From xen-devel-bounces@lists.xenproject.org Sun May 01 00:41:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 00:41:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318254.537931 (Exim 4.92) (envelope-from ) id 1nkxeO-0002dc-Q4; Sun, 01 May 2022 00:41:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318254.537931; Sun, 01 May 2022 00:41:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxeO-0002dV-N7; Sun, 01 May 2022 00:41:24 +0000 Received: by outflank-mailman (input) for mailman id 318254; Sun, 01 May 2022 00:41:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxeM-0002dL-R5; Sun, 01 May 2022 00:41:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxeM-0005gB-N6; Sun, 01 May 2022 00:41:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxeM-0004oe-B4; Sun, 01 May 2022 00:41:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nkxeM-0006CA-Ac; Sun, 01 May 2022 00:41:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VcS1CA5VRn0VmGcKzic123ewMNDlhCl39tWCotFt68g=; b=6Yl0kbctWTORXUEk6AmTOR5uA1 Bcm3szj5aiWw6GrK8AV9QMKT8eKb7bYaYBrnlg8hVBbqF7x8OL6LjQ2lqbtDyrjDmPOM43+hwDSKV mmm9MaOkGoy/YyTv74KqL26L85G8nF7KLYB5azDX+GHWuuQmsW+HYVytogzNXSz1AHiA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 169918: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=57ae8a492116910bad2b3497ffe555b3a4b4180f X-Osstest-Versions-That: linux=8013d1d3d2e33236dee13a133fba49ad55045e79 From: osstest service owner Date: Sun, 01 May 2022 00:41:22 +0000 flight 169918 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169918/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169902 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169902 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169902 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169902 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169902 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169902 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169902 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169902 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 57ae8a492116910bad2b3497ffe555b3a4b4180f baseline version: linux 8013d1d3d2e33236dee13a133fba49ad55045e79 Last test of basis 169902 2022-04-30 07:31:43 Z 0 days Testing same since 169918 2022-04-30 17:39:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alessandro Astone Alex Elder Borislav Petkov Bruno Thomsen Christophe JAILLET Christophe Leroy Dan Carpenter Dan Vacura Daniel Starke Daniele Palmas Darren Hart David Jeffery Evan Green Fabien Parent Fawzi Khaber Frank Wunderlich Georgi Djakov Greg Kroah-Hartman Gwendal Grignou Hangyu Hua Hans de Goede Heikki Krogerus Heiner Kallweit Henry Lin Hui Wang Jean-Baptiste Maneyrol Jirka Hladky Johan Hovold Jonathan Cameron Jose Cazarin Kees Cook Krzysztof Kozlowski Krzysztof Kozlowski Laurence Oberman Laurent Pinchart Lino Sanfilippo Linus Torvalds Lv Ruyi Maciej W. Rozycki Macpaul Lin Manivannan Sadhasivam Martin K. Petersen Mathias Nyman Miaoqian Lin Michael Hennerich Minchan Kim Nuno Sá Oliver Neukum Pawel Laszczak Peter Chen Peter Geis Ren Zhijie Rob Herring Sean Anderson Slark Xiao Stephen Boyd Sudeep Holla Sven Peter Tainping Fang Tasos Sahanidis Tejun Heo Thinh Nguyen Todd Kjos Tom Rix Tong Zhang Tony Lindgren Tony Luck Vijayavardhan Vennapusa Vinod Koul Wang Qing Wang ShaoBo Weitao Wang Weitao Wango Zhang Qilong zhangqilong Zheyu Ma Zizhuang Deng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 8013d1d3d2e3..57ae8a492116 57ae8a492116910bad2b3497ffe555b3a4b4180f -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 01 00:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 00:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318262.537942 (Exim 4.92) (envelope-from ) id 1nkxiv-0003Ko-CC; Sun, 01 May 2022 00:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318262.537942; Sun, 01 May 2022 00:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxiv-0003Kh-9H; Sun, 01 May 2022 00:46:05 +0000 Received: by outflank-mailman (input) for mailman id 318262; Sun, 01 May 2022 00:46:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxiu-0003KX-O8; Sun, 01 May 2022 00:46:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxiu-0005nD-NH; Sun, 01 May 2022 00:46:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkxiu-0004vE-Gi; Sun, 01 May 2022 00:46:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nkxiu-000738-GG; Sun, 01 May 2022 00:46:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hPuYWgPu4ZcDsKB/bGoXSCktwSWzoIuZBQA17GkvdxA=; b=zOGgwO0SbdQHSnKoeA9jGcMXCo BAORBdbaW0noPY6Q9FArMMi6l0bplCzl0WY5z9swnn1HUZZ1ph8B3z6xQJHK11D28C11aty/C9qSB WGPbYZfXiZfK3QlvcqOqurrzLS1tqFxcmC0Ezm/dXVt9aqNz8RHbp4YJsKwt5L/DMs9o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169926: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 00:46:04 +0000 flight 169926 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169926/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 60 days 725 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 01:36:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 01:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318270.537954 (Exim 4.92) (envelope-from ) id 1nkyVx-0006rx-V6; Sun, 01 May 2022 01:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318270.537954; Sun, 01 May 2022 01:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkyVx-0006rq-RX; Sun, 01 May 2022 01:36:45 +0000 Received: by outflank-mailman (input) for mailman id 318270; Sun, 01 May 2022 01:36:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkyVw-0006rg-LF; Sun, 01 May 2022 01:36:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkyVw-0004UT-JY; Sun, 01 May 2022 01:36:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkyVv-00062B-Hl; Sun, 01 May 2022 01:36:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nkyVv-0005Ob-HI; Sun, 01 May 2022 01:36:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7obYahCfoIwfGwDAzOuhyCkW4g2YABLuHe8lTnznrXs=; b=YH9gEGMTBpNJwQKjyHOQkx06Qv xlCdYWH8dKVnPdCnBHRy1jrTf+V1S5k/49hXGqSmvEM15/GYDOUqCco+4NLD3OSDCnyOIvs4j82Hq ufxRPH06fy/weOGLgH63TTT4oTRCXlTz9V6Y7XgiMJzSIlKaDOpesQoKjPogeM+vm5RA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169927: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 01:36:43 +0000 flight 169927 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169927/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 60 days 726 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 02:25:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 02:25:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318279.537965 (Exim 4.92) (envelope-from ) id 1nkzGi-0003Li-Ml; Sun, 01 May 2022 02:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318279.537965; Sun, 01 May 2022 02:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkzGi-0003La-I2; Sun, 01 May 2022 02:25:04 +0000 Received: by outflank-mailman (input) for mailman id 318279; Sun, 01 May 2022 02:25:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkzGh-0003LQ-Iz; Sun, 01 May 2022 02:25:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkzGh-00026d-G6; Sun, 01 May 2022 02:25:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nkzGg-00074A-SM; Sun, 01 May 2022 02:25:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nkzGg-0004tV-Rw; Sun, 01 May 2022 02:25:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8Og83j2LjygR9ipO9g7Y+4b5ADj6xWTNCzu/VB05Q2c=; b=Nbe1BwFIqOoCRdkXeCsXrYAPQh z2YzFfvZZOv2LFxoqGvk8O3QL83Q/b4+MlCc4SSkVlG6fMr09hfVxah1Jn1hdaIBEYGSu5weaMpJb HSnqtjhM1UGSpWu3UPVUZ7QKnAGxK8PlIKsKV6r/GffgccRnJDvxtFWphrrf8citm26o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169928: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 02:25:02 +0000 flight 169928 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 727 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 03:33:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 03:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318287.537976 (Exim 4.92) (envelope-from ) id 1nl0Kx-00027K-Kl; Sun, 01 May 2022 03:33:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318287.537976; Sun, 01 May 2022 03:33:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl0Kx-00027C-Eh; Sun, 01 May 2022 03:33:31 +0000 Received: by outflank-mailman (input) for mailman id 318287; Sun, 01 May 2022 03:33:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl0Kw-000272-Nt; Sun, 01 May 2022 03:33:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl0Kw-0003Gv-JY; Sun, 01 May 2022 03:33:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl0Kv-0000VV-3c; Sun, 01 May 2022 03:33:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl0Kv-00015f-38; Sun, 01 May 2022 03:33:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hl+8T35Rdw+sf+vfzQX8q2kjDZl/Ejczv1UBjzCrebo=; b=N3To7zLcp9O9yW55VIukcSXWbb V50cpqnVc/W0zTPWMzMuQdncXqUg7354jNlvMeqluKNKZDjAjcVdahoylqiLYIhSFa6LrHLq3qRhW dirgeemOgkyQqsC++blqsJYGqNXB4nrpGSVC387Pe8Ln4aa13Q5TM/tu4PCVU9m+wn40=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169930: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 03:33:29 +0000 flight 169930 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169930/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 728 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 04:57:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 04:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318295.537987 (Exim 4.92) (envelope-from ) id 1nl1dU-00024m-Ox; Sun, 01 May 2022 04:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318295.537987; Sun, 01 May 2022 04:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl1dU-00024K-Gn; Sun, 01 May 2022 04:56:44 +0000 Received: by outflank-mailman (input) for mailman id 318295; Sun, 01 May 2022 04:56:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl1dT-00024A-2h; Sun, 01 May 2022 04:56:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl1dS-0004tV-Qs; Sun, 01 May 2022 04:56:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl1dR-00059q-Pb; Sun, 01 May 2022 04:56:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl1dR-0000qI-OT; Sun, 01 May 2022 04:56:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DHI+d6Fd9Avpr93rYlBuss8mzqC30gl1r3s3dCAmZ+g=; b=ncNwu4ydl4LhZb58yX3O5WHUhX S6RAlTkXk6/rTHRn0/8KRhZ0sJsWcpJjrpfDtlVmOpBdWM4glt3TSmjlbRqr9fl5iYcfIlPOsUbg5 /1DUdGK38VwHbjrd8acx6HkDvNMPG7kTwABocGBFWoo2wYMslWCqWUsYyJK7lHo7sIY0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169931: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 04:56:41 +0000 flight 169931 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169931/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 729 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 06:07:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 06:07:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318303.537998 (Exim 4.92) (envelope-from ) id 1nl2jY-0001QC-Nz; Sun, 01 May 2022 06:07:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318303.537998; Sun, 01 May 2022 06:07:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl2jY-0001Q5-K2; Sun, 01 May 2022 06:07:04 +0000 Received: by outflank-mailman (input) for mailman id 318303; Sun, 01 May 2022 06:07:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl2jX-0001Pv-Qn; Sun, 01 May 2022 06:07:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl2jX-0006WI-OO; Sun, 01 May 2022 06:07:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl2jX-00085d-Bp; Sun, 01 May 2022 06:07:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl2jX-0002Qj-B4; Sun, 01 May 2022 06:07:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L/b9LU7aMGG+NbdUVFTvGA2sIPsDC65I5amX1KjfctA=; b=ImcG6liklveDesCMGw40zHQFkw gNbN1/opFmkVhcf+Qez2lHWkYVDpiOI+gYotMdK7urt+JMkw6L58z49BvFhabW8MVY6A4i47og8Ow 3TcNK4ok+uDpAptXupFrao8MEgbuybTlsHupRjeDCOeN3adDI+oanj+GjAxP8dZlAh+0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169933: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 06:07:03 +0000 flight 169933 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169933/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 730 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 06:32:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 06:32:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318312.538008 (Exim 4.92) (envelope-from ) id 1nl38B-0004nl-Sc; Sun, 01 May 2022 06:32:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318312.538008; Sun, 01 May 2022 06:32:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl38B-0004ne-Pr; Sun, 01 May 2022 06:32:31 +0000 Received: by outflank-mailman (input) for mailman id 318312; Sun, 01 May 2022 06:32:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl38A-0004nU-R7; Sun, 01 May 2022 06:32:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl38A-0006xs-O9; Sun, 01 May 2022 06:32:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl38A-0001eA-DC; Sun, 01 May 2022 06:32:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl38A-0000si-Cg; Sun, 01 May 2022 06:32:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wdcEPfAVxAVN+qIPDtJkygj2Q+0Os1tRNEyZ6Q4KCwo=; b=JTG/yBi96iX9OCelJ14KEltHlk is7BXUdien5zGKVrdGZLHT0GC59iJtNqm+I8eSyx1Uf0/tBPP3qQkeTq3gT9FqP7q9firtaVMumFk azpLdn+IMGDjEHGZahyehpQJwDldCoQW93LyzcdDTaQxMidh110vMxvWfJcejZ7ajpEQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169934: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 06:32:30 +0000 flight 169934 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169934/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 731 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 07:01:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 07:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318320.538020 (Exim 4.92) (envelope-from ) id 1nl3aD-0008B8-6V; Sun, 01 May 2022 07:01:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318320.538020; Sun, 01 May 2022 07:01:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl3aD-0008B1-2Z; Sun, 01 May 2022 07:01:29 +0000 Received: by outflank-mailman (input) for mailman id 318320; Sun, 01 May 2022 07:01:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl3aB-0008Ar-Vb; Sun, 01 May 2022 07:01:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl3aB-0007Tz-SJ; Sun, 01 May 2022 07:01:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl3aB-0002so-CU; Sun, 01 May 2022 07:01:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl3aB-0003Im-Bz; Sun, 01 May 2022 07:01:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BD45du8aQ7LGMpYcR+AnxjgHWalIMT8b32AEHblBYmw=; b=hwq3k5wvivoVu9QVjTE7R1djRZ twpimNNMyjsdUdSTHUJW6BXRnsMpoThN2UA0f3eq90nM/VbIBrGVDxMxVSEYLYbtdTZiUA3f5ARks bWENP8Y3XDcB9WFkbs/hPQDrT0yFhnZtKeJgFP+ah1Rh+Yi4SzNTy42f5ESCIVGKV5HA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169935: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 07:01:27 +0000 flight 169935 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169935/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 732 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 07:31:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 07:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318330.538030 (Exim 4.92) (envelope-from ) id 1nl42j-00037j-Cv; Sun, 01 May 2022 07:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318330.538030; Sun, 01 May 2022 07:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl42j-00037c-A2; Sun, 01 May 2022 07:30:57 +0000 Received: by outflank-mailman (input) for mailman id 318330; Sun, 01 May 2022 07:30:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl42h-00037S-FI; Sun, 01 May 2022 07:30:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl42h-0007yQ-Cl; Sun, 01 May 2022 07:30:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl42g-00047D-Ve; Sun, 01 May 2022 07:30:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl42g-0003qr-VA; Sun, 01 May 2022 07:30:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+F0/a0z1HOMdmQNhQcxHNWszosUghNE0VDsD91eJxv8=; b=Qp5RI1I0W1/M6vNO39K7oT2EWl PU+szFDNpcAu0lM8ZRB4os+Qhjtsfd9WKmfVuy2SkLk4J4FeIAAgkr0g2h9k9L9+3gA24k1ESXhzY zk/hmcwGWH9TvfpHcsfJsXmOLioVAvNzOFMEWqJOTBADyHwt1KbrAHfhFHRLwYk4lFm4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 169932: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d0289cfa0e77f5db524393802eb5c58216b38db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 01 May 2022 07:30:54 +0000 flight 169932 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169932/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt d0289cfa0e77f5db524393802eb5c58216b38db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 660 days Failing since 151818 2020-07-11 04:18:52 Z 659 days 641 attempts Testing same since 169897 2022-04-30 04:20:04 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106203 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 07:31:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 07:31:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318336.538042 (Exim 4.92) (envelope-from ) id 1nl436-0003WW-Q3; Sun, 01 May 2022 07:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318336.538042; Sun, 01 May 2022 07:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl436-0003WN-Ml; Sun, 01 May 2022 07:31:20 +0000 Received: by outflank-mailman (input) for mailman id 318336; Sun, 01 May 2022 07:31:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl435-0003W2-TR; Sun, 01 May 2022 07:31:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl435-0007yx-Sb; Sun, 01 May 2022 07:31:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl435-00047e-Io; Sun, 01 May 2022 07:31:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl435-0003st-IO; Sun, 01 May 2022 07:31:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f2+pzcFAJHbXZMX7Xa8nqHLw7IvomUQ2CCTKa+WtEZ4=; b=DTnqEaxl3jt1rvLFbwmY6VGztj 40bEz/6ida7OonXNhaOxSQevgatpQsxUA4hVIYZqPSM/C3nbFApWbzCIgZJxoXZMqRyJ3VzFe78rN QcEzdbCSwB1TM7e6nxfmDWNr3WkMHnvnzqt32asTj0Nx9RQhlO/6lwcb9tFkceop2O/0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169936: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 07:31:19 +0000 flight 169936 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169936/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 733 attempts Testing same since 169904 2022-04-30 08:10:33 Z 0 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 08:16:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 08:16:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318356.538061 (Exim 4.92) (envelope-from ) id 1nl4ko-0000VP-UY; Sun, 01 May 2022 08:16:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318356.538061; Sun, 01 May 2022 08:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl4ko-0000VI-RG; Sun, 01 May 2022 08:16:30 +0000 Received: by outflank-mailman (input) for mailman id 318356; Sun, 01 May 2022 08:16:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl4kn-0000V8-Lh; Sun, 01 May 2022 08:16:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl4kn-0000tK-Kv; Sun, 01 May 2022 08:16:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl4kn-0005je-9w; Sun, 01 May 2022 08:16:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl4kn-0007fa-9T; Sun, 01 May 2022 08:16:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JXQItLUVQi0fSmf8RbzMN1PcKAmkWy4Ysdni517qusY=; b=S9ukiOyuFYnFTWDVBU1K0fhIyX qqBAumzix4O8MDmuNbB5Sst08fm3MsO+ZWr3DFDPA0Icju0kESZHmGQ/WWnewL3Suu7Yr0dUqzNhv aiYEJ2vVgzhxkEyAAtb8eRDVnAqXHbyl9Pttrbim6lfZn9ct9PHCIvyLtzE4rVd0Ofgs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169937: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 08:16:29 +0000 flight 169937 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169937/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 734 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 09:03:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 09:03:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318369.538084 (Exim 4.92) (envelope-from ) id 1nl5Tu-0005pc-NS; Sun, 01 May 2022 09:03:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318369.538084; Sun, 01 May 2022 09:03:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5Tu-0005pV-KI; Sun, 01 May 2022 09:03:06 +0000 Received: by outflank-mailman (input) for mailman id 318369; Sun, 01 May 2022 09:03:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5Tt-0005pL-LP; Sun, 01 May 2022 09:03:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5Tt-0001fq-HM; Sun, 01 May 2022 09:03:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5Tt-0006xe-7u; Sun, 01 May 2022 09:03:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl5Tt-0004OL-7T; Sun, 01 May 2022 09:03:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ShGXcUOi4hrxsYGXJAeOVe/9CF3XoXGvwP3zCLIMvCw=; b=mlng9gviyEWqU2+wkYzcujlEzh sOddWU9a88bNmYC0XMuJzNu53/p6Y9yD/KUsgt6GVlmq87J8m3I77SvSb0wx02plaU8uUumpiE7qa EuKHO6z2QTQL2Uem7MBwxJan5EO3jmRFEHN3PAW5/yQAoiJ/IqqW+C9n6fuJ3zjGE8a4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 169929: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd X-Osstest-Versions-That: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd From: osstest service owner Date: Sun, 01 May 2022 09:03:05 +0000 flight 169929 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169929/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169912 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169912 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169912 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169912 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 169912 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 169912 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169912 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169912 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169912 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169912 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169912 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169912 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd baseline version: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd Last test of basis 169929 2022-05-01 01:52:13 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 01 09:03:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 09:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318372.538096 (Exim 4.92) (envelope-from ) id 1nl5U6-00068n-3z; Sun, 01 May 2022 09:03:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318372.538096; Sun, 01 May 2022 09:03:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5U6-00068g-06; Sun, 01 May 2022 09:03:18 +0000 Received: by outflank-mailman (input) for mailman id 318372; Sun, 01 May 2022 09:03:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5U5-00068F-0e; Sun, 01 May 2022 09:03:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5U4-0001fz-Td; Sun, 01 May 2022 09:03:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5U4-0006xw-M3; Sun, 01 May 2022 09:03:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl5U4-0004Oo-Ld; Sun, 01 May 2022 09:03:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=iBpQkDdWX5A7nn0F/D+QzBR8Po1GQ27DXVaaCMiYo/I=; b=QZzqLxXg9RfkuMhqCgifvZ7Q4W 4I6bHDQwhU7mKazOnkMXy7iB/X7kfWq3+BfniI1taA7YQxiJAHSwSfCMgFKLXXYGt1a7yETdiR3fP oaUjOYNMesIIbyh1tqp5FcroYiofjMe6xTgmGOkyvgWoZpHU6oJiuB0KZ7mEcUhgQU1Q=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-amd64-xsm Message-Id: From: osstest service owner Date: Sun, 01 May 2022 09:03:16 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168274/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build --summary-out=tmp/169942.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-amd64-xsm xen-build Searching for failure / basis pass: 169937 fail [host=himrod1] / 168254 [host=himrod2] 168249 [host=himrod2] 168232 ok. Failure / basis pass flights: 169937 / 168232 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd Basis pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8-cabd96ad03603a63a97e701fb30a03341ca0e2ec git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#829b0f1a7cda1bccdf44a379fb3a96e519a7e8\ cd-01774004c7f7fdc9c1e8f1715f70d3b913f8d491 git://xenbits.xen.org/xen.git#9ba4c529985a1773852069889a5b53f2ed26c408-fe234237b6fc8afc5d8265850169ceeb3d2f81fd Loaded 12651 nodes in revision graph Searching for test results: 168232 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168249 [host=himrod2] 168254 [host=himrod2] 168258 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168259 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 168260 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168263 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 1449f6873d7dd477ba110b415ca08a3c2553451e 168265 pass de463163d9f6d3c5dc6b55ff35d1e5676e0e1b9f 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168262 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168266 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168268 fail 7bc8b1d9f412507d579f21ea9af56fced81e7827 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168267 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168269 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168270 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168272 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168273 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168274 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168271 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168285 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168290 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168295 [host=himrod2] 168299 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168303 [host=himrod2] 168308 [host=himrod2] 168312 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd e0a514d2f4b2fcb51835aa9a9b02653b491a61fc 168314 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd e0a514d2f4b2fcb51835aa9a9b02653b491a61fc 168316 fail irrelevant 168320 fail irrelevant 168329 [host=himrod2] 168333 [host=himrod2] 168340 fail irrelevant 168344 [host=himrod2] 168352 [host=himrod2] 168356 [host=himrod2] 168359 [host=himrod2] 168364 [host=himrod2] 168366 [host=himrod2] 168372 [host=himrod2] 168377 [host=himrod2] 168381 [host=himrod2] 168385 fail irrelevant 168387 fail irrelevant 168389 fail irrelevant 168392 fail irrelevant 168395 [host=himrod2] 168397 fail irrelevant 168401 fail irrelevant 168402 fail irrelevant 168404 fail irrelevant 168405 fail irrelevant 168407 fail irrelevant 168408 [host=himrod2] 168411 fail irrelevant 168415 fail irrelevant 168416 fail irrelevant 168418 [host=himrod2] 168419 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168421 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168422 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168424 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168425 [host=himrod2] 168426 [host=himrod2] 168427 [host=himrod2] 168430 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168431 [host=himrod2] 168433 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168436 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168438 [host=himrod2] 168439 [host=himrod2] 168440 [host=himrod2] 168441 [host=himrod2] 168443 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168444 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168445 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168446 [host=himrod2] 168447 [host=himrod2] 168449 [host=himrod2] 168451 [host=himrod2] 168453 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168455 [host=himrod2] 168456 [host=himrod2] 168457 [host=himrod2] 168458 [host=himrod2] 168459 [host=himrod2] 168461 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168462 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168464 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168468 [host=himrod2] 168469 [host=himrod2] 168472 fail irrelevant 168475 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168477 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168478 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168479 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168489 [host=himrod2] 168490 fail irrelevant 168496 fail irrelevant 168504 [host=himrod2] 168508 fail irrelevant 168512 fail irrelevant 168519 fail irrelevant 168521 fail irrelevant 168524 [host=himrod2] 168525 [host=himrod2] 168526 [host=himrod2] 168530 [host=himrod2] 168532 fail irrelevant 168533 fail irrelevant 168534 fail irrelevant 168535 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168536 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168538 [host=himrod2] 168539 [host=himrod2] 168541 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168542 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168543 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168544 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168546 [host=himrod2] 168548 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168550 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168551 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168552 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168553 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168554 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168555 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168556 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168557 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168558 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168559 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168560 [host=himrod2] 168561 [host=himrod2] 168562 [host=himrod2] 168564 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168565 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168566 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168567 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168568 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168569 [host=himrod2] 168570 [host=himrod2] 168572 [host=himrod2] 168574 [host=himrod2] 168576 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168578 [host=himrod2] 168579 [host=himrod2] 168581 [host=himrod2] 168583 [host=himrod2] 168584 [host=himrod2] 168587 [host=himrod2] 168588 [host=himrod2] 168602 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168606 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168609 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168610 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168614 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168616 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168617 fail irrelevant 168618 [host=himrod2] 168622 fail irrelevant 168623 fail irrelevant 168625 fail irrelevant 168627 fail irrelevant 168634 fail 33438f7354af9c04cb296fb15a7a79c2c3944c0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168629 [host=himrod2] 168635 [host=himrod2] 168637 [host=himrod2] 168639 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168640 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168645 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168648 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168651 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168653 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168661 [host=himrod2] 168663 [host=himrod2] 168664 [host=himrod2] 168668 fail irrelevant 168670 fail irrelevant 168672 fail irrelevant 168673 fail irrelevant 168675 fail irrelevant 168678 fail irrelevant 168679 fail irrelevant 168680 fail irrelevant 168682 fail irrelevant 168683 fail irrelevant 168685 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168686 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168687 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168688 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168689 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168690 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168692 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168693 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168694 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168695 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168697 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168698 [host=himrod2] 168702 [host=himrod2] 168703 [host=himrod2] 168707 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168708 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168710 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168728 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168713 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168717 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168721 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168723 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168725 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168727 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168729 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168730 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168731 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168732 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168734 [host=himrod2] 168735 [host=himrod2] 168736 [host=himrod2] 168738 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168739 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168741 [host=himrod2] 168745 [host=himrod2] 168746 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168747 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168748 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168749 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168751 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168752 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168753 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168754 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168757 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168758 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168759 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168762 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168766 [host=himrod2] 168770 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168774 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168777 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168779 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168780 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168783 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168785 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168788 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168789 [host=himrod2] 168790 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168793 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168799 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168801 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168804 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168805 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168806 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168808 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168812 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168813 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168814 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168817 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168819 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168820 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168822 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168823 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168824 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168826 [host=himrod2] 168827 [host=himrod2] 168829 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168831 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168832 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168834 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168837 [host=himrod2] 168844 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168854 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168858 [host=himrod0] 168859 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168865 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168981 [host=himrod0] 169004 [host=himrod2] 169046 [host=himrod2] 169069 [host=himrod2] 169102 fail 55637a2894babca97945eeca1da0d431f74f8627 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8eec96b7b8d937d40e2e7988edb8bbd08598c715 169117 [host=himrod2] 169128 [host=himrod2] 169135 fail irrelevant 169141 [host=himrod2] 169144 [host=himrod2] 169148 [host=himrod2] 169150 [host=himrod2] 169153 fail 3e130e40fc55f06f7fe019e87ed9bae957870a12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db d62a34423a1a98aefd7c30e22d2d82d198f077c8 169156 [host=himrod2] 169161 [host=himrod2] 169165 [host=himrod2] 169169 fail irrelevant 169173 [host=himrod2] 169177 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169187 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169196 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169202 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169209 [host=himrod2] 169218 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 14dd241aad8af447680ac73e8579990e2c09c1e7 169223 [host=himrod2] 169226 fail irrelevant 169227 fail irrelevant 169229 [host=himrod0] 169232 fail irrelevant 169234 [host=himrod0] 169235 [host=himrod2] 169242 [host=himrod2] 169247 [host=himrod2] 169248 fail irrelevant 169258 fail irrelevant 169263 [host=himrod2] 169265 fail irrelevant 169266 fail irrelevant 169271 fail irrelevant 169272 [host=himrod0] 169274 [host=himrod2] 169275 [host=himrod2] 169277 [host=himrod2] 169278 [host=himrod2] 169279 [host=himrod2] 169280 [host=himrod0] 169281 [host=himrod0] 169282 [host=himrod0] 169283 [host=himrod0] 169293 [host=himrod0] 169285 [host=himrod0] 169287 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169288 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169289 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169290 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169291 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169295 [host=himrod2] 169297 [host=himrod2] 169299 [host=himrod2] 169300 [host=himrod0] 169302 [host=himrod0] 169305 [host=himrod0] 169306 [host=himrod0] 169307 [host=himrod0] 169308 [host=himrod0] 169310 [host=himrod0] 169311 fail irrelevant 169312 fail irrelevant 169313 fail irrelevant 169314 fail irrelevant 169315 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169316 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169317 [host=himrod0] 169319 [host=himrod0] 169321 [host=himrod0] 169323 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169324 fail irrelevant 169325 fail irrelevant 169326 [host=himrod0] 169327 [host=himrod0] 169329 [host=himrod0] 169331 fail irrelevant 169334 [host=himrod2] 169335 [host=himrod2] 169338 fail irrelevant 169339 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169341 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169342 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169343 [host=himrod2] 169344 [host=himrod2] 169345 [host=himrod2] 169349 [host=himrod2] 169350 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169352 [host=himrod0] 169357 [host=himrod0] 169358 [host=himrod0] 169359 [host=himrod0] 169360 [host=himrod2] 169362 [host=himrod2] 169363 [host=himrod2] 169364 [host=himrod2] 169365 [host=himrod2] 169366 [host=himrod2] 169370 [host=himrod0] 169371 [host=himrod0] 169372 [host=himrod0] 169374 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169375 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169376 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169377 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169378 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169379 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169380 fail irrelevant 169381 fail irrelevant 169382 fail 8a5727c7a82a371649419daddc2c52554ff29b16 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169384 fail 8a5727c7a82a371649419daddc2c52554ff29b16 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169385 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169387 [host=himrod0] 169388 [host=himrod0] 169389 [host=himrod0] 169390 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169391 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169392 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169393 [host=himrod2] 169394 [host=himrod2] 169395 [host=himrod2] 169396 [host=himrod2] 169397 [host=himrod2] 169398 [host=himrod2] 169399 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169400 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169401 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169402 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169404 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169405 fail irrelevant 169406 fail irrelevant 169407 fail irrelevant 169408 fail irrelevant 169410 fail irrelevant 169411 fail irrelevant 169413 fail irrelevant 169414 fail irrelevant 169416 fail irrelevant 169417 fail irrelevant 169418 fail irrelevant 169419 fail irrelevant 169420 fail irrelevant 169421 fail irrelevant 169422 fail irrelevant 169424 fail irrelevant 169425 fail irrelevant 169427 fail irrelevant 169428 [host=himrod2] 169429 [host=himrod2] 169430 [host=himrod2] 169431 [host=himrod2] 169432 [host=himrod2] 169435 fail irrelevant 169436 fail irrelevant 169437 fail irrelevant 169438 [host=himrod0] 169439 [host=himrod0] 169440 [host=himrod0] 169441 [host=himrod0] 169443 [host=himrod0] 169445 fail irrelevant 169446 fail irrelevant 169448 fail irrelevant 169449 fail irrelevant 169450 fail irrelevant 169451 fail irrelevant 169452 [host=himrod0] 169453 [host=himrod0] 169454 [host=himrod0] 169455 [host=himrod0] 169456 [host=himrod0] 169457 [host=himrod0] 169458 [host=himrod0] 169459 fail irrelevant 169460 fail irrelevant 169461 fail irrelevant 169462 fail irrelevant 169463 fail irrelevant 169464 fail irrelevant 169465 fail irrelevant 169467 fail irrelevant 169468 fail irrelevant 169469 fail irrelevant 169470 fail irrelevant 169471 fail irrelevant 169473 fail irrelevant 169476 fail irrelevant 169478 fail irrelevant 169479 fail irrelevant 169480 fail irrelevant 169481 fail irrelevant 169512 [host=himrod0] 169482 fail irrelevant 169484 [host=himrod0] 169485 [host=himrod0] 169486 [host=himrod0] 169487 [host=himrod0] 169489 [host=himrod0] 169490 fail irrelevant 169491 fail irrelevant 169492 fail irrelevant 169494 fail irrelevant 169496 fail irrelevant 169497 fail irrelevant 169498 fail irrelevant 169500 [host=himrod0] 169501 fail irrelevant 169503 fail irrelevant 169504 fail irrelevant 169505 fail irrelevant 169506 fail irrelevant 169508 [host=himrod2] 169509 [host=himrod2] 169510 [host=himrod2] 169511 [host=himrod0] 169513 [host=himrod0] 169514 [host=himrod0] 169515 [host=himrod0] 169516 [host=himrod0] 169517 [host=himrod0] 169518 fail irrelevant 169519 fail irrelevant 169520 fail irrelevant 169521 [host=himrod0] 169522 [host=himrod0] 169523 [host=himrod0] 169524 [host=himrod0] 169525 [host=himrod0] 169526 [host=himrod0] 169527 [host=himrod0] 169529 [host=himrod2] 169530 fail irrelevant 169532 fail irrelevant 169533 [host=himrod2] 169534 [host=himrod2] 169535 [host=himrod2] 169536 [host=himrod0] 169538 [host=himrod0] 169539 [host=himrod0] 169540 fail irrelevant 169542 fail irrelevant 169543 fail irrelevant 169544 fail irrelevant 169548 fail irrelevant 169549 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169551 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169553 [host=himrod2] 169554 [host=himrod2] 169556 [host=himrod0] 169558 [host=himrod0] 169559 [host=himrod0] 169561 [host=himrod0] 169564 [host=himrod2] 169567 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2ce9afd68e0bacc15b5570a983fa626cc4de9dbd 169568 fail irrelevant 169569 fail irrelevant 169571 [host=himrod2] 169574 [host=himrod2] 169585 [host=himrod0] 169575 [host=himrod2] 169578 [host=himrod2] 169579 [host=himrod2] 169580 [host=himrod2] 169582 fail irrelevant 169583 fail irrelevant 169586 [host=himrod2] 169587 [host=himrod2] 169588 [host=himrod2] 169589 [host=himrod0] 169590 [host=himrod0] 169592 [host=himrod0] 169593 [host=himrod2] 169594 [host=himrod2] 169596 [host=himrod2] 169597 [host=himrod2] 169598 [host=himrod2] 169599 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169600 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169602 [host=himrod0] 169604 [host=himrod2] 169606 [host=himrod2] 169607 [host=himrod2] 169610 [host=himrod2] 169612 fail irrelevant 169615 [host=himrod0] 169618 [host=himrod0] 169620 [host=himrod0] 169621 [host=himrod0] 169623 fail irrelevant 169625 [host=himrod0] 169626 fail irrelevant 169628 fail irrelevant 169631 [host=himrod0] 169632 [host=himrod0] 169633 [host=himrod0] 169634 [host=himrod0] 169636 [host=himrod0] 169637 fail irrelevant 169639 fail irrelevant 169641 [host=himrod2] 169642 [host=himrod2] 169643 [host=himrod2] 169644 [host=himrod2] 169646 fail irrelevant 169647 fail irrelevant 169648 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169649 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169650 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169651 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169653 [host=himrod2] 169655 [host=himrod2] 169656 [host=himrod2] 169657 [host=himrod2] 169658 [host=himrod2] 169659 [host=himrod2] 169660 [host=himrod2] 169678 [host=himrod2] 169661 [host=himrod2] 169663 [host=himrod0] 169665 [host=himrod0] 169667 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169668 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169670 [host=himrod2] 169672 [host=himrod2] 169673 [host=himrod0] 169674 [host=himrod0] 169675 [host=himrod0] 169676 [host=himrod0] 169677 [host=himrod2] 169679 [host=himrod2] 169680 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169681 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169682 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169683 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169684 [host=himrod2] 169685 [host=himrod2] 169687 [host=himrod2] 169688 [host=himrod2] 169689 [host=himrod2] 169690 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169691 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169692 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169693 [host=himrod0] 169695 [host=himrod0] 169697 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169698 [host=himrod2] 169700 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169701 fail 483d3bb716bfd1a90fde165a761067c50c482d4e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169702 fail 483d3bb716bfd1a90fde165a761067c50c482d4e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169703 fail 483d3bb716bfd1a90fde165a761067c50c482d4e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169704 [host=himrod2] 169705 [host=himrod2] 169706 [host=himrod2] 169707 [host=himrod2] 169708 [host=himrod2] 169709 [host=himrod2] 169710 [host=himrod2] 169711 [host=himrod2] 169712 [host=himrod2] 169713 [host=himrod2] 169715 [host=himrod2] 169716 [host=himrod2] 169718 [host=himrod2] 169719 [host=himrod2] 169721 [host=himrod2] 169722 [host=himrod2] 169724 [host=himrod2] 169726 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169728 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169730 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169731 [host=himrod2] 169732 [host=himrod2] 169733 [host=himrod2] 169734 [host=himrod2] 169735 [host=himrod2] 169738 [host=himrod2] 169740 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169742 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169744 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169746 [host=himrod2] 169750 [host=himrod2] 169754 [host=himrod2] 169757 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169758 [host=himrod2] 169759 [host=himrod2] 169761 [host=himrod2] 169763 [host=himrod0] 169764 [host=himrod0] 169766 [host=himrod2] 169769 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169770 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169772 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169776 [host=himrod2] 169778 [host=himrod2] 169780 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169783 [host=himrod0] 169784 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169786 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169791 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169793 [host=himrod0] 169796 [host=himrod0] 169797 [host=himrod0] 169799 [host=himrod0] 169802 [host=himrod0] 169803 [host=himrod2] 169804 [host=himrod2] 169806 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169808 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169810 [host=himrod0] 169811 [host=himrod0] 169812 [host=himrod0] 169814 [host=himrod0] 169815 [host=himrod0] 169816 [host=himrod0] 169821 [host=himrod2] 169828 [host=himrod2] 169832 [host=himrod2] 169835 [host=himrod2] 169837 [host=himrod0] 169839 [host=himrod0] 169841 fail irrelevant 169842 fail irrelevant 169845 fail irrelevant 169848 [host=himrod0] 169854 [host=himrod2] 169858 fail irrelevant 169865 [host=himrod2] 169866 fail irrelevant 169868 fail irrelevant 169872 fail irrelevant 169873 fail irrelevant 169874 [host=himrod0] 169878 [host=himrod0] 169879 [host=himrod0] 169880 [host=himrod0] 169882 [host=himrod0] 169883 [host=himrod0] 169885 [host=himrod0] 169889 [host=himrod2] 169892 fail irrelevant 169894 fail irrelevant 169901 [host=himrod0] 169904 fail irrelevant 169908 fail irrelevant 169905 fail irrelevant 169910 fail irrelevant 169913 [host=himrod2] 169914 [host=himrod2] 169915 [host=himrod2] 169916 [host=himrod2] 169917 [host=himrod0] 169919 [host=himrod2] 169920 [host=himrod2] 169921 [host=himrod2] 169922 [host=himrod2] 169923 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169924 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169925 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169926 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169927 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169928 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169930 [host=himrod0] 169931 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169933 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169934 [host=himrod0] 169935 [host=himrod0] 169936 [host=himrod0] 169938 [host=himrod0] 169937 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169939 [host=himrod0] 169940 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 9ba4c529985a1773852069889a5b53f2ed26c408 169942 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd Searching for interesting versions Result found: flight 168232 (pass), for basis pass Result found: flight 169315 (fail), for basis failure (at ancestor ~126) Repro found: flight 169940 (pass), for basis pass Repro found: flight 169942 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 168266 (pass), for last pass Result found: flight 168269 (fail), for first failure Repro found: flight 168270 (pass), for last pass Repro found: flight 168272 (fail), for first failure Repro found: flight 168273 (pass), for last pass Repro found: flight 168274 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/168274/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu Revision graph left in /home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 169942: tolerable ALL FAIL flight 169942 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/169942/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-xsm 6 xen-build fail baseline untested jobs: build-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun May 01 09:15:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 09:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318387.538106 (Exim 4.92) (envelope-from ) id 1nl5fM-000869-CR; Sun, 01 May 2022 09:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318387.538106; Sun, 01 May 2022 09:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5fM-000862-9a; Sun, 01 May 2022 09:14:56 +0000 Received: by outflank-mailman (input) for mailman id 318387; Sun, 01 May 2022 09:14:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5fK-00085s-H5; Sun, 01 May 2022 09:14:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5fK-0001ua-Cl; Sun, 01 May 2022 09:14:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl5fK-0007Dh-5n; Sun, 01 May 2022 09:14:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl5fK-00074R-5K; Sun, 01 May 2022 09:14:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QcYrdKy6mt3IZsvt9Np3s2MYBnDSpf292KFE9sdzwd8=; b=ang+r1pVZbyC8rvoTLHbdMQyHT F7d5xRN0NlYqic4gWWY3t93z7Jtbbkr0aRd3tv1SjRoqmm/ZGT6O0ER3UrTGckXZyD8YGlenJCv/4 s7avl0SefhOJph+jDNtazyhQSAyEG53Y267h4Q3vFPh/ha+FPiiEPjk+8D1NDWhupT/U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169941: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 09:14:54 +0000 flight 169941 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169941/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 735 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 10:02:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 10:02:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318395.538118 (Exim 4.92) (envelope-from ) id 1nl6PU-00051s-2j; Sun, 01 May 2022 10:02:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318395.538118; Sun, 01 May 2022 10:02:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6PT-00051l-Vu; Sun, 01 May 2022 10:02:35 +0000 Received: by outflank-mailman (input) for mailman id 318395; Sun, 01 May 2022 10:02:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6PT-00051b-4A; Sun, 01 May 2022 10:02:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6PT-0002ma-1f; Sun, 01 May 2022 10:02:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6PS-0008Ff-Hb; Sun, 01 May 2022 10:02:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl6PS-0001cZ-H9; Sun, 01 May 2022 10:02:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2eTgV2ryzkOYqARE1MVYtlxS8SFPB9ZJr4+T5rE7WEM=; b=5+hFYAwMu1pSN/MxViV+wvThNj YIiyJe1eN3qLPH/yFXEjd1MnH0u+ZoOtH8ajmqmOnZnaj/isSHj01g6dI4H672d87Xxo2SOo/qe6B sp0glWO4ej0OuuCsdxZm/pefP8FeuZYsVxS1FpxnEjFVh+qEoyiXWVXHoxCRnfW1vGIY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169943: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 10:02:34 +0000 flight 169943 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169943/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 736 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 10:31:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 10:31:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318403.538129 (Exim 4.92) (envelope-from ) id 1nl6qn-0008KX-CJ; Sun, 01 May 2022 10:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318403.538129; Sun, 01 May 2022 10:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6qn-0008KQ-8k; Sun, 01 May 2022 10:30:49 +0000 Received: by outflank-mailman (input) for mailman id 318403; Sun, 01 May 2022 10:30:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6ql-0008KG-S0; Sun, 01 May 2022 10:30:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6ql-0003GS-QB; Sun, 01 May 2022 10:30:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl6ql-0000Pd-Dk; Sun, 01 May 2022 10:30:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl6ql-0000R5-DE; Sun, 01 May 2022 10:30:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+cqekWEdq6FKKPdUywWB8cyxWON48qRHW7qTmCeFp1E=; b=ayww0+X+5KBKo3Y9knCMQ3gYhm 33yxE7wf1B0rOQuSUNfCnbI8gTH/FF4KXcf8DF8taJ3NLKAE/z4CRtuFuZYsDjADNrFAjap/6Z7Cy jkl27jnOlGd5XKvTXniRGWYXcMrmiWh83mRazYSW5HIbaKUgHpWhRuNcyCNiGhXA5Lno=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169944: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 10:30:47 +0000 flight 169944 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169944/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 61 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 737 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 11:00:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 11:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318411.538140 (Exim 4.92) (envelope-from ) id 1nl7Jg-0003K4-Qb; Sun, 01 May 2022 11:00:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318411.538140; Sun, 01 May 2022 11:00:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl7Jg-0003Jx-NK; Sun, 01 May 2022 11:00:40 +0000 Received: by outflank-mailman (input) for mailman id 318411; Sun, 01 May 2022 11:00:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl7Jf-0003Jn-BM; Sun, 01 May 2022 11:00:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl7Jf-0003no-6i; Sun, 01 May 2022 11:00:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl7Je-00014c-Qc; Sun, 01 May 2022 11:00:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl7Je-0007wd-Q9; Sun, 01 May 2022 11:00:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EbNKt4pruKm5TGAAxI1RzAhnJqH8PQGeDIm/qtFHHuU=; b=PeSW8MBFxCyYuIHbtNKeDQjHAM pCkqgYN30h7N8uhyequhYk/aE/5G3KcprHwJJMnBKH8H8mUPiF8/7l1q5WxOE1zwFaG+Oc1HO9SER 5nSHbKhkNALiEU9M4kmjE+qT4jRYUnAuIpoCGflpNr/r76xHAWIivuEl6+exf6DFTn5M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169945: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 11:00:38 +0000 flight 169945 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169945/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 738 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 12:11:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 12:11:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318425.538166 (Exim 4.92) (envelope-from ) id 1nl8PS-0002Dv-EB; Sun, 01 May 2022 12:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318425.538166; Sun, 01 May 2022 12:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl8PS-0002Do-Ak; Sun, 01 May 2022 12:10:42 +0000 Received: by outflank-mailman (input) for mailman id 318425; Sun, 01 May 2022 12:10:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl8PR-0002De-KO; Sun, 01 May 2022 12:10:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl8PR-00051O-Ic; Sun, 01 May 2022 12:10:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl8PR-0002ab-Ao; Sun, 01 May 2022 12:10:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl8PR-0006KH-AM; Sun, 01 May 2022 12:10:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gcFqsQFhUTt2rbqgMb6JelqC6czXF1omCtEboUqzs+o=; b=6if6ZXr8L2+9Q2nl0VbGF4okLP /CMVvPTz6sztPfEX62OHA2Fl9w1mIGIQyc8Rdii5njvZIxCrFJzsZ02vXpwNE6BwxcmJggDWh6AVh aa39X6APsfts2hyGxhFZDedO0zMGFrYqLgwpuII0iqtJ0xwpX0DnsuSIPN7WQlbsAC00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169946: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 12:10:41 +0000 flight 169946 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169946/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 739 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 13:12:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 13:12:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318439.538195 (Exim 4.92) (envelope-from ) id 1nl9N0-0000Di-Eb; Sun, 01 May 2022 13:12:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318439.538195; Sun, 01 May 2022 13:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl9N0-0000Db-BW; Sun, 01 May 2022 13:12:14 +0000 Received: by outflank-mailman (input) for mailman id 318439; Sun, 01 May 2022 13:12:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl9My-0000DR-PG; Sun, 01 May 2022 13:12:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl9My-00064i-ME; Sun, 01 May 2022 13:12:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nl9My-0003vx-7j; Sun, 01 May 2022 13:12:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nl9My-0004Sj-7F; Sun, 01 May 2022 13:12:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nJ7fMufgjjJbk8Lv1KooSfPeBa4b2Oclu+YjrXj84gE=; b=Ls3iYImTO2A2a2M4AyuOMVSyL3 eCjtFqQ138c7lVUKny+t+pb6G8iXQWqWzaHa2rUcPmaglVy8R6CTdhbTIQHnI7Gaxa7OztTu820cH nYq9u3GbMJ0iYxyaxIlLpcHlxocvA4VhxC09tUr8dmjIQtvzL7FUBFId01gnTA7HoABY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169952: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 13:12:12 +0000 flight 169952 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 740 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 14:12:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 14:12:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318453.538223 (Exim 4.92) (envelope-from ) id 1nlAJN-0006gT-Bw; Sun, 01 May 2022 14:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318453.538223; Sun, 01 May 2022 14:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlAJN-0006gM-97; Sun, 01 May 2022 14:12:33 +0000 Received: by outflank-mailman (input) for mailman id 318453; Sun, 01 May 2022 14:12:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlAJM-0006gC-EL; Sun, 01 May 2022 14:12:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlAJM-0007Ak-BK; Sun, 01 May 2022 14:12:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlAJM-0005Em-2B; Sun, 01 May 2022 14:12:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlAJM-000219-1j; Sun, 01 May 2022 14:12:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FdQCGRp3IV424xkEcLtGXPVbV8NctujzM97msS7qnnc=; b=H0z5Xp2bgtGwkxydVEXqFaUGNI 5+n0NTwtreptO2F6q9acqAbprj3WQWtXoWftfynzc0XVdwJGRvQCCPSZxnHzvhAxUEX8p7t1rUJgB Ethkxgjgk8xX38s/pHDPqbWbexQa0UgJwUahWN/V1/I34Y2YjpaFu1J8D1BxwbbcOMfQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169955: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 14:12:32 +0000 flight 169955 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169955/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 741 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 15:29:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 15:29:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318470.538253 (Exim 4.92) (envelope-from ) id 1nlBVf-0005cD-Fq; Sun, 01 May 2022 15:29:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318470.538253; Sun, 01 May 2022 15:29:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlBVf-0005c6-CV; Sun, 01 May 2022 15:29:19 +0000 Received: by outflank-mailman (input) for mailman id 318470; Sun, 01 May 2022 15:29:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlBVf-0005bw-1L; Sun, 01 May 2022 15:29:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlBVe-00005g-VG; Sun, 01 May 2022 15:29:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlBVe-0006t9-K2; Sun, 01 May 2022 15:29:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlBVe-0003If-Ja; Sun, 01 May 2022 15:29:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ko8l8eHjfgSn3iLucDqXYNsvcv4rVh4Cp+Xgo+3zFFo=; b=PD/+0THt/PMzdZdl70NWg1KsMA 9KD5ubctYEBvB2wfx2WlzPteWcyDrQTjv2OnUkYWet4m9aGO/t65kKib8VZQVd0S4N9fkG7BQZKr/ 213i7SE+y13LNe+SH/ta4QJXV7B4fMQuCy7Yon0bcBOqyjvMIcjbQQCVrRFD6yQd23ng=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169960: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 15:29:18 +0000 flight 169960 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169960/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 742 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 16:26:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 16:26:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318485.538281 (Exim 4.92) (envelope-from ) id 1nlCOy-00045w-6W; Sun, 01 May 2022 16:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318485.538281; Sun, 01 May 2022 16:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCOy-00045p-3S; Sun, 01 May 2022 16:26:28 +0000 Received: by outflank-mailman (input) for mailman id 318485; Sun, 01 May 2022 16:26:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCOx-00045f-3e; Sun, 01 May 2022 16:26:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCOw-0001dl-N9; Sun, 01 May 2022 16:26:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCOw-00087f-Bj; Sun, 01 May 2022 16:26:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlCOw-0008Qt-BH; Sun, 01 May 2022 16:26:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=6EcJly4aGXNULXNcbhkss29syjnqZMxMDe6Ujzo5zlE=; b=RIA/K1QlRwX/wqQCecobMSc6TI 72V83HlVIu1GVGmcHgzD2iTOgWcGYZ+Rks3aw5wha3Pf62OS78gX9l96xYeesUjk+O1piRtV4Pd1z 1i3qytYPqdU9EsOmIQzNrPNN7UGR4OeBsZFJTVe4Pd0sWOeFOpgQfgJpAPaEBTk8s9Oo=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-amd64 Message-Id: From: osstest service owner Date: Sun, 01 May 2022 16:26:26 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169965/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/169965.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-amd64 xen-build Searching for failure / basis pass: 169960 fail [host=himrod0] / 168254 [host=himrod2] 168249 [host=himrod2] 168232 [host=himrod1] 168185 [host=himrod2] 168131 [host=himrod1] 168127 [host=himrod2] 168119 [host=himrod1] 168115 [host=himrod1] 168074 [host=himrod1] 168048 [host=himrod1] 168046 [host=godello0] 168043 [host=himrod1] 168042 [host=himrod1] 168038 [host=himrod2] 168017 [host=godello0] 167989 [host=himrod2] 167980 [host=himrod2] 167976 [host=himrod1] 167956 [host=godello0] 167950 [host=himrod1] 167946 [host=himrod1] 16794\ 0 [host=himrod2] 167933 [host=himrod1] 167929 [host=himrod2] 167919 [host=himrod2] 167907 [host=himrod1] 167803 [host=himrod1] 167775 [host=himrod2] 167760 [host=himrod2] 167754 [host=himrod2] 167729 [host=himrod1] 167727 [host=himrod1] 167689 [host=himrod2] 167685 [host=himrod1] 167651 [host=himrod1] 167636 [host=godello0] 167627 [host=himrod1] 167601 [host=himrod2] 167598 [host=godello0] 167559 [host=himrod2] 167555 [host=himrod2] 167552 [host=himrod2] 167535 [host=himrod1] 167527 [host=himrod\ 1] 167522 [host=himrod2] 167513 [host=godello1] 167487 [host=himrod1] 167465 [host=himrod1] 167463 [host=himrod2] 167450 [host=himrod1] 167445 [host=himrod2] 167436 [host=himrod1] 167419 [host=himrod1] 167414 [host=himrod1] 167409 [host=himrod1] 167394 [host=himrod1] 167393 [host=himrod1] 167392 [host=himrod1] 167391 [host=himrod2] 167379 [host=himrod1] 167377 [host=himrod2] 167239 [host=himrod1] 167237 [host=himrod1] 167231 [host=himrod2] 167225 [host=himrod2] 167122 [host=fiano0] 167104 [host=\ himrod2] 167081 [host=himrod1] 166961 [host=himrod2] 166951 [host=godello0] 166949 [host=himrod1] 166826 [host=himrod1] 166360 [host=himrod1] 166133 [host=himrod2] 166130 [host=himrod1] 166126 [host=godello0] 166123 [host=himrod1] 166120 [host=himrod2] 166114 [host=himrod1] 166108 [host=himrod1] 166105 [host=himrod1] 166102 [host=himrod1] 166097 [host=himrod1] 166093 [host=himrod1] 166090 [host=himrod2] 166087 [host=himrod2] 166083 [host=himrod2] 166081 [host=himrod2] 166063 [host=himrod2] 16604\ 2 [host=himrod1] 166035 [host=himrod1] 165969 [host=himrod2] 165962 [host=himrod2] 165950 [host=albana0] 165948 [host=himrod2] 165934 [host=himrod2] 165921 [host=himrod1] 165899 [host=himrod1] 165873 [host=himrod2] 165862 [host=himrod2] 165827 [host=himrod1] 165808 [host=himrod1] 165767 [host=himrod2] 165714 [host=himrod1] 165701 [host=himrod2] 165690 [host=himrod1] 165688 [host=himrod1] 165685 [host=himrod1] 165671 [host=himrod2] 165657 [host=himrod2] 165652 [host=himrod2] 165637 [host=himrod2]\ 165531 [host=himrod2] 165523 [host=himrod2] 165508 [host=himrod2] 165505 [host=himrod1] 165502 [host=himrod2] 165494 [host=himrod2] 165487 [host=himrod1] 165474 [host=himrod2] 165462 [host=himrod1] 165433 [host=himrod2] 165425 [host=himrod2] 165398 [host=himrod2] 165382 [host=himrod2] 165377 [host=himrod1] 165347 [host=huxelrebe1] 165321 [host=himrod2] 165200 [host=himrod2] 165175 [host=himrod1] 165170 [host=himrod2] 165155 [host=himrod2] 165151 [host=himrod1] 165113 [host=himrod2] 165108 [host\ =himrod1] 165013 [host=himrod1] 165007 [host=himrod2] 165001 [host=himrod1] 164971 [host=himrod2] 164946 [host=himrod1] 164937 [host=himrod2] 164913 [host=himrod1] 164869 [host=himrod2] 164862 [host=himrod1] 164674 [host=himrod2] 164630 [host=himrod2] 164556 [host=himrod1] 164513 [host=himrod1] 164461 [host=himrod1] 164406 [host=himrod2] 164229 [host=himrod2] 164173 [host=himrod2] 164166 [host=himrod1] 164160 [host=himrod2] 164159 [host=himrod2] 164155 [host=himrod1] 164151 [host=himrod1] 164142\ [host=himrod2] 164139 [host=himrod2] 164114 [host=himrod2] 164111 [host=himrod2] 164110 [host=himrod2] 164093 [host=himrod1] 164090 [host=himrod1] 164081 [host=himrod1] 164078 [host=himrod1] 164047 [host=himrod1] 164039 [host=himrod2] 164028 [host=himrod1] 164025 [host=himrod1] 164020 [host=himrod1] 164015 [host=himrod1] 164010 [host=himrod1] 164005 [host=himrod2] 164002 [host=himrod1] 163999 [host=himrod1] 163995 [host=himrod1] 163992 [host=himrod1] 163990 [host=himrod1] 163988 [host=himrod2] \ 163986 [host=himrod2] 163984 [host=himrod2] 163980 [host=himrod1] 163978 [host=himrod2] 163975 [host=himrod1] 163972 [host=himrod1] 163956 [host=himrod1] 163945 [host=himrod2] 163929 [host=himrod2] 163917 [host=himrod1] 163907 [host=himrod2] 163889 [host=himrod2] 163882 [host=himrod2] 163875 [host=himrod2] 163864 [host=himrod1] 163851 [host=himrod2] 163835 [host=himrod2] 163819 [host=himrod2] 163806 [host=himrod1] 163794 [host=himrod2] 163786 [host=himrod1] 163770 [host=himrod2] 163756 [host=him\ rod1] 163729 [host=himrod1] 163712 [host=himrod1] 163691 [host=himrod1] 163676 [host=himrod1] 163668 [host=himrod1] 163658 [host=himrod1] 163646 [host=himrod2] 163638 [host=himrod1] 163624 [host=himrod2] 163612 [host=himrod1] 163598 [host=himrod1] 163585 [host=himrod2] 163570 [host=himrod2] 163557 [host=himrod2] 163547 [host=himrod2] 163533 [host=godello0] 163515 [host=himrod1] 163505 [host=himrod2] 163484 [host=himrod1] 163475 [host=himrod2] 163460 [host=himrod1] 163441 [host=himrod1] 163426 [h\ ost=himrod1] 163404 [host=himrod1] 163387 [host=himrod2] 163367 [host=himrod1] 163340 [host=himrod2] 163324 [host=himrod2] 163320 [host=himrod2] 163312 [host=himrod2] 163307 [host=himrod1] 163304 [host=himrod1] 163302 [host=himrod2] 163300 [host=himrod2] 163298 [host=himrod2] 163294 [host=himrod1] 163291 [host=himrod2] 163289 [host=himrod2] 163259 [host=himrod2] 163238 [host=himrod1] 163233 [host=himrod1] 163229 [host=himrod2] 163227 [host=himrod2] 163224 [host=himrod2] 163221 [host=himrod1] 163\ 217 [host=himrod1] 163216 [host=himrod1] 163214 [host=himrod2] 163210 [host=himrod1] 163205 [host=himrod1] 163197 [host=himrod2] 163192 [host=himrod1] 163189 [host=godello0] 163185 [host=himrod2] 163180 [host=himrod1] 163175 [host=himrod2] 163172 [host=himrod1] 163167 [host=himrod1] 163162 [host=himrod2] 163159 [host=himrod1] 163157 [host=himrod1] 163154 [host=himrod1] 163143 [host=himrod2] 163132 [host=himrod1] 163124 [host=himrod1] 163116 [host=himrod1] 163107 [host=himrod1] 163096 [host=himro\ d2] 163055 [host=himrod1] 163028 [host=himrod1] 163022 [host=himrod2] 163018 [host=himrod2] 163013 [host=himrod2] 163009 [host=himrod2] 162999 [host=himrod2] 162995 [host=godello0] 162994 [host=godello0] 162987 [host=fiano1] 162972 [host=himrod2] 162892 [host=himrod1] 162884 [host=himrod2] 162878 [host=himrod2] 162875 [host=himrod1] 162869 [host=himrod2] 162865 [host=himrod1] 162855 [host=himrod2] 162851 [host=himrod2] 162846 [host=himrod1] 162841 [host=himrod1] 162837 [host=himrod2] 162833 [hos\ t=himrod1] 162821 [host=himrod2] 162808 [host=himrod1] 162799 [host=himrod1] 162792 [host=himrod2] 162781 [host=himrod2] 162774 [host=himrod1] 162769 [host=himrod1] 162758 [host=himrod2] 162722 [host=himrod1] 162702 [host=himrod1] 162683 [host=himrod1] 162659 [host=himrod2] 162637 [host=himrod2] 162609 [host=himrod1] 162583 [host=himrod1] 162552 [host=albana0] 162542 [host=himrod1] 162436 [host=himrod1] 162371 [host=himrod1] 162368 [host=himrod1] 162359 [host=himrod1] 162341 [host=himrod1] 16233\ 8 [host=himrod2] 162334 [host=himrod1] 162326 [host=himrod1] 162288 [host=godello0] 162271 [host=himrod1] 162259 [host=himrod2] 162256 [host=himrod1] 162217 [host=himrod1] 162131 [host=himrod1] 162113 [host=himrod1] 162111 [host=himrod2] 162071 [host=himrod1] 162046 [host=himrod2] 162002 [host=himrod1] 161987 [host=himrod1] 161979 [host=himrod1] 161974 [host=himrod2] 161952 [host=himrod2] 161949 [host=himrod2] 161943 [host=himrod1] 161912 [host=himrod2] 161908 [host=himrod2] 161899 [host=himrod2\ ] 161895 [host=himrod2] 161726 [host=godello0] 161629 [host=himrod1] 161559 [host=himrod1] 161530 [host=himrod1] 161518 [host=himrod1] 161504 [host=himrod1] 161485 [host=himrod1] 161477 [host=himrod1] 161469 [host=himrod2] 161417 [host=himrod1] 161406 [host=himrod1] 161326 [host=himrod1] 161312 [host=himrod1] 161301 [host=himrod1] 161291 [host=himrod2] 161204 [host=himrod1] 161187 [host=himrod2] 161176 [host=himrod1] 161169 [host=himrod1] 161159 [host=himrod2] 161141 [host=himrod2] 161114 [host=\ himrod1] 161099 [host=himrod1] 161081 [host=himrod2] 161054 [host=himrod1] 161033 [host=himrod1] 160859 [host=himrod1] 160841 [host=himrod2] 160817 [host=himrod2] 160799 [host=himrod1] 160757 [host=himrod2] 160687 [host=himrod1] 160656 [host=himrod2] 160578 [host=himrod1] 160560 [host=himrod2] 160456 [host=himrod1] 160425 [host=himrod2] 160399 [host=himrod1] 160352 [host=himrod2] 160249 [host=himrod1] 160145 [host=himrod2] 160131 [host=himrod1] 160123 [host=himrod1] 160117 [host=himrod1] 160114 \ [host=himrod1] 160106 [host=himrod2] 160103 [host=himrod1] 160098 [host=himrod1] 159932 [host=himrod1] 159924 [host=himrod2] 159879 [host=himrod2] 159872 [host=himrod1] 159866 [host=himrod2] 159863 [host=himrod2] 159841 [host=himrod2] 159836 [host=himrod1] 159800 [host=himrod1] 159792 [host=himrod1] 159741 [host=himrod1] 159721 [host=himrod1] 159708 [host=himrod1] 159695 [host=himrod1] 159676 [host=himrod2] 159640 [host=himrod1] 159619 [host=himrod2] 159598 [host=himrod2] 159585 [host=himrod1] 1\ 59546 [host=himrod2] 159493 [host=himrod2] 159394 [host=himrod1] 159300 [host=himrod1] 159248 [host=himrod1] 159198 [host=himrod2] 159143 [host=himrod2] 159136 [host=himrod2] 159040 [host=himrod2] 159019 [host=himrod2] 159000 [host=himrod2] 158985 [host=himrod1] 158975 [host=himrod1] 158959 [host=himrod1] 158932 [host=himrod2] 158874 [host=himrod1] 158757 [host=himrod2] 158626 [host=himrod2] 158620 [host=himrod1] 158608 [host=himrod1] 158585 [host=himrod2] 158566 [host=himrod2] 158555 [host=himr\ od2] 158546 [host=himrod1] 158541 [host=himrod2] 158531 [host=himrod2] 158522 [host=himrod1] 158489 [host=himrod1] 158484 [host=himrod2] 158479 [host=himrod2] 158459 [host=himrod2] 158428 [host=himrod2] 158422 [host=himrod2] 158417 [host=himrod2] 158414 [host=himrod2] 158375 [host=himrod1] 158356 [host=himrod2] 158340 [host=himrod1] 158307 [host=himrod1] 158292 [host=godello1] 158286 [host=himrod1] 158280 [host=himrod1] 158273 [host=himrod2] 158267 [host=himrod1] 158262 [host=himrod1] 158260 [ho\ st=himrod1] 158246 [host=himrod1] 158233 [host=himrod2] 158215 [host=himrod1] 158199 [host=himrod2] 158185 [host=himrod1] 158181 [host=himrod2] 158165 [host=himrod1] 158141 [host=himrod1] 158137 [host=himrod1] 158125 [host=himrod1] 157875 [host=himrod2] 157856 [host=himrod1] 157848 [host=himrod1] 157840 [host=himrod1] 157804 [host=himrod1] 157787 [host=himrod2] 157778 [host=himrod2] 157759 [host=himrod1] 157726 [host=himrod2] 157708 [host=himrod2] 157662 [host=himrod2] 157633 [host=himrod2] 1576\ 12 [host=himrod1] 157571 [host=himrod1] 157561 [host=himrod2] 157549 [host=himrod2] 157547 [host=himrod2] 157545 [host=himrod1] 157531 [host=himrod2] 157527 [host=godello0] 157525 [host=himrod1] 157521 [host=himrod2] 157513 [host=himrod2] 157510 [host=himrod2] 157507 [host=himrod1] 157501 [host=godello0] 157495 [host=godello0] 157493 [host=godello0] 157490 [host=himrod2] 157488 [host=himrod1] 157467 [host=himrod2] 157462 [host=himrod2] 157458 [host=himrod2] 157449 [host=himrod1] 157437 [host=him\ rod1] 157416 [host=himrod2] 157412 [host=himrod1] 157394 [host=godello0] 157390 [host=himrod1] 157383 [host=himrod1] 157366 [host=himrod1] 157354 [host=himrod2] 157348 [host=himrod2] 157345 [host=himrod2] 157338 [host=himrod1] 157333 [host=himrod2] 157323 [host=himrod1] 157255 [host=himrod2] 157214 [host=himrod1] 157204 [host=himrod1] 157194 [host=himrod1] 157191 [host=himrod2] 157184 [host=himrod1] 157178 [host=himrod2] 157167 [host=himrod2] 157117 [host=godello0] 157104 [host=godello0] 157060 \ [host=himrod2] 157055 [host=himrod2] 157042 [host=himrod1] 157025 [host=himrod1] 157018 [host=himrod2] 157012 [host=himrod2] 156920 [host=himrod1] 156913 [host=himrod1] 156879 [host=himrod1] 156869 [host=himrod1] 156849 [host=himrod1] 156838 [host=himrod1] 156829 [host=himrod2] 156826 [host=himrod1] 156806 [host=himrod1] 156786 [host=himrod1] 156742 [host=himrod2] 156720 [host=himrod2] 156684 [host=himrod2] 156632 [host=himrod2] 156606 [host=himrod1] 156545 [host=himrod1] 156533 [host=himrod1] 1\ 56467 [host=himrod2] 156407 [host=himrod2] 156400 [host=himrod2] 156380 [host=himrod1] 156374 [host=himrod1] 156359 [host=himrod2] 156353 [host=himrod1] 156329 [host=himrod2] 156316 [host=himrod2] 156294 [host=himrod2] 156270 [host=himrod2] 156255 [host=himrod2] 156252 [host=himrod2] 156232 [host=himrod2] 156102 [host=himrod1] 156091 [host=himrod1] 156065 [host=himrod1] 156017 [host=himrod1] 156010 [host=himrod1] 155998 [host=himrod2] 155976 [host=himrod2] 155969 [host=himrod1] 155957 [host=himr\ od1] 155942 [host=himrod1] 155908 [host=himrod1] 155891 [host=himrod1] 155881 [host=himrod1] 155837 [host=himrod1] 155825 [host=himrod2] 155801 [host=himrod2] 155765 [host=himrod1] 155757 [host=himrod2] 155714 [host=godello0] 155643 [host=himrod1] 155617 [host=himrod1] 155594 [host=himrod1] 155548 [host=himrod2] 155512 [host=himrod1] 155223 [host=himrod1] 155121 [host=himrod2] 155045 [host=himrod2] 155005 [host=himrod1] 154633 [host=himrod1] 154616 [host=himrod1] 154558 [host=himrod2] 154468 [ho\ st=himrod1] 154452 [host=himrod1] 154446 [host=albana1] 154429 [host=albana0] 154378 [host=albana1] 154376 [host=godello0] 154370 [host=albana1] 154333 [host=albana0] 154312 [host=himrod2] 154021 [host=himrod1] 152863 [host=chardonnay1] 152786 [host=albana1] 152769 [host=godello0] 152743 [host=albana0] 152718 [host=godello0] 152627 [host=godello0] 152617 [host=chardonnay0] 152594 [host=godello0] 152587 [host=godello0] 152568 [host=albana0] 152536 [host=elbling0] 152517 [host=albana0] 152504 [hos\ t=godello0] 152495 [host=elbling0] 152459 [host=godello1] 152422 [host=godello0] 152367 [host=godello1] 152329 [host=godello1] 152315 [host=godello0] 152277 [host=godello0] 152270 [host=godello0] 152261 [host=godello0] 152249 [host=godello0] 152244 [host=godello0] 152225 [host=godello0] 152194 [host=godello1] 152186 [host=godello1] 152175 [host=godello0] 152157 [host=godello0] 152131 [host=godello1] 152088 [host=godello1] 152068 [host=albana0] 152048 [host=albana0] 152037 [host=godello0] 151982 \ [host=chardonnay0] 151972 [host=albana0] 151959 [host=godello0] 151946 [host=elbling1] 151937 [host=albana0] 151923 [host=albana1] 151907 [host=elbling1] 151898 [host=godello0] 151881 [host=elbling1] 151867 [host=chardonnay0] 151821 [host=albana1] 151812 [host=albana0] 151725 [host=albana0] 151590 [host=godello1] 151570 [host=godello1] 151550 [host=albana1] 151532 [host=godello1] 151465 [host=godello1] 151451 [host=godello1] 151444 [host=godello0] 151401 [host=godello0] 151347 [host=godello1] 15\ 1320 [host=godello1] 151303 [host=godello1] 151249 [host=fiano1] 151228 [host=godello1] 151187 [host=huxelrebe0] 151162 [host=godello1] 151139 [host=godello1] 151069 [host=albana0] 151054 [host=pinot1] 151024 [host=albana0] 150978 [host=albana1] 150946 [host=huxelrebe0] 150917 [host=godello0] 150911 [host=godello1] 150908 [host=albana1] 150894 [host=godello1] 150819 [host=albana1] 150687 [host=albana1] 150668 [host=pinot1] 150653 [host=chardonnay0] 150614 [host=godello0] 150611 [host=huxelrebe0]\ 150392 [host=albana0] 150318 [host=godello1] 150313 [host=albana0] 150300 [host=albana0] 150293 [host=godello1] 150284 [host=godello1] 150278 [host=godello1] 150232 [host=godello1] 150196 [host=godello1] 150187 [host=godello1] 150178 [host=pinot1] 150160 [host=debina1] 150156 [host=albana0] 150152 [host=godello1] 150141 [host=godello1] 150093 [host=huxelrebe1] 150082 [host=huxelrebe1] 150063 [host=huxelrebe1] 150050 [host=chardonnay1] 150045 [host=debina1] 149891 [host=godello1] 149887 [host=go\ dello1] 149869 [host=italia0] 149867 [host=godello1] 149827 [host=fiano1] 149825 [host=albana0] 149766 [host=fiano1] 149747 [host=debina1] 149742 [host=italia0] 149735 [host=italia0] 149725 [host=godello1] 149708 [host=albana0] 149698 [host=albana0] 149694 [host=godello1] 149685 [host=godello1] 149665 [host=godello1] 149638 [host=italia0] 149636 [host=godello1] 149633 [host=godello1] 149594 [host=godello1] 149560 [host=debina1] 149528 [host=godello1] 149513 [host=chardonnay0] 149504 [host=huxelr\ ebe0] 149497 [host=chardonnay0] 149485 [host=albana1] 149477 [host=albana1] 149462 [host=godello1] 149393 [host=italia0] 149368 [host=albana1] 149325 [host=godello1] 149292 [host=elbling0] 149262 [host=godello1] 149242 [host=godello1] 149207 [host=italia0] 149176 [host=italia0] 149116 [host=fiano1] 149071 [host=godello1] 149048 [host=godello0] 149012 [host=godello1] 148946 [host=albana0] 148761 [host=italia0] 148724 [host=godello1] 148672 [host=godello0] 148644 [host=godello0] 148543 [host=godel\ lo1] 148507 [host=godello0] 148461 [host=godello1] 148414 [host=rimava1] 148345 [host=godello0] 148114 [host=godello0] 148052 [host=godello0] 147928 [host=rimava1] 147838 [host=fiano0] 147783 [host=godello1] 147729 [host=godello0] 147686 [host=godello0] 147612 [host=godello0] 147531 [host=italia0] 147474 [host=godello1] 147395 [host=godello0] 147305 [host=godello1] 147229 [host=godello0] 147160 [host=godello0] 147093 [host=italia0] 147041 [host=godello1] 146987 [host=huxelrebe0] 146919 [host=pin\ ot0] 146886 [host=godello1] 146846 [host=godello1] 146841 [host=italia0] 146834 [host=fiano0] 146804 [host=godello1] 146801 [host=godello1] 146797 [host=italia0] 146792 [host=godello0] 146785 [host=godello1] 146778 [host=albana0] 146772 [host=italia0] 146762 [host=godello1] 146754 [host=albana0] 146746 [host=godello1] 146735 [host=godello0] 146730 [host=rimava1] 146709 [host=godello0] 146704 [host=godello1] 146694 [host=godello1] 146686 [host=godello1] 146678 [host=godello1] 146671 [host=godello\ 1] 146662 [host=godello0] 146654 [host=italia0] 146644 [host=godello0] 146639 [host=rimava1] 146634 [host=huxelrebe1] 146629 [host=godello0] 146621 [host=godello0] 146615 [host=italia0] 146610 [host=godello0] 146601 [host=rimava1] 146589 [host=albana0] 146581 [host=godello0] 146575 [host=albana0] 146571 [host=godello0] 146564 [host=godello1] 146560 [host=godello0] 146554 [host=godello1] 146548 [host=huxelrebe0] 146542 [host=godello0] 146537 [host=huxelrebe0] 146531 [host=huxelrebe0] 146524 [host\ =godello0] 146521 [host=godello1] 146517 [host=rimava1] 146511 [host=rimava1] 146508 [host=godello0] 146503 [host=pinot0] 146500 [host=godello0] 146498 [host=godello1] 146494 [host=albana0] 146490 [host=albana0] 146486 [host=godello1] 146482 [host=godello1] 146476 [host=huxelrebe1] 146468 [host=godello0] 146450 [host=huxelrebe1] 146424 [host=godello0] 146417 [host=godello1] 146412 [host=huxelrebe0] 146405 [host=godello0] 146395 [host=pinot0] 146385 [host=huxelrebe0] 146376 [host=albana0] 146370 \ [host=albana0] 146355 [host=godello0] 146346 [host=albana0] 146331 [host=godello1] 146308 [host=godello0] 146294 [host=godello0] 146283 [host=huxelrebe1] 146274 [host=godello0] 146259 [host=godello1] 146228 [host=godello1] 146212 [host=albana0] 146186 [host=albana0] 146168 [host=huxelrebe1] 146110 [host=rimava1] 146090 [host=huxelrebe0] 146072 [host=godello0] 146065 [host=godello0] 146047 [host=rimava1] 146044 [host=rimava1] 146041 [host=rimava1] 146038 [host=godello0] 146035 [host=albana0] 1460\ 32 [host=godello0] 146028 [host=albana0] 146026 [host=albana0] 146020 [host=pinot0] 146016 [host=godello1] 146014 [host=godello0] 146011 [host=godello0] 146004 [host=godello0] 145998 [host=huxelrebe0] 145986 [host=godello0] 145956 [host=godello0] 145948 [host=godello0] 145935 [host=godello0] 145926 [host=godello1] 145909 [host=albana0] 145902 [host=albana0] 145880 [host=godello1] 145873 [host=godello0] 145854 [host=godello0] 145846 [host=albana0] 145831 [host=godello1] 145825 [host=godello1] 145\ 817 [host=godello0] 145799 [host=albana0] 145790 [host=godello0] 145774 [host=huxelrebe0] 145767 [host=godello1] 145699 [host=godello1] 145678 [host=godello1] 145668 [host=godello1] 145658 [host=godello1] 145480 [host=godello1] 145476 [host=godello0] 145179 [host=italia0] 145172 [host=godello0] 145129 [host=godello0] 145032 [host=huxelrebe1] 145000 [host=godello0] 144974 [host=godello1] 144962 [host=italia0] 144957 [host=godello0] 144927 [host=rimava1] 144923 [host=godello1] 144918 [host=godello\ 0] 144637 [host=italia0] 144590 [host=godello1] 144583 [host=godello0] 144578 [host=godello0] 144564 [host=albana0] 144527 [host=godello0] 144524 [host=italia0] 144518 [host=godello1] 144515 [host=italia0] 144498 [host=chardonnay1] 144298 [host=godello1] 144292 [host=godello1] 144231 [host=godello1] 144224 [host=godello1] 144214 [host=chardonnay0] 144151 [host=godello1] 144138 [host=godello1] 144106 [host=godello0] 144089 [host=albana0] 144068 [host=godello0] 144046 [host=godello0] 144034 [host=\ huxelrebe0] 144011 [host=godello1] 143965 [host=godello1] 143942 [host=godello1] 143908 [host=godello1] 143839 [host=godello1] 143689 [host=godello1] 143580 [host=huxelrebe0] 143414 [host=italia0] 143348 [host=godello1] 143294 [host=huxelrebe1] 143259 [host=huxelrebe0] 143123 [host=huxelrebe0] 143072 [host=huxelrebe1] 143054 [host=albana1] 143039 [host=debina0] 143013 [host=albana1] 142998 [host=huxelrebe1] 142986 [host=albana1] 142895 [host=italia0] 142857 [host=huxelrebe1] 142831 [host=godello\ 0] 142765 [host=italia0] 142749 [host=rimava1] 142733 [host=huxelrebe1] 142717 [host=baroque0] 142692 [host=huxelrebe0] 142673 [host=baroque0] 142636 [host=huxelrebe0] 142599 [host=italia0] 142567 [host=huxelrebe0] 142533 [host=italia0] 142495 [host=huxelrebe0] 142455 [host=huxelrebe1] 142423 [host=godello0] 142274 [host=baroque0] 142250 [host=baroque0] 142117 [host=debina0] 142070 [host=godello0] 142017 [host=huxelrebe1] 141988 [host=albana1] 141966 [host=godello0] 141907 [host=debina1] 141888 \ [host=albana0] 141845 [host=godello0] 141798 [host=godello0] 141742 [host=godello0] 141585 [host=albana0] 141510 [host=baroque0] 141481 [host=albana1] 141451 [host=godello1] 141410 [host=huxelrebe1] 141380 [host=godello0] 141300 [host=godello0] 141270 [host=albana0] 141251 [host=huxelrebe1] 141238 [host=huxelrebe1] 141212 [host=godello0] 141189 [host=albana0] 141091 [host=albana1] 141054 [host=albana1] 141000 [host=godello1] 140983 [host=godello0] 140969 [host=godello0] 140949 [host=huxelrebe1] \ 140851 [host=huxelrebe1] 140807 [host=godello0] 140769 [host=albana1] 140725 [host=albana0] 140559 [host=godello0] 140527 [host=godello1] 140487 [host=baroque0] 140448 [host=godello1] 140405 [host=godello0] 140379 [host=godello0] 140332 [host=godello0] 140200 [host=godello1] 140177 [host=godello0] 140162 [host=godello1] 140144 [host=huxelrebe0] 140116 [host=huxelrebe0] 140089 [host=huxelrebe0] 140068 [host=godello1] 140047 [host=chardonnay1] 140011 [host=huxelrebe1] 139967 [host=italia1] 139880 \ [host=godello1] 139859 [host=huxelrebe1] 139843 [host=huxelrebe0] 139815 [host=huxelrebe0] 139777 [host=huxelrebe0] 139751 [host=fiano1] 139734 [host=italia1] 139718 [host=godello0] 139666 [host=godello0] 139653 [host=godello1] 139632 [host=godello1] 139614 [host=godello0] 139571 [host=godello0] 139550 [host=godello1] 139533 [host=godello0] 139518 [host=debina0] 139499 [host=godello1] 139468 [host=godello0] 139371 [host=godello0] 139357 [host=chardonnay1] 139329 [host=albana1] 139318 [host=godel\ lo1] 139301 [host=albana1] 139289 [host=godello0] 139262 [host=albana0] 139241 [host=godello1] 139186 [host=godello0] 139157 [host=godello0] 139118 [host=godello1] 139099 [host=italia0] 139072 [host=godello0] 139038 [host=godello0] 139011 [host=godello1] 138998 [host=godello1] 138966 [host=albana0] 138942 [host=godello1] 138914 [host=italia0] 138896 [host=debina0] 138877 [host=baroque1] 138851 [host=godello1] 138817 [host=albana0] 138782 [host=albana0] 138758 [host=albana0] 138741 [host=godello0\ ] 138715 [host=godello0] 138693 [host=godello0] 138674 [host=godello0] 138664 [host=godello0] 138650 [host=albana0] 138630 [host=godello0] 138607 [host=albana0] 138580 [host=pinot1] 138492 [host=godello0] 138392 [host=godello1] 138234 [host=godello1] 138077 [host=godello0] 137943 [host=albana0] 137860 [host=albana0] 137731 [host=godello0] 137684 [host=italia1] 137595 [host=fiano0] 137503 [host=godello1] 137443 [host=godello0] 137374 [host=albana0] 137270 [host=albana1] 137177 [host=godello1] 137\ 118 [host=godello0] 137096 [host=godello1] 137056 [host=godello0] 137021 [host=chardonnay1] 136995 [host=albana1] 136890 [host=godello1] 136761 [host=godello0] 136598 [host=pinot1] 136470 [host=godello0] 136306 [host=godello0] 136180 [host=chardonnay0] 136056 [host=godello0] 135978 [host=godello1] 135885 [host=godello1] 135689 [host=godello0] 135530 [host=godello1] 135451 [host=godello1] 135431 [host=chardonnay1] 135318 [host=albana0] 135312 [host=baroque0] 135307 [host=debina1] 135295 [host=alb\ ana0] 135288 [host=godello1] 135282 [host=godello0] 135276 [host=godello1] 135269 [host=godello0] 135265 [host=rimava1] 135248 [host=baroque0] 135219 [host=chardonnay0] 135202 [host=rimava1] 135182 [host=albana0] 135166 [host=pinot1] 135150 [host=italia1] 135124 [host=elbling1] 135107 [host=elbling1] 135097 [host=albana1] 135081 [host=godello0] 134977 [host=debina1] 134972 [host=albana0] 134970 [host=godello1] 134965 [host=italia1] 134949 [host=albana1] 134940 [host=albana1] 134935 [host=albana1\ ] 134889 [host=albana1] 134874 [host=chardonnay0] 134865 [host=godello1] 134854 [host=fiano1] 134852 [host=albana0] 134839 [host=godello1] 134823 [host=debina1] 134802 [host=albana1] 134776 [host=italia1] 134738 [host=albana1] 134640 [host=chardonnay1] 134578 [host=godello1] 134515 [host=chardonnay0] 134423 [host=italia1] 134346 [host=albana1] 134282 [host=godello1] 134254 [host=italia1] 134143 [host=italia0] 134113 [host=italia1] 134071 [host=elbling1] 134043 [host=albana1] 133980 [host=chardon\ nay1] 133970 [host=godello1] 133938 [host=italia0] 133917 [host=merlot1] 133887 [host=albana0] 133848 [host=godello0] 133816 [host=albana1] 133769 [host=godello0] 133737 [host=godello1] 133698 [host=godello0] 133670 [host=albana0] 133640 [host=albana1] 133610 [host=albana0] 133493 [host=albana0] 133471 [host=godello0] 133465 [host=godello0] 133459 [host=albana1] 133369 [host=godello1] 133354 [host=italia1] 133344 [host=godello0] 133291 [host=godello1] 133273 [host=godello1] 133243 [host=godello0\ ] 133203 [host=debina0] 133148 [host=albana1] 133126 [host=godello0] 133025 [host=albana1] 132980 [host=godello0] 132857 [host=godello0] 132766 [host=godello0] 132723 [host=godello1] 132654 [host=godello1] 132595 [host=albana1] 132567 [host=godello1] 132467 [host=godello1] 132452 [host=godello0] 132419 [host=debina1] 132382 [host=godello1] 132302 [host=godello0] 132252 [host=godello0] 132170 [host=godello0] 132077 [host=godello0] 132024 [host=godello1] 131983 [host=godello0] 129475 [host=godello\ 0] 129454 [host=rimava1] 129430 [host=baroque1] 129328 [host=godello0] 129310 [host=italia0] 129273 [host=debina0] 129268 [host=baroque1] 129238 [host=baroque1] 129218 [host=albana0] 129212 [host=italia0] 129191 [host=godello1] 129171 [host=baroque1] 129162 [host=elbling0] 129125 [host=baroque1] 129121 [host=godello0] 129113 [host=albana0] 129095 [host=albana0] 129058 [host=albana0] 129053 [host=elbling1] 129044 [host=albana0] 129014 [host=albana0] 129004 [host=albana1] 128998 [host=albana0] 128\ 994 [host=albana0] 128989 [host=albana0] 128979 [host=debina0] 128976 [host=albana1] 128974 [host=godello1] 128971 [host=elbling0] 128964 [host=albana0] 128960 [host=fiano1] 128956 [host=godello1] 128954 [host=elbling1] 128953 [host=godello0] 128952 [host=godello1] 128944 [host=italia0] 128943 [host=elbling0] 128941 [host=baroque1] 128927 [host=baroque1] 128924 [host=debina0] 128923 [host=baroque1] 128919 [host=elbling1] 128917 [host=baroque1] 128913 [host=debina0] 128874 [host=godello0] 128872 \ [host=debina0] 128862 [host=baroque1] 128860 [host=pinot1] 128856 [host=debina0] 128846 [host=godello1] 128845 [host=albana0] 128836 [host=godello0] 128834 [host=italia0] 128832 [host=albana1] 128821 [host=baroque1] 128808 [host=godello1] 128799 [host=godello0] 128680 [host=italia0] 128670 [host=baroque1] 128655 [host=albana0] 128632 [host=pinot1] 128613 [host=albana0] 128573 [host=albana1] 128528 [host=albana1] 128519 [host=albana1] 128433 [host=elbling1] 128351 [host=albana1] 128255 [host=baro\ que1] 128252 [host=godello0] 128246 [host=godello1] 128238 [host=godello1] 128223 [host=godello1] 128217 [host=godello0] 128163 [host=albana1] 128143 [host=albana0] 128119 [host=albana0] 128098 [host=godello1] 128086 [host=godello1] 128082 [host=albana0] 128058 [host=debina0] 128037 [host=baroque1] 128030 [host=huxelrebe1] 128015 [host=huxelrebe1] 127880 [host=huxelrebe1] 127766 [host=debina1] 127707 [host=debina1] 127604 [host=godello0] 127594 [host=pinot1] 127590 [host=debina0] 127561 [host=al\ bana1] 127554 [host=debina1] 127528 [host=debina1] 127522 [host=baroque1] 127502 [host=albana0] 127483 [host=joubertin0] 127470 [host=huxelrebe1] 127461 [host=joubertin0] 127390 [host=godello0] 127378 [host=godello1] 127367 [host=debina0] 127361 [host=baroque1] 127357 [host=godello0] 127354 [host=huxelrebe1] 127346 [host=albana0] 127335 [host=godello0] 127318 [host=godello1] 127299 [host=baroque1] 127285 [host=albana0] 127237 [host=godello1] 127208 [host=debina0] 127199 [host=debina0] 127190 [ho\ st=huxelrebe1] 127186 [host=albana0] 127044 [host=albana1] 127016 [host=albana0] 126988 [host=italia0] 126959 [host=godello1] 126919 [host=albana1] 126874 [host=godello0] 126824 [host=albana1] 126773 [host=debina0] 126742 [host=albana1] 126588 [host=albana0] 126545 [host=rimava1] 126526 [host=albana0] 126482 [host=godello1] 126430 [host=huxelrebe1] 126389 [host=pinot0] 126360 [host=godello0] 126340 [host=godello0] 126315 [host=albana1] 126250 [host=baroque1] 126238 [host=godello0] 126233 [host=g\ odello1] 126061 [host=debina0] 125966 [host=albana0] 125924 [host=debina0] 125900 [host=godello1] 125851 [host=godello1] 125844 [host=albana0] 125837 [host=godello0] 125830 [host=albana0] 125803 [host=godello0] 125790 [host=godello0] 125775 [host=debina1] 125763 [host=debina0] 125761 [host=huxelrebe1] 125759 [host=italia0] 125758 [host=fiano1] 125757 [host=albana0] 125755 [host=chardonnay0] 125752 [host=debina0] 125750 [host=debina1] 125748 [host=huxelrebe1] 125746 [host=huxelrebe1] 125740 [host\ =huxelrebe1] 125738 [host=albana1] 125734 [host=italia0] 125714 [host=albana0] 125693 [host=godello0] 125665 [host=albana1] 125646 [host=baroque0] 125643 [host=albana1] 125625 [host=albana0] 125613 [host=godello0] 125606 [host=albana1] 125597 [host=baroque0] 125590 [host=albana0] 125584 [host=albana0] 125579 [host=baroque0] 125576 [host=baroque0] 125562 [host=baroque0] 125557 [host=albana1] 125553 [host=debina0] 125546 [host=albana0] 125540 [host=italia0] 125531 [host=albana1] 125523 [host=debin\ a0] 125519 [host=debina1] 125513 [host=fiano1] 125510 [host=debina0] 125495 [host=albana0] 125484 [host=godello0] 125454 [host=godello1] 125295 [host=debina0] 125255 [host=debina0] 125241 [host=debina1] 125151 [host=godello1] 125147 [host=fiano1] 125145 [host=albana1] 125143 [host=godello1] 125124 [host=albana0] 125122 [host=debina1] 125120 [host=albana0] 125119 [host=godello0] 125105 [host=fiano1] 125100 [host=debina1] 125095 [host=godello0] 125073 [host=albana0] 125054 [host=albana0] 125050 [h\ ost=debina0] 125046 [host=albana1] 125036 [host=debina0] 125032 [host=debina0] 125013 [host=debina0] 124998 [host=godello1] 124974 [host=huxelrebe0] 124944 [host=albana1] 124920 [host=albana1] 124891 [host=albana1] 124864 [host=godello1] 124812 [host=albana1] 124618 [host=huxelrebe0] 124571 [host=albana1] 124515 [host=godello1] 124466 [host=godello0] 124440 [host=huxelrebe0] 124400 [host=albana0] 124361 [host=albana0] 124243 [host=godello1] 124207 [host=godello0] 124184 [host=albana0] 124162 [ho\ st=godello1] 124116 [host=godello1] 124091 [host=godello1] 124074 [host=godello0] 124058 [host=albana0] 124002 [host=godello0] 123940 [host=chardonnay1] 123879 [host=huxelrebe1] 123855 [host=italia0] 123829 [host=debina0] 123811 [host=joubertin1] 123791 [host=joubertin1] 123564 [host=godello1] 123356 [host=godello0] 123314 [host=baroque0] 123281 [host=godello0] 123204 [host=joubertin1] 123187 [host=godello0] 123101 [host=joubertin1] 123003 [host=huxelrebe1] 122961 [host=huxelrebe1] 122885 [host=\ godello0] 122797 [host=elbling1] 122718 [host=godello0] 122667 [host=godello0] 122637 [host=huxelrebe0] 122625 [host=godello1] 122597 [host=godello1] 122568 [host=elbling1] 122566 [host=huxelrebe1] 122563 [host=godello1] 122557 [host=huxelrebe0] 122532 [host=godello1] 122482 [host=elbling1] 122440 [host=huxelrebe0] 122396 [host=godello1] 122362 [host=rimava0] 122346 [host=huxelrebe0] 122337 [host=godello1] 122329 [host=elbling1] 122324 [host=italia0] 122311 [host=godello1] 122292 [host=rimava0] \ 122250 [host=elbling1] 122226 [host=italia0] 122200 [host=godello1] 122178 [host=godello0] 122168 [host=huxelrebe0] 122158 [host=godello0] 122135 [host=godello1] 122120 [host=godello0] 122092 [host=godello1] 121769 [host=italia1] 121741 [host=godello0] 121710 [host=godello0] 121669 [host=elbling1] 121490 [host=italia1] 121374 [host=godello1] 121338 [host=rimava0] 121323 [host=godello1] 121309 [host=huxelrebe1] 121281 [host=baroque1] 121170 [host=huxelrebe1] 121046 [host=baroque1] 120991 [host=hu\ xelrebe0] 120951 [host=baroque1] 120879 [host=godello0] 120819 [host=godello0] 120727 [host=godello1] 120573 [host=huxelrebe1] 120426 [host=godello1] 120373 [host=rimava0] 120340 [host=godello1] 120285 [host=godello0] 120254 [host=baroque1] 120230 [host=godello0] 120113 [host=godello0] 120070 [host=chardonnay1] 120040 [host=huxelrebe1] 120014 [host=baroque1] 119996 [host=godello0] 119964 [host=baroque0] 114319 [host=fiano0] 114270 [host=baroque1] 114197 [host=godello1] 114172 [host=godello0] 114\ 099 [host=italia1] 114078 [host=godello1] 114052 [host=fiano1] 113967 [host=baroque0] 113958 [host=baroque0] 113921 [host=nobling1] 113917 [host=baroque0] 113905 [host=nobling1] 113900 [host=godello1] 113897 [host=godello1] 113894 [host=huxelrebe1] 113891 [host=huxelrebe1] 113878 [host=baroque0] 113867 [host=godello1] 113859 [host=godello0] 113847 [host=godello0] 113841 [host=nobling1] 113838 [host=huxelrebe1] 113827 [host=rimava1] 113820 [host=godello0] 113810 [host=godello1] 113808 [host=huxel\ rebe1] 113806 [host=rimava1] 113801 [host=nobling1] 113798 [host=nobling1] 113767 [host=godello0] 113739 [host=godello1] 113647 [host=godello0] 113636 [host=nobling1] 113621 [host=godello1] 113608 [host=huxelrebe1] 113599 [host=huxelrebe1] 113590 [host=godello0] 113572 [host=huxelrebe1] 113566 [host=huxelrebe1] 113526 [host=nobling1] 113498 [host=godello1] 113481 [host=godello1] 113462 [host=godello1] 113443 [host=godello0] 113143 [host=pinot1] 113130 [host=chardonnay1] 113115 [host=nobling1] 11\ 3078 [host=godello1] 113061 [host=godello0] 113050 [host=godello1] 113045 [host=godello1] 113037 [host=huxelrebe1] 113029 [host=chardonnay1] 113005 [host=godello1] 113000 [host=rimava1] 112991 [host=godello0] 112986 [host=godello0] 112971 [host=godello1] 112958 [host=godello1] 112947 [host=godello0] 112919 [host=godello0] 112911 [host=huxelrebe0] 112903 [host=godello1] 112899 [host=huxelrebe1] 112883 [host=godello1] 112878 [host=godello1] 112867 [host=huxelrebe0] 112859 [host=godello1] 112846 [h\ ost=rimava0] 112837 [host=rimava1] 112782 [host=godello0] 112757 [host=godello1] 112722 [host=huxelrebe1] 112702 [host=merlot0] 112687 [host=godello0] 112671 [host=baroque1] 112656 [host=godello1] 112644 [host=godello0] 112636 [host=huxelrebe1] 112628 [host=rimava1] 112623 [host=godello0] 112615 [host=nobling0] 112606 [host=nobling0] 112601 [host=rimava0] 112594 [host=baroque0] 112585 [host=baroque1] 112539 [host=fiano0] 112532 [host=godello1] 112525 [host=huxelrebe0] 112522 [host=godello1] 1125\ 18 [host=nobling1] 112512 [host=nobling0] 112501 [host=elbling1] 112495 [host=merlot0] 112464 [host=huxelrebe0] 112455 [host=nobling0] 112439 [host=italia1] 112433 [host=nobling0] 112424 [host=baroque0] 112415 [host=godello0] 112404 [host=godello1] 112367 [host=huxelrebe0] 112356 [host=godello1] 112342 [host=huxelrebe1] 112337 [host=godello0] 112333 [host=godello1] 112322 [host=huxelrebe0] 112315 [host=godello1] 112309 [host=nobling0] 112305 [host=huxelrebe1] 112091 [host=huxelrebe0] 112039 [hos\ t=fiano0] 111973 [host=huxelrebe0] 111959 [host=baroque0] 111948 [host=nobling0] 111941 [host=nobling0] 111837 [host=baroque0] 111810 [host=godello1] 111785 [host=baroque0] 111715 [host=elbling1] 111704 [host=elbling0] 111665 [host=baroque0] 111656 [host=elbling1] 111621 [host=fiano0] 111544 [host=godello1] 111526 [host=nobling0] 111513 [host=huxelrebe0] 111470 [host=huxelrebe1] 111384 [host=godello1] 111370 [host=baroque0] 111369 [host=baroque0] 111367 [host=godello1] 111361 [host=godello0] 111\ 355 [host=godello1] 111212 [host=godello0] 111198 [host=godello0] 111189 [host=huxelrebe1] 111172 [host=godello1] 111153 [host=godello0] 111105 [host=nobling0] 111089 [host=godello1] 111080 [host=merlot0] 111076 [host=godello1] 111067 [host=nocera1] 111037 [host=godello1] 111019 [host=fiano0] 110988 [host=godello1] 110965 [host=huxelrebe1] 110936 [host=huxelrebe1] 110905 [host=baroque1] 110467 [host=chardonnay0] 110439 [host=godello0] 110414 [host=godello1] 110393 [host=godello1] 110263 [host=hu\ xelrebe0] 110195 [host=huxelrebe1] 110078 [host=huxelrebe0] 110056 [host=chardonnay0] 110023 [host=elbling1] 110011 [host=godello1] 110007 [host=nobling1] 109950 [host=nobling1] 109932 [host=huxelrebe1] 109931 [host=godello1] 109930 [host=nobling0] 109923 [host=godello0] 109915 [host=godello0] 109877 [host=nobling0] 109835 [host=godello0] 109816 [host=baroque0] 109794 [host=nobling0] 109791 [host=elbling1] 109761 [host=godello0] 109737 [host=baroque0] 109731 [host=baroque0] 109727 [host=godello0\ ] 109720 [host=rimava0] 109714 [host=godello0] 109700 [host=godello0] 109695 [host=rimava0] 109691 [host=huxelrebe1] 109689 [host=baroque0] 109683 [host=rimava0] 109676 [host=godello1] 109674 [host=elbling1] 109640 [host=elbling1] 109627 [host=godello1] 109608 [host=godello1] 109596 [host=godello1] 109569 [host=godello1] 109548 [host=godello1] 109524 [host=godello0] 109347 [host=baroque0] 109344 [host=godello0] 109337 [host=huxelrebe1] 109316 [host=huxelrebe1] 109312 [host=rimava1] 109308 [host=\ baroque0] 109300 [host=chardonnay1] 109291 [host=chardonnay1] 109268 [host=godello0] 109208 [host=rimava1] 109196 [host=huxelrebe1] 109159 [host=huxelrebe1] 109147 [host=godello0] 109086 [host=godello1] 109058 [host=godello0] 109029 [host=huxelrebe1] 109011 [host=godello0] 108216 [host=godello1] 108170 [host=godello1] 108129 [host=baroque0] 108114 [host=godello0] 107913 [host=godello1] 107800 [host=godello0] 107716 [host=baroque0] 107702 [host=godello0] 107683 [host=godello0] 107645 [host=godell\ o1] 107641 [host=godello1] 107637 [host=huxelrebe0] 107627 [host=fiano0] 107623 [host=baroque0] 107578 [host=godello0] 107574 [host=godello0] 107564 [host=godello1] 107554 [host=godello0] 107545 [host=huxelrebe1] 107535 [host=elbling1] 107499 [host=godello0] 107492 [host=merlot0] 107484 [host=huxelrebe1] 107447 [host=huxelrebe1] 107440 [host=godello1] 107425 [host=godello1] 107412 [host=godello1] 107392 [host=godello1] 107376 [host=godello1] 107364 [host=godello0] 107329 [host=nocera1] 107308 [h\ ost=huxelrebe1] 107270 [host=pinot1] 107237 [host=godello0] 107215 [host=fiano0] 107192 [host=godello0] 107070 [host=godello1] 107039 [host=godello0] 107018 [host=godello1] 107013 [host=godello0] 107008 [host=godello1] 106996 [host=baroque1] 106988 [host=huxelrebe1] 106978 [host=baroque0] 106971 [host=baroque0] 106955 [host=godello1] 106954 [host=baroque0] 106947 [host=pinot0] 106938 [host=chardonnay1] 106934 [host=baroque0] 106932 [host=godello0] 106929 [host=pinot0] 106904 [host=godello0] 1068\ 82 [host=godello0] 106852 [host=huxelrebe1] 106826 [host=merlot1] 106805 [host=nocera0] 106801 [host=baroque1] 106798 [host=huxelrebe1] 106790 [host=huxelrebe0] 106785 [host=elbling1] 106782 [host=huxelrebe1] 106779 [host=fiano1] 106759 [host=godello1] 106753 [host=huxelrebe0] 106745 [host=elbling1] 106731 [host=godello0] 106716 [host=baroque1] 106700 [host=elbling1] 106676 [host=merlot0] 106662 [host=godello1] 106638 [host=godello1] 106634 [host=pinot0] 106629 [host=godello0] 106626 [host=baroq\ ue0] 106624 [host=huxelrebe0] 106617 [host=godello1] 106610 [host=baroque0] 106601 [host=baroque0] 106598 [host=merlot0] 106592 [host=godello1] 106590 [host=chardonnay0] 106586 [host=huxelrebe1] 106582 [host=huxelrebe1] 106572 [host=merlot0] 106564 [host=fiano1] 106538 [host=godello0] 106527 [host=huxelrebe1] 106511 [host=baroque1] 106506 [host=huxelrebe1] 106489 [host=nocera1] 106484 [host=baroque1] 106481 [host=nocera1] 106479 [host=godello0] 106472 [host=fiano1] 106458 [host=chardonnay0] 1064\ 42 [host=huxelrebe0] 106433 [host=pinot0] 106415 [host=godello1] 106403 [host=huxelrebe1] 106390 [host=huxelrebe1] 106378 [host=baroque1] 106359 [host=godello0] 106328 [host=huxelrebe1] 106308 [host=huxelrebe1] 106287 [host=godello0] 106270 [host=rimava0] 106259 [host=godello0] 106234 [host=godello0] 106217 [host=huxelrebe0] 106206 [host=godello0] 106187 [host=huxelrebe0] 106173 [host=godello1] 106159 [host=huxelrebe1] 106145 [host=baroque0] 106133 [host=godello1] 106125 [host=merlot0] 106110 [h\ ost=chardonnay1] 106090 [host=godello1] 106058 [host=godello0] 105980 [host=rimava1] 105963 [host=baroque0] 105949 [host=pinot0] 105937 [host=godello1] 105920 [host=godello0] 105878 [host=nobling1] 105865 [host=merlot0] 105854 [host=rimava1] 105837 [host=godello0] 105814 [host=godello0] 105808 [host=godello1] 105782 [host=merlot0] 105760 [host=godello0] 105696 [host=baroque0] 105679 [host=pinot1] 105658 [host=nobling1] 105652 [host=baroque0] 105636 [host=pinot0] 105631 [host=huxelrebe0] 105627 [\ host=nocera0] 105604 [host=godello0] 105599 [host=huxelrebe0] 105558 [host=godello0] 105553 [host=nobling1] 105332 [host=huxelrebe0] 105046 [host=nobling1] 104711 [host=huxelrebe1] 104689 [host=baroque0] 104668 [host=nobling0] 104646 [host=baroque0] 104639 [host=huxelrebe0] 104635 [host=nobling1] 104620 [host=huxelrebe0] 104618 [host=godello1] 104615 [host=huxelrebe0] 104607 [host=nobling0] 104603 [host=godello0] 104600 [host=baroque0] 104589 [host=nobling0] 104575 [host=godello0] 104361 [host=m\ erlot0] 104339 [host=godello1] 104306 [host=huxelrebe0] 104279 [host=italia0] 104261 [host=nobling0] 104239 [host=italia0] 104204 [host=baroque0] 104198 [host=huxelrebe1] 104196 [host=nobling1] 104163 [host=nobling1] 104155 [host=italia0] 104151 [host=nobling1] 104144 [host=godello1] 104141 [host=nobling1] 104140 [host=huxelrebe0] 104135 [host=nobling0] 104133 [host=huxelrebe1] 104129 [host=nobling0] 104128 [host=godello1] 104123 [host=godello1] 104121 [host=nobling1] 104113 [host=huxelrebe0] 10\ 4105 [host=godello1] 104103 [host=italia1] 104102 [host=huxelrebe1] 104096 [host=nobling1] 104095 [host=italia1] 104087 [host=godello0] 104081 [host=huxelrebe0] 104080 [host=godello0] 104079 [host=nobling1] 104061 [host=italia1] 104058 [host=godello0] 104057 [host=godello0] 104055 [host=italia0] 104054 [host=nobling0] 104052 [host=huxelrebe0] 104038 [host=huxelrebe1] 104037 [host=godello0] 104035 [host=huxelrebe1] 104028 [host=nobling0] 104026 [host=nobling0] 104023 [host=godello0] 104020 [host=\ baroque0] 104009 [host=italia1] 104006 [host=nobling1] 103998 [host=nobling1] 103997 [host=baroque0] 103996 [host=chardonnay1] 103993 [host=chardonnay1] 103986 [host=baroque0] 103984 [host=baroque0] 103957 [host=italia0] 103950 [host=godello1] 103946 [host=godello1] 103869 [host=godello0] 103823 [host=chardonnay1] 103801 [host=godello0] 103787 [host=godello0] 103773 [host=godello0] 103763 [host=nobling1] 103748 [host=italia0] 103742 [host=godello1] 103739 [host=godello0] 103494 [host=godello1] 1\ 03411 [host=godello1] 103347 [host=elbling0] 103293 [host=italia0] 103226 [host=italia0] 103168 [host=baroque0] 103086 [host=godello1] 103013 [host=elbling1] 102955 [host=godello0] 102915 [host=godello0] 102827 [host=godello0] 102785 [host=baroque0] 102760 [host=godello0] 102745 [host=godello1] 102727 [host=baroque0] 102715 [host=godello1] 102707 [host=godello0] 102702 [host=godello1] 102696 [host=huxelrebe1] 102691 [host=fiano0] 102687 [host=merlot1] 102685 [host=godello0] 102655 [host=godello0\ ] 102649 [host=fiano0] 102627 [host=merlot0] 102596 [host=nocera1] 102546 [host=nobling1] 102513 [host=italia1] 102508 [host=godello0] 102474 [host=huxelrebe1] 102470 [host=godello1] 102464 [host=huxelrebe1] 102380 [host=baroque0] 102376 [host=godello0] 102371 [host=nobling0] 102367 [host=merlot0] 102363 [host=nobling0] 102360 [host=merlot1] 102355 [host=merlot1] 102343 [host=merlot0] 102337 [host=chardonnay1] 102330 [host=chardonnay1] 102322 [host=chardonnay1] 102314 [host=italia1] 102305 [host\ =chardonnay1] 102298 [host=nobling0] 102292 [host=merlot0] 102285 [host=godello0] 102279 [host=huxelrebe0] 102266 [host=nobling0] 102260 [host=nobling0] 102256 [host=huxelrebe0] 102253 [host=huxelrebe0] 102247 [host=godello0] 102236 [host=godello1] 102229 [host=godello1] 102220 [host=baroque0] 102214 [host=italia1] 102202 [host=baroque0] 102127 [host=godello1] 102114 [host=italia0] 102104 [host=huxelrebe0] 102087 [host=italia1] 102076 [host=italia0] 102065 [host=godello1] 102050 [host=huxelrebe0\ ] 102036 [host=godello1] 102029 [host=italia0] 102010 [host=godello0] 101986 [host=godello0] 101945 [host=godello0] 101930 [host=godello0] 101922 [host=huxelrebe0] 101919 [host=godello0] 101912 [host=godello1] 101872 [host=godello0] 101866 [host=baroque0] 101864 [host=chardonnay1] 101859 [host=godello1] 101853 [host=godello1] 101843 [host=godello0] 101838 [host=baroque0] 101832 [host=baroque0] 101829 [host=chardonnay1] 101825 [host=baroque0] 101821 [host=godello1] 101819 [host=godello1] 101774 [\ host=chardonnay1] 101763 [host=baroque0] 101749 [host=chardonnay0] 101729 [host=godello1] 101710 [host=godello1] 101681 [host=godello1] 101670 [host=italia0] 101658 [host=godello1] 101653 [host=chardonnay0] 101645 [host=godello1] 101639 [host=nobling0] 101635 [host=nobling1] 101591 [host=chardonnay1] 101582 [host=nobling1] 101572 [host=italia0] 101569 [host=nobling1] 101562 [host=godello1] 101558 [host=godello0] 101554 [host=godello0] 101549 [host=chardonnay1] 101544 [host=italia0] 101540 [host=\ godello0] 101534 [host=fiano1] 101526 [host=godello0] 101521 [host=fiano0] 101509 [host=godello0] 101504 [host=godello0] 101498 [host=nobling0] 101486 [host=godello1] 101481 [host=italia0] 101468 [host=italia0] 101442 [host=fiano0] 101435 [host=godello0] 101414 [host=godello1] 101402 [host=godello0] 101392 [host=pinot0] 101384 [host=fiano1] 101381 [host=fiano1] 101377 [host=godello0] 101370 [host=godello1] 101366 [host=godello1] 101351 [host=fiano1] 101348 [host=godello1] 101342 [host=fiano1] 10\ 1341 [host=godello1] 101336 [host=godello1] 101334 [host=godello1] 101331 [host=godello1] 101329 [host=godello1] 101327 [host=godello1] 101303 [host=godello0] 101297 [host=italia0] 101249 [host=godello1] 101248 [host=fiano1] 101220 [host=fiano1] 101217 [host=godello0] 101206 [host=godello0] 101199 [host=godello0] 101180 [host=godello0] 101170 [host=godello1] 101165 [host=godello1] 101162 [host=godello1] 101160 [host=godello0] 101158 [host=godello1] 101157 [host=godello1] 101152 [host=godello1] 1\ 01151 [host=fiano1] 101139 [host=godello1] 101127 [host=chardonnay0] 101124 [host=fiano1] 101122 [host=godello1] 101113 [host=fiano1] 101097 [host=chardonnay0] 101085 [host=huxelrebe1] 101071 [host=huxelrebe1] 101043 [host=italia1] 101025 [host=italia1] 100969 [host=chardonnay0] 100963 [host=huxelrebe1] 100955 [host=chardonnay0] 100947 [host=italia1] 100940 [host=godello0] 100932 [host=huxelrebe0] 100894 [host=italia1] 100890 [host=huxelrebe0] 100888 [host=huxelrebe0] 100860 [host=godello1] 1008\ 38 [host=baroque1] 100821 [host=godello1] 100810 [host=huxelrebe1] 100805 [host=baroque1] 100801 [host=godello1] 100796 [host=godello0] 100783 [host=baroque1] 100774 [host=godello1] 100764 [host=chardonnay0] 100754 [host=elbling1] 100749 [host=chardonnay0] 100743 [host=godello1] 100739 [host=baroque1] 100737 [host=godello1] 100721 [host=italia1] 100719 [host=baroque0] 100710 [host=huxelrebe0] 100709 [host=godello0] 100703 [host=huxelrebe1] 100699 [host=godello0] 100692 [host=chardonnay0] 100687 \ [host=huxelrebe0] 100673 [host=baroque1] 100672 [host=baroque1] 100670 [host=godello0] 100659 [host=italia1] 100656 [host=godello1] 100653 [host=huxelrebe0] 100633 [host=godello0] 100620 [host=godello1] 100617 [host=huxelrebe1] 100604 [host=godello0] 100601 [host=italia0] 100598 [host=godello1] 100590 [host=baroque1] 100582 [host=godello1] 100580 [host=godello0] 100579 [host=baroque1] 100556 [host=italia1] 100554 [host=baroque1] 100552 [host=godello1] 100541 [host=huxelrebe0] 100540 [host=italia\ 0] 100534 [host=godello0] 100531 [host=godello0] 100529 [host=huxelrebe1] 100524 [host=huxelrebe1] 100505 [host=huxelrebe1] 100489 [host=elbling0] 100487 [host=italia1] 100484 [host=italia1] 100452 [host=huxelrebe1] 100433 [host=huxelrebe0] 100427 [host=fiano0] 100413 [host=huxelrebe1] 100407 [host=fiano0] 100402 [host=fiano0] 100398 [host=baroque1] 100388 [host=baroque1] 100376 [host=godello1] 100364 [host=italia0] 100362 [host=godello0] 100350 [host=godello1] 100340 [host=italia0] 100328 [host\ =pinot0] 99998 [host=elbling0] 99968 [host=pinot1] 99943 [host=italia0] 99933 [host=godello1] 99931 [host=godello1] 99923 [host=italia1] 99919 [host=fiano1] 99915 [host=baroque1] 99914 [host=italia0] 99912 [host=godello0] 99910 [host=huxelrebe0] 99908 [host=godello0] 99903 [host=godello0] 99896 [host=huxelrebe1] 99888 [host=fiano1] 99884 [host=huxelrebe0] 99880 [host=italia1] 99851 [host=baroque1] 99822 [host=godello0] 99761 [host=fiano0] 99721 [host=baroque1] 99697 [host=godello0] 99681 [host=f\ iano1] 99649 [host=huxelrebe1] 97720 [host=godello1] 97683 [host=elbling1] 97653 [host=godello0] 97622 [host=italia0] 97565 [host=chardonnay1] 97509 [host=italia0] 97478 [host=godello1] 97452 [host=italia0] 97415 [host=godello0] 97375 [host=italia0] 97328 [host=huxelrebe1] 97297 [host=godello0] 97280 [host=huxelrebe1] 97273 [host=huxelrebe1] 96996 [host=huxelrebe0] 96980 [host=huxelrebe0] 96965 [host=huxelrebe1] 96949 [host=huxelrebe1] 96898 [host=godello0] 96882 [host=baroque0] 96861 [host=baro\ que1] 96827 [host=godello1] 96803 [host=godello0] 96787 [host=godello1] 96773 [host=baroque0] 96762 [host=italia0] 96743 [host=godello0] 96719 [host=chardonnay1] 96691 [host=godello0] 96675 [host=huxelrebe1] 96661 [host=godello0] 96639 [host=godello0] 96614 [host=italia0] 96605 [host=godello0] 96588 [host=baroque0] 96561 [host=baroque1] 96553 [host=huxelrebe1] 96536 [host=huxelrebe0] 96519 [host=baroque1] 96510 [host=baroque1] 96498 [host=baroque1] 96487 [host=godello1] 96474 [host=baroque1] 964\ 49 [host=baroque1] 96339 [host=baroque1] 96322 [host=chardonnay1] 96298 [host=fiano1] 96282 [host=fiano1] 96258 [host=huxelrebe0] 96242 [host=godello1] 96220 [host=italia0] 96196 [host=baroque1] 96169 [host=godello1] 96148 [host=baroque1] 96126 [host=fiano1] 96082 [host=godello1] 96050 [host=godello1] 96015 [host=godello0] 95987 [host=chardonnay1] 95974 [host=huxelrebe1] 95961 [host=huxelrebe1] 95935 [host=godello0] 95905 [host=godello1] 95884 [host=huxelrebe1] 95863 [host=godello1] 95833 [host=\ chardonnay0] 95775 [host=godello0] 95693 [host=godello1] 95622 [host=chardonnay0] 95549 [host=pinot0] 95473 [host=huxelrebe0] 95418 [host=huxelrebe1] 95355 [host=italia0] 95331 [host=huxelrebe0] 95318 [host=chardonnay1] 95305 [host=huxelrebe1] 95286 [host=chardonnay0] 95270 [host=baroque1] 95248 [host=rimava0] 95230 [host=pinot0] 95209 [host=italia0] 95178 [host=nocera1] 95133 [host=pinot1] 95092 [host=italia0] 95082 [host=italia1] 94993 [host=huxelrebe1] 94971 [host=fiano1] 94963 [host=fiano1] \ 94958 [host=baroque1] 94949 [host=nocera0] 94940 [host=italia0] 94932 [host=italia0] 94924 [host=italia1] 94910 [host=baroque0] 94902 [host=huxelrebe0] 94891 [host=huxelrebe0] 94871 [host=rimava0] 94833 [host=baroque0] 94813 [host=baroque0] 94796 [host=fiano1] 94784 [host=huxelrebe0] 94773 [host=pinot1] 94758 [host=pinot0] 94753 [host=huxelrebe1] 94750 [host=huxelrebe0] 94748 [host=pinot1] 94739 [host=baroque1] 94735 [host=italia0] 94731 [host=rimava0] 94727 [host=baroque1] 94719 [host=baroque0]\ 94614 [host=chardonnay1] 94600 [host=pinot1] 94588 [host=huxelrebe0] 94583 [host=pinot1] 94575 [host=huxelrebe0] 94559 [host=baroque0] 94541 [host=huxelrebe1] 94519 [host=italia0] 94503 [host=italia1] 94498 [host=rimava0] 94064 [host=fiano1] 94046 [host=italia0] 94010 [host=pinot1] 93944 [host=rimava0] 93918 [host=italia1] 93901 [host=italia1] 93893 [host=baroque1] 93877 [host=pinot1] 93871 [host=huxelrebe0] 93867 [host=pinot1] 93862 [host=baroque0] 93853 [host=italia1] 93848 [host=rimava0] 938\ 44 [host=chardonnay0] 93842 [host=italia1] 93839 [host=baroque1] 93833 [host=baroque0] 93816 [host=pinot1] 93809 [host=baroque0] 93800 [host=baroque0] 93791 [host=baroque0] 93781 [host=baroque0] 93772 [host=baroque0] 93765 [host=baroque0] 93756 [host=baroque0] 93747 [host=baroque1] 93745 [host=huxelrebe1] 93734 [host=rimava1] 93717 [host=baroque0] 93642 [host=huxelrebe0] 93633 [host=baroque0] 93616 [host=pinot1] 93609 [host=baroque0] 93605 [host=baroque0] 93591 [host=baroque0] 93585 [host=baroqu\ e0] 93576 [host=nocera1] 93564 [host=pinot1] 93560 [host=baroque0] 93542 [host=baroque0] 93534 [host=chardonnay0] 93530 [host=baroque0] 93523 [host=italia1] 93512 [host=italia1] 93497 [host=baroque0] 93480 [host=baroque0] 93462 [host=italia1] 93449 [host=baroque0] 93438 [host=huxelrebe0] 93425 [host=italia0] 93414 [host=pinot1] 93395 [host=rimava1] 93379 [host=huxelrebe0] 93367 [host=baroque0] 93356 [host=huxelrebe0] 93334 [host=baroque0] 93322 [host=huxelrebe0] 93314 [host=baroque0] 93300 [host\ =pinot1] 93290 [host=italia1] 93275 [host=baroque0] 93259 [host=pinot1] 93245 [host=pinot1] 93232 [host=fiano0] 93213 [host=rimava1] 93204 [host=rimava1] 93183 [host=rimava1] 93157 [host=nocera1] 93114 [host=rimava1] 93090 [host=rimava0] 93056 [host=baroque0] 92991 [host=rimava1] 92933 [host=italia1] 92910 [host=rimava1] 92876 [host=italia0] 92813 [host=godello1] 92780 [host=godello1] 92732 [host=rimava0] 92695 [host=godello1] 92652 [host=godello0] 92618 [host=godello0] 92600 [host=godello1] 925\ 45 [host=godello1] 92529 [host=godello1] 92502 [host=godello1] 92446 [host=huxelrebe1] 92364 [host=huxelrebe1] 92294 [host=godello0] 92208 [host=fiano1] 92168 [host=rimava1] 92128 [host=godello1] 92111 [host=godello0] 92097 [host=godello0] 92074 [host=godello0] 92057 [host=godello0] 92027 [host=elbling0] 91992 [host=godello0] 91978 [host=godello0] 91964 [host=godello0] 91949 [host=baroque0] 91932 [host=godello0] 91905 [host=fiano0] 91887 [host=elbling0] 91849 [host=baroque0] 91836 [host=godello0\ ] 91786 [host=godello1] 91727 [host=baroque0] 91667 [host=godello1] 91609 [host=godello1] 91514 [host=baroque0] 91276 [host=godello0] 91143 [host=fiano1] 91000 [host=rimava0] 90849 [host=rimava0] 89340 [host=fiano0] 89251 [host=rimava0] 88801 [host=godello1] 88716 [host=italia1] 88641 [host=godello0] 88546 [host=godello1] 88444 [host=chardonnay1] 88334 [host=fiano1] 88218 [host=chardonnay0] 88034 [host=godello0] 87936 [host=italia1] 87844 [host=godello0] 87789 [host=godello1] 87722 [host=godello\ 1] 87656 [host=godello0] 87566 [host=baroque0] 87525 [host=godello1] 87443 [host=baroque1] 87299 [host=italia1] 87216 [host=italia1] 87140 [host=italia1] 87061 [host=huxelrebe0] 87014 [host=baroque0] 86908 [host=godello1] 86841 [host=baroque1] 86792 [host=godello1] 86742 [host=elbling1] 86648 [host=godello0] 86593 [host=godello1] 86524 [host=italia1] 86450 [host=italia1] 86402 [host=godello0] 86364 [host=godello0] 86305 [host=baroque0] 86258 [host=baroque1] 86194 [host=godello1] 86145 [host=gode\ llo1] 86077 [host=baroque1] 86033 [host=baroque1] 85985 [host=godello1] 85876 [host=godello1] 85813 [host=godello0] 85763 [host=godello1] 85701 [host=godello0] 85663 [host=baroque0] 85629 [host=godello1] 85550 [host=huxelrebe0] 85429 [host=godello1] 85255 [host=godello0] 85082 [host=baroque1] 84960 [host=huxelrebe0] 84880 [host=chardonnay0] 84581 [host=baroque1] 84489 [host=godello0] 84435 [host=godello0] 84351 [host=godello0] 84243 [host=godello1] 84109 [host=godello0] 83998 [host=godello1] 839\ 32 [host=italia0] 83833 [host=godello0] 83704 [host=italia0] 83581 [host=italia0] 83274 [host=italia0] 83008 [host=chardonnay0] 82909 [host=godello1] 82785 [host=godello0] 82627 [host=chardonnay0] 82450 [host=godello1] 82174 [host=baroque0] 81861 [host=godello0] 81618 [host=godello0] 81313 [host=huxelrebe0] 81088 [host=godello0] 80836 [host=godello0] 80628 [host=godello0] 80399 [host=godello0] 80233 [host=godello0] 79992 [host=godello1] 79875 [host=italia1] 79772 [host=baroque0] 79603 [host=gode\ llo0] 79485 [host=godello1] 79416 [host=huxelrebe0] 79371 [host=huxelrebe0] 79324 [host=godello0] 79168 [host=godello0] 79101 [host=godello0] 79038 [host=nocera0] 78929 [host=pinot0] 78792 [host=italia1] 78700 [host=nocera0] 78649 [host=godello1] 78614 [host=pinot1] 78583 [host=baroque0] 78537 [host=italia1] 78496 [host=godello0] 78465 [host=huxelrebe1] 78428 [host=godello0] 78398 [host=pinot1] 78387 [host=baroque0] 78376 [host=pinot1] 78360 [host=italia0] 78337 [host=godello1] 78317 [host=pinot\ 0] 78302 [host=pinot1] 78276 [host=nocera1] 78254 [host=godello1] 78217 [host=godello0] 78189 [host=italia1] 78153 [host=rimava1] 78134 [host=italia1] 78101 [host=godello1] 78063 [host=merlot1] 77990 [host=pinot0] 77933 [host=godello1] 77886 [host=huxelrebe1] 77825 [host=godello1] 77717 [host=godello1] 77570 [host=godello0] 77403 [host=huxelrebe1] 77229 [host=italia0] 77119 [host=fiano1] 76948 [host=chardonnay1] 67097 [host=baroque0] 66870 [host=rimava1] 66729 [host=godello1] 66587 [host=godello\ 1] 66525 [host=godello0] 66459 [host=godello1] 66401 [host=godello0] 65677 [host=baroque0] 65624 [host=rimava1] 65593 [host=nocera0] 65543 [host=godello0] 65468 [host=godello0] 65386 [host=godello0] 65359 [host=godello0] 65336 [host=rimava1] 65319 [host=baroque1] 65293 [host=baroque0] 65278 [host=nocera0] 65258 [host=godello0] 65244 [host=italia0] 65181 [host=baroque1] 65160 [host=godello0] 65139 [host=nocera0] 65119 [host=italia0] 65098 [host=rimava1] 65085 [host=godello0] 65064 [host=nocera0] \ 65031 [host=baroque0] 64963 [host=baroque1] 64803 [host=baroque1] 64668 [host=godello1] 64483 [host=nocera0] 64294 [host=nocera0] 64185 [host=nocera1] 64148 [host=godello0] 64047 [host=godello1] 63933 [host=nocera1] 63795 [host=godello0] 63740 [host=baroque0] 63704 [host=godello1] 63599 [host=godello1] 63530 [host=godello1] 63472 [host=nocera1] 63396 [host=godello0] 63371 [host=nocera1] 63355 [host=baroque0] 63342 [host=nocera1] 63328 [host=nocera1] 63315 [host=godello1] 63293 [host=nocera1] 632\ 09 [host=godello1] 63145 [host=godello1] 63081 [host=nocera1] 63061 [host=nocera1] 63048 [host=godello1] 63025 [host=godello0] 63006 [host=godello1] 62997 [host=nocera0] 62978 [host=godello0] 62971 [host=nocera1] 62964 [host=nocera1] 62929 [host=nocera0] 62816 [host=nocera0] 62740 [host=nocera0] 62699 [host=nocera0] 62647 [host=nocera0] 62591 [host=nocera1] 62526 [host=nocera0] 62441 [host=nocera1] 62359 [host=nocera1] 62306 [host=nocera0] 62244 [host=nocera0] 62150 [host=nocera0] 62073 [host=no\ cera1] 61996 [host=nocera1] 61817 [host=nocera1] 61736 [host=nocera0] 61636 [host=nocera0] 61523 [host=elbling1] 61299 [host=nocera1] 61246 [host=nocera1] 61081 [host=nocera1] 60968 [host=nocera0] 60904 [host=nocera0] 60869 [host=nocera0] 60835 [host=nocera0] 60759 [host=nocera0] 60705 [host=nocera1] 60679 [host=nocera1] 60661 [host=nocera1] 60651 [host=nocera0] 60630 [host=nocera1] 60615 [host=nocera0] 60587 [host=nocera1] 60384 [host=nocera0] 60163 [host=nocera0] 60105 [host=nocera0] 60026 [ho\ st=italia1] 59995 [host=nocera1] 59964 [host=italia1] 59626 [host=nocera0] 59613 [host=nocera0] 59602 [host=godello1] 59592 [host=godello1] 59511 [host=nocera1] 59498 [host=nocera0] 59480 [host=nocera1] 59420 [host=nocera0] 59370 [host=nocera0] 59302 [host=nocera0] 59220 [host=nocera0] 59179 [host=nocera0] 59121 [host=nocera0] 59082 [host=nocera0] 59055 [host=pinot0] 59028 [host=nocera0] 59016 [host=nocera1] 59006 [host=nocera0] 58988 [host=nocera1] 58972 [host=godello1] 58963 [host=godello1] 58\ 956 [host=nocera0] 58942 [host=godello1] 58937 [host=nocera0] 58919 [host=nocera1] 58888 [host=nocera1] 58856 [host=nocera0] 58834 [host=nocera1] 58756 [host=nocera0] 58734 [host=nocera1] 58723 [host=nocera0] 58714 [host=godello1] 58681 [host=nocera0] 58640 [host=nocera0] 58619 [host=pinot0] 58433 [host=nocera1] 58398 [host=nocera0] 58344 [host=nocera0] 58299 [host=godello1] 58249 [host=godello0] 58201 [host=godello0] 58156 [host=godello0] 58121 [host=nocera1] 58090 [host=nocera1] 57979 [host=no\ cera1] 57912 [host=nocera1] 57857 [host=nocera0] 57791 [host=nocera1] 57721 [host=nocera0] 57649 [host=nocera1] 57573 [host=nocera1] 57498 [host=nocera1] 57427 [host=nocera1] 57380 [host=nocera1] 57340 [host=nocera1] 57304 [host=godello1] 57279 [host=godello1] 57245 [host=godello1] 57189 [host=godello0] 57156 [host=godello1] 57126 [host=godello0] 57103 [host=godello1] 57013 [host=godello1] 56974 [host=nocera0] 56936 [host=godello1] 56891 [host=nocera0] 56745 [host=nocera0] 56707 [host=nocera0] 5\ 6671 [host=godello1] 56492 [host=nocera0] 56406 [host=godello1] 56370 [host=godello1] 55353 [host=godello0] 55270 [host=nocera0] 53940 [host=pinot1] 53825 [host=nocera1] 53503 [host=godello0] 53015 [host=godello0] 52776 [host=pinot1] 52627 [host=godello1] 50403 [host=nocera0] 50386 [host=baroque0] 50365 [host=baroque1] 50307 [host=nocera0] 50275 [host=fiano1] 50265 [host=pinot0] 36764 [host=gall-mite] 36719 [host=bush-cricket] 36590 [host=gall-mite] 36525 [host=moss-bug] 36087 [host=rice-weevil]\ 35899 [host=itch-mite] 35825 [host=rice-weevil] 35673 [host=itch-mite] 35479 [host=gall-mite] 35317 [host=gall-mite] 35182 [host=rice-weevil] 34942 [host=gall-mite] 34747 [host=gall-mite] 34582 [host=scape-moth] 34536 [host=scape-moth] 34487 [host=grain-weevil] 34431 [host=bush-cricket] 34360 [host=rice-weevil] 34278 [host=rice-weevil] 34196 [host=scape-moth] 33686 [host=rice-weevil] template as basis? using template as basis. Failure / basis pass flights: 169960 / 168254 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd Basis pass b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#b1b89f9009f2390652e0061bd7b24fc40732bc70-cabd96ad03603a63a97e701fb30a03341ca0e2ec git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#829b0f1a7cda1bccdf44a379fb3a96e519a7e8\ cd-01774004c7f7fdc9c1e8f1715f70d3b913f8d491 git://xenbits.xen.org/xen.git#4388144c44c4dd9e9b7df97938ef08ffa85eec07-fe234237b6fc8afc5d8265850169ceeb3d2f81fd Loaded 12651 nodes in revision graph Searching for test results: 168254 [host=himrod2] 168258 [host=himrod1] 168262 [host=himrod1] 168267 [host=himrod1] 168275 [host=himrod1] 168276 [host=himrod1] 168277 [host=himrod1] 168278 [host=himrod1] 168279 [host=himrod1] 168280 [host=himrod1] 168281 [host=himrod1] 168282 [host=himrod1] 168271 [host=himrod1] 168284 [host=himrod1] 168286 [host=himrod1] 168285 [host=himrod1] 168287 [host=himrod1] 168290 [host=himrod1] 168295 [host=himrod2] 168299 [host=himrod1] 168303 [host=himrod2] 168308 [host=himrod2] 168312 [host=himrod1] 168314 [host=himrod1] 168316 [host=himrod1] 168320 [host=himrod1] 168329 [host=himrod2] 168333 [host=himrod2] 168340 [host=himrod1] 168344 [host=himrod2] 168352 [host=himrod2] 168356 [host=himrod2] 168359 [host=himrod2] 168364 [host=himrod2] 168366 [host=himrod2] 168372 [host=himrod2] 168377 [host=himrod2] 168381 [host=himrod2] 168385 [host=himrod1] 168387 [host=himrod1] 168389 [host=himrod1] 168392 [host=himrod1] 168395 [host=himrod2] 168397 [host=himrod2] 168401 [host=himrod1] 168402 [host=himrod1] 168404 [host=himrod1] 168405 [host=himrod1] 168407 [host=himrod2] 168408 [host=himrod2] 168411 [host=himrod1] 168415 [host=himrod1] 168416 [host=himrod1] 168418 [host=himrod2] 168419 [host=himrod2] 168421 [host=himrod1] 168422 [host=himrod1] 168424 [host=himrod1] 168425 [host=himrod2] 168426 [host=himrod2] 168427 [host=himrod2] 168430 [host=himrod2] 168431 [host=himrod1] 168433 [host=himrod1] 168436 [host=himrod1] 168438 [host=himrod2] 168439 [host=himrod2] 168440 [host=himrod2] 168441 [host=himrod2] 168443 [host=himrod1] 168444 [host=himrod1] 168445 [host=himrod1] 168446 [host=himrod2] 168447 [host=himrod2] 168449 [host=himrod2] 168451 [host=himrod2] 168453 [host=himrod1] 168455 [host=himrod1] 168456 [host=himrod2] 168457 [host=himrod2] 168458 [host=himrod2] 168459 [host=himrod2] 168461 [host=himrod2] 168462 [host=himrod1] 168464 [host=himrod1] 168468 [host=himrod2] 168469 [host=himrod2] 168472 [host=himrod1] 168475 [host=himrod2] 168477 [host=himrod1] 168478 [host=himrod1] 168479 [host=himrod1] 168489 [host=himrod2] 168490 [host=himrod1] 168496 [host=himrod1] 168504 [host=himrod2] 168508 [host=himrod2] 168512 [host=himrod1] 168519 [host=himrod1] 168521 [host=himrod1] 168524 [host=himrod2] 168525 [host=himrod2] 168526 [host=himrod2] 168530 [host=himrod1] 168532 [host=himrod1] 168533 [host=himrod1] 168534 [host=himrod1] 168535 [host=himrod1] 168536 [host=himrod1] 168538 [host=himrod2] 168539 [host=himrod2] 168541 [host=himrod1] 168542 [host=himrod1] 168543 [host=himrod1] 168544 [host=himrod1] 168546 [host=himrod2] 168548 [host=himrod1] 168550 [host=himrod1] 168551 [host=himrod1] 168552 [host=himrod1] 168553 [host=himrod1] 168554 [host=himrod1] 168555 [host=himrod1] 168556 [host=himrod1] 168557 [host=himrod1] 168558 [host=himrod1] 168559 [host=himrod1] 168560 [host=himrod1] 168561 [host=himrod2] 168562 [host=himrod2] 168564 [host=himrod1] 168565 [host=himrod1] 168566 [host=himrod1] 168567 [host=himrod1] 168568 [host=himrod1] 168569 [host=himrod1] 168570 [host=himrod2] 168572 [host=himrod2] 168574 [host=himrod2] 168576 [host=himrod1] 168578 [host=himrod2] 168579 [host=himrod2] 168581 [host=himrod2] 168583 [host=himrod2] 168584 [host=himrod2] 168587 [host=himrod1] 168588 [host=himrod1] 168602 [host=himrod1] 168606 [host=himrod1] 168609 [host=himrod1] 168610 [host=himrod1] 168614 [host=himrod1] 168616 [host=himrod1] 168617 [host=himrod1] 168618 [host=himrod1] 168622 [host=himrod1] 168623 [host=himrod1] 168625 [host=himrod1] 168627 [host=himrod1] 168634 [host=himrod2] 168629 [host=himrod2] 168635 [host=himrod1] 168637 [host=himrod1] 168639 [host=himrod1] 168640 [host=himrod1] 168645 [host=himrod1] 168648 [host=himrod1] 168651 [host=himrod1] 168653 [host=himrod1] 168661 [host=himrod2] 168663 [host=himrod2] 168664 [host=himrod2] 168668 [host=himrod1] 168670 [host=himrod1] 168672 [host=himrod1] 168673 [host=himrod1] 168675 [host=himrod1] 168678 [host=himrod1] 168679 [host=himrod1] 168680 [host=himrod1] 168682 [host=himrod1] 168683 [host=himrod1] 168685 [host=himrod1] 168686 [host=himrod1] 168687 [host=himrod1] 168688 [host=himrod1] 168689 [host=himrod1] 168690 [host=himrod1] 168692 [host=himrod1] 168693 [host=himrod1] 168694 [host=himrod1] 168695 [host=himrod1] 168697 [host=himrod1] 168698 [host=himrod2] 168702 [host=himrod2] 168703 [host=himrod2] 168707 [host=himrod2] 168708 [host=himrod1] 168710 [host=himrod1] 168728 [host=himrod1] 168713 [host=himrod1] 168717 [host=himrod1] 168721 [host=himrod1] 168723 [host=himrod1] 168725 [host=himrod1] 168727 [host=himrod1] 168729 [host=himrod1] 168730 [host=himrod1] 168731 [host=himrod1] 168732 [host=himrod1] 168734 [host=himrod2] 168735 [host=himrod2] 168736 [host=himrod2] 168738 [host=himrod1] 168739 [host=himrod1] 168741 [host=himrod2] 168745 [host=himrod2] 168746 [host=himrod2] 168747 [host=himrod1] 168748 [host=himrod1] 168749 [host=himrod1] 168751 [host=himrod1] 168752 [host=himrod1] 168753 [host=himrod1] 168754 [host=himrod1] 168757 [host=himrod1] 168758 [host=himrod1] 168759 [host=himrod1] 168762 [host=himrod1] 168766 [host=himrod2] 168770 [host=himrod1] 168774 [host=himrod1] 168777 [host=himrod1] 168779 [host=himrod1] 168780 [host=himrod1] 168783 [host=himrod1] 168785 [host=himrod1] 168788 [host=himrod2] 168789 [host=himrod2] 168790 [host=himrod1] 168793 [host=himrod1] 168799 [host=himrod1] 168801 [host=himrod1] 168804 [host=himrod1] 168805 [host=himrod1] 168806 [host=himrod1] 168808 [host=himrod1] 168812 [host=himrod1] 168813 [host=himrod1] 168814 [host=himrod1] 168817 [host=himrod1] 168819 [host=himrod1] 168820 [host=himrod1] 168822 [host=himrod1] 168823 [host=himrod1] 168824 [host=himrod1] 168826 [host=himrod2] 168827 [host=himrod2] 168829 [host=himrod1] 168831 [host=himrod1] 168832 [host=himrod1] 168834 [host=himrod1] 168837 [host=himrod2] 168844 [host=himrod1] 168854 [host=himrod1] 168858 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168859 [host=himrod1] 168865 [host=himrod1] 168981 fail irrelevant 169004 [host=himrod2] 169046 [host=himrod2] 169069 [host=himrod2] 169102 [host=himrod1] 169117 [host=himrod2] 169128 [host=himrod2] 169135 [host=himrod1] 169141 [host=himrod2] 169144 [host=himrod2] 169148 [host=himrod2] 169150 [host=himrod2] 169153 [host=himrod2] 169156 [host=himrod2] 169161 [host=himrod2] 169165 [host=himrod2] 169169 [host=himrod1] 169173 [host=himrod2] 169177 [host=himrod1] 169187 [host=himrod1] 169196 [host=himrod1] 169202 [host=himrod1] 169209 [host=himrod1] 169218 [host=himrod1] 169223 [host=himrod2] 169226 [host=himrod1] 169227 [host=himrod1] 169229 fail irrelevant 169232 [host=himrod1] 169234 fail irrelevant 169235 [host=himrod2] 169242 fail irrelevant 169247 [host=himrod2] 169248 [host=himrod1] 169258 [host=himrod1] 169263 [host=himrod2] 169265 [host=himrod1] 169266 [host=himrod1] 169271 fail irrelevant 169272 fail irrelevant 169274 [host=himrod2] 169275 [host=himrod2] 169277 [host=himrod2] 169278 [host=himrod2] 169279 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169280 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169281 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169282 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169283 fail bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169293 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169285 fail 676084303d261cb1e4b9bfacea88284adc08d243 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169287 [host=himrod1] 169288 [host=himrod1] 169289 [host=himrod1] 169290 [host=himrod1] 169291 [host=himrod1] 169295 [host=himrod2] 169297 [host=himrod2] 169299 [host=himrod2] 169300 [host=himrod2] 169302 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169305 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169306 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169307 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169308 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169310 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169311 [host=himrod1] 169312 [host=himrod1] 169313 [host=himrod1] 169314 [host=himrod1] 169315 [host=himrod1] 169316 [host=himrod1] 169317 [host=himrod1] 169319 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169321 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169323 [host=himrod1] 169324 [host=himrod1] 169325 [host=himrod1] 169326 fail irrelevant 169327 fail irrelevant 169329 fail irrelevant 169331 [host=himrod1] 169334 [host=himrod2] 169335 [host=himrod2] 169338 [host=himrod2] 169339 [host=himrod1] 169341 [host=himrod1] 169342 [host=himrod2] 169343 [host=himrod2] 169344 [host=himrod2] 169345 [host=himrod2] 169349 [host=himrod2] 169350 [host=himrod1] 169352 [host=himrod1] 169357 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169358 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169359 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169360 [host=himrod2] 169362 [host=himrod2] 169363 [host=himrod2] 169364 [host=himrod2] 169365 [host=himrod2] 169366 [host=himrod2] 169370 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169371 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169372 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169374 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169375 [host=himrod1] 169376 [host=himrod1] 169377 [host=himrod1] 169378 [host=himrod1] 169379 [host=himrod1] 169380 [host=himrod1] 169381 [host=himrod1] 169382 [host=himrod1] 169384 [host=himrod1] 169385 [host=himrod1] 169387 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169388 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169389 [host=himrod1] 169390 [host=himrod1] 169391 [host=himrod1] 169392 [host=himrod2] 169393 [host=himrod2] 169394 [host=himrod2] 169395 [host=himrod2] 169396 [host=himrod2] 169397 [host=himrod2] 169398 [host=himrod2] 169399 [host=himrod2] 169400 [host=himrod1] 169401 [host=himrod1] 169402 [host=himrod1] 169404 [host=himrod1] 169405 [host=himrod1] 169406 [host=himrod1] 169407 [host=himrod1] 169408 [host=himrod1] 169410 [host=himrod1] 169411 [host=himrod1] 169413 [host=himrod1] 169414 [host=himrod1] 169416 [host=himrod1] 169417 [host=himrod1] 169418 [host=himrod1] 169419 [host=himrod1] 169420 [host=himrod1] 169421 [host=himrod1] 169422 [host=himrod1] 169424 [host=himrod1] 169425 [host=himrod1] 169427 [host=himrod1] 169428 [host=himrod2] 169429 [host=himrod2] 169430 [host=himrod2] 169431 [host=himrod2] 169432 [host=himrod2] 169435 [host=himrod1] 169436 [host=himrod1] 169437 [host=himrod1] 169438 [host=himrod1] 169439 fail irrelevant 169440 fail irrelevant 169441 fail irrelevant 169443 fail irrelevant 169445 [host=himrod1] 169446 [host=himrod1] 169448 [host=himrod1] 169449 [host=himrod1] 169450 [host=himrod1] 169451 [host=himrod1] 169452 [host=himrod1] 169453 fail irrelevant 169454 fail irrelevant 169455 fail irrelevant 169456 fail irrelevant 169457 fail irrelevant 169458 fail irrelevant 169459 [host=himrod1] 169460 [host=himrod1] 169461 [host=himrod1] 169462 [host=himrod1] 169463 [host=himrod1] 169464 [host=himrod1] 169465 [host=himrod1] 169467 [host=himrod1] 169468 [host=himrod1] 169469 [host=himrod1] 169470 [host=himrod1] 169471 [host=himrod1] 169473 [host=himrod1] 169476 [host=himrod1] 169478 [host=himrod1] 169479 [host=himrod1] 169480 [host=himrod1] 169481 [host=himrod1] 169512 fail irrelevant 169482 [host=himrod1] 169484 [host=himrod1] 169485 fail irrelevant 169486 fail irrelevant 169487 fail irrelevant 169489 fail irrelevant 169490 [host=himrod1] 169491 [host=himrod1] 169492 [host=himrod1] 169494 [host=himrod1] 169496 [host=himrod1] 169497 [host=himrod1] 169498 [host=himrod1] 169500 fail irrelevant 169501 [host=himrod1] 169503 [host=himrod1] 169504 [host=himrod1] 169505 [host=himrod1] 169506 [host=himrod1] 169508 [host=himrod2] 169509 [host=himrod2] 169510 [host=himrod2] 169511 [host=himrod2] 169513 fail irrelevant 169514 fail irrelevant 169515 fail irrelevant 169516 fail irrelevant 169517 fail irrelevant 169518 [host=himrod1] 169519 [host=himrod1] 169520 [host=himrod1] 169521 fail irrelevant 169522 fail irrelevant 169523 fail irrelevant 169524 fail irrelevant 169525 fail irrelevant 169526 fail irrelevant 169527 fail irrelevant 169529 [host=himrod2] 169530 [host=himrod1] 169532 [host=himrod1] 169533 [host=himrod2] 169534 [host=himrod2] 169535 [host=himrod2] 169536 fail irrelevant 169538 fail irrelevant 169539 [host=himrod1] 169540 [host=himrod1] 169542 [host=himrod1] 169543 [host=himrod1] 169544 [host=himrod1] 169548 [host=himrod1] 169549 [host=himrod1] 169551 [host=himrod1] 169553 [host=himrod2] 169554 [host=himrod2] 169556 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169558 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169559 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169561 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 b881cb95cb034466d3dd9be52f5a7e6594148a90 169564 [host=himrod2] 169567 [host=himrod1] 169568 [host=himrod1] 169569 [host=himrod1] 169571 [host=himrod2] 169574 [host=himrod2] 169585 fail irrelevant 169575 [host=himrod2] 169578 [host=himrod2] 169579 [host=himrod2] 169580 [host=himrod2] 169582 [host=himrod1] 169583 [host=himrod1] 169586 [host=himrod2] 169587 [host=himrod2] 169588 [host=himrod2] 169589 fail irrelevant 169590 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169592 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169593 [host=himrod2] 169594 [host=himrod2] 169596 [host=himrod2] 169597 [host=himrod2] 169598 [host=himrod2] 169599 [host=himrod1] 169600 [host=himrod1] 169602 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169604 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169606 [host=himrod2] 169607 [host=himrod2] 169610 [host=himrod2] 169612 [host=himrod2] 169615 [host=himrod1] 169618 fail irrelevant 169620 fail irrelevant 169621 fail irrelevant 169623 [host=himrod1] 169625 fail irrelevant 169626 [host=himrod1] 169628 [host=himrod1] 169631 [host=himrod1] 169632 fail irrelevant 169633 fail irrelevant 169634 fail irrelevant 169636 [host=himrod1] 169637 [host=himrod1] 169639 [host=himrod1] 169641 [host=himrod2] 169642 [host=himrod2] 169643 [host=himrod2] 169644 [host=himrod1] 169646 [host=himrod1] 169647 [host=himrod1] 169648 [host=himrod1] 169649 [host=himrod1] 169650 [host=himrod1] 169651 [host=himrod1] 169653 [host=himrod2] 169655 [host=himrod2] 169656 [host=himrod2] 169657 [host=himrod2] 169658 [host=himrod2] 169659 [host=himrod2] 169660 [host=himrod2] 169678 [host=himrod2] 169661 [host=himrod2] 169663 [host=himrod2] 169665 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169667 [host=himrod1] 169668 [host=himrod1] 169670 [host=himrod2] 169672 [host=himrod2] 169673 [host=himrod2] 169674 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169675 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169676 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169677 [host=himrod2] 169679 [host=himrod2] 169680 [host=himrod1] 169681 [host=himrod1] 169682 [host=himrod1] 169683 [host=himrod1] 169684 [host=himrod2] 169685 [host=himrod2] 169687 [host=himrod2] 169688 [host=himrod2] 169689 [host=himrod1] 169690 [host=himrod1] 169691 [host=himrod1] 169692 [host=himrod1] 169693 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169695 [host=himrod1] 169697 [host=himrod1] 169698 [host=himrod2] 169700 [host=himrod1] 169701 [host=himrod1] 169702 [host=himrod1] 169703 [host=himrod2] 169704 [host=himrod2] 169705 [host=himrod2] 169706 [host=himrod2] 169707 [host=himrod2] 169708 [host=himrod2] 169709 [host=himrod2] 169710 [host=himrod2] 169711 [host=himrod2] 169712 [host=himrod2] 169713 [host=himrod2] 169715 [host=himrod2] 169716 [host=himrod2] 169718 [host=himrod2] 169719 [host=himrod2] 169721 [host=himrod2] 169722 [host=himrod2] 169724 [host=himrod2] 169726 [host=himrod1] 169728 [host=himrod1] 169730 [host=himrod1] 169731 [host=himrod2] 169732 [host=himrod2] 169733 [host=himrod2] 169734 [host=himrod2] 169735 [host=himrod2] 169738 [host=himrod2] 169740 [host=himrod1] 169742 [host=himrod1] 169744 [host=himrod1] 169746 [host=himrod1] 169750 [host=himrod2] 169754 [host=himrod2] 169757 [host=himrod1] 169758 [host=himrod2] 169759 [host=himrod2] 169761 [host=himrod2] 169763 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169764 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169766 [host=himrod2] 169769 [host=himrod1] 169770 [host=himrod1] 169772 [host=himrod1] 169776 [host=himrod2] 169778 [host=himrod2] 169780 [host=himrod1] 169783 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169784 [host=himrod1] 169786 [host=himrod1] 169791 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169793 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169796 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169797 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169799 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169802 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169803 [host=himrod2] 169804 [host=himrod2] 169806 [host=himrod1] 169808 [host=himrod1] 169810 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169811 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169812 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169814 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169815 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169816 fail irrelevant 169821 [host=himrod2] 169828 [host=himrod2] 169832 [host=himrod2] 169835 [host=himrod2] 169837 fail irrelevant 169839 fail irrelevant 169841 [host=himrod1] 169842 [host=himrod1] 169845 [host=himrod1] 169848 fail irrelevant 169854 [host=himrod2] 169858 [host=himrod2] 169865 [host=himrod2] 169866 [host=himrod2] 169868 [host=himrod1] 169872 [host=himrod1] 169873 [host=himrod1] 169874 fail irrelevant 169878 fail irrelevant 169879 fail irrelevant 169880 fail irrelevant 169882 fail irrelevant 169883 fail irrelevant 169885 fail irrelevant 169889 [host=himrod2] 169892 [host=himrod1] 169894 [host=himrod1] 169901 fail irrelevant 169904 [host=himrod1] 169908 [host=himrod1] 169905 [host=himrod1] 169910 [host=himrod2] 169913 [host=himrod2] 169914 [host=himrod2] 169915 [host=himrod2] 169916 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169917 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169919 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169920 [host=himrod2] 169921 [host=himrod2] 169922 [host=himrod2] 169923 [host=himrod1] 169924 [host=himrod1] 169925 [host=himrod1] 169926 [host=himrod1] 169927 [host=himrod1] 169928 [host=himrod1] 169930 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169931 [host=himrod1] 169933 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169934 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169935 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169936 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169937 [host=himrod1] 169941 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169943 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169944 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169945 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169947 pass b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169948 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169946 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169949 pass b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169950 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169951 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 4b68d12d98b8790d8002fcc2c25a9d713374a4d7 169952 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169953 fail 9ac8c85d501f07a8e4f8b85b676cd03b73ec5bd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1f410b0c7455748021be4ede59e7a0c0a2ffb1c4 169954 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db faecea18d252f97c6ad41f0f457566ff2c125b8d 169956 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169955 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169957 fail 7bc8b1d9f412507d579f21ea9af56fced81e7827 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169958 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169959 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169960 fail cabd96ad03603a63a97e701fb30a03341ca0e2ec 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fe234237b6fc8afc5d8265850169ceeb3d2f81fd 169961 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169962 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169964 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 169965 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Searching for interesting versions Result found: flight 169947 (pass), for basis pass Result found: flight 169948 (fail), for basis failure (at ancestor ~126) Repro found: flight 169949 (pass), for basis pass Repro found: flight 169950 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 169958 (pass), for last pass Result found: flight 169959 (fail), for first failure Repro found: flight 169961 (pass), for last pass Repro found: flight 169962 (fail), for first failure Repro found: flight 169964 (pass), for last pass Repro found: flight 169965 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/169965/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu pnmtopng: 180 colors found Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 169965: tolerable ALL FAIL flight 169965 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/169965/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64 6 xen-build fail baseline untested jobs: build-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun May 01 16:34:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 16:34:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318494.538293 (Exim 4.92) (envelope-from ) id 1nlCW7-0005dR-5t; Sun, 01 May 2022 16:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318494.538293; Sun, 01 May 2022 16:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCW7-0005dK-2I; Sun, 01 May 2022 16:33:51 +0000 Received: by outflank-mailman (input) for mailman id 318494; Sun, 01 May 2022 16:33:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCW5-0005dA-6T; Sun, 01 May 2022 16:33:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCW5-0001ly-2M; Sun, 01 May 2022 16:33:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlCW4-0008Hy-Ql; Sun, 01 May 2022 16:33:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlCW4-0001T1-QI; Sun, 01 May 2022 16:33:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jM1RWp7ho8zWUBZ1Br3/Im82F4Cyn8rNxm6h6CiX1xs=; b=DBMurWoyKXrAyo/e2IapoX10cp aXrhqyTbIwUtFQUBuoh1ZgYq8j8ihc5rNZtJsdSRpNQmYFdD/9KuyDcA3TUGthznQ5MoerGTR0KD6 CuFzl0S2RjMICWxaoRbaCcawBmnX1imFhuufEdtesLRblYy9nUw1q82Fi1lXSALvt1Pw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169963: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 16:33:48 +0000 flight 169963 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169963/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 743 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 17:30:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 17:30:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318502.538304 (Exim 4.92) (envelope-from ) id 1nlDOw-0003Mv-CQ; Sun, 01 May 2022 17:30:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318502.538304; Sun, 01 May 2022 17:30:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlDOw-0003Mo-9V; Sun, 01 May 2022 17:30:30 +0000 Received: by outflank-mailman (input) for mailman id 318502; Sun, 01 May 2022 17:30:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlDOv-0003Me-On; Sun, 01 May 2022 17:30:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlDOv-00038p-M8; Sun, 01 May 2022 17:30:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlDOv-00014v-BM; Sun, 01 May 2022 17:30:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlDOv-0008QU-Aw; Sun, 01 May 2022 17:30:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7/7iVcroohqrBijNXQy46SwJAy2hgt+n/SdgRdztYD0=; b=6fVtbQlHcwkcasD0IM1OAUPrNT u3ItWFDZlXcHBfQ1VSSGubOtSnpPCafWnQ3ju1CGtAxnfJ4hvenOqMy0cQ6mEgRYB2Us8wA78hyov igUmPGAL4tBX0Dm3hI7UvvLoiB8VuV6X/PpWJPAVNnPnTaB9wabfPsu5YU9F+ibR9IWk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169966: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 17:30:29 +0000 flight 169966 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169966/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 744 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 19:55:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 19:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318510.538315 (Exim 4.92) (envelope-from ) id 1nlFeq-0000Wo-Lj; Sun, 01 May 2022 19:55:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318510.538315; Sun, 01 May 2022 19:55:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlFeq-0000Wh-IU; Sun, 01 May 2022 19:55:04 +0000 Received: by outflank-mailman (input) for mailman id 318510; Sun, 01 May 2022 19:55:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlFeq-0000WX-1K; Sun, 01 May 2022 19:55:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlFep-0005jA-V6; Sun, 01 May 2022 19:55:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlFep-0008NF-GD; Sun, 01 May 2022 19:55:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlFep-00074N-Fi; Sun, 01 May 2022 19:55:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6RlV3iGzD+oaSkPcqatGEXsiVilntaKGLzOMRs9tFRM=; b=PiE2B12OyjaYVDl9auc9w3IVAM OTL00uZSX6iSDHievZ1Ld8TXYYx6KSkQTu/69SuZazdfamcm/2J6QipJX2mNcmlwJ9vdKStU1/miP CF0VFD+8x5ZPrNdczDYc3XTYydVIi4g48LakVjSoRdjGDi3pScwAGKisIC9vcIHt5e50=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169969: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 19:55:03 +0000 flight 169969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169969/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 745 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 22:11:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 22:11:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318520.538325 (Exim 4.92) (envelope-from ) id 1nlHls-0005x2-Cw; Sun, 01 May 2022 22:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318520.538325; Sun, 01 May 2022 22:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlHls-0005wv-9q; Sun, 01 May 2022 22:10:28 +0000 Received: by outflank-mailman (input) for mailman id 318520; Sun, 01 May 2022 22:10:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlHlq-0005wp-P3 for xen-devel@lists.xenproject.org; Sun, 01 May 2022 22:10:26 +0000 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [2607:f8b0:4864:20::112f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fc032a1-c99b-11ec-a405-831a346695d4; Mon, 02 May 2022 00:10:25 +0200 (CEST) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-2ebf4b91212so131986067b3.8 for ; Sun, 01 May 2022 15:10:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fc032a1-c99b-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8WXuaqzf5H6JbTMCrSNoDEe2cTNFwsekkVTcYWtQXX8=; b=NIMD1MgHFUA8qDcBtlkRUl6QwAMsrYm2LFtmvl8/1tnPPHxRUpA1yQ5LUAYctdi06T TOsD/Pv8VDI71Se+5p7Pej/mhD4qgf+k14w13KqKouOzghHkUgz02mr9ht1C5Q+AQUuh 0KviUgNPzfaZP4wqvtLikTYkYLlECRohNbsEu9h/EpakyyZgJrAzbiZa3kK32wRWZAP8 v8ZanNeCIK/+zl9E9gG5DRVG3Hrx7mW8dweXwuLE07vm1+xVHs5Z+8j39wJwgxAr3TB0 sIVDxA8IhVVZXSJeGhmsZmd4DHlgLnJXoULjO7WRPuijicppJaGPBhttKcLNbK4Ul/z4 EqFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8WXuaqzf5H6JbTMCrSNoDEe2cTNFwsekkVTcYWtQXX8=; b=Nz/Clw8R4CQOsuRAwwUQThWjQ0g7B9dtkKJu28X0Lj4sSz6BzFdSWXOrr98mtOqf0C jrOxtVk9EmNGYIFCumSpPqm2GUZlGV1ejp1xcysmHVCjeVPLrKVIeI8/0Dzl7N4aSp2H hiYDQcVlHUXIXvagvi93PPPY4V2AWxs5RkmTiecOaxxFFDQc2EauIg6lNsUkwHVTmSV7 gLQ4P7s68pNXe6vofyc03a5PcgzJ6wxbIbt3ia9bblCLQyoKThd/HXgcflDDO2yjLxc2 2rVjjqaGVtr69q7+IJIK1qKtXZrfl9SedqXtlL5Nn+lHWNe0RcuczEAIlM8NHkXMAgHg JDIA== X-Gm-Message-State: AOAM532vKpkOHRmLOJdCFzjXBzGUTmksMNo+pBY7SuxQPJiDiRWeSfUw jFwXXkMXoT6srk4EYyl3tF3eX4padDAIJHj2GbzZww== X-Google-Smtp-Source: ABdhPJwVRMVN6PYWPNDrbRGkbqET+tO2dajvHrcjRYlUisQxn4zRaAT7N9xEe7+WAUzHysUVA7VWrMEEZM+qWd2jZ7k= X-Received: by 2002:a81:2154:0:b0:2f4:d79e:35dc with SMTP id h81-20020a812154000000b002f4d79e35dcmr9302689ywh.126.1651443023815; Sun, 01 May 2022 15:10:23 -0700 (PDT) MIME-Version: 1.0 References: <20220427154111.529975-1-kuba@kernel.org> <20220427154111.529975-2-kuba@kernel.org> In-Reply-To: <20220427154111.529975-2-kuba@kernel.org> From: Linus Walleij Date: Mon, 2 May 2022 00:10:12 +0200 Message-ID: Subject: Re: [PATCH net-next 01/14] eth: remove copies of the NAPI_POLL_WEIGHT define To: Jakub Kicinski Cc: davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org, ulli.kroll@googlemail.com, mlindner@marvell.com, stephen@networkplumber.org, nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, matthias.bgg@gmail.com, grygorii.strashko@ti.com, wei.liu@kernel.org, paul@xen.org, prabhakar.mahadev-lad.rj@bp.renesas.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Wed, Apr 27, 2022 at 5:41 PM Jakub Kicinski wrote: > Defining local versions of NAPI_POLL_WEIGHT with the same > values in the drivers just makes refactoring harder. > > Drop the special defines in a bunch of drivers where the > removal is relatively simple so grouping into one patch > does not impact reviewability. > > Signed-off-by: Jakub Kicinski > --- > CC: ulli.kroll@googlemail.com > CC: linus.walleij@linaro.org > CC: mlindner@marvell.com > CC: stephen@networkplumber.org > CC: nbd@nbd.name > CC: john@phrozen.org > CC: sean.wang@mediatek.com > CC: Mark-MC.Lee@mediatek.com > CC: matthias.bgg@gmail.com > CC: grygorii.strashko@ti.com > CC: wei.liu@kernel.org > CC: paul@xen.org > CC: prabhakar.mahadev-lad.rj@bp.renesas.com > CC: linux-arm-kernel@lists.infradead.org > CC: linux-mediatek@lists.infradead.org > CC: linux-omap@vger.kernel.org > CC: xen-devel@lists.xenproject.org Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij From xen-devel-bounces@lists.xenproject.org Sun May 01 22:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 22:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318526.538337 (Exim 4.92) (envelope-from ) id 1nlI9H-00006j-8u; Sun, 01 May 2022 22:34:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318526.538337; Sun, 01 May 2022 22:34:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlI9H-00006c-67; Sun, 01 May 2022 22:34:39 +0000 Received: by outflank-mailman (input) for mailman id 318526; Sun, 01 May 2022 22:34:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlI9F-00006S-KQ; Sun, 01 May 2022 22:34:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlI9F-00009s-JN; Sun, 01 May 2022 22:34:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlI9F-00086c-8q; Sun, 01 May 2022 22:34:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlI9F-0000yj-8O; Sun, 01 May 2022 22:34:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gdqi0EUADxqer6TP4G5JygXUsNvxLOlpvBxzX4dpN1I=; b=FY6Vpj+UYi71xyM+h0K1WYq0p4 BP3UMuh6SP7fTLQRaaPFRSqIxAy4uLn1K3oTyqQn2Tz0gtSz1f6AT36+Z3ea4iW1bHcdK0+W3rNlp 03PNtfq74/cya0XR3U1ghV8RUYHL/b/hSA0iBEhq7FQJJwTkjMw0xk0j41OnGFqg8Cac=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169970: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 22:34:37 +0000 flight 169970 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169970/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 746 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 01 23:17:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 01 May 2022 23:17:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318539.538348 (Exim 4.92) (envelope-from ) id 1nlIo9-0004cL-HF; Sun, 01 May 2022 23:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318539.538348; Sun, 01 May 2022 23:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlIo9-0004cE-Dk; Sun, 01 May 2022 23:16:53 +0000 Received: by outflank-mailman (input) for mailman id 318539; Sun, 01 May 2022 23:16:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlIo7-0004c4-Ns; Sun, 01 May 2022 23:16:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlIo7-0000xD-KK; Sun, 01 May 2022 23:16:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlIo7-0000sa-7Y; Sun, 01 May 2022 23:16:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlIo7-0004lk-78; Sun, 01 May 2022 23:16:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MCsrfHsH4w5+U+6H81MlWqWfPKUtpdEyom1TwcXVEiU=; b=zWo8a1hy1MOK4V1TthOOcn1ege 9B5zaXpiE6zdPy8rU5sSBlD2QQT6pj4k4DqeArMBWt3Nrbhn2nS8KodFTn5l/pKDeG6dJOBmIGQtk aVuo1voNnJ8LtTYrpPyMIeKcZsKe8by7lg8qh9qdHkK7IRDJMMfExt7EO2UBdwni38aI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169971: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 23:16:51 +0000 flight 169971 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169971/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 747 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 00:00:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 00:00:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318548.538359 (Exim 4.92) (envelope-from ) id 1nlJTd-0000ae-MW; Sun, 01 May 2022 23:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318548.538359; Sun, 01 May 2022 23:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJTd-0000aX-JD; Sun, 01 May 2022 23:59:45 +0000 Received: by outflank-mailman (input) for mailman id 318548; Sun, 01 May 2022 23:59:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJTc-0000aN-BA; Sun, 01 May 2022 23:59:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJTc-0001gH-8G; Sun, 01 May 2022 23:59:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJTb-0002AD-L0; Sun, 01 May 2022 23:59:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlJTb-0002Qc-KY; Sun, 01 May 2022 23:59:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ulNcAwaAoSr0SzULYVzzgCPDN9RD/jYb4Df6ckbwzBE=; b=4ukUXA93qeKWS+8h5FmppQaGvC yVag4bKBTI5XNkrkmcwjMlPFMry/0QYVU53pHdS3c7AIYMY8HwC1xJzZjpJZUt5tGgH5QoIEMnWSL DW/OnmGhsXv+6GlSBG4tcRpwfE+pGBgPsM4ow4yJX63/owddM+BhM26Uzc7oQWoHKQe4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169972: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 01 May 2022 23:59:43 +0000 flight 169972 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169972/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 748 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 00:07:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 00:07:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318556.538370 (Exim 4.92) (envelope-from ) id 1nlJas-0002jH-3d; Mon, 02 May 2022 00:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318556.538370; Mon, 02 May 2022 00:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJar-0002jA-VO; Mon, 02 May 2022 00:07:13 +0000 Received: by outflank-mailman (input) for mailman id 318556; Mon, 02 May 2022 00:07:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJaq-0002ih-O2; Mon, 02 May 2022 00:07:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJaq-0002RE-KN; Mon, 02 May 2022 00:07:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJaq-0002Ml-AT; Mon, 02 May 2022 00:07:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlJaq-0007eg-9w; Mon, 02 May 2022 00:07:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4rQ050cNpsUc0DLGMK7yNftW5RlQz4oF3KCYzCvLKwY=; b=qKewP0c2Oz/n1JWwcevvl7iTd2 oF8KH0kWc3sYwfGYy7WnUNR1OiZWVcIVckT+hVlLKadl0VZdtTw+ASQcoZy6STyfQpb2Tows0EllV S4ATsMN059tekFlOmWmtj0BrlpcG+Mnsy8+LRJdoMJf75Tb5UDT3wkj3YY9OvL72JJl0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 169967: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65 X-Osstest-Versions-That: qemuu=731340813fdb4cb8339edb8630e3f923b7d987ec From: osstest service owner Date: Mon, 02 May 2022 00:07:12 +0000 flight 169967 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/169967/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169886 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169886 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169886 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169886 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169886 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169886 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169886 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169886 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65 baseline version: qemuu 731340813fdb4cb8339edb8630e3f923b7d987ec Last test of basis 169886 2022-04-29 22:08:18 Z 2 days Testing same since 169967 2022-05-01 17:08:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Schoenebeck Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 731340813f..f5643914a9 f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon May 02 00:31:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 00:31:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318565.538381 (Exim 4.92) (envelope-from ) id 1nlJxZ-00061i-4W; Mon, 02 May 2022 00:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318565.538381; Mon, 02 May 2022 00:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJxZ-00061b-0d; Mon, 02 May 2022 00:30:41 +0000 Received: by outflank-mailman (input) for mailman id 318565; Mon, 02 May 2022 00:30:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJxY-00061R-AH; Mon, 02 May 2022 00:30:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJxY-0002qa-9G; Mon, 02 May 2022 00:30:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlJxY-0002yA-1h; Mon, 02 May 2022 00:30:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlJxY-0002Kt-1I; Mon, 02 May 2022 00:30:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X9JJ0kNVHmeRaA1+8b3RoEXmeFds1cfArojTc9T9yE4=; b=xKRA8I3nkAH6Qf8/8S3KJtypT7 1+WUsu6Zw5Pv7YrJ4XbjC+PtvWNyUB6NeBJdh3MOX65tgxe2USmUTS1W/ldzher9b/zR6IjbO2bom Bxt160KXb7xVDymNheUSS+o9qBd1eWvn4YQishC16wwVKEtSRvGBI/nlaAInTNvYVuPE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169973: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 00:30:40 +0000 flight 169973 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169973/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 749 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 01:28:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 01:28:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318573.538392 (Exim 4.92) (envelope-from ) id 1nlKrX-0003dr-F4; Mon, 02 May 2022 01:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318573.538392; Mon, 02 May 2022 01:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlKrX-0003dk-Bh; Mon, 02 May 2022 01:28:31 +0000 Received: by outflank-mailman (input) for mailman id 318573; Mon, 02 May 2022 01:28:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlKrW-0003da-JY; Mon, 02 May 2022 01:28:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlKrW-0003wl-IW; Mon, 02 May 2022 01:28:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlKrW-0004KP-40; Mon, 02 May 2022 01:28:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlKrW-0007yJ-3W; Mon, 02 May 2022 01:28:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x27g6/ZYt0t4Q3jgsTox4PiEZEsFnFzJ8CiEMKuJOJk=; b=M5Fz/q5pu+dqRWrijsGO/RvNqb P7t9/ld428G9fKDaMknxwv/ZPz8lfMzSGnK+CPde7sniVCJMsI/TbCHWFEiPRmjuWiwY09zTTgaAd xMpDWQdv/JaNAlR9hFrg9nvUez8HCyCp9/Q+dOckxGuJ3SPPG9KKNYHVRgermnTPaXbE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169974: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 01:28:30 +0000 flight 169974 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169974/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 61 days 750 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 01:49:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 01:49:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318581.538403 (Exim 4.92) (envelope-from ) id 1nlLBT-00066i-4l; Mon, 02 May 2022 01:49:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318581.538403; Mon, 02 May 2022 01:49:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLBT-00066b-0v; Mon, 02 May 2022 01:49:07 +0000 Received: by outflank-mailman (input) for mailman id 318581; Mon, 02 May 2022 01:49:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLBR-00066R-F8; Mon, 02 May 2022 01:49:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLBR-0004J4-9t; Mon, 02 May 2022 01:49:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLBQ-0004pI-No; Mon, 02 May 2022 01:49:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlLBQ-0002pG-NF; Mon, 02 May 2022 01:49:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R6XMlUjeT+3ujtq9CW4e04UNfxZ7Ow2dx7GvSAyRDO8=; b=Fv0BDpGnl9qroTVpPoDYkA8wig vH+daMkIAs838Mtkt9aq1rmRaX9+t85TgrViKgXlTZTVEJL30ZnR2bBIO+5a7psjJXN054ObxYE20 Fmq6XnV+5k/UxHphtVFqPbKpabR0iqJMxd7i8SzZMjaodH0fkzKIYrc77seXRC4F+EdI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 169968: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b2da7df52e16110c8d8dda0602db81c15711e7ff X-Osstest-Versions-That: linux=57ae8a492116910bad2b3497ffe555b3a4b4180f From: osstest service owner Date: Mon, 02 May 2022 01:49:04 +0000 flight 169968 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169968/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169918 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169918 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169918 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169918 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169918 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169918 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169918 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169918 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b2da7df52e16110c8d8dda0602db81c15711e7ff baseline version: linux 57ae8a492116910bad2b3497ffe555b3a4b4180f Last test of basis 169918 2022-04-30 17:39:49 Z 1 days Testing same since 169968 2022-05-01 17:11:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Borislav Petkov Dmitry Monakhov Josh Poimboeuf Kyle D. Pelton Linus Torvalds Noah Meyerhans Nur Hussein Pawan Gupta Peter Zijlstra (Intel) Peter Zijlstra Shida Zhang Shin'ichiro Kawasaki Thomas Gleixner Tony Luck jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 57ae8a492116..b2da7df52e16 b2da7df52e16110c8d8dda0602db81c15711e7ff -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 02 02:20:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 02:20:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318590.538414 (Exim 4.92) (envelope-from ) id 1nlLfO-0001hu-Oo; Mon, 02 May 2022 02:20:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318590.538414; Mon, 02 May 2022 02:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLfO-0001hG-Jq; Mon, 02 May 2022 02:20:02 +0000 Received: by outflank-mailman (input) for mailman id 318590; Mon, 02 May 2022 02:20:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLfN-0001Wk-66; Mon, 02 May 2022 02:20:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLfM-0005HC-RD; Mon, 02 May 2022 02:20:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlLfM-0005UO-FT; Mon, 02 May 2022 02:20:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlLfM-0001c8-Ez; Mon, 02 May 2022 02:20:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aPNXVLzYb8XBfrKdk9YcZSC4F63JNpnKugNSwZ07sqU=; b=hZSc6i4lP01+0QrSYI7uUMjCqK uNyFt71jd1qSe6kJeVUOsHGhexYB3Rs/p0zYc5hZo7DWXjRqh3KhLLFbXzry7WeSCAbtnQviVdSKV vloYoY7K8a+Xq8hKABFt1FiErGUKJCgr+4vNuiRqhkRqlnFWpJI30u/lSXFtkIKjQuZg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169975: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 02:20:00 +0000 flight 169975 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169975/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 751 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 03:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 03:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318600.538425 (Exim 4.92) (envelope-from ) id 1nlMs5-0001hW-Ee; Mon, 02 May 2022 03:37:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318600.538425; Mon, 02 May 2022 03:37:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlMs5-0001hP-BX; Mon, 02 May 2022 03:37:13 +0000 Received: by outflank-mailman (input) for mailman id 318600; Mon, 02 May 2022 03:37:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlMs4-0001hD-4O; Mon, 02 May 2022 03:37:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlMs4-000725-2R; Mon, 02 May 2022 03:37:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlMs3-0008VV-NI; Mon, 02 May 2022 03:37:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlMs3-0002dL-Mk; Mon, 02 May 2022 03:37:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vOMVjk8tyWlbeLVNwKPZ0CYMW8XrQ9FPHa3lyucHjqw=; b=OB2ZQg+0O9CAMeYYcvle9JzF1q Do5lYzIL+KDnCx0+KqJxZZjtBqIMBwnML0nRRKaw93rleZZ+PTA6F3AG4lXPl/EY6PaRWxYEe+IzE lm40XkIZpIn2wbREZo4AQvBcLKzQ4hY3HK9d89e+ZFgpBr3ZuteVDeQRrU6+ZhR/8OLU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169978: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 03:37:11 +0000 flight 169978 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169978/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 752 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 44 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 04:19:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 04:19:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318608.538435 (Exim 4.92) (envelope-from ) id 1nlNWs-0006Mw-Lt; Mon, 02 May 2022 04:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318608.538435; Mon, 02 May 2022 04:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlNWs-0006Mp-Ig; Mon, 02 May 2022 04:19:22 +0000 Received: by outflank-mailman (input) for mailman id 318608; Mon, 02 May 2022 04:19:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlNWr-0006Mf-0C; Mon, 02 May 2022 04:19:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlNWq-0007zk-VP; Mon, 02 May 2022 04:19:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlNWq-00027y-Hb; Mon, 02 May 2022 04:19:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlNWq-00028G-GR; Mon, 02 May 2022 04:19:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tDGJXmAd+P6mOLVYfg5gzjRG8/gw0+XcGNR5/NiO4DY=; b=O7rsJll7eKXrOM/xQTIp783C+0 EgcuWJ+e8ZgwlcoXlCV5KoRVg7Gde4VAumdnlDyrYfXSkp7lq7li/9e7mN2JqPGWWXbOdveA/tLxi lSZo8cUBxlMGrmpdRmpYEy3RSHCi8J/p8CWe4mVKzqEonI1W/Vskpj7NViMrT1z0w4EE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169979: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 04:19:20 +0000 flight 169979 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169979/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 753 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 45 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 06:08:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:08:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318619.538446 (Exim 4.92) (envelope-from ) id 1nlPE1-0000sF-96; Mon, 02 May 2022 06:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318619.538446; Mon, 02 May 2022 06:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPE1-0000s8-6C; Mon, 02 May 2022 06:08:01 +0000 Received: by outflank-mailman (input) for mailman id 318619; Mon, 02 May 2022 06:08:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPE0-0000s2-3c for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:08:00 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 369bae7b-c9de-11ec-a405-831a346695d4; Mon, 02 May 2022 08:07:58 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-DNr0AprUOCibTbRQaWCGWQ-1; Mon, 02 May 2022 08:07:56 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB4395.eurprd04.prod.outlook.com (2603:10a6:5:34::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Mon, 2 May 2022 06:07:53 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 369bae7b-c9de-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651471677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=29oexf/4m45wjLX7A00JPx9MYlSaonvAEc1YIIAQ98o=; b=EThdSTLZvjV2XqIi1tKZbhcCMxkp5G4bb0FXMbYPOB0LW7zR5KNJ3MEy/hRLBMoII5otcJ a2qvQGc/+TJEwELun954VEgastlkDno79MdsBl/vNppKJi4m8outNNF0MN5v7lVoUnulaC vx1M65uo8s6x+pje0RZrL5UW589cGEk= X-MC-Unique: DNr0AprUOCibTbRQaWCGWQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX4sfJ6t6jbQ2zReHi+4FNDWSEciRXDhLoywMe2bnUVctFWrx7GrJ8Y9Z7n2RAIlfk0sbnYa68k0kjfGjUWC0AoXZkjf7MlIwcY8J6in+ODLKRPyWgtrMkoM2XHE8S69+DqAWFJAL4DGwj/iCspVPp/y+9T+EGLYqAvUqGdz5+V8/sKH8QFdDAW6Atb3XItRDTjVrCgS5V24zhsWoJ8AtPjec5GW0UTJ5oAyu2umdSfYdAfkU/SA2lQWq6Hg1eGgPvZPPKnoAjm343fzeb2/L5f5TBIOuuRo79TheZDZdrtLPdRZWK4HUnKXzM1tz9DRpMtSX8f0x/GnQt3ecVdtxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=29oexf/4m45wjLX7A00JPx9MYlSaonvAEc1YIIAQ98o=; b=HnEFJ//Kw4dhvWW3ZWCyUUZQW1zLzNyaFJ60Vq8VjuJhjPw/wvUotR1VGO9Tnnh7Lhpd4k78V6R5tBKJPL3aHaR2QvjWg0GO1NsPtZSMhkwxbfu5rSBc2s1wAM+6WBJm38E+7jv2U+IiYganlGyfZ74iv6OmyBnYDIYsrDlPajjYjNM3lb/1+jitauUkCRqqhRqjl5QwVTGTAmtOBQolb/XM25KOtsznuHwrn9dBIZ4QQblYi7tYu62PWNgDI493B5DsBXSHcl2+kW+AI04N3bk/dagMmAbazsqvw+HA3/vuNPnv+Jn7hIT1K87N/EaSZRAu73boX8kpw669YprCBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1aa8cc2d-2c7b-1265-296c-c8387e505c54@suse.com> Date: Mon, 2 May 2022 08:07:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2 Content-Language: en-US To: Dario Faggioli Cc: "roger.pau@citrix.com" , "ohering@suse.de" , "george.dunlap@citrix.com" , "xen-devel@lists.xenproject.org" References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com> <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com> <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com> <35599105-b441-96cf-7537-ccf9dfac0934@suse.com> <85c55676-b21f-1eb4-0471-19ca9b6de39f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:20b:b2::18) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a738ebe-c802-4d5d-854b-08da2c0217d4 X-MS-TrafficTypeDiagnostic: DB7PR04MB4395:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MbX1bKbTu/hwscDttcoT7wRWO9Mr8c3zVuvgHMXf8CzhqsyQLVCMbkyo0hedi0TVm/f1TgawxvQX6pvYGCEaFNQHwzq739fQHe20PC2tf2Ufs3O8Smzk7cWHaIAYdHZDvbEBLQo2GaT4yMIYAfriGNqGmitVhjcySZSouGSTBjHbrfaBs2TByZjcXttDnRXa1v6EJWrMQIPD1/lCvo3XnSQXMCdou2VVdSc7GMHUqBzYdmUAggtsnTcQ2ip2tIxS8cupDYILYmZ2zZW8Wyn5RcjYoCejCFb22Ze0rZLa+TzGvpHefkbQxdUK+NeHS1AarpGCWxUzL2ENvV4mTur+B7NFM9UiSW9Km+8huKu2XMDzvG+5LeUuTQ0TlxPOmCM40NJohMgaOKmPd6DZyi5SchmkUeTNVmlf5x8ReXTVsOWTh2XRPWNy2RjglttNb4MSJzdRaJ1sxhn6XQ6fX3OEzyo0JaRxI4xCfVaLGu/y8uhdsK3+dweRAIZxmpVif7ybY+godNuw0mM8M30ZVEEWKoiny/vhqj+UKqE2O3QGzUwJbZ/qc6OwgZuaoHxpbPwl4NG784RcBPuspM9wXu5y/6qIR6RUFlEdOrnnh+QgLXuVWnfNhVh4lxgfdCBaK81FGQ290AkIoDyEUq2QARchOdFLFT8etFQHebPDyqvKcFkK7UJhz8wWdRY9LxJTbBuKRHN5T1WppZfJpZfP0L+BrVFrVaMH7Tb/caqm+BVj52g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(186003)(36756003)(6862004)(4326008)(53546011)(37006003)(316002)(54906003)(2616005)(31696002)(6636002)(66476007)(86362001)(8676002)(66556008)(66946007)(508600001)(2906002)(6486002)(4744005)(26005)(38100700002)(8936002)(31686004)(6506007)(6512007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkxBMXNHZ2RuY0t2blNuTUk4b3NMN3U1SXJHQjlqZE1vc3ozSXFxdnJRbDhN?= =?utf-8?B?WnpPdWUxZ0J0K2lENTNJYWV6UTFJbVBGbGF2ak9xODJDN0p6VThjNGs0OW1S?= =?utf-8?B?SCt6QkxiaThmbDB3NUhSQjVEZzJuRStNVWlsQkZRTHZ3cUFXN2haRFZuejdY?= =?utf-8?B?Q0RhUFJVM2x1cmxMM1ZrRjFFaGVZTlZ2MFkwK3YwZzJHOFRQRHhHZXF3dmZv?= =?utf-8?B?cVRuSnRBV0cyZ3UvTFJWM01Sa0lBUS9DMklhc29KNzFRSGZFNG1FNUFvcmtW?= =?utf-8?B?Q1VCbEJ3M1FHRUFyWHpaWWxoczZINDY5SVpCbWlhaGdtK1dpNWhOWmRlbmht?= =?utf-8?B?SDh5VTRuRWIzK3daWmdRUEtZRzF4U2IzN1FTQ1RTVGc2WE9uanU2cEUwOFQz?= =?utf-8?B?Sm5QZFp5cDYxR0NpeG8zWHg4MndCUFlFdUNtVUIyOTZnVUU3WDY0aHFqeGhs?= =?utf-8?B?c3JjOFJCK3o4Tk5ZRVZEVWRqMTNld2Z0TlJNTUhuNzBLcGZmbFFkYTJwR1dy?= =?utf-8?B?R2VlZ1VUN1FQbi8rSzA2bzFXVmF5T2lvV2l3L3diNDQyNnBMblAyV0tINGFr?= =?utf-8?B?TkZtMjlqODNXcXFnaExrcXQvSFdZdHNOUUo4QXlmNUNYR2E0V3hhZGlLR3Na?= =?utf-8?B?UVZ4UnZrUVFxVWdzdEJQLzZRVVpxckEvTTBQQk5iTUxxM3FLdXBuZ2prd0M2?= =?utf-8?B?RElIZXBoS0daK3ROWmdUYk92OHlITjJZMVFaRzdlUGIwTThNdTdZUzFzMXlw?= =?utf-8?B?V0NEVzR3eWJ3SEpNaS9rOXhVMm9QcktDSk12N2RTOWQvYVlVWkVuTE1ZVmNi?= =?utf-8?B?elFBaGtuTlE0dFp5VUJHYW1uWDdHYzh1a2lUallZVXRSL0N3VjREV0FOZlZs?= =?utf-8?B?RlhhZVRjV1Y1UFNFYlN5b1h1aFU4OWR5RUVjU3ZVVlorT0JQQk04L0tORGVH?= =?utf-8?B?N2d0Kzl4QkZla0ZWcVI4N3lwSFA1Q0F6a0NDWVZ3Z25sNExlcWZjN1IyRTJ6?= =?utf-8?B?UWRBUS8xVDlFL0JncmtJSFdyM3lQR1VTQWJTYXY2dWlMTzRYTHB4Y2UwZE9j?= =?utf-8?B?LzRKM1kyVjZ0ZHoyZU01WlNFMFhRSld3bXBjaVduQ0owZTZMdG9rSDNieTl6?= =?utf-8?B?K1hHeStSN1QvYXlKMm5CUWlJdUNFOHpLTC9UTFJubDZQV1BFdTA2MG11djMv?= =?utf-8?B?aE1uY0w4WThMN1lQZEI1bEl6UmozclNJYW9xd0FpNmlybTZTUG9WSVVKYUNq?= =?utf-8?B?NVFTSUh6Zk1LUUF3dVV5bE5WdlJXZG9rakFYdi8xblA5VGw0L3ZBdERjTlBY?= =?utf-8?B?UTdiMFJkTkVWcGRKaE4vL0NTYytBcytmdmw0UjVuTnNIU3Vlck5NTkJMdmFT?= =?utf-8?B?bjV2dFZLTVVzUVhMRVhxbSthNHRFZVJtL3pkQmNpdkdoQlpVc2xrTDBteDRJ?= =?utf-8?B?TnhPTHBVYzViL25vRFBsTUFDZkd5R1hpODFoRWJnaDdKem5vN3NyejMxOTFu?= =?utf-8?B?Si9kd29KcFJnZ244cEhMZkYzVHhabXFYSXI1Q2pJRmtZOUh4TGlkRVR3MVBQ?= =?utf-8?B?aVQ4eTNCN1VWS2RnU2JNWDRsMFVZU0c0RXR0S1RRNTY5Y2d3ODhLWTNwcWhF?= =?utf-8?B?R2lCd1dHanJuZ3Jod2xBMDFSN3NuelhUeDVPQTMxdWtIRDZBakRkS082OTc2?= =?utf-8?B?ZzgzbFRhcGhGcm90b00vYzNocU1iSHZqN0xDdUtRUlZXTDlEMmZTTURnZFA5?= =?utf-8?B?Y0dSamRIS1J5UFYwVnRHcE83eVl5OFFGMUJxYUZLeWNTN0pXazR4VDZhQk5V?= =?utf-8?B?Q01zb2pLQTl5aXFrNHNhSmxGdCtpUWJybFp5ZmRhUHVLOUJWRGlrUXZHanhX?= =?utf-8?B?ck9sK3AyTWpqSGF3L1JSRlJyRVdqMUVab2kwQ3J1RjlybHl5VDc3N3ZVS2l2?= =?utf-8?B?bXMwMGpKbEJ4ZVJDbGlONGFzbEl5S25zcU8zRHlpa3dmNzA1dGRiMXE3a1o2?= =?utf-8?B?MjVBNkgrNXhVWHpTUnBvcWxPRzRvalNEVklPQU9WMkFqUkJQTElYZWVQZ2li?= =?utf-8?B?WURGTTBIRTMreld6OHB2d0JxTmM2WDl6Z1hSemtxcWp6WVFqWlM3V0tnQjFM?= =?utf-8?B?a0c0Y2hQeW00Sk1XWHlxajczSndTbUVCSjdkTW04bzY2Q25uTDlNVlM5K005?= =?utf-8?B?WWZPS3FKY3F2UmwyY2tieVNWMU1CVnQzR0hPaGJoZU1jb01qTnlEUkNTN2R4?= =?utf-8?B?d3VIY2JXMHJEUkNPdHBLK1FEOUw1S08wNTAvT0QzOW1ReEI3dmxERWJ2Sitp?= =?utf-8?B?UEdOSzFRQWNuMTNqLzY3TncvMzd1WWFSc3QvQ2RwQ2UxdGNUVnJKdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a738ebe-c802-4d5d-854b-08da2c0217d4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 06:07:52.8945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VLJt+B6GNjJl+3K2d7n/q62a0Mt4rYz9V3pqQSFEXPAjIRAmeXYHIeA5KZfpqMCbLAHtmyHtbhNyvXasKstUPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4395 On 29.04.2022 16:09, Dario Faggioli wrote: > Do you think some of this exchange we had should end somewhere > (comments? changelogs?), to make it clearer to both future us and new > contributors why things are done this way? It might be helpful, but beyond parts immediately relevant for the patch here (where in can go in the commit message) I'm not sure where to best put it. Of course if you'd be willing to make a patch just to add/extend a (few) comment(s) ... Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 06:12:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:12:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318626.538458 (Exim 4.92) (envelope-from ) id 1nlPHt-0002LC-Uj; Mon, 02 May 2022 06:12:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318626.538458; Mon, 02 May 2022 06:12:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPHt-0002L5-Rc; Mon, 02 May 2022 06:12:01 +0000 Received: by outflank-mailman (input) for mailman id 318626; Mon, 02 May 2022 06:11:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPHr-0002Kx-IP for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:11:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c4dc1dee-c9de-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 08:11:58 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-JmsiRaHuNbycMHoe3j-3Mw-1; Mon, 02 May 2022 08:11:55 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB8116.eurprd04.prod.outlook.com (2603:10a6:20b:3e7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 06:11:53 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:11:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4dc1dee-c9de-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651471916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2BIM8v4uXW0RD1G0aUIzdq8YaSrQvuFG6tw8hIwzM2Q=; b=AVzkL8SHZZJcJBFl3I4QyMxU7gNiLHRExqyzAwYgfDzif/YFLxwrjtCGG6MjNkYhCyOY/A HKSePSUynlN+ag5hDwvRzWMhl/7bCwPLGrgW3EcrNgFCilf23mos/+l6Ojodycd6DCzSHY 6mqW8rY9PKZQ2kaa7jvaPvsst3km7h0= X-MC-Unique: JmsiRaHuNbycMHoe3j-3Mw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHB9HTY+3VEhT/mjinmNm7tgHOfFJdvph+C5ipwb8zNlU4tLupI/rqpS/omjOMCaR+DLpHsCFflLGHwg+MY4EIQFPxTPvNoL5d19r+M6QqiHR+DJiR50PCdwgjUIpRtGBbkNc/k20PwF3OLiHSudIMVRyimvnLMrHEmpIeuUV72Uy3TqQoMj+Frp2OKwgf5iz0TaU3qCKsWP7t4lnnLQBFKh3FTWTy4g98wI4HVwVwXUDg7akXUA5/bJGcZu9HmsXCEH6xU56wFC0jKkaIXbh3UHe67ISILyowQHX4fEv4a7wMOKqrzEiu3t/J8gHBCBsVxyYnu8atohmMd6crLdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1xttg9DPI47C8bDODjVmNp1gMhrQ6eaSKaARBgvnI4=; b=iELH8n3piYUX5E6aWp2LA+TcK6uM9yl7WcoCLGDbWGprDMzYE9az3Dp9qswDWDWKxh5P0OWs6mvch6nqGYuI/FMBrEcCT7x5hlYWQn11MMEE9ErazJHIYWhOBy9B0goja6qxFLusAmpLgHIRTW9HDYy1dmjsxIgWGHvka6uQ69RkGCQxjMj9WP5wU/335t0tByfl8mremVfDruCtfNrTBWSdH379TMQD9JeYqTQxEI269XPfkDn90MAfeZ5sO95+FEGODLhWgOZLy6UBAFFQRbnvKqmPxuoKWLJklYTGLJKBv0bv1XNEHAfvv3oDkTdxwmw5ym2t3SdWpsVEVADy/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01122788-ff9c-5b68-b273-691c8ef92bc8@suse.com> Date: Mon, 2 May 2022 08:11:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220427104718.81342-1-roger.pau@citrix.com> <20220427104718.81342-4-roger.pau@citrix.com> <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0127.eurprd06.prod.outlook.com (2603:10a6:20b:467::32) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22d40b00-1cf6-4f28-db1d-08da2c02a718 X-MS-TrafficTypeDiagnostic: AM9PR04MB8116:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZHfMR8Toe4jb1w+vsc3NbxTh5BT19248j068l2W5/g9OT/jV5X0CCjPdcWc+ocIsXuTdJIfqU8wPFtyC9rAgnYq1qYkHFbyjvH86/UU9PyRKswGE6yPAhnFkRHhlJEDxChez4WiQHpg1rvweZ21rocNsTAkMKx95pA3/ZzZ5SvYYihmLhEIJr3LoZRsXkXQxX6RZRMCwVcMOoFv1c9y8cV4/Cix/hOicsCmvJB+k1WyQATxj3MDw+itB+WDcXf1gKRxTAZqKnpZXsJzoQH9q2Ub+STMxg6ib1WKKuR7sA8vcE0dCO0PpqtEDtGhqqRZAez8bz6CWc7l3/vtdy+f/hE9RAuTZqByJMugb0dmwW4iP8gS+MB1LcLRGjMEvF4HvmzO/hE4vJGxVXQryYCXKMn4MeJBSdUJ4ziAHgcxS+IA2KQl5Nd15DIyG2nMELzL11Le1uzvEmfMOyPWncUKq3GQxK8TzOUILz8OgvKqnbkXZ7xILNH7AJqrFu+y3xgdkhVOFpNlo4lunqvxihAQc8AOTJPDJDM2JyiS7FK8TlOyepGwbIqerPdfneG9k8q8voKPGuOby+G2mqlZI/ygx7hv9TSxRQb3MScjJSzbPUFWwwrovo54Qnt08iWLPe3hJl7caa+q3KKx/MYOoLezzTLTFpUO8yqVHtMlMn0IStVbJU3wvg7eYGX9/5yRUjh/ljtSaTd0J2gphjAOH0cnhH0rPcxgwX0g2Ezol6m0HGKiFGuO/YGivz08J+hc5L4r3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(66556008)(4744005)(6916009)(508600001)(6486002)(316002)(2616005)(54906003)(83380400001)(31686004)(2906002)(36756003)(8936002)(6506007)(26005)(66476007)(66946007)(6512007)(4326008)(186003)(8676002)(5660300002)(86362001)(53546011)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3NnKh4fIay9B2CFAEekE0OxrQT4XFtnCCUv08sEB12pk9zFl+XdQi+lxtOth?= =?us-ascii?Q?1DMBi1Hut2LfX56pUSzIDj//3ZDb7JXvhfk4X9gzgV4qvjfByG0DebJOIndn?= =?us-ascii?Q?Al5SprTWfmz+AHlNlICQJ0IZBEwiWsw3bkcLY5zFULWLDEqg9El9tun2glML?= =?us-ascii?Q?339ypPRraPEcW75kySAU4YpjVt3/W70FNLwICboPFGu+Kgl1vcmNPZhYiDRQ?= =?us-ascii?Q?hBmpBII5kMjoULawuTAW6fbJ0qzNQGBtGL+7cFpE1oK3hRymZsmwHFOFRcTf?= =?us-ascii?Q?BfbK2AzYx3hs2MKAoS8ip9K19BbIssl8KblQdYWNc1zr0bIFFGZrp5Hc289H?= =?us-ascii?Q?aULlck5RFcKtsV3NI4mKdW1fkI3H0XSCiDRDXmPaOv/K1tKl4J7ihUKkMeHN?= =?us-ascii?Q?oXiq4ZqYorLvWBK/JgKbB8n36GtblHYSXNMQ6opAgW5dTr+akWxdjYOvKFo7?= =?us-ascii?Q?v9O+vjs02WUwYlCw2gSww2bP4k7XzpgdNFI/VpZwpFDu5Q1qUAnTuNHQVqZ8?= =?us-ascii?Q?l9nNRpmolmxVIyEEVoYs6XFW/ewgHvBx5YYhb5gIpmhLD4aTGbp8brRG10F0?= =?us-ascii?Q?GVrH+EB+WncngGGr6pMSIaMoVs9q0EVMB3xdMKf0/39VAwVRChblc48fBcLi?= =?us-ascii?Q?cao1tJSpP6+DHp0/ZeMSY7ga3CwHdTVtdOrauzzNJzq8rLa3jsM2atUrSnhK?= =?us-ascii?Q?LzH26q/XcP7ddTvP9EzLdwwJjx6gWlG170Gm1fqtqV4peNJe5wU+EFj3aNRt?= =?us-ascii?Q?LPcS9kG8bSnKmICPlMIPz6xaRYdfo3PTz6wBYrloci6uvA5DklBUhaA6jdMI?= =?us-ascii?Q?0IzHrG8a+TssGCs0tdJqP8I55vPr8f6IMT6zZ5GRdOPTRl2oB2AxwIIjRSJY?= =?us-ascii?Q?CQtBxZk2UFNiMzVRqhMTpwZB5YNWJMVktUcZ9CAYL6sVGPXT2nHFeQb6n5Sg?= =?us-ascii?Q?R989qlIBzgGL2ZbmPEuVI8XA9KZqFnr+4AfUG0GJtADsz+Wg1WLXjup/44T4?= =?us-ascii?Q?lCTZc91GYAZchlT0wHPP25Suv3A2WrDccKJ6mktk1xf1NFhUsFHvfASE7hwP?= =?us-ascii?Q?BoWP/4xXK/o0AHcjNVoB66FbW1dVNxz9O3mM6DYxdjuJHd0Sf4uB0cOcwqY4?= =?us-ascii?Q?tkBya24QexPn1yDPf7qXHUl4pulOhpepqf37NmDyxnGiKjZWedBZ4W6hhvtI?= =?us-ascii?Q?OYLQNa7tO19ZuYPk0zdi1KiqOV3mQJ3MNaTOHe2vGxebWBVSXFY3VMgKw3ri?= =?us-ascii?Q?wVYOSkHZcfKjHi8swH5UwCR4P6jnW7t4Kw8jO6T5wmHZwg3tAqBURX2UUlSh?= =?us-ascii?Q?DMNfEM3TbWgUi5al4sbQ1uD2KmU5HpY65B5aX9Jkd1mLMsJscPFZqAP85qZd?= =?us-ascii?Q?9eeTItl6ZtZCejznQTt1FTVtaqnNAc65hQn8n2xsCplIag7jWDJ6HSvsLyeZ?= =?us-ascii?Q?A79jmEJWKgNV6B8RQmyhVHHSfY8aTr3aV2NMv7cKQhVM2YN4FdeDAj5ok4wB?= =?us-ascii?Q?X1K4V+4adFHxc7sMELXX+CB50mcanl50ibS5ydWAJzmmM0WMMZLltDjN5fb7?= =?us-ascii?Q?G+lxj99ZfZtiaZcsqQjvhV12nsER4wg3c9fvRy+Y2Hm9VW1qQu2+mjmsXzti?= =?us-ascii?Q?aOYne1D+NBIl1k4RRY7rAoD/FujmiSxzIqWC47u3vy7Nno6HccHdchzw+6Fx?= =?us-ascii?Q?Cwr8T/ilUO8DRUoWZpYqmGiVxUGFgwgoE0saQmt3zd8NFzGFw3DlyID6NEk9?= =?us-ascii?Q?HK0HTDHwvA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22d40b00-1cf6-4f28-db1d-08da2c02a718 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 06:11:53.2577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ggTNi0n1UQ0nd0V6awldELJpYKLvqS8DuCAdXWGQR8OTaJ3gKRFriCEOD6KSVD5Ox575mvXeIKzek+CVN5hJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8116 On 29.04.2022 17:49, Roger Pau Monn=C3=A9 wrote: > On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote: >> On 27.04.2022 12:47, Roger Pau Monne wrote: >>> @@ -3138,6 +3140,9 @@ void vmentry_virt_spec_ctrl(void) >>> =20 >>> if ( cpu_has_virt_ssbd ) >>> wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.r= aw, 0); >>> + else >>> + amd_set_legacy_ssbd(current->arch.msrs->virt_spec_ctrl.raw & >>> + SPEC_CTRL_SSBD); >> >> Would seem cheaper to use !val here (and then val for symmetry in >> the other function). >=20 > I could even use !opt_ssbd, and that would be more similar to what's > done in vmexit_virt_spec_ctrl? Might be an option, yet when using "val" there as well I don't see benefit similarity-wise. Using a local variable would imo still be cheaper than accessing a global one. But that's a matter of taste to a fair degree, so I'll leave it to you - all I'd really prefer to have is the functions using as similar / symmetric as possible conditions. Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 06:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318632.538469 (Exim 4.92) (envelope-from ) id 1nlPJj-0002vQ-A8; Mon, 02 May 2022 06:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318632.538469; Mon, 02 May 2022 06:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPJj-0002vJ-7C; Mon, 02 May 2022 06:13:55 +0000 Received: by outflank-mailman (input) for mailman id 318632; Mon, 02 May 2022 06:13:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPJi-0002vD-0g for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:13:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a45f07a-c9df-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 08:13:53 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-GOGpI-3DOdKRq0_0z983pw-1; Mon, 02 May 2022 08:13:51 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5469.eurprd04.prod.outlook.com (2603:10a6:803:cf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Mon, 2 May 2022 06:13:49 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a45f07a-c9df-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651472032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxA6Kdh16VQRJkSgCwqkesGGmB0GksnhnerCMpWnxwE=; b=WUXjDPBTLBSjpbj/WzqTa+2vZin9gymhY+2ruWQ/9Qa5UwgVFe5tce/7zlHelgFQzeuhSi 0WYjGnkLem07DgDjKaDOolDnYSwSaWFkRdQy6j9ordHFAjI91zS/SEVJG7vaQYvrXjISW9 uRJ/D2b/VENi9swZrf3p5em/Dcv9+aM= X-MC-Unique: GOGpI-3DOdKRq0_0z983pw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnXxes3LU+panu5urfx36bEHYprXnMzxI0eDlBhwqUDIFHGJ0kbVrwxj+YVZs5UbAR9h7WF++vKpx4eZkZjmhwizDSjKGlJBFhXa3sz2GcUy7YPmKIlMwRftWhbtBrmAyT3Rmc7yAeboN7SKQ6mYQVODoQjgVbFs0kQwUQ5b4fd6agqBi8dwpBbJ8bkwT9qdHo2kR88cFW4z9wkQn0uUXOp5X3MyI0kRYPVO6NHUn1tHSOjGotL/daqlRicNswvHlgVNINIzvd4/ZYCXtiqEA/OIEwKUBdit57NkYVk9enchpBkpLXiFZuyr8CY+qpLzIppeoxmnlmR5/maaMBTCMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6SrEPP0E+ZtWJrOeWA0W0GiswQNM23vVzM/o5CocNw=; b=T8u2wwBjUbyKzdEPKNDNcDiAXZebt9zoAhm3UqaXrZ4rWqdcXDAe3SY7llm5PPZCAvht+GWQ8ZjtlPSl/xMCDmvO88PcYTVTe8/5r6infLMbJ4q4ZoUpf1p9U3yGOUCbzwOGxAmQxOw//aTxIvFGHnZQul0Q4jXqDPktOboz3nv0AH+lEDZ8LZKhyA+X0UNIsthmSy694RsgR8A7WLUB0jPXPOCM/zb6kp3sgZSg7187HFVby8EiUR2XKbj8WYc+iBJoIzjeW9orYHF1PKUncmqozDtdq2cSpstWoUs2FbZWQ8jmGHPOgTGGrWYMqPt4U0TmtWvIWN2Rw3smqsR3BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <97f2c436-42e3-2c35-a544-4763c3dc3401@suse.com> Date: Mon, 2 May 2022 08:13:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220427104718.81342-1-roger.pau@citrix.com> <20220427104718.81342-4-roger.pau@citrix.com> <38f0e56e-f72f-698f-c4c3-5973ec9e46a3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:20b:b2::22) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea91f76-c3dc-4815-2ed5-08da2c02ebf9 X-MS-TrafficTypeDiagnostic: VI1PR04MB5469:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3E6t7KsEFypyqd5VXIsRXodEadnvHHlTqTvCv297auStYh3ZKJfyRCT1UCPmwE7pK5oWmQlcrVjMtCV93qKDaUG+y2Bhpfe0wb23k8wy009TuA+WpA9lcG54ONGfWuknx23st0ciVawXRRc/zdPjgv0YKLeC2IGlrLaHrAz9a82/A8jOgTO0UumX36ejwra85N7sa0ediNHYIoW/63+MYhCAGba849W98L45YS83D3AhdA1UpB8CvApoJF4bv0yCWgb+X36nxGsUSVT/fnvz/oaa7BtLRW+OFgraV+J5lWZ/rK0E3MWE0xO7ghgTIWmCtdQf+BeWDZQuRgsw0KOr4mxMdfWI2Vqf1JTMCOEzT1URymUMvgA/JRoa20GGgEGtE2eWU+oWzD8D/nFbnlYRsER2qgY1woMkaTrMtgm4BXu5cXxqK33TMHOjZHI24jZP4VCSaoTg+0IidNQeE0scxo5fJSdyRFW2WrBgEYYPz4B8mboSreO0GeP6THw4qfsOUontXLzZeIsOwTdcbDUXPKStMWPzlCJbL4/D257G5K8K67W5455+jj4jJlPRtPnsQQ/trDC4CQe5z6rE5usITgBeasbq60eDQD8x+hx8XBJqrTX4x1p5EUXlwQ1Ktb+FVxz+mWB2wzHw1V4JnBavjW8GUquSE3l7I+qWXDJ0uHDy3sbMNdnP2iFw0hd4oBFdv5CKfJeLOYJIfKrLOCHAIHV2nXshPUR6DyaLAxJ/Xt4vWPPYvK7+9KYdWebv5mxR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(54906003)(316002)(4326008)(8936002)(6916009)(38100700002)(66946007)(508600001)(66476007)(8676002)(66556008)(6486002)(5660300002)(2906002)(86362001)(31696002)(31686004)(6512007)(26005)(186003)(36756003)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HDUZlauEuQmyVPcYKRIw4SYmRchAB4DgpZuEyk0HHKM4arXGPrr0V2ap4dZm?= =?us-ascii?Q?e090xHenHi9UlmJnMKHHsWsTF4/rJRnglbcrxGxfLcopdwBs15mVbQzWhhcg?= =?us-ascii?Q?xuRaJxSrw/LzINjZdu4jzPtV1tEwBIhKl+y5gH288Jq7S22M0kTQ8KSPVWUK?= =?us-ascii?Q?2VJacxNNX7TN3Y6KvHDp9kpERN57+xEDeT0suRamAoJymAPgZ57NsExFds4m?= =?us-ascii?Q?VR6dN4gwrvNUM5k+QGr4zgfXUHWAl5SnPoIsN0qO5gTHLc2zXJqEIAtaHpYg?= =?us-ascii?Q?oA/JPoFr2YNAuPRgOZV9NwUbxp8vkwrPUYNrHZC1KUQd3Bup8Bo5sPSr2yHH?= =?us-ascii?Q?+HPXHboSDNE6hLQ7+t14MKuoHjOXvHaWowFCmi0M4gyHnOm86gPAlqaMQNUM?= =?us-ascii?Q?ETYXsrLbpahXiXqUDRMNGc7N+w7/jvkKR1edSvOi97Mt13e4uwTNSyWfIyHR?= =?us-ascii?Q?PjUglWFjmFP9sn5KsTA7ebpegoegLIGIfyMhAKxFPF8/p+TrtmEyS3h/4dIT?= =?us-ascii?Q?WSMdy98qnTWCrLz0gX6lDDOyU5RK/STrZX54yJdN0RAZ1+/qeRVEQuEg4GUR?= =?us-ascii?Q?abxc7SNY4jncoLvbyd51vkTBB6zZc60+vSkuQn2wQFqMnhWN/MVMHJ2ppNJs?= =?us-ascii?Q?qC+0hQL3FSPb+UsK3tSDX7GmVgARMEncArbWLlX7pqv9W3ZJ+kLlFuIkTPwN?= =?us-ascii?Q?jaCCHg2Vu3tgkTtzcXTnScZtyE/r9E2H6giUaAQ6bFEg79tpsy/hgE5ztreX?= =?us-ascii?Q?vmN+71WxgqAY8YQDxtReArlpsY9N364sc8+KmzSG2xNQhrZ6c+416vBJrC43?= =?us-ascii?Q?NRfx8521NXUOly3TWUH8MOB5IvgkRj2+eZEVLSPaxMVWof+PJdQNUHFZa1v0?= =?us-ascii?Q?skWwwILmNaWuoOezEh1G2KXK8GNY6b5H3xOe8spL5UCAseGBazOfjXF53pTH?= =?us-ascii?Q?8pjX8/JBmpymXOeuTiRqFlzxlj/uJcDOmUmlIzNqsTHy5EynjTaiTQ9vD7px?= =?us-ascii?Q?EQSWGDQz9cyGNBIgauQVAesywslRHHGdGUMcoOut1KmPhFilqeKPOcmDsofb?= =?us-ascii?Q?BSpRhvA5sKu3ygeN4CRegHFWFL8c9aGBX2ojLFo02BSBwJL+cl1734y6sRX5?= =?us-ascii?Q?vbieGZwRLZwx4f82wumDeQuAfLzLn0vlMXXi6oBuqs/9Pp46OfE7OZBn/2Zp?= =?us-ascii?Q?bWhX+nMk3G13iMhXKKoIS7PkNAwX4eVnupnjZg6q6MsaPfBWRyWaDj6I8mvJ?= =?us-ascii?Q?EU4k7/EbepEMaUUnWYMWNnB5h7DqoNMuYAHnrlMsop0jYDz6TwZdYmcGZK50?= =?us-ascii?Q?oKAhbmfjWC1Pe+tXZsUFyE3L18ZqGrkB3v1Z6IBBfvUh0eU+yFTIzfkZzL8G?= =?us-ascii?Q?P43mb2vYk3QH6ueNqMDw4iU/Q+lDu7ys8yTBPokuzFglSGrXeDRxvtIjc/rR?= =?us-ascii?Q?0I+nAuz/uvZpmRujFPGj5+k7N7l3wki4GQ1iLKPDb1vC6TEnL5naqlGaTIx4?= =?us-ascii?Q?+lDDI46hD9TNKfTTnI/RF/7YqW1WDLy7bh5TID3HXMFNGrSppMjqhbSGUlOq?= =?us-ascii?Q?/QPwApqEgBi4aBu2oi3qoCwsx5TD77tVmlvBsBKcu7nv7qloKSdI/SZgZcPL?= =?us-ascii?Q?iEXA36WfOHJ6qXwehP56sJQq0QmK1yOgJTzCVFchLAExWEIrxliftY8BhWnq?= =?us-ascii?Q?LOJckRZ8Ln8+Qe8iv6K19JVnr4lo56K9E9pd6uL77vNb8X60zu0gX6kovSy6?= =?us-ascii?Q?4Li/uLMDUQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea91f76-c3dc-4815-2ed5-08da2c02ebf9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 06:13:48.8909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /pj3IiNX/kgVzavRy6rsb+R6A3H0mHUGVRc+bFCa3uqvaT3IAZDDLe4AlhZV9uHYXtRTQzI57qGjfc9jJVLCMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5469 On 29.04.2022 18:11, Roger Pau Monn=C3=A9 wrote: > On Fri, Apr 29, 2022 at 05:49:42PM +0200, Roger Pau Monn=C3=A9 wrote: >> On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote: >>> On 27.04.2022 12:47, Roger Pau Monne wrote: >>>> +void amd_set_legacy_ssbd(bool enable) >>>> +{ >>>> + const struct cpuinfo_x86 *c =3D ¤t_cpu_data; >>>> + struct ssbd_ls_cfg *status; >>>> + >>>> + if (c->x86 !=3D 0x17 || c->x86_num_siblings <=3D 1) { >>>> + BUG_ON(!set_legacy_ssbd(c, enable)); >>>> + return; >>>> + } >>>> + >>>> + BUG_ON(c->phys_proc_id >=3D AMD_FAM17H_MAX_SOCKETS); >>>> + BUG_ON(c->cpu_core_id >=3D ssbd_max_cores); >>>> + status =3D &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + >>>> + c->cpu_core_id]; >>>> + >>>> + /* >>>> + * Open code a very simple spinlock: this function is used with GIF= =3D=3D0 >>>> + * and different IF values, so would trigger the checklock detector. >>>> + * Instead of trying to workaround the detector, use a very simple l= ock >>>> + * implementation: it's better to reduce the amount of code executed >>>> + * with GIF=3D=3D0. >>>> + */ >>>> + while ( test_and_set_bool(status->locked) ) >>>> + cpu_relax(); >>>> + status->count +=3D enable ? 1 : -1; >>>> + ASSERT(status->count <=3D c->x86_num_siblings); >>>> + if (enable ? status->count =3D=3D 1 : !status->count) >>>> + BUG_ON(!set_legacy_ssbd(c, enable)); >>> >>> What are the effects of ASSERT() or BUG_ON() triggering in a GIF=3D0 >>> region? >> >> So AFAICT the BUG itself works, the usage of a crash kernel however >> won't work as it's booted with GIF=3D=3D0. >> >> Maybe we need to issue an stgi as part of BUG_FRAME if required? >> (maybe that's too naive...) >=20 > Well, better in panic() or kexec_crash() likely. Yeah, lifting it too early may be detrimental. Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 06:24:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:24:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318638.538479 (Exim 4.92) (envelope-from ) id 1nlPUB-0004XK-9t; Mon, 02 May 2022 06:24:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318638.538479; Mon, 02 May 2022 06:24:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPUB-0004XD-6z; Mon, 02 May 2022 06:24:43 +0000 Received: by outflank-mailman (input) for mailman id 318638; Mon, 02 May 2022 06:24:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPUA-0004X7-C6 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:24:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c5fb2f5-c9e0-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 08:24:40 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-YkxAbIVsMiiDFAzEGMWf4g-1; Mon, 02 May 2022 08:24:31 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB5491.eurprd04.prod.outlook.com (2603:10a6:208:115::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Mon, 2 May 2022 06:24:29 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:24:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c5fb2f5-c9e0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651472680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szyDTvul2sT9/3TeSOuZRAlC7ZjpaKimGak3PGjvGhg=; b=QXIFykRudOCpl1Q5ZBS3NpmBFDQIs5ZDLMDEPrnir8DLq9B+Yq58UTNHFUT71kMx4iyRc6 1Hsaoe60o8YRq5jyJMVqhPLz7VWIvZHrOCvqAbmldtxDDWMwADIQuaYzIbBvy7y6x0IsVx fBasMfY9ztFKTyex4G35xHe7fS/CkjQ= X-MC-Unique: YkxAbIVsMiiDFAzEGMWf4g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IV3/dFyCrFc9E4PMVVO1l5kHP52v8B3yHzf82blYCtVWRQvaCrYMeEi2XBaXewj6gP4bCTsSnbhdl0j0dhm1eTzHi3GSN3xIYJRgeNhXA2AZaUi47dTU/jP3L4Hc/e0urSaoI9WQ96cojcQU07anD44vCvweiTlRBGR2jgmPmtxM0HLtWEzF5M67ySHp5NdebqdMsomvLQfiYpm5MGk6ZU+H6EMO9KzXS8/ZmDvJanJaFfC/njSGKnrldhPU2lCjaIhOr+9YJLTi8l7fLnR0WeULe/4XyGHd+aGiKzL6xidz2eFtFgxv2wuTONojnwH7lbIX9/K1lJz3KJtbJ6nz6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9R7I3NO+z+nhzpo7DQDK/nIYJ5x5gHtybATPYsmPzgc=; b=gEJ4QIudWUXuLkuxrmkzCL3o4gANRoqhfSWJunFrhH/WdZ32oy3Ag8ItW6Qxf+OLSSTh8rhO85gdGlklsglDTn9Ipt43eaMcOMDOHw6rD6vCRVv57ZJH52Vx2sph7HnQkdNzuf4+F/dKcHnCglCwC/mh1/ndswfs0PrbA2oCR1f3qKEAIPXM49yxoN3/aXVCU+uz2jEFNq2JRg7CVS+VpVgKsV/21e7eWgqnuwNE6vkylRQvTU7iRskbsA8fIEihkH0x+CW/gyR05gDrUpEUoogTW8gzvRkTl+4w4VhkezYrxYeVV8Cd38o+vB7ZYRL4egJmHL19nqsCZfyY9GOxlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7ad22939-1096-3d81-f998-4eaf1d9a1d8e@suse.com> Date: Mon, 2 May 2022 08:24:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT Content-Language: en-US To: Demi Marie Obenour CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0295.eurprd06.prod.outlook.com (2603:10a6:20b:45a::12) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33f70be3-d27d-4dda-2280-08da2c046a04 X-MS-TrafficTypeDiagnostic: AM0PR04MB5491:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9BhicGD4lPq0mPYvcsAxOAwQNTn9Nv//dP79ih1vPhHwnZPnerMDMebdtDxoVFG05d2fWxjcTXkfntGQSVOKStdlKNG7nDaHM82ts/QPwPpAtf/KIGhqFgAYDNPnYL2JpCRxl93yaSYexDqQOJ2X6VJ+eBa2BvvpaLuSYQs6EN9Zp5BGXULcw04kb51Van1IR5m6ZoEOC64pZxH7UpEnRNnMgZeltiQFHF2wxQoTHPIjeljaYZ2cnkbebgiAWNlFD2RdJae9W2Wx7OD76kTpPLvinMpBmIhLkNb6QmmFJRe29PGY0LbXkr6fVLrjDP0ZdKxGV2rgbCHoN9JTHr6CXwBJHaD84VEC73p5aoSLxhcoOkSmg07m5nmJGCr4u/pimhfiF8w+9p0DALB1HzQgP7beuPe3sp4VleCVO6YS3BYnxTUz2sQRgT+HZmmI4GXGP57fD+P343DqeRZzjr76DV82btc+XgUb+sQR0Oa25VAd7Tgg2Sfb4mbZWjA3qYJqbrf5YdWHkiZBTxMI/O/B6D8TRBIIjLGZz2VXZyu5u+rMfyeREGPLdQ+UMJXiZAlM/Mk8elAIpJZilAWzxYk8q43YI4/dEmoNd7UhXt9YBvlt9l/s8t7p0yPpmpo0Bt3Jb2ONSq+J3LuMbBjpPUsa0NmVQM+iMvYeWxFrH9MA31+YkeUr3E0muRYGl5/j4F4/dYFR0ukRHk0JlltnMtoE09LxYMJn4Aap1hCFbDIHPZdK2OVn04T2kFFwQTV8ftrfYuNqDSRX4m8wfTcHh5tHDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6506007)(6666004)(53546011)(5660300002)(66946007)(6512007)(6916009)(8676002)(316002)(66556008)(66476007)(4326008)(54906003)(38100700002)(508600001)(31696002)(6486002)(86362001)(186003)(2616005)(83380400001)(36756003)(26005)(2906002)(31686004)(15583001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2q65q/FYTazDFBuyU8XrzqNMuKqbJumWhXtcDNtHQg29H6iMKXSH28RHYaYQ?= =?us-ascii?Q?bFJDYFQRHEn7nDV0Y/imcZhTjmLuRvTwmpOUiy2HS+ayZ9Sm5lDwFSGWtc3J?= =?us-ascii?Q?lyVeWLQ7kOZYZ5SustY5BQcfzYWpgzcgiBRH/D6l5DMFtECL65QhD4xg+L52?= =?us-ascii?Q?o22IPfUfP+6WU9oPOmYn++4Rql+008HYGbl8ldrDnkYlWW9AsveAezMXqTO8?= =?us-ascii?Q?jCn8QBpaC6euQJt4pQ91/R5cRZORFffgfGmcObDrbekZdm/fzwqc7gR6ZUFT?= =?us-ascii?Q?5YLrxivtEcHe1Nj+JTu6Q3qUxN41MyXUqAT/ioE9qxZqyDnwAonCVw2EO3v8?= =?us-ascii?Q?LHkxO+PvMYV/cYJ+f5CNbEbofTw3wEEl2ZmamH2LHQ7ByUQMQX8rT6gRLytZ?= =?us-ascii?Q?PTd566VpGlBeYo8yRiA4umIeRb7YWI1RY8R1BQ+Jz2PuP1TSyfIC3RZ7prpk?= =?us-ascii?Q?LTfRrUS6/ya6Doprk6+oYuqcSHbYCA72X9na72iUsMGiwho2kvuC8F4zog/u?= =?us-ascii?Q?9JXkUBMk1xotYgt0agZuoW3aPwouMb+mC+MbYw3+FTjUu74RZEJAXj+gaBl9?= =?us-ascii?Q?9GE1CqIispj65XI2WJ/Y45ERBfdIuGjcid2q22yCfRGjw1i4u8G4I3bxfj2B?= =?us-ascii?Q?MvB9r5RvvP8YZ2X0cAYFAcMB+1/iI1eWdFtLztxQguuullGtrpVyeDEXq1oM?= =?us-ascii?Q?hPwOr4gUSAlyLy/pCXDQcU726AzKtQ+HO2EHy3eEQNVHDRPkDy7jPdFwN4zD?= =?us-ascii?Q?pH9g8LirnHiIpH2JktPLVgJ5CEg5O84gZ92cRNWPMOXPJ6i9WqgpsxbKgscm?= =?us-ascii?Q?Cu/x198fgQ/StQIBxCLc2HiH0NgDpqBsGpTF1ZsxHa0DEk1XnYVOYIDYeuZw?= =?us-ascii?Q?CyKDjN3TtMe8nEbPAix1XeLRfnz+VCTMo3goob9Htwpxly5FSCAeevw/F3+N?= =?us-ascii?Q?0IFGrv/n5og56+D1fMlI04cEs6TJGT5Gp6TEBYF72sDlQoUZHFuTf3AsX5pF?= =?us-ascii?Q?JF+HkOxPud2Yi1Mk6IMcnVoQdFT6ItB8iOEwigi0xCN1PcGx6CrMAxpqUat2?= =?us-ascii?Q?nmWkFr+3GGdPQWawo/1vHS3w2Qe4NTshZRa331j+OVnfhGyQ3pSHet5ewrPm?= =?us-ascii?Q?6DaE+ZIqK1NzdOVWDj4zVY0rHkJWkMMymiGnfaE+98wiqfXAm8tY82gFm9op?= =?us-ascii?Q?6eViaifGuinrtixlEUtrLrH8pOZks0YmRiAIrap7+uvWeXRVXHPHVgINgZZI?= =?us-ascii?Q?PypcgiDVl0CTF8+/2TaRoV/fKrpvJARXbEkjIMJDmEMFT82dm9k7YAUBjXnk?= =?us-ascii?Q?6r62DJX/mj8hd3xbuRwEF8QcSo4sbzhKfbrMjs6FYW9lJqidJAtw2PHirgI7?= =?us-ascii?Q?1sW05e63sRjz6EO08KFgeWGJbW14n8d62fF2rCuWLS3Us3KzPrg1/OC8fhbW?= =?us-ascii?Q?WIDqRbdAo0ZBpJ2uK5ty7HfQ6BcmkT/Hv3Uf1YW8mwi+OnjCxnNoWVyJlUwR?= =?us-ascii?Q?vrxzyxhHq22ZtzOdpc06RrQ76lVSb/SSaWJeWmjwSDTdm/QADAbj53I5Z1jI?= =?us-ascii?Q?It2uxd9cE/VKTRf3ugCcjv7l0EwSZdh8lIUY2GxEj7DAjB9c4SQyX9r6vVD9?= =?us-ascii?Q?W04SwH7S2os13NDHJKbFK5N2FmXB7391T37raG3HIXQHAnw+Youb5jsPYB+B?= =?us-ascii?Q?PTink2/gt8vDUALaypqI0I8B0uiCrsIleAU5wyU0CWwAIBdEXx8fbWPIF0Qd?= =?us-ascii?Q?QDPgGkN0wQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f70be3-d27d-4dda-2280-08da2c046a04 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 06:24:29.7899 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O8xv4VALYPe0yWsh1o+IG2F5tDLH59UnuBEzIRcaQA/Ls7uMgiQ9TGQMgZZ4ixGLZSY1WyuHFfE3oz+tLmHTLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5491 On 29.04.2022 19:06, Demi Marie Obenour wrote: > On Fri, Apr 29, 2022 at 10:40:42AM +0200, Jan Beulich wrote: >> On 29.04.2022 00:54, Demi Marie Obenour wrote: >>> On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote: >>>> On 27.04.2022 21:08, Demi Marie Obenour wrote: >>>>> On further thought, I think the hypercall approach is actually better >>>>> than reserving the ESRT. I really do not want XEN_FW_EFI_MEM_INFO to >>>>> return anything other than the actual firmware-provided memory >>>>> information, and the current approach seems to require more and more >>>>> special-casing of the ESRT, not to mention potentially wasting memory >>>>> and splitting a potentially large memory region into two smaller ones= . >>>>> By copying the entire ESRT into memory owned by Xen, the logic become= s >>>>> significantly simpler on both the Xen and dom0 sides. >>>> >>>> I actually did consider the option of making a private copy when you d= id >>>> send the initial version of this, but I'm not convinced this simplifie= s >>>> things from a kernel perspective: They'd now need to discover the tabl= e >>>> by some entirely different means. In Linux at least such divergence >>>> "just for Xen" hasn't been liked in the past. >>>> >>>> There's also the question of how to propagate the information across >>>> kexec. But I guess that question exists even outside of Xen, with the >>>> area living in memory which the OS is expected to recycle. >>> >>> Indeed it does. A simple rule might be, =E2=80=9COnly trust the ESRT i= f it is >>> in memory of type EfiRuntimeServicesData.=E2=80=9D That is easy to ach= ieve by >>> monkeypatching the config table as you suggested below. >>> >>> I *am* worried that the config table might be mapped read-only on some >>> systems, in which case the overwrite would cause a fatal page fault. I= s >>> there a way for Xen to check for this? >> >> While in boot mode, aiui page tables aren't supposed to be enforcing >> access restrictions. Recall that on other architectures EFI even runs >> with paging disabled; this simply is not possible for x86-64. >=20 > Yikes! No wonder firmware has nonexistent exploit mitigations. They > really ought to start porting UEFI to Rust, with ASLR, NX, stack > canaries, a hardened allocator, and support for de-priviliged services > that run in user mode. >=20 > That reminds me: Can Xen itself run from ROM? I guess that could be possible in principle, but would certainly require some work. > Xen is being ported to > POWER for use in Qubes OS, and one approach under consideration is to > have Xen and a mini-dom0 be part of the firmware. Personally, I really > like this approach, as it makes untrusted storage domains much simpler. > If this should be a separate email thread, let me know. It probably should be. >> So >> portable firmware shouldn't map anything r/o. In principle the pointer >> could still be in ROM; I consider this unlikely, but we could check >> for that (just like we could do a page table walk to figure out >> whether a r/o mapping would prevent us from updating the field). >=20 > Is there a utility function that could be used for this? I don't think there is. >>> It could also be undefined behavior to modify it. >> >> That's the bigger worry I have. >=20 > Turns out that it is *not* undefined behavior, so long as > ExitBootServices() has not been called. This is becaues EFI drivers > will modify the config table, so firmware cannot assume it to be > read-only. Ah, right - we could even use InstallConfigurationTable() ourselves to make the adjustment. >>>>> Is using ebmalloc() to allocate a copy of the ESRT a reasonable optio= n? >>>> >>>> I'd suggest to try hard to avoid ebmalloc(). It ought to be possible t= o >>>> make the copy before ExitBootServices(), via normal EFI allocation. If >>>> replacing a pointer in the config table was okay(ish), this could even >>>> be utilized to overcome the kexec problem. >>> >>> What type should I use for the allocation? EfiLoaderData looks like th= e >>> most consistent choice, but I am not sure if memory so allocated remain= s >>> valid when Xen hands off to the OS, so EfiRuntimeServicesData might be = a >>> better choice. >> >> It definitely is. We do recycle EfiLoaderData ourselves. >=20 > I wonder why the ESRT was not in EfiRuntimeServicesData to begin with. So do I. >>> To avoid memory leaks from repeated kexec(), this could >>> be made conditional on the ESRT not being in memory of type >>> EfiRuntimeServicesData to begin with. >> >> Of course - there's no point relocating the blob when it already is >> immune to recycling. >=20 > Yup. Is it reasonable for dom0 to check that the ESRT is in > EfiRuntimeServicesData when under Xen? I think it is, but kernel folks may not like Xen specific code in this (or about any) area. Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 06:33:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318645.538491 (Exim 4.92) (envelope-from ) id 1nlPcx-00067r-CX; Mon, 02 May 2022 06:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318645.538491; Mon, 02 May 2022 06:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPcx-00067k-7u; Mon, 02 May 2022 06:33:47 +0000 Received: by outflank-mailman (input) for mailman id 318645; Mon, 02 May 2022 06:33:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPcw-00067e-5y for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:33:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0b49308-c9e1-11ec-a405-831a346695d4; Mon, 02 May 2022 08:33:45 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-0fA6E43dOR-nGPAflxj5KA-2; Mon, 02 May 2022 08:33:43 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB8586.eurprd04.prod.outlook.com (2603:10a6:20b:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 06:33:40 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:33:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0b49308-c9e1-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651473224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ll/cG+hgZ50hXK8PlMmD+tzjmdvby0u0ztVZzLVRIg=; b=Asg0x7PBFxVA/EQkiHtLOmQBG6vEddpzJf3kvvM3qhbuqXiLd2+zzpCDuXUAlz7MjzskGq Ki2mStseFINN/oc9sUzaLC7RRSEG6kLEsyzhle/Hhg97AX+dWCrce1cBBKu+9MH9b+lTFD HHwByw25Y5tDCLeBcDqcQbijTFN5tQE= X-MC-Unique: 0fA6E43dOR-nGPAflxj5KA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BXK7HazJkaRhk6Pca6YOU8DvzDhv8oJ3tmq8nujUqKcd3CX25q2GdVrxmbcDsdhT3GpUr1vvZRn0TuYlIZ5/0VBZUxorRuw9mSzR0I8AQHWtNjxoSppRv2xVIlwTxggPjhFN8OioQexzw+dJo1SaZAQTmi2yGheV9c9krcn9wq4LoQ7AbRPbv8LewdzE2mQDKXsbyj7vEd0NbzbLGm/zIYO706l7QSANx3KiDVfWzsbW15WTJwa11sJzwn3Gyb1G3ol63Lw+xPalhT49jo8HfQDeWDFJd0fu/EccVnq4/yjN92DZoT27N+6dumY7Scq3iMGL6toVCW4ACH0J30YUpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ll/cG+hgZ50hXK8PlMmD+tzjmdvby0u0ztVZzLVRIg=; b=GanKL8I2/PIFsFj7gCSgxiCxhRlQwJ6J+uj0B8x5xVYJpPETIJ3MWpLAK//mDnSQwaX+fYvgq/IlMDOhPlW7Vd7pJDg9ZfAabbbeTqYG5/zGV8ZJ1/ioSQoXfi6ATsLwRS7Le3XGpx0AjoikJtb48C4Ki54ZPnRNJbALIb5T6mawXk0/LclGfDLh1kxLB7HCTYuAsPDs0fpBgztffuedUfwoer16coriPuqs/sxyZnDKAKiKmJ2uCbiUS27jfZ4CoyIa0gIONevfNYRY9a3WOpW++2wX1gnKBgYWkOCpHwhIxA+6UPJIGNoRTRaOjSkkz+kFhnWYvof996maDUwQJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0d726025-3ea0-e66e-d4c8-77708f0aaa94@suse.com> Date: Mon, 2 May 2022 08:33:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Content-Language: en-US To: Stefano Stabellini Cc: jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220429205732.2030094-4-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20220429205732.2030094-4-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR01CA0068.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::45) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 031cb4da-7b83-4eb4-cdf9-08da2c05b1f7 X-MS-TrafficTypeDiagnostic: AM9PR04MB8586:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fsdtOmkpYDI6Pb2btIOIVYAz0W2dwYnbBAsWlHk+oMNqXjzhA7EoJXdgIztLmT+t09f/+D1MRbU7Clr5dN/jynmT1UCg7O5wqLZH2xMB9md4uxos+6Tbwn4trJUtBzjFPkVJnEYyoMlxArYHHpN9vvQGvfDZWfxHMlioJbbR6ySK7VSIDkT9xjPBy8JX8B6Lkdpt5wQwfEBYDOG8a0Sx0+2UKwQlhXMx+7GFYKCztL3DqcQ94S2yJCqbLbCS0Y1e5Izu9huGt72JGLOmwyS5TLrrCz0TJ6jz5s+apR3O0m9s5TmOvEge0A3A1laPnFI0CMNi3wEnSN05/rldg3QjdKDROFPnbP6j3B5YSaGq3keCt2MENTrkil1pDyinlga1GcHkEjV4wnwiomFgyBx0Fug+0LjFyaUVAnMhY4Fb0SqBvBsNH6r+v1LMUQAEHyh5fWUb2PHmJGAUZLNCy5ZIDCvHczCLgNhhDe355J56bf+W8r7Y0YyyJbnsOn8j9aDJUPp0oWPKTqFfniCUMRs+WQ+k1g1vX5tCt7HydMXzF6VE0dqXtNuoZE/szKW55654CLmdkSpj2TQxsuvUR/Kpkxe/WAESh+4bvAiALRR7N7qHoJyNWIEQS9c3aSTjaX1xe+QTXqzYs/OeMMve/KvucAcLrsoTosxl2PAPRrNz09UinbQMNkqn5J57OrJf+UsDjaF9ezfvbBJfs0OBKukPxeVN0CUVYk1REFl2DhrQ6WTHbbDBXrC4ECVa52LHlQqR2GX0Lkik3SQEq+b6hAYNuw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(4744005)(38100700002)(53546011)(6506007)(6512007)(36756003)(31696002)(86362001)(54906003)(508600001)(6486002)(2906002)(66556008)(5660300002)(83380400001)(31686004)(8936002)(186003)(2616005)(66946007)(316002)(6916009)(8676002)(4326008)(66476007)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk11d1lsbVpIdUhMU1NXeEliL3VPczBOb1BkY1RlVjFETlp0MHN3VGxPMUs2?= =?utf-8?B?Nnd4cUxJdjlWdlBNNndneURVMzVrVldKakprMEl3TVhTcHgwSG85R0dJNC9u?= =?utf-8?B?TUUrcENwQjhRdUFjMWo2MWRHYlRtL3BBaVdVQ2tubSt5MEFyM1pvVU5xNUFZ?= =?utf-8?B?aDcyOWpKWjB4OWJOaUlKdjJVU0E1aWtJZGR6enA0UlRjSVp2ZnYwTldDVWJV?= =?utf-8?B?VDBzVGNlaWdYTXd2UlZBMHhsd3RSemFQckFKMkI4Smx1UWtnTTRwRUFOZjh2?= =?utf-8?B?YVVXVGVDWURVcHdyaTZlQjcyaVp4dXpOMGMraUl6TTRzVmZSQkd5eDFIa01x?= =?utf-8?B?REowUFZTTTlDdlA5L3Z1TXFzdUdXdUN0U0ZCdFp2VUxMNDkvMHhIb3owNFA3?= =?utf-8?B?OGFWaGZWalhxQi94aFFhMDZtMnFKdE9wVFI3U1AydW9Fbkc2RzZrWHRXSlM1?= =?utf-8?B?STRLRFlJakNQVjNrUGhhYk93NGlmSUVHZUZ0N0Q4R3k4T1JJWFZhT0FQeXgv?= =?utf-8?B?SVRDWEUrSDJlU3dTZlhaTzFIU3lOZjdWVmlWdkNkeThRY25UbEJUVVkyMkVC?= =?utf-8?B?dFc5ZWwvR0RQZUl2eDlGWWYvb2RSa1FCTjdxeFVZMi9wK2R2endIbVdZd1Zk?= =?utf-8?B?bVhmc0x4S2lnY0wxY1diR0VNZVJWcUxaZndQcnBsQUhCRzVqOUUxMGJSZnpE?= =?utf-8?B?RkFNK0p1c3BlQUtIWmVXbGNkbExSRGFNeWw1NTNRWS9CanV3WXRoNURUUTI0?= =?utf-8?B?Rm40cnVZSXZrN1ltcGdOVThOWUp0bjEzMzYzZ1h0RVhZKzI1ODJtVWorbEVn?= =?utf-8?B?QXJ2OWcvWjJRSGprRURYcjU3T0Q5WHdSWHFtRVlubHVERzMzVlJRUmdPa3lO?= =?utf-8?B?UUl4ZU5zbk5KUklJaDJ1eXpTQ2VROTFxRG45aTh0K3ZDQmVwcHdYK08zNEFv?= =?utf-8?B?N21IbEhaeW9ETGUrSmpKWFoxdkl2aktMRmhVVVl1VzhhYW1lSTlzVURBTEJx?= =?utf-8?B?eVJsblBTVlIvV0llcWdyUHpXcTI4Vll0M0ZlYTlOekJLOXY1QTJLcVRwTUxa?= =?utf-8?B?SXpYYUR1TUxSOElnbkZsM0JRK1RuRDFqOEJraUZnZ00vNVVXM1JDV2NHY2pN?= =?utf-8?B?NTVoSEJLY1RTaG9Jd1JyaWxSVFBJMWlFU0RaYW0yb3VXNlFYaENmSUJKSzU0?= =?utf-8?B?YWlldmxwaWR4Y3h0WUd1ejkvT05sd0hrTzIrZHpmS05yTHBXMmNBSlJWOTRG?= =?utf-8?B?dm9qSngvSTFnendzemhPSGVTZU9oQVkvZWpwcDRXdndrU0tiOWE1VS9Eenox?= =?utf-8?B?WmcvOFFwWWJWQUhxbTRCNHhBU2hPMUYvaSt3ODRyUk5ha2JaZ0JKcUNPdmFP?= =?utf-8?B?V3lPS0doZXFYaHJGek91eVB3U0E4aitteFpDRlNYeGttc0t2dFBuYTFGOVNv?= =?utf-8?B?dnBhb1NvV1dLYTNuWVhtSGZZM3NpMlh5cGZ4MitPeDNHazJKcGxGQUl4NERt?= =?utf-8?B?WVIvcHhjNVZ5dWpPK3ZqSEdUVzl0cHk1dWc3NEp3WDZacTVVTXBsOUZYeTBR?= =?utf-8?B?UkxwRmZyTHV2OEM2WjJtQ3VnM0xvem9sbmJ5ZjdxNEJpeStnckZrbE93ZHMy?= =?utf-8?B?UFZ1eVgzeDZVbWNNbnlXelNVck9wQmg4WFRIOUJGSnd2WWc3dWFTNThIbDd4?= =?utf-8?B?VGp4VGR2T0FMVTJiTlo3N2VNUGpkS1AvcDBJaW5SdTV5VXFSbEkxMy9hYmtD?= =?utf-8?B?TzNZT1FpMXBMQjRCMnkxL1VFWXdPdkEzTTdZTnpWc0prTXZxVEJveHJxMjZX?= =?utf-8?B?SEFpYktCd3YrditJbXZvUUY4R09DNFVNdWk4b0V1K2k3b2d5Z3gzVGVMc3NQ?= =?utf-8?B?emNTUVpTVHU2eEVSN3pNcjZsRWp2ZGNacHBJSUthK0hVVmtsVVNPMGdYU01z?= =?utf-8?B?OTBaVlZ3dDQ5UTVuck5IakVadG1CcHJaOWlvcnZNUG1kSUpVNlAwcGFONlFN?= =?utf-8?B?anJVNzhGVnNETy9qR000Yk1jSlZlOEJPd0hjdHpYOEVNYUEwNkh3dmVTN1Bv?= =?utf-8?B?Q1dkcmxkMFcxNG9yZTd6UkhOUTMvbmN4TkpHTGN3T2VTUzdzZGZkRTIwVXF6?= =?utf-8?B?UFZIeXBIazB6UWg1QThWVU5GTTN1U1l2dGl1REw0WlFjSWw5NTZWRytBaG1o?= =?utf-8?B?aW9SNnNYdmlZK2Nvc0JjMFkzeDRtWlZCZGptVzZyM2IzcjVpV05KcDdXME1E?= =?utf-8?B?S2VMcDArdEY1SzZrcDRWMVZGZ3czT25QWDhWUzhpNnJINXZHQWJab1VIM1Jh?= =?utf-8?B?RFFZWDJDTWhNQStFRnBLdDRPVjVzV0JEWmw4ZzU1dFdJWXQ5WnFrUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 031cb4da-7b83-4eb4-cdf9-08da2c05b1f7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 06:33:39.9706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gr6FlUvEm8DsB7jklzDokH7RPHS7UjpbJtAwBNzf0M3g/ylVCUzQkHiwbGSb2dETIc1TbR8x5sROroKqnJiVTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8586 On 29.04.2022 22:57, Stefano Stabellini wrote: > From: Luca Miccio > > Export evtchn_alloc_unbound and make it __must_check. > > If "xen,enhanced" is enabled, then add to dom0less domains: > > - the hypervisor node in device tree > - the xenstore event channel > > The xenstore event channel is also used for the first notification to > let the guest know that xenstore has become available. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon May 02 06:51:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 06:51:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318651.538502 (Exim 4.92) (envelope-from ) id 1nlPuK-0000QC-Qt; Mon, 02 May 2022 06:51:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318651.538502; Mon, 02 May 2022 06:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPuK-0000Q5-NS; Mon, 02 May 2022 06:51:44 +0000 Received: by outflank-mailman (input) for mailman id 318651; Mon, 02 May 2022 06:51:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlPuJ-0000Pz-0g for xen-devel@lists.xenproject.org; Mon, 02 May 2022 06:51:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5035d4be-c9e4-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 08:51:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DBD4B210ED; Mon, 2 May 2022 06:51:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A3DE213491; Mon, 2 May 2022 06:51:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aqmfJnx/b2IGZwAAMHmgww (envelope-from ); Mon, 02 May 2022 06:51:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5035d4be-c9e4-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651474300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lz8F/hGANIj6p9Z8b1GyFyuSMDlDcv7rAH35Iu3UJBU=; b=ox2+MICpVtMyzj73sEp3eDSBH5fvZSWZ3KqMdxd20sxtcTiGx9XslFP9AVky9PjO0QfqWR a4ZSnB0BVZaXsgWA2oek4rfJPp1ixFwNmeNwqjmryjw0QVb6pWsecdbzYn96OvzaoeyNB5 bV0XNn/HN9En4E25Y0/c0cwmqyy4Vi0= Message-ID: <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> Date: Mon, 2 May 2022 08:51:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [xen-unstable test] 169819: regressions - FAIL Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kOCQSCfrJ2iV9lxuK0XNRK9w" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kOCQSCfrJ2iV9lxuK0XNRK9w Content-Type: multipart/mixed; boundary="------------EEP0piTDTqRUvH9Lnce00jN4"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner Message-ID: <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> Subject: Re: [xen-unstable test] 169819: regressions - FAIL References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> In-Reply-To: --------------EEP0piTDTqRUvH9Lnce00jN4 Content-Type: multipart/mixed; boundary="------------akiveSgPlqMKkP7yZ3pEwn9e" --------------akiveSgPlqMKkP7yZ3pEwn9e Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMTM6MDAsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIEZyaSwg QXByIDI5LCAyMDIyIGF0IDEyOjM3OjEzUE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0K Pj4gT24gMjkuMDQuMjAyMiAxMjozMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBP biBGcmksIEFwciAyOSwgMjAyMiBhdCAwNzo0Njo0N0FNICswMDAwLCBvc3N0ZXN0IHNlcnZp Y2Ugb3duZXIgd3JvdGU6DQo+Pj4+IGZsaWdodCAxNjk4MTkgeGVuLXVuc3RhYmxlIHJlYWwg W3JlYWxdDQo+Pj4+IGZsaWdodCAxNjk4NDMgeGVuLXVuc3RhYmxlIHJlYWwtcmV0ZXN0IFty ZWFsXQ0KPj4+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0 L2xvZ3MvMTY5ODE5Lw0KPj4+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9y Zy9vc3N0ZXN0L2xvZ3MvMTY5ODQzLw0KPj4+Pg0KPj4+PiBSZWdyZXNzaW9ucyA6LSgNCj4+ Pj4NCj4+Pj4gVGVzdHMgd2hpY2ggZGlkIG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcs DQo+Pj4+IGluY2x1ZGluZyB0ZXN0cyB3aGljaCBjb3VsZCBub3QgYmUgcnVuOg0KPj4+PiAg IHRlc3QtYXJtNjQtYXJtNjQtZXhhbWluZSAgICAgIDggcmVib290ICAgICAgICAgICAgICAg ICAgIGZhaWwgUkVHUi4gdnMuIDE2OTc3NQ0KPj4+PiAgIHRlc3QtYXJtNjQtYXJtNjQtbGli dmlydC14c20gIDggeGVuLWJvb3QgICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE2 OTc3NQ0KPj4+PiAgIHRlc3QtYXJtNjQtYXJtNjQtbGlidmlydC1yYXcgIDggeGVuLWJvb3Qg ICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE2OTc3NQ0KPj4+PiAgIHRlc3QtYXJt NjQtYXJtNjQteGwtY3JlZGl0MSAgIDggeGVuLWJvb3QgICAgICAgICAgICAgICAgIGZhaWwg UkVHUi4gdnMuIDE2OTc3NQ0KPj4+PiAgIHRlc3QtYXJtNjQtYXJtNjQteGwtdGh1bmRlcngg IDggeGVuLWJvb3QgICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE2OTc3NQ0KPj4+ PiAgIHRlc3QtYXJtNjQtYXJtNjQteGwgICAgICAgICAgIDggeGVuLWJvb3QgICAgICAgICAg ICAgICAgIGZhaWwgUkVHUi4gdnMuIDE2OTc3NQ0KPj4+Pg0KPj4+PiBUZXN0cyB3aGljaCBh cmUgZmFpbGluZyBpbnRlcm1pdHRlbnRseSAobm90IGJsb2NraW5nKToNCj4+Pj4gICB0ZXN0 LWFtZDY0LWFtZDY0LXhsLXFlbXV0LWRlYmlhbmh2bS1pMzg2LXhzbSAxMiBkZWJpYW4taHZt LWluc3RhbGwgZmFpbCBwYXNzIGluIDE2OTg0My1yZXRlc3QNCj4+Pg0KPj4+IExvb2tlZCBp bnRvIHRoaXMgb25lLCBhbmQgaXQncyBzbGlnaHRseSBjb25jZXJuaW5nLCBndWVzdCBzZWVt cyB0byBiZQ0KPj4+IHN0dWNrIGF0IGluc3RhbGxhdGlvbjoNCj4+Pg0KPj4+IFNlbGVjdCBh bmQgaW5zdGFsbCBzb2Z0d2FyZSAgWyAgNDgxLjA5Mzg1N10gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4g WyAgNTA5LjA5Mzg2NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNTQ1LjA5MzgyMF0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4gWyAgNTczLjA5MzgwOV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNjA5LjA5 Mzg1NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNjM3LjA5MzgzNl0gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4gWyAgNjczLjA5Mzk1N10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNzAxLjA5Mzg1NF0gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4gWyAgNzMzLjA5MzgwNV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNzYx LjA5MzgxN10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgNzk3LjA5Mzg5OF0gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4gWyAgODI1LjA5Mzg2M10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgODYxLjA5Mzg2NV0g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4gWyAgODg5LjA5Mzk0NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBs b2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAg OTI1LjA5Mzk3NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAgOTUzLjA5MzkyNV0gd2F0Y2hkb2c6 IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6 MTddDQo+Pj4gWyAgOTg1LjA5MzgzMl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMDEzLjA5Mzg1 NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMDQ5LjA5NDAzMV0gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4g WyAxMDc3LjA5Mzg2MF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMTEzLjA5MzkzOF0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4gWyAxMTQxLjA5MzgwM10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMTc3LjA5 NDA1MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMjA1LjA5MzgwNV0gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4gWyAxMjM3LjA5Mzk1NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMjY1LjA5NDAwNF0gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4gWyAxMzAxLjA5MzgzNV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMzI5 LjA5NDAzOV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxMzY1LjA5Mzg4M10gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4gWyAxMzkzLjA5NDE2N10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNDI5LjA5Mzg1N10g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4gWyAxNDU3LjA5MzkwMF0gd2F0Y2hkb2c6IEJVRzogc29mdCBs b2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAx NDg5LjA5NDAyNl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNTE3LjA5Mzk5N10gd2F0Y2hkb2c6 IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6 MTddDQo+Pj4gWyAxNTUzLjA5Mzk5Nl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNTgxLjA5NDA2 NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNjE3LjA5NDA3Nl0gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4g WyAxNjQ1LjA5Mzg4Ml0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNjgxLjA5Mzg5Nl0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4gWyAxNzA5LjA5NDAyMl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNzQxLjA5 Mzg3MF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxNzY5LjA5Mzg1NF0gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4gWyAxODA1LjA5NDAxN10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxODMzLjA5MzgzN10gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4gWyAxODY5LjA5NDA0M10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxODk3 LjA5NDEwMV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxOTMzLjA5Mzg3OV0gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4gWyAxOTYxLjA5MzkzM10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAxOTk3LjA5Mzk1Ml0g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4gWyAyMDI1LjA5MzkyNV0gd2F0Y2hkb2c6IEJVRzogc29mdCBs b2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAy MDU3LjA5Mzg5NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMDg1LjA5NDE3Ml0gd2F0Y2hkb2c6 IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6 MTddDQo+Pj4gWyAyMTIxLjA5NDAxOF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMTQ5LjA5NDAy MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMTg1LjA5MzkzMV0gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4g WyAyMjEzLjA5Mzg2NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMjQ5LjA5Mzk1MV0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4gWyAyMjc3LjA5Mzg5OV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMzA5LjA5 NDA1NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyMzM3LjA5Mzk1Nl0gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4gWyAyMzczLjA5NDExMV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNDAxLjA5NDEzMl0gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4gWyAyNDM3LjA5NDA2NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNDY1 LjA5NDAwM10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNTAxLjA5Mzk1OV0gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4gWyAyNTI5LjA5NDA1MF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNTYxLjA5NDAyN10g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4gWyAyNTg5LjA5NDA2MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBs b2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAy NjI1LjA5Mzk5OV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNjUzLjA5Mzk1Nl0gd2F0Y2hkb2c6 IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6 MTddDQo+Pj4gWyAyNjg5LjA5NDAyNF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNzE3LjA5NDA5 M10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyNzUzLjA5MzkxM10gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4g WyAyNzgxLjA5NDA5NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyODEzLjA5Mzk1OV0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4gWyAyODQxLjA5NDExN10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyODc3LjA5 NDA0MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyOTA1LjA5NDAwOV0gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4gWyAyOTQxLjA5Mzg5M10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAyOTY5LjA5NDA4NV0gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4gWyAzMDA1LjA5NDA2MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAzMDMz LjA5MzkxN10gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4gWyAzMDY1LjA5NDA2MF0gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4NCj4+PiBkZWJpbmExIGlzIG9uZSBvZiB0aGUgYm94ZXMgSSd2ZSBwdXQgaW50byBw cm9kdWN0aW9uIHJlY2VudGx5Lg0KPj4NCj4+IElTVFIgdGhpcyBpc3N1ZSBoYXZpbmcgc3Vy ZmFjZWQgcmFuZG9tbHkgYmVmb3JlLiBXaXRoIHRoZSByYW5kb21uZXNzIG1ha2luZw0KPj4g aXQgZGlmZmljdWx0IHRvIGludmVzdGlnYXRlLg0KPiANCj4gSW5kZWVkLCBpdCBzZWVtcyB0 byBoYXBwZW4gb24gb3RoZXIgYm94ZXMgYWxzbzoNCj4gDQo+IGh0dHA6Ly9sb2dzLnRlc3Qt bGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvcmVzdWx0cy9oaXN0b3J5L3Rlc3QtYW1kNjQt YW1kNjQteGwtcWVtdXQtZGViaWFuaHZtLWkzODYteHNtL3hlbi11bnN0YWJsZS5odG1sDQo+ IA0KPiBBdCBsZWFzdCBkb2Vzbid0IHNlZW0gdG8gYmUgZXhwbGljaXRseSByZWxhdGVkIHRv IGRlYmluYXMuDQoNCkhvdyB2YWx1YWJsZSBpcyBpdCB0byB0ZXN0IHN5c3RlbXMgdXNpbmcg YSBrZXJuZWwgZnJvbSAyMDE5Pw0KDQpDaGFuY2VzIGFyZSBoaWdoIHRoYXQgYnVncyB3aGlj aCBtaWdodCB0cmlnZ2VyIGFyZSBjb3JyZWN0ZWQgYWxyZWFkeS4NCklNTyB0cnlpbmcgdG8g ZmluZCBwcm9iYWJseSBrbm93biBidWdzIGlzIGEgd2FzdGUgb2YgdGltZS4NCg0KDQpKdWVy Z2VuDQo= --------------akiveSgPlqMKkP7yZ3pEwn9e Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------akiveSgPlqMKkP7yZ3pEwn9e-- --------------EEP0piTDTqRUvH9Lnce00jN4-- --------------kOCQSCfrJ2iV9lxuK0XNRK9w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJvf3wFAwAAAAAACgkQsN6d1ii/Ey9t mwf+Iunh8S7KX9vDZCM5vHxyG0Tqi9iyeAc/MP8ErDKwEStV1nhr7L2bX5JkB5am+wPt+utO6kyT SE7Hog8eqYRrKoA9bm4NVuVwNsD8iPM/HiZwrvP/XKtY3jsWpHp9Ag/B8UKbFCxiS3CUzpvqBBbj Iow23CH+yxRU6nyt+bqLFawdg1koA85PrdhBefMbUw/egDUg81Dkqu96iCqtPFf1lMLD4vIATtKB XQzVkZgDWHIUJ4A+JidCR9KmDwX0mFjDdyfhKi/mmcjWnhEDdvPwCAmUS1lTBel0z5hUxtOiB8RQ 94CXHM08xO6VOhddbnO8yWT13B12AoHJaepov/bOvQ== =1Dph -----END PGP SIGNATURE----- --------------kOCQSCfrJ2iV9lxuK0XNRK9w-- From xen-devel-bounces@lists.xenproject.org Mon May 02 07:10:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 07:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318663.538533 (Exim 4.92) (envelope-from ) id 1nlQBs-0002WO-L2; Mon, 02 May 2022 07:09:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318663.538533; Mon, 02 May 2022 07:09:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQBs-0002WH-IA; Mon, 02 May 2022 07:09:52 +0000 Received: by outflank-mailman (input) for mailman id 318663; Mon, 02 May 2022 07:09:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQBq-0002WA-Q4 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 07:09:50 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id daa3534f-c9e6-11ec-a405-831a346695d4; Mon, 02 May 2022 09:09:49 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-IJx1AU5KOUiMJo18yWDyUg-2; Mon, 02 May 2022 09:09:47 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AS8PR04MB7990.eurprd04.prod.outlook.com (2603:10a6:20b:2a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 07:09:45 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 07:09:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daa3534f-c9e6-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651475388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n2fo7Dzsa3Ft/jtdOiWLptZXqbyNFQKnC9Q6PYIyfEo=; b=efxhoNE35TaCIkgrsXgCITlDw1LEnE4eFvSZa5IB+u2a9LhSceQbm66hQ8X8sopTPy2f38 TDWapzH/LZ9m9io6Upyg+GVAaH+XMSToxx4YeQoQ9RB5UGEbcYIhCVCfIvlIhAzuIcb7/O IRPGXNFrdvjgTopZzcgbsopFsIiFmxs= X-MC-Unique: IJx1AU5KOUiMJo18yWDyUg-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmZzk6dxn+vlkfrOnUyyUQXW12uQp+7gOtfpGDUphZUfTiRE/prOrO4VG+w7Wj1wG7jMQUpQXatb4zhVYVi/vcC5qaNdxEZcniERdhtyRzERf+HrVOL/IpJqkOsL1XMmEIA1JWVoQkX5JfphPvW4D6ZZkfxG58QdXx68qEv0x7bxWwNLHeAfgDXIYT90Hj6KeWvTQWFEo1SNavaDN9UBkXP5WiQ8Cs5LaEagDg/IQ/sjGSYwGl6W4aW8DXbsIBGhGdZwJcROoL5VvB+ha/l0GsZg1L4yWWXLPG1cPYRFnd4+3sHOboQOur0Vt+L+lfLgAdyCFymuTmqsPpKyzaHVtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2fo7Dzsa3Ft/jtdOiWLptZXqbyNFQKnC9Q6PYIyfEo=; b=fAveWQ8BdseVVpOJr9BLK2SjSBgFts1C2weBCbYVLOzBg42Hxdg1KMBxz86zlJThK4VHny2Kf24UuPHhaZUr/eXgwzxqXxRx9KrPu9pciYCFGHo9xxGMKF+CwAasAIzAo+kX/us9xesarexb5lTJ2C7fuxg+tD4Y9MbQhfk81H3IwCnVL065L/LVkdcjf/l5tN2zcWD/IXcqSls7cSpzvIcihpFjiqpF5VMBHIEraLi16pKYY14NB29Ql1UBmF9pmgB3wSkK5lYkgms7V6dK5TDjyodri4IuJroVgkzu16VTs1aBpf1YqY2FcqB5lVTAdpSgn9x2Y4+J5Ea7RyjkgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <994cfe5b-21b8-c59d-8160-792975304604@suse.com> Date: Mon, 2 May 2022 09:09:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Jan Beulich Subject: [PATCH v3] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0276.eurprd06.prod.outlook.com (2603:10a6:20b:45a::34) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cd9b6c6-e2c0-4d65-7fe0-08da2c0abcda X-MS-TrafficTypeDiagnostic: AS8PR04MB7990:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EnktQy76kVH3yVQYacjF+t0AI8Fo5otsq+h1EkYC46JluFT9aV+HoRiOk7ReALQURIN+ciFDahzMCEqpZ/0qlVWxTnSjUHwizwC5T0YKM11+cmkcOF8tpjdcWfqHbJHF8lWLoFDgOppwiGP1uRabJfIS6LJYod1T+HIp9unQMQreMoVMhZeM2RaT22H4TXo3gEhXey1UMLCevAFVM8jqT6ZDf2/cAZnaTKGrgFw5Yfvhb2bRrpnrVzHnUjwelPy72zPUj+xJ2LDE25XL4hvI0s4JWk3HVMaqMw7aKqkU9wKFL7t+frC8exrfBnqFyp4DlU/FtWBdhjQZOxFMtPXBE16D1hQ8B5KYp6dZdpEvVidk4Shuq55aR9qCbMtKFlljqkZkilxDJhSyw/CXerZ1b2uaT8Tfgw5CrZw1vtF02Q8TiptSv+jDuytYIBNixoANAaFCMnEBnOg+P7AaQR46fsfQ0L1LugOArkZT03wylHSHpUrSpK8FsxkY4bpUB2xSgTpzpCbALEugmCLJYo+kNigaiT5CemjugxuQe3A9npaWULgUF0Q0BVpnbCNgoKQeUNwmB4xpeSSa3WqhHgGgks5yDws2pmMPLp/nhlcvGGLFJRW5Zl7iiG8E7Qt7DY+4I2wc4OihnAg0oHwS4+Ed1EsIrNu/MH1YRZtVX+MNiEUpQF8vhTf7UPOkp5Azlvz45kdCxkGn4WRgQqOEj4MT55Q3ZzIpqXOihvEZBToZI2Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(38100700002)(6486002)(508600001)(6916009)(316002)(2616005)(54906003)(31686004)(2906002)(83380400001)(36756003)(8936002)(6506007)(26005)(66476007)(66946007)(6512007)(8676002)(186003)(4326008)(5660300002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUwxSisvR0VSYnhhOEFmR2ttWUlQUFBUTkdXZzhvSXI5MUtISTdRcjhvY1JR?= =?utf-8?B?Z0VwWmwzckxnZmdndW4zbFhXTU5wUXkwa3RaTEkzVHM2ZTNzUmVzQitpK3J0?= =?utf-8?B?UUNPUnAwVVFzWE80dDA0YXFsZlYxLzNYbHBnQkJVVWw1QjVrWG9SQjFuekg5?= =?utf-8?B?emprcWdFN1o2NWg4ejN0dVByV1p2cU9jTVVoLy9EMHo4djJjQzZlSnd4WmZ1?= =?utf-8?B?a3l5Mm1taTJleFdwcUdYczcvQk50QWlqZElKOTh4WFZQKzBrdFpzYkl3dFo2?= =?utf-8?B?dVpQUWE3bHNaNXhaelQ0Sk1aS2lXSVFROU5QNjM0ekFtd2w4YlNhOThTcWwr?= =?utf-8?B?QjVjellOZFlIeVJ1TDkvUUxJV015NWozazlIUUxCVnRlTWkzOFRVQVd0TVVG?= =?utf-8?B?eTRYNnhUOU1ZaXRhbEVYSnZqc1ZiVVRMUlc2amRWTEhEWmhLZjBRTjZ6UVVC?= =?utf-8?B?WE1nOHFNNUgxTWd3eEtmVjhqMnNHbzhzUlVxeWJEQTFmcEVvZW9tanMrMmtJ?= =?utf-8?B?ZFBwTW81UzJKcjV6Mmd1VFZ6RWNSeUdLbHhKRnIzNzBVTTFrazlKb0ZBOERC?= =?utf-8?B?OUtxVWxnZU5PdmR4enRsUXBJMEhwMjVUMjRKdWh0b1FWbHdMVklKWVBNdnlK?= =?utf-8?B?cnlvc1BGb3VmazBhcGNGbGlWa2JFUTFmd1VKdllIc1FYYzNVaE16VDZhNnEw?= =?utf-8?B?YlhnRGs5eUR3VHo1ZDV2Vk9BY2o1R2JKTjRSNWRldW1wZFlPZU9rSUJBdWhx?= =?utf-8?B?Sk9yc1hGOVJBendsVXVHRnNLTS9xbk1DL3QvdkhpK1hEOFFnbjREay9EZ2lm?= =?utf-8?B?YUNiKzF6VDZMZGJ1bkJ3ektyWWJkVzdsNHVzdW9EWE13Zlh0cUlLMks5S0Q5?= =?utf-8?B?U0o4aVVRSStRMnBxUXJ0UklZcUF4a2p0cTFFSW16Uk1BbjZTWWRadG1jUnBu?= =?utf-8?B?N3RZWHZ5bzdGcGdpQ0s1TWxLRllEVUlNWEloNXdXUHMrOWc3bVdOSG5LRkpB?= =?utf-8?B?WTNhRm1Sanh1ZER0NWxSTU9iQXg2UDJmVDA2aVExYUxaQkpPZ0J1RWVtSkRt?= =?utf-8?B?dkUvNkFYL2dHdnZEQnU1YWozaDBlOUlHbjgvVW5xYmhVR2tmdXV1ZGxLdEl1?= =?utf-8?B?NmtsRlZOWWo3d05vWU1SMldkWFdBZjBrOXEzdmdvNUdPQTBoUFUzSTQ2U2pB?= =?utf-8?B?SkpJVjl4NTZ4bWpMWkswUmtlZVZsdGc0T1BJdlRNYS9STmVtZlhNVk43eUFN?= =?utf-8?B?ZlVFamcrcGlsYVQ3YWVBQldhOTgwSHNrTDVUUy9MSk8zdGFDN01xMjV3cTEy?= =?utf-8?B?SnlpM0drL3JNYmRUVldzQjQwaVhFWkkzalBZOUtnZk9uWDhrR0lhZUF0UXRu?= =?utf-8?B?djhrQXZ1ZzRnZzFpSktadTc2OS9zeTA1QlFIWFpYakZvQWpKZ1NSUEFOODBs?= =?utf-8?B?Q2FHOWx0QlVtendZNFJjUjUxVUNBbFlpUHpoemZhaCsxN1JBQTdwb3IwNmor?= =?utf-8?B?LzkrT1llVHQxWnl4M01FUG1weUgzK1UvSlFHM2tSY3dVKzF5VzBtYTR5RU5h?= =?utf-8?B?S0U0OTY2Y3FmYzBSR1ZacnUyYWRTM3dLUDIwbnF5YnlheXlGblQzUmtXbUlM?= =?utf-8?B?WW1kOTFJOHY4RUVHZW1qdE10Q1hpZHIzM0RYalB5NEJNcEtMUTNkNjREQXZ5?= =?utf-8?B?K28wVkhMS21rVTdxNjFGT2ZsZlhkdXF1eXJlZzBqY09qbUlwN2s2NkhlRXdT?= =?utf-8?B?bmIwN0YzMGFOWE51T2FOcnpPNU9wR25aM3dVTzZrNEloY1VsVERCQlcrc1h4?= =?utf-8?B?VU9FblNUOTMrYUJQWjI3Uzk0VWo2NmdqMFVpd2I4WU9SY2VrMVY0Tnd2SGtt?= =?utf-8?B?TG1SaEY0RU9odFRjYnVoYkFYNklhRkZsb2E1WVBYcGJ3eXMraFJRTDhJMUFy?= =?utf-8?B?blFLK1l2UEpXblp0NUw5R2NSOXc5bkZoMWJjTXU5MTV6OGtGSzVsVTJtRTV5?= =?utf-8?B?Rnlic1Z5cTRPSFBkdWM5U3RMMy9EeUxzd1p0czZuelZtemR5Wnh4cUpOYUYz?= =?utf-8?B?U2hMbHN0OWNKTjNQSFpkTUNPU2hOQkNOWWYwMnhTdEJJcjNTRVN2ZUNPU2J2?= =?utf-8?B?WEZ4V2plZlcybHB0UFdaWTBwLzVBQjFUTEV6bWVkTGpwdlBQWmRNK1lVT1RL?= =?utf-8?B?NVY4UzZ4MDg4UUV4L3djRndRRWZWVzdhY3FVdmZIOVg5TXlEbWRYSlhHZXBm?= =?utf-8?B?UXRqenpBN3dqWklwOVNkcGlaSjNrTDg3RmYzQjljVnpMZTJPaVArM0k5bXpL?= =?utf-8?B?VFpUaDZ2S2g3RjBCNHZzRmJQV2k3bWVuQmJJcHcxcVpqZUpXY0tHUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd9b6c6-e2c0-4d65-7fe0-08da2c0abcda X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 07:09:45.7171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VcXfTR+LWzCE1gDUsNOxjIJaMbhtWA4isZBf823QLzoVIIECzVCPeSH8yB+OIywhTYwx2KDoCRKEwnH3KVCQYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7990 Support for this construct was added in 2.22 only. Avoid the need to introduce logic to probe for linker script capabilities by (ab)using the probe for a command line option having appeared at about the same time. Note that this remains x86-specific because Arm is unaffected, by requiring GNU ld 2.24 or newer. Fixes: 4b7fd8153ddf ("x86: fold sections in final binaries") Signed-off-by: Jan Beulich --- v3: Rebase over "kconfig: detect LD implementation". v2: Always define HAVE_LD_SORT_BY_INIT_PRIORITY when using LLVM ld. --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -73,6 +73,16 @@ ifeq ($(CONFIG_UBSAN),y) $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment) endif +ifeq ($(CONFIG_LD_IS_GNU),y) +# While not much better than going by raw GNU ld version, utilize that the +# feature we're after has appeared in the same release as the +# --print-output-format command line option. +AFLAGS-$(call ld-option,--print-output-format) += -DHAVE_LD_SORT_BY_INIT_PRIORITY +else +# Assume all versions of LLD support this. +AFLAGS += -DHAVE_LD_SORT_BY_INIT_PRIORITY +endif + ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y) efi-check := arch/x86/efi/check --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -36,6 +36,10 @@ ENTRY(start_pa) # define SECTION_ALIGN PAGE_SIZE #endif +#ifndef HAVE_LD_SORT_BY_INIT_PRIORITY +# define SORT_BY_INIT_PRIORITY SORT +#endif + OUTPUT_FORMAT(FORMAT, FORMAT, FORMAT) OUTPUT_ARCH(i386:x86-64) From xen-devel-bounces@lists.xenproject.org Mon May 02 07:12:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 07:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318669.538544 (Exim 4.92) (envelope-from ) id 1nlQEL-0003yF-1f; Mon, 02 May 2022 07:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318669.538544; Mon, 02 May 2022 07:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQEK-0003y8-V5; Mon, 02 May 2022 07:12:24 +0000 Received: by outflank-mailman (input) for mailman id 318669; Mon, 02 May 2022 07:12:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQEJ-0003y2-3k for xen-devel@lists.xenproject.org; Mon, 02 May 2022 07:12:23 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33200a80-c9e7-11ec-a405-831a346695d4; Mon, 02 May 2022 09:12:20 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1A4C75C0081; Mon, 2 May 2022 03:12:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 02 May 2022 03:12:17 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 May 2022 03:12:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33200a80-c9e7-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651475537; x= 1651561937; bh=33kj1yz/7azvZAf+9mpwSINfwefGQvvGDl74Mhrx8J4=; b=N On/+KjOeyubXyroc79W8qMAR6Zj7xTkaENf5LVvb9QMyF19FVWtImMyroI7m7n8W HX8LYC44yxWtgFW33rYDJb/axmb4LZpUhL+SataBU1REH2wlwfyB8qg8zDCiE2tO WcE/nF+fefSXWKA3WeHe884zC7GBjXQ7HPi7HHuEl+HQdshIzXKlGXk2dzBpReK6 oDWKOK9m3Tb3z0o4JaTRuQCWp2QE23/7BpzNVV5VIYWk9P4pkGm8S3plVST6OFnQ z1kQjaPQrYOzhXEzO5D/1wlBsQ8G57wn59b2ykVY8wD6vfn8u8XxK06sV6lpVEet xS42rgMSjK/CgGTqgMKzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeggdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Date: Mon, 2 May 2022 03:11:47 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT Message-ID: References: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com> <7ad22939-1096-3d81-f998-4eaf1d9a1d8e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+Mf4dSxtIGCKe9It" Content-Disposition: inline In-Reply-To: <7ad22939-1096-3d81-f998-4eaf1d9a1d8e@suse.com> --+Mf4dSxtIGCKe9It Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 2 May 2022 03:11:47 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT On Mon, May 02, 2022 at 08:24:30AM +0200, Jan Beulich wrote: > On 29.04.2022 19:06, Demi Marie Obenour wrote: > > On Fri, Apr 29, 2022 at 10:40:42AM +0200, Jan Beulich wrote: > >> On 29.04.2022 00:54, Demi Marie Obenour wrote: > >>> On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote: > >>>> On 27.04.2022 21:08, Demi Marie Obenour wrote: > >>>>> On further thought, I think the hypercall approach is actually bett= er > >>>>> than reserving the ESRT. I really do not want XEN_FW_EFI_MEM_INFO = to > >>>>> return anything other than the actual firmware-provided memory > >>>>> information, and the current approach seems to require more and more > >>>>> special-casing of the ESRT, not to mention potentially wasting memo= ry > >>>>> and splitting a potentially large memory region into two smaller on= es. > >>>>> By copying the entire ESRT into memory owned by Xen, the logic beco= mes > >>>>> significantly simpler on both the Xen and dom0 sides. > >>>> > >>>> I actually did consider the option of making a private copy when you= did > >>>> send the initial version of this, but I'm not convinced this simplif= ies > >>>> things from a kernel perspective: They'd now need to discover the ta= ble > >>>> by some entirely different means. In Linux at least such divergence > >>>> "just for Xen" hasn't been liked in the past. > >>>> > >>>> There's also the question of how to propagate the information across > >>>> kexec. But I guess that question exists even outside of Xen, with the > >>>> area living in memory which the OS is expected to recycle. > >>> > >>> Indeed it does. A simple rule might be, =E2=80=9COnly trust the ESRT= if it is > >>> in memory of type EfiRuntimeServicesData.=E2=80=9D That is easy to a= chieve by > >>> monkeypatching the config table as you suggested below. > >>> > >>> I *am* worried that the config table might be mapped read-only on some > >>> systems, in which case the overwrite would cause a fatal page fault. = Is > >>> there a way for Xen to check for this? > >> > >> While in boot mode, aiui page tables aren't supposed to be enforcing > >> access restrictions. Recall that on other architectures EFI even runs > >> with paging disabled; this simply is not possible for x86-64. > >=20 > > Yikes! No wonder firmware has nonexistent exploit mitigations. They > > really ought to start porting UEFI to Rust, with ASLR, NX, stack > > canaries, a hardened allocator, and support for de-priviliged services > > that run in user mode. > >=20 > > That reminds me: Can Xen itself run from ROM? >=20 > I guess that could be possible in principle, but would certainly require > some work. >=20 > > Xen is being ported to > > POWER for use in Qubes OS, and one approach under consideration is to > > have Xen and a mini-dom0 be part of the firmware. Personally, I really > > like this approach, as it makes untrusted storage domains much simpler. > > If this should be a separate email thread, let me know. >=20 > It probably should be. I will make one at some point. > >> So > >> portable firmware shouldn't map anything r/o. In principle the pointer > >> could still be in ROM; I consider this unlikely, but we could check > >> for that (just like we could do a page table walk to figure out > >> whether a r/o mapping would prevent us from updating the field). > >=20 > > Is there a utility function that could be used for this? >=20 > I don't think there is. Then it is good that none is necessary :) Also, should the various bug checks I added be replaced by ASSERT()? > >>> It could also be undefined behavior to modify it. > >> > >> That's the bigger worry I have. > >=20 > > Turns out that it is *not* undefined behavior, so long as > > ExitBootServices() has not been called. This is becaues EFI drivers > > will modify the config table, so firmware cannot assume it to be > > read-only. >=20 > Ah, right - we could even use InstallConfigurationTable() ourselves > to make the adjustment. That is even simpler than I thought! I was worried that InstallConfigurationTable() would assume that memory for the table was allocated a certain way and cause invalid free errors, but at least TianoCore does not do that. > >>>>> Is using ebmalloc() to allocate a copy of the ESRT a reasonable opt= ion? > >>>> > >>>> I'd suggest to try hard to avoid ebmalloc(). It ought to be possible= to > >>>> make the copy before ExitBootServices(), via normal EFI allocation. = If > >>>> replacing a pointer in the config table was okay(ish), this could ev= en > >>>> be utilized to overcome the kexec problem. > >>> > >>> What type should I use for the allocation? EfiLoaderData looks like = the > >>> most consistent choice, but I am not sure if memory so allocated rema= ins > >>> valid when Xen hands off to the OS, so EfiRuntimeServicesData might b= e a > >>> better choice. > >> > >> It definitely is. We do recycle EfiLoaderData ourselves. > >=20 > > I wonder why the ESRT was not in EfiRuntimeServicesData to begin with. >=20 > So do I. I suspect the assumption was that the ESRT would be parsed by the OS before ExitBootServices(), and that the OS would have no need for the ESRT after that. > >>> To avoid memory leaks from repeated kexec(), this could > >>> be made conditional on the ESRT not being in memory of type > >>> EfiRuntimeServicesData to begin with. > >> > >> Of course - there's no point relocating the blob when it already is > >> immune to recycling. > >=20 > > Yup. Is it reasonable for dom0 to check that the ESRT is in > > EfiRuntimeServicesData when under Xen? >=20 > I think it is, but kernel folks may not like Xen specific code in this > (or about any) area. >=20 > Jan There is PVops et al already :) --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --+Mf4dSxtIGCKe9It Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJvhE4ACgkQsoi1X/+c IsGZ4g/+I8z97HEpZDgZIFYF6223IL8bc4xLxtq+5ULmvzWrgPSGU3P/pXoU/q0x aEOKJnJxSrxAvQ14sdaeaq+VGrRTPXmcCys9hRkJ9q9njGvQsmHxsGae/RgfobaX jpodeN8cCdlfIvmiKp3YbDpUvH0YUqcd8qhlitzd9NgxefNO/7q8wS0FvXhIA3HW SLe83KzkPYMfkSyNwqsONkOPkVJP2he6jks1FXvwwOU9ltL1NAif7gHmCJOInJOd Q/7RNT0QiSk7mjwpAiIW/gqNN8TOz6R0hy/G6oru2HsWm7b8SLaIqW1s3Xvyy6Xi IPcn4H819nfl3lDQMRvALvfMVTSZItN7vA1RY7C195n6TooEFl7jdnH2TT8KP0HT 4MhzNQoLbiIjFMvXPgjq2MF35y22hk+yuyB8lsMlZNcG1Z0fAWCYUO1H+MjIz3Jy 9g9/JlqabcgxT9wVC28rvS2BD6W+3XR5iF0d1VRPj+CF+XUs3xWHmb9SxQLNHKDN RKhz/5ZaE7v39dl9rayNyf4Csfko3RSDv7jpBUca03r5Xj8K61x+Iak8PLAhLq+c atsdqYWkGSawtSsH3JTTSyWXgEcoNAyFM6RF/7+sfUY91QGaawI35EFMOLIApb7J DVKk5Vg4edAh/nkObFT5vExrCevGO3rq4devw1HxVlXlVMbn+jE= =mCXO -----END PGP SIGNATURE----- --+Mf4dSxtIGCKe9It-- From xen-devel-bounces@lists.xenproject.org Mon May 02 07:20:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 07:20:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318678.538555 (Exim 4.92) (envelope-from ) id 1nlQMD-0005PL-Ri; Mon, 02 May 2022 07:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318678.538555; Mon, 02 May 2022 07:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQMD-0005PE-Ob; Mon, 02 May 2022 07:20:33 +0000 Received: by outflank-mailman (input) for mailman id 318678; Mon, 02 May 2022 07:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQMC-0005P4-I7; Mon, 02 May 2022 07:20:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQMC-00036f-FZ; Mon, 02 May 2022 07:20:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQMB-0004z7-Vu; Mon, 02 May 2022 07:20:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlQMB-0001i9-VU; Mon, 02 May 2022 07:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+QaZHCJsaQgmJb9gE70H+dEGbqTvCYiH0eF2mAFL7Ew=; b=peStwiDynZPvD6cdvC+Yj4wcHC nTERqpYkeS8qLBfKPP4aWODy0S5TJ5HI6SMKJUOk2mPG0cd8vOZvvoOB9822P4bSxgbkZlmP63G4m fCdI0Pt19kqod0UsC5nDmG0zge0malEUqYkBrYGDtU1BOI38w0XKFb8qLba5lJBKB/us=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169981: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 07:20:31 +0000 flight 169981 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169981/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 754 attempts Testing same since 169904 2022-04-30 08:10:33 Z 1 days 46 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 07:37:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 07:37:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318687.538566 (Exim 4.92) (envelope-from ) id 1nlQcq-0007EN-Em; Mon, 02 May 2022 07:37:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318687.538566; Mon, 02 May 2022 07:37:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQcq-0007EG-Bk; Mon, 02 May 2022 07:37:44 +0000 Received: by outflank-mailman (input) for mailman id 318687; Mon, 02 May 2022 07:37:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQcp-0007EA-Ni for xen-devel@lists.xenproject.org; Mon, 02 May 2022 07:37:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c01922ce-c9ea-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 09:37:42 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-4HEFWyyRNDeAl62HJ0Fcaw-1; Mon, 02 May 2022 09:37:39 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PA4PR04MB9487.eurprd04.prod.outlook.com (2603:10a6:102:27c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 2 May 2022 07:37:38 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 07:37:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c01922ce-c9ea-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651477062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9U80lYDRJxrrSIoI2s6OuL5i+2UezngJMNv3lyNou9E=; b=ez/KPtsJPf6GoOos3PpxYhen7S2EGYg9/brfevv5XojuLxSYP429DxSeJ2mTNM2XglhsLf 5hW0qQJp0aC5KfyMogPgcVc8fYk/tOXj3gtMwiH7jULA4l4AyR3KMiex3IFjyJ+RwxsiGt nWTostjqc3MvQBWJ7Xz2SXTHzyQ3vis= X-MC-Unique: 4HEFWyyRNDeAl62HJ0Fcaw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GCndXWO3vXR2kbWjpnu6GNde8XR/r6g0qr6YTdIxmWP39mT373zLCPQ0KJu9cYM1xiw8Uws+5E0M5BTAbrziswLXUlN+4aDQ1aGHmpbt4YiQ7S2KQOvITDsEhKQUPpOuzkVEzZk3mLMZFC0xiRasqFk+ofMNlaEraJC425TNKtMHh50ThNj2J3odBx8EcLbwo+0aBSLzGowsGFLh5pz+QfIg0EizGidREz8y9kQe452u6qZ5NeKJpIg5hfCAKQ6VprD7g+ZuAIbKJzZuXB+MAP4+Wz/0zbbBNtOjsCZ9OU47t1i3xHfHSsgNsywW4EdfFgS9dbF1mANWr1S536LQow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9lO1qkyybnjDj9mtZrOKLsdIU1hr3VAD53KczCI1W4=; b=ZIi4FkFA8Qn11ZgCnxODqoo+JIpKweSCa7LAxscAD7fSEF6fdbUm3fVhr9RHJpnXE/+UNxLQpCam27JvBK3x2inQLtMSq383lqx2RWQuC2wzfrWU39Ih9vSfbojoA0RYuxeAQfcCZDJaymO6zY7Uk1kEcOYhoTe/o4mDCFux9d2S9oiejz2ox2ieb8RrR5SYVEoVRtAcqrIYQo6ZZIIjmXSW73I2uKcKpL6mmZOQoFAbdsafORgvlPqBSZCEofvLaEcft4hsuyvq8q/pmd4uJAYeoZ1Y5a5SRp0KVFjcOgLxvkmicy34kVixk/h0oml0j00OEn8tGxnf6YLmcEW2fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 2 May 2022 09:37:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT Content-Language: en-US To: Demi Marie Obenour CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com> <7ad22939-1096-3d81-f998-4eaf1d9a1d8e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0406.eurprd06.prod.outlook.com (2603:10a6:20b:461::16) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74e1dbdd-5aea-469a-ab5e-08da2c0ea1bc X-MS-TrafficTypeDiagnostic: PA4PR04MB9487:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jZmfp2jRoXKdlFENwZ94U2khWJKXDhweXsgA4s/6gBH48B4/+s5I1nK1YiIHY5aPNlAJC3dXBWoLjCp5M6OU2CeBUzfNW93axVfofZOb2De31sZ8IDSSTiNv57/00UmV6O9w5VTYydQos3vmCya7yGWLpvcbdykQQrXgJ8UArXllP27s+WReoJ4IZo/0vDvF33lDXwg6H+JWNaQ/5i4rD6r3esIpWaEjZ/Ej1dH+1+MBpP/MMvC52XH8Qtt42M9a+wHnQzvFg7m2ItxFN0YMfOB5RJebiBjMlFDE54zTMiJEWTvbrOioMqx8CN75tuUmuwNrFzTw26IeWjOx3JIDb218m45BQz8inJO++1vPl4mnyhshWZkjuius5W4wdRCJlrDH5+EN7ORBVdVFVAh3jLr9ew1QGwRfnMIxKRbkVyT5GWdF+5S1+qthw8uw6OFs3Xr83wmHekvUBS7i8mP+m6GslJt3rZu47+Tjt8AL+qa1DNzBgqtILDENwIGWiSUNEHmaCLYhZUHbMOIasmcr7IuYGChjSvD17gsZnPySGN5ZKNOr7IxYCxbG3hr9mJPiFnLCZmG41KdY1o2GSy4SUEprUZrByN88PZhNEio6JwSrrgNtVxpcTDr9HDr9mqKU5EtRaEdn3LU41HaTql1qtet9ZwWB6JC70sgrmRaBQ6hKT9k8SvHQpNH8Gc6ABHl6EZpUUsFNxSePqNpMatJpmJqyy4CbuMOK+5IqJQsYjq6LH0BOzSHlkH+FAeLP0G1olyOlobolWlWiLhTcuQCb7w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(53546011)(508600001)(31696002)(186003)(38100700002)(316002)(66556008)(66476007)(8676002)(66946007)(31686004)(4326008)(83380400001)(26005)(6506007)(2616005)(6512007)(36756003)(2906002)(86362001)(8936002)(5660300002)(6486002)(15583001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?phBzqM5A8hoSBBJY/89VYnTjqa+Rq5MvQXowvt4pZJ2KGUXlT1iWuaQmFoyQ?= =?us-ascii?Q?S+fIbEVlb0Ycw+x3az6wk6FBtx2/M8zmGl9bkQ0TZKcqgrFHTGaOboj7TzM5?= =?us-ascii?Q?ioSgXNL0032cq0WGWVby957UMZH1vxF+aKpZEpwX6H97a55FWUGAI+R+F34r?= =?us-ascii?Q?kMvRYqBQ45eNUs/8yVCiFR+q3gxgNkrQuRnCwklyZTU16d5cbgbks1NAJpNK?= =?us-ascii?Q?ZRMOW2LPIaqgPCRM2SRR/A9mpocxG3bSLv4UuiS5ItNtwlCumpema54KJ+lL?= =?us-ascii?Q?Z1WqGCFFaUKZiiNtjbtTyPZ1jZsUevOFt32zMGKg1+IWSyMYsrQvpTaHJej0?= =?us-ascii?Q?tFW/vHS0QmhSOdTGJTIMPwpjWpTfPIcX6j9TbZ96GTyVUDZxo0AoF4O8uOVB?= =?us-ascii?Q?eYWBEXsJLdiWBi2KDSd1FdVu8Fpu8cRy/u9GoZruyhC6KCxCvJZHm6v+NyYD?= =?us-ascii?Q?hxk3/hfi+k+mcoSgSmm0NE06WuW381x18R5rDdxDykxX5AcXEECXgCRA5lFX?= =?us-ascii?Q?fuR7yIMi6prR398QTv+leb8BR2oNGgeDixkOTiVvRBCreWTN5Pm54nBkWz9l?= =?us-ascii?Q?LRhUlce2GH1+Aefzu/oOCUpcDhRp2kzfbNbr0kbM06m9IN8Y3g8G0QE3rvC0?= =?us-ascii?Q?z603W2SI85RxAySnqp4MMH7drV/1TcyocPZLuQzKNQFFMMoutSmJZQo4zDCE?= =?us-ascii?Q?0PNlUXnG+MNQfE7DCYPi96DCusuSn6wTQA7xNd3hyDATSbJKFoAzJx+DAk+C?= =?us-ascii?Q?gplic3glUUCVdTP54V1gdi4nN2aJaNkLn11iAVH+//BJR6rjJfSqwlo7Y+Su?= =?us-ascii?Q?Gj47jPoEHm7ItXoSlvtjZVjJLJHGBlOk8KM/gU3JlBm0rxch+VRvh13rL+yV?= =?us-ascii?Q?n8J1PWVQsan0hSpjX7EPkq5O9pL7h3a4nBNnJS0RXIq3gDIsJCuI6npvzkrd?= =?us-ascii?Q?1N8NXI9z1ee/lKfQ8VBFOAcGEEmRscd9+GOTR81kfRsg7Rdu238qy/i4GMGS?= =?us-ascii?Q?ZMDLi54foJH49sAtEocr7XvI7JBqj8ycA2dOtypEI71V3TjQOk8z1OlmIKg4?= =?us-ascii?Q?CVDEPdfnWYrq7yLW3V2DqmwaJmyXQVko4WGLwvy3wX7IGDRd4bvGgeFmQunN?= =?us-ascii?Q?h2HO+LOU7bXkQ1z6n7RqrTtjGQeGJOyUpIvg8/XhqoBSrgbQ6gzWsKg3PhML?= =?us-ascii?Q?pCPYV5m2C4FHYJmCPPm70Gj+HOybu8Y2a2eVYJAU1Elp2wsDPt9cEcA+x+VB?= =?us-ascii?Q?vA7ZbJZfW0j4PvJWIbCvS8UvBKTpgITTR5tdGAPiRhlOy4jz2RL1B7CddBgt?= =?us-ascii?Q?RFx7ntGYGwEOkK8KzVGDGCsrYa37xtf1FK3VBrj18vSCNzSuJ55TBeSBIZ6b?= =?us-ascii?Q?RlKpsty2Onu3W+Ac9zOIRhjo8sXmIV5VwxyBPFxTlGfQxI2dgeArOHMpogfo?= =?us-ascii?Q?xvObhD0Txu+RjEplu1np6CrPslLKxZd39bDcnnqS1SDpmGmGF3WRrUN0jupY?= =?us-ascii?Q?rud98eGcxFoONNpTeIQ50FZ4AiS8DwTER9X5Wxw/+uln9RpUkVci9HbHDmUG?= =?us-ascii?Q?iUGFezFFe3T3qArCDsHdB1udMCZS8c4pSef15cCHy7x8QpjrQArM+ZEGIl8V?= =?us-ascii?Q?3zrK/bmtxiyxGDJ9NbcK2dXeD6QETafKN3LUGOcgDBx2RIwU1Pqqi1ebTl7P?= =?us-ascii?Q?dAQE7egntzjiCcoK//jopnqhPgVUuEEMqapeX7IHzEW7i1S4WifZn/7R2eVU?= =?us-ascii?Q?7kN3al1NBw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74e1dbdd-5aea-469a-ab5e-08da2c0ea1bc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 07:37:38.2256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tvhBbLOLOHPQhnbqi7CCtexUXiLP2fyc+VV0lI/SbdisH1xxUZgxOXF7mWhcINzOV5AcjiMHGSCib6j85sKDQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9487 On 02.05.2022 09:11, Demi Marie Obenour wrote: > On Mon, May 02, 2022 at 08:24:30AM +0200, Jan Beulich wrote: >> On 29.04.2022 19:06, Demi Marie Obenour wrote: >>> On Fri, Apr 29, 2022 at 10:40:42AM +0200, Jan Beulich wrote: >>>> On 29.04.2022 00:54, Demi Marie Obenour wrote: >>>>> On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote: >>>>>> On 27.04.2022 21:08, Demi Marie Obenour wrote: >>>>>>> On further thought, I think the hypercall approach is actually bett= er >>>>>>> than reserving the ESRT. I really do not want XEN_FW_EFI_MEM_INFO = to >>>>>>> return anything other than the actual firmware-provided memory >>>>>>> information, and the current approach seems to require more and mor= e >>>>>>> special-casing of the ESRT, not to mention potentially wasting memo= ry >>>>>>> and splitting a potentially large memory region into two smaller on= es. >>>>>>> By copying the entire ESRT into memory owned by Xen, the logic beco= mes >>>>>>> significantly simpler on both the Xen and dom0 sides. >>>>>> >>>>>> I actually did consider the option of making a private copy when you= did >>>>>> send the initial version of this, but I'm not convinced this simplif= ies >>>>>> things from a kernel perspective: They'd now need to discover the ta= ble >>>>>> by some entirely different means. In Linux at least such divergence >>>>>> "just for Xen" hasn't been liked in the past. >>>>>> >>>>>> There's also the question of how to propagate the information across >>>>>> kexec. But I guess that question exists even outside of Xen, with th= e >>>>>> area living in memory which the OS is expected to recycle. >>>>> >>>>> Indeed it does. A simple rule might be, =E2=80=9COnly trust the ESRT= if it is >>>>> in memory of type EfiRuntimeServicesData.=E2=80=9D That is easy to a= chieve by >>>>> monkeypatching the config table as you suggested below. >>>>> >>>>> I *am* worried that the config table might be mapped read-only on som= e >>>>> systems, in which case the overwrite would cause a fatal page fault. = Is >>>>> there a way for Xen to check for this? >>>> >>>> While in boot mode, aiui page tables aren't supposed to be enforcing >>>> access restrictions. Recall that on other architectures EFI even runs >>>> with paging disabled; this simply is not possible for x86-64. >>> >>> Yikes! No wonder firmware has nonexistent exploit mitigations. They >>> really ought to start porting UEFI to Rust, with ASLR, NX, stack >>> canaries, a hardened allocator, and support for de-priviliged services >>> that run in user mode. >>> >>> That reminds me: Can Xen itself run from ROM? >> >> I guess that could be possible in principle, but would certainly require >> some work. >> >>> Xen is being ported to >>> POWER for use in Qubes OS, and one approach under consideration is to >>> have Xen and a mini-dom0 be part of the firmware. Personally, I really >>> like this approach, as it makes untrusted storage domains much simpler. >>> If this should be a separate email thread, let me know. >> >> It probably should be. >=20 > I will make one at some point. >=20 >>>> So >>>> portable firmware shouldn't map anything r/o. In principle the pointer >>>> could still be in ROM; I consider this unlikely, but we could check >>>> for that (just like we could do a page table walk to figure out >>>> whether a r/o mapping would prevent us from updating the field). >>> >>> Is there a utility function that could be used for this? >> >> I don't think there is. >=20 > Then it is good that none is necessary :) >=20 > Also, should the various bug checks I added be replaced by ASSERT()? You mean those in the earlier patch(es)? Not sure - depends on what you would be doing for release builds. In the cases where you simply re- check what was checked earlier on, ASSERT() would probably indeed be preferable over BUG_ON() (and there I wouldn't even see a strong need to consider alternatives for release builds). Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 07:43:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 07:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318693.538577 (Exim 4.92) (envelope-from ) id 1nlQi4-0000HO-3b; Mon, 02 May 2022 07:43:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318693.538577; Mon, 02 May 2022 07:43:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQi3-0000HH-W4; Mon, 02 May 2022 07:43:07 +0000 Received: by outflank-mailman (input) for mailman id 318693; Mon, 02 May 2022 07:43:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlQi3-0000HB-4U for xen-devel@lists.xenproject.org; Mon, 02 May 2022 07:43:07 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8055b247-c9eb-11ec-a405-831a346695d4; Mon, 02 May 2022 09:43:05 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C290A5C0037; Mon, 2 May 2022 03:43:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 02 May 2022 03:43:04 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 May 2022 03:43:03 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8055b247-c9eb-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651477384; x= 1651563784; bh=CVZC41679sufgTHuZhnba1pii/ZlnBhhFJAQJ0LBsbo=; b=W v4z+VyphOWClGyt3DebUzHzFJ2WYyEOO5z0VzVwrJYMFBO5ax/pdhTEyPWcqhZOn O3tbKEqcKqJr0DoAb0Byn085JgcHj5MCu9QhsYb7QrsIhJK50TrMvY1H1PNjn7Oz L9XFUj6Gyk9QoVpqffSUZw3+jOOQ8nAvfvniKbBZGuEqJAbaSMalENehvQAr+Fv3 5+VqjhVRy+axnOTUpmgqZRL95zKDK9X73JP42zdhFUB7rTPSuSTzBE/blhbbEWWK 1JxX1tqYGBfUWVN3JrYTCVaMWw2CAklSMY1h2RRIg3X9wk3X2eSrzym/H9Pd+wFN iH0XD1FKtpuDiximBf3/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeggdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Date: Mon, 2 May 2022 03:42:34 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT Message-ID: References: <3591eec7-1299-8783-26ad-ffe27bb9fdcd@suse.com> <901c11d6-92f0-89b9-8500-4947bbdcd504@suse.com> <7ad22939-1096-3d81-f998-4eaf1d9a1d8e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ErhdjAcdLt8FbP+3" Content-Disposition: inline In-Reply-To: --ErhdjAcdLt8FbP+3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 2 May 2022 03:42:34 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH v3 3/4] Add a new hypercall to get the ESRT On Mon, May 02, 2022 at 09:37:39AM +0200, Jan Beulich wrote: > On 02.05.2022 09:11, Demi Marie Obenour wrote: > > On Mon, May 02, 2022 at 08:24:30AM +0200, Jan Beulich wrote: > >> On 29.04.2022 19:06, Demi Marie Obenour wrote: > >>> On Fri, Apr 29, 2022 at 10:40:42AM +0200, Jan Beulich wrote: > >>>> On 29.04.2022 00:54, Demi Marie Obenour wrote: > >>>>> On Thu, Apr 28, 2022 at 08:47:49AM +0200, Jan Beulich wrote: > >>>>>> On 27.04.2022 21:08, Demi Marie Obenour wrote: > >>>>>>> On further thought, I think the hypercall approach is actually be= tter > >>>>>>> than reserving the ESRT. I really do not want XEN_FW_EFI_MEM_INF= O to > >>>>>>> return anything other than the actual firmware-provided memory > >>>>>>> information, and the current approach seems to require more and m= ore > >>>>>>> special-casing of the ESRT, not to mention potentially wasting me= mory > >>>>>>> and splitting a potentially large memory region into two smaller = ones. > >>>>>>> By copying the entire ESRT into memory owned by Xen, the logic be= comes > >>>>>>> significantly simpler on both the Xen and dom0 sides. > >>>>>> > >>>>>> I actually did consider the option of making a private copy when y= ou did > >>>>>> send the initial version of this, but I'm not convinced this simpl= ifies > >>>>>> things from a kernel perspective: They'd now need to discover the = table > >>>>>> by some entirely different means. In Linux at least such divergence > >>>>>> "just for Xen" hasn't been liked in the past. > >>>>>> > >>>>>> There's also the question of how to propagate the information acro= ss > >>>>>> kexec. But I guess that question exists even outside of Xen, with = the > >>>>>> area living in memory which the OS is expected to recycle. > >>>>> > >>>>> Indeed it does. A simple rule might be, =E2=80=9COnly trust the ES= RT if it is > >>>>> in memory of type EfiRuntimeServicesData.=E2=80=9D That is easy to= achieve by > >>>>> monkeypatching the config table as you suggested below. > >>>>> > >>>>> I *am* worried that the config table might be mapped read-only on s= ome > >>>>> systems, in which case the overwrite would cause a fatal page fault= =2E Is > >>>>> there a way for Xen to check for this? > >>>> > >>>> While in boot mode, aiui page tables aren't supposed to be enforcing > >>>> access restrictions. Recall that on other architectures EFI even runs > >>>> with paging disabled; this simply is not possible for x86-64. > >>> > >>> Yikes! No wonder firmware has nonexistent exploit mitigations. They > >>> really ought to start porting UEFI to Rust, with ASLR, NX, stack > >>> canaries, a hardened allocator, and support for de-priviliged services > >>> that run in user mode. > >>> > >>> That reminds me: Can Xen itself run from ROM? > >> > >> I guess that could be possible in principle, but would certainly requi= re > >> some work. > >> > >>> Xen is being ported to > >>> POWER for use in Qubes OS, and one approach under consideration is to > >>> have Xen and a mini-dom0 be part of the firmware. Personally, I real= ly > >>> like this approach, as it makes untrusted storage domains much simple= r. > >>> If this should be a separate email thread, let me know. > >> > >> It probably should be. > >=20 > > I will make one at some point. > >=20 > >>>> So > >>>> portable firmware shouldn't map anything r/o. In principle the point= er > >>>> could still be in ROM; I consider this unlikely, but we could check > >>>> for that (just like we could do a page table walk to figure out > >>>> whether a r/o mapping would prevent us from updating the field). > >>> > >>> Is there a utility function that could be used for this? > >> > >> I don't think there is. > >=20 > > Then it is good that none is necessary :) > >=20 > > Also, should the various bug checks I added be replaced by ASSERT()? >=20 > You mean those in the earlier patch(es)? Not sure - depends on what you > would be doing for release builds. In the cases where you simply re- > check what was checked earlier on, ASSERT() would probably indeed be > preferable over BUG_ON() (and there I wouldn't even see a strong need > to consider alternatives for release builds). Yup, that=E2=80=99s what the BUG_ON()s were for. I will use ASSERT() in the next round. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --ErhdjAcdLt8FbP+3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJvi4YACgkQsoi1X/+c IsECqA/9GiH7nC7Z+pWICgSsyo8Uqu0axtawLWSdCQXZjpMbighA5imVwkfOCJ+b /XXRINSP7BUGZcLClCFA/kj5Efxlrs4oPc08UR9KgjClNu4dHarfBLaOOJNZGtca b8J+9MmqESXqA+EPfxyGZmWgKarhOGuH3kBUt/Aum6Z89i5oPRfJGdgJ+T5WYBEQ oSkOXyLLWtjMkMdVVo1yFXJeHsfuiPQ/Z6SRhtP71dFGWaJ724taQkKGtTX71WgI W+rcnn96WGXAK/P1rbbNe4c8SWUjsfjghEK1JymsYm4sqBmb7uqJlAjHvZ9G56cM dve2ADBsBXmyr+inLAI/dd09S5E8mp/W1x2/DAeG5eYaiWpMwQrXqxKWqilTsmrQ STQGKSBplLxfrz4eOBS0mlil4EKwiSlsKw+O8Da0SFRBVHvAm1FN9ht2hA++iz8T Cqzw7IEceMvMi9k/xVScZFhTBhVZLoc54xx/9ql+pSep+Gek4vsjJ3fQhhLGE4ey Z9xsS71MLyiIf1lvhzF9TnjLDucpwUwmjxVVEZ5/N0ZncMdwTw6h40J4YN3dnhOq U1a3XKQcYG4xGzrtHTITgJn2BIgVHm6SkxsOGTzK9e1mrz/afG0M8moRg0nTL9aR 77QFCssKQN3luLW5XpptPQgk+RNJUrLuuD5hSrVuDuB7A3w08WI= =KXoF -----END PGP SIGNATURE----- --ErhdjAcdLt8FbP+3-- From xen-devel-bounces@lists.xenproject.org Mon May 02 08:16:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 08:16:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318709.538588 (Exim 4.92) (envelope-from ) id 1nlREY-0004Oo-0s; Mon, 02 May 2022 08:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318709.538588; Mon, 02 May 2022 08:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlREX-0004Oh-Sl; Mon, 02 May 2022 08:16:41 +0000 Received: by outflank-mailman (input) for mailman id 318709; Mon, 02 May 2022 08:16:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlREW-0004Ob-RA for xen-devel@lists.xenproject.org; Mon, 02 May 2022 08:16:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30a896ad-c9f0-11ec-a405-831a346695d4; Mon, 02 May 2022 10:16:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 720C821875; Mon, 2 May 2022 08:16:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53776133E5; Mon, 2 May 2022 08:16:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9uHUEmaTb2LtCQAAMHmgww (envelope-from ); Mon, 02 May 2022 08:16:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30a896ad-c9f0-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651479398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IF+3AJIM0IxkoS8t8/wdvKQZ/o940JqAYrDGMNmIRm0=; b=io0oXThM+7m846VH5aHlIHPE2eH//ZGESBl1FpSoM//aCuE3JrsRzA2FP63a/eih1uTLu6 qqEAzFVDl7fFmkLp2JMgnevWS/fY9FcNteOf0Hr8w2TRwbOsgjYJN0C+gT7OJmdUjmCz0o 4crw5mKZeyZsAOqBmESFQzFsQgspm5o= Message-ID: <41385694-fd4f-f6e6-190b-48cde8f77fd4@suse.com> Date: Mon, 2 May 2022 10:16:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] tools/libs/light: update xenstore entry when setting max domain memory Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20220420080426.7036-1-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------wgAT6AxEVamKLTDTp00pz0us" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------wgAT6AxEVamKLTDTp00pz0us Content-Type: multipart/mixed; boundary="------------7TTMzo8JvJab1mTka28bZ9SM"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: <41385694-fd4f-f6e6-190b-48cde8f77fd4@suse.com> Subject: Re: [PATCH v2] tools/libs/light: update xenstore entry when setting max domain memory References: <20220420080426.7036-1-jgross@suse.com> In-Reply-To: --------------7TTMzo8JvJab1mTka28bZ9SM Content-Type: multipart/mixed; boundary="------------kYzkUR4Dfd50HPS7wHMIkuIB" --------------kYzkUR4Dfd50HPS7wHMIkuIB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMTY6NTIsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBXZWQsIEFw ciAyMCwgMjAyMiBhdCAxMDowNDoyNkFNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4gbGlieGxfZG9tYWluX3NldG1heG1lbSgpIGNhbGxlZCBkdXJpbmcgInhsIG1lbS1tYXgi IHNob3VsZCB1cGRhdGUgdGhlDQo+PiBkb21haW4ncyBtZW1vcnkvc3RhdGljLW1heCBYZW5z dG9yZSBub2RlLCBhcyBvdGhlcndpc2UgInhsIG1lbS1zZXQiDQo+PiB3b24ndCBiZSBhYmxl IHRvIHNldCB0aGUgbWVtb3J5IHNpemUgdG8gdGhlIG5ldyBtYXhpbXVtLg0KPiANCj4gU2V0 dGluZyBkb21haW4ncyBtZW1vcnkgaGlnaGVyIHRoYW4gdGhlIG9yaWdpbmFsIG1lbS1tYXgg b25seSB3b3JrcyBvbg0KPiBQViBhbmQgbWF5YmUgUFZIIGd1ZXN0LCByaWdodD8gQmVjYXVz ZSBvbiBIVk0sIFFFTVUgaXMgdG9sZCBhYm91dA0KPiBtYXhtZW0gd2hlbiBzdGFydGluZyBh IGd1ZXN0LCBhbmQgYWxsb2NhdGVzIHNvbWUgc3R1ZmYgZnJvbSB0aGlzIGFkZHJlc3MNCj4g KHZnYSBidWZmZXIsIHBjaSByb20gSSB0aGluaykgc28gdHJ5aW5nIHRvIGdpdmUgSFZNIGd1 ZXN0IG1vcmUgbWVtb3J5DQo+IGFmdGVyIHRoZSBmYWN0IGlzIHByb2JhYmx5IG5vdCBnb2lu ZyB0byBnbyBzbW9vdGhseS4NCg0KV29ya3Mgd2l0aG91dCBhIHByb2JsZW0uDQoNClRoaXMg YXJlYSBpcyBtYXJrZWQgaW4gdGhlIGU4MjAgbWVtb3J5IG1hcCwgc28gdGhlIGd1ZXN0IHdv bid0IHVzZSBpdCB0bw0KYWRkIG1lbW9yeS4NCg0KPiANCj4+IEFkanVzdCB0aGUgcmVsYXRl ZCBjb21tZW50cyBhbmQgZG9jdW1lbnRhdGlvbiBhY2NvcmRpbmdseS4NCj4+DQo+PiBTaWdu ZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+ IFYyOg0KPj4gLSBhZGp1c3QgY29tbWVudHMgYW5kIGRvY3MgKEFudGhvbnkgUGVyYXJkKQ0K PiANCj4gTWF5YmUgYG1hbiB4bGAgc2hvdWxkIGJlIHVwZGF0ZWQgYXMgd2VsbC4gSW4gdGhl IHNlY3Rpb24gYWJvdXQgYHhsDQo+IG1lbS1tYXhgLCB0aGVyZSBpczoNCj4gICAgICAiTm90 ZSBob3dldmVyIHRoYXQgdGhlIGluaXRpYWwgbWF4bWVtIHZhbHVlIGlzIHN0aWxsIHVzZWQg YXMgYW4NCj4gICAgICB1cHBlciBsaW1pdCBmb3IgeGwgbWVtLXNldC4gIEFsc28gbm90ZSB0 aGF0IGNhbGxpbmcgeGwgbWVtLXNldCB3aWxsDQo+ICAgICAgcmVzZXQgdGhpcyB2YWx1ZS4i DQo+IA0KPiBUaGF0IHdvdWxkbid0IGJlIHRydWUgYW55bW9yZSB3aXRoIHRoaXMgcGF0Y2gu DQoNCldlaXJkLiBJIGRpZCBtb2RpZnkgdGhhdCBtYW4gcGFnZSwgYnV0IG9idmlvdXNseSBk aWRuJ3QgY2hlY2sgaXQgd2FzDQpyZWFsbHkgYWRkZWQgdG8gdGhlIHBhdGNoLiBTb3JyeSBm b3IgdGhhdCwgd2lsbCByZXNlbmQgdGhlIHBhdGNoIHdpdGgNCnRoYXQgY2hhbmdlIGluY2x1 ZGVkLg0KDQoNCkp1ZXJnZW4NCg0K --------------kYzkUR4Dfd50HPS7wHMIkuIB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------kYzkUR4Dfd50HPS7wHMIkuIB-- --------------7TTMzo8JvJab1mTka28bZ9SM-- --------------wgAT6AxEVamKLTDTp00pz0us Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJvk2UFAwAAAAAACgkQsN6d1ii/Ey/5 Lgf8DgoRR3Y/NxgvZN9ztjcwn+1WFxkUoXMKPj5C/a1cDXwnD2yUWJ+Nu2Ep/x226hAwrHFnaow2 GEvdIPDEBwIwsJ8Da7ucKv6RZYgzFhLWV4RsQjIcFIXB0OFOD6rJIrFhenIpIcXKnojKwN6CP8BZ Du7WN8viwKVYSXPnREPJoLfWejmVgTGmjViTNKmLQiSY1m2Nh3S2JOj7/8vYAxh9aFj+y/mEuZDH vGVZqvklb9aq/0nBNPn813SjlihV8AaDWWZm/Xm99SPsscItIjhfnhpKaJhJeFejyuD2L4OLlsrW 10qjJp1i1v/XaVVe/jf5jznXwMIWE0mTRK7+DKMP/w== =7TMm -----END PGP SIGNATURE----- --------------wgAT6AxEVamKLTDTp00pz0us-- From xen-devel-bounces@lists.xenproject.org Mon May 02 08:34:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 08:34:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318716.538599 (Exim 4.92) (envelope-from ) id 1nlRVH-0006vW-K9; Mon, 02 May 2022 08:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318716.538599; Mon, 02 May 2022 08:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRVH-0006vP-GN; Mon, 02 May 2022 08:33:59 +0000 Received: by outflank-mailman (input) for mailman id 318716; Mon, 02 May 2022 08:33:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRVH-0006vF-4I; Mon, 02 May 2022 08:33:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRVH-0004uE-1k; Mon, 02 May 2022 08:33:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRVG-00084f-MC; Mon, 02 May 2022 08:33:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlRVG-0000hC-Lm; Mon, 02 May 2022 08:33:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4pdLv7vK5b+xAXYC2KNnuSK5okY95iA8kiyqJ4ZjMKA=; b=hJTs5v8kDlfLMouGVdw95v/oui 0m5/bXpKyjD2qeSebRHbQwlDPMOhTTUGxCWgd+Rm8rE0eRlITPEoEZc+1iGYrVM2XZqugQlk9IfBL udZGwHUBSu6+0dwVYwQZe6y6bDSilZUcXqRcZaDnEw6O29Jm4SpKfakvhA0Z5NTCsH9Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169983: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 08:33:58 +0000 flight 169983 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169983/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 755 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 47 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 08:47:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 08:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318724.538610 (Exim 4.92) (envelope-from ) id 1nlRiQ-0008WS-RJ; Mon, 02 May 2022 08:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318724.538610; Mon, 02 May 2022 08:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRiQ-0008WL-Nl; Mon, 02 May 2022 08:47:34 +0000 Received: by outflank-mailman (input) for mailman id 318724; Mon, 02 May 2022 08:47:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRiP-0008WF-LS for xen-devel@lists.xenproject.org; Mon, 02 May 2022 08:47:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 81483a6e-c9f4-11ec-a405-831a346695d4; Mon, 02 May 2022 10:47:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AE33E210EC; Mon, 2 May 2022 08:47:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 89207133E5; Mon, 2 May 2022 08:47:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PO4iIKOab2JXFgAAMHmgww (envelope-from ); Mon, 02 May 2022 08:47:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81483a6e-c9f4-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651481251; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3YGp09FIL19SEfwLZBKJrZGe61G82XI/DK4ZCzyeUww=; b=uHWnRqYyDeNiAhGeSvNuQVtBugZZEBF/T3GhiUaydYzG90eZypJtp4QeUXrx3dnsOVXce6 ScpkEKO/0DvyK13BT4zUog+/CXq5CgvfICC5RnnGpTj782kQwRvrh2dPFpC/3GxHRZy3fB tp+lDkHG46df8exc7WKvu8y6jrY9GVM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH v3] tools/libs/light: update xenstore entry when setting max domain memory Date: Mon, 2 May 2022 10:47:29 +0200 Message-Id: <20220502084729.13044-1-jgross@suse.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit libxl_domain_setmaxmem() called during "xl mem-max" should update the domain's memory/static-max Xenstore node, as otherwise "xl mem-set" won't be able to set the memory size to the new maximum. Adjust the related comments and documentation accordingly. Signed-off-by: Juergen Gross --- V2: - adjust comments and docs (Anthony Perard) V3: - really adjust the docs (Anthony Perard) --- docs/man/xl.1.pod.in | 11 +++++------ tools/libs/light/libxl_mem.c | 12 ++++++++++-- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index e2176bd696..101e14241d 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -442,15 +442,14 @@ allocate. The default unit is kiB. Add 't' for TiB, 'g' for GiB, 'm' for MiB, 'k' for kiB, and 'b' for bytes (e.g., `2048m` for 2048 MiB). -NB that users normally shouldn't need this command; B will -set this as appropriate automatically. - I can't be set lower than the current memory target for I. It is allowed to be higher than the configured maximum memory size of the domain (B parameter in the domain's -configuration). Note however that the initial B value is still -used as an upper limit for B. Also note that calling B will reset this value. +configuration). + +Setting the maximum memory size above the configured maximum memory size +will require special guest support (memory hotplug) in order to be usable +by the guest. The domain will not receive any signal regarding the changed memory limit. diff --git a/tools/libs/light/libxl_mem.c b/tools/libs/light/libxl_mem.c index c739d00f39..92ec09f4cf 100644 --- a/tools/libs/light/libxl_mem.c +++ b/tools/libs/light/libxl_mem.c @@ -20,8 +20,7 @@ /* * Set the maximum memory size of the domain in the hypervisor. There is no * change of the current memory size involved. The specified memory size can - * even be above the configured maxmem size of the domain, but the related - * Xenstore entry memory/static-max isn't modified! + * even be above the configured maxmem size of the domain. */ int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb) { @@ -82,6 +81,15 @@ int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint64_t max_memkb) goto out; } + rc = libxl__xs_printf(gc, XBT_NULL, + GCSPRINTF("%s/memory/static-max", dompath), + "%"PRIu64, max_memkb); + if (rc != 0) { + LOGED(ERROR, domid, "Couldn't set %s/memory/static-max, rc=%d\n", + dompath, rc); + goto out; + } + rc = 0; out: libxl_domain_config_dispose(&d_config); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 08:58:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 08:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318730.538621 (Exim 4.92) (envelope-from ) id 1nlRsx-0001eH-PP; Mon, 02 May 2022 08:58:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318730.538621; Mon, 02 May 2022 08:58:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRsx-0001eA-Kg; Mon, 02 May 2022 08:58:27 +0000 Received: by outflank-mailman (input) for mailman id 318730; Mon, 02 May 2022 08:58:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRsx-0001e0-3G; Mon, 02 May 2022 08:58:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRsw-0005K4-VJ; Mon, 02 May 2022 08:58:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlRsw-0000Xt-83; Mon, 02 May 2022 08:58:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlRsw-0001eT-7a; Mon, 02 May 2022 08:58:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bCawusa4fYbvxvekJl+PuGQVwLLIhS3Z4Yi2GR3hhpE=; b=o/ugbOZUmpueG8B2fAQ5xmewTy xE1jXAhoRz+zTiRI6dqu3oOfCRzI/8C1WpR+uu5hn7soVnKKUaV5OQ79/qxu/jSlIitUDu4c/bqQ/ pxvPiHBefQ43JP2XRpnzkz1YW1Hy2VVnN/FZ6JXzKSNZ3NftVjdaMIjJNOdzx9+/618c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 169976: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd X-Osstest-Versions-That: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd From: osstest service owner Date: Mon, 02 May 2022 08:58:26 +0000 flight 169976 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169976/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail pass in 169929 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169929 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169929 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169929 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169929 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 169929 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 169929 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169929 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169929 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169929 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169929 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169929 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169929 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd baseline version: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd Last test of basis 169976 2022-05-02 01:53:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 02 09:07:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 09:07:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318739.538632 (Exim 4.92) (envelope-from ) id 1nlS23-0003Ii-T8; Mon, 02 May 2022 09:07:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318739.538632; Mon, 02 May 2022 09:07:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlS23-0003Ib-Oc; Mon, 02 May 2022 09:07:51 +0000 Received: by outflank-mailman (input) for mailman id 318739; Mon, 02 May 2022 09:07:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlS22-0003IO-Hc; Mon, 02 May 2022 09:07:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlS22-0005UJ-FB; Mon, 02 May 2022 09:07:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlS22-0000r9-3J; Mon, 02 May 2022 09:07:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlS22-0008Tj-2r; Mon, 02 May 2022 09:07:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TfiXZ5JBa9wDnKmrvPmM3bJi92jBw6jHzk4MFNZ1a7o=; b=Llv2PVcAQiarwpa/Ar8NUkLjve aQjsAXKDqIwPSKldb+yYzsDoo6Qe7IOHfLUurUmfzaDfbpy7ZUiHjwlJo8jc76KGUX9+Lmjlpxrno 6K+DuNh0wNRYX32uFvzyBac6TCg//VXtkyLmZULjkIx9IOR7KAIWEsF7btvZQ6UPF1SM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169987: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 09:07:50 +0000 flight 169987 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169987/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 756 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 48 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 09:39:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 09:39:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318747.538642 (Exim 4.92) (envelope-from ) id 1nlSVx-0006mT-85; Mon, 02 May 2022 09:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318747.538642; Mon, 02 May 2022 09:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSVx-0006mM-53; Mon, 02 May 2022 09:38:45 +0000 Received: by outflank-mailman (input) for mailman id 318747; Mon, 02 May 2022 09:38:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSVw-0006mC-2p; Mon, 02 May 2022 09:38:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSVw-00061p-0X; Mon, 02 May 2022 09:38:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSVv-0001g5-GH; Mon, 02 May 2022 09:38:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlSVv-0006Lp-Fm; Mon, 02 May 2022 09:38:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bqMKJ9wGmWlSRZuwIZFui3hfCmMc1XepzTSljUJsKTo=; b=iSWPwe9lG/Pk5IpRJiFdmGjJQ1 Kja83HCuVU9zqw7QfxLI3HT7ga6FoTpunLg/OheaV7oh2NbfFQtkE5HdAU78PpEspmO/7HxzZVgX9 j+iPmc2tCC0fVguvzph86F4gohpS79KomIxKqKhb4vRvuoPKpIcH7G+aaXyy99MSIOuw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169988: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 09:38:43 +0000 flight 169988 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169988/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 757 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 49 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 09:57:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 09:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318755.538654 (Exim 4.92) (envelope-from ) id 1nlSo2-0000rw-RH; Mon, 02 May 2022 09:57:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318755.538654; Mon, 02 May 2022 09:57:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSo2-0000rp-OI; Mon, 02 May 2022 09:57:26 +0000 Received: by outflank-mailman (input) for mailman id 318755; Mon, 02 May 2022 09:57:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSo1-0000rf-7g; Mon, 02 May 2022 09:57:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSo0-0006Ke-W5; Mon, 02 May 2022 09:57:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSo0-0002CI-Kd; Mon, 02 May 2022 09:57:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlSo0-0007E6-KA; Mon, 02 May 2022 09:57:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Yi8grIAth9quFT9C24OkhdtMoLWVZ3JahXZO3G/ENIo=; b=U0hS4/mBOxviWea8xZ2DE2v2Ul yi81/Y2CzcDYLKB4A9lNJIevtKsLkb/buaDxJolXn+WmUzFK2w76MkVT96+3+4M839t9TXwKdaosp cOFgN3l3xwD1PU9M4gumgt8E+fTKre5brOPQ4AUrE+C/F7gVR92iuJ4jZqk0PmVG80qg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 169982: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 X-Osstest-Versions-That: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd From: osstest service owner Date: Mon, 02 May 2022 09:57:24 +0000 flight 169982 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/169982/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 baseline version: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd Last test of basis 169864 2022-04-29 10:00:27 Z 2 days Testing same since 169982 2022-05-02 07:01:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Elliott Mitchell Jan Beulich Julien Grall Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fe234237b6..702c9a800e 702c9a800eb3ecd4b8595998d37a769d470c5bb0 -> smoke From xen-devel-bounces@lists.xenproject.org Mon May 02 10:07:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 10:07:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318763.538665 (Exim 4.92) (envelope-from ) id 1nlSxk-0002Vb-PX; Mon, 02 May 2022 10:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318763.538665; Mon, 02 May 2022 10:07:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSxk-0002VU-Ma; Mon, 02 May 2022 10:07:28 +0000 Received: by outflank-mailman (input) for mailman id 318763; Mon, 02 May 2022 10:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlSxi-0002VO-UX for xen-devel@lists.xenproject.org; Mon, 02 May 2022 10:07:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa9638de-c9ff-11ec-a405-831a346695d4; Mon, 02 May 2022 12:07:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F2AC210E1; Mon, 2 May 2022 10:07:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3AAC613491; Mon, 2 May 2022 10:07:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q2usDF2tb2IjOQAAMHmgww (envelope-from ); Mon, 02 May 2022 10:07:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa9638de-c9ff-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651486045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=dSazRnUrhG2E0eGygBKI1IfushgTILxOn4bMfGXU/uA=; b=DJ/JY3vLaoNFkN3FaHETJ+PESajiRM+DJEqB2p0nlJ9vuowwjnFm4+o6LFGQhv7Gp4hTVV tCzANf5AlFaSHVgdpgf8VdNloGhRGWWgZ0XHIsORNmeNjmzkLQYCndaE5s12z+326Hmfss yAYBS6NvdYjkhbimTTrbUMCdeuSQCDc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD , Raphael Ning Subject: [PATCH v2] tools/xenstore: don't let special watches be children of / Date: Mon, 2 May 2022 12:07:22 +0200 Message-Id: <20220502100722.17250-1-jgross@suse.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When firing special watches (e.g. "@releaseDomain"), they will be regarded to be valid children of the "/" node. So a domain having registered a watch for "/" and having the privilege to receive the special watches will receive those special watch events for the registered "/" watch. Fix that by calling the related fire_watches() with the "exact" parameter set to true, causing a mismatch for the "/" node. Reported-by: Raphael Ning Signed-off-by: Juergen Gross Reviewed-by: Raphael Ning --- V2: - use Rapahael's amazon mail address --- tools/xenstore/xenstored_domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index ae065fcbee..80ba1d627b 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -231,7 +231,7 @@ static int destroy_domain(void *_domain) unmap_interface(domain->interface); } - fire_watches(NULL, domain, "@releaseDomain", NULL, false, NULL); + fire_watches(NULL, domain, "@releaseDomain", NULL, true, NULL); wrl_domain_destroy(domain); @@ -282,7 +282,7 @@ void check_domains(void) } if (notify) - fire_watches(NULL, NULL, "@releaseDomain", NULL, false, NULL); + fire_watches(NULL, NULL, "@releaseDomain", NULL, true, NULL); } /* We scan all domains rather than use the information given here. */ @@ -495,7 +495,7 @@ static struct domain *introduce_domain(const void *ctx, if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL, - false, NULL); + true, NULL); } else { /* Use XS_INTRODUCE for recreating the xenbus event-channel. */ if (domain->port) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 10:29:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 10:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318769.538676 (Exim 4.92) (envelope-from ) id 1nlTJ2-00053J-Gm; Mon, 02 May 2022 10:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318769.538676; Mon, 02 May 2022 10:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTJ2-00053C-D4; Mon, 02 May 2022 10:29:28 +0000 Received: by outflank-mailman (input) for mailman id 318769; Mon, 02 May 2022 10:29:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTJ1-000532-4l; Mon, 02 May 2022 10:29:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTJ1-0006yB-2v; Mon, 02 May 2022 10:29:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTJ0-0002sn-KA; Mon, 02 May 2022 10:29:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlTJ0-0001O1-Jm; Mon, 02 May 2022 10:29:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pxE+QrHYWGpvrND+S+crKsv+qvsLQf5HmZA149ZgXjw=; b=0LqYv56uI+RJ7b9bSPfp/s7HOG dqh53V8yKpBxYa4bbPlAF3d6zH3rhH89T25apNdKM2R+N9M4w0E2DYnerlMLu8RVR9WpcJvwaXoGN cnEyzWHjzkHgG+xnXPaJZOJmme0OjdXZ450uPS0MvYdpzqULrUJCEvze6NoW2HaerzX8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169989: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 10:29:26 +0000 flight 169989 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169989/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 62 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 758 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 50 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 10:50:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 10:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318778.538687 (Exim 4.92) (envelope-from ) id 1nlTd7-00008m-4h; Mon, 02 May 2022 10:50:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318778.538687; Mon, 02 May 2022 10:50:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTd7-00008f-1h; Mon, 02 May 2022 10:50:13 +0000 Received: by outflank-mailman (input) for mailman id 318778; Mon, 02 May 2022 10:50:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlTd5-00008V-Q6 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 10:50:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0a43240-ca05-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 12:50:07 +0200 (CEST) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 06:50:04 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB4847.namprd03.prod.outlook.com (2603:10b6:208:108::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 10:50:02 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 10:50:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0a43240-ca05-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651488607; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=pWDuLEAEFf5nRVlCvoGlDESZ93GYkTTylokiwwOLIc0=; b=IXjI6nXaX1Ik4JPl7h7OeLl6QhFl6uVs1Gz2f3aiwPHF2GFnUJr8oPNz wMD8bTzlfJW00AM/NVHUvMR76BTVb30lVbEeDTgmuMchESRnKSqDiKL3z V0JS315JRVhYWCujL6mVl2azwckgVI5jXaadXgwkMNksvm6cFgcugR816 o=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 70247119 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wD+G8qNknVo0HXbvrR2QlsFynXyQoLVcMsEvi/4bfWQNrUp0gWQAy TZJWm2DbqyIM2T3fNggOY21/R9Su5Hcx9dgGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9 MpVj5XueV0Qb4KWmNVCT0N7IQxSBPgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPuiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iOjLGQB+Tp5o4IRwXbvkAVz0YL0IcX7YvePZMQEgliX8 zeuE2PRR0ty2Mak4TiK6HW3ncfUgDj2HokVEdWQ9PRnnVmSzWw7EwANWB2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Geog6RrLzbHI+QGHHWsVZjlbYdciuYk9QjlC/ liShM/kHiAqubGQSHS15rqStSm1OyUeMSkFfyBscOcey9zqoYV2gheRSN9mSfSxloesRm+2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:UoacVaNZ6JnMTsBcT0j155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DsrvZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolCs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REIGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUETA9OL8y7qvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wM9HdwGOt15Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexrwqEH3QSuvyWqOLtB0B1v977jK3Z4S2MaGPLQ18bpaou W1bLofjx9+R37T X-IronPort-AV: E=Sophos;i="5.91,190,1647316800"; d="scan'208";a="70247119" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHlFBrgn/FFDALMXg1DEjUkPnMDWtxrbDm+BeAzAduBoi7f3VsDkC2ggS41XzhjLpgV4d2Cfm8TtqaXEnuG1BYjPzobwB6OeJ1LCiDJAIm3VC8nYjMuH+AyEDRbbwEQY4yZRflrM2q5wXMHMCD5tnCG1mQrQQxDhVP2+4oh/P7Kv88Yc5lHUZ8o4a46auzpnjKnIoFmayfBmco+d+cwR7B4U7+iCNXw5T0x2bmNQPBEwMt2b237uH53FSg73r9AH2HQOH8OaoJFwOzZnqeSiWHhwBmKGapgFNxhE+QIairdgsYQxB/fb2hLlLaLGR9ISnQRulfOBN3ZjKX3YISO9lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pLm4VKES2xR4AoS7eswrhG3rPzPMjBBZN3lUm7Ngte8=; b=neBSSdEL82kFrqJQLAqgz0w/DjM0LVEKe4hhljgESX+QIuBZ7I0NokNTyi5L9INutFxf7lzGEdI5uoJQ7lBWoEotKsGaZjJra6z+8nGJaIEwjxrCB/g+g7Gd1TpGK+Qiq8UK5dLgScwYg0e0g+zP0XmcnzdWQ3vY/2uelkBRllq6WSol099jP5Az78Ioy4hLa4CuRNXkZrExCC/1Ibhe7RhasXxWFAO9zczHhBfwII6x+qfOp/k2UpsoZ8L1Rk3Kqxtn1/pV5M/IPnAtLwjwi9+caC/GxQRFN29NAr0uheK91vZ0Um4p5ebmet9Kd0bLomy+gsN7n/pXt7WozAREHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pLm4VKES2xR4AoS7eswrhG3rPzPMjBBZN3lUm7Ngte8=; b=irc+2pWVJ3vpwF2GiCuPh2WVgNKzy6DeFmCIv9oKVfGV/hda4lnf5z/B9HOK/dyeZ+H85L/hklgND/sr/WZwAHB/6YCtqeVXMvzqVrDnvIylN85k+7GYPovnbqfPtuQuASm/vF0jVabBxqdqtIMYClg7fApRHOno+dVbhJZ3hGU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 2 May 2022 12:49:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross Cc: Jan Beulich , xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner Subject: Re: [xen-unstable test] 169819: regressions - FAIL Message-ID: References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> X-ClientProxiedBy: LO2P265CA0088.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 048d3b05-5b94-477b-6e46-08da2c2981d4 X-MS-TrafficTypeDiagnostic: MN2PR03MB4847:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3Yi3+nn/Mqmej+5Pk3j+rXahKXxh03Bycmm9Y/CICwypMMblLN9keygGEinAQfeJ+h1/2PRin9Kp7OUU47FPkeGPIdMORDNvgNX0KNbxYEkmIiuU51/53OJ2WT0jUeILfimOEiwLbpdROUBTSoAMRH27gaZwd+iTg4QZRmLkIb2MfyMFa0bhoR5/6lu6x5fdOXGQ0jE9ul6yVGLW5SG3CYjAKG8l1zdfBhyG2p4JctLPSdlNhW2JEcUY59Dczc0TNbEGoDjZMvK7NtBSN4UQxeFPw+yVrm8kB0Izd7k3fmxNScVRqdbVAvz5SfmzyIZCMmFF2J1lbqZrVJikIGFUfC6hp2Qh7fHgf3Hs2Ox0hXPNG3/h6+dQNX24J4Ntmr9930NceVjOndZ/E6gaWTUrXpnK6DLfqw1n3f8dTYSFSMy0sgpK8rk3IRrSa/C1O9ZEKnON4HxRFbFYgcCvpkH2LhjEdKgSEwPrpoBPgSiK1xyxesKT1UM41VXhvpTK1P2mZptIJeZQxVN1MAqogjPYheJxjwIgBhEqgUKBloX9GRwIDUb7aEKyst6p3f1fQS7lv4olnGrKvLaU48m4I3njAR4BIntB1HLfMcSTtLvmpDCB+oqBtDedyMsqbAOEFc1UVHYjv94fvX3eCMltub7LsqSlnERmYpn+QX4qiqrFHIW/dlrNTA2eX5RgnfuwkXL+EilMoPCNzs9/o/imOmnt2Bd/xZH9rj1rrr8nNzbJNmZOCMyT4Zc+nCY6duaoRV3s92Z9ahDhEhbDIX8yC3Tc0KUNxaOr4wDj3T4y8qKwh/KmtxfC5Mw1TrIO/ak8kWKL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(85182001)(4326008)(33716001)(8936002)(966005)(6486002)(6666004)(6916009)(8676002)(508600001)(66946007)(66476007)(66556008)(2906002)(54906003)(5660300002)(38100700002)(6512007)(9686003)(26005)(6506007)(53546011)(83380400001)(186003)(82960400001)(316002)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmlkQ0hrNFNjWjB2VFo5UHhZNWVUMXR6b0JlYXVJdFhDa2ZWWUw4Y3hWT0cr?= =?utf-8?B?b2xQV21vSzhXeDZFVVpZSTJmQlVqZVR5aEw4UEtibGlUV0g2RE5zQjZERXVl?= =?utf-8?B?aE5DdUZoVXo5SUd3azJ6R21VRTFxYW5mMFdrSU5RVnpnZy9KOGNQTHUvcExU?= =?utf-8?B?SnNTdm90TU5NS2VYSmRid0RtTWlsQVVwVFUrSmpERHU5ZGphK0UrMmlGb2hn?= =?utf-8?B?cEduWWZpR0dONVN4K01RaXN1MDhIOWVpT0dZbW9odndMMW1SekJUTEdQckhE?= =?utf-8?B?c3J0TVR5NlZlY3ljNTF6eldrSXRCSUkwTUVQWHAxOUlZb3Zqb3pGQXVXSWE0?= =?utf-8?B?QUpManpvRk15UXM5L0lOSS84S1NjOUNiVmtBcllrVmduRWRzeHBYTEU3d2pI?= =?utf-8?B?aGdQdVhxVVNXSnZjU3VrcG9NSDZnMFIxb1pzZEZnMmZSQWxXcXBodDN1Ykpk?= =?utf-8?B?NE1BSDhCWlM1QktwcTJCUVV1eUZQTXNzendybG9xWWdhLzQrRStESzNmb2tr?= =?utf-8?B?OWtxSTI2blhDd3M0eitxdDhzRnZWV2p3RVcxVXBuUWxVWlovMjQxRTg4Y2Q2?= =?utf-8?B?NEM3eXZDaXFEbGJVR2VML0RTdmtwdTVlVnRWZW9YcGJpSFl1cm5SaHlCdUtS?= =?utf-8?B?RHRaNytnT2lGNWdjcWNsb0gwQUkxd0lkVjBBZjZSSmw0QjJVR0QxS1hEOUxp?= =?utf-8?B?czlsRGNmdXJJME9FQWFtQ2twL0RlOEtZdjA0b0xzNk5RU3pzbGI1dWl3WWdR?= =?utf-8?B?TEtud3RtNUdXZ29HRXduTEJNYldTMzgvWE9TaHdmQUovSVM3TmpSWEpYR0d6?= =?utf-8?B?TjVRUmRKQW42NEQrMUd0RHpzNjRkK2s2c213NkJhY1lsSmozRHZEZ054bGpV?= =?utf-8?B?cFNTWFpvUjBZZTU2SG9uUDhvQ3E5RGhRblRzV1h6UEE0K2w4QTBvMmx5bDFp?= =?utf-8?B?SkZ0QmVXQUQyY2hlK3RMRWEvV2dyRHlaUmNJcDA1T0VDWWZWTFdGaEpsMUMy?= =?utf-8?B?VzdYSTdCVSszV2VFSW5LS3h1czBtMUx2UUFhMVN5WWdEQnRXTVF2c3EwczJU?= =?utf-8?B?RHNwR214NmhqaWxqYjI1MVVqd1BOdlhQMXVWODFiU3RMd2g4eDZtb3NsN3hr?= =?utf-8?B?TzlzcUl0bmpPVWRnWUozZXhGWi9FWmo4OHkxYytJZ1NiVXJhaDFaRDJVcCtG?= =?utf-8?B?dC9xYTNDTnFHVHZRMkZIcnNtNm9XRXZtVThlK3AxamFjVXBjNHVpRmZMWnV1?= =?utf-8?B?NnI1cXB5RGdLQ3NIMjN4NW1rdTNRc08rMWRrQkEyMVRQWEJjR0ZsRzV2U1Zz?= =?utf-8?B?RFVuclg1bFp1L013QVlXa3FmM1FFc0xjV09GQmJHVVRXVGpWa2NqL1BWTXFp?= =?utf-8?B?aGgvMkZzdm9KYkd2STd2UjE0aEdDU2VhQ1ZkbHBTT1h3QTVpOHZxU251VzYv?= =?utf-8?B?Q3J2bFlxZ1orZWNGQ2hGbGlmaU5IclcrWUxXTnhKbUtnRVZ0MS9oMmNNVlgx?= =?utf-8?B?STVwQWlrUTB4bjhKZVd0WHZ3S1NRRWUzU0U2YjVhWUlUNmZaRlViM09LNGdh?= =?utf-8?B?cVloRmhEdk9DODRSTU0xb0U1YzdhOFE0emJIV0dkUzRWRXpMbmNEMFRET2w4?= =?utf-8?B?V3Y5ZnlTREh6aWN3YUdMZytCKzZ0V29DL20yY3UrU2JNa2YrcE9FR05oNDB6?= =?utf-8?B?Yys4Y3FjcHRkb0MrWVd0b3VVSnNHTm03U3BNNXJjbVBUYVg1WHRjVUU0Ritz?= =?utf-8?B?N3lSUThXN2RiMzVvQ0Fndk9wRGtlOEJnc2h5SkJnUXR3eXl3R3d1eFRJZTVK?= =?utf-8?B?anBRZmZ3ZWZ5WnlCN1lub1RYU0VYRkpvd1ZxUU5RUW00ZXVCKy9sRFRHZXp4?= =?utf-8?B?UjRnRlZWNkJMeFMvcmVZaGxyVTNKNTNlRElWMWlLWUZWeGthVGxuZzFGTjVI?= =?utf-8?B?NXlwVU5MdFBMTlBCbEllK0wyZzQrQnpSWEFtYTgzT3J2TE1jbmcrNndRTmdj?= =?utf-8?B?NWVxSkw1cHlocDBHTFdwUk5OUUdVT0kxS3ZPWXoyTTZCcUk4cGw0MmkwQ29v?= =?utf-8?B?QjdUQjVGbFd0d1dmbDgzcUprbU5USGhiOHhpUlFKRjc2cVoxRGZnVWdzOThM?= =?utf-8?B?S1pILzZHckRvUnoyYUJOSGJZS3hiSG1lMzZENTNPNWJBeHFKU1ZMZzNCT0g1?= =?utf-8?B?bWpKWW9VM2YvOFVuNHllaWd6eTAzN2NrOTVOUEpwRUJlOE5FTE1ueTh0M0VX?= =?utf-8?B?YzVzTHdUY3o1UEkyQ1BuMGZUblhpU3F2cjZHcE5SeURZSS9nRTkrWTB3aVhK?= =?utf-8?B?djdMMUtXKy9vYUlKTUZwbmZZeWFIbG1TT2tBZU8rNU1zZzFvNmVCdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 048d3b05-5b94-477b-6e46-08da2c2981d4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 10:50:01.1998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82j03UP15vcLa3G+tXRd+5Wf5IUHDVyBLnbeaycVEGw4zrWm4viXyacM+/4+bJ2LpNXIDA2MDEYu/HD/GnxcEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4847 On Mon, May 02, 2022 at 08:51:40AM +0200, Juergen Gross wrote: > On 29.04.22 13:00, Roger Pau Monné wrote: > > On Fri, Apr 29, 2022 at 12:37:13PM +0200, Jan Beulich wrote: > > > On 29.04.2022 12:30, Roger Pau Monné wrote: > > > > On Fri, Apr 29, 2022 at 07:46:47AM +0000, osstest service owner wrote: > > > > > flight 169819 xen-unstable real [real] > > > > > flight 169843 xen-unstable real-retest [real] > > > > > http://logs.test-lab.xenproject.org/osstest/logs/169819/ > > > > > http://logs.test-lab.xenproject.org/osstest/logs/169843/ > > > > > > > > > > Regressions :-( > > > > > > > > > > Tests which did not succeed and are blocking, > > > > > including tests which could not be run: > > > > > test-arm64-arm64-examine 8 reboot fail REGR. vs. 169775 > > > > > test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 169775 > > > > > test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 169775 > > > > > test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 169775 > > > > > test-arm64-arm64-xl-thunderx 8 xen-boot fail REGR. vs. 169775 > > > > > test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 169775 > > > > > > > > > > Tests which are failing intermittently (not blocking): > > > > > test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169843-retest > > > > > > > > Looked into this one, and it's slightly concerning, guest seems to be > > > > stuck at installation: > > > > > > > > Select and install software [ 481.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 509.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 545.093820] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 573.093809] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 609.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 637.093836] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 673.093957] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 701.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 733.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 761.093817] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 797.093898] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 825.093863] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 861.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 889.093945] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 925.093974] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 953.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 985.093832] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1013.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1049.094031] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1077.093860] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1113.093938] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1141.093803] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1177.094051] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1205.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1237.093955] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1265.094004] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1301.093835] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1329.094039] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1365.093883] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1393.094167] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1429.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1457.093900] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1489.094026] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1517.093997] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1553.093996] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1581.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1617.094076] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1645.093882] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1681.093896] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1709.094022] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1741.093870] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1769.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1805.094017] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1833.093837] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1869.094043] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1897.094101] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1933.093879] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 1961.093933] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 1997.093952] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2025.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2057.093895] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2085.094172] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2121.094018] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2149.094021] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2185.093931] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2213.093864] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2249.093951] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2277.093899] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2309.094054] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2337.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2373.094111] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2401.094132] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2437.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2465.094003] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2501.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2529.094050] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2561.094027] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2589.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2625.093999] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2653.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2689.094024] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2717.094093] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2753.093913] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2781.094095] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2813.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2841.094117] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2877.094041] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2905.094009] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 2941.093893] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 2969.094085] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > [ 3005.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 3033.093917] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > [ 3065.094060] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > > > debina1 is one of the boxes I've put into production recently. > > > > > > ISTR this issue having surfaced randomly before. With the randomness making > > > it difficult to investigate. > > > > Indeed, it seems to happen on other boxes also: > > > > http://logs.test-lab.xenproject.org/osstest/results/history/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm/xen-unstable.html > > > > At least doesn't seem to be explicitly related to debinas. > > How valuable is it to test systems using a kernel from 2019? > > Chances are high that bugs which might trigger are corrected already. > IMO trying to find probably known bugs is a waste of time. This is the kernel from oldstable Debian distribution, which is still supported (until June 2024 AFAICT). I think it's not unlikely that people are running those kernels in guests. I wouldn't mind testing newer guest kernels, but someone would have to update osstest to use Debian 11 which ships with kernel 5.10. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 02 11:16:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 11:16:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318785.538697 (Exim 4.92) (envelope-from ) id 1nlU2E-0002wU-7N; Mon, 02 May 2022 11:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318785.538697; Mon, 02 May 2022 11:16:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU2E-0002wN-4T; Mon, 02 May 2022 11:16:10 +0000 Received: by outflank-mailman (input) for mailman id 318785; Mon, 02 May 2022 11:16:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU2D-0002wH-3M for xen-devel@lists.xenproject.org; Mon, 02 May 2022 11:16:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 430c22f5-ca09-11ec-a405-831a346695d4; Mon, 02 May 2022 13:16:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 934C021877; Mon, 2 May 2022 11:16:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5BB95133E5; Mon, 2 May 2022 11:16:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PdoXFXa9b2KUVgAAMHmgww (envelope-from ); Mon, 02 May 2022 11:16:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 430c22f5-ca09-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651490166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQBWPpl2zxow3qrKPFEujm4OmBvYDbwdVLp1pxnGQLg=; b=qAMeI26a9/Tr+jYeTIZRys8WTG8eAXqSXPiLafkVKDW08JLGqfjzROgGGCa8anQmpYRlTi tKC10hP101935HqcNrEtd0PIM6jM5XmkfOaKyBOk0cmsCisIRH60iWjHRs6ouAhfOchXmz RLpYIAQlnLEm/vwr5qobTxcnj8bsaMI= Message-ID: Date: Mon, 2 May 2022 13:16:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Jan Beulich , xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> From: Juergen Gross Subject: Re: [xen-unstable test] 169819: regressions - FAIL In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------gWu6KJAIxwi4EXtrWabMhoVn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------gWu6KJAIxwi4EXtrWabMhoVn Content-Type: multipart/mixed; boundary="------------L0YP2svfan965Yp1ORqcMmGU"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Jan Beulich , xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner Message-ID: Subject: Re: [xen-unstable test] 169819: regressions - FAIL References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> In-Reply-To: --------------L0YP2svfan965Yp1ORqcMmGU Content-Type: multipart/mixed; boundary="------------jWz0ht1gsNKpQhMFAZCXgsm4" --------------jWz0ht1gsNKpQhMFAZCXgsm4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjIgMTI6NDksIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIE1vbiwg TWF5IDAyLCAyMDIyIGF0IDA4OjUxOjQwQU0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6 DQo+PiBPbiAyOS4wNC4yMiAxMzowMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBP biBGcmksIEFwciAyOSwgMjAyMiBhdCAxMjozNzoxM1BNICswMjAwLCBKYW4gQmV1bGljaCB3 cm90ZToNCj4+Pj4gT24gMjkuMDQuMjAyMiAxMjozMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90 ZToNCj4+Pj4+IE9uIEZyaSwgQXByIDI5LCAyMDIyIGF0IDA3OjQ2OjQ3QU0gKzAwMDAsIG9z c3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4+Pj4+PiBmbGlnaHQgMTY5ODE5IHhlbi11 bnN0YWJsZSByZWFsIFtyZWFsXQ0KPj4+Pj4+IGZsaWdodCAxNjk4NDMgeGVuLXVuc3RhYmxl IHJlYWwtcmV0ZXN0IFtyZWFsXQ0KPj4+Pj4+IGh0dHA6Ly9sb2dzLnRlc3QtbGFiLnhlbnBy b2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNjk4MTkvDQo+Pj4+Pj4gaHR0cDovL2xvZ3MudGVz dC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE2OTg0My8NCj4+Pj4+Pg0KPj4+ Pj4+IFJlZ3Jlc3Npb25zIDotKA0KPj4+Pj4+DQo+Pj4+Pj4gVGVzdHMgd2hpY2ggZGlkIG5v dCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcsDQo+Pj4+Pj4gaW5jbHVkaW5nIHRlc3RzIHdo aWNoIGNvdWxkIG5vdCBiZSBydW46DQo+Pj4+Pj4gICAgdGVzdC1hcm02NC1hcm02NC1leGFt aW5lICAgICAgOCByZWJvb3QgICAgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTY5 Nzc1DQo+Pj4+Pj4gICAgdGVzdC1hcm02NC1hcm02NC1saWJ2aXJ0LXhzbSAgOCB4ZW4tYm9v dCAgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTY5Nzc1DQo+Pj4+Pj4gICAgdGVz dC1hcm02NC1hcm02NC1saWJ2aXJ0LXJhdyAgOCB4ZW4tYm9vdCAgICAgICAgICAgICAgICAg ZmFpbCBSRUdSLiB2cy4gMTY5Nzc1DQo+Pj4+Pj4gICAgdGVzdC1hcm02NC1hcm02NC14bC1j cmVkaXQxICAgOCB4ZW4tYm9vdCAgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTY5 Nzc1DQo+Pj4+Pj4gICAgdGVzdC1hcm02NC1hcm02NC14bC10aHVuZGVyeCAgOCB4ZW4tYm9v dCAgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTY5Nzc1DQo+Pj4+Pj4gICAgdGVz dC1hcm02NC1hcm02NC14bCAgICAgICAgICAgOCB4ZW4tYm9vdCAgICAgICAgICAgICAgICAg ZmFpbCBSRUdSLiB2cy4gMTY5Nzc1DQo+Pj4+Pj4NCj4+Pj4+PiBUZXN0cyB3aGljaCBhcmUg ZmFpbGluZyBpbnRlcm1pdHRlbnRseSAobm90IGJsb2NraW5nKToNCj4+Pj4+PiAgICB0ZXN0 LWFtZDY0LWFtZDY0LXhsLXFlbXV0LWRlYmlhbmh2bS1pMzg2LXhzbSAxMiBkZWJpYW4taHZt LWluc3RhbGwgZmFpbCBwYXNzIGluIDE2OTg0My1yZXRlc3QNCj4+Pj4+DQo+Pj4+PiBMb29r ZWQgaW50byB0aGlzIG9uZSwgYW5kIGl0J3Mgc2xpZ2h0bHkgY29uY2VybmluZywgZ3Vlc3Qg c2VlbXMgdG8gYmUNCj4+Pj4+IHN0dWNrIGF0IGluc3RhbGxhdGlvbjoNCj4+Pj4+DQo+Pj4+ PiBTZWxlY3QgYW5kIGluc3RhbGwgc29mdHdhcmUgIFsgIDQ4MS4wOTM4NTddIHdhdGNoZG9n OiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8x OjE3XQ0KPj4+Pj4gWyAgNTA5LjA5Mzg2NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbICA1NDUu MDkzODIwXSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAy MnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgIDU3My4wOTM4MDldIHdhdGNoZG9nOiBC VUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3 XQ0KPj4+Pj4gWyAgNjA5LjA5Mzg1NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbICA2MzcuMDkz ODM2XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyM3Mh IFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgIDY3My4wOTM5NTddIHdhdGNoZG9nOiBCVUc6 IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0K Pj4+Pj4gWyAgNzAxLjA5Mzg1NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbICA3MzMuMDkzODA1 XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtr c29mdGlycWQvMToxN10NCj4+Pj4+IFsgIDc2MS4wOTM4MTddIHdhdGNoZG9nOiBCVUc6IHNv ZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+ Pj4gWyAgNzk3LjA5Mzg5OF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbICA4MjUuMDkzODYzXSB3 YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29m dGlycWQvMToxN10NCj4+Pj4+IFsgIDg2MS4wOTM4NjVdIHdhdGNoZG9nOiBCVUc6IHNvZnQg bG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4g WyAgODg5LjA5Mzk0NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbICA5MjUuMDkzOTc0XSB3YXRj aGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGly cWQvMToxN10NCj4+Pj4+IFsgIDk1My4wOTM5MjVdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9j a3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAg OTg1LjA5MzgzMl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDEwMTMuMDkzODU1XSB3YXRjaGRv ZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQv MToxN10NCj4+Pj4+IFsgMTA0OS4wOTQwMzFdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3Vw IC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxMDc3 LjA5Mzg2MF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDExMTMuMDkzOTM4XSB3YXRjaGRvZzog QlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMTox N10NCj4+Pj4+IFsgMTE0MS4wOTM4MDNdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0g Q1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxMTc3LjA5 NDA1MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDEyMDUuMDkzODA1XSB3YXRjaGRvZzogQlVH OiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyM3MhIFtrc29mdGlycWQvMToxN10N Cj4+Pj4+IFsgMTIzNy4wOTM5NTVdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BV IzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxMjY1LjA5NDAw NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDEzMDEuMDkzODM1XSB3YXRjaGRvZzogQlVHOiBz b2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+ Pj4+IFsgMTMyOS4wOTQwMzldIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEg c3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxMzY1LjA5Mzg4M10g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDEzOTMuMDk0MTY3XSB3YXRjaGRvZzogQlVHOiBzb2Z0 IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+ IFsgMTQyOS4wOTM4NTddIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1 Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxNDU3LjA5MzkwMF0gd2F0 Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRp cnFkLzE6MTddDQo+Pj4+PiBbIDE0ODkuMDk0MDI2XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxv Y2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsg MTUxNy4wOTM5OTddIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sg Zm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxNTUzLjA5Mzk5Nl0gd2F0Y2hk b2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFk LzE6MTddDQo+Pj4+PiBbIDE1ODEuMDk0MDY0XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1 cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMTYx Ny4wOTQwNzZdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9y IDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxNjQ1LjA5Mzg4Ml0gd2F0Y2hkb2c6 IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6 MTddDQo+Pj4+PiBbIDE2ODEuMDkzODk2XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAt IENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMTcwOS4w OTQwMjJdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIy cyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxNzQxLjA5Mzg3MF0gd2F0Y2hkb2c6IEJV Rzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTdd DQo+Pj4+PiBbIDE3NjkuMDkzODU0XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQ VSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMTgwNS4wOTQw MTddIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEg W2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxODMzLjA5MzgzN10gd2F0Y2hkb2c6IEJVRzog c29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+ Pj4+PiBbIDE4NjkuMDk0MDQzXSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMx IHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMTg5Ny4wOTQxMDFd IHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tz b2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAxOTMzLjA5Mzg3OV0gd2F0Y2hkb2c6IEJVRzogc29m dCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+ PiBbIDE5NjEuMDkzOTMzXSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0 dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMTk5Ny4wOTM5NTJdIHdh dGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0 aXJxZC8xOjE3XQ0KPj4+Pj4gWyAyMDI1LjA5MzkyNV0gd2F0Y2hkb2c6IEJVRzogc29mdCBs b2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBb IDIwNTcuMDkzODk1XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNr IGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMjA4NS4wOTQxNzJdIHdhdGNo ZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJx ZC8xOjE3XQ0KPj4+Pj4gWyAyMTIxLjA5NDAxOF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2Nr dXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDIx NDkuMDk0MDIxXSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZv ciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMjE4NS4wOTM5MzFdIHdhdGNoZG9n OiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8x OjE3XQ0KPj4+Pj4gWyAyMjEzLjA5Mzg2NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAg LSBDUFUjMSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDIyNDku MDkzOTUxXSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAy MnMhIFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMjI3Ny4wOTM4OTldIHdhdGNoZG9nOiBC VUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3 XQ0KPj4+Pj4gWyAyMzA5LjA5NDA1NF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBD UFUjMSBzdHVjayBmb3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDIzMzcuMDkz OTU2XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMh IFtrc29mdGlycWQvMToxN10NCj4+Pj4+IFsgMjM3My4wOTQxMTFdIHdhdGNoZG9nOiBCVUc6 IHNvZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0K Pj4+Pj4gWyAyNDAxLjA5NDEzMl0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUj MSBzdHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI0MzcuMDk0MDY0 XSB3YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtr c29mdGlycWQvMToxN10NCj4+Pj4+IFsgMjQ2NS4wOTQwMDNdIHdhdGNoZG9nOiBCVUc6IHNv ZnQgbG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+ Pj4gWyAyNTAxLjA5Mzk1OV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBz dHVjayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI1MjkuMDk0MDUwXSB3 YXRjaGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29m dGlycWQvMToxN10NCj4+Pj4+IFsgMjU2MS4wOTQwMjddIHdhdGNoZG9nOiBCVUc6IHNvZnQg bG9ja3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4g WyAyNTg5LjA5NDA2MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVj ayBmb3IgMjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI2MjUuMDkzOTk5XSB3YXRj aGRvZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGly cWQvMToxN10NCj4+Pj4+IFsgMjY1My4wOTM5NTZdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9j a3VwIC0gQ1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAy Njg5LjA5NDAyNF0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBm b3IgMjJzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI3MTcuMDk0MDkzXSB3YXRjaGRv ZzogQlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQv MToxN10NCj4+Pj4+IFsgMjc1My4wOTM5MTNdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3Vw IC0gQ1BVIzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAyNzgx LjA5NDA5NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3Ig MjNzISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI4MTMuMDkzOTU5XSB3YXRjaGRvZzog QlVHOiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMTox N10NCj4+Pj4+IFsgMjg0MS4wOTQxMTddIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0g Q1BVIzEgc3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAyODc3LjA5 NDA0MV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJz ISBba3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDI5MDUuMDk0MDA5XSB3YXRjaGRvZzogQlVH OiBzb2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10N Cj4+Pj4+IFsgMjk0MS4wOTM4OTNdIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BV IzEgc3R1Y2sgZm9yIDIzcyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAyOTY5LjA5NDA4 NV0gd2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjNzISBb a3NvZnRpcnFkLzE6MTddDQo+Pj4+PiBbIDMwMDUuMDk0MDYxXSB3YXRjaGRvZzogQlVHOiBz b2Z0IGxvY2t1cCAtIENQVSMxIHN0dWNrIGZvciAyMnMhIFtrc29mdGlycWQvMToxN10NCj4+ Pj4+IFsgMzAzMy4wOTM5MTddIHdhdGNoZG9nOiBCVUc6IHNvZnQgbG9ja3VwIC0gQ1BVIzEg c3R1Y2sgZm9yIDIycyEgW2tzb2Z0aXJxZC8xOjE3XQ0KPj4+Pj4gWyAzMDY1LjA5NDA2MF0g d2F0Y2hkb2c6IEJVRzogc29mdCBsb2NrdXAgLSBDUFUjMSBzdHVjayBmb3IgMjJzISBba3Nv ZnRpcnFkLzE6MTddDQo+Pj4+Pg0KPj4+Pj4gZGViaW5hMSBpcyBvbmUgb2YgdGhlIGJveGVz IEkndmUgcHV0IGludG8gcHJvZHVjdGlvbiByZWNlbnRseS4NCj4+Pj4NCj4+Pj4gSVNUUiB0 aGlzIGlzc3VlIGhhdmluZyBzdXJmYWNlZCByYW5kb21seSBiZWZvcmUuIFdpdGggdGhlIHJh bmRvbW5lc3MgbWFraW5nDQo+Pj4+IGl0IGRpZmZpY3VsdCB0byBpbnZlc3RpZ2F0ZS4NCj4+ Pg0KPj4+IEluZGVlZCwgaXQgc2VlbXMgdG8gaGFwcGVuIG9uIG90aGVyIGJveGVzIGFsc286 DQo+Pj4NCj4+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0 L3Jlc3VsdHMvaGlzdG9yeS90ZXN0LWFtZDY0LWFtZDY0LXhsLXFlbXV0LWRlYmlhbmh2bS1p Mzg2LXhzbS94ZW4tdW5zdGFibGUuaHRtbA0KPj4+DQo+Pj4gQXQgbGVhc3QgZG9lc24ndCBz ZWVtIHRvIGJlIGV4cGxpY2l0bHkgcmVsYXRlZCB0byBkZWJpbmFzLg0KPj4NCj4+IEhvdyB2 YWx1YWJsZSBpcyBpdCB0byB0ZXN0IHN5c3RlbXMgdXNpbmcgYSBrZXJuZWwgZnJvbSAyMDE5 Pw0KPj4NCj4+IENoYW5jZXMgYXJlIGhpZ2ggdGhhdCBidWdzIHdoaWNoIG1pZ2h0IHRyaWdn ZXIgYXJlIGNvcnJlY3RlZCBhbHJlYWR5Lg0KPj4gSU1PIHRyeWluZyB0byBmaW5kIHByb2Jh Ymx5IGtub3duIGJ1Z3MgaXMgYSB3YXN0ZSBvZiB0aW1lLg0KPiANCj4gVGhpcyBpcyB0aGUg a2VybmVsIGZyb20gb2xkc3RhYmxlIERlYmlhbiBkaXN0cmlidXRpb24sIHdoaWNoIGlzIHN0 aWxsDQo+IHN1cHBvcnRlZCAodW50aWwgSnVuZSAyMDI0IEFGQUlDVCkuICBJIHRoaW5rIGl0 J3Mgbm90IHVubGlrZWx5IHRoYXQNCg0KWWVhaCwgYnV0IGF0IGxlYXN0IHRoZSBpbnN0YWxs IGtlcm5lbCBkb2Vzbid0IHNlZW0gdG8gaGF2ZSByZWNlaXZlZCBhbnkNCnVwZGF0ZXMgc2lu Y2UgMi41IHllYXJzIG5vdyAoY29tcGlsZSBkYXRlIGlzIHJlcG9ydGVkIHRvIGJlIDIwMTkt MDktMjApLg0KQW5kIHN1cHBvcnRlZCBkb2Vzbid0IG1lYW4gdGhhdCBhIGtlcm5lbCB3aWxs IHJ1biB3aXRob3V0IGFueSBmdXJ0aGVyDQpmaXhlcyB1bnRpbCB0aGVuLCBidXQgdGhhdCBm aXhlcyBhcmUgYXBwbGllZC4gQW5kIHRoaXMgc2VlbXMgbm90IHRvIGhhdmUNCmhhcHBlbmVk IGhlcmUgZm9yIHF1aXRlIHNvbWUgdGltZS4NCg0KPiBwZW9wbGUgYXJlIHJ1bm5pbmcgdGhv c2Uga2VybmVscyBpbiBndWVzdHMuICBJIHdvdWxkbid0IG1pbmQgdGVzdGluZw0KPiBuZXdl ciBndWVzdCBrZXJuZWxzLCBidXQgc29tZW9uZSB3b3VsZCBoYXZlIHRvIHVwZGF0ZSBvc3N0 ZXN0IHRvIHVzZQ0KPiBEZWJpYW4gMTEgd2hpY2ggc2hpcHMgd2l0aCBrZXJuZWwgNS4xMC4N Cg0KSSBkb24ndCBtaW5kIHRoZSBiYXNlIGtlcm5lbCB2ZXJzaW9uLCBqdXN0IHRoZSBsYWNr IG9mIGFwcGxpZWQgcGF0Y2hlcy4NCg0KQW5kIEJUVzogdGhpcyBpbnN0YWxsIGtlcm5lbCBz ZWVtcyB0byBsYWNrIGFueSBYZW4gc3VwcG9ydDoNCg0KWyAgICAwLjAxMjkxN10gQm9vdGlu ZyBwYXJhdmlydHVhbGl6ZWQga2VybmVsIG9uIGJhcmUgaGFyZHdhcmUNCg0KDQpKdWVyZ2Vu DQo= --------------jWz0ht1gsNKpQhMFAZCXgsm4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------jWz0ht1gsNKpQhMFAZCXgsm4-- --------------L0YP2svfan965Yp1ORqcMmGU-- --------------gWu6KJAIxwi4EXtrWabMhoVn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJvvXUFAwAAAAAACgkQsN6d1ii/Ey+m kQf/QvKcaDXqLFdFG6/DSCrz6NOStclJ/ZyJko2vloFD6beebVIkAYWH7erZST5P53GFgu4CAbp0 pX2+TDVH3P8kp0ek/dT+cbzbZTdz9AMoQCOMtmGpZy8bXDjtO5K6M1p04vL75aioc3hxG/KvFsfO 0mqpvalT+dSckp9/++9DHsizmo3c43x+qFDrEwi8bgzIX2OE4MyGrhA+N2EqHj3jHqA/5GTFVDFs yBcFcCDIHKFENuEjOvn+678PzwaSCxuPmOkx152PYRlUHyYqCX89e36GA8+3iCknEX/UNNwIOr1j VWHZ35e3EUwYY+psXsTS3dFv8hPDQDdSgPzq5UPRBA== =cxpg -----END PGP SIGNATURE----- --------------gWu6KJAIxwi4EXtrWabMhoVn-- From xen-devel-bounces@lists.xenproject.org Mon May 02 11:22:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 11:22:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318792.538709 (Exim 4.92) (envelope-from ) id 1nlU7z-0004Vj-2w; Mon, 02 May 2022 11:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318792.538709; Mon, 02 May 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU7y-0004Vc-Uj; Mon, 02 May 2022 11:22:06 +0000 Received: by outflank-mailman (input) for mailman id 318792; Mon, 02 May 2022 11:22:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU7x-0004VW-3Q for xen-devel@lists.xenproject.org; Mon, 02 May 2022 11:22:05 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 167c2de6-ca0a-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 13:22:03 +0200 (CEST) Received: from mail-bn8nam11lp2176.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 07:22:00 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6979.namprd03.prod.outlook.com (2603:10b6:510:169::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Mon, 2 May 2022 11:21:56 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 11:21:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 167c2de6-ca0a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651490523; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=y7NXiw3N0a8BkFT1wr6SrlMM7QI5ROjAHEcLs6Gb2qk=; b=Yjbml0IyFf3rWv5jeJwcaRlVMeWu/1eWty5zuc9PnTEVpVJ7LZSytySD NxrdeCyyq9ZiwnHjPtmauKZzKXNAVJtPsg3lSx0itVQozic6PoajljNif aH+q+cOlEt98VRnx/7y0Bwe1g1Y2OmdtQUYwxHuZFLkpOVKrDG71JwzVb M=; X-IronPort-RemoteIP: 104.47.58.176 X-IronPort-MID: 72835104 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:AMkHPaNInSXFABvvrR3RlsFynXyQoLVcMsEvi/4bfWQNrUoghDxWm mYYXGjUb/eDZzbxKt4lady1p0NU7cKGzYMwQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2 tNws6yUE0ATELDRnMIeQTQHKCVZMvgTkFPHCSDXXc276WTjKiKp6dM+SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7EdaaHPuiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33CmkLmQA9Dp5o4JuwXny5gZt+oS3c9DbcZuSGvtwrmOx8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FOvZsnwWVu/unHsg/IHc99ZEul/4gfdzKPRul+dHjJdEWAHb8E6vsgrQzBsz kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkinogpLeEJtsuDIJA== IronPort-HdrOrdr: A9a23:LhZ8MKPcFIIjIMBcT0j155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DsrvZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolCs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REIGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUETA9OL8y7qvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wM9HdwGOt15Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexrwqEH3QSuvyWqOLtB0B1v977jK3Z4S2MaGPLQ18bpaou W1bLofjx9+R37T X-IronPort-AV: E=Sophos;i="5.91,190,1647316800"; d="scan'208";a="72835104" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hl1VSg/8w2F7xDVNLwgDdrju1d/g7nhltjkCcjzYG6lv+c7roGKbhvJcuLcX6SdRzklDwy+Qz3pp0TVM1NwV/EVcvMvyfYtlS/j8YlwZvu1ycLxhY3aCdptkb0Qg9ImgdyqP3n45UrVzArYRTETzDLJ2WfBGzuQL6kjCwP3QiytDuZmeeSghi3QWFmt+LhD1AtlhKQYVjCVxaXgsdI7dy+dAiNmXQwHZBpcHJLjQY5kVRMyL7YDAWXxS9rh9jDraOB0DUyQyLld6s29NEu6AGhbeRcuWdU5zRgOcoJwbkF1PxwdK7Cx+15yYvb2NT3hh4rMj8ulZ0iucteSy6VmVnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9V0//fxVELBYtkHnCNEllJOvAOLy25v9knmvwKQPEvE=; b=DlZ96Qncrsw+iBmOEQU0ZFEpmLaH2V/kYIePjyI649KzAbRV1/GwEQn5xbU49Qz+HbOw7VI8dui/W/DCGReu49XvM2MN38miw/h8n2Xkzv6+H580uIZDglmBlDHURb/inAc9viY6bDN5qLpynS5VyYMoY4fMm6XiitE+jbqo4IyDh2Z9uklYpG/5s8CRjY35ZxJ4vWaB3LZyv3WvtLeGqlgEbm8yqZbz3OiQoPcDClTe9cYP9SSOSeAwWx7WNvdSOeMuGceZWDX0gn9B1ymVbyP9MTfi5M/aeVrRiPwcr6M0DWb3vvahBfx3U0EV/7/16FvdKktNHiacOahsvP6XHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9V0//fxVELBYtkHnCNEllJOvAOLy25v9knmvwKQPEvE=; b=U7+nFcJCMg+saS9TXXOI5gZ6g7RGJfQF9hKByNAoy75sC8IeKYFnDQdA7eLxr2p1D2h9D7CcIEZTjglVYnLIDOwrUz5ODCKvKKbn1XCbzoU1LE20LuP5XaqrISyFwE+fIGJvExP3Xd4t9XxhyYwsXF1p3E9YfO2IHdiivC3kdUA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 2 May 2022 13:21:51 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH v3] x86: avoid SORT_BY_INIT_PRIORITY with old GNU ld Message-ID: References: <994cfe5b-21b8-c59d-8160-792975304604@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <994cfe5b-21b8-c59d-8160-792975304604@suse.com> X-ClientProxiedBy: LO4P123CA0056.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a0a25c4-4b3c-47ee-4d2b-08da2c2df754 X-MS-TrafficTypeDiagnostic: PH0PR03MB6979:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IQRQCcUf3NmJa4nTxRr/eLsET6PRBpaIXldTGceRoS5VnmSkbffigKXq99cQSndZ5kkYaAis8jEoAbHFZkqVuSI50y+LoGRrCPBpDRpFV9mJ+Kn6t0MkQCShz35/fbE5THrf/g7sYUIRHr2osFkwsdzwcmtSZkAu2dZD2op8Fh66nu3VV6N+0uYk1lSbS5lGOeErYHFr3y8M52eORUMNzOyDSlQ1R6W0pFtex8GDSNrOehsJ5Etd1KzkDA5imjR0O5P4az24cObeXfJbG4vgx0s62Sja7Df5G22IlCz1q8btZCYu+Nti1z8+Q4ejFPqLHRfWSyQh1jctFaO2+yTs7zfuG7Lfpyxrf5bKW0C/Gs9dmGjp4gNAC2aqgFCnQ3ME9DJ/X9dX2+BnLnIlh+fye7JU2go7pws2RB2UeUc6VRfLO43dRPPPevD4k237fh6OU+5VJuYgltEQ2z+RjC+BCOtPmSrJA5Dtlh6on5RNKjPLYrgBjXsYIP2OA5s+/0jB6HoEps2M9xGUIfnx77rQkFwjokVaKwOv/koJ3WkWyqQPbnXNmTX7HKhVfXOsLp5PTuOcvPA1KENuErG/xxvMYta9HlXp2yiU0UF1nHnFQo6wHTi6z6gKwoFt/vyxE+qR2Xnuuy8cXzv9l4V4aiJt4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(86362001)(66476007)(66556008)(186003)(8676002)(4326008)(66946007)(6486002)(508600001)(6506007)(6666004)(9686003)(26005)(38100700002)(54906003)(82960400001)(316002)(6512007)(4744005)(8936002)(6916009)(2906002)(85182001)(5660300002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGp4UFErNjhaaHRPQXpWekZHbHdzUmRIMDdjWGNlcTArdHRyZkJLUjNoNkk4?= =?utf-8?B?SThMYmI5M2FTa09RQVczSHpxNU9pU3ZFVGRKQ2h4WVpLZUFRU0NOQmdVQjdN?= =?utf-8?B?REw5ZnZXa2ZpN2VXZWlvcVZ4ZmtGL2ZRRE5yemJPNHZkYlJ0N2NPUlE4TzNt?= =?utf-8?B?d25CdTg5ZGsvTVlQYUVVRmc1ZForMm5rWVVqT3E0cktpZ3lVVU1lc3h3RFEy?= =?utf-8?B?WTdSWVJqVlhzMStCRVpPMlZKTDNvOVUxczQxR0k5bEtBZktVa3VHNTlNMWpa?= =?utf-8?B?U05nQ3A3TUxEWW5mUW5WTEdyTUZxdUc3UmF2NEdnVWhzTWpoVUJxMG1wWVZG?= =?utf-8?B?RnMxOEFVaHdzNWl3UjFycWdQNGVEc241SVMrSDkxWloyZnhDeGNMR0F6dzFa?= =?utf-8?B?SDQ1S2svalp3QUZLYkpYaEt5TXN2dTdSeU1ldVpwNUFBMy8rUkpPRFh6RndL?= =?utf-8?B?RG90U2VkQXd5b01ZZlR3TWRrVjhsQkNaZmdTU1dkZTVkSVEzaGZqR05mTDFy?= =?utf-8?B?TXNDVGRtcHR1NUhnWXRZUzBnKzQvaXVaMFNlL3htcy9hZS8vMEVTaFY5a0NR?= =?utf-8?B?S1MwWVVsL2VlYmVVb0c3ZjlLTnNXTGJjVUowd1I3ZDVIeEE5N0M2ZGEwTE9k?= =?utf-8?B?VS91R0RRdnNVWVZRazh3MGIyRVNaNkFUTlBkNTlYSjhVZTlZdmNLQlNvYmRu?= =?utf-8?B?cUJVS3Fud0p3b3lBaFgrY1gxb3ZMNnhpU0MwZVFpRUo1UXVmU3VaeHRnWUZZ?= =?utf-8?B?RE1wUVo3bGplYjlwejNBdkg3MTJGcUVMUFpIOUY2VXYzTGdvWmRrVDI4aFI4?= =?utf-8?B?YUFLelkyakZNQ0Jwekg4bTdBTXgzWGtseVJKMExYT3dIY1VXTzBmWTNVMzFJ?= =?utf-8?B?QVVraWswZjJ5NEJOY2Q1OEo1bTRvbXorNktQeHp4bytjK2ttT1piSld3RDU5?= =?utf-8?B?a0FEKzg0NExXVGZLRnlQQXF3S1JLZ3k3Q1NEM09LQi8zbWhMUmoyM2htM1hz?= =?utf-8?B?VmtSTHlsM1dXVTZwRDBKOS9HSWlBUlRuRmsrMjBoRW9hQXVWR0ZPeE96VXcv?= =?utf-8?B?REdnV2FBUWxNcEp5ZnJpYnk1cDA2eTRlQWg0YUI1M2RRNVduZUN5elhEYTF5?= =?utf-8?B?NkRFY3NJejFER0tsZVEyTE5vL20wZC9kS2dCVXZsbHhZSlNGeUU3K0dORllQ?= =?utf-8?B?cFlBeEtxc1BaNTdaVUxPSVVaUlYxcnFFaG0yZ2Y2R2tZU3dzNkJpT3djUHRx?= =?utf-8?B?RWQ3SmdHQ3JwOXljdElrUDlaT3ZZQXliVjJSSFBoSmZLT2FXQWRsNkxCR3N4?= =?utf-8?B?OUVxRUZEZ0FRZ3JZYWR4a2gxUUk5WXI4Tm5IZ2pYK3hOK3Fndkp4UFdUNUxH?= =?utf-8?B?QU9CZ0ZlV3BUZWhGZnN3RmdsSjRNUjk4YXl0elYvTE1Gdy9uTm8xamIxYzdl?= =?utf-8?B?NFpzalZBUTlxVUNRMWJFZHpkcC9yWUFtU0JsMDJtNDlpOUZENnFlNTBlVVJZ?= =?utf-8?B?R2RRUk1uRDFjUy85dDdEOW8rbmxQalFreElka3EzM0VNNEtrUW04cVYzZDJ3?= =?utf-8?B?Z0tlWTJ5Q28xMkpPeGZKS3E3WUxzRURNaTZOMkYzZllBRW9iVG1VUG42ZVcr?= =?utf-8?B?cVQ3aVNaTmZrYXRaYzZjSlBxckpkVEVWOHdlaXhTME9NYlVZTEVCbkZtRXF6?= =?utf-8?B?WmFMTlNvMzRLR1VJVVZvMHZSTUxPTkpTdTkyUEY3U1hYRkhFRHpKM0lZdlpp?= =?utf-8?B?WHpSYVZyUTZpNUZWR05HNVJtWVBzS1FmUVBMWjFTbXZoc05nOFdNNlVpM1U3?= =?utf-8?B?RU0zSk0vSjk0U1NmRDh5UFB5Qk5haDZETVAvMWJZUE5aYjhKQUxMTjFTQ3RP?= =?utf-8?B?M0Z1UU5Nd2xNeHArQjIvT05GeXFDK09JZEkvbVJGc1FNUmhUWHRLNnZkcjFT?= =?utf-8?B?TWd6MVRGbmMwYmVnenREYlRsZWNIdDlzRFo1dFNhd2E2Umwrc1ZoaDUvdk5t?= =?utf-8?B?Zk5JT0J3YnFNU013WG9BWjhUcnd1RGtqMndQbjlYb2hXOWNVT1dwUjdsTDMy?= =?utf-8?B?U1ZSK0pVMnNGVmkveTVmeUZXenJiY2NRY1BtQ2ZXRlVCWTFvdlQ5bWp0VFlB?= =?utf-8?B?dFhWbm42eW0xM2JYcXNvQXExRWYweEF5YUowZXV3S2k0Yk1iYllqc1NFR1dQ?= =?utf-8?B?dDV4ZlFUM2hJN1NyN0RBWGkrWVhhSXZLNG4vWGJyNE5aQjNKaEhQMDFtdnVQ?= =?utf-8?B?cVR4UFZnZld1Z2I1NmZFUkRmNVIwaVgzR1ZTUCtVczBhNEpXVFZNN2FrRGVH?= =?utf-8?B?eHEyYkxHaTF6OWRJWktUdjhodmZpdU9tLzZUREVNWlhBTTRRb0tka3ByQ2ln?= =?utf-8?Q?EHwyOvKlQWb69C4U=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0a25c4-4b3c-47ee-4d2b-08da2c2df754 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 11:21:56.2244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ofHH5L7W2SF/BL3cDuItVsUzrvoCBIHHoIMqRr3UXJF+Nbse8QvCjEV2tIw+k9P6Hf7CyLdWOf0Iz7GRlP9c4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6979 On Mon, May 02, 2022 at 09:09:46AM +0200, Jan Beulich wrote: > Support for this construct was added in 2.22 only. Avoid the need to > introduce logic to probe for linker script capabilities by (ab)using the > probe for a command line option having appeared at about the same time. > > Note that this remains x86-specific because Arm is unaffected, by > requiring GNU ld 2.24 or newer. > > Fixes: 4b7fd8153ddf ("x86: fold sections in final binaries") > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 02 11:23:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 11:23:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318797.538720 (Exim 4.92) (envelope-from ) id 1nlU9E-00054k-CO; Mon, 02 May 2022 11:23:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318797.538720; Mon, 02 May 2022 11:23:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU9E-00054d-9X; Mon, 02 May 2022 11:23:24 +0000 Received: by outflank-mailman (input) for mailman id 318797; Mon, 02 May 2022 11:23:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlU9D-0004VW-Jm for xen-devel@lists.xenproject.org; Mon, 02 May 2022 11:23:23 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 463404c8-ca0a-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 13:23:22 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id s14so12208053plk.8 for ; Mon, 02 May 2022 04:23:22 -0700 (PDT) Received: from localhost ([122.162.207.161]) by smtp.gmail.com with ESMTPSA id n5-20020aa79045000000b0050dc7628143sm4462414pfo.29.2022.05.02.04.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 04:23:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 463404c8-ca0a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wd+0sm020ywREmAEDmZTN4FU9xTZz6tewAiOtvcc27Y=; b=Oplf38im4xZjzpTjsnGoRozUCzjrsyFGIvFGhnecRZBlLgQ/5PPKMeg/uMWOvhOaeQ 41DwSjKqWbtx1xKUBUAK85yNkuTaiJhr0EhaMPA5iPrhDo/kYtqlSMyZ2TJbsOClbXfK NW5KAnrJJ+/5xzJLOtIhs/3rNC5xgq3dIv97sHoRVX0rDX1Ii7t7hqjh0D4qP6XenpeL 2yPfKwKjKWsI81uU0jZPLWiUpqTv09JeHVumSiJUTSBu399UQMmCclzgV8q423ZAU56H PwWCnvciJqFRNaRYla6dv9zXcb2+hJxglunW+9aMgkmkY+d6KcglQgjO/TWldbwlRtnX 5BGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wd+0sm020ywREmAEDmZTN4FU9xTZz6tewAiOtvcc27Y=; b=M0PHgFHFa5NmX+ZExdF+DhD2wqBe1eo8yHhjeWybIPQu0pzaI/Z1msQf2Rgu4Y2FH7 /JFt8Ts2xHDLqAC4mThTMtJgwyQ9xDPq5yWCG8Yb/MNiMnPT/EApMaegVVk/+I0OzNHg +JIwuA6hWEEVCW4RhesJh9Q/3G3KbDK7UcSdRYY1VlDtLydFEkQaiA4JnFA6migh0g18 JyLDYCx4fmoZF5aTRZr+CWhIfDafAusaLo0BE+cVgGBSRoKOeD8Rgmukzc657FSIakk4 qVFzTzcrpMbr5ZxlPs5VQNLs8QVIb6qDB/MaSOJypNYwAyuKRcSMCoC9BC2ojc9NDgXi O0Dw== X-Gm-Message-State: AOAM532QICiGxOQzjyZwWqitsbnt/P4DxzO/PNFoERMhl4oABQ0P4r59 1LjVQM7W79dcxJZQKcje89TsDw== X-Google-Smtp-Source: ABdhPJybRPCwd/MKyLufyibbFEM//bzJHfpwkNeJeEzGpy4x2DGYeSxQkF155lrKGRrVmCWNi2/DAQ== X-Received: by 2002:a17:902:e804:b0:15e:a5cf:676 with SMTP id u4-20020a170902e80400b0015ea5cf0676mr4257844plg.144.1651490601232; Mon, 02 May 2022 04:23:21 -0700 (PDT) Date: Mon, 2 May 2022 16:53:18 +0530 From: Viresh Kumar To: stratos-dev@op-lists.linaro.org Cc: Stratos Mailing List , Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Vincent Guittot , Mike Holmes , Wei Liu , xen-devel , Juergen Gross , Julien Grall Subject: Re: Virtio on Xen with Rust Message-ID: <20220502112318.zvj4upxomvpi3zvm@vireshk-i7> References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414091538.jijj4lbrkjiby6el@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 On 14-04-22, 14:45, Viresh Kumar wrote: > Hello, > > We verified our hypervisor-agnostic Rust based vhost-user backends with Qemu > based setup earlier, and there was growing concern if they were truly > hypervisor-agnostic. > > In order to prove that, we decided to give it a try with Xen, a type-1 > bare-metal hypervisor. > > We are happy to announce that we were able to make progress on that front and > have a working setup where we can test our existing Rust based backends, like > I2C, GPIO, RNG (though only I2C is tested as of now) over Xen. An update to this, I have successfully tested GPIO backend as well with this setup now and pushed out everything. - GPIO required two virtqueues instead of one as in case of I2C. - GPIO requires to do configuration exchange as well, while I2C didn't. - The latest code supports MMIO V2, modern. - The Xen vhost master is fully device independent now and a device type can be chosen based on just the command line itself. It would be simple to test RNG or other backends with this now (we just need to update "enum VirtioDeviceType" in vhost-user-master crate for this, with device specific information). Of course we need to emulate device in Xen too. Hope this helps. -- viresh From xen-devel-bounces@lists.xenproject.org Mon May 02 11:45:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 11:45:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318805.538730 (Exim 4.92) (envelope-from ) id 1nlUUe-0007e8-4E; Mon, 02 May 2022 11:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318805.538730; Mon, 02 May 2022 11:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUUe-0007e1-1N; Mon, 02 May 2022 11:45:32 +0000 Received: by outflank-mailman (input) for mailman id 318805; Mon, 02 May 2022 11:45:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUUd-0007dv-2v for xen-devel@lists.xenproject.org; Mon, 02 May 2022 11:45:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bd799b4-ca0d-11ec-a405-831a346695d4; Mon, 02 May 2022 13:45:28 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 07:45:23 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4200.namprd03.prod.outlook.com (2603:10b6:a03:7b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 2 May 2022 11:45:22 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 11:45:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bd799b4-ca0d-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651491926; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VPL3GxdKtXSiM0rjukpXDHiYIzYigfafgYo7AuFQlSo=; b=ajl5L+YXriBBCgj7XSOVH2qxoHMSbK7yDaR5R/RhfizBOAtTIJF6UQVL GdHG9Ds3NqLHwNHqn12HHbtmJFvKyjbLPEet1K4N+l4IbweRntbHHqfQf ffZL6GKUmxsX/SNflQd4EtJyCNWyRI4kEiqB3F6OyQCtZn7wjaGjgM8NS A=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 72836414 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7i+4FKpeTlZUyUJQeuUWJqfwuZleBmItZBIvgKrLsJaIsI4StFCzt garIBmEO/eLNmvxctsnPNuz8hkPuMDdx99nGgRo/C4xECkX85uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 Yqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBLI/oh8sWUUdkOAZzMvdkxfjpCla6mJnGp6HGWyOEL/RGKmgTZNVd1sMpRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp3pwm8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK//psvTSKkGSd1pDtNpnMdOCBBvl+oU3Ci n/E2mTHPzQzYYn3JT2ttyjEavX0tSH0QoUJD5Wj6+VnxlaUwwQ7ChcbSF+6qvmRkVOlVpRUL El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL86QGDB3NCSSVdcts4r8wnbTsw3 1SNkpXiAjkHmLqOUm6Q7avRpD+3OC49PWIEfTUDTwYO/5/kuo5bs/7UZtNqEarwgtirHzj1m miOtHJn3+lVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:Nhf8WKjAkgHIPrM+tslBJqE8bnBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeSWCQfkNIN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp D52+pT5fVzp/QtHNNA7dc6MLWK41P2MGLx2UKpUCLa/fI8SjvwQ6Ce2sRG2MiaPLo18bAVpL PtFHtliE9aQTOaNSTJ5uwHzizw X-IronPort-AV: E=Sophos;i="5.91,190,1647316800"; d="scan'208";a="72836414" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0NHzMoFKDHqgT6DjCtUoOrHWmdv7BqPTcwMJu35PBPuunn4xKPz6Xf2oBJ/+sMtHXSW2SqPmIq83FFPZNl0OH1G+ebKt72pzSKC/8jTtN8rWM2S3VU0kk/z839hMIZ450XLXZb5YcbqhKyyMsR35hL232SveFFmEQD+zYVJtCBTQv5xRSB5xkSv/QyndXbg73Tzm7DpSLj/QUIuvW9K2dIvOlfHoM7wyJnD4gsp5+596FlKCWeyT+Smdz/3vEwAe331XRJyy+Hi3Q60vPSJ3mB865vGQdl5dleN3niq3MI7YfieSluMDX6JAZd1mCF3tCy89id07EJynBSvvJLZkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HnbsPNuB7Eoa8O7wY1LGJ/wJR9m6qiA5YTokPsC2WC4=; b=lTwLJ1qiMASzRwBnACtrL+DheRE7yPjhEXKZyxq4jpa99kNI1cPhIBY5x5CNLpxi0UigDe92/IvMHxeXG4CPp1hY/PEdInneYetIxDUrjo+Ac/50TUX/j8iY+viBukigXbsDLyvYySAUuntvgG7NdhmPqr4y+LnmOa5b7HjkZriALN9aLAtonRfxx3oxbUeIQ+M+Wc6oGZUntvZje5kPI3tFKdrJaRbKdhAZdzI/58wrBBR9W3tAQeFuOvEqDMsZ7ARyytfHqjSwlPJkz1sySndcNyYWA6jhu7w22ThvNL5ZgTNz65VoJU5LKFwCyE3YQj0sVxdJ5RbuTmowqowESw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HnbsPNuB7Eoa8O7wY1LGJ/wJR9m6qiA5YTokPsC2WC4=; b=cPWEh50vj3rHY36gkxAmksXCHCinaIH/LxI58Gp+RGKfptxKR+hDeh3ECbmPfNkzaoIBCRkO22pKpDGDbqoix03FDSt6LatzZ3O71zH6x66FdPZkXgD0Ee31hIoF7q3xRikbnKk0QhGbrhshRjquSTUWL9Dwj3Q49SoG+9BiEWU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 2 May 2022 13:45:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross Cc: Jan Beulich , xen-devel@lists.xenproject.org, Andrew Cooper , Boris Ostrovsky , osstest service owner Subject: Re: [xen-unstable test] 169819: regressions - FAIL Message-ID: References: <25a16b3e-e235-698a-452e-bb87920adc89@suse.com> <7ddc783e-cf0e-4a16-dbec-8c45fd603b9f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0191.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28ab218e-674c-478c-71f6-08da2c313d0e X-MS-TrafficTypeDiagnostic: BYAPR03MB4200:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7pT5eYhfyeZhccaEBPnRfbMHTA/zvxZllLc8i1/Au+D/Ojs5miKwuUwk1nfKc7RC8iYGRhDwfKwmA3CH4Pyxu+SwYaH7mmtnWi1k6JUwpBgfaaM8hpucr9MrRM4zgoSI1j7IOpS94Ub6aZcAsyCQeWs08YxZ1BnxfC8C9UHDXtNAXAZ+DG8tTxIi1cNYWdlL7bSwsoo8newpRP22gkdepy1/xE6qvkS6z0/rbMJI2ohs9dhjq3ZXc1xzYbr8YxvwAo9FGOE5KhqAvBkqLH/zl3pUlOYt3L3idLHY8kpTG1MViDsvlGYlqKERgqrw5Pc7kh4WYV/tyB8EA9J4yLUqDgSJs67FmR4M7CgVoa8ZK7t/T6noerZUG99uH7Bv+mE0h2RdywvIaku7QXMnrx5lZCmASVm9DiZD9ZJLF5I0zLD92EFrp4RIqUV82yjXkLOF2SxPRToeSIdQ/GW1sZB/Pjlzngbu0pKx4lbcw1XEqJTpSZerJtM70cPRINimwLrqAUzccgEkQFQvI2n4ZAd0yGqY4LA5TeMe5uNJygexnwQ8Mj3bXCcQ93NLQ4G2RWWT2ktYZ/aAcGU6f2SKRdDs0UddblbJZXjGvqe4ybgYNDeKW+A66fjHFf3dGrh4/b2jarfwHr5Abu3jtS+h+6ZChCV6ggVtedvRpYbGpUD8maYgek9hfVjsXemc9c8NeAWInEY7hcFil9LkY2t29/KzvzCrSKvMYycBkRqD7F3o3n99vRURL2rKlZ3WyhuxXqMKUdLox5Q8xIdcE9wCptDUMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(508600001)(966005)(30864003)(6486002)(83380400001)(4326008)(66946007)(86362001)(66556008)(66476007)(8676002)(8936002)(6666004)(26005)(6506007)(186003)(53546011)(5660300002)(316002)(54906003)(6916009)(85182001)(9686003)(38100700002)(33716001)(82960400001)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFMrcitCa3ZxUlZkVnJOak8zbUVhT2dabmcwRlQ5MHVqSTk2WWVqcTFIaVhS?= =?utf-8?B?NVh6c1NteHQwK3B3a2M0M1prLzVXSzlaZzJ3QzRST2lDWlZpY0J6UXV1ZTBo?= =?utf-8?B?RnpSQmREUktZeFhPUjBXSXk5V0UvZ3JqK0tmejdUeXlueGlHV1luZnN5dGZM?= =?utf-8?B?Q0wxc2dZbkxEc1BvaktZSFZ2cnZTS0Rxb3NtT2NKaFZLZlpmSGsrY3E3SENh?= =?utf-8?B?ZGVzZ3B4UXN6WEM2M0VpUjNPaWJqcEczSkQzbzQ3OW1wVVpRR3l2bElvd3hG?= =?utf-8?B?cTI1SkdlU1MvZURXY1lvSlFSaWwvaHlMbXA5aENveHI3VWoyQzRGZFZQNk5E?= =?utf-8?B?WlV1YUl2clpRVVhvT29vdC94a3UraUZOYWhFTGVqbURiVks5V1ozN0JMRlIr?= =?utf-8?B?RkYxVk9mZU1rM2N2NGs4THJ6cWdCY0FLWk54MmtzdG5CTjlnakNIZGxGVit3?= =?utf-8?B?QUljVHdEN3hTY0kxNGw5M0o5UEljOENNR2tPbjB3QmFwQWMzT0Rac1NsaHRD?= =?utf-8?B?bllySStlNGVPNjgwdCtvZHhhS3o0U1FuQmh3eXBseGxmZVVGTzUxTkhKakcw?= =?utf-8?B?SHg1YjVWR0RZMGc1VnQ2amZNOXhOY3BQZ0IyZUQydis2cXRQeUdHZnVvVU9G?= =?utf-8?B?VWJHZ3pLaHhmYW0zTWJyN3NxcjRML2kwb1QvbGV6UEsxbENtOFJtNEdWQ2Iz?= =?utf-8?B?NWFtanc5clhBdWpLS2tuVkJ2SUlMMzB0MVZCVllrZzFBS3p5dTV0OTJYR0JE?= =?utf-8?B?UDc4d3dqeUJmaC83Zjc3SnVyYS93YWtJWk9Ec0pxNkZWbEpyZnJzbElHc1B4?= =?utf-8?B?cjFPYUd2NTUxVFVRdnJveXJaSkYvY3dYYzVmQUp5YUNJcHNOaFYyYTIzdzJ2?= =?utf-8?B?WmJrTmtjY1EzV0RiRTVzRmQvNXNWVERrU2c1bmt3em9xWmc5RjdIV3pFSGpT?= =?utf-8?B?UFEyQkJ1TE13QVdncnBQWHIwa2tweTlGMHQvbFZNcTcwN29ZbklZcGdXUVpZ?= =?utf-8?B?YUF1eHQwR2duOTNKcUQreFp1RVJIaEFha1AwUGx4R2ROek9xemhjUktwWWwv?= =?utf-8?B?TzVYaERKYUtpeVVMM2RIRHliQlB5NG5zWkRGTklDTkJZSmJqcDdwUS9jVmxt?= =?utf-8?B?M2tId2lkdVRlSS81VGRyN2dhVVl6Q29CVHc3YjZGeUJldnV0VFZEazVpc3VD?= =?utf-8?B?YVdaMzh0QVo3SlVYWHBCc2dtRUNHYmNUOTRzWG9Rc2hJYS9STUJnWU41eXlW?= =?utf-8?B?TDJFQVdndXpZazJ2QzZTeElvRHlDdFU1NmQxZlZGOGhPK0cvSEFlbEpTdXN5?= =?utf-8?B?Z1VKb2xQenRZcUEyUytGVzRmVGpRSkxrL0hEVnlvRVN5YUpMck1ldDhJUnM4?= =?utf-8?B?eG5WaEVFWXNGYzFyVFQwVGZ5RkI3aXZIckloTStwQk0yY0REQXRXQUF6RFhS?= =?utf-8?B?c2Rxd2FFcUV3ZitqUkNKRTNzTFZlOVdZQUhHSkV3ZWhEUXdZWW1qY0NYNFVr?= =?utf-8?B?M3hFWkZrY2RZeTRnMzYvMDJTMXRmNXVCY21LUFZNTlVEWWRUUmhRY3JEOFZv?= =?utf-8?B?QnRqd09CdWllQkp0VUpOR0pRWVpMTXM4bzZnY2M1ZFR3NjQyRndGbDY2YlBU?= =?utf-8?B?SzFBaFZOcGVScVB1aVVTNFo3QS9ac21PTjY4YXJsSk5PL3h1cTU0S0tHbzVX?= =?utf-8?B?Nko1SjJYUmtoWGRDQnBneHM2TitZRk5iM3BmSkRRMWwxSUZoUERiNmFkL1Fq?= =?utf-8?B?a01NOStmY1l0amNMMUltZ2F0endtT01IUW85T00xU0Nlem5XdTlLZUJDcjRh?= =?utf-8?B?MHlIYndFNTBCdytydlBwVm00S1c0TndVM3dOVHMyOVBMOFgwUDh2bnU3TWJh?= =?utf-8?B?VjZMejBQUUpjTldWcUl1bjlNNkdHUzF6ZlkvQThWTVZ1akRTaGpuQzdKckhv?= =?utf-8?B?ektVY0NDdTlXS2x0UDJCYk1yNnVscFF1cTVhSTZlS1VOSVZKakd6dmt5RE9Q?= =?utf-8?B?RTJkQXIwQVpIalF0TW1Od0hxd1pRKzFkYTlrYk0yMGJ0ZnVRWDluTjlyNVho?= =?utf-8?B?UGhBMGhMeFRmWFdINHdPVFNhQ3lJSjJ2WUgweWtXWEpTMXVxT3A3eUxReFB2?= =?utf-8?B?ZFJ3WklUSFhjdnRtL1JmVlp0TjR5WjYxclZCckFVT0hwWkEyMVUvMHl5U1Ew?= =?utf-8?B?bllrQ3NzNDdESkx5OHIvb2hBUzhLK1RYZ2dFQ0tueFlnQ2hKQ1FJZ25ENGFN?= =?utf-8?B?L3FPdHgrQXBHVVNBNmJKSVhWZU5VakVJa0E5YzhPM1hOay9OV3gwVkROTU5t?= =?utf-8?B?eHdhZ3hlVzc3dVVpK3NVV1VQNUFHSHNESC9FQnR6OXNKT3Vsc3RyeCtJWDdM?= =?utf-8?Q?XWZjCkw2fOZHpvkw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ab218e-674c-478c-71f6-08da2c313d0e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 11:45:21.9628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9XT45R+WUtRpgUx36gB2bAI1T4C0tproB3quUrm3kEc1WUfmnsF01Jo8srYbgQsPlBvV7FGexBXfhWoqruOrNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4200 On Mon, May 02, 2022 at 01:16:05PM +0200, Juergen Gross wrote: > On 02.05.22 12:49, Roger Pau Monné wrote: > > On Mon, May 02, 2022 at 08:51:40AM +0200, Juergen Gross wrote: > > > On 29.04.22 13:00, Roger Pau Monné wrote: > > > > On Fri, Apr 29, 2022 at 12:37:13PM +0200, Jan Beulich wrote: > > > > > On 29.04.2022 12:30, Roger Pau Monné wrote: > > > > > > On Fri, Apr 29, 2022 at 07:46:47AM +0000, osstest service owner wrote: > > > > > > > flight 169819 xen-unstable real [real] > > > > > > > flight 169843 xen-unstable real-retest [real] > > > > > > > http://logs.test-lab.xenproject.org/osstest/logs/169819/ > > > > > > > http://logs.test-lab.xenproject.org/osstest/logs/169843/ > > > > > > > > > > > > > > Regressions :-( > > > > > > > > > > > > > > Tests which did not succeed and are blocking, > > > > > > > including tests which could not be run: > > > > > > > test-arm64-arm64-examine 8 reboot fail REGR. vs. 169775 > > > > > > > test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 169775 > > > > > > > test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 169775 > > > > > > > test-arm64-arm64-xl-credit1 8 xen-boot fail REGR. vs. 169775 > > > > > > > test-arm64-arm64-xl-thunderx 8 xen-boot fail REGR. vs. 169775 > > > > > > > test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 169775 > > > > > > > > > > > > > > Tests which are failing intermittently (not blocking): > > > > > > > test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 169843-retest > > > > > > > > > > > > Looked into this one, and it's slightly concerning, guest seems to be > > > > > > stuck at installation: > > > > > > > > > > > > Select and install software [ 481.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 509.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 545.093820] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 573.093809] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 609.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 637.093836] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 673.093957] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 701.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 733.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 761.093817] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 797.093898] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 825.093863] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 861.093865] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 889.093945] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 925.093974] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 953.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 985.093832] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1013.093855] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1049.094031] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1077.093860] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1113.093938] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1141.093803] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1177.094051] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1205.093805] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1237.093955] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1265.094004] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1301.093835] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1329.094039] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1365.093883] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1393.094167] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1429.093857] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1457.093900] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1489.094026] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1517.093997] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1553.093996] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1581.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1617.094076] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1645.093882] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1681.093896] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1709.094022] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1741.093870] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1769.093854] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1805.094017] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1833.093837] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1869.094043] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1897.094101] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1933.093879] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 1961.093933] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 1997.093952] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2025.093925] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2057.093895] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2085.094172] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2121.094018] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2149.094021] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2185.093931] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2213.093864] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2249.093951] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2277.093899] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2309.094054] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2337.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2373.094111] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2401.094132] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2437.094064] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2465.094003] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2501.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2529.094050] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2561.094027] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2589.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2625.093999] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2653.093956] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2689.094024] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2717.094093] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2753.093913] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2781.094095] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2813.093959] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2841.094117] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2877.094041] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2905.094009] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 2941.093893] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 2969.094085] watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [ksoftirqd/1:17] > > > > > > [ 3005.094061] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 3033.093917] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > [ 3065.094060] watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [ksoftirqd/1:17] > > > > > > > > > > > > debina1 is one of the boxes I've put into production recently. > > > > > > > > > > ISTR this issue having surfaced randomly before. With the randomness making > > > > > it difficult to investigate. > > > > > > > > Indeed, it seems to happen on other boxes also: > > > > > > > > http://logs.test-lab.xenproject.org/osstest/results/history/test-amd64-amd64-xl-qemut-debianhvm-i386-xsm/xen-unstable.html > > > > > > > > At least doesn't seem to be explicitly related to debinas. > > > > > > How valuable is it to test systems using a kernel from 2019? > > > > > > Chances are high that bugs which might trigger are corrected already. > > > IMO trying to find probably known bugs is a waste of time. > > > > This is the kernel from oldstable Debian distribution, which is still > > supported (until June 2024 AFAICT). I think it's not unlikely that > > Yeah, but at least the install kernel doesn't seem to have received any > updates since 2.5 years now (compile date is reported to be 2019-09-20). > And supported doesn't mean that a kernel will run without any further > fixes until then, but that fixes are applied. And this seems not to have > happened here for quite some time. Hm, so it seems the installer Debian CD for HVM guests is not updated as part of the rest of the install media update process. I've now updated those and I'm running some tests to check we don't regress. > > people are running those kernels in guests. I wouldn't mind testing > > newer guest kernels, but someone would have to update osstest to use > > Debian 11 which ships with kernel 5.10. > > I don't mind the base kernel version, just the lack of applied patches. > > And BTW: this install kernel seems to lack any Xen support: Yes, I've also noticed this, it seems like the kernel from the install media doesn't have Xen support. This is official install media, so I think it's also fine to test it works as expected. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 02 11:46:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 11:46:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318810.538742 (Exim 4.92) (envelope-from ) id 1nlUVY-0008FM-JF; Mon, 02 May 2022 11:46:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318810.538742; Mon, 02 May 2022 11:46:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUVY-0008FF-GP; Mon, 02 May 2022 11:46:28 +0000 Received: by outflank-mailman (input) for mailman id 318810; Mon, 02 May 2022 11:46:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUVX-0008F1-8W; Mon, 02 May 2022 11:46:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUVX-0008Hr-77; Mon, 02 May 2022 11:46:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUVW-0007wo-RH; Mon, 02 May 2022 11:46:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlUVW-0005k4-Qr; Mon, 02 May 2022 11:46:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vimuVdXT8cmZWG2I+obzkbveex0oQ5H6JABPgTnuLvI=; b=MPQHsRos0pD0n8nwYcUUjybN9r 2ezsoPQJPI6AEvDCMCl6AFiQ/DiA9Ukk6YIzqWXhw654nCiPU7f2941JIbws0iuE5AdyjP+kPkbfc UQD02lfLrf/v3hjZXgD0Mf3WNV+eY31R2+XSGXDJ5rMLi3I+9WR40UQIMHuzVwA1zUfc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169991: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 11:46:26 +0000 flight 169991 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169991/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 759 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 51 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 12:15:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 12:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318822.538752 (Exim 4.92) (envelope-from ) id 1nlUwx-0003X2-Us; Mon, 02 May 2022 12:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318822.538752; Mon, 02 May 2022 12:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUwx-0003Wv-S3; Mon, 02 May 2022 12:14:47 +0000 Received: by outflank-mailman (input) for mailman id 318822; Mon, 02 May 2022 12:14:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUww-0003Wk-Kd; Mon, 02 May 2022 12:14:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUww-0000Mh-I7; Mon, 02 May 2022 12:14:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlUww-0000YV-28; Mon, 02 May 2022 12:14:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlUww-0005Pv-1h; Mon, 02 May 2022 12:14:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ycLeeBmu1BtEJuSddntYe9OVOX9b1G30NayCc4J+2lE=; b=QehvnZyLZFu/2/HmpUrhg1hRor hEQofJRjG51QcHAiBiShyT/veCpa951X4YLYjFHyZww1OxHDPHkAhdPVGOvQKFNYBLeljf/mj1o8p w/0L3bluHhYvnQrQc0nNZGXl1TKvx28VkCU+TWgfl8iSFSpKs2+FqXz2v6ESX9MVaVps=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 169980: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=d0289cfa0e77f5db524393802eb5c58216b38db6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 02 May 2022 12:14:46 +0000 flight 169980 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169980/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt d0289cfa0e77f5db524393802eb5c58216b38db6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 661 days Failing since 151818 2020-07-11 04:18:52 Z 660 days 642 attempts Testing same since 169897 2022-04-30 04:20:04 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106203 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 12:31:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 12:31:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318830.538764 (Exim 4.92) (envelope-from ) id 1nlVDA-0005wv-B9; Mon, 02 May 2022 12:31:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318830.538764; Mon, 02 May 2022 12:31:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVDA-0005wo-8K; Mon, 02 May 2022 12:31:32 +0000 Received: by outflank-mailman (input) for mailman id 318830; Mon, 02 May 2022 12:31:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVD8-0005we-FI; Mon, 02 May 2022 12:31:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVD8-0000cv-DT; Mon, 02 May 2022 12:31:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVD7-0001Be-VN; Mon, 02 May 2022 12:31:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlVD7-00070B-Ut; Mon, 02 May 2022 12:31:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I13E3EkMux4Gtx1HysYIlg3iTwMvGq3b2Wm1DolzDs8=; b=lf4tvZOS3uKLgNvD9F37gG7V7J uOVmw3vs/Ef9Tgj1pRssKMh2epDM9LxTS3ryD/vXH67x+1nDRXPh7FAOq7jstWQXRTiyRn1fS7FD5 JjPPrgNl3wlw0gps7vY8fZ2AfHU63LIY3gN9ZWdbBO1m7PFJyM6XBLcNDmEG6snoy3So=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 169977: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=672c0c5173427e6b3e2a9bbb7be51ceeec78093a X-Osstest-Versions-That: linux=b2da7df52e16110c8d8dda0602db81c15711e7ff From: osstest service owner Date: Mon, 02 May 2022 12:31:29 +0000 flight 169977 linux-linus real [real] flight 169992 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169977/ http://logs.test-lab.xenproject.org/osstest/logs/169992/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 169992-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169968 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169968 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169968 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169968 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169968 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169968 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169968 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169968 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 672c0c5173427e6b3e2a9bbb7be51ceeec78093a baseline version: linux b2da7df52e16110c8d8dda0602db81c15711e7ff Last test of basis 169968 2022-05-01 17:11:06 Z 0 days Testing same since 169977 2022-05-02 01:56:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandru Elisei Linus Torvalds Marc Zyngier Mingwei Zhang Paolo Bonzini Sean Christopherson Will Deacon jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b2da7df52e16..672c0c517342 672c0c5173427e6b3e2a9bbb7be51ceeec78093a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 02 13:20:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318839.538775 (Exim 4.92) (envelope-from ) id 1nlVxu-0002N9-6R; Mon, 02 May 2022 13:19:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318839.538775; Mon, 02 May 2022 13:19:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVxu-0002N2-39; Mon, 02 May 2022 13:19:50 +0000 Received: by outflank-mailman (input) for mailman id 318839; Mon, 02 May 2022 13:19:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVxs-0002Ms-OS; Mon, 02 May 2022 13:19:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVxs-0001S5-M3; Mon, 02 May 2022 13:19:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlVxs-0003st-ES; Mon, 02 May 2022 13:19:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlVxs-0004DJ-Dy; Mon, 02 May 2022 13:19:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uTSQT1nZWyRV+dNq1fUbKaykESE98gErpbLyNLMHOCQ=; b=et87jtIV8SrEJw40GCxlDAm31U cPhuP/h5uWXlP3mAQCX821tB/DkrmzB3N5/4d6v3yWN+1QWjRFpU1qV1gwO6Ufw266XR/zShl0aqm fSzOZypc/gQLWM4+7xhOsJCYaB+hfVF69gkEzRFFFITwJSrbGodibI29G0WHa7wte4nY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169994: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 13:19:48 +0000 flight 169994 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169994/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 760 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 52 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 13:28:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:28:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318847.538785 (Exim 4.92) (envelope-from ) id 1nlW6A-0003xI-1Y; Mon, 02 May 2022 13:28:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318847.538785; Mon, 02 May 2022 13:28:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW69-0003xB-Uv; Mon, 02 May 2022 13:28:21 +0000 Received: by outflank-mailman (input) for mailman id 318847; Mon, 02 May 2022 13:28:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW68-0003wp-Aq for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:28:20 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bac7612b-ca1b-11ec-a405-831a346695d4; Mon, 02 May 2022 15:28:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 87BEE1F38D; Mon, 2 May 2022 13:28:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C2CB133E5; Mon, 2 May 2022 13:28:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iJcbFXLcb2KvFgAAMHmgww (envelope-from ); Mon, 02 May 2022 13:28:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bac7612b-ca1b-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651498098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zuiiUi4rmkBpc3obCjLsJI48yYJiqOqcT6jc8QEv1Po=; b=VHM4T8sWukaXBkuOa5aFO1MNKYsTX3RNdOW49qghwk8g2DfuAeg2khWSnll0AccNyZLnqh PZxqjOubZh2t/GIApR023WMrTCuuIdWejAcWdVmcUj0ol3nrlcPKO968kcZZ1rCeQgAYGY eDhvbNQnc3Cd/xfj5qFFeMo3k8aMLXM= Message-ID: <8a4d459d-e584-fc9a-4c81-180dc6bb57dc@suse.com> Date: Mon, 2 May 2022 15:28:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF Content-Language: en-US To: Oleksandr Tyshchenko Cc: xen-devel , Linux Kernel Mailing List , Boris Ostrovsky , Stefano Stabellini References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------e0jXTIe0I05zv0JtbPremHXn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------e0jXTIe0I05zv0JtbPremHXn Content-Type: multipart/mixed; boundary="------------OuErbI0dwjoWBwG2q9Ael6H6"; protected-headers="v1" From: Juergen Gross To: Oleksandr Tyshchenko Cc: xen-devel , Linux Kernel Mailing List , Boris Ostrovsky , Stefano Stabellini Message-ID: <8a4d459d-e584-fc9a-4c81-180dc6bb57dc@suse.com> Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com> In-Reply-To: --------------OuErbI0dwjoWBwG2q9Ael6H6 Content-Type: multipart/mixed; boundary="------------yTVUfd2MsHX5pdXhzgL6YyNm" --------------yTVUfd2MsHX5pdXhzgL6YyNm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDQuMjIgMjA6MDMsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g DQo+IE9uIFRodSwgQXByIDI4LCAyMDIyIGF0IDExOjI4IEFNIEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbSANCj4gPG1haWx0bzpqZ3Jvc3NAc3VzZS5jb20+PiB3cm90ZToNCj4g DQo+IEhlbGxvwqBKdWVyZ2VuDQo+IA0KPiBbc29ycnkgZm9yIHRoZSBwb3NzaWJsZSBmb3Jt YXQgaXNzdWVdDQo+IA0KPiAgICAgSW5zdGVhZCBvZiB1c2luZyBhIHByaXZhdGUgbWFjcm8g Zm9yIGFuIGludmFsaWQgZ3JhbnQgcmVmZXJlbmNlIHVzZQ0KPiAgICAgdGhlIGNvbW1vbiBv bmUuDQo+IA0KPiAgICAgU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuY29tIDxtYWlsdG86amdyb3NzQHN1c2UuY29tPj4NCj4gICAgIC0tLQ0KPiAgICAgIMKg ZHJpdmVycy94ZW4veGVuLWZyb250LXBnZGlyLXNoYnVmLmMgfCAxNyArKysrLS0tLS0tLS0t LS0tLQ0KPiAgICAgIMKgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTMgZGVs ZXRpb25zKC0pDQo+IA0KPiAgICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbi1mcm9u dC1wZ2Rpci1zaGJ1Zi5jDQo+ICAgICBiL2RyaXZlcnMveGVuL3hlbi1mcm9udC1wZ2Rpci1z aGJ1Zi5jDQo+ICAgICBpbmRleCBhOTU5ZGVlMjExMzQuLmZhMjkyMWQ0ZmJmYyAxMDA2NDQN Cj4gICAgIC0tLSBhL2RyaXZlcnMveGVuL3hlbi1mcm9udC1wZ2Rpci1zaGJ1Zi5jDQo+ICAg ICArKysgYi9kcml2ZXJzL3hlbi94ZW4tZnJvbnQtcGdkaXItc2hidWYuYw0KPiAgICAgQEAg LTIxLDE1ICsyMSw2IEBADQo+IA0KPiAgICAgIMKgI2luY2x1ZGUgPHhlbi94ZW4tZnJvbnQt cGdkaXItc2hidWYuaD4NCj4gDQo+ICAgICAtI2lmbmRlZiBHUkFOVF9JTlZBTElEX1JFRg0K PiAgICAgLS8qDQo+ICAgICAtICogRklYTUU6IHVzYWdlIG9mIGdyYW50IHJlZmVyZW5jZSAw IGFzIGludmFsaWQgZ3JhbnQgcmVmZXJlbmNlOg0KPiAgICAgLSAqIGdyYW50IHJlZmVyZW5j ZSAwIGlzIHZhbGlkLCBidXQgbmV2ZXIgZXhwb3NlZCB0byBhIFBWIGRyaXZlciwNCj4gICAg IC0gKiBiZWNhdXNlIG9mIHRoZSBmYWN0IGl0IGlzIGFscmVhZHkgaW4gdXNlL3Jlc2VydmVk IGJ5IHRoZSBQViBjb25zb2xlLg0KPiAgICAgLSAqLw0KPiAgICAgLSNkZWZpbmUgR1JBTlRf SU5WQUxJRF9SRUbCoCDCoCDCoCAwDQo+ICAgICAtI2VuZGlmDQo+ICAgICAtDQo+ICAgICAg wqAvKioNCj4gICAgICDCoCAqIFRoaXMgc3RydWN0dXJlIHJlcHJlc2VudHMgdGhlIHN0cnVj dHVyZSBvZiBhIHNoYXJlZCBwYWdlDQo+ICAgICAgwqAgKiB0aGF0IGNvbnRhaW5zIGdyYW50 IHJlZmVyZW5jZXMgdG8gdGhlIHBhZ2VzIG9mIHRoZSBzaGFyZWQNCj4gICAgIEBAIC04Myw3 ICs3NCw3IEBAIGdyYW50X3JlZl90DQo+ICAgICAgwqB4ZW5fZnJvbnRfcGdkaXJfc2hidWZf Z2V0X2Rpcl9zdGFydChzdHJ1Y3QgeGVuX2Zyb250X3BnZGlyX3NoYnVmICpidWYpDQo+ICAg ICAgwqB7DQo+ICAgICAgwqAgwqAgwqAgwqAgaWYgKCFidWYtPmdyZWZzKQ0KPiAgICAgLcKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgcmV0dXJuIEdSQU5UX0lOVkFMSURfUkVGOw0KPiAgICAg K8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcmV0dXJuIElOVkFMSURfR1JBTlRfUkVGOw0KPiAN Cj4gICAgICDCoCDCoCDCoCDCoCByZXR1cm4gYnVmLT5ncmVmc1swXTsNCj4gICAgICDCoH0N Cj4gICAgIEBAIC0xNDIsNyArMTMzLDcgQEAgdm9pZCB4ZW5fZnJvbnRfcGdkaXJfc2hidWZf ZnJlZShzdHJ1Y3QNCj4gICAgIHhlbl9mcm9udF9wZ2Rpcl9zaGJ1ZiAqYnVmKQ0KPiAgICAg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGludCBpOw0KPiANCj4gICAgICDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCBmb3IgKGkgPSAwOyBpIDwgYnVmLT5udW1fZ3JlZnM7IGkrKykNCj4g ICAgIC3CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGlmIChidWYtPmdyZWZz W2ldICE9IEdSQU5UX0lOVkFMSURfUkVGKQ0KPiAgICAgK8KgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgaWYgKGJ1Zi0+Z3JlZnNbaV0gIT0gSU5WQUxJRF9HUkFOVF9SRUYp DQo+ICAgICAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgZ250dGFiX2VuZF9mb3JlaWduX2FjY2VzcyhidWYtPmdyZWZzW2ldLCAwVUwpOw0KPiAg ICAgIMKgIMKgIMKgIMKgIH0NCj4gICAgICDCoCDCoCDCoCDCoCBrZnJlZShidWYtPmdyZWZz KTsNCj4gICAgIEBAIC0zNTUsNyArMzQ2LDcgQEAgc3RhdGljIHZvaWQgYmFja2VuZF9maWxs X3BhZ2VfZGlyKHN0cnVjdA0KPiAgICAgeGVuX2Zyb250X3BnZGlyX3NoYnVmICpidWYpDQo+ ICAgICAgwqAgwqAgwqAgwqAgfQ0KPiAgICAgIMKgIMKgIMKgIMKgIC8qIExhc3QgcGFnZSBt dXN0IHNheSB0aGVyZSBpcyBubyBtb3JlIHBhZ2VzLiAqLw0KPiAgICAgIMKgIMKgIMKgIMKg IHBhZ2VfZGlyID0gKHN0cnVjdCB4ZW5fcGFnZV9kaXJlY3RvcnkgKilwdHI7DQo+ICAgICAt wqAgwqAgwqAgwqBwYWdlX2Rpci0+Z3JlZl9kaXJfbmV4dF9wYWdlID0gR1JBTlRfSU5WQUxJ RF9SRUY7DQo+ICAgICArwqAgwqAgwqAgwqBwYWdlX2Rpci0+Z3JlZl9kaXJfbmV4dF9wYWdl ID0gSU5WQUxJRF9HUkFOVF9SRUY7DQo+ICAgICAgwqB9DQo+IA0KPiAgICAgIMKgLyoqDQo+ ICAgICBAQCAtMzg0LDcgKzM3NSw3IEBAIHN0YXRpYyB2b2lkIGd1ZXN0X2ZpbGxfcGFnZV9k aXIoc3RydWN0DQo+ICAgICB4ZW5fZnJvbnRfcGdkaXJfc2hidWYgKmJ1ZikNCj4gDQo+ICAg ICAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaWYgKGdyZWZzX2xlZnQgPD0gWEVOX05VTV9H UkVGU19QRVJfUEFHRSkgew0KPiAgICAgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIHRvX2NvcHkgPSBncmVmc19sZWZ0Ow0KPiAgICAgLcKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgcGFnZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9IEdSQU5U X0lOVkFMSURfUkVGOw0KPiAgICAgK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgcGFnZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9IElOVkFMSURfR1JBTlRfUkVGOw0K PiANCj4gDQo+IEkgZmFjZWQgYW4gaXNzdWUgd2l0aCB0ZXN0aW5nIFBWIFNvdW5kIHdpdGgg dGhlIGN1cnJlbnTCoHNlcmllcy4NCj4gDQo+IHJvb3RAc2FsdmF0b3IteC1oMy00eDJnLXh0 LWRvbXU6fiMgYXBsYXkgL21lZGlhL01vb2R5TG9vcC53YXYNCj4gUGxheWluZyBXQVZFICcv bWVkaWEvTW9vZHlMb29wLndhdicgOiBTaWduZWQgMTYgYml0IExpdHRsZSBFbmRpYW4sIFJh dGUgNDQxMDAgDQo+IEh6LCBTdGVyZW8NCj4gKFhFTikgY29tbW9uL2dyYW50X3RhYmxlLmM6 MTA1MzpkMXYyIEJhZCByZWYgMHhmZmZmZmZmZiBmb3IgZDYNCj4gDQo+IEhlcmUgd2UgaGF2 ZSBhbiBpbnRlcmVzdGluZyBzaXR1YXRpb24uIFBWIFNvdW5kIGZyb250ZW5kwqB1c2VzIHRo aXMgDQo+IHhlbi1mcm9udC1wZ2Rpci1zaGJ1ZiBmcmFtZXdvcmsuIFRlY2huaWNhbGx5LCB0 aGlzIHBhdGNoIGNoYW5nZXMgDQo+IHBhZ2VfZGlyLT5ncmVmX2Rpcl9uZXh0X3BhZ2UgKHJl ZmVyZW5jZSB0byB0aGUgbmV4dCBwYWdlIGRlc2NyaWJpbmcgcGFnZSANCj4gZGlyZWN0b3J5 KSBmcm9tIDAgdG/CoDB4ZmZmZmZmZmYgaGVyZS4NCj4gI2RlZmluZSBJTlZBTElEX0dSQU5U X1JFRsKgICgoZ3JhbnRfcmVmX3QpLTEpDQo+IA0KPiBCdXQgYWNjb3JkaW5nIHRvIHRoZSBw cm90b2NvbCAoc25kaWYuaCksICIwIiBtZWFucyB0aGF0IHRoZXJlIGFyZSBubyBtb3JlIHBh Z2VzIA0KPiBpbiB0aGUgbGlzdCBhbmQgdGhlIHVzZXIgc3BhY2UgYmFja2VuZCBleHBlY3Rz IG9ubHkgdGhhdCB2YWx1ZS4gU28gDQo+IHJlY2VpdmluZ8KgMHhmZmZmZmZmZiBpdCBhc3N1 bWVzIHRoZXJlIGFyZSBwYWdlcyBpbiB0aGUgbGlzdCBhbmQgdHJ5aW5nIHRvIA0KPiBwcm9j ZXNzLi4uDQoNCkhtbSwgdGhhdCdzIHVuZm9ydHVuYXRlLg0KDQo+IGh0dHBzOi8vZWxpeGly LmJvb3RsaW4uY29tL2xpbnV4L3Y1LjE4LXJjNC9zb3VyY2UvaW5jbHVkZS94ZW4vaW50ZXJm YWNlL2lvL3NuZGlmLmgjTDY1MCANCj4gPGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xp bnV4L3Y1LjE4LXJjNC9zb3VyY2UvaW5jbHVkZS94ZW4vaW50ZXJmYWNlL2lvL3NuZGlmLmgj TDY1MD4NCj4gDQo+IA0KPiBJIHRoaW5rLCB0aGXCoHNhbWUgaXMgcmVsZXZhbnQgdG/CoGJh Y2tlbmRfZmlsbF9wYWdlX2RpcigpIGFzIHdlbGwuDQoNClRoYW5rcyBmb3IgZmluZGluZyB0 aGlzLg0KDQoNCkp1ZXJnZW4NCg== --------------yTVUfd2MsHX5pdXhzgL6YyNm Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------yTVUfd2MsHX5pdXhzgL6YyNm-- --------------OuErbI0dwjoWBwG2q9Ael6H6-- --------------e0jXTIe0I05zv0JtbPremHXn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJv3HEFAwAAAAAACgkQsN6d1ii/Ey+Q 7wf+PehYviINvhAC1ekfNOs0Q6KGjE9D2H9kOMQLcKeX2gy3zubJTg3C/TufyPUzh4yJMOX7Gvuh s+fyP7xhaxnDmuwx4Ei/vxWXrgUKlVq0r5+AICVPgV+4cKQI1iW7liePuVQlK7ziYJcX+PSukuos hIg9AgbfeF+dFsZmYTEN3Aau3zEw1YGAs/UQjPQADTV9TaXbi5pSZ/RZCtigHCqAhv9Km9d/ke/1 y1ktc9BG1c/BDzECv/2xhpnODLlEzgQcityjMbo/1zNhgZNxsJfN2ESpDACVI3adzQTNxCba15Aa ysMq5XZb60uBi3w8oxaRGND+tKZlqhOIqWXadBU+kQ== =agnj -----END PGP SIGNATURE----- --------------e0jXTIe0I05zv0JtbPremHXn-- From xen-devel-bounces@lists.xenproject.org Mon May 02 13:30:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318853.538797 (Exim 4.92) (envelope-from ) id 1nlW89-0005HS-EI; Mon, 02 May 2022 13:30:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318853.538797; Mon, 02 May 2022 13:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW89-0005HL-BB; Mon, 02 May 2022 13:30:25 +0000 Received: by outflank-mailman (input) for mailman id 318853; Mon, 02 May 2022 13:30:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW87-0005HD-Gs for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:30:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 045c54b4-ca1c-11ec-a405-831a346695d4; Mon, 02 May 2022 15:30:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 24828210EB; Mon, 2 May 2022 13:30:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6E19133E5; Mon, 2 May 2022 13:30:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0M9wNu3cb2LzFwAAMHmgww (envelope-from ); Mon, 02 May 2022 13:30:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 045c54b4-ca1c-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651498222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1IDdLsFoC69G84KoVxaoVdzGHm0f4vR0NdUOvV6FFQw=; b=tvAbg8ZU0fNyytMYkqeLJYrS0If0KQzGlPf5TdOV5MrmiL/ssY5PWbHrEN4Q2PgmuHnvpY fuSZvPKQIYszVZ3YaHgUWQIVvjZKfuqO6NuAayvRG5r4CFEcjjZvNe9XBH43Co3xiMrwpN p2L7EzUb25GqXGtzfEYz/y4pniZ/teA= Message-ID: Date: Mon, 2 May 2022 15:30:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring() Content-Language: en-US To: Oleksandr , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-20-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Ddprj0nYjZO3j4Cw5iWPu6pn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Ddprj0nYjZO3j4Cw5iWPu6pn Content-Type: multipart/mixed; boundary="------------wKk70Jw8ZhozH8k1CfiTrShL"; protected-headers="v1" From: Juergen Gross To: Oleksandr , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini Message-ID: Subject: Re: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring() References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-20-jgross@suse.com> In-Reply-To: --------------wKk70Jw8ZhozH8k1CfiTrShL Content-Type: multipart/mixed; boundary="------------WmMLJHd3H0XnUv8azdUmUq6G" --------------WmMLJHd3H0XnUv8azdUmUq6G Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMTc6MTAsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IE9uIDI4LjA0LjIy IDExOjI3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPiANCj4gDQo+IEhlbGxvIEp1ZXJnZW4N Cj4gDQo+IA0KPj4gVGhlcmUgaXMgbm8gZXh0ZXJuYWwgdXNlciBvZiB4ZW5idXNfZ3JhbnRf cmluZygpIGxlZnQsIHNvIG1lcmdlIGl0IGludG8NCj4+IHRoZSBvbmx5IGNhbGxlciB4ZW5i dXNfc2V0dXBfcmluZygpLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gVjI6DQo+PiAtIG1ha2UgZXJyb3IgbWVz c2FnZSBtb3JlIHByZWNpc2UgKEFuZHJldyBDb29wZXIpDQo+PiAtLS0NCj4+IMKgIGRyaXZl cnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMgfCA2NSArKysrKysrKystLS0tLS0tLS0t LS0tLS0tLS0tLS0NCj4+IMKgIGluY2x1ZGUveGVuL3hlbmJ1cy5owqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8wqAgMiAtDQo+PiDCoCAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKyksIDQ4IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3hlbi94ZW5idXMveGVuYnVzX2NsaWVudC5jIA0KPj4gYi9kcml2ZXJzL3hlbi94ZW5idXMv eGVuYnVzX2NsaWVudC5jDQo+PiBpbmRleCAxYTJlMGQ5NGNjZDEuLmQ2ZmRkMmQyMDlkMyAx MDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMNCj4+ ICsrKyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfY2xpZW50LmMNCj4+IEBAIC0zNjMs NTAgKzM2Myw2IEBAIHN0YXRpYyB2b2lkIHhlbmJ1c19zd2l0Y2hfZmF0YWwoc3RydWN0IHhl bmJ1c19kZXZpY2UgDQo+PiAqZGV2LCBpbnQgZGVwdGgsIGludCBlcnIsDQo+PiDCoMKgwqDC oMKgwqDCoMKgwqAgX194ZW5idXNfc3dpdGNoX3N0YXRlKGRldiwgWGVuYnVzU3RhdGVDbG9z aW5nLCAxKTsNCj4+IMKgIH0NCj4+IC0vKioNCj4+IC0gKiB4ZW5idXNfZ3JhbnRfcmluZw0K Pj4gLSAqIEBkZXY6IHhlbmJ1cyBkZXZpY2UNCj4+IC0gKiBAdmFkZHI6IHN0YXJ0aW5nIHZp cnR1YWwgYWRkcmVzcyBvZiB0aGUgcmluZw0KPj4gLSAqIEBucl9wYWdlczogbnVtYmVyIG9m IHBhZ2VzIHRvIGJlIGdyYW50ZWQNCj4+IC0gKiBAZ3JlZnM6IGdyYW50IHJlZmVyZW5jZSBh cnJheSB0byBiZSBmaWxsZWQgaW4NCj4+IC0gKg0KPj4gLSAqIEdyYW50IGFjY2VzcyB0byB0 aGUgZ2l2ZW4gQHZhZGRyIHRvIHRoZSBwZWVyIG9mIHRoZSBnaXZlbiBkZXZpY2UuDQo+PiAt ICogVGhlbiBmaWxsIGluIEBncmVmcyB3aXRoIGdyYW50IHJlZmVyZW5jZXMuwqAgUmV0dXJu IDAgb24gc3VjY2Vzcywgb3INCj4+IC0gKiAtZXJybm8gb24gZXJyb3IuwqAgT24gZXJyb3Is IHRoZSBkZXZpY2Ugd2lsbCBzd2l0Y2ggdG8NCj4+IC0gKiBYZW5idXNTdGF0ZUNsb3Npbmcs IGFuZCB0aGUgZXJyb3Igd2lsbCBiZSBzYXZlZCBpbiB0aGUgc3RvcmUuDQo+PiAtICovDQo+ PiAtaW50IHhlbmJ1c19ncmFudF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIHZv aWQgKnZhZGRyLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGlu dCBucl9wYWdlcywgZ3JhbnRfcmVmX3QgKmdyZWZzKQ0KPj4gLXsNCj4+IC3CoMKgwqAgaW50 IGVycjsNCj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGk7DQo+PiAtwqDCoMKgIGdyYW50X3Jl Zl90IGdyZWZfaGVhZDsNCj4+IC0NCj4+IC3CoMKgwqAgZXJyID0gZ250dGFiX2FsbG9jX2dy YW50X3JlZmVyZW5jZXMobnJfcGFnZXMsICZncmVmX2hlYWQpOw0KPj4gLcKgwqDCoCBpZiAo ZXJyKSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgeGVuYnVzX2Rldl9mYXRhbChkZXYsIGVyciwg ImdyYW50aW5nIGFjY2VzcyB0byByaW5nIHBhZ2UiKTsNCj4+IC3CoMKgwqDCoMKgwqDCoCBy ZXR1cm4gZXJyOw0KPj4gLcKgwqDCoCB9DQo+PiAtDQo+PiAtwqDCoMKgIGZvciAoaSA9IDA7 IGkgPCBucl9wYWdlczsgaSsrKSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9u ZyBnZm47DQo+PiAtDQo+PiAtwqDCoMKgwqDCoMKgwqAgaWYgKGlzX3ZtYWxsb2NfYWRkcih2 YWRkcikpDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnZm4gPSBwZm5fdG9fZ2ZuKHZt YWxsb2NfdG9fcGZuKHZhZGRyKSk7DQo+PiAtwqDCoMKgwqDCoMKgwqAgZWxzZQ0KPj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2ZuID0gdmlydF90b19nZm4odmFkZHIpOw0KPj4gLQ0K Pj4gLcKgwqDCoMKgwqDCoMKgIGdyZWZzW2ldID0gZ250dGFiX2NsYWltX2dyYW50X3JlZmVy ZW5jZSgmZ3JlZl9oZWFkKTsNCj4+IC3CoMKgwqDCoMKgwqDCoCBnbnR0YWJfZ3JhbnRfZm9y ZWlnbl9hY2Nlc3NfcmVmKGdyZWZzW2ldLCBkZXYtPm90aGVyZW5kX2lkLA0KPj4gLcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ2ZuLCAwKTsNCj4+ IC0NCj4+IC3CoMKgwqDCoMKgwqDCoCB2YWRkciA9IHZhZGRyICsgWEVOX1BBR0VfU0laRTsN Cj4+IC3CoMKgwqAgfQ0KPj4gLQ0KPj4gLcKgwqDCoCByZXR1cm4gMDsNCj4+IC19DQo+PiAt RVhQT1JUX1NZTUJPTF9HUEwoeGVuYnVzX2dyYW50X3JpbmcpOw0KPj4gLQ0KPj4gwqAgLyoN Cj4+IMKgwqAgKiB4ZW5idXNfc2V0dXBfcmluZw0KPj4gwqDCoCAqIEBkZXY6IHhlbmJ1cyBk ZXZpY2UNCj4+IEBAIC00MjQsNiArMzgwLDcgQEAgaW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0 cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIGdmcF90IA0KPj4gZ2ZwLCB2b2lkICoqdmFkZHIs DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IG5yX3Bh Z2VzLCBncmFudF9yZWZfdCAqZ3JlZnMpDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHVuc2ln bmVkIGxvbmcgcmluZ19zaXplID0gbnJfcGFnZXMgKiBYRU5fUEFHRV9TSVpFOw0KPj4gK8Kg wqDCoCBncmFudF9yZWZfdCBncmVmX2hlYWQ7DQo+PiDCoMKgwqDCoMKgIHVuc2lnbmVkIGlu dCBpOw0KPj4gwqDCoMKgwqDCoCBpbnQgcmV0Ow0KPj4gQEAgLTQzMyw5ICszOTAsMjUgQEAg aW50IHhlbmJ1c19zZXR1cF9yaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsIGdmcF90 IA0KPj4gZ2ZwLCB2b2lkICoqdmFkZHIsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBl cnI7DQo+PiDCoMKgwqDCoMKgIH0NCj4+IC3CoMKgwqAgcmV0ID0geGVuYnVzX2dyYW50X3Jp bmcoZGV2LCAqdmFkZHIsIG5yX3BhZ2VzLCBncmVmcyk7DQo+PiAtwqDCoMKgIGlmIChyZXQp DQo+PiArwqDCoMKgIHJldCA9IGdudHRhYl9hbGxvY19ncmFudF9yZWZlcmVuY2VzKG5yX3Bh Z2VzLCAmZ3JlZl9oZWFkKTsNCj4+ICvCoMKgwqAgaWYgKHJldCkgew0KPj4gK8KgwqDCoMKg wqDCoMKgIHhlbmJ1c19kZXZfZmF0YWwoZGV2LCByZXQsICJncmFudGluZyBhY2Nlc3MgdG8g JXUgcmluZyBwYWdlcyIsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg bnJfcGFnZXMpOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4gK8KgwqDC oCB9DQo+PiArDQo+PiArwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBucl9wYWdlczsgaSsrKSB7 DQo+PiArwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBnZm47DQo+PiArDQo+PiArwqDC oMKgwqDCoMKgwqAgaWYgKGlzX3ZtYWxsb2NfYWRkcigqdmFkZHIpKQ0KPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgZ2ZuID0gcGZuX3RvX2dmbih2bWFsbG9jX3RvX3Bmbih2YWRkcltp XSkpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGVsc2UNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGdmbiA9IHZpcnRfdG9fZ2ZuKHZhZGRyW2ldKTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKg wqDCoCBncmVmc1tpXSA9IGdudHRhYl9jbGFpbV9ncmFudF9yZWZlcmVuY2UoJmdyZWZfaGVh ZCk7DQo+IA0KPiBnbnR0YWJfY2xhaW1fZ3JhbnRfcmVmZXJlbmNlKCkgY2FuIHJldHVybiBl cnJvciBpZiBubyBmcmVlIGdyYW50IHJlZmVyZW5jZSByZW1haW5zLg0KDQpUaGlzIGNhbiBo YXBwZW4gb25seSBpbiBjYXNlIGdudHRhYl9hbGxvY19ncmFudF9yZWZlcmVuY2VzKCkgZGlk bid0DQphbGxvY2F0ZSBlbm91Z2ggZ3JhbnRzIGJ1dCB0b2xkIHVzIGl0IHN1Y2NlZWRlZCBk b2luZyBzby4NCg0KPiBJIHVuZGVyc3RhbmQgdGhpcyBwYXRjaCBvbmx5IG1vdmVzIHRoZSBj b2RlLCBidXQgcHJvYmFibHkgaXQgd291bGQgYmUgYmV0dGVyIHRvIA0KPiBhZGQgYSBtaXNz aW5nIGNoZWNrIGhlcmUgKGFuZCBsaWtlbHkgcm9sbGJhY2sgYWxyZWFkeSBwcm9jZXNzZWQg Z3JhbnRzIGlmIGFueT8pLg0KDQpJIGRvbid0IHRoaW5rIHRoaXMgaXMgbmVlZGVkLCBhcyB0 aGlzIHdvdWxkIGJlIGEgY2xlYXIgYnVnIGluIHRoZSBjb2RlLg0KDQoNCkp1ZXJnZW4NCg== --------------WmMLJHd3H0XnUv8azdUmUq6G Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WmMLJHd3H0XnUv8azdUmUq6G-- --------------wKk70Jw8ZhozH8k1CfiTrShL-- --------------Ddprj0nYjZO3j4Cw5iWPu6pn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJv3O0FAwAAAAAACgkQsN6d1ii/Ey/U qQf/Ze6dNlV+TT84RD8luEgVfVlIp5m6drcCPiPgLiXo70IdUtARMhSuOzxN4IvjETj23uhS8pBY ucb5IuPOF2jWFrOjrkawlJsB6vEkwHGuaDQ+jH5E1btAVz2kQLju8/+O/6QLSylUNT4nIfugkHtI UHzi8qlZyWW6huWIW1S/3R8UMzbu3JBTrypRJQVxUdEGIYusPKtFTr99ZuvkRqTBjRbn5aBDhl2m DbYvtIZuvsKlA1/1kDBQne4o9s8nQGmmm7BALtJL5NPFoMHPBJBFVIjcR6922EMpBXeHWlfVgayw oQFIJg0SSra4lwr6UL620WJYo6qQUbzzxNp9wgbonA== =/Kr3 -----END PGP SIGNATURE----- --------------Ddprj0nYjZO3j4Cw5iWPu6pn-- From xen-devel-bounces@lists.xenproject.org Mon May 02 13:30:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318855.538808 (Exim 4.92) (envelope-from ) id 1nlW8X-0005nu-Rz; Mon, 02 May 2022 13:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318855.538808; Mon, 02 May 2022 13:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW8X-0005nn-Nv; Mon, 02 May 2022 13:30:49 +0000 Received: by outflank-mailman (input) for mailman id 318855; Mon, 02 May 2022 13:30:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW8V-0005cw-JH for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:30:47 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05be4eba-ca1c-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 15:30:26 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165149824039777.84452248297293; Mon, 2 May 2022 06:30:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05be4eba-ca1c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1651498243; cv=none; d=zohomail.com; s=zohoarc; b=A9SZyvTMQzXW6GpkH8UiD+8CzJ0tVf8HFnBxvpBVl8gicNA5L8L5/j4yL73sBDBhHspXBBJA18SoK+CUo0bjrYOLcOCqlIZBGtMHkj2FinnDOmo25HjRHk11F5WFFSVyWCuXSDmkUdVKvr+Ow/tfEJ7pwgPLfYc2KJ2F8dEWBDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651498243; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=2OapjgK/FWZM+gj7ggK7bPexCFnX17I6AnCRzh0bsHg=; b=YSJOqOGxr4w6fN0c2IysW/OTWCrUygc1pLyDaFZD7MvsNaJwWg7Myb9WZCiFyiJs0AeS7X2LKhhZgRB0pWgM2JVLXwYScgjisBdgRBwayfKgOWlXmf0FyA5LvTq1LOg6vtjUdOU1IFWh1unamxiWPY5NFgp8rbd+enivTkV9wDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651498243; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=2OapjgK/FWZM+gj7ggK7bPexCFnX17I6AnCRzh0bsHg=; b=UQrSrGsDHJLNGiCyw1kH6EIp+kllDGxeOA9hN8OTDgCsdqyWcjJjptErnQGC3OwB rB3XvehpRccpIYZkua50Cf4cW+Xs75xM+XAxO1/gGwa4PRYW8Ra41juNwEeekQHVCxl JeZW+GqbGNwv3ocmHb+eTGzDELD0U8B3YRCmTgho= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io Subject: [PATCH v5 0/2] Adds starting the idle domain privileged Date: Mon, 2 May 2022 09:30:25 -0400 Message-Id: <20220502133027.920-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series makes it so that the idle domain is started privileged under the default policy, which the SILO policy inherits, and under the flask policy. It then introduces a new one-way XSM hook, xsm_transition_running, that is hooked by an XSM policy to transition the idle domain to its running privilege level. Changes in v5: - dropped setting is_privileged in flask_set_system_active() - added err code returned by xsm_set_system_active() to panic message Changes in v4: - reworded patch 1 commit messaged - fixed whitespace to coding style - fixed comment to coding style Changes in v3: - renamed *_transition_running() to *_set_system_active() - changed the XSM hook set_system_active() from void to int return - added ASSERT check for the expected privilege level each XSM policy expected - replaced a check against is_privileged in each arch with checking the return value from the call to xsm_set_system_active() Changes in v2: - renamed flask_domain_runtime_security() to flask_transition_running() - added the missed assignment of self_sid Daniel P. Smith (2): xsm: create idle domain privileged and demote after setup flask: implement xsm_set_system_active tools/flask/policy/modules/xen.if | 6 ++++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/arch/arm/setup.c | 4 ++++ xen/arch/x86/setup.c | 5 +++++ xen/common/sched/core.c | 7 ++++++- xen/include/xsm/dummy.h | 17 +++++++++++++++++ xen/include/xsm/xsm.h | 6 ++++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 22 +++++++++++++++++++++- xen/xsm/flask/policy/initial_sids | 1 + 11 files changed, 69 insertions(+), 2 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 13:30:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318858.538819 (Exim 4.92) (envelope-from ) id 1nlW8c-0006Ad-4D; Mon, 02 May 2022 13:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318858.538819; Mon, 02 May 2022 13:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW8b-0006AW-Vh; Mon, 02 May 2022 13:30:53 +0000 Received: by outflank-mailman (input) for mailman id 318858; Mon, 02 May 2022 13:30:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW8a-0005cw-TG for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:30:53 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 093d3dc5-ca1c-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 15:30:31 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165149824255940.90777056694105; Mon, 2 May 2022 06:30:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 093d3dc5-ca1c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1651498245; cv=none; d=zohomail.com; s=zohoarc; b=gJxQ69T9LVdZdtKO2N8q9LAXswFrBctSCtlNLnPCXq8P1N7OxBxFCj/xQt/i49nDIE2ct75cyFHTBx3X9r+L0OQcV/hQtNp7L6/zkeiXM5DuiX35JjLVi+72LzBYKYY81UTPU02u9rdnhMY0FhooyLuSY/qaQ6zPspuMwej9ywQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651498245; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=BOUlgflxn7VK30Jea3//ttHn3E+JLPi4eu1nf0QHebY=; b=b1Xvyb6Wuste10sae5n5rQoO9ubnYhBIsF2iN9BvLGkglSJQRRX2Jo/a+uOiQ/6Qf1Etqek2kKyl4wl4k9FhovhXuqVMLQMyaitaQ9QtdTBvODm4tOieaQodj7OBJvy9CBIFuhLOuQevaeiBRripMe4GFs/u58QpSqs1Ra6fe9w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651498245; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=BOUlgflxn7VK30Jea3//ttHn3E+JLPi4eu1nf0QHebY=; b=ZBtCoztuGyKa8ORv9GgdDuWZ3F9fE9JYQtnbOdt3j9Crf/pSkQmj3wnPgvAH1MGP kTLi4jp58kQJXUDSxFt0mk8WRfOGOjG6lIDekt+VAqdvs2fw6eu5ef0jttvuQdk38o7 OzFmmgCHL/jF/K9kDq41QAopHC9noB9xQYFsp+jU= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Date: Mon, 2 May 2022 09:30:26 -0400 Message-Id: <20220502133027.920-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220502133027.920-1-dpsmith@apertussolutions.com> References: <20220502133027.920-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External There are new capabilities, dom0less and hyperlaunch, that introduce internal hypervisor logic which needs to make resource allocation calls that are protected by XSM access checks. This creates an issue as a subset of the hypervisor code is executed under a system domain, the idle domain, that is represented by a per-CPU non-privileged struct domain. To enable these new capabilities to function correctly but in a controlled manner, this commit changes the idle system domain to be created as a privileged domain under the default policy and demoted before transitioning to running. A new XSM hook, xsm_set_system_active(), is introduced to allow each XSM policy type to demote the idle domain appropriately for that policy type. In the case of SILO, it inherits the default policy's hook for xsm_set_system_active(). For flask a stub is added to ensure that flask policy system will function correctly with this patch until flask is extended with support for starting the idle domain privileged and properly demoting it on the call to xsm_set_system_active(). Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/arm/setup.c | 4 ++++ xen/arch/x86/setup.c | 5 +++++ xen/common/sched/core.c | 7 ++++++- xen/include/xsm/dummy.h | 17 +++++++++++++++++ xen/include/xsm/xsm.h | 6 ++++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 14 ++++++++++++++ 7 files changed, 53 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed4..b9057222d6 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, /* Hide UART from DOM0 if we're using it */ serial_endboot(); + if ( (rc = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): " + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); + system_state = SYS_STATE_active; for_each_domain( d ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 6f20e17892..36a60ce884 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -620,6 +620,11 @@ static void noreturn init_done(void) { void *va; unsigned long start, end; + int err; + + if ( (err = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): " + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); system_state = SYS_STATE_active; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..7b1c03a0e1 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3021,7 +3021,12 @@ void __init scheduler_init(void) sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US; } - idle_domain = domain_create(DOMID_IDLE, NULL, 0); + /* + * The idle dom is created privileged to ensure unrestricted access during + * setup and will be demoted by xsm_set_system_active() when setup is + * complete. + */ + idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged); BUG_ON(IS_ERR(idle_domain)); BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu)); idle_domain->vcpu = idle_vcpu; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 58afc1d589..3291fb5396 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -101,6 +101,23 @@ static always_inline int xsm_default_action( } } +static XSM_INLINE int cf_check xsm_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("xsm_set_system_active: should only be called by idle domain\n"); + return -EPERM; + } + + d->is_privileged = false; + + return 0; +} + static XSM_INLINE void cf_check xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..8dad03fd3d 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t; * !!! WARNING !!! */ struct xsm_ops { + int (*set_system_active)(void); void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); int (*domain_create)(struct domain *d, uint32_t ssidref); @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops; #ifndef XSM_NO_WRAPPERS +static inline int xsm_set_system_active(void) +{ + return alternative_call(xsm_ops.set_system_active); +} + static inline void xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index 8c044ef615..e6ffa948f7 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -14,6 +14,7 @@ #include static const struct xsm_ops __initconst_cf_clobber dummy_ops = { + .set_system_active = xsm_set_system_active, .security_domaininfo = xsm_security_domaininfo, .domain_create = xsm_domain_create, .getdomaininfo = xsm_getdomaininfo, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 0bf63ffa84..0bd4e8a4bd 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -186,6 +186,19 @@ static int cf_check flask_domain_alloc_security(struct domain *d) return 0; } +static int cf_check flask_set_system_active(void) +{ + struct domain *d = current->domain; + + if ( d->domain_id != DOMID_IDLE ) + { + printk("xsm_set_system_active should only be called by idle domain\n"); + return -EPERM; + } + + return 0; +} + static void cf_check flask_domain_free_security(struct domain *d) { struct domain_security_struct *dsec = d->ssid; @@ -1766,6 +1779,7 @@ static int cf_check flask_argo_send( #endif static const struct xsm_ops __initconst_cf_clobber flask_ops = { + .set_system_active = flask_set_system_active, .security_domaininfo = flask_security_domaininfo, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 13:31:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:31:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318867.538830 (Exim 4.92) (envelope-from ) id 1nlW98-0006yj-Dj; Mon, 02 May 2022 13:31:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318867.538830; Mon, 02 May 2022 13:31:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW98-0006yc-AR; Mon, 02 May 2022 13:31:26 +0000 Received: by outflank-mailman (input) for mailman id 318867; Mon, 02 May 2022 13:31:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW96-0005cw-Iq for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:31:24 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c3d68ff-ca1c-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 15:31:03 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 16514982461731.2977082991415045; Mon, 2 May 2022 06:30:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c3d68ff-ca1c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1651498246; cv=none; d=zohomail.com; s=zohoarc; b=XYyluWAWk4ZcGjNZS93FXUQpZDcFdnWXW+SkqJ9NviJB5/gfqV5UX/uMkGh4h8hFtwJdu3quM9JoW03+3ZZsZvvVqsS+360glZwuBt3c9p8VxOMHmX17/oawN1i8ad4CXNfS7XTa5Tsi45lNoYFELXFF35OEZuF2/oiDKBikE70= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651498246; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ZbfrC0msVBpnGXM3HwSg5QOB6cUwWUSvu8aYMxskpQY=; b=PY4CZrx7LZs3aXAUdpifPUKz6nLiV++YIgRS1fKRxF/V0IgIYNU8fhyMWBGDGI0fn3RNouEQ/xHn6AXQXgxjI4s7NlsC/HqU/EVlRobe47tEt14cDdiDMOioHwiKtTNnrL6THhASyvMB8PU13se94Lv76whPo+pOeUzEkr8QKYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651498246; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=ZbfrC0msVBpnGXM3HwSg5QOB6cUwWUSvu8aYMxskpQY=; b=W9US/JzZQMO0Xg6ORq9ycIG05LC+9yQZXTuJCItvw86hm8okUPp7T/aD9IzUAjC2 lIWh9tw265Xm+bURIs7UrfHcqYgPphEcQMiD7JWNJpS1r1GSvGW2v9+gJ6Riz8Cz5lY iEbRSTgLkebaSxU/OFlQ54fgOmmilVOGvXUkOpIo= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD Subject: [PATCH v5 2/2] flask: implement xsm_set_system_active Date: Mon, 2 May 2022 09:30:27 -0400 Message-Id: <20220502133027.920-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220502133027.920-1-dpsmith@apertussolutions.com> References: <20220502133027.920-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit implements full support for starting the idle domain privileged by introducing a new flask label xenboot_t which the idle domain is labeled with at creation. It then provides the implementation for the XSM hook xsm_set_system_active to relabel the idle domain to the existing xen_t flask label. In the reference flask policy a new macro, xen_build_domain(target), is introduced for creating policies for dom0less/hyperlaunch allowing the hypervisor to create and assign the necessary resources for domain construction. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- tools/flask/policy/modules/xen.if | 6 ++++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/xsm/flask/hooks.c | 8 +++++++- xen/xsm/flask/policy/initial_sids | 1 + 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if index 5e2aa472b6..4ec676fff1 100644 --- a/tools/flask/policy/modules/xen.if +++ b/tools/flask/policy/modules/xen.if @@ -62,6 +62,12 @@ define(`create_domain_common', ` setparam altp2mhvm altp2mhvm_op dm }; ') +# xen_build_domain(target) +# Allow a domain to be created at boot by the hypervisor +define(`xen_build_domain', ` + allow xenboot_t $1_channel:event create; +') + # create_domain(priv, target) # Allow a domain to be created directly define(`create_domain', ` diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te index 3dbf93d2b8..de98206fdd 100644 --- a/tools/flask/policy/modules/xen.te +++ b/tools/flask/policy/modules/xen.te @@ -24,6 +24,7 @@ attribute mls_priv; ################################################################################ # The hypervisor itself +type xenboot_t, xen_type, mls_priv; type xen_t, xen_type, mls_priv; # Domain 0 diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids index 6b7b7eff21..ec729d3ba3 100644 --- a/tools/flask/policy/policy/initial_sids +++ b/tools/flask/policy/policy/initial_sids @@ -2,6 +2,7 @@ # objects created before the policy is loaded or for objects that do not have a # label defined in some other manner. +sid xenboot gen_context(system_u:system_r:xenboot_t,s0) sid xen gen_context(system_u:system_r:xen_t,s0) sid dom0 gen_context(system_u:system_r:dom0_t,s0) sid domxen gen_context(system_u:system_r:domxen_t,s0) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 0bd4e8a4bd..3e5d084276 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) switch ( d->domain_id ) { case DOMID_IDLE: - dsec->sid = SECINITSID_XEN; + dsec->sid = SECINITSID_XENBOOT; break; case DOMID_XEN: dsec->sid = SECINITSID_DOMXEN; @@ -188,14 +188,20 @@ static int cf_check flask_domain_alloc_security(struct domain *d) static int cf_check flask_set_system_active(void) { + struct domain_security_struct *dsec; struct domain *d = current->domain; + dsec = d->ssid; + ASSERT(dsec->sid == SECINITSID_XENBOOT); + if ( d->domain_id != DOMID_IDLE ) { printk("xsm_set_system_active should only be called by idle domain\n"); return -EPERM; } + dsec->self_sid = dsec->sid = SECINITSID_XEN; + return 0; } diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids index 7eca70d339..e8b55b8368 100644 --- a/xen/xsm/flask/policy/initial_sids +++ b/xen/xsm/flask/policy/initial_sids @@ -3,6 +3,7 @@ # # Define initial security identifiers # +sid xenboot sid xen sid dom0 sid domio -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 13:31:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:31:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318870.538841 (Exim 4.92) (envelope-from ) id 1nlW9Q-0007T8-NT; Mon, 02 May 2022 13:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318870.538841; Mon, 02 May 2022 13:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW9Q-0007T1-Jc; Mon, 02 May 2022 13:31:44 +0000 Received: by outflank-mailman (input) for mailman id 318870; Mon, 02 May 2022 13:31:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlW9P-0005HD-2y for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:31:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33eae68b-ca1c-11ec-a405-831a346695d4; Mon, 02 May 2022 15:31:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D657B210EE; Mon, 2 May 2022 13:31:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A32F6133E5; Mon, 2 May 2022 13:31:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Nrh3Jj3db2KQGAAAMHmgww (envelope-from ); Mon, 02 May 2022 13:31:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33eae68b-ca1c-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651498301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lIstHClwMp6kkDDvi8Ipikr4fnPgWUhfAKVg57KkngY=; b=U3eJn1OirQP6iZzOQ4Hq2Fz1cvq5JVjK86nEarr8+H/eoBxl7dXi0f9axXEznmH8ToG5gT 160JkVEGTv7L8H0aFIplzk6F4UmUJY41ZST0Hg9dWJzGbXNq0CWyw3IcXkVIBZJaV94Hv+ lXlNV8F//8ZoOdMHQVvcujKCnerDDl0= Message-ID: Date: Mon, 2 May 2022 15:31:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF Content-Language: en-US To: Oleksandr , xen-devel , Linux Kernel Mailing List Cc: Boris Ostrovsky , Stefano Stabellini References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yarkfAZB0fK3Olo9lMNtQLAG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yarkfAZB0fK3Olo9lMNtQLAG Content-Type: multipart/mixed; boundary="------------ui4wYIwPULmvH8aTJTfRFH60"; protected-headers="v1" From: Juergen Gross To: Oleksandr , xen-devel , Linux Kernel Mailing List Cc: Boris Ostrovsky , Stefano Stabellini Message-ID: Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com> In-Reply-To: --------------ui4wYIwPULmvH8aTJTfRFH60 Content-Type: multipart/mixed; boundary="------------izIJvk0vw0NGS6eDqlUuEfT9" --------------izIJvk0vw0NGS6eDqlUuEfT9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMTc6MjgsIE9sZWtzYW5kciB3cm90ZToNCj4gDQo+IEhlbGxvIEp1ZXJn ZW4NCj4gDQo+IA0KPiBPbiAyOC4wNC4yMiAyMTowMywgT2xla3NhbmRyIFR5c2hjaGVua28g d3JvdGU6DQo+Pg0KPj4NCj4+IE9uIFRodSwgQXByIDI4LCAyMDIyIGF0IDExOjI4IEFNIEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbSANCj4+IDxtYWlsdG86amdyb3NzQHN1c2Uu Y29tPj4gd3JvdGU6DQo+Pg0KPj4gSGVsbG/CoEp1ZXJnZW4NCj4+DQo+PiBbc29ycnkgZm9y IHRoZSBwb3NzaWJsZSBmb3JtYXQgaXNzdWVdDQo+Pg0KPj4gwqDCoMKgIEluc3RlYWQgb2Yg dXNpbmcgYSBwcml2YXRlIG1hY3JvIGZvciBhbiBpbnZhbGlkIGdyYW50IHJlZmVyZW5jZSB1 c2UNCj4+IMKgwqDCoCB0aGUgY29tbW9uIG9uZS4NCj4+DQo+PiDCoMKgwqAgU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tDQo+PiDCoMKgwqAgPG1haWx0 bzpqZ3Jvc3NAc3VzZS5jb20+Pg0KPj4gwqDCoMKgIC0tLQ0KPj4gwqDCoMKgIMKgZHJpdmVy cy94ZW4veGVuLWZyb250LXBnZGlyLXNoYnVmLmMgfCAxNyArKysrLS0tLS0tLS0tLS0tLQ0K Pj4gwqDCoMKgIMKgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRp b25zKC0pDQo+Pg0KPj4gwqDCoMKgIGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi94ZW4tZnJv bnQtcGdkaXItc2hidWYuYw0KPj4gwqDCoMKgIGIvZHJpdmVycy94ZW4veGVuLWZyb250LXBn ZGlyLXNoYnVmLmMNCj4+IMKgwqDCoCBpbmRleCBhOTU5ZGVlMjExMzQuLmZhMjkyMWQ0ZmJm YyAxMDA2NDQNCj4+IMKgwqDCoCAtLS0gYS9kcml2ZXJzL3hlbi94ZW4tZnJvbnQtcGdkaXIt c2hidWYuYw0KPj4gwqDCoMKgICsrKyBiL2RyaXZlcnMveGVuL3hlbi1mcm9udC1wZ2Rpci1z aGJ1Zi5jDQo+PiDCoMKgwqAgQEAgLTIxLDE1ICsyMSw2IEBADQo+Pg0KPj4gwqDCoMKgIMKg I2luY2x1ZGUgPHhlbi94ZW4tZnJvbnQtcGdkaXItc2hidWYuaD4NCj4+DQo+PiDCoMKgwqAg LSNpZm5kZWYgR1JBTlRfSU5WQUxJRF9SRUYNCj4+IMKgwqDCoCAtLyoNCj4+IMKgwqDCoCAt ICogRklYTUU6IHVzYWdlIG9mIGdyYW50IHJlZmVyZW5jZSAwIGFzIGludmFsaWQgZ3JhbnQg cmVmZXJlbmNlOg0KPj4gwqDCoMKgIC0gKiBncmFudCByZWZlcmVuY2UgMCBpcyB2YWxpZCwg YnV0IG5ldmVyIGV4cG9zZWQgdG8gYSBQViBkcml2ZXIsDQo+PiDCoMKgwqAgLSAqIGJlY2F1 c2Ugb2YgdGhlIGZhY3QgaXQgaXMgYWxyZWFkeSBpbiB1c2UvcmVzZXJ2ZWQgYnkgdGhlIFBW DQo+PiDCoMKgwqAgY29uc29sZS4NCj4+IMKgwqDCoCAtICovDQo+PiDCoMKgwqAgLSNkZWZp bmUgR1JBTlRfSU5WQUxJRF9SRUbCoCDCoCDCoCAwDQo+PiDCoMKgwqAgLSNlbmRpZg0KPj4g wqDCoMKgIC0NCj4+IMKgwqDCoCDCoC8qKg0KPj4gwqDCoMKgIMKgICogVGhpcyBzdHJ1Y3R1 cmUgcmVwcmVzZW50cyB0aGUgc3RydWN0dXJlIG9mIGEgc2hhcmVkIHBhZ2UNCj4+IMKgwqDC oCDCoCAqIHRoYXQgY29udGFpbnMgZ3JhbnQgcmVmZXJlbmNlcyB0byB0aGUgcGFnZXMgb2Yg dGhlIHNoYXJlZA0KPj4gwqDCoMKgIEBAIC04Myw3ICs3NCw3IEBAIGdyYW50X3JlZl90DQo+ PiDCoMKgwqAgwqB4ZW5fZnJvbnRfcGdkaXJfc2hidWZfZ2V0X2Rpcl9zdGFydChzdHJ1Y3Qg eGVuX2Zyb250X3BnZGlyX3NoYnVmDQo+PiDCoMKgwqAgKmJ1ZikNCj4+IMKgwqDCoCDCoHsN Cj4+IMKgwqDCoCDCoCDCoCDCoCDCoCBpZiAoIWJ1Zi0+Z3JlZnMpDQo+PiDCoMKgwqAgLcKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgcmV0dXJuIEdSQU5UX0lOVkFMSURfUkVGOw0KPj4gwqDC oMKgICvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHJldHVybiBJTlZBTElEX0dSQU5UX1JFRjsN Cj4+DQo+PiDCoMKgwqAgwqAgwqAgwqAgwqAgcmV0dXJuIGJ1Zi0+Z3JlZnNbMF07DQo+PiDC oMKgwqAgwqB9DQo+PiDCoMKgwqAgQEAgLTE0Miw3ICsxMzMsNyBAQCB2b2lkIHhlbl9mcm9u dF9wZ2Rpcl9zaGJ1Zl9mcmVlKHN0cnVjdA0KPj4gwqDCoMKgIHhlbl9mcm9udF9wZ2Rpcl9z aGJ1ZiAqYnVmKQ0KPj4gwqDCoMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGludCBpOw0K Pj4NCj4+IMKgwqDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBmb3IgKGkgPSAwOyBpIDwg YnVmLT5udW1fZ3JlZnM7IGkrKykNCj4+IMKgwqDCoCAtwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqBpZiAoYnVmLT5ncmVmc1tpXSAhPSBHUkFOVF9JTlZBTElEX1JFRikN Cj4+IMKgwqDCoCArwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBpZiAoYnVm LT5ncmVmc1tpXSAhPSBJTlZBTElEX0dSQU5UX1JFRikNCj4+IMKgwqDCoCBnbnR0YWJfZW5k X2ZvcmVpZ25fYWNjZXNzKGJ1Zi0+Z3JlZnNbaV0sIDBVTCk7DQo+PiDCoMKgwqAgwqAgwqAg wqAgwqAgfQ0KPj4gwqDCoMKgIMKgIMKgIMKgIMKgIGtmcmVlKGJ1Zi0+Z3JlZnMpOw0KPj4g wqDCoMKgIEBAIC0zNTUsNyArMzQ2LDcgQEAgc3RhdGljIHZvaWQgYmFja2VuZF9maWxsX3Bh Z2VfZGlyKHN0cnVjdA0KPj4gwqDCoMKgIHhlbl9mcm9udF9wZ2Rpcl9zaGJ1ZiAqYnVmKQ0K Pj4gwqDCoMKgIMKgIMKgIMKgIMKgIH0NCj4+IMKgwqDCoCDCoCDCoCDCoCDCoCAvKiBMYXN0 IHBhZ2UgbXVzdCBzYXkgdGhlcmUgaXMgbm8gbW9yZSBwYWdlcy4gKi8NCj4+IMKgwqDCoCDC oCDCoCDCoCDCoCBwYWdlX2RpciA9IChzdHJ1Y3QgeGVuX3BhZ2VfZGlyZWN0b3J5ICopcHRy Ow0KPj4gwqDCoMKgIC3CoCDCoCDCoCDCoHBhZ2VfZGlyLT5ncmVmX2Rpcl9uZXh0X3BhZ2Ug PSBHUkFOVF9JTlZBTElEX1JFRjsNCj4+IMKgwqDCoCArwqAgwqAgwqAgwqBwYWdlX2Rpci0+ Z3JlZl9kaXJfbmV4dF9wYWdlID0gSU5WQUxJRF9HUkFOVF9SRUY7DQo+PiDCoMKgwqAgwqB9 DQo+Pg0KPj4gwqDCoMKgIMKgLyoqDQo+PiDCoMKgwqAgQEAgLTM4NCw3ICszNzUsNyBAQCBz dGF0aWMgdm9pZCBndWVzdF9maWxsX3BhZ2VfZGlyKHN0cnVjdA0KPj4gwqDCoMKgIHhlbl9m cm9udF9wZ2Rpcl9zaGJ1ZiAqYnVmKQ0KPj4NCj4+IMKgwqDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBpZiAoZ3JlZnNfbGVmdCA8PSBYRU5fTlVNX0dSRUZTX1BFUl9QQUdFKSB7DQo+ PiDCoMKgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdG9fY29weSA9 IGdyZWZzX2xlZnQ7DQo+PiDCoMKgwqAgLcKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgcGFnZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9DQo+PiDCoMKgwqAgR1JBTlRf SU5WQUxJRF9SRUY7DQo+PiDCoMKgwqAgK8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgcGFnZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9DQo+PiDCoMKgwqAgSU5WQUxJ RF9HUkFOVF9SRUY7DQo+Pg0KPj4NCj4+IEkgZmFjZWQgYW4gaXNzdWUgd2l0aCB0ZXN0aW5n IFBWIFNvdW5kIHdpdGggdGhlIGN1cnJlbnTCoHNlcmllcy4NCj4+DQo+PiByb290QHNhbHZh dG9yLXgtaDMtNHgyZy14dC1kb211On4jIGFwbGF5IC9tZWRpYS9Nb29keUxvb3Aud2F2DQo+ PiBQbGF5aW5nIFdBVkUgJy9tZWRpYS9Nb29keUxvb3Aud2F2JyA6IFNpZ25lZCAxNiBiaXQg TGl0dGxlIEVuZGlhbiwgUmF0ZSA0NDEwMCANCj4+IEh6LCBTdGVyZW8NCj4+IChYRU4pIGNv bW1vbi9ncmFudF90YWJsZS5jOjEwNTM6ZDF2MiBCYWQgcmVmIDB4ZmZmZmZmZmYgZm9yIGQ2 DQo+Pg0KPj4gSGVyZSB3ZSBoYXZlIGFuIGludGVyZXN0aW5nIHNpdHVhdGlvbi4gUFYgU291 bmQgZnJvbnRlbmTCoHVzZXMgdGhpcyANCj4+IHhlbi1mcm9udC1wZ2Rpci1zaGJ1ZiBmcmFt ZXdvcmsuIFRlY2huaWNhbGx5LCB0aGlzIHBhdGNoIGNoYW5nZXMgDQo+PiBwYWdlX2Rpci0+ Z3JlZl9kaXJfbmV4dF9wYWdlIChyZWZlcmVuY2UgdG8gdGhlIG5leHQgcGFnZSBkZXNjcmli aW5nIHBhZ2UgDQo+PiBkaXJlY3RvcnkpIGZyb20gMCB0b8KgMHhmZmZmZmZmZiBoZXJlLg0K Pj4gI2RlZmluZSBJTlZBTElEX0dSQU5UX1JFRsKgICgoZ3JhbnRfcmVmX3QpLTEpDQo+Pg0K Pj4gQnV0IGFjY29yZGluZyB0byB0aGUgcHJvdG9jb2wgKHNuZGlmLmgpLCAiMCIgbWVhbnMg dGhhdCB0aGVyZSBhcmUgbm8gbW9yZSANCj4+IHBhZ2VzIGluIHRoZSBsaXN0IGFuZCB0aGUg dXNlciBzcGFjZSBiYWNrZW5kIGV4cGVjdHMgb25seSB0aGF0IHZhbHVlLiBTbyANCj4+IHJl Y2VpdmluZ8KgMHhmZmZmZmZmZiBpdCBhc3N1bWVzIHRoZXJlIGFyZSBwYWdlcyBpbiB0aGUg bGlzdCBhbmQgdHJ5aW5nIHRvIA0KPj4gcHJvY2Vzcy4uLg0KPj4gaHR0cHM6Ly9lbGl4aXIu Ym9vdGxpbi5jb20vbGludXgvdjUuMTgtcmM0L3NvdXJjZS9pbmNsdWRlL3hlbi9pbnRlcmZh Y2UvaW8vc25kaWYuaCNMNjUwIA0KPj4NCj4+DQo+Pg0KPj4gSSB0aGluaywgdGhlwqBzYW1l IGlzIHJlbGV2YW50IHRvwqBiYWNrZW5kX2ZpbGxfcGFnZV9kaXIoKSBhcyB3ZWxsLg0KPiAN Cj4gDQo+IEluIGFkZGl0aW9uIHRvIHdoYXQgSSBzYWlkIHllc3RlcmRheToNCj4gDQo+IFBW IERpc3BsYXkgYWxzbyB1c2VzIHRoaXMgeGVuLWZyb250LXBnZGlyLXNoYnVmIGZyYW1ld29y ay4gSXQncyBwcm90b2NvbCANCj4gKGRpc3BsaWYuaCkgYWxzbyBtZW50aW9ucyB0aGUgc2Ft ZSBhcyBzbmRpZi5oIGlmIHRoZSBjb250ZXh0IG9mIGdyZWZfZGlyX25leHRfcGFnZToNCj4g DQo+ICDCoCogZ3JlZl9kaXJfbmV4dF9wYWdlIC0gZ3JhbnRfcmVmX3QsIHJlZmVyZW5jZSB0 byB0aGUgbmV4dCBwYWdlIGRlc2NyaWJpbmcNCj4gIMKgKsKgwqAgcGFnZSBkaXJlY3Rvcnku IE11c3QgYmUgMCBpZiB0aGVyZSBhcmUgbm8gbW9yZSBwYWdlcyBpbiB0aGUgbGlzdC4NCj4g DQo+IA0KPiBXaXRoIHRoYXQgbG9jYWwgY2hhbmdlIGJvdGggUFYgZGV2aWNlcyB3b3JrIGlu IG15IGVudmlyb25tZW50Lg0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbi1m cm9udC1wZ2Rpci1zaGJ1Zi5jIA0KPiBiL2RyaXZlcnMveGVuL3hlbi1mcm9udC1wZ2Rpci1z aGJ1Zi5jDQo+IGluZGV4IGZhMjkyMWQuLmFkNGE4OGUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl cnMveGVuL3hlbi1mcm9udC1wZ2Rpci1zaGJ1Zi5jDQo+ICsrKyBiL2RyaXZlcnMveGVuL3hl bi1mcm9udC1wZ2Rpci1zaGJ1Zi5jDQo+IEBAIC0zNDYsNyArMzQ2LDcgQEAgc3RhdGljIHZv aWQgYmFja2VuZF9maWxsX3BhZ2VfZGlyKHN0cnVjdCANCj4geGVuX2Zyb250X3BnZGlyX3No YnVmICpidWYpDQo+ICDCoMKgwqDCoMKgwqDCoCB9DQo+ICDCoMKgwqDCoMKgwqDCoCAvKiBM YXN0IHBhZ2UgbXVzdCBzYXkgdGhlcmUgaXMgbm8gbW9yZSBwYWdlcy4gKi8NCj4gIMKgwqDC oMKgwqDCoMKgIHBhZ2VfZGlyID0gKHN0cnVjdCB4ZW5fcGFnZV9kaXJlY3RvcnkgKilwdHI7 DQo+IC3CoMKgwqDCoMKgwqAgcGFnZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9IElOVkFM SURfR1JBTlRfUkVGOw0KPiArwqDCoMKgwqDCoMKgIHBhZ2VfZGlyLT5ncmVmX2Rpcl9uZXh0 X3BhZ2UgPSAwOw0KPiAgwqB9DQo+IA0KPiAgwqAvKioNCj4gQEAgLTM3NSw3ICszNzUsNyBA QCBzdGF0aWMgdm9pZCBndWVzdF9maWxsX3BhZ2VfZGlyKHN0cnVjdCB4ZW5fZnJvbnRfcGdk aXJfc2hidWYgDQo+ICpidWYpDQo+IA0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGlmIChncmVmc19sZWZ0IDw9IFhFTl9OVU1fR1JFRlNfUEVSX1BBR0UpIHsNCj4gIMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdG9fY29weSA9 IGdyZWZzX2xlZnQ7DQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBwYWdlX2Rpci0+Z3JlZl9kaXJfbmV4dF9wYWdlID0gSU5WQUxJRF9HUkFOVF9S RUY7DQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBw YWdlX2Rpci0+Z3JlZl9kaXJfbmV4dF9wYWdlID0gMDsNCj4gIMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB9IGVsc2Ugew0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCB0b19jb3B5ID0gWEVOX05VTV9HUkVGU19QRVJfUEFHRTsN Cj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGFn ZV9kaXItPmdyZWZfZGlyX25leHRfcGFnZSA9IGJ1Zi0+Z3JlZnNbaSArIDFdOw0KDQpJIHRo aW5rIEknbGwgaW50cm9kdWNlIGEgcHJvcGVyIGRlZmluZSBmb3IgdGhhdCBwdXJwb3NlLg0K DQoNCkp1ZXJnZW4NCg== --------------izIJvk0vw0NGS6eDqlUuEfT9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------izIJvk0vw0NGS6eDqlUuEfT9-- --------------ui4wYIwPULmvH8aTJTfRFH60-- --------------yarkfAZB0fK3Olo9lMNtQLAG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJv3T0FAwAAAAAACgkQsN6d1ii/Ey8U 8wf/QwdgjJ3EjOKZeIqsy/rjKDAVHxWaYwTtloONEZ1mZuj4wBE8KTrTRGk9SP63BWqfxXZxSEhf GyuVUuWzyiSSJ+fVczCUB2n+vd0ecYV2LbnoS4PQ0nmiDftfqNSeqxJ6ewOqw5My5GBPIHcPKCFv jx5fub+eRQChTtacB0IZ54RDMplQBeoxbHM55vOb/1J8nhSxS6P3Rev8teB6KNhTUY57fqqt8/NT ln4fBfvDAL7Mie51XHvecQrwJspBDU0bCVaTRDdnxhDXSk0LHz1pkyx/moqknYP8WsZh0+Ukb5QO hIqBusDuJTUzrXQAi2ClXgfrYJcghgatUy7F5eGyaw== =uYaa -----END PGP SIGNATURE----- --------------yarkfAZB0fK3Olo9lMNtQLAG-- From xen-devel-bounces@lists.xenproject.org Mon May 02 13:43:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:43:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318885.538852 (Exim 4.92) (envelope-from ) id 1nlWKR-00013T-Uc; Mon, 02 May 2022 13:43:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318885.538852; Mon, 02 May 2022 13:43:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWKR-00013M-R1; Mon, 02 May 2022 13:43:07 +0000 Received: by outflank-mailman (input) for mailman id 318885; Mon, 02 May 2022 13:43:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWKR-00013G-0S for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:43:07 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbae447b-ca1d-11ec-a405-831a346695d4; Mon, 02 May 2022 15:43:06 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id p12so25354866lfs.5 for ; Mon, 02 May 2022 06:43:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbae447b-ca1d-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1w0rsc5UcgM9aQ0WNcQ2pVdP625Ey+eZbK2+xDUD+so=; b=fDKhLXQDqFQ6xzMIw+Ao4mn6CeNvt/ejr+rl374eLHfSkOvlHiXcSJIR8wG/76TUTC InmtWsObvrBRo+Szrfcvp+QmDgSvUl5AxmVh/Wlr24pACtnsiqQgpDVaGWEFv/N2tJmm K+vxO1PXKxiN3XHRuJH6NsoSUiB6K54K8ixUelxktOaKNv4LyyspyvXSdNKpJ6WCW86d O4QGHTHgOc3pIgMdbR3sj/rvM8OgnEnjnJfwAyIb/Ijp2qdIJkAxm+MmV/ZjOCDdpfru siYzwPlx5kyiehN2zUORTOr1jM/YS0mleiC1PbWMVucL9jVrj4YuN4VJkY1QcgT7M/dd Qy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1w0rsc5UcgM9aQ0WNcQ2pVdP625Ey+eZbK2+xDUD+so=; b=VXhkBQZs83zShxkfGa2tqNOsA41kk2tGeTZ4iNsTwlHXtTh3bbC1t7TgfZqRWychzQ FqaWX5qBfMgnW7oiIMzY2UdzpRVomGZYu2A8uFMoKhd73m9YLYfrU2C4d9gRGlC99zTY hCbWi2rq0IjnMVw0fO1Su90mxm7uz5o5T0njfKv6rbuWJe5FVkCOFLbPL2vb1ghWoYSU Oj8yBs/DAavW1K5BbcEt12QlomdsDxam6BhHlX/8ql/3oN1JaxggUw/QAztQsH+LyWq1 FKVt1Yvwx7qBiJxD05YDaRbprQxsfCAznvsiIY0f/WFsz5WLmjAdoBA0RAanxJYBtOdI 8PgQ== X-Gm-Message-State: AOAM53197XEwQxUwieTSnFoX/336hs/Cy+wQTVGRl4uWMya02wlXbwA1 wGvKxoBMbQOWyphj2Vno772g8M82Q58igLKGQlo= X-Google-Smtp-Source: ABdhPJxP/kSSgXQisj6BsRqGiXDGbQxxWoPRhLMRrl9rbsulRSkkaBSUC7J601FoBOHrAUZSfRjfJNCu2YGk7cOIQ8M= X-Received: by 2002:a05:6512:11cc:b0:44a:5770:7425 with SMTP id h12-20020a05651211cc00b0044a57707425mr8458291lfr.406.1651498985737; Mon, 02 May 2022 06:43:05 -0700 (PDT) MIME-Version: 1.0 References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> In-Reply-To: <20220502133027.920-2-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Mon, 2 May 2022 09:42:54 -0400 Message-ID: Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup To: "Daniel P. Smith" Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Content-Type: text/plain; charset="UTF-8" On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith wrote: > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed4..b9057222d6 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, > /* Hide UART from DOM0 if we're using it */ > serial_endboot(); > > + if ( (rc = xsm_set_system_active()) != 0 ) > + panic("xsm(err=%d): " > + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); You want to print rc in this message. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon May 02 13:50:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318891.538862 (Exim 4.92) (envelope-from ) id 1nlWRe-0002TY-NU; Mon, 02 May 2022 13:50:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318891.538862; Mon, 02 May 2022 13:50:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWRe-0002TR-K9; Mon, 02 May 2022 13:50:34 +0000 Received: by outflank-mailman (input) for mailman id 318891; Mon, 02 May 2022 13:50:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWRd-0002TL-8V for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:50:33 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d46dc5a3-ca1e-11ec-a405-831a346695d4; Mon, 02 May 2022 15:50:32 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651499398571676.9915501839537; Mon, 2 May 2022 06:49:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d46dc5a3-ca1e-11ec-a405-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1651499428; cv=none; d=zohomail.com; s=zohoarc; b=evAPQ1x2QSOfPjULaRAFqTpp4AOoENhwkanCqkn2R9PM0PQk6AZObNO9d76XHjIrbvk+3mzWN3qg0pkIkGX9Mb6NQZEqEmFzMuf/52kF3N5zywIQY4p4um5WwChoNMOlRmn8ZvRQgUY4poQubz/DCqtcmQKd65KLfL4fvqYtgbo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651499428; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Dy+1SB52SPq1m3cdZQ9ztW+oAbas77ImY5sN9i+wbFQ=; b=kBTJZ2ujZcU4Z9mRLQqAeBk5EAmRKVYjLuuCtZ8RlF+6EaQTUvk4Ye//Px6UfiSnG+K7QGLpJ9QY6ftY/HOH8OenFbf2dSkc2t4Nw9aBWPZWNKdaOEXVXxV17NouEa9FciSNEvGi/oKYFRU4OZGrHPBWU4ltpP9QzcZCnb1V24s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651499428; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Dy+1SB52SPq1m3cdZQ9ztW+oAbas77ImY5sN9i+wbFQ=; b=QIhFv/XMB3Rf+LE6jQUK6i4uI2NTyH41XbKB45UwokNAWMd26NcSHG9yypKv81wW uojYHVt4l2UV8TgpWWpMClAynHGsCSjbGR1Z2HM/7EnLKzs16m2LBmw4E3p7lcUupma VH9aPmnECtxzxpQ5/Yu+og8nT6Z3xkLleBTnIjBE= Message-ID: <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> Date: Mon, 2 May 2022 09:49:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Jason Andryuk Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/2/22 09:42, Jason Andryuk wrote: > On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith > wrote: >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index d5d0792ed4..b9057222d6 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, >> /* Hide UART from DOM0 if we're using it */ >> serial_endboot(); >> >> + if ( (rc = xsm_set_system_active()) != 0 ) >> + panic("xsm(err=%d): " >> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); > > You want to print rc in this message. Thanks, but now I want to figure out how that compiled. v/r, dps From xen-devel-bounces@lists.xenproject.org Mon May 02 13:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318897.538874 (Exim 4.92) (envelope-from ) id 1nlWTa-0003F5-3o; Mon, 02 May 2022 13:52:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318897.538874; Mon, 02 May 2022 13:52:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWTa-0003Ey-01; Mon, 02 May 2022 13:52:34 +0000 Received: by outflank-mailman (input) for mailman id 318897; Mon, 02 May 2022 13:52:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWTY-0003Ej-Iq for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:52:32 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c8a475f-ca1f-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 15:52:31 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id 4so18405733ljw.11 for ; Mon, 02 May 2022 06:52:31 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id i12-20020a2ea22c000000b0024f3d1daec1sm1068851ljm.73.2022.05.02.06.52.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 06:52:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c8a475f-ca1f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kxY6XEDI7XOoO08e1j2VYG2/2iDuEgkmEgQ7wiqVynE=; b=fwiKPFjFCxmDq7YqB9IrFsckC6E9c687H64f+nt/JkS6Z28U3t/Lzjt7eyezeINl6i hxBFfQJRQqBYl8uBZy32zHox8mXbQ+So9BDeC5QuxomlKsTxV6BJ+SBynmdkwSkBlNQ8 9gC6OXZgHkcfFmnLGO2th6lA6wojCJwPO/pSOOLjresgcyaFOu2xB8nm4BaRwxSE+qGN 34nEjuW/qSpA7BQyx0k3Y2D1N9gy3CudwwW/bvuutK2GuQpy290Heeu6qrUIbphc8h6a WfpyZt/rJSEoZt59ALV8EtjhJvev3kXEk+1wSihpr+DRNQuF31q87JCF8Dp3oqWTst+m nsPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kxY6XEDI7XOoO08e1j2VYG2/2iDuEgkmEgQ7wiqVynE=; b=lRMkejkSccB9KFAcnLgtPXQ7qHdON8TbTDQX0/yNOkdDOvPcSZW+Aq2v/m7twzV0gd oYx77dWhlQAPnPBHnZHgKX9SWsJjXJS+r69z1ACh81HjjKCcqv2O2E/nIfQ6c4Wemtcd m4nIj+qEogRsnLkkfDZ0fqyciiLcw8/B9hQXnjZTLUFWS/1/dlovXPwJcajqAz9sCaIH UW3VtXTnG7nIhAfYQMgpNZwdVwNmuRUClwJU8RKQyQZbwUxZt3gy6iTkA9CmcR2KIf3h f8Pa4CgD105YlMXxmllm6daPJlOLJv/2cq7aRLGzgoXAaqvmvNpB/DjIjxQbZB1GjK8z JdOg== X-Gm-Message-State: AOAM531mGfMGJrq/4yENmZghDlr0TA/FD2/mYjOgyPa5wr4zWkyZcC8n jGJLSwCKUajNAUOTMHhDErE= X-Google-Smtp-Source: ABdhPJz2KbQGozEKkN2yAT7NZKMjZzpophd5jYaCUAiThjO2GlhjiPUckUzvvHZhdwwiSjZ4bgieiA== X-Received: by 2002:a2e:7c0d:0:b0:24f:b33:c6ab with SMTP id x13-20020a2e7c0d000000b0024f0b33c6abmr7895048ljc.516.1651499550807; Mon, 02 May 2022 06:52:30 -0700 (PDT) Subject: Re: [PATCH v2 08/19] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF To: Juergen Gross , xen-devel , Linux Kernel Mailing List Cc: Boris Ostrovsky , Stefano Stabellini References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-9-jgross@suse.com> From: Oleksandr Message-ID: Date: Mon, 2 May 2022 16:52:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 02.05.22 16:31, Juergen Gross wrote: Hello Juergen > On 29.04.22 17:28, Oleksandr wrote: >> >> Hello Juergen >> >> >> On 28.04.22 21:03, Oleksandr Tyshchenko wrote: >>> >>> >>> On Thu, Apr 28, 2022 at 11:28 AM Juergen Gross >> > wrote: >>> >>> Hello Juergen >>> >>> [sorry for the possible format issue] >>> >>>     Instead of using a private macro for an invalid grant reference use >>>     the common one. >>> >>>     Signed-off-by: Juergen Gross >>     > >>>     --- >>>      drivers/xen/xen-front-pgdir-shbuf.c | 17 ++++------------- >>>      1 file changed, 4 insertions(+), 13 deletions(-) >>> >>>     diff --git a/drivers/xen/xen-front-pgdir-shbuf.c >>>     b/drivers/xen/xen-front-pgdir-shbuf.c >>>     index a959dee21134..fa2921d4fbfc 100644 >>>     --- a/drivers/xen/xen-front-pgdir-shbuf.c >>>     +++ b/drivers/xen/xen-front-pgdir-shbuf.c >>>     @@ -21,15 +21,6 @@ >>> >>>      #include >>> >>>     -#ifndef GRANT_INVALID_REF >>>     -/* >>>     - * FIXME: usage of grant reference 0 as invalid grant reference: >>>     - * grant reference 0 is valid, but never exposed to a PV driver, >>>     - * because of the fact it is already in use/reserved by the PV >>>     console. >>>     - */ >>>     -#define GRANT_INVALID_REF      0 >>>     -#endif >>>     - >>>      /** >>>       * This structure represents the structure of a shared page >>>       * that contains grant references to the pages of the shared >>>     @@ -83,7 +74,7 @@ grant_ref_t >>>      xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf >>>     *buf) >>>      { >>>             if (!buf->grefs) >>>     -               return GRANT_INVALID_REF; >>>     +               return INVALID_GRANT_REF; >>> >>>             return buf->grefs[0]; >>>      } >>>     @@ -142,7 +133,7 @@ void xen_front_pgdir_shbuf_free(struct >>>     xen_front_pgdir_shbuf *buf) >>>                     int i; >>> >>>                     for (i = 0; i < buf->num_grefs; i++) >>>     -                       if (buf->grefs[i] != GRANT_INVALID_REF) >>>     +                       if (buf->grefs[i] != INVALID_GRANT_REF) >>>     gnttab_end_foreign_access(buf->grefs[i], 0UL); >>>             } >>>             kfree(buf->grefs); >>>     @@ -355,7 +346,7 @@ static void backend_fill_page_dir(struct >>>     xen_front_pgdir_shbuf *buf) >>>             } >>>             /* Last page must say there is no more pages. */ >>>             page_dir = (struct xen_page_directory *)ptr; >>>     -       page_dir->gref_dir_next_page = GRANT_INVALID_REF; >>>     +       page_dir->gref_dir_next_page = INVALID_GRANT_REF; >>>      } >>> >>>      /** >>>     @@ -384,7 +375,7 @@ static void guest_fill_page_dir(struct >>>     xen_front_pgdir_shbuf *buf) >>> >>>                     if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) { >>>                             to_copy = grefs_left; >>>     -                       page_dir->gref_dir_next_page = >>>     GRANT_INVALID_REF; >>>     +                       page_dir->gref_dir_next_page = >>>     INVALID_GRANT_REF; >>> >>> >>> I faced an issue with testing PV Sound with the current series. >>> >>> root@salvator-x-h3-4x2g-xt-domu:~# aplay /media/MoodyLoop.wav >>> Playing WAVE '/media/MoodyLoop.wav' : Signed 16 bit Little Endian, >>> Rate 44100 Hz, Stereo >>> (XEN) common/grant_table.c:1053:d1v2 Bad ref 0xffffffff for d6 >>> >>> Here we have an interesting situation. PV Sound frontend uses this >>> xen-front-pgdir-shbuf framework. Technically, this patch changes >>> page_dir->gref_dir_next_page (reference to the next page describing >>> page directory) from 0 to 0xffffffff here. >>> #define INVALID_GRANT_REF  ((grant_ref_t)-1) >>> >>> But according to the protocol (sndif.h), "0" means that there are no >>> more pages in the list and the user space backend expects only that >>> value. So receiving 0xffffffff it assumes there are pages in the >>> list and trying to process... >>> https://elixir.bootlin.com/linux/v5.18-rc4/source/include/xen/interface/io/sndif.h#L650 >>> >>> >>> >>> I think, the same is relevant to backend_fill_page_dir() as well. >> >> >> In addition to what I said yesterday: >> >> PV Display also uses this xen-front-pgdir-shbuf framework. It's >> protocol (displif.h) also mentions the same as sndif.h if the context >> of gref_dir_next_page: >> >>   * gref_dir_next_page - grant_ref_t, reference to the next page >> describing >>   *   page directory. Must be 0 if there are no more pages in the list. >> >> >> With that local change both PV devices work in my environment. >> >> diff --git a/drivers/xen/xen-front-pgdir-shbuf.c >> b/drivers/xen/xen-front-pgdir-shbuf.c >> index fa2921d..ad4a88e 100644 >> --- a/drivers/xen/xen-front-pgdir-shbuf.c >> +++ b/drivers/xen/xen-front-pgdir-shbuf.c >> @@ -346,7 +346,7 @@ static void backend_fill_page_dir(struct >> xen_front_pgdir_shbuf *buf) >>          } >>          /* Last page must say there is no more pages. */ >>          page_dir = (struct xen_page_directory *)ptr; >> -       page_dir->gref_dir_next_page = INVALID_GRANT_REF; >> +       page_dir->gref_dir_next_page = 0; >>   } >> >>   /** >> @@ -375,7 +375,7 @@ static void guest_fill_page_dir(struct >> xen_front_pgdir_shbuf *buf) >> >>                  if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) { >>                          to_copy = grefs_left; >> -                       page_dir->gref_dir_next_page = >> INVALID_GRANT_REF; >> +                       page_dir->gref_dir_next_page = 0; >>                  } else { >>                          to_copy = XEN_NUM_GREFS_PER_PAGE; >>                          page_dir->gref_dir_next_page = buf->grefs[i >> + 1]; > > I think I'll introduce a proper define for that purpose. I think it would be the best option. > > > > Juergen -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 02 13:54:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:54:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318903.538885 (Exim 4.92) (envelope-from ) id 1nlWVE-0003zd-Ed; Mon, 02 May 2022 13:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318903.538885; Mon, 02 May 2022 13:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWVE-0003zU-BQ; Mon, 02 May 2022 13:54:16 +0000 Received: by outflank-mailman (input) for mailman id 318903; Mon, 02 May 2022 13:54:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWVD-0003zE-8a for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:54:15 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58fe2fce-ca1f-11ec-a405-831a346695d4; Mon, 02 May 2022 15:54:14 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651499646743167.30787887760266; Mon, 2 May 2022 06:54:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58fe2fce-ca1f-11ec-a405-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1651499650; cv=none; d=zohomail.com; s=zohoarc; b=Bmr94QD4cG10BlBiydOQjyajDBpsSFWvoOd9xJJ+Vx08MCc9XCUOxtZ7rr7FFEqJDvxhTmZAvH8oqy9pszb4knCUXKraQeN/wyhydn/dEgkz/ykMi43psKysQC9WN6a7MJcKZ/GodwPlE6TKX0ir1+NQpsQMH/YSt43HPeG3eRs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651499650; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=FnYMnVWVfaH0gMtZ3vc/CoRsavdGYhQAWNFcbxlBHn4=; b=CwfmQlmvqPCppccKMhVvXinHvB1ofj6Kv0lfg/5zPN730pGt3hOsgiwUOERgvBlev6zkixoFgzouF641e8hOiwst/qFxbcxqUGorM93YFs+Gk8KAgSW4qLIOk5ODZZvVyTCXW43AaTxZCUMFZI8+j5DoiX8KUmihPEVXK9o1epw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651499650; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:From:From:To:To:Cc:Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=FnYMnVWVfaH0gMtZ3vc/CoRsavdGYhQAWNFcbxlBHn4=; b=V/2L56osNe6j1UZTNnHUx25iobKbvSwqHKGQvuRzg4qlcquvxqEnJyvvHdLj3EG3 54jjPZq2NzpgMHz2cc1BXzTAMpTekMYgmSjkfXBWom8zRER4blcfgsC2DAoAw40t62Z ZTzOOq8vBhbzVLeLOr6mjN22DbRASsPF0wQC2in8= Message-ID: <15634549-bde3-873b-862c-37ebb891ba0e@apertussolutions.com> Date: Mon, 2 May 2022 09:53:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US From: "Daniel P. Smith" To: Jason Andryuk Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> In-Reply-To: <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/2/22 09:49, Daniel P. Smith wrote: > On 5/2/22 09:42, Jason Andryuk wrote: >> On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith >> wrote: >>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >>> index d5d0792ed4..b9057222d6 100644 >>> --- a/xen/arch/arm/setup.c >>> +++ b/xen/arch/arm/setup.c >>> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, >>> /* Hide UART from DOM0 if we're using it */ >>> serial_endboot(); >>> >>> + if ( (rc = xsm_set_system_active()) != 0 ) >>> + panic("xsm(err=%d): " >>> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); >> >> You want to print rc in this message. > > Thanks, but now I want to figure out how that compile Ah, arm which I do not have a build env to do build tests. v/r, dps From xen-devel-bounces@lists.xenproject.org Mon May 02 13:56:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 13:56:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318909.538895 (Exim 4.92) (envelope-from ) id 1nlWWt-0004jU-Pu; Mon, 02 May 2022 13:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318909.538895; Mon, 02 May 2022 13:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWWt-0004jN-Mj; Mon, 02 May 2022 13:55:59 +0000 Received: by outflank-mailman (input) for mailman id 318909; Mon, 02 May 2022 13:55:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWWr-0004jH-On for xen-devel@lists.xenproject.org; Mon, 02 May 2022 13:55:57 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96fcdd94-ca1f-11ec-a405-831a346695d4; Mon, 02 May 2022 15:55:56 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id bu29so25457692lfb.0 for ; Mon, 02 May 2022 06:55:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96fcdd94-ca1f-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JIC98o94h+jogntJiZAvWVyufskI+823lQPu0h1sFm4=; b=JR779hjqoiT/iVWcop9gz3TjZBOrfjsYEsIkwbr2JoD77F2spCHcpYZ23UrAa2ihVX gr8zlL7A0W00LmivdY5tMrsOGT6bu4vDWmjrhPNvcqisiTktHKxvDhZriFIQb2xZQmim 23XRNTLKDHHlFWDF9AaQL3fO+np60kBaRlTv2LfsBRZjA5rlz09IeoPwA35eTl0YnC+4 EjUY4STbkDiaTCwUQxSO67Wby1BprG7J/8d8TzG6FYvPhGulKR92DkTw+O5QeE5M9pRe CgPslU2UyqONQvmDzy3OIXWU3U1FgqFKQP4vykGrTzRFIzAGjS3p2hRMAAqHjIPd1OYP 4PBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JIC98o94h+jogntJiZAvWVyufskI+823lQPu0h1sFm4=; b=WXAZtk+MHIRFyJDrDn90LEufJzlwtGvRB7utuhOZaT3NJIrgX+YTxcLg+xx1W7/ADp Q7QLs1hlm7o1PUIEDfss1X8yVaKeHdYS1au7GFQwXlBfw4neblIRmQLZy31Qm9+1bpCO hUmaM4evlJwcrMSdeoxhmMvZhHhB8nbOHuZu8kyViCkH4MnO99tOIG7i7JV2prRfeqHf /RefWxYoV13on3z4+Xf4hFxYH5wA/1pIv7HDM8CS3gSfvZ2qSqvgFDsf22sIEOkmv78d slWXBWBIdXixxoN/Iwy0WzECSoQtcvuAP2TryqseOjnf1AzEHkVPoo+SrKZGAYPI6sL3 C4yQ== X-Gm-Message-State: AOAM530Qtf01GhAe8sPBPI81CCurqc7Dxx0GO/i7vLDVfS3Lt1+alyJR sIG/TBW2gMTvji2KCg6jIaARJ6u65nYdnAHc3mY= X-Google-Smtp-Source: ABdhPJx6Po6Z33nLs5uql5iQcjO75CTeIGyOM0hj1ddVZ90lM8UmAGCLm4xh/MacRwKOnk6KHTqR1jUjjUUABKOHLug= X-Received: by 2002:a05:6512:1109:b0:472:25d9:d262 with SMTP id l9-20020a056512110900b0047225d9d262mr9159225lfg.128.1651499756401; Mon, 02 May 2022 06:55:56 -0700 (PDT) MIME-Version: 1.0 References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-3-dpsmith@apertussolutions.com> In-Reply-To: <20220502133027.920-3-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Mon, 2 May 2022 09:55:44 -0400 Message-ID: Subject: Re: [PATCH v5 2/2] flask: implement xsm_set_system_active To: "Daniel P. Smith" Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD , Roger Pau Monne Content-Type: text/plain; charset="UTF-8" On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith wrote: > @@ -188,14 +188,20 @@ static int cf_check flask_domain_alloc_security(struct domain *d) > > static int cf_check flask_set_system_active(void) > { > + struct domain_security_struct *dsec; > struct domain *d = current->domain; > > + dsec = d->ssid; > + ASSERT(dsec->sid == SECINITSID_XENBOOT); > + > if ( d->domain_id != DOMID_IDLE ) > { > printk("xsm_set_system_active should only be called by idle domain\n"); > return -EPERM; > } > > + dsec->self_sid = dsec->sid = SECINITSID_XEN; I think you want to re-add setting is_privileged to false. I think from the other thread Roger just thought it should also have the matching assert. It doesn't matter for flask decisions, but it changes the return of is_control_domain. It seems to me it would be better to have idle domains consistent between flask and non-flask instead of having a potentially subtle difference. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon May 02 14:12:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318916.538907 (Exim 4.92) (envelope-from ) id 1nlWmm-0007Pu-CF; Mon, 02 May 2022 14:12:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318916.538907; Mon, 02 May 2022 14:12:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWmm-0007Pn-7n; Mon, 02 May 2022 14:12:24 +0000 Received: by outflank-mailman (input) for mailman id 318916; Mon, 02 May 2022 14:12:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWml-0007Pg-55 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:12:23 +0000 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [2a00:1450:4864:20::22a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1fa1109-ca21-11ec-a405-831a346695d4; Mon, 02 May 2022 16:12:21 +0200 (CEST) Received: by mail-lj1-x22a.google.com with SMTP id q185so18515538ljb.5 for ; Mon, 02 May 2022 07:12:21 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id bf10-20020a2eaa0a000000b0024f3d1dae8bsm1074171ljb.19.2022.05.02.07.12.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 07:12:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1fa1109-ca21-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=SWU6aLH9edvsAPiYZzsg3YZpGJqJmDtADV4YivTa3fc=; b=f2GkEAq7tbE93SNbjvDPYMlOFQ58Y+ElOYaqZnJD4c83pm7kgbsu24P55eBrONDrbi 75i/xrj3xo0AaLEs4lRM4tgZgnj79ALseI+iOfODcR6Juf5m0Qk36UONR03WXbfdjELj 3pr+R05iPT7iWhlpOOmhl9Zi5RLBkiIYwZcbQK1OvHFnD4HJj1RBTWzEIcpKRZQZJqwB Qwy/T9MAwk0W+u1S8/G0la9G3DfemELFLiujJ6nunWaxGBK7RodwaZc30/IW1LctuflQ 6fQuC43kFdHFUKM5nQKgDJICuMv3k7iDqi/Tsc+ByAyNwU2HlVonl1Hp5vUYZhxZHx5g P9jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=SWU6aLH9edvsAPiYZzsg3YZpGJqJmDtADV4YivTa3fc=; b=4TU1yCqZplwMTuaF0NP7TKtDoB3LTifLWk1obfDirKqYDlyij5joK49TSSRjL5IgVC QbCadFjWs6KOi2NWn9BtHIwDODtkUqCkiOwzB7FfUXMT/1cRjboHEC+x86Lv5jZK/LsD edvvKvSrAEl5ixSBPhxHaStF4gVwuCB+N+H/NdWTs0Dv9ewkOSp3a+24pomDd5jBfQpz 83rQaS1uQPHRqCr10sjJyYw2F3RrtvHek5xVhXzMaMqbIHAOsHKD4Gc9Gnatxwe7YdMa zj86BHHqOKRzdDzhPcmb8LDQwgB5vf1CUgVeVx4/jFUpirmZNfX9q4TOX5K8npX5f9in 5vWw== X-Gm-Message-State: AOAM531mJ5Qx5eGVryrqOgwhJoWvrPQIcyWNQxLrPbDjpsEaK+TmdhCX IFfIKa75TKZ/J2gFR8Hb5Kk= X-Google-Smtp-Source: ABdhPJwJVFKBA2YxjJ+Wxyv20p1DVv/+TL02PG0KRMZrpfXHMJvtrhM0yW5BAY+E44Ci7QRynV5CXg== X-Received: by 2002:a2e:7f0b:0:b0:24f:e04:d0c with SMTP id a11-20020a2e7f0b000000b0024f0e040d0cmr7876359ljd.441.1651500741329; Mon, 02 May 2022 07:12:21 -0700 (PDT) Subject: Re: [PATCH v2 19/19] xen/xenbus: eliminate xenbus_grant_ring() To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini References: <20220428082743.16593-1-jgross@suse.com> <20220428082743.16593-20-jgross@suse.com> From: Oleksandr Message-ID: <44c08aed-8426-4d79-3fe7-2c854c711526@gmail.com> Date: Mon, 2 May 2022 17:12:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 02.05.22 16:30, Juergen Gross wrote: Hello Juergen > On 29.04.22 17:10, Oleksandr wrote: >> >> On 28.04.22 11:27, Juergen Gross wrote: >> >> >> Hello Juergen >> >> >>> There is no external user of xenbus_grant_ring() left, so merge it into >>> the only caller xenbus_setup_ring(). >>> >>> Signed-off-by: Juergen Gross >>> --- >>> V2: >>> - make error message more precise (Andrew Cooper) >>> --- >>>   drivers/xen/xenbus/xenbus_client.c | 65 >>> +++++++++--------------------- >>>   include/xen/xenbus.h               |  2 - >>>   2 files changed, 19 insertions(+), 48 deletions(-) >>> >>> diff --git a/drivers/xen/xenbus/xenbus_client.c >>> b/drivers/xen/xenbus/xenbus_client.c >>> index 1a2e0d94ccd1..d6fdd2d209d3 100644 >>> --- a/drivers/xen/xenbus/xenbus_client.c >>> +++ b/drivers/xen/xenbus/xenbus_client.c >>> @@ -363,50 +363,6 @@ static void xenbus_switch_fatal(struct >>> xenbus_device *dev, int depth, int err, >>>           __xenbus_switch_state(dev, XenbusStateClosing, 1); >>>   } >>> -/** >>> - * xenbus_grant_ring >>> - * @dev: xenbus device >>> - * @vaddr: starting virtual address of the ring >>> - * @nr_pages: number of pages to be granted >>> - * @grefs: grant reference array to be filled in >>> - * >>> - * Grant access to the given @vaddr to the peer of the given device. >>> - * Then fill in @grefs with grant references.  Return 0 on success, or >>> - * -errno on error.  On error, the device will switch to >>> - * XenbusStateClosing, and the error will be saved in the store. >>> - */ >>> -int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr, >>> -              unsigned int nr_pages, grant_ref_t *grefs) >>> -{ >>> -    int err; >>> -    unsigned int i; >>> -    grant_ref_t gref_head; >>> - >>> -    err = gnttab_alloc_grant_references(nr_pages, &gref_head); >>> -    if (err) { >>> -        xenbus_dev_fatal(dev, err, "granting access to ring page"); >>> -        return err; >>> -    } >>> - >>> -    for (i = 0; i < nr_pages; i++) { >>> -        unsigned long gfn; >>> - >>> -        if (is_vmalloc_addr(vaddr)) >>> -            gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr)); >>> -        else >>> -            gfn = virt_to_gfn(vaddr); >>> - >>> -        grefs[i] = gnttab_claim_grant_reference(&gref_head); >>> -        gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id, >>> -                        gfn, 0); >>> - >>> -        vaddr = vaddr + XEN_PAGE_SIZE; >>> -    } >>> - >>> -    return 0; >>> -} >>> -EXPORT_SYMBOL_GPL(xenbus_grant_ring); >>> - >>>   /* >>>    * xenbus_setup_ring >>>    * @dev: xenbus device >>> @@ -424,6 +380,7 @@ int xenbus_setup_ring(struct xenbus_device *dev, >>> gfp_t gfp, void **vaddr, >>>                 unsigned int nr_pages, grant_ref_t *grefs) >>>   { >>>       unsigned long ring_size = nr_pages * XEN_PAGE_SIZE; >>> +    grant_ref_t gref_head; >>>       unsigned int i; >>>       int ret; >>> @@ -433,9 +390,25 @@ int xenbus_setup_ring(struct xenbus_device >>> *dev, gfp_t gfp, void **vaddr, >>>           goto err; >>>       } >>> -    ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs); >>> -    if (ret) >>> +    ret = gnttab_alloc_grant_references(nr_pages, &gref_head); >>> +    if (ret) { >>> +        xenbus_dev_fatal(dev, ret, "granting access to %u ring pages", >>> +                 nr_pages); >>>           goto err; >>> +    } >>> + >>> +    for (i = 0; i < nr_pages; i++) { >>> +        unsigned long gfn; >>> + >>> +        if (is_vmalloc_addr(*vaddr)) >>> +            gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i])); >>> +        else >>> +            gfn = virt_to_gfn(vaddr[i]); >>> + >>> +        grefs[i] = gnttab_claim_grant_reference(&gref_head); >> >> gnttab_claim_grant_reference() can return error if no free grant >> reference remains. > > This can happen only in case gnttab_alloc_grant_references() didn't > allocate enough grants but told us it succeeded doing so. > >> I understand this patch only moves the code, but probably it would be >> better to add a missing check here (and likely rollback already >> processed grants if any?). > > I don't think this is needed, as this would be a clear bug in the code. I would put WARN_ON_ONCE if ref is an error value then like xen-netfront does. Either way, with or without it you can add my: Reviewed-by: Oleksandr Tyshchenko > > > > Juergen -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 02 14:16:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:16:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318922.538918 (Exim 4.92) (envelope-from ) id 1nlWqm-00082z-Sa; Mon, 02 May 2022 14:16:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318922.538918; Mon, 02 May 2022 14:16:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWqm-00082s-OD; Mon, 02 May 2022 14:16:32 +0000 Received: by outflank-mailman (input) for mailman id 318922; Mon, 02 May 2022 14:16:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWqm-00082m-0r for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:16:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76633d55-ca22-11ec-a405-831a346695d4; Mon, 02 May 2022 16:16:30 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-diCR31cjOF6-I_82YRRZ4A-1; Mon, 02 May 2022 16:16:29 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB6279.eurprd04.prod.outlook.com (2603:10a6:20b:b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 14:16:28 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 14:16:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76633d55-ca22-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651500990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UGKVNXpk6Yv1J6OL742nVyzRVlUL2zXcUGt7Gxrlk2U=; b=dahptf5G7x6fUr6dLT2N2+NXDv6iGObBQnLazoi4k3rDdYf+iUeYE+2DRn7RZL2cmDUJ2h lq0FXf00+06ukTyw9gDpwzAXylzjxkpfGgV1cH3JkvhCKn5BzmGNWrg4JjfqI7kzDxIN18 HqgawPITY8GgTr615M3FiMijVZomjRQ= X-MC-Unique: diCR31cjOF6-I_82YRRZ4A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iZFMD6kHjBOwskec7ZUcCiOZUsAQYTnDsq7geNjlArYfEv38nqsrS4sqifdZkT5TQ7ASFsdgcS9vqBuCtzXLflnP0A+Gq4h33tHLjxwhU4tOTNbUha+o9QgEK+oNou0WIXAd4r+GKXzVC7LZ6ilFLVgmhMhjm18WNXLQ1MQNCJFYSawX6v9eQg5Rpa8V5CBq8NuR//CF3Da8AB+80tbHQnzp6Dglv5ep9wSezSoBn7Mpow8AX8LWUzCchtBrVfZRDzWUsSkvEOc+GvojUMbcvLc1QqWcVPTFNNHrh5hz2tre/5rDkU8OY8hepp36yJTRxoSx2gFBLqqKWR8xyf6LLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGKVNXpk6Yv1J6OL742nVyzRVlUL2zXcUGt7Gxrlk2U=; b=Fu3yZfR7CJsfQYh9ZvI80FB8DmOuauzB4ugtbpT6zttftAAID0HK9fFV/ktAahxALSAJ/3jiIa4IoW8ZO6Oxql2gJATmIqz7jDi4zRhsGSRSyFgm+eetTM4nwrQow3QiJnfbh7UERsDWjsNR+0PkciqsbaneWmF4hc78+Vuupw6oNsqXO1DraZOEAxb5DY84OF+FPQHNzNlb8l/ecSethKgiAp5UBZhxF2m9pI4rHEsK/8YcGvbzm9CVxsUn9A4P74Qd7iN9mPFAXNmcf3LSNq3Cb/XR13xlKEMCWTs56U45EPFZnOzh6YTYf2CF1eAtbesmVpFK90kKp+hJsknA/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 2 May 2022 16:16:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 2/2] flask: implement xsm_set_system_active Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220502133027.920-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:20b:46c::20) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c12979d-4726-4eea-a27f-08da2c4658f2 X-MS-TrafficTypeDiagnostic: AM6PR04MB6279:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tZufiBjDzWIWKb/p8UX2UEfklTQycrWvuGQ3FqE5/WRJj/Zt12UzTsHJ8eRQO4t94+sTU/juP09Dnb25j3PEI9SGjN4ZywzYzAk9unTbiaQVFz3RnMwExJkPAhefkLsJOjuRw1HJaoK/BEjRoc2C9nsNSOTXx+baRbKp2n3WYFenxOPXpitRjBh75+PnoJdks/WLX6+tScTNMM79ub9cH1LxeuM3NCOLlQ7iWbtCxUGVKGowzO5Ec5z6R1ihaBarv3lgPHLUr1LrOzalSoXxt1UzrRAGPeolpjxAfqP7uDk67WuBGrZ/vkYLu5VOJ9pwNonEMFdoa3LUVmCx66ucjDlMRv7DnzOSNEUBeq8E/oxa2PTQ1ah0JdULtU2VT3KwZOjP24DdfbkjRe4Xob3nolpxVc1E5IBbMrcnPqg4Y0Dtz1b82Hii8lbN0gW2UFglHL65WnWfti7LCXq+11nEXjmIX+dlyL+eVz5h9ipHga/2vQSdUz1VHj2M5wlUm7ewpsfjY3Rd+hwO7ltufBFSxsBb9yke6BmsvzD+QL1k5h7vooTOPl1KNi9CfsQchAOGD5c8jBehZLLdPVawGOGRyZp7uC3654F//Ex4e7jlRtq80XBSakMGoQNMmWQv2YE45kJtCoA21W+AiymmV4mzgcAgW18AaKJ+UDn0kOa5YpnpD+Sk21WYidei25zbSnvzpwxH2xHNpIFSJGok0LfDUp1d+j2NNiPo3hwZ9rJ0LCs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(53546011)(2906002)(26005)(31696002)(86362001)(38100700002)(508600001)(6486002)(8936002)(36756003)(4744005)(5660300002)(4326008)(8676002)(66476007)(66946007)(66556008)(83380400001)(31686004)(316002)(186003)(54906003)(6916009)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ny9LVXBzOVZXUG5OVXZBV0dTbkkrVUg1RXRXa2ZSQnU3dDUxc1QzR3JzZ1hs?= =?utf-8?B?ZzliMWFabTJaTHlmemgwNHJMQU03cnZPanhSNWFkS3c4ak1lM05JSDlZZWVh?= =?utf-8?B?WHplbUFSUlJlMWNUY1FaeXhnM2o1bFZVYTZUN0tnT1VObUpwY1FHYXdLNGZK?= =?utf-8?B?VksvR2REcTlLQllaU3JlYmF2a0Q3Sy91MDlvRFFFangyUDRlU2JQOWlvWFRY?= =?utf-8?B?ellYaWRlYWVLd2piQStHTjZ1b2MzYWUyTFU5ZEtJMGR5WWUxVzVvVHlHY0tl?= =?utf-8?B?a2pBOVlZWHRoZHZTbDQrQWJZOHlrUzZ4T1lwdWE3TzgwWXlEazBNRnYwVDQy?= =?utf-8?B?WUwyTTNMWk5heVhRbzFDSXlkdnRCdGI1UUZicjE0SU5od0VoVmUyZEdjYmll?= =?utf-8?B?d3EvZ3dFSEw3U2k4SVloS0FrL29YQlhaZnpLakYveG9VUEpSRm9LY2NnQ1h0?= =?utf-8?B?RkE1OTNFUm1qTGQyMUdZeGk0cEQyWTh3WS84b0R4dHp2UnZxeXNpTjlnTlRB?= =?utf-8?B?WXU2TmpFL25qcklYMktrZnFZMUxrclVONk4zVmFkaGQrVVkxUm1XQkZKanVm?= =?utf-8?B?WlpNV2N0VGFTKzNCWVN1aUErVk0rOTFvbThwNzBKelVzU1E2THpjTGtQUGFL?= =?utf-8?B?YXFJeTJsL2ZURXIrdW1zMWxVV21RTUY4UmdPRm5MSnVGSmFSdERQVlI1bG1s?= =?utf-8?B?b3d2dE9QWFB5Q1ZSTTdlNVlsTUkwMHp1aDZMTWwxcDVPVnV5aGpzamVCZFRu?= =?utf-8?B?azl1SnNoVXNqeHllOU40bGI0NjdvWS9CZ2xSK0s2K0R6Q2kwVjVnY0tTOVFy?= =?utf-8?B?ZTdTdDVaYjVZdWNTY3pkOTZWUk13SWRyMmNBamtEU3U5RlBKOTRpaWJ5a01R?= =?utf-8?B?eWhzUkRIdEZjV29EMTFJMUNsbk02VjlzRDNyd1k5SWxjWUpMVktaZHk5THJ4?= =?utf-8?B?YXlwcEpMVWduV3kzdGdiZGNya3lCUU5iLzhMUjJCd0dpaXVjSlRtcDJ6SHN5?= =?utf-8?B?QVJCdWZzeDFTczdhYjcyR05XWUFuanJDd3FGWm1FZm9OMkt0bUwyeFBjeU5M?= =?utf-8?B?dytRTUdwVVFVbkx1NlUxZS9WemVGc04wLzR3ZWhpY2Q1Wlh6RjBFYXhIai9v?= =?utf-8?B?bWxSQjdnRjIrMUIyWkU1T1d3TTJWQ094Y1dGMVlOR0tWYmU0Ym54UFNiMzZO?= =?utf-8?B?SlNXdVJHYmlxN1V3cGhhaWdOZElxQjNJK2JZMm1EVU1Nd1FYTTMrOUhaRVQ5?= =?utf-8?B?NG5UdytMRGlvcnJHMFlZR3MxbUF0RW44aHk0a2RURTIwRnlOQi9Ya3dpQUtR?= =?utf-8?B?Mm9zMEorNTQ2aTJFNXBQeExsTW14T1luL0lFOWtNR004aVJvVi81dW8rekJ6?= =?utf-8?B?bmpxK1ZvWnVFVHZhdlFtQ1l0SnkwRFlCZElKYVNVblMrTEYwZ0FJRy9OSlRN?= =?utf-8?B?TSt4djRYZFZtNFZBQlY5RG9nY2xpdmJVV1RYOVZOYm56bkwwNjk4bFVFc0wy?= =?utf-8?B?WWMwc3hQcHhNRGIxZFBZbGVCbGt1TXUzRjF2QVlqRTNTRU5aanhsNXVoakMx?= =?utf-8?B?OEpmbWU2Y0lNbUVmeWx5QXA0WGFNUTM5SlltbkxPRW5mQTNRV202SmVlWi9C?= =?utf-8?B?NU9WWkpsMjBaTUNjcGg1TXpodFlpYnVqOWhxS0oxT0VNVXBDUitNZjR5SHNk?= =?utf-8?B?S3k2TUE0cStiWFJqV2lKUnh1VFMrUkhrS21WN1VHY3QxelFiMWY0RGQzRDE1?= =?utf-8?B?bTIySmkzNWtVSXdOUXp6aHlHUzZlYXpIL2x2Ym8rYUl4djZvQ1ZLUk9IUTY3?= =?utf-8?B?b01CVW1KRVIza0djOVUvcnFhR1d6bkg2czZKUFh5eER2MWI4NEFCTmhMM25M?= =?utf-8?B?Nk11ZzRySGk4dlp1bmJNdWFpQ1IyelYwS2RJeW5SL2dnK2N4eUNiQVBFYkZU?= =?utf-8?B?U0FZSG01dnpSRGcwOVdIMFNEUEFJMThrb1VYMUdGTVhiVCswcGhIZjNUYnZm?= =?utf-8?B?RTJmRTNxRXhRVE1hR1ZnQi9yem9UTmUrbDM0Q1hOTnNEVVBBWFF0SlRlMU5T?= =?utf-8?B?cjArdmFQb0g1RGtkdW0vMnJkTXE2MXYybkt1OENZZTIvd2FxRTBIc2tNMkZJ?= =?utf-8?B?bDF2Ky9pSGEybWZqT2ZGaWRROG1adUdrVGd5anYrUUJpSlpOMDF6U0FaMTVE?= =?utf-8?B?SnBjS2xlV2NnQXduQnJVbGNTdWgzaUt5UWd1d1ZaQUNvU0lQQlRQQkZDK2th?= =?utf-8?B?K3U2dklmd0dhZEhvbGdFbXFFZDk3QnFPdU9MZXpCaTVQenRoMy8zN0ZLeU9K?= =?utf-8?B?NXd2TnpsTHozQVNlTHdGSjlMZ1NiRmQyWjd0U2tLVUlsSDRWL2RTQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c12979d-4726-4eea-a27f-08da2c4658f2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 14:16:27.9069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jpOpsKap4CuThdtPmgX/EnHMcjccIPIpVWxFCPxVSjUCWvPBkhEjrTqkZZ4LSLXQHq5VJ7/WrkFpNbBwHBmk4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6279 On 02.05.2022 15:30, Daniel P. Smith wrote: > @@ -188,14 +188,20 @@ static int cf_check flask_domain_alloc_security(struct domain *d) > > static int cf_check flask_set_system_active(void) > { > + struct domain_security_struct *dsec; > struct domain *d = current->domain; > > + dsec = d->ssid; > + ASSERT(dsec->sid == SECINITSID_XENBOOT); What about ->self_sid, which ... > + > if ( d->domain_id != DOMID_IDLE ) > { > printk("xsm_set_system_active should only be called by idle domain\n"); > return -EPERM; > } > > + dsec->self_sid = dsec->sid = SECINITSID_XEN; ... you also overwrite here? Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 14:26:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:26:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318929.538929 (Exim 4.92) (envelope-from ) id 1nlWzs-0001C9-Nu; Mon, 02 May 2022 14:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318929.538929; Mon, 02 May 2022 14:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWzs-0001C2-L0; Mon, 02 May 2022 14:25:56 +0000 Received: by outflank-mailman (input) for mailman id 318929; Mon, 02 May 2022 14:25:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlWzr-0001Bt-GY for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:25:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c648ee56-ca23-11ec-a405-831a346695d4; Mon, 02 May 2022 16:25:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DB0AD1F38D; Mon, 2 May 2022 14:25:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AFDFA13491; Mon, 2 May 2022 14:25:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2Xk0KfHpb2KvMgAAMHmgww (envelope-from ); Mon, 02 May 2022 14:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c648ee56-ca23-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651501553; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQdYlCVk9hey9yn1VVGHvbimoYpSS37P3C2jjdqpTX4=; b=bkGD6FBhxPOW8l5eQ5bF4/nVIdrLgubGcD36e15jC38VZjhlt5grWfiugHmQKGvP1jpFPM PTte/29KSSToc7bLLY9azaa9awHQz6GlgMeC30f0DYm2xl9FmUDJNxMNaNFFismjiHRN11 s+WLTOoSSpnWx3/O3gZDdMSxH0yWSpQ= Message-ID: Date: Mon, 2 May 2022 16:25:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Boris Ostrovsky References: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com> From: Juergen Gross Subject: Re: x86/PV: (lack of) MTRR exposure In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZXgyRopxIcxXIhiBQWsnZPH3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZXgyRopxIcxXIhiBQWsnZPH3 Content-Type: multipart/mixed; boundary="------------wPzf9BL28ykn4r3lvVOP0IYN"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Boris Ostrovsky Message-ID: Subject: Re: x86/PV: (lack of) MTRR exposure References: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com> In-Reply-To: --------------wPzf9BL28ykn4r3lvVOP0IYN Content-Type: multipart/mixed; boundary="------------a260aBg0Ls09sFTk76G8FA3E" --------------a260aBg0Ls09sFTk76G8FA3E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMTI6NTMsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+IE9uIEZyaSwg QXByIDI5LCAyMDIyIGF0IDEyOjAwOjIxUE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0K Pj4gT24gMjkuMDQuMjAyMiAxMDowMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4+PiBP biBUaHUsIEFwciAyOCwgMjAyMiBhdCAwNTo1MzoxN1BNICswMjAwLCBKYW4gQmV1bGljaCB3 cm90ZToNCj4+Pj4gSGVsbG8sDQo+Pj4+DQo+Pj4+IGluIHRoZSBjb3Vyc2Ugb2YgYW5hbHl6 aW5nIHRoZSBpOTE1IGRyaXZlciBjYXVzaW5nIGJvb3QgdG8gZmFpbCBpbg0KPj4+PiBMaW51 eCA1LjE4IEkgZm91bmQgdGhhdCBMaW51eCwgZm9yIGFsbCB0aGUgeWVhcnMsIGhhcyBiZWVu IHJ1bm5pbmcNCj4+Pj4gaW4gUFYgbW9kZSBhcyBpZiBQQVQgd2FzIChtb3N0bHkpIGRpc2Fi bGVkLiBUaGlzIGlzIGEgcmVzdWx0IG9mDQo+Pj4+IHRoZW0gdHlpbmcgUEFUIGluaXRpYWxp emF0aW9uIHRvIE1UUlIgaW5pdGlhbGl6YXRpb24sIHdoaWxlIHdlDQo+Pj4+IG9mZmVyIFBB VCBidXQgbm90IE1UUlIgaW4gQ1BVSUQgb3V0cHV0LiBUaGlzIHdhcyBkaWZmZXJlbnQgYmVm b3JlDQo+Pj4+IG91ciBtb3ZpbmcgdG8gQ1BVIGZlYXR1cmVzZXRzLCBhbmQgYXMgc3VjaCBv bmUgY291bGQgdmlldyB0aGlzDQo+Pj4+IGJlaGF2aW9yIGFzIGEgcmVncmVzc2lvbiBmcm9t IHRoYXQgY2hhbmdlLg0KPj4+Pg0KPj4+PiBUaGUgZmlyc3QgcXVlc3Rpb24gaGVyZSBpcyB3 aGV0aGVyIG5vdCBleHBvc2luZyBNVFJSIGFzIGEgZmVhdHVyZQ0KPj4+PiB3YXMgcmVhbGx5 IGludGVuZGVkLCBpbiBwYXJ0aWN1bGFyIGFsc28gZm9yIFBWIERvbTAuIFRoZSBYZW5vTGlu dXgNCj4+Pj4ga2VybmVsIGFuZCBpdHMgZm9yd2FyZCBwb3J0cyBkaWQgbWFrZSB1c2Ugb2Yg WEVOUEZfKl9tZW10eXBlIHRvDQo+Pj4+IGRlYWwgd2l0aCBNVFJScy4gVGhhdCdzIGZ1bmN0 aW9uYWxpdHkgd2hpY2ggKG1heWJlIGZvciBhIGdvb2QNCj4+Pj4gcmVhc29uKSBuZXZlciBt YWRlIGl0IGludG8gdGhlIHB2b3BzIGtlcm5lbC4gTm90ZSB0aGF0IFBWSCBEb20wDQo+Pj4+ IGRvZXMgaGF2ZSBhY2Nlc3MgdG8gdGhlIG9yaWdpbmFsIHNldHRpbmdzLCBhcyB0aGUgaG9z dCB2YWx1ZXMgYXJlDQo+Pj4+IHVzZWQgYXMgaW5pdGlhbCBzdGF0ZSB0aGVyZS4NCj4+Pj4N Cj4+Pj4gVGhlIG5leHQgcXVlc3Rpb24gd291bGQgYmUgaG93IHdlIGNvdWxkIGdvIGFib3V0 IGltcHJvdmluZyB0aGUNCj4+Pj4gc2l0dWF0aW9uLiBGb3IgdGhlIHBhcnRpY3VsYXIgaXNz dWUgaW4gNS4xOCBJJ3ZlIGZvdW5kIGEgcmVsYXRpdmVseQ0KPj4+PiBzaW1wbGUgc29sdXRp b24gWzFdICh3aGljaCBhbHNvIGxvb2tzIHRvIGhlbHAgZ3JhcGhpY3MgcGVyZm9ybWFuY2UN Cj4+Pj4gb24gb3RoZXIgc3lzdGVtcywgYWNjb3JkaW5nIHRvIG15IGluaXRpYWwgb2JzZXJ2 YXRpb25zIHdpdGggdXNpbmcNCj4+Pj4gdGhlIGNoYW5nZSksIGFsYmVpdCBpdHMgc2ltcGxp Y2l0eSBsaWtlbHkgbWVhbnMgaXQgZWl0aGVyIGlzIHdyb25nDQo+Pj4+IGluIHNvbWUgd2F5 LCBvciBtaWdodCBub3QgYmUgbGlrZWQgZm9yIGxvb2tpbmcgaGFja3kgYW5kL29yIGFidXNp dmUuDQo+Pj4NCj4+PiBJIHdvbmRlciB3aGV0aGVyIHRoZSBwYXRjaCBuZWVkcyB0byBiZSBs aW1pdGVkIHRvIHRoZSBDUFVJRCBIeXBlcnZpc29yDQo+Pj4gYml0IGJlaW5nIHByZXNlbnQu ICBJZiB0aGUgUEFUIE1TUiBpcyByZWFkYWJsZSBhbmQgcmV0dXJucyBhIHZhbHVlICE9DQo+ Pj4gMCB0aGVuIFBBVCBzaG91bGQgYmUgYXZhaWxhYmxlPw0KPj4NCj4+IEkgc2ltcGx5IGRp ZG4ndCB3YW50IHRvIGJlIHRvbyAiYWdncmVzc2l2ZSIuIFRoZXJlIG1heSBiZSByZWFzb25z IHdoeQ0KPj4gdGhleSB3YW50IHRoaW5ncyB0byBiZSB0aGUgd2F5IHRoZXkgYXJlIG9uIG5h dGl2ZS4gQWxsIEkgcmVhbGx5IGNhcmUNCj4+IGFib3V0IGlzIHRoYXQgdGhpbmdzIGFyZSBi cm9rZW4gb24gUFYgWGVuOyBhcyBzdWNoIEkgd291bGRuJ3QgZXZlbg0KPj4gbWluZCB0aWdo dGVuaW5nIHRoZSBjaGVjayB0byB4ZW5fcHZfZG9tYWluKCkuIEJ1dCBmaXJzdCBJIG5lZWQN Cj4+IGZlZWRiYWNrIGZyb20gdGhlIG1haW50YWluZXJzIHRoZXJlIGFueXdheS4NCj4gDQo+ IFJpZ2h0LCBJIGRpZCBhbHNvIGNvbnNpZGVyIHN1Z2dlc3RpbmcgdG8gbGltaXQgdGhpcyB0 byBQViBhdCBmaXJzdCwNCj4gYnV0IEkgd2FzIHVuc3VyZSB3aHkgbmF0aXZlIHdvdWxkbid0 IGFsc28gd2FudCBzdWNoIGJlaGF2aW9yLiAgTWF5YmUNCj4gdGhlcmUncyBubyBoYXJkd2Fy ZSB0aGF0IGhhcyBQQVQgYnV0IG5vdCBNVFJSLCBhbmQgaGVuY2UgdGhpcyB3YXMNCj4gbmV2 ZXIgY29uc2lkZXJlZC4NCj4gDQo+Pj4gSSBndWVzcyB3ZSBzaG91bGQgaW5zdGVhZCBjaGVj ayB0aGF0IHRoZSBjdXJyZW50IFBBVCB2YWx1ZSBtYXRjaGVzDQo+Pj4gd2hhdCBMaW51eCBl eHBlY3RzLCBiZWZvcmUgZGVjbGFyaW5nIFBBVCBlbmFibGVkPw0KPj4NCj4+IEkgZG9uJ3Qg dGhpbmsgc3VjaCBhIGNoZWNrIGlzIG5lZWRlZCwgdGhlIGNvZGUgLi4uDQo+Pg0KPj4+IE5v dGUgdGhlcmUncyBhbHJlYWR5IGEgY29tbWVudCBpbiBpbml0X2NhY2hlX21vZGVzIHRoYXQg cmVmZXJzIHRvIFhlbg0KPj4+IGluIHRoZSBjaGVjayBmb3IgUEFUIENQVUlEIGJpdC4NCj4+ DQo+PiAuLi4gaW4gX19pbml0X2NhY2hlX21vZGVzKCkgYWxyZWFkeSBkb2VzIGl0IHRoZSBv dGhlciB3YXkgYXJvdW5kOg0KPj4gQWRhcHQgYmVoYXZpb3IgdG8gd2hhdCBpcyBmb3VuZCBp biBQQVQuDQo+Pg0KPj4+ICAgV2UgbWlnaHQgd2FudCB0byBleHBhbmQgdGhhdCBjb21tZW50 DQo+Pj4gKG9yIGFkZCBvbmUgdG8gdGhlIG5ldyBjaGVjayB5b3UgYXJlIGFkZGluZykuDQo+ Pg0KPj4gSSBkb24ndCBzZWUgd2hhdCBmdXJ0aGVyIGluZm9ybWF0aW9uIHlvdSB3b3VsZCB3 YW50IHRvIHB1dCB0aGVyZS4NCj4gDQo+IEl0IHdvdWxkIGRlcGVuZCBvbiBob3cgdGhlIGNo ZWNrIGVuZHMgdXAgbG9va2luZyBJIHRoaW5rLiAgSWYgdGhlDQo+IGVuYWJsaW5nIGlzIGxp bWl0ZWQgdG8gYWxzbyBoYXZpbmcgdGhlIEh5cGVydmlzb3IgQ1BVSUQgYml0IHNldCB0aGVu DQo+IHRoZSBjb21tZW50IHNob3VsZCBsaWtlbHkgbWVudGlvbiB3aHkgc2V0dGluZyBpdCBv biBuYXRpdmUgaXMgbm90DQo+IHNhZmUuDQo+IA0KPiBBbnl3YXksIGxldCdzIHNlZSB3aGF0 IG1haW50YWluZXJzIHRoaW5rLg0KPiANCj4gVGhlIG90aGVyIG9wdGlvbiB3b3VsZCBiZSB0 byBzZXQgc29tZSBraW5kIG9mIGhvb2tzIGZvciBYZW4gUFYgdG8gYmUNCj4gYWJsZSB0byBy ZXBvcnQgUEFUIGFzIGVuYWJsZWQgKG1heWJlIGEgWGVuIFBWIGltcGxlbWVudGF0aW9uIG9m DQo+IG10cnJfb3BzPyksIGJ1dCB0aGF0IHNlZW1zIGxpa2Ugb3Zlci1lbmdpbmVlcmluZyBp dC4gIE15IG1haW4gY29uY2Vybg0KPiB3aXRoIHNldHRpbmcgcGF0X2JwX2VuYWJsZWQgdG8g dHJ1ZSBpcyB3aGV0aGVyIGluIHRoZSBmdXR1cmUgc3VjaA0KPiBzZXR0aW5nIGNvdWxkIGJl IHVzZWQgdG8gZ2F0ZSBQQVQgTVNSIHdyaXRlcy4gIEl0J3MgYWxyZWFkeSBsaWtlIHRoaXMN Cj4gZm9yIEFQcyAoaW4gcGF0X2luaXQoKSAtPiBwYXRfYXBfaW5pdCgpKSwgYnV0IHdlIGF2 b2lkIHRoYXQgcGF0aA0KPiBiZWNhdXNlIHdlIGRvbid0IHJlcG9ydCBNVFJSIHN1cHBvcnQg QUZBSUNULg0KDQpUaGUgY2xlYW4gd2F5IHRvIGhhbmRsZSB0aGlzIG1lc3Mgd291bGQgYmUg dG8gc3VwcG9ydCBQQVQgaW4gdGhlIGtlcm5lbA0Kd2l0aG91dCByZXF1aXJpbmcgTVRSUi4N Cg0KVGhlIG9ubHkgcmVhc29uIGZvciBQQVQgdG8gcmVxdWl0ZSBNVFJSIHNlZW1zIHRvIGJl IHRoZSBjb21tb24gdXNhZ2Ugb2YNCm10cnJfcmVuZGV6dm91c19oYW5kbGVyKCkuIEkgbmVl ZCB0byBsb29rIGludG8gdGhhdCBhIGxpdHRsZSBiaXQgZnVydGhlciwNCmJ1dCBJIHRoaW5r IHRoaXMgc2hvdWxkIGJlIHJhdGhlciBlYXN5IHRvIHNvbHZlIGJ5IHVzaW5nIGEgZ2VuZXJp Yw0KcmVuZGV6dm91cyBoYW5kbGVyIGFuZCBwcm9wZXIgY2FsbGJhY2tzLCB3aGljaCB3aWxs IHVzZSBjb21tb24gYmFja2VuZA0KZnVuY3Rpb25zLg0KDQpQQVQgTVNSIHdyaXRlcyBjYW4g YmUgaGFuZGxlZCBieSBzcGVjaWFsIGNhc2luZyBpbiB4ZW5fd3JpdGVfbXNyX3NhZmUoKS4N Cg0KDQpKdWVyZ2VuDQoNCg== --------------a260aBg0Ls09sFTk76G8FA3E Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------a260aBg0Ls09sFTk76G8FA3E-- --------------wPzf9BL28ykn4r3lvVOP0IYN-- --------------ZXgyRopxIcxXIhiBQWsnZPH3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJv6fEFAwAAAAAACgkQsN6d1ii/Ey8/ GwgAmV9SgkKFHohukPx14pxszBCCi9KXIDrCNyB7IQmdM1HZVkTdXX+8RnJql1PtS9MaMMNXh0A3 cTthm0PO8t2n06uEcY2+pQYEMIipNJ7FO2QWviJ/lC5XFXr31yyv3vqTsM8yjuWylFZh3kQyILC5 r+EKbaKTQSfBXicP//PU4Rmkr8n+sZZtnplqOrE1W7CQrzUPO++vnpVR1XRLSnzSGq8B+OgzW4wu 51zXsqGF/LbfF4igFNxq4u8hlfsE4SkvFEIs0YsHtAtGHFangT1ec9F0cahf/wN3YoxUIsTfBeE3 bOPhGfa83+VQTVtfXYwvXYPar1ZOzlXmHZtZSqoJXg== =THs8 -----END PGP SIGNATURE----- --------------ZXgyRopxIcxXIhiBQWsnZPH3-- From xen-devel-bounces@lists.xenproject.org Mon May 02 14:47:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318936.538939 (Exim 4.92) (envelope-from ) id 1nlXKs-0003sM-JW; Mon, 02 May 2022 14:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318936.538939; Mon, 02 May 2022 14:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXKs-0003sF-GX; Mon, 02 May 2022 14:47:38 +0000 Received: by outflank-mailman (input) for mailman id 318936; Mon, 02 May 2022 14:47:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXKq-0003s9-KX for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:47:36 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd8ef5b4-ca26-11ec-a405-831a346695d4; Mon, 02 May 2022 16:47:35 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8--9jfLtClPhWLf5G_6zyzWA-1; Mon, 02 May 2022 16:47:34 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AS1PR04MB9430.eurprd04.prod.outlook.com (2603:10a6:20b:4da::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Mon, 2 May 2022 14:47:32 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 14:47:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd8ef5b4-ca26-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651502854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yNSnwbDFNW80Qg18oRehe5rlgCqT1OFew7OLyEXIXBo=; b=bxT+o7fzOHm997lfyoAnTw+GZGadroqnhIglf9vzwzBS48sUgqjkBlVWNr9U5VRZTbrKoh yNqSFP+UoJUqNumAbwDY5JHy1sYREF8UEdSl4KIQakO2Pg6IOBDUglf75rK2Z/S/a2tZah VkQqViJLsb1guIUbRWffFvMG9YuxGko= X-MC-Unique: -9jfLtClPhWLf5G_6zyzWA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZkcp/OgSsPF00cva184R+AspJ6LpfiRUVZvxmP0h5alXdnWuupoEf75hfoKu7ZxZTSV/E8fEFdB7xQJ7ReSntpUqvGPQmYkc7fjbA3ZXcV7gVeyWzg9ZD0bOU9Q61cFmZjF7EhbPCuaccYBBCMCwXAJB9gRQXmdHsekCq1vN/v8Jl/ndTvtMWf1CP43l6IOZ8KqTZOyTQnf78E0fqZn+wBIsubl9QOu1Sl/u/y5KCebjfgtYqNqbsIiPzQERTvEUqnVO5oNnEwTZbZTQkDWL0kzDRSU5suWdlUXWqnvSz/vzMu9+q0bWwU98SXi8Ru8UyfVh1zRvY1WL7zE7KWT0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yNSnwbDFNW80Qg18oRehe5rlgCqT1OFew7OLyEXIXBo=; b=OEQTg9Re48D1aMk2YjG1Ig4d1SfBBQ3dUeKUNPxHhyxIHEpC8KnUnkLD8nzxQYc+HyrR7v7abVz0jISKW7dUNH9CrpxR5QKIERzECf3BhMAShPFLdq19cJVbPxjC8UqUcy7SUFxpjR5W6pjJdaeA8KbEhN5VYTtYyQIyoarT7iqfVeDznlNp+lsK4+r2fjH2wCeUFEgPgFrX9+K0zCHFnHJglDDhcgYFec5Gk3q69lPluFMEOpcKgIOZ1mUQ8LWtWTQOtKRRoW1ANS0jpNFadCqdqYIKW6PMyOl4UPkkOQRMd1Vb61xFKerPIoe3H07fXEk3cvgDu1aXw71KNW5f6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 2 May 2022 16:47:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI partition Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com> In-Reply-To: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0081.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::22) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92f16bb8-fd99-42c0-772f-08da2c4ab009 X-MS-TrafficTypeDiagnostic: AS1PR04MB9430:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BTSbVUGD+G3m5ew+rQbMYuXeudArz2CGFL+gU4d6YVY3dFkNIJFc9OC5MvnLaTdtXU0kbAhoiC5xYAPrm5iCXDl4xLR7R2LRTripaV3FYK2TfsPf6Fh4VLE0mFExgbyuxmS47HTsPoloU0ARKz9H39RgdNGX+p9AdfCsOnVrEMlAbMAnt9A9Xx651fl91wTkbun4Xg4R8s9dGhc3tYz3/28FtzoQuNpqghAsNu9JHrgLWVGFV+7PI4jqO7Wjj4jtQZgdQAxuD9937DDMefJQbZCMaHkklfGt99YJfgCAGj2C7NpWcYrL7mRnn/0baTnQkHgXS1TDO12kdu8z75lr9MjYEAtlUpFPIPWMwywiEJ1bIS+0aY93tgUpn+m7167uusrTSHO3e0v0JKfb8H6mh3STpblemcwLOwSlqkuW/sBqcOKACM0q6xMhx21PXyVx2qwoAp44SmXLZg8grrj7VqnGCkjTncFtZH33GxwTXGE+aeLWjAfEcL8fff6hDE/PozgaVKDBcD/a3cfMstxoRSYdtZQAgiM9gAisWL1zPwsv+19KkEYpgvm0p6gWl3VzGfJV8wLsj35+2VzuhicYtwvyor1T/X4OR5Vj77DH34C3GlBftm9qqs1Ua6zohlImFZx+McT4xJ5cVf7ZEdilpIZGVoc6DUUs3DI5u5Zabp/Kc3xMeB4RIHY5FDmkuaBucB477XFcmqHKUoUyqcfEbcA8m9U1+ORSTJ/zDLs7tOc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(38100700002)(5660300002)(316002)(86362001)(6916009)(186003)(8676002)(54906003)(53546011)(26005)(4326008)(6506007)(6512007)(36756003)(66476007)(66946007)(66556008)(31686004)(8936002)(31696002)(508600001)(83380400001)(6486002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmVHS3J1dnBwWTYrYmZXWEQ3ZmhMTFZvR2l0SytuNXlFcCtZaWdCaEZLSktt?= =?utf-8?B?NHpHdnpVekMwYmdFSm1RSzlTcUFwT2dLYlFJZThGc29iZFB2dGp4blZXcXo1?= =?utf-8?B?L1UwOEZETXJXQ3dyajZrVmtVRUJTVjhpRkZid3l4NTlvNVc0MEUrR0FscGZy?= =?utf-8?B?b3J0KzgwV2FFNkFVT1RGWmVqZUtlSmhxQVJZVWliQ2VWWUpIY0xvT0VUdzlo?= =?utf-8?B?ekNOSm5SVFpOYzhBRXJ0a0h4WU9pRjk0MldIN2pKNjR4em85ZDNaWklBQWhp?= =?utf-8?B?K3RKK0RpYVU2dXpsVXNwMDBHcldjaXhxdjhiQ3B2ZGRrVEdLektiSitKemFj?= =?utf-8?B?UWxYNmJITUc5RGMzT1NTbE1aNWV5aG43UTdCN3RUenVTdDlwWlorcUIyWEF6?= =?utf-8?B?VGY0cFJMTWZNMnZRQTVzYm5iYmxjeGdpRU9iNDhBTGJOR1pOT0VRTGJUK2F0?= =?utf-8?B?c2xUNTFqQXQwSXVob21acnNLWjFSYXEvK0ZhSGRac1I1WDNFcUF5c3d5c0pD?= =?utf-8?B?S1VGVDQ4UE03Z2FqcWIwaTBHT0RVUjB6dlQvN3orOUxTcWdCb1ZDUmRNRGtI?= =?utf-8?B?K21VZkl6MERtOFh2YzVCYUxPSEU1eGxuajN2QUhVaEx0eWoxUXU1blVOeE0x?= =?utf-8?B?WkxvS3RoZEJLdm5KWjczTnl5QTUxa1ljeWtzc2F2dDQ5VmxEemFiOTIvUTBL?= =?utf-8?B?QllyZGd1UTBMMUh2d052T210cmcydGhjTlZpZkRkYzV1SGtJYmNucm03T3lw?= =?utf-8?B?dTRjWTRtTmhJUENvZEMrbHp5YzZFV2ZBZFY4TnJ5TGhtVTlmWXBBQXJQUE5h?= =?utf-8?B?V3J3UEVGQTNDempSdFU3L054R2tVc2YxR3pXYXNmcmR6MXZYMlBaWVlqaVBY?= =?utf-8?B?MzE2RzVVcDBuTVlBRGNhR0dBQ0RmSFA5Q05VVDNQUFBwREpKMm5IWWJTeVI0?= =?utf-8?B?eWxaRlpNMFYzK2RKM25tK25OR1M0UTNjWHlOV3J5a1JPR3lJcmI1Wk9Pb1do?= =?utf-8?B?andlMUtoVTZFU1loc09UZTZYbWxDdWh6RGFqOHJNY0ZMczhjVDhYZEJYN0FG?= =?utf-8?B?YVhlT0dkZU9PdlJKWGEydC9TbzdGNEVUeTBsODNleC9EaWtOL3lFdUZMbkFx?= =?utf-8?B?ZVpHTDlLWDQ0SnQzR0c3amtoSmFiZFZobkM4aUQ4YnhjMjg4cW52YjlqQVdo?= =?utf-8?B?VXlkL2FZNUVNQWJuWnN3SnRMZGtvdGdRU1hBczRoTzlnMDBGRXA4S1krZ1ZU?= =?utf-8?B?b0FHbmppM1AzZjVVc3E2azMvYTFNZXZWeE9ySVVIc1lRQWU0TW5VNGliREVY?= =?utf-8?B?UnVyTER3Z2RiOHJDQUNId3MydXNoWkk5d1d5ZkJicytRNzFNZEl2TEtETmdO?= =?utf-8?B?RS8rMTUxUVZIRVhIbVRwd1lKakRVNUZNd3FIc1Y1TzFVaU9XYlRlWHgvbnR6?= =?utf-8?B?enpwZ0hLd1lMeEliT1Z2dTVqdk0ydXF1UkNWNER1cDlhQ28rRFFyM2dKeFpF?= =?utf-8?B?akt1V2EwdnBkUW5iVmwyM0VxSkg0ZDIxUVp1T1JPc1MrOVl5VUFmQW05YmN6?= =?utf-8?B?THdRNTVGUkRJSWpRQURzNmxmY3pHR2lYR3ZqTmlablY1c1lzR2hHY0N3WlRZ?= =?utf-8?B?Zm1FWGpXeXRqaWdEL2l3NXp3SWFPUzA4L3ZRN3RkdnFZczRVSkhpaksyQkUx?= =?utf-8?B?QkZjNnFUMUVKSzErYWdBSWVMWlRiRkNNR1daS3QrT29KUVJnS0IwdWNlRVhv?= =?utf-8?B?bUlwMEsyUHlnRjRaUHdFc2c3Wm5ycFgzRGd3Z2RpWndYTWxQeTZPck1HZ05F?= =?utf-8?B?c2FoQ2QrK0QvbFMzUnplNXc0OXJPUitLbG1nU3c0SWNldDFiK0cwcDF4eUpU?= =?utf-8?B?VE9Bc21MdjE2VXlNUHNzQ1BMc1ZwVG5zUGc5RVlKbUJPTmRrY3lrQkxIczVC?= =?utf-8?B?ci91UzhSUzZpaVV6WDJtM25jdUNYMVVhdnQwcWFXTDJZZlF4MkRoY3FOeGE1?= =?utf-8?B?OGRUcXFYSGM1UkF0Sjc4SGRuQjZvbVI2eURvYlZrQmhEZUNydFJRMS9hSDQ4?= =?utf-8?B?bG0rYkFLbURpUTBnQzY2ZkQxL1RMaGRXaGRBR3ZPNENSeGhKbytsc1JwTU1G?= =?utf-8?B?SDJIMnMxbGZBMzIzWTBCZWhxWWluQ3RUYUpBMSs1MnpxTk1wMUkvMXRMUDl0?= =?utf-8?B?bzZRTnRhenUwdllDRWpxSjFNS1lRcy9udmh0UFdlMytEelNHN0dyVSs2QkhT?= =?utf-8?B?UnVjZ0U4UGh4cnNJcko0ZkI0MDFIZE41cUZpcXR2N1hVTllNVnlDeFl2Tkxv?= =?utf-8?B?cDRobHREU0dMbENqUTVFK3VJMkVRQU5vQnhiQnI5U1FGekN5RWU1Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92f16bb8-fd99-42c0-772f-08da2c4ab009 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 14:47:32.3814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q5GnkQkSfB5/kvNzVWPA7z7taJMg5FtrQZkZhjU//ycLz+VHz7xlnTuQJWNRFglSWWQ93r7Rdz6bqCEkD0BFFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9430 On 25.04.2022 12:46, Jan Beulich wrote: > With debug info retained, xen.efi can be quite large. Unlike for xen.gz > there's no intermediate step (mkelf32 there) involved which would strip > debug info kind of as a side effect. While the installing of xen.efi on > the EFI partition is an optional step (intended to be a courtesy to the > developer), adjust it also for the purpose of documenting what distros > would be expected to do during boot loader configuration (which is what > would normally put xen.efi into the EFI partition). > > Model the control over stripping after Linux'es module installation, > except that the stripped executable is constructed in the build area > instead of in the destination location. This is to conserve on space > used there - EFI partitions tend to be only a few hundred Mb in size. > > Signed-off-by: Jan Beulich > --- > RFC: GNU strip 2.38 appears to have issues when acting on a PE binary: > - the new file positions of the sections do not respect the file > alignment specified by the header (a resulting looks to work on > one EFI implementation where I did actually try it, but I don't > think we can rely on that), > - file name symbols are also stripped; while there is a separate > --keep-file-symbols option (which I would have thought to be on > by default anyway), its use makes no difference. Update to these items: The first one turned out to be an issue with a not-yet-upstream patch that I've been carrying for a long time. I've fixed that up, and will submit that patch (perhaps together with further ones) in due course. Apart from that the list of remarks now is - file name symbols are also stripped; while there is a separate --keep-file-symbols option (which I would have thought to be on by default anyway), its use so far makes no difference, - the string table grows in size, when one would expect it to shrink, - linker version is changed in and timestamp zapped from the header. Locally I have draft patches for all of these issues, but this means stripping won't work overly well until at least 2.39. Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 14:50:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318942.538950 (Exim 4.92) (envelope-from ) id 1nlXNf-0005DX-2J; Mon, 02 May 2022 14:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318942.538950; Mon, 02 May 2022 14:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXNe-0005DQ-Vj; Mon, 02 May 2022 14:50:30 +0000 Received: by outflank-mailman (input) for mailman id 318942; Mon, 02 May 2022 14:50:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXNe-0005DK-57 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:50:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3540ed31-ca27-11ec-a405-831a346695d4; Mon, 02 May 2022 16:50:29 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-WO2FxpqlNAilTZ16bgm4PQ-1; Mon, 02 May 2022 16:50:26 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB6PR04MB3208.eurprd04.prod.outlook.com (2603:10a6:6:3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Mon, 2 May 2022 14:50:25 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Mon, 2 May 2022 14:50:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3540ed31-ca27-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651503028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zJrJbHnR5IvjWVQmiVA+rkI1XMQdg7N6W4+aC//8XL4=; b=hcrZ0KKSAuDV2FEGrTLbw+Op1fp8nB6iqB5RFgjvTwnGNoJiY2awS9piO5K/sr5396etUq ZLMBOZVVYuGP1S0cH3WSqqgj6w5cArFAn08/GkpukdgOlJiT0HgC+iy9BLN3jgEBKtAGnR pn1glC9vQqLt2GTzHr/8AavFrrBPtQg= X-MC-Unique: WO2FxpqlNAilTZ16bgm4PQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQE6WzOn6VFs3C3pVAKoldrFg0cFLJ1org+zARJVBWt0h7Lb4Rgh3mJ7FAfxCZ25Qe0AKdkqtx7mYAk+cBLE2XtApHUN6sifKQ7NTotbUdurgPu7UIZuOvigwRMafh2J/DW3SVqvXK4QXtYSxWVTabCU06nNH3+SvN6nVnFP6RP1n2yVpPgvvltYJv1VeQvA/+6aB7aEtjDhe6QAtbkgxeoU8HmSSghaq/PeK0zM0R9X8RX9f0ea/hb9mAMcm2dbmBtPN1zZcUlzv5Q8ZPHY/ksmZoQuUQKzi+7dSTfn91UYMyMMRRulHmL+xlUUPQORzlEQ78MlvZpLcnpor2ER/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJrJbHnR5IvjWVQmiVA+rkI1XMQdg7N6W4+aC//8XL4=; b=Vr9Y6WY4j1r0dL5hT2+W9WymTo5OLJ0Fh4kvZFUpdAZ12tF3sMSIM6s7ZCD8FT+drPluC2I0T45aPWR44NpGCLzn4z9Kh2J4D47xChd6MZ5WLZVET5Y9QDIZlCFtbOj4tjqd6Fp3rDxk1e3zpPIG7Pi0CtK0Q1UcX69hNTtGbQNkuIlHaiXwsTfgaN/mU+yzz5y93vtscr4KycAO0pisZS6h3ItHPsp7d8ORYjElKw6MZyyZanwVaJU0RGgIBR4AVneUiWJa5Go3YNIcXAPvyJrOk2YX9VRaDOIYeNFBqFeX9L/U14ooC+U80Ue5iiFsvNWDsQd9ZDMsY63G/AgITA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e2e5bf7-860f-5777-ea18-2025a9bcf2e9@suse.com> Date: Mon, 2 May 2022 16:50:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: x86/PV: (lack of) MTRR exposure Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Boris Ostrovsky , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0151.eurprd04.prod.outlook.com (2603:10a6:20b:48a::21) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87c3540c-5df1-4fec-ffe3-08da2c4b1759 X-MS-TrafficTypeDiagnostic: DB6PR04MB3208:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PzIPLZPaKzQfjVcSpp6g2nGZnVlpdGU/bLWSzMz/fh5xmoUgB9czBM9OyGrp6ut/WTfSZNHnPi/7UVnz7P2/vL75TQjPGWCOeGSC9rEbBwpcfSHYD2Zrdc2waPNiN1XBMZN6GFQJqqYluZUSgqsCN3XYIMrlP3l4bo7whKibrMBzJnJnmWW0xVhcRpTN8gMDiyx0gfH+rHB6jkBM5y5QT1LGtMO+sCFaBeU01PGebHPCRzl4YuZX+Qz4RwEF6/XTbko13fxlmyOGJ2EqqQXk6PkYjt76VfZRPCDz8kzSOjntB4ZwwTbkBZFlFxMEB6HP9fTujkSGvNbhX0PSHWAswUYKZ+J993Z3Zn1kd1T5YsTptjOgY3V+Ub2Rc7R0j0afxMKiLSUOcYGlj9/9J7hTLNUcQgcqg7aEVifHZkgawFvMs+2ylAgQtIN0b4ZVwMP0FdryDBWX1KvUvstyGA8XrYiGtvsvZ4IvP/22esS7yVWATYtPjVOtts/QFAE0hRWA/3IvgfIFRUeN3+Ym2/jjkFyzujITeUOShDjfzR4YcJvV9uMlVRVne2S8+muHWurFmnYz+fSWek5em8vYdoqoh5TfEfmQkPt0ZsjxWvLoOya3I1zOJZvFOgrI/s9K1ca4PiWUSnCIdabO5NNRQf3pE4749gJz6dkVj4Iz7GV/LE49kuoJkVv1n6EdkrzFasvKtNdgmIOA0kJRDHKjcdtAyjZLn0oHwcDDxirG3gwJW+ETslHkMraToZ2oJ0RDM2tb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(8936002)(4326008)(6862004)(6486002)(66946007)(66476007)(66556008)(5660300002)(508600001)(6512007)(2616005)(6636002)(316002)(37006003)(26005)(6506007)(186003)(54906003)(31686004)(2906002)(38100700002)(31696002)(558084003)(53546011)(36756003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlRSR0FDcTFWTUNTS0lSNXMyTTR4dUFWVFFxKy9oVDVDNGNEdk1EK0hKM0VD?= =?utf-8?B?Zm1sNG9ZRENYRUMwcDJBSDZDOWdHZWJEN3dPKzVUcitvamI2RktHcFg4bnpx?= =?utf-8?B?eFFLZ2p4ck5RQ3J3YkREYUxzNllsNTFxSzNoQk5rZnV4Wmc3cnN2K3pISmRY?= =?utf-8?B?MWtnT2N3alB4RkhlQitiNEJIMThsOXg3N2lXNjNXZmI2WWVtN0p5d2ZqZGU0?= =?utf-8?B?TnRuVDhwMExleWFSZzRudXg1NWJoUUY3SUZ5RzhHRDhiTDF1eWlyNTVkcnVN?= =?utf-8?B?ZGhidDR1U21BQUtnWU0wc3hsVzhqNWxyTWNUcnJ3SWIwMjA1OC84VzFjZWRw?= =?utf-8?B?cVdjVjNWU3UzcVZ3cXJzb0pUd0xyVHM0L0pVajFFLzNJVk9EdFQ0UTVwRzhU?= =?utf-8?B?bHRoWnBMbmNNQUJkZFluamVCN1hVTDNWMlU3eEppdDkyMDlOWHhMSEN6bzVP?= =?utf-8?B?RDkvM3FzakdxdUcwN1lTVlIxVmlZbkdBeXlaRE12Rkk4MXdXVzZEVkNadkoz?= =?utf-8?B?c1oxa1FDemZEdnh5THdELzZ3QUhZNndkZ1dWS3NrbHVndFppSUlubHZsSjB0?= =?utf-8?B?enN1S0pzdXR2WEFuV0tlTEVuSzZObWpzeGxjTFJsdWVoVlJzcmFmc2Jhem1R?= =?utf-8?B?M01WNURIOUlRWlExYnUzRS9YT0U4MWt2Qjl6d3JjZ3FYd1VnRy81b2UvN1Zq?= =?utf-8?B?SGxhczFlbmxtajBXaHpKQ1hFV1kvL2JBRGV4MjRVbm9Ud2JLTjE3R3NuMzVZ?= =?utf-8?B?dmNuVG16c0tzUmVzUlhYKytXbDNiOFVZTTFzMjV4UnVkbE9xODVtY2JSVkZx?= =?utf-8?B?aTlBZEJnSFE0MFFnSk5tejROUVR6NGgxeWNyT2p3ODJsWiszK3FIc2xXNmlM?= =?utf-8?B?Y1BvZ1FKb3hZSi9CUnZDY1JseW80YjhnZUFRRGx4L01USlgvSFIzcnV1ZmVw?= =?utf-8?B?Sk81UkZkVnhTMXBpN1lLMWpqbkhRbW9aMzA2aTdydUR6SXNKckhSOWZaTnV0?= =?utf-8?B?andnb1NBRnBUMWpNWHk1bkR6MDVNS3h3OVhlcUxmUGNSQ2pEb3d3Q3VscG0x?= =?utf-8?B?alZzeENhcGZGT3FiaGVFTWtjenVGTEdORjIvMlg2dno0eXVYc0ZlWGNWQXhk?= =?utf-8?B?d1VtbU1tMFl1RkJRR1oxNkU1ZmdGNUhuUlp3TWNBejlEZktuVlF3amVEb1lB?= =?utf-8?B?UlFjSzBJWmphaGRGM00wZWh5akRYY0szZ0xIdGl3QzlialJHT3JUc0d0eWdo?= =?utf-8?B?dENVWEpzcnBBbXJvNDgrd0ZndThGTDNMaGZNU3h1SWdoNEZUMjJkdFE0U0Uz?= =?utf-8?B?eEJjS0VoSnVYVytTTVdVelBIUWVUTGFUV2kwRldiTTFwTU1uSGp6bHpJaXpW?= =?utf-8?B?L3VCZUlHYklhOUxyQzBNaHNjZUJIRWFYdDhacElKMHczRFIzcjU5N2ZpKytT?= =?utf-8?B?TTl0S3BaTWNySHJvM3dJRU9HZ2FSbE03QmZFQ2N6bHdhaEROSW52cXQrOTR5?= =?utf-8?B?RXB6eVJjWkFMdno4dEwrUnJHSHROTlV5cnBDaWNHNE9wamR1UmFqWGIyMi9j?= =?utf-8?B?M1RMUHg2bGtVRHNUWnZ4VmI0RGd6SWVCYkRWQ2JVb1pPNWJGR0hxQkdJSDVm?= =?utf-8?B?a2JDMldYaXJpS2lUTmdIbkttcDcyT2NFTDd2L2FCK0g5dTZ4SGI1VG9zL05M?= =?utf-8?B?VC9Wa0dEWTlwL3liY1VVcWEwU0hwWmV3S2tQNmRBZVZEQ1RUcW5wZGZwc1NB?= =?utf-8?B?a1I0cXFobjExT2EvZDFFWlpHKytEd0pBNXNjU1o3M1N1ck43TTByM1BRdUpE?= =?utf-8?B?YXphVUdDUUlEWnFkRWNxZS93NjlMbXhRdkFva2dBMWFlR2Q3ZkQrbmJUYXdk?= =?utf-8?B?VkZhOXIxYzFyaXZhMkNWWlIzam5idlRGNHRPYUFxRHF0cVVQQ3g5dHFPcERL?= =?utf-8?B?YVhndUtGWG5YdUZqa3pTL042ZWxhVU1QRmRDNFMzdlpWQUhSUWt4YzQ4NlNF?= =?utf-8?B?dFJhUWlDRWt5eGNDYndoSWZhN3ZlQWdrU2FuMEY1MTlHaytOS3IxYzR3UlJw?= =?utf-8?B?SDBVVUNQVngrOEZva1ZmSDdzUzNtclhrU1BPU2MwNzFMeXlXVGsvS1ZYb1pX?= =?utf-8?B?REt3U1haUkJNZzhOb2FKTS8vaHYrMWhzd09qc1lZaXpZNnJOYUFCSzRPQTE1?= =?utf-8?B?dXQzYlNhdk1wY1dRdFYzd2dOeFNHYWozbkYyYW5BVkF0cWdxbU9EYlRXM0Mx?= =?utf-8?B?K2pVa29mS2QyL3IwQlphV3FRcmE2ZDBPK2laMWJHaVR0SUVxeHIzNUVjTkZk?= =?utf-8?B?dWZQeVpwWTNXRnV1aHlQNnVraGxvZkhocjJ0N05CbUtPcHhEYnFvdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87c3540c-5df1-4fec-ffe3-08da2c4b1759 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 14:50:25.4479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1mVMj+i0OnBgJ5Ojl1+3jn/QTo+OxjDJuKuTqVKf2OW8VirCWTAPRYVVh/H800y2+PuKT4YH9jGOtn3ntsqESw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3208 On 02.05.2022 16:25, Juergen Gross wrote: > PAT MSR writes can be handled by special casing in xen_write_msr_safe(). You can squash the write attempt there, but that'll still confuse the caller assuming the write actually took effect. Jan From xen-devel-bounces@lists.xenproject.org Mon May 02 14:55:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 14:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318948.538961 (Exim 4.92) (envelope-from ) id 1nlXSg-0005sd-Ln; Mon, 02 May 2022 14:55:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318948.538961; Mon, 02 May 2022 14:55:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXSg-0005sW-Ir; Mon, 02 May 2022 14:55:42 +0000 Received: by outflank-mailman (input) for mailman id 318948; Mon, 02 May 2022 14:55:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXSf-0005sN-0K for xen-devel@lists.xenproject.org; Mon, 02 May 2022 14:55:41 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eea45596-ca27-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 16:55:40 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 843D01F388; Mon, 2 May 2022 14:55:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 57664133E5; Mon, 2 May 2022 14:55:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KLfnE+vwb2KSQAAAMHmgww (envelope-from ); Mon, 02 May 2022 14:55:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eea45596-ca27-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651503339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FwYutGKynN3uRVRz3lGzfR/Kh8A8Lg74zXPOFz9sMDs=; b=tLqRzFlQ2sJxx0+d6Iun5TbiPE6QvDGrR7Qs/pLQojRZvcIviM4s2auAMZvPjCrS3/xvgo NwztIb5r2WAViDktcQ9ruFG7hS5qlLeYWcO/YXQGVg/fo2acLKCmAcUnPvgU72jx64V2O8 DWS6Z20MVtWnkW4/3qg1o8jR/afOw0s= Message-ID: <3e4bf63d-9bc0-2345-b8d5-8d48c4ef82dc@suse.com> Date: Mon, 2 May 2022 16:55:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: x86/PV: (lack of) MTRR exposure Content-Language: en-US To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Boris Ostrovsky , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com> <9e2e5bf7-860f-5777-ea18-2025a9bcf2e9@suse.com> From: Juergen Gross In-Reply-To: <9e2e5bf7-860f-5777-ea18-2025a9bcf2e9@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MwY1h32D3xg1r0ibYNllPnEq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MwY1h32D3xg1r0ibYNllPnEq Content-Type: multipart/mixed; boundary="------------lokia30VNmLdzsUMViYFA0fU"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Boris Ostrovsky , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <3e4bf63d-9bc0-2345-b8d5-8d48c4ef82dc@suse.com> Subject: Re: x86/PV: (lack of) MTRR exposure References: <2a229df5-c341-9ff0-ae5c-cc0d848d7cea@suse.com> <9e2e5bf7-860f-5777-ea18-2025a9bcf2e9@suse.com> In-Reply-To: <9e2e5bf7-860f-5777-ea18-2025a9bcf2e9@suse.com> --------------lokia30VNmLdzsUMViYFA0fU Content-Type: multipart/mixed; boundary="------------ufmg6udNOxmohvyHMqBUV0hp" --------------ufmg6udNOxmohvyHMqBUV0hp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDUuMjIgMTY6NTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMi4wNS4yMDIy IDE2OjI1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gUEFUIE1TUiB3cml0ZXMgY2FuIGJl IGhhbmRsZWQgYnkgc3BlY2lhbCBjYXNpbmcgaW4geGVuX3dyaXRlX21zcl9zYWZlKCkuDQo+ IA0KPiBZb3UgY2FuIHNxdWFzaCB0aGUgd3JpdGUgYXR0ZW1wdCB0aGVyZSwgYnV0IHRoYXQn bGwgc3RpbGwgY29uZnVzZSB0aGUgY2FsbGVyDQo+IGFzc3VtaW5nIHRoZSB3cml0ZSBhY3R1 YWxseSB0b29rIGVmZmVjdC4NCg0KV2l0aCB0aGUgbGlzdCBvZiBjcHVzIHN1cHBvcnRlZCBi eSBYZW4gSSBkb24ndCBzZWUgYSBiaWcgY2hhbGxlbmdlIGhlcmUuDQpQQVQgdmlydHVhbGl6 YXRpb24gaGFuZGxlcyBldmVyeXRoaW5nIHdlIG5lZWQuDQoNCg0KSnVlcmdlbg0K --------------ufmg6udNOxmohvyHMqBUV0hp Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ufmg6udNOxmohvyHMqBUV0hp-- --------------lokia30VNmLdzsUMViYFA0fU-- --------------MwY1h32D3xg1r0ibYNllPnEq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJv8OoFAwAAAAAACgkQsN6d1ii/Ey84 SQf8DWt9B3HNs5UR/30oTrbK4BXGPpXKcqWyjSFspRjNcOB97jRN1v+wQ3oA5VxEPRIhq+qKRfU1 aSdwKjOn3eBfZG3T7ZXURZlt0o+vbOJnNnq5TSWle1su+uuOyEKdcPWlo7CkatAjQy5lqte8YZof tc3rqT70Tm6BWl1YGpJU7lzHIEiZ1r78GJom9RO085iZwB4Yym/yMoh8TWRrXYmsQeRjiTQOTV39 ocb4Xcyaj3Rzph0Xd+WyND2F1xWDG50tUyV9czc/QwsKPM4OcEhCPcE4n8U1M3cqBqKW1wC9hOpc wv0gORg3Gk4+eO78RQtFK7L+Atr/mEJhqvz6+7+/5A== =mITB -----END PGP SIGNATURE----- --------------MwY1h32D3xg1r0ibYNllPnEq-- From xen-devel-bounces@lists.xenproject.org Mon May 02 15:15:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:15:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318955.538973 (Exim 4.92) (envelope-from ) id 1nlXlZ-0000W1-CC; Mon, 02 May 2022 15:15:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318955.538973; Mon, 02 May 2022 15:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXlZ-0000Vu-8y; Mon, 02 May 2022 15:15:13 +0000 Received: by outflank-mailman (input) for mailman id 318955; Mon, 02 May 2022 15:15:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXlX-0000Vo-9v for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:15:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a681fdcb-ca2a-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 17:15:09 +0200 (CEST) Received: from mail-sn1anam02lp2047.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 11:15:05 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MW4PR03MB6427.namprd03.prod.outlook.com (2603:10b6:303:122::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Mon, 2 May 2022 15:15:01 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 15:15:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a681fdcb-ca2a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651504509; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=OaumsH4pUpLILf8R8+QY2ja3cVE+FYRIFWkVkZ52DAM=; b=aPJ+2DP1Sdu1FKG+utH+oJVSHVVtolvLAGwx2eK2Uj4VS19k6M0ViNim mjni0cpd4wrRfY+/ZcTxKr5nWeuztPAVYg97pX0Maty+8aiZO3FEKQQ6g 6ao+UEdUNqFNhRNcaawfg27pLva5maCcvKsHHDuh2+oCCBb68cMxUJFKc c=; X-IronPort-RemoteIP: 104.47.57.47 X-IronPort-MID: 69784172 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2oHZRaifANDKvLQzZJYhOkFSX161AxEKZh0ujC45NGQN5FlHY01je htvXW3VPPneNGryf4h+aI6y80MAscLRzdVqTAdp+C83Rngb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvX4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSE5IJ3ote0vaCVzEzFFZvNP5uTbPVHq5KR/z2WeG5ft69NHKRlseLY+o6NwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIAegGhYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUG+Q3F+fNouQA/yiRYirjcKZn4YuebSNt2tG/G/ DP23WPAV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWs1dA 1wZ/DI0qqo//1DtScPyNyBUu1aBtx8YHsFWSuQ84QTVkK7MuV7FWS4DUyJLb8EguIkuXzs22 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL+unfUjqnog5fLZOI IronPort-HdrOrdr: A9a23:3CoNHqGmbTs7eHLTpLqFdZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAvhHP9OkPAs1NKZMDUO11HYSL2KgbGD/9SCIVyCygci79 YGT0EWMrSZYzlHZK7BkXOF+r0bsby6Gc6T9ITjJyAHd3AQV0gs1XYONi+rVmlNACVWD5swE5 SRouJBujqbYHwSKuC2HGMMUeTvr8DC0MuOW29POzcXrC21yR+44r/zFBaVmj8YTjN02L8ntU zIiRbw6KmPu+yyjjXcy2jQxZJLn8aJ8KoLOOW8zuwubhn8gAehY4psH5WEoTAOuemqrG0nld Hdyi1QSviaRxvqDxCIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8O1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh4LD3xHklXqvoIRiKqbzOSI JVfYHhDbdtABmnhknizyZSKIfGZAVxIv+EKnJyyPB9nQIm3kyR9HFou/D3rk1wiK7VdKM0md gsSp4Y8o2mbvVmGZ6VV91xNvdeNAT2MGLxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.91,192,1647316800"; d="scan'208";a="69784172" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmefgUnPdUg2jrsMENZr+3G/6yq/vRPnbMyuvnNujZA7tl5Lfq3WRLlHeJBTm2ETesrRT/Qaj4Ae74DQxQ+l3IUOh3z6GaBkLoXnOfqsUrX8t6IH8H0O4TlNVImN+0p89xS24YC6usAczTWs06RZc4MAMfaPEasSB7gKQx4TaZ53cSJ9zxqZm5RDczB10yvsffkluu0U//T91ppypUv+kXPMhIgpbOsUL9OixiLGb6weiKJp5VUY41tUXeLtEViIYj9t1t2K3n82dOhtvbXw51j+gwuBUwuDFZeNcFBMi4uPzoo6SQtoL6FkyE6MUSACRmvkwAjOZKPc5EJv6UiSgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BIPzE6MBBJPrVnJjFXR5mX6/4Oe5Ot1ATMBz3yMGkyQ=; b=Yt8oDu+fWNunFoETUjdpMEsfhlTD0GZxAClgdyaKxJiNHhezJdzJxKifz+s/PFGcxqHbmaZDIc1cn7qhsHoZ/wWVzdWVwCaUeghSoLM29rz+5n9X8A1qAvqp+S09NrZ5qIi+nMrTDcAhglbZ/UvY0R7A6vlUlVzAjpS9AUwqoWwJBQPvME92YGUpL2RcCVsYsqJJs3GC5yw1+p7f7vUtKoRIAvmbkNtxvfewT642Qp29qA5TlbHChbBi8iPJ6K8ToS7Cq5btXZsjKiZCAf+CRcGP4QtAa3U0E1y+xPb1KLjvUXE4MTjvEBXh8eJDXBl7BatUIrkNSYEaTpvXPcVXDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BIPzE6MBBJPrVnJjFXR5mX6/4Oe5Ot1ATMBz3yMGkyQ=; b=ojnqzbrruy2HY2cpNIBCdZZ5IlXRPe/r5m6eTN7L14WcNypvotYpxVEgGsMC14ivLjXkwLMnA4feQ9s+XMZAuZCpYPAMXH4W5X34MSxFmI06im/HqqhqiMCn6glDE+9FeOYLuwGoO8EaO/TYc/KMQm4Sddpjlcg/2ah7GLEC1cA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org, iwj@xenproject.org Cc: Roger Pau Monne Subject: [PATCH] osstest: update Debian Buster install CD media to 10.12 Date: Mon, 2 May 2022 17:14:48 +0200 Message-Id: <20220502151448.19578-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0381.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::8) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 064136bd-22df-42c8-6bc4-08da2c4e873e X-MS-TrafficTypeDiagnostic: MW4PR03MB6427:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DfRukVokpEN4gpKdII5MGc5EU95S8cNZkE146p/26qLdrDYeEgzoqnnn+hT3f9HlbTqRpPBGcDEljow5N9u9zvD+dFxbGRBWDbDZtgUD8n/0lZdIaaWVsK2+FlNkiQCbnaGRsDApjG+1e+3lxYAif7JLmkYTFNsAi+B0ABkY9KAYSGg1HtuvXyBMSSzpIlVFixkNXla3FOXBQZu7gngsSv/0i+5B0a/sfxlSkb5GPunn/piMB5dvfMrq8qKMJm2KI49l1+aDCAk0jpiV350q2Mo2/b16BeaUL0feDU2eUDkrij4OY/h1/m6GpEv6fO4OhVOXiXa0/ZP4gj8e+XKdyM6Uk7YVD+u21zv3JQVvZX/ZwSkR3rU/7+WR8xR6viHUyG83nw/RJIcwt/fE+Mo5t10a1IE9NPdHbTpyN3jtSOscJfnOaNVME4qjJ1bvuTFNZsvFiqfs0fOIfiXqSc+hTtj9Av1jf5B3FoIczUb1EH4fEOvN95Nml3ZzuOjUGW6vT9NNRPXCTym6LQeLvy0wFkNBEoYMNNASGHrQj23tx0fwb29Qspu5e/5shU1cZcgky9x2EjrqIlotZWzgvDVApzuV2USkY83Tii8uKt6WQPL6KXj2EnL1dkCyp+dOAo7gnrVny0rqyTnUkniW7H96IGHqQDxkG/EwUxVfNj6bGyQquexFRHigFo1HubT2aUwct1UJKnVrzzr5LvvEbd3mPrYh5AAJygSQ/w3gSw6viIw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(6666004)(5660300002)(6506007)(8936002)(38100700002)(6512007)(19627235002)(2906002)(26005)(36756003)(15650500001)(2616005)(107886003)(1076003)(83380400001)(186003)(82960400001)(508600001)(966005)(6486002)(86362001)(66946007)(316002)(66476007)(4326008)(66556008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2U4OEJSQ2lobzQ1Z0kzdlNwQnJRaE8wdkMyNWdDQzFqbmNmQW1PNW80MGs4?= =?utf-8?B?ODhpL3ZNMUFmRHZuVHRvcC83ZTk2d24zdU9DRG9uUTJxRWJFTGNqS2R1bDRy?= =?utf-8?B?Qkl3TUJucWdVMEdiTUwzV3VqME5SSk1zaHJpWW9PbXNlUlY3Q2prTjZZZUh4?= =?utf-8?B?WGEvcFF0K2FjSTN3RURrcVFoalhKMEo4cERob09GZUVoTHNOM0o2cmJDNEN0?= =?utf-8?B?UXBDeXRaTy9GZmJZWVpaOGNKYTRqUFZQQktXZDQxb2JrU3VzWkhaVktYQyt0?= =?utf-8?B?V3o4eG01TnhCaGRsa1pwQ21SZnBLclRLV2lCUnJldkFJUnlyak83SElGclhu?= =?utf-8?B?b0JTckYycnJ6ZWNrOE45UkRRejVuTXh4NGdNYkJLcWZJV0V1Y3ZaVFpwak1U?= =?utf-8?B?TWZHa0ZHSGNCbldDTkVMYnFtWk9PV3pwNzQ4MUZ5L1BXbFFiNkdFbFRpb1Ro?= =?utf-8?B?dmFOaHN6UTVpWWJyWHpMbHdCZFZtRnJraTNSL0I0ZW56enRUNVI3cjFqU0xX?= =?utf-8?B?U2c2VU1zeHI5aDRFK3hvZGlpaGMrRW5JcjdhQzdjWUNoSCtFbnpvcTR6Nllh?= =?utf-8?B?MG56eTE1Um53QlZPeFlvcEhJK2hJL2dzdkdIWGtLSTMxVDRyZEJxTnQxZlp1?= =?utf-8?B?RmpqZjI2ZmtxU1phZzZhMTFvbThGTWdtQVhjeUVHSWtPS25QNDN2MmZVei9a?= =?utf-8?B?bThPWTVYM1RTUHRRNkhRZ3NaSVZ4NVpndGhxa0tVSWJYbm8yV0VWcHBkc3hZ?= =?utf-8?B?ek1scXZDUGJVT2ExSnZNL2xmQ1gvcWZrNytsT0lDN1hrYmd5TFBkV1RXV2JB?= =?utf-8?B?Z0VWUTNWU1lNRDN5OUxkTm82clIxbzhLT1BCZGEyVG8rQWJzT2c4QVJQUmIv?= =?utf-8?B?KzZRazhmaDl3cGU5WTlZU044UFhaUU95VkVZNjVvREJRT2pEdk4wMkk1RUl4?= =?utf-8?B?dndJUnVpeTdnOU5KOEkvSEZjV0F5MlorZE9IWWNSb1JiWEZUNkxWVWtKYXk1?= =?utf-8?B?Z0VRRTB2cVViekhzYll2WkgrRVlyNHMyd0ZLcGErcEtCSFloUFBCendrbDl4?= =?utf-8?B?VGRDUGRhb1BzcDZxMU9ZZ2FoSjhQNzFRdjBiTm1nS3FTS2hMRDltTWNCL0dr?= =?utf-8?B?dW9IejhQSzh1ZG92QXl6KzM3bjlXNGZJSVBJSjFMeGdOcjZuQlJ3a3BlendF?= =?utf-8?B?cEZFRkdJRFkxZGVqUEZpekk0ZzQxOEplK2YxM3pYeVpDL0FYQm12RXA3WkhU?= =?utf-8?B?OXhHZmNhT2xqK0llL3M4dzRFN3psNjBlNHRjYnBRR2RzSmlSWUx5cEN2ZU13?= =?utf-8?B?Y3ZMNllXamR0SGtMMHB5OVg4dlAxZ29Wdlo1YjJZMzdtenl5RFlsVHBSQWJv?= =?utf-8?B?RE82MklUNGdIOHVJUnFhem9NVEFBUHppSVpEZkw4UjdIWnZ2QWo4UjJVOVZ6?= =?utf-8?B?WGVRekhYNk0vbGFKUjU4ZzBhMkFvVGpCSGZpMTRVUzgreGNmSEZQOUhTck5N?= =?utf-8?B?K1ExdGx2NE5tSmF6bmlsZkgwNGZBMGtNeHphczJkbkdtM2JTNFBKSVg4SVQr?= =?utf-8?B?TUpaY1J3ekdtNitvMnhOT3ZMNlYxODZtUzFzbGZHam9oK3FUdWx5SUlhUXhr?= =?utf-8?B?N0RlMVVuOEk3NklVMGlJbEROVXFaQlBGYzNjVVVkelJiNll3TXd3QmVNL3h0?= =?utf-8?B?cGlHZVF0T0xiSlU3VGczVzJ2ZzR2MEI1dTFYTmVTdVowTXExRmdWaVpZMHpo?= =?utf-8?B?TzlvUG12Zk9Kd1ZVN0tkeHJjSTJ0MlhiVlpvdTM0VmZNUU5FMmNteThMSGFG?= =?utf-8?B?cmNaNDVCOWFwZkVnbVJhMjMvbzFJUGc0VTNnS3ZwaVJPRUtnSmlVSHF3Vzdj?= =?utf-8?B?YTJxamNkbzNzdWx3cjg0alJBVGtLZnZqT0VOb2JzckZGeVBzSjlJeTY5V0xx?= =?utf-8?B?Wmd2N3pzanhFNGlIWlRNWmwzUXozMjd3TW5QSVJOK09VNnh2bFVPTTU3dEdw?= =?utf-8?B?R1hDV2FIU1lTMkFCM0FiVGxnWmNhUENGT1dIL1R6dWxXSGw3UEdOWEpQczE3?= =?utf-8?B?QlBvMnVkck9XdG1rQWFTMm9nQ3Rud01URVl0cXltdExxNXlEOSsvU21iVFBj?= =?utf-8?B?UXB2V3RMRkI2Smt4dmhxVEJmK2tmbW9wbzhHQitmM2pUbHJmWGFVQ1N4K3dP?= =?utf-8?B?YmtzR2Nrcmk2ZWl2amFMbTNueXNuK1FNYk5mdk9sUERHeW9VQmdMaFJZV0E3?= =?utf-8?B?VzVuK0JURXlvU0UyVnl2Q0YrSHFkSEJxdk5YUEVHVEpnUUQ1RXZ0TmV3UXRF?= =?utf-8?B?QXRCUUlNSGZGend2U2lvR1drUWJvRmVWNkZHeFpzYVM4UkVGMUlYQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 064136bd-22df-42c8-6bc4-08da2c4e873e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 15:15:01.5682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kO9/LK/dkU6dcSNXHT2j8tgvoO+tBaq4c/wC30ux68FGVrQp2eE+VXy2g6FaVMp/wZjeO+9YHQHD4CPDVxQoSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6427 Signed-off-by: Roger Pau Monné --- production-config | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/production-config b/production-config index 9d2e7e0e..95d663dd 100644 --- a/production-config +++ b/production-config @@ -101,8 +101,8 @@ DebianSnapshotBackports_jessie http://snapshot.debian.org/archive/debian/2019020 DebianImageVersion_wheezy 7.2.0 DebianImageVersion_jessie 8.2.0 DebianImageVersion_stretch 9.4.0 -DebianImageFile_buster_amd64 debian-10.2.0-amd64-xfce-CD-1.iso -DebianImageFile_buster_i386 debian-10.2.0-i386-xfce-CD-1.iso +DebianImageFile_buster_amd64 debian-10.12.0-amd64-xfce-CD-1.iso +DebianImageFile_buster_i386 debian-10.12.0-i386-xfce-CD-1.iso # Update with ./mg-netgrub-loader-update -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 15:20:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:20:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318962.538984 (Exim 4.92) (envelope-from ) id 1nlXqs-0001wW-1E; Mon, 02 May 2022 15:20:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318962.538984; Mon, 02 May 2022 15:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXqr-0001wP-Ta; Mon, 02 May 2022 15:20:41 +0000 Received: by outflank-mailman (input) for mailman id 318962; Mon, 02 May 2022 15:20:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlXqp-0001wI-Qn for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:20:39 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a83b9e9-ca2b-11ec-a405-831a346695d4; Mon, 02 May 2022 17:20:37 +0200 (CEST) Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 11:20:34 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4135.namprd03.prod.outlook.com (2603:10b6:a03:77::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Mon, 2 May 2022 15:20:31 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 15:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a83b9e9-ca2b-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651504837; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=9IHSZv3VrMJDLhDfEaoQ4Rss2y1EMmvsxsBMllo85c4=; b=SysvcZQTYF8mgjSx/4YjG1fkh8SoBXV1OtI28wRUtVMPp9vVOF6KBCMD BbsVF4/C05Hsj7GhoXwiEShgqJFz0xECUX0n4HiEmY4m0FdoLoGZUQa5V cGfuTbkAkx0sSJWuQdvzFbychX7V4k6OQFVheiH2Mwrn13J8ALR1r2HEt E=; X-IronPort-RemoteIP: 104.47.70.106 X-IronPort-MID: 72856731 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Axbc2atX/3aXGsBvV/frEwwxpOfnVCJfMUV32f8akzHdYApBsoF/q tZmKW2FPPbfa2DzLYgnb4jl9BsEuZbdzt9lTFM9+Ho0RHkQ+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17V4 4uryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8PG4DTg/tHbCB8UAhnJ6gc4Z3gC1ew5Jn7I03uKxMAwt1IJWRvZcgy3LkyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AAmm5o2KiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3P9fdpvDOKpOB3+IjrHoSKVPmpeeFEtF66+ kXcwWXFXQ5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUHBBqlz6PV50OTADcCRzsYMNg+7pZuG3oty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1LUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:2G5w4qn9eiKCat44pX6XbykjxS7pDfOximdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhRYtKPTOWwVdASbsP0WKM+UyFJ8STzI5gPM RbAtVD4aPLfD9HZK/BiWHXcurIqOP3ipxA7t2uqkuFIzsaCJ2JuGxCe32m+wBNNX97LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGg9HQjprpbTMPGhZisWC1/HuVwY+/NyLd8gYVUjtJz7tn2W /Zkzbh7qHml/2g0BfT20La8pwTstr8zdloAtCKl6EuW3zRozftQL4kd6yJvTgzru3qwFE2kO PUqxNlBMh342O5RBDBnfNAszOQoQoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEK86JX/r1cop46zuNDd3B13Z W5Dk1WrsAxciZvV9MaOA4ge7rCNoWfe2O6DIqtSW6XZJ0vCjbql6PdxokTyaWDRKEopaFC66 gpFmko/lIPRw== X-IronPort-AV: E=Sophos;i="5.91,192,1647316800"; d="scan'208";a="72856731" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/73PCc3lX/nqVDqmLzheK9xYTfsjxQh4UqVttEj3/XQjCtWBTBXa0DMeQ7v/YQNFtKiaFu7xGEpjQGC+Td4ZcMsh5ttorxd0C8RtiSIklXUVEgh0zcwm3v8dg+YT37P3Kv8ormwUkoIu8zkMWp0+uynI6v1NhXWG716KLYVLiDVpqmhRpWXOgkU67wo9+RN0qAMgQpumwaY2yrkTblVn+dnG+ayIEUOxso7PuW+bnDvvR9fd39qNIJhQifdfBLyatWHiYxq8hXU2RasL0ggukUHMzrHqt7awYHLUaDRUbPDrdINSTdvLxIxndypWhlATl7fJTFHVH7Ne6rqemQAqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vIWelanqbp4RinFXdsKwb8IPkD2GS6socD99HZAMs4Y=; b=DVICLoyN6fcarufQEsjokd6S5eeDJhkih/bHvz/JZLE2v+1ryDwMhA3M+7YtnJCGpKHqNNbMBeyJ0Fh9ZsNac6yfKD2iBkUMsT9WdlFo6csyUTflrGcL2ueisofbV/3WthEwhmKeW/yWoZrjT8LHjGdXiJMdKSGyMJgALGD02Rv+x8wHlDlR87stpATncPWnx7pZNHDCcV3qPlZIzDu+Ijn3QGkhSLoUD0P9nEm6BYIqrrsjjtsr7EbOJVE4BDkj/2jpC4e7/MRyEE1puPDjxZsed/rk+vNy4uAHm/RrZ7BVhYAGKchz2jsCSCUsRSGZMptQwsbJuRBwXxcvOvtTDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vIWelanqbp4RinFXdsKwb8IPkD2GS6socD99HZAMs4Y=; b=vaT1Gldezc9rTEZYEmHIA6+nRly2hv43oTsrRa7gPXLr8r0LRXHe1r8J2nb4Nb4OKr04oM4zgNu1stU6xFw0GDzrsuTT/UV4j+L3qBOKVBvX3OxOd0d5BcOpmixK4LxC7efCmMszRB1klR3263FlOVmgFFwpJ8Gule/kHkzrZ10= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH RFC] x86/lld: fix symbol map generation Date: Mon, 2 May 2022 17:20:20 +0200 Message-Id: <20220502152020.19768-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0045.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f790ff0c-7028-4910-28c9-08da2c4f4b9c X-MS-TrafficTypeDiagnostic: BYAPR03MB4135:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N3Nj4kvoD7Of1JVSY8MiT3LvXTZiT68OfzT76GKWWcSkIP2WxQQiJQhRFYNmGB7yWUJR2FKmJOOoGnkKI0cdI/UeihMu04l8CtSdZoPTFby/pj8bfqbHXTly8iJTw2hTR6PNHR+/gJCMcDZNjjMWJsgL1MH5z7X+Wx62Ok5LoIK6G19xB7i0GqjWxjjPNg3eLJwNpzsYIKrZiCIyzwxt6yleTSrnJ31WSiTRYBcVimUa0BxQTMZOzFDpvpIbJJ4xuRu5fAu46PaSCZI7P/OgHjQA3schgx3/q5XE/YgpMQpd3PbZFlU4DqwhKX9sXo020ksCCMiVCzcetpl8KS/WbEF1hqijgtl3FJ79dXSyslJ+DrTexj3FnwrfC+v7G4LtX1JHyY25JRuZPiHw6lkFNkd+9lBbfIqO2bEutx6i/tyCdt47Q4Ohf/12aSwE/VGsogqJNwGICauOk9w8BhZA0u42gzh7w7rVvYDxT9i2r5xXkkq82wuMyyNWg768rm7VZQiTSOqTINz+cwVcVDPsXcCG2+Z0MjcqzNjBXQCJ2tDYF3G38I7vOtxYI4BF2uQCiuoE2+nBfxwhGRtudxC6RKCjHOOeZuZKwlzmTK4qKYPSAyuu7yNiCNRA6WVu2KEqtWqb5BA8q5f2aPwuZs8A/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(4326008)(66476007)(83380400001)(8676002)(66946007)(66556008)(508600001)(6486002)(186003)(6512007)(2616005)(1076003)(316002)(36756003)(86362001)(38100700002)(26005)(6666004)(5660300002)(54906003)(2906002)(6916009)(82960400001)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2k1T3BVaDQwMllwa1pON1R5VnBWS1MydXRyRkR3VzVRUjBkcHpQOEZ3UmZB?= =?utf-8?B?bkw0cUNxTWwyV0t5L1hoYnBWLzZsRTR0WEpTOXA5WnRYbGFIRUdlVXdYZTlo?= =?utf-8?B?QkJxdXJidis0eThPUDZPMVhwdm5uR3BMeEVTbjZXY1BmTkVXWTNrbHN4YTBX?= =?utf-8?B?YlVHREw3TUgrODdia1h3dGs1VUxOTXpzVTVvWXRIRjl4M29kMVZ5YVhUaVJO?= =?utf-8?B?NVFQdkpETzhselZNQnUrKzRGRHJCT3A1OUIrc3FWNGdKaVQwRXlXcUxMbStl?= =?utf-8?B?SlNMTXJFVmRMU3ppVWRCWnhhclg0WDE2Zzk4ZmM3bkxjNDRBaXJtNW5aaWJQ?= =?utf-8?B?V2VycElpTjVCeU5qUSttUmdGekxYcENKekxpb0IweTAyZnprN3BLK0JWNjA3?= =?utf-8?B?cThvOWlWT1BrRDdXbEZ4SnpMaisyeEwzQVM3VVFPNTEvODYyNjBqaXlKMzRv?= =?utf-8?B?eFF3amxBVEdRemR4SnpWREJjaWFKRm9ZS0t2SmdncnROenhuV0NsTWhiSGht?= =?utf-8?B?WUxZQVZ6TkYxR3d0NWlrMnQ0b29IMFNNZitHUTdYTHZLWkRSdmo0Q2pTL2Vr?= =?utf-8?B?V2l6SDZLVEw2YmVpN2lmck50WmM0TTZtTU5IcG1QWndxZkFxYlQwM1hXNlRC?= =?utf-8?B?amd3a0dmelFYNkI0YUVLWmJ0UmkrV2trSzZBUSt4Rm41MFlmV3o2U01WQlhO?= =?utf-8?B?U1hyUzFqMkFrOUFCa3VGa3RHMWFUb0pSQkxaU3hPaVZvYjVjdjBQRms0UWl6?= =?utf-8?B?ejhrQUtTaFBjS1BmejA0dmRKckExWmtiOWM4aFc0MWxSZnZUWHlYODZXTHlZ?= =?utf-8?B?QTVFMkJkdzFEL1RLcm5tenRlMVUwLzNjOFYwY2I0TFQrL1Bwbzk4b2wzcUdM?= =?utf-8?B?UjZTaWpsZk1KdGdUT1M3UCtreHJuU24rQ2twYVhSbnMraHJhZXFEY2VCSmpL?= =?utf-8?B?aXdWdTNzRldHSW84RDk1ZTJzR3EySmQ2QlB4UytlcEZZc1RSOCtyZEdQbTBL?= =?utf-8?B?b3JSdFhPVWcvWHNBTDdtOHdWWCtJZmRTdHEzUE5RdEJiTDFkbnUwQ3h3d1VO?= =?utf-8?B?QjdscUI3MnVGanRURStaLzZtOVlhVERieDdoVUVWd0lvalJUZ1hrM0NOWnpF?= =?utf-8?B?STVLa2lTV25QS2o5OUt4OVpkeHhKUmtWUFJmSWw4aERERmJvUUVxdlVNT1Bn?= =?utf-8?B?a3JWaytYNmFOOHR4YnFtdHJ1b2FwMTNRQ1JpK1R1MmNGaEUweFJKVm9MUDNu?= =?utf-8?B?VDRPRlpiMm1PZWJtTzg5eDJLVGhXTnFHamtDMTlkeEUrT0lKbnJ5MUp3dnhG?= =?utf-8?B?MFhvdjlFVk0ya24rdG54ZE9PbFM1Y0RhUjErZHdkdG1oOXdBM0VZeEJwNjE3?= =?utf-8?B?VFhwdUR1cy8zd0ttWW1YcnNLUVAxYy9RQ3A2QkY3WjliN25GbDFvcEJsYTlT?= =?utf-8?B?OWFka2kvK3hodDdJc0xjUzF6VUQyN1JlZ1RLcEIvMXNhWUtqRGs3YllQejR4?= =?utf-8?B?OWZqUGhSSjZhT3lhVjd1b1VRVnhtS2VISTRJaWJzTVdlT2NjeEU1V25oRGpt?= =?utf-8?B?MkFZV0h0Sm1VTUpST25haXh1ZVlmTG9SM2NqZlVDb05mc3JBMmYxKzc3Vnls?= =?utf-8?B?MDNzMlB2cHNFVXJKOEU1R0pFaHFxSXNDcHZBbDhoVGZOVE1FU3Z4R0l1TFBQ?= =?utf-8?B?TTgvZDQxZDRjZkczWmpwV0ZQNGtwYUp3NmQ1aEtnZHNWeHZidDAxcUYzVnky?= =?utf-8?B?NlFVVzFwcDZrajNSSEVnY25XcmNaOFBYOHBDYWsraVNuWFh6YnRCY0JUaHgw?= =?utf-8?B?SGxGc1lUZFFCdWRvMk9qWWd2VWxoNjh5LzdJekVxVkx2L2hheUVaQzZJTWRN?= =?utf-8?B?NVQzYjcyUFBaNVNiRHdlZ0tKcHZvdWVBOEhTU3FyR2FNZWRtZjlZSzgxREZG?= =?utf-8?B?SGQrRUs4cDVwMkR2UXRveWNPM2djZWhzUVF0UzVMWENEdGxpU3FEM2ZmNTdn?= =?utf-8?B?K3hiN3pUY3g5OHlYVGR0M1N4SkFySW54VkVaMjliZWxCY3VMWEhnYmNNREFP?= =?utf-8?B?N3ZETE5tbTFWRW8rVkRtZGR2dlMyUXM2VWVXWUtkMUQ5eUc1S0tLN3c2aVlK?= =?utf-8?B?RFE5ZFoxZkJVVXFtN0pIR0hQUFN6d0dBdkdUckVPRlpJS3kzM1FOU1JVL1R3?= =?utf-8?B?Y0FSMFYrdm1GaUZyTnZhb09mS2V5Y0Izay95dUtSc2t6bkh2cUczb21xVGZS?= =?utf-8?B?RXFpZXVMUURtMzlKYy82ajFvN29QRmpRdTlLN2ZmbVJqSlhqaUdlSC9IbllT?= =?utf-8?B?eGgzOVRYOU1GU1pMUWJYeHV2OTZZaDJHbi9DN3lzNEZDTGJ0K3VZUE94akcz?= =?utf-8?Q?W4tHMDmZnVbUnwn8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f790ff0c-7028-4910-28c9-08da2c4f4b9c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2022 15:20:31.0955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Md+snsYtAkobTAs3y4RSBlhViRz3cengoc+2rAL1n/uAml0t7xO9g8z0+OwDqDtHcabmyaUqMLKqKGC0XrphOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4135 The symbol map generation (and thus the debug info attached to Xen) is partially broken when using LLVM LD. That's due to LLD converting almost all symbols from global to local in the last linking step, and thus confusing tools/symbols into adding a file prefix to all text symbols, the results looks like: Xen call trace: [] R xxhash64.c#__start_xen+0x3938/0x39c0 [] F __high_start+0x94/0xa0 In order to workaround this create a list of global symbols prior to the linking step, and use objcopy to convert the symbols in the final binary back to global before processing with tools/symbols. Signed-off-by: Roger Pau Monné --- I haven't found a way to prevent LLD from converting the symbols, so I've come up with this rather crappy workaround. Not applied to EFI, partially because I don't have an environment with LLD capable of generating the EFI binary. Obtaining the global symbol list could likely be a target on itself, if it is to be shared between the ELF and the EFI binary generation. --- xen/arch/x86/Makefile | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 177a2ff742..f3817827bc 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -134,24 +134,34 @@ $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds + # Dump global text symbols before the linking step + $(NM) -pa --format=bsd $< | awk '{ if($$2 == "T") print $$3}' \ + > $(@D)/.$(@F).global-syms $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 + $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0.tmp + # LLVM LD has converted global symbols into local ones as part of the + # linking step, convert those back to global before using tools/symbols. + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms \ + $(@D)/.$(@F).0.tmp $(@D)/.$(@F).0 $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ >$(@D)/.$(@F).0.S $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 + $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1.tmp + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms \ + $(@D)/.$(@F).1.tmp $(@D)/.$(@F).1 $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ | $(objtree)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ >$(@D)/.$(@F).1.S $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ - $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ + $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@.tmp + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms $@.tmp $@ $(NM) -pa --format=sysv $(@D)/$(@F) \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ >$(@D)/$(@F).map - rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* + rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* $(@D)/.$(@F).global-syms ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ endif @@ -266,6 +276,7 @@ $(obj)/xen.lds $(obj)/efi.lds: $(src)/xen.lds.S FORCE clean-files := \ include/asm/asm-macros.* \ $(objtree)/.xen-syms.[0-9]* \ + $(objtree)/.xen-syms.global-syms \ $(objtree)/.xen.elf32 \ $(objtree)/.xen.efi.[0-9]* \ efi/*.efi -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 02 15:38:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:38:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318969.538994 (Exim 4.92) (envelope-from ) id 1nlY7n-0003pA-HE; Mon, 02 May 2022 15:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318969.538994; Mon, 02 May 2022 15:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlY7n-0003p3-ED; Mon, 02 May 2022 15:38:11 +0000 Received: by outflank-mailman (input) for mailman id 318969; Mon, 02 May 2022 15:38:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlY7m-0003ox-Fm for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:38:10 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dd9b3302-ca2d-11ec-a405-831a346695d4; Mon, 02 May 2022 17:38:09 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id p6so12988686pjm.1 for ; Mon, 02 May 2022 08:38:09 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id ba1-20020a170902720100b0015e8d4eb1e6sm4806927plb.48.2022.05.02.08.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 08:38:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd9b3302-ca2d-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=G3glF1N1lkKRH3me6ZqnttV9WJnWFWFCivroWGr8uPw=; b=jnlfZk0MfWr19qnX7NNM7gjFbPrAaWIfsyMT/a2rh5ffB/v2pJfbjyvAq97gGIe7rG uTUMZLa+nH4Wi+FN1pN2qcbvqHIR7otQfoQlalMkw87IR+nh4GjHlRC2yY+aj07x7Zne zGxtELORRMhqCmhbzrZiK6h4L9mSjjEbD0e/BNWv1R3qQVzAWwb6BmkzUoGpIqPCgA0+ 2ObdH2Pg4hawFfFic1Il4G3F/+ejKXGEvbg5eg2rTiwMZw7T8927WOyZTHdoi9Cab9u+ ja/WP8lvKP5PRcbOA34iZHYDbBB8sQnBVMJ+5O9kafsYw33rMK6sYehTkd+7FNKb5q1e OVZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G3glF1N1lkKRH3me6ZqnttV9WJnWFWFCivroWGr8uPw=; b=nhjlqVN1GC51zHbnzj/OuOLqTWtpAMslCMM/rNSEHQQk41Vvi71XegfmwWLyEkLChk bqjeK0rez2/XThKH+6d+8Q2bOIsH8GQ819rLcBIhXB37NK1l+zlOk3qICHoPt/kn/ZQ+ RCMWD6ym9tCAgtSsO1nHE6UvaSXMWshtkhyqOXw7G7Lq9UKgl7zxWdakzmc0/3CRX9Ts wLyq6tInqANiH0fpryhTLbiKmA2MPz/kECRoQLj5PW9482ZngzBRmkgR5wOj9eKNe9rj Wf7t1H4xuS6SS7gU9iomUdQ864yUhuuPp6Fk7S2SJq5zY+Qgw5rFNyD+cqVZtVIkcuXy G9Ow== X-Gm-Message-State: AOAM531AVI2SJjR0UkkzxKt5yGytyv3QrORp6+srRmREbD8Pq090Fjxc L71Hlh0uXicCHvKNG/aAyiA= X-Google-Smtp-Source: ABdhPJz2mcdlrFcmvMvPOd4zB8ruKzEKevBlh0oNjAFvQiI4OOjKtV9AXzvbEK94SOMfNeMR9xysnA== X-Received: by 2002:a17:903:230f:b0:15e:6e55:3230 with SMTP id d15-20020a170903230f00b0015e6e553230mr12264443plh.35.1651505887371; Mon, 02 May 2022 08:38:07 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 08:38:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers Content-Language: en-US To: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris , Florian Fainelli References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-16-gpiccoli@igalia.com> From: Florian Fainelli In-Reply-To: <20220427224924.592546-16-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/2022 3:49 PM, Guilherme G. Piccoli wrote: > This patch improves the panic/die notifiers in this driver by > making use of a passed "id" instead of comparing pointer > address; also, it removes an useless prototype declaration > and unnecessary header inclusion. > > This is part of a panic notifiers refactor - this notifier in > the future will be moved to a new list, that encompass the > information notifiers only. > > Fixes: 9eb60880d9a9 ("bus: brcmstb_gisb: add notifier handling") > Cc: Brian Norris > Cc: Florian Fainelli > Signed-off-by: Guilherme G. Piccoli Acked-by: Florian Fainelli Not sure if the Fixes tag is warranted however as this is a clean up, and not really fixing a bug. -- Florian From xen-devel-bounces@lists.xenproject.org Mon May 02 15:38:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:38:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318972.539006 (Exim 4.92) (envelope-from ) id 1nlY8M-0004N6-V8; Mon, 02 May 2022 15:38:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318972.539006; Mon, 02 May 2022 15:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlY8M-0004Mz-RA; Mon, 02 May 2022 15:38:46 +0000 Received: by outflank-mailman (input) for mailman id 318972; Mon, 02 May 2022 15:38:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlY8L-0004Mg-AH for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:38:45 +0000 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [2607:f8b0:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2a26a1e-ca2d-11ec-a405-831a346695d4; Mon, 02 May 2022 17:38:44 +0200 (CEST) Received: by mail-pf1-x42e.google.com with SMTP id a11so12586974pff.1 for ; Mon, 02 May 2022 08:38:44 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id j11-20020aa7800b000000b0050dc76281basm5027174pfi.148.2022.05.02.08.38.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 08:38:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2a26a1e-ca2d-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=xdAYU3mu3q5iKW/q53x7SG0PmMFu/IJ99F9X+I1LBFA=; b=n+sdzeWg2S/gnK+vDOIvL6IUbN3m/ZsZjzFb11eZoR9Ocah7YJVO2WiV41qchObcfb DQoBAV7ZWycdznoAT+bkWgo/wu+1wDV1bIUkSxqup4K24uuli3THOxTxyw5X5d53wgme WcsN0rdXUDiQCbaE2BiYM+YRj9TzgmIUMpvqiw3DgUAYB77r1iQIEojYxiA62BjPH8RM iKwEObMzsKXIe5T1OWURADziMPdtdHkUN1OxLhRHsrdiQj28siLmQYHweNGUt6WE2RWU 4RoD4QWsGkku1xASAbiwviIYb1qjscuQqHCmPnV7Xwb2MQ5+T3WoFFqH/wvbUUW3/9i6 dZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xdAYU3mu3q5iKW/q53x7SG0PmMFu/IJ99F9X+I1LBFA=; b=I/6lQeGBnenymKULwkkEwjVJr2D/uLw2HMMBTb9vb6gACcP82kxFHK04bgq35QnL0O tT0azgAfzlyShrvFdjlseQ33Uc9l4Nme+PKONgucu/eh+4yEhXrNzK8sske6ZCjIE/JY E987uTiB7z7hc3qxZgvkdZZoY6n0CCGqAoKGR8+85qIrIwbl8DJd1FRvQA7G1QsuA16Q gIQh8fxv4RaSYykG9w7yJK0WpD4pQi00Gjp34qJtS7dchrc8Lsd5u3RVhrzGOGZgO3Xl Jcj9+ym8pPeHy7OeyImGEQiQMha56h70rJDmxHXeMR/1mv6R8xpPkds0vHNf2hmt370A JPJQ== X-Gm-Message-State: AOAM530v1yxIfh5WKFyh7j2LiTQlXxL8+1WX7HAXhG8NiUw5Sfxeu8fq U0K9Re+2wBbcvUiDzjmX7oQ= X-Google-Smtp-Source: ABdhPJyFyZFQ5alP4D0nGrJsTy5roBCXXaX5AecPC5DucA/TU9ZDaKugYKQuLpePce1AAM16r6umMQ== X-Received: by 2002:a05:6a00:846:b0:50d:f02f:bb46 with SMTP id q6-20020a056a00084600b0050df02fbb46mr4382838pfk.74.1651505921477; Mon, 02 May 2022 08:38:41 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 08:38:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 06/30] soc: bcm: brcmstb: Document panic notifier action and remove useless header Content-Language: en-US To: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris , Doug Berger , Florian Fainelli , Justin Chen , Lee Jones , Markus Mayer References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-7-gpiccoli@igalia.com> From: Florian Fainelli In-Reply-To: <20220427224924.592546-7-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/2022 3:49 PM, Guilherme G. Piccoli wrote: > The panic notifier of this driver is very simple code-wise, just a memory > write to a special position with some numeric code. But this is not clear > from the semantic point-of-view, and there is no public documentation > about that either. > > After discussing this in the mailing-lists [0] and having Florian explained > it very well, this patch just document that in the code for the future > generations asking the same questions. Also, it removes a useless header. > > [0] https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@gmail.com > > Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") > Cc: Brian Norris > Cc: Doug Berger > Cc: Florian Fainelli > Cc: Justin Chen > Cc: Lee Jones > Cc: Markus Mayer > Signed-off-by: Guilherme G. Piccoli Acked-by: Florian Fainelli Likewise, I am not sure if the Fixes tag is necessary here. -- Florian From xen-devel-bounces@lists.xenproject.org Mon May 02 15:40:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:40:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318982.539016 (Exim 4.92) (envelope-from ) id 1nlYAJ-0005nj-BI; Mon, 02 May 2022 15:40:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318982.539016; Mon, 02 May 2022 15:40:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYAJ-0005nc-8I; Mon, 02 May 2022 15:40:47 +0000 Received: by outflank-mailman (input) for mailman id 318982; Mon, 02 May 2022 15:40:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYAI-0005nQ-1y; Mon, 02 May 2022 15:40:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYAI-0004UK-0D; Mon, 02 May 2022 15:40:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYAH-0008EM-L4; Mon, 02 May 2022 15:40:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlYAH-0001tj-KX; Mon, 02 May 2022 15:40:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2NTze6KmgjOByQ9tW3kWZVjDpGkSU+YnmTo8ZwnBW20=; b=Qu/ihuFQcFB1fUqfVJZ9k85pWl n6QWNwmJ3o2zRVZMqmBqyIcCizeJhc3516m3Y0V45fY7Grx/lZPwQFy4Pkxcw8PJzkoxWE4zVoPNN z6HOH1C5rbomAJVlJ9X0+M8a9vxrQnZOCtdX5snk+E535OYsqoY8g+Lx9L01Ya6OcXWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169995: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 15:40:45 +0000 flight 169995 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169995/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 761 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 53 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 15:49:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:49:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318991.539028 (Exim 4.92) (envelope-from ) id 1nlYIE-0006gS-5l; Mon, 02 May 2022 15:48:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318991.539028; Mon, 02 May 2022 15:48:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYIE-0006gL-2j; Mon, 02 May 2022 15:48:58 +0000 Received: by outflank-mailman (input) for mailman id 318991; Mon, 02 May 2022 15:48:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYI9-0006gE-Uh for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:48:56 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ce7e187-ca2f-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 17:48:52 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlYHE-0006n9-M1; Mon, 02 May 2022 17:47:57 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ce7e187-ca2f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lSY7Wy5DSWONSGouYm7Vnq+8PpTXyI6/GSbK7cQgCdQ=; b=RlBNIlGd1Uln2EauUT9Bs8LHDK lsVxakNgNxOntg3zLwYjCz6zOIS7+wkzSqZEsUYLo84tU2IRVM3hBykPTK2LYoUlT7/mcdyUpbUFn 8zsviqZPpC67uRPZkrddN0YT9DyHem+ksVhTVubBHX9U/sp2ORRnik8vQd9AygK72JtMh2IYdh8l4 tTpjZfKpvJI67kl00fIHJVuD+e4FxpA6/fe+9WzqT6PUlM32LuzphP5qVuRzYjTVTCNB0OrF3F4Xd tFHwZ3zAtgZeXLXoEMwxv3kOugrwYBERBngMA0b8PvfrRDptBdxsqHAO3vzW13Xb6GPVwUXCxoyeQ X1mlzNhw==; Message-ID: Date: Mon, 2 May 2022 12:47:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 06/30] soc: bcm: brcmstb: Document panic notifier action and remove useless header Content-Language: en-US To: Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris , Doug Berger , Justin Chen , Lee Jones , Markus Mayer References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-7-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/05/2022 12:38, Florian Fainelli wrote: > [...] > Acked-by: Florian Fainelli > > Likewise, I am not sure if the Fixes tag is necessary here. Perfect Florian, thanks! I'll add your Acked-by tag and remove the fixes for V2 =) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 02 15:51:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 15:51:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.318997.539038 (Exim 4.92) (envelope-from ) id 1nlYKU-00083G-Ij; Mon, 02 May 2022 15:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 318997.539038; Mon, 02 May 2022 15:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYKU-000839-Fp; Mon, 02 May 2022 15:51:18 +0000 Received: by outflank-mailman (input) for mailman id 318997; Mon, 02 May 2022 15:51:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlYKT-000833-S3 for xen-devel@lists.xenproject.org; Mon, 02 May 2022 15:51:17 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2d74348-ca2f-11ec-a405-831a346695d4; Mon, 02 May 2022 17:51:16 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlYKD-0006x9-MY; Mon, 02 May 2022 17:51:01 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2d74348-ca2f-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vs1TxitJVaqXfZt5+JAgzgpJc3Rl9y+sqSF7sQt0958=; b=CYM+I+cStAj6nsmkdvAL01St6e IV8WQNLOxWhy3UHpXhc9ZYxNJzq7ZxpyOwHWort+30gmSz14Tjb7K8kvM2hGR2PPX3dc7GXMEaskm g34Tjq/8qIJgML47/2DCuEUnFB03pqMfnk/uwmQB09CDWgBvh7TL/gFDoH0TI9HOJ3bezLUV1DrKv MwXxD9LKMhdDIB0wdDr6Kr32RysL68LVvKOkDfa5SERbORMzBS0ZyutauBA2Ekqa3472ChMBhe54V 1FaXK1lleaqm8beFaaq7IO5wyd2Jb5T5RV+lvaTO/6luDzRXN43duubtlHaOQOQQCOGaRTF8O2nxl BUemy2kw==; Message-ID: Date: Mon, 2 May 2022 12:50:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers Content-Language: en-US To: Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-16-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/05/2022 12:38, Florian Fainelli wrote: > [...] > > Acked-by: Florian Fainelli > > Not sure if the Fixes tag is warranted however as this is a clean up, > and not really fixing a bug. Perfect, thanks Florian. I'll add your ACK and remove the fixes tag in V2. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 02 16:45:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 16:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319004.539050 (Exim 4.92) (envelope-from ) id 1nlZB1-00064x-Hl; Mon, 02 May 2022 16:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319004.539050; Mon, 02 May 2022 16:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZB1-00064q-Dq; Mon, 02 May 2022 16:45:35 +0000 Received: by outflank-mailman (input) for mailman id 319004; Mon, 02 May 2022 16:45:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZB0-00064g-VX; Mon, 02 May 2022 16:45:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZB0-0006PT-Tk; Mon, 02 May 2022 16:45:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZB0-0001fm-MF; Mon, 02 May 2022 16:45:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlZB0-000862-Lm; Mon, 02 May 2022 16:45:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wUjenZrcMeaysdxp2CH3BFIlMVrTiGvNnfNMbuH0WYc=; b=DSOESyCopudFeYE3B+8nSu5xSq xfAlbdQtJjHhSh7Vk6FsF96JyTEGMaNw9l4B8FjeTOCjQXPdtAqzxXzBlcK/NT9gfNdmpaDPmI9ps nROUs9qxw4RHFTvS7QrgxC9xDIzu50X3R1t4xN+EEgH8QIeuiRGlq4iVXH5m9ASpT2Sg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169998: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=cabd96ad03603a63a97e701fb30a03341ca0e2ec X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 16:45:34 +0000 flight 169998 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169998/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf cabd96ad03603a63a97e701fb30a03341ca0e2ec baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 762 attempts Testing same since 169904 2022-04-30 08:10:33 Z 2 days 54 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5855 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 16:46:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 16:46:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319012.539061 (Exim 4.92) (envelope-from ) id 1nlZBy-0006hK-0U; Mon, 02 May 2022 16:46:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319012.539061; Mon, 02 May 2022 16:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZBx-0006hD-Td; Mon, 02 May 2022 16:46:33 +0000 Received: by outflank-mailman (input) for mailman id 319012; Mon, 02 May 2022 16:46:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlZBw-0006dS-KE for xen-devel@lists.xenproject.org; Mon, 02 May 2022 16:46:32 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b4673d3-ca37-11ec-a405-831a346695d4; Mon, 02 May 2022 18:46:31 +0200 (CEST) Received: by verein.lst.de (Postfix, from userid 2407) id 6CCEA68B05; Mon, 2 May 2022 18:46:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b4673d3-ca37-11ec-a405-831a346695d4 Date: Mon, 2 May 2022 18:46:25 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Richard Weinberger , Johannes Berg , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Mike Snitzer , Song Liu , Stefan Haberland , Jan Hoeppner , "Martin K. Petersen" , linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, dm-devel@redhat.com Subject: Re: fix and cleanup discard_alignment handling Message-ID: <20220502164625.GA21569@lst.de> References: <20220418045314.360785-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220418045314.360785-1-hch@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) ping? From xen-devel-bounces@lists.xenproject.org Mon May 02 17:47:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 17:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319024.539072 (Exim 4.92) (envelope-from ) id 1nla8c-00050u-F5; Mon, 02 May 2022 17:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319024.539072; Mon, 02 May 2022 17:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nla8c-00050n-Ap; Mon, 02 May 2022 17:47:10 +0000 Received: by outflank-mailman (input) for mailman id 319024; Mon, 02 May 2022 17:47:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nla8b-00050d-1C; Mon, 02 May 2022 17:47:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nla8b-0007i3-03; Mon, 02 May 2022 17:47:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nla8a-0003UX-D8; Mon, 02 May 2022 17:47:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nla8a-0008Iy-Ci; Mon, 02 May 2022 17:47:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E2Kg6xkyB8f0pVS21W0R9q6shvh9VJ5vuGau6yrXuJ0=; b=SMhXDoB75e+l/cZ0l4eseVhrCT B8zUTBWw1WhgXx80LEodMsWZXR78UucyaIZcjulEAZoqjOPQkdHEvpbPXq7eSeyh4eErEr3my/Jg/ grQNtloJCj2InfwqBKA5mx0YnYC9m+e8oytaxq2Ni4cb1wAPSO23zpnH6rGoVwspuhiE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 169999: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 17:47:08 +0000 flight 169999 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169999/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 763 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 19:16:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 19:16:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319034.539083 (Exim 4.92) (envelope-from ) id 1nlbWa-0006NO-Ut; Mon, 02 May 2022 19:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319034.539083; Mon, 02 May 2022 19:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlbWa-0006NH-Re; Mon, 02 May 2022 19:16:00 +0000 Received: by outflank-mailman (input) for mailman id 319034; Mon, 02 May 2022 19:15:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlbWZ-0006N7-Qb; Mon, 02 May 2022 19:15:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlbWZ-0001Du-Ok; Mon, 02 May 2022 19:15:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlbWZ-00064Q-Gg; Mon, 02 May 2022 19:15:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlbWZ-0006bu-GD; Mon, 02 May 2022 19:15:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YLLbTVLnp6ktSc03E9PAP5qd1RrATKBhr695N1X/5LE=; b=lnYyGVlIWeBHtLtE3hEar6w59I Hg0e25Ft52tdRf5durfJK8CdO2PS4O3RYC2kg9dHjAS8VjmZPyx0aseVGMC5H8GHXB3Bkuady4Gxt nk0XrdVdYhJE/qxWbTsAUQbd9R6ToQ2lUBzYRRCaqmuy5QrrUL5V3A35jJ7N6I5MhIcQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170000: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 19:15:59 +0000 flight 170000 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170000/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 764 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 19:47:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 19:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319042.539094 (Exim 4.92) (envelope-from ) id 1nlc0g-0001YY-Bl; Mon, 02 May 2022 19:47:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319042.539094; Mon, 02 May 2022 19:47:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlc0g-0001YR-8m; Mon, 02 May 2022 19:47:06 +0000 Received: by outflank-mailman (input) for mailman id 319042; Mon, 02 May 2022 19:47:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlc0e-0001YL-FP for xen-devel@lists.xenproject.org; Mon, 02 May 2022 19:47:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1c8c4a6-ca50-11ec-8fc4-03012f2f19d4; Mon, 02 May 2022 21:47:02 +0200 (CEST) Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 15:46:55 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BYAPR03MB3670.namprd03.prod.outlook.com (2603:10b6:a02:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Mon, 2 May 2022 19:46:50 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%5]) with mapi id 15.20.5206.024; Mon, 2 May 2022 19:46:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1c8c4a6-ca50-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651520822; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=HB4Y8wJWBDAzylDxMDwxvwIlOKRQhdHJuvY1tOk96Xw=; b=JFhjFwgmh022LDHQLm1vZfe2/zrkkCAK5bnfZnTfQ2CCXqjj5ac3fvdi YuM+7q2IrX7ESXibhghTR8VltRGcWEqACTHPckogN3MDOhsKIjTLAIr6L rzYkYiCNk/dvCmylwY0S6Qr6EVXNjbffnCa+lCEW2i3X86yk24UnJkTP7 4=; X-IronPort-RemoteIP: 104.47.58.109 X-IronPort-MID: 70288830 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zaxlv67pk4PID6dDlX+VWQxRtKzBchMFZxGqfqrLsTDasY5as4F+v mtLD2mHOveNNmfweo9xaNuzoEJUvZWDyIBlTFY5+ylhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhWVvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurShcSAzeaLvnt8AbEV3MHonNvR2v5z+dC3XXcy7lyUqclPK6tA3VAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YAjV/chegXdRraT +UUbiBgYVLsfhtLM08/A5Mihua4wHL4dlW0rXrK/fBnsziIlGSd1pD1PYrRJIyYa/ltuUC4j D3n20ikLjcFYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3N 0UR8zForu42+UqkX9T5dxK9qX+A+BUbXrJ4Eusm5QXI2qfSywefGmUACDVGbbQOuMYwRDEuk FyIh97zLTt1ubaRRDSW8bL8hTiyIykOMWgaZSIeCxRD6N3quoIbgRfGT9IlG6mw5vXtFCvry i2QhCc7jrQXy8UM0s2T/l3ZgjTqvpXAVBUy4C3QRH6g5wVyY4i+eoi06F7Uq/1HKe6xTFabu 2Mfs9OD9+1IBpaI/ASVTPgXBriv+96MNTTOhlgpFJ4knxyv/H6lO4JRyDB4OEptdM0DfFfBb UPcsBkX5ZBXMWCrZLRfc4O1CsI6i6PnELzNTPfeb9wIeJF3eA+O4yhGbFSVmWvqlSAEuLsjN JKsVNejBHcXF4xq1DOzAewa1NcD4yki2SXoXZ39xBm9+bOEYTieTrJtGGCSY/8w9r/CgATR/ 9tVLcKMxz1TV/f4bzPI9pQQNhYBKn1TLY7xr8tbZ+uSOD1sEWsqC+LS6b45cokjlKNQ/s/q8 3+zHGxFwlPkjnzEAQmNcHZucqzoR5Vk63k8OEQEJk200nIuZYKu6qY3dJYte7Qjsut5wpZcT eQBesiGKuRCTHLA4Tt1RYP8pYp7aRWtgyqBOiOkZH40eJsIbwDR4drlYgvH/TEDFDaqrtA5p 6C81wTdWtwIQAEKJM3fcv6ownu6tGIRn+80VEzNSvFfZ0Dz2IFvIj72iLk8JIcRKn3rzz6by y6XBxkCrOXAqoNz98PG7Yiapp2gH+R3A1ZTGkHU6L+3MW/R+W/L6YVaUe+OOy/aU2/v0LWjY eRT37f3N/hvtExNucxgFKltya8vz9Tqrr5eiA9jGR3jZVOhAKImL2KG2cRKv6tlybpQuA/wU UWKkvFRPLSPKcr/HHYUOgs+cu3F3vYR8hHV6fUrIUjgoit++bCKS1l6IRCQhTcbIqEdGIo+w aEj/tEX7wC+jBUCPdOPjyQS/GOJRlQ6WqU6stchAYnkiiIi0FQEapvZYgfu4ZaTcZNPKE4uC mSRiKfIwb9bwyLqeWA+E3TE2+kG3MwmtxVDzVtELFOM8vLEgOQqxhJW2S42VQlI1lNB3v4bE m9vOk5uLKOC5QBhgsRZQnusEAFMAh6e0kHpwl5Pn2rcJ2GvUmHON2Q7Nfy64FEC82lccz5Y+ 5mV0G/gFz3teanZ0iY/QVJlqrrmZdht6haEk8eid+yeFJ4mfSXpqqCrbGsM7RDgBKsZjkDBj eR6+/p5b6zmMGgRpMUTDoiR1b0UDheeNmFGafh7+eUCGmS0Rd2p8T2HKkT0dsYTIfXPqBe8E 5Y3fpMJUAmi3iGTqDxdHbQLP7J/gP8u4pwFZ6/vImkF9bCYq1KFra7ty8Q3v0dzK/0GrCr3A tq5m+6qeoBIuUZppg== IronPort-HdrOrdr: A9a23:Quj+0aHy6nCjv0SwpLqFRZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskd2ZJm58erwcpVoMkmsjKKdhrNhcItKPTOW81dASbsP0WKM+UyFJ8STzI9gPM RbAuRD4b/LfD9HZK/BiWHWferIq+P3k5xA8N2uqkuFOjsaCZ2IgT0YNi+rVmlNACVWD5swE5 SRouBdoSC7RHgRZsOnQlEYQunqvbTw5dzbSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X TZkjb++r6ov5iAu17hPi7ontRrcenau5l+7f+3+40ow/LX+0KVjbFaKv6/VfYO0aaSARgR4Z /xSlwbTrxOAjvqDxqISF3WqkbdOX8VmgLf4E7djn35rcPjQjUmT8JHmIJCaxPcr1Etpddmzc twrhSkXwo+N2K7oM3R3am9a/hRrDvCnZPiq59is1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgm/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M1OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDaDhgPAJ6e X8uZNjxBwPkm7VeLKzNcdwg2zwqU2GLErQ49Ab4YRlsbvhQ7euOTGfSTkV4ridn8k= X-IronPort-AV: E=Sophos;i="5.91,193,1647316800"; d="scan'208";a="70288830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PeGEtBK13Kr2uoq4U2hxP13PV69QjYAseZFn3P5vt9lli7q1Kf2Bj0lBtzhZQ0YzSU2nZnde9nvCsIQpCsag8b3X9+KB5APmo7s5SpP2JFjp1iU4maU1CNUlwlDDVqjsW56pAmGb3dxECF5oKWlRjvARk9dZ5PdFx9QZ8nu3PTIU6KwkmldxTE63Pl1AWNPl5cnB6MLAZ4FVVn21R5TD+3O+MZTOT4lchKypJB0qnD3iHJ3Qj0TUjaU+T3x3Ptig6It8YHgnx/VjM5WF6yM2TGjbGSfTJsEFqcQdyfSCCNw3ZS/nVdSjlKkM2RCEirHY/zikbVzktK9BIa7lj9hbDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HB4Y8wJWBDAzylDxMDwxvwIlOKRQhdHJuvY1tOk96Xw=; b=b55twerj+FKZm+HqTTI9+9t31iisPoX2s7oHa0vrSAM5H0RoNJwi+TxB+XL8HLNbxnkO93fygJh8PCSNmTbOy/q8UXPtSl65+Iruvil092ZYibokeWC2/9b4MZoNaqU5ulU1Gr2g8PTR94vm3ZPo04F1liqE9dPSnYRwUtl3+CGhfpXYbjdByyhaFmVN03HTC9kLcvbIdOlVtxu+j3M2fX+W9ANJY7k+K3bAcpG/QIixcpnNBQTBjIkILrhJe/Otqkd4btoO4TO6p2PC1MReg+w8HAw0fQ2+78RzF7g23O5QHhfaqDVL1BPg6tl05o5HeRA4V0eCxGG36yQxMdsckA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HB4Y8wJWBDAzylDxMDwxvwIlOKRQhdHJuvY1tOk96Xw=; b=iG9dxqb5K+DQDFz6TGeIqzZraNFI0QSjeD6FJGHMVoHxX60/4kCJiX60U2rgLm7Yd9GV81eLNQSnkQ7psfE+m4ie56WalgEiph/KEpWIO48flz73D5mT8nlErNEY3nMr4JSIIz4f+6NCODvJvWIAYBnD1tswfIzcxPuIIKGZwmo= From: George Dunlap To: xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?utf-8?B?UGlvdHIgS3LDs2w=?= , Brendan Kerrigan , "Thierry Laurion (Insurgo)" , Oleksandr Andrushchenko , Oleksandr Tyshchenko , Deepthi , Scott Davis , Ben Boyd , Anthony Perard , Michal Orzel Subject: [ANNOUNCE] Call for agenda items for May Community Call @ 1500 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for May Community Call @ 1500 UTC Thread-Index: AQHYXl1doA7M8Ltyq0S/JPt3Y86FNg== Date: Mon, 2 May 2022 19:46:49 +0000 Message-ID: <28B256D8-2359-474C-8AF3-0A2BC4CE1719@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3693.60.0.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11c4cd2c-6239-4871-b6f5-08da2c747fd4 x-ms-traffictypediagnostic: BYAPR03MB3670:EE_ x-ms-exchange-atpmessageproperties: SA|SL x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pBeYcKzQ5foSfcweWi5wKnh8j/aAqs9Ta5RcCTT5ytSHosJlWmG6/BZZyy4MQAfVSXFOl/E+fb6RXHJHHgO57qOpEhOSUP73Ds4V+qeipIffWRabHryjwjN65m4StK0bOa4T3JDzXiISWnKU+YhFGrnyYMhNpJ5pSz2bZeU7kdOqZd+GT2noyc0lSSGWOao7EQAnT+mPGMW8VCGLC952XreI/zGgdQLZMBaHS7ocfClLXXrxo3GqJnIH1f9vTqwg7TfLQ9lmLWV88rtps8zHVlfRogJPbLDFvXRxBomUNAFqdtDri6c9tvbGtmc6wDfRoLX9s0VLc1elYDL6UnqgWexJ4Jr2dKvVdFtF1tErTgAwqUGLfexy8RYViocSblYP9z/i1OtN10zwqImDTm1yx/1vfj2qJm3le1idArlEFJKz3bvw97N+VO0DReTCl0Tr3bZkRK0kTefAmhpEBrAmM+3K1+1LxvqrHxKktRp4APuGNhmHoivBZ3cUyXr6/3HgTWJZIsKdR4vj+rVRlwvB9+3qtvRHNxgJy1MkpAkGGoEIKhEctHzyFwiMnS7iK6lO2zHItkYLbzkjLpvFlu09Kn7JrSf/ExIRoYSZwVHE/9I/XpBlPaC5efxYx2oO0Expbirva9EwiVlh8taSb854efxfDXrT8tZZREs8/YtsRLu2Ozxy55qhTMGwKsueUDj08kWqgibYIIsBdHbJ4s1gMHthH5RoAptdCEw255u9rdDvKvdeWM+Dx1uQPbFp4dtIZS7SAC1WUPAMVpU76YWsSwF7MCFy96gRXQwGI3dkd16jD/ZPfaZQKv6ePKD7nBP/hFxUnC/1YZ2xY/lgugjrParT63ujFgBDFIjPphcCiapProOZrraOwn5eAj3NjLqgt1h6KpbGUbdQ9ApimhOw8Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(82960400001)(26005)(966005)(38070700005)(8936002)(122000001)(508600001)(6486002)(71200400001)(33656002)(7406005)(5660300002)(7416002)(38100700002)(86362001)(2906002)(6512007)(110136005)(83380400001)(6506007)(36756003)(76116006)(64756008)(66476007)(66946007)(66446008)(66556008)(91956017)(8676002)(2616005)(186003)(921005)(221023002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TW9ta1lxc3RFL09EMjBWSmh5cjNLVWtzT1g0S1VjNzFodTFEcFZVSEZlM05W?= =?utf-8?B?d0ovRDM1aG41SloxT1grc3owUy9zV3JoWlVYa0FDU0FqOVhQd1Fwb0F2ZTND?= =?utf-8?B?UGgzanpHanZLak1BQ2MzZHBlUHFUb1IrWWVwSHc0bWFTai9PRnY1L0g1ZTFY?= =?utf-8?B?aGJJa0JBSkZHcnRGdlFrT01RVVRieHJZUEVFN2FuRmppMUh3Q1llNGU2UXZt?= =?utf-8?B?S2pvbjZjWmc3NGdxRDYzRkRYdmN1b0xxWDFCM0NwS1ZFYXNnYkxRSkNzWFQ2?= =?utf-8?B?aVpPcEJXSlB2bmR1emE2RkNKa0dNWHpBVVlFdndaWGxUVHN3bjFGOWZlY0ZS?= =?utf-8?B?RWM5eVZuMFArSTJDbzV6aWNzdVFQRk5PK1haRHdVVk9odmJRVDllZUY5dlJR?= =?utf-8?B?TVRkN1N3ZmZpODdxTzNTZkNvNCtCVTRiMlpISCtvODBoaTJRbWRCYlZFaGFy?= =?utf-8?B?eHF4Y09FamNFbWgzMlByWHBxVC9vaS84TGpuL3lZMFFvVWF1cFhmNElPWFRL?= =?utf-8?B?N01zMFNnbUswMjVocXFCQzJ4WlgxYVFRa0hjTkYyVlYrSVJJT2hMbFRsQWpV?= =?utf-8?B?WXU4OWZ4SUlFZFg5MjkzaUZQRVRTUUxXb1B1cnFRU1pWY1BEN0R3UTVMRDdq?= =?utf-8?B?NHpLZEt5eXR6SFhDY0NCUmp2ejhXR3ZHOFNLNWlpRHpYeU9ZM1lmVnZuWHJQ?= =?utf-8?B?RUhzMDhyTXNPVlZXRDhyQTh1NVM0bXF1R3NSc0l4NWxlcGNSTUw4dE95eXly?= =?utf-8?B?a2l0YlliMDQzNUpOVDcyRUUzeHRlTTh2QjJoSzFnZldxV3htQ3dkSWpTR2lB?= =?utf-8?B?Uy9vMmYvVTNYcy9pc2R0dW5kSjd6WkY0anV6TVI4SHJWdzNGMTZjblhVL0py?= =?utf-8?B?MmZNNFU0MzJrdnh2SXhSY05vVGFTVFcyZmdKQWpKVkZqbFkyL3JjS3hHZmhQ?= =?utf-8?B?SWdIaDc2MXF6YkpTWEw2ckhSeEVXVzd4NFBMNE9lZW0yeldwcEllbzN4dlRM?= =?utf-8?B?MUFoTmVKZncxSndieVBJYWt4TGIyaWp3RW1nVkR0ZWtCdGtlWlFOVXFVNDJi?= =?utf-8?B?Z1NQSFVpTEk2K1hWVVFJSWovK0dCZXJZb1o5UGVjZzR2OWo4UU1LNEsrQzBC?= =?utf-8?B?c1R0VWEwc0VPOG5vS2xjRkFZU2t3WklBMllUU2NOeGlXWDE3TTV0NGpLekpj?= =?utf-8?B?bTBFRXlVS2xJZU0wQUt3UTVzS3I3MExJeS96KzdzUTlOdlJMbGtIRnZENW1P?= =?utf-8?B?SS9xTm9PTHdRdW9BMmc5cC9hMXZhOURZM1FINExCZ1R3ZEUwblFEd21ZMENO?= =?utf-8?B?V05BcTBtaWtKSHhMek5xUFBJUUpUSWs0ZTBtU0FiNGZkQlB5aHc1dlNpTFk2?= =?utf-8?B?bnBlaHVCYXFGK2JIdUxIdnFoK2dnWjJZV0ZidVJZU3I3NjRiZXE3WW9OUG52?= =?utf-8?B?b3M2SlQyeWNGdWR0V3lWR1VabkM2WXQ4ZFN6OXU5eFJBSTdQcGxtQk5Bd0dL?= =?utf-8?B?alZtUHYxeUlUVDNwNGhEcWtXcGM0eTdqVkt5aGhvakZ1bTFSYVhOVkRPa0Ur?= =?utf-8?B?NjhyczE1anYrY2o5SHR4Y2VQdFRGSGhDK3NuUFlpQXZ2UmljcDk2amZOOGZp?= =?utf-8?B?M2xQSlNxWnlxMkhVeWlybEU3aTFJdFZMd2lsQzRkL25IbDBiNjVoMlBYYVdx?= =?utf-8?B?dlRyVzdObnBBS2pLcXVNS0VIajVIVFppbW9OYzdMQmJ6SUVzWW8zZHc1bFN6?= =?utf-8?B?RGZRNTRNU1BZU2pjUEgxL0Vub0ZYVTE3dFNhSkYxLzNiKytLLzBhZWc3UGRI?= =?utf-8?B?ZGpNS05ZQTFEbmoyNmpwRlZDREsybElFelZxT3pQaDN2Qk41REJ4VVhCV1Vk?= =?utf-8?B?VG9NcXpoakJ0Zklyc3FGREorUlhCL001RmNYdnRpSWd6d1JJUkx1YUcraUNi?= =?utf-8?B?eXlGOUxKVzArQWttMTJOUG8vejA0d2JtVGYvZDhtaGc4WEZkM0J0eGh5WU8y?= =?utf-8?B?Q1I0a1RMR3Fia1hLWGRYZUtheFRQMVpQQURiVzlaWFlwUmRDWkFKc3kzR05S?= =?utf-8?B?Y0tCQUl1Rjd2bUkxOFJ4KzhDUGl1QUtuWGRqeXlaMEtyOEQ0QVVFVnhxZFN6?= =?utf-8?B?Qlg3aU9FVUtmcG8rZ2R3QnB6aU5yQzJocmVnVVZCMUZ2eHFwanJySGJsU0w1?= =?utf-8?B?WVF1RmNpZHc5VmhwZEkxdCtqUGwxMUIwd29uWVVsb3dBUUEzTzNJc2h0aXBO?= =?utf-8?B?OGlUczgzWmx2cEhtc1k1aThLUjQ3aFpOaWNYeW02d3loNVhGYXNGbXQ2MWI5?= =?utf-8?B?SlhMQTd0TkVQd0pNRnlEa0pUVXRxTkhuYjNqU0tDWVprdXFZMng3OWJReGZ4?= =?utf-8?Q?Ne1xR0w3sn1Y4itY=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <19BAFDCA01EDEE499B96D364E62C2103@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11c4cd2c-6239-4871-b6f5-08da2c747fd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 19:46:49.8196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DxAtXYFj24EvURbgV4MMd7PTz4mcJcU9fXw/jdun6AEVKQlvdqgz8YF+rt8uW4qNpJschdzeOVJbLeHdtOAddSvugUAE+ACAaVTnQL5Uz4c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3670 SGkgYWxsLA0KDQpUaGUgcHJvcG9zZWQgYWdlbmRhIGlzIGluIGh0dHBzOi8vY3J5cHRwYWQuZnIv cGFkLyMvMi9wYWQvZWRpdC9VTmE2eFZKZ1p0RHNtc2N1OHIzUG1zVUkvIGFuZCB5b3UgY2FuIGVk aXQgdG8gYWRkIGl0ZW1zLiAgQWx0ZXJuYXRpdmVseSwgeW91IGNhbiByZXBseSB0byB0aGlzIG1h aWwgZGlyZWN0bHkuDQoNCkFnZW5kYSBpdGVtcyBhcHByZWNpYXRlZCBhIGZldyBkYXlzIGJlZm9y ZSB0aGUgY2FsbDogcGxlYXNlIHB1dCB5b3VyIG5hbWUgYmVzaWRlcyBpdGVtcyBpZiB5b3UgZWRp dCB0aGUgZG9jdW1lbnQuDQoNCk5vdGUgdGhlIGZvbGxvd2luZyBhZG1pbmlzdHJhdGl2ZSBjb252 ZW50aW9ucyBmb3IgdGhlIGNhbGw6DQoqIFVubGVzcywgYWdyZWVkIGluIHRoZSBwZXJ2aW91cyBt ZWV0aW5nIG90aGVyd2lzZSwgdGhlIGNhbGwgaXMgb24gdGhlIDFzdCBUaHVyc2RheSBvZiBlYWNo IG1vbnRoIGF0IDE2MDAgQnJpdGlzaCBUaW1lIChlaXRoZXIgR01UIG9yIEJTVCkNCiogSSB1c3Vh bGx5IHNlbmQgb3V0IGEgbWVldGluZyByZW1pbmRlciBhIGZldyBkYXlzIGJlZm9yZSB3aXRoIGEg cHJvdmlzaW9uYWwgYWdlbmRhDQoNCiogVG8gYWxsb3cgdGltZSB0byBzd2l0Y2ggYmV0d2VlbiBt ZWV0aW5ncywgd2UnbGwgcGxhbiBvbiBzdGFydGluZyB0aGUgYWdlbmRhIGF0IDE2OjA1IHNoYXJw LiAgQWltIHRvIGpvaW4gYnkgMTY6MDMgaWYgcG9zc2libGUgdG8gYWxsb2NhdGUgdGltZSB0byBz b3J0IG91dCB0ZWNobmljYWwgZGlmZmljdWx0aWVzICZjDQoNCiogSWYgeW91IHdhbnQgdG8gYmUg Q0MnZWQgcGxlYXNlIGFkZCBvciByZW1vdmUgeW91cnNlbGYgZnJvbSB0aGUgc2lnbi11cC1zaGVl dCBhdCBodHRwczovL2NyeXB0cGFkLmZyL3BhZC8jLzIvcGFkL2VkaXQvRDl2R3ppaFB4eEFPZTZS RlB6MHNSQ2YrLw0KDQpCZXN0IFJlZ2FyZHMNCkdlb3JnZQ0KDQoNCg0KPT0gRGlhbC1pbiBJbmZv cm1hdGlvbiA9PQ0KIyMgTWVldGluZyB0aW1lDQoxNTowMCAtIDE2OjAwIFVUQw0KRnVydGhlciBJ bnRlcm5hdGlvbmFsIG1lZXRpbmcgdGltZXM6IGh0dHBzOi8vd3d3LnRpbWVhbmRkYXRlLmNvbS93 b3JsZGNsb2NrL21lZXRpbmdkZXRhaWxzLmh0bWw/eWVhcj0yMDIyJm1vbnRoPTA1JmRheT01Jmhv dXI9MTUmbWluPTAmc2VjPTAmcDE9MTIzNCZwMj0zNyZwMz0yMjQmcDQ9MTc5DQoNCg0KIyMgRGlh bCBpbiBkZXRhaWxzDQpXZWI6IGh0dHBzOi8vbWVldC5qaXQuc2kvWGVuUHJvamVjdENvbW11bml0 eUNhbGwNCg0KRGlhbC1pbiBpbmZvIGFuZCBwaW4gY2FuIGJlIGZvdW5kIGhlcmU6DQoNCmh0dHBz Oi8vbWVldC5qaXQuc2kvc3RhdGljL2RpYWxJbkluZm8uaHRtbD9yb29tPVhlblByb2plY3RDb21t dW5pdHlDYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon May 02 20:31:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 20:31:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319050.539105 (Exim 4.92) (envelope-from ) id 1nlchK-00078b-NE; Mon, 02 May 2022 20:31:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319050.539105; Mon, 02 May 2022 20:31:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlchK-00078U-KJ; Mon, 02 May 2022 20:31:10 +0000 Received: by outflank-mailman (input) for mailman id 319050; Mon, 02 May 2022 20:31:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlchK-00078K-4I; Mon, 02 May 2022 20:31:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlchJ-0002sG-VS; Mon, 02 May 2022 20:31:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlchJ-00015c-IV; Mon, 02 May 2022 20:31:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlchJ-0005Zk-Hn; Mon, 02 May 2022 20:31:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AKyW6sWsUJi3SIrBKZ0MkOS/cOGhy++mIYWjmWDxvxw=; b=0nMnuTRctFahdfBUF2DydDzdVh KlpVIHVJhIZbGSjcnLooOpDDdEGRDq9ZcVfVVLp2xRai72QQcYG5sceoMZ08fAVdMsnJ+mo0e8qgV 6BRv4u1MkWqmCyDTpKHoyzx6YHWPGlOuiOBy1CV2dXIHFbq2xc4FEzkicdcYUG+l2bSY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 169990: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 X-Osstest-Versions-That: xen=fe234237b6fc8afc5d8265850169ceeb3d2f81fd From: osstest service owner Date: Mon, 02 May 2022 20:31:09 +0000 flight 169990 xen-unstable real [real] flight 170002 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169990/ http://logs.test-lab.xenproject.org/osstest/logs/170002/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 170002-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169976 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169976 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169976 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169976 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 169976 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 169976 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169976 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169976 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169976 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169976 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169976 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169976 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 baseline version: xen fe234237b6fc8afc5d8265850169ceeb3d2f81fd Last test of basis 169976 2022-05-02 01:53:05 Z 0 days Testing same since 169990 2022-05-02 10:08:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Elliott Mitchell Jan Beulich Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fe234237b6..702c9a800e 702c9a800eb3ecd4b8595998d37a769d470c5bb0 -> master From xen-devel-bounces@lists.xenproject.org Mon May 02 20:36:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 20:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319063.539136 (Exim 4.92) (envelope-from ) id 1nlcmt-00089g-KP; Mon, 02 May 2022 20:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319063.539136; Mon, 02 May 2022 20:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlcmt-00089Z-FO; Mon, 02 May 2022 20:36:55 +0000 Received: by outflank-mailman (input) for mailman id 319063; Mon, 02 May 2022 20:36:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlcms-00089M-0d; Mon, 02 May 2022 20:36:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlcmr-0002yV-Ry; Mon, 02 May 2022 20:36:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlcmr-0001Io-B5; Mon, 02 May 2022 20:36:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlcmr-0002mY-AZ; Mon, 02 May 2022 20:36:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LGNq/4/1EF+UDHHEzCCC22RHJYW5BMuMnm2TeWy2aW4=; b=2WqkqdQRbUm7sbjc2cX8X2xRIw BP1HdsoIdSWbqMd4xFF9dy4WWFTWSBjSlx7FMBU3LER3O/wrZF3TOl5SMDX93tjqsVv5Zr4EbbROj uavJFpmiwhItTmi8CqlzKY8fh2+dEj8i4V4lv7r4RfSmp9/bDbHjDAyr+la3W65jVwCs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170003: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 20:36:53 +0000 flight 170003 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170003/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 765 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 21:41:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 21:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319072.539147 (Exim 4.92) (envelope-from ) id 1nldmp-0007Ht-Df; Mon, 02 May 2022 21:40:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319072.539147; Mon, 02 May 2022 21:40:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nldmp-0007Hm-AE; Mon, 02 May 2022 21:40:55 +0000 Received: by outflank-mailman (input) for mailman id 319072; Mon, 02 May 2022 21:40:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nldmo-0007HZ-2C; Mon, 02 May 2022 21:40:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nldmo-00043B-0i; Mon, 02 May 2022 21:40:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nldmn-0003nk-KC; Mon, 02 May 2022 21:40:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nldmn-0000EJ-Jk; Mon, 02 May 2022 21:40:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l9HFXsRRogqevll5swsU4gtjaZtFpBsDTdYGzKf3SkM=; b=L9JXQ3anCloeoVC9k53cZVreZz sKMwJZSTWfc/8Ei9TA8dCxdxvAEm7uoElszmiaMmIBIuNX0hzUfGtpM0izLl0s7zz8m+4LTBy6bzD GQpV7apXGR/3Su8bBI85doxoICv7OOlMAQN/YXrQo9VD4X3DvSEICjykAUD79H/TGnb0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170004: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 21:40:53 +0000 flight 170004 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170004/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 766 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 21:59:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 21:59:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319082.539157 (Exim 4.92) (envelope-from ) id 1nle5A-0000em-0n; Mon, 02 May 2022 21:59:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319082.539157; Mon, 02 May 2022 21:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nle59-0000ef-Tp; Mon, 02 May 2022 21:59:51 +0000 Received: by outflank-mailman (input) for mailman id 319082; Mon, 02 May 2022 21:59:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nle58-0000eZ-Hk for xen-devel@lists.xenproject.org; Mon, 02 May 2022 21:59:50 +0000 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e67ed13-ca63-11ec-a406-831a346695d4; Mon, 02 May 2022 23:59:49 +0200 (CEST) Received: by mail-oo1-f43.google.com with SMTP id y27-20020a4a9c1b000000b0032129651bb0so2812633ooj.2 for ; Mon, 02 May 2022 14:59:47 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s1-20020a4ae541000000b0035eb4e5a6c8sm4329464oot.30.2022.05.02.14.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 14:59:46 -0700 (PDT) Received: (nullmailer pid 1863055 invoked by uid 1000); Mon, 02 May 2022 21:59:45 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e67ed13-ca63-11ec-a406-831a346695d4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OfkNLJQzEZ7e5xPqfxUYJG64Wv+bQWkevq09mi7Lx3c=; b=1nvu9oD9eIBdroHecgTEnH39iR4WVlM5SyP7duD1aghiwNg634NAEOXU/5X2ENrlVf TNFWAXcCkVGdc+7pb6Pz2uvAlQr3Ei9kwq7kMO2uMhpOW75g6jKWSByV9jFW5P6BCZCA qyyXgjwylTCG93/QrCsfhzx+w6QYMGjOYMwSBTQy3ZOS2bYOMrLXfmjPig42w7MdaH0j t98xUjmz+5p+0a2GQo/uWmPOzLsbv4hKSRn1c7sY2PHuhnO/36RI0BzWsX1z/ODM7dgr +VeqQtjhjKBv17J/3/o7H+cMfVoGY6THBe4KRzIdUFWn80ZYsFJFkVlKX0pv/ZcFtJOC kTzA== X-Gm-Message-State: AOAM531riSKYhyorDYdQg/63GygjbE3Z0PYaS+f+BJIM2ENwDavqPKFg XY0H1ve4mMk44kbpP4wvRg== X-Google-Smtp-Source: ABdhPJx1LDExPGSXpHz8IMEURBsoMHXT9iZfDmEKZxw3kRgHSp4/DSf2T1IKY9UfgGxULbEh9lAUBQ== X-Received: by 2002:a4a:ac45:0:b0:35e:a8f2:7f55 with SMTP id q5-20020a4aac45000000b0035ea8f27f55mr4805941oon.46.1651528786470; Mon, 02 May 2022 14:59:46 -0700 (PDT) Date: Mon, 2 May 2022 16:59:45 -0500 From: Rob Herring To: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650646263-22047-5-git-send-email-olekstysh@gmail.com> On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings scheme needs to be > enabled for the device which DT node contains that property and specifies > the ID of Xen domain where the corresponding backend resides. The ID > (domid) is used as an argument to the grant mapping APIs. > > This is needed for the option to restrict memory access using Xen grant > mappings to work which primary goal is to enable using virtio devices > in Xen guests. > > Signed-off-by: Oleksandr Tyshchenko > --- > Changes RFC -> V1: > - update commit subject/description and text in description > - move to devicetree/bindings/arm/ > --- > .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > new file mode 100644 > index 00000000..ef0f747 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xen specific binding for the virtualized device (e.g. virtio) > + > +maintainers: > + - Oleksandr Tyshchenko > + > +select: true Do we really need to support this property everywhere? > + > +description: > + This binding indicates that Xen grant mappings scheme needs to be enabled > + for that device and specifies the ID of Xen domain where the corresponding > + device (backend) resides. This is needed for the option to restrict memory > + access using Xen grant mappings to work. > + > +properties: > + xen,dev-domid: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The domid (domain ID) of the domain where the device (backend) is running. > + > +additionalProperties: true > + > +examples: > + - | > + virtio_block@3000 { virtio@3000 > + compatible = "virtio,mmio"; > + reg = <0x3000 0x100>; > + interrupts = <41>; > + > + /* The device is located in Xen domain with ID 1 */ > + xen,dev-domid = <1>; This fails validation: Documentation/devicetree/bindings/arm/xen,dev-domid.example.dtb: virtio_block@3000: xen,dev-domid: [[1]] is not of type 'object' From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/virtio/mmio.yaml The property has to be added to the virtio/mmio.yaml schema. If it is not needed elsewhere, then *just* add the property there. Rob From xen-devel-bounces@lists.xenproject.org Mon May 02 23:06:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 23:06:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319093.539169 (Exim 4.92) (envelope-from ) id 1nlf7d-0008LD-Sy; Mon, 02 May 2022 23:06:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319093.539169; Mon, 02 May 2022 23:06:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlf7d-0008L4-Pg; Mon, 02 May 2022 23:06:29 +0000 Received: by outflank-mailman (input) for mailman id 319093; Mon, 02 May 2022 23:06:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlf7c-0008Ku-He; Mon, 02 May 2022 23:06:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlf7c-0005Uk-Ft; Mon, 02 May 2022 23:06:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlf7c-0006Lc-0C; Mon, 02 May 2022 23:06:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlf7b-0007Ox-Vy; Mon, 02 May 2022 23:06:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hIq/L+lf8TGgTNrhXjlr6k1i3wU0JIjNoSh2WpfimjE=; b=AQ29j1H98O5CwryHWxLq+JQD3U okCyR+nBlcJfYjQBhFuq/EoWO7rUAUjmMN6uW5z/SSa/8G5H335yb1FpiRfzTavFpK0AaVLSnPMV2 G4nHM64Faaa0qghLj2mwUmpkrNOuvCQglmf4LG3KTcRKoFo0ULe0HieegPFiSFTFkyBo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170005: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 23:06:27 +0000 flight 170005 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170005/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 767 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 02 23:54:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 02 May 2022 23:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319102.539182 (Exim 4.92) (envelope-from ) id 1nlfrV-0005V0-K3; Mon, 02 May 2022 23:53:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319102.539182; Mon, 02 May 2022 23:53:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlfrV-0005Ut-HD; Mon, 02 May 2022 23:53:53 +0000 Received: by outflank-mailman (input) for mailman id 319102; Mon, 02 May 2022 23:53:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlfrU-0005Uj-Ns; Mon, 02 May 2022 23:53:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlfrU-0006I5-LO; Mon, 02 May 2022 23:53:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlfrU-0007hk-Aa; Mon, 02 May 2022 23:53:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlfrU-0001On-A9; Mon, 02 May 2022 23:53:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F+CO15htAxbJOmWjWmdDfeiEhyaFUbOMiJc9qdr7Wvg=; b=BHODI3y5gye6sl73skYDT3sr/J Gv9qCF2/sl5jk8tYWHzR2ETzMKC6yy3LiiMR1hG48pf181wqu1TtiC/RrxGrP2vyrQBwCryWOlNa2 gTEpM31ptpQGXa5tLt+gfyfJWOOn2E+HA05jbHR5sfQ0eDdMstBdTmqIef85AFOSa2Xg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170006: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 02 May 2022 23:53:52 +0000 flight 170006 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170006/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 768 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 00:36:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 00:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319115.539206 (Exim 4.92) (envelope-from ) id 1nlgWb-0002Pg-Oh; Tue, 03 May 2022 00:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319115.539206; Tue, 03 May 2022 00:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgWb-0002PZ-Le; Tue, 03 May 2022 00:36:21 +0000 Received: by outflank-mailman (input) for mailman id 319115; Tue, 03 May 2022 00:36:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgWa-0002PS-D9 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 00:36:20 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bdac6c5-ca79-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 02:36:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 567D9B81AEB; Tue, 3 May 2022 00:36:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C138DC385A4; Tue, 3 May 2022 00:36:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bdac6c5-ca79-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651538176; bh=8ExZoNEzyhAcwZ0cSJzhH9XGdXeQ6MMfKD5tj7Bb4ZY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=KDX4xqpF35m7drFuTvjMYHfmX5RGer/dB18+lQSj7+OHJPy+up/yxha/A2A59WyHo 8khOs/zS7iZzWdv2fHDmro/YNSBKhA5RKKAoX/dRku7ZuEepph1pzBpAieHo6phs+7 5Z0bkiMfXSMaLDNwCabEIrWPiRArFFChm2w+xQ4wXggLr1KyMwcRAQ7oY08NBwv97j PgkTgXXRh5TSiMmxzpa+UHfPb+OxmGV5VJj3q4g8oLwMxvLIsBqriqxp7C6Q/31tLX 83DhIhbzQFgbL6PadRAbxkX0qmgIit6ChW96uQPERspLjRPeeGXFIiJEuTz+tmYyn8 4L27+lYDCizzw== Date: Mon, 2 May 2022 17:36:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Boris Ostrovsky cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini , jgross@suse.com Subject: Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain In-Reply-To: Message-ID: References: <20220429211027.2034134-1-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 29 Apr 2022, Boris Ostrovsky wrote: > On 4/29/22 5:10 PM, Stefano Stabellini wrote: > > From: Luca Miccio > > > > When running as dom0less guest (HVM domain on ARM) the xenstore event > > channel is available at domain creation but the shared xenstore > > interface page only becomes available later on. > > > > In that case, wait for a notification on the xenstore event channel, > > then complete the xenstore initialization later, when the shared page > > is actually available. > > > > The xenstore page has few extra field. Add them to the shared struct. > > One of the field is "connection", when the connection is ready, it is > > zero. If the connection is not-zero, wait for a notification. > > > > Signed-off-by: Luca Miccio > > Signed-off-by: Stefano Stabellini > > CC: jgross@suse.com > > CC: boris.ostrovsky@oracle.com > > --- > > Changes in v3: > > - check for the connection field, if it is not zero, wait for event > > > > Changes in v2: > > - remove XENFEAT_xenstore_late_init > > --- > > drivers/xen/xenbus/xenbus_probe.c | 86 +++++++++++++++++++++++------- > > include/xen/interface/io/xs_wire.h | 3 ++ > > 2 files changed, 70 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/xen/xenbus/xenbus_probe.c > > b/drivers/xen/xenbus/xenbus_probe.c > > index fe360c33ce71..dc046d25789e 100644 > > --- a/drivers/xen/xenbus/xenbus_probe.c > > +++ b/drivers/xen/xenbus/xenbus_probe.c > > @@ -65,6 +65,7 @@ > > #include "xenbus.h" > > +static int xs_init_irq; > > int xen_store_evtchn; > > EXPORT_SYMBOL_GPL(xen_store_evtchn); > > @@ -750,6 +751,17 @@ static void xenbus_probe(void) > > { > > xenstored_ready = 1; > > + if (!xen_store_interface) { > > + xen_store_interface = xen_remap(xen_store_gfn << > > XEN_PAGE_SHIFT, > > + XEN_PAGE_SIZE); > > + /* > > + * Now it is safe to free the IRQ used for xenstore late > > + * initialization. No need to unbind: it is about to be > > + * bound again. > > > This assumes knowledge of bind/unbind internals. I think we should unbind. I gave it a try and there is a problem with unbinding the IRQ here. If I do that, later when xb_init_comms calls bind_evtchn_to_irqhandler, the event channel doesn't fire anymore. I did some testing and debugging and as far as I can tell the issue is that if we call unbind_from_irqhandler here, we end up calling xen_evtchn_close. Then, when xb_init_comms calls bind_evtchn_to_irqhandler on the same evtchn, it is not enough to receive event notifications anymore because from Xen POV the evtchn is "closed". If I comment out xen_evtchn_close() in __unbind_from_irq, then yes, I can call unbind_from_irqhandler here instead of free_irq and everything works. My suggestion is to keep the call to free_irq here (not unbind_from_irqhandler) and improve the in-code comment. > > + */ > > + free_irq(xs_init_irq, &xb_waitq); > > + } > > + > > > > > @@ -959,23 +988,42 @@ static int __init xenbus_init(void) > > * > > * Also recognize all bits set as an invalid value. > > > Is this comment still correct? I can improve the comment > > */ > > - if (!v || !~v) { > > + if (!v) { > > err = -ENOENT; > > goto out_error; > > } > > - /* Avoid truncation on 32-bit. */ > > + if (v == ~0ULL) { > > + wait = true; > > + } else { > > + /* Avoid truncation on 32-bit. */ From xen-devel-bounces@lists.xenproject.org Tue May 03 00:57:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 00:57:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319123.539223 (Exim 4.92) (envelope-from ) id 1nlgqd-00054D-IF; Tue, 03 May 2022 00:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319123.539223; Tue, 03 May 2022 00:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgqd-000546-Dy; Tue, 03 May 2022 00:57:03 +0000 Received: by outflank-mailman (input) for mailman id 319123; Tue, 03 May 2022 00:57:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgqc-00053w-8z; Tue, 03 May 2022 00:57:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgqc-0007xu-1T; Tue, 03 May 2022 00:57:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlgqb-0000tN-FN; Tue, 03 May 2022 00:57:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlgqb-0002SP-Eq; Tue, 03 May 2022 00:57:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/FtyFNTPHn8g6ETFrxXr1n2QVqAsMj+yPPWkJqihY9o=; b=Y/PgGfoCseysqLyYxXIS64B63N YU0SaO+mE/C6nSzd9IO88h4fUx1KDbP5w7IKLWhyMHPaGCCN51YUomNXmQ3zGtKQ2z7JCHymOItLk I3myaKKMGDAmbH/TJMstObiIuu2NKaesOPYjrn/iw3E6TN0AaIR+oUCIPA1EXhG4pdNg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170001: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9050ba3a61a4b5bd84c2cde092a100404f814f31 X-Osstest-Versions-That: linux=672c0c5173427e6b3e2a9bbb7be51ceeec78093a From: osstest service owner Date: Tue, 03 May 2022 00:57:01 +0000 flight 170001 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170001/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169977 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169977 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169977 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169977 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169977 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169977 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169977 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169977 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9050ba3a61a4b5bd84c2cde092a100404f814f31 baseline version: linux 672c0c5173427e6b3e2a9bbb7be51ceeec78093a Last test of basis 169977 2022-05-02 01:56:06 Z 0 days Testing same since 170001 2022-05-02 19:09:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chung-Chiang Cheng David Sterba Filipe Manana Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 672c0c517342..9050ba3a61a4 9050ba3a61a4b5bd84c2cde092a100404f814f31 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue May 03 01:21:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 01:21:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319131.539234 (Exim 4.92) (envelope-from ) id 1nlhEB-0006mY-Gn; Tue, 03 May 2022 01:21:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319131.539234; Tue, 03 May 2022 01:21:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhEB-0006mR-D6; Tue, 03 May 2022 01:21:23 +0000 Received: by outflank-mailman (input) for mailman id 319131; Tue, 03 May 2022 01:21:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhEA-0006mH-2U; Tue, 03 May 2022 01:21:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhE9-0006FA-S2; Tue, 03 May 2022 01:21:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhE9-0001Ow-Gx; Tue, 03 May 2022 01:21:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlhE9-0005qq-GU; Tue, 03 May 2022 01:21:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZBwHTE+5yuMme/Hdd4Zcth78xfcMPlDPFhqiyGhpQQI=; b=qzChPu6C+nPmGH1wCPFoxYbVDY /ji3eWSfvmOcqycpbSHzUXtmjXyFVgDDSoxheo5pZ9g0vrzMZXsF+r83m1Vb0xhjD++3mEPeltOcf RYkjicCrKYfqVA62RJTyxVctQOWBlyqP4rnEfg1WyJTdNns8bbGS5GZ5v3WYfuSP6Cuc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170010: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 01:21:21 +0000 flight 170010 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 62 days 769 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 01:51:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 01:51:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319145.539250 (Exim 4.92) (envelope-from ) id 1nlhgq-000238-34; Tue, 03 May 2022 01:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319145.539250; Tue, 03 May 2022 01:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhgq-000231-02; Tue, 03 May 2022 01:51:00 +0000 Received: by outflank-mailman (input) for mailman id 319145; Tue, 03 May 2022 01:50:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlhgn-00022v-Vo for xen-devel@lists.xenproject.org; Tue, 03 May 2022 01:50:58 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 775fb837-ca83-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 03:50:54 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 242MZb6Z026110; Tue, 3 May 2022 01:50:49 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruhc4nub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 May 2022 01:50:48 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2431fmrg004581; Tue, 3 May 2022 01:50:48 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fsvbkx41d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 May 2022 01:50:48 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BN6PR10MB1475.namprd10.prod.outlook.com (2603:10b6:404:44::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 01:50:45 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5206.024; Tue, 3 May 2022 01:50:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 775fb837-ca83-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=wQW2wD7NFcfGazO8HUUSdyAhxwbex56NYFqrnyb5eJo=; b=sDcxCdkA87S/uqC0d/KOC/7oBVjMKAY/47yN3kiTPveTmDsR41cso4CrX1vXcBrKILlo uDczA1cERqJG/HDnALlxzCaijIc92Lg+QMvMGOnaiqsu+VlQsTKzyrZtzN2Q+W40MLXa prSM8uFRbIFzOCupX5VFz0PR6QjXFK/dqpEuGCvw2XDJa08q18pMHb9hdP6J2xK7Zse5 Q2QN3yKgBEUioxcnYt3UfqRN9REbkFxcrMSpxduLXXczw5BJMx371WodY5RtvwlSjzxm gjTdqUh4dsQEKsWUwwvLy+gcKBCX2PRtLS2Xr0xsTuZBswX4SgvITp//eZ7Yj9iRT9mo QQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FO+xsOcRFQ64WWNoy6SPgol4/CEtu0WNqnUA1sWLUdUV62eDFy1PgTMDr+/wRYoQkqjOzHi6TSk2PyNuNgLQbNETe7jLbsEN1jr9ME8fr2X0NS+JreMoMtJyx6/d/4gkZQWE3ESvy7Mox/fGscJDiorSWMvBVLEuUNsIYUEk/26mj1JMR5Md6yhy5YoCJds/2zwnqRsTb+h4h8Li/LiMh7UutGNGMh63lLd+x6CK8ZJSsr+oBYYa18nvXRXqHw7xflKhHWrpnv7gjdppY1wZXTbjs2NuwRYG8POddx2aSfA4nKQlpUW7GUl/0zlXpGrGkMVd2YzdFyRxIP7HixbZbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQW2wD7NFcfGazO8HUUSdyAhxwbex56NYFqrnyb5eJo=; b=DVMdVZhLdDzWfe8JaBGkINQapZWNL9CGiE6T0bqy7QW06/tPtY6ZIqjaIaGFoL/9q1xdFWyDQSTJ913VGO8713JQ+Aw96+683df0lYUH9JqPELunm51C18jR8HsjweYXXAZd5jur65v65qfnGreR/tyZhKWKiqnB/K3ItW1qZdsdfGsPolw7jBvSkc/izmaz4CPj2rtc7vKp9HgAUC0v0szoiPytd8/uPBDTdBD9utdL8BCKu5bamNV918Hnh9nMt9k9/lwJS8gSZM3Jcta4M6OaB11FhIZZ611KsYaV8wkx5ST9eV7ocMQPD5hcywPCVWuFGuGmUcxVPEvOB9lqAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQW2wD7NFcfGazO8HUUSdyAhxwbex56NYFqrnyb5eJo=; b=hnlbX04dKIIIEg26HxaUk3fOTa8PCFOE4SzQIDTVnVjpqAuCS7/S0hsPmy+OrsAPvATazmlUqTgMmpdzLW5wqSj34dtEMCHaJ6GTuKpxJnVvaaDtWfEJdzTwhOmopK5Mh/IkkO4VPw5Z6iSv4pAsAFoheSJib+ZPIrnLdDnt0Ek= Message-ID: Date: Mon, 2 May 2022 21:50:42 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini , jgross@suse.com References: <20220429211027.2034134-1-sstabellini@kernel.org> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN7P220CA0010.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::15) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e09e3b83-7625-4602-23ca-08da2ca756b0 X-MS-TrafficTypeDiagnostic: BN6PR10MB1475:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wBKklxB1CEdznIjDPJ6Y2Sy2GDto/YG8VuMBXQ9x3rZm2S2gZLEs7aXr37sUGcf1tlSDRyTSVnThRRqlgL0yUWAiVBi4NAUzbqMY8ddOq6qoLk/J1iwhOsXQc/ra0hblkQBzIepzDWZV99a24bMpjo8pOgX3LTiQv0dvQCaVnBfsHZYaVZ/ifyiQU4GUGtafO4hlW2Pqi6qotNp9dS5Bx4qG34VG468RLCkECxGTZbwzx0yaqLl1+YOBIAP2PL14OaWm1ixDTJaYTLUNTpQ1772Xh8InfAeGCya4msDJW+WQh++hAw0cr6dfoQJAu2TJHvUA/EVS0m3Zux10lD9igVJdLZcpXKazBR0X7nKubw8NzgiWfDHgLs0P4usbLvlWOURW+RJVmMNBNbdcTGSeDfb7VUvdwlBaqnES7dHVgJc8ew1tWbLyUA++fEFLUYzLzgzbHUJLLBN70AKLC40vC4adMuECCHchJ4bX/hrZqULydELhb22EkmAZjfLct3ka9fgrlvSsqWrnNCxdKUlJC/dai3ntJ6g9kmIlT2ok83/v+Yc07GpMQF5JKyUa5LC42MrknMzt+s570rFQvsDyvU3o9NDoYmtE3v0EZ2fiJznfrila9YIS2NKfHe0uToiWkw20YX1FGZ9axlEBJtv/axY67lEoFyLXcuxxBN9dRrQqj6A/tGyZp9ffcSMYphxX8EBaqI0XuF1cYIdkK7ylbKA+8y4yXSqiz9G+5kgotC8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(83380400001)(26005)(31686004)(31696002)(66946007)(66476007)(66556008)(44832011)(4326008)(6506007)(53546011)(8676002)(86362001)(5660300002)(6666004)(6916009)(54906003)(2906002)(316002)(38100700002)(36756003)(8936002)(186003)(2616005)(508600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDZTUDEweFhUalIvbkluUGticm5wT0ZqMHBYaGRYQzZuOFJ4VEJuRTJwQnpQ?= =?utf-8?B?YWJuZTdXeThWdXB2ZEp3bVBaU2dmZ3hZZG5jekhtMTdRQXp2OHpqdmxQOC9Z?= =?utf-8?B?SVJ5cnpobkxyWVFNSHltMXhwTWcvazJ1U3NPUjdjMkhWU3crVmlmQXc0aVo1?= =?utf-8?B?c3V4RnRXY2pFWU9JM3diYTMvM3R3bXF0aFRsMDdLVTV5Z0ZYaUlMbWZrcVBl?= =?utf-8?B?R1pIdGQvTHVhWHZ3aGt3cTUzT3Q1Nk5VekRBVll4d05RQ2lKNjJyZWhzMjVs?= =?utf-8?B?NnVPNGdUOXByUVFHL1VwakNWSEtPb2xFYmpyQkxOMHRBOVlMOENtNWhabmJk?= =?utf-8?B?K3VMWkEzdS8rN09BbnhQVnFHOU51c1ZhclFtQnRSQ2ZjYWRmRzg1eWdYckJJ?= =?utf-8?B?Mi9ZU0pIT1IyN0lUL2dTRURZdVc0NkFINGd0Sk5yQjdqZEpJUG41N0VhWTQr?= =?utf-8?B?MEJ5VXNaVy96MTJNL0FyejRhYVloNGhRdER6TFpjbTVKbVozV3lONmFIYnYw?= =?utf-8?B?UkVTQkJJVlNNREQzbDVEQ2U2eEF0L0ZoVDZoUVVHWldhaWR1LzlBZGdWTHZz?= =?utf-8?B?VnFYckdTUWdXVGRVMEVHNFo2dnFSOWg0a3BNTXQ0V3VoSFRaTUVGczBRb1F6?= =?utf-8?B?K0V0bGcrelYxTThYSDV5UjEwaHp5RFl1NWtSZDYzY0NwcWh5TnJxcXJnT2Fz?= =?utf-8?B?a0ZIcnNlWEY1UXlZWXNkeThWSFdIakJLQVhVZXZjTDRoUlR5WnhTWk9vdllW?= =?utf-8?B?U3daNmlPNDBFbXlpQzFGWnk0d1dCYXVrRnlnMHdUV0JWZllSMm9BSHZSejR3?= =?utf-8?B?eVpvL2p3QVMvUFdrTis0UWRYV1FmUDhkMWM1WlBYTXFJeWxpa2tEM3BZSFg4?= =?utf-8?B?V2puVHJaOWJEc3NuMDR1SFNmMkxueHFtVUlBa0YyY3ZMVmtTc2wyTjJkQlEy?= =?utf-8?B?NEN1SGlWZE1FUUhMM2RqSUFLK2ZOeTVIY3VUbC9aTUh4UDdZcUhES3U1SkFJ?= =?utf-8?B?SWp0R2R3UTcvR2w2TnVSd2taTHVEcmJjQnd4eVg0eFpxN0lrWTllY3ArNUFa?= =?utf-8?B?UjB6SVpvL2hveU9RWTlEbGF1aGFaK3E4ZDdFQXQ0a1lNZXJRNlV1TmFDVndm?= =?utf-8?B?WTQ5ZG45VlYxb09PQTY0MHIyWW1WSHpkdGppNnViNFFodUUrbTYzUk5NR1p2?= =?utf-8?B?MlZURktWY01wNmpzdlBuRG1JQ3BNdGY5MkpvVjhSNm8yc2tBVnBJQWtvbGVV?= =?utf-8?B?UmIvaFdLS3VwMEtHQ3orRHdPd2FFVVRFU252WU1nWjNqeWpQcUY0WGU3R0RE?= =?utf-8?B?bDVBRkhlYVBhVGFNSXJLSFFpbW8yUUZXYkJUVzFUNDN0ZUJYWW5OckJTTHN6?= =?utf-8?B?SWRaTFk2NDBtcVVuMUtNd3BHM1JQOE9rQmNmZDRPTitvWUJ3WGwyUll3SlND?= =?utf-8?B?NUpZS1Y4S3RlWlk4V1JXYXptTEtZWU5SSDlDSitXTklGTXdHZjZCeDh1OWdP?= =?utf-8?B?T2JDSG4wOGZ2Qjd2M0lwRS9ZWk9LWXpyaTJBTmRWdHU0RHJKWlQrRGxmc2hE?= =?utf-8?B?YWY3dWNNYmtyckd3TVFnOWg1NURMTzl0LytQMnJVWDBaM0lPVzBLTmQydERh?= =?utf-8?B?bDdFVTNha0d2WVo4N1hYUUREVjQybUlzYkFPT2ZGRWRiVnZqRk5ZMDlHSjkw?= =?utf-8?B?SjhEUnZNQUtSMFJXRThMZkJMTUdEM2NRSVJOZmNpb0hPZnBER2hmTzNRbDJ2?= =?utf-8?B?bk1EcDJ3VUF6bE1FUnN2WjlZU3QyTkZBdWlNNFJQWW1JTE5HZjZsdCtpUi94?= =?utf-8?B?Vmdxa3pxNkhOdjBKendXbllHamVoeExKVHNCNU1NemNsbWozUC83TmxJd2dk?= =?utf-8?B?cHFvK0RiQjhpK3g4bFJUcUswdXBuL3ZkaUZvRG1BdGlTa3VwVllRTitPNEVa?= =?utf-8?B?S0NhZ0loaTErc1h2T1o2d2V3cUp1dEVCaGRVL05leW5ORytrOUVhWnkyMERp?= =?utf-8?B?TW5ZSGVlUk8xYTcxWS9XRGU3ZVo0U2JqQVgzaDc4ay92aU5uL20wdkhKNmFG?= =?utf-8?B?TUdVdGRpeEo0c1E4YTZMOWRHNVZ3TUN5enFrSU5iWFRVT0pPZ0hqTVIwTWlE?= =?utf-8?B?UEpKWlJMZVBzMHhuTmV4Y2wva1ZZVmExR3Q5eW5sZUpRY3JGbUQzcDFGMUhy?= =?utf-8?B?ZDZ0Y3pvRkZlWnpzQ0tKSk9jQ0I2YmZVY3ZwQ01kY0JEbFNvR2tCdHp3THN0?= =?utf-8?B?R0tCRzlmc0swbE9PQ1FlVkMzcTF0QUJpNmgzU2F4U3d4bHZmdm85ei8xWi9P?= =?utf-8?B?Nm00cDdQREtic0Jsc3hOZ0piUHMyc2xDa2xWd1VPT3JpWHA4VW4wTlcyTUha?= =?utf-8?Q?ua04Rv82Ddkzh+bQ=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e09e3b83-7625-4602-23ca-08da2ca756b0 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 01:50:45.3453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4luSmEj3J25dN/cMyp+AZElt8rFzXnmmIRhuz2pxLREJ5k0CIwvUdPQyRWZ+ljW4S9m4smpszcvFzfUgEvQF+Kkw27mQvS7DGTcMO4EGIOU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1475 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-02_08:2022-05-02,2022-05-02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205030011 X-Proofpoint-GUID: 2CS48yCfPDzohwtxyh1_xU74Pcqlw7ac X-Proofpoint-ORIG-GUID: 2CS48yCfPDzohwtxyh1_xU74Pcqlw7ac On 5/2/22 8:36 PM, Stefano Stabellini wrote: > > I gave it a try and there is a problem with unbinding the IRQ here. If I > do that, later when xb_init_comms calls bind_evtchn_to_irqhandler, the > event channel doesn't fire anymore. I did some testing and debugging and > as far as I can tell the issue is that if we call unbind_from_irqhandler > here, we end up calling xen_evtchn_close. Then, when xb_init_comms calls > bind_evtchn_to_irqhandler on the same evtchn, it is not enough to > receive event notifications anymore because from Xen POV the evtchn is > "closed". Ah, yes. That's unfortunate. > > If I comment out xen_evtchn_close() in __unbind_from_irq, then yes, I > can call unbind_from_irqhandler here instead of free_irq and everything > works. > > My suggestion is to keep the call to free_irq here (not > unbind_from_irqhandler) and improve the in-code comment. OK. You could add an argument to unbind_from_irq() to keep the event channel open (I in fact am not sure it should be closing the channel since bind routines don't open it) but that looks pretty ugly too. -boris From xen-devel-bounces@lists.xenproject.org Tue May 03 02:31:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 02:31:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319155.539274 (Exim 4.92) (envelope-from ) id 1nliJm-0007Av-C4; Tue, 03 May 2022 02:31:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319155.539274; Tue, 03 May 2022 02:31:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nliJm-0007Ao-8d; Tue, 03 May 2022 02:31:14 +0000 Received: by outflank-mailman (input) for mailman id 319155; Tue, 03 May 2022 02:31:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nliJk-0007Ae-MC; Tue, 03 May 2022 02:31:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nliJk-0007xM-Gm; Tue, 03 May 2022 02:31:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nliJk-0002up-7Y; Tue, 03 May 2022 02:31:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nliJk-0006i9-76; Tue, 03 May 2022 02:31:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Z38Vhxk2n0srGHGR/eFrLDAA7SaBU5iZ0EGQ5cPbpRE=; b=qGiXyGHQ087Lc0H7NiWh1X8ktO tmltJt43Zi/tUtrBa7cR7PzYqgaYez9IXHbnIx3V2gAqjRBeRDwqyY1nKzt4oU2UDXTNB8apCC7+X 8S+DNBlHg+UFxTn+/s4yXEF2EHXCBIFhjyBdGmtUnzxkv+/uwXni4P8nhm3OSwSRclXs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170013: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 02:31:12 +0000 flight 170013 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170013/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 770 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 03:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 03:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319165.539290 (Exim 4.92) (envelope-from ) id 1nlj66-0004Od-2c; Tue, 03 May 2022 03:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319165.539290; Tue, 03 May 2022 03:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlj65-0004OW-Vh; Tue, 03 May 2022 03:21:09 +0000 Received: by outflank-mailman (input) for mailman id 319165; Tue, 03 May 2022 03:21:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlj64-0004OM-6I; Tue, 03 May 2022 03:21:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlj64-0000PF-4U; Tue, 03 May 2022 03:21:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlj63-0004ec-Pr; Tue, 03 May 2022 03:21:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlj63-0003NY-PO; Tue, 03 May 2022 03:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VSfKUp9G9gX1M3jbB2ToLvpOuhOLnanFTZBmsAeu53g=; b=EztnKlTyhN+YgCWbM9dpur8QTe ct7U3tGfe6sY7hE8jInpySfL7wyJSxdcTWJ0aFRYSPEmLehv8CmOtM0nm2qKMRNgzy9QMqgdUWKRN 8MIPCv2ozNMRRJASufiY5PgsSYT2f+L0sNgMdij5mUlg+ZalV+zpf7X9xkJs5PfvdR4I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170017: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 03:21:07 +0000 flight 170017 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170017/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 771 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 04:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 04:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319175.539302 (Exim 4.92) (envelope-from ) id 1nlkVZ-0005sX-Ko; Tue, 03 May 2022 04:51:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319175.539302; Tue, 03 May 2022 04:51:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlkVZ-0005sQ-Gu; Tue, 03 May 2022 04:51:33 +0000 Received: by outflank-mailman (input) for mailman id 319175; Tue, 03 May 2022 04:51:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlkVY-0005sG-9O; Tue, 03 May 2022 04:51:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlkVY-00027h-7X; Tue, 03 May 2022 04:51:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlkVX-0001av-Rt; Tue, 03 May 2022 04:51:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlkVX-0003zH-RP; Tue, 03 May 2022 04:51:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VpWKFq2vDywt+FHQwqw5IVWT6UfcPU71Ty9EEKIHPG8=; b=Yo7ef5BfbeB5bQBgHua2uaJNh1 mK4BggtM3JUrBu/DNvAezMOhwWw4iP0J5GlsSmyf94u1PxeFHD0cN2FzV/bPGHzQcfOopjeZz49mS HH8MO0Y9jnBgy/t1Jc+nW/5DRUg6clMnZigE5nXYqJWmKuIFvqBjeuo3cACk6SKIizsc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170019: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 04:51:31 +0000 flight 170019 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170019/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 772 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 07:30:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 07:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319194.539336 (Exim 4.92) (envelope-from ) id 1nlmzS-0006eu-QD; Tue, 03 May 2022 07:30:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319194.539336; Tue, 03 May 2022 07:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlmzS-0006en-N7; Tue, 03 May 2022 07:30:34 +0000 Received: by outflank-mailman (input) for mailman id 319194; Tue, 03 May 2022 07:30:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlmzQ-0006eN-Pt; Tue, 03 May 2022 07:30:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlmzQ-0005CG-Nn; Tue, 03 May 2022 07:30:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlmzQ-0000Vd-Cy; Tue, 03 May 2022 07:30:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlmzQ-0007x5-CX; Tue, 03 May 2022 07:30:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gz23C7Z6C1EcX3GpbCImaxzeGz118/8G+YH0eX8ftWA=; b=dqKYf1xj9CYDk9BIDqBX0KXIzw hboSK6d8KjRL8/Ub0rVrjVa4FcgrT87V2TrSkilH+yK+g+EyU7IcCflyxswiaakxWOon0SXAsm1C4 9WBB9VzH1sHeW6Vh1EVVHHXwGL4cVQU5IoLfYV3g8OYJd9BgWvVDT5tCixBNGSYSJ01Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170022: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 07:30:32 +0000 flight 170022 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170022/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 773 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 07:36:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 07:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319202.539348 (Exim 4.92) (envelope-from ) id 1nln4n-0007T0-Fi; Tue, 03 May 2022 07:36:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319202.539348; Tue, 03 May 2022 07:36:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nln4n-0007St-CS; Tue, 03 May 2022 07:36:05 +0000 Received: by outflank-mailman (input) for mailman id 319202; Tue, 03 May 2022 07:36:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nln4m-0007Sj-9Y; Tue, 03 May 2022 07:36:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nln4m-0005Ht-5V; Tue, 03 May 2022 07:36:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nln4l-0000e9-QB; Tue, 03 May 2022 07:36:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nln4l-0002Gf-Ph; Tue, 03 May 2022 07:36:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HEM2Vgnp7c8IUv3n0Qi2pXBQK65zAtSjgsdf0y6UFBM=; b=bJITVl8vvIwWzYbKbL82IUFIEk 7u3eEbv+JkbXY4thC/fpS4a1otdDJyGmTHf1ZoYHqGQNFj+ZoV5Lmr05H37t5xNj+3hGRDevkxAiN OIFnxvE2ITw4CxZ55WMBeKcfV9RgJTbaVJE3YnKaFeRILOYFFPBi1EUQ0V1dPC+mNHOk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170020: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a12b2d8f218a6723ac0e71a2557405bd76123830 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 03 May 2022 07:36:03 +0000 flight 170020 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170020/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt a12b2d8f218a6723ac0e71a2557405bd76123830 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 662 days Failing since 151818 2020-07-11 04:18:52 Z 661 days 643 attempts Testing same since 170020 2022-05-03 04:20:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106233 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 07:51:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 07:51:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319210.539358 (Exim 4.92) (envelope-from ) id 1nlnJB-0001RQ-P3; Tue, 03 May 2022 07:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319210.539358; Tue, 03 May 2022 07:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnJB-0001RJ-M5; Tue, 03 May 2022 07:50:57 +0000 Received: by outflank-mailman (input) for mailman id 319210; Tue, 03 May 2022 07:50:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnJA-0001RD-Ej for xen-devel@lists.xenproject.org; Tue, 03 May 2022 07:50:56 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c08742d1-cab5-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 09:50:54 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 03:50:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO3PR03MB6727.namprd03.prod.outlook.com (2603:10b6:303:165::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 07:50:48 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 07:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c08742d1-cab5-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651564254; h=date:from:to:subject:message-id:mime-version; bh=raXzC/QvFMIC7LrFRabMthRbB4jChzSiAyzuZPY+QK8=; b=OuWkymjnC4JJaRpxZyc0n+snXYQJ1s3EOWJStwXi7WOh4aNqkOiXdtTl YoqlA1Tw1OVfroKeM90mFujC+gbwKvOcXERQVkotFO0Z+e+/aWcaoSh3C Jyaj42RmCLxkMR+d/cgpD/I/rwD6txMg4JFXV3lNuL1XovYUuSkTVERbW U=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 70445231 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:L3mg9ashTumMyr26tMjOOIfKuOfnVAFfMUV32f8akzHdYApBsoF/q tZmKWjTb/vYZjTwLY0latuxpxkOu5+Bn95rTAA/pHg8EXwa+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17V4 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi83IfacqONNSCJmGnAmOaAX5OLuGVWg5Jn7I03uKxMAwt1IJWRvZ8g037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IJmm5v3aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N+fZquTOKpOB3+J7Oc/PRU/bTeZR6ohaHm nuY32bWMg5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM++zM GQR8ysq6KQ3qkqiS4CnWwXi+SHf+BkBR9BXDus2rhmXzbbZ6BqYAW5CSSNdbNsht4k9QjlCO kK1ou4FzAdH6NW9IU9xPJ/Nxd9uEUD59VM/WBI= IronPort-HdrOrdr: A9a23:hevFsKDHEm7QaKLlHehGsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5fEtQ/+xoWZPwJk80kKQY3WB/B9eftWXdyQiVxeJZnPDfKl/baknDH4dmvM 8PEpSWYOeAdWSS5vyKhTVQfexQouVup8uT9J7jJjpWPHRXQpAlyz08JheQE0VwSgUDLZ0lFK CE7s4Cgza7Y3wYYumyG3FABoH41qr2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8zKS+tPOQzAPaygbonuBrseqk7uEGKN2Hi8ATJDmpogG0ZL55U7nHhzwxqPHH0idbrP D85zMbe+hj4XLYeW+45TH33RP77Too43j+jXeFnHrKu6XCNXkHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5uLPSwphmiOP0DIfeNYo/jFiuLYlGfNsRdR1xjIbLH5AJlOy1GkfKp glMCmGj8wmP29zbBjizxhSKZKXLzUO9yy9MzU/U/yuokJrdU9CvjclLewk7wQ9HcEGOut5D9 qtCNUWqJh+CukrUIlaOMAtBeOKN02le2OzDIvVGyWQKJ06 X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70445231" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxGDmcIbVHUce5LwknItGCiObR204uzj+0jBiMGQFsGHPHda09QdwXxlRZIAUbuwQtQvpOaHxMDIl+GIPmzvYq5tg+NhSFLwRMlZ1rIx8p/WYKXfBYS2usw0sAXfJwrumw+1gnmddq5AQTIVLjZTa20t2F7YkzztRaYRJE6DpLuGl4HcilSxgz5Jp3HAbRFvA2E1AHQ35ZpreLPPkZzSHpk4SayaQ4W1WtxAxQkvTCopdxhqQ4j+R4CZVwLZVr3ZKR8z45qWaXnCkoDymRk2XhoJb6S9grMjMij/qdLukrBk3bCxnDx41oANh9ZoxreWTVES5WmZTrSa5Pc8U2K1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dGqLdgLtXKFLolu15b9s7nisL9xDZO7gFtXTaY6FjAQ=; b=XQBWebqpggi6NaImB/vUnzelUEtGYhWN/G5ohKkSTnieQxdJPXAqtmuC3u8+M1UHErNwTPl0l5llUMRMXiE7STSwQi4gustF2nbvmo5Kce11H/eM36/ISXpoJife0CEvVY1JdhCM0gfGFonExEOCl/isjFBI3lg1aLeyjUG6B9lDP3nOzH9pUpHBvpZnyxRPrcVY9yd8EPzoxITzvNOOnUvx+6ac1jLwICVy81ENU2my+q71iHRbW9c9J1RZoLOwZmlHYptUtzXoyTDEBYkTlIf5QFcvnNAPA6oN7XgObICM5LooAyPD7hGJy8F3Fg7ZgNNH9KcTDmdBznPKdybMmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dGqLdgLtXKFLolu15b9s7nisL9xDZO7gFtXTaY6FjAQ=; b=hPZ0xFQDU5CvZZeqexJN45MjVtkH13ueFUxBPoVvByPu5MsCrtGOhNZLPEhkrbUQ+bFej+BissiKfhxMh7GWwwcCm1EODDXz0ALd8hiKNmm9asEoeZCNjhPvm1CW8eCBLn5iucLUqVMVQTrurbEnK+xyAZgnaUEoXiHU0PHbiTM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 09:50:44 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Subject: osstest: blessed sabro boxes Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: BL1PR13CA0234.namprd13.prod.outlook.com (2603:10b6:208:2bf::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b703c5bb-a631-439b-05a2-08da2cd9a318 X-MS-TrafficTypeDiagnostic: CO3PR03MB6727:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LPhgkt+8NWE56fpVej/s6SSNWdsgFUFV3EqucFJeHmqTumYuGiUspKieNJZRqFl/jR1cysZiqYiMR1bT4CcFMlF6Rc2oxd342DIqsfSWuu02z5Ug11knxlzODt9S1XQQt91neVsSe4eEL1WlGurNHR8nhohTCKV1Qu9V7GXqtfKG2r05RwvBlAA25clgxkMIav+KCsG8ZmoG+cSlX6mGjPRwR+GWGwR333v6KdFBGyDh3OhGjCtpyEebVE4a7dnt2o7Aosp8bc680zMdKWL7LwcUymtLaBLix5fd4i+NN7qljftfGW7vM3sdH/fcYmd+RHnDiS0NGi0Q9QtxxB46SDGefE3APXP9WmgnW5FnVpIyNZ9+/iWM3Yh+lzj9a4bNWkfiEsMIoGZHSVeP/IUqvcmG0vPr/ot+32fjrzBBX6nyMNLUgdaatmCw6Pv9QRhGt0pAHmhzxAJHhnxELZJt6wNUvMO7FhuMHCaHlIIlw5rytNeOe2UXZmNctjS682mfXNfVFdbxKwSaAqQJJVIsUWle8d/LKgPJeonqcU2FXiCzGmMWTuei1CXUxdgSEAK1FaQ88atXbFqOw3dkeqjs0enRz16JAWDBX7+f9AIAOl7g+/yJmcmdqIgfZW7CVMn1HPe3HQ9qfaKYnmqYKQF+bkDzQkJHe+HmzV6epZig2PE+wbrtuazh80ysgtXHIyfmKr5LCb3OEQ1SJNKf5FrSIVUWwDWplKqUggqVbdl20ZHoWKeKCMPIznMz4i6TpbiYZqVNALyDQmVyMPdGSo2nHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(2906002)(6486002)(186003)(5660300002)(26005)(6512007)(9686003)(8936002)(33716001)(86362001)(6666004)(66556008)(66946007)(66476007)(8676002)(4744005)(83380400001)(85182001)(38100700002)(6916009)(508600001)(82960400001)(966005)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OURNR2k4c1g1cEwwMk4ybU1TUkNtN1RUTHB6UUZscTVWY2FqQWNSV0NvOTR1?= =?utf-8?B?SlRvNU9vREJ1d0E3U1JURUJ5OXlxRWhBZlpWZUx4Q2tXbjlEVmYxVlJGSnJm?= =?utf-8?B?K0hmRVF2UHFMMWNsU21vMjRqZFJIaWtiQ3IwWmlNdEp4ME9SeUFORFU4NHVU?= =?utf-8?B?Y3BoU0l4VW9vQzNhcXV3OHZ4ZGFpVnEwZ2JJN0VMNWRvbzZmL0hSdkJSL0xy?= =?utf-8?B?Q2NoU1l4WEx1VlhGZk5kd1JVdDZ1L0lFM2pDZ2Y3WFBER0dZREYyVmgrbU85?= =?utf-8?B?YnJPQWVaSldYTUZLNGJSV2dVU1NTWFV4bTV5VmF0eTV6WE5Sajlibm55TnBV?= =?utf-8?B?STVNUVNyTFI2L1JLNXZ2VURoU0c1Vm8xYlN5R2E5eVFmVzkrU056YmFJSmFT?= =?utf-8?B?UlNzYUZNSWdmSnBEUCtrK0QrSkUxZ204RTI3d0VCY0tqNndjdllZQ0d3UXZF?= =?utf-8?B?Y0l5WUdvWi9iR1E2S015RHpwejVzd0oycklocWExMU0wTTIrR0R4YldGQkdE?= =?utf-8?B?NnRyUlpBb0x4VmFhUGorRktuTTZGekxBdGZlM3NHTHlmVmpUR1JobjdtRGht?= =?utf-8?B?bzQyNVQ0enRheENmQmsxSGhtajV5bzVHUWs5dDhJMUlSeSswQlU1dDRVN3lu?= =?utf-8?B?V2dxRXRrazBldUFGaktUa2hZM2VWV2xzU3EvdTBlNXhaanZkdjdVUmdsR3ZG?= =?utf-8?B?aWt5MzVkMGducDNvUUFqalhxUEdHWk9uR1JuTUZodXo0bWlXYjIyN3drYUxB?= =?utf-8?B?RTZ0ODZyWklBeVNNcEdSbERlMUo4L21pQWRvSllPU2NFQTFJaG13ZG5LOXhN?= =?utf-8?B?VjJZN1NFVEUwdlcyM3JOZlY4U284cnluMDZWbUhPbWZMdVBESnhCcHY2V1Yy?= =?utf-8?B?Z09UV3A2VUozZEQrQ2RhbGV3WkZDTTVVQ0pEanVTN3psdHBMQ2RvV25EME9p?= =?utf-8?B?bWdzNFFVcXFNVEFEelhRWkdxNkhQYUFVMUlXS0pOVlRJZURvTDZFNlVBOHZi?= =?utf-8?B?U2wxTkIrQ1VWU1owcG00WUVOTTBpQ2wyQUxXYzVBOU90K1Y4MFBLRlh2TnVB?= =?utf-8?B?bnFkZUxTalcraUNlbTkwcVV3ZEJiVTFPTXJNZlNNRzFhUDl2ZFlVamVnU1ox?= =?utf-8?B?OXIwaWRRbWxxVlJFNTV6Q3k5T1p2K1A5ZW82c29JYndjL21YdWlNaHhuSWZq?= =?utf-8?B?KzhvTGN3UzJVZ250VDI0TDVrRytNcnN0dGJTR2p2UlgxdndnM0RISERmRXk0?= =?utf-8?B?M0c1OG0zWkVLMGh0d1I0dGlZZkNCT3N3eStwUDBURUpVMWs5WTR1UC83RkMx?= =?utf-8?B?ZW9ncVozYUFQVWoveEt6ZGhDditDeStzV1luTWt6V2h5N3RlV3d2c2U3UlJD?= =?utf-8?B?b0pERXd4aVJ0eHVHU2IwTGRMQ1Vkai9YbmlXbFFGYlVoYnJsRFB5dDR6Y0V6?= =?utf-8?B?S3JGQ3VVVHZtakFNMmZlcndCSmQrK2J1dGhWbXh5ZGcrMC9GU0JzSnNOVk51?= =?utf-8?B?WDBxcXBYMU5STS9TanhDTTJNSHhjeVVJbysycHJuVHJSMGpucmY2NWNUUkxJ?= =?utf-8?B?MTBEdDQ5MzJHbUxMeldxTUhLS0VEMmRicjZDU09tODFzZXJvZVpFU2xoSDFu?= =?utf-8?B?OC9lWi9vK09wVDcxUmJYaXRHMW56OXVDV1krVGg0U0YvZkZwMi9LREM3WXNq?= =?utf-8?B?NHBQNUVkbzJpRmZYZFgxNFNLaEdMY2JCUHVKWGxLMWZEMkl4ZTluaUI5MWVy?= =?utf-8?B?dEttdFZPT3JoT093QmthQWdNWGVkREtjMENOdTNTaXI2N2I0WmljYnQrUVhn?= =?utf-8?B?d0tobGFCSlRQeGg4b1UvSVlncENsTGZXajVsVEZLU3ZuS2N0UlR2bWh0eGVp?= =?utf-8?B?b3BRdjhzMFB4ZDAveVpOMkpROXE2TVJ1d0RlVk52YUdBZ3kraGpIbFBxN1pz?= =?utf-8?B?OFM4UkRmZDFkMktQRlJqSW1wN0pkKzZudlZDZTZrdlRmRWlxMFV2UUFLSVpS?= =?utf-8?B?KzVPVTZoNUtwYlM1VGpZdndWamh2UHQ3TDdBMnhuSjRoeEZtcngxb1lpY2lx?= =?utf-8?B?YVR3RVFTU0d4UUE2dnZCb0pVZFBrKzVFazJ4Q1RtcjJ5S2ZHNVF5cXJBQjBT?= =?utf-8?B?Si9OSUhTbEcrdUN2R1ljdURrWUpReUJZanRYWXkrL0kwcTN5LytVUVRvejFy?= =?utf-8?B?dU8vaVNNdmRDYzh3L01OQjhRLzI2M2t4bkNQYW9HZ0Radjlyb1VUZ3k2enh3?= =?utf-8?B?bkNXRU5TTi94cDBuT2xDQ2ZHVlpPYldPTmJ3RXhIOTZkdkh2T2ZqYUF0ekdX?= =?utf-8?B?eGdiUFBHZ3hrcExRWFM2dmdKSk9XajJibEJ1Yncxd3BqdEU2K3NWUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b703c5bb-a631-439b-05a2-08da2cd9a318 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 07:50:48.3225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d3toSh5NSaKq/yZjPCO2j+JPz2Iks9E1ew34r8kbojo7Hbh//jZ4usq4aI1AmOzQ9I9J0b5oE1u3OYrS7/YhLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6727 Hello, I've blessed the pair of sabro boxes for production after a successful commission flight: http://logs.test-lab.xenproject.org/osstest/logs/169857/ Note that the boxes don't seem to be able to boot in 32bit mode, see the following flight where all 32bit jobs failed to install the host: http://logs.test-lab.xenproject.org/osstest/logs/169986/ I have no idea what's causing this, and hence sabros will only be used in 64bit mode. FWIW, those boxes where already not marked as suitable for 32bit installs, I had to add the arch-i386 flag myself in order to test (which I've now removed again before blessing). Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 08:01:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319227.539375 (Exim 4.92) (envelope-from ) id 1nlnTS-0003hu-EA; Tue, 03 May 2022 08:01:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319227.539375; Tue, 03 May 2022 08:01:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnTS-0003hn-Ao; Tue, 03 May 2022 08:01:34 +0000 Received: by outflank-mailman (input) for mailman id 319227; Tue, 03 May 2022 08:01:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnTQ-0003hK-Jw; Tue, 03 May 2022 08:01:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnTQ-0006H3-GQ; Tue, 03 May 2022 08:01:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnTQ-0001FA-5W; Tue, 03 May 2022 08:01:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlnTQ-000899-55; Tue, 03 May 2022 08:01:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mWn2j/NeV6T4J81E8NXC/deX2F3vZKBZ+D2YFmM9/vM=; b=xLazbGH4bqt+ILiGamgstREuD+ 5kGF3qeZDq6xmhje0QtH/RpUDVtQhfpGoVmsv4pYTgGaOs5rmWxiw7kUYznnTCI8MA3a3HPKsSsbN nFsLjnMJm0P1pqz70zU89E/xGGsgp9E25f9Xj2EaNOIja309MyeIfv6RkEuaOjwftODs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170027: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 08:01:32 +0000 flight 170027 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170027/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 774 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 08:17:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319235.539386 (Exim 4.92) (envelope-from ) id 1nlnjE-0005Wi-QY; Tue, 03 May 2022 08:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319235.539386; Tue, 03 May 2022 08:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnjE-0005Wb-Nh; Tue, 03 May 2022 08:17:52 +0000 Received: by outflank-mailman (input) for mailman id 319235; Tue, 03 May 2022 08:17:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnjD-0005WS-ED for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:17:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8547be37-cab9-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:17:50 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-kP7db75DPSOqtJFIQ4iqbA-1; Tue, 03 May 2022 10:17:48 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PAXPR04MB8895.eurprd04.prod.outlook.com (2603:10a6:102:20e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 08:17:47 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 08:17:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8547be37-cab9-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651565869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x46TocwA5uwXVUAnfWFqz6teqZCQXLhrna33aBeU+j8=; b=Ds2msBnZxHrmkGIw2zrY6kYjsuZfPMEo+8csbj0/TFMGZ1OkdH58/m7LeswgVDuSuTwzzJ sKjpL3jxK+sq6u9YOC96oK0NFoVGhrsZWc9/egUddQuAFHlr6QprRuEuPm+fCBjQXGFlcU GVfTY2eqvWWnAc5Ux+hqUn97igtIsHc= X-MC-Unique: kP7db75DPSOqtJFIQ4iqbA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwApJTCcwxcxbrnAqL2neX8lA0Ulh3kNbo89fg0154X8BV2/r8fHGEqb8/Tk7iaxY4FoAAL5afEibSQ+qIrNkB4X2veMfs2TrPqQaL7g+KUkZRiqSfTWz3CawTJu2OOGcurIto/7qIDhuuKevpb5IRDsSMv9VrpHom+TYdCZOp6rg+gVrki8pdrjHvsvMC9VxooYFBr97G33MZkirzUXqkX4ONY0mVY3EpZ8DH2xCLpnWZW9xiVQHvpG2L4iFy1Nk6YP2to5rg69N3o3fuOjbzbnKdUb5VSk+dA5n7IN5Ne6S2RoitU8Ak7G+GMvQzBlOyq6NC1safC1WNrzUIB6Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QnZqch3/2Z5D44xGyAUPkoZg7cZBGL2XMAuJFVXCT3A=; b=UFOy+f7/kNO9MV8NhnyRpAyWgQAVjUKZTcRngsKh+jAItq1d5r+M1Zl3dqHiBVOp+A7aNQZzN6SmRqpqqu6azxAVcP4mzY2AdYf283fC6LHnEKM7MxNBjz9UJH6iqzCvZ+zVWT5anxHbEzo9oqBfzXS8TS/N4oKzxE8jerCK7NESS4cywvpVwwcl7Wz4X/biwh3MF8nrsyidn8q55pwfC3WxtLz9RiDAAOEYQciMhiVwgb/xrxMulLHQW8y+iNS6eve1mh6yHu0eRfEVt8Wm2XlUf/di/RjSrwsvLjIneWoTzZjIwK8jD5TSBPaiamaOaixO58CG5yvFUqY8e4y1KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 3 May 2022 10:17:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH RFC] x86/lld: fix symbol map generation Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220502152020.19768-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220502152020.19768-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0014.eurprd07.prod.outlook.com (2603:10a6:20b:451::11) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f74ed3dc-0c0f-4813-67c1-08da2cdd67bc X-MS-TrafficTypeDiagnostic: PAXPR04MB8895:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1CcWLiRwDg15AFoxeVDDMIEg+y+dGJg+omcQgNmRHZdiADdG9pxmGDHO002uHTimHhni8jQEv2JDWia96uT8ZfLiQSN9FbKG09Wwx9P4k9cjJ6saGTc3EPSkjZJQ823GTj2k0Td4s6TNBrV52mz/+L6aV4pnB82Bi9Y+LoHfHpigYpm2ys/rDQBbhZIS9OkLkDX3KHMmNi01cqUMTdRwmNdreXV5obTYyDIti1yKOGIqmzL11zu++41JURPFtJFupGyZy5N0b2lJhSwQcdXoYRXOHyxkbxN2sCfAogUuMsT/mBF5YHQW2KT0m2cthpJPuUSSjvhrKDqnxIHa6FaymzLdMwE2hERXhZerOsVqGsUX2bfo4LPUF48mMg5s04P2jd0XkX8bQ355OsfvLVBHu7L0ed70lgkjRdtfWKQXTVssVStKucm8JhfceauLu2Pw/yywl1KIW68Si8GhCH4NFG6l4R+6znjCqYrYebU/dqYhlvP9Y22SWCehEC3WVBrTpR0f4n6tqIiHw4Y/h8X3SLx1aQzyLx23yMlz4Y+pByjKXxYiD1k5f88QcjX/Y4Ij0XRuF6rA14z9rfx1JTlgXHTEtyC7b2axLkzszr0wzk6uS3jv1m4I1MVIqhS+8SQAxaqjQLOErvv7JCMdRLUcoFN/ErOMmCxgoResrtzf3g+HK8yAcnjDb/lF7xOnz+ulB9KRhbAd9WFM7pi3TbJ9Vsu0cctOJ3Jpjb+WwoESAd4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(38100700002)(2906002)(8676002)(4326008)(83380400001)(66556008)(53546011)(316002)(31686004)(86362001)(26005)(66476007)(6916009)(6506007)(8936002)(5660300002)(2616005)(508600001)(66946007)(36756003)(6512007)(6486002)(31696002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4myR3l7J/yguHYsBMT9dvF9ynscYg7adecg9dPELn4qeU+sAxYZpQzrqk7ZD?= =?us-ascii?Q?R2Gd79AO9SuMjzNQLe9YpM3B3nEqI6ju1SnRcmU5r0mIEw1zI25lhTu4wDlA?= =?us-ascii?Q?IXVGiqtKDn3BaXGB2j0SH18kFnQlMmNQxqvAT6Nr3QgFnCxi/TXHT3G+kRmK?= =?us-ascii?Q?cKGai962bjINPSDakrt1o3atL5wIOS25BDcLMc27h+/fXopTCsqg/TQUwssg?= =?us-ascii?Q?bVQwmeQbweUKbkUFYBIjGWp9Sq97aDXMhKa0AqDyTQkwJQJbQRb2SsFbZ1Js?= =?us-ascii?Q?JYk7c7DBQH4Hgtoxt8xox1kaZfiqrZgYWwtS4e2Xc+KyHM14LBNd/p6ga9w1?= =?us-ascii?Q?OupNPmjDUh3OZXOy+DPKrOk6Nrue6hOvw0GFx8heCKSamd+DGaauC0WamT0T?= =?us-ascii?Q?SI56Leg3GrP9T4CQXKCJ2a1JoWhRw90e4G9Eitj4aKGqZcUqTEgwSbKOENVL?= =?us-ascii?Q?m+s1vnOVvz99p+bu6IzqFKAX0xXGy2i1pIbDyWYsUQySY94giSDtCWu6YQO2?= =?us-ascii?Q?ayyjuDz8lokbsVXKtlfvZy+WHFtQvG4rX2mWtfM/MRJPrlDY4zIip7ujwFfK?= =?us-ascii?Q?IpdmoE+nbx8XSSRMf0BIhV1jEqZykE9tjmthqwBeakYUdYRJyfG83i/kR9d1?= =?us-ascii?Q?YEfBdbPQlcoterOabIPaCBBaVlTWXkHLmxrz8QDtfxdcC8Yb3YtCpNtqyIvi?= =?us-ascii?Q?U8fN78sqG/EGRlW6jIH60HW0ovR2nVxdtuUwusgJqMKl8QkMFICghCvF6eCu?= =?us-ascii?Q?Lkv9VRY2PfWTEd5wOz4sh7/TZMQC3fguENthD3b172BUe9RpORnBF17AgrpB?= =?us-ascii?Q?oKDdbmbLkwTXKumTtrEq1oP/IyAkw9kS52NxbFv4Gbpj5hPF/WeJwd9UC2lr?= =?us-ascii?Q?WPNhNmpVZFc7j5ZdWQy+M61NVSIaAly3RuJTTSm2a0GWxzelXcGKl7AGAf7U?= =?us-ascii?Q?JoMADGu1XIBYLBD1wTcwCN43Qb3FmN4V2qgeO5JzWwKD8+epyxGFOjZf5U+d?= =?us-ascii?Q?MWRkIt7cR4cVjI6slADx+bhmLdiK/c4A1T6yeLQlqNSgTIhgpz9gzgT9RI0l?= =?us-ascii?Q?rHWsIcT3L73SX+slc+G61gnpSNUUvh09o6LL4e5naO3IwQsnYR5Kzi5mkm+u?= =?us-ascii?Q?2Kn3rhpdPxs2hGLBeWSf24lnYWDSOX7amFdcFZKvzUqCxkNKuldueaEcrN55?= =?us-ascii?Q?JDmUUG7iTXiQfLHCySEwbToygnTBiG4j2bk/KFMVhOgoiDRinqnbtVly0smg?= =?us-ascii?Q?cFOSTjlflwWhU1WL6GLR5Dyw3Y4ALKKC54t7yriJxd5V2wgM7xXyCza26TSm?= =?us-ascii?Q?6U9Pak6Z+Cis4/WPoRzXuQ1pcn1+CVoM7YvrVlqavl4bpljjxc6Q923GuLfq?= =?us-ascii?Q?ew3cU+gNOv/tVQ67jdrjKt+RIhIa3Wz7jZ/q3iIJjib3Qt5P/nIj/rBW0h6J?= =?us-ascii?Q?C2WPJv2YfOAA5JqirUQIT146ZHyk9MyZ5xgKA/UJccgwnjG5grnAGx2xKeJI?= =?us-ascii?Q?lwqPk+2Btg1a0EyUapEYjcRnHGp/9wfDzC3d/hVABPFJj5GOpY7pNHawqi+O?= =?us-ascii?Q?nZdTL3dyzKmZaHz0PZd1nNxf/rMCXieCm2soZr+Xxv/al2dwE23g3DEAQ5co?= =?us-ascii?Q?StYHYO4N79u0F20x3qGS4FEHy2KhRIxuDZhmJhI7MeR6JSr5OgeJT5jMYcw4?= =?us-ascii?Q?dJqxGvtJWid+ncyvCjUAsXELIbGWkIET1qC/mKtyssnC3IdC8qxdDgMPxoq+?= =?us-ascii?Q?zCpgBBsHKg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f74ed3dc-0c0f-4813-67c1-08da2cdd67bc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:17:46.7548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gNbEHBk8vF22i79V53dA8CMXXVb9cxdNmvdE9S09nGK/3fI2T5fTnuTBnKCSuoG0dLJv0rXjieNqsOUsVTXIiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8895 On 02.05.2022 17:20, Roger Pau Monne wrote: > The symbol map generation (and thus the debug info attached to Xen) is > partially broken when using LLVM LD. That's due to LLD converting > almost all symbols from global to local in the last linking step, and I'm puzzled by "almost" - is there a pattern of which ones aren't converted? Also "last linking step" is ambiguous, as we link three binaries and aiui the issue is present on every of these passes. May I suggest "... when linking actual executables" or (still somewhat ambiguous) "... when linking final binaries"? > thus confusing tools/symbols into adding a file prefix to all text > symbols, the results looks like: >=20 > Xen call trace: > [] R xxhash64.c#__start_xen+0x3938/0x39c0 > [] F __high_start+0x94/0xa0 >=20 > In order to workaround this create a list of global symbols prior to > the linking step, and use objcopy to convert the symbols in the final > binary back to global before processing with tools/symbols. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 > --- > I haven't found a way to prevent LLD from converting the symbols, so > I've come up with this rather crappy workaround. Perhaps a map file (like we use for shared libraries in tools/) would allow doing so? But of course this would want to be machine-generated, not manually maintained. Have you gained any insight into _why_ they are doing what they do? > Not applied to EFI, partially because I don't have an environment with > LLD capable of generating the EFI binary. >=20 > Obtaining the global symbol list could likely be a target on itself, > if it is to be shared between the ELF and the EFI binary generation. If, as the last paragraph of the description is worded, you did this just once (as a prereq), I could see this working. Otherwise (as you have it now, with it done 3 times) it would first require splitting the linking rules into many separate ones (which has been the plan anyway, but so far I didn't get to it). > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -134,24 +134,34 @@ $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkel= f32 > CFLAGS-$(XEN_BUILD_EFI) +=3D -DXEN_BUILD_EFI > =20 > $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds > + # Dump global text symbols before the linking step > + $(NM) -pa --format=3Dbsd $< | awk '{ if($$2 =3D=3D "T") print $$3}' \ > + > $(@D)/.$(@F).global-syms > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 > + $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0.tmp > + # LLVM LD has converted global symbols into local ones as part of the > + # linking step, convert those back to global before using tools/symbols= . > + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms \ > + $(@D)/.$(@F).0.tmp $(@D)/.$(@F).0 > $(NM) -pa --format=3Dsysv $(@D)/.$(@F).0 \ > | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ > >$(@D)/.$(@F).0.S > $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).0.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 > + $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1.tmp > + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms \ > + $(@D)/.$(@F).1.tmp $(@D)/.$(@F).1 > $(NM) -pa --format=3Dsysv $(@D)/.$(@F).1 \ > | $(objtree)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-du= p-y) \ > >$(@D)/.$(@F).1.S > $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > - $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ > + $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@.tmp > + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms $@.tmp $@ Is this very useful? It only affects ... > $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > >$(@D)/$(@F).map ... the actual map file; what's in the binary and in this map file doesn't depend on local vs global anymore (and you limit this to text symbols anyway; I wonder in how far livepatching might also be affected by the same issue with data symbols). In any event I would like to ask that the objcopy invocations be tied to lld being in use. No matter that it shouldn't, objcopy can alter binaries even if no actual change is being made (I've just recently observed this with xen.efi, see the thread rooted at "EFI: strip xen.efi when putting it on the EFI partition", and recall that at least for GNU binutils objcopy and strip are effectively [almost] the same binary). Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 08:25:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319241.539398 (Exim 4.92) (envelope-from ) id 1nlnqH-00075O-Kd; Tue, 03 May 2022 08:25:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319241.539398; Tue, 03 May 2022 08:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnqH-00075H-G3; Tue, 03 May 2022 08:25:09 +0000 Received: by outflank-mailman (input) for mailman id 319241; Tue, 03 May 2022 08:25:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnqG-00075B-NY for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:25:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a10eef6-caba-11ec-a406-831a346695d4; Tue, 03 May 2022 10:25:07 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2173.outbound.protection.outlook.com [104.47.51.173]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-YC1kl2LcNU2UKVBh7-PWNQ-1; Tue, 03 May 2022 10:25:05 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB6320.eurprd04.prod.outlook.com (2603:10a6:803:f7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 08:25:03 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 08:25:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a10eef6-caba-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651566307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjNpvNYw/0LWrtpQsxe9sWUFg/ze8L34PZyWO6x/dLc=; b=IbQd2bmGMOv3hHjSJCuzD+9YLq931gSqOEaWGy++/Y2r3G60mQeYT4eLdREPjQ6Ukx6cpB nq2ey9VvhbkyRYAr2yV4/cusVUFL1JWt+Jxij687/XVBqmwBpEz4EF3LoljYSKfC6Uv0kE 1h5XStKScITAyrXCHJbLctkJ8EzXgHQ= X-MC-Unique: YC1kl2LcNU2UKVBh7-PWNQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+eHwDKPCabDp0Z9kO5FCT8bRrT4Ms2r9AAJ8j0LEy09TX6VbybWX5LnI1DvgFomwq5/jgwxCuoRM/M9nNxXDM/foWCq6IsOg64klTN0jA0G4nU6RsHmqW3h53Fr0xuNHeNDBMXrPW0+yFk2UVSbTU5IeeusY8qeuqXBRDmC/9fKZiKrPRd25MH7E4jMS3wGOzUYFVnPOk4juARecieIl52Bt9Rctg4nmy424a88ACKi8yg9aM8xuJG2llcW6avWuH//e/65XrYtarZhjQdPvCJkylLxQPhl86NVGnFX+it/1ep1GgvCUSz7gEW66kkiyr4z/sfZ9DaNRD9rvaZPdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OIMh3gqjmylWwbM8PoDU2t+DLqFtULUANv6ziZTaJH0=; b=Vnx8vV2oSTfg8fj02cOd1xs6LmPX+6QuM7VTY07ird5BZAPKq7CNuGsAfVGN1E8/v9h87AFBGLHMOzSo1S9ZGTGnUNm1aqdHjkWIaxsb58DtkkAEpl4XywfLAL4FPQfnrkrOse7/lrol5F0fiAVtTw3UYKkV9aTLggHVR7gNOxwakZZN6QxjwIA8y4s7DAn4k72EcK/Dwmi16Enclc0caaTxwfvivb4BDw934xIkR1D23MetZ/HXwqsToTVcOIPlymYrqT4eEIRXoLLUJ5mOkXZUoxrdie9IEK+sWA5wkZtgQsl8eSfZtgFtPPtTMRXCs3phaI5UsYY+6obHC2I8TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 3 May 2022 10:25:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: osstest: blessed sabro boxes Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: CC: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0017.eurprd08.prod.outlook.com (2603:10a6:20b:b2::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e2becf8-4cc2-48c1-8ebb-08da2cde6c2a X-MS-TrafficTypeDiagnostic: VI1PR04MB6320:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7zKeZIB5ySkWAqCITx7LLm/TECHxcWi+PEOqn9D8VTITRE755ZFt5/XMUmYJYCStNhXYo/3Cbiuk6e+xY8/WKJ/f4q5nLhCsYyR2mKg8ETQDDD6nwjtlV4sPwhNbbXlavki4w93t/LK2PRj+GnTbCFkMC2slOXdIbYt5ykS0y1Ug8ubQJ+tATUUQukLV068jeF2Ob+U2Y89XI4fSEZsZFbiu67jmjCPdQm1DwOxxImJCPxWtGv0feRUe/onYMxy1T0jMDBER3CtS0I2ReH+VVqqDhZk5n/CRe9zyBgCWsweGPRureHJc0LWFtqC1VY6qvYaHcqfbRDdSuuYiePMF/3Q1mllVU+cUZQJRYjV4PmhfR9HN4EJQfUJk8qblNRpzBpeY/GO6TuJM6OBb9hx1W1MplG1wreSUzNWdXDhzPej5GHO2UXzGlYEgaEa88NpEzCCkTNAbrPjLJR49zZnV5lC37drXk40qFXy4dZP0KXk5oz50/fAhtrRTBO2UFq3saZ3+gkJZruQcchH3Gr3pWYG1jjFnDt3fZs/2z8UFWk/It6gunmGqM+whw1y/b2th/p3EhtGTcsu2DVx1IeL10Q4BIWbQ9keDz4gNAhZ4UT5CLEkVetZMbN0l+FTKXqL6WQhoz6AVshxwh5NNSpMgKiYQgszW58QM6XUMFnj1HtNkd6aOMhUREsJRlf2wrfjgchAAoOH0h90pIG8gWCvgZATcWVRCoEszTWfVLLAdfpNAnmnsh/escqFyRzvb/RGT/AJReSGnbPA/c8YDtYNunoZz0bELHcBAXe5lo41xrgEYWQq/+K+2zkA0VDy6fiaDysgho1Uwewz+h5heHX7rpOJVl3fdyvVS0GF4Yp9heBk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(66946007)(8936002)(66476007)(8676002)(4326008)(4744005)(508600001)(966005)(6486002)(36756003)(5660300002)(83380400001)(31686004)(31696002)(2906002)(316002)(86362001)(6916009)(186003)(6512007)(53546011)(26005)(38100700002)(2616005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fP8myDYosnzf8O3Z0y/rlCUh+yVXn7EPrtAg55vfdoz1Oiu91HlI9X/FAs14?= =?us-ascii?Q?4aGrlGz2wx2LuI1NeUZYFrU1ObYTIMA/8RP0CBOR9HGY3Qg8GAJ1de1f8F4L?= =?us-ascii?Q?2LwueyoZCty2Za24HxOR5tNd6iJ6lq3kGxLxGUxepnO6LYjKN+7c856Ox4SW?= =?us-ascii?Q?MqiLEI2ZEoR/1zfGckZiV2Xgwfm55tYHphDyi1/nB3k8pwXd8orLivlrNGJH?= =?us-ascii?Q?X+4xfvCtdEppkOXq5EYeGofbJ9LV0qx06rzUHOjV2grNmUFBzpI9bz6EDCVo?= =?us-ascii?Q?NIIUwZJkdt4Ei8Hv36ztVL6O3n4QxZ9VJ1IlFs9/IzbCN4xXtZlHRV7u/Vdi?= =?us-ascii?Q?smXYih7Y6/sedAZ2DIUpEqgEfUWa+d1h4u08ITOFq1HOSy8tjthy7dJwyLyP?= =?us-ascii?Q?bFplHhVs1SlfHoms+dnBJXu2fhPpzKhqPhkmICJtkrvAkVaBsHVxglZHqyPD?= =?us-ascii?Q?nNzWboj/pmEJt85Fy8J3iOP8AbToqgZXfl0QV48owDekFzAgvUfRzAgI+Uh6?= =?us-ascii?Q?5ov44wTR6Jigs/7ozQpekgIiIlWtDhq59xbCtkhWnyzcG2eI69TPgwq7G4GM?= =?us-ascii?Q?7gxsW70elrSByoDhv9slzKvJlIhy4X7BnuqsY/7JO5wbqlmFEzxyZcFnOLF/?= =?us-ascii?Q?6YKDhIOzoEkPJG5Vo5JVzj2gzPF5tkBMFM3dDmbcD+RnCAUGxA51I+XiIY4C?= =?us-ascii?Q?olUNQazQbLyNdLK5ScaZQ+GAHe/M9E5eNHEhPAWiMwjaR38yWw1It6XaZdfp?= =?us-ascii?Q?ova4mTwEI06Z4YBP4gC9tr138n+cm0mOkNM6OovUYXqKO0yTl0lRaLTN5NFP?= =?us-ascii?Q?gCc0f16oN4yR9WA/s2icfF0C5C4hPH3f8Xr0NeWgmBANrc/IuVIz8lOtgWz+?= =?us-ascii?Q?RGxcvspMUd7yBTdUJw+zdoWmbPr9d1M8B5Z5t773BG1540vpivxrQ/gUw835?= =?us-ascii?Q?7TaMDLnZqc+yY1oaIybPTzaOX4KwoJxa48BUlpn1dlisr4mgl7trqbLdt7n7?= =?us-ascii?Q?bcduiv9X1nw9x/XXoklF7o0Tx6sthTX/55lIDj7TLf153X3jS10ud7Mo4cn/?= =?us-ascii?Q?W5Is1G3mlUXosD5S0zUndd03kzOx07A9yphor+jRJE7mVuvC1liuTqffoRRO?= =?us-ascii?Q?GSgI9je1BLRLmTirtz8+Cg02M+6gDDXxp+HwB/oxHndWzNBreZKTIc/m9u4b?= =?us-ascii?Q?p+NJcng6B00OtpUkzZqvTlsbC0Z+/0s4GuwcTEwPheZOuFUtNP3ig0iVRoFX?= =?us-ascii?Q?DZv6cVGoET5fZxy/3LQ2TSae5GPf/qhTeKy+V0bknK/6tQvWC7GOt2IBtvEJ?= =?us-ascii?Q?0h/wV0y288g9bra7WyX1mmWAMKuiEI/c74NLM4aL4vXOg1AXw9UaDrDnCPFW?= =?us-ascii?Q?cFlaw/2SAoFGiVuFY1l6/750g+Q7sImoy2Xmuyt6+6SzqPCrSVnM8gou3hUM?= =?us-ascii?Q?ki543AcjeYXDphKPnpmane9ew2MY82gWGwwgqW2w47G9Y/+/mZNkFDQIvk3y?= =?us-ascii?Q?vRpiVdO6E/1oox6NKLDr7Ieaoh6Z/L6ffffkoKb/wknMwWHKPX5yMdj+f33h?= =?us-ascii?Q?czFTlyz1ciCHi55KjKtxCW40xUyLWCwpe7ALuk9t8QfFjn1uQ+owA0m464x3?= =?us-ascii?Q?MB3isxLNTU/Fm9bB5cdYuyeyye3u+TAJd/B7NoZa1MpoY1tqHRUW5GjHzk1K?= =?us-ascii?Q?XT4v5YPmdYiWr88ShubNwn86nRDm/JRwxe9u78/Hi9elxB3TTu+15RRbyxIW?= =?us-ascii?Q?Fb0W6bybKg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e2becf8-4cc2-48c1-8ebb-08da2cde6c2a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:25:03.7311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GYpWvwyp28wApdWYbDaZHwtxhrRfH86Pb7sG6BzGRZzGIFRhYPitTQ3i/EkeeFaI3qNP52pcJ0NA43kZh+RWag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6320 On 03.05.2022 09:50, Roger Pau Monn=C3=A9 wrote: > Hello, >=20 > I've blessed the pair of sabro boxes for production after a successful > commission flight: >=20 > http://logs.test-lab.xenproject.org/osstest/logs/169857/ >=20 > Note that the boxes don't seem to be able to boot in 32bit mode, see > the following flight where all 32bit jobs failed to install the host: >=20 > http://logs.test-lab.xenproject.org/osstest/logs/169986/ >=20 > I have no idea what's causing this, and hence sabros will only be used > in 64bit mode. You may have better luck with a PAE kernel (which would then also be able to use all of the memory rather than just about 1.7 Gb): Notice: NX (Execute Disable) protection cannot be enabled: non-PAE kernel! Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 08:31:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:31:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319248.539409 (Exim 4.92) (envelope-from ) id 1nlnw0-00008H-E2; Tue, 03 May 2022 08:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319248.539409; Tue, 03 May 2022 08:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnw0-00008A-AG; Tue, 03 May 2022 08:31:04 +0000 Received: by outflank-mailman (input) for mailman id 319248; Tue, 03 May 2022 08:31:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnvy-00007w-J0; Tue, 03 May 2022 08:31:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnvy-0006oM-FU; Tue, 03 May 2022 08:31:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlnvy-0001uL-4Y; Tue, 03 May 2022 08:31:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlnvy-0008MQ-48; Tue, 03 May 2022 08:31:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5Kw3lOUT5B2iahzDXauaScJSPN/gos5GLv+8oZ5jXn0=; b=ns03vbRnfHn4neHuXiae9bHwH3 Jefkfij3SGNK/Ijk2RVjsMAHqDfudMR1UO/TjdCs7D+mT0VpIYXgpEW4XSKmTxNncLw/SOVbe+3wu CX9paHdeyCFXWIbt8GeDw8kkTe0u89SUzGhKlFq8hQ3uyBkC5sSJX9iFQsKGUHCAKoHA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170029: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 08:31:02 +0000 flight 170029 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170029/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 775 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 08:35:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319256.539420 (Exim 4.92) (envelope-from ) id 1nlo01-0000uT-VP; Tue, 03 May 2022 08:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319256.539420; Tue, 03 May 2022 08:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo01-0000uI-SE; Tue, 03 May 2022 08:35:13 +0000 Received: by outflank-mailman (input) for mailman id 319256; Tue, 03 May 2022 08:35:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo00-0000uC-DO for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:35:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f136ac82-cabb-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:35:11 +0200 (CEST) Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 04:35:08 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4179.namprd03.prod.outlook.com (2603:10b6:208:65::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 08:35:03 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 08:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f136ac82-cabb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651566911; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=25UJov5Cqw3/wwri3/lPpxqfRNDYAC/4d/Lv0XxgBfg=; b=ZRZhmMa0O0aRlpP0OLIpebY1Ns8SmkT6a9UY3VF6Udfk7ybbXgTI6UI8 cyhr+PoIsgWw8ZyNzuBlcP+rQjbE688TXenSckvgmaglgp/NaDeEzQSk0 651eVirGWrgj7ohMSyBrLUj8WNdXrmvwm0gLK34KMrBQ4nWl77XKEPiVg 4=; X-IronPort-RemoteIP: 104.47.51.44 X-IronPort-MID: 70447533 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LIxvYaLHB9g7xrJIFE+R8pQlxSXFcZb7ZxGr2PjKsXjdYENSgT0Om GceWDqBPvqPY2H2cop/Ptu2p04Eu5PVm95kGVBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Yz2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Nxu67Dsdz0HB6fdpeUUTBlFTB9uE6ITrdcrIVDn2SCS52vvViO2ht9IVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMmFH/miCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iWjLGAD8zp5o4INyTaKlT16yIL0H4vRRIemZZ0El2yH8 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M FEP92wlqq1a3FOvZsnwWVu/unHslj4RXcBBVdIz7g6lw7DRpQ2eAwAsRTlEbcEgtdMnAzkj0 FaGksnBFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBRw1c5dDm+N43lkiXEoolF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:uOfNkqMf4fmPkMBcTyf155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBDpTnmAtj5fZq8z+8N3WB1B9uftWbdyQ+Vxe1ZjbcKoAeQZhEWiNQtsp uIGpIWYLOQMbETt7eB3ODSKadE/DDoytHKuQ+IpE0dNj2CJpsQmDtRO0K+KAlbVQNGDZ02GN 614ddGnSOpfTAyYt6gDncIcuDfr5mT/aiWKCIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7WQywPa1UXU85NK8eGRvOdrNYipsIw4Oz/sggGnaMBIXKCDhik8pKWV5FMjgL D30mUdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxyL5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjxUC3abFuJ4O5kLZvsn+8SPw7bWPHAcEcYa JT5fjnlbprmQjwVQGYgoFtqObcLUjbUC32AXTqgfblrAS+rEoJs3fw+/Zv4EvojKhNLaWsx9 60R5iAx4s+OvP/U8pGdZY8aPryLFDxajTxF0/XCWjbNcg8SgLwQtjMkf0I2N0= X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70447533" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5AT45Y4Xrp+uFyV9z3ycycOsZPUZIdXmZCv7KJ+yEeY8sr+XVpWQPKMoJZg48o7/qxfsjxzOG3VHf5vj0rLuTaeg+dTrjTmYm3274pFqi/1oBNTGSNBTQoL3ONEAM/vRIi/aIibe84EJldUnVls+xpdn8NANAzgkpDOzgbKATG7GfCyJm6osEbHB6NvK1f/IXNtlhb4pCXy1FP6GtaxPQNCEOUK0Qk0oBqMv/s1ehWCm+C3f5A6wVIuCAGo35kozAy8GIvF6jbIBQU63nNvaLl0SA2nGdRJd+dLFKbn31Ur6dIwMMGv+M6slER75lDAHGncwSRMQy4EMGsJHSrfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O3qHloybC+YWjO8T943bJ2MyrTbnzE0pNcV0UG+PM68=; b=T4MJV43XM34Uw96xDRGF6akeABjd40ye5UptfBClA9ui0GfwvKmzRZ0Nbx0sOJR3e2j8W4CYGFNScigkwNyRqUbCuE2s6rIi1Kl6O4Y9RR8jeElm1kTwZ/cIZlrcsJsFx0y51u0S/fjfZbZJVuVRmkZmCuUC+hgOiY6FWZEsHjZMgSXgTAj2us80frYRLrQB1vJeBumjgPsvpOnzROqLtKFmf0f8Y1ciFs67KR5lVcZHLaUdC9L8XjyEHvQi3GI8CcSc6fbLHiJq8G/8ksbeJaPERFXm75/8zjf1nCoVEsZtbcvNXob0FshsJI/0tAIasUhCfxseDJ/p9p6WuvWFcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3qHloybC+YWjO8T943bJ2MyrTbnzE0pNcV0UG+PM68=; b=KOdyw2gcc0T265p+NTxp0MDyTESUcJ7d76Dq8m5GEQrUZqDc0psIM7DFvVItRI56NzzpnqGMCE+PJnh7wxA0TihNGhy+MkfLv0Bo/LYbLCf8fRUbUAQhvlbEO7Wz51DIxcJIIOv36eqy64/xxNL9Y0gTt+BXRdgkvgbri/pA2Uk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Henry Wang , Community Manager Subject: [PATCH v5 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Date: Tue, 3 May 2022 10:26:47 +0200 Message-Id: <20220503082650.23049-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR05CA0005.namprd05.prod.outlook.com (2603:10b6:208:c0::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 119daf42-147a-40e5-d15c-08da2cdfd183 X-MS-TrafficTypeDiagnostic: BL0PR03MB4179:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8JT7fuc4lO3+E52Xi68WbGyzXEJAJJAJxBTHHYdvx+D9xQATX7B4lJLHEqHSKHSwyMV36z7TsBZWd6nbpJ8DxZbyrJsEA9NNyk+V4lupJ/xCOHuOJDHrnRf3GrV/KF/6mtmLJDds73PztTTSAF8B96LhhJrte8ukiF5VgnMFf4TKvbXg93NlZCHsnUuXNdq8Qp3sCDQoS8WyZen1Cx0I5rDemqsno1QZDl3gRg/leKf0GE+mASIq+8ujsqNUSWJnltdpW4Pu5aZYEQtWXEVgmUbJpnXZqtHy++U6nGAD03HxYNey23m/CW2jJM25DzbnSszLKM9z4SQJGR4Xbr6ajPQY97f0KNKExYDoky55o88AX2DdUUWXiTFkMcwAXFSsYmPdK0m+qY1w1FZjCLAHZ/RSDnt9aPPK6wqLaLbeNdxlmkw+NsqZRiaf/F79io93fEzH8Am9MVtkb6/QVi/uCeThpprk/Sj8YFG1x3XI0UoOoKpXPnV0aUUrgX9+Y6Qpc8s8Uc5VRkHKMZX2hh/rHD2Cv0MRIa5ML3+/yNgZgw7Cu87Bwd5cb7QRnLVNeJUTeT1GMT9ZbiHLyBEIZx6dw2hb/sdQVp07AeUaONWt5n2nTSxqc1jm7fX/x5anrBSS2gCpNTdt60iv8Lvo50r17w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6512007)(26005)(6506007)(2616005)(6916009)(54906003)(5660300002)(8936002)(83380400001)(186003)(2906002)(1076003)(66556008)(66476007)(86362001)(4326008)(36756003)(66946007)(8676002)(38100700002)(6486002)(508600001)(82960400001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0M0L0FFQkVwWmlkSnB3SDFrSCtuY1FqTTZtWVBxU0sra1FqVkNXK0pjUi84?= =?utf-8?B?WjVMR1c1ZUNBcFlIVy9PdmFzOWJ5S1NDTU5QTnhKRUVuOHArclhpVThxanJ6?= =?utf-8?B?QytMVDJqd2k1SEgzYUsxUGlQV0FMTTRxT1owbDBUMzJyOG0yYWF6SGVBWE5y?= =?utf-8?B?VTF1VGdWUHJRVUp2T3dKTjUvNzFKRHVVb2s0TG80OGt4cXc0Rk1HNkhLWjIw?= =?utf-8?B?cUtyanQ2WmdBeDNWazRvUjJvUklLK0ZXSmVMaGpyUkIyS21tZ1RlcVFZYmIw?= =?utf-8?B?MUtTdEVHNlFQQzRKdGJIS2ZZcnlvY25OZ1pocmVVWVVjMTloL2MrMEdNWnQ4?= =?utf-8?B?d05CUTJrdkJWNW4zdE4wWFZkYVpFWjBpRXBxWEJjVGU0K2cvTkxJb2xHVnB2?= =?utf-8?B?NW9TaW5rbnJ4WWVlYnJkQVRVcTYrcTg3b3VRMURoR0RQQUNUemNMZG80ZEw1?= =?utf-8?B?OXl1VnVraDlUUlFMMWg0dUlLSUxhTmlTNEZrdm82eGJONmhHZE9Ocmk4ejVV?= =?utf-8?B?UkNkbnRwVXM2UEltMDZnVlVZVXNsVHpXWmtUM1BBSSt2T05oNzlYYTREc0lB?= =?utf-8?B?Q1FkaXoraEpWVVQ0TUNlaWxwdmZEaVN0QlNXSEIva3FTZ2F4aW1UYkNWU085?= =?utf-8?B?U0JrbFV4Z1lWYWN5WktSdjkxMjZsRXBRRTNSVnVRaWExMEQrY2J6bFNmL3Q3?= =?utf-8?B?V0Z0dmlvWlMyV3pyWXAwS0p3MWVzTUxFeWFBQ0NZSFhxMjQ2SU9RdlNObVl2?= =?utf-8?B?OTNzSUdxSGtEMmR5dTIwTTZCN0QvV05sZ05IWjVsSWYrdWNma2UvYTFlRERK?= =?utf-8?B?YUNLNU9DOXc0VnJEZkkrbFFWakRrd0xDMHF2amtWckVyLzhNa3hBZzVqcHc5?= =?utf-8?B?VW5LVVlHZ2NidWcrbU12N2Z4T1preXp5WWZSNS9wdGk0OTlwYTRxRVBPMis4?= =?utf-8?B?YTVyNDdLM0swMUw2QXpETW1FK3lUWkVTSzgzbHFaRk0wNUN5RWVRSmhDQmJS?= =?utf-8?B?U1JEeC9kT0loK2c4SUI2cGg4NDNBY2pEcE5CZnhkUy9lZDZOTzNPYWdEdDZk?= =?utf-8?B?VkFuUzJoVmYrSUZZOU5Vb2t0cEFSYWJEbFRXTTFkckt1ZVppa2gvVE9WYTBl?= =?utf-8?B?alZ4KzZ1a2RCWFJNTlFyeGpZTENTaEYyNzk5SHNhVjJpREs4aTBZMW45QVBq?= =?utf-8?B?bEVxbDZ3cy9zZlF3SEhhR3hVc2FJcXdSeXNYb0NuWmx5bUw4SytYY0lwYVd0?= =?utf-8?B?Mjc0WjBKbFByaWpkZVk4QVRBR2g4WldwMXVScFU1U08wK2lZZGxuRnNZRTNs?= =?utf-8?B?MGd1OStJOXdXUkRKLzY0TFk2SUtIeVdaMUJ0cFNtelVINkVkY1lraHRlZlRx?= =?utf-8?B?UTU3SkMzNzQwQW9KVGJYSWJ0eHhMajFGRmIxekQzUWNiMkxEZGlIT2FTZ0Vw?= =?utf-8?B?YjBKelJvU1dmSVBvL2dLZWV1NHo3OE9UYkxqdXU1SE5ORnU5ZHRUWXhzVUdt?= =?utf-8?B?bnNxdGpiYkhIWmEzNWNaZ2d3bndRMjU4MWxodnBZYnZRTkdpNUhCM1ZDbW9N?= =?utf-8?B?alhrSVRMMjZCZ2NwUFc0STVDc3UzWUJMMEVZa3pSejZMMXZiNW1ZT3pLL05R?= =?utf-8?B?QVhiVDNQQkkrMGN1dExHb3h0R1NGMXR0ZnNUeENnWEt6eGJ6RWxaSVZtQ0Ft?= =?utf-8?B?RmwxTzR4b0g5bzhZRjFtNkNvSmMxQzJqUm1UTDNsNmZDdnMyZmpDYndsYm9T?= =?utf-8?B?WWpkMlFDQThIcDNDcDNJdFB0ejYxS0Q3bjZ0ak9iUWJmTVhlbm9vMXZsWXVx?= =?utf-8?B?WE9ucTh4ek1IS3dCMTZIS2ZXMFhFZmxZcHlFWTNBUEdvblNncHBxSVAzam55?= =?utf-8?B?MDBZWTg5V21rcEdLbk83NEtkYTljS01ueUtzTDB4SVViS09rYXgwaFZRaWg5?= =?utf-8?B?VHYyd3lBNzM3NzRiSGlBV3lzWm1kck9JdDZiTXJkZGVUMjduclRkR2l2VFBX?= =?utf-8?B?N0Y2QnJOY0V5aWk2bjEybmhVTXpjekx0OS9yNDlwTUNkOTFtMDk5VFdYLzR3?= =?utf-8?B?S3lYNG5hRWNhMktac0hoL0xjWDhRaGFWMmdIQXlLeHppZVRPd3YwVldaVVZi?= =?utf-8?B?UUZzRko2MnhjbzcxazVjRTh4ZmFKSjgwU2ZqNENQME4zdkJjMDhxMk93RWRy?= =?utf-8?B?bVVqTkJVRXFvdW5CRUx6Q0RyMm9ocTBWaTQrQ3ZDVEM2UVU5QUZlL1FWTTd6?= =?utf-8?B?MEwvaUZ1Rm44T05ENTZ0UFpHajNmTWVVZWFIYlFVOHVXcnR1WDRwVnBaNjFr?= =?utf-8?B?NnljMmtLTGRkeUVncUptRGUzRnFDMFNnNlFDclRIUzV4RklXWVlkRzhlWEtl?= =?utf-8?Q?AYxCuhBg87n6KeS4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 119daf42-147a-40e5-d15c-08da2cdfd183 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:35:03.2158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BeeOVodjOU8ZVGh806Lk5VEPj8LrtDGHTHD64rXr9FxjuENXmGu0RTSfru6908ji1szf54hvbkuA58ePxfbVKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4179 Hello, The following series implements support for MSR_VIRT_SPEC_CTRL (VIRT_SSBD) on different AMD CPU families. Note that the support is added backwards, starting with the newer CPUs that support MSR_SPEC_CTRL and moving to the older ones either using MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG. Xen is still free to use it's own SSBD setting, as the selection is context switched on vm{entry,exit}. On Zen2 and later, SPEC_CTRL.SSBD should exist and should be used in preference to VIRT_SPEC_CTRL.SSBD. However, for migration compatibility, Xen offers VIRT_SSBD to guests (in the max cpuid policy, not default) implemented in terms of SPEC_CTRL.SSBD. On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to abstract away the model and/or hypervisor specific differences in MSR_LS_CFG/MSR_VIRT_SPEC_CTRL. So the implementation of VIRT_SSBD exposed to HVM guests will use one of the following underlying mechanisms, in the preference order listed below: * SPEC_CTRL.SSBD: patch 1 * VIRT_SPEC_CTRL.SSBD: patch 2. * Non-architectural way using LS_CFG: patch 3. NB: patch 3 introduces some logic in GIF=0 context, such logic has been kept to a minimum due to the special context it's running on. Roger Pau Monne (3): amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD CHANGELOG.md | 3 + xen/arch/x86/cpu/amd.c | 121 +++++++++++++++++--- xen/arch/x86/cpuid.c | 17 +++ xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/hvm/svm/entry.S | 8 ++ xen/arch/x86/hvm/svm/svm.c | 39 +++++++ xen/arch/x86/include/asm/amd.h | 4 + xen/arch/x86/include/asm/cpufeatures.h | 1 + xen/arch/x86/include/asm/msr.h | 14 +++ xen/arch/x86/msr.c | 26 +++++ xen/arch/x86/spec_ctrl.c | 12 +- xen/include/public/arch-x86/cpufeatureset.h | 2 +- 12 files changed, 229 insertions(+), 19 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 08:35:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319257.539431 (Exim 4.92) (envelope-from ) id 1nlo03-00019u-7x; Tue, 03 May 2022 08:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319257.539431; Tue, 03 May 2022 08:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo03-00019n-4Z; Tue, 03 May 2022 08:35:15 +0000 Received: by outflank-mailman (input) for mailman id 319257; Tue, 03 May 2022 08:35:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo01-0000uC-LQ for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:35:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2a0101e-cabb-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:35:12 +0200 (CEST) Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 04:35:09 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4179.namprd03.prod.outlook.com (2603:10b6:208:65::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 08:35:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 08:35:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2a0101e-cabb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651566912; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=N4cvQrD7q6iSxR2xJlRcM5GybB6EIiLfDx9loSHgwro=; b=etTOs2eJK3Uamrv5XRJNqVs/QPjwMXE2jtkjjul9f8EETFl5L6DuNYxb UertGUvJNzKuwpELwhxMRrT57fkbkiuD/fqqqGwpD3pFicQkJW286gxcp ESnOsLfG47Hbm7Ou5FRBiKY0QNi8ViIqmRWTze0J/SrDSAZ/yQuPKcDQP 8=; X-IronPort-RemoteIP: 104.47.51.44 X-IronPort-MID: 70447534 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2r5jeK+nIr2RH1b8jvikDrUD9X+TJUtcMsCJ2f8bNWPcYEJGY0x3x zcYDz2OM/3eYWr8Ko0lPN/joBlU7JKHy4NnSlY/qH88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IDiW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnY7hdSx3MrbAobgMcjJVMzoiL7FaqJaSdBBTseTLp6HHW13F5q00SWsQZMgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvyMuYMwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2EE9w/O+cLb5UDYxjNI9af/EeHNQdyOQsl2xnSTq X3ZqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZsb5dw21pjiDpBF0ZjZLO+gz6QXIwKyN5Q+cXjcAVmQZNIBgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:Dzl4960o4TV9GPgn+1OThgqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8O3WBxB8bYYOCCggeVxe5ZnO/fKlHbexEWs9QtrJ uIEJIOd+EYc2IK6voSiTPQe7hA/DDEytHRuQ639QYQcegAUdAE0+4WMHf5LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+FZgNYtvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70447534" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzEPuG4kUhZRSVtA+I56MHTQNCqKp4AyYNG+GvTtQCuHOt32Bdx70MrRt7+RErXLDPxVnAJ8zN5KyRJmkm6hLtzRLULI682zWNjTOnvsYr4wNaDDvMF+JKpN1JNhjJoDCEVGLlkWl6MSaUh6WV8HY7Qje7mYCDH3nNX0gIVAbG+O4DxEFDcq3lJG7lH+hFE64GWawjlDIbIFa6hqVyYo5Un7998wswWeePqE+jnLxg17wsbwhn3yUdohVMVtqqJ4/kYvS/P+FcrWNu4euxjVWAlTDHRSVRhKN/vpM8ZW0G+qhWpvGRBNly5yTIGMj3BtTr8A1WgtkXPWxHduMB3ouQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rEj4Lts9xVDYbyObPHwpFNoKH7oU7x6POmGWZCD4/9I=; b=HhaBfFmqkx1Rja6ypUEEBKVIm73A/e85jFI17gfwTyrkcuEFY8B5sk9QNSkksDuFQBYainjnh7rjX3GSJ68QCI9YY6RLJOS4LXvYR0CL08HKY8rlYYIuBTmjKlyDxBcC/WArMqgVs5IHemmh30vazQwAKCHj05CPq18omRx8P4VdvDM/NR3BtJyBLgAI4cxpRHY5ugvuGamT8iACiubTAhpCoQ9WdoTE/pu//+cUI99bch/cB1PmHMx6byYFNMZmAW1cTRQEwiGdWXm/a+Icijdb8hLwc6j1Zu9/pGImNMtKViFMULvGUmixVX9fyBl4U1r3F18+h/HsSgIFwvrphA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEj4Lts9xVDYbyObPHwpFNoKH7oU7x6POmGWZCD4/9I=; b=jQ5k5x51t2L2+aSMpp+PufvKYO0XAhBgKK/IzNK5mt/IxejNG7ZaKzhF9tlPuIxXRj0WOxdVdX57u1vRZ+Io1IW1+fiatwbqCj3pULGy8MyPiZvTQvi+S0YWT1f//keQBMzEtTM75UlgA8aRVj+hW0eU5QQJC0O6zd+87l7nSgY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v5 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL Date: Tue, 3 May 2022 10:26:48 +0200 Message-Id: <20220503082650.23049-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220503082650.23049-1-roger.pau@citrix.com> References: <20220503082650.23049-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0170.namprd13.prod.outlook.com (2603:10b6:208:2bd::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b304461-d30f-4d74-a33a-08da2cdfd2fc X-MS-TrafficTypeDiagnostic: BL0PR03MB4179:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQAwerdlbzYwxsxD4qVImgqZiPUVascdBDMmKe+GbGdiFI+KKlMjbHTzC/FNIWJIAtUDVa1BEbv8X7ARxY3AdnLHXU0OD4KgHV70St6vFAJOqaO8CldN0lcT9aI7f8pnMFZlF475nMXZlDgt2Ti15vJvLq3CNqAPW71G2BTBC/QpJW3VsVO48KqVq9N6WJ8+j6YJlSGP0saA3/ZEXktX9Zf5gPogWzTmAGLN5Xlfj+iSGQHInFrWXQItB/ygV49ny+OYqAibLHNibbuH8F9Cgnw1zAk45FHEg7K5sMf1g6d0D9qi9TOHE2LN+TFxSUjmYxuMePwhkyLCmZ/P6NuGWDzNmngUixSJ0qjxL9Tc8H9HgfLRre95+UQrW2kCWeBrcmvkuLKDdIJY79FWxx5OUPj3GdMmPfPXeWFO6dMgOeANyJ+ehYHDFJ9vU7u8URsHmM9oc2dRzIj2cGZAuDVbgX57OyW2+BoKaIZ2v8G1xQt0CASyLBxff2Wx1P2pZy1ezlA/mmVtPSzPKTtmz0dNKYVtczBnQf7meyf3WFl1/CznRR/RXFyP2q1UWPA2VsK7gu87Wkw6OYyCDMhFryJLBHtW0Y7yOLeNS13AIXUggv43cfGDVFGHpX4kFMC+FsgQkLTVzzXpFOUkaqcrt1dz8g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6512007)(26005)(6506007)(2616005)(6916009)(54906003)(5660300002)(8936002)(83380400001)(186003)(2906002)(1076003)(66556008)(66476007)(86362001)(4326008)(36756003)(66946007)(8676002)(38100700002)(6486002)(508600001)(82960400001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eU9pOWdYdWxtNE53Y1hMRll0d0hIV2REVWkxaHdZRnR1SkFjSUJhUnZTeHg5?= =?utf-8?B?aWQwZy91eVRBWmNaU3ZZK1hkSVBNSlhXQk9WdDRCMGc1c2tBaG5yMnRyaXBG?= =?utf-8?B?NGVWWWs2TlBDL1NjNE1kdUZ4ZUpHZEloeHQ4ZUxjZ201UE9EdEZ5MnFxRlFx?= =?utf-8?B?TVJMMzFOMVU3Zm9oT2Z3NVg3N0N4dEhrS0s5UW1oTGZTbk83dmRyRlJTSVpo?= =?utf-8?B?dFpJK01kMUFJZFlLMmFjQmlRQkVuakNPSWZtNGdOMkJJcnJXOUorbTMrdGRJ?= =?utf-8?B?OCtGZUFCbVNDZUxCK2RIK1VJMGw5V3dscFVTdFhQQjVya1lEOEpWeXpyYTgr?= =?utf-8?B?OVVFcGoySlZKMFEwWERhUTZzVHNJOVA0a3FQaUovVVBPaFlEZlFhOU1HcGcv?= =?utf-8?B?d2JwaGxnQWJNRE1HQlo2UXAvS1VabWFQL1BJZWlibXc4YXNGTHVPYi9MeEJS?= =?utf-8?B?UjczUGxXTHFvTlY4UXI0eWF4YVlWZE5Kakkwd0dpSlF1Z1hYa2JkU0liSWx1?= =?utf-8?B?K3VEK2dTZmFuZFB6dGxpODEwN1VJZG90NFV4cDFqcFNSMlFNOFdjWENnSDV6?= =?utf-8?B?ZkJMMjBhTnRjOWVtaWNzYU1VNi9RUmQ0VUoxdVJJbWZhYTJuc0RZbHY4S2VC?= =?utf-8?B?MWVpbGJ0L0lYMnpBd3lQWXVFLy9keklHdGJRZm5PU0l5d1NDMEdZUjYyNEVp?= =?utf-8?B?SWZWN0RaaWpVU29pYmlMMlpxdlRnT2ZoVDkxcnJHRUgrSkR3clQ1VzdPNU5t?= =?utf-8?B?QWd5N2hsK0ZiOFhiWXZSaDhqSUdROFNrZG9aeXliTGRCN3piMGx2MFErbzVn?= =?utf-8?B?M0U1QjNaOStqdzRhN202YTllWkgrUDFtbEdNY0ZKS2FnQzN6N2NFT2cyU1Mz?= =?utf-8?B?WGZpMHRYZlBiZlpRSkNUc3dKRHd5cjA2a0tUYkdVZ0dsdTBmNlhIak9CMTBa?= =?utf-8?B?T212STFVYmhTYXBSNE1pNGIycnFsc3R1emV6ajdQcDg4V1pZbklyVXllRjdN?= =?utf-8?B?MnVJZkpEVmEyM1FZRS9ibDJyZGMwaXlkbUUvVG5ZckZJcVpJRDdZMUF6NWMy?= =?utf-8?B?SmFrTTNsaFpvU1VQSktvdGlNRGo0RVRtUGo2RGsvVTFPRlhHcysvaTdTUGc4?= =?utf-8?B?R3dabTREQlNyUGluNmtYc0UwbWdjdlo5RXlqck5oU1dCZno3bFFtaWI4ZVUv?= =?utf-8?B?LzNsSW1oUDJmZzZsWUViTzJjdVlUZFlYVnpKeG94SUVQY2RuTUpwSFpIMXQ2?= =?utf-8?B?NmhTN0lNWDlCOFlTdDQvaC9JU0lVaHB1YVY4S200SkViYVRHTzJmRmxuNGts?= =?utf-8?B?WVllUGthOVNleU11QXhQQlAxYno1V2l2MXBuUUxKam5NdEp3QkViZFdwd3ox?= =?utf-8?B?aGhSVEJ3WjdSckpNeDdIZjU4WDhHK3hNb25ieUt5MHkzL00yZEJtY3BtanVY?= =?utf-8?B?czQ5cldqbzNxSkM0NmJvaTdDdEdmSnRweUM1VTQyUUcvZ2hGWWZ3YnlHVXpt?= =?utf-8?B?Z2lPMDZYUElJUFJsV2R4TE01NXpycjdrQkFXKzdXYXRWdXJ6aTJHbGFvazgr?= =?utf-8?B?Z0lsVmY1bW1JVWtwUUdNeGlpMTd3L0lGaTcrcXRUU3JkLzFFaVlLdEp4WGd1?= =?utf-8?B?K2picnpJQjJCV0VlMVEwdUJZMERzSWFLQ3JsS3U4aUVWMlY5YWxVdThpejZi?= =?utf-8?B?K24yYjNuaTg0b2Fka3hPZWd3czJDZnBPSTVHZFFmRmRBK2xEZUlrT2ZMSzdQ?= =?utf-8?B?VzE1SWYxeGlGZnptTUxTRzg3ZTYyUnZ2TnNDOEVpekxUVGxPbzY2YVlISys1?= =?utf-8?B?OElHdml2d2kwZVJWLzA1a1N6V2U4UlVQY2dwM2xWNWRFRXdmOEJZNlBzcFNu?= =?utf-8?B?dGdJbE5wNkg3VDNZZ2RvUlRaZk1BaUI0dUxKczYyNW50RWR4YWYzMG5xM2lx?= =?utf-8?B?R1RhbFdKWGpoNnBibXRZQ0JlaU05Sno5bks3aGNVbEoxZVN6T0JMZjhMNFZW?= =?utf-8?B?cEVVTDFnby9BY1JOYmlseHFTcG1kbzhYZXpFb1VKQ3JiTTdSOVVzek9acGV3?= =?utf-8?B?L2NXVDMzMjBOZFpVVFVZVldpMU1qSTNDdGQ5cnA2eTZhMy9wbmNPWGJrVnJx?= =?utf-8?B?WWYrcWQxbVFXVXh6ZU9lc2JHNWVzL1BLR3JveFNOMFZlWkFNUy85UDlEb004?= =?utf-8?B?OVNNcHpwc0djWGg5VGRHdVJNTWZwbkovR01pM2tKTkRuMms1QlQvSXFaTUhG?= =?utf-8?B?OVRNMld3R3FmcXY0emp1YVVZTXRMN0pnUE5zQ0pXdW5kcWw4Sm1UbmpOTmgw?= =?utf-8?B?ZEUxNndTNHFzMk10YVNJektOeEZscG5QMUpmam9JSElxLzJvSkFqTzhMa3N4?= =?utf-8?Q?gecAAWL32q0T3h+I=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b304461-d30f-4d74-a33a-08da2cdfd2fc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:35:05.9978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KyTSKI+3aXYwS17XoOKoohzhacCqhe7amolsL2b5QkfJy3ypujt3L2PPAQay/251tUITG86xnFT6xfu0q8hz0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4179 Use the logic to set shadow SPEC_CTRL values in order to implement support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM guests. This includes using the spec_ctrl vCPU MSR variable to store the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with any SPEC_CTRL values being set by the guest. On hardware having SPEC_CTRL VIRT_SPEC_CTRL will not be offered by default to guests. VIRT_SPEC_CTRL will only be part of the max CPUID policy so it can be enabled for compatibility purposes. Use '!' to annotate the feature in order to express that the presence of the bit is not directly tied to its value in the host policy. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v3: - Use '!' to annotate the feature. Changes since v2: - Reword reasoning for using '!s'. - Trim comment about only setting SSBD bit in spec_ctrl.raw. Changes since v1: - Only expose VIRT_SSBD if AMD_SSBD is available on the host. - Revert change to msr-sc= command line option documentation. - Only set or clear the SSBD bit of spec_ctrl. --- xen/arch/x86/cpuid.c | 7 +++++++ xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/include/asm/msr.h | 4 ++++ xen/arch/x86/msr.c | 18 ++++++++++++++++++ xen/arch/x86/spec_ctrl.c | 3 ++- xen/include/public/arch-x86/cpufeatureset.h | 2 +- 6 files changed, 33 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 7e0b395698..979dcf8164 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -550,6 +550,13 @@ static void __init calculate_hvm_max_policy(void) __clear_bit(X86_FEATURE_IBRSB, hvm_featureset); __clear_bit(X86_FEATURE_IBRS, hvm_featureset); } + else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) + /* + * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed + * and implemented using the former. Expose in the max policy only as + * the preference is for guests to use SPEC_CTRL.SSBD if available. + */ + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); /* * With VT-x, some features are only supported by Xen if dedicated diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5b16fb4cd8..db8f95ef7c 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1334,6 +1334,7 @@ static const uint32_t msrs_to_send[] = { MSR_INTEL_MISC_FEATURES_ENABLES, MSR_IA32_BNDCFGS, MSR_IA32_XSS, + MSR_VIRT_SPEC_CTRL, MSR_AMD64_DR0_ADDRESS_MASK, MSR_AMD64_DR1_ADDRESS_MASK, MSR_AMD64_DR2_ADDRESS_MASK, diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index ce4fe51afe..ab6fbb5051 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -291,6 +291,7 @@ struct vcpu_msrs { /* * 0x00000048 - MSR_SPEC_CTRL + * 0xc001011f - MSR_VIRT_SPEC_CTRL (if X86_FEATURE_AMD_SSBD) * * For PV guests, this holds the guest kernel value. It is accessed on * every entry/exit path. @@ -306,6 +307,9 @@ struct vcpu_msrs * We must clear/restore Xen's value before/after VMRUN to avoid unduly * influencing the guest. In order to support "behind the guest's back" * protections, we load this value (commonly 0) before VMRUN. + * + * Once of such "behind the guest's back" usages is setting SPEC_CTRL.SSBD + * if the guest sets VIRT_SPEC_CTRL.SSBD. */ struct { uint32_t raw; diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 6206529162..c9aabbafd7 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -383,6 +383,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) ? K8_HWCR_TSC_FREQ_SEL : 0; break; + case MSR_VIRT_SPEC_CTRL: + if ( !cp->extd.virt_ssbd ) + goto gp_fault; + + *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + break; + case MSR_AMD64_DE_CFG: if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) goto gp_fault; @@ -668,6 +675,17 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) wrmsr_tsc_aux(val); break; + case MSR_VIRT_SPEC_CTRL: + if ( !cp->extd.virt_ssbd ) + goto gp_fault; + + /* Only supports SSBD bit, the rest are ignored. */ + if ( val & SPEC_CTRL_SSBD ) + msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + else + msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + break; + case MSR_AMD64_DE_CFG: /* * OpenBSD 6.7 will panic if writing to DE_CFG triggers a #GP: diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 1408e4c7ab..f338bfe292 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -402,12 +402,13 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) * mitigation support for guests. */ #ifdef CONFIG_HVM - printk(" Support for HVM VMs:%s%s%s%s%s\n", + printk(" Support for HVM VMs:%s%s%s%s%s%s\n", (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_MD_CLEAR) || opt_eager_fpu) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", + boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_VIRT_SPEC_CTRL" : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : ""); diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 9cee4b439e..5aa3c82fc6 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -265,7 +265,7 @@ XEN_CPUFEATURE(IBRS_SAME_MODE, 8*32+19) /*S IBRS provides same-mode protection XEN_CPUFEATURE(NO_LMSL, 8*32+20) /*S EFER.LMSLE no longer supported. */ XEN_CPUFEATURE(AMD_PPIN, 8*32+23) /* Protected Processor Inventory Number */ XEN_CPUFEATURE(AMD_SSBD, 8*32+24) /*S MSR_SPEC_CTRL.SSBD available */ -XEN_CPUFEATURE(VIRT_SSBD, 8*32+25) /* MSR_VIRT_SPEC_CTRL.SSBD */ +XEN_CPUFEATURE(VIRT_SSBD, 8*32+25) /*! MSR_VIRT_SPEC_CTRL.SSBD */ XEN_CPUFEATURE(SSB_NO, 8*32+26) /*A Hardware not vulnerable to SSB */ XEN_CPUFEATURE(PSFD, 8*32+28) /*S MSR_SPEC_CTRL.PSFD */ -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 08:35:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319258.539442 (Exim 4.92) (envelope-from ) id 1nlo06-0001SI-KZ; Tue, 03 May 2022 08:35:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319258.539442; Tue, 03 May 2022 08:35:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo06-0001S9-HU; Tue, 03 May 2022 08:35:18 +0000 Received: by outflank-mailman (input) for mailman id 319258; Tue, 03 May 2022 08:35:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo04-0000uC-W4 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:35:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3832d10-cabb-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:35:15 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 04:35:12 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4179.namprd03.prod.outlook.com (2603:10b6:208:65::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 08:35:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 08:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3832d10-cabb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651566915; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=0ALjpBG9H74y2OyguSqoGmv7JglxakPmZeprVRyZkfY=; b=QjxjrLKdjXRu39HWD481EheRgRIwdgX0UayvSe2Yu+76Ru+yPFWVni/v rQh2YIK7vF5dU5/PMxOzGK7IkYeQRbOdogEBTgyFaEJtJy0UpOVs6R/WO 7dQ/qAS/DRr/SZ3crgy7Rr/ljCgTuTSUH6+j58t9QsycpULEjN7IFmSO7 c=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 70853965 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dUtX4q6V2UV66XiFupUuMQxRtEzGchMFZxGqfqrLsTDasY5as4F+v mtJDDiCO/yPNzOnc9FyYIvg9hkFsZ+AmtJkHQNq/nw1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSMRT44DvTJgt1DQj8ACnt5F4JN1L7IdC3XXcy7lyUqclPK6tA3VQQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YGjF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA+A/O9PRqi4TV5F16iZ7zHMLVQIXUf+tWrF+yo jrdp02sV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/e5VafD21dFzpZMoV45IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLS8ZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:pNzBaq7BPapexItjoAPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKnyXcV2/hrAV7GZmXbUQSTXeVfBOfZowEIXheOj9K1tp 0QDJSWdueAamSS5PySiGfYLz9j+qj+zEnBv5aj854Hd3AOV0gP1XYbNu7NeXcGOTWuSKBJXa a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWCSw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLLhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqn3d+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7kF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXKvoJBiKqbzPLd MeTP01vJ1tABCnhjHizyRSKeWXLzoO9kzseDlBhiSXuwIm6UyRgXFogfD3pU1wha7Ve6M0md gsDZ4Y5I2mNvVmC56VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70853965" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nArM+VtXNOLH3HS3W2eoxeBfOASKRtzYgDp7cDW4nEB1bOSzN7eUoSRm/9ZuADFMo8ixR+a7fgGfXfKalL0Zd8DaaruJylyrgRP72+4GGyl8yJw1Rv/+weejhsyvxMkVkkGamBVDirvqFwJBGPd3KOYQ1hFn1TnCvsf/O5Obt+zVVCzh5DzSmr1vWSm38ejztYDojJIJ89k3bB00eRgQEOaPH7jVFITfzVEa0fL18s/GFGa1opjnHd9GsUDXe2085Rr/h/ZRcftsw/IldPb8zq4uIGgwAj3y7cYNamaEJin9XIFGjqzpD2ma+GKHkZoL8MiUisuuTwaFbikx7I5/rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P5wbVzI2swND8Fk8snerwIQvwv/wXq7oC/Kmtewmsy8=; b=F15eCWs9uOG2NztQREHplO7WEH/Sq2qPEmlyc7Yvh/P2cKRpgztF7vMC+L3WGKGhoXVzJoSKAAGCWeb+ZfzduJkSHO8Y8oMoN3fo7KbPc6PAHzWlpFa03+PyIHqMV9dpdW80yV+M1WDKVzEIi3SYfp8XGL0kbny2//b7jwBMH85LAGiCVz1++iGUv5tebqMQKm3l6iygRugtNLHUSXcrRuCQfoK+E2lnpR9IXelNZSEKlugLQ1Rosws4Z2gyNOg9nijkwI4jSybZo4hHikcl697sMgJ5AMsouYiEqSR3CccoynyduRGNUilFnB+zvua+7i/VMhw/n+vCwgkxbcS5XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P5wbVzI2swND8Fk8snerwIQvwv/wXq7oC/Kmtewmsy8=; b=OGey+vu6tUUSvzE5TGiuw1PSdGfk23Ok6cyazGhaO8054bNmcDhBNKgBKZGObh4sPR1gE46NPVpZVksU4u3JkL82R5qVdb42omsPMpfZPMMC6c3/w4GOnE9UlZvKhoyXPYSMGXWYw7s7noZSZagb191Gy51uUoVUOj7+TuMlmsc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Date: Tue, 3 May 2022 10:26:49 +0200 Message-Id: <20220503082650.23049-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220503082650.23049-1-roger.pau@citrix.com> References: <20220503082650.23049-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0419.namprd13.prod.outlook.com (2603:10b6:208:2c2::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3efebba0-173a-4d2d-3898-08da2cdfd56b X-MS-TrafficTypeDiagnostic: BL0PR03MB4179:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CZ0Yf6ReLlDbsLYRzYeAYx4GjgxJJSNcyJlSrvzS90RlqfXQ9lH0PTcopk2KOfLN/MDa6bDoAK/rHy2Y6LCa19+CGVvXxLic6R1bxYUOOI2RI/dXEJtlVynQXcAPNhBOrTOtLPEc20KNhfw6yzpBy8Pqa/sjxQDnWccX+3utA4U7v1SdKIwInyysCASSnXKozgE/Ie1OxgKME7ncJLa3FHF1rDW6Jfp0AE+gypzII1ZP/I9nqBAGN3V7hkQbfNWwXX1DAziHUtz7FgkaOjkWbjQojXwcaGDKR0P/IT2sTAtgSQLOdcYStVQx7ZVl4NGEXKE6KxI4CY3BqzlmRNODpDDiOHqYA41vlPWRaErO7n0i8YRKUzdL5q52Asb+U5SM+P3i3guqLdCi3xZbz9LhNrGltISAYUXcy9Updr7QEgWm019il3tsy49zo7O608LLxaH9EE3mscSoqAMSxQQk/aoOuctO3qCy+frsfvdY3KpmWqrm25yIELSHrIOZ8vlbd/6n//BbvvZqMv1erj8UXN1WfeFATB10UE7zooDuBIZE/DaLPxSOCFAyWvRtwx4K6tDtl702faNTeKiIEMUp4d71n3qaiTsh18Cc8UunmK7Z45IFkVClK5/VjEAx/ALyf2LAtiO+sNeIupyIgFcDig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6512007)(26005)(6506007)(2616005)(6916009)(54906003)(5660300002)(8936002)(83380400001)(186003)(2906002)(1076003)(66556008)(66476007)(86362001)(4326008)(36756003)(66946007)(8676002)(38100700002)(6486002)(508600001)(82960400001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejlQZFI1Q3kzMENvM25LTTVtUXpnZWhUbncrVG9NbWJpU2ZCeG9iY3VuNCtB?= =?utf-8?B?ZjRFd0ZCMUcySXA3b0xtS2xHbnRtcnR1WEQ3dmoyV0M0NGlzUU5XelBxY25o?= =?utf-8?B?RnFnays0ejBZbFpjNUdCbC91MUwvSGlzNzBnamlEckdUb2JoM3lGS3k2MW9L?= =?utf-8?B?Vm5pV1ROQjBESUQ5UnlBZUVpYklYYndNektzMnRkL2lwY2ZPR0UrM0U5eGJH?= =?utf-8?B?T21kYUtac1NwWFAvUk9yR2J4NTIxdWt2VHFBTkdpZVdZRG1Ta2VGOFhoWXpa?= =?utf-8?B?UzZxNFMza2tET1gvdURpamJZSjFsQnVFSHJRZC9MTXppeWJwNXJEWTg4VSsx?= =?utf-8?B?cVA2VzV2ckhIZ05jVTYvWUdGdjFKNGgrNldnZktPSUpOMWJrUkZkd0tTQmQy?= =?utf-8?B?bHEvOGdXejZJcit1b0ZORlhQbWE5N0NCWFppcENLZm4zcy80eXRYM3JLdEdM?= =?utf-8?B?aVhydHpGWUZKZGFPTVBTWml0YmRwL0dMSStqVXZUVkNQNkx5UlpnTGlhRWNX?= =?utf-8?B?ai9RRURBbGF1bWxtWTYyMnRaOTNicHNBKzQzbTFyOW1oUXNJRkRKeGwxeTNI?= =?utf-8?B?L3VJa0tFbnR4UFlVSDJtMFNYUmdvTENkMyt4R0prVEwwUnRCUHBwaG1Hb1lO?= =?utf-8?B?UVdlNFp1aXZJRG0wQ2dTa2VVRDNqVjhCcytDa1FJZ053TkNFKzZ5MG93WEc0?= =?utf-8?B?aGJJVkNVR2p3cXlMK0cwUG5rcWZqY2lGbjFINjhSanNPZFFCOHU4dVdvYjd6?= =?utf-8?B?VERsa3BQekQzUERkM2NOMmkybHRIeExsTTlhSHdxT1R6MGh5dzJROWZBaFhl?= =?utf-8?B?UFFWbDdXdWJQajZBNGVocThJa1lRTVdOYUVBSVdqaEVJRGtvQ1h4bWVxYmN6?= =?utf-8?B?MkhTemlNWFhFbnNDaVZabXhOcldYNG0yT3JnWFI5TmdPQitWY3pickhqYXU4?= =?utf-8?B?T0c4TUZXdjVuS1RKemYxWERlV2UrNDVMQkc1WE9BM1l5Umppdk5PcUJPcmpH?= =?utf-8?B?bEhVTDVlRGM0d0VMV1l4ZVp1MDREQnhvckVsb00vcytGWlJrc0dYYTBxdGdq?= =?utf-8?B?am9nQVdzaFhndnNHUkZQdVlLVGJBM2pZQWVncmVmd0h1VmtleWttS3dUMm1Q?= =?utf-8?B?UWJHbysyUm94bUhWNzgwN0M3OFd3Uk9aSE42SDI2cWV0TDE3LzEwVnFFVjA4?= =?utf-8?B?WTl4WlcrcFJpS0ZOMTVZeGVEYVBodjBvSjhtQ2pJa0dGUXFxWmUvYnVUZ1RP?= =?utf-8?B?MW1pMUIwYUlXZlNnbEpmSUtBUGkxMUN3S1FZRVNBNzRSUU9tUUxRVlZBM3JD?= =?utf-8?B?ODljdytGempnSHkrdEU1QWZjR3psY2ZULy9yRWpQckcxeGwrTVJVUzhkdEN6?= =?utf-8?B?cnFFWXNLTFROWGtoOFlxNHp3bFB4UEJuZkoyekZBTkNFc3Zxam56b0dpVDZt?= =?utf-8?B?WlQxcld1TWlkbFBRREJNRlhaMzRYY1RjMHc2eFpnNldWWVhnUWx2Yi91QUlt?= =?utf-8?B?WWRHU28yVlF2eDFidEh6ZzRDSDNhaDdnSW1BckRYOXBKSDBYNjB3VnlpQ3N3?= =?utf-8?B?bWZTakJKdUMrallRZHVON29sM25PYVFrMVcwZ2tETmdlQVNyZnNCajNEZ3h5?= =?utf-8?B?WWZ6WkIwSmdxdUxiNnRrckdaU3NEUzVPNytyazZnS2pHYkt6MXo1MU15MkNY?= =?utf-8?B?UFJvbW9nVmJEbHFLdmk3eFp4VkY4ekNJT3JFVDBUVFl1enAyd3ViYnJuOFpM?= =?utf-8?B?cGhSRkxuZ0lyZFdFcDZxcmdMUzJSeW9zNWdxN2pGdEhaaXdDUWh4bEVTcGxh?= =?utf-8?B?dW5hTk5PenpnNzZZYkVDVDFabnI5amswcGlPd0lLWlRaQTdBN2IrYjdaVkFt?= =?utf-8?B?UTlhRTROTHFEM2o1NkpiU2ZSMXJzeGZLaWdWcU9OTXNpUUxWTGVwUVV6YzBt?= =?utf-8?B?cmhVK0M5YmNpOUFSNU0xazRvYjlnVUZwLzY0dkwrMDBWVTZjOHllUGJGNHFt?= =?utf-8?B?Z0hyQ0R0YVBLdWtrRkVSMjJ3TzEzOHQ5RnMwQjVmY3dMVFo1Mjg5NGpVNFVU?= =?utf-8?B?Y25YT1krM25HbVkvUjNxT0l1WG1jUlRJZVBuck5TaEdhYUZVSjI5MHE0WE56?= =?utf-8?B?Y2RsZVAyVmxtZHQxWExLYVFLQU9DT3hJdGxaa3N1WXRwY0tDR0h2UHBSVC9I?= =?utf-8?B?UmFZT21tRkliUGluZHFPcWZ0Mm1NSkJHZC9JT0ZoZmExVUl0ZHphNnRxcjd1?= =?utf-8?B?NG8vWmNNNndJZWwwN2lBL0d6ekNHaWxpT3lQd3R3OXNyYjF3RTFuTlZrUVFl?= =?utf-8?B?N08zbG5wM2JCdlg1bHhVOTMrbDBGbEdsWG9hU2VDdHV6WGRHWEZHUHd4eHYz?= =?utf-8?Q?GVIiLq+AcJ2LR94g=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3efebba0-173a-4d2d-3898-08da2cdfd56b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:35:10.1574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1wUF31VvNbiyvwer9fIpws9c4wOkaGpivcLy3g/TCfHYpHvKthrINPJjQ1eFV/CheBPGDQjb7ijXyj1IULil0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4179 Allow HVM guests access to MSR_VIRT_SPEC_CTRL if the platform Xen is running on has support for it. This requires adding logic in the vm{entry,exit} paths for SVM in order to context switch between the hypervisor value and the guest one. The added handlers for context switch will also be used for the legacy SSBD support. Introduce a new synthetic feature leaf (X86_FEATURE_VIRT_SC_MSR_HVM) to signal whether VIRT_SPEC_CTRL needs to be handled on guest vm{entry,exit}. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v4: - Fix exposing in the max policy. Changes since v3: - Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest setting. - Do not use the 'S' annotation for the VIRT_SSBD feature. Changes since v2: - Reword part of the commit message regarding annotation change. - Fix MSR intercept. - Add handling of VIRT_SPEC_CTRL to guest_{rd,wr}msr when using VIRT_SSBD also. Changes since v1: - Introduce virt_spec_ctrl vCPU field. - Context switch VIRT_SPEC_CTRL on vmentry/vmexit separately from SPEC_CTRL. --- xen/arch/x86/cpuid.c | 10 ++++++++ xen/arch/x86/hvm/svm/entry.S | 8 ++++++ xen/arch/x86/hvm/svm/svm.c | 35 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeatures.h | 1 + xen/arch/x86/include/asm/msr.h | 10 ++++++++ xen/arch/x86/msr.c | 16 +++++++++--- xen/arch/x86/spec_ctrl.c | 9 ++++++- 7 files changed, 84 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 979dcf8164..0b6ba117b7 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) raw_cpuid_policy.basic.sep ) __set_bit(X86_FEATURE_SEP, hvm_featureset); + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); + /* * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional * availability, or admin choice), hide the feature. @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void) guest_common_feature_adjustments(hvm_featureset); guest_common_default_feature_adjustments(hvm_featureset); + /* + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus + * VIRT_SC_MSR_HVM is set. + */ + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); + sanitise_featureset(hvm_featureset); cpuid_featureset_to_policy(hvm_featureset, p); recalculate_xstate(p); diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 4ae55a2ef6..2f63a2e3c6 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -19,6 +19,8 @@ .file "svm/entry.S" +#include + #include #include @@ -57,6 +59,9 @@ __UNLIKELY_END(nsvm_hap) clgi + ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \ + X86_FEATURE_VIRT_SC_MSR_HVM + /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ /* SPEC_CTRL_EXIT_TO_SVM Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ .macro svm_vmentry_spec_ctrl @@ -114,6 +119,9 @@ __UNLIKELY_END(nsvm_hap) ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ + ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \ + X86_FEATURE_VIRT_SC_MSR_HVM + stgi GLOBAL(svm_stgi_label) mov %rsp,%rdi diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 0849a9dc5f..2d0ad05111 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -610,6 +611,16 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) svm_intercept_msr(v, MSR_SPEC_CTRL, cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); + /* + * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest + * setting and avoid having to perform a rdmsr on vmexit to get the guest + * setting even if VIRT_SSBD is offered to Xen itself. + */ + svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL, + cp->extd.virt_ssbd && cpu_has_virt_ssbd && + !cpu_has_amd_ssbd ? + MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW); + /* Give access to MSR_PRED_CMD if the guest has been told about it. */ svm_intercept_msr(v, MSR_PRED_CMD, cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); @@ -3105,6 +3116,30 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) vmcb_set_vintr(vmcb, intr); } +/* Called with GIF=0. */ +void vmexit_virt_spec_ctrl(void) +{ + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; + + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) + return; + + if ( cpu_has_virt_ssbd ) + wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); +} + +/* Called with GIF=0. */ +void vmentry_virt_spec_ctrl(void) +{ + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; + + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) + return; + + if ( cpu_has_virt_ssbd ) + wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0); +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index 7413febd7a..2240547b64 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -40,6 +40,7 @@ XEN_CPUFEATURE(SC_VERW_HVM, X86_SYNTH(24)) /* VERW used by Xen for HVM */ XEN_CPUFEATURE(SC_VERW_IDLE, X86_SYNTH(25)) /* VERW used by Xen for idle */ XEN_CPUFEATURE(XEN_SHSTK, X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */ XEN_CPUFEATURE(XEN_IBT, X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */ +XEN_CPUFEATURE(VIRT_SC_MSR_HVM, X86_SYNTH(28)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */ /* Bug words follow the synthetic words. */ #define X86_NR_BUG 1 diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index ab6fbb5051..460aabe84f 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -375,6 +375,16 @@ struct vcpu_msrs */ uint32_t tsc_aux; + /* + * 0xc001011f - MSR_VIRT_SPEC_CTRL (if !X86_FEATURE_AMD_SSBD) + * + * AMD only. Guest selected value, saved and restored on guest VM + * entry/exit. + */ + struct { + uint32_t raw; + } virt_spec_ctrl; + /* * 0xc00110{27,19-1b} MSR_AMD64_DR{0-3}_ADDRESS_MASK * diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index c9aabbafd7..d87317e989 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -387,7 +387,10 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) if ( !cp->extd.virt_ssbd ) goto gp_fault; - *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + if ( cpu_has_amd_ssbd ) + *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + else + *val = msrs->virt_spec_ctrl.raw; break; case MSR_AMD64_DE_CFG: @@ -680,10 +683,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) goto gp_fault; /* Only supports SSBD bit, the rest are ignored. */ - if ( val & SPEC_CTRL_SSBD ) - msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + if ( cpu_has_amd_ssbd ) + { + if ( val & SPEC_CTRL_SSBD ) + msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + else + msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + } else - msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; break; case MSR_AMD64_DE_CFG: diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index f338bfe292..0d5ec877d1 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -406,9 +406,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_MD_CLEAR) || + boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || opt_eager_fpu) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", - boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_VIRT_SPEC_CTRL" : "", + (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || + boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL" + : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : ""); @@ -1069,6 +1072,10 @@ void __init init_speculation_mitigations(void) setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM); } + /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ + if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd ) + setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); + /* If we have IBRS available, see whether we should use it. */ if ( has_spec_ctrl && ibrs ) default_xen_spec_ctrl |= SPEC_CTRL_IBRS; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 08:35:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:35:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319267.539453 (Exim 4.92) (envelope-from ) id 1nlo0X-0002Uy-Vr; Tue, 03 May 2022 08:35:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319267.539453; Tue, 03 May 2022 08:35:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo0X-0002Ur-SW; Tue, 03 May 2022 08:35:45 +0000 Received: by outflank-mailman (input) for mailman id 319267; Tue, 03 May 2022 08:35:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo0V-0000uC-QD for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:35:44 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 037062e4-cabc-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:35:41 +0200 (CEST) Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 04:35:16 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4179.namprd03.prod.outlook.com (2603:10b6:208:65::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 08:35:13 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 08:35:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 037062e4-cabc-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651566941; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=d0r5ad4K3r4CkLRcWIDa+90V/Ub7pWJBWgKi+1nEoeU=; b=G47wjXsS9DrGT3mKa2hRxJnGprb4IGeqGk//BX6zptyB4kkp+z+EZYo9 wWxEbe9typIEPFRT1aXKt1kORPfshhAeJ4wmashOVaA1DeHjf83fU9qr8 vX/X+1dJNsLe5gAFIB4S2zHzYO54iLPefm/zQFFOqpsYrxhTOJxl7pVdh g=; X-IronPort-RemoteIP: 104.47.51.44 X-IronPort-MID: 70853970 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kILK26p4Yvgbb1Htno8LkWraaL5eBmI6ZBIvgKrLsJaIsI4StFCzt garIBmEb/uCZmD0f9l1YIWy/RtUv5fXyYRnHgc4/y89ESJHopuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 Yiq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBAbHuxeBDTDZkLHtEYY5U3rraE1GPvpnGp6HGWyOEL/RGKmgTZddd0MAuRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFhXFs2qiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N9fdssjeLpOB3+J+wD4uMRYKEfupMw2WGp SHC1kLDRQ5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/p/J koO62wRpK493EWxS5/2WBjQiHWDuxsBXdtMAqs/4QeExafOyxaUAHAeSTxMY8Bgs9U5LRQo3 FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iEvJR9M7T6qt1IWpRXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodd7xooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:NOIApK26Lzh0ShTZfJan7QqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8O3WBxB8bYYOCCggeVxe5ZnO/fKlHbexEWs9QtrJ uIEJIOd+EYc2IK6voSiTPQe7hA/DDEytHRuQ639QYQcegAUdAE0+4WMHf5LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+FZgNYtvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70853970" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QY2dFVnZDrMW3NzYwit7lVXpj4tuMC3yJT8MCziZ1uc5Ldp2l1tAnhCjffevM7WoEnjKy+8IqW2JmuZp4QWOhp/rzVVShyGZACd5Wk0Efy1ZBqDIUTB91Rwy/uZw+J6oXXokyvTdkYmcaXiDtoixLRNl3aRPVgXQ/YBrT/mBQhd6bmgqFGTf46dLHU4n/zwx1xTLigMQm7Bv8p9/tdnKJSs7rFDx2D4tWl6mfCO33KxFoYZyJ8X7fZHHb49+4XmJa/pNDNEj3LRdxXqg3q6bm8U5StR6l9wOz8byiW1SNyBuqjn301uSiNJllQly3ZuWCCrIijaPULurL5UFyJX+sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5wehwItelrslTp4h5pL3pzGUxU0zbfXkKGD+PTUrBRc=; b=VXnjg4iAhtj35JwCVhtZ54mZhM9EPQ6ufzjrp1rD/VlxgzkKE9qOYJn8221EOxVU4D6Fun0h+cme5rXAYu1GerTUcMVImqpJW7ncwAAdorA7mdWIeB640Ckl9D8xUEhrIL0PCkW6KMmBM32/8fELiLNGf26ZJTG1Qp2jtdoLJv6YNaRrKPFtuNBGQprky3IUW/Iqi8+QllG4vy9cykpF3CuXuNNKpRKDAS0UCTpVTA9sLzZeBEJDPPXYq5C6P6a+9yFDLPJmNLWlzsp3Q6wGiJtKdp9evz8bmo6dFnH16WTtXGCz9MobajB+Odkbnhej68f6hRVRX3lCQWjH7sHYMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wehwItelrslTp4h5pL3pzGUxU0zbfXkKGD+PTUrBRc=; b=PYO/JTaiGSrovQdR0CQZNKBZ5UdLpqBscNuGynX6NGZIYuSARDkOhAfAodr4QzN5uAGU/TJZkhJM3JI01gpK1vsNu7IjU3g6bI4i2XnxdswhlszqvMnZ6k9j8gq6zyBGw8rIKfVUjeHe+eQn1t2WYzyAbqlIYPS2M4RKux58LR4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Henry Wang , Community Manager , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v5 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD Date: Tue, 3 May 2022 10:26:50 +0200 Message-Id: <20220503082650.23049-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220503082650.23049-1-roger.pau@citrix.com> References: <20220503082650.23049-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR10CA0030.namprd10.prod.outlook.com (2603:10b6:208:120::43) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60dae633-6aac-49b2-f519-08da2cdfd74c X-MS-TrafficTypeDiagnostic: BL0PR03MB4179:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Q8PkQSQdhlYxhAtGOualmdheRwl2gURR9JcpWI7o/d6dIffC90ASs0aa3DWSBMc3phpw/uP5EV6RwAux0++03OOBIyqTsUblJQczhVGdm+VE9vQjhpV/9ZPZ8CMFEDaHB6gQz4lofK6g50dLhdEbHnrqnBzMniKhM149wv4xPqcmCPqxJFOQnFW7R+jVI0DdXnXw0wYsjj49HMerTwo5WW4jGrYBXmk5KlKcAMAQBDm8VmXID/53lNrOnk1rlejn19VxMaxo/1UCsHl7r1PoOPq9odlQ0PMlrXlaAQ50FI0p0okAtGyswxzap6aWoJLVrRSnTvorBVPuCfIkhFbQ91DRcpTGV2cvmKT9rCEid95FwvT/y4y9VyPhwmIFb+qSND18+f3678zjwev+PcrImUv6yPy0xdPKmRv0me5HgzVBJJxb90mb8wQXnWgkMIWvFTdTb5TAXp9K8oaW1Y7PgV1FlQAIVIRj8ejSpev4464S27d83MWs3loZS4HxWPFrGNAhW6dnE70TYP+ccgTFAu4iCymB6fff0DmMelY+4u6m/Ns1KOihmRikgfNch9639QLjCkaYQU6+2JPO/1txyBvfCB7SC05+QpoWk87ujrDjhxW1jTra4WKvsJZXzsxZklZPgKfJ+vCP5XJ/btzBArWzg0B9HVEVVV+us084I1uqDoZkMyg5xXkwJCVDxRkuEB6gIJFXjnprJt+vlh44HnVgQCW9n9xz0h4FUlS3PE2rPgILXgmvGnc7W2RiVpJyEE/CD5L3zfNSqYX+KrlFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6512007)(26005)(6506007)(2616005)(6916009)(54906003)(5660300002)(8936002)(83380400001)(186003)(2906002)(1076003)(66556008)(66476007)(86362001)(4326008)(36756003)(66946007)(8676002)(966005)(38100700002)(6486002)(508600001)(82960400001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VC9PYUZMZTBvVzA5Y0lDeXRONWpISEFpeWVxMnFCRXpkeWVuK2pSQnlEVmJI?= =?utf-8?B?c3U0REREd01tVHRYSWxaWVZBbXc3dkpvK3RwOHZxMHlaay8xdEdHK0tmc2Nu?= =?utf-8?B?UUU0NzNXdEcwR3NHR0JFMkhONlNOeENIMGVsYmQ3NkU3Y3pxNVQ1VU50SVpk?= =?utf-8?B?VHBpZGlJa2tRQ25mbU95eFhiVnhrNFVjaGtrMlhMVTlVNzRHQzA2Q1FZUitu?= =?utf-8?B?ZkFkenM2Tkp3T2RsWW5yZStlSXgvMmg1aUhwbjlkVjdhVzUrdTBORHNuMUZj?= =?utf-8?B?c21OcFdWYWxaYm5CdGJ0QnFmaTAzTUU3NFpoY1NQY0h0ZVd2VzB4SjRFbEpw?= =?utf-8?B?clZ5eVBSeGthOSs1eitIWXFad2hKKzEyVkNTdE1SNS9ncEhnTTJkMjY0V2JR?= =?utf-8?B?WG42UXk4OXc5ODU4N0wwaGVDVzVCWkVJQ1FMeHMwQkxLRzkwTUdSK3NqMjVY?= =?utf-8?B?SDBtZjZjWjBERnZTbkhHSmlVekVGeHdqYWFpOGR3allqWlpGMHBHdThKVmhu?= =?utf-8?B?bjVEV2NYNkpxYzFQUXhRdStzcHdZRzBuZ0ZYNDMvalNvOXR5U0pjb0RUUVdL?= =?utf-8?B?RDduQjIyVzZoQjhhSU9QSWlLVldTUFZ3MlJwVHpBL2FUamJKLzN2Rjhoakh2?= =?utf-8?B?MGtndldZVjlzbXBreGZhaTdPWjQ5enRWNUZFSC9KNnZUTHM1akhQSk1rVERq?= =?utf-8?B?RXJVUEoyK2M4enVQd2FScVZjZ01GZ21ldFZ3VjBDUGN4Smg0NlVac01kN1Bn?= =?utf-8?B?UTRxOW1tTXVocHVmMmNYQ21KSWtUNXl5d3FEcHJvTTRWODBKUXUyMldLQXdt?= =?utf-8?B?SERjUE8rWkJZTGJNeDZLZys1Tm9wdlJvdS9VTzZIT2NZTWUrRzhHUmh4Mmxu?= =?utf-8?B?aWhONEdKWTNXeVRCZ01Kb0tWbjJkb3U5V1Q3REFFTVU3NGw0LzB0bVBUNVZC?= =?utf-8?B?SUlHa20wMk9KbzlkK1pKdy9RUklKTUxoMmRnNkZDQzdXWG9zQVBmYnBQdVRG?= =?utf-8?B?NmxReDcyY1lodnYyY0tJUmFxUm9LTCsya1hBMnVFdG5MSXpWb1JHNWFtTlZi?= =?utf-8?B?MFNLNURpcDI1NzVqWmlQdXYrejVIWm1hQkxRN1ZZaGtHYlJnaUlZOXcwUXdS?= =?utf-8?B?cGxxTGNUNWV2UnZUbnhnYm5SWEVOR2Z5REhqYXA1MmdmZ0g2NVFRRVBPZnlM?= =?utf-8?B?WCthYTUwUnd4Q0VUNVJBYWYraXdteUxWdTU0TGJsS1ZEUzlsWjhFWTZxRFZL?= =?utf-8?B?eTQ1V3hxVm1wTSt2d25pbzRpZmVDYVBHUzJmaHVHZThsYk1SSWxtbnhYQlJl?= =?utf-8?B?dEhJaXBmaEhDTFBvd3dSMWJVUlhVRzBUWnFSWmh6aE43NXcyZURXV3FQZmI3?= =?utf-8?B?MkNnWUNJditueUg0cER3d0djeHJwVTBWU2MzVWtTZzRoODJ3M095b3JrRXB4?= =?utf-8?B?RjZHQmRYVlpibVovYmI1K2o2S3A3NkRZWURieWtwMEZUSEpvakZZM1d1UlJO?= =?utf-8?B?VGM0S2k0NlROMjBJcWtiK0QrOVU2ekxJNGVFMTRwOVVBMU1kdmdFd0RFQWZh?= =?utf-8?B?bzBwU1hUemxWblZwZ3RTRGZ2bXlwa2ZyMTJOQWFjQ0NkTXgzUWo3TzRHb0Ey?= =?utf-8?B?aXZhUUU4WEVTVnk0ZWlPVTFmMGhKbVhKT0tXNVlNQU45Ym5Ib01KdGgwZnhx?= =?utf-8?B?eUNDdS9TT05qcGFKWDNoNTZlUWE1MWhGS2x3aDdHR25HV0IxcVRvQ2NXVmpY?= =?utf-8?B?V01QbVNFUzhYVFJiMVFHYmNEN0tqYUFtcDVNeGFkZmNLdHl6OWRlK04ybFl0?= =?utf-8?B?ajE0azdHNjd4M2MwWUJCQzVyRnUvelV0VnhzbVFyWDdRR1E1VDhaVGlsZWN1?= =?utf-8?B?dklhbG9lRklRb0wybHIxdFdpdVhlRHZOdlJMR25SdVZvcnlTZTZTbWhBNitu?= =?utf-8?B?ZGVmWVRkdUo0VTVmbmZNdEY1UFdEZmEzaWVWYlRUb2gxNE1XNW5XQVRINEk0?= =?utf-8?B?WlhaSkxXSDB5MnBPNkpRbGxrTFJVc0FQN29rWXhDVXRMZEl2ZnBaU0xDaDRl?= =?utf-8?B?eEZKVmlWT0I4eUFsQUs3MjdqYWdVNUNLaVJMLyt1Y1R3UENiWkFvelJaQXZ4?= =?utf-8?B?Zy9zMU5JZXdVQUFXOEYra2NpSDM0OXJGajBlMFJCYUZIRFdwc1BsendwMUVW?= =?utf-8?B?Rno3K25raTdwK0dMeUt5SWZlYWhsRWxFZ0dsRTkzaFBrTjhUemZvSC9kU1lW?= =?utf-8?B?NEo0RlkrNTAxdUpONVNRaTBndHV6dWFDbS83QnVSM2dDNHdSZUh4cHl2Ums2?= =?utf-8?B?M3VJZHZ3RXpucDBQRVRjdjdhTHpWM0IwQlVkek1pdjY3SFgrSm45Q1RzTnV6?= =?utf-8?Q?no/iv6AR7PfbX56o=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60dae633-6aac-49b2-f519-08da2cdfd74c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:35:13.2194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ouAyEmN8rz/oIQzwmQwl5qJIM+CjTLi1KOcLuIesqY+MpHkz2XT51Z0ClY5nzdsCztGB2cqnSVWYeYHn4iZKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4179 Expose VIRT_SSBD to guests if the hardware supports setting SSBD in the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD allows for an unified way of exposing SSBD support to guests on AMD hardware that's compatible migration wise, regardless of what underlying mechanism is used to set SSBD. Note that on AMD Family 17h and Hygon Family 18h processors the value of SSBD in LS_CFG is shared between threads on the same core, so there's extra logic in order to synchronize the value and have SSBD set as long as one of the threads in the core requires it to be set. Such logic also requires extra storage for each thread state, which is allocated at initialization time. Do the context switching of the SSBD selection in LS_CFG between hypervisor and guest in the same handler that's already used to switch the value of VIRT_SPEC_CTRL. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v4: - Slightly change usage of val/opt_ssbd in vm{exit,entry}_virt_spec_ctrl. - Pull opt_ssbd outside of the for loop in amd_setup_legacy_ssbd(). - Fix indentation. - Remove ASSERTs/BUG_ONs from GIF=0 context. Changes since v3: - Align ssbd per-core struct to a cache line. - Open code a simple spinlock to avoid playing tricks with the lock detector. - s/ssbd_core/ssbd_ls_cfg/. - Fix log message wording. - Fix define name and remove comment. - Also handle Hygon processors (Fam18h). - Add changelog entry. Changes since v2: - Fix codding style issues. - Use AMD_ZEN1_MAX_SOCKETS to define the max number of possible sockets in Zen1 systems. Changes since v1: - Report legacy SSBD support using a global variable. - Use ro_after_init for ssbd_max_cores. - Handle boot_cpu_data.x86_num_siblings < 1. - Add comment regarding _irqsave usage in amd_set_legacy_ssbd. --- CHANGELOG.md | 3 + xen/arch/x86/cpu/amd.c | 121 ++++++++++++++++++++++++++++----- xen/arch/x86/hvm/svm/svm.c | 4 ++ xen/arch/x86/include/asm/amd.h | 4 ++ xen/arch/x86/spec_ctrl.c | 4 +- 5 files changed, 118 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a7755d7b0..9a007e2513 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options +### Added + - Support VIRT_SSBD feature for HVM guests on AMD. + ## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02 ### Removed diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 4999f8be2b..27f4d51e86 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -48,6 +48,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); /* Signal whether the ACPI C1E quirk is required. */ bool __read_mostly amd_acpi_c1e_quirk; +bool __ro_after_init amd_legacy_ssbd; static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, unsigned int *hi) @@ -685,23 +686,10 @@ void amd_init_lfence(struct cpuinfo_x86 *c) * Refer to the AMD Speculative Store Bypass whitepaper: * https://developer.amd.com/wp-content/resources/124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf */ -void amd_init_ssbd(const struct cpuinfo_x86 *c) +static bool set_legacy_ssbd(const struct cpuinfo_x86 *c, bool enable) { int bit = -1; - if (cpu_has_ssb_no) - return; - - if (cpu_has_amd_ssbd) { - /* Handled by common MSR_SPEC_CTRL logic */ - return; - } - - if (cpu_has_virt_ssbd) { - wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); - return; - } - switch (c->x86) { case 0x15: bit = 54; break; case 0x16: bit = 33; break; @@ -715,20 +703,119 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c) if (rdmsr_safe(MSR_AMD64_LS_CFG, val) || ({ val &= ~mask; - if (opt_ssbd) + if (enable) val |= mask; false; }) || wrmsr_safe(MSR_AMD64_LS_CFG, val) || ({ rdmsrl(MSR_AMD64_LS_CFG, val); - (val & mask) != (opt_ssbd * mask); + (val & mask) != (enable * mask); })) bit = -1; } - if (bit < 0) + return bit >= 0; +} + +void amd_init_ssbd(const struct cpuinfo_x86 *c) +{ + if (cpu_has_ssb_no) + return; + + if (cpu_has_amd_ssbd) { + /* Handled by common MSR_SPEC_CTRL logic */ + return; + } + + if (cpu_has_virt_ssbd) { + wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); + return; + } + + if (!set_legacy_ssbd(c, opt_ssbd)) { printk_once(XENLOG_ERR "No SSBD controls available\n"); + if (amd_legacy_ssbd) + panic("CPU feature mismatch: no legacy SSBD\n"); + } else if (c == &boot_cpu_data) + amd_legacy_ssbd = true; +} + +static struct ssbd_ls_cfg { + bool locked; + unsigned int count; +} __cacheline_aligned *ssbd_ls_cfg; +static unsigned int __ro_after_init ssbd_max_cores; +#define AMD_FAM17H_MAX_SOCKETS 2 + +bool __init amd_setup_legacy_ssbd(void) +{ + unsigned int i; + + if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) || + boot_cpu_data.x86_num_siblings <= 1) + return true; + + /* + * One could be forgiven for thinking that c->x86_max_cores is the + * correct value to use here. + * + * However, that value is derived from the current configuration, and + * c->cpu_core_id is sparse on all but the top end CPUs. Derive + * max_cpus from ApicIdCoreIdSize which will cover any sparseness. + */ + if (boot_cpu_data.extended_cpuid_level >= 0x80000008) { + ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000); + ssbd_max_cores /= boot_cpu_data.x86_num_siblings; + } + if (!ssbd_max_cores) + return false; + + ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg, + ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS); + if (!ssbd_ls_cfg) + return false; + + if (opt_ssbd) + for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) + /* Set initial state, applies to any (hotplug) CPU. */ + ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings; + + return true; +} + +/* + * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality + * that relies on exceptions as those are not expected to run in GIF==0 + * context. + */ +void amd_set_legacy_ssbd(bool enable) +{ + const struct cpuinfo_x86 *c = ¤t_cpu_data; + struct ssbd_ls_cfg *status; + + if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) { + set_legacy_ssbd(c, enable); + return; + } + + status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + + c->cpu_core_id]; + + /* + * Open code a very simple spinlock: this function is used with GIF==0 + * and different IF values, so would trigger the checklock detector. + * Instead of trying to workaround the detector, use a very simple lock + * implementation: it's better to reduce the amount of code executed + * with GIF==0. + */ + while ( test_and_set_bool(status->locked) ) + cpu_relax(); + status->count += enable ? 1 : -1; + if (enable ? status->count == 1 : !status->count) + set_legacy_ssbd(c, enable); + barrier(); + write_atomic(&status->locked, false); } void __init detect_zen2_null_seg_behaviour(void) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 2d0ad05111..cd465eecc9 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void) if ( cpu_has_virt_ssbd ) wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); + else + amd_set_legacy_ssbd(val); } /* Called with GIF=0. */ @@ -3138,6 +3140,8 @@ void vmentry_virt_spec_ctrl(void) if ( cpu_has_virt_ssbd ) wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0); + else + amd_set_legacy_ssbd(!val); } /* diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index a82382e6bf..6a42f68542 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -151,4 +151,8 @@ void check_enable_amd_mmconf_dmi(void); extern bool amd_acpi_c1e_quirk; void amd_check_disable_c1e(unsigned int port, u8 value); +extern bool amd_legacy_ssbd; +bool amd_setup_legacy_ssbd(void); +void amd_set_legacy_ssbd(bool enable); + #endif /* __AMD_H__ */ diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 0d5ec877d1..495e6f9405 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -22,6 +22,7 @@ #include #include +#include #include #include #include @@ -1073,7 +1074,8 @@ void __init init_speculation_mitigations(void) } /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ - if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd ) + if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && + (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) ) setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); /* If we have IBRS available, see whether we should use it. */ -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 08:36:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:36:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319272.539464 (Exim 4.92) (envelope-from ) id 1nlo0n-0002xD-C0; Tue, 03 May 2022 08:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319272.539464; Tue, 03 May 2022 08:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo0n-0002x4-7u; Tue, 03 May 2022 08:36:01 +0000 Received: by outflank-mailman (input) for mailman id 319272; Tue, 03 May 2022 08:35:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo0k-0000uC-Vm for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:35:59 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0607.outbound.protection.outlook.com [2a01:111:f400:fe05::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0de54020-cabc-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 10:35:58 +0200 (CEST) Received: from AS8PR07CA0017.eurprd07.prod.outlook.com (2603:10a6:20b:451::26) by PA4PR08MB6015.eurprd08.prod.outlook.com (2603:10a6:102:e6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 08:35:55 +0000 Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:451:cafe::f4) by AS8PR07CA0017.outlook.office365.com (2603:10a6:20b:451::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.14 via Frontend Transport; Tue, 3 May 2022 08:35:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 08:35:55 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Tue, 03 May 2022 08:35:55 +0000 Received: from 589ff73727ed.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C4DB304D-C6FC-4C1B-A286-D4401E840EF4.1; Tue, 03 May 2022 08:35:47 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 589ff73727ed.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 08:35:47 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6937.eurprd08.prod.outlook.com (2603:10a6:10:26e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Tue, 3 May 2022 08:35:46 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Tue, 3 May 2022 08:35:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0de54020-cabc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QLiEOQS5JtfMXkd3GNxmUsbHs/SDNbA4BCYNugEw8RYt9qfNQEznRr/lrK4G2G89KOOGcM+frKwZvRPe6QssPqvTXkiJDnHofK65K/DCne3TjCOc+5Zd1N4g0zL31AnNoKYQXf37Sqo0YsYmCE9M1+Of2wE64f80K1sGhd4sSl0VEgrJDeyGch/UGPfAgN04M8D6Hi/jM/CJ7STGf8XlqmoHnkH5b/Uljgw+opmC55ADGCS2NuAiIhLobsGY1TC+KGNj96qECJnneX8AGSLX1Jwxd75ZnYlXG4H6NtMHH3H9JolnqHITEQx2DaxD5PeWhWFQW84WxRmdUYtIsBOJdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yda4xcJu5mnJDxkVyWw2AodnTbGtdWn9mxh+pgXoEPs=; b=SPIaE8TbRFViGntQVYHr8CoiQFVtptsHkkIViTXmt0CMeu8va08JpFKs9Nx1aw31KLd5RB/xjhEYFM5ujrQmbDA0itx4kUW1+LCbJ31YdJK+GN2FghwdQS4Ly5xsoeLXweNauUoSysL19gxXwkQwcVcS1ae2z2T+oo38UuDNlq8q+hHS6jaigi/oEeiG4Nhyd0g+PINLuWP5GfS6+DqmIyh7+7g7OAXn71QHsDuS6A2eWjr8qVVWoSSl6UrveiGEjREtllHrO2rxVWv2+3rZzSQ9dFQxHU2MmOwPVR8+Gvalarpaq3BLv+c2ZwIKvtHMYhfG6Ps+7scM8lB2DjQW8g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yda4xcJu5mnJDxkVyWw2AodnTbGtdWn9mxh+pgXoEPs=; b=mRUK4URrNyS3GWHxr0xAjZNx+rFYim2YvYiUgRge7PBek0Q96V2bsHwRAHfQOo9IK87qJSWWyzYxYc72tWXa2vTS8Bn1Kc8jIieK9KvqWG5l3x2JPWM9LuQMzOLBOKW7DryPPHv51Rt0RTPtnvl6FWs62UF/4gHYR8gLPPAQREw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 994f4633e817c899 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LjqoT1rKlty8qVoY/+0Ak+TRMDNtPhng8YQShn1i87hN4kQzqc3krFsloYGgSUaGUog8Ql3R8kuA+ymhqvsH+WcrWjlemYrEYgP9Zj5KJWVA8Fd6x9pee36/FarTSGQtzO5YIzx58/2ukMpDijsUy+zzN2KRO0316rM9YpWvcezOHpsHgJkZ2fnQzbNujwOALwoYwxYs5wYDT1F8jJWrZAOaDZ5kGG4leWuVvTVPa2UNlq/Bo060BH6dnFzzKQHIXiZ4c/YT1NCzf4jHBmC1FJJLZuh4ax1LsEKktIb5Ck00ZfzauDEKoh6cvZ++Y0B8OC6JugDwJ8+EmKeHQ6a6fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yda4xcJu5mnJDxkVyWw2AodnTbGtdWn9mxh+pgXoEPs=; b=BI8sg8yQwJ+ZrPpLx8vDD2UtsMx6IEuAxP+yrekT7lU0pKDraHOk74CKsgWw3ki3H5vkHIEc4z4387JZ5sc1rcI7sIzzfgv0VpHup/HAhlVYZSOTcjR3vklYYzCAMXs4vZZkeusqX3iCD7XSGgwi4qRVp+nYO8k3+WFn6x38Npyig2NFCEukJ7H5u2tddpMbytQpbM3jLbLUQdYSCSVss9WG/yiZQ5Bm44seRZVc+dU6ie86VQRSwT2dyyq6rPHVBEFKYEmJowUadq1xObexyKlF/qDgqR9wX2JmwLM+iTNw+8QfHE6QztUm6358Z/iz5z4Ely52aqS+BR8jzV5UPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yda4xcJu5mnJDxkVyWw2AodnTbGtdWn9mxh+pgXoEPs=; b=mRUK4URrNyS3GWHxr0xAjZNx+rFYim2YvYiUgRge7PBek0Q96V2bsHwRAHfQOo9IK87qJSWWyzYxYc72tWXa2vTS8Bn1Kc8jIieK9KvqWG5l3x2JPWM9LuQMzOLBOKW7DryPPHv51Rt0RTPtnvl6FWs62UF/4gHYR8gLPPAQREw= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "jgross@suse.com" , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , Jan Beulich Subject: Re: [PATCH v5 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v5 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYXAvIGnfac0SmG02EavYMjYFNdq0M2XkA Date: Tue, 3 May 2022 08:35:46 +0000 Message-ID: References: <20220429205732.2030094-4-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-4-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ab3d45dd-1f06-4a17-8283-08da2cdff0d5 x-ms-traffictypediagnostic: DB9PR08MB6937:EE_|AM5EUR03FT044:EE_|PA4PR08MB6015:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c9zGTGwvVbxU0wFYrZ8W86AxWjdlWHDrQa1KJUbbqbXFwxf7Nx3ZKQ4Fptb7UmJU895hufb+zuTEpVhYfJ4bAHYFAeqnlXiRI/Sr00lgGzSkIe0s5qDGXRmxcxGBSfyB9EW8naEHPd5+i8bS7YcyG0nCkg7MvmHxYaYFDhrqfgngFXatC02LmyWvKaD6kuzJ80yrL9T40e4P4VExsOu87ETZxbmJLhJu7TV7FmbJ8ZjMUFDbkJip2USRvR31/YN7ovuT8kBUyXLWG/6B67HJr3zFe2wqSSmpjt+ki3KVOfWHXZBwj2RjSZVf1XEY/9UA3xbBncfANwzm8vxw5pK50OvMEMXlySWFjfxyYnFGCZqJ2Ts3JshkrKOskpqFQCl5allec70OzQBDj22cLaXxOyZ5yWL1XmUSHlZNyt4CLGCcD2jftnvroDyLE6+kQZ0f0Ii4V8PKrmbhBI7iVnzcFGVirL4Pfuc1yfaq/C9td6WtjFj+uMK5PqffZmbRm0kLBRQMQa9L2VWY6lsO1Fl1kL5SLqPXXM4SaGEWdYWQrCmsndV5y2Dzs0SPSeDBgOF1e5ive1Vv/tc8j3q+0d/TN7WJIPXuNDUqj2/sTsN4eYKkZ5+BpLyAKq7E7EuHNht8L3EIxrKIqRZSg8AruDno0uPETvBa5oVhS0A8Mor9nL566S9Ngj3g8CYq22SHjG4iV4d39Dyv0GTPV1MV3aGEkFZPJTrsE1yrm3xtOZgKUZAlH4A83YVjkjievo1A0xg/PqP8cmDM4NVL2+OJRlRc0Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(5660300002)(2906002)(186003)(2616005)(36756003)(4744005)(83380400001)(508600001)(6486002)(6916009)(8936002)(38100700002)(38070700005)(122000001)(71200400001)(91956017)(26005)(6512007)(76116006)(8676002)(86362001)(64756008)(6506007)(66946007)(66476007)(66446008)(4326008)(66556008)(316002)(53546011)(54906003)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <301DAE064B7B6F4A9609D691F6B3318D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6937 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 922333c3-378c-43a0-17d3-08da2cdfeb7d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Kt2tMzzh0M+5fmcBxKVo5+bKIA30xGioG/jtxkS0SnhYcdobJEFmA8LwhlC5b+Oxax65FlsVGKEi8xcnRvwoPZug0VzE8Bk10yH7YVSyeGI9QtvoaCHkCEKMhubbQIfsh7ovsrnFBLmnoyPYCE2U9r6I1QmjUNwF1+HjnzZpzESnZiLiZeAQw/2s1hMXDusY2OCeyoU4j2A4g+YrDQSBi9e/GeX7CvtvGYevHDvOm5P4IeI7yBo9xjxUOfz/d3/r2ADDC2LrT1S/qaELOo1DlCF4gw8prtPnp9//MjgIV7h1Zw5kmqdEaHn/GTDlAa7chjslzv25E9qUqfyroSctTOpiLk1jpJ3OcHMTVTdTVLZkWMkRTYrnjFB1/+nOmi7lrJFj6iD3xxubW1ASU+BXDaqCxvxkjQoN7N+/1PdBvUJC4rgxeaJzN67JA0l+rYveFgShH2RAvc2A1YwXO653DOQk8/EqrXMem07Lcz0+1dvvgJK+bWk3OrW+aDHyjejKQGB25zm0ELDDAru27/V9EIxgpgtp8knHRplWCoJHZ7VgC9NZz+4v7DEnLTm4m2+luizlSyub02ebOnpwhoJGfZB3Sv5PRDEnUlmRC9SujUsLwayVBPuoW4sL8KczvysuD14wEwIWM+gn7g3lWY3PyNiIvnxCci8o/NhPY5OH84roan1sGFxBHsG2fAPjfgo68I15h+BXVe3vf2xe3ffZA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(53546011)(316002)(83380400001)(356005)(47076005)(107886003)(6506007)(40460700003)(508600001)(336012)(2616005)(86362001)(82310400005)(186003)(4744005)(26005)(36860700001)(6486002)(36756003)(5660300002)(2906002)(54906003)(8936002)(8676002)(70206006)(4326008)(6862004)(70586007)(81166007)(33656002)(6512007)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:35:55.5575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab3d45dd-1f06-4a17-8283-08da2cdff0d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6015 Hi, > On 29 Apr 2022, at 21:57, Stefano Stabellini wro= te: >=20 > From: Luca Miccio >=20 > Export evtchn_alloc_unbound and make it __must_check. >=20 > If "xen,enhanced" is enabled, then add to dom0less domains: >=20 > - the hypervisor node in device tree > - the xenstore event channel >=20 > The xenstore event channel is also used for the first notification to > let the guest know that xenstore has become available. >=20 > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 03 08:41:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319289.539486 (Exim 4.92) (envelope-from ) id 1nlo6H-00053i-DM; Tue, 03 May 2022 08:41:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319289.539486; Tue, 03 May 2022 08:41:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6H-00053Z-8M; Tue, 03 May 2022 08:41:41 +0000 Received: by outflank-mailman (input) for mailman id 319289; Tue, 03 May 2022 08:41:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6G-00052Y-GW for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:41:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d82337c6-cabc-11ec-a406-831a346695d4; Tue, 03 May 2022 10:41:38 +0200 (CEST) Received: from mail-bn8nam11lp2173.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 04:41:35 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB4095.namprd03.prod.outlook.com (2603:10b6:805:c5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Tue, 3 May 2022 08:41:33 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 08:41:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d82337c6-cabc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651567298; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=R+XeYU6S2in/ekRibsaCHDBwGUhFALnOPZsgvRdabFE=; b=M0WlRxPfSdXUwIA2CeVw/HuEaTQgpwiYJP8xXY6gIVnn7IKSTTzlQ39T j+4zs2KQuHUcf4m/pRjo7unzRSk8Mg8Na5uEWie+FHMnAikl0HRj3JWIx c1H1P1ES2l+a9pwSTdccZcrxV8c14Y85fzwH4QYe6fT2rCOxomdfP6AaQ 4=; X-IronPort-RemoteIP: 104.47.58.173 X-IronPort-MID: 70469249 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b6PliK0o9jpCuOysN/bD5bNwkn2cJEfYwER7XKvMYLTBsI5bpzQEz mAZWT2Ea6vbNzakKdwlaoXioR8Gscfcz4RrSFFqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw2oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1hir2uFB8AIJaQt+smTT9WEAdjOZV/reqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVvre03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianL2MJ8g7EzUYxy2Hf3iN7/b/qCof+ZuyqS+UIwkeou X2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySWosLVWhS5pDuOuE4aUt8JSukisljSkezT/hqTAXUCQnhZcts6ucQqRDssk FiUg9fuAj8pu7qQIZ6AyoqpQfqJEXB9BQc/ieUsFmPpP/GLTFkPsy/y IronPort-HdrOrdr: A9a23:VDnEgqpJtqpJESGlxbwds1QaV5uiL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCDwqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP0f2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aqSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7uvZNOyfaJNw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegx2w 2LCNUtqFh0dL5mUUtMPpZ+fSKJMB28ffvtChPlHb21LtBPB5ryw6SHkokd1aWNRKEi6qcUtd DobG543FRCDn4GT/f+kaF2zg== X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70469249" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKb1AmucS1rn+61wOSC0/4DJVP+60jZpOJ/40jI2vvv9r2X8QAc0Lw7CqvUfe8NEO4+1phqsaBjGy7zDuSKKxR+HUqDxXKnSlj2phEEe0MsvRmcSE3ICMjNca3n6LfOp2O5wFX501W4FM7C1Gv6ff/XNOjEmdStMi30YSX5V0ZUw5NqC99Q58SAXcuLwwpXgmhm39IFLVwaWGtsJooHoXO99aX5biZNgvu4khJmdvGSOydG7YAJH7G9xrKiefcjaZiXRoZ5OhWdM1IQHW0ZJUCSgI181luxUTvo4VE7mXPfljyZaGHNSYAg1gsZ7HODqEuxmV5iIiVdnODq7QKUF6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syQdOtap2ntcmdlvmSAF75iZkayGUWm1CBDsHUvIS5w=; b=dexOEhCSueUQU12DR/xoJiyihs0aGK+41PdRSMnjE92jdsUWsBLWw/ihOm6J5GNjvB0IZfFgc5aG+D2HdLhD64aMpFDbPst3Qf5jZpVN45CZpwWgHhQMubXcw5zZhiPqPV86lTfpqR58/zXCBPOYZb9qA13kM8SjbQm4qWjFBik+rCQBy+VIxT+YchFcf200ulVtJtvACfqil68T0mugYu7Y4ECSDh4Y5aqoZD9Pyf3rX3xQtJW2oaOcgmAEK2fTBkHPU82dlvt9556gb86jbmSK5aAlJZRttKCVFgvoXdId2hmE9U7xA+5Ew85ttmcyB6Yz/fcd0BbQdVDNuFxEXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syQdOtap2ntcmdlvmSAF75iZkayGUWm1CBDsHUvIS5w=; b=HZeNGH/0W7/C5sgCSzeCUQkJ+wr4XnVV9DuFrYjbedmqdxlOVLbrTr4fejJr109g92zaQ2bpgAjh6zeBoQP6DgnitvdbTO2qrGX3+aN7hqV2YcH7RjdRo4Zbpaebpa6uMS1bbIo0zFaS9haO5KeiIp7yKrwhcyw4b+nkJxQEhcw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 10:41:29 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: osstest: blessed sabro boxes Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0106.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:50::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc86254c-deac-4817-ab09-08da2ce0ba4e X-MS-TrafficTypeDiagnostic: SN6PR03MB4095:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jtj2fe436TzQ3VqbjnDZ+VmNb+2/VY+dEMwpUi6we1s0qs1Fy6VgSIH5ulU5uEqUgLnY4n1ERhBLmBmHMBJGTxnRDaf9WcRKAc6EqK5vxPacmob3Ieq7LUsPXOywI2+e9FzA/4cfF4CslkLM871Jgbhw2eEM+y+mUmM5ybYOeu19LUBWN9It3GrtlkVT4QgtKQuHdJdLc9D+FuCTmwPvT3neRe5OK7FNwggO6GtGrySkvs854w9CUYBKCmzNfN+cwYjIfLC1Hw3AZDuKhJTBfTzxUxu76lacpAmqagy3gPynmfUE+o4XtOUX6NXZ+n0qCDEIKh5H4Nz6epCp+l7bKlGCJFFtXoilQXnzxfSyl23KJSoS+MVB7l6z8PAuNEgUHq7jvLDevyXq5d9RaBARC4rklumJIdDLeyl0m4Bbqx0N2E4MKCZPbY2s328juFLElS3vVORQ91Cg/OM2FRVeqBBXZc89t4S3w6wKpn6BKymf0UGsvU4NcrZj7pSp537XEDym0v6IZIxBgckNQv1H36B68+AbofNm4m/nvQoLG/NgW6PltxwO2MSIS8n/fYrYrclgxHzvE9LQmsPqg0aPAKktbejn55NifbfSfc1AVypZiFbR1NlY05wNAHfsQDa2xWSDz0lSudJRoIwRZBtx2g9zjOolKUWh0GmbImdwPgxYeUUEDlTuZmwNluT+nCWIhkvxPPEGS98PqjEeImSQ40csSciF2DfNagbOfYFIVyvY+1xozKgU/hlyKuHsOeo83uRfoM8xbdaKCe+I2dyw4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(9686003)(6666004)(26005)(186003)(53546011)(6506007)(2906002)(83380400001)(8936002)(4744005)(33716001)(5660300002)(4326008)(8676002)(66946007)(316002)(966005)(6486002)(6916009)(66476007)(66556008)(508600001)(38100700002)(85182001)(86362001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2ExVFYyR0dEWldPb2xGRnlxd093cEFhRDFKWEdCNXJ0ME16TzJEZmo0MFJs?= =?utf-8?B?c1pvVmlpc3hrQTJYQmNGVWNuQ2gxQllOQ0V0SWtBYXZJdy8yNStLUFdrb3Rn?= =?utf-8?B?Z1N5N3RXTDBWTmhpWlowdURLMzFHTjRjL1J0OFIwUmphQm5jZHJ4ajdKTWlW?= =?utf-8?B?ZHNMakU1OW81OEpGTEJ3OUZwK2J1NmRZdGZhaDN0VGp0U2k3MWlOVDZmclZw?= =?utf-8?B?a2Q1dU9pRm1QTFdRKzJYdEF6dEowMXJnc3pIUzJsVDhBMS9VMDVwUlZZWEti?= =?utf-8?B?WW9PVHhRd1QrY01nN3ZIcXZFVkk5Z0J3dnRhZUkvODVBTUdManNvVmRLK2NJ?= =?utf-8?B?YUlDMWFWZHhkWEh5RWZnR0Npc1dXVkNaRm5SVkxFSW1MQk5pZlBLTldXbEpi?= =?utf-8?B?emsvYmxMRlBGNHM3QVVvK0ZUeUo0Nzd4aC9ScHNsYWI2Um1lM0J1U2dwV0JI?= =?utf-8?B?anpjZmU4UERGK1dHdVNhVmJIVGJrdXJnMFZEZjVxa0xhVWk0aFBJMUFJbjlq?= =?utf-8?B?MXhMdU5TUlVjWGxsK1h6K3RUd1QvZnkzYkdSU1pXaFdLdXRSVmRoelBwYkkz?= =?utf-8?B?TURkb0hMNVNKRW9nQjZUN1hyUGUvMDYrSmlIZVlVVEpjeml5Sk5sSzgrRGow?= =?utf-8?B?S1JIU0V4Tm9MUWwzUldsZUdPbjdrNDlYazBhaWpldTdOYjdHajVXWlVia3N4?= =?utf-8?B?MGV3cnFYZVFxVVRyeTFJU1FTNTY1aitDWTd1U3IydzhocEx4WDArbzU1SDYz?= =?utf-8?B?dHMzS05VT1J3bFhCbU1KbHV5cjQ3ZG90Ukx5Q0h3UGRMa3RBSDBWQjNyNEJi?= =?utf-8?B?bjdyTisrbVBYM0xHb0kxcDRhM0VOcm9UcUxGSHJ0WTE0R0NIY1AyQWlndFdI?= =?utf-8?B?cHVXU05Jc1BCKzhLbGM2KzRPbUFHM0xuVHBDeTVYaFRvZXFEbmprRU91Y0J5?= =?utf-8?B?dWo2djc0TWhlOXFwWWlnTmhWRmVYL0toSUdwRzlNekd1OHhNaGZLcWtOT1dh?= =?utf-8?B?akMzdko0RzUrZTE2VklONzRwOFRkWlZmUDVNcVNabUw2MGZ3V2JSOVFzTjNM?= =?utf-8?B?dDdxVlZEOUpjUzVpWlNKbFllRWE4SlNhZXBzQitoR3JRU3JXNHQ2UXpaM1FU?= =?utf-8?B?VW1GVTNrQlVsZ2dla1hEQXVkZ2lhNmtPZE1iZVFZQ3g1WU8wZnpNeGgvaU1C?= =?utf-8?B?YndUeFlYRzE3TG9Ra1A4blY0b2JXcW1SVXp0VWVFNFRZSG55L3d6eksrZ3dI?= =?utf-8?B?Q3JjUkpjaGdWOFpOS1NEYTFpM1BmY1o1U3lHNXNGTU52N29RdmN3RGdTSnpj?= =?utf-8?B?KzFxcC8rQWhuR3pPTlVrK0NrREQ5WThnRktPWnVkdXdSMWRVNlRlN3ZGdGtK?= =?utf-8?B?S01xTkd2bks2OVdHNEFqT2lGMnZXU1c5dEF1TUN5ekhTejZOT2tTa3ZGaGZL?= =?utf-8?B?b0NOYVdGNE05QWxpVVMzZFhDUnRyMVpGUHdZNDlaSGorbVlkditIVHF0bkxy?= =?utf-8?B?WnlKbGljKy9mU1JUSVhRUUtuWDI5TzY1Y3hvV3NBNXhza3FtT0hRMlRHNFlK?= =?utf-8?B?NDU4R2R5aVE2dEw1WjRBWEY1bW92TktrN1kzQStxZEUvMTQ4cjRBNHhkMUZX?= =?utf-8?B?TE9VUzFxNjNhRVdXUnB4bWhmOWZRSXpDTnI5TmZsZnJXL3F6ZkN1dHg1UmQv?= =?utf-8?B?eGJXN21sVVNvV2tBVkY2ZUtyV21SZWsyaUlrdklsZ3pXZWxqWU52YUdSam9s?= =?utf-8?B?RTBDam5mMm9sNXNYTG1ua05mWkhUc0hOWmZEN2p0YlZWdUtNeDNaZXNLM3NP?= =?utf-8?B?dWNiNEZ4MXQ2NEV3cnE2YjQ5KzRmK2x6U1BIWU1jOHVvWmxaZ0ozN2FPQ2VL?= =?utf-8?B?a2QrYWxzVjZjNjJsZ3FRcDBzOW5oUzRYREZUTHJ3cUwxdUdTZ3RxaHE0dXBV?= =?utf-8?B?UFNBcDQvYlg0ajhhL1NLNGxXNmZ3UG5tMjd4aFB4WEpIT3NxQ3poOXZrNEpL?= =?utf-8?B?WVE4Y0xrZm9kekhldkQyejYzcnV2OE1kckFMUkFpbGI3OTlUMEFBazZDSWxz?= =?utf-8?B?czNURld5aUM0RDNjZzFic0xOVDZYY0thSFRTZWlzRnZFREdzblV5eFpkUUNK?= =?utf-8?B?M0E1ZUk5aVhmOEpnanY2M2FrRlZZbzlqRjRtaXk0VHRacFZQc1BQNjR3K1ZN?= =?utf-8?B?MkNmbXllWmpEUWJjNmNwTnhZRE1DYXU0YWRiak1NY0g4emdmOHFVTTZqY3ZD?= =?utf-8?B?U2VXSmladkdadmVvUGRWdGJKZXdyYmxPcnRWT3Y0bzJGWXduZWtRZFdqQmdT?= =?utf-8?B?Q0cweTJVRTU1N2ZnRnF0NXlEcExhL2xwams4djBFdUllN3hWSmdzc3NvbTBp?= =?utf-8?Q?AeVUnyP/QXhj8KuU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc86254c-deac-4817-ab09-08da2ce0ba4e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:41:33.7298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J11XKVXvnYmo5rTMW3a4wOkD7s3Pon4fYbbqOIN5cG/UYwyY8si2ME4PcjiSoMU6zPWBS19PaXit8UXmFA45+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4095 On Tue, May 03, 2022 at 10:25:02AM +0200, Jan Beulich wrote: > On 03.05.2022 09:50, Roger Pau Monné wrote: > > Hello, > > > > I've blessed the pair of sabro boxes for production after a successful > > commission flight: > > > > http://logs.test-lab.xenproject.org/osstest/logs/169857/ > > > > Note that the boxes don't seem to be able to boot in 32bit mode, see > > the following flight where all 32bit jobs failed to install the host: > > > > http://logs.test-lab.xenproject.org/osstest/logs/169986/ > > > > I have no idea what's causing this, and hence sabros will only be used > > in 64bit mode. > > You may have better luck with a PAE kernel (which would then also be > able to use all of the memory rather than just about 1.7 Gb): > > Notice: NX (Execute Disable) protection cannot be enabled: non-PAE kernel! I'm not sure it's worth it, we have plenty of boxes that can do i386 just fine, so I think it's fine to have those as amd64 only. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 08:41:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319286.539475 (Exim 4.92) (envelope-from ) id 1nlo6C-0004m7-VA; Tue, 03 May 2022 08:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319286.539475; Tue, 03 May 2022 08:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6C-0004m0-S3; Tue, 03 May 2022 08:41:36 +0000 Received: by outflank-mailman (input) for mailman id 319286; Tue, 03 May 2022 08:41:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6C-0004lq-B2; Tue, 03 May 2022 08:41:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6C-00070F-7p; Tue, 03 May 2022 08:41:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlo6B-000297-Of; Tue, 03 May 2022 08:41:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlo6B-0002H8-OG; Tue, 03 May 2022 08:41:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dA5/8ifvb6FEU+4RoU0rMRXLJiTjMPIZbpY9HspZ5yQ=; b=Q9fDzNaru1II1MMVQBNQn/abI4 /L9UONQkr3o9ScWcJrd6051WLF7kJyE08L6/TvcltxrDGvIs2F3NF+7ivt2uw80Gkeab3QOGtHPL8 3zfYjf34rM79SAkOB5yvc6vSg2ok+uoGbSXfelhiNyqDIUSuuuUtUUxBKwmO0bpil0VA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170014: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 X-Osstest-Versions-That: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 From: osstest service owner Date: Tue, 03 May 2022 08:41:35 +0000 flight 170014 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170014/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail in 169990 pass in 170014 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 169990 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 169990 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169990 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169990 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169990 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169990 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 169990 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 169990 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169990 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169990 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169990 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169990 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169990 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169990 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 baseline version: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Last test of basis 170014 2022-05-03 01:51:53 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue May 03 08:51:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:51:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319308.539496 (Exim 4.92) (envelope-from ) id 1nloFS-00073C-9F; Tue, 03 May 2022 08:51:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319308.539496; Tue, 03 May 2022 08:51:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloFS-000735-6G; Tue, 03 May 2022 08:51:10 +0000 Received: by outflank-mailman (input) for mailman id 319308; Tue, 03 May 2022 08:51:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloFQ-00072z-Tx for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:51:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2af84a25-cabe-11ec-a406-831a346695d4; Tue, 03 May 2022 10:51:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 26B65210EA; Tue, 3 May 2022 08:51:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E659D13ABE; Tue, 3 May 2022 08:51:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5HBENvjscGIVRQAAMHmgww (envelope-from ); Tue, 03 May 2022 08:51:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2af84a25-cabe-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651567865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aw6U/cEHAwzyUlMvxUAXLuEyNzw5AARjyCOnJ76q/r0=; b=Z/N3/I2Nk2B9GX/rggMZX2WMRrw94YNlyjUn7v7fDUdTaXNhDjhlcpjKgOaYDGFwMLuxwU FO+9nmjCSoX4qBTyX1G8mhOCN+Km/QAGWx+imqxTQ2FZLIEE2vR9BmlHdRI0ai/rlC230C 137XQryIKIDnmYeA8fMefxeU0G/vZ0M= Message-ID: <7dbaf5c6-6576-4c95-69cb-195318a6baad@suse.com> Date: Tue, 3 May 2022 10:51:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Luca Miccio , Stefano Stabellini , boris.ostrovsky@oracle.com References: <20220429211027.2034134-1-sstabellini@kernel.org> From: Juergen Gross In-Reply-To: <20220429211027.2034134-1-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------KKMgEyxhl0Ks9DBYP9SIik2C" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------KKMgEyxhl0Ks9DBYP9SIik2C Content-Type: multipart/mixed; boundary="------------6QOLHIRXfG8NUChGSFKOSJ3r"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Luca Miccio , Stefano Stabellini , boris.ostrovsky@oracle.com Message-ID: <7dbaf5c6-6576-4c95-69cb-195318a6baad@suse.com> Subject: Re: [LINUX PATCH v3] xen: add support for initializing xenstore later as HVM domain References: <20220429211027.2034134-1-sstabellini@kernel.org> In-Reply-To: <20220429211027.2034134-1-sstabellini@kernel.org> --------------6QOLHIRXfG8NUChGSFKOSJ3r Content-Type: multipart/mixed; boundary="------------0vfJqR4uSHEDFMKJmzfhaxCT" --------------0vfJqR4uSHEDFMKJmzfhaxCT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMjM6MTAsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBXaGVuIHJ1bm5pbmcg YXMgZG9tMGxlc3MgZ3Vlc3QgKEhWTSBkb21haW4gb24gQVJNKSB0aGUgeGVuc3RvcmUgZXZl bnQNCj4gY2hhbm5lbCBpcyBhdmFpbGFibGUgYXQgZG9tYWluIGNyZWF0aW9uIGJ1dCB0aGUg c2hhcmVkIHhlbnN0b3JlDQo+IGludGVyZmFjZSBwYWdlIG9ubHkgYmVjb21lcyBhdmFpbGFi bGUgbGF0ZXIgb24uDQo+IA0KPiBJbiB0aGF0IGNhc2UsIHdhaXQgZm9yIGEgbm90aWZpY2F0 aW9uIG9uIHRoZSB4ZW5zdG9yZSBldmVudCBjaGFubmVsLA0KPiB0aGVuIGNvbXBsZXRlIHRo ZSB4ZW5zdG9yZSBpbml0aWFsaXphdGlvbiBsYXRlciwgd2hlbiB0aGUgc2hhcmVkIHBhZ2UN Cj4gaXMgYWN0dWFsbHkgYXZhaWxhYmxlLg0KPiANCj4gVGhlIHhlbnN0b3JlIHBhZ2UgaGFz IGZldyBleHRyYSBmaWVsZC4gQWRkIHRoZW0gdG8gdGhlIHNoYXJlZCBzdHJ1Y3QuDQo+IE9u ZSBvZiB0aGUgZmllbGQgaXMgImNvbm5lY3Rpb24iLCB3aGVuIHRoZSBjb25uZWN0aW9uIGlz IHJlYWR5LCBpdCBpcw0KPiB6ZXJvLiBJZiB0aGUgY29ubmVjdGlvbiBpcyBub3QtemVybywg d2FpdCBmb3IgYSBub3RpZmljYXRpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBMdWNhIE1p Y2NpbyA8bHVjbWljY2lvQGdtYWlsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBT dGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gQ0M6IGpncm9z c0BzdXNlLmNvbQ0KPiBDQzogYm9yaXMub3N0cm92c2t5QG9yYWNsZS5jb20NCj4gLS0tDQo+ IENoYW5nZXMgaW4gdjM6DQo+IC0gY2hlY2sgZm9yIHRoZSBjb25uZWN0aW9uIGZpZWxkLCBp ZiBpdCBpcyBub3QgemVybywgd2FpdCBmb3IgZXZlbnQNCj4gDQo+IENoYW5nZXMgaW4gdjI6 DQo+IC0gcmVtb3ZlIFhFTkZFQVRfeGVuc3RvcmVfbGF0ZV9pbml0DQo+IC0tLQ0KPiAgIGRy aXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYyAgfCA4NiArKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0NCj4gICBpbmNsdWRlL3hlbi9pbnRlcmZhY2UvaW8veHNfd2lyZS5o IHwgIDMgKysNCj4gICAyIGZpbGVzIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKyksIDE5IGRl bGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5i dXNfcHJvYmUuYyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYw0KPiBpbmRl eCBmZTM2MGMzM2NlNzEuLmRjMDQ2ZDI1Nzg5ZSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94 ZW4veGVuYnVzL3hlbmJ1c19wcm9iZS5jDQo+ICsrKyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94 ZW5idXNfcHJvYmUuYw0KPiBAQCAtNjUsNiArNjUsNyBAQA0KPiAgICNpbmNsdWRlICJ4ZW5i dXMuaCINCj4gICANCj4gICANCj4gK3N0YXRpYyBpbnQgeHNfaW5pdF9pcnE7DQo+ICAgaW50 IHhlbl9zdG9yZV9ldnRjaG47DQo+ICAgRVhQT1JUX1NZTUJPTF9HUEwoeGVuX3N0b3JlX2V2 dGNobik7DQo+ICAgDQo+IEBAIC03NTAsNiArNzUxLDE3IEBAIHN0YXRpYyB2b2lkIHhlbmJ1 c19wcm9iZSh2b2lkKQ0KPiAgIHsNCj4gICAJeGVuc3RvcmVkX3JlYWR5ID0gMTsNCj4gICAN Cj4gKwlpZiAoIXhlbl9zdG9yZV9pbnRlcmZhY2UpIHsNCj4gKwkJeGVuX3N0b3JlX2ludGVy ZmFjZSA9IHhlbl9yZW1hcCh4ZW5fc3RvcmVfZ2ZuIDw8IFhFTl9QQUdFX1NISUZULA0KPiAr CQkJCQkJWEVOX1BBR0VfU0laRSk7DQo+ICsJCS8qDQo+ICsJCSAqIE5vdyBpdCBpcyBzYWZl IHRvIGZyZWUgdGhlIElSUSB1c2VkIGZvciB4ZW5zdG9yZSBsYXRlDQo+ICsJCSAqIGluaXRp YWxpemF0aW9uLiBObyBuZWVkIHRvIHVuYmluZDogaXQgaXMgYWJvdXQgdG8gYmUNCj4gKwkJ ICogYm91bmQgYWdhaW4uDQo+ICsJCSAqLw0KPiArCQlmcmVlX2lycSh4c19pbml0X2lycSwg JnhiX3dhaXRxKTsNCj4gKwl9DQo+ICsNCj4gICAJLyoNCj4gICAJICogSW4gdGhlIEhWTSBj YXNlLCB4ZW5idXNfaW5pdCgpIGRlZmVycmVkIGl0cyBjYWxsIHRvDQo+ICAgCSAqIHhzX2lu aXQoKSBpbiBjYXNlIGNhbGxiYWNrcyB3ZXJlIG5vdCBvcGVyYXRpb25hbCB5ZXQuDQo+IEBA IC03OTgsMjAgKzgxMCwyMiBAQCBzdGF0aWMgaW50IF9faW5pdCB4ZW5idXNfcHJvYmVfaW5p dGNhbGwodm9pZCkNCj4gICB7DQo+ICAgCS8qDQo+ICAgCSAqIFByb2JlIFhlbkJ1cyBoZXJl IGluIHRoZSBYU19QViBjYXNlLCBhbmQgYWxzbyBYU19IVk0gdW5sZXNzIHdlDQo+IC0JICog bmVlZCB0byB3YWl0IGZvciB0aGUgcGxhdGZvcm0gUENJIGRldmljZSB0byBjb21lIHVwLg0K PiArCSAqIG5lZWQgdG8gd2FpdCBmb3IgdGhlIHBsYXRmb3JtIFBDSSBkZXZpY2UgdG8gY29t ZSB1cCBvcg0KPiArCSAqIHhlbl9zdG9yZV9pbnRlcmZhY2UgaXMgbm90IHJlYWR5Lg0KPiAg IAkgKi8NCj4gICAJaWYgKHhlbl9zdG9yZV9kb21haW5fdHlwZSA9PSBYU19QViB8fA0KPiAg IAkgICAgKHhlbl9zdG9yZV9kb21haW5fdHlwZSA9PSBYU19IVk0gJiYNCj4gLQkgICAgICF4 c19odm1fZGVmZXJfaW5pdF9mb3JfY2FsbGJhY2soKSkpDQo+ICsJICAgICAheHNfaHZtX2Rl ZmVyX2luaXRfZm9yX2NhbGxiYWNrKCkgJiYNCj4gKwkgICAgIHhlbl9zdG9yZV9pbnRlcmZh Y2UgIT0gTlVMTCkpDQo+ICAgCQl4ZW5idXNfcHJvYmUoKTsNCj4gICANCj4gICAJLyoNCj4g LQkgKiBGb3IgWFNfTE9DQUwsIHNwYXduIGEgdGhyZWFkIHdoaWNoIHdpbGwgd2FpdCBmb3Ig eGVuc3RvcmVkDQo+IC0JICogb3IgYSB4ZW5zdG9yZS1zdHViZG9tIHRvIGJlIHN0YXJ0ZWQs IHRoZW4gcHJvYmUuIEl0IHdpbGwgYmUNCj4gLQkgKiB0cmlnZ2VyZWQgd2hlbiBjb21tdW5p Y2F0aW9uIHN0YXJ0cyBoYXBwZW5pbmcsIGJ5IHdhaXRpbmcNCj4gLQkgKiBvbiB4Yl93YWl0 cS4NCj4gKwkgKiBGb3IgWFNfTE9DQUwgb3Igd2hlbiB4ZW5fc3RvcmVfaW50ZXJmYWNlIGlz IG5vdCByZWFkeSwgc3Bhd24gYQ0KPiArCSAqIHRocmVhZCB3aGljaCB3aWxsIHdhaXQgZm9y IHhlbnN0b3JlZCBvciBhIHhlbnN0b3JlLXN0dWJkb20gdG8gYmUNCj4gKwkgKiBzdGFydGVk LCB0aGVuIHByb2JlLiAgSXQgd2lsbCBiZSB0cmlnZ2VyZWQgd2hlbiBjb21tdW5pY2F0aW9u DQo+ICsJICogc3RhcnRzIGhhcHBlbmluZywgYnkgd2FpdGluZyBvbiB4Yl93YWl0cS4NCj4g ICAJICovDQo+IC0JaWYgKHhlbl9zdG9yZV9kb21haW5fdHlwZSA9PSBYU19MT0NBTCkgew0K PiArCWlmICh4ZW5fc3RvcmVfZG9tYWluX3R5cGUgPT0gWFNfTE9DQUwgfHwgeGVuX3N0b3Jl X2ludGVyZmFjZSA9PSBOVUxMKSB7DQo+ICAgCQlzdHJ1Y3QgdGFza19zdHJ1Y3QgKnByb2Jl X3Rhc2s7DQo+ICAgDQo+ICAgCQlwcm9iZV90YXNrID0ga3RocmVhZF9ydW4oeGVuYnVzX3By b2JlX3RocmVhZCwgTlVMTCwNCj4gQEAgLTkwNywxMCArOTIxLDI1IEBAIHN0YXRpYyBzdHJ1 Y3Qgbm90aWZpZXJfYmxvY2sgeGVuYnVzX3Jlc3VtZV9uYiA9IHsNCj4gICAJLm5vdGlmaWVy X2NhbGwgPSB4ZW5idXNfcmVzdW1lX2NiLA0KPiAgIH07DQo+ICAgDQo+ICtzdGF0aWMgaXJx cmV0dXJuX3QgeGVuYnVzX2xhdGVfaW5pdChpbnQgaXJxLCB2b2lkICp1bnVzZWQpDQo+ICt7 DQo+ICsJaW50IGVyciA9IDA7DQo+ICsJdWludDY0X3QgdiA9IDA7DQo+ICsNCj4gKwllcnIg PSBodm1fZ2V0X3BhcmFtZXRlcihIVk1fUEFSQU1fU1RPUkVfUEZOLCAmdik7DQo+ICsJaWYg KGVyciB8fCAhdiB8fCAhfnYpDQo+ICsJCXJldHVybiBJUlFfSEFORExFRDsNCj4gKwl4ZW5f c3RvcmVfZ2ZuID0gKHVuc2lnbmVkIGxvbmcpdjsNCj4gKw0KPiArCXdha2VfdXAoJnhiX3dh aXRxKTsNCj4gKwlyZXR1cm4gSVJRX0hBTkRMRUQ7DQo+ICt9DQo+ICsNCj4gICBzdGF0aWMg aW50IF9faW5pdCB4ZW5idXNfaW5pdCh2b2lkKQ0KPiAgIHsNCj4gICAJaW50IGVycjsNCj4g ICAJdWludDY0X3QgdiA9IDA7DQo+ICsJYm9vbCB3YWl0ID0gZmFsc2U7DQo+ICAgCXhlbl9z dG9yZV9kb21haW5fdHlwZSA9IFhTX1VOS05PV047DQo+ICAgDQo+ICAgCWlmICgheGVuX2Rv bWFpbigpKQ0KPiBAQCAtOTU5LDIzICs5ODgsNDIgQEAgc3RhdGljIGludCBfX2luaXQgeGVu YnVzX2luaXQodm9pZCkNCj4gICAJCSAqDQo+ICAgCQkgKiBBbHNvIHJlY29nbml6ZSBhbGwg Yml0cyBzZXQgYXMgYW4gaW52YWxpZCB2YWx1ZS4NCj4gICAJCSAqLw0KPiAtCQlpZiAoIXYg fHwgIX52KSB7DQo+ICsJCWlmICghdikgew0KPiAgIAkJCWVyciA9IC1FTk9FTlQ7DQo+ICAg CQkJZ290byBvdXRfZXJyb3I7DQo+ICAgCQl9DQo+IC0JCS8qIEF2b2lkIHRydW5jYXRpb24g b24gMzItYml0LiAqLw0KPiArCQlpZiAodiA9PSB+MFVMTCkgew0KPiArCQkJd2FpdCA9IHRy dWU7DQo+ICsJCX0gZWxzZSB7DQo+ICsJCQkvKiBBdm9pZCB0cnVuY2F0aW9uIG9uIDMyLWJp dC4gKi8NCj4gICAjaWYgQklUU19QRVJfTE9ORyA9PSAzMg0KPiAtCQlpZiAodiA+IFVMT05H X01BWCkgew0KPiAtCQkJcHJfZXJyKCIlczogY2Fubm90IGhhbmRsZSBIVk1fUEFSQU1fU1RP UkVfUEZOPSVsbHggPiBVTE9OR19NQVhcbiIsDQo+IC0JCQkgICAgICAgX19mdW5jX18sIHYp Ow0KPiAtCQkJZXJyID0gLUVJTlZBTDsNCj4gLQkJCWdvdG8gb3V0X2Vycm9yOw0KPiAtCQl9 DQo+ICsJCQlpZiAodiA+IFVMT05HX01BWCkgew0KPiArCQkJCXByX2VycigiJXM6IGNhbm5v dCBoYW5kbGUgSFZNX1BBUkFNX1NUT1JFX1BGTj0lbGx4ID4gVUxPTkdfTUFYXG4iLA0KPiAr CQkJCQkJX19mdW5jX18sIHYpOw0KPiArCQkJCWVyciA9IC1FSU5WQUw7DQo+ICsJCQkJZ290 byBvdXRfZXJyb3I7DQo+ICsJCQl9DQo+ICAgI2VuZGlmDQo+IC0JCXhlbl9zdG9yZV9nZm4g PSAodW5zaWduZWQgbG9uZyl2Ow0KPiAtCQl4ZW5fc3RvcmVfaW50ZXJmYWNlID0NCj4gLQkJ CXhlbl9yZW1hcCh4ZW5fc3RvcmVfZ2ZuIDw8IFhFTl9QQUdFX1NISUZULA0KPiAtCQkJCSAg WEVOX1BBR0VfU0laRSk7DQo+ICsJCQl4ZW5fc3RvcmVfZ2ZuID0gKHVuc2lnbmVkIGxvbmcp djsNCj4gKwkJCXhlbl9zdG9yZV9pbnRlcmZhY2UgPQ0KPiArCQkJCXhlbl9yZW1hcCh4ZW5f c3RvcmVfZ2ZuIDw8IFhFTl9QQUdFX1NISUZULA0KPiArCQkJCQkgIFhFTl9QQUdFX1NJWkUp Ow0KPiArCQkJaWYgKHhlbl9zdG9yZV9pbnRlcmZhY2UtPmNvbm5lY3Rpb24gIT0gMCkNCg0K UGxlYXNlIHVzZSBYRU5TVE9SRV9DT05ORUNURUQgaW5zdGVhZCBvZiAwLg0KDQo+ICsJCQkJ d2FpdCA9IHRydWU7DQo+ICsJCX0NCj4gKwkJaWYgKHdhaXQpIHsNCj4gKwkJCWVyciA9IGJp bmRfZXZ0Y2huX3RvX2lycWhhbmRsZXIoeGVuX3N0b3JlX2V2dGNobiwNCj4gKwkJCQkJCQl4 ZW5idXNfbGF0ZV9pbml0LA0KPiArCQkJCQkJCTAsICJ4ZW5zdG9yZV9sYXRlX2luaXQiLA0K PiArCQkJCQkJCSZ4Yl93YWl0cSk7DQo+ICsJCQlpZiAoZXJyIDwgMCkgew0KPiArCQkJCXBy X2VycigieGVuc3RvcmVfbGF0ZV9pbml0IGNvdWxkbid0IGJpbmQgaXJxIGVycj0lZFxuIiwN Cj4gKwkJCQkgICAgICAgZXJyKTsNCj4gKwkJCQlyZXR1cm4gZXJyOw0KPiArCQkJfQ0KPiAr DQo+ICsJCQl4c19pbml0X2lycSA9IGVycjsNCj4gKwkJfQ0KPiAgIAkJYnJlYWs7DQo+ICAg CWRlZmF1bHQ6DQo+ICAgCQlwcl93YXJuKCJYZW5zdG9yZSBzdGF0ZSB1bmtub3duXG4iKTsN Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJlLmggYi9p bmNsdWRlL3hlbi9pbnRlcmZhY2UvaW8veHNfd2lyZS5oDQo+IGluZGV4IGQ0MGE0NGYwOWIx Ni4uY2Q3YWU1ZWJiMTMzIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL3hlbi9pbnRlcmZhY2Uv aW8veHNfd2lyZS5oDQo+ICsrKyBiL2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJl LmgNCj4gQEAgLTg3LDYgKzg3LDkgQEAgc3RydWN0IHhlbnN0b3JlX2RvbWFpbl9pbnRlcmZh Y2Ugew0KPiAgICAgICBjaGFyIHJzcFtYRU5TVE9SRV9SSU5HX1NJWkVdOyAvKiBSZXBsaWVz IGFuZCBhc3luYyB3YXRjaCBldmVudHMuICovDQo+ICAgICAgIFhFTlNUT1JFX1JJTkdfSURY IHJlcV9jb25zLCByZXFfcHJvZDsNCj4gICAgICAgWEVOU1RPUkVfUklOR19JRFggcnNwX2Nv bnMsIHJzcF9wcm9kOw0KPiArICAgIHVpbnQzMl90IHNlcnZlcl9mZWF0dXJlczsgLyogQml0 bWFwIG9mIGZlYXR1cmVzIHN1cHBvcnRlZCBieSB0aGUgc2VydmVyICovDQo+ICsgICAgdWlu dDMyX3QgY29ubmVjdGlvbjsNCj4gKyAgICB1aW50MzJfdCBlcnJvcjsNCj4gICB9Ow0KPiAg IA0KPiAgIC8qIFZpb2xhdGluZyB0aGlzIGlzIHZlcnkgYmFkLiAgU2VlIGRvY3MvbWlzYy94 ZW5zdG9yZS50eHQuICovDQoNClBsZWFzZSBkbyBhIGZ1bGwgc3luYyBvZiB0aGUgaGVhZGVy LiBUaGlzIHdpbGwgZW5hYmxlIHlvdSB0byB1c2UgdGhlDQpjb3JyZWN0IGRlZmluZXMgaW5z dGVhZCBvZiBoYXJkIGNvZGVkIG51bWJlcnMuDQoNCg0KSnVlcmdlbg0K --------------0vfJqR4uSHEDFMKJmzfhaxCT Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0vfJqR4uSHEDFMKJmzfhaxCT-- --------------6QOLHIRXfG8NUChGSFKOSJ3r-- --------------KKMgEyxhl0Ks9DBYP9SIik2C Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJw7PgFAwAAAAAACgkQsN6d1ii/Ey/I FQf+Ofh9//fmY/lB2Rl76DQ+jLev9a90uF1digFUBPetL+tS+8SaEI0CPkZptEmHRsUTt8l75RnI LE4UZ/GFK0mcVHF1AXylJjcp7mOwZuwPbjnig8jxvgkzbYMFcs51Y+j+oDYuTGFflDVN0ivheV37 gfzTphAKkRlenxaCY4oqeifQ1wAgzgYa1NQtwUqnXCpUHezdzbhWUlc0D23tt9X7ZZBKsOxdURZd 14kYTkRdNXFKoUMx8UUBayPIKxWUAoG1T3W5PJj9XBskFf1gnesTEEX380PvgikUlsZT5xkM6t0x uv9s6r0T8B7KzhA9H/1Xm8m+osHWTETRkH8VotbDgA== =uJJ1 -----END PGP SIGNATURE----- --------------KKMgEyxhl0Ks9DBYP9SIik2C-- From xen-devel-bounces@lists.xenproject.org Tue May 03 08:51:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:51:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319313.539508 (Exim 4.92) (envelope-from ) id 1nloG6-0007d5-Mi; Tue, 03 May 2022 08:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319313.539508; Tue, 03 May 2022 08:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloG6-0007cy-JW; Tue, 03 May 2022 08:51:50 +0000 Received: by outflank-mailman (input) for mailman id 319313; Tue, 03 May 2022 08:51:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloG4-0007aJ-Nc for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:51:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4421949f-cabe-11ec-a406-831a346695d4; Tue, 03 May 2022 10:51:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FC961F74A; Tue, 3 May 2022 08:51:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5363F13ABE; Tue, 3 May 2022 08:51:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vVPIEiPtcGJmRQAAMHmgww (envelope-from ); Tue, 03 May 2022 08:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4421949f-cabe-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651567907; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5DuNjEqYNOcxKieN8yThqpywf6NZlx1pIXkxbIrQ6YI=; b=vWKhlEObLLZMRIcC5KvQjARxfWMJqicuOCNtRBB5kZ92fEjnXeuRRiTsi2cEb37cZDNkKs QXFv7arA8jRXR7E/x0hGWTf+AIw1oNAA8eFdQbVpmjdM/FNXErbSlmnFXBx453Rr4UfGYO 8WFEA6TvtKuhLpWtB/Wpj/qMwlcMt1Y= Message-ID: Date: Tue, 3 May 2022 10:51:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v5 5/7] xenstored: send an evtchn notification on introduce_domain Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini References: <20220429205732.2030094-5-sstabellini@kernel.org> From: Juergen Gross In-Reply-To: <20220429205732.2030094-5-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------p0e4CkB8aMlo8308yjURNBz8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------p0e4CkB8aMlo8308yjURNBz8 Content-Type: multipart/mixed; boundary="------------Dz0Ol03438vtcDYvRUzsLIIu"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini Message-ID: Subject: Re: [PATCH v5 5/7] xenstored: send an evtchn notification on introduce_domain References: <20220429205732.2030094-5-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-5-sstabellini@kernel.org> --------------Dz0Ol03438vtcDYvRUzsLIIu Content-Type: multipart/mixed; boundary="------------YDM17gSiqSw5OmiIpVZjfFfl" --------------YDM17gSiqSw5OmiIpVZjfFfl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMjI6NTcsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBXaGVuIHhzX2ludHJv ZHVjZV9kb21haW4gaXMgY2FsbGVkLCBzZW5kIG91dCBhIG5vdGlmaWNhdGlvbiBvbiB0aGUN Cj4geGVuc3RvcmUgZXZlbnQgY2hhbm5lbCBzbyB0aGF0IGFueSAoZG9tMGxlc3MpIGRvbWFp biB3YWl0aW5nIGZvciB0aGUNCj4geGVuc3RvcmUgaW50ZXJmYWNlIHRvIGJlIHJlYWR5IGNh biBjb250aW51ZSB3aXRoIHRoZSBpbml0aWFsaXphdGlvbi4NCj4gQmVmb3JlIHNlbmRpbmcg dGhlIG5vdGlmaWNhdGlvbiwgY2xlYXIgWFNfQ09OTkVDVElPTl9TVEFURV9SRUNPTk5FQ1RJ TkcuDQo+IA0KPiBUaGUgZXh0cmEgbm90aWZpY2F0aW9uIGlzIGhhcm1sZXNzIGZvciBkb21h aW5zIHRoYXQgZG9uJ3QgcmVxdWlyZSBpdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2Eg TWljY2lvIDxsdWNtaWNjaW9AZ21haWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW5v IFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiBDQzogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiBDQzogSnVsaWVuIEdyYWxsIDxqdWxp ZW5AeGVuLm9yZz4NCj4gLS0tDQo+IEkgZHJvcHBlZCB0aGUgUmV2aWV3ZWQtYnkgdGFncyBk dWUgdG8gdGhlIGNvbm5lY3QgPSAwIGNoYW5nZS4gSnVsaWVuDQo+IGFsc28gc3VnZ2VzdGVk IGl0IHdvdWxkIGJlIGEgZ29vZCBpZGVhIHRvIGFkZCBhIGNsYXJpZmljYXRpb24gc3RhdGVt ZW50DQo+IGFib3V0IHRoZSB1c2FnZSBvZiBYU19DT05ORUNUSU9OX1NUQVRFX1JFQ09OTkVD VElORyBpbiB0aGUgaGVhZGVyIGZpbGVzDQo+IGJ1dCBJIHdhc24ndCBzdXJlIHdoYXQgdG8g d3JpdGUuIFBsZWFzZSBhZHZpc2UgYW5kIEkgYW0gaGFwcHkgdG8gaW5jbHVkZQ0KPiBhIHN0 YXRlbWVudCBpbiB0aGUgbmV4dCB2ZXJzaW9uLg0KPiANCj4gQ2hhbmdlcyBpbiB2NToNCj4g LSByZXNldCBYU19DT05ORUNUSU9OX1NUQVRFX1JFQ09OTkVDVElORyBiZWZvcmUgbm90aWZ5 aW5nIHRoZSBkb21VDQo+IA0KPiBDaGFuZ2VzIGluIHYyOg0KPiAtIGRyb3AgdGhlIG5ldyBs YXRlX2luaXQgcGFyYW1ldGVyDQo+IC0tLQ0KPiAgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9kb21haW4uYyB8IDQgKysrKw0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KykNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWlu LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4gaW5kZXggYWUwNjVm Y2JlZS4uN2JiOGM2NGQzMyAxMDA2NDQNCj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5jDQo+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u Yw0KPiBAQCAtNDkzLDYgKzQ5MywxMCBAQCBzdGF0aWMgc3RydWN0IGRvbWFpbiAqaW50cm9k dWNlX2RvbWFpbihjb25zdCB2b2lkICpjdHgsDQo+ICAgCQkvKiBOb3cgZG9tYWluIGJlbG9u Z3MgdG8gaXRzIGNvbm5lY3Rpb24uICovDQo+ICAgCQl0YWxsb2Nfc3RlYWwoZG9tYWluLT5j b25uLCBkb21haW4pOw0KPiAgIA0KPiArCQkvKiBOb3RpZnkgdGhlIGRvbWFpbiB0aGF0IHhl bnN0b3JlIGlzIGF2YWlsYWJsZSAqLw0KPiArCQlpbnRlcmZhY2UtPmNvbm5lY3Rpb24gPSAw eDA7DQoNClBsZWFzZSB1c2UgWEVOU1RPUkVfQ09OTkVDVEVEIGluc3RlYWQgb2YgMHgwLg0K DQo+ICsJCXhlbmV2dGNobl9ub3RpZnkoeGNlX2hhbmRsZSwgZG9tYWluLT5wb3J0KTsNCj4g Kw0KPiAgIAkJaWYgKCFpc19tYXN0ZXJfZG9tYWluICYmICFyZXN0b3JlKQ0KPiAgIAkJCWZp cmVfd2F0Y2hlcyhOVUxMLCBjdHgsICJAaW50cm9kdWNlRG9tYWluIiwgTlVMTCwNCj4gICAJ CQkJICAgICBmYWxzZSwgTlVMTCk7DQoNCg0KSnVlcmdlbg0K --------------YDM17gSiqSw5OmiIpVZjfFfl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------YDM17gSiqSw5OmiIpVZjfFfl-- --------------Dz0Ol03438vtcDYvRUzsLIIu-- --------------p0e4CkB8aMlo8308yjURNBz8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJw7SIFAwAAAAAACgkQsN6d1ii/Ey// ewgAitrLF0iP3qpyiW93/xa3WaiXFgzEwPBhYc/bIE8I5mmKYv/vMJrclO0Y5IoWgDvM0h/hJ7jW az1gGW/b+vs7mhSziXkWBG30d64G6PKLpKF/mqvZy5XmSDKg00bdK9chJH5WXDekpglgW2KIth/z 85UVEL4w1K4dl2nvNFZaCK8Qlh+tQEk1AO/z3hwr+pvoHVRKMTCwdfp8FhTQ0+OvKAsMS1zepBL+ R1kzUe9Hl/HMl6MIdSnwD3zo4WlAI0VKKgYbtyVCp2R9AKVgEKsjtFTrrz1wI1X3Bn7C6zwHXDkN 3+bmR+qs6Z4IL+0j0Lr7khfJfMrDyoC/AHnRXGLyHw== =msF3 -----END PGP SIGNATURE----- --------------p0e4CkB8aMlo8308yjURNBz8-- From xen-devel-bounces@lists.xenproject.org Tue May 03 08:58:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 08:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319321.539519 (Exim 4.92) (envelope-from ) id 1nloMG-0008VG-CU; Tue, 03 May 2022 08:58:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319321.539519; Tue, 03 May 2022 08:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloMG-0008V9-9O; Tue, 03 May 2022 08:58:12 +0000 Received: by outflank-mailman (input) for mailman id 319321; Tue, 03 May 2022 08:58:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nloMF-0008V3-5D for xen-devel@lists.xenproject.org; Tue, 03 May 2022 08:58:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27df72fa-cabf-11ec-a406-831a346695d4; Tue, 03 May 2022 10:58:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 94CEF1F38D; Tue, 3 May 2022 08:58:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E61C13ABE; Tue, 3 May 2022 08:58:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p4aYEaHucGJaSAAAMHmgww (envelope-from ); Tue, 03 May 2022 08:58:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27df72fa-cabf-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651568289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pms4NLoa+VhejEh/GWnjQtvYkBrQbHtl9W5yYSnPyuY=; b=cRytpMS1X0tknz8abz6OUs0MR5humzk29gZ/aSJGjlWCO19juK6EQ/u66rChjCc5nYKTzm jV5s8+2ptetqS1erxOCkBPKSJZoBLkoSjlNt3bHSfDiAWa1ULHfUUSGqI0O/ErwlNXovvT vSkOi5oaDkPnHLHr18tcnK0TsABy4UA= Message-ID: Date: Tue, 3 May 2022 10:58:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20220429205732.2030094-6-sstabellini@kernel.org> From: Juergen Gross Subject: Re: [PATCH v5 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <20220429205732.2030094-6-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GXrf8Z20VOIZcmHuPYY0goEK" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GXrf8Z20VOIZcmHuPYY0goEK Content-Type: multipart/mixed; boundary="------------GFpv0qZhMjXTwAqdB1FbVqyq"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v5 6/7] tools: add example application to initialize dom0less PV drivers References: <20220429205732.2030094-6-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-6-sstabellini@kernel.org> --------------GFpv0qZhMjXTwAqdB1FbVqyq Content-Type: multipart/mixed; boundary="------------ZLe02UiBoIzOFzyhsiph6hYs" --------------ZLe02UiBoIzOFzyhsiph6hYs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjkuMDQuMjIgMjI6NTcsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBBZGQgYW4gZXhhbXBs ZSBhcHBsaWNhdGlvbiB0aGF0IGNhbiBiZSBydW4gaW4gZG9tMCB0byBjb21wbGV0ZSB0aGUN Cj4gZG9tMGxlc3MgZG9tYWlucyBpbml0aWFsaXphdGlvbiBzbyB0aGF0IHRoZXkgY2FuIGdl dCBhY2Nlc3MgdG8geGVuc3RvcmUNCj4gYW5kIHVzZSBQViBkcml2ZXJzLg0KPiANCj4gVGhl IGFwcGxpY2F0aW9uIHNldHMgWFNfQ09OTkVDVElPTl9TVEFURV9SRUNPTk5FQ1RJTkcgb24g dGhlIHhlbnN0b3JlDQo+IHBhZ2UgYmVmb3JlIGNhbGxpbmcgeHNfaW50cm9kdWNlX2RvbWFp biB0byBzaWduYWwgdGhhdCB0aGUgY29ubmVjdGlvbiBpcw0KPiBub3QgcmVhZHkgeWV0IHRv IGJlIHVzZWQuIFhTX0NPTk5FQ1RJT05fU1RBVEVfUkVDT05ORUNUSU5HIGlzIHJlc2V0IHNv b24NCj4gYWZ0ZXIgYnkgeGVuc3RvcmVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVjYSBN aWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8g U3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQo+IENDOiBXZWkg TGl1IDx3bEB4ZW4ub3JnPg0KPiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJk QGNpdHJpeC5jb20+DQo+IENDOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+ IC0tLQ0KPiBDaGFuZ2VzIGluIHY1Og0KPiAtIHNldCBYU19DT05ORUNUSU9OX1NUQVRFX1JF Q09OTkVDVElORyBiZWZvcmUgeHNfaW50cm9kdWNlX2RvbWFpbg0KPiANCj4gQ2hhbmdlcyBp biB2NDoNCj4gLSBvbmx5IGFsbG9jIHhzIHBhZ2UgKG5vIG90aGVyIG1hZ2ljIHBhZ2VzKQ0K PiAtIGFkZCB4ZW5zdG9yZSBwZXJtaXNzaW9ucw0KPiAtIGNoZWNrIGFsbCByZXR1cm4gdmFs dWVzDQo+IC0gcmVuYW1lIHJlc3RvcmVfeGVuc3RvcmUgdG8gY3JlYXRlX3hlbnN0b3JlDQo+ IC0gc2V0IHRhcmdldF9tZW1rYg0KPiAtIHNldCBzdGFydF90aW1lIHByb3Blcmx5DQo+IC0g Y2xvc2UgeHMgdHJhbnNhY3Rpb24gb24gZXJyb3INCj4gLSBjYWxsIHhjX2RvbV9nbnR0YWJf c2VlZCBpbnN0ZWFkIG9mIHhjX2RvbV9nbnR0YWJfaW5pdA0KPiAtIHhzX29wZW4gaW5zdGVh ZCBvZiB4c19kYWVtb25fb3Blbg0KPiANCj4gQ2hhbmdlcyBpbiB2MzoNCj4gLSBoYW5kbGUg eGVuc3RvcmUgZXJyb3JzDQo+IC0gYWRkIGFuIGluLWNvZGUgY29tbWVudCBhYm91dCB4ZW5z dG9yZSBlbnRyaWVzDQo+IC0gbGVzcyB2ZXJib3NlIG91dHB1dA0KPiAtIGNsZWFuLXVwIGVy cm9yIHBhdGggaW4gbWFpbg0KPiANCj4gQ2hhbmdlcyBpbiB2MjoNCj4gLSBkbyBub3Qgc2V0 IEhWTV9QQVJBTV9TVE9SRV9FVlRDSE4gdHdpY2UNCj4gLSByZW5hbWUgcmVzdG9yZV94ZW5z dG9yZSB0byBjcmVhdGVfeGVuc3RvcmUNCj4gLSBpbmNyZWFzZSBtYXhtZW0NCj4gDQo+IGNv bm5lY3Rpb24gcmVjb25uZWN0aW5nDQo+IC0tLQ0KPiAgIHRvb2xzL2hlbHBlcnMvTWFrZWZp bGUgICAgICAgIHwgIDEzICsrDQo+ICAgdG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMg fCAzNDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiAgIDIgZmlsZXMg Y2hhbmdlZCwgMzU0IGluc2VydGlvbnMoKykNCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgdG9v bHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9o ZWxwZXJzL01ha2VmaWxlIGIvdG9vbHMvaGVscGVycy9NYWtlZmlsZQ0KPiBpbmRleCA3ZjZj NDIyNDQwLi44ZDc4YWIxZTkwIDEwMDY0NA0KPiAtLS0gYS90b29scy9oZWxwZXJzL01ha2Vm aWxlDQo+ICsrKyBiL3Rvb2xzL2hlbHBlcnMvTWFrZWZpbGUNCj4gQEAgLTEwLDYgKzEwLDkg QEAgaWZlcSAoJChDT05GSUdfTGludXgpLHkpDQo+ICAgaWZlcSAoJChDT05GSUdfWDg2KSx5 KQ0KPiAgIFBST0dTICs9IGluaXQteGVuc3RvcmUtZG9tYWluDQo+ICAgZW5kaWYNCj4gK2lm ZXEgKCQoQ09ORklHX0FSTSkseSkNCj4gK1BST0dTICs9IGluaXQtZG9tMGxlc3MNCj4gK2Vu ZGlmDQo+ICAgZW5kaWYNCj4gICANCj4gICBYRU5fSU5JVF9ET00wX09CSlMgPSB4ZW4taW5p dC1kb20wLm8gaW5pdC1kb20tanNvbi5vDQo+IEBAIC0yNiw2ICsyOSwxMyBAQCAkKElOSVRf WEVOU1RPUkVfRE9NQUlOX09CSlMpOiBDRkxBR1MgKz0gJChDRkxBR1NfbGlieGVuc3RvcmUp DQo+ICAgJChJTklUX1hFTlNUT1JFX0RPTUFJTl9PQkpTKTogQ0ZMQUdTICs9ICQoQ0ZMQUdT X2xpYnhlbmxpZ2h0KQ0KPiAgICQoSU5JVF9YRU5TVE9SRV9ET01BSU5fT0JKUyk6IENGTEFH UyArPSAtaW5jbHVkZSAkKFhFTl9ST09UKS90b29scy9jb25maWcuaA0KPiAgIA0KPiArSU5J VF9ET00wTEVTU19PQkpTID0gaW5pdC1kb20wbGVzcy5vIGluaXQtZG9tLWpzb24ubw0KPiAr JChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1MgKz0gJChDRkxBR1NfbGlieGVudG9vbGxv ZykNCj4gKyQoSU5JVF9ET00wTEVTU19PQkpTKTogQ0ZMQUdTICs9ICQoQ0ZMQUdTX2xpYnhl bnN0b3JlKQ0KPiArJChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1MgKz0gJChDRkxBR1Nf bGlieGVubGlnaHQpDQo+ICskKElOSVRfRE9NMExFU1NfT0JKUyk6IENGTEFHUyArPSAkKENG TEFHU19saWJ4ZW5jdHJsKQ0KPiArJChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1MgKz0g JChDRkxBR1NfbGlieGVuZXZ0Y2huKQ0KPiArDQo+ICAgLlBIT05ZOiBhbGwNCj4gICBhbGw6 ICQoUFJPR1MpDQo+ICAgDQo+IEBAIC0zNSw2ICs0NSw5IEBAIHhlbi1pbml0LWRvbTA6ICQo WEVOX0lOSVRfRE9NMF9PQkpTKQ0KPiAgIGluaXQteGVuc3RvcmUtZG9tYWluOiAkKElOSVRf WEVOU1RPUkVfRE9NQUlOX09CSlMpDQo+ICAgCSQoQ0MpICQoTERGTEFHUykgLW8gJEAgJChJ TklUX1hFTlNUT1JFX0RPTUFJTl9PQkpTKSAkKExETElCU19saWJ4ZW50b29sbG9nKSAkKExE TElCU19saWJ4ZW5zdG9yZSkgJChMRExJQlNfbGlieGVuY3RybCkgJChMRExJQlNfbGlieGVu Z3Vlc3QpICQoTERMSUJTX2xpYnhlbmxpZ2h0KSAkKEFQUEVORF9MREZMQUdTKQ0KPiAgIA0K PiAraW5pdC1kb20wbGVzczogJChJTklUX0RPTTBMRVNTX09CSlMpDQo+ICsJJChDQykgJChM REZMQUdTKSAtbyAkQCAkKElOSVRfRE9NMExFU1NfT0JKUykgJChMRExJQlNfbGlieGVuY3Ry bCkgJChMRExJQlNfbGlieGVuZXZ0Y2huKSAkKExETElCU19saWJ4ZW50b29sbG9nKSAkKExE TElCU19saWJ4ZW5zdG9yZSkgJChMRExJQlNfbGlieGVubGlnaHQpICQoTERMSUJTX2xpYnhl bmd1ZXN0KSAkKExETElCU19saWJ4ZW5mb3JlaWdubWVtb3J5KSAkKEFQUEVORF9MREZMQUdT KQ0KPiArDQo+ICAgLlBIT05ZOiBpbnN0YWxsDQo+ICAgaW5zdGFsbDogYWxsDQo+ICAgCSQo SU5TVEFMTF9ESVIpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KPiBkaWZmIC0tZ2l0IGEv dG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMgYi90b29scy9oZWxwZXJzL2luaXQtZG9t MGxlc3MuYw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi5h OTkzOThlOTI4DQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIvdG9vbHMvaGVscGVycy9pbml0 LWRvbTBsZXNzLmMNCj4gQEAgLTAsMCArMSwzNDEgQEANCj4gKyNpbmNsdWRlIDxzdGRib29s Lmg+DQo+ICsjaW5jbHVkZSA8c3lzbG9nLmg+DQo+ICsjaW5jbHVkZSA8c3RkaW8uaD4NCj4g KyNpbmNsdWRlIDxlcnIuaD4NCj4gKyNpbmNsdWRlIDxzdGRsaWIuaD4NCj4gKyNpbmNsdWRl IDxzeXMvdGltZS5oPg0KPiArI2luY2x1ZGUgPHhlbnN0b3JlLmg+DQo+ICsjaW5jbHVkZSA8 eGVuY3RybC5oPg0KPiArI2luY2x1ZGUgPHhlbmd1ZXN0Lmg+DQo+ICsjaW5jbHVkZSA8bGli eGwuaD4NCj4gKyNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4NCj4gKyNpbmNsdWRlIDx4ZW5mb3Jl aWdubWVtb3J5Lmg+DQo+ICsNCj4gKyNpbmNsdWRlICJpbml0LWRvbS1qc29uLmgiDQo+ICsN Cj4gKyNkZWZpbmUgWFNfQ09OTkVDVElPTl9TVEFURV9PRkZTRVQgICAgICAgKDIwNjgvNCkN Cj4gKyNkZWZpbmUgWFNfQ09OTkVDVElPTl9TVEFURV9SRUNPTk5FQ1RJTkcgMHgxDQoNCldo eSBkb24ndCB5b3UgdXNlIHRoZSB4c193aXJlLmggaGVhZGVyIGluc3RlYWQ/DQoNCg0KSnVl cmdlbg0K --------------ZLe02UiBoIzOFzyhsiph6hYs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZLe02UiBoIzOFzyhsiph6hYs-- --------------GFpv0qZhMjXTwAqdB1FbVqyq-- --------------GXrf8Z20VOIZcmHuPYY0goEK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJw7qAFAwAAAAAACgkQsN6d1ii/Ey9X cAf9EQkk3pdYoMMuQ3eLToN3hOvBbnoL15xXGvvdF2teCwzPowZd8YpixgOT3iHBrfi4ttih/3SW g+GTWiG1W7JuCmnNXVJGkQCrt+DjfX+WE1+C0g4jbI+6UbL3vD7CsyybwFf+Y3+qHgghucVI3VGf win5dF1g+3IiF3mjA2ctmyj4TXkavUTsIi4xv4KgoL7c0KgiILbh7Y3fDaPhYt27ZkZneS635K43 /bKlrBXFCeXNIRB2TjwQXATnDgyCMBpNzOOr4sZCEVI6q0N3ydqAnyRtzRz9B90ME2K5EPaZ+riw M568Gq9uYdW34S0DefzcTX/HhQy20vTy0qpt8IoWsg== =xefG -----END PGP SIGNATURE----- --------------GXrf8Z20VOIZcmHuPYY0goEK-- From xen-devel-bounces@lists.xenproject.org Tue May 03 09:15:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319329.539536 (Exim 4.92) (envelope-from ) id 1nlocr-0002il-V4; Tue, 03 May 2022 09:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319329.539536; Tue, 03 May 2022 09:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlocr-0002ie-Rl; Tue, 03 May 2022 09:15:21 +0000 Received: by outflank-mailman (input) for mailman id 319329; Tue, 03 May 2022 09:15:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlocq-0002iY-Gz for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:15:20 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8bcb3625-cac1-11ec-a406-831a346695d4; Tue, 03 May 2022 11:15:18 +0200 (CEST) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 05:15:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO2PR03MB2408.namprd03.prod.outlook.com (2603:10b6:102:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Tue, 3 May 2022 09:15:12 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 09:15:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bcb3625-cac1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651569318; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=RxYtBFuVdI9iiBeYUXijMWz3ziAJd0J2gaMlQP0zwUE=; b=KwIScIy3dzeYqz2oRshM8Kbp5PgmHr84FYUHGUcUWiXmtUNtwngjQ22c 5GYZf6KwMNvZANiGFSsppUN1l55gpAimfB7Pad4LV8aDGgg/rtkhRk5il cSikzX30mxuiWywaBdhSDfrWw1lcj6xoLfapnoM1DC4msoRuEoumpmZQ1 g=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 70326970 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GVGaAqLrWQJyV2bQFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENS1GFVz mAcUG7QPPmCZGHxco9+bNyw9EJXv5HVzdE3TQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Yz2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 NZpm62aUhxqBfLVx9wRDT1/GnxQAoQTrdcrIVDn2SCS52vvViK2ht9IXAQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM2FGvubjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGkKWMJ9wr9Sawf+EyM0VF+wKHREvnRUMWNS/10s2Dfq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCn1m71mEVThoMWjOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPJVGuw+rQuLmqzd5l/DAnBeF2AQLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:b9RhAKjvNb8asZZZdZiYohsgwHBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeSWCQfkNIN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp D52+pT5fVzp/QtHNNA7dc6MLWK41P2MGLx2UKpUCLa/fI8SjvwQ6Ce2sRG2MiaPLo18bAVpL PtFHtliE9aQTOaNSTJ5uwHzizw X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70326970" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BsM0wsywgqOgJIuc+wsrDUuzO2UhoEPG4TEX9s5kk5nm+6KpOSIFOqdpmjDv+fJmgX8+CJ6jdcQ9dC1Jm8ZBsFee9dBcVq7mXOqcv+yL3GuLORiDjt8vz5UijW018NR5SxIX5vvTBCieShUQRdMRVu9oCRubL1kVDIRBdLGps4n77GNzYAETdvYE0xAMQR5qiao1JhgI8zqzxeBBncDwUYhJZ24ooOXVeLoD4gYA2M5vhhRC9EU3Aufzqng/9saakxpTxk539xWVICXaeJxE/qfTV5p6+T0CoviKpjrje9qVsqPs07coCqUdqbbR/jkOE/plgz4XGYaqaXMX77SWMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EU3lfkaVuRNiVoZVgnR/BzYCqQvkfqCtqROFVEbSrUQ=; b=KZsn2pUiH3607hp7oEYDaBUFF5/7NOtvDAl/kPjh1IF0edj8qyR+IFcsiLFCHx4kvu6F6gK0J8FX2n4AbSLIxSMC60pwEvPRe4SI5yogJeKv3n3jgHGj90eDU9wnSMCDfwErURRjn76obeur3Nj9R9DO8VpNeuSCKAkPtsyewW1yYrPC8e+1DFj/4lP35tna1e0alJIOibbKnp6VVvBDP/VOVRvFDiMU9Zyw8qKQ2cXRUoj1dnDnX2c+7BfblvFklCVpfFY23L97/ETcS9i9Oc/S9H4XiYBMaKkgxsuKWB2fAS2sT15xi06KQa3F5cVppQNAx5iy0SZHe8uT9S9sjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EU3lfkaVuRNiVoZVgnR/BzYCqQvkfqCtqROFVEbSrUQ=; b=NkAo4ihnJR67wr1Z5c/i1SGRd9abn4Gi15LpIHYyK996bVdOp9X59V6A+1chZukAxkvYXOdBVity4EzAp45RTttROm+83zMFVNrTb2mdqbhFp/S82CD1Kcg+8FlQQJigavhoY1dhnuszHUQIEAk/1rYidhZciR9bixZBP4pg1L0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 11:15:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH RFC] x86/lld: fix symbol map generation Message-ID: References: <20220502152020.19768-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0074.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e38ba403-1af7-45aa-efd5-08da2ce56d28 X-MS-TrafficTypeDiagnostic: CO2PR03MB2408:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x/BgmoWWb1oURRY0u9afxdzdi4jD2MyaEEPjgzZzvqwXWJy5H0jNc+OWtlJa+15gtK3CCncC1gdo8s3W/WhvjEXQOmsIuOT1KQeh61+or7e2VBImuHDgXAs8WffNCS/2/FDwwgHXdlZeUhQd1Zth+XC91SkWUaTonwIi27FMAFVWP1mkCfuGKKDzOOGQ6Ivpiq+hAJzMyK/6QwGZ+Q14ewoAkCMpcYvhefU3FBI5kQd3pSjXZ8/vEjrGZ0WVttpVZLQ/MYLZcie4t/FjYzhSPg8Yz4O2zrS6o2jpgLTYOJ/j2JpeBpTS+XT9Nd3n+e72u+LOoUplXnITHTN1hRlyTQC8eMljkEIL4rKAqgtd8iuFx6UWDVakY8DxUmtnBKQ29DWgIWZ7JOPhA5Sdsho69rYPavruxL4HY07g4fPnZ9dtK60ESqEd2JOpiDg9FGscac1R2R/cBPy6orkMAXY8eslxUTRnKS3RKOV1KzDdXN9tqwWIk4TXEa2ZEoZnCA1FgYUkcDsG+T8dwCOJZuXfuhsKum6tDOOCOol0EC15Tjj6L+PkrgdeOEQg2KJXddEQgwB2iafa9albrPGbGJDVLf2wifiRmKSQgXiTAT66mvzSq3bBluo0/ex/nkBZugA+wx3dwdd40ZbSSE2mUAkGYs84ZgeWtVcBNFBBOYYoHT6wODvF7FbQoaZE7D7vlaH8dGkBUhOchQwVrTrdGtrT4ZR+dUvOb3aVQZOcz7gVPoY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(316002)(966005)(83380400001)(6916009)(5660300002)(85182001)(8936002)(2906002)(33716001)(86362001)(53546011)(82960400001)(66946007)(508600001)(186003)(6486002)(66556008)(38100700002)(66476007)(8676002)(26005)(6506007)(4326008)(9686003)(6666004)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V080QjBONk1hU1ViRUJLWmI1NXdYVlh0UUEwZnJtZ3graXhPbXFWOFN6Z0tU?= =?utf-8?B?a1NwQ3ZNakZzTW5Fekd3Yk8vZDZpa3NTSTJnSVlQdjd1dklaZlJEQnlpWXJR?= =?utf-8?B?NXJwenQ4UXo1UmwwM2FDdlFaNEZINVVoeE9OeHVlb3ZwZWVtVHhGTFFwOEN2?= =?utf-8?B?dWE0aXEzTTg2UndpVFNURE5yRERpOGVQZ2tjYUFja1lBbC9xOGtLYkF0OEI4?= =?utf-8?B?Sk4rbDNZYU1ZSGl5OGlaaHVmbnVIQVZ5OVhWU0FOODFjVXpjRWZkRjVuS1dV?= =?utf-8?B?OTU1R2tyWmw5SDhmV292a3l0UnlYTE1SeEh0TXBxRTJNbGZQN1laQlRZTWpH?= =?utf-8?B?T0xzVDNXeGtyT216Wk1RWUZPOU4ranJybXBialRJcEdXK2laVGdMMGNTRUdl?= =?utf-8?B?UmFDcHY0SkdPdGg0WnVqM1cwRytldGUvbzNOUFRkZHp2RmJ6OXFkYWNzK0FK?= =?utf-8?B?WTVpdHBqN3hlVzZweGxPcGFETTRkbDRqWFJGb2ROaDdncTNrTEdoT1VMQnlL?= =?utf-8?B?cTVhb1JCYjY1dUJYUFhtdGtXM3RLSHMvQWZBc1ZxVWY0NWdUdFBma25KbE1y?= =?utf-8?B?czFFTklnQks3RGROM2RlaURoN2g5VzdaTUJHRVdYc05NcXBpZFM3Q3BoVkxS?= =?utf-8?B?S25MWE5iOEJSZENwYktqQjVpdjNWYUUybGlocXA5MjRPc1RkY3VaV0dWc3NX?= =?utf-8?B?ZE5aN29FNXBhYjV6djBBa0w3bk55VmVUS3o4U2RYWmM4Mkx6MDBNYUhFS3hr?= =?utf-8?B?ZzJRVExCM1I1SE95dlFkQVFLV2NjL0dRWFluSWwrSS95L3Zia0c4Q0h4ckc3?= =?utf-8?B?UDFtQ2FwaFl2QUUxV2tOakJuaUpiZVhoZnNQVVFZcVRDMk12enBJMUVNQTB4?= =?utf-8?B?WW1oZnlDU2VadWVidkxmRG9sbWlydllhcmZJb1dnVjNSTXQyWnN3akNVSFBY?= =?utf-8?B?YjVSeDBaNHVyWVo1R0pteDF4WlJqZzR0S0VabXBYY0JnTFRkWnlTNk50cTBz?= =?utf-8?B?cVpqVGYwZ2R1aUQ1T001T1RmOEpWRUxNUk0xb0xzMkw5SXB6RmxzUmE0clJO?= =?utf-8?B?U3BZU3BXWVFVdWlCVy9hZlhjblYvSEJIVVZwS0VhN2pDMkFiM1QxbFgza1Bl?= =?utf-8?B?ZjZBejAzTWRmbjRBZHdvWUozS0YrQ3hUOXZ1TTh4U1h4U0E2MDRvQmpBRnpR?= =?utf-8?B?VUtVVTh4ZnFHWE5ORW1hRjc0bFRac1k0REZVREZvMEloK3cvNFpDMDNjbzBu?= =?utf-8?B?dmpYRHFCUmdZLzJ4T21nM1p1czVkVk1LK3JkUEMxM3ZqMnpwUWt6UFNWemtJ?= =?utf-8?B?VFBYRys0L3VHblVuOVJsa0VqV1BkQ3NqSmhkN3VXWWx5dVFaajIyenhlVk5F?= =?utf-8?B?ZjVuUkN2Y2ZJczc5WTY4ZEhTOUl6dHUyVWYweUlmajRMcno0WnVkbHpPbGwr?= =?utf-8?B?aHVRTVY1Y0tZK2RKaEtpSW9aR1pudnB2bTA4ZSthYWVSTWNLWC9wVmt0Tlk2?= =?utf-8?B?UlpoVzlkUzU2R05EWGVVR3hvU2xmMWlKcU1JbmpiUFJGcElYZXRTSW1kYTBn?= =?utf-8?B?WG95ZWFWaURKWGQxQWxlZXhNTnFJS21XYXJyOHBBdmhQV1I0STZ0S1RmK0Fy?= =?utf-8?B?MmlSSzFGYlh3cTdhckc1NGJVV3BQNzB6VVJ3UEJPaHUvVTZYZFprbjdMeEhN?= =?utf-8?B?RVpkaUZsWllPdk1QdzhUQkhLTVM1bHBYcXlUOCtZUU1ad3lvR0dkeDZaaFNN?= =?utf-8?B?bWNtb2JaTmkvUFIwL2FHQWlHV2hKN0VnTldHSnlleWppbmR2QzEyc3hMMDdY?= =?utf-8?B?K25lTUphcnRvUjBwdDNoN29ZekdYNFJHOXJDd2RYNDdaTkRDRzRod1FDWjdv?= =?utf-8?B?RldTUWEwOUlrQllZNWg0THhoalNVM2FTdkFoQUJsY0NZaHBTVmF4cDV3ZGkz?= =?utf-8?B?eUViR041c2I4T0hFc0FHUEtFeDN0a1hoNGFYcSt5ZHZZRXcxRUZoMjNBdTJh?= =?utf-8?B?TEhsbUlycStOSGRTVi9OUHVtZ2tSSHRPUGdZSDhzVVJaSDhlOHBVd0gvVXU1?= =?utf-8?B?MlM5VEdRMXllVTRJOFRCak9xWnliUzhVaitCRWxML0Rzck1hSXZjOWRVY2E3?= =?utf-8?B?Q2FyK01QZURuL0ZpSW5OWHMyQmVaSkZKUTlITjFNTkpDbUhQbDhmN0VxKyti?= =?utf-8?B?eThPRlpaM21QOG5Rbnd5MHk1bkIzODh1SlkreElDbEpISS9HZ2YxbGJ2YlVs?= =?utf-8?B?MlhhS0JyNjFZeHJGdjNSR21vakVaZThob1pvdXpOT1VmTktlMDRlSnBwK0Za?= =?utf-8?B?RjgrQXI5WTZzaXhCVE52aTRMWHJ2L1VPVyt3RVMvRi9kVlU3NUdXYVh1c1hv?= =?utf-8?Q?NqLhoRpeZ+l8Fvq0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38ba403-1af7-45aa-efd5-08da2ce56d28 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 09:15:11.7816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gJJ9wfdmo4tzwnBmrSBRHhkeCCjxGhYUvxWpA0Rhhe/1oI/fiXbNEx/S8A6Jq5U8rWAcI3qwthA6F7RjRoxBQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2408 On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: > On 02.05.2022 17:20, Roger Pau Monne wrote: > > The symbol map generation (and thus the debug info attached to Xen) is > > partially broken when using LLVM LD. That's due to LLD converting > > almost all symbols from global to local in the last linking step, and > > I'm puzzled by "almost" - is there a pattern of which ones aren't > converted? This is the list of the ones that aren't converted: __x86_indirect_thunk_r11 s3_resume start __image_base__ __high_start wakeup_stack wakeup_stack_start handle_exception dom_crash_sync_extable common_interrupt __x86_indirect_thunk_rbx __x86_indirect_thunk_rcx __x86_indirect_thunk_rax __x86_indirect_thunk_rdx __x86_indirect_thunk_rbp __x86_indirect_thunk_rsi __x86_indirect_thunk_rdi __x86_indirect_thunk_r8 __x86_indirect_thunk_r9 __x86_indirect_thunk_r10 __x86_indirect_thunk_r12 __x86_indirect_thunk_r13 __x86_indirect_thunk_r14 __x86_indirect_thunk_r15 I assume there's some kind of pattern, but I haven't yet been able to spot where triggers the conversion from global to local in lld. > Also "last linking step" is ambiguous, as we link three binaries and > aiui the issue is present on every of these passes. May I suggest > "... when linking actual executables" or (still somewhat ambiguous) > "... when linking final binaries"? > > > thus confusing tools/symbols into adding a file prefix to all text > > symbols, the results looks like: > > > > Xen call trace: > > [] R xxhash64.c#__start_xen+0x3938/0x39c0 > > [] F __high_start+0x94/0xa0 > > > > In order to workaround this create a list of global symbols prior to > > the linking step, and use objcopy to convert the symbols in the final > > binary back to global before processing with tools/symbols. > > > > Signed-off-by: Roger Pau Monné > > --- > > I haven't found a way to prevent LLD from converting the symbols, so > > I've come up with this rather crappy workaround. > > Perhaps a map file (like we use for shared libraries in tools/) would > allow doing so? But of course this would want to be machine-generated, > not manually maintained. > > Have you gained any insight into _why_ they are doing what they do? I've informally asked on IRC but got no reply. I've now created this: https://discourse.llvm.org/t/conversion-of-text-symbols-from-global-to-local > > Not applied to EFI, partially because I don't have an environment with > > LLD capable of generating the EFI binary. > > > > Obtaining the global symbol list could likely be a target on itself, > > if it is to be shared between the ELF and the EFI binary generation. > > If, as the last paragraph of the description is worded, you did this > just once (as a prereq), I could see this working. Yes, my comment was about splitting the: $(NM) -pa --format=bsd $< | awk '{ if($$2 == "T") print $$3}' \ > $(@D)/.$(@F).global-syms rune into a separate $(TARGET)-syms.global-syms target or some such. Not sure it's really worth it. > Otherwise (as you > have it now, with it done 3 times) it would first require splitting > the linking rules into many separate ones (which has been the plan > anyway, but so far I didn't get to it). > > > --- a/xen/arch/x86/Makefile > > +++ b/xen/arch/x86/Makefile > > @@ -134,24 +134,34 @@ $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mkelf32 > > CFLAGS-$(XEN_BUILD_EFI) += -DXEN_BUILD_EFI > > > > $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds > > + # Dump global text symbols before the linking step > > + $(NM) -pa --format=bsd $< | awk '{ if($$2 == "T") print $$3}' \ > > + > $(@D)/.$(@F).global-syms > > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > > - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 > > + $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0.tmp > > + # LLVM LD has converted global symbols into local ones as part of the > > + # linking step, convert those back to global before using tools/symbols. > > + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms \ > > + $(@D)/.$(@F).0.tmp $(@D)/.$(@F).0 > > $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ > > | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ > > >$(@D)/.$(@F).0.S > > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o > > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > > - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 > > + $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1.tmp > > + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms \ > > + $(@D)/.$(@F).1.tmp $(@D)/.$(@F).1 > > $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ > > | $(objtree)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-dup-y) \ > > >$(@D)/.$(@F).1.S > > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o > > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > > - $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ > > + $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@.tmp > > + $(OBJCOPY) --globalize-symbols=$(@D)/.$(@F).global-syms $@.tmp $@ > > Is this very useful? It only affects ... > > > $(NM) -pa --format=sysv $(@D)/$(@F) \ > > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > > >$(@D)/$(@F).map > > ... the actual map file; what's in the binary and in this map file doesn't > depend on local vs global anymore (and you limit this to text symbols > anyway; I wonder in how far livepatching might also be affected by the > same issue with data symbols). If I don't add this step then the map file will also end up with lines like: 0xffff82d0405b6968 b lib/xxhash64.c#iommuv2_enabled 0xffff82d0405b6970 b lib/xxhash64.c#nr_ioapic_sbdf 0xffff82d0405b6980 b lib/xxhash64.c#ioapic_sbdf I see the same happen with other non-text symbols, so I would likely need to extend the fixing to preserve all global symbols from the input file, not just text ones. > In any event I would like to ask that the objcopy invocations be tied to > lld being in use. No matter that it shouldn't, objcopy can alter binaries > even if no actual change is being made (I've just recently observed this > with xen.efi, see the thread rooted at "EFI: strip xen.efi when putting it > on the EFI partition", and recall that at least for GNU binutils objcopy > and strip are effectively [almost] the same binary). Right, that's fine. I would still hope to find a better solution, this is quite crappy IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 09:38:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319343.539581 (Exim 4.92) (envelope-from ) id 1nlozU-00062a-N9; Tue, 03 May 2022 09:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319343.539581; Tue, 03 May 2022 09:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozU-00062T-JP; Tue, 03 May 2022 09:38:44 +0000 Received: by outflank-mailman (input) for mailman id 319343; Tue, 03 May 2022 09:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozT-0005X9-5l for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:38:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d159bfae-cac4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 11:38:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4534E13D5; Tue, 3 May 2022 02:38:41 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D5373F73D; Tue, 3 May 2022 02:38:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d159bfae-cac4-11ec-8fc4-03012f2f19d4 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3 Date: Tue, 3 May 2022 10:38:30 +0100 Message-Id: <8119538cce93516f1e78d37d578996a195686f89.1651570561.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SMCC_WORKAROUND_3 is handling both Spectre v2 and spectre BHB. So when a guest is asking if we support workaround 1, tell yes if we apply workaround 3 on exception entry as it handles it. This will allow guests not supporting Spectre BHB but impacted by spectre v2 to still handle it correctly. The modified behaviour is coherent with what the Linux kernel does in KVM for guests. While there use ARM_SMCCC_SUCCESS instead of 0 for the return code value for workaround detection to be coherent with Workaround 2 handling. Signed-off-by: Bertrand Marquis --- xen/arch/arm/vsmc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index b633ff2fe8..676740ef15 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -104,8 +104,13 @@ static bool handle_arch(struct cpu_user_regs *regs) switch ( arch_func_id ) { case ARM_SMCCC_ARCH_WORKAROUND_1_FID: - if ( cpus_have_cap(ARM_HARDEN_BRANCH_PREDICTOR) ) - ret = 0; + /* + * Workaround 3 is also mitigating spectre v2 so advertise that we + * support Workaround 1 if we do Workaround 3 on exception entry. + */ + if ( cpus_have_cap(ARM_HARDEN_BRANCH_PREDICTOR) || + cpus_have_cap(ARM_WORKAROUND_BHB_SMCC_3) ) + ret = ARM_SMCCC_SUCCESS; break; case ARM_SMCCC_ARCH_WORKAROUND_2_FID: switch ( get_ssbd_state() ) @@ -126,7 +131,7 @@ static bool handle_arch(struct cpu_user_regs *regs) break; case ARM_SMCCC_ARCH_WORKAROUND_3_FID: if ( cpus_have_cap(ARM_WORKAROUND_BHB_SMCC_3) ) - ret = 0; + ret = ARM_SMCCC_SUCCESS; break; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 09:38:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319344.539592 (Exim 4.92) (envelope-from ) id 1nlozV-0006Ii-Uy; Tue, 03 May 2022 09:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319344.539592; Tue, 03 May 2022 09:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozV-0006Ib-RV; Tue, 03 May 2022 09:38:45 +0000 Received: by outflank-mailman (input) for mailman id 319344; Tue, 03 May 2022 09:38:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozU-0005vC-8H for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:38:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d2048c21-cac4-11ec-a406-831a346695d4; Tue, 03 May 2022 11:38:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 29029143D; Tue, 3 May 2022 02:38:42 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71AB23F73D; Tue, 3 May 2022 02:38:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2048c21-cac4-11ec-a406-831a346695d4 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 3/3] xen/arm: Add sb instruction support Date: Tue, 3 May 2022 10:38:31 +0100 Message-Id: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch is adding sb instruction support when it is supported by a CPU on arm64. To achieve this, the "sb" macro is moved to sub-arch macros.h so that we can use sb instruction when available through alternative on arm64 and keep the current behaviour on arm32. A new cpuerrata capability is introduced to enable the alternative code for sb when the support is detected using isa64 coprocessor register. The sb instruction is encoded using its hexadecimal value. Signed-off-by: Bertrand Marquis --- xen/arch/arm/cpuerrata.c | 14 ++++++++++++++ xen/arch/arm/include/asm/arm32/macros.h | 8 ++++++++ xen/arch/arm/include/asm/arm64/macros.h | 18 ++++++++++++++++++ xen/arch/arm/include/asm/cpufeature.h | 3 ++- xen/arch/arm/include/asm/macros.h | 9 --------- 5 files changed, 42 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c index ae649d16ef..e744abe800 100644 --- a/xen/arch/arm/cpuerrata.c +++ b/xen/arch/arm/cpuerrata.c @@ -458,6 +458,13 @@ static bool has_ssbd_mitigation(const struct arm_cpu_capabilities *entry) } #endif +#ifdef CONFIG_ARM_64 +static bool has_sb_instruction(const struct arm_cpu_capabilities *entry) +{ + return system_cpuinfo.isa64.sb; +} +#endif + #define MIDR_RANGE(model, min, max) \ .matches = is_affected_midr_range, \ .midr_model = model, \ @@ -674,6 +681,13 @@ static const struct arm_cpu_capabilities arm_errata[] = { .capability = ARM64_WORKAROUND_AT_SPECULATE, MIDR_ALL_VERSIONS(MIDR_CORTEX_A55), }, +#ifdef CONFIG_ARM_64 + { + .desc = "Speculation barrier (SB)", + .capability = ARM64_HAS_SB, + .matches = has_sb_instruction, + }, +#endif {}, }; diff --git a/xen/arch/arm/include/asm/arm32/macros.h b/xen/arch/arm/include/asm/arm32/macros.h index a4e20aa520..cf0ddad52b 100644 --- a/xen/arch/arm/include/asm/arm32/macros.h +++ b/xen/arch/arm/include/asm/arm32/macros.h @@ -5,4 +5,12 @@ mov pc, lr .endm + /* + * Speculative barrier + */ + .macro sb + dsb nsh + isb + .endm + #endif /* __ASM_ARM_ARM32_MACROS_H */ diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h index 140e223b4c..e639cec400 100644 --- a/xen/arch/arm/include/asm/arm64/macros.h +++ b/xen/arch/arm/include/asm/arm64/macros.h @@ -1,6 +1,24 @@ #ifndef __ASM_ARM_ARM64_MACROS_H #define __ASM_ARM_ARM64_MACROS_H +#include + + /* + * Speculative barrier + */ + .macro sb +alternative_if_not ARM64_HAS_SB + dsb nsh + isb +alternative_else +/* + * SB encoding as given in chapter C6.2.264 of ARM ARM (DDI 0487H.a). + */ + .inst 0xd50330ff + nop +alternative_endif + .endm + /* * @dst: Result of get_cpu_info() */ diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index 4719de47f3..9370805900 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -67,8 +67,9 @@ #define ARM_WORKAROUND_BHB_LOOP_24 13 #define ARM_WORKAROUND_BHB_LOOP_32 14 #define ARM_WORKAROUND_BHB_SMCC_3 15 +#define ARM64_HAS_SB 16 -#define ARM_NCAPS 16 +#define ARM_NCAPS 17 #ifndef __ASSEMBLY__ diff --git a/xen/arch/arm/include/asm/macros.h b/xen/arch/arm/include/asm/macros.h index 1aa373760f..91ea3505e4 100644 --- a/xen/arch/arm/include/asm/macros.h +++ b/xen/arch/arm/include/asm/macros.h @@ -5,15 +5,6 @@ # error "This file should only be included in assembly file" #endif - /* - * Speculative barrier - * XXX: Add support for the 'sb' instruction - */ - .macro sb - dsb nsh - isb - .endm - #if defined (CONFIG_ARM_32) # include #elif defined(CONFIG_ARM_64) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 09:38:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319341.539558 (Exim 4.92) (envelope-from ) id 1nlozS-0005XM-73; Tue, 03 May 2022 09:38:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319341.539558; Tue, 03 May 2022 09:38:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozS-0005XF-3x; Tue, 03 May 2022 09:38:42 +0000 Received: by outflank-mailman (input) for mailman id 319341; Tue, 03 May 2022 09:38:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozR-0005X9-Ex for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:38:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d0449201-cac4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 11:38:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 616EBED1; Tue, 3 May 2022 02:38:39 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A91B53F73D; Tue, 3 May 2022 02:38:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0449201-cac4-11ec-8fc4-03012f2f19d4 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 0/3] Spectre BHB follow up Date: Tue, 3 May 2022 10:38:28 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Following up the handling of Spectre BHB on Arm (XSA-398), this serie contain several changes which were not needed in the XSA patches but should be done in Xen: - Sync sysregs and cpuinfo with latest version of Linux (5.18-rc3) - Advertise both workaround 1 and 3 if we apply workaround 3 as it handle both cases. This will keep the same behaviour for guests which are not updated to support workaround 3. - Add sb instruction support. Some newer generations of CPU (Neoverse-N2) do support the instruction so add support for it in Xen. Bertrand Marquis (3): xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 xen/arm: Advertise workaround 1 if we apply 3 xen/arm: Add sb instruction support xen/arch/arm/arm64/cpufeature.c | 18 +++++- xen/arch/arm/cpuerrata.c | 14 +++++ xen/arch/arm/include/asm/arm32/macros.h | 8 +++ xen/arch/arm/include/asm/arm64/macros.h | 18 ++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- xen/arch/arm/include/asm/cpufeature.h | 17 ++++-- xen/arch/arm/include/asm/macros.h | 9 --- xen/arch/arm/vsmc.c | 11 +++- 8 files changed, 141 insertions(+), 30 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 09:38:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:38:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319342.539569 (Exim 4.92) (envelope-from ) id 1nlozT-0005mw-Es; Tue, 03 May 2022 09:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319342.539569; Tue, 03 May 2022 09:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozT-0005mo-Bd; Tue, 03 May 2022 09:38:43 +0000 Received: by outflank-mailman (input) for mailman id 319342; Tue, 03 May 2022 09:38:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlozS-0005X9-5c for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:38:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d0d66aa9-cac4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 11:38:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6145012FC; Tue, 3 May 2022 02:38:40 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F0123F73D; Tue, 3 May 2022 02:38:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0d66aa9-cac4-11ec-8fc4-03012f2f19d4 From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Date: Tue, 3 May 2022 10:38:29 +0100 Message-Id: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sync arm64 sysreg bit shift definitions with status of Linux kernel as of 5.18-rc3 version (linux commit b2d229d4ddb1). Sync ID registers sanitization with the status of Linux 5.18-rc3 and add sanitization of ISAR2 registers. Complete AA64ISAR2 and AA64MMFR1 with more fields. While there add a comment for MMFR bitfields as for other registers in the cpuinfo structure definition. Signed-off-by: Bertrand Marquis --- xen/arch/arm/arm64/cpufeature.c | 18 +++++- xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- xen/arch/arm/include/asm/cpufeature.h | 14 ++++- 3 files changed, 91 insertions(+), 17 deletions(-) diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index 6e5d30dc7b..d9039d37b2 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { ARM64_FTR_END, }; +static const struct arm64_ftr_bits ftr_id_aa64isar2[] = { + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_CLEARBHB_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_GPA3_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_RPRES_SHIFT, 4, 0), + ARM64_FTR_END, +}; + static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV3_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV2_SHIFT, 4, 0), @@ -158,8 +168,8 @@ static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_FP_SHIFT, 4, ID_AA64PFR0_FP_NI), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL3_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL2_SHIFT, 4, 0), - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_EL1_64BIT_ONLY), - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_EL0_64BIT_ONLY), + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), ARM64_FTR_END, }; @@ -197,7 +207,7 @@ static const struct arm64_ftr_bits ftr_id_aa64zfr0[] = { }; static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { - ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_FGT_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EXS_SHIFT, 4, 0), /* @@ -243,6 +253,7 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { }; static const struct arm64_ftr_bits ftr_id_aa64mmfr1[] = { + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_AFP_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_ETS_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_TWED_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_XNX_SHIFT, 4, 0), @@ -588,6 +599,7 @@ void update_system_features(const struct cpuinfo_arm *new) SANITIZE_ID_REG(isa64, 0, aa64isar0); SANITIZE_ID_REG(isa64, 1, aa64isar1); + SANITIZE_ID_REG(isa64, 2, aa64isar2); SANITIZE_ID_REG(zfr64, 0, aa64zfr0); diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index eac08ed33f..54670084c3 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -144,6 +144,30 @@ /* id_aa64isar2 */ #define ID_AA64ISAR2_CLEARBHB_SHIFT 28 +#define ID_AA64ISAR2_APA3_SHIFT 12 +#define ID_AA64ISAR2_GPA3_SHIFT 8 +#define ID_AA64ISAR2_RPRES_SHIFT 4 +#define ID_AA64ISAR2_WFXT_SHIFT 0 + +#define ID_AA64ISAR2_RPRES_8BIT 0x0 +#define ID_AA64ISAR2_RPRES_12BIT 0x1 +/* + * Value 0x1 has been removed from the architecture, and is + * reserved, but has not yet been removed from the ARM ARM + * as of ARM DDI 0487G.b. + */ +#define ID_AA64ISAR2_WFXT_NI 0x0 +#define ID_AA64ISAR2_WFXT_SUPPORTED 0x2 + +#define ID_AA64ISAR2_APA3_NI 0x0 +#define ID_AA64ISAR2_APA3_ARCHITECTED 0x1 +#define ID_AA64ISAR2_APA3_ARCH_EPAC 0x2 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2 0x3 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC 0x4 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC_CMB 0x5 + +#define ID_AA64ISAR2_GPA3_NI 0x0 +#define ID_AA64ISAR2_GPA3_ARCHITECTED 0x1 /* id_aa64pfr0 */ #define ID_AA64PFR0_CSV3_SHIFT 60 @@ -165,14 +189,13 @@ #define ID_AA64PFR0_AMU 0x1 #define ID_AA64PFR0_SVE 0x1 #define ID_AA64PFR0_RAS_V1 0x1 +#define ID_AA64PFR0_RAS_V1P1 0x2 #define ID_AA64PFR0_FP_NI 0xf #define ID_AA64PFR0_FP_SUPPORTED 0x0 #define ID_AA64PFR0_ASIMD_NI 0xf #define ID_AA64PFR0_ASIMD_SUPPORTED 0x0 -#define ID_AA64PFR0_EL1_64BIT_ONLY 0x1 -#define ID_AA64PFR0_EL1_32BIT_64BIT 0x2 -#define ID_AA64PFR0_EL0_64BIT_ONLY 0x1 -#define ID_AA64PFR0_EL0_32BIT_64BIT 0x2 +#define ID_AA64PFR0_ELx_64BIT_ONLY 0x1 +#define ID_AA64PFR0_ELx_32BIT_64BIT 0x2 /* id_aa64pfr1 */ #define ID_AA64PFR1_MPAMFRAC_SHIFT 16 @@ -189,6 +212,7 @@ #define ID_AA64PFR1_MTE_NI 0x0 #define ID_AA64PFR1_MTE_EL0 0x1 #define ID_AA64PFR1_MTE 0x2 +#define ID_AA64PFR1_MTE_ASYMM 0x3 /* id_aa64zfr0 */ #define ID_AA64ZFR0_F64MM_SHIFT 56 @@ -228,17 +252,37 @@ #define ID_AA64MMFR0_ASID_SHIFT 4 #define ID_AA64MMFR0_PARANGE_SHIFT 0 -#define ID_AA64MMFR0_TGRAN4_NI 0xf -#define ID_AA64MMFR0_TGRAN4_SUPPORTED 0x0 -#define ID_AA64MMFR0_TGRAN64_NI 0xf -#define ID_AA64MMFR0_TGRAN64_SUPPORTED 0x0 -#define ID_AA64MMFR0_TGRAN16_NI 0x0 -#define ID_AA64MMFR0_TGRAN16_SUPPORTED 0x1 +#define ID_AA64MMFR0_ASID_8 0x0 +#define ID_AA64MMFR0_ASID_16 0x2 + +#define ID_AA64MMFR0_TGRAN4_NI 0xf +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0 +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MAX 0x7 +#define ID_AA64MMFR0_TGRAN64_NI 0xf +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0 +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MAX 0x7 +#define ID_AA64MMFR0_TGRAN16_NI 0x0 +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MIN 0x1 +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MAX 0xf + +#define ID_AA64MMFR0_PARANGE_32 0x0 +#define ID_AA64MMFR0_PARANGE_36 0x1 +#define ID_AA64MMFR0_PARANGE_40 0x2 +#define ID_AA64MMFR0_PARANGE_42 0x3 +#define ID_AA64MMFR0_PARANGE_44 0x4 #define ID_AA64MMFR0_PARANGE_48 0x5 #define ID_AA64MMFR0_PARANGE_52 0x6 +#define ARM64_MIN_PARANGE_BITS 32 + +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_DEFAULT 0x0 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_NONE 0x1 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MIN 0x2 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MAX 0x7 + /* id_aa64mmfr1 */ #define ID_AA64MMFR1_ECBHB_SHIFT 60 +#define ID_AA64MMFR1_AFP_SHIFT 44 #define ID_AA64MMFR1_ETS_SHIFT 36 #define ID_AA64MMFR1_TWED_SHIFT 32 #define ID_AA64MMFR1_XNX_SHIFT 28 @@ -271,6 +315,9 @@ #define ID_AA64MMFR2_CNP_SHIFT 0 /* id_aa64dfr0 */ +#define ID_AA64DFR0_MTPMU_SHIFT 48 +#define ID_AA64DFR0_TRBE_SHIFT 44 +#define ID_AA64DFR0_TRACE_FILT_SHIFT 40 #define ID_AA64DFR0_DOUBLELOCK_SHIFT 36 #define ID_AA64DFR0_PMSVER_SHIFT 32 #define ID_AA64DFR0_CTX_CMPS_SHIFT 28 @@ -284,11 +331,18 @@ #define ID_AA64DFR0_PMUVER_8_1 0x4 #define ID_AA64DFR0_PMUVER_8_4 0x5 #define ID_AA64DFR0_PMUVER_8_5 0x6 +#define ID_AA64DFR0_PMUVER_8_7 0x7 #define ID_AA64DFR0_PMUVER_IMP_DEF 0xf +#define ID_AA64DFR0_PMSVER_8_2 0x1 +#define ID_AA64DFR0_PMSVER_8_3 0x2 + #define ID_DFR0_PERFMON_SHIFT 24 -#define ID_DFR0_PERFMON_8_1 0x4 +#define ID_DFR0_PERFMON_8_0 0x3 +#define ID_DFR0_PERFMON_8_1 0x4 +#define ID_DFR0_PERFMON_8_4 0x5 +#define ID_DFR0_PERFMON_8_5 0x6 #define ID_ISAR4_SWP_FRAC_SHIFT 28 #define ID_ISAR4_PSR_M_SHIFT 24 diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index f7368766c0..4719de47f3 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -230,6 +230,7 @@ struct cpuinfo_arm { union { register_t bits[3]; struct { + /* MMFR0 */ unsigned long pa_range:4; unsigned long asid_bits:4; unsigned long bigend:4; @@ -240,16 +241,21 @@ struct cpuinfo_arm { unsigned long tgranule_4K:4; unsigned long __res0:32; + /* MMFR1 */ unsigned long hafdbs:4; unsigned long vmid_bits:4; unsigned long vh:4; unsigned long hpds:4; unsigned long lo:4; unsigned long pan:4; - unsigned long __res1:8; - unsigned long __res2:28; + unsigned long specsei:4; + unsigned long xnx:4; + unsigned long twed:4; + unsigned long ets:4; + unsigned long __res1:20; unsigned long ecbhb:4; + /* MMFR2 */ unsigned long __res3:64; }; } mm64; @@ -293,7 +299,9 @@ struct cpuinfo_arm { unsigned long __res2:8; /* ISAR2 */ - unsigned long __res3:28; + unsigned long wfxt:4; + unsigned long rpres:4; + unsigned long __res3:20; unsigned long clearbhb:4; unsigned long __res4:32; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 09:44:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:44:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319368.539603 (Exim 4.92) (envelope-from ) id 1nlp4X-0000FY-Io; Tue, 03 May 2022 09:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319368.539603; Tue, 03 May 2022 09:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp4X-0000FR-Fh; Tue, 03 May 2022 09:43:57 +0000 Received: by outflank-mailman (input) for mailman id 319368; Tue, 03 May 2022 09:43:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp4W-0000FL-Q3 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 09:43:57 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0606.outbound.protection.outlook.com [2a01:111:f400:fe1e::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c63bdd2-cac5-11ec-a406-831a346695d4; Tue, 03 May 2022 11:43:55 +0200 (CEST) Received: from AM5PR1001CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::18) by AS8PR08MB6456.eurprd08.prod.outlook.com (2603:10a6:20b:336::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 09:43:46 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::58) by AM5PR1001CA0005.outlook.office365.com (2603:10a6:206:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Tue, 3 May 2022 09:43:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 09:43:45 +0000 Received: ("Tessian outbound 62985e3c34b6:v118"); Tue, 03 May 2022 09:43:45 +0000 Received: from cf8908aa108f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 11505F69-3D3F-44A3-B80C-5B54BE42DBF5.1; Tue, 03 May 2022 09:43:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf8908aa108f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 09:43:33 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by DU0PR08MB8068.eurprd08.prod.outlook.com (2603:10a6:10:3eb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 3 May 2022 09:43:32 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 09:43:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c63bdd2-cac5-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nggAKUkkq/JO5/BRWLwQiFus3nSsBz2+QtjAZW3weO4Aa2bpepSn9dOUNOVFvvSeBSmWzVKzJmx63xhmz0ukf6/okd924kyfw56BCHAVXDuxJKHt+lMhF5D3Vfjn1zcouSq9cof+s5fflnVPH6lupt/wlSRB1zU60ANpbO58aVDVND5RZLEFJuea3AZSK1CN0dLB7ASVoZ+rGsU5EwPnmqBZ6mf62fgfZt37mpWvh9Jhd/ZBq7LCk8St3xhoS6o84WoT05JyeRClu4CIhjHF2FC4oPoHAYgN5coifl9qRMfnSYtqCFLLyJpIBXbx2ggLJ2F8eE7KNN04wtdPYW7kew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=XvvE7D70i/wOo1uQSQ64vOYkPv3S4nV1gQRa+sE0hatAj0bNMHFiOKwBfV6Sv6oiTkH/mYXIMLEFd6660WqDsQqTu1OOdBWjJLVQmZhSV/1/CX3zPNd3zXmorx/4jKC0vMrl+3qRXdL/lI6OPbB4TEk1zC1cmHXq60VnKXPZMYyRgY9YIdgIlpYGdnfONT9BDnkyPTQL0IkcuP7wVPOgswtm62a/0zsWVSfgrtNCRRS9hN/k28dujcb5Ubl0FsIeKxnMp0rq56ChaOJMjRjTDlKWjKEshf0hRxxYNAj1e5XKqLTKRUnTNBwIKZnzp7AO05tH+pL3HvBUi5EMAAWIcw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=kvIYYOKba4Ca+81iwubtK0JFxfyV9OW0k/BZ83bv9tFGQnD7xDG6AImxZgHwqNLUFYNLsduWXRpx41LXgmDnhsldEvvrLkFAN4Ti8/tzC3wAKAgON3dzakSR2XFOuohV6e1KaHUO5gFTbTHJvQNnlq8u1l0AWYF1HtTN2lYm4kc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: a7781d181c44c001 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHTzNU+sr9mLOTsqGIXNc/I6doycfgXT5CyMnjxL5+LA0FTQ56DcFfiUHC7gvWqqQT8QCdyJkexKoG3Rt7zTGi34N8DxPyG7z56dob3czOXLsZSScKSMzFh+bA4Hs/cvM7ExveJTICB+mtRMCU5yzQ0XrFiVA9oJzSP/3mX9YQlI7Sx1tCTPLytqaaWdI2RjS513Uu575zG175xM3UDzS4HPO5UqYj/1B77dy+iWekVSCvh32UFHruN96xUmTWcISnchIE7IjLGVr8MIshHHt2kQ5XVgwWHjtmr2tnXzmY11xWQ9ChJNtJbboTlosSiC2xxRgF5dzqqQIhvLKYlnYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=YsXyo13sHtcwsR2QsyEVtPve4E5/ivAcvPtQw5myr0ICzG7VAedRK0MhVjAWj0iLiD4x6o03tz26O9rPe0Wh/rmnuqF8cinlA/kHeQ9J9hWnSGJFJdcPZ3kNxPiufeDWdouWUmxtzHSHzeTrpg32Mz3b/1vt21cI9h8Xn+dE9e4J6ZfF3XNF7hAGziloaNlbL/d64bwLi+mzwaQLYXjIciQfG4BWZpzh3Lv1SqJvRNsAdKQ08Y08DYVpWAEvXttfE8Th6d+I6zEBYhfQTeEK/HkToeQWtOoOnEkJ//B8mPJ+/UHOiYnWSgwcja84Driu3kHKJZUrS61rrEYxwX3rIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=avYjy66VERgxoquFyw2Y647TrKpcYR/oVyJIR7tJSMM=; b=kvIYYOKba4Ca+81iwubtK0JFxfyV9OW0k/BZ83bv9tFGQnD7xDG6AImxZgHwqNLUFYNLsduWXRpx41LXgmDnhsldEvvrLkFAN4Ti8/tzC3wAKAgON3dzakSR2XFOuohV6e1KaHUO5gFTbTHJvQNnlq8u1l0AWYF1HtTN2lYm4kc= From: Luca Fancellu To: "Daniel P. Smith" CC: Jason Andryuk , xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Thread-Topic: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Thread-Index: AQHYXijv9StER8938kifKUVqRlYIt60LmLoAgAABtwCAAAEnAIABTJWA Date: Tue, 3 May 2022 09:43:31 +0000 Message-ID: References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> <15634549-bde3-873b-862c-37ebb891ba0e@apertussolutions.com> In-Reply-To: <15634549-bde3-873b-862c-37ebb891ba0e@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1fea1d51-17dc-4323-b790-08da2ce96ad5 x-ms-traffictypediagnostic: DU0PR08MB8068:EE_|VE1EUR03FT059:EE_|AS8PR08MB6456:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IEJNjgUxcPRxCPDJbrCAaN45yrOJwBIHeAoWereQjk+aTduIJxqwHnwo+ywyA61c5AVpKYzJkGvcJiWKaLcARE1zHOTool5AXgss1G5Q8XoTa0bAOK3Y3hv+GGolcKdqEP1ZgjV3nFqhiKiLY8IXJdm/2ubYa0F3knyZMZSrFU9GFq7EcInBwVJqH3u+VGFtVI2DvnDryfrIEb51+ALg2Xy0Fyb7ZEW+YL4apnKa4cD4c8yi3fHT1y0x8lKx3ssi0UX/4oVen+2Nl/SGDCC6pROFXRHjCPNdqyfbZ2USKVDPwpoSunLn47fsKBp+QM07zCOqp8gTxjkETu+6wsMj27U84/KFEO7T6JNMK7bGyekEjBkJlcSEdRlifWNGPZWwTDZPRMgggL0C9rrZPvCWnLASmW3TdCUE/RfIB3j1GWz77f/PWpXWpON4YXpeLvpMnVYvc3U8X8R9nkpUcPMAHqovUqjjbTxkvl1CRrH7f0csWX7Yme1TGpT5f3h+GWj3Us4M8wEothXKAJ/encJ7Qla8j3gksf4TKSM+R29WBtoG1OrHsTT2LTpuN42IGplcEkPjEWtWU+DKQYITEkVF7DbEbWTCvi0uXLALMXdo7Rk9ZEdfJxtn5GR7+W6xv8U5i8w1aDf8hWYDAJ1UiqBTj7r8CXe+w/iXZ8q4/i+Hp/hG0jOt+3T6nbzrRbtF9QLaOxh1WrDFliLYnj52QZPjXLyx2Dv61EUaKIcG4gpfVtc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(26005)(6512007)(316002)(122000001)(36756003)(6916009)(54906003)(38100700002)(186003)(4744005)(38070700005)(66476007)(66556008)(66946007)(66446008)(64756008)(83380400001)(71200400001)(76116006)(4326008)(8676002)(86362001)(7416002)(6486002)(2616005)(33656002)(508600001)(5660300002)(8936002)(53546011)(6506007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8068 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05ad662b-3b5f-40fb-36e1-08da2ce962a7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BFhwEXfG1DKIybSzXS1GIrGk0AKXrFM5sDhO9OgXGy5myt6UuxR6oGS9rw5v7j54vZEo9445rgjXc1npvf6A1Y0VhARJMZZeHxoNXTpu4aMsNy4e0Dg+RMaq6V+ks1e6DfL73MtfMOGcwFAHMg4iVPwt1n9wPuHSbaWNPd8Np6MUCCO6CLjIdQqJN7Buastk+bO8OpS/LjP3mid9BxYpNnUrIQJ/Q/6wG6NbtHFEiB07YFKuwlRHseNyOaJ87t/7LJPIZZshU1ffZf25hnkHOwzwc3ZAQBnpJnWzWumAO/7VorZXV9lj4SujT5FvY8cXUkbGyKwECDCDaMo5NE7aojBZFaqpOFdufhu/QYJGDDxv6jyyF5pcI0QDBxuIiDWfHcVVsVArTC9SG1K8ZWOD3YxKJeSoU2Q2qdhbdgFQ8Vz+0LP7q4N0CYGqWvPTeK/zz7jinopushoPSawQt49RhZUdRc7J30qSurzQUW8vZzcQvsBwsZ8FEs89k0Lkg5nVuayO8DE+7pe0lWGcxI00FdMmNsX9jVL6YHlZL7GDaqbdCFKsrZlA7I3fcEOoGjzXh9N6cjUEikURiDu2IRtWz9JkGdhm7wRSBR2GebqMbJqAHdzWmmp7OXbHLzFHPBD1WC4PF21N7P3vfuXmLZZK6i3ztkXgPvH+IXimsvCTtXmdYT0TA7zhO8PZbjcONCGS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(47076005)(2616005)(6512007)(186003)(81166007)(26005)(6506007)(336012)(40460700003)(36860700001)(356005)(83380400001)(316002)(2906002)(86362001)(54906003)(82310400005)(33656002)(53546011)(8676002)(4326008)(6862004)(70206006)(5660300002)(8936002)(508600001)(70586007)(36756003)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 09:43:45.6631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1fea1d51-17dc-4323-b790-08da2ce96ad5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6456 DQoNCj4gT24gMiBNYXkgMjAyMiwgYXQgMTQ6NTMsIERhbmllbCBQLiBTbWl0aCA8ZHBzbWl0aEBh cGVydHVzc29sdXRpb25zLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiA1LzIvMjIgMDk6NDksIERhbmll bCBQLiBTbWl0aCB3cm90ZToNCj4+IE9uIDUvMi8yMiAwOTo0MiwgSmFzb24gQW5kcnl1ayB3cm90 ZToNCj4+PiBPbiBNb24sIE1heSAyLCAyMDIyIGF0IDk6MzEgQU0gRGFuaWVsIFAuIFNtaXRoDQo+ Pj4gPGRwc21pdGhAYXBlcnR1c3NvbHV0aW9ucy5jb20+IHdyb3RlOg0KPj4+PiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPj4+PiBpbmRl eCBkNWQwNzkyZWQ0Li5iOTA1NzIyMmQ2IDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0v c2V0dXAuYw0KPj4+PiArKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPj4+PiBAQCAtMTA0OCw2 ICsxMDQ4LDEwIEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nIGJvb3RfcGh5 c19vZmZzZXQsDQo+Pj4+ICAgICAvKiBIaWRlIFVBUlQgZnJvbSBET00wIGlmIHdlJ3JlIHVzaW5n IGl0ICovDQo+Pj4+ICAgICBzZXJpYWxfZW5kYm9vdCgpOw0KPj4+PiANCj4+Pj4gKyAgICBpZiAo IChyYyA9IHhzbV9zZXRfc3lzdGVtX2FjdGl2ZSgpKSAhPSAwICkNCj4+Pj4gKyAgICAgICAgcGFu aWMoInhzbShlcnI9JWQpOiAiDQo+Pj4+ICsgICAgICAgICAgICAgICJ1bmFibGUgdG8gc2V0IGh5 cGVydmlzb3IgdG8gU1lTVEVNX0FDVElWRSBwcml2aWxlZ2VcbiIsIGVycik7DQo+Pj4gDQo+Pj4g WW91IHdhbnQgdG8gcHJpbnQgcmMgaW4gdGhpcyBtZXNzYWdlLg0KPj4gDQo+PiBUaGFua3MsIGJ1 dCBub3cgSSB3YW50IHRvIGZpZ3VyZSBvdXQgaG93IHRoYXQgY29tcGlsZQ0KPiANCj4gQWgsIGFy bSB3aGljaCBJIGRvIG5vdCBoYXZlIGEgYnVpbGQgZW52IHRvIGRvIGJ1aWxkIHRlc3RzLg0KDQpJ 4oCZdmUgYnVpbHQgdGhpcyBwYXRjaCBvbiBhcm0gKGNoYW5naW5nIGVyciB0byByYyksIGV2ZXJ5 dGhpbmcgbG9va3MgZmluZSwgc28gd2l0aCB0aGF0DQphZGRyZXNzZWQ6DQoNClJldmlld2VkLWJ5 OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0KDQo+IA0KPiB2L3Is DQo+IGRwcw0KPiANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue May 03 09:48:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 09:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319388.539614 (Exim 4.92) (envelope-from ) id 1nlp8j-00018r-8W; Tue, 03 May 2022 09:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319388.539614; Tue, 03 May 2022 09:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp8j-00018k-5c; Tue, 03 May 2022 09:48:17 +0000 Received: by outflank-mailman (input) for mailman id 319388; Tue, 03 May 2022 09:48:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp8h-00018a-Nu; Tue, 03 May 2022 09:48:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp8h-0008Bi-MK; Tue, 03 May 2022 09:48:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlp8h-0004aW-3j; Tue, 03 May 2022 09:48:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlp8h-0004LP-3J; Tue, 03 May 2022 09:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iqee8MqV2C3v9ykMHGFE9h6oB0CTmvh+Lg5VxemxVBs=; b=I023G9csPWoN+lbnz9C9BTyvQX Pd5Vd1E3gQXnddbu4JPSgGdseOuGAMqJmOTSBDrOkty3D1OADSUESWvyBCWVf/leuvs0b6lZbvyEV wYOwUu7NhxuCpf7W9IXfxrkbvSAVqqGhnO54sBOFbITzVQs130Gd/xx11AZCYKrMv4sk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170030: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=4092f1d3977d290bf7fbcaa1ff55784c080f136f X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 09:48:15 +0000 flight 170030 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170030/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 4092f1d3977d290bf7fbcaa1ff55784c080f136f baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 63 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 776 attempts Testing same since 169999 2022-05-02 17:12:56 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5871 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 10:11:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:11:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319398.539631 (Exim 4.92) (envelope-from ) id 1nlpUi-0004hV-BW; Tue, 03 May 2022 10:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319398.539631; Tue, 03 May 2022 10:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpUi-0004hO-6o; Tue, 03 May 2022 10:11:00 +0000 Received: by outflank-mailman (input) for mailman id 319398; Tue, 03 May 2022 10:10:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpUg-0004hH-Iq for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:10:58 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51a32cf2-cac9-11ec-a406-831a346695d4; Tue, 03 May 2022 12:10:56 +0200 (CEST) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 06:10:50 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB3235.namprd03.prod.outlook.com (2603:10b6:405:47::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 3 May 2022 10:10:48 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:10:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51a32cf2-cac9-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651572656; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=TOPpMhClwRfKHfmFIJh2tGPy0dP3JDJ/VZ2rytOBuxc=; b=F9Dxcv5cKyxZzTxpizBSEIdM3Xm3ufiw+F8YDUN6vttXf3SjOtl0R/LL tX/uOyucAkCV84ivK8pLaonoW6a8ffPyk9xyYV8rZSevQ+PJ1HjSDkZVL y0lb2t1fUdI+zZSUNfRU3E2JEIP/+ZuYwaDXbM4ec6SOiV4l7IrtjpwT3 4=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 70859036 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pBJAmK6+HSELHynP2SlH4QxRtEnGchMFZxGqfqrLsTDasY5as4F+v jNMCzqBPvyJM2P9L9klPou1pBsC6JTVydRiGQo9rng0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSPZyYKI5XAvd4QQgZiOHA5EPR72OXYdC3XXcy7lyUqclPK6tA3VAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YAhF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA+A/E/fFpi4TV5AFdgZ+0HPrrQ9qPd/tJnE+5u WOW9WusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVRxSlpFaUsxhaXMBfe9DW8ymIw6vQpgqcWG4NS2cZbMR87ZduAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs37UZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:Gkm7vqjfaa1pwg7AFfJOivmSGXBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Su1 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfo2oCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8AzeSWCQfkNIN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp D52+pT5fVzp/QtHNNA7dc6MLWK41P2MGLx2UKpUCLa/fI8SjvwQ6Ce2sRG2MiaPLo18bAVpL PtFHtliE9aQTOaNSTJ5uwHzizw X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70859036" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lY+2/W175nW0WRBtOYpKOa0QmNVZinli8NInjGVdwT00KvNpc/PmNj0wfha0YUlvxhWxff/pkoo4XSgQcb9xpKVylp7YfntcgekFPxhnHnqLxPy8w57OISb0mcRZrLwDNIz7jkmZUi4Gq3cLTg8/viKi0mjMpy45e7ku5HEP0zQ9ODq41YqewDfIQg/NiWorPSpWtsiXvUYNRkGUMw8LcGy76nfYtr8t3JiThQTfgJ9Pc41iUrFMfMOr8q+vAXBqEpBxoH5wGdeHWHuTl6vJXl6jVul96UCtk9/ZwxrQT1tbn6WPO/nZYKH3eCf07Q3hsWQthgckS8Db9EVOWREjNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ROOFs89QgiNf7MgTSRV/8whKC9Rvw6o7cuRUEYQGDD4=; b=Y6gSy732MVl9nt0j4AKk55+p3hRsRAnOFO6OmNyVHIB7nPdaW+FP74Uf1RbHmebslmNW7ileu0c67TSQGE3sgG3CN78fzBpK1yhp3qsOpvu2wuTeWH1JSAQTsA7w44eJh1kvfETYX4SlkJ1NEwLxYzfXdh/PT4Y131sPMULGmygh4gfRkpiLiyuAHjY21c1iqzGbnLABGYcw7l06b9XNhqoG+APhHwGF9Z/fc0jSDzfFHChAy8G2TsJSYHC7okksSFpmvXbNPHQ8on/c3N4bOI7JKouyuak+6irpZJnas31wamv8EifXoO7Lrm8xosfmRPdFXxhUCx3d9Sv7cdR3DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ROOFs89QgiNf7MgTSRV/8whKC9Rvw6o7cuRUEYQGDD4=; b=iNpKSkjE1C9cmru1Q9SUVT6ywEE1icnGS8QIzy51MlHmxRn+pfbUXqcRJFiVircmWWWQDARfTXljgAVn4sWot1RDij6m63WLIvI1FmGlx/KwIScMg7cuKQPDy3lsYaBGkqYsuqicqrrzdHQ8K+cVIpbeqQThcN8wLVqtZSLNMN0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 12:10:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts Message-ID: References: <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com> X-ClientProxiedBy: MRXP264CA0023.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c431f414-8429-48c4-5ed7-08da2ced314f X-MS-TrafficTypeDiagnostic: BN6PR03MB3235:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CzuDeEPN67PIY8qXk/etGEmeNtxGK/v3nEClD7U2zL/OTdC0KNSOZuGjCXOpi+iAuk2gTc0glP7wken6lmgBe4wLghSeF4kxziNDyUjpfWK8XVLwJ4t/l7BZ7ehKW+6cwpLFa47ndPaP9D6OpyqUI71jZ0Q9lsN3uX0M28x/ti3wU3PK1zU2lTg9NPwnVK8ajRk59iOHjCrFlNFKECSNHcumvMmWmvxarOY5Gyqo5j/IKiB7LUdXX5AlOagyGyUWvosciZj3Zlc9Sac5yDTb/cPpikP9hlDHorKm2imFHaJpktaoxkhGlyYoQztj8/fF4AhBALpvwY7veNWvv/y7bYUEoL/15CkDw59iRFgZCXbtE/pEivBQ3zSzKaanXNtOinM1yeUGrfCK+u19v2i4TPu6PLCOk89aazKeiXTv3xEQx2kl9A+/Y/n8hV9FtzCNdLScKYgqoqsIk7BhQMsSkq4spfilH1jiY3gfwrnRG7FXm5Tq+tfGobp5Kr3CUJEmYV0zHXSL2pFp3KTsshSDqt1n05kHMANiER+5rX/xgqfwqPFn05CGQlHNvnWc24LWO7j109/Z47BQen5prSmVEghcKPbtRSxPacdVQfvFvCRjQnJCueTW6cjO6NkETbpH8LaesT6VdB8C2tbiF12Tcg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66476007)(4326008)(38100700002)(85182001)(82960400001)(66556008)(66946007)(8676002)(6916009)(33716001)(316002)(2906002)(86362001)(8936002)(5660300002)(26005)(6512007)(6506007)(54906003)(9686003)(186003)(6486002)(6666004)(508600001)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUdQeDd3Zm5aMnI0QUs5OXJiQmhvd1Z0Tk5FWkQ0bElxKzQySVAwUmcrT3lk?= =?utf-8?B?WW9tOGQvZS9lRXpYZkJvMnNLVUZHSkdkeHE2bHFnVUtDM0tENmd3U0k1K2Nj?= =?utf-8?B?a3E5NklxdVY4eDM2K0hKLzU5KzJuZzRjQ0RoY3VLNmRkMEtUQTFiOUdTNHVN?= =?utf-8?B?cmpPdkZGLyt3T0JVeVhTYWhxOVJZSnRkNVFTOHhjTFdXN1ZkbGhiNkw3aFdH?= =?utf-8?B?RUdMK2RWZ1c3Y2F4ZzJJVHRtYlpkbHVkdDFpd3VlN3o2eTVsT0MyTWtTanpC?= =?utf-8?B?Nk4xVGlyU0lhZE5BelhTVHlramd5RW42MXQ0Ky93QlFScjRTZE5HemU4d0Z4?= =?utf-8?B?V0tRMWRFTXV6Y1FvZjFzcTdMTThxYkE5UGpENW5XMzlES21sY2J4YjFhREFE?= =?utf-8?B?WlR5d0V0STFPRXNvSnRSbnlMSmozMWJJYlBXOERiZFhYZWdqUTY0bmZUREVZ?= =?utf-8?B?TnY2OExBR3JYZjhsT1Y0WlJZcUVKL244ZkdUeUVDeXJxZXU0MFR3NFJXSUtk?= =?utf-8?B?WlBweXd2dHRRVndBWWNVQkYxVVdWYSt2bXRtRGpid0dGczJFbWhIc0IzWTIx?= =?utf-8?B?TlgwODNuL3FsNnovblRlRDBKZnNKcVY0bUxnTWk0QXBCamtIOE9udnNkQTIx?= =?utf-8?B?dTBoa3ByN3BUNFhHNENRNEVPbmlGekhlK3ZISTB4NVc5U1VTVVFHQXlPaTl5?= =?utf-8?B?bzByVDdJd1loVmJLZTl2bHRXTlgyUjJXVTBnUm04RzZUYWtET1NrV0JWYk1a?= =?utf-8?B?Y0pOcVNRb0ovY3lIY3pEdXJleWFJRnN3VTJjazVleXFoa2tKell5Mlh2MWVM?= =?utf-8?B?Z2JYYlpSWkRwbFZWOXFaY1p4RmJKaU1wVkhnUmtiK2FQUjVrNVpCeFRONDVO?= =?utf-8?B?anBvY0dISDlVNjU3bEx1NUJlOURNY2pReVQxQy94RUtITG05dGtMODYrOXZl?= =?utf-8?B?YTl0aWRGK3MxcWtxSTJDU3grQmg4d0dOMjhQV3RMRldCS0ZZRjRBamhhWTQ2?= =?utf-8?B?Zm9od3RLbjJhNEZWSVlTZy9pODBNSTBjSXpwQ0dkL1JtRnR4U2xhbmI0UDNy?= =?utf-8?B?N0VFaDQwSFAzcFZJNnVYRDh3MFBpVE1DMWQ4RGJtejhOemtXVWo3MFcySkFx?= =?utf-8?B?R1BEN2ZNcGtIQ3JpdHFrZEhqclprSUI3MExUM2FDN3FVYTFqYWp3b3EyUlhz?= =?utf-8?B?R29MNGhoV3ppamg1ZDJ5R2d6dDFRTHNla25XMkxObFRUOEZGVzZlUVhlTkg4?= =?utf-8?B?bUx6R29BNVhObFRlVTRqWE1YbUhlUWltZnJ6bzBnUk90bEY5WVNQNFRtV2JS?= =?utf-8?B?TTV5Nlplb3QvZ0xXQU5ZY1lGbkxITFdwK29IUXFmOHdRaXpPYkVFV3JTRFEy?= =?utf-8?B?K1p6THFvVlNheHl6NGtXOWV3Q3FiZlBZdzhRMzVWa1JmZUEvYkRWUjhpOCtY?= =?utf-8?B?dWU3VjZDdVd0OWlXcnpUaVBkb0xRckZwOHBYblp6WGFTc3BmTDZOSEFFOVMy?= =?utf-8?B?NWVQRUFRNVJYL1JRNWRNTlNGaDBKaFNvTVgvRWVPUnN4VlliTzJ2MElNMlZI?= =?utf-8?B?NnpGQ0NJeFErRS80ZlpwT2h3OVJJRjNMayt5Qk9Jc2FSWHR1R29ZYk1nUGEy?= =?utf-8?B?MHhwVDJ0RDEvblh5eEo4eFNaQldPY29SVmpVY1R5QjkrV3o0Z0lWd1gyLzU5?= =?utf-8?B?S3JpOHIwbkZhc3NRNHdETlNyWDE4L3pmekJLOGQ2WGRDb3dvV0ltbmVjUTN4?= =?utf-8?B?ZFJwVVZSNlYrZkJ2RmRESTJ4R29mdHNHUU9sNkJVVWNGWks1V2JVZDlGZHZW?= =?utf-8?B?SkdpZ0c4RTVBU2trWFZRTE1sSUo1Mk43dXhrN0hjaXdiUjBrVllpQzcxOTYw?= =?utf-8?B?Mjk1bjFUL1FaMW9XS2JMYVUvNVhKYlFxRGVKdWVXTjFweVpwS214dno2QjA5?= =?utf-8?B?Z1hWbGFHNWRQQUFNcXp3TFQvbFpOQ242R1JIQ3VORnFGeHBLVkpndENxTVFa?= =?utf-8?B?dmxFRlUreldnVkZtMEh6SFoyZW1MVlFVUkEzRU91d1VyVnBjdnFPMitaWHNZ?= =?utf-8?B?eHVseHNRcEJ3SjZ4VVAwdUdkUzVHRTZpc25ERU1nUzVpQXBuRVpqZHY1dHBx?= =?utf-8?B?ak1JUUFENk1vcWIwZG1GaXd2eGJOWCtHb3NZYkFlcjFRdDdsejVuU20wL1I4?= =?utf-8?B?anorTFNab2VFeEh2L1orcks4cTlOVEkrWjBXNEx3eVZFejV0bzEwN2xTNHJB?= =?utf-8?B?T2VqdXUvOFp4b1RJZlhCTGxoUU50dUNWaTZHanpsT2NZR0V4REZ2dlIvZjVj?= =?utf-8?B?MitEZjJQSER2c3Y4eENNQXhtcVlQUXRkTy95cEFBamVBQ042c1FmZHpiUUpG?= =?utf-8?Q?+PN9oSAAToZhPh4A=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c431f414-8429-48c4-5ed7-08da2ced314f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:10:47.5159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ATgurlksNKe7Cg6fXRyAFughhACARDZKMH/whyX7hp7kLuU6HiSqayIlYIr5u8i6Mqj8KVgzjEwa9JDubNcEcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3235 On Mon, Apr 25, 2022 at 10:30:33AM +0200, Jan Beulich wrote: > Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify > the target level for page table walks"]) have made Coverity notice a > shift count in iommu_pde_from_dfn() which might in theory grow too > large. While this isn't a problem in practice, address the concern > nevertheless to not leave dangling breakage in case very large > superpages would be enabled at some point. > > Coverity ID: 1504264 > > While there also address a similar issue in set_iommu_ptes_present(). > It's not clear to me why Coverity hasn't spotted that one. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > --- > v4: New. > > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -89,11 +89,11 @@ static unsigned int set_iommu_ptes_prese > bool iw, bool ir) > { > union amd_iommu_pte *table, *pde; > - unsigned int page_sz, flush_flags = 0; > + unsigned long page_sz = 1UL << (PTE_PER_TABLE_SHIFT * (pde_level - 1)); Seeing the discussion from Andrews reply, nr_pages might be more appropriate while still quite short. I'm not making my Rb conditional to that change though. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 10:15:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:15:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319405.539642 (Exim 4.92) (envelope-from ) id 1nlpYr-0005Uc-RX; Tue, 03 May 2022 10:15:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319405.539642; Tue, 03 May 2022 10:15:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpYr-0005UV-OQ; Tue, 03 May 2022 10:15:17 +0000 Received: by outflank-mailman (input) for mailman id 319405; Tue, 03 May 2022 10:15:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpYq-0005UP-6e for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:15:16 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062d.outbound.protection.outlook.com [2a01:111:f400:fe1e::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec279146-cac9-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 12:15:14 +0200 (CEST) Received: from AM6P193CA0080.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::21) by AM0PR08MB4003.eurprd08.prod.outlook.com (2603:10a6:208:12d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 10:15:12 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:88:cafe::9a) by AM6P193CA0080.outlook.office365.com (2603:10a6:209:88::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Tue, 3 May 2022 10:15:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:15:11 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Tue, 03 May 2022 10:15:11 +0000 Received: from be5eab844d01.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 445E2378-C782-480E-BD22-7AF8137BB4B8.1; Tue, 03 May 2022 10:15:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id be5eab844d01.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 10:15:05 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by AS8PR08MB6549.eurprd08.prod.outlook.com (2603:10a6:20b:33d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:15:04 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:15:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec279146-cac9-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nySQ4NXdCoBvf8kOKPzmIgO2nMb5Bm2JZBVm+LJjWrUBDg5w5rAvcQkTCLEyRNB2RfxnelSksmrm0zKMwiMPjhyjWFGJ8AQoUnW1xYXULk9VRWzaGpuv0pucJy6sbo6/XuOjC3fJZ1X8iKMrGZ4r+2xaHG2+/b2eznnTOh+855cLicrHWHuanz08DBgjYPOMuHBWslA3zsrGg89EyqFjaly3BSQWLqxn8zvSPiInT878cmeV0UcxaTr7+2QQXZEZElvQbtWjanhxXBzyg9jmC3YB/f2frMjuKmUfclNhuIT8P99uIbmDmdlfPoGXWNKdzQm/In/Waq40B6AE3muBzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=b/h4ZinUzCs+1d5DGbch1bda5I6pvlnyfh2IAK9HMExXIIWuvgMxYQFB9rBpRo2YU869VcPpTb2lcjIS7bztwc5x9ftYiG9/ICgmkjUEXWV/zzsiYzxckJ8OEtfeilClqOgFxS66XE39v56qlhh9g8GLXN/r1inntzygvrGr7aWyqRsCNCNZhGk/qe9Hu3cE/j0uYPD6iaeDT2CIll34Ba/Y2UUlaIM9z4hvdx916udaqEnpE1QDO3Utjk7VzzN/8sc2c7aA7GgnijaACE/CwlgrvKklTon1VhNenOBy6vNA0Cp/fVbCG/ZAcS+H3sc0Nr2TJQWwwuj7CoVKpSFK7Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=EMvN4jcewlotb7hS+pG6UeZzhliWtGEgS9ADloUb9ZZ3lll+B5w7j5ZkKkuVh4NN712qAbomLaQfMoKR0HNQ0hUqzaUROYywuktV/cBU1ctyJtx6wgvagYClK3HmUdq49L9fEtdnBK95uL2o09KTLs9CF7hStbJnLmd/Y/URKUc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: da317987b6fac9ac X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CS/thZwDOq80pyz1v9lTUHoNlwIG8WL9kDRXvD7mtUlrgFa5DUXkRJ2g4yGPc8iDyydQWUgg3SqqD2rTYUI9ZMnnitRhktNZwzHckN359yIFb+hghu16CVrc5ncZwNYXMgRTQpwKB74mJiUZW3sM0w2O+idkCRERNJUlFZhTScTaPKZkQfG5bKQBbccjKlevKbfaHrsHQaDmLQyGNXELW6uWrioY0a/wkC3ULmnn+rmEsUnSEcuhTDmc1hHWb0vfdHvKJid0rNSFnFy3bzjAt23gRIbyUjHMaT8dQNqkNQT9PClrVhztAFBk+C8LniMvAYDwYmWbo0oL2wM/P1qdUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=YCg7h3mmhtkKqVUN6jRPxFoQvT+7/ozw5rK362QPhBqmOgG3bGwOXQp61ivEi2Dm3iThRVaQ6RyH4EP5HWtltNnZA2twaRK9WCgZZgwlsoLwePfbPgwiPbtRtsVyyDhsaPV9cd/1buawo8JMlk15zYHN65YKvoBQeblamnTmTT77DhsH72FPrFbPrm86vKDtfTmBlYdOJUTBqk43lNpK6Y9qt1KIxm/H3/ptl8fKwmGIdaU0hIfkfZ8tzw+IwYRmHCjggblfcY1rRdgrpcit/vkowgsVKbVETWM28+JcyWzub2zZiyoN2umVtQvzpOMtY7gBoY6T3In8TKTvUVNF8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O08oTBgJLixi80z0lATy7zmbB5LWkAjCrDCWbjYQqTI=; b=EMvN4jcewlotb7hS+pG6UeZzhliWtGEgS9ADloUb9ZZ3lll+B5w7j5ZkKkuVh4NN712qAbomLaQfMoKR0HNQ0hUqzaUROYywuktV/cBU1ctyJtx6wgvagYClK3HmUdq49L9fEtdnBK95uL2o09KTLs9CF7hStbJnLmd/Y/URKUc= From: Luca Fancellu To: Stefano Stabellini CC: xen-devel , "jgross@suse.com" , Bertrand Marquis , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Stefano Stabellini Subject: Re: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length Thread-Topic: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length Thread-Index: AQHYXAvNeYUSSCJ/SEOm+/N9Ov4Ija0M9TaA Date: Tue, 3 May 2022 10:15:04 +0000 Message-ID: <98FDF48C-9EDD-4BF0-8C67-B63884E159EF@arm.com> References: <20220429205732.2030094-1-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-1-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e3dfa394-a002-460f-866d-08da2cedcf2f x-ms-traffictypediagnostic: AS8PR08MB6549:EE_|VE1EUR03FT025:EE_|AM0PR08MB4003:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wiGXJCdk/GaOvSNhTe+4T5OyjibJypOHmPOZIQv7hgMauS22MUcLISwSu/9jWro0D/aSPkd1di3QL9H15x/yKFvXpAO/PxbEU1NqSyhIzqqugLDTOi6J6SzF1ofjmz3oolr5eTVovj6ZoIfcW/gvQs0quHlL7SWP3GdS2Ug57qeO+RoOMqdmHyTwjLXHDDZ/9KkRpzHMUEl8HtxA/NACOp/7uSljBtYoaDeeUhITws1r67G6LyuYUkIZES1azHJ5efy7wW5qc3pRb7+uayhdIGhmyFJbyXJyFcHbQRtNvroE2VHe0BXitouWVT31uaW6Pk81U6elxFQYLvf9hFpGQSsAMErYcGbbNjrlEssrom1spuGJXeftQ57Bc6ICDqXwOx9Qk9JhRJiGjJkEQ1dj0OZsEorYskjDYm/7BFt1oCGCVyFjBE0wQFbUHr1tRDi+f+XOage3FkXmO3+OF+l4Le/VPliO4/SUwc1Yf4gC3bATxqxMP378UsBNN/+bUgdcbYX6SSpeDBVz5DaKXLhaLaKHOe/v7QPF5H/luFjmku5wQY69Xn+eueL9RTH3VHtRL9EZOtf0wEhrhUaGfeaWWppItWRz/0i13F7D0c+rZofLQus2WG+syebTWNBJeumSI0xEGnu+xNNxWUs3KRje2W5dtJcgAhmi8Uc2B8XlZSYzbjJFRHVgNddEjvNOM0l3T19d5AWdTUygIEo85hNkmf4rKaWGsZYDfE44ojJi4eVIS55VWTXC50aNmYtt8sp4IucUFtXLP7R/rT94yP8anonWvVbSGS5YNLIEg595gsifuhiVc2nA15v1XDVZMA7m X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(66946007)(5660300002)(2906002)(76116006)(8676002)(4326008)(33656002)(66556008)(508600001)(66476007)(8936002)(66446008)(64756008)(38100700002)(316002)(122000001)(966005)(6486002)(4744005)(186003)(36756003)(86362001)(2616005)(71200400001)(26005)(6916009)(6512007)(6506007)(54906003)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6549 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 58c70a91-44c9-49db-6427-08da2cedca72 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7acEtjr9ShExe0C7xcVPS0v3OaEHMQ8CGEjmhbVRiaelyK0frQTGZSMiC78IFRfVhk94c2LiA+NRXi0oxRP9SCSyJFkeZmJMG6sREdNZpKufNSJ5T60lMVSlUp1g8Q7lZyTLGGfey0aMN9URe6rJBgYo3EIG/GRw42Hin6dvwcfFR1KqTHmZjRfSvsgUO87ynHBN7mLCqdHyOjKAkH+90OAquFdSZLLOloyKme6DSW3TfvrOM6wSWFwurhJ5zDzoLXeYjrCd5h7QWJJ1s+zJL3Vay8YsWIaaNTYYWZ/+Lsms1N7Bvpsj1/Mae5Dxhz9e3AvLxvqNqwiR6dgRv2Noph5ilEanHfBRd5t7YRBsBQ2/CqlSTE8YUcq88ILqOfBDqbs7viIB6Ms9h7zey4rz9duTdJqt/87xN7dNZrzbGhJNed3s3nUeE+psu4drrsW0g7+tOixKUz03WGiRGI2l6QsMeHT5Fb6VGGHVYLbmjqOmtJe+EpUP5iez7d8CRZjXOyYNgYfLejH6sBYDb0SXIA1E7xArgEHGiKa+mGNo1sWP94YPH5FGe4nwEFFP0gaMwN3R63vpFEfWu4sbDC0qNJgF/id+orfIazzjJreCF4rie1Y8X+qIc/JIyqBV9x8zS6tJoqCyB2ufldxCLBXNDuEgiZe3h7ddo6gLiuae1z+g0/+9uXV7wQg8vUA8nOiwintRYqBIPrOkzWIaK6O9pvvbRg6kvuEP1Ze8RfRj8/OKt+tPpD1WnzmTodBBqWO6N1lHmZ2QxFjVN039PmXQAw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(82310400005)(33656002)(54906003)(8676002)(6862004)(4326008)(86362001)(356005)(2906002)(4744005)(316002)(966005)(6486002)(36756003)(5660300002)(70586007)(8936002)(70206006)(508600001)(53546011)(186003)(336012)(2616005)(47076005)(26005)(6506007)(107886003)(81166007)(6512007)(36860700001)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:15:11.9966 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3dfa394-a002-460f-866d-08da2cedcf2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4003 > On 29 Apr 2022, at 21:57, Stefano Stabellini wro= te: >=20 > From: Stefano Stabellini >=20 > When the length of the string is zero of_property_read_string should > return -ENODATA according to the description of the function. >=20 > However, of_property_read_string doesn't check prop->length. If > prop->length is zero, return -ENODATA. >=20 > Without this patch the following command in u-boot: >=20 > fdt set /chosen/node property-name >=20 > results in of_property_read_string returning -EILSEQ when attempting to > read property-name. With this patch, it returns -ENODATA as expected. >=20 > This commit is a backport of: > https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@ke= rnel.org/ >=20 > Signed-off-by: Stefano Stabellini Reviewed-by: Luca Fancellu > --- > Changes in v5: > - backport from Linux, I don't have the commit id yet so I used an LKML > link instead for now From xen-devel-bounces@lists.xenproject.org Tue May 03 10:25:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319412.539652 (Exim 4.92) (envelope-from ) id 1nlpiZ-0007B7-Vx; Tue, 03 May 2022 10:25:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319412.539652; Tue, 03 May 2022 10:25:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpiZ-0007B0-SV; Tue, 03 May 2022 10:25:19 +0000 Received: by outflank-mailman (input) for mailman id 319412; Tue, 03 May 2022 10:25:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpiY-0007Au-Gs for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:25:18 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 527e869e-cacb-11ec-a406-831a346695d4; Tue, 03 May 2022 12:25:16 +0200 (CEST) Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 06:25:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB4932.namprd03.prod.outlook.com (2603:10b6:408:7c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:25:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:25:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 527e869e-cacb-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651573516; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+pupD2a5y4pYFoFDh9jKRKip7/uuEXcjX5fTrjlfPsQ=; b=ZfNDTnd/HC4XOehWsGU7viIvjXGlm0S6wrvNRp6qsALJVFmLbqzYGzGz 8O+zQFVklBbX5lWjLegKp2Jz8gXbPRNl6skNCc7uPc0GUsszWRSCYsSwJ L9b/ypbFid5ZpxhPAksHfsHCUwFlNSAkvpDVJB1ryZymyA0IqH6+pvJ6c s=; X-IronPort-RemoteIP: 104.47.51.44 X-IronPort-MID: 70859850 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FpixEq2oqBXnH3J4fPbD5aRwkn2cJEfYwER7XKvMYLTBsI5bp2dSm zRNDGDXOP7ZYjTzf4xzaYm+9UsGvp/Qydc1SAFlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw2oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1oh8G/bwQnY5b3s98xDhh4NyUnHJRZreqvzXiX6aR/zmXgWl60mbBEKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82aBfmWjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGvLmwI9Qr9SawfykHUkwNt9+bRO4DLeOTTefdtm2OYq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0ZjZLO+gz6QXIwKyN5Q+cXjcAVmQZNIBgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:bHy2Sa1B5m7N1xvFn3HH/wqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60Q5iApIs+MPP+UpgNdNvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,194,1647316800"; d="scan'208";a="70859850" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MsWVInaWfZ7PtBBYZZvTMWRvmZxkAallbtPQz5abw6jZdzktjutMWWK7A5abk0hbngO8oUSIZGiUQGOcbVet9i0zCIs14JwkVrszV2VRLUdvcav94v6vod+ZTVZZ2BeuNEWdssZO5GjRlSpIISef5ASiZ37I9dUYKFk+lB7YvFgKr2sEOomRFd4WV7Lh0V5+73Gmcl7qYAo1XvK4Bm0eIkAWW7K1MtogOYIG2fWYunLsuzIVH6798NfIHrtxwh8Bsa1xCT5If29soycVOunjwVSJR6pdmZuMh+s+n05K7UqIEt7zCyNvFGF5Se1o1/Ht7qquxiz/LccVE5ziv5Y+hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T97w/gdwNAbA5j4mcu7BDnDUPb8/a0dHPURY2jYwcLo=; b=DOcVe0qkKNPndwP0pYFYU2w4lPLO2UVeRqHPVQzG0BIOFw6lSTbpT7ClnfWpKxNJhfUMb0QTOLxSZRPIjYanE/tCeKwPsFPlZQTDm3XMP9qMr5Yr/i48VWUXJdjcvIlblOe2FhmzRPSa5q+IHkU+ib3uimtV2WsItNd/GUW5WVoObc3hqrmuvYpTZ5m8dzzaoKUHFIlCv2l3DLjI/eQuxW6PRn+l5hlqsn7dvAox91dR5qVeXz2LMRHDzaurU1mfCBGPNVrJ/PYFfck1jSi31TP5RZvPqfhJuk1yYejtfIrkk5+f6JyNJ7M9xTLhr2yb2z7X8iZFniP6kkHM272gAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T97w/gdwNAbA5j4mcu7BDnDUPb8/a0dHPURY2jYwcLo=; b=FKUOr86TvUfZHn175qwaoAYpRBZMYs4k9tcPYTeDtDPFcPc6hrB4mLdQ9fFBnzaQR1q9zcCuwccp7OCD327VsX3qPi1AELrwb/pr5QClzvnUjlwOfvR7y+eYxDTWBSAbo7zlSWMpTXc5FoXHNczgM0avLISilmz3ke8WJ8lTb6Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 12:25:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map() Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0042.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3e::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54518ef7-9078-4e46-be36-08da2cef33ca X-MS-TrafficTypeDiagnostic: BN8PR03MB4932:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3o+QzO9dR8C7SIq61V0eUULok+BxA5/azVvs6gz5YZubArcN70/czFMv5/3u1R0MdxeSnHDuLfgyfjWy0MUivTpqamDGj8BxX6X1jEnDd0mjONW4ZiGbq4lN2Di0YNN4I8pJEPqi/oZ61mtq6HFdwK6CDzfAf9ytNJBlI7zs5sKczXpXm4f/v9UbYa7b73lMs3zDKXBxnb4LPFMzj8ZkQPKAT32FZYT6cs1DshRztStjQiMjz8ZIxNgX6t5yKTFtrYsFakNlKbGnKpSbTMdgHOdGDnaWivFSqcHpRN6vj8lOHNi2zTCM5f+P3ge6se2x4tolD6qFcfh7joDEBJuS/QVC7r8X/rnZJtd7mYahHjyE2D4h9cw3GojdevsrKdIeCqXebD7v3aqz8jLTebUVKLQB3BaszpZ9YGLUCsO1Kqzw8r0tn3Ut9KU0EDdFmNWX75egSYd+kNQx5IHNM139GKK5BHBGpK+8Y6RkkTpsfSMJQ7k+FNmK1MK0f4rrjCl1m6mCOGhFfEpYlSn7YsxMYItBkIzUgxkEepBwdaKk3i8W5Q7xNYhxsF94oMPRVjBD8YDBQfVd/jt6uNYrs4DZW9HIA8YAuPIP3RmxmI2EhScs4/IrG14hd+Wr+6vDMkq5w3Lj8x3xWRPP3aS+oyh2FA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(26005)(6512007)(9686003)(6506007)(186003)(54906003)(86362001)(82960400001)(8936002)(4326008)(66556008)(66946007)(8676002)(66476007)(6486002)(6666004)(2906002)(316002)(508600001)(5660300002)(4744005)(38100700002)(85182001)(33716001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dySmJXcDBjTTA4cDdmZXV5cU1yTE1Ub2NLNXEzN2lxaHZicDQvYjdxemdV?= =?utf-8?B?bzA5ajFyRitVTFRWdzJjNTNBOHcySVBjTmRDNjN5U1B1SmRHS1h2b2s5ZU1t?= =?utf-8?B?QnRuVlo4QXBPaGdjNUtTMzY1dDFaeGRYQWxLeE9rM2VSeUNnc0tlRll1ZEFz?= =?utf-8?B?U1FveXVHQmpPMUNONEx3bnh1dlRRZmpWTXk1cmplTCtxTWgrZHFSNU0xZUFm?= =?utf-8?B?dmJCejdkYUtHVm9NNzN5R0tEd3VESDJXckc3MGFWcURIanZ4VE5ZSHZSV3BQ?= =?utf-8?B?N1ZjYWRXc0VzSUo4SGhwZHljbUc5bmhMem0zY0twZEo2V0tFcWtoVWI0UWpX?= =?utf-8?B?V1VHQ3R1aWdJTFRENUgrRURwM1JaRldaLzMyZ1c1RlcxajRoSWRndFdqUUZQ?= =?utf-8?B?VkNJU2JJNWRRWis1bWhCUlMrcmJLVXZJOHFQYU55NktEemFsSjRPRHkwejNY?= =?utf-8?B?LzZKdDJNbzdGeEkrRFVGN2FpVk9rbFRUb3V5Ui90WG1wUURXdHZiWkh0aU5v?= =?utf-8?B?ZVNJbHU3RmFxM1BKLytFejdERGE1RHlUZ1NIMWVYQ2pJMlNCSTg1MWE0Qkt5?= =?utf-8?B?TnFzQzRhUWRWSENXNUxzRk0xZ2lHSVJST3hYTTZ0dHMydUZPcnRWOER0WllN?= =?utf-8?B?aEo3b0w2T0cxcUhXU0ZmL2w3MjJaOHNWZG9MWXM1bWpWYml5L1ZHS3pjSW1a?= =?utf-8?B?bEFqVkZHTXhzbmtOQm5pbUVVMlM4a3dNUHQzQkp1OWlzTjFJRlV3dzE3aVBp?= =?utf-8?B?MFlQcDVpQVEwMmRTcjVmT2I0cG1pbzJsSUV5ZnNBM1Y0d2xKTklOT1AwTWN0?= =?utf-8?B?NTlUQmtxK1hTd0hjZlg1SGRGNXpnSzhMK1VZTTJ2aG55cDFaRmRSK3JnWG1L?= =?utf-8?B?OXY3YnhtMVBaeWcyd0lLRVQ3UnFqK2FXNVlNRUltV25JNWdDV0lHeVJmWUtv?= =?utf-8?B?a0R1R3RkbDNPbVRNS1psN09WbTdzSXNqSFplLzJzYjFwc0srN1daQTkrbFg5?= =?utf-8?B?R1hZbEZLZHBrZWdKUnBVR2NERWovRnVpN2lxVDFRLzlxM1ZsckV1WWRRRnU4?= =?utf-8?B?MVdhTFNzM0RtY0NidVk0YlF1M051Y0NzRlYrditkQitTelFIaGR3OEFiUFhF?= =?utf-8?B?dzhEQnRBL0VJZWIyVmxRM284amt2eGpSd0cvQmlzYW83MVBFazM1QWtvbjA2?= =?utf-8?B?UVVIdllFQU1xcnVDdzJPeXhCN253aFBIZTNvRUVGR1NrY2hxMEd3VkpMWXR5?= =?utf-8?B?aWR2NmhjL1UxU21jSFhmaDBqRkhJYndRNTJhb2k5aVFxYjZXMEtKUm1ZRm9T?= =?utf-8?B?V0wzTXZoalU5clBGTW1LVTduTXFwR0kvNDNGOFh6ZVFUV09WYWR3NlNEaDhr?= =?utf-8?B?VzFMN09aSWhqVFpXZzVhZHM2VUFDVWdXWUVteVZNcFhTb1FDNlZPYzVzUHM0?= =?utf-8?B?SUpPaFNHN1hoYXVKRWpUeTNGaXdPUEVaN2RWR1U0c1NBRTNwQnZtSkE4Y0R2?= =?utf-8?B?aVlCbkhhY2xhSzlLRVhXWE5acEpxMmpjTFlpWEFQSE5MdWNTZmppWk5PcWtV?= =?utf-8?B?cm4yaFFLeUdsOHNLQ2l2eFpkZ2dLMVgxR2lIeDZ1U0I3WVhXbDlSQ2hGMzBP?= =?utf-8?B?NUpjeVNNSzVPczZxTEovb0J4VUFGKzlwSnFNcU9SOFVXWlF0aDYxc2loR0p4?= =?utf-8?B?Q28wZVRCaDJuMDY1ZmsvejVIaWx6bWN5Mkh4eGVDV1NaTy85VVVwNW4xY1Yv?= =?utf-8?B?cEEzTjdTa08yeU1BTkNXN3kvK3lNY0RteStKeUxTNndsWlVVb29yWGJNWEph?= =?utf-8?B?NGRWTkU4Ynkva2lYUHQ5SkR4a0p4RVVvQVJ6N21HZWxKeCtpcmVIdVJHWlFC?= =?utf-8?B?SlV3SEowOTdPMG5ETGY0YVd4d3Mrck1Ob3BIK3F0bWI3M3BLaVFWMFlZVVhD?= =?utf-8?B?NGhkaTdaemtKUUVsWVk0WWl6ejhmN1d0L08xbUxOOFpMVndwK3E2N1VhajA4?= =?utf-8?B?bTYrWWlSWE00MlVvTU9wWVBxZmJHZThubERiWVE0SDdPMFJtaTZUb1d6eE1C?= =?utf-8?B?QkVUNEZMaklDeUpvcCtzU2hBN3RlWkk1K201THhQU3ZWc2k1UWViclZ6eWE3?= =?utf-8?B?RHBvTjhUclhPQXBvTU1RcjJtYmdBY2VvZlR5TzZQNTgzSGd5YTloRWhlY1Bq?= =?utf-8?B?ekg0Zld6M1FZZEtwSDVRZkI3ekJ4bFZPRER2bTgyVHVDamxUQ283eDZhRmN6?= =?utf-8?B?aFZsa3d0aHdLdnBxZ3NPQnBWTmJwTldBM2Y2Um52cEdmbERBalhrR3RRMFlB?= =?utf-8?B?L1F5SEk5V0VIU3ZncFNOcGtoWFJ3TjRWdWh4bEs0RTIyWmt2STJzVUNjL1k4?= =?utf-8?Q?xyYRpI55jb2IpKQc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54518ef7-9078-4e46-be36-08da2cef33ca X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:25:10.5327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F6iWxpyV8BxD3PLZkyVwgs9Cguty0n+As2VoKPsU3crN8iHXw1Dl/Xh8mzUQirru26Zwhrhd75OlBVjuSHEaEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4932 On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: > As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > similar to flush") there's no need anymore to have a loop here. > > Suggested-by: Roger Pau Monné > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné I wonder whether we should have a macro to ignore returns from __must_check attributed functions. Ie: #define IGNORE_RETURN(exp) while ( exp ) break; As to avoid confusion (and having to reason) whether the usage of while is correct. I always find it confusing to assert such loop expressions are correct. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 10:25:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319417.539663 (Exim 4.92) (envelope-from ) id 1nlpj6-0007gl-9M; Tue, 03 May 2022 10:25:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319417.539663; Tue, 03 May 2022 10:25:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpj6-0007ge-57; Tue, 03 May 2022 10:25:52 +0000 Received: by outflank-mailman (input) for mailman id 319417; Tue, 03 May 2022 10:25:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpj5-0007WO-4j for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:25:51 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe02::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 668149eb-cacb-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 12:25:49 +0200 (CEST) Received: from DU2P250CA0017.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::22) by VI1PR0801MB1965.eurprd08.prod.outlook.com (2603:10a6:800:8d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 3 May 2022 10:25:46 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::5) by DU2P250CA0017.outlook.office365.com (2603:10a6:10:231::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Tue, 3 May 2022 10:25:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:25:45 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 03 May 2022 10:25:45 +0000 Received: from bd2c4735d04e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 64221533-3624-495C-A3E6-30D2CAF54C7F.1; Tue, 03 May 2022 10:25:39 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd2c4735d04e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 10:25:39 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by AM8PR08MB6497.eurprd08.prod.outlook.com (2603:10a6:20b:316::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:25:38 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:25:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 668149eb-cacb-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FMZGxOg94zomk4PAKXFa/46p6dkusn9ph7iiR1jmhz/pjQdAnT8hNLXnVbc15ZkqqaJVbmf6ccxrE69uuQNXiXzU9NNZXhpViPaMy0fnOs1Vyl5CIlu/I144X17ADk+rVe99gWdNfWRzleJGSTDql4erSdSQpqJmrTBuWnVvXVcJJ4hpafeY4XSPs/Fnmy2J2sR9REJ0txC3MlgtmGgD9A6hpKn4dmaqJaF5ihOA8O9lzKuPPTepWMostUTc7F+dVAoHC1vFwcuBLwqeZfGs1vrX94+O6WovUztqXOHVig/MYnCQTEjlBNuB/QIXAj7NIRRAuUCF/urKGNKG8bDcWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jIJgZiW8qVdJdb7jYloaAp5TeQKFuG7Ix9pelLWAk0Q=; b=oM/m1BOP83uWwxFTMgbzhnZMA3+4jEG28Wdb2WTsATx8rbp9ebv1RBBISlgUZ5p3Rn/qivVyrZq+ZVmgvOkA/t25Uc0copglpNjeBdaXg90qgVqGugH5ZxR8Le1Csav9cRR/MQOPTL/N0I3mm3PP/EWj+9paYiuz5Q87u5Ap4zGCtjoNeNT7sHdCHjqCfErddT4UPPSWAS3moOJAZpeQNOpa9BvdUUaqPg7Tr1d1KSPQMXzRQQXPhiL3ETg/mnrINrEbbRL/oY63lwTVjz298ePw7birEHHHxzegvJ2HEDYZpAhIEoHG3JSVbMnSodY56nJfPGyolmhFj1Gl7fc0ww== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jIJgZiW8qVdJdb7jYloaAp5TeQKFuG7Ix9pelLWAk0Q=; b=Bv3xBetEI1metsW8UyrYZ4RAsM4bn/Ll72YPasGBs6K8bR8tRF1VsckM6TSJkNTGhU6CFg5to4+3GB68KSQNZeA99omZU1M2g3Q17EldzpjfAP5QF/Fv8NY5j6BBFUmBymPdEma8foTjCpw1tSuVShWnCN6RZDCQk4EAvr74RPg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 4306fa1c9320a637 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vm9jt7Mj1y0y/54IrHyk5h6xp8FO14LWxYgqLSYbPoj7sNVY0zJKA9Xa/kz7ICZ/fW0wSWkVrcZH6hSDtbJx3+Hqoc6NQHRX5EsAPiWi8+OSFw2C37oEAl8MoHgLf5zytIvKRBaQGG3YL1gYRaiWw/03wE6rdgJqNskbuZzH01DnWXC7ZUlaW6VzYuc0RyQeIXMDCSrg73bzT4JqUwl+bRv36FZi4FrILke4XfF6FFxYVUHV39xV++U/72wh6tFZ7wGBa9C24/SuT3FJs/WVpKSlT6IKJov9hVWVWzN3ysbXEFjjQafBUIyGvNP8hfgPhyEvZNtsXxJY/pjmZQ7lrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jIJgZiW8qVdJdb7jYloaAp5TeQKFuG7Ix9pelLWAk0Q=; b=MBst2X7s35riN4UF5Op+vqTTsX9JdUJOpE89OM7SZ0b6olnHqGRBMHL/wyEvYXGAMA7J6vbVk4wX65g7rjpBtKjpINQKLlwc+yi4EhF9sGT6MHA0jcQduKmXAJW9gwQlhDisZRDH3FQzF9ddWpYa13bpZhtisJU4azJJ8bWRD8UHbD3H70bSGMaivpx9Btnn5Gp10BC85iEhRJBKndLT1O2+SaSVn+rtA6PSykDoyy0bTJy6SnTPG8h7wb0T1t+tJ0Y9cWxDU2+SOZhjnI+DsczX/6Jiaa2gCdPupEpOcO1DELBAHQyUC4RFUpydXJTYejGCeDsV+3ZWFL2qM15rcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jIJgZiW8qVdJdb7jYloaAp5TeQKFuG7Ix9pelLWAk0Q=; b=Bv3xBetEI1metsW8UyrYZ4RAsM4bn/Ll72YPasGBs6K8bR8tRF1VsckM6TSJkNTGhU6CFg5to4+3GB68KSQNZeA99omZU1M2g3Q17EldzpjfAP5QF/Fv8NY5j6BBFUmBymPdEma8foTjCpw1tSuVShWnCN6RZDCQk4EAvr74RPg= From: Luca Fancellu To: Stefano Stabellini CC: xen-devel , Juergen Gross , Bertrand Marquis , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Stefano Stabellini Subject: Re: [PATCH v5 2/7] xen/arm: implement domU extended regions Thread-Topic: [PATCH v5 2/7] xen/arm: implement domU extended regions Thread-Index: AQHYXAvYExyIwYkP/U2uZo8uX8GZxK0M+CqA Date: Tue, 3 May 2022 10:25:38 +0000 Message-ID: <7E2A9578-C5B6-4D2F-8BE2-368511DE75AE@arm.com> References: <20220429205732.2030094-2-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-2-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 851f8829-ac45-4b5f-abb5-08da2cef48dc x-ms-traffictypediagnostic: AM8PR08MB6497:EE_|DBAEUR03FT041:EE_|VI1PR0801MB1965:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: yMF/H+SaVv81GrWWXRb/lQo9sQIIWlx/hWbgO66seZWr/aj9Gluvf9SnrX1TSYZYZY/G0dHYHcZ6fDb3R87NS4qVBrgBoHPEHtfVa34WqKDcT6691Y///bvEGGMev2xU8apnEPE4AzLnmjDMSdFCUSj2H61h8uHMc3aDef2pIcFG8vnCg99IvV0IlWzLuN0NqB4trt9wSKCUD851+4VC12ZnIY5vbjZzaM8aZ+bmDi+qk0D6Y2ELtghSZSvMKzr9PpRgkiKYLV9za5PZFj8A3fQd9l9jCHm+R+0oKJSfl7x7uot9GFKVJDWsYhxVLSh2bQWZ7Q88/Swt74St3UeS/GoZzGllWcy1E3dL5YWd2HWwip8a/jWmqFcc9dCQAHfJhIZpnjR4ARxRkIkhxBG+IBo35+ewnzrPiahduT1URA/CaFgBh3Ki88/Qih6qxpKjOLCzMyPhC6lDvF+CpQBxjDmDAVM9uVjQ093bv+lcU9zrEankbiLkkNDlmrEgS9cqgkQVGGQVB32dvBLytoLiu8MWVN8WBappq7c6hnRwzaKCUVStOdJyXBSFnNn9rAJa41e7k/rgcLzaF34C5KzxGuYp3RRTDrwua4/sG0Porcwg2LzafUqgnNJ0J07svEsll3SlHxm7rsH3L6xozYTZk2Tp9I0BaHuoxgP7jYryPxfZgU3yzIGe2Iu++8PoIT9mL782ka+uE7uMHExCrloey4pmFW5E/zQYS+PGcqKpvxz7jZTN9p+39tdItVnqPcSu X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66446008)(64756008)(66946007)(66556008)(33656002)(83380400001)(4326008)(76116006)(8676002)(6916009)(54906003)(2616005)(186003)(316002)(2906002)(6512007)(26005)(86362001)(53546011)(6506007)(71200400001)(36756003)(5660300002)(38100700002)(6486002)(122000001)(38070700005)(508600001)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6497 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b3dd7550-7f57-4b2e-01c7-08da2cef44a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ENh8u0+dJoh9Ve8lFO8QW/m0EPrLTrpxJw1Xx1LQehipoDRkLGyskGqDSGxBFfk3LDusOXrWy5u3riI6H47QMzojQsholrf+O2qUxEJiLwj05VZvDvEIoe6gwcgMqrtVNJnJC80CyZdkSWRSixkWIl0EX8zFOWTdmwNt9W/n2im2qS9wsFU+5xLVruc95+YPbKEQAx5gNlJInSU6C2BED80y/NE/zsTpw38SKwvhMTE2R7ajFgRBargmgiTZI26e589Jv4mPYFH1P4EXgoxfWtO370jqFeIXTS+Lwd2MYfX/Lc4zBs3KDKCe+kTCkWQUHLeWuFS/I2As8QrtRav0ZQGQiOs9PELfE87Ed91BWXTLgP/W29XBDaX+rEtcaeZUjdjw5KUl9gGI7WPcqx1tRBtuLddDGHJfRuWqQ/MYrjPr3yixoNvURwHZXNhNuU9d/jrZPtoMgZiK5liuuucaeBMrFmiLL6/BGTPQGKF2ypPauactSqtG0u9JENqKrqbhz2io0gheYUDEC9maImHot0zGT47Gz/1a3eww5PdmJrtlQQJ8fe+5ubrHHqHOmNUuAUAzKGwuOi6/j2HXVaCsXmTUQVyDi1+QamJp0kIWzEHv6FRjqG/WsY7IsueSJtHakhN3vhK2uE39EkwMAZgJstEcM2zqp4eOpjKkgMhGHtQzmsHrmHTKEs8fOxwIo7ix X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(26005)(33656002)(336012)(81166007)(36756003)(356005)(6486002)(53546011)(6512007)(6506007)(508600001)(186003)(2616005)(40460700003)(83380400001)(36860700001)(47076005)(54906003)(107886003)(70586007)(8676002)(70206006)(6862004)(4326008)(86362001)(2906002)(5660300002)(8936002)(316002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:25:45.7573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 851f8829-ac45-4b5f-abb5-08da2cef48dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1965 DQoNCj4gT24gMjkgQXByIDIwMjIsIGF0IDIxOjU3LCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gRnJvbTogU3RlZmFubyBTdGFiZWxsaW5p IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gDQo+IEltcGxlbWVudCBleHRlbmRl ZCByZWdpb25zIGZvciBkb20wbGVzcyBkb21Vcy4gVGhlIGltcGxlbWVudGF0aW9uIGlzDQo+IGJh c2VkIG9uIHRoZSBsaWJ4bCBpbXBsZW1lbnRhdGlvbi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQo+IC0tLQ0K PiBDaGFuZ2VzIGluIHY1Og0KPiAtIHByaW50IHRoZSBkb21haW4NCj4gLSBjb2Rpbmcgc3R5bGUN Cj4gLSBzaW1wbGlmeSB0aGUgY29kZSBpbiBmaW5kX2RvbVVfaG9sZXMNCj4gLSByZXR1cm4gZXJy b3IgaWYgbm8gcmVnaW9ucyBhbGxvY2F0ZWQgaW4gZmluZF9kb21VX2hvbGVzDQo+IC0gdXNlIFJP VU5EVVANCj4gLSB1aW50NjRfdC9wYWRkcl90DQo+IC0tLQ0KPiB4ZW4vYXJjaC9hcm0vZG9tYWlu X2J1aWxkLmMgfCA1NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tDQo+IDEg ZmlsZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21h aW5fYnVpbGQuYw0KPiBpbmRleCA4YmUwMTY3OGRlLi4zNGQzZTVjZTMwIDEwMDY0NA0KPiAtLS0g YS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFp bl9idWlsZC5jDQo+IEBAIC0xMzI0LDYgKzEzMjQsMzcgQEAgb3V0Og0KPiAgICAgcmV0dXJuIHJl czsNCj4gfQ0KPiANCj4gK3N0YXRpYyBpbnQgX19pbml0IGZpbmRfZG9tVV9ob2xlcyhjb25zdCBz dHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cnVjdCBtZW1pbmZvICpleHRfcmVnaW9ucykNCj4gK3sNCj4gKyAgICB1bnNpZ25l ZCBpbnQgaTsNCj4gKyAgICBwYWRkcl90IGJhbmtlbmQ7DQo+ICsgICAgY29uc3QgcGFkZHJfdCBi YW5rYmFzZVtdID0gR1VFU1RfUkFNX0JBTktfQkFTRVM7DQo+ICsgICAgY29uc3QgcGFkZHJfdCBi YW5rc2l6ZVtdID0gR1VFU1RfUkFNX0JBTktfU0laRVM7DQo+ICsgICAgaW50IHJlcyA9IC1FTk9F TlQ7DQo+ICsNCj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IEdVRVNUX1JBTV9CQU5LUzsgaSsrICkN Cj4gKyAgICB7DQo+ICsgICAgICAgIHN0cnVjdCBtZW1iYW5rICpleHRfYmFuayA9ICYoZXh0X3Jl Z2lvbnMtPmJhbmtbZXh0X3JlZ2lvbnMtPm5yX2JhbmtzXSk7DQo+ICsNCj4gKyAgICAgICAgZXh0 X2JhbmstPnN0YXJ0ID0gUk9VTkRVUChiYW5rYmFzZVtpXSArIGtpbmZvLT5tZW0uYmFua1tpXS5z aXplLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNaXzJNKTsNCg0KTklU OiB0aGVyZSBpcyBubyBuZWVkIGFueW1vcmUgdG8gYnJlYWsgdGhlIGxpbmUgYXMgU1pfMk0gd2ls bCBmaXQgaW4gdGhlIGxpbmUgbGVuZ3RoDQoNCj4gKw0KPiArICAgICAgICBiYW5rZW5kID0gfjBV TEwgPj4gKDY0IC0gcDJtX2lwYV9iaXRzKTsNCj4gKyAgICAgICAgYmFua2VuZCA9IG1pbihiYW5r ZW5kLCBiYW5rYmFzZVtpXSArIGJhbmtzaXplW2ldIC0gMSk7DQo+ICsgICAgICAgIGlmICggYmFu a2VuZCA+IGV4dF9iYW5rLT5zdGFydCApDQo+ICsgICAgICAgICAgICBleHRfYmFuay0+c2l6ZSA9 IGJhbmtlbmQgLSBleHRfYmFuay0+c3RhcnQgKyAxOw0KPiArDQo+ICsgICAgICAgIC8qIDY0TUIg aXMgdGhlIG1pbmltdW0gc2l6ZSBvZiBhbiBleHRlbmRlZCByZWdpb24gKi8NCj4gKyAgICAgICAg aWYgKCBleHRfYmFuay0+c2l6ZSA8IE1CKDY0KSApDQo+ICsgICAgICAgICAgICBjb250aW51ZTsN Cj4gKyAgICAgICAgZXh0X3JlZ2lvbnMtPm5yX2JhbmtzKys7DQo+ICsgICAgICAgIHJlcyA9IDA7 DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgcmV0dXJuIHJlczsNCj4gK30NCj4gKw0KPiBzdGF0aWMg aW50IF9faW5pdCBtYWtlX2h5cGVydmlzb3Jfbm9kZShzdHJ1Y3QgZG9tYWluICpkLA0KPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qga2VybmVsX2lu Zm8gKmtpbmZvLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQg YWRkcmNlbGxzLCBpbnQgc2l6ZWNlbGxzKQ0KPiBAQCAtMTM2MCwxMiArMTM5MSwxMyBAQCBzdGF0 aWMgaW50IF9faW5pdCBtYWtlX2h5cGVydmlzb3Jfbm9kZShzdHJ1Y3QgZG9tYWluICpkLA0KPiAN Cj4gICAgIGlmICggIW9wdF9leHRfcmVnaW9ucyApDQo+ICAgICB7DQo+IC0gICAgICAgIHByaW50 ayhYRU5MT0dfSU5GTyAiVGhlIGV4dGVuZGVkIHJlZ2lvbnMgc3VwcG9ydCBpcyBkaXNhYmxlZFxu Iik7DQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfSU5GTyAiJXBkOiBleHRlbmRlZCByZWdpb25z IHN1cHBvcnQgaXMgZGlzYWJsZWRcbiIsIGQpOw0KPiAgICAgICAgIG5yX2V4dF9yZWdpb25zID0g MDsNCj4gICAgIH0NCj4gICAgIGVsc2UgaWYgKCBpc18zMmJpdF9kb21haW4oZCkgKQ0KPiAgICAg ew0KPiAtICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgIlRoZSBleHRlbmRlZCByZWdpb25z IGFyZSBvbmx5IHN1cHBvcnRlZCBmb3IgNjQtYml0IGd1ZXN0IGN1cnJlbnRseVxuIik7DQo+ICsg ICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyAiJXBkOiBleHRlbmRlZCByZWdpb25zIGFyZSBv bmx5IHN1cHBvcnRlZCBmb3IgNjQtYml0IGd1ZXN0IGN1cnJlbnRseVxuIiwNCj4gKyAgICAgICAg ICAgICAgIGQpOw0KDQpOSVQ6IFNvbWV0aGluZyBsaWtlIHRoYXQgd29u4oCZdCBleGNlZWQgODAg Y2hhcnM6DQogICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORw0KICAgICAgICAgICAgICAgICAg IiVwZDogZXh0ZW5kZWQgcmVnaW9ucyBub3Qgc3VwcG9ydGVkIGZvciAzMi1iaXQgZ3Vlc3RzXG4i LCBkKTsNCg0KDQpSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0u Y29tPg== From xen-devel-bounces@lists.xenproject.org Tue May 03 10:35:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:35:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319433.539675 (Exim 4.92) (envelope-from ) id 1nlprw-0000wc-4r; Tue, 03 May 2022 10:35:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319433.539675; Tue, 03 May 2022 10:35:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlprw-0000wV-1i; Tue, 03 May 2022 10:35:00 +0000 Received: by outflank-mailman (input) for mailman id 319433; Tue, 03 May 2022 10:34:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpru-0000wP-50 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:34:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1b::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad099603-cacc-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 12:34:57 +0200 (CEST) Received: from AS8P251CA0026.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::17) by DB9PR08MB6794.eurprd08.prod.outlook.com (2603:10a6:10:2a9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:34:50 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::ac) by AS8P251CA0026.outlook.office365.com (2603:10a6:20b:2f2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Tue, 3 May 2022 10:34:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:34:49 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Tue, 03 May 2022 10:34:49 +0000 Received: from 6d44f2fb7666.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AEAA4B0D-3FAB-4976-8EC0-CB83754B9F4E.1; Tue, 03 May 2022 10:34:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6d44f2fb7666.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 10:34:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB7183.eurprd08.prod.outlook.com (2603:10a6:20b:3de::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 10:34:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Tue, 3 May 2022 10:34:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad099603-cacc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hbuhjdpFRYRD9+ktCNV4mVV68+WGYsD9imWKhM7fa5NfHR0mAKCDP4KsXGq4r8A6qadielIO+aPZMTjpxVH9fTsKGMe2xOh9/1CybNhEnS4TCgQGSlYURrf+JCcQXFJg5RwnSlFwXr9F/sOVwLQJs+jWtJjsTbn6J/8jDiGR0JT2+mbOSTo6iyKynyxm1lPNM4Dj6CYfpDzvvf8f1N5hPJnV5OKR49RJJ4X46U8Sortn7DYxO4iO9kY0+PHcwth9W3G9iaIoqylURQ391BnGRs+YrR47qNkXxV6xkko41KR9aBQ8pSY0BEbxY9LoLsXlKsSNKpgZ47nu3D5R/jEgmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3vWs1doxMo9fgyOrrbLJqWRH16n928hwX3XuATQuu8=; b=b2ndCx4TRvggiR+8+IPAK0iyuTNdkzMEsjUkQ7wMs7svggR9uhMhQvlnKTMT8tyrVAssUfC0KKhMQS1XeC49vF/y7sSYAQZfE3mq9WTUXGmHr8hc34VYPJF7b3lH8CizKdg3oxK4K2Ab1vjfk9Lt+MefKlzs6zdm5KbKUDOecYwDjN4+OBf9nGL256j7TgYCR99CBUToH4PBLoirxqldv9VihQjWZCtBNVvldFt7YaxOW58K2l35yAlug7jGl3ajdGqChJW07VRXyDGAnM1AhwPoVMCqqOECxQObQm8UjgCxWuO9OqNOpR2W86D2OBZDTplMf848tEXdybJQhUmxGg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3vWs1doxMo9fgyOrrbLJqWRH16n928hwX3XuATQuu8=; b=nRxJP08caTwnzKtVABZE2CYulNYDpzJraxu8PCZKKLXyF4FoGrcFAB/Rctis0p1z06YPzxGEgHrIFFwsReBUnvPqaYRX8WMfpcGbfVD58TXEKpsJ9PIT7Gf9SaEk4ftdOApyn9Tob7/HMtO6jsJtuGHA4GDVmpo9jtJveRtrtNc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: cb39af702bff052e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OK27lGfaigEUGPHkgxlz3Wiz7BY0vTeWJeBjo4wXlIAJdtzdgMe8bzI+mxMS8jDKhRSR6aSZpw43G8EaGGvfumJq/z+xpRqURTSzlbdZonw/Q+EaJpViHXe/gj8m+/Nn88oafDPLDpUu7Vy49b8mriMoHgJ8kQwjMqRADj4I/WcRLpnNrt2cqlQo8GE0RpjiVP3RYn0cE+AVqYfVV9jR7bRQFXyBN5WicKFMQYj3PjCp98GEKtmyT9bAh+JjD1k0YeFXy6BY2i9+1MObe1RZIqc5P0A0kGv2Rj287T04OvQL+TUxOuLOFQmu1Sdep9SKu9lbH4UmHWF1HDsm6ZN60g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3vWs1doxMo9fgyOrrbLJqWRH16n928hwX3XuATQuu8=; b=daqxst6AdPsDryIV/mJnGkFmXnpx9T2leAXfshLLJIp/W3GMTP/W1OYe0tYlLjIQBdEp7tLz6znCy7j00p+vsMK4hFcaLQ9yGsVFtymmJFDcwxh5mr4EXuvNK/9OBc0/UawRMAXmvXQJrte4zRcoDLrqW4fa2pf6/gYj2X10E+Gnp7Kojwg/kaAn/U+4LG4yfwUnuJ7yPFPs1DT/kKC+YNZo4TN8VGKm1/HBgpDRK3cnRL7TatpS8NBhjxJOM7RcmNAThfIcPTRfmsQRBuvhtCk7ydIJAbH7U3819lu+BWxkVpgt4kSHxGd5osxNFCgLr5oYcx40YQvFZ3cnEsTLHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3vWs1doxMo9fgyOrrbLJqWRH16n928hwX3XuATQuu8=; b=nRxJP08caTwnzKtVABZE2CYulNYDpzJraxu8PCZKKLXyF4FoGrcFAB/Rctis0p1z06YPzxGEgHrIFFwsReBUnvPqaYRX8WMfpcGbfVD58TXEKpsJ9PIT7Gf9SaEk4ftdOApyn9Tob7/HMtO6jsJtuGHA4GDVmpo9jtJveRtrtNc= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "jgross@suse.com" , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Stefano Stabellini Subject: Re: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length Thread-Topic: [PATCH v5 1/7] xen/dt: of_property_read_string return -ENODATA when !length Thread-Index: AQHYXAvKXCj8tnIY3E2+4y7aOufq8a0M+rIA Date: Tue, 3 May 2022 10:34:41 +0000 Message-ID: <3234C7B5-CF82-4C34-AF4F-957F6A5CDFB5@arm.com> References: <20220429205732.2030094-1-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-1-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: aa668b61-f8b0-43b3-7ff5-08da2cf08cf0 x-ms-traffictypediagnostic: AM9PR08MB7183:EE_|VE1EUR03FT052:EE_|DB9PR08MB6794:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HTVChEhBZkKEAQk5uaWtIrHTClTtuwx8qpjLjy+Ua7bBIl2nkyaNTyAiOm1GcRmUz4j00+gAY+YKKvcuqCQnnnYp/TXRVNpqTUjC5sdBhgz8DYQhfhbcpjq8vb9JBJw1uz5GrLaxVKvnjhHTc7CvsZobDv4wgpB4qKemnBNjsgOPlD5TsFkQophYLqPSk9Mp4O5GJB84KzeAgAHXaZwy/gFL3ZtO2QScMWTkQpkMbWiwMCF8cohjsoAiNhYgOi7Uv1/hmwS7T2pQXJuKfZgsN+xbXlkKHicDEwKKAswyfprRZCxnMrALnDFNSuTxY5YvQARYhukx/leBoGlhXgnb13wKsVYSY7rtw7Zj+pZ1X5KvOP4cogJNum+jl2ShGlD7Z96wylQ7lS1ivSBC1Wk1SGDJdeA7e5VyfdFhTmYwK91hVSwgYwgMfwJqSEKfkhvev/qJk+pMXsRs9t78ymb3kFXUc/iN44vlP/4DJjlZ6+ldolS+VCiVGVKWpUy5n7hrQYDK/ddxVji+VIhR0bhM6UYKSlvHqMvfNMlsWqdEXdgKWdV6TCq2efhrSYIZqAceHoCV8p7EacPu60qSdsFu7bWrTKIAcyypVv4bEbA6zVt8i37+wvu89bHgNIVSyXrkfRVdw6gVrSKPjV01KRZTHSx97hYNSygaEL4QJPRTuw0dDrWKbVCirnm4emsRlsx9ZcgMJPi77xiyJPefgnpFCr2iiEjm7Kf+a1WxLaZN2uHuwLXwrwUGPoOSe1bTU2/e+SPtiQpcCZwYoUOhxhPcCfxrqnp6+5PdTemg72oNLSmjU0Y3fYMxd2edZT6R3gtJBlwOA0FTqYGomRrOyRcVfA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(38100700002)(38070700005)(316002)(36756003)(6916009)(66446008)(64756008)(8676002)(4326008)(54906003)(66556008)(76116006)(91956017)(66476007)(66946007)(71200400001)(2906002)(5660300002)(6512007)(26005)(86362001)(33656002)(2616005)(6486002)(966005)(186003)(8936002)(53546011)(508600001)(4744005)(6506007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7183 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a0c5f19-1b19-49f7-4f31-08da2cf08819 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M+nggilWcK/gSrZHpjnUFiNkr/Y/WtUVmudsixFlYAeOiIWMrUe6udzMHr8GQkKF98EHkO4mSiDp88S7BpgILl5oLiwCuAaDMp1d9PrdYOA1E1hnLuKpTXCa03OONk35Kptb2epba5KTCzkGKdhT4lbNIEHbLZuxXDgGXsFC5aW999KVNUYuLKcurYfmyvozIVJqO2ZsQgjicXsETQbh8KBSeFXhJJXtkbn44q0yPUwux4ic2CcRRoli7VsofweqCOYIhwLOoIrgEk56WwwbwOutBcYbmkrzbgsdjJoKUTKHrKZ3OQK2KfuQv+mDHGJLPX2Ko5lEhWXmHOUlQjw0Wpmx/ztr2TSm2tmPZrKAiXOupjqtEjVv6BC2DRiCo2TwG5mrlX5Hv9zEHPTC3SUh9OwEvebSC2TfkLpSISq9T5T6gwuJr3j5yI/5M7k7lYW7NfD81D70yOHKaxH/Ak1ftNe9+VCAwRE19Rl5CX1raGaZgxvum07kUxqNq+frEiy+zkw5lzxx5ALVF+6AuQB+xA8TWTbSX2pxUVrE67S2EUGt7lPJmJ0dML+KKV0ErKsz2drGoR0EcUn7qL8hpCSwQoawtxOsG1LMZ+vBBZutC/gSsjP/GGNaoYpVlDu5NFxhZcDkQR9rUEsnyS/wBaoqZaRSuJlitUUYNY8hCSKBRXDfEolY9rNkLpZMj20ZAcrzfu1yjAe77LojSTV0fdGqCcwgjYtsm8q9fYd8sEzeaF5VQP/FzPCXwvv4YlaLRwEcaeEvLpTbVK1HcuDsT/PuUA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(70586007)(70206006)(82310400005)(86362001)(4326008)(8676002)(6862004)(40460700003)(356005)(2906002)(36860700001)(81166007)(4744005)(5660300002)(508600001)(8936002)(316002)(33656002)(966005)(6506007)(36756003)(6486002)(53546011)(6512007)(26005)(336012)(54906003)(2616005)(107886003)(47076005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:34:49.3753 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa668b61-f8b0-43b3-7ff5-08da2cf08cf0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6794 Hi Stefano, > On 29 Apr 2022, at 21:57, Stefano Stabellini wro= te: >=20 > From: Stefano Stabellini >=20 > When the length of the string is zero of_property_read_string should > return -ENODATA according to the description of the function. >=20 > However, of_property_read_string doesn't check prop->length. If > prop->length is zero, return -ENODATA. >=20 > Without this patch the following command in u-boot: >=20 > fdt set /chosen/node property-name >=20 > results in of_property_read_string returning -EILSEQ when attempting to > read property-name. With this patch, it returns -ENODATA as expected. >=20 > This commit is a backport of: > https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@ke= rnel.org/ >=20 > Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 03 10:36:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:36:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319443.539686 (Exim 4.92) (envelope-from ) id 1nlpt2-0001ZU-Ib; Tue, 03 May 2022 10:36:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319443.539686; Tue, 03 May 2022 10:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpt2-0001ZN-FL; Tue, 03 May 2022 10:36:08 +0000 Received: by outflank-mailman (input) for mailman id 319443; Tue, 03 May 2022 10:36:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlpt0-0001ZA-Ej for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:36:06 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0608.outbound.protection.outlook.com [2a01:111:f400:fe05::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d347e32d-cacc-11ec-a406-831a346695d4; Tue, 03 May 2022 12:36:01 +0200 (CEST) Received: from AM6PR08CA0040.eurprd08.prod.outlook.com (2603:10a6:20b:c0::28) by DB6PR08MB2696.eurprd08.prod.outlook.com (2603:10a6:6:25::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.19; Tue, 3 May 2022 10:35:58 +0000 Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::4f) by AM6PR08CA0040.outlook.office365.com (2603:10a6:20b:c0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:35:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:35:54 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Tue, 03 May 2022 10:35:54 +0000 Received: from dbe7acea0ee4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C5F285E8-CDE6-4F13-A4D6-C52BF4CC8441.1; Tue, 03 May 2022 10:35:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbe7acea0ee4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 10:35:43 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by DB8PR08MB4202.eurprd08.prod.outlook.com (2603:10a6:10:ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:35:41 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:35:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d347e32d-cacc-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nK+6NvZKF9IcW8tCYf2S9vKnsju6mqpy1b6a85S/7kCWLwxLdDRwJRpjg+e5zTYEIbCxsVSvA3l0kTvMkyPpC0CXi7keXOgeHgi1tX1KRsN6zCBETS9sAl12EiBYiyrm3fxRAQvTpzDRrtECaWLYyi84FZP9AsaJK82TWlkktjyzMPYYHdc6CT26Z+OYFA68HH8YItU/LeF54jmuL0G6KVVEBZz+v/KdbaTqM5vvHw5KBsr0F1No+cE88c756fJOH+mcuqx2S60sTCVAEISyLZveIF3+Hiov1mObfvKcS6KVjtqtrkHtjlA3AXX/YQp/8AepRoBf2F8iib0X7uTEtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c6fPKBGCmWAE4eoa1e9a6TKRDE7GnuJqC+L/TFTZxIk=; b=J+delUQHSH0xgtK8nnANipgPF73hEkWmkQAaEdY1K+tlh7djZ0ZhTOzSNEWwt928ChxfVJSzW3sRuQsqh2bH0c/0+DMH0pXxWw6RBFTGF6pP/0Ymqo5k0S6ZrK+lu/J0N6G/x8H/Shs8zbVRJLLDFVuTFmfQYU1bW7mAwbLRHr6CeIslIHedt3Ka0RmABZPnHzTGH+Me2s9Pv3kKH5F8pMwwcDpJ0Hcb/Fsw8S0lMPdDs81UTgBG67/0hVwVcKlBDzyAdhXo5aNAvi+4RWCFbbJ4UPZ6Gd67gMQ/xGZfAbvIiK57O+nBP+8moakmnu65otWm7OjK3agwcvVHEJkTDw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6fPKBGCmWAE4eoa1e9a6TKRDE7GnuJqC+L/TFTZxIk=; b=yT+GXlG+PyjaNkmcnUpgs6ahloBSQCVNJpxro55J5UzXevF/9iISO1a3dxs6T5PAv+MXtT1Ty2wpywaaOsASbxeTGgnWREl82e2k3LOOBQkkDWV9pxrrVIwerwTWNjBJWHKy/A+lJHg36r/AxhN3PpOcil02DqW0OobKnsNb/x8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: a083bb7507223bf3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CR2M2z+bPf4oP9f0UQPNbpQaUs8GxDoya5nHq/GUAMVCTz5FRonk91IyeCE18neEIdB4LeOeP6bIHi2/6wf3MLhGhs9bJd3opLx2V01GiZcU9MpEo5rLBmO0Fr2M2zquwQbj3wBNYbnOZNzNArFVM4tMD3fYa1uVO1UGw+NCpRPsS+WyuFs9Iw+NXNckNS9kpybwc00L9wG6/rY3Lqd28THzaUPEuuYNc6XMfeOBvrivGoykdnjsF6nibEYlpt3jklwVIUxXniMXz1xKqVKnDr8i/BfCGumLDZlI4gjeZaRakAl6QPIJdddUJ26z8OVyfzf9iOh31qHZNgUHjGhXnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c6fPKBGCmWAE4eoa1e9a6TKRDE7GnuJqC+L/TFTZxIk=; b=Q8EWEbMCTC3lFogtCnO0yNGjYaX7BehBCxoCfqLJ4khWHEA/2xXwno42OQdq0m8saqAtp5K2qWtMK2YyWz0fv9snK6VatmQvp49DsIZGI8jEwidcfYtmnQJXcy2CcQWebR98+pRJuXxKlWCz4400zTeXXeXcp7FNTlk8G3usVtSBL69Pxtyti26lyLPzB6HAsJY9ekDxJ3siO3fVdV2nJHBcqzLX2WHM45TZmm59v3gUHhJDg9UQeLyl3IcZaJfdp3xeqxHC5lbcea98E//Iqrb9whkuvyjQkE2EPJD7wyriZ3NuQygeWs7jix0i4R7LB9gxmdSVIIDj8YV8IYCSsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6fPKBGCmWAE4eoa1e9a6TKRDE7GnuJqC+L/TFTZxIk=; b=yT+GXlG+PyjaNkmcnUpgs6ahloBSQCVNJpxro55J5UzXevF/9iISO1a3dxs6T5PAv+MXtT1Ty2wpywaaOsASbxeTGgnWREl82e2k3LOOBQkkDWV9pxrrVIwerwTWNjBJWHKy/A+lJHg36r/AxhN3PpOcil02DqW0OobKnsNb/x8= From: Luca Fancellu To: Stefano Stabellini CC: xen-devel , "jgross@suse.com" , Bertrand Marquis , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Stefano Stabellini Subject: Re: [PATCH v5 7/7] docs: document dom0less + PV drivers Thread-Topic: [PATCH v5 7/7] docs: document dom0less + PV drivers Thread-Index: AQHYXAvORBZMXv5aPUSsbnB/Fi2OYK0M+vkA Date: Tue, 3 May 2022 10:35:41 +0000 Message-ID: <3072B061-DFB3-4D43-90F4-9964C648B96A@arm.com> References: <20220429205732.2030094-7-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-7-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b8a45150-6ade-4d97-98dc-08da2cf0b3c3 x-ms-traffictypediagnostic: DB8PR08MB4202:EE_|AM5EUR03FT029:EE_|DB6PR08MB2696:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TUH5ESABLR6jdEaW6rlupNAUFmCLZYeMQVIT8aPnxJrrCSab69uePNxvY1aG8X3ZXzyhXx/mzQsEBVeScq2oUFvgfBJqS2WMLUw3R2T3rdK47QT7SP8aSWtqkv2pL07m/zoiuByQvQjNb30mMQDUvVIIPE5xj0MIyNXqCCmYE+KhLzoNZjRHA+5oSKMdqa7jiENCEzrq8sk7o2oIyJow0ykKK7JcFqcF5od2oS3f9ljzPUY1X2i88O6Yq7Q33YhlpzRyo0z1tq8W70QgYmnLqxifSDGi8igiY3gfixOwDYFr2ERwPr0yts9KUJc0LnNg4pJaI+Y6t+6mdD8LhjolDou86kmXrLxS3Xo4k+/D5FoGesa1FCJURnDCNfg/Ul/qjl+KSFMOKzjlXi8i+c982t8k9gecR8fZ5nk3zZWmncvYyVzBKoP2dbn6uWIRhnNom5gKozbodtqJ4Ud4YTNHguKwJOj2mqWTGP33KtNrQcoPO6xwZ/KE7t/ZNN33n7pPso2tOopuNbUHEkNvgSOlhYy2GtcZ+nmuHo0KG7FBh4WOFxME9qx/r1xT5xMcYqQWopQ1slfHulwVaIPnSBEBGGIxuUqSShhdPUkBa0nKbDZXFkJUaC3s+7bVWD2EOhPg4dm9xhQQTDmvKG6xxjesk61k/ltN1b+Z2W0KkPg0Q3C5MjCpPCugY6XIiy0ULPKEteyQC35sXJD99yu5yiAgvCaSTYN6XxuJpwLprNX1O/klr/RboagyRlinU2+fuOcI X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(5660300002)(38100700002)(38070700005)(33656002)(6486002)(316002)(2906002)(6916009)(36756003)(71200400001)(2616005)(186003)(53546011)(6506007)(6512007)(26005)(8936002)(8676002)(64756008)(66476007)(66556008)(66446008)(66946007)(4326008)(76116006)(122000001)(54906003)(558084003)(86362001)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6957AF10B9B40A428B91A3367914715F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4202 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b38039d3-6ed6-46c9-6469-08da2cf0abd3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mnrghk+pgHzd7jw2GwZ57ugolhQ1elDEz2AGYYfgTL1gGFT4vPH2g/jF6hpyAHzO3C5yp6nICiOVZJsd+IWeiVtvIEBaqdToLR73cLxOArPxnpD00Q1W7Nppamdg4qDAmqxgRuXihkwcEJHKXGgH+9I/Aweib8fkHgg49iig9VIcLKJziQm0EEAFPTAm5RMSACIq29sGyRZwN5sCrtNLYbbrtuA+AlD0Jv86MchPnfWDAj0ZfXMu51bNLdsFRooGAQcyglxTtUa10MInqBzf2kWtkEmNMXHJCLnjPUMGIfeFYSdP6LjuhMoM5fPz4duxrsnzeyIaHc8kf8iKRwrTf8v+bZvEuF/97QtuGB8Fg0K82TkL6cjuW/NOX2fsVaq/4v42NQqlNjpktH9y0myBsUQoRrqp3yIyR6aAs3pxYx7RZZRsz/DDD2Ib6Mys7Tuy7FCw5TtAWw7wpijxSL5an1B5eg+croq95S8p/vnltaw7F5p77CnWu8K731NAqLUu3vDBZ12byJ2VituxYepjleSgO0yue6bdDgPvmcWWKSoQMFnkDuAfxvtk9DEk73CIxIH7gIWVqS42fKPzeZqxvEqEGvKrY8uK1wsm/6USVQSaM/3HdLOBIYjXFDMbR/SuXyuqZOJqO82SpKDtRIEUlHXTez7rhaRDjhK0nm+658oMnJyk0zZH1rFTh9gvvQZXijGTN4SrKIe1/JZB1le8+Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6506007)(356005)(316002)(81166007)(40460700003)(5660300002)(2616005)(8936002)(4744005)(33656002)(186003)(107886003)(36756003)(47076005)(54906003)(336012)(2906002)(6512007)(86362001)(26005)(6486002)(36860700001)(53546011)(70586007)(70206006)(4326008)(82310400005)(8676002)(6862004)(508600001)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:35:54.5278 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8a45150-6ade-4d97-98dc-08da2cf0b3c3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2696 > On 29 Apr 2022, at 21:57, Stefano Stabellini wro= te: >=20 > From: Stefano Stabellini >=20 > Document how to use the feature and how the implementation works. >=20 > Signed-off-by: Stefano Stabellini Reviewed-by Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue May 03 10:48:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319455.539700 (Exim 4.92) (envelope-from ) id 1nlq4V-0003GM-P3; Tue, 03 May 2022 10:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319455.539700; Tue, 03 May 2022 10:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlq4V-0003GF-KE; Tue, 03 May 2022 10:47:59 +0000 Received: by outflank-mailman (input) for mailman id 319455; Tue, 03 May 2022 10:47:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlq4U-0003G5-FE; Tue, 03 May 2022 10:47:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlq4U-0000qf-ES; Tue, 03 May 2022 10:47:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlq4U-0007Ks-7S; Tue, 03 May 2022 10:47:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlq4U-0007zs-6z; Tue, 03 May 2022 10:47:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oRrSuJ/onX6/n/7lLNqo+iAaZTxfGV6fVE5cfnxchDo=; b=A0C0s5xRm/5im1k50tkTX2W3X9 0IfCad2AJAutnZjDpagki+DxSaASk+Y5LObR7AMdF+lWS6N/1OapM5hMhOVejemolNeYwNlukckRj TSDA3JGCfv+JrYUitNzvrb9rnqwpn9qOR5M38SMOco0RLh74++2Ks6GWIh0g+aRn7IrI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170038: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 10:47:58 +0000 flight 170038 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 777 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 10:56:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 10:56:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319468.539713 (Exim 4.92) (envelope-from ) id 1nlqCn-0004sP-N3; Tue, 03 May 2022 10:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319468.539713; Tue, 03 May 2022 10:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqCn-0004sI-Ju; Tue, 03 May 2022 10:56:33 +0000 Received: by outflank-mailman (input) for mailman id 319468; Tue, 03 May 2022 10:56:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqCl-0004sC-UU for xen-devel@lists.xenproject.org; Tue, 03 May 2022 10:56:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1a::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af256557-cacf-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 12:56:29 +0200 (CEST) Received: from DB8PR06CA0042.eurprd06.prod.outlook.com (2603:10a6:10:120::16) by PR2PR08MB4857.eurprd08.prod.outlook.com (2603:10a6:101:1c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 10:56:27 +0000 Received: from DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::22) by DB8PR06CA0042.outlook.office365.com (2603:10a6:10:120::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:56:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT025.mail.protection.outlook.com (10.152.20.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 10:56:27 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 03 May 2022 10:56:27 +0000 Received: from 9917ff95df96.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7840B239-B704-4DDE-80AB-B2530EF158BC.1; Tue, 03 May 2022 10:56:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9917ff95df96.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 10:56:15 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by PAXPR08MB6638.eurprd08.prod.outlook.com (2603:10a6:102:df::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 10:56:14 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 10:56:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af256557-cacf-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mCQ8DFYPuOVeF87G3NpQjrx5juH8TgTDojf66j3sHQqkHpHKa2Uu+8wIQOF4/h45joQ2ZyiNZj2QqNfJkpvL2KlLBTPyDNbL+bkrVUXdn7p6A4133IQP1tuFXTNy+zmWl/IZO+Ppl6AXTLeooXKqAmzbx4aHdsJLIz8ANx6aekDDu5SHrLEqHyt41ZauStLNGRq5AJd95Lq6MIl1p6pgtpFE3JQ8lT+5LOzSUm6+IOLQBtXOODKAKWoFmYiKsRfhk5jGdAJsbT11zHbghtUGcDXXHXg9y+EpJt9Wa+o/QFwF08KdAzvVmwr6DK5CYxcKiZxhcOPtkuE/CpCSLdeByQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkSfPy6w4X5rzEA4+t/N/FsrgPhYgvR9diesA20FcxQ=; b=SFZDdeWKbl0hFem9GODEyHJTKR2ZprU1+yTC1YWHxUEcbZrLBHaJMoIXuAXZzzQip6bpL9Qqk3IHL6huDsYHjD6VX0VIIkCJ/bxe6JVPrQ8NJ6o6ywRjn96SApawxz5ExPDVNp1tkc8n3xNPJah28xSpkPYW+vtofq2k022SOCeQdWuQvnGsnr4r1tLGXVqr82BMDJJCJQ7GsBDnhSzrLjaPGUGL0JUO3zJc2SNFCzkGnDUyNtBwj/nqBDDKwClvEMpjHn6rjtvDlEGDX+oGCcWy49H77liCy40Xw144QORswCccMrKJzFWLegaJmCBcWqmF0sJn5qa9DDl3B4vJbQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkSfPy6w4X5rzEA4+t/N/FsrgPhYgvR9diesA20FcxQ=; b=bc7yRA4Q1VBCPxr+oTPS6dGGy3R6nToU2g1USV2XDnhN+alzEvkMs8ZwMm0kZ6t00JWfBiJHX6plWTrwFvRtzN8XFSHzFb1dCtfx7QIWNqbNuqzIp/xPSC73ZBBMMqf94xeWIwkpPjlVqJwGIXPHsmGYi0t5fUjNRy6lbR9giUQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: a3320a4d6c9ca40f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAwyACyp8jqevKdu2awSpF9Z+A9iv/lXa+Q2xRgqT7O9NRD98YH+3VwPdwXb4PlHdkNci0qTcKCogcY/ApeZorQY8SOiN9Lw8P5dLh7Y1D03N+ukrHpa0ffBAQHdRxTA1rPPCYgap1OrSN9bCTbooYgTQg9KZZzN5s5112d6D7iZp9OONC5wIb9kobRcNPVb5m9MWg53jCrS2Q1ED9meLMJh9gcXwk9w68OMWueJuSL2/8Aj9Zwgy6m6XwiZqk+IHCxslhaPwl/UyOsyL7Mv8jRQmfYENpc0GJngTXD2E03iuolXo1QNFXsv9WaMVsCti5QhCDrWHAb+xNrbK1ZT6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkSfPy6w4X5rzEA4+t/N/FsrgPhYgvR9diesA20FcxQ=; b=cfZxPR37qP7MM8QYmqpj+k3PQOF9/taO1V4/opIlF916NaHlGvaytsGbvlRSgHvrpt31FHxv6XQUPaRNKdyQmJXoNeOqwD15ilCdNL6ReibPQkXUIInT0izUcn/VElTjH7og/4kYYVV7f/xcViSw2tS0em/k9FWPenfAWLghqQ4p2BChkKM12eR6+0hMLNO/dtPIQ+W/c1T5wgmDEudhI56YHQrrNQ/BbcumrpmUYCMk2su2RwFH6xDE6CDs7tiXI/EhIOpT3HhWJKUXW3y9lfIaOjvjXNpNgU4R+g2it87GaKPnT5yDGBvkQZRGfOpokVEAPVwdNCryt2DM2gVBCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkSfPy6w4X5rzEA4+t/N/FsrgPhYgvR9diesA20FcxQ=; b=bc7yRA4Q1VBCPxr+oTPS6dGGy3R6nToU2g1USV2XDnhN+alzEvkMs8ZwMm0kZ6t00JWfBiJHX6plWTrwFvRtzN8XFSHzFb1dCtfx7QIWNqbNuqzIp/xPSC73ZBBMMqf94xeWIwkpPjlVqJwGIXPHsmGYi0t5fUjNRy6lbR9giUQ= From: Luca Fancellu To: Stefano Stabellini CC: xen-devel , "jgross@suse.com" , Bertrand Marquis , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Stefano Stabellini Subject: Re: [PATCH v5 7/7] docs: document dom0less + PV drivers Thread-Topic: [PATCH v5 7/7] docs: document dom0less + PV drivers Thread-Index: AQHYXAvORBZMXv5aPUSsbnB/Fi2OYK0M+vkAgAAFvoA= Date: Tue, 3 May 2022 10:56:13 +0000 Message-ID: <61359FAA-56EA-4F05-BFCA-F56C66C6FB85@arm.com> References: <20220429205732.2030094-7-sstabellini@kernel.org> <3072B061-DFB3-4D43-90F4-9964C648B96A@arm.com> In-Reply-To: <3072B061-DFB3-4D43-90F4-9964C648B96A@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: de9e5825-4614-47d2-0482-08da2cf39280 x-ms-traffictypediagnostic: PAXPR08MB6638:EE_|DB5EUR03FT025:EE_|PR2PR08MB4857:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZPiKd+cW3wQvk127oYxmMrT28cCCBJhUR3LEspc0GuK8ocxQHLuPyXF6ANFaL5mpDtJl8CRvx7TQx0eao9FUV2AEo0L4Ovrp8vC43TZ4NzaMdjlXHvXsp2MoIXAhbsaNLGOzuIfp7eiBP8XZOx+ac6X1iPtTLOimtdGse+QMDU0ttPZraI7EnhuUvIUB19s9BBhl/sXMUIbKjt4FCIQBhMOaMoAMkSgM9FQURexWbZyAC5AbLuUhe/Trfo4PxcnSZehyRAeXUgX0MG8+2toOaabMjBC0peXyQnI6fKAxerSiTw5pyqbJ8BJJduOhIvLe5+SDDCstilCGNgFAObXb9yY6Qty/lsolr0RSBHgu2R61InUXJ6N/np631C0v7TCzjWJdT4FA2Fda3wD5Eh1OBuH9lPQ/FmgP2YW2sAJCvfMMBoby6nS9fdP79P7vIiFxxTHMq0PiegNafGE2MnWogzkb6tglcpy8Je2INagjeQ+848713S7UeRivrnc42NFGKCCIm52LTVBgKsiZmqwvX3jZwedjL9NnqUTC3KWnfXpYvt+vAW/FXt2yBwIUkwoP0IdOGLqtlqRLM+Ubn1UQ0feKAP5KNDBRX/olxQIG/1lI2b1o0igGB8xaZEjqEHic69HWdqAXAe73urorPN313KVxEf2Rb0HTLCg8l63PUGa/7UStQwdMWkTfM0AGrLwpgOZBOn0dj3/Hh5JCWUbOx5Cv5aChhweV1ak0ouwnJX0mm+6UqU9hIhCe8u1ZNI7R22y/bop3qOSrQFeIlkDpeA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(66446008)(26005)(64756008)(66476007)(76116006)(53546011)(8676002)(186003)(4326008)(4744005)(71200400001)(36756003)(6512007)(6506007)(86362001)(6486002)(316002)(38070700005)(122000001)(8936002)(2616005)(6916009)(508600001)(54906003)(38100700002)(5660300002)(33656002)(2906002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6638 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 67f0c01a-7436-45c9-68fb-08da2cf38a89 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LS2H0nl+fx5vbeApANbkqAgOeZs1rUMvigR67KVWqqiQFoKkt/9uS5nUZtQgpV/CG2lErgS3tjr/mUm7wEMWNFph7qf1f7E0FTc+HeUUvHb/6UNGvHxZjTdDzvO7K1g9PgHRzKgECLBaRCgq36jTT4V16iG+nQlnkvpDT/8UMdugE7IvTm33f+fs4AQikfB/WPOYt2QY0CpInCYOGqbXK7nnodHNnm7kp6uCCUZyqzff/gxO097K1WtZF8TC2WPnMpiVjdCGfpHesVmdbw1aa7voGUjgSemfouHlwbP1MfDIXeN5/3td0Y7o3cxVNleGm1pSmBw4hhPuF87bTWLwwFIMYUBMsGf8EUZ2GS22Ra1gvodoSrAGatZMC6USZZFV2RvVR3v35i2FHWb0s++aFH4hHTSUkI05GAGMnbgYOqQIvfxztZ94nsnCJ4nHndDd9gf+pIBNvaJEq04Qw48mr1zTgvLXQ47ctoxjH/Owvy3chWhHNCRbXwPQtsT5jwO9GtKVgGWO6r7YKSjUZSa+ogUNSjkvVK+pGM7IYfEkeSKcYpo9LL3ZeD2gx4o65RWPyUwVxIF2IOZZdN/3Qf8j4A6JAtDuYfXrfi8ZGfiPFxz8uFeoe7UbcqpJjtmm3yop0qEkOoH/mEhDxf9VuGc5+OcGdQNEnSQnmcLJF9Niyb27sZHBsU4svY8EsCzyaY6bzlqpFn7wkk58G+I6jfLvQA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(4326008)(8676002)(2906002)(356005)(186003)(70206006)(70586007)(8936002)(81166007)(6862004)(86362001)(82310400005)(107886003)(508600001)(4744005)(2616005)(40460700003)(26005)(6512007)(54906003)(33656002)(47076005)(336012)(53546011)(36860700001)(6506007)(36756003)(316002)(6486002)(5660300002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 10:56:27.2728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de9e5825-4614-47d2-0482-08da2cf39280 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4857 > On 3 May 2022, at 11:35, Luca Fancellu wrote: >=20 >=20 >=20 >> On 29 Apr 2022, at 21:57, Stefano Stabellini wr= ote: >>=20 >> From: Stefano Stabellini >>=20 >> Document how to use the feature and how the implementation works. >>=20 >> Signed-off-by: Stefano Stabellini >=20 > Reviewed-by Luca Fancellu >=20 Ops, sorry, typo: Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue May 03 11:18:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319481.539731 (Exim 4.92) (envelope-from ) id 1nlqXe-0007fP-NF; Tue, 03 May 2022 11:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319481.539731; Tue, 03 May 2022 11:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqXe-0007fI-KI; Tue, 03 May 2022 11:18:06 +0000 Received: by outflank-mailman (input) for mailman id 319481; Tue, 03 May 2022 11:18:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqXd-0007fC-Qq for xen-devel@lists.xenproject.org; Tue, 03 May 2022 11:18:05 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b24f7f9d-cad2-11ec-a406-831a346695d4; Tue, 03 May 2022 13:18:04 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651576664402846.4614270922928; Tue, 3 May 2022 04:17:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b24f7f9d-cad2-11ec-a406-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1651576666; cv=none; d=zohomail.com; s=zohoarc; b=EzzvcKGbct+Dgc7pNKm4WmVDDRl0uZAxpuTzkeGSTSVHcTKYA4D7B8N+3v29oJHxquJY+7ERdoCGvnhdcgr5xM4RkzuwGYbSSUtxjXeaxR9NKJoUkVP1SVR9YglLpLrRtvaPxJwe0eUsASyGKTplqbkR9oxT9/d6IW7dttnu7cg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651576666; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=MZnOucO46CLab+64HD+pm5/gkjZFJY/ODJQa7F/pUHw=; b=OF4bfBMYITpuiaUzRc6fq2a/WJof/3vjfmGtOxOXt/WUkwVJ4YxMxVPBLzfav11bzmf94je2B2yFcA/3Cjsz7kJ0KWihKYCgAFJtmKapdL2FzP4Lk39QVAMqZXL0/OMVblAffJCqz3QvkqfqQqwca2DtDH3TfUC5lPtOOan91R0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651576666; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=MZnOucO46CLab+64HD+pm5/gkjZFJY/ODJQa7F/pUHw=; b=Cj7OmqXzXBBlZdGS+amcaJk9b3cqYMuaRU+f0hCDXRN2GcOjBMLLAZl1QsghBJQQ gzxblauOaLiXNNLwM5RLCBntoktwdciwx0tVyQC39gFujrat79SkT9osHuQ6DbU3e9x kobfQbWxjTljHEAL98OTALfEDPYdJTP2t/5l1a88= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io Subject: [PATCH v6 0/2] Adds starting the idle domain privileged Date: Tue, 3 May 2022 07:17:29 -0400 Message-Id: <20220503111731.12642-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series makes it so that the idle domain is started privileged under the default policy, which the SILO policy inherits, and under the flask policy. It then introduces a new one-way XSM hook, xsm_transition_running, that is hooked by an XSM policy to transition the idle domain to its running privilege level. Changes in v6: - readded the setting of is_privileged in flask_set_system_active() - clarified comment on is_privileged in flask_set_system_active() - added ASSERT on is_privileged and self_sid in flask_set_system_active() - fixed err code returned on Arm for xsm_set_system_active() panic message Changes in v5: - dropped setting is_privileged in flask_set_system_active() - added err code returned by xsm_set_system_active() to panic message Changes in v4: - reworded patch 1 commit messaged - fixed whitespace to coding style - fixed comment to coding style Changes in v3: - renamed *_transition_running() to *_set_system_active() - changed the XSM hook set_system_active() from void to int return - added ASSERT check for the expected privilege level each XSM policy expected - replaced a check against is_privileged in each arch with checking the return value from the call to xsm_set_system_active() Changes in v2: - renamed flask_domain_runtime_security() to flask_transition_running() - added the missed assignment of self_sid Daniel P. Smith (2): xsm: create idle domain privileged and demote after setup flask: implement xsm_set_system_active tools/flask/policy/modules/xen.if | 6 +++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/arch/arm/setup.c | 4 ++++ xen/arch/x86/setup.c | 5 ++++ xen/common/sched/core.c | 7 +++++- xen/include/xsm/dummy.h | 17 ++++++++++++++ xen/include/xsm/xsm.h | 6 +++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 32 +++++++++++++++++++++++++- xen/xsm/flask/policy/initial_sids | 1 + 11 files changed, 79 insertions(+), 2 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 11:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319484.539742 (Exim 4.92) (envelope-from ) id 1nlqXx-00081S-0s; Tue, 03 May 2022 11:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319484.539742; Tue, 03 May 2022 11:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqXw-00081L-TW; Tue, 03 May 2022 11:18:24 +0000 Received: by outflank-mailman (input) for mailman id 319484; Tue, 03 May 2022 11:18:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqXv-0007fC-UW for xen-devel@lists.xenproject.org; Tue, 03 May 2022 11:18:24 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd882290-cad2-11ec-a406-831a346695d4; Tue, 03 May 2022 13:18:22 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651576666625684.9544369515083; Tue, 3 May 2022 04:17:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd882290-cad2-11ec-a406-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1651576668; cv=none; d=zohomail.com; s=zohoarc; b=OraSR3qfSrtz+7/ja+AJ3u2ZEF2YOjanOlU+YmeYxS2OoWTCw9/Y894YGeG36LQncZy+h3p1mwHkS+TXUT6d6RMz2VJsxvXkSjj+6MlgynOZYGDN0GmyjsDLaO/N9dB+sFapSYW67d+PKk46Hj8L+lfrZ3MdC8Xf8UhLw+IDmaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651576668; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+BUcWaa4jX05BxfmuF7X73mpsOynlVPuun3vh8wQPWc=; b=L6GDhTRc5QYyPSm2alZ4s0mTDaWf7dJb7uFvy8JX6vnreeSqECmWux0JKBJjOPkuy9j7zfiMJ8l5/hk9yvfgVzjnm/lzvhmB0mGE/y9UFWmooqU8tzO/IFyJFbz2TbfYBN8FvJrm6LAGIqA0i8SLUMX6XwO+PGjjR/RrNAb3IZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651576668; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=+BUcWaa4jX05BxfmuF7X73mpsOynlVPuun3vh8wQPWc=; b=FXiAr3X3yy3yFkOj1ohaIwJe5eyKt9HT0WvNictncrS/NuLwW/q/M4jcwWYXPZEK hRwY3oWuwm3E7t0VBn770hO1DpZOWI6Y3CzbMvnoLC4Snldf8vOshN/tB6AdOJgeng0 1ALNaMmGHnedcAu1Bt16B53rglNfqSIGZZtOBjAM= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Date: Tue, 3 May 2022 07:17:30 -0400 Message-Id: <20220503111731.12642-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220503111731.12642-1-dpsmith@apertussolutions.com> References: <20220503111731.12642-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External There are new capabilities, dom0less and hyperlaunch, that introduce internal hypervisor logic which needs to make resource allocation calls that are protected by XSM access checks. This creates an issue as a subset of the hypervisor code is executed under a system domain, the idle domain, that is represented by a per-CPU non-privileged struct domain. To enable these new capabilities to function correctly but in a controlled manner, this commit changes the idle system domain to be created as a privileged domain under the default policy and demoted before transitioning to running. A new XSM hook, xsm_set_system_active(), is introduced to allow each XSM policy type to demote the idle domain appropriately for that policy type. In the case of SILO, it inherits the default policy's hook for xsm_set_system_active(). For flask a stub is added to ensure that flask policy system will function correctly with this patch until flask is extended with support for starting the idle domain privileged and properly demoting it on the call to xsm_set_system_active(). Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- xen/arch/arm/setup.c | 4 ++++ xen/arch/x86/setup.c | 5 +++++ xen/common/sched/core.c | 7 ++++++- xen/include/xsm/dummy.h | 17 +++++++++++++++++ xen/include/xsm/xsm.h | 6 ++++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ 7 files changed, 62 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed4..39a654926d 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, /* Hide UART from DOM0 if we're using it */ serial_endboot(); + if ( (rc = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): " + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", rc); + system_state = SYS_STATE_active; for_each_domain( d ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 6f20e17892..36a60ce884 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -620,6 +620,11 @@ static void noreturn init_done(void) { void *va; unsigned long start, end; + int err; + + if ( (err = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): " + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); system_state = SYS_STATE_active; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..7b1c03a0e1 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3021,7 +3021,12 @@ void __init scheduler_init(void) sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US; } - idle_domain = domain_create(DOMID_IDLE, NULL, 0); + /* + * The idle dom is created privileged to ensure unrestricted access during + * setup and will be demoted by xsm_set_system_active() when setup is + * complete. + */ + idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged); BUG_ON(IS_ERR(idle_domain)); BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu)); idle_domain->vcpu = idle_vcpu; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 58afc1d589..3291fb5396 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -101,6 +101,23 @@ static always_inline int xsm_default_action( } } +static XSM_INLINE int cf_check xsm_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("xsm_set_system_active: should only be called by idle domain\n"); + return -EPERM; + } + + d->is_privileged = false; + + return 0; +} + static XSM_INLINE void cf_check xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..8dad03fd3d 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t; * !!! WARNING !!! */ struct xsm_ops { + int (*set_system_active)(void); void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); int (*domain_create)(struct domain *d, uint32_t ssidref); @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops; #ifndef XSM_NO_WRAPPERS +static inline int xsm_set_system_active(void) +{ + return alternative_call(xsm_ops.set_system_active); +} + static inline void xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index 8c044ef615..e6ffa948f7 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -14,6 +14,7 @@ #include static const struct xsm_ops __initconst_cf_clobber dummy_ops = { + .set_system_active = xsm_set_system_active, .security_domaininfo = xsm_security_domaininfo, .domain_create = xsm_domain_create, .getdomaininfo = xsm_getdomaininfo, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 0bf63ffa84..b93101191e 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) return 0; } +static int cf_check flask_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("xsm_set_system_active should only be called by idle domain\n"); + return -EPERM; + } + + /* + * While is_privileged has no significant meaning under flask, set to false + * as is_privileged is not only used for a privilege check but also as a type + * of domain check, specifically if the domain is the control domain. + */ + d->is_privileged = false; + + return 0; +} + static void cf_check flask_domain_free_security(struct domain *d) { struct domain_security_struct *dsec = d->ssid; @@ -1766,6 +1788,7 @@ static int cf_check flask_argo_send( #endif static const struct xsm_ops __initconst_cf_clobber flask_ops = { + .set_system_active = flask_set_system_active, .security_domaininfo = flask_security_domaininfo, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 11:19:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:19:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319496.539753 (Exim 4.92) (envelope-from ) id 1nlqYX-0000IX-AB; Tue, 03 May 2022 11:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319496.539753; Tue, 03 May 2022 11:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqYX-0000IQ-6N; Tue, 03 May 2022 11:19:01 +0000 Received: by outflank-mailman (input) for mailman id 319496; Tue, 03 May 2022 11:18:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqYV-0007yH-FH for xen-devel@lists.xenproject.org; Tue, 03 May 2022 11:18:59 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2730006-cad2-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 13:18:57 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651576668065384.3787219888786; Tue, 3 May 2022 04:17:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2730006-cad2-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1651576669; cv=none; d=zohomail.com; s=zohoarc; b=JJKOcvVdOwQS1pxmXpLQvNqeO6TYNQd3WQq/oka+M0XDcaEgfHuTdazTFxC8uIxYFXH/DNHFx/ucW/6nFTqs0zrca0Mfir8GLPtgtCMjdaj3HdagRqIPAnpO+CN30FNYCypzjFyCkl4i6tF2ydxTkFIFvgijvdAIxe0vrpAFY4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651576669; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Rn8pIJ5/E/d7mP3iWH7p9KqhjeTfcKsV2dbiWGsA9xU=; b=drY5Qa0hxPVoMWUXPs5Uxbnx97yU2hSMvDHWga62lN3KUDzSeBIyUAii4M1IMTeAlyWtGkhz3W5qaJ3ZSzLjQd9EoBgq0AjdFYz8YM3rYGlSdbY+OwE7NP+TYlCCQWimqKQSKeocaMvOng+npS74KZBWjxvrmDD6HPpdO6ndsGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651576669; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=Rn8pIJ5/E/d7mP3iWH7p9KqhjeTfcKsV2dbiWGsA9xU=; b=MHF5gDLgRXZ3HxxgnQlW4GIcm9QG/sWt2Zcuf3cGbXNJgadnTkAni/OVPBJQcRkl CCN1OwQ07j3J7atN8PuIihA/NVJEeut/e1bRFDupLUgjpEz+EBu4dojrDpa+4oDtzdR FKl7Ysa/4pOESghTf4OyrrMuIQmJRKqSDQ54TG4c= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD Subject: [PATCH v6 2/2] flask: implement xsm_set_system_active Date: Tue, 3 May 2022 07:17:31 -0400 Message-Id: <20220503111731.12642-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220503111731.12642-1-dpsmith@apertussolutions.com> References: <20220503111731.12642-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit implements full support for starting the idle domain privileged by introducing a new flask label xenboot_t which the idle domain is labeled with at creation. It then provides the implementation for the XSM hook xsm_set_system_active to relabel the idle domain to the existing xen_t flask label. In the reference flask policy a new macro, xen_build_domain(target), is introduced for creating policies for dom0less/hyperlaunch allowing the hypervisor to create and assign the necessary resources for domain construction. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk --- tools/flask/policy/modules/xen.if | 6 ++++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/xsm/flask/hooks.c | 9 ++++++++- xen/xsm/flask/policy/initial_sids | 1 + 5 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if index 5e2aa472b6..4ec676fff1 100644 --- a/tools/flask/policy/modules/xen.if +++ b/tools/flask/policy/modules/xen.if @@ -62,6 +62,12 @@ define(`create_domain_common', ` setparam altp2mhvm altp2mhvm_op dm }; ') +# xen_build_domain(target) +# Allow a domain to be created at boot by the hypervisor +define(`xen_build_domain', ` + allow xenboot_t $1_channel:event create; +') + # create_domain(priv, target) # Allow a domain to be created directly define(`create_domain', ` diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te index 3dbf93d2b8..de98206fdd 100644 --- a/tools/flask/policy/modules/xen.te +++ b/tools/flask/policy/modules/xen.te @@ -24,6 +24,7 @@ attribute mls_priv; ################################################################################ # The hypervisor itself +type xenboot_t, xen_type, mls_priv; type xen_t, xen_type, mls_priv; # Domain 0 diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids index 6b7b7eff21..ec729d3ba3 100644 --- a/tools/flask/policy/policy/initial_sids +++ b/tools/flask/policy/policy/initial_sids @@ -2,6 +2,7 @@ # objects created before the policy is loaded or for objects that do not have a # label defined in some other manner. +sid xenboot gen_context(system_u:system_r:xenboot_t,s0) sid xen gen_context(system_u:system_r:xen_t,s0) sid dom0 gen_context(system_u:system_r:dom0_t,s0) sid domxen gen_context(system_u:system_r:domxen_t,s0) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index b93101191e..734d9de16a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) switch ( d->domain_id ) { case DOMID_IDLE: - dsec->sid = SECINITSID_XEN; + dsec->sid = SECINITSID_XENBOOT; break; case DOMID_XEN: dsec->sid = SECINITSID_DOMXEN; @@ -188,9 +188,14 @@ static int cf_check flask_domain_alloc_security(struct domain *d) static int cf_check flask_set_system_active(void) { + struct domain_security_struct *dsec; struct domain *d = current->domain; + dsec = d->ssid; + ASSERT(d->is_privileged); + ASSERT(dsec->sid == SECINITSID_XENBOOT); + ASSERT(dsec->self_sid == SECINITSID_XENBOOT); if ( d->domain_id != DOMID_IDLE ) { @@ -205,6 +210,8 @@ static int cf_check flask_set_system_active(void) */ d->is_privileged = false; + dsec->self_sid = dsec->sid = SECINITSID_XEN; + return 0; } diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids index 7eca70d339..e8b55b8368 100644 --- a/xen/xsm/flask/policy/initial_sids +++ b/xen/xsm/flask/policy/initial_sids @@ -3,6 +3,7 @@ # # Define initial security identifiers # +sid xenboot sid xen sid dom0 sid domio -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 03 11:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319507.539764 (Exim 4.92) (envelope-from ) id 1nlqbX-0001xz-Pk; Tue, 03 May 2022 11:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319507.539764; Tue, 03 May 2022 11:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqbX-0001xs-LB; Tue, 03 May 2022 11:22:07 +0000 Received: by outflank-mailman (input) for mailman id 319507; Tue, 03 May 2022 11:22:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqYO-0007fC-Qx for xen-devel@lists.xenproject.org; Tue, 03 May 2022 11:18:53 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfa12d87-cad2-11ec-a406-831a346695d4; Tue, 03 May 2022 13:18:51 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id g6so32830911ejw.1 for ; Tue, 03 May 2022 04:18:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa12d87-cad2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ii/VPjSBiz3V9wv7B3XY7h3o+gkq07nEEQqTfzgRPY=; b=RFr+TWHqvBNXMOqsxxp82sywd5VkvzjSzw4VPqpv3JVORUcXAW1tpifGSr1hQBmpuc b/qm1C2+H6nU91lbG2LsN3JYZNVbRxoyvJNTDYAKOJSnELxSQAGX/zMusReSYwhuu/DQ SdZ2x5/828Ef+hdIc4IaZcNhXH5eoRFVFb/t0/f/SghxyruXMsx2DCiBE53LzsPAGbr2 DbP2VhrME06z8M2C0u/miVDuRZg3mIuIxk4zXyxuoBHaoihYo6wq+wbhKLrrQUKlZpdu iazIFKormkNVJhyJ/euo7tWM4OgQY9oeBmfnCmqWDLcuclt5aV+EPlBXEpc7ZW44rdAG NmSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ii/VPjSBiz3V9wv7B3XY7h3o+gkq07nEEQqTfzgRPY=; b=f2UF4ddE+Z6bjzHRLNKmWZCQsPygc8k5ocIMjR3MP7NKyyS44WoRwQ0Gi32f3N3JVH ItJFkBnqbkzhV9gtltntyF3f0DgpijLgoeIyPb5hbPZ+YTaotAn17mihyuilGPZ+TKGg ZXcgApu7bLjBDrcg0wjosAkArFL1tGPvGKC6aAVybyFUw3Oi7YS8eLf5jlFNNXZCUoqJ APyXIkAHT21kihVS7JJkk83w85eeMCymyOmR4eRxgIgP7HcIIptk+C7KAzgR9OKRxC+k rTAMFND69SRf4PoWaB8fdy3KhBW5nDVPYU+3k7Okiay9u0MOWI7FUsHpkPye1mGRU9CQ rHrg== X-Gm-Message-State: AOAM5339BthtVeKoQ/U40G3TLYr7giqOx12Ig7ZMhN1fDUhfdTo1WhAP RePj7SAAixobNIwZy5bew/nN/enwD+BJkNOFW8k= X-Google-Smtp-Source: ABdhPJxvO1AgMJn+E5Afk3lxmqWsEqsKSy8oq0rKE0fV+LSVwCuuaeTbjpIylpaV1lGrMF+c0eyNVOtjoavmqQFRmGs= X-Received: by 2002:a17:907:7dac:b0:6f3:be1f:af39 with SMTP id oz44-20020a1709077dac00b006f3be1faf39mr15056314ejc.467.1651576731331; Tue, 03 May 2022 04:18:51 -0700 (PDT) MIME-Version: 1.0 References: <20220429205732.2030094-2-sstabellini@kernel.org> In-Reply-To: <20220429205732.2030094-2-sstabellini@kernel.org> From: Oleksandr Tyshchenko Date: Tue, 3 May 2022 14:18:38 +0300 Message-ID: Subject: Re: [PATCH v5 2/7] xen/arm: implement domU extended regions To: Stefano Stabellini Cc: xen-devel , Juergen Gross , Bertrand Marquis , Julien Grall , Volodymyr Babchuk , Stefano Stabellini Content-Type: multipart/alternative; boundary="00000000000063eff005de19ac13" --00000000000063eff005de19ac13 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 29, 2022 at 11:58 PM Stefano Stabellini wrote: > From: Stefano Stabellini > Hello Stefano [Sorry for the possible format issues] > > Implement extended regions for dom0less domUs. The implementation is > based on the libxl implementation. > > Signed-off-by: Stefano Stabellini > --- > Changes in v5: > - print the domain > - coding style > - simplify the code in find_domU_holes > - return error if no regions allocated in find_domU_holes > - use ROUNDUP > - uint64_t/paddr_t > --- > xen/arch/arm/domain_build.c | 56 +++++++++++++++++++++++++++++++------ > 1 file changed, 48 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 8be01678de..34d3e5ce30 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1324,6 +1324,37 @@ out: > return res; > } > > +static int __init find_domU_holes(const struct kernel_info *kinfo, > + struct meminfo *ext_regions) > +{ > + unsigned int i; > + paddr_t bankend; > + const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; > + const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; > + int res = -ENOENT; > + > + for ( i = 0; i < GUEST_RAM_BANKS; i++ ) > + { > + struct membank *ext_bank = > &(ext_regions->bank[ext_regions->nr_banks]); > + > + ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, > + SZ_2M); > + > + bankend = ~0ULL >> (64 - p2m_ipa_bits); > + bankend = min(bankend, bankbase[i] + banksize[i] - 1); > + if ( bankend > ext_bank->start ) > + ext_bank->size = bankend - ext_bank->start + 1; > + > + /* 64MB is the minimum size of an extended region */ > + if ( ext_bank->size < MB(64) ) > + continue; > + ext_regions->nr_banks++; > + res = 0; > + } > + > + return res; > +} > + > static int __init make_hypervisor_node(struct domain *d, > const struct kernel_info *kinfo, > int addrcells, int sizecells) > @@ -1360,12 +1391,13 @@ static int __init make_hypervisor_node(struct > domain *d, > > if ( !opt_ext_regions ) > ok, I think, the comment for *opt_ext_regions* at the beginning of this file and the description for *ext_regions* in xen-command-line.pandoc need to be updated, as they both mention Dom0 only. > { > - printk(XENLOG_INFO "The extended regions support is disabled\n"); > + printk(XENLOG_INFO "%pd: extended regions support is disabled\n", > d); > nr_ext_regions = 0; > } > else if ( is_32bit_domain(d) ) > { > - printk(XENLOG_WARNING "The extended regions are only supported > for 64-bit guest currently\n"); > + printk(XENLOG_WARNING "%pd: extended regions are only supported > for 64-bit guest currently\n", > + d); > nr_ext_regions = 0; > } > else > @@ -1374,13 +1406,21 @@ static int __init make_hypervisor_node(struct > domain *d, > if ( !ext_regions ) > return -ENOMEM; > > - if ( !is_iommu_enabled(d) ) > - res = find_unallocated_memory(kinfo, ext_regions); > + if ( is_domain_direct_mapped(d) ) > + { > + if ( !is_iommu_enabled(d) ) > + res = find_unallocated_memory(kinfo, ext_regions); > + else > + res = find_memory_holes(kinfo, ext_regions); > + } > else > - res = find_memory_holes(kinfo, ext_regions); > + { > + res = find_domU_holes(kinfo, ext_regions); > + } > > if ( res ) > - printk(XENLOG_WARNING "Failed to allocate extended > regions\n"); > + printk(XENLOG_WARNING "%pd: failed to allocate extended > regions\n", > + d); > nr_ext_regions = ext_regions->nr_banks; > } > > @@ -1401,8 +1441,8 @@ static int __init make_hypervisor_node(struct domain > *d, > u64 start = ext_regions->bank[i].start; > u64 size = ext_regions->bank[i].size; > > - printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", > - i, start, start + size); > + printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", > + d, i, start, start + size); > > dt_child_set_range(&cells, addrcells, sizecells, start, size); > } > -- > 2.25.1 > > > -- Regards, Oleksandr Tyshchenko --00000000000063eff005de19ac13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Apr 29, 2022 at 11:58 PM Stef= ano Stabellini <sstabellini@ke= rnel.org> wrote:
From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Hello Stefano

[Sorry f= or the possible format issues]

=C2=A0

Implement extended regions for dom0less domUs. The implementation is
based on the libxl implementation.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
---
Changes in v5:
- print the domain
- coding style
- simplify the code in find_domU_holes
- return error if no regions allocated in find_domU_holes
- use ROUNDUP
- uint64_t/paddr_t
---
=C2=A0xen/arch/arm/domain_build.c | 56 +++++++++++++++++++++++++++++++-----= -
=C2=A01 file changed, 48 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 8be01678de..34d3e5ce30 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1324,6 +1324,37 @@ out:
=C2=A0 =C2=A0 =C2=A0return res;
=C2=A0}

+static int __init find_domU_holes(const struct kernel_info *kinfo,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 struct meminfo *ext_regions)<= br> +{
+=C2=A0 =C2=A0 unsigned int i;
+=C2=A0 =C2=A0 paddr_t bankend;
+=C2=A0 =C2=A0 const paddr_t bankbase[] =3D GUEST_RAM_BANK_BASES;
+=C2=A0 =C2=A0 const paddr_t banksize[] =3D GUEST_RAM_BANK_SIZES;
+=C2=A0 =C2=A0 int res =3D -ENOENT;
+
+=C2=A0 =C2=A0 for ( i =3D 0; i < GUEST_RAM_BANKS; i++ )
+=C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct membank *ext_bank =3D &(ext_regions= ->bank[ext_regions->nr_banks]);
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 ext_bank->start =3D ROUNDUP(bankbase[i] + k= info->mem.bank[i].size,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SZ_2M);
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 bankend =3D ~0ULL >> (64 - p2m_ipa_bits)= ;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 bankend =3D min(bankend, bankbase[i] + banksiz= e[i] - 1);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( bankend > ext_bank->start )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ext_bank->size =3D bankend - = ext_bank->start + 1;
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* 64MB is the minimum size of an extended reg= ion */
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( ext_bank->size < MB(64) )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 ext_regions->nr_banks++;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D 0;
+=C2=A0 =C2=A0 }
+
+=C2=A0 =C2=A0 return res;
+}
+
=C2=A0static int __init make_hypervisor_node(struct domain *d,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 const st= ruct kernel_info *kinfo,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 int addr= cells, int sizecells)
@@ -1360,12 +1391,13 @@ static int __init make_hypervisor_node(struct domai= n *d,

=C2=A0 =C2=A0 =C2=A0if ( !opt_ext_regions )

=

ok, I think, the comment for *opt_ext_regions* at the b= eginning=C2=A0of this file and the description for *ext_regions* in xen-com= mand-line.pandoc need to be updated,
as they both mention Dom0 on= ly.


=C2=A0
=C2=A0 =C2=A0 =C2=A0{
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_INFO "The extended regions = support is disabled\n");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_INFO "%pd: extended regions= support is disabled\n", d);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0nr_ext_regions =3D 0;
=C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0else if ( is_32bit_domain(d) )
=C2=A0 =C2=A0 =C2=A0{
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_WARNING "The extended regio= ns are only supported for 64-bit guest currently\n");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_WARNING "%pd: extended regi= ons are only supported for 64-bit guest currently\n",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0d);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0nr_ext_regions =3D 0;
=C2=A0 =C2=A0 =C2=A0}
=C2=A0 =C2=A0 =C2=A0else
@@ -1374,13 +1406,21 @@ static int __init make_hypervisor_node(struct domai= n *d,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( !ext_regions )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return -ENOMEM;

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !is_iommu_enabled(d) )
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D find_unallocated_memory(= kinfo, ext_regions);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( is_domain_direct_mapped(d) )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( !is_iommu_enabled(d) )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D find_unall= ocated_memory(kinfo, ext_regions);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D find_memor= y_holes(kinfo, ext_regions);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D find_memory_holes(kinfo,= ext_regions);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D find_domU_holes(kinfo, e= xt_regions);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( res )
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_WARNING "Fail= ed to allocate extended regions\n");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 printk(XENLOG_WARNING "%pd:= failed to allocate extended regions\n",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0d); =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0nr_ext_regions =3D ext_regions->nr_ban= ks;
=C2=A0 =C2=A0 =C2=A0}

@@ -1401,8 +1441,8 @@ static int __init make_hypervisor_node(struct domain = *d,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0u64 start =3D ext_regions->bank[i].sta= rt;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0u64 size =3D ext_regions->bank[i].size= ;

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk("Extended region %d: %#"PRIx6= 4"->%#"PRIx64"\n",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i, start, start + s= ize);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 printk("%pd: extended region %d: %#"= PRIx64"->%#"PRIx64"\n",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0d, i, start, start = + size);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dt_child_set_range(&cells, addrcells,= sizecells, start, size);
=C2=A0 =C2=A0 =C2=A0}
--
2.25.1




--
Reg= ards,

Ol= eksandr Tyshchenko
<= /div> --00000000000063eff005de19ac13-- From xen-devel-bounces@lists.xenproject.org Tue May 03 11:31:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:31:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319524.539781 (Exim 4.92) (envelope-from ) id 1nlqkn-0003WD-VB; Tue, 03 May 2022 11:31:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319524.539781; Tue, 03 May 2022 11:31:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqkn-0003W6-QN; Tue, 03 May 2022 11:31:41 +0000 Received: by outflank-mailman (input) for mailman id 319524; Tue, 03 May 2022 11:31:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqkm-0003W0-Gz for xen-devel@lists.xenproject.org; Tue, 03 May 2022 11:31:40 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97d899a1-cad4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 13:31:38 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1651577492033577.5969784216805; Tue, 3 May 2022 04:31:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97d899a1-cad4-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1651577497; cv=none; d=zohomail.com; s=zohoarc; b=keIcmYiTU2s1Fi2qPgffgv1u+MA1PHR3409YrnaLrAXovoCqHBffuxXO8cbYkav0vKBkV3CZRjyoJx1L8ZFCXX2K2gLQ2rZpu0DemhWTflNXNlFB8ndhzEvscLSiJ5770vvNtomQVamXHMnAZd5L8mz9P8rPiqK5MipsCkpy2+c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1651577497; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=L9QqY4cMLNeoXiV3OJDVAFImgfcLfNv3geetzMx4Tp8=; b=OqlcPMYvuymDDIszZ0SGDqbsmImsmk23FZbh5mONDupPESnVd3sQpOJpgXKm1xrxuFWuTo6vPCiscJUmc6LU7l1uAweJF0K9qiUSIYkIfY3OIit0FZZ0xiI5Is9fbUkPNql6wUDBv2321tai4bd2A/F3GorQUJ1DDGnLTp5at6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1651577496; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=L9QqY4cMLNeoXiV3OJDVAFImgfcLfNv3geetzMx4Tp8=; b=ROj6nSGpYmSBLcH+Kp+FnLrl/O//Ldz2hQHEfXPjofH+jbbZbJyarryz53T4P8Pg qgh38CNIh9vU2tBrpotScSuwS6YOi34vh8IPAGz0N0VORD9vw6z0gNlS4rtxJpj53Il CgVu4t++UX3RCNO8bgQn8NDm1o+zBtSU8AVCx5JA= Message-ID: <89aad289-8ab9-c43f-f048-b302bcc0f568@apertussolutions.com> Date: Tue, 3 May 2022 07:30:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Luca Fancellu Cc: Jason Andryuk , xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> <15634549-bde3-873b-862c-37ebb891ba0e@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/3/22 05:43, Luca Fancellu wrote: > > >> On 2 May 2022, at 14:53, Daniel P. Smith wrote: >> >> On 5/2/22 09:49, Daniel P. Smith wrote: >>> On 5/2/22 09:42, Jason Andryuk wrote: >>>> On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith >>>> wrote: >>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >>>>> index d5d0792ed4..b9057222d6 100644 >>>>> --- a/xen/arch/arm/setup.c >>>>> +++ b/xen/arch/arm/setup.c >>>>> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, >>>>> /* Hide UART from DOM0 if we're using it */ >>>>> serial_endboot(); >>>>> >>>>> + if ( (rc = xsm_set_system_active()) != 0 ) >>>>> + panic("xsm(err=%d): " >>>>> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); >>>> >>>> You want to print rc in this message. >>> >>> Thanks, but now I want to figure out how that compile >> >> Ah, arm which I do not have a build env to do build tests. > > I’ve built this patch on arm (changing err to rc), everything looks fine, so with that > addressed: > > Reviewed-by: Luca Fancellu Thank you and my apologies for not adding your review-by this morning. I had v6 queued to go out last night and missed this email before releasing. From xen-devel-bounces@lists.xenproject.org Tue May 03 11:38:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 11:38:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319530.539792 (Exim 4.92) (envelope-from ) id 1nlqrU-0004LK-Le; Tue, 03 May 2022 11:38:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319530.539792; Tue, 03 May 2022 11:38:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqrU-0004LD-IB; Tue, 03 May 2022 11:38:36 +0000 Received: by outflank-mailman (input) for mailman id 319530; Tue, 03 May 2022 11:38:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqrT-0004Kn-Pi; Tue, 03 May 2022 11:38:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqrT-0001k4-O2; Tue, 03 May 2022 11:38:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlqrT-00009H-HN; Tue, 03 May 2022 11:38:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlqrT-0003Ir-Gs; Tue, 03 May 2022 11:38:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WMyz+zBDijbnP356oqQc4g4jcERjSYaWAc1cljA7Pk0=; b=BJaXGFRxPG8YbWHkbeMcGNFCz+ 1Fy9DgH1nLlinNxC50Dai7MRyyUePVVOWIf4AoCP6DoOThtkLbbcpTIY66JJgwv8KaRD3UCRlWBT/ zmmNySel0I3myX18lDbbrBby0LlpZzBcF5evVddCTcEM68gnaMgHdNLbPgIdX9nOoYsE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170041: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 11:38:35 +0000 flight 170041 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170041/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 778 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 12:12:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:12:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319539.539803 (Exim 4.92) (envelope-from ) id 1nlrNl-0000ne-C0; Tue, 03 May 2022 12:11:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319539.539803; Tue, 03 May 2022 12:11:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrNl-0000nX-8y; Tue, 03 May 2022 12:11:57 +0000 Received: by outflank-mailman (input) for mailman id 319539; Tue, 03 May 2022 12:11:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrNk-0000nN-4p; Tue, 03 May 2022 12:11:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrNk-0002JI-1A; Tue, 03 May 2022 12:11:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrNj-0000uR-Jn; Tue, 03 May 2022 12:11:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlrNj-0005EG-JI; Tue, 03 May 2022 12:11:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A5u2Doe9a4IrhcsYpss3DofqeRUcLnk2D0fmN6vzMDY=; b=1n655yFZAaRy6J0tYqN7YoFOVa GxOywCFsGBo/Q7u/82JGh+PzDmc1d0AoipG+juZQU/5TY5ipOdbVU3OnGFXZMRWrXMzFqhPA2TauZ CPmUewLdDIiDVghke+rWSN5att5Eme6i7PliqUYAByPMwRaJaHPD7fsSZHZ7N253YsBU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 170031: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=dc88f9b72df52b22c35b127b80c487e0b6fca4af X-Osstest-Versions-That: seabios=01774004c7f7fdc9c1e8f1715f70d3b913f8d491 From: osstest service owner Date: Tue, 03 May 2022 12:11:55 +0000 flight 170031 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/170031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169167 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169167 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169167 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169167 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169167 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios dc88f9b72df52b22c35b127b80c487e0b6fca4af baseline version: seabios 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 Last test of basis 169167 2022-04-04 21:41:47 Z 28 days Testing same since 170031 2022-05-03 08:44:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 0177400..dc88f9b dc88f9b72df52b22c35b127b80c487e0b6fca4af -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 03 12:22:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:22:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319547.539813 (Exim 4.92) (envelope-from ) id 1nlrXZ-0002Qn-AW; Tue, 03 May 2022 12:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319547.539813; Tue, 03 May 2022 12:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrXZ-0002Qg-7g; Tue, 03 May 2022 12:22:05 +0000 Received: by outflank-mailman (input) for mailman id 319547; Tue, 03 May 2022 12:22:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrXY-0002Qa-EH for xen-devel@lists.xenproject.org; Tue, 03 May 2022 12:22:04 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7e1b::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a25a972a-cadb-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 14:22:01 +0200 (CEST) Received: from DB8P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::26) by AM6PR08MB4599.eurprd08.prod.outlook.com (2603:10a6:20b:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 3 May 2022 12:21:59 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::76) by DB8P191CA0016.outlook.office365.com (2603:10a6:10:130::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Tue, 3 May 2022 12:21:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 12:21:59 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Tue, 03 May 2022 12:21:59 +0000 Received: from 31aacb8ab9c8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77F88537-66E6-4775-9497-770C1535E879.1; Tue, 03 May 2022 12:21:48 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31aacb8ab9c8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 12:21:48 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by AS8PR08MB6904.eurprd08.prod.outlook.com (2603:10a6:20b:394::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 12:21:46 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 12:21:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a25a972a-cadb-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ipHnqoMr7z79jaXjJSeaQyrzVHLU2ucGIDI1pAu+H2gHJjp+azfzq/UPtNml9QiR7ZWOPjf5B0aJmpZ+WqpoM1j7oZMnlV0n+RzO5OYByFx52pW7Y4q8f8DS6FNcra0913V77jhg24xTsuZfvofzLzj24VpbTsP11V/a168beK/qVasf9vbFyK/GOsvQHkzKp7tFo9AorztJbcLAVObXoA78Mvy0tbZCnjlbXk2ZYV4ViWhrhuNhpE0ikKInXRxUoA0wSn90sRzyiYXN6UmP+1hVpUzyl6cryM5PeZSOeP8ZOyz8EXec79XTeX/uc15FHY9cOTiWuVytGFuCEYmQ/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=K+N06bl+h/lmlPD1jKveGArfXlImNavO5JkP31XxNH1QNGyHN4dJ9vJvGZwfgIFVKY/Qf2sndtHZMIcLycv4v8iV8x8S4cgP2SYH47qbWTjaX5GZtqQaay8LBMMpvcUnLIRJ2Q9dF7zmb45xxKQYYebBQxTrrSuuDvTZzH7M+z1yEQpASA1NfVW8g4aKVCkgTZNmAh0aSDzDq/PHTyY3hjl4p+kz/ov67no5djSFSIKAuFuaLC/vk6B3pldKbjB3aK0SeUh+shF5+6Xxg6CUTtu4+MwCc3LoRGKUjYFduDdVcGffYmZETzHMRCFYVWe25A7cJXMJ+d1whHGTqmPclQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=BOwlr9JVxqj/8qWeInWZs7XCYXJvKZJHr5WD+18FpcNsCm/VLdAZSqyF83JZiMx7PG4BfMKck9Hc5mbKezer3SM/Wld/Vj9VV/tIz945DHY/lDtyH0wrnlp5v/BOhLVG9DowIK5nnzUXNglT1AlRzYhkDwoBfXAYo5TH1klevtg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: cd1c0667f994701a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgHZ0cg99AHbsYXC3Autgv1Jj7Jkk7qG7XohPFva85z9Xu8u61sGlZbqzaKx4bWuNbDGEw8hiTwilCqYLWQGwxNo2G9Sk0plRHbQmjhvPbJFFTZecDdIhL3PJURtrMz8taTGT/XIPIM/2yv79EBwHIEsV3eZG5ZSxrRTlf0rHALHpGQxsrngY/pwfg9Ze9zeba4zGRUk2AITjRwODJdKkgwO0TSKILtVVAjStWHFN12PPobeyK1nhk4GFKvrXJw7TbatRR4lBrU/UsImQtslzkYOTjWTE4SosRXRUbRh+ZStDjI5ldevT8NJidBtTnBe5cgOmJaqNhjY7rCjgijNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=UErwgLDWU/+8utvI10hRKQ3gjhwVHJ6uxmQJxsOqWaR/TZM3RvUtLfA5UN9DYy7FxVSWW+SWeyc5rhMYCzXNCyM7+QHyZAU6sKoeM+tFUm1i4t5WkaaUawhGmbhBwSm7l3aygR0h9zITjAjXkI2pQp2e4C3EdsoX2QgwIAVokJ8zap0iiZY2asMmSWnwrKMbHAMoRCNrL0/q31M+0j+adX7asi5CcI+mm6ZxqXuw4K5rnNYx1neI9h/ifPLMGKSmZOwSj1OJggbWgRfgCzIXcpPFxa79XM1mDLMbxSIlP/QM4XJgCp26hoDgLB6VuMwWQKSFtgnM+M6jsi5o8dvrrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=BOwlr9JVxqj/8qWeInWZs7XCYXJvKZJHr5WD+18FpcNsCm/VLdAZSqyF83JZiMx7PG4BfMKck9Hc5mbKezer3SM/Wld/Vj9VV/tIz945DHY/lDtyH0wrnlp5v/BOhLVG9DowIK5nnzUXNglT1AlRzYhkDwoBfXAYo5TH1klevtg= From: Luca Fancellu To: "Daniel P. Smith" CC: Jason Andryuk , xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Thread-Topic: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup Thread-Index: AQHYXijv9StER8938kifKUVqRlYIt60LmLoAgAABtwCAAAEnAIABTJWAgAAd6QCAAA5LAA== Date: Tue, 3 May 2022 12:21:46 +0000 Message-ID: <375845D4-92D7-4B8B-A030-019CCB0DADDF@arm.com> References: <20220502133027.920-1-dpsmith@apertussolutions.com> <20220502133027.920-2-dpsmith@apertussolutions.com> <7db6b050-7ace-406f-550b-d407c57cfa59@apertussolutions.com> <15634549-bde3-873b-862c-37ebb891ba0e@apertussolutions.com> <89aad289-8ab9-c43f-f048-b302bcc0f568@apertussolutions.com> In-Reply-To: <89aad289-8ab9-c43f-f048-b302bcc0f568@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: dc7c73ac-5867-4a7a-67cf-08da2cff8554 x-ms-traffictypediagnostic: AS8PR08MB6904:EE_|DBAEUR03FT052:EE_|AM6PR08MB4599:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Eklefom5rVnhX5bC7d4Q3bio+cvEfUWQxjeH6jLDS4QuKIPEQzZa33O6NUlrzUPUH7cR7BBwQdjEh1mGpQ6qzBnF5HZNMUrJHmr5PHMmWxcds1P47bartJWVEMunUh+NHtkYg8aBMDyVOuzOV4xZTUUgDYdbFZeVk2Py2VW1P0l2Y+xE9v4QydV6fBgUZPNrdTBvrqVrtwRCQgkt1ecM4u7XuHPvcBs1LzbCzWLQwagRbhgo1TPG1fqgnDzuL7+rKRoUObmkZ8N1NRI07LW0+C8IYXhejaPNFMUb9cyf5H8+uzAJOV+pyCCdxLVFfge9bASgD9dO8JzuhKSFl0Y4kbMSF+pDMLVCn7qiebnWhdEQ0l4RIzlZmfHvRkpVHlGpR5QWLLivy2Hyge2aIH3zsPIwwk3512G53jW1F+UspzsxJLHgkhpvcbKMZU9XEaYifbZFSHhAKTz3Swj+L0m9VNsELT6HUfMjHbqW/u7l2/huh2nQ8KDNNfYwmmHnJNJSawhjCOjtcM4cuz0km+wORXP+UzJ8Cdsyz+xPa3Xz376IGCJmopLjooL05WwHzVBOYpHe1eDbyefk41LJc+K27i8qmhJOUD8LnmnTgMm6Yv7ES8U3KMCE/BI9U/ZtsAy/cTLCzXrfeycNJF7nIHtJmN6/ja4QmEw1GdTmstFRsOyI0lU/VKNWVUZK0aFqIU9Mx/IGc58SDAbsMgy4zH7IOD+wohijbPygUhNsn4OHhaZV/6tm3IJLMdKpFNCnAUnU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(83380400001)(71200400001)(186003)(86362001)(38100700002)(508600001)(6486002)(38070700005)(36756003)(26005)(6512007)(4326008)(76116006)(2616005)(122000001)(66946007)(8676002)(64756008)(66476007)(66446008)(66556008)(6506007)(6916009)(33656002)(8936002)(316002)(5660300002)(7416002)(54906003)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6904 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cbed2737-dec3-46d0-9a94-08da2cff7d91 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2fJoYVMpqpLQAW+L1eWnaQhp07UNx2uVKtUFz2b8kvA1VYifT3nUzROEmGqhj8laK4Lz7Kt8WZq61fbg/jzt4hPdWjRGa07NvrcH+R99HrXAgD6PCyFst6KKwY7JH4Wwi7X5g67Lh6+QpcrYnrMwawFmkZT6V6uISeyC1AZGnNYeYZ/BAQWUToB3vTIFnctFIdSQTF3NjNjigza3aFrSPOAY7XG6PbLicobHT/EwhTS4FeievF1nTBIxz7OqmrKWm8EZbV81b3tl2fxbQqeAcw1ct4NhoI/GPuM0yoQVJO46XrJArMTWg4twqo3c8BI2+OPDcgMxF8C/6nXcDSqY2cHN2wwEi+12S52buKZrU8bVK5K7OxXXVNJ8g8AumYe7LC5vyfgp5vKL6nn55fW04LOlPrBdcpWcx88H+Q/D4gU48CbxubPYnm20VqURBG+2BTsnSc28Lh730FEfKmLpQwmD902k/XWvr5MvPcE7V27XFy5SgR2ehSNCkPuHf3iJaPEscGrSC+GYgLc4l6mCxCaushdsyKd2vUTJpLrkrbH+ZLeKg8rQvb+L3P1IjAZM4JZdPxPiBj/IeQxuwpE1hMZi1SghElhYgyH/Fkqvaxk242fGNqOShuIxjr5rIboUDrkmPOAPc9fPANMDZyaBMAptC7FrAMF9QGoHx8mBGCPydko/yvZOu68gi1FwJXXU X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(186003)(40460700003)(33656002)(336012)(6486002)(54906003)(70586007)(47076005)(70206006)(82310400005)(2906002)(83380400001)(36756003)(8936002)(5660300002)(2616005)(6862004)(86362001)(8676002)(4326008)(316002)(356005)(6512007)(26005)(81166007)(6506007)(53546011)(508600001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 12:21:59.1530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc7c73ac-5867-4a7a-67cf-08da2cff8554 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4599 DQoNCj4gT24gMyBNYXkgMjAyMiwgYXQgMTI6MzAsIERhbmllbCBQLiBTbWl0aCA8ZHBzbWl0aEBh cGVydHVzc29sdXRpb25zLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiA1LzMvMjIgMDU6NDMsIEx1Y2Eg RmFuY2VsbHUgd3JvdGU6DQo+PiANCj4+IA0KPj4+IE9uIDIgTWF5IDIwMjIsIGF0IDE0OjUzLCBE YW5pZWwgUC4gU21pdGggPGRwc21pdGhAYXBlcnR1c3NvbHV0aW9ucy5jb20+IHdyb3RlOg0KPj4+ IA0KPj4+IE9uIDUvMi8yMiAwOTo0OSwgRGFuaWVsIFAuIFNtaXRoIHdyb3RlOg0KPj4+PiBPbiA1 LzIvMjIgMDk6NDIsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+Pj4+PiBPbiBNb24sIE1heSAyLCAy MDIyIGF0IDk6MzEgQU0gRGFuaWVsIFAuIFNtaXRoDQo+Pj4+PiA8ZHBzbWl0aEBhcGVydHVzc29s dXRpb25zLmNvbT4gd3JvdGU6DQo+Pj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zZXR1 cC5jIGIveGVuL2FyY2gvYXJtL3NldHVwLmMNCj4+Pj4+PiBpbmRleCBkNWQwNzkyZWQ0Li5iOTA1 NzIyMmQ2IDEwMDY0NA0KPj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+Pj4+Pj4g KysrIGIveGVuL2FyY2gvYXJtL3NldHVwLmMNCj4+Pj4+PiBAQCAtMTA0OCw2ICsxMDQ4LDEwIEBA IHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nIGJvb3RfcGh5c19vZmZzZXQsDQo+ Pj4+Pj4gICAgLyogSGlkZSBVQVJUIGZyb20gRE9NMCBpZiB3ZSdyZSB1c2luZyBpdCAqLw0KPj4+ Pj4+ICAgIHNlcmlhbF9lbmRib290KCk7DQo+Pj4+Pj4gDQo+Pj4+Pj4gKyAgICBpZiAoIChyYyA9 IHhzbV9zZXRfc3lzdGVtX2FjdGl2ZSgpKSAhPSAwICkNCj4+Pj4+PiArICAgICAgICBwYW5pYygi eHNtKGVycj0lZCk6ICINCj4+Pj4+PiArICAgICAgICAgICAgICAidW5hYmxlIHRvIHNldCBoeXBl cnZpc29yIHRvIFNZU1RFTV9BQ1RJVkUgcHJpdmlsZWdlXG4iLCBlcnIpOw0KPj4+Pj4gDQo+Pj4+ PiBZb3Ugd2FudCB0byBwcmludCByYyBpbiB0aGlzIG1lc3NhZ2UuDQo+Pj4+IA0KPj4+PiBUaGFu a3MsIGJ1dCBub3cgSSB3YW50IHRvIGZpZ3VyZSBvdXQgaG93IHRoYXQgY29tcGlsZQ0KPj4+IA0K Pj4+IEFoLCBhcm0gd2hpY2ggSSBkbyBub3QgaGF2ZSBhIGJ1aWxkIGVudiB0byBkbyBidWlsZCB0 ZXN0cy4NCj4+IA0KPj4gSeKAmXZlIGJ1aWx0IHRoaXMgcGF0Y2ggb24gYXJtIChjaGFuZ2luZyBl cnIgdG8gcmMpLCBldmVyeXRoaW5nIGxvb2tzIGZpbmUsIHNvIHdpdGggdGhhdA0KPj4gYWRkcmVz c2VkOg0KPj4gDQo+PiBSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBh cm0uY29tPg0KPiANCj4gVGhhbmsgeW91IGFuZCBteSBhcG9sb2dpZXMgZm9yIG5vdCBhZGRpbmcg eW91ciByZXZpZXctYnkgdGhpcyBtb3JuaW5nLiBJDQo+IGhhZCB2NiBxdWV1ZWQgdG8gZ28gb3V0 IGxhc3QgbmlnaHQgYW5kIG1pc3NlZCB0aGlzIGVtYWlsIGJlZm9yZSByZWxlYXNpbmcuDQo+IA0K DQpIaSBEYW5pZWwsDQoNCkl04oCZcyBvayBJIHdpbGwgcHV0IGl0IGFnYWluIGluIHRoZSBuZXcg c2VyaWUuDQoNCkNoZWVycywNCkx1Y2E= From xen-devel-bounces@lists.xenproject.org Tue May 03 12:28:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319553.539825 (Exim 4.92) (envelope-from ) id 1nlrdV-00034o-1d; Tue, 03 May 2022 12:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319553.539825; Tue, 03 May 2022 12:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrdU-00034h-U4; Tue, 03 May 2022 12:28:12 +0000 Received: by outflank-mailman (input) for mailman id 319553; Tue, 03 May 2022 12:28:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrdT-00034b-FZ for xen-devel@lists.xenproject.org; Tue, 03 May 2022 12:28:11 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0609.outbound.protection.outlook.com [2a01:111:f400:fe06::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e108529-cadc-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 14:28:10 +0200 (CEST) Received: from DB3PR06CA0012.eurprd06.prod.outlook.com (2603:10a6:8:1::25) by AM5PR0802MB2452.eurprd08.prod.outlook.com (2603:10a6:203:9f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 12:28:06 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::93) by DB3PR06CA0012.outlook.office365.com (2603:10a6:8:1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Tue, 3 May 2022 12:28:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 12:28:05 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Tue, 03 May 2022 12:28:05 +0000 Received: from 980bc8973816.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 925694CA-96C7-4F42-A6E2-257899924CE5.1; Tue, 03 May 2022 12:27:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 980bc8973816.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 12:27:55 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by HE1PR0801MB1641.eurprd08.prod.outlook.com (2603:10a6:3:80::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 3 May 2022 12:27:44 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 12:27:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e108529-cadc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mC3+NaSETCehIt2N3nW38TBnEYqNgVakrOy8QM/q0dC+s/lQ0bBCskmQFpir6xE6BREKZpyjVQYlCkzm1HE6IskYFprjCVsGwSGUpn64H3piAiuq6ELhaNYEYao9DOreD1LF19T+ByMDHIIOsoI3dIfiLSucc/QecwzCEYKuvLI2z6FkhusqNP/Na+tNkWCyuNgFx6K6l9CT6QqwlTr/HT37kHR11v1B3PTQGbl1yX/nN0hxxpxe8xXJZHVj+c0iT64fER3QgCnt48p1pq8ZOZGQ7m6wUIhTClhX1+UEyH4Z9K4F+BxPbdvKSsiCVF78AvSU3Oh7lRFIYyG+i/Ci2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+DjChccwRJy9mvIuY1PhsTOViea0ZZycWnYFbYUdB8=; b=O/QNanFsB9nDgVDGG9EN8xkTUXZI2e0apXkvzM5CgllSDE8g8iu9uULd4g1QlYcsMt3xEqA4RTZIf6n+dIA9lrind4U9FJ/5c9viBaKfeajBf2EGkDWtguhu6YmDvan5+jgX0JYMAQPc33xnbWibplsySuEB2za0Wqk5uDmk2pdDupvfxNpn/kql3f1nSgXfdLKOx/31bCZj4dgh8OpibXDiDUWTpGPJSxW1N7KCmLlPJaKHWdgmalMIDoMMC5n83S6qZQ3DNR31xrWZNC2OcjY2ssctD6Wn2pddQF0lbhpltcvQJWrspPS5Kbj91fNTh1mV24MZojUyOL1PqZmrCA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b+DjChccwRJy9mvIuY1PhsTOViea0ZZycWnYFbYUdB8=; b=QpXktlUFkVdlA8jyXhmQl7u831Et86X75ieySZQeIq7TtM8e/XZ1XG15TYRaKda8LSk4Z50jlGRLBMlwC3GHnPHO6hJ8Y3t50kEp9kbBovZ+H51NCOUSzMHniKV8rQh0+9I9k4I6gxlX4DAyBBpx+7BQuPCDPCWFsly1jF0XpZY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7ccbc0f7eaeaeec8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k82HZsvfoFV6EgR4LdMt7yCmUtSpnzvh17OjziK58Kl8htMBiI2GHnnt6kgSsJrdR8MyRMGLhyMvU/Y/TBlRs97c1K/l+fL30me5JfBM/PrmndgjtrsIc4EBJCTeNYQFpgqcC4u33Z9Rl28jhPBSnEuDKjyoMFyn3x4WFepJy7RGpY8BY9V2nQqn6v0uI3zzUgX7P5s6mkgZc+QTs6TLg89VPsC52bPasndDh33uJgMc4RRMJH7Z7wuCgsTbtfZu+3rVE6diVqSbU6c6fTsucyIeOzGY/DCN3gY9lZ7epIn+zuxdMUJZjOmRhA7n2TlAPBHwMcnykFEICWITCwxdjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+DjChccwRJy9mvIuY1PhsTOViea0ZZycWnYFbYUdB8=; b=UhuK9lelkW9uReC4+kDGM/pwCF1iUpf073iJEbjDOnMbkV8ZEveWjKyRlDf5s/qIWVeIZg7lFw5Dk13MsxE30wvg1hOZRF2Z2Bk5kYNav5Pye8eumZvw7IMRAwZcenzcGhv9FCjjZfjD5tddrVj3f8DHVAfta45EmuM6Wlq8T4u01knisNmlmIJHd5k2lAkMxynRS3vSPpeQRAh9WOWYFZBOGXN05gF9Fjnlh8bwAGQoP1/8p17PFVCpDDJzAVn7cRnUpsJ+yiSqHec95dVLShX6sSounMAn+6DV6KaFxo3GM9npOOge+U8Qpwp5HMXVUc9eK+rVhj0dsKGKQEqu9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b+DjChccwRJy9mvIuY1PhsTOViea0ZZycWnYFbYUdB8=; b=QpXktlUFkVdlA8jyXhmQl7u831Et86X75ieySZQeIq7TtM8e/XZ1XG15TYRaKda8LSk4Z50jlGRLBMlwC3GHnPHO6hJ8Y3t50kEp9kbBovZ+H51NCOUSzMHniKV8rQh0+9I9k4I6gxlX4DAyBBpx+7BQuPCDPCWFsly1jF0XpZY= From: Luca Fancellu To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Thread-Topic: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Thread-Index: AQHYXt+O5KwXx13Nl0CUGYEFbsIOk60NFJ8A Date: Tue, 3 May 2022 12:27:44 +0000 Message-ID: <07F5E21C-7C09-4623-81B6-5D9F0633DFED@arm.com> References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> In-Reply-To: <20220503111731.12642-2-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 332ebc40-2bfe-4960-ff2f-08da2d005fd0 x-ms-traffictypediagnostic: HE1PR0801MB1641:EE_|DBAEUR03FT051:EE_|AM5PR0802MB2452:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FObFdCOJzhd1hke61JeI9bfOewtuZ68lDuhA4sNxfb+1Ya9cIot+jfxXEx3c3g5Q00E60lSjRIMRdh3UB6l47TeftIxPmPm/OmyHdxPopuuWVXWcg7ffgAmhXIvqQlubxJfBLo958QwpVRyhJ3K42fv0tm/qRMQjBEto/1qu5hrHil3GHPNqLZgU5ihFHTg9t9b6qpKPP7ujcBctRmcjNyUZoksKid8IohgARpiQkIUBiO8RRaOoBJtllJwuRXyOCC0RiFyqtK5B/xB36XlI2W8JtKzg8pBo8K2dAeSfhwEDKrv7Bv45hJ0UvuQW5ToR4OHGN4qcn8cztpQM6cX0g+2d4t93TEyBWrPwIr8cQ6tjMJtFBTFnFpPgk7Uq9Zxh6XhAkcBd2BsvIqLFu8FjLwlruaKOl9YcEHE4wvtrsJ7RlQpMZj5C+LNCqhcwgsCT77BzEMJMvYDcVnB0dOCG48kvjH6E5bd+aeNUhQj9xkHJ94rxrdS6ZWbE2CdrruPxtHR0cWbKDMKUa5ppNhyivSqdfI/rKDg7eddWt2QcveKAQS9Xee79BgBirKqt7MfO7QHQn+2mksHxCE0f3Xuv+oamGqUFa3KpmmPVlMfrMVRiYvbbgIzg16V1ow9HSE7YEH21sQUEe3E6L556Z5Zu1SbuGY8h1kbzjE8oLPS6vv38bz6RWjz+T1V8OA1CCDWUcG9rDHNAdUgf/lAllk6CW5JNUHX+Yxhlro5lKgBuKC4l66afHCvEFnkE/EGWlOfA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(66446008)(66946007)(83380400001)(5660300002)(76116006)(66556008)(66476007)(8936002)(2616005)(86362001)(186003)(26005)(33656002)(2906002)(6512007)(53546011)(6506007)(54906003)(508600001)(71200400001)(122000001)(6916009)(316002)(38070700005)(38100700002)(7416002)(8676002)(64756008)(4326008)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <466DB3C341D2D441B0C0F982872F9A19@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1641 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f96e51bf-a170-482a-a19d-08da2d005300 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jcQ7vPDJuZ1sAYjJ2AcrpxmK62eytGRBgcjQesFq0tCS49ilBTCwZHAvTq2B1f2Eq+nJ5hfU1eZgmk4nIIhrFutcqgSugzgS0k5ghczFaebhuCOOowPPE/b2PhiVeC251C/QboS64iIL+Rk79MBpeKOluX2DAjwvpQ2aL30vCte0dZKhDUryE4+s6j6Xlmre7soJu7xHslSF/c1T2oCKEnQljTdSyt955sEJW7t/Uqiq1qw/57bznmraV+BKR8NSYNsutsey+hMsri7XgyPDydtxRoj16iNSNTVjan3/x790NXcnRb4r6s/x6ZY/t2pgx2tk6zYv6wCqv+5Iov3uPBo5aqvzkKSRs80RcT1bvTyVoIwPgFaVtCJvWPo5Csd0IXrx7zQfHEY7lpr7nSSmp2r35YMjgOPfjNg6AyB2Gdpd7M9VO/ASPUZIeVu8UvyxTYnYtLAOzeCISliCBjtXyyk6LvyRqf2bPYuKXZxeg414A2uDYEl2GPesh2feVsc4I73SOmQ/d4ouyq0MrXaPiQ82O/6LJUz8CvfP1wBFmgg1ncS8d6boqymUOiTr9F+zgJrBxriFLoMMQNinokSPmeo950HiZ7VowvGsradgaIdsQBjsyoCNJFEp4UnGwR8WU8PFZxzw13dwBL14+D+/jtLB8SyJSGnQ5+k91tbPS0BKj9aHgduocbtKhe0/FV+e X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(26005)(36860700001)(82310400005)(6512007)(54906003)(6506007)(2906002)(53546011)(8676002)(4326008)(86362001)(33656002)(508600001)(6862004)(6486002)(81166007)(336012)(83380400001)(36756003)(70586007)(70206006)(5660300002)(356005)(186003)(40460700003)(2616005)(8936002)(316002)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 12:28:05.7128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 332ebc40-2bfe-4960-ff2f-08da2d005fd0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2452 > On 3 May 2022, at 12:17, Daniel P. Smith w= rote: >=20 > There are new capabilities, dom0less and hyperlaunch, that introduce inte= rnal > hypervisor logic which needs to make resource allocation calls that are > protected by XSM access checks. This creates an issue as a subset of the > hypervisor code is executed under a system domain, the idle domain, that = is > represented by a per-CPU non-privileged struct domain. To enable these ne= w > capabilities to function correctly but in a controlled manner, this commi= t > changes the idle system domain to be created as a privileged domain under= the > default policy and demoted before transitioning to running. A new XSM hoo= k, > xsm_set_system_active(), is introduced to allow each XSM policy type to d= emote > the idle domain appropriately for that policy type. In the case of SILO, = it > inherits the default policy's hook for xsm_set_system_active(). >=20 > For flask a stub is added to ensure that flask policy system will functio= n > correctly with this patch until flask is extended with support for starti= ng the > idle domain privileged and properly demoting it on the call to > xsm_set_system_active(). >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk Reviewed-by: Luca Fancellu Cheers, Luca From xen-devel-bounces@lists.xenproject.org Tue May 03 12:38:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:38:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319560.539836 (Exim 4.92) (envelope-from ) id 1nlrn7-0004m9-2u; Tue, 03 May 2022 12:38:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319560.539836; Tue, 03 May 2022 12:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrn6-0004m2-Va; Tue, 03 May 2022 12:38:08 +0000 Received: by outflank-mailman (input) for mailman id 319560; Tue, 03 May 2022 12:38:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlrn5-0004lw-GB for xen-devel@lists.xenproject.org; Tue, 03 May 2022 12:38:07 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e00a2b4b-cadd-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 14:38:05 +0200 (CEST) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 08:38:02 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN9PR03MB6122.namprd03.prod.outlook.com (2603:10b6:408:11b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 12:38:01 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 12:38:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e00a2b4b-cadd-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651581485; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ObH/qGbGICEOq1jzPGRDkQ2AO3LHWAuIwkDOzDnXjII=; b=ZWhdnuLxXqD6vhYWofZhKxYBTBGSDa3w6zwqU4+PVr0Ln5F4JNk1/3K8 iN2KYwK9K/YUG0zIi3PavwAoKyMlHpIsB3N2W8kJNFQzw69ciOF20Z9T0 0OLeo52Uxd0/hfntm5e3RlkZPbM+dVmuOGhlD/yKoEiy+lBbPt1o1CVeo k=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 69855749 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:v3boi6I9jmhuwms6FE+Rp5QlxSXFcZb7ZxGr2PjKsXjdYENS02NWn 2RJWzyFb/aJY2ahLtlyat7lox5X75PTyNdhGgZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Yz2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 N9Onp6eQCwGBffNlfwmXid+GARfOaITrdcrIVDn2SCS52vvViK0ht9IUwQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHsiFGv2QjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2CivLmAH9AP9SawfymzC8zAy27PUNuHZWoyTZulVtR+dq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0ZjZLO+gz6QXIwKyL5Q+cXzAAVmQYMIZgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:jbpjHaPviPCOX8BcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,195,1647316800"; d="scan'208";a="69855749" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YH8k2tzEDwdY0pZJCf5/wzEEzI4MsOsEW48LlQvdKQnpy3GATr+IvUiU34qJRb4JVn5oPsNNgbcGRWdeJ4FxtUiaXubS8ht4TYk5Or2E+k4cdDZ5MV+l2KzLTAda3wWFlOMjnis5wjq7eDRwqFLR+rnRzNJkgel5M1ipX/RVNInzAmV5he0E52ON4N6igcwjTmfCQ10LO6sM7UOKHxvlur+YOsWii0zLR9e8AFv5+jvNfcwildsfv16S1q1RjiqCbuTtE+phnevaqfRDeVbu/sOfOboMH3h1C2Bli6YyXzjpUle/Eu5o8PS7mOetgchos0URJ3YpFvo+9TnQ//mE+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mqF83QpIP/SYRtexbd+dCcyjdIUa1UXi2ZExKJFDhpA=; b=lLTxKUP+UKUtZhF6t15mFYkHE5Nd5cHEo+N2fyHtxZNgeYHlpYj8UQQsiaBgvMlnKXRSDsa59EDDlkG9Sdl1Ne4WBU4KasW9TV9Yjy4EbsjnXiB/Qh/lnkMWcmESSQAm86XcDlpI5hXOJDX5ge6UOo0JC1AiCgAMuGlge3UoZSJ8KeL46ADyiU/TvS1CQWhy1t6byJKtulfgCNEdF/WcmGVJ5QkF6rWMQd4YFX88DM89zFZ7fg7224CHZnHb8PXCtTK9KUaZGSR0lYMLjiOqdiZse4nLGfWdoafLYdb8t1xHd/eYJvPR7DnzijPBQLnMojfPiW61sOPVWN7BJqrsgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mqF83QpIP/SYRtexbd+dCcyjdIUa1UXi2ZExKJFDhpA=; b=DrvA0oWNzpPUH8CpwiFebYZYSO4ZvAaadj5RkfFYHWrGpvwDMJtG5l+I9RXdO5EVfWQQkqg40Q1C/RY5NMZiKk5RpJ0OaKqPwG1i4i0cQRnSrVQHIRFREYeabFzOFNEWr7aSNeauy9QofRB1fydV4MdhBMz8d7xd93EWOb3KS6U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 14:37:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 04/21] IOMMU: have iommu_{,un}map() split requests into largest possible chunks Message-ID: References: <227d0bd1-c448-6024-7b98-220271d9bf63@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <227d0bd1-c448-6024-7b98-220271d9bf63@suse.com> X-ClientProxiedBy: AM0PR02CA0143.eurprd02.prod.outlook.com (2603:10a6:20b:28d::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a8fe357-77a9-40ae-de96-08da2d01c270 X-MS-TrafficTypeDiagnostic: BN9PR03MB6122:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KIfrsuFLkEjzgX7DI37ris4CtUm+s2FPNlr4Qwrcn8UhYTEiObKoOs+T7Vroe24jhm1tXO0intweWKmFMEfru6vDq9kDOjKnJVQnRme0oN6dLhclea51YSKiftJK440G+8hSuwiAK675MaaNlvdwLDHRlJ81FLm7XlbWiYGMbHs3P8ska//fTVsr7fPaeX7ruOo6ME2VBjOrebOYC1yDpxj1OzH/cvUPh+bZ8SRYKvEWXujcoVYh1WT3myA5SqA8biYoa/24uok9bs87BXNuIu6miXf+dFDL+UoRkxg4LUJPZu3bezN7lM2NACVy4Xi5nAhPo08Bx1cV6FN5S1yZ6iq0vTVLVrZTjwlN1SyoRkVilCGIRBEVKpVA2v3M46/fSRN7YfKyP4UIwYAencOXofTKUUbLnH6E1gfkRllJBcBccUaCpzIiOD70nCIBwbUOHP2p7JvjLFPu+kwM57P4MW0uFGyq785rjvs8yYG59twG6N9IOInpEnxD8Exo/16Qk2V52kUvBDyaOIb3kbWJV+jT3StpDl1Zs9c2V75ECd0RSbuGpbtQorkYLN8tx7c5W5KF5DPgD4RmBTiZeA1UWftA5Qybwh6XxYD18GGQegylUfIgvL+qwajrqEyiPh8Q/aBCfPlagYj8tpCw3s3QRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(33716001)(66476007)(66556008)(8676002)(4326008)(85182001)(26005)(38100700002)(2906002)(6506007)(66946007)(6486002)(6666004)(9686003)(6512007)(86362001)(508600001)(82960400001)(8936002)(5660300002)(316002)(54906003)(6916009)(83380400001)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXlzV2UwemJNY1RmZkdOZ2luVkZ2S3Y0TEJjL3pBSUJ3MGdXTVhkeXVhcERR?= =?utf-8?B?LzVJZEpDU3crbC81dEg0a01qcEpFMnI5RHd6ZVNaWmNKV2JmK0x2SVpXQmdu?= =?utf-8?B?VFIwQ3BIQkpkbVRWRkJ6VU8wUnI0SGhHSEE5R1M3RkttVDRDd0F1N0hkMVc4?= =?utf-8?B?amJUVVhmRitvb3YycHd5eVNHYlExVnl5Qmo1Ky9vSTZGbk15eFRHb3dmbG9S?= =?utf-8?B?R0VkdGF0VXc3WHdKQUM3Wk9Oc05PcXc3MytsNmVTbmkvZzdRRStmSmNuS1Na?= =?utf-8?B?Y0VoUHdiRG1uQks0K1pwU2Y4aUVkS0dqeXl5RjhkS1k4Tkx4UU9hUTMwY1FF?= =?utf-8?B?VHpSSFVpQkxXQURvRmtDYktiUjNvTm1VOVdxRU1iN1pyTXpQNldacUFpUzNq?= =?utf-8?B?QzRERCtSWm1vTTNMYUVzK05SMzFFTjZRSU1KRmFrQUZseGFBTGNDZjUxMUtz?= =?utf-8?B?ZVVGV2IwazgramxuK2NyeGRvTzZ3ckRnSnpxd3NBZHFNVXExUnVDeUg3eFlO?= =?utf-8?B?YnB5QTFmYzJYNU83Mys2eklmbVk0WG9JdDVrVTVrOHRNTFpyR3FaaVROQXA1?= =?utf-8?B?a0JsOFNLVFU5TnpWTW8rbEFPWWM1VStLd3g0SC9xbmRQeWJEMlF3WmFHcTdv?= =?utf-8?B?UllFV3RBTDUvN3RVNkFjREhiYkdOWk1tUXk4Q3ZUZGlNTGtadUo5UDRtK2Zt?= =?utf-8?B?ZUtLRVV1RmhlR0RDS01vZXRSaUtkU2tJMGZhQzRtMjRSK0ErK0xRSUljMGZL?= =?utf-8?B?SHZLZGlrT3JjQ2RzTzFMZktQa1U4bVVmQkl2alNWUXJybVdteGhCU053Tlda?= =?utf-8?B?UzR5VXlGSmZqQlRScFQvRGpGMlJrYzIyVnk1aFVENEdKdC9SU0ZsRVlhdHNu?= =?utf-8?B?K3dVN2t5TnVmUEZrU3RnZHBwZytuQlJaODZqcEJFcHFJeEh5emZmbEhJNWVP?= =?utf-8?B?Sjl4dGMyTFN2dWluUFpQb3d1VEhKUk1uZC9OQ000MUw0M2JxbXV5VGhUUGgv?= =?utf-8?B?L3J0Z09zZWc4M0RtbDVBL2dySVVIamZ1Yy9ONVpLQjEySEMzMER1SFgxM1p1?= =?utf-8?B?Y0g5b2dxM0I1T2VzVmZSOUorR1Z2UG5OZk1NOGtMUkp1YXNVY0xIczBDYko3?= =?utf-8?B?a3JxNVNDT1VrdG9LZTNVdkRZMWQvNXV1THRWNXVpdVd3SW14RFhpT2YvOGl1?= =?utf-8?B?M1hLdUJrZUtxY2lBOU9XU3BzVUFrV20yZ2JnRjZPQ1JIZ1VCR1FyNS81Sko5?= =?utf-8?B?Y0NNVTdFMUJDWEtsKzZCMzlrZU4rOVNmTmRDUlJPMGd5RGZoTVNTYWliS1RL?= =?utf-8?B?a00wM0VnV2tWZy9QUDloaTZyZEhrakI3b2xvSXI3MzBxb20rS1NxRVVUS01G?= =?utf-8?B?b1RqUVlTcHVkVEpNSGtlNzBHOWRWOEJFNk9ubVdlZ0dxYUZKZXF1c3pLa29o?= =?utf-8?B?Y25RVnB5d2F0QWErSHRCeVdWQURsSGlPVU03ckpkVHFXK2U5Qm1jZTRmYjlD?= =?utf-8?B?RzhjYjl0L2tvYVNlckpTVmNyK29hWHBBTnMxQUpDMFBRN0E4cGRCNHVWTnRp?= =?utf-8?B?d3MyUGtjNzEzR2VabG03Q3FpaVdJa2w2WkhCdWxQQWoyMEhIdXJSQWUvT0NW?= =?utf-8?B?eVJqWDR0MVJQMFUvMktIUytsbTkxd0dXK0YxK0l4OE0raHViMGtYZjVlOW5U?= =?utf-8?B?RVBjZitrR3VuSk96K2E2S25WVnRBSDJDUkt3SWpDSjNwNW9MbFQ1RlpsSGlV?= =?utf-8?B?MEFuVlV0SFlWYzllWjhwb1M1dkVPMXE5bjFvUzZ4YmRzUW56ajdtM1pVUEtt?= =?utf-8?B?QVBXek45SHZWcVRSR0J2T25SSlpLYXFDcXZWeTBYMm0vU0VHK1hzZFJoWmVq?= =?utf-8?B?SlRiMmdZdERhT0tCdjVGanJPc3A2SkJ4Z2hGRUZQL0YzYnE0VHFMbHg2Y0ZB?= =?utf-8?B?a3pyU3dSN2dveXc3TkFhVlU5MkJ0U21BbUNyY3ZjWm4vcGtmeTJRdE5HNDl1?= =?utf-8?B?VDI3SnFwa3JOMWRjRUFxT0hOQlpacUVncUpHSmF2VnZLblorRHFXa1R2TnRq?= =?utf-8?B?b3YwMklROVh4NjNOYUdzblcrWnBVQnBQQ3d1Vmc3eCtVNDFOWG1hQU9lRnhi?= =?utf-8?B?VElXQktTMEJPdUZ4WmpyTUkvbHcrVFFIZDZWODVGVVZMNnI1eGRQMGNCZjNn?= =?utf-8?B?bTZ6azVUUHhmWjVveGpYdUMxWnB1TjFTSExlMlNReTFXZjNnVXFDS3RYWFpJ?= =?utf-8?B?YllFR0VCYnBsYk1Rd0x0dFF2MXFBNUFtYTdWYngwYWV3MkFmRmFEcWJqREJv?= =?utf-8?B?d0EvaGxQTXFnblZQSW9YMkdQaXptL2pZUWQvaDQ2ZEZrNzlZY2ZiRUJNeGlW?= =?utf-8?Q?Ffv8xtFe/oS9OU2U=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a8fe357-77a9-40ae-de96-08da2d01c270 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 12:38:00.9025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n8tn/11k5LUFVOb2Dk1k7xdCH8W+yrolNTJZbG5NtmvPDalc9tGJq9UgI2TX1+nVuZZ8s31UrRGNr4A3s3GkHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6122 On Mon, Apr 25, 2022 at 10:33:32AM +0200, Jan Beulich wrote: > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -307,11 +338,10 @@ int iommu_map(struct domain *d, dfn_t df > if ( !d->is_shutting_down && printk_ratelimit() ) > printk(XENLOG_ERR > "d%d: IOMMU mapping dfn %"PRI_dfn" to mfn %"PRI_mfn" failed: %d\n", > - d->domain_id, dfn_x(dfn_add(dfn, i)), > - mfn_x(mfn_add(mfn, i)), rc); > + d->domain_id, dfn_x(dfn), mfn_x(mfn), rc); Since you are already adjusting the line, I wouldn't mind if you also switched to use %pd at once (and in the same adjustment done to iommu_unmap). > > /* while statement to satisfy __must_check */ > - while ( iommu_unmap(d, dfn, i, flush_flags) ) > + while ( iommu_unmap(d, dfn0, i, flush_flags) ) To match previous behavior you likely need to use i + (1UL << order), so pages covered by the map_page call above are also taken care in the unmap request? With that fixed: Reviewed-by: Roger Pau Monné (Feel free to adjust the printks to use %pd or not, that's not a requirement for the Rb) Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 12:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319565.539847 (Exim 4.92) (envelope-from ) id 1nlroc-0005M2-E4; Tue, 03 May 2022 12:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319565.539847; Tue, 03 May 2022 12:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlroc-0005Lv-AK; Tue, 03 May 2022 12:39:42 +0000 Received: by outflank-mailman (input) for mailman id 319565; Tue, 03 May 2022 12:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlroa-0005Lh-VC; Tue, 03 May 2022 12:39:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlroa-0002nQ-UB; Tue, 03 May 2022 12:39:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlroa-0001VG-D8; Tue, 03 May 2022 12:39:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlroa-0001Tj-Cd; Tue, 03 May 2022 12:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=veorHaXLjFN8ox4cSk5F8ZhvtvPUt33AwYKOv6ukwSY=; b=tSEuNgAJvhY64eX2LNB8vfxp7c 6EbuvKjy/oqTvsXf9+2whCLUkCCUqPa5vGRZV2Fc/U/RUgCfEZQrfff3GoZaiBTu1WJj+jt9rV611 ym+P3ja3ScOj+qDanRLDdo8xGX8NGr3ebqsQn078paH7wUcBB7x0K8SaJQYN6BiS0DW0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170043: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 12:39:40 +0000 flight 170043 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170043/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 779 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 12:54:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 12:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319577.539864 (Exim 4.92) (envelope-from ) id 1nls2k-00086b-SR; Tue, 03 May 2022 12:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319577.539864; Tue, 03 May 2022 12:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nls2k-00086U-Os; Tue, 03 May 2022 12:54:18 +0000 Received: by outflank-mailman (input) for mailman id 319577; Tue, 03 May 2022 12:54:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nls2j-00086G-Ru for xen-devel@lists.xenproject.org; Tue, 03 May 2022 12:54:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2389548a-cae0-11ec-a406-831a346695d4; Tue, 03 May 2022 14:54:16 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AC9E71F74B; Tue, 3 May 2022 12:54:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 77C8713ABE; Tue, 3 May 2022 12:54:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PoIyG/clcWIcOgAAMHmgww (envelope-from ); Tue, 03 May 2022 12:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2389548a-cae0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651582455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OZcRYDL4mo/Uhq/Ypcn1akCbXvaz/7KYmlPdJUuwMeo=; b=biIOAekYyM13tqEMQ28BFriAekeD8a8AL/u0Thmc3kejLomQk8x2mqufl//RjpRJeKs/wv FMbdjUnDp7papJ/a10PQHD0jcN0KjaPcfSTpCUVcp+hZqquEHVst6HhCQc0AXUnTx/ywJI V/RjrV380KENZxqZIUyTpGa7Vg+SrIc= Message-ID: Date: Tue, 3 May 2022 14:54:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> From: Juergen Gross In-Reply-To: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------aJOfws9bZypWvjfxLcnIg1K0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------aJOfws9bZypWvjfxLcnIg1K0 Content-Type: multipart/mixed; boundary="------------oBvhHoX6mHtzA39drHHbQU0z"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> In-Reply-To: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> --------------oBvhHoX6mHtzA39drHHbQU0z Content-Type: multipart/mixed; boundary="------------Md7kWjLHF562CX34UgSWxu3K" --------------Md7kWjLHF562CX34UgSWxu3K Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDQuMjIgMTY6NTAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGUgbGF0ZXN0IHdp dGggY29tbWl0IGJkZDhiNmM5ODIzOSAoImRybS9pOTE1OiByZXBsYWNlIFg4Nl9GRUFUVVJF X1BBVA0KPiB3aXRoIHBhdF9lbmFibGVkKCkiKSBwYXRfZW5hYmxlZCgpIHJldHVybmluZyBm YWxzZSAoYmVjYXVzZSBvZiBQQVQNCj4gaW5pdGlhbGl6YXRpb24gYmVpbmcgc3VwcHJlc3Nl ZCBpbiB0aGUgYWJzZW5jZSBvZiBNVFJScyBiZWluZyBhbm5vdW5jZWQNCj4gdG8gYmUgYXZh aWxhYmxlKSBoYXMgYmVjb21lIGEgcHJvYmxlbTogVGhlIGk5MTUgZHJpdmVyIG5vdyBmYWls cyB0bw0KPiBpbml0aWFsaXplIHdoZW4gcnVubmluZyBQViBvbiBYZW4gKGk5MTVfZ2VtX29i amVjdF9waW5fbWFwKCkgaXMgd2hlcmUgSQ0KPiBsb2NhdGVkIHRoZSBpbmR1Y2VkIGZhaWx1 cmUpLCBhbmQgaXRzIGVycm9yIGhhbmRsaW5nIGlzIGZsYWt5IGVub3VnaCB0bw0KPiAoYXQg bGVhc3Qgc29tZXRpbWVzKSByZXN1bHQgaW4gYSBodW5nIHN5c3RlbS4NCj4gDQo+IFlldCBl dmVuIGJleW9uZCB0aGF0IHByb2JsZW0gdGhlIGtleWluZyBvZiB0aGUgdXNlIG9mIFdDIG1h cHBpbmdzIHRvDQo+IHBhdF9lbmFibGVkKCkgKHNlZSBhcmNoX2Nhbl9wY2lfbW1hcF93Yygp KSBtZWFucyB0aGF0IGluIHBhcnRpY3VsYXINCj4gZ3JhcGhpY3MgZnJhbWUgYnVmZmVyIGFj Y2Vzc2VzIHdvdWxkIGhhdmUgYmVlbiBxdWl0ZSBhIGJpdCBsZXNzDQo+IHBlcmZvcm1hbnQg dGhhbiBwb3NzaWJsZS4NCj4gDQo+IEFycmFuZ2UgZm9yIHRoZSBmdW5jdGlvbiB0byByZXR1 cm4gdHJ1ZSBpbiBzdWNoIGVudmlyb25tZW50cywgd2l0aG91dA0KPiB1bmRlcm1pbmluZyB0 aGUgcmVzdCBvZiBQQVQgTVNSIG1hbmFnZW1lbnQgbG9naWMgY29uc2lkZXJpbmcgUEFUIHRv IGJlDQo+IGRpc2FibGVkOiBTcGVjaWZpY2FsbHksIG5vIHdyaXRlcyB0byB0aGUgUEFUIE1T UiBzaG91bGQgb2NjdXIuDQo+IA0KPiBGb3IgdGhlIG5ldyBib29sZWFuIHRvIGxpdmUgaW4g LmluaXQuZGF0YSwgaW5pdF9jYWNoZV9tb2RlcygpIGFsc28gbmVlZHMNCj4gbW92aW5nIHRv IC5pbml0LnRleHQgKHdoZXJlIGl0IGNvdWxkL3Nob3VsZCBoYXZlIGxpdmVkIGFscmVhZHkg YmVmb3JlKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4NCg0KSSB0aGluayB0aGlzIGFwcHJvYWNoIGlzbid0IHRoZSBiZXN0IHdheSB0 byB0YWNrbGUgdGhlIGlzc3VlLg0KDQpJdCBjYW4gYmUgc29sdmVkIHJhdGhlciBlYXNpbHkg Ynkgbm90IGRlcml2aW5nIHRoZSBzdXBwb3J0ZWQgY2FjaGluZw0KbW9kZXMgdmlhIHBhdF9l bmFibGVkKCksIGJ1dCBieSBhZGRpbmcgc3BlY2lmaWMgZnVuY3Rpb25zIHRvIHF1ZXJ5DQp0 aGUgbmVlZGVkIGNhY2hpbmcgbW9kZSBmcm9tIHRoZSBQQVQgdHJhbnNsYXRpb24gdGFibGVz LCBhbmQgdG8gdXNlDQp0aG9zZSBmdW5jdGlvbnMgaW5zdGVhZCBvZiBwYXRfZW5hYmxlZCgp Lg0KDQpJJ20gcHJlcGFyaW5nIGEgcGF0Y2ggZm9yIHRoYXQgcHVycG9zZS4NCg0KDQpKdWVy Z2VuDQo= --------------Md7kWjLHF562CX34UgSWxu3K Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Md7kWjLHF562CX34UgSWxu3K-- --------------oBvhHoX6mHtzA39drHHbQU0z-- --------------aJOfws9bZypWvjfxLcnIg1K0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJxJfcFAwAAAAAACgkQsN6d1ii/Ey+3 Igf7BpIQ8c6ysulqPCIkyEw3p1kCKxgP8JBGblJfEGGMlO+cXYd7OFSAs/ANtJ+zR+pwlHZiAfn5 f7LPqjkF4EEyuixC8yTApbuqf+6N4mB4IvG/V/yAv29LT4H9mZCa7kPjrCWVdKFBWDZgP2UNXvUJ 60WWO1Bq8L7yLNKTfuxZj08Zk6AqIy8NMWBN7JeGeKqxa09IDcDVakEsmA2jAqQ4qbZVSf3X7+hl Bqccd+byU5CuC34hELfGdu2h1tU6d9u53Qxr0AqmE74QqlFLH4RnBOtoaKOkjUoFhk2cpsebumt2 h3AhEncj3eX/WsYkbkdtHPm2K6n7ELaehRcqrDjbjw== =EF2j -----END PGP SIGNATURE----- --------------aJOfws9bZypWvjfxLcnIg1K0-- From xen-devel-bounces@lists.xenproject.org Tue May 03 13:01:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319586.539880 (Exim 4.92) (envelope-from ) id 1nls9M-0001QE-QE; Tue, 03 May 2022 13:01:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319586.539880; Tue, 03 May 2022 13:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nls9M-0001Q7-NO; Tue, 03 May 2022 13:01:08 +0000 Received: by outflank-mailman (input) for mailman id 319586; Tue, 03 May 2022 13:01:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nls9L-0001Q1-Aa for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:01:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14a76436-cae1-11ec-a406-831a346695d4; Tue, 03 May 2022 15:01:02 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 09:00:57 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5647.namprd03.prod.outlook.com (2603:10b6:a03:279::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 13:00:54 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 13:00:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14a76436-cae1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651582862; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Q0917hcEFf1HWW3DvxSrw2xDs9UY6p3OuHnVBDbWZsc=; b=JlhGDS5HwFAP21Rgznfxjso1qJIfpl84/UczY5jQEVJAAgP3G0VcRbzh t6fpq9xky+u3M1YcQbkZx7U6QK6C6a0tPEenuFcwGHoZt6esO4dlBWCzF HagAo5/a2j5Kry2Aw7eWXRLQvmwSoHGzapsX7cFsD5l3U3Fl6m0U/HrNh Q=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 70485292 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1PUgr6ycqYAzeiiB0Y56t+dBxyrEfRIJ4+MujC+fZmUNrF6WrkVRy WpNUWCFP/jZMWqhctB3O4Wy8h4P78DdmIdjSFdoqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12YPhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplqZ60SBcPA/z3uttNAhAICHojPq5CweqSSZS/mZT7I0zuVVLJm68rJmdveIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeGuOWvLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianL20F8gPPzUYxy2KM5RJP0b3vCsr6dtq0VcByxkmgo H2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM+e8CMU/4QCJj6DSugCQAzBbSiYbMIB/8sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46T8ZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:4wZ186F9Z2fi8tt9pLqFdJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tOKL Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfgWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdrjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkloJk29Tpb+CUlpAZ/yHsMceg62w 36CNUYqFhvdL5jUUsvPpZ3fSOIYla9MS7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.91,195,1647316800"; d="scan'208";a="70485292" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NEC4jlbQi+UNUHO7S/aLtTstnl9davxZ0JdiaLK42nFTPZpovnlGH1Zt2kBkqUZzGlSMAEex60Iq0dH8jpjnBTR/oLn2xKAtalIshPtSLeBBQuErhtTIBgkD9U9Gg8rKuDh6OrNDYr7rT2AhQ8s3M0xyaCx+GiL9rEPY6QUi/ewsnJyzhje49IeEVTYPh7Lr1oxlwoSejD7hm2Rio3GS42hIJq+DSOznZ8E+x6BiKo6+aBlp66hpUjukYIVz9+B6K8t4YSGpG10SlPy/O4DHt2pXb907/BurRlXsG4PK3A7IJmSTZs1jDhNuR9/+0KoKfx/KgDO+VtcWJ7mTG1XYMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SP9Kd6HB6JoaU68ixnaQiyaoUqKOto2Pm+UKhzdX9o8=; b=a6g+SPwdpNbDuCqJXEo2EDAGU3DpivFpExKekp5dXAj6AbXc0/mHfkIakv74Ygi8/TORDv+f/oOP6N4ac4Z6zRo13rrCHPgkVPlGZnSrv4MFyTTHvQT6E+kvmJiLaJRpRJCB9KOORUbSzowo+ULd8sL7bz07oxhDDQASFn42GlQbzOXaZrW1SkasABvOV+Hr4PvaJCgFlIn2J2sGNs22Uzv1eolMXEEn1W4WKsC0kFF68fRePmqjpJyewIcfGMhvd3sppioO3wQ1d8V3DlYo24iVMJ8huT3ZTgJH9e8RgZPNEgjYpp4lrVeU3d0AZaNZo+H7yy30j35PK3yp+52aOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SP9Kd6HB6JoaU68ixnaQiyaoUqKOto2Pm+UKhzdX9o8=; b=nfU4/34Dua9AF136DVND/OmapUk6WL5U1ioeN+FdoBMOQoePbZlnZED0JopjtRwF84ccA7jiVflVUF01IzSQNQiQhXoovq0N1zMSNrEqaSSYTKIKGMcHIzUQKcnPH7eayBH6kDF/DK/2KNCD+6PeMV9GkLRgydTQXuL3HJ7KPj0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 15:00:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> X-ClientProxiedBy: AM0PR03CA0045.eurprd03.prod.outlook.com (2603:10a6:208::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a43d982b-e33e-4243-e5d4-08da2d04f521 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5647:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yuSzHA9ycBVWLJzUxPXQKQ0QlSRMDLbxBK0ybOO+Dmf7DlkLTYNMtFOPmuIKzx/qf8eBuF9pXzNAaf3yb/1dnEbtlUK1Nh3n3I+mjb08nfGRUcwqatHWGaSCO+2t3c9ySpkVFeA82K2iRkDX7vkbOvtmDF4LVzykXYruRtBP8ZkBm2+j4ZYIAqiCxMw8BfyZ3pZx9wdPjt/XvfqukRyDZ2PaWgHLkIPeSNKIms7lVSIrsfmIu1/JGB/tOWUqRKpppf94cWhJ20BXxy8N7fMrTfa8l3zB+q7I8vMNHJzbKK8Czw02L/dM3t6BS2a6/cWq2Q3pUDmN7Jj/9z9aE+Iqcu/lvUM6ARnVWduYDyHSI9rG1Xn1W+oqEMaE7vR9gta1W5JzqYQVQeo3FoyRDOI63TqmXSw45AwOxvcCLwAS9NMULPN9OMszm0ir+2+M61h3YxJttHIBpYxAar8eaFH2g6D0/7Blze8y+rHDDBJ4FJdDl/20FQUOyDZzT1poeCAmDS0Pc0HGcFaQdlzEJRDoio1zOeS4DOKaHkOVFoemr5Ccg2fY3njXUDGXeVARwGxa77zSZeYqSQBtqf3XwKYMwfcth5yfMw3+VQ2wmwUbgubRTVqHMRCMFmXgbjBpR00f/79goNGkO1qIqYoGhAKy4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(54906003)(66946007)(6916009)(85182001)(5660300002)(9686003)(66476007)(66556008)(4326008)(8676002)(26005)(6512007)(83380400001)(86362001)(6486002)(316002)(186003)(38100700002)(2906002)(6666004)(82960400001)(8936002)(33716001)(508600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V01IamtDUTl5S0lWSXJpSVVjdys4dHFvMXJmODE5WHJvTlBSQXgzUDlGL1lh?= =?utf-8?B?TENwRVpzaXN2VDJwbHZoWWc0Rm90UktUZlRqc0pUdjk3KzUrR2hjWjNQSWc3?= =?utf-8?B?RjAvSkJqWm5SVEFCZnJtNDdzMjVFVUF4dmwwd2txV3dpamZhYTZLQ21YdDVx?= =?utf-8?B?Y1pMTUlmdTVTYjk2ZXJOTW84M1FsdmIzVFpWWFFESjgzU0lUbG8zMWJsc28w?= =?utf-8?B?eXdEUjR1L0U4UGxwNnlrMlBWNjBYUWN4d1hUZm9VeGJXVE8rNjNid2M2dTJl?= =?utf-8?B?Z0R0YmxaREp0VUFzVmw2VFE1RkZXZVMyQUN4T3VMbHQ0aGZaM3A1aDV1STdX?= =?utf-8?B?OHd2V3NmSzZ3SGJIU2tqbWh3L1NzbUZDSzlhMDVKOTNZRnF1UjUrVjdYdDFk?= =?utf-8?B?TFluQnFpUnhHVS9CTzJCamlHMjNDdk1nV0JrY1l1aklwTnJjTUU2Z0NDYlVG?= =?utf-8?B?U0FmVHhzUFQ2TUxvRXg0Qkt3azJVL1BXZmdXcWdPaXFkOUFZaklJMURrUllU?= =?utf-8?B?QmlmaWdYd2ZoaDRYZWMxbTBYMVFlYXI1a3RFR3pmRWJQS21YL09JUGtxUEw2?= =?utf-8?B?cXQzYnNNbXpSUEJ3cjhzVFRUZDc3RUc1RzEzZnNVTFZCL2EzOU44ZTlkcWdz?= =?utf-8?B?ZU8zbkRMNnB0LzRRaHdwUnIxS3RmbEc2WnpJUHBaci93SFJFdmpTU1RwbDAw?= =?utf-8?B?M013SnNvalZCUU9VUXE4TEYyRjRyY2lkc0FsNDFPdkN1VWMyeGRZaWdxazR0?= =?utf-8?B?YzZWeHZzYXpodDBRa2NPNjZiVk40a0k1NDc4RFIwWXVEZXlqNVJ0bVg2aU5S?= =?utf-8?B?SGowYUhYS3V4MVVaalVtR0ZJVWFBZHNVeERzVUw0Q281Y3k0MDhtMGRYTitX?= =?utf-8?B?QUd2djJFUjkyNVZNZUo0SHl1MEpMZkIwTG8zQnYyLzI0MzhYdUltU2tUempv?= =?utf-8?B?TmtsN2V4dEhic01GKzJsaGVLSGNGS2hWNjZQTlBPSUIwd2hVc0ROc0x1VTIr?= =?utf-8?B?dFRJKzJtYTVwSUs0Q21jSm9HZnlaRDVhcDdZM1VKenE3ODM0R1lCVjlhYUhu?= =?utf-8?B?RjljVzJaa2h5dTQ3VFNiRVdEdlZnTi93eng5RTlkWXlyak03WEZtUk1SY2p4?= =?utf-8?B?T1R4dWIvZUNTazRlYVBHRTNTQUR3QnBybWZUamdUZE9WdHNOdVNMdTJadU5J?= =?utf-8?B?MlhtZHFTM0NOSzFKNk1xejVBQUFEUUdISDIzYlJtZjlSSmxxbGt2d1Mwa1Rr?= =?utf-8?B?a2JtcEtxek5CYm13QmlIY1NtdGtjWnAvZkRvWk1RdWxXNU1IckpyU0JaVStt?= =?utf-8?B?OHU4bUFpbEJoOTNXZGIvcUI2cTRubFJMWUtUYkt1Snk1WkdHbjdkTDMvTDR2?= =?utf-8?B?czhiQU9HS014K1pYQksxL3RidE1XNllXNVVKNDgyZFJVSGp6K2dCNjBpeFNh?= =?utf-8?B?NElmdEpmV0trd011RzhaTHF4U3dGUnhQZlN2L0N0YVpiSEV5U0QvT05KQmV3?= =?utf-8?B?cm5LZ1dVK3VIbWVCSVdoR3NINUpRUGwrL0h0TkFNcTBqWm1YZlV3MFhYM0hl?= =?utf-8?B?TVNTeDdrTU5PRUZmc3dyVTZjQ0RXUWtEckpra0p4REdqWnNBVU9mTzVPUkhw?= =?utf-8?B?aEFNZU14ekkvTEtWcTJ3dU52N3NFbnlBYmVhdld6dXh1WWdKaHovaXU0MS9w?= =?utf-8?B?aXlyemJNOE1tQmNMUkZBNk9PUXJrOGRaS2h6cmxDVEdPMU02VS81dlhsSHNo?= =?utf-8?B?TnE4UFNoTzNDS3grUUN3MVNqTUt3ZW8wTkptTTRzcFJKdTFQUVBDRG1yZkxW?= =?utf-8?B?WWpQL0dlUkRzVU91RTZIT1V2Q041WTdiejZSTThIOHI2Sjk4ZW93bWN5dlR0?= =?utf-8?B?cHVCdGc3SjVPdWZQdXhVV3M5bmIrRmRKOFVlQ2o5TFJlTVo5ZzFTWGRLdHZ6?= =?utf-8?B?QUd4Wmp1OG50MCtZQXhEVlhsMCt5QkhMaDlmelZPNENobEdlNzVkdkNFc3U1?= =?utf-8?B?WW1hZm1Ea0VJOXlVeEtxdjY0Z25TTlQ2YzQwaHNtR0YzVnVNSnVWMlNuRERw?= =?utf-8?B?WitpYWdZUTAwKzFPMUltaDVYVmtlQVFxUDFuVmdPWEZvSzR4cUxPazBDSWJN?= =?utf-8?B?aTZYMWxWNFBYVWdoQ0NFbG1kM3lkcGhPZjREdkljc0JtaTZMV3RBbWdZaFlH?= =?utf-8?B?TDBmcE01VHBiQU9xVVZoU2ZaUWpYM0xyOWJuVElnRzJ0M2tNblREYlQ3Z0xV?= =?utf-8?B?NFNBc2dUYVcwMW82VGwwL1hleWxNcXBMejNHc295VFNRTjYxblRZQ0doQytL?= =?utf-8?B?KzZHL1ZSRkhqcU5vN0l2eExtdGk0b3Vjd3JWdUcvandNcXoxVkRJM0lHM1V4?= =?utf-8?Q?biefnqreBtYo2EQk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a43d982b-e33e-4243-e5d4-08da2d04f521 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 13:00:54.3510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R0oUNspAuqOCdz94Hz09eK4QiVV8pW8LF9H1/Pl0YOou0QJXQ45iC0NMYabEEyUxr/QD0b7TplUJLbFq3Is0PA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5647 On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: > While already the case for PVH, there's no reason to treat PV > differently here, though of course the addresses get taken from another > source in this case. Except that, to match CPU side mappings, by default > we permit r/o ones. This then also means we now deal consistently with > IO-APICs whose MMIO is or is not covered by E820 reserved regions. > > Signed-off-by: Jan Beulich > --- > [integrated] v1: Integrate into series. > [standalone] v2: Keep IOMMU mappings in sync with CPU ones. > > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct > } > } > > -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, > - unsigned long pfn, > - unsigned long max_pfn) > +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d, > + unsigned long pfn, > + unsigned long max_pfn) > { > mfn_t mfn = _mfn(pfn); > - unsigned int i, type; > + unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable; > > /* > * Set up 1:1 mapping for dom0. Default to include only conventional RAM > @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map > * that fall in unusable ranges for PV Dom0. > */ > if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) > - return false; > + return 0; > > switch ( type = page_get_ram_type(mfn) ) > { > case RAM_TYPE_UNUSABLE: > - return false; > + return 0; > > case RAM_TYPE_CONVENTIONAL: > if ( iommu_hwdom_strict ) > - return false; > + return 0; > break; > > default: > if ( type & RAM_TYPE_RESERVED ) > { > if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) > - return false; > + perms = 0; > } > - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) > - return false; > + else if ( is_hvm_domain(d) ) > + return 0; > + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) > + perms = 0; > } > > /* Check that it doesn't overlap with the Interrupt Address Range. */ > if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) > - return false; > + return 0; > /* ... or the IO-APIC */ > - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) > - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > - return false; > + if ( has_vioapic(d) ) > + { > + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) > + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > + return 0; > + } > + else if ( is_pv_domain(d) ) > + { > + /* > + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o > + * ones there, so it should also have such established for IOMMUs. > + */ > + for ( i = 0; i < nr_ioapics; i++ ) > + if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) > + return rangeset_contains_singleton(mmio_ro_ranges, pfn) > + ? IOMMUF_readable : 0; If we really are after consistency with CPU side mappings, we should likely take the whole contents of mmio_ro_ranges and d->iomem_caps into account, not just the pages belonging to the IO-APIC? There could also be HPET pages mapped as RO for PV. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 13:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319624.539910 (Exim 4.92) (envelope-from ) id 1nlsPt-0004Sv-Lt; Tue, 03 May 2022 13:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319624.539910; Tue, 03 May 2022 13:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsPt-0004So-Ht; Tue, 03 May 2022 13:18:13 +0000 Received: by outflank-mailman (input) for mailman id 319624; Tue, 03 May 2022 13:18:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsPs-0004Sf-K1 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:18:12 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0602.outbound.protection.outlook.com [2a01:111:f400:fe1f::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ae0a841-cae3-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 15:18:11 +0200 (CEST) Received: from DB6P191CA0019.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::29) by PA4PR08MB7481.eurprd08.prod.outlook.com (2603:10a6:102:2a5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Tue, 3 May 2022 13:18:08 +0000 Received: from DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::af) by DB6P191CA0019.outlook.office365.com (2603:10a6:6:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Tue, 3 May 2022 13:18:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT016.mail.protection.outlook.com (100.127.142.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 13:18:07 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Tue, 03 May 2022 13:18:07 +0000 Received: from d1dfe553eb4e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9AB94707-63BB-45DA-B34B-06D977A6F0A1.1; Tue, 03 May 2022 13:17:56 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1dfe553eb4e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 13:17:56 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by VI1PR0801MB1758.eurprd08.prod.outlook.com (2603:10a6:800:53::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 13:17:54 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 13:17:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ae0a841-cae3-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FuobrphrFplM4uZya157kmdf9BRwf1xOWWw+BPbIugLEHncsCHNBEfL35W+DmN50bfpMFS1KUCdoPx2Pt+t+b5KsTI1w+USBqp+KSsY01K9WdpwNGqBkbCsmg7Z0s6Eu04zMminHOhVYW52ofLVHCTOeJI7t6UCsYB6HCL0R7jet7CahmS/xTgolg7Sajux1U21bMwLGmWJw202n1c+hZzWS+17c//8/GSa7ykC51ego+CRNWkC7Sv1PHQaxF2yyGWC6XBwqXWPry8GHf0I21bn+41o1PHlxG6Cmm3dEeu32yu3LV6k8jLjRpfc+Jqx+05MEdVv95Id5SA89MoZKKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=GiHK5k9ADypji67am1zxyOhCjeYN/KHVO6tjBUu5pkgCdc28qOXQ3SaLGEwdCtQyD4DvZjtYyPorh8Jzap/5ZiENrfN13qcUWmYkbbfocxc4ckt809YKTjBpEgRuiva/UVVRn2YTE0shuRDkjbYYErWqWnH1A/nWmsDnC0guLQIsmi0rjwiq4AFtgXgDpVI8eDfH3H6ZwJff5ifNILMLpFL39gJ1KXC6sYmrzlW9QcU22G13x120McZruQMGgNL0uF1M1Rr4y2DrJCT57XvO7htisd52jCf7ooQitL6+9FBWRdw39aNsB+lU3zKsD2j35aUKWae/duFiaqXUHOgOJw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=t8i9kItwwcrUNH0JNYgeN6S7txh+b/Oh+4yHLmGAK8Lu19JfvsOSNdllNEXD8ZD0haynf97BL00pAFVglFdFGIWEsq/0JRfMgGAbHhOBK9mEW2HayTeHVioUd5G/DAB5J690BXjcEwpMiGOLHOFHcdRwCZal6iOwQ38HQN4JM64= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 073efe158d8d88c5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJzzc0IlJ1pAm53MVorNpr9TpkUSaFBCOPb20cJ1a6i5B1ZqB6Paw8O7Cp/IO0mvnJiYLHC+LMvg3K3/OLr+5GT3qilm6helQIM3rE7Zc6tKFqW2xEwwTAiuG6xSay9r0mg8mO2zSoe/G4ZPKKdVrDUxOxNUHyqNKkMWvF0XR3AOi2qbqhuUAatLKZbOQgRiOsM8OlhE3IixCAESZDNr4Y6b0etJYYCmGB3exjr6GcuFGYDFaIzAjVcyBW+TAmejMHOPoTEZ5lBe44CjrJxKc95PMRT46U89QtBF+e3npJg1fVZAv7ezMduLlHsfEuQeYcS1FCQTQKR4KUa3CilAJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=Z8DUTJos6sCXMeUYe0YeiFpW89D3jaxGGBmYYVUgDJfeSVjZ9wJdjbo7Dl5kqHJsLcs/+NQToVzzWn0RrCG7xEWoT6wZyqyjo7VQ7na5P9koIuihFrEqduu1SxuW891PTAchObZzExcf4JYbf6mNgQ9fAwdcz0fOcDLA1NhtvOyJ/h6gtCP95JqbaEOc9msH/Yzs93HsHa1EPdmrRmXUIbKOBAyXmuU5JsnF+v0OH4EtWaCg77rD5crsW4pu/JT4WIET7rKZQpK4ahUvkRbdJlE13Wr8DSv8y4xBezjKH40fpJ+Ik1xhhdJKutZz1bJJ+gzsEMLdW6JR/aSlhVNtBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZB6UH105Pgd2TVvxfn8TNOxjI8TZycQoDY0DRRb3Ysw=; b=t8i9kItwwcrUNH0JNYgeN6S7txh+b/Oh+4yHLmGAK8Lu19JfvsOSNdllNEXD8ZD0haynf97BL00pAFVglFdFGIWEsq/0JRfMgGAbHhOBK9mEW2HayTeHVioUd5G/DAB5J690BXjcEwpMiGOLHOFHcdRwCZal6iOwQ38HQN4JM64= From: Luca Fancellu To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Thread-Topic: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Thread-Index: AQHYXt+O5KwXx13Nl0CUGYEFbsIOk60NIqSA Date: Tue, 3 May 2022 13:17:54 +0000 Message-ID: <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> In-Reply-To: <20220503111731.12642-2-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ed3ee555-76d7-43f4-7251-08da2d075d35 x-ms-traffictypediagnostic: VI1PR0801MB1758:EE_|DBAEUR03FT016:EE_|PA4PR08MB7481:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: R1DFegLEkMwXqROb+gTYEwt8pSdDjJy57yfMsGMAHseHSfdrzxwEsiOh3qcxNgp7gtZjhyL1yBeYuECO7RJE/k8EYW/Q7k7o7TXOFIv99NIhd97fzDiauqlXNqnkiGr4dOEBQBzC4ONr41GCSftZ3hRa2W7WyeIpM+bqC+CUOEQLRPPkc/s5BAg0oMn1rz0SNTHPSZeB422uXZgqEQPphPdEd/9zYutN2GUMenwCCM/dUIpRiGs2wTnAxCQvsCJGRp6mUDREEn2JxCZqmxYv0p4YGZxzwPTpr3ijWxVa976nkQhLFumBlkzwuIOvpFcBzPYrTmQ26YVQvl0zPjVR6zUJc/Afi3TungoIEOfSmOfMeLqEUEthYYYs/Dfd8IG4Wigii86H1Utk8uW6jZ9qb5LxPOodi5wL+mWuAvYzSDj2uTWWMNvF0/JEKICjqWDr4nax/hC4XNapu3ILyicXuvOF5wBCnAsER/NP2eqFL2DA/3/a+8UdRt6QgRXPVJu0hatG/ho1FH+udkEJr36aZQ5obS8L4bOUQXae57PUfYwihhsT2dg3ManU6mCziG3HKo7VnmvFOMWN89D5+PuogzIEbRs4ZzcC17cD/tdv3pbHFt5pzi1DC9ZjOJz5hFibIM0pmBgzD0nxJfVEnihoNU/jng1fkq0Zh+Mpq85c1cPKasz8itxjMUetcx/njqbfSuO//2LhV3AC8KT3Xr2EesXs9pU/Q2pEs1XDeuizFmI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(83380400001)(316002)(54906003)(71200400001)(6486002)(122000001)(36756003)(38070700005)(38100700002)(186003)(4744005)(7416002)(4326008)(8676002)(2906002)(76116006)(5660300002)(508600001)(2616005)(66446008)(33656002)(86362001)(64756008)(6506007)(66476007)(66556008)(66946007)(26005)(6512007)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1758 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d3da10e0-2d19-4c40-be79-08da2d07553e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BdWex7rvHN3RaqJdzLy/JDrsF8hf+ZlSRYNgxokZ59BVe7kZBZSaMxQGM2UgzWCM9Jwusnx+zosQwNrzyZgYxN7OGFu8UcQndcqP0ILuCtxXf8JJcI+CAEjEKNGiSImxTdYD/vvGwk/imvvppTnZN8tjEnK3PuaZS8sImHriCZYYEx2JZ59vXZKZ180y4erZ7UhQvpGqjxhqV0VWGZ1VKf/AxGExYBArzXCZrmQb4hsSqfYnJ+7uLhcUjO679910DgJ2Dex0WfsRVtdyiVbx+5mOycwOSuEhVa9faEqzwXECsdD7Cyu7jBiYxnGZzDhKbC4KoTrWWuExXcKnMcAiymWcav38mi3hsCvXEnij7xK8Q2NXlmrXNMW06IYjAmgWfg1qGZaQ3JrTcNldDsWWgQpu34Ft1el9wP27znBK6q+5kWP9GHgePGX3tSncByhZK4ilKSVilJz9bYFhLOxfGQ/rSg/mf9GoT79a4okF8rcssH5iLU0CP8DmeXL1czvEtf/Dl8sPQbpYqarMFIuH52u48jOhe+bjGufLVSl5wBw6hteNz9sKr8x0Ka3pVuKS/LluYXnygjoKbGIWCshNLkczdRgQKqi1xKnW/pxN2SkM2M2uXQJYtqew6zceC+quhbGYvV2IDDefqnRSy9JJL+tToLJIyVKFeOCIFCMP0am6OxIacFMfbj2MvA66R5Lz X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(33656002)(2616005)(5660300002)(6862004)(70586007)(356005)(70206006)(8676002)(186003)(4326008)(508600001)(36860700001)(4744005)(82310400005)(40460700003)(54906003)(8936002)(86362001)(6506007)(6512007)(316002)(83380400001)(6486002)(26005)(2906002)(336012)(47076005)(36756003)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 13:18:07.8151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed3ee555-76d7-43f4-7251-08da2d075d35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7481 SGkgRGFuaWVsLA0KDQo+IGRpZmYgLS1naXQgYS94ZW4veHNtL2ZsYXNrL2hvb2tzLmMgYi94ZW4v eHNtL2ZsYXNrL2hvb2tzLmMNCj4gaW5kZXggMGJmNjNmZmE4NC4uYjkzMTAxMTkxZSAxMDA2NDQN Cj4gLS0tIGEveGVuL3hzbS9mbGFzay9ob29rcy5jDQo+ICsrKyBiL3hlbi94c20vZmxhc2svaG9v a3MuYw0KPiBAQCAtMTg2LDYgKzE4NiwyOCBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIGZsYXNrX2Rv bWFpbl9hbGxvY19zZWN1cml0eShzdHJ1Y3QgZG9tYWluICpkKQ0KPiAgICAgcmV0dXJuIDA7DQo+ IH0NCj4gDQo+ICtzdGF0aWMgaW50IGNmX2NoZWNrIGZsYXNrX3NldF9zeXN0ZW1fYWN0aXZlKHZv aWQpDQo+ICt7DQo+ICsgICAgc3RydWN0IGRvbWFpbiAqZCA9IGN1cnJlbnQtPmRvbWFpbjsNCj4g Kw0KPiArICAgIEFTU0VSVChkLT5pc19wcml2aWxlZ2VkKTsNCj4gKw0KPiArICAgIGlmICggZC0+ ZG9tYWluX2lkICE9IERPTUlEX0lETEUgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgcHJpbnRrKCJ4 c21fc2V0X3N5c3RlbV9hY3RpdmUgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGJ5IGlkbGUgZG9tYWlu XG4iKTsNCg0KU29ycnkgSSBzcG90dGVkIHRoYXQgbm93LCBoZXJlIGluIHRoZSBwcmludGsgcHJv YmFibHkgeW91IG1lYW4g4oCcZmxhc2tfc2V0X3N5c3RlbV9hY3RpdmXigJ0NCmluc3RlYWQgb2Yg 4oCceHNtX3NldF9zeXN0ZW1fYWN0aXZl4oCdLCB5b3UgY2FuIGtlZXAgbXkgUi1ieSBhZnRlciB0 aGlzIGNoYW5nZS4NCg0KQ2hlZXJzLA0KTHVjYQ0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue May 03 13:18:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:18:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319627.539921 (Exim 4.92) (envelope-from ) id 1nlsQS-0004zM-UF; Tue, 03 May 2022 13:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319627.539921; Tue, 03 May 2022 13:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsQS-0004zF-R4; Tue, 03 May 2022 13:18:48 +0000 Received: by outflank-mailman (input) for mailman id 319627; Tue, 03 May 2022 13:18:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsQR-0004yz-VJ; Tue, 03 May 2022 13:18:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsQR-0003Tw-Tk; Tue, 03 May 2022 13:18:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsQR-0002M2-EY; Tue, 03 May 2022 13:18:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlsQR-0003Ay-E4; Tue, 03 May 2022 13:18:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pdjspZ9cPZBWil5O22PioEUxJn9v+LIyDdg5G9RZo0w=; b=hHaSQqz8DdpbRwomA9js+Zgbnr VAes9/MHfQpe7E/sGFP2gPXFbzq318GR0/92tT28+My+KMeuoOo/BkVrAEuW8ltM+HEV9H88I2Ix3 9ZEUcx+oRsqQTTJYV8YfIcezFtL14lq6e3hgJx2XxtLnopCcm1NwVJVsxWjRsCCMf170=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170045: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 13:18:47 +0000 flight 170045 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170045/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 780 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 13:22:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:22:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319642.539954 (Exim 4.92) (envelope-from ) id 1nlsTn-0007IW-W3; Tue, 03 May 2022 13:22:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319642.539954; Tue, 03 May 2022 13:22:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTn-0007IP-Ss; Tue, 03 May 2022 13:22:15 +0000 Received: by outflank-mailman (input) for mailman id 319642; Tue, 03 May 2022 13:22:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTl-0006lB-Px for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:22:13 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09964a51-cae4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 15:22:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0970D1F74B; Tue, 3 May 2022 13:22:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5EDF013ABE; Tue, 3 May 2022 13:22:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id x7ntFYEscWIASAAAMHmgww (envelope-from ); Tue, 03 May 2022 13:22:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09964a51-cae4-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651584130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OCiFhYZGfRbvpOrr1IR3lhjXORH3jBMETGpB22+cUf4=; b=NkSvVU0jzbByPjBn7ogNMnnyej2TuY2z7mt0eVPium+9eD6GxprqRlfTrBS52DctN/QLAB t6vFitDNeyXk8vdjBpDcdufkxY558EEEVPi+0w4syg5u6iECR8XV+UsVAWKMZVYwPgtEQD Wu33a9malb3HwtZ2ImjJ0txaVGbFhYY= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jbeulich@suse.com, Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Subject: [PATCH 0/2] x86/pat: fix querying available caching modes Date: Tue, 3 May 2022 15:22:05 +0200 Message-Id: <20220503132207.17234-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix some issues with querying caching modes being available for memory mappings. This is a replacement for the patch of Jan sent recently: https://lists.xen.org/archives/html/xen-devel/2022-04/msg02392.html Juergen Gross (2): x86/pat: fix x86_has_pat_wp() x86/pat: add functions to query specific cache mode availability arch/x86/include/asm/memtype.h | 2 ++ arch/x86/include/asm/pci.h | 2 +- arch/x86/mm/init.c | 24 ++++++++++++++++++++++-- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 ++++---- 4 files changed, 29 insertions(+), 7 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 03 13:22:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:22:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319641.539943 (Exim 4.92) (envelope-from ) id 1nlsTl-00070z-OL; Tue, 03 May 2022 13:22:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319641.539943; Tue, 03 May 2022 13:22:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTl-00070s-LH; Tue, 03 May 2022 13:22:13 +0000 Received: by outflank-mailman (input) for mailman id 319641; Tue, 03 May 2022 13:22:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTk-0006lA-BJ for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:22:12 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a0e3f69-cae4-11ec-a406-831a346695d4; Tue, 03 May 2022 15:22:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0C3B1F749; Tue, 3 May 2022 13:22:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6806513ABE; Tue, 3 May 2022 13:22:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iNYLGIIscWIASAAAMHmgww (envelope-from ); Tue, 03 May 2022 13:22:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a0e3f69-cae4-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651584131; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpkV8V5Y+6Vb55bRfQcavzTocu4t1BaNWLiM7KsOY1Y=; b=ubKL3UxTpmVXRWOdBpBxP1Blc7iCSFjpprMuVtEqjUkNxvt5KgAL1kIcTNjkGyUG/j5v7g eP8pHFW6Rm0suxVOYcYDsv/lL+qGJmUY9KnmCMOK0w391MnS/4uG7jTU1+tHyDmy49tmTD f4U0Tn/Uxnm7o0c9V2tpCWb8OLMoFfk= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jbeulich@suse.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Subject: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Date: Tue, 3 May 2022 15:22:07 +0200 Message-Id: <20220503132207.17234-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220503132207.17234-1-jgross@suse.com> References: <20220503132207.17234-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some drivers are using pat_enabled() in order to test availability of special caching modes (WC and UC-). This will lead to false negatives in case the system was booted e.g. with the "nopat" variant and the BIOS did setup the PAT MSR supporting the queried mode, or if the system is running as a Xen PV guest. Add test functions for those caching modes instead and use them at the appropriate places. For symmetry reasons export the already existing x86_has_pat_wp() for modules, too. Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") Signed-off-by: Juergen Gross --- arch/x86/include/asm/memtype.h | 2 ++ arch/x86/include/asm/pci.h | 2 +- arch/x86/mm/init.c | 25 +++++++++++++++++++++--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 ++++---- 4 files changed, 29 insertions(+), 8 deletions(-) diff --git a/arch/x86/include/asm/memtype.h b/arch/x86/include/asm/memtype.h index 9ca760e430b9..d00e0be854d4 100644 --- a/arch/x86/include/asm/memtype.h +++ b/arch/x86/include/asm/memtype.h @@ -25,6 +25,8 @@ extern void memtype_free_io(resource_size_t start, resource_size_t end); extern bool pat_pfn_immune_to_uc_mtrr(unsigned long pfn); bool x86_has_pat_wp(void); +bool x86_has_pat_wc(void); +bool x86_has_pat_uc_minus(void); enum page_cache_mode pgprot2cachemode(pgprot_t pgprot); #endif /* _ASM_X86_MEMTYPE_H */ diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h index f3fd5928bcbb..a5742268dec1 100644 --- a/arch/x86/include/asm/pci.h +++ b/arch/x86/include/asm/pci.h @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, int pin, int irq); #define HAVE_PCI_MMAP -#define arch_can_pci_mmap_wc() pat_enabled() +#define arch_can_pci_mmap_wc() x86_has_pat_wc() #define ARCH_GENERIC_PCI_MMAP_RESOURCE #ifdef CONFIG_PCI diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 71e182ebced3..b6431f714dc2 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -77,12 +77,31 @@ static uint8_t __pte2cachemode_tbl[8] = { [__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC, }; -/* Check that the write-protect PAT entry is set for write-protect */ +static bool x86_has_pat_mode(unsigned int mode) +{ + return __pte2cachemode_tbl[__cachemode2pte_tbl[mode]] == mode; +} + +/* Check that PAT supports write-protect */ bool x86_has_pat_wp(void) { - return __pte2cachemode_tbl[__cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]] == - _PAGE_CACHE_MODE_WP; + return x86_has_pat_mode(_PAGE_CACHE_MODE_WP); +} +EXPORT_SYMBOL_GPL(x86_has_pat_wp); + +/* Check that PAT supports WC */ +bool x86_has_pat_wc(void) +{ + return x86_has_pat_mode(_PAGE_CACHE_MODE_WC); +} +EXPORT_SYMBOL_GPL(x86_has_pat_wc); + +/* Check that PAT supports UC- */ +bool x86_has_pat_uc_minus(void) +{ + return x86_has_pat_mode(_PAGE_CACHE_MODE_UC_MINUS); } +EXPORT_SYMBOL_GPL(x86_has_pat_uc_minus); enum page_cache_mode pgprot2cachemode(pgprot_t pgprot) { diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c index 0c5c43852e24..f43ecf3f63eb 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, if (args->flags & ~(I915_MMAP_WC)) return -EINVAL; - if (args->flags & I915_MMAP_WC && !pat_enabled()) + if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) return -ENODEV; obj = i915_gem_object_lookup(file, args->handle); @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, if (HAS_LMEM(to_i915(dev))) mmap_type = I915_MMAP_TYPE_FIXED; - else if (pat_enabled()) + else if (x86_has_pat_wc()) mmap_type = I915_MMAP_TYPE_WC; else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) return -ENODEV; @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, break; case I915_MMAP_OFFSET_WC: - if (!pat_enabled()) + if (!x86_has_pat_wc()) return -ENODEV; type = I915_MMAP_TYPE_WC; break; @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, break; case I915_MMAP_OFFSET_UC: - if (!pat_enabled()) + if (!x86_has_pat_uc_minus()) return -ENODEV; type = I915_MMAP_TYPE_UC; break; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 03 13:22:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:22:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319640.539932 (Exim 4.92) (envelope-from ) id 1nlsTk-0006lO-Ix; Tue, 03 May 2022 13:22:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319640.539932; Tue, 03 May 2022 13:22:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTk-0006lH-DT; Tue, 03 May 2022 13:22:12 +0000 Received: by outflank-mailman (input) for mailman id 319640; Tue, 03 May 2022 13:22:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsTj-0006lA-IE for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:22:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09a1e0a8-cae4-11ec-a406-831a346695d4; Tue, 03 May 2022 15:22:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 60A7521871; Tue, 3 May 2022 13:22:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0838913AE0; Tue, 3 May 2022 13:22:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4IeDAIIscWIASAAAMHmgww (envelope-from ); Tue, 03 May 2022 13:22:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09a1e0a8-cae4-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651584130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CsELYWB9g735n4psOgGA9RLVHOTzorxnOT84eRzNkC4=; b=bTPrVtI98WQI22j4IYJLmfiH/e8o2FSFZ7FrB5SFsp33Oi13Cy18uQCxYfHrJpShK6M1t4 K9qPTJ0SxyLjKyMS0KuYdCJGf2bVdcqC2KyIgsR1uPLFEPrejQ1cJVWYyEMo+F3ATAxyEM DnCZsYFDCVgN2tCW6uOkWMgAo9KNMnI= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: jbeulich@suse.com, Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH 1/2] x86/pat: fix x86_has_pat_wp() Date: Tue, 3 May 2022 15:22:06 +0200 Message-Id: <20220503132207.17234-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220503132207.17234-1-jgross@suse.com> References: <20220503132207.17234-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x86_has_pat_wp() is using a wrong test, as it relies on the normal PAT configuration used by the kernel. In case the PAT MSR has been setup by another entity (e.g. BIOS or Xen hypervisor) it might return false even if the PAT configuration is allowing WP mappings. Fixes: 1f6f655e01ad ("x86/mm: Add a x86_has_pat_wp() helper") Signed-off-by: Juergen Gross --- arch/x86/mm/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index d8cfce221275..71e182ebced3 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -80,7 +80,8 @@ static uint8_t __pte2cachemode_tbl[8] = { /* Check that the write-protect PAT entry is set for write-protect */ bool x86_has_pat_wp(void) { - return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP; + return __pte2cachemode_tbl[__cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]] == + _PAGE_CACHE_MODE_WP; } enum page_cache_mode pgprot2cachemode(pgprot_t pgprot) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 03 13:23:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:23:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319655.539965 (Exim 4.92) (envelope-from ) id 1nlsVA-0008TD-Ce; Tue, 03 May 2022 13:23:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319655.539965; Tue, 03 May 2022 13:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsVA-0008T6-8L; Tue, 03 May 2022 13:23:40 +0000 Received: by outflank-mailman (input) for mailman id 319655; Tue, 03 May 2022 13:23:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsV9-0008Sw-Pu for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:23:39 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0614.outbound.protection.outlook.com [2a01:111:f400:fe08::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3dff56a5-cae4-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 15:23:38 +0200 (CEST) Received: from AM6PR08CA0023.eurprd08.prod.outlook.com (2603:10a6:20b:b2::35) by AM0PR08MB3234.eurprd08.prod.outlook.com (2603:10a6:208:5e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Tue, 3 May 2022 13:23:23 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::8b) by AM6PR08CA0023.outlook.office365.com (2603:10a6:20b:b2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Tue, 3 May 2022 13:23:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 13:23:22 +0000 Received: ("Tessian outbound 62985e3c34b6:v118"); Tue, 03 May 2022 13:23:22 +0000 Received: from fdbafd277eb7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C2A5B8F5-9E59-4995-A3A7-B0448700FBC2.1; Tue, 03 May 2022 13:23:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fdbafd277eb7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 13:23:15 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by AM0PR08MB3348.eurprd08.prod.outlook.com (2603:10a6:208:65::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 13:23:13 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 13:23:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dff56a5-cae4-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gzn1FncayiBuXhxcVuQN29gcEBQlizMHT51rAB5CAOcNWO0TuLHAJxEhRniwELK4/54S7a1h+wx9I+wkeafJeASemu/nOY1lRvF/eiP6W2wp5sddKVRLoVamnkopQkFwBtplefJbOk8Niiy3fFgUqQdYW1Ooj1jTa6hMC8uwBUz3HzTy3TxLsYkJFCh72aQbddurIt/ec0u54unCkhGI7GpP6j33ZLf2tYE0IGRqW+aSBALzpPLM/rtBXbID/CukCzWv6Pz65lIGRGqpXCiCFLwWp1TPAuCFEsQhRvb9Kvi8kArIm3iO0YlQqaXbiK/dfEoHQ3A8Y7rd4GansKGwUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9t+UUChBXOgJcqYKB+BpikrXXZ8Xac23COr5d9Phxc=; b=oT1R+4y8EFnGyi2xmXZ+8XTIN27giTMHumA4l/6AWI7oKK6F5qmVKeVAmjwHzCK0XD5+0CQny7wR4a3qmzAaUpWDqOygnlnSAmB1cBYQBYjGU0pHW8MbQNrAAIq3QRe2En1HjBqkTjYBh0vR8K4EonCGp2AIiDkn1zzGk3aIshZaDfVEJsqZDfkUxrZVtAkyFUXx0gv9+/RxiiCUY9m3cxQ1wn8pHuhkrY1YeMn43kwKVZE2Q9avA2/5CoTPXpzjhagKW6RvUGFmNQKURe0OOgt2yAxXpIAfG0PZMs0ntnDxgEBCGpgcXUQTQhS01PS1SBPSt7U4rSBtJNUyno5k/g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9t+UUChBXOgJcqYKB+BpikrXXZ8Xac23COr5d9Phxc=; b=1jd7yRNyyGJs23ojxUXEEU2UTf6+Bm0L9YflY6/Hb1HD8Ya7dZItmGqZNysYfa2RvBfSCwDOaoq1kMynB6a2EUa7k6hQFjN2zsnvYlk/fQ8a90DwqC9dR8+TKTtgkKSHL+onHfoHOzTclZbO9zAtu4AwVJ+kBP5oUucmQZHYbE0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 458ec5c0e1f27750 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfewyVNs2WWPeAiYK5FGjcIxX3l5NjPjKGXGskZv8XwMCeqEUI0C/NLdjh2gQrxtzxohYPQhr+6GJCv+VZvZtaH81LcsD542j8FgcU8cuk4dfmhgMnBQKi/cKdO0Yn72K24kW2R8YKCjLUfKvyUqhDly8RAZcxcnnX9KNcYS/vJFRFZVUgR4MuWTZm2UkizKg6NS/TXzFU2c397Q2lTCMbXZeIobwosvUbyobAK5+tFYsz/WVPwoJs/3oI0PTdU9ZLW+w6qGZrAeGwwOCcZWaeMCYOnmvyxmWGnYGh4RLHU4ABt3PfYgldmKQ4au5WvBjcHmu7kKTQHgA9tX1h0WUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9t+UUChBXOgJcqYKB+BpikrXXZ8Xac23COr5d9Phxc=; b=dkRgy3ZuxPtLh7BeKQXcymnYaKBr1lwJSWPrrcorLaPxjlBY9MKnvyIJp2nMqVzIr647hftVsQfs/oG7ZDjNb2SY76ZWfRS+3oOdv7J4ORmxuAjFgcbhslC1Wd/sejflX0FQNzsPy+wLD1ZCyLJIuXYWgne3dl1KvDJFxqKQ4OM8w6c0IAP10Tyn+Qixr7Mb0w3j+jGiur+NqZDyMa1g1x7ua9Fh8miES3APrjjSKGp+92eLj0AOWX5cst3DPO3i7n31W9BEjxRe7S95qtrVV+tScWOzrXY3R6CymXUDaVepdh7gcd7jMR4pRUCwhrMPP4vL4/h4d401dKmwbmuC6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9t+UUChBXOgJcqYKB+BpikrXXZ8Xac23COr5d9Phxc=; b=1jd7yRNyyGJs23ojxUXEEU2UTf6+Bm0L9YflY6/Hb1HD8Ya7dZItmGqZNysYfa2RvBfSCwDOaoq1kMynB6a2EUa7k6hQFjN2zsnvYlk/fQ8a90DwqC9dR8+TKTtgkKSHL+onHfoHOzTclZbO9zAtu4AwVJ+kBP5oUucmQZHYbE0= From: Luca Fancellu To: "Daniel P. Smith" CC: xen-devel , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Daniel De Graaf , Wei Liu , Anthony PERARD Subject: Re: [PATCH v6 2/2] flask: implement xsm_set_system_active Thread-Topic: [PATCH v6 2/2] flask: implement xsm_set_system_active Thread-Index: AQHYXt+hyRwwXvMDlUWMsukHHGStsK0NJCKA Date: Tue, 3 May 2022 13:23:13 +0000 Message-ID: <6CFE9B37-7B81-4EF6-8214-15582C4EB8EC@arm.com> References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-3-dpsmith@apertussolutions.com> In-Reply-To: <20220503111731.12642-3-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 45956a98-bbd9-470a-afad-08da2d08190c x-ms-traffictypediagnostic: AM0PR08MB3348:EE_|AM5EUR03FT056:EE_|AM0PR08MB3234:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jf9HWh+7h0D6WFPQQqX8LTmvnqRyf2yZ+dTXBeC4y9DzzgEAS/vnsm3XuUCtRyU0GOQUdWa29MRCPR+2ejY4ucUSahdW18vToI7YjvRBz2wuL5C09Pj93inm7clpTJD6xuNLSU9UcDVTF5QXnbC0SIkrrgoIqK1Azn3fdGmqPR+Mb990PxoBypri23JUGrGKNSmA15GC5ofBlTXG9jstBJecjibn3++A/8H0VWfeIdQdSIlfAUPSYbd0XA66Lo5wXrYNXR9JDnFY9udCPghMPPZ9iHLmomkb9RIV6zPaejcrAsb5ln3xQheYIkFvuFqHXSbltMPDZVe64jIOzeYn0R3r3RqsFco9tf1z0veMhkr8VPkwQizCZSQTZ4po+UEazi4889LEKyuApa56PL6YZcID6zoLyTeEEArBDIbQWg0wN5JZ3Dz4Afq0w3AR1hWrqIikO7o9mlqSn7wX/X/TUiGU3q3ubgHoqazxnwKnTT9U/xpD5ud5QEhtrYLRL55nUKzKOjkLgyIcJiGEFfrsl2+m2q7e8ogBbv/ZiEGx2vpVpimWAksFIDNBloCvWI9pBOGZ34YRKPtYd1PS6FNkrspJmTmAdi0NKDDepyqVJdE9tDqA7VEhuJOtWSCDYFMmWkSIfGhd0d+3WY5/R6Jnji23yFjVh8tHcQIi9yclXMpv0WYX6VTScZF1wf7dd//3AzM0mb5xaBPiH9pyWsJYZr3FEvLlfzeZFFKquUkPYJbFhUtBRrX/7eYkQ6dJFIZ6 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(38100700002)(53546011)(6506007)(26005)(122000001)(6512007)(316002)(86362001)(5660300002)(71200400001)(186003)(4744005)(36756003)(8936002)(4326008)(33656002)(8676002)(76116006)(6916009)(66556008)(64756008)(66946007)(2906002)(54906003)(508600001)(66476007)(66446008)(6486002)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1408B071AAF6504294A7EEE82D9D2342@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3348 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b10c4f8c-8807-4347-7fb1-08da2d0813a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G/rZoKYKIAQIFZVdGNkE8MZMBxkoapV/iL8qNXoFCRnPkK/xbcQiNBLHZrXElq567rqdMlTsM6d9e4RiuMgrAJwaGGCJMhaB8cVvyf5njaDwj01bCZmtNtVD95rxW4znsynRDyGoq3Isv/5Vobzi1DzV4o/oWSL5Ts6g4k3sDGdJOq5BkjTJaF50FNqfJhQbB5ZjwLSTSjlBIbp2DJXMOVYVws5TD8oCYafV/F7lmgEw22qpXAwpeAxnrWozDszWAtHBkzl/rqiJ/xoKqGiHZ/22KeiP0RqoqnBAvURlfkX15gbXD7HJc7ZXySn3K36Iz961XZiJeoeha+KqKmAKtF9uCiVmqJv6RsPuU7vghgEk7lznCHgzhmEVmME9/TMjGrygoncHZZxL8J0ibCmKU+/3xrfx37qc2o17onxB1Ej8o5PQEcfEkcP95NToWoMvmV0VvOF9NPWZSMGj5uCFVG9ViSOG4xviLOgnAScl2EPlIuQqAaaEfi8GmRdtrxhX8s0gn5VC5g0fIgxBZl1MVn+xTC43KjuIm4lPLGOwK4bGQzF4KPTWx27E4Zvtekv1STFyuPQjZL4s23LDlpjhIQPdylAaz65si3++yCKQ+m3X4Bl+YXyeIKsUf+qUxvmDuTjtDYk84t/avSn3jnLvCrQh6bnuiko2FEh9s5EUxICd4c1AuS7gLBTJOxl0HOSi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(54906003)(4326008)(6862004)(107886003)(8676002)(40460700003)(356005)(81166007)(82310400005)(70206006)(2616005)(316002)(70586007)(36756003)(5660300002)(26005)(186003)(6506007)(2906002)(336012)(53546011)(47076005)(8936002)(508600001)(6486002)(6512007)(33656002)(36860700001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 13:23:22.9127 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45956a98-bbd9-470a-afad-08da2d08190c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3234 DQoNCj4gT24gMyBNYXkgMjAyMiwgYXQgMTI6MTcsIERhbmllbCBQLiBTbWl0aCA8ZHBzbWl0aEBh cGVydHVzc29sdXRpb25zLmNvbT4gd3JvdGU6DQo+IA0KPiBUaGlzIGNvbW1pdCBpbXBsZW1lbnRz IGZ1bGwgc3VwcG9ydCBmb3Igc3RhcnRpbmcgdGhlIGlkbGUgZG9tYWluIHByaXZpbGVnZWQgYnkN Cj4gaW50cm9kdWNpbmcgYSBuZXcgZmxhc2sgbGFiZWwgeGVuYm9vdF90IHdoaWNoIHRoZSBpZGxl IGRvbWFpbiBpcyBsYWJlbGVkIHdpdGgNCj4gYXQgY3JlYXRpb24uICBJdCB0aGVuIHByb3ZpZGVz IHRoZSBpbXBsZW1lbnRhdGlvbiBmb3IgdGhlIFhTTSBob29rDQo+IHhzbV9zZXRfc3lzdGVtX2Fj dGl2ZSB0byByZWxhYmVsIHRoZSBpZGxlIGRvbWFpbiB0byB0aGUgZXhpc3RpbmcgeGVuX3QgZmxh c2sNCj4gbGFiZWwuDQo+IA0KPiBJbiB0aGUgcmVmZXJlbmNlIGZsYXNrIHBvbGljeSBhIG5ldyBt YWNybywgeGVuX2J1aWxkX2RvbWFpbih0YXJnZXQpLCBpcw0KPiBpbnRyb2R1Y2VkIGZvciBjcmVh dGluZyBwb2xpY2llcyBmb3IgZG9tMGxlc3MvaHlwZXJsYXVuY2ggYWxsb3dpbmcgdGhlDQo+IGh5 cGVydmlzb3IgdG8gY3JlYXRlIGFuZCBhc3NpZ24gdGhlIG5lY2Vzc2FyeSByZXNvdXJjZXMgZm9y IGRvbWFpbg0KPiBjb25zdHJ1Y3Rpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgUC4g U21pdGggPGRwc21pdGhAYXBlcnR1c3NvbHV0aW9ucy5jb20+DQo+IFJldmlld2VkLWJ5OiBKYXNv biBBbmRyeXVrIDxqYW5kcnl1a0BnbWFpbC5jb20+DQoNCkhpIERhbmllbCwNCg0KSeKAmXZlIGJ1 aWx0IGFuZCB0ZXN0ZWQgdGhlIHdob2xlIHNlcmllIG9uIGFybSwgY2hlY2tlZCBTSUxPIGFuZCBG TEFTSyB3aXRoIGJ1aWx0aW4gZmxhc2sgcG9saWN5IGFuZCBJ4oCZdmUNCnRlc3RlZCB0aGF0IERv bTAgaXMgYm9vdGluZyBmaW5lLg0KDQpTbyBmb3IgbWU6DQoNClJldmlld2VkLWJ5OiBMdWNhIEZh bmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQpUZXN0ZWQtYnk6IEx1Y2EgRmFuY2VsbHUg PGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KQ2hlZXJzLA0KTHVjYQ== From xen-devel-bounces@lists.xenproject.org Tue May 03 13:34:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:34:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319667.539981 (Exim 4.92) (envelope-from ) id 1nlsfJ-0001vl-I4; Tue, 03 May 2022 13:34:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319667.539981; Tue, 03 May 2022 13:34:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsfJ-0001vb-F8; Tue, 03 May 2022 13:34:09 +0000 Received: by outflank-mailman (input) for mailman id 319667; Tue, 03 May 2022 13:34:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsfH-0001vM-Vi; Tue, 03 May 2022 13:34:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsfH-0003kL-Pc; Tue, 03 May 2022 13:34:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsfH-0002gd-II; Tue, 03 May 2022 13:34:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlsfH-0007Uh-Hq; Tue, 03 May 2022 13:34:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=LSchPSE9eAzYoev4Es3fzVuP/QKpb4erfyh1Ersa4/M=; b=cwkmvHjAMP94HkMCAGmbQ8A5D8 8jd3S3c7kqJgfKYNvuh3ZvF39sFVujGHtyrKFl56RVNilqE0DfMHJK+37+MUpinF35w9E/1fGFj9X ewlRdbkRfDTkaMXZ/JqGJhd3A8XURpc/Fc1sg+CRix7qDM+Ha6NKa6kKFphe3jUym+bU=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-i386 Message-Id: From: osstest service owner Date: Tue, 03 May 2022 13:34:07 +0000 branch xen-unstable xenbranch xen-unstable job build-i386 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/170047/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386.xen-build --summary-out=tmp/170047.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-i386 xen-build Searching for failure / basis pass: 170045 fail [host=elbling1] / 168254 [host=albana0] 168249 [host=huxelrebe0] 168232 [host=huxelrebe0] 168185 [host=huxelrebe0] 168131 [host=albana0] 168127 [host=huxelrebe0] 168119 [host=albana0] 168115 [host=albana1] 168074 [host=huxelrebe0] 168048 [host=albana0] 168046 [host=huxelrebe0] 168043 [host=huxelrebe0] 168042 [host=chardonnay1] 168038 [host=huxelrebe0] 168017 [host=albana0] 167989 [host=huxelrebe1] 167980 [host=albana1] 167976 [host=huxelrebe0] 167956 [host=huxelrebe1] 167950 [host=a\ lbana0] 167946 [host=fiano0] 167940 [host=albana0] 167933 [host=albana0] 167929 [host=huxelrebe1] 167919 [host=fiano1] 167907 [host=albana0] 167803 [host=huxelrebe0] 167775 [host=albana0] 167760 [host=fiano0] 167754 [host=albana0] 167729 [host=albana1] 167727 [host=huxelrebe0] 167689 [host=fiano0] 167685 [host=chardonnay1] 167651 [host=albana0] 167636 [host=fiano0] 167627 [host=albana0] 167601 [host=albana1] 167598 [host=huxelrebe0] 167559 [host=huxelrebe0] 167555 [host=huxelrebe0] 167552 [host=\ albana0] 167535 [host=chardonnay1] 167527 [host=chardonnay1] 167522 [host=huxelrebe0] 167513 [host=albana1] 167487 [host=huxelrebe1] 167465 [host=albana1] 167463 [host=huxelrebe0] 167450 [host=fiano1] 167445 [host=chardonnay0] 167436 [host=fiano1] 167419 [host=pinot1] 167414 [host=albana1] 167409 [host=albana0] 167394 [host=albana1] 167393 [host=albana1] 167392 [host=albana1] 167391 [host=albana1] 167379 [host=huxelrebe0] 167377 [host=huxelrebe1] 167239 [host=huxelrebe0] 167237 [host=albana0] 16\ 7231 [host=albana0] 167225 [host=albana0] 167122 [host=huxelrebe0] 167104 [host=huxelrebe0] 167081 [host=albana0] 166961 [host=albana0] 166951 [host=pinot0] 166949 [host=pinot0] 166826 [host=albana0] 166360 [host=fiano0] 166133 [host=albana1] 166130 [host=huxelrebe0] 166126 [host=huxelrebe1] 166123 [host=albana0] 166120 [host=huxelrebe1] 166114 [host=huxelrebe1] 166108 [host=huxelrebe0] 166105 [host=albana0] 166102 [host=huxelrebe0] 166097 [host=huxelrebe1] 166093 [host=huxelrebe1] 166090 [host=\ huxelrebe1] 166087 [host=fiano0] 166083 [host=albana0] 166081 [host=huxelrebe0] 166063 [host=albana0] 166042 [host=huxelrebe0] 166035 [host=albana0] 165969 [host=fiano0] 165962 [host=fiano0] 165950 [host=fiano0] 165948 [host=fiano1] 165934 [host=fiano1] 165921 [host=albana0] 165899 [host=huxelrebe0] 165873 [host=chardonnay0] 165862 [host=albana0] 165827 [host=fiano0] 165808 [host=albana0] 165767 [host=fiano0] 165714 [host=fiano0] 165701 [host=fiano0] 165690 [host=huxelrebe0] 165688 [host=huxelre\ be0] 165685 [host=albana1] 165671 [host=albana0] 165657 [host=albana0] 165652 [host=albana0] 165637 [host=fiano1] 165531 [host=albana1] 165523 [host=albana0] 165508 [host=fiano1] 165505 [host=huxelrebe0] 165502 [host=fiano1] 165494 [host=albana0] 165487 [host=albana1] 165474 [host=huxelrebe0] 165462 [host=chardonnay0] 165433 [host=huxelrebe0] 165425 [host=albana0] 165398 [host=albana1] 165382 [host=huxelrebe0] 165377 [host=albana0] 165347 [host=chardonnay0] 165321 [host=elbling0] 165200 [host=ch\ ardonnay0] 165175 [host=albana1] 165170 [host=albana1] 165155 [host=huxelrebe0] 165151 [host=albana0] 165113 [host=fiano1] 165108 [host=albana0] 165013 [host=pinot1] 165007 [host=fiano1] 165001 [host=albana1] 164971 [host=huxelrebe0] 164946 [host=albana1] 164937 [host=fiano1] 164913 [host=fiano0] 164869 [host=huxelrebe0] 164862 [host=huxelrebe1] 164674 [host=albana0] 164630 [host=huxelrebe0] 164556 [host=albana1] 164513 [host=albana1] 164461 [host=fiano0] 164406 [host=albana0] 164229 [host=huxel\ rebe0] 164173 [host=albana0] 164166 [host=albana1] 164160 [host=huxelrebe1] 164159 [host=huxelrebe1] 164155 [host=fiano1] 164151 [host=huxelrebe1] 164142 [host=albana1] 164139 [host=albana1] 164114 [host=albana0] 164111 [host=huxelrebe0] 164110 [host=albana1] 164093 [host=huxelrebe1] 164090 [host=albana1] 164081 [host=albana0] 164078 [host=fiano1] 164047 [host=huxelrebe0] 164039 [host=huxelrebe1] 164028 [host=albana1] 164025 [host=huxelrebe0] 164020 [host=fiano1] 164015 [host=huxelrebe0] 164010 \ [host=albana1] 164005 [host=fiano1] 164002 [host=albana0] 163999 [host=huxelrebe1] 163995 [host=albana1] 163992 [host=albana0] 163990 [host=albana1] 163988 [host=albana1] 163986 [host=albana0] 163984 [host=albana1] 163980 [host=huxelrebe1] 163978 [host=huxelrebe1] 163975 [host=albana1] 163972 [host=albana0] 163956 [host=huxelrebe1] 163945 [host=albana1] 163929 [host=fiano0] 163917 [host=huxelrebe0] 163907 [host=fiano1] 163889 [host=fiano1] 163882 [host=albana0] 163875 [host=albana1] 163864 [host\ =huxelrebe0] 163851 [host=huxelrebe0] 163835 [host=albana0] 163819 [host=albana0] 163806 [host=huxelrebe1] 163794 [host=albana0] 163786 [host=huxelrebe0] 163770 [host=albana1] 163756 [host=huxelrebe0] 163729 [host=fiano1] 163712 [host=albana0] 163691 [host=albana1] 163676 [host=huxelrebe1] 163668 [host=albana1] 163658 [host=albana0] 163646 [host=albana1] 163638 [host=chardonnay0] 163624 [host=albana1] 163612 [host=albana1] 163598 [host=albana1] 163585 [host=albana1] 163570 [host=albana0] 163557 \ [host=huxelrebe1] 163547 [host=albana1] 163533 [host=albana1] 163515 [host=albana0] 163505 [host=albana0] 163484 [host=chardonnay0] 163475 [host=albana1] 163460 [host=huxelrebe1] 163441 [host=huxelrebe1] 163426 [host=albana1] 163404 [host=albana1] 163387 [host=elbling0] 163367 [host=albana0] 163340 [host=fiano1] 163324 [host=albana0] 163320 [host=albana0] 163312 [host=huxelrebe0] 163307 [host=albana1] 163304 [host=albana0] 163302 [host=huxelrebe0] 163300 [host=albana0] 163298 [host=fiano0] 16329\ 4 [host=huxelrebe0] 163291 [host=huxelrebe0] 163289 [host=huxelrebe0] 163259 [host=albana0] 163238 [host=huxelrebe1] 163233 [host=albana0] 163229 [host=huxelrebe0] 163227 [host=chardonnay0] 163224 [host=chardonnay0] 163221 [host=huxelrebe1] 163217 [host=albana1] 163216 [host=albana1] 163214 [host=chardonnay0] 163210 [host=albana1] 163205 [host=fiano0] 163197 [host=huxelrebe1] 163192 [host=albana0] 163189 [host=albana0] 163185 [host=albana0] 163180 [host=albana0] 163175 [host=fiano1] 163172 [host\ =albana1] 163167 [host=albana1] 163162 [host=albana1] 163159 [host=fiano1] 163157 [host=albana1] 163154 [host=huxelrebe0] 163143 [host=chardonnay0] 163132 [host=chardonnay0] 163124 [host=albana1] 163116 [host=huxelrebe0] 163107 [host=huxelrebe0] 163096 [host=albana1] 163055 [host=huxelrebe0] 163028 [host=huxelrebe1] 163022 [host=albana0] 163018 [host=albana0] 163013 [host=albana0] 163009 [host=huxelrebe0] 162999 [host=albana1] 162995 [host=albana1] 162994 [host=albana1] 162987 [host=huxelrebe1] \ 162972 [host=huxelrebe0] 162892 [host=albana1] 162884 [host=albana1] 162878 [host=albana0] 162875 [host=huxelrebe1] 162869 [host=fiano1] 162865 [host=albana1] 162855 [host=huxelrebe0] 162851 [host=huxelrebe0] 162846 [host=huxelrebe0] 162841 [host=huxelrebe0] 162837 [host=albana0] 162833 [host=huxelrebe0] 162821 [host=albana1] 162808 [host=huxelrebe0] 162799 [host=huxelrebe1] 162792 [host=huxelrebe0] 162781 [host=albana0] 162774 [host=albana1] 162769 [host=huxelrebe0] 162758 [host=huxelrebe0] 162\ 722 [host=huxelrebe0] 162702 [host=huxelrebe0] 162683 [host=fiano1] 162659 [host=huxelrebe0] 162637 [host=albana1] 162609 [host=fiano1] 162583 [host=huxelrebe1] 162552 [host=chardonnay0] 162542 [host=huxelrebe1] 162436 [host=chardonnay0] 162371 ok. Failure / basis pass flights: 170045 / 162371 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Basis pass 51adb689e1db695cffdeeacafad218768fbc018c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 7292e4a0a8f58333ccbd2d0d47242f9865083c9c 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#51adb689e1db695cffdeeacafad218768fbc018c-101f4c789221716585b972f2c2a22a85c078ef1d git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#7ea428895af2840d85c524f0bd11a38aac308308-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#7292e4a0a8f58333ccbd2d0d47242f9865083c\ 9c-dc88f9b72df52b22c35b127b80c487e0b6fca4af git://xenbits.xen.org/xen.git#5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1-702c9a800eb3ecd4b8595998d37a769d470c5bb0 adhoc-revtuple-generator: tree discontiguous: qemu-xen Loaded 8800 nodes in revision graph Searching for test results: 162769 [host=huxelrebe0] 162774 [host=albana1] 162781 [host=albana0] 162792 [host=huxelrebe0] 162799 [host=huxelrebe1] 167344 [host=huxelrebe0] 167345 [host=huxelrebe0] 167346 [host=huxelrebe0] 167347 [host=huxelrebe0] 167349 [host=huxelrebe1] 167350 [host=huxelrebe0] 167352 [host=huxelrebe1] 167353 [host=huxelrebe0] 167354 [host=huxelrebe1] 167355 [host=huxelrebe1] 167356 [host=huxelrebe1] 167358 [host=huxelrebe1] 167360 [host=huxelrebe0] 167363 [host=huxelrebe0] 167364 [host=huxelrebe0] 167365 [host=huxelrebe0] 167366 [host=huxelrebe0] 167367 [host=huxelrebe0] 167368 [host=huxelrebe0] 167369 [host=huxelrebe0] 167370 [host=huxelrebe1] 167371 [host=huxelrebe1] 167373 [host=huxelrebe1] 167374 [host=huxelrebe1] 167375 [host=huxelrebe1] 167376 [host=huxelrebe1] 167377 [host=huxelrebe1] 167379 [host=huxelrebe0] 162808 [host=huxelrebe0] 162821 [host=albana1] 162833 [host=huxelrebe0] 162837 [host=albana0] 162841 [host=huxelrebe0] 162846 [host=huxelrebe0] 165347 [host=chardonnay0] 162851 [host=huxelrebe0] 162855 [host=huxelrebe0] 162865 [host=albana1] 162869 [host=fiano1] 162875 [host=huxelrebe1] 162878 [host=albana0] 162884 [host=albana1] 162892 [host=albana1] 165321 [host=elbling0] 165377 [host=albana0] 165382 [host=huxelrebe0] 165398 [host=albana1] 162972 [host=huxelrebe0] 165425 [host=albana0] 165433 [host=huxelrebe0] 162994 [host=albana1] 162987 [host=huxelrebe1] 162995 [host=albana1] 162999 [host=albana1] 163009 [host=huxelrebe0] 163013 [host=albana0] 163018 [host=albana0] 163022 [host=albana0] 163028 [host=huxelrebe1] 163055 [host=huxelrebe0] 165462 [host=chardonnay0] 165474 [host=huxelrebe0] 163096 [host=albana1] 163107 [host=huxelrebe0] 167225 [host=albana0] 167231 [host=albana0] 167237 [host=albana0] 167239 [host=huxelrebe0] 167240 [host=huxelrebe0] 167242 [host=huxelrebe1] 163116 [host=huxelrebe0] 163124 [host=albana1] 163132 [host=chardonnay0] 163143 [host=chardonnay0] 165487 [host=albana1] 165494 [host=albana0] 165502 [host=fiano1] 165505 [host=huxelrebe0] 165508 [host=fiano1] 163154 [host=huxelrebe0] 163157 [host=albana1] 163159 [host=fiano1] 163162 [host=albana1] 163167 [host=albana1] 163172 [host=albana1] 163175 [host=fiano1] 163180 [host=albana0] 163185 [host=albana0] 163189 [host=albana0] 163192 [host=albana0] 163197 [host=huxelrebe1] 163205 [host=fiano0] 163210 [host=albana1] 163214 [host=chardonnay0] 163216 [host=albana1] 163217 [host=albana1] 163224 [host=chardonnay0] 163227 [host=chardonnay0] 163229 [host=huxelrebe0] 163221 [host=huxelrebe1] 165523 [host=albana0] 165531 [host=albana1] 163233 [host=albana0] 163238 [host=huxelrebe1] 163259 [host=albana0] 163289 [host=huxelrebe0] 163291 [host=huxelrebe0] 163294 [host=huxelrebe0] 163298 [host=fiano0] 163300 [host=albana0] 163302 [host=huxelrebe0] 163304 [host=albana0] 163307 [host=albana1] 163312 [host=huxelrebe0] 163320 [host=albana0] 163324 [host=albana0] 163340 [host=fiano1] 163367 [host=albana0] 163387 [host=elbling0] 163404 [host=albana1] 163426 [host=albana1] 163441 [host=huxelrebe1] 163460 [host=huxelrebe1] 163475 [host=albana1] 163484 [host=chardonnay0] 165637 [host=fiano1] 165652 [host=albana0] 165657 [host=albana0] 165671 [host=albana0] 163505 [host=albana0] 163515 [host=albana0] 163533 [host=albana1] 163547 [host=albana1] 163557 [host=huxelrebe1] 165685 [host=albana1] 165688 [host=huxelrebe0] 165690 [host=huxelrebe0] 165701 [host=fiano0] 165714 [host=fiano0] 163570 [host=albana0] 163585 [host=albana1] 163598 [host=albana1] 163612 [host=albana1] 163624 [host=albana1] 163638 [host=chardonnay0] 163646 [host=albana1] 163658 [host=albana0] 163668 [host=albana1] 163676 [host=huxelrebe1] 167247 [host=huxelrebe1] 167253 [host=huxelrebe0] 167258 [host=huxelrebe0] 167260 [host=huxelrebe0] 167262 [host=huxelrebe0] 163691 [host=albana1] 163712 [host=albana0] 165767 [host=fiano0] 163729 [host=fiano1] 163756 [host=huxelrebe0] 163770 [host=albana1] 163786 [host=huxelrebe0] 163794 [host=albana0] 165808 [host=albana0] 163806 [host=huxelrebe1] 163819 [host=albana0] 163835 [host=albana0] 163851 [host=huxelrebe0] 163864 [host=huxelrebe0] 163875 [host=albana1] 163882 [host=albana0] 165827 [host=fiano0] 163889 [host=fiano1] 163907 [host=fiano1] 163917 [host=huxelrebe0] 167391 [host=albana1] 167392 [host=albana1] 167393 [host=albana1] 167394 [host=albana1] 167409 [host=albana0] 167414 [host=albana1] 167419 [host=pinot1] 163929 [host=fiano0] 163945 [host=albana1] 163956 [host=huxelrebe1] 165862 [host=albana0] 165873 [host=chardonnay0] 165899 [host=huxelrebe0] 163972 [host=albana0] 163975 [host=albana1] 163978 [host=huxelrebe1] 163980 [host=huxelrebe1] 163984 [host=albana1] 163986 [host=albana0] 163988 [host=albana1] 163990 [host=albana1] 163992 [host=albana0] 163995 [host=albana1] 163999 [host=huxelrebe1] 164002 [host=albana0] 164005 [host=fiano1] 164010 [host=albana1] 164015 [host=huxelrebe0] 164020 [host=fiano1] 164025 [host=huxelrebe0] 164028 [host=albana1] 164039 [host=huxelrebe1] 165921 [host=albana0] 165934 [host=fiano1] 165948 [host=fiano1] 165950 [host=fiano0] 164047 [host=huxelrebe0] 164078 [host=fiano1] 164081 [host=albana0] 167081 [host=albana0] 167103 [host=albana0] 167104 [host=huxelrebe0] 164090 [host=albana1] 164093 [host=huxelrebe1] 164110 [host=albana1] 164111 [host=huxelrebe0] 164114 [host=albana0] 165962 [host=fiano0] 165969 [host=fiano0] 164139 [host=albana1] 164142 [host=albana1] 164151 [host=huxelrebe1] 164155 [host=fiano1] 164159 [host=huxelrebe1] 164160 [host=huxelrebe1] 164166 [host=albana1] 164173 [host=albana0] 164229 [host=huxelrebe0] 167267 [host=huxelrebe0] 167271 [host=huxelrebe0] 167274 [host=huxelrebe0] 167276 [host=huxelrebe0] 167275 [host=huxelrebe1] 167277 [host=huxelrebe0] 167278 [host=huxelrebe1] 167280 [host=huxelrebe1] 167279 [host=huxelrebe1] 167281 [host=huxelrebe1] 167282 [host=huxelrebe1] 167283 [host=huxelrebe0] 167284 [host=huxelrebe1] 167285 [host=huxelrebe1] 167286 [host=huxelrebe1] 167289 [host=huxelrebe1] 167291 [host=huxelrebe1] 167288 [host=huxelrebe1] 167292 [host=huxelrebe1] 167293 [host=huxelrebe1] 167294 [host=huxelrebe1] 167295 [host=huxelrebe1] 167296 [host=huxelrebe1] 167297 [host=huxelrebe1] 167298 [host=huxelrebe1] 167300 [host=huxelrebe1] 167303 [host=huxelrebe1] 167306 [host=huxelrebe1] 167309 [host=huxelrebe0] 166035 [host=albana0] 166042 [host=huxelrebe0] 166063 [host=albana0] 166081 [host=huxelrebe0] 166083 [host=albana0] 166087 [host=fiano0] 166090 [host=huxelrebe1] 166093 [host=huxelrebe1] 166097 [host=huxelrebe1] 166102 [host=huxelrebe0] 166105 [host=albana0] 166108 [host=huxelrebe0] 167122 [host=huxelrebe0] 164406 [host=albana0] 166114 [host=huxelrebe1] 166120 [host=huxelrebe1] 166123 [host=albana0] 166126 [host=huxelrebe1] 166130 [host=huxelrebe0] 166133 [host=albana1] 164461 [host=fiano0] 166826 [host=albana0] 164513 [host=albana1] 167465 [host=albana1] 167487 [host=huxelrebe1] 164556 [host=albana1] 164630 [host=huxelrebe0] 164674 [host=albana0] 164686 [host=huxelrebe1] 164695 [host=huxelrebe1] 164704 [host=fiano1] 164718 [host=huxelrebe1] 164728 [host=huxelrebe1] 164733 [host=huxelrebe1] 164737 [host=huxelrebe1] 164740 [host=huxelrebe0] 164743 [host=huxelrebe1] 164746 [host=huxelrebe1] 164754 [host=huxelrebe1] 164755 [host=huxelrebe1] 164751 [host=huxelrebe1] 164756 [host=huxelrebe1] 164759 [host=huxelrebe1] 164761 [host=huxelrebe1] 164762 [host=huxelrebe1] 164758 [host=huxelrebe0] 164763 [host=huxelrebe1] 164765 [host=huxelrebe0] 164766 [host=huxelrebe0] 164767 [host=huxelrebe0] 164768 [host=huxelrebe0] 164769 [host=huxelrebe0] 164770 [host=huxelrebe0] 164764 [host=huxelrebe0] 164771 [host=huxelrebe0] 164773 [host=huxelrebe1] 164774 [host=huxelrebe1] 164775 [host=huxelrebe1] 164776 [host=huxelrebe1] 164780 [host=huxelrebe1] 164781 [host=huxelrebe1] 164778 [host=huxelrebe1] 164782 [host=huxelrebe1] 164784 [host=huxelrebe1] 164783 [host=huxelrebe1] 164785 [host=huxelrebe1] 164787 [host=huxelrebe1] 164788 [host=huxelrebe1] 164790 [host=huxelrebe1] 164794 [host=huxelrebe1] 164795 [host=huxelrebe1] 164800 [host=fiano1] 164802 [host=huxelrebe1] 164804 [host=fiano1] 164806 [host=huxelrebe1] 164807 [host=huxelrebe0] 164809 [host=huxelrebe0] 164810 [host=huxelrebe1] 164811 [host=huxelrebe1] 164813 [host=huxelrebe1] 164814 [host=fiano1] 164815 [host=fiano1] 164817 [host=huxelrebe1] 164818 [host=huxelrebe0] 164820 [host=huxelrebe1] 164821 [host=huxelrebe1] 164823 [host=huxelrebe0] 164825 [host=huxelrebe0] 164826 [host=huxelrebe0] 164828 [host=huxelrebe0] 164829 [host=huxelrebe1] 164830 [host=huxelrebe1] 164831 [host=huxelrebe1] 164832 [host=huxelrebe1] 164833 [host=huxelrebe1] 167314 [host=huxelrebe0] 167319 [host=huxelrebe1] 167324 [host=huxelrebe1] 167330 [host=huxelrebe1] 167334 [host=huxelrebe1] 167335 [host=huxelrebe1] 167338 [host=huxelrebe1] 167339 [host=huxelrebe1] 167340 [host=huxelrebe0] 167341 [host=huxelrebe0] 167342 [host=huxelrebe0] 164835 [host=huxelrebe1] 164837 [host=huxelrebe1] 164838 [host=huxelrebe1] 164839 [host=huxelrebe1] 164840 [host=huxelrebe1] 164841 [host=huxelrebe1] 164842 [host=huxelrebe1] 164843 [host=huxelrebe1] 164844 [host=huxelrebe1] 164845 [host=huxelrebe1] 164846 [host=huxelrebe1] 164847 [host=huxelrebe1] 164849 [host=huxelrebe0] 164851 [host=huxelrebe1] 164853 [host=huxelrebe0] 164854 [host=huxelrebe1] 164856 [host=huxelrebe1] 164857 [host=huxelrebe0] 164858 [host=huxelrebe0] 164859 [host=huxelrebe0] 164861 [host=huxelrebe0] 164862 [host=huxelrebe1] 164869 [host=huxelrebe0] 166360 [host=fiano0] 164913 [host=fiano0] 164937 [host=fiano1] 164946 [host=albana1] 164971 [host=huxelrebe0] 165001 [host=albana1] 165007 [host=fiano1] 165013 [host=pinot1] 165108 [host=albana0] 167436 [host=fiano1] 167445 [host=chardonnay0] 167450 [host=fiano1] 167463 [host=huxelrebe0] 165113 [host=fiano1] 165151 [host=albana0] 165155 [host=huxelrebe0] 165170 [host=albana1] 165175 [host=albana1] 162371 pass 51adb689e1db695cffdeeacafad218768fbc018c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 7292e4a0a8f58333ccbd2d0d47242f9865083c9c 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 166949 [host=pinot0] 166951 [host=pinot0] 166961 [host=albana0] 162436 [host=chardonnay0] 165200 [host=chardonnay0] 162542 [host=huxelrebe1] 162553 [host=huxelrebe1] 162555 [host=chardonnay0] 162558 [host=huxelrebe1] 162559 [host=huxelrebe1] 162560 [host=huxelrebe1] 162562 [host=chardonnay0] 162564 [host=huxelrebe1] 162565 [host=huxelrebe1] 162552 [host=chardonnay0] 162583 [host=huxelrebe1] 162609 [host=fiano1] 162637 [host=albana1] 162659 [host=huxelrebe0] 162758 [host=huxelrebe0] 162683 [host=fiano1] 162702 [host=huxelrebe0] 162722 [host=huxelrebe0] 167513 [host=albana1] 167522 [host=huxelrebe0] 167527 [host=chardonnay1] 167535 [host=chardonnay1] 167552 [host=albana0] 167555 [host=huxelrebe0] 167559 [host=huxelrebe0] 167598 [host=huxelrebe0] 167601 [host=albana1] 167627 [host=albana0] 167636 [host=fiano0] 167651 [host=albana0] 167685 [host=chardonnay1] 167689 [host=fiano0] 167727 [host=huxelrebe0] 167729 [host=albana1] 167754 [host=albana0] 167760 [host=fiano0] 167775 [host=albana0] 167803 [host=huxelrebe0] 167907 [host=albana0] 167919 [host=fiano1] 167929 [host=huxelrebe1] 167933 [host=albana0] 167940 [host=albana0] 167946 [host=fiano0] 167950 [host=albana0] 167956 [host=huxelrebe1] 167976 [host=huxelrebe0] 167980 [host=albana1] 167989 [host=huxelrebe1] 168017 [host=albana0] 168046 [host=huxelrebe0] 168038 [host=huxelrebe0] 168042 [host=chardonnay1] 168043 [host=huxelrebe0] 168048 [host=albana0] 168074 [host=huxelrebe0] 168115 [host=albana1] 168119 [host=albana0] 168127 [host=huxelrebe0] 168131 [host=albana0] 168185 [host=huxelrebe0] 168232 [host=huxelrebe0] 168249 [host=huxelrebe0] 168254 [host=albana0] 168258 fail 6a890db161cd6d378bec3499a1e774db3f5a27a7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168262 [host=elbling0] 168267 [host=elbling0] 168271 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168285 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168288 pass 51adb689e1db695cffdeeacafad218768fbc018c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 7292e4a0a8f58333ccbd2d0d47242f9865083c9c 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 168291 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168290 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168292 pass 5801910013757bd626f67ed77eea6c16a176eebf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9 d05c67efd94f301b48bc486246161b05acaa8df2 168293 pass 46b4606ba23498d3d0e66b53e498eb3d5d592586 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 64f37cc530f144e53c190c9e8209a51b58fd5c43 1c3ed9c908732d19660fbe83580674d585464d4c 168297 pass b258f12889c09555e99c9cebf56dba45190c5dc2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 64f37cc530f144e53c190c9e8209a51b58fd5c43 46c4061cd2bf69e8039021af615c2bdb94e50088 168295 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168298 pass ee1f8262b83dd88b30091e6e81221ff299796099 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 72f917ea3732b115eb411230754534812901dde5 8e3edefb880caeeaaf80123d5599139e8c2c9ecf 168299 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168301 pass 33189f05278345eab608ff56e87905bdeacdbd47 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc776a2d9ca9e1b857e880ff682668871369b4c3 75cc460a1b8cfd8e5d2c4302234ee194defe4872 168302 pass b24306f15daa2ff8510b06702114724b33895d3c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd a096eaf12a0d558240c937fe44176aaa98b750a7 168303 [host=elbling0] 168304 pass b24306f15daa2ff8510b06702114724b33895d3c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 12e3410e071e284398e49d125e7d9cec076d00e5 168307 [host=elbling0] 168308 [host=elbling0] 168309 [host=elbling0] 168312 fail 497ac7b6d7f9750f48f137db244931a5728b1968 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd e0a514d2f4b2fcb51835aa9a9b02653b491a61fc 168311 [host=elbling0] 168314 [host=elbling0] 168317 [host=elbling0] 168316 [host=elbling0] 168318 [host=elbling0] 168319 [host=elbling0] 168323 [host=elbling0] 168320 [host=elbling0] 168324 [host=elbling0] 168330 [host=elbling0] 168329 fail irrelevant 168332 [host=elbling0] 168335 pass b24306f15daa2ff8510b06702114724b33895d3c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 44f231cd88a7433cb2cba9992708559afef4c0e1 168336 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 7d9589239ec068c944190408b9838774d5ec1f8f 168333 [host=elbling0] 168337 pass f1d1c337e7c0575da7fd248b2dd9cffc755940df 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 168339 [host=elbling0] 168340 [host=elbling0] 168341 [host=elbling0] 168342 [host=elbling0] 168347 [host=elbling0] 168348 [host=elbling0] 168344 [host=elbling0] 168350 [host=elbling0] 168352 [host=elbling0] 168356 [host=elbling0] 168359 [host=elbling0] 168364 [host=elbling0] 168366 [host=elbling0] 168372 [host=elbling0] 168377 [host=elbling0] 168381 [host=elbling0] 168385 [host=elbling0] 168387 [host=elbling0] 168389 [host=elbling0] 168392 [host=elbling0] 168395 fail irrelevant 168397 [host=elbling0] 168401 [host=elbling0] 168402 fail irrelevant 168404 fail irrelevant 168405 fail irrelevant 168407 fail irrelevant 168408 fail irrelevant 168411 fail irrelevant 168415 fail irrelevant 168416 fail irrelevant 168418 [host=elbling0] 168419 [host=elbling0] 168421 [host=elbling0] 168422 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168424 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168425 [host=elbling0] 168426 [host=elbling0] 168427 [host=elbling0] 168430 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168431 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168433 [host=elbling0] 168436 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168438 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168439 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168440 [host=elbling0] 168441 [host=elbling0] 168443 [host=elbling0] 168444 fail 4adc364c75b556eb0b741332f08c0aceb5e2cb0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168445 [host=elbling0] 168446 [host=elbling0] 168447 [host=elbling0] 168449 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168451 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168453 [host=elbling0] 168455 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168456 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168457 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168458 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168459 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168461 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168462 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168464 fail 79f2734e5a7bc2e5256eb0e599f45407855159c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1145d94c738ea13e0d2ceedb97a4cfe46292b08e 168468 fail irrelevant 168469 fail irrelevant 168472 [host=elbling0] 168475 [host=elbling0] 168477 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168478 fail 62fa37fe7b9df3c54a2d9d90aed9ff0e817ee0c6 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 9d4a44380d273de22d5753883cbf5581795ff24d 168479 [host=elbling0] 168489 [host=elbling0] 168490 [host=pinot1] 168496 [host=elbling0] 168504 fail irrelevant 168508 [host=pinot1] 168512 [host=pinot1] 168519 [host=pinot0] 168521 [host=elbling0] 168524 [host=elbling0] 168525 [host=elbling0] 168526 [host=pinot1] 168530 [host=pinot1] 168532 [host=pinot0] 168533 [host=pinot1] 168534 fail irrelevant 168535 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168536 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168538 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168539 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168541 [host=pinot0] 168542 [host=pinot1] 168543 [host=pinot1] 168544 [host=pinot1] 168546 [host=pinot0] 168548 [host=pinot1] 168550 [host=elbling0] 168551 [host=elbling0] 168552 [host=elbling0] 168553 [host=elbling0] 168554 [host=elbling0] 168555 [host=pinot1] 168556 [host=pinot1] 168557 [host=pinot1] 168558 [host=pinot1] 168559 [host=pinot1] 168560 [host=pinot0] 168561 [host=pinot0] 168562 [host=pinot0] 168564 [host=pinot1] 168565 [host=pinot1] 168566 [host=pinot0] 168567 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168568 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168569 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168570 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168572 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168574 [host=pinot1] 168576 [host=pinot1] 168578 [host=pinot0] 168579 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168581 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168583 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168584 [host=pinot1] 168587 [host=pinot1] 168588 [host=pinot0] 168602 [host=pinot0] 168606 [host=pinot1] 168609 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168610 [host=pinot1] 168614 [host=pinot1] 168616 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db dedb0aa42c6d1ee31805dfc61630db2c41117330 168617 [host=pinot0] 168618 fail irrelevant 168622 fail irrelevant 168623 [host=pinot1] 168625 fail irrelevant 168627 fail irrelevant 168634 [host=elbling0] 168629 [host=pinot1] 168635 fail 33438f7354af9c04cb296fb15a7a79c2c3944c0a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168637 [host=pinot1] 168639 [host=elbling0] 168640 [host=pinot1] 168645 [host=pinot1] 168648 [host=pinot0] 168651 [host=pinot0] 168653 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168661 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168663 fail irrelevant 168664 [host=elbling0] 168668 [host=pinot0] 168670 [host=elbling0] 168672 [host=elbling0] 168673 [host=elbling0] 168675 [host=elbling0] 168678 [host=elbling0] 168679 [host=pinot1] 168680 [host=pinot1] 168682 [host=pinot1] 168683 [host=elbling0] 168685 [host=elbling0] 168686 [host=elbling0] 168687 [host=elbling0] 168688 [host=elbling0] 168689 [host=pinot0] 168690 [host=pinot0] 168692 [host=pinot0] 168693 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168694 [host=pinot0] 168695 [host=pinot1] 168697 [host=pinot1] 168698 [host=elbling0] 168702 [host=pinot0] 168703 [host=pinot0] 168707 [host=pinot0] 168708 [host=pinot0] 168710 [host=pinot0] 168728 [host=elbling0] 168713 [host=elbling0] 168717 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168721 [host=elbling0] 168723 [host=elbling0] 168725 [host=elbling0] 168727 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168729 [host=elbling0] 168730 [host=elbling0] 168731 [host=elbling0] 168732 [host=elbling0] 168734 [host=pinot0] 168735 [host=pinot0] 168736 [host=pinot0] 168738 [host=elbling0] 168739 [host=pinot1] 168741 [host=elbling0] 168745 [host=elbling0] 168746 [host=elbling0] 168747 [host=elbling0] 168748 [host=elbling0] 168749 [host=pinot0] 168751 [host=elbling0] 168752 [host=elbling0] 168753 [host=elbling0] 168754 [host=elbling0] 168757 [host=pinot1] 168758 [host=elbling0] 168759 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168762 [host=elbling0] 168766 [host=elbling0] 168770 [host=pinot1] 168774 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168777 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168779 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168780 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168783 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168785 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168788 [host=pinot0] 168789 [host=pinot1] 168790 [host=elbling0] 168793 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168799 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168801 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168804 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168805 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168806 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168808 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168812 [host=elbling0] 168813 [host=elbling0] 168814 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168817 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168819 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168820 [host=pinot1] 168822 [host=pinot1] 168823 [host=pinot1] 168824 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168826 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168827 [host=pinot0] 168829 [host=pinot1] 168831 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168832 [host=pinot1] 168834 [host=pinot1] 168837 [host=pinot0] 168844 [host=pinot1] 168854 [host=pinot1] 168858 [host=pinot1] 168859 [host=pinot1] 168865 [host=pinot1] 168981 fail irrelevant 169004 fail irrelevant 169046 [host=elbling0] 169069 [host=elbling0] 169102 fail 55637a2894babca97945eeca1da0d431f74f8627 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8eec96b7b8d937d40e2e7988edb8bbd08598c715 169117 fail 55637a2894babca97945eeca1da0d431f74f8627 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8eec96b7b8d937d40e2e7988edb8bbd08598c715 169128 fail irrelevant 169135 fail irrelevant 169141 fail 3e130e40fc55f06f7fe019e87ed9bae957870a12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db d62a34423a1a98aefd7c30e22d2d82d198f077c8 169144 fail 3e130e40fc55f06f7fe019e87ed9bae957870a12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db d62a34423a1a98aefd7c30e22d2d82d198f077c8 169148 fail 3e130e40fc55f06f7fe019e87ed9bae957870a12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db d62a34423a1a98aefd7c30e22d2d82d198f077c8 169150 [host=pinot1] 169153 [host=elbling0] 169156 fail 3e130e40fc55f06f7fe019e87ed9bae957870a12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db d62a34423a1a98aefd7c30e22d2d82d198f077c8 169161 [host=elbling0] 169165 [host=elbling0] 169169 [host=pinot1] 169173 fail irrelevant 169177 [host=elbling0] 169187 [host=pinot0] 169196 [host=pinot1] 169202 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169209 [host=pinot1] 169218 [host=elbling0] 169223 [host=pinot0] 169226 [host=pinot0] 169227 [host=pinot0] 169229 [host=pinot0] 169232 fail irrelevant 169234 [host=pinot1] 169235 [host=elbling0] 169242 [host=pinot0] 169247 [host=pinot0] 169248 [host=elbling0] 169258 [host=pinot1] 169263 [host=pinot1] 169265 [host=elbling0] 169266 [host=pinot0] 169271 [host=pinot0] 169272 fail irrelevant 169274 [host=pinot1] 169275 [host=pinot0] 169277 [host=pinot0] 169278 [host=pinot0] 169279 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169280 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169281 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169282 [host=pinot0] 169283 [host=pinot0] 169293 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169285 [host=pinot1] 169287 [host=pinot1] 169288 [host=pinot0] 169289 [host=pinot1] 169290 [host=pinot1] 169291 [host=pinot1] 169295 [host=pinot1] 169297 [host=pinot1] 169299 [host=pinot1] 169300 [host=pinot1] 169302 [host=pinot1] 169305 [host=pinot1] 169306 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169307 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169308 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169310 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169311 [host=elbling0] 169312 [host=pinot1] 169313 [host=pinot1] 169314 [host=pinot1] 169315 [host=pinot1] 169316 [host=pinot1] 169317 [host=pinot1] 169319 [host=pinot1] 169321 [host=pinot0] 169323 [host=pinot1] 169324 [host=pinot1] 169325 [host=pinot1] 169326 [host=pinot1] 169327 [host=pinot1] 169329 [host=pinot1] 169331 [host=pinot1] 169334 [host=pinot1] 169335 [host=elbling0] 169338 fail irrelevant 169339 [host=pinot0] 169341 [host=pinot0] 169342 [host=pinot0] 169343 [host=pinot0] 169344 [host=pinot0] 169345 [host=pinot0] 169349 [host=pinot0] 169350 [host=pinot1] 169352 [host=pinot1] 169357 [host=pinot1] 169358 [host=pinot1] 169359 [host=pinot1] 169360 [host=pinot1] 169362 [host=pinot0] 169363 [host=pinot0] 169364 [host=pinot0] 169365 [host=pinot0] 169366 [host=pinot0] 169370 [host=pinot1] 169371 [host=pinot1] 169372 [host=pinot1] 169374 [host=pinot1] 169375 [host=pinot0] 169376 [host=pinot1] 169377 [host=pinot1] 169378 [host=pinot1] 169379 [host=pinot1] 169380 [host=pinot1] 169381 [host=pinot1] 169382 fail 8a5727c7a82a371649419daddc2c52554ff29b16 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169384 fail 8a5727c7a82a371649419daddc2c52554ff29b16 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169385 [host=pinot1] 169387 [host=elbling0] 169388 [host=elbling0] 169389 [host=elbling0] 169390 [host=elbling0] 169391 [host=elbling0] 169392 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169393 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169394 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169395 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169396 fail 0c901fcc200e411b78b9ca42d07d5ea4aaa13b21 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169397 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169398 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169399 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169400 [host=pinot0] 169401 [host=pinot0] 169402 [host=pinot0] 169404 [host=pinot0] 169405 [host=elbling0] 169406 [host=pinot1] 169407 [host=elbling0] 169408 [host=elbling0] 169410 [host=elbling0] 169411 fail irrelevant 169413 fail irrelevant 169414 fail irrelevant 169416 [host=pinot1] 169417 [host=pinot1] 169418 [host=pinot1] 169419 [host=pinot1] 169420 [host=pinot1] 169421 [host=pinot1] 169422 [host=pinot1] 169424 [host=elbling0] 169425 fail irrelevant 169427 fail irrelevant 169428 fail irrelevant 169429 [host=pinot1] 169430 [host=elbling0] 169431 [host=elbling0] 169432 [host=elbling0] 169435 fail irrelevant 169436 [host=elbling0] 169437 [host=pinot1] 169438 [host=pinot1] 169439 [host=pinot1] 169440 [host=pinot1] 169441 [host=pinot1] 169443 fail irrelevant 169445 fail irrelevant 169446 [host=elbling0] 169448 [host=pinot1] 169449 [host=pinot1] 169450 [host=pinot1] 169451 [host=pinot1] 169452 [host=pinot1] 169453 [host=pinot0] 169454 [host=pinot0] 169455 [host=pinot0] 169456 [host=pinot0] 169457 [host=pinot0] 169458 [host=pinot1] 169459 [host=pinot1] 169460 [host=pinot1] 169461 [host=pinot1] 169462 [host=pinot1] 169463 [host=pinot1] 169464 [host=pinot1] 169465 [host=pinot1] 169467 [host=pinot1] 169468 fail irrelevant 169469 fail irrelevant 169470 fail irrelevant 169471 [host=pinot1] 169473 [host=pinot1] 169476 [host=pinot0] 169478 [host=elbling0] 169479 fail irrelevant 169480 fail irrelevant 169481 fail irrelevant 169512 [host=elbling0] 169482 [host=pinot0] 169484 [host=pinot0] 169485 [host=pinot0] 169486 [host=pinot1] 169487 [host=pinot1] 169489 [host=pinot1] 169490 [host=pinot1] 169491 [host=pinot1] 169492 [host=pinot1] 169494 [host=pinot1] 169496 [host=pinot1] 169497 [host=elbling0] 169498 [host=elbling0] 169500 [host=elbling0] 169501 [host=elbling0] 169503 [host=pinot0] 169504 [host=pinot0] 169505 [host=pinot0] 169506 [host=pinot0] 169508 [host=pinot0] 169509 [host=elbling0] 169510 [host=elbling0] 169511 [host=elbling0] 169513 [host=elbling0] 169514 [host=pinot1] 169515 [host=pinot1] 169516 [host=pinot1] 169517 [host=pinot1] 169518 [host=pinot1] 169519 [host=pinot0] 169520 [host=pinot0] 169521 [host=pinot0] 169522 [host=pinot0] 169523 [host=pinot1] 169524 [host=pinot1] 169525 [host=pinot1] 169526 [host=pinot1] 169527 [host=pinot0] 169529 [host=pinot0] 169530 [host=elbling0] 169532 [host=elbling0] 169533 [host=elbling0] 169534 [host=elbling0] 169535 [host=elbling0] 169536 [host=elbling0] 169538 [host=pinot1] 169539 [host=pinot1] 169540 [host=pinot1] 169542 [host=pinot1] 169543 [host=pinot0] 169544 [host=pinot1] 169548 [host=pinot1] 169549 [host=elbling0] 169551 [host=elbling0] 169553 [host=pinot1] 169554 [host=pinot1] 169556 [host=pinot1] 169558 [host=pinot1] 169559 [host=pinot1] 169561 [host=pinot1] 169564 [host=pinot1] 169567 fail 76fda1def3d1baea3b01ae697687ff478d2d1b42 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2ce9afd68e0bacc15b5570a983fa626cc4de9dbd 169568 fail irrelevant 169569 [host=pinot1] 169571 [host=elbling0] 169574 [host=elbling0] 169585 [host=pinot1] 169575 fail irrelevant 169578 fail irrelevant 169579 [host=pinot1] 169580 [host=pinot1] 169582 [host=pinot1] 169583 [host=pinot1] 169586 [host=pinot0] 169587 fail irrelevant 169588 fail irrelevant 169589 fail irrelevant 169590 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169592 [host=pinot1] 169593 [host=pinot0] 169594 [host=pinot1] 169596 [host=pinot1] 169597 [host=pinot0] 169598 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169599 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169600 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169602 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169604 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169606 [host=pinot1] 169607 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169610 fail irrelevant 169612 [host=pinot1] 169615 [host=pinot1] 169618 fail irrelevant 169620 fail irrelevant 169621 fail irrelevant 169623 fail irrelevant 169625 fail irrelevant 169626 [host=elbling0] 169628 [host=elbling0] 169631 [host=pinot1] 169632 [host=pinot1] 169633 [host=pinot1] 169634 [host=pinot1] 169636 [host=pinot1] 169637 [host=elbling0] 169639 [host=elbling0] 169641 [host=pinot0] 169642 [host=elbling0] 169643 [host=elbling0] 169644 [host=elbling0] 169646 [host=elbling0] 169647 [host=elbling0] 169648 [host=pinot1] 169649 [host=pinot1] 169650 [host=pinot1] 169651 [host=pinot1] 169653 [host=elbling0] 169655 [host=elbling0] 169656 [host=pinot0] 169657 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169658 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169659 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169660 [host=pinot1] 169678 [host=elbling0] 169661 [host=pinot1] 169663 [host=pinot0] 169665 [host=pinot0] 169667 [host=pinot0] 169668 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169670 [host=pinot0] 169672 [host=pinot0] 169673 [host=pinot0] 169674 [host=pinot0] 169675 [host=pinot0] 169676 [host=elbling0] 169677 [host=elbling0] 169679 [host=elbling0] 169680 [host=pinot1] 169681 [host=pinot1] 169682 [host=pinot1] 169683 [host=pinot1] 169684 [host=pinot1] 169685 [host=pinot1] 169687 [host=pinot1] 169688 [host=elbling0] 169689 [host=elbling0] 169690 [host=elbling0] 169691 [host=elbling0] 169692 [host=elbling0] 169693 [host=elbling0] 169695 [host=elbling0] 169697 [host=pinot1] 169698 [host=pinot1] 169700 [host=elbling0] 169701 [host=elbling0] 169702 [host=elbling0] 169703 [host=elbling0] 169704 [host=elbling0] 169705 [host=elbling0] 169706 [host=elbling0] 169707 [host=elbling0] 169708 [host=elbling0] 169709 [host=elbling0] 169710 [host=elbling0] 169711 [host=elbling0] 169712 [host=elbling0] 169713 [host=elbling0] 169715 [host=elbling0] 169716 fail 483d3bb716bfd1a90fde165a761067c50c482d4e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169718 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169719 [host=pinot0] 169721 [host=pinot1] 169722 [host=pinot1] 169724 [host=pinot1] 169726 [host=pinot1] 169728 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169730 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169731 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169732 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169733 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169734 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169735 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169738 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169740 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169742 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169744 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169746 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169750 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169754 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169757 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169758 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169759 [host=pinot1] 169761 [host=pinot1] 169763 [host=pinot1] 169764 [host=pinot0] 169766 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169769 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169770 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169772 [host=pinot1] 169776 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169778 [host=pinot0] 169780 [host=pinot0] 169783 [host=pinot0] 169784 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169786 [host=pinot0] 169791 [host=pinot0] 169793 [host=pinot0] 169796 [host=pinot1] 169797 [host=pinot1] 169799 [host=pinot1] 169802 [host=pinot0] 169803 [host=pinot1] 169804 [host=pinot0] 169806 [host=pinot0] 169808 [host=pinot0] 169810 [host=pinot0] 169811 [host=pinot0] 169812 [host=pinot1] 169814 [host=pinot1] 169815 [host=pinot1] 169816 [host=pinot1] 169821 [host=elbling0] 169828 [host=pinot0] 169832 [host=pinot1] 169835 fail irrelevant 169837 fail irrelevant 169839 [host=pinot1] 169841 [host=pinot0] 169842 [host=pinot0] 169845 [host=pinot0] 169848 [host=pinot0] 169854 [host=pinot0] 169858 fail irrelevant 169865 [host=pinot1] 169866 [host=pinot1] 169868 [host=pinot1] 169872 [host=pinot1] 169873 [host=pinot1] 169874 [host=pinot1] 169878 [host=pinot1] 169879 [host=pinot0] 169880 [host=pinot0] 169882 [host=pinot0] 169883 [host=pinot0] 169885 [host=pinot0] 169889 [host=pinot0] 169892 [host=pinot0] 169894 [host=pinot1] 169901 [host=pinot1] 169904 [host=pinot0] 169908 fail irrelevant 169905 fail irrelevant 169910 fail irrelevant 169913 [host=pinot0] 169914 fail irrelevant 169915 [host=elbling0] 169916 [host=pinot1] 169917 [host=pinot1] 169919 [host=pinot1] 169920 fail irrelevant 169921 fail irrelevant 169922 fail irrelevant 169923 fail irrelevant 169924 fail irrelevant 169925 [host=pinot0] 169926 [host=pinot0] 169927 [host=pinot0] 169928 [host=pinot0] 169930 [host=pinot0] 169931 fail irrelevant 169933 [host=pinot1] 169934 [host=pinot1] 169935 [host=pinot1] 169936 [host=pinot1] 169937 [host=pinot1] 169941 [host=pinot0] 169943 [host=pinot0] 169944 [host=pinot0] 169945 [host=pinot0] 169946 [host=pinot0] 169952 [host=pinot0] 169955 [host=pinot0] 169960 [host=pinot0] 169963 [host=pinot0] 169966 [host=pinot0] 169969 [host=pinot0] 169970 [host=pinot1] 169971 [host=pinot1] 169972 [host=pinot1] 169973 [host=pinot1] 169974 [host=pinot1] 169975 [host=pinot0] 169978 [host=pinot0] 169979 [host=pinot0] 169981 [host=pinot1] 169983 fail irrelevant 169987 fail irrelevant 169988 fail irrelevant 169989 fail irrelevant 169991 [host=pinot0] 169994 fail irrelevant 169995 [host=pinot1] 169998 [host=pinot1] 169999 [host=pinot1] 170000 [host=pinot0] 170003 [host=pinot0] 170004 [host=elbling0] 170005 [host=pinot1] 170006 [host=pinot1] 170007 [host=pinot1] 170008 [host=pinot1] 170009 [host=pinot1] 170010 [host=pinot0] 170011 [host=pinot1] 170012 [host=pinot0] 170015 [host=pinot0] 170013 [host=pinot0] 170016 [host=pinot0] 170017 [host=pinot0] 170019 [host=pinot0] 170018 [host=pinot0] 170021 [host=pinot0] 170023 [host=pinot0] 170024 [host=pinot0] 170022 [host=pinot0] 170025 [host=pinot0] 170027 fail irrelevant 170029 fail irrelevant 170028 [host=pinot0] 170032 pass 51adb689e1db695cffdeeacafad218768fbc018c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 7ea428895af2840d85c524f0bd11a38aac308308 7292e4a0a8f58333ccbd2d0d47242f9865083c9c 5268b2dcf7e5342c8a51ceb4bed3e7740c69f5c1 170033 fail irrelevant 170030 fail irrelevant 170036 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170037 pass b1b89f9009f2390652e0061bd7b24fc40732bc70 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170038 fail irrelevant 170039 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170040 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170041 fail irrelevant 170042 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170043 fail irrelevant 170044 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170045 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170046 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170047 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Searching for interesting versions Result found: flight 162371 (pass), for basis pass Result found: flight 169382 (fail), for basis failure (at ancestor ~137) Repro found: flight 170032 (pass), for basis pass Repro found: flight 170045 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 170039 (pass), for last pass Result found: flight 170040 (fail), for first failure Repro found: flight 170042 (pass), for last pass Repro found: flight 170044 (fail), for first failure Repro found: flight 170046 (pass), for last pass Repro found: flight 170047 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/170047/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu neato: graph is too large for cairo-renderer bitmaps. Scaling by 0.254396 to fit pnmtopng: 45 colors found Revision graph left in /home/logs/results/bisect/ovmf/build-i386.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 170047: tolerable ALL FAIL flight 170047 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/170047/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386 6 xen-build fail baseline untested jobs: build-i386 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Tue May 03 13:46:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 13:46:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319676.539993 (Exim 4.92) (envelope-from ) id 1nlsqn-0003mh-RW; Tue, 03 May 2022 13:46:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319676.539993; Tue, 03 May 2022 13:46:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsqn-0003ma-ON; Tue, 03 May 2022 13:46:01 +0000 Received: by outflank-mailman (input) for mailman id 319676; Tue, 03 May 2022 13:46:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlsqm-0003mU-Lk for xen-devel@lists.xenproject.org; Tue, 03 May 2022 13:46:00 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0e::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cf920ed-cae7-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 15:45:59 +0200 (CEST) Received: from DU2P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::6) by DB9PR08MB6780.eurprd08.prod.outlook.com (2603:10a6:10:2a0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Tue, 3 May 2022 13:45:47 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::ee) by DU2P251CA0011.outlook.office365.com (2603:10a6:10:230::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Tue, 3 May 2022 13:45:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Tue, 3 May 2022 13:45:47 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Tue, 03 May 2022 13:45:47 +0000 Received: from a428f5eb00a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9E08E64A-7D4F-4FF7-823B-B0C82B92989F.1; Tue, 03 May 2022 13:45:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a428f5eb00a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 May 2022 13:45:40 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com (2603:10a6:208:131::12) by DB8PR08MB5449.eurprd08.prod.outlook.com (2603:10a6:10:119::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Tue, 3 May 2022 13:45:39 +0000 Received: from AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40]) by AM0PR08MB3956.eurprd08.prod.outlook.com ([fe80::c9b3:a7d5:f4ee:8c40%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 13:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cf920ed-cae7-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QSUPa9hpkPN+X5xVNNmvVxIAJX7WT8bQ5EJKvCflhOqXt+cdC7RN/+Gsf3GSCBQrG900UomTHnOIF0YwT7X3EMBYSSTf1N5K2l0tFvGoiP0LB4NZFVGPdH2fCRx0ZsWzoNgaHOyPXaz0LBIr9CXsq0akGNveZCZcvHqRtn/5sk3C+Br6eMGmkRfW9RdO7NL4nbkdtyOUYBXCwgihHpzo5hWIeizdDGQrZ+TtJtCAQQEcGE5BOCeLMlQ5QQRWzj9idRqOpgvE3UpdzQS3KolSTLqOISM6V1Dn1mQ310Svu12FzniLxf53zvQanPGml0wOU4ViQbDojptpn1w3yGzegg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O0S4P+wMGdro3ettmemfnoQoqv10broPkU6qZu3+1Tw=; b=TR5cu4ol6CQoKLOkgUtMDfXbSPTCrtOWT1Nl0NMcQ2Qu1k4Q+KNyt4curr7tu9jNhaLv+WBqpP6qo7H3tPCh+4INoekKgnpPSrYZrd9gmakDHbJ3SzFfRkniOqJ5X3WYcLQEl+kDgR80rwqDlEuXXoEapTHljUz/41/SH0qDBHZT6drSgyDlaBo+EDfjzvPkXNCcEsl8lqU7gmRo9ixhbAjSoFnMod5+8mxyVRt7WUXpLbrTKhP7RTtg68L9gDqnUWWVKfW6jdYnUzzUVqOTtSjFFaoqtiIj16FkY1Muj3p3obOyCCKktca+cnaDpBnfkB8ij3uHDPxCkAvuRnWM1w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O0S4P+wMGdro3ettmemfnoQoqv10broPkU6qZu3+1Tw=; b=lOk6SIpWfax5ICAHk4MuEZg2rXJcpJDPiBI5aKbmX/re1taweC5Fa8PImMoZMFjF5mCpiReVRKgDfW0WjgyfBqhAIq2WJR7hOEqe0R+vCtKcVmqYdmTzSY80++DhoRDNr+ztaaIopRH2eH6p3IuMx9/09dvuGugskb9HYUy89mI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 730a73346a3d0705 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOmK0G6keQWmkX+9VLUG8SL3pATwel/Y3pIcTA2uc/yBRZuHVryUDY/NS4pHgsM8vfrpIjpyJBlO/jFq1JgCLWQAKmgmmbVLRbs4hEmbb78SjM3rN+PxkCG1+U40+KZNjX5E5jxhur2+Hvh2VJrWauPJABY5C/Vb1NrcfXDtuc1BH11jZkkXe//RnEgDA4lkO/AZg//wvwGtKRHfWuo4VOQjkPDJErRPW4m/1WkC0WAedTrr5DKQE5aOja5me2MwyBZ115udfN/Zs+keujIJb33jXwwfi6+D3rsVkel9F1fZvPpGOLotGdwwbo+7Zf8rqBZs3LoljAvKtgpQDO4GqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O0S4P+wMGdro3ettmemfnoQoqv10broPkU6qZu3+1Tw=; b=FXf0IaBZxjZF5NiPW/lQJB97UusdfwStTzrSGiEf5lgXav7xmADXrXNd6ykf7LBSf5H1TEQrqfbK/c0RUyEANLqtPekAcHWe213rCFni+fK+oHu9swR2F9D5ixF8XyF9n6S05HjDLsbPiQs3cYVtdtt8cFKrlVim+OR5gN3LRXQXHEOCd53Rp4Jonp+bVdPw1D5sh37soSMEKGA8q6k2Y9QwdZhxlklRNxKsbzpuqXqzy35QmqyPF05+9ueyAe4shaZxkb8h0TGPSuiAt30eVityegE9+0hjnrYpnPBlFP+/+FCMTDIekgY2YR/uhECLhyFG2tNfz5au6uZx7agXgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O0S4P+wMGdro3ettmemfnoQoqv10broPkU6qZu3+1Tw=; b=lOk6SIpWfax5ICAHk4MuEZg2rXJcpJDPiBI5aKbmX/re1taweC5Fa8PImMoZMFjF5mCpiReVRKgDfW0WjgyfBqhAIq2WJR7hOEqe0R+vCtKcVmqYdmTzSY80++DhoRDNr+ztaaIopRH2eH6p3IuMx9/09dvuGugskb9HYUy89mI= From: Luca Fancellu To: =?utf-8?B?QWxleCBCZW5uw6ll?= CC: xen-devel , "stratos-dev@op-lists.linaro.org" , Richard Henderson , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw Thread-Topic: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw Thread-Index: AQHYWuuXqjHgGotG8UqKAs+V57fbVK0NMk6A Date: Tue, 3 May 2022 13:45:39 +0000 Message-ID: <22930B07-FC34-4707-B900-20CB085F5127@arm.com> References: <20220428103410.2723837-1-alex.bennee@linaro.org> In-Reply-To: <20220428103410.2723837-1-alex.bennee@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9ea8da1f-48f4-449c-3aec-08da2d0b3a88 x-ms-traffictypediagnostic: DB8PR08MB5449:EE_|DBAEUR03FT040:EE_|DB9PR08MB6780:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /aAGThh9VFE6b/MOl0NHauRjFqag2yPldt4TPdfsGjmMYs0/1xKe7JEqygLamPjFj9KS9B4BgO8GST9naTjkPH/BtH50FjbaJtNQndrk2saII6cFw1K8XQFrIwEyOeIUdaG89AoZK+WY9qCp1ialpEWTBUlwbJWwexc1BoLme8GCxUx69S7k0Cm1uo1IVu2MgV1XO0YHOeSdFq2VeDqqI4BlAKPa2BBH9OYl5HCneDalXM863HjIfY1ehrQyqxUn7pgjb5SiEqGbgX8rAK9a6kKNCPe2pFKphL4ZwG+l/0ugJlHEd6hFGWjSQ39crQDh77OJWdz7qi1T9qWjHu2Q7XauVBOdCTsXVAJMGTc1kzJtKVTHz51+gZPpsObhowfchLlHk80MKSNoqE0hwH6EbpBifPj1gI8DXUSwymEDo8qAGdAvXNFoQyvoGasCsrVsCCNa9zms5x5g7/GPLIZ7j28VyqoWwaTAkChy1FdqmC12uc7R/QSv3lCMvF52w0Zc88Y9dUjaqGJBdo5ygxnLHD4AKjT19tWEGZ935xbekJB/oDhiM8xdNYw2IoXEJ0QRoU7d+kQUF+3CeeBROeF+b8AjCIkWyEoktWkVH3VH6QhRciPQ39e4JVBfJyhSHCd1ZxX4atxDwU5Xr9jQLIT88E7kkhwjWD+ZsybZCci4/97IfQsgpuRj064TrRrWlZxKK+fY5ZpicCKdNVNWa4M/UJVf9NX+8JonSnqze26sH5EXquK+QMsZY24H3KNIT/zS X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(6512007)(5660300002)(6506007)(53546011)(26005)(76116006)(38070700005)(8676002)(6486002)(66556008)(38100700002)(64756008)(2616005)(66476007)(86362001)(2906002)(66446008)(33656002)(186003)(6916009)(54906003)(508600001)(316002)(122000001)(8936002)(71200400001)(36756003)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <78D24626CCC1C14287F1B695EBFA0228@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5449 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7cec0545-0e05-4bc8-2d91-08da2d0b35f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: taVSX2o8yshZ4wU6IEEnHBEQZvwxmF6CokwxliLVQQ836p1OoCwGHjU4rrVZxgEGricZbS6XYjhkyaP3VwC9DQ8dt1Sl44SQ3/uX5UfdA26EELhuisaBnv7cDQfPW4z8Uy8HWmKzbm5a9Y21Ex3knGSk22UXsasZnVkHabr6qRhrczeI7cl5ksKqgU0FNYW4Je3r7TT9GZG2xhTeyFQvajSdHSju55dxW7iiY/9EQu1sPlO5KIOSX+bMsb0gc2sA3pjlJhPSx8T4Zjj+3pDimne+7gdFzfitmwikxyYSMx3ftTQOyUKl1NhrKsL31d29osUxjFcbO/GjS9PeHXZLnqMRVAIcxbq52xuwWIj+R0CSIa/M50GaPpu7WzspZPbwZpsp3d0ZnxAD0V5NMlRJB8rqq+P6wIK9v2g/u9bFAhWYmWfFyFwHZPhXm6CKhVBnpDyod+Zki5rGJ6hCPejX5p5THMpRrlbIh/SmGVvFm56vSwZhKyW1hwkLWkqjpqyOdTXTCUOKwguUdn/DE1ufKCrNuYX+rNngHwQNyBvac7aMYzDPaIOJAJ51Bb2FTnnLoxLpSWa4DkYfNK3voTbe+owAtnPsoNZBZ1StM3MgCPEZvzl3dVUrNFhYeWbwSIUVnUqyb8lDzxGufFKAaDePD+7Ekdii57Wh2ivGGehSW2KJYiAu3BSLly3GAtnke+sR X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(54906003)(316002)(82310400005)(6486002)(2906002)(336012)(47076005)(186003)(6512007)(26005)(36756003)(53546011)(6506007)(86362001)(81166007)(8936002)(40460700003)(33656002)(508600001)(2616005)(8676002)(5660300002)(70206006)(70586007)(4326008)(6862004)(356005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 13:45:47.6243 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ea8da1f-48f4-449c-3aec-08da2d0b3a88 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6780 DQoNCj4gT24gMjggQXByIDIwMjIsIGF0IDExOjM0LCBBbGV4IEJlbm7DqWUgPGFsZXguYmVubmVl QGxpbmFyby5vcmc+IHdyb3RlOg0KPiANCj4gV2hlbiB3ZSBpbnRyb2R1Y2VkIEZFQVRfTFBBIHRv IFFFTVUncyAtY3B1IG1heCB3ZSBkaXNjb3ZlcmVkIG9sZGVyDQo+IGtlcm5lbHMgaGFkIGEgYnVn IHdoZXJlIHRoZSBwaHlzaWNhbCBhZGRyZXNzIHdhcyBjb3BpZWQgZGlyZWN0bHkgZnJvbQ0KPiBJ RF9BQTY0TU1GUjBfRUwxLlBBUmFuZ2UgZmllbGQuIFRoZSBlYXJseSBjcHVfaW5pdCBjb2RlIG9m IFhlbiBjb21taXRzDQo+IHRoZSBzYW1lIGVycm9yIGJ5IGJsaW5kbHkgY29weWluZyBhY3Jvc3Mg dGhlIG1heCBzdXBwb3J0ZWQgcmFuZ2UuDQo+IA0KPiBVbnN1cnByaXNpbmdseSB3aGVuIHRoZSBw YWdlIHRhYmxlcyBhcmVuJ3Qgc2V0IHVwIGZvciB0aGVzZSBncmVhdGVyDQo+IHJhbmdlcyBoaWxh cml0eSBlbnN1ZXMgYW5kIHRoZSBoeXBlcnZpc29yIGNyYXNoZXMgZmFpcmx5IGVhcmx5IG9uIGlu DQo+IHRoZSBib290LXVwIHNlcXVlbmNlLiBUaGlzIGhhcHBlbnMgd2hlbiB3ZSB3cml0ZSB0byB0 aGUgY29udHJvbA0KPiByZWdpc3RlciBpbiBlbmFibGVfbW11KCkuDQo+IA0KPiBBdHRlbXB0IHRv IGZpeCB0aGlzIHRoZSBzYW1lIHdheSBhcyB0aGUgTGludXgga2VybmVsIGRvZXMgYnkgZ2F0aW5n DQo+IFBBUmFuZ2UgdG8gdGhlIG1heGltdW0gdGhlIGh5cGVydmlzb3IgY2FuIGhhbmRsZS4gSSBh bHNvIGhhZCB0byBmaXggdXANCj4gY29kZSBpbiBwMm0gd2hpY2ggcGFuaWNzIHdoZW4gaXQgc2Vl cyBhbiAiaW52YWxpZCIgZW50cnkgaW4gUEFSYW5nZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFs ZXggQmVubsOpZSA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz4NCj4gQ2M6IFJpY2hhcmQgSGVuZGVy c29uIDxyaWNoYXJkLmhlbmRlcnNvbkBsaW5hcm8ub3JnPg0KPiBDYzogU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW5A eGVuLm9yZz4NCj4gQ2M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFt LmNvbT4NCj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4N Cj4gDQo+IC0tLQ0KPiB2Mg0KPiAgLSBjbGFtcCBwMm1faXBhX2JpdHMgPSBQQUREUl9CSVQgaW5z dGVhZA0KPiAtLS0NCg0KSGkgQWxleCwNCg0KSeKAmXZlIHRlc3RlZCB0aGUgcGF0Y2ggb24gZnZw IGFuZCBYZW4rRG9tMCBydW5zIGZpbmUuDQoNClRlc3RlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVj YS5mYW5jZWxsdUBhcm0uY29tPg0KDQpDaGVlcnMsDQpMdWNhDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue May 03 14:15:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:15:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319682.540004 (Exim 4.92) (envelope-from ) id 1nltJH-0007nW-7B; Tue, 03 May 2022 14:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319682.540004; Tue, 03 May 2022 14:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltJH-0007nP-3s; Tue, 03 May 2022 14:15:27 +0000 Received: by outflank-mailman (input) for mailman id 319682; Tue, 03 May 2022 14:15:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltJG-0007nF-13; Tue, 03 May 2022 14:15:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltJF-0004VM-U0; Tue, 03 May 2022 14:15:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltJF-0003ZQ-IR; Tue, 03 May 2022 14:15:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nltJF-0003eS-I1; Tue, 03 May 2022 14:15:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jR86F02pNFqJshAxJVz3n1c1c3K18MCY2UXnlKDxI0g=; b=rVYhPHOyEia6rNZGmFQPjDyPV6 sMq21qANXeAKj69L02kLhlpH7U/uEfF5UpY5xsMkDFYeRP9Phi3FbCP08pntDpJs5/GiIw2LT7rOT p6uKKHEIZmbeNC+l8O6ccXVQD9FjpNvCo4v7JfxDuGFSbZAaOkUS1K/Y6WyUCroxmU9M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170048: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 14:15:25 +0000 flight 170048 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 781 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 14:34:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:34:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319690.540015 (Exim 4.92) (envelope-from ) id 1nltbt-0002Cf-Sx; Tue, 03 May 2022 14:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319690.540015; Tue, 03 May 2022 14:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltbt-0002CY-PE; Tue, 03 May 2022 14:34:41 +0000 Received: by outflank-mailman (input) for mailman id 319690; Tue, 03 May 2022 14:34:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltbs-0002CS-GD for xen-devel@lists.xenproject.org; Tue, 03 May 2022 14:34:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2949d0dc-caee-11ec-a406-831a346695d4; Tue, 03 May 2022 16:34:38 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13--9XlBZ2QO6ityAiK7iXnZA-1; Tue, 03 May 2022 16:34:36 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR0402MB3639.eurprd04.prod.outlook.com (2603:10a6:209:19::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 14:34:35 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 14:34:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2949d0dc-caee-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651588478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Id/gGQfzxOdjNxz48+0puEPHm748yeLpkCxCB/6G4ac=; b=Fr6yhet8dOL/MvdheNGcGwyeU9J4LQZ5iIntNhp3miH+QdxOQTPY6l0Ee7mTLfczWoMv09 9M9Q3zCiQETuy1XnmMVXDCd0Rb4j//uScvd5Y+8yMm8Zgq3pA2GYYgVQIoXVaXlnFdrqwA 0dijFvNMas9JaDLNsGaN/9eG9yzUeio= X-MC-Unique: -9XlBZ2QO6ityAiK7iXnZA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LvvcIBRk8BitzEoQfQsF6rq3a1rc9aFLKEQwM+DCBbMNlBg5kf1gfBHC6oK7bY4EDZjNP40Uk/6krkHxSbx00YXYKaCWPfzeb8hVJcQSdeXXpH+GSKiBDZGNkQrGYKMXCEb2cLEQDTZrNHUL7a5mg1Y4HiV/DP/QsEt5KWrE4WsQ0kUn4gV4YAdBk4oFsFyeykszoI51Al+dtZ9cFjr10BlKQeNd48rBNpP3kUtI0gjXwPEDTe1GVpfpBHpi2/frRT+eefmljUJn5YyEszBYjI4NIYeqZscboABMlaU+Gn7ztSPQkenEa1mCbLhWUTm3XeLQZ4lVgSdhnXmHC+B3gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ORzGMUqT0Fv8u+AtgY9rL8u0IqW8rFi2nntxokHzZ8E=; b=FBNpNTbj9Olq0U4nIFT58ctqu3kTJtZl2XszRh/Z2uEhptPyLq/iYVClij2x86DuLDMqUeoj0MnS06g6NCGi9moOvsiaYsicI6fyDsoq/2wEJk7EBsUkkJwNox8CMDzTvbJhySJnUvj5OeH6ri4WTtAYL4DgpDevn/1gMysHXFZltZl7ukKhn6jC73rCCjHQ1yqXULMCh7XC4UDPke5Ixug2Co02pCOz2EfH3jpup2kTyCVZWVhOArgfYsEN6/QA6uV3rIBTUL2OQFxPXZVkrX4TQ1on6v1PEt4Prw1ZMNqtLbPLaSNH2pRaRz+ilgHf/2xWPI+V2iZKlFydLVcweQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ddf9998-45ce-962c-37bd-5c202a5f6279@suse.com> Date: Tue, 3 May 2022 16:34:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 01/21] AMD/IOMMU: correct potentially-UB shifts Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <0dec8285-a348-53d4-f9fa-552c7c1c405f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR10CA0067.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::44) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2ab3bbd-a7d1-42dc-39d1-08da2d120b52 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3639:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9kuNQwhxJ4AX3jl5UwJ5PFJzvvZTHJ8KT2fMlCjXIV+YCXz9SdBZGnmbTv+yJ2WaEmugncEHG1Fr8SQCmaJAAi7cbWi3UFjMxrwYC+mExHYwFOjCqZFlYnkW5QoDBK8acMq2oW1p7DLDuGGQKtGltui2pf+0DKxC7auNPfqzXKmwTJnBbPAOdo52EmbDguxz2yvCjioML0X2LOaMm2KCplmK7xVYFqULn3Mt8N3aUyCu4kSvHsEVhzlJWLCiI8jvDiQkIAcU2oSQzJw0DUUTM3QT89DwASNVqOEjEl+ZNH/oiyiPNTJezyS2cuTECMtibASFGjWo4QFDSfyYf7J1aVsZzDKOGU2jhwI/ZfR580wHv5kG5iJIV9RIhuD7FZNOe5pAsOJDfhn+hByefvooxyh0TfnR9+x5J7Km90MsdbhsS2ktbR0Rc/8VXT3bZuucplb3wYnMzt0LilRF/1PVti4VsWdRlmxSWjB47qKDZ0NP+k5KSWmn8aeakpQ/OmNSQuxnSrBXje6x+8Kw9xwGvv+V819LcOTgFgBuVi8bWbLDR5HakUvUksBXRMsnE5zT4y6iVlFHB0xYc5S0ZtdRUkFvgMKSkoIILQrUbtdq7GcMdTKklsm/D14oUGjE/i1+Bw9HwRIj9qNtfEilg50KJrdGWToMjmVkbc4f/e5JfsfXJEwn6PDr37J1xCLGE9Xj92AHsaZL/EQGFLW4a0DW/W39pF30TfN+JKh3QXJbiZE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6486002)(36756003)(6916009)(38100700002)(31686004)(2906002)(54906003)(8676002)(66946007)(66476007)(8936002)(66556008)(4326008)(53546011)(6506007)(83380400001)(316002)(186003)(31696002)(2616005)(86362001)(508600001)(26005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZWTq1H+e9ZBMk3rdYImRARbqPlCPwNMYzXlyAxFaRcxEIZ9x6gXiOZCSPAoD?= =?us-ascii?Q?OsPgBTK4966PLYXGnII1sJA7bnSotktGC2u83jdHZxApKgHNMFmDTYbkkbv0?= =?us-ascii?Q?APaQt+pyycfFBcNMsoy0BlhcDvB3FHraNJIARfpRCwtJDEmb4Sx1Gr7TTerf?= =?us-ascii?Q?mbVeBwfpXzfMh6wcP4o0IleZERSVnjbqczNjXhxIw7rphjZHjqaE7bjKE34M?= =?us-ascii?Q?wSWYzEJDfbs8nVACbRtH3Bp5Kd/Tei6mRZrkKrL+H4S59hKTq8hBWk9xV3gf?= =?us-ascii?Q?6YmVaC2IL1qLaZ1Vywlr5uNzb2QivXWLZjc32ESY+D1b9SfmDroP0D4Y2RoK?= =?us-ascii?Q?1+tnc83uGGdisX95zLTqY+KdXZyyhmMqUmFcPSOkcKMhCD0TwUQ0TFaMG4Sr?= =?us-ascii?Q?5JZ22tS8/MfHV2OlUzBn7zw5/tUysX22tJ4hMxnKgxMaZi78GYku2NizDhB5?= =?us-ascii?Q?OAxCnxts54rBfLFz/KCUpdwz2n6DjbMgZ96kDIEWCitAxZMwPHpmbkDFUOZr?= =?us-ascii?Q?jG4apMfl5NyF5zOhUL/ySEfiTRPoDnLgFG+9H4gDTG0BgN7JbdwMfDJBmz2f?= =?us-ascii?Q?xOqBHrrTxpDFb3ANzrCxaFpsg4i6CahRQrux0bSnUBxD7TQ5zohaVzKofwZA?= =?us-ascii?Q?9ujDA4NPdUYG3zWeEeyYgH8si3dtzlLQtI6yC6QkNaF8w2RBdm+9YafzhAit?= =?us-ascii?Q?S6IqbTNxDR4oDH+ySkr15VwpzbkKa1/x2QPNw52UP7PHZ5bhJuSeeUodmF7a?= =?us-ascii?Q?RguoDaIzxMFDTVBhDz8jzjB2MWa0WgFHxcIjS/5RLeVElV0h/4eiZ9Q88Jxe?= =?us-ascii?Q?HeL7N9kmiOQNQgPZ1eVcCoG/ooGcwzoUeQkWcWO4FasgHu7mcSiOIJaFPp9R?= =?us-ascii?Q?cIBNIxtJtUqgvd/vCpxNmHFwdAf7u5gH6jXzkium/HFTR2S1Q4eska4yeKGq?= =?us-ascii?Q?sos2W9TtgSfMwvs2i72OeGQ8sIFu5SJr1M6JMOnhCYUr0luChsYF350L2ZVU?= =?us-ascii?Q?ocMZVzuIpvaGb7nL25Bg8lUqIk82sxdmoPlYuEzkIFvhqOQ907cddRLpOWmQ?= =?us-ascii?Q?5Y57FNN+pbHTwH/Ty63QmrDtmhNE/XuvTuNVu8VZNzNN4yCJZPXGoUdR74X3?= =?us-ascii?Q?0zpWVDiBL1v4Kz0sKnjwZAWNOJHlgEE5ibRqXHiE06R3r87g2s/Y9N0o0sw/?= =?us-ascii?Q?Fz5WuFYDN5DwR93iflFZRBLJA0asRNrWcbS2907SQV6iIVpixMSW6aryIQxw?= =?us-ascii?Q?1veemb8k6jOvs3BgA88ITRG1GAktq+Lnoaq5dx3BLpwFXnHKG5dVRPNwKHri?= =?us-ascii?Q?V3F78XiaVaVSKJsKODN0en8rYFq6VANa+lhbq2GwCVNop2l/T2Gf/1WykZeA?= =?us-ascii?Q?tFxYBJuOK7xic2YEav4z3QsGBWpiKHu+eHbAAYtN+xZ+FVLHMLp4lwhvJVef?= =?us-ascii?Q?4OyY3l08VTHvm35NVrNFD7LZSG+KTJFs86tooemuFPvg5j056/ciIFup6Yf3?= =?us-ascii?Q?NtGn5F0WSmeyZ0BwbvmvlShZo5nI6+5zZUwSER5BhLro0VpcrWLeQ/u27slg?= =?us-ascii?Q?hMfQB9gFDg5SRkRq30C81WENe4ST5laQeptXuROxpAy3YSW1bcjZzDyPaPrD?= =?us-ascii?Q?WJiPtloFWx1Y4+z2kWmZomj4pDEcKW4gO/Rfzd1BvXkyBEPlWF5o+em5zliI?= =?us-ascii?Q?w8ydqTIoE9lwvRUk6Se5eG25oMw8Gy39CadmuoJJNAqvi28e5zA8ympXEoKo?= =?us-ascii?Q?DIkYMTs/2A=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2ab3bbd-a7d1-42dc-39d1-08da2d120b52 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 14:34:35.1445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2CXP3FSCnEzlTkbXGRiFAWTPbdHTJQiRK/hy0aRBzXgsxK4Ls89KYcgwOKZPHz3xsjam1Hzh93z2Uo6iRpMzWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3639 On 03.05.2022 12:10, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:30:33AM +0200, Jan Beulich wrote: >> Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify >> the target level for page table walks"]) have made Coverity notice a >> shift count in iommu_pde_from_dfn() which might in theory grow too >> large. While this isn't a problem in practice, address the concern >> nevertheless to not leave dangling breakage in case very large >> superpages would be enabled at some point. >> >> Coverity ID: 1504264 >> >> While there also address a similar issue in set_iommu_ptes_present(). >> It's not clear to me why Coverity hasn't spotted that one. >> >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. >> --- a/xen/drivers/passthrough/amd/iommu_map.c >> +++ b/xen/drivers/passthrough/amd/iommu_map.c >> @@ -89,11 +89,11 @@ static unsigned int set_iommu_ptes_prese >> bool iw, bool ir) >> { >> union amd_iommu_pte *table, *pde; >> - unsigned int page_sz, flush_flags =3D 0; >> + unsigned long page_sz =3D 1UL << (PTE_PER_TABLE_SHIFT * (pde_level = - 1)); >=20 > Seeing the discussion from Andrews reply, nr_pages might be more > appropriate while still quite short. Yes and no - it then would be ambiguous as to what size pages are meant. > I'm not making my Rb conditional to that change though. Good, thanks. But I guess I'm still somewhat stuck unless hearing back from Andrew (although one might not count a conditional R-b as a "pending objection"). I'll give him a few more days, but I continue to think this ought to be a separate change (if renaming is really needed in the 1st place) ... Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 14:37:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319697.540025 (Exim 4.92) (envelope-from ) id 1nltel-0002sm-FN; Tue, 03 May 2022 14:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319697.540025; Tue, 03 May 2022 14:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltel-0002sf-CK; Tue, 03 May 2022 14:37:39 +0000 Received: by outflank-mailman (input) for mailman id 319697; Tue, 03 May 2022 14:37:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltej-0002sG-No for xen-devel@lists.xenproject.org; Tue, 03 May 2022 14:37:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 928a69fa-caee-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 16:37:35 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-eZhpcM0XMUmZIcOaVOF52Q-1; Tue, 03 May 2022 16:37:33 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB5377.eurprd04.prod.outlook.com (2603:10a6:208:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Tue, 3 May 2022 14:37:32 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 14:37:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 928a69fa-caee-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651588655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJasbgl5K181eMpWCwlaUaFuJJ11AypZXM97LiZ3c4I=; b=TGHmXtymsUS77XTqEz/AdTeii+P52FsRSSkwCXsCSRNdPbvcNtBoNWbznY370vz1DwloPM ekuvtDKZHsFdTR/XFc2vZcQIjv5ysZCV06LTFjfn5RRHpnDQkBsmpEdzr1qsABmB6kFCJZ xUumyEZu6UVLgv5k2MeUYrsV2mbTLic= X-MC-Unique: eZhpcM0XMUmZIcOaVOF52Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+lG2EtKWRw33VME8fdCG1tsjBL4NHdNWk2vzJlQmwGNB4lA8Ci1MfuRuf/x4DoL7yg+5JQGoS3As2CZUKxgt8VFDkI1cF9r7SQxwMJzZNFMsRSVS5ha/SipulVab5Fpbq43JrzwhIM6pPacwUSbqgrr6KtzwjGA+3N45C44eO3c+q9KNXmUWxHYjmB93Y7REJPtjTYTvtP44AAGMqD8IATqc2RcAG5LwOE8B4iglti57zVelsekoTQ/+uaqYZQn3lHUdRJyoewO4D6wUwKtc/ZS+8ZzcB8TC2ZQaJ7/PtFXhDPu8WGK3A/bkHEPv8+KgS1WVz8gNtEBTQUI58FylA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XiM3v9ehxjalEdyydAEZPE86Myb11PHYx6eUAjSqLm4=; b=OJ/9+U9mR71xAhnYCbp39sSm+kQ8C2cy47sxaiyM0Csjm71g7Ca512FAL7nlURmkMv6TlVeAOSR9gueaSh3sBa+W1GnyEEs2DUXF8RP89td9HVXQl4lKOCNfz0TM6EijuUd6moAaAgUOhTjGoWj3kWprZauzGc39E0f4qZKiiwbKMdffo9otZ3MdmxQ4z3NE1r2LPX6YIUfTGDaENLxMAlTZYSkL3MOwZeOBoLnC0YUjHo9nKUzWF441RzuFIyHmc8BNNZlpZDa9rNE3GIxbqVXd3mJII7RAXryA8S7dvdyne34wVYZo70G8LyJv0ZDxMj7JAFHdCFkRnzgopcTkwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <35e5935b-7082-8224-7ad1-84ed12116426@suse.com> Date: Tue, 3 May 2022 16:37:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR1001CA0036.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::49) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4f5a8f2-1e1b-4f7f-bae0-08da2d1274f1 X-MS-TrafficTypeDiagnostic: AM0PR04MB5377:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sP5DCZUAzXZ0QKHd3+PKHCaCvMPCIrPIf3NlQfWn3tgIg7ZljqcxRryt5iJI4D/8Hh9yzjzdwB/rAgdxRzyUFtgtePxatm4NX8HJlXVgNEmcDrwH9XrqFqRNyx0NhQ0fxrpu8B+6AABlg7lhnqttvVT8GQ0ryfyRj6uVFeZbvBjBNOhMh5Pso9U23J6FDJanWPnOYnV+HKlTkso5YrZnUPtlI9C9Y5nXMyU0Op91VwponEGfwFX+jgwFnjiD9tRaMhLs9n9S6muZs7Lky2KQIWL9hS5xhfQXxwbmZpoNutNGb5vwpZ7xOHQRNBG5IUz//9cR0WGKUNW65hw72bRVqBblZGlyonbY7Qg46E7jToMMYnRXGkvRlkbtd9Wqy/3Cp0h6GbMeVyphW/7IlfgoavGwinB+MnaBjIjgoUYfjndn3ZP+WV+F/qJI/RI7L6ZnvKMDVO2Hn3fbJ6wAj2w+iQh+L0pSSATSY/YIXuKF16ZD0RpVk3aThjsgfq33ChFstnwhPk6tePJhqBulMRbC1cKVxyA1Zu2+GVmYZaAw8o7wFf0ukJoOThps8CLecHRTN5LV9GY1/TJMIoxydr6HEfXAYicewZypWhNde4Isq0+yw/xVas5H/+P2tLd/Q6OsYU04iyXc1I3zpwLhQVKf0J3KycXxVLjOTXQkWviv9ieKzufhjZ0fnvVF6oYA+7lHdiJCdSjkmhHgtvz+vLLLbatNdYQe6R+gPYeXponNGLh94okaX0gyum2oQML5NPSp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6486002)(508600001)(66556008)(66946007)(8676002)(31696002)(86362001)(66476007)(4326008)(38100700002)(6916009)(36756003)(6666004)(316002)(5660300002)(186003)(54906003)(31686004)(53546011)(26005)(6506007)(6512007)(2616005)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HqeFZyP0a0OhPJj7M0dRwWOmpY6wYj/x6zTPN/FKZ1wUZDKszeEjVE4cY3P1?= =?us-ascii?Q?7LfI7plsjjXKCRP6T3Ljfam4NdU58a9Uf35Kukkx9AHTK2z+6YuH2YmvTyvc?= =?us-ascii?Q?WqrRV2QhrVCQ3RKM8f1AZcvlg37HxSHd+bPrDcDVwXAhuAvWDEJmfHygnmEP?= =?us-ascii?Q?xXFyi3+v5vBp/4JSQttdW/mdBPWGqWtWkIz0kZ9A6fcRYnMMGN3cEAwBm+9v?= =?us-ascii?Q?2UO+3X6wWZXT1wPV1+0N3gasRw6wxPuoH7U8A6YwA/GS54lOgeO0XJmWxFsx?= =?us-ascii?Q?9KbKu4ZjtJbmiYfObSHwD3qvPcQQpS1taK0uqV8PbqK+CilAXPYzQgK7zsaO?= =?us-ascii?Q?T5e2I7atv72EtXlaRLPWLrmLG4mpooj8D8CpQUEGeh40wcm/DoZfRNK8z6KY?= =?us-ascii?Q?TLdKvEeugHybCY5aHsJ58flTNl/CJLvEURn4nAPV06oewHyQ8Znh4x7pDIUn?= =?us-ascii?Q?30LVr0bAKAs/YUeIDhw4kXDn+OqcS6vL/hVCvfpZ6Yw149603p39szDNMQXV?= =?us-ascii?Q?lyTWYyzXC4gTKGW/Z5pjsdrKHdFnZK8ZhQefUG93/HKemag5nm0KlhSZuGo2?= =?us-ascii?Q?yLBAxQb1bLyyqyE9lkmUvwP08ozQnax5eec96KBqL5Cwx8dduWZVQIwMu61r?= =?us-ascii?Q?EhAWhVBT1/wkasHUNCkJGBYFYb7xqJqDjfKgklTVNhqvYXXs/d4YK6r0B1Nh?= =?us-ascii?Q?+0wcKYp20wZN1M7vZfNqcK3MWJOgXlhKGf5HBAk3uzdSJ+Oq8AQ7fQFDC10S?= =?us-ascii?Q?92PfV3WTTcdC9tDPjXr2FRCOR1Sjw/CRkp1MWAkhFYlqfzMkiES2MDOWuIXI?= =?us-ascii?Q?hpzBzR4ntLQuqao3BXq2rap8WFZj/3nObBpN9zjoN3XB7SxzdcGE+UtHupNI?= =?us-ascii?Q?WZW2JIufz1EH0ZCEjUEo+doREyJKCr0BvGi1lJRgrHI4a2vRBPC1mLTCvycw?= =?us-ascii?Q?y6jET8/9fdKIzCgTeAnz8DAbPFwPVfu0RXdu9qpqYmZopM2P8tOjTbRg86uY?= =?us-ascii?Q?Dkfq2I5WGUB2LtAa59Pn4BQj3fWqmkJnozAPvH8pfa55reL6DJ4Zm5UKDxP5?= =?us-ascii?Q?MIP8lzP+9Te0JHLEitJZAayWxpLfcK1mV7ipyi2e6A18yzaMHdSBuc5Ua7VC?= =?us-ascii?Q?riwbSDP/Phza2Ac2IPIeu4kJ+rarNVC2GsYq6DYmRefpJiu91xFhjaPbRmf/?= =?us-ascii?Q?GljYXZXAzbaMGLNE2ddClPlgrE48C3Zd4zCRx/9BNGIbeEYUTIbsExda9TOg?= =?us-ascii?Q?O/pdw7o1HGYDb2IqgzCa8+ZqiXNfWWY87IMEsvFsxv0ou5HlqrufxLCtZm5o?= =?us-ascii?Q?/8og/t+VHyh+4I285pBXsrqYQE4apFfVOj43rSSZvHMJ2RcU9lRTmm/9Zsai?= =?us-ascii?Q?M4C8LS9G10E71eMjf0EQsxe9iB3O8XH/3Mhd4bjpTlNEWty1WU4kl42BOq/m?= =?us-ascii?Q?9bnu6Ot9RM/w0do9cDxOJQbyT1sbLLpRmKqwLGF+BjG5TzNx+s6iq7eAp7Cu?= =?us-ascii?Q?jYt+IZQftiBfZhW17KuLIpyv9wy+teeiSoeqdO21Q+G87JBaO4WL2JbQFOSp?= =?us-ascii?Q?RiqgpfkpZE49OKBIJsw4JfQMrHxr1LjkaEE7ff3q27NKzLE4Esz+Oa6JwPvP?= =?us-ascii?Q?b/RVFHW7kAW3wZMUHxX1yFYZI4I4Lfry8PG+YkkT2YioHduGQNJED3IlThfQ?= =?us-ascii?Q?e8lddlj36QA4h6ODQ6HChEbC9y5cLysFKt535Af2P+3drvK4CcMzYLPRnx26?= =?us-ascii?Q?MKQBrdQCdQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4f5a8f2-1e1b-4f7f-bae0-08da2d1274f1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 14:37:32.3349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vLU+o3ffgOr72sbu9SuKDl1vdm5Qu4WThGhPCPohtO+EVTpjyCxhKLh3/rzuUKnNhBlYDGAqukP2mnt/n0lFsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5377 On 03.05.2022 12:25, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: >> As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, >> similar to flush") there's no need anymore to have a loop here. >> >> Suggested-by: Roger Pau Monn=C3=A9 >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. > I wonder whether we should have a macro to ignore returns from > __must_check attributed functions. Ie: >=20 > #define IGNORE_RETURN(exp) while ( exp ) break; >=20 > As to avoid confusion (and having to reason) whether the usage of > while is correct. I always find it confusing to assert such loop > expressions are correct. I've been considering some form of wrapper macro (not specifically the one you suggest), but I'm of two minds: On one hand I agree it would help readers, but otoh I fear it may make it more attractive to actually override the __must_check (which really ought to be an exception). Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 14:44:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319703.540037 (Exim 4.92) (envelope-from ) id 1nltll-0004Ig-9A; Tue, 03 May 2022 14:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319703.540037; Tue, 03 May 2022 14:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltll-0004IZ-4k; Tue, 03 May 2022 14:44:53 +0000 Received: by outflank-mailman (input) for mailman id 319703; Tue, 03 May 2022 14:44:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltlj-0004IS-5Z for xen-devel@lists.xenproject.org; Tue, 03 May 2022 14:44:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95a9d60b-caef-11ec-a406-831a346695d4; Tue, 03 May 2022 16:44:50 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-Jdbn8wKpNFyWWLoJrc2DLg-1; Tue, 03 May 2022 16:44:48 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB8PR04MB5739.eurprd04.prod.outlook.com (2603:10a6:10:a5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 14:44:47 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 14:44:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95a9d60b-caef-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651589089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUnAwZR1/Fpv+omSr3SxME1OxG/gQTSSN2T8IL2uOwo=; b=ZL0/34g0bA/l5giBpU6rdq1VlHo85CMvpA+9rHJSxvJJd9lU7yMfuEnfImg1G9uhZTyqmL TppSP+gNXbhYXCDKuUmgo0W47CNCbiDldkBzzT3fX7hgo+AJwOY/aFTnjYSW8cQ4U+keeN RwSM5wOjh60fBR0aBi/7abH0dA58m9Q= X-MC-Unique: Jdbn8wKpNFyWWLoJrc2DLg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3W9FB2Gk0qdDEIJ2/eH/gXOVUsxlGZsvZL1WnKoqLfNzFs7B6IRuk0oDekMy/wNwYDarXHAiOcGs7FCDuPnYltAJ00CT6n/zZAuWmvw1iC3JERL2+HkjOjv81ENpdBdrKPrpWIUvI19y4JvWN0Qz3NJNE0eB0RpQPvxNu0/H/naziG1gjfHgGT2Gi38g6k8vh96R8pqME1IRxFu0cZc7wQyiH/0JRnbsjsl1bhcCJFekEw+7wk7rYxSWnLsmCIDH0EQZAInXAG6cFKRyWmQ0BjwkOQJuJ5k63uXsEVYLbk+Srf3ufULqatLnTkYt9yz41JcnTCiuhXYOhvampaLDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XWmtKpqqxSlmL45fiyRgFSSmbCkQN2t/lZ1ysSR9HDk=; b=SvBE0TAkWNO0f7p3kRcK8s7F+cKPolEuiptkDIv7By5oawJhWZZ5STwn6Igs7LV81xL+WrCsADDsZfdcigoEsuczYQxa1TcF+ReuiDfBWuTNPtqRGI+UyUmh4uRvw2eaZa6ZajdnpimqB0irRzF0aLSXzLqg1nZTkvnxqE798rlKo5hywmHbZ1Z8wIglWctuimQYFUgGeUI3PrDWdXq/r5/IcTjzqoZL9c5nCez16Dhpmq0c5R9PIpDtFf6tgHoxIH4f7bWDiWSYOM088+GV86DlzNtWSOSrhsxiCtDiHCVVqjjsB6HH/v/+5YB2CmYGQTaPFyfHav1FGHFdz0ZNIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <03cf64c4-8ca8-3e13-a4d0-e8da9f309b38@suse.com> Date: Tue, 3 May 2022 16:44:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 04/21] IOMMU: have iommu_{,un}map() split requests into largest possible chunks Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <227d0bd1-c448-6024-7b98-220271d9bf63@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P191CA0034.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::47) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18dc14a0-a3a4-4f93-4db0-08da2d137817 X-MS-TrafficTypeDiagnostic: DB8PR04MB5739:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v6sV2tQRcekJHknd5XpEwNvwFVq1+cLa1NPeCu6tKSoMclZOdTxAs3gcMnLK24WdOt8BN2D+6Xj4fuWCLQAJ2NQJ9U6FBlTGHrZtUx2bCpnc06+lCykaPm9rHe6qBjquN9RIjg5M9UD9F8eEEB8fCXakIViG9vpjqfBy9koU+8APwoAGBs2hCbDme0/zSo/tn3BQq6m7cE3EE/4wYkfIpnAhOG5leiR0bI+uauYwPEJDKH/Isz2tT25S26/0/DErYBaB8/nVXWrE3GhYs167X47TGyLEuWUFwUdcqaroqkW0vCfKYKQrJEld1rHq6vwqzKZkO9ZOTVxc+zmj+BKN9GNWVyuY0sngRUPheZqm1N6eJSqkiZWGKZ1Zv3OnXnjxdomYsgMabqM/kBuQHLfvXU2Z2vTQ9Fb7/XKN/i4893Bp6xhrp6dBCs370eoVnGo2etQW+7Vr2i8AHsGE1bmYrMsBCHf+s1EUGtcDMQ9LfR+x3+Aej8Fap6eVn6YY0fHXIYYt7tXZoCR1w3SjujMrpQeljwO8ki5hsb9DbLYXAUWybqxX2yV411ZKhzLlyUaarRko/ral3A8v92U57w6eDIsD4bfAx3a06uJcdGDL01FzZoPaNmw2UR/hl0jr4cJmY4D7+BKSiqX4gPTq2r43x5OYMyRPWEcpuCw0K068c536wY6XzfbSc4/6C9l7g3DjP5VeqiOWL5WSa4LDXrU5KvZyCvDbtPU2rZOTuXSDWB8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(83380400001)(53546011)(316002)(6486002)(54906003)(31696002)(6916009)(6512007)(26005)(6506007)(86362001)(5660300002)(186003)(2616005)(36756003)(8936002)(38100700002)(31686004)(2906002)(8676002)(66556008)(66476007)(66946007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DXKzkzVcMkHp5B35NxZBn9XQWmAl1ubCnTklkzPT3dygWUREo3gakqBHsqBk?= =?us-ascii?Q?rdsFfiF29s+zVncWeVmA3+GsGBliBJFMQKQrFFCi3gi1e6z4mPpT7wjsT8Fw?= =?us-ascii?Q?+gcSa1FXl0k2L6GIHNLCGdcz9YlB4DgYrLNQCTeijQsyTrjGfPUwkVhxdQKv?= =?us-ascii?Q?pTy6VxBly+cvZ7bqkvKrS8MzA27He+6bor+JYb43HBMnBIvljmSfNiVKo7Ne?= =?us-ascii?Q?oG6kHWGhqwkWnTJH1xawctsCBgsthg+SXD1Wy4pFl31VYyUkpOJKILpER3OP?= =?us-ascii?Q?eYg+R8fKMaxcea0ow4dR9PnJkxZghhaTGwJ5GvvGfCmHJQ5CRJiL6X6XVD10?= =?us-ascii?Q?iGB1gGeh3t6ba14Ipuy/25AQgb/KV5B5B/54QVnxIOxrLCA5F/5P9R9xRFe0?= =?us-ascii?Q?aO4HBVD8aGmHYRfwdH2RnOeV+3UPx5KE3fJ+qS5wBRZkbSwE4Ffan6GKr73b?= =?us-ascii?Q?NFaJbR5pK57nUotc3N6ZRlBhfX8Kvl/G6Q6xKQncgMJyJRk2YbeiAN/s+itX?= =?us-ascii?Q?aagV9EUSwZvyjC3APJK0+Ob4VbSJ8fdE4bUkLWGy66zWttYTXBknRHUQa0ey?= =?us-ascii?Q?IulckTAThA+Ab+kZS3UU1OOpJN1aYJ0MtWDo/prwe8rwEs9JNp1goD+sTvZL?= =?us-ascii?Q?Fnx8NePTMHQ3b+TEayfDuWiMLwhVODTYzOok+NWtUE9dDXLe6tdvQjTXMYHV?= =?us-ascii?Q?TMuud7uAFswx+CS50ZPWYAyItOZUCELiYMqoeT/d8R9tME1YF84cIcR9s4We?= =?us-ascii?Q?JJLYwTA0Spt972nyZxOGFmUSwhLzFPVI81KogeiyE3SdlCkIFTJXsT4XYYke?= =?us-ascii?Q?MKevRE2tu/qLkG+8uzADKTQYIq8lEP7p6b5++j/klhga4ZBQdGPSe6I1ymqf?= =?us-ascii?Q?jS+d9bCzi9lNzdr5LQKPTnrD+omVUjZbHnlN8eckm7Dk5vDxDMDnnyH/Mvyx?= =?us-ascii?Q?Aa1WCL8rQtPK33ImeTOsa4QgL7JWe13dBPQu71oh35aUUjPaHO1/5+Lqf27A?= =?us-ascii?Q?+J3fAHPHL1HZ2IYHj863XiOffQDWHsWxhfMNcSgijiGpGnx+RD5NGoHE8jA9?= =?us-ascii?Q?n8PznacfGWXz292GjPcPRjSdUrl1kpfDhAQloQdvTMuBJu2I8b/WHRSPxaRW?= =?us-ascii?Q?LkwK8Ip/7QTfUC/3IlNNkvBIjf2DRNw8TuR6pJ/Ny4c7tBeIdY7jKU2IGuId?= =?us-ascii?Q?GFitiXQL8ANxWaUbY3CwopzzW34a8spakhhC4mICn94Mu8Ia5TvkUlEMyqiG?= =?us-ascii?Q?4j9BqVCk9utWmdateKApVaFsnUkUzqxW5nqJxsvdgHle5B2UPuBPysrlpGTi?= =?us-ascii?Q?j39ihvUCOScJaEC7gObuYKPmujrilYekMXMn/ECUVSzi+GO6UZhym1Y4yUpG?= =?us-ascii?Q?Epvm+Y3BM5JUcA2xFwwnV0BPjWgWXlWtupH7nMkRLcBH/Rz8myFztl4hfMbz?= =?us-ascii?Q?VVf9zdN1lP9vfIC8DA9U+DEBP3sEV/xVZZihJE+fVPkeMBJ1tFhV9K5qAGyP?= =?us-ascii?Q?lysJFiNtxMDOrzqrMW9ohmqIGtRnz0kCbN/sZzSENQ4iQ8DG0lZZSCIdKcg1?= =?us-ascii?Q?jFWUukGUGZQyx9c3TisG+bs+wQYdLPjl5i/gyrk07GR8RZjxH7+NZQOYt06+?= =?us-ascii?Q?2hU0+ndpfynhqQXNoI1VIBpNoXVNiOQqXyJf5gp5Gbszp+hDsbEG2E+CGWyo?= =?us-ascii?Q?whahNKeRWdeWDUCiP8AKY7LzPb4sfIQENfc/g41GCgSM7zGQT0L7QfZLyhm+?= =?us-ascii?Q?33Yo7n/SDQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18dc14a0-a3a4-4f93-4db0-08da2d137817 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 14:44:47.0017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zVfDQboR7bS5LyB3e4KketM4SZTji/ytd5LKL/ng4Y5U1+H+7QFs+k0er3obLqmgNkiZmurapVBSMSj6iuGjwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5739 On 03.05.2022 14:37, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:33:32AM +0200, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/iommu.c >> +++ b/xen/drivers/passthrough/iommu.c >> @@ -307,11 +338,10 @@ int iommu_map(struct domain *d, dfn_t df >> if ( !d->is_shutting_down && printk_ratelimit() ) >> printk(XENLOG_ERR >> "d%d: IOMMU mapping dfn %"PRI_dfn" to mfn %"PRI_mfn"= failed: %d\n", >> - d->domain_id, dfn_x(dfn_add(dfn, i)), >> - mfn_x(mfn_add(mfn, i)), rc); >> + d->domain_id, dfn_x(dfn), mfn_x(mfn), rc); >=20 > Since you are already adjusting the line, I wouldn't mind if you also > switched to use %pd at once (and in the same adjustment done to > iommu_unmap). I did consider doing so, but decided against since this would lead to also touching the format string (which right now is unaltered). >> =20 >> /* while statement to satisfy __must_check */ >> - while ( iommu_unmap(d, dfn, i, flush_flags) ) >> + while ( iommu_unmap(d, dfn0, i, flush_flags) ) >=20 > To match previous behavior you likely need to use i + (1UL << order), > so pages covered by the map_page call above are also taken care in the > unmap request? I'm afraid I don't follow: Prior behavior was to unmap only what was mapped on earlier iterations. This continues to be that way. > With that fixed: >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks, but I'll wait with applying this. Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 14:50:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319709.540048 (Exim 4.92) (envelope-from ) id 1nltqo-0005xF-S2; Tue, 03 May 2022 14:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319709.540048; Tue, 03 May 2022 14:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltqo-0005x8-Ou; Tue, 03 May 2022 14:50:06 +0000 Received: by outflank-mailman (input) for mailman id 319709; Tue, 03 May 2022 14:50:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltqn-0005pg-DS for xen-devel@lists.xenproject.org; Tue, 03 May 2022 14:50:05 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f33b934-caf0-11ec-a406-831a346695d4; Tue, 03 May 2022 16:50:03 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 10:49:59 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3650.namprd03.prod.outlook.com (2603:10b6:406:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May 2022 14:49:55 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 14:49:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f33b934-caf0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651589402; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=MdRjRfP0KbSVC/+93yyY/E205B7eXRM3nAOufUtELEw=; b=Cqh4EyD/lC8+98euMDRlNk9pCzcRwCoUdeFx3CYJXUfsOOhzE/YUWyC1 2mig2miw6glyuIjDFViMvbhp+1Z6qKMLU0PEEEl8woCBvYIFrGwAhQgCP RklqVLXua/oA/SfbYyAayrvfnZWYzbDt52npAzTGiKGwguElU/aPEg/6I g=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 70351257 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:98tbEK1t8bQcoF7HS/bD5alwkn2cJEfYwER7XKvMYLTBsI5bpzUFy TAbDzjQO/zcYGT3fNolb4Wwo01U6J/Uz4RnTAVspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Ald+LdT8TEJfut+YfAgNGN30uZPV/reqvzXiX6aR/zmXgWl61mbBEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfyVvre03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianKGAB8g/KzUYxy1aUkypq8Yb9CdnQINuvb9dIw3S6p m2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM/JPF8Uq5QfLzbDbizt1HUABRz9FLdYg5Mk/QGVw0 kfTxoyyQztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:aw4CGa/Bdl2z9KOHfIJuk+FEdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe yhz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlCl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFc1ccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiU7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri6knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdo99RrBmc4a+d RVfYDhDK48SyLbU5mZhBgk/DWUZAV9Iv/cKXJy+fB80FBt7QJEJgUjtY4id0w7hewAoql/lp v525tT5cBzp+8tHNZA7bQ6MLyK4lKke2O9DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK j8 X-IronPort-AV: E=Sophos;i="5.91,195,1647316800"; d="scan'208";a="70351257" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsrNu3/8iybUgRYmC8qnCzz3CCZKax1J+Z8aeP4mDGKp41A4YQ0LEF4nMpai7GnkXzzGoNbI6J4SNzORDePH4duWM3AIfIyI+WlP5bbsI6DicXRvuBBYwE0j/GtcltONfVVPcfMB4Il0TsGy+L4uJ/hM8yR5N/aV3kqEgNEJ3mABU98AUpULTuvdKIsuGPhfYFNktkStOnnaYCOqOQbKNT54DvMulgBJl3VTTm11tO8i27jSFuml9J40eKdCb6WMh9lLAVbQprggu6AtkQ6WFQKQCkH3kY4+p4zu4ZY1UwQaMJ/MkzdDS4Lj9EVWkcEIu1C2Zb0EMperpoVAs4zImA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yyFIvEtYwDFKe2vs2Og2sJf3T0l4JaHHBJ1hwLGjVkE=; b=Vq1DFSsRi45F5MoIdhnY2dRFCDfnYv7JnoaKkem6Q+xrH8grrwzlRzSCZiKrqrfDiW1Q8e4OvjOVsASgZhUPbkbLsMMScLspSVOvzzMcWYSkZTazhol0Npdkyhy1pVJCuk1yp81RCtFFFYDVaiZDzCS0+1RtmxpyAE/uQnAgXpEo/L+fiGxAmdQzHA41/0Bp3hktRPET8mPZ2XU3IQnfN3uL7Is2roMwmNdiGTt6i0NxM6eZKhHEYse3PNtLJNDknQGMSAv8GVQ0FgNdcL4gOZ3c/hxMX4/TXQYsNlX773z6Ga2Twyy614avWVJutexsVYpGC0pPpxaMg2Kr7+X68g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yyFIvEtYwDFKe2vs2Og2sJf3T0l4JaHHBJ1hwLGjVkE=; b=vwPk5k+z/ACHg5x2Ap4bRUastYR8KdCMFu7Ubgsh+neQkB6LILF6rkQZ27HbmgP7rWIE6Z42t5ueK22w14IapAHD/DDK+SJg83I31VVM5VnbaMcP/zFEiLQAaxd6Ow4qMFBWN4j3pVqVt/KFN+w1nXCixf2FlPfp8xmaWK+Crf8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 16:49:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0500.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e774bd3-622c-4e33-bab6-08da2d142fa0 X-MS-TrafficTypeDiagnostic: BN7PR03MB3650:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A54kzlNxp9aNGgcYq6RjUrNcQki4oFF+Ht8NJfGTHgYzJy3gxL1gKUzChIj53n9W4AHTPb3OD54HjhFzKVA6O9Ypd7E+YhxrQI/N8/dkRV8KZ+7vrB70oMDzBIWb/U3AkG4pU4daO7WjH4kvo7Uy+LMM8WgWM6acrdZexsKYQNKeXzjTRkHwsqGtFLjCVbnndkgRx6rDt/OK1MsQaEr+265yH2pLB6DSGO7QVpR1jeqWrHX81pOWznw7DbIY3wTvRKgTW8npkAhV79y9sk6j6j50kBIH9gxHp3l0xcmrAp/gyYWtanG9w6XlcvsZs8IrQOCLcU4aRtrtVPgeBigXRmqupAhi7vPk9Hl8slHbsfWmWvY803gFLSudMPuGu2t6biOJ/9lnmIPxcRIfhpcJCRw8YmdT+zo9mjwk4gzMs8uNti9UEZDHIEZSAkThOHpQTH9pVbXb4OQnoMB+mNQBDAWoKKkB2DA7rTpF74PDLHUWXDty9yQKVdEYxHF6DexS+mPt/gw2XT4avGHDqxYX+nxRZhEKxmMN+9l+O45UtZu7erzeWSuPhXF+PzLTZ6pOYvM6u3Qm+J1AscmhqcxmjdakALPLSgSZoyuFrsKFouVB0xxMl1dH4JAoT6KJeQubeib+4ddiLtb+B3gwbeu1wNzTxfhaB9QatIIbr0+GsWDbbs+uawfMfRT1V+XFZfZyAxNQ6kSdat85aD5rutXP8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(4326008)(6506007)(26005)(6486002)(508600001)(85182001)(186003)(2906002)(83380400001)(6666004)(8676002)(86362001)(6916009)(54906003)(5660300002)(66556008)(33716001)(66476007)(6512007)(9686003)(66946007)(38100700002)(316002)(8936002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkRNRksvOWxTem5na2pvbW42WnJWamZIMGdYNXFQZldIZXJwMEhlakdkbFdx?= =?utf-8?B?SGV5Tk9jcDdkeDM2RTArUWZpZGs5bnZKTmJCc0M0ODdzaGhwSWpGM2tMcXl4?= =?utf-8?B?VWtrYm5ESmNrZ01Hek83QUdQaFArVTZqYkpGWWpmMlRqQXR6UHk1aEsvMStz?= =?utf-8?B?T3dlTWc2SHVRWU1kcmRVSmRIbGpGTUpIZHFpSjZ3aitEeW93OWxpbjRwT2I1?= =?utf-8?B?UFIxaUoyVThjUS9UbEhYOUYybnNldzBjVU5OdnN2cUtEZUhRQjFsTlduK2hl?= =?utf-8?B?amtMZmhQOGNVSUYxczIwTXBGUDhXc1k3Rlp4WFpEYXJTekxGdVZuMFE4SWJZ?= =?utf-8?B?OHRsY05uL1lHb1hNemJnWVUxU2l5M21oRzl0ZVA0NFNhd0lvcFJLYU1aaGhK?= =?utf-8?B?cEw5VFo3ekRDUFVaaFE2QXhtR1ZpSmRJQlZQSExobGF6NER2RjVhU3gwT09Z?= =?utf-8?B?ZnBuajYwWnEzeHZvNGpkQ2YyaFpSTGR5ZXJHZFE0dEdXc2poYWZHMFdCcjdw?= =?utf-8?B?dzVxbHlzRExNNS9ZcXd6WGs2TlZiQ0IyaXU1d295MWdhV0hFMEtZOXN1UnRY?= =?utf-8?B?bXg4Tk5uVndPbW9DZDlUT3RrQWlnU2hrSWxpUlRLMWxYN1c5L01ZRDdlSnNK?= =?utf-8?B?YVVIdXNxeWlEQW9DQVJqUWJpSGJHWVpCU0RFYUg2bDZ5U1NNWU5oRmlxQjRa?= =?utf-8?B?WDZQVmh3OUZRY3l5c1dKZVcrQlp3ZTBLclROK2RiZWJnd21NMHp3aWNWd1pS?= =?utf-8?B?NkJ4WUwxOU85b0ZTRVF2YjZ1TW13d3laNHRzdFd6THU2WjlGSTE0VnIrdmYv?= =?utf-8?B?ZmhBTXUrcS9ha1VXRm1zbEZ1WGsrcnc5eHFmNHhVdWdIYUFFUFQ0d3ZtcW9W?= =?utf-8?B?WU9CVW9qdm54V0JzTEFVdFZ3VHZkVnFmMUdGMTZLVUxxVkF3eEYwUENzQzR0?= =?utf-8?B?aE5vNHVKclJwWVhvZTRjOXpleTNnTDhPQ0RyWGJSRUJuYjNLWHgrT3JtY2Fv?= =?utf-8?B?R1hkOEY1cVkwOTF4VWlpbXBPKzh0cDlCT25pRjVsWWdyd2lGcVF6TTdWQW41?= =?utf-8?B?eXVaOFAyRFE5V25ISHNpc3AxUjRuWGp3VThkQUxlc3pqWFpiTzdzOXFKQ0J2?= =?utf-8?B?RW5wODE2R0J2YmhsZXUxVnlNMk1yWW5XNHlRR0JTNE40bHdhZnFUN3NsZkIw?= =?utf-8?B?ZlpFaG1oVW9iTGNldldqSU03N2FoS2JrbEdZdmNhVzg1TEhpYVBtWWo2dEQ2?= =?utf-8?B?S3NjamYxelBuNHhaTjZERUFjOGhUQWM0ZXphVUx5dEk4SDNUTlB0T0FMUDBy?= =?utf-8?B?R3VxRllYMmFsSjFBQmR4eGNEeXh4SjFtUGdaSWhJV2FYRitrcmFydGRkK0dp?= =?utf-8?B?QmZRQkVoMElRMW9SMERoRHJzNlJLWTlNTzFmM1VaQnNhZ0JWd3JiY1ZPbkI2?= =?utf-8?B?b1BIeGdyNHBxSWtpSW5pZURxN1ZkTE5sL3J3Z3BHdE5OR3ZMdk00cXdZYlZC?= =?utf-8?B?bFAzZkdiVmdmc3UxTXhqcE44b2pyWHBFVXFwNGZrNW12UEVLZ3BqME1wQTAr?= =?utf-8?B?L0JMbUJBNldEZjRTVnJ2WDMrRjI1aFRrejFtbWhjM2EySnB3a0VScVREWXlu?= =?utf-8?B?V3lWZGN4VDRWYmdGWmcyT2xRSVMwSzE0bktCQ3M5b0NLalVXSGNDRmVBYjlH?= =?utf-8?B?K0NHOEpIR093enYzZktBaE5XM3IzeUNMa2t2c3hBTnRpREhxT3FIN2FHdDB0?= =?utf-8?B?bVNtMmZWWGo5TFpseU9GTVVYRnpWRzlUM1hJYmFvZExHTCtoMk1GS3dyUTRG?= =?utf-8?B?QlozOUJ6NmttN2U4L1U2VE12cUVkcjNUR2R2VGZSeGVMWVlsNkhoeFVWS3po?= =?utf-8?B?SmhHVEhvdjJsS3p5bTZXSVM5NTJkR2VqaHZxZVd6WXhwb3lWMEVlM3pYWU9R?= =?utf-8?B?N2VMYjZXK3piaTMzcEcvOU10S0N0Mi81NTB4TVBsUUF1V2tSOWFBdDdBaDVK?= =?utf-8?B?VzNReGUwNFBkZWJyaVl6clh6Q2xhbzV2bmxsbjhGdkZ1Mi9YMzdiWGxDaW1S?= =?utf-8?B?cmt1bWl5UDFGNmM5bC9ET0pzS2VUQXBmWWVnd2JDclBmbjFwN1pCNENYbW8z?= =?utf-8?B?dmhOdkhBakdWeitvdTlLUzZyMGJ2ckM0UnIzS0t0SzBKS3hUV3JwYU1aZTR2?= =?utf-8?B?ci9FL3dwNFNkSzVmclRDOVN5QjNzZnQ0TVozN3R0dHlUWWZvL1ByRXh1NWtp?= =?utf-8?B?TzRDVjgxWHRMcHB5Rk5oMWtJSDFoMEs3T09mUXRyck5PQWtVdU9DL3hkYnlJ?= =?utf-8?B?U2lHbEI2dGZocE5yVVZ2K28zL2pJZitpdE9kVHdxU04wR0orQzBKdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e774bd3-622c-4e33-bab6-08da2d142fa0 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 14:49:54.9723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gyfw8QuywZ/4Lssd8lxeqQS4r0oQ3KMyVkNvy5J0Rcq7OlllX7/qzR9e8KhOsS1/c0v3nvFjLbrKiKJJkPFVEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3650 On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: > For large page mappings to be easily usable (i.e. in particular without > un-shattering of smaller page mappings) and for mapping operations to > then also be more efficient, pass batches of Dom0 memory to iommu_map(). > In dom0_construct_pv() and its helpers (covering strict mode) this > additionally requires establishing the type of those pages (albeit with > zero type references). I think it's possible I've already asked this. Would it make sense to add the IOMMU mappings in alloc_domheap_pages(), maybe by passing a specific flag? It would seem to me that doing it that way would also allow the mappings to get established in blocks for domUs. And be less error prone in having to match memory allocation with iommu_memory_setup() calls in order for the pages to be added to the IOMMU page tables. > The earlier establishing of PGT_writable_page | PGT_validated requires > the existing places where this gets done (through get_page_and_type()) > to be updated: For pages which actually have a mapping, the type > refcount needs to be 1. > > There is actually a related bug that gets fixed here as a side effect: > Typically the last L1 table would get marked as such only after > get_page_and_type(..., PGT_writable_page). While this is fine as far as > refcounting goes, the page did remain mapped in the IOMMU in this case > (when "iommu=dom0-strict"). > > Signed-off-by: Jan Beulich > --- > Subsequently p2m_add_identity_entry() may want to also gain an order > parameter, for arch_iommu_hwdom_init() to use. While this only affects > non-RAM regions, systems typically have 2-16Mb of reserved space > immediately below 4Gb, which hence could be mapped more efficiently. Indeed. > The installing of zero-ref writable types has in fact shown (observed > while putting together the change) that despite the intention by the > XSA-288 changes (affecting DomU-s only) for Dom0 a number of > sufficiently ordinary pages (at the very least initrd and P2M ones as > well as pages that are part of the initial allocation but not part of > the initial mapping) still have been starting out as PGT_none, meaning > that they would have gained IOMMU mappings only the first time these > pages would get mapped writably. Consequently an open question is > whether iommu_memory_setup() should set the pages to PGT_writable_page > independent of need_iommu_pt_sync(). I think I'm confused, doesn't the setting of PGT_writable_page happen as a result of need_iommu_pt_sync() and having those pages added to the IOMMU page tables? (so they can be properly tracked and IOMMU mappings are removed if thte page is also removed) If the pages are not added here (because dom0 is not running in strict mode) then setting PGT_writable_page is not required? > I didn't think I need to address the bug mentioned in the description in > a separate (prereq) patch, but if others disagree I could certainly > break out that part (needing to first use iommu_legacy_unmap() then). > > Note that 4k P2M pages don't get (pre-)mapped in setup_pv_physmap(): > They'll end up mapped via the later get_page_and_type(). > > As to the way these refs get installed: I've chosen to avoid the more > expensive {get,put}_page_and_type(), favoring to put in place the > intended type directly. I guess I could be convinced to avoid this > bypassing of the actual logic; I merely think it's unnecessarily > expensive. In a different piece of code I would have asked to avoid open-coding the type changes. But there are already open-coded type changes in dom0_construct_pv(), so adding those doesn't make the current status worse. > Note also that strictly speaking the iommu_iotlb_flush_all() here (as > well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be > needed: Actual hooking up (AMD) or enabling of translation (VT-d) > occurs only afterwards anyway, so nothing can have made it into TLBs > just yet. Hm, indeed. I think the one in arch_iommu_hwdom_init can surely go away, as we must strictly do the hwdom init before enabling the iommu itself. The one in dom0 build I'm less convinced, just to be on the safe side if we ever change the order of IOMMU init and memory setup. I would expect flushing an empty TLB to not be very expensive? > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i > > void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > { > - unsigned long i, top, max_pfn; > - unsigned int flush_flags = 0; > + unsigned long i, top, max_pfn, start, count; > + unsigned int flush_flags = 0, start_perms = 0; > > BUG_ON(!is_hardware_domain(d)); > > @@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init( > * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid > * setting up potentially conflicting mappings here. > */ > - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > > - for ( ; i < top; i++ ) > + for ( i = start, count = 0; i < top; ) > { > unsigned long pfn = pdx_to_pfn(i); > unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); > @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( > if ( !perms ) > rc = 0; > else if ( paging_mode_translate(d) ) > + { > rc = p2m_add_identity_entry(d, pfn, > perms & IOMMUF_writable ? p2m_access_rw > : p2m_access_r, > 0); > + if ( rc ) > + printk(XENLOG_WARNING > + "%pd: identity mapping of %lx failed: %d\n", > + d, pfn, rc); > + } > + else if ( pfn != start + count || perms != start_perms ) > + { > + commit: > + rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms, > + &flush_flags); > + if ( rc ) > + printk(XENLOG_WARNING > + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n", > + d, pfn, pfn + count, rc); > + SWAP(start, pfn); > + start_perms = perms; > + count = 1; > + } > else > - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, > - perms, &flush_flags); > + { > + ++count; > + rc = 0; Seeing as we want to process this in blocks now, I wonder whether it would make sense to take a different approach, and use a rangeset to track which regions need to be mapped. What gets added would be based on the host e820 plus the options iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes based on the logic in hwdom_iommu_map() and finally we could iterate over the regions afterwards using rangeset_consume_ranges(). Not that you strictly need to do it here, just think the end result would be clearer. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 14:50:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 14:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319714.540060 (Exim 4.92) (envelope-from ) id 1nltrZ-0006ZG-Az; Tue, 03 May 2022 14:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319714.540060; Tue, 03 May 2022 14:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltrZ-0006Z4-5i; Tue, 03 May 2022 14:50:53 +0000 Received: by outflank-mailman (input) for mailman id 319714; Tue, 03 May 2022 14:50:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nltrX-0005pg-NS for xen-devel@lists.xenproject.org; Tue, 03 May 2022 14:50:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c8ad055-caf0-11ec-a406-831a346695d4; Tue, 03 May 2022 16:50:50 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-yFakTHKzPAWYuFRyQP-3DQ-1; Tue, 03 May 2022 16:50:49 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB7122.eurprd04.prod.outlook.com (2603:10a6:208:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 14:50:49 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 14:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c8ad055-caf0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651589450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ezJo7YDgknkq7vhqbpS9obSKpnX7KAvezgl9XgxGlHU=; b=H23haPd5wAGNO6ylLEv7hAEe6Prxkn1x0F+E8f3ycw2R0CepZfQCcRsg7iJHT/99kfCVTA dKuTAKmfdI/QTE/aamQBJQHYP+WrKefnaBHPciqeQV3YKcrTKAaM0KiF6RZTJ1ErjseGYE RVHXrwd5imuftQZz4/mroIm3ki6xiHY= X-MC-Unique: yFakTHKzPAWYuFRyQP-3DQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=leNfv2hcFwoa3eebkiecZA3JSqe0zlQYuP4BV0TQJ8eDStlbnTyCU5SnkZwnpuxCIZDchYYVPZetS6YrR+d47O6qZLI+ieq0jygQjN97XPPW7QYdqzaqXXaP5+rpv/SHdEMP9cNHoVpp+qmG6qnSOI8TzA+P8aeVFX5+rNunxBaSPx5gP7oDaHUe99pbAzdsG1SDXcJzaHBp434NE9cADmE1dVo/sk2VzeT2vV06rmU9FzW8sPMq6Lh9vKXK1DEAgKJ+5OKejjJhd6hM7bwlSNDQt639+oGIYFxM0VAIZtyKBpUuewARti1McHdG0EIdScIlw1Y0XoJHcijPolvofg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWGdVFOWyKkjmpReZGRkKTWPXr9heReK4U68dZjHxO8=; b=JnDboInax8O1WwjqjFA2Xx7JsZwEkH1d8dbVv7St6nOn3PTSggX48yMXx3mMIXMSbv1CawRxNNrtpnGxrSZZu3FIcmXksOcso47CGM4OOmo+Zy4z0omcxiqxginq3zmZmU+8SJuDbrqMylUWFf8u6023zVqsN9chXi5Edgu62r+TCfNam3FFNHezxI/4rSzUoW6VAZmc+n6e7sUd7al2GKyg0Kyl69XE/O89MvN1j4AuB8PDcZa688OiVBr9yQpyFv6rz3zqaBnpOVwStPVQ4JnMhfNLcC01Pgp5qkduDWyFgVQfV8pfG5tr+lUIrEl+4aUhCR5zJtKKmKbl71sThg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> Date: Tue, 3 May 2022 16:50:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::13) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3adf452e-60e0-49d1-cd0d-08da2d144fb5 X-MS-TrafficTypeDiagnostic: AM0PR04MB7122:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L5fGZx1v2HDYzqge9HsOEk0P7vbQu+yt5btCT/hXU/H+BHX1MKZxBQ9b7TH9CVaOEajzkbEBu27RkWb7HMmbt1R8E2m6JXFGlvYUvfocVBW+c5msmSG253WihCSKU7xS9TVNEC00D9z6eQ/h9pI95TrPjnubwIiCY/j5TmkJItrKPBoe2TMcrWgkO2IeAss8HSVPZgC+3RdhB3r0iouvb+ic37IiM9ZERCQJdvSL42v65Mv7E2oyrNhvO5ycqUSuIehJu7hfctueckZJJkUZ8YSR/mlZfOHyZdYKd7VupKLksD3nbfvMGN4QwlwPvILzNjrV/i4W0zxCOYqCUv0S8xiZRXQu2pn/UAAq7AoxOz7kxzdVD6k6YZ3PSo6NXgGWmF+UlOIGQ6Th1jodaF2jetHcBtCGLwJngeUe2+liK1Lv580XfTESKZiLoMetbHzyjtUP31pMZM4vaij/Va8FO0hQdzb8yShUN4KIf80CqbtodoogS6Z8McoQfIqq8ZAujov+NwQJ5WVCA0N2LtQ/fZ78obCZBoeNZT7waoROzOCwnJJf6aQELfnK1mlnyR6wg6+42npaHfexVIUnt7PO9NWC58cOHM8UpOuCSD18S1NBoQvQXyAW/awl6itrFpUcU3F7htmEURVrJc5WbG1NOBLSxjKvLLiNwYUsX2+8L3YnjIBgshQ9vcjPX6Ba1fAVLjFmC9A1hVtkm9drLNeg/x/W9uaIasqNpJ9KO1MrDlJX42lrxLhVu6bRjwOvpLks X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(6486002)(54906003)(4326008)(508600001)(186003)(6916009)(2616005)(86362001)(31696002)(66556008)(66476007)(66946007)(5660300002)(8676002)(38100700002)(316002)(26005)(31686004)(2906002)(6506007)(83380400001)(6512007)(53546011)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1yHtJokUi/V7OnTp17zyOCPLDF9hhoXuHHdU949W9qZUCyrYuStUL+HbpkHs?= =?us-ascii?Q?cOKUXvejKInZps68w1gt0Tq5jV/IoV+STaua+C1vQpy8Muh3CbJa0dyJL5bm?= =?us-ascii?Q?Of4Qv7RbCrxyCkJsPhrgBjSj0u1TusvRl3HTddoiXWW+JhbjG7synW1HoKve?= =?us-ascii?Q?dwL9QGwXsdcOnTAgn4EKf4v61ot7EdIZu8yfhwY78t2XP1SJBOjnkKUQemsV?= =?us-ascii?Q?TIxVnpDTdQI/rK50zWqCvUhINs3XYM5kwb3VBtVPdRCTyUhD8r2teRXO0xU7?= =?us-ascii?Q?99+W29pXB69BRXyum0IE11iy8yO/pqqmrhsbwdbVWrLNL3otTokkyZffELvE?= =?us-ascii?Q?SZlJsl3G2Y1c43xJPZGM2WXpUMNOOTndnXpdKDxL6+qS0WJJ/NJwUeNzRzb2?= =?us-ascii?Q?xLumTCuJpo2EnfbFm8kfeWQi2HNjQUJb8tdSOvVwF9lJsUkx0sFN8IO/1ILr?= =?us-ascii?Q?ly6oFhW/FyA4U364wTwS/L7a5rMivBsmGQOPoqJHO1oq/AlH9wViyZHpLxME?= =?us-ascii?Q?6IZEk1OvpouqBP48cSkx9V+KgGeTFSPsosVsTI3nlFwn4jIbWAeCD+e8BS6S?= =?us-ascii?Q?dfiemwduKOLMuTqt1nmUre72pOGQLyIQy961U27XsomlyUn/x5fdTWInvsCt?= =?us-ascii?Q?6BxpqaIQdBE0PJreVlmQ0Y3JXQM9p1UYgG3E8WneHY6IOcue8Jd16z2PX1OF?= =?us-ascii?Q?44O1mGzPJcmJOkng9ZWBZSgsIuwAf6rEqjYO/f3nOwloEaha8JuttLHLCYjv?= =?us-ascii?Q?Sk0J19Z/+pLrmA0P309ZM7jkvanz67kEDupEjdrAUe0XZJ0LrCKy9NpqoPcy?= =?us-ascii?Q?D6mO1+pPYFJNpDoSQmZatvNRGc3aDf3AqHFXIsYDIRU2i1uMnf5eRGFDxXfV?= =?us-ascii?Q?6r4h1+vPP5RR8BNzcDkpSUtnXaVcanPBefFcYTG6iyW9XdsBufUsBbLnrs8L?= =?us-ascii?Q?tOb1siubC/Wu/IA9JC7AWBgOmyFxZCMNNpMm9X3KQSbupcE85+Zq4KiBwV3T?= =?us-ascii?Q?pJ2e0IqM9+jE9Zl3QEpBfBM2iWsScYATEsdLVAUJWHBYOBrOgLZIN2rr6XBz?= =?us-ascii?Q?nNnRpBqHLm04X0zSNj7Awi/lPIVwaLbPO8tqzuEmsLUYWqO6ft9mnDuZpzCk?= =?us-ascii?Q?LnR2YEcDDGiZnxYGYvP0Q91Uubz5PkOTxf9rVRGqjy0Ae4ajWOUqwoHwPPpd?= =?us-ascii?Q?O621iAtTh9IV83bo6X9c0uhmi4cC4hffaAMWempVBw+Rf4Wor9sKfWQSEuVZ?= =?us-ascii?Q?X9O1VlF3+m82/5IpZHB7sxkU1VRIRU46iiayADYI+u96pMJ0OhUPzyXHt9yl?= =?us-ascii?Q?WJocxBoYN+wEOeprr+ZdklV61ZDVUTM7/z02ttjEQNcFHN/prug60wcZp6D8?= =?us-ascii?Q?5DKkjEdXNGwFXsRdWg7riz+gBkMjflMcepuydUgEbnZFSM+6dTWPit6eY3wQ?= =?us-ascii?Q?AYoBV30waLbPblQDz6SIjmKkljk0DYXtmDHf3OeKw4PjJc9nRAbCEGM9f0Fg?= =?us-ascii?Q?3k6WwAUTxij85Qx0DzrSWkQ+skSST0n+34MU6D6QdKmvpqLM3rUm0yp7Bxvc?= =?us-ascii?Q?gGSiH7CnarPX2MzzyxzU35EUE/0+DA5iMnAjcgj5M2cRNYrQJC9aOE92B2x4?= =?us-ascii?Q?YIWUMh/rqs4RdTzeVoBiRqnWykYRGyzEUgVcBTnTe6YynHAvvPjidPXOSyG1?= =?us-ascii?Q?9Q2xZi0HC5BWz1uRlQNs+vrIiqLAvkeeh0yiwj+rmw8mWDQIDKL0A7k+JY2Z?= =?us-ascii?Q?bjdshEcluQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3adf452e-60e0-49d1-cd0d-08da2d144fb5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 14:50:48.7350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GFDFCfyXS+Lgxg2jBwvCcLhB8egAOY5kAAMtH+YKDqMDQqw6pooF8Wn7cFP7UObcNu4PGZjN4C1mU4hQUvgL7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7122 On 03.05.2022 15:00, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: >> While already the case for PVH, there's no reason to treat PV >> differently here, though of course the addresses get taken from another >> source in this case. Except that, to match CPU side mappings, by default >> we permit r/o ones. This then also means we now deal consistently with >> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >> >> Signed-off-by: Jan Beulich >> --- >> [integrated] v1: Integrate into series. >> [standalone] v2: Keep IOMMU mappings in sync with CPU ones. >> >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct >> } >> } >> =20 >> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, >> - unsigned long pfn, >> - unsigned long max_pfn) >> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d= , >> + unsigned long pfn, >> + unsigned long max_pfn) >> { >> mfn_t mfn =3D _mfn(pfn); >> - unsigned int i, type; >> + unsigned int i, type, perms =3D IOMMUF_readable | IOMMUF_writable; >> =20 >> /* >> * Set up 1:1 mapping for dom0. Default to include only conventiona= l RAM >> @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map >> * that fall in unusable ranges for PV Dom0. >> */ >> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) >> - return false; >> + return 0; >> =20 >> switch ( type =3D page_get_ram_type(mfn) ) >> { >> case RAM_TYPE_UNUSABLE: >> - return false; >> + return 0; >> =20 >> case RAM_TYPE_CONVENTIONAL: >> if ( iommu_hwdom_strict ) >> - return false; >> + return 0; >> break; >> =20 >> default: >> if ( type & RAM_TYPE_RESERVED ) >> { >> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) >> - return false; >> + perms =3D 0; >> } >> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > m= ax_pfn ) >> - return false; >> + else if ( is_hvm_domain(d) ) >> + return 0; >> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) >> + perms =3D 0; >> } >> =20 >> /* Check that it doesn't overlap with the Interrupt Address Range. = */ >> if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff ) >> - return false; >> + return 0; >> /* ... or the IO-APIC */ >> - for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) >> - if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address) ) >> - return false; >> + if ( has_vioapic(d) ) >> + { >> + for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ ) >> + if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address= ) ) >> + return 0; >> + } >> + else if ( is_pv_domain(d) ) >> + { >> + /* >> + * Be consistent with CPU mappings: Dom0 is permitted to establ= ish r/o >> + * ones there, so it should also have such established for IOMM= Us. >> + */ >> + for ( i =3D 0; i < nr_ioapics; i++ ) >> + if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) >> + return rangeset_contains_singleton(mmio_ro_ranges, pfn) >> + ? IOMMUF_readable : 0; >=20 > If we really are after consistency with CPU side mappings, we should > likely take the whole contents of mmio_ro_ranges and d->iomem_caps > into account, not just the pages belonging to the IO-APIC? >=20 > There could also be HPET pages mapped as RO for PV. Hmm. This would be a yet bigger functional change, but indeed would further improve consistency. But shouldn't we then also establish r/w mappings for stuff in ->iomem_caps but not in mmio_ro_ranges? This would feel like going too far ... Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 15:28:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:28:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319723.540070 (Exim 4.92) (envelope-from ) id 1nluRT-0002dx-5t; Tue, 03 May 2022 15:27:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319723.540070; Tue, 03 May 2022 15:27:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRT-0002dq-2o; Tue, 03 May 2022 15:27:59 +0000 Received: by outflank-mailman (input) for mailman id 319723; Tue, 03 May 2022 15:27:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRR-0002de-Rh; Tue, 03 May 2022 15:27:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRR-0005j2-KB; Tue, 03 May 2022 15:27:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRR-00058l-8J; Tue, 03 May 2022 15:27:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nluRR-0004P4-7r; Tue, 03 May 2022 15:27:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j15q2opJOFUt1K8EnyEGYQ/ZlJyhWrLC0RgFQR8Kq8A=; b=XYzmelv+k7O+7N+264t0PzFKue o3VjeNAZNvJt+WpaJNzXH1aXqoU+O8UN8vCghH3+BD43Bf5Z9Kn9nR7KF7EmtcFDTw9lDsQm5Fvet vXM59CQ2jIH075pkAkUMT6akdXvwKGEF7l5bsIKYZ+eh3Zppwt2i4XllCB0aM+mgOUxI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170049: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 15:27:57 +0000 flight 170049 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 782 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 15:28:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:28:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319727.540080 (Exim 4.92) (envelope-from ) id 1nluRs-00035W-Ed; Tue, 03 May 2022 15:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319727.540080; Tue, 03 May 2022 15:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRs-00035P-Bb; Tue, 03 May 2022 15:28:24 +0000 Received: by outflank-mailman (input) for mailman id 319727; Tue, 03 May 2022 15:28:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRq-00031C-EY for xen-devel@lists.xenproject.org; Tue, 03 May 2022 15:28:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluRq-0005kL-3i; Tue, 03 May 2022 15:28:22 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nluRp-00087q-UE; Tue, 03 May 2022 15:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+5TDtsr3usX74j/+t36ZEF0usP4W/TKLWvT5jR6Z8BM=; b=Z4YSrxB5dckiyPSM2+n9UZadVX vWNuUDQc1eHYNgrZzR7yTQvca+wWZjpMitA6iJOt+t3brRFj1Kt1MF5XJP6s6ok6Rmxxn/FeZGKL3 nDXD7oE+t6PyCUKWNo64eVu+r/ziMjnTIcWU+Lrj5BlrdpjwKE0U1R9uyoYjV9Skc22w=; Message-ID: Date: Tue, 3 May 2022 16:28:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to dom0 To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <780400E5-C22A-471E-BB19-C2F3B24112F1@arm.com> From: Julien Grall In-Reply-To: <780400E5-C22A-471E-BB19-C2F3B24112F1@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/04/2022 19:18, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 27 Apr 2022, at 7:26 pm, Julien Grall wrote: >> >> Hi Rahul, >> >> On 27/04/2022 17:12, Rahul Singh wrote: >>> Xen should control the SMMUv3 devices therefore, don't expose the >>> SMMUv3 devices to dom0. Deny iomem access to SMMUv3 address space for >>> dom0 and also make ACPI IORT SMMUv3 node type to 0xff. >> >> Looking at the IORT spec (ARM DEN 0049E), 255 (0xff) is marked as reserved. So I don't think we can "allocate" 0xff to mean invalid without updating the spec. Did you engage with whoever own the spec? > > Yes I agree with you 0xff is reserved for future use. I didn’t find any other value to make node invalid. > Linux kernel is mostly using the node->type to process the SMMUv3 or other IORT node so I thought this is the only possible solution to hide SMMUv3 for dom0 > If you have any other suggestion to hide the SMMUv3 node I am okay to use that. The other solution is to remove completely the SMMUv3 node from the IORT. This would require more work as you would need to fully rewrite the IORT. Hence why I suggested to speak with the spec owner (it seems to be Arm) to reserve 0xff as "Invalid/Ignore". >>> + smmu = (struct acpi_iort_smmu_v3 *)node->node_data; >>> + mfn = paddr_to_pfn(smmu->base_address); >>> + rc = iomem_deny_access(d, mfn, mfn + PFN_UP(SZ_128K)); >>> + if ( rc ) >>> + printk("iomem_deny_access failed for SMMUv3\n"); >>> + node->type = 0xff; >> >> 'node' points to the Xen copy of the ACPI table. We should really not touch this copy. Instead, we should modify the version that will be used by dom0. > > As of now IORT is untouched by Xen and mapped to dom0. I will create the IORT table for dom0 and modify the node SMMUv3 that will be used by dom0. >> >> Furthermore, if we go down the road to update node->type, we should 0 the node to avoid leaking the information to dom0. > > I am not sure if we can zero the node, let me check and come back to you. By writing node->type, you already invalidate the content because the software cannot know how to interpret it. At which point, zeroing it should make no difference for software parsing the table afterwards. This may be a problem for software parsing before hand and keeping a pointer to the entry. But then, this is yet another reason to no updated the host IORT and create a copy for dom0. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 15:39:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319738.540091 (Exim 4.92) (envelope-from ) id 1nlucH-0004y7-Er; Tue, 03 May 2022 15:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319738.540091; Tue, 03 May 2022 15:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlucH-0004y0-Bb; Tue, 03 May 2022 15:39:09 +0000 Received: by outflank-mailman (input) for mailman id 319738; Tue, 03 May 2022 15:39:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlucF-0004xu-MI for xen-devel@lists.xenproject.org; Tue, 03 May 2022 15:39:07 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a78e9d1-caf7-11ec-a406-831a346695d4; Tue, 03 May 2022 17:39:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BD1C4210E0; Tue, 3 May 2022 15:39:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8535A13ABE; Tue, 3 May 2022 15:39:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xRmRHplMcWI5CgAAMHmgww (envelope-from ); Tue, 03 May 2022 15:39:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a78e9d1-caf7-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651592345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WrpEMB1W7TnL5SQymLWsAPOL6/iFhNULQO1y1FsULXc=; b=hGwb9ZZ9ghIo53lFXEIKH9OOYFOaoQZRjDIyZmkR4V6BZFXZqDe0ra6C67FABMb41iM7tD aySUo9/xF1YfmSh3rwEljtz1eYqQ2UTDqPVGWFexKMaCrO3V2apRX3EUUa2fv0VsKBs6Uy FuQOLcwgMu6S5v9ai/T3TxVfnWX0mfQ= Message-ID: Date: Tue, 3 May 2022 17:39:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: x86/PV: (lack of) MTRR exposure Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ltgwuO16jt05xd18LUOM1IlN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ltgwuO16jt05xd18LUOM1IlN Content-Type: multipart/mixed; boundary="------------BELGfTD8P7ZLtSJQtZPTd09M"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Boris Ostrovsky Message-ID: Subject: Re: x86/PV: (lack of) MTRR exposure References: In-Reply-To: --------------BELGfTD8P7ZLtSJQtZPTd09M Content-Type: multipart/mixed; boundary="------------1x28XZSRFm0KjFy5Ax3404Vq" --------------1x28XZSRFm0KjFy5Ax3404Vq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjguMDQuMjIgMTc6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBIZWxsbywNCj4gDQo+ IGluIHRoZSBjb3Vyc2Ugb2YgYW5hbHl6aW5nIHRoZSBpOTE1IGRyaXZlciBjYXVzaW5nIGJv b3QgdG8gZmFpbCBpbg0KPiBMaW51eCA1LjE4IEkgZm91bmQgdGhhdCBMaW51eCwgZm9yIGFs bCB0aGUgeWVhcnMsIGhhcyBiZWVuIHJ1bm5pbmcNCj4gaW4gUFYgbW9kZSBhcyBpZiBQQVQg d2FzIChtb3N0bHkpIGRpc2FibGVkLiBUaGlzIGlzIGEgcmVzdWx0IG9mDQo+IHRoZW0gdHlp bmcgUEFUIGluaXRpYWxpemF0aW9uIHRvIE1UUlIgaW5pdGlhbGl6YXRpb24sIHdoaWxlIHdl DQo+IG9mZmVyIFBBVCBidXQgbm90IE1UUlIgaW4gQ1BVSUQgb3V0cHV0LiBUaGlzIHdhcyBk aWZmZXJlbnQgYmVmb3JlDQo+IG91ciBtb3ZpbmcgdG8gQ1BVIGZlYXR1cmVzZXRzLCBhbmQg YXMgc3VjaCBvbmUgY291bGQgdmlldyB0aGlzDQo+IGJlaGF2aW9yIGFzIGEgcmVncmVzc2lv biBmcm9tIHRoYXQgY2hhbmdlLg0KPiANCj4gVGhlIGZpcnN0IHF1ZXN0aW9uIGhlcmUgaXMg d2hldGhlciBub3QgZXhwb3NpbmcgTVRSUiBhcyBhIGZlYXR1cmUNCj4gd2FzIHJlYWxseSBp bnRlbmRlZCwgaW4gcGFydGljdWxhciBhbHNvIGZvciBQViBEb20wLiBUaGUgWGVub0xpbnV4 DQo+IGtlcm5lbCBhbmQgaXRzIGZvcndhcmQgcG9ydHMgZGlkIG1ha2UgdXNlIG9mIFhFTlBG XypfbWVtdHlwZSB0bw0KPiBkZWFsIHdpdGggTVRSUnMuIFRoYXQncyBmdW5jdGlvbmFsaXR5 IHdoaWNoIChtYXliZSBmb3IgYSBnb29kDQo+IHJlYXNvbikgbmV2ZXIgbWFkZSBpdCBpbnRv IHRoZSBwdm9wcyBrZXJuZWwuIE5vdGUgdGhhdCBQVkggRG9tMA0KPiBkb2VzIGhhdmUgYWNj ZXNzIHRvIHRoZSBvcmlnaW5hbCBzZXR0aW5ncywgYXMgdGhlIGhvc3QgdmFsdWVzIGFyZQ0K PiB1c2VkIGFzIGluaXRpYWwgc3RhdGUgdGhlcmUuDQo+IA0KPiBUaGUgbmV4dCBxdWVzdGlv biB3b3VsZCBiZSBob3cgd2UgY291bGQgZ28gYWJvdXQgaW1wcm92aW5nIHRoZQ0KPiBzaXR1 YXRpb24uIEZvciB0aGUgcGFydGljdWxhciBpc3N1ZSBpbiA1LjE4IEkndmUgZm91bmQgYSBy ZWxhdGl2ZWx5DQo+IHNpbXBsZSBzb2x1dGlvbiBbMV0gKHdoaWNoIGFsc28gbG9va3MgdG8g aGVscCBncmFwaGljcyBwZXJmb3JtYW5jZQ0KPiBvbiBvdGhlciBzeXN0ZW1zLCBhY2NvcmRp bmcgdG8gbXkgaW5pdGlhbCBvYnNlcnZhdGlvbnMgd2l0aCB1c2luZw0KPiB0aGUgY2hhbmdl KSwgYWxiZWl0IGl0cyBzaW1wbGljaXR5IGxpa2VseSBtZWFucyBpdCBlaXRoZXIgaXMgd3Jv bmcNCj4gaW4gc29tZSB3YXksIG9yIG1pZ2h0IG5vdCBiZSBsaWtlZCBmb3IgbG9va2luZyBo YWNreSBhbmQvb3IgYWJ1c2l2ZS4NCj4gV2UgY2FuJ3QsIGZvciBleGFtcGxlLCBzaW1wbHkg dHVybiBvbiB0aGUgTVRSUiBiaXQgaW4gQ1BVSUQsIGFzIHRoYXQNCj4gd291bGQgaW1wbGlj aXRseSBsZWFkIHRvIHRoZSBrZXJuZWwgdHJ5aW5nIHRvIHdyaXRlIHRoZSBQQVQgTVNSIChp ZiwNCj4gc2VlIGJlbG93LCBpdCBkaWRuJ3QgaXRzZWxmIHphcCB0aGUgYml0KS4gV2UgYWxz byBjYW4ndCBzaW1wbHkNCj4gaWdub3JlIFBBVCBNU1Igd3JpdGVzLCBhcyB0aGUga2VybmVs IHdvbid0IGNoZWNrIHdoZXRoZXIgd3JpdGVzDQo+IGFjdHVhbGx5IHRvb2sgZWZmZWN0LiAo QWxsIG9mIHRoYXQgZGlkIHdvcmsgb24gdG9wIG9mIG9sZCBYZW4NCj4gYXBwYXJlbnRseSBv bmx5IGJlY2F1c2UgeGVuX2luaXRfY2FwYWJpbGl0aWVzKCkgaXRzZWxmIGFsc28gZm9yY2Vz DQo+IHRoZSBNVFJSIGZlYXR1cmUgdG8gb2ZmLikNCg0KSSd2ZSBzZW50IGFuIGFsdGVybmF0 aXZlIHBhdGNoIGFkZHJlc3NpbmcgdGhpcyBwcm9ibGVtOg0KDQpodHRwczovL2xvcmUua2Vy bmVsLm9yZy9sa21sLzIwMjIwNTAzMTMyMjA3LjE3MjM0LTMtamdyb3NzQHN1c2UuY29tL1Qv I3UNCg0KTGV0cyBzZWUgd2hldGhlciBpdCBpcyBhY2NlcHRlZC4NCg0KDQpKdWVyZ2VuDQo= --------------1x28XZSRFm0KjFy5Ax3404Vq Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1x28XZSRFm0KjFy5Ax3404Vq-- --------------BELGfTD8P7ZLtSJQtZPTd09M-- --------------ltgwuO16jt05xd18LUOM1IlN Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJxTJkFAwAAAAAACgkQsN6d1ii/Ey9R /ggAjMENfXS2o/d5iKFeZ8vryHlFCYfToR+Ohy4iGIHBYlbb3CKhEDG7aiopbbF/mkWVaxNqf1Qw olvAvHL2XGbjYKyxlh/HsXBE74Bd6xFEBMcX5vQNfG1CqFNIb1OcuWjObKX/IXSrY+Fkbsjao+EC +X2FNkwxG8BbB9elr4ZzI8hsBIMSvgDEwLiFj4GzEM/jn48zmIytg8kU7cXp0VXBq8P+W0/6668U U0oVJo170gy3Jy+6e+1xAu0rGHZebQOMFw3jU0MSo221HlBSSzprHEBLLy4cABTcFrtQdAPhA6Fj ajMFpsZWdl3+jTBIuLEw9An4j1kPJ4cx9VyQB+O8IQ== =/9IA -----END PGP SIGNATURE----- --------------ltgwuO16jt05xd18LUOM1IlN-- From xen-devel-bounces@lists.xenproject.org Tue May 03 15:44:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:44:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319745.540103 (Exim 4.92) (envelope-from ) id 1nluhf-0006TS-80; Tue, 03 May 2022 15:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319745.540103; Tue, 03 May 2022 15:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluhf-0006TL-55; Tue, 03 May 2022 15:44:43 +0000 Received: by outflank-mailman (input) for mailman id 319745; Tue, 03 May 2022 15:44:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluhd-0006TC-VZ for xen-devel@lists.xenproject.org; Tue, 03 May 2022 15:44:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluhd-00061t-FA; Tue, 03 May 2022 15:44:41 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nluhd-0000rp-94; Tue, 03 May 2022 15:44:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9F7Xv3wLaFGv28kCjn9Bfk2xJDD+LTW1ZkZduRWOKTQ=; b=EWXSU5UfsHMw99AqntlX9d0o5m 3VvvJmgdOR/qdaax/rXRWHXVF5vpG4uWHdq0Jfm50R+6QGK6MNvD+wpiygTaBv2r8HcnWzm+r9o0k 3bpxi2RRWnnndZZOrmkxEvVero2zqzVqj6wHHl+KP93+tkCOJJa7L0VpAUfiz7dIojXc=; Message-ID: Date: Tue, 3 May 2022 16:44:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <0c6fd5db-ffc7-893a-1ad0-d54f3974a45a@xen.org> <004BB439-72CA-4543-8CEA-C3BADC7D98CF@arm.com> From: Julien Grall In-Reply-To: <004BB439-72CA-4543-8CEA-C3BADC7D98CF@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/04/2022 15:33, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 27 Apr 2022, at 6:42 pm, Julien Grall wrote: >> >> Hi, >> >> On 27/04/2022 17:15, Rahul Singh wrote: >>> When a device is deassigned from the domain it is required to remove the >>> iommu group. >> >> This read wrong to me. We should not need to re-create the IOMMU group (and call arm_smmu_add_device()) every time a device is re-assigned. > Ok. >> >>> If we don't remove the group, the next time when we assign >>> a device, SME and S2CR will not be setup correctly for the device >>> because of that SMMU fault will be observed. >> >> I think this is a bug fix for 0435784cc75dcfef3b5f59c29deb1dbb84265ddb. If so, please add a Fixes tag. > > Ok Let me add the Fixes tag in next version. >> >>> Signed-off-by: Rahul Singh >>> --- >>> xen/drivers/passthrough/arm/smmu.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c >>> index 5cacb2dd99..9a31c332d0 100644 >>> --- a/xen/drivers/passthrough/arm/smmu.c >>> +++ b/xen/drivers/passthrough/arm/smmu.c >>> @@ -1690,6 +1690,8 @@ static void arm_smmu_detach_dev(struct iommu_domain *domain, struct device *dev) >>> if (cfg) >>> arm_smmu_master_free_smes(cfg); >>> + iommu_group_put(dev_iommu_group(dev)); >>> + dev_iommu_group(dev) = NULL; >>> } >> >> The goal of arm_smmu_detach_dev() is to revert the change made in arm_smmu_attach_dev(). But looking at the code, neither the IOMMU group nor the smes are allocated in arm_smmu_attach_dev(). >> >> Are the SMES meant to be re-allocated everytime we assign to a different domain? If yes, the allocation should be done in arm_smmu_attach_dev(). > > Yes SMES have to be re-allocated every time a device is assigned. Hmmmm.... Looking at the code, arm_smmu_alloc_smes() doesn't seem to use the domain information. So why would it need to be done every time it is assigned? > > Is that okay if I will move the function arm_smmu_master_alloc_smes() from arm_smmu_add_device() to arm_smmu_attach_dev(). > In this case we don’t need to remove the IOMMU group and also arm_smmu_detach_dev() will also revert the change made in arm_smmu_attach_dev(). > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index 5cacb2dd99..ff1b73d3d8 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -1680,6 +1680,10 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > if (!cfg) > return -ENODEV; > > + ret = arm_smmu_master_alloc_smes(dev); > + if (ret) > + return ret; > + > return arm_smmu_domain_add_master(smmu_domain, cfg); If we go down this route, then you will likely need to revert the change made by arm_smmu_master_alloc_smes(). > } > > @@ -2075,7 +2079,7 @@ static int arm_smmu_add_device(struct device *dev) > iommu_group_add_device(group, dev); > iommu_group_put(group); > > - return arm_smmu_master_alloc_smes(dev); > + return 0; > } > > Regards, > Rahul >> >> If not, then we should not free the SMES here >> >> IIUC, the SMES have to be re-allocated every time a device is assigned. Therefore, I think we should move the call to arm_smmu_master_alloc_smes() out of the detach callback and in a helper that would be used when removing a device (not yet supported by Xen). >> >> Cheers, >> >> -- >> Julien Grall > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 15:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319751.540114 (Exim 4.92) (envelope-from ) id 1nlupB-0007y9-1P; Tue, 03 May 2022 15:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319751.540114; Tue, 03 May 2022 15:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlupA-0007y2-Uk; Tue, 03 May 2022 15:52:28 +0000 Received: by outflank-mailman (input) for mailman id 319751; Tue, 03 May 2022 15:52:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlup9-0007xw-F1 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 15:52:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlup9-00069C-4o; Tue, 03 May 2022 15:52:27 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nlup8-0001CM-V8; Tue, 03 May 2022 15:52:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1W+oa9k0g1MXamaZFtGzakPAdp+MvW/mq7nzi9iGnxI=; b=az80evquFMTUEse/BmwKjYYhut ZXYyBTwVuVaPGJW7R7JYMNXdDbJpPFoR0CTpof+7fAle/uJeyhNpRLXJbgyntQgcmx0bSYLEGMW83 Yc48nqdmipYHxx9qFiT3iw8oMiIkAB7W420xa4S1zw49gq+zM8iaedR3N6hXFQlQxmpE=; Message-ID: <76b13da0-9ec4-1cc1-547a-129f89956ad5@xen.org> Date: Tue, 3 May 2022 16:52:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com> <92ECC32D-DA6E-4DC8-B0E2-8EC758471C4B@arm.com> From: Julien Grall In-Reply-To: <92ECC32D-DA6E-4DC8-B0E2-8EC758471C4B@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/04/2022 15:11, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 28 Apr 2022, at 1:59 pm, Julien Grall wrote: >> >> >> >> On 28/04/2022 11:00, Rahul Singh wrote: >>> Hi Julien, >>>> On 27 Apr 2022, at 6:59 pm, Julien Grall wrote: >>>> >>>> Hi Rahul, >>>> >>>> On 27/04/2022 17:14, Rahul Singh wrote: >>>>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are >>>> >>>> Looking at the spec (ARM IHI 0069H), I can't find a command error named MAPC_LPI_OFF. Is it something specific to your HW? >>> I found the issue on HW that implements GIC-600 and GIC-600 TRM specify the MAPC_LPI_OFF its command error. >>> https://developer.arm.com/documentation/100336/0106/introduction/about-the-gic-600 >>> {Table 3-15 ITS command and translation errors, records 13+ page 3-89} >> >> Please provide a pointer to the spec in the commit message. This would help the reviewer to know where MAPC_LPI_OFF come from. > Ok. >> >>>> >>>>> not enabled before mapping the collection table using MAPC command. >>>>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection >>>>> table. >>>>> Signed-off-by: Rahul Singh >>>>> --- >>>>> xen/arch/arm/gic-v3.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>>>> index 3c472ed768..8fb0014b16 100644 >>>>> --- a/xen/arch/arm/gic-v3.c >>>>> +++ b/xen/arch/arm/gic-v3.c >>>>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) >>>>> /* If the host has any ITSes, enable LPIs now. */ >>>>> if ( gicv3_its_host_has_its() ) >>>>> { >>>>> + if ( !gicv3_enable_lpis() ) >>>>> + return -EBUSY; >>>>> ret = gicv3_its_setup_collection(smp_processor_id()); >>>>> if ( ret ) >>>>> return ret; >>>>> - if ( !gicv3_enable_lpis() ) >>>>> - return -EBUSY; >>>> >>>> AFAICT, Linux is using the same ordering as your are proposing. It seems to have been introduced from the start, so it is not clear why we chose this approach. >>> Yes I also confirmed that before sending the patch for review. I think this is okay if we enable the enable LPIs before mapping the collection table. >> >> In general, I expect change touching the GICv3 code based on the specification rather than "we think this is okay". This reduce the risk to make modification that could break other platforms (we can't possibly test all of them). >> >> Reading through the spec, the definition of GICR.EnableLPIs contains the following: >> >> " >> 0b0 LPI support is disabled. Any doorbell interrupt generated as a result of a write to a virtual LPI register must be discarded, and any ITS translation requests or commands involving LPIs in this Redistributor are ignored. >> >> 0b1 LPI support is enabled. >> " >> >> So your change is correct. But the commit message needs to be updated with more details on which GIC HW the issue was seen and why your proposal is correct (i.e. quoting the spec). > > Ok. I will modify the commit msg as below.Please let me know if it is okay. > > arm/its: enable LPIs before mapping the collection table > > When Xen boots on the platform that implements the GIC 600, ITS > MAPC_LPI_OFF uncorrectable command error issue is oberved. s/oberved/observed/ > > As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can > be reported if the ITS MAPC command has tried to map a collection to a core > that does not have LPIs enabled. Please add a quote from the GICv3 specification (see my previous reply). > > To fix this issue, enable the LPIs using GICR_CTLR.EnableLPIs before > mapping the collection table. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 15:58:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 15:58:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319757.540124 (Exim 4.92) (envelope-from ) id 1nluus-0000Ia-N9; Tue, 03 May 2022 15:58:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319757.540124; Tue, 03 May 2022 15:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluus-0000IT-KN; Tue, 03 May 2022 15:58:22 +0000 Received: by outflank-mailman (input) for mailman id 319757; Tue, 03 May 2022 15:58:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluur-0000IK-Fe for xen-devel@lists.xenproject.org; Tue, 03 May 2022 15:58:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluur-0006F8-0S; Tue, 03 May 2022 15:58:21 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nluuq-0001dV-R7; Tue, 03 May 2022 15:58:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=s7eq2YAZ2vkZbMLKz3s/AzmFRex9ztoOqdyNyEaAaX8=; b=1YzDPQCchP9KTR4O9pTtSCtN/l mKACTZQVXS0JLK/JQX1UMyAwZL2aPZMNePBbNs83jbsl7ulU0NsmZcu37hmLPnEGxDrL46UmHKaIz xkX+jFQHBg+DmIsi0qO95M4egFQUusz8WXoE0wE/nqJFZfxzHPgZuuI5DqXV19DjfeO4=; Message-ID: Date: Tue, 3 May 2022 16:58:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 27/04/2022 17:14, Rahul Singh wrote: > MAPC_LPI_OFF ITS command error can be reported to software if LPIs are > not enabled before mapping the collection table using MAPC command. > > Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection > table. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/gic-v3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index 3c472ed768..8fb0014b16 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) > /* If the host has any ITSes, enable LPIs now. */ > if ( gicv3_its_host_has_its() ) > { > + if ( !gicv3_enable_lpis() ) > + return -EBUSY; gicv3_enable_lpis() is using writel_relaxed(). So in theory, the write may not be visible before gicv3_its_setup_collection() send the command. So I think we need to add an smp_wmb() to ensure the ordering with a comment explaning why this is necessary. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 16:00:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 16:00:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319763.540135 (Exim 4.92) (envelope-from ) id 1nluxA-0002CK-3c; Tue, 03 May 2022 16:00:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319763.540135; Tue, 03 May 2022 16:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nluxA-0002CD-0Z; Tue, 03 May 2022 16:00:44 +0000 Received: by outflank-mailman (input) for mailman id 319763; Tue, 03 May 2022 16:00:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlux8-0002C1-4R; Tue, 03 May 2022 16:00:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlux8-0006s7-31; Tue, 03 May 2022 16:00:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlux7-0005qM-NC; Tue, 03 May 2022 16:00:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlux7-0003Tf-Ml; Tue, 03 May 2022 16:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+AmgU9nUHmtohZFBstC2Zwt6kcL46tCEt9Tr1CCz5GE=; b=m/6lfk0IR25sk7ChzuhkffPMQk Q5nqDqSVGMuXjZQjTofWLschu+hhTRIJ6P7SP6rCslhpoXlWcxqDi0ZuJQLZlZjhVrqg2Jatmm9N3 Ccz8vZy1vl6dEW3RoIqj+o4rwTOLg1RDsD/YT3Blg/SyLG82dhvQzstO9u7qrVhkJd+Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170050: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 16:00:41 +0000 flight 170050 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170050/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 783 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 16:06:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 16:06:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319771.540147 (Exim 4.92) (envelope-from ) id 1nlv2j-0002yc-Po; Tue, 03 May 2022 16:06:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319771.540147; Tue, 03 May 2022 16:06:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlv2j-0002yV-MA; Tue, 03 May 2022 16:06:29 +0000 Received: by outflank-mailman (input) for mailman id 319771; Tue, 03 May 2022 16:06:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlv2j-0002yP-4U for xen-devel@lists.xenproject.org; Tue, 03 May 2022 16:06:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcc35531-cafa-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 18:06:27 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-kmLX6NTYNWWVkhG93Kgb2A-1; Tue, 03 May 2022 18:06:26 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM8PR04MB8002.eurprd04.prod.outlook.com (2603:10a6:20b:247::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Tue, 3 May 2022 16:06:24 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Tue, 3 May 2022 16:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcc35531-cafa-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651593987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vu+AzfRNDiCGW2HH4jtGe5Gs/BEKSQ0r8+P7fnZ70TI=; b=OcgfnZCAJb0s8hCf+FkSCk7QHii5uvSKw2RC7ztxvZjHEAJxKw+3K1JBsXqVYaX9X4OAQF ahSzEUq+1QdcDH+HKgH+2z2C8Ie154ALw9wH/fJz51bcQoVuVFzQIRB8uhwCcVROHBwTer PRYF7N6bx9GCcd+n49nNU1wuuRxPgu8= X-MC-Unique: kmLX6NTYNWWVkhG93Kgb2A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d09YyPyW+gFxI3dsL5n3kzi5fwsH//3Kf7QClzuyTtoGc4sl/Kz1sDHOidT54RX9ew3eBwiwJMemTl2INy7/o/6DkyCN/0LAC3n7YzegKwL2rMziOhUbbq8Tl4esTeAaRd+G07x9/if/fGwiESmr9pnQALTS6Rq+s+s1OKNeYcGCWxf1515t3c1cIBDR9ZAUEZQA2uJonlzPl6aJpVtoOgCXMJqOxYMRieQLmiNAiYVDpLe1NTTGk/0AOWJM1asF4Y2T9HUr9k3k119vjOfZWTCuFp+Uu7QxxBlJ+lp3XRnok+c8g9sS05fA6y9RBQUPsMXkGhxOv6R/QPd/FxQjBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=km7FEL/ymbiuEfFWWplf0LDFYJiDq7CdQKzWzw4/q6s=; b=htWY6yxUSGLu+KQ33981OUXcN1RpQYO371cAUj62u3kedp1RPvVO4uUQrd5nAH+UK459aMUSQ41qZQxiI9rumfehQvIoGY5fElDn9rO6MQd4OVVDkS8MPMiyU7o0RN322lgWrfH5dhUIB0O3uFTJc2NEj88bjhrb+Wgi5YxaZs38xLM45KhOwgzIPM25WPbgz8YBVrSVOe+rOHNpQV5+5aLNTqFUzCSJxr0E492mlkSkFCHzsrnErLe0dM1U23q9nC0RB8O6ttjIKVBUDnpRJ9L7JGFruCyFBXTeqCtpUdSKNBJMRNpatSCdHSFnFOxJFyGLCXaqNuP4CcE1v6blXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 3 May 2022 18:06:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH RFC] x86/lld: fix symbol map generation Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220502152020.19768-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:20b:2e::26) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3138b05-2063-4f58-f3cd-08da2d1edf00 X-MS-TrafficTypeDiagnostic: AM8PR04MB8002:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YCD8beQR2MmGqEw6t2BX7AfKEZ3oq0X0Z8YIP02tUQOAzNzb30I5nd/PbUYVqHernWg+d6MMV9hvPYwvtlCSz6vCJ6sYhAazLhzgK8x4mc67qMyNxt9ar00VfYDUUnEP+7mI2G1K6sh8Tdc3xTiSCusB0YchY7iI1XXY305VoB1a8O+U3WFU2ZvQ+8SpZ53IFzAYC21Q5eUsAWL/gExK9TkpMOxbMhMA0limcK6T4BYF4Ja3XKTozefUpsnizUa0pLIqGy6tf/gkPW3rvavi+lzEAxt1uLsayrg7tgKzGqtVh1ykz03zQulWRgsg0ktncmJan1/+OpeGT1lU+AUC7JiqbVHDrt4zwQIYQbf8TKDf4gCLIKD+t1u20p7elqRDhxBhYQW0eHsThuMTsRd7LxaV0Zq3BbpCHEUjuw+AclT8ZyGbrOkyAnxtKMgoeKUxDDcB+JTaIOHOvP7J2O076wi5vcg55980eAvAhyH0rk8kWfgeTbJI98j5qG4zSkVGeM5VnPqX1k1rI+fss29+9wisO6prSDpQo8FSOQ2HTR48WMCJBes5mFHHMHkg/QCL1N1euf+O8Mng0x2p8m5TrL5a3PJ+RtOoW40TJfde9GdT9ufxmYbGBFicUpa8IEtIh38vwBf1cPqbLkcaMDjcPwrOek6L5Mg4EbK5taf2QzauNzQwnak6LFjg09AEf0ogwu3ZAKuRCVqlK6B5kw4VyUqIik7bW1cejThwJHjGyA0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(53546011)(6506007)(2906002)(6512007)(26005)(31696002)(508600001)(38100700002)(6486002)(8936002)(36756003)(5660300002)(8676002)(4326008)(83380400001)(66946007)(66556008)(66476007)(31686004)(186003)(316002)(54906003)(6916009)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xlcGhuCKQ9fgy1eh9jBb31lYaXhS/cMiSfYmpJX6Foh1APTJzS6vlCoaGbHM?= =?us-ascii?Q?hg8Lm1ehEAF/4tripQ7RNPZNhRwEDQFQI5DxC/XHLl994Vq1gLemkrvtopgn?= =?us-ascii?Q?B1k5VvPzfv+kYZd4LLiFPx2oBXphNLCllzxpGCaHWTHpUHyY8VlplFrcfZbS?= =?us-ascii?Q?6GsaeZGCSD1NW3q+UkFtpcKGLarBhKn1Rqh4Mc2BFHEPEsukzlOtAgdNHMOU?= =?us-ascii?Q?kiIdnadoE3l8ebeuYip5J0TGEe96WpDj0BKGerC4BOPxkJfnnk5zkvqV1mxD?= =?us-ascii?Q?RZsNrzRIddj/1nHZ1S+wJnN5XPesiVvn4UGL2DR/9aDhC5S7quyijZ/seYDk?= =?us-ascii?Q?Hrmx2on0tFA2YLy7fSIUHMmAACKBIBPX3vYLtBE2IyNum2DuvoRtJvxxIjis?= =?us-ascii?Q?v53FFM2sWX/u4ZiHDnhMvYB08ps6NelBHGnq88lR6BnVq+Jv3Yog6Qjc/tof?= =?us-ascii?Q?sIXQqjz34DIUAUzPN23Zknqun8mLLcn7eyMw8cuohrtQnXumE2qojYK9SOVf?= =?us-ascii?Q?Fg6ZrQ3Cpd6emmGlUgukp1BMlDzDgyUQhhsvc+ZkBHafycMYHUlRYfT3BHks?= =?us-ascii?Q?7QlPeFYdfpNqkzZ6ThujecG/8S/NHoaOyCV3gjQy6wSoXyG948U1exFLy6qk?= =?us-ascii?Q?wCi/8nQkLD8kCaMhsDqL2ZjoP0Lr93jJ4dNbsjaAq0i5xxDKX6t6ZJ2i4ySC?= =?us-ascii?Q?2r9Xs5tYlLB8biIuDlcC3ZvK4+trJL0BWtQPvEmIflrYw5kV5xdns2GkJ9m7?= =?us-ascii?Q?BOU/GHsqJAXfxC10prOd8O59IbiDh7J2lyJVbPHNBJUfoGSXKJJFqylXTaJl?= =?us-ascii?Q?h7byd10KayvNzD+aPVms5VssUHs9oBTV0nWJBi51yGpGIeGOt4HzkgJXVrxA?= =?us-ascii?Q?yK39A5CV3qtXsowKVJmAEo2+B38Kx0gVv+pS+J3SQxmWg5Ce6NLYmhGqwq7d?= =?us-ascii?Q?KiZOKxjTmeNf4yZO/uGWZCiOR7QNE/xRlutKC/cf/sdhlC0N2+YHi//8SMBa?= =?us-ascii?Q?cWeitJr8S7+rPqJrSt4aQyAyNnc5AfFz4Oy2YEefDyz9tYSJZYMWq+UHpqXW?= =?us-ascii?Q?dHEbOzoNh7HRdCZ8amNLd3XOwMPjWeVEERoM7ewTlRAPbksQTm3U9TrukeYU?= =?us-ascii?Q?UNWfqrLCkJu4hvSzlOY5JBVvFMcA3+leGS+VeVt9g2CO+ebdFaKu0NLJC20P?= =?us-ascii?Q?oaK4c22MTQtb82C/LuQb5YJpDzPYX/FrOt/PnsCs/ToXV1TPvRtbVMgCeBTl?= =?us-ascii?Q?1ECoNkp6OTLLz7CQSUqVcGv2+UnB8u83oqbx0JYuVDJiM2C+lfi6c75mCmHo?= =?us-ascii?Q?mxW+b2KtufoK2abX1ih7X3C16lO2nGaw/XIuwMAXBSOGAMLny1T5kpx1MhBu?= =?us-ascii?Q?lwi9Uo5sWy5WFQzgwBUgrRQdXB29iANZsdn7OeCTdaSTXXDWta292CcgtI2I?= =?us-ascii?Q?wrvBoyp8fiAH+mPQuAPCW9TBz2UUCBWuU7Y7yb5pKpzwhQYMwZVc1/1wM3Xi?= =?us-ascii?Q?ZmDd+hmZQ1og+Y4XEFEPHXnzhFJbM4UtI0HTAJ7mODyKSnC7n9k4dunwv/m4?= =?us-ascii?Q?BIc99owzyAtJYlGIH2IQecI+wwMN7huMdTnm5YyH3ip6SQO+wieQuuj+q75g?= =?us-ascii?Q?km8GExPg6oCss2A3GAcGAF5O1jxPBvwTPoBC1UUu9BUm/MtctDVQycEu1wL4?= =?us-ascii?Q?pbrcK+icoGBlMz4S/x8+i+jksQ9y1M2Gm/k0k5Qb3lQCjwxAM+YlJ8E3zW6B?= =?us-ascii?Q?keo7N7bRLw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3138b05-2063-4f58-f3cd-08da2d1edf00 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 16:06:24.1715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eqqHRdfSLX1T1U5GDtxoYWr1h3xOK4RpxRwxsMexG9c3Jz1LKmLzF7ISJaxSk2bmzQYcgpnLFp8kEKBkCxB2NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8002 On 03.05.2022 11:15, Roger Pau Monn=C3=A9 wrote: > On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: >> On 02.05.2022 17:20, Roger Pau Monne wrote: >>> The symbol map generation (and thus the debug info attached to Xen) is >>> partially broken when using LLVM LD. That's due to LLD converting >>> almost all symbols from global to local in the last linking step, and >> >> I'm puzzled by "almost" - is there a pattern of which ones aren't >> converted? >=20 > This is the list of the ones that aren't converted: >=20 > __x86_indirect_thunk_r11 > s3_resume > start > __image_base__ > __high_start > wakeup_stack > wakeup_stack_start > handle_exception > dom_crash_sync_extable > common_interrupt > __x86_indirect_thunk_rbx > __x86_indirect_thunk_rcx > __x86_indirect_thunk_rax > __x86_indirect_thunk_rdx > __x86_indirect_thunk_rbp > __x86_indirect_thunk_rsi > __x86_indirect_thunk_rdi > __x86_indirect_thunk_r8 > __x86_indirect_thunk_r9 > __x86_indirect_thunk_r10 > __x86_indirect_thunk_r12 > __x86_indirect_thunk_r13 > __x86_indirect_thunk_r14 > __x86_indirect_thunk_r15 >=20 > I assume there's some kind of pattern, but I haven't yet been able to > spot where triggers the conversion from global to local in lld. At least this looks to all be symbols defined in assembly files, which don't have a C-visible declaration. >>> Not applied to EFI, partially because I don't have an environment with >>> LLD capable of generating the EFI binary. >>> >>> Obtaining the global symbol list could likely be a target on itself, >>> if it is to be shared between the ELF and the EFI binary generation. >> >> If, as the last paragraph of the description is worded, you did this >> just once (as a prereq), I could see this working. >=20 > Yes, my comment was about splitting the: >=20 > $(NM) -pa --format=3Dbsd $< | awk '{ if($$2 =3D=3D "T") print $$3}' \ > > $(@D)/.$(@F).global-syms >=20 > rune into a separate $(TARGET)-syms.global-syms target or some such. > Not sure it's really worth it. Probably indeed only when splitting up the rule as a whole. >>> --- a/xen/arch/x86/Makefile >>> +++ b/xen/arch/x86/Makefile >>> @@ -134,24 +134,34 @@ $(TARGET): $(TARGET)-syms $(efi-y) $(obj)/boot/mk= elf32 >>> CFLAGS-$(XEN_BUILD_EFI) +=3D -DXEN_BUILD_EFI >>> =20 >>> $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds >>> + # Dump global text symbols before the linking step >>> + $(NM) -pa --format=3Dbsd $< | awk '{ if($$2 =3D=3D "T") print $$3}' \ >>> + > $(@D)/.$(@F).global-syms >>> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >>> - $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 >>> + $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0.tmp >>> + # LLVM LD has converted global symbols into local ones as part of the >>> + # linking step, convert those back to global before using tools/symbo= ls. >>> + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms \ >>> + $(@D)/.$(@F).0.tmp $(@D)/.$(@F).0 >>> $(NM) -pa --format=3Dsysv $(@D)/.$(@F).0 \ >>> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ >>> >$(@D)/.$(@F).0.S >>> $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).0.o >>> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >>> - $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 >>> + $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1.tmp >>> + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms \ >>> + $(@D)/.$(@F).1.tmp $(@D)/.$(@F).1 >>> $(NM) -pa --format=3Dsysv $(@D)/.$(@F).1 \ >>> | $(objtree)/tools/symbols $(all_symbols) --sysv --sort $(syms-warn-= dup-y) \ >>> >$(@D)/.$(@F).1.S >>> $(MAKE) $(build)=3D$(@D) $(@D)/.$(@F).1.o >>> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >>> - $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ >>> + $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@.tmp >>> + $(OBJCOPY) --globalize-symbols=3D$(@D)/.$(@F).global-syms $@.tmp $@ >> >> Is this very useful? It only affects ... >> >>> $(NM) -pa --format=3Dsysv $(@D)/$(@F) \ >>> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ >>> >$(@D)/$(@F).map >> >> ... the actual map file; what's in the binary and in this map file doesn= 't >> depend on local vs global anymore (and you limit this to text symbols >> anyway; I wonder in how far livepatching might also be affected by the >> same issue with data symbols). >=20 > If I don't add this step then the map file will also end up with lines > like: >=20 > 0xffff82d0405b6968 b lib/xxhash64.c#iommuv2_enabled > 0xffff82d0405b6970 b lib/xxhash64.c#nr_ioapic_sbdf > 0xffff82d0405b6980 b lib/xxhash64.c#ioapic_sbdf >=20 > I see the same happen with other non-text symbols, so I would likely > need to extend the fixing to preserve all global symbols from the > input file, not just text ones. Oh, I see - yes, this wants avoiding. Jan From xen-devel-bounces@lists.xenproject.org Tue May 03 16:21:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 16:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319778.540158 (Exim 4.92) (envelope-from ) id 1nlvH0-0005hp-6z; Tue, 03 May 2022 16:21:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319778.540158; Tue, 03 May 2022 16:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvH0-0005hi-3i; Tue, 03 May 2022 16:21:14 +0000 Received: by outflank-mailman (input) for mailman id 319778; Tue, 03 May 2022 16:21:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvGy-0005hc-Sr for xen-devel@lists.xenproject.org; Tue, 03 May 2022 16:21:13 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09439ef1-cafd-11ec-a406-831a346695d4; Tue, 03 May 2022 18:21:09 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 12:20:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB3403.namprd03.prod.outlook.com (2603:10b6:4:43::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Tue, 3 May 2022 16:20:47 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 16:20:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09439ef1-cafd-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651594869; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=7l8ELOECyci1/B3ZF07O9GdIccNxyxV28w8MkB1oWn8=; b=cL1rw44pWsYwRb6bzCV8prxPvJviCUvlPrcW9gmTc3MkRrWB0h9d5Amw LSB0bhvTi9uHPv4BrXo8kwgm8ac450lJAX3ftRM80jjgBGct9Nkj5MqE5 BBa8hoayTPpvodZs4V1RtA3noMivW4YGS46YS9YnhSln/HJYXda49k1r5 c=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 70505550 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iIKJLqpLlridN0HI436IyXIA/WReBmIdZBIvgKrLsJaIsI4StFCzt garIBmPPqmIZjOmL9l2OYy1/RsFvZWGxoAxGVM/qihmHilB+JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 Yiq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBZ4ruoeQEURpkNX96Le5i+aP6OnOwvpnGp6HGWyOEL/RGKmgTZNdd1sMpRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjXFp2Zwm8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/fdvvjWOlGSd1pDSbPbnaIGLFfx2n2nFi GnK5U/JGDoVYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiGaNoxo0S9dWVeog52ml1a788wufQG8eQVZ8hMcOscY3QXkm0 wGPltawXzh36uTKFTSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa3871JBjO3mTlbwfvw+Rmw== IronPort-HdrOrdr: A9a23:wj8Xy6x6D80FC91Jc275KrPxv+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu vU2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9 fB5z8mIsRI8nvUOlq4pBP8sjOQpArHRxfZuC+lqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60TJiApIs+MfP+UpgNddvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,195,1647316800"; d="scan'208";a="70505550" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8s5oBAVz4uuFdp6JrbNxZoj32WBitCk3P3FUinCVvuI/tCdXWETo+gtayU0A1HUNiMFJKhm5mI7ly3/3YYVeeA0FferzEcSwrZ49GIFanAV16KLShhFSKcIL5GCWuip6lWOPvgfbvqHdcS/02FJGZ2l4qCsAj1fLUI5lPafN1kdKhUTySPj7X5CfuY9jGEQNYCcie4srN1Z3xyLbHJdsQv3aLjaTu7ntsj+Re1QJbH2QPFMba3Xlsam24lYpr7p7aLx7pE1C2oHNH1ppE4b6twiOHZ8IBEoG7yJe+NuDLYvHB6Y6lFFjislvL5vEegRIr7Ptz9bArXAOhC3L1E97g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J6RFzzGxPKZprX2xkIxyR/rvK1kwYmEkki2XS56ruW0=; b=fYOhSON1k6LDzn1ZhZWP4a6Zs825sqUgCQKLFsDzrh0fE27VgM8tUGw/k0jJsg1keNp7yeh5HToc0lGDricslYWePQkopfwQE1nARHvy0nms3a8E1EKL0g6BWaCkh9uHmwwhP7Ni1QuONpQ3C7lgydCI0yF4MwJYgtmT3mgEyaHiga/aRiHgxQUVrTkafZLaAa2TvJweAfb8y/wLVhH88mg3OOgFKF0LPnDT7HWig6ryOw9uUCBzcnb69H7P+7Xhn7K1MYay5/qBhosFRy99eTmNuD21ysYj4xwu1f1eyCp0lrzBrbxiQdKNyqBbiKIsafdANdAPCmBFsNPrMSAT9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J6RFzzGxPKZprX2xkIxyR/rvK1kwYmEkki2XS56ruW0=; b=pG1na5+ZoYMftF5rmnXMzGk4Scn1i4edcYpO3Hw88Ibcuiu8mWE5PvZEBsG3juxkNZVlCijYdk2AGdS9FStEbOb5M0T2JOAu3LnrTgIcwWb6PGbrgxdiTRRuKnZFHdXPOVLA3Ydaz6RLAixOMEF6LdSuqZg537WUJbOtlJUUF+U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 18:20:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables Message-ID: References: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> X-ClientProxiedBy: LO2P265CA0323.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4647cc6d-8ec4-4770-ca6e-08da2d20e171 X-MS-TrafficTypeDiagnostic: DM5PR03MB3403:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wtU8UJNviWKl8Qaf9IWZ/l8RZH4qewEb0l9xSDZOG2uHtEZx0tJUbDuIYR7L7UblK1SpsxMXgrz9cfE/Kjog7ltWtNTztXZxXMc0z00GdRxr/U3ziHOIs3nJBlE7D3ZWAgkzUSDNGq3s2Usw8jwNP5CsXGtAbBj5f30DngcuVe9whn79jDdErNygLuzJgPfJUMFQYM8UzrhsXWwYN9MQJoD24eF42rD6EvPRi3lQPkaRsWhT7qjCwTcgVI4rzlXUPpWfP8jZeAMpUjZEFcKWybHOnLsaIdm/ENp9dNqK5fR2hRB9NlVT28r4aAOZ60Jx1NBMxQjLEE9jT+kbbld1fOoE5xqAzTlbZN6Qa3vlVvRG8X0jdig5LlDfhnQyXeaiPj/IINqy+cSWS7Ej4986GeRzHe++qLlEEqapGn7vFmZx7A+7oVkWG3cqjUjhv5wfkQS1ofxDjAcpSe/QDhb8nVOAZHwX8IYDt4S8frag4dOVrFVtTCdrBPpVNxlzMsM0438MIPmAtOeDn07eoXlXviqCD1PhsDUbM27sVoVRaiXy1kjG8pLku34ej123Vr4GEfoWAIXBBHdIjafNh8W7dfp1pFVmU4R9C5fCM7FVlJGr0HfP0Vz+J3UYo6d698m+SWW8QAqth74mGpHPV3ONbX19V5P4quRcf3U7d7t1k+YfLqZ2hsiXl7AoFwUPEmjNL6o4pJBEPDMuIeibatksNlCvG9/Kei10z55XCi7ocVELM+cp3Fkozu0ofixb3x4SALtrPEijuXAsnLuumPfd+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(33716001)(85182001)(8936002)(508600001)(38100700002)(5660300002)(4326008)(83380400001)(8676002)(54906003)(6916009)(82960400001)(316002)(86362001)(6666004)(6506007)(6486002)(186003)(66476007)(66946007)(66556008)(9686003)(26005)(2906002)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWNhSWxUeGdGOG1XckQ0TUNORTdaVFRQS2VNdmU4Y25JdXB1ZkpVVzRDNHcy?= =?utf-8?B?cmhrTkJVbW43MW5seXIzWEFhOVhKMDR4M1gzdEo1eWlhRldlRWdabmhkZm0z?= =?utf-8?B?TnFCc1BwditDc1VrdWJGSytueFRvQTFYZlZjTjM1NXNhaStWZ1ZsT1M5TXRx?= =?utf-8?B?VHpuZzRYTWQza0o0MDJ4OFBLVU5kMCtMYWFnOCtoZzQ1b3YycXhzNnFnSmVH?= =?utf-8?B?ZG1iUnNDcWZ0SDNYTE1qRUluUHlReFBHWHo2cXN4WVpnSU0vbDJQZWk2d2Jx?= =?utf-8?B?cnpWQ0tNb21nc281K3UrcmN3K3R3K3hEZFd3cUpycEdraDA2b0lXYmFJUFA0?= =?utf-8?B?blNNdVhJSkp0MVFaaHh2TzJuakhMbjUyWDlLaGVmLzh4Mmthak5lRmxRbHpG?= =?utf-8?B?RlVIbmxrWDBDMHZRM1gvK2RzWHRWZGsyb1M2MlVLY1VWUElNa1loUHhPbktX?= =?utf-8?B?YTcwUHI0OUxuWENlZDdJLzhQWjJkeHMvTzIrbG5HckdQRTNUZkFJWjhFUjlR?= =?utf-8?B?NnNERjg2amxRdkdrSGMybURQVzAxTk5CVGlTQ3VGV2dTYjFqUWtYZklYNHRp?= =?utf-8?B?NnNWT1QrSjJKdW93REpjMkF2MjF0cnFYejF6QjZ2SmhjRExITU5XbWRjeUE3?= =?utf-8?B?UVN5VCtFdmFkR0psWkswbTIybXk5enFvb1NYN1lPUmMwVEptK3pna1hEc3gr?= =?utf-8?B?eTVJQ2RObk0rVUFTWkpuaC9qL05vNy9xS01ZK0I0SFNjbzJpQmE0aXZPN1hZ?= =?utf-8?B?dGRwdDJUMTNWVFc0YWd4OU1iSStUNm1jY1QybllENjI1Q1JFbFFSVmZDVEpI?= =?utf-8?B?NnM1eUtYV1o5VmdVa0p4STlaQm50OVNETXY0NkVtUHNMSmM5Wmc2K0xxMVd0?= =?utf-8?B?V2p4a2llVDNXVXNVQkcwZm5PNmcxV0JhUlZCMmlzZndkL29NbElTUlRPK1FZ?= =?utf-8?B?SjFpNVFTbldMWTkvQzVzdElCRFU0cm5hYkZEZ1BPVEdHZ0ZjVndZa1FFQmhx?= =?utf-8?B?b1NvalprTUxXdFhCMFNDaVJ6Nmo0M2lpTWxFZnFrZjRtV0E4eFdTbWVCeHNE?= =?utf-8?B?TlZMblNWQmg5cXU0dVZOVG4vZ0NWRlFPbTZDb3o2eXVEald2ejhqSVVxcGFu?= =?utf-8?B?dFViRHdvRWttM2RmWEo2aloxbUtGTEVQamljNTk3R2tiUlN5cFdLQVZSZ2dY?= =?utf-8?B?bVN4OXl4ZlRwL1llZElWYmUyeHRZdytiWTV3V2dpMW04L2poM1U5UGowVGNZ?= =?utf-8?B?TmpuaCsrTGlkY29VU0U2cHRJV2gwUUZuVGJRaytOMGFOQ09jNGE3SkpJaThy?= =?utf-8?B?eUZYZFQ4dmtlQmhTVk1LQklhN1llUi9sRG5CWUlvNWdZck56MEpJOFAxazUx?= =?utf-8?B?a3Y2bnhkY2hzdHkyaFkyTXB2Z25qNGxKSmswaHZkQS9SZnJiV3RwOEFJVjk0?= =?utf-8?B?SklVRFZSQnI3VFpiNnRlVDYyMkVjTmlpWVZlWEVBVGo4eWtmTHRlejg4aitX?= =?utf-8?B?MGQyczV6WTVTajdXRkQxSXBaS3lqU0tMSVorczVEM0VCNVBmNVBHMzY1OCtl?= =?utf-8?B?aHZaSVlIbjh0ZFQvbGxyVnRpT0VyL3RxMzFkcnA4VlhoUW5NSStPUGxpQy9L?= =?utf-8?B?WitlU3RlbDdDN2hnbmlCd0dNUjZPTFRreUxsNEd4T3lWbkJ2Q3NsRURXdmhy?= =?utf-8?B?V3FPMDQ5YWkwVCtFWkFZZ3dCeVI2NTdrVE0xUFhJTytqSHpySTNqb2N5Y1Uz?= =?utf-8?B?Y2ZuY3RKS2FEdW1kcVR5UFFFbCtTOWpVM3JtYld5K3pwOSt1cUNnMExGaWg4?= =?utf-8?B?YXJhMVM4b2M0ZXdiTnVmWkpaLzRDTUlKSitGVjBiRVYxNEx2QUk2WHF3VVdo?= =?utf-8?B?UGo5TXlZWEpua05vdDhrL2hzR2lNRW5RNVRkeGdDRktMeE1xcXgzRWVVNURm?= =?utf-8?B?REgrR0Nka3k2c25rYTdNTkhjSlRkUWtEdjBXanFGL3VZQkJjbi80TmVNUTJt?= =?utf-8?B?c2R2ZEtmd3lhL0lxQm9zc1NhRDNvQytnNlFacTdwOFRZTzF2aWNpcDh0WTRn?= =?utf-8?B?Q3ZleldicnNZM201REJ5ZWJ0UkdDWCtXQW9QVTQ5VjdOSlAvK1lYUitxSjFM?= =?utf-8?B?cURTUnk2M3NQdEpCbGNwSmRST2l0NUg4dnFMTzA4TXVyS2RBdmVFVG03aXhT?= =?utf-8?B?Nmk0N2V4QW03VlNDU0ZzYVlUMmd4bU52V0FGY0Yzam1ocE9iLzhDcnVFYWMv?= =?utf-8?B?YWl3eTEvTnNNOTM4T3U1OE91b3BKUFU2b2xoL3JidTgzdmFlRExLUzhwcU9m?= =?utf-8?B?Y0dTM2hRRUpROEY4YkNaUk5WeWpIR0lvZGxYSzFLWlp4MldGNTd2SGpCRTQ3?= =?utf-8?Q?pyPDu37bOrvh6i2Q=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4647cc6d-8ec4-4770-ca6e-08da2d20e171 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 16:20:47.2911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V/z73H02Q9FBW/0vBPnlQ1yY//jDSyH71z1EJ0ugZNiICikUVT9qBUTNIRbRTvLXemqBjq4IELXsvTYijonOpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3403 On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: > For vendor specific code to support superpages we need to be able to > deal with a superpage mapping replacing an intermediate page table (or > hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > needed to free individual page tables while a domain is still alive. > Since the freeing needs to be deferred until after a suitable IOTLB > flush was performed, released page tables get queued for processing by a > tasklet. > > Signed-off-by: Jan Beulich > --- > I was considering whether to use a softirq-tasklet instead. This would > have the benefit of avoiding extra scheduling operations, but come with > the risk of the freeing happening prematurely because of a > process_pending_softirqs() somewhere. I'm sorry again if I already raised this, I don't seem to find a reference. What about doing the freeing before resuming the guest execution in guest vCPU context? We already have a hook like this on HVM in hvm_do_resume() calling vpci_process_pending(). I wonder whether we could have a similar hook for PV and keep the pages to be freed in the vCPU instead of the pCPU. This would have the benefit of being able to context switch the vCPU in case the operation takes too long. Not that the current approach is wrong, but doing it in the guest resume path we could likely prevent guests doing heavy p2m modifications from hogging CPU time. > --- > v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base. > v3: Call process_pending_softirqs() from free_queued_pgtables(). > > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns > int __must_check iommu_free_pgtables(struct domain *d); > struct domain_iommu; > struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); > +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); > > #endif /* !__ARCH_X86_IOMMU_H__ */ > /* > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -12,6 +12,7 @@ > * this program; If not, see . > */ > > +#include > #include > #include > #include > @@ -550,6 +551,91 @@ struct page_info *iommu_alloc_pgtable(st > return pg; > } > > +/* > + * Intermediate page tables which get replaced by large pages may only be > + * freed after a suitable IOTLB flush. Hence such pages get queued on a > + * per-CPU list, with a per-CPU tasklet processing the list on the assumption > + * that the necessary IOTLB flush will have occurred by the time tasklets get > + * to run. (List and tasklet being per-CPU has the benefit of accesses not > + * requiring any locking.) > + */ > +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); > +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); > + > +static void free_queued_pgtables(void *arg) > +{ > + struct page_list_head *list = arg; > + struct page_info *pg; > + unsigned int done = 0; > + With the current logic I think it might be helpful to assert that the list is not empty when we get here? Given the operation requires a context switch we would like to avoid such unless there's indeed pending work to do. > + while ( (pg = page_list_remove_head(list)) ) > + { > + free_domheap_page(pg); > + > + /* Granularity of checking somewhat arbitrary. */ > + if ( !(++done & 0x1ff) ) > + process_pending_softirqs(); > + } > +} > + > +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg) > +{ > + unsigned int cpu = smp_processor_id(); > + > + spin_lock(&hd->arch.pgtables.lock); > + page_list_del(pg, &hd->arch.pgtables.list); > + spin_unlock(&hd->arch.pgtables.lock); > + > + page_list_add_tail(pg, &per_cpu(free_pgt_list, cpu)); > + > + tasklet_schedule(&per_cpu(free_pgt_tasklet, cpu)); > +} > + > +static int cf_check cpu_callback( > + struct notifier_block *nfb, unsigned long action, void *hcpu) > +{ > + unsigned int cpu = (unsigned long)hcpu; > + struct page_list_head *list = &per_cpu(free_pgt_list, cpu); > + struct tasklet *tasklet = &per_cpu(free_pgt_tasklet, cpu); > + > + switch ( action ) > + { > + case CPU_DOWN_PREPARE: > + tasklet_kill(tasklet); > + break; > + > + case CPU_DEAD: > + page_list_splice(list, &this_cpu(free_pgt_list)); I think you could check whether list is empty before queuing it? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 16:22:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 16:22:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319783.540168 (Exim 4.92) (envelope-from ) id 1nlvID-0006Fx-HA; Tue, 03 May 2022 16:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319783.540168; Tue, 03 May 2022 16:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvID-0006Fq-E7; Tue, 03 May 2022 16:22:29 +0000 Received: by outflank-mailman (input) for mailman id 319783; Tue, 03 May 2022 16:22:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvIB-0006Fg-R3 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 16:22:27 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 378b25e1-cafd-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 18:22:26 +0200 (CEST) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 May 2022 12:22:23 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB4367.namprd03.prod.outlook.com (2603:10b6:805:fc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.20; Tue, 3 May 2022 16:22:21 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.024; Tue, 3 May 2022 16:22:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 378b25e1-cafd-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651594946; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FPuEodeAjwsUKw7vIjyrD2EQdiqu2zIFLbwrSnLioaY=; b=TNi7vjeygHaM0cqHa01C6g2IElQjh4Qxr5N8gAZeoH+YfezJ2HMq6WWn tIsMw0/zj+w35z4xmScqQHmt9cUkSWKzRmupaeopDL4qDLJpinukurdia q1G5KBdZVzmsbb6dldljqpxPJWrtti90DvTicP8oCa7IJ8FhDgDVlKoOK c=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 72956715 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yWjmVK0qZeR343PzTPbD5aVwkn2cJEfYwER7XKvMYLTBsI5bpzwFn WUbUTuPMvneYjb8e99zO4Wy8kMEv8fUztdrQQI5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0T5YTsTFxzEpfThbo8eAdlKR4lLKd/reqvzXiX6aR/zmXgWl61m7BCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyStbe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrialImAG9wvIzUYxy3j61Spwk5fvDPbcOeTVVJ9NnByIg W2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM+e8CMU/4QCJj6bRvQCQAzFcSiYbMYR28sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46eEJpprUZwQ3N/ g0= IronPort-HdrOrdr: A9a23:z0p/XKvQ/VX6wgiNqA4c+77v7skC/4Mji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVeUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kcKDaTCNUEHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0k9 gsfJ4Y0I2mdfVmHJ6VNN1xP/dfNVa9MS4kEFjiV2gPR5t3ck4klfbMkccIzdDvXqA0570Pv7 mEeG9klAcJCjfT4Iu1rdB2ziw= X-IronPort-AV: E=Sophos;i="5.91,195,1647316800"; d="scan'208";a="72956715" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMHmeZHsCQTmvFm1eHbR6VzAfp1wl5PUqnYxE3iImJaO/APZq4GDyyZwpLwHUkdqKwXWeHTmvvwlwgEiNUN7JHbYpUX+GuTkS150ZhYYnMmIeo4oTGfzzz5w6v+77odVZjpipyrM4J5pTp9i8KvsSfoQRxibF5uhMyt4P8tg5uC44VVwApcFXAlNPa5jZAc8A0CH4Fzas1oQZmhaHFq5kMr53RaN5CsVlS6aG0CvG1C0SqNGcl/47n1tz16c61XDnGdRvMRpPuLp38lvzqWFhRRXaLubdSPS+ZbIiOyVEABEZF32JNhfdo40S92vuUXuBvE0VgdoqwI+C9y/WZ5yQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qkzrd2DUK+DDbH0WxNzsiXtOa7GcoyGYyEZagU34lpw=; b=fXKxSjl6xIecuasqQQZ+X3KOulvuZP6NaGZLUMZwJYiBVkN5sU7Xjrr4cB2KHv/D4jVsSOXw5gmUjT2DdTc9hKelYKc4mc1OXbKtAo266PnHpyLjp/MV4sXfXPtWBkLF4YMgVzHQWKVJEUxRFhmk19feRpP2Gglw+cjDmX8Camd4tm2D+3daYrIpShLb8WSdod0bRLsyMxFRejjcDdY2Ey9IYDXtyojcL53qZGRosV8Yka5MygoRVwEyTYXy8yzL0z1g8oNkXL5R9kTtFMLugAR3N+2m6QII1MRg4Obp9OVp5VeXquhjICoahZZCv1kI5Ua+puIS/ZC94HLZ0we9BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qkzrd2DUK+DDbH0WxNzsiXtOa7GcoyGYyEZagU34lpw=; b=I9ETElZMdTaYvaZVYipPS5o7ugfKPPxoqgv2fHcOOlLrvWou/4to0Skd7Yc0JefOz1iEy2K8eGM7I/bobC0A89MBakW7nz97IfV92TRyr0KpNIbLGlF15gaQMu6Cb7YRHeMfKaqjV+jo14qHpX8ctgTK9XlPSBn1wNxPFaKpVCA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 3 May 2022 18:22:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map() Message-ID: References: <35e5935b-7082-8224-7ad1-84ed12116426@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <35e5935b-7082-8224-7ad1-84ed12116426@suse.com> X-ClientProxiedBy: LO2P265CA0365.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1ba6d2d-74e0-4c4b-5ba9-08da2d21199f X-MS-TrafficTypeDiagnostic: SN6PR03MB4367:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qtOdDTkLvLfrQiRVuzEyXczubqRApLEhnvl3soZCxKEaazVFrkjk0KpDk22UIFMxGWPlEHfz8vI39d7IfYK0tgnGYDM9L4kfzZv/S3Ys5UmT8SiYrQmQJ4vrELN9p9S03ErOO8PZj6zD7ueOQQRuZ84R8Tmt6kAghvuaobEVNA8BrphqvvR3/jLvHYx4CYaoYpvYYRsiWXIroa4eddJIO77H0cjekEntpoLw1rzEMrdD6eyuorgu6b5afbd1fXzMguorm/50gGuQ/azl4o42AQpHOkjJ1FaOF4fjqFSNBLsLg2TWodnQ/d9Hmclg81zIiBnQdRbfcdAwfNhefVnr5BO5V8GDvkUXDZ9JET0r3xdr8uwcLYdj5o/ODhDDAn0wohl7PXMOX0tHKoyz5ZnPGuvGvn+Kn6J/43mOBRyDC9oaj6G5u0OCHzbMxlv1dOyVI0Glp7Ad+lwmGzrm41trD/W65iB2be9cOLZkeTpd2l/Um0g6kZ7pDP/gMAt9R52K8jGO75r7PvVafNKIi2imihBLgmSn/fWa3fO9q8fbRPn6Mz+sq2dF3u/BdiA2/41OlawI0EJcZxmtkR247aiUDt6vXfphopxN+G/3YdmcB4UUxI1c6EA5KL/XIANFsAsqiePfsmWXjzS1Y0MxqB1bMg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(6512007)(9686003)(6506007)(53546011)(6666004)(2906002)(6486002)(5660300002)(86362001)(186003)(508600001)(8936002)(4326008)(82960400001)(66556008)(66946007)(66476007)(8676002)(85182001)(316002)(33716001)(54906003)(6916009)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blZML0NTM1RFWnllaUVwUmxOUHl5bzJrSGJzYStRSEc2dzQ4QkdvbU9BL1JH?= =?utf-8?B?Q1lpNU9TSWczblA0ZmN0Z0RNZXdPZ2xNMFJmNXBHOXdQRFFjZGxWejEzL25i?= =?utf-8?B?a2VHVm9yaDI4NGlzWmp0bmpBUWVzS2paRzN5NUs0aTlvdk12MDBEUzU1VEE4?= =?utf-8?B?TWFtOE9EZHpWQUVIM3gzaktaSTgzSTczbzF4RTZucnA0SnlUMTgwekxMVlpr?= =?utf-8?B?Wno1Wm9VamY3TWpjckVRLy9hMUx3NFVsSDU0eVNucElQNVRjVWl0eXNtdGcx?= =?utf-8?B?NmVmVnlMRnd4K3pEWXovWTV0RXpxWnBKd0lqUy9NYlQ0VHJFNHJXS2piQVpL?= =?utf-8?B?ZGRMQllLb1NDbEp5NnQ4UFRncG54L3RhR3Z2c2VqWlB5dlgybG5BUUNTNE90?= =?utf-8?B?enE5TWRKU0lFbjZ4bmROVE9nSi9Fam9sRmFDRkNiYi9rSXFrQ001THZ2Yitx?= =?utf-8?B?UElEdnEyYzl2REFKNTdDaXpyK1huQndIam94ZTdGa3NYNVdoWGlZM2VZT25F?= =?utf-8?B?cVJVM242U01nVm5MVGQ5Ulk3VGtad2xKUmk0VWl1TnNrU0xaelY0bDFDTSsy?= =?utf-8?B?WVloa0NLN2NMSlhpQVR1K2thSk5ndVNjWVlNY0RhVmxGZG1XWXhFclR6VzNU?= =?utf-8?B?czJSWFJhVm9kSEpiOXFvZS9qS3pSQVJCUVVOU2c2K3lESVVheHN0amQ5cnl6?= =?utf-8?B?YzY3SFpuK24xZjJ0VStlckZPcmo0YVpHallRcXE1QTRJUC9neFM3SmhBeklX?= =?utf-8?B?Zk9JTTRueERueVdGbjJwRE9mZGd5WC83TVNuRTRTb1VUL2xhc0p6a2VuSTZv?= =?utf-8?B?R25EYURZaHA4L2lVMTVyQThicWxSc2QzMDhWSUpjcy9MUTQ2MWtyYklRd1VB?= =?utf-8?B?SVRMU3RqZnNWRUNHdUE2ZUFHQlBPc1V5dXlDTmJLMVhReXVkWXBTQUV4Q2Ro?= =?utf-8?B?ZFlFOW5tZDM0ZWh1eE1sZ3ozeVJENXBtenptN251b21PZ28yUGZMaDdGOHps?= =?utf-8?B?VHduempuL0dvM1UxdXdvcnBiNHNkaGZiQXVRbzc3VlFralBGaTdwQU9FWWtG?= =?utf-8?B?anhROGdHNEw1UzJ2YkdvWDRaMXFkQUF1YWc0UG5BK0p5bHBQTkxLMyt0QlYr?= =?utf-8?B?emhvMHdKeHhHQmJlR2lwWTRHQkVHTHFRelEvRHoyVGlENDAxQzEzWER1ZG1U?= =?utf-8?B?OXNlVlk3YTJPOUNpV3llQ2htMEV0MkduSGVXNW9rTzF3dVlTL1dJTmErZnRD?= =?utf-8?B?SzVZbmROWmx6Umg2NkZLQWkzZnFPRytWa1lBRWdHTnRIMko4RGhXM0h4SEdD?= =?utf-8?B?RmJ6blRweGFsSnUwTWsvU2YxbjZadHJyZXhVUGwrQlpXY0RqZHdqVkkvbTAy?= =?utf-8?B?RE1OVFZ1WnJ4LyszSHFZUUlzRktZVFl3L3VpQ3ZCL0lqNVN2dllOTGlrY3Ry?= =?utf-8?B?azVqTzRnNzQrTjVEcGlndGttc1ZQTEg0VE9vazREZkNsdEFndTFqandRZDNj?= =?utf-8?B?MTBUL0JBUmhhVXFCOFdUN0srbmhyNWxIaDZrYjBEY0hwbmxaMjRkR21TcEp5?= =?utf-8?B?Rmg0cVpkQXU4cm84OVBLcW5wMEllTHlaQkU3ZlJURldkWXNOOFVXeXBZWEM3?= =?utf-8?B?Nlp4SGxCeW1BK0JzcnhQSGNiUGNSSXcxaW85ZmljU2RNcVprMkplalFpeUZu?= =?utf-8?B?OG9NQnVkREFNUllIQjNRSmQraElsM2Zlaml6b2JpaFh4MXBXdUZRTUNZSnd6?= =?utf-8?B?MW5kb2tLVVRFVllVa2xtVVhmQ1AzUkFOeGtLWmp1aStxUFFpY2FpT3RtY0hQ?= =?utf-8?B?UjYyd29keUFCbFdrWDhzNHgzL1I0S285MUsyT2RMbUROa2NzbUhUcDBKZ3hW?= =?utf-8?B?d2trS1R3U3ErZ1pNRS8rMzF6YzNZUVY1TlNnOUY2dk9oWWN1N0RnZmFpVXdQ?= =?utf-8?B?dVBhVzllZDNpU0s4R21tYnBwdUMrRTJWZEkxMS9WSldFVWhBSmZPTUNkTGVi?= =?utf-8?B?WUl4aGE0bGZmbXE2a0hCY3dvaTF6UEdmOU1uZFRtZ0R2aXBoVEFRdGNGMDZi?= =?utf-8?B?cVkvS0dQdUhjSDNrVVBjZHQ5cFl3bVZIWHNTSmxCMGtYTm9SalJqcmNPK1Fm?= =?utf-8?B?VUE4NEp5ZEtsbWZqVE1ZZjRTRVBucW5LR0VsUWdXVTJneE1mTlFxQTc3OVRD?= =?utf-8?B?eU0yY0t6bHdwT0Z0V0s0blFtNFZZTjdDb2c1eXJxc0ZpUXVCRytmUlA5L1kz?= =?utf-8?B?WXMwQVpLdlhBaGZ6MjExV2o1MWxVdHFnY2hnK0lQNmVudHB2TXhvRGxnWVYv?= =?utf-8?B?dzZVNTZ5b1dtbDRuWDhLWDEyancxUit2SkRSTkwwb3BVd0JQMDRtSHFqU2RE?= =?utf-8?Q?cvUtNWv/SiXj13Ms=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1ba6d2d-74e0-4c4b-5ba9-08da2d21199f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 16:22:21.5109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jm14pvaihxrgEGVmJMuGNjRBPIDdNMYaLzIiF+l0yfabXQxsCUJA5GvCUmF7a/FrCTVmitDKsDd4HyuFK4Iprw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4367 On Tue, May 03, 2022 at 04:37:29PM +0200, Jan Beulich wrote: > On 03.05.2022 12:25, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote: > >> As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, > >> similar to flush") there's no need anymore to have a loop here. > >> > >> Suggested-by: Roger Pau Monné > >> Signed-off-by: Jan Beulich > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > > I wonder whether we should have a macro to ignore returns from > > __must_check attributed functions. Ie: > > > > #define IGNORE_RETURN(exp) while ( exp ) break; > > > > As to avoid confusion (and having to reason) whether the usage of > > while is correct. I always find it confusing to assert such loop > > expressions are correct. > > I've been considering some form of wrapper macro (not specifically > the one you suggest), but I'm of two minds: On one hand I agree it > would help readers, but otoh I fear it may make it more attractive > to actually override the __must_check (which really ought to be an > exception). Well, I think anyone reviewing the code would realize that the error is being ignored, and hence check that this is actually intended. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 03 16:39:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 16:39:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319792.540180 (Exim 4.92) (envelope-from ) id 1nlvYQ-00086W-V3; Tue, 03 May 2022 16:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319792.540180; Tue, 03 May 2022 16:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvYQ-00086P-Ra; Tue, 03 May 2022 16:39:14 +0000 Received: by outflank-mailman (input) for mailman id 319792; Tue, 03 May 2022 16:39:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlvYP-00086J-Ek for xen-devel@lists.xenproject.org; Tue, 03 May 2022 16:39:13 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f2f7875-caff-11ec-a406-831a346695d4; Tue, 03 May 2022 18:39:12 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so2754104pjb.3 for ; Tue, 03 May 2022 09:39:11 -0700 (PDT) Received: from [127.0.1.1] ([8.34.116.185]) by smtp.gmail.com with ESMTPSA id m9-20020a17090a858900b001d9b7fa9562sm1559200pjn.28.2022.05.03.09.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 09:39:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f2f7875-caff-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=s39mE0kiqCYA7ZYSMO88r6nrLoSeKkE/K4dp3BvGwGs=; b=pGDpCf7sl1d7573gjTTpqwkm3SiLycRrYLR/Cpm0xghxjpDf3AYMtstNaQt6JhXwCj hQ35tsdAS9xUuNcQ6bjTAIO4jrWGURYFn6WniUxLx9leI8Us/ZQXxmUsx5sXqR+3SMFs NPtnD8cP+Vrfqw+JIy3zA370Pyvn+VSXvM3gc7wLfoXTetostms9mgjy7Euc3hVJAm4j a9n45bGAUG8eOYOtc2pRDLYRKouGSmmTKZVBKYAG6yGnvzNVe7ulVhqBTMV0jNCtQJ1b eh8fwFdSJCS0763Fc+Es4Igf8he/A1M8/7QNTfbxn1mM2JdiBuUfp0c3rzGlnMqDUeCY VcJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=s39mE0kiqCYA7ZYSMO88r6nrLoSeKkE/K4dp3BvGwGs=; b=XSev3313wqZIYs4YJg1AMgqWhQQDdq0bhepoocHVr2ncnVnpB4nrH5bg5eetk7b28F zuyNtF3ce/dJc3KPh2qLBSomu+3QcmwKMrY/NS/CoibvZGuHd7hEVvsWygs8MXxGejek Rnb/Euy7xeU6wDm0FaAWyIIXsxv7g46zD99xuo/rbWS//4RThrrohvEhJI9Q9lmBIRvY K5RmCPzNCdai3hjHqYl23EF9qmdJF6t5wJKQJncp6CMvFy5eisL4ceq11gR+WQxPp3sI Y5cNxywX+5pwjHOTHUCTuJfx434zZy97ZMkI4i84YDz0Bar4dQZ+RmTOWZ2SzpbLV2NG 01zQ== X-Gm-Message-State: AOAM533+6sLpmkVOFjuz66QGHUHpe0unxHPPf6eqONi4wxVhSQdtblsL UGtO8RD72JH3BSel2wM2I6vm1A== X-Google-Smtp-Source: ABdhPJynf+YKk08yAhS/p4BXstboFDeyZsD4FTBMM24xr+KLv+BRsvUdLzF1UAPk9hKAVzsu2Q8whQ== X-Received: by 2002:a17:90a:9901:b0:1cb:aa19:5eee with SMTP id b1-20020a17090a990100b001cbaa195eeemr5645991pjp.158.1651595950265; Tue, 03 May 2022 09:39:10 -0700 (PDT) From: Jens Axboe To: Christoph Hellwig Cc: mst@redhat.com, linux-s390@vger.kernel.org, sth@linux.ibm.com, martin.petersen@oracle.com, dm-devel@redhat.com, hoeppner@linux.ibm.com, linux-nvme@lists.infradead.org, richard@nod.at, josef@toxicpanda.com, virtualization@lists.linux-foundation.org, snitzer@kernel.org, roger.pau@citrix.com, linux-um@lists.infradead.org, linux-block@vger.kernel.org, song@kernel.org, nbd@other.debian.org, linux-raid@vger.kernel.org, johannes@sipsolutions.net, haris.iqbal@ionos.com, xen-devel@lists.xenproject.org, jasowang@redhat.com, jinpu.wang@ionos.com In-Reply-To: <20220418045314.360785-1-hch@lst.de> References: <20220418045314.360785-1-hch@lst.de> Subject: Re: fix and cleanup discard_alignment handling Message-Id: <165159594780.2557.1712299203175316151.b4-ty@kernel.dk> Date: Tue, 03 May 2022 10:39:07 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 18 Apr 2022 06:53:03 +0200, Christoph Hellwig wrote: > the somewhat confusing name of the discard_alignment queue limit, that > really is an offset for the discard granularity mislead a lot of driver > authors to set it to an incorrect value. This series tries to fix up > all these cases. > > Diffstat: > arch/um/drivers/ubd_kern.c | 1 - > drivers/block/loop.c | 1 - > drivers/block/nbd.c | 3 --- > drivers/block/null_blk/main.c | 1 - > drivers/block/rnbd/rnbd-srv-dev.h | 2 +- > drivers/block/virtio_blk.c | 7 ++++--- > drivers/block/xen-blkback/xenbus.c | 4 ++-- > drivers/md/dm-zoned-target.c | 2 +- > drivers/md/raid5.c | 1 - > drivers/nvme/host/core.c | 1 - > drivers/s390/block/dasd_fba.c | 1 - > 11 files changed, 8 insertions(+), 16 deletions(-) > > [...] Applied, thanks! [01/11] ubd: don't set the discard_alignment queue limit commit: 07c6e92a8478770a7302f7dde72f03a5465901bd [02/11] nbd: don't set the discard_alignment queue limit commit: 4a04d517c56e0616c6f69afc226ee2691e543712 [03/11] null_blk: don't set the discard_alignment queue limit commit: fb749a87f4536d2fa86ea135ae4eff1072903438 [04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits commit: 62952cc5bccd89b76d710de1d0b43244af0f2903 [05/11] dm-zoned: don't set the discard_alignment queue limit commit: 44d583702f4429763c558624fac763650a1f05bf [06/11] raid5: don't set the discard_alignment queue limit commit: 3d50d368c92ade2f98a3d0d28b842a57c35284e9 [07/11] dasd: don't set the discard_alignment queue limit commit: c3f765299632727fa5ea5a0acf118665227a4f1a [08/11] loop: remove a spurious clear of discard_alignment commit: 4418bfd8fb9602d9cd8747c3ad52fdbaa02e2ffd [09/11] nvme: remove a spurious clear of discard_alignment commit: 4e7f0ece41e1be8f876f320a0972a715daec0a50 [10/11] rnbd-srv: use bdev_discard_alignment commit: 18292faa89d2bff3bdd33ab9c065f45fb6710e47 [11/11] xen-blkback: use bdev_discard_alignment commit: c899b23533866910c90ef4386b501af50270d320 Best regards, -- Jens Axboe From xen-devel-bounces@lists.xenproject.org Tue May 03 17:09:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319799.540190 (Exim 4.92) (envelope-from ) id 1nlw1q-0003Mi-EV; Tue, 03 May 2022 17:09:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319799.540190; Tue, 03 May 2022 17:09:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlw1q-0003Mb-Bf; Tue, 03 May 2022 17:09:38 +0000 Received: by outflank-mailman (input) for mailman id 319799; Tue, 03 May 2022 17:09:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlw1o-0003MV-S3 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:09:36 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cebfe149-cb03-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:09:35 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id bu29so31457985lfb.0 for ; Tue, 03 May 2022 10:09:35 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id f15-20020a19ae0f000000b0046ba69295e6sm991362lfc.1.2022.05.03.10.09.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 10:09:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cebfe149-cb03-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zJs4+MMRWZw/5d9ErRntMPYDHkeYPubfbBu5PoJ/OL4=; b=M8YnGgqOtzjrYDRuAmiWTIN0idz0aB1XK23Uw+aNk4CfbYy5aKVITKbBOMASf1yAua BgpgVejpIWt8F6mYbpZ1fCm1sjp9iu2AjIo/0vd3sBkasOA0RrTEuUAJ6mQOWQqVeq/O BqSxjkrx9WDaAFcutE4wvDiQqMrbSgdyiQ0TOVxxXqv5w8GeoXBgF7aZ+MxcSzk15Y8e +1W9wBTeyxRmh+fB0IFa3uURqquKs04Bl4ddkmB4yTgcmom0ydsORiv+WE2n/M+E59Wk su6MC/cBHQzbjTguGmt0qezOEvsqpcxwEsxAmk4LvxoqWGtGAocx94WxhC2Ls1TnRWy9 06JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zJs4+MMRWZw/5d9ErRntMPYDHkeYPubfbBu5PoJ/OL4=; b=Iw1ilpernMvS86V92yRJxO5SE2aNF8QfLDC4/woc53W9x0xoDWknNzqt+jDVw4+RSq AOkbYDY6+IZ8C1WcAV6BoYbmzIxTpmE5KqFbUnQ1fwu3s5BIWNA8Z3U5DVcecdHddjnA R5NThQc058yIz67j7yx2KrjO9/JiIUQNqUXWx3f0RK/0VuCOWThI0aMhzioLik9M3LZU smsmikqhmASsdA/W10V17QzKQnrJDtWnlMUzh+XQJVO8Zbeme9WkZkxRQdnM8D0AxCsJ RMb+lnN9NfX4z5Nb9Cea+FIPs/hFGXzCwp/RwWvRfizoAZnBW2Fny3Zt3psUjiH3ihHk ZtIQ== X-Gm-Message-State: AOAM530feIaWcZmUROggU9sJo0TwhyZr80FS82FkbNGnd8MzdRuMSEHn D3NW6ZuprIJsV7braVtbV+4= X-Google-Smtp-Source: ABdhPJzv6H6M8/xo8EzW/O4pDdx28m5jcypFmJdLpM4hdPg4n724T8DEh4HH50LEA43Trj5o8JzjrQ== X-Received: by 2002:ac2:4add:0:b0:471:fc6d:a71d with SMTP id m29-20020ac24add000000b00471fc6da71dmr12040907lfp.350.1651597775052; Tue, 03 May 2022 10:09:35 -0700 (PDT) Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Rob Herring Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Tue, 3 May 2022 20:09:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 03.05.22 00:59, Rob Herring wrote: Hello Rob > On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Introduce Xen specific binding for the virtualized device (e.g. virtio) >> to be used by Xen grant DMA-mapping layer in the subsequent commit. >> >> This binding indicates that Xen grant mappings scheme needs to be >> enabled for the device which DT node contains that property and specifies >> the ID of Xen domain where the corresponding backend resides. The ID >> (domid) is used as an argument to the grant mapping APIs. >> >> This is needed for the option to restrict memory access using Xen grant >> mappings to work which primary goal is to enable using virtio devices >> in Xen guests. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> Changes RFC -> V1: >> - update commit subject/description and text in description >> - move to devicetree/bindings/arm/ >> --- >> .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> new file mode 100644 >> index 00000000..ef0f747 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific binding for the virtualized device (e.g. virtio) >> + >> +maintainers: >> + - Oleksandr Tyshchenko >> + >> +select: true > Do we really need to support this property everywhere? From my understanding - yes. As, I think, any device node describing virtulized device in the guest device tree can have this property.  Initially (in the RFC series) the "solution to restrict memory access using Xen grant mappings" was virtio-specific. Although the support of virtio is a primary target of this series, we decided to generalize this work and expand it to any device [1]. So the Xen grant mappings scheme (this property to be used for) can be theoretically used for any device emulated by the Xen backend. >> + >> +description: >> + This binding indicates that Xen grant mappings scheme needs to be enabled >> + for that device and specifies the ID of Xen domain where the corresponding >> + device (backend) resides. This is needed for the option to restrict memory >> + access using Xen grant mappings to work. >> + >> +properties: >> + xen,dev-domid: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The domid (domain ID) of the domain where the device (backend) is running. >> + >> +additionalProperties: true >> + >> +examples: >> + - | >> + virtio_block@3000 { > virtio@3000 ok, will change > >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The device is located in Xen domain with ID 1 */ >> + xen,dev-domid = <1>; > This fails validation: > > Documentation/devicetree/bindings/arm/xen,dev-domid.example.dtb: virtio_block@3000: xen,dev-domid: [[1]] is not of type 'object' > From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/virtio/mmio.yaml Thank you for pointing this out, my fault, I haven't "properly" checked this before. I think, we need to remove "compatible = "virtio,mmio"; here diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml index 2daa8aa..d2f2140 100644 --- a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml @@ -28,7 +28,7 @@ additionalProperties: true  examples:    - |      virtio_block@3000 { -            compatible = "virtio,mmio"; +            /* ... */              reg = <0x3000 0x100>;              interrupts = <41>; > > The property has to be added to the virtio/mmio.yaml schema. If it is > not needed elsewhere, then *just* add the property there. As I described above, the property is not virtio specific and can be used for any virtualized device for which Xen grant mappings scheme needs to be enabled (xen-grant DMA-mapping layer). [1] https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2204181202080.915916@ubuntu-linux-20-04-desktop/ > > Rob -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue May 03 17:21:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:21:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319805.540202 (Exim 4.92) (envelope-from ) id 1nlwDQ-0005eW-GM; Tue, 03 May 2022 17:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319805.540202; Tue, 03 May 2022 17:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwDQ-0005eP-By; Tue, 03 May 2022 17:21:36 +0000 Received: by outflank-mailman (input) for mailman id 319805; Tue, 03 May 2022 17:21:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwDO-0005eD-N0; Tue, 03 May 2022 17:21:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwDO-0008DJ-Iz; Tue, 03 May 2022 17:21:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwDO-0000dv-2A; Tue, 03 May 2022 17:21:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlwDO-0000Sz-1f; Tue, 03 May 2022 17:21:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WRBMcuARX4ARpFwbM9oY5+mZv52oIY77rUnMyzAy6PQ=; b=Rz0TiDcclxpu8l2WzZATCHIdZs 4hxjAa1hGdQELExwN2JZiHOKTVQ/2tnD0whdyK/KFuPmoUMlU+2zuJ52HdXnE4b3t7F4/lVhdMCVQ KIitQPEgN30kCw9RBL+glFFVk4S8Qf008AvytPF3lq80/jv+CRhQKMMCwd3mwvvOEo9U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170052: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 17:21:34 +0000 flight 170052 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170052/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 784 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 17:26:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319813.540213 (Exim 4.92) (envelope-from ) id 1nlwHt-0006JK-2p; Tue, 03 May 2022 17:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319813.540213; Tue, 03 May 2022 17:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHs-0006JD-Ut; Tue, 03 May 2022 17:26:12 +0000 Received: by outflank-mailman (input) for mailman id 319813; Tue, 03 May 2022 17:26:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHr-0006J7-TG for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:26:11 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20043ed7-cb06-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:26:11 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id p10so31450603lfa.12 for ; Tue, 03 May 2022 10:26:11 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id x18-20020a2e9dd2000000b0024f275bb06asm1395134ljj.3.2022.05.03.10.26.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 May 2022 10:26:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20043ed7-cb06-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=umOQGchKDeLfvuk7Ji346IJN/L3nIUwISV47GPcVMhE=; b=T7RaQs+80EORAFR76+IMwfgrxBJGUE91BqYOUhT404Onmft+qauRAB/gQ/yuAkFHCT G4+nJ2hPwc8VA7ybyq5XbiTlbUa48XueYSSo4fcTOGaFtqRUM21RT+hoBX5yhEuFShGi Kg580saW2muxAi+3w0o3K6Jl/AKIOSqO08hsAxGM7ZHZdslGVCOv1SuxsDfD5ryS8Dp0 4xxAcvOid95eKNPzMKSenptlH68a0I5Bxa0ImqJ1pYbN69E4fsY3Z4sLGCujuOzKdiAo lYsnvAAE+LI0qC/42/NCCfNf5yYYlDZscoZj0g3TfwH/u8PCAcfvDZOOLa39p2u6w6P8 HWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=umOQGchKDeLfvuk7Ji346IJN/L3nIUwISV47GPcVMhE=; b=l7ucnGDf+ynuNlRWT7LwnJ1J6ZXXrBjy5hvWRefddPhqocmiCpfYgjfsZtnVJ3aU8e ON9WLrv2bT9hm1+AQy19k3XfFAuCWWSKMJRyd814+JIPZ4CTKysmJxfIDVCoIEBMxGwO bqSri/yUYQ/ZXqmXmhQO3bagYqDkSXgA9MtjTuoz/DQM6Ozg92FGSm+fvV79SkJ6xsYE wvKgIi6Y9p9rLXUMz3YSDNW0bOVN0pchXmVPjtWWoYyPtN4B+dtl1ykN/+GFZwBLLFXV /brVKkFoCiogj0RwQ1qaHWp0Btt1HwVrMYHIqZdWGny05pkCen5B+3gB8+/Spm3aKuLI QZkA== X-Gm-Message-State: AOAM533AcOl5FYDVnQzrhCl5lWMFbDtK+bIescCgtNcixzhKWrDeGn80 0Ytf17CXrRD5Mebpu1lMuKJPCUtii5c= X-Google-Smtp-Source: ABdhPJx2oNncq4yrPTUffO2Fx80aFKy+L4yK4rjO+SaKcJGTvB1KLiN/aaZ7Yb7SO9+g7efJ/YfL7g== X-Received: by 2002:a05:6512:398b:b0:472:5b79:32f5 with SMTP id j11-20020a056512398b00b004725b7932f5mr9973401lfu.636.1651598769536; Tue, 03 May 2022 10:26:09 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen , Kaly Xin , Jiamei Xie , Henry Wang , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH V8 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm") Date: Tue, 3 May 2022 20:26:01 +0300 Message-Id: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm. The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio enabling work. You can find previous discussions at [2]. Patch series [3] is based on recent "staging" branch (fa6dc0879ffd3dffffaea2837953c7a8761a9ba0 page_alloc: assert IRQs are enabled in heap alloc/free) and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio based virtio-disk backend [4] running in Dom0 (or Driver domain) and unmodified Linux Guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy' use-cases work properly. Any feedback/help would be highly appreciated. [1] https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/ [2] https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html https://lore.kernel.org/xen-devel/1621626361-29076-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1638982784-14390-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/ [3] https://github.com/otyshchenko1/xen/commits/libxl_virtio3 [4] https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant Julien Grall (1): libxl: Introduce basic virtio-mmio support on Arm Oleksandr Tyshchenko (1): libxl: Add support for Virtio disk configuration docs/man/xl-disk-configuration.5.pod.in | 38 +- tools/golang/xenlight/helpers.gen.go | 8 + tools/golang/xenlight/types.gen.go | 18 + tools/include/libxl.h | 7 + tools/libs/light/libxl_arm.c | 118 +++- tools/libs/light/libxl_device.c | 62 +- tools/libs/light/libxl_disk.c | 136 ++++- tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 16 + tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_utils.c | 2 + tools/libs/util/libxlu_disk_l.c | 959 +++++++++++++++--------------- tools/libs/util/libxlu_disk_l.h | 2 +- tools/libs/util/libxlu_disk_l.l | 9 + tools/xl/xl_block.c | 11 + xen/include/public/arch-arm.h | 7 + 16 files changed, 914 insertions(+), 482 deletions(-) -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 03 17:26:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:26:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319814.540224 (Exim 4.92) (envelope-from ) id 1nlwHz-0006j0-9v; Tue, 03 May 2022 17:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319814.540224; Tue, 03 May 2022 17:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHz-0006it-6l; Tue, 03 May 2022 17:26:19 +0000 Received: by outflank-mailman (input) for mailman id 319814; Tue, 03 May 2022 17:26:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHx-0006J7-6v for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:26:17 +0000 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [2a00:1450:4864:20::22b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 231db891-cb06-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:26:16 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id g16so17388079lja.3 for ; Tue, 03 May 2022 10:26:16 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id x18-20020a2e9dd2000000b0024f275bb06asm1395134ljj.3.2022.05.03.10.26.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 May 2022 10:26:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 231db891-cb06-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f65g7NWnRsWANdfet5Rqx3TxwkiQFjNC9zdZg7FLBDU=; b=SYeHmTXCVvsqvobnc8rIqi9fwFmANSJZzvNBqSCU3btsfPZYpY1/ZdgIw6Rkr3/0/K RE5qwDZm4ArUQVR3XtbEMDgnraaxN7Gjd5tcwKbshzJ9NPIHWZ+pdFKDB5lhm1JBJ3rk aGQVwJ8XWuT/zM1gaBYl7KN4oog1qhbFD+STauhec9IGldIt8XK4Ls0Cha291Kk6WoMJ VHOAiQ9eqmn2g40WqSmj0XRWQAceqp50gsN9ybL3rTp+VMGqcKGhA8/gvnh+6BBk4Zv/ rlSJD5eh+d3xr/sVbtFIzd70cK+jG5LS7BUp5hn79CxA7fdgzGtrU4wcJmlqs9BbfTJf mKAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f65g7NWnRsWANdfet5Rqx3TxwkiQFjNC9zdZg7FLBDU=; b=AN+ZlKZFUabhz/BbAQv8dZeve1YRknMn/FRMQ+2c9rSwcBG3IQhkR0Ss02tE9HUTFp o3uAuqWjJqBsGYF/wHSYPBNxLK+Ce0cm5RfqULRWNn8Y80ROeHMR42pK8rEJLmpOxoZx udZ7waRCFLEeYp6n76oAKgRKEL5Z2jNgGrbl3opAEG1c9+ycPnR/CdVcwOkAPTAvJ31H O9owTCPVqjJSIqOnw/t/Bufda5U3sW4a/ipYHjL5YoxGaMdf7zoMXqR117LJdrf3ghkw t58nVHDkpN+77lK2dgSLw7GRRiero0Fr2VRH7LjVekOi/OTPgRHSKj1M/T7QdvoY91ec FV0Q== X-Gm-Message-State: AOAM532bk6NIBquZsoG3gaJLcOu4r/bWM72THAMyk5ZrVDkYewvhfBvQ 4WdZHxl/78X07bbUldeBlnfxyWz4Sws= X-Google-Smtp-Source: ABdhPJzLkBZTJwKS1QtEVBgQdPUcpKoo+faBrTFSXDQzye/esbr7nKb7add+WCgeHTd2sf84IZiWSw== X-Received: by 2002:a05:651c:211b:b0:24f:4da2:6e3c with SMTP id a27-20020a05651c211b00b0024f4da26e3cmr9388996ljq.37.1651598774845; Tue, 03 May 2022 10:26:14 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm Date: Tue, 3 May 2022 20:26:03 +0300 Message-Id: <1651598763-12162-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Julien Grall This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- Please note, this is a split/cleanup/hardening of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Changes RFC -> V1: - was squashed with: "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way" "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node" "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT" - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h Changes V1 -> V2: - update the author of a patch Changes V2 -> V3: - no changes Changes V3 -> V4: - no changes Changes V4 -> V5: - split the changes, change the order of the patches - drop an extra "virtio" configuration option - update patch description - use CONTAINER_OF instead of own implementation - reserve ranges for Virtio MMIO params and put them in correct location - create helpers to allocate Virtio MMIO params, add corresponding sanity-сhecks - add comment why MMIO size 0x200 is chosen - update debug print - drop Wei's T-b Changes V5 -> V6: - rebase on current staging Changes V6 -> V7: - rebase on current staging - add T-b and R-b tags - update according to the recent changes to "libxl: Add support for Virtio disk configuration" Changes V7 -> V8: - drop T-b and R-b tags - make virtio_mmio_base/irq global variables to be local in libxl__arch_domain_prepare_config() and initialize them at the beginning of the function, then rework alloc_virtio_mmio_base/irq() to take a pointer to virtio_mmio_base/irq variables as an argument - update according to the recent changes to "libxl: Add support for Virtio disk configuration" --- tools/libs/light/libxl_arm.c | 118 +++++++++++++++++++++++++++++++++++++++++- xen/include/public/arch-arm.h | 7 +++ 2 files changed, 123 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index eef1de0..37403a2 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -8,6 +8,46 @@ #include #include +/* + * There is no clear requirements for the total size of Virtio MMIO region. + * The size of control registers is 0x100 and device-specific configuration + * registers starts at the offset 0x100, however it's size depends on the device + * and the driver. Pick the biggest known size at the moment to cover most + * of the devices (also consider allowing the user to configure the size via + * config file for the one not conforming with the proposed value). + */ +#define VIRTIO_MMIO_DEV_SIZE xen_mk_ullong(0x200) + +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc, uint64_t *virtio_mmio_base) +{ + uint64_t base = *virtio_mmio_base; + + /* Make sure we have enough reserved resources */ + if ((base + VIRTIO_MMIO_DEV_SIZE > + GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) { + LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n", + base); + return 0; + } + *virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE; + + return base; +} + +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq) +{ + uint32_t irq = *virtio_mmio_irq; + + /* Make sure we have enough reserved resources */ + if (irq > GUEST_VIRTIO_MMIO_SPI_LAST) { + LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n", irq); + return 0; + } + (*virtio_mmio_irq)++; + + return irq; +} + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -26,8 +66,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, { uint32_t nr_spis = 0; unsigned int i; - uint32_t vuart_irq; - bool vuart_enabled = false; + uint32_t vuart_irq, virtio_irq = 0; + bool vuart_enabled = false, virtio_enabled = false; + uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; + uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; /* * If pl011 vuart is enabled then increment the nr_spis to allow allocation @@ -39,6 +81,30 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, vuart_enabled = true; } + for (i = 0; i < d_config->num_disks; i++) { + libxl_device_disk *disk = &d_config->disks[i]; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); + if (!disk->base) + return ERROR_FAIL; + + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); + if (!disk->irq) + return ERROR_FAIL; + + if (virtio_irq < disk->irq) + virtio_irq = disk->irq; + virtio_enabled = true; + + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, + disk->vdev, disk->irq, disk->base); + } + } + + if (virtio_enabled) + nr_spis += (virtio_irq - 32) + 1; + for (i = 0; i < d_config->b_info.num_irqs; i++) { uint32_t irq = d_config->b_info.irqs[i]; uint32_t spi; @@ -58,6 +124,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + /* The same check as for vpl011 */ + if (virtio_enabled && + (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) { + LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq); + return ERROR_FAIL; + } + if (irq < 32) continue; @@ -787,6 +860,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, return 0; } + +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + gic_interrupt intr; + /* Placeholder for virtio@ + a 64-bit number + \0 */ + char buf[24]; + + snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base); + res = fdt_begin_node(fdt, buf); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,mmio"); + if (res) return res; + + res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + 1, base, VIRTIO_MMIO_DEV_SIZE); + if (res) return res; + + set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING); + res = fdt_property_interrupts(gc, fdt, &intr, 1); + if (res) return res; + + res = fdt_property(fdt, "dma-coherent", NULL, 0); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -988,6 +1094,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; + unsigned int i; const libxl_version_info *vers; const struct arch_info *ainfo; @@ -1094,6 +1201,13 @@ next_resize: if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); + for (i = 0; i < d_config->num_disks; i++) { + libxl_device_disk *disk = &d_config->disks[i]; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + } + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index ab05fe1..c8b6058 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t; /* Physical Address Space */ +/* Virtio MMIO mappings */ +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x00100000) + /* * vGIC mappings: Only one set of mapping is used by the guest. * Therefore they can overlap. @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t; #define GUEST_VPL011_SPI 32 +#define GUEST_VIRTIO_MMIO_SPI_FIRST 33 +#define GUEST_VIRTIO_MMIO_SPI_LAST 43 + /* PSCI functions */ #define PSCI_cpu_suspend 0 #define PSCI_cpu_off 1 -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 03 17:26:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:26:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319815.540230 (Exim 4.92) (envelope-from ) id 1nlwHz-0006qQ-Re; Tue, 03 May 2022 17:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319815.540230; Tue, 03 May 2022 17:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHz-0006ov-MQ; Tue, 03 May 2022 17:26:19 +0000 Received: by outflank-mailman (input) for mailman id 319815; Tue, 03 May 2022 17:26:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwHy-0006J7-Ba for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:26:18 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22c1ebfa-cb06-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:26:15 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id x17so31449987lfa.10 for ; Tue, 03 May 2022 10:26:15 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id x18-20020a2e9dd2000000b0024f275bb06asm1395134ljj.3.2022.05.03.10.26.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 May 2022 10:26:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22c1ebfa-cb06-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oCeM8I7zzzz3AmE4jt0yG37E7+GjReoQWX9Nj8jYMW8=; b=idcbzWo9S+LjNTq5uV4l6YnMXq8jhe6E86vZ77kuRXs4LM9cnjdb+MgGLCrUhB/96r j1OaiANz0rN+BPWPQ5rcT9Vz6ZWwirw8ZI7tar8P+nE53KdrvrEcZO+CK9AjbP75K+RU avTeYlmYQ28sLuQnspD9Rc4QMJZ8dKlgVZUFUaK7WwkvM8Dr7PXzGOsq/eUdp075nVVJ FD8bV9M2StFStYzfEpXfKWBLXPlF0dKJ9d5rO3RiEI2zbX2G3gVeCGUdtGDvrB+1Z7aF zQD3NT3sQKgC8qBGXvrbFXXvoSz97O5TsRVTrC+EmqbswGX1WPkri2ayy5omJ3cd7Ue4 OZlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oCeM8I7zzzz3AmE4jt0yG37E7+GjReoQWX9Nj8jYMW8=; b=QnYq+GVgL3M88c8MkQXGKVeq7M3mVB/Ku3bV17ROyWT1vDzUPN54JB/0hNePBTyiBa aVkYEto5dFOwm25UlRxWNe52lfDaWwuOEvFO0zOAOjhSFt1OVHroml4ie4tO/+zaZZFK U7XdacTmrBgt3szbnW0vsw5BrtlmOkkMfjQoW/wQgk4adkZ2alxTzCfY/cWhGw6VuyNr tbC/M9FAmhGZgpztN/AtJADn0VAlN5NLw/d/2JiFW1vFvOyCH4797Ms7l9W0Yfmv1vDM IOgq9iLXm9UrLLChRseOVpXS/KzBuiFn/TDXbS+sZmngD0dtXmjTx7DKi7IXYASGBrGb okpA== X-Gm-Message-State: AOAM531VUinG5k6R0jHK0T4NmCxuYo3toxvhrprww4wvdYfRG7AVDeHC 2TAiVRwmK2NoGZ+AqIL3pTQDUHhy+3E= X-Google-Smtp-Source: ABdhPJzHIry3dtrPqLevmS1PZnDQATD1DZK/mwzFsDadENKGvkNiqvflI3famx1JPUgATpkJGgCm2Q== X-Received: by 2002:a05:6512:39c1:b0:44a:e25d:47fd with SMTP id k1-20020a05651239c100b0044ae25d47fdmr11963935lfu.580.1651598772759; Tue, 03 May 2022 10:26:12 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH V8 1/2] libxl: Add support for Virtio disk configuration Date: Tue, 3 May 2022 20:26:02 +0300 Message-Id: <1651598763-12162-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - no changes Changes V1 -> V2: - rebase according to the new location of libxl_virtio_disk.c Changes V2 -> V3: - no changes Changes V3 -> V4: - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT Changes V4 -> V5: - split the changes, change the order of the patches - update patch description - don't introduce new "vdisk" configuration option with own parsing logic, re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk - introduce "virtio" flag and document it's usage - add LIBXL_HAVE_DEVICE_DISK_VIRTIO - update libxlu_disk_l.[ch] - drop num_disks variable/MAX_VIRTIO_DISKS - drop Wei's T-b Changes V5 -> V6: - rebase on current staging - use "%"PRIu64 instead of %lu for disk->base in device_disk_add() - update *.gen.go files Changes V6 -> V7: - rebase on current staging - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description - rework significantly to support more flexible configuration and have more generic basic implementation for being able to extend that for other use-cases (virtio-pci, qemu, etc). Changes V7 -> V8: - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description and comments in the code - use "specification" config option instead of "protocol" - update libxl_types.idl and code according to new fields in libxl_device_disk --- docs/man/xl-disk-configuration.5.pod.in | 38 +- tools/golang/xenlight/helpers.gen.go | 8 + tools/golang/xenlight/types.gen.go | 18 + tools/include/libxl.h | 7 + tools/libs/light/libxl_device.c | 62 +- tools/libs/light/libxl_disk.c | 136 ++++- tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 16 + tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_utils.c | 2 + tools/libs/util/libxlu_disk_l.c | 959 +++++++++++++++--------------- tools/libs/util/libxlu_disk_l.h | 2 +- tools/libs/util/libxlu_disk_l.l | 9 + tools/xl/xl_block.c | 11 + 14 files changed, 791 insertions(+), 480 deletions(-) diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in index 71d0e86..487ffef 100644 --- a/docs/man/xl-disk-configuration.5.pod.in +++ b/docs/man/xl-disk-configuration.5.pod.in @@ -232,7 +232,7 @@ Specifies the backend implementation to use =item Supported values -phy, qdisk +phy, qdisk, other =item Mandatory @@ -244,11 +244,13 @@ Automatically determine which backend to use. =back -This does not affect the guest's view of the device. It controls -which software implementation of the Xen backend driver is used. +It controls which software implementation of the backend driver is used. +Depending on the "specification" option this may affect the guest's view +of the device. Not all backend drivers support all combinations of other options. -For example, "phy" does not support formats other than "raw". +For example, "phy" and "other" do not support formats other than "raw" and +"other" does not support specifications other than "virtio". Normally this option should not be specified, in which case libxl will automatically determine the most suitable backend. @@ -344,8 +346,36 @@ can be used to disable "hole punching" for file based backends which were intentionally created non-sparse to avoid fragmentation of the file. +=item B=I + +=over 4 + +=item Description + +Specifies the communication protocol (specification) to use for the chosen +"backendtype" option + +=item Supported values + +xen, virtio + +=item Mandatory + +No + +=item Default value + +xen + =back +Besides forcing toolstack to use specific backend implementation, this also +affects the guest's view of the device. For example, "virtio" requires +Virtio frontend driver (virtio-blk) to be used. Please note, the virtual +device (vdev) is not passed to the guest in that case, but it still must be +specified for the internal purposes. + +=back =head1 COLO Parameters diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff1..00f10b9 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1751,6 +1751,10 @@ x.DirectIoSafe = bool(xc.direct_io_safe) if err := x.DiscardEnable.fromC(&xc.discard_enable);err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +x.Specification = DiskSpecification(xc.specification) +x.Transport = DiskTransport(xc.transport) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) if err := x.ColoEnable.fromC(&xc.colo_enable);err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } @@ -1788,6 +1792,10 @@ xc.direct_io_safe = C.bool(x.DirectIoSafe) if err := x.DiscardEnable.toC(&xc.discard_enable); err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +xc.specification = C.libxl_disk_specification(x.Specification) +xc.transport = C.libxl_disk_transport(x.Transport) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) if err := x.ColoEnable.toC(&xc.colo_enable); err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d5..cc52936 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -99,6 +99,20 @@ DiskBackendUnknown DiskBackend = 0 DiskBackendPhy DiskBackend = 1 DiskBackendTap DiskBackend = 2 DiskBackendQdisk DiskBackend = 3 +DiskBackendOther DiskBackend = 4 +) + +type DiskSpecification int +const( +DiskSpecificationUnknown DiskSpecification = 0 +DiskSpecificationXen DiskSpecification = 1 +DiskSpecificationVirtio DiskSpecification = 2 +) + +type DiskTransport int +const( +DiskTransportUnknown DiskTransport = 0 +DiskTransportMmio DiskTransport = 1 ) type NicType int @@ -643,6 +657,10 @@ Readwrite int IsCdrom int DirectIoSafe bool DiscardEnable Defbool +Specification DiskSpecification +Transport DiskTransport +Irq uint32 +Base uint64 ColoEnable Defbool ColoRestoreEnable Defbool ColoHost string diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 51a9b6c..cd8067b 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -528,6 +528,13 @@ #define LIBXL_HAVE_MAX_GRANT_VERSION 1 /* + * LIBXL_HAVE_DEVICE_DISK_SPECIFICATION indicates that 'specification' and + * 'transport' fields (of libxl_disk_specification and libxl_disk_transport + * types respectively) are present in libxl_device_disk. + */ +#define LIBXL_HAVE_DEVICE_DISK_SPECIFICATION 1 + +/* * libxl ABI compatibility * * The only guarantee which libxl makes regarding ABI compatibility diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c index e6025d1..a38d2e2 100644 --- a/tools/libs/light/libxl_device.c +++ b/tools/libs/light/libxl_device.c @@ -289,9 +289,16 @@ static int disk_try_backend(disk_try_backend_args *a, libxl_disk_backend backend) { libxl__gc *gc = a->gc; + libxl_disk_specification specification = a->disk->specification; /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or * backend on success */ + if ((specification == LIBXL_DISK_SPECIFICATION_VIRTIO && + backend != LIBXL_DISK_BACKEND_OTHER) || + (specification != LIBXL_DISK_SPECIFICATION_VIRTIO && + backend == LIBXL_DISK_BACKEND_OTHER)) + goto bad_specification; + switch (backend) { case LIBXL_DISK_BACKEND_PHY: if (a->disk->format != LIBXL_DISK_FORMAT_RAW) { @@ -329,6 +336,29 @@ static int disk_try_backend(disk_try_backend_args *a, if (a->disk->script) goto bad_script; return backend; + case LIBXL_DISK_BACKEND_OTHER: + if (a->disk->format != LIBXL_DISK_FORMAT_RAW) + goto bad_format; + + if (a->disk->script) + goto bad_script; + + if (libxl_defbool_val(a->disk->colo_enable)) + goto bad_colo; + + if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) { + LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, " + "skipping physical device check", a->disk->vdev); + return backend; + } + + if (libxl__try_phy_backend(a->stab.st_mode)) + return backend; + + LOG(DEBUG, "Disk vdev=%s, backend other unsuitable as phys path not a " + "block device", a->disk->vdev); + return 0; + default: LOG(DEBUG, "Disk vdev=%s, backend %d unknown", a->disk->vdev, backend); return 0; @@ -352,6 +382,12 @@ static int disk_try_backend(disk_try_backend_args *a, LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with colo", a->disk->vdev, libxl_disk_backend_to_string(backend)); return 0; + + bad_specification: + LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with specification %s", + a->disk->vdev, libxl_disk_backend_to_string(backend), + libxl_disk_specification_to_string(specification)); + return 0; } int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path, @@ -376,8 +412,9 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { a.gc = gc; a.disk = disk; - LOG(DEBUG, "Disk vdev=%s spec.backend=%s", disk->vdev, - libxl_disk_backend_to_string(disk->backend)); + LOG(DEBUG, "Disk vdev=%s spec.backend=%s specification=%s", disk->vdev, + libxl_disk_backend_to_string(disk->backend), + libxl_disk_specification_to_string(disk->specification)); if (disk->format == LIBXL_DISK_FORMAT_EMPTY) { if (!disk->is_cdrom) { @@ -392,7 +429,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { } memset(&a.stab, 0, sizeof(a.stab)); } else if ((disk->backend == LIBXL_DISK_BACKEND_UNKNOWN || - disk->backend == LIBXL_DISK_BACKEND_PHY) && + disk->backend == LIBXL_DISK_BACKEND_PHY || + disk->backend == LIBXL_DISK_BACKEND_OTHER) && disk->backend_domid == LIBXL_TOOLSTACK_DOMID && !disk->script) { if (stat(disk->pdev_path, &a.stab)) { @@ -408,7 +446,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { ok= disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?: disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?: - disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP); + disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?: + disk_try_backend(&a, LIBXL_DISK_BACKEND_OTHER); if (ok) LOG(DEBUG, "Disk vdev=%s, using backend %s", disk->vdev, @@ -441,10 +480,25 @@ char *libxl__device_disk_string_of_backend(libxl_disk_backend backend) case LIBXL_DISK_BACKEND_QDISK: return "qdisk"; case LIBXL_DISK_BACKEND_TAP: return "phy"; case LIBXL_DISK_BACKEND_PHY: return "phy"; + case LIBXL_DISK_BACKEND_OTHER: return "other"; + default: return NULL; + } +} + +char *libxl__device_disk_string_of_specification(libxl_disk_specification specification) +{ + switch (specification) { + case LIBXL_DISK_SPECIFICATION_XEN: return "xen"; + case LIBXL_DISK_SPECIFICATION_VIRTIO: return "virtio"; default: return NULL; } } +char *libxl__device_disk_string_of_transport(libxl_disk_transport transport) +{ + return (transport == LIBXL_DISK_TRANSPORT_MMIO ? "mmio" : NULL); +} + const char *libxl__qemu_disk_format_string(libxl_disk_format format) { switch (format) { diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index a5ca778..7fd98ce 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -163,6 +163,19 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); if (rc < 0) return rc; + if (disk->specification == LIBXL_DISK_SPECIFICATION_UNKNOWN) + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + + /* + * The transport field is only used for the specification "virtio" and + * it assumes only "mmio" value for now. When there will be a need to add + * "pci" support, we will need to remove the enforcement here and + * respective assert(s) down the code and let the toolstack to decide + * the transport to use. + */ + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; + /* Force Qdisk backend for CDROM devices of guests with a device model. */ if (disk->is_cdrom != 0 && libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { @@ -204,6 +217,9 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, case LIBXL_DISK_BACKEND_QDISK: device->backend_kind = LIBXL__DEVICE_KIND_QDISK; break; + case LIBXL_DISK_BACKEND_OTHER: + device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO_DISK; + break; default: LOGD(ERROR, domid, "Unrecognized disk backend type: %d", disk->backend); @@ -212,7 +228,8 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, device->domid = domid; device->devid = devid; - device->kind = LIBXL__DEVICE_KIND_VBD; + device->kind = disk->backend == LIBXL_DISK_BACKEND_OTHER ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; return 0; } @@ -317,6 +334,11 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, goto out; } + assert((disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO && + disk->backend == LIBXL_DISK_BACKEND_OTHER) || + (disk->specification != LIBXL_DISK_SPECIFICATION_VIRTIO && + disk->backend != LIBXL_DISK_BACKEND_OTHER)); + switch (disk->backend) { case LIBXL_DISK_BACKEND_PHY: dev = disk->pdev_path; @@ -330,7 +352,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD); break; + case LIBXL_DISK_BACKEND_OTHER: + dev = disk->pdev_path; + + flexarray_append(back, "params"); + flexarray_append(back, dev); + assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK); + break; case LIBXL_DISK_BACKEND_TAP: LOG(ERROR, "blktap is not supported"); rc = ERROR_FAIL; @@ -386,6 +415,15 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, flexarray_append_pair(back, "discard-enable", libxl_defbool_val(disk->discard_enable) ? "1" : "0"); + flexarray_append(back, "specification"); + flexarray_append(back, libxl__device_disk_string_of_specification(disk->specification)); + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); + flexarray_append(back, "transport"); + flexarray_append(back, libxl__device_disk_string_of_transport(disk->transport)); + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base)); + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq)); + } flexarray_append(front, "backend-id"); flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); @@ -532,6 +570,49 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path, } libxl_string_to_backend(ctx, tmp, &(disk->backend)); + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/specification", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/specification", libxl_path); + goto cleanup; + } + if (!strcmp(tmp, "xen")) + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + else if (!strcmp(tmp, "virtio")) + disk->specification = LIBXL_DISK_SPECIFICATION_VIRTIO; + else + disk->specification = LIBXL_DISK_SPECIFICATION_UNKNOWN; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/transport", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path); + goto cleanup; + } + if (!strcmp(tmp, "mmio")) + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; + else + disk->transport = LIBXL_DISK_TRANSPORT_UNKNOWN; + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/base", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); + goto cleanup; + } + disk->base = strtoul(tmp, NULL, 10); + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/irq", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); + goto cleanup; + } + disk->irq = strtoul(tmp, NULL, 10); + } + disk->vdev = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/dev", libxl_path), &len); if (!disk->vdev) { @@ -575,6 +656,41 @@ cleanup: return rc; } +static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid, + char **path) +{ + const char *dir; + int rc; + + /* + * As we don't know exactly what device kind to be used here, guess it + * by checking the presence of the corresponding path in Xenstore. + * First, try to read path for vbd device (default) and if not exists + * read path for virtio_disk device. This will work as long as both Xen PV + * and Virtio disk devices are not assigned to the same guest. + */ + *path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); + if (rc) + return rc; + + if (dir) + return 0; + + *path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); + if (rc) + return rc; + + return 0; +} + int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, const char *vdev, libxl_device_disk *disk) { @@ -588,10 +704,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, libxl_device_disk_init(disk); - libxl_path = libxl__domain_device_libxl_path(gc, domid, devid, - LIBXL__DEVICE_KIND_VBD); + rc = libxl_device_disk_get_path(gc, domid, &libxl_path); + if (rc) + return rc; - rc = libxl__disk_from_xenstore(gc, libxl_path, devid, disk); + rc = libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, devid), + devid, disk); GC_FREE; return rc; @@ -605,16 +723,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid, char *fe_path, *libxl_path; char *val; int rc; + libxl__device_kind kind; diskinfo->backend = NULL; diskinfo->devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL); - /* tap devices entries in xenstore are written as vbd devices. */ + /* tap devices entries in xenstore are written as vbd/virtio_disk devices. */ + kind = disk->backend == LIBXL_DISK_BACKEND_OTHER ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; fe_path = libxl__domain_device_frontend_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); libxl_path = libxl__domain_device_libxl_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); diskinfo->backend = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/backend", libxl_path), NULL); if (!diskinfo->backend) { @@ -1418,6 +1539,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk) #define libxl__device_disk_update_devid NULL DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks, + .get_path = libxl_device_disk_get_path, .merge = libxl_device_disk_merge, .dm_needed = libxl_device_disk_dm_needed, .from_xenstore = (device_from_xenstore_fn_t)libxl__disk_from_xenstore, diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index a26daec..534dc71 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -1493,6 +1493,8 @@ _hidden char * libxl__domain_pvcontrol_read(libxl__gc *gc, /* from xl_device */ _hidden char *libxl__device_disk_string_of_backend(libxl_disk_backend backend); +_hidden char *libxl__device_disk_string_of_specification(libxl_disk_specification specification); +_hidden char *libxl__device_disk_string_of_transport(libxl_disk_transport transport); _hidden char *libxl__device_disk_string_of_format(libxl_disk_format format); _hidden const char *libxl__qemu_disk_format_string(libxl_disk_format format); _hidden int libxl__device_disk_set_backend(libxl__gc*, libxl_device_disk*); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 2a42da2..f783cac 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -130,6 +130,18 @@ libxl_disk_backend = Enumeration("disk_backend", [ (1, "PHY"), (2, "TAP"), (3, "QDISK"), + (4, "OTHER"), + ]) + +libxl_disk_specification = Enumeration("disk_specification", [ + (0, "UNKNOWN"), + (1, "XEN"), + (2, "VIRTIO"), + ]) + +libxl_disk_transport = Enumeration("disk_transport", [ + (0, "UNKNOWN"), + (1, "MMIO"), ]) libxl_nic_type = Enumeration("nic_type", [ @@ -704,6 +716,10 @@ libxl_device_disk = Struct("device_disk", [ ("is_cdrom", integer), ("direct_io_safe", bool), ("discard_enable", libxl_defbool), + ("specification", libxl_disk_specification), + ("transport", libxl_disk_transport), + ("irq", uint32), + ("base", uint64), # Note that the COLO configuration settings should be considered unstable. # They may change incompatibly in future versions of Xen. ("colo_enable", libxl_defbool), diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 3593e21..8f71980 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "VIRTIO_DISK"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c index b91c2ca..eb816dd 100644 --- a/tools/libs/light/libxl_utils.c +++ b/tools/libs/light/libxl_utils.c @@ -303,6 +303,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, libxl_disk_backend *backend *backend = LIBXL_DISK_BACKEND_TAP; } else if (!strcmp(s, "qdisk")) { *backend = LIBXL_DISK_BACKEND_QDISK; + } else if (!strcmp(s, "other")) { + *backend = LIBXL_DISK_BACKEND_OTHER; } else if (!strcmp(s, "tap")) { p = strchr(s, ':'); if (!p) { diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c index 32d4b74..bb1337c 100644 --- a/tools/libs/util/libxlu_disk_l.c +++ b/tools/libs/util/libxlu_disk_l.c @@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner ); yyg->yy_hold_char = *yy_cp; \ *yy_cp = '\0'; \ yyg->yy_c_buf_p = yy_cp; -#define YY_NUM_RULES 36 -#define YY_END_OF_BUFFER 37 +#define YY_NUM_RULES 37 +#define YY_END_OF_BUFFER 38 /* This struct is not used in this scanner, but its presence is necessary. */ struct yy_trans_info @@ -558,74 +558,77 @@ struct yy_trans_info flex_int32_t yy_verify; flex_int32_t yy_nxt; }; -static const flex_int16_t yy_acclist[575] = +static const flex_int16_t yy_acclist[594] = { 0, - 35, 35, 37, 33, 34, 36, 8193, 33, 34, 36, - 16385, 8193, 33, 36,16385, 33, 34, 36, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 33, 34, - 36, 33, 34, 36, 33, 34, 36, 33, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 35, 36, - 36, 33, 33, 8193, 33, 8193, 33,16385, 8193, 33, - 8193, 33, 33, 8224, 33,16416, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - - 33, 33, 33, 33, 33, 33, 33, 33, 33, 35, - 8193, 33, 8193, 33, 8193, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 28, 8224, 33,16416, 33, 33, 15, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 8217, - 8224, 33,16409,16416, 33, 33, 31, 8224, 33,16416, - 33, 8216, 8224, 33,16408,16416, 33, 33, 8219, 8224, - 33,16411,16416, 33, 33, 33, 33, 33, 28, 8224, - - 33, 28, 8224, 33, 28, 33, 28, 8224, 33, 3, - 33, 15, 33, 33, 33, 33, 33, 30, 8224, 33, - 16416, 33, 33, 33, 8217, 8224, 33, 8217, 8224, 33, - 8217, 33, 8217, 8224, 33, 33, 31, 8224, 33, 31, - 8224, 33, 31, 33, 31, 8224, 8216, 8224, 33, 8216, - 8224, 33, 8216, 33, 8216, 8224, 33, 8219, 8224, 33, - 8219, 8224, 33, 8219, 33, 8219, 8224, 33, 33, 10, - 33, 33, 28, 8224, 33, 28, 8224, 33, 28, 8224, - 28, 33, 28, 33, 3, 33, 33, 33, 33, 33, - 33, 33, 30, 8224, 33, 30, 8224, 33, 30, 33, - - 30, 8224, 33, 33, 29, 8224, 33,16416, 8217, 8224, - 33, 8217, 8224, 33, 8217, 8224, 8217, 33, 8217, 33, - 33, 31, 8224, 33, 31, 8224, 33, 31, 8224, 31, - 33, 31, 8216, 8224, 33, 8216, 8224, 33, 8216, 8224, - 8216, 33, 8216, 33, 8219, 8224, 33, 8219, 8224, 33, - 8219, 8224, 8219, 33, 8219, 33, 33, 10, 23, 10, - 7, 33, 33, 33, 33, 33, 33, 33, 13, 33, - 30, 8224, 33, 30, 8224, 33, 30, 8224, 30, 33, - 30, 2, 33, 29, 8224, 33, 29, 8224, 33, 29, - 33, 29, 8224, 16, 33, 33, 11, 33, 22, 10, - - 10, 23, 7, 23, 7, 33, 8, 33, 33, 33, - 33, 6, 33, 13, 33, 2, 23, 2, 33, 29, - 8224, 33, 29, 8224, 33, 29, 8224, 29, 33, 29, - 16, 33, 33, 11, 23, 11, 26, 8224, 33,16416, - 22, 23, 22, 7, 7, 23, 33, 8, 23, 8, - 33, 33, 33, 33, 6, 23, 6, 6, 23, 6, - 23, 33, 2, 2, 23, 33, 33, 11, 11, 23, - 26, 8224, 33, 26, 8224, 33, 26, 33, 26, 8224, - 22, 23, 33, 8, 8, 23, 33, 33, 17, 18, - 6, 6, 23, 6, 6, 33, 33, 14, 33, 26, - - 8224, 33, 26, 8224, 33, 26, 8224, 26, 33, 26, - 33, 33, 33, 17, 23, 17, 18, 23, 18, 6, - 6, 33, 33, 14, 33, 20, 9, 19, 17, 17, - 23, 18, 18, 23, 6, 5, 6, 33, 21, 20, - 23, 20, 9, 23, 9, 19, 23, 19, 4, 6, - 5, 6, 33, 21, 23, 21, 20, 20, 23, 9, - 9, 23, 19, 19, 23, 4, 6, 12, 33, 21, - 21, 23, 12, 33 + 36, 36, 38, 34, 35, 37, 8193, 34, 35, 37, + 16385, 8193, 34, 37,16385, 34, 35, 37, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 34, 35, + 37, 34, 35, 37, 34, 35, 37, 34, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 36, 37, + 37, 34, 34, 8193, 34, 8193, 34,16385, 8193, 34, + 8193, 34, 34, 8225, 34,16417, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 36, 8193, 34, 8193, 34, 8193, 8225, 34, 8225, 34, + 8225, 24, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 8225, 34, 8225, + 34, 8225, 24, 34, 34, 29, 8225, 34,16417, 34, + 34, 16, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 8218, 8225, 34,16410,16417, 34, 34, 32, 8225, + 34,16417, 34, 8217, 8225, 34,16409,16417, 34, 34, + 34, 8220, 8225, 34,16412,16417, 34, 34, 34, 34, + + 34, 29, 8225, 34, 29, 8225, 34, 29, 34, 29, + 8225, 34, 3, 34, 16, 34, 34, 34, 34, 34, + 31, 8225, 34,16417, 34, 34, 34, 8218, 8225, 34, + 8218, 8225, 34, 8218, 34, 8218, 8225, 34, 34, 32, + 8225, 34, 32, 8225, 34, 32, 34, 32, 8225, 8217, + 8225, 34, 8217, 8225, 34, 8217, 34, 8217, 8225, 34, + 34, 8220, 8225, 34, 8220, 8225, 34, 8220, 34, 8220, + 8225, 34, 34, 11, 34, 34, 29, 8225, 34, 29, + 8225, 34, 29, 8225, 29, 34, 29, 34, 3, 34, + 34, 34, 34, 34, 34, 34, 31, 8225, 34, 31, + + 8225, 34, 31, 34, 31, 8225, 34, 34, 30, 8225, + 34,16417, 8218, 8225, 34, 8218, 8225, 34, 8218, 8225, + 8218, 34, 8218, 34, 34, 32, 8225, 34, 32, 8225, + 34, 32, 8225, 32, 34, 32, 8217, 8225, 34, 8217, + 8225, 34, 8217, 8225, 8217, 34, 8217, 34, 34, 8220, + 8225, 34, 8220, 8225, 34, 8220, 8225, 8220, 34, 8220, + 34, 34, 11, 24, 11, 7, 34, 34, 34, 34, + 34, 34, 34, 14, 34, 31, 8225, 34, 31, 8225, + 34, 31, 8225, 31, 34, 31, 2, 34, 30, 8225, + 34, 30, 8225, 34, 30, 34, 30, 8225, 17, 34, + + 34, 12, 34, 34, 23, 11, 11, 24, 7, 24, + 7, 34, 8, 34, 34, 34, 34, 6, 34, 14, + 34, 2, 24, 2, 34, 30, 8225, 34, 30, 8225, + 34, 30, 8225, 30, 34, 30, 17, 34, 34, 12, + 24, 12, 34, 27, 8225, 34,16417, 23, 24, 23, + 7, 7, 24, 34, 8, 24, 8, 34, 34, 34, + 34, 6, 24, 6, 6, 24, 6, 24, 34, 2, + 2, 24, 34, 34, 12, 12, 24, 34, 27, 8225, + 34, 27, 8225, 34, 27, 34, 27, 8225, 23, 24, + 34, 8, 8, 24, 34, 34, 18, 19, 6, 6, + + 24, 6, 6, 34, 34, 15, 34, 34, 27, 8225, + 34, 27, 8225, 34, 27, 8225, 27, 34, 27, 34, + 34, 34, 18, 24, 18, 19, 24, 19, 6, 6, + 34, 34, 15, 34, 34, 21, 9, 20, 18, 18, + 24, 19, 19, 24, 6, 5, 6, 34, 22, 34, + 21, 24, 21, 9, 24, 9, 20, 24, 20, 4, + 6, 5, 6, 34, 22, 24, 22, 34, 21, 21, + 24, 9, 9, 24, 20, 20, 24, 4, 6, 13, + 34, 22, 22, 24, 10, 13, 34, 10, 24, 10, + 10, 10, 24 + } ; -static const flex_int16_t yy_accept[356] = +static const flex_int16_t yy_accept[373] = { 0, 1, 1, 1, 2, 3, 4, 7, 12, 16, 19, 21, 24, 27, 30, 33, 36, 39, 42, 45, 48, @@ -633,39 +636,41 @@ static const flex_int16_t yy_accept[356] = 74, 76, 79, 81, 82, 83, 84, 87, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, - 109, 110, 111, 113, 115, 116, 118, 120, 121, 122, + 109, 110, 111, 112, 114, 116, 117, 119, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, - 143, 144, 145, 146, 148, 150, 151, 152, 153, 154, - - 158, 159, 160, 162, 163, 164, 165, 166, 167, 168, - 169, 170, 175, 176, 177, 181, 182, 187, 188, 189, - 194, 195, 196, 197, 198, 199, 202, 205, 207, 209, - 210, 212, 214, 215, 216, 217, 218, 222, 223, 224, - 225, 228, 231, 233, 235, 236, 237, 240, 243, 245, - 247, 250, 253, 255, 257, 258, 261, 264, 266, 268, - 269, 270, 271, 272, 273, 276, 279, 281, 283, 284, - 285, 287, 288, 289, 290, 291, 292, 293, 296, 299, - 301, 303, 304, 305, 309, 312, 315, 317, 319, 320, - 321, 322, 325, 328, 330, 332, 333, 336, 339, 341, - - 343, 344, 345, 348, 351, 353, 355, 356, 357, 358, - 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, - 371, 374, 377, 379, 381, 382, 383, 384, 387, 390, - 392, 394, 396, 397, 398, 399, 400, 401, 403, 405, - 406, 407, 408, 409, 410, 411, 412, 413, 414, 416, - 418, 419, 420, 423, 426, 428, 430, 431, 433, 434, - 436, 437, 441, 443, 444, 445, 447, 448, 450, 451, - 452, 453, 454, 455, 457, 458, 460, 462, 463, 464, - 466, 467, 468, 469, 471, 474, 477, 479, 481, 483, - 484, 485, 487, 488, 489, 490, 491, 492, 494, 495, - - 496, 497, 498, 500, 503, 506, 508, 510, 511, 512, - 513, 514, 516, 517, 519, 520, 521, 522, 523, 524, - 526, 527, 528, 529, 530, 532, 533, 535, 536, 538, - 539, 540, 542, 543, 545, 546, 548, 549, 551, 553, - 554, 556, 557, 558, 560, 561, 563, 564, 566, 568, - 570, 571, 573, 575, 575 + 143, 144, 145, 146, 147, 148, 150, 152, 153, 154, + + 155, 156, 160, 161, 162, 164, 165, 166, 167, 168, + 169, 170, 171, 172, 177, 178, 179, 183, 184, 189, + 190, 191, 192, 197, 198, 199, 200, 201, 202, 205, + 208, 210, 212, 213, 215, 217, 218, 219, 220, 221, + 225, 226, 227, 228, 231, 234, 236, 238, 239, 240, + 243, 246, 248, 250, 253, 256, 258, 260, 261, 262, + 265, 268, 270, 272, 273, 274, 275, 276, 277, 280, + 283, 285, 287, 288, 289, 291, 292, 293, 294, 295, + 296, 297, 300, 303, 305, 307, 308, 309, 313, 316, + 319, 321, 323, 324, 325, 326, 329, 332, 334, 336, + + 337, 340, 343, 345, 347, 348, 349, 350, 353, 356, + 358, 360, 361, 362, 363, 365, 366, 367, 368, 369, + 370, 371, 372, 373, 374, 376, 379, 382, 384, 386, + 387, 388, 389, 392, 395, 397, 399, 401, 402, 403, + 404, 405, 406, 407, 409, 411, 412, 413, 414, 415, + 416, 417, 418, 419, 420, 422, 424, 425, 426, 429, + 432, 434, 436, 437, 439, 440, 442, 443, 444, 448, + 450, 451, 452, 454, 455, 457, 458, 459, 460, 461, + 462, 464, 465, 467, 469, 470, 471, 473, 474, 475, + 476, 478, 479, 482, 485, 487, 489, 491, 492, 493, + + 495, 496, 497, 498, 499, 500, 502, 503, 504, 505, + 506, 508, 509, 512, 515, 517, 519, 520, 521, 522, + 523, 525, 526, 528, 529, 530, 531, 532, 533, 535, + 536, 537, 538, 539, 540, 542, 543, 545, 546, 548, + 549, 550, 551, 553, 554, 556, 557, 559, 560, 562, + 564, 565, 567, 568, 569, 570, 572, 573, 575, 576, + 578, 580, 582, 583, 585, 586, 588, 590, 591, 592, + 594, 594 } ; static const YY_CHAR yy_ec[256] = @@ -708,216 +713,224 @@ static const YY_CHAR yy_meta[35] = 1, 1, 1, 1 } ; -static const flex_int16_t yy_base[424] = +static const flex_int16_t yy_base[443] = { 0, - 0, 0, 901, 900, 902, 897, 33, 36, 905, 905, - 45, 63, 31, 42, 51, 52, 890, 33, 65, 67, - 69, 70, 889, 71, 888, 75, 0, 905, 893, 905, - 91, 94, 0, 0, 103, 886, 112, 0, 89, 98, - 113, 92, 114, 99, 100, 48, 121, 116, 119, 74, - 124, 129, 123, 135, 132, 133, 137, 134, 138, 139, - 141, 0, 155, 0, 0, 164, 0, 0, 849, 142, - 152, 164, 140, 161, 165, 166, 167, 168, 169, 173, - 174, 178, 176, 180, 184, 208, 189, 183, 192, 195, - 215, 191, 193, 223, 0, 0, 905, 208, 204, 236, - - 219, 209, 238, 196, 237, 831, 242, 815, 241, 224, - 243, 261, 244, 259, 277, 266, 286, 250, 288, 298, - 249, 283, 274, 282, 294, 308, 0, 310, 0, 295, - 305, 905, 308, 306, 313, 314, 342, 319, 316, 320, - 331, 0, 349, 0, 342, 344, 356, 0, 358, 0, - 365, 0, 367, 0, 354, 375, 0, 377, 0, 363, - 356, 809, 327, 322, 384, 0, 0, 0, 0, 379, - 905, 382, 384, 386, 390, 372, 392, 403, 0, 410, - 0, 407, 413, 423, 426, 0, 0, 0, 0, 409, - 424, 435, 0, 0, 0, 0, 437, 0, 0, 0, - - 0, 433, 444, 0, 0, 0, 0, 391, 440, 781, - 905, 769, 439, 445, 444, 447, 449, 454, 453, 399, - 464, 0, 0, 0, 0, 757, 465, 476, 0, 478, - 0, 479, 476, 753, 462, 490, 749, 905, 745, 905, - 483, 737, 424, 485, 487, 490, 500, 493, 905, 729, - 905, 502, 518, 0, 0, 0, 0, 905, 498, 721, - 905, 527, 713, 0, 705, 905, 495, 697, 905, 365, - 521, 528, 530, 685, 905, 534, 540, 540, 657, 905, - 537, 542, 650, 905, 553, 0, 557, 0, 0, 551, - 641, 905, 558, 557, 633, 614, 613, 905, 547, 555, - - 563, 565, 569, 584, 0, 0, 0, 0, 583, 570, - 585, 612, 905, 601, 905, 522, 580, 589, 594, 905, - 600, 585, 563, 520, 905, 514, 905, 586, 486, 597, - 480, 441, 905, 416, 905, 345, 905, 334, 905, 601, - 254, 905, 242, 905, 200, 905, 151, 905, 905, 607, - 86, 905, 905, 905, 620, 624, 627, 631, 635, 639, - 643, 647, 651, 655, 659, 663, 667, 671, 675, 679, - 683, 687, 691, 695, 699, 703, 707, 711, 715, 719, - 723, 727, 731, 735, 739, 743, 747, 751, 755, 759, - 763, 767, 771, 775, 779, 783, 787, 791, 795, 799, - - 803, 807, 811, 815, 819, 823, 827, 831, 835, 839, - 843, 847, 851, 855, 859, 863, 867, 871, 875, 879, - 883, 887, 891 + 0, 0, 936, 935, 937, 932, 33, 36, 940, 940, + 45, 63, 31, 42, 51, 52, 925, 33, 65, 67, + 69, 70, 924, 71, 923, 75, 0, 940, 928, 940, + 91, 95, 0, 0, 104, 921, 113, 0, 91, 99, + 114, 92, 115, 80, 100, 48, 119, 121, 122, 74, + 123, 128, 131, 129, 125, 133, 135, 136, 137, 143, + 138, 145, 0, 157, 0, 0, 168, 0, 0, 926, + 140, 146, 165, 159, 152, 164, 155, 168, 171, 176, + 177, 170, 180, 175, 184, 188, 212, 191, 185, 192, + 193, 194, 219, 212, 199, 230, 0, 0, 940, 195, + + 200, 239, 235, 197, 246, 225, 226, 919, 244, 918, + 243, 236, 245, 266, 248, 264, 282, 271, 291, 248, + 270, 254, 300, 279, 296, 302, 288, 303, 311, 0, + 315, 0, 311, 318, 940, 313, 319, 208, 313, 344, + 321, 331, 325, 333, 0, 352, 0, 345, 347, 359, + 0, 361, 0, 368, 0, 370, 0, 322, 366, 379, + 0, 381, 0, 359, 357, 923, 382, 384, 392, 0, + 0, 0, 0, 387, 940, 386, 390, 392, 329, 401, + 397, 409, 0, 417, 0, 399, 412, 426, 429, 0, + 0, 0, 0, 412, 427, 438, 0, 0, 0, 0, + + 440, 0, 0, 0, 0, 436, 405, 447, 0, 0, + 0, 0, 438, 443, 922, 940, 921, 442, 450, 449, + 452, 454, 459, 458, 453, 469, 0, 0, 0, 0, + 920, 470, 481, 0, 483, 0, 484, 481, 919, 368, + 467, 495, 918, 940, 917, 940, 488, 916, 479, 490, + 492, 495, 505, 498, 940, 915, 940, 507, 523, 0, + 0, 0, 0, 940, 503, 864, 940, 846, 532, 836, + 0, 824, 940, 516, 796, 940, 513, 530, 536, 538, + 784, 940, 542, 535, 547, 772, 940, 549, 551, 768, + 940, 502, 562, 0, 564, 0, 0, 562, 764, 940, + + 544, 557, 760, 752, 744, 940, 552, 568, 571, 568, + 581, 577, 588, 0, 0, 0, 0, 589, 580, 591, + 736, 940, 728, 940, 601, 602, 597, 599, 940, 603, + 720, 712, 700, 672, 940, 665, 940, 610, 656, 603, + 648, 607, 629, 940, 627, 940, 625, 940, 624, 940, + 607, 574, 940, 614, 572, 940, 491, 940, 433, 940, + 940, 622, 389, 940, 303, 940, 261, 940, 204, 940, + 940, 635, 639, 642, 646, 650, 654, 658, 662, 666, + 670, 674, 678, 682, 686, 690, 694, 698, 702, 706, + 710, 714, 718, 722, 726, 730, 734, 738, 742, 746, + + 750, 754, 758, 762, 766, 770, 774, 778, 782, 786, + 790, 794, 798, 802, 806, 810, 814, 818, 822, 826, + 830, 834, 838, 842, 846, 850, 854, 858, 862, 866, + 870, 874, 878, 882, 886, 890, 894, 898, 902, 906, + 910, 914 } ; -static const flex_int16_t yy_def[424] = +static const flex_int16_t yy_def[443] = { 0, - 354, 1, 355, 355, 354, 356, 357, 357, 354, 354, - 358, 358, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 359, 354, 356, 354, - 360, 357, 361, 361, 362, 12, 356, 363, 12, 12, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, + 371, 1, 372, 372, 371, 373, 374, 374, 371, 371, + 375, 375, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 12, 12, 12, 376, 371, 373, 371, + 377, 374, 378, 378, 379, 12, 373, 380, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 359, 360, 361, 361, 364, 365, 365, 354, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 362, 12, 12, 12, 12, - 12, 12, 12, 364, 365, 365, 354, 12, 12, 366, - + 12, 12, 376, 377, 378, 378, 381, 382, 382, 371, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 367, 86, 86, 368, 12, 369, 12, 12, 370, - 12, 12, 12, 12, 12, 371, 372, 366, 372, 12, - 12, 354, 86, 12, 12, 12, 373, 12, 12, 12, - 374, 375, 367, 375, 86, 86, 376, 377, 368, 377, - 378, 379, 369, 379, 12, 380, 381, 370, 381, 12, - 12, 382, 12, 12, 371, 372, 372, 383, 383, 12, - 354, 86, 86, 86, 12, 12, 12, 384, 385, 373, - 385, 12, 12, 386, 374, 375, 375, 387, 387, 86, - 86, 376, 377, 377, 388, 388, 378, 379, 379, 389, - - 389, 12, 380, 381, 381, 390, 390, 12, 12, 391, - 354, 392, 86, 12, 86, 86, 86, 12, 86, 12, - 384, 385, 385, 393, 393, 394, 86, 395, 396, 386, - 396, 86, 86, 397, 12, 398, 391, 354, 399, 354, - 86, 400, 12, 86, 86, 86, 401, 86, 354, 402, - 354, 86, 395, 396, 396, 403, 403, 354, 86, 404, - 354, 405, 406, 406, 399, 354, 86, 407, 354, 12, - 86, 86, 86, 408, 354, 408, 408, 86, 402, 354, - 86, 86, 404, 354, 409, 410, 405, 410, 406, 86, - 407, 354, 12, 86, 411, 412, 408, 354, 408, 408, - - 86, 86, 86, 409, 410, 410, 413, 413, 86, 12, - 86, 414, 354, 415, 354, 408, 408, 86, 86, 354, - 416, 417, 418, 414, 354, 415, 354, 408, 408, 86, - 419, 420, 354, 421, 354, 422, 354, 408, 354, 86, - 423, 354, 420, 354, 421, 354, 422, 354, 354, 86, - 423, 354, 354, 0, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354 + 12, 12, 12, 12, 12, 12, 379, 12, 12, 12, + 12, 12, 12, 12, 12, 381, 382, 382, 371, 12, + + 12, 383, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 384, 87, 87, 385, 12, 386, 12, + 12, 12, 387, 12, 12, 12, 12, 12, 388, 389, + 383, 389, 12, 12, 371, 87, 12, 12, 12, 390, + 12, 12, 12, 391, 392, 384, 392, 87, 87, 393, + 394, 385, 394, 395, 396, 386, 396, 12, 12, 397, + 398, 387, 398, 12, 12, 399, 12, 12, 388, 389, + 389, 400, 400, 12, 371, 87, 87, 87, 12, 12, + 12, 401, 402, 390, 402, 12, 12, 403, 391, 392, + 392, 404, 404, 87, 87, 393, 394, 394, 405, 405, + + 395, 396, 396, 406, 406, 12, 12, 397, 398, 398, + 407, 407, 12, 12, 408, 371, 409, 87, 12, 87, + 87, 87, 12, 87, 12, 401, 402, 402, 410, 410, + 411, 87, 412, 413, 403, 413, 87, 87, 414, 12, + 12, 415, 408, 371, 416, 371, 87, 417, 12, 87, + 87, 87, 418, 87, 371, 419, 371, 87, 412, 413, + 413, 420, 420, 371, 87, 421, 371, 12, 422, 423, + 423, 416, 371, 87, 424, 371, 12, 87, 87, 87, + 425, 371, 425, 425, 87, 419, 371, 87, 87, 421, + 371, 12, 426, 427, 422, 427, 423, 87, 424, 371, + + 12, 87, 428, 429, 425, 371, 425, 425, 87, 87, + 87, 12, 426, 427, 427, 430, 430, 87, 12, 87, + 431, 371, 432, 371, 425, 425, 87, 87, 371, 12, + 433, 434, 435, 431, 371, 432, 371, 425, 425, 87, + 436, 12, 437, 371, 438, 371, 439, 371, 425, 371, + 87, 440, 371, 12, 437, 371, 438, 371, 439, 371, + 371, 87, 440, 371, 441, 371, 442, 371, 442, 371, + 0, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371 } ; -static const flex_int16_t yy_nxt[940] = +static const flex_int16_t yy_nxt[975] = { 0, 6, 7, 8, 9, 6, 6, 6, 6, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 17, 17, 17, 17, 20, 17, 21, 22, 23, 24, 25, 17, 26, 17, 17, 17, 32, 32, 33, 32, 32, 33, 36, 34, 36, 42, 34, 29, 29, 29, 30, 35, - 50, 36, 37, 38, 43, 44, 39, 36, 79, 45, + 50, 36, 37, 38, 43, 44, 39, 36, 80, 45, 36, 36, 40, 29, 29, 29, 30, 35, 46, 48, 37, 38, 41, 47, 36, 49, 36, 53, 36, 36, - 36, 56, 58, 36, 36, 55, 82, 60, 51, 342, - 54, 61, 52, 29, 64, 32, 32, 33, 36, 65, - - 70, 36, 34, 29, 29, 29, 30, 36, 36, 36, - 29, 38, 66, 66, 66, 67, 66, 71, 74, 66, - 68, 72, 36, 36, 73, 36, 77, 78, 36, 76, - 36, 53, 36, 36, 75, 85, 80, 83, 36, 86, - 84, 36, 36, 36, 36, 81, 36, 36, 36, 36, - 36, 36, 93, 89, 337, 98, 88, 29, 64, 101, - 90, 36, 91, 65, 92, 87, 29, 95, 89, 99, - 36, 100, 96, 36, 36, 36, 36, 36, 36, 106, - 105, 85, 36, 36, 102, 36, 107, 36, 103, 36, - 109, 112, 36, 36, 104, 108, 115, 110, 36, 117, - - 36, 36, 36, 335, 36, 36, 122, 111, 29, 29, - 29, 30, 118, 36, 116, 29, 38, 36, 36, 113, - 114, 119, 120, 123, 36, 29, 95, 121, 36, 134, - 131, 96, 130, 36, 125, 124, 126, 126, 66, 127, - 126, 132, 133, 126, 129, 333, 36, 36, 135, 137, - 36, 36, 36, 140, 139, 35, 35, 352, 36, 36, - 85, 141, 141, 66, 142, 141, 160, 145, 141, 144, - 35, 35, 89, 117, 155, 36, 146, 147, 147, 66, - 148, 147, 162, 36, 147, 150, 151, 151, 66, 152, - 151, 36, 36, 151, 154, 120, 161, 36, 156, 156, - - 66, 157, 156, 36, 36, 156, 159, 164, 171, 163, - 29, 166, 29, 168, 36, 36, 167, 170, 169, 35, - 35, 172, 36, 36, 173, 36, 213, 184, 36, 36, - 175, 36, 174, 29, 186, 212, 36, 349, 183, 187, - 177, 176, 178, 178, 66, 179, 178, 182, 348, 178, - 181, 29, 188, 35, 35, 35, 35, 189, 29, 193, - 29, 195, 190, 36, 194, 36, 196, 29, 198, 29, - 200, 191, 36, 199, 36, 201, 219, 29, 204, 29, - 206, 36, 202, 205, 209, 207, 29, 166, 36, 293, - 208, 214, 167, 35, 35, 35, 35, 35, 35, 36, - - 36, 36, 249, 218, 220, 29, 222, 216, 36, 217, - 235, 223, 29, 224, 215, 226, 36, 227, 225, 346, - 35, 35, 36, 228, 228, 66, 229, 228, 29, 186, - 228, 231, 232, 36, 187, 233, 35, 29, 193, 29, - 198, 234, 36, 194, 344, 199, 29, 204, 236, 36, - 35, 241, 205, 242, 36, 35, 35, 270, 35, 35, - 35, 35, 247, 36, 35, 35, 29, 222, 244, 262, - 248, 36, 223, 243, 245, 246, 35, 252, 29, 254, - 29, 256, 258, 342, 255, 259, 257, 35, 35, 339, - 35, 35, 69, 264, 35, 35, 35, 35, 35, 35, - - 267, 35, 35, 275, 35, 35, 35, 35, 271, 35, - 35, 276, 277, 35, 35, 272, 278, 315, 273, 281, - 29, 254, 290, 313, 282, 275, 255, 285, 285, 66, - 286, 285, 35, 35, 285, 288, 295, 298, 296, 35, - 35, 35, 35, 298, 301, 328, 299, 294, 35, 35, - 275, 35, 35, 35, 303, 29, 305, 300, 275, 29, - 307, 306, 35, 35, 302, 308, 337, 36, 35, 35, - 309, 310, 320, 316, 35, 35, 35, 35, 322, 36, - 35, 35, 317, 275, 319, 311, 29, 305, 335, 275, - 318, 321, 306, 323, 35, 35, 35, 35, 330, 329, - - 35, 35, 331, 333, 327, 35, 35, 338, 35, 35, - 353, 340, 35, 35, 350, 325, 275, 315, 35, 35, - 27, 27, 27, 27, 29, 29, 29, 31, 31, 31, - 31, 36, 36, 36, 36, 62, 313, 62, 62, 63, - 63, 63, 63, 65, 269, 65, 65, 35, 35, 35, - 35, 69, 69, 261, 69, 94, 94, 94, 94, 96, - 251, 96, 96, 128, 128, 128, 128, 143, 143, 143, - 143, 149, 149, 149, 149, 153, 153, 153, 153, 158, - 158, 158, 158, 165, 165, 165, 165, 167, 298, 167, - 167, 180, 180, 180, 180, 185, 185, 185, 185, 187, - - 292, 187, 187, 192, 192, 192, 192, 194, 240, 194, - 194, 197, 197, 197, 197, 199, 289, 199, 199, 203, - 203, 203, 203, 205, 284, 205, 205, 210, 210, 210, - 210, 169, 280, 169, 169, 221, 221, 221, 221, 223, - 269, 223, 223, 230, 230, 230, 230, 189, 266, 189, - 189, 196, 211, 196, 196, 201, 261, 201, 201, 207, - 251, 207, 207, 237, 237, 237, 237, 239, 239, 239, - 239, 225, 240, 225, 225, 250, 250, 250, 250, 253, - 253, 253, 253, 255, 238, 255, 255, 260, 260, 260, - 260, 263, 263, 263, 263, 265, 265, 265, 265, 268, - - 268, 268, 268, 274, 274, 274, 274, 279, 279, 279, - 279, 257, 211, 257, 257, 283, 283, 283, 283, 287, - 287, 287, 287, 264, 138, 264, 264, 291, 291, 291, - 291, 297, 297, 297, 297, 304, 304, 304, 304, 306, - 136, 306, 306, 312, 312, 312, 312, 314, 314, 314, - 314, 308, 97, 308, 308, 324, 324, 324, 324, 326, - 326, 326, 326, 332, 332, 332, 332, 334, 334, 334, - 334, 336, 336, 336, 336, 341, 341, 341, 341, 343, - 343, 343, 343, 345, 345, 345, 345, 347, 347, 347, - 347, 351, 351, 351, 351, 36, 30, 59, 57, 36, - - 30, 354, 28, 28, 5, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 36, 56, 58, 36, 36, 55, 83, 61, 51, 36, + 54, 62, 52, 29, 65, 59, 32, 32, 33, 66, + + 36, 36, 71, 34, 29, 29, 29, 30, 36, 36, + 77, 29, 38, 67, 67, 67, 68, 67, 75, 72, + 67, 69, 73, 36, 36, 74, 78, 79, 36, 53, + 36, 36, 36, 87, 36, 76, 84, 36, 36, 85, + 36, 81, 36, 86, 36, 36, 36, 36, 82, 36, + 92, 95, 36, 100, 36, 36, 89, 90, 88, 29, + 65, 36, 91, 101, 36, 66, 90, 93, 36, 94, + 29, 97, 102, 36, 36, 104, 98, 36, 103, 36, + 36, 107, 108, 106, 36, 36, 36, 105, 86, 36, + 109, 110, 111, 36, 36, 114, 112, 36, 117, 119, + + 36, 36, 36, 36, 36, 121, 36, 368, 36, 36, + 120, 113, 29, 29, 29, 30, 118, 36, 134, 29, + 38, 36, 127, 115, 116, 122, 123, 125, 36, 126, + 128, 124, 29, 97, 36, 36, 180, 138, 98, 129, + 129, 67, 130, 129, 36, 36, 129, 132, 133, 135, + 136, 140, 36, 36, 36, 36, 142, 36, 137, 35, + 35, 123, 86, 36, 370, 143, 144, 144, 67, 145, + 144, 148, 158, 144, 147, 35, 35, 90, 119, 36, + 36, 149, 150, 150, 67, 151, 150, 159, 36, 150, + 153, 154, 154, 67, 155, 154, 164, 36, 154, 157, + + 160, 160, 67, 161, 160, 36, 368, 160, 163, 165, + 166, 36, 36, 29, 170, 167, 168, 29, 172, 171, + 36, 175, 36, 173, 35, 35, 176, 36, 36, 177, + 36, 36, 188, 174, 36, 29, 190, 178, 36, 181, + 36, 191, 223, 179, 182, 182, 67, 183, 182, 186, + 206, 182, 185, 187, 29, 192, 35, 35, 35, 35, + 193, 29, 197, 29, 199, 194, 36, 198, 36, 200, + 29, 202, 29, 204, 195, 36, 203, 36, 205, 268, + 207, 29, 209, 29, 211, 214, 213, 210, 218, 212, + 217, 36, 353, 36, 29, 170, 36, 35, 35, 219, + + 171, 35, 35, 35, 35, 224, 36, 231, 36, 225, + 36, 29, 227, 221, 36, 222, 232, 228, 220, 29, + 229, 36, 240, 35, 35, 230, 233, 233, 67, 234, + 233, 29, 190, 233, 236, 237, 348, 191, 238, 35, + 29, 197, 29, 202, 239, 36, 198, 36, 203, 29, + 209, 242, 36, 35, 247, 210, 255, 241, 248, 36, + 35, 35, 36, 35, 35, 35, 35, 253, 36, 35, + 35, 29, 227, 250, 269, 254, 36, 228, 249, 251, + 252, 35, 258, 29, 260, 29, 262, 264, 36, 261, + 265, 263, 35, 35, 346, 35, 35, 70, 271, 35, + + 35, 35, 35, 35, 35, 274, 35, 35, 282, 35, + 35, 36, 277, 278, 35, 35, 283, 284, 35, 35, + 279, 285, 36, 280, 288, 29, 260, 35, 35, 289, + 312, 261, 293, 293, 67, 294, 293, 301, 306, 293, + 296, 35, 35, 298, 303, 306, 304, 35, 35, 35, + 35, 309, 308, 36, 307, 282, 302, 319, 35, 35, + 35, 35, 35, 311, 29, 314, 29, 316, 35, 35, + 315, 282, 317, 35, 35, 344, 310, 364, 325, 35, + 35, 318, 35, 35, 329, 320, 36, 328, 332, 36, + 29, 314, 35, 35, 330, 326, 315, 331, 327, 333, + + 35, 35, 35, 35, 282, 282, 340, 341, 35, 35, + 35, 35, 36, 282, 35, 35, 36, 351, 35, 35, + 362, 339, 365, 36, 338, 366, 342, 361, 360, 354, + 358, 349, 356, 35, 35, 27, 27, 27, 27, 29, + 29, 29, 31, 31, 31, 31, 36, 36, 36, 36, + 63, 353, 63, 63, 64, 64, 64, 64, 66, 350, + 66, 66, 35, 35, 35, 35, 70, 70, 324, 70, + 96, 96, 96, 96, 98, 322, 98, 98, 131, 131, + 131, 131, 146, 146, 146, 146, 152, 152, 152, 152, + 156, 156, 156, 156, 162, 162, 162, 162, 169, 169, + + 169, 169, 171, 348, 171, 171, 184, 184, 184, 184, + 189, 189, 189, 189, 191, 346, 191, 191, 196, 196, + 196, 196, 198, 344, 198, 198, 201, 201, 201, 201, + 203, 337, 203, 203, 208, 208, 208, 208, 210, 335, + 210, 210, 215, 215, 215, 215, 173, 282, 173, 173, + 226, 226, 226, 226, 228, 324, 228, 228, 235, 235, + 235, 235, 193, 322, 193, 193, 200, 276, 200, 200, + 205, 267, 205, 205, 212, 257, 212, 212, 243, 243, + 243, 243, 245, 245, 245, 245, 230, 306, 230, 230, + 256, 256, 256, 256, 259, 259, 259, 259, 261, 300, + + 261, 261, 266, 266, 266, 266, 270, 270, 270, 270, + 272, 272, 272, 272, 275, 275, 275, 275, 281, 281, + 281, 281, 286, 286, 286, 286, 263, 246, 263, 263, + 290, 290, 290, 290, 295, 295, 295, 295, 271, 297, + 271, 271, 299, 299, 299, 299, 305, 305, 305, 305, + 313, 313, 313, 313, 315, 292, 315, 315, 321, 321, + 321, 321, 323, 323, 323, 323, 317, 291, 317, 317, + 334, 334, 334, 334, 336, 336, 336, 336, 343, 343, + 343, 343, 345, 345, 345, 345, 347, 347, 347, 347, + 352, 352, 352, 352, 355, 355, 355, 355, 357, 357, + + 357, 357, 359, 359, 359, 359, 363, 363, 363, 363, + 367, 367, 367, 367, 369, 369, 369, 369, 287, 276, + 273, 216, 267, 257, 246, 244, 216, 141, 139, 99, + 36, 30, 60, 57, 36, 30, 371, 28, 28, 5, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; -static const flex_int16_t yy_chk[940] = +static const flex_int16_t yy_chk[975] = { 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, @@ -927,101 +940,105 @@ static const flex_int16_t yy_chk[940] = 18, 14, 11, 11, 13, 14, 11, 46, 46, 14, 15, 16, 11, 12, 12, 12, 12, 12, 14, 16, 12, 12, 12, 15, 19, 16, 20, 20, 21, 22, - 24, 22, 24, 50, 26, 21, 50, 26, 19, 351, - 20, 26, 19, 31, 31, 32, 32, 32, 39, 31, - - 39, 42, 32, 35, 35, 35, 35, 40, 44, 45, - 35, 35, 37, 37, 37, 37, 37, 39, 42, 37, - 37, 40, 41, 43, 41, 48, 45, 45, 49, 44, - 47, 47, 53, 51, 43, 53, 48, 51, 52, 54, - 52, 55, 56, 58, 54, 49, 57, 59, 60, 73, - 61, 70, 60, 61, 347, 70, 56, 63, 63, 73, - 58, 71, 59, 63, 59, 55, 66, 66, 57, 71, - 74, 72, 66, 72, 75, 76, 77, 78, 79, 78, - 77, 79, 80, 81, 74, 83, 80, 82, 75, 84, - 82, 85, 88, 85, 76, 81, 87, 83, 87, 89, - - 92, 89, 93, 345, 90, 104, 92, 84, 86, 86, - 86, 86, 90, 99, 88, 86, 86, 98, 102, 86, - 86, 91, 91, 93, 91, 94, 94, 91, 101, 104, - 102, 94, 101, 110, 99, 98, 100, 100, 100, 100, - 100, 103, 103, 100, 100, 343, 105, 103, 105, 107, - 109, 107, 111, 110, 109, 113, 113, 341, 121, 118, - 111, 112, 112, 112, 112, 112, 121, 113, 112, 112, - 114, 114, 116, 116, 118, 116, 114, 115, 115, 115, - 115, 115, 123, 123, 115, 115, 117, 117, 117, 117, - 117, 124, 122, 117, 117, 119, 122, 119, 120, 120, - - 120, 120, 120, 125, 130, 120, 120, 125, 131, 124, - 126, 126, 128, 128, 131, 134, 126, 130, 128, 133, - 133, 133, 135, 136, 133, 139, 164, 140, 138, 140, - 134, 164, 133, 141, 141, 163, 163, 338, 139, 141, - 136, 135, 137, 137, 137, 137, 137, 138, 336, 137, - 137, 143, 143, 145, 145, 146, 146, 143, 147, 147, - 149, 149, 145, 155, 147, 161, 149, 151, 151, 153, - 153, 146, 160, 151, 270, 153, 176, 156, 156, 158, - 158, 176, 155, 156, 161, 158, 165, 165, 170, 270, - 160, 170, 165, 172, 172, 173, 173, 174, 174, 175, - - 208, 177, 220, 175, 177, 178, 178, 173, 220, 174, - 208, 178, 180, 180, 172, 182, 182, 183, 180, 334, - 190, 190, 183, 184, 184, 184, 184, 184, 185, 185, - 184, 184, 190, 243, 185, 191, 191, 192, 192, 197, - 197, 202, 202, 192, 332, 197, 203, 203, 209, 209, - 213, 213, 203, 214, 214, 215, 215, 243, 216, 216, - 217, 217, 218, 218, 219, 219, 221, 221, 215, 235, - 219, 235, 221, 214, 216, 217, 227, 227, 228, 228, - 230, 230, 232, 331, 228, 233, 230, 233, 233, 329, - 232, 232, 236, 236, 241, 241, 244, 244, 245, 245, - - 241, 246, 246, 247, 248, 248, 267, 267, 244, 259, - 259, 247, 247, 252, 252, 245, 248, 326, 246, 252, - 253, 253, 267, 324, 259, 316, 253, 262, 262, 262, - 262, 262, 271, 271, 262, 262, 272, 276, 273, 272, - 272, 273, 273, 277, 278, 316, 276, 271, 281, 281, - 299, 278, 278, 282, 282, 285, 285, 277, 300, 287, - 287, 285, 290, 290, 281, 287, 323, 293, 294, 294, - 290, 293, 303, 299, 301, 301, 302, 302, 310, 310, - 303, 303, 300, 317, 302, 294, 304, 304, 322, 328, - 301, 309, 304, 311, 309, 309, 311, 311, 318, 317, - - 318, 318, 319, 321, 314, 319, 319, 328, 330, 330, - 350, 330, 340, 340, 340, 312, 297, 296, 350, 350, - 355, 355, 355, 355, 356, 356, 356, 357, 357, 357, - 357, 358, 358, 358, 358, 359, 295, 359, 359, 360, - 360, 360, 360, 361, 291, 361, 361, 362, 362, 362, - 362, 363, 363, 283, 363, 364, 364, 364, 364, 365, - 279, 365, 365, 366, 366, 366, 366, 367, 367, 367, - 367, 368, 368, 368, 368, 369, 369, 369, 369, 370, - 370, 370, 370, 371, 371, 371, 371, 372, 274, 372, - 372, 373, 373, 373, 373, 374, 374, 374, 374, 375, - - 268, 375, 375, 376, 376, 376, 376, 377, 265, 377, - 377, 378, 378, 378, 378, 379, 263, 379, 379, 380, - 380, 380, 380, 381, 260, 381, 381, 382, 382, 382, - 382, 383, 250, 383, 383, 384, 384, 384, 384, 385, - 242, 385, 385, 386, 386, 386, 386, 387, 239, 387, - 387, 388, 237, 388, 388, 389, 234, 389, 389, 390, - 226, 390, 390, 391, 391, 391, 391, 392, 392, 392, - 392, 393, 212, 393, 393, 394, 394, 394, 394, 395, - 395, 395, 395, 396, 210, 396, 396, 397, 397, 397, - 397, 398, 398, 398, 398, 399, 399, 399, 399, 400, - - 400, 400, 400, 401, 401, 401, 401, 402, 402, 402, - 402, 403, 162, 403, 403, 404, 404, 404, 404, 405, - 405, 405, 405, 406, 108, 406, 406, 407, 407, 407, - 407, 408, 408, 408, 408, 409, 409, 409, 409, 410, - 106, 410, 410, 411, 411, 411, 411, 412, 412, 412, - 412, 413, 69, 413, 413, 414, 414, 414, 414, 415, - 415, 415, 415, 416, 416, 416, 416, 417, 417, 417, - 417, 418, 418, 418, 418, 419, 419, 419, 419, 420, - 420, 420, 420, 421, 421, 421, 421, 422, 422, 422, - 422, 423, 423, 423, 423, 36, 29, 25, 23, 17, - - 6, 5, 4, 3, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 24, 22, 24, 50, 26, 21, 50, 26, 19, 44, + 20, 26, 19, 31, 31, 24, 32, 32, 32, 31, + + 39, 42, 39, 32, 35, 35, 35, 35, 40, 45, + 44, 35, 35, 37, 37, 37, 37, 37, 42, 39, + 37, 37, 40, 41, 43, 41, 45, 45, 47, 47, + 48, 49, 51, 54, 55, 43, 51, 52, 54, 52, + 53, 48, 56, 53, 57, 58, 59, 61, 49, 71, + 59, 61, 60, 71, 62, 72, 56, 62, 55, 64, + 64, 75, 58, 72, 77, 64, 57, 60, 74, 60, + 67, 67, 73, 76, 73, 75, 67, 78, 74, 82, + 79, 78, 79, 77, 84, 80, 81, 76, 80, 83, + 81, 82, 83, 85, 89, 86, 84, 86, 88, 90, + + 88, 90, 91, 92, 100, 92, 104, 369, 95, 101, + 91, 85, 87, 87, 87, 87, 89, 138, 104, 87, + 87, 94, 100, 87, 87, 93, 93, 94, 93, 95, + 101, 93, 96, 96, 106, 107, 138, 107, 96, 102, + 102, 102, 102, 102, 103, 112, 102, 102, 103, 105, + 105, 109, 111, 109, 113, 105, 111, 120, 106, 115, + 115, 122, 113, 122, 367, 112, 114, 114, 114, 114, + 114, 115, 120, 114, 114, 116, 116, 118, 118, 121, + 118, 116, 117, 117, 117, 117, 117, 121, 124, 117, + 117, 119, 119, 119, 119, 119, 124, 127, 119, 119, + + 123, 123, 123, 123, 123, 125, 365, 123, 123, 125, + 126, 126, 128, 129, 129, 127, 128, 131, 131, 129, + 133, 134, 139, 131, 136, 136, 136, 134, 137, 136, + 141, 158, 143, 133, 143, 144, 144, 136, 179, 139, + 142, 144, 179, 137, 140, 140, 140, 140, 140, 141, + 158, 140, 140, 142, 146, 146, 148, 148, 149, 149, + 146, 150, 150, 152, 152, 148, 165, 150, 164, 152, + 154, 154, 156, 156, 149, 159, 154, 240, 156, 240, + 159, 160, 160, 162, 162, 165, 164, 160, 168, 162, + 167, 167, 363, 168, 169, 169, 174, 176, 176, 174, + + 169, 177, 177, 178, 178, 180, 181, 186, 186, 181, + 180, 182, 182, 177, 207, 178, 187, 182, 176, 184, + 184, 187, 207, 194, 194, 184, 188, 188, 188, 188, + 188, 189, 189, 188, 188, 194, 359, 189, 195, 195, + 196, 196, 201, 201, 206, 206, 196, 213, 201, 208, + 208, 214, 214, 218, 218, 208, 225, 213, 219, 219, + 220, 220, 225, 221, 221, 222, 222, 223, 223, 224, + 224, 226, 226, 220, 241, 224, 241, 226, 219, 221, + 222, 232, 232, 233, 233, 235, 235, 237, 249, 233, + 238, 235, 238, 238, 357, 237, 237, 242, 242, 247, + + 247, 250, 250, 251, 251, 247, 252, 252, 253, 254, + 254, 292, 249, 250, 265, 265, 253, 253, 258, 258, + 251, 254, 277, 252, 258, 259, 259, 274, 274, 265, + 292, 259, 269, 269, 269, 269, 269, 277, 284, 269, + 269, 278, 278, 274, 279, 283, 280, 279, 279, 280, + 280, 285, 284, 301, 283, 307, 278, 301, 285, 285, + 288, 288, 289, 289, 293, 293, 295, 295, 302, 302, + 293, 308, 295, 298, 298, 355, 288, 352, 307, 310, + 310, 298, 309, 309, 311, 302, 312, 310, 319, 319, + 313, 313, 311, 311, 312, 308, 313, 318, 309, 320, + + 318, 318, 320, 320, 325, 326, 327, 328, 327, 327, + 328, 328, 330, 338, 340, 340, 342, 340, 351, 351, + 351, 326, 354, 354, 325, 362, 330, 349, 347, 342, + 345, 338, 343, 362, 362, 372, 372, 372, 372, 373, + 373, 373, 374, 374, 374, 374, 375, 375, 375, 375, + 376, 341, 376, 376, 377, 377, 377, 377, 378, 339, + 378, 378, 379, 379, 379, 379, 380, 380, 336, 380, + 381, 381, 381, 381, 382, 334, 382, 382, 383, 383, + 383, 383, 384, 384, 384, 384, 385, 385, 385, 385, + 386, 386, 386, 386, 387, 387, 387, 387, 388, 388, + + 388, 388, 389, 333, 389, 389, 390, 390, 390, 390, + 391, 391, 391, 391, 392, 332, 392, 392, 393, 393, + 393, 393, 394, 331, 394, 394, 395, 395, 395, 395, + 396, 323, 396, 396, 397, 397, 397, 397, 398, 321, + 398, 398, 399, 399, 399, 399, 400, 305, 400, 400, + 401, 401, 401, 401, 402, 304, 402, 402, 403, 403, + 403, 403, 404, 303, 404, 404, 405, 299, 405, 405, + 406, 290, 406, 406, 407, 286, 407, 407, 408, 408, + 408, 408, 409, 409, 409, 409, 410, 281, 410, 410, + 411, 411, 411, 411, 412, 412, 412, 412, 413, 275, + + 413, 413, 414, 414, 414, 414, 415, 415, 415, 415, + 416, 416, 416, 416, 417, 417, 417, 417, 418, 418, + 418, 418, 419, 419, 419, 419, 420, 272, 420, 420, + 421, 421, 421, 421, 422, 422, 422, 422, 423, 270, + 423, 423, 424, 424, 424, 424, 425, 425, 425, 425, + 426, 426, 426, 426, 427, 268, 427, 427, 428, 428, + 428, 428, 429, 429, 429, 429, 430, 266, 430, 430, + 431, 431, 431, 431, 432, 432, 432, 432, 433, 433, + 433, 433, 434, 434, 434, 434, 435, 435, 435, 435, + 436, 436, 436, 436, 437, 437, 437, 437, 438, 438, + + 438, 438, 439, 439, 439, 439, 440, 440, 440, 440, + 441, 441, 441, 441, 442, 442, 442, 442, 256, 248, + 245, 243, 239, 231, 217, 215, 166, 110, 108, 70, + 36, 29, 25, 23, 17, 6, 5, 4, 3, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; #define YY_TRAILING_MASK 0x2000 @@ -1160,9 +1177,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"other")) DSET(dpc,backend,BACKEND,str,OTHER); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -1199,9 +1224,9 @@ static int vdev_and_devtype(DiskParseContext *dpc, char *str) { #undef DPC /* needs to be defined differently the actual lexer */ #define DPC ((DiskParseContext*)yyextra) -#line 1202 "libxlu_disk_l.c" +#line 1227 "libxlu_disk_l.c" -#line 1204 "libxlu_disk_l.c" +#line 1229 "libxlu_disk_l.c" #define INITIAL 0 #define LEXERR 1 @@ -1477,13 +1502,13 @@ YY_DECL } { -#line 177 "libxlu_disk_l.l" +#line 185 "libxlu_disk_l.l" -#line 180 "libxlu_disk_l.l" +#line 188 "libxlu_disk_l.l" /*----- the scanner rules which do the parsing -----*/ -#line 1486 "libxlu_disk_l.c" +#line 1511 "libxlu_disk_l.c" while ( /*CONSTCOND*/1 ) /* loops until end-of-file is reached */ { @@ -1515,14 +1540,14 @@ yy_match: while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; *yyg->yy_state_ptr++ = yy_current_state; ++yy_cp; } - while ( yy_current_state != 354 ); + while ( yy_current_state != 371 ); yy_find_action: yy_current_state = *--yyg->yy_state_ptr; @@ -1572,152 +1597,158 @@ do_action: /* This label is used only to access EOF actions. */ case 1: /* rule 1 can match eol */ YY_RULE_SETUP -#line 182 "libxlu_disk_l.l" +#line 190 "libxlu_disk_l.l" { /* ignore whitespace before parameters */ } YY_BREAK /* ordinary parameters setting enums or strings */ case 2: /* rule 2 can match eol */ YY_RULE_SETUP -#line 186 "libxlu_disk_l.l" +#line 194 "libxlu_disk_l.l" { STRIP(','); setformat(DPC, FROMEQUALS); } YY_BREAK case 3: YY_RULE_SETUP -#line 188 "libxlu_disk_l.l" +#line 196 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 4: YY_RULE_SETUP -#line 189 "libxlu_disk_l.l" +#line 197 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 5: YY_RULE_SETUP -#line 190 "libxlu_disk_l.l" +#line 198 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 0; } YY_BREAK case 6: /* rule 6 can match eol */ YY_RULE_SETUP -#line 191 "libxlu_disk_l.l" +#line 199 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown value for type"); } YY_BREAK case 7: /* rule 7 can match eol */ YY_RULE_SETUP -#line 193 "libxlu_disk_l.l" +#line 201 "libxlu_disk_l.l" { STRIP(','); setaccess(DPC, FROMEQUALS); } YY_BREAK case 8: /* rule 8 can match eol */ YY_RULE_SETUP -#line 194 "libxlu_disk_l.l" +#line 202 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } YY_BREAK case 9: /* rule 9 can match eol */ YY_RULE_SETUP -#line 195 "libxlu_disk_l.l" +#line 203 "libxlu_disk_l.l" { STRIP(','); setbackendtype(DPC,FROMEQUALS); } YY_BREAK case 10: /* rule 10 can match eol */ YY_RULE_SETUP -#line 197 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } +#line 204 "libxlu_disk_l.l" +{ STRIP(','); setspecification(DPC,FROMEQUALS); } YY_BREAK case 11: /* rule 11 can match eol */ YY_RULE_SETUP -#line 198 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } +#line 206 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } YY_BREAK case 12: +/* rule 12 can match eol */ YY_RULE_SETUP -#line 199 "libxlu_disk_l.l" -{ DPC->disk->direct_io_safe = 1; } +#line 207 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } YY_BREAK case 13: YY_RULE_SETUP -#line 200 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, true); } +#line 208 "libxlu_disk_l.l" +{ DPC->disk->direct_io_safe = 1; } YY_BREAK case 14: YY_RULE_SETUP -#line 201 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, false); } +#line 209 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, true); } YY_BREAK -/* Note that the COLO configuration settings should be considered unstable. - * They may change incompatibly in future versions of Xen. */ case 15: YY_RULE_SETUP -#line 204 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, true); } +#line 210 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, false); } YY_BREAK +/* Note that the COLO configuration settings should be considered unstable. + * They may change incompatibly in future versions of Xen. */ case 16: YY_RULE_SETUP -#line 205 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, false); } +#line 213 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, true); } YY_BREAK case 17: -/* rule 17 can match eol */ YY_RULE_SETUP -#line 206 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } +#line 214 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, false); } YY_BREAK case 18: /* rule 18 can match eol */ YY_RULE_SETUP -#line 207 "libxlu_disk_l.l" -{ STRIP(','); setcoloport(DPC, FROMEQUALS); } +#line 215 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } YY_BREAK case 19: /* rule 19 can match eol */ YY_RULE_SETUP -#line 208 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } +#line 216 "libxlu_disk_l.l" +{ STRIP(','); setcoloport(DPC, FROMEQUALS); } YY_BREAK case 20: /* rule 20 can match eol */ YY_RULE_SETUP -#line 209 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } +#line 217 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } YY_BREAK case 21: /* rule 21 can match eol */ YY_RULE_SETUP -#line 210 "libxlu_disk_l.l" +#line 218 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } + YY_BREAK +case 22: +/* rule 22 can match eol */ +YY_RULE_SETUP +#line 219 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); } YY_BREAK /* the target magic parameter, eats the rest of the string */ -case 22: +case 23: YY_RULE_SETUP -#line 214 "libxlu_disk_l.l" +#line 223 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); } YY_BREAK /* unknown parameters */ -case 23: -/* rule 23 can match eol */ +case 24: +/* rule 24 can match eol */ YY_RULE_SETUP -#line 218 "libxlu_disk_l.l" +#line 227 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown parameter"); } YY_BREAK /* deprecated prefixes */ /* the "/.*" in these patterns ensures that they count as if they * matched the whole string, so these patterns take precedence */ -case 24: +case 25: YY_RULE_SETUP -#line 225 "libxlu_disk_l.l" +#line 234 "libxlu_disk_l.l" { STRIP(':'); DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'"); setformat(DPC, yytext); } YY_BREAK -case 25: +case 26: YY_RULE_SETUP -#line 231 "libxlu_disk_l.l" +#line 240 "libxlu_disk_l.l" { char *newscript; STRIP(':'); @@ -1731,65 +1762,65 @@ YY_RULE_SETUP free(newscript); } YY_BREAK -case 26: +case 27: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 8; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 244 "libxlu_disk_l.l" +#line 253 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 27: +case 28: YY_RULE_SETUP -#line 245 "libxlu_disk_l.l" +#line 254 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 28: +case 29: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 246 "libxlu_disk_l.l" +#line 255 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 29: +case 30: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 6; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 247 "libxlu_disk_l.l" +#line 256 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 30: +case 31: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 5; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 248 "libxlu_disk_l.l" +#line 257 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 31: +case 32: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 249 "libxlu_disk_l.l" +#line 258 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 32: -/* rule 32 can match eol */ +case 33: +/* rule 33 can match eol */ YY_RULE_SETUP -#line 251 "libxlu_disk_l.l" +#line 260 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix"); return 0; } YY_BREAK /* positional parameters */ -case 33: -/* rule 33 can match eol */ +case 34: +/* rule 34 can match eol */ YY_RULE_SETUP -#line 258 "libxlu_disk_l.l" +#line 267 "libxlu_disk_l.l" { STRIP(','); @@ -1816,27 +1847,27 @@ YY_RULE_SETUP } } YY_BREAK -case 34: +case 35: YY_RULE_SETUP -#line 284 "libxlu_disk_l.l" +#line 293 "libxlu_disk_l.l" { BEGIN(LEXERR); yymore(); } YY_BREAK -case 35: +case 36: YY_RULE_SETUP -#line 288 "libxlu_disk_l.l" +#line 297 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0; } YY_BREAK -case 36: +case 37: YY_RULE_SETUP -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" YY_FATAL_ERROR( "flex scanner jammed" ); YY_BREAK -#line 1839 "libxlu_disk_l.c" +#line 1870 "libxlu_disk_l.c" case YY_STATE_EOF(INITIAL): case YY_STATE_EOF(LEXERR): yyterminate(); @@ -2104,7 +2135,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; @@ -2128,11 +2159,11 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - yy_is_jam = (yy_current_state == 354); + yy_is_jam = (yy_current_state == 371); if ( ! yy_is_jam ) *yyg->yy_state_ptr++ = yy_current_state; @@ -2941,4 +2972,4 @@ void yyfree (void * ptr , yyscan_t yyscanner) #define YYTABLES_NAME "yytables" -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h index 6abeecf..509aad6 100644 --- a/tools/libs/util/libxlu_disk_l.h +++ b/tools/libs/util/libxlu_disk_l.h @@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner); #undef yyTABLES_NAME #endif -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" #line 699 "libxlu_disk_l.h" #undef xlu__disk_yyIN_HEADER diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_disk_l.l index 3bd639a..47b8ee0 100644 --- a/tools/libs/util/libxlu_disk_l.l +++ b/tools/libs/util/libxlu_disk_l.l @@ -122,9 +122,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"other")) DSET(dpc,backend,BACKEND,str,OTHER); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -192,6 +200,7 @@ devtype=[^,]*,? { xlu__disk_err(DPC,yytext,"unknown value for type"); } access=[^,]*,? { STRIP(','); setaccess(DPC, FROMEQUALS); } backend=[^,]*,? { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); } +specification=[^,]*,? { STRIP(','); setspecification(DPC,FROMEQUALS); } vdev=[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } script=[^,]*,? { STRIP(','); SAVESTRING("script", script, FROMEQUALS); } diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c index 70eed43..f2b0ff5 100644 --- a/tools/xl/xl_block.c +++ b/tools/xl/xl_block.c @@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv) return 0; } + if (disk.specification != LIBXL_DISK_SPECIFICATION_XEN) { + fprintf(stderr, "block-attach is only supported for specification xen\n"); + return 1; + } + if (libxl_device_disk_add(ctx, fe_domid, &disk, 0)) { fprintf(stderr, "libxl_device_disk_add failed.\n"); return 1; @@ -119,6 +124,12 @@ int main_blockdetach(int argc, char **argv) fprintf(stderr, "Error: Device %s not connected.\n", argv[optind+1]); return 1; } + + if (disk.specification != LIBXL_DISK_SPECIFICATION_XEN) { + fprintf(stderr, "block-detach is only supported for specification xen\n"); + return 1; + } + rc = !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) : libxl_device_disk_destroy(ctx, domid, &disk, 0); if (rc) { -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 03 17:32:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:32:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319833.540246 (Exim 4.92) (envelope-from ) id 1nlwNX-0000wi-Mh; Tue, 03 May 2022 17:32:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319833.540246; Tue, 03 May 2022 17:32:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwNX-0000wb-IO; Tue, 03 May 2022 17:32:03 +0000 Received: by outflank-mailman (input) for mailman id 319833; Tue, 03 May 2022 17:32:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwNW-0000wV-BJ for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:32:02 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-cusazlp170110003.outbound.protection.outlook.com [2a01:111:f403:c111::3]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef98652c-cb06-11ec-a406-831a346695d4; Tue, 03 May 2022 19:32:00 +0200 (CEST) Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21) by MWHPR21MB0191.namprd21.prod.outlook.com (2603:10b6:300:79::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.6; Tue, 3 May 2022 17:31:43 +0000 Received: from PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df%5]) with mapi id 15.20.5250.006; Tue, 3 May 2022 17:31:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef98652c-cb06-11ec-a406-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jt/KOtRUgIAyksyYK8VnD6ZnzZ/NliFwcadXLsWhztfCamTq3QwkwpGwyMwiutvnUnN9P++1gDsLEiw6Ffs4JzYwWGjG1s32LGaj++fC09TISIbhTPJ22JvpH1sDoC1t8TEEevav+mZukOSpAc/O8A9zMznA1StSx+n+fiDRjrtWV3GTpPnM9y6fYUY9TLjiFeJdopLkIP13Hd3e75u1mME7ICYLLotdeJxv7FFo9dCplpw84PrBxCkN8oMYpv+9SKWUo7v1vDi+yPwDJ8RozZ6cej5bW0lGLjxGVSQUz4zO2RXSdgzKKqzurjdwrIitXCjuYEki2FjSzkfT1QwwKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EOJL1aNKBYeOe+uczwmHwdViQyc7IwMUkuukaeURBOs=; b=S7HWX64rCgnA9mLOc2eDXyDjV6iC0ehqY8SNFj/n7g9tX/kIZbHomLEI9FL1MH56jcIPtcTLOcqfxQMnuO6iEK3JH7YjdxMdQA+HfoV3LG9zl2jalk2jxwFSWVvdJKaYxR965/HLYUfTNH9sMSpM9KkV6n9THwWb2UXseqq1mVCCB9/2/pYGTGYa0m4B6mGZ8ABVNHH0efDrQpFCtgvcmpBYAxTdOM5BWACtw4nDbSbKbDaQPVrS4f/tC0fAe4egALomaphJqT00udxastUBLuxGhAmPgXopd/cBVnO3YucxlRcHy76OdoyO+bUJQCABjNA8UWZ8RaZuV9puIkhUjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOJL1aNKBYeOe+uczwmHwdViQyc7IwMUkuukaeURBOs=; b=iMwLKZ9LBUYKCD7s3OHUGAzQf1eKepDONOGF5h+ECdpSlLnCRD1k8RU9oxx0Yd92mvK8EkErUnr1aFcwYQE1hWsNHP5RV8IZwkrqNwqDR6/GJsTT94uz47EnDd3I5q+sCx4HSe8qnHdaKJZ/stF6cJ7V1IuK4VGpUqTTX4YDSgg= From: "Michael Kelley (LINUX)" To: "Guilherme G. Piccoli" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" Subject: RE: [PATCH 24/30] panic: Refactor the panic path Thread-Topic: [PATCH 24/30] panic: Refactor the panic path Thread-Index: AQHYWooewzaZJbWMbkqYc1HZNUkdQa0HKRAQgAAz7QCABhB0MA== Date: Tue, 3 May 2022 17:31:43 +0000 Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <50178dfb-8e94-f35f-09c3-22fe197550ef@igalia.com> In-Reply-To: <50178dfb-8e94-f35f-09c3-22fe197550ef@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8353cb62-2ed7-400a-b7eb-a0eb08ff48b4;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-05-03T17:14:35Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c02534b1-161e-4271-51ad-08da2d2aca6d x-ms-traffictypediagnostic: MWHPR21MB0191:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d+Vj8BD2ptagF97e+OKWd6KIi9dJnQ7gaUDc6wlNZqB6d87vNQwAg9gTTz7gmEe5peNSxQquSkNJzQZbbI/RlISFgBlQoQpdhadxVIaq7nDryyXKXewxJ0vEK70rT16ZqNlNHh03BpEBnX+MiIth//WHnfeBrwZmsv0wDp5R3AQsTrWJaSMiwJUOUWRAJ4NNbdjAtd6NDcqyYBbe/F2sAryTMSyjGpc4aonCjZ4cV15U71QaHrIwDBpm9Ott4b/b9qtwd1Umqb+3ozGfrT9PkBMRsd3ruDpgUupJRy0jUOCMhPng7xTHxD5JfAgZjtHX9KAOIfg/a4LVLYLDxSzDOj0bVriAYEXmhf3mtG/3z/Ov87p4l4gyWHPi3JZPxGGlFR/SgW76EoWXJHfAJtuldYHbL9T4rhbaORwQLgLnzmqfYlau6+M/dYNT8y/uw3q3K6oZ6wuFLStOV7xMc3LAlTPyYJYxe8F0WsMoFQutNHnbjeH5rRpCrzTR2byFdYk4tRWkm1W2B7lovCjTOPhfiNyLfasP6HjbeopVJGp91XcI8s8jb7bFMITNKq0NhyelZQt8vkTqhEUT0hpbvLrqX/4zxvGqf7KS+O5k9BlNztUgNOk4AEnflbZjadvWOVpCU6KgEsLHWGGqJTczV5btT+4ftNTK4/5RNcc5r8t81x3Qng82ku6C6Sy2px6abE7hE+MJFVQt3wDG7R39G1tnCbrKEwajs+OkqxRln1S9lmH2pp5HwuLL5xpibnmFTPHDx410FyVKd08iauOHoDTrAWdkY/rGrhSinmO9G7HzK/JuxyBxSsA50phwfKS7qvGXabAWJbIIe81HboIaEq2IyXifJPQJp+rKDJXr+pJU+kmIR57hSHvkeiJudnDxrp8n x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(71200400001)(10290500003)(82950400001)(5660300002)(7406005)(7366002)(122000001)(8676002)(8936002)(83380400001)(53546011)(7416002)(7696005)(508600001)(86362001)(6506007)(64756008)(38070700005)(38100700002)(52536014)(9686003)(186003)(26005)(66476007)(66446008)(66946007)(76116006)(66556008)(82960400001)(54906003)(110136005)(966005)(316002)(4326008)(8990500004)(2906002)(55016003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/JpsvICJW831GtJhoHUV7R5VNJCByy4wAGc71QhpgpZ9H5twFSHjEwLRUjNq?= =?us-ascii?Q?+xcjP/YzIJDPmEBkCiHEwmnaevTU0pHzAC/ToQf+XxP9Pq/V6V/4zX1GbtCC?= =?us-ascii?Q?6TfuHBuuBf+9ejbz00o1x7xRKy5CUtBmEvw+0X5/cQSU/lR6323jos9/PanL?= =?us-ascii?Q?wXSQfD6SMNaQHS0AB5Ww12hs+qWMOFKkpyXTSvfTfP8xd/65gZ5GX5qeH3ZV?= =?us-ascii?Q?rk0XFNSTh0qp1DUHgrYLDStU+U5kweGv+JzhMITo15+lB9pZO6tKK5u1+yIv?= =?us-ascii?Q?S4Xc3FVp/A2a7E9dcITnFLqGq8Di8UadZMR9ty8GUfGmqGizf2j2+zN6Qlzq?= =?us-ascii?Q?W9G42fDKK65EIbamjxiBd7kwvsgKpWjadf0mTRG5wd6RhvSnjRfUC5DWAVD5?= =?us-ascii?Q?MU43loH4ELMFnUomwAGDwpb7Jfq72+KlTxdLXSlfvyrd8qfZhVbosi5rq778?= =?us-ascii?Q?OsgybK0DVpMIm4u97jRl8TRFD0Kumg8jUSvxHQuMK9IhffuYGS7J9Tj2fF2L?= =?us-ascii?Q?r+wWJ+bpmnK5isJwURS9DQA7ZKjeauso0WcwJatwsHZY3tW07ezQw3LdF3eC?= =?us-ascii?Q?BPQIpQ6Gv1hgqaMvEOFvz5j6jFIRH9bIafnMpeUmwQl+IsmP/e+s+Kd0pIA8?= =?us-ascii?Q?CIiIqq7GIvYQqYCaH4Kai4JM2R6PQ+UBr3bT7802u8YJSEfQhlKqznchSm1L?= =?us-ascii?Q?sFnvGGX1BvEzcBWZ3oNjA72XewKggji1hhR1Up+TJlOngapGMliMmVKtyRpR?= =?us-ascii?Q?An0XeQ+OjtTeo13bQmj3o132J/r6YJrJZCI+V/lxQ6TabhCmPKsgkx6KEQFy?= =?us-ascii?Q?EZWA9YNVksZkcqfHPRmKtvhtt2t4VXJSlooO/gsEDGU5UK5xWoD1C7xNOfr5?= =?us-ascii?Q?3HfkPGhe+KL3/FSEczi29DIyhslBql9QRZkeyGBED6xWcoHeWQICeopseWe5?= =?us-ascii?Q?rA8Wyj2STMJj1XZPMf2Ig4T4uCLE53Jc87GKJPrWk6guBYcZNQTUlsP3RRi/?= =?us-ascii?Q?eOj1pnly+b3D0souCKgk9bVVlIewyhQFC3rDkdNqeEG0iyC/c1NIFpQ7BTsM?= =?us-ascii?Q?hQT3d/1an0zHG5geRp6eUSgzazxJdw9FWfdwnXJUKyvfQvNvOAaERsNw0wWC?= =?us-ascii?Q?zzbU8jX3dNYLUKrrOH0NV12CHX4jYkTVYJmbKnkX28nQt/c7qhnxyRVWxt4U?= =?us-ascii?Q?u/pUED5lDnxYr0//LOtOOggezR1tW5+2vlOst3LzoPjmy4cuZHMrmgqV62jX?= =?us-ascii?Q?BsTaKSRtmBDE4jLeImBYd42cPgdVttbyKVo3SSX+u+qV7FBwHvuSK4mGTMT9?= =?us-ascii?Q?zj2OyZyV0iIcCMnAv5bRh9jZYYdeuQlOMcJi0Pn8A3/QGdmQwclZu0/BD9kV?= =?us-ascii?Q?/tpGTxTS8CYjFK9L6GpSBkcjBAzbZd9DdPM2tD4KDdhhv9FOvl9K893/rqJT?= =?us-ascii?Q?EcvMYmZsYOFNp939/EQ02tRp5Tk4RTZDzUZOytVvYLm9Etqrtk0we6fyWqZW?= =?us-ascii?Q?7h2jGVdTyiXaZJo3zpc2u2E8R/4sxXQWFdY/7hAQ6pZiB/jfXGIsWWCT/h2j?= =?us-ascii?Q?seEitHQyk3PZuYC26Tt+Aep09FET5ZeUVkFhE2lDKvZGqW2p2FuH0IsbWnHJ?= =?us-ascii?Q?APq546lgGacp3dNPPra6++6k5Ze+ibilIXYr2871lf75Po05kxywWn2YS7tE?= =?us-ascii?Q?7ihfERru7bbVvMU0KOB53AE4IzmeefbD40voYwTcNdMO7hDuylseW+MXFABQ?= =?us-ascii?Q?3Alqkuy65DPhYQjdaZpxE27nYeShtF4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c02534b1-161e-4271-51ad-08da2d2aca6d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2022 17:31:43.3884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uCZvqjHqBSnDDITyIgv33IArtj67sulx9219DtqDuXN15ic3u3zIh/wV/287GSYh6ohZ68LzN/uqJT/ZRhTo5qXHXhMXRCpanWwblZGK3w4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0191 From: Guilherme G. Piccoli Sent: Friday, April 29, 20= 22 1:38 PM >=20 > On 29/04/2022 14:53, Michael Kelley (LINUX) wrote: > > From: Guilherme G. Piccoli Sent: Wednesday, April= 27, 2022 > 3:49 PM > >> [...] > >> + panic_notifiers_level=3D > >> + [KNL] Set the panic notifiers execution order. > >> + Format: > >> + We currently have 4 lists of panic notifiers; based > >> + on the functionality and risk (for panic success) the > >> + callbacks are added in a given list. The lists are: > >> + - hypervisor/FW notification list (low risk); > >> + - informational list (low/medium risk); > >> + - pre_reboot list (higher risk); > >> + - post_reboot list (only run late in panic and after > >> + kdump, not configurable for now). > >> + This parameter defines the ordering of the first 3 > >> + lists with regards to kdump; the levels determine > >> + which set of notifiers execute before kdump. The > >> + accepted levels are: > >> + 0: kdump is the first thing to run, NO list is > >> + executed before kdump. > >> + 1: only the hypervisor list is executed before kdump. > >> + 2 (default level): the hypervisor list and (*if* > >> + there's any kmsg_dumper defined) the informational > >> + list are executed before kdump. > >> + 3: both the hypervisor and the informational lists > >> + (always) execute before kdump. > > > > I'm not clear on why level 2 exists. What is the scenario where > > execution of the info list before kdump should be conditional on the > > existence of a kmsg_dumper? Maybe the scenario is described > > somewhere in the patch set and I just missed it. > > >=20 > Hi Michael, thanks for your review/consideration. So, this idea started > kind of some time ago. It all started with a need of exposing more > information on kernel log *before* kdump and *before* pstore - > specifically, we're talking about panic_print. But this cause some > reactions, Baoquan was very concerned with that [0]. Soon after, I've > proposed a panic notifiers filter (orthogonal) approach, to which Petr > suggested instead doing a major refactor [1] - it finally is alive in > the form of this series. >=20 > The theory behind the level 2 is to allow a scenario of kdump with the > minimum amount of notifiers - what is the point in printing more > information if the user doesn't care, since it's going to kdump? Now, if > there is a kmsg dumper, it means that there is likely some interest in > collecting information, and that might as well be required before the > potential kdump (which is my case, hence the proposal on [0]). >=20 > Instead of forcing one of the two behaviors (level 1 or level 3), we > have a middle-term/compromise: if there's interest in collecting such > data (in the form of a kmsg dumper), we then execute the informational > notifiers before kdump. If not, why to increase (even slightly) the risk > for kdump? >=20 > I'm OK in removing the level 2 if people prefer, but I don't feel it's a > burden, quite opposite - seems a good way to accommodate the somewhat > antagonistic ideas (jump to kdump ASAP vs collecting more info in the > panicked kernel log). >=20 > [0] https://lore.kernel.org/lkml/20220126052246.GC2086@MiWiFi-R3L-srv/ >=20 > [1] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/ >=20 To me, it's a weak correlation between having a kmsg dumper, and wanting or not wanting the info level output to come before kdump. Hyper-V is one of only a few places that register a kmsg dumper, so most Linux instances outside of Hyper-V guest (and PowerPC systems?) will have the info level output after kdump. It seems like anyone who cared strongly about the info level output would set the panic_notifier_level to 1 or to 3 so that the result is more deterministic. But that's just my opinion, and it's probably an opinion that is not as well informed on the topic as some others in the discussion. So keeping things as in your patch set is not a show-stopper for me. However, I would request a clarification in the documentation. The panic_notifier_level affects not only the hypervisor, informational, and pre_reboot lists, but it also affects panic_print_sys_info() and kmsg_dump(). Specifically, at level 1, panic_print_sys_info() and kmsg_dump() will not be run before kdump. At level 3, they will always be run before kdump. Your documentation above mentions "informational lists" (plural), which I take to vaguely include kmsg_dump() and panic_print_sys_info(), but being explicit about the effect would be better. Michael >=20 > >[...] > >> + * Based on the level configured (smaller than 4), we clear the > >> + * proper bits in "panic_notifiers_bits". Notice that this bitfield > >> + * is initialized with all notifiers set. > >> + */ > >> + switch (panic_notifiers_level) { > >> + case 3: > >> + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > >> + break; > >> + case 2: > >> + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > >> + > >> + if (!kmsg_has_dumpers()) > >> + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > >> + break; > >> + case 1: > >> + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > >> + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > >> + break; > >> + case 0: > >> + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > >> + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > >> + clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits); > >> + break; > >> + } > > > > I think the above switch statement could be done as follows: > > > > if (panic_notifiers_level <=3D 3) > > clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > > if (panic_notifiers_level <=3D 2) > > if (!kmsg_has_dumpers()) > > clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > > if (panic_notifiers_level <=3D1) > > clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > > if (panic_notifiers_level =3D=3D 0) > > clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits); > > > > That's about half the lines of code. It's somewhat a matter of style, > > so treat this as just a suggestion to consider. I just end up looking > > for a better solution when I see the same line of code repeated > > 3 or 4 times! > > >=20 > It's a good idea - I liked your code. The switch seems more > natural/explicit for me, even duplicating some lines, but in case more > people prefer your way, I can definitely change the code - thanks for > the suggestion. > Cheers, >=20 >=20 > Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 03 17:44:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319840.540268 (Exim 4.92) (envelope-from ) id 1nlwZR-0002iJ-34; Tue, 03 May 2022 17:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319840.540268; Tue, 03 May 2022 17:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwZQ-0002iC-VJ; Tue, 03 May 2022 17:44:20 +0000 Received: by outflank-mailman (input) for mailman id 319840; Tue, 03 May 2022 17:44:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwZQ-0002hJ-1X for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:44:20 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-eus2azlp170100002.outbound.protection.outlook.com [2a01:111:f403:c110::2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6c3ed02-cb08-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:44:17 +0200 (CEST) Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21) by LV2PR21MB3087.namprd21.prod.outlook.com (2603:10b6:408:17b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.6; Tue, 3 May 2022 17:44:03 +0000 Received: from PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df%5]) with mapi id 15.20.5250.006; Tue, 3 May 2022 17:44:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6c3ed02-cb08-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XbijhHt7DvBA3OPHj5t3ISIXnYrTgZbDSRSHY/XkvVdsezGq0sD81iZ//y42Fi2Hm7oEIw1H8MDO35AWd9+dF5auopwSIzFPe74YuKNP1Oz83tgle2Aq1+PBTM7yyQtPdPg8dBbkObOOfdcHgPQwCYlcKGuWJ4R156bFid/pLdBUkpw8ikAC6TwUDIHN2W7gUY/PlWHAT3ycgAIsFpuAIVIlReaxm4w8jPPJRfFHTDrwfikPx+q0M2KAr4BP+Mkr2WGz6Mo0WABvgcYmWGlqDonrI6A0W3sVJYI01Hwlyz83gHMY/7BNmBCbcS7mV6SQ4sjfr4xbKlH5do/EEq/TuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4f7/UQ5vrJT1CcOWidK1fYhaFM8aZiWH/zdIuOdIqFI=; b=dqXqNwHhYIB0ER3lhh/rWVNm4ZKERdEz94orJ80nKUJUfttp/wnfqSikyK7yKt7iYkc6ldUXEJma4nPZMqUqXLWeqBqYn3BdE2tOa/aMKvNt9gj8PT3QNHIdWaLn8iw/avUa7KnRHtq2eRRYGwyR7FuPyrdomPVLH2oCaEXcOUnrjeVd/oiCqcnnAd/up+tug/xBARgpdJCDI/9XQpeIX67uH77GUYwgNe77hWgiQhX7h5Bo1kYMNhBf7E0pbeQS5Uw18UPkTEbTw5p8eddfnQ5xc5RmwbnOWVCy1bs9vErVywk/hlTEcX9LIiT7Ea0jg2aEKuPewehmuyrotSaXxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4f7/UQ5vrJT1CcOWidK1fYhaFM8aZiWH/zdIuOdIqFI=; b=ibLxKWCEZr87+e1ghS/3cQWdAu21T6pLKpXb8f8XpZMMGm6EnkQk6xvpbhjPJde4vXJnb/vlh+izkRcTyaQ3oc0/MfDh6ustPJ68hRUYdoknL67CjcRfYkt2JoVm3CTCbqOVt2GOpFlK+kEynFerKUIBO0QTVxV0uZ6if6XeVIo= From: "Michael Kelley (LINUX)" To: "Guilherme G. Piccoli" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , David Gow , "David S. Miller" , Dexuan Cui , Doug Berger , Evan Green , Florian Fainelli , Haiyang Zhang , Hari Bathini , Heiko Carstens , Julius Werner , Justin Chen , KY Srinivasan , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Scott Branden , Sebastian Reichel , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: RE: [PATCH 19/30] panic: Add the panic hypervisor notifier list Thread-Topic: [PATCH 19/30] panic: Add the panic hypervisor notifier list Thread-Index: AQHYWonjjKMtrubrvUiw63ryI2yC7q0HJOjggAANHwCABkBo0A== Date: Tue, 3 May 2022 17:44:03 +0000 Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <0147d038-571b-0802-c210-ccd4d52cd5dd@igalia.com> In-Reply-To: <0147d038-571b-0802-c210-ccd4d52cd5dd@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=9d743df4-32f4-4832-b2bd-4bac7169537f;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-05-03T17:32:26Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: acdb6465-6bb9-4403-84f7-08da2d2c8350 x-ms-traffictypediagnostic: LV2PR21MB3087:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wLED0P0VxujV/NW5LEmwON60/vs9aWjhxc2SvH76GRzH9ukteke/LYW3Yu4t0Qc2EbxzckRYOK1czaMQT+TCBICWOjI6ITHKMiozSJLgS9hQFU5D46+CvmFm/io9aBdtA0Xav0jItj7kAOY/7tKKA8c26IAbmlY0ktpg15mMulNY4n+A7iUKB1NwGgOIJ8oYqbmomBEGepyAxu/y2LKJklw01ZAV2iUCJTrVU5AKYn/kWBNnmJdLrMEh8bwSV10itp4b4fsO6rsYg+Mbcytw7AQce9am850chhQ+WAgda/wrMZiQBO8p86jPtVzHRjJMPYMKtwd0rrVEm/rC6JNgmuYhW8yknC+VyZUi6OjMjhn+uh9twn8sq9L6OWqLkh+x7v72U9HqKAj8CUZoxDuREWKpfaZRsa5KgNg8/HkfmjiCGoQzF9oXyg+mRaouRi57PQ1YtcJ9opqi3qFcpUR/HTgzcMVGX/KIWaSeWtBcdSK6+Sq5bPxmxJRP79DTIFg7VV14SuSkzWyicHoFB377vDjqJZmLdGXd/fcwOLdylL5z2YOcb+163LArbXK3SUeBspcxp3f8eKCsjV2e8uesRaZwHbKLLXlxmyTSDEYrF12HtJItVs6NA+uFJxCWqmOBNh7oyvvEvKtZiIvwM1ypQhy+0nUG36ALgFNdrBC2OyWauW3EhCekOjoCgDpMdhWtEktU3YOGCh1vmWRYm6tsTzCdGFqvcAI/mfhz9DuBuEqeJc2/YP+UtGZb3VI1T/4B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(6506007)(7416002)(7406005)(7366002)(54906003)(5660300002)(7336002)(86362001)(8676002)(186003)(82960400001)(82950400001)(52536014)(8936002)(122000001)(110136005)(508600001)(26005)(2906002)(53546011)(8990500004)(55016003)(9686003)(83380400001)(66556008)(10290500003)(76116006)(38100700002)(64756008)(66946007)(38070700005)(316002)(66476007)(7696005)(66446008)(33656002)(71200400001)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Uzg5MGZMaWFBaXRQZWs0N2FJVkVzalo1cjhyVUVtc3VYMHV6MTZLc1ZTUWhO?= =?utf-8?B?dFcvNHpaaWVSZFZZWG1xSkRZTW1QbTRubzczcHZnM05Db2ZZN2s5ODBOaXdM?= =?utf-8?B?cHRvOGVrZXRoV2txMXZOVzUwaHRRMk1OVVl5VnhnTXF6bFFwMW5INDZvRkdF?= =?utf-8?B?RU9CS3N5TENPV1kxeHBwbFR3bmFXaUwrTVpGampQSUk5b0xQbDZZQ0t6bXBW?= =?utf-8?B?ZWtFTE91OVM1NTFmTi9qSzdCVHhsMTkrcWVETUR4SS9nQk9lN3NBV2o2cDk2?= =?utf-8?B?WUNBYU9tcit6WTUwQUNXV0hZbWJKV05hemgyTGYxM2ZGL3I0dVVHOWdObFlr?= =?utf-8?B?ZTQzU0ZCZjF0S0ZMcmJ5V2FLeEJwKzQyUitzVVJXZ1lOeWtCdHhlbHduL2dD?= =?utf-8?B?b0g5ZjZNZFhWQWw4Z3EwWDZXcjVNZjY1ZVdMbTUwN3lVaFRPUWlqUDNlTU5v?= =?utf-8?B?VHpGWkI5VU1uWWtZS2ppeURhZEE2cllIMmc3ZmhnbUFpRFNuZElLeWk4cDZn?= =?utf-8?B?MzdwNmhqazczdVlMcytiVDVGa00ybGhZOGRkNzlhUUkyRFArQjdKaVh3TENl?= =?utf-8?B?WjMvN0d2SUEzVUMzSzV2TlNTb0FKU3RBZkg5STFibGxNNWdNdXlVVjhXQkFO?= =?utf-8?B?TitFUVFPMktXeEsxV1VJbjRvNkIxTURtaWhQS3hKQUdhYXRrc1V3cVhSUkxq?= =?utf-8?B?aURsL0p2M0JTenJzQkdLeGdyaTFTTDBueVRveGJRYXc4R1k1Q3dyampkd0pz?= =?utf-8?B?VUxzSFVwaC90MHJySlZvWFNmVlV2QTRCbnVnQUE2L1BtSHI5WENoQU9XcTlM?= =?utf-8?B?TUdhWmx6dkJETTk2QVNwMjFreDRWQUlObnFJRjByQ0dueHdsYTN4eWdDTjJt?= =?utf-8?B?K0haTjNxSU9nMkxiZUduUmJVMGJzSXBzNTF1V0NWK2ZCblpqd29GQzRKYjZW?= =?utf-8?B?blFxZEVNV0tjYnV2S2hNR2hOa2JYQnc3U0JYalJIeVR6bFRBL3NZcWtwZ0M2?= =?utf-8?B?ZkdMQkNZUzcvb3VIM0lVQUNEa3NyOVJsM21NNjQyQ2N0ZW01T3V1bXJJblBx?= =?utf-8?B?VjA4LzRnRnIwSXhXcnc1R0lrRlZ4SXFrTE14TFh5STU1dHR3eHp5QVpDdUJY?= =?utf-8?B?Z1Y5c21QVHRva1dBUUtpTW1lVTA5blNLTW1PL3FoczZMS3VmWCtUSHh1b3hl?= =?utf-8?B?K3pLRGIyem5HZFFndFQ1bVg0YTl6cjV0OHdKcGJxdnNjVHdtQlN4TjJqQ1BL?= =?utf-8?B?QXBBRmhTK2ZadHE1ZEJlaXNVU2dqa1dscmtZTitJTitlck1CZFk3dkhqMVJq?= =?utf-8?B?cnlXQVZVT05VTlhlbmg5ZktBZmsvSk5iTUw1UGJSSHZRZUR3cnNkYkdRV0Vn?= =?utf-8?B?SW9DUnNHTW5JdFhVbHFLU25yem1jWVEzckRjT1EwWjJEWVVUT0ZCSXBWSHpR?= =?utf-8?B?MUhLYTdzbmoreHJJdkpTWmp4T3oyTEZOWkRJY2JPLzV0cWdiRDRTMWloZEV5?= =?utf-8?B?NUhncGdEMjFQRzJKclMzU3JBbjVZY1BJY25FSzZBOXh1dEFaS1FRRjVMQ2Vt?= =?utf-8?B?RW9jV3B2RkhZWnN4MkJLNk9QemcrRHFnVklFWTVRQ2ZjOFp2QzY4RnBVMUwr?= =?utf-8?B?VGpzb1pPeUdCYTBNeFRoTlV2RlhUZjlOdGV2aGxvVjVHT3JqVUZmNmhiWGxH?= =?utf-8?B?c0s4ODdXNjNVWWVkVHYyY1BZamRvbW1YSkV2UUxjNU5nckJXUU90NStrc2Vy?= =?utf-8?B?SjFFSWkybm1sVTdaZGd5T1B3aTZOdDRHUEU3TzNwSTF3Z1YrbWN6VUQwR01S?= =?utf-8?B?eURFQU9YbWpnOHYwSzFwbENWTmN4UU5WbVJEMi9QZ1BvTlRDNzJ3SlZHVFo2?= =?utf-8?B?aElITDZ6eDI1dnExSVhrTS9POEFUREtrVGFlRkxla2pFRmFVL1FhYk1GTk1Z?= =?utf-8?B?YXRmODdxa1NXNHFNT1o4Qzd6U0VZQ3dTeWpTaGxHdFVMRjBqTkNPVjBDWm9y?= =?utf-8?B?QmFTd3NEQkJyZk9jRFlEQkQ1eHd0YnAzclpLV2lEWmVkK1E1VjgxR0x3Nkg0?= =?utf-8?B?dEMyQ3FDakl2d1BNT0lxQWNVODNEdllqdGFRdE9TTlp0b1hjTjdGYVpYSzFk?= =?utf-8?B?NndteitmL1BIOEZLdVdZcWFxVTg0dFJEUmRoZEs5bGdYanI2Y0ovN0Vra1FF?= =?utf-8?B?Qms0aE1nem41YmRFRS9RUjVEZjc4MlVMUFFFbnZ6YU1GckFDMW5MNnBsWllG?= =?utf-8?B?MG41cnVmUUo0Nk9mM1dlZmtEcEprNTdIRVBabFUxVEJrbytiNEJHSTdYM21w?= =?utf-8?B?L2tFV1pSUUpNckZraGpUUkR5b2U3Q3Mzbnp2UFc0ZkE1TDZnM0pWQ21PRUF2?= =?utf-8?Q?7+E0ENSNTCQZpn7M=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: acdb6465-6bb9-4403-84f7-08da2d2c8350 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2022 17:44:03.1149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NkMuoF21r2OIcMVUlulc+xEK2JKXdV4gyeFO5gANWyhUxAZ+FPx2yDzOdgj8vVPwcFsCzNZAmP8P2j9v7c0hX+2ZzXGXg1AyIjkDrrZmEI0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR21MB3087 RnJvbTogR3VpbGhlcm1lIEcuIFBpY2NvbGkgPGdwaWNjb2xpQGlnYWxpYS5jb20+IFNlbnQ6IEZy aWRheSwgQXByaWwgMjksIDIwMjIgMTE6MDQgQU0NCj4gDQo+IE9uIDI5LzA0LzIwMjIgMTQ6MzAs IE1pY2hhZWwgS2VsbGV5IChMSU5VWCkgd3JvdGU6DQo+ID4gRnJvbTogR3VpbGhlcm1lIEcuIFBp Y2NvbGkgPGdwaWNjb2xpQGlnYWxpYS5jb20+IFNlbnQ6IFdlZG5lc2RheSwgQXByaWwgMjcsIDIw MjINCj4gMzo0OSBQTQ0KPiA+PiBbLi4uXQ0KPiA+Pg0KPiA+PiBAQCAtMjg0Myw3ICsyODQzLDcg QEAgc3RhdGljIHZvaWQgX19leGl0IHZtYnVzX2V4aXQodm9pZCkNCj4gPj4gIAlpZiAobXNfaHlw ZXJ2Lm1pc2NfZmVhdHVyZXMgJiBIVl9GRUFUVVJFX0dVRVNUX0NSQVNIX01TUl9BVkFJTEFCTEUp IHsNCj4gPj4gIAkJa21zZ19kdW1wX3VucmVnaXN0ZXIoJmh2X2ttc2dfZHVtcGVyKTsNCj4gPj4g IAkJdW5yZWdpc3Rlcl9kaWVfbm90aWZpZXIoJmh5cGVydl9kaWVfcmVwb3J0X2Jsb2NrKTsNCj4g Pj4gLQkJYXRvbWljX25vdGlmaWVyX2NoYWluX3VucmVnaXN0ZXIoJnBhbmljX25vdGlmaWVyX2xp c3QsDQo+ID4+ICsJCWF0b21pY19ub3RpZmllcl9jaGFpbl91bnJlZ2lzdGVyKCZwYW5pY19oeXBl cnZpc29yX2xpc3QsDQo+ID4+ICAJCQkJCQkmaHlwZXJ2X3BhbmljX3JlcG9ydF9ibG9jayk7DQo+ ID4+ICAJfQ0KPiA+Pg0KPiA+DQo+ID4gVXNpbmcgdGhlIGh5cGVydmlzb3JfbGlzdCBoZXJlIHBy b2R1Y2VzIGEgYml0IG9mIGEgbWlzbWF0Y2guICBJbiBtYW55IGNhc2VzDQo+ID4gdGhpcyBub3Rp ZmllciB3aWxsIGRvIG5vdGhpbmcsIGFuZCB3aWxsIGRlZmVyIHRvIHRoZSBrbXNnX2R1bXAoKSBt ZWNoYW5pc20NCj4gPiB0byBub3RpZnkgdGhlIGh5cGVydmlzb3IgYWJvdXQgdGhlIHBhbmljLiAg IFJ1bm5pbmcgdGhlIGttc2dfZHVtcCgpDQo+ID4gbWVjaGFuaXNtIGlzIGxpbmtlZCB0byB0aGUg aW5mb19saXN0LCBzbyBJJ20gdGhpbmtpbmcgdGhlIEh5cGVyLVYgcGFuaWMgcmVwb3J0DQo+ID4g bm90aWZpZXIgc2hvdWxkIGJlIG9uIHRoZSBpbmZvX2xpc3QgYXMgd2VsbC4gIFRoYXQgd2F5IHRo ZSByZXBvcnRpbmcgYmVoYXZpb3INCj4gPiBpcyB0cmlnZ2VyZWQgYXQgdGhlIHNhbWUgcG9pbnQg aW4gdGhlIHBhbmljIHBhdGggcmVnYXJkbGVzcyBvZiB3aGljaA0KPiA+IHJlcG9ydGluZyBtZWNo YW5pc20gaXMgdXNlZC4NCj4gPg0KPiANCj4gSGkgTWljaGFlbCwgdGhhbmtzIGZvciB5b3VyIGZl ZWRiYWNrISBJIGFncmVlIHRoYXQgeW91ciBpZGVhIGNvdWxkIHdvcmssDQo+IGJ1dC4uLnRoZXJl IGlzIG9uZSBkb3duc2lkZTogaW1hZ2luZSB0aGUga21zZ19kdW1wKCkgYXBwcm9hY2ggaXMgbm90 IHNldA0KPiBpbiBzb21lIEh5cGVyLVYgZ3Vlc3QsIHRoZW4gd2Ugd291bGQgcmVseSBpbiB0aGUg cmVndWxhciBub3RpZmljYXRpb24NCj4gbWVjaGFuaXNtIFtodl9kaWVfcGFuaWNfbm90aWZ5X2Ny YXNoKCldLCByaWdodD8NCj4gQnV0Li4ueW91IHdhbnQgdGhlbiB0byBydW4gdGhpcyBub3RpZmll ciBpbiB0aGUgaW5mb3JtYXRpb25hbCBsaXN0LA0KPiB3aGljaC4uLndvbid0IGV4ZWN1dGUgKmJ5 IGRlZmF1bHQqIGJlZm9yZSBrZHVtcCBpZiBubyBrbXNnX2R1bXAoKSBpcw0KPiBzZXQuIFNvLCB0 aGlzIGxvZ2ljIGlzIGNvbnZvbHV0ZWQgd2hlbiB5b3UgbWl4IGl0IHdpdGggdGhlIGRlZmF1bHQg bGV2ZWwNCj4gY29uY2VwdCArIGtkdW1wLg0KDQpZZXMsIHlvdSBhcmUgcmlnaHQuICBCdXQgdG8g bWUgdGhhdCBzcGVha3MgYXMgbXVjaCB0byB0aGUgbGlua2FnZQ0KYmV0d2VlbiB0aGUgaW5mb3Jt YXRpb25hbCBsaXN0IGFuZCBrbXNnX2R1bXAoKSBiZWluZyB0aGUgY29yZQ0KcHJvYmxlbS4gIEJ1 dCBhcyBJIGRlc2NyaWJlZCBpbiBteSByZXBseSB0byBQYXRjaCAyNCwgSSBjYW4gbGl2ZSB3aXRo DQp0aGUgbGlua2FnZSBhcy1pcy4NCg0KRldJVywgZ3Vlc3RzIG9uIG5ld2VyIHZlcnNpb25zIG9m IEh5cGVyLVYgd2lsbCBhbHdheXMgcmVnaXN0ZXIgYQ0Ka21zZyBkdW1wZXIuICBUaGUgZmxhZ3Mg dGhhdCBhcmUgdGVzdGVkIHRvIGRlY2lkZSB3aGV0aGVyIHRvDQpyZWdpc3RlciBwcm92aWRlIGNv bXBhdGliaWxpdHkgd2l0aCBvbGRlciB2ZXJzaW9ucyBvZiBIeXBlci1WIHRoYXQgDQpkb27igJl0 IHN1cHBvcnQgdGhlIDRLIGJ5dGVzIG9mIG5vdGlmaWNhdGlvbiBpbmZvLg0KDQo+IA0KPiBNYXkg SSBzdWdnZXN0IHNvbWV0aGluZz8gSWYgcG9zc2libGUsIHRha2UgYSBydW4gd2l0aCB0aGlzIHBh dGNoIHNldCArDQo+IERFQlVHX05PVElGSUVSPXksIGluICpib3RoKiBjYXNlcyAod2l0aCBhbmQg d2l0aG91dCB0aGUga21zZ19kdW1wKCkNCj4gc2V0KS4gSSBkaWQgdGhhdCBhbmQgdGhleSBydW4g YWxtb3N0IGF0IHRoZSBzYW1lIHRpbWUuLi5JJ3ZlIGNoZWNrZWQgdGhlDQo+IG5vdGlmaWVycyBj YWxsZWQsIGl0J3MgbGlrZSBhbG1vc3Qgbm90aGluZyBydW5zIGluLWJldHdlZW4uDQo+IA0KPiBJ IGZlZWwgdGhlIHBhbmljIG5vdGlmaWNhdGlvbiBtZWNoYW5pc20gZG9lcyByZWFsbHkgZml0IHdp dGggYQ0KPiBoeXBlcnZpc29yIGxpc3QsIGl0J3MgYSBnb29kIG1hdGNoIHdpdGggdGhlIG5hdHVy ZSBvZiB0aGUgbGlzdCwgd2hpY2gNCj4gYWltcyBhdCBpbmZvcm1pbmcgdGhlIHBhbmljIG5vdGlm aWNhdGlvbiB0byB0aGUgaHlwZXJ2aXNvci9GVy4NCj4gT2YgY291cnNlIHdlIGNhbiBtb2RpZnkg aXQgaWYgeW91IHByZWZlci4uLmJ1dCBwbGVhc2UgdGFrZSBpbnRvIGFjY291bnQNCj4gdGhlIGtk dW1wIGNhc2UgYW5kIGhvdyBpdCBjb21wbGljYXRlcyB0aGUgbG9naWMuDQoNCkkgYWdyZWUgdGhh dCB0aGUgcnVudGltZSBlZmZlY3Qgb2Ygb25lIGxpc3QgdnMuIHRoZSBvdGhlciBpcyBuaWwuICBU aGUNCmNvZGUgd29ya3MgYW5kIGNhbiBzdGF5IGFzIHlvdSB3cml0dGVuIGl0Lg0KDQpJIHdhcyB0 cnlpbmcgdG8gYWxpZ24gZnJvbSBhIGNvbmNlcHR1YWwgc3RhbmRwb2ludC4gIEl0IHdhcyBhIGJp dA0KdW5leHBlY3RlZCB0aGF0IG9uZSBwYXRoIHdvdWxkIGJlIG9uIHRoZSBoeXBlcnZpc29yIGxp c3QsIGFuZCB0aGUNCm90aGVyIHBhdGggZWZmZWN0aXZlbHkgb24gdGhlIGluZm9ybWF0aW9uYWwg bGlzdC4gIFdoZW4gSSBzZWUNCmNvbmNlcHR1YWwgbWlzbWF0Y2hlcyBsaWtlIHRoYXQsIEkgdGVu ZCB0byB3YW50IHRvIHVuZGVyc3RhbmQgd2h5LA0KYW5kIGlmIHRoZXJlIGlzIHNvbWV0aGluZyBt b3JlIGZ1bmRhbWVudGFsIHRoYXQgaXMgb3V0LW9mLXdoYWNrLg0KDQoNCj4gDQo+IExldCBtZSBr bm93IHlvdXIgY29uc2lkZXJhdGlvbnMsIGluIGNhc2UgeW91IGNhbiBleHBlcmltZW50IHdpdGgg dGhlDQo+IHBhdGNoIHNldCBhcy1pcy4NCj4gQ2hlZXJzLA0KPiANCj4gDQo+IEd1aWxoZXJtZQ0K From xen-devel-bounces@lists.xenproject.org Tue May 03 17:44:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319839.540257 (Exim 4.92) (envelope-from ) id 1nlwZF-0002Pt-SX; Tue, 03 May 2022 17:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319839.540257; Tue, 03 May 2022 17:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwZF-0002Pm-MW; Tue, 03 May 2022 17:44:09 +0000 Received: by outflank-mailman (input) for mailman id 319839; Tue, 03 May 2022 17:44:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwZE-0002Pa-Bs for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:44:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwZD-0000Bs-Mg; Tue, 03 May 2022 17:44:07 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nlwZD-0005EE-Ge; Tue, 03 May 2022 17:44:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AJTxtIsZiRzarCT1oQta/EtUbVEGwPc7KZaUCcC4/X4=; b=HosHuBnQ4BSpOkfsCZ8WUsc/tU uBYnKe+rSBIbOQ2/ECqyPle4NZ+I2lDif5hLJwf+Lbpiu2R5udYBd0WBydl28wq3NJz53+zqB39Uh Bn0tv0ylLMpyPN0C5o9kRRTqWMtQ73rszc0IaJ6xAM4dAit6lCnzFYIZskfwq9mOQPQc=; Message-ID: <074a5ae8-cade-3343-0c18-8122c85fecc3@xen.org> Date: Tue, 3 May 2022 18:44:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220428094625.382970-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: <20220428094625.382970-1-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/04/2022 10:46, Michal Orzel wrote: > Function unmap_common_complete (common/grant_table.c) defines and sets > a variable ld that is later on passed to a macro: > gnttab_host_mapping_get_page_type(). > On Arm this macro does not make use of any arguments causing a compiler > to warn about unused-but-set variable (when -Wunused-but-set-variable > is enabled). Fix it by casting the arguments to void in macro's body. > > While there, take the opportunity to modify other macros in this file > that do not make use of all the arguments to prevent similar issues in > the future. > > Signed-off-by: Michal Orzel > --- > Changes since v1: > -standalone patch carved out from a series (other patches already merged) > -v1 was ([3/8] gnttab: Remove unused-but-set variable) > -modify macro on Arm instead of removing ld variable > --- > xen/arch/arm/include/asm/grant_table.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h > index d31a4d6805..5bcd1ec528 100644 > --- a/xen/arch/arm/include/asm/grant_table.h > +++ b/xen/arch/arm/include/asm/grant_table.h > @@ -31,10 +31,11 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) > > int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, > unsigned int flags, unsigned int cache_flags); > -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) > +#define gnttab_host_mapping_get_page_type(ro, ld, rd) \ > + ((void)(ro), (void)(ld), (void)(rd), 0) I would switch to a static inline helper: static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, struct domian *rd) { return false; } Note the switch from 0 to false as the function is technically returning a boolean (see the x86 implementation). > int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, > unsigned long new_gpaddr, unsigned int flags); > -#define gnttab_release_host_mappings(domain) 1 > +#define gnttab_release_host_mappings(domain) ((void)(domain), 1) Same here. > > /* > * The region used by Xen on the memory will never be mapped in DOM0 > @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, > }) > > #define gnttab_shared_gfn(d, t, i) \ > - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) > + ((void)(d), \ > + ((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) > > -#define gnttab_status_gfn(d, t, i) \ > - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) > +#define gnttab_status_gfn(d, t, i) \ > + ((void)(d), \ > + ((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) I share Jan's opinion here. If we want to evaluate d, then we should make sure t and i should be also evaluated once. However, IIRC, they can't be turned to static inline because the type of t (struct grant_table) is not fully defined yet. Cheers -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 17:58:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 17:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319852.540279 (Exim 4.92) (envelope-from ) id 1nlwnB-0004sS-E3; Tue, 03 May 2022 17:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319852.540279; Tue, 03 May 2022 17:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwnB-0004sL-B0; Tue, 03 May 2022 17:58:33 +0000 Received: by outflank-mailman (input) for mailman id 319852; Tue, 03 May 2022 17:58:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwn7-0004sF-KH for xen-devel@lists.xenproject.org; Tue, 03 May 2022 17:58:32 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1badf24-cb0a-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 19:58:27 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlwlp-0009Ge-E7; Tue, 03 May 2022 19:57:09 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1badf24-cb0a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V5OlIrQZACaQuAvW/eyS6B/1Zwik+ew1I16AuySJnIg=; b=gjAznZuoR4/m9kKzzhqzuGrpkT xtMc6cJN1cBQNuGvg6XyrPFTI1ixzsXC2Qdeh+HpywC/rv8GnlBjcukr7ohfRrQ9c8Vv3g1C+degf BKLK1MQn4ihq1pQ2tLJ4K6bqakBNB70xc08nkdXZEPCNZh6tlfswNgMdLLmr3btmvO+ASGsTB1McO bjtFx1IEqa+FJgHwAOYextuGE9H3QAozC9Ow4n5OqOMhRYX1e/PE6FhaxFfCh6NihoHwyZzrtpHli GlpKhk1VLnB8Ef855kd7QLHnrR7/smJu3dr6Yo1GdqpDjEKpnWDlt7/NfiaCRZ690xo8EgxQrZVRx GY9vS48w==; Message-ID: Date: Tue, 3 May 2022 14:56:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: "Michael Kelley (LINUX)" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" Cc: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , David Gow , "David S. Miller" , Dexuan Cui , Doug Berger , Evan Green , Florian Fainelli , Haiyang Zhang , Hari Bathini , Heiko Carstens , Julius Werner , Justin Chen , KY Srinivasan , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Scott Branden , Sebastian Reichel , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <0147d038-571b-0802-c210-ccd4d52cd5dd@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/05/2022 14:44, Michael Kelley (LINUX) wrote: > [...] >> >> Hi Michael, thanks for your feedback! I agree that your idea could work, >> but...there is one downside: imagine the kmsg_dump() approach is not set >> in some Hyper-V guest, then we would rely in the regular notification >> mechanism [hv_die_panic_notify_crash()], right? >> But...you want then to run this notifier in the informational list, >> which...won't execute *by default* before kdump if no kmsg_dump() is >> set. So, this logic is convoluted when you mix it with the default level >> concept + kdump. > > Yes, you are right. But to me that speaks as much to the linkage > between the informational list and kmsg_dump() being the core > problem. But as I described in my reply to Patch 24, I can live with > the linkage as-is. Thanks for the feedback Michael! > [...] >> I feel the panic notification mechanism does really fit with a >> hypervisor list, it's a good match with the nature of the list, which >> aims at informing the panic notification to the hypervisor/FW. >> Of course we can modify it if you prefer...but please take into account >> the kdump case and how it complicates the logic. > > I agree that the runtime effect of one list vs. the other is nil. The > code works and can stay as you written it. > > I was trying to align from a conceptual standpoint. It was a bit > unexpected that one path would be on the hypervisor list, and the > other path effectively on the informational list. When I see > conceptual mismatches like that, I tend to want to understand why, > and if there is something more fundamental that is out-of-whack. > Totally agree with you here, I am like that as well - try to really understand the details, this is very important specially in this patch set, since it's a refactor and affects every user of the notifiers infrastructure. Again, just to double-say it: feel free to suggest any change for the Hyper-V portion (might as well for any patch in the series, indeed) - you and the other Hyper-V maintainers own this code and I'd be glad to align with your needs, you are honor citizens in the panic notifiers area, being one the most heavy users for that =) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 03 18:07:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319858.540289 (Exim 4.92) (envelope-from ) id 1nlwvh-0006PC-9t; Tue, 03 May 2022 18:07:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319858.540289; Tue, 03 May 2022 18:07:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwvh-0006P5-6v; Tue, 03 May 2022 18:07:21 +0000 Received: by outflank-mailman (input) for mailman id 319858; Tue, 03 May 2022 18:07:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwvg-0006Oz-6n for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:07:20 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de906321-cb0b-11ec-a406-831a346695d4; Tue, 03 May 2022 20:07:19 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlwvB-000AFb-By; Tue, 03 May 2022 20:06:49 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de906321-cb0b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WYW7A1AoQOryf4HZjlafyZKPnHAKwmZXZQ0bWMyg1OM=; b=IJk7PjWXbuJYxjyJajFcqu+Mif 2fd51zOcNQRJjfhVuzSoQO9mBBwmDdVBHLRqON1BGirC1Vk8+AoSYO3LiHwD+UN1A9emX95LT9quF x9JKLy4HImLNSn0mqdv7zEp5uPj6Lvn09d1aUkR/Hf14MsP+c2ZYwmIAyLwNg0VIkqGkELR5aYgVO 0xdNy0LqxmoLJzxFqk/oO1+b/WdJOIRWXo4fLVInmE2Yo6XsUwQPE4Yo6Y1hA1Cl8oTHfkCacBbdC IAv1LZ4HQl0+X38MUmMlSpApf42pMuXeETEON4eFrPMp1+0PSjab3dBLEc1woBTNMiXT6t4Yfmen7 fHSrzQsQ==; Message-ID: <12b5a753-c0f1-9da5-f269-483384752837@igalia.com> Date: Tue, 3 May 2022 15:06:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: "Michael Kelley (LINUX)" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" Cc: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <50178dfb-8e94-f35f-09c3-22fe197550ef@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/05/2022 14:31, Michael Kelley (LINUX) wrote: > [...] > > To me, it's a weak correlation between having a kmsg dumper, and > wanting or not wanting the info level output to come before kdump. > Hyper-V is one of only a few places that register a kmsg dumper, so most > Linux instances outside of Hyper-V guest (and PowerPC systems?) will have > the info level output after kdump. It seems like anyone who cared strongly > about the info level output would set the panic_notifier_level to 1 or to 3 > so that the result is more deterministic. But that's just my opinion, and > it's probably an opinion that is not as well informed on the topic as some > others in the discussion. So keeping things as in your patch set is not a > show-stopper for me. > > However, I would request a clarification in the documentation. The > panic_notifier_level affects not only the hypervisor, informational, > and pre_reboot lists, but it also affects panic_print_sys_info() and > kmsg_dump(). Specifically, at level 1, panic_print_sys_info() and > kmsg_dump() will not be run before kdump. At level 3, they will > always be run before kdump. Your documentation above mentions > "informational lists" (plural), which I take to vaguely include > kmsg_dump() and panic_print_sys_info(), but being explicit about > the effect would be better. > > Michael Thanks again Michael, to express your points and concerns - great idea of documentation improvement here, I'll do that for V2, for sure. The idea of "defaulting" to skip the info list on kdump (if no kmsg_dump() is set) is again a mechanism that aims at accommodating all users and concerns of antagonistic goals, kdump vs notifier lists. Before this patch set, by default no notifier executed before kdump. So, the "pendulum" was strongly on kdump side, and clearly this was a sub-optimal decision - proof of that is that both Hyper-V / PowerPC code forcibly set the "crash_kexec_post_notifiers". The goal here is to have a more lightweight list that by default runs before kdump, a secondary list that only runs before kdump if there's usage for that (either user sets that or kmsg_dumper set is considered a valid user), and the remaining notifiers run by default only after kdump, all of that very customizable through the levels idea. Now, one thing we could do to improve consistency for the hyper-v case: having a kmsg_dump_once() helper, and *for Hyper-V only*, call it on the hypervisor list, within the info notifier (that would be moved to hypervisor list, ofc). Let's wait for more feedback on that, just throwing some ideas in order we can have everyone happy with the end-result! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 03 18:08:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:08:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319866.540301 (Exim 4.92) (envelope-from ) id 1nlwwd-0006uQ-JQ; Tue, 03 May 2022 18:08:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319866.540301; Tue, 03 May 2022 18:08:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwwd-0006uJ-GE; Tue, 03 May 2022 18:08:19 +0000 Received: by outflank-mailman (input) for mailman id 319866; Tue, 03 May 2022 18:08:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwwc-0006u9-33 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:08:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwwb-0000f7-M6; Tue, 03 May 2022 18:08:17 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nlwwb-0007Ge-GN; Tue, 03 May 2022 18:08:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CT1uxsqTeygpt1GvGkEWE44P/bWQU55+s2GX7aH/zV0=; b=Y997Caa43h7WV8qeqBrHvrzUdj tVsWK4cx5BAXPXPsBvxKtS0rm5ax1F35q5YZUenp3S50KwrWrLT4eBbDd7g4yt9XeN5gRMNMRePh8 Gj+QgnwM11iMb7lUgUQ1q3QxTkYBiggXVnuonflGmELnKHFJMHrtzXrc27jOIAteXziw=; Message-ID: Date: Tue, 3 May 2022 19:08:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 03/05/2022 10:38, Bertrand Marquis wrote: > Sync arm64 sysreg bit shift definitions with status of Linux kernel as > of 5.18-rc3 version (linux commit b2d229d4ddb1). > Sync ID registers sanitization with the status of Linux 5.18-rc3 and add > sanitization of ISAR2 registers. Please outline which specific commits you are actually backported. This would help to know what changed, why and also keep track of the autorships. When possible, the changes should be separated to match each Linux commit we backport. > Complete AA64ISAR2 and AA64MMFR1 with more fields. > While there add a comment for MMFR bitfields as for other registers in > the cpuinfo structure definition. AFAICT, this patch is doing 3 different things that are somewhat related: - Sync cpufeature.c - Update the headers with unused defines - Complete the structure cpufeature.h All those changes seem to be independent, so I think they should be done separately. This would help to keep the authorship right (your code vs Linux code). > > Signed-off-by: Bertrand Marquis > --- > xen/arch/arm/arm64/cpufeature.c | 18 +++++- > xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- > xen/arch/arm/include/asm/cpufeature.h | 14 ++++- > 3 files changed, 91 insertions(+), 17 deletions(-) > > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > index 6e5d30dc7b..d9039d37b2 100644 > --- a/xen/arch/arm/arm64/cpufeature.c > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { > ARM64_FTR_END, > }; > > +static const struct arm64_ftr_bits ftr_id_aa64isar2[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_CLEARBHB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), So we are using CONFIG_ARM64_PTR_AUTH. But this is not defined in Kconfig. I realize there are more in cpufeature.c (somehow I didn't spot during preview), but I don't think this is right to define CONFIG_* without an associated entry in Kconfig. In one hand, I think it would be odd to add an entry in Kconfig because Xen wouldn't properly work if selected. On the other hand, it is useful if when we will implement pointer authentification. So maybe we should just add the Kconfig entry with a comment explaning why they are not selected. Any thoughts? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 18:14:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:14:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319876.540312 (Exim 4.92) (envelope-from ) id 1nlx2H-0000It-97; Tue, 03 May 2022 18:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319876.540312; Tue, 03 May 2022 18:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlx2H-0000Im-64; Tue, 03 May 2022 18:14:09 +0000 Received: by outflank-mailman (input) for mailman id 319876; Tue, 03 May 2022 18:14:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlx2F-0000If-Mt for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:14:07 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-cusazlp170100000.outbound.protection.outlook.com [2a01:111:f403:c111::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0da3c22-cb0c-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 20:14:06 +0200 (CEST) Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21) by PH7PR21MB3140.namprd21.prod.outlook.com (2603:10b6:510:1d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.6; Tue, 3 May 2022 18:13:52 +0000 Received: from PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df]) by PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::dd77:2d4d:329e:87df%5]) with mapi id 15.20.5250.006; Tue, 3 May 2022 18:13:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0da3c22-cb0c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=he4GrjUJs+pbbWOQAVUF9nF+ZBMO4NsBCGINPa3zG0Bz1QzGye7Hk6i58aQzP3Blsk4b3K481euJuFtVdA2Zl8Y9mhnDmx4UXp3nDA+I9uaN0WjUXEvwqxyunj30uyFdLPvsh9QNCwG5izqZo+EK0KzoTtamKSkqRqHzvoVQurdi/xURo6vL0AtXF6EhXCNcLLW4aPu7HrQvw+xU2zbD/dD/frLKp7O3y+bzOKLeBqXNtsEsnaWHIUMmyPLivm3BGEnNiyZpnm/0uTsvEZ6C6Plz7pX/bbiWmLQuAfY6WUyxI/e9r/KBnxIFktKIoSecveRqgN64wh8mo4s0A8CH4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHdWyr/lQ4oMAILHgYnTcyVdhz+H5tpb/ZbxMPdRznY=; b=Z8Q7zSE2FHB3mX9406scaZ7L/J5DU+5rZWfUrzWaCXcLS/K/Bms05PaCHEzN2F0GO7mbO6MP/3efMdcYTEEe6qc6Zsvo2EtFOPVsWEPlAvCGrkAh+cFw5roduWkgm8+olQJb+7ki2gL4oCfx5PGOE4yNt+SwPcn5h9gLzy86+3AHBjA6HCldqjdgt7TTYQ8wvJjH4tT01cap8x/HBDfBqMP1s1hw6+naeoy1L5qe3eXoSLNH9T1uTOMsGhvGrZM99GizzxF42pM4Xn/M5rWCreeHz3I/LVKPYt0pTXJYbtmxmNqft5UKqxvNh52cg/eUbLZXIi8dpy/iPrIu+ZR2bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uHdWyr/lQ4oMAILHgYnTcyVdhz+H5tpb/ZbxMPdRznY=; b=N8b4zUYeoSjVoBnIOHZk9x7r326uVrpKbKzx6XXMOIrzFUAHQx5Vf0lGVGrXZlrXWa6AW+P6rzthVyShps/A6r3TZdabpgEBaTS9lCeVdBHNNE//vXD9jQ0tGm9xQNx3bTBkWGRMD+GYCBn7m/MbMeekivw2v/V0MngTJJcvwwM= From: "Michael Kelley (LINUX)" To: "Guilherme G. Piccoli" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" , Andrea Parri , Dexuan Cui , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , Tianyu Lan , Wei Liu Subject: RE: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers Thread-Topic: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers Thread-Index: AQHYWonHTKAKlsJlK0mi6B2rKp5WnK0HF4GAgABmLoCABfgOgA== Date: Tue, 3 May 2022 18:13:52 +0000 Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-17-gpiccoli@igalia.com> <2787b476-6366-1c83-db80-0393da417497@igalia.com> In-Reply-To: <2787b476-6366-1c83-db80-0393da417497@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=b41f9d07-1c9e-45a3-8ea4-5e837b666291;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-05-03T17:44:15Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40ac3dec-95e5-41bb-b783-08da2d30adb3 x-ms-traffictypediagnostic: PH7PR21MB3140:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FnIu9JpCdSU0bQtZUV5dEj7PTdHFP+LtwhgAsFHYKotKFZawzkNh1lUKYQokTK/oCA2oTWbBewVD72G73c3XzAhVtFhiLcEIRL5qdiF/xtEroSX1oj54Gq2PNnlzvUiCrd5TgrPM8LLQol7Wv8rD+kp4HyGQqXAFjMMN/Q2b4ZnVWNQ00/Vk5ypMiLQC/Ge/LCjSKneNG1xvmc2w9eX5SQ+/NyoLbnPryEqqBn7XuhMGDPslUzBOCcBN9YzUH68DS3hVF/Y5YhZtptZAZl2fTODZaJ2OwlykQp2I7Y6oG604LaPSsD0WPRmfpuaxoaOJIBdg0z+sdf+ubxmrC2Lr6MC6CrHAYG2L9kYqxZ4TqUtfoYZe7iudHWuxS69IuDr6iBZqdpgoDeHt3w3VzP9WxgI8jPwJCQwQv1mBZQJmhCbOFyKbCW388TQmxGJBM+r/qP9RJnhIgeQ5lWNdHZQKBsJxXz9+WhNGVkCgDdXgrY8MH9TQ2Sf3xIRTrK1LLXk+zeEbeaxHdfl56bAKPB5NuJiRqc1btjZYZQk16htM9PY07KltFPdC2rrMXk7odT8u+eVy+MBlh+KWuBEiY95z+g0uDfcC050kDJa8XsOULxaq6Wf52amSPQlpcL9dg6HDsB0YS1ka7dqVfJuoxshV5S/Ebu1mJvmoKPDJAT4s5+acqoljARobFpoBsZLvfqrvHnUWSvRY+07fOtsxPKpPoCJ8/mvijdRVVId+MDSBmoOuSdmutfrJNctuNoWS/Afw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(451199009)(7366002)(10290500003)(5660300002)(508600001)(52536014)(7416002)(8936002)(9686003)(26005)(122000001)(71200400001)(7406005)(38070700005)(38100700002)(66556008)(86362001)(53546011)(76116006)(7696005)(110136005)(8676002)(66446008)(66476007)(64756008)(4326008)(6506007)(54906003)(66946007)(82950400001)(82960400001)(2906002)(186003)(55016003)(316002)(83380400001)(8990500004)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NDhJRGpJaGwrNTR3ZDdabHBaaGZVMTUvb1hqVWwrclBlK0wrMzIzQmRXWlVN?= =?utf-8?B?RFB5cC91SGNPZ09CQ1RhWDZEbDBnZHI5d29CRFFlb2ZRdzYyZ3ViV2VmWVZS?= =?utf-8?B?L1NqZ3hyM3BTTW9YT2pQZFBtUVN1SmFERjM4Sk5qT2RlbkVQWU55bGJLZ3FE?= =?utf-8?B?TmJyZmV4VHJ3MjQvV212REJjTDJlMHZabGZ1RWtUUHpnUGVOUlNya2lNZHpR?= =?utf-8?B?V3lzZm1nb1FDZVR3Z3JmUVZPTEVEYkZCSUVjUVhpbU1QRkpwWEVOK2NzRU8v?= =?utf-8?B?Y0hSN0toQWFJRFFrVXZJR2tlZUtnd3JmOTVObnJla0NLSVE2Y1haRTlEd3Vw?= =?utf-8?B?eVUveFhjVWMybVE4V2FHZWNDdzY3d3habUZMcndIK21GdHp3Wmw3RWFMTEtu?= =?utf-8?B?NURSWU5UY28xbzdYL1hINmtEdUZGd210MTFSVGVvVWFnMnJwT3YxVDJCa1dK?= =?utf-8?B?cm8ra2ppeHdnalJnRDM5aU8zZFBjMEoyZXhUU3ZTZ05vSFZOT1hHTFFGOXNB?= =?utf-8?B?U1BaVXFxOGRhTWRadnZ4YW5yYWFrZU5oWlJ5N0xvb05ZU0JtSW9ZdE1hVmRy?= =?utf-8?B?RXpGS3h5a2JkYkJEbW0wcVF2eWZtSVpsTVF1MnJ0dUxqTEdFY1htaThXY0g4?= =?utf-8?B?T0QzODZMQVB1ejl4b3ZOWHA4TDErbWxzNFpjOVNqNjUrbGJVVGpieS9SV2pS?= =?utf-8?B?VFZPU1ErQXlFbTZZek45Nk5WZVF5eThLQUk1bmxSMUxyeDgwUjFJMHQwQkc1?= =?utf-8?B?QmdSVjFyQ1p3RzV0SDRCTjhKdzFwdU5Ec0M0SDV4M2JBbHJxRXJhRm1IaW9E?= =?utf-8?B?bHF5WHlCczd3bU9VeXhERGw0L21jalFmOGxBTHhBWEhiT3pIMU5zb0FkZDNi?= =?utf-8?B?QUZGUEFoSjRiNUx4ZUxoekRZeHhwRmd5R3lSOTNJNVhXbzYvaTVCOFU1M0NY?= =?utf-8?B?YUtiWXZuQlJDcnYzWUVDRURpWmYxb0ppaXN6cWU2L1U4YzBFNGdXQ0FJWHNU?= =?utf-8?B?WlBkTjdzSFc4Sk1QSEYwMERjY0xnSGpUVTdhMmJqV3ZQYVYyN1dBT0pzNVVL?= =?utf-8?B?OHQ1QXg5VXJic3p1WHdDc2xKRklMOUk2KzRYTmMvWHBDQ3B6d2hLSVkxRm9M?= =?utf-8?B?aWtCaktiYWx4blJGVjQxV3dJczBSTzQzNVNMYVdWZTJpUG5GVUJWV2RNTHNI?= =?utf-8?B?bk5hRlJNVmZFOENOVk1nOVVDMldvcUlGRzVMR0dCNnBRVDBySVNvWVZrUnFG?= =?utf-8?B?SFMrVVh6SW9VVWZ0N2pUNDFiRStHaVNiVkZJZGJSQ2c5aERqRnBuZDg1T3dy?= =?utf-8?B?dDhKdngyWFZBSGtUS2lacmlPYWJDay9LYkFNc0JZM1JNSmRSQ2hjeGRqa1pj?= =?utf-8?B?eFI5S2s1MkcwOEI4dWFjU1ordnlCM0IrQnhycWJWYVEwVXVLTVIyeGJabGhJ?= =?utf-8?B?N1YvTkhWNVlBUXVyaUF2UkZ0ZnlvdEhxbEJWU3FsMTM1Sjc4QWxQdy8xNVMw?= =?utf-8?B?K05NazBSdkV6VjllUllTdzFUK2k0NExGSlpVbkcyUVBqSjEwS3lpYVBucGd5?= =?utf-8?B?eXZiM3ZaMjM5OTF1S3JNYmY0SXlmQ2RiODNZY1Npd3JXcGxOTW03a1YycFN3?= =?utf-8?B?V3UydCt4NkxEWWhxMFh0YjNLWElJdHRablBrVzdPZDM5azBYQm5RNUxnbHNV?= =?utf-8?B?eVhKdDIxSHl5d01DZEp1emFCK3VOM2VKekF1Y2w3N0gwTHVnZmNXVUtrL2M4?= =?utf-8?B?UXlSc0YybWxncEVJZVNBNXkxWEVhcForc3Y5TGJZUjNsNEwwcWlPaTJjME44?= =?utf-8?B?VjJ1K25uQmZ0RGtMaHIrb0oxQnJ1Sm9vMGdTd1RxVklDcFoveHcybkxlOTJ3?= =?utf-8?B?eXhvWkRySEx5WlBmcG5KdEtBalZrcHNwMXZwbWJnYUpHU1dsT3ltMFgzRVd3?= =?utf-8?B?Nk03eEZHOWRRUkIvYVZXZGJTdXJibnpvcHpuby9ESThJTGNKVTFjYkxQQWlK?= =?utf-8?B?VlBVcVI5VmtYYms2bFF5cFl0WUFoOW9YOFNkZTh1bG5DQlJoWkJNQ0g0VU5B?= =?utf-8?B?M2RHRW1CNEtFRnFaVkhSN2p1UnVFczFpdHRYQ3JadnZoSzJyZFlqKzl2SlJO?= =?utf-8?B?VWpDVGlDSVdmbTJIOWNVa3hMMm9vMHFVOTQvSng0RG9HWEgvdTN0VkdtUFcr?= =?utf-8?B?amE1NWRNWUlMeUJKQk40aU9pUGRrU1E0SmxZTTdRMWh4RUhFOVpkR2hTRXps?= =?utf-8?B?aDRxeUdKbHJTc281c0hObXdkbCt2TFE1aHVES0VBczgwMjE2b0pqYmVOUTNv?= =?utf-8?B?VnVaZlRiTmpjQWVUeE00V0p5cERtUWpuVFU4YVFOd1V3ZHY5SGJqRXNYLzhW?= =?utf-8?Q?teI2zGknLdIGYpMk=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40ac3dec-95e5-41bb-b783-08da2d30adb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2022 18:13:52.1349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4ui4kPv1QwwCeWcwraRIbiZaeFVEkUzs/5EQ9xwdazJ0cXTpmhELoQLf2pdHck77pdCw8h9HzCi86jIk8NpF5JK+JkBkOskELkyDCBUt8k0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3140 RnJvbTogR3VpbGhlcm1lIEcuIFBpY2NvbGkgPGdwaWNjb2xpQGlnYWxpYS5jb20+IFNlbnQ6IEZy aWRheSwgQXByaWwgMjksIDIwMjIgMzozNSBQTQ0KPiANCj4gSGkgTWljaGFlbCwgZmlyc3Qgb2Yg YWxsIHRoYW5rcyBmb3IgdGhlIGdyZWF0IHJldmlldywgbXVjaCBhcHByZWNpYXRlZC4NCj4gU29t ZSBjb21tZW50cyBpbmxpbmUgYmVsb3c6DQo+IA0KPiBPbiAyOS8wNC8yMDIyIDE0OjE2LCBNaWNo YWVsIEtlbGxleSAoTElOVVgpIHdyb3RlOg0KPiA+IFsuLi5dDQo+ID4+IGh5cGVydmlzb3IgSS9P IGNvbXBsZXRpb24pLCBzbyB3ZSBwb3N0cG9uZSB0aGF0IHRvIHJ1biBsYXRlLiBCdXQgbW9yZQ0K PiA+PiByZWxldmFudDogdGhpcyAqc2FtZSogdm1idXMgdW5sb2FkaW5nIGhhcHBlbnMgaW4gdGhl IGNyYXNoX3NodXRkb3duKCkNCj4gPj4gaGFuZGxlciwgc28gaWYga2R1bXAgaXMgc2V0LCB3ZSBj YW4gc2FmZWx5IHNraXAgdGhpcyBwYW5pYyBub3RpZmllciBhbmQNCj4gPj4gZGVmZXIgc3VjaCBj bGVhbi11cCB0byB0aGUga2V4ZWMgY3Jhc2ggaGFuZGxlci4NCj4gPg0KPiA+IFdoaWxlIHRoZSBs YXN0IHNlbnRlbmNlIGlzIHRydWUgZm9yIEh5cGVyLVYgb24geDg2L3g2NCwgaXQncyBub3QgdHJ1 ZSBmb3INCj4gPiBIeXBlci1WIG9uIEFSTTY0LiAgeDg2L3g2NCBoYXMgdGhlICdtYWNoaW5lX29w cycgZGF0YSBzdHJ1Y3R1cmUNCj4gPiB3aXRoIHRoZSBhYmlsaXR5IHRvIHByb3ZpZGUgYSBjdXN0 b20gY3Jhc2hfc2h1dGRvd24oKSBmdW5jdGlvbiwgd2hpY2gNCj4gPiBIeXBlci1WIGRvZXMgaW4g dGhlIGZvcm0gb2YgaHZfbWFjaGluZV9jcmFzaF9zaHV0ZG93bigpLiAgQnV0IEFSTTY0DQo+ID4g aGFzIG5vIG1lY2hhbmlzbSB0byBwcm92aWRlIHN1Y2ggYSBjdXN0b20gZnVuY3Rpb24gdGhhdCB3 aWxsIGV2ZW50dWFsbHkNCj4gPiBkbyB0aGUgbmVlZGVkIHZtYnVzX2luaXRpYXRlX3VubG9hZCgp IGJlZm9yZSBydW5uaW5nIGtkdW1wLg0KPiA+DQo+ID4gSSdtIG5vdCBpbW1lZGlhdGVseSBzdXJl IHdoYXQgdGhlIGJlc3Qgc29sdXRpb24gaXMgZm9yIEFSTTY0LiAgQXQgdGhpcw0KPiA+IHBvaW50 LCBJJ20ganVzdCBwb2ludGluZyBvdXQgdGhlIHByb2JsZW0gYW5kIHdpbGwgdGhpbmsgYWJvdXQg dGhlIHRyYWRlb2Zmcw0KPiA+IGZvciB2YXJpb3VzIHBvc3NpYmxlIHNvbHV0aW9ucy4gIFBsZWFz ZSBkbyB0aGUgc2FtZSB5b3Vyc2VsZi4gOi0pDQo+ID4NCj4gDQo+IE9oLCB5b3UncmUgdG90YWxs eSByaWdodCEgSSBqdXN0IGFzc3VtZWQgQVJNNjQgd291bGQgdGhlIHRoZSBzYW1lLCBteQ0KPiBi YWQuIEp1c3QgdG8gcHJvcG9zZSBzb21lIGFsdGVybmF0aXZlcywgc28geW91L290aGVycyBjYW4g YWxzbyBkaXNjdXNzDQo+IGhlcmUgYW5kIHdlIGNhbiByZWFjaCBhIGNvbnNlbnN1cyBhYm91dCB0 aGUgdHJhZGUtb2ZmczoNCj4gDQo+IChhKSBXZSBjb3VsZCBmb3JnZXQgYWJvdXQgdGhpcyBjaGFu Z2UsIGFuZCBhbHdheXMgZG8gdGhlIGNsZWFuLXVwIGhlcmUsDQo+IG5vdCByZWx5aW5nIGluIG1h Y2hpbmVfY3Jhc2hfc2h1dGRvd24oKS4NCj4gUHJvOiByZWFsbHkgc2ltcGxlLCBiZWhhdmVzIHRo ZSBzYW1lIGFzIGl0IGlzIGRvaW5nIGN1cnJlbnRseS4NCj4gQ29uOiBsZXNzIGVsZWdhbnQvY29u Y2lzZSwgZG9lc24ndCBhbGxvdyBhcm02NCBjdXN0b21pemF0aW9uLg0KPiANCj4gKGIpIEFkZCBh IHdheSB0byBhbGxvdyBBUk02NCBjdXN0b21pemF0aW9uIG9mIHNodXRkb3duIGNyYXNoIGhhbmRs ZXIuDQo+IFBybzogbWF0Y2hlcyB4ODYsIG1vcmUgY3VzdG9taXphYmxlLCBpbXByb3ZlcyBhcm02 NCBhcmNoIGNvZGUuDQo+IENvbjogQSB0YWQgbW9yZSBjb21wbGV4Lg0KPiANCj4gQWxzbywgYSBx dWVzdGlvbiB0aGF0IGNhbWUtdXA6IGlmIEFSTTY0IGhhcyBubyB3YXkgb2YgY2FsbGluZyBzcGVj aWFsDQo+IGNyYXNoIHNodXRkb3duIGhhbmRsZXIsIGhvdyBjYW4geW91IGV4ZWN1dGUgaHZfc3Rp bWVyX2NsZWFudXAoKSBhbmQNCj4gaHZfc3luaWNfZGlzYWJsZV9yZWdzKCkgdGhlcmU/IE9yIGFy ZSB0aGV5IG5vdCByZXF1aXJlZCBpbiBBUk02ND8NCj4gDQoNCk15IHN1Z2dlc3Rpb24gaXMgdG8g ZG8gKGEpIGZvciBub3cuICBJIHN1c3BlY3QgKGIpIGNvdWxkIGJlIGEgbW9yZQ0KZXh0ZW5kZWQg ZGlzY3Vzc2lvbiBhbmQgSSB3b3VsZG4ndCB3YW50IHlvdXIgcGF0Y2ggc2V0IHRvIGdldCBoZWxk DQp1cCBvbiB0aGF0IGRpc2N1c3Npb24uICBJIGRvbid0IGtub3cgd2hhdCB0aGUgc2Vuc2Ugb2Yg dGhlIEFSTTY0DQptYWludGFpbmVycyB3b3VsZCBiZSB0b3dhcmQgKGIpLiAgVGhleSBoYXZlIHRy aWVkIHRvIGF2b2lkIHBpY2tpbmcNCnVwIGNvZGUgd2FydHMgbGlrZSBoYXZlIGFjY3VtdWxhdGVk IG9uIHRoZSB4ODYveDY0IHNpZGUgb3ZlciB0aGUNCnllYXJzLCBhbmQgSSBhZ3JlZSB3aXRoIHRo YXQgZWZmb3J0LiAgQnV0IGFzIG1vcmUgYW5kIHZhcmllZA0KaHlwZXJ2aXNvcnMgYmVjb21lIGF2 YWlsYWJsZSBmb3IgQVJNNjQsIGl0IHNlZW1zIGxpa2UgYSBmcmFtZXdvcmsNCmZvciBzdXBwb3J0 aW5nIGEgY3VzdG9tIHNodXRkb3duIGhhbmRsZXIgbWF5IGJlY29tZSBuZWNlc3NhcnkuDQpCdXQg dGhhdCBjb3VsZCB0YWtlIGEgbGl0dGxlIHRpbWUuDQoNCllvdSBhcmUgcmlnaHQgYWJvdXQgaHZf c3RpbWVyX2NsZWFudXAoKSBhbmQgaHZfc3luaWNfZGlzYWJsZV9yZWdzKCkuDQpXZSBhcmUgbm90 IHJ1bm5pbmcgdGhlc2Ugd2hlbiBhIHBhbmljIG9jY3VycyBvbiBBUk02NCwgYW5kIHdlDQpzaG91 bGQgYmUsIHRob3VnaCB0aGUgcmlzayBpcyBzbWFsbC4gICBXZSB3aWxsIHB1cnN1ZSAoYikgYW5k IGFkZA0KdGhlc2UgYWRkaXRpb25hbCBjbGVhbnVwcyBhcyBwYXJ0IG9mIHRoYXQuICBCdXQgYWdh aW4sIEkgd291bGQgc3VnZ2VzdA0KZG9pbmcgKGEpIGZvciBub3csIGFuZCB3ZSB3aWxsIHN3aXRj aCBiYWNrIHRvIHlvdXIgc29sdXRpb24gb25jZQ0KKGIpIGlzIGluIHBsYWNlLg0KDQo+IA0KPiA+ Pg0KPiA+PiAoYykgVGhlcmUgaXMgYWxzbyBhIEh5cGVyLVYgZnJhbWVidWZmZXIgcGFuaWMgbm90 aWZpZXIsIHdoaWNoIHJlbGllcyBpbg0KPiA+PiBkb2luZyBhIHZtYnVzIG9wZXJhdGlvbiB0aGF0 IGRlbWFuZHMgYSB2YWxpZCBjb25uZWN0aW9uLiBTbywgd2UgbXVzdA0KPiA+PiBvcmRlciB0aGlz IG5vdGlmaWVyIHdpdGggdGhlIHBhbmljIG5vdGlmaWVyIGZyb20gdm1idXNfZHJ2LmMsIGluIG9y ZGVyIHRvDQo+ID4+IGd1YXJhbnRlZSB0aGF0IHRoZSBmcmFtZWJ1ZmZlciBjb2RlIGV4ZWN1dGVz IGJlZm9yZSB0aGUgdm1idXMgY29ubmVjdGlvbg0KPiA+PiBpcyB1bmxvYWRlZC4NCj4gPg0KPiA+ IFBhdGNoIDIxIG9mIHRoaXMgc2V0IHB1dHMgdGhlIEh5cGVyLVYgRkIgcGFuaWMgbm90aWZpZXIg b24gdGhlIHByZV9yZWJvb3QNCj4gPiBub3RpZmllciBsaXN0LCB3aGljaCBtZWFucyBpdCB3b24n dCBleGVjdXRlIGJlZm9yZSB0aGUgVk1idXMgY29ubmVjdGlvbg0KPiA+IHVubG9hZCBpbiB0aGUg Y2FzZSBvZiBrZHVtcC4gICBUaGlzIG5vdGlmaWVyIGlzIG1ha2luZyBzdXJlIHRoYXQgSHlwZXIt Vg0KPiA+IGlzIG5vdGlmaWVkIGFib3V0IHRoZSBsYXN0IHVwZGF0ZXMgbWFkZSB0byB0aGUgZnJh bWUgYnVmZmVyIGJlZm9yZSB0aGUNCj4gPiBwYW5pYywgc28gbWF5YmUgaXQgbmVlZHMgdG8gYmUg cHV0IG9uIHRoZSBoeXBlcnZpc29yIG5vdGlmaWVyIGxpc3QuICBJdA0KPiA+IHNlbmRzIGEgbWVz c2FnZSB0byBIeXBlci1WIG92ZXIgaXRzIGV4aXN0aW5nIFZNYnVzIGNoYW5uZWwsIGJ1dCBpdA0K PiA+IGRvZXMgbm90IHdhaXQgZm9yIGEgcmVwbHkuICBJdCBkb2VzLCBob3dldmVyLCBvYnRhaW4g YSBzcGluIGxvY2sgb24gdGhlDQo+ID4gcmluZyBidWZmZXIgdXNlZCB0byBjb21tdW5pY2F0ZSB3 aXRoIEh5cGVyLVYuICAgVW5sZXNzIHNvbWVvbmUgaGFzDQo+ID4gYSBiZXR0ZXIgc3VnZ2VzdGlv biwgSSdtIGluY2xpbmVkIHRvIHRha2UgdGhlIHJpc2sgb2YgYmxvY2tpbmcgb24gdGhhdA0KPiA+ IHNwaW4gbG9jay4NCj4gDQo+IFRoZSBsb2dpYyBiZWhpbmQgdGhhdCB3YXM6IHdoZW4ga2R1bXAg aXMgc2V0LCB3ZSdkIHNraXAgdGhlIHZtYnVzDQo+IGRpc2Nvbm5lY3Qgb24gbm90aWZpZXJzLCBk ZWZlcnJpbmcgdGhhdCB0byBjcmFzaF9zaHV0ZG93bigpLCBsb2dpYyB0aGlzDQo+IG9uZSByZWZ1 dGVkIGluIHRoZSBhYm92ZSBkaXNjdXNzaW9uIG9uIEFSTTY0IChvbmUgbW9yZSBQcm8gYXJndW1l bnQgdG8NCj4gdGhlIGlkZWEgb2YgcmVmYWN0b3JpbmcgYWFyY2g2NCBjb2RlIHRvIGFsbG93IGEg Y3VzdG9tIGNyYXNoIHNodXRkb3duDQo+IGhhbmRsZXIgaGVoKS4gQnV0IHlvdSdyZSByaWdodCwg Zm9yIHRoZSBkZWZhdWx0IGxldmVsIDIsIHdlIHNraXAgdGhlDQo+IHByZV9yZWJvb3Qgbm90aWZp ZXJzIG9uIGtkdW1wLCBlZmZlY3RpdmVseSBza2lwcGluZyB0aGlzIG5vdGlmaWVyLg0KPiANCj4g U29tZSBpZGVhcyBvZiB3aGF0IHdlIGNhbiBkbyBoZXJlOg0KPiANCj4gSSkgd2UgY291bGQgY2hh bmdlIHRoZSBmcmFtZWJ1ZmZlciBub3RpZmllciB0byByZWx5IG9uIHRyeWxvY2tzLCBpbnN0ZWFk DQo+IG9mIHJpc2tpbmcgYSBsb2NrdXAgc2NlbmFyaW8sIGFuZCB3aXRoIHRoYXQsIHdlIGNhbiBl eGVjdXRlIGl0IGJlZm9yZQ0KPiB0aGUgdm1idXMgZGlzY29ubmVjdCBpbiB0aGUgaHlwZXJ2aXNv ciBsaXN0Ow0KDQpJIHRoaW5rIHdlIGhhdmUgdG8gZG8gdGhpcyBhcHByb2FjaCBmb3Igbm93Lg0K DQo+IA0KPiBJSSkgd2UgaWdub3JlIHRoZSBoeXBlcnZpc29yIG5vdGlmaWVyIGluIGNhc2Ugb2Yg a2R1bXAgX2J5IGRlZmF1bHRfLCBhbmQNCj4gaWYgdGhlIHVzZXJzIGRvbid0IHdhbnQgdGhhdCwg dGhleSBjYW4gYWx3YXlzIHNldCB0aGUgcGFuaWMgbm90aWZpZXINCj4gbGV2ZWwgdG8gNCBhbmQg cnVuIGFsbCBub3RpZmllcnMgcHJpb3IgdG8ga2R1bXA7IHdvdWxkIHRoYXQgYmUgdGVycmlibGUN Cj4geW91IHRoaW5rPyBLZHVtcCB1c2VycyBtaWdodCBkb24ndCBjYXJlIGFib3V0IHRoZSBmcmFt ZWJ1ZmZlci4uLg0KPiANCj4gSUlJKSB3ZSBnbyB3aXRoIGFwcHJvYWNoIChiKSBhYm92ZSBhbmQg cmVmYWN0b3IgYXJtNjQgY29kZSB0byBhbGxvdyB0aGUNCj4gY3VzdG9tIGNyYXNoIGhhbmRsZXIg b24ga2R1bXAgdGltZSwgdGhlbiBbd2l0aCBwb2ludCAoSSkgYWJvdmVdIHRoZQ0KPiBsb2dpYyBw cm9wb3NlZCBpbiB0aGlzIHNlcmllcyBpcyBzdGlsbCB2YWxpZCAtIHNlZW1zIG1vcmUgYW5kIG1v cmUgdGhlDQo+IG1vc3QgY29ycmVjdC9jb21wbGV0ZSBzb2x1dGlvbi4NCg0KQnV0IGV2ZW4gd2hl bi9pZiB3ZSBnZXQgYXBwcm9hY2ggKGIpIGltcGxlbWVudGVkLCBoYXZpbmcgdGhlDQpmcmFtZWJ1 ZmZlciBub3RpZmllciBvbiB0aGUgcHJlX3JlYm9vdCBsaXN0IGlzIHN0aWxsIHRvbyBsYXRlIHdp dGggdGhlDQpkZWZhdWx0IG9mIHBhbmljX25vdGlmaWVyX2xldmVsID0gMi4gIFRoZSBrZHVtcCBw YXRoIHdpbGwgcmVzZXQgdGhlDQpWTWJ1cyBjb25uZWN0aW9uIGFuZCB0aGVuIHRoZSBmcmFtZWJ1 ZmZlciBub3RpZmllciB3b24ndCB3b3JrLg0KDQo+IA0KPiBJbiBhbnkgY2FzZSwgSSBndWVzcyB3 ZSBzaG91bGQgYXZvaWQgd29ya2Fyb3VuZHMgaWYgcG9zc2libGUgYW5kIGRvIHRoZQ0KPiB0aGlu Z3MgdGhlIGJlc3Qgd2F5IHdlIGNhbiwgdG8gZW5jb21wYXNzIGFsbCAob3IgYWxtb3N0IGFsbCkg dGhlDQo+IHBvc3NpYmxlIHNjZW5hcmlvcyBhbmQgZG9uJ3QgZm9yY2UgdGhpbmdzIG9uIHVzZXJz IChsaWtlIGVuZm9yY2luZyBwYW5pYw0KPiBub3RpZmllciBsZXZlbCA0IGZvciBIeXBlci1WIG9y IHNvbWV0aGluZyBsaWtlIHRoaXMuLi4pDQo+IA0KPiBNb3JlIGZlZWRiYWNrIGZyb20geW91IC8g SHlwZXItViBmb2xrcyBpcyBwcmV0dHkgd2VsY29tZSBhYm91dCB0aGlzLg0KPiANCj4gDQo+ID4N Cj4gPj4gWy4uLl0NCj4gPiBUaGUgIkZpeGVzOiIgdGFncyBpbXBseSB0aGF0IHRoZXNlIGNoYW5n ZXMgc2hvdWxkIGJlIGJhY2twb3J0ZWQgdG8gb2xkZXINCj4gPiBsb25ndGVybSBrZXJuZWwgdmVy c2lvbnMsIHdoaWNoIEkgZG9uJ3QgdGhpbmsgaXMgdGhlIGNhc2UuICBUaGVyZSBpcyBhDQo+ID4g ZGVwZW5kZW5jeSBvbiBQYXRjaCAxNCBvZiB5b3VyIHNlcmllcyB3aGVyZSBQQU5JQ19OT1RJRklF UiBpcw0KPiA+IGludHJvZHVjZWQuDQo+ID4NCj4gDQo+IE9oLCB0aGlzIHdhcyBtb3JlIHJlbGF0 ZWQgd2l0aCBhcmNoZW9sb2d5IG9mIHRoZSBrZXJuZWwuIFdoZW4gSSdtDQo+IGludmVzdGlnYXRp bmcgc3R1ZmYsIEkgcmVhbGx5IHdhbnQgdG8gdW5kZXJzdGFuZCB3aHkgY29kZSB3YXMgYWRkZWQg YW5kDQo+IHRoYXQgdXN1YWxseSByZXF1aXJlIHNvbWUgdGltZSBnaXQgYmxhbWluZyBzdHVmZiwg c28gaGF2aW5nIHRoYXQgcHJvbnRvDQo+IGluIHRoZSBjb21taXQgbWVzc2FnZSBpcyBhIGJvbnVz Lg0KPiANCj4gQnV0IG9mIGNvdXJzZSB3ZSBkb24ndCBuZWVkIHRvIHVzZSB0aGUgRml4ZXMgdGFn IGZvciB0aGF0LCBlYXN5IHRvIG9ubHkNCj4gbWVudGlvbiBpdCBpbiB0aGUgdGV4dC4gQSBzZWNv bmRhcnkgYmVuZWZpdCBieSB1c2luZyB0aGlzIHRhZyBpcyB0bw0KPiBpbmRpY2F0ZSB0aGlzIGlz IGEgX3JlYWwgZml4XyB0byBzb21lIGNvZGUsIGFuZCBub3QgYW4gaW1wcm92ZW1lbnQsIGJ1dA0K PiBhcyB5b3Ugc2F5LCBJIGFncmVlIHdlIHNob3VsZG4ndCBiYWNrcG9ydCBpdCB0byBwcmV2aW91 cyByZWxlYXNlcyBoYXZpbmcNCj4gb3Igbm90IHRoZSBGaXhlcyB0YWcgKEFGQUlLIGl0J3Mgbm90 IG1hbmRhdG9yeSB0byBiYWNrcG9ydCBzdHVmZiB3aXRoDQo+IEZpeGVzIHRhZykuDQo+IA0KPiAN Cj4gPj4gWy4uLl0NCj4gPj4gKyAqIGludHJpbmNhdGVkIGlzIHRoZSByZWxhdGlvbiBvZiB0aGlz IG5vdGlmaWVyIHdpdGggSHlwZXItViBmcmFtZWJ1ZmZlcg0KPiA+DQo+ID4gcy9pbnRyaW5jYXRl ZC9pbnRyaWNhdGUvDQo+IA0KPiBUaGFua3MsIGZpeGVkIGluIFYyIQ0KPiANCj4gDQo+ID4NCj4g Pj4gWy4uLl0NCj4gPj4gK3N0YXRpYyBpbnQgaHZfcGFuaWNfdm1idXNfdW5sb2FkKHN0cnVjdCBu b3RpZmllcl9ibG9jayAqbmIsIHVuc2lnbmVkIGxvbmcgdmFsLA0KPiA+PiAgCQkJICAgICAgdm9p ZCAqYXJncykNCj4gPj4gK3sNCj4gPj4gKwlpZiAoIWtleGVjX2NyYXNoX2xvYWRlZCgpKQ0KPiA+ DQo+ID4gSSdtIG5vdCBjbGVhciBvbiB0aGUgcHVycG9zZSBvZiB0aGlzIGNvbmRpdGlvbi4gIEkg dGhpbmsgaXQgbWVhbnMNCj4gPiB3ZSB3aWxsIHNraXAgdGhlIHZtYnVzX2luaXRpYXRlX3VubG9h ZCgpIGlmIGEgcGFuaWMgb2NjdXJzIGluIHRoZQ0KPiA+IGtkdW1wIGtlcm5lbC4gIElzIHRoZXJl IGEgcmVhc29uIGEgcGFuaWMgaW4gdGhlIGtkdW1wIGtlcm5lbA0KPiA+IHNob3VsZCBiZSB0cmVh dGVkIGRpZmZlcmVudGx5PyAgT3IgYW0gSSBtaXN1bmRlcnN0YW5kaW5nPw0KPiANCj4gVGhpcyBp cyByZWFsbHkgcmVsYXRlZCB3aXRoIHRoZSBwb2ludCBkaXNjdXNzZWQgaW4gdGhlIHRvcCBvZiB0 aGlzDQo+IHJlc3BvbnNlIC0gSSBhc3N1bWVkIGJvdGggQVJNNjQveDg2XzY0IHdvdWxkIGJlaGF2 ZSB0aGUgc2FtZSBhbmQNCj4gZGlzY29ubmVjdCB0aGUgdm1idXMgdGhyb3VnaCB0aGUgY3VzdG9t IGNyYXNoIGhhbmRsZXIgd2hlbiBrZHVtcCBpcyBzZXQsDQo+IHNvIHdvcnRoIHNraXBwaW5nIGl0 IGhlcmUgaW4gdGhlIG5vdGlmaWVyLiBCdXQgdGhhdCdzIG5vdCB0cnVlIGZvciBBUk02NA0KPiBh cyB5b3UgcG9pbnRlZCwgc28gdGhpcyBndWFyZCBhZ2FpbnN0IGtleGVjIGlzIHJlYWxseSBwYXJ0 IG9mIHRoZQ0KPiBkZWNpc2lvbi9kaXNjdXNzaW9uIG9uIHdoYXQgdG8gZG8gd2l0aCBBUk02NCBo ZWgNCg0KQnV0IG5vdGUgdGhhdCB2bWJ1c19pbml0aWF0ZV91bmxvYWQoKSBhbHJlYWR5IGhhcyBh IGd1YXJkIGJ1aWx0LWluLg0KSWYgdGhlIGludGVudCBvZiB0aGlzIHRlc3QgaXMganVzdCBhcyBh IGd1YXJkIGFnYWluc3QgcnVubmluZyB0d2ljZSwNCnRoZW4gaXQgaXNuJ3QgbmVlZGVkLg0KDQo+ IA0KPiBDaGVlcnMhDQo= From xen-devel-bounces@lists.xenproject.org Tue May 03 18:17:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:17:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319883.540322 (Exim 4.92) (envelope-from ) id 1nlx5t-00010N-TM; Tue, 03 May 2022 18:17:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319883.540322; Tue, 03 May 2022 18:17:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlx5t-00010G-QU; Tue, 03 May 2022 18:17:53 +0000 Received: by outflank-mailman (input) for mailman id 319883; Tue, 03 May 2022 18:17:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlx5s-00010A-Fn for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:17:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlx5s-0000py-3A; Tue, 03 May 2022 18:17:52 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nlx5r-0007sm-SS; Tue, 03 May 2022 18:17:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Gk+fqLWnYDeGe+z0ICz8HBceXXit2p94eMJ49M1NvSE=; b=aFPcUwtbMPSwSIHBa1il9zqXGD 7vbuByH6Ud1CCbFOE+DKoeQuA5nBfMS/btUXS9ETEvL3UhH5ylNRSCSLb+QAL6zxy+wf4X6eleGm0 70vE8IVLFsdbneQwhqbzRowJCCSgpfyj0d3wK5K1otncIiqeCTh9lvIw+kxSSFOkPGkQ=; Message-ID: Date: Tue, 3 May 2022 19:17:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3 To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <8119538cce93516f1e78d37d578996a195686f89.1651570561.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <8119538cce93516f1e78d37d578996a195686f89.1651570561.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 03/05/2022 10:38, Bertrand Marquis wrote: > SMCC_WORKAROUND_3 is handling both Spectre v2 and spectre BHB. > So when a guest is asking if we support workaround 1, tell yes if we > apply workaround 3 on exception entry as it handles it. > > This will allow guests not supporting Spectre BHB but impacted by > spectre v2 to still handle it correctly. > The modified behaviour is coherent with what the Linux kernel does in > KVM for guests. > > While there use ARM_SMCCC_SUCCESS instead of 0 for the return code value > for workaround detection to be coherent with Workaround 2 handling. > > Signed-off-by: Bertrand Marquis Acked-by: Julien Grall I think we should also consider for backport. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 18:47:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:47:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319889.540334 (Exim 4.92) (envelope-from ) id 1nlxYX-0004OP-3s; Tue, 03 May 2022 18:47:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319889.540334; Tue, 03 May 2022 18:47:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxYX-0004OI-0u; Tue, 03 May 2022 18:47:29 +0000 Received: by outflank-mailman (input) for mailman id 319889; Tue, 03 May 2022 18:47:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxYV-0004OC-FT for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:47:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxYV-0001K8-4Z; Tue, 03 May 2022 18:47:27 +0000 Received: from [54.239.6.185] (helo=[192.168.2.157]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nlxYU-0001NP-Ul; Tue, 03 May 2022 18:47:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=b958ry/pJGqJfD/0IZgqnpcAa3lnCp8QNLjQ6xV5+II=; b=g5DBZ0gwFeE3IbH8H1yFfcQaM5 k/QL0C+i8eMtYYsi4ivXWlPuveOdI7Pu7XqCnlbIezvDlyjetJ6+vS6SDwFoAz0Z7Q/Pyrl9y9FkO hGJHQUbpfCWFmPm6PiJR2qzq5dsj/c5GRLPUTvOjo+wYh6Dv+rorAS+c6GOSEzKfSNH4=; Message-ID: <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> Date: Tue, 3 May 2022 19:47:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 03/05/2022 10:38, Bertrand Marquis wrote: > This patch is adding sb instruction support when it is supported by a > CPU on arm64. > To achieve this, the "sb" macro is moved to sub-arch macros.h so that we > can use sb instruction when available through alternative on arm64 and > keep the current behaviour on arm32. SB is also supported on Arm32. So I would prefer to introduce the encoding right now and avoid duplicating the .macro sb. > A new cpuerrata capability is introduced to enable the alternative 'sb' is definitely not an erratum. Errata are for stuff that are meant to be specific to one (or multiple) CPU and they are not part of the architecture. This is the first time we introduce a feature in Xen. So we need to add a new array in cpufeature.c that will cover 'SB' for now. In future we could add feature like pointer auth, LSE atomics... > code for sb when the support is detected using isa64 coprocessor s/coprocessor/system/ > register. > The sb instruction is encoded using its hexadecimal value. This is necessary to avoid recursive macro, right? > diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h > index 140e223b4c..e639cec400 100644 > --- a/xen/arch/arm/include/asm/arm64/macros.h > +++ b/xen/arch/arm/include/asm/arm64/macros.h > @@ -1,6 +1,24 @@ > #ifndef __ASM_ARM_ARM64_MACROS_H > #define __ASM_ARM_ARM64_MACROS_H > > +#include > + > + /* > + * Speculative barrier > + */ > + .macro sb > +alternative_if_not ARM64_HAS_SB > + dsb nsh > + isb > +alternative_else > +/* > + * SB encoding as given in chapter C6.2.264 of ARM ARM (DDI 0487H.a). > + */ NIT: Please align the comment with ".inst" below. I also don't think it is necessary to mention the spec here. The instruction encoding is not going to change. > + .inst 0xd50330ff > + nop Why do we need the NOP? > +alternative_endif > + .endm > + > /* > * @dst: Result of get_cpu_info() > */ > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index 4719de47f3..9370805900 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -67,8 +67,9 @@ > #define ARM_WORKAROUND_BHB_LOOP_24 13 > #define ARM_WORKAROUND_BHB_LOOP_32 14 > #define ARM_WORKAROUND_BHB_SMCC_3 15 > +#define ARM64_HAS_SB 16 > > -#define ARM_NCAPS 16 > +#define ARM_NCAPS 17 > > #ifndef __ASSEMBLY__ > > diff --git a/xen/arch/arm/include/asm/macros.h b/xen/arch/arm/include/asm/macros.h > index 1aa373760f..91ea3505e4 100644 > --- a/xen/arch/arm/include/asm/macros.h > +++ b/xen/arch/arm/include/asm/macros.h > @@ -5,15 +5,6 @@ > # error "This file should only be included in assembly file" > #endif > > - /* > - * Speculative barrier > - * XXX: Add support for the 'sb' instruction > - */ > - .macro sb > - dsb nsh > - isb > - .endm > - > #if defined (CONFIG_ARM_32) > # include > #elif defined(CONFIG_ARM_64) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 03 18:58:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 18:58:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319896.540345 (Exim 4.92) (envelope-from ) id 1nlxjU-0006Ix-58; Tue, 03 May 2022 18:58:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319896.540345; Tue, 03 May 2022 18:58:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxjU-0006Iq-0g; Tue, 03 May 2022 18:58:48 +0000 Received: by outflank-mailman (input) for mailman id 319896; Tue, 03 May 2022 18:58:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxjR-0006Ik-9J for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:58:46 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c749958-cb13-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 20:58:42 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlxio-0001n9-LT; Tue, 03 May 2022 20:58:06 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c749958-cb13-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q8xZuwWHbM5RtbVLpI5p8QHhyHnoykAXVMFnszZxrdg=; b=TqkdHc+398urJjW6/hR3lSmD91 Fo7i3n3SNwuNElwVYi/w+KnbhS8+u2vWgV1cIJIjZ8jCkAcSLSvlso5lciPOVsZuwZ60o4GZ0Sqjx 22Y1fjpJoK/chqdm1vTsGuRJJqpC4q32E8Os80o8bAzvpNnZtKFYUr9IxCs7Y3+qiYY9v7R2c2HHE u9NeehqoIhEiDWWb10yrMKqoHSbKirkdSM2MnGXbLFUWfXxGVmNdvtyoWTdWi0kALfB+UzyKpCQXc XjY+PUaHj85B5+JbHxedajI8IojA4qagg32dYWLI8h4fZxyG6QPV3ENEKaWRgNkAk597bSNzvAt8G d2ESiTmQ==; Message-ID: <92dee5a0-f04e-f352-1e22-f990818ca06a@igalia.com> Date: Tue, 3 May 2022 15:57:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 16/30] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers Content-Language: en-US To: "Michael Kelley (LINUX)" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" Cc: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , vkuznets , "will@kernel.org" , Andrea Parri , Dexuan Cui , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , Tianyu Lan , Wei Liu References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-17-gpiccoli@igalia.com> <2787b476-6366-1c83-db80-0393da417497@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/05/2022 15:13, Michael Kelley (LINUX) wrote: > [...] >> (a) We could forget about this change, and always do the clean-up here, >> not relying in machine_crash_shutdown(). >> Pro: really simple, behaves the same as it is doing currently. >> Con: less elegant/concise, doesn't allow arm64 customization. >> >> (b) Add a way to allow ARM64 customization of shutdown crash handler. >> Pro: matches x86, more customizable, improves arm64 arch code. >> Con: A tad more complex. >> >> Also, a question that came-up: if ARM64 has no way of calling special >> crash shutdown handler, how can you execute hv_stimer_cleanup() and >> hv_synic_disable_regs() there? Or are they not required in ARM64? >> > > My suggestion is to do (a) for now. I suspect (b) could be a more > extended discussion and I wouldn't want your patch set to get held > up on that discussion. I don't know what the sense of the ARM64 > maintainers would be toward (b). They have tried to avoid picking > up code warts like have accumulated on the x86/x64 side over the > years, and I agree with that effort. But as more and varied > hypervisors become available for ARM64, it seems like a framework > for supporting a custom shutdown handler may become necessary. > But that could take a little time. > > You are right about hv_stimer_cleanup() and hv_synic_disable_regs(). > We are not running these when a panic occurs on ARM64, and we > should be, though the risk is small. We will pursue (b) and add > these additional cleanups as part of that. But again, I would suggest > doing (a) for now, and we will switch back to your solution once > (b) is in place. > Thanks again Michael, I'll stick with (a) for now. I'll check with ARM64 community about that, and I might even try to implement something in parallel (if you are not already working on that - lemme know please), so we don't get stuck here. As you said, I feel that this is more and more relevant as the number of panic/crash/kexec scenarios tend to increase in ARM64. >> [...] >> Some ideas of what we can do here: >> >> I) we could change the framebuffer notifier to rely on trylocks, instead >> of risking a lockup scenario, and with that, we can execute it before >> the vmbus disconnect in the hypervisor list; > > I think we have to do this approach for now. > >> >> II) we ignore the hypervisor notifier in case of kdump _by default_, and >> if the users don't want that, they can always set the panic notifier >> level to 4 and run all notifiers prior to kdump; would that be terrible >> you think? Kdump users might don't care about the framebuffer... >> >> III) we go with approach (b) above and refactor arm64 code to allow the >> custom crash handler on kdump time, then [with point (I) above] the >> logic proposed in this series is still valid - seems more and more the >> most correct/complete solution. > > But even when/if we get approach (b) implemented, having the > framebuffer notifier on the pre_reboot list is still too late with the > default of panic_notifier_level = 2. The kdump path will reset the > VMbus connection and then the framebuffer notifier won't work. > OK, perfect! I'll work something along these lines in V2, allowing the FB notifier to always run in the hypervisor list before the vmbus unload mechanism. >> [...] >>>> +static int hv_panic_vmbus_unload(struct notifier_block *nb, unsigned long val, >>>> void *args) >>>> +{ >>>> + if (!kexec_crash_loaded()) >>> >>> I'm not clear on the purpose of this condition. I think it means >>> we will skip the vmbus_initiate_unload() if a panic occurs in the >>> kdump kernel. Is there a reason a panic in the kdump kernel >>> should be treated differently? Or am I misunderstanding? >> >> This is really related with the point discussed in the top of this >> response - I assumed both ARM64/x86_64 would behave the same and >> disconnect the vmbus through the custom crash handler when kdump is set, >> so worth skipping it here in the notifier. But that's not true for ARM64 >> as you pointed, so this guard against kexec is really part of the >> decision/discussion on what to do with ARM64 heh > > But note that vmbus_initiate_unload() already has a guard built-in. > If the intent of this test is just as a guard against running twice, > then it isn't needed. Since we're going to avoid relying in the custom crash_shutdown(), due to the lack of ARM64 support for now, this check will be removed in V2. Its purpose was to skip the notifier *proactively* in case kexec is set, given that...once kexec happens, the custom crash_shutdown() would run the same function (wrong assumption for ARM64, my bad). Postponing that slightly would maybe gain us some time while the hypervisor finish its work, so we'd delay less in the vmbus unload path - that was the rationale behind this check. Cheers! From xen-devel-bounces@lists.xenproject.org Tue May 03 19:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 19:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319905.540356 (Exim 4.92) (envelope-from ) id 1nlxl4-0007g0-FQ; Tue, 03 May 2022 19:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319905.540356; Tue, 03 May 2022 19:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxl4-0007ft-C3; Tue, 03 May 2022 19:00:26 +0000 Received: by outflank-mailman (input) for mailman id 319905; Tue, 03 May 2022 19:00:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxl3-0007fh-4t; Tue, 03 May 2022 19:00:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxl2-0001Zi-V3; Tue, 03 May 2022 19:00:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxl2-0005xA-KC; Tue, 03 May 2022 19:00:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlxl2-0007Mr-Jf; Tue, 03 May 2022 19:00:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MzzSLpbVOshJ5aXGb2vIWRX6Gj7nsv21ie4Bwn1SPyY=; b=ucmZTZJx4xcPsNWbGa3+fs+MSF BFDKXslzBlEDP7Q53Fe6AEsN2vmlX1Qu4IbUhmOpoKC4QSAWFDsrXlba+FXDaes8Hm2+bVOOKe+/M ooBxNTl1kNdFGNi0Q9euTIHaL8eTuFtBRjwZlmmCArJwZUJXy2e6AbKATlbJnK3Vf7Hg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170054: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 19:00:24 +0000 flight 170054 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170054/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 785 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 19:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 19:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319914.540366 (Exim 4.92) (envelope-from ) id 1nlxxT-0000wi-KY; Tue, 03 May 2022 19:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319914.540366; Tue, 03 May 2022 19:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxxT-0000wb-HH; Tue, 03 May 2022 19:13:15 +0000 Received: by outflank-mailman (input) for mailman id 319914; Tue, 03 May 2022 19:13:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlxxS-0000wV-AP for xen-devel@lists.xenproject.org; Tue, 03 May 2022 19:13:14 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13281c2d-cb15-11ec-a406-831a346695d4; Tue, 03 May 2022 21:13:12 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nlxwt-0003VB-Uo; Tue, 03 May 2022 21:12:40 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13281c2d-cb15-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YwqRVzAP9ZbrZ5VBMcTGFQUJhCIOHa56e0xcGxSMZUc=; b=g6wHrcBwrz2KwYvXjjVtORBiHn IYMsR5GaRD/VR0xedfaxvBvF7rTbYR/J22t3j5lb3f06u/Fc1RouLR18wpSiKcYUFYo1Es0dUnLOJ KS0gcPiTX1Gp43QoEXeB9qey3fro+JGWKqZb1HOFCCA1BT9LzygpBsI5rkGlNutynR2bG5HAOwC/E tPyLP92RA6GDIRm0QuhAm+c5aBu4j0UaKxwKd9I7j0kUsDE4qHndJxIdGDBq1RIB7dNA6suRfXZwh e21o4FfMtSVNbUCh0WQI73Gd4fdNm7+rXf7RsUeEiM3OYwwmkesCvbsvfiNKmEoMOIdut9FTHQRzP TtMjBb/w==; Message-ID: Date: Tue, 3 May 2022 16:12:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Content-Language: en-US To: Evan Green Cc: Andrew Morton , bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/05/2022 15:03, Evan Green wrote: > [...] > gsmi_shutdown_reason() is a common function called in other scenarios > as well, like reboot and thermal trip, where it may still make sense > to wait to acquire a spinlock. Maybe we should add a parameter to > gsmi_shutdown_reason() so that you can get your change on panic, but > we don't convert other callbacks into try-fail scenarios causing us to > miss logs. > Hi Evan, thanks for your feedback, much appreciated! What I've done in other cases like this was to have a helper checking the spinlock in the panic notifier - if we can acquire that, go ahead but if not, bail out. For a proper example of an implementation, check patch 13 of the series: https://lore.kernel.org/lkml/20220427224924.592546-14-gpiccoli@igalia.com/ . Do you agree with that, or prefer really a parameter in gsmi_shutdown_reason() ? I'll follow your choice =) > Though thinking more about it, is this really a Good Change (TM)? The > spinlock itself already disables interrupts, meaning the only case > where this change makes a difference is if the panic happens from > within the function that grabbed the spinlock (in which case the > callback is also likely to panic), or in an NMI that panics within > that window. The downside of this change is that if one core was > politely working through an event with the lock held, and another core > panics, we now might lose the panic log, even though it probably would > have gone through fine assuming the other core has a chance to > continue. My feeling is that this is a good change, indeed - a lot of places are getting changed like this, in this series. Reasoning: the problem with your example is that, by default, secondary CPUs are disabled in the panic path, through an IPI mechanism. IPIs take precedence and interrupt the work in these CPUs, effectively interrupting the "polite work" with the lock held heh Then, such CPU is put to sleep and we finally reach the panic notifier hereby discussed, in the main CPU. If the other CPU was shut-off *with the lock held*, it's never finishing such work, so the lock is never to be released. Conclusion: the spinlock can't be acquired, hence we broke the machine (which is already broken, given it's panic) in the path of this notifier. This should be really rare, but..possible. So I think we should protect against this scenario. We can grab others' feedback if you prefer, and of course you have the rights to refuse this change in the gsmi code, but from my point-of-view, I don't see any advantage in just assume the risk, specially since the change is very very simple. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 03 20:41:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 20:41:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319926.540378 (Exim 4.92) (envelope-from ) id 1nlzKN-0001ws-3j; Tue, 03 May 2022 20:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319926.540378; Tue, 03 May 2022 20:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlzKN-0001wl-0Y; Tue, 03 May 2022 20:40:59 +0000 Received: by outflank-mailman (input) for mailman id 319926; Tue, 03 May 2022 20:40:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlzKL-0001wb-Ep; Tue, 03 May 2022 20:40:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlzKL-0003JQ-DA; Tue, 03 May 2022 20:40:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlzKL-00039S-0H; Tue, 03 May 2022 20:40:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nlzKK-0004VA-W1; Tue, 03 May 2022 20:40:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ghnhl1CEdIkob0VgNIPLBpBk4lmT3uBRwbu5e4Ewz+o=; b=eSuJ/pbeczku4Tk+sxL0rcYzve /OjsmIGZwt5Ufz4Z4rvpiNr2kZ2PRpeb6J5KjQ8pYpbpn1yvIa4oSMp+N0XU9CtYdpBejNHPN8AKf 9fSra4mOTNcYM5F6POhMO61o4uqsrtHkda3bHjIeKYyXpks6KRMO1x2mbplmL5sWhbyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170055: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 20:40:56 +0000 flight 170055 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170055/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 786 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 21:46:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 21:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319939.540404 (Exim 4.92) (envelope-from ) id 1nm0Lo-0008GS-64; Tue, 03 May 2022 21:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319939.540404; Tue, 03 May 2022 21:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm0Lo-0008GL-2t; Tue, 03 May 2022 21:46:32 +0000 Received: by outflank-mailman (input) for mailman id 319939; Tue, 03 May 2022 21:46:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm0Lm-0008GB-Eu; Tue, 03 May 2022 21:46:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm0Lm-0004QN-Cb; Tue, 03 May 2022 21:46:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm0Lm-0005Fe-1J; Tue, 03 May 2022 21:46:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm0Lm-0005MZ-0u; Tue, 03 May 2022 21:46:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N/2sTMscJLaukUOwOCfStN62faMXM2oUTVNFyWOfFGQ=; b=PlJpcDmr6LGWY2b5E+pINUz4mL n+pSFNFV7olNZtkfJ89R38kktEMaPkNJwdoKip0Sx/AT6Kx09rdfK+ZbgIfFVIcvoWDa6Va0xqlU4 8XcxiVSUJckgfm7fnhqOxzbv7DAPHCwshYENKheYd8z8ox1dNv+PM8raaxy5axlkO1QQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170059: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 21:46:30 +0000 flight 170059 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170059/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 787 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 22:51:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 22:51:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319953.540427 (Exim 4.92) (envelope-from ) id 1nm1Mf-0006ci-90; Tue, 03 May 2022 22:51:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319953.540427; Tue, 03 May 2022 22:51:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1Mf-0006cb-5W; Tue, 03 May 2022 22:51:29 +0000 Received: by outflank-mailman (input) for mailman id 319953; Tue, 03 May 2022 22:51:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1Md-0006cR-O3; Tue, 03 May 2022 22:51:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1Md-0005c8-Ko; Tue, 03 May 2022 22:51:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1Md-0007FS-5v; Tue, 03 May 2022 22:51:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm1Md-0000Ep-5U; Tue, 03 May 2022 22:51:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FPcQLaM3pu79kNoeRto8SuEwpchnSIBDm73l5/cam/U=; b=ivIpc3K7C3t6Buan5cwXFQEyft ZQLo+b6Gj8LAWaDWKgQKqfsgQoTByJFRGWz8TCqbHu1u53ULhsC/6ZMEMGJtg3iqOA9TLQXb74uxE 61TLgGEkbE9NzpEeDYfsnpzM6U61oKWGg8lz+SrPkeDUz3pVWzTAOvKuquvt8T7pMqew=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170051: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt:xen-boot:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-raw:guest-saverestore:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5f14cfe187e2fc3c71f4536b2021b8118d224239 X-Osstest-Versions-That: qemuu=f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65 From: osstest service owner Date: Tue, 03 May 2022 22:51:27 +0000 flight 170051 qemu-mainline real [real] flight 170057 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170051/ http://logs.test-lab.xenproject.org/osstest/logs/170057/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 8 xen-boot fail pass in 170057-retest test-amd64-i386-libvirt-raw 16 guest-saverestore fail pass in 170057-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 170057 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169967 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169967 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169967 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169967 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169967 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169967 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169967 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169967 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 5f14cfe187e2fc3c71f4536b2021b8118d224239 baseline version: qemuu f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65 Last test of basis 169967 2022-05-01 17:08:17 Z 2 days Testing same since 170051 2022-05-03 16:08:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Le Goater Jae Hyun Yoo Jamin Lin Joel Stanley Peter Delevoryas Richard Henderson Steven Lee Thomas Huth Troy Lee jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f5643914a9..5f14cfe187 5f14cfe187e2fc3c71f4536b2021b8118d224239 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 03 23:15:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 23:15:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319964.540440 (Exim 4.92) (envelope-from ) id 1nm1jL-0000ga-Bi; Tue, 03 May 2022 23:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319964.540440; Tue, 03 May 2022 23:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1jL-0000gT-8c; Tue, 03 May 2022 23:14:55 +0000 Received: by outflank-mailman (input) for mailman id 319964; Tue, 03 May 2022 23:14:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1jK-0000gJ-JF; Tue, 03 May 2022 23:14:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1jK-00066n-Hc; Tue, 03 May 2022 23:14:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm1jK-0007t0-8O; Tue, 03 May 2022 23:14:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm1jK-0008KN-7y; Tue, 03 May 2022 23:14:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L47fK5EspEcLB4D+VSLrN1kQxrzKNdZ2B7NCaY4PV20=; b=vMJOYmChE770d7q3L2Nm9bmSzA nAkP8awzb3pfa3hvbijUap4gu4hg4+X7owxalmpI5/u+fxbBVrUP/8R5EpnVFWWP8xj2k+ngdIDmu EWjAKjmEaUCrnP26g9SuiYznGasyiUEJuZsLywFh6Nn7iV62snMrzql8sjA3V5bqlm7Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170062: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 03 May 2022 23:14:54 +0000 flight 170062 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170062/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 788 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 03 23:56:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 03 May 2022 23:56:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319978.540461 (Exim 4.92) (envelope-from ) id 1nm2NL-0004qt-Ga; Tue, 03 May 2022 23:56:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319978.540461; Tue, 03 May 2022 23:56:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm2NL-0004qm-DN; Tue, 03 May 2022 23:56:15 +0000 Received: by outflank-mailman (input) for mailman id 319978; Tue, 03 May 2022 23:56:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm2NK-0004qg-0h for xen-devel@lists.xenproject.org; Tue, 03 May 2022 23:56:14 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b34bad5-cb3c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 01:56:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B227EB81AB4; Tue, 3 May 2022 23:56:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED2BDC385A4; Tue, 3 May 2022 23:56:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b34bad5-cb3c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651622168; bh=mBbu5PwH7dLH1yD4cNvHnQ/jBPlVI+m9PnFMk1JT1B8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tGixvVs4IR/RZBxVOX4383xCaPASO2Gf7tI3ba+T5sHoQsIVfb/iVgANeU5pr5YJ+ XVJ1Oh9Lx44+vpKRkLzHZJLTYNnS5g9DbKVJLDBAZG9cNBj/525QG7KqeuDepOKE5o miaMMeP04RWgffLdsBmmuCrE+n7vgnN0LG3I4wScHWLMfzSM2ZovKj1SunM4Nzv0Yy XFJqEWwSDCDU/rjqwEW1nm3yNZDJRog+DvyP3lY5XMMqWIuPJLb9KFzNaS7SNBvgTW nUE+ieHlpwJFFoJ3j0C0YzqkyC1Yuj0uF6q7nPPQjLzPmL/R1msfvAjCP9Jn/rGbf9 7gO8iO7ADjIRw== Date: Tue, 3 May 2022 16:56:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: Re: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm In-Reply-To: <1651598763-12162-3-git-send-email-olekstysh@gmail.com> Message-ID: References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-3-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1965384132-1651622161=:43560" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1965384132-1651622161=:43560 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 3 May 2022, Oleksandr Tyshchenko wrote: > From: Julien Grall > > This patch introduces helpers to allocate Virtio MMIO params > (IRQ and memory region) and create specific device node in > the Guest device-tree with allocated params. In order to deal > with multiple Virtio devices, reserve corresponding ranges. > For now, we reserve 1MB for memory regions and 10 SPIs. > > As these helpers should be used for every Virtio device attached > to the Guest, call them for Virtio disk(s). > > Please note, with statically allocated Virtio IRQs there is > a risk of a clash with a physical IRQs of passthrough devices. > For the first version, it's fine, but we should consider allocating > the Virtio IRQs automatically. Thankfully, we know in advance which > IRQs will be used for passthrough to be able to choose non-clashed > ones. > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini > --- > Please note, this is a split/cleanup/hardening of Julien's PoC: > "Add support for Guest IO forwarding to a device emulator" > > Changes RFC -> V1: > - was squashed with: > "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way" > "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node" > "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT" > - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h > > Changes V1 -> V2: > - update the author of a patch > > Changes V2 -> V3: > - no changes > > Changes V3 -> V4: > - no changes > > Changes V4 -> V5: > - split the changes, change the order of the patches > - drop an extra "virtio" configuration option > - update patch description > - use CONTAINER_OF instead of own implementation > - reserve ranges for Virtio MMIO params and put them > in correct location > - create helpers to allocate Virtio MMIO params, add > corresponding sanity-сhecks > - add comment why MMIO size 0x200 is chosen > - update debug print > - drop Wei's T-b > > Changes V5 -> V6: > - rebase on current staging > > Changes V6 -> V7: > - rebase on current staging > - add T-b and R-b tags > - update according to the recent changes to > "libxl: Add support for Virtio disk configuration" > > Changes V7 -> V8: > - drop T-b and R-b tags > - make virtio_mmio_base/irq global variables to be local in > libxl__arch_domain_prepare_config() and initialize them at > the beginning of the function, then rework alloc_virtio_mmio_base/irq() > to take a pointer to virtio_mmio_base/irq variables as an argument > - update according to the recent changes to > "libxl: Add support for Virtio disk configuration" > --- > tools/libs/light/libxl_arm.c | 118 +++++++++++++++++++++++++++++++++++++++++- > xen/include/public/arch-arm.h | 7 +++ > 2 files changed, 123 insertions(+), 2 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de0..37403a2 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -8,6 +8,46 @@ > #include > #include > > +/* > + * There is no clear requirements for the total size of Virtio MMIO region. > + * The size of control registers is 0x100 and device-specific configuration > + * registers starts at the offset 0x100, however it's size depends on the device > + * and the driver. Pick the biggest known size at the moment to cover most > + * of the devices (also consider allowing the user to configure the size via > + * config file for the one not conforming with the proposed value). > + */ > +#define VIRTIO_MMIO_DEV_SIZE xen_mk_ullong(0x200) > + > +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc, uint64_t *virtio_mmio_base) > +{ > + uint64_t base = *virtio_mmio_base; > + > + /* Make sure we have enough reserved resources */ > + if ((base + VIRTIO_MMIO_DEV_SIZE > > + GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) { > + LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n", > + base); > + return 0; > + } > + *virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE; > + > + return base; > +} > + > +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq) > +{ > + uint32_t irq = *virtio_mmio_irq; > + > + /* Make sure we have enough reserved resources */ > + if (irq > GUEST_VIRTIO_MMIO_SPI_LAST) { > + LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n", irq); > + return 0; > + } > + (*virtio_mmio_irq)++; > + > + return irq; > +} > + > static const char *gicv_to_string(libxl_gic_version gic_version) > { > switch (gic_version) { > @@ -26,8 +66,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > { > uint32_t nr_spis = 0; > unsigned int i; > - uint32_t vuart_irq; > - bool vuart_enabled = false; > + uint32_t vuart_irq, virtio_irq = 0; > + bool vuart_enabled = false, virtio_enabled = false; > + uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; > + uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; > > /* > * If pl011 vuart is enabled then increment the nr_spis to allow allocation > @@ -39,6 +81,30 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > vuart_enabled = true; > } > > + for (i = 0; i < d_config->num_disks; i++) { > + libxl_device_disk *disk = &d_config->disks[i]; > + > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); > + if (!disk->base) > + return ERROR_FAIL; > + > + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); > + if (!disk->irq) > + return ERROR_FAIL; > + > + if (virtio_irq < disk->irq) > + virtio_irq = disk->irq; > + virtio_enabled = true; > + > + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, > + disk->vdev, disk->irq, disk->base); > + } > + } > + > + if (virtio_enabled) > + nr_spis += (virtio_irq - 32) + 1; > + > for (i = 0; i < d_config->b_info.num_irqs; i++) { > uint32_t irq = d_config->b_info.irqs[i]; > uint32_t spi; > @@ -58,6 +124,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + /* The same check as for vpl011 */ > + if (virtio_enabled && > + (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) { > + LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq); > + return ERROR_FAIL; > + } > + > if (irq < 32) > continue; > > @@ -787,6 +860,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, > return 0; > } > > + > +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > + uint64_t base, uint32_t irq) > +{ > + int res; > + gic_interrupt intr; > + /* Placeholder for virtio@ + a 64-bit number + \0 */ > + char buf[24]; > + > + snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base); > + res = fdt_begin_node(fdt, buf); > + if (res) return res; > + > + res = fdt_property_compat(gc, fdt, 1, "virtio,mmio"); > + if (res) return res; > + > + res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, > + 1, base, VIRTIO_MMIO_DEV_SIZE); > + if (res) return res; > + > + set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING); > + res = fdt_property_interrupts(gc, fdt, &intr, 1); > + if (res) return res; > + > + res = fdt_property(fdt, "dma-coherent", NULL, 0); > + if (res) return res; > + > + res = fdt_end_node(fdt); > + if (res) return res; > + > + return 0; > +} > + > static const struct arch_info *get_arch_info(libxl__gc *gc, > const struct xc_dom_image *dom) > { > @@ -988,6 +1094,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > size_t fdt_size = 0; > int pfdt_size = 0; > libxl_domain_build_info *const info = &d_config->b_info; > + unsigned int i; > > const libxl_version_info *vers; > const struct arch_info *ainfo; > @@ -1094,6 +1201,13 @@ next_resize: > if (d_config->num_pcidevs) > FDT( make_vpci_node(gc, fdt, ainfo, dom) ); > > + for (i = 0; i < d_config->num_disks; i++) { > + libxl_device_disk *disk = &d_config->disks[i]; > + > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) > + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); > + } > + > if (pfdt) > FDT( copy_partial_fdt(gc, fdt, pfdt) ); > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index ab05fe1..c8b6058 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t; > > /* Physical Address Space */ > > +/* Virtio MMIO mappings */ > +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) > +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x00100000) > + > /* > * vGIC mappings: Only one set of mapping is used by the guest. > * Therefore they can overlap. > @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t; > > #define GUEST_VPL011_SPI 32 > > +#define GUEST_VIRTIO_MMIO_SPI_FIRST 33 > +#define GUEST_VIRTIO_MMIO_SPI_LAST 43 > + > /* PSCI functions */ > #define PSCI_cpu_suspend 0 > #define PSCI_cpu_off 1 > -- > 2.7.4 > --8323329-1965384132-1651622161=:43560-- From xen-devel-bounces@lists.xenproject.org Wed May 04 00:02:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 00:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319984.540472 (Exim 4.92) (envelope-from ) id 1nm2T7-0006sc-Le; Wed, 04 May 2022 00:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319984.540472; Wed, 04 May 2022 00:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm2T7-0006sV-IZ; Wed, 04 May 2022 00:02:13 +0000 Received: by outflank-mailman (input) for mailman id 319984; Wed, 04 May 2022 00:02:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm2T6-0006sP-6E for xen-devel@lists.xenproject.org; Wed, 04 May 2022 00:02:12 +0000 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7199c68d-cb3d-11ec-a406-831a346695d4; Wed, 04 May 2022 02:02:10 +0200 (CEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-d6e29fb3d7so18764090fac.7 for ; Tue, 03 May 2022 17:02:10 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id b14-20020a056870160e00b000e915a9121csm8077296oae.52.2022.05.03.17.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 17:02:08 -0700 (PDT) Received: (nullmailer pid 275646 invoked by uid 1000); Wed, 04 May 2022 00:02:08 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7199c68d-cb3d-11ec-a406-831a346695d4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XPALVs8tri7925YP8yP2QcFpx7h0JSNeGifZWhU99Ro=; b=ze6E0pCmSc92htYK4PJhcfgcE2U7KasC9uCnp3u5nluUO9pqIyVaZrBz8AKkHqLkf0 pLeb7NqXN7moaTqgHU4oioAg9bH5R45A55Va5PSD65d8YlPQhtpW+JReHAikDKensHix 9FoSMJ5J3HthdGyOJXyq9fIrBZSmXGDGJJ7JQE+jtW5Z1nYfbWA3MAznVXmqpYgTGQiQ Z+xTRG9Ox65vGFsXf+2fPgRnuq7xRwAfQVf/IiPWC5jXPNBelKknZAC9S8oVbXDIXPV6 BFgFH/phz6xQcPf+N5Im6DbIuvgbTbFjxdzZBXWOrJp7uJP9obxyOuLv0lqEQ77uCVET H+tg== X-Gm-Message-State: AOAM531Ieq+PzLNtuBiLgYL+6MElLm4Lve8utS02di+d43bRWR5rLyof dPf6z+Y07kAaDfixaf2bhw== X-Google-Smtp-Source: ABdhPJzDGRHxbFONbrvkkP2SSUKrYke5y7WcShS5ZvQNY7jHJAryoCIKp3IBbg4qJhIn8naxdCDyWw== X-Received: by 2002:a05:6870:b292:b0:ec:ec79:4842 with SMTP id c18-20020a056870b29200b000ecec794842mr2769207oao.145.1651622529455; Tue, 03 May 2022 17:02:09 -0700 (PDT) Date: Tue, 3 May 2022 19:02:08 -0500 From: Rob Herring To: Oleksandr Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, May 03, 2022 at 08:09:32PM +0300, Oleksandr wrote: > > On 03.05.22 00:59, Rob Herring wrote: > > Hello Rob > > > > On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: > > > From: Oleksandr Tyshchenko > > > > > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > > > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > > > > > This binding indicates that Xen grant mappings scheme needs to be > > > enabled for the device which DT node contains that property and specifies > > > the ID of Xen domain where the corresponding backend resides. The ID > > > (domid) is used as an argument to the grant mapping APIs. > > > > > > This is needed for the option to restrict memory access using Xen grant > > > mappings to work which primary goal is to enable using virtio devices > > > in Xen guests. > > > > > > Signed-off-by: Oleksandr Tyshchenko > > > --- > > > Changes RFC -> V1: > > > - update commit subject/description and text in description > > > - move to devicetree/bindings/arm/ > > > --- > > > .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > > new file mode 100644 > > > index 00000000..ef0f747 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > > @@ -0,0 +1,37 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Xen specific binding for the virtualized device (e.g. virtio) > > > + > > > +maintainers: > > > + - Oleksandr Tyshchenko > > > + > > > +select: true > > Do we really need to support this property everywhere? > > From my understanding - yes. > > As, I think, any device node describing virtulized device in the guest > device tree can have this property. Initially (in the RFC series) the > "solution to restrict memory access using Xen grant mappings" was > virtio-specific. > > Although the support of virtio is a primary target of this series, we > decided to generalize this work and expand it to any device [1]. So the Xen > grant mappings scheme (this property to be used for) can be theoretically > used for any device emulated by the Xen backend. > > > > > + > > > +description: > > > + This binding indicates that Xen grant mappings scheme needs to be enabled > > > + for that device and specifies the ID of Xen domain where the corresponding > > > + device (backend) resides. This is needed for the option to restrict memory > > > + access using Xen grant mappings to work. > > > + > > > +properties: > > > + xen,dev-domid: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: > > > + The domid (domain ID) of the domain where the device (backend) is running. > > > + > > > +additionalProperties: true > > > + > > > +examples: > > > + - | > > > + virtio_block@3000 { > > virtio@3000 > > ok, will change > > > > > > > + compatible = "virtio,mmio"; > > > + reg = <0x3000 0x100>; > > > + interrupts = <41>; > > > + > > > + /* The device is located in Xen domain with ID 1 */ > > > + xen,dev-domid = <1>; > > This fails validation: > > > > Documentation/devicetree/bindings/arm/xen,dev-domid.example.dtb: virtio_block@3000: xen,dev-domid: [[1]] is not of type 'object' > > From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/virtio/mmio.yaml > > Thank you for pointing this out, my fault, I haven't "properly" checked this > before. I think, we need to remove "compatible = "virtio,mmio"; here Uhh, no. That just means the example is incomplete. You need to add this property or reference this schema from virtio/mmio.yaml. > diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > index 2daa8aa..d2f2140 100644 > --- a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > @@ -28,7 +28,7 @@ additionalProperties: true > examples: > - | > virtio_block@3000 { > - compatible = "virtio,mmio"; > + /* ... */ > reg = <0x3000 0x100>; > interrupts = <41>; > > > > > > > The property has to be added to the virtio/mmio.yaml schema. If it is > > not needed elsewhere, then *just* add the property there. > > As I described above, the property is not virtio specific and can be used > for any virtualized device for which Xen grant mappings scheme needs to be > enabled (xen-grant DMA-mapping layer). But that's a finite list of devices, right? In any case, you have to list the property anywhere it can be used. Rob From xen-devel-bounces@lists.xenproject.org Wed May 04 01:00:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 01:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319995.540483 (Exim 4.92) (envelope-from ) id 1nm3NK-0001qV-5j; Wed, 04 May 2022 01:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319995.540483; Wed, 04 May 2022 01:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm3NK-0001pI-1M; Wed, 04 May 2022 01:00:18 +0000 Received: by outflank-mailman (input) for mailman id 319995; Wed, 04 May 2022 01:00:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm3NI-0001Sf-Ro; Wed, 04 May 2022 01:00:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm3NI-0006aa-QK; Wed, 04 May 2022 01:00:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm3NI-00038w-FT; Wed, 04 May 2022 01:00:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm3NI-0002CT-F3; Wed, 04 May 2022 01:00:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fkSrws6oweD/fW7Mz+eew9jahvJMtbDC/Rn30cPtFbg=; b=aTwRnjL5U8dS01IDOhJ3F2YcZU idczYDvhduWCwz8By/TVXSj40H2UEjbwGZKMQ8ddxeoCpC6r+A3fbTZ5LOWz9aEFxmGT+bd2yis0h FoZKreAHrv9fiSsCw8mifv4D44nVJrHPV/7uOpy6dZIScU/VRxBw7M7jUpY6BiEggO3o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170066: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 01:00:16 +0000 flight 170066 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170066/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 63 days 789 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 01:44:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 01:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320005.540500 (Exim 4.92) (envelope-from ) id 1nm43i-0006ni-K3; Wed, 04 May 2022 01:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320005.540500; Wed, 04 May 2022 01:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm43i-0006nb-Go; Wed, 04 May 2022 01:44:06 +0000 Received: by outflank-mailman (input) for mailman id 320005; Wed, 04 May 2022 01:44:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm43h-0006nR-1X; Wed, 04 May 2022 01:44:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm43g-0007Sc-Pr; Wed, 04 May 2022 01:44:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm43g-0005XJ-5y; Wed, 04 May 2022 01:44:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm43g-0006Qm-5G; Wed, 04 May 2022 01:44:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2iOQkroIC+r0AIvG6j/KQeZPi5S/C0Z6+20VTZCAewQ=; b=C8QWo2qx3lH6EKC/qt1RW2yNiu nmCevEWyL8icRBWyFp0O5GEg09Es1v3s8vUAB2x4rRDDcO5v70GZRSzU2qKefQ+jOGjYtKMv+z0D2 aXQMcVMlrCvwA/fB5mFVLBw5o0ta7Fubqzizi15i7RTr9FYURiQPxVbsZxVHb1Zf4sgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170053: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-examine-uefi:host-install:broken:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ef8e4d3c2ab1f47f63b6c7e578266b7e5cc9cd1b X-Osstest-Versions-That: linux=9050ba3a61a4b5bd84c2cde092a100404f814f31 From: osstest service owner Date: Wed, 04 May 2022 01:44:04 +0000 flight 170053 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170053/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine-uefi 5 host-install broken REGR. vs. 170001 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170001 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170001 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170001 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170001 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170001 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170001 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170001 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170001 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ef8e4d3c2ab1f47f63b6c7e578266b7e5cc9cd1b baseline version: linux 9050ba3a61a4b5bd84c2cde092a100404f814f31 Last test of basis 170001 2022-05-02 19:09:59 Z 1 days Testing same since 170053 2022-05-03 17:42:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Wujek Armin Wolf Denis Pauk Guenter Roeck Ji-Ze Hong (Peter Hong) Ji-Ze Hong (Peter Hong) Linus Torvalds Rob Herring Zev Weiss Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-step test-amd64-amd64-examine-uefi host-install Not pushing. ------------------------------------------------------------ commit ef8e4d3c2ab1f47f63b6c7e578266b7e5cc9cd1b Merge: 9050ba3a61a4 08da09f02804 Author: Linus Torvalds Date: Tue May 3 09:51:52 2022 -0700 Merge tag 'hwmon-for-v5.18-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging Pull hwmon fixes from Guenter Roeck: - Work around a hardware problem in the delta-ahe50dc-fan driver - Explicitly disable PEC in PMBus core if not enabled - Fix negative temperature values in f71882fg driver - Fix warning on removal of adt7470 driver - Fix CROSSHAIR VI HERO name in asus_wmi_sensors driver - Fix build warning seen in xdpe12284 driver if CONFIG_SENSORS_XDPE122_REGULATOR is disabled - Fix type of 'ti,n-factor' in ti,tmp421 driver bindings * tag 'hwmon-for-v5.18-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging: hwmon: (pmbus) delta-ahe50dc-fan: work around hardware quirk hwmon: (pmbus) disable PEC if not enabled hwmon: (f71882fg) Fix negative temperature dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' hwmon: (adt7470) Fix warning on module removal hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name hwmon: (xdpe12284) Fix build warning seen if CONFIG_SENSORS_XDPE122_REGULATOR is disabled commit 08da09f028043fed9653331ae75bc310411f72e6 Author: Zev Weiss Date: Tue Apr 26 20:51:09 2022 -0700 hwmon: (pmbus) delta-ahe50dc-fan: work around hardware quirk CLEAR_FAULTS commands can apparently sometimes trigger catastrophic power output glitches on the ahe-50dc, so block them from being sent at all. Signed-off-by: Zev Weiss Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220427035109.3819-1-zev@bewilderbeest.net Fixes: d387d88ed045 ("hwmon: (pmbus) Add Delta AHE-50DC fan control module driver") Signed-off-by: Guenter Roeck commit 75d2b2b06bd8407d03a3f126bc8b95eb356906c7 Author: Adam Wujek Date: Wed Apr 20 14:51:25 2022 +0000 hwmon: (pmbus) disable PEC if not enabled Explicitly disable PEC when the client does not support it. The problematic scenario is the following. A device with enabled PEC support is up and running and a kernel driver is loaded. Then the driver is unloaded (or device unbound), the HW device is reconfigured externally (e.g. by i2cset) to advertise itself as not supporting PEC. Without a new code, at the second load of the driver (or bind) the "flags" variable is not updated to avoid PEC usage. As a consequence the further communication with the device is done with the PEC enabled, which is wrong and may fail. The implementation first disable the I2C_CLIENT_PEC flag, then the old code enable it if needed. Fixes: 4e5418f787ec ("hwmon: (pmbus_core) Check adapter PEC support") Signed-off-by: Adam Wujek Link: https://lore.kernel.org/r/20220420145059.431061-1-dev_public@wujek.eu Signed-off-by: Guenter Roeck commit 4aaaaf0f279836f06d3b9d0ffeec7a1e1a04ceef Author: Ji-Ze Hong (Peter Hong) Date: Mon Apr 18 17:07:06 2022 +0800 hwmon: (f71882fg) Fix negative temperature All temperature of Fintek superio hwmonitor that using 1-byte reg will use 2's complement. In show_temp() temp = data->temp[nr] * 1000; When data->temp[nr] read as 255, it indicate -1C, but this code will report 255C to userspace. It'll be ok when change to: temp = ((s8)data->temp[nr]) * 1000; Signed-off-by: Ji-Ze Hong (Peter Hong) Link: https://lore.kernel.org/r/20220418090706.6339-1-hpeter+linux_kernel@gmail.com Signed-off-by: Guenter Roeck commit 4d0d5c352303a318925ceb84a86818761aa6586b Author: Rob Herring Date: Wed Apr 13 08:47:29 2022 -0500 dt-bindings: hwmon: ti,tmp421: Fix type for 'ti,n-factor' 'ti,n-factor' is read as a 32-bit signed value, so the type and constraints are wrong. The same property is also defined for ti,tmp464 and is correct. The constraints should also not be under 'items' as this property is not an array. Cc: Jean Delvare Cc: Guenter Roeck Cc: Krzysztof Kozlowski Cc: linux-hwmon@vger.kernel.org Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220413134729.3112190-1-robh@kernel.org Signed-off-by: Guenter Roeck commit 7b2666ce445c700b8dcee994da44ddcf050a0842 Author: Armin Wolf Date: Thu Apr 7 12:13:12 2022 +0200 hwmon: (adt7470) Fix warning on module removal When removing the adt7470 module, a warning might be printed: do not call blocking ops when !TASK_RUNNING; state=1 set at [] adt7470_update_thread+0x7b/0x130 [adt7470] This happens because adt7470_update_thread() can leave the kthread in TASK_INTERRUPTIBLE state when the kthread is being stopped before the call of set_current_state(). Since kthread_exit() might sleep in exit_signals(), the warning is printed. Fix that by using schedule_timeout_interruptible() and removing the call of set_current_state(). This causes TASK_INTERRUPTIBLE to be set after kthread_should_stop() which might cause the kthread to exit. Reported-by: Zheyu Ma Fixes: 93cacfd41f82 (hwmon: (adt7470) Allow faster removal) Signed-off-by: Armin Wolf Tested-by: Zheyu Ma Link: https://lore.kernel.org/r/20220407101312.13331-1-W_Armin@gmx.de Signed-off-by: Guenter Roeck commit 4fd45cc8568e6086272d3036f2c29d61e9b776a1 Author: Denis Pauk Date: Sun Apr 3 22:34:54 2022 +0300 hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name CROSSHAIR VI HERO motherboard is incorrectly named as ROG CROSSHAIR VI HERO. Signed-off-by: Denis Pauk Link: https://lore.kernel.org/r/20220403193455.1363-1-pauk.denis@gmail.com Signed-off-by: Guenter Roeck commit d6732317a5525a95a7eb2d12b46e3e42d321c6b6 Author: Guenter Roeck Date: Fri Mar 25 15:24:34 2022 -0700 hwmon: (xdpe12284) Fix build warning seen if CONFIG_SENSORS_XDPE122_REGULATOR is disabled 0-day reports: drivers/hwmon/pmbus/xdpe12284.c:127:36: warning: unused variable 'xdpe122_reg_desc' This is seen if CONFIG_SENSORS_XDPE122_REGULATOR is not enabled. Mark xdpe122_reg_desc as __maybe_unused to fix the problem. Fixes: f53bfe4d6984 ("hwmon: (xdpe12284) Add regulator support") Reported-by: kernel test robot Cc: Marcello Sylvester Bauer Signed-off-by: Guenter Roeck From xen-devel-bounces@lists.xenproject.org Wed May 04 02:00:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 02:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320082.540516 (Exim 4.92) (envelope-from ) id 1nm4J3-0000Lk-LF; Wed, 04 May 2022 01:59:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320082.540516; Wed, 04 May 2022 01:59:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4J3-0000Ld-Hq; Wed, 04 May 2022 01:59:57 +0000 Received: by outflank-mailman (input) for mailman id 320082; Wed, 04 May 2022 01:59:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4J1-0000LT-TO; Wed, 04 May 2022 01:59:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4J1-0007my-On; Wed, 04 May 2022 01:59:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4J1-0006ek-Be; Wed, 04 May 2022 01:59:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm4J1-0005nH-B8; Wed, 04 May 2022 01:59:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yt9MOYAGM2qqs6TvxvbA9CIMc3WTelF9p1xgdv0ee04=; b=BBDJUcY2tHa/lg+9vxNaDa4xLZ WGfDSnCwPSsaezPC3BhQzi3FmRtwgz+vj6GzX2of7ERt/Da6rvPsBtmaDa9+T4+zQXpUQQX58Cxom YisQOk5kB1wEMlbPlYIjDM3BYlvumP8/COTLuUUomWuX7O6qW17Ka0vGV4NEucOiVuaY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170069: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 01:59:55 +0000 flight 170069 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170069/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 790 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 03:49:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 03:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320103.540545 (Exim 4.92) (envelope-from ) id 1nm60Z-0002hn-4o; Wed, 04 May 2022 03:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320103.540545; Wed, 04 May 2022 03:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm60Z-0002hg-1L; Wed, 04 May 2022 03:48:59 +0000 Received: by outflank-mailman (input) for mailman id 320103; Wed, 04 May 2022 03:48:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm60X-0002hW-Gs; Wed, 04 May 2022 03:48:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm60X-0001sR-Fo; Wed, 04 May 2022 03:48:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm60X-0003Zn-56; Wed, 04 May 2022 03:48:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm60X-00039N-4g; Wed, 04 May 2022 03:48:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=48aIyUUkQsHAoyOMkqUMHMmuPbWnxTmXATNDwxrfw5g=; b=Z606O9MiN4uoYaB6qs1pUMjThl wmdGb0X1LFWCOG2EthcnFdmxmpeRd3S1eZzeaAjVcLHoECTpAn4Tkff1p+5xG1Ciq7EpmuLPyoNdh vPsOd+uyjuO7cWBtoeroy4Hhg5dxTEWQF1AKpcLSfJfasbSf9ytsBuTVduFzhvQLz1bI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170073: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 03:48:57 +0000 flight 170073 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170073/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 791 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 04:46:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 04:46:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320111.540557 (Exim 4.92) (envelope-from ) id 1nm6tw-0000DF-Ar; Wed, 04 May 2022 04:46:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320111.540557; Wed, 04 May 2022 04:46:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm6tw-0000D8-6A; Wed, 04 May 2022 04:46:12 +0000 Received: by outflank-mailman (input) for mailman id 320111; Wed, 04 May 2022 04:46:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm6tu-0000Cy-M1; Wed, 04 May 2022 04:46:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm6tu-00030h-KT; Wed, 04 May 2022 04:46:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm6tu-000762-9m; Wed, 04 May 2022 04:46:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm6tu-0003x8-9H; Wed, 04 May 2022 04:46:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Fba87cU6ebv+lT3sD/LMjNj/eTEjrMAVi0irCxPshYg=; b=M5hIABOygsUgVMf0/nEanKnaFs oBxJZnNu/Dv0+LmZQk9KfNr8WxX+wet/KosstjPNvF4PjUTqg/TQDc7kN/52kzbEzzOJdP7Vy/+1a LXQZFUPouCD5ggdnOlsckAtG5SGzQAeHHFiN+yYKOGWkKYJEzXel5GwAvJmhTSMtCCaE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170077: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 04:46:10 +0000 flight 170077 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170077/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 792 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 05:14:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:14:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319923.540568 (Exim 4.92) (envelope-from ) id 1nm7L4-0003vL-En; Wed, 04 May 2022 05:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319923.540568; Wed, 04 May 2022 05:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7L4-0003vE-BJ; Wed, 04 May 2022 05:14:14 +0000 Received: by outflank-mailman (input) for mailman id 319923; Tue, 03 May 2022 19:36:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlyJX-0003oK-9a for xen-devel@lists.xenproject.org; Tue, 03 May 2022 19:36:03 +0000 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [2607:f8b0:4864:20::1129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43846196-cb18-11ec-a406-831a346695d4; Tue, 03 May 2022 21:36:02 +0200 (CEST) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-2f863469afbso167288887b3.0 for ; Tue, 03 May 2022 12:36:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43846196-cb18-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=n3Zc0sMo50Lmd548uHQmkNDpex8oEWoswi229+miYCw=; b=PiC6x02SrBwxBsIwisXmQAgrus9YNtZzZXEAYPYV65jYEtvzanbYLmXBI6CsZB8u61 B95O5wI9MwgtwNWN1Qh/qis1doJMxsYYNMJ8oyj6mQpgK7QDHeA2TpQPdZ+d12/U2BMT /ho0fmvw0vgSkBDynpK5O2jOhn2ZvecV6Q8ZEi4mkPHeuHZRvL08Gfbqo1ZP49E3wBMG k9Cq4AjZhkSnrsuFhOGNbDc0PAFdDYL+TA7gCjxhDkbJ0nbj8ezfkzjX31kWRgv1qWoa e5U/VrVYBUU5T724jhHjPaOzeCiBgZVScbNeaXgHwUXCpGVD9nZSYoFLCV4IRRZzt47b vyXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=n3Zc0sMo50Lmd548uHQmkNDpex8oEWoswi229+miYCw=; b=ssL2f+F/q25zHav9Gp8GBczl7cVsQS4IiXzaFg29TSYSb28A30Sg8ODgzuRSYuiOHp uDBcDcFzLSSlWuo6kdscwYcUsZdtkNcXsTFpbMA3kTrzdpKaUxZwPxzxFfvvUdX9fELn CV/WqFckzFv5bCwpIVGDxq4ZggTOcXWe1nNr21LqG7YHkXZiqIYvyTMnoY9Qq4DA2LSC XwYoePfYOgpM2ogeV1Y+eBWftKx9zUGMAvZNfLy8HMp7N9qTo4vXe6hBwv35sKl4wbTa zpUDukTHIO2eHm140/voBw1JLR+M2fLbDJtU8Q9Y+nGx9yfrwzs2poO3Duq3/Un3h025 IFZw== X-Gm-Message-State: AOAM533Hrdw23/kfr+uYBQ8ZJNq0mFkGNAHR+sLUXkSU7vbSmFLCheSk vBB2K257Nch4UUIg9fGO2YdhQz42Te6MChXpAYNKWghQ9lg= X-Google-Smtp-Source: ABdhPJys2WpISuQNmNm+sBglpHUjCpmzyin+y4uQIl7/ID63li/2beL7qcHok94+GNaoU6E2D4tkuJvRDDuqevhidR0= X-Received: by 2002:a0d:d98c:0:b0:2f8:e554:3541 with SMTP id b134-20020a0dd98c000000b002f8e5543541mr14112102ywe.446.1651606560664; Tue, 03 May 2022 12:36:00 -0700 (PDT) MIME-Version: 1.0 From: Colton Reeder Date: Tue, 3 May 2022 12:36:43 -0700 Message-ID: Subject: OPNSense running in domU has no network connectivity on 5.15.29+ To: xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hello, I am running the FreeBSD-based router OS OPNSense in a domU. I recently upgraded my dom0 kernel from 5.15.26 to 5.15.32 and with the new kernel, OPNSense had no connectivity. I downloaded from kernel.org 5.15.26-32, built and installed each version and booted them consecutively until I found the version that no longer worked. It turned out to be 5.15.29. I looked through the change log of 5.15.29 and found two commits for xen-netback commit 2708ceb4e5cc84ef179bad25a2d7890573ef78be commit fe39ab30dcc204e321c2670cc1cf55904af35d01 I reverted these changes (a revert of a revert, yes) in 5.15.32, built and installed. Now the network works. Now I dont know enough to know thats for sure the right fix. Maybe I have a config issue, I dont know, but reverting that change fixes the problem. What should I do? I was asked to provide xenstore -ls https://pastebin.com/hHPWgrEy From xen-devel-bounces@lists.xenproject.org Wed May 04 05:15:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:15:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319874.540578 (Exim 4.92) (envelope-from ) id 1nm7Lr-0004R7-NE; Wed, 04 May 2022 05:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319874.540578; Wed, 04 May 2022 05:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Lr-0004R0-KK; Wed, 04 May 2022 05:15:03 +0000 Received: by outflank-mailman (input) for mailman id 319874; Tue, 03 May 2022 18:10:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nlwyc-0008L1-TW for xen-devel@lists.xenproject.org; Tue, 03 May 2022 18:10:22 +0000 Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [2001:4860:4864:20::2a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b8f12ba-cb0c-11ec-8fc4-03012f2f19d4; Tue, 03 May 2022 20:10:21 +0200 (CEST) Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-e93ff05b23so17959511fac.9 for ; Tue, 03 May 2022 11:10:21 -0700 (PDT) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com. [209.85.167.175]) by smtp.gmail.com with ESMTPSA id h3-20020a056870d24300b000e686d1386fsm7141694oac.9.2022.05.03.11.10.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 11:10:20 -0700 (PDT) Received: by mail-oi1-f175.google.com with SMTP id e189so18977535oia.8 for ; Tue, 03 May 2022 11:10:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b8f12ba-cb0c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4/K6aedIUl9MohMPOlkW7bX2DydtcwCMb+CydErQh0=; b=CJu9kW5FihxnTA4wr5HdIEfymEuuekA79aJVNMM2F6kdV2+CmmuoX8R9fhQ+4vfzGu cwr0+95tIZHFde4YyKyVQIEU1uoccXZ0Wre6iNf7ZQo6N8EA9gsX+jTvyEJvXCE49T6e 235jqkHQ/du2SkGvAqn3TvfA6e2cYQxB3dcEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4/K6aedIUl9MohMPOlkW7bX2DydtcwCMb+CydErQh0=; b=mANBf/56P26M3i4J+XdC29p3ZzMuNp+xWUru7SFyoFB4C4md3mS2PCPRKYTorwrlQN OVnLICJGg7AIm9aCHpCdNGiov49GGbVyqyfrzheRNtwQlfsUGVuuNiJGyqurYkv96lc4 74V3onSmRgFGP7HwQo9wP746niCExJ+2ibOhXCBruHPY3+FeF3FSG2yALazsjNkVQB9H EEoHfnNbjQ1csZxednlee5RjfDV4fHnoCZKSIA+bBGrH4HwqA94id4AVhAvAYmwyFRAj nXO7RsM8+SNoU7SZA3FifPpBDDhmWXM9ucfqg+5+cn6E0WWZxhn3ZV8Qf62M1gQF6+lV THkA== X-Gm-Message-State: AOAM530R4oZvl14hMqO0oREPqr8c77InAiEJ+tUdGMR83YzrBjsU8SKB el0WGVOT9D1eOumgX0ybqn69tP4BUlXxjA== X-Google-Smtp-Source: ABdhPJwTfrzb9fERfXK28ycmomtnyX6s1/viu/AmSIMRHMupK9xAnIyo2wHhfFbfgmmsmT/wfOu81Q== X-Received: by 2002:a05:6870:d683:b0:de:eaa2:3550 with SMTP id z3-20020a056870d68300b000deeaa23550mr2338878oap.253.1651601420400; Tue, 03 May 2022 11:10:20 -0700 (PDT) X-Received: by 2002:a05:6808:d50:b0:322:fb1d:319d with SMTP id w16-20020a0568080d5000b00322fb1d319dmr2350498oik.174.1651601052906; Tue, 03 May 2022 11:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> In-Reply-To: <20220427224924.592546-5-gpiccoli@igalia.com> From: Evan Green Date: Tue, 3 May 2022 11:03:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path To: "Guilherme G. Piccoli" Cc: Andrew Morton , bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Content-Type: text/plain; charset="UTF-8" On Wed, Apr 27, 2022 at 3:51 PM Guilherme G. Piccoli wrote: > > Currently the gsmi driver registers a panic notifier as well as > reboot and die notifiers. The callbacks registered are called in > atomic and very limited context - for instance, panic disables > preemption, local IRQs and all other CPUs that aren't running the > current panic function. > > With that said, taking a spinlock in this scenario is a > dangerous invitation for a deadlock scenario. So, we fix > that in this commit by changing the regular spinlock with > a trylock, which is a safer approach. > > Fixes: 74c5b31c6618 ("driver: Google EFI SMI") > Cc: Ard Biesheuvel > Cc: David Gow > Cc: Evan Green > Cc: Julius Werner > Signed-off-by: Guilherme G. Piccoli > --- > drivers/firmware/google/gsmi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c > index adaa492c3d2d..b01ed02e4a87 100644 > --- a/drivers/firmware/google/gsmi.c > +++ b/drivers/firmware/google/gsmi.c > @@ -629,7 +629,10 @@ static int gsmi_shutdown_reason(int reason) > if (saved_reason & (1 << reason)) > return 0; > > - spin_lock_irqsave(&gsmi_dev.lock, flags); > + if (!spin_trylock_irqsave(&gsmi_dev.lock, flags)) { > + rc = -EBUSY; > + goto out; > + } gsmi_shutdown_reason() is a common function called in other scenarios as well, like reboot and thermal trip, where it may still make sense to wait to acquire a spinlock. Maybe we should add a parameter to gsmi_shutdown_reason() so that you can get your change on panic, but we don't convert other callbacks into try-fail scenarios causing us to miss logs. Though thinking more about it, is this really a Good Change (TM)? The spinlock itself already disables interrupts, meaning the only case where this change makes a difference is if the panic happens from within the function that grabbed the spinlock (in which case the callback is also likely to panic), or in an NMI that panics within that window. The downside of this change is that if one core was politely working through an event with the lock held, and another core panics, we now might lose the panic log, even though it probably would have gone through fine assuming the other core has a chance to continue. -Evan From xen-devel-bounces@lists.xenproject.org Wed May 04 05:15:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:15:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.319949.540585 (Exim 4.92) (envelope-from ) id 1nm7Ls-0004Un-2J; Wed, 04 May 2022 05:15:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 319949.540585; Wed, 04 May 2022 05:15:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Lr-0004UP-TG; Wed, 04 May 2022 05:15:03 +0000 Received: by outflank-mailman (input) for mailman id 319949; Tue, 03 May 2022 21:57:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm0Wi-0001N4-J1 for xen-devel@lists.xenproject.org; Tue, 03 May 2022 21:57:48 +0000 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [2001:4860:4864:20::2c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10d4269f-cb2c-11ec-a406-831a346695d4; Tue, 03 May 2022 23:57:47 +0200 (CEST) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-ed8a3962f8so8478875fac.4 for ; Tue, 03 May 2022 14:57:47 -0700 (PDT) Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com. [209.85.160.53]) by smtp.gmail.com with ESMTPSA id z4-20020a056870514400b000edae17a8cesm2296872oak.3.2022.05.03.14.57.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 14:57:45 -0700 (PDT) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-e2fa360f6dso18584158fac.2 for ; Tue, 03 May 2022 14:57:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10d4269f-cb2c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=czLZHU7MG6H1spBLHXY5jaZbzV59tXkMuN+Ck8Z7wc4=; b=hhWjsHnmVba6J3iaRJaO09nZL4LxjIq8C9W91LOfNC4XgTIwgTHymewopsSR7xhrbE wJfMPDofFT9Orm5X1Xmnq6csdeG70AmAjQHsJ6oidSvnu+c5NqT0zTpfwvGt6c7imJaY Yx4JIofQGY7s+yKOtcqFuF1p2zpjcELmsl0YE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=czLZHU7MG6H1spBLHXY5jaZbzV59tXkMuN+Ck8Z7wc4=; b=pui6iQPCX6qHuB24e1WM14qTzuQquJxDqCFxcsUdOz7/7V6R50lqZgUMPsNqVoIN+q 1bZuu9cmlOQVKGWjPr5C3VfsJCxFaQS/77bp7uOrs5AseuuwhyQ2S1cIuo5t9tfHZ6R1 AzNj+vUFf3VSO/uaqFPVD8cQDZS/Q8p6RT/sJ/mdfzyU5ocP+zJEgeR6N6NiRRYx2O9s MJI3Qy1m8mpYPjA8BpTqxrNacG4D881/fSdh4cSUwkOSpsnEmm3BGi8rlStgpqTINSks KrAiNCR8mHoZyU+FLuKiclAwcJTKXusVcQb1Okrfi2HysQ899V3rgp03dTuUFXl1zmSQ ypXw== X-Gm-Message-State: AOAM5319PiBj2lc9A1mansQqyjSDXDRt9RM7SQmqkqCZ3jmLfPctnAuQ qYUF5Wf1muBu5HPSOSZzDVV40oC4cp95f0Qh X-Google-Smtp-Source: ABdhPJx5rURYPENHPTpAtcdR2ujaXKwN++NfzKhXqO4u0NAQP1pT7L+sAFz8wp3DgjvhDWatHCMP7w== X-Received: by 2002:a05:6870:61d4:b0:df:b74:8de5 with SMTP id b20-20020a05687061d400b000df0b748de5mr2623969oah.37.1651615065673; Tue, 03 May 2022 14:57:45 -0700 (PDT) X-Received: by 2002:a05:6808:219a:b0:325:93fc:e0fd with SMTP id be26-20020a056808219a00b0032593fce0fdmr2775646oib.241.1651615054192; Tue, 03 May 2022 14:57:34 -0700 (PDT) MIME-Version: 1.0 References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> In-Reply-To: From: Evan Green Date: Tue, 3 May 2022 14:56:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path To: "Guilherme G. Piccoli" Cc: Andrew Morton , bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Content-Type: text/plain; charset="UTF-8" Hi Guilherme, On Tue, May 3, 2022 at 12:12 PM Guilherme G. Piccoli wrote: > > On 03/05/2022 15:03, Evan Green wrote: > > [...] > > gsmi_shutdown_reason() is a common function called in other scenarios > > as well, like reboot and thermal trip, where it may still make sense > > to wait to acquire a spinlock. Maybe we should add a parameter to > > gsmi_shutdown_reason() so that you can get your change on panic, but > > we don't convert other callbacks into try-fail scenarios causing us to > > miss logs. > > > > Hi Evan, thanks for your feedback, much appreciated! > What I've done in other cases like this was to have a helper checking > the spinlock in the panic notifier - if we can acquire that, go ahead > but if not, bail out. For a proper example of an implementation, check > patch 13 of the series: > https://lore.kernel.org/lkml/20220427224924.592546-14-gpiccoli@igalia.com/ . > > Do you agree with that, or prefer really a parameter in > gsmi_shutdown_reason() ? I'll follow your choice =) I'm fine with either, thanks for the link. Mostly I want to make sure other paths to gsmi_shutdown_reason() aren't also converted to a try. > > > > Though thinking more about it, is this really a Good Change (TM)? The > > spinlock itself already disables interrupts, meaning the only case > > where this change makes a difference is if the panic happens from > > within the function that grabbed the spinlock (in which case the > > callback is also likely to panic), or in an NMI that panics within > > that window. The downside of this change is that if one core was > > politely working through an event with the lock held, and another core > > panics, we now might lose the panic log, even though it probably would > > have gone through fine assuming the other core has a chance to > > continue. > > My feeling is that this is a good change, indeed - a lot of places are > getting changed like this, in this series. > > Reasoning: the problem with your example is that, by default, secondary > CPUs are disabled in the panic path, through an IPI mechanism. IPIs take > precedence and interrupt the work in these CPUs, effectively > interrupting the "polite work" with the lock held heh The IPI can only interrupt a CPU with irqs disabled if the IPI is an NMI. I haven't looked before to see if we use NMI IPIs to corral the other CPUs on panic. On x86, I grepped my way down to native_stop_other_cpus(), which looks like it does a normal IPI, waits 1 second, then does an NMI IPI. So, if a secondary CPU has the lock held, on x86 it has roughly 1s to finish what it's doing and re-enable interrupts before smp_send_stop() brings the NMI hammer down. I think this should be more than enough time for the secondary CPU to get out and release the lock. So then it makes sense to me that you're fixing cases where we panicked with the lock held, or hung with the lock held. Given the 1 second grace period x86 gives us, I'm on board, as that helps mitigate the risk that we bailed out early with the try and should have spun a bit longer instead. Thanks. -Evan > > Then, such CPU is put to sleep and we finally reach the panic notifier > hereby discussed, in the main CPU. If the other CPU was shut-off *with > the lock held*, it's never finishing such work, so the lock is never to > be released. Conclusion: the spinlock can't be acquired, hence we broke > the machine (which is already broken, given it's panic) in the path of > this notifier. > This should be really rare, but..possible. So I think we should protect > against this scenario. > > We can grab others' feedback if you prefer, and of course you have the > rights to refuse this change in the gsmi code, but from my > point-of-view, I don't see any advantage in just assume the risk, > specially since the change is very very simple. > > Cheers, > > > Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320014.540601 (Exim 4.92) (envelope-from ) id 1nm7N3-0005h7-HL; Wed, 04 May 2022 05:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320014.540601; Wed, 04 May 2022 05:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N3-0005h0-Dn; Wed, 04 May 2022 05:16:17 +0000 Received: by outflank-mailman (input) for mailman id 320014; Wed, 04 May 2022 01:47:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm476-0007U1-Ab for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:36 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ab0349a-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:47:34 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id i1so157085plg.7 for ; Tue, 03 May 2022 18:47:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k18-20020aa78212000000b0050dc76281d8sm7127921pfi.178.2022.05.03.18.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ab0349a-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sclcWESS1vfOtw+/lNSZNu/Le9PHpJZ15I1QqAAnvbk=; b=aAevwHR9bd3JwLUN2/LQ5c9sjKYomRXHOOzT8MO771crgcUz3lq0Os/XqytwNxvtUl OUsDFPJQodMi3Gdr6qEsX6JPLYzpX2mmV6xIquzdXHmOBlRoXebJSJEipFEaZ36NWHtd 8ThHw67NIdrIhrBqNV3S6GthwijgxDY2pMUM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sclcWESS1vfOtw+/lNSZNu/Le9PHpJZ15I1QqAAnvbk=; b=K8Q0jilwOC34AFyxP7ce4853PeUbUaY+3zJ7OYfSXJ76eIQv8Jp8qhDwzjDv3BsZNW kxchzpSI5it8TXa6ILjhhALjEgZB6fzfozpxIM9Agu0YEmYzO/HW1mOGya9DkUWwJ2wN 61TApTaMd0k+Hz+X4T7Ld53V127jLNFo9V8W3ejEsNApclJKH6KnGuEh1Ths23CiJQRu jr1mK0X4W5P/ukz6cXr+23Q6IN+LgWR5Bdd0isg6o9+67JcKJ7JVzXW7c/6SXWxuoJ/d y6YXLs1ZUXNZRV30CcfJKaiVMA880BvsrOI8uBPYAqCuSlqe0/CEsgsLyHv9sgKsPF16 h+Tg== X-Gm-Message-State: AOAM533B6a+iQKCcFLrN1B+b05rdEa0g08oU3oXbz4zf4SYMZAPQQS7d 1Ip5tPr5J15gzedTsFgZp/2+GA== X-Google-Smtp-Source: ABdhPJydthUqGsV5WN/Na4umt7Tao7IcxfjHP60PQVyNBHqb1vS1VBDCQ+czysKBY9MzdUuG7LicnA== X-Received: by 2002:a17:90b:4b52:b0:1dc:6602:4ea with SMTP id mi18-20020a17090b4b5200b001dc660204eamr7857020pjb.38.1651628852964; Tue, 03 May 2022 18:47:32 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 00/32] Introduce flexible array struct memcpy() helpers Date: Tue, 3 May 2022 18:44:09 -0700 Message-Id: <20220504014440.3697851-1-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6778; h=from:subject; bh=NBPx/kHPxccGjkqS1SEj//lWw761DgDLlzW6gj8lDu4=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqAMDKbiuLQ8pX7zUwKdz8OKsd8xesPXEJn90lJ iEErvqmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagAAKCRCJcvTf3G3AJjEaD/ sFb+hZKXd2lFEv0+WnlWvb0j4ta2t/UZVhsNUWQNDJHAVtv+Zlu02MxnR0jdR0CBnsA3iKMPIFMmfD pdgs6dba5/tH1Iyi6jW+wJXwtek/3ey7ygj+u19Odj4PSt0QygwmNm6MjSvTES52gqKWv74MU5t5xz L/SasXg+UAUYtWgal3FtLixo//9nvHNO1pQXa0nIFsWFnV/HFJgtQ4lutI26Hj2oKn8G30z3GHGSn4 1IRXOAidSEkPmoGdbgk1b5NrcIB4dDVp1bZOWVQ48/ez1pipyXC5BUmkDkC/X1S5WnuU0ZQ0UW1Grm 3khhO+QcGTzdaxvhpnGpJechhRJETE1ML25oQrj3M1NNy97RDl4CAzoWJillKIvj0+U+3eRoIKQc09 jVarH3JkPknzz7xPutFPSXX+ZRRa9ZIrntaHAJu8fM/gDMHvlhMmoSO/MpZW8uL4xNo34dAwBiIsfO 3kXWSB5poclt6J8JY4UGRwxeS2Ccjolknj9sm/IfEioLedUmK04grKYVaFhwm/AgWMQXfLQYxU4UVg LzieTWMmZ+uNuV5sEynHPDSzGXpTKhNmWdH0WmkjYCGd9FIF8ySFxwKVRfGpnPqbVGVOMqmYz9piV5 jE5S5aSXLfYPuj0uiXQg9UZZfkTvEGuBLHq71VsZwciiyvWRhtAG4UU4gmcQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit Hi, This is the next phase of memcpy() buffer bounds checking[1], which starts by adding a new set of helpers to address common code patterns that result in memcpy() usage that can't be easily verified by the compiler (i.e. dynamic bounds due to flexible arrays). The runtime WARN from memcpy has been posted before, but now there's more context around alternatives for refactoring false positives, etc. The core of this series is patches 2 (flex_array.h), 3 (flex_array KUnit), and 4 (runtime memcpy WARN). Patch 1 is a fix to land before 4 (and I can send separately), and everything else are examples of what the conversions look like for one of the helpers, mem_to_flex_dup(). These will need to land via their respective trees, but they all depend on patch 2, which I'm hoping to land in the coming merge window. I'm happy to also point out that the conversions (patches 5+) are actually a net reduction in lines of code: 49 files changed, 154 insertions(+), 244 deletions(-) Anyway, please let me know what you think. And apologies in advance if this is spammy; the CC list got rather large due to the "treewide" nature of the example conversions. Also available here: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=flexcpy/next-20220502 -Kees [1] https://lwn.net/Articles/864521/ Kees Cook (32): netlink: Avoid memcpy() across flexible array boundary Introduce flexible array struct memcpy() helpers flex_array: Add Kunit tests fortify: Add run-time WARN for cross-field memcpy() brcmfmac: Use mem_to_flex_dup() with struct brcmf_fweh_queue_item iwlwifi: calib: Prepare to use mem_to_flex_dup() iwlwifi: calib: Use mem_to_flex_dup() with struct iwl_calib_result iwlwifi: mvm: Use mem_to_flex_dup() with struct ieee80211_key_conf p54: Use mem_to_flex_dup() with struct p54_cal_database wcn36xx: Use mem_to_flex_dup() with struct wcn36xx_hal_ind_msg nl80211: Use mem_to_flex_dup() with struct cfg80211_cqm_config cfg80211: Use mem_to_flex_dup() with struct cfg80211_bss_ies mac80211: Use mem_to_flex_dup() with several structs af_unix: Use mem_to_flex_dup() with struct unix_address 802/garp: Use mem_to_flex_dup() with struct garp_attr 802/mrp: Use mem_to_flex_dup() with struct mrp_attr net/flow_offload: Use mem_to_flex_dup() with struct flow_action_cookie firewire: Use __mem_to_flex_dup() with struct iso_interrupt_event afs: Use mem_to_flex_dup() with struct afs_acl ASoC: sigmadsp: Use mem_to_flex_dup() with struct sigmadsp_data soc: qcom: apr: Use mem_to_flex_dup() with struct apr_rx_buf atags_proc: Use mem_to_flex_dup() with struct buffer Bluetooth: Use mem_to_flex_dup() with struct hci_op_configure_data_path IB/hfi1: Use mem_to_flex_dup() for struct tid_rb_node Drivers: hv: utils: Use mem_to_flex_dup() with struct cn_msg ima: Use mem_to_flex_dup() with struct modsig KEYS: Use mem_to_flex_dup() with struct user_key_payload selinux: Use mem_to_flex_dup() with xfrm and sidtab xtensa: Use mem_to_flex_dup() with struct property usb: gadget: f_fs: Use mem_to_flex_dup() with struct ffs_buffer xenbus: Use mem_to_flex_dup() with struct read_buffer esas2r: Use __mem_to_flex() with struct atto_ioctl arch/arm/kernel/atags_proc.c | 12 +- arch/xtensa/platforms/xtfpga/setup.c | 9 +- drivers/firewire/core-cdev.c | 7 +- drivers/hv/hv_utils_transport.c | 7 +- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 7 +- drivers/infiniband/hw/hfi1/user_exp_rcv.h | 4 +- drivers/net/wireless/ath/wcn36xx/smd.c | 8 +- drivers/net/wireless/ath/wcn36xx/smd.h | 4 +- .../broadcom/brcm80211/brcmfmac/fweh.c | 11 +- drivers/net/wireless/intel/iwlwifi/dvm/agn.h | 2 +- .../net/wireless/intel/iwlwifi/dvm/calib.c | 23 +- .../net/wireless/intel/iwlwifi/dvm/ucode.c | 8 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 8 +- drivers/net/wireless/intersil/p54/eeprom.c | 8 +- drivers/net/wireless/intersil/p54/p54.h | 4 +- drivers/scsi/esas2r/atioctl.h | 1 + drivers/scsi/esas2r/esas2r_ioctl.c | 11 +- drivers/soc/qcom/apr.c | 12 +- drivers/usb/gadget/function/f_fs.c | 11 +- drivers/xen/xenbus/xenbus_dev_frontend.c | 12 +- fs/afs/internal.h | 4 +- fs/afs/xattr.c | 7 +- include/keys/user-type.h | 4 +- include/linux/flex_array.h | 637 ++++++++++++++++++ include/linux/fortify-string.h | 70 +- include/linux/of.h | 3 +- include/linux/string.h | 1 + include/net/af_unix.h | 14 +- include/net/bluetooth/hci.h | 4 +- include/net/cfg80211.h | 4 +- include/net/flow_offload.h | 4 +- include/net/garp.h | 4 +- include/net/mac80211.h | 4 +- include/net/mrp.h | 4 +- include/uapi/linux/connector.h | 4 +- include/uapi/linux/firewire-cdev.h | 4 +- include/uapi/linux/netlink.h | 1 + include/uapi/linux/stddef.h | 14 + include/uapi/linux/xfrm.h | 4 +- lib/Kconfig.debug | 12 +- lib/Makefile | 1 + lib/flex_array_kunit.c | 523 ++++++++++++++ net/802/garp.c | 9 +- net/802/mrp.c | 9 +- net/bluetooth/hci_request.c | 9 +- net/core/flow_offload.c | 7 +- net/mac80211/cfg.c | 22 +- net/mac80211/ieee80211_i.h | 12 +- net/netlink/af_netlink.c | 5 +- net/unix/af_unix.c | 7 +- net/wireless/core.h | 4 +- net/wireless/nl80211.c | 15 +- net/wireless/scan.c | 21 +- security/integrity/ima/ima_modsig.c | 12 +- security/keys/user_defined.c | 7 +- security/selinux/ss/sidtab.c | 9 +- security/selinux/xfrm.c | 7 +- sound/soc/codecs/sigmadsp.c | 11 +- 58 files changed, 1409 insertions(+), 253 deletions(-) create mode 100644 include/linux/flex_array.h create mode 100644 lib/flex_array_kunit.c -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320019.540619 (Exim 4.92) (envelope-from ) id 1nm7N4-0005xr-OY; Wed, 04 May 2022 05:16:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320019.540619; Wed, 04 May 2022 05:16:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N4-0005vw-ET; Wed, 04 May 2022 05:16:18 +0000 Received: by outflank-mailman (input) for mailman id 320019; Wed, 04 May 2022 01:47:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm478-0007U4-VW for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:39 +0000 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [2607:f8b0:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c029691-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:36 +0200 (CEST) Received: by mail-pg1-x532.google.com with SMTP id t13so8564pgn.8 for ; Tue, 03 May 2022 18:47:36 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d10-20020a170903208a00b0015e8d4eb1e8sm6942318plc.50.2022.05.03.18.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c029691-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5xrPLh8wlK0Awe/nxhZ3OTQkBfhB9ct4glfpE9UmuQA=; b=iR9L6Vqjlx1BryUCEPQzmXGsipsWNHmgM203Ex9fHJaxkwALa+U/8+AhC1W6u8Uu4S pdpKAydA7J6X8qY7ulBdTwd5M0XdedZwrLJ2rJGOBc8ssCMpRdfFdFzH/3OiOkWgs3nY iUUPR2F7rY3hlYziqOz651zfzNr5dc2NwLGx4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5xrPLh8wlK0Awe/nxhZ3OTQkBfhB9ct4glfpE9UmuQA=; b=68zlw9162eImomox+uTr66LNJfDgM5R3ZFxEkQ4ytdSTk6QR/tSjJNF0VdMOZf38p3 WUFBKb+3wNje5cLXfzPGadmvyNX+etJxWORn9uKIgpx3sKRy9J7PFSl6OcBaqLWWfpaf Hbej7hMdQsJ7WmuWtAmj2HZtXng/mtjQNGWFJo5TDmIwenbiUD3Nnztvwl2+yjftre9f /m//osB0GkuBgADv/kiTl1VTabzwl0zc1OufdG60bGmrpS5U2JA5KVOijAErNjvLA9Rm x1+7Q9e+UIT4HQsARcuOk2s0GE4sdlmq6n7VAU2to8slgLLGX961Hi1dralLG8wNvRVh Ld+A== X-Gm-Message-State: AOAM532Z0NMWq6LaMooigsvrFKqiINoqx/H2S/z5a1LI649lPKF/ZrHz AQy2g2d07gJ6lqTMOA5loe2gTw== X-Google-Smtp-Source: ABdhPJwtYLoTUD9KqFl1mr1s8ohNwDAzj5ZRjD1HD2J430AUFuNRKn9PfFCjyKwAxdqiF9EOZPPuPw== X-Received: by 2002:a05:6a00:1695:b0:4f7:decc:506b with SMTP id k21-20020a056a00169500b004f7decc506bmr18741084pfc.7.1651628855010; Tue, 03 May 2022 18:47:35 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Date: Tue, 3 May 2022 18:44:11 -0700 Message-Id: <20220504014440.3697851-3-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=31712; h=from:subject; bh=5cc80Yc5OXNqRAprch5bwZGcqXUCUMStKhnm0MOB3y0=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqBuKUviArqTxzH7Wyv/Nwvzm6EtfG7z8zEgd2S CFn/D26JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagQAKCRCJcvTf3G3AJpjQEA ChDXz4K07hJ0QiNbIT6owwYl55x0UIZFIMNeKxftQCbtR6Cl3MX4CkUi+/EJ8C8dPDo6mlzFTZqAxE XzATgYZNuJ523DOE/BPbCYmvKr4YAWPu6Wn7kbjIxVBMviz5nZcyJxQ+/XBUyAGJ3SxROvWBwUjV/6 F/JTDhfGISKpN7rStULVRZGpTFvhYy7KSGzeySPi7vdd0TzXBe/xWYm4+5OavNt9bEaQtWuPDsj44s DUlQOr5PRhiqMWKrzj0D2TzJNWzzHtyuSLO7/68u4AbQn8eb2UwqSoZd2dRkTgWpr3Z2V9/4cHhRDV WCmu8DVvZjtJESAMl+XTQPnpKn58oDlSpvOJbQQTA8KOSOou/Nci/P0W1rEVlYh0NojG6VCbAeBMrn rEVYhXf5v38RvldzmZdcHqvf8H1heVEsdF+y1ZbqUcAH22EtmZCnLmlHAi+20tUoXkU8VbgWEqvPJl Pah1xcPhbEcI1rbQunpPk4m/1qmImy9fuVUAyNvYMscpMdVdH4K0gKVYpQHZYsisa3jMvAsFcOOs2J iA/kdCWGFCI/JDzzU5cB8un6NJx/gQNXyzGdb41MWlUlEuoGJaqd6aYCuJPRtQbEQLLk/LJH0ABw65 j/jpppipk5fv9Ey1Hx63Ukkoh4P5ebCD0Gd8fn28BxsX/cCzBQE9z93YBRng== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit The compiler is not able to automatically perform bounds checking on structures that end in flexible arrays: __builtin_object_size() is compile-time only. Any possible run-time checks are currently short-circuited because there isn't an obvious common way to figure out the bounds of such a structure. C has no way (yet[1]) to signify which struct member holds the number of allocated flexible array elements (like exists in other languages). As a result, the kernel (and C projects generally) need to manually check the bounds, check the element size calculations, and perform sanity checking on all the associated variable types in between (e.g. 260 cannot be stored in a u8). This is extremely fragile. However, even if we could do all this through a magic memcpy(), the API itself doesn't provide meaningful feedback, which forces the kernel into an "all or nothing" approach: either do the copy or panic the system. Any failure conditions should be _detectable_, with API users able to gracefully recover. To deal with these needs, create a set of helper functions that do the work of memcpy() but perform the needed bounds checking based on the arguments given: flex_cpy(). The common pattern of "allocate and copy" is also included: flex_dup(). However, one of the most common patterns is deserialization: allocating and populating flexible array members from a byte array: mem_to_flex_dup(). And if the elements are already allocated: mem_to_flex(). The concept of a "flexible array structure" is introduced, which is a struct that has both a trailing flexible array member _and_ an element count member. If a struct lacks the element count member, it's just a blob: there are no bounds associated with it. The most common style of flexible array struct in the kernel is a "normal" one, where both the flex-array and element-count are present: struct flex_array_struct_example { ... /* arbitrary members */ u16 part_count; /* count of elements stored in "parts" below. */ ... /* arbitrary members */ u32 parts[]; /* flexible array with elements of type u32. */ }; Next are "encapsulating flexible array structs", which is just a struct that contains a flexible array struct as its final member: struct encapsulating_example { ... /* arbitrary members */ struct flex_array_struct_example fas; }; There are also "split" flex array structs, which have the element-count member in a separate struct level than the flex-array member: struct split_example { ... /* arbitrary members */ u16 part_count; /* count of elements stored in "parts" below. */ ... /* arbitrary members */ struct blob_example { ... /* other blob members */ u32 parts[];/* flexible array with elements of type u32. */ } blob; }; To have the helpers deal with these arbitrary layouts, the names of the flex-array and element-count members need to be specified with each use (since C lacks the array-with-length syntax[1] so the compiler cannot automatically determine them). However, for the "normal" (most common) case, we can get close to "automatic" by explicitly declaring common member aliases "__flex_array_elements", and "__flex_array_elements_count" respectively. The regular helpers use these members, but extended helpers exist to cover the other two code patterns. For example, using the most complicated helper, mem_to_flex_dup(): /* Flexible array struct with members identified. */ struct something { int mode; DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, how_many); unsigned long flags; DECLARE_FLEX_ARRAY_ELEMENTS(u32, value); }; ... struct something *instance = NULL; int rc; rc = mem_to_flex_dup(&instance, byte_array, count, GFP_KERNEL); if (rc) return rc; This will: - validate "instance" is non-NULL (no NULL dereference). - validate "*instance" is NULL (no memory allocation resource leak). - validate that "count" is: - non-negative (no arithmetic underflow). - has a value that can be stored in the "how_many" type (no value truncation). - calculate the bytes needed to store "count"-many trailing u32 elements (no arithmetic overflow/underflow). - calculate the bytes needed for a "struct something" with the above trailing elements (no arithmetic overflow/underflow). - allocate the memory and check the result (no NULL dereference). - initialize the non-flex-array portion of the struct to zero (no uninitialized memory usage). - copy from "buf" into the flexible array elements. If anything goes wrong, it returns a negative errno. With these helpers the kernel can move away from many of the open-coded patterns of using memcpy() with a dynamically-sized destination buffer. [1] https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1990.htm Cc: "Gustavo A. R. Silva" Cc: Keith Packard Cc: Francis Laniel Cc: Daniel Axtens Cc: Dan Williams Cc: Vincenzo Frascino Cc: Guenter Roeck Cc: Daniel Vetter Cc: Tadeusz Struk Signed-off-by: Kees Cook --- include/linux/flex_array.h | 637 ++++++++++++++++++++++++++++++++++++ include/linux/string.h | 1 + include/uapi/linux/stddef.h | 14 + 3 files changed, 652 insertions(+) create mode 100644 include/linux/flex_array.h diff --git a/include/linux/flex_array.h b/include/linux/flex_array.h new file mode 100644 index 000000000000..b2cf219f7b56 --- /dev/null +++ b/include/linux/flex_array.h @@ -0,0 +1,637 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_FLEX_ARRAY_H_ +#define _LINUX_FLEX_ARRAY_H_ + +#include +/* + * A "flexible array structure" is a struct which ends with a flexible + * array _and_ contains a member that represents how many array elements + * are present in the flexible array structure: + * + * struct flex_array_struct_example { + * ... // arbitrary members + * u16 part_count; // count of elements stored in "parts" below. + * .. // arbitrary members + * u32 parts[]; // flexible array with elements of type u32. + * }; + * + * Without the "count of elements" member, a structure ending with a + * flexible array has no way to check its own size, and should be + * considered just a blob of memory that is length-checked through some + * other means. Kernel structures with flexible arrays should strive to + * always be true flexible array structures so that they can be operated + * on with the flex*()-family of helpers defined below. + * + * An "encapsulating flexible array structure" is a structure that contains + * a full "flexible array structure" as its final struct member. These are + * used frequently when needing to pass around a copy of a flexible array + * structure, and track other things about the data outside of the scope of + * the flexible array structure itself: + * + * struct encapsulating_example { + * ... // other members + * struct flex_array_struct_example fas; + * }; + * + * For bounds checking operations on a flexible array structure, member + * aliases must be created so the helpers can always locate the associated + * members. Marking up the examples above would look like this: + * + * struct flex_array_struct_example { + * ... // arbitrary members + * // count of elements stored in "parts" below. + * DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u16, part_count); + * .. // arbitrary members + * // flexible array with elements of type u32. + * DECLARE_FLEX_ARRAY_ELEMENTS(u32, parts); + * }; + * + * The above creates the aliases for part_count as __flex_array_elements_count + * and parts as __flex_array_elements. + * + * For encapsulated flexible array structs, there are alternative helpers + * below where the flexible array struct member name can be explicitly + * included as an argument. (See the @dot_fas_member arguments below.) + * + * + * Examples: + * + * Using mem_to_flex(): + * + * struct single { + * u32 flags; + * u32 count; + * u8 data[]; + * }; + * struct single *ptr_single; + * + * struct encap { + * u16 info; + * struct single single; + * }; + * struct encap *ptr_encap; + * + * struct blob { + * u32 flags; + * u8 data[]; + * }; + * + * struct split { + * u32 count; + * struct blob blob; + * }; + * struct split *ptr_split; + * + * mem_to_flex(ptr_one, src, count); + * __mem_to_flex(ptr_encap, single.data, single.count, src, count); + * __mem_to_flex(ptr_split, count, blob.data, src, count); + * + */ + +/* These are wrappers around the UAPI macros. */ +#define DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(TYPE, NAME) \ + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(TYPE, NAME) + +#define DECLARE_FLEX_ARRAY_ELEMENTS(TYPE, NAME) \ + __DECLARE_FLEX_ARRAY_ELEMENTS(TYPE, NAME) + +/* All the helpers return negative on failure, as must be checked. */ +static inline int __must_check __must_check_errno(int err) +{ + return err; +} + +/** + * __fas_elements_bytes - Calculate potential size of the flexible + * array elements of a given flexible array + * structure. + * + * @p: Pointer to flexible array structure. + * @flex_member: Member name of the flexible array elements. + * @count_member: Member name of the flexible array elements count. + * @elements_count: Count of proposed number of @p->__flex_array_elements + * @bytes: Pointer to variable to write calculation of total size in bytes. + * + * Returns: 0 on successful calculation, -ve on error. + * + * This performs the same calculation as flex_array_size(), except + * that the result is bounds checked and written to @bytes instead + * of being returned. + */ +#define __fas_elements_bytes(p, flex_member, count_member, \ + elements_count, bytes) \ +__must_check_errno(({ \ + int __feb_err = -EINVAL; \ + size_t __feb_elements_count = (elements_count); \ + size_t __feb_elements_max = \ + type_max(typeof((p)->count_member)); \ + if (__feb_elements_count > __feb_elements_max || \ + check_mul_overflow(sizeof(*(p)->flex_member), \ + __feb_elements_count, bytes)) { \ + *(bytes) = 0; \ + __feb_err = -E2BIG; \ + } else { \ + __feb_err = 0; \ + } \ + __feb_err; \ +})) + +/** + * fas_elements_bytes - Calculate current size of the flexible array + * elements of a given flexible array structure. + * + * @p: Pointer to flexible array structure. + * @bytes: Pointer to variable to write calculation of total size in bytes. + * + * Returns: 0 on successful calculation, -ve on error. + * + * This performs the same calculation as flex_array_size(), except + * that the result is bounds checked and written to @bytes instead + * of being returned. + */ +#define fas_elements_bytes(p, bytes) \ + __fas_elements_bytes(p, __flex_array_elements, \ + __flex_array_elements_count, \ + (p)->__flex_array_elements_count, bytes) + +/** __fas_bytes - Calculate potential size of flexible array structure + * + * @p: Pointer to flexible array structure. + * @flex_member: Member name of the flexible array elements. + * @count_member: Member name of the flexible array elements count. + * @elements_count: Count of proposed number of @p->__flex_array_elements + * @bytes: Pointer to variable to write calculation of total size in bytes. + * + * Returns: 0 on successful calculation, -ve on error. + * + * This performs the same calculation as struct_size(), except + * that the result is bounds checked and written to @bytes instead + * of being returned. + */ +#define __fas_bytes(p, flex_member, count_member, elements_count, bytes)\ +__must_check_errno(({ \ + int __fasb_err; \ + typeof(*bytes) __fasb_bytes; \ + \ + if (__fas_elements_bytes(p, flex_member, count_member, \ + elements_count, &__fasb_bytes) || \ + check_add_overflow(sizeof(*(p)), __fasb_bytes, bytes)) { \ + *(bytes) = 0; \ + __fasb_err = -E2BIG; \ + } else { \ + __fasb_err = 0; \ + } \ + __fasb_err; \ +})) + +/** fas_bytes - Calculate current size of flexible array structure + * + * @p: Pointer to flexible array structure. + * @bytes: Pointer to variable to write calculation of total size in bytes. + * + * This performs the same calculation as struct_size(), except + * that the result is bounds checked and written to @bytes instead + * of being returned, using the current size of the flexible array + * structure (via @p->__flexible_array_elements_count). + * + * Returns: 0 on successful calculation, -ve on error. + */ +#define fas_bytes(p, bytes) \ + __fas_bytes(p, __flex_array_elements, \ + __flex_array_elements_count, \ + (p)->__flex_array_elements_count, bytes) + +/** flex_cpy - Copy from one flexible array struct into another with count conversion + * + * @dst: Destination pointer + * @src: Source pointer + * + * The full structure of @src will be copied to @dst, including all trailing + * flexible array elements. @dst->__flex_array_elements_count must be large + * enough to hold @src->__flex_array_elements_count. Any elements left over + * in @dst will be zero-wiped. + * + * Returns: 0 on successful calculation, -ve on error. + */ +#define flex_cpy(dst, src) __must_check_errno(({ \ + int __fc_err = -EINVAL; \ + typeof(*(dst)) *__fc_dst = (dst); \ + typeof(*(src)) *__fc_src = (src); \ + size_t __fc_dst_bytes, __fc_src_bytes; \ + \ + BUILD_BUG_ON(!__same_type(*(__fc_dst), *(__fc_src))); \ + \ + do { \ + if (fas_bytes(__fc_dst, &__fc_dst_bytes) || \ + fas_bytes(__fc_src, &__fc_src_bytes) || \ + __fc_dst_bytes < __fc_src_bytes) { \ + /* do we need to wipe dst here? */ \ + __fc_err = -E2BIG; \ + break; \ + } \ + __builtin_memcpy(__fc_dst, __fc_src, __fc_src_bytes); \ + /* __flex_array_elements_count is included in memcpy */ \ + /* Wipe any now-unused trailing elements in @dst: */ \ + __builtin_memset((u8 *)__fc_dst + __fc_src_bytes, 0, \ + __fc_dst_bytes - __fc_src_bytes); \ + __fc_err = 0; \ + } while (0); \ + __fc_err; \ +})) + +/** __flex_dup - Allocate and copy an arbitrarily encapsulated flexible + * array struct + * + * @alloc: Pointer to Pointer to hold to-be-allocated (optionally + * encapsulating) flexible array struct. + * @dot_fas_member: For encapsulating flexible arrays, the name of the + * flexible array struct member preceded with a literal + * dot (e.g. .foo.bar.flex_array_struct_name). For a + * regular flexible array struct, this macro arument is + * empty. + * @src: Pointer to source flexible array struct. + * @gfp: GFP allocation flags + * + * This copies the contents of one flexible array struct into another. + * The (**@alloc)@dot_fas_member and @src arguments must resolve to the + * same type. Everything prior to @dot_fas_member in *@alloc will be + * initialized to zero. + * + * Failure modes: + * - @alloc is NULL. + * - *@alloc is not NULL (something was already allocated). + * - Required allocation size is larger than size_t can hold. + * - No available memory to allocate @alloc. + * + * Returns: 0 on success, -ve on failure. + */ +#define __flex_dup(alloc, dot_fas_member, src, gfp) \ +__must_check_errno(({ \ + int __fd_err = -EINVAL; \ + typeof(*(src)) *__fd_src = (src); \ + typeof(**(alloc)) *__fd_alloc; \ + typeof((*__fd_alloc)dot_fas_member) *__fd_dst; \ + size_t __fd_alloc_bytes, __fd_copy_bytes; \ + \ + BUILD_BUG_ON(!__same_type(*(__fd_dst), *(__fd_src))); \ + \ + do { \ + if ((uintptr_t)(alloc) < 1 || *(alloc)) { \ + __fd_err = -EINVAL; \ + break; \ + } \ + if (fas_bytes(__fd_src, &__fd_copy_bytes) || \ + check_add_overflow(__fd_copy_bytes, \ + sizeof(*__fd_alloc) - \ + sizeof(*__fd_dst), \ + &__fd_alloc_bytes)) { \ + __fd_err = -E2BIG; \ + break; \ + } \ + __fd_alloc = kmalloc(__fd_alloc_bytes, gfp); \ + if (!__fd_alloc) { \ + __fd_err = -ENOMEM; \ + break; \ + } \ + __fd_dst = &((*__fd_alloc)dot_fas_member); \ + /* Optimize away any unneeded memset. */ \ + if (sizeof(*__fd_alloc) != sizeof(*__fd_dst)) \ + __builtin_memset(__fd_alloc, 0, \ + __fd_alloc_bytes - \ + __fd_copy_bytes); \ + __builtin_memcpy(__fd_dst, src, __fd_copy_bytes); \ + /* __flex_array_elements_count is included in memcpy */ \ + *(alloc) = __fd_alloc; \ + __fd_err = 0; \ + } while (0); \ + __fd_err; \ +})) + +/** flex_dup - Allocate and copy a flexible array struct + * + * @alloc: Pointer to Pointer to hold to-be-allocated flexible array struct. + * @src: Pointer to source flexible array struct. + * @gfp: GFP allocation flags + * + * This copies the contents of one flexible array struct into another. + * The *@alloc and @src arguments must resolve to the same type. + * + * Failure modes: + * - @alloc is NULL. + * - *@alloc is not NULL (something was already allocated). + * - Required allocation size is larger than size_t can hold. + * - No available memory to allocate @alloc. + * + * Returns: 0 on success, -ve on failure. + */ +#define flex_dup(alloc, src, gfp) \ + __flex_dup(alloc, /* alloc itself */, src, gfp) + +/** __mem_to_flex - Copy from memory buffer into a flexible array structure's + * flexible array elements. + * + * @ptr: Pointer to already allocated flexible array struct. + * @flex_member: Member name of the flexible array elements. + * @count_member: Member name of the flexible array elements count. + * @src: Source memory pointer. + * @elements_count: Number of @ptr's flexible array elements to copy from + * @src into @ptr. + * + * Copies @elements_count-many elements from memory buffer at @src into + * @ptr->@flex_member, wipes any remaining elements, and updates + * @ptr->@count_member. + * + * This is essentially a simple deserializer. + * + * TODO: It would be nice to automatically discover the max bounds of @src + * besides @elements_count. There is currently no universal way to ask + * "what is the size of a given pointer's allocation?" So for + * now just use __builtin_object_size(@src, 1) to validate known + * compile-time too-large conditions. Perhaps in the future if + * __mtf_copy_bytes above is > PAGE_SIZE, perform a dynamic lookup + * using something similar to __check_heap_object(). + * + * Failure conditions: + * - The value of @elements_count cannot fit in the @ptr's @count_member + * type (e.g. 260 in a u8). + * - @ptr's @count_member value is smaller than @elements_count (e.g. not + * enough space was previously allocated). + * - @elements_count yields a byte count greater than: + * - INT_MAX (as a simple "too big" sanity check) + * - the compile-time size of @src (when it can be determined) + * + * Returns: 0 on success, -ve on error. + */ +#define __mem_to_flex(ptr, flex_member, count_member, src, \ + elements_count) \ +__must_check_errno(({ \ + int __mtf_err = -EINVAL; \ + typeof(*(ptr)) *__mtf_ptr = (ptr); \ + typeof(elements_count) __mtf_src_count = (elements_count); \ + size_t __mtf_copy_bytes, __mtf_dst_bytes; \ + u8 *__mtf_dst = (u8 *)__mtf_ptr->flex_member; \ + \ + do { \ + if (is_negative(__mtf_src_count) || \ + __fas_elements_bytes(__mtf_ptr, flex_member, \ + count_member, \ + __mtf_src_count, \ + &__mtf_copy_bytes) || \ + __mtf_copy_bytes > INT_MAX || \ + __mtf_copy_bytes > __builtin_object_size(src, 1) || \ + __fas_elements_bytes(__mtf_ptr, flex_member, \ + count_member, \ + __mtf_ptr->count_member, \ + &__mtf_dst_bytes) || \ + __mtf_dst_bytes < __mtf_copy_bytes) { \ + __mtf_err = -E2BIG; \ + break; \ + } \ + __builtin_memcpy(__mtf_dst, src, __mtf_copy_bytes); \ + /* Wipe any now-unused trailing elements in @dst: */ \ + __builtin_memset(__mtf_dst + __mtf_dst_bytes, 0, \ + __mtf_dst_bytes - __mtf_copy_bytes); \ + /* Make sure in-struct count of elements is updated: */ \ + __mtf_ptr->count_member = __mtf_src_count; \ + __mtf_err = 0; \ + } while (0); \ + __mtf_err; \ +})) + +#define mem_to_flex(ptr, src, elements_count) \ + __mem_to_flex(ptr, __flex_array_elements, \ + __flex_array_elements_count, src, elements_count) + +/** __mem_to_flex_dup - Allocate a flexible array structure and copy into + * its flexible array elements from a memory buffer. + * + * @alloc: Pointer to pointer to hold allocation for flexible array struct. + * @dot_fas_member: For encapsulating flexible array structs, the name of + * the flexible array struct member preceded with a + * literal dot (e.g. .foo.bar.flex_array_struct_name). + * For a regular flexible array struct, this macro arument + * is empty. + * @src: Source memory buffer pointer. + * @elements_count: Number of @alloc's flexible array elements to copy from + * @src into @ptr. + * @gfp: GFP allocation flags + * + * This behaves like mem_to_flex(), but allocates the needed space for + * a new flexible array struct and its trailing elements. + * + * This is essentially a simple allocating deserializer. + * + * TODO: It would be nice to automatically discover the max bounds of @src + * besides @elements_count. There is currently no universal way to ask + * "what is the size of a given pointer's allocation?" So for now just + * use __builtin_object_size(@src, 1) to validate known compile-time + * too-large conditions. Perhaps in the future if __mtfd_copy_bytes + * above is > PAGE_SIZE, perform a dynamic lookup using something + * similar to __check_heap_object(). + * + * Failure conditions: + * - @alloc is NULL. + * - *@alloc is not NULL (something was already allocated). + * - The value of @elements_count cannot fit in the @alloc's + * __flex_array_elements_count member type (e.g. 260 in u8). + * - @elements_count yields a byte count greater than: + * - INT_MAX (as a simple "too big" sanity check) + * - the compile-time size of @src (when it can be determined) + * - @alloc could not be allocated. + * + * Returns: 0 on success, -ve on error. + */ +#define __mem_to_flex_dup(alloc, dot_fas_member, src, elements_count, \ + gfp) \ +__must_check_errno(({ \ + int __mtfd_err = -EINVAL; \ + typeof(elements_count) __mtfd_src_count = (elements_count); \ + typeof(**(alloc)) *__mtfd_alloc; \ + typeof((*__mtfd_alloc)dot_fas_member) *__mtfd_fas; \ + u8 *__mtfd_dst; \ + size_t __mtfd_alloc_bytes, __mtfd_copy_bytes; \ + \ + do { \ + if ((uintptr_t)(alloc) < 1 || *(alloc)) { \ + __mtfd_err = -EINVAL; \ + break; \ + } \ + if (is_negative(__mtfd_src_count) || \ + __fas_elements_bytes(__mtfd_fas, \ + __flex_array_elements, \ + __flex_array_elements_count, \ + __mtfd_src_count, \ + &__mtfd_copy_bytes) || \ + __mtfd_copy_bytes > INT_MAX || \ + __mtfd_copy_bytes > __builtin_object_size(src, 1) ||\ + check_add_overflow(sizeof(*__mtfd_alloc), \ + __mtfd_copy_bytes, \ + &__mtfd_alloc_bytes)) { \ + __mtfd_err = -E2BIG; \ + break; \ + } \ + __mtfd_alloc = kmalloc(__mtfd_alloc_bytes, gfp); \ + if (!__mtfd_alloc) { \ + __mtfd_err = -ENOMEM; \ + break; \ + } \ + __mtfd_fas = &((*__mtfd_alloc)dot_fas_member); \ + __mtfd_dst = (u8 *)__mtfd_fas->__flex_array_elements; \ + __builtin_memset(__mtfd_alloc, 0, __mtfd_alloc_bytes - \ + __mtfd_copy_bytes); \ + __builtin_memcpy(__mtfd_dst, src, __mtfd_copy_bytes); \ + /* Make sure in-struct count of elements is updated: */ \ + __mtfd_fas->__flex_array_elements_count = \ + __mtfd_src_count; \ + *(alloc) = __mtfd_alloc; \ + __mtfd_err = 0; \ + } while (0); \ + __mtfd_err; \ +})) + +/** mem_to_flex_dup - Allocate a flexible array structure and copy + * into it from a memory buffer. + * + * @alloc: Pointer to pointer to hold allocation for flexible array struct. + * @src: Source memory pointer. + * @elements_count: Number of @alloc's flexible array elements to copy from + * @src into @alloc. + * @gfp: GFP allocation flags + * + * This behaves like mem_to_flex(), but allocates the needed space for + * a new flexible array struct and its trailing elements. + * + * This is essentially a simple allocating deserializer. + * + * TODO: It would be nice to automatically discover the max bounds of @src + * besides @elements_count. There is currently no universal way to ask + * "what is the size of a given pointer's allocation?" So for + * now just use __builtin_object_size(@src, 1) to validate known + * compile-time too-large conditions. Perhaps in the future if + * __mtf_copy_bytes above is > PAGE_SIZE, perform a dynamic lookup + * using something similar to __check_heap_object(). + * + * Failure conditions: + * - @alloc is NULL. + * - *@alloc is not NULL (something was already allocated). + * - The value of @elements_count cannot fit in the @alloc's + * __flex_array_elements_count member type (e.g. 260 in u8). + * - @elements_count yields a byte count greater than: + * - INT_MAX (as a simple "too big" sanity check) + * - the compile-time size of @src (when it can be determined) + * - @alloc could not be allocated. + * + * Returns: 0 on success, -ve on error. + */ +#define mem_to_flex_dup(alloc, src, elements_count, gfp) \ + __mem_to_flex_dup(alloc, /* alloc itself */, src, elements_count, gfp) + +/** flex_to_mem - Copy all flexible array structure elements into memory + * buffer. + * + * @dst: Destination buffer pointer. + * @bytes_available: How many bytes are available in @dst. + * @ptr: Pointer to allocated flexible array struct. + * @bytes_written: Pointer to variable to store how many bytes were written + * (may be NULL). + * + * Copies all of @ptr's flexible array elements into @dst. + * + * This is essentially a simple serializer. + * + * Failure conditions: + * - @bytes_available in @dst is any of: + * - negative. + * - larger than INT_MAX. + * - not large enough to hold the resulting copy. + * - @bytes_written's type cannot hold the size of the copy (e.g. 260 in u8). + * + * Return: 0 on success, -ve on failure. + * + */ +#define flex_to_mem(dst, bytes_available, ptr, bytes_written) \ +__must_check_errno(({ \ + int __ftm_err = -EINVAL; \ + typeof(*(ptr)) *__ftm_ptr = (ptr); \ + u8 *__ftm_src = (u8 *)__ftm_ptr->__flex_array_elements; \ + typeof(*(bytes_written)) *__ftm_written = (bytes_written); \ + size_t __ftm_written_max = type_max(typeof(*__ftm_written)); \ + typeof(bytes_available) __ftm_dst_bytes = (bytes_available); \ + size_t __ftm_copy_bytes; \ + \ + do { \ + if (is_negative(__ftm_dst_bytes) || \ + __ftm_dst_bytes > INT_MAX || \ + fas_elements_bytes(__ftm_ptr, &__ftm_copy_bytes) || \ + __ftm_dst_bytes < __ftm_copy_bytes || \ + (!__same_type(typeof(bytes_written), NULL) && \ + __ftm_copy_bytes > __ftm_written_max)) { \ + __ftm_err = -E2BIG; \ + break; \ + } \ + __builtin_memcpy(dst, __ftm_src, __ftm_copy_bytes); \ + if (__ftm_written) \ + *__ftm_written = __ftm_copy_bytes; \ + __ftm_err = 0; \ + } while (0); \ + __ftm_err; \ +})) + +/** flex_to_mem_dup - Copy entire flexible array structure into newly + * allocated memory buffer. + * + * @alloc: Pointer to pointer to newly allocated memory region to hold contents + * of the copy. + * @alloc_size: Pointer to variable to hold the size of the allocated memory. + * @ptr: Pointer to allocated flexible array struct. + * @gfp: GFP allocation flags + * + * Allocates @alloc and copies all of @ptr's flexible array elements. + * + * This is essentially a simple allocating serializer. + * + * Failure conditions: + * - @alloc is NULL. + * - *@alloc is not NULL (something was already allocated). + * - @alloc_size is NULL. + * - @alloc_size's type cannot hold the size of the copy (e.g. 260 in u8). + * - @alloc could not be allocated. + * + * Return: 0 on success, -ve on failure. + */ +#define flex_to_mem_dup(alloc, alloc_size, ptr, gfp) \ +__must_check_errno(({ \ + int __ftmd_err = -EINVAL; \ + typeof(**(alloc)) *__ftmd_alloc; \ + typeof(*(alloc_size)) *__ftmd_alloc_size = (alloc_size); \ + typeof(*(ptr)) *__ftmd_ptr = (ptr); \ + u8 *__ftmd_src = (u8 *)__ftmd_ptr->__flex_array_elements; \ + size_t __ftmd_alloc_max = type_max(typeof(*__ftmd_alloc_size)); \ + size_t __ftmd_copy_bytes; \ + \ + do { \ + if ((uintptr_t)(alloc) < 1 || *(alloc) || \ + (uintptr_t)(alloc_size) < 1) { \ + __ftmd_err = -EINVAL; \ + break; \ + } \ + if (fas_elements_bytes(__ftmd_ptr, \ + &__ftmd_copy_bytes) || \ + __ftmd_copy_bytes > __ftmd_alloc_max) { \ + __ftmd_err = -E2BIG; \ + break; \ + } \ + __ftmd_alloc = kmemdup(__ftmd_src, __ftmd_copy_bytes, \ + gfp); \ + if (!__ftmd_alloc) { \ + __ftmd_err = -ENOMEM; \ + break; \ + } \ + *__ftmd_alloc_size = __ftmd_copy_bytes; \ + *(alloc) = __ftmd_alloc; \ + __ftmd_err = 0; \ + } while (0); \ + __ftmd_err; \ +})) + +#endif /* _LINUX_FLEX_ARRAY_H_ */ diff --git a/include/linux/string.h b/include/linux/string.h index b6572aeca2f5..c01b76f73e99 100644 --- a/include/linux/string.h +++ b/include/linux/string.h @@ -252,6 +252,7 @@ static inline const char *kbasename(const char *path) #if !defined(__NO_FORTIFY) && defined(__OPTIMIZE__) && defined(CONFIG_FORTIFY_SOURCE) #include #endif +#include void memcpy_and_pad(void *dest, size_t dest_len, const void *src, size_t count, int pad); diff --git a/include/uapi/linux/stddef.h b/include/uapi/linux/stddef.h index 7837ba4fe728..04870274f33b 100644 --- a/include/uapi/linux/stddef.h +++ b/include/uapi/linux/stddef.h @@ -44,4 +44,18 @@ struct { } __empty_ ## NAME; \ TYPE NAME[]; \ } + +/* For use with flexible array structure helpers, in */ +#define __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(TYPE, NAME) \ + union { \ + TYPE __flex_array_elements_count; \ + TYPE NAME; \ + } + +#define __DECLARE_FLEX_ARRAY_ELEMENTS(TYPE, NAME) \ + union { \ + __DECLARE_FLEX_ARRAY(TYPE, __flex_array_elements); \ + __DECLARE_FLEX_ARRAY(TYPE, NAME); \ + } + #endif -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320018.540610 (Exim 4.92) (envelope-from ) id 1nm7N4-0005px-6T; Wed, 04 May 2022 05:16:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320018.540610; Wed, 04 May 2022 05:16:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N4-0005og-0R; Wed, 04 May 2022 05:16:18 +0000 Received: by outflank-mailman (input) for mailman id 320018; Wed, 04 May 2022 01:47:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm478-0007U4-7A for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:38 +0000 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [2607:f8b0:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c94b62b-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:36 +0200 (CEST) Received: by mail-pf1-x42e.google.com with SMTP id a11so21695pff.1 for ; Tue, 03 May 2022 18:47:36 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r12-20020a170903020c00b0015e8d4eb27dsm438909plh.199.2022.05.03.18.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c94b62b-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=50F1hUbWFLfT5ENWUNJYEA3u7uQsl+qxaqqCeMwZnyU=; b=XJCNLp6T2hlq16vnGlmWmig5+GsVMxNRRvIbEOnN6HSW8yTRmnmgFn0bdfSDK1+nc+ /lIeg89b2qTVpmYFiDm9nYt9X28PYd7TpfNNYgxckwT1LfN0EOUF0w4hbizFZn5WO8zm t78WDusU+YL8An+v944Dg9g9tejsxP74BYxPU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=50F1hUbWFLfT5ENWUNJYEA3u7uQsl+qxaqqCeMwZnyU=; b=29zhVAAsOCm8qEcSFehjvdYZuHXNkxBcTpJoa9iLECxSBK4iopks0e9cQL3LtcyZ+Q KwYaV0woMFy4ME8JRYR476h+JgjpP+Mi3FYb1U6VCdUdSttejiat1yL4lO/6JDiz78/O MHKEflW7mr0Dc6EPwusrppnvHaGITTZTPcm+mY45L/ORoDUy9wPC4PesSNh17qGjIK4v ZM2ntAcZ/wdr2lf7sgYwVbucxnJyR2gfOjvInJtQOLhvkm2n/S8CJXfw4HF5ZcLLwtCq OxHGCTGXKO0lTSdk6mQRrJQz5BE6OfvixjD2snW3+NwZNZ93oVzCL4uIdnnsV1uQbypu 0Ulw== X-Gm-Message-State: AOAM5339Fu1kgph/nJDugmYJZnua/1AfeCIa8M4xVbPCFAYsV/On+qIE mm4+KislOROppD0Kdy/plLE1GA== X-Google-Smtp-Source: ABdhPJx5lkCCHxBXyDGf524YVNuXMSDkRx2jqeSfgP68bF0unQnk9Z/wgy4uMEksLglsYmioBepIKA== X-Received: by 2002:a65:6d15:0:b0:382:4e6d:dd0d with SMTP id bf21-20020a656d15000000b003824e6ddd0dmr15813794pgb.333.1651628855971; Tue, 03 May 2022 18:47:35 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , David Gow , kunit-dev@googlegroups.com, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 03/32] flex_array: Add Kunit tests Date: Tue, 3 May 2022 18:44:12 -0700 Message-Id: <20220504014440.3697851-4-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=19765; h=from:subject; bh=GG9nmr532r4pl7tVh2IFzW2uuFJ/hvJpUQj5i4N5B0I=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqB7/551GkKwZcI+OcZghRu66mEP7FMOhfFmE5a 67h/Z0iJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagQAKCRCJcvTf3G3AJtfAEA CqSqFekHoLTEwm5Qyt0UbimHFpi/b/6zyOUB2KND396l+syWQ1mJIbLGjTios1NH/eIxHjGEKJ1syg U7L/zPIs4XJhvSt5mtK7HHfsD2jlgvLX3UL7IgUlEzTG1onpa1dDWN1UtoN81ahy1fct7CMGoD/1ll 3ngnIysZAbkbazroo7sUYB/JX8DX8bsjNn97JBfq+F0NovBSkT6UKeW29aHUk5FoZhWo+bijLKKQBA JrEW47fYiaZ04M3TcLGaKkKLllkiajq0N/9TLMbmHrUZphVEZCSiD9eikb/Kpr28WXz4NX00Fu4CGe kq7UO4JP9HeF1pCMUg3iVoEHddmrfhdENHsLrAQzNrTdnkG+Jt7b+DxWscqIxexQR8D0GFXA1TavBy c52biYoOXViqwEmvm12u6MNQYxMVN2/v5fbzbwkcdy4DlhOuLC0Wu4AmEcPHG6wFuSX5NdbPBBeIzQ 911ljxSY+UGfg0USsjIzhH6oqejgpYUmqqLAV0WoW7O8aSmtqBCOORogwfI680pWARJhsTuTVbZ5G4 KsZcDi9opJFLcoYlb9wuFYeQrydBbShjiVXqT/tU0kK4PWWlEc85sOiKq7Bd8cuiixIgJW5Zlc+4n+ 1sgKfTbiJo/zVmyCeEmrKxLCEoinmDvnxEdOeXRWpeTslL+4jMSgSaBMHUCw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit Add tests for the new flexible array structure helpers. These can be run with: make ARCH=um mrproper ./tools/testing/kunit/kunit.py config ./tools/testing/kunit/kunit.py run flex_array Cc: David Gow Cc: kunit-dev@googlegroups.com Signed-off-by: Kees Cook --- lib/Kconfig.debug | 12 +- lib/Makefile | 1 + lib/flex_array_kunit.c | 523 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 531 insertions(+), 5 deletions(-) create mode 100644 lib/flex_array_kunit.c diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9077bb38bc93..8bae6b169c50 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2551,11 +2551,6 @@ config OVERFLOW_KUNIT_TEST Builds unit tests for the check_*_overflow(), size_*(), allocation, and related functions. - For more information on KUnit and unit tests in general please refer - to the KUnit documentation in Documentation/dev-tools/kunit/. - - If unsure, say N. - config STACKINIT_KUNIT_TEST tristate "Test level of stack variable initialization" if !KUNIT_ALL_TESTS depends on KUNIT @@ -2567,6 +2562,13 @@ config STACKINIT_KUNIT_TEST CONFIG_GCC_PLUGIN_STRUCTLEAK, CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF, or CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL. +config FLEX_ARRAY_KUNIT_TEST + tristate "Test flex_*() family of helper functions at runtime" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + Builds unit tests for flexible array copy helper functions. + config TEST_UDELAY tristate "udelay test driver" help diff --git a/lib/Makefile b/lib/Makefile index 6b9ffc1bd1ee..9884318db330 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -366,6 +366,7 @@ obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o CFLAGS_stackinit_kunit.o += $(call cc-disable-warning, switch-unreachable) obj-$(CONFIG_STACKINIT_KUNIT_TEST) += stackinit_kunit.o +obj-$(CONFIG_FLEX_ARRAY_KUNIT_TEST) += flex_array_kunit.o obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o diff --git a/lib/flex_array_kunit.c b/lib/flex_array_kunit.c new file mode 100644 index 000000000000..48bee88945b4 --- /dev/null +++ b/lib/flex_array_kunit.c @@ -0,0 +1,523 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Test cases for flex_*() array manipulation helpers. + */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include + +#define COMPARE_STRUCTS(STRUCT_A, STRUCT_B) do { \ + STRUCT_A *ptr_A; \ + STRUCT_B *ptr_B; \ + int rc; \ + size_t size_A, size_B; \ + \ + /* matching types for flex array elements and count */ \ + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A), sizeof(*ptr_B)); \ + KUNIT_EXPECT_TRUE(test, __same_type(*ptr_A->data, \ + *ptr_B->__flex_array_elements)); \ + KUNIT_EXPECT_TRUE(test, __same_type(ptr_A->datalen, \ + ptr_B->__flex_array_elements_count)); \ + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A->data), \ + sizeof(*ptr_B->__flex_array_elements)); \ + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), data), \ + offsetof(typeof(*ptr_B), \ + __flex_array_elements)); \ + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), datalen), \ + offsetof(typeof(*ptr_B), \ + __flex_array_elements_count)); \ + \ + /* struct_size() vs __fas_bytes() */ \ + size_A = struct_size(ptr_A, data, 13); \ + rc = __fas_bytes(ptr_B, __flex_array_elements, \ + __flex_array_elements_count, 13, &size_B); \ + KUNIT_EXPECT_EQ(test, rc, 0); \ + KUNIT_EXPECT_EQ(test, size_A, size_B); \ + \ + /* flex_array_size() vs __fas_elements_bytes() */ \ + size_A = flex_array_size(ptr_A, data, 13); \ + rc = __fas_elements_bytes(ptr_B, __flex_array_elements, \ + __flex_array_elements_count, 13, &size_B); \ + KUNIT_EXPECT_EQ(test, rc, 0); \ + KUNIT_EXPECT_EQ(test, size_A, size_B); \ + \ + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A) + size_A, \ + offsetof(typeof(*ptr_A), data) + \ + (sizeof(*ptr_A->data) * 13)); \ + KUNIT_EXPECT_EQ(test, sizeof(*ptr_B) + size_B, \ + offsetof(typeof(*ptr_B), \ + __flex_array_elements) + \ + (sizeof(*ptr_B->__flex_array_elements) * \ + 13)); \ +} while (0) + +struct normal { + size_t datalen; + u32 data[]; +}; + +struct decl_normal { + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, datalen); + DECLARE_FLEX_ARRAY_ELEMENTS(u32, data); +}; + +struct aligned { + unsigned short datalen; + char data[] __aligned(__alignof__(u64)); +}; + +struct decl_aligned { + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned short, datalen); + DECLARE_FLEX_ARRAY_ELEMENTS(char, data) __aligned(__alignof__(u64)); +}; + +static void struct_test(struct kunit *test) +{ + COMPARE_STRUCTS(struct normal, struct decl_normal); + COMPARE_STRUCTS(struct aligned, struct decl_aligned); +} + +/* Flexible array structure with internal padding. */ +struct flex_cpy_obj { + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, count); + unsigned long empty; + char induce_padding; + /* padding ends up here */ + unsigned long after_padding; + DECLARE_FLEX_ARRAY_ELEMENTS(u32, flex); +}; + +/* Encapsulating flexible array structure. */ +struct flex_dup_obj { + unsigned long flags; + int junk; + struct flex_cpy_obj fas; +}; + +/* Flexible array struct of only bytes. */ +struct tiny_flex { + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, count); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, byte_array); +}; + +#define CHECK_COPY(ptr) do { \ + typeof(*(ptr)) *_cc_dst = (ptr); \ + KUNIT_EXPECT_EQ(test, _cc_dst->induce_padding, 0); \ + memcpy(&padding, &_cc_dst->induce_padding + sizeof(_cc_dst->induce_padding), \ + sizeof(padding)); \ + /* Padding should be zero too. */ \ + KUNIT_EXPECT_EQ(test, padding, 0); \ + KUNIT_EXPECT_EQ(test, src->count, _cc_dst->count); \ + KUNIT_EXPECT_EQ(test, _cc_dst->count, TEST_TARGET); \ + for (i = 0; i < _cc_dst->count - 1; i++) { \ + /* 'A' is 0x41, and here repeated in a u32. */ \ + KUNIT_EXPECT_EQ(test, _cc_dst->flex[i], 0x41414141); \ + } \ + /* Last item should be different. */ \ + KUNIT_EXPECT_EQ(test, _cc_dst->flex[_cc_dst->count - 1], 0x14141414); \ +} while (0) + +/* Test copying from one flexible array struct into another. */ +static void flex_cpy_test(struct kunit *test) +{ +#define TEST_BOUNDS 13 +#define TEST_TARGET 12 +#define TEST_SMALL 10 + struct flex_cpy_obj *src, *dst; + unsigned long padding; + int i, rc; + + /* Prepare open-coded source. */ + src = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); + src->count = TEST_BOUNDS; + memset(src->flex, 'A', flex_array_size(src, flex, TEST_BOUNDS)); + src->flex[src->count - 2] = 0x14141414; + src->flex[src->count - 1] = 0x24242424; + + /* Prepare open-coded destination, alloc only. */ + dst = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); + /* Pre-fill with 0xFE marker. */ + memset(dst, 0xFE, struct_size(src, flex, TEST_BOUNDS)); + /* Pretend we're 1 element smaller. */ + dst->count = TEST_TARGET; + + /* Pretend to match the target destination size. */ + src->count = TEST_TARGET; + + rc = flex_cpy(dst, src); + KUNIT_EXPECT_EQ(test, rc, 0); + CHECK_COPY(dst); + /* Item past last copied item is unchanged from initial memset. */ + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); + + /* Now trip overflow, and verify we didn't clobber beyond end. */ + src->count = TEST_BOUNDS; + rc = flex_cpy(dst, src); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Item past last copied item is unchanged from initial memset. */ + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); + + /* Reset destination contents. */ + memset(dst, 0xFD, struct_size(src, flex, TEST_BOUNDS)); + dst->count = TEST_TARGET; + + /* Copy less than max. */ + src->count = TEST_SMALL; + rc = flex_cpy(dst, src); + KUNIT_EXPECT_EQ(test, rc, 0); + /* Verify count was adjusted. */ + KUNIT_EXPECT_EQ(test, dst->count, TEST_SMALL); + /* Verify element beyond src size was wiped. */ + KUNIT_EXPECT_EQ(test, dst->flex[TEST_SMALL], 0); + /* Verify element beyond original dst size was untouched. */ + KUNIT_EXPECT_EQ(test, dst->flex[TEST_TARGET], 0xFDFDFDFD); + + kfree(dst); + kfree(src); +#undef TEST_BOUNDS +#undef TEST_TARGET +#undef TEST_SMALL +} + +static void flex_dup_test(struct kunit *test) +{ +#define TEST_TARGET 12 + struct flex_cpy_obj *src, *dst = NULL, **null = NULL; + struct flex_dup_obj *encap = NULL; + unsigned long padding; + int i, rc; + + /* Prepare open-coded source. */ + src = kzalloc(struct_size(src, flex, TEST_TARGET), GFP_KERNEL); + src->count = TEST_TARGET; + memset(src->flex, 'A', flex_array_size(src, flex, TEST_TARGET)); + src->flex[src->count - 1] = 0x14141414; + + /* Reject NULL @alloc. */ + rc = flex_dup(null, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + + /* Check good copy. */ + rc = flex_dup(&dst, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_ASSERT_TRUE(test, dst != NULL); + CHECK_COPY(dst); + + /* Reject non-NULL *@alloc. */ + rc = flex_dup(&dst, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + + kfree(dst); + + /* Check good encap copy. */ + rc = __flex_dup(&encap, .fas, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_ASSERT_TRUE(test, dst != NULL); + CHECK_COPY(&encap->fas); + /* Check that items external to "fas" are zero. */ + KUNIT_EXPECT_EQ(test, encap->flags, 0); + KUNIT_EXPECT_EQ(test, encap->junk, 0); + kfree(encap); +#undef MAGIC_WORD +#undef TEST_TARGET +} + +static void mem_to_flex_test(struct kunit *test) +{ +#define TEST_TARGET 9 +#define TEST_MAX U8_MAX +#define MAGIC_WORD 0x03030303 + u8 magic_byte = MAGIC_WORD & 0xff; + struct flex_cpy_obj *dst; + size_t big = (size_t)INT_MAX + 1; + char small[] = "Hello"; + char *src; + u32 src_len; + int rc; + + /* Open coded allocations, 1 larger than actually used. */ + src_len = flex_array_size(dst, flex, TEST_MAX + 1); + src = kzalloc(src_len, GFP_KERNEL); + dst = kzalloc(struct_size(dst, flex, TEST_MAX + 1), GFP_KERNEL); + dst->count = TEST_TARGET; + + /* Fill source. */ + memset(src, magic_byte, src_len); + + /* Short copy is fine. */ + KUNIT_EXPECT_EQ(test, dst->flex[0], 0); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + rc = mem_to_flex(dst, src, 1); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_EXPECT_EQ(test, dst->count, 1); + KUNIT_EXPECT_EQ(test, dst->after_padding, 0); + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + dst->count = TEST_TARGET; + + /* Reject negative elements count. */ + rc = mem_to_flex(dst, small, -1); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure dst is unchanged. */ + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + + /* Reject compile-time read overflow. */ + rc = mem_to_flex(dst, small, 20); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure dst is unchanged. */ + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + + /* Reject giant buffer source. */ + rc = mem_to_flex(dst, small, big); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure dst is unchanged. */ + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + + /* Copy beyond storage size is rejected. */ + dst->count = TEST_MAX; + KUNIT_EXPECT_EQ(test, dst->flex[TEST_MAX - 1], 0); + KUNIT_EXPECT_EQ(test, dst->flex[TEST_MAX], 0); + rc = mem_to_flex(dst, src, TEST_MAX + 1); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure dst is unchanged. */ + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); + + kfree(dst); + kfree(src); +#undef MAGIC_WORD +#undef TEST_MAX +#undef TEST_TARGET +} + +static void mem_to_flex_dup_test(struct kunit *test) +{ +#define ELEMENTS_COUNT 259 +#define MAGIC_WORD 0xABABABAB + u8 magic_byte = MAGIC_WORD & 0xff; + struct flex_dup_obj *obj = NULL; + struct tiny_flex *tiny = NULL, **null = NULL; + size_t src_len, count, big = (size_t)INT_MAX + 1; + char small[] = "Hello"; + u8 *src; + int rc; + + src_len = struct_size(tiny, byte_array, ELEMENTS_COUNT); + src = kzalloc(src_len, GFP_KERNEL); + KUNIT_ASSERT_TRUE(test, src != NULL); + /* Fill with bytes. */ + memset(src, magic_byte, src_len); + KUNIT_EXPECT_EQ(test, src[0], magic_byte); + KUNIT_EXPECT_EQ(test, src[src_len / 2], magic_byte); + KUNIT_EXPECT_EQ(test, src[src_len - 1], magic_byte); + + /* Reject storage exceeding elements_count type. */ + count = ELEMENTS_COUNT; + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + KUNIT_EXPECT_TRUE(test, tiny == NULL); + + /* Reject negative elements count. */ + rc = mem_to_flex_dup(&tiny, src, -1, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + KUNIT_EXPECT_TRUE(test, tiny == NULL); + + /* Reject compile-time read overflow. */ + rc = mem_to_flex_dup(&tiny, small, 20, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + KUNIT_EXPECT_TRUE(test, tiny == NULL); + + /* Reject giant buffer source. */ + rc = mem_to_flex_dup(&tiny, small, big, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + KUNIT_EXPECT_TRUE(test, tiny == NULL); + + /* Reject NULL @alloc. */ + rc = mem_to_flex_dup(null, src, count, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + + /* Allow reasonable count.*/ + count = ELEMENTS_COUNT / 2; + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_ASSERT_TRUE(test, tiny != NULL); + /* Spot check the copy happened. */ + KUNIT_EXPECT_EQ(test, tiny->count, count); + KUNIT_EXPECT_EQ(test, tiny->byte_array[0], magic_byte); + KUNIT_EXPECT_EQ(test, tiny->byte_array[count / 2], magic_byte); + KUNIT_EXPECT_EQ(test, tiny->byte_array[count - 1], magic_byte); + + /* Reject non-NULL *@alloc. */ + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + kfree(tiny); + + /* Works with encapsulation too. */ + count = ELEMENTS_COUNT / 10; + rc = __mem_to_flex_dup(&obj, .fas, src, count, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_ASSERT_TRUE(test, obj != NULL); + /* Spot check the copy happened. */ + KUNIT_EXPECT_EQ(test, obj->fas.count, count); + KUNIT_EXPECT_EQ(test, obj->fas.after_padding, 0); + KUNIT_EXPECT_EQ(test, obj->fas.flex[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, obj->fas.flex[count / 2], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, obj->fas.flex[count - 1], MAGIC_WORD); + /* Check members before flexible array struct are zero. */ + KUNIT_EXPECT_EQ(test, obj->flags, 0); + KUNIT_EXPECT_EQ(test, obj->junk, 0); + kfree(obj); +#undef MAGIC_WORD +#undef ELEMENTS_COUNT +} + +static void flex_to_mem_test(struct kunit *test) +{ +#define ELEMENTS_COUNT 200 +#define MAGIC_WORD 0xF1F2F3F4 + struct flex_cpy_obj *src; + typeof(*src->flex) *cast; + size_t src_len = struct_size(src, flex, ELEMENTS_COUNT); + size_t copy_len = flex_array_size(src, flex, ELEMENTS_COUNT); + int i, rc; + size_t bytes = 0; + u8 too_small; + u8 *dst; + + /* Create a filled flexible array struct. */ + src = kzalloc(src_len, GFP_KERNEL); + KUNIT_ASSERT_TRUE(test, src != NULL); + src->count = ELEMENTS_COUNT; + src->after_padding = 13; + for (i = 0; i < ELEMENTS_COUNT; i++) + src->flex[i] = MAGIC_WORD; + + /* Over-allocate space to do past-src_len checking. */ + dst = kzalloc(src_len * 2, GFP_KERNEL); + KUNIT_ASSERT_TRUE(test, dst != NULL); + cast = (void *)dst; + + /* Fail if dst is too small. */ + rc = flex_to_mem(dst, copy_len - 1, src, &bytes); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure nothing was copied. */ + KUNIT_EXPECT_EQ(test, bytes, 0); + KUNIT_EXPECT_EQ(test, cast[0], 0); + + /* Fail if type too small to hold size of copy. */ + KUNIT_EXPECT_GT(test, copy_len, type_max(typeof(too_small))); + rc = flex_to_mem(dst, copy_len, src, &too_small); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + /* Make sure nothing was copied. */ + KUNIT_EXPECT_EQ(test, bytes, 0); + KUNIT_EXPECT_EQ(test, cast[0], 0); + + /* Check good copy. */ + rc = flex_to_mem(dst, copy_len, src, &bytes); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_EXPECT_EQ(test, bytes, copy_len); + /* Spot check the copy */ + KUNIT_EXPECT_EQ(test, cast[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT / 2], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT - 1], MAGIC_WORD); + /* Make sure nothing was written after last element. */ + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT], 0); + + kfree(dst); + kfree(src); +#undef MAGIC_WORD +#undef ELEMENTS_COUNT +} + +static void flex_to_mem_dup_test(struct kunit *test) +{ +#define ELEMENTS_COUNT 210 +#define MAGIC_WORD 0xF0F1F2F3 + struct flex_dup_obj *obj, **null = NULL; + struct flex_cpy_obj *src; + typeof(*src->flex) *cast; + size_t obj_len = struct_size(obj, fas.flex, ELEMENTS_COUNT); + size_t src_len = struct_size(src, flex, ELEMENTS_COUNT); + size_t copy_len = flex_array_size(src, flex, ELEMENTS_COUNT); + int i, rc; + size_t bytes = 0; + u8 too_small = 0; + u8 *dst = NULL; + + /* Create a filled flexible array struct. */ + obj = kzalloc(obj_len, GFP_KERNEL); + KUNIT_ASSERT_TRUE(test, obj != NULL); + obj->fas.count = ELEMENTS_COUNT; + obj->fas.after_padding = 13; + for (i = 0; i < ELEMENTS_COUNT; i++) + obj->fas.flex[i] = MAGIC_WORD; + src = &obj->fas; + + /* Fail if type too small to hold size of copy. */ + KUNIT_EXPECT_GT(test, src_len, type_max(typeof(too_small))); + rc = flex_to_mem_dup(&dst, &too_small, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -E2BIG); + KUNIT_EXPECT_TRUE(test, dst == NULL); + KUNIT_EXPECT_EQ(test, too_small, 0); + + /* Fail if @alloc_size is NULL. */ + KUNIT_EXPECT_TRUE(test, dst == NULL); + rc = flex_to_mem_dup(&dst, dst, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + KUNIT_EXPECT_TRUE(test, dst == NULL); + + /* Fail if @alloc is NULL. */ + rc = flex_to_mem_dup(null, &bytes, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + KUNIT_EXPECT_TRUE(test, dst == NULL); + KUNIT_EXPECT_EQ(test, bytes, 0); + + /* Check good copy. */ + rc = flex_to_mem_dup(&dst, &bytes, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, 0); + KUNIT_EXPECT_TRUE(test, dst != NULL); + KUNIT_EXPECT_EQ(test, bytes, copy_len); + cast = (void *)dst; + /* Spot check the copy */ + KUNIT_EXPECT_EQ(test, cast[0], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT / 2], MAGIC_WORD); + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT - 1], MAGIC_WORD); + + /* Fail if *@alloc is non-NULL. */ + bytes = 0; + rc = flex_to_mem_dup(&dst, &bytes, src, GFP_KERNEL); + KUNIT_EXPECT_EQ(test, rc, -EINVAL); + KUNIT_EXPECT_EQ(test, bytes, 0); + + kfree(dst); + kfree(obj); +#undef MAGIC_WORD +#undef ELEMENTS_COUNT +} + +static struct kunit_case flex_array_test_cases[] = { + KUNIT_CASE(struct_test), + KUNIT_CASE(flex_cpy_test), + KUNIT_CASE(flex_dup_test), + KUNIT_CASE(mem_to_flex_test), + KUNIT_CASE(mem_to_flex_dup_test), + KUNIT_CASE(flex_to_mem_test), + KUNIT_CASE(flex_to_mem_dup_test), + {} +}; + +static struct kunit_suite flex_array_test_suite = { + .name = "flex_array", + .test_cases = flex_array_test_cases, +}; + +kunit_test_suite(flex_array_test_suite); + +MODULE_LICENSE("GPL"); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320015.540605 (Exim 4.92) (envelope-from ) id 1nm7N3-0005jB-R3; Wed, 04 May 2022 05:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320015.540605; Wed, 04 May 2022 05:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N3-0005iu-M6; Wed, 04 May 2022 05:16:17 +0000 Received: by outflank-mailman (input) for mailman id 320015; Wed, 04 May 2022 01:47:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm476-0007U4-Er for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:36 +0000 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [2607:f8b0:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2aecb958-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:35 +0200 (CEST) Received: by mail-pf1-x42e.google.com with SMTP id a11so21695pff.1 for ; Tue, 03 May 2022 18:47:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k23-20020a170902ba9700b0015e8d4eb1d6sm7012542pls.32.2022.05.03.18.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aecb958-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+ZZ5vfFx25K1I7i1kYl8UxhLqvkhElnoRitD8+hKJmA=; b=DpRwgsc8k+bO9cXVHmU7ksT2E8T7R4om62xOunRq9j6F4/Hlmd+72tPALfSIkWpTBv 6ZsB/FoXumwXqUlvu94h7ehF0Poi6zQZRyL/SVAXWNru3D7CYZKN+GO4S+p3OYu8TvOf p5r4/HuAd0PoSIWCdxVFPC7ODUIYPeBjfKvmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+ZZ5vfFx25K1I7i1kYl8UxhLqvkhElnoRitD8+hKJmA=; b=H3QBJt/8FGoNQ5tBkoz9intG79x0e79OkL5RhEkVHtcOG9moyDesIcBce+RH3JQWp8 CsBSv5aJ+eNuYZka6umPEfZrdZ7fsnmMUrHRpgFzGJJ8h2yLjSPf0yEg1DYnU3QU215e JLlqOGtw+5nh2AfgiwbpWKfNqzjorh0R43SzEuttjAIff+9jd8KzdMjGJQx4XoiBDbA9 V5dENXB2yryBxs/SV5Rn+2pHGOtdqUlL66+4xJQL7zrulUHJso8VlYB+hDVaBx2c/Kc+ bxzLm0SsXZnWICCNT+db+yFwXUVKRF/v0aI4q1PY88hhz3o5Wy6KdIZZ01YVMhH+NWrT wYTQ== X-Gm-Message-State: AOAM533t0VWpDlAbh3obgPlGAYAoIJrDkM1VV7Pxr/v14Y/BO7PCLM4k hSzci+WWN1gZZDS09g2Y58Vxsg== X-Google-Smtp-Source: ABdhPJytQuECKGgEb8eAW6DkkFw1E8TxkJAce0g4AzSArkwdtDW898amuL4eidgPFi1A7RBjUnKTDA== X-Received: by 2002:a62:8684:0:b0:50d:972b:d9d2 with SMTP id x126-20020a628684000000b0050d972bd9d2mr18445121pfd.4.1651628853419; Tue, 03 May 2022 18:47:33 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Rasmus Villemoes , "David S. Miller" , Jakub Kicinski , Rich Felker , Eric Dumazet , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 01/32] netlink: Avoid memcpy() across flexible array boundary Date: Tue, 3 May 2022 18:44:10 -0700 Message-Id: <20220504014440.3697851-2-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2198; h=from:subject; bh=m3+rrHA3rlt0sA4WgKzRJNTXeSTN4vWW0f0prUvbWYY=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqAKYSI60YG7oB43Zm2qf2XEYFq9+0dv6JxgKQA Vag6ObOJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagAAKCRCJcvTf3G3AJt+PD/ 4wYVpcKl2liC+Uc4jUmmdOovQey8J6/k2HmeHGxkjjuXUGIWCxvRqFTmpp0zt8q6NeCY1dzyQE7A9N PW2CVLlv5GLZfLyBlcsOWL4hofk/Ed905HvAky/Dx8yVe0LszOaIIrWGUii70nX0RIZBcDlNYaOY4k wGJaGLJ9XI5Abp/vMi8qzgEIVt5Qty6Z+cfnpAvETE9FFC0ibHAuxSsOCPhKMgvWgkyDjMAVgJQC6t TKGjSE1Rwow+68x8cxXa3ZsNgWXO0wHDaWWB4/QUxyVrq/AqCxOvgu3SljXBgVpaeUF41w+gB7rTXz Jpn7XXtJZLIDQT9yoNDAsj8yjQSIPdaKabA732knKP+dXXvoimMLj17LWxunuIrNQJ5Awl5Dz2jNa4 96eQ4Eabc5miPNc5+9VOK1Wc20FUE/uqW/VkQkBWzcnLXslpLRuJ2jNTFzk50BKZOJ20vutotuSmWf 5gqjyHzRfK+iajoBCEV6nUiWN7ewO8XDDayLZtzu5foCWXgFFwp2ZWksNnvY6M1djooGD0fU2cMDkZ HK9WR0ZfO5zv8cE5RCjDXb25deVhtGS6HRKU3vBlDmFx3drFqOEK/4zwTej6ttVyJqAspxBqEq7xpi JDgQOkTfh60YdtsNYhykruXCL3NnFuRLtxOeMGWD4IL6YtPwYfH3V6aFCljQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit In preparation for run-time memcpy() bounds checking, split the nlmsg copying for error messages (which crosses a previous unspecified flexible array boundary) in half. Avoids the future run-time warning: memcpy: detected field-spanning write (size 32) of single field "&errmsg->msg" (size 16) Creates an explicit flexible array at the end of nlmsghdr for the payload, named "nlmsg_payload". There is no impact on UAPI; the sizeof(struct nlmsghdr) does not change, but now the compiler can better reason about where things are being copied. Fixed-by: Rasmus Villemoes Link: https://lore.kernel.org/lkml/d7251d92-150b-5346-6237-52afc154bb00@rasmusvillemoes.dk Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Rich Felker Cc: Eric Dumazet Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/uapi/linux/netlink.h | 1 + net/netlink/af_netlink.c | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h index 855dffb4c1c3..47f9342d51bc 100644 --- a/include/uapi/linux/netlink.h +++ b/include/uapi/linux/netlink.h @@ -47,6 +47,7 @@ struct nlmsghdr { __u16 nlmsg_flags; /* Additional flags */ __u32 nlmsg_seq; /* Sequence number */ __u32 nlmsg_pid; /* Sending process port ID */ + __u8 nlmsg_payload[];/* Contents of message */ }; /* Flags values */ diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 1b5a9c2e1c29..09346aee1022 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2445,7 +2445,10 @@ void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err, NLMSG_ERROR, payload, flags); errmsg = nlmsg_data(rep); errmsg->error = err; - memcpy(&errmsg->msg, nlh, payload > sizeof(*errmsg) ? nlh->nlmsg_len : sizeof(*nlh)); + errmsg->msg = *nlh; + if (payload > sizeof(*errmsg)) + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, + nlh->nlmsg_len - sizeof(*nlh)); if (nlk_has_extack && extack) { if (extack->_msg) { -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320020.540626 (Exim 4.92) (envelope-from ) id 1nm7N5-00066U-6q; Wed, 04 May 2022 05:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320020.540626; Wed, 04 May 2022 05:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N4-00063L-ST; Wed, 04 May 2022 05:16:18 +0000 Received: by outflank-mailman (input) for mailman id 320020; Wed, 04 May 2022 01:47:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm479-0007U1-9T for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:39 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ccb9786-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:47:38 +0200 (CEST) Received: by mail-pg1-x529.google.com with SMTP id 7so11490846pga.12 for ; Tue, 03 May 2022 18:47:38 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y15-20020a62b50f000000b0050dc7628169sm6918076pfe.67.2022.05.03.18.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ccb9786-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=911JnfKaG9oxLMZbIRJVKqmgZoLrOSfR0+bBHDgrI5Q=; b=XpaB8pfu8eVojSjAsTEUujhhPhU3ucUSWYxDz/8sQ6z59UWvf3i1yrd7kb6SWG2Tnt HAfw08l7QKrj5Y9xBESf9NlJZEn9vrEgx5ueLfnIKaMH/WYs9aAiD55J+sDOumyzi4NC ygqjXeva6u5ldSCOC93c/m2TPIGafNG0RRrsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=911JnfKaG9oxLMZbIRJVKqmgZoLrOSfR0+bBHDgrI5Q=; b=yEAwnET2SAJele/cuo9AYkZPd7fE9zwiPeSUdE8NrkCUkmcvvDajsRsH2eeChfk1sc OS9iOnYZoSNKO44ZOEXNbktzXuHnfnAqZcMicMXX4aeycUOgg29g9oLf7mMQX5nxDGYV cIRpHRD8YlbCybjdbE+C3/p9UXs7SIQkbVC9tjhDdf7b09bZJ1dUf3nORVagYGPK2i6o uJwb2juQivfINw3+rjxi9t1beIK6AaQA5tqgIvT4Nsc1648CTnAY0S2AieUon4ShO5pG SFsy5SGBrmu/fyPK706RbmDTW/rfS8Rjgi7X6DedEWNcvTcmzUHmhrFifDoDwDpS6rD0 H26Q== X-Gm-Message-State: AOAM530+crvAfdqoV7ka3hk6/JMR4Ws3cdR7kpdLRHnueE8zbXjgkkgD MAET/F8yYTICpWWISvNBYJeIBQ== X-Google-Smtp-Source: ABdhPJydqfWS2cnvIBsBYcFhLEOpO1Tg+x0Mug13Ee8lcdS00R4Sd2JnpNFfM3uvQNoLZ5NloFdI/Q== X-Received: by 2002:a05:6a00:150d:b0:510:3a9c:3eed with SMTP id q13-20020a056a00150d00b005103a9c3eedmr1139816pfu.86.1651628856514; Tue, 03 May 2022 18:47:36 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , netdev@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 04/32] fortify: Add run-time WARN for cross-field memcpy() Date: Tue, 3 May 2022 18:44:13 -0700 Message-Id: <20220504014440.3697851-5-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=7485; h=from:subject; bh=tR948KPQeb2PYDrDjEae6GxtJ84K9V5KxBtP7gPRR/0=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqBJdrO+OL3bCOY6akLjwosSFqhKtDoTb/Zh8Fy uzSMohWJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagQAKCRCJcvTf3G3AJu6nD/ 4nHJdgb4XE8OHMjojOaPl9nULa44o03t//4waAm5Xj50QbDOyrBIKqeaRsc5tWg7tp/Z6v0nmG1RJ6 XSHy4AfPcewPHlkIjBTKQ1jbxZcS7qaEExIyWtMJtQ7GtiOD1AWiQbAW4KJ769iV/0me51Vamo+8Ip veorWN0jTQ+xDJ7fyb9mbxXsI7lvSOQUBdZzwAzPgJazmEXjwO8ozXnn0AaGKNv31py+LgyPwV3P64 KAQ04Gxp/rMnWduFhSm2pHXhcI6M++J1CvvtB/IPwWfRbr9CNUU4Jk3s04sG/XIIP/XCeyAn9u7lla 0QyhfHAuqHdIkCdiPXrp7mi2GKNlqOsemPZjnRNTm7F8RVQ7axjkLgPu/OdKyoIjcu4+Gxe1+1ddUe aX6mQB2mGmzNYtycr4ZILXoVPXUX2aUg4K+tE9BlmcAPTi2DTbr35TkFDaDVuBx1qu3sfaOS7h4cb8 ktu5OJHSekWrtF+UVSH3EdBatG6D2HeS6wxcx6SHUNtMwugLr34tjLkliqOflvnPJpRccxYFyzl9dZ qy69k3TaXevsfsMBn7XO5PIzGI74pL+vRzFTRl1RwbUS4WyKiQh9d4h/hZVD2tYMHxvgBj3q9keCdw H22GUCBSF28gbojQv8oqLHwc2cPU6T+4DFzfvbOlpZYHDcM7+2IPrnwnqyXQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit Enable run-time checking of dynamic memcpy() and memmove() lengths, issuing a WARN when a write would exceed the size of the target struct member, when built with CONFIG_FORTIFY_SOURCE=y. This would have caught all of the memcpy()-based buffer overflows from 2018 through 2020, specifically covering all the cases where the destination buffer size is known at compile time. This change ONLY adds a run-time warning. As false positives are currently still expected, this will not block the overflow. The new warnings will look like this: memcpy: detected field-spanning write (size N) of single field "var->dest" (size M) WARNING: CPU: n PID: pppp at source/file/path.c:nr function+0xXX/0xXX [module] The false positives are most likely where intentional field-spanning writes are happening. These need to be addressed similarly to how the compile-time cases were addressed: add a struct_group(), split the memcpy(), use a flex_array.h helper, or some other refactoring. In order to make identifying/investigating instances of added runtime checks easier, each instance includes the destination variable name as a WARN argument, prefixed with 'field "'. Therefore, on any given build, it is trivial to inspect the artifacts to find instances. For example on an x86_64 defconfig build, there are 78 new run-time memcpy() bounds checks added: $ for i in vmlinux $(find . -name '*.ko'); do \ strings "$i" | grep '^field "'; done | wc -l 78 Currently, the common case where a destination buffer is known to be a dynamic size (i.e. has a trailing flexible array) does not generate a WARN. For example: struct normal_flex_array { void *a; int b; size_t array_size; u32 c; u8 flex_array[]; }; struct normal_flex_array *instance; ... /* These cases will be ignored for run-time bounds checking. */ memcpy(instance, src, len); memcpy(instance->flex_array, src, len); This code pattern will need to be addressed separately, likely by migrating to one of the flex_array.h family of helpers. Note that one of the dynamic-sized destination cases is irritatingly unable to be detected by the compiler: when using memcpy() to target a composite struct member which contains a trailing flexible array struct. For example: struct wrapper { int foo; char bar; struct normal_flex_array embedded; }; struct wrapper *instance; ... /* This will incorrectly WARN when len > sizeof(instance->embedded) */ memcpy(&instance->embedded, src, len); These cases end up appearing to the compiler to be sized as if the flexible array had 0 elements. :( For more details see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832 https://godbolt.org/z/vW6x8vh4P Regardless, all cases of copying to/from flexible array structures should be migrated to using the new flex*()-family of helpers to gain their added safety checking, but priority will need to be given to the "composite flexible array structure destination" cases noted above. As mentioned, none of these bounds checks block any overflows currently. For users that have tested their workloads, do not encounter any warnings, and wish to make these checks stop any overflows, they can use a big hammer and set the sysctl panic_on_warn=1. Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: Tom Rix Cc: linux-hardening@vger.kernel.org Cc: llvm@lists.linux.dev Signed-off-by: Kees Cook --- include/linux/fortify-string.h | 70 ++++++++++++++++++++++++++++++++-- 1 file changed, 67 insertions(+), 3 deletions(-) diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h index 295637a66c46..9f65527fff40 100644 --- a/include/linux/fortify-string.h +++ b/include/linux/fortify-string.h @@ -3,6 +3,7 @@ #define _LINUX_FORTIFY_STRING_H_ #include +#include #define __FORTIFY_INLINE extern __always_inline __gnu_inline __overloadable #define __RENAME(x) __asm__(#x) @@ -303,7 +304,7 @@ __FORTIFY_INLINE void fortify_memset_chk(__kernel_size_t size, * V = vulnerable to run-time overflow (will need refactoring to solve) * */ -__FORTIFY_INLINE void fortify_memcpy_chk(__kernel_size_t size, +__FORTIFY_INLINE bool fortify_memcpy_chk(__kernel_size_t size, const size_t p_size, const size_t q_size, const size_t p_size_field, @@ -352,16 +353,79 @@ __FORTIFY_INLINE void fortify_memcpy_chk(__kernel_size_t size, if ((p_size != (size_t)(-1) && p_size < size) || (q_size != (size_t)(-1) && q_size < size)) fortify_panic(func); + + /* + * Warn when writing beyond destination field size. + * + * We must ignore p_size_field == 0 and -1 for existing + * 0-element and flexible arrays, until they are all converted + * to flexible arrays and use the flex()-family of helpers. + * + * The implementation of __builtin_object_size() behaves + * like sizeof() when not directly referencing a flexible + * array member, which means there will be many bounds checks + * that will appear at run-time, without a way for them to be + * detected at compile-time (as can be done when the destination + * is specifically the flexible array member). + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832 + */ + if (p_size_field != 0 && p_size_field != (size_t)(-1) && + p_size != p_size_field && p_size_field < size) + return true; + + return false; } #define __fortify_memcpy_chk(p, q, size, p_size, q_size, \ p_size_field, q_size_field, op) ({ \ size_t __fortify_size = (size_t)(size); \ - fortify_memcpy_chk(__fortify_size, p_size, q_size, \ - p_size_field, q_size_field, #op); \ + WARN_ONCE(fortify_memcpy_chk(__fortify_size, p_size, q_size, \ + p_size_field, q_size_field, #op), \ + #op ": detected field-spanning write (size %zu) of single %s (size %zu)\n", \ + __fortify_size, \ + "field \"" #p "\" at " __FILE__ ":" __stringify(__LINE__), \ + p_size_field); \ __underlying_##op(p, q, __fortify_size); \ }) +/* + * Notes about compile-time buffer size detection: + * + * With these types... + * + * struct middle { + * u16 a; + * u8 middle_buf[16]; + * int b; + * }; + * struct end { + * u16 a; + * u8 end_buf[16]; + * }; + * struct flex { + * int a; + * u8 flex_buf[]; + * }; + * + * void func(TYPE *ptr) { ... } + * + * Cases where destination size cannot be currently detected: + * - the size of ptr's object (seemingly by design, gcc & clang fail): + * __builtin_object_size(ptr, 1) == -1 + * - the size of flexible arrays in ptr's obj (by design, dynamic size): + * __builtin_object_size(ptr->flex_buf, 1) == -1 + * - the size of ANY array at the end of ptr's obj (gcc and clang bug): + * __builtin_object_size(ptr->end_buf, 1) == -1 + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 + * + * Cases where destination size is currently detected: + * - the size of non-array members within ptr's object: + * __builtin_object_size(ptr->a, 1) == 2 + * - the size of non-flexible-array in the middle of ptr's obj: + * __builtin_object_size(ptr->middle_buf, 1) == 16 + * + */ + /* * __builtin_object_size() must be captured here to avoid evaluating argument * side-effects further into the macro layers. -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320024.540641 (Exim 4.92) (envelope-from ) id 1nm7N6-0006SJ-Dc; Wed, 04 May 2022 05:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320024.540641; Wed, 04 May 2022 05:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N6-0006Ns-2c; Wed, 04 May 2022 05:16:20 +0000 Received: by outflank-mailman (input) for mailman id 320024; Wed, 04 May 2022 01:47:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47A-0007U4-Ty for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:40 +0000 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [2607:f8b0:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2df7430c-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:40 +0200 (CEST) Received: by mail-pf1-x42c.google.com with SMTP id j6so16129857pfe.13 for ; Tue, 03 May 2022 18:47:40 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j14-20020aa7800e000000b0050dc762816bsm6923568pfi.69.2022.05.03.18.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2df7430c-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/zjSzrQhFPsEVokcSsrv18uPDt/e1w8KitHmUEp+EKs=; b=mT+0HB76IN8PFmOQ4RQ3Shsn/xpSWIw4uZtDzm+qPL1ltT6DXjm7Tp880YLv6NTlX2 jzlnck4Hcy2b22tjZHTFIsFigeOwa/p0jwatnoLYw/6ZPZFoRjVJYcegxFjMo85nErfR VdOWk3eGpgUIVPQ45lqiYFZPzg8bYlpkvYlx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/zjSzrQhFPsEVokcSsrv18uPDt/e1w8KitHmUEp+EKs=; b=hgDqft2slnu8FVh3VbVEVkVjahO9V0qincdjYBTHOeYCfLIh8HMur9Dx4UmdUT+pff iPGbU1ZMo9xykNhTDx9+FU7ON+jgqVwxjZREiyoGQJTg7XYwQSwHYqCm/plHaHcYEypc /+fZo3+QE9YIne9TUKCckCHmQLkoamlGJFz8399+CKKq3XWpATWVQqGFcZfPB5IcUjEQ XA8nMeDcI836pCmJrne7SMQFQ+Di4cI5r/zxGH7QHR/yL/L/ScPYN5dgJv4f8DgCTfyK QpyRoWwnQuBP7NAxnokfujtjBFAyELv/6Bepl6HuMJ/t0r0aLZUEJxLqPVZxQFIdhwnA ojMw== X-Gm-Message-State: AOAM53368V3GZP6HCksMpycIQ0IiDrGZ6y90xsPP4Yf8tRyp1sEIZSN6 i1dIqMyHeMzpFE9bnwbA79jzIw== X-Google-Smtp-Source: ABdhPJxhtwXtLVIUcB2US4slqD0XToxtoZJgPLmnCR1fqgUmJy/AmZ3otgqvCCOEdhxOZsYp+oeMXA== X-Received: by 2002:a63:3409:0:b0:3ab:4d72:1f0a with SMTP id b9-20020a633409000000b003ab4d721f0amr15975186pga.420.1651628858527; Tue, 03 May 2022 18:47:38 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Luca Coelho , "David S. Miller" , Jakub Kicinski , Lee Jones , Johannes Berg , Gregory Greenman , Kalle Valo , Eric Dumazet , Paolo Abeni , Andy Lavr , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 06/32] iwlwifi: calib: Prepare to use mem_to_flex_dup() Date: Tue, 3 May 2022 18:44:15 -0700 Message-Id: <20220504014440.3697851-7-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4285; h=from:subject; bh=3rsHreun4MVxtWWXTu1WNAZSbES1/vQKrpGvwiRs9tU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqBVRPLVwI+Gac+Hu63Hjdxl/T8wFFeQtpYoExL lGTHr0KJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagQAKCRCJcvTf3G3AJls/D/ 437IfHiRN/O/WyQZtpBUHVGUgP169cUmMhP62Pg0E7Hm7/o39zhQLTQ6d/zK2YTBo7GmHkrgW8+U89 K5ocyNlNeKiAOXNNyYjAKY0hINeYBOJbO+yP8Qb7dZ/ehdVAMXsZ5FjQQj2vRKXsiXBoCT4SNc7+7q 9k8nWm0scS/uHdUFonlvWzm3U/glq/QdTO6+M+RL75mqVm3Z2pZVYd2zeERbawqDVM7cuH2Zg17Avr WdhGyjfTAsPULi+qZBWVUvqc6X+iQ4DfUXZsJix/xvmINZyl3qG1d9TC92K8dHMKiRgdQpvnR+FE6Q WFBlvLGlrizcMolOVSXOkMFCRZ74YilAy+JISkDbLH5XPWP7v8ecKO+KApQCuxSqbyQ5G2zKND3+pY XoycBgIvvVGCy6VqLKW/gevPTpcBLR3Co4zh7nUKJffVspyQUE2M+5pLQBir/tmUVL54XdaUlMD4Tn pwD2p93A7KSHATImTFhq4PX2SS6jGi0V6Il1OHQS6pknXDGlaqxdwNO9EjP+edRb938jKgEGXypou9 S7mjGxWZ8I5Vu1E04fw2ClHZt4VH4Yas0mafjkRAPt2hiDdKF7TGiEg+awmLwQxN4tzHXDSsSGnmAv D9O1AcRWlYNF1HE1jUt/Y9dXMSZUe1atungkrYoabVpF4z5SrVEEglZiUKow== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit In preparation for replacing an open-coded memcpy() of a dynamically side buffer, rearrange the structures to pass enough information into the calling function to examine the bounds of the struct. Rearrange the argument passing to use "cmd", rather than "hdr", since "res" expects to operate on the "data" flex array in "cmd" (that follows "hdr"). Cc: Luca Coelho Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Lee Jones Cc: Johannes Berg Cc: Gregory Greenman Cc: Kalle Valo Cc: Eric Dumazet Cc: Paolo Abeni Cc: Andy Lavr Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/wireless/intel/iwlwifi/dvm/agn.h | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/calib.c | 10 +++++----- drivers/net/wireless/intel/iwlwifi/dvm/ucode.c | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/agn.h b/drivers/net/wireless/intel/iwlwifi/dvm/agn.h index abb8696ba294..744e111d2ea3 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/agn.h +++ b/drivers/net/wireless/intel/iwlwifi/dvm/agn.h @@ -112,7 +112,7 @@ int iwl_load_ucode_wait_alive(struct iwl_priv *priv, enum iwl_ucode_type ucode_type); int iwl_send_calib_results(struct iwl_priv *priv); int iwl_calib_set(struct iwl_priv *priv, - const struct iwl_calib_hdr *cmd, int len); + const struct iwl_calib_cmd *cmd, int len); void iwl_calib_free_results(struct iwl_priv *priv); int iwl_dump_nic_event_log(struct iwl_priv *priv, bool full_log, char **buf); diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c index a11884fa254b..ae1f0cf560e2 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c @@ -19,7 +19,7 @@ struct iwl_calib_result { struct list_head list; size_t cmd_len; - struct iwl_calib_hdr hdr; + struct iwl_calib_cmd cmd; /* data follows */ }; @@ -43,12 +43,12 @@ int iwl_send_calib_results(struct iwl_priv *priv) int ret; hcmd.len[0] = res->cmd_len; - hcmd.data[0] = &res->hdr; + hcmd.data[0] = &res->cmd; hcmd.dataflags[0] = IWL_HCMD_DFL_NOCOPY; ret = iwl_dvm_send_cmd(priv, &hcmd); if (ret) { IWL_ERR(priv, "Error %d on calib cmd %d\n", - ret, res->hdr.op_code); + ret, res->cmd.hdr.op_code); return ret; } } @@ -57,7 +57,7 @@ int iwl_send_calib_results(struct iwl_priv *priv) } int iwl_calib_set(struct iwl_priv *priv, - const struct iwl_calib_hdr *cmd, int len) + const struct iwl_calib_cmd *cmd, int len) { struct iwl_calib_result *res, *tmp; @@ -69,7 +69,7 @@ int iwl_calib_set(struct iwl_priv *priv, res->cmd_len = len; list_for_each_entry(tmp, &priv->calib_results, list) { - if (tmp->hdr.op_code == res->hdr.op_code) { + if (tmp->cmd.hdr.op_code == res->cmd.hdr.op_code) { list_replace(&tmp->list, &res->list); kfree(tmp); return 0; diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/ucode.c b/drivers/net/wireless/intel/iwlwifi/dvm/ucode.c index 4b27a53d0bb4..bb13ca5d666c 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/ucode.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/ucode.c @@ -356,18 +356,18 @@ static bool iwlagn_wait_calib(struct iwl_notif_wait_data *notif_wait, struct iwl_rx_packet *pkt, void *data) { struct iwl_priv *priv = data; - struct iwl_calib_hdr *hdr; + struct iwl_calib_cmd *cmd; if (pkt->hdr.cmd != CALIBRATION_RES_NOTIFICATION) { WARN_ON(pkt->hdr.cmd != CALIBRATION_COMPLETE_NOTIFICATION); return true; } - hdr = (struct iwl_calib_hdr *)pkt->data; + cmd = (struct iwl_calib_cmd *)pkt->data; - if (iwl_calib_set(priv, hdr, iwl_rx_packet_payload_len(pkt))) + if (iwl_calib_set(priv, cmd, iwl_rx_packet_payload_len(pkt))) IWL_ERR(priv, "Failed to record calibration data %d\n", - hdr->op_code); + cmd->hdr.op_code); return false; } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320023.540636 (Exim 4.92) (envelope-from ) id 1nm7N5-0006HQ-U8; Wed, 04 May 2022 05:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320023.540636; Wed, 04 May 2022 05:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N5-0006Ec-Eu; Wed, 04 May 2022 05:16:19 +0000 Received: by outflank-mailman (input) for mailman id 320023; Wed, 04 May 2022 01:47:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47A-0007U4-Al for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:40 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d8ca463-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:39 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id qe3-20020a17090b4f8300b001dc24e4da73so2750449pjb.1 for ; Tue, 03 May 2022 18:47:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ij16-20020a170902ab5000b0015e8d4eb200sm7024989plb.74.2022.05.03.18.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d8ca463-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xU+lft0xYFj1fS1yuTZSbozxjgBGk0a+m2yFd6VoFH8=; b=a+tRkUtoblEDLjvFId++UphGjoZEaQCYI3Vk83Wii7jOQPjtu5Lszr9szx/ri1HX51 wV1jt/Of6XxA4HH6Vf9VLVYuUYeTQ2uz41Vd4xndvpOP8cB9qurXZHACinwkcuuAVoNS S4kXDV6k7pYw97SFuBD/SAZ91ynDl2QAdaG/0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xU+lft0xYFj1fS1yuTZSbozxjgBGk0a+m2yFd6VoFH8=; b=fktl6Yv3Nm3QkSrb7p49UsoedJnB+T1LtCoWrC5aMnua+A7CliP10R0kINaiOIdNJe cDWYpgWPWJo6S1XkPix5ntPsEr+ewj30JFmd6Lt9MgS8Wm6TKT2i4h90YBqZGXaqU2e6 9CzzDAtzn+tqEKRFXSorQNvE0OUppCaqmnUkpVgxArrrBYXjja9qrXTRLrFTff36VW5c H9LAeFS4x+Feygm3sFnSO7Aup5VmJ3wjCHwVC9a/VjeQC9puby9mmd90G+Y6HtY668xL wW3C7gVp12nwF8LUZ0zAQxkKDpmMUSOPDz5gMW7nu1QB/U3B/SyrQ8T6RgzvwQd9w3CE Z0uQ== X-Gm-Message-State: AOAM533h1rB0hsaftIEPXgWtL1YV2Xfo/fysjXDl/KZ1isfFvrR2LZ/3 BIjlTjV3W04WrA/aexlNOfx1Hg== X-Google-Smtp-Source: ABdhPJxAtBZ9EXzckbFxXEo5UZhmn/LsbzwXw7S3livWp9IXdIuEWTNc+6eQzBZkUiCIn0RCFgRUjw== X-Received: by 2002:a17:90a:8407:b0:1d9:ab62:bd3c with SMTP id j7-20020a17090a840700b001d9ab62bd3cmr7874329pjn.139.1651628857838; Tue, 03 May 2022 18:47:37 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Andy Lavr , Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Gregory Greenman , Eric Dumazet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 07/32] iwlwifi: calib: Use mem_to_flex_dup() with struct iwl_calib_result Date: Tue, 3 May 2022 18:44:16 -0700 Message-Id: <20220504014440.3697851-8-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2309; h=from:subject; bh=WpodBqq01jqwxM1KRcJO62uugaWovPAJ5k8Asd34efc=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqCGKNTo/e4rYqRS6JHFIWEcMsPl6ZUWQBFBFL/ Wqla2nSJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHaggAKCRCJcvTf3G3AJvqCD/ 9KMmQRVL3p5s+EO2ziT+OnA/bWRcfyVrpdD2apYiZrAvV6jv+ChcK5o9LNvgU6liqmGQvBK56XO3bQ qrNnEnu62KEpY0aEShwY6YNXdwdTLw3FEMK42jV6f34XbajiPo0MoQoS/x/QSbL1eIG6JO5d4TRjIe 0/Q48qkArPdlLvI5pKeSr1lsEVPndfc9NGHCI6nA2+bBonwbXOWfAC7HZPfrpPcmTgLfoKTkBLXai4 ePDPJtwC3/jzsxtTC7J9DHOmQvRPHeYKpPXefkrkgeOaZf2ToPQ3uG49rEHXnkAeJVNemhQ1DJPNcQ HudzUsakTefZTR7ato8r+9r+0+ie8aFfQEAagdWcpPFVR9EyXHXbSWIWZPdHaXSsvv+zcH2BVwp+lX PHt2bIY0X/x3Uouh1It3/uSZlg30A1qnqeXxqNsMc6p4qaHY4pJywV1EkrsZwZd1PdBaiWc6LsdWnm g/rpEfcleSaFr5QGOmd7i7ErfwdtNTNDj5n6eo7f/rD6qfq1dEAIa3IkdH7xRECGPpT/2qd+a747A7 vm2gjfh13/ghhPAbVTSZORt9oZN46upeJxwm83wHp0XHC4gVbEH+bjDqXYQAWbhNyUaOA8Ua7uIonu l7HgMXAQ7eoMMallt3TbHeAxvHxkwxcyt1LUHi517rK5CcCYO26DROhVZXYw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Avoids future false-positive warning when strict run-time memcpy() bounds checking is enabled: memcpy: detected field-spanning write (size 8) of single field "&res->hdr" (size 4) Adds an additional size check since the minimum isn't 0. Reported-by: Andy Lavr Cc: Luca Coelho Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Gregory Greenman Cc: Eric Dumazet Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/wireless/intel/iwlwifi/dvm/calib.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c index ae1f0cf560e2..7480c19d7af0 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c @@ -18,8 +18,11 @@ /* Opaque calibration results */ struct iwl_calib_result { struct list_head list; - size_t cmd_len; - struct iwl_calib_cmd cmd; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, cmd_len); + union { + struct iwl_calib_cmd cmd; + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); + }; /* data follows */ }; @@ -59,14 +62,10 @@ int iwl_send_calib_results(struct iwl_priv *priv) int iwl_calib_set(struct iwl_priv *priv, const struct iwl_calib_cmd *cmd, int len) { - struct iwl_calib_result *res, *tmp; + struct iwl_calib_result *res = NULL, *tmp; - res = kmalloc(sizeof(*res) + len - sizeof(struct iwl_calib_hdr), - GFP_ATOMIC); - if (!res) + if (len < sizeof(*cmd) || mem_to_flex_dup(&res, cmd, len, GFP_ATOMIC)) return -ENOMEM; - memcpy(&res->hdr, cmd, len); - res->cmd_len = len; list_for_each_entry(tmp, &priv->calib_results, list) { if (tmp->cmd.hdr.op_code == res->cmd.hdr.op_code) { -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320026.540653 (Exim 4.92) (envelope-from ) id 1nm7N7-0006iY-FK; Wed, 04 May 2022 05:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320026.540653; Wed, 04 May 2022 05:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N6-0006ex-UG; Wed, 04 May 2022 05:16:20 +0000 Received: by outflank-mailman (input) for mailman id 320026; Wed, 04 May 2022 01:47:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47C-0007U4-0H for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:42 +0000 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [2607:f8b0:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e7e2912-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:41 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id x23so10860423pff.9 for ; Tue, 03 May 2022 18:47:41 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i3-20020a17090a718300b001d6a79768b6sm1982097pjk.49.2022.05.03.18.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e7e2912-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jHmaho/x33MqcwhAHjzMaEbYW3Sn2ucNcqc26yK2kNU=; b=P8OaWDj1i9vMS2YXwPGohhK4T/Iw+CyPZ/W6hEEhH6k1LaC96jgeOuZ+dQGCL7k52R 9vedbYNUSwVa5cTgkoS7mq60UIXNgrNEh8xt0xCvSUKOkKMHizwfjhRvtgim24nhUgRa 9onXSvEkUpL1rmnA+09r2XcsNzTJwLrKjOBuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jHmaho/x33MqcwhAHjzMaEbYW3Sn2ucNcqc26yK2kNU=; b=RJQ6fmhIo/2H+2B4RjOqnlsBl+21sG53M5wjGPyq+kMKT7FcDuHBv28q+HrGvUQVo/ 3JBJyc0Zeykn0Jw+w3GAOWCUesqERKzRZDZNch6EPnZ5HbeDAy6gvffSQJZnfM32RNs7 pLIJ8Q4ELEtqRPxPhjfrWjj48fWdhBCW4y14erefCCvnZ+TU5mMhhNkz4oRrsce3qgLr GIxGj/fUTba0SdR3RRhGPIO4BPyylJSzged31kLwM0ZABQ3spWqDONmEwh0dNRl8jTAF iSIqiiW6I9k3cnBoO8UXOoayfTzp3t42uzVqSDCn2KZn6J1+CJC70o2QY1pKLkbfHbyI 1CLg== X-Gm-Message-State: AOAM533yOQxhXT86tTETT3FumZIeNq0i4RzYWhKBJX8S7mBBNlbGKwl8 ugvyiWGc+mQFh2seFK4RG7RdMA== X-Google-Smtp-Source: ABdhPJwDwI9Zn57H+UzccAss3I4+YVo4G5gzupm0JsKJ0LRhyJxSmHdZxJnL2FMxr0l8EdjG4443ww== X-Received: by 2002:a05:6a00:2482:b0:50d:481d:b516 with SMTP id c2-20020a056a00248200b0050d481db516mr18785143pfv.10.1651628859404; Tue, 03 May 2022 18:47:39 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Johannes Berg , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 12/32] cfg80211: Use mem_to_flex_dup() with struct cfg80211_bss_ies Date: Tue, 3 May 2022 18:44:21 -0700 Message-Id: <20220504014440.3697851-13-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4271; h=from:subject; bh=zLIoLyad9bBq8i+CHRJcAMhW5JgPaoyM4x0VIL3Wjf8=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqDR3XqoFSprf0Mf1o1HYj7dBBBP7wDZ118xdTx ToM0RNGJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagwAKCRCJcvTf3G3AJpDCD/ wMlRRCUB8XTmCXlLdvPCGb5ACTTMa3Km0myBmfsx6i7FkHxAEfNtllJsJZ1xGdv/WP8g4XEUJ0zuGC 7wsRbPVl7sHYNyFiAu9iXMMSYvJVG0G1YrRXdH2A3UhX8o4+JfEVNj7XazhRyhM9cIwvTR0hQBUIKJ OO0TtkviYxesRpL1xBvgYIcCWjxEvNdpsGjAfF7Wn6Ml1dOstypUTb2ulq7hIf7BX8w63KuqOXZx6V eQKW4gi3cQO3gPoEWsv9zeDktQzxWbaMN212KDtDCB76/UH1i+QQg8eLLlaSQ/55nnf45kUX75sHkI zDmnUC7uL8hJaFE7/98/TeYKsLAgbyP1/MwzniEWgtSaLkPJj+BDTLhK4+jBB7zxpXsyQsyJXmfWnN 69jBTE8Z6ldaOWiCaA2dwzQcHNWXsHvzTspOWk/Tiv7AIUHd8Nqe4ecJtsbDBBxQU21ogSn3TNlfat 3ZCTfW1XDttiZNSK2Rit27Gb0LCzE4nKpVwxT5qmFoGk/jjq2ZfP1uWkMyv4TOb/bfGw5ZiXtTJwtA 22mI6CUOQ9lCD1lIB2WdB8z0yibGypy9fbuDpeqzg6v+weYYD4cY0Q38ZtkdzpABByyOAlmZm7iXIU /hIQA44hD8/vgfuYEgBfavnXALP3koZt6viHAklNZAsuY6wiAG9ZgR2ZT8XQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Johannes Berg Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Eric Dumazet Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/cfg80211.h | 4 ++-- net/wireless/scan.c | 21 ++++++--------------- 2 files changed, 8 insertions(+), 17 deletions(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 68713388b617..fa236015f6ef 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -2600,9 +2600,9 @@ struct cfg80211_inform_bss { struct cfg80211_bss_ies { u64 tsf; struct rcu_head rcu_head; - int len; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); bool from_beacon; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; /** diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 4a6d86432910..9f53d05c6aaa 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -1932,7 +1932,7 @@ cfg80211_inform_single_bss_data(struct wiphy *wiphy, gfp_t gfp) { struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy); - struct cfg80211_bss_ies *ies; + struct cfg80211_bss_ies *ies = NULL; struct ieee80211_channel *channel; struct cfg80211_internal_bss tmp = {}, *res; int bss_type; @@ -1978,13 +1978,10 @@ cfg80211_inform_single_bss_data(struct wiphy *wiphy, * override the IEs pointer should we have received an earlier * indication of Probe Response data. */ - ies = kzalloc(sizeof(*ies) + ielen, gfp); - if (!ies) + if (mem_to_flex_dup(&ies, ie, ielen, gfp)) return NULL; - ies->len = ielen; ies->tsf = tsf; ies->from_beacon = false; - memcpy(ies->data, ie, ielen); switch (ftype) { case CFG80211_BSS_FTYPE_BEACON: @@ -2277,7 +2274,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, size_t ielen = len - offsetof(struct ieee80211_mgmt, u.probe_resp.variable); size_t new_ie_len; - struct cfg80211_bss_ies *new_ies; + struct cfg80211_bss_ies *new_ies = NULL; const struct cfg80211_bss_ies *old; u8 cpy_len; @@ -2314,8 +2311,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, if (!new_ie) return; - new_ies = kzalloc(sizeof(*new_ies) + new_ie_len, GFP_ATOMIC); - if (!new_ies) + if (mem_to_flex_dup(&new_ies, new_ie, new_ie_len, GFP_ATOMIC)) goto out_free; pos = new_ie; @@ -2333,10 +2329,8 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, memcpy(pos, mbssid + cpy_len, ((ie + ielen) - (mbssid + cpy_len))); /* update ie */ - new_ies->len = new_ie_len; new_ies->tsf = le64_to_cpu(mgmt->u.probe_resp.timestamp); new_ies->from_beacon = ieee80211_is_beacon(mgmt->frame_control); - memcpy(new_ies->data, new_ie, new_ie_len); if (ieee80211_is_probe_resp(mgmt->frame_control)) { old = rcu_access_pointer(nontrans_bss->proberesp_ies); rcu_assign_pointer(nontrans_bss->proberesp_ies, new_ies); @@ -2363,7 +2357,7 @@ cfg80211_inform_single_bss_frame_data(struct wiphy *wiphy, gfp_t gfp) { struct cfg80211_internal_bss tmp = {}, *res; - struct cfg80211_bss_ies *ies; + struct cfg80211_bss_ies *ies = NULL; struct ieee80211_channel *channel; bool signal_valid; struct ieee80211_ext *ext = NULL; @@ -2442,14 +2436,11 @@ cfg80211_inform_single_bss_frame_data(struct wiphy *wiphy, capability = le16_to_cpu(mgmt->u.probe_resp.capab_info); } - ies = kzalloc(sizeof(*ies) + ielen, gfp); - if (!ies) + if (mem_to_flex_dup(&ies, variable, ielen, gfp)) return NULL; - ies->len = ielen; ies->tsf = le64_to_cpu(mgmt->u.probe_resp.timestamp); ies->from_beacon = ieee80211_is_beacon(mgmt->frame_control) || ieee80211_is_s1g_beacon(mgmt->frame_control); - memcpy(ies->data, variable, ielen); if (ieee80211_is_probe_resp(mgmt->frame_control)) rcu_assign_pointer(tmp.pub.proberesp_ies, ies); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320029.540665 (Exim 4.92) (envelope-from ) id 1nm7N8-0006vw-D9; Wed, 04 May 2022 05:16:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320029.540665; Wed, 04 May 2022 05:16:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N7-0006rL-O1; Wed, 04 May 2022 05:16:21 +0000 Received: by outflank-mailman (input) for mailman id 320029; Wed, 04 May 2022 01:47:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47C-0007U4-SV for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:42 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f325e7f-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:42 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id cq17-20020a17090af99100b001dc0386cd8fso3382pjb.5 for ; Tue, 03 May 2022 18:47:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n21-20020a634d55000000b003c14af50617sm13533557pgl.47.2022.05.03.18.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f325e7f-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P7uM3xoAcE7zuGNsfEYVdWWhl8RQOVkTgxnXHqQm9tk=; b=Ttm1udnLhK1uzAB04KBRSr/POGM0kwPI1bs4XPEU6UEtgK8/23ubm+dxeV4+X853RT 0+Il5Jok8kr0+FDj5VV/8TyC5lx1HeS1NOnJkl2lVk9pme8hyn7Y1lYALOBUqbtoGYi3 cAWN4x8Bl4pcx02o/CTto17Eyhwd5u2uMzQSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P7uM3xoAcE7zuGNsfEYVdWWhl8RQOVkTgxnXHqQm9tk=; b=CzF2swXzJxePme2qfhya1OY4oF5kEILB4G12AyhLWa63zgs4oIrCIZU6uc+d9sLObX bZrvAZRSykJ+1UJV9978No7zrqjX+cGa6GE9OUHcKJgNzqciZO5HUizMoD0G0h/GVgFz U+w+EcQkg5hKz4mzIId0Ekv9UbGd/na+JfYTzsmbyPQQTrqInt711XAx3+aNPnq9V0Ky 9rU9+ytLOplygSfGzUBfJwlII3pDBaqbtUqfNZqZgbhMKrdrS+pH4IZQci/pn7MrzaqF uFx8OoywBPFs8HeRFlEgTK22DKyWDc1ZIQ5OdXJZbCIeVgCzIVUt3gJBA/pyG2Tf+UeN 0VRA== X-Gm-Message-State: AOAM530GZPF4oFwGeYtu6aIosPGZSiB9zOFfZTUUNkJH8y7m6r8iNLT+ zQDJ4CMdUmbot0e3hdIBab1zpQ== X-Google-Smtp-Source: ABdhPJxiRXcmbs8jLBX+uUybbobrWQal42E5OsdXgAFm4WZnFq+xnafC0he6L5xAcHtlxnI8HYhS1A== X-Received: by 2002:a17:90b:3742:b0:1d9:5dc6:dede with SMTP id ne2-20020a17090b374200b001d95dc6dedemr7813310pjb.92.1651628860398; Tue, 03 May 2022 18:47:40 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Johannes Berg , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 11/32] nl80211: Use mem_to_flex_dup() with struct cfg80211_cqm_config Date: Tue, 3 May 2022 18:44:20 -0700 Message-Id: <20220504014440.3697851-12-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2217; h=from:subject; bh=rRfAu1/k1e5caQg21/8VBHhysNqsP1FR5GA2AHrLW6w=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqDYqJpVuI+Da24TYyn7rK2cAZcih+2ZRWaGUhg VviQcPmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagwAKCRCJcvTf3G3AJjdwD/ 9GoZycFvhK6h6fbIQwuLO60vgqzr+JFBMz2boSXTBJSryctNsbZrwuvUuiBZUKC1y9sGE+SgzQm0T7 WzDZtyTlGmT1CZjKFpgdCfMbuMLVROkIwwyYoraeYFirZmIIRURYhLoAsJh4ZeL+hi8jOWnaV5ClMm GpAX4WW1YsM9YRJimQri0QE7pLQKGb80KxVsDgul4e0OUj1wYZTYbTgr98Zpysc1nSby6oGnxfPJ5B GvVh8QA/SYaCCMlYyUKr3bjTLrKOZ0NSnt6bAW38OpCXj8344D0TsfmO6tGo0jkheFbpEhSFjRi0Lj 1/+lxcBQ3jvc7zB+0Q5hpVWgX0kC+MxgbmIRdXF66gXOY9KMZzGl6dt9Fdm0xQWH6kFZlX7zpOBeHx To/pgX+EVE7aw6zudBInH3vlkkTYIklAIL/O9ajINZfL2HKHTp1XgnQdpa0KDyxqJilBhkXXekcKjn s7KJFzs28RJWqn+YgyJ+4W4uA6XLQvHdqVGZu5zS748KLU05KkgCeTW+Wm195aiMdUvqPG1QyqpCX5 1oMep8SXDkjOyDi6DnWcfFivJfrpKBqXU3oWsvXdBRhX+fVXmfr/E7qrARl1smC7xBgqWCcJf152Rh nwFocx9Hoo9dTUkHbkM4z/OFi36I6ENfaPOS+x9fFE1riA7xPsrh1gW6nwwA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Johannes Berg Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Cc: Eric Dumazet Signed-off-by: Kees Cook --- net/wireless/core.h | 4 ++-- net/wireless/nl80211.c | 15 ++++----------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/net/wireless/core.h b/net/wireless/core.h index 3a7dbd63d8c6..899d111993c6 100644 --- a/net/wireless/core.h +++ b/net/wireless/core.h @@ -295,8 +295,8 @@ struct cfg80211_beacon_registration { struct cfg80211_cqm_config { u32 rssi_hyst; s32 last_rssi_event_value; - int n_rssi_thresholds; - s32 rssi_thresholds[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, n_rssi_thresholds); + DECLARE_FLEX_ARRAY_ELEMENTS(s32, rssi_thresholds); }; void cfg80211_destroy_ifaces(struct cfg80211_registered_device *rdev); diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 945ed87d12e0..70df7132cce8 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -12096,21 +12096,14 @@ static int nl80211_set_cqm_rssi(struct genl_info *info, wdev_lock(wdev); if (n_thresholds) { - struct cfg80211_cqm_config *cqm_config; + struct cfg80211_cqm_config *cqm_config = NULL; - cqm_config = kzalloc(struct_size(cqm_config, rssi_thresholds, - n_thresholds), - GFP_KERNEL); - if (!cqm_config) { - err = -ENOMEM; + err = mem_to_flex_dup(&cqm_config, thresholds, n_thresholds, + GFP_KERNEL); + if (err) goto unlock; - } cqm_config->rssi_hyst = hysteresis; - cqm_config->n_rssi_thresholds = n_thresholds; - memcpy(cqm_config->rssi_thresholds, thresholds, - flex_array_size(cqm_config, rssi_thresholds, - n_thresholds)); wdev->cqm_config = cqm_config; } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320030.540674 (Exim 4.92) (envelope-from ) id 1nm7N9-0007Gw-Q2; Wed, 04 May 2022 05:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320030.540674; Wed, 04 May 2022 05:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N8-0007CI-Rn; Wed, 04 May 2022 05:16:22 +0000 Received: by outflank-mailman (input) for mailman id 320030; Wed, 04 May 2022 01:47:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47D-0007U4-DV for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:43 +0000 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [2607:f8b0:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f320c5b-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:42 +0200 (CEST) Received: by mail-pf1-x42d.google.com with SMTP id bo5so13454pfb.4 for ; Tue, 03 May 2022 18:47:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f1-20020aa782c1000000b0051008603b66sm534694pfn.219.2022.05.03.18.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f320c5b-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9UACyPlKQMpsfBiUxRNSWJwLKyqQ0BVbIzFlqTVpEg=; b=VrQ6dmSQ7VwQQlIfvwbiI2ql0BVm4J4y9LnkKFZwetWH13cFjtZDcQhXtoigM+PS1n cWMsbR1tWdnyAFxVTIwv3Ub+HJcEvYJUmHiHKdd7Tvd9COj+RhcM0WyuPg5dj9PivY8a z6yX6sb9Wvgoc2VwmZES4MbGCx8+oyfzVBgW4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z9UACyPlKQMpsfBiUxRNSWJwLKyqQ0BVbIzFlqTVpEg=; b=IQc73+5+jKk96efUyDTD3gTkunWq2894dqstlAop9DyrjkJ4koVNYprOBNR0o6iWuu ttyyGE0DA7eMak94UfLE4RWoH2EInMETvnEm9CQiP8mITOj7tSOTokPouFsTm0dJ5aic uVgd/mhCWncK6BGx6qHjZk85LWS2tAzBZB2t+hqidE6XwftyJctB9Cg3aNZZAA+BcrRU S61l1ROJsbDsEkbKMJFqxO3Jk1XRKSnhJOV0h00+NrASp5dHo3XrTrx6Lx7YSpLiTBMR MsJ/H/mxTfbjF74p4tY5y6gptI55UXogvT/pJh9I85Q5MPEH021JziWFfaF3IuMigrQ0 miog== X-Gm-Message-State: AOAM530KAJJYmW2vg+nEl2TmdKlMAvsMmqus0TtRuspcZhCxZvLRwnS5 wpLbBNbzBGmm0Wql+v6uIVszTQ== X-Google-Smtp-Source: ABdhPJwEApgoIF80IVfCqZ7Wc14eeSv0NeFMafCSFu13taEwh77M4/lfD99nmAtgnvxZOmH48ydyyA== X-Received: by 2002:a65:524b:0:b0:383:1b87:2d21 with SMTP id q11-20020a65524b000000b003831b872d21mr15967593pgp.482.1651628860634; Tue, 03 May 2022 18:47:40 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Christian Lamparter , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 09/32] p54: Use mem_to_flex_dup() with struct p54_cal_database Date: Tue, 3 May 2022 18:44:18 -0700 Message-Id: <20220504014440.3697851-10-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2429; h=from:subject; bh=nMnYI58OZL/NYqqBGThX6X9At9N55AKclw2PdmxLkv8=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqCpEYc7sUWDpluF0bUB90CkVbrB3/z8O0fymGg eduju0uJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHaggAKCRCJcvTf3G3AJkJoEA CB3d+CRBr1VkScrlHfbIs1LkNyymQ0HwJgl7p4QyueseREG9Mt5326Iwc7RqKF+Rn+YzyWk8dFShzv z6gbI8PNrGAqBPz5BIqLg3dYYHVK5dPPYcYrISNYxFwyXlYH5CnwM8gllN72k9RJxbWzAxh0A+60N/ jviJWlHykiM1Zhxd/qazs6ZevTYO060Zif3DN8WCX/LuwNHp30u5sclQ55oDW3betiobkSC6Ov1eP6 Hi7uDPuaVPlM2ZtdStVUbJUtmb0ddMSgxtTLjFPmzu+/igOg0pwYTovc41hbeEbBnxlRHIoUJWYLEF 9HwXpVeVj29IIka07Wj1DhYds+eo/zSM1UgogveTLy1YqauYGa0HDWQq9oUmlyE1DVBtfNlwDKfQFw abW5WTkLqlaK1bDWZEM/2f5rXJ6Qb2wLF8985KU4MwKaSdM+Jib4Npl3mdvg3RTIqLUDL5C0EsnPZd jx7VWu4NuZxHBeVOpG042kcl9h6NgrzPV4i2lneNTdK9Mf4aIUBuhXuEi0RjjZPRX5KWBWDETa+SHA xIpk2sXTFarSyRcDwvPPRN7FWxxM5y5OPAGRGPRQhj9zCDB+Eh+NAEZe1GFUTZYOWu4PHtyiVVuH0q lf+bEbHqDfX8rt+XVzeUsKcH3bW7KZvEkMLgB/C70MIwPtiUdXvWDMDbvCRw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Christian Lamparter Cc: Kalle Valo Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/wireless/intersil/p54/eeprom.c | 8 ++------ drivers/net/wireless/intersil/p54/p54.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c index 5bd35c147e19..bd9b3ea327b9 100644 --- a/drivers/net/wireless/intersil/p54/eeprom.c +++ b/drivers/net/wireless/intersil/p54/eeprom.c @@ -702,7 +702,7 @@ static int p54_convert_output_limits(struct ieee80211_hw *dev, static struct p54_cal_database *p54_convert_db(struct pda_custom_wrapper *src, size_t total_len) { - struct p54_cal_database *dst; + struct p54_cal_database *dst = NULL; size_t payload_len, entries, entry_size, offset; payload_len = le16_to_cpu(src->len); @@ -713,16 +713,12 @@ static struct p54_cal_database *p54_convert_db(struct pda_custom_wrapper *src, (payload_len + sizeof(*src) != total_len)) return NULL; - dst = kmalloc(sizeof(*dst) + payload_len, GFP_KERNEL); - if (!dst) + if (mem_to_flex_dup(&dst, src->data, payload_len, GFP_KERNEL)) return NULL; dst->entries = entries; dst->entry_size = entry_size; dst->offset = offset; - dst->len = payload_len; - - memcpy(dst->data, src->data, payload_len); return dst; } diff --git a/drivers/net/wireless/intersil/p54/p54.h b/drivers/net/wireless/intersil/p54/p54.h index 3356ea708d81..22bbb6d28245 100644 --- a/drivers/net/wireless/intersil/p54/p54.h +++ b/drivers/net/wireless/intersil/p54/p54.h @@ -125,8 +125,8 @@ struct p54_cal_database { size_t entries; size_t entry_size; size_t offset; - size_t len; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; #define EEPROM_READBACK_LEN 0x3fc -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320032.540685 (Exim 4.92) (envelope-from ) id 1nm7NA-0007Xr-VA; Wed, 04 May 2022 05:16:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320032.540685; Wed, 04 May 2022 05:16:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7N9-0007Ry-Vy; Wed, 04 May 2022 05:16:24 +0000 Received: by outflank-mailman (input) for mailman id 320032; Wed, 04 May 2022 01:47:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47E-0007U4-Bu for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:44 +0000 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [2607:f8b0:4864:20::102f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2fb4306a-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:43 +0200 (CEST) Received: by mail-pj1-x102f.google.com with SMTP id e24so16903191pjt.2 for ; Tue, 03 May 2022 18:47:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a23-20020a62bd17000000b0050dc762817csm6895201pff.86.2022.05.03.18.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fb4306a-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OUtFJC5/TKCmTq7i/wF9dXPYB7F9m5Fe+Glt57epyug=; b=LA1DuW2pq5PcEvMCaSGHJyuI7WWCw3brL8SvS9+2zVb7L13DgPnUJao9oTWLzzgmb0 FDFEPcC6DrQfzS+lsrgByCwuE3V59hlwMRxN4HndNJubDx+3EuT5ltBW8juSZqsKA86J 6Mk0HEWOn29+r/VVptC8G26Rp5mKAXoQSht84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OUtFJC5/TKCmTq7i/wF9dXPYB7F9m5Fe+Glt57epyug=; b=EFTS5Rlug7C1wTcsrz8BhHt4/YKj7z4/vAM8ZUn6Hw7scqDJJXbfxihC0qL0nKj7xz kqrqO1CvKgKcZIUHXMZdGQcn/jMXfWClwjfUV+Mjeep6aySGTwZxsANavYZum5wouL4d XRD+C3cylxmygHLVnHFbm0pb3xtzpxnwwzs5quINzJiMcWMeUm2r0Xk+LHi8DZAYZ6vz CEgvGZgAAlJUcCrSEw+CuFoRtJ2cxAATVRgpPTJwYNSbzcIXlU2CEpYB6CBeCIDHiVWq bLsR3Hl1wjpBkVddpdX3wbK4GMOcLXMhPhR5eRLYWXFjTfUjYDRLppx8Xf4m9GeVE/9A HJgg== X-Gm-Message-State: AOAM530Yf5Km9r0lOc3l5BI0ED1WA33JCaKPD0Td2kbZ0MeJqFMvLPcy ohwtyeaItJ/cPhtZOzY0H+ZLkQ== X-Google-Smtp-Source: ABdhPJx7ujhXCzRS91FZ+LbZ03DWxWBQ0dT1Khz71PDh68k6Z8Yrj0NdP/nPQNiqOyMCkQJP+cu5vw== X-Received: by 2002:a17:902:e811:b0:15e:b27b:92ef with SMTP id u17-20020a170902e81100b0015eb27b92efmr8546338plg.142.1651628861418; Tue, 03 May 2022 18:47:41 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Loic Poulain , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 10/32] wcn36xx: Use mem_to_flex_dup() with struct wcn36xx_hal_ind_msg Date: Tue, 3 May 2022 18:44:19 -0700 Message-Id: <20220504014440.3697851-11-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2631; h=from:subject; bh=Msy2+XfnfeHEfU9VZJ5tdjPuaYOOARhkHxIAzZX3hrE=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqCU5cwj3opYKUJRuHiQ6yrF7a8I32dTqix7rZH epN2AJmJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHaggAKCRCJcvTf3G3AJlHYD/ wPCLYVdBQwlOASKzq0go8+yQ9WXYDGyw7A8O0OnAVu3fIR1Fz5Lc4pY5x32WjVh8glBxJBPELf/CJL MNaKgMdTHQ7NA2hxtEc7bQM+t4sMdVV5x1MYPoH8LFiI3+Tvt13YvoQ+E1WZ0t2qqUC8zhxbH36dxW Bc0wCumlz/0FK9T//W8qmXHq+YCTZhpOj4lIosW7Ic80QXG9vfEguHz+8nSw2PXbpXiLtiKMXYVPis NcxiHBa5qoFp2VamsSe418quush6XqJxmFvLZl7mtiboKYYYu2/qPzI5A37FAbPIGCru3jMXR/tCbm Q/hHT9bgmoM7Gg13G5tslRAOTf4pY5AWKIKHlUwbJswOg2FEBoabSKGh058NrhtgM0MjsUnbiDiOZ5 aO0FKd7cJsVfNFB7uZ3+4sBW8mA109abyB33FJQ/eJ+s21q6pPofkO9ECLZme3sqINH5kUfMBZEGbc CCwh1fPl5ZjvS1fXH/PGcDGjsAPJyMdcuEmaFNP9/8CuF7AfC9V9oEUOZ4lm0ofCSU0/fD12keSaj3 IHfhVbZKNV1ZZFfOUd6M2qngKUJR4ZbYTuwFlDxka/MvOQ2XJ1z5dhL/T/KTejeZjeDoZmMeDtRSc8 Toe4QQtXjKsYj/+iwJSz5/80d1lP2aqDJFhk1y/i4XSNcgPBCqcyBiQzMbsQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Loic Poulain Cc: Kalle Valo Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: wcn36xx@lists.infradead.org Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/wireless/ath/wcn36xx/smd.c | 8 ++------ drivers/net/wireless/ath/wcn36xx/smd.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index dc3805609284..106af0a2ffc4 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -3343,7 +3343,7 @@ int wcn36xx_smd_rsp_process(struct rpmsg_device *rpdev, const struct wcn36xx_hal_msg_header *msg_header = buf; struct ieee80211_hw *hw = priv; struct wcn36xx *wcn = hw->priv; - struct wcn36xx_hal_ind_msg *msg_ind; + struct wcn36xx_hal_ind_msg *msg_ind = NULL; wcn36xx_dbg_dump(WCN36XX_DBG_SMD_DUMP, "SMD <<< ", buf, len); switch (msg_header->msg_type) { @@ -3407,16 +3407,12 @@ int wcn36xx_smd_rsp_process(struct rpmsg_device *rpdev, case WCN36XX_HAL_DELETE_STA_CONTEXT_IND: case WCN36XX_HAL_PRINT_REG_INFO_IND: case WCN36XX_HAL_SCAN_OFFLOAD_IND: - msg_ind = kmalloc(struct_size(msg_ind, msg, len), GFP_ATOMIC); - if (!msg_ind) { + if (mem_to_flex_dup(&msg_ind, buf, len, GFP_ATOMIC)) { wcn36xx_err("Run out of memory while handling SMD_EVENT (%d)\n", msg_header->msg_type); return -ENOMEM; } - msg_ind->msg_len = len; - memcpy(msg_ind->msg, buf, len); - spin_lock(&wcn->hal_ind_lock); list_add_tail(&msg_ind->list, &wcn->hal_ind_queue); queue_work(wcn->hal_ind_wq, &wcn->hal_ind_work); diff --git a/drivers/net/wireless/ath/wcn36xx/smd.h b/drivers/net/wireless/ath/wcn36xx/smd.h index 3fd598ac2a27..76ecac46f36b 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.h +++ b/drivers/net/wireless/ath/wcn36xx/smd.h @@ -46,8 +46,8 @@ struct wcn36xx_fw_msg_status_rsp { struct wcn36xx_hal_ind_msg { struct list_head list; - size_t msg_len; - u8 msg[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, msg_len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, msg); }; struct wcn36xx; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320035.540699 (Exim 4.92) (envelope-from ) id 1nm7NC-0007wL-8O; Wed, 04 May 2022 05:16:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320035.540699; Wed, 04 May 2022 05:16:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NB-0007nh-By; Wed, 04 May 2022 05:16:25 +0000 Received: by outflank-mailman (input) for mailman id 320035; Wed, 04 May 2022 01:47:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47F-0007U4-CE for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:45 +0000 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [2607:f8b0:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30645da1-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:44 +0200 (CEST) Received: by mail-pg1-x534.google.com with SMTP id i62so13977pgd.6 for ; Tue, 03 May 2022 18:47:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a7-20020aa780c7000000b0050dc76281b6sm7143766pfn.144.2022.05.03.18.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30645da1-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c1Rtb5BPD8+4OzMMFAYya8AfbyIngu3+nEeMZt3y0UI=; b=PPT74quvAq5PeXKx/MiU6TPQu9k3CNU13XJUuKL0EyoDADIEUu/0flA/RnFvgA1c7X mBDEtN+hqIFmsdnm+Z9MnOUhAzMjdHFmhT3p34uRueOVQQXniPBqP+mbSA7EtL7aqOIy RKCLgSNE4LzNp+Ti/YBiXR973K5zL+mViu9iQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c1Rtb5BPD8+4OzMMFAYya8AfbyIngu3+nEeMZt3y0UI=; b=CBO3FRDCo5FT6GIKWHYp9yxSblV7fccPJ2I9MDCAx1PEQdt8JvhDr1UTA6s13LL1Iz 0pkzl7zuACVxgs+p/0CYYzRh10dkrScKKbGZTdQlMc0sYcd72UQXzJnPLTJlm0gsB5e5 EY9d8B5JhQzRvQeLzYAyyBZ2KKgBG0ziboIJxJqV0lWN/FpS6O1j3miuwVpMGQFZji4/ XwY+ogzgIuRehZwQHM1j5JnDC7pH/c7TozhpfIsmODNKgyGaB8AU2ugjNaqpNs5uwoUn XMlNKWyZ4iKcCeTPuiDEYfScytsQ112Gbolf42UKI7OhZF43tYnxmq8NYw1s3SQ+dyWb mZlQ== X-Gm-Message-State: AOAM530H68nr/Q9u8iJJC9ynwMBV/6VY2Y21w8CSTk0uZX1+jP8l+hbJ 21vYkYEX4l0HN/3ICgKl3a2t3w== X-Google-Smtp-Source: ABdhPJxnr15nFI48HkUIGCzg3Ti+ux7Hnf2+eF3BCNGMnuO30iNkq86oUQW51ItlsFi5999/esgbAg== X-Received: by 2002:a62:33c2:0:b0:50d:a588:daab with SMTP id z185-20020a6233c2000000b0050da588daabmr18437024pfz.31.1651628862604; Tue, 03 May 2022 18:47:42 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Stefan Richter , linux1394-devel@lists.sourceforge.net, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 18/32] firewire: Use __mem_to_flex_dup() with struct iso_interrupt_event Date: Tue, 3 May 2022 18:44:27 -0700 Message-Id: <20220504014440.3697851-19-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2017; h=from:subject; bh=En62c6cYeUTmU8jbvcTu7IkYSFHpDUIXfTMNPx9PLGc=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqEY3t8cFKELeYkm2NJIduUgR+ZPwYvLuYXHKSq h9RlNwCJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahAAKCRCJcvTf3G3AJmzQD/ 40OwL2hRSWj9CwaOb0EjwNMYNrEpXdJJUx4PtLsO50tNm7kViyp0rIIENwt0Refm3UMfgJOd4uhpAP UnN8m9LoCHDWTn2Ip+vIMDS3s7F5W2nAcbk5hF/C+qyUcxpZ01AbHR+GyZjxwzVt9qEG+TAXzPRQnp dfwWrtSjiyM2jKV9PjBNt6qRhM7Jxt/+wokWBFK4eM8IKP5wMTPXf0n1BGa/3mFi6dkoZD+yXtl4IT q4PePWOvlJ8zihIyMKu6xe3P2Cd5gPfwiDcsKwkrzufOJPHAEhY8riHbDxYytvqLGG7bw341elDFvM fFg+b/yC+gowOuz1miET0BDC+cA6vVe4BMDspdtGoFbNEJfsp72+AkNfwxKDENX6TekjFRU3iHzOci lPoBqEyf2AILOQko5Kh9u3twT5Z6Azf7bj/NRatR/QKpZXBkjRcvBCR8SN8nlgdnYckPdhxRBU5YUS IHSagdIFo3kzcAF1P/Aq785Nakdj4SMvQp66HlJm0gKK57rvSGhQtlRXIDROMfObo/Dar+MBASK/fr qWo15PcDT/tqMlbzcrYAAB4BcvmIgHfXG5riesv5IcmZv6ehMHVZTaM4Sf1wIA6V0OWztJpmHeUVBs 1l35/YNa44KeLfFackz/5o7jU6Cqxn/jknqaXV6GkQkL2jafxDjZYhz781sQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Stefan Richter Cc: linux1394-devel@lists.sourceforge.net Signed-off-by: Kees Cook --- drivers/firewire/core-cdev.c | 7 ++----- include/uapi/linux/firewire-cdev.h | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c index c9fe5903725a..7e884c61e12e 100644 --- a/drivers/firewire/core-cdev.c +++ b/drivers/firewire/core-cdev.c @@ -913,17 +913,14 @@ static void iso_callback(struct fw_iso_context *context, u32 cycle, size_t header_length, void *header, void *data) { struct client *client = data; - struct iso_interrupt_event *e; + struct iso_interrupt_event *e = NULL; - e = kmalloc(sizeof(*e) + header_length, GFP_ATOMIC); - if (e == NULL) + if (__mem_to_flex_dup(&e, .interrupt, header, header_length, GFP_ATOMIC)) return; e->interrupt.type = FW_CDEV_EVENT_ISO_INTERRUPT; e->interrupt.closure = client->iso_closure; e->interrupt.cycle = cycle; - e->interrupt.header_length = header_length; - memcpy(e->interrupt.header, header, header_length); queue_event(client, &e->event, &e->interrupt, sizeof(e->interrupt) + header_length, NULL, 0); } diff --git a/include/uapi/linux/firewire-cdev.h b/include/uapi/linux/firewire-cdev.h index 5effa9832802..22c5f59e9dfa 100644 --- a/include/uapi/linux/firewire-cdev.h +++ b/include/uapi/linux/firewire-cdev.h @@ -264,8 +264,8 @@ struct fw_cdev_event_iso_interrupt { __u64 closure; __u32 type; __u32 cycle; - __u32 header_length; - __u32 header[0]; + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u32, header_length); + __DECLARE_FLEX_ARRAY_ELEMENTS(__u32, header); }; /** -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320037.540707 (Exim 4.92) (envelope-from ) id 1nm7ND-0008Cu-FE; Wed, 04 May 2022 05:16:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320037.540707; Wed, 04 May 2022 05:16:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NC-00082k-LW; Wed, 04 May 2022 05:16:26 +0000 Received: by outflank-mailman (input) for mailman id 320037; Wed, 04 May 2022 01:47:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47G-0007U1-7x for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:46 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3139a411-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:47:45 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id d22so151481plr.9 for ; Tue, 03 May 2022 18:47:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 136-20020a63078e000000b003c511f54e55sm516441pgh.28.2022.05.03.18.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3139a411-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dMAADGqtkadGyWtiMmUAPEm8bORo1cOmSuHFnzFIe9g=; b=HdhwV0WkvXZw3hjS8p1tFCKs9cZKJFJ7k5obLNyUKACusCcW1RzcVwG/3AkN25wPjr MN1c4fbIR9x0erwQN9MET5VRJYx8dh+R8g2fLDUMIFlB05v/yh9SmtiE3TYb5zg7tp+O AetyTzERcbfGEy31+di4TAAiEqxWduNa5FUWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dMAADGqtkadGyWtiMmUAPEm8bORo1cOmSuHFnzFIe9g=; b=qAYs1T2DIoUvska3+EhXXNPXaFbXKkiA4o8VBkVr3hR5tYr2w+eeCxwTQcoPZbOrec KObhCAOoDPuDNnr4a5122NV6s0LMgVYxfx9xhJLbla11vM6xxDxoFQq2EUmlcDz9Wyk5 mOX6KhJWbahuQLLhgS1rtQMkQYTB263BQLU5mHiprnCdBBZHhEEJAtxzwe5O+DG6fuRf +gNeZq9r6WJC4mDr20wCE995MD9fxRumRZbiywWRfR9AoKdESPSGvG+uu8RgglG0ib4l 0DYFBDM5QNZRz86tzQnbAzDEhwQzVhhE93M8d++KRyVXpHl1lLCWYTzAmn29L8St2Fbf JF+g== X-Gm-Message-State: AOAM531hIdFlF4g1HoFBlHWen2H9yWn3DZPLuKPGnI+kO87v1WpR1SPN bFUH2+EIqBjY7aij+Tawe1XZpw== X-Google-Smtp-Source: ABdhPJydJlkF2g/C05t9xL+CcCRfyDPyeeapmmNS1jyl5QDmxOwU4sKgjA6yob870vT6k0dKeYtEdg== X-Received: by 2002:a17:90b:1c88:b0:1b8:a77e:c9cb with SMTP id oo8-20020a17090b1c8800b001b8a77ec9cbmr7789362pjb.205.1651628863999; Tue, 03 May 2022 18:47:43 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kuniyuki Iwashima , Alexei Starovoitov , Cong Wang , Al Viro , netdev@vger.kernel.org, alsa-devel@alsa-project.org, Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 14/32] af_unix: Use mem_to_flex_dup() with struct unix_address Date: Tue, 3 May 2022 18:44:23 -0700 Message-Id: <20220504014440.3697851-15-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2272; h=from:subject; bh=8b5W7mEG2Sah1C3FkS/UxctivFJh7iOzV6P8ujUbZM8=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqDcR3znMx51jViMoq05/q58V2/1rXjoJjYBmJ4 CKXc5kiJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagwAKCRCJcvTf3G3AJp8ZEA CTZiOebtApgRIMQFGfvlsj7s1U7ENKry+y1qCoH7clKk+kIHUFtKQuToAucuA7HnBVAIDqbBHa+dtu b1A4bqv4cHK21pPyhZmiE0VCyP00EYC8X6VbBCMRrhOvgKIRCQKYCDRRU3x3+zdTamMi+Cw4QRLFbr KeEVo3vWRxKFNYlUY6py6WsFnpaTCP45A1Rt2Mk1ONM+4tvkRlgJQKibXiiVxMmNJiq7diRyS43UyZ xdZzOY9N/SsdVs+DBAetVCVJfwnmWSxup+qwrjzAenumL1egb53niPav19Uu0KPGAkzqPtS4NDain6 T5G8UOgj2W4S/ZIxVzp3AEI0v7Q07cg9AUILFEUOEn2Ga7m2xtn/dn5Hqt0Gq5ryDybbgCBb0FW6nE apZrvb6JoF5ZEkWIMx0CD3b/SEJCPUMr1n+n/nlozI3/5uYk+uJuq11ezAU6BWwGeaiQi5MNENuLtJ f2iVuD520n1Ne+0aDX0g+6Bxq6CjD/3mk3NtQkdQZ1W7jF6hmMJWqPx/GWYvlmDlmSQNEQ659WICV6 styiy2WjRaD2LhpwT9sZHwcdpjjTGhsJ3rXcC+FrO5v7LrNOaE49f+5vGV2+PdIn7TzyijsyYCwjfC sD4MdxKc4Kc8wvaGgok8h676GkR5iOBRUeFIUjcwGTrf9mDGBR6ew5hwb4cQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Kuniyuki Iwashima Cc: Alexei Starovoitov Cc: Cong Wang Cc: Al Viro Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/af_unix.h | 14 ++++++++++++-- net/unix/af_unix.c | 7 ++----- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/include/net/af_unix.h b/include/net/af_unix.h index a7ef624ed726..422535b71295 100644 --- a/include/net/af_unix.h +++ b/include/net/af_unix.h @@ -25,8 +25,18 @@ extern struct hlist_head unix_socket_table[2 * UNIX_HASH_SIZE]; struct unix_address { refcount_t refcnt; - int len; - struct sockaddr_un name[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); + union { + DECLARE_FLEX_ARRAY(struct sockaddr_un, name); + /* + * While a struct is used to access the flexible + * array, it may only be partially populated, and + * "len" above is actually tracking bytes, not a + * count of struct sockaddr_un elements, so also + * include a byte-size flexible array. + */ + DECLARE_FLEX_ARRAY_ELEMENTS(u8, bytes); + }; }; struct unix_skb_parms { diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index e1dd9e9c8452..8410cbc82ded 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -244,15 +244,12 @@ EXPORT_SYMBOL_GPL(unix_peer_get); static struct unix_address *unix_create_addr(struct sockaddr_un *sunaddr, int addr_len) { - struct unix_address *addr; + struct unix_address *addr = NULL; - addr = kmalloc(sizeof(*addr) + addr_len, GFP_KERNEL); - if (!addr) + if (mem_to_flex_dup(&addr, sunaddr, addr_len, GFP_KERNEL)) return NULL; refcount_set(&addr->refcnt, 1); - addr->len = addr_len; - memcpy(addr->name, sunaddr, addr_len); return addr; } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320040.540720 (Exim 4.92) (envelope-from ) id 1nm7NF-00007m-AL; Wed, 04 May 2022 05:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320040.540720; Wed, 04 May 2022 05:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NE-0008Tk-5h; Wed, 04 May 2022 05:16:28 +0000 Received: by outflank-mailman (input) for mailman id 320040; Wed, 04 May 2022 01:47:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47I-0007U1-Ql for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:48 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32c54e3e-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:47:48 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so3936158pju.2 for ; Tue, 03 May 2022 18:47:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id az10-20020a170902a58a00b0015e8d4eb233sm6960220plb.125.2022.05.03.18.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32c54e3e-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t4tLOfp2E2B9sgaGczz1NwPmHgtmRYBWoAQq16bLzJ0=; b=I3H3+WN+4U2IJzWLbxbA/bIvmhwpU+qBCw+gT1kFMomBbMNpQHZRW5m4AyP4iYFi7B wO7Fc+96Bo7pEAoDQ9bMSzGw32N3zXUa3Gz+3UCf0arCmNNwPy4jlH+xYNM+a196cQiM uiF0kR4EmYLRMWy1Z3PDmpbPfAtknr37xwrFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t4tLOfp2E2B9sgaGczz1NwPmHgtmRYBWoAQq16bLzJ0=; b=IZOXgNb6xszmV+77byFOw1rDZGfZd/6AHlvrYV8laAZ/kWzdvBXvSBDosM3Q8MmNnm OIAE+BaJwG+NPBnkTIn4M+fvCwlQ2auBK+pZCJg1gyW1ivPFI71WuZRZJ2Gl3KxTf/tt hT72oDg2IieBHFqCM/uOd3TjVDtaGqD1X9w2vpkgth9BBSmUZvMKr8jjLLRY/sTUav1M i7i1Q/YNsn1eH0XNn5Gw1zJQilhA5uDRhMmeYe7iY5WEkk3q9sHVV+TZ8hkGUjYJNLdS RmJyL3b9a6cVp/Q+SMJ211ZgTBkD4Itw91sj0tLVkaOTBsSRLbPle9ftnJq48+JNAtOx o9og== X-Gm-Message-State: AOAM530gTW2t0vG24Y7P9/ph8OwFTKxidsEQprFw9tzGEfao1dFdn2xa M851mKghXtijGQt/m1+hjbFzUA== X-Google-Smtp-Source: ABdhPJwlsT0iQnDL6xwldA7EiHSnV+6TMJGJpyqPrrObMI2QZUEHe3gCMsqWN7yN6aeTIm9o+5AxVg== X-Received: by 2002:a17:902:ecc8:b0:15e:9e46:cb7e with SMTP id a8-20020a170902ecc800b0015e9e46cb7emr14297448plh.111.1651628866623; Tue, 03 May 2022 18:47:46 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Russell King , Christian Brauner , Andrew Morton , Muchun Song , linux-arm-kernel@lists.infradead.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 22/32] atags_proc: Use mem_to_flex_dup() with struct buffer Date: Tue, 3 May 2022 18:44:31 -0700 Message-Id: <20220504014440.3697851-23-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1766; h=from:subject; bh=LnjqklrPVWNNMfpJjCRO96xv5LhFHHWzp99zKaiUXqg=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqFIMxxbq1Hf+xelWQa6dzkOUxczwNZ6gqGtZgE u/xEciiJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahQAKCRCJcvTf3G3AJpySD/ 9y19Eohym3FvBZ0fkG9198v9dbCdm6Pjk18VavszBLhJaXRQM+HUC12vTL4roysA9+j7Y6cR3Kj+wq mOj198L6Vf/kLphe9xK9VW8LUtIBMSqwCe6Jb9KvCOzeJt1MCby6s4CLjMwjVk9Xf0ZpbPwyghODjv Ol/fkTTE1L9VOXyhYqOagbjRt1ZyTMdInfVLCEui8yUpYiaclByI9CIWaHVkeTDP+2pgEibaH/4OYF wScQ0s9UBHmLFAqRyw73xHGYEHN7DaT9kxcQ0VZMiNRcYxnu5o5CdcqgHDnW0Ws1fLC8PN0uMYp4N2 rNatCh14EdFNyQewdpkHW8VlGj373tjOHjfpHC0RkrDel6FJ4Ac7ipDJypBfD/E0/Apg/I1MwDDPaC nZOn83UTZag+wJyrVfm5yRqNeeoaLNiS9PzD+ARWL40QVrGBA61Ch7hLljKEu7HPfOeufLqsruBVa/ IGTYZbtUKTu+xZFocXg9FmT3/XFiJqva79//82c/nDPbB0Oek/1d/nHiv6e1p5qQeyDcF/lH9dR7Vc v6zhxqG/em6APpkkhmZtA3GMlJqi13XwAKn0eZ/nS06JrCIy8Cq+02xWpUwqJV6SZ63AviU8SrK86H cYVB3yY3zLGR0ABTEsKF2Yo/EaE3tvZgUnPk5p2jx3782+uMiis96Fb2iKQw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Russell King Cc: Christian Brauner Cc: Andrew Morton Cc: Muchun Song Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Kees Cook --- arch/arm/kernel/atags_proc.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm/kernel/atags_proc.c b/arch/arm/kernel/atags_proc.c index 3ec2afe78423..638bbb616daa 100644 --- a/arch/arm/kernel/atags_proc.c +++ b/arch/arm/kernel/atags_proc.c @@ -6,8 +6,8 @@ #include struct buffer { - size_t size; - char data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, size); + DECLARE_FLEX_ARRAY_ELEMENTS(char, data); }; static ssize_t atags_read(struct file *file, char __user *buf, @@ -38,7 +38,7 @@ static int __init init_atags_procfs(void) */ struct proc_dir_entry *tags_entry; struct tag *tag = (struct tag *)atags_copy; - struct buffer *b; + struct buffer *b = NULL; size_t size; if (tag->hdr.tag != ATAG_CORE) { @@ -54,13 +54,9 @@ static int __init init_atags_procfs(void) WARN_ON(tag->hdr.tag != ATAG_NONE); - b = kmalloc(sizeof(*b) + size, GFP_KERNEL); - if (!b) + if (mem_to_flex_dup(&b, atags_copy, size, GFP_KERNEL)) goto nomem; - b->size = size; - memcpy(b->data, atags_copy, size); - tags_entry = proc_create_data("atags", 0400, NULL, &atags_proc_ops, b); if (!tags_entry) goto nomem; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320044.540729 (Exim 4.92) (envelope-from ) id 1nm7NG-0000S0-JR; Wed, 04 May 2022 05:16:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320044.540729; Wed, 04 May 2022 05:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NF-0000MJ-KA; Wed, 04 May 2022 05:16:29 +0000 Received: by outflank-mailman (input) for mailman id 320044; Wed, 04 May 2022 01:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47I-0007U4-Gb for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:48 +0000 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [2607:f8b0:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 328da9af-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:47 +0200 (CEST) Received: by mail-pg1-x530.google.com with SMTP id g3so22040pgg.3 for ; Tue, 03 May 2022 18:47:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j17-20020aa783d1000000b0050dc7628166sm6962339pfn.64.2022.05.03.18.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 328da9af-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tt+uE/qYWOs3CEanZOjmvMoORa5i/xMNqAO3DwAd5m4=; b=YmT1lNTRttmLRyn/WOgpT0DAFWD3BvjkOIsApwxFa4B3Com0bh2yQqIJO66Wiak8Tt rwU+QSbZtL4swuVhrV8kkivMWLyJT9AqfxXpJ4Lm9ZibQLMBbHjNrpcN7FDNu1QRPCS+ uiBQnyfLBZT2SNnaE6twmHxSxmZ2FlIbgcsF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tt+uE/qYWOs3CEanZOjmvMoORa5i/xMNqAO3DwAd5m4=; b=Pq+y38erQEjwn18MEH/HBEiEyG+KRYw55e22sgzxjpaCPVyNr87fy5onSO2hjRg51d 1j7Y8g8L70W61iE51LpEBjsB6/L3TV/u4cXHP5aXS6cvgKqJ8eVJ+5QwQE5b7dqRXzMa 17yJ1iycY5NBCt1vp/EDBdULYSn4bkQJgtgCQAOpC5B6Dv3YAnrZr/r8DiQYRuSXIAgH bHb+eK3cVSW80ZSq4iLqULcBFlWpftMTLyvWyPCP+203cRyUEm6/FiYJSGQ8nbqKLa0y HJlKoG+oOE5auhxqba4DBCqw+T5HVlRBdc5OyGM6sOeQhtYGcEzeQ+QIMZiMLEoBBFH7 HokA== X-Gm-Message-State: AOAM532I1aTbSYiooWL56mKoZPglZ5ysgmVR9tzpvnHV7GBA/uU6+d1I bOsvtevnnDLJWmzY/JR4WdXX6Q== X-Google-Smtp-Source: ABdhPJxm8oQpe82/AlfHpo86YsbZI42gD8lqIDet1sGBcYjpwPke9wpE0Wpp3R+D8mPYMYqjJQCKXw== X-Received: by 2002:a65:490d:0:b0:39e:58cb:b1eb with SMTP id p13-20020a65490d000000b0039e58cbb1ebmr16428991pgs.390.1651628866265; Tue, 03 May 2022 18:47:46 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Lavr , Arend van Spriel , Baowen Zheng , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 21/32] soc: qcom: apr: Use mem_to_flex_dup() with struct apr_rx_buf Date: Tue, 3 May 2022 18:44:30 -0700 Message-Id: <20220504014440.3697851-22-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1693; h=from:subject; bh=f797ezn2sQWsQcALbTjtcz0/uVJxqqsdCbEE9J5EL4c=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqFcya5M1Ba7xKOXe16qG7jIlVI8ph+ibFXwwOp nrqS7nGJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahQAKCRCJcvTf3G3AJhB6D/ 4mAanYpWDhhzP0wFox6ZgqAP9umNDzMV7dRX4Y08wPvedXkTuo/N0jclu6EdK/Bs4KaQilIZSFkLno xsM8xXSf4UqStJoT27N7DzjgnXKUJuyB5HZu1PfC+8PJ3QEnqiU5wE/l/2KdIJiAa7Xrj82dQB2cOe f9cgwxVbs3UnZy77Wv+k8FP5dMShK5yfzH0kpSd88R+/mDgZ6PLzi6zr8ZQiGCGdehQ7yp7ahiIA+i aAsDm3/+QhB0XaYdbqgAm2IAn+ouEdBPFgeXFzXqJwdi8AEfwBoByO06B8F23M3UCLdd6ZTRuaYeVQ kIZhzXstlVWDB9mIUnTP7dpfIY0lC+xzWyCLtZeT4bAvCwQB9CAAEWnSx7qfxwfOCYH1OjKUWJ+Xo4 5bWdci/vlaLQLD13TFP2X8QMY+seDM4SmnQAjgo5eITKrQ8RREz044kssPiR5qrnynNMOFWoNryxir 5TxsUJqEcElCuxyYstu2GZWqRpIeTKHVnaCu6XWtUkfQXhXikks9R9eVs6gSl+qIiVvgsVs7Tv/R9N rFtDfCJB155p3+TaJfCxSA/1e92fAlkjvrq+Ar3n/Jqs+/JGlPFT7Zy0qsgxzMjclrsboCWAvbLZZ2 OSexYpHjEn8jykFiHVbn1z48UtV3JdplNzCir+Gph+mH4axRJfHc0k7gYzyA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Kees Cook --- drivers/soc/qcom/apr.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 3caabd873322..6cf6f6df276e 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -40,8 +40,8 @@ struct packet_router { struct apr_rx_buf { struct list_head node; - int len; - uint8_t buf[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); + DECLARE_FLEX_ARRAY_ELEMENTS(uint8_t, buf); }; /** @@ -162,7 +162,7 @@ static int apr_callback(struct rpmsg_device *rpdev, void *buf, int len, void *priv, u32 addr) { struct packet_router *apr = dev_get_drvdata(&rpdev->dev); - struct apr_rx_buf *abuf; + struct apr_rx_buf *abuf = NULL; unsigned long flags; if (len <= APR_HDR_SIZE) { @@ -171,13 +171,9 @@ static int apr_callback(struct rpmsg_device *rpdev, void *buf, return -EINVAL; } - abuf = kzalloc(sizeof(*abuf) + len, GFP_ATOMIC); - if (!abuf) + if (mem_to_flex_dup(&abuf, buf, len, GFP_ATOMIC)) return -ENOMEM; - abuf->len = len; - memcpy(abuf->buf, buf, len); - spin_lock_irqsave(&apr->rx_lock, flags); list_add_tail(&abuf->node, &apr->rx_list); spin_unlock_irqrestore(&apr->rx_lock, flags); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320045.540739 (Exim 4.92) (envelope-from ) id 1nm7NI-0000pl-Bn; Wed, 04 May 2022 05:16:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320045.540739; Wed, 04 May 2022 05:16:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NH-0000ky-95; Wed, 04 May 2022 05:16:31 +0000 Received: by outflank-mailman (input) for mailman id 320045; Wed, 04 May 2022 01:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm47L-0007U4-Kl for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:47:51 +0000 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [2607:f8b0:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3467b003-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:47:50 +0200 (CEST) Received: by mail-pl1-x62b.google.com with SMTP id k1so167938pll.4 for ; Tue, 03 May 2022 18:47:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e11-20020a62ee0b000000b0050dc762818bsm6935424pfi.101.2022.05.03.18.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:47:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3467b003-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e+5qnKpu1VsQ22oucG43AL+WcjSiOIWtbY50R7ZcVWE=; b=g9AcrkR+3RVkYkCjXueQwetC04MS+NoxVmpAB9VicL40p720LPQhGGdx5xmKktKIDM zPigxQLAL6TBhbYLJe+5LnwPNyPpBp4uN8e2a1B/ZwWxWPLLj/iqfcDi30QcFjJ9kn/S 1QG2VSMrqeLVVCmXWD35ETUMI7QbOsGkL0vw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e+5qnKpu1VsQ22oucG43AL+WcjSiOIWtbY50R7ZcVWE=; b=amjt22iF5IhpVxkEueHYdgaQxqKobSshIOpXHttbtJ7ET050O/dTYT30BUpihst8xg 8Ahj5M7rxiYI5/i6AZlkZBXLafLD+yCORuhoCU+l6XdxI7LnBvTxCGVugDnQ7TYvmZse o8cqAG7N53+n7hnw2ygluCtloA2dJLhfRExAXYeOhZXnfU6OdDBrDx3aBBrjdUH17eRS EL0m632h30SqQ6IkSdlCzZvdgpYEGnu414VuVYzrlaH4UIoOeER+Ikd4E6kw/NktKX7s +Rlsp9+dMh/5SbxiriGa16QeGAVALKuuzQEy6aBRRhrxo5WgLigBDekC9QjASs9JrEsd Nj2Q== X-Gm-Message-State: AOAM533aflmNj3HyQBMgxZynIpl1/kqmQGk10KJbOiq2K9ybmuG8jNfP aaK9HlMoMPy4qhzzY9eYG7HkUQ== X-Google-Smtp-Source: ABdhPJxl7EiV8keIDc6EF0ePDWOyFM8DsnsLzOPF7upSDtXElO4KQwWeIT0ElEMEtCPMOLdFUp0h+w== X-Received: by 2002:a17:902:a5c4:b0:15d:4ca:90cf with SMTP id t4-20020a170902a5c400b0015d04ca90cfmr19318951plq.133.1651628869364; Tue, 03 May 2022 18:47:49 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Chris Zankel , Max Filippov , Rob Herring , Frank Rowand , Guenter Roeck , linux-xtensa@linux-xtensa.org, devicetree@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 29/32] xtensa: Use mem_to_flex_dup() with struct property Date: Tue, 3 May 2022 18:44:38 -0700 Message-Id: <20220504014440.3697851-30-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2507; h=from:subject; bh=Sq6uxCkPHvMJ5JYb1gf1A6wcVxIwkSOLKZO2iCrXvzo=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqHU+zS6KGRXLibFnc06yiYHvM6h9+r1i1/xDqh sS9tPM6JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahwAKCRCJcvTf3G3AJio4D/ 9e7/PUFE5eJVA+iwP4RNPRrwfTbaso73y3UIDDhSBi7DWpVecGpxBZFhq8AZJnACJZ6+0txfLVZrgC Hf9yN6InooZL//+CTSXiiLI0odsJS5G7VPzg8jqFheAUvfc33Ayl7CE4IjUesDTHb8MJcD6pRcV301 BkdC9bu9R9O1wfXjDMG6LGijqVC44/VnATk0Fj2osA9aCT7hCW4+9Y2AhfOuja15+dIryUwqZtX2nq ec7DFRbWbwCMxIvSe2M9T/eENcPFBDRzyY24sIHLdTtdM3+mq1w0JC+v5z47HvtBxdp6Ab4AjGQ6AH +XYDv1NkFrQYotIcm5C43jbDrqJMKe7MsguTTl2SqeeyJm0j16c29CoaUYxAFDubw9ldqYXLp5WTjS purW5BkSiZew9UjQYOHstIZ3tkzqccDABlxOoJx6Jeg7kYmdQqE4PnV7je2MA/jAMh7Hm3WqyHFS4l uZ6AZ4qsuZ3GaLee5riE9Nh9OXqTK8uWuL7aIKJHegYL1BtPlvOB5J6yMZJ+U/rhYZD5ZxqQ0LXB2z BwWGEo9PhEtkSWKk2TiOybFLVH2xKxpJfcQV806Jj+7f6Kq059naUze9XagBDSL7sUoMR34BvbOeER oRxCHL5YzBGrQi45jMVYuRuMcPsrrlr2vvkyx+TWc4h0GZl7w6C6OGv59wRA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Chris Zankel Cc: Max Filippov Cc: Rob Herring Cc: Frank Rowand Cc: Guenter Roeck Cc: linux-xtensa@linux-xtensa.org Cc: devicetree@vger.kernel.org Signed-off-by: Kees Cook --- arch/xtensa/platforms/xtfpga/setup.c | 9 +++------ include/linux/of.h | 3 ++- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/xtensa/platforms/xtfpga/setup.c b/arch/xtensa/platforms/xtfpga/setup.c index 538e6748e85a..31c1fa4ba4ec 100644 --- a/arch/xtensa/platforms/xtfpga/setup.c +++ b/arch/xtensa/platforms/xtfpga/setup.c @@ -102,7 +102,7 @@ CLK_OF_DECLARE(xtfpga_clk, "cdns,xtfpga-clock", xtfpga_clk_setup); #define MAC_LEN 6 static void __init update_local_mac(struct device_node *node) { - struct property *newmac; + struct property *newmac = NULL; const u8* macaddr; int prop_len; @@ -110,19 +110,16 @@ static void __init update_local_mac(struct device_node *node) if (macaddr == NULL || prop_len != MAC_LEN) return; - newmac = kzalloc(sizeof(*newmac) + MAC_LEN, GFP_KERNEL); - if (newmac == NULL) + if (mem_to_flex_dup(&newmac, macaddr, MAC_LEN, GFP_KERNEL)) return; - newmac->value = newmac + 1; - newmac->length = MAC_LEN; + newmac->value = newmac->contents; newmac->name = kstrdup("local-mac-address", GFP_KERNEL); if (newmac->name == NULL) { kfree(newmac); return; } - memcpy(newmac->value, macaddr, MAC_LEN); ((u8*)newmac->value)[5] = (*(u32*)DIP_SWITCHES_VADDR) & 0x3f; of_update_property(node, newmac); } diff --git a/include/linux/of.h b/include/linux/of.h index 17741eee0ca4..efb0f419fd1f 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -30,7 +30,7 @@ typedef u32 ihandle; struct property { char *name; - int length; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, length); void *value; struct property *next; #if defined(CONFIG_OF_DYNAMIC) || defined(CONFIG_SPARC) @@ -42,6 +42,7 @@ struct property { #if defined(CONFIG_OF_KOBJ) struct bin_attribute attr; #endif + DECLARE_FLEX_ARRAY_ELEMENTS(u8, contents); }; #if defined(CONFIG_SPARC) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320048.540751 (Exim 4.92) (envelope-from ) id 1nm7NL-0001H9-0u; Wed, 04 May 2022 05:16:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320048.540751; Wed, 04 May 2022 05:16:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NJ-00019I-8m; Wed, 04 May 2022 05:16:33 +0000 Received: by outflank-mailman (input) for mailman id 320048; Wed, 04 May 2022 01:52:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C5-0008Vf-Qc for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:45 +0000 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [2607:f8b0:4864:20::1035]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3a46777-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:52:44 +0200 (CEST) Received: by mail-pj1-x1035.google.com with SMTP id w17-20020a17090a529100b001db302efed6so14823pjh.4 for ; Tue, 03 May 2022 18:52:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g16-20020a62e310000000b0050dc76281d2sm7165111pfh.172.2022.05.03.18.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3a46777-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KYZx+y1oKNSP1oqgJrB6Tz6rT9EWA8WKaERG51foz1A=; b=bz1Sh9MVCXyP0oQlo8D6xVMzQ27pV4R6B//UGDTL8nzMS3F7Sze+JRYFVh2IBIaTFl BrDTiNFs4Nw3sFWGEkG5ftS8E8tnvlsvZL9PIbvMFVJ2Ru0EtHqoxpqbupakHeJmxqdO iZ/yeqiNZ245qldJTLvXJrPu0t4+xuvhNmFB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KYZx+y1oKNSP1oqgJrB6Tz6rT9EWA8WKaERG51foz1A=; b=6jhQdmwyS7DaNkjisqbSo5Tp37RoF1zEWXYNYD3pgkIjTt/SUi6QJ1ikvslE9Xl4oB eHQpaeDcUwLXjJhIE2ZVmoDs2aK4S9o51MLCBynxHvsr4/im4islngvQl92pm99iAf+X WAm/zZOV85QK2Bp8TvOrTG6lqfJy+xtDeU/LxkhXD7QBUITzrGVqqfyB7tvM0yHTPqKd kyV4EupwL8A91d5ElBqHWw7ECuUg/BHE570njlQ3J0xjVm4SkqtlKCEsvme8OK8TACD6 CxwdEmw5lHk9Z9889F6k2fBORyv8rXkEDVLG/XKIYGMUAB1ZXHGsp68c03uZhHTaEVWu V6NA== X-Gm-Message-State: AOAM530jP4LEhYPsLSihR/h7Lgp26ZFM4npl1Jy6KpDFY7w6n4JlG/tc fa7FNvWHd4SORBINUQMVGf1YPg== X-Google-Smtp-Source: ABdhPJzn4mkWoLO9GkvHCb0f9HPITkXNkv0C1WpBFBFfJEBtcJV5kgYulneag//rfVNwLsJ0LGVqMg== X-Received: by 2002:a17:90b:1251:b0:1d7:f7ae:9f1 with SMTP id gx17-20020a17090b125100b001d7f7ae09f1mr7834178pjb.65.1651629163350; Tue, 03 May 2022 18:52:43 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hulk Robot , Yang Yingliang , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng Subject: [PATCH 15/32] 802/garp: Use mem_to_flex_dup() with struct garp_attr Date: Tue, 3 May 2022 18:44:24 -0700 Message-Id: <20220504014440.3697851-16-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2053; h=from:subject; bh=g6mLY++H2BfqQCK003F0EjItFkVyhehgYOIo/aZQtaQ=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqEjjw/bjk+w/BAp5zZGN/lLOysTcemUiPR49xS rdNJyZqJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahAAKCRCJcvTf3G3AJkdZD/ 9ULlU2HE7dyOGGZcxoTDzzzQ0RkAnTOaJ+RVqmjII2Tv1VoPm6QRB0LGPVIKf/ajMgajI22eW2yGjV dV/acgUammYsccOQLPxTPzsPUVFZFU0hxMis5Oq9JqjehQPY4nErl1wT/Zymsur2YjD5pHbuIEHC00 ++wwwIwEXX7l/PdVNJ+PMRIdE9atC0npYUgWrpfpDQWjeDdc8adknigoQ33ZyiQZNgrZVYTO9/59Qg 8KXYHO+zkVTrXNgaZRW0wDjH3ltz+pKJr0geOSSbUhz6LlZjAauJ/rC2ZsYG+CUN5gZKKeQGMACl+O utmoGfrkJAMo4fchbVPoySQfEI4RycU3tPyq3AjrjHPoEOk1up5kNYJrBZjwNIsdxzt2klrR6QtXyt bfI8wU27DsqhelPlsyi6UMtKYVW917c/eUpFGiSJstE8AvpEEc7fwbwOkpO95+zogvhdjqrPwm0ODF hO4WSuDl0qqoSCqmphywXtHTbvP3/SyHQqpHk+XFWlqObHfRedTUudfAq0fRt/wpoTokjndugHxbB3 vPHZIR/QvpGV0TdPvLZ2ykBHieWoDTJLdsmeVjUv1/KqeUr4N1QQRZM24ry1hMmkrjPTDYRPSVjN1n 2Idl5GOStpor5uc8wuqfeiXlQfP7X+6iC5KJi+Kgwt8eOaWFgTn89ibYrF3g== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Hulk Robot Cc: Yang Yingliang Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/garp.h | 4 ++-- net/802/garp.c | 9 +++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/include/net/garp.h b/include/net/garp.h index 4d9a0c6a2e5f..ec087ae534e7 100644 --- a/include/net/garp.h +++ b/include/net/garp.h @@ -80,8 +80,8 @@ struct garp_attr { struct rb_node node; enum garp_applicant_state state; u8 type; - u8 dlen; - unsigned char data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, dlen); + DECLARE_FLEX_ARRAY_ELEMENTS(unsigned char, data); }; enum garp_applications { diff --git a/net/802/garp.c b/net/802/garp.c index f6012f8e59f0..72743ed00a54 100644 --- a/net/802/garp.c +++ b/net/802/garp.c @@ -168,7 +168,7 @@ static struct garp_attr *garp_attr_create(struct garp_applicant *app, const void *data, u8 len, u8 type) { struct rb_node *parent = NULL, **p = &app->gid.rb_node; - struct garp_attr *attr; + struct garp_attr *attr = NULL; int d; while (*p) { @@ -184,13 +184,10 @@ static struct garp_attr *garp_attr_create(struct garp_applicant *app, return attr; } } - attr = kmalloc(sizeof(*attr) + len, GFP_ATOMIC); - if (!attr) - return attr; + if (mem_to_flex_dup(&attr, data, len, GFP_ATOMIC)) + return NULL; attr->state = GARP_APPLICANT_VO; attr->type = type; - attr->dlen = len; - memcpy(attr->data, data, len); rb_link_node(&attr->node, parent, p); rb_insert_color(&attr->node, &app->gid); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320049.540762 (Exim 4.92) (envelope-from ) id 1nm7NN-0001p9-HQ; Wed, 04 May 2022 05:16:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320049.540762; Wed, 04 May 2022 05:16:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NL-0001dS-SD; Wed, 04 May 2022 05:16:35 +0000 Received: by outflank-mailman (input) for mailman id 320049; Wed, 04 May 2022 01:52:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C5-0008Vg-UZ for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:45 +0000 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [2607:f8b0:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3b25c7e-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:52:44 +0200 (CEST) Received: by mail-pg1-x532.google.com with SMTP id 6so2144pgb.13 for ; Tue, 03 May 2022 18:52:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m1-20020a637d41000000b003c14af5063esm13641114pgn.86.2022.05.03.18.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3b25c7e-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xT+5hQcq61BvthAgaoVmL+Iixyk9Kz6M9vS9nNgwYZE=; b=foxymm92zvgmK0ETJD/OF52F7nwlYYgJQ8oVdho7r9BzWtgtuSGYfDYK5MhNshEOoZ 2wn0h0u9CPuexCbq87DKe80piTtxK5R6ZpJwSBGXRNF7rOHEPYzOtCIu9lKjSdiUbhe+ r2DkWtw3UKhrg5w4I5ukgiJdOnG5MzFcAx9yc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xT+5hQcq61BvthAgaoVmL+Iixyk9Kz6M9vS9nNgwYZE=; b=Ej/NX4k2cHepcyQKn330sRS+z2I0Wc/VSQC5SnEh+juypLzcp92uOLgqKAbgpf9F7D mcBizMiCM4JvC4HeDNS33ptC69evMiHB8NBhFC2FembNtViK816XAhM0XePKxAbEJ9b2 K56+wzHWs7aKoM3a82c3kQQ00MccC+fahmEb52Gki0ct4XJyHG2vAhOtsQRMbZcImanS GiYhNDT4yDxDzNfsuSUW7U4rd1yOmQsVwbAr0rtFp1Ig3LEErE+rDv1WvTefC5TQKOa5 6CVs14ZPzs0D901QvOqD5hb0Vve+idStDrq/dlj9F/nPfTIr7k59gAAOLJdIUwu1byLw Q/Ag== X-Gm-Message-State: AOAM5327+nQ0InZNKZ9fn0C4Ba5HEDVcVuUcs4bn/Q4GXSRlmiWGr3l1 YkNiRWRGXc0OR7VatZw7NfnflQ== X-Google-Smtp-Source: ABdhPJzg0KwFLixG8Pstl42rdZ/PTRxkyHAZczqCheTOMrqPGfLT6/zfzGOMo4pLCA8igqbxzHRxPA== X-Received: by 2002:a63:6fc4:0:b0:393:9567:16dc with SMTP id k187-20020a636fc4000000b00393956716dcmr15834959pgc.593.1651629163469; Tue, 03 May 2022 18:52:43 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Gregory Greenman , Eric Dumazet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 08/32] iwlwifi: mvm: Use mem_to_flex_dup() with struct ieee80211_key_conf Date: Tue, 3 May 2022 18:44:17 -0700 Message-Id: <20220504014440.3697851-9-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2437; h=from:subject; bh=kqrSs6qCwh+Lec2OX97eOmuBYGTxbYZO/oveyYvsSyU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqCYob8Le101GWyzNPT8SUQLcWbnMdLaBLnNMKi PFuQ5FWJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHaggAKCRCJcvTf3G3AJrrrD/ 41pLe3vLmy1DT131k402AnWkbvKKTeLHCfdZOZOBG/caJXqmnpOxwil6RAxg5u6hN5hKr+gqoQg3jM PjxMAKOnj4UigmA4/hMbFkpe2UAFQce0nHR1yDX9KirGdKMvnAq1KmeZTOvAK12ubsFuw1otFOoOY9 il9bAkoOcb67DGRv3WnjeBeJAIZesPeob+hkdIGXBLwjDM9HsKNWnS0CO4faN9H2UB5yHtan5AE3fY ejNDT+faux7HktJ5LMXGuFK8hNTMT6DzsBUJMh/VqnJUQfz4J8NZnt1C2fhjm2UKTMJJXaSL2VTIls +E869VhJZmwXhnjNOoXxgs2ypZPdZn7bJMJt9MVXQCWOJ/r5Z4HL//NjQwlMsxa5eN/OtY6fhuJmQa Kt081e3mYWawz+yHoGLyrxfgEVcaxPetNNZbtFWAguSAm+2kDAVJoYtbd1P/PeFNxjV9iclz5KMbsR vfwg2FoAJ4/UE7uv/e9hwMg874lDgZBVxecyw2BfPg0CFqa9KiQ4QmpYRs8HaRBhJQv/jDtfxWqnVh RhanF8E/YIf8Mwjneo+/nQykVNYJP+mnin2t2PXGGQTtyZfdgc4mogRxpnvnUcDOoGAndvfOm8tHL7 lnC6lEffqiIvIoLzddv1Yrb2IU0R/a/tFtHusn7zJ+WlS695vP3r1pDWMDUg== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Luca Coelho Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Johannes Berg Cc: Gregory Greenman Cc: Eric Dumazet Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 8 ++------ include/net/mac80211.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c index 406f0a50a5bf..23cade528dcf 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c @@ -4108,7 +4108,7 @@ int iwl_mvm_add_pasn_sta(struct iwl_mvm *mvm, struct ieee80211_vif *vif, int ret; u16 queue; struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); - struct ieee80211_key_conf *keyconf; + struct ieee80211_key_conf *keyconf = NULL; ret = iwl_mvm_allocate_int_sta(mvm, sta, 0, NL80211_IFTYPE_UNSPECIFIED, @@ -4122,15 +4122,11 @@ int iwl_mvm_add_pasn_sta(struct iwl_mvm *mvm, struct ieee80211_vif *vif, if (ret) goto out; - keyconf = kzalloc(sizeof(*keyconf) + key_len, GFP_KERNEL); - if (!keyconf) { + if (mem_to_flex_dup(&keyconf, key, key_len, GFP_KERNEL)) { ret = -ENOBUFS; goto out; } - keyconf->cipher = cipher; - memcpy(keyconf->key, key, key_len); - keyconf->keylen = key_len; ret = iwl_mvm_send_sta_key(mvm, sta->sta_id, keyconf, false, 0, NULL, 0, 0, true); diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 75880fc70700..4abe52963a96 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -1890,8 +1890,8 @@ struct ieee80211_key_conf { u8 hw_key_idx; s8 keyidx; u16 flags; - u8 keylen; - u8 key[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, keylen); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, key); }; #define IEEE80211_MAX_PN_LEN 16 -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320050.540772 (Exim 4.92) (envelope-from ) id 1nm7NQ-0002PA-Gr; Wed, 04 May 2022 05:16:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320050.540772; Wed, 04 May 2022 05:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NO-0002Eg-6E; Wed, 04 May 2022 05:16:38 +0000 Received: by outflank-mailman (input) for mailman id 320050; Wed, 04 May 2022 01:52:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C6-0008Vf-JM for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:46 +0000 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [2607:f8b0:4864:20::1031]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4237b71-cb4c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:52:45 +0200 (CEST) Received: by mail-pj1-x1031.google.com with SMTP id j8-20020a17090a060800b001cd4fb60dccso27631pjj.2 for ; Tue, 03 May 2022 18:52:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e9-20020a635449000000b003c14af505edsm10931771pgm.5.2022.05.03.18.52.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4237b71-cb4c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tkQJNMDRPVcNM81JGzyx6JZrZP+sXh6Sgsv2ZLlrcME=; b=TYzsMmP+/eI9TqO4+QAx6yxqi3QYWePclkTlbFjhG/HlibMiAybufg/zrz+rLu5OQM GYSNJAX6L87NNLI9qdgxro62vFxqE/fqrqJQw8CwHhp/9rH1kcR4jgxtvHzWUzWEYP1/ vfXC+WsSf1WXNAAHPYjXFPor5Evr5tOPUQrMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tkQJNMDRPVcNM81JGzyx6JZrZP+sXh6Sgsv2ZLlrcME=; b=teeWBQQ84Kzul5EJ8q+ofmCOguqBbxMQw/wixtVs6zyXgj5pd6zbxuJ+T9uWOGAoAR GkbxYQ3K3J+eigjwbmReGhc0GvBB2r5+ie8jCbzK5BABk7w+e6AVf9hUpd6M8XWTOKCo qXlvJxYLDgecA+2zBeS44XwdxWZp3vNB7+wY26owi0ewMQ1n0Hb6VKEmrLIiqH/eUJQ4 JBGEDSfZgjW2U6iCmVQsRkIn4ae2lOkPE99HXnej2TZtsQSHy1OCuZ3mz8HwygMwDwvI hFglt9rJ84qE3ztn+zHlB19pjZscfZTQKVQVAqzmRs9b/8jpo5yIdr6jcQqzgvBSdz0D pCqg== X-Gm-Message-State: AOAM5306iljyPk2qZjiCxGynuwxZdTizXYv5Hy2JYeX5wZuLt0iFerdn l7w7kN/VmCkPxbdPHx3PURA6qA== X-Google-Smtp-Source: ABdhPJw9Mfs8NfMfd0J0YXQIXkiEsTIKgP7m3XPDxYdlVEgqirj/YA+wclSgtM17YB9KKuMWrujLhg== X-Received: by 2002:a17:90a:f405:b0:1da:2640:f171 with SMTP id ch5-20020a17090af40500b001da2640f171mr7788351pjb.245.1651629164213; Tue, 03 May 2022 18:52:44 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Lars-Peter Clausen , =?UTF-8?q?Nuno=20S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Alexei Starovoitov , Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lee Jones , Leon Romanovsky , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 20/32] ASoC: sigmadsp: Use mem_to_flex_dup() with struct sigmadsp_data Date: Tue, 3 May 2022 18:44:29 -0700 Message-Id: <20220504014440.3697851-21-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2019; h=from:subject; bh=6F6KuGFShxf4JxPYrPXKFZeMoWxJdOn30za8QMiNMmc=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqFlVM0+m4mgxXYHmim1KeQeXuOmDGRSbqn4CM/ nO+6V12JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahQAKCRCJcvTf3G3AJlsGD/ wObp4TF0rjxUnDl2XU/AX62Kx0wgUSNaGDsaAeFZLHsspTJNlI1xRmKN2zRi+snj0mrEhw1q9Yh76Z 6xSGswQmdh9uemezB9oVUp2GxxN8WyMWOAR+OlnbPY//H6lChfwlnFARSS1Rkb2ZmcX//rZQZhHCXc svCtT3KSBt+VremyDJs9eQY7zKQWSEjl94vDal0JxS0GbWRYV672gtwgzYHATTiXJfZNK9Hnh5x9cI gP5/UtCpxOgh6ebk6PFJurz7rwB5cHVPIkhz8fgbd1cA/0ybs2wrCYj6JpgihAXuZtV18lAdnt8ND/ zB2f7mC3x32cU4603jCCh3lhtKY74eDhUyxc2qxDVBIyLoOufW0rNL12ZmPb/ZqzHlvwvJRNsgVIeo SLXEWPzSRWl4K2DFX2+37Xle5LxGv8rC5oIP/GCWXKXR98j60QjzBdcMWXTL+hc6sVS7VKBDtIDKQO bT+6D7J9MgSyuvsB8QDDWA1XfDXpj4PrZoT1fpgmZGGO+E9p7LhEd5TGmvmWF4EiqePthKxEq+ytkN iIM2UomARrjFWKhMiO7lt831EjVuWu1bB4+YBjMve73RZhWrYBTG1Fi4daezhQ+AyJvye8gqJgbfNu RIcWAmcfFgGhsp4VDM+sRhA/KybFzkFbvrxBwlwAx/rdq4RJkgf/AFGMfR9g== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Lars-Peter Clausen Cc: "Nuno Sá" Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org Signed-off-by: Kees Cook --- sound/soc/codecs/sigmadsp.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c index b992216aee55..648bdc73c5d9 100644 --- a/sound/soc/codecs/sigmadsp.c +++ b/sound/soc/codecs/sigmadsp.c @@ -42,8 +42,8 @@ struct sigmadsp_data { struct list_head head; uint32_t samplerates; unsigned int addr; - unsigned int length; - uint8_t data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned int, length); + DECLARE_FLEX_ARRAY_ELEMENTS(uint8_t, data); }; struct sigma_fw_chunk { @@ -263,7 +263,7 @@ static int sigma_fw_load_data(struct sigmadsp *sigmadsp, const struct sigma_fw_chunk *chunk, unsigned int length) { const struct sigma_fw_chunk_data *data_chunk; - struct sigmadsp_data *data; + struct sigmadsp_data *data = NULL; if (length <= sizeof(*data_chunk)) return -EINVAL; @@ -272,14 +272,11 @@ static int sigma_fw_load_data(struct sigmadsp *sigmadsp, length -= sizeof(*data_chunk); - data = kzalloc(sizeof(*data) + length, GFP_KERNEL); - if (!data) + if (mem_to_flex_dup(&data, data_chunk->data, length, GFP_KERNEL)) return -ENOMEM; data->addr = le16_to_cpu(data_chunk->addr); - data->length = length; data->samplerates = le32_to_cpu(chunk->samplerates); - memcpy(data->data, data_chunk->data, length); list_add_tail(&data->head, &sigmadsp->data_list); return 0; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320051.540784 (Exim 4.92) (envelope-from ) id 1nm7NS-0002wu-MD; Wed, 04 May 2022 05:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320051.540784; Wed, 04 May 2022 05:16:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NQ-0002k6-Lg; Wed, 04 May 2022 05:16:40 +0000 Received: by outflank-mailman (input) for mailman id 320051; Wed, 04 May 2022 01:52:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C6-0008Vg-Vj for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:47 +0000 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [2607:f8b0:4864:20::52a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4796d04-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:52:46 +0200 (CEST) Received: by mail-pg1-x52a.google.com with SMTP id x12so18421pgj.7 for ; Tue, 03 May 2022 18:52:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c21-20020aa781d5000000b0050dc7628163sm6921886pfn.61.2022.05.03.18.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4796d04-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=szeqM9M0yrMyJS9vcuYR4tTzvEASeBs+sh1JgS4qPAo=; b=SNMym2HDPaFxMLeJFcK68nelvSK8kE0Z3iij6ppE4Nnk5PkLPyihqCWqJWEyxTK+Ad Wlo0fMMZpa7cEJ44ZnUWiYYlbNhSmn3I+2rzPJ3v+90je6UlKRw4Aqz10rVm1pygvoeV KVh5PeFOgavCCRafhGFy8OhJb2FMOsRW4OkVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=szeqM9M0yrMyJS9vcuYR4tTzvEASeBs+sh1JgS4qPAo=; b=3RJUiXYOZN1RyZOgCsuOnxS/1CXfwRanj5YH60A5g1VLQqv2t2GgxfQ4dL92NuIlCv Ktz2SGDh2kB957z0riXO0oajfB2ctF+pWbI1cricYaEUz8o9V0rQcAvzgOMIt7nzcgiQ SVPyCIkmzLd7KXf7oVFgdIHaEY1uMKF3l2Jhcme2OzPSHQk/Q8diU4BBgpFM7a/P9g4i Eco4L0GIMC4U8rHxaVAQ07FhzhwQyxQe/KHU49/qahY6pSHT46ivBh7Y2PSlNGweHUK0 wg7epj65jNQVBkSbmTphkt2yzGIBZ0DQLk7tJRiPv6yKlNCR1/gvbIjdGp950wLJlqGt KtFQ== X-Gm-Message-State: AOAM531r3tdG9PZeRQFXsH0av5AfXPVFf13e/b+Az4ICKkdF95v8aS/2 QMl4AwoJNKGnK6JPKMgCFGop2A== X-Google-Smtp-Source: ABdhPJwdis58CLkd0sjK8SnsRx0Cj4uwRmI1rQtZqa6dArHava5h0MqK56bFRFrLStS8ZAx2UHCkJQ== X-Received: by 2002:a65:614e:0:b0:380:bfd9:d4ea with SMTP id o14-20020a65614e000000b00380bfd9d4eamr15889135pgv.92.1651629164801; Tue, 03 May 2022 18:52:44 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 05/32] brcmfmac: Use mem_to_flex_dup() with struct brcmf_fweh_queue_item Date: Tue, 3 May 2022 18:44:14 -0700 Message-Id: <20220504014440.3697851-6-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2425; h=from:subject; bh=LUlPP0dMftItb3yi/Nge8ZTfomS6k0b5Ud+psHgt9Uk=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqBCnVywLtiCXwEUYb08oAOpk1h97YdS8IXrTwN m34sdVuJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagQAKCRCJcvTf3G3AJokcD/ 944yjyiL4MM2Llyg3BhqwjaPE/1VNwGW9grsHKNIASpW8lInBdW90HjydT+vZ0wCt1VpknFi2upnQI XFtVoH0BT1G9pp4WHMjMMAaSqS3XB0bqdYs4DVvPzTKh5kGr5jX6k9+GTSve/itnWwnYDdM80IlUNt S0IhtkWMACqLlgyqGlt11fTu2Zpj0mRgIVFYh1FPaQRGj+skxj5+tzJqnIxOvBBPtzMq5leG8tzvRp gGF1ADH/0BhWsidIuY5CltVSgionGZ0at33CGy6Yb686fc3WZxfkwUqwKd4kWy0/RHSdYt4O0S9KnY r3h5ztCJtoyE+LsOyQfAjweyIO2LhMxNdieb0lZcJ/4W95rILXttIhcQ8iyf4yAsY69UgQuHPKDcAf nBH2PYzGNfEsEHmEr7bOtF2WG7xXUZXn6gi1luh2tpxiaDAkWSbwC0/Hg4An1+r4RDKB8TaO47Qgsp PG9QvJ1Ej3BAp6hSui4/P+qsMcNSEBBM0dZS2Ro11mi+jDDxK5En0Xgd/el0xn+qwqq+NFNlC0jKcW /QhhJ9GSxPsZzAT51pgi/Q//ZlDNoXI6Xmoho22SXd2se2PmaeWQDnuPK8bWnerpItxcrS1KP5jR9H przw+F/g76E2CP74njdcHJE58D4/zsqYKWbbLWi2QfpgIWTEZ+hV+/A44Ihw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Kalle Valo Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: SHA-cyfmac-dev-list@infineon.com Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- .../net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c index bc3f4e4edcdf..bea798ca6466 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c @@ -32,8 +32,8 @@ struct brcmf_fweh_queue_item { u8 ifidx; u8 ifaddr[ETH_ALEN]; struct brcmf_event_msg_be emsg; - u32 datalen; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, datalen); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; /* @@ -395,7 +395,7 @@ void brcmf_fweh_process_event(struct brcmf_pub *drvr, { enum brcmf_fweh_event_code code; struct brcmf_fweh_info *fweh = &drvr->fweh; - struct brcmf_fweh_queue_item *event; + struct brcmf_fweh_queue_item *event = NULL; void *data; u32 datalen; @@ -414,8 +414,7 @@ void brcmf_fweh_process_event(struct brcmf_pub *drvr, datalen + sizeof(*event_packet) > packet_len) return; - event = kzalloc(sizeof(*event) + datalen, gfp); - if (!event) + if (mem_to_flex_dup(&event, data, datalen, gfp)) return; event->code = code; @@ -423,8 +422,6 @@ void brcmf_fweh_process_event(struct brcmf_pub *drvr, /* use memcpy to get aligned event message */ memcpy(&event->emsg, &event_packet->msg, sizeof(event->emsg)); - memcpy(event->data, data, datalen); - event->datalen = datalen; memcpy(event->ifaddr, event_packet->eth.h_dest, ETH_ALEN); brcmf_fweh_queue_event(fweh, event); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320052.540791 (Exim 4.92) (envelope-from ) id 1nm7NU-0003Vd-RB; Wed, 04 May 2022 05:16:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320052.540791; Wed, 04 May 2022 05:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NT-0003KT-4A; Wed, 04 May 2022 05:16:43 +0000 Received: by outflank-mailman (input) for mailman id 320052; Wed, 04 May 2022 01:52:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C7-0008Vg-Mc for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:47 +0000 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [2607:f8b0:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4826b9c-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:52:46 +0200 (CEST) Received: by mail-pg1-x531.google.com with SMTP id a191so31722pge.2 for ; Tue, 03 May 2022 18:52:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p8-20020a17090ab90800b001d9780b7779sm1993305pjr.15.2022.05.03.18.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4826b9c-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ifZyQ0FGREg3J5AlhSr1XwF8hVhKkYa2p2S/5EeDNQo=; b=oI9BqoXIzDP9CoImflntgKhs0kNacYAtoqQVKtiTaZQIfSzE3upaJIyWSMVlJB9jX5 Uzgry9KW4Gc+1VYbvAKoSW8Y7tDSPleB46+D+uoXs4vfR0muKw9a9urjnLYWGuq+yUxW TpztkzpLBXFj1c/3e7LzufWdk2zzK47xh6GHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ifZyQ0FGREg3J5AlhSr1XwF8hVhKkYa2p2S/5EeDNQo=; b=8OwWXFoCNPioaa+Ou+MczVcYDO4JnP3MXMwex8p2mQCBVVDuOH1LeRX/KuWb2MG9tS ub5F8/R9ZtnKifcq5Du/YhYFroBPmSGvavGbvBuHvxHKkcJQC6Pyp4HucbUchpt6aKcq u53zZjGwEr6fC+o6oBg9Ry9nM388Eq6/z1PpUvRU/KxMES32doN0CqU5umLMZZOp/RBU E2e5KGlQZMoXm4MgKOUOyPcuFSsnol6f9cRaP+kCKhmsz5Y8qNa8l4sygL+k1FrGEL4Z stsYJOL2Vmcu/J4wP9auOw9jVTuCK1XpYqhUdHZ3OVaTPX/tX6L008gyq/lHzcr5I1YX qblA== X-Gm-Message-State: AOAM532T1FCbmrk9Ec6zDHkR7GtfznqGbKjjxvsBXr27S7VoW+VvvVZR C6/ZlR1RcBhCq6XkHB8FHYDXrw== X-Google-Smtp-Source: ABdhPJwZiz3yJY+jd4qKaXewy5LDTdfohDV0JwoDG1EH0nOIyFnsz5yLMaixtkbCgQQyU/bziKLmbA== X-Received: by 2002:a63:48f:0:b0:3ab:3b1f:7e7f with SMTP id 137-20020a63048f000000b003ab3b1f7e7fmr16090583pge.164.1651629164850; Tue, 03 May 2022 18:52:44 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , David Howells , Marc Dionne , linux-afs@lists.infradead.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 19/32] afs: Use mem_to_flex_dup() with struct afs_acl Date: Tue, 3 May 2022 18:44:28 -0700 Message-Id: <20220504014440.3697851-20-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1709; h=from:subject; bh=saaNwrN23mX+OUTBowMD9D5OUm7L78VX128VXuwjwK4=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqFfM0vuwTYMUTv7e3BZX/iyY3njPgklra+Pkd2 Z4Ou11+JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahQAKCRCJcvTf3G3AJnn8D/ 0T93KRcb7qCWTB465n1/YTnsBy2jNLz/U2OLVBzcDFt0AYoA7buN0/1goMxvPhSLi6bjE8UGxc7Fm2 xx2FN5ysX9H/h+AK/cJ3DkHLeBbkc/PToOz1Rhf5ASBW2+V7+qa6CVBSwtSMKSrvj1IM0/N6ioBB18 MCYPkmQ5qhj0A1T1FA5/P3wK+c+Ifo0Yti2zuuDAIo5vSlw/g2lJmCFOlKoVoRmzWGn3UyVXJ9I2UQ xKVYebiH78lPg6s6N8CPVfENvu4vx//FaBlyLvf4NFhRMP18HACQP44Qc0JxstvU7LUJDijflXIFRi grE+kmE6e8bz3l6xfmcLLCVVxLK6kcbN3OPR+1k6kH5962HfiJPZd9T/oRuzkyyoFrBDpqQaKr2g97 9t3Z++vXgvnHcsU1cXdQfiWNAJpoV7p0N66Awn9yJJxP+n2LKF+1g7vkk1gkZ2hlcco2zbVq1FoTnd Kq1+DAU+g1ED0hIHLj9KRfnow47QSvPnc3E3GtLGWqIqKnDHNqPKkcdMSkOm3B6mDT3H0KPxEPrXSQ e1b3nOgGEcTvPf2Pm2gSCNuMfjkK4yrpVG4rvDniz6n+9MLWIpAAWJQjbptVRYhcyt8n75fxNua/sq zBQRxeXk3BLz5v/Hfp5qbE1czFgBcqhDqrr0pErXoP5/DINTx+J9WdEMY0DQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: David Howells Cc: Marc Dionne Cc: linux-afs@lists.infradead.org Signed-off-by: Kees Cook --- fs/afs/internal.h | 4 ++-- fs/afs/xattr.c | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/afs/internal.h b/fs/afs/internal.h index 7a72e9c60423..83014d20b6b3 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h @@ -1125,8 +1125,8 @@ extern bool afs_fs_get_capabilities(struct afs_net *, struct afs_server *, extern void afs_fs_inline_bulk_status(struct afs_operation *); struct afs_acl { - u32 size; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, size); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; extern void afs_fs_fetch_acl(struct afs_operation *); diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c index 7751b0b3f81d..77b3af283d49 100644 --- a/fs/afs/xattr.c +++ b/fs/afs/xattr.c @@ -73,16 +73,13 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler, static bool afs_make_acl(struct afs_operation *op, const void *buffer, size_t size) { - struct afs_acl *acl; + struct afs_acl *acl = NULL; - acl = kmalloc(sizeof(*acl) + size, GFP_KERNEL); - if (!acl) { + if (mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL)) { afs_op_nomem(op); return false; } - acl->size = size; - memcpy(acl->data, buffer, size); op->acl = acl; return true; } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320055.540803 (Exim 4.92) (envelope-from ) id 1nm7NX-00041e-6r; Wed, 04 May 2022 05:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320055.540803; Wed, 04 May 2022 05:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NV-0003tA-Ib; Wed, 04 May 2022 05:16:45 +0000 Received: by outflank-mailman (input) for mailman id 320055; Wed, 04 May 2022 01:52:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C8-0008Vg-My for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:48 +0000 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [2607:f8b0:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e525fab1-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:52:47 +0200 (CEST) Received: by mail-pf1-x432.google.com with SMTP id v11so14983pff.6 for ; Tue, 03 May 2022 18:52:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r1-20020a1709028bc100b0015e8d4eb26dsm7012010plo.183.2022.05.03.18.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e525fab1-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vEhg+UN+nvvIRlNnvIoleDYLxzWI/4j+AXJ2OBahvyQ=; b=E5bLX9p+4KMQ7dCXesW/uSO4Z3TzhqBoNV2cnwQ6UenYFaZTatAXLltuILaNWlnTeH ZPF9bsRL6MA89tW5PvZIMCIKWfhOmFJwJGsxRwJiF9IEfmjgBCchcmHUHUKuUjfJgzaf xdp24lDnEh6QoNKPI3Ft2lTJ+h48bMoBlTL80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vEhg+UN+nvvIRlNnvIoleDYLxzWI/4j+AXJ2OBahvyQ=; b=29ISmw9Yfn8qFDlPlNqQJq8d9BVDIe8VPkdASr7QDA5YBZdhAx5cO5Nq2GsoOAPcIE B7jDxsvkV8bMF7yk9l0RznE/ysHY16/VH3RlNgLpVfH9PY4t+Nxm0YGIhG903/agiFGI EdwtMxFIcdVuzW9pd+iujykeSen5MkJ36RU6Y5bBMJCtnlsOz2rVruivSiNnRVJlZW/x y3fEjzH6pOkTU25nAIzeMZu8lVYfl6OiuXg0jzXQtTiHKV6OK7WXjfuWCjVFHYkcaODB HGsuE5PD5Mq+wIWvwte2Ap92cnHJ7+4bgZPtRA/TRnchqH928QZSsV4vfR5mTyoslws+ TQ8A== X-Gm-Message-State: AOAM532e8ZggLgc4u+5WdLEb9BKRf6vv3c7WgGp9vW19A6FFn+V2WJRA a2nmt597DowBj1cucUbuw5Y5ag== X-Google-Smtp-Source: ABdhPJxoiYBXvCh64QSH6OUY9EQxIRhEKB4uYd5bFmFfjmCLPQJOIMmboo7ZUamkfbJvRXo9YdSApw== X-Received: by 2002:a62:e80d:0:b0:50d:8f8e:ffb8 with SMTP id c13-20020a62e80d000000b0050d8f8effb8mr18591524pfi.37.1651629165912; Tue, 03 May 2022 18:52:45 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Baowen Zheng , Eli Cohen , Louis Peens , Simon Horman , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 17/32] net/flow_offload: Use mem_to_flex_dup() with struct flow_action_cookie Date: Tue, 3 May 2022 18:44:26 -0700 Message-Id: <20220504014440.3697851-18-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1993; h=from:subject; bh=PrKJ7fngslFAVnoAR+kxxSWcyzyvUbqj4Z3UXnDbHJY=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqEQoFbddPpYBIL178hMkYpivETQV90l3JHFEnm 7J1thjCJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahAAKCRCJcvTf3G3AJtw3EA C0LNh89YqDNrcJCXsCKfSbcHlFxrq44D7OA0sCgHExo+fXdaECb+Xj3tfEkQFm9bgvn/VnNhpCwqMV U8VQzGL6UaTCr267IE8XzSzkQJ6Uu2Nn+oM8/g6gDst8U7DsXu/1M4XVa8NK32yL6cBvV8PVBTcChy j8jyHBC43g8+Lg9oLs4UB/SO8Tb2ObCEpGf+h+/rD6v1mUrkoYKhvITvEAQ6BXgJ7NMeKfMd5TbnLL n7fyJaP0DKQoiMbMCMPhOnbaBLKTz9JjJ2/U07j/wfD/U5vjQBmTOZvo7vv3sex/J3PimMP/LVVrgg rZ19XaTiGULGLnmPuJjPt4zppdXAE7bED4queSk/tjdOsuMkougu3osd+yKLNrkqDRGxwMqxHn6Adg VL64IdPA3BY3aE8mOXGUxTLKtJs1pv7lv1msRzE5gUB7RTMHQ1//cIMC8EgdL5FVxZNtm4Nrhurpsb fvUFe8jDSjzE++5RHGWvAqbIheq7tgJhhaDmUF+rUmIMNowlHUeWcz7qDRxFSgMiX+xi/ZX4sJtg/V tnoPJ9uGluYyVnNod6v2TAn0dMpQirNr3BrADN1GRZ9iYaSt2xYRiifwpxLWUpi4DIfHGqb2y4ockX o/g9MpGsEistTYeWgK8HQdvJO+YhqSNADTeBhz9hngLOsUZU3CcUlT8pVg2A== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Baowen Zheng Cc: Eli Cohen Cc: Louis Peens Cc: Simon Horman Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/flow_offload.h | 4 ++-- net/core/flow_offload.c | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index 021778a7e1af..ca5db457a0bc 100644 --- a/include/net/flow_offload.h +++ b/include/net/flow_offload.h @@ -190,8 +190,8 @@ enum flow_action_hw_stats { typedef void (*action_destr)(void *priv); struct flow_action_cookie { - u32 cookie_len; - u8 cookie[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, cookie_len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, cookie); }; struct flow_action_cookie *flow_action_cookie_create(void *data, diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index 73f68d4625f3..e23c8d05b828 100644 --- a/net/core/flow_offload.c +++ b/net/core/flow_offload.c @@ -199,13 +199,10 @@ struct flow_action_cookie *flow_action_cookie_create(void *data, unsigned int len, gfp_t gfp) { - struct flow_action_cookie *cookie; + struct flow_action_cookie *cookie = NULL; - cookie = kmalloc(sizeof(*cookie) + len, gfp); - if (!cookie) + if (mem_to_flex_dup(&cookie, data, len, gfp)) return NULL; - cookie->cookie_len = len; - memcpy(cookie->cookie, data, len); return cookie; } EXPORT_SYMBOL(flow_action_cookie_create); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320059.540809 (Exim 4.92) (envelope-from ) id 1nm7NZ-0004hN-1M; Wed, 04 May 2022 05:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320059.540809; Wed, 04 May 2022 05:16:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7NY-0004Xi-8O; Wed, 04 May 2022 05:16:48 +0000 Received: by outflank-mailman (input) for mailman id 320059; Wed, 04 May 2022 01:52:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4C9-0008Vg-N1 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:52:49 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e50fe268-cb4c-11ec-a406-831a346695d4; Wed, 04 May 2022 03:52:47 +0200 (CEST) Received: by mail-pj1-x1029.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so3943249pju.2 for ; Tue, 03 May 2022 18:52:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e7-20020a62ee07000000b0050dc7628187sm7105368pfi.97.2022.05.03.18.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:52:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e50fe268-cb4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mP4n/1nXKyry8BA7O9b2ZHkrsFy8iWlCifKEx03rFnY=; b=KHTjDn10FYAC4WZ7g7q0AiHpgmThRRwNrbm62hmsBLY/2xCOlkENwcyXQ7aBQDInHn 4dM/qCI2Tdd2RF0pF33RCRgUwHIp4H4DbO/aaCcleZepYJ5vWn77BhvgITsj4rJQjCoy BKAgqDEuTpx8EMb/HQ18TpUE/vAD2m0OUQRDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mP4n/1nXKyry8BA7O9b2ZHkrsFy8iWlCifKEx03rFnY=; b=fU7z56Ocj/QQe4kI6UON0D/Bq0jNirBE2Ov6gJS7EPnFvqXteUHCVzLn5JyJvbMbvf 2vTa/Zy0hEBxm2fn7xxtjS+kReSPXZgtOd68FFGJADHi3/WkbiE7oh4zOYe/HlVhfhiV lv1Ssiph1BZLfvscsPIZQyUi8u40NBkLrXqa5YD1arf48CpCYKP7ZNbRsBmUoHerCEx0 6IVR+qVN4ih3H2x5Tt5ZllbdyBqFtV0lI1218BgSztxJBprQ14ka7S0eNA2p0X5EwHtO Y1msM8cGFOIDHe7ZEb978GSsyhUCvUw+F6IwZjlDQQjSDpCHPlchF6guPNQw8Lcxibfj fAxQ== X-Gm-Message-State: AOAM533iyVEPENtyGi7AdbAF1j1e/WXcaTmXOEPohTrErk1MjaugGlwb dlcul6RZcMDX5nvFnYcBAPDQuQ== X-Google-Smtp-Source: ABdhPJwHKY3hhc2EVCZI7A1dFaYRwqtmSZDSbHAbD6nPuIchK7Q/r3a8yj8NWOtZNQdYaNOSw3r3qA== X-Received: by 2002:a17:902:7049:b0:156:285a:2d64 with SMTP id h9-20020a170902704900b00156285a2d64mr19719385plt.63.1651629165731; Tue, 03 May 2022 18:52:45 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 13/32] mac80211: Use mem_to_flex_dup() with several structs Date: Tue, 3 May 2022 18:44:22 -0700 Message-Id: <20220504014440.3697851-14-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4296; h=from:subject; bh=pufTBCpv1+FASDh6fZcOJeIhSO8YXc6ZD3a299NrZm4=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqDYrX5tu9Go+cvYwIXEOTpZneB8YhW9dUC3sac ck3ML8KJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHagwAKCRCJcvTf3G3AJq+JD/ 0X3AbEhtjv68HS2Qdhx7xmo3K/uONkt1yj8h+vION6AHfDmeZPu5bBaCsLzt2TEAHsBPpBRc/uejYa E5pfehOGAmVM9Fmpr+oP9ly2RkyPTwtNTxFzb4xd27IkVD6UCFORNFDveBYD2VZmO04Vlo9STZ2Bva Ya86oVZEXAhbCZ0AKH2Z49cpjz9VZgyDJ90DrfDKvzm96gavfrOqU0IVXkfUaaZ2QIO1JKI1ll5mvN bjuyTdXnOlMf6CsLwcLHMMb3wDPPpFe8MXv8dayu3NC1pfidvNqoPkozVAiGWacsIqIp8awptGqHH3 yZM3uXcRJhmG01Xnag1yX2F7KLQmdLxTX6Hbi08mVFLjqUHf68oJ6AVzIx7EMO+10VCaS/VKc3pV3a pK6YmhDCo4DAFS2qS/uEZXisfMRLsJ/cNqfILKDs5PJ0Es4D+au1dZbccNyNOsuJKBeugjRZ5yxcT7 MJKOMLVY1PqPEf5qN8rvFBbg71fUmT5dpnBhj5KXWGXisWBxjiXBivh+CA2Ejt0B6LRCEsIE3FDe5W KUS1oA4CkivV4K+FG1LXa3Rjg0Q3XEjfoJZfQnEJWIevZxzJmOPWarLDNgPdL+D9ql+ZHO2xZ2SL6R x2yZO7FnhS+Q3p1vFXul6o0tnRCpX7VXjQMb8yEVgGi33g8kkzRVmWX114lw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying: struct probe_resp struct fils_discovery_data struct unsol_bcast_probe_resp_data Cc: Johannes Berg Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- net/mac80211/cfg.c | 22 ++++++---------------- net/mac80211/ieee80211_i.h | 12 ++++++------ 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index f1d211e61e49..355edbf41707 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -867,20 +867,16 @@ ieee80211_set_probe_resp(struct ieee80211_sub_if_data *sdata, const struct ieee80211_csa_settings *csa, const struct ieee80211_color_change_settings *cca) { - struct probe_resp *new, *old; + struct probe_resp *new = NULL, *old; if (!resp || !resp_len) return 1; old = sdata_dereference(sdata->u.ap.probe_resp, sdata); - new = kzalloc(sizeof(struct probe_resp) + resp_len, GFP_KERNEL); - if (!new) + if (mem_to_flex_dup(&new, resp, resp_len, GFP_KERNEL)) return -ENOMEM; - new->len = resp_len; - memcpy(new->data, resp, resp_len); - if (csa) memcpy(new->cntdwn_counter_offsets, csa->counter_offsets_presp, csa->n_counter_offsets_presp * @@ -898,7 +894,7 @@ ieee80211_set_probe_resp(struct ieee80211_sub_if_data *sdata, static int ieee80211_set_fils_discovery(struct ieee80211_sub_if_data *sdata, struct cfg80211_fils_discovery *params) { - struct fils_discovery_data *new, *old = NULL; + struct fils_discovery_data *new = NULL, *old = NULL; struct ieee80211_fils_discovery *fd; if (!params->tmpl || !params->tmpl_len) @@ -909,11 +905,8 @@ static int ieee80211_set_fils_discovery(struct ieee80211_sub_if_data *sdata, fd->max_interval = params->max_interval; old = sdata_dereference(sdata->u.ap.fils_discovery, sdata); - new = kzalloc(sizeof(*new) + params->tmpl_len, GFP_KERNEL); - if (!new) + if (mem_to_flex_dup(&new, params->tmpl, params->tmpl_len, GFP_KERNEL)) return -ENOMEM; - new->len = params->tmpl_len; - memcpy(new->data, params->tmpl, params->tmpl_len); rcu_assign_pointer(sdata->u.ap.fils_discovery, new); if (old) @@ -926,17 +919,14 @@ static int ieee80211_set_unsol_bcast_probe_resp(struct ieee80211_sub_if_data *sdata, struct cfg80211_unsol_bcast_probe_resp *params) { - struct unsol_bcast_probe_resp_data *new, *old = NULL; + struct unsol_bcast_probe_resp_data *new = NULL, *old = NULL; if (!params->tmpl || !params->tmpl_len) return -EINVAL; old = sdata_dereference(sdata->u.ap.unsol_bcast_probe_resp, sdata); - new = kzalloc(sizeof(*new) + params->tmpl_len, GFP_KERNEL); - if (!new) + if (mem_to_flex_dup(&new, params->tmpl, params->tmpl_len, GFP_KERNEL)) return -ENOMEM; - new->len = params->tmpl_len; - memcpy(new->data, params->tmpl, params->tmpl_len); rcu_assign_pointer(sdata->u.ap.unsol_bcast_probe_resp, new); if (old) diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index d4a7ba4a8202..2e9bbfb12c0d 100644 --- a/net/mac80211/ieee80211_i.h +++ b/net/mac80211/ieee80211_i.h @@ -263,21 +263,21 @@ struct beacon_data { struct probe_resp { struct rcu_head rcu_head; - int len; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); u16 cntdwn_counter_offsets[IEEE80211_MAX_CNTDWN_COUNTERS_NUM]; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; struct fils_discovery_data { struct rcu_head rcu_head; - int len; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; struct unsol_bcast_probe_resp_data { struct rcu_head rcu_head; - int len; - u8 data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); }; struct ps_data { -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320062.540827 (Exim 4.92) (envelope-from ) id 1nm7Nb-0005M1-G1; Wed, 04 May 2022 05:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320062.540827; Wed, 04 May 2022 05:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Na-0005GQ-IV; Wed, 04 May 2022 05:16:50 +0000 Received: by outflank-mailman (input) for mailman id 320062; Wed, 04 May 2022 01:57:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gw-0000D6-Bu for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:46 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96a4330d-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:45 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id n18so178684plg.5 for ; Tue, 03 May 2022 18:57:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g5-20020a17090a7d0500b001d7faf357b7sm2048797pjl.4.2022.05.03.18.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96a4330d-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rbuuZeQPYS/ZqiRJTOL0fJFLrNpJQKS6QwLbS0JMY/Y=; b=Aydv/AU/AZjVEPtiqBONRpzT2Ty39Vvxt2nRw4lRsRTiChjbuH3CBtpVpPkeZSBFK6 zdgmOm2O/OwYN3+guV5vUjUfuHrQcdlBHjoZJkVx9D3VoYUSW8m0vG5AtNFTLXP40SJ0 Ys4mhsjMHxsUEY5V0SeB81DJET0W6jrFHyAsM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rbuuZeQPYS/ZqiRJTOL0fJFLrNpJQKS6QwLbS0JMY/Y=; b=4gCLnUkpUP4jDEm8jzBwwanaD7N1HvZ3Xojdn7nhvG/UNi14gq2mh69zA1KV0LCEXt du43yIu9NmwK/F2Em1sDKslW96q25yfXQuFzjuzJhAhN1+aiZqKNfxKA20NxqiX8o+ON /KneBphI+RBWecUVi2SAW296GH5RKxDzpFO7182IG5wuxhVEVaOZVUdhkoeIUq+LAPEA HSbXj68UhDxBACH7u+ZHLYV1PO3uaCaxHdxyYQvvJqzjLmfc8qNfPGBgduHT5cGL1zfk IVvquRe924/YNYCkYXbntEnoU9wYsk7EknAmPYaKlSXWkhnCx2oW6gufNbegfqgu/8QJ VYvw== X-Gm-Message-State: AOAM531v7wPWSqCNQ0NM1wDSM0atH5OcT0oMb86Gq70Tzef3SrKuZ2H1 +k61gTXxNdmayiwFTaLNUX95Vg== X-Google-Smtp-Source: ABdhPJz6tYNBnWbxdtttDcx79X7XJmalrOAZ2eOiqk6F7AwF/hqWiLs80f73ZpQqflYNA4mYhbV7PA== X-Received: by 2002:a17:90a:bf0a:b0:1db:d98d:7ce9 with SMTP id c10-20020a17090abf0a00b001dbd98d7ce9mr7862640pjs.155.1651629463602; Tue, 03 May 2022 18:57:43 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Steffen Klassert , Herbert Xu , "David S. Miller" , Paul Moore , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Subject: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab Date: Tue, 3 May 2022 18:44:37 -0700 Message-Id: <20220504014440.3697851-29-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3696; h=from:subject; bh=lo77E+k1d7CC41pTHDyzxO7V17zZAZU2RAD4DG2zlf8=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqHYGDosyWmB9LoZ/xyfTluExkJdmxRYXDGGUpK LWQR5yOJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahwAKCRCJcvTf3G3AJtEtD/ 9q7isByvmnLJbF2Mqtm1GQLY5WfrgpLpjGz0wPZPFjTuIQg5cBR9sDT+aFaBgykC00RI3PI08gsS9x JTi9K5ZLLk5xSHCb0CjZKLo+ARF0awusiFxdJwvbSdnvd44xlkRwQcTwLZJVGqr2yqy1jJvW1u/3Yh ZZdqt4uhJJpDu5ukdXw+OwIsu09yrTMufSFBgGUsU5+73BimHVDJD+/bAZBGxLMHaKK06iBuF62hS+ XVkvSjBaytrB7eplhA3FHdoU+z/LeETfQYkjmOeYJe6qC/4XyTzzuTjmlkj3sUYna+gIZzZHw5lCgK e8ZKUtmmyjY5P/B2T6F7kreBUKh5iZLQ2r0VwfwJfpJuk13DSHdvjCQuhl4Gt013zBd9fWhQZJesS5 o9IMVFaMGKiFrS1RpL2iZHNi9XVb32DwtShUKjyeEw7ioOL0wYGhna0Kp6zzMgnwjmSeJYnd7Rpifr zM2tyFEjE6tpop237tnM6UbRdzm3XRg4GDWTpvqG9hsvcQcDOk1Wp2/aCUi8Xgzl8dNl2Fr8PklFs5 z9ZW1ImUkK8q5k+Zy0o0VYflt1WZnHugXEEA8b/AT3xAXNqa3BayfVHOM7lLNNWJLV4rSY9HRRJDtf tRpTY3p7aW3hTdJeb21upjhDTPNqM9cBLjUh0Pb2AymaADYZ1hqLMPlC3M+Q== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying: struct xfrm_sec_ctx struct sidtab_str_cache Cc: Steffen Klassert Cc: Herbert Xu Cc: "David S. Miller" Cc: Paul Moore Cc: Stephen Smalley Cc: Eric Paris Cc: Nick Desaulniers Cc: Xiu Jianfeng Cc: "Christian Göttsche" Cc: netdev@vger.kernel.org Cc: selinux@vger.kernel.org Signed-off-by: Kees Cook --- include/uapi/linux/xfrm.h | 4 ++-- security/selinux/ss/sidtab.c | 9 +++------ security/selinux/xfrm.c | 7 ++----- 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h index 65e13a099b1a..4a6fa2beff6a 100644 --- a/include/uapi/linux/xfrm.h +++ b/include/uapi/linux/xfrm.h @@ -31,9 +31,9 @@ struct xfrm_id { struct xfrm_sec_ctx { __u8 ctx_doi; __u8 ctx_alg; - __u16 ctx_len; + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); __u32 ctx_sid; - char ctx_str[0]; + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); }; /* Security Context Domains of Interpretation */ diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c index a54b8652bfb5..a9d434e8cff7 100644 --- a/security/selinux/ss/sidtab.c +++ b/security/selinux/ss/sidtab.c @@ -23,8 +23,8 @@ struct sidtab_str_cache { struct rcu_head rcu_member; struct list_head lru_member; struct sidtab_entry *parent; - u32 len; - char str[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, len); + DECLARE_FLEX_ARRAY_ELEMENTS(char, str); }; #define index_to_sid(index) ((index) + SECINITSID_NUM + 1) @@ -570,8 +570,7 @@ void sidtab_sid2str_put(struct sidtab *s, struct sidtab_entry *entry, goto out_unlock; } - cache = kmalloc(struct_size(cache, str, str_len), GFP_ATOMIC); - if (!cache) + if (mem_to_flex_dup(&cache, str, str_len, GFP_ATOMIC)) goto out_unlock; if (s->cache_free_slots == 0) { @@ -584,8 +583,6 @@ void sidtab_sid2str_put(struct sidtab *s, struct sidtab_entry *entry, s->cache_free_slots--; } cache->parent = entry; - cache->len = str_len; - memcpy(cache->str, str, str_len); list_add(&cache->lru_member, &s->cache_lru_list); rcu_assign_pointer(entry->cache, cache); diff --git a/security/selinux/xfrm.c b/security/selinux/xfrm.c index c576832febc6..bc7a54bf8f0d 100644 --- a/security/selinux/xfrm.c +++ b/security/selinux/xfrm.c @@ -345,7 +345,7 @@ int selinux_xfrm_state_alloc_acquire(struct xfrm_state *x, struct xfrm_sec_ctx *polsec, u32 secid) { int rc; - struct xfrm_sec_ctx *ctx; + struct xfrm_sec_ctx *ctx = NULL; char *ctx_str = NULL; u32 str_len; @@ -360,8 +360,7 @@ int selinux_xfrm_state_alloc_acquire(struct xfrm_state *x, if (rc) return rc; - ctx = kmalloc(struct_size(ctx, ctx_str, str_len), GFP_ATOMIC); - if (!ctx) { + if (mem_to_flex_dup(&ctx, ctx_str, str_len, GFP_ATOMIC)) { rc = -ENOMEM; goto out; } @@ -369,8 +368,6 @@ int selinux_xfrm_state_alloc_acquire(struct xfrm_state *x, ctx->ctx_doi = XFRM_SC_DOI_LSM; ctx->ctx_alg = XFRM_SC_ALG_SELINUX; ctx->ctx_sid = secid; - ctx->ctx_len = str_len; - memcpy(ctx->ctx_str, ctx_str, str_len); x->security = ctx; atomic_inc(&selinux_xfrm_refcount); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320063.540837 (Exim 4.92) (envelope-from ) id 1nm7Ne-0005sA-5t; Wed, 04 May 2022 05:16:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320063.540837; Wed, 04 May 2022 05:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nc-0005hg-9B; Wed, 04 May 2022 05:16:52 +0000 Received: by outflank-mailman (input) for mailman id 320063; Wed, 04 May 2022 01:57:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gx-0000DU-F7 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:47 +0000 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [2607:f8b0:4864:20::1030]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 975afaa6-cb4d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:57:46 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id r9so16887863pjo.5 for ; Tue, 03 May 2022 18:57:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e13-20020a170903240d00b0015e8d4eb265sm7031136plo.175.2022.05.03.18.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 975afaa6-cb4d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=01xJZEdKekiitPaj8shKdCy94myHgVaNNGs/evnqdOM=; b=SvMNDAvPtTxF809bZoNNzl6o2LENxUqxJ8mipssp3LG3CBJ8QbgPBB5oXpfBBM0oF0 mrxvm9m9xVoCbf+yK4esflyfRaDRIsoJWH6TXY5t/ov9rXMP+/iMpbnHqj0C62OZCoN6 UGJtRe8MarqA1Hj1HXhO/p0X4vXAnV3Tj8zaI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=01xJZEdKekiitPaj8shKdCy94myHgVaNNGs/evnqdOM=; b=m3/1atxdd1Qi+b9mne1pMud3zIFCZD/oXbGMs6NPIS5Hm7FubRRZhs3IJ2Oapok8tP qWQqcrYc5TMPbdcMs8Rv5beutXuC1ZYiRLEb4HjdpQhjJvKbfpfPAofX3ywH4TRz1Fyb Qeg/RImDVFHI4YpqhRsqR7rdbVrUudQKbi1DmUTDV077SE+3PkoIXra3EmPFta6RrOWb LEjCMjsLoTOPr2yjNjagJwMGY/hIZ5e+iXrnzzNBqHIqP4W8qbAj5tHTqeHlta9H4sIb Wpu9NY42FZrJ4673Se32FrBVxkY52PLEb093S1UyOimFFZI0ivNJ6HTsP0JzDzDhtkmv cRHw== X-Gm-Message-State: AOAM530gxQZ4hLvjlW0qey7c1ZjxhfryYNhLufamm1V3UEGb6TaAMGfl iro4ChzX9ySPgJ0FV/vJEELfug== X-Google-Smtp-Source: ABdhPJy/3qlQKz4CGd/TL5fBHV8zpb68+maLc3mzl++Mz3XNXj92dha7r1Tz2gSmcMtLt6kUnUaPzQ== X-Received: by 2002:a17:902:9a4c:b0:158:b6f0:4aa2 with SMTP id x12-20020a1709029a4c00b00158b6f04aa2mr19404150plv.163.1651629464772; Tue, 03 May 2022 18:57:44 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 27/32] KEYS: Use mem_to_flex_dup() with struct user_key_payload Date: Tue, 3 May 2022 18:44:36 -0700 Message-Id: <20220504014440.3697851-28-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2171; h=from:subject; bh=+EMqJweUKHRI+p140UR53z0ouyFfaCeLO7XO6/7BouU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqGhXIUX0opXFG+79dwIKeyeoTVzZjDz3s4gqRG WcoAdoCJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahgAKCRCJcvTf3G3AJpigD/ 9+hUDrqvhbexCJ+LI5xyfbONc0He6AfGv1OpoTuMyM/EDr+8Hlw69lTHvEd33pGAWnTcfLgvPFr5do SNqT7Ky9GohochNniXjI7VRAtZrFkRiG4130PztKwnvQ1ESHLdO+N8oQLoe0xNaVekFqVoLBQkU9ev NHp8YraJs7P1h9w8Pzngx6LtwE4pUvGsFmXmsBhmx5Uk1uiQ2UWzwtYPWYzdgEo1mTJ+BX1FT2/meR Eat9ZR2zS06PJ4uns7jc0qp4FerfBCuZHWMHvuzUrZLKj8YxmjyZPUn166vO9ypE2CX9eBtY3kFi3n EmX0Ryqm38lbokKGz+VyWMmMBepuljd3Kfm8eTAac9jztiqctLEmKqxMqXkQxGfDluj5udRd3fZOOR lag1NSmzJGGy19dHbynOZKZH+nGjFmGobp3C/7rBrswBDkGAbM9kHRt0+D9nPRbomIChQdinr+YNdi taMC+Zbtg73jiBg4SNGk9uXdxHdHcrvUozaxfZNwaBq19qR/CzNl695UzIFzTsoHUgCgp8UNwQOrIX 147/aQi6XAgsy4OrML7xnIyf5cn/Lol5s3J5+7HAqw9FmH4FhWg/atdWEZT71eREnRWKn+j7VQWUSS sH4Cq8R0Hlz39XjL9tHdhH6lg4wbDgAXnwYK6YZ7bEVdBr2fYMufUIc2hMWw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: David Howells Cc: Jarkko Sakkinen Cc: James Morris Cc: "Serge E. Hallyn" Cc: keyrings@vger.kernel.org Cc: linux-security-module@vger.kernel.org Signed-off-by: Kees Cook --- include/keys/user-type.h | 4 ++-- security/keys/user_defined.c | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/keys/user-type.h b/include/keys/user-type.h index 386c31432789..4e67ff902a32 100644 --- a/include/keys/user-type.h +++ b/include/keys/user-type.h @@ -26,8 +26,8 @@ */ struct user_key_payload { struct rcu_head rcu; /* RCU destructor */ - unsigned short datalen; /* length of this data */ - char data[] __aligned(__alignof__(u64)); /* actual data */ + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned short, datalen); + DECLARE_FLEX_ARRAY_ELEMENTS(char, data) __aligned(__alignof__(u64)); }; extern struct key_type key_type_user; diff --git a/security/keys/user_defined.c b/security/keys/user_defined.c index 749e2a4dcb13..2fb84894cdaa 100644 --- a/security/keys/user_defined.c +++ b/security/keys/user_defined.c @@ -58,21 +58,18 @@ EXPORT_SYMBOL_GPL(key_type_logon); */ int user_preparse(struct key_preparsed_payload *prep) { - struct user_key_payload *upayload; + struct user_key_payload *upayload = NULL; size_t datalen = prep->datalen; if (datalen <= 0 || datalen > 32767 || !prep->data) return -EINVAL; - upayload = kmalloc(sizeof(*upayload) + datalen, GFP_KERNEL); - if (!upayload) + if (mem_to_flex_dup(&upayload, prep->data, datalen, GFP_KERNEL)) return -ENOMEM; /* attach the data */ prep->quotalen = datalen; prep->payload.data[0] = upayload; - upayload->datalen = datalen; - memcpy(upayload->data, prep->data, datalen); return 0; } EXPORT_SYMBOL_GPL(user_preparse); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320065.540849 (Exim 4.92) (envelope-from ) id 1nm7Ng-0006Lx-0y; Wed, 04 May 2022 05:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320065.540849; Wed, 04 May 2022 05:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Ne-0006Fv-FL; Wed, 04 May 2022 05:16:54 +0000 Received: by outflank-mailman (input) for mailman id 320065; Wed, 04 May 2022 01:57:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gx-0000D6-J8 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:47 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97a8f23d-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:46 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id d15so185947plh.2 for ; Tue, 03 May 2022 18:57:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v5-20020a655c45000000b003c14af5060asm13495971pgr.34.2022.05.03.18.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97a8f23d-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gAffb2dB7AJw8ctZpf7uy/Kjt0ZfUPuqpFj+O/VUlMc=; b=Hd3jrxU8+XlRdXnNJ6BuxLBWU0ZKLG70m7wHx4jqP+VfQJII0AB4HJY2PvK+TXUYom id9ML06dSBRB1VVnBWjBz+2v5YDaqSJHQM5Ls3McxesxCE+qRmiHqxTVev9Mnq0iPJTj hb0i3oZtBtCUvWZopE6bN0CU7y3IuWgie3Mk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gAffb2dB7AJw8ctZpf7uy/Kjt0ZfUPuqpFj+O/VUlMc=; b=X0K0ptRApAPVcHgdPDOc9hxEelYN8w9131Mj1BmppLuH9tCEN29cvJh+Ku8YHNBTHZ o49rjK8Edpf51YDLoqfJ8f+dLg6lcIqauKWNJWHymf5KMSVd9RvzLvlwfaHBkh57mtxE 7JpQCFybyDIMlJDMBGnXR56HTjc2Wrbpu4FIQIQhZou7ImHtAunupw3FrkyAOmY973jN NwYmiprnimBxReFcDKcfcu7FVPfKXIt2mrMeEOlG/R14naUY6yWrmE+OwNB0NcoFpDxW 5HpZMaOfvVn5Vhg3raO2CFjiprJ2I+D7c1PmWvJjZpYNLiHsV8eqPFc3d1VMQEJ5ORlU yGAg== X-Gm-Message-State: AOAM531WaEJTK/t8F17UgXJuB7P8UhV0agepg+Cmc80s/S7+Bcddj01O Hp3wearHURwld1XZWZiFxShMdw== X-Google-Smtp-Source: ABdhPJz6qaS4+sld6IO764cErbo2AsXw9zqY/8zLJ1brIZKZBC0UJqtHfYq6e8mw4ednkAIXxJWdIQ== X-Received: by 2002:a17:90b:1c8f:b0:1b8:c6dc:ca61 with SMTP id oo15-20020a17090b1c8f00b001b8c6dcca61mr7862141pjb.13.1651629465413; Tue, 03 May 2022 18:57:45 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 24/32] IB/hfi1: Use mem_to_flex_dup() for struct tid_rb_node Date: Tue, 3 May 2022 18:44:33 -0700 Message-Id: <20220504014440.3697851-25-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2597; h=from:subject; bh=j5qqa5iL1lvOORaDlLtm9UR9x0OLEu0XOUmPN1O3Ohg=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqGK+oIIr5PEnTJbsZIIE6wDFvul9czcGBuCOb4 OJUbtUyJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahgAKCRCJcvTf3G3AJlPpD/ 0VwfEZeptxhwXvC03S8kaKbVzD8jf4H7HBP2WwjQ4ovXcZoeEPoHk43gm5ko9ZHxsEuhVYfSsNabEv KwzfkX+Be0SZ1mudTtAQCrxBnFPmMKxMszwt9mMNZtm6E/XnP2w7B2+1rA358f0MYJXzvFe7/kn3VU 5iBgnGpNGOZgXOG+jBcjTyiKQiMSXDSUp0cIXvVQpsePyQMfJGh/eu5bFCRNrwstStCte4Ow73c4Va IaWYSGyLDy4kuX78W5f19yAQR3uD4X1ryr/AVwZV0/P/jnJmz5EmCKU1qFe2YNVe7kF2+3nxmDxawo cvJJ0SuVsX0ZNg8KDkjZEG/9wBeWjiXSyoD0G6pP/WshlZoegMuvye4fFyhyKmatyVqt3t8c7FD223 F60swFGSkgfSg6J4GMTvGe3/d8QAl3MTq2ZH18n8DlcYgMk+3J2vMunZUU58h8auD6hXcni1nXgoMb GZApmHHYK5s4Fqge2j1uqJVBjHZOX3fK3YaZhKtoTqm6FUuJw+H1P3nVYfkcXshsd8t27NuIM2hLa9 jZnMgeaYhLQAUUWWjOKVskE6/+GP5gz4+qjVUI/Alev5kHFOWsbWXBC5JGCSrGBZtpMfJqMcYVqTxZ tS3tgiujwVPsRJdYvH3X2NotOyhjEtEFR8egS3/g8M+hET9UITd8x/6NqLnw== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Dennis Dalessandro Cc: Jason Gunthorpe Cc: Leon Romanovsky Cc: linux-rdma@vger.kernel.org Signed-off-by: Kees Cook --- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 7 ++----- drivers/infiniband/hw/hfi1/user_exp_rcv.h | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index 186d30291260..f14846662ac9 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -683,7 +683,7 @@ static int set_rcvarray_entry(struct hfi1_filedata *fd, { int ret; struct hfi1_ctxtdata *uctxt = fd->uctxt; - struct tid_rb_node *node; + struct tid_rb_node *node = NULL; struct hfi1_devdata *dd = uctxt->dd; dma_addr_t phys; struct page **pages = tbuf->pages + pageidx; @@ -692,8 +692,7 @@ static int set_rcvarray_entry(struct hfi1_filedata *fd, * Allocate the node first so we can handle a potential * failure before we've programmed anything. */ - node = kzalloc(struct_size(node, pages, npages), GFP_KERNEL); - if (!node) + if (mem_to_flex_dup(&node, pages, npages, GFP_KERNEL)) return -ENOMEM; phys = dma_map_single(&dd->pcidev->dev, __va(page_to_phys(pages[0])), @@ -707,12 +706,10 @@ static int set_rcvarray_entry(struct hfi1_filedata *fd, node->fdata = fd; node->phys = page_to_phys(pages[0]); - node->npages = npages; node->rcventry = rcventry; node->dma_addr = phys; node->grp = grp; node->freed = false; - memcpy(node->pages, pages, flex_array_size(node, pages, npages)); if (fd->use_mn) { ret = mmu_interval_notifier_insert( diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.h b/drivers/infiniband/hw/hfi1/user_exp_rcv.h index 8c53e416bf84..4be3446c4d25 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.h +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.h @@ -32,8 +32,8 @@ struct tid_rb_node { u32 rcventry; dma_addr_t dma_addr; bool freed; - unsigned int npages; - struct page *pages[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned int, npages); + DECLARE_FLEX_ARRAY_ELEMENTS(struct page *, pages); }; static inline int num_user_pages(unsigned long addr, -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320066.540857 (Exim 4.92) (envelope-from ) id 1nm7Ni-0006vs-0t; Wed, 04 May 2022 05:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320066.540857; Wed, 04 May 2022 05:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Ng-0006ic-Re; Wed, 04 May 2022 05:16:56 +0000 Received: by outflank-mailman (input) for mailman id 320066; Wed, 04 May 2022 01:57:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gy-0000D6-4l for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:48 +0000 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [2607:f8b0:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97d10802-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:47 +0200 (CEST) Received: by mail-pg1-x52c.google.com with SMTP id q76so17156pgq.10 for ; Tue, 03 May 2022 18:57:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r7-20020a17090b050700b001d2bff34228sm2042759pjz.9.2022.05.03.18.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97d10802-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RgEz4A26uAC0tPMSdTdWzcdcPMkc9MyjUZa57zGhp5c=; b=THMBXiotwI/HtB6w2vZ4AUJ2BjQh4hIPsHX7+RZwOa1PHLlgiT/9TXJjWzKZ2YkERx +jSME8ruQzJrkosl9qqzWHjBRc3gpjhe8YYA4SgiQV2fs5uQIJ4ItuKhnxn0qRtTRwig 4dauL4e9jCHwc/wxp5WYhLqZAsMtRYdbGk0Nk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RgEz4A26uAC0tPMSdTdWzcdcPMkc9MyjUZa57zGhp5c=; b=S2XqLAnEbRCfqktg0Rp5aXYKSpAFcWx/a8iE2v0Tto1DHBo6xajBt6hZJTYbA5K/YP kJyrole7JHZsr8A1d7LJGtv+7JhEEBExXsuLOjqdZST9XMD7lyam3pqeD1vRa1WOe0Bi JBfTcTMIiHZlLcZT/kNfRaXyopot6DG9JSOwYObFgInO3vltEc7TygobJKxtcSNZnq61 P7vPE2SWtTd19eSCItq8lUlRsZpgW3104RKe3OzzCNEY0No8/5lMw24VmAihJdA7H8e1 0gDXA1wSKyx/y7ce5eJcNqPOQ9AWzmBBsFGiJ8Lbg4U0rMip/JS5MICjKhrJXcRRKRXj 3ANQ== X-Gm-Message-State: AOAM532m9TWL14aNCHOGrkuqkYF9awV7ngOIKXhEyS/iuFXmIyEV47Wm w65JKBxKatdSHP8bA8xZ9sxe0A== X-Google-Smtp-Source: ABdhPJy/mXnQX0lzKSCAqZ5j/o4PSwRGlEpcGdLSsNwTNiJ+5ZDPNEMrqd4G6zPJoCRhzNbxNPSiag== X-Received: by 2002:a65:6e8f:0:b0:3c1:c903:e5fe with SMTP id bm15-20020a656e8f000000b003c1c903e5femr6684833pgb.424.1651629465609; Tue, 03 May 2022 18:57:45 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 26/32] ima: Use mem_to_flex_dup() with struct modsig Date: Tue, 3 May 2022 18:44:35 -0700 Message-Id: <20220504014440.3697851-27-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2212; h=from:subject; bh=0OJGwcsHhKZ90NmLpvzscbvuHwuTm4ffAc9aRODTTVY=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqG62vfnuT12WKQv0IVuyRZyZzMX4U3Y+bYmap0 sx6VNCCJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahgAKCRCJcvTf3G3AJp8HEA CsjdGpDagpIubOZwh4SIwzLI0mQ71SVDOmeVgjaMH3wCaEUbVyUbQcZCwMkSSQkmaYi0JHdt186r90 KEdAes66ANgHJSwIbVxb19utRynHoJDFwO5gfVuTp2sVSu0AKP3KnJZajTXsyucbZynSVAJNanMloi v43qXD0nlRXkU0gX5ADpraYNTEc4DmC1I4QdBks60+U4wHFdhcjQvwo5U7V+5dzuva3RK7ldVtXJrB VeE5PpJQ5Xc1tmru3dEvFHv9MKipcoi+cf2u17BgJcgfDnUcb/oIr/jZVk1w2GF8Ilp5rtUyr0DM8m Na/yIL9jeaPARJok7fgLZP9afaRB6ZwWwE4H2uMjCy1cT6gasjHiZsGre3gXlWVcsFQqLjohy6kCxW rBj7pLN4d++yrxKprYmKAt3zeatf5EMTvrLIgqFUOrk/sAwpHwlXmgGTkAeWNhT8J5VVKpaeshrS8f gKI9RgmhD5seOLoAZLEOSns1PPAdryQb5THkD3O+72gLN08L6etoAPODJ68wd7fcwq7Wg5n5/+AkF2 1jkeaI8b1sgNrwkPOtdnKDQm4yxesI//AmfFdH7EEjbVd52gAVu+rbz7yhcBh1dHRczes2IJW3soaR v4zCatjhXz33SY1+Zru2qRrDvhgaoAqzqRxMbwi9eNYoszXDTRyDKQ8NgEFg== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Mimi Zohar Cc: Dmitry Kasatkin Cc: James Morris Cc: "Serge E. Hallyn" Cc: linux-integrity@vger.kernel.org Cc: linux-security-module@vger.kernel.org Signed-off-by: Kees Cook --- security/integrity/ima/ima_modsig.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/security/integrity/ima/ima_modsig.c b/security/integrity/ima/ima_modsig.c index fb25723c65bc..200c080d36de 100644 --- a/security/integrity/ima/ima_modsig.c +++ b/security/integrity/ima/ima_modsig.c @@ -28,8 +28,8 @@ struct modsig { * This is what will go to the measurement list if the template requires * storing the signature. */ - int raw_pkcs7_len; - u8 raw_pkcs7[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, raw_pkcs7_len); + DECLARE_FLEX_ARRAY_ELEMENTS(u8, raw_pkcs7); }; /* @@ -42,7 +42,7 @@ int ima_read_modsig(enum ima_hooks func, const void *buf, loff_t buf_len, { const size_t marker_len = strlen(MODULE_SIG_STRING); const struct module_signature *sig; - struct modsig *hdr; + struct modsig *hdr = NULL; size_t sig_len; const void *p; int rc; @@ -65,8 +65,7 @@ int ima_read_modsig(enum ima_hooks func, const void *buf, loff_t buf_len, buf_len -= sig_len + sizeof(*sig); /* Allocate sig_len additional bytes to hold the raw PKCS#7 data. */ - hdr = kzalloc(sizeof(*hdr) + sig_len, GFP_KERNEL); - if (!hdr) + if (mem_to_flex_dup(&hdr, buf + buf_len, sig_len, GFP_KERNEL)) return -ENOMEM; hdr->pkcs7_msg = pkcs7_parse_message(buf + buf_len, sig_len); @@ -76,9 +75,6 @@ int ima_read_modsig(enum ima_hooks func, const void *buf, loff_t buf_len, return rc; } - memcpy(hdr->raw_pkcs7, buf + buf_len, sig_len); - hdr->raw_pkcs7_len = sig_len; - /* We don't know the hash algorithm yet. */ hdr->hash_algo = HASH_ALGO__LAST; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320067.540865 (Exim 4.92) (envelope-from ) id 1nm7Nk-0007Si-2Z; Wed, 04 May 2022 05:17:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320067.540865; Wed, 04 May 2022 05:16:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Ni-0007K0-RZ; Wed, 04 May 2022 05:16:58 +0000 Received: by outflank-mailman (input) for mailman id 320067; Wed, 04 May 2022 01:57:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gy-0000DU-Id for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:48 +0000 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [2607:f8b0:4864:20::633]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98157bd0-cb4d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:57:47 +0200 (CEST) Received: by mail-pl1-x633.google.com with SMTP id d15so185970plh.2 for ; Tue, 03 May 2022 18:57:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c136-20020a63358e000000b003c14af5063bsm13937195pga.83.2022.05.03.18.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98157bd0-cb4d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rmxrp/UxOFb8piH92Vxf3rNJk8bX2cfzoG0Wa8qHsPs=; b=M/yQls1bpyaiOjU76efK5Yp3KeWPaKFU4zmgVp0hnDPVEvcbG0Yr2VZsk9GtUI6EW2 P3x8PrWJUASQzTlrmV7uEWLEbManT0y+Zg+pt3XuYEBjyOBd/MkDra9+mVvndIuuMdNV ADaMqJRFecvzQ2p2BbgcShyTVJWmeZm5rse6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rmxrp/UxOFb8piH92Vxf3rNJk8bX2cfzoG0Wa8qHsPs=; b=ERZBBA4T2e+lSiNt3oxi11fhKzxhUgQPUS2jxCKUlfMe/u+bWQ6YIM4pGsT8/gZ9B2 W9kqLAdkZ4V6oCMXpzrhzgnNbaY5+Hokvep1bo3jcrCNtTUFcFss/ichGWA6cbg4/jNt ufZikIfgtJ0N3zghfrJdIGCuwbzWqAoTbUsnzOCAUwcnU4QNE1PuNWbP5ZceEEJetlHG g48rT0logPfN4iRsiFx8xk1LUErM8d9+d06OvbOMPw2m1gBfHj19OPKg0kYKw6sL7jIz bEvK/TtadS9ROyW+apylnQCDxko/NQgssjjS240Pz+btlOkQJkeFMn3fOo6KIISQ+x/h 3T0g== X-Gm-Message-State: AOAM532UbviZdt7vWZsvRKeeCy8hvv7d0WErfSP7TquIcwUa4ptJ+xFH JP4JhhtjcuIlqS80TtN0PQOw/w== X-Google-Smtp-Source: ABdhPJzsaAMZFIEH9aJDz9g66+jgdQsHq+yoVh8YzAJHoTu87D8ChQb63hX2VO7VJEySpHJexGyYWQ== X-Received: by 2002:a17:903:2350:b0:15e:93de:763a with SMTP id c16-20020a170903235000b0015e93de763amr16789834plh.117.1651629466084; Tue, 03 May 2022 18:57:46 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Bradley Grove , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 32/32] esas2r: Use __mem_to_flex() with struct atto_ioctl Date: Tue, 3 May 2022 18:44:41 -0700 Message-Id: <20220504014440.3697851-33-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1840; h=from:subject; bh=wclXkCNzL8tWkFiLRsyBirHZGs1pS2ud8xMfF2Bbgys=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqIM8CXiBVoq1vvnq9rbFmtFRUsN4irOoYa4gS1 0IJEQ2KJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHaiAAKCRCJcvTf3G3AJgOdD/ sEBkA9QLnBKc64IqIq4YxEg4VNWAmPZGOznytqC/Owjod/71puJ/xtUz+R2WjO80ATXotNqfvtWe/d 9/yCjwl54Xp//OjYlRlQVLKBx2Q11FBqi4MBsooAiVirzGDDTHxmU1iuq6Wz2ZIdZlghDO60VBIerY f7y/tG7dD7LIfF4hLq69yeIQaG4gx8rz9gY1ntSTDKIZg+3A+cCuG7GHCLE4hzM9XcCNdcjNHkLLzM U6m0NaS7W7NFnR0mxnwloGXZVChfb884A/O/wC2lhgRNoxndIkrhF+x2NIhSvpQQmje9R235snuAfX mTZgHUaiYXSuSt8YrUbWAYgqP95oux1CHcGbFo6OSfvzri3R22Sizw6iJPckU4HcHFbxLD7v2eEMVp 3ECGtyv2+WAG63yJy/2YJm4mTGZKQM9ZC/lL6nR/U6EYIjrevoE7kTnSKMDTU+PS27rxgE+Rh1Hg9K ipwZmZh4bV/Xed50s1aJAocNChxua0lDl5jjP3QaZBpQGTlt8ls0YY8i1DswPFLAiSj88j/CGJOPOK +82q4/Et8Wn6QjhXmaRuef6bFcOHFRRdfpp1PZEOD91CPvnpq0Q9e/WXiAbsnkg/diZHdL5A9LVD0O L6xVqhkIsupraaLBcdxfoyPChtyfc0T1x/f55UeM/J7IkMaJAzAUEKGWn+Gg== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. This requires adding the flexible array explicitly. Cc: Bradley Grove Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Kees Cook --- drivers/scsi/esas2r/atioctl.h | 1 + drivers/scsi/esas2r/esas2r_ioctl.c | 11 +++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/esas2r/atioctl.h b/drivers/scsi/esas2r/atioctl.h index ff2ad9b38575..dd3437412ffc 100644 --- a/drivers/scsi/esas2r/atioctl.h +++ b/drivers/scsi/esas2r/atioctl.h @@ -831,6 +831,7 @@ struct __packed atto_hba_trace { u32 total_length; u32 trace_mask; u8 reserved2[48]; + u8 contents[]; }; #define ATTO_FUNC_SCSI_PASS_THRU 0x04 diff --git a/drivers/scsi/esas2r/esas2r_ioctl.c b/drivers/scsi/esas2r/esas2r_ioctl.c index 08f4e43c7d9e..9310b54b1575 100644 --- a/drivers/scsi/esas2r/esas2r_ioctl.c +++ b/drivers/scsi/esas2r/esas2r_ioctl.c @@ -947,11 +947,14 @@ static int hba_ioctl_callback(struct esas2r_adapter *a, break; } - memcpy(trc + 1, - a->fw_coredump_buff + offset, - len); + if (__mem_to_flex(hi, data.trace.contents, + data_length, + a->fw_coredump_buff + offset, + len)) { + hi->status = ATTO_STS_INV_FUNC; + break; + } - hi->data_length = len; } else if (trc->trace_func == ATTO_TRC_TF_RESET) { memset(a->fw_coredump_buff, 0, ESAS2R_FWCOREDUMP_SZ); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320069.540879 (Exim 4.92) (envelope-from ) id 1nm7Nm-0007vX-Dd; Wed, 04 May 2022 05:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320069.540879; Wed, 04 May 2022 05:17:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nk-0007lY-U8; Wed, 04 May 2022 05:17:00 +0000 Received: by outflank-mailman (input) for mailman id 320069; Wed, 04 May 2022 01:57:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4Gz-0000D6-4r for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:49 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97dff336-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:47 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id a15-20020a17090ad80f00b001dc2e23ad84so3926618pjv.4 for ; Tue, 03 May 2022 18:57:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g13-20020a170902c38d00b0015e8d4eb1efsm6956799plg.57.2022.05.03.18.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97dff336-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hCvG0k88HO9y5mV8jIlfDaOoiV0I/JnHiEgOfadNreI=; b=nTykdqnni29IYFP/aKlZ1tz+wSZFndNhf6nwtWAlZtsI1+zfxgtaBvH+tz4Jq/XHTo 7HJGSNs/F64gdmokeo6uSP6KePJfQuFps/a+uVb9CQhG7Wm+ptt1Wr19Dv7sboM4E5DX 5fllnhK611XRrQM46REzeI6j7l3nMzBYK6UHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hCvG0k88HO9y5mV8jIlfDaOoiV0I/JnHiEgOfadNreI=; b=brNgfaaCL7He9Owu/9/fUGSWn8KCFVdzHINdxZPyvKW2RztN60wTMzTYA9K9neWUBZ UrPqHP0x3wFSIDouuPuF+MawWb+J999GUskos8pMCPWVQB3rj40TwtGZUtTqN3m3XuFO umwppx1em2pGomI9l7BlkZ3MvNOgRwnyeVq8BqrTvxAGzlKwk6M8iUWAho/abEN9uvLY 012KS/UsEWOw3eLxuTA32qcqKhKB19n4ZE975hBukPP0U4Ff/oZdJR7YOhPRF8zucREX gNs85c8WQp+NJ2KV2nMh/0InA37BAl7kOXuIje9vcn4PZAfvfX5mArERQ6RPXES6a9Ip c7ew== X-Gm-Message-State: AOAM5302AlPtotpIUwVmd//FtXmkR9hy3GhhqtEb/y+8KJ+KA9RgPWzS dlEgmru50BRpilyP6GIPxtxZEw== X-Google-Smtp-Source: ABdhPJy/xxcAxGHu6MAf8PWivCJIfByxF3Ri1FspSsyk9y0AdnFFlTGxMLPZluu1QVnfA2Jry7j06A== X-Received: by 2002:a17:90a:343:b0:1cb:234a:a975 with SMTP id 3-20020a17090a034300b001cb234aa975mr7933650pjf.83.1651629465679; Tue, 03 May 2022 18:57:45 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yang Yingliang , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng Subject: [PATCH 16/32] 802/mrp: Use mem_to_flex_dup() with struct mrp_attr Date: Tue, 3 May 2022 18:44:25 -0700 Message-Id: <20220504014440.3697851-17-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1997; h=from:subject; bh=OvOiYjzm/q6KNaMl+//jdZvtdGx65Whv0+J0OvbhHK4=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqE83ulc8i1Me+2H60c4+E7txzeLZOhw3piKY/N AW6WeVaJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahAAKCRCJcvTf3G3AJhJeD/ oCosU8dkvX3qhHC1w07Zs/6TYmI5gdPsPSk8ZM0TFXbvewK/h3P8F3y3Nj710vMoVm4HKj2kaEgTOk 2f2b5GE4O8jpZqRExVAK8Rw2Cf/+lieahxnXSaeHUcCSE5w7f3XjMdbU5lVFfxvOwj5yiCJ8AmC0h6 PKlej2yANnnifLBAy1vCwATP2HMjRoJK8z8V8EPZWY5Ak8cwN5N+W8aRpKReFLT56NqrSMNdex1APu dJQyH++TBuJBuyERb/vZdPxaz6qQCAzya/hpIBykyOqwSpa+BuzC5eaQePNcGDlTxES1vpgiLcnpCY ylYUXLQ+/MEaj/+FNFhQb44VMXSJW6mBxFuV9yP0MGuTLCFYQ2tjlsr0dWXoGDaFAaazyGNVjsWTdX POY6oata9LsQMBKZIVM5ROcKCdIv711ZQR5lFNVAIwLL/QUuyvkWtdQwSvdywSC8oK7xwBWlABXbox I9fjkKMnE1RYapMRtAmf2VKQ0RghvNMYTAPgLGO7OYoWbeGSQ2hIfI655r9udNZNdyoNBAjzqo0qLR QOmey3V+dlX3CiVaAbQTmtt3Nc5u/EhyJdE/xxV8TqqMA3btOXCemNQBKKIif6kQD22YoS7IRqY0J5 q1bRyY9izDrZQAwPOQpXq88UsmOMBlUHokCiJyT9thFEfc5wcLBU5JMv7gIA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Yang Yingliang Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/mrp.h | 4 ++-- net/802/mrp.c | 9 +++------ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/include/net/mrp.h b/include/net/mrp.h index 1c308c034e1a..211670bb46f2 100644 --- a/include/net/mrp.h +++ b/include/net/mrp.h @@ -91,8 +91,8 @@ struct mrp_attr { struct rb_node node; enum mrp_applicant_state state; u8 type; - u8 len; - unsigned char value[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, len); + DECLARE_FLEX_ARRAY_ELEMENTS(unsigned char, value); }; enum mrp_applications { diff --git a/net/802/mrp.c b/net/802/mrp.c index 35e04cc5390c..8b9b2e685a42 100644 --- a/net/802/mrp.c +++ b/net/802/mrp.c @@ -257,7 +257,7 @@ static struct mrp_attr *mrp_attr_create(struct mrp_applicant *app, const void *value, u8 len, u8 type) { struct rb_node *parent = NULL, **p = &app->mad.rb_node; - struct mrp_attr *attr; + struct mrp_attr *attr = NULL; int d; while (*p) { @@ -273,13 +273,10 @@ static struct mrp_attr *mrp_attr_create(struct mrp_applicant *app, return attr; } } - attr = kmalloc(sizeof(*attr) + len, GFP_ATOMIC); - if (!attr) - return attr; + if (mem_to_flex_dup(&attr, value, len, GFP_ATOMIC)) + return NULL; attr->state = MRP_APPLICANT_VO; attr->type = type; - attr->len = len; - memcpy(attr->value, value, len); rb_link_node(&attr->node, parent, p); rb_insert_color(&attr->node, &app->mad); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320073.540890 (Exim 4.92) (envelope-from ) id 1nm7No-0008Vb-Mp; Wed, 04 May 2022 05:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320073.540890; Wed, 04 May 2022 05:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nm-0008Mf-UM; Wed, 04 May 2022 05:17:02 +0000 Received: by outflank-mailman (input) for mailman id 320073; Wed, 04 May 2022 01:57:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4H0-0000D6-4v for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:50 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 986eb06b-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:48 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id cu23-20020a17090afa9700b001d98d8e53b7so3028087pjb.0 for ; Tue, 03 May 2022 18:57:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h3-20020a17090a2ec300b001cd4989ff50sm2000264pjs.23.2022.05.03.18.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 986eb06b-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lxy/SBBLbAnketd1perUQv/dnI2mQxvvkPs8DufKeQc=; b=i0Oww6FXAlmLjZL2Xo7+cZyQbZSuVhJcrUz8A4NqwsB3mnE9GxrQbFM3pG+OqIOvr/ bRoZsADS+tsQKhBZ6qjjGQ8wPq6NgM7w5LLDy+9US9EqrP5Wl9gOulV8iAxG2VM68w2h ys5/rKlySYl9/8SCzquZGEIldbBkfJX1v+C7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lxy/SBBLbAnketd1perUQv/dnI2mQxvvkPs8DufKeQc=; b=EdVd9xBsBghjWCO/6BEus3D5/GlqaJufiu6wXcOo8Ccquewd8q54Rj1veXpQOkts0l OjmUYkKbRJEce0HFhgKmzs/BA16KuDn6DZo4fvUB0F/YS1KAkaLnTPqD+XzhhlJRWRSb 3zJ0Z1QqG/dpVwGfTcYJzmOU5evz1uTs5f28wjPQkrDp2Bv8MjRu7ckq41xtVy6mPDnc ARthPSifuN7OHlVTGXBC0ML0F4x9DjAQUfDAmLz8Z21EGb3SMdaYPGj+voNDzWPs/5wl wWtLjtfNso4oW4DXBSL21tboFHKE6DL3RKg2mZPsZUOnWnmj2naKTuM7GN/5F3fhUZBs TFjA== X-Gm-Message-State: AOAM530EFvac6KvlJ+5uV7Zd1iRGA0fM5zhrWclEclH8ehb7nYvtZPwI UwkL6SuzVLgKUt+WscSyENj7zQ== X-Google-Smtp-Source: ABdhPJwkCJiyloqnUC98ULA8VGwgD2gCblOMTFYJlDNNyWPyHvD0nLQtaW1YAKVPNQXc+1bJk4N22Q== X-Received: by 2002:a17:903:2281:b0:15e:95f7:37d1 with SMTP id b1-20020a170903228100b0015e95f737d1mr16432450plh.18.1651629466697; Tue, 03 May 2022 18:57:46 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , Xiu Jianfeng , Yang Yingliang Subject: [PATCH 31/32] xenbus: Use mem_to_flex_dup() with struct read_buffer Date: Tue, 3 May 2022 18:44:40 -0700 Message-Id: <20220504014440.3697851-32-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1723; h=from:subject; bh=Af40/wtrXz82sQZ3gkXc9sqO1MKE/dCxzKzVkZCyPBE=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqH+KXwBf+62Kz/ptxhFXwkt9WosiEBHko2iuOB 0fcNum2JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahwAKCRCJcvTf3G3AJvLPD/ 9BhjziZJhS9xD2GsjrelNYz/xp7Z6XtKNgFRofwy/p+e4IFCpDHMNYQmpP3WVjlkD9FyouGOGLk+Sf 0i6cJgn02GGl9DKJH1kqxbUikzY6c8wzuc6v3W7+teBaTIZXxJ4Bg0xxroKqmZVZTUvN34ouMFIb2p ++rnq2J7531VZeebMPx+6kezaUVTaUGe1VFKBUuccT4/6mp2R8HqzWVgmSai8ZyNi4Z0nnObREm+rJ u1d6VjniOCRmOGgG7QCuuF+cUE4d+Isa6moThhkOv0m//DMJYGT/djpuk6W+kWlcJs+nrsoX1AByJu zD1O0Fk/hh4ooTDaA3lQmWtVq+gJIaYvCBILFRlDcGFC0oo/EM3wXTGcFGjgMgTNiEXK62PdLF9dZf kRieucxaOIdVPYz+BN9o4ps+oSWfIYaQYOYAOwTAA01RA6l3cElUd3dfgBE1lOqQNUDIkcTD8rOm+l 8JdhxGwQaeetRebI0mGQru7qvbnW4s+raN3cR8JtJ36LlEBzqobHNRhVRK3K2dZQhOPhKgr3OWpCOE anL307TAv51pZ7CNDf9iEaZPdoVXALMDtkTpnwemX7C4Lc94fH0b/AmlH5YOCpb8DGFa9BJnGzvzbc FPmLrSOPa5hu9l1uVEcpEaQHDzIfRLtxISX0mmsQ1VLswRk+mwBJcKd8a+7w== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org Signed-off-by: Kees Cook --- drivers/xen/xenbus/xenbus_dev_frontend.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index 597af455a522..4267aaef33fb 100644 --- a/drivers/xen/xenbus/xenbus_dev_frontend.c +++ b/drivers/xen/xenbus/xenbus_dev_frontend.c @@ -81,8 +81,8 @@ struct xenbus_transaction_holder { struct read_buffer { struct list_head list; unsigned int cons; - unsigned int len; - char msg[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned int, len); + DECLARE_FLEX_ARRAY_ELEMENTS(char, msg); }; struct xenbus_file_priv { @@ -188,21 +188,17 @@ static ssize_t xenbus_file_read(struct file *filp, */ static int queue_reply(struct list_head *queue, const void *data, size_t len) { - struct read_buffer *rb; + struct read_buffer *rb = NULL; if (len == 0) return 0; if (len > XENSTORE_PAYLOAD_MAX) return -EINVAL; - rb = kmalloc(sizeof(*rb) + len, GFP_KERNEL); - if (rb == NULL) + if (mem_to_flex_dup(&rb, data, len, GFP_KERNEL)) return -ENOMEM; rb->cons = 0; - rb->len = len; - - memcpy(rb->msg, data, len); list_add_tail(&rb->list, queue); return 0; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320074.540901 (Exim 4.92) (envelope-from ) id 1nm7Nq-0000aq-KD; Wed, 04 May 2022 05:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320074.540901; Wed, 04 May 2022 05:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Np-0000Ts-7S; Wed, 04 May 2022 05:17:05 +0000 Received: by outflank-mailman (input) for mailman id 320074; Wed, 04 May 2022 01:57:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4H0-0000DU-6r for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:50 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99334a0e-cb4d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 03:57:49 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id z5-20020a17090a468500b001d2bc2743c4so56873pjf.0 for ; Tue, 03 May 2022 18:57:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g25-20020a62e319000000b0050dc7628168sm6962145pfh.66.2022.05.03.18.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99334a0e-cb4d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/QgTacQ+A83oLfMgc7AcEsbfIOOMUUn/07ShQ/z1lc0=; b=OEKPNTKscDvuMfuoT9d4JeIvnRRtddZvUR90FLHTaY6dqJ3WoEedmmXxG6udDH4ll2 hQ3xVWzIJux8F2/IVGnkOvoKvzigrtb6PN+WIk/nKNi6EuEO6/f9y41IdVZKJ50O2w0U wl96xKQAPtHy1YFDiqJxnzLe5ZISnsn0F+m/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/QgTacQ+A83oLfMgc7AcEsbfIOOMUUn/07ShQ/z1lc0=; b=DK9MKrt0Ly6WQG82i/hZNLbbnLobEDszZI01OOtxu7bFkCeN8iymCcFPrpAOSWk9Ly QQQBj819LOh+YFOCDULdOp3p2e3T/ee5iL4Rrk3Mb0uHvDGT7qN5zz0UmzH5Niyjduyn MoD/OYG7AcPhQyG+NBtbq+ES36oLKcHKyfQ/1dEEJ0FFyji6LfNYz83dyFp3Xen7iMiD OFGAL+Hq5nCKSMmyYaHOKEDuSA8y4NhkpSzpwDJ7e4daFYZHJ82W4wdYzZNcoq1ksw4U vJoCQTBmTPZwPlwlEFzD5lHUDoNoe0xwJQacvc9gS642+qv0K6w0S/ZmFf7QipnLOntr 2nLg== X-Gm-Message-State: AOAM532yjYRnKnxPImTJ5D1mZRDN06FG5hVe38Mw9JJUKymmGZ1oOS7n 3lsiJ6w9sj89ZdSH4esxcjMk8A== X-Google-Smtp-Source: ABdhPJz0Wz7uiw5Q84ZpgLomJ2sUNDZBw1NN/qBgJSmrLfPlt8IAi/IZc7UEAL8HYcl01ZzZ3TTw8Q== X-Received: by 2002:a17:902:e851:b0:15e:93ac:41db with SMTP id t17-20020a170902e85100b0015e93ac41dbmr17049558plg.26.1651629467986; Tue, 03 May 2022 18:57:47 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Felipe Balbi , Greg Kroah-Hartman , Eugeniu Rosca , John Keeping , Jens Axboe , Udipto Goswami , Andrew Gabbasov , linux-usb@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Francis Laniel , Frank Rowand , Franky Lin , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Johan Hedberg , Johannes Berg , Johannes Berg , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 30/32] usb: gadget: f_fs: Use mem_to_flex_dup() with struct ffs_buffer Date: Tue, 3 May 2022 18:44:39 -0700 Message-Id: <20220504014440.3697851-31-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2095; h=from:subject; bh=LoG608ySlb2xL5QEVpZpmYP+iWI9TrvgD0EbU83Sc1E=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqHiYfLCw3gedIJSUEv2AjZro9JsQDzVs6+PWv3 Jf25uuWJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahwAKCRCJcvTf3G3AJtOuD/ 44mR9b5DwvccUUG6HIlhBLAsn/BfAVzBmuRK+yPZ9MioNDOL4TpD4dZaBBpGG0hJon5radolumfj0P VNZW46qoLbHEBiSScw3XJnUUVFGSv9GbDDKBVRxmIWevrrYcSx9Ey7v8r/vqablkY0Kzx4Q+fL+nnh 4X55duw+qKqgzFtzT5kMl5IKcf/sFUgv1r2jts0fmdh4Bu2jfLlkfdmjQhJ4Af2db1+OF6UjtoOy5R 6BRYL6DkOEkVM3vSV8rlDM6yldlZogrtVEpiQUvbkDi2LerWROmCrkpPzwbukN6gYwmAh2v78g4BDT Asjg/ynqVVAPardAHgI8QUQbZeI1y2iXC5u4FfFaeEUSCVddHgdjugXVWOiP7s+phDof4Ke2yI+sBV QfV5yaD/w1jelv5AZidP9asc2fTSb8ASrFF+lKcuVilfbgIn9krQvLJqB8gjrr8OyJ8falxCUPu3i9 l/P190yQNXc+sUM1kJVb0JaQYSk6mxyyCv3suqH72zxRXkDKeNa7lGgBW+tH8Of1c6RUkdJZYUe0pH L7tc/j/ocIEHXPRHlkHrndofVZCRhIQ2XiFWxCEfSW4N1fXtuDO+O77rmlbdYwwwgsTLusPjWPXhon 642xzSjREIl8aWgxlvRZ5ty8QQFJP8TbxfkMEUHUpitb1yMsa0xo6z3WBFcA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: Eugeniu Rosca Cc: John Keeping Cc: Jens Axboe Cc: Udipto Goswami Cc: Andrew Gabbasov Cc: linux-usb@vger.kernel.org Signed-off-by: Kees Cook --- drivers/usb/gadget/function/f_fs.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 4585ee3a444a..bb0ff41dabd2 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -202,9 +202,9 @@ struct ffs_epfile { }; struct ffs_buffer { - size_t length; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, length); char *data; - char storage[]; + DECLARE_FLEX_ARRAY_ELEMENTS(char, storage); }; /* ffs_io_data structure ***************************************************/ @@ -905,7 +905,7 @@ static ssize_t __ffs_epfile_read_data(struct ffs_epfile *epfile, void *data, int data_len, struct iov_iter *iter) { - struct ffs_buffer *buf; + struct ffs_buffer *buf = NULL; ssize_t ret = copy_to_iter(data, data_len, iter); if (data_len == ret) @@ -919,12 +919,9 @@ static ssize_t __ffs_epfile_read_data(struct ffs_epfile *epfile, data_len, ret); data_len -= ret; - buf = kmalloc(struct_size(buf, storage, data_len), GFP_KERNEL); - if (!buf) + if (mem_to_flex_dup(&buf, data + ret, data_len, GFP_KERNEL)) return -ENOMEM; - buf->length = data_len; buf->data = buf->storage; - memcpy(buf->storage, data + ret, flex_array_size(buf, storage, data_len)); /* * At this point read_buffer is NULL or READ_BUFFER_DROP (if -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320076.540910 (Exim 4.92) (envelope-from ) id 1nm7Nt-00018L-2P; Wed, 04 May 2022 05:17:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320076.540910; Wed, 04 May 2022 05:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nr-0000zb-GU; Wed, 04 May 2022 05:17:07 +0000 Received: by outflank-mailman (input) for mailman id 320076; Wed, 04 May 2022 01:57:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4H1-0000D6-4y for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:51 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98adc00f-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:48 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id o69so15547488pjo.3 for ; Tue, 03 May 2022 18:57:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d25-20020aa78159000000b0050dc7628150sm6944272pfn.42.2022.05.03.18.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98adc00f-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QnKXHDo7FoS6A9KJnTSD5KrVSbLLoX11tytSVaJywLg=; b=I1CnhqzTuM3VIMYb3RIInFBjlZ/Kx1CC2nOaz3zCzGfRz66UhpKktUjcUf1DB5iFHu gfyX0fG10mb1nZrZrHamW6VaM5Mxf2xxMafia1jAkPA8Cn5ohLG+uBumAmwOSdS3hISM a4JzdC7Fo3kAKeDLIrkA80T/ZAttaFcZAV7gI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QnKXHDo7FoS6A9KJnTSD5KrVSbLLoX11tytSVaJywLg=; b=JXD6cLLB+Co+a1fBYLmLwF24KETnquon31SW+MhUlwsAXZYwyYCml6fvZVjirSYD0y 7sLpCNYzOMfIQmupCGm5pzLi07iGfUJXbqtGg+7tqUznOcyUiw9qj2GVwRDDPHaATtnY kHhpmsJXyl6ei3WDKNnE0nxdGkSk1WSTrjZBBl7ezlTEoTlfa25vjWJPEqAgE0VOqKRk xm1THt7yYNj23iK7I7peuUlhuAvRzWg794MuiWKJ/ftG3ver5fqRqL5JHQSa+KOtY6Wi 2VhdF9/EAoh7zHvopHx1r/qr+LMuIa8bwwvQd2EURDeGEgGPWN5ZEm/tdTmWbjgpta8J 8zDw== X-Gm-Message-State: AOAM533jhZI1AXx1b/SOZHkVQ+RvkWY6gT2iiIulwoCAcQ3CG7BXYKb8 39XSVBq8Ker4KzcQc1Hyk4F1wg== X-Google-Smtp-Source: ABdhPJwBJoJRbJoEf8uS056mC/SrVUlIMx/WczuLmtwpXFTRApIslHsgCto/oSfyiNoJlGKNBXfsbw== X-Received: by 2002:a17:90b:3904:b0:1dc:8fe0:df69 with SMTP id ob4-20020a17090b390400b001dc8fe0df69mr4001057pjb.59.1651629467088; Tue, 03 May 2022 18:57:47 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Marc Dionne , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 23/32] Bluetooth: Use mem_to_flex_dup() with struct hci_op_configure_data_path Date: Tue, 3 May 2022 18:44:32 -0700 Message-Id: <20220504014440.3697851-24-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2134; h=from:subject; bh=wkblXI7lu8DePbBEkrWcF6TPvSCY+fsd3+cJcm8lUX8=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqFhAG+9XZipSZhJ97uz0MVZAPm9ikLEayXBQca tSbucr2JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahQAKCRCJcvTf3G3AJuQgD/ 0RkSBHvTdsmM6uGZhl5vuzw4/t8A08lVzH+n9delDb7Snc4rClp98T7EnMak/i+Ne5YZV/OBum0+Ri 2Rso0KTZ7bgngl/ZWjToI21GZHTx0BvhmyN92pCyMRw8Q5g2WKeqI0pNWy8pO+tdkj+OZBI+kBTpzB DSCicDcFGgdZrS4ClZfIJ3ul5GuyH628GJbhzyj2IkHnbcVJTgVXEYTZfa9CUXIk5OxX0tgeN5hgKI YhvXiesuoZ4ZeGkGoBZgoWkyhWZg61taY7sMsK18JUdPuD2jO1Ziy7pPKMcmqr1QC1dxYBE2bshZ+7 3zm60sMtOhDVJc9pY0GGXTh83THBv9el1PLd8R1i03dHlFU+DYzQrq0OMEQ82DXkr9t89m7UmRpPNh UlFCgY75idmpPhVdKyd4ETvQlZtXZLEj7o98G9BByjCzXoXREee+09IWrA/DOZh7zHcuLHY4mwot7j j2JWq1nvZO0OVDBDjoUB6FMPShLAPZiPeGYn+67y9JU7lL1VFHN8sVsxBLq08bQ/HI32D+rAgZCCsn fVZ7tajhB6zkfYibttaD+E5RLSV+adLK+eXnFBqoQttbtNsKxuiZQF0dJZusj9dnKk/M5l3Ud90Uiq FXQeX6fOpiALefTfw5/ocOvMAHAP7Hz1WKgKO3NK7KYNbxbmS5+syYfDxdWQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: Marcel Holtmann Cc: Johan Hedberg Cc: Luiz Augusto von Dentz Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-bluetooth@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook --- include/net/bluetooth/hci.h | 4 ++-- net/bluetooth/hci_request.c | 9 ++------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index 62a9bb022aed..7b398ef0b46d 100644 --- a/include/net/bluetooth/hci.h +++ b/include/net/bluetooth/hci.h @@ -1321,8 +1321,8 @@ struct hci_rp_read_local_oob_ext_data { struct hci_op_configure_data_path { __u8 direction; __u8 data_path_id; - __u8 vnd_len; - __u8 vnd_data[]; + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u8, vnd_len); + DECLARE_FLEX_ARRAY_ELEMENTS(__u8, vnd_data); } __packed; #define HCI_OP_READ_LOCAL_VERSION 0x1001 diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index f4afe482e300..e29be3810b93 100644 --- a/net/bluetooth/hci_request.c +++ b/net/bluetooth/hci_request.c @@ -2435,19 +2435,14 @@ int hci_req_configure_datapath(struct hci_dev *hdev, struct bt_codec *codec) if (err < 0) goto error; - cmd = kzalloc(sizeof(*cmd) + vnd_len, GFP_KERNEL); - if (!cmd) { - err = -ENOMEM; + err = mem_to_flex_dup(&cmd, vnd_data, vnd_len, GFP_KERNEL); + if (err < 0) goto error; - } err = hdev->get_data_path_id(hdev, &cmd->data_path_id); if (err < 0) goto error; - cmd->vnd_len = vnd_len; - memcpy(cmd->vnd_data, vnd_data, vnd_len); - cmd->direction = 0x00; hci_req_add(&req, HCI_CONFIGURE_DATA_PATH, sizeof(*cmd) + vnd_len, cmd); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320079.540918 (Exim 4.92) (envelope-from ) id 1nm7Nu-0001ih-Tj; Wed, 04 May 2022 05:17:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320079.540918; Wed, 04 May 2022 05:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nt-0001aH-Hx; Wed, 04 May 2022 05:17:09 +0000 Received: by outflank-mailman (input) for mailman id 320079; Wed, 04 May 2022 01:57:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm4H2-0000D6-50 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 01:57:52 +0000 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [2607:f8b0:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 992860bc-cb4d-11ec-a406-831a346695d4; Wed, 04 May 2022 03:57:49 +0200 (CEST) Received: by mail-pf1-x42c.google.com with SMTP id p12so50531pfn.0 for ; Tue, 03 May 2022 18:57:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x21-20020a1709027c1500b0015e8d4eb202sm6984553pll.76.2022.05.03.18.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 18:57:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 992860bc-cb4d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dWvrJlxp0hfwq/rpuMGCsTJMwzo7GNCIoJATWYPCVJE=; b=OW0yn3aPFgkfwn8L35EyIBf488Ir3oPRdcuBBy8HPNsH5M0x5CXqSqshhOTKtpKq5L QF/xhc9eykoWhvFmZW6nwgo8tyY5Hha7nsaQ+7vI7aAIrUuE+pM/MYF4FAAKrs9ERjRM nEcriHnnehj4N7XQ40GlCVy2op0vzdnIn84H4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dWvrJlxp0hfwq/rpuMGCsTJMwzo7GNCIoJATWYPCVJE=; b=zo+fgNNId7BJTV9Wds/8rrfsBVUEOkqPOJPju1TF+kusEsGBWueUQbYGjQQV7xR8Sx kRYda/oMQtq2HbXKByrLPRj1Fd37KaCXmwHwm8i5b94n9S3keKEN0yhaTMnweDF/Bl0F GJA+U56vXcpeWXjFFilexf8ggKeVU7p/+cLu6mCdYQe1JakiknXGBovXTqlRsic/8dZ2 g+SGZDIZRe09nlEEEvzGdx07O5ZOz6PzaKFfRPNduVr9YTafIUPLY2JSGYoII0y0IzrW SHoFV4lZ9HKFOB3AGIax6fY51py+7f6Ep8jbAsQ0emttEQiNHVfNQuvBMjuoyBC2+Zdd njYg== X-Gm-Message-State: AOAM533mBQ5urbjJGTbs/j5JQt3y5oZilGRRbOZBx6DyRrVFZaxAgOnw 7Y7ENIag2fmCv11r49xwrvFsBQ== X-Google-Smtp-Source: ABdhPJwbC/L7nZs96BtZ9jeB/rQtyCDwXrBrp6VlWrbG6DOzItmYMRFYheK4g32qpwyIMeuySKD+FQ== X-Received: by 2002:a63:2b05:0:b0:3c2:3ed1:5fa9 with SMTP id r5-20020a632b05000000b003c23ed15fa9mr8717398pgr.220.1651629467921; Tue, 03 May 2022 18:57:47 -0700 (PDT) From: Kees Cook To: "Gustavo A . R . Silva" Cc: Kees Cook , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , linux-hyperv@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?q?Nuno=20S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: [PATCH 25/32] Drivers: hv: utils: Use mem_to_flex_dup() with struct cn_msg Date: Tue, 3 May 2022 18:44:34 -0700 Message-Id: <20220504014440.3697851-26-keescook@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2219; h=from:subject; bh=dgFYdMqTm4tBMA+d8KWXYde/YMvArhgtiTydpKgqF6s=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBicdqGpwfENVCD78xIrOKs07wFk+8+2VNIIqaIzTy/ MQg5zx6JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCYnHahgAKCRCJcvTf3G3AJlkID/ 9xYgI2yUTmOqWGUHwjPg6PRpPwUj6yqPTnvHBjZmeB6GcMkb/J1qYZ0We4QMX2FKo8/RxUIZmkpsBI ghlT5pXLwU+EL9vLRAtiKFcmM6HmLrpDOA+H7c/+3yz3nLeExs5il9FvDhAWsAneG2E6lymkjrtZwB PmGHZ1SbLjt7dlHn9zzeTTcBLGvqVG+t1HbL1yM0qT9sxR33bwrS1/XY/VbQ9ZBwXv5G1ci/UQYTn+ IxWJQyTz1WY3n4gGJIy12AX3Gg0SC3bdx9m5pnqgXmSvY3uw+gAkf+Jq+ITd7t+YW8zrXaiMMGPmhC +dn4j7Pvv4hNJ6R/d9/lrj8cAs53cQUbwW3e/7yRsiZb37BKs643K8RW97bKNemjiBUk2NngqjWaOl FzxBm7iGLEjOq989XZeJNEB+MQLecqtGjX+/LxzzzpvAKeMi9bXDiSJAfPG2yxB7wzIUCmUUxW3kKq 5ITIvocBuuqbJzokzh+M+VX/4LsefOVBxhkljlxxgFvwnLhsXHSrMa9c7vd07TAikSiJ0Vi6xYDuv0 m4TiF4oEz1DuG0oiUI9BpM7VSTL+S8V/5GoKv/V+vcO7lhrDKhfS7G8kPKHplhyqNqe7RD2pCIVyOI ++T7/zqpV+vaRd4iu+z+vgmLDrCZcODKGwvjXW2ZeAEW8baladN7FbwkDLDA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit As part of the work to perform bounds checking on all memcpy() uses, replace the open-coded a deserialization of bytes out of memory into a trailing flexible array by using a flex_array.h helper to perform the allocation, bounds checking, and copying. Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Wei Liu Cc: Dexuan Cui Cc: linux-hyperv@vger.kernel.org Signed-off-by: Kees Cook --- drivers/hv/hv_utils_transport.c | 7 ++----- include/uapi/linux/connector.h | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c index 832885198643..43b4f8893cc0 100644 --- a/drivers/hv/hv_utils_transport.c +++ b/drivers/hv/hv_utils_transport.c @@ -217,20 +217,17 @@ static void hvt_cn_callback(struct cn_msg *msg, struct netlink_skb_parms *nsp) int hvutil_transport_send(struct hvutil_transport *hvt, void *msg, int len, void (*on_read_cb)(void)) { - struct cn_msg *cn_msg; + struct cn_msg *cn_msg = NULL; int ret = 0; if (hvt->mode == HVUTIL_TRANSPORT_INIT || hvt->mode == HVUTIL_TRANSPORT_DESTROY) { return -EINVAL; } else if (hvt->mode == HVUTIL_TRANSPORT_NETLINK) { - cn_msg = kzalloc(sizeof(*cn_msg) + len, GFP_ATOMIC); - if (!cn_msg) + if (mem_to_flex_dup(&cn_msg, msg, len, GFP_ATOMIC)) return -ENOMEM; cn_msg->id.idx = hvt->cn_id.idx; cn_msg->id.val = hvt->cn_id.val; - cn_msg->len = len; - memcpy(cn_msg->data, msg, len); ret = cn_netlink_send(cn_msg, 0, 0, GFP_ATOMIC); kfree(cn_msg); /* diff --git a/include/uapi/linux/connector.h b/include/uapi/linux/connector.h index 3738936149a2..b85bbe753dae 100644 --- a/include/uapi/linux/connector.h +++ b/include/uapi/linux/connector.h @@ -73,9 +73,9 @@ struct cn_msg { __u32 seq; __u32 ack; - __u16 len; /* Length of the following data */ + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, len); __u16 flags; - __u8 data[0]; + __DECLARE_FLEX_ARRAY_ELEMENTS(__u8, data); }; #endif /* _UAPI__CONNECTOR_H */ -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320099.540930 (Exim 4.92) (envelope-from ) id 1nm7Nx-0002CG-08; Wed, 04 May 2022 05:17:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320099.540930; Wed, 04 May 2022 05:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7Nv-000231-NN; Wed, 04 May 2022 05:17:11 +0000 Received: by outflank-mailman (input) for mailman id 320099; Wed, 04 May 2022 03:37:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm5pc-0001mD-35 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 03:37:40 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8afb1b8f-cb5b-11ec-a406-831a346695d4; Wed, 04 May 2022 05:37:38 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id k1so329150pll.4 for ; Tue, 03 May 2022 20:37:38 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k23-20020a170902ba9700b0015e8d4eb1fesm7117388pls.72.2022.05.03.20.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 20:37:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8afb1b8f-cb5b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lsBVjxx2frcPFNjY4/BLqdzh7cys7mpO3LyMH5LAbSE=; b=e/seADFb6dKCy5O35I2lb3QkGM1U1AG+HWJjIUEuWUaLYiQ/bRCqVwsL3BCOvWYEuK 9qpY1aU7RmqPGGBT5JUv2H6Jc6siGFaT+PVsx+FN+n4iHis5NM0gOyiK9HY2IIWzLhh4 mk3V/alwvU0/DDln8pB7kZALicerW3KUceFLU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lsBVjxx2frcPFNjY4/BLqdzh7cys7mpO3LyMH5LAbSE=; b=UQoKhUhj8O9oTA6ogw3q2AFB5K5XaCYhdY7KmHXn6oABR2dfhGCQXHu+0HkTJOGlve ikD94cSP3XeW4VQdYBrERrTLhKE8UuclDL2jzTQ+E056RH2lP6JzEUQW7Aa5GFRbIxUn 1VR2WHfA9UsUk91IH2C7U9FQWeF4qbr/Nm3M27InbdbIryJwIR050pDpTXXukcS0S9gZ RSA/3vO+QxJXS9WlzNiYRLMbi+aq5dm+iORZlZjp2oT9AG2vZwsJZ4bZu24/rJ7Q3i9D t36RElxqfCM8tW3sMLXTbTmWKBTHSaaGRGZQg6Qvk99HvFYzR8Q5m85BPqWjXL92TNFS lCSg== X-Gm-Message-State: AOAM530lXVJZduSvP97LsRa0WdvZeCriAIGQ5T7ZIQvhkNd0br+Wfv/I 6OgveiKnHeXATwvgsWLv1ysujg== X-Google-Smtp-Source: ABdhPJw42Y4zw7XGLJ0qL8m2iK8R/sg3Y/yQJpglfujQWmDGz21UKIQOVg7Md/ZATtyrGT1c7jNF4A== X-Received: by 2002:a17:90b:1b44:b0:1dc:315f:4510 with SMTP id nv4-20020a17090b1b4400b001dc315f4510mr8282445pjb.28.1651635456924; Tue, 03 May 2022 20:37:36 -0700 (PDT) Date: Tue, 3 May 2022 20:37:35 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Rasmus Villemoes , "David S. Miller" , Jakub Kicinski , Rich Felker , Eric Dumazet , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 01/32] netlink: Avoid memcpy() across flexible array boundary Message-ID: <202205032027.B2A9FB4AA@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-2-keescook@chromium.org> <20220504033105.GA13667@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504033105.GA13667@embeddedor> On Tue, May 03, 2022 at 10:31:05PM -0500, Gustavo A. R. Silva wrote: > On Tue, May 03, 2022 at 06:44:10PM -0700, Kees Cook wrote: > [...] > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > > index 1b5a9c2e1c29..09346aee1022 100644 > > --- a/net/netlink/af_netlink.c > > +++ b/net/netlink/af_netlink.c > > @@ -2445,7 +2445,10 @@ void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err, > > NLMSG_ERROR, payload, flags); > > errmsg = nlmsg_data(rep); > > errmsg->error = err; > > - memcpy(&errmsg->msg, nlh, payload > sizeof(*errmsg) ? nlh->nlmsg_len : sizeof(*nlh)); > > + errmsg->msg = *nlh; > > + if (payload > sizeof(*errmsg)) > > + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, > > + nlh->nlmsg_len - sizeof(*nlh)); > > They have nlmsg_len()[1] for the length of the payload without the header: > > /** > * nlmsg_len - length of message payload > * @nlh: netlink message header > */ > static inline int nlmsg_len(const struct nlmsghdr *nlh) > { > return nlh->nlmsg_len - NLMSG_HDRLEN; > } Oh, hm, yeah, that would be much cleaner. The relationship between "payload" and nlmsg_len is confusing in here. :) So, this should be simpler: - memcpy(&errmsg->msg, nlh, payload > sizeof(*errmsg) ? nlh->nlmsg_len : sizeof(*nlh)); + errmsg->msg = *nlh; + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, nlmsg_len(nlh)); It's actually this case that triggered my investigation in __bos(1)'s misbehavior around sub-structs, since this case wasn't getting silenced: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832 It still feels like it should be possible to get this right without splitting the memcpy, though. Hmpf. > (would that function use some sanitization, though? what if nlmsg_len is > somehow manipulated to be less than NLMSG_HDRLEN?...) Maybe something like: static inline int nlmsg_len(const struct nlmsghdr *nlh) { if (WARN_ON(nlh->nlmsg_len < NLMSG_HDRLEN)) return 0; return nlh->nlmsg_len - NLMSG_HDRLEN; } > Also, it seems there is at least one more instance of this same issue: > > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c > index 16ae92054baa..d06184b94af5 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -1723,7 +1723,8 @@ call_ad(struct net *net, struct sock *ctnl, struct sk_buff *skb, > nlh->nlmsg_seq, NLMSG_ERROR, payload, 0); > errmsg = nlmsg_data(rep); > errmsg->error = ret; > - memcpy(&errmsg->msg, nlh, nlh->nlmsg_len); > + errmsg->msg = *nlh; > + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, nlmsg_len(nlh)); Ah, yes, nice catch! > cmdattr = (void *)&errmsg->msg + min_len; > > ret = nla_parse(cda, IPSET_ATTR_CMD_MAX, cmdattr, > > -- > Gustavo > > [1] https://elixir.bootlin.com/linux/v5.18-rc5/source/include/net/netlink.h#L577 -- Kees Cook From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320093.540974 (Exim 4.92) (envelope-from ) id 1nm7O9-0005EM-Jb; Wed, 04 May 2022 05:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320093.540974; Wed, 04 May 2022 05:17:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7O8-00057x-KX; Wed, 04 May 2022 05:17:24 +0000 Received: by outflank-mailman (input) for mailman id 320093; Wed, 04 May 2022 03:00:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm5G1-0007QV-83 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 03:00:53 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 676a3030-cb56-11ec-a406-831a346695d4; Wed, 04 May 2022 05:00:50 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id bg25so91624wmb.4 for ; Tue, 03 May 2022 20:00:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 676a3030-cb56-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vGLIjYSiLxoBv9ZeIUTv+P3yeo2tknkDegJ6pup4NBI=; b=Oz+AQP3PYqauwY/6AZTw7BE36VXH3mJF/MGrVDM8W9fjiQypv9jPTxItc8GGtxsg0U l4mb/QIk20MPDrHaLGmuNJmGDdipCqMd0st2sqAdEK08X8uvc/MdsvBRAPLBzzKR2bKr bf5FTJRJ8WsQrkIBO6TpdkOODhjJGApEMfZ+oAqimaPzMy1bDbFQht+mAd9V5ghwcZco 2d27XZJ2v3gg+Qp8J9frlfA+eN+MGXY+XkVRpygoDE5l5c+TsyfLbyRCm7xFkSQK4b0R x7YSeI2/gYSGLn3War0Vu6hNoE2UT6QDvLlPcGTKTsXKyZNvlE/iXhksog//o7idzb7j OChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vGLIjYSiLxoBv9ZeIUTv+P3yeo2tknkDegJ6pup4NBI=; b=rAcwoPp4x8Y/vFA4pp8AQ6bxGE93YTwRQToq33X6wB0WtJGovf67vlF851VqCiNPKP F1VZtOJsyEpglC7KM2KR7qAa1V0YgrBLEfUPC7+foqmtBX/iNReLeXIBLvGU6vmHy9Uf 6W+h3hvBIwQQLaQv+zj73JJAr+EYouIZgbYT16HvsfV1/9d87p03sZI31PJQfpgva7by MNiAlIVzue6UcP7ve4jO4IOBQOFVqipGjelyt5KdCwZn6Wk+ZFpWkryby69bqznxK5Ap mBMqfw5aJXCGmIcSsjXI7SnraKY5h3oDZxvcpEcRT57EPUaxnGgwD51XLIx4dnIsxo92 SNvw== X-Gm-Message-State: AOAM531YdBVdtQ3TonsPff6kDRZ3X319/T+9xfB0YCP6KIWwNnhni/h/ 9IemQVNJNb30HhWFeyAFpmEz9KhC1QFT42i7h+nncQ== X-Google-Smtp-Source: ABdhPJw5h9yKjUvRlwSZRTIszjUlPOhVsMiOY4Ap4z8MuSzSxI7vfctThfZZedLmgdKZf6N+2wNPQVgplRDJto1jdW4= X-Received: by 2002:a05:600c:12c9:b0:394:54ab:52c5 with SMTP id v9-20020a05600c12c900b0039454ab52c5mr2975585wmd.141.1651633249656; Tue, 03 May 2022 20:00:49 -0700 (PDT) MIME-Version: 1.0 References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-4-keescook@chromium.org> In-Reply-To: <20220504014440.3697851-4-keescook@chromium.org> From: David Gow Date: Wed, 4 May 2022 11:00:38 +0800 Message-ID: Subject: Re: [PATCH 03/32] flex_array: Add Kunit tests To: Kees Cook Cc: "Gustavo A . R . Silva" , KUnit Development , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, Linux ARM , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Networking , Nick Desaulniers , =?UTF-8?B?TnVubyBTw6E=?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Content-Type: text/plain; charset="UTF-8" On Wed, May 4, 2022 at 9:47 AM Kees Cook wrote: > > Add tests for the new flexible array structure helpers. These can be run > with: > > make ARCH=um mrproper > ./tools/testing/kunit/kunit.py config Nit: it shouldn't be necessary to run kunit.py config separately: kunit.py run will configure the kernel if necessary. > ./tools/testing/kunit/kunit.py run flex_array > > Cc: David Gow > Cc: kunit-dev@googlegroups.com > Signed-off-by: Kees Cook > --- This looks pretty good to me: it certainly worked on the different setups I tried (um, x86_64, x86_64+KASAN). A few minor nitpicks inline, mostly around minor config-y things, or things which weren't totally clear on my first read-through. Hopefully one day, with the various stubbing features or something similar, we'll be able to check against allocation failures in flex_dup(), too, but otherwise nothing seems too obviously missing. Reviewed-by: David Gow -- David > lib/Kconfig.debug | 12 +- > lib/Makefile | 1 + > lib/flex_array_kunit.c | 523 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 531 insertions(+), 5 deletions(-) > create mode 100644 lib/flex_array_kunit.c > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 9077bb38bc93..8bae6b169c50 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -2551,11 +2551,6 @@ config OVERFLOW_KUNIT_TEST > Builds unit tests for the check_*_overflow(), size_*(), allocation, and > related functions. > > - For more information on KUnit and unit tests in general please refer > - to the KUnit documentation in Documentation/dev-tools/kunit/. > - > - If unsure, say N. > - Nit: while I'm not against removing some of this boilerplate, is it better suited for a separate commit? > config STACKINIT_KUNIT_TEST > tristate "Test level of stack variable initialization" if !KUNIT_ALL_TESTS > depends on KUNIT > @@ -2567,6 +2562,13 @@ config STACKINIT_KUNIT_TEST > CONFIG_GCC_PLUGIN_STRUCTLEAK, CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF, > or CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL. > > +config FLEX_ARRAY_KUNIT_TEST > + tristate "Test flex_*() family of helper functions at runtime" if !KUNIT_ALL_TESTS > + depends on KUNIT > + default KUNIT_ALL_TESTS > + help > + Builds unit tests for flexible array copy helper functions. > + Nit: checkpatch warns that the description here may be insufficient: WARNING: please write a help paragraph that fully describes the config symbol > config TEST_UDELAY > tristate "udelay test driver" > help > diff --git a/lib/Makefile b/lib/Makefile > index 6b9ffc1bd1ee..9884318db330 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -366,6 +366,7 @@ obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o > obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o > CFLAGS_stackinit_kunit.o += $(call cc-disable-warning, switch-unreachable) > obj-$(CONFIG_STACKINIT_KUNIT_TEST) += stackinit_kunit.o > +obj-$(CONFIG_FLEX_ARRAY_KUNIT_TEST) += flex_array_kunit.o > > obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o > > diff --git a/lib/flex_array_kunit.c b/lib/flex_array_kunit.c > new file mode 100644 > index 000000000000..48bee88945b4 > --- /dev/null > +++ b/lib/flex_array_kunit.c > @@ -0,0 +1,523 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Test cases for flex_*() array manipulation helpers. > + */ > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > +#include > +#include > +#include > +#include > +#include > + > +#define COMPARE_STRUCTS(STRUCT_A, STRUCT_B) do { \ > + STRUCT_A *ptr_A; \ > + STRUCT_B *ptr_B; \ > + int rc; \ > + size_t size_A, size_B; \ > + \ > + /* matching types for flex array elements and count */ \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A), sizeof(*ptr_B)); \ > + KUNIT_EXPECT_TRUE(test, __same_type(*ptr_A->data, \ > + *ptr_B->__flex_array_elements)); \ > + KUNIT_EXPECT_TRUE(test, __same_type(ptr_A->datalen, \ > + ptr_B->__flex_array_elements_count)); \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A->data), \ > + sizeof(*ptr_B->__flex_array_elements)); \ > + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), data), \ > + offsetof(typeof(*ptr_B), \ > + __flex_array_elements)); \ > + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), datalen), \ > + offsetof(typeof(*ptr_B), \ > + __flex_array_elements_count)); \ > + \ > + /* struct_size() vs __fas_bytes() */ \ > + size_A = struct_size(ptr_A, data, 13); \ > + rc = __fas_bytes(ptr_B, __flex_array_elements, \ > + __flex_array_elements_count, 13, &size_B); \ > + KUNIT_EXPECT_EQ(test, rc, 0); \ > + KUNIT_EXPECT_EQ(test, size_A, size_B); \ > + \ > + /* flex_array_size() vs __fas_elements_bytes() */ \ > + size_A = flex_array_size(ptr_A, data, 13); \ > + rc = __fas_elements_bytes(ptr_B, __flex_array_elements, \ > + __flex_array_elements_count, 13, &size_B); \ > + KUNIT_EXPECT_EQ(test, rc, 0); \ > + KUNIT_EXPECT_EQ(test, size_A, size_B); \ > + \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A) + size_A, \ > + offsetof(typeof(*ptr_A), data) + \ > + (sizeof(*ptr_A->data) * 13)); \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_B) + size_B, \ > + offsetof(typeof(*ptr_B), \ > + __flex_array_elements) + \ > + (sizeof(*ptr_B->__flex_array_elements) * \ > + 13)); \ > +} while (0) > + > +struct normal { > + size_t datalen; > + u32 data[]; > +}; > + > +struct decl_normal { > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, datalen); > + DECLARE_FLEX_ARRAY_ELEMENTS(u32, data); > +}; > + > +struct aligned { > + unsigned short datalen; > + char data[] __aligned(__alignof__(u64)); > +}; > + > +struct decl_aligned { > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned short, datalen); > + DECLARE_FLEX_ARRAY_ELEMENTS(char, data) __aligned(__alignof__(u64)); > +}; > + > +static void struct_test(struct kunit *test) > +{ > + COMPARE_STRUCTS(struct normal, struct decl_normal); > + COMPARE_STRUCTS(struct aligned, struct decl_aligned); > +} If I understand it, the purpose of this is to ensure that structs both with and without the flexible array declaration have the same memory layout? If so, any chance of a comment briefly stating that's the purpose (or renaming this test struct_layout_test())? Also, would it make sense to do the same with the struct with internal padding below? > + > +/* Flexible array structure with internal padding. */ > +struct flex_cpy_obj { > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, count); > + unsigned long empty; > + char induce_padding; > + /* padding ends up here */ > + unsigned long after_padding; > + DECLARE_FLEX_ARRAY_ELEMENTS(u32, flex); > +}; > + > +/* Encapsulating flexible array structure. */ > +struct flex_dup_obj { > + unsigned long flags; > + int junk; > + struct flex_cpy_obj fas; > +}; > + > +/* Flexible array struct of only bytes. */ > +struct tiny_flex { > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u8, count); > + DECLARE_FLEX_ARRAY_ELEMENTS(u8, byte_array); > +}; > + > +#define CHECK_COPY(ptr) do { \ > + typeof(*(ptr)) *_cc_dst = (ptr); \ > + KUNIT_EXPECT_EQ(test, _cc_dst->induce_padding, 0); \ > + memcpy(&padding, &_cc_dst->induce_padding + sizeof(_cc_dst->induce_padding), \ > + sizeof(padding)); \ > + /* Padding should be zero too. */ \ > + KUNIT_EXPECT_EQ(test, padding, 0); \ > + KUNIT_EXPECT_EQ(test, src->count, _cc_dst->count); \ > + KUNIT_EXPECT_EQ(test, _cc_dst->count, TEST_TARGET); \ > + for (i = 0; i < _cc_dst->count - 1; i++) { \ > + /* 'A' is 0x41, and here repeated in a u32. */ \ Would it be simpler to just note that the magic value is 0x41, rather than have it be the character 'A'? > + KUNIT_EXPECT_EQ(test, _cc_dst->flex[i], 0x41414141); \ > + } \ > + /* Last item should be different. */ \ > + KUNIT_EXPECT_EQ(test, _cc_dst->flex[_cc_dst->count - 1], 0x14141414); \ > +} while (0) > + > +/* Test copying from one flexible array struct into another. */ > +static void flex_cpy_test(struct kunit *test) > +{ > +#define TEST_BOUNDS 13 > +#define TEST_TARGET 12 > +#define TEST_SMALL 10 > + struct flex_cpy_obj *src, *dst; > + unsigned long padding; > + int i, rc; > + > + /* Prepare open-coded source. */ > + src = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); > + src->count = TEST_BOUNDS; > + memset(src->flex, 'A', flex_array_size(src, flex, TEST_BOUNDS)); As above, it's possibly nicer to just state 0x41 here, rather than 'A', since all we're doing is checking against a hex value. > + src->flex[src->count - 2] = 0x14141414; > + src->flex[src->count - 1] = 0x24242424; > + > + /* Prepare open-coded destination, alloc only. */ > + dst = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); > + /* Pre-fill with 0xFE marker. */ > + memset(dst, 0xFE, struct_size(src, flex, TEST_BOUNDS)); > + /* Pretend we're 1 element smaller. */ > + dst->count = TEST_TARGET; > + > + /* Pretend to match the target destination size. */ > + src->count = TEST_TARGET; > + > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, 0); > + CHECK_COPY(dst); > + /* Item past last copied item is unchanged from initial memset. */ > + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); > + > + /* Now trip overflow, and verify we didn't clobber beyond end. */ > + src->count = TEST_BOUNDS; > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Item past last copied item is unchanged from initial memset. */ > + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); > + > + /* Reset destination contents. */ > + memset(dst, 0xFD, struct_size(src, flex, TEST_BOUNDS)); > + dst->count = TEST_TARGET; > + > + /* Copy less than max. */ > + src->count = TEST_SMALL; > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, 0); > + /* Verify count was adjusted. */ > + KUNIT_EXPECT_EQ(test, dst->count, TEST_SMALL); > + /* Verify element beyond src size was wiped. */ > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_SMALL], 0); > + /* Verify element beyond original dst size was untouched. */ > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_TARGET], 0xFDFDFDFD); > + > + kfree(dst); > + kfree(src); > +#undef TEST_BOUNDS > +#undef TEST_TARGET > +#undef TEST_SMALL > +} > + > +static void flex_dup_test(struct kunit *test) > +{ > +#define TEST_TARGET 12 > + struct flex_cpy_obj *src, *dst = NULL, **null = NULL; > + struct flex_dup_obj *encap = NULL; > + unsigned long padding; > + int i, rc; > + > + /* Prepare open-coded source. */ > + src = kzalloc(struct_size(src, flex, TEST_TARGET), GFP_KERNEL); > + src->count = TEST_TARGET; > + memset(src->flex, 'A', flex_array_size(src, flex, TEST_TARGET)); > + src->flex[src->count - 1] = 0x14141414; > + > + /* Reject NULL @alloc. */ > + rc = flex_dup(null, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + > + /* Check good copy. */ > + rc = flex_dup(&dst, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, dst != NULL); > + CHECK_COPY(dst); > + > + /* Reject non-NULL *@alloc. */ > + rc = flex_dup(&dst, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + > + kfree(dst); > + > + /* Check good encap copy. */ > + rc = __flex_dup(&encap, .fas, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, dst != NULL); > + CHECK_COPY(&encap->fas); > + /* Check that items external to "fas" are zero. */ > + KUNIT_EXPECT_EQ(test, encap->flags, 0); > + KUNIT_EXPECT_EQ(test, encap->junk, 0); > + kfree(encap); > +#undef MAGIC_WORD MAGIC_WORD isn't defined (or used) for flux_dup_test? Is it worth using it (or something similar) for the 'A' / 0x14141414 and the CHECK_COPY() macro? > +#undef TEST_TARGET > +} > + > +static void mem_to_flex_test(struct kunit *test) > +{ > +#define TEST_TARGET 9 > +#define TEST_MAX U8_MAX > +#define MAGIC_WORD 0x03030303 > + u8 magic_byte = MAGIC_WORD & 0xff; > + struct flex_cpy_obj *dst; > + size_t big = (size_t)INT_MAX + 1; > + char small[] = "Hello"; > + char *src; > + u32 src_len; > + int rc; > + > + /* Open coded allocations, 1 larger than actually used. */ > + src_len = flex_array_size(dst, flex, TEST_MAX + 1); > + src = kzalloc(src_len, GFP_KERNEL); > + dst = kzalloc(struct_size(dst, flex, TEST_MAX + 1), GFP_KERNEL); > + dst->count = TEST_TARGET; > + > + /* Fill source. */ > + memset(src, magic_byte, src_len); > + > + /* Short copy is fine. */ > + KUNIT_EXPECT_EQ(test, dst->flex[0], 0); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + rc = mem_to_flex(dst, src, 1); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_EXPECT_EQ(test, dst->count, 1); > + KUNIT_EXPECT_EQ(test, dst->after_padding, 0); > + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + dst->count = TEST_TARGET; > + > + /* Reject negative elements count. */ > + rc = mem_to_flex(dst, small, -1); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure dst is unchanged. */ > + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + > + /* Reject compile-time read overflow. */ > + rc = mem_to_flex(dst, small, 20); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure dst is unchanged. */ > + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + > + /* Reject giant buffer source. */ > + rc = mem_to_flex(dst, small, big); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure dst is unchanged. */ > + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + > + /* Copy beyond storage size is rejected. */ > + dst->count = TEST_MAX; > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_MAX - 1], 0); > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_MAX], 0); > + rc = mem_to_flex(dst, src, TEST_MAX + 1); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure dst is unchanged. */ > + KUNIT_EXPECT_EQ(test, dst->flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, dst->flex[1], 0); > + > + kfree(dst); > + kfree(src); > +#undef MAGIC_WORD > +#undef TEST_MAX > +#undef TEST_TARGET > +} > + > +static void mem_to_flex_dup_test(struct kunit *test) > +{ > +#define ELEMENTS_COUNT 259 > +#define MAGIC_WORD 0xABABABAB > + u8 magic_byte = MAGIC_WORD & 0xff; > + struct flex_dup_obj *obj = NULL; > + struct tiny_flex *tiny = NULL, **null = NULL; > + size_t src_len, count, big = (size_t)INT_MAX + 1; > + char small[] = "Hello"; > + u8 *src; > + int rc; > + > + src_len = struct_size(tiny, byte_array, ELEMENTS_COUNT); > + src = kzalloc(src_len, GFP_KERNEL); > + KUNIT_ASSERT_TRUE(test, src != NULL); > + /* Fill with bytes. */ > + memset(src, magic_byte, src_len); > + KUNIT_EXPECT_EQ(test, src[0], magic_byte); > + KUNIT_EXPECT_EQ(test, src[src_len / 2], magic_byte); > + KUNIT_EXPECT_EQ(test, src[src_len - 1], magic_byte); > + > + /* Reject storage exceeding elements_count type. */ > + count = ELEMENTS_COUNT; > + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + KUNIT_EXPECT_TRUE(test, tiny == NULL); > + > + /* Reject negative elements count. */ > + rc = mem_to_flex_dup(&tiny, src, -1, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + KUNIT_EXPECT_TRUE(test, tiny == NULL); > + > + /* Reject compile-time read overflow. */ > + rc = mem_to_flex_dup(&tiny, small, 20, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + KUNIT_EXPECT_TRUE(test, tiny == NULL); > + > + /* Reject giant buffer source. */ > + rc = mem_to_flex_dup(&tiny, small, big, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + KUNIT_EXPECT_TRUE(test, tiny == NULL); > + > + /* Reject NULL @alloc. */ > + rc = mem_to_flex_dup(null, src, count, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + > + /* Allow reasonable count.*/ > + count = ELEMENTS_COUNT / 2; > + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, tiny != NULL); > + /* Spot check the copy happened. */ > + KUNIT_EXPECT_EQ(test, tiny->count, count); > + KUNIT_EXPECT_EQ(test, tiny->byte_array[0], magic_byte); > + KUNIT_EXPECT_EQ(test, tiny->byte_array[count / 2], magic_byte); > + KUNIT_EXPECT_EQ(test, tiny->byte_array[count - 1], magic_byte); > + > + /* Reject non-NULL *@alloc. */ > + rc = mem_to_flex_dup(&tiny, src, count, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + kfree(tiny); > + > + /* Works with encapsulation too. */ > + count = ELEMENTS_COUNT / 10; > + rc = __mem_to_flex_dup(&obj, .fas, src, count, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, obj != NULL); > + /* Spot check the copy happened. */ > + KUNIT_EXPECT_EQ(test, obj->fas.count, count); > + KUNIT_EXPECT_EQ(test, obj->fas.after_padding, 0); > + KUNIT_EXPECT_EQ(test, obj->fas.flex[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, obj->fas.flex[count / 2], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, obj->fas.flex[count - 1], MAGIC_WORD); > + /* Check members before flexible array struct are zero. */ > + KUNIT_EXPECT_EQ(test, obj->flags, 0); > + KUNIT_EXPECT_EQ(test, obj->junk, 0); > + kfree(obj); > +#undef MAGIC_WORD > +#undef ELEMENTS_COUNT > +} > + > +static void flex_to_mem_test(struct kunit *test) > +{ > +#define ELEMENTS_COUNT 200 > +#define MAGIC_WORD 0xF1F2F3F4 > + struct flex_cpy_obj *src; > + typeof(*src->flex) *cast; > + size_t src_len = struct_size(src, flex, ELEMENTS_COUNT); > + size_t copy_len = flex_array_size(src, flex, ELEMENTS_COUNT); > + int i, rc; > + size_t bytes = 0; > + u8 too_small; > + u8 *dst; > + > + /* Create a filled flexible array struct. */ > + src = kzalloc(src_len, GFP_KERNEL); > + KUNIT_ASSERT_TRUE(test, src != NULL); > + src->count = ELEMENTS_COUNT; > + src->after_padding = 13; > + for (i = 0; i < ELEMENTS_COUNT; i++) > + src->flex[i] = MAGIC_WORD; > + > + /* Over-allocate space to do past-src_len checking. */ > + dst = kzalloc(src_len * 2, GFP_KERNEL); > + KUNIT_ASSERT_TRUE(test, dst != NULL); > + cast = (void *)dst; > + > + /* Fail if dst is too small. */ > + rc = flex_to_mem(dst, copy_len - 1, src, &bytes); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure nothing was copied. */ > + KUNIT_EXPECT_EQ(test, bytes, 0); > + KUNIT_EXPECT_EQ(test, cast[0], 0); > + > + /* Fail if type too small to hold size of copy. */ > + KUNIT_EXPECT_GT(test, copy_len, type_max(typeof(too_small))); > + rc = flex_to_mem(dst, copy_len, src, &too_small); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Make sure nothing was copied. */ > + KUNIT_EXPECT_EQ(test, bytes, 0); > + KUNIT_EXPECT_EQ(test, cast[0], 0); > + > + /* Check good copy. */ > + rc = flex_to_mem(dst, copy_len, src, &bytes); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_EXPECT_EQ(test, bytes, copy_len); > + /* Spot check the copy */ > + KUNIT_EXPECT_EQ(test, cast[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT / 2], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT - 1], MAGIC_WORD); > + /* Make sure nothing was written after last element. */ > + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT], 0); > + > + kfree(dst); > + kfree(src); > +#undef MAGIC_WORD > +#undef ELEMENTS_COUNT > +} > + > +static void flex_to_mem_dup_test(struct kunit *test) > +{ > +#define ELEMENTS_COUNT 210 > +#define MAGIC_WORD 0xF0F1F2F3 > + struct flex_dup_obj *obj, **null = NULL; > + struct flex_cpy_obj *src; > + typeof(*src->flex) *cast; > + size_t obj_len = struct_size(obj, fas.flex, ELEMENTS_COUNT); > + size_t src_len = struct_size(src, flex, ELEMENTS_COUNT); > + size_t copy_len = flex_array_size(src, flex, ELEMENTS_COUNT); > + int i, rc; > + size_t bytes = 0; > + u8 too_small = 0; > + u8 *dst = NULL; > + > + /* Create a filled flexible array struct. */ > + obj = kzalloc(obj_len, GFP_KERNEL); > + KUNIT_ASSERT_TRUE(test, obj != NULL); > + obj->fas.count = ELEMENTS_COUNT; > + obj->fas.after_padding = 13; > + for (i = 0; i < ELEMENTS_COUNT; i++) > + obj->fas.flex[i] = MAGIC_WORD; > + src = &obj->fas; > + > + /* Fail if type too small to hold size of copy. */ > + KUNIT_EXPECT_GT(test, src_len, type_max(typeof(too_small))); > + rc = flex_to_mem_dup(&dst, &too_small, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + KUNIT_EXPECT_TRUE(test, dst == NULL); > + KUNIT_EXPECT_EQ(test, too_small, 0); > + > + /* Fail if @alloc_size is NULL. */ > + KUNIT_EXPECT_TRUE(test, dst == NULL); > + rc = flex_to_mem_dup(&dst, dst, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + KUNIT_EXPECT_TRUE(test, dst == NULL); > + > + /* Fail if @alloc is NULL. */ > + rc = flex_to_mem_dup(null, &bytes, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + KUNIT_EXPECT_TRUE(test, dst == NULL); > + KUNIT_EXPECT_EQ(test, bytes, 0); > + > + /* Check good copy. */ > + rc = flex_to_mem_dup(&dst, &bytes, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_EXPECT_TRUE(test, dst != NULL); > + KUNIT_EXPECT_EQ(test, bytes, copy_len); > + cast = (void *)dst; > + /* Spot check the copy */ > + KUNIT_EXPECT_EQ(test, cast[0], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT / 2], MAGIC_WORD); > + KUNIT_EXPECT_EQ(test, cast[ELEMENTS_COUNT - 1], MAGIC_WORD); > + > + /* Fail if *@alloc is non-NULL. */ > + bytes = 0; > + rc = flex_to_mem_dup(&dst, &bytes, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + KUNIT_EXPECT_EQ(test, bytes, 0); > + > + kfree(dst); > + kfree(obj); > +#undef MAGIC_WORD > +#undef ELEMENTS_COUNT > +} > + > +static struct kunit_case flex_array_test_cases[] = { > + KUNIT_CASE(struct_test), > + KUNIT_CASE(flex_cpy_test), > + KUNIT_CASE(flex_dup_test), > + KUNIT_CASE(mem_to_flex_test), > + KUNIT_CASE(mem_to_flex_dup_test), > + KUNIT_CASE(flex_to_mem_test), > + KUNIT_CASE(flex_to_mem_dup_test), > + {} > +}; > + > +static struct kunit_suite flex_array_test_suite = { > + .name = "flex_array", > + .test_cases = flex_array_test_cases, > +}; > + > +kunit_test_suite(flex_array_test_suite); > + > +MODULE_LICENSE("GPL"); > -- > 2.32.0 > From xen-devel-bounces@lists.xenproject.org Wed May 04 05:17:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:17:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320097.540980 (Exim 4.92) (envelope-from ) id 1nm7OB-0005OK-4w; Wed, 04 May 2022 05:17:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320097.540980; Wed, 04 May 2022 05:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7O9-0005JO-LQ; Wed, 04 May 2022 05:17:25 +0000 Received: by outflank-mailman (input) for mailman id 320097; Wed, 04 May 2022 03:22:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm5ac-0000p6-IW for xen-devel@lists.xenproject.org; Wed, 04 May 2022 03:22:10 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 615b0ec5-cb59-11ec-a406-831a346695d4; Wed, 04 May 2022 05:22:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18892B8232A; Wed, 4 May 2022 03:22:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A314DC385A4; Wed, 4 May 2022 03:21:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 615b0ec5-cb59-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651634526; bh=CbH7e4NC57tInXkJXSsd/52EmX/XddNYerXxPthi51M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DIwdXVh+VV/zYYIjKLXr4Szv2+RVCJso7Yrna+VEBVSMJIQebRGfEQocYWQ9qhBs9 dQhrwZuigtil9oBZ0XW5HelOufcdZFi1O1bEAbcRZ9J3x10G9yhO9l+C09ZtlmyZZw GpucC3kt0l5cbMUvCa/VeS02litV5lRqA8iw3KlM+jhY2mY8KWgoCBOGbAq/+BTRhA S5YyOElAtqNxHS/8Wxq/re4LfIWS6fv/NGLYVJZNcc3jPTL6Uv6dSAbPCH8oAPDBUW 0SnkgLUJaaLFnOfHJVoL8Ba5zNeTdXKoSb3ecp2gjmvxidB+mHtoYDlFTsxQh+zp9M 5qO0Pg46G3n2A== Date: Tue, 3 May 2022 22:31:05 -0500 From: "Gustavo A. R. Silva" To: Kees Cook Cc: Rasmus Villemoes , "David S. Miller" , Jakub Kicinski , Rich Felker , Eric Dumazet , netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 01/32] netlink: Avoid memcpy() across flexible array boundary Message-ID: <20220504033105.GA13667@embeddedor> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504014440.3697851-2-keescook@chromium.org> On Tue, May 03, 2022 at 06:44:10PM -0700, Kees Cook wrote: > In preparation for run-time memcpy() bounds checking, split the nlmsg > copying for error messages (which crosses a previous unspecified flexible > array boundary) in half. Avoids the future run-time warning: > > memcpy: detected field-spanning write (size 32) of single field "&errmsg->msg" (size 16) > > Creates an explicit flexible array at the end of nlmsghdr for the payload, > named "nlmsg_payload". There is no impact on UAPI; the sizeof(struct > nlmsghdr) does not change, but now the compiler can better reason about > where things are being copied. > > Fixed-by: Rasmus Villemoes > Link: https://lore.kernel.org/lkml/d7251d92-150b-5346-6237-52afc154bb00@rasmusvillemoes.dk > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Rich Felker > Cc: Eric Dumazet > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > include/uapi/linux/netlink.h | 1 + > net/netlink/af_netlink.c | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h > index 855dffb4c1c3..47f9342d51bc 100644 > --- a/include/uapi/linux/netlink.h > +++ b/include/uapi/linux/netlink.h > @@ -47,6 +47,7 @@ struct nlmsghdr { > __u16 nlmsg_flags; /* Additional flags */ > __u32 nlmsg_seq; /* Sequence number */ > __u32 nlmsg_pid; /* Sending process port ID */ > + __u8 nlmsg_payload[];/* Contents of message */ > }; > > /* Flags values */ > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index 1b5a9c2e1c29..09346aee1022 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -2445,7 +2445,10 @@ void netlink_ack(struct sk_buff *in_skb, struct nlmsghdr *nlh, int err, > NLMSG_ERROR, payload, flags); > errmsg = nlmsg_data(rep); > errmsg->error = err; > - memcpy(&errmsg->msg, nlh, payload > sizeof(*errmsg) ? nlh->nlmsg_len : sizeof(*nlh)); > + errmsg->msg = *nlh; > + if (payload > sizeof(*errmsg)) > + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, > + nlh->nlmsg_len - sizeof(*nlh)); They have nlmsg_len()[1] for the length of the payload without the header: /** * nlmsg_len - length of message payload * @nlh: netlink message header */ static inline int nlmsg_len(const struct nlmsghdr *nlh) { return nlh->nlmsg_len - NLMSG_HDRLEN; } (would that function use some sanitization, though? what if nlmsg_len is somehow manipulated to be less than NLMSG_HDRLEN?...) Also, it seems there is at least one more instance of this same issue: diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 16ae92054baa..d06184b94af5 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -1723,7 +1723,8 @@ call_ad(struct net *net, struct sock *ctnl, struct sk_buff *skb, nlh->nlmsg_seq, NLMSG_ERROR, payload, 0); errmsg = nlmsg_data(rep); errmsg->error = ret; - memcpy(&errmsg->msg, nlh, nlh->nlmsg_len); + errmsg->msg = *nlh; + memcpy(errmsg->msg.nlmsg_payload, nlh->nlmsg_payload, nlmsg_len(nlh)); cmdattr = (void *)&errmsg->msg + min_len; ret = nla_parse(cda, IPSET_ATTR_CMD_MAX, cmdattr, -- Gustavo [1] https://elixir.bootlin.com/linux/v5.18-rc5/source/include/net/netlink.h#L577 From xen-devel-bounces@lists.xenproject.org Wed May 04 05:49:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 05:49:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320330.540997 (Exim 4.92) (envelope-from ) id 1nm7t4-0005KX-1G; Wed, 04 May 2022 05:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320330.540997; Wed, 04 May 2022 05:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7t3-0005KQ-Tx; Wed, 04 May 2022 05:49:21 +0000 Received: by outflank-mailman (input) for mailman id 320330; Wed, 04 May 2022 05:49:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7t1-0005KK-Ul for xen-devel@lists.xenproject.org; Wed, 04 May 2022 05:49:20 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efe7d668-cb6d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 07:49:18 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id x17so540720lfa.10 for ; Tue, 03 May 2022 22:49:18 -0700 (PDT) Received: from jade.urgonet (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id t7-20020ac24c07000000b0047255d210f7sm1116784lfq.38.2022.05.03.22.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 22:49:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efe7d668-cb6d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hnuRMXxh5aQGAD1Jx6BN0KvTPVXOtPiamofA9IF2SH4=; b=Lo85xaqPggn9ooAYY+cHhZ3i0SF/lO7zTZFn6zxJtV3orxZPMiasR4zs+B/CBT7c5f y7kionomVlhujBfeARorySQBgbGKCoBF5mee7k7hgHIYvA+gwP1HJiZCkuZ7Ugfg9o/k kLxl5vMOAUKzbrJivafe6dw+fcWm6b/8tMenIrbSKTbxgiccRi/OPW7ONb/bY6MJuDE7 FBfeD1VlJKmWLJy1OvvmPpDBKoda+JjRu2kfuApWiZh4HOy7rJqMAy3nT5Ns1/E5r2pt uJq4ysd9XrpfLjq4pf6Tgs3Vo77bljtwyvrMVsFesGBjFUxvgHrW+FGE0S5kQTEhik2v zWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hnuRMXxh5aQGAD1Jx6BN0KvTPVXOtPiamofA9IF2SH4=; b=R9RuVb2EUuGPtlFAgRv2eTuD3ycXt7wbqzDVIp7XYvCA9P69r0MyicA8wVkbyNQ9CH mT8L/FHUGPYqG10DcFDzvpgO7lhc2mzXeCeWojUvVfygSSjHaqPImNideYWcAaS0fSoR dXnZyiW5PNzNEHJNa3X7zZAdR/wIJ248bWKa1lvwBazjFiaqzzcBeMKwq34wMpoy1UoP AGEeNHZelJSQ4/BzT7sl4LMS+hFLpcTarpu4tJsus5HMvnrNgImhF5SIMQ7BNFlWyy7C Fso91wL9BCzcnrjgNsh67ele8GIqI14TLc/+XaEOYEfF6c7Xg1Q156HYF6fV9QX/x+I0 JgEA== X-Gm-Message-State: AOAM533ligtReN8x78+7SdfdjAjdaYK/a+pLpdsILd4YiHSoiKkbDQUR 9N3HDZNHAivtfSwf/wuSzxw0S/ZtRUyVRw== X-Google-Smtp-Source: ABdhPJzfPaIq44pZy65eLPYJDGAlkEn8nDBePwG0XSIDFOBmAsrqAjHTt5Ke5wFv5ZvmAxl+Eg/IWw== X-Received: by 2002:a05:6512:128f:b0:473:a2ec:5df6 with SMTP id u15-20020a056512128f00b00473a2ec5df6mr5696351lfs.196.1651643357330; Tue, 03 May 2022 22:49:17 -0700 (PDT) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: [PATCH] optee: immediately free RPC buffers that are released by OP-TEE Date: Wed, 4 May 2022 07:49:12 +0200 Message-Id: <287f81d7cec66b5ef1f8f3f61679b9593e2b81d4.1651643156.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit fixes a case overlooked in [1]. There are two kinds of shared memory buffers used by OP-TEE: 1. Normal payload buffer 2. Internal command structure buffers The internal command structure buffers are represented with a shadow copy internally in Xen since this buffer can contain physical addresses that may need to be translated between real physical address and guest physical address without leaking information to the guest. [1] fixes the problem when releasing the normal payload buffers. The internal command structure buffers must be released in the same way. Failure to follow this order opens a window where the guest has freed the shared memory but Xen is still tracking the buffer. During this window the guest may happen to recycle this particular shared memory in some other thread and try to use it. Xen will block this which will lead to spurious failures to register a new shared memory block. Fix this by freeing the internal command structure buffers first before informing the guest that the buffer can be freed. [1] 5b13eb1d978e ("optee: immediately free buffers that are released by OP-TEE") Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/optee.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 8a39fe33b0ef..539a862fd185 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -1149,6 +1149,11 @@ static int handle_rpc_return(struct optee_domain *ctx, call->rpc_data_cookie = 0; } unmap_domain_page(shm_rpc->xen_arg); + } else if ( call->rpc_op == OPTEE_SMC_RPC_FUNC_FREE ) { + uint64_t cookie = regpair_to_uint64(get_user_reg(regs, 1), + get_user_reg(regs, 2)); + + free_shm_rpc(ctx, cookie); } return ret; @@ -1598,13 +1603,6 @@ static void handle_rpc(struct optee_domain *ctx, struct cpu_user_regs *regs) case OPTEE_SMC_RPC_FUNC_ALLOC: handle_rpc_func_alloc(ctx, regs, call); return; - case OPTEE_SMC_RPC_FUNC_FREE: - { - uint64_t cookie = regpair_to_uint64(call->rpc_params[0], - call->rpc_params[1]); - free_shm_rpc(ctx, cookie); - break; - } case OPTEE_SMC_RPC_FUNC_FOREIGN_INTR: break; case OPTEE_SMC_RPC_FUNC_CMD: -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Wed May 04 06:34:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 06:34:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320328.541014 (Exim 4.92) (envelope-from ) id 1nm8ab-0002GN-JE; Wed, 04 May 2022 06:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320328.541014; Wed, 04 May 2022 06:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm8ab-0002GG-G5; Wed, 04 May 2022 06:34:21 +0000 Received: by outflank-mailman (input) for mailman id 320328; Wed, 04 May 2022 05:43:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm7nD-0005FP-4y for xen-devel@lists.xenproject.org; Wed, 04 May 2022 05:43:19 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 190212bb-cb6d-11ec-a406-831a346695d4; Wed, 04 May 2022 07:43:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93BAFB8223A; Wed, 4 May 2022 05:43:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1EF2C385A5; Wed, 4 May 2022 05:42:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 190212bb-cb6d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651642995; bh=JrTxy6eXsiDtGM/F/9OTUVdSC11/W1yM6qcTiJhEEWY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ptNmZdYs+o6KHSEb902G1QgyncrLgIYxwRjyZ9+W9VTxnFGJHKAdTcbe0JtEXzd4l aYwCxztA+GFA6BxNwpRJ+fwdrhYF+K4ZZZLdzPKi8lBBWFO/VNZwdIAlyDMFIxmOWz hAmvQ+5DrbHNQghYSGB1afStWvfnMlPcYreVpeGPzS9YPA/9Y4p/yFDlQcLqjzbi/7 oTPIz0yt7M1rWvdVDxqtNaenj2/snIMXH2fVjjBqgI4xeMRFMaS+uomXQ38nO6fIxg l9QT60aMp2PNBolRmvUG9+MmaPk4GD+QjG/dwTaQmabfDmxvYb7M7hfSFb2fcWpc9I jV5YMv8gNlmpA== From: Kalle Valo To: Kees Cook Cc: "Gustavo A . R . Silva" , Loic Poulain , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?utf-8?Q?G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?utf-8?Q?S=C3=A1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 10/32] wcn36xx: Use mem_to_flex_dup() with struct wcn36xx_hal_ind_msg References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-11-keescook@chromium.org> Date: Wed, 04 May 2022 08:42:46 +0300 In-Reply-To: <20220504014440.3697851-11-keescook@chromium.org> (Kees Cook's message of "Tue, 3 May 2022 18:44:19 -0700") Message-ID: <8735hpc0q1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Kees Cook writes: > As part of the work to perform bounds checking on all memcpy() uses, > replace the open-coded a deserialization of bytes out of memory into a > trailing flexible array by using a flex_array.h helper to perform the > allocation, bounds checking, and copying. > > Cc: Loic Poulain > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: wcn36xx@lists.infradead.org > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook [...] > --- a/drivers/net/wireless/ath/wcn36xx/smd.h > +++ b/drivers/net/wireless/ath/wcn36xx/smd.h > @@ -46,8 +46,8 @@ struct wcn36xx_fw_msg_status_rsp { > > struct wcn36xx_hal_ind_msg { > struct list_head list; > - size_t msg_len; > - u8 msg[]; > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, msg_len); > + DECLARE_FLEX_ARRAY_ELEMENTS(u8, msg); This affects readability quite a lot and tbh I don't like it. Isn't there any simpler way to solve this? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From xen-devel-bounces@lists.xenproject.org Wed May 04 06:41:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 06:41:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320343.541024 (Exim 4.92) (envelope-from ) id 1nm8hS-0003go-An; Wed, 04 May 2022 06:41:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320343.541024; Wed, 04 May 2022 06:41:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm8hS-0003gh-7s; Wed, 04 May 2022 06:41:26 +0000 Received: by outflank-mailman (input) for mailman id 320343; Wed, 04 May 2022 06:41:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm8hQ-0003gb-PU for xen-devel@lists.xenproject.org; Wed, 04 May 2022 06:41:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 36124092-cb75-11ec-a406-831a346695d4; Wed, 04 May 2022 08:41:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B834F1042; Tue, 3 May 2022 23:41:21 -0700 (PDT) Received: from [10.57.2.7] (unknown [10.57.2.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B6503FA49; Tue, 3 May 2022 23:41:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36124092-cb75-11ec-a406-831a346695d4 Message-ID: <87eb6f25-c940-8aa2-bab3-dea9bcf1760b@arm.com> Date: Wed, 4 May 2022 08:41:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220428094625.382970-1-michal.orzel@arm.com> <074a5ae8-cade-3343-0c18-8122c85fecc3@xen.org> From: Michal Orzel In-Reply-To: <074a5ae8-cade-3343-0c18-8122c85fecc3@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Julien, On 03.05.2022 19:44, Julien Grall wrote: > Hi, > > On 28/04/2022 10:46, Michal Orzel wrote: >> Function unmap_common_complete (common/grant_table.c) defines and sets >> a variable ld that is later on passed to a macro: >> gnttab_host_mapping_get_page_type(). >> On Arm this macro does not make use of any arguments causing a compiler >> to warn about unused-but-set variable (when -Wunused-but-set-variable >> is enabled). Fix it by casting the arguments to void in macro's body. >> >> While there, take the opportunity to modify other macros in this file >> that do not make use of all the arguments to prevent similar issues in >> the future. >> >> Signed-off-by: Michal Orzel >> --- >> Changes since v1: >> -standalone patch carved out from a series (other patches already merged) >> -v1 was ([3/8] gnttab: Remove unused-but-set variable) >> -modify macro on Arm instead of removing ld variable >> --- >>   xen/arch/arm/include/asm/grant_table.h | 13 ++++++++----- >>   1 file changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h >> index d31a4d6805..5bcd1ec528 100644 >> --- a/xen/arch/arm/include/asm/grant_table.h >> +++ b/xen/arch/arm/include/asm/grant_table.h >> @@ -31,10 +31,11 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >>     int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >>                                 unsigned int flags, unsigned int cache_flags); >> -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) >> +#define gnttab_host_mapping_get_page_type(ro, ld, rd) \ >> +    ((void)(ro), (void)(ld), (void)(rd), 0) > > I would switch to a static inline helper: > > static inline bool > gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, >                       struct domian *rd) > { >     return false; > } > > Note the switch from 0 to false as the function is technically returning a boolean (see the x86 implementation). > >>   int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >>                                  unsigned long new_gpaddr, unsigned int flags); >> -#define gnttab_release_host_mappings(domain) 1 >> +#define gnttab_release_host_mappings(domain) ((void)(domain), 1) > > Same here. > Ok, sounds right. >>     /* >>    * The region used by Xen on the memory will never be mapped in DOM0 >> @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >>   }) >>     #define gnttab_shared_gfn(d, t, i)                                       \ >> -    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >> +    ((void)(d),                                                          \ >> +     ((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >>   -#define gnttab_status_gfn(d, t, i)                                       \ >> -    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) >> +#define gnttab_status_gfn(d, t, i)                                        \ >> +    ((void)(d),                                                           \ >> +     ((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) > > I share Jan's opinion here. If we want to evaluate d, then we should make sure t and i should be also evaluated once. However, IIRC, they can't be turned to static inline because the type of t (struct grant_table) is not fully defined yet. > Then, we could do like this: #define gnttab_shared_gfn(d, t, i) \ ({ \ const unsigned int _i = (i); \ const struct grant_table *_t = (t); \ (void)(d); \ (_i >= nr_grant_frames(_t)) ? INVALID_GFN \ : _t->arch.shared_gfn[_i]; \ }) However, if we start modifying the macros to evaluate args only once, shouldn't we also take care of the following macros in this file?: gnttab_set_frame_gfn gnttab_init_arch I'm ok to do these changes but I'm afriad we are losing the origin of this patch as we are focusing on macros not related to the issue. > Cheers > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Wed May 04 07:22:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320354.541035 (Exim 4.92) (envelope-from ) id 1nm9LF-00089U-BK; Wed, 04 May 2022 07:22:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320354.541035; Wed, 04 May 2022 07:22:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9LF-00089N-8P; Wed, 04 May 2022 07:22:33 +0000 Received: by outflank-mailman (input) for mailman id 320354; Wed, 04 May 2022 07:22:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9LD-00089D-Fb; Wed, 04 May 2022 07:22:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9LD-0006jm-BT; Wed, 04 May 2022 07:22:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9LC-0000Wh-Uo; Wed, 04 May 2022 07:22:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm9LC-0001hf-UM; Wed, 04 May 2022 07:22:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+EUTOJ4tuU2l4XtMmBKwAhMV9CPldiFOQq8gE/Kc9Go=; b=solM9sD6zhwI4i8xkIRJMteh3E wTU2QE4m9tPupjQyP3DXgJia5Bbn3dBZhbtf5BRQwaZ7iYhtglBSE0uuVXx5k6++AGy0V/Osl7PGs 5Gq5d3FlCb4YB+zVG7cYDI646ys2sG68LYcuiBt1g3NNmddm2yOxz0vAwB3ZlYdlxg3I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170079: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 07:22:30 +0000 flight 170079 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170079/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 793 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 07:25:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:25:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320362.541047 (Exim 4.92) (envelope-from ) id 1nm9Nj-0000Ig-Oy; Wed, 04 May 2022 07:25:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320362.541047; Wed, 04 May 2022 07:25:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9Nj-0000IZ-M4; Wed, 04 May 2022 07:25:07 +0000 Received: by outflank-mailman (input) for mailman id 320362; Wed, 04 May 2022 07:25:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9Nh-0000IT-GN for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:25:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50d6f773-cb7b-11ec-a406-831a346695d4; Wed, 04 May 2022 09:25:04 +0200 (CEST) Received: from DU2P250CA0008.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::13) by VE1PR08MB4958.eurprd08.prod.outlook.com (2603:10a6:803:108::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 07:25:02 +0000 Received: from DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::43) by DU2P250CA0008.outlook.office365.com (2603:10a6:10:231::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25 via Frontend Transport; Wed, 4 May 2022 07:25:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT048.mail.protection.outlook.com (10.152.21.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 07:25:01 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Wed, 04 May 2022 07:25:01 +0000 Received: from 17540dd481bc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 68086438-E78C-43E4-B034-4B75AEAEFAFD.1; Wed, 04 May 2022 07:24:54 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17540dd481bc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 07:24:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB4301.eurprd08.prod.outlook.com (2603:10a6:803:f7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 07:24:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Wed, 4 May 2022 07:24:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50d6f773-cb7b-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EwBQ0yrTymwqJ3V/bOHM5iU78coyBUarhUFnTdy+d4TuVcxEE3XaYX6Nr3EQaZieh4Vf6QdaIMN0ZYrn+P/3GsMzdDimVftD+zbSuCfbbzNqD9YpYMxARbXMAx0AD8j52AV6OyRGsrineOxwu8n4JEqJBSg9W82N42CmnLjg4WdCpiCxTafTyXXTAGYCSByzDUUFHNzbscb9BVLrwRsv1coYO/gmN7j0N81keRhHAariqzbqRDJv1VfdPTFv7zIBlqWhjNN4pIKapYsnheRAc5JCTvIDG3BpNz4fAXjvSxJUPSr8of6aFtxtZAeDIcSdysf5GoVpEfTKJ9O00seVIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9fcqZ04iw2IdItrRajTwSyqV3xUNBwyExasmtmjCK0=; b=Ft38bnwoJh2eNX0QKiw8YkxkluCubA1EyZIXf1PRZ4Ajr4uGwfFgOhgxC8Hh4irKB19HKvJtBYY0J1q4tOc4ETNdQyF2nTV5K+/+nfkLHs5u6pwgWL4Yu3USLUDzRA6eyQVnlT2+oIhBX1NJwvL5uNAtp6bL9STS5h62Nn1lWKUFEp8/BjvuiYEiWC/STNJeBLN38x+d8b+WEnXn2jir/n2DCap4UmPqe698gWGJtTl/Q7IwXuna+5sekB246uilV2wSa6ArsQw1suCLw88uqsq6+QGowCtNGwvvnOdD0clfVVGqMEl1dNcxbFvev/RGqmRm3WT54EL49Qiq7uGXnw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9fcqZ04iw2IdItrRajTwSyqV3xUNBwyExasmtmjCK0=; b=zmKKmxgUMhM2kOdTlLFqa3jKax9Xkeqg8Wexnj0uAfOBBeDO3NdTOqSHOXWRWQyrCMuERu9Dh2If0PuI9Kg+NRXCvVxR+PkOQJlKA07pDevuEYV97AcgaSHoZokWEJuegBf+KDpNbN6KxTJWM99ja841w+G009LSYHlTrbJ6z0c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a1954b95020bb84 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9zLv7KysRB44FLxkA+Ga/Zs0qykciW7hYnxiBc6q4bsFTrxJB0jZJB62IH4upyU44T8nDHFYPdxwDAfUMxF+lpeJE12jpp8L0fQ4bpicksprMGFeF7xJ8WImjP0ZoanYa4QXcZGpOBPZKDEraWrXNH0nQ6j1d3I2iol450zvx7a9Oyp6fbKNz9vp6L3KpjQsunSFjISeFRI2zwPaRqzpg4qJA5UKPRgsyDdC9oamF+ef4QWrcOVy70sT8JqVP1aqGFaqlluFwra7hmCqX+LKaz/CJRIws+jMZh1A2w4s0aEqqSGoVOJwmpEm9VU+2jilkBzECumf9SuX4xG9coiXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9fcqZ04iw2IdItrRajTwSyqV3xUNBwyExasmtmjCK0=; b=e/cuHNjDdZ7+u8BjFq8fRGRNfOLtt6jlK/c6kGMBAbs09myAeiSEww9kV6ku6+fjS+kRsD1z87LXpaGNfp6pqVk/NVYavPSttM+STzQuN5JCwPYvU7PpXXFam3uq/hn7ZlAF+8vvjMFzZ3p+AHwIRnnrO6o8rROUZLMJKiEym8AHclE/4+oV2jxVvRFTGUGh+cOvK870uMoPtdEIp6WoPY09y4F0nhPoYzU50+W1UzskXz9TiaF2b3R5ltbTON9JGfjD4BIzsU5oLEH1VfJbu9RR5Hk74xyMnliuL2bnKfpJusWv35A024qeXtIu+3X/4frPQURC9sraJy24prFcBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9fcqZ04iw2IdItrRajTwSyqV3xUNBwyExasmtmjCK0=; b=zmKKmxgUMhM2kOdTlLFqa3jKax9Xkeqg8Wexnj0uAfOBBeDO3NdTOqSHOXWRWQyrCMuERu9Dh2If0PuI9Kg+NRXCvVxR+PkOQJlKA07pDevuEYV97AcgaSHoZokWEJuegBf+KDpNbN6KxTJWM99ja841w+G009LSYHlTrbJ6z0c= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Topic: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Index: AQHYXtGbLw8lUArxPEOQFl634Avmjq0NftKAgADToQA= Date: Wed, 4 May 2022 07:24:52 +0000 Message-ID: References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> In-Reply-To: <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 210d7183-6a91-4ae6-ba6f-08da2d9f3372 x-ms-traffictypediagnostic: VI1PR08MB4301:EE_|DB5EUR03FT048:EE_|VE1PR08MB4958:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VhcdsuevpH6ildDAMR8ORcKP0dgRb48SUq5rVVxs1KH75Z+40F1onNPA8MjP98HOh6107cJw4ZWJmuptzQonuA9EcO3blHT3NuheSxPwWMvmU67kPOfqYBxe2gI7/j7gfqnEdyNytLwa4gAXVCxUadLb5Aoif7B1VGd6cD1AnyW7su1iQXaphDo2AyBqyZBWYVMCWbPSAJkk3SrYJt/GOF0KEM+HuEMsTVY6l9kqDqr1KbEhe2PQ9Mxjo0+fxWOM7677led7QIMM8l7hyou2j0RdIm/pZYVaes/6GovjYLkEGPyG2VUWURNAPKv0o3+7NoAcfTRsZTJshTnmOscTZWK/AjUoZ58tEflOnNWTm7yJp5fpIMrNEFYW34s9TTh724TLxJSRKlN7Hz8W5XPb3BbwKIorC8LmqKqXFS5A73wjUm1iZzRpy6l5BbH65swvHzSQDQ1q3l/aW/BjG4s8sfPGm2fYixB2Y8CWS7Jw/96mlCKHr4eVh5h4Pjuj1514SbOR1EOuj1/vIvI4flZGhrKPoF1HOI0n5/2MGnM5QnRroVEGC4fqk41tZjWBUhXg2LIsmtlJzU01zAe/v+qcyJZU/1epu0xSUnXE+k4+6KSwzHFqeUbTyZLqv0TwHawHNqO/fM7v/69lfAbSCj4c4PL9LsZ6/9xGyZ5dWc0mjK2XJEYdsYjZiCUr0jzbVI5eiWMNw3fAggMAPqID0O8/Envme0/3+/2Wa+ngwyYDVIVpZvwyyAopnwHaOK7AxJbVWeQgZWWoUIA3lqJIiYNUMQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(71200400001)(316002)(508600001)(38070700005)(2616005)(6486002)(186003)(6512007)(53546011)(83380400001)(76116006)(5660300002)(6916009)(38100700002)(6506007)(91956017)(26005)(54906003)(36756003)(2906002)(122000001)(66446008)(4326008)(64756008)(8676002)(86362001)(66476007)(66556008)(66946007)(8936002)(21314003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4301 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ff6ce075-5bf8-4f8b-54ce-08da2d9f2e58 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LlOzVHmc+czLRpPLoLC64+aRXPLEFlBuaJxBEtiZzJHDOjI/7zRmRnX4WCG8WIIvwEawMbm/Q+hTfnwdgieoF4uRk6BW9oLvrzNyobmS6puAHK6Fm7td8ncCthiKeU21FgTmYWjim5A7r3FoOxjkGIfEaAhY8ejaqhfSmn44SRm+/9s/rBMPfB42/pkrs9fnSdXr91F1PKWmhy8LucuNUVtR5TqAw+okwDQWvnt4gsqxUp0tHQVbOZfeknaS/Ti1qgfKCYioFt6gkQJkQAsXuMduUF4EQHkoImtykYv4Gkbj6rskMiX1D6gKR+MYrB8QmugvQ+Z9jnq+caLTZLr1ZCzZkTRq3Ra+wzi2001MizizffEJeskaks2fITHSuD5Kh2JKjHmIct9D3eC7K6yG859Pvjr5ZnbdQlJJrHU97lW/JEo0T9+U9GOv2mHiwRipQRoAE6Ps5TDdX59oXr/9d9WuHnFE6m4OQR7Et8CiedjUJ2vUpOOeTaLvkJEeDLUN2/JZhfndP67shy10Vgoh0WBhn6WYWU+Ce8Mjh+ObooZ3rs9P3xO/csvWbGhyiFE+oVFvtP8AjGhKyfI98nrl/tjUb4FSS2N7vypZYmeB/wShnROg7LRfVcYGNKIFClAX7xCT/dcvltYfZrep+gWuQ+0SxZzAHPnZe/ZVJJ6jXMLxhKawN96sZaT7SqABvwxDs8XTHKvbSXMfYwrnp8JO3g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(82310400005)(81166007)(2906002)(4326008)(6862004)(8676002)(356005)(40460700003)(70206006)(70586007)(83380400001)(86362001)(36860700001)(47076005)(8936002)(316002)(5660300002)(53546011)(54906003)(6506007)(26005)(6512007)(36756003)(6486002)(33656002)(508600001)(2616005)(107886003)(186003)(336012)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 07:25:01.2397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 210d7183-6a91-4ae6-ba6f-08da2d9f3372 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4958 Hi Julien, > On 3 May 2022, at 19:47, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 03/05/2022 10:38, Bertrand Marquis wrote: >> This patch is adding sb instruction support when it is supported by a >> CPU on arm64. >> To achieve this, the "sb" macro is moved to sub-arch macros.h so that we >> can use sb instruction when available through alternative on arm64 and >> keep the current behaviour on arm32. >=20 > SB is also supported on Arm32. So I would prefer to introduce the encodin= g right now and avoid duplicating the .macro sb. I will look into that. >=20 >> A new cpuerrata capability is introduced to enable the alternative >=20 > 'sb' is definitely not an erratum. Errata are for stuff that are meant to= be specific to one (or multiple) CPU and they are not part of the architec= ture. >=20 > This is the first time we introduce a feature in Xen. So we need to add a= new array in cpufeature.c that will cover 'SB' for now. In future we could= add feature like pointer auth, LSE atomics... I am not quite sure why you would want to do that. Using the sb instruction is definitely something to do to solve erratas, if= a CPU is not impacted by those erratas, why would you want to use this ? >=20 >> code for sb when the support is detected using isa64 coprocessor >=20 > s/coprocessor/system/ Ack >=20 >> register. >> The sb instruction is encoded using its hexadecimal value. >=20 > This is necessary to avoid recursive macro, right? This is necessary for several reasons: - support compilers not supporting sb instructions (need encoding) - handle the alternative code (we do not want to repeat this everywhere) - avoid recursive macro >=20 >> diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/incl= ude/asm/arm64/macros.h >> index 140e223b4c..e639cec400 100644 >> --- a/xen/arch/arm/include/asm/arm64/macros.h >> +++ b/xen/arch/arm/include/asm/arm64/macros.h >> @@ -1,6 +1,24 @@ >> #ifndef __ASM_ARM_ARM64_MACROS_H >> #define __ASM_ARM_ARM64_MACROS_H >> +#include >> + >> + /* >> + * Speculative barrier >> + */ >> + .macro sb >> +alternative_if_not ARM64_HAS_SB >> + dsb nsh >> + isb >> +alternative_else >> +/* >> + * SB encoding as given in chapter C6.2.264 of ARM ARM (DDI 0487H.a). >> + */ >=20 > NIT: Please align the comment with ".inst" below. I also don't think it i= s necessary to mention the spec here. The instruction encoding is not going= to change. Ack >=20 >> + .inst 0xd50330ff >> + nop >=20 > Why do we need the NOP? Alternative requires both sides to have the same size hence the nop to have= 2 instructions as in the if. >=20 >> +alternative_endif >> + .endm >> + >> /* >> * @dst: Result of get_cpu_info() >> */ >> diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/includ= e/asm/cpufeature.h >> index 4719de47f3..9370805900 100644 >> --- a/xen/arch/arm/include/asm/cpufeature.h >> +++ b/xen/arch/arm/include/asm/cpufeature.h >> @@ -67,8 +67,9 @@ >> #define ARM_WORKAROUND_BHB_LOOP_24 13 >> #define ARM_WORKAROUND_BHB_LOOP_32 14 >> #define ARM_WORKAROUND_BHB_SMCC_3 15 >> +#define ARM64_HAS_SB 16 >> -#define ARM_NCAPS 16 >> +#define ARM_NCAPS 17 >> #ifndef __ASSEMBLY__ >> diff --git a/xen/arch/arm/include/asm/macros.h b/xen/arch/arm/include/a= sm/macros.h >> index 1aa373760f..91ea3505e4 100644 >> --- a/xen/arch/arm/include/asm/macros.h >> +++ b/xen/arch/arm/include/asm/macros.h >> @@ -5,15 +5,6 @@ >> # error "This file should only be included in assembly file" >> #endif >> - /* >> - * Speculative barrier >> - * XXX: Add support for the 'sb' instruction >> - */ >> - .macro sb >> - dsb nsh >> - isb >> - .endm >> - >> #if defined (CONFIG_ARM_32) >> # include >> #elif defined(CONFIG_ARM_64) >=20 > Cheers, Thanks for the review Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Wed May 04 07:25:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:25:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320367.541058 (Exim 4.92) (envelope-from ) id 1nm9OT-0000rg-4W; Wed, 04 May 2022 07:25:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320367.541058; Wed, 04 May 2022 07:25:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9OT-0000rZ-0B; Wed, 04 May 2022 07:25:53 +0000 Received: by outflank-mailman (input) for mailman id 320367; Wed, 04 May 2022 07:25:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9OS-0000pG-Bu for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:25:52 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0603.outbound.protection.outlook.com [2a01:111:f400:fe06::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d1b6af5-cb7b-11ec-a406-831a346695d4; Wed, 04 May 2022 09:25:51 +0200 (CEST) Received: from DB6PR07CA0165.eurprd07.prod.outlook.com (2603:10a6:6:43::19) by DB9PR08MB7177.eurprd08.prod.outlook.com (2603:10a6:10:2ca::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 07:25:50 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::6b) by DB6PR07CA0165.outlook.office365.com (2603:10a6:6:43::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.7 via Frontend Transport; Wed, 4 May 2022 07:25:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 07:25:49 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Wed, 04 May 2022 07:25:48 +0000 Received: from 44a58f65f1c0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 554B77AF-40FB-42D7-AED6-B7F156C36EDB.1; Wed, 04 May 2022 07:25:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 44a58f65f1c0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 07:25:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB7185.eurprd08.prod.outlook.com (2603:10a6:102:207::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 07:25:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Wed, 4 May 2022 07:25:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d1b6af5-cb7b-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L8t9Ij4FFkYD6P9Dcior8pMbleREACfwbTyBRUnCMIYgZw5437zOenIR6nhKdTz+un69Ftf/MMmLh54vDDIWTn0K+pZ6LwYEsZFTD2wHZJRskrtgxlEQfMVR3CvKH1VgTyVhtJdRmsihByU8TY+j8Dj8DiA/a1PCmyh3jRkQQqvIJqlyltYDzC5iJT+MMh1ZJNtz+DghCiR6sWmaLUvez9PCsiPNkdwZoDFJ3kFri92R4HaVbCdmL3Ha27YRMHytx9yvHOTFSsKhE6ITDM2t6ZKdmsqprUI60Sghr1XcRi6di58e7ANRnxMP0MqMRpXVmJgzULXPIxQ4e2LkIPPBTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4i6aKpT1Q9Wb0tSNFh84E7CqB5bX+55FNc8kTTdRO24=; b=SYpZsjCUtE4g7EkAQCHwpFgaZm5P4IlDoWSnHqSW/nSGGhkAoeHzsM9rWAgWjnpEx/ucHpUMmLDkhoLepHgAzihLhO3j5itjkQgXuXWbAOcoykZEiLRVgzLcsJJ6Gotf6HfLce8GohO6MRt8pPlRI2xZhHIpZaDhtIO0Xf1MDhE2TQ5hUncrzIMVLukhSKE4RNsWyBvPllWBctolHwfSVDEKzLFCa8cJGABf0mZ8Mk22akLCQAhm6KamIpGzzU8IhbqiT8nhsv4g3r2wWN1tBEAN3xvEZTguCURGqpPTHXAk1jYo/E1jUrKJo7iDyRfL/KFymxOuLhSpjJOpjTmsow== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4i6aKpT1Q9Wb0tSNFh84E7CqB5bX+55FNc8kTTdRO24=; b=uG1fFdWFLOhLmFQReDifOZjJFuRD6J10xX5oy8E7r3yeSYj/TLsu/UVv/J+aMZiOUY7NuE93nQqrQOakcEnLRy1GSNFOR4kn+qIuoom9xJpzPbHNwK82KTjYnyPI0FHO4Q6vCE0C45so2z1qN6XArBrrHWTmu0/KmfuKFaiVC5A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 61fd4502fcc52b69 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEW/1tsNcghplI60jU9gfIGi/4jjgrYhn4uukqz++RA9xWWjmZfXgDi5Z/Ia0ZdUcM5NVvA7BX2Hy1dUR2AmRqo5zMbrQHeNWaIq64LtxjXyKzVfyhTgQ/93SKPPvfuXAifwsMl7xdnlgUGDw1uiwSU2sBUexRjuwsqDqR7hycWDRenXadZPdrqqkpY452cCzA+qjUOz/VGQKhr41abECNw4aktVoqmcQdgo82gGm+KdR+sYREXEwVRdGmQZNkL8LzuicmoAgU/M8UvokBTxFwzbUQ3a1RTmYaAJ25HYfQoiD6PfPq7qb4zJONxRVLtLg0appZO9y/F5KEbyMEFHoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4i6aKpT1Q9Wb0tSNFh84E7CqB5bX+55FNc8kTTdRO24=; b=aZQ9JmIkXobb/xQefVbKVgcCbzhTr9QmdDqTTo4paHVnjp/8L4eYBhC6qfMPSwFgtozEYQ0tpZEBMnyky1gRpEImkq7CApYRg7hXv8+rGZW+1DoqN8DH0XmI8JdKS3ktmI6Z0UUnRt0mgoh5ydAOUJjiGbzEn8oiuDnoL3zwzY0UNbwjPK0usXdRktsYzuPXjed5RchfA/xnJs7CLvccNw1no+AOgEOciO7AVFO2uZFUWiiGEMsk9IXAGlwQaXppP2llQDUJEiKRuDLVZkJJqe2yq4DDH2FT9v5EpSxHca4t4xuSg6Una8uHmmbYiIzeM44jAf1NqnchrqtXgdzuqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4i6aKpT1Q9Wb0tSNFh84E7CqB5bX+55FNc8kTTdRO24=; b=uG1fFdWFLOhLmFQReDifOZjJFuRD6J10xX5oy8E7r3yeSYj/TLsu/UVv/J+aMZiOUY7NuE93nQqrQOakcEnLRy1GSNFOR4kn+qIuoom9xJpzPbHNwK82KTjYnyPI0FHO4Q6vCE0C45so2z1qN6XArBrrHWTmu0/KmfuKFaiVC5A= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3 Thread-Topic: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3 Thread-Index: AQHYXtGhCQ41RL6ZvkCIAGwqzunCAq0Ndo4AgADcHgA= Date: Wed, 4 May 2022 07:25:40 +0000 Message-ID: <3700FF65-C9BD-44D6-87EA-7C2B4B2A8557@arm.com> References: <8119538cce93516f1e78d37d578996a195686f89.1651570561.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88c2c7f4-c006-483f-1117-08da2d9f5007 x-ms-traffictypediagnostic: PAXPR08MB7185:EE_|DBAEUR03FT058:EE_|DB9PR08MB7177:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xOC2SGmrcSnsQsFpifoa7ES8lp+SMb6jWjmk+cW9MzNJzb3KxWPJlpXlTITTm1FEkVoP8UnTNAPDjhUToiWAiZqpzkyP9gKHMZn4X8ZNLgFZCycxCpEtvEAyHdLTDp8KDgBTiamyQ/fDqCBz5K3YFEdXufkjsgC9hOw5XM3h7iW/Sbcqbq2hPPt13MxCvqvRntRViRMTqx1Cu2NA/jz5L6sd7Rx/gb1Iden32yKue15V5HsTuwdGUClJc6HddSQ2vSK6BpwKAzImYepd/DLMPybCRT6QFW1wyrTV9pYJDq0IWji78qMkv/o+4tgBH61QZPs/RsFbVN42RaSQTZCAXWzpfM8TrcuSpluTABvEl+oy/osGQWlK2sYlEua9mGL2bLl1Jb+cRo3Fhnz00yJqu1VUqB+laKiUag+NkW4uRFUpzlE6OfmrwgviqkENQ1BQjuMtmSvt6x0vLatIxwa87Yh4/WeGqnn3Iyt/l9bOPt/qucs8P18m3Bgy3Yl6/Q32yIYcRVN/Bw4moWjfKakkScmJcV1UuPDoz2yhvDd++BLskKfzpAEWjvD2UM5FqBt73A+EaVKSMU81FroMCfszf4E7ZlYnd7+8N9IemtLv/hoRIgDK+hnoiOZS512MlSaFr0i0uiIzBtkUkKl2MjBsPF7lcY7l0Uj+LyIaAQ5fRDgTetfnBDUBvXWo8DkwG6++yn2Um9eJ/zLHwQSCphlEqsexqx7VqT2eQ5ZgGUIm2tZhtn8zSTFS+QPMwhFRtlNr X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(8936002)(508600001)(54906003)(38100700002)(38070700005)(122000001)(4744005)(6916009)(316002)(33656002)(6486002)(71200400001)(26005)(4326008)(66946007)(8676002)(76116006)(6512007)(64756008)(66476007)(66556008)(91956017)(66446008)(2616005)(83380400001)(186003)(86362001)(6506007)(53546011)(2906002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <8C58BD131A035140A772D28783ACA66C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7185 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be50143c-8ba4-410e-73fb-08da2d9f4aef X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B78BJoJqSdYnDwaa2oB2pdlHkrsQNZNlEP4ukFFSftoaGgVR6CE0oxqXbe9Q0Abr/TAHumEDRwmNL+Xm2a+GNSIJZ+QUikXdhkiSjiu1nbl2uEzvffPV9xIzD7ci6weFLLhix5Z+rS/Q8ydRNTHui+0x23IFK37ySQgcrGVx6JCfTJsCWXXDxIR682fus6sY95vC8azxyyFcJO9KUfOtaSEKns32HtgK2CQvkGgCQX1NuORIXHRzRuo86B4dd6Fpups5pQ/xq6p2+pW99kvpUbLbAQhN5ML5Fgx+F/XeO8aX30jb1XvZOWIp5nCf2g0TrG740TSNkuKJIHk5Nfd1rAcb9lTQork7dTUbDJ/NfaJOWsp8RXsIv2YKfD28S7NOebd/GSyKhGquPDuIHN8RIc7zi3zSTe4D4nDFqKu3QepU2JBVKeos5KYMVlgKxTqSpxyqlUvNKIm2CrdorxgIAEx0gVdq2ANpis1U17v9OwnKkYwE5YheGG2uHTh/YIL6Qq6RaIyncjU/p8n+vzHxfmQZfta4d6Ki65LveHsTPnNGWIOxZvTtmDjiJYcBmJnxQfPFOxn/wWdhK6vpMrAuje+p49b4p0sVqTEAnCSYnIyQ4N1QJushzLXF88XfbCnywW6EAhvcYhcC7IrwmDQkq7C2Ufm8Hh1hE67V7WsE3Yhqnc0OU72rPOIp4s43239a X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(33656002)(47076005)(316002)(5660300002)(6486002)(36860700001)(86362001)(336012)(2906002)(8936002)(186003)(26005)(4744005)(6506007)(54906003)(508600001)(53546011)(6512007)(83380400001)(107886003)(82310400005)(356005)(2616005)(81166007)(4326008)(40460700003)(6862004)(36756003)(8676002)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 07:25:49.1880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88c2c7f4-c006-483f-1117-08da2d9f5007 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7177 Hi Julien, > On 3 May 2022, at 19:17, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 03/05/2022 10:38, Bertrand Marquis wrote: >> SMCC_WORKAROUND_3 is handling both Spectre v2 and spectre BHB. >> So when a guest is asking if we support workaround 1, tell yes if we >> apply workaround 3 on exception entry as it handles it. >> This will allow guests not supporting Spectre BHB but impacted by >> spectre v2 to still handle it correctly. >> The modified behaviour is coherent with what the Linux kernel does in >> KVM for guests. >> While there use ARM_SMCCC_SUCCESS instead of 0 for the return code value >> for workaround detection to be coherent with Workaround 2 handling. >> Signed-off-by: Bertrand Marquis >=20 > Acked-by: Julien Grall Thanks >=20 > I think we should also consider for backport. Agree. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 07:30:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320377.541075 (Exim 4.92) (envelope-from ) id 1nm9Sd-0002OU-Us; Wed, 04 May 2022 07:30:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320377.541075; Wed, 04 May 2022 07:30:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9Sd-0002ON-S2; Wed, 04 May 2022 07:30:11 +0000 Received: by outflank-mailman (input) for mailman id 320377; Wed, 04 May 2022 07:29:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9Rt-0001cR-TK for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:29:26 +0000 Received: from sipsolutions.net (s3.sipsolutions.net [2a01:4f8:191:4433::2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb90edf8-cb7b-11ec-a406-831a346695d4; Wed, 04 May 2022 09:29:24 +0200 (CEST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nm9Oe-001wnb-ND; Wed, 04 May 2022 09:26:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb90edf8-cb7b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ity6IPNC2WIGLGTiJizfPDCFcsI1FfOGUjdPuI/9x1Q=; t=1651649364; x=1652858964; b=uLXceoXRzocE9rr9tSqSs3uwv2YN+Y2ols3vkwJs3Y80NTC SHrykdTo0rjdIMKD1kdUgluxp0pOBzv4vqReeotEDsKew0IA0V4g7ZTRWNZZsRXFODX7TO0A9D7NY IchhOKlEq5QBQFzOkV42FF1wCVIu3tXzAVjIhBKA0O87cF6n3RnAHUaXk+axAihNbPJMW5/YL5jQl EJRchlELJXVJAfqiU9LX00czxRGevoxwrxbu1sLHbNWZfH6AsHgi+hmPFIthDXbadbXtBfWz+gCeu ylNizrxU3D+4BhDE+2fuiAHq5Srn8Frknie+J+sc3cHV2I5EjxH4Ks1/gwZL9aJw==; Message-ID: Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers From: Johannes Berg To: Kees Cook , "Gustavo A . R . Silva" Cc: Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?ISO-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?ISO-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang , kvalo@kernel.org Date: Wed, 04 May 2022 09:25:56 +0200 In-Reply-To: <20220504014440.3697851-3-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned On Tue, 2022-05-03 at 18:44 -0700, Kees Cook wrote: > > For example, using the most complicated helper, mem_to_flex_dup(): > > /* Flexible array struct with members identified. */ > struct something { > int mode; > DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, how_many); > unsigned long flags; > DECLARE_FLEX_ARRAY_ELEMENTS(u32, value); In many cases, the order of the elements doesn't really matter, so maybe it'd be nicer to be able to write it as something like DECLARE_FLEX_STRUCT(something, int mode; unsigned long flags; , int, how_many, u32, value); perhaps? OK, that doesn't seem so nice either. Maybe struct something { int mode; unsigned long flags; FLEX_ARRAY( int, how_many, u32, value ); }; or so? The long and duplicated DECLARE_FLEX_ARRAY_ELEMENTS_COUNT and DECLARE_FLEX_ARRAY_ELEMENTS seems a bit tedious to me, at least in cases where the struct layout is not the most important thing (or it's already at the end anyway). > struct something *instance = NULL; > int rc; > > rc = mem_to_flex_dup(&instance, byte_array, count, GFP_KERNEL); > if (rc) > return rc; This seems rather awkward, having to set it to NULL, then checking rc (and possibly needing a separate variable for it), etc. But I can understand how you arrived at this: - need to pass instance or &instance or such for typeof() or offsetof() or such - instance = mem_to_flex_dup(instance, ...) looks too much like it would actually dup 'instance', rather than 'byte_array' - if you pass &instance anyway, checking for NULL is simple and adds a bit of safety but still, honestly, I don't like it. As APIs go, it feels a bit cumbersome and awkward to use, and you really need everyone to use this, and not say "uh what, I'll memcpy() instead". Maybe there should also be a realloc() version of it? > +/** __fas_bytes - Calculate potential size of flexible array structure I think you forgot "\n *" in many cases here after "/**". johannes From xen-devel-bounces@lists.xenproject.org Wed May 04 07:32:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:32:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320382.541086 (Exim 4.92) (envelope-from ) id 1nm9V3-000348-E0; Wed, 04 May 2022 07:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320382.541086; Wed, 04 May 2022 07:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9V3-000341-AN; Wed, 04 May 2022 07:32:41 +0000 Received: by outflank-mailman (input) for mailman id 320382; Wed, 04 May 2022 07:31:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9TT-0002nu-R0 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:31:03 +0000 Received: from sipsolutions.net (s3.sipsolutions.net [2a01:4f8:191:4433::2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26da81e1-cb7c-11ec-a406-831a346695d4; Wed, 04 May 2022 09:31:03 +0200 (CEST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nm9RJ-001wsH-EM; Wed, 04 May 2022 09:28:49 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26da81e1-cb7c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=VhRMkWupHGEpu4hR7M12B8TWP/ZW0H0fx/g6wrBtOIU=; t=1651649463; x=1652859063; b=HFA2AIZmqpf6+yeLRbS3PLbwviaP+jkvBWw3+3ulYKo4Q6o RhNfe0lL0GneTSfwgtZeMGTnAa5F6rr4VoyfFbyrIYWuO8K20dJY7AHtcytnKCwmKsQgOOTv/SCk0 BctPq2UoO7olDDZin4wFtpFfTfM/iM5ZwPmqMe3p8UbITyVOjVTYfWPV/gKKvhFLVi5K25ySIuBHU c4Ob5ITKIt3CjOcX+pNQrF1EPOJww6TZNrDIMmx21k/lEphFhyPvhJqGQHrMonnYVz65SiaCBU9F5 hbD/XYU1A2xaoHMOVcS30y7KN2GSEs1AYvdswyIRncfIBab6WzoSaFG4FleiR0Og==; Message-ID: Subject: Re: [PATCH 12/32] cfg80211: Use mem_to_flex_dup() with struct cfg80211_bss_ies From: Johannes Berg To: Kees Cook , "Gustavo A . R . Silva" Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?ISO-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?ISO-8859-1?Q?S=E1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Date: Wed, 04 May 2022 09:28:46 +0200 In-Reply-To: <20220504014440.3697851-13-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-13-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned On Tue, 2022-05-03 at 18:44 -0700, Kees Cook wrote: > > @@ -2277,7 +2274,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > size_t ielen = len - offsetof(struct ieee80211_mgmt, > u.probe_resp.variable); > size_t new_ie_len; > - struct cfg80211_bss_ies *new_ies; > + struct cfg80211_bss_ies *new_ies = NULL; > const struct cfg80211_bss_ies *old; > u8 cpy_len; > > @@ -2314,8 +2311,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > if (!new_ie) > return; > > - new_ies = kzalloc(sizeof(*new_ies) + new_ie_len, GFP_ATOMIC); > - if (!new_ies) > + if (mem_to_flex_dup(&new_ies, new_ie, new_ie_len, GFP_ATOMIC)) > goto out_free; > > pos = new_ie; > @@ -2333,10 +2329,8 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > memcpy(pos, mbssid + cpy_len, ((ie + ielen) - (mbssid + cpy_len))); > > /* update ie */ > - new_ies->len = new_ie_len; > new_ies->tsf = le64_to_cpu(mgmt->u.probe_resp.timestamp); > new_ies->from_beacon = ieee80211_is_beacon(mgmt->frame_control); > - memcpy(new_ies->data, new_ie, new_ie_len); This introduces a bug, "new_ie" is modified between the kzalloc() and the memcpy(), but you've moved the memcpy() into the allocation. In fact, new_ie is completely freshly kzalloc()'ed at this point. So you need to change the ordering here, but since new_ie is freed pretty much immediately, we can probably just build the stuff directly inside new_ies->data, though then of course we cannot use your helper anymore? johannes From xen-devel-bounces@lists.xenproject.org Wed May 04 07:40:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320395.541097 (Exim 4.92) (envelope-from ) id 1nm9c2-0003jr-4d; Wed, 04 May 2022 07:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320395.541097; Wed, 04 May 2022 07:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9c2-0003jk-0z; Wed, 04 May 2022 07:39:54 +0000 Received: by outflank-mailman (input) for mailman id 320395; Wed, 04 May 2022 07:39:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9c0-0003jd-6H for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:39:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0d::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6197a7eb-cb7d-11ec-a406-831a346695d4; Wed, 04 May 2022 09:39:51 +0200 (CEST) Received: from AS8PR04CA0147.eurprd04.prod.outlook.com (2603:10a6:20b:127::32) by AM5PR0801MB1874.eurprd08.prod.outlook.com (2603:10a6:203:49::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 07:39:48 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:127:cafe::a8) by AS8PR04CA0147.outlook.office365.com (2603:10a6:20b:127::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Wed, 4 May 2022 07:39:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 07:39:47 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 04 May 2022 07:39:47 +0000 Received: from af27461cb16b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75F42243-0098-480D-B6E4-D9F37A18A1EA.1; Wed, 04 May 2022 07:39:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id af27461cb16b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 07:39:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7793.eurprd08.prod.outlook.com (2603:10a6:10:398::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 07:39:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Wed, 4 May 2022 07:39:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6197a7eb-cb7d-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Dx0z1afT19KF/t6HY9GDnkkyejvalkQL1P05YwzE13yT5xzcnwksCOLuzuwn9nVmCMA8NH529mpZu2cdzb21YbKFuP+k2in912DERtr3IcKO08pzhIkjwg76SNT/1y5ypk7sAItVvfp82asyu66XJXffQwY+Q8Mp9IY4kJCNHOodvwdBJoS5mNb/tw9pLc4B23n2/pvd67e8CzHrdD+3udCikcNbLOzrEPcsEcbKDayz35WgpOw7rK7jaxAS8GmngWaqMZM2SqzRGMyW5vXRcXrbuuwqMY/G7LPyclaFsOX62HiQc0wqf37UPzSUmon1Ib9GrxE+9Z+2rfcPq3PMmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6VHyoo9axMNr1V+wqh6VafmQkySppERg10V7U9lyyM=; b=SFNdUwFjV3EUMrcyibJkhGjcnZXJ22+/lZTQ+iIqE/tVMCQN6jC8wkGGdppEmsasf5QOTlZ89GKpbwc6k2UAn59QbhqhHle/UZtV2jh6IhuNm4SZ7Oi6EglHHBF7Ss2DfsmT5257/lrf64Pw56ql9i238zbglkMhqvLpVyqnEd6p/9weQ6L7HRRUfR1JsosTdltaGWK4PSkk4h2DJYkvAzlOmgN+pk7d63lw4Xk7fM8OsqD/VZOWH4kdU3MRwY2GIvUsKuvD2vQUeO0lbVaga/peisRfA5NRruITuhIWqbLfHg4d46U4ri129we3vivXuXV+2ihRJzADufuKNMLWmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o6VHyoo9axMNr1V+wqh6VafmQkySppERg10V7U9lyyM=; b=q7byG2LwxyCqHa9s7ppar6DkCgqK2zvVna0XQmRGnBgBESe890z8iTE3WWj6u30flY9HLWsKS0s/DJ2dEF3eLvhXyDhy5/PpMX08LY/O7cO39wkPCbubDf2DkhTmGfnyMTPR1vehHFG53AroaXsAnw4duMi19IRxrwM8JjcFGu0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6265ded2173f89f9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJdKhf9Cxuc93JXXAMLZBWG+pnXJWMN0Q3uYScqdXi9X2gpx2D9x1ARPJZwXuJHl142j+qINzPlA/x2nPBpgDXdH9W5//y5jaFxPNW1pH4AticIUJgCEOoGatGhoCLHoI+M2IuZ5NlDaZfFFazWEGdb2J5ZVhltbEj4kpnu+WEkqaBckzXBSw0CxPUfDIrADv1sKMEzL/HT2OvRmtGDqm7tbfQL072jEr867jb+Oh2tfS9y7nGybQIp1P4RADMUdZkMDGO+/5wp9T5Pf2QQ2aocT3svqLTDpobzGUR5YW6O+NcEjxQOyzH5V5QUt5RO4BBXl+MoGjdR0y1O+NpPKXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o6VHyoo9axMNr1V+wqh6VafmQkySppERg10V7U9lyyM=; b=bHVmBexrz1x0P3XRCHtflgj3FPSo8YhKuVHH1oYuGi+y1WQYR7ecE+zssBH9hkkW0Pr5C+xKoV3hk3tAUI92A5PIP46zh4My3saD08pXZfAgLWg6NghIGMwc1xgtcQuEstohUxK9+PadUcaV0xWn6f4QwB+KWgG9x4bKRpcosoKLltfJxgz3Lwdpm4jFLcJ3tZ/ytkLONaO8aeed1OOyfdytXvz/kOx/4KRTnVplGbAem9rP1JD2niJD2Machp7LnPOeUILEeBvY3Phfxj8IDLb4AXytk/snt9xIzpPqkCLN9wf/6F0tibwNzOfGpBzDMCAMUEN4jHS5BDOpqFqOKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o6VHyoo9axMNr1V+wqh6VafmQkySppERg10V7U9lyyM=; b=q7byG2LwxyCqHa9s7ppar6DkCgqK2zvVna0XQmRGnBgBESe890z8iTE3WWj6u30flY9HLWsKS0s/DJ2dEF3eLvhXyDhy5/PpMX08LY/O7cO39wkPCbubDf2DkhTmGfnyMTPR1vehHFG53AroaXsAnw4duMi19IRxrwM8JjcFGu0= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYA= Date: Wed, 4 May 2022 07:39:38 +0000 Message-ID: <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1e33d8e9-09ed-431a-32d0-08da2da1440c x-ms-traffictypediagnostic: DB9PR08MB7793:EE_|VE1EUR03FT029:EE_|AM5PR0801MB1874:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UVm9WN2dFcXzZTuMU02VhCzt3xpj3HVnx+ohj8rcOi5UT4vWu1YY0DjUXfJHPdCjP+tl5ed8976D3FYJIgRcF11C2W1Fq9JaYac9CLUeQcrNIrTLGyeoECyZjP/59aPAiMWg+hUEgQri2eqHsEqb+G8qG3HSBfbUmzjlu8ZTW12wJoo00UMxbmCL1LOQOunHl7yTwo4v8UEFwlRiNGY8EecESmE4cxh8ccDSw8Oj5D7NdeOuVa2blWG9XQJ66vtwOw+va0zhynsxJjybDqInMrrPl4jOBo8oKb2JI96Uv25X0Ii0/8RP+WhytDRHVXdBgzM/sgwFkqGeE+54hyuvFLBZN5WjyWnDCWyAoLlWfLpuMtTgHMoxjy6MnUzwo5Grn3lehcsGGak01vR6S0mMGsXV9x4qY0OY+LFMtDswpsfGmXZ1SLfq8fiRL//cNzia8V/BkZpiMB6Ji1KY9oiFbF66R3JIioitUjBjWozCljo+Bv72pvBokEezppgYdD+1V6A9Mm2wx4JFloUH06+dVr2yzkb7/8bYJKX+Z4Qt3oiEMckq/YzcmKkMcqlE0GTz7hlitTbickwJcvBs+letsUElavaesSKHj1SQy5HC7Np675deGRJz9+1QhjhMv+ijrTv8KKYjp4zL2iwuSF0n9EUl4z3RayrDSEGPH9D/8tHX1NjwJCdve20+kOxZUsl3qYHLKaSKL7rxLQ0FoNlY5rArYlPbQC5rzJQXpv/aBbe10lMG1rdQkjPrzjtyMPzD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(71200400001)(38070700005)(38100700002)(2906002)(66476007)(8936002)(6486002)(316002)(508600001)(91956017)(5660300002)(122000001)(54906003)(6916009)(8676002)(4326008)(64756008)(66946007)(83380400001)(66556008)(66446008)(76116006)(6506007)(33656002)(26005)(2616005)(53546011)(6512007)(186003)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <85BBD066915CA54CB66B134141CB1FEF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7793 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d4dab97a-6882-43f5-5b24-08da2da13e66 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xBa2qByMzuejWpmrDRFhxwXsH1BCO/5vSExTF7IOMvz5cd5hA4i0PsQYDG5HxoDUkDMVxUXVpgUZYnP+NGPNqmDMV2dBk/qpcwIEJiskDYcEnVF4lJkSQgXqGh3PRiiuGIyQJlZ+V3evNlHdd40skPxu1WW3503LxP55pirJyo6Oj5xRTGs8UQlM4zOC1eNcBtTT1CWu1xtXCpwQWjNsalHxeTaFOZOlsANb0WnU88NdoNU2cIW42cTMhLbizFRX82jIu04KoNQTHU/mr77OGwb3aTUOvIU4O8G8wEfJgH58TtJA+9/AW5LNKiZB8U/D2tPrcgKzvKjuL21z60/FDZVRVHATqqwYAEqXi+P8OC8rXxMX1CHrvss7W7X1illomU0kh/7FAm+QT7tcbwVG9KcyUxJouT/OJ8R+LhBUIu3qUYeHDYFFYeueADKqj1dwaj0j/gOrrae78xfG+Ux257Pv3gBjWzaOdEpK3wN9yjmmXKcx7LnjPEPagFMe4+JOKUEgoPjBRbefYx2z5yfvSU2ToBRUeasFg0t2sqnSpkx03VAs4oxkWyXp7FHZTrH3eahLPB3UPQWzR1BQ7hjbFBC/GFgphxyeTh6RfneDldZBgQ9VaEZwhaETzLi58aetWsrhiIcTTBucIijrw8/tox7V6Tth+sHBWmiHfUdyNN/vS6AjMlE0EMFmu/im3JQu X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(33656002)(47076005)(316002)(5660300002)(6486002)(36860700001)(86362001)(336012)(2906002)(8936002)(186003)(26005)(6506007)(54906003)(508600001)(53546011)(6512007)(83380400001)(107886003)(82310400005)(356005)(2616005)(81166007)(4326008)(40460700003)(6862004)(36756003)(8676002)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 07:39:47.9887 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e33d8e9-09ed-431a-32d0-08da2da1440c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1874 Hi Julien, > On 3 May 2022, at 19:08, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 03/05/2022 10:38, Bertrand Marquis wrote: >> Sync arm64 sysreg bit shift definitions with status of Linux kernel as >> of 5.18-rc3 version (linux commit b2d229d4ddb1). >> Sync ID registers sanitization with the status of Linux 5.18-rc3 and add >> sanitization of ISAR2 registers. > Please outline which specific commits you are actually backported. This w= ould help to know what changed, why and also keep track of the autorships. >=20 > When possible, the changes should be separated to match each Linux commit= we backport. As those are exactly identical to the linux tree, one can easily use git bl= ame on the linux source tree to find those information if it is needed. I checked a bit and this is not something that was required before (for exa= mple when the cpufeature was introduced). >=20 >> Complete AA64ISAR2 and AA64MMFR1 with more fields. >> While there add a comment for MMFR bitfields as for other registers in >> the cpuinfo structure definition. >=20 > AFAICT, this patch is doing 3 different things that are somewhat related: > - Sync cpufeature.c > - Update the headers with unused defines > - Complete the structure cpufeature.h >=20 > All those changes seem to be independent, so I think they should be done = separately. This would help to keep the authorship right (your code vs Linu= x code). This and the previous request to split using linux commit will actually end= up in 10 patches or more. In the current, the change can easily be checked doing a diff with the ment= ioned Linux version, so I am not really thrilled to make it more complex. Please confirm that all this is really what you want. >=20 >> Signed-off-by: Bertrand Marquis >> --- >> xen/arch/arm/arm64/cpufeature.c | 18 +++++- >> xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- >> xen/arch/arm/include/asm/cpufeature.h | 14 ++++- >> 3 files changed, 91 insertions(+), 17 deletions(-) >> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufea= ture.c >> index 6e5d30dc7b..d9039d37b2 100644 >> --- a/xen/arch/arm/arm64/cpufeature.c >> +++ b/xen/arch/arm/arm64/cpufeature.c >> @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1= [] =3D { >> ARM64_FTR_END, >> }; >> +static const struct arm64_ftr_bits ftr_id_aa64isar2[] =3D { >> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_C= LEARBHB_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >> + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > So we are using CONFIG_ARM64_PTR_AUTH. But this is not defined in Kconfig= . I realize there are more in cpufeature.c (somehow I didn't spot during pr= eview), but I don't think this is right to define CONFIG_* without an assoc= iated entry in Kconfig. >=20 > In one hand, I think it would be odd to add an entry in Kconfig because X= en wouldn't properly work if selected. On the other hand, it is useful if w= hen we will implement pointer authentification. >=20 > So maybe we should just add the Kconfig entry with a comment explaning wh= y they are not selected. Any thoughts? This is really right and a very good catch. I think it would make sense to introduce those in Kconfig in order to keep = the code equivalent to Linux. So I would suggest here to add hidden entries like this: ARM64_PTR_AUTH def_bool n depends on ARM64 help Pointer authentication support. This feature is not supported by Xen. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 07:53:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 07:53:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320404.541115 (Exim 4.92) (envelope-from ) id 1nm9pX-0006DZ-Mj; Wed, 04 May 2022 07:53:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320404.541115; Wed, 04 May 2022 07:53:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9pX-0006DS-HK; Wed, 04 May 2022 07:53:51 +0000 Received: by outflank-mailman (input) for mailman id 320404; Wed, 04 May 2022 07:53:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9pW-0006D3-17 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 07:53:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54268061-cb7f-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 09:53:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 53A77210E5; Wed, 4 May 2022 07:53:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3ADA131BD; Wed, 4 May 2022 07:53:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3J+lNQoxcmJGXgAAMHmgww (envelope-from ); Wed, 04 May 2022 07:53:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54268061-cb7f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651650827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tRuMICiQGR2wMmghH8xrPLx6iImFqvCTPWI3QuRWDZQ=; b=UdjnifrIpvNDPAbkkItX5X3RY5KGwxbTUXkyTDFcejonRrdWpoC9bo6SPx3yJtDrlgm5NN 4WFyLLhDSztZiA7JAkNSpfX84gBA2pUUw6BQPWP3BXHveI7rK1G96Da1aroaq6feK6SQk7 mIrlT83axm0ymIj0ib5we5eCVRIL//c= Message-ID: <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> Date: Wed, 4 May 2022 09:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables Content-Language: en-US From: Juergen Gross To: xen-devel@lists.xenproject.org, Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" References: <20220324140139.5899-1-jgross@suse.com> <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> In-Reply-To: <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------nbQOVFr5r5mbpitkQo1XeI30" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------nbQOVFr5r5mbpitkQo1XeI30 Content-Type: multipart/mixed; boundary="------------vXg90Jstq1UIB17NgjOQiR29"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org, Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" Message-ID: <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables References: <20220324140139.5899-1-jgross@suse.com> <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> In-Reply-To: <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> --------------vXg90Jstq1UIB17NgjOQiR29 Content-Type: multipart/mixed; boundary="------------Q5PLr7JUyt9dWWE9Aa75SSaw" --------------Q5PLr7JUyt9dWWE9Aa75SSaw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDQuMjIgMTA6MDEsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI0LjAzLjIy IDE1OjAxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gSW4gb3JkZXIgdG8gYXZvaWQgaW5k aXJlY3QgZnVuY3Rpb24gY2FsbHMgb24gdGhlIGh5cGVyY2FsbCBwYXRoIGFzDQo+PiBtdWNo IGFzIHBvc3NpYmxlIHRoaXMgc2VyaWVzIGlzIHJlbW92aW5nIHRoZSBoeXBlcmNhbGwgZnVu Y3Rpb24gdGFibGVzDQo+PiBhbmQgaXMgcmVwbGFjaW5nIHRoZSBoeXBlcmNhbGwgaGFuZGxl ciBjYWxscyB2aWEgdGhlIGZ1bmN0aW9uIGFycmF5DQo+PiBieSBhdXRvbWF0aWNhbGx5IGdl bmVyYXRlZCBjYWxsIG1hY3Jvcy4NCj4+DQo+PiBBbm90aGVyIGJ5LXByb2R1Y3Qgb2YgZ2Vu ZXJhdGluZyB0aGUgY2FsbCBtYWNyb3MgaXMgdGhlIGF1dG9tYXRpYw0KPj4gZ2VuZXJhdGlu ZyBvZiB0aGUgaHlwZXJjYWxsIGhhbmRsZXIgcHJvdG90eXBlcyBmcm9tIHRoZSBzYW1lIGRh dGEgYmFzZQ0KPj4gd2hpY2ggaXMgdXNlZCB0byBnZW5lcmF0ZSB0aGUgbWFjcm9zLg0KPj4N Cj4+IFRoaXMgaGFzIHRoZSBhZGRpdGlvbmFsIGFkdmFudGFnZSBvZiB1c2luZyB0eXBlIHNh ZmUgY2FsbHMgb2YgdGhlDQo+PiBoYW5kbGVycyBhbmQgdG8gZW5zdXJlIHJlbGF0ZWQgaGFu ZGxlciAoZS5nLiBQViBhbmQgSFZNIG9uZXMpIHNoYXJlDQo+PiB0aGUgc2FtZSBwcm90b3R5 cGVzLg0KPj4NCj4+IEEgdmVyeSBicmllZiBwZXJmb3JtYW5jZSB0ZXN0IChwYXJhbGxlbCBi dWlsZCBvZiB0aGUgWGVuIGh5cGVydmlzb3INCj4+IGluIGEgNiB2Y3B1IGd1ZXN0KSBzaG93 ZWQgYSB2ZXJ5IHNsaW0gaW1wcm92ZW1lbnQgKGxlc3MgdGhhbiAxJSkgb2YNCj4+IHRoZSBw ZXJmb3JtYW5jZSB3aXRoIHRoZSBwYXRjaGVzIGFwcGxpZWQuIFRoZSB0ZXN0IHdhcyBwZXJm b3JtZWQgdXNpbmcNCj4+IGEgUFYgYW5kIGEgUFZIIGd1ZXN0Lg0KPiANCj4gQSBnZW50bGUg cGluZyByZWdhcmRpbmcgdGhpcyBzZXJpZXMuDQo+IA0KPiBJIHRoaW5rIHBhdGNoIDEgc3Rp bGwgbGFja3MgYW4gQWNrIGZyb20geDg2IHNpZGUuIE90aGVyIHRoYW4gdGhhdA0KPiBwYXRj aGVzIDEsIDIgYW5kIDQgc2hvdWxkIGJlIGZpbmUgdG8gZ28gaW4sIGFzIHRoZXkgYXJlIGNs ZWFudXBzIHdoaWNoDQo+IGFyZSBmaW5lIG9uIHRoZWlyIG93biBJTUhPLg0KPiANCj4gQW5k cmV3LCB5b3Ugd2FudGVkIHRvIGdldCBzb21lIHBlcmZvcm1hbmNlIG51bWJlcnMgb2YgdGhl IHNlcmllcyB1c2luZw0KPiB0aGUgQ2l0cml4IHRlc3QgZW52aXJvbm1lbnQuIEFueSBuZXdz IG9uIHRoZSBwcm9ncmVzcyBoZXJlPw0KDQpBbmQgYW5vdGhlciBwaW5nLg0KDQpBbmRyZXcs IGNvdWxkIHlvdSBwbGVhc2UgZ2l2ZSBzb21lIGZlZWRiYWNrIHJlZ2FyZGluZyBwZXJmb3Jt YW5jZQ0KdGVzdGluZyBwcm9ncmVzcz8NCg0KDQpKdWVyZ2VuDQo= --------------Q5PLr7JUyt9dWWE9Aa75SSaw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Q5PLr7JUyt9dWWE9Aa75SSaw-- --------------vXg90Jstq1UIB17NgjOQiR29-- --------------nbQOVFr5r5mbpitkQo1XeI30 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJyMQoFAwAAAAAACgkQsN6d1ii/Ey+6 Sgf+P/dXNAYpj/JqNjQZg6H+qpuJmtJ2PXpENwKAkEQcZbIbcjycuGGtnBU8+FPMuZaau0F3JGVo r0FmajuhTYEXTWAtjpVKmlggTWc7RtHkyUCQl1lNQnhr2p60pZmDFKG/lCZa4+1FZgjIb6QdieeP 2/04X+dzIFHd0Lk7lVxVF7/dhB70zD/tFuyWzrmYnoF0VtQFH0uxH8Q+pwRbmfegWCKus7FhRO15 WrHyhIicsRFVeRmSBIJskKpGEWJL0QReRp5EZXC6usKBKYHS3ToSsiHBswupnwBYo9VKAvexF0TU REB6wiOb5lo3fXXqr6t6q4OfKiIFaMZquziRnwiXdg== =DR5Z -----END PGP SIGNATURE----- --------------nbQOVFr5r5mbpitkQo1XeI30-- From xen-devel-bounces@lists.xenproject.org Wed May 04 08:00:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:00:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320416.541124 (Exim 4.92) (envelope-from ) id 1nm9wG-0008Ci-Lm; Wed, 04 May 2022 08:00:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320416.541124; Wed, 04 May 2022 08:00:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9wG-0008Cb-Ii; Wed, 04 May 2022 08:00:48 +0000 Received: by outflank-mailman (input) for mailman id 320416; Wed, 04 May 2022 08:00:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9wE-0008CR-DV; Wed, 04 May 2022 08:00:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9wE-00085B-Aa; Wed, 04 May 2022 08:00:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nm9wD-0002ot-Vh; Wed, 04 May 2022 08:00:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nm9wD-0002YV-VG; Wed, 04 May 2022 08:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8iMLAdCiUxrnwtBu4P8ugXTLDp1CHZYFiO2V6xxXwNA=; b=bW4FOnpT+ca4zsSA8DQJwOCRro W1Y1Q0sbyt9MJRnu3DkEpDf1Zienn4n4wfKRqJT3ZhGFTKGH8oQfNPYRmQCT7EACi7UecRdd5+wcj ahJRR2l0Jq4WULnUelOnjhlaqHI7wB2ZGzf8CuxYmWrIl9p/FdelDgUueYgdi134Ja9E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170083: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 08:00:45 +0000 flight 170083 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170083/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 794 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 08:06:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:06:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320424.541137 (Exim 4.92) (envelope-from ) id 1nmA1e-0000WB-Cf; Wed, 04 May 2022 08:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320424.541137; Wed, 04 May 2022 08:06:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA1e-0000W4-7K; Wed, 04 May 2022 08:06:22 +0000 Received: by outflank-mailman (input) for mailman id 320424; Wed, 04 May 2022 08:06:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA1c-0000Vx-SM for xen-devel@lists.xenproject.org; Wed, 04 May 2022 08:06:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA1c-0008Bf-IZ; Wed, 04 May 2022 08:06:20 +0000 Received: from [54.239.6.185] (helo=[192.168.21.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmA1c-0000pX-Cc; Wed, 04 May 2022 08:06:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fFRfu8WinN2af30yWVR7eQyalk7y8rMLkiOOZFNQqFw=; b=Mvuqq12UMZAEiZAQqgk5PjMOGK Wkx92OntMK5kOg9bwOGB+0h1GP6qlE52kGmrMA+Vsmtu4/WLMT7ukMMcfdC6eQHFUHXYNtx6dcmy9 fS/LfHEV9eI9BKefLHhX2lDR8ZrDfPgp9mWrM4lf7+FgkSHkfol0JC9r2EsovItSwqwE=; Message-ID: Date: Wed, 4 May 2022 09:06:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/05/2022 08:24, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 3 May 2022, at 19:47, Julien Grall wrote: >>> A new cpuerrata capability is introduced to enable the alternative >> >> 'sb' is definitely not an erratum. Errata are for stuff that are meant to be specific to one (or multiple) CPU and they are not part of the architecture. >> >> This is the first time we introduce a feature in Xen. So we need to add a new array in cpufeature.c that will cover 'SB' for now. In future we could add feature like pointer auth, LSE atomics... > > I am not quite sure why you would want to do that. > > Using the sb instruction is definitely something to do to solve erratas, if a CPU is not impacted by those erratas, why would you want to use this ? I agree that SB is used to solve errata but the instruction itself is not a workaround (it may be part of it though). Instead, this is a more efficient way to prevent speculation and will replace dsb/isb. Speculation is never going to disappear from processor. So, in the future, there might be valid reason for us to say "We don't want the processor to speculate". This would mean using SB. >>> + .inst 0xd50330ff >>> + nop >> >> Why do we need the NOP? > > Alternative requires both sides to have the same size hence the nop to have 2 instructions as in the if. A few years ago we backported a patch from Linux to automatically add nop. However, looking at the code, this would not handle this Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 08:14:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:14:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320432.541152 (Exim 4.92) (envelope-from ) id 1nmA98-00020l-7E; Wed, 04 May 2022 08:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320432.541152; Wed, 04 May 2022 08:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA98-00020e-4G; Wed, 04 May 2022 08:14:06 +0000 Received: by outflank-mailman (input) for mailman id 320432; Wed, 04 May 2022 08:14:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA97-00020Y-4z for xen-devel@lists.xenproject.org; Wed, 04 May 2022 08:14:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 290ef415-cb82-11ec-a406-831a346695d4; Wed, 04 May 2022 10:14:03 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-Ppc2BRGaNA68eMiyvgHHRg-1; Wed, 04 May 2022 10:13:59 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5878.eurprd04.prod.outlook.com (2603:10a6:20b:a2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 08:13:57 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 08:13:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 290ef415-cb82-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651652043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQs3uBZfO9npD8/kSlAwlsaWzBFngKYYBHskg+vPm5c=; b=dlTlrqKwld79yrfL3SE8ld/ggCgGwxT75i+yPsvEDqTFcJJpuYgjwzuw29v0moidGqobfX k5659bXeK/JKecukQwGJDKmM2XzeWTsRwdSbGTqqyOB1Mq8heyiwTIE/yii66b2LuP7kTx Xj+/QIj7zkcAemzUsR4s5NVvWGS3kJw= X-MC-Unique: Ppc2BRGaNA68eMiyvgHHRg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMN1efV8sFPLIqOWJ2dPbOqa+feueJZMWzt4kVbYWnTXpn29z1Adnl2ByZ3d6fH7v3GB5+WzmcbwEyl2pMhtdEwFjFzvhojw21G7ofPRi1ADq2LLorATvfY7RIa0MUkIf84nwx3Z6rZ9q50EkEI9VWicRo3yBsTyM2iTj2T2ea3iQupmBHkFMmhsAuLr9b1sOJZEgbSrRxqBbHAElVMnxyCnXXrd9iY/SyPo2wxh7DLlSi3TRuz/g/zaTnfbF0oz0E3b9MxlRg4BQVH4+1RYk2uXNiga3LWyk9wUL3p+tG6mn3U6sTAAAakajLFU2y8UzM3KBz35dRoknD5wT69F8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4eT6ziFmR+oEmt5PfVan7mIVFt45G6awZJDDsAjaG+Y=; b=kqYsNVXAlBworOWZhlUlpvR7s+655dbsp9BlORQ9JLsaCC0ARAsi/0tUE5sX+01M/tGjLJX2PY+D6ipJrX+/n4zWXH+68fiygNZ1xHg656huWdW2Z+EgrOtECEsYDQv73l0xipNT/+EFXeb+B8FHFc8HMmWXaLUENFpCYMcUw0ZmhUMH/cUTflbhim4OOuwRgiX2osvg9tn3oFPvpnkH3hRbCkDThklqztPuQUTx6Ud7C1A5jStcwkwHZVobXkaPoN35FUovCcMTqGLbXKhSjU02Cv28CEhmFX5O5efJnmZtFblRk8ZhpzRDRnBHa0k0rfnH8WE4A1n8lxMEEh85Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 May 2022 10:13:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void Content-Language: en-US To: Michal Orzel CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , xen-devel@lists.xenproject.org References: <20220428094625.382970-1-michal.orzel@arm.com> <074a5ae8-cade-3343-0c18-8122c85fecc3@xen.org> <87eb6f25-c940-8aa2-bab3-dea9bcf1760b@arm.com> From: Jan Beulich In-Reply-To: <87eb6f25-c940-8aa2-bab3-dea9bcf1760b@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR05CA0015.eurprd05.prod.outlook.com (2603:10a6:20b:488::14) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed955d99-673f-4be4-471b-08da2da60989 X-MS-TrafficTypeDiagnostic: AM6PR04MB5878:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dUJ8whW7IKJTKtJNZmVAS2iutSiBW3r+FPtG3No5TChrFLKpCiaW6ESDvcJ+2PKV3g6jKwX59BdR7BGoyEccjaJkT07xp54JQYnBDItDb8Cz+n0AnFcZhbT6W9VOG8kY6tRpgav8Z0G+XDe+6qDmDVEVUuDoON2YeqKobM8XQS1sosqNgmnhnuLqrpMdk35PH7QH4IcmSvl5JJfgxsegkpFGUpOSKdvClP0cU+omcrkc2rXHfWnKdTwlm8wA6webt03rytuaVU1rRcl/eu3EdnM8uk0NNjpSk09FTjlgJmg4Yi3qcmF2gbTdfMATRDGtZ4u7/+cAZIpCBmLhxDuOlbs2aIKWvD5QODw9dS3vSscWveqth20AzwyA2L41U26SWKwLpWD+H8PkHqU03l6s2q7c6ZalXVBqPZShB+wEzFkf1o+Kr1hjHHkKS4zyZUfo8U8BiicuDwM8QbTKVX+163iRNP3LCvikxuCwUNKU/BO7EFQfVurBtNSS7BU8qWeR+wyOUu9OS4lffQawEQ3W7NGpMfoFQoX5KRSu6fxZnpSputW4B1Iv7XkuRwnzLjyoisgmON+84dvObuXVjTfjBsyWSHnLEtTKf+KzUzZ0/zeucdICaM7hoeawNAUAw4Scinp8s4AdYUpr5qrkgDTsXK3zJtyHo5MXn3YnWn9IMlrJa94O3J/Kkcaf08HQnx/hK3x/KuYVfBbpblKqkWHKPAOC4MOm+jzC1ZWYbwDPVnQ0UDLugkD8ozqrmrHT4wCc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(6506007)(31686004)(2906002)(36756003)(8676002)(26005)(508600001)(6486002)(38100700002)(66946007)(4326008)(6512007)(66556008)(66476007)(86362001)(8936002)(316002)(31696002)(5660300002)(186003)(54906003)(83380400001)(6916009)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DeY/cPtvS4FRS7tV0Zjf8k+wzDRBP0OGcuKEcVdkbUKHuCW0QuH5nV8lGBpy?= =?us-ascii?Q?Xh0wjt0o37PldBnaTcLSQx4pOkmNgPrRNq8qbZSxvYAyrlj0FaGex1dfJJp3?= =?us-ascii?Q?UAiTHH+qMc1w4H3sAem7ub+aV9mUX2iLGQaO2wrdVALrf6ZZ5IkP5k11yBkI?= =?us-ascii?Q?D9w5YdNQoaUWLKQQPTos+y8JIQGPdP87FCNSOxeVQo/+d26LL6bKvN+BZ496?= =?us-ascii?Q?LcQiUh9rsb8t0g6r5zBuC2loZF3Rjq5M9spdL1iNR0eHHpa13o9pE2RhpfXO?= =?us-ascii?Q?jvR082wc2ME1iDz3pDc+J6FITnTVikiebMKNh2f4iEv8Mm1GnXCLl/VW8EUS?= =?us-ascii?Q?00LOm49alwcJxnmgZ6iVZzzJ2gzF7Bn7rE3SVh+0SAAqkSGa/+PEDnZ8JzNJ?= =?us-ascii?Q?m66flAEeB+QGJultcy8PaBygsY/y2Flrm2QBrJjIgpGZ0pzqjw2SpZe9038W?= =?us-ascii?Q?l+U+CGRmWUuBEyp+INDc4sWo1JCyEzA/El6yljlvLFH5YEaEIEFC5ZRjOcar?= =?us-ascii?Q?vNPxk4p0QfdCQrLmxCbNSmGQknhP4HiLtnp4OtI2Q3+VlcajjRjxg3DAvUAX?= =?us-ascii?Q?DeBD7Fokb+hdCVs7+d1xm8RDd+xb8bBMHV6BN5mGQVz93sTQmjdeat5T9ZUl?= =?us-ascii?Q?4lyXXvzxD/NhpQHK9Pu+D7ZwjDQUSLDQDxtaNf3nKR2JnPj730/xLmziH+tk?= =?us-ascii?Q?VsvpuuI/BX8xsguJa37H/iT8mhkqkVdJ7XonwYxTbJrEE92kKIPWkXriSiHc?= =?us-ascii?Q?HEGEREgwn3yGdx0xEgh4RYlZBZbyj3d08m+LxGxAAr5da+A+4JJGe+yk9wLY?= =?us-ascii?Q?w1E7kTk1Gz8Ogd1PW4REGpymLocqDTN0EPDIByZ7H4LxdBV2RFwwVSZaqUAf?= =?us-ascii?Q?DlQSPHQP2yiBbWMNy5FQa2/Ek1xv65Flz6IsshXOeSFBu/y8sYuuFQAJ8pU/?= =?us-ascii?Q?bde849PZF0beZXWaW0pNcVjvKLje6D7pYBGGX5lNzf0uS9cLRYq6GkODVfK5?= =?us-ascii?Q?VFf2juoKFdVbs3jZToBLU/V4KFnvb0TNM1IDC/N0LEn9eYVuuEa8TgaCwOip?= =?us-ascii?Q?JOYbLQO5sZ0mVVdGFT/kVrm8CMPp9br3cc/7HviGW0y+WDAFmRvnmVLjwNm/?= =?us-ascii?Q?HP+4Eijpq0cPPTGG7GdoGjXDuYdilR6y3SkNSPhZetPq//ET3XFa/M1P8wPy?= =?us-ascii?Q?7Po8fK2A6PwZrAIIdTBJeiFaVyZ2VRVfQI0uD+HUDclpC2aJHGEWVmQS1Lp2?= =?us-ascii?Q?NSZzzyWeP/coHhzWFv9iFHr4jpIyQ186yF7U+sU8OwI4xXAG/hXgQwlbv85Y?= =?us-ascii?Q?U3MPT2iZxxVi0ZUHbl3ALthshFH91Y7ze/io5c+jJZnnfbRLt3RTPvMGs9nh?= =?us-ascii?Q?CI29tDaLsgCKRCs8Yd6xe/wPXUDpVstPwGxcE4Jx2aqs/Lp7yS1TpEg5hSpC?= =?us-ascii?Q?6CZ9ei4EG/Ce8zyxxJ7lo49bB4Or76HPBd9bhEl5sZnf9qskMq4AjfAhJO7p?= =?us-ascii?Q?9HehsOGG+j3KZhpxAJovzoHB9wEXsRyJClYLc9jjeNoUaC1td2MDQLUOdOA+?= =?us-ascii?Q?wdAof12Wf8MoJpr/brNa7VoV7X7Qzr4fGG7Gey/9DyjfnDlb7OQI6Qkf8ysM?= =?us-ascii?Q?afMFcfznomDAEnn9zorl1iC/D+OV0KUE0s0g3K7DHFyTdT09YxdhftSd6dpi?= =?us-ascii?Q?o6qK5XsUCqvck8j1bxChemXSR9vUnaxg3KSP0XhjuLV56jv96ARnwRE+Nocg?= =?us-ascii?Q?PelK70IPWg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed955d99-673f-4be4-471b-08da2da60989 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 08:13:57.5565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y/LQE+DX96Fkvy/NujTWoKuEIFNPerltzDQ2I/TDnoedB4RDCO3nZPAyij8xZkOCSJuVixbq7vKOYbBlQLvqqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5878 On 04.05.2022 08:41, Michal Orzel wrote: > On 03.05.2022 19:44, Julien Grall wrote: >> On 28/04/2022 10:46, Michal Orzel wrote: >>> @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr= , mfn_t mfn, >>> =C2=A0 }) >>> =C2=A0 =C2=A0 #define gnttab_shared_gfn(d, t, i)=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>> -=C2=A0=C2=A0=C2=A0 (((i) >=3D nr_grant_frames(t)) ? INVALID_GFN : (t)-= >arch.shared_gfn[i]) >>> +=C2=A0=C2=A0=C2=A0 ((void)(d),=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 \ >>> +=C2=A0=C2=A0=C2=A0=C2=A0 ((i) >=3D nr_grant_frames(t)) ? INVALID_GFN := (t)->arch.shared_gfn[i]) >>> =C2=A0 -#define gnttab_status_gfn(d, t, i)=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>> -=C2=A0=C2=A0=C2=A0 (((i) >=3D nr_status_frames(t)) ? INVALID_GFN : (t)= ->arch.status_gfn[i]) >>> +#define gnttab_status_gfn(d, t, i)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>> +=C2=A0=C2=A0=C2=A0 ((void)(d),=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 \ >>> +=C2=A0=C2=A0=C2=A0=C2=A0 ((i) >=3D nr_status_frames(t)) ? INVALID_GFN = : (t)->arch.status_gfn[i]) >> >> I share Jan's opinion here. If we want to evaluate d, then we should mak= e sure t and i should be also evaluated once. However, IIRC, they can't be = turned to static inline because the type of t (struct grant_table) is not f= ully defined yet. >> > Then, we could do like this: >=20 > #define gnttab_shared_gfn(d, t, i) = \ > ({ = \ > const unsigned int _i =3D (i); = \ > const struct grant_table *_t =3D (t); = \ > (void)(d); = \ > (_i >=3D nr_grant_frames(_t)) ? INVALID_GFN = \ > : _t->arch.shared_gfn[_i]; = \ > }) Please avoid underscore-prefixed names here; we've started to use underscore-suffixed names in a few macros. Additionally please consider using typeof() instead of spelling out types. This may help to avoid surprising behavior. Finally, instead of merely casting d to void, please consider using it in e.g. ASSERT((d)->grant_table =3D=3D t_), which ought to also take care of the unused variable warning. After all the explicit passing of t is only an (attempted) optimization here. > However, if we start modifying the macros to evaluate args only once, sho= uldn't we also take care of the following macros in this file?: > gnttab_set_frame_gfn > gnttab_init_arch >=20 > I'm ok to do these changes but I'm afriad we are losing the origin of thi= s patch as we are focusing on macros not related to the issue. Indeed - I'd leave further ones to a subsequent patch, or make conversion of all of the macros a prereq patch to the one you're after. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 08:14:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:14:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320435.541164 (Exim 4.92) (envelope-from ) id 1nmA9S-0002Sf-J4; Wed, 04 May 2022 08:14:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320435.541164; Wed, 04 May 2022 08:14:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA9S-0002SY-Ft; Wed, 04 May 2022 08:14:26 +0000 Received: by outflank-mailman (input) for mailman id 320435; Wed, 04 May 2022 08:14:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA9Q-0002Rv-I6; Wed, 04 May 2022 08:14:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA9Q-0008MD-F3; Wed, 04 May 2022 08:14:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmA9Q-0003Gg-2i; Wed, 04 May 2022 08:14:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmA9Q-0006RB-2J; Wed, 04 May 2022 08:14:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lFwC3TTDyI20S/V2VxYTilB0+Hk70IIrMdIdmN6I/v8=; b=uR/aHkHFBUKsT3mapRKY+tzN9c yQdKlRWGHuyMfzgHI5cPIXb5Ur0lHkGGbISd9pEGDvtL65mN5m74+tSwrICAsTBVJOcyjsTBR1QKq SMkq4bpGQFWpghsICxZPfss69sHb+JjHnjIvFIqMkFi98lF/Iytk4EH5sIWHc+RYQ/Pw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170064: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2e3408b3cc7de4e87a9adafc8c19bfce3abec947 X-Osstest-Versions-That: qemuu=5f14cfe187e2fc3c71f4536b2021b8118d224239 From: osstest service owner Date: Wed, 04 May 2022 08:14:24 +0000 flight 170064 qemu-mainline real [real] flight 170081 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170064/ http://logs.test-lab.xenproject.org/osstest/logs/170081/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 8 xen-boot fail pass in 170081-retest Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 170051 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 170081 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 170081 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170051 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170051 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170051 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170051 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170051 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170051 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170051 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170051 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 2e3408b3cc7de4e87a9adafc8c19bfce3abec947 baseline version: qemuu 5f14cfe187e2fc3c71f4536b2021b8118d224239 Last test of basis 170051 2022-05-03 16:08:25 Z 0 days Testing same since 170064 2022-05-03 23:09:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marc-André Lureau Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 5f14cfe187..2e3408b3cc 2e3408b3cc7de4e87a9adafc8c19bfce3abec947 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed May 04 08:20:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:20:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320447.541175 (Exim 4.92) (envelope-from ) id 1nmAF7-00043Y-7w; Wed, 04 May 2022 08:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320447.541175; Wed, 04 May 2022 08:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAF7-00043R-4j; Wed, 04 May 2022 08:20:17 +0000 Received: by outflank-mailman (input) for mailman id 320447; Wed, 04 May 2022 08:20:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAF5-00043J-4o for xen-devel@lists.xenproject.org; Wed, 04 May 2022 08:20:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAF4-0008T8-0M; Wed, 04 May 2022 08:20:14 +0000 Received: from [54.239.6.185] (helo=[192.168.21.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmAF3-0001na-QO; Wed, 04 May 2022 08:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=L6RA+6rkBTFITMu+zROdOo2PKLgVUgaxMDHiTm/2MHM=; b=soR/bJenVtXASurPhm0IfIp1dX YH2uHiV6D59X+QF8Jn7TcXsASVP73i8ae23sOBwsD+BiVtHMV6PS1bt88elUlxLFwoT0PpzvFhYL5 bdFMIuDg3qAQWzG9uGeYH6vzdQRj5ts+HriUvZZYeWmoDqJvcFPygMXX70Pt69L9t4s8=; Message-ID: Date: Wed, 4 May 2022 09:20:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> From: Julien Grall In-Reply-To: <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/05/2022 08:39, Bertrand Marquis wrote: > Hi Julien, Hi, >> On 3 May 2022, at 19:08, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 03/05/2022 10:38, Bertrand Marquis wrote: >>> Sync arm64 sysreg bit shift definitions with status of Linux kernel as >>> of 5.18-rc3 version (linux commit b2d229d4ddb1). >>> Sync ID registers sanitization with the status of Linux 5.18-rc3 and add >>> sanitization of ISAR2 registers. >> Please outline which specific commits you are actually backported. This would help to know what changed, why and also keep track of the autorships. >> >> When possible, the changes should be separated to match each Linux commit we backport. > > As those are exactly identical to the linux tree, one can easily use git blame on the linux source tree to find those information if it is needed Well... that's possible at the cost of everyone going through Linux to understand why the changes were made. This is not very scalable. > > I checked a bit and this is not something that was required before (for example when the cpufeature was introduced). If we import the full file, then we will generally don't log all the commits. However, for smaller changes, we will always mention the commit backported. There are several examples on the ML: - 0435784cc75d ("xen/arm: smmuv1: Intelligent SMR allocation") - 9c432b876bf5 ("x86/mwait-idle: add SPR support") We also recently introduced a tag "Origin:" to keep track of which commit was backported. If you want to understand the rationale, you can read this long thread: https://lore.kernel.org/xen-devel/0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com/ > >> >>> Complete AA64ISAR2 and AA64MMFR1 with more fields. >>> While there add a comment for MMFR bitfields as for other registers in >>> the cpuinfo structure definition. >> >> AFAICT, this patch is doing 3 different things that are somewhat related: >> - Sync cpufeature.c >> - Update the headers with unused defines >> - Complete the structure cpufeature.h >> >> All those changes seem to be independent, so I think they should be done separately. This would help to keep the authorship right (your code vs Linux code). > > This and the previous request to split using linux commit will actually end up in 10 patches or more. I think we need to differentiate the two request. The previous request is about logging which commits you backported. I would be open to have all of them in one patch so long we account the authors/tags properly. For this request, this is mostly about avoid to mix multiple things together. Your commit message describes 3 distinct parts and therefore they should be split. >>> Signed-off-by: Bertrand Marquis >>> --- >>> xen/arch/arm/arm64/cpufeature.c | 18 +++++- >>> xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- >>> xen/arch/arm/include/asm/cpufeature.h | 14 ++++- >>> 3 files changed, 91 insertions(+), 17 deletions(-) >>> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c >>> index 6e5d30dc7b..d9039d37b2 100644 >>> --- a/xen/arch/arm/arm64/cpufeature.c >>> +++ b/xen/arch/arm/arm64/cpufeature.c >>> @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { >>> ARM64_FTR_END, >>> }; >>> +static const struct arm64_ftr_bits ftr_id_aa64isar2[] = { >>> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_CLEARBHB_SHIFT, 4, 0), >>> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >>> + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), >>> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >> So we are using CONFIG_ARM64_PTR_AUTH. But this is not defined in Kconfig. I realize there are more in cpufeature.c (somehow I didn't spot during preview), but I don't think this is right to define CONFIG_* without an associated entry in Kconfig. >> >> In one hand, I think it would be odd to add an entry in Kconfig because Xen wouldn't properly work if selected. On the other hand, it is useful if when we will implement pointer authentification. >> >> So maybe we should just add the Kconfig entry with a comment explaning why they are not selected. Any thoughts? > > This is really right and a very good catch. > > I think it would make sense to introduce those in Kconfig in order to keep the code equivalent to Linux. > > So I would suggest here to add hidden entries like this: > > ARM64_PTR_AUTH > def_bool n > depends on ARM64 > help > Pointer authentication support. > This feature is not supported by Xen. I am OK with that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 08:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320453.541186 (Exim 4.92) (envelope-from ) id 1nmAQQ-0005fB-C4; Wed, 04 May 2022 08:31:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320453.541186; Wed, 04 May 2022 08:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAQQ-0005f4-8D; Wed, 04 May 2022 08:31:58 +0000 Received: by outflank-mailman (input) for mailman id 320453; Wed, 04 May 2022 08:31:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAQP-0005ey-EW for xen-devel@lists.xenproject.org; Wed, 04 May 2022 08:31:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a79f79f7-cb84-11ec-a406-831a346695d4; Wed, 04 May 2022 10:31:55 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-s03ChdGRMva8mRVmUNHg1Q-1; Wed, 04 May 2022 10:31:51 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5437.eurprd04.prod.outlook.com (2603:10a6:803:d8::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 08:31:49 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 08:31:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a79f79f7-cb84-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651653115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uQfWNe1RxVIVhGw370YZzsDPbGmRCJ6APtQ7SkS5ucE=; b=EH0WaOBy2ZeJmEfmnfoAOLt+H4z+qc066ZDmMBs9r+1GbQbeeP8WhtVYsld2TWyDpAEfqM WIZ4Ybfc9jpdFfNwe6Kal36l0suJPMhBrSLBtKv7i+1Xe6k9uPpcy/K21ZsK0f/quxn0yY VsiwMxDtgzZrjXNgoE+XyYNq3LAmHLo= X-MC-Unique: s03ChdGRMva8mRVmUNHg1Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J/TcqT3FmKHLvjBoB2dTAf6qSEpSlXxnWt72lZgDZiAkI9tYIVrN/TMZ97c4y/V8yI78LutDPzRWxcmg1UJrgz9KA0VRaTkZFLFW0RNv83UrNA/oW59EGQRvDoy16Mdyh1VlRZeeijbPKMW3LAfX2jXocIGzzFWIaF8yrVWhgNdEUkP1Hjm7xtuQyASavG+hMlPcSml8DTlPrUWgZBEdWPF4WhzKdnRK679jX3rpCDgOy3LDFefGuhONH43yATAH2+3s0WMz83mvZRpn3j9U6HPs2J+1OK2Vht86oeQTX3STNcvMm7lTncPA3eB7iROCONua4/pv6WEC0CUv2l2ALQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQfWNe1RxVIVhGw370YZzsDPbGmRCJ6APtQ7SkS5ucE=; b=O/MdNjN/vdEiSXOOv5aLaCtKv24zDcfASUE87VxaXEgPQKkbLQvP3Vv8mzBcP+UPSkGYiMSfawR2oP9hdRouktrHCaJjbMoFw7NLD301yyAi6491YzglTUj7Vs9f3UUu8Vu07gMAm6AAIroem+1EURPb63bd+afJDuf4ah/XP0KhZCJD0cCxBfIE9R87T5Or7YUVtAJeZZxxbYnWTRHqNQK0o87njqmybuWh3Tb1fe3fbY1WdOd3ue6N8NLs/39mRmVoR2tMRB3cra0mdkwohQlau0ZBp4Vq1bo/RLlVJkMkGNk4Ut2SqS+x26oFZATs8JPye6R+ii69xpG+p78r4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> Date: Wed, 4 May 2022 10:31:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Juergen Gross Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220503132207.17234-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0337.eurprd06.prod.outlook.com (2603:10a6:20b:466::13) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d493a38e-8de6-4ab7-a9ef-08da2da8884e X-MS-TrafficTypeDiagnostic: VI1PR04MB5437:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q6/goCuOXLBGJE4xI9cnuLVbnU7uK3VKQx8/d04qTCC62JOqpYdNPb+52+pWQBOipselsPPIjc+xHk/FKvsuqCEzcymZ9m5mCZ5tjnE+nxjG/GFxTwIs5RmVecjJy74TzT0+a9ZsBXuiQMucoojzlKroFvM763LWfrZoQD1bkk3V55kifqIEt8F/Ez5UvYKkadFazg0TljMkRV4MMtID+fnOAwbqjhri9AiypnbvyvHHqW/5KXuhCMl0q7aXw1w8WwvVH3DJUkigdMX0STl9Yy6vGIHGMQhHCK85Zvd0zHGt4FbBqiHOr4Pw6oCazKAuxJ0mgUGmH9+O5dC5O6zl9mD1b8glBlAdxwwiBYhO9ysgeB3mVsWjmf7F1zM2RxN52dzMMR0Ssa5gbC2sJSCprrRsqC2aAOGgS5Lf645VU6Eyl9dSKQquHsf4yaZxszFcFx+Hc6gXDLRnqx7EnE/gznOJlXKei1zgEuVbCJX+pAIG8dPy3UWGbEsnBQUzeqNcimVajwyG7cNuot7MZdHRgTuc1/EM50CaM8KV/5+Mo5RkDd2sB0dNnaRTQd3nd68psAeOmZomeshxRW/hN917cqGuJMszTLSm02VV/QH9Z2Yaxd3w3KvoJvc5j9YZcHiyD7L58SilxC+xXdLStKwVnR/yozUtjoKmRoYPNbVtUQpF1UiV/1uGGIhPp9DGtllbtUwyZU6DojpKMnoYrGZ8mcal9mG9WCCWsauOWFsRWfKfptPL6gK5PevhmFT9yxVg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(7416002)(53546011)(6862004)(66556008)(66476007)(508600001)(4326008)(66946007)(8936002)(8676002)(31686004)(37006003)(54906003)(6506007)(316002)(38100700002)(2906002)(6486002)(6636002)(26005)(83380400001)(6512007)(2616005)(36756003)(86362001)(186003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1Z6S2RLYmZscWpIYTV3SzlMZ0RDVTl1R3VKTlA3cEUvQ2pYQkJuS3k3SzBm?= =?utf-8?B?endydmJ2Zm5sRnNSbnhYL282dU5ZV200czdBVjJBcUJkY29vd1ZQSG5TMUE0?= =?utf-8?B?T3M2OWx5ZXpEREtrTEtqSkFhc0pyK1NNcktVZ0JLbTBqalI2enYvQSszNkNm?= =?utf-8?B?UzNwd00wM0xJQ0FQQXhhOFowZmljTXE4MjBaRTJ2WW1XV29NUTN4c3IwcWd6?= =?utf-8?B?MXJYdEFtZTN3UExRTHFzRnl5TUtIcnYvUjd3czYvejVvTFhRay9xK3I3QkM3?= =?utf-8?B?Q042WWlSc2toUUJNSmp0YTRpZ2NNVFdVc0tXQ0YyaFdSNkNLSHdpUzFDTVdC?= =?utf-8?B?RDdGZjA5TG1hK2JBRWd2NFBXVWJjc1dxVStBRDkwcVlnQzE2YzZvSVZvTTY4?= =?utf-8?B?QWFmYTdVbHM4UzBSenFiTjBQSnBJZFZyMW14WDdkMkdoUDFtS3JINFZWN3lP?= =?utf-8?B?ODhVc2ltLzlwaHhQTDRDa01LTzNPYUNtK3NFZG9TWEtMcjRRK0hkV1h0Tkhr?= =?utf-8?B?THN4NUYrM3EyYmt3RFRicExRRVRlQzNjR29zbC94VHRXZGFIaUlLZzBKb0lk?= =?utf-8?B?ZGw2akpJRFB2YlZsajd6M0pjM3ZSdmJtWkt6RExGMi9adjh5SHNIU3NkbkNG?= =?utf-8?B?c09SZ3g0ZGdwdEI0YlRHbG9hNnJhM1VveHpvVjFXT05YSFJWc1BhZkNCaUFV?= =?utf-8?B?TUNtc3dTS2FBMkU0OEtHdnVGbHdIRTBVOWpoeVN6QjEvZlgwSzhJTnp6NEdk?= =?utf-8?B?T3k0bVh0aW5TVzZ3OFVsZWt2VXIxejROQWo5cXpVVEQ4bU5tNHhPcDBOcmk5?= =?utf-8?B?ZlJKamJoUlpmb0psSEZmTmY2ekdhYzV0NG5qMmJwY3R6M0pnWUIwM0tGVVJl?= =?utf-8?B?RU5mYmROeXp1dnlXUVpCeGppWTcxQWpGYUdWd1dhczJQSllSNTR4ZlU1RmlN?= =?utf-8?B?Rjh0ZklkZTJXT0hNUUFPWXVZWDRJR1lBb2x2YWlKZUNZRTF6dkt1emlCcmcy?= =?utf-8?B?bmltenQyMXFTQ29rc09vZnRsdFRvWG11U1lWZDBoNU1RUVBBMC9BMmlhRWh0?= =?utf-8?B?M0lQU2k5b0U2RmF4bEx1Z3pxVGd0WnQwTmJ3OXFFbEdML0V2akQ4dUs0cW05?= =?utf-8?B?WWtGcXE0NGdCbjVtV3NUNHBEZG80ZlZUeFQ5dC9odXo2bmZ3K0ZobUhFeEN1?= =?utf-8?B?Vjl0cnVyL0xNRFVudTFWbkNUY2c0REUydVF0SS8wTFN5cXAwVGlMazRBUyt3?= =?utf-8?B?Z05lUDVxRU14dGZoZDJ3RG5sdmpLWUYremlWeFNNZ2IwRWtsRFlRREs0WmJD?= =?utf-8?B?a3NMSkM4elIxSjMzdlBpb3lBU3VmazVDc3pLQTU2SkZCaGhUYXEzWjYrdUFr?= =?utf-8?B?ei9yaUFpc0ErKzR3L0FGUERyVlNybzRrQ3RFNWpkVFdYSXhScjJxWURpZ3Jv?= =?utf-8?B?U1lxWC80azJpU1E3KzQ0L1BSazVCWDgrWlpTM01rMDV5R3Eyd3JBQmlTazVm?= =?utf-8?B?S3p6TzluYlhETTFRN1ZDU0JqcTc3L3NtYktNbW9jZmNFUDJPN3BtY1YxVkNW?= =?utf-8?B?Tkh5aW1yM1JaWGp4cUVLanFvMERhd1NHL2NhSHhTWmlJMzIwUCs3clBWUlRa?= =?utf-8?B?aEorUlNqbkZ1S3JCZ0xOc0haK0hPSitmRzhHTVpBQ3RlcE9wYU5UWnQ5Wkha?= =?utf-8?B?K05WRys3VzhRQUxHU1RTaVFzWkRPSElzSmZLOGlrYXVuWWtVNXExL1BVVks1?= =?utf-8?B?emZSdG1jUHlMeUFyeHBzUHlDcllHV3loMzJiS0tzOWZKbmRLVjZYNU5uUVkr?= =?utf-8?B?V2hTQ0c3T1loVzRGbFlJa3Z4L2ZlMWRnQVhpc1VrYmNkMm15Z08vYjYrREFy?= =?utf-8?B?cGU5U0lacTJlbElxSXM5K3JjSnQwdzk4Ri9HbGJDYTJlbmI3clI0Y3N4UVQr?= =?utf-8?B?MS9waUJpRTQ3ZVBWcWhqcld0UDJ2bmtlOGYvK2lEcmhzUEtIM091RzZzWHd6?= =?utf-8?B?a1BTNDZWemdNTU1jZnNDMzVncmgyU3l2MGRUN1YyM1Y1NGZNK2I1VkU5YkxI?= =?utf-8?B?c29DRWdYZXUwYmpTWlA3V0pqL081bHJlbGZDSXVGUDFlajZZL2VJSjNtcWY0?= =?utf-8?B?UHM3SDFPUHVCMlllcmdBMXFUMDlVTFc2dml6S2l4RmpZQVpzL3VoZE9lNHBO?= =?utf-8?B?RFRGNHF0YmJhclZSWUlISmdXQno5QmNpSWVNNUpzcWNNM3c3bHY3QVVhUlJj?= =?utf-8?B?WGhSeitqYTBiREJmWUFJaThMSkFIcVFBdzdqQ0lEWStEUmpKTVpVT0tobEIr?= =?utf-8?B?b1JHd1JiMktNVEhVdkJtRW9ZQjA3RklUeGdqUmpkWEJDZlpXTUxRUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d493a38e-8de6-4ab7-a9ef-08da2da8884e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 08:31:49.2208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AhtRaIIfvZAc7TwDIZ0GnLdy5KNKjJI1rFZ3z2ZgAfSMQzvSpvcQBWpZmqGIssObKPMWhzvHPKsiXLbV90Ay3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5437 On 03.05.2022 15:22, Juergen Gross wrote: > Some drivers are using pat_enabled() in order to test availability of > special caching modes (WC and UC-). This will lead to false negatives > in case the system was booted e.g. with the "nopat" variant and the > BIOS did setup the PAT MSR supporting the queried mode, or if the > system is running as a Xen PV guest. While, as per my earlier patch, I agree with the Xen PV case, I'm not convinced "nopat" is supposed to honor firmware-provided settings. In fact in my patch I did arrange for "nopat" to also take effect under Xen PV. > Add test functions for those caching modes instead and use them at the > appropriate places. > > For symmetry reasons export the already existing x86_has_pat_wp() for > modules, too. > > Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") > Signed-off-by: Juergen Gross I think this wants a Reported-by as well. > --- a/arch/x86/include/asm/pci.h > +++ b/arch/x86/include/asm/pci.h > @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, int pin, int irq); > > > #define HAVE_PCI_MMAP > -#define arch_can_pci_mmap_wc() pat_enabled() > +#define arch_can_pci_mmap_wc() x86_has_pat_wc() Besides this and ... > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > if (args->flags & ~(I915_MMAP_WC)) > return -EINVAL; > > - if (args->flags & I915_MMAP_WC && !pat_enabled()) > + if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) > return -ENODEV; > > obj = i915_gem_object_lookup(file, args->handle); > @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, > > if (HAS_LMEM(to_i915(dev))) > mmap_type = I915_MMAP_TYPE_FIXED; > - else if (pat_enabled()) > + else if (x86_has_pat_wc()) > mmap_type = I915_MMAP_TYPE_WC; > else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) > return -ENODEV; > @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_WC: > - if (!pat_enabled()) > + if (!x86_has_pat_wc()) > return -ENODEV; > type = I915_MMAP_TYPE_WC; > break; > @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_UC: > - if (!pat_enabled()) > + if (!x86_has_pat_uc_minus()) > return -ENODEV; > type = I915_MMAP_TYPE_UC; > break; ... these uses there are several more. You say nothing on why those want leaving unaltered. When preparing my earlier patch I did inspect them and came to the conclusion that these all would also better observe the adjusted behavior (or else I couldn't have left pat_enabled() as the only predicate). In fact, as said in the description of my earlier patch, in my debugging I did find the use in i915_gem_object_pin_map() to be the problematic one, which you leave alone. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 08:36:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 08:36:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320460.541196 (Exim 4.92) (envelope-from ) id 1nmAV1-0006NT-12; Wed, 04 May 2022 08:36:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320460.541196; Wed, 04 May 2022 08:36:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAV0-0006NM-UU; Wed, 04 May 2022 08:36:42 +0000 Received: by outflank-mailman (input) for mailman id 320460; Wed, 04 May 2022 08:36:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAUz-0006NC-CT; Wed, 04 May 2022 08:36:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAUz-0000Kt-8d; Wed, 04 May 2022 08:36:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAUy-00042J-SQ; Wed, 04 May 2022 08:36:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmAUy-0001h6-S0; Wed, 04 May 2022 08:36:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QCQoZS75TAvRkI/RraylTK0RYeIudk7JY4uvr3cIVLI=; b=xd6F9jur2WmynB2TMXQmTedJxP 5eSGWvQqN7nFttrgPfqXsGNOPj5GLH9ewsjuENI2vLuhGd2bIWqSBH8Rza0TjSOusNKjow5Gl3o/O YeXvpL3Gh2PJnsgjrRwfvTFE1811sWe3/NTYqxSuFnmQ8vN/2GUdyaFZCmUtHdexz9LY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170085: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 08:36:40 +0000 flight 170085 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170085/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 795 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 09:03:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320470.541214 (Exim 4.92) (envelope-from ) id 1nmAug-0001Jc-BX; Wed, 04 May 2022 09:03:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320470.541214; Wed, 04 May 2022 09:03:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAug-0001JV-7O; Wed, 04 May 2022 09:03:14 +0000 Received: by outflank-mailman (input) for mailman id 320470; Wed, 04 May 2022 09:03:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAue-0001JL-Oy; Wed, 04 May 2022 09:03:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAue-0000r4-LH; Wed, 04 May 2022 09:03:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmAue-0004mA-5r; Wed, 04 May 2022 09:03:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmAue-0007x9-5Q; Wed, 04 May 2022 09:03:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4brajoL2r4xVerJatknxZaouKnXvdD/GgJ3x1d3hIRM=; b=NhlNVza9YUvgltrq+MZaf4tQiB e3YVEWCaao1Jsv04hDOZ3Q9Ei3wmySDerLA3pkTHDAp/xODb5PvYXEuNq3Bd8mjK46wxE7CUW/esW rNz6edtWDZB6aw096ylCbcQrMeLkLIXekDVKgVLGVXtFfc3pDTBm+OE8Y643Sd6NTneg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170071: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 X-Osstest-Versions-That: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 From: osstest service owner Date: Wed, 04 May 2022 09:03:12 +0000 flight 170071 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170071/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170014 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170014 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170014 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170014 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170014 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170014 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170014 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170014 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170014 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170014 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170014 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170014 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 baseline version: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Last test of basis 170071 2022-05-04 01:52:23 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed May 04 09:14:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:14:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320478.541224 (Exim 4.92) (envelope-from ) id 1nmB5E-0002pd-BO; Wed, 04 May 2022 09:14:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320478.541224; Wed, 04 May 2022 09:14:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmB5E-0002pW-8M; Wed, 04 May 2022 09:14:08 +0000 Received: by outflank-mailman (input) for mailman id 320478; Wed, 04 May 2022 09:14:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmB5C-0002pQ-4e for xen-devel@lists.xenproject.org; Wed, 04 May 2022 09:14:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b5b7871-cb8a-11ec-a406-831a346695d4; Wed, 04 May 2022 11:14:04 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 41FF61F745; Wed, 4 May 2022 09:14:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9CEC6132C4; Wed, 4 May 2022 09:14:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Fr3vJNtDcmIqAgAAMHmgww (envelope-from ); Wed, 04 May 2022 09:14:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b5b7871-cb8a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651655644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAjoNuvoU/e5r+Dhtmbs6y94IojTmAMxzQSPTvQQq3k=; b=mPSdzOe7obE3sdzEwUP7M1b90pyMWlXIHT/sVL28hkQoM3dQFurkrTbvYjJYAZqagWD4YP MqHADrNM/spvAyefN+KPGYz52oXAfwVRD4G+Q67MUc8D6ETmf+JcsUuh7B4eiboE+Wptuf 2dNMZSatWeOVbRhy8Nwr2hNr9BfmgJM= Message-ID: <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> Date: Wed, 4 May 2022 11:14:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> From: Juergen Gross Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability In-Reply-To: <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RlLwG6bGfey6DnwJOYNBjCk9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RlLwG6bGfey6DnwJOYNBjCk9 Content-Type: multipart/mixed; boundary="------------7BrNe85h4V9tvwH7WRoa05e4"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> In-Reply-To: <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> --------------7BrNe85h4V9tvwH7WRoa05e4 Content-Type: multipart/mixed; boundary="------------Y00b4gzBImDUVmzy43dMoV6s" --------------Y00b4gzBImDUVmzy43dMoV6s Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDUuMjIgMTA6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwMy4wNS4yMDIy IDE1OjIyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gU29tZSBkcml2ZXJzIGFyZSB1c2lu ZyBwYXRfZW5hYmxlZCgpIGluIG9yZGVyIHRvIHRlc3QgYXZhaWxhYmlsaXR5IG9mDQo+PiBz cGVjaWFsIGNhY2hpbmcgbW9kZXMgKFdDIGFuZCBVQy0pLiBUaGlzIHdpbGwgbGVhZCB0byBm YWxzZSBuZWdhdGl2ZXMNCj4+IGluIGNhc2UgdGhlIHN5c3RlbSB3YXMgYm9vdGVkIGUuZy4g d2l0aCB0aGUgIm5vcGF0IiB2YXJpYW50IGFuZCB0aGUNCj4+IEJJT1MgZGlkIHNldHVwIHRo ZSBQQVQgTVNSIHN1cHBvcnRpbmcgdGhlIHF1ZXJpZWQgbW9kZSwgb3IgaWYgdGhlDQo+PiBz eXN0ZW0gaXMgcnVubmluZyBhcyBhIFhlbiBQViBndWVzdC4NCj4gDQo+IFdoaWxlLCBhcyBw ZXIgbXkgZWFybGllciBwYXRjaCwgSSBhZ3JlZSB3aXRoIHRoZSBYZW4gUFYgY2FzZSwgSSdt IG5vdA0KPiBjb252aW5jZWQgIm5vcGF0IiBpcyBzdXBwb3NlZCB0byBob25vciBmaXJtd2Fy ZS1wcm92aWRlZCBzZXR0aW5ncy4gSW4NCj4gZmFjdCBpbiBteSBwYXRjaCBJIGRpZCBhcnJh bmdlIGZvciAibm9wYXQiIHRvIGFsc28gdGFrZSBlZmZlY3QgdW5kZXINCj4gWGVuIFBWLg0K DQpEZXBlbmRzIG9uIHdoYXQgdGhlIHdhbnRlZCBzZW1hbnRpY3MgZm9yICJub3BhdCIgYXJl Lg0KDQpSaWdodCBub3cgIm5vcGF0IiB3aWxsIHJlc3VsdCBpbiB0aGUgUEFUIE1TUiBsZWZ0 IHVuY2hhbmdlZCBhbmQgdGhlDQpjYWNoZSBtb2RlIHRyYW5zbGF0aW9uIHRhYmxlcyBiZSBp bml0aWFsaXplZCBhY2NvcmRpbmdseS4NCg0KU28gZG9lcyAibm9wYXQiIG1lYW4gdGhhdCB0 aGUgUEFUIE1TUiBzaG91bGRuJ3QgYmUgY2hhbmdlZCwgb3IgdGhhdA0KUEFHRV9CSVRfUEFU IHdpbGwgbmV2ZXIgYmUgc2V0Pw0KDQo+PiBBZGQgdGVzdCBmdW5jdGlvbnMgZm9yIHRob3Nl IGNhY2hpbmcgbW9kZXMgaW5zdGVhZCBhbmQgdXNlIHRoZW0gYXQgdGhlDQo+PiBhcHByb3By aWF0ZSBwbGFjZXMuDQo+Pg0KPj4gRm9yIHN5bW1ldHJ5IHJlYXNvbnMgZXhwb3J0IHRoZSBh bHJlYWR5IGV4aXN0aW5nIHg4Nl9oYXNfcGF0X3dwKCkgZm9yDQo+PiBtb2R1bGVzLCB0b28u DQo+Pg0KPj4gRml4ZXM6IGJkZDhiNmM5ODIzOSAoImRybS9pOTE1OiByZXBsYWNlIFg4Nl9G RUFUVVJFX1BBVCB3aXRoIHBhdF9lbmFibGVkKCkiKQ0KPj4gRml4ZXM6IGFlNzQ5YzdhYjQ3 NSAoIlBDSTogQWRkIGFyY2hfY2FuX3BjaV9tbWFwX3djKCkgbWFjcm8iKQ0KPj4gU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gSSB0aGlu ayB0aGlzIHdhbnRzIGEgUmVwb3J0ZWQtYnkgYXMgd2VsbC4NCg0KT2theS4NCg0KPiANCj4+ IC0tLSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BjaS5oDQo+PiArKysgYi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9wY2kuaA0KPj4gQEAgLTk0LDcgKzk0LDcgQEAgaW50IHBjaWJpb3Nfc2V0 X2lycV9yb3V0aW5nKHN0cnVjdCBwY2lfZGV2ICpkZXYsIGludCBwaW4sIGludCBpcnEpOw0K Pj4gICANCj4+ICAgDQo+PiAgICNkZWZpbmUgSEFWRV9QQ0lfTU1BUA0KPj4gLSNkZWZpbmUg YXJjaF9jYW5fcGNpX21tYXBfd2MoKQlwYXRfZW5hYmxlZCgpDQo+PiArI2RlZmluZSBhcmNo X2Nhbl9wY2lfbW1hcF93YygpCXg4Nl9oYXNfcGF0X3djKCkNCj4gDQo+IEJlc2lkZXMgdGhp cyBhbmQgLi4uDQo+IA0KPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVf Z2VtX21tYW4uYw0KPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2Vt X21tYW4uYw0KPj4gQEAgLTc2LDcgKzc2LDcgQEAgaTkxNV9nZW1fbW1hcF9pb2N0bChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLA0KPj4gICAJaWYgKGFyZ3MtPmZsYWdz ICYgfihJOTE1X01NQVBfV0MpKQ0KPj4gICAJCXJldHVybiAtRUlOVkFMOw0KPj4gICANCj4+ IC0JaWYgKGFyZ3MtPmZsYWdzICYgSTkxNV9NTUFQX1dDICYmICFwYXRfZW5hYmxlZCgpKQ0K Pj4gKwlpZiAoYXJncy0+ZmxhZ3MgJiBJOTE1X01NQVBfV0MgJiYgIXg4Nl9oYXNfcGF0X3dj KCkpDQo+PiAgIAkJcmV0dXJuIC1FTk9ERVY7DQo+PiAgIA0KPj4gICAJb2JqID0gaTkxNV9n ZW1fb2JqZWN0X2xvb2t1cChmaWxlLCBhcmdzLT5oYW5kbGUpOw0KPj4gQEAgLTc1Nyw3ICs3 NTcsNyBAQCBpOTE1X2dlbV9kdW1iX21tYXBfb2Zmc2V0KHN0cnVjdCBkcm1fZmlsZSAqZmls ZSwNCj4+ICAgDQo+PiAgIAlpZiAoSEFTX0xNRU0odG9faTkxNShkZXYpKSkNCj4+ICAgCQlt bWFwX3R5cGUgPSBJOTE1X01NQVBfVFlQRV9GSVhFRDsNCj4+IC0JZWxzZSBpZiAocGF0X2Vu YWJsZWQoKSkNCj4+ICsJZWxzZSBpZiAoeDg2X2hhc19wYXRfd2MoKSkNCj4+ICAgCQltbWFw X3R5cGUgPSBJOTE1X01NQVBfVFlQRV9XQzsNCj4+ICAgCWVsc2UgaWYgKCFpOTE1X2dndHRf aGFzX2FwZXJ0dXJlKHRvX2d0KGk5MTUpLT5nZ3R0KSkNCj4+ICAgCQlyZXR1cm4gLUVOT0RF VjsNCj4+IEBAIC04MTMsNyArODEzLDcgQEAgaTkxNV9nZW1fbW1hcF9vZmZzZXRfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwNCj4+ICAgCQlicmVhazsNCj4+ ICAgDQo+PiAgIAljYXNlIEk5MTVfTU1BUF9PRkZTRVRfV0M6DQo+PiAtCQlpZiAoIXBhdF9l bmFibGVkKCkpDQo+PiArCQlpZiAoIXg4Nl9oYXNfcGF0X3djKCkpDQo+PiAgIAkJCXJldHVy biAtRU5PREVWOw0KPj4gICAJCXR5cGUgPSBJOTE1X01NQVBfVFlQRV9XQzsNCj4+ICAgCQli cmVhazsNCj4+IEBAIC04MjMsNyArODIzLDcgQEAgaTkxNV9nZW1fbW1hcF9vZmZzZXRfaW9j dGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwNCj4+ICAgCQlicmVhazsN Cj4+ICAgDQo+PiAgIAljYXNlIEk5MTVfTU1BUF9PRkZTRVRfVUM6DQo+PiAtCQlpZiAoIXBh dF9lbmFibGVkKCkpDQo+PiArCQlpZiAoIXg4Nl9oYXNfcGF0X3VjX21pbnVzKCkpDQo+PiAg IAkJCXJldHVybiAtRU5PREVWOw0KPj4gICAJCXR5cGUgPSBJOTE1X01NQVBfVFlQRV9VQzsN Cj4+ICAgCQlicmVhazsNCj4gDQo+IC4uLiB0aGVzZSB1c2VzIHRoZXJlIGFyZSBzZXZlcmFs IG1vcmUuIFlvdSBzYXkgbm90aGluZyBvbiB3aHkgdGhvc2Ugd2FudA0KPiBsZWF2aW5nIHVu YWx0ZXJlZC4gV2hlbiBwcmVwYXJpbmcgbXkgZWFybGllciBwYXRjaCBJIGRpZCBpbnNwZWN0 IHRoZW0NCj4gYW5kIGNhbWUgdG8gdGhlIGNvbmNsdXNpb24gdGhhdCB0aGVzZSBhbGwgd291 bGQgYWxzbyBiZXR0ZXIgb2JzZXJ2ZSB0aGUNCj4gYWRqdXN0ZWQgYmVoYXZpb3IgKG9yIGVs c2UgSSBjb3VsZG4ndCBoYXZlIGxlZnQgcGF0X2VuYWJsZWQoKSBhcyB0aGUgb25seQ0KPiBw cmVkaWNhdGUpLiBJbiBmYWN0LCBhcyBzYWlkIGluIHRoZSBkZXNjcmlwdGlvbiBvZiBteSBl YXJsaWVyIHBhdGNoLCBpbg0KPiBteSBkZWJ1Z2dpbmcgSSBkaWQgZmluZCB0aGUgdXNlIGlu IGk5MTVfZ2VtX29iamVjdF9waW5fbWFwKCkgdG8gYmUgdGhlDQo+IHByb2JsZW1hdGljIG9u ZSwgd2hpY2ggeW91IGxlYXZlIGFsb25lLg0KDQpPaCwgSSBtaXNzZWQgdGhhdCBvbmUsIHNv cnJ5Lg0KDQpJIHdhbnRlZCB0byBiZSByYXRoZXIgZGVmZW5zaXZlIGluIG15IGNoYW5nZXMs IGJ1dCBJIGFncmVlIGF0IGxlYXN0IHRoZQ0KY2FzZSBpbiBhcmNoX3BoeXNfd2NfYWRkKCkg bWlnaHQgd2FudCB0byBiZSBjaGFuZ2VkLCB0b28uDQoNCmt2bV9pc19tbWlvX3BmbigpIHNo b3VsZCBub3QgcmVhbGx5IG1hdHRlciBhdCBsZWFzdCBmb3IgdGhlIFhlbiBjYXNlLg0KDQpX aXRoIHRoZSBvdGhlciB1c2UgY2FzZXMgaW4gbWVtdHlwZS5jIEknbSByYXRoZXIgb24gdGhl IGVkZ2UuDQoNCkluIGNhc2UgdGhlIHg4NiBtYWludGFpbmVycyB0aGluayB0aG9zZSBzaG91 bGQgYmUgY2hhbmdlZCwgdG9vLCBJIGFncmVlDQp0aGF0IHlvdXIgYXBwcm9hY2ggbWlnaHQg YmUgdGhlIGJldHRlciBvbmUuDQoNCg0KSnVlcmdlbg0K --------------Y00b4gzBImDUVmzy43dMoV6s Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Y00b4gzBImDUVmzy43dMoV6s-- --------------7BrNe85h4V9tvwH7WRoa05e4-- --------------RlLwG6bGfey6DnwJOYNBjCk9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJyQ9sFAwAAAAAACgkQsN6d1ii/Ey8i KAgAiuUxDCrW2LM+rNY4P8V/p08F19Eb8X7VjpQHuP5yfA4LSQs5rUcKj45XOxutARuR8yFeQld3 eFoFiGNjPghf587jgGn5pW+uZ9u8+YvRDzmboUP/QH8dcY63VMyP3pBYCxdcgu3UUeAXVPHgcs66 og32V5hSHko4rVj1pu2b7/RwjovXodIF/egi/ux8b4kk0U1kfeJYlplx9T9niQDBw/I/B5/kWPuE BDbIBSyhKGzF0SPom1rITiC9ugSgz6NX89xrLYaPyXHSeZL8hUqyAJ5Cd9iFJCrYgE7J6a1Luajy CYjd+Tc6gPVetmfKKEISEOoRODiMp2kNUxM2ziK9PQ== =v/JH -----END PGP SIGNATURE----- --------------RlLwG6bGfey6DnwJOYNBjCk9-- From xen-devel-bounces@lists.xenproject.org Wed May 04 09:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320485.541235 (Exim 4.92) (envelope-from ) id 1nmBET-0004cV-C4; Wed, 04 May 2022 09:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320485.541235; Wed, 04 May 2022 09:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBET-0004cO-93; Wed, 04 May 2022 09:23:41 +0000 Received: by outflank-mailman (input) for mailman id 320485; Wed, 04 May 2022 09:23:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBES-0004cE-PX; Wed, 04 May 2022 09:23:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBES-0001D4-MC; Wed, 04 May 2022 09:23:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBES-0005Lo-FN; Wed, 04 May 2022 09:23:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmBES-0004Uo-Es; Wed, 04 May 2022 09:23:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=47+hcGAnPQXpUeJP8WJNryK6YPplXhdPqxsQWRCf/uM=; b=WaYEqX2XFqUQlWQt5edv7rnWJw r46JuogR0bUE6ymQfmT/hNCaYWxjvjr85tkCuuGa6tvl6RSLEWe4pal7dVIhRI/tAMKLsu+USxgx/ 0wcJuAcZhnzNmJtz4Vj3+iSvlmvofpJoJKEe8ybbt7gEmvDw0mVA/FuITkET3mNGakJ8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170087: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 09:23:40 +0000 flight 170087 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 796 attempts Testing same since 170038 2022-05-03 10:12:47 Z 0 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 09:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320495.541253 (Exim 4.92) (envelope-from ) id 1nmBNW-0006Ax-Ed; Wed, 04 May 2022 09:33:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320495.541253; Wed, 04 May 2022 09:33:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBNW-0006Aq-BI; Wed, 04 May 2022 09:33:02 +0000 Received: by outflank-mailman (input) for mailman id 320495; Wed, 04 May 2022 09:33:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBNU-0006Ak-UR for xen-devel@lists.xenproject.org; Wed, 04 May 2022 09:33:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2eb15e3c-cb8d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 11:32:57 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-wH463SmSO2ibocIu2JhI5Q-1; Wed, 04 May 2022 11:32:55 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB5114.eurprd04.prod.outlook.com (2603:10a6:10:23::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 09:32:53 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 09:32:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2eb15e3c-cb8d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651656777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saOCQtuwdFVHnqgJh7Wl6ao1vYeQgeyjg/m/LJXlpW0=; b=MHx8EKWB+ZVmfeWuCJ9HVSv8/pK1l336nH7baFf0LO3yZpH6syccIz8/NXqWCb3QGnnCtn J75aS6fhUSBfiPxQFwywaflguRo4gEkRxnUTOVqqUhvS9AEQB6g6eKTnumw5Qsyu8WzoOS CzUeB6R7lEUPlohSeVaYTkS4mRmjB+c= X-MC-Unique: wH463SmSO2ibocIu2JhI5Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAjJvvNxReMUyN4Grc0eOympn80EAirPFWe/RUoOrzR1JtC4LIVJQAoeZ2OLXCzYe/pwltlcgg8ddZruEqGgrzwyr597Nd8hvuqMOHedtrqvi93Y2QF8hO+P+nQqygKetiTQXjqReOaeB1m74B3rXTK8byGFrPw8X7H4rwj9dWU5nvtQk+FPiMatYh5nTG3km+ysKj6UHmHbRJqYke1x+md1dZI3tyyV/dgPwxd5m1f9CLS+4dJaz1hPOmUpZnaA2AM22AXMJZ3U+05S5fpndY3n13d+L/IiX2ujWz2f0EQMzR968i7gzOHG+BrMZ5CcYdDS0jp+fYgJemv+E+Yuaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qQ/tWqPXcQF2o2dkJ8KHWyYx75+mzdxX5FgcKh1v/Fc=; b=hPmdY8KKolCcgvffgrvs2KVczXum3JmFaWIqGA6116ZOiw6n91bFk3MbjE+67ChgZivheyGUOmkXOnIhEOC218xUH/Bcxm+YEwkOnkJyLH+CgR0b0a5GS5oR4drK+5SoLSlhUwDk9XAEI3y+QDAYRg1k3uJNpn91NUKYWDnI+fH58KP1kr+cjLb4nw+Osmj3oG7o8ZtDC2goW5FuiPuilxYu8ULA+YRLK553zS55aN3aUL/dqlTrEyUBhUQUE59J59D5xLsXlmzlyJb//mthibd/KoE9p7Nj9QAfIRV/tR7w1jMRDtMk+5pbawrgZ5lSISioW5uxvSVEeC2qihizTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> Date: Wed, 4 May 2022 11:32:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> In-Reply-To: <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7be8e082-31a0-4e48-bcbd-08da2db11048 X-MS-TrafficTypeDiagnostic: DB7PR04MB5114:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4jgI2zPzovdDHQZ+MS5EJxh7Hb6xYVGvKwwY2GJj8FEbhDZvkmY+My+3mm19J7CsWj80tN8X8eRZKbosGSa30AwZ6CCGH4VZfW0ZcdWnD/rZbEAvOuG19C9jQs5N0uGCqPGyoU4JMIMfEb8c3N6ISKzv5o9WwuaIhiSfWtApN1TWCa4HhOua/0jzFaHXcfiakCdDxbSWvP+jsiSF92Tv3MfchtQaxtHGTiJlaRfP/DyKJAGVRH8eXRavu1AQWK1HEsNqcS0KRaOB0dV6CSf7jBEk+j1FvNLlIsjf64FtPyOgstKucW3qv8QdHqSjko8cv4LRDguIg6GQsYeZdz0yh3xeJEAsO4Z54A0l3DzVpSAGgEyWGkeVaRTv2NMKFEndkBW9NSWliGSQSi/7c8wPZ9hWMoceE8S0pbYUpjbLtyfPfRGg9c0RMocTgDL7n18F2I3IaRca4QoXmXacp/wcQ5ZmLB6eVn16t+hM18XKCA845iVXL8QurPRQgYlUzhJBwL1HroPehDw4iIg2UJ5Wkka9vacJqatYY1/K2yyel3ZK8b5chlTmpKz//jlLQ0xaJ6SMU+yqwFLqM4rpxswA654Q0ef8TCVberZoG3rXpgZGHjkVFWgtJK5B9f0QQLOG24vi0/1FNgDkhWIV4Wj+XYwveniHUTVVbhY418NyUnkLiZuYk1TJZg+a9BApHv9ZV5QBrG99XGxUEBBSP/H0lkXUJNsuu1yAjoLtjm46HejInVxca19hVL9WpLaQTLxQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66476007)(66556008)(66946007)(8936002)(8676002)(2616005)(5660300002)(36756003)(31696002)(83380400001)(31686004)(86362001)(53546011)(316002)(2906002)(54906003)(6916009)(186003)(6512007)(26005)(38100700002)(6506007)(508600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/dkG1mIsduCJI3sHyiO+Qn6GMaZP6OhLZm9zkSx6ZrWxIJ3jGVQeZ9Zl37d+?= =?us-ascii?Q?lc2PxMcxd0gHFtlkYiV9tQq5Qa/FtPbZHZhuVuCV9r4Wy8/ZFQ6y+KmskFkn?= =?us-ascii?Q?qQa9AHF9CDeZdVTSsN4EAy2q/jWeg+RJs/qDM2yEF5bXWRRV3Nr34zeWIwZx?= =?us-ascii?Q?orKfT7ABSm7IJJ4JFf0grd7A0yp6hhHTmfZu3w1pMo/Bdbg31fpWBexXWwPq?= =?us-ascii?Q?GbPCGkWgRFupB5ICd1/7bN4uq9rchQoWGSZpaOjlj/UXd9p/nKgbsiroRHpU?= =?us-ascii?Q?656Hfi4wxuHQxNs6MH9gAUeOf7DB+EMDXSYPbaYJAHPd025z8FeqRJ1UCVGK?= =?us-ascii?Q?70oqpw5y6rjUBaQreoRZ5SNtCWAIoUQh5BKDgIwmo00l2D+eXF7YNyEh9yLO?= =?us-ascii?Q?xiupLVu53V4rOL+Ia3d8NqnwWkWbo/bkOANYeKR6SXGJ+GFbZKT3lP/DjlSv?= =?us-ascii?Q?shiiJsf6EE0XXqEMYRavzK2+rR+0Nns6E3Ihdg4NywcnxLbigxGE76tYHeqn?= =?us-ascii?Q?pnzNon30iAGQdEZTsZ8OlHTcYFNJtzx9oyzpHDmcGZ7rgFchtCQM56HZKt6H?= =?us-ascii?Q?6RM+tC5iAszbi0ypC+dAXgaHuHPM8f4GH1z4zFipvggkEe+xIGmItvpJcmY5?= =?us-ascii?Q?WLQxK0JWUlkm2GjBMHbZphOy2KTbnzryS9LSPVFFOzV2HDJzkeeaMhoJnE4w?= =?us-ascii?Q?SSLu0IbseYv7mQ7AfB2xn0MExrlWjsKW+A2IwNzYjRKx8oemUIeAMmnGhiYq?= =?us-ascii?Q?cstygD/JPSHg0iLPbO0exr86KJgnmrDQDnKLY0r+1doG5FKQjTExtu40Exun?= =?us-ascii?Q?b3F1OJ1Z2VxBFL2D60GqkHj41x0BwXwdyWlLvi1scRcIg0BltCXfj8x0MjK/?= =?us-ascii?Q?Vu9lUopq2a0+Cjv68f1P2SKN9XSt9kdwjjn4CN6lCxBITdD00bQJ0QISPb5L?= =?us-ascii?Q?5aM8iAb+BIlLN06QeNF16sA/wOj1eG2ryZOQdXtG7feLxnmNAdTI6iFp/47F?= =?us-ascii?Q?wKSWn/udA2M58yG8XZfiFpGJ8swTxxnMg+UMJzjF+o6JpRCG3epAaCSk3HeZ?= =?us-ascii?Q?+P0XEljq360v+56nkqcx2rEBL2S1nnpJGAaETkRH/Tns2jDDP1Fc1+97Jlr3?= =?us-ascii?Q?Hn5hlKSU7UGL8m8606Hr7zoi1TgVDpvbL63XpXmtLPViabOgJQQuZofeWIZD?= =?us-ascii?Q?5Uc6vvaliCsXqHYBd3lGX8on7tsxqpSGRfMs2M41tlPgirh+SW4MLZ0xftcd?= =?us-ascii?Q?ax+houkPje/KhKeW9pBzDwXPlj4oRu/msZ/dTaqC8+oe4I+sfY0e/dM8/cD0?= =?us-ascii?Q?AWoqYakSufbTsObWKIU1n5tdxCLVYpRFEC9ad6rfyetCvGYyvHPq0yYf3KId?= =?us-ascii?Q?vPiFxNfgelhznbajfxx8q0KjlQMVGRE8FhNfF/wHK947sdvVoMrTzQyHRLcI?= =?us-ascii?Q?EPPeX0v2Cq4e1l4HEgNF/qpar9WB9b1CrAu5otJ0ES25LPO8nEUBjOFWoTYO?= =?us-ascii?Q?lOJwXV0k7+ooIf4OjoH+JO46Q1HCMnVHfrCPfOpo+vY1R5oVpXgeSJStH9Er?= =?us-ascii?Q?9A2kNa8DfztcN+7McOSSv0lRSur93zegcwcx3aCabc4g0Ju2JwCXUdi+Jm89?= =?us-ascii?Q?hTfruvigtMlaN5nKWFpDH0Y5ShlyL0vCupZPPauE3pz/ETo6v9fOxJppo50p?= =?us-ascii?Q?wdCpnLPbfhi0r7K+U1gpnB6u24lX86aEh8+C98yLftrwXKStvOOVcMFTwWge?= =?us-ascii?Q?GdCExBfJRw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7be8e082-31a0-4e48-bcbd-08da2db11048 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 09:32:53.3259 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kGefTwdi/4UYF7FrPqQwngqPsFvxdapEDxneQAXgB52xXcB8M2GDKK1+j8ZrFAkSwuJhFrrF+WrsX1kH9Do4Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5114 On 03.05.2022 16:50, Jan Beulich wrote: > On 03.05.2022 15:00, Roger Pau Monn=C3=A9 wrote: >> On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: >>> While already the case for PVH, there's no reason to treat PV >>> differently here, though of course the addresses get taken from another >>> source in this case. Except that, to match CPU side mappings, by defaul= t >>> we permit r/o ones. This then also means we now deal consistently with >>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> [integrated] v1: Integrate into series. >>> [standalone] v2: Keep IOMMU mappings in sync with CPU ones. >>> >>> --- a/xen/drivers/passthrough/x86/iommu.c >>> +++ b/xen/drivers/passthrough/x86/iommu.c >>> @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct >>> } >>> } >>> =20 >>> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, >>> - unsigned long pfn, >>> - unsigned long max_pfn) >>> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *= d, >>> + unsigned long pfn, >>> + unsigned long max_pfn= ) >>> { >>> mfn_t mfn =3D _mfn(pfn); >>> - unsigned int i, type; >>> + unsigned int i, type, perms =3D IOMMUF_readable | IOMMUF_writable; >>> =20 >>> /* >>> * Set up 1:1 mapping for dom0. Default to include only convention= al RAM >>> @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map >>> * that fall in unusable ranges for PV Dom0. >>> */ >>> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) >>> - return false; >>> + return 0; >>> =20 >>> switch ( type =3D page_get_ram_type(mfn) ) >>> { >>> case RAM_TYPE_UNUSABLE: >>> - return false; >>> + return 0; >>> =20 >>> case RAM_TYPE_CONVENTIONAL: >>> if ( iommu_hwdom_strict ) >>> - return false; >>> + return 0; >>> break; >>> =20 >>> default: >>> if ( type & RAM_TYPE_RESERVED ) >>> { >>> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) >>> - return false; >>> + perms =3D 0; >>> } >>> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > = max_pfn ) >>> - return false; >>> + else if ( is_hvm_domain(d) ) >>> + return 0; >>> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) >>> + perms =3D 0; >>> } >>> =20 >>> /* Check that it doesn't overlap with the Interrupt Address Range.= */ >>> if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff ) >>> - return false; >>> + return 0; >>> /* ... or the IO-APIC */ >>> - for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ = ) >>> - if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address) ) >>> - return false; >>> + if ( has_vioapic(d) ) >>> + { >>> + for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ ) >>> + if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_addres= s) ) >>> + return 0; >>> + } >>> + else if ( is_pv_domain(d) ) >>> + { >>> + /* >>> + * Be consistent with CPU mappings: Dom0 is permitted to estab= lish r/o >>> + * ones there, so it should also have such established for IOM= MUs. >>> + */ >>> + for ( i =3D 0; i < nr_ioapics; i++ ) >>> + if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) >>> + return rangeset_contains_singleton(mmio_ro_ranges, pfn= ) >>> + ? IOMMUF_readable : 0; >> >> If we really are after consistency with CPU side mappings, we should >> likely take the whole contents of mmio_ro_ranges and d->iomem_caps >> into account, not just the pages belonging to the IO-APIC? >> >> There could also be HPET pages mapped as RO for PV. >=20 > Hmm. This would be a yet bigger functional change, but indeed would furth= er > improve consistency. But shouldn't we then also establish r/w mappings fo= r > stuff in ->iomem_caps but not in mmio_ro_ranges? This would feel like goi= ng > too far ... FTAOD I didn't mean to say that I think such mappings shouldn't be there; I have been of the opinion that e.g. I/O directly to/from the linear frame buffer of a graphics device should in principle be permitted. But which specific mappings to put in place can imo not be derived from ->iomem_caps, as we merely subtract certain ranges after initially having set all bits in it. Besides ranges not mapping any MMIO, even something like the PCI ECAM ranges (parts of which we may also force to r/o, and which we would hence cover here if I followed your suggestion) are questionable in this regard. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 09:46:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320501.541264 (Exim 4.92) (envelope-from ) id 1nmBan-0007kQ-Ny; Wed, 04 May 2022 09:46:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320501.541264; Wed, 04 May 2022 09:46:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBan-0007kJ-Iq; Wed, 04 May 2022 09:46:45 +0000 Received: by outflank-mailman (input) for mailman id 320501; Wed, 04 May 2022 09:46:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBam-0007kB-6n for xen-devel@lists.xenproject.org; Wed, 04 May 2022 09:46:44 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a6097ef-cb8f-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 11:46:42 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-a0v6ymhzNW2VSgq_7wn2Gw-1; Wed, 04 May 2022 11:46:41 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by GV1PR04MB9149.eurprd04.prod.outlook.com (2603:10a6:150:24::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 09:46:39 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 09:46:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a6097ef-cb8f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651657602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cK6OCi5oWKM6GuPQATG/SVn9ENc8ADMMZC2dCddWQTo=; b=e+q1CScv0sBCXGUEDJj0RLBIhrzwsEn/Iz40z0nQivHONlkVKku/rRKXHf4GSIhp/5ff7Q UyzeN4+7XMjMe9FOA8QBpZ0gGKJd9I7NFx/Af+R7pXVrGLcTw2CqPypLpmPvqqYKlSlcCU lAN8LdemP64v8e9FFmpzOWUE+kMhjQk= X-MC-Unique: a0v6ymhzNW2VSgq_7wn2Gw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B7Q2kE9ZdQP7BjyrzhLGcGS2KEP/GK0wvps1g7Zb5v0vxq8BpiMPNctO91imkU7RYCgm8BW16nr990m9dczmOxLH0M9fruDnekV4sIg4XFMxGuSNFMHvof8OPHN2lu/XctNLzDF1AIRXzFQm1IhytCQZDbyQnA8sNMVVxbeB75vonhW394ffeVuxPkvcjah2HiN4aiY1eAAjawuX4Lhq8snaE1n/BEsZW9Yw5tpVdppARP0AplT8YvR2atzpYvMZBxTbybasldu3LwZfiA5omb5MqyqdHOHSkgV9w0tNv6Jt2EhpJ7Ju7G7xjQPvasMhD2MGELlDKRiCQHAjF7pzlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vuvmrCTvQYgpXyhHw0y7zflM6sqF8Uc+05hhmG/uaiQ=; b=P2d+GK04/1mhEY1O1BJZ0Yv8Rra6r7JPGxnq1sI3RXcclPZBBNsmNSarFxVbiXQfVDY8kmRaYrvvy4AVRcja2zhGMBnnhFNhw36FAuYfC+E2L54kGMV2lBfIwWtMVLUbe0paCIQdx75X41alANnxklOwNEHpHxsm/ymLEtVHWSK1x1EBSm4wu9WCDXN7b5QhCjSE+z9Kcoa4VLJM/7RS/LsHCogSpxQgxkQHa/BWJvrj79YAZ1l5Tj78SYzfvhpII3HeEPEdyWq34rNc9IBndtm4zTIgNkQL+DvWcH8hiZwYRCpkfan4WP+8Cnis2kfJ/d3VeXLkr8oEX8TlB4StLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> Date: Wed, 4 May 2022 11:46:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0320.eurprd06.prod.outlook.com (2603:10a6:20b:45b::33) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d945f9e-5a1b-4887-7745-08da2db2fc90 X-MS-TrafficTypeDiagnostic: GV1PR04MB9149:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o5QLrOEoQhI9EQCeHXbEWUSGdE2wwd+KwYzC3nvf+Ctn5T0gbl0fu3S/SRhy2CsyBFdasy+jy6c+WRC2qQX+iQtYmMDRCFtcnLp/x605q3vFo4J8Jw+dKsfmzl41/qz0/IiRQgotY0e+I5lNwUfEpxTOVzzUB9S6kc2ZKRQxehdzmXMvwT3IDUwMbKg2MkalluUPHYgi8BwfQARMOvvZPW8nEdIogfyXNJrP7M4dLdNJn1FJMPOEvUQCX0f+hkKGyXuOFLbTu8L7iC4dOQA7mQ0IhBwnplRpQes+zL9P49Bi0Ei4+/31eruSiUvIFUfr1XKQ1W393u2N96JjLP8okMEQtfk6GT2qZLxa2d7/TQZcjOh0CqMu080+f+cOtHSy6fbhInJfSMDScjjMftHxkUNnL9ASUc4WZ0XQqGyf1P2RxLsNtkyLJYJF3KAqnbVjrmFkW+9udP6kVZU8Hmn7595NG5XGCzqjgmJCBgmppCZPcRXBPKNv5piy32XGRTRymH38ywCnld6yNojRkcPhLzwCL55xDRokFoX2W9dm3lcJU19sdkQzNdjtsLK1fuyFE/swXLEkTu1t9Ci4rMzwPKnSWrbsXOEAToQvJ3UAAwOJkJcuNfKfBueHeYfuoK39CB6V7QlEDH8OR7TRwdnMqNnbyAk6K0TjHhD4CvGdSWgRpcE7Poh4zBDqirhPmndOMbIcXitymqzVCztJMqb2nNANxYdrlgsGGtKPdKnK5ts9b6CLAVQFJlUKtHPB9sqG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(54906003)(6486002)(6916009)(38100700002)(2616005)(5660300002)(186003)(36756003)(8936002)(86362001)(31686004)(26005)(6512007)(6506007)(53546011)(316002)(2906002)(31696002)(83380400001)(66946007)(66476007)(66556008)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oHFvZAVenJ33GwUcKlGQ9WG9eYcnoAx26a0YeDY+9b2Me6qg2hmBgy/z68i6?= =?us-ascii?Q?kd92XgyF2w7RdjV9eQ62qwz7yaQMUdNbSMyQzAlj4Xr6Mf6vV2qhiHLLC04m?= =?us-ascii?Q?1lrXs4Xun0XyYXg2iQXGvGH+Z7xDuB+umK1gA/gB2Vx7QT3f7PiiNy7jYb56?= =?us-ascii?Q?lJQdagMEZ8599aoJvKC4dRbvdo8sfheo1B56dJogadY5XC4/iJc/+SqS4o5m?= =?us-ascii?Q?FQ6GGM5fG2MUJKf18Sf7knyXOGUVQ99Ad61NB2FZwj6Vj4LklsHFpf7b3pT0?= =?us-ascii?Q?csShMZ3jxlJrJOuOavA8e98mFYDwWrqIkbQWRVjFGXtIQxRptuEPX0DfDhvd?= =?us-ascii?Q?MC/ba568gn7dqSAJcCJ87DFjJAIj3jV/Ts+BEgIynJNf4LWTa2Lk0nm5sqQv?= =?us-ascii?Q?8Y1hwW3a5HEl11at7jSOlCNA6hJ74kLkM1ejLhd4SB6xz2XCysn2po8OqmBi?= =?us-ascii?Q?kknRsa6lGLakJIUIGEkQ4OSZaJk+hRgbhJeDku/yU1hqh/VZyA2b7sK2qSoX?= =?us-ascii?Q?wUn+UUPUshQm4dulboYbQVYobI2nnwCKGvlRGUcqD8o1OEGlLv1B56dENRan?= =?us-ascii?Q?1lchDbLxGg8aiUD16B6d5dyAlOOkxXF7bVjfbhKLl153FWsaO2x8mBvK/px+?= =?us-ascii?Q?FRu0e2ZQPLAP0pXtN5LXTqZ8sNwIGtcVEQ+9UV049oytt2teQkL8r0GAW7Ss?= =?us-ascii?Q?7GvVCOFQXQG8rdrxjn3iDD8nIHbtTLbBVhLCmmNjubDs6im+FTO+CsX5f0Fz?= =?us-ascii?Q?AgJlgiVm8g6WFtXRfWia76fkkJL2UCIqzRgW9fEm/ykQYHtIQhX2QeObemI4?= =?us-ascii?Q?awmN3iPEd2VpPuLJGI4MEycEQyEwiBhhwdydrYwuL3n2Ab+vFrF5LffD5Kud?= =?us-ascii?Q?c6H4hAxnSORbTKYK4L2bCCaiyRQzCDhY4MiTuC3HTy9R7wEFLHG2obu4uSJj?= =?us-ascii?Q?SD3hOFTYTCFrRl9wnam5rUQsKdpqZcCX98bOzcpEcSrkZ6zDpfdORklqWxR/?= =?us-ascii?Q?3S6clX3RBXLeC7NXkv3G3Yq9xQ8BZmUkPyXl18NuKV9aa1msnZhxAbDMTJa8?= =?us-ascii?Q?E4yDDHwuIXkA1E6qyCTJYL/hKKEbyrk9kNI7GOVJYeFO17KJIUJzseBRbT1z?= =?us-ascii?Q?nTr5qOy1k5neX4bLQYXqyOjYxq8yLJRKUUEgbiHG1AmHUkAdPm3aZMVCayoS?= =?us-ascii?Q?/a7ueQeI0bbpQqGvnrgUJ2O2UxWSPVWvznW3/dY3U7dmq20d69ZSFEM1m6KY?= =?us-ascii?Q?42apgD5aViOgBygklf2C9KUdM7AJDXc9MxbhaZGyvL8WzlwzL1VVagkNvPIn?= =?us-ascii?Q?8lObAGmCfGSrjki/ZEJ34S68NAqPeZ6RzBENd3qc1YdDCBqSBwRDS6WxQKYQ?= =?us-ascii?Q?XH53pxaJtoqlTJ4AV564jGMNDVlNKarjYxdtxiyDnuoQDnRXJ4gGEiM23I5e?= =?us-ascii?Q?SOZF0As7lAdunxrcRtJYUKigFBTwEU6YOwoyINIeuRb3wPFpYMS52SdfSVSf?= =?us-ascii?Q?QLyW7WAPX2mym5+o5OSSRb+DGkBR14SnEpFGFx0XvEd3SWP6T4TnU8WXeW5q?= =?us-ascii?Q?T0+/6b4yvOo4G79kjK+fmNn86EfUowtTCJm91ITVsU2F/RyeDeG2hil6g3c6?= =?us-ascii?Q?MaxvtYTKA/h3VWw7Pu8QT4HphKNbhLxQkambRz1DnvPMI6X4rGmDEH7w5CKN?= =?us-ascii?Q?nmfejltGBdRgjfSVoUyvliUxrGLdXaKaSd/ZYjgRp2Ah7aEo768EKCIVUazh?= =?us-ascii?Q?g52w6VpcnA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d945f9e-5a1b-4887-7745-08da2db2fc90 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 09:46:39.2038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g7EI0Gg7w9lFpa4Lr/63j3fAZ7zWsR0Rl2k6+FDqXZ4u5s7L5MbyOKBSGjo1nDsUHyYYbxT0LHuDiaLbwmCxSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9149 On 03.05.2022 16:49, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: >> For large page mappings to be easily usable (i.e. in particular without >> un-shattering of smaller page mappings) and for mapping operations to >> then also be more efficient, pass batches of Dom0 memory to iommu_map(). >> In dom0_construct_pv() and its helpers (covering strict mode) this >> additionally requires establishing the type of those pages (albeit with >> zero type references). >=20 > I think it's possible I've already asked this. Would it make sense to > add the IOMMU mappings in alloc_domheap_pages(), maybe by passing a > specific flag? I don't think you did ask, but now that you do: This would look like a layering violation to me. I don't think allocation should ever have mapping (into the IOMMU or elsewhere) as a "side effect", no matter that ... > It would seem to me that doing it that way would also allow the > mappings to get established in blocks for domUs. ... then this would perhaps be possible. >> The installing of zero-ref writable types has in fact shown (observed >> while putting together the change) that despite the intention by the >> XSA-288 changes (affecting DomU-s only) for Dom0 a number of >> sufficiently ordinary pages (at the very least initrd and P2M ones as >> well as pages that are part of the initial allocation but not part of >> the initial mapping) still have been starting out as PGT_none, meaning >> that they would have gained IOMMU mappings only the first time these >> pages would get mapped writably. Consequently an open question is >> whether iommu_memory_setup() should set the pages to PGT_writable_page >> independent of need_iommu_pt_sync(). >=20 > I think I'm confused, doesn't the setting of PGT_writable_page happen > as a result of need_iommu_pt_sync() and having those pages added to > the IOMMU page tables? (so they can be properly tracked and IOMMU > mappings are removed if thte page is also removed) In principle yes - in guest_physmap_add_page(). But this function isn't called for the pages I did enumerate in the remark. XSA-288 really only cared about getting this right for DomU-s. > If the pages are not added here (because dom0 is not running in strict > mode) then setting PGT_writable_page is not required? Correct - in that case we skip fiddling with IOMMU mappings on transitions to/from PGT_writable_page, and hence putting this type in place would be benign (but improve consistency). >> Note also that strictly speaking the iommu_iotlb_flush_all() here (as >> well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be >> needed: Actual hooking up (AMD) or enabling of translation (VT-d) >> occurs only afterwards anyway, so nothing can have made it into TLBs >> just yet. >=20 > Hm, indeed. I think the one in arch_iommu_hwdom_init can surely go > away, as we must strictly do the hwdom init before enabling the iommu > itself. Why would that be? That's imo as much of an implementation detail as ... > The one in dom0 build I'm less convinced, just to be on the safe side > if we ever change the order of IOMMU init and memory setup. ... this. Just like we populate tables with the IOMMU already enabled for DomU-s, I think the same would be valid to do for Dom0. > I would expect flushing an empty TLB to not be very expensive? I wouldn't "expect" this - it might be this way, but it surely depends on whether an implementation can easily tell whether the TLB is empty, and whether its emptiness actually makes a difference for the latency of a flush operation. >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i >> =20 >> void __hwdom_init arch_iommu_hwdom_init(struct domain *d) >> { >> - unsigned long i, top, max_pfn; >> - unsigned int flush_flags =3D 0; >> + unsigned long i, top, max_pfn, start, count; >> + unsigned int flush_flags =3D 0, start_perms =3D 0; >> =20 >> BUG_ON(!is_hardware_domain(d)); >> =20 >> @@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init( >> * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid >> * setting up potentially conflicting mappings here. >> */ >> - i =3D paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; >> + start =3D paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; >> =20 >> - for ( ; i < top; i++ ) >> + for ( i =3D start, count =3D 0; i < top; ) >> { >> unsigned long pfn =3D pdx_to_pfn(i); >> unsigned int perms =3D hwdom_iommu_map(d, pfn, max_pfn); >> @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( >> if ( !perms ) >> rc =3D 0; >> else if ( paging_mode_translate(d) ) >> + { >> rc =3D p2m_add_identity_entry(d, pfn, >> perms & IOMMUF_writable ? p2m_a= ccess_rw >> : p2m_a= ccess_r, >> 0); >> + if ( rc ) >> + printk(XENLOG_WARNING >> + "%pd: identity mapping of %lx failed: %d\n", >> + d, pfn, rc); >> + } >> + else if ( pfn !=3D start + count || perms !=3D start_perms ) >> + { >> + commit: >> + rc =3D iommu_map(d, _dfn(start), _mfn(start), count, start_= perms, >> + &flush_flags); >> + if ( rc ) >> + printk(XENLOG_WARNING >> + "%pd: IOMMU identity mapping of [%lx,%lx) failed= : %d\n", >> + d, pfn, pfn + count, rc); >> + SWAP(start, pfn); >> + start_perms =3D perms; >> + count =3D 1; >> + } >> else >> - rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER= _4K, >> - perms, &flush_flags); >> + { >> + ++count; >> + rc =3D 0; >=20 > Seeing as we want to process this in blocks now, I wonder whether it > would make sense to take a different approach, and use a rangeset to > track which regions need to be mapped. What gets added would be based > on the host e820 plus the options > iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes > based on the logic in hwdom_iommu_map() and finally we could iterate > over the regions afterwards using rangeset_consume_ranges(). >=20 > Not that you strictly need to do it here, just think the end result > would be clearer. The end result might indeed be, but it would be more of a change right here. Hence I'd prefer to leave that out of the series for now. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 09:50:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:50:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320508.541275 (Exim 4.92) (envelope-from ) id 1nmBe7-0000js-As; Wed, 04 May 2022 09:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320508.541275; Wed, 04 May 2022 09:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBe7-0000jl-5n; Wed, 04 May 2022 09:50:11 +0000 Received: by outflank-mailman (input) for mailman id 320508; Wed, 04 May 2022 09:50:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBe5-0000jX-93 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 09:50:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0629.outbound.protection.outlook.com [2a01:111:f400:fe0c::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94d0f904-cb8f-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 11:50:08 +0200 (CEST) Received: from DBBPR09CA0012.eurprd09.prod.outlook.com (2603:10a6:10:c0::24) by GV1PR08MB7986.eurprd08.prod.outlook.com (2603:10a6:150:9e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 4 May 2022 09:50:04 +0000 Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::9a) by DBBPR09CA0012.outlook.office365.com (2603:10a6:10:c0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Wed, 4 May 2022 09:50:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 09:50:04 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Wed, 04 May 2022 09:50:04 +0000 Received: from a08369454825.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FD642911-2911-499C-9D32-E1926D99BAD8.1; Wed, 04 May 2022 09:49:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a08369454825.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 09:49:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB3009.eurprd08.prod.outlook.com (2603:10a6:208:66::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.16; Wed, 4 May 2022 09:49:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5186.028; Wed, 4 May 2022 09:49:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94d0f904-cb8f-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CDRFsv4Df9OZYMtw+OVd5bCd2CeDxb7tEU0QRx9l6KSUsAGKNCMTkb2fi0kGaG1qhNWJigG91XHZuu/aVWeb25exk5bHc0YsAR5AwVjGFMZ4G6VfJA9xrCKLg1bBOj7TR78PxtfOKwfu0WiiGSmrpwJSNieGaZpo8y69oIAungc46Lgb29qcTG8akgOhvQz8dlTmr4r4pJ2TAcK0BUlgXzaVAZF5qN7IGgp6NGKHWT6+Ax841vVjwJKYM+/ycfl/VsIW9yp/sxu14Ycd/eh46BY8HLFs2qvRjYPJrXUW3yDF03YMpV/ObUX/pse6RqH3Oqyc7dVSheLZD5pu7x1RFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4yrrZoq72BY0aOgRp+XuKvQ60XUgDAQlKDmxu9cXok=; b=Bl/LRoLhzUZZv1pGG8MyrPv63Rv4ZWlbHkuOtwj51kGZSOv44GuO1yUxjUga77gafFdV+/CiBDQzeIetoLkPjyKiq5o9DV6pWwz+JIhJBQ+mjxV5NOhuDdCeNrJ6EbGA12TXcKi68ws4Gh3l+m3cycaUTTt59vVABbdZBHpIGoF8pPovR6pKrCu9P3j/RzLjWhJKzCtlmidScySSqFKbT/97WP99DMBAYqg4f0VBytSA+L7JdjFh/ZJyepeMjgqImEF/H8tqFoxoOb+8G4eeAhuEaRvk9lzS/u37+xfSItJYAqO+zlIjiZrXQlwpD54sOvrz/ntf5xPnjsJa0RWJ6g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4yrrZoq72BY0aOgRp+XuKvQ60XUgDAQlKDmxu9cXok=; b=zsYQOXHxTbtIyZA35uCCUPPg9MXfpM0SjgRjQPW9JFU1eQQv2RjhvpWaoyDlMHQi3jZ9QXAotJY+FkM1GN9vEW7s3O9KEjYjkuky8makOBz0YLdjyYYjzMk6W7ZcLEUi/XgJ2D+5DmGxEiQzMUeJShJe2XW4cCY8wS8WL4Wm19E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 002f77ecf03e342c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5gifq9RU5WGkcaqMeYwDqW6FxM/mGWcZZGywNGmxCAv58pj8IctGxVIRNqu2mrCV5/v6YBCRGLrZMzygXykbQq030yDeHZFpFZ3U3h88F2UnFchl9Hf0qmwC6TX4p0Hjp+TNdnlo4jZDeGuicmNE1Lj8nhXVh3KvGH0hBaszXavIok6HzLccrsHIIBJwseyHtPAnJXhMNDB/K/ThpqFc6LV+a0SXmOKUXA4DG8eTSUmQvb5GACTxJiOTRG1yICnUNWmY1pm6TXsbwmo5ZxQOmgsiSPF+bUeBuJ8EO0FIae462sgB7ZXTtEjYrbhCaM+T87NLa/ojFYGMsK2R18mmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4yrrZoq72BY0aOgRp+XuKvQ60XUgDAQlKDmxu9cXok=; b=fWocSSXb5G0f3pvuRa2nQDcfh47LAOup8JUrMPlCMoubCHy2X23IwLLJxlLHgRHjopUVzj0iuEp2FgYqNDLK6kJtukOuebmVc9iY9l047FSFAxZXnfKlnbfEgFH4JPgRvbziOqfAfWzEEyCm2AnCTqYHwIXwJDA4/Ms/C9PPVc+80/zDeWWYQxY0ZE5s/GYcgwygLnMMKbx3Bykfky3Pmqfdw3+PE0dX3hXMw4E/9F/XQ/nb9Z5P9v3ili9o5kNnqh6RM5qNgTF+s7VBsp+kA806Op5NPMaN/0NUZUxCN+pWwHbaev7nRMrxjaNEdIj8dwPIOHrEqRGfi1LKAEB3iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4yrrZoq72BY0aOgRp+XuKvQ60XUgDAQlKDmxu9cXok=; b=zsYQOXHxTbtIyZA35uCCUPPg9MXfpM0SjgRjQPW9JFU1eQQv2RjhvpWaoyDlMHQi3jZ9QXAotJY+FkM1GN9vEW7s3O9KEjYjkuky8makOBz0YLdjyYYjzMk6W7ZcLEUi/XgJ2D+5DmGxEiQzMUeJShJe2XW4cCY8wS8WL4Wm19E= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0A Date: Wed, 4 May 2022 09:49:54 +0000 Message-ID: <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a0c3c9d5-7147-4e25-58b1-08da2db376c4 x-ms-traffictypediagnostic: AM0PR08MB3009:EE_|DB5EUR03FT010:EE_|GV1PR08MB7986:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BcocTth2w+yKls3hK3gg72r93mA1DAS/1CZU7xMM1JDe5pJAjfaxqu8ebYMY/tju7wRjSssWThUNUrkR/zkk8fj/3KtCTK9RQWkVKGHdyj6jM9Z222kFI8ZxMgaoiUeF61P05GfGVtAOOz+cUECSv8/Y45rFDmFssOFez+xIgpbz8C2WiKgqUm69e0Yu8jWJLSXVhZncwpqRuekQpoprNE1teexLlkhKr35wKqAiFBjqD4iZiG2CuP6zfVGIvtrqRLw9hWbmHBVCxXrMatKGNxqCHJ4jWuieKTSXOc97Yj/sWAXWcMec60T7Hz9DZ/d9yS+EIzUnUW21wLuXAR+ixfjJMgGb/JD49jFFZL0xFLDjDSHWNPC1qln1hEEiA/fFLOSkB+/3gzp02QTLbJPbEu+3xlKPP5sdvmt7bkEMVkLQgqjryW2qnt/6kxazNbeUt9wnlx6tGwuv9YotRRHGrqloNR2G84bFLedmm2zmkF8IZPflWpzJTI+wJUlRHvJXhZMziY+RRwp8lNN8eQzxZyxTKxfb3sc+2Q3Oeyi/VekAwrWqp3o0bidlgW4UB0aDD0J6YcKhYdUnxhuQmCXmOmAR7B8xKKAoFx0/fJ+9bc/TKQo158FKsQdRqc9SDF4eQLOFv+cN/XWRbpri1yKAfD/YWxpyjBJbbqhg9VH9eUuKH+U5E6EC0vpVyPCqwRqe3++0ajHzfqyvrvn1o9qEJNiLbGbYsX7lrCQbjnlbAp27/smfEGC6OSJ4qPo/3fTteH9hykuE/Njw/FctVy0U4tHZhNDV0GtDp61qlrUoAIm9rS0z/RxRx0rcA4GBHbvQUv4DNmzQXHKXsuL/d4EVjHnqNaLuTdWSD/CZ4+VHkUTDX/vE+AYLz4TLnn324sfH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(186003)(36756003)(83380400001)(2906002)(53546011)(26005)(66946007)(122000001)(8936002)(6512007)(5660300002)(6506007)(66476007)(508600001)(76116006)(66556008)(33656002)(8676002)(4326008)(91956017)(66446008)(86362001)(6916009)(316002)(71200400001)(54906003)(38100700002)(38070700005)(6486002)(966005)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3739599378D65043842FCFA835B71FF1@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3009 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3b4872e6-254c-4371-5994-08da2db3711a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X7Dc2AoSehozbmLsDcyBZR8NhkcLtftUrxfx4cBEf1YHZglsJ6nNmivna/LnBKlvGlvVhPT1clq4gckMQyu1xSJiYvpC9Uc98fMtGfkUHeCRJ8Me2W8yPNnQqS88r4W4VrBi9Q0xTNjRXC39S8jnK/J1OduA18pYjzN0mmBDltqct+vwqdFFdj6TqLEWJtx+/Hc7LaT+Vh5/SXdRq7fX1/8SEoV/LeZFDv244GFraNffpuF7LcbLkmDAnBHhB17No4sDvYxuK/0KWkDSpxFE+KLNQBCNNSq7E52UHya7h6thsLhT4z4LGYRMjIUiymXG3YG2Y9xbwy+ntT4mcXO8VyVsFVJLJbp5HHHEtwnNHUXC30GcOP2GrBwkLX+OSqSYbZmie7J1EgCMDbTvdhAOKUY8RqPzqsRt0wkwhOSd4swkiHIkPu+Wf6if6SQPPzbURbHvx3JGDyD3PmVSE3x7saku516XksB3jp2a9MdNGnPIUQNMzF8qp+xG82/eKW9XiIl4UH4PTH1PcFoKh0cN32UPk6wzXNHC82jbMb7r225UPGT2J/H+guJMWE1VwQqvL4YRL6PhPZvB4bflPCBR93oIGAmZ4+gsFQQuESFbWrpzXPEqIvKo2oa2fqvFph3AzZhoGqdJC6NzoqHDYP5ndCRtU2uNFRyhU0FxBrUZ0QPIEA+wjByW35x1fve2Hb5RJbPEMMDDhpA40BorG8ZRUgnRE2o416EBQtTnfZ9bz1sWAbIz0fRjq4Q5aSn6IYFH4gUUQRch6hu972S00z4SGA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(186003)(6506007)(26005)(336012)(107886003)(6512007)(83380400001)(47076005)(2616005)(81166007)(36860700001)(40460700003)(53546011)(2906002)(316002)(82310400005)(33656002)(8676002)(4326008)(6862004)(54906003)(86362001)(70206006)(5660300002)(8936002)(70586007)(508600001)(36756003)(966005)(6486002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 09:50:04.1236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0c3c9d5-7147-4e25-58b1-08da2db376c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7986 Hi Julien, > On 4 May 2022, at 09:20, Julien Grall wrote: >=20 >=20 >=20 > On 04/05/2022 08:39, Bertrand Marquis wrote: >> Hi Julien, > Hi, >=20 >>> On 3 May 2022, at 19:08, Julien Grall wrote: >>>=20 >>> Hi Bertrand, >>>=20 >>> On 03/05/2022 10:38, Bertrand Marquis wrote: >>>> Sync arm64 sysreg bit shift definitions with status of Linux kernel as >>>> of 5.18-rc3 version (linux commit b2d229d4ddb1). >>>> Sync ID registers sanitization with the status of Linux 5.18-rc3 and a= dd >>>> sanitization of ISAR2 registers. >>> Please outline which specific commits you are actually backported. This= would help to know what changed, why and also keep track of the autorships= . >>>=20 >>> When possible, the changes should be separated to match each Linux comm= it we backport. >> As those are exactly identical to the linux tree, one can easily use git= blame on the linux source tree to find those information if it is needed >=20 > Well... that's possible at the cost of everyone going through Linux to un= derstand why the changes were made. This is not very scalable. >=20 >> I checked a bit and this is not something that was required before (for = example when the cpufeature was introduced). >=20 > If we import the full file, then we will generally don't log all the comm= its. However, for smaller changes, we will always mention the commit backpo= rted. There are several examples on the ML: >=20 > - 0435784cc75d ("xen/arm: smmuv1: Intelligent SMR allocation") > - 9c432b876bf5 ("x86/mwait-idle: add SPR support") >=20 > We also recently introduced a tag "Origin:" to keep track of which commit= was backported. If you want to understand the rationale, you can read this= long thread: >=20 > https://lore.kernel.org/xen-devel/0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@su= se.com/ Do I understand right that it is ok for you if I push one patch mentioning = all the commits done in Linux corresponding to the changes (instead of one = patch per commit) ? >=20 >>>=20 >>>> Complete AA64ISAR2 and AA64MMFR1 with more fields. >>>> While there add a comment for MMFR bitfields as for other registers in >>>> the cpuinfo structure definition. >>>=20 >>> AFAICT, this patch is doing 3 different things that are somewhat relate= d: >>> - Sync cpufeature.c >>> - Update the headers with unused defines >>> - Complete the structure cpufeature.h >>>=20 >>> All those changes seem to be independent, so I think they should be don= e separately. This would help to keep the authorship right (your code vs Li= nux code). >> This and the previous request to split using linux commit will actually = end up in 10 patches or more. >=20 > I think we need to differentiate the two request. The previous request is= about logging which commits you backported. I would be open to have all of= them in one patch so long we account the authors/tags properly. >=20 > For this request, this is mostly about avoid to mix multiple things toget= her. Your commit message describes 3 distinct parts and therefore they shou= ld be split. So 3 patches if you confirm the previous point. I am ok with that >=20 >>>> Signed-off-by: Bertrand Marquis >>>> --- >>>> xen/arch/arm/arm64/cpufeature.c | 18 +++++- >>>> xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- >>>> xen/arch/arm/include/asm/cpufeature.h | 14 ++++- >>>> 3 files changed, 91 insertions(+), 17 deletions(-) >>>> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpuf= eature.c >>>> index 6e5d30dc7b..d9039d37b2 100644 >>>> --- a/xen/arch/arm/arm64/cpufeature.c >>>> +++ b/xen/arch/arm/arm64/cpufeature.c >>>> @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isa= r1[] =3D { >>>> ARM64_FTR_END, >>>> }; >>>> +static const struct arm64_ftr_bits ftr_id_aa64isar2[] =3D { >>>> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2= _CLEARBHB_SHIFT, 4, 0), >>>> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >>>> + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), >>>> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >>> So we are using CONFIG_ARM64_PTR_AUTH. But this is not defined in Kconf= ig. I realize there are more in cpufeature.c (somehow I didn't spot during = preview), but I don't think this is right to define CONFIG_* without an ass= ociated entry in Kconfig. >>>=20 >>> In one hand, I think it would be odd to add an entry in Kconfig because= Xen wouldn't properly work if selected. On the other hand, it is useful if= when we will implement pointer authentification. >>>=20 >>> So maybe we should just add the Kconfig entry with a comment explaning = why they are not selected. Any thoughts? >> This is really right and a very good catch. >> I think it would make sense to introduce those in Kconfig in order to ke= ep the code equivalent to Linux. >> So I would suggest here to add hidden entries like this: >> ARM64_PTR_AUTH >> def_bool n >> depends on ARM64 >> help >> Pointer authentication support. >> This feature is not supported by Xen. >=20 > I am OK with that. Ok, there are currently 4 CONFIG_ not defined so I will add a patch for tho= se in my serie. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 09:51:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:51:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320513.541286 (Exim 4.92) (envelope-from ) id 1nmBfM-0001KZ-K7; Wed, 04 May 2022 09:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320513.541286; Wed, 04 May 2022 09:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBfM-0001KS-H2; Wed, 04 May 2022 09:51:28 +0000 Received: by outflank-mailman (input) for mailman id 320513; Wed, 04 May 2022 09:51:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBfL-0001IV-Pf for xen-devel@lists.xenproject.org; Wed, 04 May 2022 09:51:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3d790d1-cb8f-11ec-a406-831a346695d4; Wed, 04 May 2022 11:51:27 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-2Oz4Z3rXMNy1DgS7CTeIrw-1; Wed, 04 May 2022 11:51:23 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DBBPR04MB8043.eurprd04.prod.outlook.com (2603:10a6:10:1e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 09:51:20 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 09:51:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3d790d1-cb8f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651657886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RIBCT1rrFfVzuyRXT43onKwesiX0CW33peF0U3S9TdE=; b=JcTf5+IdNK9Xv8vW8liz7CxSWg/Q6txCYvaDMDoMbD+kHEeBK/D7O+WZU4HMreqEa96iae u+ZES3LVV48U10bBvn6A8H3v5UtHuWVs64b+auVRwepyJ7CiZGs233+4yxMZWEzlgZ/tqT MCvPyrOVneQoHmjQlKBw7DguaSzb1yk= X-MC-Unique: 2Oz4Z3rXMNy1DgS7CTeIrw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsrawYlaewBsYP4yBOBKoyCJhL+SMYv6oM+Y/gsbskaCY2gyxrLV++OFoJmxwTWkZZtrwCU7A3OgN4+WA8xmCrh2r9uI/GEWSQNNtuxfjGUDyOMrCoxG8dDgHfVgrwZz6xQuf7KYE89DTf5cTbCCCnR7srrAxK+yNULc9eIAa1P/ZYBHSIZmY+t8g5ESVUqL4XqbU3HLkX1nzEw9XnG5820WEC1GzJuRbrTB91uwPBtZJdWxoMufNtsE9CO+DLhXr+eAq4eOS3FYLv5+KhE/islw7BQ0jqYZVJcMqS3fV0A8xBSHdYHdLrWz1y0XgjN4V8y68hBGd52BrjNg+wmURg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RIBCT1rrFfVzuyRXT43onKwesiX0CW33peF0U3S9TdE=; b=mTtSetnNUZk86stYQTLHlgHZuVj5k5/V8hjYmgXMu2pxtyp8S+yGkNYxPyQL/h8F2Ace0h/O3UlS4CBRvChv/LVVOzd7pvrKVuQCjrJZZRPlShL6k1jLhRSJZpkyhfWav3eR9yYIXJk4dqDbKk4+t6o37854Do2Mpj2zTHpvT+cfgewrZ6txYMn1UCYqxNebp4FHnQjqN7a1mgfMvwGjHl6YItWWXOhyEnlK/NiAuD+VmpMsv4Cw9qwgfMcpYuxPjKukbxkT/iQBRvpo3wKFCx713JUFZGyiHE0MIfTR1Q2lC+Ej1tTNubRTOS1QSKMoPLlwa4NENyxyWkHz3UKkeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 May 2022 11:51:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Juergen Gross Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> From: Jan Beulich In-Reply-To: <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6498b1c5-090c-4e8d-8a46-08da2db3a430 X-MS-TrafficTypeDiagnostic: DBBPR04MB8043:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5wlZPykJ5hK/C67K1e3o37RvqG3sQR/uouJKzeCR6DICD1pet22o3YotQvRBH1/HGVnvDUn7nqZSSzpHfJu3qblZ9cSIvh6l8HppT000ysH7XQTaRiHHyQ/cbA5M5BwoVPyV3GCQbZlxv2WL4J6hOD8g5QuVO/6YgXEnqsQysfoU8EksuLjYbrblbzellvLSPe2727UBEt80grRSSTg86xioc1k6taF1DlheZ+Ot3VJQS91xIdo5i+5+/wegjiGa4uKI/Nv3VnRwm/V9MAfiqH6yK7WxffTEQFfgPD/2qBw80Q6rY4XgoNw3ikLZx1PzhR2tbWIv9QMrVLBojpP3FYFVo1AHxIH+/Njd649ZYZinghT9kJcBVZuAYkQv+CgxvrVFjNGt86XIz0KGBl6q1JtOkYfMOVyGEoyET1bbnURmd294JxBeLKvKjWnqvGfsL0Ca7vTjAwVmQym78s5wJkIK5gMdJir0xhAOsa86QeKkGUrqzSrv17lm+AM3cIOOm0p7pyo1rSn1U0WIEjnPdXhNktTkEWunU3vcTla5mhpTi/rfiWaQTeOwh7DS8ofgObSoZPJUgjeSuXhK0D5b/i1ymCgfipGjjow4R7CRGmZ7b2dfm5Mnei3XS6fBXHSxg115/fP6w8oLM/D+H1OzDrnKT2jzdaixETPPqqbUe0ChHBFhAolK6nqkhwXv7kCeN9FYH723yPjPzdqcpkNm3YZ5VTS4bEEdhcEjHYa1Lgc4c+VXJXLREzrMAaJv0GKf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(508600001)(5660300002)(186003)(8936002)(26005)(316002)(6666004)(7416002)(38100700002)(6506007)(86362001)(53546011)(31696002)(66556008)(66476007)(4326008)(6862004)(83380400001)(36756003)(8676002)(2616005)(66946007)(2906002)(54906003)(31686004)(37006003)(6636002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVNQMVhDNENaT2UzY0xSUkI5S2hvM1MxcGhWbmhrNFRGSlZjYnF5UEkrNjFM?= =?utf-8?B?NkJtT0dyR0NyRXFGdjhhWG5KR0pxaVpoQmpTVUE0ZlZnOHZ3RmV4aGdreDBW?= =?utf-8?B?SHhqMDhsNWNjWExyWDJvbVQwalI2dXFTNUQzOG9Ca21lRGQ3SmlWekJ5cFh3?= =?utf-8?B?NEpKU1JkU3dJYjE5eWNOczU4eDF0Rnh4Ly9JcDBScHhVclZuV0lzMDlqRVYx?= =?utf-8?B?RU50Y3FEL29UL2U2dHNGNU5FeTZPM3FtWXdXb1ZxUG51dWcwbEFqQksxWCti?= =?utf-8?B?aVV2eHZMdStmQUp2UitWbGlEbFNmM3hDaWFzOHphdXl4RURVYXd2T1g2bXZE?= =?utf-8?B?QVJDQzcxUnRzdkVtWkF5R1cxY1ZvbnQrRDQyVFlzOGxWMGc1ci9xTnFBbzJP?= =?utf-8?B?MytTOFU2RG9FSVdlbklWYi9va1hRckxSZUMrM292eVMzalZ1NXB5VXhpd0xx?= =?utf-8?B?S0srMUQrTFpFK3Y1dUQ3UExzcHkwYm92aDltMnRLVlhxZG1GRW9mZjY3amVj?= =?utf-8?B?ODVZZ2lyOFd6eHF2TFFmRHdhVVNKRFRXWGRacW9hYWM4bGlNRHFjRzBaTWFm?= =?utf-8?B?Vkk0UEpzaVcrK2M2RksyYjJQaWJIdnFWbVMzQnpuaElPdk1zN1R1dCtzSGVR?= =?utf-8?B?cHFuYWpJaEt5RnBmWmU4TXBCelhROU5MeXlsMk1xUGVUTmcyeHIweGFOcm9I?= =?utf-8?B?TEhwa3VZNXdjZlNEbDgyYjh6SjV3RStXam9vakw0MEN5QTUwc1V4R25ib0dS?= =?utf-8?B?R3BLTk95bHVrODBEcjdKRHAwL3p6dkJUQUpwUVpnTnNuL05tbTZUbG1PUXFv?= =?utf-8?B?MDNhNlVXU2VuWEZDYUVSczZlYnZIVEhTVUlMZVMwV2ZrSnlTT1dKaWFsMWVr?= =?utf-8?B?MUJ2TFozLzI2M2MxdWx3SU5tdlcwVGl3V1B4Wk1iVUhLMUgwYkZ2aTZGdWl0?= =?utf-8?B?LzNtYVV3UE42VVpPM1JuSFJNRzBLMm9ubUNub25sbVRGMTZGTE1OL0tKeXo2?= =?utf-8?B?Mzd0TFlhbmhqZnA3emtOK2lvV0trNklrNnpDa1M5Z3VjSUlFMUxWaHY3OXVV?= =?utf-8?B?b2ozNlgwV0JDa0tqNnFKL1k2SXp0SlBwdDdHWU5FbVlIMTFVQ2k5QlBDOHBJ?= =?utf-8?B?bUpiUkkwUURQUWhBRzJET2o3elRJYnZ5TFRQZkRKbVJCVExEWm9HanRRWUpF?= =?utf-8?B?dXB5U0ZVLzFJbWtqVTNPbkpkUlVlc1NBOXFDVFVZUHdnWVlrc3lJQkF1VzBj?= =?utf-8?B?MHlteTJ4YVArQ1JvcFdzekhPK1RyTEhFbUhXSy82RFdrdS8yVFJ2WGgyOFBv?= =?utf-8?B?SXBZUUYxS2xlS1U2Z2NDbXk1ZG9oTlBIRFJkMDA4eUNKUW1ibVZBcFNJM2tP?= =?utf-8?B?NUVOSmdrOWpIVlZhRXBrS0FTRXAzZlUwaDBqZDR2U3JTL3JLM1ZLUE5LcnZC?= =?utf-8?B?NXEvWUthdW03c0d6VXpSWWtFdlRpZG5jRy96bGJ5bTRSM3hVMm1iTlBvZmdB?= =?utf-8?B?cWk1elNHNkMzN3l1MVZ6cGlNUmY1OStPelZuNzdVY3ZaaGFJZjFuMFVpY0xs?= =?utf-8?B?elhOeFdDdXBobHVRWDRJYWJKSmh0aVZIV3BlUFQ4aS9qeTJTTkhjMzZ6cHpT?= =?utf-8?B?dnQ4bFp0U0VkNjBZbGJqcm43SmNud08xRmtNOXhPUjRrd0czVVJodUlPVU5F?= =?utf-8?B?c2dYRUJHZi9JSGMvK1o1YU1kaE1UWkN3SThqRWdEU2R4a0c2MkQ4T1MwZGtD?= =?utf-8?B?UUY1bllxV3BrSGxIQ3lWSEk1OGtNdXVwTlNkUzRwNUVjd1dMYXFLWk5EZWJv?= =?utf-8?B?Z0JqNjhCeXAxL0s3R1J4ekFJQmljTk9TL2JsazMzR0NXbGtLN1lxRDVBaVJO?= =?utf-8?B?dXUvY3Z4ekxIaXdZb2VsdEVsKzh2Q2lMSHVUU0NxRGU2QVhVMnU3aklRM3NE?= =?utf-8?B?dGxxQVhjNTdIQXBHTk4rTDRTT2RUY1VzSVNUblB2L1EvWGo4VVJmbVp1V1ZY?= =?utf-8?B?QlIvcmNSMDBTS1lsVVB6M3c0dTAzeTM3cWVZNW5zU2xrRVhKc2xGSmxqd1lN?= =?utf-8?B?QStvYmJrUHYybEFta3YxZE8xQ1lYQmJiM2ZSNGUrczMzLzE4QWJmWTlJa3Bq?= =?utf-8?B?cEdVZUZVTHBLYndhcS9XRkhsK1pqbEg1RFg5K2ZJSHVjSkR3UHNhb3N6T2JU?= =?utf-8?B?TVN4R0RLWmpxRUJzL2ZSMFBlbHZDVTdVRGFwNm5wL2dua01vUU1NeXVqUXhG?= =?utf-8?B?eFJYMDRCaXZuQzFPSVNsWUVXeXBMVWlNYmNXbnlJT29jT1dVUlZiY2txS3hN?= =?utf-8?B?TGdXNS96ZkJWemVQTXp4TlFEWmI3MXhYN1c4ZUxlbDBYTEs0bVNtQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6498b1c5-090c-4e8d-8a46-08da2db3a430 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 09:51:20.4324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x18Q+h6dqK4TJ6XqYgwEsWrAjakGvYPTmq6w0o4XhpedTHIzVkbHqjeHKAcS43UmADypyJ6586HslpIWsanLHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8043 On 04.05.2022 11:14, Juergen Gross wrote: > On 04.05.22 10:31, Jan Beulich wrote: >> On 03.05.2022 15:22, Juergen Gross wrote: >>> Some drivers are using pat_enabled() in order to test availability of >>> special caching modes (WC and UC-). This will lead to false negatives >>> in case the system was booted e.g. with the "nopat" variant and the >>> BIOS did setup the PAT MSR supporting the queried mode, or if the >>> system is running as a Xen PV guest. >> >> While, as per my earlier patch, I agree with the Xen PV case, I'm not >> convinced "nopat" is supposed to honor firmware-provided settings. In >> fact in my patch I did arrange for "nopat" to also take effect under >> Xen PV. > > Depends on what the wanted semantics for "nopat" are. > > Right now "nopat" will result in the PAT MSR left unchanged and the > cache mode translation tables be initialized accordingly. > > So does "nopat" mean that the PAT MSR shouldn't be changed, or that > PAGE_BIT_PAT will never be set? According to the documentation for the option ("Disable PAT (page attribute table extension of pagetables) support") I'd say the latter. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 09:54:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 09:54:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320521.541297 (Exim 4.92) (envelope-from ) id 1nmBiO-00025k-6w; Wed, 04 May 2022 09:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320521.541297; Wed, 04 May 2022 09:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBiO-00025d-3k; Wed, 04 May 2022 09:54:36 +0000 Received: by outflank-mailman (input) for mailman id 320521; Wed, 04 May 2022 09:54:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBiM-00025T-LW; Wed, 04 May 2022 09:54:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBiM-0001jq-Hm; Wed, 04 May 2022 09:54:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBiM-00064t-66; Wed, 04 May 2022 09:54:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmBiM-0004XI-5c; Wed, 04 May 2022 09:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gOHxEBkl/zWkSUN6W6eavxdgTVOQSuwM3S712Ng3wX8=; b=PTX0x6nn+sK6sDcnj/hNprQtgK Tq8pv8dZh5X/ISG8AlQF2GUngiLUpp3/O2QlkFtPjDt6L7GtAT2kIAAOhvLNVJGoALtY7cSnCeY45 XjXDsN+OEPovunsaEYVjKAbhTe3mQ1nfOQxfV/oKhEgJTXiQvKwjIej2dQ/PwgIDmYD8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170078: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=41e118fa4f72567f8c147cf58f1912b00c5ba0ef X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 04 May 2022 09:54:34 +0000 flight 170078 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170078/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 41e118fa4f72567f8c147cf58f1912b00c5ba0ef baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 663 days Failing since 151818 2020-07-11 04:18:52 Z 662 days 644 attempts Testing same since 170078 2022-05-04 04:19:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106242 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 10:08:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320533.541314 (Exim 4.92) (envelope-from ) id 1nmBvX-0003ml-Mi; Wed, 04 May 2022 10:08:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320533.541314; Wed, 04 May 2022 10:08:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBvX-0003me-I9; Wed, 04 May 2022 10:08:11 +0000 Received: by outflank-mailman (input) for mailman id 320533; Wed, 04 May 2022 10:08:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmBvV-0003mY-0s for xen-devel@lists.xen.org; Wed, 04 May 2022 10:08:09 +0000 Received: from pi.kojedz.in (pi.kojedz.in [2a01:be00:10:201:0:80:0:1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17be9a5f-cb92-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 12:08:07 +0200 (CEST) Received: from webmail.srv.kojedz.in (BC9CDDBA.catv.pool.telekom.hu [188.156.221.186]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) (Authenticated sender: richard@kojedz.in) by pi.kojedz.in (Postfix) with ESMTPSA id 5733B201E1 for ; Wed, 4 May 2022 12:08:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17be9a5f-cb92-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kojedz.in; s=mail; t=1651658885; bh=RC0yVnL1JQ++H3nQdzUfeAM3LIsYT6SMc7rwkMlA71M=; h=Date:From:To:Subject; b=tZoFiN9FsIB41R2WRuEBFwTsaMLlCaxUZI4aT/evLnKKamTdVYNBN7whq9+TVl5IG ll9/KWsb24NXtF8dUlAidjuj5teajqlRYrA9i5mj3A6Lc6ow5vWN2fsxI/WojduVvv kMgGeulWl/4rb61R3qHWIuudRNnbb5btSQjz6w4M6JcfMgbIOwALqX5A+wHOPDaYS7 rOfxrce80z3QZ9RhKhpyajFC6dLEktFfpVQh4u/+kg0r0k5h5NXbT5sbyQ8PA1TG45 uEdPdzCpVhyGzhfwCMaZpj3oAWZB+oxjShWbDGjKTfXVKFzfpaKn+RYX41J3jhp7IU /M4j9Z7gjPZLi6i2RSzWVw8n38aSXOPXCfHdeps38mS/Cl42ht0IBnWMhSbqCmWj8y kHa9Re59oKngfCvLud/Nm5x10a1I5yhoFcL3nMccyVFvxWUgJH1YMLW2vb7Srdtm3e eYddFmOb6k0+g5xne29C1boxNKzFqvo3GrVQdU7aJkGgvHOqcB7pDOzXcJ3lhGUcpT 8shlpRZ/mBCcoZza5N5gcmGR79ol6cEVsUzkDYQQlOmaB5ILcN8YHj/TpZI2PZG4sv 4FlLU9PZSwW+GzQtq0UVbO1tbcCffn0nz73HogY8NbPekjzJFbsBVlbSCEAdG5BhCl MxSd1jp3IJNve7vbRnGdQyRo= MIME-Version: 1.0 Date: Wed, 04 May 2022 12:08:04 +0200 From: Richard Kojedzinszky To: xen-devel@lists.xen.org Subject: [BUG] libxenstat does parse networks with openvswitch only bridges Message-ID: <926c2f80d7c9513aa0b44600d727f41b@kojedz.in> X-Sender: richard@kojedz.in Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Dear xen developers, When xen is deployed in a way that no linux bridges exists on the host, then https://github.com/xen-project/xen/blob/stable-4.14/tools/xenstat/libxenstat/src/xenstat_linux.c#L313 will get devBridge as empty string, and then conditions on https://github.com/xen-project/xen/blob/stable-4.14/tools/xenstat/libxenstat/src/xenstat_linux.c#L326 will evaluate to true, effectively discarding any parsed results. As a workaround, just creating a fake unused bridge will resolve the issue, howewer libxsenstat itself should take care of such cases. The same is true for later branches as well. Regards, Richard Kojedzinszky From xen-devel-bounces@lists.xenproject.org Wed May 04 10:14:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320546.541324 (Exim 4.92) (envelope-from ) id 1nmC1v-0005GV-Cg; Wed, 04 May 2022 10:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320546.541324; Wed, 04 May 2022 10:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC1v-0005GO-9g; Wed, 04 May 2022 10:14:47 +0000 Received: by outflank-mailman (input) for mailman id 320546; Wed, 04 May 2022 10:14:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC1t-0005GE-9c; Wed, 04 May 2022 10:14:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC1t-0002B4-6l; Wed, 04 May 2022 10:14:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC1s-0006Vs-RY; Wed, 04 May 2022 10:14:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmC1s-0000uF-R9; Wed, 04 May 2022 10:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nJmh/eWWzYClDjrL8TSzyXA2WL/FHNSOBtKfnvq7dAk=; b=rzelmN5kzLOpiU3E+xRVe+zLM0 NWgFpYn3TN7xck8aFS8wmeMRar1340N9+MHrZDMtE5zTlcdC89SpHaAooltcLwVQXRshk6Qiipod1 WF4yjWRlxjlC+f2kK8qwVHcOTVDeDTS/vo3K4cJNdMMHuD2RNb7gwciZTB3m2VPZpsoQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170090: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 10:14:44 +0000 flight 170090 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170090/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 64 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 797 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 10:20:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:20:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320556.541342 (Exim 4.92) (envelope-from ) id 1nmC7h-0006i0-8L; Wed, 04 May 2022 10:20:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320556.541342; Wed, 04 May 2022 10:20:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC7h-0006ht-5B; Wed, 04 May 2022 10:20:45 +0000 Received: by outflank-mailman (input) for mailman id 320556; Wed, 04 May 2022 10:20:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmC7f-0006hn-M6 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 10:20:43 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d89ee895-cb93-11ec-a406-831a346695d4; Wed, 04 May 2022 12:20:41 +0200 (CEST) Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 06:20:38 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB4771.namprd03.prod.outlook.com (2603:10b6:408:99::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 10:20:36 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 10:20:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d89ee895-cb93-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651659641; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/usFWNuzcG3Q3EFBNOYA70Fulok3nugZlFrUxEbvFmM=; b=gC0DZU3sS+dBFV7WELRftaa2KgY9ewf3V3sx2W72+yAVfB5WwV8XAK1p KWAt3hkGWfm96rudKji0yTp2RTDfylO3UGOBpCmEycxr56UvuEIAapDXY gMOak3ckD/G44FmNusTGWN0CAeVWIwpbhah1fgkBuA9r+mPRtn64EOzeT g=; X-IronPort-RemoteIP: 104.47.70.101 X-IronPort-MID: 70948050 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HNEu8aKwHFL6yVLAFE+Rp5QlxSXFcZb7ZxGr2PjKsXjdYENS12cAy mcfC27VaPuKNGT8fdBxao6/8RgBvZ/VxoVmQVdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Y02YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 M8dsLOcRgEjB4OSqP4xVzxjFQRHZ6ITrdcrIVDn2SCS52vvViK0ht9IUwQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHsiFGv2TjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGuL20A9Qr9Sawf6Df3wTJs1pzRMoDHUOLVYcBSoUeAn zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0ZjZLO+gz6QXIwKyL5Q+cXzAAVmQYMIVgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:L2UI+asChOn4jHNSSUhQ+Ptw7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,197,1647316800"; d="scan'208";a="70948050" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hbBdCRg5mOYGqtST/69syEgcgP7QTcB6DAZTKBgewT+LSbsq3FREhz7dMhThcoo38u5U9bZ65vrN5RFqiOQYpILADsrcMmMc6LCRJrdoCAL2kSTJvANAjYzCbxQ0yEpwDwTtZVPQ3ACv9nt8oALnMaX++BtWRRklR3ZlJgsT7fVUuWrQ0ag4nTPSkJ14nqYV7XF2QtLb70ZLbhlvzJ5Z3Rvyl6nEJAfYhc8zkxA9DVVe+WZTNLRQlt1R3q2PfHs6BxLgbcv+wnMrW0DPxXmzkrkl4Iv4AnnvIokWirQwoPkbS0UIuk3KKKH/3dgVjCZyv5vF1FY+K1gFd6yt+3/Mmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8E5FA7lAZfXSsb7r4k/bPtnZb2F5xM7Rg4DOMiVNIW8=; b=Aw3fx4s1dG8KhrF3DY8IzbC/UJOf5xAOlJZjfaa8wbRmb6B0CYsObBxC07K4OcEkUUvYVq02//MDrshTME7Ud/SIM74QceaCQ1kgVKd9Q0gv2Vxi12yT8VdTH9I5Prx/O+K7SKRbsjcx38dX2mbbkNRAPA3aAKyrRR0xTIlN9XqhrYdFsBBC570ik4oLyfPPdP9WZDovaqoH+XcnjZf8r3I4ktnmAwC12fIPe2T5WSJ4e99BgNDVdd/g6bVmTUNfkCoFOsxjsmARB578aBcwN7l2u7HFnMrdVnbyfT/rQc6PAKJfFhtADMeOzvEZ/6gAnATbsmvbo3qdtJQGBL9aDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8E5FA7lAZfXSsb7r4k/bPtnZb2F5xM7Rg4DOMiVNIW8=; b=fqympcUPKdMU+ksQR3vi49qEAIQItagulNn3PAvBc6sCjjXmON2wW/4VlcVB8e1p6xIj4JqHYu7OQrovx7fupT17EPMcPE+EZqHOe75/LLdluG9/wtY3EL/wGeTmWpJfgkBWPg9LRxingTrCqPJXRQbKiB+tYfxX6QZ6JZU23RE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 12:20:30 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 04/21] IOMMU: have iommu_{,un}map() split requests into largest possible chunks Message-ID: References: <227d0bd1-c448-6024-7b98-220271d9bf63@suse.com> <03cf64c4-8ca8-3e13-a4d0-e8da9f309b38@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <03cf64c4-8ca8-3e13-a4d0-e8da9f309b38@suse.com> X-ClientProxiedBy: MRXP264CA0026.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:14::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dc8fd44-4271-44e4-57fa-08da2db7badf X-MS-TrafficTypeDiagnostic: BN8PR03MB4771:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9xhrl8zTbHaVgPcKI+1Jdu6LvZrP3CseSReEDnVaSfFtmVtO45nkc9CD7wV1HZVi6digCbkJFjjIJ/dj7oZOaPIOCGCZ4FuhV80P9bIzd2jecENn/+BnTBJjdfhAre113tFEJoD/FuhaF5uuOz355mOWp5g/+nAbqCURzSTZSvq8mb/c/VBj6qXGVUeLzgdQ05KK+nUivhdSCURip3jT3sAhZbrTLhVuAQAQPHkeW2tMOafRF4XXzT2yc5kc4nZTU5W/lhWHuysHliePpGyzFffWTZnvb9mmFub9pmk2uH4eltX50m+qK8uhGhCMt1mJAEaz9EKY2Jiww0sW99015k5wqRRIg56xa3gCI/CtKO2QuM2+xEia51NKXO3uvtST+sVkiGEj0csqdt+tZMMU5jtcd44cPMjhoYEJLqXlxiYUI7GxACgmBnBsuMJm6gAV3wjdOfqb1VZDCofZjx/ZV45xdJAxzybqtcZEvQsU6CG+V7kC6eXtjj1xEIdGhzLx278wpQE5RVVU7EP6jB3cGJhFucEk0K4DFUJvz9SW9FEFzRBne4gB44E5ecSp/H+dhiuYqq4jPRkskR4CatH0DfU3z1VGqYBh4a6tdlU1t04DxP65U9dpvuNojkvoFj7trwS1xg6wwEkswJxBdu9ghw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6512007)(9686003)(6506007)(83380400001)(38100700002)(26005)(53546011)(82960400001)(316002)(86362001)(5660300002)(186003)(8936002)(85182001)(33716001)(4326008)(6666004)(8676002)(6916009)(66946007)(54906003)(66556008)(2906002)(66476007)(508600001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm11RjFpemx4WC9uZXFwbHcyQ1I4Zk43NXp6S0xlcXZyV0R5RmN3d0doOG9v?= =?utf-8?B?UFI2MTkvVW5SUUJ6ekFVN0ZVcjFuNjlOK09DTThodUJxRC9Hb2p6NUpBbzdU?= =?utf-8?B?eHpZeFQ0TGNGNVRESVI2bE95SmE5K0FEeWJTRG44Y0tIV2NhZDFmVzMxZGdH?= =?utf-8?B?VzVabXlkMFp4MVVITGdhd2cvUjR2RWo0MlBxckx4eWhkWU5rNXZ1UDFYeWla?= =?utf-8?B?VmNMNmdpeml2WmIyZjFkM2lZRTgxNjNWSWxjTGU2TW5VTmNpMmdoUzhUN2lQ?= =?utf-8?B?WnBWVzNFd0U4MGZSS0lSbmRrMmR0RWJsbkE0WmV4ZDQyRlRPZUxLVDQ0NVAz?= =?utf-8?B?dllWTUdyK1hWa1orNDJvbDd3NGVERlYvQzRGdEVLdU0wR2tnT0tKZDRyY1gz?= =?utf-8?B?bFhvQXRJeW4zTTMwUlU5bzdOeXpNVFdiZTByVStCSiszS2p1a2pSNjFIZ0Fr?= =?utf-8?B?bWRMdDc4dzdhaDNsbmptMkVIT05sMHBCUk9vUkJiMWJIdlZhZGZGa2hXejRz?= =?utf-8?B?MEZmZ01IaVVrR1ozY3RrSUdXQzJKQ3FnME5RVTZBRzVtWU05M0tJYitHdDhI?= =?utf-8?B?c1FsazVwY0o5SGRxRUZrVk9vUWlCVHVURVVJSjNWQlhHREY5UzRyV1RueTZH?= =?utf-8?B?T2E3c0tXbHhFYnE0ekpoNk9NQitOU1crRmJ0MUkrNnNiTXFYa25PcVRwUFZ0?= =?utf-8?B?RjFGZWdzdDZ1Z040ZnFvdWxJV0ZMVEJQeU5LK3JyZTBBdHp2RHRCK09obU9P?= =?utf-8?B?KzFtdnBMbnNlYzU1SEYrZ0Z1V1VwbHJqTXJYLzNnVjRVMlZtT0NFbW9MVlhk?= =?utf-8?B?cXBjOUczclZJb21Sd2VQTEZpSjg3NWtYdGlaNFhHWlJRbUg1emI4VGZnbGRN?= =?utf-8?B?VVNubXJkclVGcGpIcnBYY2w5MTVTSWtRRFVVRlpyek4vS2V4am5WTk9KU21Z?= =?utf-8?B?eEZRKzlTdHN0NXpQeDdpY0dwYngvZ0k2TlVEbGpvS3dQdmFOYnFJaVdKTjJq?= =?utf-8?B?T3Y1UHM0aFZodXlvSWxWZGRvR0ErRFNyYTd1QkJkTXllNDhTTFpJN3RpSmkv?= =?utf-8?B?NjVmbkhLaFBRWUN3VDFaLzVibXNsajhFdVhSY2ZOK0hHS0U4QkQrVFNZRnp6?= =?utf-8?B?elJqYlhjc0Rwa01VOWlFazVPMm9LeEFzTmxWSDllamxoVjlOdnVkZFZDa3gz?= =?utf-8?B?aEJ5VjM5RGpzMytYR05NVC9IbXRMaFE5d3hqdW1wZm9VTFFuYnY1cERXM2cz?= =?utf-8?B?NFRkT3NMMWdyZXVWeHNKam5pdFV3MUFRbC96dmNHV24rYndoaFlSRzV3Qkd6?= =?utf-8?B?RHZ1WkU5YkluRGtWbTB0VU5EM1AzUlkwdVZJd2ZUNVlKTmlxZTJyZm5SbmRT?= =?utf-8?B?eDZ6TmRadyt6SHExR3Z6OWZwRGRDSHhTR3pISnlUc3JzcjlxUXFzbXdyVmtQ?= =?utf-8?B?L0JnOWZjSDkrWEE1bUFUcms1UElKTFBVTTIrUVUxSE5BalJhb0w5eEVINDNr?= =?utf-8?B?MUN1cUw3a05Sb1YySjk1Qk9yNlZnc0JpQ1I0SGhoZExwQWUrbkJWbXo0MnFS?= =?utf-8?B?Y1hlNThzS2U0MGdJQnZmZ0xubUNjcnBqR2dQRVlFK1BGL255d3pOY1c1cDU1?= =?utf-8?B?NEhDYWxkWWxKY0hLRlg1c0NiK2UyQnBHYUJnNjBKRDNBV0JlaDVRVjFTcjdK?= =?utf-8?B?OGJwMzVGeXNPN29tRjFtRitIVkkxY3c0Lzg5TGdyY01DU2ZMUWJJNm1NSFpI?= =?utf-8?B?M1FwTkRDTGc0TFpWamVtVFlsQ0lxOVlZK2txR2NjVFVEVjlBdUs5WGxHNGJL?= =?utf-8?B?dWtHQTJMbThrN1VRa3pQTDY1cU4wTG84Tk1sblJGYzF6Wm9jQnI2bXN1RWdt?= =?utf-8?B?TDhHcGsyWkhJeGl1cURXYnpPdEcycExmWXpRM2hRdURFRC9qMWZlbEJSUUN1?= =?utf-8?B?byt4c1dFNGRhd08yYUhKV3dCdXBuZDRlU1R2UUhuZlZJSm9yWU5BMnl0azZi?= =?utf-8?B?NkROS0dWeVdvWjJuRFFDeVFiWSs0ZHRqeXJvN0ZzdzcvWmk2SlNNRnNQQ1Ru?= =?utf-8?B?VkhLemNQeFVRT2I2aGZxdG5hcXUrL1ZDTEE3TlJ1SVNseCt6RGREUXRrdUpY?= =?utf-8?B?MDJWcVRiTkRrZnRxcVlXNTdpOGYyRzhva1hTOVM5V3RudDZ0UnJjRjBZTUt1?= =?utf-8?B?aXh5STlLaGdxR0VHZHU1ZXF2UXcrZ0RDM204N1VXUUI2VmlVa3RFWjk4THZU?= =?utf-8?B?SyttNEZLRkZRTXA2ZWtzN0JXbUpzRlNTWWNHenI5R3RwaDJqVWxmRC8ySEh4?= =?utf-8?B?R3drR0pyZWtBU3lIN0VxRWMzZ0V1UFFpMWxOaWRWbVc2MEExZzNYdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc8fd44-4271-44e4-57fa-08da2db7badf X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 10:20:36.6454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mfd2dXQqPZ+5aXLLg539Wnw/6+KCR6IPg4ulM36nKKl4qkoBchBa9KT7oevorCNfQtMTl7qSv07Ek3CBPTLEaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4771 On Tue, May 03, 2022 at 04:44:45PM +0200, Jan Beulich wrote: > On 03.05.2022 14:37, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:33:32AM +0200, Jan Beulich wrote: > >> --- a/xen/drivers/passthrough/iommu.c > >> +++ b/xen/drivers/passthrough/iommu.c > >> @@ -307,11 +338,10 @@ int iommu_map(struct domain *d, dfn_t df > >> if ( !d->is_shutting_down && printk_ratelimit() ) > >> printk(XENLOG_ERR > >> "d%d: IOMMU mapping dfn %"PRI_dfn" to mfn %"PRI_mfn" failed: %d\n", > >> - d->domain_id, dfn_x(dfn_add(dfn, i)), > >> - mfn_x(mfn_add(mfn, i)), rc); > >> + d->domain_id, dfn_x(dfn), mfn_x(mfn), rc); > > > > Since you are already adjusting the line, I wouldn't mind if you also > > switched to use %pd at once (and in the same adjustment done to > > iommu_unmap). > > I did consider doing so, but decided against since this would lead > to also touching the format string (which right now is unaltered). > > >> > >> /* while statement to satisfy __must_check */ > >> - while ( iommu_unmap(d, dfn, i, flush_flags) ) > >> + while ( iommu_unmap(d, dfn0, i, flush_flags) ) > > > > To match previous behavior you likely need to use i + (1UL << order), > > so pages covered by the map_page call above are also taken care in the > > unmap request? > > I'm afraid I don't follow: Prior behavior was to unmap only what > was mapped on earlier iterations. This continues to be that way. My bad, I was wrong and somehow assumed that the previous behavior would also pass the failed map entry, but that's not the case. > > With that fixed: > > > > Reviewed-by: Roger Pau Monné > > Thanks, but I'll wait with applying this. I withdraw my previous comment, feel free to apply this. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 10:31:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320564.541353 (Exim 4.92) (envelope-from ) id 1nmCHt-0008K2-3u; Wed, 04 May 2022 10:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320564.541353; Wed, 04 May 2022 10:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCHt-0008Jv-0L; Wed, 04 May 2022 10:31:17 +0000 Received: by outflank-mailman (input) for mailman id 320564; Wed, 04 May 2022 10:31:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCHr-0008Jp-Nj for xen-devel@lists.xenproject.org; Wed, 04 May 2022 10:31:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51c7ab4e-cb95-11ec-a406-831a346695d4; Wed, 04 May 2022 12:31:14 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 06:30:59 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MW4PR03MB6508.namprd03.prod.outlook.com (2603:10b6:303:127::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 4 May 2022 10:30:56 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 10:30:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51c7ab4e-cb95-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651660274; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=CaNuGWRVeYOwtVEMeVDPqTIitrmDjgSOdjbtrA+zmKs=; b=HZenvrG61bSqrZXtgJJLO7yPn67jd3NUjvNFs8FWqfSlIO8q0tEo65tS rsMGJ/LoEa6+hM8bG1fhsBgfrHgTrtj57D4R19qFqXPrZFQwpCBrW23+0 cvVD2jZzaosGho51+T4RSxfSK2ypwwPQkBm0FZHD+PkGsU8EdwCBWEblM 4=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 73015646 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ckugqaw/miAEWAtvfbB6t+dBxyrEfRIJ4+MujC+fZmUNrF6WrkUHy jYZW2mOPvyKamCgfo1watmwpBwPvMeAztY1HQZoqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12YThWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NpluZuhTFc7N6/1xsMmaAN7QismA/FKweqSSZS/mZT7I0zuVVLJmq8rJmdmeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTu48wMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKGUB9QzJ+8Lb5UD8kSo20ryxKuDIZ8eOZN9wrGmU9 mHvqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsH0QhmQsHOC+BkGVLJt//YS7QiMzu/e5VafD21dFDpZMoV45IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLTsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:eF6Z3KmyEcHVoTPjBN1AdsmFmaDpDfO+imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb WpaiIriYd1QTOlNfGz X-IronPort-AV: E=Sophos;i="5.91,197,1647316800"; d="scan'208";a="73015646" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lm6NhCfLYLHMJFV4fu2FAyrRiYmkV7YbPAgJyahrQYX+r0AZLf6b6oVdeLL37qJIwpOEWm7mc7oKWAU6dcV2wMs5hcwjm7IX81X9K4O8kcWv4xso8U1dy+jCNI3yWEAcCZWQKoT/AUAP/EPQ2B1vCwWv5RQ9tTtrSzZtlAMt0sEyd0bYXKdWqNm3lnUWY5/+zBiK0Hr7JCvKlKbn7lzDqrddgFp8vPQezS02oWb1uL5sjpjRRU08WC9anznUN/33nxIAvMxsM+Hwyj2AKPvB5DmFHQ5q2MLLEJRN0gpWlQZAFiDJDxN5h1AFhT2Nn1yUMSxPMnIbG+3Pu0Ok6SC4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jp+XssVel/hGWX2ziOq47qLGBWP2xQ/XrCSD0AYTXbU=; b=LvFFlJG1oFMQDOxEIXJ38F4pGao6FZlwrvOZDoNMAAY3xP4G3Vlq8ARouqMNNmGp31zdLsNAfRURtMKgtXoa9UM1X2DDfYZ182bvCBAOs1pfJvp0WuRYcCAPKjBLKl39zDN7fQUAfraIQJP8XBvDN3Pti1GXcZ39ZaEFbvdDJlbaMxDH/ZVFQBQPBQF2184oUxJEbIwTirSuguZbDLIEDIDkTzBLRiRQxxkDWeEUN1Rlhja9IS/VCv8rXVAXIM7zAuj2NatNco1akzYZO3JZTF/0cqPLhrUTK3YPkD7DkceO1dsj5Pu5wCEyXljT+KfbN2mjBjXQT+oUWWcBLtcAjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jp+XssVel/hGWX2ziOq47qLGBWP2xQ/XrCSD0AYTXbU=; b=kVKVMgumJy5lT5e1c96ebvNqG/jhkzVISL/Xi2+G+J+sTS21Xj2vq3K2FvWvh3bty8LP0G+uqGCR/nem8ikcrEP0qAYXwYxtMJZLvTyaqp8GsLz4VM/Q6dVwk0aTIaCigUhhjaYW6gkc67c2M7NlhUKh2ttZcKke6lW+dcY+70o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 12:30:52 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> X-ClientProxiedBy: MR2P264CA0113.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2ba0aee-e82d-4aba-2d7a-08da2db92ca5 X-MS-TrafficTypeDiagnostic: MW4PR03MB6508:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9Jg3NFYWLtYiHD7VqQL8GWgjJPipp/0YgtQO1iceCKQcZ77r5f5f147Fw2j2IsyIlX/X4xzLsgrRw6iiWMjSWVYtV4Lc5DsG8+QTbzvtNA0dfd2Okp3uICYcJP7WRpc+dqAqJVKlk24rhP6wiBGGYp0JBTSSQB9O0q8xq7VjDGv29U1PbjU+TUTEzjiJu+z5ddjtTzHosdp6VU8V50/GZ7oZIfAwvP9KpFNWRaJfiW7vKuHBVyBdLjEmSdxe3oUyvmVnfyauqKOP9MaISp4x5yDiRXRjY8iEqLfM2KJyhTsCLxGbxmtWF4WVidc5g34hl0Xc7Wm+iCvgUxT/6xvSNCsW6HL4qpHN9xRHLyk4Ur+uYjFF7EQGTkyVwDPSVH2QwNKtsHW8iVF6gcsQekniGwpPGS1qU4RQDYRT+TubOIO1LJNbFkdZgqOlHeEA5KxQzjzq8/J4WMAjsCPNEaaCzkOYXvIhRqryvhFimUdWRpOD2l5Ly1ILukKJfcJfJCAjSz5sxXBWb2PjutcDQguFXEqvUtZJsUqjNfhat3mHs0sjqGBMqjft/qOnfHIbchGLcaaPo87j0fzqcu2qvHrmYSdUS4zQlCX/mJcbG+07bF7lNk0lJW2xDFcOVfsQjNbCptX3wRq0oR/l11RcLH0AtVwEQAmRXbFjAhzk/v5U/3vPpxncV3YWW/sZMqh2+sWrsp1f8D2lNKaRfaSI38SaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(66556008)(82960400001)(4326008)(85182001)(8676002)(6666004)(66946007)(66476007)(33716001)(38100700002)(6916009)(54906003)(8936002)(5660300002)(508600001)(86362001)(6486002)(6512007)(9686003)(26005)(53546011)(6506007)(186003)(83380400001)(2906002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0xNV1VHRlRmWEptODhmR1RvcEVvaVFvaFVEYlpGLzNvNXRvZ3NEbG9vVmtj?= =?utf-8?B?VndrNnFXUmxSVjhlaURFck4wR3Viek9HR2EvemlNcTlrdS9rZzBmbW81ZFJt?= =?utf-8?B?UjE0bGNZNEVlRFFtMTVYZ0NwR2ZuZFhLTWtIa3FMSHBWYnNHSXp0eVFEcSti?= =?utf-8?B?RDcxbFh5YWpwZVNXM3Bwa1Y5cndQMDJQcjFGWXhBM1hnNzdJT3hGQnpsMTFE?= =?utf-8?B?WU9uSERhbzd4NFFmaHF1a1pNaWo5WXE1QUtRVXFWcDlaSU52RVRRcXE2bjkr?= =?utf-8?B?d0ZqZjBBRkpuVjBtTHoxdjdaTlgrYVZhdGpVc3BPemp0MFdjZjMxMHVYMHd2?= =?utf-8?B?aG43K21PL3hVZHV1TFVaSDZlb1k0ZGF1RlgrS1BmV1phVFVkVUlxQVhpOHlI?= =?utf-8?B?cEhlZ2kxdS85RUVEWUZSYUNpemFEYmlTeTd2d0c0a2ZLckdySXVrNUZKTHhw?= =?utf-8?B?THZ3NVNmeHlKcEhtOWt5eGxueEFtNjA1eGhqSk5UaUNZYWtEbEY0V0FNUFhN?= =?utf-8?B?K0NEdUcraFpraVBHclNXVUJqaTFWNDBlNTk2bERZeTRjR3RXa0FCTEYyS25l?= =?utf-8?B?SXFHSTZhZVNNcFhtV1pRUTNuTFY1VjlSVWx1N1gvL3A4UEVWWm5vMDQ2SFhs?= =?utf-8?B?VDBFd3Y2cGpwVW84bk1nUWliM1IwK25GTUlodTQ1L2FhOEpvMWZYRDJXUXNT?= =?utf-8?B?bnVqZGpZMThwaS82V2hSVHdQVW9kZ2MyQm4vRFhQUWRkTTVZRUNaMzR3RHQ3?= =?utf-8?B?Sld1ZnFlR25Ta1R2YnFneTdkTThHQXZMU045YytZbmVqWE5oMVViWEdjS0x3?= =?utf-8?B?b1Fra05Xbk5RaUdGR1UxaTMzSklrYlRtU3ZSU1V3TU1xYkdBa1VVNjdXMVNJ?= =?utf-8?B?M0gvcUJMOEdhdGVFZFlSdS8zbTR5MHVvTkpySHd0OFdKVW9xVGdWVml4WDlU?= =?utf-8?B?VE12QTBiZEUxamRrRlpBZmkzaTNMQUp5dUNocExMVElheEVQR3IyN1RLRG5k?= =?utf-8?B?T0Ztc1A4Yzhvc0pmZTNNTW5XZVVpbjRVZmhta21OMUFtZWtoRndYWnFsTUl4?= =?utf-8?B?ei9pSFk2aUhrQWRzeVhMR2FmM0hIcjNLV1RNaG5NYytrWkJlTzhDSlI0YzhG?= =?utf-8?B?WXhBRWx1bW0vMExocDNMVG41cWtwK1lKa3c0WG02Y0JabmR6ZDY5WXIrMllN?= =?utf-8?B?N3IyMmNuNWNPdWR2KzBScFlXSytncjNuWVRFSndBeFQzd3o3dGhHTlNHNExG?= =?utf-8?B?cnpmL0RTcmh6aGtPU3BrYkRKUHN2YkxpRW8vcFRWaHBnVi96Qzh1YkhZT1Ji?= =?utf-8?B?MFk0K29OM2NpYWphT01lTnZpM2xqL1VmaG1nYVFuN3k1c3BCU2F3dkdobDdV?= =?utf-8?B?K1phaTJyMTFuMTlHMUxmUWxuY1EvTCtuaGV6c01YWEVaSld2eWczcGt2Wmpu?= =?utf-8?B?Q0VMelNaUTYxT25XbGtUaXc5ejFwYWkzYXNSR0xVVkRNa1NUbW5kV1lxU2Fo?= =?utf-8?B?NTJSRVZxdVgzdmNkWWU4VkRJL3JCdXh1OFFwaEFxaWo0MXhHQ0V6Vld1bWNp?= =?utf-8?B?NklNU1B0Y2tEUVU2Q293Y3hGREIyOTdBTy96ZWM3ZXoyMTBYNndFN2pmbDlR?= =?utf-8?B?dGdBR29DbzVidWF5OWt0L250VnBCbWVEa0VyOGFuZDd1UFo5SDNvV2FOSFQw?= =?utf-8?B?cjNrRDNFTXdNWWZJUlIrY0NNVTZNVHlyY0x3ZVo0V0NEY0g3Y2ZlMXhpYUI4?= =?utf-8?B?MHRrS3dlUUwzQzVHN05NTDcrcGJNM29DVTdDa0NwcXpyS09XZm1mcy9NK1FK?= =?utf-8?B?M01ubkpWZXpZNnp5UVZsOWhFcERPSE5ZQkxXTlFEcjZKZFRRcFVtVlpFanI2?= =?utf-8?B?UWw4VGRSbmhQamZqWTIrTzhabTJKMmlaVzhzeTlhZTFYYjhCSDZDcml4Zi9k?= =?utf-8?B?YzJ0M1ZZckdXM3BUVHRkZDNQL2h0Q1lhTFpxcEEyR0tIZmxqZDBKaTdWVEhu?= =?utf-8?B?bWF2dnZyc1ZhRW5FWkVGNCsyVTFoS2FRQWE2V2hVY3k3K1cwRTR4Nks2SE5Z?= =?utf-8?B?SFcvb0EwN0doRnBBTVQwVlBGUy9EV2Z6VkN5VEJQeFZjS25Ta2hkZ08xVGxo?= =?utf-8?B?THl3L1BvUkF0TmVLSjVDNUFBaEd2eTlCNHVRM2QrcWVHUGZMV1Jjbk9zdzgr?= =?utf-8?B?TTFQMFI2RDFtUnY5WE9BOFRjZU8zaCs3NE9odHhrbWhDTG91SElXT3lkTmt0?= =?utf-8?B?UVhINVpjNHhMYk11eHEzRVRPNk1MOWNUTERqaUw4NTI0Mmkvd2g2ek9DVTg4?= =?utf-8?B?dHN1OEhrYjZOR0gxbGc4bmFtL3B0THpRWFpEUkd6dW9qODZ3MEVtV2p6S3hj?= =?utf-8?Q?98vLzej8Qn/D0fq0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2ba0aee-e82d-4aba-2d7a-08da2db92ca5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 10:30:56.8818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EMsbRo8V88AwOkJwNuoNI5qPVGxNHgcscDCnKuOMLdvxa8VjUbY2V3S4CvTwLrmhRQ1Nq6+rO1oafncpj+ukLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6508 On Wed, May 04, 2022 at 11:32:51AM +0200, Jan Beulich wrote: > On 03.05.2022 16:50, Jan Beulich wrote: > > On 03.05.2022 15:00, Roger Pau Monné wrote: > >> On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: > >>> While already the case for PVH, there's no reason to treat PV > >>> differently here, though of course the addresses get taken from another > >>> source in this case. Except that, to match CPU side mappings, by default > >>> we permit r/o ones. This then also means we now deal consistently with > >>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. > >>> > >>> Signed-off-by: Jan Beulich > >>> --- > >>> [integrated] v1: Integrate into series. > >>> [standalone] v2: Keep IOMMU mappings in sync with CPU ones. > >>> > >>> --- a/xen/drivers/passthrough/x86/iommu.c > >>> +++ b/xen/drivers/passthrough/x86/iommu.c > >>> @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct > >>> } > >>> } > >>> > >>> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, > >>> - unsigned long pfn, > >>> - unsigned long max_pfn) > >>> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d, > >>> + unsigned long pfn, > >>> + unsigned long max_pfn) > >>> { > >>> mfn_t mfn = _mfn(pfn); > >>> - unsigned int i, type; > >>> + unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable; > >>> > >>> /* > >>> * Set up 1:1 mapping for dom0. Default to include only conventional RAM > >>> @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map > >>> * that fall in unusable ranges for PV Dom0. > >>> */ > >>> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) > >>> - return false; > >>> + return 0; > >>> > >>> switch ( type = page_get_ram_type(mfn) ) > >>> { > >>> case RAM_TYPE_UNUSABLE: > >>> - return false; > >>> + return 0; > >>> > >>> case RAM_TYPE_CONVENTIONAL: > >>> if ( iommu_hwdom_strict ) > >>> - return false; > >>> + return 0; > >>> break; > >>> > >>> default: > >>> if ( type & RAM_TYPE_RESERVED ) > >>> { > >>> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) > >>> - return false; > >>> + perms = 0; > >>> } > >>> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) > >>> - return false; > >>> + else if ( is_hvm_domain(d) ) > >>> + return 0; > >>> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) > >>> + perms = 0; > >>> } > >>> > >>> /* Check that it doesn't overlap with the Interrupt Address Range. */ > >>> if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) > >>> - return false; > >>> + return 0; > >>> /* ... or the IO-APIC */ > >>> - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) > >>> - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >>> - return false; > >>> + if ( has_vioapic(d) ) > >>> + { > >>> + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) > >>> + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >>> + return 0; > >>> + } > >>> + else if ( is_pv_domain(d) ) > >>> + { > >>> + /* > >>> + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o > >>> + * ones there, so it should also have such established for IOMMUs. > >>> + */ > >>> + for ( i = 0; i < nr_ioapics; i++ ) > >>> + if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) > >>> + return rangeset_contains_singleton(mmio_ro_ranges, pfn) > >>> + ? IOMMUF_readable : 0; > >> > >> If we really are after consistency with CPU side mappings, we should > >> likely take the whole contents of mmio_ro_ranges and d->iomem_caps > >> into account, not just the pages belonging to the IO-APIC? > >> > >> There could also be HPET pages mapped as RO for PV. > > > > Hmm. This would be a yet bigger functional change, but indeed would further > > improve consistency. But shouldn't we then also establish r/w mappings for > > stuff in ->iomem_caps but not in mmio_ro_ranges? This would feel like going > > too far ... > > FTAOD I didn't mean to say that I think such mappings shouldn't be there; > I have been of the opinion that e.g. I/O directly to/from the linear > frame buffer of a graphics device should in principle be permitted. But > which specific mappings to put in place can imo not be derived from > ->iomem_caps, as we merely subtract certain ranges after initially having > set all bits in it. Besides ranges not mapping any MMIO, even something > like the PCI ECAM ranges (parts of which we may also force to r/o, and > which we would hence cover here if I followed your suggestion) are > questionable in this regard. Right, ->iomem_caps is indeed too wide for our purpose. What about using something like: else if ( is_pv_domain(d) ) { if ( !iomem_access_permitted(d, pfn, pfn) ) return 0; if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) return IOMMUF_readable; } That would get us a bit closer to allowed CPU side mappings, and we don't need to special case IO-APIC or HPET addresses as those are already added to ->iomem_caps or mmio_ro_ranges respectively by dom0_setup_permissions(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 10:50:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:50:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320573.541370 (Exim 4.92) (envelope-from ) id 1nmCaL-0002Mo-Sc; Wed, 04 May 2022 10:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320573.541370; Wed, 04 May 2022 10:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCaL-0002Mh-OU; Wed, 04 May 2022 10:50:21 +0000 Received: by outflank-mailman (input) for mailman id 320573; Wed, 04 May 2022 10:50:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCaK-0002MZ-FK for xen-devel@lists.xenproject.org; Wed, 04 May 2022 10:50:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0d::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc7217f4-cb97-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 12:50:18 +0200 (CEST) Received: from DB6PR07CA0183.eurprd07.prod.outlook.com (2603:10a6:6:42::13) by VI1PR08MB3008.eurprd08.prod.outlook.com (2603:10a6:803:43::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 10:50:15 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::7e) by DB6PR07CA0183.outlook.office365.com (2603:10a6:6:42::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6 via Frontend Transport; Wed, 4 May 2022 10:50:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 10:50:14 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Wed, 04 May 2022 10:50:13 +0000 Received: from a82bc442a9a9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43B0544E-01A5-469D-8C8A-F816AD5029A8.1; Wed, 04 May 2022 10:50:02 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a82bc442a9a9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 10:50:02 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) by DB8PR08MB5435.eurprd08.prod.outlook.com (2603:10a6:10:113::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 4 May 2022 10:49:59 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938]) by AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938%11]) with mapi id 15.20.5206.024; Wed, 4 May 2022 10:49:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc7217f4-cb97-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PfmHPMuklw+D5EA+VpEBhXSvyZQrh1T9LsOSRnwOXLEUuuWTGQVXzf6kyshspw7zZmvthMBxLEmD6V03CTslSoR3GOc5XMjt1/aVcjg7mcATdcmDtwBmZL6M4m5gbuScFx0t1LggbjHAcRf0rIj8XxXM9n6bnMQkkaPifQ6EupxbhE1Wx4cVacwudrzm5GecR/rAcLkDeFFkg7X96hAMbG35gPEq8owMhcibwLeSCpzHg0EwI+5+ro7StPNzDGEwDAWXT+wsfrGRXSwV4qLhMp4s8Wwpb49KiZVjQecxjm/QE3CP+lsyXvBJww1pM1aM0iy7UzN9UD5uXcatnjh7Pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VUrGaD67QOs6TcY79KbZjv/R7D4tuZmtwnwyrSQu7xk=; b=IbEaDvPny4NXClL4DyNQT7S4oMtXE+DJNmL+Cmxtpp4aRB6Cu9sfHeoJ/rB+VMZI0RcQIpK/Nklokx/CcL1W75LPnWkDGhN06MZyvIYKeqCKSwme79Drt/XXcOMom6WQgsCKNYgoe3292jHlUEjx9q+4R6/uRlhufcCP+wWbSitaNFrdsHxzc30dlM64EAnp1L/6A0EyJbnc035EsuFZxnMwq4mCYO/7UTEC1mM0O9FO5qOxGIgezL09zsSZSKn3D1TKhUQI2QYi08igU8cD0a8mDU82sNa1+LQ7QgJhk8I7m9fawvgWhmiRvQ3yRIPjhkSUkzlImEJD9A+1EH+X6A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VUrGaD67QOs6TcY79KbZjv/R7D4tuZmtwnwyrSQu7xk=; b=2rGtfmSafHtBH8WUVfTBqc5/wqlDtbOW+bCi+vyWg00Jgowbf694G+fS0pz59C5p+4eZ043v72qyZjreiBmX2rw6Zre7buqz3iPC1wKO8ENQx5Q9dbtoj7BvceuowvIbFXdPd0bFY6j/VljSsRAm51FhGJIjHkcHfrGekLz68ww= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 48f6a743b9987708 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VxST/VwUEWvCKoooN+NTg92d9UYnCFmf4/89erFLXgukLPYl85AgIVH04CouQQF26M6wQXpbnUNZKidPwNqwAl3z1anhmnGWDLp0ujijGwMmES44ZvyWzI2VICEaccRpMrf1w7pmHcXoemWG53fid33SJdFzWJUf4XiGxssC2YcmDoTvXNVCiLT/B1b3N2/+EbLPKoCVndO+pjV17hwnDQyCq/K4YsWhViIl1P2pYF0s3hC6FSwqou7KsNeK9nR7CRi4spXnHTUHLQbiNDBT5Z+p3+vWhmQWtqJ1lCCHzTEZqYfI6st3mOuPCuznhtVN1I7U2Zhb9bjPpUuTjIfg1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VUrGaD67QOs6TcY79KbZjv/R7D4tuZmtwnwyrSQu7xk=; b=MkAIgrJ6s8W+LpLEqbrwVLzRNhTfWTc0399NjCcHVb0cUpUc7TmXpkeqVNmGdJe9c+uFt4yayY9UsXxvxqT9HRlBHmbQ/HFfUh9fD8Gcanzi0WX/3YUk+ej8Q0HKTwK79tqDlWMUYYVOcnjVqcC+i/vhWTVoAhiq78GLry3YfXYTXrZA/PJboB7Vl7v4uOus2/Wyom5UDg4uBhy+YBCYAXj7fVhwPuK8pCXVcBp77YzZycSloAIMgeZj34Ql/UHQpv6xaDInrIKnnn46VBdd+CPUrRbgaDJA1GWOL3M/i6ZKjHkmXDO9kaB9Pk5nc4OMJYLBHSlxA5ZiW8KJFfstqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VUrGaD67QOs6TcY79KbZjv/R7D4tuZmtwnwyrSQu7xk=; b=2rGtfmSafHtBH8WUVfTBqc5/wqlDtbOW+bCi+vyWg00Jgowbf694G+fS0pz59C5p+4eZ043v72qyZjreiBmX2rw6Zre7buqz3iPC1wKO8ENQx5Q9dbtoj7BvceuowvIbFXdPd0bFY6j/VljSsRAm51FhGJIjHkcHfrGekLz68ww= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Topic: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Index: AQHYWlHsf41jIOfeQ0mX6M++noloAq0EDIIAgAEMUACAADIdgIAAFDQAgAf3yoCAAT3VgA== Date: Wed, 4 May 2022 10:49:59 +0000 Message-ID: <3ABD11B7-08F2-495B-A008-B00E2F671D85@arm.com> References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> <73BA5CB5-8B01-41BF-B967-15886554C230@arm.com> <92ECC32D-DA6E-4DC8-B0E2-8EC758471C4B@arm.com> <76b13da0-9ec4-1cc1-547a-129f89956ad5@xen.org> In-Reply-To: <76b13da0-9ec4-1cc1-547a-129f89956ad5@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1c0a19c0-a187-4f87-feff-08da2dbbde7d x-ms-traffictypediagnostic: DB8PR08MB5435:EE_|DBAEUR03FT013:EE_|VI1PR08MB3008:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YLJRpenSkYMunDi/ROdnkWVdJkucXgIxb6UFFnFH/WXlCDXbsY9FiVsICGVvGzEFwHrqWEgpKRgJ287RDEvAAHyvscG86gt4YCwVqhyuT5Dzj4pKwp6/2OxY3Bg2L11DRAOiRmzK+VucEtAY96m0SaicTpya/j2YZzUPjgedagfQMX/NzlaLhSsBVRnvH7sbsqLk1N/u7tIL1vM7Xebkd3cYcaSX6iPrkl6zb2hkHRSkm8oqeHFjhXbakPqBrqz39k75UzLqx1TC4Tkl4+3qyJoJb0+QHHnXpBM759gs8VXoVUM2Tu165o+FyNnTefYwTu7NNp73ekouGwDGjsv6tO2iLKAT0nVYLj5lwk1z+38cKCVmQxpjg2me7KCjyuPSVJ4DaXwhCVq5EGkhmwbyuzXb0n81fI3qaXbIs/4JMwJiE/+P4yreD9bvPEtU3+Nd4whr3u+TRDxmmfod36XuVZqRQa1Ku2U6MsxthbAhkofor/JvU77G6FnCDWd690jv22eBOWLjIbLjKfnvA7Jp1HxQpBpInxDrHOLTmQloQ/eAmtbJY0IGG+PvonvpLWXk62c4Hjqz4XFioyQ5izHtTbOV2dISZZdZR6Mz1fIr2Zu1C0qr6k/5Sf9x3T6Ycv6zHJRR/awWBSw8KekqwPAGsd0JeiGsowGfJeh0wudwHrb9QzLidSnZZudZoLEsYe483VcgezMQyfsOEXNTEfPggsIXqNCliQg+Utq1W4a55v9Zs95yU/iLoVYGa+kqzQZlxAdD7sSjRqrXdEmI9Fkja9v0OvDVDfuosksK19cu06sLpqEM1WX/CojbaHmI6fvR X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(4326008)(86362001)(6486002)(8676002)(71200400001)(966005)(91956017)(508600001)(66556008)(66446008)(64756008)(38070700005)(66946007)(66476007)(316002)(6916009)(186003)(54906003)(83380400001)(2616005)(122000001)(6506007)(26005)(53546011)(6512007)(36756003)(8936002)(33656002)(2906002)(5660300002)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5435 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a45df6a8-1690-4567-a929-08da2dbbd5d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OtKju9h0F7sFjRg0paYHrToYeiKxsilTGofHa9dpLEZj+AIg9DYFheuswo6qOemQBeNN+U2HOBd++VHO3xzaVFHzVFPGfStoY2KgvKA8tzIMEu00pGK57uOm71rZlT+zUGnMmrBFBY3x+5xj8yjbbRcbylMCN4cpezT4MJwoRzDWlbXhlZOROElZu1+NW6MnBmhnd+oxMLVmJ7FJssGgtIkbFU+QONsdjNXdIhm0ZtZYiX0ibGuGh4mrj0eVemcX4jpQ0anZ6eFnQU2K2S5Eqblbs914ifyv+tIQckWw1AX/Ud9cQSmHHVW2D4PPBH+uidtKodEmo9Rn2zXbAGP8Lh+n3a4h2/IUTOVbDTDVAwsnz3DB4/R5E4eO3PVDNxmjilQe725In4/fwMxwMx1bi2pfRnu2GnRSVbesZFxEQNDJaiWOFJDlE8DK2CUdlzfP7SWs+Y0wgDGJPWLr8ZcI1tCdi0mBaGnY2ryB5ER8syYv9vQUeMYCu1DJFU+qC/xKOEDpS20CzIdjbzUQZgKy9Vwdq31ihnxAHM7SOlkJgSd4Uo0uF8mb+giD2BqENWASR5Y3/cJSpBDp0YBwu/eLTM+njbDmaXYch20w0VKVMv56kM+NALqfcEALHsKiAejsVgEmrvjUjZ1OkoyIojCyqso53VSqAl/L/MZl6y8uhOADoegBHSwY3CR/OpidC22oSgDIDdG7+p64RTQTyO9aMitVJ8L7dDYpBZ1lScjKiAls1wOQwM9WOmdUzqvpYg4UpfJtNjln0bo+7DfhI6UHOg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(86362001)(2906002)(6506007)(53546011)(6512007)(26005)(5660300002)(6486002)(8936002)(966005)(8676002)(82310400005)(508600001)(36756003)(356005)(83380400001)(6862004)(70206006)(107886003)(81166007)(70586007)(4326008)(40460700003)(336012)(47076005)(33656002)(186003)(316002)(54906003)(36860700001)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 10:50:14.1123 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0a19c0-a187-4f87-feff-08da2dbbde7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3008 Hi Julien, > On 3 May 2022, at 4:52 pm, Julien Grall wrote: >=20 >=20 >=20 > On 28/04/2022 15:11, Rahul Singh wrote: >> Hi Julien, >=20 > Hi Rahul, >=20 >>> On 28 Apr 2022, at 1:59 pm, Julien Grall wrote: >>>=20 >>>=20 >>>=20 >>> On 28/04/2022 11:00, Rahul Singh wrote: >>>> Hi Julien, >>>>> On 27 Apr 2022, at 6:59 pm, Julien Grall wrote: >>>>>=20 >>>>> Hi Rahul, >>>>>=20 >>>>> On 27/04/2022 17:14, Rahul Singh wrote: >>>>>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs a= re >>>>>=20 >>>>> Looking at the spec (ARM IHI 0069H), I can't find a command error nam= ed MAPC_LPI_OFF. Is it something specific to your HW? >>>> I found the issue on HW that implements GIC-600 and GIC-600 TRM specif= y the MAPC_LPI_OFF its command error. >>>> https://developer.arm.com/documentation/100336/0106/introduction/about= -the-gic-600 >>>> {Table 3-15 ITS command and translation errors, records 13+ page 3-89} >>>=20 >>> Please provide a pointer to the spec in the commit message. This would = help the reviewer to know where MAPC_LPI_OFF come from. >> Ok. >>>=20 >>>>>=20 >>>>>> not enabled before mapping the collection table using MAPC command. >>>>>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collec= tion >>>>>> table. >>>>>> Signed-off-by: Rahul Singh >>>>>> --- >>>>>> xen/arch/arm/gic-v3.c | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>>>>> index 3c472ed768..8fb0014b16 100644 >>>>>> --- a/xen/arch/arm/gic-v3.c >>>>>> +++ b/xen/arch/arm/gic-v3.c >>>>>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) >>>>>> /* If the host has any ITSes, enable LPIs now. */ >>>>>> if ( gicv3_its_host_has_its() ) >>>>>> { >>>>>> + if ( !gicv3_enable_lpis() ) >>>>>> + return -EBUSY; >>>>>> ret =3D gicv3_its_setup_collection(smp_processor_id()); >>>>>> if ( ret ) >>>>>> return ret; >>>>>> - if ( !gicv3_enable_lpis() ) >>>>>> - return -EBUSY; >>>>>=20 >>>>> AFAICT, Linux is using the same ordering as your are proposing. It se= ems to have been introduced from the start, so it is not clear why we chose= this approach. >>>> Yes I also confirmed that before sending the patch for review. I think= this is okay if we enable the enable LPIs before mapping the collection ta= ble. >>>=20 >>> In general, I expect change touching the GICv3 code based on the specif= ication rather than "we think this is okay". This reduce the risk to make m= odification that could break other platforms (we can't possibly test all of= them). >>>=20 >>> Reading through the spec, the definition of GICR.EnableLPIs contains th= e following: >>>=20 >>> " >>> 0b0 LPI support is disabled. Any doorbell interrupt generated as a resu= lt of a write to a virtual LPI register must be discarded, and any ITS tran= slation requests or commands involving LPIs in this Redistributor are ignor= ed. >>>=20 >>> 0b1 LPI support is enabled. >>> " >>>=20 >>> So your change is correct. But the commit message needs to be updated w= ith more details on which GIC HW the issue was seen and why your proposal i= s correct (i.e. quoting the spec). >> Ok. I will modify the commit msg as below.Please let me know if it is ok= ay. >> arm/its: enable LPIs before mapping the collection table >> When Xen boots on the platform that implements the GIC 600, ITS >> MAPC_LPI_OFF uncorrectable command error issue is oberved. >=20 > s/oberved/observed/ Ack.=20 >=20 >> As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can >> be reported if the ITS MAPC command has tried to map a collection to a c= ore >> that does not have LPIs enabled. >=20 > Please add a quote from the GICv3 specification (see my previous reply). Ok. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed May 04 10:51:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 10:51:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320579.541381 (Exim 4.92) (envelope-from ) id 1nmCbW-000308-Ad; Wed, 04 May 2022 10:51:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320579.541381; Wed, 04 May 2022 10:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCbW-000301-7b; Wed, 04 May 2022 10:51:34 +0000 Received: by outflank-mailman (input) for mailman id 320579; Wed, 04 May 2022 10:51:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCbU-0002ht-Hu for xen-devel@lists.xenproject.org; Wed, 04 May 2022 10:51:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27f8e254-cb98-11ec-a406-831a346695d4; Wed, 04 May 2022 12:51:31 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-tcyspo3fOrWWFoVCY0aQVg-1; Wed, 04 May 2022 12:51:28 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PAXPR04MB8239.eurprd04.prod.outlook.com (2603:10a6:102:1c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 10:51:26 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 10:51:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27f8e254-cb98-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651661490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IHA+R1CLoSXosdkYvUywhpt8DKBH2xWsyr3b6c/1xvU=; b=NSzYc8B6/sA8KqReKPdku9lrGHPcXqmcrak9l/9UAluEip/sO7thWkMLXhMuqMMu3Q7Dig jBxR/JoahSzC4QFHfeCfu2K+MNyWfGqta9/S1c0OuMRt4+dshEL1srvsUmO3AONW7D6dS1 TVqSRtb8xZQEkhVWeKubD+VF/BGCAyM= X-MC-Unique: tcyspo3fOrWWFoVCY0aQVg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgoGVzG0berEc0c6nbj39pTHQ5CIbjTg88dQKp2mAEP1Q32nxDMQCieHx136OoqakbnL0AYtsu9WBSvCol8d48XAL1uIUSUcCkOcWmATkFyCc9araG1452gWDC8KfpNB5KvsR5wLEWWEyLUplMRRmfkuM/5XCHUnLo0CcsLZf8QAQD6Xp7noTkyWNKuU/+adHeXi5D14YTZKiiqkmGrjDivhFlQd74IG64QQld7m+0iD//IkLcDnNuYjIJM3PemovbBhco4ne6l4oIsZeVBgxiNsumnrB8S+5D0OtDzhDeJre7lcIOfae3gjFUA+Md0EDtrI29aBcmlrtC35tFIFFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qswr8SjRBWKZEizsfbh4whqdiXqN2ADspLgyl7Io1AY=; b=hi1t+AmmLtjkjJfaa6n+bAKJL0W/VwYC/MqRJMQW4ORCyuv3xMQDsFKdrvMmOSd4UjmkYIi7t8YWu7/Y6KIMW0oO0s9O5pWX4YnmHm4Wl6eo2Zxg0LzYthxmKoG/v9yty7M+90tfT2jJm9bkYzX3F8WNMXm8EAAi5WdT9ZZ22i1DvOFD0XEZ4nM15gYXfruV8podRh36tQf8c43DdHzrqlxeCdfijQLss4aMcL6tVfdOzrnHLHDAhS48tcQnHBAXE3g7Vm2JNJuUM00rVX3YaD/N+DxMO6Mkr7NqiMoYYRfs8djRTrA0doPtWjr45jKAiHjUAaoPL3v+FL+CxftVVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 May 2022 12:51:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR0502CA0046.eurprd05.prod.outlook.com (2603:10a6:20b:56::23) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b07b2e49-2c92-4ecb-d6da-08da2dbc0993 X-MS-TrafficTypeDiagnostic: PAXPR04MB8239:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YA6P+FeczFeFTRdWYrH5C+HqDsByWVLDDixHn4aXI587nLgoBWVg7o2Nys0d2R8WCYoc4Ld68wTFecR/PSj13gZiBtY5bRgREf2aU/Asea9S5jhNkew34kFgYDnbDdzq3Rj793Exck6n4MqemdwNy/9QNMcMmFDueip45Kr/Mm0ghouICARads/HubqPjNplwVws/N4ZlpJTFhLA/1sCpW+Kx7C8bEucJAzQo+cMs3v3+KwVScOLFU+WidZ6Cz/78KpKfD+4T+GvhLf8YOtUf3/+uQ8/tvTxXCb6KtjxYfMkgFGfZLLxqpPNrOoHrmpzcJecJS56VZT7CmZHUht3cFfRW5rnpJnVihdmqZ9XBY+4ghJkkAQUL5yix6qCW8KPSNCsLQiCyZeGzvERDyiDT3R5LNUNyrK4YX7YOejsP2HJVgDdZ3AXow9w/AI/32y97D0/LD1FpcUvbzdb8oZozTZ3QBdeqb/SqZYpTEw2EccuMvJbf4nE5+Ui7wFzp9kETI+JIrZ7Y71CFdq/ucK6MH3c5mWKrXTNc9NpKkqQ1l4pUucBcmsad8WttYp9xx/AzzWl3Hb3z2z81YwosQgpK3fEmaTxCPuklsJW7lGFQncNZvEksNH0U5eI2t56YhmG6chxfO3q9syPEkr5EAdc/V/rmAsMCTd7FiMbEygZDF5468rnD4gwsqIsxXgVmow54yuxRSR+V/H5riyO/8xq0+/SDGEH6hY3naSilj2NRuw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(2906002)(508600001)(316002)(31696002)(86362001)(38100700002)(66556008)(4326008)(66476007)(8676002)(66946007)(8936002)(6916009)(5660300002)(54906003)(186003)(36756003)(6512007)(26005)(2616005)(53546011)(6506007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D+hHbHOYAxIBZKcvz+qcHNoaFqBBpaY+5+Wy3KbRdAqX9qwyQVHi/keElhWk?= =?us-ascii?Q?Xtn2cCVWn2COcSu770MK48K5OGg2ZppK+g+ip3dC+0Hd6uXpUYYN4702jvy7?= =?us-ascii?Q?E8vytZzJMsjEnj9GodBwcRr4EdXCd9Xwk0U1ZxiBSIkYh5OBC4hDAKQAbEad?= =?us-ascii?Q?LkiDTZktETouZZEH3EzeE69/Y2Qp6i1m+dM2Psp6H02GoKugZJxQz5i8zCvO?= =?us-ascii?Q?F7TXhI3W5MZlsHmmPOxXl+clLLyig9+200jZHggwhL5AySPRBIxgO1cYivi/?= =?us-ascii?Q?eXY81EFHyVS8iGP0v8VYCYZv2FBzvTWQVeiySaMyKRvBn+VSvMxhqWNO/EeG?= =?us-ascii?Q?AmoYvT4jMPGTVpFylkTEWVKh57LLA1JSAGnXd1yBQFUtTIaVzyNjstJassvG?= =?us-ascii?Q?VJ7h/vcywDNRy2Znaa+LFWsUcG6gszf3PotQGh+Biw4vkTuB7Rjw9jKOVMWN?= =?us-ascii?Q?gBQl52Z4qxTIvps5AScMYNFaafU5sv+s0rAXsguZu/XUpQhs1HTZjjT6mBjO?= =?us-ascii?Q?9j77Zu078V/Onn6b6XBTVaVbgDsEF7WXS/R6iRuOPXv2LdThZ2cBhcLNYc23?= =?us-ascii?Q?EB3YuECTvzlPRmp1tJgx5CRaeYL4Nk0+btI5ym/NPRTnCXQGCYRsMXE9dsql?= =?us-ascii?Q?a4BMjEBtsVcZiLbopfV+fSfWxSns4zlhdmtodzZGNWVpL9mPWcH8CwF0d26N?= =?us-ascii?Q?d1WLiSrB73POxQAHwuRuHoygHjX9VHtRB8/7Icx8p4k9S3f4UdRQ0R6+eIZg?= =?us-ascii?Q?ogkRhZy7Wz1w+Y4HujbATUVxO0/K9DZfjj08CjKM7zBRC/VEjX5YGuIWWbW7?= =?us-ascii?Q?wR4hOVszAD2td++tgR24gvhZL9udZGWEwIKP2rj/2Jq0OYc2utcDXmvyOvFW?= =?us-ascii?Q?2x46yCaZoTz7sLUZrT58J9BfP1jlMNyqMFh6BWhRYWHhXziYRrVn2SopWVRT?= =?us-ascii?Q?ZvhOl1Yq3qobG6zeQTFbIzyHjqOIIG/XYjX6/UZFS+l1tdSKouAG16DI0QwM?= =?us-ascii?Q?R4EHsGc2OPv4Bn9l4i7SUHTP9YZkXBv/jeQjgo9XYgm4fJGCuM4p+FodORZ9?= =?us-ascii?Q?MUWmXwUa852xwZCPJJNxKdFUFcq7l7EPsv6G+RUfRD6hhT2PHuOeoUOvBTvt?= =?us-ascii?Q?VDImAIddQ59rcJVrhmSKQ7N9u2gfXmF3yaChmncuR1uqmlkh94Ufervr27td?= =?us-ascii?Q?Tbde++dzIW2NBtiq9kOMkoyLo19f1USGYvtpxKlJkI5skHA0YLdteCAb/ejL?= =?us-ascii?Q?vbwtDeB5EutRPgCjjW1C4OXPKS3XQ/kCGG0oHFDozWfxdAshBcuJ+XsUTXE5?= =?us-ascii?Q?L0KoEtN8KpWOIclvW3VA/FivHOGjAah/K/81LzPCUhgDu3lleBk22YBatE+k?= =?us-ascii?Q?kKNPHl3Zhe7PQeF/bJ1Hf7DO9sVuKZYkGnN1CXQPKY6/AOzips4aWOcMGgEE?= =?us-ascii?Q?P6AoWTh3PRDCsvTujoH49C4icHtYmTkOzGEmih5NDbgepUbDA1/bXbAWyvBy?= =?us-ascii?Q?lXgCvc/w+XeY2YNJ53zwoe4wN+IryQifBU8z2P4w2YGlEM9RnaGkUG/I1+00?= =?us-ascii?Q?pGZ3w0pmbwElVlC3A41YJmlx0EF6xS9jnNVpG4TLmvsAraVWwrVfGnLtRIh0?= =?us-ascii?Q?Ef5QgMALe90boS/k9b6Q4AvJwpZGa9n8rEaNeCsS6LYQq2J3v3M5Jgh1ovB6?= =?us-ascii?Q?yesd3YwGZ+lGpdu/jj3K7cWKr5Tnci8URODkakdx+CMCgwNmOfckV0iX+yMu?= =?us-ascii?Q?nWPzQxY5xQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b07b2e49-2c92-4ecb-d6da-08da2dbc0993 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 10:51:26.5537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tCahlXHNWWGVoXTCy9yI+1b8vi6rQSGMFxpDqOwEeyTqKb4D4IqB7153osyi7dEnykrV1VDe8nixfK+m26ppaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8239 On 04.05.2022 12:30, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 11:32:51AM +0200, Jan Beulich wrote: >> On 03.05.2022 16:50, Jan Beulich wrote: >>> On 03.05.2022 15:00, Roger Pau Monn=C3=A9 wrote: >>>> On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: >>>>> While already the case for PVH, there's no reason to treat PV >>>>> differently here, though of course the addresses get taken from anoth= er >>>>> source in this case. Except that, to match CPU side mappings, by defa= ult >>>>> we permit r/o ones. This then also means we now deal consistently wit= h >>>>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >>>>> >>>>> Signed-off-by: Jan Beulich >>>>> --- >>>>> [integrated] v1: Integrate into series. >>>>> [standalone] v2: Keep IOMMU mappings in sync with CPU ones. >>>>> >>>>> --- a/xen/drivers/passthrough/x86/iommu.c >>>>> +++ b/xen/drivers/passthrough/x86/iommu.c >>>>> @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct >>>>> } >>>>> } >>>>> =20 >>>>> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, >>>>> - unsigned long pfn, >>>>> - unsigned long max_pfn) >>>>> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain= *d, >>>>> + unsigned long pfn, >>>>> + unsigned long max_p= fn) >>>>> { >>>>> mfn_t mfn =3D _mfn(pfn); >>>>> - unsigned int i, type; >>>>> + unsigned int i, type, perms =3D IOMMUF_readable | IOMMUF_writabl= e; >>>>> =20 >>>>> /* >>>>> * Set up 1:1 mapping for dom0. Default to include only conventi= onal RAM >>>>> @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map >>>>> * that fall in unusable ranges for PV Dom0. >>>>> */ >>>>> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) >>>>> - return false; >>>>> + return 0; >>>>> =20 >>>>> switch ( type =3D page_get_ram_type(mfn) ) >>>>> { >>>>> case RAM_TYPE_UNUSABLE: >>>>> - return false; >>>>> + return 0; >>>>> =20 >>>>> case RAM_TYPE_CONVENTIONAL: >>>>> if ( iommu_hwdom_strict ) >>>>> - return false; >>>>> + return 0; >>>>> break; >>>>> =20 >>>>> default: >>>>> if ( type & RAM_TYPE_RESERVED ) >>>>> { >>>>> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) >>>>> - return false; >>>>> + perms =3D 0; >>>>> } >>>>> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn = > max_pfn ) >>>>> - return false; >>>>> + else if ( is_hvm_domain(d) ) >>>>> + return 0; >>>>> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) >>>>> + perms =3D 0; >>>>> } >>>>> =20 >>>>> /* Check that it doesn't overlap with the Interrupt Address Rang= e. */ >>>>> if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff ) >>>>> - return false; >>>>> + return 0; >>>>> /* ... or the IO-APIC */ >>>>> - for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i+= + ) >>>>> - if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address)= ) >>>>> - return false; >>>>> + if ( has_vioapic(d) ) >>>>> + { >>>>> + for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ ) >>>>> + if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_addr= ess) ) >>>>> + return 0; >>>>> + } >>>>> + else if ( is_pv_domain(d) ) >>>>> + { >>>>> + /* >>>>> + * Be consistent with CPU mappings: Dom0 is permitted to est= ablish r/o >>>>> + * ones there, so it should also have such established for I= OMMUs. >>>>> + */ >>>>> + for ( i =3D 0; i < nr_ioapics; i++ ) >>>>> + if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) >>>>> + return rangeset_contains_singleton(mmio_ro_ranges, p= fn) >>>>> + ? IOMMUF_readable : 0; >>>> >>>> If we really are after consistency with CPU side mappings, we should >>>> likely take the whole contents of mmio_ro_ranges and d->iomem_caps >>>> into account, not just the pages belonging to the IO-APIC? >>>> >>>> There could also be HPET pages mapped as RO for PV. >>> >>> Hmm. This would be a yet bigger functional change, but indeed would fur= ther >>> improve consistency. But shouldn't we then also establish r/w mappings = for >>> stuff in ->iomem_caps but not in mmio_ro_ranges? This would feel like g= oing >>> too far ... >> >> FTAOD I didn't mean to say that I think such mappings shouldn't be there= ; >> I have been of the opinion that e.g. I/O directly to/from the linear >> frame buffer of a graphics device should in principle be permitted. But >> which specific mappings to put in place can imo not be derived from >> ->iomem_caps, as we merely subtract certain ranges after initially havin= g >> set all bits in it. Besides ranges not mapping any MMIO, even something >> like the PCI ECAM ranges (parts of which we may also force to r/o, and >> which we would hence cover here if I followed your suggestion) are >> questionable in this regard. >=20 > Right, ->iomem_caps is indeed too wide for our purpose. What > about using something like: >=20 > else if ( is_pv_domain(d) ) > { > if ( !iomem_access_permitted(d, pfn, pfn) ) > return 0; We can't return 0 here (as RAM pages also make it here when !iommu_hwdom_strict), so I can at best take this as a vague outline of what you really mean. And I don't want to rely on RAM pages being (imo wrongly) represented by set bits in Dom0's iomem_caps. > if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > return IOMMUF_readable; > } >=20 > That would get us a bit closer to allowed CPU side mappings, and we > don't need to special case IO-APIC or HPET addresses as those are > already added to ->iomem_caps or mmio_ro_ranges respectively by > dom0_setup_permissions(). This won't fit in a region of code framed by a (split) comment saying "Check that it doesn't overlap with ...". Hence if anything I could put something like this further down. Yet even then the question remains what to do with ranges which pass iomem_access_permitted() but - aren't really MMIO, - are inside MMCFG, - are otherwise special. Or did you perhaps mean to suggest something like else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && rangeset_contains_singleton(mmio_ro_ranges, pfn) ) return IOMMUF_readable; ? Then there would only remain the question of whether mapping r/o MMCFG pages is okay (I don't think it is), but that could then be special-cased similar to what's done further down for vPCI (by not returning in the "else if", but merely updating "perms"). Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 11:00:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:00:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320586.541392 (Exim 4.92) (envelope-from ) id 1nmCji-0003yU-5b; Wed, 04 May 2022 11:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320586.541392; Wed, 04 May 2022 11:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCji-0003y1-2C; Wed, 04 May 2022 11:00:02 +0000 Received: by outflank-mailman (input) for mailman id 320586; Wed, 04 May 2022 11:00:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCjg-0003ne-Rh; Wed, 04 May 2022 11:00:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCjg-0002wU-PG; Wed, 04 May 2022 11:00:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmCjg-0007Xm-C6; Wed, 04 May 2022 11:00:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmCjg-0004OV-Bd; Wed, 04 May 2022 11:00:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mEP0uI3z4Ss5cJ3SIixWc1aD1g/LRvoa7fxFifvjX/Y=; b=FkT5KiiclspX79JpQ5kteUCl3H o9ISx9bzbQsVOns2djLnOJDEItA5PdG7sk5QAStTG35UnE54sC3YBEOPnEmkoxitOQBEl5kZRc6lu ReAXmduwx3V2MYAwvhKP4d+hUjRHMtXPbWppNaKfFAagvUYSIDXzJaJmPJdGp06sQuVM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170094: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 11:00:00 +0000 flight 170094 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 798 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 11:20:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:20:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320596.541409 (Exim 4.92) (envelope-from ) id 1nmD3G-00076u-1V; Wed, 04 May 2022 11:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320596.541409; Wed, 04 May 2022 11:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmD3F-00076n-U2; Wed, 04 May 2022 11:20:13 +0000 Received: by outflank-mailman (input) for mailman id 320596; Wed, 04 May 2022 11:20:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmD3F-00076h-65 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 11:20:13 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28434631-cb9c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 13:20:10 +0200 (CEST) Received: from mail-dm6nam08lp2048.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 07:20:09 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB3978.namprd03.prod.outlook.com (2603:10b6:5:47::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Wed, 4 May 2022 11:20:05 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 11:20:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28434631-cb9c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651663211; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=a7cYbZornsBAQ8naSFhYceZi00oJ3S/vf0SkJczMXFE=; b=D4kevFiIxx03IHaPkyZ+g6UP5J8lkglb6/GZUDMG4qvrqV/kJKVUDWde A5XgsQKamuoRm0/JvytVP+ltF7tUwSVLeTvkzoYq6P4f7lvFzDO74+73N EAgbpBx4vx3ZhAue7/rhS8RFgJdAhpn12k0+RvNUgv+6JUXbeTL017fcK 0=; X-IronPort-RemoteIP: 104.47.73.48 X-IronPort-MID: 70563991 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/HhddahXbFIr2LWqFa8pbM9MX161GxEKZh0ujC45NGQN5FlHY01je htvCDjSP//fZzD9LYtxYYvioBwAsJXSyIJgTARpqyA2Fi4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvR4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQ4kEbbVxtgmbxgbOT1ufqpX8rDaKmfq5KR/z2WeG5ft69NHKRlqeKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQegGdYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8A/L/vtmugA/yiRtyJvvP/7fJeW7VOxEnEHBo FLM2kvQV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUS9wWl2qfSpQGDCQA5oiVpbdUnsIo6QGIs3 1rRz9fxX2Qz4PuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6 1i3QOIW3t3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:z72oLKkB/Q7Uf57Ks1hYEG+Ke7zpDfOrimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qTi2z+8Q3WBjB8bZYOCGghrjEGgG1+ffKlLbakrDH4JmtJ uINpIOcOEYbmIKwPoSgjPIderIqePvmM/HuQ6d9QYVcegAUdAC0+4NMHf/LqQAfnglOXNWLv qhz/sCgwDlVWUcb8y9CHVAdfPEvcf3mJXvZgNDLwI76SGV5AnYp4LSIly95FMzQjlPybAt/S zuiAri/JiutPm911v1y3LT1ZJLg9Hso+EzSvBky/JlawkEuDzYJ7iJaIfy/gzdZ9vfrWrCpe O84yvI+f4Dr085MFvF5icFkDOQrQrGo0WStWNwx0GT7fARDQhKdfaoie9iA2Tkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DMfeMMo/gtiuLElGclsRE0kjTFoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG8fIzmZ0Wd9ih33ekLhoHB X-IronPort-AV: E=Sophos;i="5.91,197,1647316800"; d="scan'208";a="70563991" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eE8rHVPNBGUDeiC/ewb4jJtFiBEBkq2jXujGHQf5pSHyzydC0mb7kEiVUuWFKnT4LiPCfi3ByWi1drYD6j1CnljQV95BheYslRzV0gx79ej/mVxJjXBoweoQq3tOItz9TTJzEs0v2d68LqPOk17eqXsEoY/aklwHAwWK/pIePEuyEbZfK6SvbEUcdqRuC1TslUgdfv3IQRUqfxi5/Ox5lD0UfI8mOIdk4bxXAFROFdPDUaSU8Ph+pVFF8aictWOv1mmDVq5XZ76EN7TlSWBuJbpsbyp/tcoyDRdAAueA3lJ2GJ03KAUF0kPx6w0Uag9K+zPEjRR0OLesVSckzadZ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rGLyz5rNsfkM5+0cdpWMsBi8Jw3UJRIy9rwFb2sFOmE=; b=YF1tPFbH/N2uVIysrqiElASPjM+VNBnhI3a4ZGEgv4h/fXBvAf8zVskpRtvXN/EYMOfRDsGpGc1GIiMT4VZ2TgmdWq4P86br0dmDCyuu0ALbct+SUNZ2r97163Hjmf/yY8Ibun7stAK8O/uqQUBonrN8Mn1m6AqBlzU+YjZVusMgDTLZWLnd4PBqMGEMI9lrOgdZULH7EquYD0xBx9/WJzpek4xWNyCDECGoH/R49sxbUTIUcrVq0HaaOXJkUdJfqWXRL7eapV05OTfbE80ENwx4lVqXkl8KVibIxiZxG4ZNQy3565kIWkO2f888MD54j7f5ALm/tZfmEnLHL/+xjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGLyz5rNsfkM5+0cdpWMsBi8Jw3UJRIy9rwFb2sFOmE=; b=FCJW9heoh1g21OpJnbNeM9mqGHWdYA2HWGIfJUqpmo6xf2gffBhfrMMx3mPiLZt3iPMaLgTXWrLUEiA73KYG8r2660zMNZ4Tjd2xFaauVJcM4SQ/zX2WhVhnDiKpI3/PZf2ut0XjvjE6nHey34sA2HciDITjm86dML8ob2djpjM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 13:20:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Message-ID: References: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> X-ClientProxiedBy: MR2P264CA0098.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9760b386-f502-48c2-fd04-08da2dc009f9 X-MS-TrafficTypeDiagnostic: DM6PR03MB3978:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4hfqBmyxrpkQ35DTNeVeL6FdOc0SBbBhlTs9apUmGH9cNu8YXhGHXEYxtOlMBAeXAN63R1NXaY6e7wL3X/2EEwqdR205Zn2EBScgz8vgh6QwqmcrK7kuAcNHIL9LPGCNg70KWJSJ3rZxOWsiXTtNGgojHQqavRpiqEJ9ctyzFE/WgKCS5JbPZSbQpJflycDYs4RAxFs7JD/TNyC3RM1IC0mzcfxZApLnLWhrZA6UpGBqSGe2Kvbjiu3GtjczJ5rvCqT4ZDMOVfYJCiBJxMa7FYwykCQeJeg2jp2YktTQAXp+X2g26WvEcVj2C+O+rbmHyE7heWme6DdtrHsesx7rIug9Uaif8IrCF+gWf6KzsuGUqUFomBJPGNgzCikc/3PcJB00tSBq988lffDyxL3PqNyva6zjK5Lt1UU2G6HfTa8L9xWmJL2LhKKjFw8D/j+mexSfOmsfgYaYmh8RSeLOLKyMitHC+z1mPP6sGVk1DnpDkwS0q+opcgXl55886zRG2EBmVv/R3WzgptKUeEbaI/J4L+BJraT69qgGXERo5633D4iKnkmejH8nHKoP6ulUN9MSWd1r8JzZd5hT4Gtu3R3aPcQD44XUQUNFioBIpK3VGtd41UoN1ZIbgEzfSeN/0ZS+NCphGLYcqRbhXlfHpA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(6666004)(86362001)(316002)(83380400001)(54906003)(8676002)(6916009)(4326008)(66476007)(26005)(186003)(66946007)(6512007)(2906002)(66556008)(9686003)(6486002)(6506007)(508600001)(33716001)(53546011)(85182001)(8936002)(5660300002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXYyNGJJZTc4Y2pEdkFUTkU4LzdwWjBnTk9kLzE1Yi96a2lxSklBNGhsdytB?= =?utf-8?B?Z0VmTWM4NzlBTlAxTGhuSU5YZkFNSkVNVVFCSmZNdDRHQnhxY3kxcXNhOVNu?= =?utf-8?B?T0swNkpNNE9jZ0Vib2xUMnFuUWt3eEwxdDNzc1hmMDZ0YzNVNitSYVBlZnhn?= =?utf-8?B?Qks1VFFuWTIzQ1VzOFlISExDY2dLNXlURVNlK2ZRVzBncndETXlFUWNWWldQ?= =?utf-8?B?WDVnaXdjZlJIdnFWWTZIQSt2YkdIaE4xUHE5dHBRd08xTnZTcmRsK3NqZUpp?= =?utf-8?B?SG1LNXJTcGlMWkJ2NnljZXBSenFCUVh3R2F3dmZ3eGlUSk1PZ1FUZFF5bjU0?= =?utf-8?B?Q2w3aVFhcjV0L3p0dGI3TjhjZ2pHTXl5VFlpSGFkaUJDZUxyK2RwaVZwVit4?= =?utf-8?B?aWdrdFBVL2laK1E3elJZbmZIaDhNTnpCTUlYWmovUHlHc2diS2NQVUFBdnFp?= =?utf-8?B?TFZoNlMxMnZhOW5ySVY5L2R0MEdKeVZJOGQ4NnNBa2o2dW9jZ0R4TlVVc1Yw?= =?utf-8?B?VjcvbTNYMXJiSW9CR3J0enJuTzJBSm1ucE02MGFnZVo4L0RzN01CVnlaZzRE?= =?utf-8?B?dGhNVG81SWw4QnYvTTVvUUQxdTdvQk1UMktIMDNzWVpHY1N2MXI5MVVCMWl5?= =?utf-8?B?YjNSdDdSNVJuQmVVbGs4YjBuS1oxQTBpeG9DcjZqUlRMQUcvVmUyYXVOdTR5?= =?utf-8?B?aDRHWVFRYzdscW1MQWJEZ25wdzlHVEpSYjZ0WFNpNkZ5bDI1bUFYVFpTOHVv?= =?utf-8?B?VmpUYTRtR05yOHh5RkE4dmlKSGZleFROamdqN1A3YnpicDVQQ0tiWmxkbS9m?= =?utf-8?B?S2xGakE0M2dRRGw5MHlTQjFncU1oVGhIbCtERFJIWWVQU3EzbWVIYVRPTzlh?= =?utf-8?B?ZGx0K0dzWWJTT3Yxbm1jTnRVaEVxdVNNT3hRKzVHZi83V1dQWEFmMWRsTElh?= =?utf-8?B?SmlOWHdBSVZQNjBJeC9KK0xqdTV2TW1NUDNRZERUNEJveEFNaWU2Q0RYSGVl?= =?utf-8?B?QUFZS2doYjdIQ1d4WjZ1aGl6Vi9iK0JVNlBHNDdkOTBEV0k0QjMyQmRIVmtD?= =?utf-8?B?M2wwU3R0a2l4OTF4azZGNjl1K0duNTNNYnVnSzQydUV6NmY4S1dBc2UyVStn?= =?utf-8?B?dFRKWThOM0NHK2lWUURYTXVOeEhhdVRXQWRiYmlmdzhUK2FTUWxpK3hydUtK?= =?utf-8?B?Q2pQSFg3TU5JR0NyNS9CWDhvSGJtOVFRSzRNV2dLb01SK3R3ZFRzZmZxaDBv?= =?utf-8?B?cVV6QzNTSVNST2Q0bFFEY29rdzVxWkxCRjZFNlR0dkV4cWhCa2RHanNza2Rq?= =?utf-8?B?elNnOVB6YTlwY2pkc3g3TzM1QXQ1aGVFcWZnb3JNOGk1dmFRQ2VEa1lVTytv?= =?utf-8?B?Unk3U21iOEo1Z0RuV21XdnVXYlpHTUNYQXd6VnIxRHdMMTB2cXd6RlpBS0Yz?= =?utf-8?B?OHJTT2RRRFNuYmc0UjNTcUNwVHBsM3Q0N1h6cWYzTGZzU3ZGNnU3aVNFYVpw?= =?utf-8?B?VE12TWpxU212eUE3SFo4TE9NSEN3VFBMdndQSXEyQ2ViSk9OR0tYMU50MWxk?= =?utf-8?B?Q0NDZDVvWGtsYTRiVjAvR0Nrd2FGdjQ1UGh4S0FDZFM2dThnb3JHUzZkRXps?= =?utf-8?B?amxLOTdmbVBwNE1TMWppY3lSV0hPdmxRK1JsempTank2RmtWeGdsSS9SNzlE?= =?utf-8?B?VjdoU3lWNktzOU5CQlhvSHFJWEZTK3I1dEQxQ2pVbGhKWHZrWStVZE1TcmpU?= =?utf-8?B?d0R4bS9iR01qd3VjTXRMTWtDMWdhUUpwcy9URkZpdU9KVVZJQWtybEZBZ1Va?= =?utf-8?B?TWhycnBtUHpQL0VRYlhiM3VnQ3VkZHpBUnNyWFM4NTBUVXJJUytKdjhjSmpL?= =?utf-8?B?S1Z2a01naWhnM00xQVdmVnZXVkd1RTlpeEZDcVpiOUJDUWNFYTdVSTRsK2Ft?= =?utf-8?B?M0JqNHVjS2FpVUFCZ2VZY2dXOGpybHF1RU9LVlc3Y28wbVZzdVI5WitnMUt1?= =?utf-8?B?NW5vM2xySkhNVHFKcy9hMGxoNmtNVnJRTUhTUFBiWTU2cW80ZzVKLzI3Wmp4?= =?utf-8?B?V01zK1pGVmVJODdzNDNNcXYxUjFBaitmSmFrejQvdjZTS0lqK2RURG9pNU9y?= =?utf-8?B?cGRwUkpVZmlRN0N2dVc4U0FoT3ArZXdUWWcxWnJKZndwbHVhblJldnNIMThm?= =?utf-8?B?dUJiMTdqREp3OURLcTJnMHBDdXFEd2s4R3dpQjFva2paVXMrU2YwUkk0b1Z4?= =?utf-8?B?VDA5dDR2UHIycVdac1R6SEQ1MHVSaUgzZldRc05kQTBvZXVYWTFTUExkWFlF?= =?utf-8?B?UzRHU1FsVW95WXJDVFp4R2FodHc3OFFYVllTRjdwTEJtR1dHNlRKeHhvT0ZS?= =?utf-8?Q?RftXm3oulLvo9MHI=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9760b386-f502-48c2-fd04-08da2dc009f9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:20:05.1945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mNi2ScNb1n4jW3v6b9FPP1L6soYFIBzWR6idL9FCJc3/4kLLcxSHF0lOXF2Xc0Id4vsL8VY57cOyPcyZCNRLsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3978 On Wed, May 04, 2022 at 11:46:37AM +0200, Jan Beulich wrote: > On 03.05.2022 16:49, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: > >> For large page mappings to be easily usable (i.e. in particular without > >> un-shattering of smaller page mappings) and for mapping operations to > >> then also be more efficient, pass batches of Dom0 memory to iommu_map(). > >> In dom0_construct_pv() and its helpers (covering strict mode) this > >> additionally requires establishing the type of those pages (albeit with > >> zero type references). > > > > I think it's possible I've already asked this. Would it make sense to > > add the IOMMU mappings in alloc_domheap_pages(), maybe by passing a > > specific flag? > > I don't think you did ask, but now that you do: This would look like a > layering violation to me. I don't think allocation should ever have > mapping (into the IOMMU or elsewhere) as a "side effect", no matter > that ... Hm, I'm certainly not that familiar with PV itself to likely be able to make a proper argument here. I fully agree with you for translated guests using a p2m. For PV we currently establish/teardown IOMMU mappings in _get_page_type(), which already looks like a layering violation to me, hence also doing so in alloc_domheap_pages() wouldn't seem that bad if it allows to simplify the resulting code overall. > > It would seem to me that doing it that way would also allow the > > mappings to get established in blocks for domUs. > > ... then this would perhaps be possible. > > >> The installing of zero-ref writable types has in fact shown (observed > >> while putting together the change) that despite the intention by the > >> XSA-288 changes (affecting DomU-s only) for Dom0 a number of > >> sufficiently ordinary pages (at the very least initrd and P2M ones as > >> well as pages that are part of the initial allocation but not part of > >> the initial mapping) still have been starting out as PGT_none, meaning > >> that they would have gained IOMMU mappings only the first time these > >> pages would get mapped writably. Consequently an open question is > >> whether iommu_memory_setup() should set the pages to PGT_writable_page > >> independent of need_iommu_pt_sync(). > > > > I think I'm confused, doesn't the setting of PGT_writable_page happen > > as a result of need_iommu_pt_sync() and having those pages added to > > the IOMMU page tables? (so they can be properly tracked and IOMMU > > mappings are removed if thte page is also removed) > > In principle yes - in guest_physmap_add_page(). But this function isn't > called for the pages I did enumerate in the remark. XSA-288 really only > cared about getting this right for DomU-s. Would it make sense to change guest_physmap_add_page() to be able to pass the page_order parameter down to iommu_map(), and then use it for dom0 build instead of introducing iommu_memory_setup()? I think guest_physmap_add_page() will need to be adjusted at some point for domUs, and hence it could be unified with dom0 usage also? > > If the pages are not added here (because dom0 is not running in strict > > mode) then setting PGT_writable_page is not required? > > Correct - in that case we skip fiddling with IOMMU mappings on > transitions to/from PGT_writable_page, and hence putting this type in > place would be benign (but improve consistency). > > >> Note also that strictly speaking the iommu_iotlb_flush_all() here (as > >> well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be > >> needed: Actual hooking up (AMD) or enabling of translation (VT-d) > >> occurs only afterwards anyway, so nothing can have made it into TLBs > >> just yet. > > > > Hm, indeed. I think the one in arch_iommu_hwdom_init can surely go > > away, as we must strictly do the hwdom init before enabling the iommu > > itself. > > Why would that be? That's imo as much of an implementation detail as > ... Well, you want to have the reserved/inclusive options applied (and mappings created) before enabling the IOMMU, because at that point devices have already been assigned. So it depends more on a combination of devices assigned & IOMMU enabled rather than just IOMMU being enabled. > > The one in dom0 build I'm less convinced, just to be on the safe side > > if we ever change the order of IOMMU init and memory setup. > > ... this. Just like we populate tables with the IOMMU already enabled > for DomU-s, I think the same would be valid to do for Dom0. > > > I would expect flushing an empty TLB to not be very expensive? > > I wouldn't "expect" this - it might be this way, but it surely depends > on whether an implementation can easily tell whether the TLB is empty, > and whether its emptiness actually makes a difference for the latency > of a flush operation. > > >> --- a/xen/drivers/passthrough/x86/iommu.c > >> +++ b/xen/drivers/passthrough/x86/iommu.c > >> @@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i > >> > >> void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > >> { > >> - unsigned long i, top, max_pfn; > >> - unsigned int flush_flags = 0; > >> + unsigned long i, top, max_pfn, start, count; > >> + unsigned int flush_flags = 0, start_perms = 0; > >> > >> BUG_ON(!is_hardware_domain(d)); > >> > >> @@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init( > >> * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid > >> * setting up potentially conflicting mappings here. > >> */ > >> - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > >> + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > >> > >> - for ( ; i < top; i++ ) > >> + for ( i = start, count = 0; i < top; ) > >> { > >> unsigned long pfn = pdx_to_pfn(i); > >> unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); > >> @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( > >> if ( !perms ) > >> rc = 0; > >> else if ( paging_mode_translate(d) ) > >> + { > >> rc = p2m_add_identity_entry(d, pfn, > >> perms & IOMMUF_writable ? p2m_access_rw > >> : p2m_access_r, > >> 0); > >> + if ( rc ) > >> + printk(XENLOG_WARNING > >> + "%pd: identity mapping of %lx failed: %d\n", > >> + d, pfn, rc); > >> + } > >> + else if ( pfn != start + count || perms != start_perms ) > >> + { > >> + commit: > >> + rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms, > >> + &flush_flags); > >> + if ( rc ) > >> + printk(XENLOG_WARNING > >> + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n", > >> + d, pfn, pfn + count, rc); > >> + SWAP(start, pfn); > >> + start_perms = perms; > >> + count = 1; > >> + } > >> else > >> - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, > >> - perms, &flush_flags); > >> + { > >> + ++count; > >> + rc = 0; > > > > Seeing as we want to process this in blocks now, I wonder whether it > > would make sense to take a different approach, and use a rangeset to > > track which regions need to be mapped. What gets added would be based > > on the host e820 plus the options > > iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes > > based on the logic in hwdom_iommu_map() and finally we could iterate > > over the regions afterwards using rangeset_consume_ranges(). > > > > Not that you strictly need to do it here, just think the end result > > would be clearer. > > The end result might indeed be, but it would be more of a change right > here. Hence I'd prefer to leave that out of the series for now. OK. I think it might be nice to add a comment in that regard, mostly because I tend to forget myself. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 11:26:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:26:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320604.541420 (Exim 4.92) (envelope-from ) id 1nmD8t-0007vC-PU; Wed, 04 May 2022 11:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320604.541420; Wed, 04 May 2022 11:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmD8t-0007v5-Lv; Wed, 04 May 2022 11:26:03 +0000 Received: by outflank-mailman (input) for mailman id 320604; Wed, 04 May 2022 11:26:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmD8r-0007ux-Sy for xen-devel@lists.xenproject.org; Wed, 04 May 2022 11:26:01 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0603.outbound.protection.outlook.com [2a01:111:f400:fe02::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9641565-cb9c-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 13:26:00 +0200 (CEST) Received: from DB6PR1001CA0029.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::15) by VI1PR08MB4063.eurprd08.prod.outlook.com (2603:10a6:803:e8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 11:25:54 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::8c) by DB6PR1001CA0029.outlook.office365.com (2603:10a6:4:55::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Wed, 4 May 2022 11:25:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 11:25:52 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Wed, 04 May 2022 11:25:52 +0000 Received: from 7cbc38927b67.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C29148E5-7BB3-456B-BB61-D5A4B34F0857.1; Wed, 04 May 2022 11:25:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7cbc38927b67.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 11:25:45 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) by VI1PR08MB3293.eurprd08.prod.outlook.com (2603:10a6:803:41::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 11:25:43 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938]) by AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938%11]) with mapi id 15.20.5206.024; Wed, 4 May 2022 11:25:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9641565-cb9c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Nbq1Nk3qwQrTK+FGEKiUQcJAMEIGb9y46Zb/WYN79oTUVgxkuuxLj56Wv5Nu2w72TBNPSpGv9XqB5hKRF00kfYz9k0sK5HJLVXPEecL2Gloro29dwyWrd1GGl7qqa5Sb0iLmTXHKklJXj/paHzKK+9/qI98Sr9SrySHOdpJAAHHaQB9M/YbIrSrYsgKWpZK0/HrKqkrKOa14fOQyg8RJydS6erAmWdkOcGiUty2W4locS0j562A5artC+WmS7CwQZx45+wuixn4Ikf0q1L0RdKXKqx4xkKRH4ujQt7T7Zm+mAVCyYZVkPCxPrEG21ulRE/WQ+7oSP0QgSKDtf6l0Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BxDbL4q+k1vsMqGCv/KwwhS2qPBsrfbNV+N/I0uoJos=; b=R6Ten7IUofX73Zry3gw6FAZQGpkk/voedbu7QEEkZeUVCmlOR8ZnH9nAebbKIFdr5fxDXmkxwaoZyWKYr6IUOHNTTcf1h55Bv62b6/ZCopHzoTvS+IxGdlBaSyMRw2KI+rs+W+fscdGVbmBIkXyiCxxev4F9IkD4N29HgkB06qjfT4SSMITkVnJnMumAyaBe9OegY+7UBbT7HYDf3fFHvP4hNs2A93Q6dXVEyluCzPYCLs5XIybvc6eZ0aDVtGYT5FIbSHZ2TTheJPw/ynhIbJkIRe+etAWgOLR904yNPvcLgWTzpdZu0PQ+APcGHu+LbLwYXcx3r8MEuDLG1P9Rzg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxDbL4q+k1vsMqGCv/KwwhS2qPBsrfbNV+N/I0uoJos=; b=xhbk4Iqd4raj+kF7wIJgilGr9gjISPFGF4LdY3Jh1N032jOrJdzGslKEETPCjJtyHlW+/b32eluvD6Q2ynfFqOntzJpWkND7WTqTojZgQyo4IwCflSBpqPakbn+qThLF7Wtoxo03AoW9+jKkwVNve0d4J/2QavJyiz05YQbHqJg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 932b0875947538dd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EcyoQ3IfqK7tTFQOTB7a1f6cV26jCpRPq5YMuMpvRGPz5UIoNuPDPwMW/tAa+UEZp5vS3bJEyd6Z9fUrsQ8ovPH9+uPgkMqJRFw/KNNdXKKTpwiT0xSTI6Ek0Nsp2Dg1JSi8v+SbfDmbpajGnUpC16en+kwyJ/dT3pPFmMND6l9dOl/jcXSVZbx82ssVgh1roHU8HDll6IQ4cCW7VFE+KoNvwSm+YdIJjaSQsv/99322129i7pEPeHbW3O+xhlVcxeCBSLrVUo4YxHh4GQGJC5UiFShNpC0IlVetHl2xXkuwxSZ5k8THGWHNfleFsf3uDe5rN7n1P50jh60VXpYvww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BxDbL4q+k1vsMqGCv/KwwhS2qPBsrfbNV+N/I0uoJos=; b=c2jyTVr9MnV/Axav9/iw8maJw5kS4ykjQoNabcoErREyg6J3JjR+mmBIqnvnUq5FG6exuNI1f39dC7AENwtCcxcErJv1VVFIx1qRo8DV9hgrqiaMW0ZNTzSvo6n575kLDvJ9o7RtuBbdz2+PfytqMZLJBsHc8uYrvMex7vJcR+Vx2f6VPSobXHDQIJ0WocURxHwSOU1Ck1t8cFFoC+TTX6XVU8yXdQNsMxjA7hPAFuuY1F7CyKvFzIOxn9N4KymfSFRkVn6teKBWQNwvvIbtzq2FL1AG3MonqUfulcc/8KQzFlpHXwjxxtM0pZd36wrCLOH6Kw0DApr8KA+Jy6HfeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BxDbL4q+k1vsMqGCv/KwwhS2qPBsrfbNV+N/I0uoJos=; b=xhbk4Iqd4raj+kF7wIJgilGr9gjISPFGF4LdY3Jh1N032jOrJdzGslKEETPCjJtyHlW+/b32eluvD6Q2ynfFqOntzJpWkND7WTqTojZgQyo4IwCflSBpqPakbn+qThLF7Wtoxo03AoW9+jKkwVNve0d4J/2QavJyiz05YQbHqJg= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Topic: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Index: AQHYWlHsf41jIOfeQ0mX6M++noloAq0NWJOAgAFGKQA= Date: Wed, 4 May 2022 11:25:42 +0000 Message-ID: <66A4F1AF-9539-497E-A777-316D1C21E1F4@arm.com> References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6f15aa29-b21d-48f6-4c8a-08da2dc0d8fb x-ms-traffictypediagnostic: VI1PR08MB3293:EE_|DB5EUR03FT047:EE_|VI1PR08MB4063:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AnK0FVtcU1tTYuZGqPqZDLW+WBvlEdsXcYdin07q7SYYX5/nkvPy4cDmm1Cr/QuXmuXvd0GlkvOpnrePrrTVVy8HPA7riZfRhcNKD8exPV9/VdbDIo9s4TcvudHI5fPkGFnbXqXih7sCa2KBhujbFmB32clE9RUJ0zMNrpA8IIJ3m02bn65bhY9LeMLrP4miwWA2jbGHVBvf1OO0FQ29feZ5RYoTzI5dtnQP6MjdWROfqu5WpDMumgPn3eVVDay00DqisdlrzyMrgKAL1nGX0NWpL8Rz46eU8TLy4OtRTZ4xhfSD/avh9Ojx78BJT+e8an2tupo9dRwKqQGDQRqc5/HamorQxpGV0pGNrThNjKk6Zle8gr5c8CAYwTzTPjSeAy34maiYHARJElMticsfXi5A1ibHtgXJ1rkDsiv4zbhep0GsdhPCr4wSHxzhFIpZ4EJeE8e4JI16L22PCUOZWZY/tMe/mIEhYuDUjClBLFYOSl9N9aDylZP2+zB5tppXU/wJ0X96su0UzuiRQ3gD/Vm2k+0UWWHvUll1GgMMfbtwfywDok99Mm+Lkj8VA9k0j06xqbtd6F5sVLwlKJFaBVYI5OiX8S+9v+kckuOuSfLjCcA5IM8jqdLA6eQqUTdXJmJyrIJHZhqm2EDOwxrQ6iwKmotFsw1UfzpSjLnv1hh3jkCZ/STeAbHjhqRmUmyDXK4NMNudueZNZeqOoKnOYNDM4BheCHOV6ICL1qh1KrxWP8J/S0yLhrBWytfwiSav X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(86362001)(2616005)(36756003)(66946007)(66556008)(66476007)(83380400001)(33656002)(53546011)(316002)(26005)(8676002)(64756008)(186003)(66446008)(76116006)(91956017)(4326008)(8936002)(6916009)(5660300002)(71200400001)(38070700005)(38100700002)(6512007)(54906003)(508600001)(6486002)(122000001)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <63EA348529398B448FD651519AAAD7C7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3293 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 20024d50-33ba-418c-8772-08da2dc0d367 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zOSWNLToRmGwG1NNXTv/uK/beWZcUYpxkoNmLGUvi/7efjHwJ6UsgPEaeY2xZCE94vaOh4LnEQNJt9Ng9dnqZ4XD/AjkRZjpjjBn+KFFe3mik/TXvMYWQh3tRIdHB5CVh1eR2UnYs/CkIO02Ifq3Jot+8tX+XSZQVE+43fkig0uyttxQwI/2EirJlnCgwWW+FwF5dP9tD0Mz7FuUsolefoQOorga7PjtMhX3N/7iOZCVvbgRWyEdKd0oE3nYioeSag7mzBR/xbMbDB7esTmbfOJFXeamHybF3ylXepKlNXgLTSe7votMwxE8EySLeHPp4lSew/ImaB0Mv+LkMvvbaynlFC9rMpqpCmqN7i8ZuLVnOmDNcIWBgQgnA7ewsvgD67CjSdXJCTkTOm+F2Hc6ZcewM34xy8EHcDEI7BpRZZjLbmZJjpZpLds+0ZbEfZOabYMpvq3uFjup+ZmV8J0svCtdUawh1X0zj8e5PDhZ5MFkKtUv8r9mvbT4VbXX5tM/ho/R6P6YvXJtXdCP3sKO2D1u5d2JMqu/kfRcxBoBGFOpJ196VfZ0WS8+cfSlC9Dp4Hu6CqrKeEWnDlJ9vhQSEUp1fCZzT9KHr1K+4wJUSzbRnmc+pF3GOQxkBO/vC8FMuldPLURDzv66ijAmeJhl5AdwX7nG9cmGEY/+x9wvX6Yw4rSDhx/Na3xBXcrOkAJa X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(5660300002)(316002)(36860700001)(86362001)(8936002)(83380400001)(54906003)(2616005)(33656002)(186003)(47076005)(336012)(81166007)(36756003)(6506007)(53546011)(2906002)(356005)(82310400005)(6512007)(70586007)(6862004)(4326008)(70206006)(8676002)(6486002)(508600001)(40460700003)(26005)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 11:25:52.3508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f15aa29-b21d-48f6-4c8a-08da2dc0d8fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4063 Hi Julien, > On 3 May 2022, at 4:58 pm, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 27/04/2022 17:14, Rahul Singh wrote: >> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are >> not enabled before mapping the collection table using MAPC command. >> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection >> table. >> Signed-off-by: Rahul Singh >> --- >> xen/arch/arm/gic-v3.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >> index 3c472ed768..8fb0014b16 100644 >> --- a/xen/arch/arm/gic-v3.c >> +++ b/xen/arch/arm/gic-v3.c >> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) >> /* If the host has any ITSes, enable LPIs now. */ >> if ( gicv3_its_host_has_its() ) >> { >> + if ( !gicv3_enable_lpis() ) >> + return -EBUSY; >=20 > gicv3_enable_lpis() is using writel_relaxed(). So in theory, the write ma= y not be visible before gicv3_its_setup_collection() send the command. Agree. >=20 > So I think we need to add an smp_wmb() to ensure the ordering with a comm= ent explaning why this is necessary. Or maybe be we can change the writer_relaxed() to writel() that will also w= ork. - writel_relaxed(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTL= R); + writel(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR); =20 Regards, Rahul=20 From xen-devel-bounces@lists.xenproject.org Wed May 04 11:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320610.541431 (Exim 4.92) (envelope-from ) id 1nmDFK-0000yh-G3; Wed, 04 May 2022 11:32:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320610.541431; Wed, 04 May 2022 11:32:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDFK-0000ya-CO; Wed, 04 May 2022 11:32:42 +0000 Received: by outflank-mailman (input) for mailman id 320610; Wed, 04 May 2022 11:32:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDFJ-0000yU-3o for xen-devel@lists.xenproject.org; Wed, 04 May 2022 11:32:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e743f4c6-cb9d-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 13:32:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C87C312FC; Wed, 4 May 2022 04:32:38 -0700 (PDT) Received: from [10.57.2.7] (unknown [10.57.2.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 392E43FA50; Wed, 4 May 2022 04:32:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e743f4c6-cb9d-11ec-8fc4-03012f2f19d4 Message-ID: Date: Wed, 4 May 2022 13:32:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] xen/arm: gnttab: cast unused macro arguments to void Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , xen-devel@lists.xenproject.org References: <20220428094625.382970-1-michal.orzel@arm.com> <074a5ae8-cade-3343-0c18-8122c85fecc3@xen.org> <87eb6f25-c940-8aa2-bab3-dea9bcf1760b@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04.05.2022 10:13, Jan Beulich wrote: > On 04.05.2022 08:41, Michal Orzel wrote: >> On 03.05.2022 19:44, Julien Grall wrote: >>> On 28/04/2022 10:46, Michal Orzel wrote: >>>> @@ -89,10 +90,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >>>>   }) >>>>     #define gnttab_shared_gfn(d, t, i)                                       \ >>>> -    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >>>> +    ((void)(d),                                                          \ >>>> +     ((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >>>>   -#define gnttab_status_gfn(d, t, i)                                       \ >>>> -    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) >>>> +#define gnttab_status_gfn(d, t, i)                                        \ >>>> +    ((void)(d),                                                           \ >>>> +     ((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) >>> >>> I share Jan's opinion here. If we want to evaluate d, then we should make sure t and i should be also evaluated once. However, IIRC, they can't be turned to static inline because the type of t (struct grant_table) is not fully defined yet. >>> >> Then, we could do like this: >> >> #define gnttab_shared_gfn(d, t, i) \ >> ({ \ >> const unsigned int _i = (i); \ >> const struct grant_table *_t = (t); \ >> (void)(d); \ >> (_i >= nr_grant_frames(_t)) ? INVALID_GFN \ >> : _t->arch.shared_gfn[_i]; \ >> }) > > Please avoid underscore-prefixed names here; we've started to use > underscore-suffixed names in a few macros. > > Additionally please consider using typeof() instead of spelling out > types. This may help to avoid surprising behavior. > > Finally, instead of merely casting d to void, please consider using it > in e.g. ASSERT((d)->grant_table == t_), which ought to also take care > of the unused variable warning. After all the explicit passing of t is > only an (attempted) optimization here. > >> However, if we start modifying the macros to evaluate args only once, shouldn't we also take care of the following macros in this file?: >> gnttab_set_frame_gfn >> gnttab_init_arch >> >> I'm ok to do these changes but I'm afriad we are losing the origin of this patch as we are focusing on macros not related to the issue. > > Indeed - I'd leave further ones to a subsequent patch, or make > conversion of all of the macros a prereq patch to the one you're after. > > Jan > Ok, so I will drop this patch and push a new series containing of 2 patches: 1. xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* 2. xen/arm: gnttab: modify macros to evaluate all arguments and only once Cheers, Michal From xen-devel-bounces@lists.xenproject.org Wed May 04 11:49:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:49:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320620.541442 (Exim 4.92) (envelope-from ) id 1nmDVK-0002dc-SZ; Wed, 04 May 2022 11:49:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320620.541442; Wed, 04 May 2022 11:49:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVK-0002dV-P2; Wed, 04 May 2022 11:49:14 +0000 Received: by outflank-mailman (input) for mailman id 320620; Wed, 04 May 2022 11:49:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVJ-0002dL-Rt; Wed, 04 May 2022 11:49:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVJ-0003mr-Pu; Wed, 04 May 2022 11:49:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVJ-0000Bb-DV; Wed, 04 May 2022 11:49:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmDVJ-0005oh-D1; Wed, 04 May 2022 11:49:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lfnX+E3D8HS/VcflDx/HgPYIM1bJI3f/8dwmdimg868=; b=vjSnX2frsfxdjcOj6JwGHm0ESs lR6vq0Ncf8TdlYQQf9EnGh6HHBet6GpGwRwGU9nUKxg2rm99TaItRmhhAVl+XMQgulGJLFv87j3er OMr6X/t8lpsvnFl8DccZsVrYlwOfcxQ6uvxYkMmfeRwMKAvguTXl1lojB9iMKVIkVGY4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170097: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 11:49:13 +0000 flight 170097 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170097/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 799 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 11:49:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320625.541453 (Exim 4.92) (envelope-from ) id 1nmDVh-00033y-4J; Wed, 04 May 2022 11:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320625.541453; Wed, 04 May 2022 11:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVh-00033n-1G; Wed, 04 May 2022 11:49:37 +0000 Received: by outflank-mailman (input) for mailman id 320625; Wed, 04 May 2022 11:49:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVf-00033N-MJ for xen-devel@lists.xenproject.org; Wed, 04 May 2022 11:49:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDVf-0003nG-Eo; Wed, 04 May 2022 11:49:35 +0000 Received: from [54.239.6.185] (helo=[192.168.21.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmDVf-0007pP-8W; Wed, 04 May 2022 11:49:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=iHuLg9uKVa1aHZ/vij6AprBhnuR8wdbdvE5Mk+L2ESk=; b=NO6LmjNmHV8grwa5+zqcqki+Gv bDjlw89Bnxa6Q4sN/3jIzhtVKSddRtLaYGmrlUCNLl7OjGx5mOJtink8mTRU2JjU8Widc05yRFZlA vw1gjWIOYB/f7Qieuj7aqMDQiQl3Bcz06e43/bag3+hqIe1w1dwQUra64NL8xeCsKYhE=; Message-ID: <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> Date: Wed, 4 May 2022 12:49:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> From: Julien Grall In-Reply-To: <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 04/05/2022 10:49, Bertrand Marquis wrote: >> On 4 May 2022, at 09:20, Julien Grall wrote: >> >> >> >> On 04/05/2022 08:39, Bertrand Marquis wrote: >>> Hi Julien, >> Hi, >> >>>> On 3 May 2022, at 19:08, Julien Grall wrote: >>>> >>>> Hi Bertrand, >>>> >>>> On 03/05/2022 10:38, Bertrand Marquis wrote: >>>>> Sync arm64 sysreg bit shift definitions with status of Linux kernel as >>>>> of 5.18-rc3 version (linux commit b2d229d4ddb1). >>>>> Sync ID registers sanitization with the status of Linux 5.18-rc3 and add >>>>> sanitization of ISAR2 registers. >>>> Please outline which specific commits you are actually backported. This would help to know what changed, why and also keep track of the autorships. >>>> >>>> When possible, the changes should be separated to match each Linux commit we backport. >>> As those are exactly identical to the linux tree, one can easily use git blame on the linux source tree to find those information if it is needed >> >> Well... that's possible at the cost of everyone going through Linux to understand why the changes were made. This is not very scalable. >> >>> I checked a bit and this is not something that was required before (for example when the cpufeature was introduced). >> >> If we import the full file, then we will generally don't log all the commits. However, for smaller changes, we will always mention the commit backported. There are several examples on the ML: >> >> - 0435784cc75d ("xen/arm: smmuv1: Intelligent SMR allocation") >> - 9c432b876bf5 ("x86/mwait-idle: add SPR support") >> >> We also recently introduced a tag "Origin:" to keep track of which commit was backported. If you want to understand the rationale, you can read this long thread: >> >> https://lore.kernel.org/xen-devel/0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com/ > > Do I understand right that it is ok for you if I push one patch mentioning all the commits done in Linux corresponding to the changes (instead of one patch per commit) ? For this case yes. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 11:59:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 11:59:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320635.541463 (Exim 4.92) (envelope-from ) id 1nmDfB-0004pA-5g; Wed, 04 May 2022 11:59:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320635.541463; Wed, 04 May 2022 11:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDfB-0004p3-2q; Wed, 04 May 2022 11:59:25 +0000 Received: by outflank-mailman (input) for mailman id 320635; Wed, 04 May 2022 11:59:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDf9-0004ox-QV for xen-devel@lists.xenproject.org; Wed, 04 May 2022 11:59:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDf9-0003xy-HQ; Wed, 04 May 2022 11:59:23 +0000 Received: from [54.239.6.185] (helo=[192.168.21.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmDf9-0008Ik-BY; Wed, 04 May 2022 11:59:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rMOx4W//VFhBwFm/jRSN74+WIOFhA+Era3LnSSHVD8M=; b=uBVFSbtGjpvmC7vR/U2oTr4N9d B93M4lHOpbOMQIISn9YA1M9FP49GZMGDcHCRxO8w5qqL8/dnp1rPKu+ru3R8eMCZ+fv2DbreDxt+3 /JEZvwccNII+pFi3+527PI/gu+szSKstIHpUa9M3yPtLKKcKw9jYYgOwq7vWLxibRCbk=; Message-ID: <0bab2226-fcce-6525-323f-c95d951e6696@xen.org> Date: Wed, 4 May 2022 12:59:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> <66A4F1AF-9539-497E-A777-316D1C21E1F4@arm.com> From: Julien Grall In-Reply-To: <66A4F1AF-9539-497E-A777-316D1C21E1F4@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/05/2022 12:25, Rahul Singh wrote: >> On 3 May 2022, at 4:58 pm, Julien Grall wrote: >> On 27/04/2022 17:14, Rahul Singh wrote: >>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are >>> not enabled before mapping the collection table using MAPC command. >>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection >>> table. >>> Signed-off-by: Rahul Singh >>> --- >>> xen/arch/arm/gic-v3.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>> index 3c472ed768..8fb0014b16 100644 >>> --- a/xen/arch/arm/gic-v3.c >>> +++ b/xen/arch/arm/gic-v3.c >>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) >>> /* If the host has any ITSes, enable LPIs now. */ >>> if ( gicv3_its_host_has_its() ) >>> { >>> + if ( !gicv3_enable_lpis() ) >>> + return -EBUSY; >> >> gicv3_enable_lpis() is using writel_relaxed(). So in theory, the write may not be visible before gicv3_its_setup_collection() send the command. > Agree. >> >> So I think we need to add an smp_wmb() to ensure the ordering with a comment explaning why this is necessary. > > Or maybe be we can change the writer_relaxed() to writel() that will also work. > > - writel_relaxed(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR); > + writel(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR); writel() guarantees the previous writes are observed before this write. But it would not guarantee that the write will be observed before the ones after. Also, after further thoughts, I think this wants to be wmb() (system-wide) rather than smp_wmb() (innershearable). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 04 12:01:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:01:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320645.541481 (Exim 4.92) (envelope-from ) id 1nmDh2-0006MS-WA; Wed, 04 May 2022 12:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320645.541481; Wed, 04 May 2022 12:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDh2-0006MG-SI; Wed, 04 May 2022 12:01:20 +0000 Received: by outflank-mailman (input) for mailman id 320645; Wed, 04 May 2022 12:01:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDh1-0006Lv-Fy for xen-devel@lists.xenproject.org; Wed, 04 May 2022 12:01:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e68d06d4-cba1-11ec-a406-831a346695d4; Wed, 04 May 2022 14:01:17 +0200 (CEST) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 08:01:15 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB3567.namprd03.prod.outlook.com (2603:10b6:805:4a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 12:01:12 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 12:01:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e68d06d4-cba1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651665677; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kRLMZ8GgmoIEtLb+5OhcyKbjXL0yGW8xba8e9ur84eY=; b=cMPM/bGZLlImiAcS9sw4lJNl1/eAAUtmU0ckMZIm7aD7rwCq9BWMx0hm giOad7Je0Q7p2FCZU68Pb0fMdfzY1CfZdjVpUsXDvHIV2thwJliF/EG8c Q0gRN+SCDI7PDZlEkk9lllPzfqYZWkrmWxP3rtBd0+oxveOWRtMcyXjgm Y=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 70566273 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/8vTMKutygN25hroqjIeDUruyufnVCBfMUV32f8akzHdYApBsoF/q tZmKWvUPPuMN2b0KIp1a4vgo05Xu5bVz4BqT1Nvq3g8QXlA+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17V5 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8PeYDug98kcSNUGh5aJqBg8aP+PFSg5Jn7I03uKxMAwt1IJWRvZMg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IHmm5v3KiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N+PRpuTeIpOB3+La3GdDccdm1edVynByJq lDdzmjnKChPYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IA0bUx63rOe0jma6WslDM AoE9yw2t68w+Ue3CN7nUHWQuHeZujYMVtwWFPc1gDxh0YLR6gedQ2QBEDhIbYV/sNdsHGNwk FiUg9nuGDpj9qWPTm6Q/auVqjX0PjUJKWgFZmkPSg5tD8TfnbzfRynnFr5LeJNZRPWscd0s6 1hmdBQDuog= IronPort-HdrOrdr: A9a23:MxkFRK44Ewq53WoaGwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="70566273" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bkAPHt22NMIJx/QVZ9icgkGvKrqHjk/fRNta77S0IVI24iuXVNu2TKhC2I9SRSYw2hcKMiEBvy9Z4SMyIJ0WFpyjJW366IEEep4MvdUEbwlI91DouJPF1mTp9kZxey8yldu2F4cS6ojfl6i7H8bWSGUGl+pSEf4U0enDzIJL52h2Q8nkdYVBC1+QVcYN35nAzFmGfxr4fBOybJ3hRMYkGdvHnbytcx9ywldZ6mqhY09pwldqe5k7K0lP4kmDr1S6nHxJQKFYlgFuaSRzi+DMGiFBtJVDdhWZjOR4o8D+lWg8i8hbwLHRjDMm6EM0Owub4SDyfwQKQ9Szcc3AiERpYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wqE6FbiLFOhEI0kMWqQB55i1XJ4lYeJnSAw3hJjs0qY=; b=WuxfI4+Gxax+xOL7Xsarn9UFog7sFtRl7XZh+Zgd072QWBnD3j2kiI4KA9u0i8ec0/68xdy6fd/4hv5HX/xI1K8GZaBfdxDwCYqGGkELSELnw2IatqpFhwQYSDlM3B1FgvN6ecEe4rEEZ2l1fZEpR2boRBgcxPoH2jHW3HFRtkTwXxcwz6FH4P/NxyeyZ1/f3W+wO+lpN5GOBvgCycxv84+IJYhO5zr6X3+YJO0WkdLn23pXFpEkSndZNMUd+CmUeQuuWvFaCCWyNha9FkkzJRLrS5l8T25++vQK8y2UjqtrTmIZM3uwBAgodNqp7mOy8lXRWeSpf9gMoRDrFHXuvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqE6FbiLFOhEI0kMWqQB55i1XJ4lYeJnSAw3hJjs0qY=; b=HYvG+gzMZeNbcYNRKmOsM+wlSxv1yE9MYmLQZEsru+KGeolZlAdgftoAWTPdbdTakI/7WDkHsdJ5qgQSL2l6w86XhVIlm2y3MUh+ZWB+u1+hriYEfd0sIkwbWN9Qj+CCeEjVr3CKSywailzpQBVLYi+aDHvGaQ8F5VLTfHVrGk4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 14:01:08 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BLAPR03CA0022.namprd03.prod.outlook.com (2603:10b6:208:32b::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f929019c-3aca-46cb-5889-08da2dc5c7ef X-MS-TrafficTypeDiagnostic: SN6PR03MB3567:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7f33z0GLHrp9WB3Aj6BPHIpm8c69OLSU0N3bUVwFVWpOZ0Zx44KU7c41iUVlnhB4G5UOj5v2Rk9adrK7HmNMYN/puEZOPp9kn6BIdgRUB7svoUu3vPswjB9WY3mV4VFZ5pWFvtZ/txxLa5YowMAe06SD3ksRuB2Pf7aLJMzVe1elGtsok7zIAGi2j5Lodas1OPWdOs0GLcDguGiCEq9Yc603x9lxHII/ti34UpYh0Taf8939EihvviIKqEWjDs1jkUyeUqCQ3HE3qcVzP+KPs2H3jm3wBA+XyK684IwcXYxGw0iNeaUN2KSkFZW2eb5kRA5Oc1kqJCvnc9trvHIsyBZ2jQMXw6y43YJwGjS9bQ/8bbxWMwiwIfSTDSM3yKuAgy0McQp5z6rUArgILa0h7KVNMyEDCUra/eMSulfY0amwbVqcmfxUwBN92R0l09cEkRi1/UMed+tiWcP7zyI0yC7sEWcZvB3wBARuMLrmbxkZK2twE2BNRkPwlprh+z2ysJ6viEtdqKh+c1Wk+rylTlepnxp2Ca57QawMwPR7YPdzsucxhGZ2RXaEZhwChCchWu8JIn/ng//JE/c+hfWt99z0SyAQ8If/wLTsIqGunwIB3CEh+ateFLzipxNs6wfG02MBKjf/adlyaa02ci4kug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(6506007)(26005)(53546011)(85182001)(6666004)(9686003)(6512007)(82960400001)(86362001)(38100700002)(8936002)(83380400001)(33716001)(6486002)(6916009)(54906003)(5660300002)(508600001)(316002)(2906002)(66476007)(8676002)(4326008)(66556008)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1JjRlhrajF3WlVZQ1lMRndZdWR4T3l2dFZ2WnQ0bjlzYyt3dDE5UzBoWity?= =?utf-8?B?a2NqRjdxeDlkME1ZMXc1ZUt3WktoRDk4NWIxOG5kUXVFSmpYMFpTSlNPeTN0?= =?utf-8?B?RUs3T2VlenhLZDFHRDJ2VG8wUzg3dWtTK0xaQ3UxSy9rdW1CNU1aVzNhSnA2?= =?utf-8?B?YjVOdlBia0IyZjBIZlJFUjRoYWs2ekZWRnlxb2VVbGhqNm5SVWFvMXRsRzJa?= =?utf-8?B?T0xkSEhrcUtOVmRsVEtDT1Rzby9vN3VvK1NIVWFIcWFPa3hDWFh2OXZ6NHQw?= =?utf-8?B?dUtkaFQrVzg1b3Zsa0h5OGd5d2FNQ3hsREU1cEpiendhcmxTM0Y4ejJvMC9F?= =?utf-8?B?UHV3U3dMTDdIRnp0b2tZTS9VRm1xWkFkOTdTMlp1b2JNVVlaNGlnUC9nTi9M?= =?utf-8?B?ZFU0blFMc0VHZkJWRm5NSk91VDB2NTFsMUJVekNIMUIwYUlBNzE0RldSV2la?= =?utf-8?B?RlpaYWhnd2tFZFJFZHE1RVAxaFRpZmZxbm9XaDg3NHl4SXphUFREQUNGNTR3?= =?utf-8?B?b01taEtUeGdGYTNrM3hYa1VXc2RTUWcwS1RHVXM0R3VEbSszK05tVG0xcGxQ?= =?utf-8?B?NFUyamYrOWgyZmVONFFVQWd4MTNuK3dtNGhKaDBmSDNUN3hmV3d0WllMQWlO?= =?utf-8?B?Y3MybEhjVzZuVkE4WEFXbE9hN21NaWdCSDBGbWRiZFF3cHhFb0t5Tm1XNzhQ?= =?utf-8?B?Q3V5ZENNVEttWm1naFg5YnBsUTdYakM3RGE4ZGVkMDZqcjdKRkFlRTlGVUJS?= =?utf-8?B?TEFFZ2hLRklYUThpN3hlSnMrTmgrYTU2eDRLbWdmQWZhZHNyaXNVaVZnY0Fj?= =?utf-8?B?Z2NKdGVzanFrQjEyWWhYblc1aGNqUXo3UGJEU1RXMDFxcXMwRUIrcU80bUQ1?= =?utf-8?B?NkVPUW5ObjBMdENIOXV4Y2NPTmNXMjE1dDdMMGZRNEtLcnNaVUpjc2JDVUtN?= =?utf-8?B?YXNGWHhrNlpGcGRDQkVDSzRUTkVjU3JyUE1jbUJxRHBOb1NvdGhiTDNWc25U?= =?utf-8?B?NWxqbEhDSTg1REY4Wng1dWt4Sjk5T1VTRVNwSnYvS3k3VFo1Sllab1MxMEVF?= =?utf-8?B?SlYwbVBDaEErT1JmUTZvanVpZnQvaU11U1JBcjBXK1lqaFJKV2RBS3QrdURq?= =?utf-8?B?SEVYQjJTSHAvYUdNQXduTytHMVVpaVgwdU8wUmNzWDd6SW0xdzgvQTRxNXk5?= =?utf-8?B?dG9CKzV3eHU4MmZXOUxIQnA4QTdIMHRzYXVOTVY1V1gxaSs3T1FDOE5vUFVB?= =?utf-8?B?NGN0dkhUTm85VkJ1alBHN0hBM3ZaZW1aUWR4cEdjaDhCOGJMckcxakl2am5I?= =?utf-8?B?OGF5aURjRUZkWFhFMUR4d2s2Ri9LTlc1SHQ3SlNDU1RITnByR00zTUN3SEtJ?= =?utf-8?B?VnVmckVCd2NLYWw5VTFIZzRhbTVNQXNDbTVmcW0wdGtLWnZ5WVJlSlA5ekNt?= =?utf-8?B?WStMMlJIZHR2VU1mUlViVnhKV0tqdjdFNGNMcm9naWdpOUg3ekl3azJNRWtl?= =?utf-8?B?QUFKbXFzVzJuRVEyTEJMUTJNNWJWMElnaFFwT2taNE1UeUxTTnF4cGQyZlpO?= =?utf-8?B?cHByMnVKTmtiNWUxK3YrU1ZPUExnOU9uRkJkKy9IUzRpckdvdUVaM0pkSk1Q?= =?utf-8?B?T2pGNWhjc05UWExqa1ZqaXFKVkNNM1RRenFsUEpnWEV1VUNIdHFIcVpBd1Ar?= =?utf-8?B?R0d2ODEyd3A3R2dSekY1dWwxS0pMN1F5dXM4dHNEekxYNjBhbjBhTEpoa05G?= =?utf-8?B?Q2doYkh1aXNlVFJadEhJdGJ5S2NqSERjZDRUUnRaSGsxSkJvcG9BZSsyVUow?= =?utf-8?B?UnhibXN3bURIZVFUeHVteUdlWnJUT1dreWhoNGFUejZzZTNMMWtJUFIrYlJQ?= =?utf-8?B?b2NnU0hqZ05OMEE1N0pHaDZCMkErVDVUTWxGT3IreG50QkZWY1RXbnlYRlg0?= =?utf-8?B?aHE4MUYzR0VQbGdYeVRkTUtseFJITkR3Y1lZbEdPK3V3WTVjQmZVWVpwc0pu?= =?utf-8?B?bkY5Ujc5bnhVN2dtUUpLbkZYbDc4U3Q1dFFIVUJUVlBmVlZZYllKbEgvQU1R?= =?utf-8?B?VS9lZ3VzK1V5cXJnODArRFRUQTUvYzNLTmZCSk1TKzBGZTVDakhXN3FPaVhL?= =?utf-8?B?VUcyU05Ta093LzVoYVp1bGFzYjE2WXU4eGx5aXJqQXRscEVxT1djUDhPWmdo?= =?utf-8?B?d1p6akczOHdrMTJ3eGtqcHE4eWdybi9kdVhoU1lPblhPaWxuSkN0S2N3U2Zu?= =?utf-8?B?TWFnWCtEMXUvUzlUSVVIVllsL1loRlhiajRqeFcyV0ROZWY3aFlqLysyOEtk?= =?utf-8?B?QTB0Y3lucElmdFdtWDlWREVVL1BHNFNhYmpoK1cvTEJmZTlDb1hXYlRWdFJP?= =?utf-8?Q?CS8LBCFb8AAYNTfY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f929019c-3aca-46cb-5889-08da2dc5c7ef X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 12:01:12.4057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8J2+Qj1IlyqCQbew8cq+swqVhPz86VMI/2mjiNOwn270v040TJVT8a1RSjPtovwZ65rExmvE5DD2u/ixmkgFiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3567 On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: > On 04.05.2022 12:30, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 11:32:51AM +0200, Jan Beulich wrote: > >> On 03.05.2022 16:50, Jan Beulich wrote: > >>> On 03.05.2022 15:00, Roger Pau Monné wrote: > >>>> On Mon, Apr 25, 2022 at 10:34:23AM +0200, Jan Beulich wrote: > >>>>> While already the case for PVH, there's no reason to treat PV > >>>>> differently here, though of course the addresses get taken from another > >>>>> source in this case. Except that, to match CPU side mappings, by default > >>>>> we permit r/o ones. This then also means we now deal consistently with > >>>>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. > >>>>> > >>>>> Signed-off-by: Jan Beulich > >>>>> --- > >>>>> [integrated] v1: Integrate into series. > >>>>> [standalone] v2: Keep IOMMU mappings in sync with CPU ones. > >>>>> > >>>>> --- a/xen/drivers/passthrough/x86/iommu.c > >>>>> +++ b/xen/drivers/passthrough/x86/iommu.c > >>>>> @@ -275,12 +275,12 @@ void iommu_identity_map_teardown(struct > >>>>> } > >>>>> } > >>>>> > >>>>> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, > >>>>> - unsigned long pfn, > >>>>> - unsigned long max_pfn) > >>>>> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d, > >>>>> + unsigned long pfn, > >>>>> + unsigned long max_pfn) > >>>>> { > >>>>> mfn_t mfn = _mfn(pfn); > >>>>> - unsigned int i, type; > >>>>> + unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable; > >>>>> > >>>>> /* > >>>>> * Set up 1:1 mapping for dom0. Default to include only conventional RAM > >>>>> @@ -289,44 +289,60 @@ static bool __hwdom_init hwdom_iommu_map > >>>>> * that fall in unusable ranges for PV Dom0. > >>>>> */ > >>>>> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) > >>>>> - return false; > >>>>> + return 0; > >>>>> > >>>>> switch ( type = page_get_ram_type(mfn) ) > >>>>> { > >>>>> case RAM_TYPE_UNUSABLE: > >>>>> - return false; > >>>>> + return 0; > >>>>> > >>>>> case RAM_TYPE_CONVENTIONAL: > >>>>> if ( iommu_hwdom_strict ) > >>>>> - return false; > >>>>> + return 0; > >>>>> break; > >>>>> > >>>>> default: > >>>>> if ( type & RAM_TYPE_RESERVED ) > >>>>> { > >>>>> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) > >>>>> - return false; > >>>>> + perms = 0; > >>>>> } > >>>>> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) > >>>>> - return false; > >>>>> + else if ( is_hvm_domain(d) ) > >>>>> + return 0; > >>>>> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) > >>>>> + perms = 0; > >>>>> } > >>>>> > >>>>> /* Check that it doesn't overlap with the Interrupt Address Range. */ > >>>>> if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) > >>>>> - return false; > >>>>> + return 0; > >>>>> /* ... or the IO-APIC */ > >>>>> - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) > >>>>> - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >>>>> - return false; > >>>>> + if ( has_vioapic(d) ) > >>>>> + { > >>>>> + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) > >>>>> + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >>>>> + return 0; > >>>>> + } > >>>>> + else if ( is_pv_domain(d) ) > >>>>> + { > >>>>> + /* > >>>>> + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o > >>>>> + * ones there, so it should also have such established for IOMMUs. > >>>>> + */ > >>>>> + for ( i = 0; i < nr_ioapics; i++ ) > >>>>> + if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) ) > >>>>> + return rangeset_contains_singleton(mmio_ro_ranges, pfn) > >>>>> + ? IOMMUF_readable : 0; > >>>> > >>>> If we really are after consistency with CPU side mappings, we should > >>>> likely take the whole contents of mmio_ro_ranges and d->iomem_caps > >>>> into account, not just the pages belonging to the IO-APIC? > >>>> > >>>> There could also be HPET pages mapped as RO for PV. > >>> > >>> Hmm. This would be a yet bigger functional change, but indeed would further > >>> improve consistency. But shouldn't we then also establish r/w mappings for > >>> stuff in ->iomem_caps but not in mmio_ro_ranges? This would feel like going > >>> too far ... > >> > >> FTAOD I didn't mean to say that I think such mappings shouldn't be there; > >> I have been of the opinion that e.g. I/O directly to/from the linear > >> frame buffer of a graphics device should in principle be permitted. But > >> which specific mappings to put in place can imo not be derived from > >> ->iomem_caps, as we merely subtract certain ranges after initially having > >> set all bits in it. Besides ranges not mapping any MMIO, even something > >> like the PCI ECAM ranges (parts of which we may also force to r/o, and > >> which we would hence cover here if I followed your suggestion) are > >> questionable in this regard. > > > > Right, ->iomem_caps is indeed too wide for our purpose. What > > about using something like: > > > > else if ( is_pv_domain(d) ) > > { > > if ( !iomem_access_permitted(d, pfn, pfn) ) > > return 0; > > We can't return 0 here (as RAM pages also make it here when > !iommu_hwdom_strict), so I can at best take this as a vague outline > of what you really mean. And I don't want to rely on RAM pages being > (imo wrongly) represented by set bits in Dom0's iomem_caps. Well, yes, my suggestion was taking into account that ->iomem_caps for dom0 has mostly holes for things that shouldn't be mapped, but otherwise contains everything else as allowed (including RAM). We could instead do: else if ( is_pv_domain(d) && type != RAM_TYPE_CONVENTIONAL ) { ... So that we don't rely on RAM being 'allowed' in ->iomem_caps? > > if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > > return IOMMUF_readable; > > } > > > > That would get us a bit closer to allowed CPU side mappings, and we > > don't need to special case IO-APIC or HPET addresses as those are > > already added to ->iomem_caps or mmio_ro_ranges respectively by > > dom0_setup_permissions(). > > This won't fit in a region of code framed by a (split) comment > saying "Check that it doesn't overlap with ...". Hence if anything > I could put something like this further down. Yet even then the > question remains what to do with ranges which pass > iomem_access_permitted() but > - aren't really MMIO, > - are inside MMCFG, > - are otherwise special. > > Or did you perhaps mean to suggest something like > > else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && > rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > return IOMMUF_readable; I don't think this would be fully correct, as we would still allow mappings of IO-APIC pages explicitly banned in ->iomem_caps by not handling those? > ? Then there would only remain the question of whether mapping r/o > MMCFG pages is okay (I don't think it is), but that could then be > special-cased similar to what's done further down for vPCI (by not > returning in the "else if", but merely updating "perms"). Well part of the point of this is to make CPU and Device mappings more similar. I don't think devices have any business in poking at the MMCFG range, so it's fine to explicitly ban that range. But I would have also said the same for IO-APIC pages, so I'm unsure why are IO-APIC pages fine to be mapped RO, but not the MMCFG range. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 12:13:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:13:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320658.541492 (Exim 4.92) (envelope-from ) id 1nmDsR-00087K-25; Wed, 04 May 2022 12:13:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320658.541492; Wed, 04 May 2022 12:13:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsQ-00087D-VE; Wed, 04 May 2022 12:13:06 +0000 Received: by outflank-mailman (input) for mailman id 320658; Wed, 04 May 2022 12:13:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsP-000875-Gc for xen-devel@lists.xenproject.org; Wed, 04 May 2022 12:13:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c1f35f3-cba3-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 14:13:03 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-eB8yswbXMuiZMSz5bl9Z7w-1; Wed, 04 May 2022 14:13:01 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB6630.eurprd04.prod.outlook.com (2603:10a6:20b:f4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 12:12:59 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 12:12:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c1f35f3-cba3-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651666383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oITOIIhNj0LUWTBHTS7HPOmnJantOOqXINRwg1eRSs=; b=XcS8b2CG1tRmnQVOT+EnPyLf8ZSe7tfc46/nXPBHHqbWfQnEjvSYJTrDNPP9z1jaLRy9Q5 8kITnNazRNRgkr+Un1RtCHi7MWULGZruFUJ726KX/6+cxg57kQrgzriuJ+KAJPFrqlIN/L F6dJVDS++ecwhBWcwA3gqdkAvsNjtoI= X-MC-Unique: eB8yswbXMuiZMSz5bl9Z7w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RrDcdguwB1tFuk1fYTsmlhU3RGvhs+WHzDfKwqyFoM/+oRB596JoUJZLJtom5fN2xo/MsSoUv/5cKYP1Qqp00qLdwaZSOwJFHb3cHwKN0YyftdaGRKPjq4XY4FjDjaEOjWxGJCyEtk3ylJFjROV1br6RpKU94N6w+wtMMFDHgXfDFVHyt3Uzf71QHHdOvmYLxmSaHAgD+9JzKJM0WQbKjCTOihcky2SpklSm4XjXSMfsC9vuZ/E+lAnBDVh1OjGSM1fEoG4P3cPqlVB3ZpJZnoMmPFFIIMJT6sZDT2yshb/lpeTSQr8bRhcRDDw4pqFdLifylmJp3492dxqaEtKs0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PA5UUpOtBj8BJ1Me5KMvvF/KdLRLs9SOHPLbpRHMCwY=; b=kFdHFOfYuAIBcb8fEJgPwWtzUY0EPEBZjDlFPkiG9f9MtT+fj86w3D6/DISgXRiVdCl+bnDLxlmnyafoZla5PntzY/5OZ6a1XMTCc5N4BQEkDsNVcwHVfi27Mi1bk/xKcNFFLVkaAa/0J+/nahgWfdhVL5mUDFw3ANxQZFP7TVvI1zHDJsB0o+MPkx7zHWnuHKZwVvZjRKSZLT1sKGMAPU9NGckDv8iPcYM1nwJ0POTnxrzEDpJT8OdP8h8vcAQNmRV2xrxa9ksavBFAmYs2K6sn3EpeLJJC/rKYEL7Ti8FMvcAcivk4u6DdgN/D4/fLSB7Z7KgXlDZZMCB0ACQVqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 May 2022 14:12:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0153.eurprd04.prod.outlook.com (2603:10a6:20b:48a::27) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5792ceb3-e8f9-4b33-9598-08da2dc76df2 X-MS-TrafficTypeDiagnostic: AM6PR04MB6630:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c76HXU57sDupC/K4Aa8rBqlxhn7WM3UhX+UgowKtuA3Bej1q6iLT3KwdDbOGflDN3VfaegVW83DvRd++o86D/frV0QyvHz43DWxIHwbZ2WTI7Xh0wJieUvaDHSyZGqKMU2OxQrEX+f1a/Dgrp3aNs+152ETr//t+cVl/NFxiLms9LhaRM2lrbgkS9Ujag8NxvDV/MjB+JUF69cCpCdlE5qGG0HA3WCTjeBJjGxIuRLvdO4qZAyk7sAHaQcNiJZXa/VDhcwsfdSDZzYbIKR4RrUheAgmuUdy2Vp2Hjfpg5p5/uz1NDnNrGeLshJa7qv8nUQTqXnco2wsaN2f9BJfrTINeRJCZh8BTgJgw54Hx965vaBmWuKn2G6x3ny4LticivEkYHmQLquU2xQNlUqSYLFTyQ81Fx84VMqkdHqrwUeQAHFIs8VdCK2SqBqEMjTDsD+QnmyIzlwKc2IOoaq/KplOVbVR4twQiszVw5IzO7HGudWRnCO71PpsaqE0F0qXUJcKRMsHNTp+75p+M8sduweGlcbVEI+Fwb4P51Twsh/tnj7YjZZRpcND7ajm7hYXHanOA8js5mZ5+9tctRD2Sgao4uLPYip8dNFFM2Rv49CaVbmSTrYCWiOQkiptVUGcyZus9unTcGMRi6/uEcKOAl+Jv/4wUih76vZLL+cK9ABSGEY9GUWwiv7iNNRFm/UZxYCOVkx/PfZMEnGE2z6UiFpqfAMEILppYaViIjVaFeCdLOdMyYQDkIfAZkeHJZl86 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(4326008)(8676002)(66476007)(66946007)(83380400001)(186003)(6506007)(2616005)(53546011)(2906002)(26005)(6512007)(8936002)(38100700002)(508600001)(5660300002)(31696002)(86362001)(36756003)(6916009)(54906003)(6486002)(316002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?brtpOyOyR7p4ZHp5vfAVMRYa44zux1NXnULlyaTxYSLej5UaCmEb0HAb9fRs?= =?us-ascii?Q?V7vo+AvSq5xuiLPDTLxpoQNsiWCPIDqL6Q73adDOGcANtKK//r0Iq8udbd96?= =?us-ascii?Q?E1Smv2ajqUOefivw14MGG+nx8EKxdzjSKta8XljmUCADkF14KP3PjZf//I8G?= =?us-ascii?Q?tyb2Bq/PZXa0tjBu+0tVbIitErnMKnbJqZx/r9nMVqkAzXA/h9ah2+Cuvg6n?= =?us-ascii?Q?wTDrH00Z1m0cPF6uIKPJ1yTFWlFa4qw1b2M6ahoRDu3KtyvJMlYYH+HdV4H+?= =?us-ascii?Q?Ta5bZ9KTlPpNF9m8KbHauHdpnsSvmRDERL2lRBGgebb/yZqqmt/0qP/AcyWf?= =?us-ascii?Q?N43BRfUrEzj065h/T30jB4ELE8FGbvRADZO/tF0Yi4Z2jPLnUTiW7HH+CbX5?= =?us-ascii?Q?SyQHXfDMKO0/PfTvX1rrqy1EPHo5SrxtqN6RJe4m7XiHptTQxXaT2BA3QCxQ?= =?us-ascii?Q?aSBfx97n4AielNma0rgkfV0CV7LJMY5j33sKMeq350j49Ub368O2OzZJkdAA?= =?us-ascii?Q?tmtHg6aQCc0aczgtsUJYMqeKkTnED7aS28pqqCXkuVp0NvYqhURti8PtPhBo?= =?us-ascii?Q?1xmtroFJZTsVAJjPzVM6kIDy94WwCqy/FTGBDAAEyl7WwfUOUySqg+SZHBkc?= =?us-ascii?Q?QGfykhyoujhFg4m0AAYlIimHc7MnDSD0LCwbC/pqWHZsUf3Ma5pzOAi2Sbfe?= =?us-ascii?Q?X+JwMhANmVoLprlXmiAco8g1k93lN4lzf6QWf/4fdZ8kXmtb8p1exd8ylJBL?= =?us-ascii?Q?/kAdz/c7RpHBg4OjeNtByE3D7WP50jxbzs7/pybR9XYnvLm5ePf6Qj4Prvps?= =?us-ascii?Q?YHzzUo8EUpcYhKgSjX7xOrMfQGiXxXeUoyl3WpJBiQfZOJVWadsqgHM7okMt?= =?us-ascii?Q?JKLm4Jn8OoJHX1LzIwHUDUo38xf0fU2Wq3I1CWuf0PWs/Jrij6MYjBBeDw1p?= =?us-ascii?Q?jLXwz/yqc5vRFHVXBY3OyB7AiF8XzTYwcCcGSQsG3SOBXq8buCTio4+gq8Bd?= =?us-ascii?Q?2oTRsmp36+Hw9J9Bw9xmUnitWbFN38U1g8pWl9Qx9YkPyTOEe2P5ETjsKGeW?= =?us-ascii?Q?OIutZ8u728G7ukqwVsL3+Vh4hP0LejCu9M86qq0mHfrjuotufXMF7EhGk2xH?= =?us-ascii?Q?6zXmoUwNZb+wUiexcHgi2jhVn6fkw+ZX8S/WR0MJWHPgEMC3LjDBq/4zj0gu?= =?us-ascii?Q?MbzKxy+s4IVwFDN+mNALmOCYVFehpt3c60lmf7DmV4t+PZAJW3byFQuGlkkq?= =?us-ascii?Q?Mv1ox/AU3uBw7S48O7iRYHcJl24RlMWLd8QczsZHNMeI4seKzwqrnnzd/wDd?= =?us-ascii?Q?MhDWAvPpirvgbtDYxDgTQSJufNKf2az2x/sleidAmYTluWZU/fIitVVdfhVY?= =?us-ascii?Q?vhROf5ALEFQTLRE9zykElk+qQ+UzygyrM/UfFP/3AiPIPhD/IJE43zO3+jS+?= =?us-ascii?Q?EglHkYX+RcKNBDDOpVoNKLKp2o1Gb54VXwpOixd0ufsW3SCs3wApe1KUPJqL?= =?us-ascii?Q?A8yOv6Uh6zY3Y2Kupg5FPFNTXY9LS8GzFQuWJnjBo0Ger2NOIi1mYUkWLBeE?= =?us-ascii?Q?l6dwoXv+ubfJmYbRMFfI19tRNmluoCq3OYDtX7UdZE+axQo9TbRxN3tYk5Gw?= =?us-ascii?Q?I0ZxhPQ9Rlo86XVqOEC7Ek1r08vY/zQlwJCZ0sGds88gvb/YbdXiHqtrGXqa?= =?us-ascii?Q?4KGeWqOy/cAVoPu7iW1N6eoCgVtdcLLeJE7DJFj6r236CWumir82m+cW97Qn?= =?us-ascii?Q?f8vrEBnGVg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5792ceb3-e8f9-4b33-9598-08da2dc76df2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 12:12:59.3796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MAwCmzxRX2fsAqrnENsZvrNSvvwq6SP3xarzTW9hxQGkGjywj/expWUvia3uMsOwuTdiycuFve4z6LORZpHDtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6630 On 04.05.2022 14:01, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: >> On 04.05.2022 12:30, Roger Pau Monn=C3=A9 wrote: >>> Right, ->iomem_caps is indeed too wide for our purpose. What >>> about using something like: >>> >>> else if ( is_pv_domain(d) ) >>> { >>> if ( !iomem_access_permitted(d, pfn, pfn) ) >>> return 0; >> >> We can't return 0 here (as RAM pages also make it here when >> !iommu_hwdom_strict), so I can at best take this as a vague outline >> of what you really mean. And I don't want to rely on RAM pages being >> (imo wrongly) represented by set bits in Dom0's iomem_caps. >=20 > Well, yes, my suggestion was taking into account that ->iomem_caps for > dom0 has mostly holes for things that shouldn't be mapped, but > otherwise contains everything else as allowed (including RAM). >=20 > We could instead do: >=20 > else if ( is_pv_domain(d) && type !=3D RAM_TYPE_CONVENTIONAL ) > { > ... >=20 > So that we don't rely on RAM being 'allowed' in ->iomem_caps? This would feel to me like excess special casing. >>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >>> return IOMMUF_readable; >>> } >>> >>> That would get us a bit closer to allowed CPU side mappings, and we >>> don't need to special case IO-APIC or HPET addresses as those are >>> already added to ->iomem_caps or mmio_ro_ranges respectively by >>> dom0_setup_permissions(). >> >> This won't fit in a region of code framed by a (split) comment >> saying "Check that it doesn't overlap with ...". Hence if anything >> I could put something like this further down. Yet even then the >> question remains what to do with ranges which pass >> iomem_access_permitted() but >> - aren't really MMIO, >> - are inside MMCFG, >> - are otherwise special. >> >> Or did you perhaps mean to suggest something like >> >> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && >> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >> return IOMMUF_readable; >=20 > I don't think this would be fully correct, as we would still allow > mappings of IO-APIC pages explicitly banned in ->iomem_caps by not > handling those? CPU side mappings don't deal with the IO-APICs specifically. They only care about iomem_caps and mmio_ro_ranges. Hence explicitly banned IO-APIC pages cannot be mapped there either. (Of course we only do such banning if IO-APIC pages weren't possible to represent in mmio_ro_ranges, which should effectively be never.) >> ? Then there would only remain the question of whether mapping r/o >> MMCFG pages is okay (I don't think it is), but that could then be >> special-cased similar to what's done further down for vPCI (by not >> returning in the "else if", but merely updating "perms"). >=20 > Well part of the point of this is to make CPU and Device mappings > more similar. I don't think devices have any business in poking at > the MMCFG range, so it's fine to explicitly ban that range. But I > would have also said the same for IO-APIC pages, so I'm unsure why are > IO-APIC pages fine to be mapped RO, but not the MMCFG range. I wouldn't have wanted to allow r/o mappings of the IO-APICs, but Linux plus the ACPI tables of certain vendors require us to permit this. If we didn't, Dom0 would crash there during boot. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 12:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320660.541503 (Exim 4.92) (envelope-from ) id 1nmDsm-000083-FS; Wed, 04 May 2022 12:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320660.541503; Wed, 04 May 2022 12:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsm-00007w-BC; Wed, 04 May 2022 12:13:28 +0000 Received: by outflank-mailman (input) for mailman id 320660; Wed, 04 May 2022 12:13:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsk-00005U-Gn; Wed, 04 May 2022 12:13:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsk-0004Gx-E9; Wed, 04 May 2022 12:13:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmDsk-0000l7-5c; Wed, 04 May 2022 12:13:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmDsk-0004Rh-5D; Wed, 04 May 2022 12:13:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hwxXF+w5EJsoRrfdR3W6rQ1BEeZdjfZBrE+C5efdnp8=; b=avwc0BhvXOLv0oS6z+jz4CGcLV vUYEXwPP9xW8p17I0EKM8Yp7nJUJZzInddCnxHym+nA6kIzyE8YRPE+jDucAFUYVv1udHc1FwBAH2 g4NExBFuwCWCqlmXJLqYBgUJrFK7/tIx7T8XJqxRAS7u1Q/820YYK/61gwytNGHyD2lE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170072: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=107c948d1d3e61d10aee9d0f7c3d81bbee9842af X-Osstest-Versions-That: linux=9050ba3a61a4b5bd84c2cde092a100404f814f31 From: osstest service owner Date: Wed, 04 May 2022 12:13:26 +0000 flight 170072 linux-linus real [real] flight 170095 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170072/ http://logs.test-lab.xenproject.org/osstest/logs/170095/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170095-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170001 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170001 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170001 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170001 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170001 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170001 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170001 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170001 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 107c948d1d3e61d10aee9d0f7c3d81bbee9842af baseline version: linux 9050ba3a61a4b5bd84c2cde092a100404f814f31 Last test of basis 170001 2022-05-02 19:09:59 Z 1 days Failing since 170053 2022-05-03 17:42:45 Z 0 days 2 attempts Testing same since 170072 2022-05-04 01:56:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Wujek Armin Wolf Denis Pauk Guenter Roeck Jann Horn Ji-Ze Hong (Peter Hong) Ji-Ze Hong (Peter Hong) Kees Cook Linus Torvalds Rob Herring Zev Weiss Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 9050ba3a61a4..107c948d1d3e 107c948d1d3e61d10aee9d0f7c3d81bbee9842af -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed May 04 12:22:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320675.541520 (Exim 4.92) (envelope-from ) id 1nmE0z-0001tW-Ec; Wed, 04 May 2022 12:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320675.541520; Wed, 04 May 2022 12:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmE0z-0001tP-Bd; Wed, 04 May 2022 12:21:57 +0000 Received: by outflank-mailman (input) for mailman id 320675; Wed, 04 May 2022 12:21:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmE0y-0001tJ-11 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 12:21:56 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on062a.outbound.protection.outlook.com [2a01:111:f400:fe08::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c81a50c7-cba4-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 14:21:53 +0200 (CEST) Received: from AM6PR0502CA0050.eurprd05.prod.outlook.com (2603:10a6:20b:56::27) by AM6PR08MB3638.eurprd08.prod.outlook.com (2603:10a6:20b:4b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 12:21:52 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:56:cafe::80) by AM6PR0502CA0050.outlook.office365.com (2603:10a6:20b:56::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25 via Frontend Transport; Wed, 4 May 2022 12:21:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 4 May 2022 12:21:51 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Wed, 04 May 2022 12:21:51 +0000 Received: from d62a3791ed95.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9D9AC6B8-BDA0-4959-A596-7012BAA79B5D.1; Wed, 04 May 2022 12:21:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d62a3791ed95.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 May 2022 12:21:39 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com (2603:10a6:203:4c::14) by DB7PR08MB3578.eurprd08.prod.outlook.com (2603:10a6:10:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14; Wed, 4 May 2022 12:21:36 +0000 Received: from AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938]) by AM5PR0801MB2020.eurprd08.prod.outlook.com ([fe80::6c39:76a0:c05c:2938%11]) with mapi id 15.20.5206.024; Wed, 4 May 2022 12:21:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c81a50c7-cba4-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QAw4A3ql79FmKia3EbNbDjTpo/5Lxx+ssUn2OOjRZz2WG+ocD/dYthrIH74oh62RRkZQw2q/i1E6pwAGZnteaDPYNlqRUiUNp4o8cTLodbXbI/KZ9ADyu6p7iFWWTAEhJ3rmq8NA/mYvf8Rcp4+EzpQf1owEfZbJTZuR0toqNEMEBwCthZaDZyJ4gI9s2tJhXtnwcOOS5Z8vYsCI8DzjHIsZn6tvbfXlVXHX50mEJk5ISho6ROo6pVAlPOhztb9zxjjc/KektrbDSh2tbWvWIXIiFHnqHuuriK/sPxsgFEBtvRuMS56jz6Bog616tTQPGc2mgYtKJXb/JeeE41rMdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXi5+ByetQA4DsgMU9oucBblz1aUs+i897kCw50ipuA=; b=Ne1nbgg3mZSgTOL1fhFoaRQRlV3A8QLBZWJQ4KifpmkN1M55QwydAu51bcJgbFG/EbR/AEDu+fM4ijw5suwKccXkYSzQqM3LFc08sTgve8J9Qa0mdIPsRV3+DRRm6pRWQtI2RZ5iHWDGV644mmv9liwCa4h3ofAO37X1h2ibpOYgUSACto17QATRpHzXPl3uMfJA1NvnEM66b/P3KMjq325+ZODNwMZ06I+HZ9+emgM7EckwJNM2GyNGdKVE42bjOpvHwM5wcCqrbP+64eeTEGUWVz0k1n/Vt4cciNSedckavHFU1KNCXCSHL38EZNzaoz6VOguaunNxJGDPwa9UtQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PXi5+ByetQA4DsgMU9oucBblz1aUs+i897kCw50ipuA=; b=eTOdwOoG/1iuAxZulLSg0JXxlZs1iYoj/dX/za3xKxDZ4kvMZoDQgQqLm2jWed1FzdB4cEo++g9NP0UKb5VEZbQ0Vr6T02U2jaez0UXyi/dppSIxTabHepC6wl3CChxtTI3epe15oGPTQwy+mfeZSaxaexOwpcWWFtfQPmos5qA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: f9449c6b2f052471 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqhukKvyl0IiNt/IKDFFIxjW9dtn8whQIrP6HHFLtyyAbx5j97ppRE3AmitupaTfGzyi2TKRL4Q4l94MGTAFQr6bfxtIHw5OEpm6fkb5iZLw0DAISk31M2MtJApxVAwseRKOoqy4d+Np8uZnhx2Zk6OSfm+o2U31sz0/eGJeCoRJA2tX8nJQH9ibyip/WobgtePhRfI+pna1lSy73UD7h/QbNBueVgLkZ/l000ghCzgIV5aMGxPGX5BY1WZ10CiNSqz60Fw206HCgAYLDio3nN9jCS9LMQHofsmJ49bVunuJiJpvVEtycpRXKfEa+We/EKp1tqc87AFy6a4kPblaJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXi5+ByetQA4DsgMU9oucBblz1aUs+i897kCw50ipuA=; b=nH1dB2nTPPkZGzjpe01Wa77DFJPoFFtKjH2HlSwQYczK7dcFFhw6ukTAmUytqP/vM1I2CAZRQLWl4VDSGM9u4+SDtM7h+N9qN7fNa9Zy59R9DPGxEeGYqJJxq7ytW+79vRGrV+fK3sBH08wa1h1niZsZ788XC4cxi0OzySDZKhH5QXfPMXKtXMub6LpuuEaM9EdMI9bdo4FN+qxKqCteOwr+MwuczBbP+t1JA4ylm0PcMXqHAsIDLjcTAJVaBZzR+vbqZbo0GrMKrdOUeBed+Yq6hXd+4QVCX+aKvje81LGl2LP9p2+vjZ6vfsepGYRbBoQeGtaj81WFkJV0wjs1sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PXi5+ByetQA4DsgMU9oucBblz1aUs+i897kCw50ipuA=; b=eTOdwOoG/1iuAxZulLSg0JXxlZs1iYoj/dX/za3xKxDZ4kvMZoDQgQqLm2jWed1FzdB4cEo++g9NP0UKb5VEZbQ0Vr6T02U2jaez0UXyi/dppSIxTabHepC6wl3CChxtTI3epe15oGPTQwy+mfeZSaxaexOwpcWWFtfQPmos5qA= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Topic: [PATCH] arm/its: enable LPIs before mapping the collection table Thread-Index: AQHYWlHsf41jIOfeQ0mX6M++noloAq0NWJOAgAFGKQCAAAlngIAABjSA Date: Wed, 4 May 2022 12:21:35 +0000 Message-ID: References: <7762e8e35be1f99f2a7ca81aa8cf8fc502030e7b.1651075773.git.rahul.singh@arm.com> <66A4F1AF-9539-497E-A777-316D1C21E1F4@arm.com> <0bab2226-fcce-6525-323f-c95d951e6696@xen.org> In-Reply-To: <0bab2226-fcce-6525-323f-c95d951e6696@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ce756cee-aec0-449b-1477-08da2dc8ab33 x-ms-traffictypediagnostic: DB7PR08MB3578:EE_|VE1EUR03FT049:EE_|AM6PR08MB3638:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LlOPiwC2VoNSCLdl0IaskwHc1F4l6kCapgKMf63l5OaaMjihghzItSjAg+6BkAwyvnJlFuPgYl3QZeq4UfEEDSPGrKF1KEPGkEG2ePpXktAkZ173ZsirYZxN4/GQ3M9OBSt+S4LfLGnl8Grz9eMNtbONWxSVDH0Lt9p27xkdhwrnPNz3bfJN3mWGBa47EwqiigUPKwLUzqsA50redIyKSYjF3Az7d/jdi6WE/zg7eLJm2zfOBoyFleL+L5cXdXTqSxx/br+OvDCbG49PmlQruUvfnudR2vl6f/I8oW7PsKVz3lENlop2mmvdukyvnf5cejK1jeswk6UPm/XglIszUx1cshbjSd4KVlCWJRqBxJqO15Mj3oJBzAVl6vrWKFYxl+/P1Bk6re4m9tvNv+gPhlntTsLl1yoo1WaaLEegkaG1KdilkfTFCNfMEexEo4qfLTR0j5JTLq4svKs5ohfhAKjSUSZjnX661BwzfmIIEDwTjpmJu1BHer/m4bUtVFD+7aRyfdH6bnqjh9Eya5MvYrNk/naxEkyH6Hql7HGFZjDtxLEUilb3Qdh2ctLJYl0R0b0kHi5ST/qxKpBPHshe35QonAzy3vUF4nEfKVteb4lGQsaH+inkV9VEX5oR2RAcUWoi+F9XW83wKwyH5aUJCpm3znTriIW0zOwjwu/bhIlM+n/nX0n1MdKSRr9df7vIE482DnaUXOkdcHEGx8bUwy6x1MkACvMuhYuMYUK6nV24GjIMaXaQ1XxU1jVpbA5P X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB2020.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(66446008)(64756008)(8936002)(83380400001)(66556008)(76116006)(8676002)(26005)(66476007)(4326008)(66946007)(6512007)(33656002)(38100700002)(38070700005)(6916009)(316002)(54906003)(53546011)(6506007)(71200400001)(5660300002)(6486002)(2906002)(86362001)(36756003)(508600001)(186003)(2616005)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <9F1C286DA2D3D448B93A90C5F528A00B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3578 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f204800-54bf-40a2-838d-08da2dc8a1e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DWPBnEPqKzeyGoZ3Enm3kjdJnu8Z+Y2yXW+BVM9g5ngyTytHIadS2DSc94k8lak5vgh7uinX0bzMw+n/L1b9BwNIlJ5WGLX+cDKGHX+cnKnQ3m/rIRzmPFCSEWQFeBG+DTZ+Ac84OEpNO1ZwvBZadPh5CgX7vOH/jaeWYmxTWTMpgfdh6cxlqmt3msNHewVGkdIC/UlqXIpFRx2lAuTAUR0C6+Hw3vRfw/GibEnOSkepEXBJnwglDl+/TPAjL8CvXV8n7hy7dYuX4AaRcrOB4Sp/Qk9KY7N+UDAI/1J4NrxyWDz7y1oUQrOr2HuADP4H52rmmcCLq6DgWLeszK4jAELgrEQw1n9akTx+31WLbmDkZC+rz9ABexWt/Db6Z8myxxMpoUO18ZJAXRqB29V4zKczr88BBoX1fJv6jxW2cYaaneA+1HnWMqwxw26s1fMLJUDoJxVD+ZcNj/xHFNDs+GxSNWhDriYeNYHtAhgsMxcu+LY2JiRqyQ3gp+RuMD4fcQdSwx4/e+eQJ8r22LBCFSbjP6qtDi0IZ7NbAwWH8WIknQSBhpaNfCxOy2Se9VgeZcjuzeq9WZr+aWXd01zkVZClhdcYP49OKY4B1FxnGpTTZosleIIYUmn4NkngkEtk4LSXKoOFuiOc7Hku2t9QJhEXDC52bynaGNvKg5IAGwrfJVimQOI/RjZPxp9HMtEm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(5660300002)(356005)(8936002)(81166007)(86362001)(508600001)(36756003)(6486002)(2906002)(186003)(33656002)(2616005)(336012)(82310400005)(107886003)(6512007)(83380400001)(40460700003)(6506007)(26005)(47076005)(53546011)(36860700001)(4326008)(6862004)(316002)(70206006)(54906003)(70586007)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 12:21:51.4369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce756cee-aec0-449b-1477-08da2dc8ab33 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3638 Hi Julien, > On 4 May 2022, at 12:59 pm, Julien Grall wrote: >=20 > Hi, >=20 > On 04/05/2022 12:25, Rahul Singh wrote: >>> On 3 May 2022, at 4:58 pm, Julien Grall wrote: >>> On 27/04/2022 17:14, Rahul Singh wrote: >>>> MAPC_LPI_OFF ITS command error can be reported to software if LPIs are >>>> not enabled before mapping the collection table using MAPC command. >>>> Enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collecti= on >>>> table. >>>> Signed-off-by: Rahul Singh >>>> --- >>>> xen/arch/arm/gic-v3.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >>>> index 3c472ed768..8fb0014b16 100644 >>>> --- a/xen/arch/arm/gic-v3.c >>>> +++ b/xen/arch/arm/gic-v3.c >>>> @@ -812,11 +812,11 @@ static int gicv3_cpu_init(void) >>>> /* If the host has any ITSes, enable LPIs now. */ >>>> if ( gicv3_its_host_has_its() ) >>>> { >>>> + if ( !gicv3_enable_lpis() ) >>>> + return -EBUSY; >>>=20 >>> gicv3_enable_lpis() is using writel_relaxed(). So in theory, the write = may not be visible before gicv3_its_setup_collection() send the command. >> Agree. >>>=20 >>> So I think we need to add an smp_wmb() to ensure the ordering with a co= mment explaning why this is necessary. >> Or maybe be we can change the writer_relaxed() to writel() that will als= o work. >> - writel_relaxed(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_= CTLR); >> + writel(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR); >=20 > writel() guarantees the previous writes are observed before this write. B= ut it would not guarantee that the write will be observed before the ones a= fter. >=20 > Also, after further thoughts, I think this wants to be wmb() (system-wide= ) rather than smp_wmb() (innershearable). >=20 Ok. I will use the wmb() and will send the next version. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed May 04 12:27:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320682.541531 (Exim 4.92) (envelope-from ) id 1nmE6F-0002bW-AS; Wed, 04 May 2022 12:27:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320682.541531; Wed, 04 May 2022 12:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmE6F-0002bP-7A; Wed, 04 May 2022 12:27:23 +0000 Received: by outflank-mailman (input) for mailman id 320682; Wed, 04 May 2022 12:27:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmE6D-0002bH-Ot for xen-devel@lists.xenproject.org; Wed, 04 May 2022 12:27:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ac3316f-cba5-11ec-a406-831a346695d4; Wed, 04 May 2022 14:27:20 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-5WsEpDGDN9usLJanCc4cwg-1; Wed, 04 May 2022 14:27:17 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB6PR0401MB2423.eurprd04.prod.outlook.com (2603:10a6:4:4a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 12:27:16 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 12:27:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ac3316f-cba5-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651667239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T64vUcl2cITlN8kw2alyFq0hnF6Tt8pAGQC7aNyyV0c=; b=iAHKqXljsvsGQnl9U8sy0MWxJnbo5nnz+ElZ9BDIkZ3zx1db4qa3IDLuxgPfMJyvpOWTNv yCpvA4uwFpj51PeISB/WVwz39x9lXaik5PuLU6sqgP2W7srkp+qbgPSsnK+Q6NJD33Zl28 lD0cb5bQwvEbM6o7f5ucC3QJeUdr9OY= X-MC-Unique: 5WsEpDGDN9usLJanCc4cwg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bht570VS3z7fLjIsDFX0khUuSufN/U/raUNVOulikpGF4IRLPuGsZ5yzDRHqCRbMw1v+lzByG4P6833vs4HRH6CqTSAFmDBocJv2vFBPMEzbO7cfIJe2j3UKHck37UJIbOuxePbHkv/vevHwBgmHgFSgJQ5uaz6YMzWvXf5jIjceqw3d5K/9fAY/NihvH2Q7qkvDLshitxXgJf9gGG4BUoN1Ulz9TYKzYLwBwWOZA60mkqZO681IJitWN/4pI9m42PJ7W6OndLMgz70Bdo/Q4JBLG1mdxWTIe3jCMvmoWXWgWshUN26No7a+SLkdInsFepKBh9GluIfdzH5wGRSiZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JoiT2BJkTZzhDs6QCYmjh86fvZROusCbPCGoXiSewzY=; b=PzMR9swBkyIi3G8aKpJ2XUaRow0BN3+Oj1ctrENa4tuli95nKrX9UE7sK9rxLCgiXk5KOkQBed8u9Sr89jSL5tstG8Go6EZNUCgysjaToQqX7jeNy3B/eVwfNjj/opqyPvNemFglpcPxvCtl5xqlntouxyIaI+0+IWXlMp133rIB9GlScJpSN49bg24GRDiKdyqJND7oWOHuGA7f/r8hPPyCIwYLvQl9FR1rAX5eV9KqoHBW+0EQwWkFHR5Icpe1G2Pf8mz/wa89IIuPQ0DG1iy3/1ANIZUlkyQM8Ii6ZLMDXlc2CkDSq7sieYaVxl5cEvxuYCi/Hi61vH1LttO3Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7675bc21-e951-0d75-844c-94ddf47dd343@suse.com> Date: Wed, 4 May 2022 14:27:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR0301CA0013.eurprd03.prod.outlook.com (2603:10a6:20b:468::13) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e4ad616-0896-4da5-f681-08da2dc96c5c X-MS-TrafficTypeDiagnostic: DB6PR0401MB2423:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: keSkOfMrtorves7Fv69vhXpEvCxX6R/QfQeum/on9Dp5IUGbIdyL42rOL/G4LOBdLbjlagF235CjarKQEEwy8zN1DySkLe5nfmUsUrxr4CZqkH7jcXmL75BJiZ5Q4qysX11i+MoQoTNoFRZ5mgHGT+AqfOFTVSD3O/bOhRKnbD4c6XW01h6DyJIclqzdVbLAwscn4dWWlMjRLCcm+qxBHCZ3LaS1fW1thdMaOFk41bCuyyxiVcXlD/Sy7SCmRTdBWXY3AuGqQD0o91N5bDcU8bbyaWy+DC1TToMlHQZOhA6GD/VKLy55fJtfC1Eu1hkQ5H9A7XSzZFfA073EWFOi8v3GEkXHDyPl/T64Al76lAOAe3Z+o7D27jyksu96k4zHwGx4oKs61bGiGiHsPUl1/a5KuR54cvJmaPuVhxyj+xG5by4borKtyEijnEusjAnrEvJ3hfGFCZYf0r31zhzjMlhcRHxa339aqumu5wBzmfQqmzdwLjtVqCTf1s9/Qy0SACFbajCz7epy2DcYZJ3/TtydW3OywqRNI2pmLFnikAACt15nUJ5gLz9lRmA8SHgt9YCjZ4hf+AOxITq0Nflm2Lk6cQhK4txJyrdwGIuTq9lmcUgH1k5hB05N75SXoXUwi6dnUyzxP8cVpr/tcDfEC+AAk5x5Rbyh+rxbeR6FbOqWqHjY5oAGI7vSq1fpqw/6Q4NIGF5BBZ1KDSraBSbb7fa93LAfaVOewvCbf7NY7ifD9miWxw3v1iddSAWYDGq0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(53546011)(6486002)(38100700002)(2906002)(31686004)(6506007)(8936002)(508600001)(4326008)(86362001)(6916009)(6512007)(2616005)(186003)(54906003)(26005)(5660300002)(31696002)(316002)(66946007)(8676002)(83380400001)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zX6jB/88jOsZpk6ynL4p7kX1IEwSwMx8yMwoWleWhcDyXqDE4RflV3qF20RJ?= =?us-ascii?Q?H0tCmYO4m3Cs38n6lQ2OConHDCH2xHgUC/Wgt99R3biL5XQlT/x9rKwqAqPw?= =?us-ascii?Q?FU7N7a9UPKvNgAQ9v699BUu4zvugl+Tnua7c8olEN5FtWRFZeNwYJGg96SKk?= =?us-ascii?Q?8sGHxsWa0kYyI4+7m/keCTe6nSqMrXDd1aTpUKw+Vm7AFHA96ZZYXd2VEfpT?= =?us-ascii?Q?Eedenay0I8O8F8Kj0XbPRkLG3HaYFTNTMJlUucF0pL0R1SQVEoy3S/InJOAI?= =?us-ascii?Q?UIkTx4wGsBzN3vEP+vKU+GqZOzxnUUHyAjlvtDzQLuGqwOOsxcY2DfKo7pj0?= =?us-ascii?Q?gPdPJdLsat4vW+ML4FeFX2lt57zsd116/ClJjeUd6q55A7q7MPjDjP9U/Z8X?= =?us-ascii?Q?7uO8saQwPFok1e7cs7qi4jIdZDKNFvBtOoX4724xOKMzuPZ5SC/ipkwN5N1J?= =?us-ascii?Q?okh59r4tYgyPMuF/YPpmK3Jdmm4Tr/h8T7NgB7Pa3ygpLsne2u9aR6cEktV0?= =?us-ascii?Q?n+rfWeXoKeawEZ08NXWEQwfpceJYa+oCXADz2ZXRq2vXmmKz0oGhus9HbB3D?= =?us-ascii?Q?3uZX9huS/HE2nKHNpgAvKHrkWZKh/j6dTDtfVxd+bM9EYybTPSAADODO7xR4?= =?us-ascii?Q?HhLeIMIOnjLkfVaP52tc6Tz28q8dAo+hZ8cMwHBAc8oeBYxCEJ7kMm5mzL82?= =?us-ascii?Q?5LZeZQazBvSCwhV3jXQWII8HlZ1Q6tlmYhkPdn5CHGuyvxvSYulG1Ocp/7oG?= =?us-ascii?Q?5gK3avMBpTUgP2s5P4GX2IoJIc7kK/7fXukikgtzTl30QBIVtQhCR7cuaiXc?= =?us-ascii?Q?gQD4FFXORr+WAHydaOEspa8VBq3I8W5I6Ra+FRSjgEhBgf3tz7ikGWScUFoq?= =?us-ascii?Q?VjZg2oB/wJL/BTUusQDaUyyQOMWuKOPKD9JSa1+gzH2zOGvAPXq2Fm3aUei0?= =?us-ascii?Q?rgxZri3ijxDV8/35JA0n06cDjxfvvApZdSxABWeEnEFf+PO2r+aBjeBou43f?= =?us-ascii?Q?XIrOiFe1RcN7YIpdz/9mad98N3UPxbhDeftRYRP13memFfhgQMlkxxskpc6C?= =?us-ascii?Q?fJkIv1C3+pfyvuQAgrNS4zVtBYLWQ83U6E3xln469clbGfzp6OVMr5xCXObm?= =?us-ascii?Q?lr3N0a53ymrCnWtvEFOgiF6NGKCIUtHnWbQHbreXCYvufcEDvZ8PA+/Nux7D?= =?us-ascii?Q?Hal8cDYLfg6vRKAX32gpb26Bfyzg1a8uxVVszOJU36saluadUn0SFq5/Fope?= =?us-ascii?Q?ZiqiG2tpHW29UVHcqyvuzmfULMduPzVXU3gOJePJvCe7QWPTeaQRkSwffHA2?= =?us-ascii?Q?CHZJ/5nAdX72HsVJp64hg+kIqVSFm2a30eF6wNPjGaVc4FFV20OnWOoEryVY?= =?us-ascii?Q?oCmjKSb8VOBkP3Q8Hc4GHvpOlhC6M7h7tQD3gqgdLSRkZxCXwcOjmUXyzNHy?= =?us-ascii?Q?GDkbWTFCYWsODCtkb6xDdSj+cgP9suFQ+UpV1mlW+mbTgpA6MCQOiCU3iUlr?= =?us-ascii?Q?3AzB+eWy1qnHzCKYkOwTPNz35cVxMMclUBfQ/9JSVrmUv/XQduS+nm+GVV4y?= =?us-ascii?Q?G1Z6fPVv82Aczt1EPpHRNrFTn6AR6yzU10XvWK0OYPaG9Q+zhSISa9uEns+b?= =?us-ascii?Q?vXBZ9iyATXNtlepLB6qrRAAhqQo0qEfsazbPzrbckKrj7lwwsCHlQq90NB4e?= =?us-ascii?Q?sOEz/UFRh7+yTD+vQq4iyzY6Y1VUXANypNHz8m/yu8YTMcRUHEcslSNeU4dr?= =?us-ascii?Q?GevoxQw8wg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e4ad616-0896-4da5-f681-08da2dc96c5c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 12:27:15.7148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pjd6s8Hk7gsMB2fYV9CfSxH0PKow4w4lP3mlpmdtuYGgxGFELqcJJrLhetQwAxSVA3FEkJ7RZUewHRRC95bD9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2423 On 04.05.2022 13:20, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 11:46:37AM +0200, Jan Beulich wrote: >> On 03.05.2022 16:49, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: >>>> For large page mappings to be easily usable (i.e. in particular withou= t >>>> un-shattering of smaller page mappings) and for mapping operations to >>>> then also be more efficient, pass batches of Dom0 memory to iommu_map(= ). >>>> In dom0_construct_pv() and its helpers (covering strict mode) this >>>> additionally requires establishing the type of those pages (albeit wit= h >>>> zero type references). >>> >>> I think it's possible I've already asked this. Would it make sense to >>> add the IOMMU mappings in alloc_domheap_pages(), maybe by passing a >>> specific flag? >> >> I don't think you did ask, but now that you do: This would look like a >> layering violation to me. I don't think allocation should ever have >> mapping (into the IOMMU or elsewhere) as a "side effect", no matter >> that ... >=20 > Hm, I'm certainly not that familiar with PV itself to likely be able > to make a proper argument here. I fully agree with you for translated > guests using a p2m. >=20 > For PV we currently establish/teardown IOMMU mappings in > _get_page_type(), which already looks like a layering violation to me, > hence also doing so in alloc_domheap_pages() wouldn't seem that bad if > it allows to simplify the resulting code overall. That's a layering violation too, I agree, but at least it's one central place. >>> It would seem to me that doing it that way would also allow the >>> mappings to get established in blocks for domUs. >> >> ... then this would perhaps be possible. >> >>>> The installing of zero-ref writable types has in fact shown (observed >>>> while putting together the change) that despite the intention by the >>>> XSA-288 changes (affecting DomU-s only) for Dom0 a number of >>>> sufficiently ordinary pages (at the very least initrd and P2M ones as >>>> well as pages that are part of the initial allocation but not part of >>>> the initial mapping) still have been starting out as PGT_none, meaning >>>> that they would have gained IOMMU mappings only the first time these >>>> pages would get mapped writably. Consequently an open question is >>>> whether iommu_memory_setup() should set the pages to PGT_writable_page >>>> independent of need_iommu_pt_sync(). >>> >>> I think I'm confused, doesn't the setting of PGT_writable_page happen >>> as a result of need_iommu_pt_sync() and having those pages added to >>> the IOMMU page tables? (so they can be properly tracked and IOMMU >>> mappings are removed if thte page is also removed) >> >> In principle yes - in guest_physmap_add_page(). But this function isn't >> called for the pages I did enumerate in the remark. XSA-288 really only >> cared about getting this right for DomU-s. >=20 > Would it make sense to change guest_physmap_add_page() to be able to > pass the page_order parameter down to iommu_map(), and then use it for > dom0 build instead of introducing iommu_memory_setup()? To be quite frank: This is something that I might have been willing to do months ago, when this series was still fresh. If I was to start re-doing all of this code now, it would take far more time than it would have taken back then. Hence I'd like to avoid a full re-work here unless entirely unacceptable in the way currently done (which largely fits with how we have been doing Dom0 setup). Furthermore, guest_physmap_add_page() doesn't itself call iommu_map(). What you're suggesting would require get_page_and_type() to be able to work on higher-order pages. I view adjustments like this as well out of scope for this series. > I think guest_physmap_add_page() will need to be adjusted at some > point for domUs, and hence it could be unified with dom0 usage > also? As an optimization - perhaps. I view it as more important to have HVM guests work reasonably well (which includes the performance aspect of setting them up). >>> If the pages are not added here (because dom0 is not running in strict >>> mode) then setting PGT_writable_page is not required? >> >> Correct - in that case we skip fiddling with IOMMU mappings on >> transitions to/from PGT_writable_page, and hence putting this type in >> place would be benign (but improve consistency). >> >>>> Note also that strictly speaking the iommu_iotlb_flush_all() here (as >>>> well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be >>>> needed: Actual hooking up (AMD) or enabling of translation (VT-d) >>>> occurs only afterwards anyway, so nothing can have made it into TLBs >>>> just yet. >>> >>> Hm, indeed. I think the one in arch_iommu_hwdom_init can surely go >>> away, as we must strictly do the hwdom init before enabling the iommu >>> itself. >> >> Why would that be? That's imo as much of an implementation detail as >> ... >=20 > Well, you want to have the reserved/inclusive options applied (and > mappings created) before enabling the IOMMU, because at that point > devices have already been assigned. So it depends more on a > combination of devices assigned & IOMMU enabled rather than just IOMMU > being enabled. >=20 >>> The one in dom0 build I'm less convinced, just to be on the safe side >>> if we ever change the order of IOMMU init and memory setup. >> >> ... this. Just like we populate tables with the IOMMU already enabled >> for DomU-s, I think the same would be valid to do for Dom0. >> >>> I would expect flushing an empty TLB to not be very expensive? >> >> I wouldn't "expect" this - it might be this way, but it surely depends >> on whether an implementation can easily tell whether the TLB is empty, >> and whether its emptiness actually makes a difference for the latency >> of a flush operation. >> >>>> --- a/xen/drivers/passthrough/x86/iommu.c >>>> +++ b/xen/drivers/passthrough/x86/iommu.c >>>> @@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i >>>> =20 >>>> void __hwdom_init arch_iommu_hwdom_init(struct domain *d) >>>> { >>>> - unsigned long i, top, max_pfn; >>>> - unsigned int flush_flags =3D 0; >>>> + unsigned long i, top, max_pfn, start, count; >>>> + unsigned int flush_flags =3D 0, start_perms =3D 0; >>>> =20 >>>> BUG_ON(!is_hardware_domain(d)); >>>> =20 >>>> @@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init( >>>> * First Mb will get mapped in one go by pvh_populate_p2m(). Avoi= d >>>> * setting up potentially conflicting mappings here. >>>> */ >>>> - i =3D paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; >>>> + start =3D paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; >>>> =20 >>>> - for ( ; i < top; i++ ) >>>> + for ( i =3D start, count =3D 0; i < top; ) >>>> { >>>> unsigned long pfn =3D pdx_to_pfn(i); >>>> unsigned int perms =3D hwdom_iommu_map(d, pfn, max_pfn); >>>> @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( >>>> if ( !perms ) >>>> rc =3D 0; >>>> else if ( paging_mode_translate(d) ) >>>> + { >>>> rc =3D p2m_add_identity_entry(d, pfn, >>>> perms & IOMMUF_writable ? p2m= _access_rw >>>> : p2m= _access_r, >>>> 0); >>>> + if ( rc ) >>>> + printk(XENLOG_WARNING >>>> + "%pd: identity mapping of %lx failed: %d\n", >>>> + d, pfn, rc); >>>> + } >>>> + else if ( pfn !=3D start + count || perms !=3D start_perms ) >>>> + { >>>> + commit: >>>> + rc =3D iommu_map(d, _dfn(start), _mfn(start), count, star= t_perms, >>>> + &flush_flags); >>>> + if ( rc ) >>>> + printk(XENLOG_WARNING >>>> + "%pd: IOMMU identity mapping of [%lx,%lx) fail= ed: %d\n", >>>> + d, pfn, pfn + count, rc); >>>> + SWAP(start, pfn); >>>> + start_perms =3D perms; >>>> + count =3D 1; >>>> + } >>>> else >>>> - rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORD= ER_4K, >>>> - perms, &flush_flags); >>>> + { >>>> + ++count; >>>> + rc =3D 0; >>> >>> Seeing as we want to process this in blocks now, I wonder whether it >>> would make sense to take a different approach, and use a rangeset to >>> track which regions need to be mapped. What gets added would be based >>> on the host e820 plus the options >>> iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes >>> based on the logic in hwdom_iommu_map() and finally we could iterate >>> over the regions afterwards using rangeset_consume_ranges(). >>> >>> Not that you strictly need to do it here, just think the end result >>> would be clearer. >> >> The end result might indeed be, but it would be more of a change right >> here. Hence I'd prefer to leave that out of the series for now. >=20 > OK. I think it might be nice to add a comment in that regard, mostly > because I tend to forget myself. Sure, I've added another post-commit-message remark. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 12:46:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 12:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320688.541542 (Exim 4.92) (envelope-from ) id 1nmEP0-00056D-UG; Wed, 04 May 2022 12:46:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320688.541542; Wed, 04 May 2022 12:46:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEP0-000566-RF; Wed, 04 May 2022 12:46:46 +0000 Received: by outflank-mailman (input) for mailman id 320688; Wed, 04 May 2022 12:46:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEOx-000560-GH for xen-devel@lists.xenproject.org; Wed, 04 May 2022 12:46:46 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ecbb5fa-cba8-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 14:46:42 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nmEOH-0003Ke-Oi; Wed, 04 May 2022 14:46:02 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ecbb5fa-cba8-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UDxTzr/LbFPHIhZF1U36kLmGFtpbBGYhm6tD7CfQBjM=; b=KDrxDW8Mnr1qToRh0yGaDv25Fu TWpgQRScRF3dRjjU3pakegMZLqUHmycIdjATA6DbY60uPfya2zQOAwJ0e5erFJc5BJn7o3eV3sQ41 Tox4yunn4/jA8a3IjyUJT/sI3KcoYtb2p2FNUwcMM3f1g/ex9W0DrY0odKixjZjudGtrtbA3G1JPw m7Nny7DVsQFLh+HpvU/q7Yc8/k1hRGwJeSWIAUBYmqnc5ZdThCMVxiKgVNOsyAMWZdrNHmIgXn40c w6AF2HzVr+D+OvvIusg4XzuOUWHoF2AYp44ZOOo2CAb1BDljEp1qf8qc23J8WoJ9sqhtbxFJxmFVB 8aeUFBag==; Message-ID: <9581851d-6c61-a2ef-a3c4-6e2ce05eab12@igalia.com> Date: Wed, 4 May 2022 09:45:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Content-Language: en-US To: Evan Green Cc: Andrew Morton , bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/05/2022 18:56, Evan Green wrote: > Hi Guilherme, > [...] >> Do you agree with that, or prefer really a parameter in >> gsmi_shutdown_reason() ? I'll follow your choice =) > > I'm fine with either, thanks for the link. Mostly I want to make sure > other paths to gsmi_shutdown_reason() aren't also converted to a try. Hi Evan, thanks for the prompt response! So, I'll proceed like I did in s390, for consistency. > [...] >> Reasoning: the problem with your example is that, by default, secondary >> CPUs are disabled in the panic path, through an IPI mechanism. IPIs take >> precedence and interrupt the work in these CPUs, effectively >> interrupting the "polite work" with the lock held heh > > The IPI can only interrupt a CPU with irqs disabled if the IPI is an > NMI. I haven't looked before to see if we use NMI IPIs to corral the > other CPUs on panic. On x86, I grepped my way down to > native_stop_other_cpus(), which looks like it does a normal IPI, waits > 1 second, then does an NMI IPI. So, if a secondary CPU has the lock > held, on x86 it has roughly 1s to finish what it's doing and re-enable > interrupts before smp_send_stop() brings the NMI hammer down. I think > this should be more than enough time for the secondary CPU to get out > and release the lock. > > So then it makes sense to me that you're fixing cases where we > panicked with the lock held, or hung with the lock held. Given the 1 > second grace period x86 gives us, I'm on board, as that helps mitigate > the risk that we bailed out early with the try and should have spun a > bit longer instead. Thanks. > > -Evan Well, in the old path without "crash_kexec_post_notifiers", we indeed end-up relying on native_stop_other_cpus() for x86 as you said, and the "1s rule" makes sense. But after this series (or even before, if the kernel parameter "crash_kexec_post_notifiers" was used) the function used to stop CPUs in the panic path is crash_smp_send_stop(), and the call chain is like: Main CPU: crash_smp_send_stop() --kdump_nmi_shootdown_cpus() ----nmi_shootdown_cpus() Then, in each CPU (except the main one, running panic() path), we execute kdump_nmi_callback() in NMI context. So, we seem to indeed interrupt any context (even with IRQs disabled), increasing the likelihood of the potential lockups due to stopped CPUs holding the locks heheh Thanks again for the good discussion, let me know if anything I'm saying doesn't make sense - this crash path is a bit convoluted, specially in x86, I might have understood something wrongly =) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 04 13:01:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:01:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320698.541552 (Exim 4.92) (envelope-from ) id 1nmEcx-0007WR-5t; Wed, 04 May 2022 13:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320698.541552; Wed, 04 May 2022 13:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEcx-0007WK-2t; Wed, 04 May 2022 13:01:11 +0000 Received: by outflank-mailman (input) for mailman id 320698; Wed, 04 May 2022 13:01:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEcu-0007WE-Vh for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:01:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e5fb5ce-cbaa-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 15:01:02 +0200 (CEST) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 09:00:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6638.namprd03.prod.outlook.com (2603:10b6:510:b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 13:00:54 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 13:00:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e5fb5ce-cbaa-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651669262; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=CDoiQVZPuhqD8N8J+i75fs3R+yfTIdF9pOhQKig9Haw=; b=OhAL7EXn1OrEpZDWr+1+vL7FXl8ffiLT0VULuKg5r9sfLyr7PUeOCBVz rcGkVSHP4TQDPlcjBHjKYM9db+V9kGQneETTRwkw/mzZKlLqxg+aWuSzB BSro+VbZE+NO4ZOQP6QKJewreVouTl5BPThG5RXh76iMMojIuLkhHed8l 8=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 69945112 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:51ebkK3FpDvlifgOl/bD5aVwkn2cJEfYwER7XKvMYLTBsI5bpzUBz GdMWzyEOvyLYmP8e4h/bYSzoU9VvJTXn9RmTAZvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw3YDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1cnKyfZSYoYZf2kb1McQB0PmYkBPdZreqvzXiX6aR/zmXgWl61mrBCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82cBfyVu7e03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrieuImEF8QvPzUYxy1LZ/S5I1ebBDODyVvuPSusKu0qbv FuTqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM+e8CMU/4QCJj6bRvQCQAzFdSiYbMYN48sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46eEJpprUZwQ3N/ g0= IronPort-HdrOrdr: A9a23:cBscHqpzY1w2WE/wRWCWhCoaV5t4LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ki90dq7MAjhHP9OkMMs1NKZMDUO11HYSL2KgbGC/9SkIVyGygc/79 YsT0EdMqyWMbESt6+Tj2eF+pQbsb+6GcuT9ITjJgJWPGRXgtZbnmVE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29IOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6c030Woqqh9jJwPr3OtiEnEESvtu9uXvUlZ1S2hkF0nAho0idvrD CDmWZmAy050QKqQoj8m2qR5+Cn6kdj15aq8y7mvVL4vcL2SCgmB8d2jZ9FehHZ70Ymoedn3L hQ32SfgZpbZCmw4BjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklWavoMRiKn7zPKt Meev00JcwmAm+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNAKVs9q DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaMKAg3d83gt DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu7VjDlhCy8jBrZbQQFy+oQoV4rWdSt0kc73mcu f2Po5KCPn+KmarEZpV3mTFKutvFUU= X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="69945112" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CoK9AtcXuWTDbWNVxgkMslLc6kGt3eCUS3FDCzIHUMm7ad8r7e5BxFP5nT8BIY+J311aTmNvD1a67yl1L2ZjjfHXzuKe8f8h4PsND+VLoaSPMeJBD+J76/9eBcSA4X/ExdGJL1xcl5Go/XR+ndmdqakF5CUEwa2Xy6AOXQncQTxad1g6cFlskXFiyObWKRoSchs7tIOhjVCII5weSYECF1MPNXuu/AjNtRoIzvcTjbjj8RVp9Ip75nqs6BP7F8yERiNRY1MnrH3ob3gNdjV9Xj9lEUrcmLbXB0DvhSeMJ+WyeaKeAUqp2gCJa9RpiKFxq1QfVbf0i1OOSNvncyaRwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qG0gipfkVcrI0mhGWOZpx23SXCCFHD+LFN5z/Mlkfkg=; b=j9rjxB6mapJvFp43AjNItRzO4RofaCEIRQ/oHQxNcbEGojKy27yQc4k7OIPPs+EKV4FRZOaqUhbH/UVaF3IxES2ZoETISANvJT+C3MAe8qrFbxpPpIJRUtPqI2JQspfxE8nXRLFcprxHHG8cIxmD1qqkRfwCNX6DsyGmVB3qOvB5dxyqqW1ZeihXLceCYBUPvRY5bW5iySHtnSv1dQTwsZt7l6IlMvWIqnJA0OpyEcxh79YpTJHQCsV1H4STaPNRucyd+E4hBmP9empyrQTbWwz7zeC6GuOUagIOFEWOqsn6bDfWE4vFwKfx+2cxmQP9o8PW1IZKLcYXLRNaH5U+Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qG0gipfkVcrI0mhGWOZpx23SXCCFHD+LFN5z/Mlkfkg=; b=pBTEm2lopVxJgSZXFUOyiPpDVbClO0ZqOn3ztoC7CQycttI8DY2zKUcOu3oKAh8O2gjId5w+Z8FHZyYIcj1Q71S5GxkWiq/Z0tjKNmWTRM3qLQf3POHHdeo6UiW4NWxCwq+esjcIHR3U4F6iK4q0d1Zlop4rLodS3DJFWcHa4gg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 15:00:49 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0006.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e16e0af-9b62-48c4-c158-08da2dce1f59 X-MS-TrafficTypeDiagnostic: PH0PR03MB6638:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rk4eMg5sfZCw4HGv+WbI0CnutQi38jZsNb9Kbk173GFcyfdi3OFZBF8MrneCZblBe6VBA/FCAOt18/2uYmyEclLCGy2soqEL/fktJuaPbWSb2KWM8G7i0lsE6YRs646zAXkSyLaGf6unKNcz1y04sHl1xnb85RsyuAps0xyGrFyAff1wBk7jKBH37m+OlNOjJYKdjVp3N+eHo7lye9g6Q33xFi5cksHqctr05lTj8IDOoDdqBf1xLtxFUczpl3VtM1PO7Y9xgkfBT7CnYsJKcxaVveEB1D7z5Yv/0nJIHLomfMStNhM9qvxECSqLI3EZmB7sua9iUoviEcEs6ZQmC1lVa42q7dDt3S3geuiswAzNmi4Hi/swbY64dCgnov1Mk7nYwAcwTAL73B5RTHz2vJnHFg5YjuqF2yx5K1oaMOWkh9tMsuURzQLDhT9M4UoyiJtBuZ1bp1S28RIJzJ6V55nGXTMHiGhuvVdW8xVYjCHLbjCwhezKqmgRUSdivBDk18Yz9jT6Qu1d4gaWXCXqvLDPdo8mXcXnbuta4Dgqn1Fyt9cT61iOY14gXAmfJBKnTeBHyURBbperNnYWWqgZE80p5v2I+vC0qaYRnmASkkB4T1Y3xi6ccoSkmS0KrnhNKI2buMGB+iWNk4fJIMhJbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(85182001)(186003)(33716001)(26005)(9686003)(508600001)(6512007)(6916009)(316002)(54906003)(82960400001)(8676002)(66476007)(38100700002)(66946007)(6486002)(4326008)(86362001)(66556008)(2906002)(83380400001)(8936002)(6666004)(53546011)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2txUnlnYTVKVk1lTHk4M1BwakdUZzJVUlhzSHIzd000NTNyY3dpTjZxdkRQ?= =?utf-8?B?c2tOY045SytZRTZsZlVUTHV1VE53elEzWlpscklsaDdpRkc2Tk5nNWJrMVNS?= =?utf-8?B?TVZMMW9nbjdzN3d5TEdYQ3BFS1E3ejZIcmFJSExaWEFDeWliUEFubWZveEEy?= =?utf-8?B?Kyt3LzBlcGtHOVFCYWRrUXEwOHVnUlZlZ1pqYnFZL1E3WFk4K3ZQeVkyc25E?= =?utf-8?B?d0poN0pnVk51N0RQUExBZytFQndGNkNJWnQwRkltd3hyVXc1cGI2Q2F2MG5t?= =?utf-8?B?N0V1a2Y3ZmVhTjE4dGJxNEU2RVlpT0wyaXhXcGdGeVFKL0tRM3FISXpvUnJT?= =?utf-8?B?ajBOdjBqbFJtaElHTUJBWW5sVTVOcEpZUG5TMk9FRzdHdWRwZmxHUjlsdHIv?= =?utf-8?B?c3NVTlRWRmFMWGVkOHVEdmxGbjgrU2FvN3dsVTAzcWhTMDgyeEJiNHpLME1h?= =?utf-8?B?Ly9xSjI4KzVtTC9qa0xaTjRBQWk4VWdoS2lJK05qeU1mMnVXWHFEbFM3LzZH?= =?utf-8?B?SDJoOW5pMGhwdTJNMTJxNjRJWkJtQWRjdzVDbWpxZ2FmL050b1lObmgrdTFR?= =?utf-8?B?b0o4a1RmU1FHUElqcDl6YzBlcmQ2L3J6ZzBhVThzV3RMdGhHRHdxNFgwVWVR?= =?utf-8?B?djdNeFY2bnJmZzBwWkszSDQrWjI4eUFpeVM1a1pYcGVBVk9wZFhmVzFXd21J?= =?utf-8?B?b1ZUQVozZkFaZVlzanhTQ3FpNFFDQ0oyVW8xWHJWVUFsaDJIR3RCUWxDQ0I3?= =?utf-8?B?WEhvYm9BQnN2OUxVa1pweVJqY1hxV3BJRTc1elpTZm83T1pSOFFMNVZjb3dy?= =?utf-8?B?azRZYmlBYlZDckZiZThhQktISGZucDd6UnpkcFRuaTlheE5ib1dZS2Y4eWdU?= =?utf-8?B?anNHZG5DN0F6d21MaWZhZVpOeXduU01VVk1nT3MzMFl0NWRXN3JLZEppZysw?= =?utf-8?B?Tm9wZXoyWWoyMGdCOXJSejBHeXhvN005cS9IMVNvRmRrbTcyOVpHYmsvNVlw?= =?utf-8?B?Q244bkdDdXNTaUhnWWZVM0cwMGlHenpoUUJqM1RMTmMyTXN1b0Y3NVloYlRS?= =?utf-8?B?R3lleGpERUFFQ2lyRWx3NVZGQk1LcTJ0S0owZGJTNmV1OUJ1aU1rVzl2U1Fq?= =?utf-8?B?aDlkczJOYzRrYWxLZXlPMndpOUtCSHpOakNlMEF4cE91Wkc3Rkx3RDZSMU1v?= =?utf-8?B?cTNidmRXMVR4c1NobXRjdjd5dTBWTVY2R1dQRGFoNSs5T2Qrc2dQY2JZWXhM?= =?utf-8?B?S0daamJRVDZhU1UxZ0xTMFVHZXBUd1NmczBoaTRvamUvdnFEWEJSSWEzTjBF?= =?utf-8?B?VllJYktPMTZ0REQvTTNIMk5rdzU0VnhRQXp0OGVTZG9maEJkVGhIbXVaVU5z?= =?utf-8?B?ay9pRmVta3FKOVNWWGdOYW5iL3JvQWdoOUZURTZLeXkyRHFTQTUrZTA2U0Fx?= =?utf-8?B?RWhkSnRaNWdzMXFoU2VYbEd5WG04eFplT2RlZXZsZGFzUlA0dTFkemkreVBQ?= =?utf-8?B?OSs2aTUzRGVMcGFzZDdtYUdiVmV4MXlpRFBDR1A1ZXFRRW1VL3lZOGNTTVo5?= =?utf-8?B?ZHQycGhZVkJ3WTVUamdrRUozK3llQkhVc3I3YTQ2WTlMVWtPdjFadE9zTFpo?= =?utf-8?B?b0pSSXJLalBERWh5N1BiaUZidHRnTGxvMG5LSGdLTUdDTk9OQWFGb1NYeHhz?= =?utf-8?B?SHc0UUtGeFJNQUgvVndaTVFIOGR2UW1hbSswVU9KRUg3ZTFmMFdKUXR6Vmhl?= =?utf-8?B?a2pqMC9vQ281eXNGbCszU3RzSytQb0U1MnNtYURhRUxZb3pyT0RLczFyRkhC?= =?utf-8?B?SHdFWktYTHllUGJubnQraGR6eldpbDZINHVBRXVxUXJGV09HYVFSR08wWDhW?= =?utf-8?B?ajdhTHk3L0pHcVBBN2FwaXN3V3NTMzBvRk5raHpwdmFMYlEySlF5WERMZDFI?= =?utf-8?B?Q3Q4alRkUklEcnBrSnAvWHR1cUgrNU5FTnhRTUowczF2UGtQVXVTQWVnREMy?= =?utf-8?B?QUFMdTdPandZQ2grUjJ4OG41Y2xHN0ZCMHF4MUY2M1B6S3NYRklKY2FZMFJw?= =?utf-8?B?OUhqOWRhUDhCQjR4SVgrdi9oL3FJRU40TWRoSDc1cHJmZmE2dm9HMmJIYmtY?= =?utf-8?B?Z2R4czd2akNVUEd0akdwZzNGb0d2SFp5eTRqODRNRk1nM0ZVcnlwcmxVM0VL?= =?utf-8?B?UUJYM1JOamFlUE1TQjZlWGxodVIwOE0wV21yNnlIVUprWGZoNjBBODQwbkFT?= =?utf-8?B?M2N5Wnd4UTV2M0t1N2s3OWNKL29DQ1ZrV1F4MEFXT0NVUDhoS1J2czc0NjZN?= =?utf-8?B?L0FaQ2tuM1JROEF1VXRaT2VtYjVXeDF4RGp1c2dCcWFlMEIreGRrejFiYWxZ?= =?utf-8?Q?43ENXPCvHuTfI+wc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e16e0af-9b62-48c4-c158-08da2dce1f59 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:00:54.2584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HWcuRPMAltfZG57d+9OHudr/zktRhhPjiIWPJWl8Hv0MakNkXSjpdWJtoiMp4FVacShWmYiJOAJTTIBAnyrxEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6638 On Wed, May 04, 2022 at 02:12:58PM +0200, Jan Beulich wrote: > On 04.05.2022 14:01, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: > >> On 04.05.2022 12:30, Roger Pau Monné wrote: > >>> Right, ->iomem_caps is indeed too wide for our purpose. What > >>> about using something like: > >>> > >>> else if ( is_pv_domain(d) ) > >>> { > >>> if ( !iomem_access_permitted(d, pfn, pfn) ) > >>> return 0; > >> > >> We can't return 0 here (as RAM pages also make it here when > >> !iommu_hwdom_strict), so I can at best take this as a vague outline > >> of what you really mean. And I don't want to rely on RAM pages being > >> (imo wrongly) represented by set bits in Dom0's iomem_caps. > > > > Well, yes, my suggestion was taking into account that ->iomem_caps for > > dom0 has mostly holes for things that shouldn't be mapped, but > > otherwise contains everything else as allowed (including RAM). > > > > We could instead do: > > > > else if ( is_pv_domain(d) && type != RAM_TYPE_CONVENTIONAL ) > > { > > ... > > > > So that we don't rely on RAM being 'allowed' in ->iomem_caps? > > This would feel to me like excess special casing. What about placing this in the 'default:' label on the type switch a bit above? > >>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >>> return IOMMUF_readable; > >>> } > >>> > >>> That would get us a bit closer to allowed CPU side mappings, and we > >>> don't need to special case IO-APIC or HPET addresses as those are > >>> already added to ->iomem_caps or mmio_ro_ranges respectively by > >>> dom0_setup_permissions(). > >> > >> This won't fit in a region of code framed by a (split) comment > >> saying "Check that it doesn't overlap with ...". Hence if anything > >> I could put something like this further down. Yet even then the > >> question remains what to do with ranges which pass > >> iomem_access_permitted() but > >> - aren't really MMIO, > >> - are inside MMCFG, > >> - are otherwise special. > >> > >> Or did you perhaps mean to suggest something like > >> > >> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && > >> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >> return IOMMUF_readable; > > > > I don't think this would be fully correct, as we would still allow > > mappings of IO-APIC pages explicitly banned in ->iomem_caps by not > > handling those? > > CPU side mappings don't deal with the IO-APICs specifically. They only > care about iomem_caps and mmio_ro_ranges. Hence explicitly banned > IO-APIC pages cannot be mapped there either. (Of course we only do > such banning if IO-APIC pages weren't possible to represent in > mmio_ro_ranges, which should effectively be never.) I think I haven't expressed myself correctly. This construct won't return 0 for pfns not in iomem_caps, and hence could allow mapping of addresses not in iomem_caps? > >> ? Then there would only remain the question of whether mapping r/o > >> MMCFG pages is okay (I don't think it is), but that could then be > >> special-cased similar to what's done further down for vPCI (by not > >> returning in the "else if", but merely updating "perms"). > > > > Well part of the point of this is to make CPU and Device mappings > > more similar. I don't think devices have any business in poking at > > the MMCFG range, so it's fine to explicitly ban that range. But I > > would have also said the same for IO-APIC pages, so I'm unsure why are > > IO-APIC pages fine to be mapped RO, but not the MMCFG range. > > I wouldn't have wanted to allow r/o mappings of the IO-APICs, but > Linux plus the ACPI tables of certain vendors require us to permit > this. If we didn't, Dom0 would crash there during boot. Right, but those are required for the CPU only. I think it's a fine goal to try to have similar mappings for CPU and Devices, and then that would also cover MMCFG in the PV case. Or else it fine to assume CPU vs Device mappings will be slightly different, and then don't add any mappings for IO-APIC, HPET or MMCFG to the Device page tables (likely there's more that could be added here). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 13:04:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:04:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320707.541570 (Exim 4.92) (envelope-from ) id 1nmEft-0008I2-TP; Wed, 04 May 2022 13:04:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320707.541570; Wed, 04 May 2022 13:04:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEft-0008Hv-QP; Wed, 04 May 2022 13:04:13 +0000 Received: by outflank-mailman (input) for mailman id 320707; Wed, 04 May 2022 13:04:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEfs-0008Hl-Nl; Wed, 04 May 2022 13:04:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEfs-00059W-Mw; Wed, 04 May 2022 13:04:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEfs-0001re-Cg; Wed, 04 May 2022 13:04:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmEfs-0007jk-CA; Wed, 04 May 2022 13:04:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xtmAyYziAux5G+wz9o05dwZznJrvO1CcYy6sE23nxGM=; b=Vjsx5FsKaGu7lreRaKpnc+mX4J 5Y77U5FWV7/YmE64EsW/qX29VW2/xst+8eyVvQoJ8FDDZNRhBbUP/G8v9h939aHTO5bLycyDDgHqT Y1erEPb2XMYrmW3sfZvZErphUk8w3NYVU3vKu/Cl4I3HEZlyZCgzPxqeRBvVmDyQLF80=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170099: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 13:04:12 +0000 flight 170099 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170099/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 800 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 13:07:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320716.541581 (Exim 4.92) (envelope-from ) id 1nmEj5-0000VB-ED; Wed, 04 May 2022 13:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320716.541581; Wed, 04 May 2022 13:07:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEj5-0000V4-A3; Wed, 04 May 2022 13:07:31 +0000 Received: by outflank-mailman (input) for mailman id 320716; Wed, 04 May 2022 13:07:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEj3-0000Uw-SE for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:07:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 264f2cd4-cbab-11ec-a406-831a346695d4; Wed, 04 May 2022 15:07:28 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-exh7fVW5MqyLWgDWQUar8Q-1; Wed, 04 May 2022 15:07:27 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5711.eurprd04.prod.outlook.com (2603:10a6:803:e7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 13:07:26 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:07:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 264f2cd4-cbab-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651669648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a2g00xa9Q366Gjo2W3X1L9KuAwQR/CYQX5PBctOoVhk=; b=N47JmInkYTg2zFBXvg+WosC+LFV+witz3Fb/Wj/TNo/ZArTjtlRL5WMtrRjDskzU7yl76V kqex/DVlfUeI4+SNh4DK290RE057jZGYM3AGiRegdVUDMktcMUTZigtrtcwI9MGZfe8dNd 0DmSU9dRXhoqm629sndbc1twvMNO0x8= X-MC-Unique: exh7fVW5MqyLWgDWQUar8Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/Nz2O8BLSfIRWX9dq6xrHxHkPiERNTtWML4mGVJlcBv8FieuOoRqQxTX7mtMaJWcCx28tayuu7TJnIYXimHSMIPfjC7ABXfRE6O08iUxqzbM6cQBqIjTvDbfiFINOlDPTNoDl2yiQT+MTMfXK6sfs9B/K7wlsX44lFempKeU114WG99SvoumbrsXMz2qdOdPbujkfjcUAkzYPlG+FFlhzzQ0P4GykqQd1vtZAMyrGL/SYtrL6sqomtYed4WzBr6jrdub3XPN61VtdQGVYGHL21WjUPPdZ+a+J+44gPPCXFJD45QgZAJKLLeAho1zmVDxcDfYuKSM1xH8AY32yD/7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMgl4Gr/UeHBQ66d/DU6oKCkaWBT+A+HnvvjltgK/R0=; b=gosMQPsiDCukklNzqAjdwHd4x+Mj3lXFdv3bZTCDz/u+NEKdZlh0YIZsX8OKfZcuLwYADD5gyAS/q2A37v7hdrz3Xy6WuICKumoGAUxuyR8UVOx8oUbo4yYqGryB8AuG/DI5tHBM3l72dSgyIvdcpIyHOxqAY1B50PcIJVO6dl0xK1sPvnEJx3FW2Pr0pEXHPx8dM/361wHOPrZm1bG4cxtuXeccFoas2suJ7FO/hfPbE69AVXpSv56ynANBYc3IAzFp6a74MdCbMeMTZzIF9Q6RT1pxZZX1126rDSi67cjhACFhIAP6by8b4EUZWL5wHh//yQlLlMSZiTtli6tPig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2d0d8aa9-1ab8-a505-e2df-c9b6446062cf@suse.com> Date: Wed, 4 May 2022 15:07:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR1001CA0032.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::45) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52f8f67f-4908-4539-954f-08da2dcf08bb X-MS-TrafficTypeDiagnostic: VI1PR04MB5711:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RY6I9FDfR1nMs7YeA/QUs7V03yrphpods4lz/ggNKnvbWe/0620HwYUsNyAhIY4MGEaS6Wg7nhfo+4wndNqOIDa2mb79zGkcWuXbeFD1kMaF/CxQ/j8jL8uqhRSh3+H2yOb0RfVHi63HI3Ar5JhdlHqd8ImMOHUIoAvSjIBFcViVu01xz90QI/nVi25+k1KL/4O802Wb0iaM3A2H+RXpOYA5DFCYbPNTk7uANZ32XujNQJRoKEailRiZUZvyka0F4LWcFryr+S9g1liV9ia5C1+bOS5aOsEMARitoCm62RaiQmyigseffi0HDqOr7vUhVHhHnBLwSbi+hATC2EEBdXskgYOoUaUWRXwP5hKZqrKtAtOcO7S+9vgO0nvQ2eJ5C5Sqrx+laaMbz6vC3Tu4SsmMdrwSqtKH76deKv3DxBKNaJuh6aOIJUuSiug4KDEkCExrzN09WsNfAjM3nJqVWS7Yqsl0uw93+vIFaHbD9DRmN7rbvBVHfa1uLFE8lp0u6MUUnT5gXO6h2rC4eWpmkGFVPtj6UncaV+gMkOO+BgtzCv6KgrtOUT1ouxLCyas2NyYteXgQBAd9Qbmb5UL7UdG8tFRGReYqyHRDKjBVgGMux/2gwaxssneu3HljRVs7YYr4putBBKOhn323JhCJuhUudvBBWghsrbyuj06JMad1DtVVprs6xeU/nhdXSkU015TrgRZsCaBLKJWSGSoDmVKD+oB6266Fke/a31CRyFc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(26005)(6506007)(6512007)(66946007)(2616005)(86362001)(54906003)(66476007)(8676002)(4326008)(186003)(8936002)(6916009)(66556008)(36756003)(316002)(5660300002)(83380400001)(31686004)(53546011)(38100700002)(31696002)(508600001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ht1guBpo30JPhOyapwo/I6ljelQCiS55CFaQMQM+EpiuRvkZ8U6XpAjooXjb?= =?us-ascii?Q?v4vELA460s1ffcF5c02B+pChCF6Ouc3q7H4OwD9+YIaYOOqI9ZscyM9OpW66?= =?us-ascii?Q?uJSYWvuqaJy3t10uD5h61wDOO6zWxopB1XYGDcEDrSjMCIiuGISfWyfT8KU3?= =?us-ascii?Q?ZDqvBAibjQEEBMoZGgWgIv4L6qE08OD9d67RCQc+cAttVrcnL2PPaHRS0LF2?= =?us-ascii?Q?53bTh2eA7kP5rGVQPt3J76XlgVYiGC7nCyCsMvJcpQhYuNP8qUwr20t6pkha?= =?us-ascii?Q?yG5xm2CVPAQLY53WhLMAOa7abfk0OU3/D1qxXDFdx1sowf6CsmzSlw+IMpaP?= =?us-ascii?Q?uJkMy6oVH4RnlNLaytJWKpeXJ17ZbZeYn9nv6LM9JzmLcuHDbd8TNYvaIbTa?= =?us-ascii?Q?kjyaL1z3qEGO9a9ejCpKuZ+leXtsgvD3M56bnfIW7eLcU7Usxm5IO3tWcXL4?= =?us-ascii?Q?RbGDPdExzhLtGkF8Pfui92fsNFWoafgueZjh4x+A4dC2KbAZ2Iuv0Tv3GYTx?= =?us-ascii?Q?Gu9Vuu6401MtYnom5eNLmREbElWT/YDn1qmT8njhwgpVgP6dVGC/6nOYVDNe?= =?us-ascii?Q?Um9wKw3Hhouf0qvBJLVd3y2l5hi+kpJlsW9aCtsQdrzU9ERoaL0skVMCU3QF?= =?us-ascii?Q?KGNNFZYh0NFz/neO2z6AEDBYMCr9JCxIUK9OZrFUeq9KSVkDGYW0hgxpZahR?= =?us-ascii?Q?OkImvpVELv42WGAPWmfDnDP6f8FsKu+5U/e9Z4U/nzoqrQzQD92dqlhdT/sN?= =?us-ascii?Q?6b4YrHH0CWHceiB3bF1EW9KkyP0dkI4H3neSuWjOvVsGXHV0a3aPtzmcmL1d?= =?us-ascii?Q?veLl3QwxoS+pDJkIs1oqGPTNzgsa6JnidFbmLsuXRlS0SbdqTEzHo/d6YL6m?= =?us-ascii?Q?BPaQQEm/kwEFigVc22GJLcAtotOFXUKlmialU0q9rBfdjvWaE+YgQeXBF/pa?= =?us-ascii?Q?cxUqsc12k0UF9hR+0rdF4fMrgVNsc8qawoafDKD+x+fo0IAGhmnl9FsBy+Ca?= =?us-ascii?Q?5foOYYyk1+CZr05TnuoO/M07cOikFvRfJgvizWY5ElOVSzS3s4pJFxi6C539?= =?us-ascii?Q?Z1mE5BLPJBJA5U4FW2o48EhwjiXOcqgXLQirceRdQAEpAieYNzgL0/j+Sk3W?= =?us-ascii?Q?Jf9OEy789vrPfi7YA8PAQdVJmc2Av+bFbSjf120Y25+6Pwn7O26b6npEF3so?= =?us-ascii?Q?E+M5LLAwVqzhyP/7AThIIbEQZ4K8VgbZ8vPkM/figW1YocTPRIeb/eldbJt2?= =?us-ascii?Q?igKRFlL8YcVTaS3wHvNOjhxek8mBAT55KmEHvCEem8pXY1uTMuA71WqiDcQ9?= =?us-ascii?Q?bshcG542Bz6ZJLLg1cSXXkYp4z3uwg6ytCLUUBXcK1mbp8LnPlOIg7o1TDV9?= =?us-ascii?Q?LISvoMbQq0xL86zZxcRDQpWMfDSKjvgh5Ux1LRXNtlwCT+giqWmb970r7nFO?= =?us-ascii?Q?pb6em6Z+sKrjBN82ZdswMWlEET4Mfzj+mRWNZdU2eWfgmAjLNsQWx/9PZNrD?= =?us-ascii?Q?TBJjHZz/pcHfwQdiNBLjW96ccWxwOvN1rtWzwx3geBDdpgYZINREGWzq8mio?= =?us-ascii?Q?2+nbiZ86vIOohUAb3ewE4RcIPQTXXbt/8Ptvml2jrsR8amcpDZ7CYGx9OQQG?= =?us-ascii?Q?DPghIN+Ec5Sn4Q8xHMK7pt8+pZiE4kzlx5z30sn6PSjAO8+EkN+mjobtE7Iw?= =?us-ascii?Q?QHkBJevslwo4A6Z09Y79GDgG0fmV50Qo+SG/IEVEYxLyRrQyPXfrvdYdmRRJ?= =?us-ascii?Q?OHQHfjMa7g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52f8f67f-4908-4539-954f-08da2dcf08bb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:07:25.8555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +kd/Jk7vY4Kws37F+IsBwoVsjceJdkZAoS0fi6ZTyTu8DkdLMVCfw+hgKtTGlrxYgx4mnJll3RCsKaybHiCiLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5711 On 03.05.2022 18:20, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: >> For vendor specific code to support superpages we need to be able to >> deal with a superpage mapping replacing an intermediate page table (or >> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is >> needed to free individual page tables while a domain is still alive. >> Since the freeing needs to be deferred until after a suitable IOTLB >> flush was performed, released page tables get queued for processing by a >> tasklet. >> >> Signed-off-by: Jan Beulich >> --- >> I was considering whether to use a softirq-tasklet instead. This would >> have the benefit of avoiding extra scheduling operations, but come with >> the risk of the freeing happening prematurely because of a >> process_pending_softirqs() somewhere. >=20 > I'm sorry again if I already raised this, I don't seem to find a > reference. Earlier on you only suggested "to perform the freeing after the flush". > What about doing the freeing before resuming the guest execution in > guest vCPU context? >=20 > We already have a hook like this on HVM in hvm_do_resume() calling > vpci_process_pending(). I wonder whether we could have a similar hook > for PV and keep the pages to be freed in the vCPU instead of the pCPU. > This would have the benefit of being able to context switch the vCPU > in case the operation takes too long. I think this might work in general, but would be troublesome when preparing Dom0 (where we don't run on any of Dom0's vCPU-s, and we won't ever "exit to guest context" on an idle vCPU). I'm also not really fancying to use something like v =3D current->domain =3D=3D d ? current : d->vcpu[0]; (leaving aside that we don't really have d available in iommu_queue_free_pgtable() and I'd be hesitant to convert it back). Otoh it might be okay to free page tables right away for domains which haven't run at all so far. But this would again require passing struct domain * to iommu_queue_free_pgtable(). Another upside (I think) of the current approach is that all logic is contained in a single source file (i.e. in particular there's no new field needed in a per-vCPU structure defined in some header). > Not that the current approach is wrong, but doing it in the guest > resume path we could likely prevent guests doing heavy p2m > modifications from hogging CPU time. Well, they would still be hogging time, but that time would then be accounted towards their time slices, yes. >> @@ -550,6 +551,91 @@ struct page_info *iommu_alloc_pgtable(st >> return pg; >> } >> =20 >> +/* >> + * Intermediate page tables which get replaced by large pages may only = be >> + * freed after a suitable IOTLB flush. Hence such pages get queued on a >> + * per-CPU list, with a per-CPU tasklet processing the list on the assu= mption >> + * that the necessary IOTLB flush will have occurred by the time taskle= ts get >> + * to run. (List and tasklet being per-CPU has the benefit of accesses = not >> + * requiring any locking.) >> + */ >> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); >> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); >> + >> +static void free_queued_pgtables(void *arg) >> +{ >> + struct page_list_head *list =3D arg; >> + struct page_info *pg; >> + unsigned int done =3D 0; >> + >=20 > With the current logic I think it might be helpful to assert that the > list is not empty when we get here? >=20 > Given the operation requires a context switch we would like to avoid > such unless there's indeed pending work to do. But is that worth adding an assertion and risking to kill a system just because there's a race somewhere by which we might get here without any work to do? If you strongly think we want to know about such instances, how about a WARN_ON_ONCE() (except that we still don't have that specific construct, it would need to be open-coded for the time being)? >> +static int cf_check cpu_callback( >> + struct notifier_block *nfb, unsigned long action, void *hcpu) >> +{ >> + unsigned int cpu =3D (unsigned long)hcpu; >> + struct page_list_head *list =3D &per_cpu(free_pgt_list, cpu); >> + struct tasklet *tasklet =3D &per_cpu(free_pgt_tasklet, cpu); >> + >> + switch ( action ) >> + { >> + case CPU_DOWN_PREPARE: >> + tasklet_kill(tasklet); >> + break; >> + >> + case CPU_DEAD: >> + page_list_splice(list, &this_cpu(free_pgt_list)); >=20 > I think you could check whether list is empty before queuing it? I could, but this would make the code (slightly) more complicated for improving something which doesn't occur frequently. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:11:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:11:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320722.541591 (Exim 4.92) (envelope-from ) id 1nmEmS-0001tq-U6; Wed, 04 May 2022 13:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320722.541591; Wed, 04 May 2022 13:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEmS-0001tj-R8; Wed, 04 May 2022 13:11:00 +0000 Received: by outflank-mailman (input) for mailman id 320722; Wed, 04 May 2022 13:10:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEmR-0001tb-3V for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:10:59 +0000 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [2001:4860:4864:20::34]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2dad2e8-cbab-11ec-a406-831a346695d4; Wed, 04 May 2022 15:10:58 +0200 (CEST) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-d6e29fb3d7so1101639fac.7 for ; Wed, 04 May 2022 06:10:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2dad2e8-cbab-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lf+X08kiFKGHmXOfN6LM+PkgLDzpqNGCHdD4Kk3iQOM=; b=Ij1NfEjZccriCrwIDseFnx1SrsjQHM/SaEmJLeJWRs/yGvosNgcQ2/tyj1hwQ4ZoyN G4cjJiy+ewMRVjw4+x7FxnV4JjNKYddAY0B0FHgXjAuDQtKx/0vyzAAYSrMG8uJaDSV8 0WRaGEcATSZoMaenS52OjI/LEmzg99h51r422RbmpWC0ustbF7i18jHRjxQZ35yaOnXd X5ch8EUwuZB9KAIfIiCylu1tDcwrD6RrzBTuJDOF7ildsZOCRVU4sD6CIUUPQesx2pIp SqkYqEmxSDoq+vfNH5Rw4/70bjJJe3Dn5RhH3qGJc62ocRib78yxIXAcRLSKlYeXnz6N Le4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lf+X08kiFKGHmXOfN6LM+PkgLDzpqNGCHdD4Kk3iQOM=; b=jzP+UU0kZtq7mNj4EqN1R8rLZVpaJ+LrFt0yILOFC5V9AHpK54lu6oLy42SlGY74O9 yYMVON/fs3uWkdO5EDGkr7CItYDxgZaC94XKEibJzd81psjI4LohqaJzekZ4Jdq8eVVF b7dJOqyr30HB8895j4x2VKO+OuJtQqXw3qMO1QJVLqgmPyC3EEIh45IJNABujugcTB32 xNMMC66Bw75qfKasq0lPNljn/HL1wR5ZueJGTNhcJLBTCzw1jiUtAiTqRhjk84gs7IHO 18E+Ry/i1aOU+nXMq2/Ba66N+DlJEYJiegfZvaI/Om9Y8omaDIz6tOKoPP1E0osvBiZG SRug== X-Gm-Message-State: AOAM530btuqDjrGwEU1liIfmTsIbLfVYlOQdAo2DvMkagm0zTYEYcN6v lhymHGHkM56xP4ex+gguKrTziUfKhBTj4rBIdQ4= X-Google-Smtp-Source: ABdhPJyixgBB9PH8W0hTe1IZshr6QZP7uRJJMKenoe25BGU8vVX0BFmjDSUqlkxGyT5MujPNJmfJeOh8IB3pov3Kf60= X-Received: by 2002:a05:6870:3288:b0:ec:9da8:22c3 with SMTP id q8-20020a056870328800b000ec9da822c3mr3729320oac.128.1651669856830; Wed, 04 May 2022 06:10:56 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 4 May 2022 09:10:21 -0400 Message-ID: Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor To: Tamas K Lengyel Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" On Wed, Apr 27, 2022 at 11:52 AM Tamas K Lengyel wrote: > > Need to separately specify if the reset is for the memory or for the VM state, > or both. > > Signed-off-by: Tamas K Lengyel > --- > v5: split from the hypervisor-side patch Patch ping. Could a toolstack maintainer please take a look at this? The hypervisor side is already merged. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Wed May 04 13:13:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:13:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320728.541602 (Exim 4.92) (envelope-from ) id 1nmEoo-0002Zi-Ad; Wed, 04 May 2022 13:13:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320728.541602; Wed, 04 May 2022 13:13:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEoo-0002Zb-7j; Wed, 04 May 2022 13:13:26 +0000 Received: by outflank-mailman (input) for mailman id 320728; Wed, 04 May 2022 13:13:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEom-0002ZT-AO for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:13:24 +0000 Received: from MTA-10-4.privateemail.com (mta-10-4.privateemail.com [198.54.122.149]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8c4e847-cbab-11ec-a406-831a346695d4; Wed, 04 May 2022 15:13:23 +0200 (CEST) Received: from mta-10.privateemail.com (localhost [127.0.0.1]) by mta-10.privateemail.com (Postfix) with ESMTP id CC525180020A for ; Wed, 4 May 2022 09:13:20 -0400 (EDT) Received: from mail-oi1-f180.google.com (unknown [10.20.151.157]) by mta-10.privateemail.com (Postfix) with ESMTPA id A5E1B18000BE for ; Wed, 4 May 2022 09:13:20 -0400 (EDT) Received: by mail-oi1-f180.google.com with SMTP id e189so1113399oia.8 for ; Wed, 04 May 2022 06:13:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8c4e847-cbab-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1651670000; bh=KClxr9FPaKgZE6KxjQcm7KgpN2gKPuncy9nYaqWpkQY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f75Es7b6xuG2+AFq5SGj5X33iRV1uqYqWfSB6+Uplx0Zw5umuRGeWLVnbHRw77kox VBTaiV559B66BWpMp6j/7V1wLzH9crCl8xRROfCvhfrVgKqKSWqSIfoj7xxk0v5wF9 7wE8OhAXboteZyHzDd3wT8SSTZjxbxFEwGb1BE8O9//AZW7uZYnx/ItykbATPvJ3jh ztj+QfUxwu9wwxhKUkBAHwH+akkWyWuag2xojVPYyOJUyh1YS4Kpyb2bCnVH+eEIHZ DtcNN4E+fuTsaIKamNnM1cSdlwviuTQela214j6bxLYHELfdintsrX8nloFHdShA0T pK44hAGfKMuzA== X-Gm-Message-State: AOAM530b7bHkicBXedH5n/bQ7kK/Mgf+G3ywvb57ygEFhOYJBXGiOlQR PUt1kmGDAfZALBbLLKlz6SIY2x01Kg2cp/Voc3M= X-Google-Smtp-Source: ABdhPJz7H/A8xF27/Ct7j3sc2wBz72O5tpWBNCv4VAQ/Rq+h5NwgbV2piYxP8FkOhHlaGMMMebzOrCBJO13IB2rUGGg= X-Received: by 2002:a05:6808:302b:b0:2f9:eeef:f03 with SMTP id ay43-20020a056808302b00b002f9eeef0f03mr3816600oib.128.1651670000010; Wed, 04 May 2022 06:13:20 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> From: Tamas K Lengyel Date: Wed, 4 May 2022 09:12:44 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits To: Tamas K Lengyel Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Alexandru Isaila , Petre Pircalabu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jun Nakajima , Kevin Tian Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Apr 27, 2022 at 11:51 AM Tamas K Lengyel wrote: > > Add monitor event that hooks the vmexit handler allowing for both sync and > async monitoring of events. With async monitoring an event is placed on the > monitor ring for each exit and the rest of the vmexit handler resumes normally. > If there are additional monitor events configured those will also place their > respective events on the monitor ring. > > With the sync version an event is placed on the monitor ring but the handler > does not get resumed, thus the sync version is only useful when the VM is not > expected to resume normally after the vmexit. Our use-case is primarily with > the sync version with VM forks where the fork gets reset after sync vmexit > event, thus the rest of the vmexit handler can be safely skipped. This is > very useful when we want to avoid Xen crashing the VM under any circumstance, > for example during fuzzing. Collecting all vmexit information regardless of > the root cause makes it easier to reason about the state of the VM on the > monitor side, hence we opt to receive all events, even for external interrupt > and NMI exits and let the monitor agent decide how to proceed. > > Signed-off-by: Tamas K Lengyel > --- > v5: wrap vmexit fields in arch.vmx structures in the public vm_event ABI Patch ping. Could a toolstack maintainer please take a look at this? The hypervisor side already has a Reviewed-by. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Wed May 04 13:19:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:19:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320735.541614 (Exim 4.92) (envelope-from ) id 1nmEuZ-0003IR-3x; Wed, 04 May 2022 13:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320735.541614; Wed, 04 May 2022 13:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEuZ-0003IK-0z; Wed, 04 May 2022 13:19:23 +0000 Received: by outflank-mailman (input) for mailman id 320735; Wed, 04 May 2022 13:19:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmEuY-0003IE-K7 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:19:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cef08fa4-cbac-11ec-a406-831a346695d4; Wed, 04 May 2022 15:19:21 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-2eZzxAFaOk-HwyhaOhjL_w-2; Wed, 04 May 2022 15:19:19 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DBBPR04MB6217.eurprd04.prod.outlook.com (2603:10a6:10:c1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 13:19:18 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:19:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cef08fa4-cbac-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651670360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brOLFC9YKlUYWyAcAQIjbfZrHhyNPEPuAEN42KEly30=; b=nnfm7bX1Snov8wGkG3/1eusUbrIiptySXfCCL1TGQY5jwCIRQ3p4hseFRE0mn6si/Rm5NT xKTh6yuphBo4Mgz2O6Y1Io9+4vld73shFPDpKr09/V4yD1jm70zeCxuSD+PBhxCGqyx8jY VNgWrksOl1oOZU3KivbRzNdcr0ImLYQ= X-MC-Unique: 2eZzxAFaOk-HwyhaOhjL_w-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5QzvFr1BFpvk6Y08TYMJxTQezJVVmarXWbCoqZcc+c/q4HIpHu5oVGc+sY+MjURvXchRn+jlB1vvY2xGntAVM3Y2sE+TpKe4ds4tPbxHMRG5ig0jnz3T4UvqYb6EDumeyspUq8XkdpcGwXNge9kpQg3plxt4nRajoHD2X1y8yN+gItyal9FYRuGlYPDxY/xAx0rNDv1FhqYicAtFPDisPeaMFQCfbIp5F+xTv2fQD3as0uqnrHnauUAbBdeOewwFWy8NXdBEqejYk2BWXJvfXkZlTj6IpZ5QSnXqkyysZ1yWozp5Oo8ZVebNAFV211qvVHhwDj58eCkKftVPYCKwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OIegK4KQyJkiHm0c3sXrkiucNtnTVk8d6mJ1eMXyT9k=; b=MqLbC+TG3FP8xG3SWH+1oWgu6+cqSYsTM79sAInC++oUUgkvs9+jbeGJG7u7TE8SYEK2bNJR03mebSEarGANvQEGgYES6UtPyAcch/0oA1MAk4EvRoYdKA4qj+a50/XTEoMZI2RMSRHG7/PVDwUtWggiGY6d2c4VDBXYgZz8NCOfDTkTx3m/4fChiph5FYTxMekHvqCORs7UuHdeN8ljeut8ix+PrdEjRq1PLuxT2M753vmQNLSeEgc3+byoSQysjgA683wQwpNDkSgfPVhAv6J0wZPiyhfxBwubsj1YBsX0EMvw5mHlAFFzCYP/PYtrBulYoiCmmsrtVvP0RkeZ/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <66587a43-02b8-20c6-2663-4a6fc3e010e2@suse.com> Date: Wed, 4 May 2022 15:19:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0155.eurprd04.prod.outlook.com (2603:10a6:20b:48a::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 476f4aa8-8c94-45ce-9fd8-08da2dd0b185 X-MS-TrafficTypeDiagnostic: DBBPR04MB6217:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UnZPgLD0p0ev1kHdjmDwQrp5TVdQnwBVwIDY+IQGCmamz0QxfNd3tdXCk1KbuHyfJHjbraWsA2LZhSKmn2EsSvICtLJvz70AyYrMaDSzKUH7aQQDKE/T7gqnCWa8vNJJs72tzhzg32B6SUGyX3VAQPkTLENw37E31qc/M0nztvOPK39EKys3vIuOi/YPbs+ErsYlypoLRa/rz3KPxAn3HG6XO30fT7atvAl7PZGH6fxMsrSVPGghmNHqFZZ+BDJyLOUU6q+lcn+XTSGQXr9/xTGtlgkvfGpg+wRVlGVcEIQev8vWEAOrI2+vrHRhReC+/8j30o2KS7fzCLKrpMWIEndrAqCSHUQrY31gC3GOHtjexa+vR5DppXAoKqlJbGKHemGfcZ73z4qyjFeTeFKYNjHIk8Fmy8qXJTzK3uONUUm+J9PGON4SM1pEdGhYkmPaowgZear+EQTp1Bq0Ew+6loXbfjhBUDtqh6PtgK4Une5JoyxRcb56xJQbNkFnyYtmHjx4gCvmloeDIbI/q55U6CVHYm2OVAZysj1E47uEw9smYtrpi8eqN7XE2eVbhDGntmm07cbiVDwweZPdE8js5l32jikGMDT/FfkcVFBCH+9qEhkWtHw778Ws+A8n0OLs0QS+oQwVLhrxyOZti7c7RJdd4LIplOoBsRk9VWPD8VPLuQxZtSy1nNNAYgXsHZZbcgQRMtHs18erfCfgn1VW7zNncYwXN0yvvdLl1iDbgFeeFICeBMfMc05xDEH+Wzfk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(5660300002)(6506007)(53546011)(186003)(316002)(6486002)(36756003)(508600001)(2906002)(31686004)(8936002)(86362001)(54906003)(6916009)(38100700002)(31696002)(66946007)(66556008)(66476007)(8676002)(4326008)(6512007)(26005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?65El8MF4NeaWFWkSumL7KPbw4psSWra0CXRoVopLt6qBjVutMLIedLtC7JYb?= =?us-ascii?Q?jISiHgEnNmyznL+C6ed2Gx80YgNoeN5aNebZbHcep5KnsFzNs1lOVLLyF3dJ?= =?us-ascii?Q?Syt91El+T1nzFX5MSV7RVnUDtXZEPZysEeB4Rr6kbJiiryYRBTDneK37ts4m?= =?us-ascii?Q?K5Tt0RuauaQON1wLRnIBF4gEFRAb6O+oblNeyHTQPPWCpB6rejxR8FysPHcO?= =?us-ascii?Q?vXZbhapPcl9vso4WiJP/s8NxC88MDdVW2R2/bny3CTOQ7oczWmq/Dv/fnQjj?= =?us-ascii?Q?NE1hUb/LwN8Eiv+Z4qXMvTpfQQbi4sT/RcRKn+o42qEWuV0kqbFeYQQie1gv?= =?us-ascii?Q?5AtKyTGw/8ECzJ5ZXLjd38pnvHG4btQBXxXrxTjyzGyV7a8XNRvYuNFPYKo7?= =?us-ascii?Q?IYj2IQY8oAQvvYD70d4j8RPX4yD1jhOFIDccsZ6fc7J/+ED3Dlmxeltqr4O3?= =?us-ascii?Q?T6V/hLNJPhy2AId8MNfndDR/TpBFh5SJVQu6evlAU6Bco+z3GJhgybKRnYmq?= =?us-ascii?Q?2TmIarKnlN6koZBZM3Epx9caFXgaLsIRVnzd8vy0FGiYJ5RdufbrfRsV7Jog?= =?us-ascii?Q?C90VJFxVyLUYo0iQ39ZedbXZGdStv1u6EObw2W/uasGowx4KbqqST8jfhLC7?= =?us-ascii?Q?2A3D3mTw3kciBQ3US79Ec7T1n/9e3W7H4RB0Pw7UDozLoApLlvO6BWvk17k/?= =?us-ascii?Q?ctsgY63iYFGCIFTv3+P72fSDeqS/Fa4724DMOBZvk6HFjTjGGMdrlXdIMLwT?= =?us-ascii?Q?3Wmqk5B0/fLtAJJ1U6+piHl0a/15d3hQWfadYl6MRVvzkMglUTFzulEw95W9?= =?us-ascii?Q?OzS6V+uL2/AZD1M01QY5hCDJ+ryCLv6reqDth/EfuvcBil9arKAIvSQBlHDH?= =?us-ascii?Q?DkyGXJziR0yoYmCvUItwlic1X3KA1ta8tQsN90khwOAwXx4mwzyXKMjDzqud?= =?us-ascii?Q?1Z8HUGFbwyOydN0mDY7gLo1h/4JPUg0QAx7hoNzlFhQkLrTB0xBt8d8ri5jV?= =?us-ascii?Q?2dBl8whoN6wPRBJ8lkiYZ6vi7eir/ffaj12qRV7+pP//pGG3dPzUJ2Z1Hi8A?= =?us-ascii?Q?NDEYzRfzVuBcutvqnZ4u8nqEmjp0kj6jU2j0EmbN8poa36iz1lYG0ZGsYVbD?= =?us-ascii?Q?tDJ66Numo7+BNmq+DKaHbgAXTqNRm3I/pG23cUmym/c0BdNfXmZfyECRD2Su?= =?us-ascii?Q?T9HrWJDwXdF6rvymlBK4I/2p8yrdpk/+CPn4znSIQRMIOT314OYkW1jqkmUt?= =?us-ascii?Q?nBu23WRk0qBs+6ALQwJx/Qo4qQKIQBeSq9S0ZjJFIZbfsmyqj9OzSoNuZNLV?= =?us-ascii?Q?ig42+zgN12FvFEmSl3S5n6Rm+8ho5REPpuJ+ZtjTmhlmwmmiFWVUuIITj7KW?= =?us-ascii?Q?Eo+6yl1z4a/kceudznrsGTtdze7KWm2t3C9DHT+FHbb167q14z7EjlVqVxrs?= =?us-ascii?Q?K997r8eqIwEHsMILu33fwBLSw1zwF+rYOtbVnYlLnYeYQCokpKzrOFyb68cm?= =?us-ascii?Q?Gjk5GGV5y3iIxjA6J6FT4ESkOXEjqoOFdyqNHweAlJJ/ngQzwAjdKF8H56sj?= =?us-ascii?Q?CJBX08oM16+WIosAPcR1GUqC85yrtsIovVLumKeVrUmM4DiBrx078IcNOd13?= =?us-ascii?Q?jN8fpgzz3N8PhBixIVRu/5UFOmu54UKCSrOaXtp88LZSWsJmgxkw8WKOMysj?= =?us-ascii?Q?z+kMlNVigLpIOytRHfFr0DDZDS4+nlK8cfs/RD+3cQrbORCvbLVtXcWChzw+?= =?us-ascii?Q?8+rncS/h+w=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 476f4aa8-8c94-45ce-9fd8-08da2dd0b185 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:19:18.2211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6yGw1rgAQqjSTQdemUnE7KUDp0HQf0HekCbEkcRsEoVSScGHM24rYcCgiiiQW6DGKXw1XwLTEk/8Oz/48hKn8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6217 On 04.05.2022 15:00, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 02:12:58PM +0200, Jan Beulich wrote: >> On 04.05.2022 14:01, Roger Pau Monn=C3=A9 wrote: >>> On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: >>>> On 04.05.2022 12:30, Roger Pau Monn=C3=A9 wrote: >>>>> Right, ->iomem_caps is indeed too wide for our purpose. What >>>>> about using something like: >>>>> >>>>> else if ( is_pv_domain(d) ) >>>>> { >>>>> if ( !iomem_access_permitted(d, pfn, pfn) ) >>>>> return 0; >>>> >>>> We can't return 0 here (as RAM pages also make it here when >>>> !iommu_hwdom_strict), so I can at best take this as a vague outline >>>> of what you really mean. And I don't want to rely on RAM pages being >>>> (imo wrongly) represented by set bits in Dom0's iomem_caps. >>> >>> Well, yes, my suggestion was taking into account that ->iomem_caps for >>> dom0 has mostly holes for things that shouldn't be mapped, but >>> otherwise contains everything else as allowed (including RAM). >>> >>> We could instead do: >>> >>> else if ( is_pv_domain(d) && type !=3D RAM_TYPE_CONVENTIONAL ) >>> { >>> ... >>> >>> So that we don't rely on RAM being 'allowed' in ->iomem_caps? >> >> This would feel to me like excess special casing. >=20 > What about placing this in the 'default:' label on the type switch a > bit above? I'd really like to stick to the present layout of where the special casing is done, with PV and PVH logic at least next to each other. I continue to think the construct I suggested (still visible below) would do. >>>>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >>>>> return IOMMUF_readable; >>>>> } >>>>> >>>>> That would get us a bit closer to allowed CPU side mappings, and we >>>>> don't need to special case IO-APIC or HPET addresses as those are >>>>> already added to ->iomem_caps or mmio_ro_ranges respectively by >>>>> dom0_setup_permissions(). >>>> >>>> This won't fit in a region of code framed by a (split) comment >>>> saying "Check that it doesn't overlap with ...". Hence if anything >>>> I could put something like this further down. Yet even then the >>>> question remains what to do with ranges which pass >>>> iomem_access_permitted() but >>>> - aren't really MMIO, >>>> - are inside MMCFG, >>>> - are otherwise special. >>>> >>>> Or did you perhaps mean to suggest something like >>>> >>>> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && >>>> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >>>> return IOMMUF_readable; >>> >>> I don't think this would be fully correct, as we would still allow >>> mappings of IO-APIC pages explicitly banned in ->iomem_caps by not >>> handling those? >> >> CPU side mappings don't deal with the IO-APICs specifically. They only >> care about iomem_caps and mmio_ro_ranges. Hence explicitly banned >> IO-APIC pages cannot be mapped there either. (Of course we only do >> such banning if IO-APIC pages weren't possible to represent in >> mmio_ro_ranges, which should effectively be never.) >=20 > I think I haven't expressed myself correctly. >=20 > This construct won't return 0 for pfns not in iomem_caps, and hence > could allow mapping of addresses not in iomem_caps? I'm afraid I don't understand: There's an iomem_access_permitted() in the conditional. How would this allow mapping pages outside of iomem_caps? The default case higher up has already forced perms to zero for any non-RAM page (unless iommu_hwdom_inclusive). >>>> ? Then there would only remain the question of whether mapping r/o >>>> MMCFG pages is okay (I don't think it is), but that could then be >>>> special-cased similar to what's done further down for vPCI (by not >>>> returning in the "else if", but merely updating "perms"). >>> >>> Well part of the point of this is to make CPU and Device mappings >>> more similar. I don't think devices have any business in poking at >>> the MMCFG range, so it's fine to explicitly ban that range. But I >>> would have also said the same for IO-APIC pages, so I'm unsure why are >>> IO-APIC pages fine to be mapped RO, but not the MMCFG range. >> >> I wouldn't have wanted to allow r/o mappings of the IO-APICs, but >> Linux plus the ACPI tables of certain vendors require us to permit >> this. If we didn't, Dom0 would crash there during boot. >=20 > Right, but those are required for the CPU only. I think it's a fine > goal to try to have similar mappings for CPU and Devices, and then > that would also cover MMCFG in the PV case. Or else it fine to assume > CPU vs Device mappings will be slightly different, and then don't add > any mappings for IO-APIC, HPET or MMCFG to the Device page tables > (likely there's more that could be added here). It being different is what Andrew looks to strongly dislike. And I agree with this up to a certain point, i.e. I'm having a hard time seeing why we should put in MMCFG mappings just for this reason. But if consensus was that consistency across all types of MMIO is the goal, then I could live with also making MMCFG mappings ... Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320742.541628 (Exim 4.92) (envelope-from ) id 1nmF2G-0004q4-00; Wed, 04 May 2022 13:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320742.541628; Wed, 04 May 2022 13:27:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmF2F-0004px-S5; Wed, 04 May 2022 13:27:19 +0000 Received: by outflank-mailman (input) for mailman id 320742; Wed, 04 May 2022 13:27:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmF2F-0004pr-7Z for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:27:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eaf7eca7-cbad-11ec-a406-831a346695d4; Wed, 04 May 2022 15:27:17 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-yR9Von1QMPu5BFq5gj-nyw-1; Wed, 04 May 2022 15:27:15 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB8422.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 13:27:13 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:27:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaf7eca7-cbad-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651670837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BvJtktjFkyufefyAbwFObafdz8RoPHDnq29l09RLCdc=; b=PDorknEX25LpFoutFghmlYfzvXDQrm76nXwXuqNJcR7BLZBj7yGDRsnN13a2XkiGncIHNl H1uxXR1fVdyx5LwGaMG9JgQuhn+O6SVDih+J76OZ6R2Bzsm210p7xUwFfcdPoOfRAWadCm mH8PZKXWgIJpd8/j9UFl/GQH1kn/geI= X-MC-Unique: yR9Von1QMPu5BFq5gj-nyw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFIuwjTcUhYabI9+YXqQJKgw9k/yDpVSTl64eEwUosTPdiH8ZanueazlHy3MEyMPAfuCzTwBXXviEbZBQ8H7eWtboiisNKZ2HlimACs7Ic+1r8cl7GDFTGkJ+ERIxvG7UQR2NghR2Rjrz0WcT3P2S6eN2i8No0ceHvbAHXHfIWZKt08ME2unayFnjjMluvJ8/vyI4bs0NW+gGDzcrBDdN8e/trIq8kQ8c6i8YANUfsXizgzZ3u+fTl8hoKiXEYtNW5NRtAgx5l8fv/omMCRFWj2KP2qp4x0PwUzQkJtjhsmQU+ih6PTrvhlSd0Y2gOyN/LmGEbCmZ8Y7Y32ye+2isA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvJtktjFkyufefyAbwFObafdz8RoPHDnq29l09RLCdc=; b=QLnH9kZSlYv39iPKAew6pfobYkXt9EnYf1LxORwQiXVd/tGVwDQK+eZnwPH/9aDDr3+9U8a61WHF3/bbxV6DfTQcJNRLD2d9S6Rqvs4MXM6QV2oYwrNBQXhi59AGkypB1sNEc9ncMGCOOJaWIv7AiaX7Idbt8SgaKKJL/3m04o+nSj7ceZ9fP3eJEp3dJ8P0SOjrfWHETvwaPMnA5wuK/XnPF7t/QztrKUZenkPKd6JgXdI/9p2OEbTB6KZq9pHJqiANpvbrj6TWume6pfknjg4T4tj791dBKMVqo3fDvujLWDOcwozGTKcTpXBDwXXqMxO0zn2tWOEsEIOYi9NJLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5de2f283-f6fc-95e7-808c-4f3d96b25926@suse.com> Date: Wed, 4 May 2022 15:27:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/6] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220428030127.998670-1-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220428030127.998670-1-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0097.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::38) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e18091ce-2b71-4349-9ac9-08da2dd1ccc0 X-MS-TrafficTypeDiagnostic: AM9PR04MB8422:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JpsPJWXzAfGOocAbvnRCqjdJXKLFp2LYZYrm94XAsML9cq+bSKsoYZkAH/Y+ucRSnYPh7Xs9/MAjbcqOu1wozqz/BAFFsaBs8F0unonlOq4pb+4JDL3XcrVGfjZj9ZqT0Q/S0h6miZvL3M4Wom41gLNbBpGcaVVF6JgS9DJfBwG+K7ZIKCYrp4TxDnWzOOHBs2zXNFezGCDcrmw+Ki2PHPbrFiOCdtULNqnG4ZM6cM/TyeP7Yz8Zzknq7NyXHvh4ELAQeLJrFf2fgYsKxEsbcIuO9ZuHf9hEjicRILgSYvLndcc+J1cC6XEE2DEZTsIpUGIzCoGxa3uByZVxkQrrDeg+VAzAMWIWFNZ9UFe4STMsn1FS7YoJlOxdyLybTp2FYrxMBhtDPkpYjecB8KFEQB/YkYxPCelT7Ccs13pe9PEQQe+M6+AnHmU543srvagkcqtnv1Q31ZS9FNblGAvQqIu97csvei87x4B7zyWpM7URLa7lMGNF7n7DzvbG72UgFBj6s/zPFHGVumnuZuiqV0zoPGzrEViaJoYo7T6Q1M4DEkRCRQshVwQa7U/LYmDgfn7wThNxCiMm6oEpsZV0VuRqM+eD7JHoJySkMZy6VfhdfjE6zp6YGt17lzXLEl6A0aVRxbKFOTviNLGF/+Gg0Foe9CsYSnNumvo5v0fGHcwes0Qa9SMuVbSyT/th6+riS+oPJiJphlHlTwIpTePxd+0MIKBoIUAS2kIWtTo/9TC3wjPN6jYB+jSk387XB834 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(66476007)(4326008)(8676002)(66556008)(66946007)(6486002)(86362001)(26005)(508600001)(53546011)(38100700002)(186003)(316002)(2616005)(31696002)(83380400001)(31686004)(54906003)(6916009)(2906002)(4744005)(36756003)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEM4cTIyT3F6eVhBcjhXcEh5b2o5QWJTNm5nWmVIakVRQldJWHdMRzIwd1R4?= =?utf-8?B?RS9JVFRmeVAzSlNKVk5hbXdjNGZXaVcyQSs5K1gzbkRxMGVpc1hDKyt0bElT?= =?utf-8?B?QjR2RFhkdUt1UGN5WmRuTGlCTnloTUg2LzZCamE2emgrS3FXbS9mRGJvOGNh?= =?utf-8?B?NmI1TVFodHVleTlhbkJUZzNVSUhwOUtYRjlCSDFtejZFTTUzL0JPYlpONEVv?= =?utf-8?B?YjZJZVY2YkJXSlJBT3R2SnF6T1hEVlBuWHBWRHZFVHY0dSs2YnF4dmttVUN4?= =?utf-8?B?M3llQlhoa0p5amZ0M1BrNkdXaEp6MnJyeENFY2IwSjAzQmRkY3hQd3Vsc1NK?= =?utf-8?B?d01MeERldWZtUEMyOTBWZURqRGZlS0U5c1RYVXNhWVUrclBrS3BZVlM1MDVo?= =?utf-8?B?WC83Nlp1MzhSV3ZRSW11aUpFVmFHZzlDTlRwMnBMb2I3RHpXMWdvU0RUQVdp?= =?utf-8?B?TkVURnRYYkp6NktHVExlUmdyZERKMjUxMml5Z1l2SkNQRVVtM1BvN1drWURP?= =?utf-8?B?cy9mZjB1cTVJaElvZXh0ZWZNSXJnQTFBaVpLTGI2ZHpvaFN6QzNDaXJXNC9Y?= =?utf-8?B?WlUzeFdUUFJPUTBaa2lwU2ZtcmZaOStFTEtLaHd2NGMwZ2FiTGdaR3lsU1RQ?= =?utf-8?B?MGY2V3FyUGNLREsrcVgxbGpJTTIvcmlqM3NTS3A4aHhDYXFJc3pVbW5KSVFi?= =?utf-8?B?aUVnQ0pqeHZsMnZpdTgzVUUvbnhIT01hOGFRUWUzWXlYclJCZmF5MTE5QnJH?= =?utf-8?B?UFk5ZTlCUDlxRXdEeHpJTS92RWNzemR2Ui9rTm1tYWc5NGYvdHBMVktwbXJG?= =?utf-8?B?VWs4dDFCNFdvN003cDMwR3RrRVFjZzhWMDZpcGNta0dqK3ZOUTE3V2VaM3lB?= =?utf-8?B?U1RHZlIwT05Qb0pBYnIxZmxoY0xsc1FleUhhMTBmdnNWZnd2Yi9hQkpOc0E3?= =?utf-8?B?d05DV3lKTWJhL3hjNHBZYnV5dFY4TjVtM0lCeTBscFRZcXFCRVpRZDExcExo?= =?utf-8?B?RzJ2NWxjSW1FUjduYkNVUEpHeDlrS1Vnb3BDUjd2bTg2dlI3Qk1KcU1KVE85?= =?utf-8?B?WkhneUJ3a3VPVXBxTlU0ZlRYSWpmOVU3VXZsM3U0bzdDekhxdlVQc0plWVhW?= =?utf-8?B?ZHZURUNZRCtYc29iNUtOdXZVSEsrZG53RXhLVXVBcExVU2IxQkxMN01JcC9P?= =?utf-8?B?R3liKzNKcEdia0dJdjhQOTlWeVBvNUNjZFRNUWFSeWtyZlZtdTdQd1h1N2E5?= =?utf-8?B?MFc5SXVqZDdsQkgvRlgxdjFwa3ZIRWEzbXlmcXZwM2JXZGdFY1BiSERSNTBv?= =?utf-8?B?M0d6bElhWFphVHdtRFhUZ0d4SmdkK2liTkxkWlhYM1lNZ1FrODFXZU9qcVpy?= =?utf-8?B?WE9QMWR0UGJwamk1OWdSMEJVTGc0aFdUNFhXNHJGNGFPT1lnUmxwNmtIQURs?= =?utf-8?B?RHNiZzk1cDAwVGdTTXhuZnVndEVBNlU4bis0YWhPTlJIUmRCK1FURWNybWVK?= =?utf-8?B?Z002S0NmQ3ZaSzdZR2hReTVxOUJrZ1dKMXJSV2p5QUI0dVlYK29nemJKeE1M?= =?utf-8?B?bWQ3N0FVRVhmQXduSXhuY25wMEE3UjVCZXQzbWcxVDJ1NmJYSmx0M3VMTGpw?= =?utf-8?B?VEdVamhnMXMvQW56bzd2VWJoMTdsbU5SQWd4Um5HWk82U2VvQk01L1IxQ25v?= =?utf-8?B?VVQ5M3NDNThnSWtlazF6NytoUWFtZ056c29wSE9OS1FDc2JsR21RS2RoT0xK?= =?utf-8?B?MHNXMWxoN1Z1QUE2dTN5K1JzWkRXeDV3bDZMZFUzN1ZIa1poejJsQStUcEMx?= =?utf-8?B?SUlBZS9hOWFneUZBR3g2djVhNkRyQWxVRGwyeVZnMDFoUktqTWEzR2U2UFJj?= =?utf-8?B?bnRaRTNvdVhuYVNjdDlFdEhXa1Q2RFcyd1dCc09SZy9nOEUrdTVwdS8wL2NG?= =?utf-8?B?b2RXWjNqV3JaZ2F4Z01PS1pCT0pNUVQ5aFpJVEFrVWFpckFNSWNoaURnejFz?= =?utf-8?B?aTZEa0pXUXdYdjlHaWlNY21BN0o5ajRCeUZCMXZYeG04cE51U1dhZTJ6c2ZJ?= =?utf-8?B?elJHWDYwMVZYSzlhQjNkaUc1LytsMkFLb1dYcTBjOUIyUlVVM1lOSVVCY05z?= =?utf-8?B?bGNKMlJiYlhoUFdQQXFNaStld3lCVEM0eitZMnBRQ29LUkVuNUZ0cXJNdU96?= =?utf-8?B?dk1SOTFxRzBTWWxXWENDeHd6c1YzblQzUGVhWlZpZnpPQXh2eVNYelBWRG4x?= =?utf-8?B?NEJtWGJORFhoTzRmVE14dmdGSHlqMUpBUzQyMWtpbldiWWpGREJZU0tQbVho?= =?utf-8?B?NnA2TDlRMUdvWTFjWjM1RW1tRDVNTnV2SVI0c2pLUnErODd3cnQ1dz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e18091ce-2b71-4349-9ac9-08da2dd1ccc0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:27:13.4810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /U5/PR8KD2IzScYrWXdiHy1jQq0+WaH9ovy/x/bMviG/d8JrmSJxLGKpmycjM6P9i1FCKNmK/W6D3KBOUCi8Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8422 On 28.04.2022 05:01, Penny Zheng wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1443,6 +1443,10 @@ static void free_heap_pages( > > ASSERT(order <= MAX_ORDER); > > + if ( pg->count_info & PGC_reserved ) > + /* Reserved page shall not go back to the heap. */ > + return free_staticmem_pages(pg, 1UL << order, need_scrub); With PGC_reserved being zero, the compiler should CSE this call. Hence ... > @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > +#else > +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > + bool need_scrub) > +{ > + ASSERT_UNREACHABLE(); > +} > #endif ... I don't think this is needed? Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:29:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:29:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320749.541642 (Exim 4.92) (envelope-from ) id 1nmF4j-0005Qy-ER; Wed, 04 May 2022 13:29:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320749.541642; Wed, 04 May 2022 13:29:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmF4j-0005Qr-Bc; Wed, 04 May 2022 13:29:53 +0000 Received: by outflank-mailman (input) for mailman id 320749; Wed, 04 May 2022 13:29:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmF4i-0005Ql-GF for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:29:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46b87242-cbae-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 15:29:51 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-M1Fa6z5vOqqHdgO0E-AT7w-1; Wed, 04 May 2022 15:29:50 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB8PR04MB5851.eurprd04.prod.outlook.com (2603:10a6:10:b1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 13:29:46 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:29:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46b87242-cbae-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651670991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y9+FwQel3xlzm+ts3VujKHKpahUBSQESjXCgj5tGyjk=; b=GYXQEzRRH0DIefA2ES6jucZ1LniQXQ6dpL6kRBmAQe9apbZNwOxd+e2Lu90cLO/MbI2Ykl tneYN/tO5vIg0eavPvc8U5R9fRc08q8wzcMDZLR9zrad+YdB0pVwvzVxEZxtCeQyBrqWF2 AUos5UWb7lSTqMnyErhoTAeFyCl53i0= X-MC-Unique: M1Fa6z5vOqqHdgO0E-AT7w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gpy2r+MDovDcNjM4ebaY+UqmzIWP6WKCNvgChU3gkjOIK6cPB2qA0PMgprKCo/J9cvuM+D2ZHueKTAwBJ4IGXbIZGDEaVREYzyeP7x/cx10hf5xMXt9LT9MVbezBzR6jMevnPqO7Ue2tSuCJttEZbv0v1keG1pqXgXhBQ9U8MinHOphyrQvPkpssWcaZ0Uz3wWVhYzt/6U+NZsDuiewPkI2Mu3NJDX2n5RwTMW+2n1FwV4sSVBmqqAX/SqjgsPiO9ifm1oFH5WyhyAcnN8pRqxuOrL7CgR/1Ck0pfJ86xhsNf0VTAyfRajO5fRTYTVUE9D7SHOgFOsZhZROeNvNYeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y9+FwQel3xlzm+ts3VujKHKpahUBSQESjXCgj5tGyjk=; b=A7Dm754bpMUrhAUMmSgq49nYUD81gu/LEKUCEbMBrM8yiyTI8J9irEZB8SDPdqbdAUxUct3FM+FApCcbh9lH32kFwbgVstEdoRUziSfHQBYdJErHOh8iezR+/iYM4oSZbhbgNi4ClSWk5mxv62PoRmnWiLHygWadyxJJkkePMuEBDeNKSCC4Jzdc/aAihMX+V7i6G3amPMPMMpIRuV0Pz7qoni3VRxO/F2vsT+J2PO4GPsfw09qJuhDGboclERnTpbqX9NhTULE+vQkKn+VIr6/7sNSjIFanY8Gh6tDFJKrCLgOenx2R4eaO1O86gdQtBRoDIKVaoBUyc58bmOgiFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ba5fb49-4cbf-916f-9d8e-4b64211fa87c@suse.com> Date: Wed, 4 May 2022 15:29:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages() Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, henry.wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220427092743.925563-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0010.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::23) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 939215fb-cbd0-4ad3-58b5-08da2dd227a1 X-MS-TrafficTypeDiagnostic: DB8PR04MB5851:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z5yXe80XQ6G+Q89Xe4DLzzS1gvrVkpO49C4FhQschL11kj//q7aT9pajSkIvcGHZr6NhOlPYPoeX92veyzwviOHk3oGNlIeEIVy3C6kOI3tKwGsRIHn0tl4WF8I55txPyFIq93xCnCr9QQ0xBAVwYnqdi97g4WiSGlg9kb5pAKlnAiFcm7YRJBFfymZdoEGoLY3XOPaOh5WXtr+NgeFwMTh0jCYE/mbUAZfb8yNvlsc6HNRoMtLmboKIdBT5eKHUi/RMzaM0KppoHNxh8Nq2+xAkECQQIyg89Qzsse7aUOEcDnTP2DnJFhzstoxRXHSoh6bQfL4vYd0W7+5QWqPKCL0fiW//YB4273U5Dx6ZoKJbnk3vRMzFaBpyZV6LA95UqFEooUnheV21aePqYRpw2bvmmTAscfT9k/zA+CA5K5zmqq9xSIK/pEO454ak+5n/rzJAQhlZF4/D75PIFSVG7GzFsoPXdki9/ctFKPwYvsJ7U3n+svZcP+zFBEEpAJDHoJ8G4QaEHWJ35qLnoqbGtzPc0iOoL7ALoY4bmxWECYJ+kEgM63XNjV4zQoIZflvbm0p1lYhUI9VN0H4rCkQzbjCAAwrQbEMOednukgCltshwm+iP+HGC84N1IMS22Ct/WUMdj43+yT2JrPyNm8ZSi+9YN7MAk/PwV2MCPeoKQIImKTc8fRk0H4iuxSJUT80FbsOSW3DGNLtu+tU1ZbldBriIKTpSKa01k+LSxDKhnD6rNAO8h2dlV8YbdZhSb1ev X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(2616005)(26005)(6512007)(5660300002)(508600001)(2906002)(4744005)(36756003)(6506007)(86362001)(53546011)(6486002)(31686004)(6916009)(66556008)(54906003)(186003)(66946007)(316002)(66476007)(31696002)(83380400001)(8676002)(4326008)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2N2TnpRaVgwODdzbFl5aUpvSURIV1NKWjBwOU5RWERNb1dla1ZxT1l0d0s1?= =?utf-8?B?b1VUSDBHbURydDRRbVFiMXpiOG9xYS9zL2d5U0xLT3dTNi9ZOTdIZlhWMkxB?= =?utf-8?B?andPSjJpWG5JT2tJOS9XMk40K3JoYmp5L0NhTEtsdW1HMWVmMStTRElBVjV6?= =?utf-8?B?c2hPVlBmM0VmM2lJTVllQXB2T3lCcFByNENGeDNqU1FoMjk4UVloR1B3N2tp?= =?utf-8?B?Zlg2ZjJpRTJ1RGU4VUZwUjU2ak5RZFdxbnhBQmxxM0pHRCtPaWRSMFFWTmtI?= =?utf-8?B?eC93Q0Qzd1k0S0ZkMlNuVDRlbmQzeG5MMlFCVWQ1MlZLeU0rdjA5Tkp6UVJJ?= =?utf-8?B?KzFvWi9VOE5Zai9GMFdGaXlxVFN1K2pkeHdDeW1Ea3h2cGZ0MkFPOVp1dERY?= =?utf-8?B?ck53UVdySk13ZEhwVmcrOEpqdXJ5aWxtSWRCQTRzclVIOG1WOEFtNHBReHdt?= =?utf-8?B?SDk1eFhjM0thanBYT3VMaTFsUGEyZUc1ZHJmMlJETmZhSUx2YmcyTThQTUd3?= =?utf-8?B?Q0d5bWRBZzZ6V2ZGQnBjLzlneWRTSVNydnYwK1lyaUY4S3Bjbng5OGx2QUx0?= =?utf-8?B?THd2KzVzR21aaDBIRkh0L291a3FadGRzSGRITUk1d3J4ZUhLb0d0eGlwYUlz?= =?utf-8?B?cXhiV1dsVVRRU0QzbWtHc3U1a3Vuc0RFYnF6a1ZqU2dWc2l3QWx2YjBuUlc5?= =?utf-8?B?cTRaaHUzQUFLYUJ5clVyRHZrOEFIZDgvdk01ZVhuVVp1WFNqN1pqejhOcFpY?= =?utf-8?B?ZDJGbkFTaUlPVEVVZnVxT2JHbmxac1hSczZFMmsybGF6TVd3ZWpHc0l5d0NV?= =?utf-8?B?NEdkZUhOUG9uMzJUL25mUGxGNlpZWWxDSUxwVDdtaWs3Z0Jrck1jWEpFREs0?= =?utf-8?B?QWUzaWtxbVhhZzV5cUtvTGlBbzU3c1krSkY2TkUxb2tNSHY5dlpPQ0tmYnNC?= =?utf-8?B?c3lxc3VESW9wemZNQkRoNGtZSENiR29qbUxqQ3ZubHAyeDFYTkc2dWdBQ2tM?= =?utf-8?B?emlYdHF5cExnOEpBTHhnd0hFbkJpdk9Fbi9TZWpxVXhBRVQ1UGFQU0didDJO?= =?utf-8?B?VlU4cGRpNE1aMHQ3aWFjTGdLdTBIdzRKRElHemlYMkhkVnlHK0RPU2luU2x4?= =?utf-8?B?SXp4N01oZzI2cm5JYjJ0MytndFkvbGlqdjhNajROZjlJZFk3ei82WStneWlI?= =?utf-8?B?WEZsaXoxZ3AxcFJMbk5Ob3JWeXJKUE43NjRKcEhKdTNJbWhmcVVYV1hpRDc4?= =?utf-8?B?R3FibG12VEZRL1E1QnVSMTR4SmpPa2t5ekJYc3NMdGF4NUVNWFVKTS93bDRj?= =?utf-8?B?TVNvTUVCUjFkbDBwZ2xWSzFqWWJZVXlZU0x1M1ljQ1BZUjBibXY5emZHOEZs?= =?utf-8?B?Yk1PVHVrTFBFeVhWamcvTW5SQlhEZy9oVVRxQ1Z4UXFkdGpQem9XQkhvemZT?= =?utf-8?B?VC9janFxdE96ZElTeC9rb2ZQR2lERG1oWG9kTUxPalNQaE16OVVMZ0JXNDkx?= =?utf-8?B?dFZmQkovaWhyays5RHFWbVBubG52N3VkWEdzdXg4RzkrYXNpVVIvNWZpc3dw?= =?utf-8?B?NHhaQ0F0OGpqZVlRaGFFRHkzMkxRUW9vb2VPNGQyaUo4bmdWV295TEc4cDNp?= =?utf-8?B?WE1Jc0prbTJyeFR4a2pJR0wyNnZMOEh1SVcrZXEyNVhHSXhqY3BMcERvWEpm?= =?utf-8?B?K21NVWdrdWxWYmY4emxHdldlL1RUU29KSEgzYmFOVWxVaTNaSThTc0tJSzZG?= =?utf-8?B?cU9SY2U5WFhUMzdhVHlaMFlYS3ZxNGRnRGhOS0hPNEc1KzM1WnNsdEs5ekdX?= =?utf-8?B?dHZpNjZLWEVHZDBoVC9pTWhVemVmbXJMeTdjZXQ5Z2orKytpZmtPdC9odW8v?= =?utf-8?B?REJrSUk1UENUQUIvem9RVis2VUx2dEd1T1BhTVhOd2F0OWl6eU1waHVuZjZE?= =?utf-8?B?TEdYbE81QkMxVExhMUZLWlhZU2hOZ1JzT2NPa2JwMi8xZWpJZ3RqRG9qYkN0?= =?utf-8?B?SVRXS2RyTnd2cEh2cEJQS00wYjBWcWVMTmtKS21MMW9yMExNWWdxa3NhTEsx?= =?utf-8?B?Yi9sdG9STXdOWExHRkVIeHZrMkJCb1g4bXVidXJWRmVGSnliMEFlWVRHS0xi?= =?utf-8?B?QXFUaDI0TENLVmtaeWdyRVNxQ09laVB0VEVFSVFiNkRTam1ockhXMTRPVDcw?= =?utf-8?B?ajFkOFZGYWU3bVFkb1hobTVsWDlaMHZ6cE8vTytmd3U5eUhiQUVwdFdwaXpC?= =?utf-8?B?M2RQMXBxNkNnZEpYcVNTaThJemc1MjFSay8xZ0k4RUNFaXh6VGk5U3p5RkNI?= =?utf-8?B?M1J5OSt4Ky85SGxmUjkxcmlJcTZaMnNkRytmMVlYSHhGWGkrbjdRZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 939215fb-cbd0-4ad3-58b5-08da2dd227a1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:29:45.9176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K5p4CpRrKESz3Zr3MymauNb430t8o16JzykN0ZRj2/MfvdbIb1KE1jBIDGB6J2jxTNIcpcqbEaSv9plaH3Zb2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5851 On 27.04.2022 11:27, Penny Zheng wrote: > There is a slim chance that free_heap_pages() may decide to merge a chunk > from the static region(PGC_reserved) with the about-to-be-free chunk. > > So in order to avoid the above scenario, this commit updates free_heap_pages() > to check whether the predecessor and/or successor has PGC_reserved set, > when trying to merge the about-to-be-freed chunk with the predecessor > and/or successor. > > Signed-off-by: Penny Zheng Reviewed-by: Jan Beulich I think this also wants a Suggested-by or Reported-by (iirc) Julien? Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320756.541653 (Exim 4.92) (envelope-from ) id 1nmFJB-0007zE-Tw; Wed, 04 May 2022 13:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320756.541653; Wed, 04 May 2022 13:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFJB-0007z7-Qt; Wed, 04 May 2022 13:44:49 +0000 Received: by outflank-mailman (input) for mailman id 320756; Wed, 04 May 2022 13:44:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFJA-0007z1-As for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:44:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ca18f9c-cbb0-11ec-a406-831a346695d4; Wed, 04 May 2022 15:44:47 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2174.outbound.protection.outlook.com [104.47.51.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-1YeZStKJOSC3bckf5qsO2g-1; Wed, 04 May 2022 15:44:43 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DBBPR04MB6235.eurprd04.prod.outlook.com (2603:10a6:10:c4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 13:44:42 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:44:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca18f9c-cbb0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651671886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kk26KPZ3qaX7PUBimH8FV/lVXnDPWBg6rQVr+FCT1Hk=; b=nRx1T51zGrf2CTSxzEGW3W2XOGNf/u3Q2rxdmyPlNWWdSMaJVoAL/rmMzC9tXZCo9UM7KU MjgjhRlp0Ip7q03FzzK/M2xCQIOpp1JwAI3kS8K98/HhAS+jEv/0ewcmJwzDFFpgANDN2z 22/zKufmNfNKL2DAn63YmwRYyYZwWs4= X-MC-Unique: 1YeZStKJOSC3bckf5qsO2g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZYdJCffISq8lC0mZ6EX6aWQb4tzhbzA91bFnvjI7/uyn07pjiMOXQhU6Mvoh+sZVjwz9kZGNpQAwAy49dUyD/G5x0Re4docbzNI8huoUZzRqvwWfgXGnhfDcOp1EEBFWV+3paQqqmi1n9CHaYd05ijTRWQCyeQJXuNG5NzfvDiXPOT+KaW1/GAuX1/6MgietSf0gROtNClyEPZgyYjXMxvIqIfqocmStYthjS8mamjr7FRBzulDPAdPic+/CAo4c+zLfWTjCn/V2xVixzliwMB+3/PQ+Y+b5RT225tBxjG9eclKD9pViw3RwGBmdwPSZUaznNbR04AfinXDpRLmGpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kk26KPZ3qaX7PUBimH8FV/lVXnDPWBg6rQVr+FCT1Hk=; b=cq+e6kvvRWlNqXZSgB7+JTdSVhwSH0gJLCnGkMc0kqp29iTbFHSMg2+9+Rso6PGgeHUwzvrHVPi4Jddf2+rSNt/kYoXQZPxX3+/dFzgr8IdFd5604XPcGU4wpyvVzkmlxc99rSczH6iRe8590/CBuJcHL5Fy0sF3I4TS+NrcRjJiOQ2aIIUGszqR9EXP3OmMDKxCjlIGYYrZJWKdB+IRFD9WtbC8gTk/JybA+v3PrHuXAG75IySniJxaOvEDEiZxhogGaCfw4KA6Gar2xCGd4e74jPYPpXoWpQjVa1dcOtxEzLqyGfJzoCR+sl6AEaJzwzsdeTjWfWzx+ym/LccBXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 4 May 2022 15:44:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, henry.wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220427092743.925563-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0051.eurprd04.prod.outlook.com (2603:10a6:20b:312::26) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b92b6687-af6c-447f-4845-08da2dd43db1 X-MS-TrafficTypeDiagnostic: DBBPR04MB6235:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qvfIEHOYd4cYGg/1oyvw7Xt5jS8S2iQ1caGDxlbgT+MqUtlcdjH/zwp8A0XBWB2eluBwslPWmlZ7ysEuJ2XhmHRfQutlOhyKsWUZnqx0c9yuk38wKX8BVVEx1wiNTUTiyGN6Y4RXv/kuhRB9IFk9kDdSlpb+cTuorRRBv3sHv/vwrQbLf3KP+k5jH/ZooFuvR9UNAZwOBUdlcLmpNBzmxV9fdMOENlqv5LyC7hYxMTMgQBaOywpcngv3ZQPTbvk+RcJWtmipM3j5GciCxuISQwLQc6vYqlG/YFC/PK4YlwHkBzMNwgQsGrrgLg4T8fxkrDdquvy4PzP1UOlQYKUWu9ygqoCKn8Z0h2B5BawnwvUFndC3HWu4MOgAKEyCd5F7Zp9ieDSu4b/PFapmePRU4K/rN5Btj1lFIJQegGZTtOhnaNrxPm9htpkg3ZM1tYyOfQQPU7fobNcmBGRRrLHSuoglEMoKoWzyQ6Y9SOMy2mlxtwwHMBYqha6DxTlnF+ub8tNGBn37T0gcwYtLK/1P9HacReCmtcfMm6vWRrgWDg9yZITXh8xPZx8K6tQ1WogCftAth7iYJIVs82bAEtt1HdxukWC6g5UmH4PDAt6wHIK3NhZUCSeGyg6pHMXG4XK1/ibaOzCZ1Ryt1yhr+LUrqUjrnfbq/FcfUEifrBQS/AODmnANWH57lNDiRdJXbbsSYQFigDVerO+kVpRZqjIyWwRNjDErvaTy756FbXbTYL2kZVHXDHrfGVXlAl/+czKW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(83380400001)(53546011)(6506007)(26005)(6512007)(31696002)(316002)(5660300002)(86362001)(186003)(2616005)(8936002)(36756003)(4326008)(8676002)(6916009)(54906003)(66556008)(508600001)(66476007)(66946007)(2906002)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDlYeUNNSGx6UmxXdWtGMkh0U1piSkl1dDBqaUdKU0Y2VjBaVzRYWkltZEFI?= =?utf-8?B?T2lwQ0pQUERCRFRQMUJqYTQvR1lNTXZWWmlDa3hQWDJMK0VQblZSSEFMN0Js?= =?utf-8?B?UWhtY2tVMWRNK2hHY0FOeWlHWm5KTWtPNzIvckZsWTF4c3dycEYrUTl0RElY?= =?utf-8?B?MGk4emhsZGhmN0JSWWNRd3RoZFlMQm5IdVFjTXVmYWorTG54QlZsVHU1aGpE?= =?utf-8?B?TjNkRndCZHNacS9QeUFLeWFCeFVRVUNQR0t6Y0VVZC9USkFwaHI5YkhPUmVh?= =?utf-8?B?K0d5YnExbjM1d3NjVm5xbnhBSmJOUWdmUzVBWUoxOGJOaHZvb3Urd1hDc0Nn?= =?utf-8?B?RjRlcVJ2eS9kdDF4Z0Nqd0lJZGZXQnZES3ZLNWRGTElhU1JLV0o2TnZUWGsv?= =?utf-8?B?eWtPVGlwVHduTWhvVEdLNHBxQ3g5ZGlxR0tMZldObURMbWNYV0RTK2JkSGpL?= =?utf-8?B?ZmdsOEJ5U2RSb29wcHNucG5HZ0ZWQkZXUVRSRVY2eGJUSi9zaDk4WTBFUXFF?= =?utf-8?B?Z3F5QTRBMXFjTnJoNGZxRElCL1NOaGJoTmd1YlM2WVhtc2IydEJncUlHV0Q4?= =?utf-8?B?MHVPYWk0VGJJc29GRU1pTnJPWUFsRnpzczF3M29kdnFuZGVVakdZSFZMUHZq?= =?utf-8?B?K21LUUR3MnlEYm1lU0hjR1NISlF2RlVkNTBmdm84UXdlampaSEtXaTg3NTlE?= =?utf-8?B?VTFzdFlUSzhNdjRPMEtIcW1iOWFPZ2Q3WUN2L3NhQ1IvMTFEaVpvUWtLZTE2?= =?utf-8?B?L2xxbG1ORk13MjJVZ3NZMExzK2hsay9uRmwyRkxxaTZyZlVlSG1CZ0t4QmdW?= =?utf-8?B?UGpxOGMxUGJyK2g0NWJZN1lKekRRSE0xdVlCckxDcnJxSldhUWxQK3NnNDRa?= =?utf-8?B?WW9Fcy93RXY1eGY5WGoyNTlJWmUzdm5wK29kSWhkdmN0a1J1TGpUTzZ3N2E3?= =?utf-8?B?TXF2eTBhL3lia3hUbVhZL3JpbUhvN29xMytKaVR6cVlaWjkzU1VxSGdqRSt4?= =?utf-8?B?ZkdTVFJ2UXhxN3ZETUpISnBaMDlmcjFlL2pWT3BCUkpReE9mK2VRa200WmFn?= =?utf-8?B?K2NmRXVTcFRMczYzVXErblBzMUJtczNhbnNkeW1GRHJXYkp3TEFPaENPQkwx?= =?utf-8?B?NHM1NnBJSHIvNEF2MWhjc3NPNlIvZUZhYmpNR2tkaEV6SmNmL2lNOG0vUUhU?= =?utf-8?B?VGdROVIrNjk4SCtTMTVZdHhpVGVFalU5c1hyN0RjNzlWc2ZiQWpic2wvelBF?= =?utf-8?B?ZVYrMU5xNXUwbWFuUzVLMUhmOXoydVNhYVNjdTRTdDNRL3JmTk5vV3FuVXZE?= =?utf-8?B?STFwbVc4SXFaWDBRYVdGaXJLTmNiQytCZTFOWEJjZmdCM2plaHVVQTgveExG?= =?utf-8?B?QkFTa0JUSXVFdGVLNUJNTXNJQWM1RzRFYW1GQ2Q5ZFkyN1RTREp3L2hOa21p?= =?utf-8?B?bGMyR2pxNHVWeG9Mek1DMjlRQ2UyWVVUZEtuQlBWNnppaWxYc1E2U2VTdDdL?= =?utf-8?B?QWJJQ0MvL0FrTUJhdVNraEUzcktEclRDSk9GMUVRZWtjWHQrYldjTFNwMy9y?= =?utf-8?B?d1dnZGRhNlgvMW9JaDJEZy9FNFB2c1B4YXlvTnFFVndhZEl0bzliUVNlOWdh?= =?utf-8?B?MUI0QWFPa3VZU2JpeHZ3VVZvbWFIZGJkSDhUVExpZTUvV0dlQlFndFBaTFk5?= =?utf-8?B?V3RvcFlPNXRrS2gvVEpTZDVpaUU5dFU2SUN2UVovY2plWmlkekRKWHVVenVw?= =?utf-8?B?WDVnOXAwbkZVYTRnWVNDVkpMY0ROSk8vMjNZbXBob291bFRCOWxDRkN2OVBY?= =?utf-8?B?SFI4N0wxWnFSYUZjS1BHMkRkNVVPMFFZOUlCZTc2Rk5rQWZGZnNJTTVReUJn?= =?utf-8?B?cGlyZUUyelBueWZHTklwTHkzaTJSb2p3aXVIYmxqSXJRcEk5S3p5ellDbzlR?= =?utf-8?B?NlE0dHRDSVdxZkQ5QTFBQjZLaU1JNXIzTnp0T21WVWFVVWJNMFIwVHdEdXFE?= =?utf-8?B?ODFPb051Yk91SFF5Szd4Q0g5YmVwSDBkaTVhL2c3dVdsb0R5blUwZElBYXBr?= =?utf-8?B?OG4zTS84YlNEQTVOMVpub0E3cnF2U3ptWUU4N1cxaEpJMG5ZMTBjdDNlNCtq?= =?utf-8?B?VXRaZGc3OUdsTlFjNDJIamRONVd4ZytqU1dGVFI4ZWNoNG9HWU1VRVFyL3pR?= =?utf-8?B?RHFUZzI2OFNXK2prbjZnV25vZnV2NXdFSVZrdWk5Tjd1blpYRXhBdHRxNHl1?= =?utf-8?B?QTNjNFYzakgxMlkyU0N5ZFErQkM1elNQMHRxVXdTRklGWVRuZFZrY2RyMUI4?= =?utf-8?B?M29yQzFsRVVIN01OdlVaNHBkc1VWbENIekdzaGFBU29hTURISTV5UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b92b6687-af6c-447f-4845-08da2dd43db1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:44:41.8781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zGWyr6nuyeBdinYQlpnJelA6TGhGVNm5U2CSEssStKEcftmAHU4MS33eP2Ihk34D4HH/BwyCFG2JcyT52hwlDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6235 On 27.04.2022 11:27, Penny Zheng wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) > > mfn = _mfn(gpfn); > } > + else if ( is_domain_using_staticmem(d) ) > + { > + /* > + * No easy way to guarantee the retreived pages are contiguous, Nit: retrieved > + * so forbid non-zero-order requests here. > + */ > + if ( a->extent_order != 0 ) > + { > + gdprintk(XENLOG_INFO, > + "Could not allocate non-zero-order pages for static %pd.\n.", Nit: "Could not" reads as if an attempt was made, so maybe better "Cannot"? I'd also pull "static" ahead of "non-zero-order" and, to help observers of the message associate it with a call site, actually log the order (i.e. "order-%u" instead of "non-zero-order"). Also please omit full stops in log messages. They serve no purpose but consume space. Finally, here as well as below: Is "info" log level really appropriate? You're logging error conditions after all, so imo these want to be at least "warn" level. An alternative would be to omit logging of messages here altogether. > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2769,12 +2769,50 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > + > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + mfn_t smfn; > + > + /* Acquire a page from reserved page list(resv_page_list). */ > + page = page_list_remove_head(&d->resv_page_list); > + if ( unlikely(!page) ) > + { > + printk(XENLOG_ERR > + "%pd: failed to acquire a reserved page from resv_page_list.\n", > + d); A gdprintk() in the caller is acceptable. Two log messages isn't imo, and a XENLOG_ERR message which a guest can trigger is a security concern (log spam) anyway. > + return INVALID_MFN; > + } > + > + smfn = page_to_mfn(page); > + > + if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) > + return INVALID_MFN; Don't you want to add the page back to the reserved list in case of error? > + return smfn; > +} > #else > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub) > { > ASSERT_UNREACHABLE(); > } > + > +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > + unsigned int nr_mfns, unsigned int memflags) > +{ > + ASSERT_UNREACHABLE(); > +} I can't spot a caller of this one outside of suitable #ifdef. Also the __init here looks wrong and you look to have missed dropping it from the real function. > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + ASSERT_UNREACHABLE(); > +} > #endif For this one I'd again expect CSE to leave no callers, just like in the earlier patch. Or am I overlooking anything? Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:46:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:46:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320761.541664 (Exim 4.92) (envelope-from ) id 1nmFKa-00008h-7n; Wed, 04 May 2022 13:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320761.541664; Wed, 04 May 2022 13:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFKa-00008a-4n; Wed, 04 May 2022 13:46:16 +0000 Received: by outflank-mailman (input) for mailman id 320761; Wed, 04 May 2022 13:46:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFKY-00008E-Rn for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:46:15 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ee3a86d-cbb0-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 15:46:13 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 09:46:10 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4514.namprd03.prod.outlook.com (2603:10b6:408:36::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 13:46:08 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 13:46:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ee3a86d-cbb0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651671973; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=snpqByTeNhnkshO6Ej7j8drnkDQJ6eOt2fBCEgmQIog=; b=AE1/b+q4mu1s3LJgRs4/M5Yv40GcEAw0Xj0T5fvrQDZ4kSz+WDAwS5Vk c+O5jNTrlR8ybF7K3EyKxkq1bQm9ZFezZZwIBhmpD2R0SzpDdUZaFscoW FRSfi/Vlj7YWtv/nWgA6bg9H47IKyq/cxxNwXLFQeQUKGuiZaxBS+xNXT I=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 70554396 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:148p7anvNh2uVYbW1E8SLNbo5gz3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIeUGGAOKqCZmHwfdhwYYXn/RgDvpOAzoQ3TVdopSExEiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW1/V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYDjsuEorGh+IhTRRnKgxVOfIY07L7GC3q2SCT5xWun3rE5dxLVRhzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkBg25YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8A/I+fFmvQA/yiRe9ZLhNfreWeWLavcIg3+0+ mPKwmPmV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUHBBqlz6PV50OVAzYCRzsYMdg+7pZpHHoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1bUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:uzp7/qjblVEsrUCjM6B411XSL3BQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="70554396" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdRE7OLD90ay9o3cw37Xy4AoFZZR01i8LEGICk2Q19VLUQ5fm2OOd9egRnd1krTbH8VFiya7DEhBzN58ZOvRcOL1CTNcNdhK0pdtZMoSn1lTzuIjW1uI9lce0VlxrcjdBox6I/r3pBFORPKAfhTg6BylD8wsSt7NW2kpiEjDjJte6G2N86nRhWJWAIzblKkSrsFitqSBcO/BEqC4OR1lMixgYnRPMifbtsdSVl68g3LyxkBIFbCLFtJEEBg0+nVYv3Cx6Cc245fHk80g/2br9mcIpzm8I5Jr8k+lQkV+GWRWYprCG6L/M/mXi6FmSEbnqcxZoS9jzkV9olkKxNNQfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rYz58vCxxnV2QVO4SVjnndTHHlvJr9hq45F/UFYdlAs=; b=hY1YOVuyFvq5H2cSoc68PBI+g6h/vT58X28EhYfpGeUVOnRoJ5Bmlys56OaxBdOgnWEBJItvOnmg331OrIwC9iXufVj70tw5Ib7nz0J6kaSiPXb4qHU8WmDTvL2OG3eCA9VQQyR9xfdBCxAY8ybgVwb/UrPmjDWRzZEmEBeM2v0Nnp+zNb07sKwthjjcBSGspLF2b6xBl4nYvX27OjZMRUIa82PcXfUS4yAm5GCNHKNrr5cBZ66U/mhxOd7282DAEcxXVvsALQbOe7d7G0sW6xrEfgnlprbxCSF68DIreKLvCeAIZAIDomBh/aKf+DelXVi2xnO3n/1OaosCHBj2eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rYz58vCxxnV2QVO4SVjnndTHHlvJr9hq45F/UFYdlAs=; b=eEZBml4bKpAKuNWEVHoaVKylhnB7hfXS7hMcxK76WVufA9dmHjNq7+e2CItmqu8DtENW0GolSOijwqm6X7swfRBA/11CWFh3vhvi2+T8hvJRcAipIxJC13IU7P2bdswjKqe/pVtcdI/G5EI5KOP0uCWPHRAcrRiASz7vXkK6qqU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 15:46:03 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> <66587a43-02b8-20c6-2663-4a6fc3e010e2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <66587a43-02b8-20c6-2663-4a6fc3e010e2@suse.com> X-ClientProxiedBy: MR2P264CA0177.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7bd5a18e-c9de-49bb-36f3-08da2dd47106 X-MS-TrafficTypeDiagnostic: BN7PR03MB4514:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fxTp/neBKMYSu1f9jT5yoc2wiJI/GOZd/Blh6ffz0yoW0YLlYwuXe7YUvG0mmKMZW1XgzcTmYsHJVqDsSqIY6R8RjitYPyrmnLeo0KZbUozYTA4ZQw1L4SLogWh7xU7JfKoRx4pFvpGuxMVj4UlzTIFLEFsbvFW+kabR7/tOroO8BvDICXTeODP8fk79lPT5kuo/o+cxtjwhFJY+bFXnTJyZ6jlg+2dSh8umUwyt/0I33Xeitxanhaz1q6qOLH8kYo2Wk5hInfT4DEVn/itzUU0LdGX2+xB9Q2uCpGb3uIumiEaHVGXpoRem4xz5+KZRs4Z3zmgK4Yye2zAjDWojhKvdhvNRJ2Ue8EhNg95BhbtltboHGRBNIJvddGRM0/bDVGsWERHyvKYYAoeDdEvIA+TBsIyTTOZb3fJIjU8TA/lmY1LjyrOfhqagqXV8WumPoJwGf4gu5QqGpl1MA/fBzaA6DHRfjqqpzuZdJy7QNMteE/lhU0DKEmkcjs6AsFFbdBujbqAw/y9OeHpkp2nYLXFbb1D4xRceZ3+shIfvagjycAtx5JFvoD2oM4CqoCOeW2gglRXRWmF2pLzRjmPal11APB8saRQmvP8SPSMwtzB69wrvl2hJQZ4D4s/JXbAIIOL3YguIW+gAYHRv8reMnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(5660300002)(54906003)(33716001)(83380400001)(6486002)(66476007)(8936002)(2906002)(85182001)(316002)(6916009)(8676002)(66556008)(4326008)(66946007)(9686003)(6666004)(186003)(26005)(6506007)(53546011)(6512007)(38100700002)(86362001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUUxMm5sd0VYMzNBT01sNmo3c2FxV1IvZ1hqelZRemh4ekwzNTEyWGtYNTJr?= =?utf-8?B?clBjbml1WjFxRkJCYnJqYy84WjRYdVhTZ3BoOWhFdWx1Z3dVdGMvS3JYOTJC?= =?utf-8?B?NlpuaHFPRGw4bW5GcjM1TnVsQ2JUek1NNVI5VjFYWUVQS0pVZFMxc3ZuOUl2?= =?utf-8?B?bEhPTm5xNzJrdXR3VUhwdlkyYlh6K1lNZUxDeGYwaXJLRGw5Zjd3VXRRMFU1?= =?utf-8?B?NjlqQ253QkpvZWs2M1J3amhPSS8wM0ZFVEZDVE8zdGdzTUprc2o1Tmd6MjhS?= =?utf-8?B?TmdjYmVKMFpUMWdPYllEZnFaUmJZb2ZpMEVlOEhSU1J2d0dHUDhQb0xXcE83?= =?utf-8?B?TStndHFVeDJWUDFyNEJLMlZ4Uk9vM0MwOFlhMVliNGRoZVR5MWVBOXlUVTMz?= =?utf-8?B?dU0xQ0NKKy9iU2F0SDJJS2l0QkNQYllKN05FdFlPU0lpaTN4MnVQYU9aMmNM?= =?utf-8?B?TmpMa1JMdzFrci9iZ0xkdk9ZdkZsSC9heUc0QlBJVmU1dnh0ejlDamtNNFBK?= =?utf-8?B?cXdUb25oakxmdS9hMGg3Tm5RTWc1cGM0V2hNQVp1Y3RiSXFwQlk5c0tjL1BY?= =?utf-8?B?NE1XSG1CMGlmSjg5NlZZNUFPbjBjM2ZLYWFPZjZOcTZNczVDckMvNSs1ZDNH?= =?utf-8?B?QkdvRkNVVmNSRlBvTUdFTHlWSlYyMHdxbXNCM080RGMvVkFrcVBzbVVvWFNh?= =?utf-8?B?VXZTOGZBR3JEdmtZNlN1S3lCRVpFemZCb2ViZGlvODZXTEtQZ3NtSkc4UmpY?= =?utf-8?B?dTBiOVlZSXdHYjh2b3d6emhEbllxbll2eHR1a3JKdkFNejdSZUVrSE81QVNv?= =?utf-8?B?c1lMR3JkMkxoQ1FhKzJOQ0Q0ZmRMQ1RhYUVKdUhFbU1uN2V1QTBIbmdFZHlh?= =?utf-8?B?azM3cWVyRWNDU0l1TzVwTTU0RGVxNEMvclhpMFYwbWFHZC9CdXVVb2x3N1pu?= =?utf-8?B?UUcweG9TNlZmOVI1WmVNTllBeHVVUGNaRTlHRFR0b09pcGkxY0l6dUpOem96?= =?utf-8?B?U0RBNjN2Skg3b1pGbCtDNmQ2dVI4NEh0dit1a3RPTkQ3RW5lV1ZsSmQrQlA1?= =?utf-8?B?RUNTckxyVk9wNitUOERiOUR4ZFVPSHVFdG5PYzBCdEhuY0djeFJyYlNQbWJH?= =?utf-8?B?RFljV2FFeisybGMwMjhkYVgxeGFLWEhMT1FTKzJUVFkvY3c0SmoyRndHUi95?= =?utf-8?B?Vm5PNURLS3M2NE5qR3ZVZjNjdHJJZ1lydjBpbjNOeUZHNjVTN01mYXFQRUZ3?= =?utf-8?B?WkdrYlE5clhXZjB0cXVyc0IwcmlOK2lwaGM3QTlBK2plWGFzTDZKVm1MbmNP?= =?utf-8?B?czJCc0k2WG1oa3NVUE1DdzQwdTNSejRHanZhQXp4dFVtd3RUU0hjZ3dQL1hN?= =?utf-8?B?UzNZL0dvZHBZQ1BpZnVGR2hQT3gwMzR1dXdKTm0ya1Qwcmt0ZFRROTFwb2Yz?= =?utf-8?B?U0w3Q2NsVDc4M1BNb2tqOVl5emlheUk0TkgvT0FyRjdlTXFxWUlBV2FkRDhV?= =?utf-8?B?K2V2TVRWaHpDR2orZXlqamtFV0tPdFJrUFJyL1B0QkVMaXgraHdYa0xycFA2?= =?utf-8?B?aStqNFloMU04Q3p4dGtwUU1GblYxMTBkeVovcThOYng4TXhjUk04U3NHNVNq?= =?utf-8?B?MWYzRHNMbGJ0U1BRN3RHOG5QdWlRM2NqS2ZqY2hZSVV4Rkw0WWpJcmtqV1JF?= =?utf-8?B?a2NHY2pMaUdIc3B2bnM4aTJ1b2orRDQzQTNYWUp5Q3dvaGVSRDJVRGdmYzBE?= =?utf-8?B?Y09jWWQ0T0N5SnNJT2lQZHk2dWpGSjZiREFhVi9LclltREcyUm9XclNJYTg2?= =?utf-8?B?NG1EN0ZjTXBBYld5b2xNUzNyRnQ4L1BpeCswREwzaUN1cHBRVUVCcDZmMnF1?= =?utf-8?B?UGNPWnlaSGtDcDMwL3pFMENuL204L0pXWUo4dHVCcGgwZnl6TkxTamRxL3ln?= =?utf-8?B?S09STnVZRStNYXhyMlZEZGhDYzhiZEJ6czNqeW5YQ3hvQUtkTy9hcXRXK2dn?= =?utf-8?B?UFNla3VFdkNNYnBvN0xIUEdvMzhGNlVyamsxQTVoYnhhc0FsUWloWUxpN05X?= =?utf-8?B?eHJCNzF2S3pMYkQ1eFRqWTgycVZ5K01SWGVPbEhUM3RyWjdITHpoUFYycFB6?= =?utf-8?B?Z0dEeVg1T0g3TURCR0dYVlBGVyszdUhPbEVKS1duUWw5VklrUDl3Q0FxZjNZ?= =?utf-8?B?L0tnTjhLS24rVVpBdUx5dGxNMXA4Z1hKTUlmOWFIaXNuckg4aDNjcFBxVHBM?= =?utf-8?B?T3BaZWhBMzZGcjFpR05uWGd3eHdCTnpsMEEzeEJheERGMXZtQXhyVHlnNVBV?= =?utf-8?B?SitiQUsvMEw0NWI2OVcrZTUxU01KLzArdkdFVGduNGU4T200dVlkZTl5cGI2?= =?utf-8?Q?hY/yjbmf36AaXr/M=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bd5a18e-c9de-49bb-36f3-08da2dd47106 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:46:08.0145 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WCBZKOAe0BCMxHf/gQQnCJ8XTWzYmHi9AZzJiQFI9BVz5xm2vrh8SCkgFi1brS5IR6cFj7ZNTpF2TZqN4grFRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4514 On Wed, May 04, 2022 at 03:19:16PM +0200, Jan Beulich wrote: > On 04.05.2022 15:00, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 02:12:58PM +0200, Jan Beulich wrote: > >> On 04.05.2022 14:01, Roger Pau Monné wrote: > >>> On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: > >>>> On 04.05.2022 12:30, Roger Pau Monné wrote: > >>>>> Right, ->iomem_caps is indeed too wide for our purpose. What > >>>>> about using something like: > >>>>> > >>>>> else if ( is_pv_domain(d) ) > >>>>> { > >>>>> if ( !iomem_access_permitted(d, pfn, pfn) ) > >>>>> return 0; > >>>> > >>>> We can't return 0 here (as RAM pages also make it here when > >>>> !iommu_hwdom_strict), so I can at best take this as a vague outline > >>>> of what you really mean. And I don't want to rely on RAM pages being > >>>> (imo wrongly) represented by set bits in Dom0's iomem_caps. > >>> > >>> Well, yes, my suggestion was taking into account that ->iomem_caps for > >>> dom0 has mostly holes for things that shouldn't be mapped, but > >>> otherwise contains everything else as allowed (including RAM). > >>> > >>> We could instead do: > >>> > >>> else if ( is_pv_domain(d) && type != RAM_TYPE_CONVENTIONAL ) > >>> { > >>> ... > >>> > >>> So that we don't rely on RAM being 'allowed' in ->iomem_caps? > >> > >> This would feel to me like excess special casing. > > > > What about placing this in the 'default:' label on the type switch a > > bit above? > > I'd really like to stick to the present layout of where the special > casing is done, with PV and PVH logic at least next to each other. I > continue to think the construct I suggested (still visible below) > would do. > > >>>>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >>>>> return IOMMUF_readable; > >>>>> } > >>>>> > >>>>> That would get us a bit closer to allowed CPU side mappings, and we > >>>>> don't need to special case IO-APIC or HPET addresses as those are > >>>>> already added to ->iomem_caps or mmio_ro_ranges respectively by > >>>>> dom0_setup_permissions(). > >>>> > >>>> This won't fit in a region of code framed by a (split) comment > >>>> saying "Check that it doesn't overlap with ...". Hence if anything > >>>> I could put something like this further down. Yet even then the > >>>> question remains what to do with ranges which pass > >>>> iomem_access_permitted() but > >>>> - aren't really MMIO, > >>>> - are inside MMCFG, > >>>> - are otherwise special. > >>>> > >>>> Or did you perhaps mean to suggest something like > >>>> > >>>> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && > >>>> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >>>> return IOMMUF_readable; > >>> > >>> I don't think this would be fully correct, as we would still allow > >>> mappings of IO-APIC pages explicitly banned in ->iomem_caps by not > >>> handling those? > >> > >> CPU side mappings don't deal with the IO-APICs specifically. They only > >> care about iomem_caps and mmio_ro_ranges. Hence explicitly banned > >> IO-APIC pages cannot be mapped there either. (Of course we only do > >> such banning if IO-APIC pages weren't possible to represent in > >> mmio_ro_ranges, which should effectively be never.) > > > > I think I haven't expressed myself correctly. > > > > This construct won't return 0 for pfns not in iomem_caps, and hence > > could allow mapping of addresses not in iomem_caps? > > I'm afraid I don't understand: There's an iomem_access_permitted() > in the conditional. How would this allow mapping pages outside of > iomem_caps? The default case higher up has already forced perms to > zero for any non-RAM page (unless iommu_hwdom_inclusive). It was my understanding that when using iommu_hwdom_inclusive (or iommu_hwdom_reserved if the IO-APIC page is a reserved region) we still want to deny access to the IO-APIC page if it's not in iomem_caps, and the proposed conditional won't do that. So I guess the discussion is really whether iommu_hwdom_{inclusive,reserved} take precedence over ->iomem_caps? It seems a bit inconsistent IMO to enforce mmio_ro_ranges but not ->iomem_caps when using iommu_hwdom_{inclusive,reserved}. > >>>> ? Then there would only remain the question of whether mapping r/o > >>>> MMCFG pages is okay (I don't think it is), but that could then be > >>>> special-cased similar to what's done further down for vPCI (by not > >>>> returning in the "else if", but merely updating "perms"). > >>> > >>> Well part of the point of this is to make CPU and Device mappings > >>> more similar. I don't think devices have any business in poking at > >>> the MMCFG range, so it's fine to explicitly ban that range. But I > >>> would have also said the same for IO-APIC pages, so I'm unsure why are > >>> IO-APIC pages fine to be mapped RO, but not the MMCFG range. > >> > >> I wouldn't have wanted to allow r/o mappings of the IO-APICs, but > >> Linux plus the ACPI tables of certain vendors require us to permit > >> this. If we didn't, Dom0 would crash there during boot. > > > > Right, but those are required for the CPU only. I think it's a fine > > goal to try to have similar mappings for CPU and Devices, and then > > that would also cover MMCFG in the PV case. Or else it fine to assume > > CPU vs Device mappings will be slightly different, and then don't add > > any mappings for IO-APIC, HPET or MMCFG to the Device page tables > > (likely there's more that could be added here). > > It being different is what Andrew looks to strongly dislike. And I agree > with this up to a certain point, i.e. I'm having a hard time seeing why > we should put in MMCFG mappings just for this reason. But if consensus > was that consistency across all types of MMIO is the goal, then I could > live with also making MMCFG mappings ... For HVM/PVH I think we want o be consistent as long as it's doable (we can't provide devices access to the emulated MMCFG there for example). For PV I guess it's also a worthy goal if it makes the code easier. PV (and PV dom0 specially) is already a very custom platform with weird properties (like the mapping of the IO-APIC and HPET regions RO or no mappings at all). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 13:55:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320770.541674 (Exim 4.92) (envelope-from ) id 1nmFTJ-0001mm-6i; Wed, 04 May 2022 13:55:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320770.541674; Wed, 04 May 2022 13:55:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFTJ-0001mf-3t; Wed, 04 May 2022 13:55:17 +0000 Received: by outflank-mailman (input) for mailman id 320770; Wed, 04 May 2022 13:55:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFTI-0001mZ-6W for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:55:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2cb2991-cbb1-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 15:55:15 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-a3ICA7YwOkCtEghQRwfAJw-1; Wed, 04 May 2022 15:55:12 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PAXPR04MB8624.eurprd04.prod.outlook.com (2603:10a6:102:21b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 4 May 2022 13:55:11 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 13:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2cb2991-cbb1-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651672514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3/DdxjlIAG8lNDxhGLr6KR/UDC21Cct/DVLYgehZGFk=; b=csJrXdsK8LHFlbRafvkfPmeGwjg+tpGPfr/ysWKFXt09lV66q/xtqyXQOWssYkrWa8UAye gqdD0ITcw3fOj3gYuQG9iNnCqpE6mZBfaI0sqxkOdszmhbCeNFdx9WcUFF8zunFz1sMbPK Wcw+dKunhmon84oDCLjHItoK/RrzAfc= X-MC-Unique: a3ICA7YwOkCtEghQRwfAJw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhxpunzOERdyZktJGWpF//1HIBaa6KrWo31E6lTdgRAtQ63G7FTHV3ylcYNHtOhDVoDCwy0FTG2k8pjmMGz8XqttHIKmHzUBWFkDWhdaR/GAxQi0jSyLCoOlE5/MZJrMClj+eXyvlssecWh9O3Pcb74/0wV3zdam4z6WbLT1fCJF5l160XVLgZ5euVk+wpqtLplAspoObbPzaJVBSX0gU9s/xAURL5Rn6gALeMiAFr/vqUCjveKZkGbxT4nnek2+wZCaKwn+GoJVLdFVIuxl8AUwJ8m/mps5cfr6LkByX3vTMB8N/5rN+F9EE5G8cA8elBhmIzKEhhWogsUhrrNExQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aW8AT++bJb62FkOPESWChfbU83/meKwieafmErQ6Vag=; b=iPfw0F5U0I1FigbQ3wLRvxj9S4uXptSNdCrD9zRCePi1uqGtxt4FD0EJzhKc8rIWtuKzNDsf+0Yd09ux5sE7VlO+qYI9TlvHQDzJa6HuMPe5Ea2C3I2k9bsLu/dzdeXjR1mMAIE6y/V3pO5ME7oZkk2qgOmfz9sMhuw7FRw6yqeg4Nzy5MOLrjFH3DCVUpkyonPGUgDbDW4X8QgO3EZrHrEHPZOHUYH7GsiZWOblv5MzgYeIZvq6L5YnTM8EHrhtW0x6g4ZxqZYq598vRec2AeIr4+0g0iXZQn+Ja8UJm5+Yy/B8/mO8mIoeJ99BAjqhv59PSWYXDqhV9YqSXArcpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2018a835-e924-7d70-1160-227acd75947c@suse.com> Date: Wed, 4 May 2022 15:55:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5cb4dc1b-f6b0-89cc-e21c-a27a5daf0290@suse.com> <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> <66587a43-02b8-20c6-2663-4a6fc3e010e2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P194CA0063.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::40) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 657c2f71-f445-4183-74cd-08da2dd5b4de X-MS-TrafficTypeDiagnostic: PAXPR04MB8624:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dcM6DKYb0frNhbzpWpvXX/1xaNH8zOY8IvB8DM9tMfqVqx0JowtqJ0iVd0EfbIR28DerpDRTnhTNFjhljyj+nStyaxUmBT8xmf6PxsFaSRhbJ774puc5ks8feDFTkmXk0Zws9SHhlSu3Jzntj3S3/iqc2XPjGV/pgeom6wv06tcLj1NUSnl5fFe8FruRKI45u4R7puQXjXwvb9+/bcSWO9xmL8KCVKULrXBMkakKTuCzj+xbt9yMkNvSoq9xEToldodZI4g5i6NkNgw4fdvID+EQULU9ebpQPWHvg0rnhMTdItZm9nsB5/gGaYeWSLHm1sMsjgcXaT87ZIqIqQ0uIPDo3PCMUH+rJ/J38/ZcbKJAMyh/dVJYPM71zvnjS+xUkl4RTo51NHj6PFzYiQNsHbvKjvHpaWmumx1AQr6VsquazvxOrz5IGFbhGrTiiMinc8nAWGkvyTqol8Kw2P+6ppjzmio3CxKnHRzuVkD7Tf2572n9B/5pjEX8GlTNaBCQZh+nukS1MPIlGbdLc287cIQPIn3lp1h06SLweJNCi0llpWmLkABjYXHdw4pQjazQ9eFOKGTxv2t2dbX9acl9IBWNfnjfGokLG3jvhRW3VspVALxBTa4j797bIiLYj1sxhT+E14OO63Q3C9KaGXLT2kVPks3rEqF+33PB+uelgbTkDikYQPHeuPVDARxCFODrfr4iMGc0vPoQ1e/wa5Nqr5n8a06CBxPh6tcsl3P7OmmFTcuih0hIVySnJcHl9wYu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(6506007)(54906003)(53546011)(508600001)(6486002)(6916009)(2906002)(31696002)(38100700002)(86362001)(36756003)(316002)(66946007)(66556008)(31686004)(186003)(4326008)(66476007)(8676002)(2616005)(8936002)(5660300002)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aSTnrFFkbeLKM4MFMuUauFIfhpzPLx4P1OVqpiCZXTwnmwX/PdEoyQs+3q6S?= =?us-ascii?Q?JDOX43x/QTRpHcWvsBeGrvxKwqG2Gixyn/72+sNOBWpaYMu1f89LueVgDQWo?= =?us-ascii?Q?7YpbJ8KCZR/VdvC+CfNipl0UZtWwi9qRUMUDraE2d96SHZqW8QvLAvZ+B5aN?= =?us-ascii?Q?CF4Uy+nqng+rDH5jXbDkvwu4oqL7MZcjZy9B8BZbezhOWaqE1+brZYfm5Oxh?= =?us-ascii?Q?evSpQm7GkE+DpfLFnTo2YeGPTqk6o0NuPqAkpSZhmOhED9IJj9ZOCY63l2ZM?= =?us-ascii?Q?c8n+C0u/Y+qKoria2Epb/NOvlfEnxhd+Kvmwnh6oJNcCiKrwdlvZO7aTB7Ng?= =?us-ascii?Q?8iU6B89Aq5Hi9+EIOPF8rbdESz5MPJ1LyD1VEKnMA3/ADy7zjOP9lct5bGyY?= =?us-ascii?Q?IjymjJ+fC31bD1BhSM/COU9rCYxr11bzLT7SQZIIVo0OqC+pbTRLnU6Dsph6?= =?us-ascii?Q?c0l75vsuYrIzDX94r5Dw4HPWQLepiTAry58oBL9Hu6LDUXHki+eYnhaA72eP?= =?us-ascii?Q?8P3G6qcw+xSsYhNcgM7YzDjy2iTI6FO6QZUS83Li37rWvPGeP5okeBsclQZN?= =?us-ascii?Q?C2aY5nPv2mddtfHKWZQzsqENsvOrXPd4gyvStJeWMBQYChzBbtJK0PCO163n?= =?us-ascii?Q?RuG61RU8gDSAgTRkQgku0N5CDUwZ3WDDZLo3LgBbwJIJU8G+qi6sIihkgVcI?= =?us-ascii?Q?igRvKd1shHz8EfqaNw4qvYR9kdB9WaG7iuJQ6xcN6xWdinem7zT+eeCIiH+X?= =?us-ascii?Q?q4V2h9xoU/AHDGv9E8l0VEGX4GMF4cfbggpbYG2Q2PLql4M2O+h44U4gEJQq?= =?us-ascii?Q?D+AOvNZFOTlUSoSeuGmTZcZvhYSdZZ6doIesYPUbSqa7hOK55YniN66bkXk3?= =?us-ascii?Q?Vv/ooJ6U4T50pQz+X+XypWTMosoGQ2CkxZlqw5voOxr4qW5ufTII2mAYj4+m?= =?us-ascii?Q?NaojiuL6SwXb6YRM7L3U4rxjxYN8v1PZmJAYdaJeVjxtFEE6Mv4c4jmajyTc?= =?us-ascii?Q?Otscudzg3ITpl2zkmSKt03cRvPS/0luLe1w/J816JEqb3VAYJwEbj7R9far8?= =?us-ascii?Q?E+pLannc361lb8/9Evds/YpLQQ+ktDUzXlWsQCxoo36RhIN4AnUP83gTNk7p?= =?us-ascii?Q?RbFpvHPKa2ygEU2YQEe1aXxbZIFBKejSiWmQaVlnvxSuI39OuQlGsbiBNlcQ?= =?us-ascii?Q?Dc8yoNZ0bQ1eIekfN01Jjg8tYnpSTpO9YVP0GKSPO7U7HLjGihDDfdLKRaK0?= =?us-ascii?Q?w0qkJ7wtPRQw+md/IGduxcOikgIeGSMFgyeGsRpcdkViL4vcTlMHEkRUZlAh?= =?us-ascii?Q?NMlO/4MPdPEJpzUjvh1TVkqwL7xvjtLiiuz06XGClMbv38RLmTfVkuFAKnK9?= =?us-ascii?Q?rkbghtumYGzMDjEUx+wDes7AblrWtAdB09PFnjHoZKGNUzeW8SC1DLWw/TNc?= =?us-ascii?Q?D4ad783T0VfRX1EoQZouGx/Qd4jM9iVm+ya942e+JNqtgKs4VE6tLfZfDvqO?= =?us-ascii?Q?0Ea1hiKx3va3CMSTH+6lfGMeYw1zsYYlWJZPf46nePHcngqLwOI3Yfmzm2B5?= =?us-ascii?Q?WhJaxiMCF4gK17FpazICcZrZ941e310+3KXmDB6/+lcNEyJe2xqeCg9Hqacc?= =?us-ascii?Q?/7uUvDDplIr6VWd/ba1KGZP+6JKtrCjW/5gEwWVK5/fIBNTdxd0OsdzR8EeV?= =?us-ascii?Q?ZyDl0gMCu0d+H2yEnJxT+9INpwpXYVzVHLTmIA8giMZvu48XYZ6GoE+YNVzl?= =?us-ascii?Q?Z7fBXLiTAw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 657c2f71-f445-4183-74cd-08da2dd5b4de X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:55:11.3350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qKX9ABaBh07WTJJruKPoNYOcbDDYDj/+C9mb8yAC9LWNeSyRnLM/y4b8FDrvESuHqHK9tK+w8RLitYRfYWy2rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8624 On 04.05.2022 15:46, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 03:19:16PM +0200, Jan Beulich wrote: >> On 04.05.2022 15:00, Roger Pau Monn=C3=A9 wrote: >>> On Wed, May 04, 2022 at 02:12:58PM +0200, Jan Beulich wrote: >>>> On 04.05.2022 14:01, Roger Pau Monn=C3=A9 wrote: >>>>> On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: >>>>>> On 04.05.2022 12:30, Roger Pau Monn=C3=A9 wrote: >>>>>>> Right, ->iomem_caps is indeed too wide for our purpose. What >>>>>>> about using something like: >>>>>>> >>>>>>> else if ( is_pv_domain(d) ) >>>>>>> { >>>>>>> if ( !iomem_access_permitted(d, pfn, pfn) ) >>>>>>> return 0; >>>>>> >>>>>> We can't return 0 here (as RAM pages also make it here when >>>>>> !iommu_hwdom_strict), so I can at best take this as a vague outline >>>>>> of what you really mean. And I don't want to rely on RAM pages being >>>>>> (imo wrongly) represented by set bits in Dom0's iomem_caps. >>>>> >>>>> Well, yes, my suggestion was taking into account that ->iomem_caps fo= r >>>>> dom0 has mostly holes for things that shouldn't be mapped, but >>>>> otherwise contains everything else as allowed (including RAM). >>>>> >>>>> We could instead do: >>>>> >>>>> else if ( is_pv_domain(d) && type !=3D RAM_TYPE_CONVENTIONAL ) >>>>> { >>>>> ... >>>>> >>>>> So that we don't rely on RAM being 'allowed' in ->iomem_caps? >>>> >>>> This would feel to me like excess special casing. >>> >>> What about placing this in the 'default:' label on the type switch a >>> bit above? >> >> I'd really like to stick to the present layout of where the special >> casing is done, with PV and PVH logic at least next to each other. I >> continue to think the construct I suggested (still visible below) >> would do. >> >>>>>>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >>>>>>> return IOMMUF_readable; >>>>>>> } >>>>>>> >>>>>>> That would get us a bit closer to allowed CPU side mappings, and we >>>>>>> don't need to special case IO-APIC or HPET addresses as those are >>>>>>> already added to ->iomem_caps or mmio_ro_ranges respectively by >>>>>>> dom0_setup_permissions(). >>>>>> >>>>>> This won't fit in a region of code framed by a (split) comment >>>>>> saying "Check that it doesn't overlap with ...". Hence if anything >>>>>> I could put something like this further down. Yet even then the >>>>>> question remains what to do with ranges which pass >>>>>> iomem_access_permitted() but >>>>>> - aren't really MMIO, >>>>>> - are inside MMCFG, >>>>>> - are otherwise special. >>>>>> >>>>>> Or did you perhaps mean to suggest something like >>>>>> >>>>>> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && >>>>>> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >>>>>> return IOMMUF_readable; >>>>> >>>>> I don't think this would be fully correct, as we would still allow >>>>> mappings of IO-APIC pages explicitly banned in ->iomem_caps by not >>>>> handling those? >>>> >>>> CPU side mappings don't deal with the IO-APICs specifically. They only >>>> care about iomem_caps and mmio_ro_ranges. Hence explicitly banned >>>> IO-APIC pages cannot be mapped there either. (Of course we only do >>>> such banning if IO-APIC pages weren't possible to represent in >>>> mmio_ro_ranges, which should effectively be never.) >>> >>> I think I haven't expressed myself correctly. >>> >>> This construct won't return 0 for pfns not in iomem_caps, and hence >>> could allow mapping of addresses not in iomem_caps? >> >> I'm afraid I don't understand: There's an iomem_access_permitted() >> in the conditional. How would this allow mapping pages outside of >> iomem_caps? The default case higher up has already forced perms to >> zero for any non-RAM page (unless iommu_hwdom_inclusive). >=20 > It was my understanding that when using iommu_hwdom_inclusive (or > iommu_hwdom_reserved if the IO-APIC page is a reserved region) we > still want to deny access to the IO-APIC page if it's not in > iomem_caps, and the proposed conditional won't do that. >=20 > So I guess the discussion is really whether > iommu_hwdom_{inclusive,reserved} take precedence over ->iomem_caps? I think the intended interaction is not spelled out anywhere. I also think that it is to be expected for such interaction to be quirky; after all the options themselves are quirks. > It seems a bit inconsistent IMO to enforce mmio_ro_ranges but not > ->iomem_caps when using iommu_hwdom_{inclusive,reserved}. In a way, yes. But as said before - it's highly theoretical for IO-APIC pages to not be in ->iomem_caps (and this case also won't go silently). Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 13:56:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 13:56:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320775.541686 (Exim 4.92) (envelope-from ) id 1nmFU2-0002Ku-IS; Wed, 04 May 2022 13:56:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320775.541686; Wed, 04 May 2022 13:56:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFU2-0002Kn-EK; Wed, 04 May 2022 13:56:02 +0000 Received: by outflank-mailman (input) for mailman id 320775; Wed, 04 May 2022 13:56:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFU0-0002FL-PT for xen-devel@lists.xenproject.org; Wed, 04 May 2022 13:56:01 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebd0b924-cbb1-11ec-a406-831a346695d4; Wed, 04 May 2022 15:55:58 +0200 (CEST) Received: from mail-bn8nam11lp2176.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 09:55:53 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB3802.namprd03.prod.outlook.com (2603:10b6:5:50::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 13:55:49 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 13:55:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebd0b924-cbb1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651672558; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=d4jzifbCRGSYi4KfZ1jOo3Xe24gNsjZCXv1fPF5OC8k=; b=J7virZJpjez2Rqfu1XYZiS4DIm6sh66D5kByxG/8dkoVXPYXQZNin5rn gWhuqGPaFfHinBRSC3UtDZ2bXbItlwMG1tpjMuxg7boaEfhM9UD2YWJQe GRGY+KgyViEJAio6jZzA1Op3IHcsspNU9L/wPyT3m2tZblxY0e4DSOXci 0=; X-IronPort-RemoteIP: 104.47.58.176 X-IronPort-MID: 69950537 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mur9R64s/zBnHLhLlEO+ewxRtELGchMFZxGqfqrLsTDasY5as4F+v mFNWmCHPPeKNjPyeNsgOY+xpENSvcfdyN5qHQBpqi0wHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhX1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSyTiktB6z1x90tQgFIDhpSZYdD0a7udC3XXcy7lyUqclPK6tA3VQQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YHgl/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2MJ+Q/N+PFoi4TV5F11k57EHfXFQOeLe/dft0+Sh iHs+k2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVRxSlpFaUsxhaXMBfe8Ul7Cmdx6yS5ByWblXoVRZEYd0i8cUwFToj0 wbQm8uzXGMx9rqIVXia67GY6yuoPjQYJnMDYilCShYZ597ko8c4iRenostfLZNZR+bdQVnYq w1mZgBk71nPpabnD5mGwG0= IronPort-HdrOrdr: A9a23:7XvjpKqJ85fFrPNg0SA1UuwaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="69950537" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfQQbnww9kv/59hfsb+3CuC37PXX//RiGCrKisfPhiR7mGWmAGjawLAqIXS/spVbgUzXWnzrtSMn7zc6o8I1tMTNHh6ohRSVtpFjgPzdO+cRlHCjy9dNX7uTF670no7Bxexu1TNNHN1AcMfk1Or7FXPIn73GMXJ5zSjanCmIUximILoif1CTKnrjbFtNVuB32BdxTkWVCWcuczXnavF65m/EOX2Y7hnsGXWeLxtaloKxtzU1UCmLpHsTr0VugyTLg3vxtOQYgBVgEznxBR/meTD4NQSE7wvB8qwMcBO2vjGjVBGjNt1+InmXNW1yU6EPkoo7/elMr5JBu1kx0cnCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nQ1GIAIcILvu1VTg7Kv7YpbGZ4BPwhFXFVKbWwZ7Haw=; b=WAHEcESXe6ASaNpZGvkYY5QrvvQ5vQwk8e0BXlFI7grDRAFebhO25fH9Fr+7PlXzE26koTurWm3FF/of/BsOo12tGT0502ijRVkhap4Tz3KTK8qiZy5XIMpnnLDeiiPR13BH9MaTu2bI8AiBo8eI+T/UHCshPJb+4U0I9s2DK/G2amaNibcrFU1dITvnn6+8sTpQ0mEmLcC61UEtyLIw7JvY8mqAyA/9Qm6OHFl5HIMMs7cRALI7OdPAkliKpiAXdNirz2GV0hszgXJTk7kRFHDMIOMl/JY+9gAfs7IeDGyRm40DVj8goWHDL6M5AKpaZXodzoMRzVBJB8+uDoWYTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQ1GIAIcILvu1VTg7Kv7YpbGZ4BPwhFXFVKbWwZ7Haw=; b=ZHBgtTWzu9XktaLSpohkh2m7chcwa28IfglAuSdfF0yGIeG8nrQsxSDYnYP1U6T8DYrRa/CW5PGIqlZPBGAsY/5VUcziZOXU32RkUL/0YAR18y2GgaBESMefU0wM4FcuP4PFxHnatPJcWMx8zsMSB2K24+97TX49ea2bqZmLgnU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 15:55:45 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Message-ID: References: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> <7675bc21-e951-0d75-844c-94ddf47dd343@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7675bc21-e951-0d75-844c-94ddf47dd343@suse.com> X-ClientProxiedBy: MR2P264CA0022.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5a33afb-7479-4c8b-b41d-08da2dd5cbd1 X-MS-TrafficTypeDiagnostic: DM6PR03MB3802:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RyN7UC+Z2Saux2MlihYQXB2pBQVs8MN9+n9gmkk3NHC83k9FiUPFKJptvpqNhvnYHMPmPOgZee/M/w0q6J3Q9HzP5BmQlvW/R7yLZAGp4NCi8nqUuWpgiVF71Kk/GU8JKuP65EL5tkAKKcO7GLu9+/AjbBCeNMYj/+PwmtkP0GgGjlG2BITcKaNnM17ilmxeOmEcysEZ14bCj12u4A7HeNyVS2Fvkq54vyHCxV1S+aeC7ByPOCHmNRVyOkTy5WxttRNia57q6ji6NBMAwW+mVI6S22UrYD4Yg1/SvIj9EhCx2OvKbTKEFy1DVzDfYz4V6yG+r+LLI/L3BZJQLbc/6CHHdXCYMFtdyoKWYmXd3xzGjr+ItO5xS/o9kjDTIbjSXx0Zn1YlwA1N6k1q2nT09L/vSOXcTdnAZr+CpVZqd2cdMnDBYWN8Z/UQ9h5ikVfLVHafQvRITYjpz9Bswyqxl6xzGTRhGXsHfMApWnhiF7Kh+f+O/iZz6CtfG0AkDrr2pn8Rh5zAUNNaHuV4QkICwQYP/ajE+rfLXtfz34ndpzWWZWHMx+JqJiwQX/AudtBtspPKezeaNrTv7YAY1d8m7LmQT3aX5xBzH6xvsEoa01dKnRscnfFd5aB2Q1R/VClypKMIqzoFE99OULikO6BxZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(26005)(6506007)(6486002)(9686003)(6666004)(6512007)(83380400001)(508600001)(5660300002)(8936002)(85182001)(2906002)(316002)(8676002)(6916009)(66476007)(66946007)(66556008)(33716001)(38100700002)(53546011)(86362001)(4326008)(82960400001)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjVYclhxQU9TNVJqODZrcVBmSmtIeW56YjJFUUphclNYYmNzQXBmUG4yZS82?= =?utf-8?B?TkNkOEhZY0RLcnNubUZDdlFJUkhRVkJPZ2ZxM0ZacS84cXh4dUQwbDNFbWY5?= =?utf-8?B?dEZ1bWI3QUxHSTVhZEFVTGxxY0ZicUFsQkUzcnFSeElZcWhUc00wS1pyTlFo?= =?utf-8?B?MmVuSm0rNDRXVlNId0xEWWVZV2pxY2IwdHFLdi9zZWQrSkh2dUJubDZockJU?= =?utf-8?B?dDlCUVNuSzNqNTB3REw3TXVBc0lWMkJ1MlVERzViM1dNUlJvYyszcGtza1Fy?= =?utf-8?B?VWdCb05jVXY5TFd4aUF3NFhmTndRWFZZVnltZk9zS2JZQk84eUtxK2kwR1Vq?= =?utf-8?B?SnNBUlkrcFJhZmRnWjlLZlB4RDFJTzJud2FGZytoaENjSmdkZ1ZVRWZOeGRB?= =?utf-8?B?WEIvclFxSlZmMnB4bFJ2d1JtbFI2Nkc1cU1BWVAraUZuc3lsZ3ROdkRvOGs3?= =?utf-8?B?OGZ6bjNYeHgzL2dpRytSQTdmLzFEdVduUTR6a1l0ZTV0UzRGdHkwU3dqeXda?= =?utf-8?B?QkJQMEk3S3p3allFdGtveWVENHhWVERsWVRILzhpWVNKT3JHeVR1Q0x5dUIy?= =?utf-8?B?ZFpqNW54WHRxaERzR1JQbkJvN3hCMXdHZlowbHR2bll0cFdjRkJmMkg0MHdl?= =?utf-8?B?dytBZlVoTUxqQ2RKTStvWVBpTjdzeFQxM01ianRVanFVd2F4UDR1SUdURndR?= =?utf-8?B?SlhWYlpKWU9aTGZmOG0vRXZyNzJuQnZmWWNnRVVmZG5hSUtqY2g4TnJoait5?= =?utf-8?B?UldXQmZWL2IxeUZSaHpEaFZGai9vaTBacC9wcVFwdUluY0xxbWZ3RVdGdzcw?= =?utf-8?B?UU5yb3Y3WUkxSEhNYWNPY0NWNGNicTMvQjhRMnlhMkg2aWhSYlFQSWVHcnhB?= =?utf-8?B?b21NcHJyOUxGOVpvR3NTWm83RVhzYm0xek91dnFGUGJ1N0Q3QU1VdnFYRGhu?= =?utf-8?B?WmxWOTRFZ0R6ZHg2QnlkWmZ4SWh4bk5yNFUxMVo2SlhMSUsvR0grK3Y0QnVY?= =?utf-8?B?KzQzbWloSDd3T0ZyeFA3TXdFTjVHZGgycFdCdDNFQmU3eWsxdVBxZ0k3eDNX?= =?utf-8?B?b3FJMFk5T3FuNlFiODhTUnpSUm1YR0k5NUxGbm1ucXRsT2xqdy9hRnpKN09a?= =?utf-8?B?djVlN0RwYWVnd0lXRHBGVUV1aEpQaG9Mc2xMM2ozVkxSaGRvK0ZxNXBWajk4?= =?utf-8?B?blZYNEN5VGJLVFZiVDA3N3pyaGM2MDg3eWNsQ1g2VnBUOWpsaGtjcWdGRXIr?= =?utf-8?B?cXI4NmFCSWpoeUdOUU9RemkxOWlUYXpxRVFvWFVoVzNIV2RjT295Z2M0U1hY?= =?utf-8?B?Y0VkVVpsSmhYd0pLSU5rOHdiZHZPdXBDNVBnbHJBWEVnNmEvMWZaUjA2dy9k?= =?utf-8?B?RDVISkRIZG1lbVJuWFhXNGZDeTlLQjQ1K2o0OExrajZLcmthbFlUVzZiVGIr?= =?utf-8?B?OGRFRHl0eW01eVVNbWxwdkdwaWxRazVKQ0lCVHNGK3JlczQvRUJvODM3cEx1?= =?utf-8?B?VzNDbGJjS0t1N2R1Y3FDQmN3N0NKdmM1TTN5d1N5dzNSQmxheVh4TWE5ZWFZ?= =?utf-8?B?VzdzcERna3lQWVBpUFpZWXdtandYMWxRVnh0U2JTRmQwaUhMVzgyV1ppYzJK?= =?utf-8?B?dHRvemo5T2NNQnQyWTJRYk9RTjFVcGRpSDhTNnp0N0wxUDF0Q1NTeTFTelVw?= =?utf-8?B?T3pVK0MzSDJzb0lJUEFsRm51UmtuQzI3bzVpVTl1NWo0Y2NQSTlHNXVPZG5i?= =?utf-8?B?eUhlR0FvcFcxVmpvTXdEc2wvNVA3aGFRWkIzZVQwWS9yRnJISHlac0hKZjJx?= =?utf-8?B?SUk2OTE5VVovdDdqeUFKVkFNanJpTXloM1lUbWdNeTNSdENtaGFhK01PdzFT?= =?utf-8?B?YUdBOHFhLzRMaHNjMVkwQU9lOUV0U2xMY0ZvZVhDdml2czdhSmdZOVkyQUFX?= =?utf-8?B?YnMwV2R5amFpNjIvOGNYWElOaGlCTTRSaGd1Q3JxRzV0ekVoeXdmRVplZm9P?= =?utf-8?B?MU1ReHVTYzdWT1FjWmk0bjBVeUt3ZWkzVGxwSUdHbUN4Sk1SeXZCTFN0Ritp?= =?utf-8?B?SkRqT1BHdGVvN1MrQjJrSUJ5QWxUKzdtQy9obit0VlJYaWw0SnhrdW85ZWNw?= =?utf-8?B?UkdiOXFrVW8zaDFVOWZqcm10VVBPN29nMG1XbVgreEJPUlZqaDEvWVVKWXY4?= =?utf-8?B?RTJtelV4TGpjQ3N5OGxCUW5XelErUlJlWHN4Umh2NmFDL0RiZ0dlU0tKSUU1?= =?utf-8?B?ZmZTWFVZUlNkcG9nY083NTVmd1hEL3MyQmlyeGt2NW5LcEE3ZXVJaE9waGxn?= =?utf-8?B?VnI4bzRtNTQ1bTQvSVNoMHEvRDQvaUo1aCsyM2lJOXp0THIvNEozaW1xdngv?= =?utf-8?Q?MYl8r8p2JE0SmiSU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5a33afb-7479-4c8b-b41d-08da2dd5cbd1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:55:49.8398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WNBinIK+1xn2m9Ic3hi+hgloKZ/wyKuN3rebcbUBV4LvBQ9VY4WBRP/NTvgyOkJfa3lsvEL9RO71PCueu4KEhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3802 On Wed, May 04, 2022 at 02:27:14PM +0200, Jan Beulich wrote: > On 04.05.2022 13:20, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 11:46:37AM +0200, Jan Beulich wrote: > >> On 03.05.2022 16:49, Roger Pau Monné wrote: > >>> On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: > >>> It would seem to me that doing it that way would also allow the > >>> mappings to get established in blocks for domUs. > >> > >> ... then this would perhaps be possible. > >> > >>>> The installing of zero-ref writable types has in fact shown (observed > >>>> while putting together the change) that despite the intention by the > >>>> XSA-288 changes (affecting DomU-s only) for Dom0 a number of > >>>> sufficiently ordinary pages (at the very least initrd and P2M ones as > >>>> well as pages that are part of the initial allocation but not part of > >>>> the initial mapping) still have been starting out as PGT_none, meaning > >>>> that they would have gained IOMMU mappings only the first time these > >>>> pages would get mapped writably. Consequently an open question is > >>>> whether iommu_memory_setup() should set the pages to PGT_writable_page > >>>> independent of need_iommu_pt_sync(). > >>> > >>> I think I'm confused, doesn't the setting of PGT_writable_page happen > >>> as a result of need_iommu_pt_sync() and having those pages added to > >>> the IOMMU page tables? (so they can be properly tracked and IOMMU > >>> mappings are removed if thte page is also removed) > >> > >> In principle yes - in guest_physmap_add_page(). But this function isn't > >> called for the pages I did enumerate in the remark. XSA-288 really only > >> cared about getting this right for DomU-s. > > > > Would it make sense to change guest_physmap_add_page() to be able to > > pass the page_order parameter down to iommu_map(), and then use it for > > dom0 build instead of introducing iommu_memory_setup()? > > To be quite frank: This is something that I might have been willing to > do months ago, when this series was still fresh. If I was to start > re-doing all of this code now, it would take far more time than it > would have taken back then. Hence I'd like to avoid a full re-work here > unless entirely unacceptable in the way currently done (which largely > fits with how we have been doing Dom0 setup). Sorry, I would have really liked to be more on time with reviews of this, but there's always something that comes up. > Furthermore, guest_physmap_add_page() doesn't itself call iommu_map(). > What you're suggesting would require get_page_and_type() to be able to > work on higher-order pages. I view adjustments like this as well out > of scope for this series. Well, my initial thinking was to do something similar to what you currently have in iommu_memory_setup: a direct call to iommu_map and adjust the page types manually, but I think this will only work for dom0 because pages are fresh at that point. For domUs we must use get_page_and_type so any previous mapping is also removed. > > I think guest_physmap_add_page() will need to be adjusted at some > > point for domUs, and hence it could be unified with dom0 usage > > also? > > As an optimization - perhaps. I view it as more important to have HVM > guests work reasonably well (which includes the performance aspect of > setting them up). OK, I'm fine with focusing on HVM. > >>>> --- a/xen/drivers/passthrough/x86/iommu.c > >>>> +++ b/xen/drivers/passthrough/x86/iommu.c > >>>> @@ -347,8 +347,8 @@ static unsigned int __hwdom_init hwdom_i > >>>> > >>>> void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > >>>> { > >>>> - unsigned long i, top, max_pfn; > >>>> - unsigned int flush_flags = 0; > >>>> + unsigned long i, top, max_pfn, start, count; > >>>> + unsigned int flush_flags = 0, start_perms = 0; > >>>> > >>>> BUG_ON(!is_hardware_domain(d)); > >>>> > >>>> @@ -379,9 +379,9 @@ void __hwdom_init arch_iommu_hwdom_init( > >>>> * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid > >>>> * setting up potentially conflicting mappings here. > >>>> */ > >>>> - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > >>>> + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > >>>> > >>>> - for ( ; i < top; i++ ) > >>>> + for ( i = start, count = 0; i < top; ) > >>>> { > >>>> unsigned long pfn = pdx_to_pfn(i); > >>>> unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); > >>>> @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( > >>>> if ( !perms ) > >>>> rc = 0; > >>>> else if ( paging_mode_translate(d) ) > >>>> + { > >>>> rc = p2m_add_identity_entry(d, pfn, > >>>> perms & IOMMUF_writable ? p2m_access_rw > >>>> : p2m_access_r, > >>>> 0); > >>>> + if ( rc ) > >>>> + printk(XENLOG_WARNING > >>>> + "%pd: identity mapping of %lx failed: %d\n", > >>>> + d, pfn, rc); > >>>> + } > >>>> + else if ( pfn != start + count || perms != start_perms ) > >>>> + { > >>>> + commit: > >>>> + rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms, > >>>> + &flush_flags); > >>>> + if ( rc ) > >>>> + printk(XENLOG_WARNING > >>>> + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n", > >>>> + d, pfn, pfn + count, rc); > >>>> + SWAP(start, pfn); > >>>> + start_perms = perms; > >>>> + count = 1; > >>>> + } > >>>> else > >>>> - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, > >>>> - perms, &flush_flags); > >>>> + { > >>>> + ++count; > >>>> + rc = 0; > >>> > >>> Seeing as we want to process this in blocks now, I wonder whether it > >>> would make sense to take a different approach, and use a rangeset to > >>> track which regions need to be mapped. What gets added would be based > >>> on the host e820 plus the options > >>> iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes > >>> based on the logic in hwdom_iommu_map() and finally we could iterate > >>> over the regions afterwards using rangeset_consume_ranges(). > >>> > >>> Not that you strictly need to do it here, just think the end result > >>> would be clearer. > >> > >> The end result might indeed be, but it would be more of a change right > >> here. Hence I'd prefer to leave that out of the series for now. > > > > OK. I think it might be nice to add a comment in that regard, mostly > > because I tend to forget myself. > > Sure, I've added another post-commit-message remark. Sorry for being confused, but are those reflected in the final commit message, or in the code itself? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 14:15:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 14:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320786.541703 (Exim 4.92) (envelope-from ) id 1nmFmw-00054d-Dy; Wed, 04 May 2022 14:15:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320786.541703; Wed, 04 May 2022 14:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFmw-00054W-Ay; Wed, 04 May 2022 14:15:34 +0000 Received: by outflank-mailman (input) for mailman id 320786; Wed, 04 May 2022 14:15:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFmu-00054L-LI; Wed, 04 May 2022 14:15:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFmu-0006Rm-H5; Wed, 04 May 2022 14:15:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFmu-0003Om-As; Wed, 04 May 2022 14:15:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmFmu-0006tS-AT; Wed, 04 May 2022 14:15:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xDo8AaWqqpVNMOZ9oiLGZbvnPFpdlsjEopmZWm8QSX8=; b=6H3UKAwJx85pl9JJSD7sayBcYP 33xbOpWIWKt/MgEnsHR9OmjzY4aa0s3oOs4pVi8i+Y6ywGYoEQQnkHprtV8mtE4WXMYeETyEllP6C bMzEE5aBJqDb2fByUljvAjXVGtqYCjYzte9ZkBUsCEj5EgznLMI62MgdzRmsmdZAvBp4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170102: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 14:15:32 +0000 flight 170102 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170102/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 801 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 14:26:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 14:26:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320794.541714 (Exim 4.92) (envelope-from ) id 1nmFxp-0006h3-GM; Wed, 04 May 2022 14:26:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320794.541714; Wed, 04 May 2022 14:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFxp-0006gw-DD; Wed, 04 May 2022 14:26:49 +0000 Received: by outflank-mailman (input) for mailman id 320794; Wed, 04 May 2022 14:26:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmFxo-0006gq-6q for xen-devel@lists.xenproject.org; Wed, 04 May 2022 14:26:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a76af8a-cbb6-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 16:26:47 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-j_RvmjBmNsiXlJeFaJmq8w-1; Wed, 04 May 2022 16:26:43 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM5PR04MB3266.eurprd04.prod.outlook.com (2603:10a6:206:6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Wed, 4 May 2022 14:26:42 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 14:26:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a76af8a-cbb6-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651674406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aPre0fSaTqJjCC6rXW3Fw0LU03vIteEXe/4QPwSjBLc=; b=i4m/3yrbIW22uLlnvHiLI3wIBXoWgRImWAYd+0t4+q8r+hqQRFWKRnk5nK83IoIuBHBt/+ f6ddSaOKrVyRfI6kX6krNX7YX6tqr3nUH4nrq3L5gZX2H5bDg+E1dkZRV+UOkQBUZ0iIwa DRUXn5E5Y/bYkW6b3lYaddj4T+P3eM8= X-MC-Unique: j_RvmjBmNsiXlJeFaJmq8w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZbg0pXAUS068iphzx36b5TTpKKwtNV0+DkblLinVGXsKWAtT5YulH4/JXJatpwkZc905MHDz2fzh4ECktN8ZaIoyTG1Eo0XjOi0sfgSO/gw9+wpz5fus4EzSGHewW9DQAHnVtmr738/h8RBPNvIfKf+GC5vGJ916E1Hbr7q+s+R2zZl7kfZk8NBVwFbWBmbqTnqZ24dTZMaVDBjuLI9nC1naA6iN1j+HJL4AGEhXnLggm+Dmw9zxXZK3IXn+bSHtgEF27fLTYgQm4qLMO/++1BmIyCB1xe486IRHkTb6W6VlbSBCd7N3vJ5ff7N1d7HRxYBDYi/nj1xi9sujqspWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MbIRklcKrf6YQ+z2qg+c4tmqOIeHHIcsZmFER4YXlcg=; b=FrMqztCwOiDLdcTQSNvZXKsI9QlpuUkai25KMyVY0Hlp/sgdGnvsjZn4+xRSHupJK6rL44oqErQEYMCjNXMnEN9yGNc8Q900aaSpXmIf6ryARkzMyWrVj/nBTrTB5wa6RUB06IF4ZMIgfppwe06atPFmxyXf/5yFPpwviEIwycg0TsP5QxqBCpFxox7QCJTPHoxAwpdmh8+CDSKBu004gHBVqe5wZpJS9IQpkzCJLTypSeJXlySKfoGLzoXEZtJ4lxvqr8MqCtOHnqm3sOc5WldJ/BZStlXhxObNNHvsaI163lHc4gx7nLPHPfsBY8u5LLJMZWiYxzR2oAloDaJkAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <56a5dfbf-fb6c-93b3-8c6f-2fcc5dfb8dee@suse.com> Date: Wed, 4 May 2022 16:26:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 06/21] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <73aabaf9-4509-53f9-8af4-354fd3d13fb3@suse.com> <7675bc21-e951-0d75-844c-94ddf47dd343@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::20) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c4f6d8f-3081-4866-3228-08da2dda1bdf X-MS-TrafficTypeDiagnostic: AM5PR04MB3266:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xf3qeviIsywR2QRi6kMxkUYzgnfjH3uY7t7wHA3a2l1WT6iImERykiIwGz0DHNhSUmXKHmFYQySs3tGKP/HuIUWgenrTqzjPCNdZYQgNySCA//jAZ2z+G8Eo5/N2fhhgpWjSYL+RXgdiRUgzu/vSixNeDZlWNJ6mtbxAremzQRRbxyIU+hN/2f9YAYyKuUjYhBTIcEKsURNGLxCdrpLpJoKfhBQAXQaJy52W51TGRKEuKtZpovGTotJboPNCOyoUVBDjfbaxOfm15Q6zLLZ+HiEVQH3o9+USaVZzSLanu8pJqVkggsIx0Mt6QyYZ5txxzIsMPN/sEcaRxmDZ4QJwgLmWLpghKMEarRy0WqjScimKxkazPG7M3QKTRJtdpmlrm//nrLmob32a4q2THuBECnA17iytesNLiPlimWta9m5bpp5bi/iEplHfNNoe1HftBqhH08YnzU+zoa4WmT9Frpfggql0Fne6JPx/qBizgb95Lnq07MhBBA4D/oE9wk3uqbYfbnryw6sA5oB+8tapd+LCspUCBk7GwcnJ+m4dKs56B16+rBRk2gJPXE03RLThwXO7cN+fcud2gg53kWLkkQrQCxvMXQTFCBnD70P6jLjfYN57I6x8X2gDgGcC/DonMgHuK/ZNozqeJKs67EKcoQn8bwwpRLA4VY5DMdTqjTq/8HuzhNW7ZMkffcLNqQygto/f5xGUcvGPwrF5QfAIsmQZ3kTf4sJPJETjrVhqAVY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(36756003)(6486002)(38100700002)(2906002)(31686004)(8936002)(6506007)(508600001)(86362001)(6916009)(6512007)(4326008)(2616005)(54906003)(26005)(186003)(5660300002)(31696002)(316002)(66946007)(8676002)(83380400001)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fYXNWn51G08FVzT7ed7Itvs/4kvk8s3QwyIlstJloW5HveOmcDdqIuA6awfQ?= =?us-ascii?Q?zHqrhpD0IODdX+Y9bd1b01oqoe8Nt6m3/K8vT+uvZkcdAGk4nbefoaxs7ils?= =?us-ascii?Q?+qPKGjfSrycLF/1WW3yKYuIJ26NH8W7S4HomFdGwITS3NWFSDTwuGFgZL5nX?= =?us-ascii?Q?gqmvMJ9hopmtVdzdSWyAkEvslY8hA3lohOd92ry/Ey/EVjSQ8n6HBg2j8SDf?= =?us-ascii?Q?443U7Mo/c7H09mzkkISq0f8UBkubixdajyTEeLfBF2sas2XlkKrTkeXWhTbc?= =?us-ascii?Q?dSbL1Clq0rwzPskf6GWq+vbUhaCnRNi5h2wZuptXDPHHaZrxCwsZ+vCYnxHQ?= =?us-ascii?Q?Lod8TyKaXM3yE8pdnHeryQyvibBiTy01Cmag/X0l9AGe3rXf8WK070oGd0Kw?= =?us-ascii?Q?UusxcamlUDhzWEZeoQuh2tX+VZikm9grPYxPqvvUruqy4mee8EGw3wVWyIkv?= =?us-ascii?Q?k57IDHfhVfFZEzg5eM9oMI+V8H9A71ZEATsoyTnrUXOa1dWLDfW47UWNxV1V?= =?us-ascii?Q?oKUsNuchK+Y/8vTGJfU1f9Gm+yBgwztwDNPmO0D8ahDEe1AQiy8+X9qe0v28?= =?us-ascii?Q?94nO5Afose8Oo4qVIIdTNGewg/5pVsBhAGF0t0yFLr3YJkEYSwkp/OgqOzDf?= =?us-ascii?Q?qpzUGyshCImNjkw7V5oz7dPM6arzFaY6r1TdeiS/avCxqtIH528h5FIMRIUS?= =?us-ascii?Q?zwePtaw5CamQp4HBnGgBXiv6kkVM8r2UiIXoXiMd2mLTSAcm7WaJoZFhLGhQ?= =?us-ascii?Q?jb2DbgNNkoGVj3l7FpLtytLDmKp9nMhOyTEi53pm0WO/wunTmC0tT+tr33DE?= =?us-ascii?Q?wvV2J0WF/K/DqDI7wyT+FbEhlg61SEvnhvhzCN7jek/f1COi8Oy2SheBt3xE?= =?us-ascii?Q?TV0eqzlozGJw94SjRNAXoV67t5WqeGXlOHNm+CtY5oAmpkPwiZqd/J2Z8gBD?= =?us-ascii?Q?09ca5nxYe4h3nzHCL7meZaODYHWeVihmeJtziw2pl/Q0rZaO7AQhN1NWZiCC?= =?us-ascii?Q?cEDnZcV0OKsFVqpVc2Fwl9goNqYouzS+q7ibg5jeFbN2wIyTDr+zeiUE07ov?= =?us-ascii?Q?skhITKevFZ00hNcRnJrVshqCznEDR+806wa/5FrMqcEa+VvIB+fcmo49zj7g?= =?us-ascii?Q?L4KB1Ya7o5XV+DwzGoBvyE6Nquow+TYJ7h9p9bw7RzVP58FctH+xL1C8VYOY?= =?us-ascii?Q?xjlwh7E/ileZKiCf7qISurz1Muyld58Qj2BEgdIDx2zIemqxHSkuR7hH8lDF?= =?us-ascii?Q?Ki6CNHRTTvcCSRjO27cZyFCoX6caMPNgIeqVdHLstEHPpruKoXINtcimCWHU?= =?us-ascii?Q?/A+VJ1BuPOkaZ1rcX3A+GWeE+HtSonzLqhGrqoZIIre/EiQMBDAtTtIaWPnf?= =?us-ascii?Q?yfw9OxaF+0b9CyzOQHWL7UzGYnmpzivrcAtF690D9ZX1w35XEHGm4LClOfyT?= =?us-ascii?Q?qgA5jSKPR4DiMyL1YEkxktIgmuKwrIQ0LXWSUCW3XVHRCESMpooeqfHK71zK?= =?us-ascii?Q?72l5I6uxTj00nnl1npEobmWSt036Z8eu5uHLoUDobIVllbm7K3QmO2itDJaW?= =?us-ascii?Q?wZVm18P97T15QAWiP0HDWGtFU0rN2bBElmuDPDgHMV1A7uTMC8ogOEyYdjwE?= =?us-ascii?Q?EccCL/oz9W+hEGIZkq6TPoaDUteJ4JgKhsGcgG9m2Lf7JWcrzdUlMeNTPSib?= =?us-ascii?Q?B4yO8Tt16KWr+xUj/9hKws384Ne5Cie6ha1d6D6n7m9lYJPIj/pT2DoXbDCB?= =?us-ascii?Q?PzwvfFJ9pw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4f6d8f-3081-4866-3228-08da2dda1bdf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 14:26:42.1797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zrw/rqKVBSKFTM1ib5Agjedz2nFXgY98D6tyUjsGmIXWmLJTiUSGJamu0NwmYbUR/EW4mXw79MGRMcrV4gh+Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3266 On 04.05.2022 15:55, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 02:27:14PM +0200, Jan Beulich wrote: >> On 04.05.2022 13:20, Roger Pau Monn=C3=A9 wrote: >>> On Wed, May 04, 2022 at 11:46:37AM +0200, Jan Beulich wrote: >>>> On 03.05.2022 16:49, Roger Pau Monn=C3=A9 wrote: >>>>> On Mon, Apr 25, 2022 at 10:34:59AM +0200, Jan Beulich wrote: >>>>>> @@ -390,20 +390,41 @@ void __hwdom_init arch_iommu_hwdom_init( >>>>>> if ( !perms ) >>>>>> rc =3D 0; >>>>>> else if ( paging_mode_translate(d) ) >>>>>> + { >>>>>> rc =3D p2m_add_identity_entry(d, pfn, >>>>>> perms & IOMMUF_writable ? p= 2m_access_rw >>>>>> : p= 2m_access_r, >>>>>> 0); >>>>>> + if ( rc ) >>>>>> + printk(XENLOG_WARNING >>>>>> + "%pd: identity mapping of %lx failed: %d\n", >>>>>> + d, pfn, rc); >>>>>> + } >>>>>> + else if ( pfn !=3D start + count || perms !=3D start_perms = ) >>>>>> + { >>>>>> + commit: >>>>>> + rc =3D iommu_map(d, _dfn(start), _mfn(start), count, st= art_perms, >>>>>> + &flush_flags); >>>>>> + if ( rc ) >>>>>> + printk(XENLOG_WARNING >>>>>> + "%pd: IOMMU identity mapping of [%lx,%lx) fa= iled: %d\n", >>>>>> + d, pfn, pfn + count, rc); >>>>>> + SWAP(start, pfn); >>>>>> + start_perms =3D perms; >>>>>> + count =3D 1; >>>>>> + } >>>>>> else >>>>>> - rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_O= RDER_4K, >>>>>> - perms, &flush_flags); >>>>>> + { >>>>>> + ++count; >>>>>> + rc =3D 0; >>>>> >>>>> Seeing as we want to process this in blocks now, I wonder whether it >>>>> would make sense to take a different approach, and use a rangeset to >>>>> track which regions need to be mapped. What gets added would be base= d >>>>> on the host e820 plus the options >>>>> iommu_hwdom_{strict,inclusive,reserved}. We would then punch holes >>>>> based on the logic in hwdom_iommu_map() and finally we could iterate >>>>> over the regions afterwards using rangeset_consume_ranges(). >>>>> >>>>> Not that you strictly need to do it here, just think the end result >>>>> would be clearer. >>>> >>>> The end result might indeed be, but it would be more of a change right >>>> here. Hence I'd prefer to leave that out of the series for now. >>> >>> OK. I think it might be nice to add a comment in that regard, mostly >>> because I tend to forget myself. >> >> Sure, I've added another post-commit-message remark. >=20 > Sorry for being confused, but are those reflected in the final commit > message, or in the code itself? Neither - I didn't think we have any code comments anywhere which outline future plans, including reasons why not doing so right away. When writing that new remark I didn't even think it would belong in the commit message. Jan From xen-devel-bounces@lists.xenproject.org Wed May 04 15:07:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320804.541737 (Exim 4.92) (envelope-from ) id 1nmGan-00030r-T0; Wed, 04 May 2022 15:07:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320804.541737; Wed, 04 May 2022 15:07:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGan-00030k-Pe; Wed, 04 May 2022 15:07:05 +0000 Received: by outflank-mailman (input) for mailman id 320804; Wed, 04 May 2022 15:07:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGal-00030e-QH for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:07:04 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8b27c3a-cbbb-11ec-a406-831a346695d4; Wed, 04 May 2022 17:07:01 +0200 (CEST) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 11:06:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB3230.namprd03.prod.outlook.com (2603:10b6:301:47::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21; Wed, 4 May 2022 15:06:43 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 15:06:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8b27c3a-cbbb-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651676821; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/tDBmlUfkdgZedZn816TXJs6fQ2aaqtHWjaOnvFZZzM=; b=MUgjKSFHKHwkjCrHVbUR7uOvUMe8qxUfdNc18r5J5RR8Pyrd6r0tCmJv ltE0JISHuayPRFjJes+JKsN6kgkgn/awlO11fjq4rr2sOsdhCgJMh2rXT IvaVaGo8W8QnA/iAvlGS3QLtwBBmHNGyazk5dltB5pzuLrBbxSynp2EQs Y=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 70562892 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sZelU6z1fV98Wo2dQQ96t+dMxyrEfRIJ4+MujC+fZmUNrF6WrkUOx zYaWz2DPaqCY2LyKd1ybImx8x4P75CDzYdjQVY4qSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12YThWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplsaCyUFs3IarwiPk3dQZ+IjBgELd7weqSSZS/mZT7I0zuVVLJmq8rKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtadHeOWube03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianLmMC+APPzUYxy07+7B5v4p3iDPPUe4ysQeFTkVSYl m2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM/JPF8Uq5QfLzbDbizt1HUABRz9FLdk57sk/QGVw0 kfTx4+1QztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:KoG7PKPZ0ZvQ8MBcT0j155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DsrvZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolCs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REIGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUETA9OL8y7qvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wM9HdwGOt15Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexrwqEH3QSuvyWqOLtB0B1v977jK3Z4S2MaGPLQ18bpaou W1bLofjx9+R37T X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="70562892" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hzvs74yV/ag/Ej/V4Jxc2nIxfug9HdrYkM8y2HdgspyI8zpoEk4sPc8YquLBju4xIG0dHfJAOF99qDHDbRn6OLHor5PjStrDuRn6elwFyQSrjN8MwfX/F4PTHZMQwFbP6JyAhGPXb+2trjfRJlLjPjsxwevOsU9PYs9MIPq/tAvGcd+xMexiYNBisu94gNUh40f4hYI8bRWTVCnouCySTSO511RbBOQ3sGUiR86wQVUroteYyijONt49XcmOTbQkgzgBfyGBAGB+9S1oDmnjiA5/wM5byEnuc/+8Z6CSlKlDHyPRDvOlxay08JjLkg25u4VPeLthDsp4fzonu0S8gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dNCr8JtWNmzzkI4xTIFBx6uWfiaIOvJ4Yifm6zPjdcc=; b=AnGK9l8YO7yeTJ9IwMPTRofWs13H57NfwK2A+qT+zdLqNYl1TvkBxSvcpZun5itM2d3xpWkHhSq6BayjvuKZUEATv5S3L/lzrz0m0/sTtaO/icXW1g6osIWr9xL4KRqOc6DlgJuYphieYO+4+vB3PpzeIym6Bul2AR88dq+cmGnJ6WQxDWQE94iSKIx3oCTRIUsP4j7BHp5NETvU02htvey7ihPzizpyJ0+8NAyEjqmADBhijmDj5VV3pQh2ofdFTYT0oWAVDZS+rIfQca/1/LTV3xMPlte3kjMicXKUFBZ7ZYIABsUXOke6hs8a0beuWckVbtUy/Dxn+oQEcceaBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNCr8JtWNmzzkI4xTIFBx6uWfiaIOvJ4Yifm6zPjdcc=; b=oIIn97RusZ2JEgDZq3cXXoX4UouCNfKcwFLTdL8rF66EfpwXj9+FMiHqCnDsbnWrJ3Gp5Kol+DJ+KKSGorfpKbvIfkirwbvHPaIg9J9b3xh1eHINwoG/Ped3j2QE8liz9lai7roRo0St+z4KnB9RqN/ZCOa4mu3w0c3X0G3FecY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 17:06:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables Message-ID: References: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> <2d0d8aa9-1ab8-a505-e2df-c9b6446062cf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2d0d8aa9-1ab8-a505-e2df-c9b6446062cf@suse.com> X-ClientProxiedBy: MR2P264CA0059.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:31::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0961f478-510d-4062-d793-08da2ddfb2c7 X-MS-TrafficTypeDiagnostic: MWHPR03MB3230:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MKrLMM206IO2irf183dvYGbBMP63De97ABSoORX1tvSs7+Xj1e+ZHC9L1R3zsvZp7Y5brVlVvpGDgAPFJ3S1hi7AAJgjWOVTpMyqov8bJJGJWwwpNIPZe8nSiVtl+h19YOgRHb5dK917Rz/aRjGz8DYwwbb+fQhppsF+R97ZVU+SZ49Rr50MDoHAIXGfVgZm42mKwAeApd2QJcZZsOueUee/KvJnsrecOWIRvQHuOAcF70LX4rObcZdvRb6wO0vqmV80hSscUHL8qa2/p039ahPCjYG9XYEGKeS/Xfx57uHSblFXQD5shcyGX7FSi3ahAfMdWbV/Ame7YK8/M76pBolzKd4TsR9p1gnvl9lXmx4LG5I9cjhl6ZMjpmIbWujizCJIrKqtCjREcnZ0675HgLpwALuDWBuVKivoeb1N0O6fYVml8+vcpb1ftZ06pvXQcDte9hoWMbCA4vo0SE8tz6tiA/GiUlGNVBe57/7Q3XpfPaw733EPLIfumxudjAHEyKUIrgsPDO0u323jOA/DlCV9EONAXHIZHAIQeJ7u3cWv1efAHJtQQS/i/F2uU9lwlUoo+U1/KOOcC+tPhfNblFujkBQoibdH1ggd8ihEPoYj6O4ugfbSqluU7xUU+xgJmhkVqDw6vq7mB0F1xX5wqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(26005)(5660300002)(186003)(86362001)(6512007)(9686003)(82960400001)(8936002)(8676002)(4326008)(2906002)(66476007)(66556008)(66946007)(53546011)(6506007)(508600001)(6486002)(33716001)(54906003)(6666004)(6916009)(316002)(85182001)(83380400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QURtTkl6YUQ1dHJJaHVPMTdENDQwcDcySDRaeWc3UFp3L0pPQTRzbHpWbUZR?= =?utf-8?B?ZGxNVTJZNzl0SzdIZjQ2UjFKTmRLZHNlMCtJTnBQK3h2SDNJWGMyN2w4WWNB?= =?utf-8?B?eUEvdDlYYlFiKyszeXJqd0hzcjRLaDVTTlorVzBIeHV5ZWc2TTVsaU5RY09w?= =?utf-8?B?YUd1QVhCbjNta3J1bkNCYjFZRXRpTVVxNVcwRjRqVGJNT0grNVovMUhkS2lN?= =?utf-8?B?NXByWlBSaDJqSCtQUjZNZXZwNU5lN3pXUTh4M29nREhzZnRxTVhCeXZ3NFNR?= =?utf-8?B?YmN4TjhDZmx2TGZEVSt0aVZpTnQ3OUMxa2lCZllYVC8xSCtXaUp6YWxpM0JC?= =?utf-8?B?R0lpUEtmQ2d6UzV2ZWREVXZycklDZGxZdHFUYTViazA5Mzc0b0c1c0t1Q1g2?= =?utf-8?B?OHJkZHh0c1ZsRllqK3dXbXlkbEhtMWtZOW5FNnVULzRsa0tPS3RTdkRkVjRr?= =?utf-8?B?bTV3NkhDbGo3T1FsV1lUSDJZR3l5MXJXdkZoNUkrNGlialY2RUpzeEpBMTBJ?= =?utf-8?B?MmpxZ2RvZGFFZUVhL2VoRW9NcllMSGxzNVk3dFpaMFJpSmh6WnpkV3JFbXBL?= =?utf-8?B?dWs3R0xJYk9oYUExR1lBYmYxdFp1T1U0Nk1UM2RvYlV2RDZDZnAzaWNVcGJ4?= =?utf-8?B?aUkxRzZoditkOTc2YWxaRkpwREg1enUweXFzRW9yNm5YOGlaUUFnRlhnVWNl?= =?utf-8?B?ZHVoSElJM2ZKNnpkZFBiOGRYQ2EwS0x6MWJuUmgrdkkvOExoYzM2b2w4N0o4?= =?utf-8?B?ZzNKNEpsZ1h4VWxZMFJ5elcrUjV1dytqNmZUb1BzVEtQbnFmVmlyNVhBZGsr?= =?utf-8?B?dGFvVmVJelVsbEczbVZTMklYa1d4VTJOZ1h6R081VnRkaG5HR0JLa21LSktF?= =?utf-8?B?c0E1VXJjalhiN2h4L3FUYmNTM3YzYnJmekJabVFXN2VLTGVYZkRZWFFxMmRa?= =?utf-8?B?ZEo0NkVMRmhUejA2Ujl3SXpvSFo1cVZqenJENTgvbnh4REd6TmRVWHhWMXFh?= =?utf-8?B?SXBMVXVaNEUvK0ZzWWxXZm5nYXc1YXY5bE41Y3hJbXJRV1BaRGIxTE1KZW16?= =?utf-8?B?SW5sdkppNXlUbkZxN1RsdjVIOTdITGZJdEFkMTcyYkFidHpKdFlJQ2JFdC9R?= =?utf-8?B?ektnVlVHODNMT3oyaGFHYk92WEdrRER4cjVXL0tCN3hpSmtjUk91K0dEbWhQ?= =?utf-8?B?TWFDMVRiZENyVXU4VUgwZ3FzaWJSNi9sVTgrQUw5dDdMYWxKc3VIa0ZVMExq?= =?utf-8?B?VTZoTTJqTnd3cmFVcXByVnRMM0M4NFpSQlJwL0RCQXV5SmJIeGFRQk9XMjNo?= =?utf-8?B?OFpXSE1vL1VJdE9RMi92eTFpRTd2UytMclRNQVpleWpIbUJjMlVsdXhxYTFn?= =?utf-8?B?WGs2N0toblJwVTRsbmFPRzA1SjRIS1QxZ1FPTnJKT3A1cnJreDFaVTFVd0ZD?= =?utf-8?B?VmxnVmRld0lwVGo0alVGZEJkZUhnL3p6dVBNM3AwdzFIQjc1cCtjR3FJMlZr?= =?utf-8?B?bUd1dzZXZU45TnVIcTNJdXRidTFRb1ErK1F2eHhFSHNQUGNwdlBIV3ZDUVIr?= =?utf-8?B?cU9COVkxYmZlVU5BR21RRitVdkdTeVVOM0JWRXRqOXV1azBKQnZySm5aRmF6?= =?utf-8?B?bmNjOFVQMlBmMVl5THdCWEMxc1JGN0pETjh2c2d1ci82RyswcnJrWWNzUHdU?= =?utf-8?B?WWJLMkNSMk5GdU1vYXJyUWYvWGpFRkJhZy92YzY2OEM1WCtqOW1iRDZmYjVi?= =?utf-8?B?RlBrcWw4cUtWNU41ZTRBWmtoU0ZHdzQ3N0lFWGtwNkRMNDZkdENlRkVzc2Nk?= =?utf-8?B?UzQ4WlJtaFhQU0FiOW9DZWlDMklBL3JlYUJXNjR6T210OVY0SnpsOGYweFFm?= =?utf-8?B?dHMzaEVLK2FvTDhJT0pKWUt4eGJaTjhERWdtZWlUc0VZdkk4a1FwVzlMMXdl?= =?utf-8?B?cjc4NlhjK2RYendLNTBEZXdJc0hNUTZiRHpLb1pCZ0lPeUV0T2lXWFU4UnRw?= =?utf-8?B?aG43QzVEOVlvL2s3SDB4RDlOc3B5VFJVdDJtRnNyWG1Md0gveXUrbWp3dVA4?= =?utf-8?B?Y24rSTV2c0dGeHMrVTZROFY2MytrRW1yT0tiNjhwOGd6ajU4QkY5ZU1hdkxw?= =?utf-8?B?TkVsdjJnWWFQY3VFdENDT3JuV3E4YkJGTHVuN3p2dmhZTFNvRU1EdGtHKzc5?= =?utf-8?B?bzBRM1J4TkNCblNYSUlHd1l5YU81aElPZHJBQVROMGFEZ2lXenJNcHdlbEJi?= =?utf-8?B?c2piR2xYc3NLc2o5blhMa0ZlaGVIaUovR05PUVBIMTRZalBFdXErYUhaeldS?= =?utf-8?B?VmRIbmRVOWVPdklET3VtUnF3MFhEYlJPbS9mc050SUlFVlJqYitPUmhVYVA5?= =?utf-8?Q?mT04IJjl4udWcGXA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0961f478-510d-4062-d793-08da2ddfb2c7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 15:06:43.1431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7/Uy/rr2O8jqdY63eaKxW8bXoAsHxX5+0oZISShJdsw0xKLPwYFGhAb96AswZxPD8a+CZ9lywBBcHz/lG3IVVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3230 On Wed, May 04, 2022 at 03:07:24PM +0200, Jan Beulich wrote: > On 03.05.2022 18:20, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: > >> For vendor specific code to support superpages we need to be able to > >> deal with a superpage mapping replacing an intermediate page table (or > >> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > >> needed to free individual page tables while a domain is still alive. > >> Since the freeing needs to be deferred until after a suitable IOTLB > >> flush was performed, released page tables get queued for processing by a > >> tasklet. > >> > >> Signed-off-by: Jan Beulich > >> --- > >> I was considering whether to use a softirq-tasklet instead. This would > >> have the benefit of avoiding extra scheduling operations, but come with > >> the risk of the freeing happening prematurely because of a > >> process_pending_softirqs() somewhere. > > > > I'm sorry again if I already raised this, I don't seem to find a > > reference. > > Earlier on you only suggested "to perform the freeing after the flush". > > > What about doing the freeing before resuming the guest execution in > > guest vCPU context? > > > > We already have a hook like this on HVM in hvm_do_resume() calling > > vpci_process_pending(). I wonder whether we could have a similar hook > > for PV and keep the pages to be freed in the vCPU instead of the pCPU. > > This would have the benefit of being able to context switch the vCPU > > in case the operation takes too long. > > I think this might work in general, but would be troublesome when > preparing Dom0 (where we don't run on any of Dom0's vCPU-s, and we > won't ever "exit to guest context" on an idle vCPU). I'm also not > really fancying to use something like > > v = current->domain == d ? current : d->vcpu[0]; I guess a problematic case would also be hypercalls executed in a domain context triggering the freeing of a different domain iommu page table pages. As then the freeing would be accounted to the current domain instead of the owner of the pages. dom0 doesn't seem that problematic, any freeing triggered on a system domain context could be performed in place (with process_pending_softirqs() calls to ensure no watchdog triggering). > (leaving aside that we don't really have d available in > iommu_queue_free_pgtable() and I'd be hesitant to convert it back). > Otoh it might be okay to free page tables right away for domains > which haven't run at all so far. Could be, but then we would have to make hypercalls that can trigger those paths preemptible I would think. > But this would again require > passing struct domain * to iommu_queue_free_pgtable(). Hm, I guess we could use container_of with the domain_iommu parameter to obtain a pointer to the domain struct. > Another upside (I think) of the current approach is that all logic > is contained in a single source file (i.e. in particular there's no > new field needed in a per-vCPU structure defined in some header). Right, I do agree to that. I'm mostly worried about the resource starvation aspect. I guess freeing the pages replaced by a 1G super page entry is still fine, bigger could be a problem. > > Not that the current approach is wrong, but doing it in the guest > > resume path we could likely prevent guests doing heavy p2m > > modifications from hogging CPU time. > > Well, they would still be hogging time, but that time would then be > accounted towards their time slices, yes. > > >> @@ -550,6 +551,91 @@ struct page_info *iommu_alloc_pgtable(st > >> return pg; > >> } > >> > >> +/* > >> + * Intermediate page tables which get replaced by large pages may only be > >> + * freed after a suitable IOTLB flush. Hence such pages get queued on a > >> + * per-CPU list, with a per-CPU tasklet processing the list on the assumption > >> + * that the necessary IOTLB flush will have occurred by the time tasklets get > >> + * to run. (List and tasklet being per-CPU has the benefit of accesses not > >> + * requiring any locking.) > >> + */ > >> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); > >> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); > >> + > >> +static void free_queued_pgtables(void *arg) > >> +{ > >> + struct page_list_head *list = arg; > >> + struct page_info *pg; > >> + unsigned int done = 0; > >> + > > > > With the current logic I think it might be helpful to assert that the > > list is not empty when we get here? > > > > Given the operation requires a context switch we would like to avoid > > such unless there's indeed pending work to do. > > But is that worth adding an assertion and risking to kill a system just > because there's a race somewhere by which we might get here without any > work to do? If you strongly think we want to know about such instances, > how about a WARN_ON_ONCE() (except that we still don't have that > specific construct, it would need to be open-coded for the time being)? Well, I was recommending an assert because I think it's fine to kill a debug system in order to catch those outliers. On production builds we should obviously not crash. > >> +static int cf_check cpu_callback( > >> + struct notifier_block *nfb, unsigned long action, void *hcpu) > >> +{ > >> + unsigned int cpu = (unsigned long)hcpu; > >> + struct page_list_head *list = &per_cpu(free_pgt_list, cpu); > >> + struct tasklet *tasklet = &per_cpu(free_pgt_tasklet, cpu); > >> + > >> + switch ( action ) > >> + { > >> + case CPU_DOWN_PREPARE: > >> + tasklet_kill(tasklet); > >> + break; > >> + > >> + case CPU_DEAD: > >> + page_list_splice(list, &this_cpu(free_pgt_list)); > > > > I think you could check whether list is empty before queuing it? > > I could, but this would make the code (slightly) more complicated > for improving something which doesn't occur frequently. It's just a: if ( list_empty(list) ) break; at the start of the CPU_DEAD case AFAICT. As you say this notifier is not to be called frequently, so not a big deal (also I don't think the addition makes the code more complicated). Now that I look at the code again, I think there's a tasklet_schedule() missing in the CPU_DOWN_FAILED case if there are entries pending on the list list? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 15:10:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320810.541747 (Exim 4.92) (envelope-from ) id 1nmGeL-0004Qt-HO; Wed, 04 May 2022 15:10:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320810.541747; Wed, 04 May 2022 15:10:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGeL-0004Qm-EX; Wed, 04 May 2022 15:10:45 +0000 Received: by outflank-mailman (input) for mailman id 320810; Wed, 04 May 2022 15:08:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGcA-0003bg-WC for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:08:31 +0000 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [2607:f8b0:4864:20::1030]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0dc8c419-cbbc-11ec-a406-831a346695d4; Wed, 04 May 2022 17:08:29 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id e24so1489435pjt.2 for ; Wed, 04 May 2022 08:08:29 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l9-20020a62be09000000b0050dc76281fesm8311194pff.216.2022.05.04.08.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:08:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0dc8c419-cbbc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qb+1GrJs8SRgE6Wq+GlmzxuejfTqdKZ3b89DzJavSQw=; b=QW7CQXai9IiD71Wvf+o2VYxsrI+DMXmN1vsS0b5DV0rtrX+G8r3eGzQnrLgcSNLS6o 18VjexLmt9t17aqS0qc4jCF5CPslGIy/SB1vEauI+iOiw3aemKigwzjm7wU//Osg3Pbt 9wMF/4HUhAaX0invtmDD41DdrKFbACP1VK8u0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qb+1GrJs8SRgE6Wq+GlmzxuejfTqdKZ3b89DzJavSQw=; b=XvfkywNj3hPCxapKjjwM40c8Xxsteuyr18doI0sCiVopQbPMJwrhv7B9gLsgi7kuOm Er405qRRSZXaKzuW1eOkV+cHqv64dLxXBviYiwUBayLFbTH4eMqWFM4QaZQa8rqf1vMx AOniQOEc5gSs8Q6NEmx7x2c7q6hKmDIjUS8f8yOHAvsRoTxakxpud9R4RWZG0vxMX7oN 5uSINehXYJteq7XEiEj7LiaXbIlViVPL3ij0IMmuisinhwTEW0CtqfXvGRldfniw9eWx r3O/AcexBq7xEinQB1eklqyEc3dE3N23rtxrg5pWVSWd92GT3Z83iDjHXnjbl3Wb1yRP r29w== X-Gm-Message-State: AOAM531OFwVDRAv449Pg2VeyEfslOkQfpvAVMoSxLWtcb8Jur7Ba4boh iPXvYmomoRc27rYPfNxw6FOnzw== X-Google-Smtp-Source: ABdhPJwHiFEMEf0LT8rKs64uS9VK7WCOKMtRJ3EqkT4Zb3Dx1isF6RYPGWL4Kz+uhEu4FzOD4HUSMQ== X-Received: by 2002:a17:902:82c8:b0:15c:f7c7:ef9d with SMTP id u8-20020a17090282c800b0015cf7c7ef9dmr22125373plz.44.1651676908149; Wed, 04 May 2022 08:08:28 -0700 (PDT) Date: Wed, 4 May 2022 08:08:26 -0700 From: Kees Cook To: Kalle Valo Cc: "Gustavo A . R . Silva" , Loic Poulain , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 10/32] wcn36xx: Use mem_to_flex_dup() with struct wcn36xx_hal_ind_msg Message-ID: <202205040730.161645EC@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-11-keescook@chromium.org> <8735hpc0q1.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735hpc0q1.fsf@kernel.org> On Wed, May 04, 2022 at 08:42:46AM +0300, Kalle Valo wrote: > Kees Cook writes: > > > As part of the work to perform bounds checking on all memcpy() uses, > > replace the open-coded a deserialization of bytes out of memory into a > > trailing flexible array by using a flex_array.h helper to perform the > > allocation, bounds checking, and copying. > > > > Cc: Loic Poulain > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: Eric Dumazet > > Cc: Jakub Kicinski > > Cc: Paolo Abeni > > Cc: wcn36xx@lists.infradead.org > > Cc: linux-wireless@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Kees Cook > > [...] > > > --- a/drivers/net/wireless/ath/wcn36xx/smd.h > > +++ b/drivers/net/wireless/ath/wcn36xx/smd.h > > @@ -46,8 +46,8 @@ struct wcn36xx_fw_msg_status_rsp { > > > > struct wcn36xx_hal_ind_msg { > > struct list_head list; > > - size_t msg_len; > > - u8 msg[]; > > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, msg_len); > > + DECLARE_FLEX_ARRAY_ELEMENTS(u8, msg); > > This affects readability quite a lot and tbh I don't like it. Isn't > there any simpler way to solve this? Similar to how I plumbed member names into __mem_to_flex(), I could do the same for __mem_to_flex_dup(). That way if the struct member aliases (DECLARE_FLEX...) aren't added, the longer form of the helper could be used. Instead of: if (mem_to_flex_dup(&msg_ind, buf, len, GFP_ATOMIC)) { it would be: if (__mem_to_flex_dup(&msg_ind, /* self */, msg, msg_len, buf, len, GFP_ATOMIC)) { This was how I'd written the helpers in an earlier version, but it seemed much cleaner to avoid repeating structure layout details at each call site. I couldn't find any other way to encode the needed information. It'd be wonderful if C would let us do: struct wcn36xx_hal_ind_msg { struct list_head list; size_t msg_len; u8 msg[msg_len]; } And provide some kind of interrogation: __builtin_flex_array_member(msg_ind) -> msg_ind->msg __builtin_flex_array_count(msg_ind) -> msg_ind->msg_len My hope would be to actually use the member aliases to teach things like -fsanitize=array-bounds about flexible arrays. If it encounters a structure with the aliases, it could add the instrumentation to do the bounds checking of things like: msg_ind->msg[42]; /* check that 42 is < msg_ind->msg_len */ I also wish I could find a way to make the proposed macros "forward portable" into proposed C syntax above, but this eluded me as well. For example: struct wcn36xx_hal_ind_msg { size_t msg_len; struct list_head list; BOUNDED_FLEX_ARRAY(u8, msg, msg_len); } #ifdef CC_HAS_DYNAMIC_ARRAY_LEN # define BOUNDED_FLEX_ARRAY(type, name, bounds) type name[bounds] #else # define BOUNDED_FLEX_ARRAY(type, name, bounds) \ magic_alias_of msg_len __flex_array_elements_count; \ union { \ type name[]; \ type __flex_array_elements[]; \ } #endif But I couldn't sort out the "magic_alias_of" syntax that wouldn't force structures into having the count member immediately before the flex array, which would impose more limitations on where this could be used... Anyway, I'm open to ideas on how to improve this! -Kees -- Kees Cook From xen-devel-bounces@lists.xenproject.org Wed May 04 15:12:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:12:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320817.541759 (Exim 4.92) (envelope-from ) id 1nmGfe-00057Z-Tv; Wed, 04 May 2022 15:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320817.541759; Wed, 04 May 2022 15:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGfe-00057S-PK; Wed, 04 May 2022 15:12:06 +0000 Received: by outflank-mailman (input) for mailman id 320817; Wed, 04 May 2022 15:12:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGfe-00057G-66; Wed, 04 May 2022 15:12:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGfe-0007P0-4J; Wed, 04 May 2022 15:12:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGfd-0004dP-QO; Wed, 04 May 2022 15:12:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmGfd-0003fB-Pw; Wed, 04 May 2022 15:12:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8Yv1g7mM+/lqS/D8xmCVNgoGM/aTqgdfhDapo0jyivY=; b=YpjcX6+yIUDSr12JO5Haxn+6O2 su6MYUKyOLJb+gbnkpPmNUkDE/n//P76aIKgLyaaYm1iGk/hMVPt0Vj6qsSgiLxdClorFbWD25soq gCXbzVZCEPDz6QgHnT8ZNaQg5eMW+2Y7vzEvUZXRToLd8+6t3mxVv9GPU2XOapTHVuOc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170106: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 15:12:05 +0000 flight 170106 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170106/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 802 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 15:14:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:14:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320828.541776 (Exim 4.92) (envelope-from ) id 1nmGhv-0005nS-GP; Wed, 04 May 2022 15:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320828.541776; Wed, 04 May 2022 15:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGhv-0005nL-DE; Wed, 04 May 2022 15:14:27 +0000 Received: by outflank-mailman (input) for mailman id 320828; Wed, 04 May 2022 15:13:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGgl-0005WY-R3 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:13:15 +0000 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [2607:f8b0:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7c9ff4d-cbbc-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 17:13:14 +0200 (CEST) Received: by mail-pf1-x42a.google.com with SMTP id p12so1403255pfn.0 for ; Wed, 04 May 2022 08:13:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id ij18-20020a170902ab5200b0015e8d4eb204sm8399103plb.78.2022.05.04.08.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:13:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7c9ff4d-cbbc-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K5o0mxzRhIj/1qVaf+Qsisfgid2WQLM66dSEL7WW688=; b=XkqjtCLvOAHdMweJpAE7OFgXj0jWG7id7d0Hhskj9BPIqKJFUoqoOWLf2YUT5xAOL1 wZmhUNtZAmbQT4d6fpbwfM2QOncu2zNn3djMX16s2PmGSDIstIDxugPIALaO8utyKIj7 sKwWZedxfPJh4WLIB65ege/77jViBz9SzZ4sg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K5o0mxzRhIj/1qVaf+Qsisfgid2WQLM66dSEL7WW688=; b=hvWwozAKJB7+5a47bwL3/TbHJMJYnhtGJMGiKysO2sqI1Dw6KK7rx+W6mjywxZMqgt 6dl7WZpy+3NsEy3EAq2qerisrgpaAg63jnDT1hKdaPM2QR8DmhWlxTDWzz8+9K5I3lyX IlNpRhAqfX3DjWFEWLL22Te+GbdApTpc6R/QrizlAuGfq5IJFFhxjkR81DaRWZILvCZk gETrszg3vUQnN2yAtHc33CS5thebpfdbZ1PHsOE2jb+zJNEoI2Jwmx8159tUk7OweSEY R9PzhBg+4uV1E6nF66zykjhn6K7/zRwi7TVHdisby5/02O3uDTuJAv3T2FNZhKNXUBRO o3lQ== X-Gm-Message-State: AOAM530Vf0HWk/y30e4Z2u0GaBRp75okHJcO6lO+iqqdtHf3MENBkFLn 8dGT2EOQlLi4gfzOoI0GPP0HEw== X-Google-Smtp-Source: ABdhPJzX6+dBcxBz0XblIdgMGWS0aXoAf/IhYxrn+6863Acr/iqsf/vGdFE+GWueiipLbn0gI1TqjQ== X-Received: by 2002:a63:184c:0:b0:3c5:fd55:1e9e with SMTP id 12-20020a63184c000000b003c5fd551e9emr1189487pgy.315.1651677193381; Wed, 04 May 2022 08:13:13 -0700 (PDT) Date: Wed, 4 May 2022 08:13:12 -0700 From: Kees Cook To: Johannes Berg Cc: "Gustavo A . R . Silva" , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 12/32] cfg80211: Use mem_to_flex_dup() with struct cfg80211_bss_ies Message-ID: <202205040811.05D7E61@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-13-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 04, 2022 at 09:28:46AM +0200, Johannes Berg wrote: > On Tue, 2022-05-03 at 18:44 -0700, Kees Cook wrote: > > > > @@ -2277,7 +2274,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > > size_t ielen = len - offsetof(struct ieee80211_mgmt, > > u.probe_resp.variable); > > size_t new_ie_len; > > - struct cfg80211_bss_ies *new_ies; > > + struct cfg80211_bss_ies *new_ies = NULL; > > const struct cfg80211_bss_ies *old; > > u8 cpy_len; > > > > @@ -2314,8 +2311,7 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > > if (!new_ie) > > return; > > > > - new_ies = kzalloc(sizeof(*new_ies) + new_ie_len, GFP_ATOMIC); > > - if (!new_ies) > > + if (mem_to_flex_dup(&new_ies, new_ie, new_ie_len, GFP_ATOMIC)) > > goto out_free; > > > > pos = new_ie; > > @@ -2333,10 +2329,8 @@ cfg80211_update_notlisted_nontrans(struct wiphy *wiphy, > > memcpy(pos, mbssid + cpy_len, ((ie + ielen) - (mbssid + cpy_len))); > > > > /* update ie */ > > - new_ies->len = new_ie_len; > > new_ies->tsf = le64_to_cpu(mgmt->u.probe_resp.timestamp); > > new_ies->from_beacon = ieee80211_is_beacon(mgmt->frame_control); > > - memcpy(new_ies->data, new_ie, new_ie_len); > > This introduces a bug, "new_ie" is modified between the kzalloc() and > the memcpy(), but you've moved the memcpy() into the allocation. In > fact, new_ie is completely freshly kzalloc()'ed at this point. So you > need to change the ordering here, but since new_ie is freed pretty much > immediately, we can probably just build the stuff directly inside > new_ies->data, though then of course we cannot use your helper anymore? Eek, yes, thanks. My attempt to locate the alloc/memcpy pattern failed to take into account anything touch the source between alloc and memcpy. I'll double check the other examples. -Kees -- Kees Cook From xen-devel-bounces@lists.xenproject.org Wed May 04 15:22:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:22:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320838.541787 (Exim 4.92) (envelope-from ) id 1nmGpV-0007M0-CV; Wed, 04 May 2022 15:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320838.541787; Wed, 04 May 2022 15:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGpV-0007Lt-8P; Wed, 04 May 2022 15:22:17 +0000 Received: by outflank-mailman (input) for mailman id 320838; Wed, 04 May 2022 15:22:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGpU-0007Ln-5n for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:22:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8fe57b3-cbbd-11ec-a406-831a346695d4; Wed, 04 May 2022 17:22:14 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 11:22:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB3512.namprd03.prod.outlook.com (2603:10b6:a02:af::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 15:22:09 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 15:22:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8fe57b3-cbbd-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651677734; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=xjjpDfurCFr4fQGUmo+sE3/9zUTMYO0ZZwKB2QaDgDQ=; b=JxbdnxRcgcPH7CBcYcaNo1Aqt6l7C7jepy5bYqnDSMByXvv0QwTbUC8d 9epjd4nl2U/mFIEkzrsTRKMv+hct05v6UIzXOVsD6R8ZmRWTazF7K3mRc TnEc6Y/O0SqB4Rp1CXmGgfY6RroVVPVHP1la4s5soYG8TsjAGtuxGZIWh 4=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 73042646 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bJYAnaNKMgOYp5bvrR3TlsFynXyQoLVcMsEvi/4bfWQNrUorhj1Sz msaWTrXPqqMY2SjetkjbY+/8xxTvZ/cn9JhTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tIw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9 tVHkbW/ZCESJqjxk+oRDSNVGQpGBPgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPqiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33SGjKWME9jp5o4Ic0UXT4ApT7ILzF4DZI/y1VMsImmmx8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FSiU93VTxC+5nmesXYht8F4FuQ77ESBz/TS6gPAXGwcFGceN5ohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnFb6PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:1F7oj6gJYztH68mD6O0GvTqIoXBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="73042646" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXGjXmeyHgBb6OiTFVwieL5Gi96CC0RpRwEKhgiTduwr+7xKjg4RUfwzeN61WWm17zi5riri2NMIhn+PNtdluW82k0HsNnqqvXlixchnMtvtfzP6YFs+jJQrAGP8ai+lJIwsFPpoyCkU4bsdGwuOKjhnN7pR4BREwhkR++3t0pi0rr9Z2Rs+WEUszR58xXUSnyD07z+dI7Dcg/oGcHWlRt0YQTE3GxwdkIMOA1lsmufAvLG1yw+E4K2w4y6Wd9Ts/V9XRZPV4BrrWfjGJub4qCoo9C3MIIZC4e6G7bNimiRYBvNALWacvLwX84+le2WdZL/mIAfO39hIBP6/aN85iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mf0+SJmhNTTx4Llp+FZHiwS/xWK9D5akmjx62ddNe1E=; b=FYPlPNAewErR4ldC0veER2GO4KzsKwjZUTs8jPbmAWwzHeOgQ1X9dbfdNIBkMrx1bI7WfbpQkkU3vb7xTYIoJjQR/25EwYvJk8IiN2x9NwjzDABLi19zwbMx9IO/gS1LfU+tibFSMmZFCDrlQj+DEGlFH1DrYbnsIV+UkUqUVJHwUtbcQ8IEqaLm75+br5V4fkoFXDDb532jn3LtGWqKeKYkF2XGEzWRGhpkd39v8r7CiLw4UxilR/ZaFl8adqAFiHXoFy0glaFKWLR2nuXoBZdl/cSODvjj1s+LJbyXpQj2Y/v/NqmZ3+wAX0s7/jOD7yLb7oa+L88UuQVSWeKyqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mf0+SJmhNTTx4Llp+FZHiwS/xWK9D5akmjx62ddNe1E=; b=cDejAw4L2i0as28mKW17yZyiD5szG5VwRzXFjPYIr+705sM/FGodCx1MJQZeo1H4xcYknLu3o/a2nTzDJcLohWlcWkmhznXlL9ItKNwgw65cKV6ZfWS9Vrzq4C/G33IN/umloDHBCvzA3wGJrxVoqj6a/LMiVfHOfEDTkBQ9R+U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 17:22:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 05/21] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <6ffd48ee-9356-2f22-415e-03e172eabb55@suse.com> <6f45248b-2f49-0834-e801-d298ea680a33@suse.com> <66587a43-02b8-20c6-2663-4a6fc3e010e2@suse.com> <2018a835-e924-7d70-1160-227acd75947c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2018a835-e924-7d70-1160-227acd75947c@suse.com> X-ClientProxiedBy: MR2P264CA0044.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3099a40f-c462-444b-79a3-08da2de1daec X-MS-TrafficTypeDiagnostic: BYAPR03MB3512:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FnsXHH2MK1kcyIPQLXwiYz92nF7jg0iX422YLLaOG4LjlKP/2sba6eHv3a2UxxQSYGRrXgh0hsc4rPWlqF95QnxMOtAAcsJyqM5FMusS5oEFLtn/m6DtJdsltTwsyRo4ZeQba3gnQ31gF28pPXUawVz5NPB07b2VutqH12661yJswmCda01N2KGKhBqsRTIYJ/0j5037sirsivUfT93qxUm5GoO69jbNauEYyy5lB8gECeAccwnFPyXHplTGIpK/guRaZRqcO1XgybXn+k94rbkU7n+vG/hIqmyUDsxyHfRrOsUfIrnggnvG0zqF+0VOK8qnuThPpRJzeeS+wUp8zlFrYX6pK/+Tb9Est3a0LTn+2K5ujm/K859OJS29H4qA2hykAFjWTEXPVqvB4HytEPKR937qaxHyMgeKsTiZjCQV+t0O2AeMO0/6EQnlhdpKPK7mn5dTGZ8DUMyoWIlFRi+CFWRP4sWm08KsP9rGK1T22hwEt6SY4m4CvufD8k7jCHEtYp9kSlhu6CC7eC0Rf1Owfc4JmzOLMGO2WEtP9pYP45QHJ4x35BB6oZhhU4BeMWGd/6d+kaHHe1PQRS7J1qQGo67X7ybUv9+nh5aXZxj2liEXQxomrB49dQ125ytXJEfAvNCy8frxrzKkPEcrRuGhr/BxHGCWIUflJ3Zwk1IGWmzQU/JVqviApWt5v+xCwYq27RRbP7AWKnXc0oL1Jg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6512007)(9686003)(82960400001)(26005)(83380400001)(33716001)(2906002)(38100700002)(508600001)(8936002)(6506007)(86362001)(6666004)(53546011)(6486002)(5660300002)(66556008)(66476007)(66946007)(186003)(54906003)(6916009)(8676002)(316002)(4326008)(85182001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2doZEpTaWxXNVBIbmg3b2FmWElVRWd4QzdiK2d2aXBhNlBTYW1nK3lSaW5t?= =?utf-8?B?RjhsQmZwRkNwUDgyTjE4dlRjWGFYRDVEQmlVdURXZDlJc2V4TDlPLzYvNmQw?= =?utf-8?B?QUZUNUdWaU5NVzFIR1VPYTJMMVlUWUtxcUNuQWJXNjlKVE8xVUlCUVNQMEZG?= =?utf-8?B?czRGM3hiT1pwZDJ0c2g3blFXbmxzSXdPbGNmZnVHUUovQkVuSktSc0VOWW9k?= =?utf-8?B?Vm5qamd5UGhRbGFjVExyd1ZQSE9OOE5wYnhxdjdoOGF4c0h2L01mL2Qyb2Np?= =?utf-8?B?dys3WFZhcEI3VFNpNm9mVTBxM1YrdU5CM0xQWXVKYUpvSTdaKzZyQ0htT3U5?= =?utf-8?B?elBQckMxcjQ1dENUNlkzd29CQXRxLzQ5YnBjandFNjVLTCtIOWVraEpVM0VX?= =?utf-8?B?WUVVQnpMejV6MVozVlFrbnorSmVzMlpuN25WbjNWU0paOVBVVUZrTzg0bkM2?= =?utf-8?B?a3pwVjJCcnBVQ3FLUWFyOFY0QjhUTm1aTzNtUk5OVjlyVlEybTNkRnhjUnlL?= =?utf-8?B?SjJub2EvcThXTHduTVFiNWNnd0pYdWQxSkpxNWJpeVdqSlA0ZmRnelhMMVk0?= =?utf-8?B?QnAxcHl1L0ZINktxcEc5MzZaR3ExU3hycVBXVFdhcFBMZGxvTUd2UzgvQTJo?= =?utf-8?B?WHBLU0hXeTlsa0FtYnlqb3lVK0lOOEVZSVZUeHRGM2Y5dGFkVTdRdTNpNld4?= =?utf-8?B?L2lwVTNDQW1jVEhBR0ovY3B3dFUwcHFNWEhiT3lBWE8yYk0reVp2bndhV20w?= =?utf-8?B?Y1dMTDlXZnppWEc1eFhFSkpUMFRWT3Jua2toeStqMEFuK21HNGtwWENWREh3?= =?utf-8?B?T3JDMUFJZFdnbnRadmlFaHl4SGRsR2pnb0t4b0FqQnVqdzhDaGpodWxvdkNs?= =?utf-8?B?Ui9jajhiK1dpWUxnZGw4R1BWcFFlbzRKT1hnalNwMnkvd1EzM05JdjdFcFdT?= =?utf-8?B?a2s3V2VkRGp5b2NSU1k5QkUrRC9sL0hRbHNsY1oxRTFxZHdIYXRBZC92Z3pk?= =?utf-8?B?UUtuT1kydGJpTHZTcTRWaDZueFRVcE4wTGlpRVpSams1bW5MdWVQeGNaQTBU?= =?utf-8?B?YjhoRjZQWFF5UjBzZFJOdEZyOVR6Z3k0OU5CQnEvMzVIdm5tdlVQVGh0elZG?= =?utf-8?B?dmZvUFIydGRDMm5vMlUwSmcyTERibkpxMTIvbERROURjci80aVhFVGRuQ0Fy?= =?utf-8?B?blJZY1NRLzExbXZKNnVaS04vRklxaG9ldlovR1Nmei9VTFEwM21BaTU0QXlq?= =?utf-8?B?UmJKd0lKUS9rbXNlM0dwR2Y5ZFVQeFFtUThHTVVzaUtQci9hM0xIT05Zb0pj?= =?utf-8?B?QnhQSXVFVjJwM0xtU3kyNjExWUV0bFprc0RXWGJnMEM5U2Q1eEIrTVE5cTB2?= =?utf-8?B?K2l2dEZhZWFLWUhnTDZkQWE4UE5MWWpqeTQxbWNjMEQyS2h5SmtUMjcxNzFR?= =?utf-8?B?ZU1wend1eG11blR1Sk1rbHhQbnhDSE5YRFRIUmdQWEZlU2JBeHVmbTB6ekc2?= =?utf-8?B?cXdWWUxvMHJWa2l2aEtvSEFYOG8wVTU2b0l2WE5BczcrYnlGWkdhZkRkd043?= =?utf-8?B?dEd6b0VhS0E3ZmRLaC8xd3ZSNXVMREJjWWdTVWppc2s1OHZML1VzaU1LUUdm?= =?utf-8?B?WlN3QUNMR3VwcW9NUjk1MURISTgyeVoxc1ExaTFSRWlKd2NwbEN3Sk1WQW5U?= =?utf-8?B?VE1KZ3VGQ0NvYTJTZjN0a3hHOEhIc0lTTzZ0ektDSC94Tm5Cek9BTCsrcjc5?= =?utf-8?B?OXBPdDAza2svS1dqTWxOZTdzUE5xUVNSVXlYNUVuUGxyeVJ2VU9ReXg1SnI1?= =?utf-8?B?d3hTL3VJWkJYYVlGY2xhZUpuUFh1Sjcwa3kwMnJST2dUMUM4NE9mZm0wMFQ3?= =?utf-8?B?eTYvUi9yQUpUUWl1dEQ4SEhjVXYvenJIcmJpUFpQSm5vV0RDNlpycWY2Y0JX?= =?utf-8?B?U0JLUTUycUhCWGQ1VE10dzlUWkthemxqVkppOVMxbExxTkVCaEZQRXh1MTJm?= =?utf-8?B?NWhZQXhiVUZ2dG9EQnJEWmRhMUk2d3Jsd3E4a3NOMnJwaUpST0prK041SXIv?= =?utf-8?B?Q3dHUDRCWlErdWhxUXZFTzRGd1hNd1JSNGpPcTkrSlQ0R1lxckxibWJCOUtQ?= =?utf-8?B?RFhzcXlySmIveVU3Rm5aTk01SzZXb3ZjL1A1SUdaLzkyMEM4K0tiL2RodDhY?= =?utf-8?B?WlNRdW1uQlBKZFh0ZXQxY0o0QURLTXJTQUxjTU8wemVWQ2FzcUpWOGdhamdB?= =?utf-8?B?VXppTi91RDgvbm9RRmM0NlhBVEM0dDkwalRJdk9Ob0JOQkRGMEtMQ0NxTEsx?= =?utf-8?B?UHVadEJQUWdBMUFZWXJmYVB0QXhqeE9QMWtURzlKQS9uZm9VK3RSMTNTZmwy?= =?utf-8?Q?ZkEa3n9G38ceBklA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3099a40f-c462-444b-79a3-08da2de1daec X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 15:22:09.1887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wv7o+y7RvWIjGjooKN2OkHzMjefgqU3FmXdRC/0f/aOC3njp+qg6D2u40LrSlPtU5bxcsEQ5jpIOCYCEoqlf3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3512 On Wed, May 04, 2022 at 03:55:09PM +0200, Jan Beulich wrote: > On 04.05.2022 15:46, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 03:19:16PM +0200, Jan Beulich wrote: > >> On 04.05.2022 15:00, Roger Pau Monné wrote: > >>> On Wed, May 04, 2022 at 02:12:58PM +0200, Jan Beulich wrote: > >>>> On 04.05.2022 14:01, Roger Pau Monné wrote: > >>>>> On Wed, May 04, 2022 at 12:51:25PM +0200, Jan Beulich wrote: > >>>>>> On 04.05.2022 12:30, Roger Pau Monné wrote: > >>>>>>> Right, ->iomem_caps is indeed too wide for our purpose. What > >>>>>>> about using something like: > >>>>>>> > >>>>>>> else if ( is_pv_domain(d) ) > >>>>>>> { > >>>>>>> if ( !iomem_access_permitted(d, pfn, pfn) ) > >>>>>>> return 0; > >>>>>> > >>>>>> We can't return 0 here (as RAM pages also make it here when > >>>>>> !iommu_hwdom_strict), so I can at best take this as a vague outline > >>>>>> of what you really mean. And I don't want to rely on RAM pages being > >>>>>> (imo wrongly) represented by set bits in Dom0's iomem_caps. > >>>>> > >>>>> Well, yes, my suggestion was taking into account that ->iomem_caps for > >>>>> dom0 has mostly holes for things that shouldn't be mapped, but > >>>>> otherwise contains everything else as allowed (including RAM). > >>>>> > >>>>> We could instead do: > >>>>> > >>>>> else if ( is_pv_domain(d) && type != RAM_TYPE_CONVENTIONAL ) > >>>>> { > >>>>> ... > >>>>> > >>>>> So that we don't rely on RAM being 'allowed' in ->iomem_caps? > >>>> > >>>> This would feel to me like excess special casing. > >>> > >>> What about placing this in the 'default:' label on the type switch a > >>> bit above? > >> > >> I'd really like to stick to the present layout of where the special > >> casing is done, with PV and PVH logic at least next to each other. I > >> continue to think the construct I suggested (still visible below) > >> would do. > >> > >>>>>>> if ( rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >>>>>>> return IOMMUF_readable; > >>>>>>> } > >>>>>>> > >>>>>>> That would get us a bit closer to allowed CPU side mappings, and we > >>>>>>> don't need to special case IO-APIC or HPET addresses as those are > >>>>>>> already added to ->iomem_caps or mmio_ro_ranges respectively by > >>>>>>> dom0_setup_permissions(). > >>>>>> > >>>>>> This won't fit in a region of code framed by a (split) comment > >>>>>> saying "Check that it doesn't overlap with ...". Hence if anything > >>>>>> I could put something like this further down. Yet even then the > >>>>>> question remains what to do with ranges which pass > >>>>>> iomem_access_permitted() but > >>>>>> - aren't really MMIO, > >>>>>> - are inside MMCFG, > >>>>>> - are otherwise special. > >>>>>> > >>>>>> Or did you perhaps mean to suggest something like > >>>>>> > >>>>>> else if ( is_pv_domain(d) && iomem_access_permitted(d, pfn, pfn) && > >>>>>> rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >>>>>> return IOMMUF_readable; > >>>>> > >>>>> I don't think this would be fully correct, as we would still allow > >>>>> mappings of IO-APIC pages explicitly banned in ->iomem_caps by not > >>>>> handling those? > >>>> > >>>> CPU side mappings don't deal with the IO-APICs specifically. They only > >>>> care about iomem_caps and mmio_ro_ranges. Hence explicitly banned > >>>> IO-APIC pages cannot be mapped there either. (Of course we only do > >>>> such banning if IO-APIC pages weren't possible to represent in > >>>> mmio_ro_ranges, which should effectively be never.) > >>> > >>> I think I haven't expressed myself correctly. > >>> > >>> This construct won't return 0 for pfns not in iomem_caps, and hence > >>> could allow mapping of addresses not in iomem_caps? > >> > >> I'm afraid I don't understand: There's an iomem_access_permitted() > >> in the conditional. How would this allow mapping pages outside of > >> iomem_caps? The default case higher up has already forced perms to > >> zero for any non-RAM page (unless iommu_hwdom_inclusive). > > > > It was my understanding that when using iommu_hwdom_inclusive (or > > iommu_hwdom_reserved if the IO-APIC page is a reserved region) we > > still want to deny access to the IO-APIC page if it's not in > > iomem_caps, and the proposed conditional won't do that. > > > > So I guess the discussion is really whether > > iommu_hwdom_{inclusive,reserved} take precedence over ->iomem_caps? > > I think the intended interaction is not spelled out anywhere. I > also think that it is to be expected for such interaction to be > quirky; after all the options themselves are quirks. > > > It seems a bit inconsistent IMO to enforce mmio_ro_ranges but not > > ->iomem_caps when using iommu_hwdom_{inclusive,reserved}. > > In a way, yes. But as said before - it's highly theoretical for > IO-APIC pages to not be in ->iomem_caps (and this case also won't > go silently). My idea was for whatever check we add for PV to also cover HPET, which is in a similar situation (can be either blocked in ->iomem_caps or in mmio_ro_ranges). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 15:34:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:34:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320836.541802 (Exim 4.92) (envelope-from ) id 1nmH0t-0000f4-Kw; Wed, 04 May 2022 15:34:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320836.541802; Wed, 04 May 2022 15:34:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmH0t-0000ex-Hy; Wed, 04 May 2022 15:34:03 +0000 Received: by outflank-mailman (input) for mailman id 320836; Wed, 04 May 2022 15:17:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmGlA-0006RY-Ar for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:17:48 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 592fc22e-cbbd-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 17:17:45 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1480A61BD1; Wed, 4 May 2022 15:17:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 373AAC385A5; Wed, 4 May 2022 15:17:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 592fc22e-cbbd-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651677463; bh=/TElw+eJLqLZJfiH+wgcHcLpwRKNjBsKkGVEQia8krA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r2EKwrBPc+6tZUWBhSzhnQBRbc05hZb7TQkoWLFCHnEdKXJw3pmkGfZGmnrehNIzt w4JzS33+2EMoGBnnb9xtS1/Spopuhywsv347T3+6LyYHbgpE6CtvE0AFq5B7fBqPyX 5MqWaHUdzYaViNaxBlBJK+ptIdjAAYkruP0EWQGDllsuxMmiP7mRJFbecq0YUstgiD RpxbR+x5+dC5Tuv+76tsVvvXax+z+1tbQ0BeM8qtcsvnJHNnSQ0TrXHhc3n1lnDWSu S6G8rlCBvr55hWxhdkIt/elBXUAB3x5zutaGRQmaLr3G+4d2Cx6Eo/yp43Szdk/NKp Cfc4hXpr4p5Ow== Date: Wed, 4 May 2022 16:17:17 +0100 From: Mark Brown To: Kees Cook Cc: "Gustavo A . R . Silva" , Lars-Peter Clausen , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Alexei Starovoitov , Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lee Jones , Leon Romanovsky , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 20/32] ASoC: sigmadsp: Use mem_to_flex_dup() with struct sigmadsp_data Message-ID: Mail-Followup-To: Kees Cook , "Gustavo A . R . Silva" , Lars-Peter Clausen , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Alexei Starovoitov , Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lee Jones , Leon Romanovsky , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-21-keescook@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WsBvT7ldclzXuz86" Content-Disposition: inline In-Reply-To: <20220504014440.3697851-21-keescook@chromium.org> X-Cookie: Mother is the invention of necessity. --WsBvT7ldclzXuz86 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 03, 2022 at 06:44:29PM -0700, Kees Cook wrote: > As part of the work to perform bounds checking on all memcpy() uses, > replace the open-coded a deserialization of bytes out of memory into a > trailing flexible array by using a flex_array.h helper to perform the > allocation, bounds checking, and copying. Acked-by: Mark Brown --WsBvT7ldclzXuz86 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJymP0ACgkQJNaLcl1U h9BOTAf/ZD8yoDRekvioENLYy8dN3NXa5AWr7w113Lw6amX9IH8PkZBk9MuYaDgS lyEL/dF+NQH1EG1pD8OqTodb2FRk6p2BmOqGHZamS0MgHy+d4s7a66k1YkGIKh1O 8m5wnvOKz3Fk2HYUDyLrx+sOQL3a9Pp0Qh1JdRiAsXXyc6GyJwrC5vR/TbFMyfFd yDpPiY/nMzIqHfWGSIhIy2K+Fl9WzSdcTDasOELxcxGPYhdJbxgT/WoRcOTc/5l1 gNGLh0quw//dri/kQ0Y9YwSNbjiZjy/ZPVbQ2WxIGlmhcmbavI9j6S4iDwgZzTpY B0dknkr+kOxX7zlsqhHYQ6guFBtrCw== =XAoD -----END PGP SIGNATURE----- --WsBvT7ldclzXuz86-- From xen-devel-bounces@lists.xenproject.org Wed May 04 15:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320861.541819 (Exim 4.92) (envelope-from ) id 1nmHEH-0002La-1c; Wed, 04 May 2022 15:47:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320861.541819; Wed, 04 May 2022 15:47:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHEG-0002LT-U3; Wed, 04 May 2022 15:47:52 +0000 Received: by outflank-mailman (input) for mailman id 320861; Wed, 04 May 2022 15:38:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmH50-0001L8-5N for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:38:18 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36f89b46-cbc0-11ec-a406-831a346695d4; Wed, 04 May 2022 17:38:16 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id j6so1408490pfe.13 for ; Wed, 04 May 2022 08:38:16 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id bm16-20020a056a00321000b0050dc76281a0sm1144893pfb.122.2022.05.04.08.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 08:38:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f89b46-cbc0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KqAJb/V6gfBBDG6bSPIb4vESmdq1P/sKe2F177CTgUM=; b=fQrMYNAIqMyggez1Cxk6MO5ffmDcMsHa95ZyVgeB+XLocHYSpcdXLdDMIvfhtVHebJ c6KLuD9O1zHpfXOArUQ9i6OPKZN0wLEdS36xK8UGnJ7GhAZoY1ZaUI/INEIjt/aYGDme 7yPqIKR/2ePc228VdQYx3R6Gd7ox0JMkE5pTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KqAJb/V6gfBBDG6bSPIb4vESmdq1P/sKe2F177CTgUM=; b=v6LRtTLznbgcj3mzaOa4py1sIX+892jBLw4qZz9G5a8Mdiy9mV17rbNZo20U2sEOzu eADp+cmcQxqnmKPK+4uC1avaljrE2NJ1IpU8daPh+Xo2TtDWbUcLucn1MP2V9aIbquA4 2pn1YVs6fFbfsf9S4sUtoehOp1IPVdY3j8tsSKJRKbIyWxMg8Uud34h7wIgV03nLtRK7 WUKWHZYhQ0eVRApUK3HasUxRSl7m9Gw0BsQY0xdMt8pN8BxnflTdSqw1ZerpQ3FJpZ6+ PkSuA6SdOt4961jyW7osjVijF7f1HGLEUpRMnboa5/VvyAmFS2Nxz9rD4eCAU5rf8Krl eJVA== X-Gm-Message-State: AOAM533KbJR1LdGZzHwzG8mlFf+l7W3goWOY1t4CQ2GxjWRFRg4mhFoH heqkzZ4+jV17UIYEjBd3rCGnuw== X-Google-Smtp-Source: ABdhPJwBmZJ9wb0LzywgcJVjfOXV8uAsCTwjDfuLOerjn5Pxz0fuB6CwDGapDJ7lr8xm5AQuNXIQuw== X-Received: by 2002:a63:88c8:0:b0:3ab:1871:13b4 with SMTP id l191-20020a6388c8000000b003ab187113b4mr18710813pgd.85.1651678695070; Wed, 04 May 2022 08:38:15 -0700 (PDT) Date: Wed, 4 May 2022 08:38:13 -0700 From: Kees Cook To: Johannes Berg Cc: "Gustavo A . R . Silva" , Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Message-ID: <202205040819.DEA70BD@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 04, 2022 at 09:25:56AM +0200, Johannes Berg wrote: > On Tue, 2022-05-03 at 18:44 -0700, Kees Cook wrote: > > > > For example, using the most complicated helper, mem_to_flex_dup(): > > > > /* Flexible array struct with members identified. */ > > struct something { > > int mode; > > DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(int, how_many); > > unsigned long flags; > > DECLARE_FLEX_ARRAY_ELEMENTS(u32, value); > > In many cases, the order of the elements doesn't really matter, so maybe > it'd be nicer to be able to write it as something like > > DECLARE_FLEX_STRUCT(something, > int mode; > unsigned long flags; > , > int, how_many, > u32, value); > > perhaps? OK, that doesn't seem so nice either. > > Maybe > > struct something { > int mode; > unsigned long flags; > FLEX_ARRAY( > int, how_many, > u32, value > ); > }; Yeah, I mention some of my exploration of this idea in the sibling reply: https://lore.kernel.org/linux-hardening/202205040730.161645EC@keescook/#t It seemed like requiring a structure be rearranged to take advantage of the "automatic layout introspection" wasn't very friendly. On the other hand, looking at the examples, most of them are already neighboring members. Hmmm. > or so? The long and duplicated DECLARE_FLEX_ARRAY_ELEMENTS_COUNT and > DECLARE_FLEX_ARRAY_ELEMENTS seems a bit tedious to me, at least in cases > where the struct layout is not the most important thing (or it's already > at the end anyway). The names aren't great, but I wanted to distinguish "elements" as the array not the count. Yay naming. However, perhaps the solution is to have _both_. i.e using BOUNDED_FLEX_ARRAY(count_type, count_name, array_type, array_name) for the "neighboring" case, and the DECLARE...{ELEMENTS,COUNT} for the "split" case. And DECLARE_FLEX_ARRAY_ELEMENTS could actually be expanded to include the count_name too, so both methods could be "forward portable" to a future where C grew the syntax for bounded flex arrays. > > > struct something *instance = NULL; > > int rc; > > > > rc = mem_to_flex_dup(&instance, byte_array, count, GFP_KERNEL); > > if (rc) > > return rc; > > This seems rather awkward, having to set it to NULL, then checking rc > (and possibly needing a separate variable for it), etc. I think the errno return is completely required. I had an earlier version of this that was much more like a drop-in replacement for memcpy that would just truncate or panic, and when I had it all together, I could just imagine hearing Linus telling me to start over because it was unsafe (truncation may be just as bad as overflow) and disruptive ("never BUG"), and that it should be recoverable. So, I rewrote it all to return a __must_check errno. Requiring instance to be NULL is debatable, but I feel pretty strongly about it because it does handle a class of mistakes (resource leaks), and it's not much of a burden to require a known-good starting state. > But I can understand how you arrived at this: > - need to pass instance or &instance or such for typeof() > or offsetof() or such Right. > - instance = mem_to_flex_dup(instance, ...) > looks too much like it would actually dup 'instance', rather than > 'byte_array' And I need an errno output to keep imaginary Linus happy. :) > - if you pass &instance anyway, checking for NULL is simple and adds a > bit of safety Right. > but still, honestly, I don't like it. As APIs go, it feels a bit > cumbersome and awkward to use, and you really need everyone to use this, > and not say "uh what, I'll memcpy() instead". Sure, and I have tried to get it down as small as possible. The earlier "just put all the member names in every call" version was horrid. :P I realize it's more work to check errno, but the memcpy() API we've all been trained to use is just plain dangerous. I don't think it's unreasonable to ask people to retrain themselves to avoid it. All that said, yes, I want it to be as friendly as possible. > Maybe there should also be a realloc() version of it? Sure! Seems reasonable. I'd like to see the code pattern for this though. Do you have any examples? Most of what I'd been able to find for the fragile memcpy() usage was just basic serialize/deserialize or direct copying. > > +/** __fas_bytes - Calculate potential size of flexible array structure > > I think you forgot "\n *" in many cases here after "/**". Oops! Yes, thank you. I'll fix these. -Kees -- Kees Cook From xen-devel-bounces@lists.xenproject.org Wed May 04 15:57:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320870.541836 (Exim 4.92) (envelope-from ) id 1nmHNG-0003wh-1i; Wed, 04 May 2022 15:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320870.541836; Wed, 04 May 2022 15:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNF-0003wa-U2; Wed, 04 May 2022 15:57:09 +0000 Received: by outflank-mailman (input) for mailman id 320870; Wed, 04 May 2022 15:57:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNE-0003wP-EV for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:57:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d93f5fd2-cbc2-11ec-a406-831a346695d4; Wed, 04 May 2022 17:57:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A53991F74B; Wed, 4 May 2022 15:57:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 04953132C4; Wed, 4 May 2022 15:57:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XfVKO1GicmLWPAAAMHmgww (envelope-from ); Wed, 04 May 2022 15:57:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d93f5fd2-cbc2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651679826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hG7emcEGn0sS81RKfZEcY3mzY1AE7PXlwENEP7suGv0=; b=g4wY94mvZyO+V+p1H2CBHhX6rOIEgjn6VJaUzqhOuZaZX7Z5w3dZMNr2IaH2+kGxfqve9X r9KOXvqVpM9FnKRs3k6i4MC+Iqp/CQTkqEI1FyzTVZqXo58XoBlTfaY4/FeC40jLvdkqw2 cmdfELH/dDTQoTEyFXNI3PahwVKzzWM= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: [PATCH v3 0/2] kernel: add new infrastructure for platform_has() support Date: Wed, 4 May 2022 17:57:01 +0200 Message-Id: <20220504155703.13336-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In another patch series [1] the need has come up to have support for a generic feature flag infrastructure. This patch series is introducing that infrastructure and adds the first use case. I have decided to use a similar interface as the already known x86 cpu_has() function. As the new infrastructure is meant to be usable for general and arch-specific feature flags, the flags are being spread between a general bitmap and an arch specific one. The bitmaps start all being zero, single features can be set or reset at any time by using the related platform_[re]set_feature() functions. The platform_has() function is using a simple test_bit() call for now, further optimization might be added when needed. [1]: https://lore.kernel.org/lkml/1650646263-22047-1-git-send-email-olekstysh@gmail.com/T/#t Juergen Gross (2): kernel: add platform_has() infrastructure virtio: replace arch_has_restricted_virtio_memory_access() MAINTAINERS | 8 ++++++++ arch/s390/Kconfig | 1 - arch/s390/mm/init.c | 13 +++---------- arch/x86/Kconfig | 1 - arch/x86/mm/mem_encrypt.c | 7 ------- arch/x86/mm/mem_encrypt_amd.c | 4 ++++ drivers/virtio/Kconfig | 6 ------ drivers/virtio/virtio.c | 5 ++--- include/asm-generic/Kbuild | 1 + include/asm-generic/platform-feature.h | 8 ++++++++ include/linux/platform-feature.h | 19 ++++++++++++++++++ include/linux/virtio_config.h | 9 --------- kernel/Makefile | 2 +- kernel/platform-feature.c | 27 ++++++++++++++++++++++++++ 14 files changed, 73 insertions(+), 38 deletions(-) create mode 100644 include/asm-generic/platform-feature.h create mode 100644 include/linux/platform-feature.h create mode 100644 kernel/platform-feature.c -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed May 04 15:57:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320872.541852 (Exim 4.92) (envelope-from ) id 1nmHNH-0004Fu-Pp; Wed, 04 May 2022 15:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320872.541852; Wed, 04 May 2022 15:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNH-0004EZ-IY; Wed, 04 May 2022 15:57:11 +0000 Received: by outflank-mailman (input) for mailman id 320872; Wed, 04 May 2022 15:57:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNG-0003wP-72 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:57:10 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9ea31e3-cbc2-11ec-a406-831a346695d4; Wed, 04 May 2022 17:57:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 020191F74C; Wed, 4 May 2022 15:57:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 632F013AFD; Wed, 4 May 2022 15:57:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WNXUFlOicmLWPAAAMHmgww (envelope-from ); Wed, 04 May 2022 15:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9ea31e3-cbc2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651679828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0lMxpONprAdpQbV0uZskDbB1fEIP7YYHFmYdwzZhDVE=; b=FZxi5C4az6xiRDRt5zrq3DDmodZF2oavjNsJxai9hYEooOypl2qGaNwDnpiy9Tx+vC7rtJ 6VsX/43rtog5GY2zI9yxWTXDz0XrgLb2dS1b5YOdmVOPtV5uJQwTW4VSx39BlUI2CPd3R6 9okDcBlH2MvPKcdeiIkPEin/HR4d5xc= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access() Date: Wed, 4 May 2022 17:57:03 +0200 Message-Id: <20220504155703.13336-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220504155703.13336-1-jgross@suse.com> References: <20220504155703.13336-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using arch_has_restricted_virtio_memory_access() together with CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, replace those with platform_has() and a new platform feature PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS. Signed-off-by: Juergen Gross --- V2: - move setting of PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS in SEV case to sev_setup_arch(). V3: - remove Hyper-V chunk (Michael Kelley) - remove include virtio_config.h from mem_encrypt.c (Oleksandr Tyshchenko) - add comment for PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS (Oleksandr Tyshchenko) --- arch/s390/Kconfig | 1 - arch/s390/mm/init.c | 13 +++---------- arch/x86/Kconfig | 1 - arch/x86/mm/mem_encrypt.c | 7 ------- arch/x86/mm/mem_encrypt_amd.c | 4 ++++ drivers/virtio/Kconfig | 6 ------ drivers/virtio/virtio.c | 5 ++--- include/linux/platform-feature.h | 6 +++++- include/linux/virtio_config.h | 9 --------- 9 files changed, 14 insertions(+), 38 deletions(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index e084c72104f8..f97a22ae69a8 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -772,7 +772,6 @@ menu "Virtualization" config PROTECTED_VIRTUALIZATION_GUEST def_bool n prompt "Protected virtualization guest support" - select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS help Select this option, if you want to be able to run this kernel as a protected virtualization KVM guest. diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c index 86ffd0d51fd5..2c3b451813ed 100644 --- a/arch/s390/mm/init.c +++ b/arch/s390/mm/init.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -168,22 +169,14 @@ bool force_dma_unencrypted(struct device *dev) return is_prot_virt_guest(); } -#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS - -int arch_has_restricted_virtio_memory_access(void) -{ - return is_prot_virt_guest(); -} -EXPORT_SYMBOL(arch_has_restricted_virtio_memory_access); - -#endif - /* protected virtualization */ static void pv_init(void) { if (!is_prot_virt_guest()) return; + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); + /* make sure bounce buffers are shared */ swiotlb_force = SWIOTLB_FORCE; swiotlb_init(1); diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 4bed3abf444d..eeb7c6c8eec5 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1515,7 +1515,6 @@ config X86_CPA_STATISTICS config X86_MEM_ENCRYPT select ARCH_HAS_FORCE_DMA_UNENCRYPTED select DYNAMIC_PHYSICAL_MASK - select ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS def_bool n config AMD_MEM_ENCRYPT diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c index 50d209939c66..18a55a0f1ca2 100644 --- a/arch/x86/mm/mem_encrypt.c +++ b/arch/x86/mm/mem_encrypt.c @@ -12,7 +12,6 @@ #include #include #include -#include /* Override for DMA direct allocation check - ARCH_HAS_FORCE_DMA_UNENCRYPTED */ bool force_dma_unencrypted(struct device *dev) @@ -76,9 +75,3 @@ void __init mem_encrypt_init(void) print_mem_encrypt_feature_info(); } - -int arch_has_restricted_virtio_memory_access(void) -{ - return cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT); -} -EXPORT_SYMBOL_GPL(arch_has_restricted_virtio_memory_access); diff --git a/arch/x86/mm/mem_encrypt_amd.c b/arch/x86/mm/mem_encrypt_amd.c index 6169053c2854..39b71084d36b 100644 --- a/arch/x86/mm/mem_encrypt_amd.c +++ b/arch/x86/mm/mem_encrypt_amd.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -206,6 +207,9 @@ void __init sev_setup_arch(void) size = total_mem * 6 / 100; size = clamp_val(size, IO_TLB_DEFAULT_SIZE, SZ_1G); swiotlb_adjust_size(size); + + /* Set restricted memory access for virtio. */ + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); } static unsigned long pg_level_to_pfn(int level, pte_t *kpte, pgprot_t *ret_prot) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index b5adf6abd241..a6dc8b5846fe 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -6,12 +6,6 @@ config VIRTIO bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG or CONFIG_S390_GUEST. -config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS - bool - help - This option is selected if the architecture may need to enforce - VIRTIO_F_ACCESS_PLATFORM - config VIRTIO_PCI_LIB tristate help diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 22f15f444f75..371e16b18381 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -5,6 +5,7 @@ #include #include #include +#include #include /* Unique numbering for virtio devices. */ @@ -170,12 +171,10 @@ EXPORT_SYMBOL_GPL(virtio_add_status); static int virtio_features_ok(struct virtio_device *dev) { unsigned status; - int ret; might_sleep(); - ret = arch_has_restricted_virtio_memory_access(); - if (ret) { + if (platform_has(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS)) { if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) { dev_warn(&dev->dev, "device must provide VIRTIO_F_VERSION_1\n"); diff --git a/include/linux/platform-feature.h b/include/linux/platform-feature.h index 6ed859928b97..b2f48be999fa 100644 --- a/include/linux/platform-feature.h +++ b/include/linux/platform-feature.h @@ -6,7 +6,11 @@ #include /* The platform features are starting with the architecture specific ones. */ -#define PLATFORM_FEAT_N (0 + PLATFORM_ARCH_FEAT_N) + +/* Used to enable platform specific DMA handling for virtio devices. */ +#define PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS (0 + PLATFORM_ARCH_FEAT_N) + +#define PLATFORM_FEAT_N (1 + PLATFORM_ARCH_FEAT_N) void platform_set(unsigned int feature); void platform_clear(unsigned int feature); diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index b341dd62aa4d..79498298519d 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -559,13 +559,4 @@ static inline void virtio_cwrite64(struct virtio_device *vdev, _r; \ }) -#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS -int arch_has_restricted_virtio_memory_access(void); -#else -static inline int arch_has_restricted_virtio_memory_access(void) -{ - return 0; -} -#endif /* CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS */ - #endif /* _LINUX_VIRTIO_CONFIG_H */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed May 04 15:57:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320871.541847 (Exim 4.92) (envelope-from ) id 1nmHNH-0004Cc-DV; Wed, 04 May 2022 15:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320871.541847; Wed, 04 May 2022 15:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNH-0004CV-9h; Wed, 04 May 2022 15:57:11 +0000 Received: by outflank-mailman (input) for mailman id 320871; Wed, 04 May 2022 15:57:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNF-0003wP-6r for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:57:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d98c4a11-cbc2-11ec-a406-831a346695d4; Wed, 04 May 2022 17:57:07 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 641FE210E1; Wed, 4 May 2022 15:57:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF262132C4; Wed, 4 May 2022 15:57:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GLt2KVKicmLWPAAAMHmgww (envelope-from ); Wed, 04 May 2022 15:57:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d98c4a11-cbc2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651679827; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nu4FNczpZovRCMLybZ5k5rdDCEUYi3yOv4DX+sivCNc=; b=YaaUVhSRP5GfOdY2LJNhrw0zcyHIdbiTMz0zj9Uc7X0cg8wRTltA+1tJX8+n+pE3HmN/96 GCQ4MBEVKbCBpzNefZPdi8vvKmVmniACzN6LXAmRJGwENURN4ArHLM2iHP3MAqfwFoO41q WQJiMyj03IXIYJcUR850l7JEgifK4ZA= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: [PATCH v3 1/2] kernel: add platform_has() infrastructure Date: Wed, 4 May 2022 17:57:02 +0200 Message-Id: <20220504155703.13336-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220504155703.13336-1-jgross@suse.com> References: <20220504155703.13336-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a simple infrastructure for setting, resetting and querying platform feature flags. Flags can be either global or architecture specific. Signed-off-by: Juergen Gross --- V2: - rename set/reset functions to platform_[set|clear]() (Boris Petkov, Heiko Carstens) - move function implementations to c file (Boris Petkov) --- MAINTAINERS | 8 ++++++++ include/asm-generic/Kbuild | 1 + include/asm-generic/platform-feature.h | 8 ++++++++ include/linux/platform-feature.h | 15 ++++++++++++++ kernel/Makefile | 2 +- kernel/platform-feature.c | 27 ++++++++++++++++++++++++++ 6 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 include/asm-generic/platform-feature.h create mode 100644 include/linux/platform-feature.h create mode 100644 kernel/platform-feature.c diff --git a/MAINTAINERS b/MAINTAINERS index edc96cdb85e8..2749a88d75f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15657,6 +15657,14 @@ S: Maintained F: Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.yaml F: drivers/iio/chemical/pms7003.c +PLATFORM FEATURE INFRASTRUCTURE +M: Juergen Gross +S: Maintained +F: arch/*/include/asm/platform-feature.h +F: include/asm-generic/platform-feature.h +F: include/linux/platform-feature.h +F: kernel/platform-feature.c + PLDMFW LIBRARY M: Jacob Keller S: Maintained diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild index 302506bbc2a4..8e47d483b524 100644 --- a/include/asm-generic/Kbuild +++ b/include/asm-generic/Kbuild @@ -44,6 +44,7 @@ mandatory-y += msi.h mandatory-y += pci.h mandatory-y += percpu.h mandatory-y += pgalloc.h +mandatory-y += platform-feature.h mandatory-y += preempt.h mandatory-y += rwonce.h mandatory-y += sections.h diff --git a/include/asm-generic/platform-feature.h b/include/asm-generic/platform-feature.h new file mode 100644 index 000000000000..4b0af3d51588 --- /dev/null +++ b/include/asm-generic/platform-feature.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_GENERIC_PLATFORM_FEATURE_H +#define _ASM_GENERIC_PLATFORM_FEATURE_H + +/* Number of arch specific feature flags. */ +#define PLATFORM_ARCH_FEAT_N 0 + +#endif /* _ASM_GENERIC_PLATFORM_FEATURE_H */ diff --git a/include/linux/platform-feature.h b/include/linux/platform-feature.h new file mode 100644 index 000000000000..6ed859928b97 --- /dev/null +++ b/include/linux/platform-feature.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _PLATFORM_FEATURE_H +#define _PLATFORM_FEATURE_H + +#include +#include + +/* The platform features are starting with the architecture specific ones. */ +#define PLATFORM_FEAT_N (0 + PLATFORM_ARCH_FEAT_N) + +void platform_set(unsigned int feature); +void platform_clear(unsigned int feature); +bool platform_has(unsigned int feature); + +#endif /* _PLATFORM_FEATURE_H */ diff --git a/kernel/Makefile b/kernel/Makefile index 847a82bfe0e3..2f412f80110d 100644 --- a/kernel/Makefile +++ b/kernel/Makefile @@ -7,7 +7,7 @@ obj-y = fork.o exec_domain.o panic.o \ cpu.o exit.o softirq.o resource.o \ sysctl.o capability.o ptrace.o user.o \ signal.o sys.o umh.o workqueue.o pid.o task_work.o \ - extable.o params.o \ + extable.o params.o platform-feature.o \ kthread.o sys_ni.o nsproxy.o \ notifier.o ksysfs.o cred.o reboot.o \ async.o range.o smpboot.o ucount.o regset.o diff --git a/kernel/platform-feature.c b/kernel/platform-feature.c new file mode 100644 index 000000000000..cb6a6c3e4fed --- /dev/null +++ b/kernel/platform-feature.c @@ -0,0 +1,27 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include +#include +#include +#include + +#define PLATFORM_FEAT_ARRAY_SZ BITS_TO_LONGS(PLATFORM_FEAT_N) +static unsigned long __read_mostly platform_features[PLATFORM_FEAT_ARRAY_SZ]; + +void platform_set(unsigned int feature) +{ + set_bit(feature, platform_features); +} +EXPORT_SYMBOL_GPL(platform_set); + +void platform_clear(unsigned int feature) +{ + clear_bit(feature, platform_features); +} +EXPORT_SYMBOL_GPL(platform_clear); + +bool platform_has(unsigned int feature) +{ + return test_bit(feature, platform_features); +} +EXPORT_SYMBOL_GPL(platform_has); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed May 04 15:57:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 15:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320882.541869 (Exim 4.92) (envelope-from ) id 1nmHNk-0005Ul-VH; Wed, 04 May 2022 15:57:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320882.541869; Wed, 04 May 2022 15:57:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNk-0005Ue-S1; Wed, 04 May 2022 15:57:40 +0000 Received: by outflank-mailman (input) for mailman id 320882; Wed, 04 May 2022 15:57:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHNj-0004qP-7r for xen-devel@lists.xenproject.org; Wed, 04 May 2022 15:57:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eaed3aa2-cbc2-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 17:57:38 +0200 (CEST) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 May 2022 11:57:35 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3143.namprd03.prod.outlook.com (2603:10b6:910:53::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Wed, 4 May 2022 15:57:16 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 15:57:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaed3aa2-cbc2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651679858; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/IXhLhDt0E9eeUcwEbn5PpCRkH1HoUzBsCIQ4h0GWmw=; b=aV26xk8TaeI0hQT3G+2RBNcjO8DiRmCBE2U6+veJi97Fe8Zd7nZ2mHbG Br92cq7SKrhpazGUIl+n8XvzB1Ksk+BFdXwwKkYmwFCJ8gNSi5EBYWRvU SCYVSm63kKZpUByydead68QvaZHbjTAiSTCNgollbxXkMYCvls9xV04gX U=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 70567504 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0EJejqkxgxmHcrky9tmsdF7o5gz3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWC2GBbqmONDP1e9AgO4/j80lSuZDRyt9rTgpk/3w0EyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW1/V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYUiYMMovsluAkSAh2NA1cPfB5opHVCC3q2SCT5xWun3rE5dxLVRtzF6tIv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBg2hYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8A/L+vdvvwA/yiQv3eC8D/z6I+ayXMMMhHTC4 UHI7WrAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUHBBqlz6PV50OTADgCRzsYMtg+7pZpGnoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1LUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:pzn0KqvtAHe4Xg3x9zqT15pD7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.91,198,1647316800"; d="scan'208";a="70567504" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkeQO4+Dy5RtLiXPr8TW6iFLFCuVSxJKYpAVMAQv3vrbT3dvf1egNKeh34Ua4OZ+Ni5/vf2181eVoNjThXLSDjXxEZVy7gR+3kfwn+WKA/TiBPpeYexQfl65h/aPsr3ClO8BZB0FMYq8xlhX93vxiuNKNxp+cOlvBZRpA2uHe5sGd+mLFN393dAMnVvC5ad6h1ZuOlIWJxaKZ5c93tZRX/c0M02gjGkHqWv7G/JnE9SskwFLZiXkfZcz/PQ4nf5M+Ee5tVI6NKDOUCLlQoZqwZemNo0eOZctmT7NMhpVk4cE2pfLURDQF7ddb2UKioO+T5gTMfVJe5h7F7BVxJNtkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bviXjXfbxHmm9UZDT6v/R+s53wKEUsCNE2+bcKi18OQ=; b=ezOJCpJ92TNu+quIxGP2Pbe1yyGSIATJPhzUuoVBh2OCpSR0awmMyP2ffZKTTXd4FU0hinUCir8bf0L8oNxjpweY9AMvaUcKP0JtylsqYMsj7ua3lkyF2yxgmWAkN4BdHWPQRFXxhkeVHeyMdsxyL/Y6WDDG9R1SfGzPPyvoAd7iVbGh4n8Wmy5dnKVy4Yh6dAnSC2QT9tngSfdkXVSJpFcmiBdP7/3MNkpchq7hCAEyy3sNKBDlBFgvGK+1ozWUegMf36LgMKeHnjKQCRqukHDP5f4B9sE4FWn37MODnYgyY7cZ20mBmkw1bZxIKQgGYuOovF1W7n64L8IgxJ3X3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bviXjXfbxHmm9UZDT6v/R+s53wKEUsCNE2+bcKi18OQ=; b=XFvD32p8UyinAvmTeC83NAUubziA8BaIrJV6/hLw9Goxr6oh8Ejf9uGvAkuxTdSCGAAXxCxi6MTVRw7UNQgEGFOUocl2BH94Jebdykz/q3z75B18vWBhBPrKez4kaosf3/D4/FuFpaVp/iaJaWzvqJKV39x4Nrhz/AsZhLR2W0k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 4 May 2022 17:57:11 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 08/21] AMD/IOMMU: walk trees upon page fault Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR2P264CA0085.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21951acb-ea24-4fbb-ecaa-08da2de6c2f4 X-MS-TrafficTypeDiagnostic: CY4PR03MB3143:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n8aGBsr8id6y+7iNFynoyRwTJhkbiyGCAhcf0SYMp4eeIhJMYe1/LxhDxjyfktCN1hLyL9Gy+u58730yrbL/LXTpoACiNTvWYWgbLkjS2BoAKwfg+dSgF6XDj3u++Rbw99tspDqF4vYdgzKZjHy2KwBSLDesQCACu1jwui8eDfR9mBetEagpgicVKjsL1ehGzF5/ATz8R6HDvnwpHYHzPvsjv2lfbANoZmQ2y+vNAOwpz46AbvHVGjW1a52AjddS0fM2p0mL+zc5YBSvJfoLwF3RY5iFfI7O78k8PIP8E5WuGPRg3R4IJa24MPF3zAT0TV2A5SBJgbMplYaLltCbIEr+gCL9ewzMyRUd90Mx+Je/X3ET3LAtBdT4+Lq+DUj3WXy4EmNjcGY40kEoD6noayNhWRypKDXnHta7tPFERSlaVHA9e+Rdsil1b2OJUWfBg2VIkbgw5/GN+ft6XuC4y6zHPq0W1qViijT5NKYvFMoKuI5VYar4AnJUcTZR7aGzCEqBJAPktrblEn/1jSZ7Hj7gP2FFx98lLciTYpMDm6qcBmWU0Be4a2pVzyeJL4aM9wEgLiai9bKMBHcCg4RWkH8bgVq5IdEAXAZFJsimV8O9Gxy8PYfsH+wpWpNlsSDJWX5MlA21O4nalsPGhWyjgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(4744005)(9686003)(4326008)(508600001)(26005)(5660300002)(66476007)(66946007)(83380400001)(66556008)(85182001)(6916009)(316002)(54906003)(6512007)(33716001)(8676002)(82960400001)(2906002)(8936002)(6486002)(86362001)(38100700002)(6506007)(186003)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHhNeDRJY1dMWnlqZzN0TXhRbGlndGI2UGNEK0JsZXVvU25yWmR2OFh1amhS?= =?utf-8?B?ZjMyRm9lVWs4VjlUaGVHQVpMNGpNNGRXdVVjdDAvQXkveVBwYkJHQXZxRVhG?= =?utf-8?B?ejRkZGVOVmxQNW9wWUgyWEFNZUtrZlVSYlNmcTZuSzlRdDVzLzZpdGhIYnpt?= =?utf-8?B?S1o0ZjladFNGWGVucDh2R0Y5dFhvWFd5dWJ3c3E0SktBZkYxMnBkNTQ1U0xk?= =?utf-8?B?Vll2VDVFTk51SWlGelEra2lYWnFKMHJWT0ZMVHBOTWVLMTA1NExRclU1UFdY?= =?utf-8?B?aWlOdmJlTWdoalliWmtUcEp6clowSWJqNlkyaGFVSEdUSy9KWnBqRWt0WVVR?= =?utf-8?B?YTRHK1dwU081VlV3c2tCdktFZm9NQ09zZTZRSmxFY1d0WHV0dXcvbENlc05K?= =?utf-8?B?UVVEa0Z1cWR5b2NsY0NBNC9rS1JpdUZBNnlTeHhkWlFNd3NNRldJL0ZPemFi?= =?utf-8?B?STVvU3p1UDVWdUVVbUdTek1mSThkNjd5ZjhybW04cXlZRUJnWFVrVmVsYlVw?= =?utf-8?B?bGo0bE1ERmVmZTY4aGxHbXdTVi9hQXF2bXhOd3dzTjQ4K28yUkI0VEwxcFk2?= =?utf-8?B?UjlvZzFsdkdhZlFDc3VhYTl6M1lSaXI1empHei8wSE9ZakhwVVBHdFNrRklz?= =?utf-8?B?amNaME1QQ1pCUWw4b2d4VXByTW5UM0VmajI3U0ZwRExkS3pFdnZweHYwclBQ?= =?utf-8?B?cW5zdVlBb1dkYnRqaHZNNTI1cmFzU1BzcG9ZNUlTZkdoSk83SlpBTjRiMlBB?= =?utf-8?B?RFJjYzJHR3VJeUdIaEtlOEF6b2NQbkpKRmF6N2c3Z1owMWl6VXZBQXN0M0Fm?= =?utf-8?B?NUIvMFZvbDNlWFVqTy9adEE4cTM0SGIrTUVrQzQ5c0FyaXZPZWxpNmZKRGdS?= =?utf-8?B?MUFWSEovaTBQYnJvaWtGSGxsNXBGVndWUFhaNDdQWjNyMFRIcDJGNDRDRyty?= =?utf-8?B?REE1eUpkUW4yOFJ3S1dPalZsVTZ2b2JoZmhBbzQrVWV5S0JVTEtKR1hQSzMv?= =?utf-8?B?cG02b3E0RlExMlBHUXVodFlkd3FxQ0hSRU1JSEs1YUJXTnUrNFdDTGhxRUV0?= =?utf-8?B?aUJ6MkdQdmlxcEFVL1czOXRVcjJObjFjQ1hJVUtvY0VtVlFxVG9DV2wvdnY4?= =?utf-8?B?OC84YlVqRU14RVJ0MzBiRFNUTDYrL0V1VC9wendMNXM5V1NXTHRRRU1xTXNo?= =?utf-8?B?Nm10aTI1a0pXZGlsMElqYndOMVVTYnM1WDRva21XTDQvNEhOSUJoOVhEMzNG?= =?utf-8?B?a0xnY3pVNHhkVmhKM29Sc2RlYnhNUzdybXV5UitCMWRXVWMycEtCMmtvTjR5?= =?utf-8?B?QWtaN3BudStWbU85T1JRN2F4U0UrZ0RuVFlDc3dnS3dHZlNJMWtFNXMwSDZM?= =?utf-8?B?RVpVWGJaMG5HSS9EQnRzNThCSUdseHpOeU1DT1MvRDlBMysrL3BVUjlkMWVm?= =?utf-8?B?TE9LTU5xdmNBUGR0dFI3ZEo3ck1tWWN3bmtqeVo5ZkZPMzlGa1BoWkQ3aXlL?= =?utf-8?B?SE8vT0d3R3BzZEh5UE8raEdEME93cUpBK0wrNGpCMlEwNHRFQXc3TjRUMFBJ?= =?utf-8?B?Q3gwYnZIanpoZVN1S1BhNVN0YTF5RDg4QmZLcitaUVNJem1OT04wTXRMQ3cz?= =?utf-8?B?WGU4Y2RLWmZ2M3ljQ0ZmMGl1ZUN3akN5Z0Z4VDR5R0pFSUcwbWVLV1JETHZH?= =?utf-8?B?M0VENnNkNlMrL0tOWmVPdi9kV1o5dDlnUlQ4WmdFemphb0F3UEdmaW9RSFJX?= =?utf-8?B?MU94djNOVCtMV3JuekhqNUV3K3lOR1Q5c0hsa1d1akYvQ0ZyUWt3ZFE3NkZI?= =?utf-8?B?b2xuOWRldnRTcEN5SFZSUlZMOFBVblVvTG1Za0Rzbm52aWVNRFpwcGNIK3A4?= =?utf-8?B?N2haeU1zOWJrdzV3cTVFRkcxV0QzZU5BaWtBQ094dWxkNEZqTnJjS3JXN09G?= =?utf-8?B?aERad3BUcW01UVdEQjhOTTFKUTlxUzc5S0I5eWhqa0NjSk94L3ZCeDhBb0tS?= =?utf-8?B?YkdMUXdvNFgvUXVPaXNpUEJzaFV2K24vWWJtTjFxck9DYmZLRmt6cWcrdDNu?= =?utf-8?B?alFlOFZvYTdTY0hvM29KWFAzeTNmNzhJeXpaY0w0UWQ3RWRQaUVCcEFuRmw2?= =?utf-8?B?UWFwRjE4U05PcEtReWRKdXRZMVg3R0JockQ5ZWRRaG1yb2pIeWNCbVV4eGlt?= =?utf-8?B?NmRNNTROa2oyN2xhS1ZHWWZHNTFqeTZ2aE1uSml5NFhuaDVBNzgxbVpjWEwz?= =?utf-8?B?bXhBbm55aTk4RGFwOWRaQlBpVjNRV0IwNEJOWGI4SnV1NXlIWTlDVmhPbk9j?= =?utf-8?B?SWVPM3pVTUdMRXlOZlNwVDBUOVAwQmM5OEE2d0h2ZWhna1ZQdEFhL1hmM3Q3?= =?utf-8?Q?dNTu+HHnVmDB/XFM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21951acb-ea24-4fbb-ecaa-08da2de6c2f4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 15:57:16.4624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P0XK614R0OF7RZ8jDgjMMim8uY8TjOW3GS8Yo7hXsMbFI7qo38OUyK+6k6okxBEd5HsA1eU7u/Or2OptRiT1Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3143 On Mon, Apr 25, 2022 at 10:36:42AM +0200, Jan Beulich wrote: > This is to aid diagnosing issues and largely matches VT-d's behavior. > Since I'm adding permissions output here as well, take the opportunity > and also add their displaying to amd_dump_page_table_level(). > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > --- > Note: "largely matches VT-d's behavior" includes the lack of any locking > here. Adding suitable locking may not be that easy, as we'd need > to determine which domain's mapping lock to acquire in addition to > the necessary IOMMU lock (for the device table access), and > whether that domain actually still exists. The latter is because > if we really want to play safe here, imo we also need to account > for the device table to be potentially corrupted / stale. I think that's fine. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 04 16:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 16:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320896.541879 (Exim 4.92) (envelope-from ) id 1nmHYa-0007xy-7f; Wed, 04 May 2022 16:08:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320896.541879; Wed, 04 May 2022 16:08:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHYa-0007xr-4o; Wed, 04 May 2022 16:08:52 +0000 Received: by outflank-mailman (input) for mailman id 320896; Wed, 04 May 2022 16:08:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmHYA-0007x6-1t for xen-devel@lists.xenproject.org; Wed, 04 May 2022 16:08:26 +0000 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d0d3f81-cbc4-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 18:08:24 +0200 (CEST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-304-ZFewZZfvOMewltUmmE4nqg-2; Wed, 04 May 2022 17:08:23 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 4 May 2022 17:08:15 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Wed, 4 May 2022 17:08:15 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d0d3f81-cbc4-11ec-8fc4-03012f2f19d4 X-MC-Unique: ZFewZZfvOMewltUmmE4nqg-2 From: David Laight To: 'Kees Cook' , Johannes Berg CC: "Gustavo A . R . Silva" , Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , "alsa-devel@alsa-project.org" , Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , "Baowen Zheng" , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , "brcm80211-dev-list.pdl@broadcom.com" , Christian Brauner , =?iso-8859-1?Q?Christian_G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , "David Gow" , David Howells , "David S. Miller" , Dennis Dalessandro , "devicetree@vger.kernel.org" , Dexuan Cui , "Dmitry Kasatkin" , Eli Cohen , "Eric Dumazet" , Eric Paris , "Eugeniu Rosca" , Felipe Balbi , Frank Rowand , Franky Lin , "Greg Kroah-Hartman" , Gregory Greenman , Haiyang Zhang , "Hante Meuleman" , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , "keyrings@vger.kernel.org" , "kunit-dev@googlegroups.com" , Kuniyuki Iwashima , "K. Y. Srinivasan" , "Lars-Peter Clausen" , Lee Jones , Leon Romanovsky , Liam Girdwood , "linux1394-devel@lists.sourceforge.net" , "linux-afs@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "linux-hardening@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "llvm@lists.linux.dev" , Loic Poulain , Louis Peens , Luca Coelho , "Luiz Augusto von Dentz" , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , "Max Filippov" , Mimi Zohar , Muchun Song , Nathan Chancellor , "netdev@vger.kernel.org" , Nick Desaulniers , =?iso-8859-1?Q?Nuno_S=E1?= , Paolo Abeni , Paul Moore , "Rich Felker" , Rob Herring , Russell King , "selinux@vger.kernel.org" , "Serge E. Hallyn" , "SHA-cyfmac-dev-list@infineon.com" , Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , "wcn36xx@lists.infradead.org" , Wei Liu , "xen-devel@lists.xenproject.org" , Xiu Jianfeng , "Yang Yingliang" Subject: RE: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Thread-Topic: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Thread-Index: AQHYX80GRJFxZRupFEigWcMQWGiaSK0O4MfQ Date: Wed, 4 May 2022 16:08:15 +0000 Message-ID: References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> In-Reply-To: <202205040819.DEA70BD@keescook> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Kees Cook > Sent: 04 May 2022 16:38 ... > > > struct something *instance =3D NULL; > > > int rc; > > > > > > rc =3D mem_to_flex_dup(&instance, byte_array, count, GFP_KERNEL); > > > if (rc) > > > return rc; > > > > This seems rather awkward, having to set it to NULL, then checking rc > > (and possibly needing a separate variable for it), etc. >=20 > I think the errno return is completely required. I had an earlier version > of this that was much more like a drop-in replacement for memcpy that > would just truncate or panic, and when I had it all together, I could > just imagine hearing Linus telling me to start over because it was unsafe > (truncation may be just as bad as overflow) and disruptive ("never BUG"), > and that it should be recoverable. So, I rewrote it all to return a > __must_check errno. >=20 > Requiring instance to be NULL is debatable, but I feel pretty strongly > about it because it does handle a class of mistakes (resource leaks), > and it's not much of a burden to require a known-good starting state. Why not make it look like malloc() since it seems to be malloc(). That gives a much better calling convention. Passing pointers and integers by reference can generate horrid code. (Mostly because it stops the compiler keeping values in registers.) If you want the type information inside the 'function' use a #define so that the use is: =09mem_to_flex_dup(instance, byte_array, count, GFP_KERNEL); =09if (!instance) =09=09return ... (or use ERR_PTR() etc). =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales) From xen-devel-bounces@lists.xenproject.org Wed May 04 16:53:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 16:53:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320922.541898 (Exim 4.92) (envelope-from ) id 1nmIFW-0005GK-SD; Wed, 04 May 2022 16:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320922.541898; Wed, 04 May 2022 16:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIFW-0005GD-PA; Wed, 04 May 2022 16:53:14 +0000 Received: by outflank-mailman (input) for mailman id 320922; Wed, 04 May 2022 16:53:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIFV-0005G3-JO; Wed, 04 May 2022 16:53:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIFV-0001CR-DR; Wed, 04 May 2022 16:53:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIFV-0006pd-1y; Wed, 04 May 2022 16:53:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmIFV-0007Xs-1V; Wed, 04 May 2022 16:53:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UjcoZFVwMnH26AK51k16DOOom8OBd+TZo4ucHpA7xys=; b=rqrzAyOkgUjSsv0cRNRHtdN9bG /e9rorsBBPK4hfJbBVpC4R66oROC2yNQEUGfXF08WuM6OmtbiKgUoM3atT8p/8bWsok20lDujF26s s+UkzvRPwoIYSeTm81+kJhZF4b+FFu5qNfQ+5Ffs96yE7WUXbLvzF6DYHPPIGkXbssrs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170111: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 16:53:13 +0000 flight 170111 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170111/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 803 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 17:15:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 17:15:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320932.541916 (Exim 4.92) (envelope-from ) id 1nmIaz-0007xV-RJ; Wed, 04 May 2022 17:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320932.541916; Wed, 04 May 2022 17:15:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIaz-0007xO-OP; Wed, 04 May 2022 17:15:25 +0000 Received: by outflank-mailman (input) for mailman id 320932; Wed, 04 May 2022 17:15:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIay-0007xH-Qj for xen-devel@lists.xenproject.org; Wed, 04 May 2022 17:15:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c7f3bf00-cbcd-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 19:15:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26DEE1042; Wed, 4 May 2022 10:15:22 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3644B3FA27; Wed, 4 May 2022 10:15:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7f3bf00-cbcd-11ec-8fc4-03012f2f19d4 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2] arm/its: enable LPIs before mapping the collection table Date: Wed, 4 May 2022 18:15:12 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When Xen boots on the platform that implements the GIC 600, ITS MAPC_LPI_OFF uncorrectable command error issue is observed. As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can be reported if the MAPC command has tried to map a collection to a core that does not have LPIs enabled. The definition of GICR.EnableLPIs also suggests enabling the LPIs before sending any ITS command that involves LPIs 0b0 LPI support is disabled. Any doorbell interrupt generated as a result of a write to a virtual LPI register must be discarded, and any ITS translation requests or commands involving LPIs in this Redistributor are ignored. 0b1 LPI support is enabled. To fix the MAPC command error issue, enable the LPIs using GICR_CTLR.EnableLPIs before mapping the collection table. gicv3_enable_lpis() is using writel_relaxed(), write to the GICR_CTLR register may not be visible before gicv3_its_setup_collection() send the MAPC command. Use wmb() after writel_relaxed() to make sure register write to enable LPIs is visible. Signed-off-by: Rahul Singh --- v2 changes: - Add more info about issue in commit msg and specification details. - Use wmb() after writel_relaxed() to make sure register write to enable LPIs is visible --- xen/arch/arm/gic-v3.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 3c472ed768..64b36cec25 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -696,6 +696,9 @@ static bool gicv3_enable_lpis(void) val = readl_relaxed(GICD_RDIST_BASE + GICR_CTLR); writel_relaxed(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR); + /* Make sure the GIC has seen the above */ + wmb(); + return true; } @@ -812,11 +815,11 @@ static int gicv3_cpu_init(void) /* If the host has any ITSes, enable LPIs now. */ if ( gicv3_its_host_has_its() ) { + if ( !gicv3_enable_lpis() ) + return -EBUSY; ret = gicv3_its_setup_collection(smp_processor_id()); if ( ret ) return ret; - if ( !gicv3_enable_lpis() ) - return -EBUSY; } /* Set priority on PPI and SGI interrupts */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 04 17:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 17:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320950.541931 (Exim 4.92) (envelope-from ) id 1nmItj-0002Dg-FN; Wed, 04 May 2022 17:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320950.541931; Wed, 04 May 2022 17:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmItj-0002DZ-CI; Wed, 04 May 2022 17:34:47 +0000 Received: by outflank-mailman (input) for mailman id 320950; Wed, 04 May 2022 17:34:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmIth-0002DT-Q2 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 17:34:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7c2347b9-cbd0-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 19:34:44 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 629991042; Wed, 4 May 2022 10:34:43 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 22FB93FA27; Wed, 4 May 2022 10:34:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c2347b9-cbd0-11ec-8fc4-03012f2f19d4 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2] xen/evtchn: Add design for static event channel signaling Date: Wed, 4 May 2022 18:34:32 +0100 Message-Id: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit This patch introduces a new feature to support the signaling between two domains in dom0less system. Signed-off-by: Rahul Singh --- v2 changes: - switch to the one-subnode-per-evtchn under xen,domain" compatible node. - Add more detail about event-channel --- docs/designs/dom0less-evtchn.md | 126 ++++++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+) create mode 100644 docs/designs/dom0less-evtchn.md diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md new file mode 100644 index 0000000000..62ec8a4009 --- /dev/null +++ b/docs/designs/dom0less-evtchn.md @@ -0,0 +1,126 @@ +# Signaling support between two domUs on dom0less system + +## Current state: Draft version + +## Proposer(s): Rahul Singh, Bertrand Marquis + +## Problem Statement: + +Dom0less guests would benefit from a statically-defined memory sharing and +signally system for communication. One that would be immediately available at +boot without any need for dynamic configurations. + +In embedded a great variety of guest operating system kernels exist, many of +which don't have support for xenstore, grant table, or other complex drivers. +Some of them are small kernel-space applications (often called "baremetal", +not to be confused with the term "baremetal" used in the data center which +means "without hypervisors") or RTOSes. Additionally, for safety reasons, users +often need to be able to configure the full system statically so that it can +be verified statically. + +Event channels are very simple and can be added even to baremetal applications. +This proposal introduces a way to define them statically to make them suitable +for dom0less embedded deployments. + +## Proposal: + +Event channels are the basic primitive provided by Xen for event notifications. +An event channel is a logical connection between 2 domains (more specifically +between dom1,port1, and dom2,port2). Each event has a pending and a masked bit. +The pending bit indicates the event has been raised. The masked bit is used by +the domain to prevent the delivery of that specific event. Xen only performs a +0 → 1 transition on the pending bits and does not touch the mask bit. The +domain may toggle masked bits in the masked bit field and should clear the +pending bit when an event has been processed + +Events are received by a domain via an interrupt from Xen to the domain, +indicating when an event arrives (setting the bit). Further notifications are +blocked until the bit is cleared again. Events are delivered asynchronously to +a domain and are enqueued when the domain is not running. +More information about FIFO based event channel can be found at: +https://xenbits.xen.org/people/dvrabel/event-channels-H.pdf + +The event channel communication will be established statically between two +domains (dom0 and domU also) before unpausing the domains after domain creation. +Event channel connection information between domains will be passed to XEN via +the device tree node. The event channel will be created and established +beforehand in XEN before the domain started. The domain doesn’t need to do any +operation to establish a connection. Domain only needs hypercall +EVTCHNOP_send(local port) to send notifications to the remote guest. + +There is no need to describe the static event channel info in the domU device +tree. Static event channels are only useful in fully static configurations, +and in those configurations the domU device tree dynamically generated by Xen +is not needed. + +Under the "xen,domain" compatible node, there need to be sub-nodes with +compatible "xen,evtchn" that describe the event channel connection between two +domains(dom0 and domU also). + +The event channel sub-node has the following properties: + +- compatible + + "xen,evtchn" + +- xen,evtchn + + The property is tuples of two numbers + (local-evtchn link-to-foreign-evtchn) where: + + local-evtchn is an integer value that will be used to allocate local port + for a domain to send and receive event notifications to/from the remote + domain. + + link-to-foreign-evtchn is a single phandle to a remote evtchn to which + local-evtchn will be connected. + + +Example: + + chosen { + .... + + domU1: domU1 { + compatible = "xen,domain"; + + /* one sub-node per local event channel */ + ec1: evtchn@1 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec3>; + }; + + ec2: evtchn@2 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xc &ec4>; + }; + .... + }; + + domU2: domU2 { + compatible = "xen,domain"; + + /* one sub-node per local event channel */ + ec3: evtchn@3 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xb &ec1>; + }; + + ec4: evtchn@4 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xd &ec2>; + }; + .... + }; + }; + +In above example two event channel comunication will be established between +domU1 and domU2. + + domU1 (port 0xa) <-----------------> domU2 (port 0xb) + domU1 (port 0xc) <-----------------> domU2 (port 0xd) + +domU1 and domU2 can send the signal to remote domain via hypercall +EVTCHNOP_send(.) on local port. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 04 18:34:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 18:34:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320963.541948 (Exim 4.92) (envelope-from ) id 1nmJpE-0000cK-Iu; Wed, 04 May 2022 18:34:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320963.541948; Wed, 04 May 2022 18:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmJpE-0000c8-92; Wed, 04 May 2022 18:34:12 +0000 Received: by outflank-mailman (input) for mailman id 320963; Wed, 04 May 2022 18:34:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmJpB-0000bp-DZ; Wed, 04 May 2022 18:34:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmJpB-0002yo-Bz; Wed, 04 May 2022 18:34:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmJpA-0003dn-RS; Wed, 04 May 2022 18:34:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmJpA-0002Gk-Qz; Wed, 04 May 2022 18:34:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=imNK9X7MZOlJAB6gVmA3fy1+xkXJBqohPwdMY40o85U=; b=3kqQWdYAmJUd2GxdKOuirIhE1+ sHqi3JagHv2Ue1EmaAzn44b2kdOJxJXeS31N74LrHPZnXI+uKRSNj1A2awTap85TOPnP56GLtJxb8 ua8b4zQeCwgJgbuGfAA7VM7kcz8uVft3vFA1JNKb/oV2SYsnyrvXXAL5C78GGnAcUoGM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170114: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 18:34:08 +0000 flight 170114 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170114/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 804 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 19:54:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 19:54:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320973.541964 (Exim 4.92) (envelope-from ) id 1nmL4n-000116-MK; Wed, 04 May 2022 19:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320973.541964; Wed, 04 May 2022 19:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmL4n-00010z-IY; Wed, 04 May 2022 19:54:21 +0000 Received: by outflank-mailman (input) for mailman id 320973; Wed, 04 May 2022 19:43:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmKuV-0008PY-6H for xen-devel@lists.xenproject.org; Wed, 04 May 2022 19:43:43 +0000 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [2607:f8b0:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f432258-cbe2-11ec-a406-831a346695d4; Wed, 04 May 2022 21:43:41 +0200 (CEST) Received: by mail-pg1-x533.google.com with SMTP id i62so1958476pgd.6 for ; Wed, 04 May 2022 12:43:40 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h15-20020a170902f70f00b0015e8d4eb1d0sm8730938plo.26.2022.05.04.12.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 12:43:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f432258-cbe2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RQ5+Z93YtWEK5xXREhrhRleXnskqFAblQsxgrgprxiY=; b=PWTj7QFNwdFF2OE0C4xFUgoIvDGn2+dYizGm/ZxeTyJ+Iz/tyIN+jbKS/JUP74dMIB W7u3atVP0GNPWpIF5TIzABeYYT/Et9n+I/Ppab3jaBr0jw2QDopw+U1E91lEzpAOCQFs xQr1OFa2NKNeyWLt6H4cI0w0eWAyTF94chl/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RQ5+Z93YtWEK5xXREhrhRleXnskqFAblQsxgrgprxiY=; b=heVClJmXMgjV+pfdsDtJfhK8zTPBdPUFUWyo5NKdPskQP+TX9nWISglVfuCf8jrbvK WIqJPmyTK31U9L42BWjkEvQJZ+OiZwrMasE+ePYXeCBTo7a80aa7MhGmEye2EqBveVzZ j96Nkq9c8v0PhZE8Xy4cKM9+zQUJ8+4QSeSsUrR++3ls8iZvF1oNizNmC8UKiR4x7NCJ 9AnB/Hhp6uaEimLLvIDNOfR+Bg6f2bIj08DdpnfyoVNVCqro24E3eKOx9PVjiRaBAxHI ReB1pZcBTHq2klZ9gWI2WvBDaT2S1oLeo413/fkIO7LducmpjCq1wKe6eVC2s935f3hh YIrw== X-Gm-Message-State: AOAM533pKCwwpVVq+Uf1dzfWeO7bb3DzjnrdO71w/ilJgOFDPHebhOYn rsvh0ypysJhzVuRcnaQgxaoHyQ== X-Google-Smtp-Source: ABdhPJxpGz3s4m+LKjicArp6DlDBRGF27gXeN2gLCVWGRMHmfRxOIpCp0rTzhf6HWYs/gZ1wrGnYMQ== X-Received: by 2002:a65:4848:0:b0:39c:c393:688c with SMTP id i8-20020a654848000000b0039cc393688cmr18715460pgs.376.1651693419340; Wed, 04 May 2022 12:43:39 -0700 (PDT) Date: Wed, 4 May 2022 12:43:37 -0700 From: Kees Cook To: David Gow Cc: "Gustavo A . R . Silva" , KUnit Development , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, Linux ARM , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Networking , Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 03/32] flex_array: Add Kunit tests Message-ID: <202205041220.4BAF15F6B4@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 04, 2022 at 11:00:38AM +0800, David Gow wrote: > On Wed, May 4, 2022 at 9:47 AM Kees Cook wrote: > > > > Add tests for the new flexible array structure helpers. These can be run > > with: > > > > make ARCH=um mrproper > > ./tools/testing/kunit/kunit.py config > > Nit: it shouldn't be necessary to run kunit.py config separately: > kunit.py run will configure the kernel if necessary. Ah yes, I think you mentioned this before. I'll adjust the commit log. > > > ./tools/testing/kunit/kunit.py run flex_array > > > > Cc: David Gow > > Cc: kunit-dev@googlegroups.com > > Signed-off-by: Kees Cook > > --- > > This looks pretty good to me: it certainly worked on the different > setups I tried (um, x86_64, x86_64+KASAN). > > A few minor nitpicks inline, mostly around minor config-y things, or > things which weren't totally clear on my first read-through. > > Hopefully one day, with the various stubbing features or something > similar, we'll be able to check against allocation failures in > flex_dup(), too, but otherwise nothing seems too obviously missing. > > Reviewed-by: David Gow Great; thanks for the review and testing! > > -- David > > > lib/Kconfig.debug | 12 +- > > lib/Makefile | 1 + > > lib/flex_array_kunit.c | 523 +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 531 insertions(+), 5 deletions(-) > > create mode 100644 lib/flex_array_kunit.c > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 9077bb38bc93..8bae6b169c50 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -2551,11 +2551,6 @@ config OVERFLOW_KUNIT_TEST > > Builds unit tests for the check_*_overflow(), size_*(), allocation, and > > related functions. > > > > - For more information on KUnit and unit tests in general please refer > > - to the KUnit documentation in Documentation/dev-tools/kunit/. > > - > > - If unsure, say N. > > - > > Nit: while I'm not against removing some of this boilerplate, is it > better suited for a separate commit? Make sense, yes. I'll drop this for now. > > > config STACKINIT_KUNIT_TEST > > tristate "Test level of stack variable initialization" if !KUNIT_ALL_TESTS > > depends on KUNIT > > @@ -2567,6 +2562,13 @@ config STACKINIT_KUNIT_TEST > > CONFIG_GCC_PLUGIN_STRUCTLEAK, CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF, > > or CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL. > > > > +config FLEX_ARRAY_KUNIT_TEST > > + tristate "Test flex_*() family of helper functions at runtime" if !KUNIT_ALL_TESTS > > + depends on KUNIT > > + default KUNIT_ALL_TESTS > > + help > > + Builds unit tests for flexible array copy helper functions. > > + > > Nit: checkpatch warns that the description here may be insufficient: > WARNING: please write a help paragraph that fully describes the config symbol Yeah, I don't know anything to put here that isn't just more boilerplate, so I'm choosing to ignore this for now. :) > > [...] > > +struct normal { > > + size_t datalen; > > + u32 data[]; > > +}; > > + > > +struct decl_normal { > > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(size_t, datalen); > > + DECLARE_FLEX_ARRAY_ELEMENTS(u32, data); > > +}; > > + > > +struct aligned { > > + unsigned short datalen; > > + char data[] __aligned(__alignof__(u64)); > > +}; > > + > > +struct decl_aligned { > > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(unsigned short, datalen); > > + DECLARE_FLEX_ARRAY_ELEMENTS(char, data) __aligned(__alignof__(u64)); > > +}; > > + > > +static void struct_test(struct kunit *test) > > +{ > > + COMPARE_STRUCTS(struct normal, struct decl_normal); > > + COMPARE_STRUCTS(struct aligned, struct decl_aligned); > > +} > > If I understand it, the purpose of this is to ensure that structs both > with and without the flexible array declaration have the same memory > layout? > > If so, any chance of a comment briefly stating that's the purpose (or > renaming this test struct_layout_test())? Yeah, good idea; I'll improve the naming. > > Also, would it make sense to do the same with the struct with internal > padding below? Heh, yes, good point! :) > [...] > > +#define CHECK_COPY(ptr) do { \ > > + typeof(*(ptr)) *_cc_dst = (ptr); \ > > + KUNIT_EXPECT_EQ(test, _cc_dst->induce_padding, 0); \ > > + memcpy(&padding, &_cc_dst->induce_padding + sizeof(_cc_dst->induce_padding), \ > > + sizeof(padding)); \ > > + /* Padding should be zero too. */ \ > > + KUNIT_EXPECT_EQ(test, padding, 0); \ > > + KUNIT_EXPECT_EQ(test, src->count, _cc_dst->count); \ > > + KUNIT_EXPECT_EQ(test, _cc_dst->count, TEST_TARGET); \ > > + for (i = 0; i < _cc_dst->count - 1; i++) { \ > > + /* 'A' is 0x41, and here repeated in a u32. */ \ > > Would it be simpler to just note that the magic value is 0x41, rather > than have it be the character 'A'? Yeah, now fixed. > [...] > > + CHECK_COPY(&encap->fas); > > + /* Check that items external to "fas" are zero. */ > > + KUNIT_EXPECT_EQ(test, encap->flags, 0); > > + KUNIT_EXPECT_EQ(test, encap->junk, 0); > > + kfree(encap); > > +#undef MAGIC_WORD > > MAGIC_WORD isn't defined (or used) for flux_dup_test? Is it worth > using it (or something similar) for the 'A' / 0x14141414 and the > CHECK_COPY() macro? Oops, yes. Fixed. Thanks again! -Kees -- Kees Cook From xen-devel-bounces@lists.xenproject.org Wed May 04 19:59:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 19:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320982.541976 (Exim 4.92) (envelope-from ) id 1nmLA1-0001ff-Gb; Wed, 04 May 2022 19:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320982.541976; Wed, 04 May 2022 19:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmLA1-0001fY-Cs; Wed, 04 May 2022 19:59:45 +0000 Received: by outflank-mailman (input) for mailman id 320982; Wed, 04 May 2022 19:59:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmLA0-0001fQ-84 for xen-devel@lists.xenproject.org; Wed, 04 May 2022 19:59:44 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bbe39775-cbe4-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 21:59:42 +0200 (CEST) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 244IDPwY011405; Wed, 4 May 2022 19:59:25 GMT Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3fuxjx88ma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 May 2022 19:59:25 +0000 Received: from AM0PR03MB3699.eurprd03.prod.outlook.com (52.134.85.31) by VI1PR03MB3102.eurprd03.prod.outlook.com (10.165.190.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 19:59:22 +0000 Received: from AM0PR03MB3699.eurprd03.prod.outlook.com ([fe80::78c1:e5da:903e:66f8]) by AM0PR03MB3699.eurprd03.prod.outlook.com ([fe80::78c1:e5da:903e:66f8%3]) with mapi id 15.20.5206.024; Wed, 4 May 2022 19:59:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbe39775-cbe4-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAHXikLKCJY+8KhhwurLUSs/dKOnEpbM4dBGGMqa/hSs45g9gAnUtaUmwQufnFoNmF/Ue9TNTuybMNbNq+nFvK+wPub5aYrG5AAS/F9KlRMvbOtlyghKluAjldzongJYt5pE6cyTznfjXHkJtmArDR1y1/PLDnbSkRmo6P5Mo09ZC/SJMtw7nCGkjoZj4DaGDMnu5iSlsw83jvQHUjFhtR0K/yO49eLLRcZD6HjbJgyhU+s1GcztjqrNyU/lJUvHI4CfOw/+LKIofcTrbGBMjTJMO61rQ+Su9uNr0ucxc4pHh03IFpGiPvpPZI0wQWsDXfWaZ/IdWJKy6bjaU80OCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YGtCWR5lByVj/N6VFEw2T6DzI7VtEWTpfk8cjDXtedo=; b=KyRZS616Lwc0Z5adJx8WSRLoSIUnQE8+fiVZ36gB37XuKpNSqj+Rxo6+j6tYvb7/ug0KoIH5aSu+AG8jVLja5ho/Wh3oUvNRZF5OedVsLxcmZ32qy1xzyE6y4hetSCAGx9o+oO2CSTbOFLSDLTq3dY1a5eCvQ5jeybMzg/uQzcT/gFSRL0k2LvVTHmuP3i6/7CfiqSWIjlBG13D4zC1juX2LA3ZW50gdn4zpLqQ00gedVt3+3X3FA6QLYJJzzQiuGjOGc2Z55iseRq/gSK8AwBk7cLCZpQvvmnsymKBIsKlBYM95gn85rvhnCjxdrhymyz9tzpXV0XlsY+xGIdQUhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGtCWR5lByVj/N6VFEw2T6DzI7VtEWTpfk8cjDXtedo=; b=Le+r2uXSqakkzf7LCQOxsTgPTeckCt9YgrWmo18PMURhxX+S5+AeBonZVtDBXwz7s7hYdS7g6YCEzoLblMJan5beCRN4tmJzW1yKHstA2p+q4ntl8W9WWW5+zOCfWbMUnt515DKoGObPx08o1eo60FvGmIh2dgIz+gcK5rp3g49OW29p+ptMT1CgAtwRIC8n8FvU6JJLiWteBKbjScbF5Mry2dD1UcEWEw+U5x1BeAHUuH2sMG30ZZDjdkyrd3nQMEqeiLgEdJhtVPRifN48V+kYBBGMyh0EMhUBcUw2L/FT1Xaa3srPF1KRk0bcaiaifn1Kqk46VRZ+bMl8DTvciQ== From: Volodymyr Babchuk To: Jens Wiklander CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH] optee: immediately free RPC buffers that are released by OP-TEE Thread-Topic: [PATCH] optee: immediately free RPC buffers that are released by OP-TEE Thread-Index: AQHYX3q1+cwfT5uujESolgz3RZy+760PI7EA Date: Wed, 4 May 2022 19:59:22 +0000 Message-ID: <8735hpm5ly.fsf@epam.com> References: <287f81d7cec66b5ef1f8f3f61679b9593e2b81d4.1651643156.git.jens.wiklander@linaro.org> In-Reply-To: <287f81d7cec66b5ef1f8f3f61679b9593e2b81d4.1651643156.git.jens.wiklander@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.6.5; emacs 27.2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b341712-0cce-4ac7-d14b-08da2e089548 x-ms-traffictypediagnostic: VI1PR03MB3102:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aEyS1YvdLcaEhWd3dzJTjg9RHw10ZDVk3+lNxRfnXkjybU7Ob2y8JEijdke7IO35OWI1BkA7NHAioV7SdCuV1rDCzwPNRyhQEDuZ4W4fTKU26KJZXVz9JKGb8BjjjU3Gemq4YveetprCfbpBWUeP/3eK0T+bvo3dMMbj/YIzKMBtT4y8i7d5T+9JPVamRaGdxx/PIBIfUex3lbq6QBMsFJHC01toHd6wM+PO9Zh9s9z8uQNem28y6MMusyk7B+MKSYaPY7oYRM93wxPjAHM9y82gjPaQVQXAxsnxxM6labvwTX0JgmsyQezROb6kit6u7VS/m+P4lGHETZNi0cJ+T3cKOGgt8K8vc2goeAXzBBZ1EWHXrfCIoGbwodRMBL54OyAVeM7n2S+eX8Vmk/GvgOBwEq75xdzTkthBwQPDLcjnlQvyl+oKRBqW/9btYoCJB4xXS9p6L2/EY4O0RwBo6+URo/jyk/c9Z2QQynJqYRw1vtMgzFBuxTmWUuPnaiRUQZPF3iQx6zs1cIJV8IkK/g+cYPTtCbNdGxdayPb3vCkg/4dOSeEuw/W41J2Y7NJekHA15747PCtpGDV0jLQkDNkDuZ91UqdoyzODv1cE52K3rLhlL3Fm9Kn0fCDntyILAVNdq6eC9wiOwdVGdlKg0hZ9BdGSaqWN0tIQmh78j8lubRjEkTQKHybGBcF3T1m9g0WJvnCV+1wquYYSdr/vVsxgYPT3ksZy5vZhEWll8do= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB3699.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(71200400001)(6486002)(83380400001)(508600001)(6512007)(2616005)(55236004)(6506007)(86362001)(38070700005)(38100700002)(5660300002)(122000001)(36756003)(2906002)(66446008)(66556008)(54906003)(66946007)(91956017)(76116006)(66476007)(4326008)(64756008)(8676002)(6916009)(316002)(8936002)(14773001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?xir0iemCa3r41Yj9cK8uwJDYAajOBzCHuxbGPQ+ULccuaejeXqtxgGv+qi?= =?iso-8859-1?Q?FfqJimJ6Z/xRYIMJCcoptuJ2NYZ9tEw2xrQqLh6vXWR5t2CxndZmrVINcX?= =?iso-8859-1?Q?q8coK6z3EkBSuIVfpvnVLRuQDAprlLwhRHnjUg5xjIHAjD4SNVkWQH/xCE?= =?iso-8859-1?Q?37rxQkjP277XhBjgBV/+69O+D47DP5WQYM4PRTQbvqi3tuhCOM+qAoKj7j?= =?iso-8859-1?Q?G6RKxA3ftfXn02gv5I2Fak0TP2AFjurDKRvqCf9ZT7KzISR3aAL0o/BZZY?= =?iso-8859-1?Q?+WpACLHiTOMEjR4JrRsf/eKgGDYT7DG/Ufz0lQyqe1dPTTnkSBo+/l2nAV?= =?iso-8859-1?Q?B3mYxcL2OLDDMNayHTKo8iBRPjwNwZMMzSutA6eH6I3wydrACFgz6tsBeM?= =?iso-8859-1?Q?36m1Hv9d6nv//NRU9j2E9zXWYjN8dZRa+GwiO/YTOaBsete4mlEdLpMnV7?= =?iso-8859-1?Q?bu0paSPCXRU44sNmA/ZLSsx5wR2U1/TXtGfayx9UiRPuQ+XVcVnV5xxaB7?= =?iso-8859-1?Q?VheDKqkIFZBGkiGDVwO0TW9Uju9xsMVnj2VkPNwfEDo+8vO1+eeFQYkOpD?= =?iso-8859-1?Q?A/U1IqpaPy5jgvPLJ0p/bWMkrl8dL2hwprWCDyxks3Bf7ReeY4VQ62oKhl?= =?iso-8859-1?Q?JxpwZZlXW+xQLb4uVCh154qBpAHLTMBqZAyt7e2WIia3cWrSd82f0yM76j?= =?iso-8859-1?Q?DcMJAZEbK99eT8Dmb7GY7UMBiIoWZPp952veJaxo9T5TkEpKoz4a+kpN0Q?= =?iso-8859-1?Q?jvPsNWaNf6lF0NkKL2iZvsOAqi8MY4TcaNTE83a9MqAs6+uz8yUJF8cCLQ?= =?iso-8859-1?Q?4sqzRNxu78Lmde1Agky8YcJ+xDJGTKaDeDnx6bQ5uNlJSt86r3zv2nr8sf?= =?iso-8859-1?Q?FbWLDPAY6lI4MgE1ij0TmZ135y6izRiAuv7QLbgI1XLlVHyF2Gz8spE9Nc?= =?iso-8859-1?Q?v40LaUX7zRDBtDo9iyJdGP2bUPMVN0WUHR5uQqkrC1ONkrRbUgdEmfe/Uq?= =?iso-8859-1?Q?1mZ7iq+a0YZSg3MCWmdvbmB1RO/u6l6dnrseNQKD5xa8HjI9ioPy6cL3qK?= =?iso-8859-1?Q?WJdyKzme607mvtYimfeg3zqOR28CvYq17RAQAOE/Frb9LFsc+6q1UFGZum?= =?iso-8859-1?Q?FS6cDr3Ptrcgn51ZTaApMzAurBkC5rjqDAgIZYKryw+e/dzlCAR2tM/xfm?= =?iso-8859-1?Q?j1SDkgLYIXm7asWidTRhfU9iyIxUFCBK+0t3b8Gtnnyq7SyKkooQ3vSFYZ?= =?iso-8859-1?Q?gmvQ/vcnVUX4CuQM0DZu1Awl7PC1lDXU9sQ4WPK3oxsHhd64sWAsmO1P9j?= =?iso-8859-1?Q?BbbmtHnY0+wmr7Ux8XXf3ybiybcp28IWRB1+9w8KcYOuRzHqfkaQ5TkW8d?= =?iso-8859-1?Q?Vjz/VsabYnN61tjpN56jzga65rMq7Qk0matIADjMnJlezsEs6l/cPScIf0?= =?iso-8859-1?Q?On74puo4MlDUmU+cHASmRe+UhE+ZaUFdJgL0FTfXlC8s33iyPHzAAW1A6x?= =?iso-8859-1?Q?Uiz5wLz7jQinyi87Is+T7Iy1BVhQjXhahs/PfzZlQCGr28id19z1NIy3d5?= =?iso-8859-1?Q?dlDKpEqok/JvOH80DUKnTxi+K1Pg2Hpc7T03o3qTZzg322qTKQOyEn7hB9?= =?iso-8859-1?Q?cup3P9Keaza9NRLK6VNc0Kwv5I4J2IRshWH94/+ezZKsHL5tHoTg8YMoKA?= =?iso-8859-1?Q?BAXlYgPWU8KDBDzA3AMoSdHx54sjOUoBAfqWla/3l6TMlxWooQpAY4K5WJ?= =?iso-8859-1?Q?i6E3ngSfAOVljGhW5Zh4eF1f8OzuYp35UTrghKYtG9nCHObpcnmH71oinK?= =?iso-8859-1?Q?A3aFM8WQ/qtjxmHEoN7JUd9jyMrwxH8=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB3699.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b341712-0cce-4ac7-d14b-08da2e089548 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 19:59:22.5071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jk5Rz8GyJqzcFsXY0RSsdz9w1fE+aMdX1PDgTgSlT6pj5ivBKGNKu+4+Bxr7iqOSTuA7jNGAplzprgOxWLDMQ/BVIBCn78SK1i98uA2al5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3102 X-Proofpoint-ORIG-GUID: 17zvTvYtmbeEZZIvXIAbjTcHEaDsYSlk X-Proofpoint-GUID: 17zvTvYtmbeEZZIvXIAbjTcHEaDsYSlk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-04_05,2022-05-04_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=811 priorityscore=1501 spamscore=0 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205040117 Hello Jens, Jens Wiklander writes: > This commit fixes a case overlooked in [1]. > > There are two kinds of shared memory buffers used by OP-TEE: > 1. Normal payload buffer > 2. Internal command structure buffers > > The internal command structure buffers are represented with a shadow > copy internally in Xen since this buffer can contain physical addresses > that may need to be translated between real physical address and guest > physical address without leaking information to the guest. > > [1] fixes the problem when releasing the normal payload buffers. The > internal command structure buffers must be released in the same way. > Failure to follow this order opens a window where the guest has freed > the shared memory but Xen is still tracking the buffer. > > During this window the guest may happen to recycle this particular > shared memory in some other thread and try to use it. Xen will block > this which will lead to spurious failures to register a new shared > memory block. > > Fix this by freeing the internal command structure buffers first before > informing the guest that the buffer can be freed. > > [1] 5b13eb1d978e ("optee: immediately free buffers that are released by O= P-TEE") > > Signed-off-by: Jens Wiklander Thank you for the fix: Reviewed-by: Volodymyr Babchuk --=20 Volodymyr Babchuk at EPAM= From xen-devel-bounces@lists.xenproject.org Wed May 04 21:22:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 21:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320992.541993 (Exim 4.92) (envelope-from ) id 1nmMRd-0002yv-7k; Wed, 04 May 2022 21:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320992.541993; Wed, 04 May 2022 21:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMRd-0002yo-42; Wed, 04 May 2022 21:22:01 +0000 Received: by outflank-mailman (input) for mailman id 320992; Wed, 04 May 2022 21:21:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMRb-0002yP-6z for xen-devel@lists.xenproject.org; Wed, 04 May 2022 21:21:59 +0000 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 3a1e3e79-cbf0-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 23:21:57 +0200 (CEST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nmLg4-0003MI-01; Wed, 04 May 2022 22:32:52 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id B9C09C01D0; Wed, 4 May 2022 22:32:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a1e3e79-cbf0-11ec-8fc4-03012f2f19d4 Date: Wed, 4 May 2022 22:32:24 +0200 From: Thomas Bogendoerfer To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 07/30] mips: ip22: Reword PANICED to PANICKED and remove useless header Message-ID: <20220504203224.GA23475@alpha.franken.de> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-8-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-8-gpiccoli@igalia.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Wed, Apr 27, 2022 at 07:49:01PM -0300, Guilherme G. Piccoli wrote: > Many other place in the kernel prefer the latter, so let's keep > it consistent in MIPS code as well. Also, removes a useless header. > > Cc: Thomas Bogendoerfer > Signed-off-by: Guilherme G. Piccoli > --- > arch/mips/sgi-ip22/ip22-reset.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From xen-devel-bounces@lists.xenproject.org Wed May 04 21:27:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 21:27:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321002.542004 (Exim 4.92) (envelope-from ) id 1nmMXB-0003da-WD; Wed, 04 May 2022 21:27:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321002.542004; Wed, 04 May 2022 21:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMXB-0003dT-St; Wed, 04 May 2022 21:27:45 +0000 Received: by outflank-mailman (input) for mailman id 321002; Wed, 04 May 2022 21:27:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMX7-0003dN-Ri for xen-devel@lists.xenproject.org; Wed, 04 May 2022 21:27:44 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 062a6930-cbf1-11ec-8fc4-03012f2f19d4; Wed, 04 May 2022 23:27:40 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nmMWW-0004FF-4B; Wed, 04 May 2022 23:27:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 062a6930-cbf1-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dpN78FnXP8xKsKthCe3ePYGrznnidWC78ijJKGIis+s=; b=VzNshjcWDWgTdIjmwACWbnjJ/H mQcB13lNG3fglzHQC/FUqdo2dvwKWsRAKNIc/TJuBa97Z8kYuf2lpVRvpBu62ga3ovDrsi08aDNiE OlqogXHjD4qsmKbgS2LbXN2AOGnhdCvdtCVo6IDt0imworVavUuV/zNlIT6mNaTQhnLm07TNtoK4m Ihl3ULKYuFP6cuYPQF485CZFlEA6oPcsLGDcH0IfHz/dstflDSmqrZB+ksN5MQ7uiQlVVpBT+K7Ib 0RM9kXieFgdNepPjq9LySneGSuViPcHimXjyBUf5+knfLf159kvuFYr1c8xkwmLdvzZ/p8/HjZAHo dOADxIVQ==; Message-ID: <976c2d62-09e7-9f8d-d978-12749a2f70e6@igalia.com> Date: Wed, 4 May 2022 18:26:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 07/30] mips: ip22: Reword PANICED to PANICKED and remove useless header Content-Language: en-US To: Thomas Bogendoerfer Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-8-gpiccoli@igalia.com> <20220504203224.GA23475@alpha.franken.de> From: "Guilherme G. Piccoli" In-Reply-To: <20220504203224.GA23475@alpha.franken.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/05/2022 17:32, Thomas Bogendoerfer wrote: > [...] > > applied to mips-next. > > Thomas. > Thanks a bunch Thomas =) From xen-devel-bounces@lists.xenproject.org Wed May 04 21:36:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 21:36:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321009.542018 (Exim 4.92) (envelope-from ) id 1nmMf9-0005D4-11; Wed, 04 May 2022 21:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321009.542018; Wed, 04 May 2022 21:35:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMf8-0005Cx-Sl; Wed, 04 May 2022 21:35:58 +0000 Received: by outflank-mailman (input) for mailman id 321009; Wed, 04 May 2022 21:35:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMf7-0005Cn-KE; Wed, 04 May 2022 21:35:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMf7-00068l-Iu; Wed, 04 May 2022 21:35:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMf7-0003ob-4v; Wed, 04 May 2022 21:35:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmMf7-00012G-4T; Wed, 04 May 2022 21:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2zq0EP9bfvi+CY+YG9S6ul95OL4qgn6rMw6kwLaU78o=; b=3MswKLAKAUlRroOpNKP4vGAaBl mlMX+a13a45CReOCReFuAsj7gqjfS/YbtM+3kRah5leCkgm73G9MgdLfjTkyHJOtXm3M52fhdihW1 BN9kgPulpDOdpdpEWlhHbJNyVtGLKaxPT2G6gOBQ47cZOJtZfDww2xeKy21wZIQMW2xc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170117: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 21:35:57 +0000 flight 170117 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 805 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 04 21:41:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 21:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321018.542032 (Exim 4.92) (envelope-from ) id 1nmMk2-0006eF-Qg; Wed, 04 May 2022 21:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321018.542032; Wed, 04 May 2022 21:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMk2-0006e8-Mx; Wed, 04 May 2022 21:41:02 +0000 Received: by outflank-mailman (input) for mailman id 321018; Wed, 04 May 2022 21:41:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmMk0-0006dm-TW for xen-devel@lists.xenproject.org; Wed, 04 May 2022 21:41:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2c41d7f-cbf2-11ec-a406-831a346695d4; Wed, 04 May 2022 23:40:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5926F6198D; Wed, 4 May 2022 21:40:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A383C385A5; Wed, 4 May 2022 21:40:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2c41d7f-cbf2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651700457; bh=UAjJyX/lpnZbUpWnQUB7nZzIjLfz62Xr9MhId9sEZ7E=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rZDsvS/NZ8oMcvzXShzVceRe8f9ecNqb1KhzqOB3XaZLavRbdY4JjzB82o4NatXdF CIZArqv1VSzdVQLwgyPrqAG90bADo5MsDkiR6nUnlmSj3SzLgvXCBKaojlyxCVjdIN FMnVztkuhjjCNbQgw5s+EeA7sXOKDXgjCO/Toib3ctsMZ+btEVJCPHId3Lz3RJoiJn LF9et2IVUyAuGtdi0sNSFpjDRUwh1pdAHflVBmHIuuTTWaxTseXsdVKGDzIEMRwc5U 08Dq2LFVvEVaLFLLJNQvv6dzFyRR0eE4MVShFydHjU6dByv5fr5S0DXW/hQ4rjjbyV 3+WlEc9wHknyQ== Date: Wed, 4 May 2022 14:40:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Volodymyr Babchuk cc: Jens Wiklander , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH] optee: immediately free RPC buffers that are released by OP-TEE In-Reply-To: <8735hpm5ly.fsf@epam.com> Message-ID: References: <287f81d7cec66b5ef1f8f3f61679b9593e2b81d4.1651643156.git.jens.wiklander@linaro.org> <8735hpm5ly.fsf@epam.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 May 2022, Volodymyr Babchuk wrote: > Hello Jens, > > Jens Wiklander writes: > > > This commit fixes a case overlooked in [1]. > > > > There are two kinds of shared memory buffers used by OP-TEE: > > 1. Normal payload buffer > > 2. Internal command structure buffers > > > > The internal command structure buffers are represented with a shadow > > copy internally in Xen since this buffer can contain physical addresses > > that may need to be translated between real physical address and guest > > physical address without leaking information to the guest. > > > > [1] fixes the problem when releasing the normal payload buffers. The > > internal command structure buffers must be released in the same way. > > Failure to follow this order opens a window where the guest has freed > > the shared memory but Xen is still tracking the buffer. > > > > During this window the guest may happen to recycle this particular > > shared memory in some other thread and try to use it. Xen will block > > this which will lead to spurious failures to register a new shared > > memory block. > > > > Fix this by freeing the internal command structure buffers first before > > informing the guest that the buffer can be freed. > > > > [1] 5b13eb1d978e ("optee: immediately free buffers that are released by OP-TEE") > > > > Signed-off-by: Jens Wiklander > > Thank you for the fix: > > Reviewed-by: Volodymyr Babchuk committed with a small code syle fix From xen-devel-bounces@lists.xenproject.org Wed May 04 23:13:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 04 May 2022 23:13:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321029.542047 (Exim 4.92) (envelope-from ) id 1nmOBW-00081W-C1; Wed, 04 May 2022 23:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321029.542047; Wed, 04 May 2022 23:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOBW-00081P-7w; Wed, 04 May 2022 23:13:30 +0000 Received: by outflank-mailman (input) for mailman id 321029; Wed, 04 May 2022 23:13:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOBV-00081F-3u; Wed, 04 May 2022 23:13:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOBV-0007re-1m; Wed, 04 May 2022 23:13:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOBU-0007Ra-KS; Wed, 04 May 2022 23:13:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmOBU-0002Xg-K1; Wed, 04 May 2022 23:13:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zaAex+ohKhWOJP27MKW8oyV7fuKKVKixcX7BIcXCjww=; b=Q9bxnz66VqJTnCxre4xEp4Hltm KOKyJK/SfBG5bB/8+V45Zy8bykDTDD6DFjAHLWEa4GY6IB3jm38CjAwc28GNXt6pwSmwSi3rVbqaT P53F+RKSAZdrGK3MEpbkUkPIyBfKdi/ZqvBBptwfRvwdCoGyGc6vbKrgbw0isu8VuZhg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170121: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 04 May 2022 23:13:28 +0000 flight 170121 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170121/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 806 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 00:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321156.542070 (Exim 4.92) (envelope-from ) id 1nmOv4-0005cK-7I; Thu, 05 May 2022 00:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321156.542070; Thu, 05 May 2022 00:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOv4-0005cD-32; Thu, 05 May 2022 00:00:34 +0000 Received: by outflank-mailman (input) for mailman id 321156; Thu, 05 May 2022 00:00:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOv2-0005c3-9H; Thu, 05 May 2022 00:00:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOv2-0000rS-8G; Thu, 05 May 2022 00:00:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOv1-0000Ls-Rw; Thu, 05 May 2022 00:00:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmOv1-0001Hl-RS; Thu, 05 May 2022 00:00:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UVw0optj6rDQp4BSCx823essuKyK8fnMDHZQWRNvdYY=; b=ZgFWMkzG5YL/Ez1NVI8KFZ0IBU Vug5cF5Wxxfbs8mq1hhKZ6s3QL/3Rx7lT0BQWKHH1RoHVMcqjliFZHxIH7dZ/1Jmky3o03y9wXaSF 16s2ExnuSEv8IhV3ifi+4h7dmnZajKsICJY6ixrlthPo0h6Tk+z2IE3DiT6BgiOGA6Tc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170125: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 00:00:31 +0000 flight 170125 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170125/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 807 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 00:16:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:16:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321169.542081 (Exim 4.92) (envelope-from ) id 1nmPAL-0007LX-2N; Thu, 05 May 2022 00:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321169.542081; Thu, 05 May 2022 00:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPAK-0007LQ-Uj; Thu, 05 May 2022 00:16:20 +0000 Received: by outflank-mailman (input) for mailman id 321169; Thu, 05 May 2022 00:16:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPAJ-0007LG-VR for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:16:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94e9c763-cc08-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 02:16:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 982E061D4E; Thu, 5 May 2022 00:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E94C385B1; Thu, 5 May 2022 00:16:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94e9c763-cc08-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709776; bh=a/fnNJ/bKKOG4tmQuObcdJZXY4wSKSDloZeQB+YRC8w=; h=Date:From:To:cc:Subject:From; b=ZaU/YGT0s/VxMgSGatTuRI/ua6haMOlNBLbWwfKsxq8u/M4yqS/TorElYIhQz3JvD 1LISqvh2EShuY9GL7GDCYU4UZRPqoR7o1RZsxT26gnwoV9rboW2+OUHNBRTOjIpzSf JRFW3HB753S+QqGkLNX5u7uFlXuiSGXBVzvrbPWmu4gEY+If1WKD29NpZ4aMiWfdqV D7wf9vdwefqQiq+wWJgpZy9nqRUiz6MuFtI45Dq7L0zk1ezjF1y5u90g8NlBXNkl51 /7WTbplxRE834Ry6YVuooBdi21VU8e/1xljep8WJToZvOkpplYD8WSaieFjhnymcpX 6uzangn0phfYg== Date: Wed, 4 May 2022 17:16:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com Subject: [PATCH v6 0/7] dom0less PV drivers Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, Currently dom0less guests cannot use PV drivers because they don't have access to xenstore. Also, the hypervisor node in device tree is missing so they don't detect that they are running on Xen (thus, they don't try to enable PV interfaces.) This patch series enables dom0less guests (on ARM) to use PV drivers. Instead of initializing xenstore immediately at boot, dom0less guests get access to xenstore later. They delay the initialization until they receive a notification via the xenstore event channel (which is available at boot.) An example workflow is as follows: - all domains start in parallel, dom0less guests are immediately running - when dom0 is up and running, the init-dom0less application is called - dom0less guests receive the notification and initialize xenstore - now xl network-attach/disk-attach works as expected for dom0less domUs The patch series introduces a new dom0less device tree option "xen,enhanced" (in the Xen device tree) to specify whether PV interfaces should be enabled/disabled for the dom0less guest. This patch series is based on Daniel P. Smith's "Adds starting the idle domain privileged". A important change in v5 is the usage of XS_CONNECTION_STATE_RECONNECTING to signal that the xenstore interface is not ready. Cheers, Stefano Luca Miccio (3): xen/arm: configure dom0less domain for enabling xenstore after boot xenstored: send an evtchn notification on introduce_domain tools: add example application to initialize dom0less PV drivers Stefano Stabellini (4): xen/dt: of_property_read_string return -ENODATA when !length xen/arm: implement domU extended regions xen: introduce xen,enhanced dom0less property docs: document dom0less + PV drivers docs/features/dom0less.pandoc | 43 ++++- docs/misc/arm/device-tree/booting.txt | 18 ++ docs/misc/xen-command-line.pandoc | 9 +- tools/helpers/Makefile | 13 ++ tools/helpers/init-dom0less.c | 340 ++++++++++++++++++++++++++++++++++ tools/xenstore/xenstored_domain.c | 4 + xen/arch/arm/domain_build.c | 104 ++++++++++- xen/arch/arm/include/asm/kernel.h | 3 + xen/common/device_tree.c | 2 +- xen/common/event_channel.c | 2 +- xen/include/public/io/xs_wire.h | 2 +- xen/include/xen/device_tree.h | 3 + xen/include/xen/event.h | 3 + 13 files changed, 527 insertions(+), 19 deletions(-) create mode 100644 tools/helpers/init-dom0less.c From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321173.542092 (Exim 4.92) (envelope-from ) id 1nmPB0-0007rk-Ft; Thu, 05 May 2022 00:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321173.542092; Thu, 05 May 2022 00:17:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB0-0007rd-BA; Thu, 05 May 2022 00:17:02 +0000 Received: by outflank-mailman (input) for mailman id 321173; Thu, 05 May 2022 00:17:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPAz-0007pt-2e for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae072064-cc08-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 02:17:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F25D861D48; Thu, 5 May 2022 00:16:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEC20C385A5; Thu, 5 May 2022 00:16:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae072064-cc08-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709818; bh=Mwel9XZZFmkKqmMXTUSqunEUmjRMBAHXbPN0MGWNniE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X1CQfMiiba7mxvH99FxIL6s0zrb0Fc7+eSFMhhFjOj4c+F465u6+ZLvNmQySQfgud AmoD7u+dD1zZ3W4t6HsqLBghxSkW3DIJwrF9lsNUxHHZxAojy6DeJFhlhb2eptpteU P316kO1K/T06fU7OB99OohEKNqV1iP36NdJCOuURxJ+6CIh0ymwdeUIe2IzYjcNCda /5KbvSzf7BBfccwe16Ms+X7H5GQQO+cM2pSalMM5Kz4+GYXOm5WRWdS5TV0mMUWQ/Y kEdPoFtCHn6++6d8a8gcYoWHW8AorTyLUhJmVdTKZ7eH7M6ejWQzcKHvQ1TMaHnXd9 ANgNDKFjVlnpg== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu , olekstysh@gmail.com Subject: [PATCH v6 2/7] xen/arm: implement domU extended regions Date: Wed, 4 May 2022 17:16:51 -0700 Message-Id: <20220505001656.395419-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Implement extended regions for dom0less domUs. The implementation is based on the libxl implementation. Also update docs for the ext_regions command line option. Signed-off-by: Stefano Stabellini Reviewed-by: Luca Fancellu CC: olekstysh@gmail.com --- Changes in v6: - add reviewed-by - address 2 NITs - update docs Changes in v5: - print the domain - coding style - simplify the code in find_domU_holes - return error if no regions allocated in find_domU_holes - use ROUNDUP - uint64_t/paddr_t --- docs/misc/xen-command-line.pandoc | 9 ++--- xen/arch/arm/domain_build.c | 60 ++++++++++++++++++++++++++----- 2 files changed, 56 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1dc7e1ca07..881fe409ac 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1110,11 +1110,12 @@ to use the default. > Default : `true` -Flag to enable or disable support for extended regions for Dom0. +Flag to enable or disable support for extended regions for Dom0 and +Dom0less DomUs. -Extended regions are ranges of unused address space exposed to Dom0 as -"safe to use" for special memory mappings. Disable if your board device -tree is incomplete. +Extended regions are ranges of unused address space exposed to the guest +as "safe to use" for special memory mappings. Disable if your board +device tree is incomplete. ### flask > `= permissive | enforcing | late | disabled` diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1472ca4972..f22450b4b7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -35,7 +35,10 @@ static unsigned int __initdata opt_dom0_max_vcpus; integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); -/* If true, the extended regions support is enabled for dom0 */ +/* + * If true, the extended regions support is enabled for dom0 and + * dom0less domUs. + */ static bool __initdata opt_ext_regions = true; boolean_param("ext_regions", opt_ext_regions); @@ -1324,6 +1327,36 @@ out: return res; } +static int __init find_domU_holes(const struct kernel_info *kinfo, + struct meminfo *ext_regions) +{ + unsigned int i; + paddr_t bankend; + const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; + const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; + int res = -ENOENT; + + for ( i = 0; i < GUEST_RAM_BANKS; i++ ) + { + struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]); + + ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, SZ_2M); + + bankend = ~0ULL >> (64 - p2m_ipa_bits); + bankend = min(bankend, bankbase[i] + banksize[i] - 1); + if ( bankend > ext_bank->start ) + ext_bank->size = bankend - ext_bank->start + 1; + + /* 64MB is the minimum size of an extended region */ + if ( ext_bank->size < MB(64) ) + continue; + ext_regions->nr_banks++; + res = 0; + } + + return res; +} + static int __init make_hypervisor_node(struct domain *d, const struct kernel_info *kinfo, int addrcells, int sizecells) @@ -1360,12 +1393,13 @@ static int __init make_hypervisor_node(struct domain *d, if ( !opt_ext_regions ) { - printk(XENLOG_INFO "The extended regions support is disabled\n"); + printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d); nr_ext_regions = 0; } else if ( is_32bit_domain(d) ) { - printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n"); + printk(XENLOG_WARNING + "%pd: extended regions not supported for 32-bit guests\n", d); nr_ext_regions = 0; } else @@ -1374,13 +1408,21 @@ static int __init make_hypervisor_node(struct domain *d, if ( !ext_regions ) return -ENOMEM; - if ( !is_iommu_enabled(d) ) - res = find_unallocated_memory(kinfo, ext_regions); + if ( is_domain_direct_mapped(d) ) + { + if ( !is_iommu_enabled(d) ) + res = find_unallocated_memory(kinfo, ext_regions); + else + res = find_memory_holes(kinfo, ext_regions); + } else - res = find_memory_holes(kinfo, ext_regions); + { + res = find_domU_holes(kinfo, ext_regions); + } if ( res ) - printk(XENLOG_WARNING "Failed to allocate extended regions\n"); + printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n", + d); nr_ext_regions = ext_regions->nr_banks; } @@ -1401,8 +1443,8 @@ static int __init make_hypervisor_node(struct domain *d, u64 start = ext_regions->bank[i].start; u64 size = ext_regions->bank[i].size; - printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", - i, start, start + size); + printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", + d, i, start, start + size); dt_child_set_range(&cells, addrcells, sizecells, start, size); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321174.542097 (Exim 4.92) (envelope-from ) id 1nmPB0-0007vU-VA; Thu, 05 May 2022 00:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321174.542097; Thu, 05 May 2022 00:17:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB0-0007up-NY; Thu, 05 May 2022 00:17:02 +0000 Received: by outflank-mailman (input) for mailman id 321174; Thu, 05 May 2022 00:17:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB0-0007pt-2u for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae6e9ef7-cc08-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 02:17:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7348761D4A; Thu, 5 May 2022 00:16:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A635C385B0; Thu, 5 May 2022 00:16:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae6e9ef7-cc08-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709818; bh=1SZ90Yt0l4IaHxlGeXfmBz5khMim6VBa3OhRqKwwqVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ELx8Xsa4VisWKnYAVptArxVyNrykUSbHalc0JlZOUH/J+ExS9sbCy3ivYBHoJStLC 9/xqbsUD4cbsBUBBU6VFoRXJYjVakJUHNurJqjslDxV0X/OWgnJ1KtHP+65+5GYFZb WW/6yO/Lg6nhIQFuBbLcWhfE3jngodRytVBS0YZcrsbcjSWp4oWIpADUHVfV8NXnoR LR95aOZPoLtpcHbo8ZWFtXd46cxiqQyL2HIJSn5vKzIl7kggL1xT6qy/7zjRLk67k/ i7mhaGWDyGqB+lcYOHUh7vx/TWHdrRRkD6zM5cXq+qQjvuYt1az3hsNgb6okba3kuv ZApf0qHn1PAWg== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Bertrand Marquis Subject: [PATCH v6 3/7] xen: introduce xen,enhanced dom0less property Date: Wed, 4 May 2022 17:16:52 -0700 Message-Id: <20220505001656.395419-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Introduce a new "xen,enhanced" dom0less property to enable/disable PV driver interfaces for dom0less guests. Currently only "enabled" and "disabled" are supported property values (and empty). Leave the option open to implement further possible values in the future (e.g. "xenstore" to enable only xenstore.) The configurable option is for domUs only. For dom0 we always set the corresponding property in the Xen code to true (PV interfaces enabled.) This patch only parses the property. Next patches will make use of it. Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- Changes in v4: - move xen,enhanced to the bottom of the list - do not set kinfo.dom0less_enhanced for dom0 Changes in v3: - improve commit message Changes in v2: - rename kinfo.enhanced to kinfo.dom0less_enhanced - set kinfo.dom0less_enhanced to true for dom0 - handle -ENODATA in addition to -EILSEQ --- docs/misc/arm/device-tree/booting.txt | 18 ++++++++++++++++++ xen/arch/arm/domain_build.c | 7 +++++++ xen/arch/arm/include/asm/kernel.h | 3 +++ 3 files changed, 28 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index a94125394e..92097c4969 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -188,6 +188,24 @@ with the following properties: An empty property to request the memory of the domain to be direct-map (guest physical address == physical address). +- xen,enhanced + + A string property. Possible property values are: + + - "enabled" (or missing property value) + Xen PV interfaces, including grant-table and xenstore, will be + enabled for the VM. + + - "disabled" + Xen PV interfaces are disabled. + + If the xen,enhanced property is present with no value, it defaults + to "enabled". If the xen,enhanced property is not present, PV + interfaces are disabled. + + In the future other possible property values might be added to + enable only selected interfaces. + Under the "xen,domain" compatible node, one or more sub-nodes are present for the DomU kernel and ramdisk. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f22450b4b7..016f56a99f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3154,6 +3154,7 @@ static int __init construct_domU(struct domain *d, const struct dt_device_node *node) { struct kernel_info kinfo = {}; + const char *dom0less_enhanced; int rc; u64 mem; @@ -3169,6 +3170,12 @@ static int __init construct_domU(struct domain *d, kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); + rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced); + if ( rc == -EILSEQ || + rc == -ENODATA || + (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) + kinfo.dom0less_enhanced = true; + if ( vcpu_create(d, 0) == NULL ) return -ENOMEM; diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 874aa108a7..c4dc039b54 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -36,6 +36,9 @@ struct kernel_info { /* Enable pl011 emulation */ bool vpl011; + /* Enable PV drivers */ + bool dom0less_enhanced; + /* GIC phandle */ uint32_t phandle_gic; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321175.542112 (Exim 4.92) (envelope-from ) id 1nmPB2-0008JP-E4; Thu, 05 May 2022 00:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321175.542112; Thu, 05 May 2022 00:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB2-0008I0-8n; Thu, 05 May 2022 00:17:04 +0000 Received: by outflank-mailman (input) for mailman id 321175; Thu, 05 May 2022 00:17:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB0-0007ib-Hu for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aec53614-cc08-11ec-a406-831a346695d4; Thu, 05 May 2022 02:17:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ACA561D50; Thu, 5 May 2022 00:17:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3FCEC385AF; Thu, 5 May 2022 00:16:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aec53614-cc08-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709820; bh=rIw+2SrwT7YpYC/phawk5vOS/f23VxvR6M90QJVp4fk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IzyPwIj4awg5UuN2mAFVNIw8aZZVyleXB9GoKZL7HhJafzHHCw/zn3G4VE4mxI3dw eNZxzPgcrdHBsuXo3GX5fW3S/4g7vQ1GsDhjd7LRKa99T23xZR35y8fpQc6ZpK61OV fDN8+cDyn5p81t52tReUHjv8pCqDwb6DCYyW4apHyeOR6YUPiaXoGH6kARsXSmcb6Z egnm+TToF8ks2H7EGKqxjiwipXZ0yRFE3g2blztRft/18ntFEUHn+u0GbbeXx1oRk3 YuBsq5u2SV1ll661dfDxBn9Gy+2bg0KCiHFL3T4sEN92UWu/OvTogsBU4RMmFfZWSO j5fKwJksZ+yCg== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org Subject: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain Date: Wed, 4 May 2022 17:16:54 -0700 Message-Id: <20220505001656.395419-5-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio When xs_introduce_domain is called, send out a notification on the xenstore event channel so that any (dom0less) domain waiting for the xenstore interface to be ready can continue with the initialization. Before sending the notification, clear XENSTORE_RECONNECTING. The extra notification is harmless for domains that don't require it. In xs_wire.h update the commment on top of XENSTORE_RECONNECTING to generalize its meaning to suit the dom0less use-case better. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini CC: jgross@suse.com CC: anthony.perard@citrix.com CC: wl@xen.org --- If you have better suggestions for the wording in xs_wire.h please suggest! Changes in v6: - use XENSTORE_CONNECTED instead of 0x0 - update xs_wire.h Changes in v5: - reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU Changes in v2: - drop the new late_init parameter --- tools/xenstore/xenstored_domain.c | 4 ++++ xen/include/public/io/xs_wire.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index ae065fcbee..6f34af225c 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -493,6 +493,10 @@ static struct domain *introduce_domain(const void *ctx, /* Now domain belongs to its connection. */ talloc_steal(domain->conn, domain); + /* Notify the domain that xenstore is available */ + interface->connection = XENSTORE_CONNECTED; + xenevtchn_notify(xce_handle, domain->port); + if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL, false, NULL); diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h index 953a0050a3..c1ec7c73e3 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -141,7 +141,7 @@ struct xenstore_domain_interface { /* Valid values for the connection field */ #define XENSTORE_CONNECTED 0 /* the steady-state */ -#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ +#define XENSTORE_RECONNECT 1 /* reconnect in progress */ /* Valid values for the error field */ #define XENSTORE_ERROR_NONE 0 /* No error */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321177.542118 (Exim 4.92) (envelope-from ) id 1nmPB3-0008Ou-Cl; Thu, 05 May 2022 00:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321177.542118; Thu, 05 May 2022 00:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB2-0008NG-Ri; Thu, 05 May 2022 00:17:04 +0000 Received: by outflank-mailman (input) for mailman id 321177; Thu, 05 May 2022 00:17:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB1-0007ib-IB for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae2c56aa-cc08-11ec-a406-831a346695d4; Thu, 05 May 2022 02:17:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12ADEB82A2B; Thu, 5 May 2022 00:16:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E9F1C385A4; Thu, 5 May 2022 00:16:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae2c56aa-cc08-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709817; bh=ZGLKYYisUFc7rn69ZuhuAK+ygCod9wup1sfHy1UwDoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S9CFQ9zfBSPi8met1QyoP+KqA5OQ0CtJXNnOXF7M9WbALyBL45NT0DcQv3P7mavXi mcVNUCqKbsqu8QpxNGsJozUtxpUNqcdyp5To2mhVgWgTRalQrX+ktfGrXRberm+9cx b3baurQQTmE88cYdA7NNnownmSZ2TK2LWBtVERmIQt9jYJ2eZfl1Ev9VgO4Izz/4rB 7lXnPD/qaGNJhqa9a6SuHdP/FSszW04AhLGnH3Fsp+ct6XKO5w7xVZ0T1tTNX1eQBD A6y0gQEEwW0mW4eZVssa4rDfie3V12YEygEDWjfIADo0MJzYpJUKsUpZqcN1BRT6mG v79oU1bRvbVsg== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Bertrand Marquis , Luca Fancellu Subject: [PATCH v6 1/7] xen/dt: of_property_read_string return -ENODATA when !length Date: Wed, 4 May 2022 17:16:50 -0700 Message-Id: <20220505001656.395419-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini When the length of the string is zero of_property_read_string should return -ENODATA according to the description of the function. However, of_property_read_string doesn't check prop->length. If prop->length is zero, return -ENODATA. Without this patch the following command in u-boot: fdt set /chosen/node property-name results in of_property_read_string returning -EILSEQ when attempting to read property-name. With this patch, it returns -ENODATA as expected. This commit is a backport of: https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@kernel.org/ Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Reviewed-by: Luca Fancellu --- Changes in v5: - backport from Linux --- xen/common/device_tree.c | 2 +- xen/include/xen/device_tree.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..0e8798bd24 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -198,7 +198,7 @@ int dt_property_read_string(const struct dt_device_node *np, if ( !pp ) return -EINVAL; - if ( !pp->value ) + if ( !pp->length ) return -ENODATA; if ( strnlen(pp->value, pp->length) >= pp->length ) return -EILSEQ; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index fd6cd00b43..430a1ef445 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -451,6 +451,9 @@ static inline bool_t dt_property_read_bool(const struct dt_device_node *np, * doest not have value, and -EILSEQ if the string is not * null-terminated with the length of the property data. * + * Note that the empty string "" has length of 1, thus -ENODATA cannot + * be interpreted as an empty string. + * * The out_string pointer is modified only if a valid string can be decoded. */ int dt_property_read_string(const struct dt_device_node *np, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321178.542125 (Exim 4.92) (envelope-from ) id 1nmPB4-0000Bw-Jm; Thu, 05 May 2022 00:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321178.542125; Thu, 05 May 2022 00:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB4-00008o-9N; Thu, 05 May 2022 00:17:06 +0000 Received: by outflank-mailman (input) for mailman id 321178; Thu, 05 May 2022 00:17:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB2-0007pt-Eu for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afaa955e-cc08-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 02:17:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C526B61D54; Thu, 5 May 2022 00:17:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE3A7C385AF; Thu, 5 May 2022 00:17:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afaa955e-cc08-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709821; bh=22bdOt6XvBV3vZtPeEaCTfB0bw/G2RA4hDJ9uoEjSFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m4sfZKihHvArayriNCGoTIgtef6y1iMvURwOYyCteNAhVfmP39wW9p+FgVExSZF0/ ojrrvZPEKv34/HnQQDAUxl30cLS5gT1U120D4lXjW73osEmVkisYjQGzRRSnvBPP0+ 15PRbfYz2gFizytWchwxCW2fCJ/x+l+iwxLV4Czu7/I1T4mYM5GpIWvQ6t3sCDN6X0 9RkffTyiBR5eb1p9NgcTXVR4IJg5Ca5ATeLyM9xjJ359luLgecy+qPfM76eSfqiQKk DoaNyGFCO8bZOhIxN59eywz8smmRV+ClqxxmbQBCMZvd5irh/H6RWXBBH5r3Mm9EY4 FXMOhRpr/5mMA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu Subject: [PATCH v6 7/7] docs: document dom0less + PV drivers Date: Wed, 4 May 2022 17:16:56 -0700 Message-Id: <20220505001656.395419-7-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Document how to use the feature and how the implementation works. Signed-off-by: Stefano Stabellini Reviewed-by: Luca Fancellu --- docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc index c9edb529e1..725afa0558 100644 --- a/docs/features/dom0less.pandoc +++ b/docs/features/dom0less.pandoc @@ -90,6 +90,46 @@ Otherwise, they may be unusable in Xen (for instance if they are compressed). See docs/misc/arm/device-tree/booting.txt for more information. +PV Drivers +---------- + +It is possible to use PV drivers with dom0less guests with some +restrictions: + +- dom0less domUs that want to use PV drivers support should have the + "xen,enhanced" property set under their device tree nodes (see + docs/misc/arm/device-tree/booting.txt) +- a dom0 must be present (or another domain with enough privileges to + run the toolstack) +- after dom0 is booted, the utility "init-dom0less" must be run +- do not run "init-dom0less" while creating other guests with xl + +After the execution of init-dom0less, it is possible to use "xl" to +hotplug PV drivers to dom0less guests. E.g. xl network-attach domU. + +The implementation works as follows: +- Xen allocates the xenstore event channel for each dom0less domU that + has the "xen,enhanced" property, and sets HVM_PARAM_STORE_EVTCHN +- Xen does *not* allocate the xenstore page and sets HVM_PARAM_STORE_PFN + to ~0ULL (invalid) +- Dom0less domU kernels check that HVM_PARAM_STORE_PFN is set to invalid + - Old kernels will continue without xenstore support (Note: some old + buggy kernels might crash because they don't check the validity of + HVM_PARAM_STORE_PFN before using it! Disable "xen,enhanced" in + those cases) + - New kernels will wait for a notification on the xenstore event + channel (HVM_PARAM_STORE_EVTCHN) before continuing with the + initialization +- Once dom0 is booted, init-dom0less is executed: + - it allocates the xenstore shared page and sets HVM_PARAM_STORE_PFN + - it calls xs_introduce_domain +- Xenstored notices the new domain, initializes interfaces as usual, and + sends an event channel notification to the domain using the xenstore + event channel (HVM_PARAM_STORE_EVTCHN) +- The Linux domU kernel receives the event channel notification, checks + HVM_PARAM_STORE_PFN again and continue with the initialization + + Limitations ----------- @@ -107,9 +147,6 @@ limitations: information, the GIC version exposed to the domains started by Xen at boot is the same as the native GIC version. -- No PV drivers. There is no support for PV devices at the moment. All - devices need to be statically assigned to guests. - - Pinning vCPUs of domains started by Xen at boot can be done from the control domain, using `xl vcpu-pin` as usual. It is not currently possible to configure vCPU pinning without a control domain. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321179.542133 (Exim 4.92) (envelope-from ) id 1nmPB5-0000KZ-Cw; Thu, 05 May 2022 00:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321179.542133; Thu, 05 May 2022 00:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB5-0000Hm-08; Thu, 05 May 2022 00:17:07 +0000 Received: by outflank-mailman (input) for mailman id 321179; Thu, 05 May 2022 00:17:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB2-0007ib-IW for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae66ea89-cc08-11ec-a406-831a346695d4; Thu, 05 May 2022 02:17:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6C5F61D46; Thu, 5 May 2022 00:16:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B62C385B2; Thu, 5 May 2022 00:16:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae66ea89-cc08-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709819; bh=E9MSaccIsafpyB3w94QGDZQ01xMK5vlE5XQ9xApFP8Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZWuCYpHaMtY1a2m/mVJcnt9ZaoqlCQSly0zRsecEpEhEUv00xb6ysU98BpbbGmHNo mzpC1T5eGczmunbZKFCKKv1Quulp+Zb2yKj2z+fiwcVzWPCP6RCcZ3UoAFAiCyLPAz d8ey2GVFPYrXVjdFmpVgUOmYaIFBNnOM/YLB076Ca/eUDTlH4UXQW8AkNx8D6B+Z+X iTI2DvKEqMYy4AuTBH4y2j8ZerRGDL3u92wHfUU4N4Y/YUL8eLW9Ui7MiX2brKHgRo YWy6rfud5XG8LbyQgZ+mgXr0J07dgQiY8GTusa6e/ReyR7U44UWmPZ+K5Tj7r5nkPg itZEpo81JhRyg== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Bertrand Marquis , jbeulich@suse.com Subject: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Date: Wed, 4 May 2022 17:16:53 -0700 Message-Id: <20220505001656.395419-4-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio Export evtchn_alloc_unbound and make it __must_check. If "xen,enhanced" is enabled, then add to dom0less domains: - the hypervisor node in device tree - the xenstore event channel The xenstore event channel is also used for the first notification to let the guest know that xenstore has become available. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis CC: jbeulich@suse.com --- Changes in v5: - merge with "xen: export evtchn_alloc_unbound" - __must_check Changes in v3: - use evtchn_alloc_unbound Changes in v2: - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound xen: export evtchn_alloc_unbound It will be used during dom0less domains construction. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++ xen/common/event_channel.c | 2 +- xen/include/xen/event.h | 3 +++ 3 files changed, 41 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 016f56a99f..bb430f2189 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include @@ -2810,6 +2811,8 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) int ret; kinfo->phandle_gic = GUEST_PHANDLE_GIC; + kinfo->gnttab_start = GUEST_GNTTAB_BASE; + kinfo->gnttab_size = GUEST_GNTTAB_SIZE; addrcells = GUEST_ROOT_ADDRESS_CELLS; sizecells = GUEST_ROOT_SIZE_CELLS; @@ -2884,6 +2887,13 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) goto err; } + if ( kinfo->dom0less_enhanced ) + { + ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); + if ( ret ) + goto err; + } + ret = fdt_end_node(kinfo->fdt); if ( ret < 0 ) goto err; @@ -3150,6 +3160,25 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) return 0; } +static int __init alloc_xenstore_evtchn(struct domain *d) +{ + evtchn_alloc_unbound_t alloc; + int rc; + + alloc.dom = d->domain_id; + alloc.remote_dom = hardware_domain->domain_id; + rc = evtchn_alloc_unbound(&alloc); + if ( rc ) + { + printk("Failed allocating event channel for domain\n"); + return rc; + } + + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; + + return 0; +} + static int __init construct_domU(struct domain *d, const struct dt_device_node *node) { @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, if ( rc < 0 ) return rc; + if ( kinfo.dom0less_enhanced ) + { + rc = alloc_xenstore_evtchn(d); + if ( rc < 0 ) + return rc; + d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; + } + return rc; } diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 0a82eb3ac2..e60cd98d75 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -290,7 +290,7 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } -static int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; struct domain *d; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index 21c95e14fd..f3021fe304 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn); /* Allocate a specific event channel port. */ int evtchn_allocate_port(struct domain *d, unsigned int port); +/* Allocate a new event channel */ +int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc); + /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:17:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321180.542139 (Exim 4.92) (envelope-from ) id 1nmPB6-0000Wf-7Y; Thu, 05 May 2022 00:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321180.542139; Thu, 05 May 2022 00:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB5-0000Us-Rq; Thu, 05 May 2022 00:17:07 +0000 Received: by outflank-mailman (input) for mailman id 321180; Thu, 05 May 2022 00:17:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPB3-0007ib-Ii for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:17:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af68623d-cc08-11ec-a406-831a346695d4; Thu, 05 May 2022 02:17:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51DE761D53; Thu, 5 May 2022 00:17:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 459E8C385A4; Thu, 5 May 2022 00:17:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af68623d-cc08-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651709820; bh=/N68VmzRvwvpluFCprOhDNpEgtNIdxYSilGj4T1UcRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lPKsmPT0fgZXnVdDg8bMTvjs8MDSJYA4qjPV6kUk8WP6P4hA4vU+d0S5yBKq+jYOi tAIWS+ZTnjcoTg+I7PMcBpI7oF7cjwdOatfNQMyijnLscfVcKuugmSNXEzuh6/CIoB 3QYu8GFnNLG51ZddkOmPz1M8iQRwLFjqwHyvmAeJ0SqcuXX4bfKWOI0akAE6J1jXyA xr4Hbxs/O00P7g32u4dvLczoM8xyPlUYl1lKe8HHnlq65p52Hs83oovvr60NSuQqmg +9nQWg6hyT6RZY8j6Gfuvs2Xq3k2mZdVlVhvgB8mr0fRo0pMukvlBuS8boEjwkwcxv RiEaaxAyG2xDQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers Date: Wed, 4 May 2022 17:16:55 -0700 Message-Id: <20220505001656.395419-6-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio Add an example application that can be run in dom0 to complete the dom0less domains initialization so that they can get access to xenstore and use PV drivers. The application sets "connection" to XENSTORE_RECONNECT on the xenstore page before calling xs_introduce_domain to signal that the connection is not ready yet to be used. XENSTORE_RECONNECT is reset soon after by xenstored. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross --- Changes in v6: - include xs_wire.h and use its definitions Changes in v5: - set XS_CONNECTION_STATE_RECONNECTING before xs_introduce_domain Changes in v4: - only alloc xs page (no other magic pages) - add xenstore permissions - check all return values - rename restore_xenstore to create_xenstore - set target_memkb - set start_time properly - close xs transaction on error - call xc_dom_gnttab_seed instead of xc_dom_gnttab_init - xs_open instead of xs_daemon_open Changes in v3: - handle xenstore errors - add an in-code comment about xenstore entries - less verbose output - clean-up error path in main Changes in v2: - do not set HVM_PARAM_STORE_EVTCHN twice - rename restore_xenstore to create_xenstore - increase maxmem connection reconnecting --- tools/helpers/Makefile | 13 ++ tools/helpers/init-dom0less.c | 340 ++++++++++++++++++++++++++++++++++ 2 files changed, 353 insertions(+) create mode 100644 tools/helpers/init-dom0less.c diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 7f6c422440..8d78ab1e90 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y) ifeq ($(CONFIG_X86),y) PROGS += init-xenstore-domain endif +ifeq ($(CONFIG_ARM),y) +PROGS += init-dom0less +endif endif XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o @@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h +INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn) + .PHONY: all all: $(PROGS) @@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS) init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) +init-dom0less: $(INIT_DOM0LESS_OBJS) + $(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) + .PHONY: install install: all $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c new file mode 100644 index 0000000000..bfd5ff0761 --- /dev/null +++ b/tools/helpers/init-dom0less.c @@ -0,0 +1,340 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "init-dom-json.h" + +#define XENSTORE_PFN_OFFSET 1 +#define STR_MAX_LENGTH 64 + +static int alloc_xs_page(struct xc_interface_core *xch, + libxl_dominfo *info, + uint64_t *xenstore_pfn) +{ + int rc; + const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT; + xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET; + + rc = xc_domain_setmaxmem(xch, info->domid, + info->max_memkb + (XC_PAGE_SIZE/1024)); + if (rc < 0) + return rc; + + rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m); + if (rc < 0) + return rc; + + *xenstore_pfn = base + XENSTORE_PFN_OFFSET; + rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn); + if (rc < 0) + return rc; + + return 0; +} + +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, + domid_t domid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + struct xs_permissions perms[2]; + + perms[0].id = domid; + perms[0].perms = XS_PERM_NONE; + perms[1].id = 0; + perms[1].perms = XS_PERM_READ; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/local/domain/%u/%s", domid, path) < 0) + return false; + if (!xs_write(xsh, t, full_path, val, strlen(val))) + return false; + return xs_set_permissions(xsh, t, full_path, perms, 2); +} + +static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t, + domid_t domid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/libxl/%u/%s", domid, path) < 0) + return false; + return xs_write(xsh, t, full_path, val, strlen(val)); +} + +static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t, + libxl_uuid uuid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0) + return false; + return xs_write(xsh, t, full_path, val, strlen(val)); +} + +/* + * The xenstore nodes are the xenstore nodes libxl writes at domain + * creation. + * + * The list was retrieved by running xenstore-ls on a corresponding + * domain started by xl/libxl. + */ +static int create_xenstore(struct xs_handle *xsh, + libxl_dominfo *info, libxl_uuid uuid, + evtchn_port_t xenstore_port) +{ + domid_t domid; + unsigned int i; + char uuid_str[STR_MAX_LENGTH]; + char dom_name_str[STR_MAX_LENGTH]; + char vm_val_str[STR_MAX_LENGTH]; + char id_str[STR_MAX_LENGTH]; + char max_memkb_str[STR_MAX_LENGTH]; + char target_memkb_str[STR_MAX_LENGTH]; + char cpu_str[STR_MAX_LENGTH]; + char xenstore_port_str[STR_MAX_LENGTH]; + char ring_ref_str[STR_MAX_LENGTH]; + xs_transaction_t t; + struct timeval start_time; + char start_time_str[STR_MAX_LENGTH]; + int rc; + + if (gettimeofday(&start_time, NULL) < 0) + return -errno; + rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d", + (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000); + if (rc < 0) + return rc; + + domid = info->domid; + rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid); + if (rc < 0) + return rc; + rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid); + if (rc < 0) + return rc; + rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); + if (rc < 0) + return rc; + rc = snprintf(vm_val_str, STR_MAX_LENGTH, + "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); + if (rc < 0) + return rc; + rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb); + if (rc < 0) + return rc; + rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb); + if (rc < 0) + return rc; + rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET); + if (rc < 0) + return rc; + rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port); + if (rc < 0) + return rc; + +retry_transaction: + t = xs_transaction_start(xsh); + if (t == XBT_NULL) + return -errno; + + rc = -EIO; + /* /vm */ + if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err; + if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err; + if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto err; + + /* /domain */ + if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err; + for (i = 0; i < info->vcpu_max_id; i++) { + rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i); + if (rc < 0) + goto err; + rc = -EIO; + if (!do_xs_write_dom(xsh, t, domid, cpu_str, + (info->cpupool & (1 << i)) ? "online" : "offline")) + goto err; + } + + if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", max_memkb_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", "")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-multiprocessor-suspend", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-xs_reset_watches", "1")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) goto err; + + if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err; + if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto err; + + if (!xs_transaction_end(xsh, t, false)) { + if (errno == EAGAIN) + goto retry_transaction; + else + return -errno; + } + + return 0; + +err: + xs_transaction_end(xsh, t, true); + return rc; +} + +static int init_domain(struct xs_handle *xsh, + struct xc_interface_core *xch, + xenforeignmemory_handle *xfh, + libxl_dominfo *info) +{ + libxl_uuid uuid; + uint64_t xenstore_evtchn, xenstore_pfn; + int rc; + struct xenstore_domain_interface *intf; + + printf("Init dom0less domain: %u\n", info->domid); + + rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN, + &xenstore_evtchn); + if (rc != 0) { + printf("Failed to get HVM_PARAM_STORE_EVTCHN\n"); + return 1; + } + + /* Alloc xenstore page */ + if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) { + printf("Error on alloc magic pages\n"); + return 1; + } + + intf = xenforeignmemory_map(xfh, info->domid, XS_READ | XS_WRITE, 1, + &xenstore_pfn, NULL); + if (!intf) { + printf("Error mapping xenstore page\n"); + return 1; + } + intf->connection = XENSTORE_RECONNECT; + xenforeignmemory_unmap(xfh, intf, 1); + + rc = xc_dom_gnttab_seed(xch, info->domid, true, + (xen_pfn_t)-1, xenstore_pfn, 0, 0); + if (rc) + err(1, "xc_dom_gnttab_seed"); + + libxl_uuid_generate(&uuid); + xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); + + rc = gen_stub_json_config(info->domid, &uuid); + if (rc) + err(1, "gen_stub_json_config"); + + /* Now everything is ready: set HVM_PARAM_STORE_PFN */ + rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN, + xenstore_pfn); + if (rc < 0) + return rc; + + rc = create_xenstore(xsh, info, uuid, xenstore_evtchn); + if (rc) + err(1, "writing to xenstore"); + + rc = xs_introduce_domain(xsh, info->domid, + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, + xenstore_evtchn); + if (!rc) + err(1, "xs_introduce_domain"); + return 0; +} + +/* Check if domain has been configured in XS */ +static bool domain_exists(struct xs_handle *xsh, int domid) +{ + return xs_is_domain_introduced(xsh, domid); +} + +int main(int argc, char **argv) +{ + libxl_dominfo *info = NULL; + libxl_ctx *ctx; + int nb_vm = 0, rc = 0, i; + struct xs_handle *xsh = NULL; + struct xc_interface_core *xch = NULL; + xenforeignmemory_handle *xfh = NULL; + + /* TODO reuse libxl xsh connection */ + xsh = xs_open(0); + xch = xc_interface_open(0, 0, 0); + xfh = xenforeignmemory_open(0, 0); + if (xsh == NULL || xch == NULL || xfh == NULL) { + fprintf(stderr, "Cannot open xc/xs/xenforeignmemory interfaces"); + rc = -errno; + goto out; + } + + rc = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, NULL); + if (rc) { + fprintf(stderr, "cannot init xl context\n"); + goto out; + } + + info = libxl_list_domain(ctx, &nb_vm); + if (!info) { + fprintf(stderr, "libxl_list_vm failed.\n"); + rc = -1; + goto out; + } + + for (i = 0; i < nb_vm; i++) { + domid_t domid = info[i].domid; + + /* Don't need to check for Dom0 */ + if (!domid) + continue; + + printf("Checking domid: %u\n", domid); + if (!domain_exists(xsh, domid)) { + rc = init_domain(xsh, xch, xfh, &info[i]); + if (rc < 0) { + fprintf(stderr, "init_domain failed.\n"); + goto out; + } + } else { + printf("Domain %u has already been initialized\n", domid); + } + } +out: + libxl_dominfo_list_free(info, nb_vm); + return rc; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:23:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:23:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321227.542169 (Exim 4.92) (envelope-from ) id 1nmPGo-0004XT-NM; Thu, 05 May 2022 00:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321227.542169; Thu, 05 May 2022 00:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGo-0004XM-Jg; Thu, 05 May 2022 00:23:02 +0000 Received: by outflank-mailman (input) for mailman id 321227; Thu, 05 May 2022 00:23:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGn-0004XG-KL for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:23:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84e02bce-cc09-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 02:23:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C9BF61D44; Thu, 5 May 2022 00:22:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF7DC385A5; Thu, 5 May 2022 00:22:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84e02bce-cc09-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651710178; bh=U4s8K8JX60MK1mxVftNipKeg5x2+caAQ29BNBAA5GYI=; h=Date:From:To:cc:Subject:From; b=fi4dbKRA3J16t17yLEvfa2T2sL3n6bzADOIwKYxw3mOhEw6xqDj/ICkHuYDobfI0f hH068OeiTbH6tQv/tdFy4ud89Gf4eTGnS/FiJ/KyhELM5mjubbAovtO+2ptKUuh7LE wjAQArVTnAk2I5TpDmCJnoAOXGkQeDH94Rzbq7b2W0zG/eV/8kH+KL67lKYpZXgO46 e5J+jnQvfYxpbpg5vnP99IxKZmZi6CnjluSvWBWLqSiMoTyWVyOc5ErXXlP4qmvFuI g5X5nRrCXSS1ZbcgKhDqOfkL815Ye7LUh5rbrCKqdlOixka669uf8R451V2GK+QMTF 6fAn9fv1oyjbg== Date: Wed, 4 May 2022 17:22:58 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: boris.ostrovsky@oracle.com, jgross@suse.com cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH LINUX 0/2] dom0less + PV drivers Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This small Linux patch series implements support for initializing xenstore later, if not immediately available at boot time. It enables dom0less + PV drivers support. Luca Miccio (1): xen: add support for initializing xenstore later as HVM domain Stefano Stabellini (1): xen: sync xs_wire.h header with upstream xen drivers/xen/xenbus/xenbus_probe.c | 91 +++++++++++++++++++++++++++++--------- include/xen/interface/io/xs_wire.h | 34 ++++++++++++-- 2 files changed, 102 insertions(+), 23 deletions(-) From xen-devel-bounces@lists.xenproject.org Thu May 05 00:23:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321228.542180 (Exim 4.92) (envelope-from ) id 1nmPGw-0004qS-2y; Thu, 05 May 2022 00:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321228.542180; Thu, 05 May 2022 00:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGv-0004qL-Vc; Thu, 05 May 2022 00:23:09 +0000 Received: by outflank-mailman (input) for mailman id 321228; Thu, 05 May 2022 00:23:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGu-0004pS-NF for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:23:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 890976fb-cc09-11ec-a406-831a346695d4; Thu, 05 May 2022 02:23:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84DB761D47; Thu, 5 May 2022 00:23:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9000C385A5; Thu, 5 May 2022 00:23:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 890976fb-cc09-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651710185; bh=HFLLzAtqSAhevBTNCZk3OMTL3poJMeEW0dWOHMZLBNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BQp06t9UrtZbQwSSdyMAde3poqr3W4rwIegP9HDgHxNqJwYhUJclsMyS7/BSekUYN eMLtojNJl4Gl+cxR2pHBW++i9NV6nEO4TIBpp3NBTcq+h8T4qq3VixHHkRIUl0JY/B xE8gD9+bHb5Yx6gOQA0xmQS3Y10kx5vu74flOWV4OCyO5VYcdfXSYCYJMtBeK5Stko Cb8keVZzu9OWU955B6ZfAPvyYdPa4zI4tyzVCJebjcZ1jvtyMiaj3JfZ6SPB2YoCt7 al93Oe2uPdGzBU1l3hSUy8gvyJVHXv/xmAwFO5cQgrxFKyrZ5xFlZzxKdm94jzRFFv bscsu/OK1DzQA== From: Stefano Stabellini To: boris.ostrovsky@oracle.com, jgross@suse.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen Date: Wed, 4 May 2022 17:23:03 -0700 Message-Id: <20220505002304.401417-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Sync the xs_wire.h header file in Linux with the one in Xen. Signed-off-by: Stefano Stabellini --- include/xen/interface/io/xs_wire.h | 34 +++++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/include/xen/interface/io/xs_wire.h b/include/xen/interface/io/xs_wire.h index d40a44f09b16..04dca77abc45 100644 --- a/include/xen/interface/io/xs_wire.h +++ b/include/xen/interface/io/xs_wire.h @@ -10,7 +10,8 @@ enum xsd_sockmsg_type { - XS_DEBUG, + XS_CONTROL, +#define XS_DEBUG XS_CONTROL XS_DIRECTORY, XS_READ, XS_GET_PERMS, @@ -30,8 +31,13 @@ enum xsd_sockmsg_type XS_IS_DOMAIN_INTRODUCED, XS_RESUME, XS_SET_TARGET, - XS_RESTRICT, - XS_RESET_WATCHES, + /* XS_RESTRICT has been removed */ + XS_RESET_WATCHES = XS_SET_TARGET + 2, + XS_DIRECTORY_PART, + + XS_TYPE_COUNT, /* Number of valid types. */ + + XS_INVALID = 0xffff /* Guaranteed to remain an invalid type */ }; #define XS_WRITE_NONE "NONE" @@ -87,9 +93,31 @@ struct xenstore_domain_interface { char rsp[XENSTORE_RING_SIZE]; /* Replies and async watch events. */ XENSTORE_RING_IDX req_cons, req_prod; XENSTORE_RING_IDX rsp_cons, rsp_prod; + uint32_t server_features; /* Bitmap of features supported by the server */ + uint32_t connection; + uint32_t error; }; /* Violating this is very bad. See docs/misc/xenstore.txt. */ #define XENSTORE_PAYLOAD_MAX 4096 +/* Violating these just gets you an error back */ +#define XENSTORE_ABS_PATH_MAX 3072 +#define XENSTORE_REL_PATH_MAX 2048 + +/* The ability to reconnect a ring */ +#define XENSTORE_SERVER_FEATURE_RECONNECTION 1 +/* The presence of the "error" field in the ring page */ +#define XENSTORE_SERVER_FEATURE_ERROR 2 + +/* Valid values for the connection field */ +#define XENSTORE_CONNECTED 0 /* the steady-state */ +#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ + +/* Valid values for the error field */ +#define XENSTORE_ERROR_NONE 0 /* No error */ +#define XENSTORE_ERROR_COMM 1 /* Communication problem */ +#define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */ +#define XENSTORE_ERROR_PROTO 3 /* Protocol violation (payload too long) */ + #endif /* _XS_WIRE_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:23:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321229.542185 (Exim 4.92) (envelope-from ) id 1nmPGw-0004u0-Ig; Thu, 05 May 2022 00:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321229.542185; Thu, 05 May 2022 00:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGw-0004t7-AQ; Thu, 05 May 2022 00:23:10 +0000 Received: by outflank-mailman (input) for mailman id 321229; Thu, 05 May 2022 00:23:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPGv-0004pS-Fc for xen-devel@lists.xenproject.org; Thu, 05 May 2022 00:23:09 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a0f85db-cc09-11ec-a406-831a346695d4; Thu, 05 May 2022 02:23:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3698B81AF2; Thu, 5 May 2022 00:23:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DA06C385AA; Thu, 5 May 2022 00:23:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a0f85db-cc09-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651710186; bh=jzqqLYPIU8TZVMVWEtLKqhjo+o2vN0T5c9gjvg8DczU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJa8DW7x8TN40d7joD6W/6C38az0F/jRNXIG9CyyceJoYItNDMBkl/DLsFfNuMcHx W/PdfvS8c3bz38cQ1/kmOwFfWAwj+n0+udfAz0cM4edtjbKTzokjxAylNe6I9l7Ldz qdcQYqUu2tpZqNsWW50xItFPHBO0OFSPssK6J+YDzsLfzXDo5d/mJ+ZlOSE1YPvH0s MLG354Hq3fNC5C82yNKsrSfI9QjMUi/dsjOpC6CeJNvTnvdKUmtK3nMV/fRbHGnFR4 UvqmWgplAO57Xl3tkdr+6LwlTXRieCQWwauYMHO60qczyOYwhVZdTTisjpJlmQqUMG yyag0n/GHQtaQ== From: Stefano Stabellini To: boris.ostrovsky@oracle.com, jgross@suse.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini Subject: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Date: Wed, 4 May 2022 17:23:04 -0700 Message-Id: <20220505002304.401417-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio When running as dom0less guest (HVM domain on ARM) the xenstore event channel is available at domain creation but the shared xenstore interface page only becomes available later on. In that case, wait for a notification on the xenstore event channel, then complete the xenstore initialization later, when the shared page is actually available. The xenstore page has few extra field. Add them to the shared struct. One of the field is "connection", when the connection is ready, it is zero. If the connection is not-zero, wait for a notification. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini --- Changes in v4: - improve in-code comments - move header sync to separate patch - use XENSTORE_CONNECTED Changes in v3: - check for the connection field, if it is not zero, wait for event Changes in v2: - remove XENFEAT_xenstore_late_init --- drivers/xen/xenbus/xenbus_probe.c | 91 ++++++++++++++++++++++++------- 1 file changed, 71 insertions(+), 20 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index fe360c33ce71..0a785d5e3e40 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -65,6 +65,7 @@ #include "xenbus.h" +static int xs_init_irq; int xen_store_evtchn; EXPORT_SYMBOL_GPL(xen_store_evtchn); @@ -750,6 +751,20 @@ static void xenbus_probe(void) { xenstored_ready = 1; + if (!xen_store_interface) { + xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE); + /* + * Now it is safe to free the IRQ used for xenstore late + * initialization. No need to unbind: it is about to be + * bound again from xb_init_comms. Note that calling + * unbind_from_irqhandler now would result in xen_evtchn_close() + * being called and the event channel not being enabled again + * afterwards, resulting in missed event notifications. + */ + free_irq(xs_init_irq, &xb_waitq); + } + /* * In the HVM case, xenbus_init() deferred its call to * xs_init() in case callbacks were not operational yet. @@ -798,20 +813,22 @@ static int __init xenbus_probe_initcall(void) { /* * Probe XenBus here in the XS_PV case, and also XS_HVM unless we - * need to wait for the platform PCI device to come up. + * need to wait for the platform PCI device to come up or + * xen_store_interface is not ready. */ if (xen_store_domain_type == XS_PV || (xen_store_domain_type == XS_HVM && - !xs_hvm_defer_init_for_callback())) + !xs_hvm_defer_init_for_callback() && + xen_store_interface != NULL)) xenbus_probe(); /* - * For XS_LOCAL, spawn a thread which will wait for xenstored - * or a xenstore-stubdom to be started, then probe. It will be - * triggered when communication starts happening, by waiting - * on xb_waitq. + * For XS_LOCAL or when xen_store_interface is not ready, spawn a + * thread which will wait for xenstored or a xenstore-stubdom to be + * started, then probe. It will be triggered when communication + * starts happening, by waiting on xb_waitq. */ - if (xen_store_domain_type == XS_LOCAL) { + if (xen_store_domain_type == XS_LOCAL || xen_store_interface == NULL) { struct task_struct *probe_task; probe_task = kthread_run(xenbus_probe_thread, NULL, @@ -907,10 +924,25 @@ static struct notifier_block xenbus_resume_nb = { .notifier_call = xenbus_resume_cb, }; +static irqreturn_t xenbus_late_init(int irq, void *unused) +{ + int err = 0; + uint64_t v = 0; + + err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v); + if (err || !v || !~v) + return IRQ_HANDLED; + xen_store_gfn = (unsigned long)v; + + wake_up(&xb_waitq); + return IRQ_HANDLED; +} + static int __init xenbus_init(void) { int err; uint64_t v = 0; + bool wait = false; xen_store_domain_type = XS_UNKNOWN; if (!xen_domain()) @@ -957,25 +989,44 @@ static int __init xenbus_init(void) * been properly initialized. Instead of attempting to map a * wrong guest physical address return error. * - * Also recognize all bits set as an invalid value. + * Also recognize all bits set as an invalid/uninitialized value. */ - if (!v || !~v) { + if (!v) { err = -ENOENT; goto out_error; } - /* Avoid truncation on 32-bit. */ + if (v == ~0ULL) { + wait = true; + } else { + /* Avoid truncation on 32-bit. */ #if BITS_PER_LONG == 32 - if (v > ULONG_MAX) { - pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", - __func__, v); - err = -EINVAL; - goto out_error; - } + if (v > ULONG_MAX) { + pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", + __func__, v); + err = -EINVAL; + goto out_error; + } #endif - xen_store_gfn = (unsigned long)v; - xen_store_interface = - xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, - XEN_PAGE_SIZE); + xen_store_gfn = (unsigned long)v; + xen_store_interface = + xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE); + if (xen_store_interface->connection != XENSTORE_CONNECTED) + wait = true; + } + if (wait) { + err = bind_evtchn_to_irqhandler(xen_store_evtchn, + xenbus_late_init, + 0, "xenstore_late_init", + &xb_waitq); + if (err < 0) { + pr_err("xenstore_late_init couldn't bind irq err=%d\n", + err); + return err; + } + + xs_init_irq = err; + } break; default: pr_warn("Xenstore state unknown\n"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 00:31:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321249.542208 (Exim 4.92) (envelope-from ) id 1nmPOd-0007Be-J4; Thu, 05 May 2022 00:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321249.542208; Thu, 05 May 2022 00:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPOd-0007BX-FG; Thu, 05 May 2022 00:31:07 +0000 Received: by outflank-mailman (input) for mailman id 321249; Thu, 05 May 2022 00:31:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPOb-0007BN-NS; Thu, 05 May 2022 00:31:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPOb-0001Q7-Jk; Thu, 05 May 2022 00:31:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPOb-00018O-6i; Thu, 05 May 2022 00:31:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmPOb-0001YR-6H; Thu, 05 May 2022 00:31:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6p1uGqqK1BZIPKFj4MuuzRZvd+GUDvAocdSjn27uH7A=; b=Z8WhEu3BC4Bt4jOtgpb2B7qZxz SPWMsFx++eD8hxThXrIQMTCEn0a0/twt3cTuSRlRV4SSuu7pUiry6xmU+n6QUiXh2+2fQCeKHl6M8 yW4GYxTuTrwv4OZWk1Lxfc1PxmQSSBTCrIYBGYNg7IV9X9e0ZZ+wggx0ugJfDxfAdcrg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170110: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9cf289af47bcfae5c75de37d8e5d6fd23705322c X-Osstest-Versions-That: qemuu=2e3408b3cc7de4e87a9adafc8c19bfce3abec947 From: osstest service owner Date: Thu, 05 May 2022 00:31:05 +0000 flight 170110 qemu-mainline real [real] flight 170123 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170110/ http://logs.test-lab.xenproject.org/osstest/logs/170123/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 170123-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 170123 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 170123 never pass test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 170064 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170064 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170064 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170064 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170064 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170064 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170064 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170064 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170064 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 9cf289af47bcfae5c75de37d8e5d6fd23705322c baseline version: qemuu 2e3408b3cc7de4e87a9adafc8c19bfce3abec947 Last test of basis 170064 2022-05-03 23:09:37 Z 1 days Testing same since 170110 2022-05-04 15:38:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Deason Richard Henderson zhenwei pi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2e3408b3cc..9cf289af47 9cf289af47bcfae5c75de37d8e5d6fd23705322c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 05 00:32:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 00:32:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321258.542219 (Exim 4.92) (envelope-from ) id 1nmPPv-0007pG-8D; Thu, 05 May 2022 00:32:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321258.542219; Thu, 05 May 2022 00:32:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPPv-0007p9-41; Thu, 05 May 2022 00:32:27 +0000 Received: by outflank-mailman (input) for mailman id 321258; Thu, 05 May 2022 00:32:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPPu-0007oz-7w; Thu, 05 May 2022 00:32:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPPu-0001RC-71; Thu, 05 May 2022 00:32:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmPPt-0001Bk-Rt; Thu, 05 May 2022 00:32:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmPPt-0001gS-RT; Thu, 05 May 2022 00:32:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gNimB1E0fHAIJsJrV9ke889OhtMfAGk4HYZE40Q/PLg=; b=PAb+7N0HeiKmpRrlzLrwI861sx WMLER0MQHXE3gknnOmWVMu90XXxscNj7pYH3tWs7Bonq82dJrTyk8CXkSHDee42r3olXYGPppJUjW H9tbhid4ok+LK5aYv5cZ96v5eh0Pm8wNRAS3WPZx2oeASDLS7I8ayUyp3zPMx95bc+r0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170127: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 00:32:25 +0000 flight 170127 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 64 days 808 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 01:35:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 01:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321278.542236 (Exim 4.92) (envelope-from ) id 1nmQOe-0003iH-Ip; Thu, 05 May 2022 01:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321278.542236; Thu, 05 May 2022 01:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQOe-0003iA-Bw; Thu, 05 May 2022 01:35:12 +0000 Received: by outflank-mailman (input) for mailman id 321278; Thu, 05 May 2022 01:35:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQOc-0003i0-Kn; Thu, 05 May 2022 01:35:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQOc-0000Me-HS; Thu, 05 May 2022 01:35:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQOb-0002gk-LP; Thu, 05 May 2022 01:35:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmQOb-0003Wj-KA; Thu, 05 May 2022 01:35:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KZdNoaDnF39B4D+nDBOOJZzDuJ4R6FqfDlGXDRJ0uUA=; b=LDKUYuKg8dn4rD3odP9LlplBXo 0ytLvAw4b/FokyFnIGUzlljvdZ714UUYtPeDiLRK2JIbooSIWy2o/FIMJWrtiylnUTmKLVXRryC+M iHeugSwAxsrlIvrHsGIAGWRnI/c9eok33Ta8am9rJC7OLzaNL10Zd+pXJzbTeCkn2WGg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170116: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a7391ad3572431a354c927cf8896e86e50d7d0bf X-Osstest-Versions-That: linux=107c948d1d3e61d10aee9d0f7c3d81bbee9842af From: osstest service owner Date: Thu, 05 May 2022 01:35:09 +0000 flight 170116 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170116/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170072 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170072 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170072 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170072 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170072 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170072 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170072 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170072 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux a7391ad3572431a354c927cf8896e86e50d7d0bf baseline version: linux 107c948d1d3e61d10aee9d0f7c3d81bbee9842af Last test of basis 170072 2022-05-04 01:56:07 Z 0 days Testing same since 170116 2022-05-04 18:40:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ashish Mhetre Corey Minyard David Stevens Hector Martin Jan Stancek Joe Wiese Joerg Roedel Linus Torvalds Lu Baolu Nicolin Chen Pritesh Raithatha Robin Murphy Will Deacon Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 107c948d1d3e..a7391ad35724 a7391ad3572431a354c927cf8896e86e50d7d0bf -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu May 05 01:46:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 01:46:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321291.542253 (Exim 4.92) (envelope-from ) id 1nmQZJ-0001I9-37; Thu, 05 May 2022 01:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321291.542253; Thu, 05 May 2022 01:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQZI-0001I2-UE; Thu, 05 May 2022 01:46:12 +0000 Received: by outflank-mailman (input) for mailman id 321291; Thu, 05 May 2022 01:46:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQZH-0001Hs-TW; Thu, 05 May 2022 01:46:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQZH-0000YX-Sk; Thu, 05 May 2022 01:46:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmQZH-0002vf-LE; Thu, 05 May 2022 01:46:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmQZH-0008FM-Kn; Thu, 05 May 2022 01:46:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n6ERN9tZDIc9CO2reIyI2mGSDsdcJirlzbyrrMXit4g=; b=mHbRcNuchT/hJ+mb2r5LSbIMpM GdTMZL/51KHVFqbM2hVbFeld48wvdpmX5iVd1/j/M07QSLHks0o3LykT4LLVKpzHhgtvN+uep3dww IEQ3s2YSmYLKszCBC9FWu0gQ2abKYrRHQBb6XivNXbj4xk2+GgkmsHnG0ggarvlTybOo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170122: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5d2d5365ffadf075fd812038ab0841a3e868f906 X-Osstest-Versions-That: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 From: osstest service owner Date: Thu, 05 May 2022 01:46:11 +0000 flight 170122 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170122/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 5d2d5365ffadf075fd812038ab0841a3e868f906 baseline version: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Last test of basis 169982 2022-05-02 07:01:45 Z 2 days Testing same since 170122 2022-05-04 22:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jens Wiklander Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 702c9a800e..5d2d5365ff 5d2d5365ffadf075fd812038ab0841a3e868f906 -> smoke From xen-devel-bounces@lists.xenproject.org Thu May 05 02:27:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 02:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321305.542270 (Exim 4.92) (envelope-from ) id 1nmRDH-0005sF-I5; Thu, 05 May 2022 02:27:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321305.542270; Thu, 05 May 2022 02:27:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRDH-0005s8-E3; Thu, 05 May 2022 02:27:31 +0000 Received: by outflank-mailman (input) for mailman id 321305; Thu, 05 May 2022 02:27:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRDG-0005ry-CQ; Thu, 05 May 2022 02:27:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRDG-0001fw-9d; Thu, 05 May 2022 02:27:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRDF-0004jR-Vc; Thu, 05 May 2022 02:27:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmRDF-0006Oy-V9; Thu, 05 May 2022 02:27:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Bzkr9A3ZimVXSuryRb5XvrVbBgA/zxU65DPI3m2STc8=; b=LIAvWjOSLstJbZ/47GyRPZzFIS Rf5EYTmKzRDcPINx9FmLB34hCCx7ZHLyisMwDG9hm0PErZkScNnmmXOj8blVodowQMyA9+LDeYe1u HLfnPgi+JjhKswxmDbhTxNPe0AT8kEu1PnQev/3hlpx+alptfPu7HrKbxaOX4SWZehVc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170131: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 02:27:29 +0000 flight 170131 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170131/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 809 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 02:54:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 02:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321314.542281 (Exim 4.92) (envelope-from ) id 1nmRdG-0000cZ-KP; Thu, 05 May 2022 02:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321314.542281; Thu, 05 May 2022 02:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdG-0000cS-Hd; Thu, 05 May 2022 02:54:22 +0000 Received: by outflank-mailman (input) for mailman id 321314; Thu, 05 May 2022 02:54:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdF-0000cH-9s for xen-devel@lists.xenproject.org; Thu, 05 May 2022 02:54:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a89ebb83-cc1e-11ec-a406-831a346695d4; Thu, 05 May 2022 04:54:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBDDC1042; Wed, 4 May 2022 19:54:18 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 627533FA35; Wed, 4 May 2022 19:54:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a89ebb83-cc1e-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org, Julien Grall , Wei Chen Subject: [PATCH 0/2] Adjustment after introducing ASSERT_ALLOC_CONTEXT Date: Thu, 5 May 2022 10:54:05 +0800 Message-Id: <20220505025407.919988-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores on Arm will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. To solve this issue, this series introduces two patches. The first one defers the calling of request_irq on secondary CPUs after local_irq_enable on Arm. The second one moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). Henry Wang (2): xen/arm: Defer request_irq on secondary CPUs after local_irq_enable xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() xen/arch/arm/smpboot.c | 7 ++++--- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 2 +- xen/include/xen/irq.h | 7 +++++++ 4 files changed, 12 insertions(+), 11 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 02:54:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 02:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321316.542303 (Exim 4.92) (envelope-from ) id 1nmRdJ-00017c-5Q; Thu, 05 May 2022 02:54:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321316.542303; Thu, 05 May 2022 02:54:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdJ-00017V-1Y; Thu, 05 May 2022 02:54:25 +0000 Received: by outflank-mailman (input) for mailman id 321316; Thu, 05 May 2022 02:54:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdH-0000cH-RT for xen-devel@lists.xenproject.org; Thu, 05 May 2022 02:54:23 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id aab10dc1-cc1e-11ec-a406-831a346695d4; Thu, 05 May 2022 04:54:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 668881042; Wed, 4 May 2022 19:54:22 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 416D03FA35; Wed, 4 May 2022 19:54:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aab10dc1-cc1e-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org, Jan Beulich Subject: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Date: Thu, 5 May 2022 10:54:07 +0800 Message-Id: <20220505025407.919988-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505025407.919988-1-Henry.Wang@arm.com> References: <20220505025407.919988-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xmalloc() will use a pool for allocation smaller than a page. The pool is extended only when there are no more space. At which point, alloc_xenheap_pages() is called to add more memory. xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in alloc_xenheap_pages(). Hence, this commit moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67 --- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 2 +- xen/include/xen/irq.h | 7 +++++++ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e866e0d864..ea59cd1a4a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -162,13 +162,6 @@ static char __initdata opt_badpage[100] = ""; string_param("badpage", opt_badpage); -/* - * Heap allocations may need TLB flushes which may require IRQs to be - * enabled (except when only 1 PCPU is online). - */ -#define ASSERT_ALLOC_CONTEXT() \ - ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) - /* * no-bootscrub -> Free pages are not zeroed during boot. */ diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index d2ad909502..b8f838ae74 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long size, unsigned long align) { void *p = NULL; - ASSERT(!in_irq()); + ASSERT_ALLOC_CONTEXT(); if ( !size ) return ZERO_BLOCK_PTR; diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index d8beadd16b..300625e56d 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -10,6 +10,13 @@ #include #include +/* + * Heap allocations may need TLB flushes which may require IRQs to be + * enabled (except when only 1 PCPU is online). + */ +#define ASSERT_ALLOC_CONTEXT() \ + ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) + struct irqaction { void (*handler)(int, void *, struct cpu_user_regs *); const char *name; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 02:54:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 02:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321315.542286 (Exim 4.92) (envelope-from ) id 1nmRdG-0000fH-UJ; Thu, 05 May 2022 02:54:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321315.542286; Thu, 05 May 2022 02:54:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdG-0000eK-Oy; Thu, 05 May 2022 02:54:22 +0000 Received: by outflank-mailman (input) for mailman id 321315; Thu, 05 May 2022 02:54:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRdG-0000cH-BW for xen-devel@lists.xenproject.org; Thu, 05 May 2022 02:54:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a9c3d604-cc1e-11ec-a406-831a346695d4; Thu, 05 May 2022 04:54:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9E201042; Wed, 4 May 2022 19:54:20 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 51FF83FA35; Wed, 4 May 2022 19:54:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9c3d604-cc1e-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org, Julien Grall , Wei Chen Subject: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Date: Thu, 5 May 2022 10:54:06 +0800 Message-Id: <20220505025407.919988-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505025407.919988-1-Henry.Wang@arm.com> References: <20220505025407.919988-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang Change-Id: Iebdde81f52785b0c6e037c981ff68922db016d08 --- xen/arch/arm/smpboot.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7bfd0a73a7..a057e85ac1 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -361,9 +361,6 @@ void start_secondary(void) init_secondary_IRQ(); - init_maintenance_interrupt(); - init_timer_interrupt(); - set_current(idle_vcpu[cpuid]); setup_cpu_sibling_map(cpuid); @@ -380,6 +377,10 @@ void start_secondary(void) cpumask_set_cpu(cpuid, &cpu_online_map); local_irq_enable(); + + init_maintenance_interrupt(); + init_timer_interrupt(); + local_abort_enable(); check_local_cpu_errata(); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 03:06:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 03:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321345.542320 (Exim 4.92) (envelope-from ) id 1nmRoW-0003LH-DJ; Thu, 05 May 2022 03:06:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321345.542320; Thu, 05 May 2022 03:06:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRoW-0003LA-92; Thu, 05 May 2022 03:06:00 +0000 Received: by outflank-mailman (input) for mailman id 321345; Thu, 05 May 2022 03:05:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRoU-0003L4-CF for xen-devel@lists.xenproject.org; Thu, 05 May 2022 03:05:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7d00::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 480b780a-cc20-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 05:05:56 +0200 (CEST) Received: from AM6P194CA0026.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::39) by AM0PR08MB4579.eurprd08.prod.outlook.com (2603:10a6:208:108::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 03:05:54 +0000 Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::cf) by AM6P194CA0026.outlook.office365.com (2603:10a6:209:90::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 03:05:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 03:05:53 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Thu, 05 May 2022 03:05:53 +0000 Received: from 8e098e39ccc7.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91CC2C7C-1044-4C5B-8BAF-025743C9C347.1; Thu, 05 May 2022 03:05:48 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e098e39ccc7.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 03:05:48 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB6065.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 03:05:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c%7]) with mapi id 15.20.5144.027; Thu, 5 May 2022 03:05:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 480b780a-cc20-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m2MZ48G32ypJ89kPfrkYzTha0YP5d3dbkZlumJCuhSWA85z49e42l3aTHOC95DDb32m8EkAgJxtD9aumssaClWrx1HIGsWwX2Y9Iw09PULPMHnHkkendBur9nVIm+SNyT1ymrK1KjHS6lDmChkaE8M1KWJGChWUqd0E3fzOMf0tKWwV9gGgj6TifZQDcAj5q5/IcF3NxzCSBfDmwGsiScojTqxC+PEBCGy1227Rh1qMlfJE+HXJWJS100vbNHVUDJjiHf7JUBQLQDq8u2do0w2FTPlM8lG6v1VPyLWfuhos0jbQEkwPSoV6kvaZ4I0T8vr+EUJhdIxQz8ywNpWW2Hw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=I0j03R+tV65Hwx0e19Ya9TItyB+GKaFIQLipl5krm3JOdX5GAsYAEcKK6qKUWpnX0aJExQEbz3VuH7Hf9j0CvijuhwtcxLh3AQLqdNo7gSxTaguWLrcWj5IJiTp9OEnRdc8DEXOKnEds35qrk73gdln00msA6E06vYpb96Qv2vVxKSO9FfEwGqEKTBNmA+9Ri2IQ6Z7DImjWIo/m+0AExnyfVDIxRkcY3mhq4jhTXsi52PE2G2BLyp3Tp6WFILFlRM+LXASxMmLXJ3BAASa057TlRzjWzhBU0mZQsEgaKQ/9aTokF/M4KftfSrdPaeQdupXv/PFANxe74O7DXZnjuQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=8WTP8A/pUzhhLwwHcmOv8Wvl2Xr+br+45o4DlmBPi5ZCWH9Aa6m2ln/7HDhuNRoqXDyVcX6CqqR59xJdGMKfeyTyAqPDESS8QwP6hbnhFH2pzoFw48a7gjXzZTYDVboWSAkfnQqJkHEFbiOcZRQDN8lWBWM3kKAWuuS4VtRKgbU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KwfvWC51KH88JCmWExVWOz8polrWWg48wDeuoDIWJMlYx3Uaglb7G0ytbjotQ+DEOFvhIGvpBYC18KjMNaKYYrI8adyYkA5LEVdEWbgpCgdC7GNSOnarG9t3AvpN+/sJKtg+Ab13SIB1j+JdYQDhIPAVDpTujRV2ySczG8NNSHsH3qd12x+6CLNIppnOhNvVMN6aBlPET+L8Bld8mKLxv9U0pEDhuSz6dC8c95MRyKPbewymm/Ed4gpBLSbmae0SvMcn1DBoxMySTpdbKFbI6QTgvdF4U1EXYIExfyE6bf4wH6aXjMsz/bOoMWmwtUDMOqS4bwl2R/TA/0F1xRrT4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=N9f9XISvJut/gyfeL0c9oW00vSdTJOcLrwuKUgtJ8RL+TNlcjI0oYwY/Gu5+vPZsn/Td6sj55c8JQt7GhzQwy4VFPzfxqI3Ag+xBrs27bMIuheAJqrXbmiit/OZyQNwTjY9BIa3A8RX814Tlsu3b+aF0t/4rYTRJvMygwGyZsjBYkgtVHzabAz+nZkBmhvTG3HFY0pyTZ9P1WTXdMtdnYl2CIZ3lb3gUeUlaPN82z7+AL7/3bhZfHVU004dWQqRCneRJdv5/CMGRfvJO+bP9wrum0tPRBIClby7r+elGRE8aJvEw4Eedt4b7P+7uLmRwiy//lGjJYNSybdZRWSdmdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=8WTP8A/pUzhhLwwHcmOv8Wvl2Xr+br+45o4DlmBPi5ZCWH9Aa6m2ln/7HDhuNRoqXDyVcX6CqqR59xJdGMKfeyTyAqPDESS8QwP6hbnhFH2pzoFw48a7gjXzZTYDVboWSAkfnQqJkHEFbiOcZRQDN8lWBWM3kKAWuuS4VtRKgbU= From: Henry Wang To: "xen-devel@lists.xenproject.org" , Julien Grall , Wei Chen CC: Bertrand Marquis , "sstabellini@kernel.org" , Jan Beulich Subject: RE: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Thread-Topic: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Thread-Index: AQHYYCt6dq3rsqHdhkOYsjKIcgbjk60PmQ0w Date: Thu, 5 May 2022 03:05:46 +0000 Message-ID: References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-2-Henry.Wang@arm.com> In-Reply-To: <20220505025407.919988-2-Henry.Wang@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0DE3494AD93B024D892B9E0F6314E6D6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: eb1ecf6b-0b76-4b77-e6cf-08da2e442acd x-ms-traffictypediagnostic: AM9PR08MB6065:EE_|AM5EUR03FT021:EE_|AM0PR08MB4579:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QT3EuU8v/L15nia5LdAoeWxHZyMlJ+gSg5CUWOEkO2BSlf+dbzYxJQcpJf95tWXxxD+QvzDSONSor67kVpySHsEiIa0792OSGO+V54CT642cEIHNMINtBixwI1pnbEsSOnO7eqZCltAIL1cNAkYm6m2aMmZf/TZksIhFuPEDOqr7rTJL5aKhPCiIM3dg5mDPdgcN2ns0mqOdmOv/jR/V6M/IIs8Nn/0hQYE3ekhTR5kshJQFHVjOC11lBLjIrXBSzhNiuM+OjJl6r69LxdvFbBZlgq/av6txvTxgCUDCu7722xb3oMRILuKmVHke5Jel0ET8I+KozXx9QAarDb+YA3tRIpcRebevQEVIePNj5QRfjP3q0RCK4pyzehZGydxn535X4Pv24c5e5YL4eKo52+/oCDZLXnigWH8Gt2XKYRXbQ3v19Y/enubmByABZuXkVLHkOkraOqk7Sz9Tc9DNS1USgSLpGOVQIYUYkQBHlAapjXD0/xSwY/lPVvXkiMQbAgEM1RhLMgV2dlHIqjiQsQgQLCu4z6RxZ1n2Kej2eXQoSUmQYr9gYWh8ikVdcYIsKVPD5g8MR9Icwlr7gVmMoJeA8EPcVA7tqmRPltSSU9XvD0hE4LlN1y6BKbn22ydWVscaR/YISjnGpCTL+IfywbgFU73AxXgarmTBF5Z5QAagmKPFbf+BKfqo2Z6TwMd9zR3pkVh2OBBmCzjQt+NzkA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(508600001)(66946007)(76116006)(110136005)(55016003)(8936002)(86362001)(83380400001)(186003)(54906003)(71200400001)(7696005)(9686003)(6506007)(26005)(38070700005)(66476007)(122000001)(6636002)(66556008)(316002)(8676002)(64756008)(66446008)(52536014)(5660300002)(38100700002)(2906002)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6065 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f1c1a778-4c85-4675-27df-08da2e4426d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6kp8m/Fn8254z7gL831jQf9E6IQyFXA87xzTHkafzFoRq/RkYkIGitB9wHc/uBRvKM+VQZy8cf8yULawaUFIHwvopXtLDi1MsuiDCyW3ksu/cqAGN/B8JacK2aJPG7ep9Fj3nM1/r2dO8bpS3P5O4glRqtMJfJFkpVhXHd7z7EqThLQec0501OWb0ripZbDTJd1QoThpRAM9xEZvbPqFBGkDl2/j23rlLe6oXWWHQ/h3x9I1obel9s4+LLcPGWPhVkEAbMc9/ch3QMYgrPyQwrrI5t2ykFrLZduNFBi//il9ZRSLWoJqtRhkAHfqv+r+02UABc33Tw21MSY0WQNb6efsTy275MEdxryR2nsgLb28hsFm4tg+M406dFEXDDsWbtm+9ViQxh4cy68nV/3MF6XrDqCmOX5hjXujm3iWTH17atQPsXDJcVuiQeo+3ER7a4vSOJN5an0ghdjykbyJEUMvayaZiOfuH0TtcqfOeSk+xrNlrjiwc+iYuWcNTirbX9BbxkFCNiOjiDtFdUGHZIaGRO/S2wxszboyImTtPabsSSUe2yGdasaYYWUcI1Ja+Y0h/SAsVUoFUfVpPxVwaEgFZMbpDAs6r7r7kSgYKj3jH6jzJyNsXvz1ummPV9UBzwvKx7x0frS6OFTPob7B6BGP2d4fe9DoSkwLyg+8YFlQgPVJDsWlZCYRds+sq6ah X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(107886003)(40460700003)(9686003)(7696005)(356005)(26005)(6506007)(81166007)(5660300002)(2906002)(33656002)(82310400005)(36860700001)(52536014)(8936002)(86362001)(8676002)(508600001)(4326008)(70206006)(70586007)(83380400001)(336012)(47076005)(110136005)(6636002)(54906003)(316002)(186003)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 03:05:53.6512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb1ecf6b-0b76-4b77-e6cf-08da2e442acd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4579 Hi,=20 > -----Original Message----- > Subject: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after > local_irq_enable >=20 > With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before > local_irq_enable on secondary cores will lead to >=20 > (XEN) Xen call trace: > (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) > (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) > (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 > (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 > (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 > (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 > (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc > (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 > (XEN) [<0000000084000200>] 0000000084000200 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 4: > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || > num_online_cpus() <=3D 1)' failed at common/page_alloc.c:2212 > (XEN) **************************************** >=20 > on systems without a big enough pool for xmalloc() to cater the > requested size. >=20 > Reported-by: Wei Chen > Suggested-by: Julien Grall > Signed-off-by: Henry Wang > Change-Id: Iebdde81f52785b0c6e037c981ff68922db016d08 Sorry about the Change-Id, forgot to remove it before sending the mail to M= L, will remove it in V2. Same for PATCH 2/2. Kind regards, Henry > --- > xen/arch/arm/smpboot.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) From xen-devel-bounces@lists.xenproject.org Thu May 05 03:35:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 03:35:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321359.542331 (Exim 4.92) (envelope-from ) id 1nmSH6-0006bk-SB; Thu, 05 May 2022 03:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321359.542331; Thu, 05 May 2022 03:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSH6-0006bd-PF; Thu, 05 May 2022 03:35:32 +0000 Received: by outflank-mailman (input) for mailman id 321359; Thu, 05 May 2022 03:35:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSH5-0006bT-Q1; Thu, 05 May 2022 03:35:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSH5-0002og-L3; Thu, 05 May 2022 03:35:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSH5-00016G-A4; Thu, 05 May 2022 03:35:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmSH5-0001SO-9K; Thu, 05 May 2022 03:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=RDqcSRvbNkfZPBgX19moga97nGdLvPCvubXrdDAA+OY=; b=fIQ0sUOHhiMKyZZ+7qn3x7Y127 64eGI3/uEg3P9c6s0QBZZHHEdAMmy/wgbx1Vaw5FgXgXx5ujB+7noH7ElR+vHBZge16VVhHPxcHOZ OCYwtJsp3yh+COaKTyf91R0/QiQG5cJfGTNYIHkS19dvsOpy3JdyBvlkTbVLdlbbcNm8=; To: xen-devel@lists.xenproject.org Subject: [ovmf bisection] complete build-i386-xsm Message-Id: From: osstest service owner Date: Thu, 05 May 2022 03:35:31 +0000 branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/170136/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386-xsm.xen-build --summary-out=tmp/170136.bisection-summary --basis-template=168254 --blessings=real,real-bisect,real-retry ovmf build-i386-xsm xen-build Searching for failure / basis pass: 170131 fail [host=pinot0] / 168254 [host=albana0] 168249 [host=huxelrebe0] 168232 [host=huxelrebe0] 168185 [host=huxelrebe0] 168131 [host=albana0] 168127 [host=huxelrebe0] 168119 [host=albana0] 168115 [host=huxelrebe1] 168074 [host=huxelrebe0] 168048 [host=albana0] 168046 [host=huxelrebe0] 168043 [host=huxelrebe0] 168042 [host=chardonnay1] 168038 [host=huxelrebe0] 168017 [host=albana0] 167989 [host=huxelrebe1] 167980 [host=albana1] 167976 [host=huxelrebe0] 167956 [host=huxelrebe1] 167950 [host=\ albana0] 167946 [host=fiano0] 167940 [host=albana0] 167933 [host=albana0] 167929 [host=huxelrebe1] 167919 [host=elbling1] 167907 [host=albana1] 167803 [host=huxelrebe0] 167775 [host=albana0] 167760 [host=fiano0] 167754 [host=albana0] 167729 [host=albana1] 167727 [host=huxelrebe0] 167689 [host=fiano0] 167685 [host=chardonnay1] 167651 [host=albana0] 167636 [host=fiano0] 167627 [host=albana0] 167601 [host=albana1] 167598 [host=huxelrebe0] 167559 [host=huxelrebe0] 167555 [host=huxelrebe0] 167552 [ho\ st=albana0] 167535 [host=chardonnay1] 167527 [host=chardonnay1] 167522 [host=huxelrebe0] 167513 [host=albana1] 167487 [host=huxelrebe1] 167465 [host=albana1] 167463 [host=huxelrebe0] 167450 [host=fiano1] 167445 [host=chardonnay0] 167436 ok. Failure / basis pass flights: 170131 / 167436 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Basis pass f14fff513540757bef62923ee4aeca4bf3ea8081 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c d828caa9aeee80c59a35f662f875f6573e9b532f Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#f14fff513540757bef62923ee4aeca4bf3ea8081-101f4c789221716585b972f2c2a22a85c078ef1d git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003088b173b0-a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 git://xenbits.xen.org/osstest/seabios.git#2dd4b9b3f84019668719344b40dba79d681be4\ 1c-dc88f9b72df52b22c35b127b80c487e0b6fca4af git://xenbits.xen.org/xen.git#d828caa9aeee80c59a35f662f875f6573e9b532f-702c9a800eb3ecd4b8595998d37a769d470c5bb0 Loaded 76222 nodes in revision graph Searching for test results: 167465 [host=albana1] 167487 [host=huxelrebe1] 167436 pass f14fff513540757bef62923ee4aeca4bf3ea8081 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c d828caa9aeee80c59a35f662f875f6573e9b532f 167445 [host=chardonnay0] 167450 [host=fiano1] 167463 [host=huxelrebe0] 167513 [host=albana1] 167522 [host=huxelrebe0] 167527 [host=chardonnay1] 167535 [host=chardonnay1] 167552 [host=albana0] 167555 [host=huxelrebe0] 167559 [host=huxelrebe0] 167598 [host=huxelrebe0] 167601 [host=albana1] 167627 [host=albana0] 167636 [host=fiano0] 167651 [host=albana0] 167685 [host=chardonnay1] 167689 [host=fiano0] 167727 [host=huxelrebe0] 167729 [host=albana1] 167754 [host=albana0] 167760 [host=fiano0] 167775 [host=albana0] 167803 [host=huxelrebe0] 167907 [host=albana1] 167919 [host=elbling1] 167929 [host=huxelrebe1] 167933 [host=albana0] 167940 [host=albana0] 167946 [host=fiano0] 167950 [host=albana0] 167956 [host=huxelrebe1] 167976 [host=huxelrebe0] 167980 [host=albana1] 167989 [host=huxelrebe1] 168017 [host=albana0] 168046 [host=huxelrebe0] 168038 [host=huxelrebe0] 168042 [host=chardonnay1] 168043 [host=huxelrebe0] 168048 [host=albana0] 168074 [host=huxelrebe0] 168115 [host=huxelrebe1] 168119 [host=albana0] 168127 [host=huxelrebe0] 168131 [host=albana0] 168185 [host=huxelrebe0] 168232 [host=huxelrebe0] 168249 [host=huxelrebe0] 168254 [host=albana0] 168258 [host=elbling1] 168262 [host=elbling0] 168267 [host=elbling0] 168271 [host=elbling1] 168285 [host=elbling1] 168290 [host=elbling1] 168295 [host=elbling1] 168299 [host=elbling1] 168303 [host=elbling0] 168308 [host=elbling1] 168312 [host=elbling1] 168314 [host=elbling0] 168316 [host=elbling0] 168320 [host=elbling0] 168329 [host=elbling1] 168333 [host=elbling1] 168340 [host=elbling0] 168362 [host=elbling0] 168344 [host=elbling0] 168352 [host=elbling0] 168351 [host=elbling0] 168357 [host=elbling0] 168356 [host=elbling0] 168358 [host=elbling0] 168359 [host=elbling0] 168360 [host=elbling0] 168363 [host=elbling0] 168364 [host=elbling0] 168365 [host=elbling0] 168367 [host=elbling0] 168366 [host=elbling0] 168368 [host=elbling0] 168371 [host=elbling0] 168373 [host=elbling0] 168372 [host=elbling0] 168375 [host=elbling0] 168378 [host=elbling0] 168379 [host=elbling0] 168377 [host=elbling0] 168380 [host=elbling0] 168382 [host=elbling0] 168381 [host=elbling0] 168385 [host=elbling0] 168387 [host=elbling0] 168389 [host=elbling0] 168392 [host=elbling0] 168395 [host=elbling1] 168397 [host=elbling0] 168401 [host=elbling0] 168402 [host=elbling1] 168404 [host=elbling1] 168405 [host=elbling1] 168407 [host=elbling1] 168408 [host=elbling1] 168411 [host=elbling1] 168415 [host=elbling1] 168416 [host=elbling1] 168418 [host=elbling0] 168419 [host=elbling0] 168421 [host=elbling0] 168422 [host=elbling1] 168424 [host=elbling1] 168425 [host=elbling0] 168426 [host=elbling0] 168427 [host=elbling0] 168430 [host=elbling1] 168431 [host=elbling1] 168433 [host=elbling0] 168436 [host=elbling1] 168438 [host=elbling1] 168439 [host=elbling1] 168440 [host=elbling0] 168441 [host=elbling0] 168443 [host=elbling1] 168444 [host=elbling1] 168445 [host=elbling0] 168446 [host=elbling0] 168447 [host=elbling0] 168449 [host=elbling1] 168451 [host=elbling1] 168453 [host=elbling0] 168455 [host=elbling1] 168456 [host=elbling1] 168457 [host=elbling1] 168458 [host=elbling1] 168459 [host=elbling1] 168461 [host=elbling1] 168462 [host=elbling1] 168464 [host=elbling1] 168468 [host=elbling1] 168469 [host=elbling1] 168472 [host=elbling0] 168475 [host=elbling0] 168477 [host=elbling1] 168478 [host=elbling1] 168479 [host=elbling0] 168489 [host=elbling0] 168490 [host=pinot1] 168496 [host=elbling0] 168504 [host=elbling1] 168508 [host=pinot1] 168512 [host=pinot1] 168519 fail irrelevant 168521 [host=elbling0] 168524 [host=elbling0] 168525 [host=elbling0] 168526 [host=pinot1] 168530 [host=pinot1] 168532 fail irrelevant 168533 [host=pinot1] 168534 [host=elbling1] 168535 [host=elbling1] 168536 [host=elbling1] 168538 [host=elbling1] 168539 [host=elbling1] 168541 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168542 [host=pinot1] 168543 [host=pinot1] 168544 [host=pinot1] 168546 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168548 [host=pinot1] 168550 [host=elbling0] 168551 [host=elbling0] 168552 [host=elbling0] 168553 [host=elbling0] 168554 [host=elbling0] 168555 [host=pinot1] 168556 [host=pinot1] 168557 [host=pinot1] 168558 [host=pinot1] 168559 [host=pinot1] 168560 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168561 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168562 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168564 [host=pinot1] 168565 [host=pinot1] 168566 fail 2b175eeb6a3f630aef5a59a2c610a5be1a0cdd65 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168567 [host=elbling1] 168568 [host=elbling1] 168569 [host=elbling1] 168570 [host=elbling1] 168572 [host=elbling1] 168574 [host=pinot1] 168576 [host=pinot1] 168578 fail 10b4c8f3b75f765a5d210aa6f2fbab100955062e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168579 [host=elbling1] 168581 [host=elbling1] 168583 [host=elbling1] 168584 [host=pinot1] 168587 [host=pinot1] 168588 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168602 fail a13dfc769bd7097d8d9ffe3e029a2c1d062d712b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6ff9a7e62b8c43fe3e9d360fbd49d5854787bc39 168606 [host=pinot1] 168609 [host=elbling1] 168610 [host=pinot1] 168614 [host=pinot1] 168616 [host=elbling1] 168617 fail irrelevant 168618 [host=elbling1] 168622 [host=elbling1] 168623 [host=pinot1] 168625 [host=elbling1] 168627 [host=elbling1] 168634 [host=elbling0] 168629 [host=pinot1] 168635 [host=elbling1] 168637 [host=pinot1] 168639 [host=elbling0] 168640 [host=pinot1] 168645 [host=pinot1] 168648 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168651 fail 5b56c52b5c1cc817a1ddac7f03aa6a02aeab4c04 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db c7a80bc50ac768b4eecaad85b77ae45790c93c73 168653 [host=elbling1] 168661 [host=elbling1] 168663 [host=elbling1] 168664 [host=elbling0] 168668 [host=elbling0] 168670 [host=elbling0] 168672 [host=elbling0] 168673 [host=elbling0] 168675 [host=elbling0] 168678 [host=elbling0] 168679 [host=pinot1] 168680 [host=pinot1] 168682 [host=pinot1] 168683 [host=elbling0] 168685 [host=elbling0] 168686 [host=elbling0] 168687 [host=elbling0] 168688 [host=elbling0] 168689 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168690 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168692 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168693 [host=elbling1] 168694 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168695 [host=pinot1] 168697 [host=pinot1] 168698 [host=elbling0] 168702 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168703 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168707 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168708 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168710 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 6974c75180f1aad44e5428eabf2396b2b50fb0e4 168728 [host=elbling0] 168713 [host=elbling0] 168717 [host=elbling1] 168721 [host=elbling0] 168723 [host=elbling0] 168725 [host=elbling0] 168727 [host=elbling1] 168729 [host=elbling0] 168730 [host=elbling0] 168731 [host=elbling0] 168732 [host=elbling0] 168734 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168735 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168736 fail c1e662101addbfd983026f06d119da2d470865a1 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168738 [host=elbling0] 168739 [host=pinot1] 168741 [host=elbling0] 168745 [host=elbling0] 168746 [host=elbling0] 168747 [host=elbling0] 168748 [host=elbling0] 168749 fail 267a92fef3b705e6a3ecbeaa4d4b58f7bfac9734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db fdfb07eb28e42b456e5e1ce999a47cc3ea439f7f 168751 [host=elbling0] 168752 [host=elbling0] 168753 [host=elbling0] 168754 [host=elbling0] 168757 [host=pinot1] 168758 [host=elbling0] 168759 [host=elbling1] 168762 [host=elbling0] 168766 [host=elbling0] 168770 [host=pinot1] 168774 [host=elbling1] 168777 [host=elbling1] 168779 [host=elbling1] 168780 [host=elbling1] 168783 [host=elbling1] 168785 [host=elbling1] 168788 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 8aa0e9d2d1a4815516607eabe9b2e850f284a2f8 168789 [host=pinot1] 168790 [host=elbling0] 168793 [host=elbling1] 168799 [host=elbling1] 168801 [host=elbling1] 168804 [host=elbling1] 168805 [host=elbling1] 168806 [host=elbling1] 168808 [host=elbling1] 168812 [host=elbling0] 168813 [host=elbling0] 168814 [host=elbling1] 168817 [host=elbling1] 168819 [host=elbling1] 168820 [host=pinot1] 168822 [host=pinot1] 168823 [host=pinot1] 168824 [host=elbling1] 168826 [host=elbling1] 168827 fail ec0b54849b23efa25caf0055b0eef8bf9b4dec98 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 69e46280937526db9cf78259cd8a0a9ec62dc847 168829 [host=pinot1] 168831 [host=elbling1] 168832 [host=pinot1] 168834 [host=elbling0] 168837 fail 69218d5d2854acaa7a11c777244de4a297d2fbb9 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1c80f13a6efdc832878d7a431e2c216039d063bc 168844 [host=pinot1] 168854 [host=pinot1] 168858 [host=pinot1] 168859 [host=pinot1] 168865 [host=pinot1] 168981 [host=elbling1] 169004 [host=elbling1] 169046 [host=elbling0] 169069 [host=elbling0] 169102 [host=elbling1] 169117 [host=elbling1] 169128 [host=elbling1] 169135 [host=elbling1] 169141 [host=elbling1] 169144 [host=elbling1] 169148 [host=elbling1] 169150 [host=pinot1] 169153 [host=elbling0] 169156 [host=elbling1] 169161 [host=elbling0] 169165 [host=pinot1] 169169 [host=pinot1] 169173 [host=elbling0] 169177 [host=elbling0] 169187 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 169196 [host=pinot1] 169202 [host=elbling1] 169209 [host=pinot1] 169218 [host=elbling0] 169223 fail a298a84478053872ed9da660a75f182ce81b8ddc 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 14dd241aad8af447680ac73e8579990e2c09c1e7 169226 fail irrelevant 169227 fail irrelevant 169229 fail irrelevant 169232 [host=elbling1] 169234 [host=pinot1] 169235 [host=elbling0] 169242 fail irrelevant 169247 fail irrelevant 169248 [host=elbling0] 169258 [host=pinot1] 169263 [host=pinot1] 169265 [host=elbling0] 169266 fail irrelevant 169271 fail irrelevant 169272 [host=elbling1] 169274 [host=pinot1] 169275 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169277 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169278 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169279 [host=elbling1] 169280 [host=elbling1] 169281 [host=elbling1] 169282 fail 4f4afcd28802ff8a3e78ad72e47b6acb6e24819c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169283 fail bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169293 [host=elbling1] 169285 [host=pinot1] 169287 [host=pinot1] 169288 fail dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 8847ec08fd0eecbe3da944fdd49ca3d755e8a9bf 169289 [host=pinot1] 169290 [host=pinot1] 169291 [host=pinot1] 169295 [host=pinot1] 169297 [host=pinot1] 169299 [host=pinot1] 169300 [host=pinot1] 169302 [host=pinot1] 169305 [host=pinot1] 169306 [host=elbling1] 169307 [host=elbling1] 169308 [host=elbling1] 169310 [host=elbling1] 169311 [host=elbling0] 169312 [host=pinot1] 169313 [host=pinot1] 169314 [host=pinot1] 169315 [host=pinot1] 169316 [host=pinot1] 169317 [host=pinot1] 169319 [host=pinot1] 169321 fail 12a50c9ce117b6106c92bb965799e709547d8494 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 f44201124e8713f6eff80f349351b5740001c6fc 169323 [host=pinot1] 169324 [host=pinot1] 169325 [host=pinot1] 169326 [host=pinot1] 169327 [host=pinot1] 169329 [host=pinot1] 169331 fail irrelevant 169334 [host=pinot1] 169335 [host=elbling1] 169338 [host=elbling1] 169339 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169341 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169342 fail f5508a91e306dd183ab971be438b9667c9890a1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169343 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169344 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169345 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169349 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169350 [host=pinot1] 169352 [host=pinot1] 169357 [host=pinot1] 169358 [host=pinot1] 169359 [host=pinot1] 169360 [host=pinot1] 169362 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169363 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169364 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169365 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169366 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169370 [host=pinot1] 169371 [host=pinot1] 169372 [host=pinot1] 169374 [host=pinot1] 169375 fail c411566fad3d6d61a97edfa6e97a91688b175201 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 5b752808ff37b7c819a26fd76329ef329c42774f 169376 [host=pinot1] 169377 [host=pinot1] 169378 [host=pinot1] 169379 [host=pinot1] 169380 [host=pinot1] 169381 [host=pinot1] 169382 [host=elbling1] 169384 [host=elbling1] 169385 [host=pinot1] 169387 [host=elbling0] 169388 [host=elbling0] 169389 [host=elbling0] 169390 [host=elbling0] 169391 [host=elbling0] 169392 [host=elbling1] 169393 [host=elbling1] 169394 [host=elbling1] 169395 [host=elbling1] 169396 [host=elbling1] 169397 [host=elbling1] 169398 [host=elbling1] 169399 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169400 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169401 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169402 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169404 fail f3da13461cbed699e54b1d7ef3fba5144cc3b3b4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e509b5f932608e74deac96048b28a5e9b210c647 169405 [host=elbling0] 169406 [host=pinot1] 169407 [host=elbling0] 169408 [host=elbling0] 169410 [host=elbling0] 169411 [host=elbling1] 169413 [host=elbling1] 169414 [host=elbling1] 169416 [host=pinot1] 169417 [host=pinot1] 169418 [host=pinot1] 169419 [host=pinot1] 169420 [host=pinot1] 169421 [host=pinot1] 169422 [host=pinot1] 169424 [host=elbling0] 169425 [host=elbling1] 169427 [host=elbling1] 169428 [host=elbling1] 169429 [host=pinot1] 169430 [host=elbling0] 169431 [host=elbling0] 169432 [host=elbling0] 169435 [host=elbling1] 169436 [host=elbling0] 169437 [host=pinot1] 169438 [host=pinot1] 169439 [host=pinot1] 169440 [host=pinot1] 169441 [host=pinot1] 169443 [host=elbling1] 169445 [host=elbling1] 169446 [host=elbling0] 169448 [host=pinot1] 169449 [host=pinot1] 169450 [host=pinot1] 169451 [host=pinot1] 169452 [host=pinot1] 169453 fail irrelevant 169454 fail irrelevant 169455 fail irrelevant 169456 fail irrelevant 169457 fail irrelevant 169458 [host=pinot1] 169459 [host=pinot1] 169460 [host=pinot1] 169461 [host=pinot1] 169462 [host=pinot1] 169463 [host=pinot1] 169464 [host=pinot1] 169465 [host=pinot1] 169467 [host=pinot1] 169468 [host=elbling1] 169469 [host=elbling1] 169470 [host=elbling1] 169471 [host=elbling1] 169473 [host=pinot1] 169476 fail irrelevant 169478 [host=elbling0] 169479 [host=elbling1] 169480 [host=elbling1] 169481 [host=elbling1] 169512 [host=elbling0] 169482 fail irrelevant 169484 fail irrelevant 169485 fail irrelevant 169486 fail irrelevant 169487 [host=pinot1] 169489 [host=pinot1] 169490 [host=pinot1] 169491 [host=pinot1] 169492 [host=pinot1] 169494 [host=pinot1] 169496 [host=pinot1] 169497 [host=elbling0] 169498 [host=elbling0] 169500 [host=elbling0] 169501 [host=elbling0] 169503 fail irrelevant 169504 fail irrelevant 169505 fail irrelevant 169506 fail irrelevant 169508 fail irrelevant 169509 [host=elbling0] 169510 [host=elbling0] 169511 [host=elbling0] 169513 [host=elbling0] 169514 [host=pinot1] 169515 [host=pinot1] 169516 [host=pinot1] 169517 [host=pinot1] 169518 [host=pinot1] 169519 fail irrelevant 169520 fail irrelevant 169521 fail irrelevant 169522 fail irrelevant 169523 fail irrelevant 169524 [host=pinot1] 169525 [host=pinot1] 169526 [host=pinot1] 169527 fail irrelevant 169529 fail irrelevant 169530 [host=elbling0] 169532 [host=elbling0] 169533 [host=elbling0] 169534 [host=elbling0] 169535 [host=elbling0] 169536 [host=elbling0] 169538 [host=pinot1] 169539 [host=pinot1] 169540 [host=pinot1] 169542 [host=pinot1] 169543 fail irrelevant 169544 [host=pinot1] 169548 [host=pinot1] 169549 [host=elbling0] 169551 [host=elbling0] 169553 [host=pinot1] 169554 [host=pinot1] 169556 [host=pinot1] 169558 [host=pinot1] 169559 [host=pinot1] 169561 [host=pinot1] 169564 [host=pinot1] 169567 [host=elbling1] 169568 [host=elbling1] 169569 [host=pinot1] 169571 [host=elbling0] 169574 [host=elbling0] 169585 [host=pinot1] 169575 [host=elbling1] 169578 [host=elbling1] 169579 [host=pinot1] 169580 [host=pinot1] 169582 [host=pinot1] 169583 [host=pinot1] 169586 fail irrelevant 169587 [host=elbling1] 169588 [host=elbling1] 169589 [host=elbling1] 169590 [host=elbling1] 169592 [host=elbling1] 169593 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169594 [host=pinot1] 169596 [host=pinot1] 169597 fail b06a007b6471b6eba6d1c38ff1bcfff183b57488 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 fdef107edd4459375f9c0e6e377f30e82d498747 169598 [host=elbling1] 169599 [host=elbling1] 169600 [host=elbling1] 169602 [host=elbling1] 169604 [host=elbling1] 169606 [host=pinot1] 169607 [host=elbling1] 169610 [host=elbling1] 169612 [host=pinot1] 169615 [host=pinot1] 169618 [host=elbling1] 169620 [host=elbling1] 169621 [host=elbling1] 169623 [host=elbling1] 169625 [host=elbling1] 169626 [host=elbling0] 169628 [host=elbling0] 169631 [host=pinot1] 169632 [host=pinot1] 169633 [host=pinot1] 169634 [host=pinot1] 169636 [host=pinot1] 169637 [host=elbling0] 169639 [host=elbling0] 169641 fail irrelevant 169642 [host=elbling0] 169643 [host=elbling0] 169644 [host=elbling0] 169646 [host=elbling0] 169647 [host=elbling0] 169648 [host=pinot1] 169649 [host=pinot1] 169650 [host=pinot1] 169651 [host=pinot1] 169653 [host=elbling0] 169655 [host=elbling0] 169656 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169657 [host=elbling1] 169658 [host=elbling1] 169659 [host=elbling1] 169660 [host=elbling1] 169678 [host=elbling0] 169661 [host=pinot1] 169663 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169665 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169667 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169668 [host=elbling1] 169670 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169672 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169673 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169674 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169675 fail 96e1d337e0109d970282de71181a5cc317876829 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169676 [host=elbling0] 169677 [host=elbling0] 169679 [host=elbling0] 169680 [host=elbling0] 169681 [host=pinot1] 169682 [host=pinot1] 169683 [host=pinot1] 169684 [host=pinot1] 169685 [host=pinot1] 169687 [host=pinot1] 169688 [host=elbling0] 169689 [host=elbling0] 169690 [host=elbling0] 169691 [host=elbling0] 169692 [host=elbling0] 169693 [host=elbling0] 169695 [host=elbling0] 169697 [host=pinot1] 169698 [host=pinot1] 169700 [host=elbling0] 169701 [host=elbling0] 169702 [host=elbling0] 169703 [host=elbling0] 169704 [host=elbling0] 169705 [host=elbling0] 169706 [host=elbling0] 169707 [host=elbling0] 169708 [host=elbling0] 169709 [host=elbling0] 169710 [host=elbling0] 169711 [host=elbling0] 169712 [host=elbling0] 169713 [host=elbling0] 169715 [host=elbling0] 169716 [host=elbling0] 169718 [host=elbling1] 169719 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169721 [host=pinot1] 169722 [host=pinot1] 169724 [host=pinot1] 169726 [host=pinot1] 169728 [host=elbling1] 169730 [host=elbling1] 169731 [host=elbling1] 169732 [host=elbling1] 169733 [host=elbling1] 169734 [host=elbling1] 169735 [host=elbling1] 169738 [host=elbling1] 169740 [host=elbling1] 169742 [host=elbling1] 169744 [host=elbling1] 169746 [host=elbling1] 169750 [host=elbling1] 169754 [host=elbling1] 169757 [host=elbling1] 169758 [host=elbling1] 169759 [host=pinot1] 169761 [host=pinot1] 169763 [host=pinot1] 169764 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169766 [host=elbling1] 169769 [host=elbling1] 169770 [host=elbling1] 169772 [host=pinot1] 169776 [host=elbling1] 169778 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169780 [host=elbling0] 169783 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169784 [host=elbling1] 169786 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169791 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169793 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 2419a159fb943c24a6f2439604b9fdb1478fcd08 169796 [host=pinot1] 169797 [host=pinot1] 169799 [host=pinot1] 169802 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169803 [host=pinot1] 169804 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169806 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169808 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169810 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169811 fail 916f90baa547b3ebef8fa87c530e2f0c8e35e1e3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 3f5d61466345ed2213de2d7e391b6cd6d4b86015 169812 [host=pinot1] 169814 [host=pinot1] 169815 [host=pinot1] 169816 [host=pinot1] 169821 [host=elbling0] 169828 fail irrelevant 169832 [host=pinot1] 169835 [host=elbling1] 169837 [host=elbling1] 169839 [host=pinot1] 169841 fail irrelevant 169842 fail irrelevant 169845 fail irrelevant 169848 fail irrelevant 169854 fail irrelevant 169858 [host=elbling1] 169865 [host=pinot1] 169866 [host=pinot1] 169868 [host=pinot1] 169872 [host=pinot1] 169873 [host=pinot1] 169874 [host=pinot1] 169878 [host=pinot1] 169879 fail irrelevant 169880 fail irrelevant 169882 fail irrelevant 169883 fail irrelevant 169885 fail irrelevant 169889 fail irrelevant 169892 fail irrelevant 169894 [host=pinot1] 169901 [host=pinot1] 169904 fail irrelevant 169908 [host=elbling1] 169905 [host=elbling1] 169910 [host=elbling1] 169913 fail irrelevant 169914 [host=elbling1] 169915 [host=elbling0] 169916 [host=pinot1] 169917 [host=pinot1] 169919 [host=pinot1] 169920 [host=elbling1] 169921 [host=elbling1] 169922 [host=elbling1] 169923 [host=elbling1] 169924 [host=elbling1] 169925 fail irrelevant 169926 fail irrelevant 169927 fail irrelevant 169928 fail irrelevant 169930 fail irrelevant 169931 [host=elbling1] 169933 [host=pinot1] 169934 [host=pinot1] 169935 [host=pinot1] 169936 [host=pinot1] 169937 [host=pinot1] 169941 fail irrelevant 169943 fail irrelevant 169944 fail irrelevant 169945 fail irrelevant 169946 fail irrelevant 169952 fail irrelevant 169955 fail irrelevant 169960 fail irrelevant 169963 fail irrelevant 169966 fail irrelevant 169969 fail irrelevant 169970 [host=pinot1] 169971 [host=pinot1] 169972 [host=pinot1] 169973 [host=pinot1] 169974 [host=pinot1] 169975 fail irrelevant 169978 fail irrelevant 169979 fail irrelevant 169981 [host=pinot1] 169983 [host=elbling1] 169987 [host=elbling1] 169988 [host=elbling1] 169989 fail irrelevant 169991 fail irrelevant 169994 [host=elbling1] 169995 [host=pinot1] 169998 [host=pinot1] 169999 [host=pinot1] 170000 fail irrelevant 170003 fail irrelevant 170004 [host=elbling0] 170005 [host=pinot1] 170006 [host=pinot1] 170010 fail irrelevant 170013 [host=pinot1] 170017 fail irrelevant 170019 fail irrelevant 170022 [host=elbling1] 170027 [host=elbling1] 170029 [host=elbling1] 170030 [host=elbling1] 170038 [host=elbling1] 170041 [host=elbling1] 170043 [host=elbling1] 170045 [host=elbling1] 170048 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170049 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170050 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170052 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170054 [host=pinot1] 170055 [host=elbling1] 170056 [host=elbling1] 170058 [host=elbling1] 170059 [host=elbling1] 170060 [host=elbling1] 170061 [host=elbling1] 170063 [host=elbling1] 170062 [host=elbling1] 170065 [host=elbling1] 170066 [host=elbling1] 170067 [host=elbling1] 170068 [host=elbling1] 170069 [host=elbling1] 170070 [host=elbling1] 170074 [host=elbling1] 170075 [host=elbling1] 170073 [host=elbling1] 170077 [host=pinot1] 170076 [host=elbling1] 170079 [host=pinot1] 170080 [host=pinot1] 170082 [host=pinot1] 170083 [host=pinot1] 170084 [host=pinot1] 170085 [host=pinot1] 170086 [host=pinot1] 170087 [host=pinot1] 170088 [host=pinot1] 170089 [host=pinot1] 170090 [host=pinot1] 170091 [host=pinot1] 170092 [host=pinot1] 170094 [host=pinot1] 170093 [host=pinot1] 170097 [host=pinot1] 170096 [host=pinot1] 170098 [host=pinot1] 170100 [host=pinot1] 170099 [host=pinot1] 170101 [host=pinot1] 170103 [host=pinot1] 170102 [host=pinot1] 170104 [host=pinot1] 170105 [host=pinot1] 170107 [host=pinot1] 170106 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170108 pass f14fff513540757bef62923ee4aeca4bf3ea8081 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c d828caa9aeee80c59a35f662f875f6573e9b532f 170109 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170111 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170112 pass 7e5c603cba0823fd97456984f4cfc21c4c831b52 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 4eff93e7b0d093fd9347f2d533dada49854290fe 975a8fb45ca186b3476e5656c6ad5dad1122dbfd 170113 pass b24306f15daa2ff8510b06702114724b33895d3c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 22939d3c83da3f94c612b1f49f6f91f11ee3490d 170114 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170115 pass b24306f15daa2ff8510b06702114724b33895d3c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 109980738e1449f5f281e5d6bfb5681eb9defea6 170118 fail b909b4ad097080f865cbb7caae4cca101c0fe96c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 d239552ce7220e448ae81f41515138f7b9e3c4db 1f410b0c7455748021be4ede59e7a0c0a2ffb1c4 170119 fail 2aa107c0aa2e1375651867c8df1b81ff64b67fce 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170117 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170134 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170121 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170120 pass 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 7d9589239ec068c944190408b9838774d5ec1f8f 170124 pass 63c50d3ff2854a76432b752af4f2a76f33ff1974 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170125 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170126 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170127 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170128 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170129 pass 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170132 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 170131 fail 101f4c789221716585b972f2c2a22a85c078ef1d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 dc88f9b72df52b22c35b127b80c487e0b6fca4af 702c9a800eb3ecd4b8595998d37a769d470c5bb0 170136 fail d3febfd9ade35dc552df6b3607c2b15d26b82867 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 Searching for interesting versions Result found: flight 167436 (pass), for basis pass Result found: flight 169321 (fail), for basis failure (at ancestor ~137) Repro found: flight 170108 (pass), for basis pass Repro found: flight 170109 (fail), for basis failure 0 revisions at 84338c0d498555f860a480693ee8647a1795fba3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 a68d6d311c2d1fd9d2fa9a0768ea2353e8a79b42 829b0f1a7cda1bccdf44a379fb3a96e519a7e8cd 4388144c44c4dd9e9b7df97938ef08ffa85eec07 No revisions left to test, checking graph state. Result found: flight 170126 (pass), for last pass Result found: flight 170128 (fail), for first failure Repro found: flight 170129 (pass), for last pass Repro found: flight 170132 (fail), for first failure Repro found: flight 170134 (pass), for last pass Repro found: flight 170136 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: d3febfd9ade35dc552df6b3607c2b15d26b82867 Bug not present: 84338c0d498555f860a480693ee8647a1795fba3 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/170136/ commit d3febfd9ade35dc552df6b3607c2b15d26b82867 Author: Jason Date: Mon Jan 10 21:46:27 2022 +0800 MdePkg: Replace Opcode with the corresponding instructions. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790 Replace Opcode with the corresponding instructions. The code changes have been verified with CompareBuild.py tool, which can be used to compare the results of two different EDK II builds to determine if they generate the same binaries. (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) Signed-off-by: Jason Lou Cc: Michael D Kinney Reviewed-by: Liming Gao Cc: Zhiguang Liu neato: graph is too large for cairo-renderer bitmaps. Scaling by 0.580286 to fit pnmtopng: 106 colors found Revision graph left in /home/logs/results/bisect/ovmf/build-i386-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 170136: tolerable ALL FAIL flight 170136 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/170136/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386-xsm 6 xen-build fail baseline untested jobs: build-i386-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Thu May 05 03:38:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 03:38:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321369.542342 (Exim 4.92) (envelope-from ) id 1nmSJm-0007I7-G4; Thu, 05 May 2022 03:38:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321369.542342; Thu, 05 May 2022 03:38:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSJm-0007I0-Cj; Thu, 05 May 2022 03:38:18 +0000 Received: by outflank-mailman (input) for mailman id 321369; Thu, 05 May 2022 03:38:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSJl-0007Hq-FT; Thu, 05 May 2022 03:38:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSJl-0002qb-EZ; Thu, 05 May 2022 03:38:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmSJl-0001GO-6u; Thu, 05 May 2022 03:38:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmSJl-0006Tz-6S; Thu, 05 May 2022 03:38:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aSLQaGpyzINmPmOEwY0ijL5/E+o0+JU4vfe9ccndhR8=; b=D4cFPQfmVlzbVnE7Z5l7xkUnQY oJfH8iq2bNULR/u5ALsdGmA2dfoOhjbqv1ICJwyp1+TKnvtd+Dx6kgX+iQgB+AOFS18Gr/tO7HCDl du6btdcE9Agk+9otkhty4fCbDPqlFvylsSE+dUF62VUnYuRqlDwbqGYPsmkzInml50y4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170135: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 03:38:17 +0000 flight 170135 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170135/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 810 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 05:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321357.542375 (Exim 4.92) (envelope-from ) id 1nmTfj-0008F0-Tr; Thu, 05 May 2022 05:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321357.542375; Thu, 05 May 2022 05:05:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTfj-0008CH-J7; Thu, 05 May 2022 05:05:03 +0000 Received: by outflank-mailman (input) for mailman id 321357; Thu, 05 May 2022 03:14:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmRxA-0004q1-H8 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 03:14:56 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 887bc140-cc21-11ec-a406-831a346695d4; Thu, 05 May 2022 05:14:54 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id x18so4363792wrc.0 for ; Wed, 04 May 2022 20:14:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 887bc140-cc21-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6ucVUJA/3XuUnAZZDdzrSa00V5OM/xNG80G7w+rY/AM=; b=TuxTKLvOuI4WPEKhesTppN+S/ZTkV+RZI5Wf5W2p+hsrw7/gyfISF8EIiT+rnx8Zu6 zyyiN1wYwPcxjcCA2Sf5xnxirRkddqYIXy2R06dd7qAEUind0ZWDkOOMEqGzEQWPzWzC ZTGq5qihhGmXwhHHxuYfhzg3wQjnC+ThZO+LDVhD9+QIb89VKx3wO1YbUFwWrxXrBCMa SL8UA4+69pMFcpj8M2pJPoNe1J5xXeNZwxQABf1kR5+ALPhLTrYwt5fLtjpY8BeYkBF4 nHH6g/sC5IM5M9d/Ecm/JssJwuDneWf8+Vn5nXmTehGUz+AEuc9+Pt2ztZNda+z83bgG KQkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ucVUJA/3XuUnAZZDdzrSa00V5OM/xNG80G7w+rY/AM=; b=Zw3nFjN8S7/Kv/W0FIrlMJUz9TqcHJC4InBc0P7+zZYiAd4uy2cc6u5kOuLPej0Nym WVstf2peChtvRwt1nMgDFivM7zx+WK7o/6098pOm825HKwGj8j/PpE+N5PqNEFxVoY8Q geh/5QqrGW0vCH5EhUMM+y6Z0jKKIfc/a8xJ6WaGiwTGOcj42drncBQqczVmCLACDeYj 8qRkhLzr4plWhOfn2N7UKTC9FSMdmClTOjc/ppXc/QS78Co07dSnkrDT1/wZrx2SXQV0 REFdDB0OlR2+9eGDXUhvstLcEvsrKlrGwpRJXtP/TRDDWHMKL6bL4HoL4Gyn1FuM6W9o SCNA== X-Gm-Message-State: AOAM530QA0vjVgLsX3OECeA4CWm5gVaLMprQ199KH9UQdcn5miJa7sTO 71FS+iNju4L1uvUV0Lw9so37OpNd8llh+nI4hO4y X-Google-Smtp-Source: ABdhPJzVMX+BMHIo/6Rx3rt/EGt5DUCiA1Xs3vZE5oz5hLJkbM0bMmp2okAEnKI/au/mDAitpvRIKuXqsxBU1V8TuLw= X-Received: by 2002:a5d:590d:0:b0:20a:c3eb:2584 with SMTP id v13-20020a5d590d000000b0020ac3eb2584mr18412244wrd.18.1651720493308; Wed, 04 May 2022 20:14:53 -0700 (PDT) MIME-Version: 1.0 References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> <20220504234324.GA12556@embeddedor> In-Reply-To: <20220504234324.GA12556@embeddedor> From: Paul Moore Date: Wed, 4 May 2022 23:14:42 -0400 Message-ID: Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab To: "Gustavo A. R. Silva" Cc: Kees Cook , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , =?UTF-8?B?TnVubyBTw6E=?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Content-Type: text/plain; charset="UTF-8" On Wed, May 4, 2022 at 7:34 PM Gustavo A. R. Silva wrote: > > Hi Paul, > > On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote: > > On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: > > [..] > > > > +++ b/include/uapi/linux/xfrm.h > > > @@ -31,9 +31,9 @@ struct xfrm_id { > > > struct xfrm_sec_ctx { > > > __u8 ctx_doi; > > > __u8 ctx_alg; > > > - __u16 ctx_len; > > > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > > > __u32 ctx_sid; > > > - char ctx_str[0]; > > > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > > > }; > > > > While I like the idea of this in principle, I'd like to hear about the > > testing you've done on these patches. A previous flex array > > conversion in the audit uapi headers ended up causing a problem with > > I'm curious about which commit caused those problems...? Commit ed98ea2128b6 ("audit: replace zero-length array with flexible-array member"), however, as I said earlier, the problem was actually with SWIG, it just happened to be triggered by the kernel commit. There was a brief fedora-devel mail thread about the problem, see the link below: * https://www.spinics.net/lists/fedora-devel/msg297991.html To reiterate, I'm supportive of changes like this, but I would like to hear how it was tested to ensure there are no unexpected problems with userspace. If there are userspace problems it doesn't mean we can't make changes like this, it just means we need to ensure that the userspace issues are resolved first. -- paul-moore.com From xen-devel-bounces@lists.xenproject.org Thu May 05 05:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321065.542365 (Exim 4.92) (envelope-from ) id 1nmTfj-00083u-EC; Thu, 05 May 2022 05:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321065.542365; Thu, 05 May 2022 05:05:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTfj-00082J-5v; Thu, 05 May 2022 05:05:03 +0000 Received: by outflank-mailman (input) for mailman id 321065; Wed, 04 May 2022 23:41:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmOVn-00024e-VY for xen-devel@lists.xenproject.org; Wed, 04 May 2022 23:34:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc27fa87-cc02-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 01:34:26 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 86DE561BD4; Wed, 4 May 2022 23:34:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B1B9C385A4; Wed, 4 May 2022 23:34:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc27fa87-cc02-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651707264; bh=rg7gAW6bX54fvgfTyj+iLNX8iI1sLhWyZHkaZSInPKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rr/VhCUks/jvvIukLEQ8hvouelHSSI+9oZesVy9WjHsFReyAH53SdMAhNcNxTncRh AeNcfpQbGYHxmfRd7jiZWMjG0UbB4TKauYhVIbCXLf6VkMiM+KTnvLtKq+XumdW3b5 5XsvfgT+eqRG0aM2cOon7t/TFhjG0ZcaDmVjSrCT8tVFYMC+NZbIz/9jgmtLbpb2XF jXkHA/11zXgPOkzwOz9hKL1cmOdu/0VL29aSmhBA26JK83Tblanq8QYFCE42J8CQ6Y 8C4e2ka/Vcj7axXhNyNWWZ2uF0Rop6olk1luKtEofCYGXG5sML5MH30Czl0f2TcCS9 K08sslbYEpn+w== Date: Wed, 4 May 2022 18:43:24 -0500 From: "Gustavo A. R. Silva" To: Paul Moore Cc: Kees Cook , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , Christian =?iso-8859-1?Q?G=F6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab Message-ID: <20220504234324.GA12556@embeddedor> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Paul, On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote: > On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: [..] > > +++ b/include/uapi/linux/xfrm.h > > @@ -31,9 +31,9 @@ struct xfrm_id { > > struct xfrm_sec_ctx { > > __u8 ctx_doi; > > __u8 ctx_alg; > > - __u16 ctx_len; > > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > > __u32 ctx_sid; > > - char ctx_str[0]; > > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > > }; > > While I like the idea of this in principle, I'd like to hear about the > testing you've done on these patches. A previous flex array > conversion in the audit uapi headers ended up causing a problem with I'm curious about which commit caused those problems...? Thanks -- Gustavo > GCC12 and SWIG; while it was a SWIG problem and not a kernel header > problem that was thin consolation for those with broken builds. From xen-devel-bounces@lists.xenproject.org Thu May 05 05:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.320980.542353 (Exim 4.92) (envelope-from ) id 1nmTfi-0007uo-NX; Thu, 05 May 2022 05:05:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 320980.542353; Thu, 05 May 2022 05:05:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTfi-0007uh-KE; Thu, 05 May 2022 05:05:02 +0000 Received: by outflank-mailman (input) for mailman id 320980; Wed, 04 May 2022 19:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmL8Z-0001d3-QT for xen-devel@lists.xenproject.org; Wed, 04 May 2022 19:58:15 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8868aa5d-cbe4-11ec-a406-831a346695d4; Wed, 04 May 2022 21:58:14 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id j6so4875963ejc.13 for ; Wed, 04 May 2022 12:58:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8868aa5d-cbe4-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y+sByE56HbVf5kRX6gGxIKl4lkDcQYxYxjANal7cqo4=; b=Fisf8qNfLenDK0j792maHiYPMMvmyhGB9B3J/xS9stoAM/UZoSn3s9eWa4z58SqqtN zwNzc/F7jGucn3q+uOerwwvhkYcHR8WadSDg35wFqZ6iJOtuV3DgeIHYCsICPjn3FRC5 ijS3ruVDVcid8vwK6Aeyu8cvVWuqX4vHHcMprgjz8mGjIqaTTVh5y7xE1A9w5vPgc3/M 9OL1YFUN+X3Smqy7ONv67Xs9IxNQQJThHBH0mRzDjCqw6Y6Boyru+xViNBlwab5eTP66 Ql7OyvNLc8tFoVxvf1pFaiO/JKRt9GNoTAQHusID9bvyAzw/qXdqG5nBEcpTVWJq8YZ4 Z1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y+sByE56HbVf5kRX6gGxIKl4lkDcQYxYxjANal7cqo4=; b=UTvgBVLAqu6bBC8XJh0hyCRJauDlsP9PwN6EP9+YHh5vgBFHTjzotHEsxeceQdU76O trGxaqkLmIcLoNM+qDTrqv6z1ntC36lFjkWcFWTLNXLemhrMz+epQpV+uFKJqJ2QhhEc v45FxErbeLpnxvdCsLEPI+vgjy0nMcm0seWB0XQn8PsXzeVMkP/iclr34rvhq+wOgebj ZIeh40P+BHirSMvmaUvaRXzuc78urmWWtORE0bMBNKEtHNS+eiQa0udfOmq2LIbEF0zm 9ldl3Zhu6wBlZ6v0kOBqXIH2HpmR3cLFZoQjCWLXWwFJdr09TA2H4+acT6TPwselO5se XXGw== X-Gm-Message-State: AOAM531pCB1z2dwEar4AIEnREYjq/gXHjdm/aup1AUV5XK3VWeaDFJcb Dj8qGh0Q0rU0a0BEFlGx1iGEqZkNuqL+KFUfNHypzA== X-Google-Smtp-Source: ABdhPJyNqylHJlc3dOLmSwn3LLwT4ktliGhTIZtJUbCp6p9cyFNeSQSMHaaSeuuF72ZsBGrGa7DMKOVMS/2gIc+sdec= X-Received: by 2002:a17:907:9726:b0:6f4:c0e:40ce with SMTP id jg38-20020a170907972600b006f40c0e40cemr21300141ejc.170.1651694293700; Wed, 04 May 2022 12:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-4-keescook@chromium.org> In-Reply-To: <20220504014440.3697851-4-keescook@chromium.org> From: Daniel Latypov Date: Wed, 4 May 2022 14:58:02 -0500 Message-ID: Subject: Re: [PATCH 03/32] flex_array: Add Kunit tests To: Kees Cook Cc: "Gustavo A . R . Silva" , David Gow , kunit-dev@googlegroups.com, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , =?UTF-8?B?TnVubyBTw6E=?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Content-Type: text/plain; charset="UTF-8" On Tue, May 3, 2022 at 8:47 PM Kees Cook wrote: > +#define COMPARE_STRUCTS(STRUCT_A, STRUCT_B) do { \ > + STRUCT_A *ptr_A; \ > + STRUCT_B *ptr_B; \ > + int rc; \ > + size_t size_A, size_B; \ > + \ > + /* matching types for flex array elements and count */ \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A), sizeof(*ptr_B)); \ > + KUNIT_EXPECT_TRUE(test, __same_type(*ptr_A->data, \ > + *ptr_B->__flex_array_elements)); \ Leaving some minor suggestions to go along with David's comments. Should we make these KUNIT_ASSERT_.* instead? I assume if we have a type-mismatch, then we should bail out instead of continuing to produce more error messages. > + KUNIT_EXPECT_TRUE(test, __same_type(ptr_A->datalen, \ > + ptr_B->__flex_array_elements_count)); \ > + KUNIT_EXPECT_EQ(test, sizeof(*ptr_A->data), \ > + sizeof(*ptr_B->__flex_array_elements)); \ > + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), data), \ > + offsetof(typeof(*ptr_B), \ > + __flex_array_elements)); \ > + KUNIT_EXPECT_EQ(test, offsetof(typeof(*ptr_A), datalen), \ > + offsetof(typeof(*ptr_B), \ > + __flex_array_elements_count)); \ > + \ > + /* struct_size() vs __fas_bytes() */ \ > + size_A = struct_size(ptr_A, data, 13); \ > + rc = __fas_bytes(ptr_B, __flex_array_elements, \ > + __flex_array_elements_count, 13, &size_B); \ > + KUNIT_EXPECT_EQ(test, rc, 0); \ Hmm, what do you think about inlining the call/dropping rc? i.e. something like KUNIT_EXPECT_EQ(test, 0, __fas_bytes(ptr_B, __flex_array_elements, \ __flex_array_elements_count, 13, &size_B)); That would give a slightly clearer error message on failure. Otherwise the user only really gets a line number to try and start to understand what went wrong. > + > +#define CHECK_COPY(ptr) do { \ > + typeof(*(ptr)) *_cc_dst = (ptr); \ > + KUNIT_EXPECT_EQ(test, _cc_dst->induce_padding, 0); \ > + memcpy(&padding, &_cc_dst->induce_padding + sizeof(_cc_dst->induce_padding), \ > + sizeof(padding)); \ > + /* Padding should be zero too. */ \ > + KUNIT_EXPECT_EQ(test, padding, 0); \ > + KUNIT_EXPECT_EQ(test, src->count, _cc_dst->count); \ This also seems like a good place to use ASSERT instead of EXPECT. > + KUNIT_EXPECT_EQ(test, _cc_dst->count, TEST_TARGET); \ > + for (i = 0; i < _cc_dst->count - 1; i++) { \ > + /* 'A' is 0x41, and here repeated in a u32. */ \ > + KUNIT_EXPECT_EQ(test, _cc_dst->flex[i], 0x41414141); \ > + } \ > + /* Last item should be different. */ \ > + KUNIT_EXPECT_EQ(test, _cc_dst->flex[_cc_dst->count - 1], 0x14141414); \ > +} while (0) > + > +/* Test copying from one flexible array struct into another. */ > +static void flex_cpy_test(struct kunit *test) > +{ > +#define TEST_BOUNDS 13 > +#define TEST_TARGET 12 > +#define TEST_SMALL 10 > + struct flex_cpy_obj *src, *dst; > + unsigned long padding; > + int i, rc; > + > + /* Prepare open-coded source. */ > + src = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); Looks like we could use kunit_kzalloc() here and avoid needing the manual call to kfree? This also holds for the other test cases where they don't have early calls to kfree(). Doing so would also let you use KUNIT_ASSERT's without fear of leaking these allocations. > + src->count = TEST_BOUNDS; > + memset(src->flex, 'A', flex_array_size(src, flex, TEST_BOUNDS)); > + src->flex[src->count - 2] = 0x14141414; > + src->flex[src->count - 1] = 0x24242424; > + > + /* Prepare open-coded destination, alloc only. */ > + dst = kzalloc(struct_size(src, flex, TEST_BOUNDS), GFP_KERNEL); > + /* Pre-fill with 0xFE marker. */ > + memset(dst, 0xFE, struct_size(src, flex, TEST_BOUNDS)); > + /* Pretend we're 1 element smaller. */ > + dst->count = TEST_TARGET; > + > + /* Pretend to match the target destination size. */ > + src->count = TEST_TARGET; > + > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, 0); > + CHECK_COPY(dst); > + /* Item past last copied item is unchanged from initial memset. */ > + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); > + > + /* Now trip overflow, and verify we didn't clobber beyond end. */ > + src->count = TEST_BOUNDS; > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, -E2BIG); > + /* Item past last copied item is unchanged from initial memset. */ > + KUNIT_EXPECT_EQ(test, dst->flex[dst->count], 0xFEFEFEFE); > + > + /* Reset destination contents. */ > + memset(dst, 0xFD, struct_size(src, flex, TEST_BOUNDS)); > + dst->count = TEST_TARGET; > + > + /* Copy less than max. */ > + src->count = TEST_SMALL; > + rc = flex_cpy(dst, src); > + KUNIT_EXPECT_EQ(test, rc, 0); > + /* Verify count was adjusted. */ > + KUNIT_EXPECT_EQ(test, dst->count, TEST_SMALL); Just an FYI, macros get evaluated before the expect macros can stringify them. So the error message would look something like Expected dest->count == 10 but dest->count = 9 Not a big concern, but just noting that "TEST_SMALL" won't be visible at all. Could opt for KUNIT_EXPECT_EQ_MSG(test, dst->count, TEST_SMALL, "my custom extra message"); if you think it'd be usable to make the test more grokkable. > + /* Verify element beyond src size was wiped. */ > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_SMALL], 0); > + /* Verify element beyond original dst size was untouched. */ > + KUNIT_EXPECT_EQ(test, dst->flex[TEST_TARGET], 0xFDFDFDFD); > + > + kfree(dst); > + kfree(src); > +#undef TEST_BOUNDS > +#undef TEST_TARGET > +#undef TEST_SMALL > +} > + > +static void flex_dup_test(struct kunit *test) > +{ > +#define TEST_TARGET 12 > + struct flex_cpy_obj *src, *dst = NULL, **null = NULL; > + struct flex_dup_obj *encap = NULL; > + unsigned long padding; > + int i, rc; > + > + /* Prepare open-coded source. */ > + src = kzalloc(struct_size(src, flex, TEST_TARGET), GFP_KERNEL); > + src->count = TEST_TARGET; > + memset(src->flex, 'A', flex_array_size(src, flex, TEST_TARGET)); > + src->flex[src->count - 1] = 0x14141414; > + > + /* Reject NULL @alloc. */ > + rc = flex_dup(null, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + > + /* Check good copy. */ > + rc = flex_dup(&dst, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, dst != NULL); > + CHECK_COPY(dst); > + > + /* Reject non-NULL *@alloc. */ > + rc = flex_dup(&dst, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, -EINVAL); > + > + kfree(dst); > + > + /* Check good encap copy. */ > + rc = __flex_dup(&encap, .fas, src, GFP_KERNEL); > + KUNIT_EXPECT_EQ(test, rc, 0); > + KUNIT_ASSERT_TRUE(test, dst != NULL); FYI, there's a new KUNIT_ASSERT_NOT_NULL() macro in the -kselftest/kunit branch, https://patchwork.kernel.org/project/linux-kselftest/patch/20220211164246.410079-1-ribalda@chromium.org/ But that's not planned for inclusion into mainline until 5.19, so leaving this as-is is better for now. From xen-devel-bounces@lists.xenproject.org Thu May 05 05:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321026.542360 (Exim 4.92) (envelope-from ) id 1nmTfj-0007y4-51; Thu, 05 May 2022 05:05:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321026.542360; Thu, 05 May 2022 05:05:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTfi-0007xB-Sf; Thu, 05 May 2022 05:05:02 +0000 Received: by outflank-mailman (input) for mailman id 321026; Wed, 04 May 2022 22:57:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmNwE-00062l-Io for xen-devel@lists.xenproject.org; Wed, 04 May 2022 22:57:42 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99078139-cbfd-11ec-a406-831a346695d4; Thu, 05 May 2022 00:57:40 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id n126-20020a1c2784000000b0038e8af3e788so1670513wmn.1 for ; Wed, 04 May 2022 15:57:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99078139-cbfd-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qfWwXZWPvxEE3w1uLnkzPlrx6nJaZSmQ1gbsC3kCZlI=; b=fMehx6+pldeupaypGl5lGMLh8Blc5Pb964suvnwujkOTfmhEds0USznV5iIpAmDMiQ 3bX5ovLiBcm+P+Qjkm7S30sNoAIneyphU/3HUmg8FgNya3x4Ys+vGWu+B9CwMsbZwixV 5hhw5d61RXfF0ZuA9a19yWLWnmsownsAlvxGOq/bh+zf+KCchfsYUSjN3DbkCogRNiil 4sZMBBy0wN3DJWJ3HV3y9RTPrsOy6eZO4wbIVzlw9cfeY3DYzhWrMs9JJuoIK2/rWVPl SzHF6XACCrgzPRUtq8fL5afcNflV6Vriy9o5VdAvBNuxRLNvKxX70jkd0hURqNp4X2R8 1xwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qfWwXZWPvxEE3w1uLnkzPlrx6nJaZSmQ1gbsC3kCZlI=; b=EYUFGzufqp6Cr1Nnc5Bk5L7/k6eEsarCQ3oz0AIiTKrOfQ6wHIG3rhWUYnQWlMhr5S +qcpwmei37b8cGK38Y/GpSD6NCQbOTM729KFYXENfly/jJT0nxY4SROxaf6wnF4aDxbS YgVBsW/OPisqjijnjlORDpOCBMXYbrbs1r/IGafL9gwgMj2LP7Lqkd2r1WaS0bX6gwzJ 2SiwttOeu5wvAByQulnTwkhJOUoz38PcZS37O/KcnvnzWZgEBEcLO3z9QtgzuRTJ/lS2 SOpy7DVT1jKar/ZmCpgbe1bVTVXimPVVxnarE9iefxz6UWbogTzxBlstHK74SSFyNiPR 66Zg== X-Gm-Message-State: AOAM533K8fceuovLDAcTzkzWNB7CKaiNHQAoWDSgOw3AAlnQaHmZ2FLn /qFAEHHKveBA1s5PHvhI80NgB/RnjDRsTWtku2Ne X-Google-Smtp-Source: ABdhPJzn8kCki7g2xrksVPCE2X0dMoSQ5GNrlnQWJqU+8a/RnZE5ShgkUyQvDBvdRa4kG7oifCsX28YouBnWU5DkxR0= X-Received: by 2002:a05:600c:4fc9:b0:394:4317:1aa4 with SMTP id o9-20020a05600c4fc900b0039443171aa4mr1477643wmq.179.1651705059031; Wed, 04 May 2022 15:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> In-Reply-To: <20220504014440.3697851-29-keescook@chromium.org> From: Paul Moore Date: Wed, 4 May 2022 18:57:28 -0400 Message-ID: Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab To: Kees Cook Cc: "Gustavo A . R . Silva" , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , =?UTF-8?B?TnVubyBTw6E=?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: > > As part of the work to perform bounds checking on all memcpy() uses, > replace the open-coded a deserialization of bytes out of memory into a > trailing flexible array by using a flex_array.h helper to perform the > allocation, bounds checking, and copying: > > struct xfrm_sec_ctx > struct sidtab_str_cache > > Cc: Steffen Klassert > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Paul Moore > Cc: Stephen Smalley > Cc: Eric Paris > Cc: Nick Desaulniers > Cc: Xiu Jianfeng > Cc: "Christian G=C3=B6ttsche" > Cc: netdev@vger.kernel.org > Cc: selinux@vger.kernel.org > Signed-off-by: Kees Cook > --- > include/uapi/linux/xfrm.h | 4 ++-- > security/selinux/ss/sidtab.c | 9 +++------ > security/selinux/xfrm.c | 7 ++----- > 3 files changed, 7 insertions(+), 13 deletions(-) > > diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h > index 65e13a099b1a..4a6fa2beff6a 100644 > --- a/include/uapi/linux/xfrm.h > +++ b/include/uapi/linux/xfrm.h > @@ -31,9 +31,9 @@ struct xfrm_id { > struct xfrm_sec_ctx { > __u8 ctx_doi; > __u8 ctx_alg; > - __u16 ctx_len; > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > __u32 ctx_sid; > - char ctx_str[0]; > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > }; While I like the idea of this in principle, I'd like to hear about the testing you've done on these patches. A previous flex array conversion in the audit uapi headers ended up causing a problem with GCC12 and SWIG; while it was a SWIG problem and not a kernel header problem that was thin consolation for those with broken builds. > diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c > index a54b8652bfb5..a9d434e8cff7 100644 > --- a/security/selinux/ss/sidtab.c > +++ b/security/selinux/ss/sidtab.c > @@ -23,8 +23,8 @@ struct sidtab_str_cache { > struct rcu_head rcu_member; > struct list_head lru_member; > struct sidtab_entry *parent; > - u32 len; > - char str[]; > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, len); > + DECLARE_FLEX_ARRAY_ELEMENTS(char, str); > }; > > #define index_to_sid(index) ((index) + SECINITSID_NUM + 1) --=20 paul-moore.com From xen-devel-bounces@lists.xenproject.org Thu May 05 05:07:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321406.542397 (Exim 4.92) (envelope-from ) id 1nmThy-0001sS-EC; Thu, 05 May 2022 05:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321406.542397; Thu, 05 May 2022 05:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmThy-0001sL-B3; Thu, 05 May 2022 05:07:22 +0000 Received: by outflank-mailman (input) for mailman id 321406; Thu, 05 May 2022 05:07:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmThx-0001s7-5D; Thu, 05 May 2022 05:07:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmThx-0004ri-2i; Thu, 05 May 2022 05:07:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmThw-0005qg-Mf; Thu, 05 May 2022 05:07:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmThw-0008Cc-MG; Thu, 05 May 2022 05:07:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4rtaiCDWE5A3oURS+0LeGd3bcvIY4dwpD/h67RrYfVc=; b=MYW9BcAjv/f07NpncZ2GYMFlH2 eYIc0txMfrx102/gJO+JE8shPiZfWAYDeODdl9L7iUrDUccF76W+BkRD3ywRd3QVOt26NFg73p1Vl Nx3q0U5qKgzgXhAy657UFuqXqdtpID72U6RKuywR9WrSFyM/v8jxzrZcBQzDvNKP1p/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170137: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 05:07:20 +0000 flight 170137 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170137/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 811 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 05:12:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:12:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321415.542407 (Exim 4.92) (envelope-from ) id 1nmTnI-0003LG-3g; Thu, 05 May 2022 05:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321415.542407; Thu, 05 May 2022 05:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTnI-0003L9-0g; Thu, 05 May 2022 05:12:52 +0000 Received: by outflank-mailman (input) for mailman id 321415; Thu, 05 May 2022 05:12:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmTnG-0003Kh-PI for xen-devel@lists.xenproject.org; Thu, 05 May 2022 05:12:50 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0e::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01c5512a-cc32-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 07:12:49 +0200 (CEST) Received: from DB6P18901CA0013.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::23) by AM5PR0801MB2051.eurprd08.prod.outlook.com (2603:10a6:203:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 05:12:35 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::d) by DB6P18901CA0013.outlook.office365.com (2603:10a6:4:16::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Thu, 5 May 2022 05:12:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 05:12:35 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Thu, 05 May 2022 05:12:35 +0000 Received: from e06e04e781c1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B410CB8C-FDBD-447D-9910-3D358550603A.1; Thu, 05 May 2022 05:12:29 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e06e04e781c1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 05:12:29 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM0PR08MB3793.eurprd08.prod.outlook.com (2603:10a6:208:fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 05:12:27 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 05:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01c5512a-cc32-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AjhkM2a+UE4UJwkfIE/+yw3uaHcT2wDeI4teEJ6kdZs41XT++YJQMMprpUonoPwaueu2SHlyXYX475STeYJ2SK9w3gxtxC0Q3xRkwe+Ogt9m9LXygZ4SUTIBLMJ085NVI4I+1J/e8mg8IiVJS+GNrVPZoZ98r72jbbG3/jKVkgxkJlfkEkKOdUfIk8SiiY4tIxfw213muf+00VJXvwOnXrHNxzdTvD17vjMOVh83hNvV1LEYAFSG5/g8/3YjvMvT2BEiDeC1YDaVq8u7NgjK9fSbyF+UqWD/G94HbYKgQNwy4aU5uZ89cgyTZwHmPsazJ2sFitXfEEhrRIC65izF9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r7rbIplsgsshtyg3MjoASS19Py1Ag1wvmhbDkdc8Cv8=; b=lI/SXP9ouS7P46cbCPt5sUxsCUfQke+q6/VcfMr10qxL2b4h0lyC+x32/3Iw7aPRem4p/oyJbjwJOfDL4WAKe0nRIlYm+/nZHl88yfmneOw6ea6dgkza+eiQwp4scXZfgRN9rYyWE/oF+R2m6q6xsaOyHLUOIL3POnoaCz/+FWlIqLoFYvhQFS8DDDZdgvdkPhaiDxh4epoCZ0cFhi2WGsjxOLStFyMfeWVDrk5Ip/26D7hn+AOpZwv86g2uf3We62OXjGv6IaaNPDt993cMqCQlTvda0wv93hYZDbCzzMXzSSJZ/jYVSLRDL0lPsh79zDYYrWbnSn7fv0XAMF1dpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r7rbIplsgsshtyg3MjoASS19Py1Ag1wvmhbDkdc8Cv8=; b=IynsbezpJrwoZG5KDDgtFS4ZEwpUduB6NUv/KFrca6WiiCP6nD4vDteIkfp9j9w/+p6GORdWsBpNc/T3j9LKqU1E6qdB/x80WdmTPwNxuHHOCns6owcdxSK7+sb2VEoLFfy8/bWAscHSQesb30412JgnuEKb7I2kosullMqYWgI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5Dy1wAazm9PViZ4YRwnd2sp5gaZxxlN6KOs3sV6xpk5PD6sg4nSoowaneMdc+qjvfKprBrFG5mGF0BwE/LiqtPijKkBFAulgVORB0TIBJTccnA11CU5N556BCYeoq1PBdHtPcRF5uuTQ/MUgIEe51kWqZm4J2M0AtIL0ULpQ/Ep9YGr4AhF+XdiQbxCKg3+7RYFqG0iIJhenZmqSpiiN+IkVa5BH6VljbsDahA28bfEJKFjj5Z2Y/365/VZnbV+tewBZDO5KjNmUQUvTL0ERB+MD2BLLCylYOVkVE7zUuLjfw+859n9P4I+JyudhQ9tefr/x5nJ40SL5526Qaeclw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r7rbIplsgsshtyg3MjoASS19Py1Ag1wvmhbDkdc8Cv8=; b=AEpyzYO1hst7HwZkrecmXAfGHToqXtOZp+tRE+ekcsyp8aVHEQu2I1yWQGZ/Upk0q0w4pFxj4cH6n0MViim+zFHhKwE6wkKtYOMMfSoe+ML4Xu9h2u/QM76AjuGVb/4Lz1vS04Qn2kXEIc5U+BKusSk4vLR3AeTU49oBrbvxUhrgOlfRltoyA9406ZkcKGy8SXB0zx7WOFGSxxrb1U9+uNsAeph9ienGctxnxwbPIaZPOoWZxWlT4vhbweZUvxSgmxXKZ6nKjAduB9Llzs1zpK4qSew7xDWLd9b4vtxyxk7/cCdGmxRWW1jDOnFvRyR6T9MHzvmWX+/iw2RbzCUYPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r7rbIplsgsshtyg3MjoASS19Py1Ag1wvmhbDkdc8Cv8=; b=IynsbezpJrwoZG5KDDgtFS4ZEwpUduB6NUv/KFrca6WiiCP6nD4vDteIkfp9j9w/+p6GORdWsBpNc/T3j9LKqU1E6qdB/x80WdmTPwNxuHHOCns6owcdxSK7+sb2VEoLFfy8/bWAscHSQesb30412JgnuEKb7I2kosullMqYWgI= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/6] xen: do not free reserved memory into heap Thread-Topic: [PATCH v3 1/6] xen: do not free reserved memory into heap Thread-Index: AQHYWqxrPp+knbswwky8XjTDnza4CK0Ov/mAgADdzUA= Date: Thu, 5 May 2022 05:12:26 +0000 Message-ID: References: <20220428030127.998670-1-Penny.Zheng@arm.com> <5de2f283-f6fc-95e7-808c-4f3d96b25926@suse.com> In-Reply-To: <5de2f283-f6fc-95e7-808c-4f3d96b25926@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 55429DD6869B7047B38827212B5CCEC5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4afe8e1d-b68d-41b0-5265-08da2e55ddc1 x-ms-traffictypediagnostic: AM0PR08MB3793:EE_|DBAEUR03FT062:EE_|AM5PR0801MB2051:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E6XSE9oyiEIfYDsB5D57UNnHASjdBurZoIU/V9KgegPOrN+b8Dwj6e5SwZgvq0BwyZ7hCrijgYufNTcBkRDyTvZbxZUDjb3oCEsecTwElxROCET9KA/7E7AeDJUTvX0+EA+RMa7tN9dsZF7ZILrSm1ELRJqNGllXE15XI/eV1Ty/FM3RuwPUWrnGL4kGOpLwJwsiy1JAJOIO2h+70l0C6p/9Ah/MxpLbuuha/El+uE+j6OqGaG37roNo/i1XQBWRiw0VGNXQ7fk1qWVBf08h7aEmpFpDdwYg8POnrCR6u7Kmh2X3SHl4RRbEyc7bFSae9q4vMaVwRSjGYRJgh/YBwY2PvLqeukXwXgsqa3fkzwID723+Yu0OR8WhkbW56xUqCliZg2dZs4LMk+n6ytKBK302I/LBgCvZPfOSup1SGdA77VANfY+1yGcXOo4ysRhc2yIs5WYQRKAY/0wh3cywgzvYhmPkrPpe0UUsExGAsd6BUdDb+dCVxUwND0EjI7pKJrqjC/nzCHNOboxC/2LiYdYJ/B6PPwMq0t79Ha4Jcm1HF8cMp6pKI5NxFn1G757matTj4aNCMWWERSdTEXHTfUXERPP/lP33lPwTlKFvhYYnrc33WaNcN4O2a5UJSuDwQ5QymGdmx7W0M49JRmgMneoP1BrvHv+8XATCk2ku587BJVvoS6fZ64fJ2J7rOtikpt9kyojVEknm7xNgJ7Ldnw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(186003)(66476007)(66556008)(66946007)(26005)(66446008)(64756008)(76116006)(53546011)(8676002)(71200400001)(9686003)(6506007)(86362001)(55016003)(7696005)(316002)(38070700005)(6916009)(122000001)(8936002)(52536014)(5660300002)(54906003)(38100700002)(508600001)(83380400001)(2906002)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3793 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f6592be-8a19-4b3a-c303-08da2e55d8c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: itkfIIzSi1a2A3ekiUuATVUDnHTYXFrDxPGSowQpgg94TgaxMcWKdE9FmWm3Wq48JR24JIcwjt9rM0YnoUx11wi4aPdcTdZFZFE4l0N76eXW3BlIeW77N6q/lYJSQYG3X78jbmct7cDDnchKGPBCYZb894GCNHfdAB7NkXdf4mCw8SHuk9lT+k96psGqVEH2T9kagkgmR37FqPiokADZE07mdQMCbmXHH8ZA2FcfrLBDrE9T7131bT8s//a6O4rG5Kz/FS2kEJUpxez1XksDXgdo5beYzDdZUSNpMkPVXmUMqtqxoVGwa6YK3oX+PeXW00XenGO90l+HQDy8c0vlJNXkO+4/oQGLmgkvPWDRmpFNhyM0FPLcSddW8sZx0WU7toCnvWL8kJL5NDnhdM9p06BQG+ZpVgt8HDT6FkqgKRWYpN1wxOW+Evr0vWFezg4f29ANXTYhkpq2wc+AB8zxP+eeKLtGWZKBp5qelUGLvXwrwwgu6EPJMaRs4Rx2qq1izBwxhGBOO+KQku0/GjKzJSp89WZ4DIYdkApPMWsXAMuhzHh3R8uPGNPDiznRBnaQA2sLal92IvkyoAL3ZcVwbPCuwvbRrG32Szk1pKjxikO6yycdDlFkHUdRP+YI8G0cOITkffokGfKFtJ255nXweDKxeLKXxEJYm4DFGbIJh86J/Fj2T+vFlYeqtlASgntR X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(508600001)(54906003)(5660300002)(8936002)(52536014)(316002)(26005)(9686003)(186003)(47076005)(336012)(83380400001)(86362001)(40460700003)(356005)(33656002)(55016003)(36860700001)(6506007)(70206006)(2906002)(4326008)(70586007)(8676002)(6862004)(7696005)(53546011)(81166007)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 05:12:35.3878 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4afe8e1d-b68d-41b0-5265-08da2e55ddc1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2051 SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBXZWRuZXNkYXksIE1heSA0LCAyMDIyIDk6 MjcgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsN Cj4gSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47IFdlaQ0KPiBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAxLzZdIHhlbjog ZG8gbm90IGZyZWUgcmVzZXJ2ZWQgbWVtb3J5IGludG8gaGVhcA0KPiANCj4gT24gMjguMDQuMjAy MiAwNTowMSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gLS0tIGEveGVuL2NvbW1vbi9wYWdlX2Fs bG9jLmMNCj4gPiArKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+IEBAIC0xNDQzLDYg KzE0NDMsMTAgQEAgc3RhdGljIHZvaWQgZnJlZV9oZWFwX3BhZ2VzKA0KPiA+DQo+ID4gICAgICBB U1NFUlQob3JkZXIgPD0gTUFYX09SREVSKTsNCj4gPg0KPiA+ICsgICAgaWYgKCBwZy0+Y291bnRf aW5mbyAmIFBHQ19yZXNlcnZlZCApDQo+ID4gKyAgICAgICAgLyogUmVzZXJ2ZWQgcGFnZSBzaGFs bCBub3QgZ28gYmFjayB0byB0aGUgaGVhcC4gKi8NCj4gPiArICAgICAgICByZXR1cm4gZnJlZV9z dGF0aWNtZW1fcGFnZXMocGcsIDFVTCA8PCBvcmRlciwgbmVlZF9zY3J1Yik7DQo+IA0KPiBXaXRo IFBHQ19yZXNlcnZlZCBiZWluZyB6ZXJvLCB0aGUgY29tcGlsZXIgc2hvdWxkIENTRSB0aGlzIGNh bGwuIEhlbmNlIC4uLg0KPiANCg0KSSBhc3N1bWUgdGhhdCB5b3Ugc3VnZ2VzdCB0aGF0IHdlIHJl bW92ZSB0aGUgc3R1YiBmdW5jdGlvbiBhbmQganVzdCBsZXQNCmZyZWVfc3RhdGljbWVtX3BhZ2Vz IG5vdCBndWFyZGVkIGJ5IENPTkZJR19TVEFUSUNfTUVNT1JZIGFueSBtb3JlPw0KIA0KSG1tbW0s IG9uIHg4NiwgUEdDX3Jlc2VydmVkIHdpbGwgYmUgemVybyBhcyBub3QgZGVmaW5lZCwgYW5kIENT RSB3aWxsIGxlYXZlDQpubyBjYWxsZXIgaGVyZS4gIGJ1dCBvbiBhcm0sIENTRSBjb3VsZCBub3Qg Z3VhcmQgdGhpcz8NCiANCj4gPiBAQCAtMjc2Miw2ICsyNzY3LDEyIEBAIGludCBfX2luaXQgYWNx dWlyZV9kb21zdGF0aWNfcGFnZXMoc3RydWN0DQo+ID4gZG9tYWluICpkLCBtZm5fdCBzbWZuLA0K PiA+DQo+ID4gICAgICByZXR1cm4gMDsNCj4gPiAgfQ0KPiA+ICsjZWxzZQ0KPiA+ICt2b2lkIGZy ZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2luZm8gKnBnLCB1bnNpZ25lZCBsb25nIG5y X21mbnMsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBuZWVkX3NjcnViKSB7 DQo+ID4gKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gPiArfQ0KPiA+ICAjZW5kaWYNCj4g DQo+IC4uLiBJIGRvbid0IHRoaW5rIHRoaXMgaXMgbmVlZGVkPw0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 05 05:39:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321424.542419 (Exim 4.92) (envelope-from ) id 1nmUCd-0005ok-Ch; Thu, 05 May 2022 05:39:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321424.542419; Thu, 05 May 2022 05:39:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUCd-0005od-9r; Thu, 05 May 2022 05:39:03 +0000 Received: by outflank-mailman (input) for mailman id 321424; Thu, 05 May 2022 05:39:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUCc-0005oX-9f for xen-devel@lists.xenproject.org; Thu, 05 May 2022 05:39:02 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8c61143-cc35-11ec-a406-831a346695d4; Thu, 05 May 2022 07:38:59 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7D3F75C0086; Thu, 5 May 2022 01:38:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 05 May 2022 01:38:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 May 2022 01:38:56 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8c61143-cc35-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651729137; x=1651815537; bh=9ykJBArLSi+XT l0RENKtkpARnv7uv852R79wjUcrN+k=; b=E8Wfv1tvn1otQ4SEXe+8rILStEskT wXuM7un7WIIUD1LAoTK48c1FuQk6fNTL5WNw5t3gj+SBHSCdg+NsUffeQAkemd2m jr9YTjq3XyzgCcFtfwoKQmfKJRiAj8i6sBT0Q4Cqh3Tf8g7shFo/9fq5fymRdtPX QdAaXEqCldtfjmo8DiOWlld4EAT0SdWlwrSOE/tbiBqOcXXbOh92NxJ6cHP0Rt8s 3iHjsN0YcTF/j1AdoLTe+a6BUJntGC4OUutBzmAkI6R6auI8ZoyyC+PKyWvA2oea ydIE8X+M2XCOrlfCI8fe5ZeLd0JrfjWfza4SNh4vYofQNkvy6PtKN6/iQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggusehgtderredttdejnecuhfhrohhmpeffvghmihcuofgr rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhmqeenucggtffrrghtthgvrhhnpedukeetkeekkeekvdetgedtkeetffdthfdt tdfgieffhfekhefhjefhveeggfeiheenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhi sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Thu, 5 May 2022 01:38:52 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v4] Preserve the EFI System Resource Table for dom0 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7tuAjtNtlO9wuDyC" Content-Disposition: inline --7tuAjtNtlO9wuDyC Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 5 May 2022 01:38:52 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v4] Preserve the EFI System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification =C2=A723.= 4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour --- xen/common/efi/boot.c | 68 ++++++++++++++++++++++++++++++++++++++-- xen/common/efi/efi.h | 17 ++++++++++ xen/common/efi/runtime.c | 2 +- xen/include/efi/efiapi.h | 3 ++ 4 files changed, 86 insertions(+), 4 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..4b22dc1bb7 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -567,6 +567,37 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I= MAGE *loaded_image) } #endif =20 +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; + +static bool __init is_esrt_valid(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start =3D desc->PhysicalStart; + const ESRT *esrt_ptr; + + len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR ) + return false; + if ( physical_start > esrt || esrt - physical_start >=3D len ) + return false; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type !=3D EfiRuntimeServicesData) && + (desc->Type !=3D EfiBootServicesData) ) + return false; + available_len =3D len - (esrt - physical_start); + if ( available_len < sizeof(*esrt_ptr) ) + return false; + esrt_ptr =3D (const ESRT *)esrt; + if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count ) + return false; + return esrt_ptr->Count <=3D + (available_len - sizeof(*esrt_ptr)) / + sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +876,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTP= UT_PROTOCOL *gop, return gop_mode; } =20 +static EFI_GUID __initdata esrt_guid =3D ESRT_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +901,8 @@ static void __init efi_tables(void) efi.smbios =3D (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt =3D (UINTN)efi_ct[i].VendorTable; } =20 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1056,13 +1091,11 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHa= ndle, EFI_SYSTEM_TABLE *Syste EFI_STATUS status; UINTN info_size =3D 0, map_key; bool retry; -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP unsigned int i; -#endif =20 efi_bs->GetMemoryMap(&info_size, NULL, &map_key, &efi_mdesc_size, &mdesc_ver); - info_size +=3D 8 * efi_mdesc_size; + info_size +=3D 8 * (efi_mdesc_size + 1); efi_memmap =3D efi_arch_allocate_mmap_buffer(info_size); if ( !efi_memmap ) blexit(L"Unable to allocate memory for EFI memory map"); @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan= dle, EFI_SYSTEM_TABLE *Syste if ( EFI_ERROR(status) ) PrintErrMesg(L"Cannot obtain memory map", status); =20 + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) + { + if ( !is_esrt_valid(efi_memmap + i) ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type !=3D + EfiRuntimeServicesData ) + { + /* ESRT needs to be moved to memory of type EfiRuntimeServ= icesData + * so that the memory it is in will not be used for other = purposes */ + size_t esrt_size =3D offsetof(ESRT, Entries) + + ((ESRT *)esrt)->Count * sizeof(ESRT_ENTRY); + void *new_esrt =3D NULL; + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, es= rt_size, &new_esrt); + if ( status !=3D EFI_SUCCESS ) + { + PrintErrMesg(L"Cannot allocate memory for ESRT", statu= s); + break; + } + memcpy(new_esrt, (void *)esrt, esrt_size); + status =3D efi_bs->InstallConfigurationTable(&esrt_guid, n= ew_esrt); + if ( status !=3D EFI_SUCCESS ) + { + PrintErrMesg(L"Cannot install new ESRT", status); + efi_bs->FreePool(new_esrt); + } + } + break; + } + efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_si= ze, efi_mdesc_size, mdesc_ver); =20 diff --git a/xen/common/efi/efi.h b/xen/common/efi/efi.h index c9aa65d506..bf94dfcdf6 100644 --- a/xen/common/efi/efi.h +++ b/xen/common/efi/efi.h @@ -10,6 +10,23 @@ #include #include =20 +typedef struct _ESRT_ENTRY { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 FwLowestSupportedVersion; + UINT32 FwCapsuleFlags; + UINT32 FwLastAttemptVersion; + UINT32 FwLastAttemptStatus; +} ESRT_ENTRY; + +typedef struct _ESRT { + UINT32 Count; + UINT32 Max; + UINT64 Version; + ESRT_ENTRY Entries[]; +} ESRT; + struct efi_pci_rom { const struct efi_pci_rom *next; u16 vendor, devid, segment; diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c index 13b0975866..64e9f04671 100644 --- a/xen/common/efi/runtime.c +++ b/xen/common/efi/runtime.c @@ -269,7 +269,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *in= fo) case XEN_FW_EFI_MEM_INFO: for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) { - EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i; + const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i; u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; =20 if ( info->mem.addr >=3D desc->PhysicalStart && diff --git a/xen/include/efi/efiapi.h b/xen/include/efi/efiapi.h index a616d1238a..42ef3e1c8c 100644 --- a/xen/include/efi/efiapi.h +++ b/xen/include/efi/efiapi.h @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES { #define SAL_SYSTEM_TABLE_GUID \ { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1= , 0x4d} } =20 +#define ESRT_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x2= 1, 0x80} } + =20 typedef struct _EFI_CONFIGURATION_TABLE { EFI_GUID VendorGuid; --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --7tuAjtNtlO9wuDyC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJzYu4ACgkQsoi1X/+c IsGJ/w//bZq+40cFGG8L25uhNhJtVjUx0nryhGQF9TlV59w73UrTaZN7zNIhn6gi dkXz7hV52zeM2zS4by6dwto6H+8R8jte67tC2kejMUsd1vLwrumPh/ovTBxkgc9E FjnAktl+oy6J8D1A5Lwm+HpVeWnxvKbba5LT3w3zT/p/OTshe/vvI7fuRwbmco/R n++K5Mfz5XPO3lX0DhnhGuC63S0rdzEjTYhkvZE+kOOfLI48hSaZ9dhgfNEoJXWy WMIN4J4Y+TMAOZS2HHWeHFsPDyK8gxyEUJQ8/3peO4rPbf/ju2cFQm2yLXXk01/D DWBIx1d3/yRZllFqeDrcau05pA1Jumv/lbllgikfj97lTCQRuE9uXJ7K29OZMv+C TM07aiR+lD4f6r9De0OPFq+O0X9B1lpTUO5sr44Yedmk/Ve9IPpUMWpPk1aWFFsH Hsbt9Pdl7/8nRolisxLKjvRs1mkXQPY5KwvvMuMY8olXKc8lKcliFGVSiwBjlyb2 MPsJoQ57Y5kodqNfyV8lSytF8AhNzfQ1oJt90mXq/Si8UpD+W9SqQ8FDvP6HcnmI rr7fDlU4RqG3R3PMsGSu/5DAtM6+kE2xVknBIyXhLQdU/PJ2A0A1Myt2jDybGoFm VG7AdbGKL0hjji6mDhz3os5NPOWFUN7DvJ1JuRzX5mv6pHFMLuU= =9i6E -----END PGP SIGNATURE----- --7tuAjtNtlO9wuDyC-- From xen-devel-bounces@lists.xenproject.org Thu May 05 05:52:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 05:52:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321434.542430 (Exim 4.92) (envelope-from ) id 1nmUPQ-00084d-Hd; Thu, 05 May 2022 05:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321434.542430; Thu, 05 May 2022 05:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUPQ-00084W-EZ; Thu, 05 May 2022 05:52:16 +0000 Received: by outflank-mailman (input) for mailman id 321434; Thu, 05 May 2022 05:52:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUPO-00084Q-LM for xen-devel@lists.xenproject.org; Thu, 05 May 2022 05:52:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20604.outbound.protection.outlook.com [2a01:111:f400:7d00::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8292974a-cc37-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 07:52:13 +0200 (CEST) Received: from AM6P192CA0020.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::33) by AM6PR08MB3735.eurprd08.prod.outlook.com (2603:10a6:20b:81::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 05:52:10 +0000 Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::4) by AM6P192CA0020.outlook.office365.com (2603:10a6:209:83::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 05:52:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 05:52:09 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Thu, 05 May 2022 05:52:09 +0000 Received: from 9072cbe7cc29.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F1CE75D-7CB7-469F-884C-5C286AEC0D00.1; Thu, 05 May 2022 05:51:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9072cbe7cc29.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 05:51:59 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by DBBPR08MB6025.eurprd08.prod.outlook.com (2603:10a6:10:203::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 05:51:54 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 05:51:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8292974a-cc37-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SulS33LZtyKfpIrRkieYc6vMscbWcr/VlX6Rntamyuqd+htQ66GRXmYq1kOfICskc8I7oGW55Aphkn8IQkRgAojU2rgSzJ2/NemiDKGRcQa/hNTWw1/Q4cyfrimr1tAaF8AOgt7AzQr1bbg8+npppGbg2Ll98SzlvXyVNwxys3Rmxap+7SlYVl9P01CYmS43578NIjgrhOQsCnfchMx5vMtgvL804THu0VA+fIPMWTuF6On/olEqZR1lQKKSzNQhJTsGGthL0pjskspDSaq0/jreZ/PBHzR1Lm9xjJntR0K3/DRw6XL/p1jTaGGZN+cYxN5CbA8XuJ8tl3V6eya9Pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=Cft3Lm2u1FaDg1g9RXFW+oRypfszYWxubrBRNeEobGP7ITManMGA/Sc7+l9SxPYTcFc6UH39wZPCOKzpEYzNN171+Y6EZuIQSkOf/ZVyyeMhkxS1X2gkwjci/2wJeEbY7j4o/Sw3xOdM9Yo2y3T0jrQ4Nz5NWGNudmpfAnLT1HhFro6BrzXgcW7GgimPdIPhPcRe/c+fRAVz/yPPIYBlIKnP0/l0Vih1R6ivXCwz087YNvID5s1hM/txZhvEPIYBnklyXXcBFJ4TzdgJEdq/p72QTxsEUwGB183lEMyXsGqtnkrdx+JFMqeIqjEDUFenV9JvOZNgaTzWa6GQkI1BfQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=zDzxFLx1/IyipBWxS4MMx8Z4gFq6cwKC7hbFbohtGo3kxSeVLhw3ovbQ85FTTFGix4XTTxKinb6MneadOLaR9f46TLpXFcXBWkXRVTXKmT98a1LjLAjLvzQxwbBXGGREMsRrAd8GUqoJvFWTCkLLo9ecSFQqeNENB4iMqFI/ipQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfPkMwizstMZwulyEDC9TmK4Oh7naJ89naLZBG9z2F+Y5+gCUJ6WS9NN1hcDe8HHa3vQF6cZMi9AeyFMvvdwjWL2tq7IBrJXzCehPSOqFUc+3x3S2kmvKdBd+hAEnEj5HgHduyL2an3Zzhr+bcg/fkjrCfCiIfnBHAq90k89kyEdRqHHYpKyMF+qN9Y4gQeH7Cyrep6YtjtHZjJkVD19GZicevOBc025hVLxvcHanF7QCZlLzA6yDGBQetOV5hAHdjd6vPoTczvU0juGsW0PATDqnMFCcde8A2gi9/rj1GLaQDIvfUV+eZAvGgPzY+2sizXkLTLW5iglcyNM97B/Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=k1yvBRgmw0A+F3pTxkKbA8eCqQ5Drt2YY/+Cidk3Q3qJ6lfbM5ma8Df5wOPyT0AJJdPN8NCWA69DmYqxQpJzufVS5zkpwqe7kjk71M/EmjOZ5/VupjPwf9ElsNmvOpiXSWUGnfgp7S16L73DqX3w6J57GKy+/A9xIVWXEMYKB3kPEp4jsneOOvbmQXKbPOZ7ya+KUw/5uFC3thVQGexaQYViaMlLoPXI/kZHAol2JN9i8TC/Ss7nxlWG+p98f1Dtw0KttI/VpQHn7Xi0Rm9I6p0V0aIC6eJLZ7YX6ztwBPeEQtp7ebuh5YVLXRS7tyN1GtY81qo+xdmScji53m7wNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YTk4w4kM8VASug7minekMuaUJ+KOdkYv7klB2qI+Y7Y=; b=zDzxFLx1/IyipBWxS4MMx8Z4gFq6cwKC7hbFbohtGo3kxSeVLhw3ovbQ85FTTFGix4XTTxKinb6MneadOLaR9f46TLpXFcXBWkXRVTXKmT98a1LjLAjLvzQxwbBXGGREMsRrAd8GUqoJvFWTCkLLo9ecSFQqeNENB4iMqFI/ipQ= From: Penny Zheng To: Jan Beulich , "julien@xen.org" CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages() Thread-Topic: [PATCH v3 2/6] xen: do not merge reserved pages in free_heap_pages() Thread-Index: AQHYWhkw7aZ3ZAXjYkKl+baB+o3PAa0OwdUAgAENzPA= Date: Thu, 5 May 2022 05:51:54 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-3-Penny.Zheng@arm.com> <0ba5fb49-4cbf-916f-9d8e-4b64211fa87c@suse.com> In-Reply-To: <0ba5fb49-4cbf-916f-9d8e-4b64211fa87c@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8A4ED691C7B01A488901BD414A7CEB31.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6b661b80-fc2b-42d1-b637-08da2e5b6518 x-ms-traffictypediagnostic: DBBPR08MB6025:EE_|VE1EUR03FT063:EE_|AM6PR08MB3735:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wdmoSHLN9E/dzJ0dJ7ivTKwsev5O25NmGRLTZ18eSNW8Op21I4A2vL9EZAGZmvzZKKsIM0ru/xc0LA6NTMEezoBl2T+wSbRM52p8tYnFYbxqwBvLKbnhIp9v1YNRb4yipetRaPwU8xeOHln9cT90LaM5Gpc8qyt2reIG7yjLP7JqThD1sSFiqEkPxgHMvfaqSZCvFOdMf0WsWUNyESTJZMim0ur1urYESCarvYguHf3w/MarX+Y6PkB+VAYisRs7IYk2n7OnmD9mmyb7AfNNSGtyB7UwQCQGhtiHTKNrHOyRprpqK+xvmdeXq55H54HnSxIuf3dCGzS8+qTjdLLa5aY42ooODmsUqGrWvbpJMPglRiiPaZwwZMMQ+oBD4ll5sVyHkzPT1HIb7Lqjb6fsQYycO3FOPnqoB79PqRzhzZl9sOpk3+fiAYLmqq5LVjd3LOKYFssgPIQvfjNwttqjEtF3STFdvdp95+gHxzgiIaAetx3/JxmXdFtzPTUpV5rjhFRQ4GuLcsUarQrK8xhEVy6DH0Nfx2NXFiWarCRS2SNY+8whemUeKfmQKsiZq9ISi2X27LW5hsvUPl7cBtYnP3tQMYh/tDznkXdF3vG5m2+oJy6NubY09Bs3Nx15v1nw697c7RUSpQ45jsYTSi5cio6NmWIOmo2LfgDFx3qoGM0DBHdDzzNOtRlSE+h1W5NQtYWThcPSXil51QyWm9eg+w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(2906002)(83380400001)(508600001)(66476007)(66446008)(66556008)(64756008)(8676002)(76116006)(4326008)(186003)(316002)(4744005)(5660300002)(6506007)(33656002)(7696005)(53546011)(122000001)(86362001)(71200400001)(38070700005)(52536014)(8936002)(9686003)(110136005)(54906003)(26005)(55016003)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6025 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 016806db-8b35-489d-d502-08da2e5b5c0a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: guaZD59DSFcmTj/iixdAaCyJ8zwd3Kr60aVyLzXDyVCTqtT0W+akJUA200jfb+1qAkFiTJtSpYRBBD4sjvgz4dUa2UVFrYP8RYho5o+OpooPu8RK5aAmMxRJ51SiQqeoWnTZ+CbQYdU/n+iNPmCLHShrVkYphijCXCcwxkYJ9wkh4lWeBBgtLbNVOqBHgvv4jIHGBL3BKa3rRW1gjgnPzhARVp5eX0SlaI4DoRw6EegkYKfLsq9QvHMoqohKidveDhFJyvBPJ5a5ep1j0SpNl1/2ZTM0cNAuwBb0ShuNI1v6GV3lK6fZ+JMr1g0SxXHu2SWhZEecqPC0OROraz3hswMrMUQHFqoin3rsrRDIt4Uw+FFm5m1+UEVv284o3jWIozlaWG9TxuEU+W/joz9AGqAW3K1IGeTGZ4ABWO3qqSQHayHsFvwxthFQB/L9QXvIQHq7I2u/VAzdMM71OdW4rJ0bWpx4U6KzlsFlJMCFm/Ws2BhH72+d1He4Jvrf4NiunRjBu4IysgCUJj3UdmDooO2qvUfpGz3TaTAeEILl2srnsV7k3aV5f7tSh6I0F7PsUHkWgkHuTJasHBKJEXYB+58xfqmuW3ZFVWnmEbat0zCi9BgWxtMkgnXR032XOVQxZZK1/0K+yl3HIjlSD9wStPeq6GbWLjWMx8IUKj9jcMFgtZGQWTtyaUBXi6Odn/eL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(86362001)(186003)(336012)(47076005)(55016003)(53546011)(26005)(6506007)(9686003)(82310400005)(7696005)(33656002)(83380400001)(40460700003)(36860700001)(70206006)(70586007)(81166007)(4326008)(8676002)(110136005)(316002)(508600001)(356005)(54906003)(2906002)(52536014)(5660300002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 05:52:09.8116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b661b80-fc2b-42d1-b637-08da2e5b6518 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3735 SGksIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogV2VkbmVzZGF5LCBNYXkgNCwgMjAyMiA5OjMw IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdlaSBD aGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPjsN Cj4gQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5s YXANCj4gPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBX ZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0K PiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDIvNl0geGVuOiBkbyBub3QgbWVyZ2UgcmVzZXJ2ZWQg cGFnZXMgaW4NCj4gZnJlZV9oZWFwX3BhZ2VzKCkNCj4gDQo+IE9uIDI3LjA0LjIwMjIgMTE6Mjcs IFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IFRoZXJlIGlzIGEgc2xpbSBjaGFuY2UgdGhhdCBmcmVl X2hlYXBfcGFnZXMoKSBtYXkgZGVjaWRlIHRvIG1lcmdlIGENCj4gPiBjaHVuayBmcm9tIHRoZSBz dGF0aWMgcmVnaW9uKFBHQ19yZXNlcnZlZCkgd2l0aCB0aGUgYWJvdXQtdG8tYmUtZnJlZQ0KPiBj aHVuay4NCj4gPg0KPiA+IFNvIGluIG9yZGVyIHRvIGF2b2lkIHRoZSBhYm92ZSBzY2VuYXJpbywg dGhpcyBjb21taXQgdXBkYXRlcw0KPiA+IGZyZWVfaGVhcF9wYWdlcygpIHRvIGNoZWNrIHdoZXRo ZXIgdGhlIHByZWRlY2Vzc29yIGFuZC9vciBzdWNjZXNzb3INCj4gPiBoYXMgUEdDX3Jlc2VydmVk IHNldCwgd2hlbiB0cnlpbmcgdG8gbWVyZ2UgdGhlIGFib3V0LXRvLWJlLWZyZWVkIGNodW5rDQo+ ID4gd2l0aCB0aGUgcHJlZGVjZXNzb3IgYW5kL29yIHN1Y2Nlc3Nvci4NCj4gPg0KPiA+IFNpZ25l ZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiANCj4gUmV2aWV3 ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IEkgdGhpbmsgdGhp cyBhbHNvIHdhbnRzIGEgU3VnZ2VzdGVkLWJ5IG9yIFJlcG9ydGVkLWJ5IChpaXJjKSBKdWxpZW4/ DQo+IA0KDQpTdXJlLCBJJ2xsIGRlZmluaXRlbHkgYWRkLWluIFN1Z2dlc3RlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Thu May 05 06:24:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 06:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321441.542441 (Exim 4.92) (envelope-from ) id 1nmUul-00030K-3k; Thu, 05 May 2022 06:24:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321441.542441; Thu, 05 May 2022 06:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUul-00030D-0a; Thu, 05 May 2022 06:24:39 +0000 Received: by outflank-mailman (input) for mailman id 321441; Thu, 05 May 2022 06:24:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmUui-000307-RB for xen-devel@lists.xenproject.org; Thu, 05 May 2022 06:24:37 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on060b.outbound.protection.outlook.com [2a01:111:f400:fe06::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07c72537-cc3c-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 08:24:34 +0200 (CEST) Received: from AS8PR04CA0114.eurprd04.prod.outlook.com (2603:10a6:20b:31e::29) by AM6PR08MB5157.eurprd08.prod.outlook.com (2603:10a6:20b:e8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 06:24:31 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::5b) by AS8PR04CA0114.outlook.office365.com (2603:10a6:20b:31e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25 via Frontend Transport; Thu, 5 May 2022 06:24:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 06:24:30 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Thu, 05 May 2022 06:24:30 +0000 Received: from dbbfcfa96db2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 547A895A-7E17-426E-A3DF-CC9D33FA1D51.1; Thu, 05 May 2022 06:24:20 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbbfcfa96db2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 06:24:20 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR0802MB2288.eurprd08.prod.outlook.com (2603:10a6:800:a6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 06:24:17 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 06:24:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07c72537-cc3c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d3Y684bcOr79PPdtZ8HSiseYGEWdV+V8hRpOIJSeLwQiBoDfTiwyB0v3PPSQBXceWuWxGgAW0kHZX/+sHUFzrolpkJhZbIjRqHRh7Unus107ngZz+scVb24sdrNvB7oj9hopMZV5J038eoj/WUoTWKYjqa/g5jLSxrlHNuf8cpql4k6QxpHPzdv0n7AdetznEC0e/6xlu+RXHrATXpn0iKZKJ9+AgePmuw5SVHq4g/4ZC65GWQDZARC6lGkBp0ZN01fCCrDoFyviQFN26BeD8SNAl9WlS7yqHrJqkmT3plzUvo9ylRoSZ4MBnl4qX6tFhnJ1TjlFQLsiNmAQYWa+0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gzQe7Cb12yxjblIaJlPcI092brMvHMWkPmc6L4PYCqA=; b=HQHHwdKkPYWGuhMzY9ZEpLpOzMT5jQ5pukvpUFD7hkfoZ6jtc3YFzphTTXPd82awA4Zj43tBbalG9qx4seDtjZkGao3GQvA2HXRYYGEtS9bTvz3y3cvK7pGG8JbPumE2tdZeoLdTd+w04uh4OBmh111JAaG+c7t12z53WcI8ngpuhDUZBZhWUO/M2/ssnMrdupv6Adhl9x9iZVbm6EbtuqgjxiRRYJUG8BKN1x1FmXnPwDxr81iX6dvqIsOhW9UUQG7Vs+TLJ7YKTcI9Am+/XpBsJeuAKUxhwniMcHi6nZmtWWPLAThIxWrD4Hx/TWgMb6AGMmyEg3mkfAbvouy3vQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gzQe7Cb12yxjblIaJlPcI092brMvHMWkPmc6L4PYCqA=; b=oYtEfq0cikChyrHY5/pjOTIrC1AHrUZ4Bd6iibkIPVnCl9AcoAHHQEyI6nUsXs4iUi/+F4P71mJomG/BXilmKxL7WmOeTe0xeBvVZHfL3aGrFGuSqp8MJUrz5DN7d79DCzWBgnmOTqt/6pSFsIwlhlRl9GOIe+zGPLwixBw2J9E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ly14b8uW25XyRSsh/KnxrGFpNrGunA3n87uhYBCikSEwkHq6GVVNEo/HNz77lcmV1Pv6ORHbwRmmn5A41lHPQvPB/jdMjHFchTk3qpvu+ZVXskZ/VkAyMEUKyb6r2zeCrSbRA3Xu4hAHKjgD30KWQFc7+zqflRlAnkN1+Jdg68H97UbBpAprKtZVTQq2VFUTDTuQdYYgVK6nCTMecUxqTRdsj9sDhaonu881ITbZlGp8Dah0kGVaQZ2ApF35ke12n6F0cBcTmTkt7cJ12UfjTnlaKGSFg4NIC1ZqWS4vuh1xCT4WYKqZS0lXjyyGsfKDMnP3aQI6WxcFqsqh4cfWAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gzQe7Cb12yxjblIaJlPcI092brMvHMWkPmc6L4PYCqA=; b=nFdU0XquqbpHOfjPE3Gpdsz5dyDWhhaiz9FA11WppZD5xXe1qMvUh0IOBWtm2Or9sThSM62s+RCM1YIV0MWbJf04Dhzu1vgusUBLao0+YEukLjM8EkZae4wRX330Z2uZYL19a3WJiYRDUYd94pBEHLnnDUX+jOWeYA+ELcozC+RUt3TlRd/dYbXsj1RHwArXPEMacq2EIOilXljBodBxwhZw3PyZ5fowQymSXeU9bMwvjAkOyHco4dBlFF4X3LodVjXjH4PCGJSuVWA8GHH001nR/3TEHLkJOz22JRCC1CUGWuf/TBFQei34j5Uadk5vpyWOUFOnTk2+DL/rf5G/DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gzQe7Cb12yxjblIaJlPcI092brMvHMWkPmc6L4PYCqA=; b=oYtEfq0cikChyrHY5/pjOTIrC1AHrUZ4Bd6iibkIPVnCl9AcoAHHQEyI6nUsXs4iUi/+F4P71mJomG/BXilmKxL7WmOeTe0xeBvVZHfL3aGrFGuSqp8MJUrz5DN7d79DCzWBgnmOTqt/6pSFsIwlhlRl9GOIe+zGPLwixBw2J9E= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwA= Date: Thu, 5 May 2022 06:24:17 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7405BF0E8CE6B341BE247F2B41D24E4F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 081da096-dd88-421f-3a1b-08da2e5fea09 x-ms-traffictypediagnostic: VI1PR0802MB2288:EE_|VE1EUR03FT024:EE_|AM6PR08MB5157:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0PBD8NEGXTKwiP15omzpMoc2fu5cBvDCCR/JDpZ26P2dVgN0fbOtEfibBspWLxWPKhNYTSeZQuYuQQyRnHabU7tjXHqJGKh1/CNoU0uU2iYymf81knAuHoQ802RrYrPekNGWEBc92/Mi0Rf11dBM+Awz20QOh5JQ+Cp+0r7/K0fpcVc+cEZwhfU9LnMQ6QXbpP1GAquytQlxqxVcuA/jBSjL9rH5EgYvphnrQDtpJ6i8oM7C7AeuyA7kp0ie+TxkBRYsc8jGQ71sU9ySb72zgq3ccsWUAUT1fEwG7ImltmIngysMJDHFApCB0saRy0Gp5SpO1/AeXGZM98XmR5cEJOJIjnWslBgyVugqgcy5QMVynBOkX4Z+KshsDvKxfe/Bl/fbrK5jdWYnzzPvGV229tm/RAQr6W9BJFlxpUOuv8j65t2RAK/zVDDV3+FVKtp6UJZwq9F+XT+BRSGIAxJLy3s4/fxL1UcTCswI9gklsHwJNL8R6NWBrHDBdNx86+MR1YgKpyq6RSZQfo4wWq80ud0gmz8QI5iENt1WYtjFQBMmAgtqKpMoo2aA7XqNrUO+UVq72Lo5U+aSr/XYGod5Pdvk7pBpoBbj4+XxJVbHe1dCIfQcinwK+YrejU7CaIpcg/QOO1UJIRFpbaEU2g4VAiULqkSiRsrWgHgQ5CkwzIXi9MdL515ppN5pj23ExrN7TZwtQf74ZjuUhRbVA4Ooig== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(6916009)(83380400001)(66946007)(4326008)(76116006)(8676002)(66446008)(64756008)(66476007)(66556008)(71200400001)(2906002)(52536014)(316002)(508600001)(5660300002)(8936002)(9686003)(33656002)(7696005)(186003)(26005)(53546011)(6506007)(38100700002)(38070700005)(86362001)(55016003)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2288 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ac7d28e4-c815-44ec-5c05-08da2e5fe218 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EJZKqea/1Q3CMyxegAx8XOVigfpKsMDEM0Jdy1wwEgdM0Otw+62hmSPJusWf2BTQenuIlVxs60m9hLpXHWFGwRlIn6DE3WLK9m/YxxIxm1RikjGq68Jq7PjfWmj37txBVUJoPsrDUMztLDqzfXHGRMrrMHMq1/+lrJkc3vJRteBIUgjgLdB8oHD6VOjSje2cIUf+QjV06m6GZHjWbaMiqC8rxhCCLg5det28q7JL5/Qlzzg9dusP26AqCKZOyCGwHvWjZ8QRziQLHtwK2Yf6RJTbfQZzOY0fFwhZv6PR/sdz+YbLXkVz30EQhARF7Sm55RFv9faalqKZqmsnxGtNFTdIu1j8I9jWdrTO0Vigcuqz7HOxr4dwtWdNAkSI2ZdMob0ZlItIgDLbppPIpbWMTq5ts5/pYWDikrto2MzApLmlLLMvacjnsbOcDxbIgph5s7lVwXjSwUx49JItEHPgUMMpXkDXw4uW7Bs6dc/rb8hZQEXaODlMPh3TovglED99qWl3/rJBttgkK1AFjLNxofqekMDhOaL35dW6iXX+WAHaxj+sFKbi7UHKeVNgxhjZlMvbVeWTCwZpjl5ef5f8t8gkuMhVMk8yeX+IwQgFDhso5Wmkw/XcJ2tbq1WaBC9fLT5tSmCccxgVyrcuzW5OM5kNWOHgfToYebeTeSUvA/5gSioItboGSJlO41MArjQJ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36860700001)(8936002)(26005)(55016003)(508600001)(316002)(52536014)(186003)(5660300002)(40460700003)(7696005)(70586007)(6506007)(86362001)(53546011)(70206006)(4326008)(83380400001)(6862004)(81166007)(8676002)(82310400005)(2906002)(33656002)(54906003)(47076005)(9686003)(336012)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 06:24:30.8184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 081da096-dd88-421f-3a1b-08da2e5fea09 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5157 SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBXZWRuZXNkYXksIE1heSA0LCAyMDIyIDk6 NDUgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ Ow0KPiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1 bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5A eGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47 IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tDQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgNi82XSB4ZW46IHJldHJpZXZlIHJlc2VydmVkIHBh Z2VzIG9uDQo+IHBvcHVsYXRlX3BoeXNtYXANCj4gDQo+IE9uIDI3LjA0LjIwMjIgMTE6MjcsIFBl bm55IFpoZW5nIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9jb21tb24vbWVtb3J5LmMNCj4gPiArKysg Yi94ZW4vY29tbW9uL21lbW9yeS5jDQo+ID4gQEAgLTI0NSw2ICsyNDUsMjkgQEAgc3RhdGljIHZv aWQgcG9wdWxhdGVfcGh5c21hcChzdHJ1Y3QgbWVtb3BfYXJncw0KPiA+ICphKQ0KPiA+DQo+ID4g ICAgICAgICAgICAgICAgICBtZm4gPSBfbWZuKGdwZm4pOw0KPiA+ICAgICAgICAgICAgICB9DQo+ ID4gKyAgICAgICAgICAgIGVsc2UgaWYgKCBpc19kb21haW5fdXNpbmdfc3RhdGljbWVtKGQpICkN Cj4gPiArICAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAgICAgLyoNCj4gPiArICAgICAg ICAgICAgICAgICAqIE5vIGVhc3kgd2F5IHRvIGd1YXJhbnRlZSB0aGUgcmV0cmVpdmVkIHBhZ2Vz IGFyZQ0KPiA+ICsgY29udGlndW91cywNCj4gDQo+IE5pdDogcmV0cmlldmVkDQo+IA0KPiA+ICsg ICAgICAgICAgICAgICAgICogc28gZm9yYmlkIG5vbi16ZXJvLW9yZGVyIHJlcXVlc3RzIGhlcmUu DQo+ID4gKyAgICAgICAgICAgICAgICAgKi8NCj4gPiArICAgICAgICAgICAgICAgIGlmICggYS0+ ZXh0ZW50X29yZGVyICE9IDAgKQ0KPiA+ICsgICAgICAgICAgICAgICAgew0KPiA+ICsgICAgICAg ICAgICAgICAgICAgIGdkcHJpbnRrKFhFTkxPR19JTkZPLA0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJDb3VsZCBub3QgYWxsb2NhdGUgbm9uLXplcm8tb3JkZXIgcGFnZXMNCj4g PiArIGZvciBzdGF0aWMgJXBkLlxuLiIsDQo+IA0KPiBOaXQ6ICJDb3VsZCBub3QiIHJlYWRzIGFz IGlmIGFuIGF0dGVtcHQgd2FzIG1hZGUsIHNvIG1heWJlIGJldHRlciAiQ2Fubm90Ij8NCj4gSSdk IGFsc28gcHVsbCAic3RhdGljIiBhaGVhZCBvZiAibm9uLXplcm8tb3JkZXIiIGFuZCwgdG8gaGVs cCBvYnNlcnZlcnMgb2YgdGhlDQo+IG1lc3NhZ2UgYXNzb2NpYXRlIGl0IHdpdGggYSBjYWxsIHNp dGUsIGFjdHVhbGx5IGxvZyB0aGUgb3JkZXIgKGkuZS4NCj4gIm9yZGVyLSV1IiBpbnN0ZWFkIG9m ICJub24temVyby1vcmRlciIpLg0KPiANCj4gQWxzbyBwbGVhc2Ugb21pdCBmdWxsIHN0b3BzIGlu IGxvZyBtZXNzYWdlcy4gVGhleSBzZXJ2ZSBubyBwdXJwb3NlIGJ1dA0KPiBjb25zdW1lIHNwYWNl Lg0KPiANCj4gRmluYWxseSwgaGVyZSBhcyB3ZWxsIGFzIGJlbG93OiBJcyAiaW5mbyIgbG9nIGxl dmVsIHJlYWxseSBhcHByb3ByaWF0ZT8NCj4gWW91J3JlIGxvZ2dpbmcgZXJyb3IgY29uZGl0aW9u cyBhZnRlciBhbGwsIHNvIGltbyB0aGVzZSB3YW50IHRvIGJlIGF0IGxlYXN0DQo+ICJ3YXJuIiBs ZXZlbC4gQW4gYWx0ZXJuYXRpdmUgd291bGQgYmUgdG8gb21pdCBsb2dnaW5nIG9mIG1lc3NhZ2Vz IGhlcmUNCj4gYWx0b2dldGhlci4NCj4gDQo+ID4gLS0tIGEveGVuL2NvbW1vbi9wYWdlX2FsbG9j LmMNCj4gPiArKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+IEBAIC0yNzY5LDEyICsy NzY5LDUwIEBAIGludCBfX2luaXQgYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoc3RydWN0DQo+ID4g ZG9tYWluICpkLCBtZm5fdCBzbWZuLA0KPiA+DQo+ID4gICAgICByZXR1cm4gMDsNCj4gPiAgfQ0K PiA+ICsNCj4gPiArLyoNCj4gPiArICogQWNxdWlyZSBhIHBhZ2UgZnJvbSByZXNlcnZlZCBwYWdl IGxpc3QocmVzdl9wYWdlX2xpc3QpLCB3aGVuDQo+ID4gK3BvcHVsYXRpbmcNCj4gPiArICogbWVt b3J5IGZvciBzdGF0aWMgZG9tYWluIG9uIHJ1bnRpbWUuDQo+ID4gKyAqLw0KPiA+ICttZm5fdCBh Y3F1aXJlX3Jlc2VydmVkX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IG1lbWZs YWdzKQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlOw0KPiA+ICsgICAg bWZuX3Qgc21mbjsNCj4gPiArDQo+ID4gKyAgICAvKiBBY3F1aXJlIGEgcGFnZSBmcm9tIHJlc2Vy dmVkIHBhZ2UgbGlzdChyZXN2X3BhZ2VfbGlzdCkuICovDQo+ID4gKyAgICBwYWdlID0gcGFnZV9s aXN0X3JlbW92ZV9oZWFkKCZkLT5yZXN2X3BhZ2VfbGlzdCk7DQo+ID4gKyAgICBpZiAoIHVubGlr ZWx5KCFwYWdlKSApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIN Cj4gPiArICAgICAgICAgICAgICAgIiVwZDogZmFpbGVkIHRvIGFjcXVpcmUgYSByZXNlcnZlZCBw YWdlIGZyb20gcmVzdl9wYWdlX2xpc3QuXG4iLA0KPiA+ICsgICAgICAgICAgICAgICBkKTsNCj4g DQo+IEEgZ2RwcmludGsoKSBpbiB0aGUgY2FsbGVyIGlzIGFjY2VwdGFibGUuIFR3byBsb2cgbWVz c2FnZXMgaXNuJ3QgaW1vLCBhbmQgYQ0KPiBYRU5MT0dfRVJSIG1lc3NhZ2Ugd2hpY2ggYSBndWVz dCBjYW4gdHJpZ2dlciBpcyBhIHNlY3VyaXR5IGNvbmNlcm4gKGxvZw0KPiBzcGFtKSBhbnl3YXku DQo+IA0KPiA+ICsgICAgICAgIHJldHVybiBJTlZBTElEX01GTjsNCj4gPiArICAgIH0NCj4gPiAr DQo+ID4gKyAgICBzbWZuID0gcGFnZV90b19tZm4ocGFnZSk7DQo+ID4gKw0KPiA+ICsgICAgaWYg KCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhkLCBzbWZuLCAxLCBtZW1mbGFncykgKQ0KPiA+ICsg ICAgICAgIHJldHVybiBJTlZBTElEX01GTjsNCj4gDQo+IERvbid0IHlvdSB3YW50IHRvIGFkZCB0 aGUgcGFnZSBiYWNrIHRvIHRoZSByZXNlcnZlZCBsaXN0IGluIGNhc2Ugb2YgZXJyb3I/DQo+IA0K DQpPaCwgdGhhbmtzIGZvciBwb2ludGluZyB0aGF0IG91dC4NCg0KPiA+ICsgICAgcmV0dXJuIHNt Zm47DQo+ID4gK30NCj4gPiAgI2Vsc2UNCj4gPiAgdm9pZCBmcmVlX3N0YXRpY21lbV9wYWdlcyhz dHJ1Y3QgcGFnZV9pbmZvICpwZywgdW5zaWduZWQgbG9uZyBucl9tZm5zLA0KPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJvb2wgbmVlZF9zY3J1YikgIHsNCj4gPiAgICAgIEFTU0VSVF9V TlJFQUNIQUJMRSgpOw0KPiA+ICB9DQo+ID4gKw0KPiA+ICtpbnQgX19pbml0IGFjcXVpcmVfZG9t c3RhdGljX3BhZ2VzKHN0cnVjdCBkb21haW4gKmQsIG1mbl90IHNtZm4sDQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5yX21mbnMsIHVuc2lnbmVk IGludA0KPiA+ICttZW1mbGFncykgew0KPiA+ICsgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+ ID4gK30NCj4gDQo+IEkgY2FuJ3Qgc3BvdCBhIGNhbGxlciBvZiB0aGlzIG9uZSBvdXRzaWRlIG9m IHN1aXRhYmxlICNpZmRlZi4gQWxzbyB0aGUgX19pbml0IGhlcmUNCj4gbG9va3Mgd3JvbmcgYW5k IHlvdSBsb29rIHRvIGhhdmUgbWlzc2VkIGRyb3BwaW5nIGl0IGZyb20gdGhlIHJlYWwgZnVuY3Rp b24uDQo+IA0KPiA+ICttZm5fdCBhY3F1aXJlX3Jlc2VydmVkX3BhZ2Uoc3RydWN0IGRvbWFpbiAq ZCwgdW5zaWduZWQgaW50IG1lbWZsYWdzKQ0KPiA+ICt7DQo+ID4gKyAgICBBU1NFUlRfVU5SRUFD SEFCTEUoKTsNCj4gPiArfQ0KPiA+ICAjZW5kaWYNCj4gDQo+IEZvciB0aGlzIG9uZSBJJ2QgYWdh aW4gZXhwZWN0IENTRSB0byBsZWF2ZSBubyBjYWxsZXJzLCBqdXN0IGxpa2UgaW4gdGhlIGVhcmxp ZXINCj4gcGF0Y2guIE9yIGFtIEkgb3Zlcmxvb2tpbmcgYW55dGhpbmc/DQo+IA0KDQpJbiBhY3F1 aXJlX3Jlc2VydmVkX3BhZ2UsIEkndmUgdXNlIGEgZmV3IENPTkZJR19TVEFUSUNfTUVNT1JZLW9u bHkgdmFyaWFibGVzLCBsaWtlDQpkLT5yZXN2X3BhZ2VfbGlzdCwgc28gSSdkIGV4cGVjdCB0byBs ZXQgYWNxdWlyZV9yZXNlcnZlZF9wYWdlIGd1YXJkZWQgYnkgQ09ORklHX1NUQVRJQ19NRU1PUlkN CnRvbyBhbmQgcHJvdmlkZSB0aGUgc3R1YiBmdW5jdGlvbiBoZXJlIHRvIGF2b2lkIGNvbXBpbGF0 aW9uIGVycm9yIHdoZW4gIUNPTkZJR19TVEFUSUNfTUVNT1JZLg0KDQoNCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 05 06:52:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 06:52:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321449.542452 (Exim 4.92) (envelope-from ) id 1nmVLK-0006H2-BI; Thu, 05 May 2022 06:52:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321449.542452; Thu, 05 May 2022 06:52:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVLK-0006Gv-8B; Thu, 05 May 2022 06:52:06 +0000 Received: by outflank-mailman (input) for mailman id 321449; Thu, 05 May 2022 06:52:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVLI-0006Gl-N5; Thu, 05 May 2022 06:52:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVLI-0006hh-LS; Thu, 05 May 2022 06:52:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVLI-0003Si-6q; Thu, 05 May 2022 06:52:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmVLI-0002Dx-6M; Thu, 05 May 2022 06:52:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mJYwGHBf9CFqx40qL8yVyTMphpDEstvfPhwUbeF2nbc=; b=PBRcD8o4mpvT9D4sYgjZTy1tNS zbbu0NKIO70lBE56+4GTNCVCTG8aiWeHt0lbh8tN1fHjM35UUKAHpDZVKn8RYIgGb7seb6OP5NWCx tL0unTWhN+mw92ZWXFmIk63D06GBDwOYHDr60NOm+v1XB7zwhV1IffmEtaFh7giwvaDo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170139: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 06:52:04 +0000 flight 170139 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170139/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 812 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 07:20:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:20:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321502.542483 (Exim 4.92) (envelope-from ) id 1nmVmr-0001Ue-SI; Thu, 05 May 2022 07:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321502.542483; Thu, 05 May 2022 07:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVmr-0001UX-PK; Thu, 05 May 2022 07:20:33 +0000 Received: by outflank-mailman (input) for mailman id 321502; Thu, 05 May 2022 07:20:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVmq-0001UR-Oe for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:20:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d8bf0952-cc43-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:20:31 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-yTHRmf6YN7-XHXyB-OSbhg-1; Thu, 05 May 2022 09:20:29 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB4545.eurprd04.prod.outlook.com (2603:10a6:208:73::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 07:20:28 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 07:20:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8bf0952-cc43-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651735231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sp07AszI1s7SokeGwBG60Tm9noCAWBn8yawQFWbTxu0=; b=W1MHVL3EH8TWalRWIhRU69MF5yp3CFM62j0tcdDL7R9kod66dRrmSotdCt2mJtf9Jjl+Na Dkzs+1KXSkB/e2ay/IsCyU6jFACMKSyMcCvjsolMSKz2Bq+Ht8aeze6bHek4FFrTI5NRJx zxTzZdkuu8OqSzIe7klIMIcOhL+EAtM= X-MC-Unique: yTHRmf6YN7-XHXyB-OSbhg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKBUMi467tJl/L01Wn0JBCcLuWvhAAL3dEWirMWh+QoJiOt1sW09JSuAdeVDEQKoa8LuhNIfNeJ/8SZL4PBzDtq1Qv33x9qw/V0vPejrAhqCd6xw7RTwqj9QFEjY+2HMTqGLHPlMpmTo6jMFY3qQi5eOzkaaKtHkQ0Nnxr/Nc2wzU56mu+VpI66zpsKLI39skvbRG0QhProyjAzBIgjMb3N+HHB1DI9UvYSNPobvpAnPuWxTnfdiUAur4vhAnoiK8LTNUN4ax4UnLl0GLbfIrZq6yDPq//NfPv6wIkGH/YYzbjz14Veyf7xf4qw0RzGHO8cPN+0Gb2zOqgccbKrndQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sp07AszI1s7SokeGwBG60Tm9noCAWBn8yawQFWbTxu0=; b=NNsJp6EZNS4r8b+fXyClB+X//tQMCC0dCWUecGDpcVAKJB39i8u+X8ctdx+mdCVDRwUTXov2TxPBpxYrUo2l0Ipky9J5dgRZe+TJudKrzvqcIxqpAxbZuMSX8tlX5LAfrOLPvE4DpvqAJ53gLt+tPztFSZ+pKIuWFkDD0NqSoGR05yNc6xvC4oUf53DaS5pG/785v+NiyHFUgurs+b4B7WPElSxUqNN/PhsFVb/JdHb2EM3SURvM8ROf/ShZoqCp49VXjgl2EIROcUSxKDWFeAGoB3ykGMRyJyYNDsuSVKgSehEvnIu9LRTRJ6aXrJ1r9FxEqioiuIGKNOOwwUt8bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <89fa76cc-2fa0-5ec3-64d7-d83407b8a495@suse.com> Date: Thu, 5 May 2022 09:20:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Content-Language: en-US To: Henry Wang References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-3-Henry.Wang@arm.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20220505025407.919988-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0152.eurprd06.prod.outlook.com (2603:10a6:20b:45c::21) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf45d3db-350f-486a-1bc3-08da2e67bac2 X-MS-TrafficTypeDiagnostic: AM0PR04MB4545:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 22hGQP4UTHVt0xS0w8TXUWOOP8Sw6SP7pKs6+Rq1p5+FoV5OdxGjiCk8zCR+IEzFTHCbbeufmHmkK357kE06lvWYXJ6p0vI1k63mPfzYXCFhY2KyoZRPTcG7nQzbifZ5TU6H0EAQ7WTdm1VcdRUzluRGCol6BwZXvUPGquhk12fgTdTfnAFk1/DCkv7UdV5jCDKor/sakKEH70BSbiBFRkUbDGZf2N5P69h206S2rSwq979+eynThCmWT8S3zfFSFytX1JaVoMj8tKCC8oo8Opli4NkLMusLEgFYKiY8a0BbcroIhoeLt/at0wjnZsbXMeAUywUdYxqpyh3EfxLhTjKhlYMP4eskPP1ePAX93UBsnRQmz3pCJFxaGuZfg3HUBQZgFxA6XDQvjbozmiwhMJX/0IHzvrLv7dDEapPEsPo8oYGtPVDQ9R+iEIfoAU2s/kk08jzOmTBgluFD7PLLjfFtJKzsoZ737k9a+tn0MlBU3aOCifXf6VrhgysBHfSZ9yt+cIIYQpmOrGJfn8JeaL9U2Mqp/8qA5jT/NXbRQzaw9jgFQLvyiSblUkiZF00KabKJAZG45U7b4t6GU5kE8N7vIUFqIHpL5crxzweomUpncEXs7OdO5iR98LkBDPElg5CmdpV73oCcl2KoSdS4qI7nUravcMZu+l4FG+tLwgW2BJQjXKSJCBKxLQBoIDh7dYRNg7Et7TTGwOvwPOPB7cPhrCZB/33tah9+Z05lPD0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(6486002)(6916009)(8676002)(31686004)(5660300002)(316002)(36756003)(38100700002)(2906002)(508600001)(6506007)(53546011)(83380400001)(2616005)(8936002)(31696002)(4326008)(66556008)(66946007)(66476007)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW9NQXNzNlhtSzVXTXRGNmRPa0dodjNiWUZabnhLTFh2Zks3VXkzLzBwWDNW?= =?utf-8?B?Yk9Xdnpxd0JMdFBMaTdpY2l3aGIrK1NTd2RTTGdjMk5UZzhQWEZ1d3EzMGVF?= =?utf-8?B?WW5SMnUyWERSTzFNb3ZiRHFLTDNGZ292Sy9EVldjQ1VJcHhEM1M1R2pXTEtx?= =?utf-8?B?c3Zyem9CQndEUHIxbVBxOUJUeEphZnYyaDhrM2wzUWNrTUNoTkQ3Z0dHSStG?= =?utf-8?B?Y2lGOHFidGNEV1pEQ3BTRHp6eFRtbDNHVXNleDJISlVhS2lBZ3hiVU5kejBE?= =?utf-8?B?Sjh2RVNPZ3ptZ0Y1NjdGWEZHUlVQNmlNeFl5L2JXdC81Mkg1MzVDZEFoMUtl?= =?utf-8?B?b3AxdSt6T0JhQTA0bkoweGdkZFlOeFIxR3grTXlUNDdmL2ZPVlFBcG5oclpv?= =?utf-8?B?QlZKRzd2QndVN2N4aHNCR0ZXVlNYMEFGbWNzakc5blZXUnBHMVZHbWdodGFT?= =?utf-8?B?bUdCRnNTRVhHcGN2dzFxOEFzY2piWlNBTWM4NFNJRGh2UzU0cHk2K2U2UGNX?= =?utf-8?B?SUxwd2RxZWNWVC8wZjdjYmR1MlYxSXJCa1pUOE9mM1h2NGhiaDNuL3hRYlph?= =?utf-8?B?blBBUXg2dU4rSXpyUjNnNmk0am9zbzV1eXpJa3dFbGpFL0xqRkxBWERDMllP?= =?utf-8?B?UTJUa0NQUWFQQzNxSjNML2hENTNUWXJzQzh3N3NSWGxvZ2hNU2FZWUZFbE5k?= =?utf-8?B?dUZjazRJbW9QSlNnejJ6NWU4WS9YbjVLVW5PNjlTL0VTR1dBRHRiTXhvZVEw?= =?utf-8?B?Z3JBcmtZZDdKM3JqUzVtbkJBc0lNcG1ZNHNncjdseWlBUDV5Vm5wRDVWV2Vs?= =?utf-8?B?RUlMWnIzZ1h3UmgyNEk0cWF4eHltcW0xUllQY2F6VEU5dXpaK2RnbkRzNGlv?= =?utf-8?B?ZUordFExWlJ3ZVYzOWErNW9WbTVLV0hGMzh2SUcrUDkvajB6SDZtcDhaSCtM?= =?utf-8?B?YUdzZHlHdExYRGtTei9EZE9zZkRPa2hNVkNqREN0aVdNSGd0NGhoZHRWU05R?= =?utf-8?B?L1NRNEFFM2RFb1g5NGM2Ym5kU1NCSXREVWVSUDFtSENJWUNKUXFZY0RzcEVM?= =?utf-8?B?TE1RUnZCMHBEVWViMVZNMHU0MXNieVNLSE93dGtQZHE0Ykp2RDlsZDQvSGNn?= =?utf-8?B?L2VpbkVPSTdWVFFuWEh3U0w2VHZLR0RwT1R6QkEwODdoTTBLelBqalI5YkN2?= =?utf-8?B?R0tGU3d4TEdxanFxeEVVQks4OXlLVzd3R2cza1F5SjVaVzZVK3BLNmxSdDdo?= =?utf-8?B?WmRESG5CR0xsYkNqaDd0QlV3djFoWGlobEdkZmRUbk9NVG9mNGpjZmtpMWFY?= =?utf-8?B?OGZ3RGxTTlNKcVVmN2hIdGFwaUlzeG84VEdudGVqY1FyOUFRdjNLbzN4emc3?= =?utf-8?B?c1VsWUFPWTZPbHdQYkhzclp0Mi9LM2FRTHZyR2xMMC83SzhhejBsZ3BXekk1?= =?utf-8?B?K1dJd3BENm0wWkhib2NnaUtua3NnMVN5cCtqbkdCMFdkK3A1WG0zQmJ1SDBU?= =?utf-8?B?bjJEVnZXdzZjNkk2V3NtYVJYOElFUS9GT0ZYUm9ydXI5VnFSN2lIbGN2aGYz?= =?utf-8?B?aGEvT2hIYXIwb0gyY1ZOQ0FlVlNpRjR5czUvbW41VFhIQWl3Mm1iUG51Y2Z2?= =?utf-8?B?MTJuOGpnVCtqLzZUU1gxUDFXYlcvNkRlSWRHK05ra2RiTDBlZXFRWWhES2xZ?= =?utf-8?B?QmFYZ1BGK2F0Y3pUZ0o0c0dBUGNocmZpUjl3cGRvNW8yWWdpbDdoRjNHaW5R?= =?utf-8?B?Y0N4VlNWYmNzRTE5bnZwNy9xcDVWY21MWmZvclM4QWkyQlVKbnJJR2VTbVYz?= =?utf-8?B?MHdmN1Y4L1pONzRxOVF3N1ZydDFQZ2JJenpqVng1OEJEaTZuUUl2S1EySlh3?= =?utf-8?B?MmoyUW9GQTlGSk1tVVREUFlMSmIzUjR2QTgxZi9TYXladklTZDRZcE9pZFV1?= =?utf-8?B?RmFlNW5BK2NOMzE1WFhrWGVKQWFaSjVPRWo4c0NOUlNlTnF2bTkwY2cyeDY1?= =?utf-8?B?Y0Yrc0tOcC8vVmc2VHo0SFR5UktqdTFma3pzRWtzTHBXalZkZlNVa3RFMERs?= =?utf-8?B?Y3hzTVpweUZuYmluQzcyRXpwUWRKa2MzaHlnWCs1b1BNeVpuN2lER21uc2kv?= =?utf-8?B?S0M3dFdyazgvTFk2UkVMMlpYNGlIL0ROdDNsMHY2dHBKTEF1NFQxdXZmKzJ4?= =?utf-8?B?aEdCampNNjNGR3QzbHpFbFc1aFFnYkVoVTUvTWFFV3VJL3ZxVTdFMWZPWU1U?= =?utf-8?B?QWxaYVVEUm13SDFHcFZYWVBEdFNxeDBNanNtU0ZGdXdTLzNERlVxdGFUYmVm?= =?utf-8?B?Ym9DNnBWNDVyblpmc21PbkhvSjhsUGZwTU5xZGYwaUpKVFlrc25vQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf45d3db-350f-486a-1bc3-08da2e67bac2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:20:28.0670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: foebnPAj6JL446/+xKoNJHlVdFrkjtunLFkpTMlEgKdqK7t4NgVu4AT/HAbqLhRnZDhw5JrEp2isa6EDOsydfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4545 On 05.05.2022 04:54, Henry Wang wrote: > xmalloc() will use a pool for allocation smaller than a page. > The pool is extended only when there are no more space. At which > point, alloc_xenheap_pages() is called to add more memory. > > xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not > rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in > alloc_xenheap_pages(). Hence, this commit moves the definition of > ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT > to replace the original assertion in xmalloc(). > > Reported-by: Wei Chen > Suggested-by: Julien Grall > Signed-off-by: Henry Wang > Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67 Just two formal remarks for starters: What's this last tag? And why am I on the To: list of this patch, when ... > --- > xen/common/page_alloc.c | 7 ------- > xen/common/xmalloc_tlsf.c | 2 +- > xen/include/xen/irq.h | 7 +++++++ > 3 files changed, 8 insertions(+), 8 deletions(-) ... with this diffstat you should instead have _Cc_-ed REST maintainers? Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 07:25:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:25:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321509.542494 (Exim 4.92) (envelope-from ) id 1nmVrF-00028o-F3; Thu, 05 May 2022 07:25:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321509.542494; Thu, 05 May 2022 07:25:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVrF-00028h-Bh; Thu, 05 May 2022 07:25:05 +0000 Received: by outflank-mailman (input) for mailman id 321509; Thu, 05 May 2022 07:25:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVrE-00028b-Gq for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:25:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVrE-0007IQ-9F; Thu, 05 May 2022 07:25:04 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmVrE-0003ir-3b; Thu, 05 May 2022 07:25:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Cc:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=rswWiS6EWY9ocAYetmOTtZ6L0xXY+2ny9cCO8dMRdjQ=; b=Jx2a1uaFQZajXKRsUI78YU4O1r dCx0In7YAzSVyz3zKMUzVI6Z/xh08H8GHn4IacJIxBsYru2yKbMKtbPgJm7kgdNCX7jRmoo6dhDjm pXB6ysZbT6lvH5r4kVadbtXfoFF7GLJAYcpug55ZjvRgRj1U1hVNW0wngOJlQP/WDTfk=; Message-ID: <9b082ec7-c9a1-18ac-5d7e-59922480ea65@xen.org> Date: Thu, 5 May 2022 08:25:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable To: Henry Wang , xen-devel@lists.xenproject.org, Wei Chen References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-2-Henry.Wang@arm.com> From: Julien Grall Cc: Stefano Stabellini , Bertrand Marquis In-Reply-To: <20220505025407.919988-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, The CC list doesn't seem to contain the other maintainers. Please use the scripts provided in the repo (such scripts/add_maintainers.pl) to generate the CC. On 05/05/2022 03:54, Henry Wang wrote: > With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before > local_irq_enable on secondary cores will lead to > > (XEN) Xen call trace: > (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) > (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) > (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 > (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 > (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 > (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 > (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc > (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 > (XEN) [<0000000084000200>] 0000000084000200 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 4: > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || > num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 > (XEN) **************************************** > > on systems without a big enough pool for xmalloc() to cater the > requested size. Can you explain in the commit message, why this is OK to move the code after enabling interrupts? > > Reported-by: Wei Chen > Suggested-by: Julien Grall > Signed-off-by: Henry Wang > Change-Id: Iebdde81f52785b0c6e037c981ff68922db016d08 > --- > xen/arch/arm/smpboot.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index 7bfd0a73a7..a057e85ac1 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -361,9 +361,6 @@ void start_secondary(void) > > init_secondary_IRQ(); > > - init_maintenance_interrupt(); > - init_timer_interrupt(); > - > set_current(idle_vcpu[cpuid]); > > setup_cpu_sibling_map(cpuid); > @@ -380,6 +377,10 @@ void start_secondary(void) > cpumask_set_cpu(cpuid, &cpu_online_map); > > local_irq_enable(); > + > + init_maintenance_interrupt(); > + init_timer_interrupt(); > + > local_abort_enable(); > > check_local_cpu_errata(); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 07:26:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:26:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321515.542505 (Exim 4.92) (envelope-from ) id 1nmVsP-0002iI-Q1; Thu, 05 May 2022 07:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321515.542505; Thu, 05 May 2022 07:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsP-0002iB-Lo; Thu, 05 May 2022 07:26:17 +0000 Received: by outflank-mailman (input) for mailman id 321515; Thu, 05 May 2022 07:26:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsO-0002i1-Ah for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:26:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a58ae20d-cc44-11ec-a406-831a346695d4; Thu, 05 May 2022 09:26:15 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-To9vQ7ZVMmKzJcZ_J2FH-g-1; Thu, 05 May 2022 09:26:12 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5192.eurprd04.prod.outlook.com (2603:10a6:20b:e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 07:26:07 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 07:26:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a58ae20d-cc44-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651735574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TB0faeh4zp13fDu5tnUkmcmjBzWc6IWHLvzQtK/pD7k=; b=hRuHD/NNoFlTjaxrabzlbWGCQNQ1S5IpsnxqeDMvRSEVwqw1qNxF+sRUQX4XM1Gn5DjT7W +cbqWReFfKzNCkvcSBByjJGTq7OtFnI60MZReAMVTfMI0TbA2YecHRlXZiw9x0kUpIKEij 7TL8u/CvryohzH4HDgNZONXDLdSQw6E= X-MC-Unique: To9vQ7ZVMmKzJcZ_J2FH-g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=meLBR5R75Ho3qlQCIoj2lEKJcGxd9IouCmVK65XQYjJcFK73tday7FGUPIhL4e3L+X6Snb2N0CMgEBl9wD1xnJk3YdBsHTqs05MW2GrtNjn07tGQfPznLrHwekD7xxl2FXwcm25bev80Cu18+Q2xWh8ezsp1AS94nVLKrCueOYqv+gkNeO7jagXysk3H0jq1pml29bJbkEqbXqgfFk1OtXTBPiHMZnRv2XTup5yrudgwSmV5X/CZNI+nKntwsGot/zTOyHRgArVXI96QgEywDoG5FdNKGmTanoVrOjFuUBwXXdjHK0Ifm4Y1x0mCxvJvn1MqEH1QxGT2prqUaaNXOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TB0faeh4zp13fDu5tnUkmcmjBzWc6IWHLvzQtK/pD7k=; b=iwlcOp9MbAPocpXK/w9z92+ty1PKV5IM1KHFQs7gE/32caMXhyIowcoBVOxWYSeGiBIllC5Kc/wRaPuSryskj1AosXh7yP59i0c438Br0bs8idesL4Swh6hJrP4qrXdq4i2+/5uTsCJ7E3CaU7HmcNLwe7c0fWuZ1f0W/vcyWeyOPGyKC7WobhfPcPwkzxUKsXq2W7yckraQtqw8NTZvQO5/UlUlyl2dwj7Jxtu01EihhCyqCE6RQ+f88HqzWmldS0jT+ogY17YJVLabggnqdQQO+b6Rinea7qRZOoT+0R9STGag9Qj2IQoo6MJIaZJjqvs3exl3Wv9QR17gzYaRNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e3aa32b-5b6e-7432-a6db-f2e8f9937c2a@suse.com> Date: Thu, 5 May 2022 09:26:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Content-Language: en-US To: Stefano Stabellini Cc: jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220505001656.395419-4-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20220505001656.395419-4-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0100.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::41) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1df2e99d-5be0-4d39-ea4e-08da2e688548 X-MS-TrafficTypeDiagnostic: AM6PR04MB5192:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kWGnrrkbaJzX7/yOZSO6y9tewEmh7N9WxEPKF3TVTeFzOYwqGXfWoh8rjUmLidYXaWgr2l4INZbH/P+vme3F2hO2yoipyl5JxrMo/2VugySe4/3AETysT+bc2ZIZgexow/mkPON53vVzlkA9kcgC+m1mUNmSncCyNwm8OA6Bl08KhvgL2WolzhyQKbW04yIaBNWtAWqnpflPZIdh68fqfAKWCGquwd8wQhmaROwjDg8KxjgPX0GTDXLk9aNVS5aOL1bNvj82J3VGAvZijcHEk9at6wP6nRM9XSWTGQTNOpFj18ZXKGk6dtWRfV3qLwkUTai0C/9k8j+TD0O3zGEEw5ZHx3eoRIj0kJa6FL8ZUMhGs1fQ3HE5/Tf5remNEwp+bXgHtFcpM9C4ARpB2gdKsesJ0GMAJ7U2oQUhYdRQMuadGhCc+yRVJqdZhaepn8NlCSLQL3n55BT3WkEQ4lj4Mh25OmRJJLfw3YE8IRcsg2p4BFetkjwKhOKwqXef0y7ntSVpv2G4edXYz+679nclzu0tmY0G+leDrXYsSUUduxIi98X6Hbxmp6xyE+dVPOy7a8MRZ7v1U/a8rKcKMGDeg8Vo9MAtkkuvPxN6xOycOmv1CHxSCclBzOYHINEoM9ChkVRMdXQDdok3TQjoBtr8lDy7zSqj/FAjBG1tBaVbRj+TOZilxdNllm4TNqE0SM+FcvktHOImLAx24u2CZw8ms3atcmGZkmZrL5QwDt2Hjtrex9hQpsZeuG1E+ZUcEZWODp2uc8dDIF+BWGXsJOoHCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(316002)(6506007)(2906002)(54906003)(8936002)(36756003)(53546011)(186003)(31696002)(31686004)(86362001)(66946007)(66556008)(66476007)(8676002)(6486002)(508600001)(5660300002)(38100700002)(2616005)(4326008)(83380400001)(6512007)(26005)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2x5RkRJbWRUUmtReHhrUTdqZmE5UnltL3AzU3lWQ3QrM1VtbXhzZk9tM2VI?= =?utf-8?B?a3NPc2pJY0lrdjE0NTFwaTdKb094RU5FWFRMWGp5SzNiUmV1Mno4ME9pU2xj?= =?utf-8?B?ZWtQUHVxYzhEcnRhbDgyYXd3SFRuSldZZFBkQzRpQmhIYkRxMVBKNU96SkMv?= =?utf-8?B?VWRFMmw2NjQrSTZxeFhWL3ArQnFvV1ZaeC8wS1ltRU9JazRwdTlBVVlzNUtk?= =?utf-8?B?aXZ0dVNtQTVML2NCeEFZczFuZEZqaGNxOExOVVQzb1llTnRzdGJlem1DWTBP?= =?utf-8?B?b2h2RHJKKzJFVnhueEM1Y05RS09DaXJ6V1YrSVEwMTJlTTBkZkJ3UklJbWtV?= =?utf-8?B?eUpSZUhoVG1zNk9CSFNWMmhGN1lFaFQ1dWN2TGZYNWdPaFZhSmVJZFRFWFk1?= =?utf-8?B?THdHWXE1RGdYUGxoR29oWjVpYWxaZWEwNnJUVm1EYWxzaGNPa2RFMDlaSW9l?= =?utf-8?B?S1J5ZElXUTJGQWRvaVBUU1dkbDkvckEvRUUwMmdya0MrdERoR0RXQ1QybzdY?= =?utf-8?B?YkgzSWUzd0U3ZFBnS3M4RHlEcU9kdDlGK1RwMFAwT09UQ2N4TzlpeFlMZUV3?= =?utf-8?B?b3BISGZ1aWtTdFVmUzdtVHkvS2gvd2Q3K0dHWkc0SU1wSzc0Zks4TjNlek9S?= =?utf-8?B?bXl0ZlhzOVVCOWExWm5YdFg0TkFrL25TOEVuTjM5dTFvYmRIRDFqcVlaeHd2?= =?utf-8?B?dk5aK3BKcER1RWhsQzJFOUREcFJ3cCtBbDdGN2h4VzVKYThNaDhQOGVMZkFo?= =?utf-8?B?NWJIN0wvT2cvRkdaQ2pyM05xTmVmaVczYjcwa0JTWUZScUtpLzZWS0lFbmhT?= =?utf-8?B?d09Lb0N6L0hsUUEzcHhyTmRpT000dWJUTE5rS0ducTJaLzFWNjJrWDM2N2xQ?= =?utf-8?B?SUhFWkFoY3VPZktWQWFYRGQ4QUNvSHFYTDN1dGNFa2wzRFhGKzJPWTVTdW9j?= =?utf-8?B?S0tGY1NQbmt4aEYyRGJJb2VSWG1WWXdYL0FhSmo3Mk1wZVphaFY3bG10OTRx?= =?utf-8?B?R0xRdEFGVHZvWGQ2WW94RmFvekZVT29DTEpBQXQvTHN2MXF6VzA5MGptY2JX?= =?utf-8?B?dC9weExiSWE0MG1VcVQrL3NyQm53SE52RDcrTmlMVkI4MlZ5R095Q1N5V2Fv?= =?utf-8?B?dE1FR0Q3QVJMYjJINWNhRnZkTXBUb2dCUGl3NGpvZUZHS3FhNUU2UzUxUUc5?= =?utf-8?B?aS9CT1liY0xYM2ZETlhCckdYcnNJOXZ4ejVXd0w1RmN3eXVGK0lFQmUzOE1s?= =?utf-8?B?RFZCTklucjZ5UnRMM3dPeVNpWU1wck0vUmk3NFFlak1yVUl2MzRkZEl2V2xR?= =?utf-8?B?akZidmJsUTFvZnBiem5hLzNmWTdOM0JVSlJqSjNXVXJNRHd3WnM3OWRySHh1?= =?utf-8?B?S28rOWZWckhuQVVteDR5YTVQbmFwSXNPeGNKWkp6ZjJPWmFsTGphais0ZVR2?= =?utf-8?B?UklyMEhNWFN6elBBbC9oaUZpMlMyMklNdzM0cjUyRU5mWWlzTTdHNXgrTVBy?= =?utf-8?B?ZlNnRkoreitEQ0hQZlZRbnhldWRiM3VsM2Y2THVkLzBTQTJISzMyTzRoQU9F?= =?utf-8?B?TUdVOFJ2TjI0VHJoQTZVczQ5WG00OStrRStyTlVwWVMxbFo5MSt1Mkpiamdu?= =?utf-8?B?OFVnS3VwM3ZRMXMrNWxqSkFBT05mbmkwNXhKL2FCdCs2TTVTNkxwQWVqTUlI?= =?utf-8?B?Rk1uK1VNNzFHZHVZSzY3bDNzL0JmYUYvZ05iblBnblFnN3FHYis4K3Z5dzNs?= =?utf-8?B?N2FVN1pUVW9VY01sQUYvM0FLVHhoWmdTdDBEMDd4MmtNUjlqUW9NM2hPV3lN?= =?utf-8?B?N25Mc2FhMWdLcFpxd1luVmYvVlE4OGU0WGZlV3N5YndiOWJKYUlPSndwZ1dI?= =?utf-8?B?ODM4K25DYUJEZ3pZYmFTNHVEWGFkL0dwU1R2WXRhQ0JYb0JjL2x5ZUxNaUtB?= =?utf-8?B?YlNLSkR2aXU2eVQrTG1wVlRURUNDV0IrT2ozOTJ0ZGtKVUFxb2J3WkU5YWZI?= =?utf-8?B?UlZVeVZrNUppTzVWbTZCYSszcGNVSDYwcnlBN2hEM24rU3BmNE1JYW96VUVI?= =?utf-8?B?dnlzSUZmd3FGV3JUdFRwcWd6dEhSdHYyWHpRRk9ubWtHVytzOWJrSEhiOGF0?= =?utf-8?B?Q0hjdGRIenY2YjVKa0lPeDh5K0hteEpwRmRialhzQ01vanFrUlNzSWtMbzN3?= =?utf-8?B?cnlNNldLOGxWWFI0VWZIL1J4VkdsL2ZaNnBaM1RTV0VqemNuTmF4U1c4d0hN?= =?utf-8?B?bmlzV0hFMFN2cDRwa1FUMGdwOWV6SjMxRDRwL09YemVzdnFzOExTakMxZzVB?= =?utf-8?B?clpZNHkxN0xiNUFUMEtCU0RqNUl0dUw4NytmWVpkcU1YVVMrRUVJUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1df2e99d-5be0-4d39-ea4e-08da2e688548 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:26:07.5377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kfBQvWJHGTfK0Tr+sZdt3iuJntoulIOPJqvIx31b6NaXNpVq9W6CawE7EmqCeUzUEDTRjMO8WBM1rYjmPNZcgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5192 On 05.05.2022 02:16, Stefano Stabellini wrote: > From: Luca Miccio > > Export evtchn_alloc_unbound and make it __must_check. > > If "xen,enhanced" is enabled, then add to dom0less domains: > > - the hypervisor node in device tree > - the xenstore event channel > > The xenstore event channel is also used for the first notification to > let the guest know that xenstore has become available. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: jbeulich@suse.com Somehow my ack given for v5 was lost? > --- > Changes in v5: > - merge with "xen: export evtchn_alloc_unbound" > - __must_check > > Changes in v3: > - use evtchn_alloc_unbound > > Changes in v2: > - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation > - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound > > xen: export evtchn_alloc_unbound > > It will be used during dom0less domains construction. > > Signed-off-by: Stefano Stabellini This is somewhat confusing to find in a post-commit-message remark. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 07:26:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:26:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321516.542516 (Exim 4.92) (envelope-from ) id 1nmVsa-00033B-7y; Thu, 05 May 2022 07:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321516.542516; Thu, 05 May 2022 07:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsa-000334-3t; Thu, 05 May 2022 07:26:28 +0000 Received: by outflank-mailman (input) for mailman id 321516; Thu, 05 May 2022 07:26:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsZ-00032F-7w for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:26:27 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0604.outbound.protection.outlook.com [2a01:111:f400:fe05::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab8aa85b-cc44-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:26:25 +0200 (CEST) Received: from DB6PR0301CA0056.eurprd03.prod.outlook.com (2603:10a6:4:54::24) by VE1PR08MB4880.eurprd08.prod.outlook.com (2603:10a6:802:aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 07:26:23 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::fe) by DB6PR0301CA0056.outlook.office365.com (2603:10a6:4:54::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Thu, 5 May 2022 07:26:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 07:26:22 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Thu, 05 May 2022 07:26:22 +0000 Received: from 0da885bd73fb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5478F56-CF10-4215-BEF0-4485B86DE714.1; Thu, 05 May 2022 07:26:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0da885bd73fb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 07:26:16 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5657.eurprd08.prod.outlook.com (2603:10a6:102:87::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 07:26:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c%7]) with mapi id 15.20.5144.027; Thu, 5 May 2022 07:26:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab8aa85b-cc44-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IbP0UoG5K9mb45h/x5+d+2imE8qyiye3V4qRjBIB+ZBJOSZCyG7IuB4aCQmROP881HvchL4QC55GnsTGpGqb6IvDalTVlv3Jl65BhgWZJTAESx1wDvmQLBE/YGbHtGac2yfT4xiKJS0SSjNn5RgE/yVlxqW6S4SM3XMXNVbK6XOLOGhdjCGd0dIUx++upx2a8V1KW17nzrGNss6G3twlwEHM8bb4tvfSX43HJLTR/3xuuIn0z/C/WlATphTNM7PlsDizaMss1P6jJ8hmzQ+j+EMdvLipisZa5zpFx74n+OvZPKf5v9U1Fs0+FdfcqbLucve7BymZR2OgDPjXuBRatA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVJx+fQtZfJL6kq/K9paKi/7lPDIbOoKWNe8gPSH4L8=; b=VjiOaSDuuizG5PgJrvFXUUGO/MD3KBej1cd4QDZJBkuGU6Yk1oWs6SB9q8hD/Jw7uvnKPk5yUXpYp0NAUwLOYOTgfahbTQYCxlCzIA5NkDqKVIvjh29L1Xoa12zUuejSwS8bcDaC+pTsAF8w+aKOFWmiXkaddmRTQII0Z7ojxW6UO3d3HoR+nOTM+gFrNxFNsCARZdwJCQmO+L4Ny4i+Cc9Cez2yxEszoftfQJduOWcf3kmzYgQfn22YwmK1ml/WTeEZbQZFc/lzdxPuJa6J8UM3n1vIIZXUToPKxAAulyfwVQ+XDYmrHeryinmzLGXbQlegzAYKFQHBzcCVNG7JBw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MVJx+fQtZfJL6kq/K9paKi/7lPDIbOoKWNe8gPSH4L8=; b=Wf45dtx5IkioNnS5vUmI1PdTZXNiaHHrvTvEujdBaNHf4lm5SSkDAbxF/u+sjFzf+nnx31ZRFWZKPwFP/AvsI2ToAnsAI1LktsvWMELTU9e96VLYyb5Mr3rQCN9MpP/jkPNwcqZgK+7FCtYJ+LDNqzIP8nJZN1N2We3qMxeZxTY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T/YiS7G3h2uHuXvToLeE7mFeHXu4tMabxjai9hRaigHZCQDDyzs7/PNI2Rf3okdk3x44By/5DSX/VFE8eGyoPv1hVIoHZ1aU+PSiN2ZMCvj+IuvsfbkRYR7fLVCAwedg9wU5qShSnm4VUleou9pNe8DRy8XXcdOBYUCR9BTwuUU34Lb5+1mr38GC+aSBDGMAS3vVkVSWRSxomEktnv4pfjdgJEWpC+piadX+t7YWPXmdca1JghssbHfYpqrbcZksyRCHEK7LuV4i0NXnvUIaj02RhgyiMncroAAJ8oSvzRhQCgOe6NkUyA8feqc3r3tYSIWZE4feuKvswZVQm7TwNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVJx+fQtZfJL6kq/K9paKi/7lPDIbOoKWNe8gPSH4L8=; b=euk3mSM7o9JNQHQUcnEMvpA7FCxT4JNYtWz3aV/K4x32K7icjwhh7oNFyzD0Dv0TPYbiEh3LOGyuqjw9XNEL+gAL8ndracOsCn+EVuR/aGOuNsjqqdc6KwFdMHz231UVFriX7CfrtVabGp2rt4GMQSuZJqawVQMvyeBAZWcC7QM/4r06Mt6/2mQxIcXGv8iJj54p1zO8nchBJ2LmaM1eVgki3XQ9Kaqrs6MLNE8gYolly5rAa39K4Z8jeV70nA4v06Gv7yYylLE4xSZyBBsdOH6QB58HC0DJ9V9wWrz7Su8pr7nWyeXS2uH6uEyTi25Neq7j1/pgbGnItOF5vndhGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MVJx+fQtZfJL6kq/K9paKi/7lPDIbOoKWNe8gPSH4L8=; b=Wf45dtx5IkioNnS5vUmI1PdTZXNiaHHrvTvEujdBaNHf4lm5SSkDAbxF/u+sjFzf+nnx31ZRFWZKPwFP/AvsI2ToAnsAI1LktsvWMELTU9e96VLYyb5Mr3rQCN9MpP/jkPNwcqZgK+7FCtYJ+LDNqzIP8nJZN1N2We3qMxeZxTY= From: Henry Wang To: Jan Beulich CC: "xen-devel@lists.xenproject.org" Subject: RE: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Topic: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Index: AQHYYCt7d27UDL4eL0mD7GPwQ0hwjq0P4NcAgAAAbhA= Date: Thu, 5 May 2022 07:26:12 +0000 Message-ID: References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-3-Henry.Wang@arm.com> <89fa76cc-2fa0-5ec3-64d7-d83407b8a495@suse.com> In-Reply-To: <89fa76cc-2fa0-5ec3-64d7-d83407b8a495@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 691DA8AC28908E4C82F50574E6A194AA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 36265f18-0826-428d-c4b6-08da2e688e69 x-ms-traffictypediagnostic: PR3PR08MB5657:EE_|DBAEUR03FT022:EE_|VE1PR08MB4880:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pYBP//IWadp2cSR+bdcnHHTvs+LwGE9sIhjOF8+YSkj5Fcd96qql5sQpJPbejUfJVuB9LqPnB+ytNsjWwj+5atInT6OkT84qHV2+REbOZgZLfVUUCZX2oCxoxI1JKMphczfhgsz2edRgjJDmW1YugCCHI4PVZcHRUrakZUT8IoZgSBvuobgvkx91vFPDCBI9yzgUJKyL2IZaHPaELxwOleq4rmF9ft9WEKmRY6FHcyyWOpSVudl799q8Mt58m6LqrNN/sZuX0SXI8Eb/g1DkkGIv9N1baSzU7egyEUBy8bDGyMC4uRW4KbyPraLGMdUCGsCKD5ppRbQi4qkozgQGLBRHhu4wtV4uIihaE3+E/IWHkutebzp13DscC6goUiXolG91/lUcd2fXp4YFMaKqeQVCxWDgYSDsUPDDKh8Yamwgas0XuaZj3WuhPMPiRDJGmPywdJgPTeeC4ja654XGRnYoXqZ6RVzQL8M9xwsWVTdcyT4LmxYSPLpzzur5mZcduBHvZaqkTaLxsLeag1jNpdE17LOnUTkbe0TJkRgJWCgqpMe8atohgQfj0aezYHzEeF0hIU5ohCir/ywJsNuqIziYnb2e8pM0UU9RLmCewTlUjkzNiXNM9oN4mqLOrkig0GtuztreATLTHaOWc/owNGCp4RjsbqMbKAGeB67NojbqQ9meK/q/b6DlIGrk3DVPeJKTni2aXuJ6mfjUlsxBvg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(9686003)(5660300002)(66946007)(76116006)(38070700005)(38100700002)(26005)(83380400001)(4326008)(8676002)(66446008)(508600001)(66556008)(64756008)(66476007)(52536014)(55016003)(2906002)(122000001)(316002)(33656002)(186003)(6506007)(7696005)(8936002)(6916009)(86362001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5657 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3523dab4-015e-479e-fae4-08da2e6888ad X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FdxO5YvX2AedXGbHy97opZ3jNmtfpQslfFum1As4EB0LR/zBKz1Fkq+tgF6ETnfR3fhPOZVNEoLGjF7TWWebH9lEOroVe7TnMGjpSeLzHnkbsfjSnnmHnYVGBI2Reb1RLTwlyB0BO82WNRRH5EGbh/rZsUe9MXNnbAb0uZL3bI0F8Gjfass2VFt3c2CwXc/VS++qgX5gSmwmDVLPAFSCfSO286qG8O/udnZNXFVciK6zPndn5M+vT/pQN6+3Q9Ypt8mEqdSh2pMOAgPzSjUNrJS3X468SMFyfWcYbTZvRZiccoKRWY+G4CWeMWi28CN9ynbNiKVN5J0CR1WbP75c4uuGBkI9FUrLHq1sGE4wXNMrTBRlPsKfUkyoMUd2dA3auT7QC2qDJuGxpfvFk4KRkMH1Qe2s227Jre0Az5a6kwn/udLjB5u7c1uY4Ukl31e6ODwZjVauNDbP5x+AKUjbAzCcZw/PKI3OmrLQOaQb7axf1Rg5APTDL+baS2BBaozYbWmHR5WDetrWOAXgj2OB5LPtwR8sdFrRMxTIOwWMnTcqm1VsvkuouCV4ks3xA1CzktUWaGEcNVw6hcAbX9DVasWVnHhoQeVNVXy3BYiovkSsj7iWYp2tS3iN8H1wt9IxMedQrkz7Mz8akCYmiyyL1jPfFThiBoDc8lpsEVcBy/KLVsfXF7osCarA4HxXkgtf X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6506007)(5660300002)(47076005)(40460700003)(7696005)(336012)(4744005)(2906002)(186003)(36860700001)(9686003)(26005)(316002)(356005)(70586007)(82310400005)(55016003)(83380400001)(4326008)(86362001)(81166007)(508600001)(8936002)(33656002)(52536014)(6862004)(8676002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:26:22.7119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36265f18-0826-428d-c4b6-08da2e688e69 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4880 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPiBDaGFuZ2UtSWQ6IElhNDYzZDIyNDFlODBlOGE3 OGQ3ZGJiNWIyMzE4Njk0ZDNjYTVlZDY3DQo+IA0KPiBKdXN0IHR3byBmb3JtYWwgcmVtYXJrcyBm b3Igc3RhcnRlcnM6IFdoYXQncyB0aGlzIGxhc3QgdGFnPyBBbmQgd2h5IGFtDQo+IEkgb24gdGhl IFRvOiBsaXN0IG9mIHRoaXMgcGF0Y2gsIHdoZW4gLi4uDQoNCkkgZm9yZ290IHRvIHJlbW92ZSB0 aGUgQ2hhbmdlLUlkIGJlZm9yZSBzZW5kaW5nIHRoZSBwYXRjaCwgc29ycnkgYWJvdXQgdGhhdC4N ClRoaXMgd2lsbCBiZSByZW1vdmVkIGluIHYyLg0KDQo+IA0KPiA+IC0tLQ0KPiA+ICB4ZW4vY29t bW9uL3BhZ2VfYWxsb2MuYyAgIHwgNyAtLS0tLS0tDQo+ID4gIHhlbi9jb21tb24veG1hbGxvY190 bHNmLmMgfCAyICstDQo+ID4gIHhlbi9pbmNsdWRlL3hlbi9pcnEuaCAgICAgfCA3ICsrKysrKysN Cj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+ IA0KPiAuLi4gd2l0aCB0aGlzIGRpZmZzdGF0IHlvdSBzaG91bGQgaW5zdGVhZCBoYXZlIF9DY18t ZWQgUkVTVCBtYWludGFpbmVycz8NCg0KSSB0aGluayB0aGlzIGlzIGJlY2F1c2UgYnkgc3dpdGNo aW5nIHRvIGFkZC1tYWludGFpbmVycy5wbCBJIGRpZG4ndCBjaGFuZ2UNCm15IGdpdCBzZW5kLWVt YWlsIGNvbW1hbmQgbGluZSB3aGVyZSBvcmlnaW5hbGx5IGl0IGhhcyBhIC0tc3VwcHJlc3MtY2M9 YWxsLg0KU2luY2UgeW91IGFyZSB0aGUgbWFpbnRhaW5lciBvZiBjb21tb24gY29kZSBJIHRob3Vn aHQgSSBzaG91bGQgZGlyZWN0bHkNCiJUbyIgeW91Lg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K DQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Thu May 05 07:26:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:26:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321525.542527 (Exim 4.92) (envelope-from ) id 1nmVt1-0003pi-Gr; Thu, 05 May 2022 07:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321525.542527; Thu, 05 May 2022 07:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVt1-0003pb-EC; Thu, 05 May 2022 07:26:55 +0000 Received: by outflank-mailman (input) for mailman id 321525; Thu, 05 May 2022 07:26:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsz-0003nZ-Qn; Thu, 05 May 2022 07:26:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsz-0007KH-PB; Thu, 05 May 2022 07:26:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVsz-0005I0-C8; Thu, 05 May 2022 07:26:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmVsz-0000QQ-Bi; Thu, 05 May 2022 07:26:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Lxtga3NJKsUKwIYbUmOwMT7fkW2OpwI6tHrele2cOm4=; b=cQjTtB0Vhsyj0zn9EhN7NXDUGS Su9nuBae7Jh+BS6vtqYEhs5c/v3lTbVLLoPikLFEhskwgb35S/zZjqMOv44HUhInRinfNc5T1VrcM VNa4QZtTCARAer30eizPUN6CiDAEh/HrKlI57BJLZHYKkO/MUXVmzpjJi3dSdHC/t4Ow=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170130: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215 X-Osstest-Versions-That: qemuu=9cf289af47bcfae5c75de37d8e5d6fd23705322c From: osstest service owner Date: Thu, 05 May 2022 07:26:53 +0000 flight 170130 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170130/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170110 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail like 170110 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170110 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170110 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170110 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170110 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170110 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170110 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170110 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170110 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215 baseline version: qemuu 9cf289af47bcfae5c75de37d8e5d6fd23705322c Last test of basis 170110 2022-05-04 15:38:38 Z 0 days Testing same since 170130 2022-05-05 00:38:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Hildenbrand David Miller Ilya Leoshkevich Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9cf289af47..1fba9dc71a 1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 05 07:28:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:28:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321538.542538 (Exim 4.92) (envelope-from ) id 1nmVuF-0004ax-1u; Thu, 05 May 2022 07:28:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321538.542538; Thu, 05 May 2022 07:28:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVuE-0004aq-VG; Thu, 05 May 2022 07:28:10 +0000 Received: by outflank-mailman (input) for mailman id 321538; Thu, 05 May 2022 07:28:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVuD-0004ac-8I for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:28:09 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0617.outbound.protection.outlook.com [2a01:111:f400:fe1f::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8e06781-cc44-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:28:08 +0200 (CEST) Received: from AS9PR04CA0134.eurprd04.prod.outlook.com (2603:10a6:20b:48a::9) by AM0PR08MB3761.eurprd08.prod.outlook.com (2603:10a6:208:103::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 07:28:06 +0000 Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48a:cafe::14) by AS9PR04CA0134.outlook.office365.com (2603:10a6:20b:48a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Thu, 5 May 2022 07:28:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 07:28:05 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Thu, 05 May 2022 07:28:05 +0000 Received: from 05d98706846a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8BB515AF-AEF9-4A82-9885-4396A0852A3A.1; Thu, 05 May 2022 07:27:55 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 05d98706846a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 07:27:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB6350.eurprd08.prod.outlook.com (2603:10a6:102:12c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 07:27:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c%7]) with mapi id 15.20.5144.027; Thu, 5 May 2022 07:27:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e06781-cc44-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AVtDFUk06UtQSF47zoKzsV7OZp344arAemapA2DVCW/4b4W0xft3kUkDOPIwX8VPR7RC/DzuFsbM3/3yBQ7OhaNxG8yWxs5LZiQtR2CZqAFc70xHQQ8IkQWTY1373TehxXdHWH2jIvWwr1T8W+KmmqmHvygoD0IQoSsxON03Ima+tSWWtZhPH5aiItCigOucKJ9ko3+DcOuAbntyU5Pyxor8lVt4wV+BfHRlmzySO6et53KdeBmZcxvKuj9Ipad8UlbABSL/4M9uye1utnWJP8+zcl82BoqK35IStrXi3jTflX1YiNvsJUxhMRaQ7Y3NShq/vZ7inSKfE6bRUS0i4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4pk0LjocVE6GhlK5fZwvyOKzsUSDK9bj8ABNjqw79Q8=; b=mhU2DFQlr5u0ZTdVg1NADU4Cp7olJ+9EsnQZZqz6kfGLZEL71wpZ4MkZ+Lkb/cyn7Sz3IZzBY9krqvRxkKYk6ivczqO8uxdDC6VBzT7DhzLZLGVqoztvT3aATaQBJilxP6eoTWnDBPz07udUvYAyyuKWnt/o/qJ+vBH3FD8EZk/SurgFR1XR7z/3WTs8ipnAYBabcyjdDyERMM63pXzFBiT/BvybrEevQYH+1Xo7P5QI8JMVbt8Pp3teiKVT42D429+KeLmoWNSfX6aBv/WQHmmIohp2KrjrbQ/QHjT4ZK6ESTjWzy/lmOzHPFcY7PioKHbIvwX1xMEsjuBESyI+Ng== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4pk0LjocVE6GhlK5fZwvyOKzsUSDK9bj8ABNjqw79Q8=; b=sfPumtZ9jMQBVK3wumxfkw1WnRvpeNjtbn2ilp6jg3pWQbIzg/F7S1rC2nTrDl1sPz16F3b/qHbJ7zNBCfx791wjNuCJoJIeLBEefe/ZcIprz42QExdArDxcWBd+TDonSW4ElZ8u+5JrafiB8Zqh0XayGabuIBqV6+wcM/eXbNY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgHEI/KrF148kdAPbVkhcuk9+7Yyfi7soQXPJ0MuReaeZv6yGWCqVVurUIfyoq4bN//8PGZ1RbASHSqQLBwroA2R18dal4VHTnfpVQQ5zcV9xC1s/1OVQpnehWP00GP7qacMaOoNe9W9kGMet5NZZWAwRjbigrHLKJ3UvKYy3M48C5gQp3FkZeqTHlxRqXmDHTVIt9rKBqIVY572yy6UNOE6uTHjOGtMrFd1ltd6qbhatw0Q5ZkALWCPu0FuKOV7KI1aPXsKzH0Z2GZaDheoYvBVbV/exRBGLfuk55w8O39+u6OCOxXQ93wYmlE38uo13JvOnRx34jgUYkap7y0QcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4pk0LjocVE6GhlK5fZwvyOKzsUSDK9bj8ABNjqw79Q8=; b=c/RppT8+TuYGvkMxI7Y/OAM/RsL18RjWM5fuqeAiIgREAKs2P3hgPSoh9BowncrIwUrjOj34Sr6I/yt7UVvQC2WNL37D/obx6V8dRiZ8lj2478El1GXBwfQn9kfGA9IpaA5haDGYvhsQuTs836o7+Gt6zJVsgnU0W4YLVDEQnhM+RPR/Z+JtI11aBAR9waT2qiLg2H9xViGtA7FT+p3cHeC+K82AsoTqp5synWOonBWy3OhqGL8QOtCQxW3urPUw+zn0+I+rXLzb3X3QZP8K9grQ02S94eL4MsX5xgOGREXrs9uXdG5BoorH9MvEk14f6jzAfOKe/+oss8wEg51l3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4pk0LjocVE6GhlK5fZwvyOKzsUSDK9bj8ABNjqw79Q8=; b=sfPumtZ9jMQBVK3wumxfkw1WnRvpeNjtbn2ilp6jg3pWQbIzg/F7S1rC2nTrDl1sPz16F3b/qHbJ7zNBCfx791wjNuCJoJIeLBEefe/ZcIprz42QExdArDxcWBd+TDonSW4ElZ8u+5JrafiB8Zqh0XayGabuIBqV6+wcM/eXbNY= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen CC: Stefano Stabellini , Bertrand Marquis Subject: RE: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Thread-Topic: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Thread-Index: AQHYYCt6dq3rsqHdhkOYsjKIcgbjk60P4h+AgAAAaRA= Date: Thu, 5 May 2022 07:27:52 +0000 Message-ID: References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-2-Henry.Wang@arm.com> <9b082ec7-c9a1-18ac-5d7e-59922480ea65@xen.org> In-Reply-To: <9b082ec7-c9a1-18ac-5d7e-59922480ea65@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 104F20D87291B9498A0762615E7B034C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 31610ca8-d10a-421d-2276-08da2e68cbe1 x-ms-traffictypediagnostic: PAXPR08MB6350:EE_|VE1EUR03FT011:EE_|AM0PR08MB3761:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ze/zCOkrewb+ZYtIm+6Tcvica9jU+914iMnVNPyKuqaSgxajUyb/tz23AjVsiE07EsXUq8wgzTrDiTNj5E1F7cNdqrT5LEwFKL6vDVsLU/DnXGG4IB4uHGwp1X6pkWzqo7+9ikgf4kAydf2Xlb0wctquzgmeTlJA68p73ezJ7lFtoyvUNUs9CENZhsg7eMenvvyc1Tt+ztudhsX+2y6r5t69ADsqqNH/udwKi6q3v9QWf8SMXER1NWtHjhsaSpwkwRU7M+4iEJy2S+/x16jYAfzFBM9HLWE3gGFDWVSlAZkJicVsPIHt50hkZxYjtX9ZvtnRb8+D707KNozXQUqj4bAzg3zyOsBx133bVbmZIbtu6YknavDd4gvdU4GkJJvx6ABRctqg4uoPUuPyZuH88gn3+zbEXLqv6MhQj7+daeBeEJ2fhcaHZmtdzNMLeTPlx6jHjg8m4zay907hZwfqZwY4SwEHh7CRLKbpYJHuEAVjgEibVc2xKl2s2zef9XyVNBzY50fdiue1W+vgwFfn6R4r5eS6zTa1V4J3u3ACAL2HGDZPV+VFAszyyPKhHrsumUL87cXeLWMK8WxHp4AedjIgr+Myx2QReEZXGgLB46Gmvl7E7iZFOqoyc7WpE4PRuDVjBZKIB2BaIc1vVaSjvw0wt26RwMIFoJGsZBaMhnf3qew29i4A3C/H8XytOwavzFnNge3SMfQe9qo6PDrMEA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(9686003)(6506007)(53546011)(26005)(86362001)(2906002)(55016003)(52536014)(8936002)(38100700002)(38070700005)(122000001)(508600001)(71200400001)(7696005)(5660300002)(4326008)(64756008)(66946007)(66556008)(66476007)(66446008)(76116006)(8676002)(33656002)(83380400001)(316002)(186003)(6636002)(54906003)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6350 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f15647f2-85fe-498b-6167-08da2e68c3fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kc7asACskBCK8gAjLcvGl0TvL5dHOGtjq/jQcqfxCeC3BcXCmJlQtkIegjTDo3EYKWotK7J4E8E6juGiGLblUFCZoqNGhXenIHorGsYDmyl01DyAp90YJ+/lGfw0XzO+WOvQDBhmhkIHS4q3Sz1r69ocHZpAGAzrYmDbd8LEovNQgVyHxPc3tGPwmYebdHD0m1yYkjnJUDaK6ZN1ZrOuLw5GGgzg4Qa1qeLEOIzeMTxaXgfVJ03aVfZO6MVNxIKUiV/S9JFEsMSic6UxNNJX/lAD/EJiiwyBCZfSxY4TdEYW1FKYaMYofPLbxHEBwyzx+23aN2n7PXwuSrRVR1DzAnHYx7AX7DmjI/wxvXMa3/OVzSr5ffIv6RO+dCaORpqQs8i3zaKfLConN9lntyl435J5Ear0bpc2zN6uf3Is8da5YqUiyatNoDRMkG5rP3limqPNnoj+X1S/Y9MiFG8BmaNZZXr3Oii8T0jFw3HxuiX07BIp8GxPfXaQ2HEI1mOOqcyV14iPduW8JmPtNLPARXutUyRgilABsSlHzXuuUIUh3FA0az5FmDAqHJ4g7TSZ+SKDAJR7ggXQ8iV2wFjW7gfzQW/qqVLw9Bn7GpFvk9vqzjMZNtZxoW3aEKHHxZqlqRzkIO9aGVpR/8y6hFb/XlOJVHsZU9p2fGKrud2ELhEKiRGExDE5VOw0LJOHrEyg X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(36860700001)(6636002)(110136005)(55016003)(54906003)(86362001)(316002)(33656002)(47076005)(83380400001)(336012)(508600001)(26005)(53546011)(9686003)(7696005)(40460700003)(8936002)(6506007)(5660300002)(2906002)(82310400005)(52536014)(81166007)(4326008)(356005)(8676002)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:28:05.7258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31610ca8-d10a-421d-2276-08da2e68cbe1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3761 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IEhpIEhlbnJ5LA0KPiANCj4gVGhlIENDIGxpc3Qg ZG9lc24ndCBzZWVtIHRvIGNvbnRhaW4gdGhlIG90aGVyIG1haW50YWluZXJzLiBQbGVhc2UgdXNl DQo+IHRoZSBzY3JpcHRzIHByb3ZpZGVkIGluIHRoZSByZXBvIChzdWNoIHNjcmlwdHMvYWRkX21h aW50YWluZXJzLnBsKSB0bw0KPiBnZW5lcmF0ZSB0aGUgQ0MuDQo+IA0KPiBPbiAwNS8wNS8yMDIy IDAzOjU0LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IFdpdGggdGhlIGVuaGFuY2VkIEFTU0VSVF9B TExPQ19DT05URVhULCBjYWxsaW5nIHJlcXVlc3RfaXJxIGJlZm9yZQ0KPiA+IGxvY2FsX2lycV9l bmFibGUgb24gc2Vjb25kYXJ5IGNvcmVzIHdpbGwgbGVhZCB0bw0KPiA+DQo+ID4gKFhFTikgWGVu IGNhbGwgdHJhY2U6DQo+ID4gKFhFTikgWzwwMDAwMDAwMDAwMjFkODZjPl0gYWxsb2NfeGVuaGVh cF9wYWdlcysweDc0LzB4MTk0IChQQykNCj4gPiAoWEVOKSBbPDAwMDAwMDAwMDAyMWQ4NjQ+XSBh bGxvY194ZW5oZWFwX3BhZ2VzKzB4NmMvMHgxOTQgKExSKQ0KPiA+IChYRU4pIFs8MDAwMDAwMDAw MDIyOWU5MD5dIHhtYWxsb2NfdGxzZi5jI3htYWxsb2NfcG9vbF9nZXQrMHgxYy8weDI4DQo+ID4g KFhFTikgWzwwMDAwMDAwMDAwMjJhMjcwPl0geG1lbV9wb29sX2FsbG9jKzB4MjFjLzB4NDQ4DQo+ ID4gKFhFTikgWzwwMDAwMDAwMDAwMjJhOGRjPl0gX3htYWxsb2MrMHg4Yy8weDI5MA0KPiA+IChY RU4pIFs8MDAwMDAwMDAwMDI2YjU3Yz5dIHJlcXVlc3RfaXJxKzB4NDAvMHhiOA0KPiA+IChYRU4p IFs8MDAwMDAwMDAwMDI3Mjc4MD5dIGluaXRfdGltZXJfaW50ZXJydXB0KzB4NzQvMHhjYw0KPiA+ IChYRU4pIFs8MDAwMDAwMDAwMDI3MjEyYz5dIHN0YXJ0X3NlY29uZGFyeSsweDFiNC8weDIzOA0K PiA+IChYRU4pIFs8MDAwMDAwMDA4NDAwMDIwMD5dIDAwMDAwMDAwODQwMDAyMDANCj4gPiAoWEVO KQ0KPiA+IChYRU4pDQo+ID4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKg0KPiA+IChYRU4pIFBhbmljIG9uIENQVSA0Og0KPiA+IChYRU4pIEFzc2VydGlvbiAn IWluX2lycSgpICYmIChsb2NhbF9pcnFfaXNfZW5hYmxlZCgpIHx8DQo+ID4gbnVtX29ubGluZV9j cHVzKCkgPD0gMSknIGZhaWxlZCBhdCBjb21tb24vcGFnZV9hbGxvYy5jOjIyMTINCj4gPiAoWEVO KSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+ID4NCj4gPiBvbiBz eXN0ZW1zIHdpdGhvdXQgYSBiaWcgZW5vdWdoIHBvb2wgZm9yIHhtYWxsb2MoKSB0byBjYXRlciB0 aGUNCj4gPiByZXF1ZXN0ZWQgc2l6ZS4NCj4gDQo+IENhbiB5b3UgZXhwbGFpbiBpbiB0aGUgY29t bWl0IG1lc3NhZ2UsIHdoeSB0aGlzIGlzIE9LIHRvIG1vdmUgdGhlIGNvZGUNCj4gYWZ0ZXIgZW5h YmxpbmcgaW50ZXJydXB0cz8NCg0KU3VyZSwgd2lsbCBjb3JyZWN0IGJvdGggaXNzdWVzIGluIHYy Lg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiA+DQo+ID4gUmVwb3J0ZWQtYnk6IFdl aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiA+IFN1Z2dlc3RlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5y eS5XYW5nQGFybS5jb20+DQo+ID4gQ2hhbmdlLUlkOiBJZWJkZGU4MWY1Mjc4NWIwYzZlMDM3Yzk4 MWZmNjg5MjJkYjAxNmQwOA0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL3NtcGJvb3QuYyB8 IDcgKysrKy0tLQ0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc21wYm9vdC5jIGIv eGVuL2FyY2gvYXJtL3NtcGJvb3QuYw0KPiA+IGluZGV4IDdiZmQwYTczYTcuLmEwNTdlODVhYzEg MTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL3NtcGJvb3QuYw0KPiA+ICsrKyBiL3hlbi9h cmNoL2FybS9zbXBib290LmMNCj4gPiBAQCAtMzYxLDkgKzM2MSw2IEBAIHZvaWQgc3RhcnRfc2Vj b25kYXJ5KHZvaWQpDQo+ID4NCj4gPiAgICAgICBpbml0X3NlY29uZGFyeV9JUlEoKTsNCj4gPg0K PiA+IC0gICAgaW5pdF9tYWludGVuYW5jZV9pbnRlcnJ1cHQoKTsNCj4gPiAtICAgIGluaXRfdGlt ZXJfaW50ZXJydXB0KCk7DQo+ID4gLQ0KPiA+ICAgICAgIHNldF9jdXJyZW50KGlkbGVfdmNwdVtj cHVpZF0pOw0KPiA+DQo+ID4gICAgICAgc2V0dXBfY3B1X3NpYmxpbmdfbWFwKGNwdWlkKTsNCj4g PiBAQCAtMzgwLDYgKzM3NywxMCBAQCB2b2lkIHN0YXJ0X3NlY29uZGFyeSh2b2lkKQ0KPiA+ICAg ICAgIGNwdW1hc2tfc2V0X2NwdShjcHVpZCwgJmNwdV9vbmxpbmVfbWFwKTsNCj4gPg0KPiA+ICAg ICAgIGxvY2FsX2lycV9lbmFibGUoKTsNCj4gPiArDQo+ID4gKyAgICBpbml0X21haW50ZW5hbmNl X2ludGVycnVwdCgpOw0KPiA+ICsgICAgaW5pdF90aW1lcl9pbnRlcnJ1cHQoKTsNCj4gPiArDQo+ ID4gICAgICAgbG9jYWxfYWJvcnRfZW5hYmxlKCk7DQo+ID4NCj4gPiAgICAgICBjaGVja19sb2Nh bF9jcHVfZXJyYXRhKCk7DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwN Cg== From xen-devel-bounces@lists.xenproject.org Thu May 05 07:30:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321545.542548 (Exim 4.92) (envelope-from ) id 1nmVwp-0005zB-Fm; Thu, 05 May 2022 07:30:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321545.542548; Thu, 05 May 2022 07:30:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVwp-0005z2-D6; Thu, 05 May 2022 07:30:51 +0000 Received: by outflank-mailman (input) for mailman id 321545; Thu, 05 May 2022 07:30:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVwn-0005yw-Uz for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:30:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48cc7b53-cc45-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:30:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 89312210E0; Thu, 5 May 2022 07:30:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 307CC13A65; Thu, 5 May 2022 07:30:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /s1tCih9c2KZcQAAMHmgww (envelope-from ); Thu, 05 May 2022 07:30:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48cc7b53-cc45-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651735848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+fW1f7/zymDhOc4ll/u+MKfC167UDYSprVePkH1SmY4=; b=cOikIPDcirvjLvuLc7EXXIdct59fi5RZDnVKERqquJ9hXiaQ329CODYLcyZwQOVSgmdsvK RSD3nB2VT+frThbkl33sWjaUeZNtKoG0dpvQS7iicW7IIBlBKNjBLBP4EWPgn71Iyh4f09 hVAX2Lmlt6v17Mir7+v0+7MgutokGTo= Message-ID: <3ac34875-0e3d-076a-e5b1-7561a5e7a5fa@suse.com> Date: Thu, 5 May 2022 09:30:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org References: <20220505001656.395419-5-sstabellini@kernel.org> From: Juergen Gross In-Reply-To: <20220505001656.395419-5-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------SUfep81T9IQVwUKKhrl7tmsE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------SUfep81T9IQVwUKKhrl7tmsE Content-Type: multipart/mixed; boundary="------------pKXn5jatHkAgUxsB8retxnTu"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org Message-ID: <3ac34875-0e3d-076a-e5b1-7561a5e7a5fa@suse.com> Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain References: <20220505001656.395419-5-sstabellini@kernel.org> In-Reply-To: <20220505001656.395419-5-sstabellini@kernel.org> --------------pKXn5jatHkAgUxsB8retxnTu Content-Type: multipart/mixed; boundary="------------1rlfoowGkiJN1XT1U8g2KLfg" --------------1rlfoowGkiJN1XT1U8g2KLfg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDUuMjIgMDI6MTYsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBXaGVuIHhzX2ludHJv ZHVjZV9kb21haW4gaXMgY2FsbGVkLCBzZW5kIG91dCBhIG5vdGlmaWNhdGlvbiBvbiB0aGUN Cj4geGVuc3RvcmUgZXZlbnQgY2hhbm5lbCBzbyB0aGF0IGFueSAoZG9tMGxlc3MpIGRvbWFp biB3YWl0aW5nIGZvciB0aGUNCj4geGVuc3RvcmUgaW50ZXJmYWNlIHRvIGJlIHJlYWR5IGNh biBjb250aW51ZSB3aXRoIHRoZSBpbml0aWFsaXphdGlvbi4NCj4gQmVmb3JlIHNlbmRpbmcg dGhlIG5vdGlmaWNhdGlvbiwgY2xlYXIgWEVOU1RPUkVfUkVDT05ORUNUSU5HLg0KPiANCj4g VGhlIGV4dHJhIG5vdGlmaWNhdGlvbiBpcyBoYXJtbGVzcyBmb3IgZG9tYWlucyB0aGF0IGRv bid0IHJlcXVpcmUgaXQuDQo+IA0KPiBJbiB4c193aXJlLmggdXBkYXRlIHRoZSBjb21tbWVu dCBvbiB0b3Agb2YgWEVOU1RPUkVfUkVDT05ORUNUSU5HIHRvDQo+IGdlbmVyYWxpemUgaXRz IG1lYW5pbmcgdG8gc3VpdCB0aGUgZG9tMGxlc3MgdXNlLWNhc2UgYmV0dGVyLg0KPiANCj4g U2lnbmVkLW9mZi1ieTogTHVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IFNp Z25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhp bGlueC5jb20+DQo+IENDOiBqZ3Jvc3NAc3VzZS5jb20NCj4gQ0M6IGFudGhvbnkucGVyYXJk QGNpdHJpeC5jb20NCj4gQ0M6IHdsQHhlbi5vcmcNCj4gLS0tDQo+IElmIHlvdSBoYXZlIGJl dHRlciBzdWdnZXN0aW9ucyBmb3IgdGhlIHdvcmRpbmcgaW4geHNfd2lyZS5oIHBsZWFzZQ0K PiBzdWdnZXN0IQ0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPg0KDQoNCkp1ZXJnZW4NCg== --------------1rlfoowGkiJN1XT1U8g2KLfg Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1rlfoowGkiJN1XT1U8g2KLfg-- --------------pKXn5jatHkAgUxsB8retxnTu-- --------------SUfep81T9IQVwUKKhrl7tmsE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJzfScFAwAAAAAACgkQsN6d1ii/Ey/D GwgAgzGSePVAcOSdWAzfdEdr6BsuPI1/+v1h5xaRs/5hPXOBe8124DOcyOpqzHL6Km515qe2kVl4 tfJ4hH+94gZhbQxkIw5EYIup13Hup7fGXQgiHvhJxeKWXCfCSmo4dEX8kI4MzG1lmL8PlX23d2zi ez3crw8womVl9rBgLkq4KgdQHhJxnUtl7fW8ZcnrLn5FLYNEDBGtqsYn0NoKMg8CVpaxAsHHOV4Y 5u9Q2YwiTU129YygKuOo7r6gVZXwizKuZXeLyjw8b3yXLNb4Vc3SSBZTMvEfJqpRcrXPHoxO5WJu XZM3DIFp7k2M6A5TokHdh+XpwdQQ5rUCG4GbXgLA5g== =4jYQ -----END PGP SIGNATURE----- --------------SUfep81T9IQVwUKKhrl7tmsE-- From xen-devel-bounces@lists.xenproject.org Thu May 05 07:32:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321550.542560 (Exim 4.92) (envelope-from ) id 1nmVyF-0006aW-SJ; Thu, 05 May 2022 07:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321550.542560; Thu, 05 May 2022 07:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVyF-0006aP-Nk; Thu, 05 May 2022 07:32:19 +0000 Received: by outflank-mailman (input) for mailman id 321550; Thu, 05 May 2022 07:32:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVyF-0006aF-AM; Thu, 05 May 2022 07:32:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVyF-0007R8-7k; Thu, 05 May 2022 07:32:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVyE-0005Uf-Sc; Thu, 05 May 2022 07:32:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmVyE-00024c-S8; Thu, 05 May 2022 07:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ilEeHvTJx0TIeTKVegAZ80TkUN9aytDwNq+84IgvYLM=; b=Eo0iCwbJBZL5egGqnzOiV165UN KudoV3vmtppHmPIThQNzDnA77NkNpxjl6NefFR0uJPFANEI5054NyeXvazAQFIBtjQ+EJZQbeQuuR Md+T32MF7etstDMHJ7d3hdBen4+o2iLjheZC1cmOC6QcMPNxbnaSyGCgy5U2gR52iTzQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170140: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 07:32:18 +0000 flight 170140 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 813 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 07:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321559.542570 (Exim 4.92) (envelope-from ) id 1nmVzS-0007Dy-97; Thu, 05 May 2022 07:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321559.542570; Thu, 05 May 2022 07:33:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzS-0007Dr-6O; Thu, 05 May 2022 07:33:34 +0000 Received: by outflank-mailman (input) for mailman id 321559; Thu, 05 May 2022 07:33:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzR-0007CX-1v for xen-devel@lists.xen.org; Thu, 05 May 2022 07:33:33 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a93b71f4-cc45-11ec-a406-831a346695d4; Thu, 05 May 2022 09:33:32 +0200 (CEST) Received: by mail-pj1-x102d.google.com with SMTP id iq10so3456585pjb.0 for ; Thu, 05 May 2022 00:33:31 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id g5-20020a635205000000b003c14af5060esm666455pgb.38.2022.05.05.00.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:33:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a93b71f4-cc45-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ybq9PQWMvYB+rx172vn/HNQj4/TuzKkSJCqSdN1eHyM=; b=Jqj+Vz4GbZzonnAax6DnR8nTiHHAuhFnrMS/2aQzMzCpgC6IqAMnQH9zfG3tILHJvw 1CabTtSkZA67Y9YESGe2B6jwWYyqYml7G81YjSqc4944VutrbFSCfNXwSnFcVLLQtS2F N6O0wKO6mqKTRdcW4RAKWi1TlzVQpBbrWoscLUO1SiG4tORQJSoi0kbmHPf90q4W7+Dm 1320VHbqr3L60HBb3pFOE5kzHdzb+zxqsr+KKOjkpQhkZOfwgAk/Q6rrjlfTvQJU5JOa gCQU/Dx4qoUNqFBE9QFwIawQnCNJQ/PJeLA7zXf3cvWn5+WXznARJFQ8KXVZ3SFu/yXe V/Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ybq9PQWMvYB+rx172vn/HNQj4/TuzKkSJCqSdN1eHyM=; b=RG6/h8FTpj5GfHAAI0vnUROCDlAgwtt8ydQp1JvtgpccGQV80OQfmteHatF1m3qYuD sLkMHSjkEaOVVrMNXA/zSd1qAiRTDXKfFK/Gix4nGuiU4HKyFNcGP5eQSCM9yvkePq72 B2++D5s550RcgIjMCr0tUBpHbqx21yn7Jl9bPpR4G+4XaZNcdJEfzGQta2XKZOxV1IH9 y6TceeBaV+rC1gDYhFoekVpBCvNhxmkouqE6DreYD+p7lh8yGEPWClVYmxYmu38wCBVd ZCXJdh6c2QoSfEYFlvmM6cfNKo8NBYOFK0nnzkyfYz3D42txAlaqnx6VKAUW+I2yVOGi QeUQ== X-Gm-Message-State: AOAM530r0qWSwfPKurQX6NRVjQj8EVQko6QJhFyzBGdW7oMGn9wbRh1L 3KrefZph1Rq78zAoD+/53JV27fclxn1n6g== X-Google-Smtp-Source: ABdhPJwfAtBx+hfWoJ1pvr4S9UnGesILtdZj9jghAuXe9Y+0LwQa61b7dx5t4gLSaj+qmULhAk4PgQ== X-Received: by 2002:a17:90b:4c91:b0:1dc:57bc:4caa with SMTP id my17-20020a17090b4c9100b001dc57bc4caamr4474371pjb.10.1651736010030; Thu, 05 May 2022 00:33:30 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH 0/4] Virtio toolstack support for I2C and GPIO on Arm Date: Thu, 5 May 2022 13:03:19 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device [1]. The first two patches can be applied right away, but the last two need Oleksandr's series [1] to be applied first. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backend [2]. I must accept that I am a beginner to Xen and developed this patchset based on support for existing devices like Disk or Keyboard. There may be bits which I missed or the one I added which aren't really required. Thanks. -- Viresh Viresh Kumar (4): libxl: Add support for Virtio I2C device libxl: Add support for Virtio GPIO device libxl: Allocate MMIO params for I2c device and update DT libxl: Allocate MMIO params for GPIO device and update DT tools/golang/xenlight/helpers.gen.go | 220 ++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 54 +++++ tools/include/libxl.h | 64 ++++++ tools/include/libxl_utils.h | 6 + tools/libs/light/Makefile | 2 + tools/libs/light/libxl_arm.c | 117 ++++++++++- tools/libs/light/libxl_create.c | 26 +++ tools/libs/light/libxl_dm.c | 34 +++- tools/libs/light/libxl_gpio.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_i2c.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 52 +++++ tools/libs/light/libxl_types_internal.idl | 2 + tools/ocaml/libs/xl/genwrap.py | 2 + tools/ocaml/libs/xl/xenlight_stubs.c | 2 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 6 + tools/xl/xl_cmdtable.c | 30 +++ tools/xl/xl_gpio.c | 143 +++++++++++++ tools/xl/xl_i2c.c | 143 +++++++++++++ tools/xl/xl_parse.c | 160 +++++++++++++++ tools/xl/xl_parse.h | 2 + tools/xl/xl_sxp.c | 4 + 23 files changed, 1540 insertions(+), 5 deletions(-) create mode 100644 tools/libs/light/libxl_gpio.c create mode 100644 tools/libs/light/libxl_i2c.c create mode 100644 tools/xl/xl_gpio.c create mode 100644 tools/xl/xl_i2c.c -- 2.31.1.272.g89b43f80a514 [1] https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/ [2] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i7/ From xen-devel-bounces@lists.xenproject.org Thu May 05 07:33:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:33:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321560.542582 (Exim 4.92) (envelope-from ) id 1nmVzX-0007W8-GY; Thu, 05 May 2022 07:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321560.542582; Thu, 05 May 2022 07:33:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzX-0007W1-DU; Thu, 05 May 2022 07:33:39 +0000 Received: by outflank-mailman (input) for mailman id 321560; Thu, 05 May 2022 07:33:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzV-0007V6-Jt for xen-devel@lists.xen.org; Thu, 05 May 2022 07:33:37 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab534a2c-cc45-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:33:35 +0200 (CEST) Received: by mail-pg1-x529.google.com with SMTP id g184so527301pgc.1 for ; Thu, 05 May 2022 00:33:34 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id q13-20020a170902eb8d00b0015e8d4eb241sm758759plg.139.2022.05.05.00.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:33:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab534a2c-cc45-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BFckj9YfDJ61q1eBueMecImTvynCt5bpUOPgONXR2+I=; b=AYXGQKOSRrxPs7ysZjl+LyPQvTZ/s567X9PNMqdBWINvpPXWJeBUJHjd0X+fUf64G4 IHhuFlM+AEA6oN9u++Sk47bfhsQZF9U6XCPDWFHQRiwmho1afCQeiLbEmbkvjhetixmv /rcA6FtQI35HggiCwC2689To+3TaoDx/Yhtv7dYeJnhfYQ3huJvPBABxW93m9zIhiC0d huhrzuObECay/cbJH13nbdWqz/hdtRfBtC5bJNSANrUAC+fD+ssNpfWqniFy0vm373Xe T/GkgdlqcwSL4oYiSCMUe5MNf2tXRIj8owKolXljZYbqCYv4uzUydsdqySjeAtn/HJal DZEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BFckj9YfDJ61q1eBueMecImTvynCt5bpUOPgONXR2+I=; b=d8k4mz3jUOE2SSg/JLR5r35QVWsTAcQ1TOSsh+9m8xoEb8G9fUXXxlCzvqsHqAQqXC EFJg6zXemNi6Kh00v7hgClElidqhSClcGFUwdmmXtMESNi06ZUg7ilW6V+htfVA6JOra JhUTTro76/h77exGUfhBwlBduyWLBjNH8hiyN5nFoivUa21pXS8zkSeHdVP3/GEzV2tL TO3mNL5iOgz5GcViSHCtPFHTB+kiZVXKE89RnRsgryQ95lm9heh9PUgc4B6ntJOAe/+E OesjabCsOagoqTded5U9JIBMsQ8K1J7Z1lRGnS+smZILVMBrjwINSWr8UKVT3umdHnbp 3IlQ== X-Gm-Message-State: AOAM532evu4HLvuxEsWgKu1ms4Jl6oRp3aZy55nAUi8gH3qTq+4N0rJf pNGxWDM4JP3bHIxBDhAORKEzOcZikQvY7Q== X-Google-Smtp-Source: ABdhPJxyPD2d2FOr0mYehd/6b19nQmgZ7BArfA6CVuFoJCJz4nZn9sKERJO3/7IlC/J7WeZFlvWpog== X-Received: by 2002:a63:2a95:0:b0:3c1:d528:9992 with SMTP id q143-20020a632a95000000b003c1d5289992mr19903271pgq.128.1651736013264; Thu, 05 May 2022 00:33:33 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH 1/4] libxl: Add support for Virtio I2C device Date: Thu, 5 May 2022 13:03:20 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for configuring and assisting virtio-mmio based virtio-i2c backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio I2c: i2c = [ "" ] Please note, this patch is not enough for virtio-i2c to work on Xen (Arm), as for every Virtio device we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. A subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. Signed-off-by: Viresh Kumar --- tools/golang/xenlight/helpers.gen.go | 110 ++++++++++ tools/golang/xenlight/types.gen.go | 27 +++ tools/include/libxl.h | 32 +++ tools/include/libxl_utils.h | 3 + tools/libs/light/Makefile | 1 + tools/libs/light/libxl_create.c | 13 ++ tools/libs/light/libxl_dm.c | 19 +- tools/libs/light/libxl_i2c.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 26 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_i2c.c | 143 +++++++++++++ tools/xl/xl_parse.c | 80 ++++++++ tools/xl/xl_parse.h | 1 + tools/xl/xl_sxp.c | 2 + 20 files changed, 714 insertions(+), 3 deletions(-) create mode 100644 tools/libs/light/libxl_i2c.c create mode 100644 tools/xl/xl_i2c.c diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff108131..ad23b0969abd 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1215,6 +1215,9 @@ x.Usbdevice = C.GoString(tmp.usbdevice) if err := x.VkbDevice.fromC(&tmp.vkb_device);err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := x.I2cDevice.fromC(&tmp.i2c_device);err != nil { +return fmt.Errorf("converting field I2cDevice: %v", err) +} x.Soundhw = C.GoString(tmp.soundhw) if err := x.XenPlatformPci.fromC(&tmp.xen_platform_pci);err != nil { return fmt.Errorf("converting field XenPlatformPci: %v", err) @@ -1532,6 +1535,9 @@ hvm.usbdevice = C.CString(tmp.Usbdevice)} if err := tmp.VkbDevice.toC(&hvm.vkb_device); err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := tmp.I2cDevice.toC(&hvm.i2c_device); err != nil { +return fmt.Errorf("converting field I2cDevice: %v", err) +} if tmp.Soundhw != "" { hvm.soundhw = C.CString(tmp.Soundhw)} if err := tmp.XenPlatformPci.toC(&hvm.xen_platform_pci); err != nil { @@ -1722,6 +1728,46 @@ xc.multi_touch_num_contacts = C.uint32_t(x.MultiTouchNumContacts) return nil } +// NewDeviceI2c returns an instance of DeviceI2c initialized with defaults. +func NewDeviceI2c() (*DeviceI2c, error) { +var ( +x DeviceI2c +xc C.libxl_device_i2c) + +C.libxl_device_i2c_init(&xc) +defer C.libxl_device_i2c_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *DeviceI2c) fromC(xc *C.libxl_device_i2c) error { + x.BackendDomid = Domid(xc.backend_domid) +x.BackendDomname = C.GoString(xc.backend_domname) +x.Devid = Devid(xc.devid) +x.BackendType = I2cBackend(xc.backend_type) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) + + return nil} + +func (x *DeviceI2c) toC(xc *C.libxl_device_i2c) (err error){defer func(){ +if err != nil{ +C.libxl_device_i2c_dispose(xc)} +}() + +xc.backend_domid = C.libxl_domid(x.BackendDomid) +if x.BackendDomname != "" { +xc.backend_domname = C.CString(x.BackendDomname)} +xc.devid = C.libxl_devid(x.Devid) +xc.backend_type = C.libxl_i2c_backend(x.BackendType) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) + + return nil + } + // NewDeviceDisk returns an instance of DeviceDisk initialized with defaults. func NewDeviceDisk() (*DeviceDisk, error) { var ( @@ -2835,6 +2881,15 @@ if err := x.Vkbs[i].fromC(&v); err != nil { return fmt.Errorf("converting field Vkbs: %v", err) } } } +x.I2cs = nil +if n := int(xc.num_i2cs); n > 0 { +cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:n:n] +x.I2cs = make([]DeviceI2c, n) +for i, v := range cI2cs { +if err := x.I2cs[i].fromC(&v); err != nil { +return fmt.Errorf("converting field I2cs: %v", err) } +} +} x.Vtpms = nil if n := int(xc.num_vtpms); n > 0 { cVtpms := (*[1<<28]C.libxl_device_vtpm)(unsafe.Pointer(xc.vtpms))[:n:n] @@ -2996,6 +3051,16 @@ return fmt.Errorf("converting field Vkbs: %v", err) } } } +if numI2cs := len(x.I2cs); numI2cs > 0 { +xc.i2cs = (*C.libxl_device_i2c)(C.malloc(C.ulong(numI2cs)*C.sizeof_libxl_device_i2c)) +xc.num_i2cs = C.int(numI2cs) +cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:numI2cs:numI2cs] +for i,v := range x.I2cs { +if err := v.toC(&cI2cs[i]); err != nil { +return fmt.Errorf("converting field I2cs: %v", err) +} +} +} if numVtpms := len(x.Vtpms); numVtpms > 0 { xc.vtpms = (*C.libxl_device_vtpm)(C.malloc(C.ulong(numVtpms)*C.sizeof_libxl_device_vtpm)) xc.num_vtpms = C.int(numVtpms) @@ -3683,6 +3748,51 @@ if err != nil{ C.libxl_vkbinfo_dispose(xc)} }() +if x.Backend != "" { +xc.backend = C.CString(x.Backend)} +xc.backend_id = C.uint32_t(x.BackendId) +if x.Frontend != "" { +xc.frontend = C.CString(x.Frontend)} +xc.frontend_id = C.uint32_t(x.FrontendId) +xc.devid = C.libxl_devid(x.Devid) +xc.state = C.int(x.State) +xc.evtch = C.int(x.Evtch) +xc.rref = C.int(x.Rref) + + return nil + } + +// NewI2cinfo returns an instance of I2cinfo initialized with defaults. +func NewI2cinfo() (*I2cinfo, error) { +var ( +x I2cinfo +xc C.libxl_i2cinfo) + +C.libxl_i2cinfo_init(&xc) +defer C.libxl_i2cinfo_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *I2cinfo) fromC(xc *C.libxl_i2cinfo) error { + x.Backend = C.GoString(xc.backend) +x.BackendId = uint32(xc.backend_id) +x.Frontend = C.GoString(xc.frontend) +x.FrontendId = uint32(xc.frontend_id) +x.Devid = Devid(xc.devid) +x.State = int(xc.state) +x.Evtch = int(xc.evtch) +x.Rref = int(xc.rref) + + return nil} + +func (x *I2cinfo) toC(xc *C.libxl_i2cinfo) (err error){defer func(){ +if err != nil{ +C.libxl_i2cinfo_dispose(xc)} +}() + if x.Backend != "" { xc.backend = C.CString(x.Backend)} xc.backend_id = C.uint32_t(x.BackendId) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d525843..c232e4811ac3 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -241,6 +241,11 @@ VkbBackendQemu VkbBackend = 1 VkbBackendLinux VkbBackend = 2 ) +type I2cBackend int +const( +I2cBackendVirtio I2cBackend = 0 +) + type Passthrough int const( PassthroughDefault Passthrough = 0 @@ -568,6 +573,7 @@ Usb Defbool Usbversion int Usbdevice string VkbDevice Defbool +I2cDevice Defbool Soundhw string XenPlatformPci Defbool UsbdeviceList StringList @@ -630,6 +636,15 @@ MultiTouchHeight uint32 MultiTouchNumContacts uint32 } +type DeviceI2c struct { +BackendDomid Domid +BackendDomname string +Devid Devid +BackendType I2cBackend +Irq uint32 +Base uint64 +} + type DeviceDisk struct { BackendDomid Domid BackendDomname string @@ -913,6 +928,7 @@ Rdms []DeviceRdm Dtdevs []DeviceDtdev Vfbs []DeviceVfb Vkbs []DeviceVkb +I2cs []DeviceI2c Vtpms []DeviceVtpm P9S []DeviceP9 Pvcallsifs []DevicePvcallsif @@ -1067,6 +1083,17 @@ Evtch int Rref int } +type I2cinfo struct { +Backend string +BackendId uint32 +Frontend string +FrontendId uint32 +Devid Devid +State int +Evtch int +Rref int +} + type Numainfo struct { Size uint64 Free uint64 diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 51a9b6cfaceb..4d19194c3dc2 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -800,6 +800,15 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 +/* + * LIBXL_HAVE_BUILDINFO_I2C_DEVICE + * + * If this is defined, then the libxl_domain_build_info structure will + * contain a boolean hvm.i2c_device which instructs libxl whether to include + * a i2c at build time or not. + */ +#define LIBXL_HAVE_BUILDINFO_I2C_DEVICE 1 + /* * LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST * @@ -2368,6 +2377,29 @@ int libxl_device_vkb_getinfo(libxl_ctx *ctx, uint32_t domid, libxl_vkbinfo *vkbinfo) LIBXL_EXTERNAL_CALLERS_ONLY; +/* I2C */ +int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_remove(libxl_ctx *ctx, uint32_t domid, + libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_destroy(libxl_ctx *ctx, uint32_t domid, + libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; + +libxl_device_i2c *libxl_device_i2c_list(libxl_ctx *ctx, + uint32_t domid, int *num) + LIBXL_EXTERNAL_CALLERS_ONLY; +void libxl_device_i2c_list_free(libxl_device_i2c* list, int num) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_i2c *i2c, + libxl_i2cinfo *i2cinfo) + LIBXL_EXTERNAL_CALLERS_ONLY; + /* Framebuffer */ int libxl_device_vfb_add(libxl_ctx *ctx, uint32_t domid, libxl_device_vfb *vfb, const libxl_asyncop_how *ao_how) diff --git a/tools/include/libxl_utils.h b/tools/include/libxl_utils.h index 46918aea847f..72b7796b7e4b 100644 --- a/tools/include/libxl_utils.h +++ b/tools/include/libxl_utils.h @@ -83,6 +83,9 @@ int libxl_devid_to_device_usbctrl(libxl_ctx *ctx, uint32_t domid, int libxl_devid_to_device_vkb(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vkb *vkb); +int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_i2c *i2c); + int libxl_devid_to_device_vdispl(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vdispl *vdispl); diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 453bea006723..dca46846e586 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,7 @@ SRCS-y += libxl_vdispl.c SRCS-y += libxl_pvcalls.c SRCS-y += libxl_vsnd.c SRCS-y += libxl_vkb.c +SRCS-y += libxl_i2c.c SRCS-y += libxl_genid.c SRCS-y += _libxl_types.c SRCS-y += libxl_flask.c diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 69ec405858a8..d604171e504c 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -363,6 +363,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); libxl_defbool_setdefault(&b_info->u.hvm.usb, false); libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); + libxl_defbool_setdefault(&b_info->u.hvm.i2c_device, true); libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); libxl_defbool_setdefault(&b_info->u.hvm.spice.enable, false); @@ -1755,6 +1756,7 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl__device_console console; libxl__device device; libxl_device_vkb vkb; + libxl_device_i2c i2c; init_console_info(gc, &console, 0); console.backend_domid = state->console_domid; @@ -1767,6 +1769,12 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl_device_vkb_dispose(&vkb); } + if (libxl_defbool_val(d_config->b_info.u.hvm.i2c_device)) { + libxl_device_i2c_init(&i2c); + libxl__device_add(gc, domid, &libxl__i2c_devtype, &i2c); + libxl_device_i2c_dispose(&i2c); + } + dcs->sdss.dm.guest_domid = domid; if (libxl_defbool_val(d_config->b_info.device_model_stubdomain)) libxl__spawn_stub_dm(egc, &dcs->sdss); @@ -1799,6 +1807,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl__device_add(gc, domid, &libxl__i2c_devtype, + &d_config->i2cs[i]); + } + if (d_config->b_info.arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) { init_console_info(gc, &vuart, 0); vuart.backend_domid = state->console_domid; diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 1864ee30f0a2..9340ae4628a2 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -2095,7 +2095,8 @@ static void libxl__dm_vifs_from_hvm_guest_config(libxl__gc *gc, static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, const libxl_domain_config *guest_config, libxl_device_vfb *vfb, - libxl_device_vkb *vkb) + libxl_device_vkb *vkb, + libxl_device_i2c *i2c) { const libxl_domain_build_info *b_info = &guest_config->b_info; @@ -2104,6 +2105,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, libxl_device_vfb_init(vfb); libxl_device_vkb_init(vkb); + libxl_device_i2c_init(i2c); vfb->backend_domid = 0; vfb->devid = 0; @@ -2114,6 +2116,9 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, vkb->backend_domid = 0; vkb->devid = 0; + i2c->backend_domid = 0; + i2c->devid = 0; + return 0; } @@ -2276,6 +2281,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) int ret; libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; char **args; struct xs_permissions perm[2]; xs_transaction_t t; @@ -2348,11 +2354,14 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) || libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { GCNEW(vfb); GCNEW(vkb); - libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb); + GCNEW(i2c); + libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, i2c); dm_config->vfbs = vfb; dm_config->num_vfbs = 1; dm_config->vkbs = vkb; dm_config->num_vkbs = 1; + dm_config->i2cs = i2c; + dm_config->num_i2cs = 1; } if (guest_config->b_info.stubdomain_kernel && @@ -2494,6 +2503,12 @@ static void spawn_stub_launch_dm(libxl__egc *egc, if (ret) goto out; } + if (dm_config->num_i2cs) { + ret = libxl__device_add(gc, dm_domid, &libxl__i2c_devtype, + &dm_config->i2cs[0]); + if (ret) goto out; + } + if (guest_config->b_info.u.hvm.serial) { num_console++; } else if (guest_config->b_info.u.hvm.serial_list) { diff --git a/tools/libs/light/libxl_i2c.c b/tools/libs/light/libxl_i2c.c new file mode 100644 index 000000000000..fd13c07826ff --- /dev/null +++ b/tools/libs/light/libxl_i2c.c @@ -0,0 +1,236 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +#include + +static int libxl__device_i2c_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, bool hotplug) +{ + if (i2c->backend_type != LIBXL_I2C_BACKEND_VIRTIO) { + i2c->backend_type = LIBXL_I2C_BACKEND_VIRTIO; + } + + return libxl__resolve_domid(gc, i2c->backend_domname, &i2c->backend_domid); +} + +static int libxl__device_i2c_dm_needed(void *e, uint32_t domid) +{ + libxl_device_i2c *elem = e; + + return elem->backend_type == LIBXL_I2C_BACKEND_VIRTIO; +} + +static int libxl__set_xenstore_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + flexarray_append_pair(back, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", i2c->base)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", i2c->base)); + + return 0; +} + +static int libxl__i2c_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_i2c *i2c) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + i2c->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &i2c->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + i2c->backend_type = LIBXL_I2C_BACKEND_VIRTIO; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static int libxl__device_from_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *type, libxl__device *device) +{ + device->backend_devid = type->devid; + device->backend_domid = type->backend_domid; + device->backend_kind = LIBXL__DEVICE_KIND_I2C; + device->devid = type->devid; + device->domid = domid; + device->kind = LIBXL__DEVICE_KIND_I2C; + + return 0; +} + +int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) +{ + AO_CREATE(ctx, domid, ao_how); + int rc; + + rc = libxl__device_add(gc, domid, &libxl__i2c_devtype, i2c); + if (rc) { + LOGD(ERROR, domid, "Unable to add i2c device"); + goto out; + } + +out: + libxl__ao_complete(egc, ao, rc); + return AO_INPROGRESS; +} + +int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_i2c *i2c) +{ + GC_INIT(ctx); + + libxl_device_i2c *i2cs = NULL; + int n, i; + int rc; + + libxl_device_i2c_init(i2c); + + i2cs = libxl__device_list(gc, &libxl__i2c_devtype, domid, &n); + + if (!i2cs) { rc = ERROR_NOTFOUND; goto out; } + + for (i = 0; i < n; ++i) { + if (devid == i2cs[i].devid) { + libxl_device_i2c_copy(ctx, i2c, &i2cs[i]); + rc = 0; + goto out; + } + } + + rc = ERROR_NOTFOUND; + +out: + + if (i2cs) + libxl__device_list_free(&libxl__i2c_devtype, i2cs, n); + + GC_FREE; + return rc; +} + +int libxl_device_i2c_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_i2c *i2c, + libxl_i2cinfo *info) +{ + GC_INIT(ctx); + char *libxl_path, *dompath, *devpath; + char *val; + int rc; + + libxl_i2cinfo_init(info); + dompath = libxl__xs_get_dompath(gc, domid); + info->devid = i2c->devid; + + devpath = libxl__domain_device_frontend_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_I2C); + libxl_path = libxl__domain_device_libxl_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_I2C); + + info->backend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + NULL); + if (!info->backend) { rc = ERROR_FAIL; goto out; } + + rc = libxl__backendpath_parse_domid(gc, info->backend, &info->backend_id); + if (rc) goto out; + + val = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/state", devpath)); + info->state = val ? strtoul(val, NULL, 10) : -1; + + info->frontend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + NULL); + info->frontend_id = domid; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_EVT_CHANNEL, devpath)); + info->evtch = val ? strtoul(val, NULL, 10) : -1; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_RING_GREF, devpath)); + info->rref = val ? strtoul(val, NULL, 10) : -1; + + rc = 0; + +out: + GC_FREE; + return rc; +} + +static LIBXL_DEFINE_UPDATE_DEVID(i2c) + +#define libxl__add_i2cs NULL +#define libxl_device_i2c_compare NULL + +LIBXL_DEFINE_DEVICE_LIST(i2c) +LIBXL_DEFINE_DEVICE_REMOVE(i2c) + +DEFINE_DEVICE_TYPE_STRUCT(i2c, I2C, i2cs, + .skip_attach = 1, + .dm_needed = libxl__device_i2c_dm_needed, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_i2c, + .from_xenstore = (device_from_xenstore_fn_t)libxl__i2c_from_xenstore +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index bdef5a605ea9..b4dfbe7e5db1 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4001,6 +4001,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__i2c_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; extern const libxl__device_type libxl__vtpm_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 2a42da2f7d78..e9454e669224 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -266,6 +266,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_i2c_backend = Enumeration("i2c_backend", [ + (0, "VIRTIO") + ]) + libxl_passthrough = Enumeration("passthrough", [ (0, "default"), (1, "disabled"), @@ -614,6 +618,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ # - "mouse" for PS/2 protocol relative mouse ("usbdevice", string), ("vkb_device", libxl_defbool), + ("i2c_device", libxl_defbool), ("soundhw", string), ("xen_platform_pci", libxl_defbool), ("usbdevice_list", libxl_string_list), @@ -691,6 +696,15 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_i2c = Struct("device_i2c", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("backend_type", libxl_i2c_backend), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_disk = Struct("device_disk", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -960,6 +974,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("i2cs", Array(libxl_device_i2c, "num_i2cs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), ("pvcallsifs", Array(libxl_device_pvcallsif, "num_pvcallsifs")), @@ -1121,6 +1136,17 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_i2cinfo = Struct("i2cinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ("evtch", integer), + ("rref", integer) + ], dir=DIR_OUT) + # NUMA node characteristics: size and free are how much memory it has, and how # much of it is free, respectively. dists is an array of distances from this # node to each other node. diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 3593e21dbb64..1b87d1480bf9 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "I2C"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index 7bf26bdcd831..a9db0b97d80f 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_i2c": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), ("of_vdev", ["ctx", "domid", "string", "t"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74a..cdf473f4ed57 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(i2c) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/Makefile b/tools/xl/Makefile index b7f439121a3a..06801962f11e 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -23,7 +23,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o XL_OBJS += xl_info.o xl_console.o xl_misc.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_i2c.o $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XL_OBJS): CFLAGS += $(CFLAGS_XL) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd5d..210bc1b6d47a 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -177,6 +177,9 @@ int main_vsnddetach(int argc, char **argv); int main_vkbattach(int argc, char **argv); int main_vkblist(int argc, char **argv); int main_vkbdetach(int argc, char **argv); +int main_i2cattach(int argc, char **argv); +int main_i2clist(int argc, char **argv); +int main_i2cdetach(int argc, char **argv); int main_usbctrl_attach(int argc, char **argv); int main_usbctrl_detach(int argc, char **argv); int main_usbdev_attach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d4884e..30bd614fc275 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -406,6 +406,21 @@ const struct cmd_spec cmd_table[] = { "Destroy a domain's virtual keyboard device", " ", }, + { "i2c-attach", + &main_i2cattach, 1, 1, + "Create a new virtual i2c device", + " ...", + }, + { "i2c-list", + &main_i2clist, 0, 0, + "List virtual i2c devices for a domain", + "", + }, + { "i2c-detach", + &main_i2cdetach, 0, 1, + "Destroy a domain's virtual i2c device", + " ", + }, { "vdispl-attach", &main_vdisplattach, 1, 1, "Create a new virtual display device", diff --git a/tools/xl/xl_i2c.c b/tools/xl/xl_i2c.c new file mode 100644 index 000000000000..a916d05604f2 --- /dev/null +++ b/tools/xl/xl_i2c.c @@ -0,0 +1,143 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include + +#include +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +int main_i2cattach(int argc, char **argv) +{ + int opt; + int rc; + uint32_t domid; + libxl_device_i2c i2c; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-attach", 2) { + /* No options */ + } + + libxl_device_i2c_init(&i2c); + domid = find_domain(argv[optind++]); + + for (argv += optind, argc -= optind; argc > 0; ++argv, --argc) { + rc = parse_i2c_config(&i2c, *argv); + if (rc) goto out; + } + + if (dryrun_only) { + char *json = libxl_device_i2c_to_json(ctx, &i2c); + printf("i2c: %s\n", json); + free(json); + goto done; + } + + if (libxl_device_i2c_add(ctx, domid, &i2c, 0)) { + fprintf(stderr, "libxl_device_i2c_add failed.\n"); + rc = ERROR_FAIL; goto out; + } + +done: + rc = 0; + +out: + libxl_device_i2c_dispose(&i2c); + return rc; +} + +int main_i2clist(int argc, char **argv) +{ + int opt; + libxl_device_i2c *i2cs; + libxl_i2cinfo i2cinfo; + int nb, i; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-list", 1) { + /* No options */ + } + + /* Idx BE Hdl Sta evch ref ID BE-type BE-path */ + printf("%-3s %-2s %-6s %-5s %-6s %6s %-10s %-10s %-30s\n", + "Idx", "BE", "handle", "state", "evt-ch", "ref", + "ID", "BE-type", "BE-path"); + for (argv += optind, argc -= optind; argc > 0; --argc, ++argv) { + uint32_t domid = find_domain(*argv); + i2cs = libxl_device_i2c_list(ctx, domid, &nb); + if (!i2cs) { + continue; + } + for (i = 0; i < nb; ++i) { + if (libxl_device_i2c_getinfo(ctx, domid, &i2cs[i], &i2cinfo) == 0) { + printf("%-3d %-2d %6d %5d %6d %6d %-10s %-30s\n", + i2cinfo.devid, i2cinfo.backend_id, + i2cinfo.devid, i2cinfo.state, i2cinfo.evtch, + i2cinfo.rref, + libxl_i2c_backend_to_string(i2cs[i].backend_type), + i2cinfo.backend); + libxl_i2cinfo_dispose(&i2cinfo); + } + } + libxl_device_i2c_list_free(i2cs, nb); + } + return 0; +} + +int main_i2cdetach(int argc, char **argv) +{ + uint32_t domid, devid; + int opt, rc; + libxl_device_i2c i2c; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-detach", 2) { + /* No options */ + } + + domid = find_domain(argv[optind++]); + devid = atoi(argv[optind++]); + + libxl_device_i2c_init(&i2c); + + if (libxl_devid_to_device_i2c(ctx, domid, devid, &i2c)) { + fprintf(stderr, "Error: Device %d not connected.\n", devid); + rc = ERROR_FAIL; + goto out; + } + + rc = libxl_device_i2c_remove(ctx, domid, &i2c, 0); + if (rc) { + fprintf(stderr, "libxl_device_i2c_remove failed.\n"); + rc = ERROR_FAIL; + goto out; + } + + rc = 0; + +out: + libxl_device_i2c_dispose(&i2c); + return rc; +} + + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index b98c0de378b6..95483e551c38 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1204,6 +1204,74 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +int parse_i2c_config(libxl_device_i2c *i2c, char *token) +{ + char *oparg; + + if (MATCH_OPTION("backend", token, oparg)) { + i2c->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("backend-type", token, oparg)) { + libxl_i2c_backend backend_type; + if (libxl_i2c_backend_from_string(oparg, &backend_type)) { + fprintf(stderr, "Unknown backend_type \"%s\" in i2c spec\n", + oparg); + return -1; + } + i2c->backend_type = backend_type; + } else if (MATCH_OPTION("irq", token, oparg)) { + i2c->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + i2c->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in i2c spec\n", token); + return -1; + } + + return 0; +} + +static void parse_i2c_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *i2cs; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "i2c", &i2cs, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(i2cs, entry)) != NULL) { + libxl_device_i2c *i2c; + char *p; + + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, + d_config->num_i2cs, + libxl_device_i2c_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_i2c_config(i2c, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + void parse_config_data(const char *config_source, const char *config_data, int config_len, @@ -2305,13 +2373,16 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_i2cs = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->i2cs = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; char *buf2 = strdup(buf); char *p, *p2; @@ -2322,6 +2393,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, + libxl_device_i2c_init); + p = strtok(buf2, ","); if (!p) goto skip_vfb; @@ -2579,6 +2653,7 @@ void parse_config_data(const char *config_source, if (vnc_enabled) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; vfb = ARRAY_EXTEND_INIT(d_config->vfbs, d_config->num_vfbs, libxl_device_vfb_init); @@ -2586,6 +2661,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, + libxl_device_i2c_init); + parse_top_level_vnc_options(config, &vfb->vnc); parse_top_level_sdl_options(config, &vfb->sdl); xlu_cfg_replace_string (config, "keymap", &vfb->keymap, 0); @@ -2700,6 +2778,7 @@ void parse_config_data(const char *config_source, exit(-ERROR_FAIL); } xlu_cfg_get_defbool(config, "vkb_device", &b_info->u.hvm.vkb_device, 0); + xlu_cfg_get_defbool(config, "i2c_device", &b_info->u.hvm.i2c_device, 0); xlu_cfg_replace_string (config, "soundhw", &b_info->u.hvm.soundhw, 0); xlu_cfg_get_defbool(config, "xen_platform_pci", &b_info->u.hvm.xen_platform_pci, 0); @@ -2748,6 +2827,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_i2c_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); diff --git a/tools/xl/xl_parse.h b/tools/xl/xl_parse.h index bab2861f8c3e..4b972d525199 100644 --- a/tools/xl/xl_parse.h +++ b/tools/xl/xl_parse.h @@ -36,6 +36,7 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config **config, char *token); int parse_vdispl_config(libxl_device_vdispl *vdispl, char *token); int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec); int parse_vkb_config(libxl_device_vkb *vkb, char *token); +int parse_i2c_config(libxl_device_i2c *i2c, char *token); int match_option_size(const char *prefix, size_t len, char *arg, char **argopt); diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c index 359a0015709e..a44c765aa515 100644 --- a/tools/xl/xl_sxp.c +++ b/tools/xl/xl_sxp.c @@ -140,6 +140,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) fprintf(fh, "\t\t\t(usbdevice %s)\n", b_info->u.hvm.usbdevice); fprintf(fh, "\t\t\t(vkb_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.vkb_device)); + fprintf(fh, "\t\t\t(i2c_device %s)\n", + libxl_defbool_to_string(b_info->u.hvm.i2c_device)); fprintf(fh, "\t\t)\n"); break; case LIBXL_DOMAIN_TYPE_PV: -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu May 05 07:33:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321561.542593 (Exim 4.92) (envelope-from ) id 1nmVza-0007oh-2m; Thu, 05 May 2022 07:33:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321561.542593; Thu, 05 May 2022 07:33:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzZ-0007oW-Tn; Thu, 05 May 2022 07:33:41 +0000 Received: by outflank-mailman (input) for mailman id 321561; Thu, 05 May 2022 07:33:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzY-0007CX-3i for xen-devel@lists.xen.org; Thu, 05 May 2022 07:33:40 +0000 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [2607:f8b0:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id acf234c8-cc45-11ec-a406-831a346695d4; Thu, 05 May 2022 09:33:37 +0200 (CEST) Received: by mail-pg1-x535.google.com with SMTP id x12so3023843pgj.7 for ; Thu, 05 May 2022 00:33:37 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id x24-20020a170902b41800b0015e8d4eb1e4sm779323plr.46.2022.05.05.00.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:33:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acf234c8-cc45-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HyzuOp/tvITGfFX9GJge8V/26LSsI0eF8GbficmNu7U=; b=pyGfDoyLFuWl7Uj8utxqcCHZVXxkdcVJBD4N8YyjBhRZD/9RiFZsjcRaDN6M1nPy+g Ftpz5n12CQZe/4QBDji+hcO3FxoH90fYRVZIjphl1WdjQDWKEVTRugn+oIi6vv1go0x2 ygPM0lqcuLjOYIGBqEd5dBmwoGhIrwb01WIUkvCDnYzdLSV3vqOz3SsBqfGvDNjM2h8P BQwyVIySeue2vG2UkJr5vC9aKEfirHWcDcHrq8NGSOZryfZt9jwE1l9iymwTfS56oUR4 YFMgWoOOwXp5ZMF2KlsSvLgRg3zh10RWaL9j1JnmCxHcGmCn/uMvYLFu1+C+wjNFWrB7 Mfdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HyzuOp/tvITGfFX9GJge8V/26LSsI0eF8GbficmNu7U=; b=OlSpsQHvmAZOFjy0kRFZiqduWyD1AuTw2+HsEJeW5whjMnoefbBuGzymBXkxXQXKfO sYBrXaX5K6q4LIENbTUy4rsFQS+TSPFv9y48mx5uaDLsO7CXbF+2+nhlHhRy28gvDbJo O283rwhkz3X6al1LBWUUKBRa1f2XDACXuf+evVAUpJUzIuCXy5BtAEXGY2Shia0lDVkB O3gPWysEuI3pTJRgQHGCc0kHp7+wMt3AU9FIoNuLuyXrE1wwjeoDN2XR41zWFpkSaux2 0LdG6ODl8k5CNL9OaiBdQJR/FA7yrgRY7gpUfrrebxD5LkeZzpUrNWKdrzbyFR70iz3X gXyA== X-Gm-Message-State: AOAM5309zCGEz3m1VpwigD2/dHC2jRSjkrEsodM0myIKpS+fFsOFZhLT Nmi/YH2DHXw7BEJmBcWQyTWanj8fUZkSrQ== X-Google-Smtp-Source: ABdhPJy24n+voUOot2k8vkUuG3nP609OSqbhbHtF4yaWeeHu10U3e83/J+rrHenK+BqGmK52eVHafw== X-Received: by 2002:a05:6a00:c8f:b0:510:60cf:55fa with SMTP id a15-20020a056a000c8f00b0051060cf55famr1662695pfv.37.1651736016099; Thu, 05 May 2022 00:33:36 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH 2/4] libxl: Add support for Virtio GPIO device Date: Thu, 5 May 2022 13:03:21 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for configuring and assisting virtio-mmio based virtio-gpio backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio Gpio: gpio = [ "" ] Please note, this patch is not enough for virtio-gpio to work on Xen (Arm), as for every Virtio device we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. A subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. Signed-off-by: Viresh Kumar --- tools/golang/xenlight/helpers.gen.go | 110 ++++++++++ tools/golang/xenlight/types.gen.go | 27 +++ tools/include/libxl.h | 32 +++ tools/include/libxl_utils.h | 3 + tools/libs/light/Makefile | 1 + tools/libs/light/libxl_create.c | 13 ++ tools/libs/light/libxl_dm.c | 17 +- tools/libs/light/libxl_gpio.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 26 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_gpio.c | 143 +++++++++++++ tools/xl/xl_parse.c | 80 ++++++++ tools/xl/xl_parse.h | 1 + tools/xl/xl_sxp.c | 2 + 20 files changed, 713 insertions(+), 2 deletions(-) create mode 100644 tools/libs/light/libxl_gpio.c create mode 100644 tools/xl/xl_gpio.c diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index ad23b0969abd..ed880cad3fa7 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1215,6 +1215,9 @@ x.Usbdevice = C.GoString(tmp.usbdevice) if err := x.VkbDevice.fromC(&tmp.vkb_device);err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := x.GpioDevice.fromC(&tmp.gpio_device);err != nil { +return fmt.Errorf("converting field GpioDevice: %v", err) +} if err := x.I2cDevice.fromC(&tmp.i2c_device);err != nil { return fmt.Errorf("converting field I2cDevice: %v", err) } @@ -1535,6 +1538,9 @@ hvm.usbdevice = C.CString(tmp.Usbdevice)} if err := tmp.VkbDevice.toC(&hvm.vkb_device); err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := tmp.GpioDevice.toC(&hvm.gpio_device); err != nil { +return fmt.Errorf("converting field GpioDevice: %v", err) +} if err := tmp.I2cDevice.toC(&hvm.i2c_device); err != nil { return fmt.Errorf("converting field I2cDevice: %v", err) } @@ -1728,6 +1734,46 @@ xc.multi_touch_num_contacts = C.uint32_t(x.MultiTouchNumContacts) return nil } +// NewDeviceGpio returns an instance of DeviceGpio initialized with defaults. +func NewDeviceGpio() (*DeviceGpio, error) { +var ( +x DeviceGpio +xc C.libxl_device_gpio) + +C.libxl_device_gpio_init(&xc) +defer C.libxl_device_gpio_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *DeviceGpio) fromC(xc *C.libxl_device_gpio) error { + x.BackendDomid = Domid(xc.backend_domid) +x.BackendDomname = C.GoString(xc.backend_domname) +x.Devid = Devid(xc.devid) +x.BackendType = GpioBackend(xc.backend_type) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) + + return nil} + +func (x *DeviceGpio) toC(xc *C.libxl_device_gpio) (err error){defer func(){ +if err != nil{ +C.libxl_device_gpio_dispose(xc)} +}() + +xc.backend_domid = C.libxl_domid(x.BackendDomid) +if x.BackendDomname != "" { +xc.backend_domname = C.CString(x.BackendDomname)} +xc.devid = C.libxl_devid(x.Devid) +xc.backend_type = C.libxl_gpio_backend(x.BackendType) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) + + return nil + } + // NewDeviceI2c returns an instance of DeviceI2c initialized with defaults. func NewDeviceI2c() (*DeviceI2c, error) { var ( @@ -2881,6 +2927,15 @@ if err := x.Vkbs[i].fromC(&v); err != nil { return fmt.Errorf("converting field Vkbs: %v", err) } } } +x.Gpios = nil +if n := int(xc.num_gpios); n > 0 { +cGpios := (*[1<<28]C.libxl_device_gpio)(unsafe.Pointer(xc.gpios))[:n:n] +x.Gpios = make([]DeviceGpio, n) +for i, v := range cGpios { +if err := x.Gpios[i].fromC(&v); err != nil { +return fmt.Errorf("converting field Gpios: %v", err) } +} +} x.I2cs = nil if n := int(xc.num_i2cs); n > 0 { cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:n:n] @@ -3051,6 +3106,16 @@ return fmt.Errorf("converting field Vkbs: %v", err) } } } +if numGpios := len(x.Gpios); numGpios > 0 { +xc.gpios = (*C.libxl_device_gpio)(C.malloc(C.ulong(numGpios)*C.sizeof_libxl_device_gpio)) +xc.num_gpios = C.int(numGpios) +cGpios := (*[1<<28]C.libxl_device_gpio)(unsafe.Pointer(xc.gpios))[:numGpios:numGpios] +for i,v := range x.Gpios { +if err := v.toC(&cGpios[i]); err != nil { +return fmt.Errorf("converting field Gpios: %v", err) +} +} +} if numI2cs := len(x.I2cs); numI2cs > 0 { xc.i2cs = (*C.libxl_device_i2c)(C.malloc(C.ulong(numI2cs)*C.sizeof_libxl_device_i2c)) xc.num_i2cs = C.int(numI2cs) @@ -3748,6 +3813,51 @@ if err != nil{ C.libxl_vkbinfo_dispose(xc)} }() +if x.Backend != "" { +xc.backend = C.CString(x.Backend)} +xc.backend_id = C.uint32_t(x.BackendId) +if x.Frontend != "" { +xc.frontend = C.CString(x.Frontend)} +xc.frontend_id = C.uint32_t(x.FrontendId) +xc.devid = C.libxl_devid(x.Devid) +xc.state = C.int(x.State) +xc.evtch = C.int(x.Evtch) +xc.rref = C.int(x.Rref) + + return nil + } + +// NewGpioinfo returns an instance of Gpioinfo initialized with defaults. +func NewGpioinfo() (*Gpioinfo, error) { +var ( +x Gpioinfo +xc C.libxl_gpioinfo) + +C.libxl_gpioinfo_init(&xc) +defer C.libxl_gpioinfo_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *Gpioinfo) fromC(xc *C.libxl_gpioinfo) error { + x.Backend = C.GoString(xc.backend) +x.BackendId = uint32(xc.backend_id) +x.Frontend = C.GoString(xc.frontend) +x.FrontendId = uint32(xc.frontend_id) +x.Devid = Devid(xc.devid) +x.State = int(xc.state) +x.Evtch = int(xc.evtch) +x.Rref = int(xc.rref) + + return nil} + +func (x *Gpioinfo) toC(xc *C.libxl_gpioinfo) (err error){defer func(){ +if err != nil{ +C.libxl_gpioinfo_dispose(xc)} +}() + if x.Backend != "" { xc.backend = C.CString(x.Backend)} xc.backend_id = C.uint32_t(x.BackendId) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index c232e4811ac3..cb959d5fa87a 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -241,6 +241,11 @@ VkbBackendQemu VkbBackend = 1 VkbBackendLinux VkbBackend = 2 ) +type GpioBackend int +const( +GpioBackendVirtio GpioBackend = 0 +) + type I2cBackend int const( I2cBackendVirtio I2cBackend = 0 @@ -573,6 +578,7 @@ Usb Defbool Usbversion int Usbdevice string VkbDevice Defbool +GpioDevice Defbool I2cDevice Defbool Soundhw string XenPlatformPci Defbool @@ -636,6 +642,15 @@ MultiTouchHeight uint32 MultiTouchNumContacts uint32 } +type DeviceGpio struct { +BackendDomid Domid +BackendDomname string +Devid Devid +BackendType GpioBackend +Irq uint32 +Base uint64 +} + type DeviceI2c struct { BackendDomid Domid BackendDomname string @@ -928,6 +943,7 @@ Rdms []DeviceRdm Dtdevs []DeviceDtdev Vfbs []DeviceVfb Vkbs []DeviceVkb +Gpios []DeviceGpio I2cs []DeviceI2c Vtpms []DeviceVtpm P9S []DeviceP9 @@ -1083,6 +1099,17 @@ Evtch int Rref int } +type Gpioinfo struct { +Backend string +BackendId uint32 +Frontend string +FrontendId uint32 +Devid Devid +State int +Evtch int +Rref int +} + type I2cinfo struct { Backend string BackendId uint32 diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 4d19194c3dc2..f2fe616dee18 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -800,6 +800,15 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 +/* + * LIBXL_HAVE_BUILDINFO_GPIO_DEVICE + * + * If this is defined, then the libxl_domain_build_info structure will + * contain a boolean hvm.gpio_device which instructs libxl whether to include + * a gpio at build time or not. + */ +#define LIBXL_HAVE_BUILDINFO_GPIO_DEVICE 1 + /* * LIBXL_HAVE_BUILDINFO_I2C_DEVICE * @@ -2377,6 +2386,29 @@ int libxl_device_vkb_getinfo(libxl_ctx *ctx, uint32_t domid, libxl_vkbinfo *vkbinfo) LIBXL_EXTERNAL_CALLERS_ONLY; +/* GPIO */ +int libxl_device_gpio_add(libxl_ctx *ctx, uint32_t domid, libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_remove(libxl_ctx *ctx, uint32_t domid, + libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_destroy(libxl_ctx *ctx, uint32_t domid, + libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; + +libxl_device_gpio *libxl_device_gpio_list(libxl_ctx *ctx, + uint32_t domid, int *num) + LIBXL_EXTERNAL_CALLERS_ONLY; +void libxl_device_gpio_list_free(libxl_device_gpio* list, int num) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_gpio *gpio, + libxl_gpioinfo *gpioinfo) + LIBXL_EXTERNAL_CALLERS_ONLY; + /* I2C */ int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, const libxl_asyncop_how *ao_how) diff --git a/tools/include/libxl_utils.h b/tools/include/libxl_utils.h index 72b7796b7e4b..91f5c68172cb 100644 --- a/tools/include/libxl_utils.h +++ b/tools/include/libxl_utils.h @@ -83,6 +83,9 @@ int libxl_devid_to_device_usbctrl(libxl_ctx *ctx, uint32_t domid, int libxl_devid_to_device_vkb(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vkb *vkb); +int libxl_devid_to_device_gpio(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_gpio *gpio); + int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_i2c *i2c); diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index dca46846e586..6caa15cc1148 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,7 @@ SRCS-y += libxl_vdispl.c SRCS-y += libxl_pvcalls.c SRCS-y += libxl_vsnd.c SRCS-y += libxl_vkb.c +SRCS-y += libxl_gpio.c SRCS-y += libxl_i2c.c SRCS-y += libxl_genid.c SRCS-y += _libxl_types.c diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index d604171e504c..836d43bd3f03 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -363,6 +363,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); libxl_defbool_setdefault(&b_info->u.hvm.usb, false); libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); + libxl_defbool_setdefault(&b_info->u.hvm.gpio_device, true); libxl_defbool_setdefault(&b_info->u.hvm.i2c_device, true); libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); @@ -1756,6 +1757,7 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl__device_console console; libxl__device device; libxl_device_vkb vkb; + libxl_device_gpio gpio; libxl_device_i2c i2c; init_console_info(gc, &console, 0); @@ -1769,6 +1771,12 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl_device_vkb_dispose(&vkb); } + if (libxl_defbool_val(d_config->b_info.u.hvm.gpio_device)) { + libxl_device_gpio_init(&gpio); + libxl__device_add(gc, domid, &libxl__gpio_devtype, &gpio); + libxl_device_gpio_dispose(&gpio); + } + if (libxl_defbool_val(d_config->b_info.u.hvm.i2c_device)) { libxl_device_i2c_init(&i2c); libxl__device_add(gc, domid, &libxl__i2c_devtype, &i2c); @@ -1807,6 +1815,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_gpios; i++) { + libxl__device_add(gc, domid, &libxl__gpio_devtype, + &d_config->gpios[i]); + } + for (i = 0; i < d_config->num_i2cs; i++) { libxl__device_add(gc, domid, &libxl__i2c_devtype, &d_config->i2cs[i]); diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 9340ae4628a2..124b73f1dd00 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -2096,6 +2096,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, const libxl_domain_config *guest_config, libxl_device_vfb *vfb, libxl_device_vkb *vkb, + libxl_device_gpio *gpio, libxl_device_i2c *i2c) { const libxl_domain_build_info *b_info = &guest_config->b_info; @@ -2105,6 +2106,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, libxl_device_vfb_init(vfb); libxl_device_vkb_init(vkb); + libxl_device_gpio_init(gpio); libxl_device_i2c_init(i2c); vfb->backend_domid = 0; @@ -2116,6 +2118,9 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, vkb->backend_domid = 0; vkb->devid = 0; + gpio->backend_domid = 0; + gpio->devid = 0; + i2c->backend_domid = 0; i2c->devid = 0; @@ -2281,6 +2286,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) int ret; libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; char **args; struct xs_permissions perm[2]; @@ -2354,12 +2360,15 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) || libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { GCNEW(vfb); GCNEW(vkb); + GCNEW(gpio); GCNEW(i2c); - libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, i2c); + libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, gpio, i2c); dm_config->vfbs = vfb; dm_config->num_vfbs = 1; dm_config->vkbs = vkb; dm_config->num_vkbs = 1; + dm_config->gpios = gpio; + dm_config->num_gpios = 1; dm_config->i2cs = i2c; dm_config->num_i2cs = 1; } @@ -2503,6 +2512,12 @@ static void spawn_stub_launch_dm(libxl__egc *egc, if (ret) goto out; } + if (dm_config->num_gpios) { + ret = libxl__device_add(gc, dm_domid, &libxl__gpio_devtype, + &dm_config->gpios[0]); + if (ret) goto out; + } + if (dm_config->num_i2cs) { ret = libxl__device_add(gc, dm_domid, &libxl__i2c_devtype, &dm_config->i2cs[0]); diff --git a/tools/libs/light/libxl_gpio.c b/tools/libs/light/libxl_gpio.c new file mode 100644 index 000000000000..2bf68deb3850 --- /dev/null +++ b/tools/libs/light/libxl_gpio.c @@ -0,0 +1,236 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +#include + +static int libxl__device_gpio_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *gpio, bool hotplug) +{ + if (gpio->backend_type != LIBXL_GPIO_BACKEND_VIRTIO) { + gpio->backend_type = LIBXL_GPIO_BACKEND_VIRTIO; + } + + return libxl__resolve_domid(gc, gpio->backend_domname, &gpio->backend_domid); +} + +static int libxl__device_gpio_dm_needed(void *e, uint32_t domid) +{ + libxl_device_gpio *elem = e; + + return elem->backend_type == LIBXL_GPIO_BACKEND_VIRTIO; +} + +static int libxl__set_xenstore_gpio(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *gpio, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + flexarray_append_pair(back, "irq", GCSPRINTF("%u", gpio->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", gpio->base)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", gpio->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", gpio->base)); + + return 0; +} + +static int libxl__gpio_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_gpio *gpio) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + gpio->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &gpio->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + gpio->backend_type = LIBXL_GPIO_BACKEND_VIRTIO; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + gpio->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + gpio->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static int libxl__device_from_gpio(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *type, libxl__device *device) +{ + device->backend_devid = type->devid; + device->backend_domid = type->backend_domid; + device->backend_kind = LIBXL__DEVICE_KIND_GPIO; + device->devid = type->devid; + device->domid = domid; + device->kind = LIBXL__DEVICE_KIND_GPIO; + + return 0; +} + +int libxl_device_gpio_add(libxl_ctx *ctx, uint32_t domid, libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) +{ + AO_CREATE(ctx, domid, ao_how); + int rc; + + rc = libxl__device_add(gc, domid, &libxl__gpio_devtype, gpio); + if (rc) { + LOGD(ERROR, domid, "Unable to add gpio device"); + goto out; + } + +out: + libxl__ao_complete(egc, ao, rc); + return AO_INPROGRESS; +} + +int libxl_devid_to_device_gpio(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_gpio *gpio) +{ + GC_INIT(ctx); + + libxl_device_gpio *gpios = NULL; + int n, i; + int rc; + + libxl_device_gpio_init(gpio); + + gpios = libxl__device_list(gc, &libxl__gpio_devtype, domid, &n); + + if (!gpios) { rc = ERROR_NOTFOUND; goto out; } + + for (i = 0; i < n; ++i) { + if (devid == gpios[i].devid) { + libxl_device_gpio_copy(ctx, gpio, &gpios[i]); + rc = 0; + goto out; + } + } + + rc = ERROR_NOTFOUND; + +out: + + if (gpios) + libxl__device_list_free(&libxl__gpio_devtype, gpios, n); + + GC_FREE; + return rc; +} + +int libxl_device_gpio_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_gpio *gpio, + libxl_gpioinfo *info) +{ + GC_INIT(ctx); + char *libxl_path, *dompath, *devpath; + char *val; + int rc; + + libxl_gpioinfo_init(info); + dompath = libxl__xs_get_dompath(gc, domid); + info->devid = gpio->devid; + + devpath = libxl__domain_device_frontend_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_GPIO); + libxl_path = libxl__domain_device_libxl_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_GPIO); + + info->backend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + NULL); + if (!info->backend) { rc = ERROR_FAIL; goto out; } + + rc = libxl__backendpath_parse_domid(gc, info->backend, &info->backend_id); + if (rc) goto out; + + val = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/state", devpath)); + info->state = val ? strtoul(val, NULL, 10) : -1; + + info->frontend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + NULL); + info->frontend_id = domid; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_EVT_CHANNEL, devpath)); + info->evtch = val ? strtoul(val, NULL, 10) : -1; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_RING_GREF, devpath)); + info->rref = val ? strtoul(val, NULL, 10) : -1; + + rc = 0; + +out: + GC_FREE; + return rc; +} + +static LIBXL_DEFINE_UPDATE_DEVID(gpio) + +#define libxl__add_gpios NULL +#define libxl_device_gpio_compare NULL + +LIBXL_DEFINE_DEVICE_LIST(gpio) +LIBXL_DEFINE_DEVICE_REMOVE(gpio) + +DEFINE_DEVICE_TYPE_STRUCT(gpio, GPIO, gpios, + .skip_attach = 1, + .dm_needed = libxl__device_gpio_dm_needed, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_gpio, + .from_xenstore = (device_from_xenstore_fn_t)libxl__gpio_from_xenstore +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index b4dfbe7e5db1..7bbd9601ea7c 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4001,6 +4001,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__gpio_devtype; extern const libxl__device_type libxl__i2c_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index e9454e669224..b5a5cb99c2b4 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -266,6 +266,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_gpio_backend = Enumeration("gpio_backend", [ + (0, "VIRTIO") + ]) + libxl_i2c_backend = Enumeration("i2c_backend", [ (0, "VIRTIO") ]) @@ -618,6 +622,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ # - "mouse" for PS/2 protocol relative mouse ("usbdevice", string), ("vkb_device", libxl_defbool), + ("gpio_device", libxl_defbool), ("i2c_device", libxl_defbool), ("soundhw", string), ("xen_platform_pci", libxl_defbool), @@ -696,6 +701,15 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_gpio = Struct("device_gpio", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("backend_type", libxl_gpio_backend), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_i2c = Struct("device_i2c", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -974,6 +988,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("gpios", Array(libxl_device_gpio, "num_gpios")), ("i2cs", Array(libxl_device_i2c, "num_i2cs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), @@ -1136,6 +1151,17 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_gpioinfo = Struct("gpioinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ("evtch", integer), + ("rref", integer) + ], dir=DIR_OUT) + libxl_i2cinfo = Struct("i2cinfo", [ ("backend", string), ("backend_id", uint32), diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 1b87d1480bf9..3bb79c2a063a 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -33,6 +33,7 @@ libxl__device_kind = Enumeration("device_kind", [ (15, "VSND"), (16, "VINPUT"), (17, "I2C"), + (18, "GPIO"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index a9db0b97d80f..ffab4b362d2a 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_gpio": DEVICE_FUNCTIONS, "device_i2c": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index cdf473f4ed57..0114cc22a1b6 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(gpio) DEVICE_ADDREMOVE(i2c) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/Makefile b/tools/xl/Makefile index 06801962f11e..34ff203bfd86 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -23,7 +23,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o XL_OBJS += xl_info.o xl_console.o xl_misc.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_i2c.o +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_gpio.o xl_i2c.o $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XL_OBJS): CFLAGS += $(CFLAGS_XL) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 210bc1b6d47a..b2110b125ae4 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -177,6 +177,9 @@ int main_vsnddetach(int argc, char **argv); int main_vkbattach(int argc, char **argv); int main_vkblist(int argc, char **argv); int main_vkbdetach(int argc, char **argv); +int main_gpioattach(int argc, char **argv); +int main_gpiolist(int argc, char **argv); +int main_gpiodetach(int argc, char **argv); int main_i2cattach(int argc, char **argv); int main_i2clist(int argc, char **argv); int main_i2cdetach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 30bd614fc275..20bfedb74a7b 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -406,6 +406,21 @@ const struct cmd_spec cmd_table[] = { "Destroy a domain's virtual keyboard device", " ", }, + { "gpio-attach", + &main_gpioattach, 1, 1, + "Create a new virtual gpio device", + " ...", + }, + { "gpio-list", + &main_gpiolist, 0, 0, + "List virtual gpio devices for a domain", + "", + }, + { "gpio-detach", + &main_gpiodetach, 0, 1, + "Destroy a domain's virtual gpio device", + " ", + }, { "i2c-attach", &main_i2cattach, 1, 1, "Create a new virtual i2c device", diff --git a/tools/xl/xl_gpio.c b/tools/xl/xl_gpio.c new file mode 100644 index 000000000000..85c0b25411c7 --- /dev/null +++ b/tools/xl/xl_gpio.c @@ -0,0 +1,143 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include + +#include +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +int main_gpioattach(int argc, char **argv) +{ + int opt; + int rc; + uint32_t domid; + libxl_device_gpio gpio; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-attach", 2) { + /* No options */ + } + + libxl_device_gpio_init(&gpio); + domid = find_domain(argv[optind++]); + + for (argv += optind, argc -= optind; argc > 0; ++argv, --argc) { + rc = parse_gpio_config(&gpio, *argv); + if (rc) goto out; + } + + if (dryrun_only) { + char *json = libxl_device_gpio_to_json(ctx, &gpio); + printf("gpio: %s\n", json); + free(json); + goto done; + } + + if (libxl_device_gpio_add(ctx, domid, &gpio, 0)) { + fprintf(stderr, "libxl_device_gpio_add failed.\n"); + rc = ERROR_FAIL; goto out; + } + +done: + rc = 0; + +out: + libxl_device_gpio_dispose(&gpio); + return rc; +} + +int main_gpiolist(int argc, char **argv) +{ + int opt; + libxl_device_gpio *gpios; + libxl_gpioinfo gpioinfo; + int nb, i; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-list", 1) { + /* No options */ + } + + /* Idx BE Hdl Sta evch ref ID BE-type BE-path */ + printf("%-3s %-2s %-6s %-5s %-6s %6s %-10s %-10s %-30s\n", + "Idx", "BE", "handle", "state", "evt-ch", "ref", + "ID", "BE-type", "BE-path"); + for (argv += optind, argc -= optind; argc > 0; --argc, ++argv) { + uint32_t domid = find_domain(*argv); + gpios = libxl_device_gpio_list(ctx, domid, &nb); + if (!gpios) { + continue; + } + for (i = 0; i < nb; ++i) { + if (libxl_device_gpio_getinfo(ctx, domid, &gpios[i], &gpioinfo) == 0) { + printf("%-3d %-2d %6d %5d %6d %6d %-10s %-30s\n", + gpioinfo.devid, gpioinfo.backend_id, + gpioinfo.devid, gpioinfo.state, gpioinfo.evtch, + gpioinfo.rref, + libxl_gpio_backend_to_string(gpios[i].backend_type), + gpioinfo.backend); + libxl_gpioinfo_dispose(&gpioinfo); + } + } + libxl_device_gpio_list_free(gpios, nb); + } + return 0; +} + +int main_gpiodetach(int argc, char **argv) +{ + uint32_t domid, devid; + int opt, rc; + libxl_device_gpio gpio; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-detach", 2) { + /* No options */ + } + + domid = find_domain(argv[optind++]); + devid = atoi(argv[optind++]); + + libxl_device_gpio_init(&gpio); + + if (libxl_devid_to_device_gpio(ctx, domid, devid, &gpio)) { + fprintf(stderr, "Error: Device %d not connected.\n", devid); + rc = ERROR_FAIL; + goto out; + } + + rc = libxl_device_gpio_remove(ctx, domid, &gpio, 0); + if (rc) { + fprintf(stderr, "libxl_device_gpio_remove failed.\n"); + rc = ERROR_FAIL; + goto out; + } + + rc = 0; + +out: + libxl_device_gpio_dispose(&gpio); + return rc; +} + + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 95483e551c38..7ab4f22821c4 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1204,6 +1204,74 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +int parse_gpio_config(libxl_device_gpio *gpio, char *token) +{ + char *oparg; + + if (MATCH_OPTION("backend", token, oparg)) { + gpio->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("backend-type", token, oparg)) { + libxl_gpio_backend backend_type; + if (libxl_gpio_backend_from_string(oparg, &backend_type)) { + fprintf(stderr, "Unknown backend_type \"%s\" in gpio spec\n", + oparg); + return -1; + } + gpio->backend_type = backend_type; + } else if (MATCH_OPTION("irq", token, oparg)) { + gpio->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + gpio->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in gpio spec\n", token); + return -1; + } + + return 0; +} + +static void parse_gpio_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *gpios; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "gpio", &gpios, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(gpios, entry)) != NULL) { + libxl_device_gpio *gpio; + char *p; + + gpio = ARRAY_EXTEND_INIT(d_config->gpios, + d_config->num_gpios, + libxl_device_gpio_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_gpio_config(gpio, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + int parse_i2c_config(libxl_device_i2c *i2c, char *token) { char *oparg; @@ -2373,15 +2441,18 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_gpios = 0; d_config->num_i2cs = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->gpios = NULL; d_config->i2cs = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; char *buf2 = strdup(buf); @@ -2393,6 +2464,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + gpio = ARRAY_EXTEND_INIT(d_config->gpios, d_config->num_gpios, + libxl_device_gpio_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, libxl_device_i2c_init); @@ -2653,6 +2727,7 @@ void parse_config_data(const char *config_source, if (vnc_enabled) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; vfb = ARRAY_EXTEND_INIT(d_config->vfbs, d_config->num_vfbs, @@ -2661,6 +2736,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + gpio = ARRAY_EXTEND_INIT(d_config->gpios, d_config->num_gpios, + libxl_device_gpio_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, libxl_device_i2c_init); @@ -2778,6 +2856,7 @@ void parse_config_data(const char *config_source, exit(-ERROR_FAIL); } xlu_cfg_get_defbool(config, "vkb_device", &b_info->u.hvm.vkb_device, 0); + xlu_cfg_get_defbool(config, "gpio_device", &b_info->u.hvm.gpio_device, 0); xlu_cfg_get_defbool(config, "i2c_device", &b_info->u.hvm.i2c_device, 0); xlu_cfg_replace_string (config, "soundhw", &b_info->u.hvm.soundhw, 0); xlu_cfg_get_defbool(config, "xen_platform_pci", @@ -2827,6 +2906,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_gpio_list(config, d_config); parse_i2c_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", diff --git a/tools/xl/xl_parse.h b/tools/xl/xl_parse.h index 4b972d525199..6e041abe5d50 100644 --- a/tools/xl/xl_parse.h +++ b/tools/xl/xl_parse.h @@ -36,6 +36,7 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config **config, char *token); int parse_vdispl_config(libxl_device_vdispl *vdispl, char *token); int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec); int parse_vkb_config(libxl_device_vkb *vkb, char *token); +int parse_gpio_config(libxl_device_gpio *gpio, char *token); int parse_i2c_config(libxl_device_i2c *i2c, char *token); int match_option_size(const char *prefix, size_t len, diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c index a44c765aa515..632e1f338d09 100644 --- a/tools/xl/xl_sxp.c +++ b/tools/xl/xl_sxp.c @@ -140,6 +140,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) fprintf(fh, "\t\t\t(usbdevice %s)\n", b_info->u.hvm.usbdevice); fprintf(fh, "\t\t\t(vkb_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.vkb_device)); + fprintf(fh, "\t\t\t(gpio_device %s)\n", + libxl_defbool_to_string(b_info->u.hvm.gpio_device)); fprintf(fh, "\t\t\t(i2c_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.i2c_device)); fprintf(fh, "\t\t)\n"); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu May 05 07:33:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321562.542599 (Exim 4.92) (envelope-from ) id 1nmVza-0007uh-JY; Thu, 05 May 2022 07:33:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321562.542599; Thu, 05 May 2022 07:33:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVza-0007tH-BK; Thu, 05 May 2022 07:33:42 +0000 Received: by outflank-mailman (input) for mailman id 321562; Thu, 05 May 2022 07:33:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzZ-0007CX-4Y for xen-devel@lists.xen.org; Thu, 05 May 2022 07:33:41 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae742219-cc45-11ec-a406-831a346695d4; Thu, 05 May 2022 09:33:40 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id p12so3037160pfn.0 for ; Thu, 05 May 2022 00:33:40 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id v10-20020aa799ca000000b0050dc7628166sm660155pfi.64.2022.05.05.00.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:33:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae742219-cc45-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oaW6A1hTB436RSWpybXMNt3EyRCE2jUiJD8XH/4GaQk=; b=vdN1z4Xl4+W+wF9Zqgim2NY6dUQsGEGR3O8/mWhFKgr/dzabvXjWTLqQOM/N0Mmh7P 1augu9E5HCtpv03jGlmm3+B0tlnObreRnffK/eis41JupPw0wF+L02KTYnA8RqxlLbkX KpfFRkc/HkDHLFpwxgv9qp1K/neeVuzH8X4tt4WgP6h8b4cenvuYp5FkyWI2krCV2SUu iDJVPHCbX3s5kYDmjSDgjVUCP3jGFjhZGCQzQfSSK2cwpec5J7NaOUnFTDoFK0NjbgII a8N2Mh0SLebfwvvpDE/mjTrXAPN5yl06inr6jhn/MRQFd6IlTpQxv+q8MVsMlTh+iLtG HW2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oaW6A1hTB436RSWpybXMNt3EyRCE2jUiJD8XH/4GaQk=; b=L+9usCsWxJLO+NuUa64aq968uxOX9sMenRhoyrCO6h+QTiw04yI3ywmjmhnFa48rdL oNHuYXUIZOo0zQ9AcnN2dlj4L32G0tAnIzw2T+EkS3cKTvd7rBxsiH8k6VRB373s9UJd /s5bkHut8csMunQDMkM/3PTZQd2CAMk8q41HqJ1JplEav5DHhLpnotkc3ifgCkJhjqGv 5nW0SN1dtlCyCFgIM9apkytaX2LzIF9qrOWG8pBm7pFamCYVbn07FK/WhfCpAYUQKzVO IlIPnrno4PrxdQSiopb6XuIqiGP2lgyo4sD3EYbsAC7zAr8Bre48P908hNJqXyJPY1QX wSmA== X-Gm-Message-State: AOAM533VRCpVcstmC3A/PAuWh7ysKZhkR46872QlipncY8BOy0URQ1xT li0nfwDsehkqoo/mBDZgg2pSHCrlMdsrCg== X-Google-Smtp-Source: ABdhPJwOTMbqTMVYU7vnXDi2mDFlDRgF2RkAaFuDlhX4shtx7BTvK7Ri/i74rwPlQxZk2EKMaGd3jw== X-Received: by 2002:a65:684c:0:b0:3ab:7c9c:f648 with SMTP id q12-20020a65684c000000b003ab7c9cf648mr21261369pgt.562.1651736018870; Thu, 05 May 2022 00:33:38 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH 3/4] libxl: Allocate MMIO params for I2c device and update DT Date: Thu, 5 May 2022 13:03:22 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 57 ++++++++++++++++++++++++++++++++++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 8132a47a72b6..ea633d6f91df 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -115,6 +115,26 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, } } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + + i2c->base = alloc_virtio_mmio_base(gc); + if (!i2c->base) + return ERROR_FAIL; + + i2c->irq = alloc_virtio_mmio_irq(gc); + if (!i2c->irq) + return ERROR_FAIL; + + if (virtio_irq < i2c->irq) + virtio_irq = i2c->irq; + + virtio_enabled = true; + + LOG(DEBUG, "Allocate Virtio MMIO params for I2C: IRQ %u BASE 0x%"PRIx64, + i2c->irq, i2c->base); + } + if (virtio_enabled) nr_spis += (virtio_irq - 32) + 1; @@ -874,7 +894,7 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, } -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, +static int _make_virtio_mmio_node(libxl__gc *gc, void *fdt, uint64_t base, uint32_t irq) { int res; @@ -897,7 +917,35 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property_interrupts(gc, fdt, &intr, 1); if (res) return res; - res = fdt_property(fdt, "dma-coherent", NULL, 0); + return fdt_property(fdt, "dma-coherent", NULL, 0); +} + +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + + res = _make_virtio_mmio_node(gc, fdt, base, irq); + if (res) return res; + + return fdt_end_node(fdt); +} + +static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + + res = _make_virtio_mmio_node(gc, fdt, base, irq); + if (res) return res; + + res = fdt_begin_node(fdt, "i2c"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device22"); + if (res) return res; + + res = fdt_end_node(fdt); if (res) return res; res = fdt_end_node(fdt); @@ -1221,6 +1269,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); + } + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu May 05 07:33:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321564.542615 (Exim 4.92) (envelope-from ) id 1nmVzd-0008R8-QC; Thu, 05 May 2022 07:33:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321564.542615; Thu, 05 May 2022 07:33:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzd-0008Qx-Mv; Thu, 05 May 2022 07:33:45 +0000 Received: by outflank-mailman (input) for mailman id 321564; Thu, 05 May 2022 07:33:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmVzc-0007CX-Mi for xen-devel@lists.xen.org; Thu, 05 May 2022 07:33:44 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0a68c66-cc45-11ec-a406-831a346695d4; Thu, 05 May 2022 09:33:44 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id i1so3631155plg.7 for ; Thu, 05 May 2022 00:33:43 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id 6-20020a631546000000b003c14af50628sm591840pgv.64.2022.05.05.00.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:33:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0a68c66-cc45-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QGzDrTPy64513Du9xuDXa48CFlPswySc0zHzj23oYf8=; b=RxPh60rFi0elI38eto3TqPlDZfFZal0laZeixIdoLopmOZAb73Vxx1fWN2wCIObCvO jIpnaNf6YMKDdNllCJAT0oR0zpuW0nnnXshrpTKEgnYIMU7e4mZVriwWq12z4/QBI1Y3 cAEL2FB3116miQnVi5XUfJO9mKoDw9PTEZIhf643PzJXYrO1CLUstYY3G9T5qeb+2ik3 Wvvd6g36jxK1CYLm+h5uqKckO1k50Y7NyUjWBAzyBoGFCU333Ikd74gXUWsovu2GFp4f nWJWdARTUU5P8ysk0hmar4QhnI8VGSZ16+5Qp16ewKskcP1Gp/0YgpTzPp1LYg0OWcpr oYkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QGzDrTPy64513Du9xuDXa48CFlPswySc0zHzj23oYf8=; b=X2iXhHMwKO3NIn70tmtYLOKllAdTSkY/9Vx1FMmrgaocYxaK/RUyMH7Uytw0RAA10p As5D7Pmh+1z5Fnd31VGCcc/62Gl91AAgK9Ci215y2aQXELLC5JxmTzOOMw6+vIavaYv4 IsRWPU2xk97lzeUH9qHicZJKRwz3+Y34IkB2h56pkIreaoI4ArTgyMIq4aNHZbLCjzlu yF03K/3+qYb4/sLcUzll/SkDJnmJL6EI1y+/FwiXuhiHLGGgwYUNOYKWBRxl2+1jK7rY mQwcBn3xqpoQViIiviGmtAMAum2vrZcXyiVrFUSCkHvBiUyb0Xll4Hf+DpoednWB75vq 3fAQ== X-Gm-Message-State: AOAM531XrMiA6xU1dNbNEvMp+kfB9yBYD3WpQ2tvrz09ZVeug+GjGsS6 iMQGLMe1jIYrek+1QBvYa6xcKCEa1NmSXA== X-Google-Smtp-Source: ABdhPJwFRgUBsEWqupRmG0rkhQ5zqwButa/QLfnJhmFpSeJkJ1MEZDguOtWs3PBiKoi2GHTCECyw7Q== X-Received: by 2002:a17:90b:3508:b0:1dc:c275:3e18 with SMTP id ls8-20020a17090b350800b001dcc2753e18mr714198pjb.245.1651736021423; Thu, 05 May 2022 00:33:41 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH 4/4] libxl: Allocate MMIO params for GPIO device and update DT Date: Thu, 5 May 2022 13:03:23 +0530 Message-Id: <0b8d38ef26bfa9bc150f3818108ca9e875652e5e.1651734854.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 60 ++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ea633d6f91df..89e5a1e5780d 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -135,6 +135,26 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, i2c->irq, i2c->base); } + for (i = 0; i < d_config->num_gpios; i++) { + libxl_device_gpio *gpio = &d_config->gpios[i]; + + gpio->base = alloc_virtio_mmio_base(gc); + if (!gpio->base) + return ERROR_FAIL; + + gpio->irq = alloc_virtio_mmio_irq(gc); + if (!gpio->irq) + return ERROR_FAIL; + + if (virtio_irq < gpio->irq) + virtio_irq = gpio->irq; + + virtio_enabled = true; + + LOG(DEBUG, "Allocate Virtio MMIO params for GPIO: IRQ %u BASE 0x%"PRIx64, + gpio->irq, gpio->base); + } + if (virtio_enabled) nr_spis += (virtio_irq - 32) + 1; @@ -954,6 +974,41 @@ static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, return 0; } +static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + + res = _make_virtio_mmio_node(gc, fdt, base, irq); + if (res) return res; + + res = fdt_begin_node(fdt, "gpio"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device29"); + if (res) return res; + + res = fdt_property(fdt, "gpio-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#gpio-cells", 2); + if (res) return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 2); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -1269,6 +1324,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); } + for (i = 0; i < d_config->num_gpios; i++) { + libxl_device_gpio *gpio = &d_config->gpios[i]; + FDT( make_virtio_mmio_node_gpio(gc, fdt, gpio->base, gpio->irq) ); + } + for (i = 0; i < d_config->num_i2cs; i++) { libxl_device_i2c *i2c = &d_config->i2cs[i]; FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Thu May 05 07:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321584.542626 (Exim 4.92) (envelope-from ) id 1nmW2g-0001uZ-C0; Thu, 05 May 2022 07:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321584.542626; Thu, 05 May 2022 07:36:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW2g-0001uS-8v; Thu, 05 May 2022 07:36:54 +0000 Received: by outflank-mailman (input) for mailman id 321584; Thu, 05 May 2022 07:36:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW0d-0007CX-88 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:34:47 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d5fab755-cc45-11ec-a406-831a346695d4; Thu, 05 May 2022 09:34:46 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id s14so3634224plk.8 for ; Thu, 05 May 2022 00:34:46 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id i8-20020a170902c94800b0015e8d4eb24dsm771036pla.151.2022.05.05.00.34.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 00:34:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5fab755-cc45-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l2DlLsy5lkQbdWfeVmn+2WmrzKLcTz2JsLkufshoHHo=; b=fP/bHM4G4SEDaKwTRzXjiKwoxlD/tQN3YNJdy82WGNRCrXey5PTWiZRyhoScm9pd/0 ZFH5r/1Rg46N1c0ywEKTRUimv5GywiD00mGhaPdFjWMgzPW0Rq6pkxf5V0E06l7P8GAC 0B+ikUPZNBg/+OOUqJEMPp/uNTZ+INYkeaeiH62pv+YpzdCb/Ed7f99UvWR8QPW/MyOy G57FGANXxV8ZU5IIjonLEjdnWmmM/0mIgIY8KE5LTMe2I12QKRGoZiygEGT4aTz3zQ9b Vj1B4bBykjRXYTgW1JfbJp2LexYAFeP/Dv8THNQfZDCi1UWf8wfGugT+UpFiEOOVCvh8 D2Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l2DlLsy5lkQbdWfeVmn+2WmrzKLcTz2JsLkufshoHHo=; b=N/EeCAvtqDquXY0MjID5+R6wSRE8yJmENnef/EqiRuHYQwVaX7LFhXmSCpumId1BXb Ji0UoFX43NI9S7TF6UOHxRi0qBL9JNyvwIBBvw3Y7q11VKH/b9mA1hljC9p/EF+ttWwR uKLD11MQrXaDtcANbwWHEpjb2pW2jR+NkMtSVHxOI9XQVxRTD0M+RyPYrhtLNbrtsV6L IOLjHtERW7K65Z+TBfTt5+DbeehC64mv3iyqORdlZMmAzZ5EEl5dIb3vmVH3ygEsGu82 4WZcf4gOLvueVjmR+1OpGpj0z8XoOYkYBZvVUPbWoDx0E3knOaqsyi5hDD7af6e5GQUj aRDg== X-Gm-Message-State: AOAM532cGf45eF0CPifip2dH/bO3FjnxOKieRJ8kHR473bvxGMe3gnFT 0p8EnCukNxrt+hoOfHh0bv23YQ== X-Google-Smtp-Source: ABdhPJzr2ScpVn9pQo1AkF0WETnQpxMNZnnGzwXkg8yJZCMlm3RXGXbpTH1HxLCmB8FbvfQo1Hg0iA== X-Received: by 2002:a17:902:ecc8:b0:15e:b5d3:2687 with SMTP id a8-20020a170902ecc800b0015eb5d32687mr12680367plh.164.1651736085128; Thu, 05 May 2022 00:34:45 -0700 (PDT) Date: Thu, 5 May 2022 13:04:42 +0530 From: Viresh Kumar To: Oleksandr Cc: Stratos Mailing List , Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Vincent Guittot , Mike Holmes , Wei Liu , xen-devel , Juergen Gross , Julien Grall Subject: Re: Virtio on Xen with Rust Message-ID: <20220505073442.io6ojvmstmn6e6xc@vireshk-i7> References: <20220414091538.jijj4lbrkjiby6el@vireshk-i7> <20220429034808.dr647727dphnx6zk@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 On 29-04-22, 13:44, Oleksandr wrote: > On 29.04.22 06:48, Viresh Kumar wrote: > > What should I do about these patches ? Send them to xen list ? I can at least > > send the stuff which doesn't depend on your series ? > > Below my understanding, which might be wrong) > > > I think, the best case scenario - is to try to get these features > upstreamed. I expect a possible interest to virtulized I2C/GPIO devices on > Xen, > especially in embedded environment where the passthrough of dedicated > I2C/GPIO controller to the guest is not possible for some reason (clocks, > pins, power domains, etc). > But I do understand it most likely takes some time. If upsteaming this stuff > is not your primary target, then I think, such patch series deserves to be > sent to the Xen mailing list anyway for someone who is interested in the > topic to give it a try. For example, you can send RFC version saying in > cover letter that it depends on non-upsteamed yet stuff to start discussion. I have sent the patchset to xen list. Thanks. -- viresh From xen-devel-bounces@lists.xenproject.org Thu May 05 07:40:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321603.542637 (Exim 4.92) (envelope-from ) id 1nmW5m-0003IV-Qq; Thu, 05 May 2022 07:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321603.542637; Thu, 05 May 2022 07:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW5m-0003IO-Nl; Thu, 05 May 2022 07:40:06 +0000 Received: by outflank-mailman (input) for mailman id 321603; Thu, 05 May 2022 07:40:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW5m-0003Dy-7v for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:40:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 945e5456-cc46-11ec-a406-831a346695d4; Thu, 05 May 2022 09:40:05 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-Rh5dMx_GMeu22Q4vILKvKw-1; Thu, 05 May 2022 09:40:04 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by HE1PR0402MB3497.eurprd04.prod.outlook.com (2603:10a6:7:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 07:40:01 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 07:40:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 945e5456-cc46-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651736405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZzN6p7dLMk3EaNILW4pfgpF1pgIj4xwgfqJW0MG00w=; b=n5aVdAOL8FZBBASbepX5uwtDVle2k8gNtPg/FHV1g177fmKE6No8Tk+U7EtkGxqCN4vsbh fd2YsLQlE+25x8M7lBpVUL+C0tp2/iJv9P6xYj6vzkPxfaA0WBjdz6j1HS0N0AT+NAD7yh EqydcYgjbkIYX2YjYlCu8YMT0Z9hyS4= X-MC-Unique: Rh5dMx_GMeu22Q4vILKvKw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BWzaVfgcQov13q873OUbW8rmfQmtfa517q9cHy17koAHFmL4C36i2LXIjVdCTNZaLX3yeN1GzVT2x+RBkUbT+YFgVWx1Z92/T7acg0hyihPrZeFjFN2sfevsU6msI8DNU1+FlTbrVa76SFymVrv0pM03cA9DotUvYMV3UfMkwhz06Dl2EtDV9VkOdNs1b1iRG0WIR9fEh/2/q/mMSzMYXqewjptaOQBds6zgtgus2bsvbiXAds9alpot5YgLbQ/WApUPvBZMs9XvlBW7JeHRHv1WpqvefCoJEf5RjCLyOU0dO9gZK7t1nxEP0Rb7fxXPNIaK58wh8w//hT/IJ+2ZZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gZzN6p7dLMk3EaNILW4pfgpF1pgIj4xwgfqJW0MG00w=; b=AQG3ZCLe9acNI1JwFfCEUqzLXLoJrafROxvaXKmvyYRWyBdIz6x4dekPKu17E7U328387w0hz3e+7O4SZrQOb5OOOf9hekxfYzkfArb2TkpZB/iievBG3h78BS00wV/SwzNQBuENHBE5n5PqWC9RsQ9LCJPAKnZ3L0NaqBEqbwYqSgNbgkONTGLRcZ0T8xzXJwPOvdbRfFaFrn4DUs18RhdiCJ3b4M5kT0I62ubfLH7l9F9p/1KzXhVyMG9vcWByR3xp5l0fun1E/EMS0AMbT3T3riJAzL3Dz6KJ47xO9g1VGf+agfLDUer/vcN6oaOp+mpnkMFyHaq+XI9dEj9NqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 May 2022 09:40:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Content-Language: en-US To: Henry Wang Cc: "xen-devel@lists.xenproject.org" References: <20220505025407.919988-1-Henry.Wang@arm.com> <20220505025407.919988-3-Henry.Wang@arm.com> <89fa76cc-2fa0-5ec3-64d7-d83407b8a495@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0086.eurprd04.prod.outlook.com (2603:10a6:20b:50e::24) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88db32af-bb50-4ee6-089c-08da2e6a7647 X-MS-TrafficTypeDiagnostic: HE1PR0402MB3497:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MDIWlL9CiqLu4xQm1UwkH7Sz5D5QG5IQY0IocSlZBTrcLGjInsjms7fG0zdoxBcgAfw7tNvq+ig5ZTwW7uxknk0wc/pa7p9IKm7xVwKRB+YxOqwbJZB4Q8GgnxtRyMrTwJVGHOcIw8wZz0F+ufk2qxlAmSlDNPB48COV9q12iA2ZlzHEqHoPPL4jD2apJceDO4avheRTRylFYb4Qpla0UYITDUSq1lfOWq876UT8bsLTR/+enENeWfRS9HTXbjeBObXMh175+QNZDPQLEkpyXmJiLwqPV19EwDg4wyUiZbIOl1B8nHnDQfX8xai8A8XJM6ueBcMBFEEkeOHx73K67JJeq1hIID3FKCYJ4b3vd0itwL0EJJmkfgSqAJnaV1JjvAiSevjqsYAw+yLIGG2MTksO//FULh5vm/3qVr84EbUVEN/n6MR8LPM/MIL8d/c/cjrEJ8ASUDmkvZHJnwUWTDnOofG2r7KF57EoAsE/ABmmx0yzzonXmpKPB2bNjzkUluBUYmrU0o3BFOvJH/BsEryNRNbReGka5Kce5YvJSl51DvCYTy3+SQoa9mT/JVy60JDaXrZ9nync3FChKXU0JSk/BDaAH9kq164EotZSDYjHD9YCWFc0/JPka/FSGnwT0R4E8xfRwkBQotypaKEARMtxdNoo2be69BMhsj9oTCvqYlNfAFeFCbvPP7e6yv7OQ2ry8sLC0vz73NAPj5RaY/hUHaG5d5oe1n94H3m5AS96xxZNweMPfmdP/7j4WoLg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(316002)(6916009)(508600001)(53546011)(6506007)(26005)(83380400001)(86362001)(5660300002)(31696002)(6512007)(186003)(2616005)(36756003)(31686004)(8936002)(38100700002)(2906002)(8676002)(4326008)(66556008)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aENMaXAwZmtHZlJJVzNFNmlHSFRPTVkyZlppaWpCSXp5eGRJRS9TRUlDSnJ0?= =?utf-8?B?OGo4Tkc0clNVdGxRUXFFQkZ1SkFOcjJ3NGd5YXFxYXRXREFrOTE4bHBvZU5j?= =?utf-8?B?OC8rUVRObTNTcGFTZkJMUGlSVVFWNlNnQVhPNThIeUdaK1RxQXFTM3d1U0l3?= =?utf-8?B?SnBXYkxxb285dU1KWFZXTEV0ZTFzNlJibFdSZE91dTl2UUhSZmhoYmowaFpU?= =?utf-8?B?bHFNQkFVWTMxeDVSQnA1MmRMckFHQnVZUVhrc0tUTXBZTmZHanQ3d2pNb2J5?= =?utf-8?B?ZVdibGZvcHpBRFp5NmZyYzJMM0NNY0h5dmd6NGVqOFYxUUc2RDdURzYrOEpt?= =?utf-8?B?cXJvVmVyNXdPRXFOUnBtSGhQUVFCR1gvUjhMc1pUL1dJaFVlSzhJMkh6QkJO?= =?utf-8?B?RnEwQkMrSXJWSUhlZXVZV1UzMGY0L2NSU2FiREQ0aUNJNmZUZmJYRjhMVTQ4?= =?utf-8?B?TDF4RGt1UkY0MFhBOHBjVEY2OXJOUnBNdEFHYjM5cm5Ga1NrekNiOHdsdDh2?= =?utf-8?B?YlZsZUdFL1p1ZDBlTVhEdVR0dmhUS1dRWDRJVWFqNkI2TTZTMjZnU1Jlemli?= =?utf-8?B?WForYnMxRHVOSmhiYW02RkMxWTkzejZmWTZ6V2s3SjZvajJ1ZUVHYkROa1E3?= =?utf-8?B?ZkdRYmtYTUhQYUh4U3lNSWU5M1JsaFZyNnFVd0dCNWo0amMybXZQYndwZmtP?= =?utf-8?B?Tis2RjNSYzJXcW04Rk5FRWt4QkJZRCtLTG05eXJjQ3I2OHl3N1p2WjM5R0I2?= =?utf-8?B?d2lNL0hkZW1WZ1REL0VFdkFkdEZyOWo4MXhmYzBpQ2R4RkEvZUxLSWQwTWZZ?= =?utf-8?B?cWZva3pXNTVqajB6aDU3bGRSek9mbTRHTFNLWnhpV1hPMnFBS05ha2dpcEsv?= =?utf-8?B?NHEvMitRRGpEL3FTeFRLWTRCNkk3VjdyN3UrY3k5Z3BIQVozMTF1Y25xQ1VX?= =?utf-8?B?MGlvLzVpbFJnVXQzUEZTK2RnS09vNEd3K1pCbHU1OHFVYi9jZmM1MG1lREMr?= =?utf-8?B?SUlHaytzb0ZCSnpKa1hsMnppQWhoY282cDVXSUFNWDZOMlorVHpjMVZkYVBp?= =?utf-8?B?V3JGNEhqQ2pvdTNxQWYzUnh6Umw1bFZEZy9VMzR3a0JuTE1jZXNSQ2t5NjJ5?= =?utf-8?B?L2RDMUxnS2h5Wmpnd29hQW40Q2tybFpyRlhvcmROSWlibnpDOURHL0c2MGhq?= =?utf-8?B?NFM3YkhKbU8vVEtNcGdhbVFFYnNLR3VsV3BtdjZiOHBORXcvdlJvUUpFM0FB?= =?utf-8?B?MlVUVHVkWGxya2VnUllFcW94QXZVRkVhTlppdm9rZnBxcmdMTnJsZnFYUExZ?= =?utf-8?B?TGJtM0UzT3c2eG9ZTnZBMzdkYzVCUWEvR2JUWkNuN3FUb1Nwbm9hMWk3RnBo?= =?utf-8?B?elJWcGpVTzhGQXVFUVlxeHdPQXFicjYyY1lTUVNhajBlYStiN2xFQ29HZWZk?= =?utf-8?B?b3pmc2pXc3FUYTA3dlpNcHN0OHZhU1ZlYnorTUcyM2dDN2ZIYzhsY3dKZGdw?= =?utf-8?B?VXBDN01JZWNhb3plc2FpM1dWUjdrNnlUaUc4bHIrMmhpUzB3Q2R2N0lZUi9J?= =?utf-8?B?TkxSaGNKdG9lZUdFRDM4Q0xBQi9tM0NjVVpKTXkxRXRuNFJpcFNhWGlUYzJi?= =?utf-8?B?VVg3cjRIY0s2bmZxOUtPOGZPa3V1dndZRVhJSnV4YWhBT3FqL3JZdTF0VVVx?= =?utf-8?B?dks3Q0RWanRTUmdKSkpQRU5SRm1uYUNjU09OUEJXNjYzSmxUbGhZYXMvRUtm?= =?utf-8?B?d0Yxb2NBMWI4eEYrdURuOGtMZXRwQkEyRURBNEVXYVoyUkNPaCtBTGhBdEx2?= =?utf-8?B?eWJ2Z3l0ZHZZWEI3clYrM0ZFUytSMUliUXFnai9DQXYwZlV0WmFEM1JnK1Mw?= =?utf-8?B?YnlTK294KytNQ1J5RCszakVuZVE2ZDhMWENVblVsN1hvTjJBTzlhekxHY2gr?= =?utf-8?B?RDBYRkFFMUY1QmQ5dnc5cXNXcGl2WE9rNHN4K0ZkSnN4SXR5dWVvVVU1a3la?= =?utf-8?B?UWUrVktRTFhLZzJJbjBldTZXVEthVFpwSjNmdWVYemhyUHhtQU90RWpmS2xH?= =?utf-8?B?Mkd3ODdPZ2U3MnM1Mk1XV3JYSzFHWTVDSENSbXVnWlNZOXE3TDh1Q0g3MTlo?= =?utf-8?B?QlIvM2x2VnRYQ2ZwY1R1NE9FeXNDWWNJSG5GT2FuTUpTV3JOUHZhbHVrQUhL?= =?utf-8?B?VE1hbG1SVU1GQlpqWlNhaWFqZTRzc0dXcEpXU2JPOUU3a3A1WDh4bE1mNGo1?= =?utf-8?B?NG0rV0ZXRCtiM1BSN2NwTlRldFl5N1dGWVBNWUZEbXZabHdkbTU5RU1NYmhy?= =?utf-8?B?cWVkeTNvR3RWUnRaSG1PeU9UNGNJU2VJNzRSVUNLTWNSOE9XUEVCQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88db32af-bb50-4ee6-089c-08da2e6a7647 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:40:01.4780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6isiS/dvwkrk2NDQQDvputfTGN1/u16nIJqpuo8vxnRDNTS4EKy5pl56kXiARxc/79xTZgjRVZPZJKrtxLi1hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3497 On 05.05.2022 09:26, Henry Wang wrote: >> -----Original Message----- >> From: Jan Beulich >>> Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67 >> >> Just two formal remarks for starters: What's this last tag? And why am >> I on the To: list of this patch, when ... > > I forgot to remove the Change-Id before sending the patch, sorry about that. > This will be removed in v2. > >> >>> --- >>> xen/common/page_alloc.c | 7 ------- >>> xen/common/xmalloc_tlsf.c | 2 +- >>> xen/include/xen/irq.h | 7 +++++++ >>> 3 files changed, 8 insertions(+), 8 deletions(-) >> >> ... with this diffstat you should instead have _Cc_-ed REST maintainers? > > I think this is because by switching to add-maintainers.pl I didn't change > my git send-email command line where originally it has a --suppress-cc=all. > Since you are the maintainer of common code I thought I should directly > "To" you. I'm sorry, but no: For one I am not "the" maintainer, but one of several. And then patches are generally only sent _To_ the list, with _Cc_ to maintainers. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 07:42:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321612.542648 (Exim 4.92) (envelope-from ) id 1nmW84-0003yH-BI; Thu, 05 May 2022 07:42:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321612.542648; Thu, 05 May 2022 07:42:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW84-0003yA-7o; Thu, 05 May 2022 07:42:28 +0000 Received: by outflank-mailman (input) for mailman id 321612; Thu, 05 May 2022 07:42:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmW83-0003y4-Et for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:42:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e888d057-cc46-11ec-a406-831a346695d4; Thu, 05 May 2022 09:42:26 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-D3EtbukcMmmsDdTXr4sEoQ-1; Thu, 05 May 2022 09:42:22 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB4292.eurprd04.prod.outlook.com (2603:10a6:208:67::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 07:42:21 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 07:42:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e888d057-cc46-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651736546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+7/WrkTa+pkAfbx4Jft+s4DtAVkSGAzAFhBNOuODXg=; b=Hz+Q8pwAV2LuTjCJ091h0db+SApWmLunpaQaslqFbP71OqapZiUqyAFDjUd7/puaHsUlV1 YdZ2kt9ErlVQhEH3q8xlaJl5vV6mMweM9LykMssUE1NUabJaCHu6KUnFzEhb40xtDCz8Ax 5uwCRLFg48OO1PJpXmj8ovCozjV2hSE= X-MC-Unique: D3EtbukcMmmsDdTXr4sEoQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dr+TRpfk4o0VRBLn7dqyOqYSgWK5dlqBePRTd/kQHqyBZ0eVd0W+E4itRyfgcBoKNyTZ7TXgbZE2VTm1AKkvxiqBkiQp82Mef+9O+2lrYKcQGNNgpsc7H4/R9WGQPcC/KmLbv8XwdAwV1szp8NThB+TNmzaJa+6ZX0ABfyKBAlwjCg+CC0YuMQOrf7VbDRUEc2SfsIee3Ute+oUxCozmbM/dXW51MQwJFA2zcTfLzgMqUPcONH4OzslF+tFLGXpLsn27daMqEXGEE4xGlDATPoIBb11a0u/czQPivCucVG+j3bLznaBfFjIHWJFHp7DVjrv/T6nDuc6Z6XaR7PFayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+7/WrkTa+pkAfbx4Jft+s4DtAVkSGAzAFhBNOuODXg=; b=Rj3rbBskq4oO8QexP0S9uWnEBkP7m3nhf785t3clb4NP1A24UX9se1GNQyRTww0Y42haM+TkzfmMocWYYNmAWsw0KalVUyZC22Y1Khn3QLXjsjRbC6b0vmgIQma534iCju3iyx+cZcNyneBztpegGXNeNiIein4Zq+JGvgSZujg8o4BP0LMeOQvcgtcNK8ot9tzprRd/3gRdU8l0gNTwS4f+a3Wu7uKlUd5EWhOUIstE1fEI172capu15RW1luoPA1+s0nHDx2wZkMgNCtUVQODG6VSUXi/PUditRmE/qMpziouoXb8nLy06Xhe7UOgV69Ps6xxmhqsV3yZHeKVorQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2b304872-a407-be04-22d3-2ebb88040036@suse.com> Date: Thu, 5 May 2022 09:42:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/6] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220428030127.998670-1-Penny.Zheng@arm.com> <5de2f283-f6fc-95e7-808c-4f3d96b25926@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::6) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07a4be58-f0f4-49d0-19d3-08da2e6ac9dc X-MS-TrafficTypeDiagnostic: AM0PR04MB4292:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T8s9PoSWXXxy0LzlZ5UsFRa33hWVMZMwx07oBBhyKzyLUIfgnHqcTEdF7Y6ivuOv42MMuCUT5O4TRQNoVFDVR2ifIGZXaGn480ky2qno3qTQp3rx959WrY3lAi19lmoMptjaUiejNcQ5DfEv8HrlgO2VA1cn4ehdrFdP8rQpGZAef81lKPsZNeLomJQq+4Go540s7MaGvFxVVn1q+Vo5dMOhGAUa2v45HU5/One+OlFAkC0U6RZJ4gayb0qGUT4xq6uqu+BKG+YNlHP8b2Zg3hu+C+V51tEa32hzOMrUde65xyYP/dakXC2VnFfQsQqTzxt0ZN/B0jZfQnnuStdM1STlvbvoibcULy/FEqJ7hnrordr5X7BEmeK/hnRxnxrHm50BvLksENPthkAWln5fOErbg+aDcKw/jy4lxKdhnpi5qbl4jnNSNn6CnfgdiL9GXrZ/xPuBDBy4Iw9rd3m0WqU02eRqgoCU3ctdrZcNcJGNk+RFqGow0gSap5PHIxUc67aRDCuTjBOl1V4x4RJ0cNbXJfpSNHo6YFPY1ASTYNmwQeSnjsi+utKUrjhYwz22I5Rc6Z9NDKOHRN4dV1+SQGLBmcn7VtnRiQ0/CzyBjMVznATRpV/sRBlt5aXELTPMNvXLs9Mxt+IZiPhBi04t7asz4gG/l7ZlIfAQa4kYbg2LyXF3eOVehjDuQ9t6LkT7wBy6YAZ48kx47LlIoWBjYQ1nx/LPToLEbYg+wMAQ3/YtgoBeBdwo4EixXEd7QgJe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(36756003)(186003)(2906002)(8936002)(38100700002)(86362001)(31696002)(31686004)(5660300002)(54906003)(4326008)(83380400001)(8676002)(66476007)(66556008)(66946007)(6486002)(26005)(6512007)(53546011)(2616005)(6506007)(508600001)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L09QM003ZW1NWCtrV29HaDJUa3dKTE5XYWtzUFl6enFYb2x3OW9NQWlHS21l?= =?utf-8?B?VHphSUFoZzdHNStSNDZaWVBtUHBMVThiT2F4VTJoN2VHTWtUNXNuUm9qNktF?= =?utf-8?B?cVI4dWxjMmNORWh3QzMySytlWklKL05BMnhvYjFvSElWOWY1Z2lLVm1lRzhn?= =?utf-8?B?RWRORDh0cUZ1SU1FZENLUVVBa3BLQ3RDeURlUTR6OVBVRkw2bC9JQjk1MHh2?= =?utf-8?B?UlZFTUh0ZXlzWE5CZ3hieW5OWnp3VXdkeFlraGM3ejNLQ3dZbEh3bjNEUmRO?= =?utf-8?B?bkwvYUVoRnlvOVRJQmw1dmFQS01mcDZkcldUMHBWcVhmOXNwcEU0U25TS0kz?= =?utf-8?B?SGQ0WEJxcHB3NGRCUGxJc1JKdGZZWWNVRXRCY2tnTHNNLzBUTCtmbHRIYUg3?= =?utf-8?B?Vm9CMTZXQkRhWE9iSTFtTCtncmtJU2FmVXdoRHNnRVdzVytjVFpsWVJPMjhv?= =?utf-8?B?eUw1QzNYdXNZb1ZtenhsVVRyTnVxRlk2WG5jM2ZhY1hxRXNNWHRjczAwL2tM?= =?utf-8?B?aU5kNjU1dWUzTTFvNnU2MDFSU1pmWVBXWmljMGRUYlhDVVg2a3ZVZlo1dnpD?= =?utf-8?B?aEZSb1lGVldiL1l3QXNSZjhoQWxDWnRjWlBGQkxvUXJmc0pKQjVSNURGMGJ3?= =?utf-8?B?STkzSHhoTjVrZzM4eTZCdEZSV2NqeU9UV1ZQMW1PcTZqVzV6dmFQRUorVkhm?= =?utf-8?B?bTBTaExJV0FDcm1DM1c3TnJ3bUFOUjRqWGVXVjlvczZlVEN2a1F6TFFKZ1hR?= =?utf-8?B?YlJBdVZmKzFQaUF6elpIVjcyRzdNc2lCL1BRM1hIcEQ3NTZKcnJScFpqeWIv?= =?utf-8?B?aGR6d3dYUzIzcC9XZm5FeWplTUNIdXRXM09wZHhoVFFCUVBhM1dRQ3hFQVh3?= =?utf-8?B?UUtYQWZmY2NvNVBKV1dyd2dHb29KdGU5cGZ3TWwxUm1nYVZCaisxVUVDQkx3?= =?utf-8?B?VnBYaWNwQk9qcGZyR3pNVGU4Z0VsUG9pVHlYMFRCNzdBbWpScHJzYVBlUTN2?= =?utf-8?B?azg0VXR0b3pYUTUzd1AvUUlOc0tiWVBNN0lvWlErc2xYUzVKdXFxby9waTRy?= =?utf-8?B?N0krd1NlOWlBc1FPUEYxdGp0VGliZTNwOEJMZkl5Mmxkb1Myck5ITTJxaVZT?= =?utf-8?B?Yk1CMVNjV09iYVhNckRyN2ZVZjhNUUpXQUhza0dzRld3OWhOTVZvZ0FLNUFv?= =?utf-8?B?ejlzMlBwMUtyc3VRcEowb3JOT1NTNWxVaXdqUlVUcWROTXVyTE1FRm5aWlo1?= =?utf-8?B?ZUhCUFFTZzd1NFhkT1RObTJ4RUhuZGhvQlBwOVRIYzh5WXhKb25hMEVVdjhr?= =?utf-8?B?SWlBWVd2NGVKMFJSMGZ1K1ozSW8wcURld0FoUVdiWm1sSkJzTmc2N3hXWmsr?= =?utf-8?B?VXU3WHdpYmEwYTB6cHl2L3VqbjRjazVFenMxK01tVWdLWmhPUzBCY1Z3MWs1?= =?utf-8?B?Ritaa29sTmpTVlhBN241Tjl1Vk13cVl2dkVka1d0Vk8rYzZIS0wyL1h4bEU1?= =?utf-8?B?ckZpcS9xalB6Ymc4dTVYYWRTS0JiTjNXaTRTRE45dzNieHZFZC9VRUgrMzZW?= =?utf-8?B?NEs3SXR6TndEVTNIaHlUV3lkdkFaVVlkcnYzK0xKZEF3Zko0VkpvbDBjWi9n?= =?utf-8?B?ZFIxZTdhR0VnekhYTTZXcExsQWVLRHNPclVLbEErVEVYRlhCaERsWWUwR3dw?= =?utf-8?B?UU5aYXBsb29YanJMaGRNdmNCNDdWdk9xVzloZndNb2MzUG5mYVRmTVIwa3Rw?= =?utf-8?B?TXFRZjBHMzJlL2Z2b0lRZ28rSGtqa1Fhc2JYL1pPM0tOcjFMZHZJWmVxeGVW?= =?utf-8?B?RHBJRnovTlpjV2I5dThialNIZ0FXU3pwclFndEJLWlhaSUxKMXUwVHpsdFVz?= =?utf-8?B?ZFVUV21ldS9mR3hsQ3g0YXhla2ZuSDNUVHZvUU9EWWF1MldMVDk4bkRXYUpP?= =?utf-8?B?cFlSSG1YNUlnV0lUQ3hVZi9xMG4xUjI4clE1TjVCeUpSS2lhTlEwRE9mQjJa?= =?utf-8?B?d2tDUzZzd2pDQ3JneHBZZUpLSU1yQm9aNVRsZnVUN2hkci8rUCtKdHFBN3Ny?= =?utf-8?B?eXJ2TFJES2k1NytYeVlaQzFsSlpQbDdmSnFVaEx5dXNOaG4zWXowVDZ0U0ZP?= =?utf-8?B?bVlHNlRyWElidFM1bEkxSUFveXhmdzhDY0o4U1hCYjZDWWZsWkdyTytETWE0?= =?utf-8?B?VDBZczA0UjJGYlFwM3Q4WFhtZ2hScFJGRitkYmdQNFJLUUEyejVyRndFSmw3?= =?utf-8?B?RnFSMUFiZ0NXTmgzRDk3OUJveWo3dExhQjAySUwvMDVYZkZpbHNFQ2x4L3g1?= =?utf-8?B?MXI3NFBVRGh0ZlFEWUczdStWanFKajJza1pzM1dPQ0ExaFpCTUFVQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07a4be58-f0f4-49d0-19d3-08da2e6ac9dc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:42:21.6119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jtdych3LOnNsPSML2te129qUYlPd2vRBdFYETKfGrbnuYlaMnu5iACznyxDjGgwWOO53/aQ+MTFhtvHSwj0Szw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4292 On 05.05.2022 07:12, Penny Zheng wrote: > Hi jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, May 4, 2022 9:27 PM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; Wei >> Liu ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v3 1/6] xen: do not free reserved memory into heap >> >> On 28.04.2022 05:01, Penny Zheng wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -1443,6 +1443,10 @@ static void free_heap_pages( >>> >>> ASSERT(order <= MAX_ORDER); >>> >>> + if ( pg->count_info & PGC_reserved ) >>> + /* Reserved page shall not go back to the heap. */ >>> + return free_staticmem_pages(pg, 1UL << order, need_scrub); >> >> With PGC_reserved being zero, the compiler should CSE this call. Hence ... >> > > I assume that you suggest that we remove the stub function and just let > free_staticmem_pages not guarded by CONFIG_STATIC_MEMORY any more? No, I' not suggesting to remove the existing guard. I'm only suggesting to avoid introducing a stub when that's not really needed. > Hmmmm, on x86, PGC_reserved will be zero as not defined, and CSE will leave > no caller here. but on arm, CSE could not guard this? Why would that be? When !CONFIG_STATIC_MEMORY, I'd expect PGC_reserved to be zero on Arm as well. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 07:46:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:46:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321618.542658 (Exim 4.92) (envelope-from ) id 1nmWC9-0004c1-Rq; Thu, 05 May 2022 07:46:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321618.542658; Thu, 05 May 2022 07:46:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWC9-0004bu-PF; Thu, 05 May 2022 07:46:41 +0000 Received: by outflank-mailman (input) for mailman id 321618; Thu, 05 May 2022 07:46:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWC7-0004bo-Rb for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:46:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f00abef-cc47-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 09:46:38 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-RFj3uAbuM_O6JaWwrjvLaQ-1; Thu, 05 May 2022 09:46:37 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5573.eurprd04.prod.outlook.com (2603:10a6:20b:94::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 07:46:35 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 07:46:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f00abef-cc47-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651736798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=59XdpUfHVbilsEhtfR5JO0+5vwDqmAsmmdN1OvKCsKc=; b=OW7kTQ4mcip2pqB+EE6opvNxCzeNa1v+p/DshNhE+QsCJjoySyzVWw1BZURbHJcqCMKLPa 7sf2H80lR9CC/L1AURuseBvncsm9tG5LTWXhjqEwiWfW1PFGuCs7+TNVHr2fWvXcj3AUr0 f5jLMc+sT/oerGIZhXJJojyt8EqCJV8= X-MC-Unique: RFj3uAbuM_O6JaWwrjvLaQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIwbPdvDXnVPnoBHj6k08AO8oR52B0pOrD4tELDaraa75/FCEBFPz7kPMy/9BVg60yk43uyOvNbam6qrTVKTSp+ulCRPdxgB/JqjAkU35k3sPx5vnw/3Tl/0f3sUzl9jb6Zo/hkTjxqAT3TWxtGonVHiyFpEeBYKv1Yp6JZeuJ/sSGFn7cWHV+kkU3NeX2t9T7w1ac3nX9efdD/3jBxuObfaF+0ydkSX95kqG2BTh0uw5RFNRl/rfJjsBJvyxYCRvxKf0UM0rlQwKqDNlvYCGL2BGiNbSpXZD/cjgyurKdEuLLIKlE0C4sEUv/AMEMlvulX+Jgypslc1mRQNPnUOsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59XdpUfHVbilsEhtfR5JO0+5vwDqmAsmmdN1OvKCsKc=; b=Vx3hnxL5ZWB1fyKeyglyrI2cM78xPJXpNFhvmg57Gn6SIGWu2MCktBteKFasDfwfrJTC26H4zyFgrOG6JI/34qct0m8yOKIiNWuBT1mXy7RHt5Ui7P07LXZ3n7aH8gng6uJO6U6p08qF5pg6/dxh8PaPMySoRG1V69o6baxSLqYdshG1Qrd5upSMkqrETjMKHanQJu48nYgIOu6cMIz5W/Z8m9ehOPNV4yScS3Y/udvAz0TjOgWdIjpet+yH5erGXBukh+nT80IfL95GS93M5qore488rl+dZhfK9Jl5MY1qWDn/q5BaR6+B9X4SkVKGxwTYznaoDGFl2Y4d2eqbIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 May 2022 09:46:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0003.eurprd05.prod.outlook.com (2603:10a6:20b:488::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d864930b-c334-4cad-0770-08da2e6b60fb X-MS-TrafficTypeDiagnostic: AM6PR04MB5573:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GYnpfA4pAjD75PDO0yoXutbuJDi79KjLda8M5tDjoycOqlMQALKdtpon4jZxY9z6vb+LEeUCpRI/qNed2a5CupUk43TAUlmvBEvFcoHtqzk2dhl2QiZ+rEjzG/m/TNOlrkGj9v+cDHHh2tMscMO8adCBx0EMzW8GDMAy5DRQhGaZZVfht5ihBaTxk3UW8IoCAdPPYxq+WbjyLAprCehAstd/UV/x5wWQJW7HJXNxdUaxec3sxZNuTCr/vZxzuExCRGjmvrLjoyxVqRKXXS+G0EsX3d3KStW4RrYO0QZk11XY1FX6Iz6XqJLz4/tljLDpVu9yBTfO7CoX3tn/NulnbHCedylawRlCIPS+rSogORRfmUuEGGOM/Dg0p3e/D3VP3aY9N6Qb+laD30X6eyFGKffEX5o+4+IMeaWZ3vkcE2e1b/qackbRUzEONzw1stWmoJFWGN+mIhxFwvfQGFoEcfV+zjI+gIQC7F5qZSPYrEEU+a9DA3E2JN9IPnP9BO/jh+z0QzXO74JWQV+Tv7nlEk8taH3VwzFn3d09LRys+up/J1DIM0gSA0o897KKcyqSbZ9pRNL9Ww3bUEX2txJGG7HcQ4si7Omct0msow+T1HC+9Q3a55f5hlSdN8rvKPGiKWBzBhMgGHG11BPbpG21HmcxdExqBQDvrQEK9NTHuSLpXzaVW5JO/RWi5EjdiEy3ZBe+SV0p50/AYx85iE4F0uIZtvdosD/WNsXcMqBUfjo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(26005)(6512007)(8936002)(31696002)(86362001)(31686004)(186003)(2616005)(2906002)(83380400001)(36756003)(8676002)(4326008)(66946007)(508600001)(6486002)(66556008)(66476007)(5660300002)(54906003)(6916009)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUpPR2syKzNUSmgzYlJWUXYreDIxMW9yb2xSbW1FYm9Nc1JVWENySzFaQ2o1?= =?utf-8?B?dHMxeDJueEtkQ0Vhc2tXZXQrVlcvd2RPWnVLdUQxNHFXZmFSWE1uV014c211?= =?utf-8?B?bWtKY1BpV2ZUUGZTL2tHNFdSSkJYd0xyeTVxbnZuTXdNdnU4ckRFdWVEc3FC?= =?utf-8?B?azJUUytYVGFudXVoT0gxcWR3OC9YdmNTQWdtSmhVNTZtZ1NvYkhub0xzRjBJ?= =?utf-8?B?aGlnemVuY3FiNVJ6dXRCMDNkNlhzT0dySGxOUkdWMzRRbGttVCtWazJiTzZB?= =?utf-8?B?ZnpkbWZUWUVKTlBpVXlKL0dWRkhyM3F0U1B3SGJPdjRCSGFmdW5TakVFVEt4?= =?utf-8?B?bXVJUG9FTUlTY0YxL1ZuampVM29yUzdFR1ZTVmIzbDZnaWt5REpSekxlZnRK?= =?utf-8?B?ZjRON2RKbldPV1NqREF6QTRlY2k3YjdRdXdrTzY5TnFTdk9JYUdxSjUyRkkv?= =?utf-8?B?Y1ZSMXI5M2tVQTE0OXEyTk0ycVpsZDJsc2YwQUtZY0p6cTFodzNpaXR2RnI1?= =?utf-8?B?OEl1OTduaHZCUndqN09KVGFaZGNVTEhmd1NFUjUvSFFiU2RscFRTbFE0WGpB?= =?utf-8?B?bmMzMkxHbHJFS3NVQ3ZwU0EwVWRKd0pWcS8xMlVWSXg5c2hkdExMendZUysx?= =?utf-8?B?RG45NmgzSE5iMGNYZnBseWRwTjNoRlpzc3ByT0pHWWpPQ1M1Y3RYd1NjMEJl?= =?utf-8?B?SzJwbFJuanZ6eitkaDd6QXJaU0hmWFluU21uYWxHaTI4blpRWkdxZFRBbXBj?= =?utf-8?B?aXhrc1I5a3pPT2FrTVNDMlZZWVdqaFFSSWpKV1lVMTBWRHFMUHZLd1ZubGVl?= =?utf-8?B?T0UydS9LekJ0SEMzR2wxMDBFaVJzYlNhOFkvWVhyMURqSW16ZFo1Q3ErdjZ0?= =?utf-8?B?eE96d28vMXQ2aERhSHJqd3ZTTXRoNktLcXBFanp1SkhKSzZnNlV6aG00U25N?= =?utf-8?B?SDUxMXRDc2NZWmY1U3RnWGFQSkRoUS9ydERaY29zd0NwM0gvdU95UndaYXZt?= =?utf-8?B?akVCNDBpRkswdlIvbFlub0hsMnlyUEh6dlBtRTJNWTRTOWRXZ0pMc0ltTy8y?= =?utf-8?B?REpFZ0hsWUpCTUV6OEdTWjRlUDVvRUttenlUTjFEaTdNTGdkb0crRzh4UHh4?= =?utf-8?B?cUMrNnNMZFZMQ1FOVzVhN2ZYbitIdWd6STVmcnR3d2dOeGxSalFjdzZHSlNL?= =?utf-8?B?TkdkVVJTR013ZU9SMVREOFZZc2pKTGcyTUxGcVNQQThnZTVIWFF4RWh0ZEx0?= =?utf-8?B?d2VreWFDQWZSYUpVVndTNzZMQmgwWERhQWNEVHp6ZGsvVXhjRXQxbmpQTDcw?= =?utf-8?B?bi9qUHFZck95Z0lBZVN1NmFOYlRZVUpZd0Q1Y29ka3pBRk9EVEVXeldOcjBE?= =?utf-8?B?UkNTSVYvOHhraEhnNlMxTXVlNE1aWXNnOThjN0RNQStoMUFHVVBlR0JBVUpo?= =?utf-8?B?aEM4RGxmcjZpMk1wbEVxVjRDOXhVeng3VCtlRE1kL0s0Wi8vL0k2QWIzRTFJ?= =?utf-8?B?UU83b2xhekhtTU8yUUxYQ3pXcE9PLzJXL250MU1TNllkMGJGV2N2SzgzWTl0?= =?utf-8?B?UjZRRVBxM1pid1grY0FBMlZnWm9OQTlFWEtuMzFFTUFtc0VvQ21mZ1RFcVVJ?= =?utf-8?B?UjdjY0tzVE1ld1ExZVU4MWR1MHdud2pZS3p5QlpCcmpVRnV4clNOWlFRR1hs?= =?utf-8?B?Ullid01EOExYSHFzMXhDN2pYRUdaaDFCS2pBdHBYSW5SaDZua2JsakNRRFVC?= =?utf-8?B?SG8velpSM0RRYlR5V205QzU0ZFNsam1OSWRFcno4elduRS9vVkhuR0didThJ?= =?utf-8?B?aUU1SDFrc0FuVEVMdGNrYVNCQzFOZWpwclRxNUUzVUtOZll6UFZSTUJYT1NW?= =?utf-8?B?U1pNd2ZoQytlaldCSmhEem5LbHhYZERWUlRLT3RxYk1qN0dUQlEzSE5ibzNm?= =?utf-8?B?cDhXSkl5TXR3Nlgrb1BnQm9YcVFTdmdWMGVROXpGd21hcTcxMTBsK3JQT3RP?= =?utf-8?B?VitXNU4zK0pvWE1GNndmblkySEFxVzloeU9HQ2w2NEUyUVVxeER4S3hXTHk0?= =?utf-8?B?Y3lPMlVtOHVZenNlTEZoTFI2MitRNllNWWh0YnhyU2VVOFYrbFNBK29ZQVpQ?= =?utf-8?B?L3QraVNaRS9GcnRlaHRVTUNUTytIYVpOVUhmb1poalB6R2l3ek1scmhSMmF5?= =?utf-8?B?SnRmeGQ5VVREUi9wc3V4cnVsNWZNelVkQ3YyeGpJd2ZrRldMU2RsMGNCRzYw?= =?utf-8?B?Y1BaY3hCNTVBK1I5QnB2VE9IRVp2M0xuWXVXMXE4aTNXTVZMdDdvR0ZBRG5Z?= =?utf-8?B?aGRZamtGZzRxODl4Y3lDYS9aN0RJRnhZNFA5dHVveUJsSEFBRldyZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d864930b-c334-4cad-0770-08da2e6b60fb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 07:46:35.1038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d9023CrxCsPZeXe5v6bWpl+0twGWcBsRYnol4Urrywi6ck11YGnlhhenV6oyn61FnJ2mO5JzIGzlYlxNX5w40A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5573 On 05.05.2022 08:24, Penny Zheng wrote: >> From: Jan Beulich >> Sent: Wednesday, May 4, 2022 9:45 PM >> >> On 27.04.2022 11:27, Penny Zheng wrote: >>> #else >>> void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, >>> bool need_scrub) { >>> ASSERT_UNREACHABLE(); >>> } >>> + >>> +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, >>> + unsigned int nr_mfns, unsigned int >>> +memflags) { >>> + ASSERT_UNREACHABLE(); >>> +} >> >> I can't spot a caller of this one outside of suitable #ifdef. Also the __init here >> looks wrong and you look to have missed dropping it from the real function. >> >>> +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) >>> +{ >>> + ASSERT_UNREACHABLE(); >>> +} >>> #endif >> >> For this one I'd again expect CSE to leave no callers, just like in the earlier >> patch. Or am I overlooking anything? >> > > In acquire_reserved_page, I've use a few CONFIG_STATIC_MEMORY-only variables, like > d->resv_page_list, so I'd expect to let acquire_reserved_page guarded by CONFIG_STATIC_MEMORY > too and provide the stub function here to avoid compilation error when !CONFIG_STATIC_MEMORY. A compilation error should only result if there's no declaration of the function. I didn't suggest to remove that. A missing definition would only be noticed when linking, but CSE should result in no reference to the function in the first place. Just like was suggested for the earlier patch. And as opposed to the call site optimization the compiler can do, with -ffunction-sections there's no way for the linker to eliminate the dead stub function. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 07:47:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:47:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321624.542669 (Exim 4.92) (envelope-from ) id 1nmWCs-00059p-4N; Thu, 05 May 2022 07:47:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321624.542669; Thu, 05 May 2022 07:47:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWCs-00059i-1j; Thu, 05 May 2022 07:47:26 +0000 Received: by outflank-mailman (input) for mailman id 321624; Thu, 05 May 2022 07:47:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWCq-000599-GN for xen-devel@lists.xenproject.org; Thu, 05 May 2022 07:47:24 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9969fdb2-cc47-11ec-a406-831a346695d4; Thu, 05 May 2022 09:47:23 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C55731F37F; Thu, 5 May 2022 07:47:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7296113A65; Thu, 5 May 2022 07:47:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5XFmGgqBc2L1eAAAMHmgww (envelope-from ); Thu, 05 May 2022 07:47:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9969fdb2-cc47-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651736842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jrMLaSSMN7He6cdt5XTC24vdCcm0PNlp2WLIgEZGGtw=; b=W/9jPLvfsgNRfw6eZlORSnjLaAYSd6NMKn3O6c7oXrOwqYm55zVail8bEKB/IivsU5vK3q bjTpS4cI89ZnnDrPfpdE5hTli4NNlseVpMoYQo4MpVJ+nffC5hwEL5dJE3yVMvUJLYBJj6 yRY5scMTvfSp7VjnX5tlE8xqU4CAFbQ= Message-ID: <04d6f32d-56a9-f6b2-96d0-3087328769ae@suse.com> Date: Thu, 5 May 2022 09:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20220505001656.395419-6-sstabellini@kernel.org> From: Juergen Gross Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <20220505001656.395419-6-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4mWKd07QHnHr3dhk0IlKHrlg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4mWKd07QHnHr3dhk0IlKHrlg Content-Type: multipart/mixed; boundary="------------cu0C6z0LauKjwjyF8Th10B27"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Message-ID: <04d6f32d-56a9-f6b2-96d0-3087328769ae@suse.com> Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers References: <20220505001656.395419-6-sstabellini@kernel.org> In-Reply-To: <20220505001656.395419-6-sstabellini@kernel.org> --------------cu0C6z0LauKjwjyF8Th10B27 Content-Type: multipart/mixed; boundary="------------i1Emc5yTRg3B0mB33G9lSzqI" --------------i1Emc5yTRg3B0mB33G9lSzqI Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDUuMjIgMDI6MTYsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBBZGQgYW4gZXhhbXBs ZSBhcHBsaWNhdGlvbiB0aGF0IGNhbiBiZSBydW4gaW4gZG9tMCB0byBjb21wbGV0ZSB0aGUN Cj4gZG9tMGxlc3MgZG9tYWlucyBpbml0aWFsaXphdGlvbiBzbyB0aGF0IHRoZXkgY2FuIGdl dCBhY2Nlc3MgdG8geGVuc3RvcmUNCj4gYW5kIHVzZSBQViBkcml2ZXJzLg0KPiANCj4gVGhl IGFwcGxpY2F0aW9uIHNldHMgImNvbm5lY3Rpb24iIHRvIFhFTlNUT1JFX1JFQ09OTkVDVCBv biB0aGUgeGVuc3RvcmUNCj4gcGFnZSBiZWZvcmUgY2FsbGluZyB4c19pbnRyb2R1Y2VfZG9t YWluIHRvIHNpZ25hbCB0aGF0IHRoZSBjb25uZWN0aW9uIGlzDQo+IG5vdCByZWFkeSB5ZXQg dG8gYmUgdXNlZC4gWEVOU1RPUkVfUkVDT05ORUNUIGlzIHJlc2V0IHNvb24gYWZ0ZXIgYnkN Cj4geGVuc3RvcmVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVjYSBNaWNjaW8gPGx1Y21p Y2Npb0BnbWFpbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8 c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+DQo+IENDOiBXZWkgTGl1IDx3bEB4ZW4u b3JnPg0KPiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+ DQo+IENDOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IC0tLQ0KPiBDaGFu Z2VzIGluIHY2Og0KPiAtIGluY2x1ZGUgeHNfd2lyZS5oIGFuZCB1c2UgaXRzIGRlZmluaXRp b25zDQo+IA0KPiBDaGFuZ2VzIGluIHY1Og0KPiAtIHNldCBYU19DT05ORUNUSU9OX1NUQVRF X1JFQ09OTkVDVElORyBiZWZvcmUgeHNfaW50cm9kdWNlX2RvbWFpbg0KPiANCj4gQ2hhbmdl cyBpbiB2NDoNCj4gLSBvbmx5IGFsbG9jIHhzIHBhZ2UgKG5vIG90aGVyIG1hZ2ljIHBhZ2Vz KQ0KPiAtIGFkZCB4ZW5zdG9yZSBwZXJtaXNzaW9ucw0KPiAtIGNoZWNrIGFsbCByZXR1cm4g dmFsdWVzDQo+IC0gcmVuYW1lIHJlc3RvcmVfeGVuc3RvcmUgdG8gY3JlYXRlX3hlbnN0b3Jl DQo+IC0gc2V0IHRhcmdldF9tZW1rYg0KPiAtIHNldCBzdGFydF90aW1lIHByb3Blcmx5DQo+ IC0gY2xvc2UgeHMgdHJhbnNhY3Rpb24gb24gZXJyb3INCj4gLSBjYWxsIHhjX2RvbV9nbnR0 YWJfc2VlZCBpbnN0ZWFkIG9mIHhjX2RvbV9nbnR0YWJfaW5pdA0KPiAtIHhzX29wZW4gaW5z dGVhZCBvZiB4c19kYWVtb25fb3Blbg0KPiANCj4gQ2hhbmdlcyBpbiB2MzoNCj4gLSBoYW5k bGUgeGVuc3RvcmUgZXJyb3JzDQo+IC0gYWRkIGFuIGluLWNvZGUgY29tbWVudCBhYm91dCB4 ZW5zdG9yZSBlbnRyaWVzDQo+IC0gbGVzcyB2ZXJib3NlIG91dHB1dA0KPiAtIGNsZWFuLXVw IGVycm9yIHBhdGggaW4gbWFpbg0KPiANCj4gQ2hhbmdlcyBpbiB2MjoNCj4gLSBkbyBub3Qg c2V0IEhWTV9QQVJBTV9TVE9SRV9FVlRDSE4gdHdpY2UNCj4gLSByZW5hbWUgcmVzdG9yZV94 ZW5zdG9yZSB0byBjcmVhdGVfeGVuc3RvcmUNCj4gLSBpbmNyZWFzZSBtYXhtZW0NCj4gDQo+ IGNvbm5lY3Rpb24gcmVjb25uZWN0aW5nDQo+IC0tLQ0KPiAgIHRvb2xzL2hlbHBlcnMvTWFr ZWZpbGUgICAgICAgIHwgIDEzICsrDQo+ICAgdG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNz LmMgfCAzNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiAgIDIgZmls ZXMgY2hhbmdlZCwgMzUzIGluc2VydGlvbnMoKykNCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQg dG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMNCj4gDQo+IGRpZmYgLS1naXQgYS90b29s cy9oZWxwZXJzL01ha2VmaWxlIGIvdG9vbHMvaGVscGVycy9NYWtlZmlsZQ0KPiBpbmRleCA3 ZjZjNDIyNDQwLi44ZDc4YWIxZTkwIDEwMDY0NA0KPiAtLS0gYS90b29scy9oZWxwZXJzL01h a2VmaWxlDQo+ICsrKyBiL3Rvb2xzL2hlbHBlcnMvTWFrZWZpbGUNCj4gQEAgLTEwLDYgKzEw LDkgQEAgaWZlcSAoJChDT05GSUdfTGludXgpLHkpDQo+ICAgaWZlcSAoJChDT05GSUdfWDg2 KSx5KQ0KPiAgIFBST0dTICs9IGluaXQteGVuc3RvcmUtZG9tYWluDQo+ICAgZW5kaWYNCj4g K2lmZXEgKCQoQ09ORklHX0FSTSkseSkNCj4gK1BST0dTICs9IGluaXQtZG9tMGxlc3MNCj4g K2VuZGlmDQo+ICAgZW5kaWYNCj4gICANCj4gICBYRU5fSU5JVF9ET00wX09CSlMgPSB4ZW4t aW5pdC1kb20wLm8gaW5pdC1kb20tanNvbi5vDQo+IEBAIC0yNiw2ICsyOSwxMyBAQCAkKElO SVRfWEVOU1RPUkVfRE9NQUlOX09CSlMpOiBDRkxBR1MgKz0gJChDRkxBR1NfbGlieGVuc3Rv cmUpDQo+ICAgJChJTklUX1hFTlNUT1JFX0RPTUFJTl9PQkpTKTogQ0ZMQUdTICs9ICQoQ0ZM QUdTX2xpYnhlbmxpZ2h0KQ0KPiAgICQoSU5JVF9YRU5TVE9SRV9ET01BSU5fT0JKUyk6IENG TEFHUyArPSAtaW5jbHVkZSAkKFhFTl9ST09UKS90b29scy9jb25maWcuaA0KPiAgIA0KPiAr SU5JVF9ET00wTEVTU19PQkpTID0gaW5pdC1kb20wbGVzcy5vIGluaXQtZG9tLWpzb24ubw0K PiArJChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1MgKz0gJChDRkxBR1NfbGlieGVudG9v bGxvZykNCj4gKyQoSU5JVF9ET00wTEVTU19PQkpTKTogQ0ZMQUdTICs9ICQoQ0ZMQUdTX2xp YnhlbnN0b3JlKQ0KPiArJChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1MgKz0gJChDRkxB R1NfbGlieGVubGlnaHQpDQo+ICskKElOSVRfRE9NMExFU1NfT0JKUyk6IENGTEFHUyArPSAk KENGTEFHU19saWJ4ZW5jdHJsKQ0KPiArJChJTklUX0RPTTBMRVNTX09CSlMpOiBDRkxBR1Mg Kz0gJChDRkxBR1NfbGlieGVuZXZ0Y2huKQ0KPiArDQo+ICAgLlBIT05ZOiBhbGwNCj4gICBh bGw6ICQoUFJPR1MpDQo+ICAgDQo+IEBAIC0zNSw2ICs0NSw5IEBAIHhlbi1pbml0LWRvbTA6 ICQoWEVOX0lOSVRfRE9NMF9PQkpTKQ0KPiAgIGluaXQteGVuc3RvcmUtZG9tYWluOiAkKElO SVRfWEVOU1RPUkVfRE9NQUlOX09CSlMpDQo+ICAgCSQoQ0MpICQoTERGTEFHUykgLW8gJEAg JChJTklUX1hFTlNUT1JFX0RPTUFJTl9PQkpTKSAkKExETElCU19saWJ4ZW50b29sbG9nKSAk KExETElCU19saWJ4ZW5zdG9yZSkgJChMRExJQlNfbGlieGVuY3RybCkgJChMRExJQlNfbGli eGVuZ3Vlc3QpICQoTERMSUJTX2xpYnhlbmxpZ2h0KSAkKEFQUEVORF9MREZMQUdTKQ0KPiAg IA0KPiAraW5pdC1kb20wbGVzczogJChJTklUX0RPTTBMRVNTX09CSlMpDQo+ICsJJChDQykg JChMREZMQUdTKSAtbyAkQCAkKElOSVRfRE9NMExFU1NfT0JKUykgJChMRExJQlNfbGlieGVu Y3RybCkgJChMRExJQlNfbGlieGVuZXZ0Y2huKSAkKExETElCU19saWJ4ZW50b29sbG9nKSAk KExETElCU19saWJ4ZW5zdG9yZSkgJChMRExJQlNfbGlieGVubGlnaHQpICQoTERMSUJTX2xp Ynhlbmd1ZXN0KSAkKExETElCU19saWJ4ZW5mb3JlaWdubWVtb3J5KSAkKEFQUEVORF9MREZM QUdTKQ0KPiArDQo+ICAgLlBIT05ZOiBpbnN0YWxsDQo+ICAgaW5zdGFsbDogYWxsDQo+ICAg CSQoSU5TVEFMTF9ESVIpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KPiBkaWZmIC0tZ2l0 IGEvdG9vbHMvaGVscGVycy9pbml0LWRvbTBsZXNzLmMgYi90b29scy9oZWxwZXJzL2luaXQt ZG9tMGxlc3MuYw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAw Li5iZmQ1ZmYwNzYxDQo+IC0tLSAvZGV2L251bGwNCj4gKysrIGIvdG9vbHMvaGVscGVycy9p bml0LWRvbTBsZXNzLmMNCj4gQEAgLTAsMCArMSwzNDAgQEANCj4gKyNpbmNsdWRlIDxzdGRi b29sLmg+DQo+ICsjaW5jbHVkZSA8c3lzbG9nLmg+DQo+ICsjaW5jbHVkZSA8c3RkaW8uaD4N Cj4gKyNpbmNsdWRlIDxlcnIuaD4NCj4gKyNpbmNsdWRlIDxzdGRsaWIuaD4NCj4gKyNpbmNs dWRlIDxzeXMvdGltZS5oPg0KPiArI2luY2x1ZGUgPHhlbnN0b3JlLmg+DQo+ICsjaW5jbHVk ZSA8eGVuY3RybC5oPg0KPiArI2luY2x1ZGUgPHhlbmd1ZXN0Lmg+DQo+ICsjaW5jbHVkZSA8 bGlieGwuaD4NCj4gKyNpbmNsdWRlIDx4ZW5ldnRjaG4uaD4NCj4gKyNpbmNsdWRlIDx4ZW5m b3JlaWdubWVtb3J5Lmg+DQo+ICsjaW5jbHVkZSA8eGVuL2lvL3hzX3dpcmUuaD4NCj4gKw0K PiArI2luY2x1ZGUgImluaXQtZG9tLWpzb24uaCINCj4gKw0KPiArI2RlZmluZSBYRU5TVE9S RV9QRk5fT0ZGU0VUIDENCj4gKyNkZWZpbmUgU1RSX01BWF9MRU5HVEggNjQNCj4gKw0KPiAr c3RhdGljIGludCBhbGxvY194c19wYWdlKHN0cnVjdCB4Y19pbnRlcmZhY2VfY29yZSAqeGNo LA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWluZm8gKmluZm8sDQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgKnhlbnN0b3JlX3BmbikNCj4g K3sNCj4gKyAgICBpbnQgcmM7DQo+ICsgICAgY29uc3QgeGVuX3Bmbl90IGJhc2UgPSBHVUVT VF9NQUdJQ19CQVNFID4+IFhDX1BBR0VfU0hJRlQ7DQo+ICsgICAgeGVuX3Bmbl90IHAybSA9 IChHVUVTVF9NQUdJQ19CQVNFID4+IFhDX1BBR0VfU0hJRlQpICsgWEVOU1RPUkVfUEZOX09G RlNFVDsNCj4gKw0KPiArICAgIHJjID0geGNfZG9tYWluX3NldG1heG1lbSh4Y2gsIGluZm8t PmRvbWlkLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbmZvLT5tYXhfbWVt a2IgKyAoWENfUEFHRV9TSVpFLzEwMjQpKTsNCj4gKyAgICBpZiAocmMgPCAwKQ0KPiArICAg ICAgICByZXR1cm4gcmM7DQo+ICsNCj4gKyAgICByYyA9IHhjX2RvbWFpbl9wb3B1bGF0ZV9w aHlzbWFwX2V4YWN0KHhjaCwgaW5mby0+ZG9taWQsIDEsIDAsIDAsICZwMm0pOw0KPiArICAg IGlmIChyYyA8IDApDQo+ICsgICAgICAgIHJldHVybiByYzsNCj4gKw0KPiArICAgICp4ZW5z dG9yZV9wZm4gPSBiYXNlICsgWEVOU1RPUkVfUEZOX09GRlNFVDsNCj4gKyAgICByYyA9IHhj X2NsZWFyX2RvbWFpbl9wYWdlKHhjaCwgaW5mby0+ZG9taWQsICp4ZW5zdG9yZV9wZm4pOw0K PiArICAgIGlmIChyYyA8IDApDQo+ICsgICAgICAgIHJldHVybiByYzsNCj4gKw0KPiArICAg IHJldHVybiAwOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgYm9vbCBkb194c193cml0ZV9kb20o c3RydWN0IHhzX2hhbmRsZSAqeHNoLCB4c190cmFuc2FjdGlvbl90IHQsDQo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZG9taWRfdCBkb21pZCwgY2hhciAqcGF0aCwgY2hhciAq dmFsKQ0KPiArew0KPiArICAgIGNoYXIgZnVsbF9wYXRoW1NUUl9NQVhfTEVOR1RIXTsNCj4g KyAgICBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgcGVybXNbMl07DQo+ICsNCj4gKyAgICBwZXJt c1swXS5pZCA9IGRvbWlkOw0KPiArICAgIHBlcm1zWzBdLnBlcm1zID0gWFNfUEVSTV9OT05F Ow0KPiArICAgIHBlcm1zWzFdLmlkID0gMDsNCj4gKyAgICBwZXJtc1sxXS5wZXJtcyA9IFhT X1BFUk1fUkVBRDsNCj4gKw0KPiArICAgIGlmIChzbnByaW50ZihmdWxsX3BhdGgsIFNUUl9N QVhfTEVOR1RILA0KPiArICAgICAgICAgICAgICAgICAiL2xvY2FsL2RvbWFpbi8ldS8lcyIs IGRvbWlkLCBwYXRoKSA8IDApDQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gKyAgICBp ZiAoIXhzX3dyaXRlKHhzaCwgdCwgZnVsbF9wYXRoLCB2YWwsIHN0cmxlbih2YWwpKSkNCj4g KyAgICAgICAgcmV0dXJuIGZhbHNlOw0KPiArICAgIHJldHVybiB4c19zZXRfcGVybWlzc2lv bnMoeHNoLCB0LCBmdWxsX3BhdGgsIHBlcm1zLCAyKTsNCj4gK30NCj4gKw0KPiArc3RhdGlj IGJvb2wgZG9feHNfd3JpdGVfbGlieGwoc3RydWN0IHhzX2hhbmRsZSAqeHNoLCB4c190cmFu c2FjdGlvbl90IHQsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkb21pZF90 IGRvbWlkLCBjaGFyICpwYXRoLCBjaGFyICp2YWwpDQo+ICt7DQo+ICsgICAgY2hhciBmdWxs X3BhdGhbU1RSX01BWF9MRU5HVEhdOw0KPiArDQo+ICsgICAgaWYgKHNucHJpbnRmKGZ1bGxf cGF0aCwgU1RSX01BWF9MRU5HVEgsDQo+ICsgICAgICAgICAgICAgICAgICIvbGlieGwvJXUv JXMiLCBkb21pZCwgcGF0aCkgPCAwKQ0KPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ICsg ICAgcmV0dXJuIHhzX3dyaXRlKHhzaCwgdCwgZnVsbF9wYXRoLCB2YWwsIHN0cmxlbih2YWwp KTsNCj4gK30NCj4gKw0KPiArc3RhdGljIGJvb2wgZG9feHNfd3JpdGVfdm0oc3RydWN0IHhz X2hhbmRsZSAqeHNoLCB4c190cmFuc2FjdGlvbl90IHQsDQo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICBsaWJ4bF91dWlkIHV1aWQsIGNoYXIgKnBhdGgsIGNoYXIgKnZhbCkNCj4g K3sNCj4gKyAgICBjaGFyIGZ1bGxfcGF0aFtTVFJfTUFYX0xFTkdUSF07DQo+ICsNCj4gKyAg ICBpZiAoc25wcmludGYoZnVsbF9wYXRoLCBTVFJfTUFYX0xFTkdUSCwNCj4gKyAgICAgICAg ICAgICAgICAgIi92bS8iIExJQlhMX1VVSURfRk1UICIvJXMiLCBMSUJYTF9VVUlEX0JZVEVT KHV1aWQpLCBwYXRoKSA8IDApDQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gKyAgICBy ZXR1cm4geHNfd3JpdGUoeHNoLCB0LCBmdWxsX3BhdGgsIHZhbCwgc3RybGVuKHZhbCkpOw0K PiArfQ0KPiArDQo+ICsvKg0KPiArICogVGhlIHhlbnN0b3JlIG5vZGVzIGFyZSB0aGUgeGVu c3RvcmUgbm9kZXMgbGlieGwgd3JpdGVzIGF0IGRvbWFpbg0KPiArICogY3JlYXRpb24uDQo+ ICsgKg0KPiArICogVGhlIGxpc3Qgd2FzIHJldHJpZXZlZCBieSBydW5uaW5nIHhlbnN0b3Jl LWxzIG9uIGEgY29ycmVzcG9uZGluZw0KPiArICogZG9tYWluIHN0YXJ0ZWQgYnkgeGwvbGli eGwuDQo+ICsgKi8NCj4gK3N0YXRpYyBpbnQgY3JlYXRlX3hlbnN0b3JlKHN0cnVjdCB4c19o YW5kbGUgKnhzaCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWlu Zm8gKmluZm8sIGxpYnhsX3V1aWQgdXVpZCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgIGV2dGNobl9wb3J0X3QgeGVuc3RvcmVfcG9ydCkNCj4gK3sNCj4gKyAgICBkb21pZF90 IGRvbWlkOw0KPiArICAgIHVuc2lnbmVkIGludCBpOw0KPiArICAgIGNoYXIgdXVpZF9zdHJb U1RSX01BWF9MRU5HVEhdOw0KPiArICAgIGNoYXIgZG9tX25hbWVfc3RyW1NUUl9NQVhfTEVO R1RIXTsNCj4gKyAgICBjaGFyIHZtX3ZhbF9zdHJbU1RSX01BWF9MRU5HVEhdOw0KPiArICAg IGNoYXIgaWRfc3RyW1NUUl9NQVhfTEVOR1RIXTsNCj4gKyAgICBjaGFyIG1heF9tZW1rYl9z dHJbU1RSX01BWF9MRU5HVEhdOw0KPiArICAgIGNoYXIgdGFyZ2V0X21lbWtiX3N0cltTVFJf TUFYX0xFTkdUSF07DQo+ICsgICAgY2hhciBjcHVfc3RyW1NUUl9NQVhfTEVOR1RIXTsNCj4g KyAgICBjaGFyIHhlbnN0b3JlX3BvcnRfc3RyW1NUUl9NQVhfTEVOR1RIXTsNCj4gKyAgICBj aGFyIHJpbmdfcmVmX3N0cltTVFJfTUFYX0xFTkdUSF07DQo+ICsgICAgeHNfdHJhbnNhY3Rp b25fdCB0Ow0KPiArICAgIHN0cnVjdCB0aW1ldmFsIHN0YXJ0X3RpbWU7DQo+ICsgICAgY2hh ciBzdGFydF90aW1lX3N0cltTVFJfTUFYX0xFTkdUSF07DQo+ICsgICAgaW50IHJjOw0KPiAr DQo+ICsgICAgaWYgKGdldHRpbWVvZmRheSgmc3RhcnRfdGltZSwgTlVMTCkgPCAwKQ0KPiAr ICAgICAgICByZXR1cm4gLWVycm5vOw0KPiArICAgIHJjID0gc25wcmludGYoc3RhcnRfdGlt ZV9zdHIsIFNUUl9NQVhfTEVOR1RILCAiJWpkLiUwMmQiLA0KPiArICAgICAgICAgICAgKGlu dG1heF90KXN0YXJ0X3RpbWUudHZfc2VjLCAoaW50KXN0YXJ0X3RpbWUudHZfdXNlYyAvIDEw MDAwKTsNCj4gKyAgICBpZiAocmMgPCAwKQ0KPiArICAgICAgICByZXR1cm4gcmM7DQo+ICsN Cj4gKyAgICBkb21pZCA9IGluZm8tPmRvbWlkOw0KPiArICAgIHJjID0gc25wcmludGYoaWRf c3RyLCBTVFJfTUFYX0xFTkdUSCwgIiV1IiwgZG9taWQpOw0KPiArICAgIGlmIChyYyA8IDAp DQo+ICsgICAgICAgIHJldHVybiByYzsNCj4gKyAgICByYyA9IHNucHJpbnRmKGRvbV9uYW1l X3N0ciwgU1RSX01BWF9MRU5HVEgsICJkb20wbGVzcy0ldSIsIGRvbWlkKTsNCj4gKyAgICBp ZiAocmMgPCAwKQ0KPiArICAgICAgICByZXR1cm4gcmM7DQo+ICsgICAgcmMgPSBzbnByaW50 Zih1dWlkX3N0ciwgU1RSX01BWF9MRU5HVEgsIExJQlhMX1VVSURfRk1ULCBMSUJYTF9VVUlE X0JZVEVTKHV1aWQpKTsNCj4gKyAgICBpZiAocmMgPCAwKQ0KPiArICAgICAgICByZXR1cm4g cmM7DQo+ICsgICAgcmMgPSBzbnByaW50Zih2bV92YWxfc3RyLCBTVFJfTUFYX0xFTkdUSCwN Cj4gKyAgICAgICAgICAgICAgICAgICJ2bS8iIExJQlhMX1VVSURfRk1ULCBMSUJYTF9VVUlE X0JZVEVTKHV1aWQpKTsNCj4gKyAgICBpZiAocmMgPCAwKQ0KPiArICAgICAgICByZXR1cm4g cmM7DQo+ICsgICAgcmMgPSBzbnByaW50ZihtYXhfbWVta2Jfc3RyLCBTVFJfTUFYX0xFTkdU SCwgIiVsdSIsIGluZm8tPm1heF9tZW1rYik7DQo+ICsgICAgaWYgKHJjIDwgMCkNCj4gKyAg ICAgICAgcmV0dXJuIHJjOw0KPiArICAgIHJjID0gc25wcmludGYodGFyZ2V0X21lbWtiX3N0 ciwgU1RSX01BWF9MRU5HVEgsICIlbHUiLCBpbmZvLT5jdXJyZW50X21lbWtiKTsNCj4gKyAg ICBpZiAocmMgPCAwKQ0KPiArICAgICAgICByZXR1cm4gcmM7DQo+ICsgICAgcmMgPSBzbnBy aW50ZihyaW5nX3JlZl9zdHIsIFNUUl9NQVhfTEVOR1RILCAiJWxsZCIsDQo+ICsgICAgICAg ICAgICAgICAgICAoR1VFU1RfTUFHSUNfQkFTRSA+PiBYQ19QQUdFX1NISUZUKSArIFhFTlNU T1JFX1BGTl9PRkZTRVQpOw0KPiArICAgIGlmIChyYyA8IDApDQo+ICsgICAgICAgIHJldHVy biByYzsNCj4gKyAgICByYyA9IHNucHJpbnRmKHhlbnN0b3JlX3BvcnRfc3RyLCBTVFJfTUFY X0xFTkdUSCwgIiV1IiwgeGVuc3RvcmVfcG9ydCk7DQo+ICsgICAgaWYgKHJjIDwgMCkNCj4g KyAgICAgICAgcmV0dXJuIHJjOw0KPiArDQo+ICtyZXRyeV90cmFuc2FjdGlvbjoNCj4gKyAg ICB0ID0geHNfdHJhbnNhY3Rpb25fc3RhcnQoeHNoKTsNCj4gKyAgICBpZiAodCA9PSBYQlRf TlVMTCkNCj4gKyAgICAgICAgcmV0dXJuIC1lcnJubzsNCj4gKw0KPiArICAgIHJjID0gLUVJ TzsNCj4gKyAgICAvKiAvdm0gKi8NCj4gKyAgICBpZiAoIWRvX3hzX3dyaXRlX3ZtKHhzaCwg dCwgdXVpZCwgIm5hbWUiLCBkb21fbmFtZV9zdHIpKSBnb3RvIGVycjsNCj4gKyAgICBpZiAo IWRvX3hzX3dyaXRlX3ZtKHhzaCwgdCwgdXVpZCwgInV1aWQiLCB1dWlkX3N0cikpIGdvdG8g ZXJyOw0KPiArICAgIGlmICghZG9feHNfd3JpdGVfdm0oeHNoLCB0LCB1dWlkLCAic3RhcnRf dGltZSIsIHN0YXJ0X3RpbWVfc3RyKSkgZ290byBlcnI7DQo+ICsNCj4gKyAgICAvKiAvZG9t YWluICovDQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0LCBkb21pZCwgInZt Iiwgdm1fdmFsX3N0cikpIGdvdG8gZXJyOw0KPiArICAgIGlmICghZG9feHNfd3JpdGVfZG9t KHhzaCwgdCwgZG9taWQsICJuYW1lIiwgZG9tX25hbWVfc3RyKSkgZ290byBlcnI7DQo+ICsg ICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0LCBkb21pZCwgImNwdSIsICIiKSkgZ290 byBlcnI7DQo+ICsgICAgZm9yIChpID0gMDsgaSA8IGluZm8tPnZjcHVfbWF4X2lkOyBpKysp IHsNCj4gKyAgICAgICAgcmMgPSBzbnByaW50ZihjcHVfc3RyLCBTVFJfTUFYX0xFTkdUSCwg ImNwdS8ldS9hdmFpbGFiaWxpdHkvIiwgaSk7DQo+ICsgICAgICAgIGlmIChyYyA8IDApDQo+ ICsgICAgICAgICAgICBnb3RvIGVycjsNCj4gKyAgICAgICAgcmMgPSAtRUlPOw0KPiArICAg ICAgICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlkLCBjcHVfc3RyLA0KPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW5mby0+Y3B1cG9vbCAmICgxIDw8IGkp KSA/ICJvbmxpbmUiIDogIm9mZmxpbmUiKSkNCj4gKyAgICAgICAgICAgIGdvdG8gZXJyOw0K PiArICAgIH0NCj4gKw0KPiArICAgIGlmICghZG9feHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9t aWQsICJtZW1vcnkiLCAiIikpIGdvdG8gZXJyOw0KPiArICAgIGlmICghZG9feHNfd3JpdGVf ZG9tKHhzaCwgdCwgZG9taWQsICJtZW1vcnkvc3RhdGljLW1heCIsIG1heF9tZW1rYl9zdHIp KSBnb3RvIGVycjsNCj4gKyAgICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlk LCAibWVtb3J5L3RhcmdldCIsIHRhcmdldF9tZW1rYl9zdHIpKSBnb3RvIGVycjsNCj4gKyAg ICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlkLCAibWVtb3J5L3ZpZGVvcmFt IiwgIi0xIikpIGdvdG8gZXJyOw0KPiArDQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20o eHNoLCB0LCBkb21pZCwgImRldmljZSIsICIiKSkgZ290byBlcnI7DQo+ICsgICAgaWYgKCFk b194c193cml0ZV9kb20oeHNoLCB0LCBkb21pZCwgImRldmljZS9zdXNwZW5kIiwgIiIpKSBn b3RvIGVycjsNCj4gKyAgICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlkLCAi ZGV2aWNlL3N1c3BlbmQvZXZlbnQtY2hhbm5lbCIsICIiKSkgZ290byBlcnI7DQo+ICsNCj4g KyAgICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlkLCAiY29udHJvbCIsICIi KSkgZ290byBlcnI7DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0LCBkb21p ZCwgImNvbnRyb2wvc2h1dGRvd24iLCAiIikpIGdvdG8gZXJyOw0KPiArICAgIGlmICghZG9f eHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9taWQsICJjb250cm9sL2ZlYXR1cmUtcG93ZXJvZmYi LCAiMSIpKSBnb3RvIGVycjsNCj4gKyAgICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQs IGRvbWlkLCAiY29udHJvbC9mZWF0dXJlLXJlYm9vdCIsICIxIikpIGdvdG8gZXJyOw0KPiAr ICAgIGlmICghZG9feHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9taWQsICJjb250cm9sL2ZlYXR1 cmUtc3VzcGVuZCIsICIiKSkgZ290byBlcnI7DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9k b20oeHNoLCB0LCBkb21pZCwgImNvbnRyb2wvc3lzcnEiLCAiIikpIGdvdG8gZXJyOw0KPiAr ICAgIGlmICghZG9feHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9taWQsICJjb250cm9sL3BsYXRm b3JtLWZlYXR1cmUtbXVsdGlwcm9jZXNzb3Itc3VzcGVuZCIsICIxIikpIGdvdG8gZXJyOw0K PiArICAgIGlmICghZG9feHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9taWQsICJjb250cm9sL3Bs YXRmb3JtLWZlYXR1cmUteHNfcmVzZXRfd2F0Y2hlcyIsICIxIikpIGdvdG8gZXJyOw0KPiAr DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0LCBkb21pZCwgImRvbWlkIiwg aWRfc3RyKSkgZ290byBlcnI7DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0 LCBkb21pZCwgImRhdGEiLCAiIikpIGdvdG8gZXJyOw0KPiArICAgIGlmICghZG9feHNfd3Jp dGVfZG9tKHhzaCwgdCwgZG9taWQsICJkcml2ZXJzIiwgIiIpKSBnb3RvIGVycjsNCj4gKyAg ICBpZiAoIWRvX3hzX3dyaXRlX2RvbSh4c2gsIHQsIGRvbWlkLCAiZmVhdHVyZSIsICIiKSkg Z290byBlcnI7DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9kb20oeHNoLCB0LCBkb21pZCwg ImF0dHIiLCAiIikpIGdvdG8gZXJyOw0KPiArDQo+ICsgICAgaWYgKCFkb194c193cml0ZV9k b20oeHNoLCB0LCBkb21pZCwgInN0b3JlL3BvcnQiLCB4ZW5zdG9yZV9wb3J0X3N0cikpIGdv dG8gZXJyOw0KPiArICAgIGlmICghZG9feHNfd3JpdGVfZG9tKHhzaCwgdCwgZG9taWQsICJz dG9yZS9yaW5nLXJlZiIsIHJpbmdfcmVmX3N0cikpIGdvdG8gZXJyOw0KPiArDQo+ICsgICAg aWYgKCFkb194c193cml0ZV9saWJ4bCh4c2gsIHQsIGRvbWlkLCAidHlwZSIsICJwdmgiKSkg Z290byBlcnI7DQo+ICsgICAgaWYgKCFkb194c193cml0ZV9saWJ4bCh4c2gsIHQsIGRvbWlk LCAiZG0tdmVyc2lvbiIsICJxZW11X3hlbiIpKSBnb3RvIGVycjsNCj4gKw0KPiArICAgIGlm ICgheHNfdHJhbnNhY3Rpb25fZW5kKHhzaCwgdCwgZmFsc2UpKSB7DQo+ICsgICAgICAgIGlm IChlcnJubyA9PSBFQUdBSU4pDQo+ICsgICAgICAgICAgICBnb3RvIHJldHJ5X3RyYW5zYWN0 aW9uOw0KPiArICAgICAgICBlbHNlDQo+ICsgICAgICAgICAgICByZXR1cm4gLWVycm5vOw0K PiArICAgIH0NCj4gKw0KPiArICAgIHJldHVybiAwOw0KPiArDQo+ICtlcnI6DQo+ICsgICAg eHNfdHJhbnNhY3Rpb25fZW5kKHhzaCwgdCwgdHJ1ZSk7DQo+ICsgICAgcmV0dXJuIHJjOw0K PiArfQ0KPiArDQo+ICtzdGF0aWMgaW50IGluaXRfZG9tYWluKHN0cnVjdCB4c19oYW5kbGUg KnhzaCwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHhjX2ludGVyZmFjZV9j b3JlICp4Y2gsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHhlbmZvcmVpZ25tZW1vcnlf aGFuZGxlICp4ZmgsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGxpYnhsX2RvbWluZm8g KmluZm8pDQo+ICt7DQo+ICsgICAgbGlieGxfdXVpZCB1dWlkOw0KPiArICAgIHVpbnQ2NF90 IHhlbnN0b3JlX2V2dGNobiwgeGVuc3RvcmVfcGZuOw0KPiArICAgIGludCByYzsNCj4gKyAg ICBzdHJ1Y3QgeGVuc3RvcmVfZG9tYWluX2ludGVyZmFjZSAqaW50ZjsNCj4gKw0KPiArICAg IHByaW50ZigiSW5pdCBkb20wbGVzcyBkb21haW46ICV1XG4iLCBpbmZvLT5kb21pZCk7DQo+ ICsNCj4gKyAgICByYyA9IHhjX2h2bV9wYXJhbV9nZXQoeGNoLCBpbmZvLT5kb21pZCwgSFZN X1BBUkFNX1NUT1JFX0VWVENITiwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgJnhl bnN0b3JlX2V2dGNobik7DQo+ICsgICAgaWYgKHJjICE9IDApIHsNCj4gKyAgICAgICAgcHJp bnRmKCJGYWlsZWQgdG8gZ2V0IEhWTV9QQVJBTV9TVE9SRV9FVlRDSE5cbiIpOw0KPiArICAg ICAgICByZXR1cm4gMTsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICAvKiBBbGxvYyB4ZW5zdG9y ZSBwYWdlICovDQo+ICsgICAgaWYgKGFsbG9jX3hzX3BhZ2UoeGNoLCBpbmZvLCAmeGVuc3Rv cmVfcGZuKSAhPSAwKSB7DQo+ICsgICAgICAgIHByaW50ZigiRXJyb3Igb24gYWxsb2MgbWFn aWMgcGFnZXNcbiIpOw0KPiArICAgICAgICByZXR1cm4gMTsNCj4gKyAgICB9DQo+ICsNCj4g KyAgICBpbnRmID0geGVuZm9yZWlnbm1lbW9yeV9tYXAoeGZoLCBpbmZvLT5kb21pZCwgWFNf UkVBRCB8IFhTX1dSSVRFLCAxLA0KDQpJIGRvbid0IHRoaW5rIHlvdSB3YW50IHRvIHBhc3Mg dGhlIHhlbnN0b3JlIHdpcmUgY29tbWFuZHMgaGVyZS4gRGlkIHlvdSBtZWFuDQpQUk9UX1JF QUQgfCBQUk9UX1dSSVRFPw0KDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICZ4ZW5zdG9yZV9wZm4sIE5VTEwpOw0KPiArICAgIGlmICghaW50Zikgew0KPiArICAgICAg ICBwcmludGYoIkVycm9yIG1hcHBpbmcgeGVuc3RvcmUgcGFnZVxuIik7DQo+ICsgICAgICAg IHJldHVybiAxOw0KPiArICAgIH0NCj4gKyAgICBpbnRmLT5jb25uZWN0aW9uID0gWEVOU1RP UkVfUkVDT05ORUNUOw0KPiArICAgIHhlbmZvcmVpZ25tZW1vcnlfdW5tYXAoeGZoLCBpbnRm LCAxKTsNCj4gKw0KPiArICAgIHJjID0geGNfZG9tX2dudHRhYl9zZWVkKHhjaCwgaW5mby0+ ZG9taWQsIHRydWUsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHhlbl9wZm5f dCktMSwgeGVuc3RvcmVfcGZuLCAwLCAwKTsNCg0KU28gbm8gc3VwcG9ydCBmb3IgWGVuc3Rv cmUgcnVubmluZyBpbiBhIHN0dWItZG9tYWluPw0KDQoNCkp1ZXJnZW4NCg== --------------i1Emc5yTRg3B0mB33G9lSzqI Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------i1Emc5yTRg3B0mB33G9lSzqI-- --------------cu0C6z0LauKjwjyF8Th10B27-- --------------4mWKd07QHnHr3dhk0IlKHrlg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJzgQoFAwAAAAAACgkQsN6d1ii/Ey+6 pAf/TNuSGEhH8LBqAmtkiqXIbhMliNozVQFEHl/7xxYMbUz1jAme+Cuj97zV47YLegEY3Pr8l0RX lfopHf5qdJr7P+5LouDvfNM9Z6VjFlsmj08bmV/N2KAfaRjMv2lvSnmb2yMgTICxbhgrkDuQXxRI nCiwPl1WQgF10zYQDr2gxpXn7yFpqhOtSxSDDvtB4A52Fp5LX+ULlHk1S0qjisL80xIi9yieFAfp zFL4H16iE7K0biNj4ZUS9/ViurZxT7ShJ6qa4dtu4ihDo7GpIYA38grZP5nlXkv3cXKlJ0PJSMea izZ1IEhOf5MADFngHJpubMWiO68QdCnPZSShNmVvdg== =tGYv -----END PGP SIGNATURE----- --------------4mWKd07QHnHr3dhk0IlKHrlg-- From xen-devel-bounces@lists.xenproject.org Thu May 05 07:52:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 07:52:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321635.542681 (Exim 4.92) (envelope-from ) id 1nmWHM-0006g2-Qu; Thu, 05 May 2022 07:52:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321635.542681; Thu, 05 May 2022 07:52:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWHM-0006fv-N0; Thu, 05 May 2022 07:52:04 +0000 Received: by outflank-mailman (input) for mailman id 321635; Thu, 05 May 2022 07:52:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWHL-0006fl-Or; Thu, 05 May 2022 07:52:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWHL-0007qv-G9; Thu, 05 May 2022 07:52:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWHL-00062a-8L; Thu, 05 May 2022 07:52:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmWHL-0007al-7q; Thu, 05 May 2022 07:52:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sQMhPPCwbYyfpONd8bmVDiT9BqxIUcwa3m3NmNGWeNg=; b=o16YtqBeCb3hGD2udEzv76H28l jB0cwuY29fgFLjK3UNrDTZu2dCf53CUXbtXTiDHNLARrTxJb322OjTqf2+ndmk4imRGg6TY+nHLD2 2rgfag16nsnV0F3E8rdi462FkHvltFhBbQ9TLBlZIIVSvZy6ey2+PB7TubbmMezSiTzs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170138: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b6bd6eabc0e865578b56244f249a141918fb8070 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 05 May 2022 07:52:03 +0000 flight 170138 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b6bd6eabc0e865578b56244f249a141918fb8070 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 664 days Failing since 151818 2020-07-11 04:18:52 Z 663 days 645 attempts Testing same since 170138 2022-05-05 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106311 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 08:01:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321651.542692 (Exim 4.92) (envelope-from ) id 1nmWQ6-0000HF-13; Thu, 05 May 2022 08:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321651.542692; Thu, 05 May 2022 08:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWQ5-0000H8-Ti; Thu, 05 May 2022 08:01:05 +0000 Received: by outflank-mailman (input) for mailman id 321651; Thu, 05 May 2022 08:01:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWQ4-0000Gy-Jk; Thu, 05 May 2022 08:01:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWQ4-00008J-HK; Thu, 05 May 2022 08:01:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWQ4-0006eH-5F; Thu, 05 May 2022 08:01:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmWQ4-0003cq-4m; Thu, 05 May 2022 08:01:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=97WZHErkn0Bn782wd59+IrYjC+ZNeOpf004oAi8mWiU=; b=DsJZkp9z+5Em9airxr53O4kG9a oyxKHrUGaWaa4MBeoBE1lnLqz7U6HXLD4QcuEIF5kGwdHFz4itRc/kFsWVGPbWjRau8kSZTvr9IfF mwLQzJIXyyLZap0YoNbV+VKZDx8QDQ06BJbLmz2ixjHM9iz+/jzFTzOvASrfEoiQ7gyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170141: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 08:01:04 +0000 flight 170141 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170141/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 814 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321666.542733 (Exim 4.92) (envelope-from ) id 1nmWfJ-0002LO-V8; Thu, 05 May 2022 08:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321666.542733; Thu, 05 May 2022 08:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfJ-0002HX-Fg; Thu, 05 May 2022 08:16:49 +0000 Received: by outflank-mailman (input) for mailman id 321666; Thu, 05 May 2022 08:16:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfI-0001o5-AM for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b47ec514-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 604741F899; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 35D7D13B11; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QCrLC+6Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b47ec514-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cTsWa69X2OUjBOqWnT/IIW2kgbsTrmAnTYOsVwnlfpA=; b=YmPDgx7mOyOodnOmuOxz9DYtEeuCQsuHYFfhPXOPmAD/4WumcdcywENs+Yo9BSVgTJyyLI xNPJyleTNI3ziOaWL6Q6gJzGPis7dM16r5SsfSHyrTqMVL0f/dvhQQk4vCjoIiJhLfEPcV jmS3s2tqWLpMXMAEMPFPYhWj9Bn+B+c= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v3 10/21] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:29 +0200 Message-Id: <20220505081640.17425-11-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- V3: - terminate grant ref list with 0 (Oleksandr Tyshchenko) --- drivers/xen/xen-front-pgdir-shbuf.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c index a959dee21134..b6433761d42c 100644 --- a/drivers/xen/xen-front-pgdir-shbuf.c +++ b/drivers/xen/xen-front-pgdir-shbuf.c @@ -21,15 +21,6 @@ #include -#ifndef GRANT_INVALID_REF -/* - * FIXME: usage of grant reference 0 as invalid grant reference: - * grant reference 0 is valid, but never exposed to a PV driver, - * because of the fact it is already in use/reserved by the PV console. - */ -#define GRANT_INVALID_REF 0 -#endif - /** * This structure represents the structure of a shared page * that contains grant references to the pages of the shared @@ -38,6 +29,7 @@ */ struct xen_page_directory { grant_ref_t gref_dir_next_page; +#define XEN_GREF_LIST_END 0 grant_ref_t gref[1]; /* Variable length */ }; @@ -83,7 +75,7 @@ grant_ref_t xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf) { if (!buf->grefs) - return GRANT_INVALID_REF; + return INVALID_GRANT_REF; return buf->grefs[0]; } @@ -142,7 +134,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_shbuf *buf) int i; for (i = 0; i < buf->num_grefs; i++) - if (buf->grefs[i] != GRANT_INVALID_REF) + if (buf->grefs[i] != INVALID_GRANT_REF) gnttab_end_foreign_access(buf->grefs[i], 0UL); } kfree(buf->grefs); @@ -355,7 +347,7 @@ static void backend_fill_page_dir(struct xen_front_pgdir_shbuf *buf) } /* Last page must say there is no more pages. */ page_dir = (struct xen_page_directory *)ptr; - page_dir->gref_dir_next_page = GRANT_INVALID_REF; + page_dir->gref_dir_next_page = XEN_GREF_LIST_END; } /** @@ -384,7 +376,7 @@ static void guest_fill_page_dir(struct xen_front_pgdir_shbuf *buf) if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) { to_copy = grefs_left; - page_dir->gref_dir_next_page = GRANT_INVALID_REF; + page_dir->gref_dir_next_page = XEN_GREF_LIST_END; } else { to_copy = XEN_NUM_GREFS_PER_PAGE; page_dir->gref_dir_next_page = buf->grefs[i + 1]; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321668.542746 (Exim 4.92) (envelope-from ) id 1nmWfL-0002bc-3n; Thu, 05 May 2022 08:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321668.542746; Thu, 05 May 2022 08:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfK-0002YX-Go; Thu, 05 May 2022 08:16:50 +0000 Received: by outflank-mailman (input) for mailman id 321668; Thu, 05 May 2022 08:16:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfJ-0001o5-Ay for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b44835c0-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F05971F898; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B495913B11; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OOBiKu2Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b44835c0-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+hTaiTIyePP0FUFQBbLbCUhke4bQBarxkCj3G5VB5K4=; b=aeJosLBGzoVaAdiBDdxPfy+Uo/uCh2Mz1gdkHFZtuDdt1P0s9kB1QomOQe8wM6fslfYUBC RlMnuBh33GsFIs0C9YK7GDs7Z+Gm8tpGQ1DQOA+gHhvbmMKL7LFdvX9OlSdw93QKPlZLUp 8H2PS6IrRiOqk7Kx3GL5Kyojzya3M3w= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Andrushchenko , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: [PATCH v3 08/21] xen/sound: switch xen_snd_front to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:27 +0200 Message-Id: <20220505081640.17425-9-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 4 ++-- sound/xen/xen_snd_front_evtchnl.h | 9 --------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c index ecbc294fc59a..3e21369c8216 100644 --- a/sound/xen/xen_snd_front_evtchnl.c +++ b/sound/xen/xen_snd_front_evtchnl.c @@ -167,7 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info, xenbus_free_evtchn(front_info->xb_dev, channel->port); /* End access and free the page. */ - if (channel->gref != GRANT_INVALID_REF) + if (channel->gref != INVALID_GRANT_REF) gnttab_end_foreign_access(channel->gref, page); else free_page(page); @@ -207,7 +207,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index, channel->index = index; channel->front_info = front_info; channel->state = EVTCHNL_STATE_DISCONNECTED; - channel->gref = GRANT_INVALID_REF; + channel->gref = INVALID_GRANT_REF; page = get_zeroed_page(GFP_KERNEL); if (!page) { ret = -ENOMEM; diff --git a/sound/xen/xen_snd_front_evtchnl.h b/sound/xen/xen_snd_front_evtchnl.h index cbe51fd1ec15..3675fba70564 100644 --- a/sound/xen/xen_snd_front_evtchnl.h +++ b/sound/xen/xen_snd_front_evtchnl.h @@ -15,15 +15,6 @@ struct xen_snd_front_info; -#ifndef GRANT_INVALID_REF -/* - * FIXME: usage of grant reference 0 as invalid grant reference: - * grant reference 0 is valid, but never exposed to a PV driver, - * because of the fact it is already in use/reserved by the PV console. - */ -#define GRANT_INVALID_REF 0 -#endif - /* Timeout in ms to wait for backend to respond. */ #define VSND_WAIT_BACK_MS 3000 -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321665.542727 (Exim 4.92) (envelope-from ) id 1nmWfJ-0002FW-D3; Thu, 05 May 2022 08:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321665.542727; Thu, 05 May 2022 08:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfJ-0002DJ-4R; Thu, 05 May 2022 08:16:49 +0000 Received: by outflank-mailman (input) for mailman id 321665; Thu, 05 May 2022 08:16:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfH-0001qT-U3 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3a9e985-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DDDEC1F855; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 945B313B12; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cF3JIuyHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a9e985-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wb0uPnKVxH6X1fgBon9Xmych7JExQqCQIYQDdDvAVlQ=; b=k1MwMA6LVKHn4L9RbGeodLm/ou5drbiC+/MbupQdZY0wZom9Er4mw5atok2+PHFm4+7p5o pe7ibN48YJRZ4BpfaAyM4qGPRz6VZ3mDCKlIU2/4/HGucH1zu9hjHWvMmeidZ0WHufVZCh LzZlGjtJFZCHchL/8oPj8rkEjUasN8Y= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v3 04/21] xen/netfront: switch netfront to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:23 +0200 Message-Id: <20220505081640.17425-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index e2b4a1893a13..af3d3de7d9fa 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -78,8 +78,6 @@ struct netfront_cb { #define RX_COPY_THRESHOLD 256 -#define GRANT_INVALID_REF 0 - #define NET_TX_RING_SIZE __CONST_RING_SIZE(xen_netif_tx, XEN_PAGE_SIZE) #define NET_RX_RING_SIZE __CONST_RING_SIZE(xen_netif_rx, XEN_PAGE_SIZE) @@ -224,7 +222,7 @@ static grant_ref_t xennet_get_rx_ref(struct netfront_queue *queue, { int i = xennet_rxidx(ri); grant_ref_t ref = queue->grant_rx_ref[i]; - queue->grant_rx_ref[i] = GRANT_INVALID_REF; + queue->grant_rx_ref[i] = INVALID_GRANT_REF; return ref; } @@ -432,7 +430,7 @@ static bool xennet_tx_buf_gc(struct netfront_queue *queue) } gnttab_release_grant_reference( &queue->gref_tx_head, queue->grant_tx_ref[id]); - queue->grant_tx_ref[id] = GRANT_INVALID_REF; + queue->grant_tx_ref[id] = INVALID_GRANT_REF; queue->grant_tx_page[id] = NULL; add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, id); dev_kfree_skb_irq(skb); @@ -1021,7 +1019,7 @@ static int xennet_get_responses(struct netfront_queue *queue, * the backend driver. In future this should flag the bad * situation to the system controller to reboot the backend. */ - if (ref == GRANT_INVALID_REF) { + if (ref == INVALID_GRANT_REF) { if (net_ratelimit()) dev_warn(dev, "Bad rx response id %d.\n", rx->id); @@ -1390,7 +1388,7 @@ static void xennet_release_tx_bufs(struct netfront_queue *queue) gnttab_end_foreign_access(queue->grant_tx_ref[i], (unsigned long)page_address(queue->grant_tx_page[i])); queue->grant_tx_page[i] = NULL; - queue->grant_tx_ref[i] = GRANT_INVALID_REF; + queue->grant_tx_ref[i] = INVALID_GRANT_REF; add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, i); dev_kfree_skb_irq(skb); } @@ -1411,7 +1409,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue) continue; ref = queue->grant_rx_ref[id]; - if (ref == GRANT_INVALID_REF) + if (ref == INVALID_GRANT_REF) continue; page = skb_frag_page(&skb_shinfo(skb)->frags[0]); @@ -1422,7 +1420,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue) get_page(page); gnttab_end_foreign_access(ref, (unsigned long)page_address(page)); - queue->grant_rx_ref[id] = GRANT_INVALID_REF; + queue->grant_rx_ref[id] = INVALID_GRANT_REF; kfree_skb(skb); } @@ -1761,7 +1759,7 @@ static int netfront_probe(struct xenbus_device *dev, static void xennet_end_access(int ref, void *page) { /* This frees the page as a side-effect */ - if (ref != GRANT_INVALID_REF) + if (ref != INVALID_GRANT_REF) gnttab_end_foreign_access(ref, (unsigned long)page); } @@ -1798,8 +1796,8 @@ static void xennet_disconnect_backend(struct netfront_info *info) xennet_end_access(queue->tx_ring_ref, queue->tx.sring); xennet_end_access(queue->rx_ring_ref, queue->rx.sring); - queue->tx_ring_ref = GRANT_INVALID_REF; - queue->rx_ring_ref = GRANT_INVALID_REF; + queue->tx_ring_ref = INVALID_GRANT_REF; + queue->rx_ring_ref = INVALID_GRANT_REF; queue->tx.sring = NULL; queue->rx.sring = NULL; @@ -1927,8 +1925,8 @@ static int setup_netfront(struct xenbus_device *dev, grant_ref_t gref; int err; - queue->tx_ring_ref = GRANT_INVALID_REF; - queue->rx_ring_ref = GRANT_INVALID_REF; + queue->tx_ring_ref = INVALID_GRANT_REF; + queue->rx_ring_ref = INVALID_GRANT_REF; queue->rx.sring = NULL; queue->tx.sring = NULL; @@ -1978,17 +1976,17 @@ static int setup_netfront(struct xenbus_device *dev, * granted pages because backend is not accessing it at this point. */ fail: - if (queue->rx_ring_ref != GRANT_INVALID_REF) { + if (queue->rx_ring_ref != INVALID_GRANT_REF) { gnttab_end_foreign_access(queue->rx_ring_ref, (unsigned long)rxs); - queue->rx_ring_ref = GRANT_INVALID_REF; + queue->rx_ring_ref = INVALID_GRANT_REF; } else { free_page((unsigned long)rxs); } - if (queue->tx_ring_ref != GRANT_INVALID_REF) { + if (queue->tx_ring_ref != INVALID_GRANT_REF) { gnttab_end_foreign_access(queue->tx_ring_ref, (unsigned long)txs); - queue->tx_ring_ref = GRANT_INVALID_REF; + queue->tx_ring_ref = INVALID_GRANT_REF; } else { free_page((unsigned long)txs); } @@ -2020,7 +2018,7 @@ static int xennet_init_queue(struct netfront_queue *queue) queue->tx_pend_queue = TX_LINK_NONE; for (i = 0; i < NET_TX_RING_SIZE; i++) { queue->tx_link[i] = i + 1; - queue->grant_tx_ref[i] = GRANT_INVALID_REF; + queue->grant_tx_ref[i] = INVALID_GRANT_REF; queue->grant_tx_page[i] = NULL; } queue->tx_link[NET_TX_RING_SIZE - 1] = TX_LINK_NONE; @@ -2028,7 +2026,7 @@ static int xennet_init_queue(struct netfront_queue *queue) /* Clear out rx_skbs */ for (i = 0; i < NET_RX_RING_SIZE; i++) { queue->rx_skbs[i] = NULL; - queue->grant_rx_ref[i] = GRANT_INVALID_REF; + queue->grant_rx_ref[i] = INVALID_GRANT_REF; } /* A grant for every tx ring slot */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321663.542714 (Exim 4.92) (envelope-from ) id 1nmWfI-00024T-I3; Thu, 05 May 2022 08:16:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321663.542714; Thu, 05 May 2022 08:16:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfI-00024J-F5; Thu, 05 May 2022 08:16:48 +0000 Received: by outflank-mailman (input) for mailman id 321663; Thu, 05 May 2022 08:16:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfG-0001o5-A0 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:46 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b324c607-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:44 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 162DA1F45F; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D700013B12; Thu, 5 May 2022 08:16:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wL4gM+uHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b324c607-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FLxbtpzBQ9VbjqIE6K+qmcx5CrSY4iyn10JST4u0ffI=; b=ay1jpywDJoybUwQoo2dUHqa0To7OTJNg/ZM1r+YNMOd3surTH0G/97x0mDb7bzCvSiLOI7 f/RB5om3S2Zi8OUxDTeYZWcLhK99ITR1to9+YrZTjmC80uSFFispkwJWb2V16Rh7jJZTJq zLC6uOkeYylneNsL4LOKmBK0ZhYQJF8= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v3 01/21] xen: update grant_table.h Date: Thu, 5 May 2022 10:16:20 +0200 Message-Id: <20220505081640.17425-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update include/xen/interface/grant_table.h to its newest version. This allows to drop some private definitions in grant-table.c and include/xen/grant_table.h. Signed-off-by: Juergen Gross --- V3: - new patch --- drivers/xen/grant-table.c | 8 +- include/xen/grant_table.h | 2 - include/xen/interface/grant_table.h | 161 +++++++++++++++++----------- 3 files changed, 103 insertions(+), 68 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 8ccccace2a4f..6ea31ea26008 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -66,8 +66,6 @@ #include -/* External tools reserve first few grant table entries. */ -#define NR_RESERVED_ENTRIES 8 #define GNTTAB_LIST_END 0xffffffff static grant_ref_t **gnttab_list; @@ -1465,12 +1463,12 @@ int gnttab_init(void) nr_init_grefs = nr_grant_frames * gnttab_interface->grefs_per_grant_frame; - for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) + for (i = GNTTAB_NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) gnttab_entry(i) = i + 1; gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END; - gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES; - gnttab_free_head = NR_RESERVED_ENTRIES; + gnttab_free_count = nr_init_grefs - GNTTAB_NR_RESERVED_ENTRIES; + gnttab_free_head = GNTTAB_NR_RESERVED_ENTRIES; printk("Grant table initialized\n"); return 0; diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index dfd5bf31cfb9..7d0f2f0037b8 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -57,8 +57,6 @@ #define INVALID_GRANT_REF ((grant_ref_t)-1) #define INVALID_GRANT_HANDLE ((grant_handle_t)-1) -#define GNTTAB_RESERVED_XENSTORE 1 - /* NR_GRANT_FRAMES must be less than or equal to that configured in Xen */ #define NR_GRANT_FRAMES 4 diff --git a/include/xen/interface/grant_table.h b/include/xen/interface/grant_table.h index 3eeabbc7ee09..cebbd99f1f84 100644 --- a/include/xen/interface/grant_table.h +++ b/include/xen/interface/grant_table.h @@ -19,7 +19,8 @@ /* Some rough guidelines on accessing and updating grant-table entries * in a concurrency-safe manner. For more information, Linux contains a - * reference implementation for guest OSes (arch/xen/kernel/grant_table.c). + * reference implementation for guest OSes (drivers/xen/grant_table.c, see + * http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD * * NB. WMB is a no-op on current-generation x86 processors. However, a * compiler barrier will still be required. @@ -80,8 +81,9 @@ typedef uint32_t grant_ref_t; */ /* - * Version 1 of the grant table entry structure is maintained purely - * for backwards compatibility. New guests should use version 2. + * Version 1 of the grant table entry structure is maintained largely for + * backwards compatibility. New guests are recommended to support using + * version 2 to overcome version 1 limitations, but to default to version 1. */ struct grant_entry_v1 { /* GTF_xxx: various type and flag information. [XEN,GST] */ @@ -89,12 +91,21 @@ struct grant_entry_v1 { /* The domain being granted foreign privileges. [GST] */ domid_t domid; /* - * GTF_permit_access: Frame that @domid is allowed to map and access. [GST] - * GTF_accept_transfer: Frame whose ownership transferred by @domid. [XEN] + * GTF_permit_access: GFN that @domid is allowed to map and access. [GST] + * GTF_accept_transfer: GFN that @domid is allowed to transfer into. [GST] + * GTF_transfer_completed: MFN whose ownership transferred by @domid + * (non-translated guests only). [XEN] */ uint32_t frame; }; +/* The first few grant table entries will be preserved across grant table + * version changes and may be pre-populated at domain creation by tools. + */ +#define GNTTAB_NR_RESERVED_ENTRIES 8 +#define GNTTAB_RESERVED_CONSOLE 0 +#define GNTTAB_RESERVED_XENSTORE 1 + /* * Type of grant entry. * GTF_invalid: This grant entry grants no privileges. @@ -111,10 +122,13 @@ struct grant_entry_v1 { #define GTF_type_mask (3U<<0) /* - * Subflags for GTF_permit_access. + * Subflags for GTF_permit_access and GTF_transitive. * GTF_readonly: Restrict @domid to read-only mappings and accesses. [GST] * GTF_reading: Grant entry is currently mapped for reading by @domid. [XEN] * GTF_writing: Grant entry is currently mapped for writing by @domid. [XEN] + * Further subflags for GTF_permit_access only. + * GTF_PAT, GTF_PWT, GTF_PCD: (x86) cache attribute flags to be used for + * mappings of the grant [GST] * GTF_sub_page: Grant access to only a subrange of the page. @domid * will only be allowed to copy from the grant, and not * map it. [GST] @@ -125,6 +139,12 @@ struct grant_entry_v1 { #define GTF_reading (1U<<_GTF_reading) #define _GTF_writing (4) #define GTF_writing (1U<<_GTF_writing) +#define _GTF_PWT (5) +#define GTF_PWT (1U<<_GTF_PWT) +#define _GTF_PCD (6) +#define GTF_PCD (1U<<_GTF_PCD) +#define _GTF_PAT (7) +#define GTF_PAT (1U<<_GTF_PAT) #define _GTF_sub_page (8) #define GTF_sub_page (1U<<_GTF_sub_page) @@ -164,8 +184,7 @@ struct grant_entry_header { }; /* - * Version 2 of the grant entry structure, here is a union because three - * different types are suppotted: full_page, sub_page and transitive. + * Version 2 of the grant entry structure. */ union grant_entry_v2 { struct grant_entry_header hdr; @@ -180,9 +199,9 @@ union grant_entry_v2 { * field of the same name in the V1 entry structure. */ struct { - struct grant_entry_header hdr; - uint32_t pad0; - uint64_t frame; + struct grant_entry_header hdr; + uint32_t pad0; + uint64_t frame; } full_page; /* @@ -191,10 +210,10 @@ union grant_entry_v2 { * in frame @frame. */ struct { - struct grant_entry_header hdr; - uint16_t page_off; - uint16_t length; - uint64_t frame; + struct grant_entry_header hdr; + uint16_t page_off; + uint16_t length; + uint64_t frame; } sub_page; /* @@ -202,12 +221,15 @@ union grant_entry_v2 { * grant @gref in domain @trans_domid, as if it was the local * domain. Obviously, the transitive access must be compatible * with the original grant. + * + * The current version of Xen does not allow transitive grants + * to be mapped. */ struct { - struct grant_entry_header hdr; - domid_t trans_domid; - uint16_t pad0; - grant_ref_t gref; + struct grant_entry_header hdr; + domid_t trans_domid; + uint16_t pad0; + grant_ref_t gref; } transitive; uint32_t __spacer[4]; /* Pad to a power of two */ @@ -219,6 +241,21 @@ typedef uint16_t grant_status_t; * GRANT TABLE QUERIES AND USES */ +#define GNTTABOP_map_grant_ref 0 +#define GNTTABOP_unmap_grant_ref 1 +#define GNTTABOP_setup_table 2 +#define GNTTABOP_dump_table 3 +#define GNTTABOP_transfer 4 +#define GNTTABOP_copy 5 +#define GNTTABOP_query_size 6 +#define GNTTABOP_unmap_and_replace 7 +#define GNTTABOP_set_version 8 +#define GNTTABOP_get_status_frames 9 +#define GNTTABOP_get_version 10 +#define GNTTABOP_swap_grant_ref 11 +#define GNTTABOP_cache_flush 12 +/* ` } */ + /* * Handle to track a mapping created via a grant reference. */ @@ -227,7 +264,7 @@ typedef uint32_t grant_handle_t; /* * GNTTABOP_map_grant_ref: Map the grant entry (,) for access * by devices and/or host CPUs. If successful, is a tracking number - * that must be presented later to destroy the mapping(s). On error, + * that must be presented later to destroy the mapping(s). On error, * is a negative status code. * NOTES: * 1. If GNTMAP_device_map is specified then is the address @@ -241,7 +278,6 @@ typedef uint32_t grant_handle_t; * host mapping is destroyed by other means then it is *NOT* guaranteed * to be accounted to the correct grant reference! */ -#define GNTTABOP_map_grant_ref 0 struct gnttab_map_grant_ref { /* IN parameters. */ uint64_t host_addr; @@ -266,7 +302,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_map_grant_ref); * 3. After executing a batch of unmaps, it is guaranteed that no stale * mappings will remain in the device or host TLBs. */ -#define GNTTABOP_unmap_grant_ref 1 struct gnttab_unmap_grant_ref { /* IN parameters. */ uint64_t host_addr; @@ -286,7 +321,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_unmap_grant_ref); * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. * 3. Xen may not support more than a single grant-table page per domain. */ -#define GNTTABOP_setup_table 2 struct gnttab_setup_table { /* IN parameters. */ domid_t dom; @@ -301,7 +335,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_setup_table); * GNTTABOP_dump_table: Dump the contents of the grant table to the * xen console. Debugging use only. */ -#define GNTTABOP_dump_table 3 struct gnttab_dump_table { /* IN parameters. */ domid_t dom; @@ -311,17 +344,17 @@ struct gnttab_dump_table { DEFINE_GUEST_HANDLE_STRUCT(gnttab_dump_table); /* - * GNTTABOP_transfer_grant_ref: Transfer to a foreign domain. The - * foreign domain has previously registered its interest in the transfer via - * . + * GNTTABOP_transfer: Transfer to a foreign domain. The foreign domain + * has previously registered its interest in the transfer via . * * Note that, even if the transfer fails, the specified page no longer belongs * to the calling domain *unless* the error is GNTST_bad_page. + * + * Note further that only PV guests can use this operation. */ -#define GNTTABOP_transfer 4 struct gnttab_transfer { /* IN parameters. */ - xen_pfn_t mfn; + xen_pfn_t mfn; domid_t domid; grant_ref_t ref; /* OUT parameters. */ @@ -352,21 +385,20 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_transfer); #define _GNTCOPY_dest_gref (1) #define GNTCOPY_dest_gref (1<<_GNTCOPY_dest_gref) -#define GNTTABOP_copy 5 struct gnttab_copy { - /* IN parameters. */ - struct { - union { - grant_ref_t ref; - xen_pfn_t gmfn; - } u; - domid_t domid; - uint16_t offset; - } source, dest; - uint16_t len; - uint16_t flags; /* GNTCOPY_* */ - /* OUT parameters. */ - int16_t status; + /* IN parameters. */ + struct gnttab_copy_ptr { + union { + grant_ref_t ref; + xen_pfn_t gmfn; + } u; + domid_t domid; + uint16_t offset; + } source, dest; + uint16_t len; + uint16_t flags; /* GNTCOPY_* */ + /* OUT parameters. */ + int16_t status; }; DEFINE_GUEST_HANDLE_STRUCT(gnttab_copy); @@ -377,7 +409,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_copy); * 1. may be specified as DOMID_SELF. * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. */ -#define GNTTABOP_query_size 6 struct gnttab_query_size { /* IN parameters. */ domid_t dom; @@ -399,7 +430,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_query_size); * 2. After executing a batch of unmaps, it is guaranteed that no stale * mappings will remain in the device or host TLBs. */ -#define GNTTABOP_unmap_and_replace 7 struct gnttab_unmap_and_replace { /* IN parameters. */ uint64_t host_addr; @@ -412,14 +442,12 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_unmap_and_replace); /* * GNTTABOP_set_version: Request a particular version of the grant - * table shared table structure. This operation can only be performed - * once in any given domain. It must be performed before any grants - * are activated; otherwise, the domain will be stuck with version 1. - * The only defined versions are 1 and 2. + * table shared table structure. This operation may be used to toggle + * between different versions, but must be performed while no grants + * are active. The only defined versions are 1 and 2. */ -#define GNTTABOP_set_version 8 struct gnttab_set_version { - /* IN parameters */ + /* IN/OUT parameters */ uint32_t version; }; DEFINE_GUEST_HANDLE_STRUCT(gnttab_set_version); @@ -436,7 +464,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_set_version); * 1. may be specified as DOMID_SELF. * 2. Only a sufficiently-privileged domain may specify != DOMID_SELF. */ -#define GNTTABOP_get_status_frames 9 struct gnttab_get_status_frames { /* IN parameters. */ uint32_t nr_frames; @@ -451,7 +478,6 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_get_status_frames); * GNTTABOP_get_version: Get the grant table version which is in * effect for domain . */ -#define GNTTABOP_get_version 10 struct gnttab_get_version { /* IN parameters */ domid_t dom; @@ -461,27 +487,38 @@ struct gnttab_get_version { }; DEFINE_GUEST_HANDLE_STRUCT(gnttab_get_version); +/* + * GNTTABOP_swap_grant_ref: Swap the contents of two grant entries. + */ +struct gnttab_swap_grant_ref { + /* IN parameters */ + grant_ref_t ref_a; + grant_ref_t ref_b; + /* OUT parameters */ + int16_t status; /* GNTST_* */ +}; +DEFINE_GUEST_HANDLE_STRUCT(gnttab_swap_grant_ref); + /* * Issue one or more cache maintenance operations on a portion of a * page granted to the calling domain by a foreign domain. */ -#define GNTTABOP_cache_flush 12 struct gnttab_cache_flush { union { uint64_t dev_bus_addr; grant_ref_t ref; } a; - uint16_t offset; /* offset from start of grant */ - uint16_t length; /* size within the grant */ -#define GNTTAB_CACHE_CLEAN (1<<0) -#define GNTTAB_CACHE_INVAL (1<<1) -#define GNTTAB_CACHE_SOURCE_GREF (1<<31) + uint16_t offset; /* offset from start of grant */ + uint16_t length; /* size within the grant */ +#define GNTTAB_CACHE_CLEAN (1u<<0) +#define GNTTAB_CACHE_INVAL (1u<<1) +#define GNTTAB_CACHE_SOURCE_GREF (1u<<31) uint32_t op; }; DEFINE_GUEST_HANDLE_STRUCT(gnttab_cache_flush); /* - * Bitfield values for update_pin_status.flags. + * Bitfield values for gnttab_map_grant_ref.flags. */ /* Map the grant entry for access by I/O devices. */ #define _GNTMAP_device_map (0) @@ -531,6 +568,7 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_cache_flush); #define GNTST_bad_copy_arg (-10) /* copy arguments cross page boundary. */ #define GNTST_address_too_big (-11) /* transfer page address too large. */ #define GNTST_eagain (-12) /* Operation not done; try again. */ +#define GNTST_no_space (-13) /* Out of space (handles etc). */ #define GNTTABOP_error_msgs { \ "okay", \ @@ -545,7 +583,8 @@ DEFINE_GUEST_HANDLE_STRUCT(gnttab_cache_flush); "bad page", \ "copy arguments cross page boundary", \ "page address size too large", \ - "operation not done; try again" \ + "operation not done; try again", \ + "out of space", \ } #endif /* __XEN_PUBLIC_GRANT_TABLE_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321664.542720 (Exim 4.92) (envelope-from ) id 1nmWfJ-000299-0Q; Thu, 05 May 2022 08:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321664.542720; Thu, 05 May 2022 08:16:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfI-00027Y-Qp; Thu, 05 May 2022 08:16:48 +0000 Received: by outflank-mailman (input) for mailman id 321664; Thu, 05 May 2022 08:16:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfH-0001o5-Aa for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b391d4b2-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9A2411F460; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 515F513B11; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4NWHEuyHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b391d4b2-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LiPPxVvJ/tZwu8jvS4fDntozP5hW+zLbGIbL5f3d6ug=; b=lKDEZaYIrZbZV4QoHmZ/ztck+zaRHuUrhf9XzAXw8TYoOaMZLBy/6PqTsy2u9tZ3RGh5rN br1KiRGwE6tZ0a4Rhq9/oaOZGsqLWY5ghXvy+6NeNQSGW9uQhU2pPwQn2YBxSmcfKgQ4so PQf8BYf5MYZ5Uj2P/okjcZrWgtE92jo= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Boris Ostrovsky , Stefano Stabellini , Jens Axboe Subject: [PATCH v3 03/21] xen/blkfront: switch blkfront to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:22 +0200 Message-Id: <20220505081640.17425-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 003056d4f7f5..7f35e30e626a 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -229,8 +229,6 @@ static unsigned int nr_minors; static unsigned long *minors; static DEFINE_SPINLOCK(minor_lock); -#define GRANT_INVALID_REF 0 - #define PARTS_PER_DISK 16 #define PARTS_PER_EXT_DISK 256 @@ -321,7 +319,7 @@ static int fill_grant_buffer(struct blkfront_ring_info *rinfo, int num) gnt_list_entry->page = granted_page; } - gnt_list_entry->gref = GRANT_INVALID_REF; + gnt_list_entry->gref = INVALID_GRANT_REF; list_add(&gnt_list_entry->node, &rinfo->grants); i++; } @@ -350,7 +348,7 @@ static struct grant *get_free_grant(struct blkfront_ring_info *rinfo) node); list_del(&gnt_list_entry->node); - if (gnt_list_entry->gref != GRANT_INVALID_REF) + if (gnt_list_entry->gref != INVALID_GRANT_REF) rinfo->persistent_gnts_c--; return gnt_list_entry; @@ -372,7 +370,7 @@ static struct grant *get_grant(grant_ref_t *gref_head, struct grant *gnt_list_entry = get_free_grant(rinfo); struct blkfront_info *info = rinfo->dev_info; - if (gnt_list_entry->gref != GRANT_INVALID_REF) + if (gnt_list_entry->gref != INVALID_GRANT_REF) return gnt_list_entry; /* Assign a gref to this page */ @@ -396,7 +394,7 @@ static struct grant *get_indirect_grant(grant_ref_t *gref_head, struct grant *gnt_list_entry = get_free_grant(rinfo); struct blkfront_info *info = rinfo->dev_info; - if (gnt_list_entry->gref != GRANT_INVALID_REF) + if (gnt_list_entry->gref != INVALID_GRANT_REF) return gnt_list_entry; /* Assign a gref to this page */ @@ -1221,7 +1219,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) list_for_each_entry_safe(persistent_gnt, n, &rinfo->grants, node) { list_del(&persistent_gnt->node); - if (persistent_gnt->gref != GRANT_INVALID_REF) { + if (persistent_gnt->gref != INVALID_GRANT_REF) { gnttab_end_foreign_access(persistent_gnt->gref, 0UL); rinfo->persistent_gnts_c--; @@ -1283,9 +1281,9 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) /* Free resources associated with old device channel. */ for (i = 0; i < info->nr_ring_pages; i++) { - if (rinfo->ring_ref[i] != GRANT_INVALID_REF) { + if (rinfo->ring_ref[i] != INVALID_GRANT_REF) { gnttab_end_foreign_access(rinfo->ring_ref[i], 0); - rinfo->ring_ref[i] = GRANT_INVALID_REF; + rinfo->ring_ref[i] = INVALID_GRANT_REF; } } free_pages_exact(rinfo->ring.sring, @@ -1475,7 +1473,7 @@ static int blkif_completion(unsigned long *id, * to the tail of the list, so it will not be picked * again unless we run out of persistent grants. */ - s->grants_used[i]->gref = GRANT_INVALID_REF; + s->grants_used[i]->gref = INVALID_GRANT_REF; list_add_tail(&s->grants_used[i]->node, &rinfo->grants); } } @@ -1500,7 +1498,7 @@ static int blkif_completion(unsigned long *id, indirect_page = s->indirect_grants[i]->page; list_add(&indirect_page->lru, &rinfo->indirect_pages); } - s->indirect_grants[i]->gref = GRANT_INVALID_REF; + s->indirect_grants[i]->gref = INVALID_GRANT_REF; list_add_tail(&s->indirect_grants[i]->node, &rinfo->grants); } } @@ -1687,7 +1685,7 @@ static int setup_blkring(struct xenbus_device *dev, grant_ref_t gref[XENBUS_MAX_RING_GRANTS]; for (i = 0; i < info->nr_ring_pages; i++) - rinfo->ring_ref[i] = GRANT_INVALID_REF; + rinfo->ring_ref[i] = INVALID_GRANT_REF; sring = alloc_pages_exact(ring_size, GFP_NOIO); if (!sring) { @@ -2544,13 +2542,13 @@ static void purge_persistent_grants(struct blkfront_info *info) list_for_each_entry_safe(gnt_list_entry, tmp, &rinfo->grants, node) { - if (gnt_list_entry->gref == GRANT_INVALID_REF || + if (gnt_list_entry->gref == INVALID_GRANT_REF || !gnttab_try_end_foreign_access(gnt_list_entry->gref)) continue; list_del(&gnt_list_entry->node); rinfo->persistent_gnts_c--; - gnt_list_entry->gref = GRANT_INVALID_REF; + gnt_list_entry->gref = INVALID_GRANT_REF; list_add_tail(&gnt_list_entry->node, &grants); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321662.542703 (Exim 4.92) (envelope-from ) id 1nmWfH-0001oO-DL; Thu, 05 May 2022 08:16:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321662.542703; Thu, 05 May 2022 08:16:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfH-0001oG-7b; Thu, 05 May 2022 08:16:47 +0000 Received: by outflank-mailman (input) for mailman id 321662; Thu, 05 May 2022 08:16:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfF-0001o5-IK for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3401556-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:44 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AF8C210DF; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CCDA13B11; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8JqSBeyHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3401556-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97UDNK1f7czhnU/2ak2EMjgJM9WmcipgW6hepwuQnLg=; b=TIGROP5NtrO/PMKocRwXDq4uW8i352wOc1Z8dfJPBykWG1KVaUs1y2V2ugsyPQNmx7HW7A 7YEaBEYBaDKYEspokFV4o5IqKEomEss+SP90j3p4SJQhRp2HPvh7OngYWLnofHdSf1J4/b gKvNZ3TxKDt4H8fjI3G6ZJ0tlhzkvPg= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v3 02/21] xen/grant-table: never put a reserved grant on the free list Date: Thu, 5 May 2022 10:16:21 +0200 Message-Id: <20220505081640.17425-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure a reserved grant is never put on the free list, as this could cause hard to debug errors. Signed-off-by: Juergen Gross --- V3: - new patch --- drivers/xen/grant-table.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 6ea31ea26008..1a1aec0a88a1 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -207,6 +207,10 @@ static inline void check_free_callbacks(void) static void put_free_entry(grant_ref_t ref) { unsigned long flags; + + if (unlikely(ref < GNTTAB_NR_RESERVED_ENTRIES)) + return; + spin_lock_irqsave(&gnttab_list_lock, flags); gnttab_entry(ref) = gnttab_free_head; gnttab_free_head = ref; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321667.542736 (Exim 4.92) (envelope-from ) id 1nmWfK-0002SE-9l; Thu, 05 May 2022 08:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321667.542736; Thu, 05 May 2022 08:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfJ-0002QT-UW; Thu, 05 May 2022 08:16:49 +0000 Received: by outflank-mailman (input) for mailman id 321667; Thu, 05 May 2022 08:16:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfI-0001qT-Nb for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:48 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b31efa47-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD1AE1F37F; Thu, 5 May 2022 08:16:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D03F13B11; Thu, 5 May 2022 08:16:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QqHGAeuHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b31efa47-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+rG3u9WN3fpKsJ0oR6FOTx9SGcpcZNwJpHRZoiitWn0=; b=iZYfwDJOH3Rm9o+MLXSeu50EFMfd04XPhuJ/CB2/T6Z6DRtP11UcKJwcKyHntgX/sKa2RI CH6o5/RIWxX7F43gvAY3CXkLN0l6PCPqFBQnpY4226kszreGPap8IbAxANXT9XN+5OGMsS 82Q6oURWAFQNrJrP+mu5LGGeKvQm574= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, linux-pci@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Axboe , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Bjorn Helgaas Subject: [PATCH v3 00/21] xen: simplify frontend side ring setup Date: Thu, 5 May 2022 10:16:19 +0200 Message-Id: <20220505081640.17425-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Many Xen PV frontends share similar code for setting up a ring page (allocating and granting access for the backend) and for tearing it down. Create new service functions doing all needed steps in one go. This requires all frontends to use a common value for an invalid grant reference in order to make the functions idempotent. Changes in V3: - new patches 1 and 2, comments addressed Changes in V2: - new patch 9 and related changes in patches 10-18 Juergen Gross (21): xen: update grant_table.h xen/grant-table: never put a reserved grant on the free list xen/blkfront: switch blkfront to use INVALID_GRANT_REF xen/netfront: switch netfront to use INVALID_GRANT_REF xen/scsifront: remove unused GRANT_INVALID_REF definition xen/usb: switch xen-hcd to use INVALID_GRANT_REF xen/drm: switch xen_drm_front to use INVALID_GRANT_REF xen/sound: switch xen_snd_front to use INVALID_GRANT_REF xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF xen: update ring.h xen/xenbus: add xenbus_setup_ring() service function xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/xenbus: eliminate xenbus_grant_ring() drivers/block/xen-blkfront.c | 57 +++---- drivers/char/tpm/xen-tpmfront.c | 18 +-- drivers/gpu/drm/xen/xen_drm_front.h | 9 -- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++---- drivers/net/xen-netfront.c | 85 ++++------- drivers/pci/xen-pcifront.c | 19 +-- drivers/scsi/xen-scsifront.c | 31 +--- drivers/usb/host/xen-hcd.c | 65 ++------ drivers/xen/gntdev-dmabuf.c | 13 +- drivers/xen/grant-table.c | 12 +- drivers/xen/xen-front-pgdir-shbuf.c | 18 +-- drivers/xen/xenbus/xenbus_client.c | 82 +++++++--- include/xen/grant_table.h | 2 - include/xen/interface/grant_table.h | 161 ++++++++++++-------- include/xen/interface/io/ring.h | 19 ++- include/xen/xenbus.h | 4 +- sound/xen/xen_snd_front_evtchnl.c | 44 ++---- sound/xen/xen_snd_front_evtchnl.h | 9 -- 18 files changed, 287 insertions(+), 404 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321669.542763 (Exim 4.92) (envelope-from ) id 1nmWfM-0003BD-Ug; Thu, 05 May 2022 08:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321669.542763; Thu, 05 May 2022 08:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfM-00036l-G3; Thu, 05 May 2022 08:16:52 +0000 Received: by outflank-mailman (input) for mailman id 321669; Thu, 05 May 2022 08:16:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfJ-0001qT-NB for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3d7f15a-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3969B1F88B; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E496F13B11; Thu, 5 May 2022 08:16:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iMNpNuyHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3d7f15a-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+7CMtprq6730KQODSTXPIsn2CRUJgb2Tt/M0T6KuL48=; b=Q2+/LfYrDGupnXadg7i13kivgfkB4z78xXa2vTrESCx1cXyAPfEcMcie1z+7R0euXijjcM vw4QUlQh0InKyhg1f3MxDpMjPVc1uSit3MGRMu5iswkPMFFQOxRbo897oUllJDl9kUPf0r bFhchb8fTC55lJqtirWiVOUmJD46sT4= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "James E.J. Bottomley" , "Martin K. Petersen" Subject: [PATCH v3 05/21] xen/scsifront: remove unused GRANT_INVALID_REF definition Date: Thu, 5 May 2022 10:16:24 +0200 Message-Id: <20220505081640.17425-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit GRANT_INVALID_REF isn't used in scsifront, so remove it. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 56173beecbc6..4c55e479fc36 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -58,9 +58,6 @@ #include - -#define GRANT_INVALID_REF 0 - #define VSCSIFRONT_OP_ADD_LUN 1 #define VSCSIFRONT_OP_DEL_LUN 2 #define VSCSIFRONT_OP_READD_LUN 3 -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321670.542774 (Exim 4.92) (envelope-from ) id 1nmWfN-0003MF-UG; Thu, 05 May 2022 08:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321670.542774; Thu, 05 May 2022 08:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfN-0003Hz-9Z; Thu, 05 May 2022 08:16:53 +0000 Received: by outflank-mailman (input) for mailman id 321670; Thu, 05 May 2022 08:16:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfK-0001o5-Ap for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4b17495-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF08821871; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 696DF13B11; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EKRqGO6Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4b17495-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NOtG87ytP6Jh5NCmFkub01f6OJcOR1V96rvCSE+C7vA=; b=rgjzT37HswzabuodndnNoAIBhcaV9Yg3557K0ICQL/jluev/EsR89xbFX9PZQizcwOrRYi PnFyHFkLNAbjfh3DXofOl4AODH8F7yCKDyv5ztM0DC+tE08tp28mCbuOhVYzzZFRUHiS39 DfP4Pmh6ZCTaySti8VzrjWisi+VBWA8= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v3 11/21] xen: update ring.h Date: Thu, 5 May 2022 10:16:30 +0200 Message-Id: <20220505081640.17425-12-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update include/xen/interface/io/ring.h to its newest version. Switch the two improper use cases of RING_HAS_UNCONSUMED_RESPONSES() to XEN_RING_NR_UNCONSUMED_RESPONSES() in order to avoid the nasty XEN_RING_HAS_UNCONSUMED_IS_BOOL #define. Signed-off-by: Juergen Gross --- V2: - new patch --- drivers/net/xen-netfront.c | 4 ++-- include/xen/interface/io/ring.h | 19 ++++++++++++++----- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index af3d3de7d9fa..966bee2a6902 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -866,7 +866,7 @@ static void xennet_set_rx_rsp_cons(struct netfront_queue *queue, RING_IDX val) spin_lock_irqsave(&queue->rx_cons_lock, flags); queue->rx.rsp_cons = val; - queue->rx_rsp_unconsumed = RING_HAS_UNCONSUMED_RESPONSES(&queue->rx); + queue->rx_rsp_unconsumed = XEN_RING_NR_UNCONSUMED_RESPONSES(&queue->rx); spin_unlock_irqrestore(&queue->rx_cons_lock, flags); } @@ -1498,7 +1498,7 @@ static bool xennet_handle_rx(struct netfront_queue *queue, unsigned int *eoi) return false; spin_lock_irqsave(&queue->rx_cons_lock, flags); - work_queued = RING_HAS_UNCONSUMED_RESPONSES(&queue->rx); + work_queued = XEN_RING_NR_UNCONSUMED_RESPONSES(&queue->rx); if (work_queued > queue->rx_rsp_unconsumed) { queue->rx_rsp_unconsumed = work_queued; *eoi = 0; diff --git a/include/xen/interface/io/ring.h b/include/xen/interface/io/ring.h index 2470ec45ebb2..ba4c4274b714 100644 --- a/include/xen/interface/io/ring.h +++ b/include/xen/interface/io/ring.h @@ -72,9 +72,8 @@ typedef unsigned int RING_IDX; * of the shared memory area (PAGE_SIZE, for instance). To initialise * the front half: * - * mytag_front_ring_t front_ring; - * SHARED_RING_INIT((mytag_sring_t *)shared_page); - * FRONT_RING_INIT(&front_ring, (mytag_sring_t *)shared_page, PAGE_SIZE); + * mytag_front_ring_t ring; + * XEN_FRONT_RING_INIT(&ring, (mytag_sring_t *)shared_page, PAGE_SIZE); * * Initializing the back follows similarly (note that only the front * initializes the shared ring): @@ -146,6 +145,11 @@ struct __name##_back_ring { \ #define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size) +#define XEN_FRONT_RING_INIT(r, s, size) do { \ + SHARED_RING_INIT(s); \ + FRONT_RING_INIT(r, s, size); \ +} while (0) + #define BACK_RING_ATTACH(_r, _s, _i, __size) do { \ (_r)->rsp_prod_pvt = (_i); \ (_r)->req_cons = (_i); \ @@ -170,16 +174,21 @@ struct __name##_back_ring { \ (RING_FREE_REQUESTS(_r) == 0) /* Test if there are outstanding messages to be processed on a ring. */ -#define RING_HAS_UNCONSUMED_RESPONSES(_r) \ +#define XEN_RING_NR_UNCONSUMED_RESPONSES(_r) \ ((_r)->sring->rsp_prod - (_r)->rsp_cons) -#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({ \ +#define XEN_RING_NR_UNCONSUMED_REQUESTS(_r) ({ \ unsigned int req = (_r)->sring->req_prod - (_r)->req_cons; \ unsigned int rsp = RING_SIZE(_r) - \ ((_r)->req_cons - (_r)->rsp_prod_pvt); \ req < rsp ? req : rsp; \ }) +#define RING_HAS_UNCONSUMED_RESPONSES(_r) \ + (!!XEN_RING_NR_UNCONSUMED_RESPONSES(_r)) +#define RING_HAS_UNCONSUMED_REQUESTS(_r) \ + (!!XEN_RING_NR_UNCONSUMED_REQUESTS(_r)) + /* Direct access to individual ring elements, by index. */ #define RING_GET_REQUEST(_r, _idx) \ (&((_r)->sring->ring[((_idx) & (RING_SIZE(_r) - 1))].req)) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321671.542782 (Exim 4.92) (envelope-from ) id 1nmWfO-0003Zw-Ve; Thu, 05 May 2022 08:16:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321671.542782; Thu, 05 May 2022 08:16:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfO-0003Vg-C6; Thu, 05 May 2022 08:16:54 +0000 Received: by outflank-mailman (input) for mailman id 321671; Thu, 05 May 2022 08:16:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfK-0001qT-NH for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3f1c427-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F7012129A; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3FEC413B11; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WPtXDu2Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3f1c427-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40GR81qLBAKpQ1pdFfw5ZbcFKNAIeNjaSwOGqddCksA=; b=EYWTHAdH5RBPO4czJu3WhK/zfuAs3DPsQSFX7ShogW2nC4Y+RSVboPlZrXxv7vWz6rPt4r hH6yrF93UKdeG02In73kBwMr+ScCL3WB97iWJbmhTeE3jQIFTITqOW8UWBzubf6sOu4oSJ NLeFPsnT2hA+8Ihi6gyc0hhiGm3PHGg= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Greg Kroah-Hartman Subject: [PATCH v3 06/21] xen/usb: switch xen-hcd to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:25 +0200 Message-Id: <20220505081640.17425-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c index 3e487baf8422..9cbc7c2dab02 100644 --- a/drivers/usb/host/xen-hcd.c +++ b/drivers/usb/host/xen-hcd.c @@ -87,8 +87,6 @@ struct xenhcd_info { bool error; }; -#define GRANT_INVALID_REF 0 - #define XENHCD_RING_JIFFIES (HZ/200) #define XENHCD_SCAN_JIFFIES 1 @@ -1100,17 +1098,17 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info) unbind_from_irqhandler(info->irq, info); info->irq = 0; - if (info->urb_ring_ref != GRANT_INVALID_REF) { + if (info->urb_ring_ref != INVALID_GRANT_REF) { gnttab_end_foreign_access(info->urb_ring_ref, (unsigned long)info->urb_ring.sring); - info->urb_ring_ref = GRANT_INVALID_REF; + info->urb_ring_ref = INVALID_GRANT_REF; } info->urb_ring.sring = NULL; - if (info->conn_ring_ref != GRANT_INVALID_REF) { + if (info->conn_ring_ref != INVALID_GRANT_REF) { gnttab_end_foreign_access(info->conn_ring_ref, (unsigned long)info->conn_ring.sring); - info->conn_ring_ref = GRANT_INVALID_REF; + info->conn_ring_ref = INVALID_GRANT_REF; } info->conn_ring.sring = NULL; } @@ -1123,8 +1121,8 @@ static int xenhcd_setup_rings(struct xenbus_device *dev, grant_ref_t gref; int err; - info->urb_ring_ref = GRANT_INVALID_REF; - info->conn_ring_ref = GRANT_INVALID_REF; + info->urb_ring_ref = INVALID_GRANT_REF; + info->conn_ring_ref = INVALID_GRANT_REF; urb_sring = (struct xenusb_urb_sring *)get_zeroed_page( GFP_NOIO | __GFP_HIGH); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321673.542792 (Exim 4.92) (envelope-from ) id 1nmWfQ-0003uC-9W; Thu, 05 May 2022 08:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321673.542792; Thu, 05 May 2022 08:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfP-0003rY-Iv; Thu, 05 May 2022 08:16:55 +0000 Received: by outflank-mailman (input) for mailman id 321673; Thu, 05 May 2022 08:16:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfL-0001qT-Nh for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b462e9cb-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30DBD210E7; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 029DD13B11; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oL34Ou2Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b462e9cb-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HbhUc4kkAgjpJllqUuyWzZXVZYGf9QqSKvPktQD9iyQ=; b=rHPzp9Pc6VbGCmz1ZS7ybs1DGkH3gmX3BoOpGkieYlTPAbhcH+NHvsmWQu1WFVL2naVmuD eKYWr1PLWsZCQ3Omym3VkvbUaP3GMXNXjdA0XGexieKFIIVo1g52oQFiGzHlDuSPuhIYNg IhZV2NcAdYXhYHVPq+TJP5OWPIz6AE8= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v3 09/21] xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:28 +0200 Message-Id: <20220505081640.17425-10-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/xen/gntdev-dmabuf.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c index d5bfd7b867fc..91073b4e4a20 100644 --- a/drivers/xen/gntdev-dmabuf.c +++ b/drivers/xen/gntdev-dmabuf.c @@ -24,15 +24,6 @@ MODULE_IMPORT_NS(DMA_BUF); -#ifndef GRANT_INVALID_REF -/* - * Note on usage of grant reference 0 as invalid grant reference: - * grant reference 0 is valid, but never exposed to a driver, - * because of the fact it is already in use/reserved by the PV console. - */ -#define GRANT_INVALID_REF 0 -#endif - struct gntdev_dmabuf { struct gntdev_dmabuf_priv *priv; struct dma_buf *dmabuf; @@ -532,7 +523,7 @@ static void dmabuf_imp_end_foreign_access(u32 *refs, int count) int i; for (i = 0; i < count; i++) - if (refs[i] != GRANT_INVALID_REF) + if (refs[i] != INVALID_GRANT_REF) gnttab_end_foreign_access(refs[i], 0UL); } @@ -567,7 +558,7 @@ static struct gntdev_dmabuf *dmabuf_imp_alloc_storage(int count) gntdev_dmabuf->nr_pages = count; for (i = 0; i < count; i++) - gntdev_dmabuf->u.imp.refs[i] = GRANT_INVALID_REF; + gntdev_dmabuf->u.imp.refs[i] = INVALID_GRANT_REF; return gntdev_dmabuf; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321672.542803 (Exim 4.92) (envelope-from ) id 1nmWfR-0004CL-Lj; Thu, 05 May 2022 08:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321672.542803; Thu, 05 May 2022 08:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfQ-00045C-NB; Thu, 05 May 2022 08:16:56 +0000 Received: by outflank-mailman (input) for mailman id 321672; Thu, 05 May 2022 08:16:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfL-0001o5-Ax for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:51 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b53264fd-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 887BE1F8A4; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 404C813B11; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wBleDu+Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b53264fd-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M6eg+rFc1MumAtFExaebcTMQjlP8JRCZ6MaTwnyhXTA=; b=PRWXK75Iy6glOCFP+BRMxBlVtN2eHikrFDyCXtCZLSYh/NlKtBEhjsX7rYe7cPq6dpCFly qvF85uuWPEVq+aRqbBWAp2SNiiVWB76NOqlqkde8eV21BTItvL14AtMhA40lzTs2DmU8P+ I7XPM8jeaQbxgQQTxLE8bS2JFHwffU0= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v3 14/21] xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:33 +0200 Message-Id: <20220505081640.17425-15-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify netfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/net/xen-netfront.c | 53 +++++++++----------------------------- 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 966bee2a6902..65ab907aca5a 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1921,8 +1921,7 @@ static int setup_netfront(struct xenbus_device *dev, struct netfront_queue *queue, unsigned int feature_split_evtchn) { struct xen_netif_tx_sring *txs; - struct xen_netif_rx_sring *rxs = NULL; - grant_ref_t gref; + struct xen_netif_rx_sring *rxs; int err; queue->tx_ring_ref = INVALID_GRANT_REF; @@ -1930,33 +1929,19 @@ static int setup_netfront(struct xenbus_device *dev, queue->rx.sring = NULL; queue->tx.sring = NULL; - txs = (struct xen_netif_tx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH); - if (!txs) { - err = -ENOMEM; - xenbus_dev_fatal(dev, err, "allocating tx ring page"); + err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&txs, + 1, &queue->tx_ring_ref); + if (err) goto fail; - } - SHARED_RING_INIT(txs); - FRONT_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE); - err = xenbus_grant_ring(dev, txs, 1, &gref); - if (err < 0) - goto fail; - queue->tx_ring_ref = gref; + XEN_FRONT_RING_INIT(&queue->tx, txs, XEN_PAGE_SIZE); - rxs = (struct xen_netif_rx_sring *)get_zeroed_page(GFP_NOIO | __GFP_HIGH); - if (!rxs) { - err = -ENOMEM; - xenbus_dev_fatal(dev, err, "allocating rx ring page"); + err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, (void **)&rxs, + 1, &queue->rx_ring_ref); + if (err) goto fail; - } - SHARED_RING_INIT(rxs); - FRONT_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE); - err = xenbus_grant_ring(dev, rxs, 1, &gref); - if (err < 0) - goto fail; - queue->rx_ring_ref = gref; + XEN_FRONT_RING_INIT(&queue->rx, rxs, XEN_PAGE_SIZE); if (feature_split_evtchn) err = setup_netfront_split(queue); @@ -1972,24 +1957,10 @@ static int setup_netfront(struct xenbus_device *dev, return 0; - /* If we fail to setup netfront, it is safe to just revoke access to - * granted pages because backend is not accessing it at this point. - */ fail: - if (queue->rx_ring_ref != INVALID_GRANT_REF) { - gnttab_end_foreign_access(queue->rx_ring_ref, - (unsigned long)rxs); - queue->rx_ring_ref = INVALID_GRANT_REF; - } else { - free_page((unsigned long)rxs); - } - if (queue->tx_ring_ref != INVALID_GRANT_REF) { - gnttab_end_foreign_access(queue->tx_ring_ref, - (unsigned long)txs); - queue->tx_ring_ref = INVALID_GRANT_REF; - } else { - free_page((unsigned long)txs); - } + xenbus_teardown_ring((void **)&queue->rx.sring, 1, &queue->rx_ring_ref); + xenbus_teardown_ring((void **)&queue->tx.sring, 1, &queue->tx_ring_ref); + return err; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:16:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:16:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321675.542811 (Exim 4.92) (envelope-from ) id 1nmWfS-0004Qe-Rd; Thu, 05 May 2022 08:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321675.542811; Thu, 05 May 2022 08:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfR-0004Mz-QJ; Thu, 05 May 2022 08:16:57 +0000 Received: by outflank-mailman (input) for mailman id 321675; Thu, 05 May 2022 08:16:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfM-0001qT-NY for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4194cc7-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AD77B1F891; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 75BD113B11; Thu, 5 May 2022 08:16:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GKd6G+2Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4194cc7-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738605; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6ggN2balHjG5CI3jRk1VrmRzP8B/Nm2ztrH3YOWGCk=; b=helWnP73V72ZSHcX1/aibZU8SheuDic0cwyuSMwpOutceVsMy58aFEH/CDLZXrGoidt9BX 7t+UwBsoDdE6odBOC2KMcJdtaJihm/5I7y8lbWp4Q7bOuuFSRsLN6jJbVGWTBEd9nduCyW hil4J+m7kbB57nwtL9W34PEnDiV3IrU= From: Juergen Gross To: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Andrushchenko , David Airlie , Daniel Vetter Subject: [PATCH v3 07/21] xen/drm: switch xen_drm_front to use INVALID_GRANT_REF Date: Thu, 5 May 2022 10:16:26 +0200 Message-Id: <20220505081640.17425-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front.h | 9 --------- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h index cefafe859aba..a987c78abe41 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.h +++ b/drivers/gpu/drm/xen/xen_drm_front.h @@ -80,15 +80,6 @@ struct drm_pending_vblank_event; /* timeout in ms to wait for backend to respond */ #define XEN_DRM_FRONT_WAIT_BACK_MS 3000 -#ifndef GRANT_INVALID_REF -/* - * Note on usage of grant reference 0 as invalid grant reference: - * grant reference 0 is valid, but never exposed to a PV driver, - * because of the fact it is already in use/reserved by the PV console. - */ -#define GRANT_INVALID_REF 0 -#endif - struct xen_drm_front_info { struct xenbus_device *xb_dev; struct xen_drm_front_drm_info *drm_info; diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c index 08b526eeec16..4006568b9e32 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c +++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c @@ -147,7 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info, xenbus_free_evtchn(front_info->xb_dev, evtchnl->port); /* end access and free the page */ - if (evtchnl->gref != GRANT_INVALID_REF) + if (evtchnl->gref != INVALID_GRANT_REF) gnttab_end_foreign_access(evtchnl->gref, page); memset(evtchnl, 0, sizeof(*evtchnl)); @@ -168,7 +168,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index, evtchnl->index = index; evtchnl->front_info = front_info; evtchnl->state = EVTCHNL_STATE_DISCONNECTED; - evtchnl->gref = GRANT_INVALID_REF; + evtchnl->gref = INVALID_GRANT_REF; page = get_zeroed_page(GFP_NOIO | __GFP_HIGH); if (!page) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321674.542819 (Exim 4.92) (envelope-from ) id 1nmWfU-0004i7-IB; Thu, 05 May 2022 08:17:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321674.542819; Thu, 05 May 2022 08:17:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfT-0004db-4E; Thu, 05 May 2022 08:16:59 +0000 Received: by outflank-mailman (input) for mailman id 321674; Thu, 05 May 2022 08:16:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfM-0001o5-B1 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4d2a2ac-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E5F9F1F895; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B70D213B11; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CFNgK+6Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4d2a2ac-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yFjXHXMXwZa6Ccja7xlX/k6b/j03dysFoZbs8/tSS0=; b=tZpw7w2YZs7zI4Wv0ZhcBunFcpmESyHgadFim0wkQdlTZDZz7ZNdx1QNcQvdlPsvcwlSM2 QWD8TVciM+/T64Fk45IKVJjeUCiDTZIQ8t9ZdDRgywz13/SQqfAoPJSygm1LjbV/XUYDrk 5x1A1Gezd16QvlIB5qynYPOvcggWS7A= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini Subject: [PATCH v3 12/21] xen/xenbus: add xenbus_setup_ring() service function Date: Thu, 5 May 2022 10:16:31 +0200 Message-Id: <20220505081640.17425-13-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Most PV device frontends share very similar code for setting up shared ring buffers: - allocate page(s) - init the ring admin data - give the backend access to the ring via grants Tearing down the ring requires similar actions in all frontends again: - remove grants - free the page(s) Provide service functions xenbus_setup_ring() and xenbus_teardown_ring() for that purpose. Signed-off-by: Juergen Gross --- drivers/xen/xenbus/xenbus_client.c | 69 ++++++++++++++++++++++++++++++ include/xen/xenbus.h | 4 ++ 2 files changed, 73 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index df6890681231..1a2e0d94ccd1 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -407,6 +407,75 @@ int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr, } EXPORT_SYMBOL_GPL(xenbus_grant_ring); +/* + * xenbus_setup_ring + * @dev: xenbus device + * @vaddr: pointer to starting virtual address of the ring + * @nr_pages: number of pages to be granted + * @grefs: grant reference array to be filled in + * + * Allocate physically contiguous pages for a shared ring buffer and grant it + * to the peer of the given device. The ring buffer is initially filled with + * zeroes. The virtual address of the ring is stored at @vaddr and the + * grant references are stored in the @grefs array. In case of error @vaddr + * will be set to NULL and @grefs will be filled with INVALID_GRANT_REF. + */ +int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, + unsigned int nr_pages, grant_ref_t *grefs) +{ + unsigned long ring_size = nr_pages * XEN_PAGE_SIZE; + unsigned int i; + int ret; + + *vaddr = alloc_pages_exact(ring_size, gfp | __GFP_ZERO); + if (!*vaddr) { + ret = -ENOMEM; + goto err; + } + + ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs); + if (ret) + goto err; + + return 0; + + err: + if (*vaddr) + free_pages_exact(*vaddr, ring_size); + for (i = 0; i < nr_pages; i++) + grefs[i] = INVALID_GRANT_REF; + *vaddr = NULL; + + return ret; +} +EXPORT_SYMBOL_GPL(xenbus_setup_ring); + +/* + * xenbus_teardown_ring + * @vaddr: starting virtual address of the ring + * @nr_pages: number of pages + * @grefs: grant reference array + * + * Remove grants for the shared ring buffer and free the associated memory. + * On return the grant reference array is filled with INVALID_GRANT_REF. + */ +void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages, + grant_ref_t *grefs) +{ + unsigned int i; + + for (i = 0; i < nr_pages; i++) { + if (grefs[i] != INVALID_GRANT_REF) { + gnttab_end_foreign_access(grefs[i], 0); + grefs[i] = INVALID_GRANT_REF; + } + } + + if (*vaddr) + free_pages_exact(*vaddr, nr_pages * XEN_PAGE_SIZE); + *vaddr = NULL; +} +EXPORT_SYMBOL_GPL(xenbus_teardown_ring); /** * Allocate an event channel for the given xenbus_device, assigning the newly diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index b13eb86395e0..b533b4adc835 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -226,6 +226,10 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch, int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state); int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr, unsigned int nr_pages, grant_ref_t *grefs); +int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, + unsigned int nr_pages, grant_ref_t *grefs); +void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages, + grant_ref_t *grefs); int xenbus_map_ring_valloc(struct xenbus_device *dev, grant_ref_t *gnt_refs, unsigned int nr_grefs, void **vaddr); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321676.542830 (Exim 4.92) (envelope-from ) id 1nmWfW-00050h-7J; Thu, 05 May 2022 08:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321676.542830; Thu, 05 May 2022 08:17:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfU-0004xu-OE; Thu, 05 May 2022 08:17:00 +0000 Received: by outflank-mailman (input) for mailman id 321676; Thu, 05 May 2022 08:16:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfN-0001o5-BB for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5a69cf7-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 527911F896; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BA3413B11; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SE5QBfCHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5a69cf7-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZPJLwAsgzNCCroRjeE9JafH9BIwjuth4vqOa5N14pw=; b=L9AkWL0xVkfyaETjQQnwkqUS5khHtDMf+yhkFrQWWVGL/FhZgqSqJiD6oFcqjNRK/K9rtz 6R8uVePLGLABT2Xwd4pNjgXpVO+mNjheueg8SMDJ1wu3KzgWpc+QQ1S9WmzuZ1sM5HFo3U g/h5qKh9aDov7yLDD/Pzd+iMPkafJ5k= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Bjorn Helgaas Subject: [PATCH v3 17/21] xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:36 +0200 Message-Id: <20220505081640.17425-18-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify pcifront's shared page creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/pci/xen-pcifront.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index 3edc1565a27c..689271c4245c 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -709,9 +709,8 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev) if (pdev == NULL) goto out; - pdev->sh_info = - (struct xen_pci_sharedinfo *)__get_free_page(GFP_KERNEL); - if (pdev->sh_info == NULL) { + if (xenbus_setup_ring(xdev, GFP_KERNEL, (void **)&pdev->sh_info, 1, + &pdev->gnt_ref)) { kfree(pdev); pdev = NULL; goto out; @@ -729,7 +728,6 @@ static struct pcifront_device *alloc_pdev(struct xenbus_device *xdev) spin_lock_init(&pdev->sh_info_lock); pdev->evtchn = INVALID_EVTCHN; - pdev->gnt_ref = INVALID_GRANT_REF; pdev->irq = -1; INIT_WORK(&pdev->op_work, pcifront_do_aer); @@ -754,11 +752,7 @@ static void free_pdev(struct pcifront_device *pdev) if (pdev->evtchn != INVALID_EVTCHN) xenbus_free_evtchn(pdev->xdev, pdev->evtchn); - if (pdev->gnt_ref != INVALID_GRANT_REF) - gnttab_end_foreign_access(pdev->gnt_ref, - (unsigned long)pdev->sh_info); - else - free_page((unsigned long)pdev->sh_info); + xenbus_teardown_ring((void **)&pdev->sh_info, 1, &pdev->gnt_ref); dev_set_drvdata(&pdev->xdev->dev, NULL); @@ -769,13 +763,6 @@ static int pcifront_publish_info(struct pcifront_device *pdev) { int err = 0; struct xenbus_transaction trans; - grant_ref_t gref; - - err = xenbus_grant_ring(pdev->xdev, pdev->sh_info, 1, &gref); - if (err < 0) - goto out; - - pdev->gnt_ref = gref; err = xenbus_alloc_evtchn(pdev->xdev, &pdev->evtchn); if (err) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321677.542836 (Exim 4.92) (envelope-from ) id 1nmWfX-0005Et-6N; Thu, 05 May 2022 08:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321677.542836; Thu, 05 May 2022 08:17:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfV-000580-OZ; Thu, 05 May 2022 08:17:01 +0000 Received: by outflank-mailman (input) for mailman id 321677; Thu, 05 May 2022 08:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfN-0001qT-Nu for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4ff8518-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 37EDF2186F; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED19B13B11; Thu, 5 May 2022 08:16:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mEeNOO6Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4ff8518-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUFvPpZ+oh+I9lruBO51qkEJU8XZSf+Prfa9vNAfD4o=; b=RYSQ8JFtt7g+QL1lPmO44RO9WuQtxDFHNcWhV9LQmmzP+qFc/I5gcomwpavuHenseioV94 /ToMKaMYHhmxtL6brZ94XA4T42D3tUBUIQYIaj/77wHBPTJxtAZoJ6Phi6kIFSXMdQx40T R9TSSP1SL5v99dQ6Wa6XXsWqGcEUCvA= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Boris Ostrovsky , Stefano Stabellini , Jens Axboe Subject: [PATCH v3 13/21] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:32 +0200 Message-Id: <20220505081640.17425-14-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify blkfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 37 ++++++++---------------------------- 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 7f35e30e626a..bd7b34f29193 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1280,15 +1280,8 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) flush_work(&rinfo->work); /* Free resources associated with old device channel. */ - for (i = 0; i < info->nr_ring_pages; i++) { - if (rinfo->ring_ref[i] != INVALID_GRANT_REF) { - gnttab_end_foreign_access(rinfo->ring_ref[i], 0); - rinfo->ring_ref[i] = INVALID_GRANT_REF; - } - } - free_pages_exact(rinfo->ring.sring, - info->nr_ring_pages * XEN_PAGE_SIZE); - rinfo->ring.sring = NULL; + xenbus_teardown_ring((void **)&rinfo->ring.sring, info->nr_ring_pages, + rinfo->ring_ref); if (rinfo->irq) unbind_from_irqhandler(rinfo->irq, rinfo); @@ -1679,30 +1672,16 @@ static int setup_blkring(struct xenbus_device *dev, struct blkfront_ring_info *rinfo) { struct blkif_sring *sring; - int err, i; + int err; struct blkfront_info *info = rinfo->dev_info; unsigned long ring_size = info->nr_ring_pages * XEN_PAGE_SIZE; - grant_ref_t gref[XENBUS_MAX_RING_GRANTS]; - - for (i = 0; i < info->nr_ring_pages; i++) - rinfo->ring_ref[i] = INVALID_GRANT_REF; - sring = alloc_pages_exact(ring_size, GFP_NOIO); - if (!sring) { - xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring"); - return -ENOMEM; - } - SHARED_RING_INIT(sring); - FRONT_RING_INIT(&rinfo->ring, sring, ring_size); - - err = xenbus_grant_ring(dev, rinfo->ring.sring, info->nr_ring_pages, gref); - if (err < 0) { - free_pages_exact(sring, ring_size); - rinfo->ring.sring = NULL; + err = xenbus_setup_ring(dev, GFP_NOIO, (void **)&sring, + info->nr_ring_pages, rinfo->ring_ref); + if (err) goto fail; - } - for (i = 0; i < info->nr_ring_pages; i++) - rinfo->ring_ref[i] = gref[i]; + + XEN_FRONT_RING_INIT(&rinfo->ring, sring, ring_size); err = xenbus_alloc_evtchn(dev, &rinfo->evtchn); if (err) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321678.542852 (Exim 4.92) (envelope-from ) id 1nmWfa-0005xD-55; Thu, 05 May 2022 08:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321678.542852; Thu, 05 May 2022 08:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfY-0005oe-Vf; Thu, 05 May 2022 08:17:04 +0000 Received: by outflank-mailman (input) for mailman id 321678; Thu, 05 May 2022 08:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfO-0001qT-OA for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5599068-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5D41210DF; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E7AD13B12; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iP9gIe+Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5599068-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738607; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CBDkywWrMTWS4hJ++nC6A/5fx/cpBVFJCY9cboe51eI=; b=OEjJij1fp5lh4IRX8e9PkSZvFNrlGEYuIQSutmEO+TvPqFZXcgCap5W1giZv0lvoVKgGni BS2MmSOX7SimDLZiVLSOxL7uf/YU1PzAeNCyDghPW9RcDxXya8DHpSwXv98HH1ATacpLgT d9CEKt/6bV7Wm3zIeR43ugE9p4xvL1M= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe Subject: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:34 +0200 Message-Id: <20220505081640.17425-16-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify tpmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/char/tpm/xen-tpmfront.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index 69df04ae2401..379291826261 100644 --- a/drivers/char/tpm/xen-tpmfront.c +++ b/drivers/char/tpm/xen-tpmfront.c @@ -253,20 +253,12 @@ static int setup_ring(struct xenbus_device *dev, struct tpm_private *priv) struct xenbus_transaction xbt; const char *message = NULL; int rv; - grant_ref_t gref; - priv->shr = (void *)__get_free_page(GFP_KERNEL|__GFP_ZERO); - if (!priv->shr) { - xenbus_dev_fatal(dev, -ENOMEM, "allocating shared ring"); - return -ENOMEM; - } - - rv = xenbus_grant_ring(dev, priv->shr, 1, &gref); + rv = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&priv->shr, 1, + &priv->ring_ref); if (rv < 0) return rv; - priv->ring_ref = gref; - rv = xenbus_alloc_evtchn(dev, &priv->evtchn); if (rv) return rv; @@ -331,11 +323,7 @@ static void ring_free(struct tpm_private *priv) if (!priv) return; - if (priv->ring_ref) - gnttab_end_foreign_access(priv->ring_ref, - (unsigned long)priv->shr); - else - free_page((unsigned long)priv->shr); + xenbus_teardown_ring((void **)&priv->shr, 1, &priv->ring_ref); if (priv->irq) unbind_from_irqhandler(priv->irq, priv); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321679.542860 (Exim 4.92) (envelope-from ) id 1nmWfb-0006Mw-Ow; Thu, 05 May 2022 08:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321679.542860; Thu, 05 May 2022 08:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfa-0006CY-Q2; Thu, 05 May 2022 08:17:06 +0000 Received: by outflank-mailman (input) for mailman id 321679; Thu, 05 May 2022 08:16:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfO-0001o5-BW for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5d1a77d-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 946131F8A3; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A8A413B11; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IM5DFPCHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5d1a77d-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0MG5If+wT1PFlFjSpPM4l/2JLJ70ISQLhBhO24AmiRY=; b=jySglPOM/qmId9veILCMfWbXmbLP+gNn4u7XEfWwcN1T4/oJO4hATS7eTV+0YsaVudLyFb aYaRxPRl6knBSXtSBo/g/lmKCyGWWV5cbs786fWksp1RjeOLzvSNCVsHa/oH4L1QHJObdw 88zVG8kaKeockHaPdWQ38AjKWsWoiqY= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "James E.J. Bottomley" , "Martin K. Petersen" Subject: [PATCH v3 18/21] xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:37 +0200 Message-Id: <20220505081640.17425-19-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify scsifront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 4c55e479fc36..51afc66e839d 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -798,27 +798,15 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info) { struct xenbus_device *dev = info->dev; struct vscsiif_sring *sring; - grant_ref_t gref; - int err = -ENOMEM; + int err; /***** Frontend to Backend ring start *****/ - sring = (struct vscsiif_sring *)__get_free_page(GFP_KERNEL); - if (!sring) { - xenbus_dev_fatal(dev, err, - "fail to allocate shared ring (Front to Back)"); + err = xenbus_setup_ring(dev, GFP_KERNEL, (void **)&sring, 1, + &info->ring_ref); + if (err) return err; - } - SHARED_RING_INIT(sring); - FRONT_RING_INIT(&info->ring, sring, PAGE_SIZE); - err = xenbus_grant_ring(dev, sring, 1, &gref); - if (err < 0) { - free_page((unsigned long)sring); - xenbus_dev_fatal(dev, err, - "fail to grant shared ring (Front to Back)"); - return err; - } - info->ring_ref = gref; + XEN_FRONT_RING_INIT(&info->ring, sring, PAGE_SIZE); err = xenbus_alloc_evtchn(dev, &info->evtchn); if (err) { @@ -847,8 +835,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info) free_irq: unbind_from_irqhandler(info->irq, info); free_gnttab: - gnttab_end_foreign_access(info->ring_ref, - (unsigned long)info->ring.sring); + xenbus_teardown_ring((void **)&sring, 1, &info->ring_ref); return err; } @@ -856,8 +843,7 @@ static int scsifront_alloc_ring(struct vscsifrnt_info *info) static void scsifront_free_ring(struct vscsifrnt_info *info) { unbind_from_irqhandler(info->irq, info); - gnttab_end_foreign_access(info->ring_ref, - (unsigned long)info->ring.sring); + xenbus_teardown_ring((void **)&info->ring.sring, 1, &info->ring_ref); } static int scsifront_init_ring(struct vscsifrnt_info *info) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321680.542871 (Exim 4.92) (envelope-from ) id 1nmWfe-00071r-FC; Thu, 05 May 2022 08:17:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321680.542871; Thu, 05 May 2022 08:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfd-0006tu-4h; Thu, 05 May 2022 08:17:09 +0000 Received: by outflank-mailman (input) for mailman id 321680; Thu, 05 May 2022 08:16:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfP-0001qT-Oa for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5f27b5e-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C77D11F8A6; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9BF4413B11; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2GSyJPCHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5f27b5e-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4Z1RjFpyVDty3WoTn8qjFQASCN+ZRnPh5FcuU0Fko0=; b=BhtFVaZFvCxw2q4uOqiGV6IV3CyJrE9Dw4JGcI3BpRoPiNqDCjWjoHDih934WXw7iqEQyg YEMJJBedzXNNfme/6kZ/1j44R+ppHMB90m/u+85yIn4E5iYAKPb8s5fbntyx4w2hypvn8M loMr0Bhpw9KIeQDLTwcA1mOnCSAVuQ0= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Greg Kroah-Hartman Subject: [PATCH v3 19/21] xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:38 +0200 Message-Id: <20220505081640.17425-20-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify xen-hcd's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross Acked-by: Greg Kroah-Hartman --- drivers/usb/host/xen-hcd.c | 61 ++++++++++---------------------------- 1 file changed, 15 insertions(+), 46 deletions(-) diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c index 9cbc7c2dab02..de1b09158318 100644 --- a/drivers/usb/host/xen-hcd.c +++ b/drivers/usb/host/xen-hcd.c @@ -1098,19 +1098,10 @@ static void xenhcd_destroy_rings(struct xenhcd_info *info) unbind_from_irqhandler(info->irq, info); info->irq = 0; - if (info->urb_ring_ref != INVALID_GRANT_REF) { - gnttab_end_foreign_access(info->urb_ring_ref, - (unsigned long)info->urb_ring.sring); - info->urb_ring_ref = INVALID_GRANT_REF; - } - info->urb_ring.sring = NULL; - - if (info->conn_ring_ref != INVALID_GRANT_REF) { - gnttab_end_foreign_access(info->conn_ring_ref, - (unsigned long)info->conn_ring.sring); - info->conn_ring_ref = INVALID_GRANT_REF; - } - info->conn_ring.sring = NULL; + xenbus_teardown_ring((void **)&info->urb_ring.sring, 1, + &info->urb_ring_ref); + xenbus_teardown_ring((void **)&info->conn_ring.sring, 1, + &info->conn_ring_ref); } static int xenhcd_setup_rings(struct xenbus_device *dev, @@ -1118,46 +1109,24 @@ static int xenhcd_setup_rings(struct xenbus_device *dev, { struct xenusb_urb_sring *urb_sring; struct xenusb_conn_sring *conn_sring; - grant_ref_t gref; int err; - info->urb_ring_ref = INVALID_GRANT_REF; info->conn_ring_ref = INVALID_GRANT_REF; - - urb_sring = (struct xenusb_urb_sring *)get_zeroed_page( - GFP_NOIO | __GFP_HIGH); - if (!urb_sring) { - xenbus_dev_fatal(dev, -ENOMEM, "allocating urb ring"); - return -ENOMEM; - } - SHARED_RING_INIT(urb_sring); - FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE); - - err = xenbus_grant_ring(dev, urb_sring, 1, &gref); - if (err < 0) { - free_page((unsigned long)urb_sring); - info->urb_ring.sring = NULL; - goto fail; - } - info->urb_ring_ref = gref; - - conn_sring = (struct xenusb_conn_sring *)get_zeroed_page( - GFP_NOIO | __GFP_HIGH); - if (!conn_sring) { - xenbus_dev_fatal(dev, -ENOMEM, "allocating conn ring"); - err = -ENOMEM; - goto fail; + err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, + (void **)&urb_sring, 1, &info->urb_ring_ref); + if (err) { + xenbus_dev_fatal(dev, err, "allocating urb ring"); + return err; } - SHARED_RING_INIT(conn_sring); - FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE); + XEN_FRONT_RING_INIT(&info->urb_ring, urb_sring, PAGE_SIZE); - err = xenbus_grant_ring(dev, conn_sring, 1, &gref); - if (err < 0) { - free_page((unsigned long)conn_sring); - info->conn_ring.sring = NULL; + err = xenbus_setup_ring(dev, GFP_NOIO | __GFP_HIGH, + (void **)&conn_sring, 1, &info->conn_ring_ref); + if (err) { + xenbus_dev_fatal(dev, err, "allocating conn ring"); goto fail; } - info->conn_ring_ref = gref; + XEN_FRONT_RING_INIT(&info->conn_ring, conn_sring, PAGE_SIZE); err = xenbus_alloc_evtchn(dev, &info->evtchn); if (err) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:17:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:17:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321681.542884 (Exim 4.92) (envelope-from ) id 1nmWfg-0007Z9-UO; Thu, 05 May 2022 08:17:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321681.542884; Thu, 05 May 2022 08:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWff-0007N6-G6; Thu, 05 May 2022 08:17:11 +0000 Received: by outflank-mailman (input) for mailman id 321681; Thu, 05 May 2022 08:16:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfQ-0001qT-Ow for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:56 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b61a15f6-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:16:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 120B11F8A8; Thu, 5 May 2022 08:16:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD80F13B11; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8OnlMPCHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b61a15f6-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YieP6g6GD+6KZq0OezPbFilh5pPFUmXvxSeu0Xk0Zbk=; b=a47wg7hs+Ar9ubMMFW2QBPgc/9OvtFAxtGENzHnQvWq+IimOl5w725xLTv49E1Lysuln+l EWdRp77qNP7Ww6z0rS78kI+ZFPVH8Y9J42HfkArvJavBRQdnE3UQxjVoQ5CYzVGeYAGP7p 3Gk9ApfmiHo+Z13DYIfwZirMV54dG0w= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Andrushchenko , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: [PATCH v3 20/21] xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:39 +0200 Message-Id: <20220505081640.17425-21-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify sndfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- sound/xen/xen_snd_front_evtchnl.c | 44 +++++++------------------------ 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c index 3e21369c8216..26d1b3987887 100644 --- a/sound/xen/xen_snd_front_evtchnl.c +++ b/sound/xen/xen_snd_front_evtchnl.c @@ -143,12 +143,12 @@ void xen_snd_front_evtchnl_flush(struct xen_snd_front_evtchnl *channel) static void evtchnl_free(struct xen_snd_front_info *front_info, struct xen_snd_front_evtchnl *channel) { - unsigned long page = 0; + void *page = NULL; if (channel->type == EVTCHNL_TYPE_REQ) - page = (unsigned long)channel->u.req.ring.sring; + page = channel->u.req.ring.sring; else if (channel->type == EVTCHNL_TYPE_EVT) - page = (unsigned long)channel->u.evt.page; + page = channel->u.evt.page; if (!page) return; @@ -167,10 +167,7 @@ static void evtchnl_free(struct xen_snd_front_info *front_info, xenbus_free_evtchn(front_info->xb_dev, channel->port); /* End access and free the page. */ - if (channel->gref != INVALID_GRANT_REF) - gnttab_end_foreign_access(channel->gref, page); - else - free_page(page); + xenbus_teardown_ring(&page, 1, &channel->gref); memset(channel, 0, sizeof(*channel)); } @@ -196,8 +193,7 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index, enum xen_snd_front_evtchnl_type type) { struct xenbus_device *xb_dev = front_info->xb_dev; - unsigned long page; - grant_ref_t gref; + void *page; irq_handler_t handler; char *handler_name = NULL; int ret; @@ -207,12 +203,9 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index, channel->index = index; channel->front_info = front_info; channel->state = EVTCHNL_STATE_DISCONNECTED; - channel->gref = INVALID_GRANT_REF; - page = get_zeroed_page(GFP_KERNEL); - if (!page) { - ret = -ENOMEM; + ret = xenbus_setup_ring(xb_dev, GFP_KERNEL, &page, 1, &channel->gref); + if (ret) goto fail; - } handler_name = kasprintf(GFP_KERNEL, "%s-%s", XENSND_DRIVER_NAME, type == EVTCHNL_TYPE_REQ ? @@ -226,33 +219,18 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index, mutex_init(&channel->ring_io_lock); if (type == EVTCHNL_TYPE_REQ) { - struct xen_sndif_sring *sring = (struct xen_sndif_sring *)page; + struct xen_sndif_sring *sring = page; init_completion(&channel->u.req.completion); mutex_init(&channel->u.req.req_io_lock); - SHARED_RING_INIT(sring); - FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE); - - ret = xenbus_grant_ring(xb_dev, sring, 1, &gref); - if (ret < 0) { - channel->u.req.ring.sring = NULL; - goto fail; - } + XEN_FRONT_RING_INIT(&channel->u.req.ring, sring, XEN_PAGE_SIZE); handler = evtchnl_interrupt_req; } else { - ret = gnttab_grant_foreign_access(xb_dev->otherend_id, - virt_to_gfn((void *)page), 0); - if (ret < 0) - goto fail; - - channel->u.evt.page = (struct xensnd_event_page *)page; - gref = ret; + channel->u.evt.page = page; handler = evtchnl_interrupt_evt; } - channel->gref = gref; - ret = xenbus_alloc_evtchn(xb_dev, &channel->port); if (ret < 0) goto fail; @@ -279,8 +257,6 @@ static int evtchnl_alloc(struct xen_snd_front_info *front_info, int index, return 0; fail: - if (page) - free_page(page); kfree(handler_name); dev_err(&xb_dev->dev, "Failed to allocate ring: %d\n", ret); return ret; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:20:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:20:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321702.542924 (Exim 4.92) (envelope-from ) id 1nmWj7-0005xk-LP; Thu, 05 May 2022 08:20:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321702.542924; Thu, 05 May 2022 08:20:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWj7-0005xd-Fo; Thu, 05 May 2022 08:20:45 +0000 Received: by outflank-mailman (input) for mailman id 321702; Thu, 05 May 2022 08:20:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWj6-0005xX-95 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:20:44 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41398c86-cc4c-11ec-a406-831a346695d4; Thu, 05 May 2022 10:20:42 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-irsWogXIO9GjP0R69fL8Jg-1; Thu, 05 May 2022 10:20:39 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DBBPR04MB8009.eurprd04.prod.outlook.com (2603:10a6:10:1ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 08:20:38 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 08:20:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41398c86-cc4c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651738842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hJlGUUR5XXcOw3k3TFk3aRA0msNeqezU97iFj288mwg=; b=QI872EWeGozXh03I6FcL7ELyrL4VxlGxj66RZhwmGLR7vL6n/6u1fpKLC9+Nzt3T2WFxid PdqDxITHG+PhHCPutFwUUZsgNM6RmKl3tG/tt+SJQIqGCn2b3KeL8rGoDUA1MGoyakTbwG Vklr3TatVppw8WVnTVxA5XdqryjQtK8= X-MC-Unique: irsWogXIO9GjP0R69fL8Jg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Is9v+9Lttr0ytepKcGTG4ff6gXPBOp1o+v2Abb0vloFSkL1ZJ2yIsW604WBsPohIxuUulbrfeFxIdZ/zcl/BgJNZnA/q5xdpffa/V/QmF6mevf+uytq1aVlHC3Kk4xXU9RjvqdEejP/tfHmhMb/TYdjiY96HKROHVM0vTKDNDTMqrzhFh0qOSgH/GSvHhER7hfwQFu1vntKkjSeN+/JtwjMnGZCI7i8earM3/UiV2Ts9ExIcctxVwAxc25LZN7kaeivj+itFsIsLre5iT6dagzv9MQW8GzXDlDxRDD0uTjPN4D6V+0wCQmUqlQSfxtnUm+Nau+/aPdapqVCaw1o7VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qmQR8VnoKT3D6hkXdukz2HjDDlH33eCm35AERLERfE8=; b=dAfHNz8xLkuQi0CEwpK4GGmWrFoIZxPAposGbADp5ROr2OxqOnJAnsaBtbank084A6q1EIHf0JkI/FlTFGMtlqgJAcVIo22RomH9Q2TDS3VPCvBDC6YaBgroMMGTW2q4yvVvUTezXdYWwZvuuDTWzrgt9nLrsPs50I4atT9WNCUAArBRqRCKndOyxg72AE/2Zhafvdj+hEW3fPMIOLUuVHVKLjCUJt3QFS4xUl2a92I1BQ/7uJPvTMqBEJD2yRUmg2e1XkmWoG7oBG+zAgYvo6BDwzU5T+6MuMAVgAJz2883Bbe6W8ClE2GII0oR9YtSPPSvEdXqLV3uBxj9oC6jjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4bca3f52-436a-1285-9c36-9206dc5d50c9@suse.com> Date: Thu, 5 May 2022 10:20:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> <2d0d8aa9-1ab8-a505-e2df-c9b6446062cf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:20b:488::8) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fa6619d-9e49-4308-3079-08da2e70229d X-MS-TrafficTypeDiagnostic: DBBPR04MB8009:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EOs2/4YTO5tfUnMXNyur8KkO7U/qeDGwwEshSL1yApTRkUg5mESjlzbRmwb12HL5mIjjLKkIQoN7O/Q+LvczDrxbQst9zBb5sPojGZUpChqR/2i1OvydcqktiuI+VXlDQhOvtv+u90WMUFhpGo2C0DKufbjjzIHC5R+gbXYhB3cBc+ikajO7RV4B6mQKIb58gPrr8S1Hlqh25tK4OKMu8l4TxTCdfIm0VHrxYQOMn9hXvhZ40xtgX+qH/WaaxgptGAU/J12woLryiGIgHcQo7VXeEVobEOcnSmFx1MQAFtzsPafjkWORCOra2eyhl0oc1pfUUxsjx1HQMH3iJTIax/xG1cIKJeoiBYNy6S+/Nh6kWTplqQjaGPvSb8dMuuWX3oL4HaN39MlSqT9yOxh1G/ZBTFXvebk1cToWk1frJWmnuMK0/w4GQUs1e/K+hk2Z+V5J4+aMPs7xNjQJ6ga3Iuq94C/SNV+sXzcTLV7IVO+HJMAQ4RBk6zxDwyYJotlQccV/kRkIRJ5mzZzF7uU4yH76MnIdwoO9NqNz9ipBz4DFFmZKd5k+8KmHHxyaWGVBKvBjwZNpsOWELbpbhdpTE+uEKXVdGV3l5zLrbhNiUzUO6Yj0C2tR8EQ4i+mg8XKxPtVeB6/SPPiRT8PpnzVL5UT6xe5oNrq4LTCZH6c1da+5siuul9tE5MPXNl0RCTAUE6S7kPamHsYZS3Yfg8/eFeK6zD+6ifvNneJzt2v794w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31696002)(508600001)(83380400001)(53546011)(8936002)(66946007)(316002)(2616005)(54906003)(31686004)(5660300002)(186003)(86362001)(2906002)(6486002)(8676002)(4326008)(66556008)(66476007)(6512007)(26005)(6506007)(38100700002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M6whz8ut6Rx56Dc3C/qdynpuPUSmc6XDn8Aj+Fwllmh48LiBX0CadptbjZJr?= =?us-ascii?Q?l49bwIGyhXn0zYgmoKXfI7/yt9auK2ApD9vuVyJD/2bWMd49ikbxHRHOHiCf?= =?us-ascii?Q?C8KwSjnSBzR2sdrMUCg3Pk6Oe9w49h9s/qhZQwHZD3WRbU2/bNcttillHowv?= =?us-ascii?Q?fW5LQOkHp/BuldSFvGQ/yZaqvwzmiZPJAMLHTLYGjPK20YGn+/UIXh9ETWFJ?= =?us-ascii?Q?6ZiBQG92fzRfWp3+ik291upoXxAXGpUtJgT3XB6usWu2YB+yK/BtwDLzDinZ?= =?us-ascii?Q?zNvLlLswmoT180XfJATxHhFWHmucxO/FyLgWX30j8zaHdRODudu8ow8TiPcG?= =?us-ascii?Q?hecYVogIDiQTjon3nN1rjJHInfatsGamyl4s6TU/hlqyFVG09YBYGcNpkYRV?= =?us-ascii?Q?yNOnMHjPZQ8UjrexRUY7PKqjzP42VSyEYid/OCSaXJEdB4Q32Eh9eDbKSxS6?= =?us-ascii?Q?cPpX0ym6Vjyj0c+AgZvl5FoO3buCc4dg0eE1joLesTa1VyljetoMcnT3TU7p?= =?us-ascii?Q?g3Gdw6AxAIWzi4a/6qVxLuJBfVHcOSpjNqHWURepH9ee6NsovK1eaoXGoMmf?= =?us-ascii?Q?sIS5q3V/iuV6XEXR+maITk2AbnFrhtlyJznhGwsXezvnZXajsbAVWULEshb1?= =?us-ascii?Q?UaDsQL9VoV7672yTI/GHBakVVD8pxnD1RgBf5Uk3mofoOVvrYng0fbr8M77t?= =?us-ascii?Q?9sUQfoauWXiDI3ztVY+kbZrL51vOkaoKxdnTRvHj+s42UAO3NZaw+vvchw8E?= =?us-ascii?Q?XuZc6kjzWqfsDj7RgQy0TWReJWs9FFJpAtoAtcCO0HBzY3ldmV8Yc66PTU/8?= =?us-ascii?Q?cVDAtWZz31w7HZpfZJIjjU9Ah5MfCGe0qsxixP/W5EnRf99rc1et8TPWou6y?= =?us-ascii?Q?FnnRcVxqIFatyBCXU3662WHXShht65oTs98iVFSP1bEBoG6bBNxQwi/YBWeH?= =?us-ascii?Q?iFmIqoGB7HofEAUNjjlEAW1k2Fkl8tc4ImQjmASlVQapK1Pv/rO6d42SYDeA?= =?us-ascii?Q?CBb5AXN+R1fqf2fKQvwoSf5Io+nvZPr9SRxGe36aN2pzx5sEbIwcdDenfutr?= =?us-ascii?Q?mEx3n5q1uLw+gYReu9GrVBDZbJewVCCJkODOXc3XIOzXAvvGlPkruE7Lgv6p?= =?us-ascii?Q?6qe44iIifGUP68I6BTW9oOaJkF3pJC1DvK/9zQrvF0AtcOh/oZp1LCH48ZSH?= =?us-ascii?Q?SgS8Xo/Ca8jvzo3CwjVPnzR2l0J1l0p5Jl7uh5j396fufKWdi1DzCQDJN1Dw?= =?us-ascii?Q?+dpxdfjuo9C+1IrMtCo1pKVY3MqkUOthNDXbkQNZ+I7i2Fk4HAnKEdbEr5dQ?= =?us-ascii?Q?Y30T/EMkMt3mj2wPC7K8j5KcG8PVfUo5hzn0AI29itRNji0zLnG41xTxmGl3?= =?us-ascii?Q?DTOJfTdvjEmJWAJ0KroeXPVAwJZcHfoJH70gAHrlMBhEd4PxGBUIAdNJjsiq?= =?us-ascii?Q?vf4Vsj94nyJUQVie/BVfY2iZpfWJ7dRqGdCLkZ5xMFUXycvSQuEutHS853dL?= =?us-ascii?Q?kEDTznlAqRav/2huYYSenXzNq280KPdCWcFpKujMU7f7BzAvux6xvAPfbQWp?= =?us-ascii?Q?cadzF9AreRqEP/gH0sbkWnhCVEC23ph49dVRdQE1MQ96QYCI8yWlRa2PV6Fm?= =?us-ascii?Q?Pbk7CFOFgo6w20yK8TFKLu/9QDzvX2UrTuAYGb2syAm9m3Dp8zvJI2Jtlgia?= =?us-ascii?Q?oAQZZhhSHgTlJALlhKB35TZn6gJ8S8sa1/dra5e6hxrZNZ82+d9vK5lk7k7q?= =?us-ascii?Q?TKYBvRUdkw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa6619d-9e49-4308-3079-08da2e70229d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:20:37.9694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0W9IJdOeogC/AeLuSc9iMZ9dYlqz8jBWFSISIe4LdGKsp1dAFqHUSvclLJK8+JcE2lqNOvN7L7eKZ+vMqWrNzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8009 On 04.05.2022 17:06, Roger Pau Monn=C3=A9 wrote: > On Wed, May 04, 2022 at 03:07:24PM +0200, Jan Beulich wrote: >> On 03.05.2022 18:20, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: >>>> For vendor specific code to support superpages we need to be able to >>>> deal with a superpage mapping replacing an intermediate page table (or >>>> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart = is >>>> needed to free individual page tables while a domain is still alive. >>>> Since the freeing needs to be deferred until after a suitable IOTLB >>>> flush was performed, released page tables get queued for processing by= a >>>> tasklet. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> I was considering whether to use a softirq-tasklet instead. This would >>>> have the benefit of avoiding extra scheduling operations, but come wit= h >>>> the risk of the freeing happening prematurely because of a >>>> process_pending_softirqs() somewhere. >>> >>> I'm sorry again if I already raised this, I don't seem to find a >>> reference. >> >> Earlier on you only suggested "to perform the freeing after the flush". >> >>> What about doing the freeing before resuming the guest execution in >>> guest vCPU context? >>> >>> We already have a hook like this on HVM in hvm_do_resume() calling >>> vpci_process_pending(). I wonder whether we could have a similar hook >>> for PV and keep the pages to be freed in the vCPU instead of the pCPU. >>> This would have the benefit of being able to context switch the vCPU >>> in case the operation takes too long. >> >> I think this might work in general, but would be troublesome when >> preparing Dom0 (where we don't run on any of Dom0's vCPU-s, and we >> won't ever "exit to guest context" on an idle vCPU). I'm also not >> really fancying to use something like >> >> v =3D current->domain =3D=3D d ? current : d->vcpu[0]; >=20 > I guess a problematic case would also be hypercalls executed in a > domain context triggering the freeing of a different domain iommu page > table pages. As then the freeing would be accounted to the current > domain instead of the owner of the pages. Aiui such can happen only during domain construction. Any such operation behind the back of a running guest is imo problematic. > dom0 doesn't seem that problematic, any freeing triggered on a system > domain context could be performed in place (with > process_pending_softirqs() calls to ensure no watchdog triggering). >=20 >> (leaving aside that we don't really have d available in >> iommu_queue_free_pgtable() and I'd be hesitant to convert it back). >> Otoh it might be okay to free page tables right away for domains >> which haven't run at all so far. >=20 > Could be, but then we would have to make hypercalls that can trigger > those paths preemptible I would think. Yes, if they aren't already and if they allow for freeing of sufficiently large numbers of pages. That's kind of another argument against doing so right here, isn't it? >> But this would again require >> passing struct domain * to iommu_queue_free_pgtable(). >=20 > Hm, I guess we could use container_of with the domain_iommu parameter > to obtain a pointer to the domain struct. I was fearing you might suggest this. It would be sort of okay since the reference to struct domain isn't really altering that struct, but the goal of limiting what is passed to the function was to prove that the full struct domain isn't required there. Also doing so would tie us to the iommu piece actually being a sub-structure of struct domain, whereas I expect it to become a pointer to a separate structure sooner or later. >>>> @@ -550,6 +551,91 @@ struct page_info *iommu_alloc_pgtable(st >>>> return pg; >>>> } >>>> =20 >>>> +/* >>>> + * Intermediate page tables which get replaced by large pages may onl= y be >>>> + * freed after a suitable IOTLB flush. Hence such pages get queued on= a >>>> + * per-CPU list, with a per-CPU tasklet processing the list on the as= sumption >>>> + * that the necessary IOTLB flush will have occurred by the time task= lets get >>>> + * to run. (List and tasklet being per-CPU has the benefit of accesse= s not >>>> + * requiring any locking.) >>>> + */ >>>> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); >>>> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); >>>> + >>>> +static void free_queued_pgtables(void *arg) >>>> +{ >>>> + struct page_list_head *list =3D arg; >>>> + struct page_info *pg; >>>> + unsigned int done =3D 0; >>>> + >>> >>> With the current logic I think it might be helpful to assert that the >>> list is not empty when we get here? >>> >>> Given the operation requires a context switch we would like to avoid >>> such unless there's indeed pending work to do. >> >> But is that worth adding an assertion and risking to kill a system just >> because there's a race somewhere by which we might get here without any >> work to do? If you strongly think we want to know about such instances, >> how about a WARN_ON_ONCE() (except that we still don't have that >> specific construct, it would need to be open-coded for the time being)? >=20 > Well, I was recommending an assert because I think it's fine to kill a > debug system in order to catch those outliers. On production builds we > should obviously not crash. I disagree - such a crash may be rather disturbing to someone doing work on Xen without being familiar with the IOMMU details. >>>> +static int cf_check cpu_callback( >>>> + struct notifier_block *nfb, unsigned long action, void *hcpu) >>>> +{ >>>> + unsigned int cpu =3D (unsigned long)hcpu; >>>> + struct page_list_head *list =3D &per_cpu(free_pgt_list, cpu); >>>> + struct tasklet *tasklet =3D &per_cpu(free_pgt_tasklet, cpu); >>>> + >>>> + switch ( action ) >>>> + { >>>> + case CPU_DOWN_PREPARE: >>>> + tasklet_kill(tasklet); >>>> + break; >>>> + >>>> + case CPU_DEAD: >>>> + page_list_splice(list, &this_cpu(free_pgt_list)); >>> >>> I think you could check whether list is empty before queuing it? >> >> I could, but this would make the code (slightly) more complicated >> for improving something which doesn't occur frequently. >=20 > It's just a: >=20 > if ( list_empty(list) ) > break; >=20 > at the start of the CPU_DEAD case AFAICT. As you say this notifier is > not to be called frequently, so not a big deal (also I don't think the > addition makes the code more complicated). Okay, I've made that conditional, not the least because I think ... > Now that I look at the code again, I think there's a > tasklet_schedule() missing in the CPU_DOWN_FAILED case if there are > entries pending on the list list? ... this, which indeed was missing, wants to be conditional. While adding this I did notice that INIT_PAGE_LIST_HEAD() was also missing for CPU_UP_PREPARE - that's benign for most configs, but necessary in BIGMEM ones. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 08:27:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:27:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321715.542933 (Exim 4.92) (envelope-from ) id 1nmWpS-0006gV-8g; Thu, 05 May 2022 08:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321715.542933; Thu, 05 May 2022 08:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWpS-0006gO-64; Thu, 05 May 2022 08:27:18 +0000 Received: by outflank-mailman (input) for mailman id 321715; Thu, 05 May 2022 08:27:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWg2-0001qT-Hx for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:17:34 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce283030-cc4b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:17:31 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 04:17:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB3312.namprd03.prod.outlook.com (2603:10b6:301:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Thu, 5 May 2022 08:17:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Thu, 5 May 2022 08:17:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce283030-cc4b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651738651; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=DYHsY0IXWbJ6loB9haX+v463uMMw0RF3zHBUBC6ge6I=; b=iawZEIH3f6TDGSgc//KpDfwWYuGDz/CosvgB51HUF/02QqeGg0+Rg64Z xnG0OzBdWhJOC7nExhk5i//GIJBUYXUYEEmp2Ecv/KFXIk53ZMDg1BkAB TTGKHPbiQtVILy5/U9R6SdMMlNbIQwPtqhsRJIEmpiCpCVg9lM5idHcbP 8=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 70022277 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:d53uNa4N26Bc5oa1sqoiDQxRtDXGchMFZxGqfqrLsTDasY5as4F+v jQZWj+GaKqLNjDzeN91aoqzp0MAsMDVyoNjSgtqpCtjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhXlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSTawZ3PPyUxdgjDT4BAyh0H5RPpvzIdC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YHhl/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA8AjP//Voi4TV5FBJ9JbuP4rqRsSHat1bt3fFn liB312sV3n2M/Tak1Jp6EmEmubKlDi9XI8UG6y18tZrhkGewioYDxh+fUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxasoRo0S9dWVeog52mlyKXO5B2CLnMZVTMHY9sj3PLaXhQv3 16N2tnvVTpmteTPTWrHr+jO6zSvJSISMGkOIzceShcI6MXip4d1iQ/TStFkE+i+idid9SzM/ g1mZRMW39075fPnHY3ilbwbq1pAfqT0czM= IronPort-HdrOrdr: A9a23:CwpgEameMOe5ICG+vffhcHm/+BXpDfOlimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVnSRULAhKePZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z WxDk0nrsALciYsV9MNOA4we7rINoXze2O9DIuzGyWQKEhVAQOFl3bIiI9Flt2CSdgv8KYYvq jnfRdxiVMSEniefPFmmqc7vyzwfA== X-IronPort-AV: E=Sophos;i="5.91,200,1647316800"; d="scan'208";a="70022277" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGGYp5Y/c4JgPoJTyV3hnoEYSd4GJwmEkAaLF5rGHrY3R9lGdxDqZuz6oj0ZfC5DHCX51BSWqkxaNs8oiHwWhF55qKQn5eV8fnPWvhPBjYGt49gK/CRIH5JbjfpXYl8P3Os3tJWb5lDQRh07qy2jDXWd6B4+6/LNNEpGdiujxbsUHXfeggtzWeIm7q90eTRrMPoE6oTH9ym1X22NKljzZsWPxRf2oLIgrA6NB9qFyVL60q0kN7t1i2HOtMq4fi2Vem7gdT3Vfuwyg+Qa/bYsP5uUeOw5jQ0ATi2c3Sg76yTFu/OAcCm9GqoIXYjXMmaO6H2uDamt2cW0j1WDSCHB2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cnXHkI2Htj7a8UjLcH5DgpvCpOmlABz1ln1juOq+kCU=; b=QpLYGQCEW8R5or5zrF7a4IZp9Nzf/LsAalpl7itUujV+bdhHJFQ4NdD+xui6R8e+pfLLx1VQOiWVqk8ihf/Bd4rmuiaIrPMU4DzjU19aP5L0Zx3pskkhoFohmhFB2Wt9Rx+tj32S3RIOc7PqOKIHjO4LVcMBZRIIhJY1Vt2s9R4Iizzq7OgGYIja6xTwTuW+4ZXXgeVz2aLSYZ6CT1LBTvPRp6X+WjRgIWLvv0m4QD0kf34KhzD/uD3P3Wm06aQXW9Glw4trlHzKv05/Ys92ohxmmj3vUUEz0O/BxoQlq4/+VfArVWrCI3mYJwuYMKannnVKZx9yi8vKBe812ubpiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cnXHkI2Htj7a8UjLcH5DgpvCpOmlABz1ln1juOq+kCU=; b=bC/4ZZRs0+LfY1DgTLcfjspQ0ykkhAqWfMB0WZgSjVPCOpmDg54xty499iVb3NPVMXX0abcPX1ujh6gwqjzuRkEN6qInzfKIbfwlPjo+dM8EDtWNhB4mV92nxmwbEGzG2K7639cVSA32E2AXv8fAHJQKbnJtIarueMdu7GWmPqM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 10:17:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Tamas K Lengyel Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor Message-ID: References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: BL1PR13CA0237.namprd13.prod.outlook.com (2603:10b6:208:2bf::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fabb4bac-0689-4281-3b88-08da2e6fafc3 X-MS-TrafficTypeDiagnostic: MWHPR03MB3312:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B8VYaXdB3fjcCegRklxTCVYMyVEqIyaWypVhyj15EIWz9CVAFdFYS7UQIlAUqu7oDb/6TZ+MV8S1H1Bo0dBQl0ILQaDQyUbAQPSJym7P0Evq5+ehFCfQC/h8iImF2cZrp5uUowpzMX+ff6TYj6Ul/DisotWtMojNzplHQTa4FNliX+5E+iyXdNlC3AJcRnK314Kdg+nIDUNmA7QF5Wco7mLtiCWVKwv96jZHpqFQe06ygoJIid8X7UltCE0atpVuxENfTA1EmCD7uN+pniqE0qCntrXOFxHlMqiXGoHKYK2fpWgzdZ38eIzf4EHF1sASNXl9q2OQ6p1Tu+AsQkLnmVZhw8L8qOwl1H77ooCkt1Gqd1+DNBzbCWli1aTRUEvx5TPKj6eyMbLyFwdyfpy5+phMlFdRizW1I03tGQ8lcry2pwH0qjpJjN9fg1P8Qnp6KnE+Q8dddD7z1enmsw+hVVUo3JPNhvChPJpx3kTxziCtQaVcD1b+Xjc8iYS3Th47AXqGFErtqkq3JbNdxvLeo31NBoAOE4OTJcKzzA3wfuglwrAOuSqq6AS4qNmdXxtT9iYTbX4BX0rHDQsSjdDdbJuiT95sAqVODcHVDjv2/YvrRk6K4SbTaKtX8+Tu32pKSTZbeTN4DLqnzFGP6ZvWFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6506007)(6666004)(8936002)(86362001)(4326008)(8676002)(6916009)(66946007)(66556008)(316002)(66476007)(54906003)(82960400001)(38100700002)(508600001)(6486002)(6512007)(186003)(85182001)(33716001)(558084003)(9686003)(2906002)(26005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3QyQ2laSE0wb094Q3FWQTVxK0tNUXJmT2FDc2xha3NwQWZvSDBTWktSNHJp?= =?utf-8?B?YldPTjBiYWpOUFFNTVVNTTJRaXJHLzEzdzNET0dkWHhWRkd0aUNqOGVHNjE1?= =?utf-8?B?dDQ4RXZjQUx1c3RHaG9VS1pyWFRkblcvWWxJckFudTBFejhQbWtkODVYTHFq?= =?utf-8?B?NWQranArSnNvZnJ4MHR5RmdhZ3V4WHFmTFNQSjNGRVAyQVJXOWlQbXhRR3pm?= =?utf-8?B?dzVnZVByMTNpYUZ6UlhWbkNKb2UvVFdTUGJHU1NZMktCMlZ3RUV4eVNGRmdS?= =?utf-8?B?V3VKZkErN1JCS01DS2l4bkxpTStFbXdROGQ2U0I1TlJYdUlWMnh4WjNpNVBQ?= =?utf-8?B?VWNlTENLSU4remR1MDhzWWZ0dVBvZVJnUm0wU29iaXFpVkVpbm8wdW9IZjNZ?= =?utf-8?B?SWlLM2R3eGtmblNVYzdRNWZHVU5yNnBCL1RDcGRlT3dYR2NmTC9pNkNqVis0?= =?utf-8?B?amM3K2xzNXdBMG9STTF2SGc0U1RFYnpObEsxVnU2VTZEbnpGWFhuSUxGdGRR?= =?utf-8?B?TTNxbE5PSFlGOGJZQ3p4L0ZIMHJFR282a1VPRlFYSmNaNVhSNlpWakplWW91?= =?utf-8?B?aUx2Z2NIVmRRZFRSbW5EdEtCM3pLL09TU0hiWWZNMG9LekQrVTdFOHNVTkcy?= =?utf-8?B?bkh0bXNmS3BsVXIzNEVZYnlMbHhYcHBMcUt2eHVQZkpOUUhHVWJKOS9scXEw?= =?utf-8?B?dzdicHR1S1cyRmRYa3Z2S0lLNWtIRkVLSW1sZ3UzNGlkNTBKZEZDZ0hSUS8r?= =?utf-8?B?ekw2aU9GQ3FlVmVvUXB4aTZYcHNFVS83aWxpT2NJemNXUGpidm82NEFaRm16?= =?utf-8?B?RW03OWk5VS9LTHlaNmFKcmNyN1pFUnJISmF0QTkxeXYzazZZaEY1dFVONW1N?= =?utf-8?B?Vk9zREpkMkNtYVlRUHd1cXloOWpJY3VWei9CV0taWHRra2R3Y042S1I1aWJw?= =?utf-8?B?UVM2SHZWWFNsSlRhaDB0OWFjOUVZbE1LVndVWmtlR2xpNzBOSVFNenNoMFBz?= =?utf-8?B?cnA4WnZqb2lQbkgrYmF6ZUdMRG8rMjVSNFdSVEM2OEowZ3hJTk5xZTdpVmVs?= =?utf-8?B?L0hKdWc5WDlVaEE0M2xwVFJMZVB2YTdsSGdsTDFvSWJiSzNRR004aFBlUlhO?= =?utf-8?B?SlRvbHljNHA5N2hBUU9PSG9IR3pidGJEbmFCQk5BeHR6aldKa0dOWTN4Qi85?= =?utf-8?B?YUpZUWhkbTh0ZjlWZ1lJRnczY3NvSU40ZjJNQ1lsWndhRSs4bGZZaXdZMlhn?= =?utf-8?B?QldXQTc1ZGRIWGZDYjNJN0VWOEZZTnRRNjhraVNyVDZndDdLVUhvTEVZSTZl?= =?utf-8?B?YmIyY2RrUWtzNk41T0VMZlVOMDJsRWUzM2t3SEdIS2lCcGkrN0UxSEJqNXgx?= =?utf-8?B?RTJ6elhDbm4wMkg1ZkNOSm9GK1NKQ3dhTXZjdHgwT3h1VnlQZ3FmUHU0NmtC?= =?utf-8?B?V1FyZzcyNkU1WWdZUDRCaGkyaFFkUWRnN1hQUitsajArMzNxemtNaytZMm9O?= =?utf-8?B?cW1lNXJxc2h0dzVnS2k5dlpFakdlbmNQZlkveDlqM01KczdjMWdYb1p6V1pB?= =?utf-8?B?NExKTTFncDhZSXlERWVhSXpMcWozSU11eEVvL3NnV2JYdW9NMnQvRnFLQ2hk?= =?utf-8?B?M0QxSDVQTUdUZmZ5bk5IZ3hrL2VsK0FzV1hIS09xV05Kb3ZTZEhOVCsrVEhl?= =?utf-8?B?Y25KZVFqSG5MWVpSRzhUQzJxeWRCRk9aYmN2aG9ZMGE3MW9RdzI5VkZTclRi?= =?utf-8?B?K2dqdUZXVnBMdWVHV2pjMjFQbm92ek9MVTNxZENhRWU1b2h6UU1xa0Z1aC8y?= =?utf-8?B?UGNXbnVxbGtzZy9uRXhQUlNNL1dXRWNGeHRuNVlWMUhNdFdGUDc2UEw2SW11?= =?utf-8?B?SlZ5SEhCbmttMTNkVUFZRDhZbC9GUGNDZnZuNUdpUHozRVd1c0VOOUJGLy9Q?= =?utf-8?B?Vk8raFk0Q2p5U1VrYXFtck9oR3FFZStPMDN6QjU2QzFqRWk3UjZEWHo3NGxx?= =?utf-8?B?S1FZT0lURmdEWk5BenhJUEtvSHg5MGs0WVpZdFZtWGlOZ2wxMVhLeitTRHps?= =?utf-8?B?b3Q0dVR1QXdCeEd5ZG9UaTJ1d0hyQi9DSDZKeFQzeXRhckZWcUd0M3JZei9T?= =?utf-8?B?OGVFKzZNWnV6MWdwMytiVk1wRUJFbENSK2NOSWhtMnFMYm9ERlB3N2E2bEh0?= =?utf-8?B?SkVKSS9iaFE1Um1LTlNTbGkrYkl6VjRjby92d0xmUkZBY1hRQ3VoMmVHeGNX?= =?utf-8?B?QU41VmlyYlF2aklHN29YRnJ0QTZieWhITHVTR2hmWVMrcjV1S0N1Z1lVcDNX?= =?utf-8?B?Rm0rU1NFNzJqVTJVY2JuNTJ6Si9VU05rbXk1em5qUnpQM00vWEZpUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fabb4bac-0689-4281-3b88-08da2e6fafc3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:17:25.3744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: urIGGIGaqjXeFCwdtLa8rj5Ry+aRHUEXkqjibRg4PZE3XyVkCvpOzqva302xeqB5Tu5p6IucdpNutFhCftuIUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3312 On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: > Need to separately specify if the reset is for the memory or for the VM state, > or both. > > Signed-off-by: Tamas K Lengyel Reviewed-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Thu May 05 08:31:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:31:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321758.542944 (Exim 4.92) (envelope-from ) id 1nmWtC-0008GF-UC; Thu, 05 May 2022 08:31:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321758.542944; Thu, 05 May 2022 08:31:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWtC-0008G8-RW; Thu, 05 May 2022 08:31:10 +0000 Received: by outflank-mailman (input) for mailman id 321758; Thu, 05 May 2022 08:31:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWtB-0008Fy-Lm; Thu, 05 May 2022 08:31:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWtB-0000hd-Ih; Thu, 05 May 2022 08:31:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWtB-0008KN-3P; Thu, 05 May 2022 08:31:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmWtB-0004XF-2w; Thu, 05 May 2022 08:31:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CUNkDCq54ustax2AQXtgvgJaeNVeMHWzssMVCFrqFGg=; b=xqRsm0oSB2L8GCJoNuZYAVS5xz H27gPEamHs0oZMDXhdmmeJctirJhFzj6pGWcJWyWudsbRzHdl0j5KAVPMGmDm2DUBza/dVgce26Ju +CPTD0kXfApU/57QbUtLZbLJOgTHyQWi+9+YMyGDeqqnCQSQyI3blJ89734TmWgzgrfY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170142: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 08:31:09 +0000 flight 170142 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170142/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 815 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 08:32:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:32:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321798.542956 (Exim 4.92) (envelope-from ) id 1nmWuE-0000TQ-7S; Thu, 05 May 2022 08:32:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321798.542956; Thu, 05 May 2022 08:32:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWuE-0000TJ-4o; Thu, 05 May 2022 08:32:14 +0000 Received: by outflank-mailman (input) for mailman id 321798; Thu, 05 May 2022 08:32:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfP-0001o5-Bc for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b591ea6b-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 12A012129A; Thu, 5 May 2022 08:16:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CCA8B13B11; Thu, 5 May 2022 08:16:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kD2xMO+Hc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b591ea6b-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IedMI7VTW3rOengTxIhbDIljAXRKt8bJ55HpQHeXTKE=; b=icajDoZbBIwzJ6XcUYvjT5rdUpqaOLHVx+KJgSdfR6jIBErNSkSt0o44KvdViEe6Gl4dxM y8ety7dLU+QVWAR9qvUOSPuT4K7BvqCgmQSR10XuH36FLkxabJLU+fZ6mW8c6f0yU+WgIg CVjSUZA1EqxHMUE0Gi/sxDg4kyBRsoM= From: Juergen Gross To: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Andrushchenko , David Airlie , Daniel Vetter Subject: [PATCH v3 16/21] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring() Date: Thu, 5 May 2022 10:16:35 +0200 Message-Id: <20220505081640.17425-17-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify drmfront's ring creation and removal via xenbus_setup_ring() and xenbus_teardown_ring(). Signed-off-by: Juergen Gross --- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++++++--------------- 1 file changed, 11 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c index 4006568b9e32..e52afd792346 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c +++ b/drivers/gpu/drm/xen/xen_drm_front_evtchnl.c @@ -123,12 +123,12 @@ static irqreturn_t evtchnl_interrupt_evt(int irq, void *dev_id) static void evtchnl_free(struct xen_drm_front_info *front_info, struct xen_drm_front_evtchnl *evtchnl) { - unsigned long page = 0; + void *page = NULL; if (evtchnl->type == EVTCHNL_TYPE_REQ) - page = (unsigned long)evtchnl->u.req.ring.sring; + page = evtchnl->u.req.ring.sring; else if (evtchnl->type == EVTCHNL_TYPE_EVT) - page = (unsigned long)evtchnl->u.evt.page; + page = evtchnl->u.evt.page; if (!page) return; @@ -147,8 +147,7 @@ static void evtchnl_free(struct xen_drm_front_info *front_info, xenbus_free_evtchn(front_info->xb_dev, evtchnl->port); /* end access and free the page */ - if (evtchnl->gref != INVALID_GRANT_REF) - gnttab_end_foreign_access(evtchnl->gref, page); + xenbus_teardown_ring(&page, 1, &evtchnl->gref); memset(evtchnl, 0, sizeof(*evtchnl)); } @@ -158,8 +157,7 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index, enum xen_drm_front_evtchnl_type type) { struct xenbus_device *xb_dev = front_info->xb_dev; - unsigned long page; - grant_ref_t gref; + void *page; irq_handler_t handler; int ret; @@ -168,44 +166,25 @@ static int evtchnl_alloc(struct xen_drm_front_info *front_info, int index, evtchnl->index = index; evtchnl->front_info = front_info; evtchnl->state = EVTCHNL_STATE_DISCONNECTED; - evtchnl->gref = INVALID_GRANT_REF; - page = get_zeroed_page(GFP_NOIO | __GFP_HIGH); - if (!page) { - ret = -ENOMEM; + ret = xenbus_setup_ring(xb_dev, GFP_NOIO | __GFP_HIGH, &page, + 1, &evtchnl->gref); + if (ret) goto fail; - } if (type == EVTCHNL_TYPE_REQ) { struct xen_displif_sring *sring; init_completion(&evtchnl->u.req.completion); mutex_init(&evtchnl->u.req.req_io_lock); - sring = (struct xen_displif_sring *)page; - SHARED_RING_INIT(sring); - FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE); - - ret = xenbus_grant_ring(xb_dev, sring, 1, &gref); - if (ret < 0) { - evtchnl->u.req.ring.sring = NULL; - free_page(page); - goto fail; - } + sring = page; + XEN_FRONT_RING_INIT(&evtchnl->u.req.ring, sring, XEN_PAGE_SIZE); handler = evtchnl_interrupt_ctrl; } else { - ret = gnttab_grant_foreign_access(xb_dev->otherend_id, - virt_to_gfn((void *)page), 0); - if (ret < 0) { - free_page(page); - goto fail; - } - - evtchnl->u.evt.page = (struct xendispl_event_page *)page; - gref = ret; + evtchnl->u.evt.page = page; handler = evtchnl_interrupt_evt; } - evtchnl->gref = gref; ret = xenbus_alloc_evtchn(xb_dev, &evtchnl->port); if (ret < 0) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:38:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:38:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321827.542966 (Exim 4.92) (envelope-from ) id 1nmX0T-0001HG-Sl; Thu, 05 May 2022 08:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321827.542966; Thu, 05 May 2022 08:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmX0T-0001H9-Q4; Thu, 05 May 2022 08:38:41 +0000 Received: by outflank-mailman (input) for mailman id 321827; Thu, 05 May 2022 08:38:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmWfQ-0001o5-Bj for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:16:56 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b63b1ddf-cc4b-11ec-a406-831a346695d4; Thu, 05 May 2022 10:16:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4ABF921871; Thu, 5 May 2022 08:16:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1888F13B11; Thu, 5 May 2022 08:16:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SCawBPGHc2K1BwAAMHmgww (envelope-from ); Thu, 05 May 2022 08:16:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b63b1ddf-cc4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651738609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hj6JgClEpjn6TGh0jHUJx9zkFBBp/YGxKjjz8AW9Jwc=; b=eY1x7w8cnLUr3BuPmzWU96Csqt2i/OipoBessbn74oEwg3ab+rmGZw1odPnIDFmotJ228A /1dxHTptERgmJGhz1nf4m63A8AAXb/45etB0cEKFtDLH5dit6Hh0FKkDHrpay1UhjHuHSg sEPUMV6nZWaJFy2qqBkz6PIq5nWPZ7s= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Oleksandr Tyshchenko Subject: [PATCH v3 21/21] xen/xenbus: eliminate xenbus_grant_ring() Date: Thu, 5 May 2022 10:16:40 +0200 Message-Id: <20220505081640.17425-22-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> References: <20220505081640.17425-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is no external user of xenbus_grant_ring() left, so merge it into the only caller xenbus_setup_ring(). Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko --- V2: - make error message more precise (Andrew Cooper) --- drivers/xen/xenbus/xenbus_client.c | 65 +++++++++--------------------- include/xen/xenbus.h | 2 - 2 files changed, 19 insertions(+), 48 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index 1a2e0d94ccd1..d6fdd2d209d3 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -363,50 +363,6 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err, __xenbus_switch_state(dev, XenbusStateClosing, 1); } -/** - * xenbus_grant_ring - * @dev: xenbus device - * @vaddr: starting virtual address of the ring - * @nr_pages: number of pages to be granted - * @grefs: grant reference array to be filled in - * - * Grant access to the given @vaddr to the peer of the given device. - * Then fill in @grefs with grant references. Return 0 on success, or - * -errno on error. On error, the device will switch to - * XenbusStateClosing, and the error will be saved in the store. - */ -int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr, - unsigned int nr_pages, grant_ref_t *grefs) -{ - int err; - unsigned int i; - grant_ref_t gref_head; - - err = gnttab_alloc_grant_references(nr_pages, &gref_head); - if (err) { - xenbus_dev_fatal(dev, err, "granting access to ring page"); - return err; - } - - for (i = 0; i < nr_pages; i++) { - unsigned long gfn; - - if (is_vmalloc_addr(vaddr)) - gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr)); - else - gfn = virt_to_gfn(vaddr); - - grefs[i] = gnttab_claim_grant_reference(&gref_head); - gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id, - gfn, 0); - - vaddr = vaddr + XEN_PAGE_SIZE; - } - - return 0; -} -EXPORT_SYMBOL_GPL(xenbus_grant_ring); - /* * xenbus_setup_ring * @dev: xenbus device @@ -424,6 +380,7 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, unsigned int nr_pages, grant_ref_t *grefs) { unsigned long ring_size = nr_pages * XEN_PAGE_SIZE; + grant_ref_t gref_head; unsigned int i; int ret; @@ -433,9 +390,25 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, goto err; } - ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs); - if (ret) + ret = gnttab_alloc_grant_references(nr_pages, &gref_head); + if (ret) { + xenbus_dev_fatal(dev, ret, "granting access to %u ring pages", + nr_pages); goto err; + } + + for (i = 0; i < nr_pages; i++) { + unsigned long gfn; + + if (is_vmalloc_addr(*vaddr)) + gfn = pfn_to_gfn(vmalloc_to_pfn(vaddr[i])); + else + gfn = virt_to_gfn(vaddr[i]); + + grefs[i] = gnttab_claim_grant_reference(&gref_head); + gnttab_grant_foreign_access_ref(grefs[i], dev->otherend_id, + gfn, 0); + } return 0; diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index b533b4adc835..eaa932b99d8a 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -224,8 +224,6 @@ int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch, const char *pathfmt, ...); int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state); -int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr, - unsigned int nr_pages, grant_ref_t *grefs); int xenbus_setup_ring(struct xenbus_device *dev, gfp_t gfp, void **vaddr, unsigned int nr_pages, grant_ref_t *grefs); void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu May 05 08:39:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:39:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321836.542978 (Exim 4.92) (envelope-from ) id 1nmX16-0001oM-8A; Thu, 05 May 2022 08:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321836.542978; Thu, 05 May 2022 08:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmX16-0001oF-3Z; Thu, 05 May 2022 08:39:20 +0000 Received: by outflank-mailman (input) for mailman id 321836; Thu, 05 May 2022 08:39:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmX14-0001iA-Bo for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:39:18 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8339c38-cc4e-11ec-a406-831a346695d4; Thu, 05 May 2022 10:39:16 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 04:39:13 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6253.namprd03.prod.outlook.com (2603:10b6:a03:3b8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 08:39:09 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.025; Thu, 5 May 2022 08:39:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8339c38-cc4e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651739956; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=BK9mmxVQ4pn+oequ2EaGjPX6vPeHDJGwA5Ymeou+vHQ=; b=g1I/vE0575OX83vmMBXcHQh1aqVrcwoeX7/eQLrBsqcH8qr9eF6wQPdX P17uBOuAnQ2miZ/Kz7VKGIQxTW4Ed40+YUk+/HMkn/P2HkSC+gdMS//Bx +vnf1hNKMO5BJAina41lOn0gOfzxFtNyZxcg6t812RNP1Oyj9QVZNXmsM 0=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 70648996 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:T1GwnKMaXD+pFrzvrR3RlsFynXyQoLVcMsEvi/4bfWQNrUom0GAOn zBNC22Ab/mNYDP3KtFwatixoB4F65/TzoBjTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tMw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk eVN7L+LFl0SeayRlvYCVSldFj1aMvgTkFPHCSDXXc276WTjKiKp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtaaHfWiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iejI2wJ9jp5o4I++0GJkSpaz4T3H4XrQs2XHZsWhkyh8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ1hHWDy2pVDwcZPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsg/IHc99ZEul/5ATTzKPRul+dHjJdEG4Hb8E6vsgrQzBsz kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkinogpLeEJtsuDIJA== IronPort-HdrOrdr: A9a23:b8iOL60iJLJ1aW8agFY+qQqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60Q5iApIs+MPP+UpgNdNvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,200,1647316800"; d="scan'208";a="70648996" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzLajnfe1tOir8zYV2QeSGWvBihSjTca8fw4ZwFTmP0KrheLauq2kROeGDXURgG2o6d8zjXOw7rwOpW5V7tLl145EzjrnziPM7XEG5G4mzIGNsCjQkOr0GfneEmoB67fsQIXfmi8UdRRo/VTcDiFqeQGAXr8FTYNMiPm7ac8Vbi05P2e2YR6adFufm60MUloMfQCD7nOSX69KHiAsU//oK9LYMRJmhrP73OQB70n3NmcWSRIYQFOjwFjNMCn1FKYmFExRRXptbfOAIJhJAVykMZGeXnHQaWOae+Vhgq8PpYAlfQeTidqH7iXd8/byhDqInon55UPydliK99FmQwOEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsPBDF3S1NCYyGFfu8Ws9je3Ze4yh0Ma5fIOOJOMJE4=; b=Y1zOD48KkJAg/0yb4/TDFcQ3FLv/hK5rkRubY1FZEcDG4kqfXasSRiertLAu73407VIK+Lqg5ICxe9LuwWn4ezc6WYVRi5WujP+sRe4lt9PTNCA7ioRQJ2U65b2rPBLhI9kz1Zm0pMLb1Tv9gTPSy2oQNzv0SGL32x9X4ZiJ4nVUZJ4iXZrDujCZ5HRKysjseJQq/v3m28F+R1ZLcp/DRaeCFbxprWo9JD1Ojfi0vG6wgoRWJvM2b44YQWCubptD07KzTxa4d3J4C+YWPt0wVQnGvuP3KqPyRADqSCZ8SybFND6H6bN+pFAjdQ113qD8DDvBR/jIIzbEvoFJmB65CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zsPBDF3S1NCYyGFfu8Ws9je3Ze4yh0Ma5fIOOJOMJE4=; b=C+vGTC9maWBX9NAtvbA0edn89vwtgNRiIaVJoNIlp1BfL48WFuot9JJe4Z9GVDUjESu9Vjb3WSYYPlS0jffMIvrEKPdVxWEc2hZht5NLzu070+6Fke5rXwgOdjEoEr5VlFUSR2et/5d0AaFNNaXCwNQPDFXCCx+7LGU0Xq1hWSs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 10:39:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH RFC] x86/lld: fix symbol map generation Message-ID: References: <20220502152020.19768-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MN2PR18CA0002.namprd18.prod.outlook.com (2603:10b6:208:23c::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b530dc27-fed8-4982-c7aa-08da2e72b89a X-MS-TrafficTypeDiagnostic: SJ0PR03MB6253:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 89V+Up9PIUfpvhc17SNQoi+td19wcH/iO5sdTHogXrX3CtQqzuNY3c6JAfRYF5PlR238K5EzU2MK1fy+kaAIs+jKLC2+8abihsxD5RdsIGQMV689NA+CtQ/PK/q+YVdOiDK5gI1fHhB3Gi98WWBCocPyJW06SKPWycT4S1Wt4pRg7Z6PVsRKe3B6gLEHrSfbT7ndQRSyS+SZW/GZbOqYiMM4v6V+xZH/2iWlOjUJHulFkQPQ1N3NbPLPdEqC8UTL1lPmAXq+6gXtXzXRg/gwvY+K3+CvwuZLR67aR0KpXCte1r79sslsNnuu7bMIU891ADiy/UQ8XyCpEiRdoanjut8tq4+gu0/to+2vlhydkaXdIdy/NKiCLXEAYgYIK7fz6mopa/ri7TRkrz4juEXTcY5pYKq+tIge+d38eyhlteJxZWmToCxjA5FQNYvcbfiJiyiC3rGcQsQ+jR8rSpuop78rpp/wWpFnRC17IHvg9RzhVUHfpotw53KoDd9ciNsj8VGejAg/pOZF2KQqlxK/uhACrv1Nyckq8v2N0WgX5dADUfgNGayhR5tQin/Bgprkg98g/HYNJhFiM7qDav/57KraUQbYl8VHelzJQHPlFY+JG9Ajcb2M9RfyIZzWdhZyh+cHEB4kUfGtdvWo5EALWWBiPqoLy8IjAZAOCd6syajDb1ZTf6L8tFiHqi3jIVr8ufoyWqwkbYHcLuwLl2C98hfA0E8E6uL+leLV9r+MlaA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(86362001)(54906003)(38100700002)(82960400001)(6512007)(9686003)(26005)(66556008)(66946007)(4326008)(66476007)(8676002)(83380400001)(6666004)(53546011)(33716001)(186003)(316002)(5660300002)(6506007)(508600001)(8936002)(2906002)(85182001)(6486002)(966005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0R6bU5QaElTcEcvMU14dW9ncEpkcm5LbUF6cDRYOEI5VWI4d0p2UWpNM1VU?= =?utf-8?B?ZUFwbUNjcVNYeEZsbnBHbjc4SU5heU8xdGtyZW9pVXZ3bjdQNE40WkZKeS9m?= =?utf-8?B?RHBLU3pOREtyWGM2QzNSa1VuZEJLZXMwdFBOTDRpa29FdlRTdlhYSkpBVmRE?= =?utf-8?B?WjdNY1R3aXg0UE5pRXJrWkxqTnB4dTZkSFk2YTZtOU5RU3htclZ6Y3RlM3ho?= =?utf-8?B?MzA2bDJvelI3dmtSL3Z0bE9HK3F1UyszQTR1RmVndXlzdjBFU1RTa1VMUk5x?= =?utf-8?B?UlpaTmVZLy9mNndBR3lmazJCZGJndGNvT1NiVHRicVoxVDlwQUwrazhjREZx?= =?utf-8?B?dlBVb3laeldBa1IrdWQzZmJRaTJUYnY3eXZMdlhIbFpEQjFnWWVXQUxqQWJj?= =?utf-8?B?bVhHRlFvUmFva09xcllYRE5iSDN0STdFc3VPbXFkc2c4OWhRTTNmYkxIdUZm?= =?utf-8?B?bkRMZXJndUlRaVFrUDBDTGhHQ2NpWnUya3R3TkhyTEFGbXFoNzl3c0cwSit3?= =?utf-8?B?WVFOd2ZJU0huR0xaRU4xK29hV3ZQNy9UY3N6QXlIVTZOalJubkRJYkQrbXhW?= =?utf-8?B?QVVRYjI0OEFQRkVSRlNFbWNDTDdxMnlpMDkwZzRJTldBM3AweG4xV2NRTGRQ?= =?utf-8?B?ZmNCSk9vTzZVYk5pWjNmWVgvVDhpUERzQmMwNFJkdG9LZ1NyNEgzNWpDMnpD?= =?utf-8?B?YnRBc2Fwa2xDbVRvZU9tV2xKOXg2dWxWNlA2d2R5dVdvelFITDlIbmx6c2dt?= =?utf-8?B?bjQ5T1F3T1l3VStFeStNSDhYYTBmVCsxaldaSVlUbW5yYWVuMFloM1U5Ti80?= =?utf-8?B?cFl0alVMUklmODlhOTNReWY1Nld5VUorZEo4REYrVDBwc0xFdzl4a2lzNEgx?= =?utf-8?B?MS80cDNVc0hIU1pLWUtkajhOWllEazk4OHlRcGMvSk5MZFQ1SFJ5THgwdW5W?= =?utf-8?B?R1h5ZGNxRmg2bUxmV2I5KzV0cm9wdmpLcm5FSGErN0dRTjZwSC9JckdnNTRH?= =?utf-8?B?b0RFQnJ1QUo3NmNtdHUwSnV1N1luWUZUNGxhdTVYNUk0VEp5aEJWdmkwNDlE?= =?utf-8?B?dm1CWm53WXJGNjFRL0liUThnbWgzdTFmQnZyTk85ZFpRYUJ6R0cxTThDL0Jv?= =?utf-8?B?bU85d05uUFdFRURjMWJTZmxQNG5reWxKVWI0dzlGOXJUL0FTMXJCa3pzQzlo?= =?utf-8?B?S29IbVlqc285aTR5V3l2TlNmd1ExTzM3NkVkTzlkbUI3VXNZWnhXaEVzeHlX?= =?utf-8?B?Q1pvbUMyeHFGL3BieDNPRW9XT01Id3ZBZ2JIaWlaNmN0Q2M1OW5YT0ZoL29R?= =?utf-8?B?djIyL3ZiVjA5RS9UUGVpMG05dnlhRDdqWHRzcy9nUTB6MXdvRC8ySVNHNitG?= =?utf-8?B?YXJhWmhSMFNyM0g4U3dPc3M5ZGVoL05NUmsvelNsalc5Zk96K0lZeWljczY2?= =?utf-8?B?bUh5a0srRnlZU0Q3dERjcE5CSkR1MHBzbEMveDRhOXN6UUR6eGZtSG81eWtj?= =?utf-8?B?QXdINGsyQkp3ZlhkQjY1U0JOcnVIRTBvOXFBZUdrcXl0WVpIOThwbjEzb0N5?= =?utf-8?B?ZGNpVjVnbndNcjRXa3lEblRxNXBhaktadStRaFZubFp4UThOa0wzbVBEd0w2?= =?utf-8?B?cGhHMVRtaWNxeEFOckhSQzJVNVBYZVdOdjJlT0RLdTlWaHhuazQyR2lRSW1o?= =?utf-8?B?YXdZMHRvUzRQeGxWQjRlTUpIRlFESEZaQnhtMTFUKzM5WnhsdFlWNnBEOXIx?= =?utf-8?B?NmZLMk81dTRXS0ZrVlR1VTJiWDBmYnFHbUFrVkg3YlJBMHBxcWIvOFYza0NN?= =?utf-8?B?cEFqYjVWZG9nOFJuZVZLMit3ZlhsYUVtS2swUU5sS0NtTUlHSjFoNmNOWHRj?= =?utf-8?B?SCtpNGRlOVZpQTMvdlBXOXY0U3g5MUNYTDFkR0xieFFqTXBXWkRxZHdMTitX?= =?utf-8?B?ekNzODhRTEIzZ2FpMlpxcENoOWxja1NaUlVTL3UvdUZMZ2lPamFwNWRwQ0Rm?= =?utf-8?B?cjZVYXBGUS9rOWRvOGwyK0hicVFjUGR3ZWZZUHJOZDJDY1ZTeERTSVpHTE9E?= =?utf-8?B?aklrdy9CcnFKd081TjM2Ni81dExqNWFiSkNnZlJRcmZ2aDhZaDJ5QXhKTVRk?= =?utf-8?B?THZPMjlzMzNpVzhMTTZWOXlvai9scmk3WG5TUTJCYmh6bXpWRTBaS0s5cG8w?= =?utf-8?B?c0xJSi9zbVgxd0ZXeWlsQ2d5RS9jVW04OVpXN2RpT0hwbWNEVjdlTTBvWW83?= =?utf-8?B?SUtVbGhsVTdOOHlOSXJZWUczai9TdEdmamZwWExrdExwYUNBVHZpZ0VNME8v?= =?utf-8?B?SGQzQS9UUTBxNG1ucHd1U3MvOHFlS1R2OWNkRzJnbmFjSXFNNVNXSVgxVCts?= =?utf-8?Q?RO0XzYThXkZCWICw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b530dc27-fed8-4982-c7aa-08da2e72b89a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:39:08.8552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVa3CLYSo8tBBdJjhr37/RR8wp6QIcC2HzAPgBmDIWxy6DAStXzDmkSN6YK2ftCnwTIsPb8EudGDrXE5439MGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6253 On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: > On 02.05.2022 17:20, Roger Pau Monne wrote: > > The symbol map generation (and thus the debug info attached to Xen) is > > partially broken when using LLVM LD. That's due to LLD converting > > almost all symbols from global to local in the last linking step, and > > I'm puzzled by "almost" - is there a pattern of which ones aren't > converted? > > Also "last linking step" is ambiguous, as we link three binaries and > aiui the issue is present on every of these passes. May I suggest > "... when linking actual executables" or (still somewhat ambiguous) > "... when linking final binaries"? > > > thus confusing tools/symbols into adding a file prefix to all text > > symbols, the results looks like: > > > > Xen call trace: > > [] R xxhash64.c#__start_xen+0x3938/0x39c0 > > [] F __high_start+0x94/0xa0 > > > > In order to workaround this create a list of global symbols prior to > > the linking step, and use objcopy to convert the symbols in the final > > binary back to global before processing with tools/symbols. > > > > Signed-off-by: Roger Pau Monné > > --- > > I haven't found a way to prevent LLD from converting the symbols, so > > I've come up with this rather crappy workaround. > > Perhaps a map file (like we use for shared libraries in tools/) would > allow doing so? But of course this would want to be machine-generated, > not manually maintained. > > Have you gained any insight into _why_ they are doing what they do? So after raising this in the LLVM LD forum, I was told this behavior is due to the spec: "A hidden symbol contained in a relocatable object must be either removed or converted to STB_LOCAL binding by the link-editor when the relocatable object is included in an executable file or shared object." Then I did some search myself and found that you raised the same with GNU ld not doing the conversion: https://sourceware.org/bugzilla/show_bug.cgi?id=12374 So it seems LLVM LD goes a bit further than GNU ld and also changes the binding of symbols in the .symtab. I'm not sure I would consider the behavior of either linkers wrong. As a test I've attempted to disable the hidden visibility setting we set in compiler.h, just to realize that parts of our code do rely on having hidden visibility. That's the bug and alternative constructs that use the "i" asm constrain with function pointers. That's only possible in the absence of a GOT or PLT table: https://godbolt.org/z/jK3bq4fhe So I think the way to fix this would be to set the visibility to protected instead of hidden, and then to also make the setting of the visibility unconditional: the compiler not supporting -fvisibility and Xen not setting it will just lead to compiler errors further on during the build process. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 08:45:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321847.542989 (Exim 4.92) (envelope-from ) id 1nmX6Y-0003Lt-1Q; Thu, 05 May 2022 08:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321847.542989; Thu, 05 May 2022 08:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmX6X-0003Lm-SR; Thu, 05 May 2022 08:44:57 +0000 Received: by outflank-mailman (input) for mailman id 321847; Thu, 05 May 2022 08:44:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmX6V-0003Lg-Hz for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:44:55 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0618.outbound.protection.outlook.com [2a01:111:f400:fe0d::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1e25c14-cc4f-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 10:44:53 +0200 (CEST) Received: from AS9PR06CA0033.eurprd06.prod.outlook.com (2603:10a6:20b:463::25) by VE1PR08MB4958.eurprd08.prod.outlook.com (2603:10a6:803:108::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 08:44:44 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:463:cafe::be) by AS9PR06CA0033.outlook.office365.com (2603:10a6:20b:463::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 08:44:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 08:44:44 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Thu, 05 May 2022 08:44:43 +0000 Received: from e84af41c3a1c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 01E5150F-E4CC-4BF3-852D-D2DE6C007F5D.1; Thu, 05 May 2022 08:44:38 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e84af41c3a1c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 08:44:38 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM0PR08MB5425.eurprd08.prod.outlook.com (2603:10a6:208:17d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 08:44:36 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 08:44:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1e25c14-cc4f-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mWBQlAiDPlFGJUBIqVQ7QxKdPEvBIN0OStYWXhCyx/ol4Os6eQGs9uPgXiwjTigQWjXtpaEYEOJ1yZjbd3GwSl9qqtvMbWT7z5c+CW4WG8SJRnbbEOiaF9qF/J0s+ASqtQ/hV52lfqJL3ELANWWzS6X3E4nwF0f9mmNsVp7MJKvzVdOKgP9vN1TionXfm0Rvvm1JSKei+bBYxE8ex867dLKEWldDVuyxm0KIYlKwuIEhql4LhL7tNbdJlCbFzRK8piO5LQMNoPNtSlhJJQIHmUMlHTaRQMBeo32exQ2G6xCpUp53NfCB4WXWY9qwnd/F84XexHcQoZouqDDLsQEPlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePLn/19sws3bcmF/c0iOd8JtdJzzIJun04rnx3Ej+3U=; b=MzY2Jt+WQEN7ib+29m9qMX7odVEDkA1ga4AWUFlHNOkOee4pQNoGJHG00I0etfEILu9E+eq+Ii6bzmqkGDOLC7jn9nZJgwP/8sowaLWQddweYayPqKzTw1RsmfOZgXVrej1eS7WP97l61pdaL2PBdtTOKM/Q0zp4KfVHo9e37rQRvU8w9fAf40Pps28UqmEgvjV0icRTnCq+h6WvFk4IJnWesAHaYwK2BpKQeuEoq0SOI774Ag31TtIyOs/xaEjhFLlNxqTcfQbqjisGYQrIskoEOrdbJiJp4EQv8fcb8s25TyX89pZMheL1wb66nElF8inPQMPZuLcJRQa065CvxQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ePLn/19sws3bcmF/c0iOd8JtdJzzIJun04rnx3Ej+3U=; b=h6CXijfPuFryRyE/vSXdRu+UGNlcBwoUWSE8T1goi2Cmgp+gGmOljEX3tX5XZXvfiAe23KV0Ogq4JoVKtaPy+1HO3yF+1+Ncs306bNWXTbx9EtwHmmnlRubijkbp7VDOX1qxF9E/DR0pwqUv1CP5oW06l0o9dyKtx29o2D3G8OI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7nTc41WMlQTGxPGWxPwHSMzeKqYN+qkAQAR+zhaGKLwII+np+tUhQb7x5X9foRVs8NKtXhDp83mE8JxeURE0fXuNSsPkrXHLJpXPplSD8duv7gTZZW3zF0LbzM2eFZMyB8LsU7to2uHdeDHtcwIVci0pTJz8v0a/BblQcuB54/T64WJY5M6NtCVZV2gpRLxuQc4zp+o2KwXmizI7c3tteaSGhhAEJdkM5LNaLRR/dnnsh+5ifHDSqCsnc09IKdFuXI+OAC74fNmFZkmzObQpXx2epgeO/LVXkoxeoUYjCxbvBZw3pUQfwYmU5/Hm7cA9XFxJY+Ku41FXKnVbgirIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePLn/19sws3bcmF/c0iOd8JtdJzzIJun04rnx3Ej+3U=; b=B2qfUReRwk3aRbzlCmiM8QlcNQL+YGS3Nj8Wb2i/zal+vnW/bwVs/NRVGqfF9DVz5PR9+Djm9uiiNCedmGpeZ6eJ4keXbgVp4x1E2h7Slnb7h02WVED7+V+kZVxMJuCE1E8+mKVkyptIx/sjfroc/WsKos0vHCAkD25c8FiW239H5cCGKkpwRbEfrO1wVccwlpjq1smqmm9KhjXsXvsivMuNm+ORLoYubTNtCvMgdiZfWxgPMrUXTV+JZRWz1+Q9x3qXMD2mrzCttv/gyRLY04jDN4fBYCEbn7IPXBGip6Xupwhb55gtodst2a4n1OHTi5FAYZ/GLgb+BWFnwOjXCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ePLn/19sws3bcmF/c0iOd8JtdJzzIJun04rnx3Ej+3U=; b=h6CXijfPuFryRyE/vSXdRu+UGNlcBwoUWSE8T1goi2Cmgp+gGmOljEX3tX5XZXvfiAe23KV0Ogq4JoVKtaPy+1HO3yF+1+Ncs306bNWXTbx9EtwHmmnlRubijkbp7VDOX1qxF9E/DR0pwqUv1CP5oW06l0o9dyKtx29o2D3G8OI= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rg Date: Thu, 5 May 2022 08:44:36 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E6186299A95C7F40ADFB8919A44ECAAE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a45636ef-b206-49a7-e40b-08da2e7380c1 x-ms-traffictypediagnostic: AM0PR08MB5425:EE_|AM5EUR03FT018:EE_|VE1PR08MB4958:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8DGJ2irUgFQyHFEc4eSWcxFIzY9fVkBek7O0MHLhhzZD7bjnhn3AoMLFNI/izZ5MjIsgxut6Wr11xv5ZaAXMOcV/4EBshC0BfFJJ1MzofTDgTVqCy9j1gijb52WVr5Cqn/asOrmZL1xsbnmNi3Th+cD1hUJUFRm/2FkYVkSxkcrJfBIM5XkHynCy9Nw+HN8s2taCjeunQkE6Y1fe5QgtBsc9UxiTZEwIHLX40xvDFphuVLPWcHy5rM3lCL8+zxs+jgZmBV1e80HKvb0RkrN47x73lVN/egVtCOH/BilKrMd/DACc8I1GDgzx9x/oVnTadqGjb4ieqbEnHVPi42Ir9kU//qjRhxddUSS4CWS3QPK65eLV+RTd2PRGCOasPLvRtDFlfmPcFyjPDBaP/+5Fm8XOiZYLPNDROntd31TKFgAJm4pifzjhy5eBoehiX26lrXQ8rxbXjZOY7sc6lkEX2YnPLCiTKdCCDlhrUl4syonUfvezwBfcx5ihjsxl02eW94HzwYNJlQ9t0LA8ynz8lZe5DafmjG8MsJoPWiagKfH9asfqh46mo0UJP6dQJzhx1CxEXS852t8YTouuI03M6e5aGQ7xfJM83WVY7bwUqrQi3PJxqGbyMWzr+JO9mw+rys519b+sPboKXRsXNy9IFum54pfovTFBk06B4sOs5gsE0f4/utxiT/HC2fJoXz7IvPkZCWuIlYkAO34RA0d+zOZ5W4QNe3WQQ14p87wpyok= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(86362001)(6916009)(4326008)(122000001)(2906002)(8676002)(26005)(6506007)(53546011)(54906003)(508600001)(83380400001)(7696005)(9686003)(186003)(71200400001)(8936002)(66946007)(38100700002)(38070700005)(66556008)(66476007)(55016003)(33656002)(76116006)(52536014)(66446008)(64756008)(5660300002)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5425 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ef146404-632e-4715-7cb0-08da2e737c33 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Scrbveixekn6QxG9CILu/p4MiXct2iPiz7JQvuzw7KvTzxw+mSg3X83BmlbvagfM08GZ1MyMAsVWfZcmT1yOM2+5x+Y6GmXyrnwXsa6vTOIdYZMJG2erCRxvgnuqCt1b2dmtrbrM78+Wjwih8nX+Aj9k6S3x7O2ofl9OQ7PL1gK6EipBA5QBNMJ7GvzOTYwomPgsdqPXZMIKvO/B/nKtFv5TzhWqRRBrN90M8C3Yqi+nnVppO3ogcodYuLIcdm6IH38CLsIzBEHUBjwAGYQtUUKy9bR9FU2ZoVLR9t1SFNSLB6w8Z3GKK2GQIvpH/1DDNv8wh/FR1swPhp9zVAO5/Z8h1AoLZWoQJetuNUTFZwNpCrQV8dmFIDiQ3mc3lEbqnUgvWbmeYpqtvAQN0Z7F1kWtqK0jmTOVmQzFCg+0b4RUH0cXw2Z4KNMBfm41t021jASf8kqMaEemD+/KMYmJvzKf9YtPdOdRfDpJi6au6C21+43kDyfDHBziAurUxPzJNepV222f49nlhuToEzGMuF4C+q2UT7JMf6DMPQ4HAldJbZIiKQjKaY980IZ1mcGIrXsmgdXoPnBNtDDnGecJUKXlr8t67RtkmByaEJHJrEADYuGSC3I8xtKnvM0h8Um9Diw6Ebznmj4rbq6z8ONXe1cZ6eML1xqbDBUwcJxUJiwcrwN+GT8VFGkixdv6nnBRX6SL5pjyP213xHOP7W4kWg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6506007)(9686003)(7696005)(26005)(316002)(54906003)(5660300002)(53546011)(8936002)(508600001)(186003)(55016003)(33656002)(336012)(70206006)(70586007)(8676002)(4326008)(6862004)(82310400005)(356005)(40460700003)(2906002)(81166007)(36860700001)(47076005)(83380400001)(52536014)(86362001)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:44:44.1905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a45636ef-b206-49a7-e40b-08da2e7380c1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4958 SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgMzo0 NyBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+IENjOiBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47 DQo+IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsg V2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcN Cj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA2LzZdIHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFn ZXMgb24NCj4gcG9wdWxhdGVfcGh5c21hcA0KPiANCj4gT24gMDUuMDUuMjAyMiAwODoyNCwgUGVu bnkgWmhlbmcgd3JvdGU6DQo+ID4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4gPj4gU2VudDogV2VkbmVzZGF5LCBNYXkgNCwgMjAyMiA5OjQ1IFBNDQo+ID4+DQo+ID4+ IE9uIDI3LjA0LjIwMjIgMTE6MjcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4gICNlbHNlDQo+ ID4+PiAgdm9pZCBmcmVlX3N0YXRpY21lbV9wYWdlcyhzdHJ1Y3QgcGFnZV9pbmZvICpwZywgdW5z aWduZWQgbG9uZw0KPiBucl9tZm5zLA0KPiA+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg Ym9vbCBuZWVkX3NjcnViKSAgew0KPiA+Pj4gICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4g Pj4+ICB9DQo+ID4+PiArDQo+ID4+PiAraW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRpY19wYWdl cyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBzbWZuLA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5yX21mbnMsIHVuc2lnbmVkDQo+ID4+PiAr aW50DQo+ID4+PiArbWVtZmxhZ3MpIHsNCj4gPj4+ICsgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7 DQo+ID4+PiArfQ0KPiA+Pg0KPiA+PiBJIGNhbid0IHNwb3QgYSBjYWxsZXIgb2YgdGhpcyBvbmUg b3V0c2lkZSBvZiBzdWl0YWJsZSAjaWZkZWYuIEFsc28NCj4gPj4gdGhlIF9faW5pdCBoZXJlIGxv b2tzIHdyb25nIGFuZCB5b3UgbG9vayB0byBoYXZlIG1pc3NlZCBkcm9wcGluZyBpdCBmcm9tDQo+ IHRoZSByZWFsIGZ1bmN0aW9uLg0KPiA+Pg0KPiA+Pj4gK21mbl90IGFjcXVpcmVfcmVzZXJ2ZWRf cGFnZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQNCj4gPj4+ICttZW1mbGFncykgew0K PiA+Pj4gKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gPj4+ICt9DQo+ID4+PiAgI2VuZGlm DQo+ID4+DQo+ID4+IEZvciB0aGlzIG9uZSBJJ2QgYWdhaW4gZXhwZWN0IENTRSB0byBsZWF2ZSBu byBjYWxsZXJzLCBqdXN0IGxpa2UgaW4NCj4gPj4gdGhlIGVhcmxpZXIgcGF0Y2guIE9yIGFtIEkg b3Zlcmxvb2tpbmcgYW55dGhpbmc/DQo+ID4+DQo+ID4NCj4gPiBJbiBhY3F1aXJlX3Jlc2VydmVk X3BhZ2UsIEkndmUgdXNlIGEgZmV3IENPTkZJR19TVEFUSUNfTUVNT1JZLW9ubHkNCj4gPiB2YXJp YWJsZXMsIGxpa2UNCj4gPiBkLT5yZXN2X3BhZ2VfbGlzdCwgc28gSSdkIGV4cGVjdCB0byBsZXQg YWNxdWlyZV9yZXNlcnZlZF9wYWdlIGd1YXJkZWQNCj4gPiBkLT5ieSBDT05GSUdfU1RBVElDX01F TU9SWQ0KPiA+IHRvbyBhbmQgcHJvdmlkZSB0aGUgc3R1YiBmdW5jdGlvbiBoZXJlIHRvIGF2b2lk IGNvbXBpbGF0aW9uIGVycm9yDQo+IHdoZW4gIUNPTkZJR19TVEFUSUNfTUVNT1JZLg0KPiANCj4g QSBjb21waWxhdGlvbiBlcnJvciBzaG91bGQgb25seSByZXN1bHQgaWYgdGhlcmUncyBubyBkZWNs YXJhdGlvbiBvZiB0aGUNCj4gZnVuY3Rpb24uIEkgZGlkbid0IHN1Z2dlc3QgdG8gcmVtb3ZlIHRo YXQuIEEgbWlzc2luZyBkZWZpbml0aW9uIHdvdWxkIG9ubHkgYmUNCj4gbm90aWNlZCB3aGVuIGxp bmtpbmcsIGJ1dCBDU0Ugc2hvdWxkIHJlc3VsdCBpbiBubyByZWZlcmVuY2UgdG8gdGhlIGZ1bmN0 aW9uIGluDQo+IHRoZSBmaXJzdCBwbGFjZS4gSnVzdCBsaWtlIHdhcyBzdWdnZXN0ZWQgZm9yIHRo ZSBlYXJsaWVyIHBhdGNoLiBBbmQgYXMgb3Bwb3NlZA0KPiB0byB0aGUgY2FsbCBzaXRlIG9wdGlt aXphdGlvbiB0aGUgY29tcGlsZXIgY2FuIGRvLCB3aXRoIC1mZnVuY3Rpb24tc2VjdGlvbnMNCj4g dGhlcmUncyBubyB3YXkgZm9yIHRoZSBsaW5rZXIgdG8gZWxpbWluYXRlIHRoZSBkZWFkIHN0dWIg ZnVuY3Rpb24uDQo+IA0KDQpTdXJlLCBwbHogY29ycmVjdCBtZSBpZiBJIHVuZGVyc3RhbmQgd3Jv bmdseToNCk1heWJlIGhlcmUgSSBzaG91bGQgdXNlICNkZWZpbmUgeHh4IHRvIGRvIHRoZSBkZWNs YXJhdGlvbiwgYW5kIGl0IHdpbGwgYWxzbw0KYXZvaWQgYnJpbmdpbmcgZGVhZCBzdHViIGZ1bmN0 aW9uLiBTb21ldGhpbmcgbGlrZToNCiNkZWZpbmUgZnJlZV9zdGF0aWNtZW1fcGFnZXMocGcsIG5y X21mbnMsIG5lZWRfc2NydWIpICgodm9pZCkocGcpLCAodm9pZCkobnJfbWZucyksICh2b2lkKShu ZWVkX3NjcnViKSkNCkFuZA0KI2RlZmluZSBhY3F1aXJlX3Jlc2VydmVkX3BhZ2UoZCwgbWVtZmxh Z3MpIChJTlZBTElEX01GTikNCg0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Thu May 05 08:50:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 08:50:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321855.542999 (Exim 4.92) (envelope-from ) id 1nmXCC-0004lL-Jt; Thu, 05 May 2022 08:50:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321855.542999; Thu, 05 May 2022 08:50:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXCC-0004lE-H4; Thu, 05 May 2022 08:50:48 +0000 Received: by outflank-mailman (input) for mailman id 321855; Thu, 05 May 2022 08:50:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXCB-0004l8-Pu for xen-devel@lists.xenproject.org; Thu, 05 May 2022 08:50:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7414b1e6-cc50-11ec-a406-831a346695d4; Thu, 05 May 2022 10:50:46 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-wir383SwNpOQVknM7N4V3Q-1; Thu, 05 May 2022 10:50:44 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5752.eurprd04.prod.outlook.com (2603:10a6:20b:a7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 08:50:43 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 08:50:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7414b1e6-cc50-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651740645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ak6H5CiI3ws0MkhZrIndIX8PvuJbEqaZ1rfQvkSoe9A=; b=jW7a25BZlEXdlzzEpYWzurw0gLEobJ2XRF7APiUSnoYUGYum+zo+VBHk7RJeoAFZYMUHo9 vd/dKzItZTZ8AIGayWjS8XKvEVNSnuXlrAttuGy2glixVb3YbxBZGczH1rpTMAiYIU0Q17 getVNM2t7NuvE4R+qgouojHrR4L2AAI= X-MC-Unique: wir383SwNpOQVknM7N4V3Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DnnO6GvbIAVA+bHTFM6bZQGhG79jVqMQdBL9jASfY1pMZ4hleDRbkdkiLfzuLL+S8vdT96f+tDy4sC/0+TGe4Q1ItGkhwuxNJNkKUJtW9T4VUuD0JLFMHG7XOYbd1vwuq7HWv6IzcrOmtA2KCh30MRv1uauMoZJR/v7Aj7DfBUmekZTT3NIxkI5iYd0GETfbd51S0Ytw6ELpCSP+YjVdRN6BQWE3Kjgh/4UTbFf5kdhnbBkSPZiKJxmWF/iDPLjWLxCLk7FPGiSJfpbvpxB6WoS4Ba4brxxqCIud6Pnpeq9k48AzaWL/7p1/u0m2vWkognz8/80SMq8c1bZc2kyq9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ak6H5CiI3ws0MkhZrIndIX8PvuJbEqaZ1rfQvkSoe9A=; b=bBMjBHXKk3JkhY8Wj/U/zjmYs3MQxMMjINL0gSZuiFGGVXjpG+yu+ekSI6NHTTOyCco1StZfi2Cr1Q1MbGDt128v7IHW/jFf29LKHy0uxWCzx1dVOhY8KqCpgZ/QRvTz81z4rgamgt5oxfKwSuqn5aH0p+oBpHmrx+bPR4cmp0BmsoSiFJvG4NiKuu8WGb6kAA6EnMcpc31ghDo+N4aK+mEqLOoprCcFccnmEoVYDskIBpJF9pINgb2GWnMWnVhqt6sd6otUCNBmoYyJxOchyUiJy+XgUtIVlgFS54egrf4V3/L1y7+3ybr45zHItBLvGokkNKeL3luPWEWAkYTSHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> Date: Thu, 5 May 2022 10:50:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:48b::20) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9aea18f-1cad-4fc4-c2a7-08da2e745670 X-MS-TrafficTypeDiagnostic: AM6PR04MB5752:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8UUHueoUIEoom7cc7vdfmwozZfC0H/SHjQAoWh67IKBLcnZ437VC6vQKt0rb6hBcwmbqUjU7K9GbJseL3+Q9SPzoQzuN5kXYALTu3oS1OU/ot/3wUk8uGxxpXy/bNsLnuqPcfKMCCseLz2OME0YetjHW6Z2QiIEwqXJ0wOSt9rsDDSMM5lZsvkjRQsnceu6sgee9e7Wj9uCc+YbROPDE0wTiI4tQmNyCgYt0EF5PVtUyogIzguK/DhaR2swolhaeF99SI7PCvE6befLqJf3PnpxsyCrBTKzxR2nVOBQBU1Yu38yIu/m6kt7veH6VW+6zMja4GRBpzXn9EaZCgBeLIJSNRHa1SuZt5HFLAw5LiXg80RNk1hdonh1oghpfmeNT3E/wfqCNo0gdFolpIUAkjO+tFsEXk1DOSEa7YjIyJKlliVrklTIg74A9sGDSal+02avLCfidPc1pPttt6jmHRbivw8v5t82anzHNv2CD5/UmL8JIYLjHDk7dGf8lkuFASIAy2K28iopxcxOpsGcw9+e9CFxMjSAEOG6okAmmiwmooCLBVrl/UsvP43kIyaC8LxMgiPmceysc0gStfsIlURxSjbkBCJKXJQ/d+qFHA2+ARNhwWRdeBvxoY5GmnewgUOfRZLf5z7MMyV8iiF2GHHgnx7M3bJRAQuvRiuuFqtuJg/qecIU0Dka3PJqI6klzGOP2+5y3+FiQTiAnjZ1e/hIyGI0B994c8UYcdqwcX2aTu0uMewCZ2INlLa/hKi20FE6NaF+WKmPk7pERiK3gpw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(26005)(6506007)(6512007)(53546011)(8936002)(31696002)(86362001)(186003)(2616005)(2906002)(36756003)(83380400001)(8676002)(4326008)(66946007)(508600001)(6486002)(66556008)(66476007)(5660300002)(6916009)(54906003)(38100700002)(316002)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmJ5ejBZRWluTk0vN0xrU2U1d1NEOTVITEh5L0IwOW0zT2RCbW5MSEJ6ZklV?= =?utf-8?B?Qm5kVHMyRUpUYXNXUmxrTU11c2ZkU1M2SEVyVElDdVIzbkdlOHJCN1ZvN0Nq?= =?utf-8?B?K2pkWXMvanEyay9oRWx2OWkyRlNOMmpRb25URndHcEdDcFFqNHZTdExQM1B0?= =?utf-8?B?Rm9OTm9LK1R4NEU1UjlJOTh0MnNYMmI4bmo1UUwvL2MrSHFPcHNaRk85bmpp?= =?utf-8?B?NWFtOUFZOWU4c0E0UGhDaWxKRXNvclhLRXRTRWxtYWhwRW5TVTNWQ09aTkFp?= =?utf-8?B?UytYeFdCbElGNkhTTkxUMlJqaC95SUJieUdUWTlJZllOb2Q0Nkd1UTRIN3Jl?= =?utf-8?B?UC9CNjVyWVVIanEyM3NSOGhoVUdHS3VYVHgxTmErekNJYzhNYVAyWnpFdVAz?= =?utf-8?B?N1BEMUNOd25TR0Q3aEhLaiszandsdndUaVMwVnY1TGE4NGMzOXk0MGpwd1Zy?= =?utf-8?B?Y0NjUGFHWTM4UkRxZFNETUI4Qzg0dlY3UVB4YnpISjVlSEpjdWZZYTNEZTVw?= =?utf-8?B?SklROWU3N3ZrblZZOVZ5Q0pDSTlkMTRiRzE3TEwvc2x0K080dkdYd0pVQnps?= =?utf-8?B?QkYvc0VYY0xxV2dJek9OMmM2aWU1bmJpYzlDS2JJeTBGQlBFcVl2R0R6d2h4?= =?utf-8?B?ZlVZbXdrTlJORzVYUEF3anE4Ykt3OFZ1M291TCtsa3JjRjhZcmdiR2pRc3FE?= =?utf-8?B?dmRMTllad2tpWmF5OVJ1djR4dVAwTDU2TE1HdGgrQ1RtTURnVHk3YzJDRGhU?= =?utf-8?B?UUIvUXFwUm1kNkNRUTJYc3d2TWdnMmpYem1uVTExVW1YNWJNUE9yOWJ0QkZ5?= =?utf-8?B?VFpnS2FzSTg1YmU5MUo1L2VHQkNWVU94M05JUzdEYXNuc0tHYTV0ZWIwRXhw?= =?utf-8?B?ekFpV2syazVlM2ZxWjJBeTRTYkdKVmZVa2RoazZ3RjNMaGllQ3QvaHllNkhm?= =?utf-8?B?a3hzdVREWWx3NG1qcFEvTVFlSGZFZG1aR2Nvai9ZN2tEL29WQ1JodWhGZkk5?= =?utf-8?B?a2x2czNac01sdkRjU1hhNGZFT3Y0T3VhWTRnZ3ZhZzZVbkdHK20rd2pETjJy?= =?utf-8?B?S2NKNUV3dE0vVEhZN1N2N040ZUdka1J3MFYrMGxLVFFVTnRiVytIaU42T0xJ?= =?utf-8?B?T1hkY1prcmIySFJQY3JOTGJxcU1kZGdWa1FqVjFXNjBiQVVzdEYzU0FSM29D?= =?utf-8?B?Qmp5aUFLMGV4OTVTY2NkK1ZHWnJPd3Z1eUxHV0Zwc0VZV3RWenJSckM5NXVU?= =?utf-8?B?THViVHdSQnA5ekgrL0E2NFMvM2xIUmdHYTY4RXBPejlVWnIxSlAxUkFtTU8y?= =?utf-8?B?aTNBU0pDN1FHYndVTVlFZlRFb2ZmQVIxbnpPalNYaXpGdWJ0ejZNK1dhcW5z?= =?utf-8?B?TkdHSVBBdkVHdUtTUlBtVTV5ZzhTVWJHeE1ndEcwU2NKMjhTLzI0UDR1NnVG?= =?utf-8?B?eFdyNzcrOXF6aFV2SVdSb2d0Z3V3dEdZNXFpYWlKVDJSRWYzeFVHSlpZclV1?= =?utf-8?B?ZG9mWkxwcnQ2bnFacGI5VlorUStGNUg0SXpoRjBhenZ6VlFGRkFzR1ZKMkVB?= =?utf-8?B?clQ0V3FMdVlTQWdVamRMMlFXbHBGZ2VDaDU0UWp0U0V6QjhHd0hTcElJWUdK?= =?utf-8?B?aWp3dnlicU5FS05uY1VoRDRWYkNjSGFsTk9iZzVTamVpNFA2TTRvZ0h4ZDF2?= =?utf-8?B?WUx0cVUrYjVjeWJjc2s2NzQ0dmZ5dlpOMno4b3M0Njd6bEcwd3JWcjhRYmlU?= =?utf-8?B?WS9CSHJLaVU5a2JQTE9LVERvVmx0bXVHVjBkcUN3QWZKWk9uSkhJeTlzbUxx?= =?utf-8?B?bmF5L1M0Q2N6MzFlSUtHVzRtSklLc2FET2JCTEVveElBeUxxTnEyZFNjdEho?= =?utf-8?B?UEtVNDlWNGhMcWJtWUpCeEttYkVwUUVzelJqd2VYK0xqeXd2Mko1VHM5c2hF?= =?utf-8?B?TVg4T21rc1VNT2YwNHZnOHBzeGE1enN0UWZQSHB6aDNOQkt1TUtKM0F1L2xC?= =?utf-8?B?MGVRRklUTWJ6VUZyUWZndXQ3UFpBd2lzVytlQUNobmQ0SUtZS3lIamozNFVQ?= =?utf-8?B?SFE3ckdwZmhQS0F4WUxFanl2SFErL1ZoTjFqdHgzS0R4dENNNFB4VVRFQ3o5?= =?utf-8?B?eVZYTjBiV3J1Q1pQaGZVbS9wRmVMME8yQzdqaEdRcVVpMEY2cUcxaFdQeGll?= =?utf-8?B?V0NrbW9BdlZrZUkyaUN6MGxndTkreG84VExsTjU1L3VvRjdpeGhvN1JDN3J2?= =?utf-8?B?UncwMy9CMUdjcXNickdxQzVrOTRxeWlUVmdkNnVWVFpjRmZqMDZ3M3lwK0Nw?= =?utf-8?B?ZEU0ZUFFTjFwYmY4cDRPSmtPZVZJTzUrVjNKMk1xZWtlSEhRMENSdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9aea18f-1cad-4fc4-c2a7-08da2e745670 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:50:42.9223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eZe5TxKfGynyKGcEU3Rbcuv+m7xbnC+UiY+oKU3n4Plh2jthYkkhJ47w7q7+v7r0wUP3tkOt+cDEG9VFppinuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5752 On 05.05.2022 10:44, Penny Zheng wrote: > Hi jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Thursday, May 5, 2022 3:47 PM >> To: Penny Zheng >> Cc: Wei Chen ; Henry Wang ; >> Andrew Cooper ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; Wei Liu ; xen- >> devel@lists.xenproject.org >> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on >> populate_physmap >> >> On 05.05.2022 08:24, Penny Zheng wrote: >>>> From: Jan Beulich >>>> Sent: Wednesday, May 4, 2022 9:45 PM >>>> >>>> On 27.04.2022 11:27, Penny Zheng wrote: >>>>> #else >>>>> void free_staticmem_pages(struct page_info *pg, unsigned long >> nr_mfns, >>>>> bool need_scrub) { >>>>> ASSERT_UNREACHABLE(); >>>>> } >>>>> + >>>>> +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, >>>>> + unsigned int nr_mfns, unsigned >>>>> +int >>>>> +memflags) { >>>>> + ASSERT_UNREACHABLE(); >>>>> +} >>>> >>>> I can't spot a caller of this one outside of suitable #ifdef. Also >>>> the __init here looks wrong and you look to have missed dropping it from >> the real function. >>>> >>>>> +mfn_t acquire_reserved_page(struct domain *d, unsigned int >>>>> +memflags) { >>>>> + ASSERT_UNREACHABLE(); >>>>> +} >>>>> #endif >>>> >>>> For this one I'd again expect CSE to leave no callers, just like in >>>> the earlier patch. Or am I overlooking anything? >>>> >>> >>> In acquire_reserved_page, I've use a few CONFIG_STATIC_MEMORY-only >>> variables, like >>> d->resv_page_list, so I'd expect to let acquire_reserved_page guarded >>> d->by CONFIG_STATIC_MEMORY >>> too and provide the stub function here to avoid compilation error >> when !CONFIG_STATIC_MEMORY. >> >> A compilation error should only result if there's no declaration of the >> function. I didn't suggest to remove that. A missing definition would only be >> noticed when linking, but CSE should result in no reference to the function in >> the first place. Just like was suggested for the earlier patch. And as opposed >> to the call site optimization the compiler can do, with -ffunction-sections >> there's no way for the linker to eliminate the dead stub function. >> > > Sure, plz correct me if I understand wrongly: > Maybe here I should use #define xxx to do the declaration, and it will also > avoid bringing dead stub function. Something like: > #define free_staticmem_pages(pg, nr_mfns, need_scrub) ((void)(pg), (void)(nr_mfns), (void)(need_scrub)) > And > #define acquire_reserved_page(d, memflags) (INVALID_MFN) No, I don't see why you would need #define-s. You want to have normal declarations, but no definition unless STATIC_MEMORY. If that doesn't work, please point out why (i.e. what I am overlooking). Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 09:16:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 09:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321877.543014 (Exim 4.92) (envelope-from ) id 1nmXbD-0007fF-R3; Thu, 05 May 2022 09:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321877.543014; Thu, 05 May 2022 09:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXbD-0007f8-OR; Thu, 05 May 2022 09:16:39 +0000 Received: by outflank-mailman (input) for mailman id 321877; Thu, 05 May 2022 09:16:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXbC-0007ex-6H; Thu, 05 May 2022 09:16:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXbC-0001a1-3s; Thu, 05 May 2022 09:16:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXbB-0000tl-Jb; Thu, 05 May 2022 09:16:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmXbB-00061y-Iz; Thu, 05 May 2022 09:16:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H5OlRYYC2WuT9un/htIg6oriLfsSee3zo6u7SIM9MX4=; b=ybKyjAKEIe2Mc9qYcEiEfKXAQS l9vFIJOXFCBfB8KuhqKYd9nggokqAlzMMv6zQK/CVplkxwUXOxVzrz6HYKmV0Cs4GhzjPWiJPqWtE piSm607sj5Y7kuGODEjgCk8YqbC4HdSIHWWRiKJPtckc8Jal5580qtziHIhru+lRC0eM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170143: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 09:16:37 +0000 flight 170143 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170143/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 816 attempts Testing same since 170038 2022-05-03 10:12:47 Z 1 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 09:29:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 09:29:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321886.543025 (Exim 4.92) (envelope-from ) id 1nmXnW-0000oT-W4; Thu, 05 May 2022 09:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321886.543025; Thu, 05 May 2022 09:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXnW-0000oM-TF; Thu, 05 May 2022 09:29:22 +0000 Received: by outflank-mailman (input) for mailman id 321886; Thu, 05 May 2022 09:29:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXnU-0000oG-W9 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 09:29:21 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on062b.outbound.protection.outlook.com [2a01:111:f400:fe05::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6e3c519-cc55-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 11:29:19 +0200 (CEST) Received: from AM5PR1001CA0050.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::27) by AM0PR08MB2962.eurprd08.prod.outlook.com (2603:10a6:208:5b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:29:17 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::8) by AM5PR1001CA0050.outlook.office365.com (2603:10a6:206:15::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Thu, 5 May 2022 09:29:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 09:29:16 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Thu, 05 May 2022 09:29:16 +0000 Received: from 7392b9c90a74.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD3DCFFB-BFAF-42D3-BE1E-F68DFFF9AA5E.1; Thu, 05 May 2022 09:29:06 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7392b9c90a74.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 09:29:06 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR0801MB1886.eurprd08.prod.outlook.com (2603:10a6:800:8b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:29:03 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 09:29:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6e3c519-cc55-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BCnt22bYRygT46cOYbbJcg4S+2GMvreb2x4JCECUX75bkwpufhJ+bNW1itas2eOUbGrOERqmVN6cdwZbi4en+w350JGyEmHLVOG3Bn0C54ZXDnXVz0lZtWAvr7xp4rY1K+aTUMamzKR32yPSpBcenwgQA9XLxCcMhFOlH/Mwhoe0g6EGZfqu4gtbBH31dLeoVeTyT/fFBrKcjuriD/hCThlyh9Nb1fxHe+0kI3Dnl8lu7cViGWkr5qaV34Gh3BFqlbtv7XYuIhfDQnh84Ha2h+3jv2BoYaNYgTEsQLGVS7O6GOjVbaJ3vSlhIzVhyrcz4B77SuT78THMeJa2LMV3Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9uNSsv0Xm/N7smwIAHAnezWvsSLYubikA8hEGczJDgA=; b=GtQEtbkBKNScZfQlJq2tLnZq8TQY+eLOwTzleJOiJ55BTSMrTgrxGDOQGmiKecDd4yEbsEBhvzSVEMxWt6V5Xd0w61i1HJQO2rzDrpxGHAMUg4LshmiLDfFiDaxAITcXtCa1qh/6FDrgxbUxGrtcHG/CFAcIz766ZBaV+6CWoqjnAbBeoUeIDVRhCG7zTyepATJy9YF/5JjSy+5djqJwOMmiIvXsLq78sPVctLqYv0yuJZB/R4aQYvhgMFwE57x8fiSsSEZRidCJBuf17ooF10nItftN/LHMx9jKo9sftHg8OCilUfG1DsVLMhutFAXOZF81sjUqPs4k1mdIswftvQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uNSsv0Xm/N7smwIAHAnezWvsSLYubikA8hEGczJDgA=; b=pm3PLBwBkO8yDpdp9DaGBmlUu2KOx2Ls3y44Y6BF2y93VXioLUMUeHoDo8CXgaC6+Meo+V0SDtefdzGoj7PsfYjR2IemQgowiIYpAXORaY8GSJI/Ni4YAYLXIhOHK1zAgtJQTVBYWqnL33SZZk8NIO4s1I05GF7yh5oMyHHo908= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QhZ7wG4aeuIXx2NnrrvqmoWl4+mTR8b6TUT/GjEKJexEP6+TCMy9fEW6OoOJJOC9FkjFdoGjbtTDBspTVYEaJIyeQHsDr6E3Z5TQNuj9SUxDo2AzOSojzGjJ+6OLVyuP/q6muzpx/vGYladzU6FQlE3RRfqifdTWyhDnA8VTAUqrlFNUjWIemTOZEGW5HMtqADeR4PRg4nJY9kK/i9MS2ejcBnY3eoeEIJELAVxA47S5HdhQ/7CKF57fu6KKgQN0BDUooMt3L22yEs63SzKPaC7DZdYjnYec1LSXIPkWXSaAwvknedAbqto+3ZEbdH7TzSrD8cduhWjiz+lHAZJ4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9uNSsv0Xm/N7smwIAHAnezWvsSLYubikA8hEGczJDgA=; b=aF4UPWM0urbRt631Of9r2V4p5qdlfohaogv2kwpK0OHC5XJa5ROYtWIssipWGdH9UUcdGYnN7YfqiWwB6pwqZ/pKT1AyIGldnSfelaRsltOODZ5Cz76wb92LMGX3LjdKyb5txleXPy78DVbljPonWVqc0EQtcLzai3ivattUc6RRDuAdTqk4U4386xeuTBLmmglhLj7oxgiSd1n8JNKbezi0DbWG4PGqoasRMeSbq/cK+F5XqAJ4G6rCT+phSNp/Npv3bgHqLCnWqwEwc6lOZ9MRNxckAK4beXqJHaQL2Gx+kxUNgzXDYiGIt60ijS31yH+TeixWI/dgU66gVwLwtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uNSsv0Xm/N7smwIAHAnezWvsSLYubikA8hEGczJDgA=; b=pm3PLBwBkO8yDpdp9DaGBmlUu2KOx2Ls3y44Y6BF2y93VXioLUMUeHoDo8CXgaC6+Meo+V0SDtefdzGoj7PsfYjR2IemQgowiIYpAXORaY8GSJI/Ni4YAYLXIhOHK1zAgtJQTVBYWqnL33SZZk8NIO4s1I05GF7yh5oMyHHo908= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUA== Date: Thu, 5 May 2022 09:29:03 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> In-Reply-To: <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1976E5EF62171C40A3B2D53E034770FB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e87da999-821e-45d1-bc85-08da2e79b9d4 x-ms-traffictypediagnostic: VI1PR0801MB1886:EE_|VE1EUR03FT055:EE_|AM0PR08MB2962:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c6vmgTjslyjEp2YnFvmPmx8YnB4JTHMMHw4VSaG6D4zipcd0JynM2iWNFxH/XK2+8bIwDoRQCRNSBjHolY1KQI3ni7KaRkEAXB8xYTlfykgZHlODVZ5iiFjkADOESd2rBk6lB+AOtoejY1SNCbjEetbp6MGJqQv+wSHTnXO6DNI13opZkuJLu/d4Og9OEnJnowggxX5FV2xQIG/ji1uicjz8CRq9mD1XkPrZpl5oPmOyaUc5QoW2Xbw/IZn/60BTucQvBK5asCPM4qmfrh677hVE402wJOjQVt4iqmPd3pkEVej0IvjJopQBh9gtsoO8sBIueyzj9WgYLyEOs11GVm0WU5LMjqUYgeYSqVl6bVuXnmgHTFzaKbpeDqp5iIug8kItNxas3waiTthHT9uOy5H3GvRWp4JoGM1wX84LHWGzt+gS/84YYWBQ4bh1aohvLg880e7JHBORfK8Od3ynqc58wVeoPYIoS+LddOMDYXijxrLsUzdToEF1zGxqWi64x4htMRGrhc9GTyl/4YrHmHDE1fJ2DnqoDoaXA3GXbimdOA6DrIcFH/KLpvz8yzmUb8qRaIN7hUbuuWBefyyBDN4RJsijlNKEZ2ORuuqtxzkhmOWgY581cZd927uNoobCqW9i/YI5Rfy1HAp9Qb8420U6DT2nM8Stv3WXoOhwQo0CfLqDjXyCirxwMEwTZfyk+mgge4UAL/8aBkUXuvlOaVWLGsbTS3ffUJLmrV+UAcE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(66946007)(66476007)(66556008)(66446008)(8676002)(76116006)(4326008)(71200400001)(38070700005)(86362001)(508600001)(186003)(6916009)(316002)(54906003)(53546011)(83380400001)(26005)(7696005)(122000001)(6506007)(9686003)(55016003)(8936002)(52536014)(33656002)(2906002)(5660300002)(38100700002)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1886 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 14d9e41c-57a2-402a-f026-08da2e79b1b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lbzUP6toL+BE+aEnG/QHSlVNOcUsgZBAzTPICTkEzwVGahlBWQcIOAOSPuLSO10wQNHWVdEqshMGLemm/m3GWzzmLRVw8gDHdRIWvA2rcwo7XSOIUSCoI/Cyk5ru/6Wvzt0FIptRZUfMduaGJJ4x7FAQs3Ie+BnUa/PpyIHEt2V2Wzr8esmmLDYG2hFLiXgdNrUZQf9K+FvQ5QZwwCMKpzOeOn34DS/rnh4HXIxufEzd230MLL1JJYBexr8+JOjGYLhrBAj91b/X/yfe1bCA2oI8kfUQK07RxlIda2H5MJr8n9jd08xyVXs5FmLYXLwmI7p1uWP92B5Y8ovGXIW8gkqvgGgWd+9PBvKpIxDWo4HXpAsCk8HbhRcaq4h/Sah2S6wZS0rxwYa+qmQefVSlVJVYxVqKe4NsZCjTP2BaMLT9lC3i7MSr8bM2AU891GPC/wD/qMW+YybfMHfloUcu6YrIrE5M2rwKf+pYbmUVcVxuc/aKvmfJ/BwXU03O2vcvxRvRVgjCXZGZx0TMtLlXVoBTKmpz/eqXgszygFm+2KzUZxuWcAQHap5m/z3OV+Rrz02xl43XktiYWSsXk3P3opWxShFKzADDYjpxx3cdhCj1A4Qzwe8ah0CbD5PnScL/Xl00n3Eft38Sc5rGxsedVmbrPNTkjhK5L+U8w8cwNUyxEO5FvZHslZZ82lAznZ+Spn+WlhQ0PB+WviIXzyzJPA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(9686003)(2906002)(83380400001)(70206006)(70586007)(33656002)(40460700003)(4326008)(6862004)(8676002)(81166007)(36860700001)(82310400005)(54906003)(55016003)(356005)(186003)(26005)(53546011)(6506007)(316002)(7696005)(5660300002)(8936002)(336012)(52536014)(508600001)(86362001)(47076005)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 09:29:16.8743 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e87da999-821e-45d1-bc85-08da2e79b9d4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2962 SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgNDo1 MSBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+IENjOiBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47 DQo+IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsg V2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcN Cj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA2LzZdIHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFn ZXMgb24NCj4gcG9wdWxhdGVfcGh5c21hcA0KPiANCj4gT24gMDUuMDUuMjAyMiAxMDo0NCwgUGVu bnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgamFuDQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0NCj4gPj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+ PiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgMzo0NyBQTQ0KPiA+PiBUbzogUGVubnkgWmhl bmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+ID4+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJt LmNvbT47IEhlbnJ5IFdhbmcNCj4gPEhlbnJ5LldhbmdAYXJtLmNvbT47DQo+ID4+IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwDQo+ID4+IDxn ZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsg U3RlZmFubw0KPiA+PiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgV2VpIExp dSA8d2xAeGVuLm9yZz47IHhlbi0NCj4gPj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4g Pj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA2LzZdIHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFn ZXMgb24NCj4gPj4gcG9wdWxhdGVfcGh5c21hcA0KPiA+Pg0KPiA+PiBPbiAwNS4wNS4yMDIyIDA4 OjI0LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4+PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQo+ID4+Pj4gU2VudDogV2VkbmVzZGF5LCBNYXkgNCwgMjAyMiA5OjQ1IFBN DQo+ID4+Pj4NCj4gPj4+PiBPbiAyNy4wNC4yMDIyIDExOjI3LCBQZW5ueSBaaGVuZyB3cm90ZToN Cj4gPj4+Pj4gICNlbHNlDQo+ID4+Pj4+ICB2b2lkIGZyZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVj dCBwYWdlX2luZm8gKnBnLCB1bnNpZ25lZCBsb25nDQo+ID4+IG5yX21mbnMsDQo+ID4+Pj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgbmVlZF9zY3J1YikgIHsNCj4gPj4+Pj4gICAg ICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gPj4+Pj4gIH0NCj4gPj4+Pj4gKw0KPiA+Pj4+PiAr aW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5f dCBzbWZuLA0KPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgbnJfbWZucywgdW5zaWduZWQNCj4gPj4+Pj4gK2ludA0KPiA+Pj4+PiArbWVtZmxh Z3MpIHsNCj4gPj4+Pj4gKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gPj4+Pj4gK30NCj4g Pj4+Pg0KPiA+Pj4+IEkgY2FuJ3Qgc3BvdCBhIGNhbGxlciBvZiB0aGlzIG9uZSBvdXRzaWRlIG9m IHN1aXRhYmxlICNpZmRlZi4gQWxzbw0KPiA+Pj4+IHRoZSBfX2luaXQgaGVyZSBsb29rcyB3cm9u ZyBhbmQgeW91IGxvb2sgdG8gaGF2ZSBtaXNzZWQgZHJvcHBpbmcgaXQNCj4gPj4+PiBmcm9tDQo+ ID4+IHRoZSByZWFsIGZ1bmN0aW9uLg0KPiA+Pj4+DQo+ID4+Pj4+ICttZm5fdCBhY3F1aXJlX3Jl c2VydmVkX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50DQo+ID4+Pj4+ICttZW1m bGFncykgew0KPiA+Pj4+PiArICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPiA+Pj4+PiArfQ0K PiA+Pj4+PiAgI2VuZGlmDQo+ID4+Pj4NCj4gPj4+PiBGb3IgdGhpcyBvbmUgSSdkIGFnYWluIGV4 cGVjdCBDU0UgdG8gbGVhdmUgbm8gY2FsbGVycywganVzdCBsaWtlIGluDQo+ID4+Pj4gdGhlIGVh cmxpZXIgcGF0Y2guIE9yIGFtIEkgb3Zlcmxvb2tpbmcgYW55dGhpbmc/DQo+ID4+Pj4NCj4gPj4+ DQo+ID4+PiBJbiBhY3F1aXJlX3Jlc2VydmVkX3BhZ2UsIEkndmUgdXNlIGEgZmV3IENPTkZJR19T VEFUSUNfTUVNT1JZLW9ubHkNCj4gPj4+IHZhcmlhYmxlcywgbGlrZQ0KPiA+Pj4gZC0+cmVzdl9w YWdlX2xpc3QsIHNvIEknZCBleHBlY3QgdG8gbGV0IGFjcXVpcmVfcmVzZXJ2ZWRfcGFnZQ0KPiA+ Pj4gZC0+Z3VhcmRlZCBieSBDT05GSUdfU1RBVElDX01FTU9SWQ0KPiA+Pj4gdG9vIGFuZCBwcm92 aWRlIHRoZSBzdHViIGZ1bmN0aW9uIGhlcmUgdG8gYXZvaWQgY29tcGlsYXRpb24gZXJyb3INCj4g Pj4gd2hlbiAhQ09ORklHX1NUQVRJQ19NRU1PUlkuDQo+ID4+DQo+ID4+IEEgY29tcGlsYXRpb24g ZXJyb3Igc2hvdWxkIG9ubHkgcmVzdWx0IGlmIHRoZXJlJ3Mgbm8gZGVjbGFyYXRpb24gb2YNCj4g Pj4gdGhlIGZ1bmN0aW9uLiBJIGRpZG4ndCBzdWdnZXN0IHRvIHJlbW92ZSB0aGF0LiBBIG1pc3Np bmcgZGVmaW5pdGlvbg0KPiA+PiB3b3VsZCBvbmx5IGJlIG5vdGljZWQgd2hlbiBsaW5raW5nLCBi dXQgQ1NFIHNob3VsZCByZXN1bHQgaW4gbm8NCj4gPj4gcmVmZXJlbmNlIHRvIHRoZSBmdW5jdGlv biBpbiB0aGUgZmlyc3QgcGxhY2UuIEp1c3QgbGlrZSB3YXMgc3VnZ2VzdGVkDQo+ID4+IGZvciB0 aGUgZWFybGllciBwYXRjaC4gQW5kIGFzIG9wcG9zZWQgdG8gdGhlIGNhbGwgc2l0ZSBvcHRpbWl6 YXRpb24NCj4gPj4gdGhlIGNvbXBpbGVyIGNhbiBkbywgd2l0aCAtZmZ1bmN0aW9uLXNlY3Rpb25z IHRoZXJlJ3Mgbm8gd2F5IGZvciB0aGUgbGlua2VyDQo+IHRvIGVsaW1pbmF0ZSB0aGUgZGVhZCBz dHViIGZ1bmN0aW9uLg0KPiA+Pg0KPiA+DQo+ID4gU3VyZSwgcGx6IGNvcnJlY3QgbWUgaWYgSSB1 bmRlcnN0YW5kIHdyb25nbHk6DQo+ID4gTWF5YmUgaGVyZSBJIHNob3VsZCB1c2UgI2RlZmluZSB4 eHggdG8gZG8gdGhlIGRlY2xhcmF0aW9uLCBhbmQgaXQgd2lsbA0KPiA+IGFsc28gYXZvaWQgYnJp bmdpbmcgZGVhZCBzdHViIGZ1bmN0aW9uLiBTb21ldGhpbmcgbGlrZToNCj4gPiAjZGVmaW5lIGZy ZWVfc3RhdGljbWVtX3BhZ2VzKHBnLCBucl9tZm5zLCBuZWVkX3NjcnViKSAoKHZvaWQpKHBnKSwN Cj4gPiAodm9pZCkobnJfbWZucyksICh2b2lkKShuZWVkX3NjcnViKSkgQW5kICNkZWZpbmUNCj4g PiBhY3F1aXJlX3Jlc2VydmVkX3BhZ2UoZCwgbWVtZmxhZ3MpIChJTlZBTElEX01GTikNCj4gDQo+ IE5vLCBJIGRvbid0IHNlZSB3aHkgeW91IHdvdWxkIG5lZWQgI2RlZmluZS1zLiBZb3Ugd2FudCB0 byBoYXZlIG5vcm1hbA0KPiBkZWNsYXJhdGlvbnMsIGJ1dCBubyBkZWZpbml0aW9uIHVubGVzcyBT VEFUSUNfTUVNT1JZLiBJZiB0aGF0IGRvZXNuJ3Qgd29yaywNCj4gcGxlYXNlIHBvaW50IG91dCB3 aHkgKGkuZS4gd2hhdCBJIGFtIG92ZXJsb29raW5nKS4NCj4gDQoNCkkgd2FzIHRyeWluZyB0byBh dm9pZCBkZWFkIHN0dWIgZnVuY3Rpb24sIGFuZCBJIHRoaW5rICNkZWZpbmUtcyBpcyB0aGUgd3Jv bmcgcGF0aC4uLg0KU28sIEkgZ3Vlc3MgSWYgSSByZW1vdmUgdGhlIEFTU0VSVF9VTlJFQUNIQUJM RSgpIHBhcnQgYW5kIG9ubHkgbGVhdmUgdGhlIGVtcHR5DQpmdW5jdGlvbiBib2R5IHRoZXJlLCB0 aGUgQ1NFIGNvdWxkIGRvIHRoZSBvcHRpbWl6YXRpb24gYW5kIHJlc3VsdCBpbiBubyByZWZlcmVu Y2UuDQoNCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 05 09:30:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 09:30:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321891.543036 (Exim 4.92) (envelope-from ) id 1nmXoV-000267-9P; Thu, 05 May 2022 09:30:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321891.543036; Thu, 05 May 2022 09:30:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXoV-000260-6D; Thu, 05 May 2022 09:30:23 +0000 Received: by outflank-mailman (input) for mailman id 321891; Thu, 05 May 2022 09:30:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXoU-00025q-Jr; Thu, 05 May 2022 09:30:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXoU-0001pz-F2; Thu, 05 May 2022 09:30:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmXoU-0001C7-3T; Thu, 05 May 2022 09:30:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmXoU-0001nG-2y; Thu, 05 May 2022 09:30:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6KRN8xpBLytyQ42XZVpll8zEWkmG1MdYc1B9uuPoU7c=; b=FH6IaHVOPoVnXf4IFWJEgRlxwC FGiz9P6PX32uj9rDrxDJBxctrYfStc7XlFFku9p/JgEhJa5SxPqxPIdcywikU3DPx+h5NgN8PzxDp FYGT4YfesPvuEldVXf/8EHdoutK5FgdELRw1Bub12TwXWYKOEnf7GKxeEZ2x/Hpyk/pw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170133: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5d2d5365ffadf075fd812038ab0841a3e868f906 X-Osstest-Versions-That: xen=702c9a800eb3ecd4b8595998d37a769d470c5bb0 From: osstest service owner Date: Thu, 05 May 2022 09:30:22 +0000 flight 170133 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170133/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 170071 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170071 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170071 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170071 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170071 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170071 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170071 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170071 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170071 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170071 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170071 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170071 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170071 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 5d2d5365ffadf075fd812038ab0841a3e868f906 baseline version: xen 702c9a800eb3ecd4b8595998d37a769d470c5bb0 Last test of basis 170071 2022-05-04 01:52:23 Z 1 days Testing same since 170133 2022-05-05 01:53:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jens Wiklander Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 702c9a800e..5d2d5365ff 5d2d5365ffadf075fd812038ab0841a3e868f906 -> master From xen-devel-bounces@lists.xenproject.org Thu May 05 09:49:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 09:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321906.543052 (Exim 4.92) (envelope-from ) id 1nmY6W-0003qi-Un; Thu, 05 May 2022 09:49:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321906.543052; Thu, 05 May 2022 09:49:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmY6W-0003qb-RW; Thu, 05 May 2022 09:49:00 +0000 Received: by outflank-mailman (input) for mailman id 321906; Thu, 05 May 2022 09:48:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmY6V-0003qV-Ak for xen-devel@lists.xenproject.org; Thu, 05 May 2022 09:48:59 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95822f1e-cc58-11ec-a406-831a346695d4; Thu, 05 May 2022 11:48:58 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso4740439wme.5 for ; Thu, 05 May 2022 02:48:58 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id 7-20020a05600c230700b003942a244edbsm1122594wmo.32.2022.05.05.02.48.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 02:48:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95822f1e-cc58-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=pSvw9K1FYxiVG0Z10oAKU+AQrsUSBrFUaiCoJdmHWuc=; b=KoRvUAl+/qpGx0yGTKaAV/486S+mgxPNc9P1T2dlsR0k7NOVOYCy07czgeRefxC49z bh7r9O95uA8InAHWJYZWaHqG7z97dS/OLHrpxLAOHhl4NYncqV+XHwxLCpanNisHNCBh 2rBm+q1k8rAcGZeSdEoaJ/K6jQCkZUjqnUIspD+TYmodURIbi+92ZchDDS77U7uU9xnq 5npoDYKvl1WtDC+b9ayjQmUL7E6oGHdEWKcJsFer+ZXW68a9sGPcDOwt3ZfCE5F56SrR w8U8aDyCkW9CevOt1wevF4PalQweXdeo+vSNKgzqE5YZuAxwL6IXrZwUQ1MVydVjUnSO gFwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pSvw9K1FYxiVG0Z10oAKU+AQrsUSBrFUaiCoJdmHWuc=; b=wj4RPNIPjeox0qBOFFP5b6oCCqUaknQD3wgQ171oo7qqNUahhYvx4IAPhcIYRtQWmX CC7UdiKkc77SWz5/uUe1PzwR8VcORlCrkmp687OOPm7WN502mC9E7QtR/x2xE0DP27LL 0hOdu04pRtdzTP7yfwQG8Ptd6XxYunbTldQPRj7V7rncLQ6NlbFZ6a7MEoT4sCb5cEfd bAA4+ccFKC0XWED2NQyI03CRDcG6J6kFKe0zhZHZ080I9ALHtGSJG7hGPcx+jxcL9kfo pl90FPKytfuUCcIqN90Wk0/lrU4ZT0seAdpvyjuMqeJDKlpDjiATayf1vV8Foi3gtEhx y6zw== X-Gm-Message-State: AOAM530ndC/KBotq2/56PyVnIrzgzPGagRYkskC+qmiQve+IFjxHiOxO txQRV7bSQwegaWJ6+UKCiq5IHtoJTmQ= X-Google-Smtp-Source: ABdhPJw2ZpARWggm0W0a3xNvR1XD67CV3GZ8YCbaGcTimHSLTXqOArruatu5KcghWtvXGScNTUE9mw== X-Received: by 2002:a05:600c:1f1a:b0:394:29c1:6d82 with SMTP id bd26-20020a05600c1f1a00b0039429c16d82mr3634809wmb.111.1651744137436; Thu, 05 May 2022 02:48:57 -0700 (PDT) Subject: Re: [PATCH v6 2/7] xen/arm: implement domU extended regions To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu References: <20220505001656.395419-2-sstabellini@kernel.org> From: Oleksandr Message-ID: Date: Thu, 5 May 2022 12:48:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220505001656.395419-2-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 05.05.22 03:16, Stefano Stabellini wrote: Hello Stefano > From: Stefano Stabellini > > Implement extended regions for dom0less domUs. The implementation is > based on the libxl implementation. > > Also update docs for the ext_regions command line option. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Luca Fancellu > CC: olekstysh@gmail.com Reviewed-by: Oleksandr Tyshchenko Thanks! > --- > Changes in v6: > - add reviewed-by > - address 2 NITs > - update docs > > Changes in v5: > - print the domain > - coding style > - simplify the code in find_domU_holes > - return error if no regions allocated in find_domU_holes > - use ROUNDUP > - uint64_t/paddr_t > --- > docs/misc/xen-command-line.pandoc | 9 ++--- > xen/arch/arm/domain_build.c | 60 ++++++++++++++++++++++++++----- > 2 files changed, 56 insertions(+), 13 deletions(-) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index 1dc7e1ca07..881fe409ac 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1110,11 +1110,12 @@ to use the default. > > > Default : `true` > > -Flag to enable or disable support for extended regions for Dom0. > +Flag to enable or disable support for extended regions for Dom0 and > +Dom0less DomUs. > > -Extended regions are ranges of unused address space exposed to Dom0 as > -"safe to use" for special memory mappings. Disable if your board device > -tree is incomplete. > +Extended regions are ranges of unused address space exposed to the guest > +as "safe to use" for special memory mappings. Disable if your board > +device tree is incomplete. > > ### flask > > `= permissive | enforcing | late | disabled` > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 1472ca4972..f22450b4b7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -35,7 +35,10 @@ > static unsigned int __initdata opt_dom0_max_vcpus; > integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); > > -/* If true, the extended regions support is enabled for dom0 */ > +/* > + * If true, the extended regions support is enabled for dom0 and > + * dom0less domUs. > + */ > static bool __initdata opt_ext_regions = true; > boolean_param("ext_regions", opt_ext_regions); > > @@ -1324,6 +1327,36 @@ out: > return res; > } > > +static int __init find_domU_holes(const struct kernel_info *kinfo, > + struct meminfo *ext_regions) > +{ > + unsigned int i; > + paddr_t bankend; > + const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; > + const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; > + int res = -ENOENT; > + > + for ( i = 0; i < GUEST_RAM_BANKS; i++ ) > + { > + struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]); > + > + ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, SZ_2M); > + > + bankend = ~0ULL >> (64 - p2m_ipa_bits); > + bankend = min(bankend, bankbase[i] + banksize[i] - 1); > + if ( bankend > ext_bank->start ) > + ext_bank->size = bankend - ext_bank->start + 1; > + > + /* 64MB is the minimum size of an extended region */ > + if ( ext_bank->size < MB(64) ) > + continue; > + ext_regions->nr_banks++; > + res = 0; > + } > + > + return res; > +} > + > static int __init make_hypervisor_node(struct domain *d, > const struct kernel_info *kinfo, > int addrcells, int sizecells) > @@ -1360,12 +1393,13 @@ static int __init make_hypervisor_node(struct domain *d, > > if ( !opt_ext_regions ) > { > - printk(XENLOG_INFO "The extended regions support is disabled\n"); > + printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d); > nr_ext_regions = 0; > } > else if ( is_32bit_domain(d) ) > { > - printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n"); > + printk(XENLOG_WARNING > + "%pd: extended regions not supported for 32-bit guests\n", d); > nr_ext_regions = 0; > } > else > @@ -1374,13 +1408,21 @@ static int __init make_hypervisor_node(struct domain *d, > if ( !ext_regions ) > return -ENOMEM; > > - if ( !is_iommu_enabled(d) ) > - res = find_unallocated_memory(kinfo, ext_regions); > + if ( is_domain_direct_mapped(d) ) > + { > + if ( !is_iommu_enabled(d) ) > + res = find_unallocated_memory(kinfo, ext_regions); > + else > + res = find_memory_holes(kinfo, ext_regions); > + } > else > - res = find_memory_holes(kinfo, ext_regions); > + { > + res = find_domU_holes(kinfo, ext_regions); > + } > > if ( res ) > - printk(XENLOG_WARNING "Failed to allocate extended regions\n"); > + printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n", > + d); > nr_ext_regions = ext_regions->nr_banks; > } > > @@ -1401,8 +1443,8 @@ static int __init make_hypervisor_node(struct domain *d, > u64 start = ext_regions->bank[i].start; > u64 size = ext_regions->bank[i].size; > > - printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", > - i, start, start + size); > + printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", > + d, i, start, start + size); > > dt_child_set_range(&cells, addrcells, sizecells, start, size); > } -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 05 09:57:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 09:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321913.543063 (Exim 4.92) (envelope-from ) id 1nmYEW-0005I4-Nu; Thu, 05 May 2022 09:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321913.543063; Thu, 05 May 2022 09:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYEW-0005Hx-L7; Thu, 05 May 2022 09:57:16 +0000 Received: by outflank-mailman (input) for mailman id 321913; Thu, 05 May 2022 09:57:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYEV-0005Hr-3t for xen-devel@lists.xenproject.org; Thu, 05 May 2022 09:57:15 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb9a021c-cc59-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 11:57:13 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 05:57:09 -0400 Received: from BLAPR03MB5603.namprd03.prod.outlook.com (2603:10b6:208:29b::16) by BY5PR03MB5332.namprd03.prod.outlook.com (2603:10b6:a03:22f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:57:07 +0000 Received: from BLAPR03MB5603.namprd03.prod.outlook.com ([fe80::24e0:fa20:e171:58e9]) by BLAPR03MB5603.namprd03.prod.outlook.com ([fe80::24e0:fa20:e171:58e9%3]) with mapi id 15.20.5206.027; Thu, 5 May 2022 09:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb9a021c-cc59-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651744633; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=PBS8lz3Gu3TX1bQd09a9mK6PT2QQHoMUsDd8nEJg9i0=; b=TDzixU6L5FuCImPiUkRmSrXCLhlMRcF2shict2t1JtyDIA/Zs7bTZAXj NGVtUbn1led4WrDCXtCmRo8mwZoVwCM1KJXA9ZQwWgeFYCt9m+pEvSUck y2QSHt6oAB72Af/OgxtnvEfvybuLvwPADRihGqN9DchjCM6I786eTFcht s=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 71043361 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6KBMG6DmywYUdRVW/1Piw5YqxClBgxIJ4kV8jS/XYbTApGgi3jdUy jYaXjjVa6zeYzOkLYx2advl8UoC6MXVnNFjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh39Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhS+ I59u7GcZDwVEajPhvkXXkQINyZXaPguFL/veRBTsOS15mifKz7G5aorC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l+B8mbE80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx3iWkKGMBwL6TjawmxE3R61Uv67HgAt3uJuGkf+tZhknN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1jYDX/JAHut87xuCopc4+C6cD2kACzRHN9ovsZZuQSRwj wfZ2dT0GTZorbuZD2qH8auZpi+zPi5TKnIeYSgDTk0O5NyLTJwPsy8jh+1LSMad5uAZ0xmpq 9xWhEDSX4kusPM= IronPort-HdrOrdr: A9a23:ms0Ubqsp/AFeX10itz52QeoM7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,200,1647316800"; d="scan'208";a="71043361" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j25w/nA/zLfdyZWryIHq4Rr2mgn6FJ2kgpxTb9DRoBKXmVkNYmcOvxGKq14EY1XfVTCaR9P8v63VRrHzvD+iyBs9FbQFhIoIpZIYOVUroJVGjUWfYtHzxd2IMxf9tmZSHfez/qnmz+Ef1pLbmNQw56kcseXWKDIIPgEYBxkNhxYIHuC29J6/qMn/6SGYia+tC2r1E6YKT56bzMJfQ5eoePCJRB5iuYkSsCBOiQ74a70vNC3PdKjdTNkGHQiDzFtbL/XlJi1OR2uQcGiJwv2OKgs6goxay4XxbWy48G+dUuS3zLsWEqEngHykDFCC587kWP5ubk1eEZvqAQLvbzODZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZ+/rbCdMStzxyo2GbkBsXJy+BVnDayK/Bc52NqgJzE=; b=Ynxp4yhd7KVzblh57wNKuYzgB+RKysh5yiPaR6yCjed7JOf1DH6WcoxTVoP37TyztTADp0KShUxioUS8ekE1Ivg70DYVpYaXlmIE1WDMfSqVn/ISZf1KAjvOqlPHLr9pfLDB+Owo/NL7g0pjP69Lhn1427z8A7uA9BttcRdzeUPQpk2Cb3hzEJnYjH5sKi9pdOoQ9J7sGSZQWUwyiGD5AEoziMMa7lZZLBOZR3TG4oV6XsZ8QsfrZQyt+J53WDulEob/ByWesb1VgwGio95Qr4Oy2aLapIsneAS0METAW60+j0jGxwz/Oudtx6kz6PM6YSbU2PcP3O4iS4Vyx1pmQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZ+/rbCdMStzxyo2GbkBsXJy+BVnDayK/Bc52NqgJzE=; b=p5SCRP3YxRGYoli1swONp8R0EHs46YIGs5yUWLZKlY/mncMNOG2JzAmLf5u2MjcAwjBPjKJ4Jh/bwuMU8fWJ+HM/S6yYoPS2Qo3uGzVSbgpt0Uq9YqDzUzxonD3bTIBkD9m93xAWO2Lrxn+blRtDJvJcyqqxvWRTyrBX8HZQScg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 11:57:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 07/21] IOMMU/x86: support freeing of pagetables Message-ID: References: <1389c785-ffe3-5d8c-36f1-a923ce5250cd@suse.com> <2d0d8aa9-1ab8-a505-e2df-c9b6446062cf@suse.com> <4bca3f52-436a-1285-9c36-9206dc5d50c9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4bca3f52-436a-1285-9c36-9206dc5d50c9@suse.com> X-ClientProxiedBy: PR0P264CA0068.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::32) To BLAPR03MB5603.namprd03.prod.outlook.com (2603:10b6:208:29b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5e989a3-f119-424b-c8bd-08da2e7d9cf9 X-MS-TrafficTypeDiagnostic: BY5PR03MB5332:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vs9THIIL5B4E3WFdfudcSCsWnHqrjl6LQ19PM/F36wT/ccHRoMw5CQ1Q1GM+WHPtl1fxyp81jfGc9a+DsEqhu9tzAHAqv9Tnws6dOT7D7OUaRN0k8S2Tdxm4DS1Hia36t93qDRD3+UUmO/M3mzXZ+NXzbb0zbI5e2R6p/cOas56IOdXz1HvsFTYVAlhlxT/V5IjsrhJtTmKclEYC1ShHZBKS0P+Nnf/rbPeqL//B1sYyoVBoMpZl/q/hy+ntjKPyV6vWs/JqICSvjsFL7zfuoUt7stRaLdnNF/VEcXboA8E9zqoquiwqcQL7kpTfSqnhkWwhLRxNdvkmZBNweX/oQaRN9DVDyiCm+oQyzytnScQzhMp1i7f43t4tou+RkrjexPKm0oU9AWBJUFBuFBMthsWcOpm5VKg6WwYkNOl4PrF0IPiCDFoXb9Ilari56ImlfdXs/GB/ponxh97etXpyUGEqxESvcnG5iKdLWzG1306Y9cd1/euIWs9DzydaOB930eoIYdrvT6jCK0Iz8fRF7bjPHasNeGGpdQy+HfNoxMU2BJdKWY5odcQQccMOD425/3Lwl9yYJAeOVpyY9JI7k+iCp2nRKkrcPhyaKdZGW1A++0yAEZ521LM8q09hZnRnN41Kk4LYoAQl5Q/Tt5Rl8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR03MB5603.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(33716001)(38100700002)(82960400001)(66946007)(8676002)(66556008)(66476007)(4326008)(86362001)(8936002)(186003)(2906002)(316002)(5660300002)(6486002)(53546011)(508600001)(6512007)(85182001)(9686003)(6916009)(26005)(54906003)(6506007)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmQ2RVpVNEs2VXZCbUxCQ2dmcXlFdllvZGVINmxWcmJacjRudm4wQjI2dVVp?= =?utf-8?B?cXIvRnBPY1dCVkxTOTJ4U3VGaTZGSGZNcjkyRzZ6SDJZUC9wS3lEbDNPSVlU?= =?utf-8?B?SWdsY2F1QTIwUXMxY2tST1JNQ3VkVDRYaU9pZ1Nqc1JQNDVHclJheVBQNWN3?= =?utf-8?B?N0RwRUJuWlkwQ0kxUDVFMFROSUpWcDBLc1AyVEtNNTZCYVJZLzNEMGhmMEpV?= =?utf-8?B?WWFtd2hZaVZOdCt3WjB3dWRjTGdKSXRwV3ltRUY0Y0lUYUllSFVtc2VMRjZ3?= =?utf-8?B?Y2doYk15dlpmR0tTSUxIeTFvMXVFenQxbmxodXh1QzVaQkQvNTVLa3RlbmVv?= =?utf-8?B?LzZaV21EdEliVzFsMWt5SU9TYkNxSGtqUkMyZEYrd1dRZEx6YVhhWEFxSGZC?= =?utf-8?B?cjhKZ2ZGQ2JNcnRaa0FBb20rWmR0TGtzT2N3Qy8raDlabGI3K0lITjBTaEk4?= =?utf-8?B?eUtCTndsK2luNVA0SjJpOEtNek1lTzFkbnpYaDJNS2p2QjErKzB2aG1lWHFu?= =?utf-8?B?OTdzR2hlWWF6K2YyVnZPYm5iRElxT20yNkpkM2Fpbzdhc1liK2MzTkEyYnlP?= =?utf-8?B?YmdDU3NXYUZId1dLbFVQOGJLNktuUWhmMjlUUklpcWtqZzQ1NDhnQ2Q1UmxX?= =?utf-8?B?OVdHMm9tTkVzNVkvdzgwM1g0dW9taDZVdW83WndOdFl4WCt5RkVFYTNxajFN?= =?utf-8?B?VzlFNms3UFhNblRyNUV1MWl3c29JVytkMmV4SWJGRE8xYW5vc1ZDc2cwU3FJ?= =?utf-8?B?dE1adS9lVSsxR2xBTll4TlBnSDRrZmhtNEl5bFRxakx4dVpPWFQxMm8rdWpU?= =?utf-8?B?bExwdU9OWTExN1ZWbVRYTHRsM21McFhRTkFSWHFrOHdzbFl0QmhROExOVzFS?= =?utf-8?B?ZkEvMXdmU1ZzaTZYUVB1SmN6Mmp4MytwUzVIaW14Ujl1aVh3bnhIL0ZWSlRZ?= =?utf-8?B?bC9McDdDakxTUWV0SUdqRi8wTXNZRVJWcnpaRHVWNDRLREQxQUlNRUVGcjVP?= =?utf-8?B?M2hDb01oeHpHdkEwWVlBVUxYWEJiRytRa1psY2tNdTZRWXNZaFRoWFNjYmRC?= =?utf-8?B?dFJGV1FZaXBERjVDK3hCdGlubDUvdUp0RjZxOFVOWWRRcTkvNlkzdUhQY3lO?= =?utf-8?B?RjFCK0puR2cxekNIRmJNMDBaejVWcE8zZzRiSyt2emhmWWs0L3puNWxYSWs3?= =?utf-8?B?QVQ2QkxYeEk2aWkxQ2lmVVVGcGx3aG9yUGZKZVVCM0pjVGtoYklDTXYxNDBr?= =?utf-8?B?bEpaTG0yK2hreE1raldYUEVybkZpTnhhOVpadXZUSUM5djNNU0RBR3VkQUxD?= =?utf-8?B?c3dRV2RleWF3d1o4RkVCTlM1LzROUmpEeW5tU0t3UEtjUkFsanY0cHpDL2Zv?= =?utf-8?B?bTdUcEc0WDFwYnh4TTNjcWZuTTZjM3ZkM1habDlCY0lGV2xDNWVOTEtpdTI2?= =?utf-8?B?SDc3eUpKbWFZYm8zUnJnNkJYY1BCSU5wY29VU2g2MUcwdGFBZm1xOWpqekZZ?= =?utf-8?B?azBvNU1iNFZCNE8wUFc3T0Y5S1RlZzhWcUNTbTNPSGdQNzBzczZRMzJFTm5C?= =?utf-8?B?Mk12SmxLWTcvK2dvRGR0Wm8zTmVTYjVsOGtVczEycGplMjBVL1FLQThuRThW?= =?utf-8?B?cU9GTXREMlV2aVhzdklMVTI5azA5R1J2WjlLSWo5OHNzUVlxMkVERDN2L1Fs?= =?utf-8?B?NStENFM1NDMzcHRQUW43MFQvbHEzRFRvRFJUM2dpUnhtd0E2Q0c3MnB5Sm5h?= =?utf-8?B?Y21oYTI4RFdDSWVPZk9xMzNRdVYxQnRvYzlWcm5tN0p2YkYxR0FpUGF1ZmRW?= =?utf-8?B?SExXR2VsY0M0V2xEd2VKeVE2NXlPcVlkeXFKUTZFWnVNQllpMmZ5TlEvbUs4?= =?utf-8?B?MmRzZjA1RGJCNU9CcGFIZGdlTlJpQjBvQzdKUU5XQnlDNlhzUG4zNlcrZVh0?= =?utf-8?B?ekNHWEQraVdtbEtObThJWlQvK0prT0cyYVQzR2toV0FvbmZjRDFoVnpDazZQ?= =?utf-8?B?cFNudktqUmE4VXBsSmpDWnZ0aUMzVUNUYmlaSGxtWUFYb0hFVWZxUVFCanh5?= =?utf-8?B?cTJKaFBvMGx5VUZCWGEwMUYwTzBZNmF2V1BSNU9UVDdjWFZrMFYzWHpZa1BT?= =?utf-8?B?UE4xdENuWXZmM2NGRUVpZUhybmY5MVNJN2FtWmRwSkFjWFFMaG5iM203TjFI?= =?utf-8?B?MHRpbXdBQXpRVUJkQ05nUkdNNTF5RTFWS1R3b1lTYksvRmdOcHZGR2MvQkU0?= =?utf-8?B?dElYV3NnRUphYUU5dDZtcVZzT0Z1dWFrNUcvZXIzZ3NjQzlZRTVmczdMTjZY?= =?utf-8?B?NFNZKzY1dVVCSVE2dDIxUGhrWnFmQktTN2UvY3prVGMxdlo2SFd0YWVRUkI4?= =?utf-8?Q?8zwjDZ8NM33dLJUo=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e989a3-f119-424b-c8bd-08da2e7d9cf9 X-MS-Exchange-CrossTenant-AuthSource: BLAPR03MB5603.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 09:57:07.2469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XQzk2v8d5eoB8zkUT+Y8fHX7W8tloRALFUcUkS4lAcx/VA05D2n8Y0RhB9QLolENnWS3AveGIRDwUqofzAb4yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5332 On Thu, May 05, 2022 at 10:20:36AM +0200, Jan Beulich wrote: > On 04.05.2022 17:06, Roger Pau Monné wrote: > > On Wed, May 04, 2022 at 03:07:24PM +0200, Jan Beulich wrote: > >> On 03.05.2022 18:20, Roger Pau Monné wrote: > >>> On Mon, Apr 25, 2022 at 10:35:45AM +0200, Jan Beulich wrote: > >>>> For vendor specific code to support superpages we need to be able to > >>>> deal with a superpage mapping replacing an intermediate page table (or > >>>> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > >>>> needed to free individual page tables while a domain is still alive. > >>>> Since the freeing needs to be deferred until after a suitable IOTLB > >>>> flush was performed, released page tables get queued for processing by a > >>>> tasklet. > >>>> > >>>> Signed-off-by: Jan Beulich > >>>> --- > >>>> I was considering whether to use a softirq-tasklet instead. This would > >>>> have the benefit of avoiding extra scheduling operations, but come with > >>>> the risk of the freeing happening prematurely because of a > >>>> process_pending_softirqs() somewhere. > >>> > >>> I'm sorry again if I already raised this, I don't seem to find a > >>> reference. > >> > >> Earlier on you only suggested "to perform the freeing after the flush". > >> > >>> What about doing the freeing before resuming the guest execution in > >>> guest vCPU context? > >>> > >>> We already have a hook like this on HVM in hvm_do_resume() calling > >>> vpci_process_pending(). I wonder whether we could have a similar hook > >>> for PV and keep the pages to be freed in the vCPU instead of the pCPU. > >>> This would have the benefit of being able to context switch the vCPU > >>> in case the operation takes too long. > >> > >> I think this might work in general, but would be troublesome when > >> preparing Dom0 (where we don't run on any of Dom0's vCPU-s, and we > >> won't ever "exit to guest context" on an idle vCPU). I'm also not > >> really fancying to use something like > >> > >> v = current->domain == d ? current : d->vcpu[0]; > > > > I guess a problematic case would also be hypercalls executed in a > > domain context triggering the freeing of a different domain iommu page > > table pages. As then the freeing would be accounted to the current > > domain instead of the owner of the pages. > > Aiui such can happen only during domain construction. Any such > operation behind the back of a running guest is imo problematic. > > > dom0 doesn't seem that problematic, any freeing triggered on a system > > domain context could be performed in place (with > > process_pending_softirqs() calls to ensure no watchdog triggering). > > > >> (leaving aside that we don't really have d available in > >> iommu_queue_free_pgtable() and I'd be hesitant to convert it back). > >> Otoh it might be okay to free page tables right away for domains > >> which haven't run at all so far. > > > > Could be, but then we would have to make hypercalls that can trigger > > those paths preemptible I would think. > > Yes, if they aren't already and if they allow for freeing of > sufficiently large numbers of pages. That's kind of another argument > against doing so right here, isn't it? Indeed, as it's likely to make the implementation more complex IMO. So let's use this pCPU implementation. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 10:12:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:12:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321921.543073 (Exim 4.92) (envelope-from ) id 1nmYT9-0007du-1R; Thu, 05 May 2022 10:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321921.543073; Thu, 05 May 2022 10:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYT8-0007dn-V8; Thu, 05 May 2022 10:12:22 +0000 Received: by outflank-mailman (input) for mailman id 321921; Thu, 05 May 2022 10:12:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYT7-0007dh-LV for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:12:21 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d95108dd-cc5b-11ec-a406-831a346695d4; Thu, 05 May 2022 12:12:20 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id d5so5423980wrb.6 for ; Thu, 05 May 2022 03:12:20 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id bj20-20020a0560001e1400b0020c5253d8edsm908950wrb.57.2022.05.05.03.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 03:12:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d95108dd-cc5b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eb2ZcFrJLchDQJ3uoZwQrPbJ1hCXeW171xzslTdT/U4=; b=G89l6j5DRWAvV3zCYyVoZKkWWBGnZmD3gVlBJDJs1rBbWZGMduvsJXgjawnSyEvdry wK8X2CVN4x+NPbTCSj/Hhf99L/9GOZ1OJbxwihCOn/RX0Kl5nqvbEsQh3FNzrbb1gixQ UCiBZhzKSWWfPKfAk9noqtj32u52IDzcaLqLzCgHlvFdrC+eqqa6vTfXWDUFbgRqFBqB 6sLFoZLkvMkYbyxOtL/JwMxWfZNOPan9v832XXd/QrVzjHj+WBf2G+buT/KWnTlMphbF UxWVKrDxlAdR/Thq9GPIpuJJU5fg+AoBHmdU1+Fi9uoVPjtOmPBSchUkefm3TRpzF2/C pz6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=eb2ZcFrJLchDQJ3uoZwQrPbJ1hCXeW171xzslTdT/U4=; b=qHsPk9brhYhGkU8PDovKmjhByh+q2p1Ck5cbMu/w0CmoOVVQfBHquWXp1+nKWzGrqR LAuaHfFFC6fYeyJ2lU7CAvqGzzX6zpZcqgCQK2O2zJLCBcuUZ1ar+APAo4c+tiOkck8T nCwZzHqlK0h+/p8Fn+QDgLh9WEYLj2QksMd5ih9mu+q3kd+0JbK8/631t3XSgkjnSjFN sZ2/0cvXFYRoTR49AsKwQxVVu8MoisCbyNxYd0JKIWS43LuKZCgYg8MSY+a02neTQwzn eFYfSDx8KE+bQCwqw1vXCqfrh2S2K4q5aideQJ6NQQMWOgk0wfFrCF/O5JiQKpY5FrEe 7TQg== X-Gm-Message-State: AOAM531pmFIsDRQKrTi0i3uyPMKrvSKXhyg6UQyi5kGxh4UXhiFXWPQT G/22T6qorcZy+PsJPsk5TBk= X-Google-Smtp-Source: ABdhPJw7Wbi8fb/wzTczoS25ioRejgwcD7Tq0/bwbcNAYzBrRJZFfWNBH1Dc95FX1erDQ/IFeDBlUg== X-Received: by 2002:a05:6000:144d:b0:20c:7829:2a44 with SMTP id v13-20020a056000144d00b0020c78292a44mr8970101wrx.663.1651745539758; Thu, 05 May 2022 03:12:19 -0700 (PDT) Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Rob Herring Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <87009e86-8999-eac9-a5c9-feef196f69fc@gmail.com> Date: Thu, 5 May 2022 13:12:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 04.05.22 03:02, Rob Herring wrote: Hello Rob > On Tue, May 03, 2022 at 08:09:32PM +0300, Oleksandr wrote: >> On 03.05.22 00:59, Rob Herring wrote: >> >> Hello Rob >> >> >>> On Fri, Apr 22, 2022 at 07:51:01PM +0300, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> Introduce Xen specific binding for the virtualized device (e.g. virtio) >>>> to be used by Xen grant DMA-mapping layer in the subsequent commit. >>>> >>>> This binding indicates that Xen grant mappings scheme needs to be >>>> enabled for the device which DT node contains that property and specifies >>>> the ID of Xen domain where the corresponding backend resides. The ID >>>> (domid) is used as an argument to the grant mapping APIs. >>>> >>>> This is needed for the option to restrict memory access using Xen grant >>>> mappings to work which primary goal is to enable using virtio devices >>>> in Xen guests. >>>> >>>> Signed-off-by: Oleksandr Tyshchenko >>>> --- >>>> Changes RFC -> V1: >>>> - update commit subject/description and text in description >>>> - move to devicetree/bindings/arm/ >>>> --- >>>> .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >>>> new file mode 100644 >>>> index 00000000..ef0f747 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Xen specific binding for the virtualized device (e.g. virtio) >>>> + >>>> +maintainers: >>>> + - Oleksandr Tyshchenko >>>> + >>>> +select: true >>> Do we really need to support this property everywhere? >> From my understanding - yes. >> >> As, I think, any device node describing virtulized device in the guest >> device tree can have this property.  Initially (in the RFC series) the >> "solution to restrict memory access using Xen grant mappings" was >> virtio-specific. >> >> Although the support of virtio is a primary target of this series, we >> decided to generalize this work and expand it to any device [1]. So the Xen >> grant mappings scheme (this property to be used for) can be theoretically >> used for any device emulated by the Xen backend. >> >> >>>> + >>>> +description: >>>> + This binding indicates that Xen grant mappings scheme needs to be enabled >>>> + for that device and specifies the ID of Xen domain where the corresponding >>>> + device (backend) resides. This is needed for the option to restrict memory >>>> + access using Xen grant mappings to work. >>>> + >>>> +properties: >>>> + xen,dev-domid: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: >>>> + The domid (domain ID) of the domain where the device (backend) is running. >>>> + >>>> +additionalProperties: true >>>> + >>>> +examples: >>>> + - | >>>> + virtio_block@3000 { >>> virtio@3000 >> ok, will change >> >> >>>> + compatible = "virtio,mmio"; >>>> + reg = <0x3000 0x100>; >>>> + interrupts = <41>; >>>> + >>>> + /* The device is located in Xen domain with ID 1 */ >>>> + xen,dev-domid = <1>; >>> This fails validation: >>> >>> Documentation/devicetree/bindings/arm/xen,dev-domid.example.dtb: virtio_block@3000: xen,dev-domid: [[1]] is not of type 'object' >>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/virtio/mmio.yaml >> Thank you for pointing this out, my fault, I haven't "properly" checked this >> before. I think, we need to remove "compatible = "virtio,mmio"; here > Uhh, no. That just means the example is incomplete. You need to add this > property or reference this schema from virtio/mmio.yaml. ok, I got it > > >> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> index 2daa8aa..d2f2140 100644 >> --- a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> @@ -28,7 +28,7 @@ additionalProperties: true >>  examples: >>    - | >>      virtio_block@3000 { >> -            compatible = "virtio,mmio"; >> +            /* ... */ >>              reg = <0x3000 0x100>; >>              interrupts = <41>; >> >> >> >>> The property has to be added to the virtio/mmio.yaml schema. If it is >>> not needed elsewhere, then *just* add the property there. >> As I described above, the property is not virtio specific and can be used >> for any virtualized device for which Xen grant mappings scheme needs to be >> enabled (xen-grant DMA-mapping layer). > But that's a finite list of devices, right? Right > In any case, you have to > list the property anywhere it can be used. Agree If I got it right, we need to add to virtio/mmio.yaml something like: diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml index 10c22b5..29a0932 100644 --- a/Documentation/devicetree/bindings/virtio/mmio.yaml +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml @@ -13,6 +13,9 @@ description:    See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for    more details. +allOf: +  - $ref: /schemas/arm/xen,dev-domid.yaml# +  properties:    compatible:      const: virtio,mmio @@ -33,6 +36,10 @@ properties:      description: Required for devices making accesses thru an IOMMU.      maxItems: 1 +  xen,dev-domid: +    description: Required when Xen grant mappings need to be enabled for device. +    $ref: /schemas/types.yaml#/definitions/uint32 +  required:    - compatible    - reg This passed validation. Could you please clarify, is my understanding correct? > > Rob -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 05 10:16:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:16:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321929.543085 (Exim 4.92) (envelope-from ) id 1nmYXJ-0008LT-Oe; Thu, 05 May 2022 10:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321929.543085; Thu, 05 May 2022 10:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYXJ-0008LM-L6; Thu, 05 May 2022 10:16:41 +0000 Received: by outflank-mailman (input) for mailman id 321929; Thu, 05 May 2022 10:16:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYXJ-0008LC-23; Thu, 05 May 2022 10:16:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYXI-0002ko-S7; Thu, 05 May 2022 10:16:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYXI-0002Cr-Hx; Thu, 05 May 2022 10:16:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmYXI-0003FR-HT; Thu, 05 May 2022 10:16:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YUiULSuuHHAIDWBUW1nIbeo09E7cKFGoCQ/pNzLXmuQ=; b=o45kkYCJVYpuM56l6NiHR6lc7C xr7oA1o+VhSmpNcORDDvI7GXwllAQfQKUg+flFYtMOf6DoPj6Zi5Dx9m9zNnritIVmczjr/HY12yy 54MvDXArMtwIaqaWgejIQiOHEMuHBqMcw9IBZO+MBqU5vbXbZlJWlEF5YeQnH332z5FY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170144: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 10:16:40 +0000 flight 170144 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170144/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 65 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 817 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 10:36:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321938.543096 (Exim 4.92) (envelope-from ) id 1nmYqG-0002XW-CA; Thu, 05 May 2022 10:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321938.543096; Thu, 05 May 2022 10:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqG-0002XP-99; Thu, 05 May 2022 10:36:16 +0000 Received: by outflank-mailman (input) for mailman id 321938; Thu, 05 May 2022 10:36:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqF-0002XD-A8 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:36:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 2f346267-cc5f-11ec-a406-831a346695d4; Thu, 05 May 2022 12:36:13 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66FC5106F; Thu, 5 May 2022 03:36:12 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E37D63FA27; Thu, 5 May 2022 03:36:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f346267-cc5f-11ec-a406-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/2] xen/arm: gnttab: macros modifications Date: Thu, 5 May 2022 12:35:59 +0200 Message-Id: <20220505103601.322110-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series modifies macros inside xen/arch/arm/include/asm/grant_table.h to be resistant to static analyzer/compiler warnings about unused-but-set variables. The first patch acts as a fix for a gcc warning when -Wunused-but-set-variable flag is enabled by converting the macro to static inline helper. The adjacent macro is modified as well. These macros can be converted to inline helpers as they do not take argument of type struct grant_table which is not fully defined yet. The second patch modifies the remaining macros to evaluate all their arguments and only once. Previous discussion: https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg119708.html Michal Orzel (2): xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* xen/arm: gnttab: modify macros to evaluate all arguments and only once xen/arch/arm/include/asm/grant_table.h | 80 +++++++++++++++++++------- 1 file changed, 59 insertions(+), 21 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 10:36:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321940.543118 (Exim 4.92) (envelope-from ) id 1nmYqI-00032Z-TW; Thu, 05 May 2022 10:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321940.543118; Thu, 05 May 2022 10:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqI-00032S-Pi; Thu, 05 May 2022 10:36:18 +0000 Received: by outflank-mailman (input) for mailman id 321940; Thu, 05 May 2022 10:36:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqH-0002XD-TD for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:36:18 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 317a602c-cc5f-11ec-a406-831a346695d4; Thu, 05 May 2022 12:36:16 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3214D1516; Thu, 5 May 2022 03:36:16 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF5A93FA27; Thu, 5 May 2022 03:36:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 317a602c-cc5f-11ec-a406-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Date: Thu, 5 May 2022 12:36:01 +0200 Message-Id: <20220505103601.322110-3-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505103601.322110-1-michal.orzel@arm.com> References: <20220505103601.322110-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify macros to evaluate all the arguments and make sure the arguments are evaluated only once. While doing so, use typeof for basic types and use const qualifier when applicable. Signed-off-by: Michal Orzel --- xen/arch/arm/include/asm/grant_table.h | 67 ++++++++++++++++++-------- 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index 779f6fbdbb..b161d4baf1 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -57,38 +57,44 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, #define gnttab_init_arch(gt) \ ({ \ - unsigned int ngf_ = (gt)->max_grant_frames; \ + struct grant_table *gt_ = (gt); \ + unsigned int ngf_ = gt_->max_grant_frames; \ unsigned int nsf_ = grant_to_status_frames(ngf_); \ \ - (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ - (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ - if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ + gt_->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ + gt_->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ + if ( gt_->arch.shared_gfn && gt_->arch.status_gfn ) \ { \ while ( ngf_-- ) \ - (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ + gt_->arch.shared_gfn[ngf_] = INVALID_GFN; \ while ( nsf_-- ) \ - (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ + gt_->arch.status_gfn[nsf_] = INVALID_GFN; \ } \ else \ - gnttab_destroy_arch(gt); \ - (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ + gnttab_destroy_arch(gt_); \ + gt_->arch.shared_gfn ? 0 : -ENOMEM; \ }) #define gnttab_destroy_arch(gt) \ do { \ - XFREE((gt)->arch.shared_gfn); \ - XFREE((gt)->arch.status_gfn); \ + struct grant_table *gt_ = (gt); \ + XFREE(gt_->arch.shared_gfn); \ + XFREE(gt_->arch.status_gfn); \ } while ( 0 ) #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ ({ \ int rc_ = 0; \ - gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx); \ - if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) || \ - (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn, \ + const struct grant_table *gt_ = (gt); \ + const typeof(st) st_ = (st); \ + const typeof(idx) idx_ = (idx); \ + const gfn_t gfn_ = (gfn); \ + const gfn_t ogfn_ = gnttab_get_frame_gfn(gt_, st_, idx_); \ + if ( gfn_eq(ogfn_, INVALID_GFN) || gfn_eq(ogfn_, gfn_) || \ + (rc_ = guest_physmap_remove_page(gt_->domain, ogfn_, mfn, \ 0)) == 0 ) \ - ((st) ? (gt)->arch.status_gfn \ - : (gt)->arch.shared_gfn)[idx] = (gfn); \ + (st_ ? gt_->arch.status_gfn \ + : gt_->arch.shared_gfn)[idx_] = gfn_; \ rc_; \ }) @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, }) #define gnttab_shared_gfn(d, t, i) \ - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + ({ \ + const struct domain *d_ = (d); \ + const struct grant_table *t_ = (t); \ + const typeof(i) i_ = (i); \ + \ + if ( d_ != NULL ) \ + ASSERT(d_->grant_table == t_); \ + \ + (i_ >= nr_grant_frames(t_)) ? INVALID_GFN \ + : t_->arch.shared_gfn[i_]; \ + }) #define gnttab_status_gfn(d, t, i) \ - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + ({ \ + const struct domain *d_ = (d); \ + const struct grant_table *t_ = (t); \ + const typeof(i) i_ = (i); \ + \ + if ( d_ != NULL ) \ + ASSERT(d_->grant_table == t_); \ + \ + (i_ >= nr_status_frames(t_)) ? INVALID_GFN \ + : t_->arch.status_gfn[i_]; \ + }) -#define gnttab_need_iommu_mapping(d) \ - (is_domain_direct_mapped(d) && is_iommu_enabled(d)) +#define gnttab_need_iommu_mapping(d) \ + ({ \ + const struct domain *d_ = (d); \ + is_domain_direct_mapped(d_) && is_iommu_enabled(d_); \ + }) #endif /* __ASM_GRANT_TABLE_H__ */ /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 10:36:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:36:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321939.543107 (Exim 4.92) (envelope-from ) id 1nmYqH-0002mw-JH; Thu, 05 May 2022 10:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321939.543107; Thu, 05 May 2022 10:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqH-0002mp-GI; Thu, 05 May 2022 10:36:17 +0000 Received: by outflank-mailman (input) for mailman id 321939; Thu, 05 May 2022 10:36:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmYqF-0002XJ-VW for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:36:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 305beeb0-cc5f-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 12:36:15 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582B014BF; Thu, 5 May 2022 03:36:14 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE25A3FA27; Thu, 5 May 2022 03:36:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 305beeb0-cc5f-11ec-8fc4-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Date: Thu, 5 May 2022 12:36:00 +0200 Message-Id: <20220505103601.322110-2-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220505103601.322110-1-michal.orzel@arm.com> References: <20220505103601.322110-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable is enabled). Fix it by converting this macro to a static inline helper and using the boolean return type. While there, also convert macro gnttab_release_host_mappings. Signed-off-by: Michal Orzel --- xen/arch/arm/include/asm/grant_table.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index d31a4d6805..779f6fbdbb 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) #endif } +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, + struct domain *rd) +{ + return false; +} + +static inline bool gnttab_release_host_mappings(struct domain *d) +{ + return true; +} + int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned int flags, unsigned int cache_flags); -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned long new_gpaddr, unsigned int flags); -#define gnttab_release_host_mappings(domain) 1 /* * The region used by Xen on the memory will never be mapped in DOM0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 10:47:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321971.543129 (Exim 4.92) (envelope-from ) id 1nmZ1M-0005Dz-0W; Thu, 05 May 2022 10:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321971.543129; Thu, 05 May 2022 10:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ1L-0005Ds-TK; Thu, 05 May 2022 10:47:43 +0000 Received: by outflank-mailman (input) for mailman id 321971; Thu, 05 May 2022 10:47:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ1K-0005Di-EN for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:47:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ1J-0003gC-6k; Thu, 05 May 2022 10:47:41 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmZ1I-0000ht-W7; Thu, 05 May 2022 10:47:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=X8ImuXUO53Htv8l3X5EVFCQdHO2x9Eep1S4ThuF+gu0=; b=BYIkbOY8jsAaoR4B6mNVzG5qQc e1UIqnLFmbugjnakQ914CowfRie6liZNakGAVWHjj4eGlxshb45424XBgxZ6aqjBruT0SIjRBrg01 peZzOs0gHcgs7yaJ5ds73qxAwgld5prNh+AO2zeHNUU9uHcmeerAeN3+RP7FkWLXVr6E=; Message-ID: <29821df5-ff10-381f-f4ab-6d25ae1815bb@xen.org> Date: Thu, 5 May 2022 11:47:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] SUPPORT.MD: Correct the amount of physical memory supported for Arm To: Bertrand Marquis Cc: Xen-devel , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220427132246.52715-1-julien@xen.org> <2AFEFEE2-DDF7-42EB-A1AD-88642596152C@arm.com> From: Julien Grall In-Reply-To: <2AFEFEE2-DDF7-42EB-A1AD-88642596152C@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/04/2022 14:51, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 27 Apr 2022, at 14:22, Julien Grall wrote: >> >> From: Julien Grall >> >> As part of XSA-385, SUPPORT.MD gained a statement regarding the amount >> of physical memory supported. >> >> However, booting Xen on a Arm platform with that amount of memory would >> result to a breakage because the frametable area is too small. >> >> The wiki [1] (as of April 2022) claims we were able to support up to >> 5 TiB on Arm64 and 16 GiB. However, this is not the case because >> the struct page_info has always been bigger than expected (56 bytes >> for 64-bit and 32-bytes for 32-bit). >> >> I don't have any HW with such amount of memory. So rather than >> modifying the code, take the opportunity to use the limit that should >> work on Arm (2 TiB for 64-bit and 12 GiB for 32-bit). > > Sadly I have no hardware either even remotely near this capacity and > I think those limits are right for now so... > >> >> Signed-off-by: Julien Grall > Reviewed-by: Bertrand Marquis #arm part Thanks! The changes requested by Jan are easy to fix. So instead of resubmitting, I have done the modifications and committed the patch directly. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 10:51:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:51:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321978.543140 (Exim 4.92) (envelope-from ) id 1nmZ4s-0006cU-FI; Thu, 05 May 2022 10:51:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321978.543140; Thu, 05 May 2022 10:51:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ4s-0006cN-C5; Thu, 05 May 2022 10:51:22 +0000 Received: by outflank-mailman (input) for mailman id 321978; Thu, 05 May 2022 10:51:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ4q-0006cG-KY for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:51:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZ4p-0003rF-Jz; Thu, 05 May 2022 10:51:19 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmZ4p-0000xR-Du; Thu, 05 May 2022 10:51:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9w/c8Nvl31x+9xKc098sP9ad/LGa5RXA+jKL7wWmspQ=; b=OJA78OD5hp002ho72HJR74DcPu DNDFiLzAScCtIbg4dJjS3MS4HT+Qr2W4gCDVSssahx0yFBUTmzgFnK/xnVG9DJFxAee5Kozv5J2cC +Ny6piMVXWUx0uKDxg4RTq2Eh83qNxG9A/2AqqFw5QdkEKbwiZ05vMETEr8L7fN1VluU=; Message-ID: <6035b26c-e011-b905-6295-fc55f0070f29@xen.org> Date: Thu, 5 May 2022 11:51:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] xen/arm: Advertise workaround 1 if we apply 3 To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <8119538cce93516f1e78d37d578996a195686f89.1651570561.git.bertrand.marquis@arm.com> <3700FF65-C9BD-44D6-87EA-7C2B4B2A8557@arm.com> From: Julien Grall In-Reply-To: <3700FF65-C9BD-44D6-87EA-7C2B4B2A8557@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/05/2022 08:25, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 3 May 2022, at 19:17, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 03/05/2022 10:38, Bertrand Marquis wrote: >>> SMCC_WORKAROUND_3 is handling both Spectre v2 and spectre BHB. >>> So when a guest is asking if we support workaround 1, tell yes if we >>> apply workaround 3 on exception entry as it handles it. >>> This will allow guests not supporting Spectre BHB but impacted by >>> spectre v2 to still handle it correctly. >>> The modified behaviour is coherent with what the Linux kernel does in >>> KVM for guests. >>> While there use ARM_SMCCC_SUCCESS instead of 0 for the return code value >>> for workaround detection to be coherent with Workaround 2 handling. >>> Signed-off-by: Bertrand Marquis >> >> Acked-by: Julien Grall > > Thanks > >> >> I think we should also consider for backport. > > Agree. I have committed this patch and added to my list of backport candidate. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 10:59:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321987.543154 (Exim 4.92) (envelope-from ) id 1nmZCp-0007P3-Da; Thu, 05 May 2022 10:59:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321987.543154; Thu, 05 May 2022 10:59:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCp-0007Ow-Ah; Thu, 05 May 2022 10:59:35 +0000 Received: by outflank-mailman (input) for mailman id 321987; Thu, 05 May 2022 10:59:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCo-0007Oq-0W for xen-devel@lists.xenproject.org; Thu, 05 May 2022 10:59:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCn-00042S-6b; Thu, 05 May 2022 10:59:33 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmZCm-0001bR-W3; Thu, 05 May 2022 10:59:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3N4YsIiibXlZqaFYkKkk8amaqy18kkvoO+KOegbi83M=; b=f/Gyyn8eZj4onyPNx5ump8fn9l 0cu2ZYQBXyfbNRqyOG5NOamoIDR/YT6LWqzbuHgSkfv9NklIutvYRzWQtFfSjwIjXBwu2V4pXU++W 6yPX8mWOxviGoDhimsTZ9OezfYumOyjoOEe4oT4eVDa01ObCu8yMJtKUKXq+3YdleogI=; Message-ID: <18cd9a4a-f7ce-7078-b638-fdce3531481f@xen.org> Date: Thu, 5 May 2022 11:59:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] tools/xenstore: don't let special watches be children of / To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Raphael Ning References: <20220502100722.17250-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20220502100722.17250-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 02/05/2022 11:07, Juergen Gross wrote: > When firing special watches (e.g. "@releaseDomain"), they will be > regarded to be valid children of the "/" node. So a domain having > registered a watch for "/" and having the privilege to receive > the special watches will receive those special watch events for the > registered "/" watch. > > Fix that by calling the related fire_watches() with the "exact" > parameter set to true, causing a mismatch for the "/" node. > > Reported-by: Raphael Ning > Signed-off-by: Juergen Gross > Reviewed-by: Raphael Ning Reviewed-by: Julien Grall And commited it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 10:59:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 10:59:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.321988.543166 (Exim 4.92) (envelope-from ) id 1nmZCy-0007ht-Le; Thu, 05 May 2022 10:59:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 321988.543166; Thu, 05 May 2022 10:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCy-0007hm-IV; Thu, 05 May 2022 10:59:44 +0000 Received: by outflank-mailman (input) for mailman id 321988; Thu, 05 May 2022 10:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCx-0007h7-Ax; Thu, 05 May 2022 10:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCx-00042f-AD; Thu, 05 May 2022 10:59:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZCw-00037t-SU; Thu, 05 May 2022 10:59:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmZCw-0005xv-S4; Thu, 05 May 2022 10:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BGYUoz9l9+Jz60nP0ZoKA44JCjiw6ynGZWBXkUsKVj0=; b=DnsRS+8yBOKijbQ7sSBKIY7M8T 7Q52oI0I7ujhn14KyVTq4tl3jel98H3PGIkzCGv0j8TKQ+FXSkf39Bgd3FJVVy8Oiyg4YpgDlPV59 STlzmOA5FQBDaH/5m6j2JnlUM0UIy36zGjOL6hnr3Ns5y2GKNxZ49uR+F8NJbGmV/gj8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170145: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 10:59:42 +0000 flight 170145 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170145/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 818 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 11:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322005.543185 (Exim 4.92) (envelope-from ) id 1nmZQK-0001x1-Vn; Thu, 05 May 2022 11:13:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322005.543185; Thu, 05 May 2022 11:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZQK-0001wu-SL; Thu, 05 May 2022 11:13:32 +0000 Received: by outflank-mailman (input) for mailman id 322005; Thu, 05 May 2022 11:13:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZQK-0001wo-8c for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:13:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 655789fe-cc64-11ec-a406-831a346695d4; Thu, 05 May 2022 13:13:31 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-12-uuY1WKC8MO-3xiPJ3ya-dg-1; Thu, 05 May 2022 13:13:25 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB5362.eurprd04.prod.outlook.com (2603:10a6:208:119::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 11:13:23 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 11:13:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 655789fe-cc64-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651749211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IknTPg+MA5SHn/OdlLcI4UhfMTjucHnRbWuw51/GaZE=; b=Czo+qLul/g+b3541gr5w518TR3HDS9cT8f9f79TKeGygrN5WcUQzJpIzg07UIAlpWRptCE J1hB4jn79UpzCKLrUUsF9XHn97tDgyt2QMv6Yi5hZWoWqJazwaUqK7HHj32F2K7rt3qiiK uN2Fa+eJtvJDxlnATRw6xbAimazR4BI= X-MC-Unique: uuY1WKC8MO-3xiPJ3ya-dg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CD6gHCx1maNZt7g2nLdrvQd04jakAiV9YH2v70mSyCXsLwj2DvsgGXtzUZKdbzuNXPTaSJiiaBbbBYFThE58HTZ0QOdodS/kRsSxL7UwfTJVqyf8O2PYD//xawjMn1vi94ry0iStK+kSSVhWKv1RUfWX2bGMl1f4Xx4LnsFX59QMbHr1Nd9l+jb8UwZJ1DxZNJEBFGAi9gXkr37lCHnUN+zgGdv6r3fHyyZ8LFfvg2n0w1eAtvRx5JT5jMwP8gdgp6vGFDnZ/znr/pixqiBl75St/GhPXN2oKisWtWaDKXN/iJ2hOg8pDDFj59hTz9ofMdiKEd21NLb2QPFl6oPHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IknTPg+MA5SHn/OdlLcI4UhfMTjucHnRbWuw51/GaZE=; b=GL3Ek34g2xbuhnAeqISoqzinmdtoj71xs0D7V5UIQd0Y9Yz2lzwZ9IwyvtMqy09AfEGyCqC8gvfGEpmp2gTc3nUlYbaYplkpnjqKlgK45r9C3XCigUX5px4GwZ3RwZJc3FCGe8TatrjtjfNo0bBSb6vV6QB+YPa/IxwjWVmPpQTygbJ0FG4R4AMVLblYCkWBrqtTO+rRwokElB/zudjOZLFSJrufZYLMYi0wwX0Wp8Wlvcwy7Zw/ds1Nt3guh1BGT36DnIC7fPmMwM8lyOGDw7mGIO8qCiUwUw6PPrug+vUbWq8oIl/vphlFKiigp3p/wYzSu+7Td0M7WVXlwE0gkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> Date: Thu, 5 May 2022 13:13:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-2-michal.orzel@arm.com> From: Jan Beulich In-Reply-To: <20220505103601.322110-2-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0298.eurprd06.prod.outlook.com (2603:10a6:20b:45a::6) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad1ae64b-9da0-4a72-f30c-08da2e884499 X-MS-TrafficTypeDiagnostic: AM0PR04MB5362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QU7yB7vSvRz+M7ZU3VPwlqd080hyVFlT72g5YhKYQ2AtDyRB2SnDLWQvPe4JuJU7TD0xgkRhej3zo1h3DbsUCLXEzZ++Hz4Pr9thsp13Ctwe03P+MmfNGysYY4cZgpQRwY+U5CmhGp5wirTLCfF2Rm+hJQKRvQNFnQbZNnTvDe3st1+NIFLwJNi75uZYoxc+iAV4SXCofy4MaX0JfPKhd1ngSIS+/js0+e3F/BidVV9JFwEAr8rIRU5r7d8zMHYmoK+vWCKhonG0/fxlH42MXEbA7q+gm0bzrJi4AJrd1q9+HCrd0jjCOT5jKdDmXUtLdytkbG6VVCK1V00GF0NJ6jL0kFjHWkAuTAlVtvVcAmWQst7PWjreT3A+8rCPB8Ca5Sy5/biqo05x4GLwqMsKPIoGsM/nRJ/skX36qgYsQ6OCl/miEINrcfa65BFmsWMFWWV+9HdZjSV0TAZdoT6EyJqFF5brKU9W9DLFGl4drQZykjAjlo2g9PKhGDU8kW1ybvVE01uUYEUPcduJqedn8gGkbLtdJVgfcyFDcR+qHccCme6yZaI/5qjZw7P8bqUYIJsOGuEwKPiGT4vVnRBf25R0VcJeDV+CNNWn0XxIbCNfPxsbMKTfBc2dbwFvqGYImjh6lQ2qve+QnvNZnLLj+3yJE5t3LNjbygwOMts1g9qoyQNEq1KKGgl0A/Yf8vFBVC9Oa0g5gmR2shBCjx851hmC10+PlIzD1gVCzl5VLK3gvy+vCYRONmwd9hCKWMnn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(508600001)(8936002)(6916009)(4744005)(5660300002)(31696002)(38100700002)(86362001)(316002)(6486002)(66476007)(66556008)(8676002)(66946007)(4326008)(6512007)(26005)(186003)(2616005)(31686004)(6506007)(53546011)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REttQkJuTEZFdFBHSFhYUHZmY3c4RjU1am5QSTJ2N3BJeGFWakFuWDk2Z2x1?= =?utf-8?B?eUJJTktFM1BjQVdCakRIZDFFRGl5b0pMQlM1RDVJLzU5WDRReE1tYVQ3ckxJ?= =?utf-8?B?U1U4RDhDVzNDazZWYjN5UnVGUTNud2lOU1hJSWo1Yk4yMDlReFd5bWJkekpS?= =?utf-8?B?dWJWdDlOZkV4Kys5dnV1eExmSFZuOS9KOS9MYjVqK0tTelFOanpOc3Mvdk15?= =?utf-8?B?Q0locm5pMWNTTUxoWUoyenZwVXBZNG5IOWdxcXNZaUo2cHR0RDZNOEVtTy9i?= =?utf-8?B?OHp5N0N5VEpPNFVxdHlwRnE2VExPakIvcGkxdmFCeGdCT1VvdFUxME5sT2xD?= =?utf-8?B?dTBYbXUrVkZRd0RaaUNBK3MwczF0ajVXQU83dXFSME00OE9iUVNpeFNoTEJt?= =?utf-8?B?MUlSbGQrT1ZyWUFtcWNzNUt4b2d0NCsycEwzSTRlRXpWRTZud0FjemlBUUhT?= =?utf-8?B?eVNIY0NoVTluUStqSHBqN05pUVJ5dXluNUFXRDczSDZ3c1hmNUhPbkoxbjdo?= =?utf-8?B?bzhvZmU4QVZ1Z1AxczQ5c1hON1JDNVRlNnlueXFELzJ1ZTJLblpjYWpqVnh4?= =?utf-8?B?djNDM1gvS2svNG5nRENQWmZWRXRKNXhyamo1UGxXS0F6dXp3elVvU1pXQW1M?= =?utf-8?B?RUZEdnhCZHk3aXZidFBtL2VTb3VwNDFIQ055OXpQQjJKWG1xMlAyTFdRbWV1?= =?utf-8?B?MHBsY1BCNDBmamtTVHRzaUN4Qm42enI3L2xUUitRRVF2Zm52YVQwNDNNSSth?= =?utf-8?B?cis3Si9FTlBESUxOQ2VEMmk4VWhNWUpjTzYyNmgwSjhqY0lOZk1nZGNWSHM1?= =?utf-8?B?eVlsVHZ2YmsxRnloUDYwZ0phNDVubXRTRDQ0RlRsMGg0TTNsbXVwYVMvK3lR?= =?utf-8?B?L3QzN3RER2F5N2syUmlBUGNtRWh6MTJaUXFMREszVHY4VUhxM2hxMTRYOFRu?= =?utf-8?B?dzVBTEhINjhyODNUWi90SUlrdXZ4QTJva2NVZzNYQmdPbkVzK2hDZ2lGVDd5?= =?utf-8?B?VkFnZHRxQUhuU21FSnBmSXRsY3NzbG81OTVDRjlqTWpxTGo4RTFBcU03bzRr?= =?utf-8?B?bU0yQTRWamRXTVNVeHJlZWx4Wm1CeVBMODkzK1dpYUx0NTVON1RJZGkxRW92?= =?utf-8?B?bDVxM09qclorNEFvdDgzbGEvMFZkN1dNVXRnUEl6SzBmWWFzS3BCYUNXZ1da?= =?utf-8?B?R1crbHEyYUZlNjVHcHdMM2xCdU16bGxQTzlQa3dtaGYyUUlLb0tKalRyMzU0?= =?utf-8?B?UU1tNkFOU1ZBb015TnVhVUVCOGl0RXVmSWRYcjdJSUJyOGVGbkZteDNtRUQx?= =?utf-8?B?SFhybHZPRkNxOUFzQUpJa1M5aitPd1RsUWhCWHROVlVKQlZwRTVFYTM4dVRF?= =?utf-8?B?aG1ua0s5dHllOUk0djI0dWNWWFVTZ3pGTVREZFJTeEZsRWZWU1M0WXdNamdX?= =?utf-8?B?YS9kNEZJVVpIcFBSMXRJQ0d6Nzl1c0MzTGNkQjg0ZzFqVkwwSDJKUURZbkxR?= =?utf-8?B?ak9zTDFsRjJBUmF3Y3A2RXp4NjNLc2oxVlpEMjl3ZlhPYmw4VGg1SWM2S0RB?= =?utf-8?B?Y1d5Q2djaWE4QjZYblRIQzV0Z0M1NEU0UUJVdTRralg5T1JPaGVMaFU0dVk3?= =?utf-8?B?ZVlXTThWSFR0SWFtRXU4UUxRSUNSR1R4Q0pGSHVsRjBXMHIvUTNPYU9BeFRP?= =?utf-8?B?TmNSeVVRUmVXSkxqdlVMc1cyVFNXTHhjVVYxRkRsRjl6RmhpMmx6Q0dsQVZi?= =?utf-8?B?ZHhuQ2hudUFMNmJvQ09SR3B2WlVUR1FUcnRBTHErd1EvMko3RitQZDVPSTZl?= =?utf-8?B?MmdiTFhjUThoMFVuaUwreVdxTjZPd0NWRUE2YVg3QkswdXE0V3lPdW1iNnJW?= =?utf-8?B?MVBQTHkyL2hJZHVvbFlpOWF3VUpWWjdXNTRkNXF3NWRUVFVzTzl2bFJnaFp6?= =?utf-8?B?UW1hV1BGSCt5Qmt1YnVKUUQyNHVlaUtoaEtKVndHMU5pTU9CN2dqbE9Ia0ZZ?= =?utf-8?B?Wjk3ZUE1eVNZMnA4YkpxSlpQQStQcHBma1FCOElVY2dQNlhza1ZLZUtSVFJ3?= =?utf-8?B?UE9mUjNyb2luTU53ZUp3Y0pYekpzbFlQR0xJT2tFYUlCNXp3Y285a3loNmQz?= =?utf-8?B?TXdnTUVmQjd3NVRLb1FLZjI4NHVON3EvWnd6WUxrSXA4a0FBYzFTWll6WlRB?= =?utf-8?B?YVc5NUhwdE5SWkdwSWh3bU5ySUtobzdsUzZHUHZ2V1NTWGlpOTBzWmpGcmlm?= =?utf-8?B?SmJXZzB1ZUh0a3pyQjdTLzA1aXFWdVFNNTFiT3RwRGx1T3pPbVR4ZFZabThI?= =?utf-8?B?ZGRyNVBBS3M1eUJuVkIzdE1UQkRLUHdhaU5zcFFJaTZhclhIdmUvdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad1ae64b-9da0-4a72-f30c-08da2e884499 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 11:13:23.1153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K1lvfcPxREqQzcicpZKjym59HlV1erC1s4WWIb7o8vI6PVVoY+CiL/xYH4Ttrw5wrVvDHz4nOeIcvYkMjtbRYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5362 On 05.05.2022 12:36, Michal Orzel wrote: > --- a/xen/arch/arm/include/asm/grant_table.h > +++ b/xen/arch/arm/include/asm/grant_table.h > @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) > #endif > } > > +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, > + struct domain *rd) > +{ > + return false; > +} > + > +static inline bool gnttab_release_host_mappings(struct domain *d) > +{ > + return true; > +} Looking at x86 I think all three instances of struct domain * want to be const struct domain *. Then Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 11:20:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322012.543196 (Exim 4.92) (envelope-from ) id 1nmZWv-0003N8-Ld; Thu, 05 May 2022 11:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322012.543196; Thu, 05 May 2022 11:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZWv-0003N1-Ih; Thu, 05 May 2022 11:20:21 +0000 Received: by outflank-mailman (input) for mailman id 322012; Thu, 05 May 2022 11:20:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZWu-0003Mv-Et for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:20:20 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55920b4b-cc65-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 13:20:14 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-7IYbrM9aNxaI2lO3217H7Q-1; Thu, 05 May 2022 13:20:15 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR0402MB3399.eurprd04.prod.outlook.com (2603:10a6:209:7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Thu, 5 May 2022 11:20:14 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 11:20:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55920b4b-cc65-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651749617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mVTX3TkakSlTqqRukpP5/yEJBJhUFNk6zXYPPW9fKE=; b=n3EFAGNjinVbDQd0MXonmoBlPFBDl0/uvEgILhO8omi9BREcGzNSDVnFiJ9AMrGP12LLmX Wc6pRe8Xb91kisgq9we80ySCD5mB13g9YwYZNb8W4hqmRGE3H3Cv42xU/k9EfMdPW5tb18 UfDSp/9iuBRaPeG6xHefVILf87CtP2w= X-MC-Unique: 7IYbrM9aNxaI2lO3217H7Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PnC+eK0SLCMjMPWLs7PW8hRsag69oI12Yf0HzonGH1MA+bGqovQgopPZ1qXEx9i8mO2CDXxL8DeeSz939rfTOsSXRaeeLVKg1gE+NF/Y+CvGFQ7VvRNnVzYnNoXE5Py4+MY6FsW4J3LbNq0qqZHAcHsC+ZyOh1V8IdAj0exNBa6PF5jSxhQCslc/XNiOb+tF/FIEOgV5/okleRP6Tl4SmAI79FYXMOEhcJeVpTTsQfhWTk2uFvqVv2Ur2MlK1tIlrnbulEle9GoqZKkYJ2XJjcRWECfZfkpU4ZsBbNc7Zw9pPkDItiEtDaMljZ7d6Bjv/8JYOwPQ2xiOsBNLawJKYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0mVTX3TkakSlTqqRukpP5/yEJBJhUFNk6zXYPPW9fKE=; b=Y+36MiB4u1aHNK9DezaJLJStXRqOn0WUWtPkDCDms5Ya5oJK3j1eBa+lQcYucq5mx4uZ+prQ71spfXP0o6dtzbNoPkke9j4lxgx4JiuFKWMe33AVg/SIKvWc5Xe0lavNWk91mreF2cP5w2wPz5+aCvVP8WJlbGDSPuENc0wWBoZNVMENjkqd3C8jh/E9K5pBHEzztmZ7Ee11D8W4Kjwq6WRYPOq+VbHiBYs1e7QJoOeaE4HZX0xzHpFtROgDIMgwYbojL2hYCmTUcOacT1OxRCAMBkTZtqBzTLZtSfLSd1arLD9BIDAHBMa8Oo2dEb35osGrzobxsRUXyWJ4ZLaKPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0bf31f91-9a05-ac91-a258-d28d6ad9084d@suse.com> Date: Thu, 5 May 2022 13:20:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-3-michal.orzel@arm.com> From: Jan Beulich In-Reply-To: <20220505103601.322110-3-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:20b:312::8) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e2ff6db-7543-4b78-b62a-08da2e8939f4 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3399:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gl3c535e77Rv31bvpWwXchbQYdnCuYbSjk6ypm1NyFI63Oz2YJRJ1/KmV065fyhrokd4686lx1BsOEQArl5RjHf4xJezRNpqzb1k0jLiIEl8vROSIzokT1al2oKg2cIn0pKSseSqBLaZVEYnsjfZGmB/C1p6fOUbZIecQ6J6elA+WZps+yTjqRI22Jz7LJBlh9H+eHjwFqpN9jfHtvbcxoCuS4UsFCJ35jFVLZpKDrdhCvwoshweCuTTCQFRPhZziebF7aslyEOO9I74vtP8+Qct5HZ2Z/qXsnEh/LrvUx/MbX8pj6B/5/edc4ou2Voa0n62nFrSs/vgR1ywqSxMM/JtLcvYVfYKEryCMZeazxTsqzXi2+3L4eN6WZFiEKwWXAdb+d4xqxM0A1MczxyK+49tNWujmOQN/BksrPw9tYN/1SwSQonKpcdWu15b4OLm+ArEbOlyX+gkY+pIbDhzRCiqdoxzDNhNwLc4KFUFIGnWRDsG6Xab986wOgxBkUxlTwfiRN4UaJEr4Mc8pdVhdkIBXmsHuhPpDwsoBK4e2zcXIL3yY+A3uNM+dNF3eWRIRIcZnq1Qt7RmpWnb+TYH5ZX7HO94KR3RU5uuZo3Ez43ch77p+PUl+EC2i+PR+d2MBpiWYlZNDeLqvGPLsoJnRB3aNw7EMnwMrIDjlVhocTWncZ3R3UlAuMItXJt8dpBk8AaDrVC9Ll7M4PHRPVawZEK3muXVfc3doZrJ8mc5n+M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(66946007)(4326008)(66476007)(66556008)(8676002)(6486002)(508600001)(6512007)(186003)(316002)(36756003)(2616005)(86362001)(4744005)(53546011)(38100700002)(31696002)(2906002)(31686004)(6916009)(5660300002)(54906003)(6506007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlFWVFB0SlNZTWYzVEJneHFIb21IdWJVMCsrUkxPSEJUc1pqc3dNQm4yT2pG?= =?utf-8?B?YThDQmJoOThkektaenFua1F2UzZSeEZwTXp0bWpTSGhpMDg1Ni9ndzQ1dUF4?= =?utf-8?B?OGZNaTJjbTlNZ2VjMVJXdlRveDFUYU14RVkvTWR4aUIyZ3JocUJoMFVoYVV2?= =?utf-8?B?dFQ3N1ArVE95L2J2Z2NjYXBpb2l4bUtPMWx3aHFEY1Z5NFpMYjNhV2craXIx?= =?utf-8?B?dG8vM3lMSzRvUDRobUx0dUZOOExDZTYrWGx5dUIrKzI0a0pNOFRQMGFoWFov?= =?utf-8?B?bk5kWFR3L1FheUh1SUhpUjBFMUlHbHdrVkIzK0tSRC9RS1B0YjhreXVQMVhi?= =?utf-8?B?YkJFUVRURFFJaUNreXNXaHJHdEkwT2ZxbXNJa09RUmtMY0V4Z3VSUHcyUFlp?= =?utf-8?B?c21zaFR1VVplSEwyYjJmMEkwZ2pTdFI5aVIzQTIyekJ3WUdCOGtrQS9aMG85?= =?utf-8?B?amMyUkhLcVA0MnhJQUJqY3plL2J6eldqNnJtRkNlb1JoTTlSQlgwcjF0N1d3?= =?utf-8?B?RlRRaVREcXBkOUg4V2JaaXkyMHlscGZ2cHlzaENSVXNhTUdDS0FoVjJVMko0?= =?utf-8?B?ZldPZmJtVTRGaU16eFF1UlEyc3dpc2hjYmRsT2ZZWHhyT1BuQkxyaEk3RHF4?= =?utf-8?B?Q092aFNVWE5oaWQyMllMTVZNWklnUllIRFp3aTVZdzkrL1IvaW9ZVkJEb09j?= =?utf-8?B?S3kxcnlkcXFmSDZQOW9XeTdOK1hraEhuVlVBdThKQ2w1bjF3K0crcFBHNWt1?= =?utf-8?B?cXlqdUlOOTFVaDVaU0kvUlc4c2pDUUZSQWYzRlR2SGRpc3JZSzcyQWxNMTRn?= =?utf-8?B?aERTMXJrTC9BY3pDc0FsWkpCMVJuQTcvNHd3OWVFY3ZicWVHT0FMNm1OVG9M?= =?utf-8?B?WHdJS2pyMU1OeFhwSFZ5bFY4VmRsVndXU2lqdWUxUDhYUXpuTmMxUUY3TTMy?= =?utf-8?B?RlBRam85blYrakZkUmlXaERBU05jTnJYQkRrRi9VNnZ5aE1BRkpPYkVFVUYz?= =?utf-8?B?OTZ4aHpYUVZyT1ptb1J2c3hvZUF6QURJakpGdlJRT1RlanVocExXbTl2MzFq?= =?utf-8?B?Ni9vTHZ2cjdaTmo4WGFVamVNcm1MUXRYU3BCNFpkWGRVS2xCYnBSbWNodTJP?= =?utf-8?B?RE9NZ3RHaEozWVQrZk1WaDBEZ3I0SzVZYXQzcmtoM1hqbG45cWR2SUVhYmVK?= =?utf-8?B?OWROQ0NENzRLR2llMGZENXpRT2FVc0pObUZmSDlaVDViM1pZaDZSd2ZvZlAr?= =?utf-8?B?Zkk1WVNsaktRd2xlY29BNVU2eUZiaElBeXVzSjMrejNQOXFkVkFsaEpRRVRk?= =?utf-8?B?aXBBK0RTTGJJNkJkdWlERlpWN0hqc2ZFeDNoQjUyVGpjcVI4S0lRei9UNVlJ?= =?utf-8?B?SksvRDhJdXJxWUZjUGdRdllGWkJERXd3aWo3QWJCdmEzT1ZoQmdwU0J0MUY5?= =?utf-8?B?WUFaeUVMbERIa3ZOVE1QSldRN25tMzI2VzVLbUlhUVVwbzJIQUVQQUJWdFow?= =?utf-8?B?Z1ZyQ0tOZlZQWkNwNExuSkljemtyT3h1TUdyY1VVclEyczBGYk9iSFJ3VU9s?= =?utf-8?B?QllLSDQ3ZXUyZEFXK0FobnlidEN0QjFydHQvUDdWZWxrSnAvNTZPQkRtNis2?= =?utf-8?B?QTdzK2g2M0oxL1pueVFPcmI2UWplVmZkWDUzekRFWmsrOW5pK05ONmxVYUU2?= =?utf-8?B?UFZXVmJ3dzByUFMrUThLSnA4OThDV3JpZ3FrVmw1bHluR1lnOTZwcFBHUzRy?= =?utf-8?B?M2Y0MkEzSDIyTmhhZWNiZitGUTFSOC9PcXF6ZHU1bHBiNDUrekhzMStxY01O?= =?utf-8?B?S0pkUzBKK0JCWG92T3VWa3kzZnlNaXhFb2J3eHN3OFhaempmQkNpRWYyem1F?= =?utf-8?B?TVF4Y1JxNDQ0OTk2T21oOXpZZFdybU02RkM1ZHZJQnRFa2tLRE54TFFRQ09q?= =?utf-8?B?ZjU5Q2h1ZExCRk04V0h1Z1hYeHR2aHErbFlGbDh2OFhIWnVmNVkvWFMrTFR0?= =?utf-8?B?OEhTY1ZFSkthajh5UWVuSGZrdVZyOStVaTIxNWJEd2p5LzVUcVNJajNSM01u?= =?utf-8?B?M2JPRDZBZm9lYnRDOUNFNE0wVytKRitVdWc5ci9OVW1VeWZJUTZ3OUNaMHIz?= =?utf-8?B?ODZXcEo1c29GanpsYk5PVVE1QTg5QmdjZlVGWThHZVY3SmltNHM2Wnd5WnFj?= =?utf-8?B?QlllSU1MTS9zK2N5S0N5QXhnMkwyMHVSR0hneTNiOUhRZWhCZHp5M3REYVkr?= =?utf-8?B?Nlo3U1VNTjVkNnpSMGphRk1Bdmd0eWloWlgvZnlka2k2Ymd6cUVncGtlT2Nu?= =?utf-8?B?WFJYUDNQc2hXQlpFWGpVc2ZmcXhMQnVIMzZRdDVhR2R0OFovTzlDdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2ff6db-7543-4b78-b62a-08da2e8939f4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 11:20:14.5488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tO/AUAeQiS+0fXqt70t8Tf68jjTEZlypNLImNeLf26t529mSNObnkzBjt5ubk890NPNvRPG4NX0kEuGqBIA1/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3399 On 05.05.2022 12:36, Michal Orzel wrote: > Modify macros to evaluate all the arguments and make sure the arguments > are evaluated only once. While doing so, use typeof for basic types > and use const qualifier when applicable. Why only for basic types? To take an example, passing void * into gnttab_need_iommu_mapping() would imo also better not work. > @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, > }) > > #define gnttab_shared_gfn(d, t, i) \ > - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) > + ({ \ > + const struct domain *d_ = (d); \ > + const struct grant_table *t_ = (t); \ > + const typeof(i) i_ = (i); \ > + \ > + if ( d_ != NULL ) \ > + ASSERT(d_->grant_table == t_); \ I'm puzzled by this NULL check (and the similar instance further down): Are you suggesting NULL can legitimately come into here? If not, maybe better ASSERT(d_ && d_->grant_table == t_)? Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 11:25:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:25:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322020.543207 (Exim 4.92) (envelope-from ) id 1nmZbr-000452-De; Thu, 05 May 2022 11:25:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322020.543207; Thu, 05 May 2022 11:25:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZbr-00044v-AT; Thu, 05 May 2022 11:25:27 +0000 Received: by outflank-mailman (input) for mailman id 322020; Thu, 05 May 2022 11:25:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZbp-00044p-9F for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:25:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0de6697e-cc66-11ec-a406-831a346695d4; Thu, 05 May 2022 13:25:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B47A106F; Thu, 5 May 2022 04:25:23 -0700 (PDT) Received: from [10.57.3.137] (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96B953FA27; Thu, 5 May 2022 04:25:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0de6697e-cc66-11ec-a406-831a346695d4 Message-ID: <77ba649d-89b6-8a15-191f-6e4261b7e381@arm.com> Date: Thu, 5 May 2022 13:25:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-3-michal.orzel@arm.com> <0bf31f91-9a05-ac91-a258-d28d6ad9084d@suse.com> From: Michal Orzel In-Reply-To: <0bf31f91-9a05-ac91-a258-d28d6ad9084d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jan, On 05.05.2022 13:20, Jan Beulich wrote: > On 05.05.2022 12:36, Michal Orzel wrote: >> Modify macros to evaluate all the arguments and make sure the arguments >> are evaluated only once. While doing so, use typeof for basic types >> and use const qualifier when applicable. > > Why only for basic types? To take an example, passing void * into > gnttab_need_iommu_mapping() would imo also better not work. > Just by looking at the majority of macros in Xen, typeof is used mostly for basic data types. Also I think it is better to explictly use a struct type for better readability. Otherwise one need to search in other files, to what type does typeof evaluates. >> @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >> }) >> >> #define gnttab_shared_gfn(d, t, i) \ >> - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >> + ({ \ >> + const struct domain *d_ = (d); \ >> + const struct grant_table *t_ = (t); \ >> + const typeof(i) i_ = (i); \ >> + \ >> + if ( d_ != NULL ) \ >> + ASSERT(d_->grant_table == t_); \ > > I'm puzzled by this NULL check (and the similar instance further down): > Are you suggesting NULL can legitimately come into here? If not, maybe > better ASSERT(d_ && d_->grant_table == t_)? > Example: NULL is coming explictly from macro gnttab_get_frame_gfn right above gnttab_shared_gfn. > Jan > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu May 05 11:44:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322031.543218 (Exim 4.92) (envelope-from ) id 1nmZu9-0006Pf-1l; Thu, 05 May 2022 11:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322031.543218; Thu, 05 May 2022 11:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZu8-0006PY-UU; Thu, 05 May 2022 11:44:20 +0000 Received: by outflank-mailman (input) for mailman id 322031; Thu, 05 May 2022 11:44:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmZu7-0006PS-Uh for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:44:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aff3a505-cc68-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 13:44:14 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-EELKo-5nPNOTOVEolQlI8g-1; Thu, 05 May 2022 13:44:17 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DU2PR04MB8757.eurprd04.prod.outlook.com (2603:10a6:10:2e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 11:44:15 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 11:44:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aff3a505-cc68-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651751058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qXjhfAx+ngtQyxYpNNyRHM9koDR7MpOhQ9Ev2hHU3DY=; b=kFGIcR9OpbXPzSw5f93qaK/3FE3CNZ17oPLzBNXFlR5sT7uRiMq/xdWjHEtnfxnMRMKmw3 f3wxTprhFm9ZeDSGfO1+xMNPKiks1ts2R5csipapWqwCawC4CsjE6Xf4dee1aNlxlz/d0K rqwpXpNMP05orkVehIJNKNUfu6Dve3M= X-MC-Unique: EELKo-5nPNOTOVEolQlI8g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7/E1HqGS4RywRK9/BHN1nbYja8ZWU+/DrIx4IbcE/AWKLKWp2mqTYUtdmachSm+6gnLO3UXK9huqhFtp/zEo0bVylmxIGmiO8Q62k2EEGRGnN8UBXHM8i/ykL6m7euwZYRGe1cI3RWVk1tiKZvWBta5WNb4uabF4Ky3AaL2YRVEdXs76UgLQKAV/aS5euVWvynkCcf3y7hw5qOCLPzUHqtdqQzKxLduxst5nayk1KkNGU9KpGilY8MAy4GKF9vpuocJz1YBSEaT6S5EsMYhtwcwShbZT15tO4Uq8j3mUYx4/J1GNkLelu0qGo5M+5hbAWMBUXpfg3g46dttkNoDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzAUuUk5ZHPwsHZGXAwqO9Q/Yk3SDydaDJ7ipfYDrYM=; b=asbRIRmD5oMLn5mLCuQ20DlA7S32ZqV1gYuxAhJ1Oe2ELEi+dkzE/bTJw8+blCmaskOH5AR6/+hFZ8eMMBc2frEhUJcFaTb4sCuUaScyMqgQadiLrnIYIlAsVlpZ3QDYUdZiqJmkmdSlF/OpK+JVqMq/I9lo1cdezVhR0Qb2RrYqkU3OYvHBG7iL8CF4l7cW84t/A9cjYiV23+IjNPoVwmrDNCSYyGl/2QslV9e5IpWuErwJum+GXMxz52gL/GXfpvfvfKxETOFbgYDpZkb7wCd3qCnGruHYcFjQgSPgd0ckPP3fjFXkm6PBzllemui+CY4uhQF2wD5PDSPUKCjrUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1073709a-08bb-7795-63ca-dc4055c0b9fb@suse.com> Date: Thu, 5 May 2022 13:44:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH RFC] x86/lld: fix symbol map generation Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220502152020.19768-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0398.eurprd06.prod.outlook.com (2603:10a6:20b:461::17) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15327202-5eae-4d35-cf48-08da2e8c947b X-MS-TrafficTypeDiagnostic: DU2PR04MB8757:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qmt9is1T0OJRb3P3RZz2TGe07ZYwX9dZWupujPj8Q1kbj9G6A6vvfM4sVzGmnrBKhaWFUy2O6vj5JSZZZfVlFL01aGKPdQehj34iY7s2j6Pp8OtsUuB1BkcMv9IbdlZaeEZ9r1Q9IQRG5NfU77CMTv6EIvaeKL5P/H2J5M2LeIjU5/nDUHEoDj51BjQ+lIQ3Kdq7HuaMeQt7WXc2qm2mQRhEGTU6mtZvDsuptWzi6wVBpujvDCzYNd4fUZSp/R9GCHzeJATV9t6GnyNn/gP07lQI2eWnKHwSYlauZDOLarI7zS4gmh2Dt0IRcJnA1yM6OBukSMUr2vPe7Gtnk0xXfkKdYeIv3Ty8odjBwrG1wBE9KcJaYxDWrdlL2TrP2/MMvP6o4/mjputqLrO4SwqXvSzVjmM4Ym9C7MKtIur34heLGXXid98+DM177A1BDjavwCUmy6jMtnDHReTHihDiXdtmRIwXyP+hxLxlHwBh5fxx7eem0b6lp/dfOUYPy5vUHoVNESGajBkc3PSmEwuXLsY8ZXVexe7QaW7pLKnqrRoTNmnprb5/sB9Sm8mwDcrcL3XMBA6w9rGETexe96kSmeaKUK2RqE0QQ0CeHpQIDZRaoE2+eIeDTc8sxJvuF/QKsADaUbDOgLVibVxkNgzuW/y48MmSfRCgconqhXf05ZAlm42kKrkwKO3QXvf8QEa/elA990QkmqkbdQpnS0Ar2yV2crp0l9AKJW6WgTl5yb+9oWqqZtuZWKwvQGHu4HuE6/IKqNDB6pqkFv76M2n7HAnTpD+je+XIOKFUVOG4Q9PPd1mqv69PPmzqf1bw52St X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(316002)(38100700002)(5660300002)(8676002)(2906002)(66476007)(54906003)(6916009)(8936002)(4326008)(83380400001)(6506007)(53546011)(6486002)(966005)(6512007)(508600001)(2616005)(26005)(186003)(31686004)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BMIcZKWSZdMPf/+Z9hLbR5Sm5PiaM6D8YrIm5kkupYVQ7RZUbVo75yM8OHIg?= =?us-ascii?Q?cPD9ldyR89nFn1dRYmKuzbVqqrjxNoNwbd9gW1oCKVmVLEe/KukQDNAEeejg?= =?us-ascii?Q?9ipdkTfUY7P5uMq5VIkDhog96ocyS1nQsvDl0xRD44ugofq+glMBTIQdrrIL?= =?us-ascii?Q?c29HoLxXoJPDLSyDfUCA+qgniTDcBenoNLd0y1KvzF54RUTyln9GnbCVZXh/?= =?us-ascii?Q?uxQRotaQfEUv39116yUqYKr5GxHaz5oyS5jGlpCwh0HML8ih7IKg6CyzGtNb?= =?us-ascii?Q?jmFvJxzEAya6qBLgKELh7wY7/eE+jwc97GBf5CXt8mlVCxd84CvcdibOYH7L?= =?us-ascii?Q?z2kM/5N3w3OjZv4ZXBjspJhrkfCFEJgs+xiWl9FQp1URGhxjEwb6VvSzaKv5?= =?us-ascii?Q?0djgNA3AUhknb3lVCacF2NPr/rmHxMBTCBnBwzF6MYiojae1mUCkRMZ/Dv05?= =?us-ascii?Q?D6K0QWwwEuXHEStcIFlv1mJGT8NidV6P5RKNpFMgjkbMPygG/08NVc5H5KLc?= =?us-ascii?Q?vW/zxbD2dBgRaCs5pFnpIHPfjvX7Y2o52kS3SVmoiS3F+f/doWllonkxyjQq?= =?us-ascii?Q?4RXJxz96T4UloI7tFXDI2TCjldbFWf6XCRPCkHDz4tlDWRX/6oTsLSDqrWBG?= =?us-ascii?Q?e0wDHyqQEkQjlyuYt/U5lStARzYVbUyTLOMzOLI77R9WW18pvjBeMsjaHCv6?= =?us-ascii?Q?PRaW1hqeD+RCAVvKQNdfUs5gLX7tvDqA5FojTKQkBICUcXKrcyQps8agbzTo?= =?us-ascii?Q?VeEMaS50lnC2fZjhO2Is+h0QJ3u5k6eeocR3yz55uBGwCA/ix8avDh3GtfBX?= =?us-ascii?Q?+IApFRU6JQjwjGaixXFo3hYm/p3gsw1P1edBQMoK/+VxbfHjqAYQHHp/xKGN?= =?us-ascii?Q?qSy/OgVjIh4CDqP9L/BXTpfGfA8kI5cDTWzHhM3QIlVxnQGQ3Y4HLsvNAH0t?= =?us-ascii?Q?sMRzIBQqlgeuOZpwjoMoIqMgI8nEj3GzAZYiz9Ljz+NQx4e3F3KzN2a/xxiV?= =?us-ascii?Q?m6rYMrjUr9j7uG07/JHC5OWLiMHJrCUkiZrDkfkU/JEB40gc15Suj+Yf3ogr?= =?us-ascii?Q?VVIBRchHk1qwHefbMvzalOfs93Xu58WKv0jrjrC5LZ1UXjZAvOxeFUv5z5vG?= =?us-ascii?Q?Bx+Z2Ojr5nuQ/s+/P/+fGepBUUq+2/CZvb8gACH2w7QZ3cWicqbr/BvS+aII?= =?us-ascii?Q?GAF6UilVzzbIv+HETtEhiUdzBlxROcTKZGyL5zNkTjx8irws9LsJD91vUWhx?= =?us-ascii?Q?zbQZfY8tlGOuF/i/3WCP5per61NlrFLmu2BMnRXyjY6+I93jOCUwrq38/rFd?= =?us-ascii?Q?JDklkVmh41xRILZCe9FWBDIrssD0q25PmstfzgwfkH26BUFalcM0Ypi3nwLK?= =?us-ascii?Q?aUo74weggQlqIllCWiLqrtuw6xzGLWtHTwQy2x3OpaLEQXL6OqPRDCywt9s6?= =?us-ascii?Q?xDZc/zrLKe5uU4jJTiR0t4F9XPFHXXypEZfG/Bj7voP4Fu3VjfqQCTfUFMV5?= =?us-ascii?Q?vP5swJIkkfvaAhUlrLpZW6llvfR9GGJiWroi+Ngbd9k0ygTDHXGBnfdkh64a?= =?us-ascii?Q?79a+ZfgvwoifBAwdm+PCibGncj+fgo6nRFAkvbyAAwb+8JBymeJ4cXxxuFgG?= =?us-ascii?Q?FrnRw2nN4WxAKiIQDIzz0MgW8Scp7AdBRL7UNm4fGcN+kWB3929ROP7iisRx?= =?us-ascii?Q?DUuxJHxiJ+NjkTNQjzloNfD17e0Ao6s/XAubKwsQQEmtRzW7ygLKcXonuP5C?= =?us-ascii?Q?YHeGNMDotQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15327202-5eae-4d35-cf48-08da2e8c947b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 11:44:14.9193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SPxFe/sOxNDNvou80vJobxPNAxn/6XlInK7lMJMHbQLHqBjtvSzNrOz7KoepJ7dbOtxA+BQE6/IL+fOjewXgsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8757 On 05.05.2022 10:39, Roger Pau Monn=C3=A9 wrote: > On Tue, May 03, 2022 at 10:17:44AM +0200, Jan Beulich wrote: >> On 02.05.2022 17:20, Roger Pau Monne wrote: >>> The symbol map generation (and thus the debug info attached to Xen) is >>> partially broken when using LLVM LD. That's due to LLD converting >>> almost all symbols from global to local in the last linking step, and >> >> I'm puzzled by "almost" - is there a pattern of which ones aren't >> converted? >> >> Also "last linking step" is ambiguous, as we link three binaries and >> aiui the issue is present on every of these passes. May I suggest >> "... when linking actual executables" or (still somewhat ambiguous) >> "... when linking final binaries"? >> >>> thus confusing tools/symbols into adding a file prefix to all text >>> symbols, the results looks like: >>> >>> Xen call trace: >>> [] R xxhash64.c#__start_xen+0x3938/0x39c0 >>> [] F __high_start+0x94/0xa0 >>> >>> In order to workaround this create a list of global symbols prior to >>> the linking step, and use objcopy to convert the symbols in the final >>> binary back to global before processing with tools/symbols. >>> >>> Signed-off-by: Roger Pau Monn=C3=A9 >>> --- >>> I haven't found a way to prevent LLD from converting the symbols, so >>> I've come up with this rather crappy workaround. >> >> Perhaps a map file (like we use for shared libraries in tools/) would >> allow doing so? But of course this would want to be machine-generated, >> not manually maintained. >> >> Have you gained any insight into _why_ they are doing what they do? >=20 > So after raising this in the LLVM LD forum, I was told this behavior > is due to the spec: >=20 > "A hidden symbol contained in a relocatable object must be either > removed or converted to STB_LOCAL binding by the link-editor when the > relocatable object is included in an executable file or shared > object." >=20 > Then I did some search myself and found that you raised the same with > GNU ld not doing the conversion: >=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D12374 Hmm, interesting. Too long ago to remember, but yes. > So it seems LLVM LD goes a bit further than GNU ld and also changes > the binding of symbols in the .symtab. I'm not sure I would consider > the behavior of either linkers wrong. I agree (taking into account Alan's comment in the bug report above). > As a test I've attempted to disable the hidden visibility setting we > set in compiler.h, just to realize that parts of our code do rely on > having hidden visibility. That's the bug and alternative constructs > that use the "i" asm constrain with function pointers. That's only > possible in the absence of a GOT or PLT table: >=20 > https://godbolt.org/z/jK3bq4fhe Right, -fpic would then also need to go away. > So I think the way to fix this would be to set the visibility to > protected instead of hidden, Originally, when we introduced the use of hidden, it was pretty clear that protected would suffice, but using hidden seemed more logical. Now that we have a reason where hidden ends up being too strict, I agree we can switch to protected. > and then to also make the setting of the > visibility unconditional: the compiler not supporting -fvisibility and > Xen not setting it will just lead to compiler errors further on during > the build process. I guess this being conditional pre-dates our requiring of gcc 4.1, as that version looks to support both the command line option and the pragma we use. So switching to making this unconditional ought to be fine. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 11:56:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:56:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322038.543229 (Exim 4.92) (envelope-from ) id 1nma5R-0007uU-42; Thu, 05 May 2022 11:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322038.543229; Thu, 05 May 2022 11:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nma5R-0007uN-1B; Thu, 05 May 2022 11:56:01 +0000 Received: by outflank-mailman (input) for mailman id 322038; Thu, 05 May 2022 11:55:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nma5P-0007uH-GS for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:55:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 534ab6a7-cc6a-11ec-a406-831a346695d4; Thu, 05 May 2022 13:55:58 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-FqL5NIvaM_ysMoI83ygxAA-1; Thu, 05 May 2022 13:55:55 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB7681.eurprd04.prod.outlook.com (2603:10a6:20b:286::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 11:55:53 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 11:55:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 534ab6a7-cc6a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651751757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Ip9NLDbIkinEk8L3v7zxIbR5eNjq31A39HEQEZfsmA=; b=ACDR6jCC5CzpflV94obtFwXYGEoqm4c7UVXhwCasH7vKbotYNS0wKGsPrQwYT+kDBj6i/0 6VXmLL/o/RXxzAsJFbi3iHq8gTSIiFfeCC2BZa/vZNouvobzI/ueUqXRfuA0eh8WsMZiy+ zps9YhhraTxbZ0Uazc4llu8REA1PPSw= X-MC-Unique: FqL5NIvaM_ysMoI83ygxAA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B31V0Fw5uzWM/PQeOgp6v8uNJezWqvCSWr8GEFDTJ+0cHmHxFjXn6nmckA8c9KBNEKlXbG7DGDQoqNgGvszfj8RkqtPU/mvLiE81dPEm2AtLXTJabY+SF9OtdGaDYf5YDtXFsYQYlILflDtJaBsHsih9C04J3x/5jNU0M4/7h26g75JGAq+VE7qG/dT2W4YTES/zWOM6GEMlN2a5NSH8j7Q08hqLMnXbwH/pKuOmvanCQySlFWyd0kEEuEVvJN0MMqr29y5RvulXvbUCfY+7+pys+w8x6cpPR6729sQ2sL3x1Wm7Q5NUpFHOjvPbvEdjA/3HU4nvO5Y5NY1mchBRbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Ip9NLDbIkinEk8L3v7zxIbR5eNjq31A39HEQEZfsmA=; b=n6Yamit5blYAEGNIuAGrMqJalTCYDZIMB0JRGsN936dt0/F9dqrsiRFgwv3mf3JKfrRRW05YQ6F0MX9//1k2yvL89TfoPhrXMXUhEsRoA8crGnqcYPvokt2o+23q0yPOvb3gHnRG9z8SyCsXrjQ75eY+ZTOoZX7Vxp4TDcETP2nhM5pqAdW2rxjUiYFyQ83DSAPsHL0fH5NhkM+i7tXyrRLOOAhVfXCa0Cqn2xIHT1BEqEt5xl0CxaH6FO1aobUJUOkWDqD2AkGsY5qB6YRcC+N7QLhI2nlSHBJsicIjuknEbtOyr9egt9beSaK12MC6GOcBWig5LaI9INAXIs+Y8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 May 2022 13:55:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-3-michal.orzel@arm.com> <0bf31f91-9a05-ac91-a258-d28d6ad9084d@suse.com> <77ba649d-89b6-8a15-191f-6e4261b7e381@arm.com> From: Jan Beulich In-Reply-To: <77ba649d-89b6-8a15-191f-6e4261b7e381@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0342.eurprd06.prod.outlook.com (2603:10a6:20b:466::18) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cac7665-79ab-4349-397f-08da2e8e34bc X-MS-TrafficTypeDiagnostic: AM9PR04MB7681:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zi/d7lI7QtCaY82eJveLZyPeksfxXsC1Slx7iFgKIpsgbilNdYYttWJ+gb5/7OA2BE/fqv+8oy6kRPKN5/ZLTPtMjZq5oBbM4aCpFk32cfPzkkJtAonMuMV+a+PxuBmX7wvBpGov5I02exaVaab02mU3Ndqvy2Nkq2I11WCyvYzZeGnXfyPx09aFdgILbs3X6QHyf4wT2ge+fzXpGE78u2ArVKdJOCQ7Q3ulZqinn6DgU2vMip744bXFm71BKwbFgVQlHFjRuSJizz/RjpTD0bVpp5b4tqJ9HWhWx5clulNzm1S6z5e46BeFuKw1DGbDXdOtX/S+59eR7TZCaRUxbRdVLORKUs6TGDWZfSyVWz+OwlwYr7n5Hbk+Ny+94YUJAxkpNAJT0VdSuiJmCTc0yFoKIhOu9j0goLVetU377uYjj4GF5tmSqYGKSiwWfMl/kpPL9k4AseNLUlDo7OGzKEqm9HO65YTJhkl4qlwoqb8by2HSWuVNtyRzYtnro9+oLglv1tjWpjuuizRUP/4qLQZsDt61pos/8+lVAKaY5IjdFCOfWK28NT2dOWsGQ0ctol9qb/SinO52+wmmkmdO/YwysFDWSViCD5F+Y+J146a6HsnP68knibas5G++lDHDfdN53b8Rl/lZS+mtv4w33GWzYI01XssHndyrgRj7SpommdpPMvxSdjGcx6figwZ9D9TittedlQp+T/86EBcTH0u1ZFwWfPdYntC0hFsT694= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(38100700002)(8936002)(508600001)(6916009)(54906003)(6486002)(53546011)(2616005)(2906002)(86362001)(31696002)(8676002)(31686004)(26005)(6506007)(4326008)(36756003)(6512007)(5660300002)(66946007)(66476007)(186003)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHArVkNKcXhJRTFzbjdWUFJ0dUx2QXZmdWFaemVabGNUVzc1K21JWUlua25o?= =?utf-8?B?NktiSFVBWEJCVXhmTEtEZW1iY2cvZTBnQ21vYzdLZXV4eVMvQ0NmTFNTOU5a?= =?utf-8?B?ZU5UMC8wTG9vaDFtUmRWbUM4TzJzbklrNUtSUXkyT0VTUDlibmlsSHZVdEtw?= =?utf-8?B?OXZsS0x1REE1VzNuWm8yVzUydDhXNHNoSkJScjFMRm90RjhkUGdMSndRaURF?= =?utf-8?B?enR3NytzZjVNcVp6anp6WmVpUjRPR1ZHbUlFb1VLNDZwbndWbFBnSE9mYWIv?= =?utf-8?B?OVF5bVdFSUxOckw4RTZhMXEvZnVBakljcDFoWmVRQ21VbEZPekN6ZkxkdGhO?= =?utf-8?B?YmwzWGVybWM0VU1pZjB5UzZCUzhjRzFjTlVveTVVRXFUK3FhNUdGK28xdWVX?= =?utf-8?B?RkorbU9MOEp0NnA4ZTE2S1BHeTluUi9YT0dQbkxCOGJoTldYTWUzQjB3UkNS?= =?utf-8?B?UUZOZWRHYk5mN3hNQXF3LzFzVmk0cFlmdUJ2ZkVYM2RCTjM5QkFyQTRONG5E?= =?utf-8?B?QmNkZmlIeXZEMzM0TEJpNytTU3I4ZUxmYmt4YjVmU2VjcVc4MnJsQWVkd0VB?= =?utf-8?B?Q3hGR3RxUEVvRTJNTWRxSnF4U3libERHTEVTUUYvOVVQVW44WlBNUVZFLyt3?= =?utf-8?B?SlZyV3JCSDhmSHpQWktiQ1kzL1RWeDdqMEFEc1A1RTRlUWczMlpONWFwSVJu?= =?utf-8?B?UHlLSkxWUXNwYXlndnlJRStvMHo1VEVqaWhIb256L21DWWplbi9MemxOb1Ry?= =?utf-8?B?aS83VEE3ME9XTGcyQ2F1d0ZVVS9LZmdLbGlnVDk5akcxUHhWektjbzl1K1A0?= =?utf-8?B?eVlaUjBnQWJjNVZELzN6TGJXdjg1STl3Wm12Y2tNVEFkQk9KcGFUM3lobWhY?= =?utf-8?B?N1AzMjZ2UHY5ak9rbVVheXhsNjN0NThKTE9Ud25jOHBpd29DWnN2MDJMc3dr?= =?utf-8?B?d3ZLeWcxbjJMVmh1ZGN3dUVtN1pLVlpwNmdGd0FNMktHdUlVQ1dTcXZxdkM1?= =?utf-8?B?b1Mxb3NMKzBHb2dvRHdzb2R3UXJFeVVDOHpFWWhTTmVnMkZYcGpEY2t3ZGVa?= =?utf-8?B?SVBaVDNjWTRvTUMwNEU4MkdVTUNQSWRWSEJNdEpUWUIwdTR4TE9iQWpvejd4?= =?utf-8?B?ZUdqSE1abjE1eHpRdkplUzVTdzl3R1duQmJRY282ZzNxMkNlZjUvU1I0Q0JJ?= =?utf-8?B?RldSTVFuemNDb2tqK0VkV1B3YU51Z2h1ZmhGOG5QVVQvWHRPeHhQa0RSb0Nu?= =?utf-8?B?TTB2ZTdtNFFuWGgvdVRSZDVES0xVUVhjclMvZDMzZTNKWWw0NVpnTkY0V2RY?= =?utf-8?B?bFo3V1V4S2lwai9SNjJ4dEdCTC84cXdJTzNyT1hFYnRGTEd3Wk1KR3dOcHdW?= =?utf-8?B?bi9UdlVDTkZLMVJiaU1qRWdHRW94VnVWR0tKRWliU2RsZHN1akVVNEFsK2xu?= =?utf-8?B?NHpuNjRUK2VVcVVsc000SEpHa3MzSVNvbU9VbWkzZGRtQ3B5T3pIb2dFWEFV?= =?utf-8?B?eEM1WDJZNlNCYWRKYk9MVHRTM2FYWkg1K1hmNWUxVGQ1dzVta2JKbUxZamJi?= =?utf-8?B?WGRsZzlESjRFVVdBNkVMNGJqYUJBUUM2ZDBLU2FSczQrRFJFWDdJNU0wTkho?= =?utf-8?B?OWhyUnEwc01ZSm9pc2thb0cvaFV4SU5OVFJGZGNGbkVsNFMvL3lSZG9kQXI0?= =?utf-8?B?ZDBvekY1NzBqWnQ1aEEyN01aUmdaUFc2dDZXczlVS04ydWZRQmtBQ1o5QWFF?= =?utf-8?B?RFJQN0dSLzRhcndRTEUzS3kwYVNKL3RjWVhXSUxJbUs0eEZ2RlpUdGl2Si9o?= =?utf-8?B?dnExKzhqUERkTDdWYWZDaHEzVXlkK2dwUzd6QVhGb0o0RXY2aGdJN0xocDQ0?= =?utf-8?B?eWZvVHBXTDBFYkJyYitxVlRndUlQdG1neFNsLzNJTHhHYTJES0xRenBXKy9L?= =?utf-8?B?dWxvTUoxUk95TzgvVUFIM0svVGpTekF0QnpyZGFwWms2VWxVWmExbEdXTGlu?= =?utf-8?B?cHNHRDRPQmV2bjdoS2NDbUJNTGtqY0cvV084a3JKbG9iajJ0ZWh5OWZnNEJI?= =?utf-8?B?K1dXZHRWSWhka1pTcWhPUzgyeFY5RGRuVWdnZmkwa3Q1UjFSUm5pL2I2NHlw?= =?utf-8?B?Q1FCbHpMSEE1WmV4UzhNb25kZHBuc2haRlhJZnRST3BBMEhyMm4zV1IzcjhQ?= =?utf-8?B?Z3VUdk5zMVpRMk04Z2RKV29HSDdNU2dZeElnaTgzWFBBQUNkS2FnWlNKdGlY?= =?utf-8?B?OXUycG1iRVpDMVVjakNTbDZ0Q0VnR1NMcWJFTnZMVmZSdlByQ09ZeWlWSGgr?= =?utf-8?B?SXRTbWJ1am1jQ0daQUhuVC9oRzJHdGg5Y1lhUkcySURMcWkrZzRuUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cac7665-79ab-4349-397f-08da2e8e34bc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 11:55:53.2893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 69KQBt+lnvnHAyAyotJz1/FHAM+xnZblQ0M0gqEKpiXdncUR0YE89FdnkNh0v1fm0yLiNDeq9v3WCkBQnxEydg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7681 On 05.05.2022 13:25, Michal Orzel wrote: > On 05.05.2022 13:20, Jan Beulich wrote: >> On 05.05.2022 12:36, Michal Orzel wrote: >>> Modify macros to evaluate all the arguments and make sure the arguments >>> are evaluated only once. While doing so, use typeof for basic types >>> and use const qualifier when applicable. >> >> Why only for basic types? To take an example, passing void * into >> gnttab_need_iommu_mapping() would imo also better not work. >> > Just by looking at the majority of macros in Xen, typeof is used mostly for basic data types. > Also I think it is better to explictly use a struct type for better readability. > Otherwise one need to search in other files, to what type does typeof evaluates. > >>> @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, >>> }) >>> >>> #define gnttab_shared_gfn(d, t, i) \ >>> - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) >>> + ({ \ >>> + const struct domain *d_ = (d); \ >>> + const struct grant_table *t_ = (t); \ >>> + const typeof(i) i_ = (i); \ >>> + \ >>> + if ( d_ != NULL ) \ >>> + ASSERT(d_->grant_table == t_); \ >> >> I'm puzzled by this NULL check (and the similar instance further down): >> Are you suggesting NULL can legitimately come into here? If not, maybe >> better ASSERT(d_ && d_->grant_table == t_)? >> > Example: > NULL is coming explictly from macro gnttab_get_frame_gfn right above gnttab_shared_gfn. Hmm, that's pretty odd (and Arm specific). Just like with the other remark above, it'll be the Arm maintainers to judge, but here I think the NULLs would better be done away with, by introducing intermediate macros, e.g. #define gnttab_shared_gfn_(t, i) ... #define gnttab_shared_gfn(d, t, i) ({ \ const typeof(t) t_ = (t); \ ASSERT((d)->grant_table == t_); \ gnttab_shared_gfn_(t_, i); \ }) #define gnttab_get_frame_gfn(gt, st, idx) ({ \ (st) ? gnttab_status_gfn_(gt, idx) \ : gnttab_shared_gfn_(gt, idx); \ }) Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 11:59:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 11:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322047.543239 (Exim 4.92) (envelope-from ) id 1nma8f-0000Ag-Oo; Thu, 05 May 2022 11:59:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322047.543239; Thu, 05 May 2022 11:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nma8f-0000AZ-LW; Thu, 05 May 2022 11:59:21 +0000 Received: by outflank-mailman (input) for mailman id 322047; Thu, 05 May 2022 11:59:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nma8e-0000AS-G4 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 11:59:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cb03a216-cc6a-11ec-a406-831a346695d4; Thu, 05 May 2022 13:59:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FACE106F; Thu, 5 May 2022 04:59:18 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CE4F3F885; Thu, 5 May 2022 04:59:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb03a216-cc6a-11ec-a406-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Catalin Marinas Subject: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Date: Thu, 5 May 2022 13:59:06 +0200 Message-Id: <20220505115906.380416-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer and can lead to overflow. Currently there is no issue as it is used in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. To avoid possible problems, fix the macro. Signed-off-by: Michal Orzel Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com Signed-off-by: Catalin Marinas Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) --- Changes since v1: - add Origin tag as the patch was merged in upstream arm64 linux tree --- xen/arch/arm/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 852b5f3c24..7a1c4c4410 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -39,7 +39,7 @@ #define MIDR_VARIANT(midr) \ (((midr) & MIDR_VARIANT_MASK) >> MIDR_VARIANT_SHIFT) #define MIDR_IMPLEMENTOR_SHIFT 24 -#define MIDR_IMPLEMENTOR_MASK (0xff << MIDR_IMPLEMENTOR_SHIFT) +#define MIDR_IMPLEMENTOR_MASK (0xffU << MIDR_IMPLEMENTOR_SHIFT) #define MIDR_IMPLEMENTOR(midr) \ (((midr) & MIDR_IMPLEMENTOR_MASK) >> MIDR_IMPLEMENTOR_SHIFT) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 05 12:03:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:03:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322061.543250 (Exim 4.92) (envelope-from ) id 1nmaCq-0001hP-G3; Thu, 05 May 2022 12:03:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322061.543250; Thu, 05 May 2022 12:03:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaCq-0001hI-DO; Thu, 05 May 2022 12:03:40 +0000 Received: by outflank-mailman (input) for mailman id 322061; Thu, 05 May 2022 12:03:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaCp-0001h8-QJ; Thu, 05 May 2022 12:03:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaCp-0005Av-JM; Thu, 05 May 2022 12:03:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaCp-0004XB-3S; Thu, 05 May 2022 12:03:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmaCp-0004R0-31; Thu, 05 May 2022 12:03:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VfD2hMgx9BMuQtH8+OYUVRd/uLuW76celusX3+ZGbN8=; b=x8dUIAStdCw+IMeg1Vnnt+VuDm XPCWfOyO4wFk1hr+g2EH1g4ZtadH4KWp+e0auQEkuFvwGEb08xB1qe1aXVuc/FGVZIlyV9EGVTvuT XHObjIPyz8hl44ItaLPo/CP1y8/3CY2Z0KPNlt42ZqcA9K/8Vgx7EWNePE5h8GhDmW7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170147: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 12:03:39 +0000 flight 170147 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170147/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 819 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 12:06:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:06:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322070.543262 (Exim 4.92) (envelope-from ) id 1nmaFp-0002Kp-13; Thu, 05 May 2022 12:06:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322070.543262; Thu, 05 May 2022 12:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaFo-0002Ki-Sv; Thu, 05 May 2022 12:06:44 +0000 Received: by outflank-mailman (input) for mailman id 322070; Thu, 05 May 2022 12:06:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaFn-0002KT-KJ for xen-devel@lists.xenproject.org; Thu, 05 May 2022 12:06:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d14198fb-cc6b-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 14:06:38 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-bhKbU8qVOJu-C75XKnLQVw-1; Thu, 05 May 2022 14:06:38 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB3184.eurprd04.prod.outlook.com (2603:10a6:802:9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 12:06:35 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 12:06:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d14198fb-cc6b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651752402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98p1TwxYan7Gpg3+zutP7MOt3Eyiz/A+sUynE80Rr+0=; b=niJnaE1AryT4j+qtmo8YAF7e69WSTPfDjkt4sdQt4RYE+IFiXTGg3f5/7zVUistEQwrkxO 9umaRrN2qKG3ymQAMou9l5jURBrhH6Zkx7hQfb8vR+akKkLVv2pGDZ0dwFZqcEiJGvXjnM wYj4C+v44hrE5PtxFm42sNYxvbmXVm4= X-MC-Unique: bhKbU8qVOJu-C75XKnLQVw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5MkIDr+HFV/SjfZgdFUy6LcdLBJuhRirNNNhcR7cFYkZCQRKiJsqjhjAsfAAvtUpStnoBOIGyZmyMwR5qAry4DnWqqhmjxWisTbAuayfIziw3Z/CEh5/LYbPhHpLQ7L98Uey0EUxQfnHP8yjk0OXj03AmEohk1WCAJjjxIs6wkAAGYfi01DnC5kO7v8tN/UEkENeCSupBVxWXcJh909l2QMCUl7Ww5L61x2YEgrj2n1tE9T2gpU0muuAQ992+klcb2BICMBpzTSzsOQ5BxdUSyprnG5daYmmIwTm6938ciIlx/C6T7i5Sc6q3SASAz8F3uydZ2Dm2Jb1/gEqJQhUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98p1TwxYan7Gpg3+zutP7MOt3Eyiz/A+sUynE80Rr+0=; b=icG+0cEi73LgHfyAW0NLtevt6YPGzOMgv3j0y1HrxGNR96WHW+HGW6DdrviKlpawJ1n/vN8AOOz5tAOURUoHPSTmayz7nYzRwrgfJuqO720nowTbyWbDAtIGQriClRp8iI9iijc3TSiHCFQPp/FZDpeXSK4wSXEaRZ3htbtLekJ9EnH6gVxqKI/HBgrRzMRhD7KHZ0F7uCgDa8sdKrFxIFTmPSd4+RCcZnjQS+Asl56Clg3CmO4qoMisdTKDE5alFAn/XQK3HY2D9X/13o1UvgTZL0JIpeKcUDhmTJ4sy72/yhhx9thbGJZHQdqhG4JivlvC9fqgIgB2QwkSnv4Uww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> Date: Thu, 5 May 2022 14:06:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0492.eurprd06.prod.outlook.com (2603:10a6:20b:49b::17) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c05eb4eb-f729-4bba-38ac-08da2e8fb37c X-MS-TrafficTypeDiagnostic: VI1PR04MB3184:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mZhQqpBoN5FLZ1nHSiE3vFAQ+p1VKXFJMV356TtGPQkXZ2armu468Ca8BHtf96pe+I5lH7RJlGHFJDI1w4NLTWQVB00cx+6C1RERjphIeu/vnzpIlyK/on4b5PBVjlxuPlAhCReuFoMQ7hTFW6bO3+Vj5AS4AKJM233j3PqBPjSlTlCN7oj94Xx/7ulRW7r6z6xnSMB72czTSOn60dgRD5grTLOal4YAhaJR+bOTMFSsXaFQqst9gHukSV28O0f7lZiX++a+v3ELC4JCLSqSztr7XVTumDiku+Ghs4RjK5ggEZ02IrWJn03W4ejrVdQv7JDGGy2U+IOppYeScLPd0ueVsqCfW+62yTWzNdR/wH58NMduguGUjyR/bBZ0Tw23BATGfppoQX1pGm560Nuk2oUmVcwU6iSxNXOOUHY1gQsHCSM9kzlQLHZ7O3V8eUs/aC7twWTDE9l6EvyRFZXz+BuOQ79srsPbM5U45Ggy9fvO9UzaZy4eGn5BMIkA7IJBCA2xEJWyFWrxduMlhbJbtDhMWKRhEk8Mnnx4hIRUelSSQpW1p931TERS1WHMbj4H4tF8imUjZWX4D9pf56WVIh3YAKQjtNpBllZubNTeu2uXgYGOPvgnlv2mg2i6XZMZuz1nx2knRc0E/AfGwdJBVe0b9KXNKuUv4F0Ewverg/5LBETdGoH9oiSrTnZBVoOobbocwC3j1/crNcOdcgFJ0A+g75Fqi5hSuwwbrrxxi2qqEQBWjWoVqYFwwynuEn4075j+9vIEN3Lk976AgPfN5w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(2616005)(5660300002)(186003)(508600001)(316002)(53546011)(6916009)(31686004)(6506007)(54906003)(38100700002)(8936002)(83380400001)(26005)(6512007)(6486002)(2906002)(31696002)(8676002)(4326008)(66946007)(66556008)(86362001)(66476007)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWxTTmkraGRYeGU1aXg2UVNENFErc2I1TXhsd0k2OFZGRS9SY2x0aWZpOEtC?= =?utf-8?B?d01PcnBmNGRKMUQvYjBQTEhKOGg0RTZhY1FSNlBudkNCZFVnMGNQU3BUUWRC?= =?utf-8?B?TS9lU0RYUkZJV0pPRlB3Q3ROa3RXK2Q3c2lpWlFzbE9QUmRCSHp5VnJZbUJq?= =?utf-8?B?R2tLVXpHUm5mcXFmWlowY1lZT1hjanpLWXJld05SblB1bkluZWRZMlBOQ0h3?= =?utf-8?B?c0lTNEU0TFZmWCtob0t4ajRZRnk4SlZKQVpjU0E5d3E0d0FqdXlZL2FuRUZj?= =?utf-8?B?WmhNRFk0b0kxZVZRN3RqeFExNUc2TkVUbU91UkQyRjRBRXZmKzJObHFUczg1?= =?utf-8?B?bGlnMk5GTlQ4dGJlTFlJNml5TXRzd0ZOVm5XWUtQQitsQ2VqR0ozWGxScEtK?= =?utf-8?B?OFpQMzY5dy9Qd0hWS0hIT3NtN1IzQ3IvZEFza1RDTXIxaDUxTHd4cEpHdlRt?= =?utf-8?B?R2ptQXhua1NCL2d6TnduY21PTC91d2ZvVGlSb0ZIL2RYUzJCV3FVNmVlc0FR?= =?utf-8?B?b0U4SHB1ZjBMTUFhZlMyS3dSS3NWRUc2K0g3cGFMZ25GWERNamV1NmZaRTJ2?= =?utf-8?B?T0svZzBURm8wRHJHUGxNRXl5WjlMNS9CVXhNaWJkcEpGT0FXSnNQL2wvQUs0?= =?utf-8?B?MC9YeERKUlJmWllKeXJVZ0ZqU1BodUZZSmxlU0t3QWp3TUdOb0pSVWlTMkRD?= =?utf-8?B?SXc3VCs0YTY0ZjA1eVpIbW1iWHRWT0ZzU0lCUmtONEdwNHBBdGs5ZGlXcUpF?= =?utf-8?B?YmNZc2JpWW43WDd0bklGQjE5aDdoSEt2VTFmUzF0YW5aSGtOT3FzbllCNWgw?= =?utf-8?B?a1FoQ2pFeE1pbFY0R3d0WXFDNUZ4Yk84RXY1RnFoUzBVOGxSdjFMMW1XY1ho?= =?utf-8?B?bzJ0b1M1cUxmOXEyaE1ud0N6SUNmbnZmZ3A4YXB5QTdkYnVMTTBMQ2g5UVEz?= =?utf-8?B?WGxkWnJQdlc5Vm5mVW83VnRrR0xDMjI1OXNRWVBnWUJ1ZEx0YmRIUGhMbnFI?= =?utf-8?B?cnYySnJsY2RlaU9DN0lBUzNGWUJlNzFSNHN0YnZLTHlIY1dTYk1MZVRiYnlU?= =?utf-8?B?QU9zNzUzMzBPdFp0S1NGcHFLZnBacUhQNDdhaFQ0Ymg5Rk1tNXRXdVAxayta?= =?utf-8?B?Vi9PV0J1M08reWRCS2x2UzB5WHpyaWVrTk1VYU0wdjdnTXVCNFh1d3hGd0xh?= =?utf-8?B?VUFzNUdCaGNaQ3dpYmxRYmRVb2wvcDRQSnBSZm9zbHV5aWxsWWNsU0ZTbTlm?= =?utf-8?B?WXVYNGJxM2tTVlByUCtxQ3g0NE9qdVFLWUgvdkVxLzhVVERWSGJiYjk4Zis3?= =?utf-8?B?ejZIQ0c2bEtjempqZ2xRekpISi9xSy90bStaQ1VyNFB4ekZkbkRGZERqVXdD?= =?utf-8?B?TjZnREV1bzh2RGluV202d2RrZ2d3NDNEcm91NGdwZk5WMWZ5aXZmaERZS1NC?= =?utf-8?B?UmtoQ1lIZFpzSTJVUkJEYjZoL2VmcUtFWXBiNDFGS0lUMzBreDRPY0lRa2hq?= =?utf-8?B?dVJ4L1lRR3dXT2lvbDUzM29UMDh6YU50M1lNdTN5Z1lRcGVucHQ5Zks3alZu?= =?utf-8?B?VnJxZTV0eWIvdWI3WEpsMHRJU1lJSG9aOUhCQzFZQk5yVWhwY2IvV2lvZnBs?= =?utf-8?B?dDhvU1lwWVE2STdBVC9KOFlJQ3J4akk3c1ovbDkrYTFCQ1kzS3dSTnVRMnEw?= =?utf-8?B?WjI3WjhNR1RJZkp4azhqZCtaRDRndVJhNWp0QVo4SGh3VzJuSURhYXV3b2JQ?= =?utf-8?B?SjJQY3pQRHN4YzJYMVZoZ05CWE9Ob1E3MVVHTlRjbFhLY0JJK3ZkSjNyOSt4?= =?utf-8?B?d1pDNGVjNWtrZXZLdDR2N1NqbFVlWkVkdDdnd1pCYklRSW5oL1dzRzM4b2Yv?= =?utf-8?B?MEI4Z3VDM3pzQVRJQStuZHhaZGZEVnphMC8reU9xbVMrVGxONytMR001dGpH?= =?utf-8?B?aFkwQTdRS21MUTc5d0pRdERoWXJlVjdxQklIMU9WVGxsMzVMalZQMWFJMDV5?= =?utf-8?B?QXBGaXJQRXNETUpWanJYSXlZVDlmZjRyUitZNlVkN0w5ZW1lNG4zL3JTMTlW?= =?utf-8?B?RVRBUndoTDhTMWk3Y1hPL1hrcUNvbFhTem9rTk5wZllRc1pOVEZRSFJOejMr?= =?utf-8?B?TVdWYmhuTDFwSUx2TmRTQUVQM3MvbFpCM1pWMC9zR0NlVEd4QUZuVDFtaG9H?= =?utf-8?B?bkp4UVNGZWNSa3pyV20rdHh1NmRiWG1IcEpSeGQzeFpnN0krdUllYzRTSFB1?= =?utf-8?B?NW93SXVQU0JVYXlBVUpkL2Z1SXUyUmRSTnJNYnVWdjVoY3UvNWhJSHZMd1dN?= =?utf-8?B?TVFGaTQ3S1k4RU9VZVBzVlY1aHdHajBEdTE2RitjSWQyeG14VnpzZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c05eb4eb-f729-4bba-38ac-08da2e8fb37c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 12:06:35.4685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g/MpD3jZ/2elbBkunwDPQgLK8AEgIPdIxaH4D2+toifMDDrAj4SP1Bi13OcoqKuNgOLE99nsbvDLOe+PE9MwIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3184 On 05.05.2022 11:29, Penny Zheng wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Thursday, May 5, 2022 4:51 PM >> >> On 05.05.2022 10:44, Penny Zheng wrote: >>>> -----Original Message----- >>>> From: Jan Beulich >>>> Sent: Thursday, May 5, 2022 3:47 PM >>>> >>>> On 05.05.2022 08:24, Penny Zheng wrote: >>>>>> From: Jan Beulich >>>>>> Sent: Wednesday, May 4, 2022 9:45 PM >>>>>> >>>>>> On 27.04.2022 11:27, Penny Zheng wrote: >>>>>>> #else >>>>>>> void free_staticmem_pages(struct page_info *pg, unsigned long >>>> nr_mfns, >>>>>>> bool need_scrub) { >>>>>>> ASSERT_UNREACHABLE(); >>>>>>> } >>>>>>> + >>>>>>> +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, >>>>>>> + unsigned int nr_mfns, unsigned >>>>>>> +int >>>>>>> +memflags) { >>>>>>> + ASSERT_UNREACHABLE(); >>>>>>> +} >>>>>> >>>>>> I can't spot a caller of this one outside of suitable #ifdef. Also >>>>>> the __init here looks wrong and you look to have missed dropping it >>>>>> from >>>> the real function. >>>>>> >>>>>>> +mfn_t acquire_reserved_page(struct domain *d, unsigned int >>>>>>> +memflags) { >>>>>>> + ASSERT_UNREACHABLE(); >>>>>>> +} >>>>>>> #endif >>>>>> >>>>>> For this one I'd again expect CSE to leave no callers, just like in >>>>>> the earlier patch. Or am I overlooking anything? >>>>>> >>>>> >>>>> In acquire_reserved_page, I've use a few CONFIG_STATIC_MEMORY-only >>>>> variables, like >>>>> d->resv_page_list, so I'd expect to let acquire_reserved_page >>>>> d->guarded by CONFIG_STATIC_MEMORY >>>>> too and provide the stub function here to avoid compilation error >>>> when !CONFIG_STATIC_MEMORY. >>>> >>>> A compilation error should only result if there's no declaration of >>>> the function. I didn't suggest to remove that. A missing definition >>>> would only be noticed when linking, but CSE should result in no >>>> reference to the function in the first place. Just like was suggested >>>> for the earlier patch. And as opposed to the call site optimization >>>> the compiler can do, with -ffunction-sections there's no way for the linker >> to eliminate the dead stub function. >>>> >>> >>> Sure, plz correct me if I understand wrongly: >>> Maybe here I should use #define xxx to do the declaration, and it will >>> also avoid bringing dead stub function. Something like: >>> #define free_staticmem_pages(pg, nr_mfns, need_scrub) ((void)(pg), >>> (void)(nr_mfns), (void)(need_scrub)) And #define >>> acquire_reserved_page(d, memflags) (INVALID_MFN) >> >> No, I don't see why you would need #define-s. You want to have normal >> declarations, but no definition unless STATIC_MEMORY. If that doesn't work, >> please point out why (i.e. what I am overlooking). >> > > I was trying to avoid dead stub function, and I think #define-s is the wrong path... > So, I guess If I remove the ASSERT_UNREACHABLE() part and only leave the empty > function body there, the CSE could do the optimization and result in no reference. No, DCE (I'm sorry for the earlier wrong uses of CSE) cannot eliminate a function, it can only eliminate call sites. Hence it doesn't matter whether a function is empty. And no, if a stub function needs retaining, the ASSERT_UNREACHABLE() should also remain there if the function indeed is supposed to never be called. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 12:13:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:13:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322076.543273 (Exim 4.92) (envelope-from ) id 1nmaMW-0003kt-Nq; Thu, 05 May 2022 12:13:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322076.543273; Thu, 05 May 2022 12:13:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaMW-0003km-L7; Thu, 05 May 2022 12:13:40 +0000 Received: by outflank-mailman (input) for mailman id 322076; Thu, 05 May 2022 12:13:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaMV-0003kg-K8 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 12:13:39 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9198a5a-cc6c-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 14:13:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5243B82C54; Thu, 5 May 2022 12:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E373C385A4; Thu, 5 May 2022 12:13:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9198a5a-cc6c-11ec-8fc4-03012f2f19d4 Date: Thu, 5 May 2022 13:13:32 +0100 From: Catalin Marinas To: Michal Orzel Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Message-ID: References: <20220505115906.380416-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505115906.380416-1-michal.orzel@arm.com> On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: > Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer > and can lead to overflow. Currently there is no issue as it is used > in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. > To avoid possible problems, fix the macro. > > Signed-off-by: Michal Orzel > Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com > Signed-off-by: Catalin Marinas > Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) > --- > Changes since v1: > - add Origin tag as the patch was merged in upstream arm64 linux tree Note that there's always a risk that the commit Id will be changed before it hits mainline (Linus' tree). -- Catalin From xen-devel-bounces@lists.xenproject.org Thu May 05 12:26:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:26:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322088.543284 (Exim 4.92) (envelope-from ) id 1nmaYv-0005GF-SN; Thu, 05 May 2022 12:26:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322088.543284; Thu, 05 May 2022 12:26:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaYv-0005G8-PX; Thu, 05 May 2022 12:26:29 +0000 Received: by outflank-mailman (input) for mailman id 322088; Thu, 05 May 2022 12:26:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaYu-0005G2-Na for xen-devel@lists.xenproject.org; Thu, 05 May 2022 12:26:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 95494c7c-cc6e-11ec-a406-831a346695d4; Thu, 05 May 2022 14:26:26 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C403106F; Thu, 5 May 2022 05:26:26 -0700 (PDT) Received: from [10.57.3.137] (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC3553F885; Thu, 5 May 2022 05:26:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95494c7c-cc6e-11ec-a406-831a346695d4 Message-ID: Date: Thu, 5 May 2022 14:26:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Stefano Stabellini , boris.ostrovsky@oracle.com, jgross@suse.com Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini References: <20220505002304.401417-2-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20220505002304.401417-2-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Luca, On 05.05.2022 02:23, Stefano Stabellini wrote: > From: Luca Miccio > > When running as dom0less guest (HVM domain on ARM) the xenstore event > channel is available at domain creation but the shared xenstore > interface page only becomes available later on. > > In that case, wait for a notification on the xenstore event channel, > then complete the xenstore initialization later, when the shared page > is actually available. > > The xenstore page has few extra field. Add them to the shared struct. > One of the field is "connection", when the connection is ready, it is > zero. If the connection is not-zero, wait for a notification. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > --- > Changes in v4: > - improve in-code comments > - move header sync to separate patch > - use XENSTORE_CONNECTED > > Changes in v3: > - check for the connection field, if it is not zero, wait for event > > Changes in v2: > - remove XENFEAT_xenstore_late_init > --- > drivers/xen/xenbus/xenbus_probe.c | 91 ++++++++++++++++++++++++------- > 1 file changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c > index fe360c33ce71..0a785d5e3e40 100644 > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -65,6 +65,7 @@ > #include "xenbus.h" > > > +static int xs_init_irq; > int xen_store_evtchn; > EXPORT_SYMBOL_GPL(xen_store_evtchn); > > @@ -750,6 +751,20 @@ static void xenbus_probe(void) > { > xenstored_ready = 1; > > + if (!xen_store_interface) { > + xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, > + XEN_PAGE_SIZE); > + /* > + * Now it is safe to free the IRQ used for xenstore late > + * initialization. No need to unbind: it is about to be > + * bound again from xb_init_comms. Note that calling > + * unbind_from_irqhandler now would result in xen_evtchn_close() > + * being called and the event channel not being enabled again > + * afterwards, resulting in missed event notifications. > + */ > + free_irq(xs_init_irq, &xb_waitq); > + } > + > /* > * In the HVM case, xenbus_init() deferred its call to > * xs_init() in case callbacks were not operational yet. > @@ -798,20 +813,22 @@ static int __init xenbus_probe_initcall(void) > { > /* > * Probe XenBus here in the XS_PV case, and also XS_HVM unless we > - * need to wait for the platform PCI device to come up. > + * need to wait for the platform PCI device to come up or > + * xen_store_interface is not ready. > */ > if (xen_store_domain_type == XS_PV || > (xen_store_domain_type == XS_HVM && > - !xs_hvm_defer_init_for_callback())) > + !xs_hvm_defer_init_for_callback() && > + xen_store_interface != NULL)) > xenbus_probe(); > > /* > - * For XS_LOCAL, spawn a thread which will wait for xenstored > - * or a xenstore-stubdom to be started, then probe. It will be > - * triggered when communication starts happening, by waiting > - * on xb_waitq. > + * For XS_LOCAL or when xen_store_interface is not ready, spawn a > + * thread which will wait for xenstored or a xenstore-stubdom to be > + * started, then probe. It will be triggered when communication > + * starts happening, by waiting on xb_waitq. > */ > - if (xen_store_domain_type == XS_LOCAL) { > + if (xen_store_domain_type == XS_LOCAL || xen_store_interface == NULL) { > struct task_struct *probe_task; > > probe_task = kthread_run(xenbus_probe_thread, NULL, > @@ -907,10 +924,25 @@ static struct notifier_block xenbus_resume_nb = { > .notifier_call = xenbus_resume_cb, > }; > > +static irqreturn_t xenbus_late_init(int irq, void *unused) > +{ > + int err = 0; No need to set up initial value as it is being reassigned without using the initial value. > + uint64_t v = 0; > + > + err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v); > + if (err || !v || !~v) > + return IRQ_HANDLED; > + xen_store_gfn = (unsigned long)v; > + > + wake_up(&xb_waitq); > + return IRQ_HANDLED; > +} > + > static int __init xenbus_init(void) > { > int err; > uint64_t v = 0; > + bool wait = false; > xen_store_domain_type = XS_UNKNOWN; > > if (!xen_domain()) > @@ -957,25 +989,44 @@ static int __init xenbus_init(void) > * been properly initialized. Instead of attempting to map a > * wrong guest physical address return error. > * > - * Also recognize all bits set as an invalid value. > + * Also recognize all bits set as an invalid/uninitialized value. > */ > - if (!v || !~v) { > + if (!v) { > err = -ENOENT; > goto out_error; > } > - /* Avoid truncation on 32-bit. */ > + if (v == ~0ULL) { No need for brackets for a single instruction. > + wait = true; > + } else { > + /* Avoid truncation on 32-bit. */ > #if BITS_PER_LONG == 32 > - if (v > ULONG_MAX) { > - pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", > - __func__, v); > - err = -EINVAL; > - goto out_error; > - } > + if (v > ULONG_MAX) { > + pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", > + __func__, v); __func shall be aligned with "%s... as it was before. > + err = -EINVAL; > + goto out_error; > + } > #endif > - xen_store_gfn = (unsigned long)v; > - xen_store_interface = > - xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, > - XEN_PAGE_SIZE); > + xen_store_gfn = (unsigned long)v; > + xen_store_interface = > + xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, > + XEN_PAGE_SIZE); > + if (xen_store_interface->connection != XENSTORE_CONNECTED) > + wait = true; > + } > + if (wait) { > + err = bind_evtchn_to_irqhandler(xen_store_evtchn, > + xenbus_late_init, > + 0, "xenstore_late_init", > + &xb_waitq); > + if (err < 0) { > + pr_err("xenstore_late_init couldn't bind irq err=%d\n", > + err); > + return err; > + } > + > + xs_init_irq = err; > + } > break; > default: > pr_warn("Xenstore state unknown\n"); Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu May 05 12:29:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322096.543295 (Exim 4.92) (envelope-from ) id 1nmacG-0005wC-GY; Thu, 05 May 2022 12:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322096.543295; Thu, 05 May 2022 12:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmacG-0005w5-Dq; Thu, 05 May 2022 12:29:56 +0000 Received: by outflank-mailman (input) for mailman id 322096; Thu, 05 May 2022 12:29:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmacF-0005vx-LC for xen-devel@lists.xenproject.org; Thu, 05 May 2022 12:29:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e97b601-cc6f-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 14:29:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 90D9B1F8BD; Thu, 5 May 2022 12:29:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5BED713A65; Thu, 5 May 2022 12:29:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aMsBFUHDc2KuAgAAMHmgww (envelope-from ); Thu, 05 May 2022 12:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e97b601-cc6f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651753793; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9vamwImk0t8OduVCZ2cH+IuqWspf5M+PUNeFEMyLaNI=; b=KydLLjdUXc+bdEOB98vmTITOIaYqH1torezgvR9N8HhPKldrE2xJAlXyYw4Vn+ejFmWcfe QIqq3qq9u2elAAvHFgopQCorTj2gZtKsjkN19+le/RzRp/SphVyaXuEg7BcyHZAO8751S5 DvPR9yODj79FHHJD8NhCtiGyVqWEZqk= Message-ID: Date: Thu, 5 May 2022 14:29:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Michal Orzel , Stefano Stabellini , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini References: <20220505002304.401417-2-sstabellini@kernel.org> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------37AFpT5JzY4QS3SQBqr09ro7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------37AFpT5JzY4QS3SQBqr09ro7 Content-Type: multipart/mixed; boundary="------------sxuqtKRsG1hv02k5Rl6BxGyf"; protected-headers="v1" From: Juergen Gross To: Michal Orzel , Stefano Stabellini , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini Message-ID: Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain References: <20220505002304.401417-2-sstabellini@kernel.org> In-Reply-To: --------------sxuqtKRsG1hv02k5Rl6BxGyf Content-Type: multipart/mixed; boundary="------------zI0C7aImK9MvIQ74H35QFogn" --------------zI0C7aImK9MvIQ74H35QFogn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDUuMjIgMTQ6MjYsIE1pY2hhbCBPcnplbCB3cm90ZToNCj4gSGkgTHVjYSwNCj4g DQo+IE9uIDA1LjA1LjIwMjIgMDI6MjMsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+ IEZyb206IEx1Y2EgTWljY2lvIDxsdWNtaWNjaW9AZ21haWwuY29tPg0KPj4NCj4+IFdoZW4g cnVubmluZyBhcyBkb20wbGVzcyBndWVzdCAoSFZNIGRvbWFpbiBvbiBBUk0pIHRoZSB4ZW5z dG9yZSBldmVudA0KPj4gY2hhbm5lbCBpcyBhdmFpbGFibGUgYXQgZG9tYWluIGNyZWF0aW9u IGJ1dCB0aGUgc2hhcmVkIHhlbnN0b3JlDQo+PiBpbnRlcmZhY2UgcGFnZSBvbmx5IGJlY29t ZXMgYXZhaWxhYmxlIGxhdGVyIG9uLg0KPj4NCj4+IEluIHRoYXQgY2FzZSwgd2FpdCBmb3Ig YSBub3RpZmljYXRpb24gb24gdGhlIHhlbnN0b3JlIGV2ZW50IGNoYW5uZWwsDQo+PiB0aGVu IGNvbXBsZXRlIHRoZSB4ZW5zdG9yZSBpbml0aWFsaXphdGlvbiBsYXRlciwgd2hlbiB0aGUg c2hhcmVkIHBhZ2UNCj4+IGlzIGFjdHVhbGx5IGF2YWlsYWJsZS4NCj4+DQo+PiBUaGUgeGVu c3RvcmUgcGFnZSBoYXMgZmV3IGV4dHJhIGZpZWxkLiBBZGQgdGhlbSB0byB0aGUgc2hhcmVk IHN0cnVjdC4NCj4+IE9uZSBvZiB0aGUgZmllbGQgaXMgImNvbm5lY3Rpb24iLCB3aGVuIHRo ZSBjb25uZWN0aW9uIGlzIHJlYWR5LCBpdCBpcw0KPj4gemVyby4gSWYgdGhlIGNvbm5lY3Rp b24gaXMgbm90LXplcm8sIHdhaXQgZm9yIGEgbm90aWZpY2F0aW9uLg0KPj4NCj4+IFNpZ25l ZC1vZmYtYnk6IEx1Y2EgTWljY2lvIDxsdWNtaWNjaW9AZ21haWwuY29tPg0KPj4gU2lnbmVk LW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54 LmNvbT4NCj4+IC0tLQ0KPj4gQ2hhbmdlcyBpbiB2NDoNCj4+IC0gaW1wcm92ZSBpbi1jb2Rl IGNvbW1lbnRzDQo+PiAtIG1vdmUgaGVhZGVyIHN5bmMgdG8gc2VwYXJhdGUgcGF0Y2gNCj4+ IC0gdXNlIFhFTlNUT1JFX0NPTk5FQ1RFRA0KPj4NCj4+IENoYW5nZXMgaW4gdjM6DQo+PiAt IGNoZWNrIGZvciB0aGUgY29ubmVjdGlvbiBmaWVsZCwgaWYgaXQgaXMgbm90IHplcm8sIHdh aXQgZm9yIGV2ZW50DQo+Pg0KPj4gQ2hhbmdlcyBpbiB2MjoNCj4+IC0gcmVtb3ZlIFhFTkZF QVRfeGVuc3RvcmVfbGF0ZV9pbml0DQo+PiAtLS0NCj4+ICAgZHJpdmVycy94ZW4veGVuYnVz L3hlbmJ1c19wcm9iZS5jIHwgOTEgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQ0K Pj4gICAxIGZpbGUgY2hhbmdlZCwgNzEgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0p DQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUu YyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYw0KPj4gaW5kZXggZmUzNjBj MzNjZTcxLi4wYTc4NWQ1ZTNlNDAgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi94ZW5i dXMveGVuYnVzX3Byb2JlLmMNCj4+ICsrKyBiL2RyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNf cHJvYmUuYw0KPj4gQEAgLTY1LDYgKzY1LDcgQEANCj4+ICAgI2luY2x1ZGUgInhlbmJ1cy5o Ig0KPj4gICANCj4+ICAgDQo+PiArc3RhdGljIGludCB4c19pbml0X2lycTsNCj4+ICAgaW50 IHhlbl9zdG9yZV9ldnRjaG47DQo+PiAgIEVYUE9SVF9TWU1CT0xfR1BMKHhlbl9zdG9yZV9l dnRjaG4pOw0KPj4gICANCj4+IEBAIC03NTAsNiArNzUxLDIwIEBAIHN0YXRpYyB2b2lkIHhl bmJ1c19wcm9iZSh2b2lkKQ0KPj4gICB7DQo+PiAgIAl4ZW5zdG9yZWRfcmVhZHkgPSAxOw0K Pj4gICANCj4+ICsJaWYgKCF4ZW5fc3RvcmVfaW50ZXJmYWNlKSB7DQo+PiArCQl4ZW5fc3Rv cmVfaW50ZXJmYWNlID0geGVuX3JlbWFwKHhlbl9zdG9yZV9nZm4gPDwgWEVOX1BBR0VfU0hJ RlQsDQo+PiArCQkJCQkJWEVOX1BBR0VfU0laRSk7DQo+PiArCQkvKg0KPj4gKwkJICogTm93 IGl0IGlzIHNhZmUgdG8gZnJlZSB0aGUgSVJRIHVzZWQgZm9yIHhlbnN0b3JlIGxhdGUNCj4+ ICsJCSAqIGluaXRpYWxpemF0aW9uLiBObyBuZWVkIHRvIHVuYmluZDogaXQgaXMgYWJvdXQg dG8gYmUNCj4+ICsJCSAqIGJvdW5kIGFnYWluIGZyb20geGJfaW5pdF9jb21tcy4gTm90ZSB0 aGF0IGNhbGxpbmcNCj4+ICsJCSAqIHVuYmluZF9mcm9tX2lycWhhbmRsZXIgbm93IHdvdWxk IHJlc3VsdCBpbiB4ZW5fZXZ0Y2huX2Nsb3NlKCkNCj4+ICsJCSAqIGJlaW5nIGNhbGxlZCBh bmQgdGhlIGV2ZW50IGNoYW5uZWwgbm90IGJlaW5nIGVuYWJsZWQgYWdhaW4NCj4+ICsJCSAq IGFmdGVyd2FyZHMsIHJlc3VsdGluZyBpbiBtaXNzZWQgZXZlbnQgbm90aWZpY2F0aW9ucy4N Cj4+ICsJCSAqLw0KPj4gKwkJZnJlZV9pcnEoeHNfaW5pdF9pcnEsICZ4Yl93YWl0cSk7DQo+ PiArCX0NCj4+ICsNCj4+ICAgCS8qDQo+PiAgIAkgKiBJbiB0aGUgSFZNIGNhc2UsIHhlbmJ1 c19pbml0KCkgZGVmZXJyZWQgaXRzIGNhbGwgdG8NCj4+ICAgCSAqIHhzX2luaXQoKSBpbiBj YXNlIGNhbGxiYWNrcyB3ZXJlIG5vdCBvcGVyYXRpb25hbCB5ZXQuDQo+PiBAQCAtNzk4LDIw ICs4MTMsMjIgQEAgc3RhdGljIGludCBfX2luaXQgeGVuYnVzX3Byb2JlX2luaXRjYWxsKHZv aWQpDQo+PiAgIHsNCj4+ICAgCS8qDQo+PiAgIAkgKiBQcm9iZSBYZW5CdXMgaGVyZSBpbiB0 aGUgWFNfUFYgY2FzZSwgYW5kIGFsc28gWFNfSFZNIHVubGVzcyB3ZQ0KPj4gLQkgKiBuZWVk IHRvIHdhaXQgZm9yIHRoZSBwbGF0Zm9ybSBQQ0kgZGV2aWNlIHRvIGNvbWUgdXAuDQo+PiAr CSAqIG5lZWQgdG8gd2FpdCBmb3IgdGhlIHBsYXRmb3JtIFBDSSBkZXZpY2UgdG8gY29tZSB1 cCBvcg0KPj4gKwkgKiB4ZW5fc3RvcmVfaW50ZXJmYWNlIGlzIG5vdCByZWFkeS4NCj4+ICAg CSAqLw0KPj4gICAJaWYgKHhlbl9zdG9yZV9kb21haW5fdHlwZSA9PSBYU19QViB8fA0KPj4g ICAJICAgICh4ZW5fc3RvcmVfZG9tYWluX3R5cGUgPT0gWFNfSFZNICYmDQo+PiAtCSAgICAg IXhzX2h2bV9kZWZlcl9pbml0X2Zvcl9jYWxsYmFjaygpKSkNCj4+ICsJICAgICAheHNfaHZt X2RlZmVyX2luaXRfZm9yX2NhbGxiYWNrKCkgJiYNCj4+ICsJICAgICB4ZW5fc3RvcmVfaW50 ZXJmYWNlICE9IE5VTEwpKQ0KPj4gICAJCXhlbmJ1c19wcm9iZSgpOw0KPj4gICANCj4+ICAg CS8qDQo+PiAtCSAqIEZvciBYU19MT0NBTCwgc3Bhd24gYSB0aHJlYWQgd2hpY2ggd2lsbCB3 YWl0IGZvciB4ZW5zdG9yZWQNCj4+IC0JICogb3IgYSB4ZW5zdG9yZS1zdHViZG9tIHRvIGJl IHN0YXJ0ZWQsIHRoZW4gcHJvYmUuIEl0IHdpbGwgYmUNCj4+IC0JICogdHJpZ2dlcmVkIHdo ZW4gY29tbXVuaWNhdGlvbiBzdGFydHMgaGFwcGVuaW5nLCBieSB3YWl0aW5nDQo+PiAtCSAq IG9uIHhiX3dhaXRxLg0KPj4gKwkgKiBGb3IgWFNfTE9DQUwgb3Igd2hlbiB4ZW5fc3RvcmVf aW50ZXJmYWNlIGlzIG5vdCByZWFkeSwgc3Bhd24gYQ0KPj4gKwkgKiB0aHJlYWQgd2hpY2gg d2lsbCB3YWl0IGZvciB4ZW5zdG9yZWQgb3IgYSB4ZW5zdG9yZS1zdHViZG9tIHRvIGJlDQo+ PiArCSAqIHN0YXJ0ZWQsIHRoZW4gcHJvYmUuICBJdCB3aWxsIGJlIHRyaWdnZXJlZCB3aGVu IGNvbW11bmljYXRpb24NCj4+ICsJICogc3RhcnRzIGhhcHBlbmluZywgYnkgd2FpdGluZyBv biB4Yl93YWl0cS4NCj4+ICAgCSAqLw0KPj4gLQlpZiAoeGVuX3N0b3JlX2RvbWFpbl90eXBl ID09IFhTX0xPQ0FMKSB7DQo+PiArCWlmICh4ZW5fc3RvcmVfZG9tYWluX3R5cGUgPT0gWFNf TE9DQUwgfHwgeGVuX3N0b3JlX2ludGVyZmFjZSA9PSBOVUxMKSB7DQo+PiAgIAkJc3RydWN0 IHRhc2tfc3RydWN0ICpwcm9iZV90YXNrOw0KPj4gICANCj4+ICAgCQlwcm9iZV90YXNrID0g a3RocmVhZF9ydW4oeGVuYnVzX3Byb2JlX3RocmVhZCwgTlVMTCwNCj4+IEBAIC05MDcsMTAg KzkyNCwyNSBAQCBzdGF0aWMgc3RydWN0IG5vdGlmaWVyX2Jsb2NrIHhlbmJ1c19yZXN1bWVf bmIgPSB7DQo+PiAgIAkubm90aWZpZXJfY2FsbCA9IHhlbmJ1c19yZXN1bWVfY2IsDQo+PiAg IH07DQo+PiAgIA0KPj4gK3N0YXRpYyBpcnFyZXR1cm5fdCB4ZW5idXNfbGF0ZV9pbml0KGlu dCBpcnEsIHZvaWQgKnVudXNlZCkNCj4+ICt7DQo+PiArCWludCBlcnIgPSAwOw0KPiBObyBu ZWVkIHRvIHNldCB1cCBpbml0aWFsIHZhbHVlIGFzIGl0IGlzIGJlaW5nIHJlYXNzaWduZWQg d2l0aG91dCB1c2luZyB0aGUgaW5pdGlhbCB2YWx1ZS4NCj4gDQo+PiArCXVpbnQ2NF90IHYg PSAwOw0KPj4gKw0KPj4gKwllcnIgPSBodm1fZ2V0X3BhcmFtZXRlcihIVk1fUEFSQU1fU1RP UkVfUEZOLCAmdik7DQo+PiArCWlmIChlcnIgfHwgIXYgfHwgIX52KQ0KPj4gKwkJcmV0dXJu IElSUV9IQU5ETEVEOw0KPj4gKwl4ZW5fc3RvcmVfZ2ZuID0gKHVuc2lnbmVkIGxvbmcpdjsN Cj4+ICsNCj4+ICsJd2FrZV91cCgmeGJfd2FpdHEpOw0KPj4gKwlyZXR1cm4gSVJRX0hBTkRM RUQ7DQo+PiArfQ0KPj4gKw0KPj4gICBzdGF0aWMgaW50IF9faW5pdCB4ZW5idXNfaW5pdCh2 b2lkKQ0KPj4gICB7DQo+PiAgIAlpbnQgZXJyOw0KPj4gICAJdWludDY0X3QgdiA9IDA7DQo+ PiArCWJvb2wgd2FpdCA9IGZhbHNlOw0KPj4gICAJeGVuX3N0b3JlX2RvbWFpbl90eXBlID0g WFNfVU5LTk9XTjsNCj4+ICAgDQo+PiAgIAlpZiAoIXhlbl9kb21haW4oKSkNCj4+IEBAIC05 NTcsMjUgKzk4OSw0NCBAQCBzdGF0aWMgaW50IF9faW5pdCB4ZW5idXNfaW5pdCh2b2lkKQ0K Pj4gICAJCSAqIGJlZW4gcHJvcGVybHkgaW5pdGlhbGl6ZWQuIEluc3RlYWQgb2YgYXR0ZW1w dGluZyB0byBtYXAgYQ0KPj4gICAJCSAqIHdyb25nIGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mg cmV0dXJuIGVycm9yLg0KPj4gICAJCSAqDQo+PiAtCQkgKiBBbHNvIHJlY29nbml6ZSBhbGwg Yml0cyBzZXQgYXMgYW4gaW52YWxpZCB2YWx1ZS4NCj4+ICsJCSAqIEFsc28gcmVjb2duaXpl IGFsbCBiaXRzIHNldCBhcyBhbiBpbnZhbGlkL3VuaW5pdGlhbGl6ZWQgdmFsdWUuDQo+PiAg IAkJICovDQo+PiAtCQlpZiAoIXYgfHwgIX52KSB7DQo+PiArCQlpZiAoIXYpIHsNCj4+ICAg CQkJZXJyID0gLUVOT0VOVDsNCj4+ICAgCQkJZ290byBvdXRfZXJyb3I7DQo+PiAgIAkJfQ0K Pj4gLQkJLyogQXZvaWQgdHJ1bmNhdGlvbiBvbiAzMi1iaXQuICovDQo+PiArCQlpZiAodiA9 PSB+MFVMTCkgew0KPiBObyBuZWVkIGZvciBicmFja2V0cyBmb3IgYSBzaW5nbGUgaW5zdHJ1 Y3Rpb24uDQoNClRoZSBjb2Rpbmcgc3R5bGUgc2F5cyBvdGhlcndpc2U6DQoNCiAgIFRoaXMg ZG9lcyBub3QgYXBwbHkgaWYgb25seSBvbmUgYnJhbmNoIG9mIGEgY29uZGl0aW9uYWwgc3Rh dGVtZW50IGlzIGEgc2luZ2xlDQogICBzdGF0ZW1lbnQ7IGluIHRoZSBsYXR0ZXIgY2FzZSB1 c2UgYnJhY2VzIGluIGJvdGggYnJhbmNoZXM6DQoNCiAgIC4uIGNvZGUtYmxvY2s6OiBjDQoN CiAgICAgICAgIGlmIChjb25kaXRpb24pIHsNCiAgICAgICAgICAgICAgICAgZG9fdGhpcygp Ow0KICAgICAgICAgICAgICAgICBkb190aGF0KCk7DQogICAgICAgICB9IGVsc2Ugew0KICAg ICAgICAgICAgICAgICBvdGhlcndpc2UoKTsNCiAgICAgICAgIH0NCg0KDQpKdWVyZ2VuDQo= --------------zI0C7aImK9MvIQ74H35QFogn Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------zI0C7aImK9MvIQ74H35QFogn-- --------------sxuqtKRsG1hv02k5Rl6BxGyf-- --------------37AFpT5JzY4QS3SQBqr09ro7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJzw0AFAwAAAAAACgkQsN6d1ii/Ey9/ 8Af+KFHWc8MW9qDR1heCY0rrSOwDTk2yMGiFmXInyCjHBAXj5PhbgY593/7IlPpK0k4LGJfoKRID a1MOFVSNsIv1GZkIdReEgcTBHmn432bI12ZiYFlcQomE80EXBgBxrJFdD+e4qhslqohm55CUTC5U XIR+h+4hjNKU+4S8Xhb1LU5VDck9ckMqHKyWBEEN1WA5p3cuPlOSVD+KywdxEVYf9Ab/ksZTMIGk mBFr25EOQWhHxTnDWyN+2QSlyBcnqO8eKD7dOnl4hUBGiVWbiEBlxOGdZcdmc2kgHiWWdc5hLnsx 4gRwIfa8e9vJ7uXCly6o530Xcw4uqJDmb0uoaZha1Q== =D/Fk -----END PGP SIGNATURE----- --------------37AFpT5JzY4QS3SQBqr09ro7-- From xen-devel-bounces@lists.xenproject.org Thu May 05 12:36:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:36:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322103.543306 (Exim 4.92) (envelope-from ) id 1nmaid-0007N3-8b; Thu, 05 May 2022 12:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322103.543306; Thu, 05 May 2022 12:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaid-0007Mw-4V; Thu, 05 May 2022 12:36:31 +0000 Received: by outflank-mailman (input) for mailman id 322103; Thu, 05 May 2022 12:36:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmaic-0007Mq-GZ for xen-devel@lists.xenproject.org; Thu, 05 May 2022 12:36:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id ec2723ab-cc6f-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 14:36:25 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24CC5106F; Thu, 5 May 2022 05:36:05 -0700 (PDT) Received: from [10.57.3.137] (unknown [10.57.3.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B86543F885; Thu, 5 May 2022 05:36:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec2723ab-cc6f-11ec-8fc4-03012f2f19d4 Message-ID: <5f7e5a83-0944-8464-564a-51d7a4d19c55@arm.com> Date: Thu, 5 May 2022 14:35:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Juergen Gross , Stefano Stabellini , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini References: <20220505002304.401417-2-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 05.05.2022 14:29, Juergen Gross wrote: >>> -        /* Avoid truncation on 32-bit. */ >>> +        if (v == ~0ULL) { >> No need for brackets for a single instruction. > > The coding style says otherwise: > >   This does not apply if only one branch of a conditional statement is a single >   statement; in the latter case use braces in both branches: > >   .. code-block:: c > >         if (condition) { >                 do_this(); >                 do_that(); >         } else { >                 otherwise(); >         } > > Good to know. So Luca, you can omit this comment. > Juergen Cheers, Michal From xen-devel-bounces@lists.xenproject.org Thu May 05 12:48:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 12:48:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322114.543317 (Exim 4.92) (envelope-from ) id 1nmauI-0000RH-8f; Thu, 05 May 2022 12:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322114.543317; Thu, 05 May 2022 12:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmauI-0000RA-5l; Thu, 05 May 2022 12:48:34 +0000 Received: by outflank-mailman (input) for mailman id 322114; Thu, 05 May 2022 12:48:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmauG-0000R0-FX; Thu, 05 May 2022 12:48:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmauG-000600-8S; Thu, 05 May 2022 12:48:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmauF-0005Zy-TD; Thu, 05 May 2022 12:48:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmauF-0006g6-Sl; Thu, 05 May 2022 12:48:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=49eR9ED0hRzpg9HKN9qpihkuVjx5tnZofuWqUkmectI=; b=BvzmUBJsp0OC/0jS/LtHGW24ds 9KoGMv6sIQhJANYDSvQLPu6Er0cY3ycv0jawCysJBQYDGoC7RtNbUhEfNMhJgLXnVJmjNvpkJgf7A qfnAEhSPcCBY8etQJKP31xD5JGS6gS7b7MaQTXMyo3s3ChywaQsPOLrXDXopULAw06uk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170148: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 12:48:31 +0000 flight 170148 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 820 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 44 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 13:20:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 13:20:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322125.543328 (Exim 4.92) (envelope-from ) id 1nmbPN-0004SR-RM; Thu, 05 May 2022 13:20:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322125.543328; Thu, 05 May 2022 13:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbPN-0004SK-OI; Thu, 05 May 2022 13:20:41 +0000 Received: by outflank-mailman (input) for mailman id 322125; Thu, 05 May 2022 13:20:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbPL-0004SE-Kq for xen-devel@lists.xenproject.org; Thu, 05 May 2022 13:20:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25b2c983-cc76-11ec-a406-831a346695d4; Thu, 05 May 2022 15:20:37 +0200 (CEST) Received: from mail-bn8nam08lp2046.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 09:20:03 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2973.namprd03.prod.outlook.com (2603:10b6:300:11d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 13:20:01 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 13:20:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25b2c983-cc76-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651756837; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=JKLRraHfvav+WJnxq7ne1MwcmnXBreSib1heG5ceGCk=; b=PIQlHwChMuT9XyX31N1DE6+fgW425gLfjQrUy+eGmRHrpL+V0Iy+kbB4 yc9JNankKv8qawrU1tGhxAjPk5xqkHEAQxwlZPB338xPXYL/qgQAW05BB CW1K5O5oa/vd4pxIhXnjhUZrlB5Cxqvtk71Eyn4DUsx92x+rLHE53YHZg A=; X-IronPort-RemoteIP: 104.47.74.46 X-IronPort-MID: 70523173 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aSMsP6Bt1IlURhVW/1/iw5YqxClBgxIJ4kV8jS/XYbTApDwrgzMAm GQZCmjTO6yOZWvzfNt2b9y3p0hV7MDTn9BqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh39Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh0k epw6cexaT1zEZTigvombStxAzFHaPguFL/veRBTsOS15mieLz7G5aUrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l6B8ydK0nJzYYwMDMYnMdBEOyYf 8MEQTFucA7Bc1tEPVJ/5JcWw7/13CKmLGYwRFS9nYUswTHc9RJLwObvLufHftOGeeFapxPNz o7B1yGjav0AD/SdwzeY9nOnhsfUgDj2HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI FBS/TAhxYAq/VGvZsnwWVu/unHsg/IHc99ZEul/4gfdzKPRu1adHjJcEmAHb8E6vsgrQzBsz kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkiWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:G+2QX6/36DsjiNyVTE5uk+FKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81nOdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbkidzk7hdcAoqJ/lp X525RT5c9zp/AtHNJA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="70523173" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PpSIBrpt8jp1OZgADYFB5nXwixEOmqw86KvzpVrUS1V7wW6pBn6kUe2k0lbtDof4FdrFQUPV1Ef9EuMhKdTlf4eDQnXzc/94xmi+YPWdXOvbThgFoD252hYbKg0bb/ZhZCMeoSd3EpwN3U4rrLHa78Wnr7Q79ciP+toxkkOb7fE1gxL3E8KsluUZU+mQ4RWDrRKg6r3bJGoOVnLE+9y6SYwoTXULEh6296nfS0se8FaPBUS/5KWsMqDTFqDqH+TQehJf4xwJ9qiNY1geY4I/Ab2RMzEHkyl/6fX1t7ni0EtPIbf4TZeW5Y38H+mDKlkHcBpVCcysloyHubBkbO6jNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M5hHCjWk86eXh5ysv1fYYsjEaFY1oeuhyXEOTXkQ07o=; b=X9DIRa6Uz63RSYWCrh3HVJzg/WWgOr0AxKt9GCcSOSa1mnHwoqT0q9NeEKjjvuEX0IoXHAuX/UZwU3qbPgZS5uIssCfqC9gcpAywaoyHYilTapIo1m5QX0YBujLVOuEraGeFq2I8CB6VOxfOMqlAOGdekilaeNJxqkSkV/RN5AiGOmKMhg9gQlnzmBz2RN57eVvBqeIcnBMhllnHWnnFUVxnzTS0/efRTxBUnE1qX9dD8kylr6lQ8Ru8UCY6VZV1nzjQ1ukQM5Qns9lasJ/zT9RjKHmdEii6NodgjCqjqFKtrYCvc8y5a05J2l8PTnK7ECl1sHuSI8UzX614HyEJEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M5hHCjWk86eXh5ysv1fYYsjEaFY1oeuhyXEOTXkQ07o=; b=SsSDYwy1oTbBnO1mOTjaPXyvGDHp1hEJxIPHpZIo15eakWYmyfPKvdz3xtBzFmGE3Cmb98KxkPCtewQ/D71AHG3xGfvcZq0mOUNAdnzUOoa92gO8MrHEkFXu7TE1Wnm8vqCV/zPiYBtWma3X5n1jJOb+uMuE+gL9SK7pAX7OGAE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 15:19:56 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings Message-ID: References: <5866e22e-9f31-84ab-1df9-db84aa802944@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5866e22e-9f31-84ab-1df9-db84aa802944@suse.com> X-ClientProxiedBy: LO4P123CA0412.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca2876bf-af9c-4a0e-e4b4-08da2e99f555 X-MS-TrafficTypeDiagnostic: MWHPR03MB2973:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cA8s76bgwdN9yCyXzWTi5l216iq62BbMIv27OPNymY6RJ3petyeHXw6kuM5z4+M+8WRTy0G6ASz+W/TPsMUoffqAN7lsIztZmTCBeXVmNN5x+58oM9Ttcm/JNdo/p6ak0TQg4ZbyNlxPGtcDdBo+kAQSFBJAhjP/PBxl1BCE2Z2UB9G4IA298+JNtOF83YRu5WXNbqeIQZ2uKQUfCHuCI+NcmKeuRBNmPg7CPc2dVLfsEldEE2u25yT1SDuYwe97M6K2LHPztLzbOb4mwBRcDp0un9ARkMYlU9f0aGXE5zDYsLOb7EqxH8970G4biJDWiPd0+5VsGxpnd1w2aybUMArgA221CPp+QJqzuVeq6+UUfe3sO87u/+fuIkSyVABgY0yee0JgWVixjAk35/Ff0ohaK8w2bYVVxdLl5ep4KVMpTAJEz3vfPi/ePsDTssoO8UuKuu4ntgHxYBjOokQeDbzhigAqpP/j0k4ZoisblglZD1eTOE2akCZxTZBnqWaiIIFFJx9r4tZggssh3Wov+K6M6A+Nm7mL0f77fyQPnwyMopSoIn3KA+a6ImIoRrcUnaD4nqbr3u1aSYyoaiZUnMwIptlHYkLx8SqwMNWLjL/YrsP/mTw1FAFeOUE0VkkeagoMsxT/FHqNDfo45JF0ug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(66946007)(66556008)(85182001)(8676002)(508600001)(6506007)(66476007)(83380400001)(54906003)(86362001)(9686003)(6512007)(5660300002)(6916009)(186003)(8936002)(2906002)(316002)(82960400001)(6666004)(6486002)(33716001)(38100700002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N25qc3FqR0pwRCtoWVRXY0VCSTVxYnZCUC9XclNqT1ZFMjlGdklNRU9qQ05O?= =?utf-8?B?cko3TkNuWk5HdjNPbWNRMXAxRGRjZnNWb3NDRk1NNThuOFdJL1dyc29TeW15?= =?utf-8?B?UHJyMkZpWEdONHdVT1A1Vndoc0V1YVBkSDFCZGpWS1ByM0p3Mk9aS0s3Sjk3?= =?utf-8?B?RXJ2M05UMG10UUZmYUhpWktXRVZUS1NVblFPc2tIUWVoUG1GZFR2aXR2YXd0?= =?utf-8?B?aVJhM3dEbTVlWE1qTkIxVGg5bzk3YnFQMUFMS2lkeG1tdUt1MndGWkcrSVkz?= =?utf-8?B?ZzBJc200bEVrd1NUaVNkN1dnS29yWmZmSnFQQkJsYVRQRFlwWEVhT1Y4ZGx1?= =?utf-8?B?Y1dpcTdZTkZvWGljN05yZytjUExOaTc2eWNMTHE5Q2FFR2IwOUdNN0FKZzdO?= =?utf-8?B?T21Fd3F0R0tTdmFkZk9QbFk0ZWNDMS9ZU05NWmp1L2JlemJmZmJzY2VKTEZQ?= =?utf-8?B?SGFkZ1ZiMm1JZGRUdk55dmM2bDZqVWNlc0krekN6UWpLVWVJc0tpWU5GSkdD?= =?utf-8?B?SjRqd1l6eFZrcmxRUUg1MVg4T2lqSmxjN3FPdk4vbDJqZTNFN1R5ZS9vdGc3?= =?utf-8?B?VWI1cFBmb3lkL2tOQW9ZTFFCcVFOcTE0WUZPMmtKUUd2cUVUd2ZCV3FHMW5K?= =?utf-8?B?RytrN0lkL0ZMMEpyRFZaVy9oYTdITUFpajRBOXlnZEY2bjlLTkhXK3oySXg3?= =?utf-8?B?UHZSZzR6Vi8ycytIaFMzcUZQRGRMQzZMNTBQWG4vL0xIUjhLeXh6elJLV09G?= =?utf-8?B?U09ib0pLWWF5bWMwVFNUMGJnVGVQQkNWc1BJaldJOWlTU2ZJNXpSaTFubXF6?= =?utf-8?B?UVpmNzFBTDcrOVBzOHRZdjNhdm9VTnl6bWlJZG9zakhSbVcxZ1JCVTRBVVlT?= =?utf-8?B?UVppRFE0WnpHWjlHT0g1T2psVWF2YUxDZnk5QUIvb0ZvYlZ1VmR3TjdrNVVq?= =?utf-8?B?R2tNZXJpNm1pdWpKZDZGMzNUYmF5M01pTGI1Y2JqZVl2Rm95cjNaM3J3a2xB?= =?utf-8?B?MVZOZjVlQnE1NGNmekdyQVdlOUNIUnkyVHh6bGJkenJZeCsyYVJqQ2lFWWx4?= =?utf-8?B?RE9MdjFlOG9qY2p3M0xpSkdTUjQwWm5WK1Z1Q2Y5TlppMDEyM0Z4Y2tCRE5R?= =?utf-8?B?dFlJWUlYOGwzR1VBZDEvTGlHRlAwZFdIZnVmM3NEN1RqU2diOEozY2NvOW5W?= =?utf-8?B?UllVTXlrTCtHUTE2anJVd1dqVm1pRTA2NDJENjQ1RFBtTHRtRHpYUThFTFBs?= =?utf-8?B?NzVpb2h5ZUN2My9xODB3cENiSDRFbnk1cXpwY2E2SkE0TW9ORVVUTXA4dXN6?= =?utf-8?B?djNtSDVtVHlNWEI0eFRiMDd1eFM2YWlhZE9xb2JmWDQ3Q0dGclBOSlM3VEJD?= =?utf-8?B?Wlc1VUlaWHZMSGkzREthMEI1emVFTXFzYlV5NXFqbkwzem9uckNIWlBvTWxl?= =?utf-8?B?OTN0dHpKRjlBWTd3UDViK2Z2SVg1UmNMWEZVdUgzdXdoanMzVHM0aXI1TTJC?= =?utf-8?B?dUJacVdvenVMRXQxTHZ3cU1KYnFldXRCK25oNU10V05id3JFcmdFQTNJUlJ2?= =?utf-8?B?bXpaNkp2UUdqbkMzN2pNU1V1KzVuWUc3Q1hUTm9KdFZaMmoyQXovOEVHRWNN?= =?utf-8?B?SG5XUUgza2oyUzFLbG5PNUhaaWlPM1FGZm5UbDl2eWxycmRHbVZjZXV2TVJS?= =?utf-8?B?cjRqVDNSMFNKV2lidWhuaHdRR09hVDlXd3FCV2o1dTFUNS9PZTQzKzFwUjZL?= =?utf-8?B?UFBmVkxQdnltS3MwU2VabVh6a3RmWGJ2elNrT2J2dzkrcWF2L1o4d2c5OGh4?= =?utf-8?B?bUc5eWNmL0VQSGFXbGkzVzZlYldKVHJOOC8zN0J3RnVOVjVnbUkwRG9iTkJY?= =?utf-8?B?eXZFZ05SdVVucUdRZy9pdFhmdXVsNTM0akYvM1VyRGZGTm1rV2xKcEdHL05Q?= =?utf-8?B?ZmRuOTZVejB0RXdLVm1iREdmMmdFaWxVWmd6ajN4QkUwaW9jQ3hGUFgxbEp2?= =?utf-8?B?M1V3MUpjazY3RXAwL2R2MXZITG43cGxaMmgyZHIyTHZxZGZLTmVHa3I4Nmxl?= =?utf-8?B?OC9CQllScnd6d1RadGVNVkVXdFE5cTBJTmhKMWlmUWgyWlJoRnMyeEdJZ0p4?= =?utf-8?B?anVESXh0TlVZcEF0TC82ZW9ZVjlmbWFEN0gwZldXcW9oOGFwaEJsZHdNY0Fs?= =?utf-8?B?eXRXekNnOXlvVDB2SnJGYzh4bTdGRkllSitVSnNhdS9SU2dJSTgwZFo2VUs0?= =?utf-8?B?M0JVTEw5REl5SmNUMHhyU0N5MnpQTWlVQlkvUml3dVMweTVPb0JGQVFDNW9U?= =?utf-8?B?bSt2SXlsZkdWS0JvRGpXbERLZ1haRUI1TENsMk15bFZwdXZpejYyRHRZek5W?= =?utf-8?Q?vXZHmwjAPo8OnOo8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca2876bf-af9c-4a0e-e4b4-08da2e99f555 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 13:20:01.0860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lxUd48crxTOHcu/H23fI1/HNCPZtsxkQkeSCrlHYfg0iUgiXdyn4VD1SFbFJ/v05MoK4Xcx4RzY+3HYgIPZEbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2973 On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: > No separate feature flags exist which would control availability of > these; the only restriction is HATS (establishing the maximum number of > page table levels in general), and even that has a lower bound of 4. > Thus we can unconditionally announce 2M, 1G, and 512G mappings. (Via > non-default page sizes the implementation in principle permits arbitrary > size mappings, but these require multiple identical leaf PTEs to be > written, which isn't all that different from having to write multiple > consecutive PTEs with increasing frame numbers. IMO that's therefore > beneficial only on hardware where suitable TLBs exist; I'm unaware of > such hardware.) > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > --- > I'm not fully sure about allowing 512G mappings: The scheduling-for- > freeing of intermediate page tables would take quite a while when > replacing a tree of 4k mappings by a single 512G one. Yet then again > there's no present code path via which 512G chunks of memory could be > allocated (and hence mapped) anyway, so this would only benefit huge > systems where 512 1G mappings could be re-coalesced (once suitable code > is in place) into a single L4 entry. And re-coalescing wouldn't result > in scheduling-for-freeing of full trees of lower level pagetables. I would think part of this should go into the commit message, as to why enabling 512G superpages is fine. > --- > v4: Change type of queue_free_pt()'s 1st parameter. Re-base. > v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks > where possible. > > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -32,12 +32,13 @@ static unsigned int pfn_to_pde_idx(unsig > } > > static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, > - unsigned long dfn) > + unsigned long dfn, > + unsigned int level) > { > union amd_iommu_pte *table, *pte, old; > > table = map_domain_page(_mfn(l1_mfn)); > - pte = &table[pfn_to_pde_idx(dfn, 1)]; > + pte = &table[pfn_to_pde_idx(dfn, level)]; > old = *pte; > > write_atomic(&pte->raw, 0); > @@ -351,11 +352,32 @@ static int iommu_pde_from_dfn(struct dom > return 0; > } > > +static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level) > +{ > + if ( level > 1 ) > + { > + union amd_iommu_pte *pt = map_domain_page(mfn); > + unsigned int i; > + > + for ( i = 0; i < PTE_PER_TABLE_SIZE; ++i ) > + if ( pt[i].pr && pt[i].next_level ) > + { > + ASSERT(pt[i].next_level < level); > + queue_free_pt(hd, _mfn(pt[i].mfn), pt[i].next_level); > + } > + > + unmap_domain_page(pt); > + } > + > + iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); > +} > + > int cf_check amd_iommu_map_page( > struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags, > unsigned int *flush_flags) > { > struct domain_iommu *hd = dom_iommu(d); > + unsigned int level = (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1; > int rc; > unsigned long pt_mfn = 0; > union amd_iommu_pte old; > @@ -384,7 +406,7 @@ int cf_check amd_iommu_map_page( > return rc; > } > I think it might be helpful to assert or otherwise check that the input order is supported by the IOMMU, just to be on the safe side. > - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, true) || > + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, true) || > !pt_mfn ) > { > spin_unlock(&hd->arch.mapping_lock); > @@ -394,8 +416,8 @@ int cf_check amd_iommu_map_page( > return -EFAULT; > } > > - /* Install 4k mapping */ > - old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), 1, > + /* Install mapping */ > + old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level, > (flags & IOMMUF_writable), > (flags & IOMMUF_readable)); > > @@ -403,8 +425,13 @@ int cf_check amd_iommu_map_page( > > *flush_flags |= IOMMU_FLUSHF_added; > if ( old.pr ) > + { > *flush_flags |= IOMMU_FLUSHF_modified; > > + if ( IOMMUF_order(flags) && old.next_level ) > + queue_free_pt(hd, _mfn(old.mfn), old.next_level); > + } > + > return 0; > } > > @@ -413,6 +440,7 @@ int cf_check amd_iommu_unmap_page( > { > unsigned long pt_mfn = 0; > struct domain_iommu *hd = dom_iommu(d); > + unsigned int level = (order / PTE_PER_TABLE_SHIFT) + 1; > union amd_iommu_pte old = {}; > > spin_lock(&hd->arch.mapping_lock); > @@ -423,7 +451,7 @@ int cf_check amd_iommu_unmap_page( > return 0; > } > > - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, false) ) > + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, false) ) > { > spin_unlock(&hd->arch.mapping_lock); > AMD_IOMMU_ERROR("invalid IO pagetable entry dfn = %"PRI_dfn"\n", > @@ -435,14 +463,19 @@ int cf_check amd_iommu_unmap_page( > if ( pt_mfn ) > { > /* Mark PTE as 'page not present'. */ > - old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn)); > + old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); > } > > spin_unlock(&hd->arch.mapping_lock); > > if ( old.pr ) > + { > *flush_flags |= IOMMU_FLUSHF_modified; > > + if ( order && old.next_level ) > + queue_free_pt(hd, _mfn(old.mfn), old.next_level); > + } > + > return 0; > } > > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -747,7 +747,7 @@ static void cf_check amd_dump_page_table > } > > static const struct iommu_ops __initconst_cf_clobber _iommu_ops = { > - .page_sizes = PAGE_SIZE_4K, > + .page_sizes = PAGE_SIZE_4K | PAGE_SIZE_2M | PAGE_SIZE_1G | PAGE_SIZE_512G, As mentioned on a previous email, I'm worried if we ever get to replace an entry populated with 4K pages with a 512G superpage, as the freeing cost of the associated pagetables would be quite high. I guess we will have to implement a more preemptive freeing behavior if issues arise. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 13:22:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 13:22:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322123.543339 (Exim 4.92) (envelope-from ) id 1nmbR3-000577-B5; Thu, 05 May 2022 13:22:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322123.543339; Thu, 05 May 2022 13:22:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbR3-000570-8J; Thu, 05 May 2022 13:22:25 +0000 Received: by outflank-mailman (input) for mailman id 322123; Thu, 05 May 2022 13:20:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbOp-0004RQ-Ka for xen-devel@lists.xenproject.org; Thu, 05 May 2022 13:20:07 +0000 Received: from sipsolutions.net (s3.sipsolutions.net [2a01:4f8:191:4433::2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13786756-cc76-11ec-a406-831a346695d4; Thu, 05 May 2022 15:20:06 +0200 (CEST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nmbLD-002nmQ-2E; Thu, 05 May 2022 15:16:23 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13786756-cc76-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=WOqM4DKEC8qEB5Nc8Asp0yMdSAPt0BrvJUl7fGL2K2o=; t=1651756805; x=1652966405; b=B+f5Dqyl+tBNOHpDd8nC90UQUBil9YUOmokZwjAdYtKsO5M iIiPMzOUUov8fdIgLszcX8m7i6MUgfcKa1nUPX/es4PYKc7nOVkLlvu1FpKZ0zS45bqXwbZO01ptU SOycYjNJgvbx1/ZyWlcqYmVykuf0Jjb26R4doi2wo4GfO7DtF9HXrcSaGOPntuyaw8y1yulWn9v2a V3OWAD8XHYG972i4l6ComutmODPHD0wShMJnyZolEmMT1pQG08ycPT7nsHFONzKWOdsrW4M6Kl0MX ImemQouQt2PmIQQnwSiZ6lwztjDvervfaQF5v4369djbrCgOLaPUVm6UaIuKDANQ==; Message-ID: <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers From: Johannes Berg To: Kees Cook Cc: "Gustavo A . R . Silva" , Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?ISO-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?ISO-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Date: Thu, 05 May 2022 15:16:19 +0200 In-Reply-To: <202205040819.DEA70BD@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned On Wed, 2022-05-04 at 08:38 -0700, Kees Cook wrote: > > It seemed like requiring a structure be rearranged to take advantage of > the "automatic layout introspection" wasn't very friendly. On the other > hand, looking at the examples, most of them are already neighboring > members. Hmmm. A lot of them are, and many could be, though not all. > > or so? The long and duplicated DECLARE_FLEX_ARRAY_ELEMENTS_COUNT and > > DECLARE_FLEX_ARRAY_ELEMENTS seems a bit tedious to me, at least in cases > > where the struct layout is not the most important thing (or it's already > > at the end anyway). > > The names aren't great, but I wanted to distinguish "elements" as the > array not the count. Yay naming. :-) > However, perhaps the solution is to have _both_. i.e using > BOUNDED_FLEX_ARRAY(count_type, count_name, array_type, array_name) for > the "neighboring" case, and the DECLARE...{ELEMENTS,COUNT} for the > "split" case. Seems reasonable to me. > And DECLARE_FLEX_ARRAY_ELEMENTS could actually be expanded to include > the count_name too, so both methods could be "forward portable" to a > future where C grew the syntax for bounded flex arrays. I guess I don't see that happening :) > > This seems rather awkward, having to set it to NULL, then checking rc > > (and possibly needing a separate variable for it), etc. > > I think the errno return is completely required. I had an earlier version > of this that was much more like a drop-in replacement for memcpy that > would just truncate or panic,  > Oh, I didn't mean to imply it should truncate or panic or such - but if it returns a pointer it can still be an ERR_PTR() or NULL instead of having this separate indication, which even often confuses static type checkers since they don't always see the "errno == 0 <=> ptr != NULL" relation. So not saying you shouldn't have any error return - clearly you need that, just saying that I'm not sure that having the two separated is great. > Requiring instance to be NULL is debatable, but I feel pretty strongly > about it because it does handle a class of mistakes (resource leaks), > and it's not much of a burden to require a known-good starting state. Yeah, dunno, I guess I'm slightly more on the side of not requiring it, since we don't do the same for kmalloc() etc. and probably really wouldn't want to add kmalloc_s() that does it ;-) I mean, you _could_ go there: int kmalloc_s(void **ptr, size_t size, gfp_t gfp) { void *ret; if (*ptr) return -EINVAL; ret = kmalloc(size, gfp); if (!ret) return -ENOMEM; *ptr = ret; return 0; } right? But we don't really do that, and I'm not sure it'd be a win if done over the whole code base. So I'm not really sure why this aspect here should need to be different, except of course that you already need the input argument for the magic. But we could still have (this prototype is theoretical, of course, it cannot be implemented in C): void *mem_to_flex_dup(void *ptr, const void *data, size_t elements, gfp_t gfp); which isn't really that much better though. And btw, while I was writing it down I was looking to see if it should be "size_t elements" or "size_t len" (like memcpy), it took me some time to figure out, and I was looking at the examples: 1) most of them actually use __u8 or some variant thereof, so you could probably add an even simpler macro like BOUNDED_FLEX_DATA(int, bytes, data) which has the u8 type internally. 2) Unless I'm confusing myself, you got the firewire change wrong, because __mem_to_flex_dup takes the "elements_count", but the memcpy() there wasn't multiplied by the sizeof(element)? Or maybe the fact that it was declared as __u32 header[0] is wrong, and it should be __u8, but it's all very confusing, and I'm really not sure about this at all. One "perhaps you'll laugh me out of the room" suggestion might be to actually be able to initialize the whole thing too? mydata = flex_struct_alloc(mydata, GFP_KERNEL, variable_data, variable_len, .member = 1, .another = 2); (the ordering can't really be otherwise since you have to use __VA_ARGS__). That might reduce some more code too, though I guess it's quite some additional magic ... :) > > but still, honestly, I don't like it. As APIs go, it feels a bit > > cumbersome and awkward to use, and you really need everyone to use this, > > and not say "uh what, I'll memcpy() instead". > > Sure, and I have tried to get it down as small as possible. The earlier > "just put all the member names in every call" version was horrid. :P :-D > I > realize it's more work to check errno, but the memcpy() API we've all > been trained to use is just plain dangerous. I don't think it's > unreasonable to ask people to retrain themselves to avoid it. All that > said, yes, I want it to be as friendly as possible. > > > Maybe there should also be a realloc() version of it? > > Sure! Seems reasonable. I'd like to see the code pattern for this > though. Do you have any examples? I was going to point to struct cfg80211_bss_ies, but I realize now they're RCU-managed, so we never resize them anyway ... So maybe it's less common than I thought it might be. I suppose you know better since you converted a lot of stuff already :-) johannes From xen-devel-bounces@lists.xenproject.org Thu May 05 13:36:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 13:36:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322140.543350 (Exim 4.92) (envelope-from ) id 1nmbej-0006e0-IG; Thu, 05 May 2022 13:36:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322140.543350; Thu, 05 May 2022 13:36:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbej-0006dt-F1; Thu, 05 May 2022 13:36:33 +0000 Received: by outflank-mailman (input) for mailman id 322140; Thu, 05 May 2022 13:36:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbeh-0006dj-U5; Thu, 05 May 2022 13:36:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbeh-00072I-SD; Thu, 05 May 2022 13:36:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbeh-0006bZ-DF; Thu, 05 May 2022 13:36:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmbeh-0004Mf-Cl; Thu, 05 May 2022 13:36:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9xMGT1tc5U4HzhX7MjaRDL3VkoUEuAvh7d16eg/vLxY=; b=DO6xmfXvJTVCZAIS5YhgSmXvTE Xrxl3OkN0MpAxLs73Hqt6yzX93nUtLeT+EMD7JNSBdXaK8SbuPSox1UUAcamPK4buFSY5eAvdIvOn S6VYacpYLo2/JbuhPqpMn5pRFrEj0J2NRcsMNgTduVxDdHywKWacbHqmZiYzJmabv3ls=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170149: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 13:36:31 +0000 flight 170149 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170149/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 821 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 45 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 13:45:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 13:45:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322149.543361 (Exim 4.92) (envelope-from ) id 1nmbmt-00084d-Ds; Thu, 05 May 2022 13:44:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322149.543361; Thu, 05 May 2022 13:44:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbmt-00084W-B5; Thu, 05 May 2022 13:44:59 +0000 Received: by outflank-mailman (input) for mailman id 322149; Thu, 05 May 2022 13:44:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbmr-000847-Mh for xen-devel@lists.xenproject.org; Thu, 05 May 2022 13:44:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20628.outbound.protection.outlook.com [2a01:111:f400:7d00::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89943608-cc79-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 15:44:51 +0200 (CEST) Received: from AM6P194CA0012.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::25) by AM5PR0801MB1905.eurprd08.prod.outlook.com (2603:10a6:203:43::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Thu, 5 May 2022 13:44:52 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::6e) by AM6P194CA0012.outlook.office365.com (2603:10a6:209:90::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Thu, 5 May 2022 13:44:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 13:44:51 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Thu, 05 May 2022 13:44:51 +0000 Received: from e87e99e6af7a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 436D0B5A-D641-46BE-ACE8-59ECCD6877CE.1; Thu, 05 May 2022 13:44:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e87e99e6af7a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 13:44:46 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by PAXPR08MB7035.eurprd08.prod.outlook.com (2603:10a6:102:207::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 13:44:43 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Thu, 5 May 2022 13:44:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89943608-cc79-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RVK/23gRDogmS0UajxkDoWi7Svkjw/bC/5AYyjymKm1zfwx1OLMNGJEO4SZXOg1SaxJoXxqIO+oC9mDiKC7KjAkk+djk5YahBSb11uWYuKcI+9Jwg9hO+rFyVAFER5iKWTjj8QyAZrgV28Q9Kibxg3mqi4mk93gmi+EjLyWDKFezC858NmTMkof7E2xTNjucEQOPxV7ydSOKfVXAXgFuJpeiDYATUkvMwDiRRJlfgZIU/y6QVqopM1iVVCAd1Ux1xtqItbsG4m1BACWOx9YJLxcDSUHun1ze1V1HTh/djWT6+oyEGB0PHnS4Emq7JxOnClHiBqEZX6sGaWnF6T8DkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30gKdXD5EI40lISPx9UXSUYITHyg6VythMuIYcJ6Qto=; b=dgrnz5I/i/6fWXC/Bk38L1n3rUOFTdv/8f7L+vCd0aCUhYoY9x7Xsyh+ePoXXOezo6PHDhrArfx6MrKEXl/5AX0+Z+lvnAYBjZ1u+59qxR3geHiWokCC/QHsEjZRDWeJeYo9bYqmnRxyb453GFh9PsVKztwRiZbfvdRNbXdXtlEHYj00Tj/+QHfrap9u05Nr1QkBmUMgdm8FJ/hX2tBPZgqigH5nnVn2oq4iFErPR4Tjl6XZdIMo7SgxBeckwBQ3MaFYScPtZFSiXSALBvoVvU4JGWE9kw0oIUJ6ju3yh/YqmImpFjvoyxHL4iMla32TRb6uwxNg5WbgXzYdsg+afg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30gKdXD5EI40lISPx9UXSUYITHyg6VythMuIYcJ6Qto=; b=HyU4elX5TxV+IoA3eulmv1DWxmrTFEf/T0GcCe2xeTm18+n8+EOtSwda24P9RrzKWY6HGBa+5YFRtYFO3yF/ENAnZ4Xt2VZpu99mq7EKNYe3MxzXwnQX4ldl/F/TW05tai2s1Crv8g71pozB7DL24RLJ4PZ20zOc67ZwQ9UPPw0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qawr8E5m9d5DzFs6D9LKhTYO/ckf8V/W7spP7lifsXhyWy7kU8/UG58xqiS8f0vEl6QtQjZMKDSkrL+hpVZZsAhFz/LyVLAlqhHvEx5OGQ7hq2FhX6VxJO4Z10kOwjhvK2np4emvQkxK90sbMCbx+IWHTRnzZltpQzxiRlZLOiE7tno/I92oZtc8kB9U7NV0Gi3z3Q2gdMFexO/Cl8TC/FP8hAajasmlUZdozpGK0I3TT2L2fjlZlriwylsx6UnyfGmbYyanu9fX+zbUsF+TTubAmVLfuV336R3bLc/2GSV4UVUklTVBpjBvPcJAraw5oGzBWWAWoUWYUqpqv0ZOPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30gKdXD5EI40lISPx9UXSUYITHyg6VythMuIYcJ6Qto=; b=ogWiE9FzhQy14xZDrE5A0Nv2fLjlLagM7wtJDxeQ2hof5x9sqO4wYYkbJJ7yZ+uayYCzim/xvn6a8dd+ecozY0K1LX/lMioA72VcQizcVTyFWoIKfkr0oY4A2KtoEPxlQPwyD0cJQt9NoS2/Nq2VlieYS5lralWtxIEw1RJDKyI2kYGhtSTBK7N7KVQo3ggUerz9zZBbvgeM523eEgfjSe1kMMLIn2gLx/mnJyQjwvDrTdhPhx/Ad61h+APSHX45/OgwGXycq/lW4RoHE7qwSpFTO6CWMgCzrFuCRzLGPAa85fp9vYSBzTPfFbd28qPYoZF4DVWmLAkZe64ENteXPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30gKdXD5EI40lISPx9UXSUYITHyg6VythMuIYcJ6Qto=; b=HyU4elX5TxV+IoA3eulmv1DWxmrTFEf/T0GcCe2xeTm18+n8+EOtSwda24P9RrzKWY6HGBa+5YFRtYFO3yF/ENAnZ4Xt2VZpu99mq7EKNYe3MxzXwnQX4ldl/F/TW05tai2s1Crv8g71pozB7DL24RLJ4PZ20zOc67ZwQ9UPPw0= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUIAAL5+AgAAR4BA= Date: Thu, 5 May 2022 13:44:42 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> In-Reply-To: <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F5543EAA1FF1E24CB3C4F53CC915BB4C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4db717ea-c20a-40ef-a575-08da2e9d6e1e x-ms-traffictypediagnostic: PAXPR08MB7035:EE_|VE1EUR03FT006:EE_|AM5PR0801MB1905:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ieAiGseEfScHXBZBQiRxmu5wOmRHR78qBge/7VULS7mH7SWpCuBgeqP+CRMQVXtW955bupzyulcHZtD5oIMuyFHh3q9x0katXHWodiBSpmWJgzZpKU+ehRoUJ+pviqGE9QWpBgyHfDj62N8iVrlCxDxvGSK7nyU3eGJiMqUflIFSU0O9TZZUAVB5bhgQcWzTB87ubkn1h2vEc8zH4WRVT8SnGB1nTSxGN9DwLNto5LUFGNDM38H8kCk7T3agHnYN18VuSgU7HzAGuS/lLY3IUaJhOjmWeHPXFVuNvqONsYwlVgz2Gx3EYM5IX19aAWSCVUKT1S295zPK9qkyW8UyKT943dG/qn+p3ro7IWVr+IT9juGDd5v7MINLEPlF7vMRtvn3Bkv3MDbQl2cQMxs2suSARHKdfLXzvbV6Za1Xong1f4xw20NLzXKsVqYSuTE6zL4VMJrK8RGLP/Gm7uWkbg2WbLuo1EPybZe4yBkdfTPZHwmztKkjwgP3xpr9ZhZAuowqVUSpXcykPtZyk+tthuklF1Hp203NqUz4bN7S3LC3cXHQ/LZZTdy5lK5RKX/gAct3hDsVBejk5ysltOOPaM7vTvxsxmrdQR16mKImxHIPrx2qAiDn0Hbb+/BY8/tu8XXGd3nddJQSxll5UcSpZAVAFO4MDLJylXAQZYTnyB6Lw64xK4yA0w8sKGgi4I6/OY7rMgU+dAq3Xl/b3+JhGZ4W37QssTZS5rL6N+iuhTA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(7696005)(122000001)(86362001)(38070700005)(38100700002)(66446008)(71200400001)(8676002)(66476007)(64756008)(66556008)(76116006)(66946007)(4326008)(55016003)(8936002)(52536014)(186003)(33656002)(316002)(2906002)(5660300002)(53546011)(508600001)(9686003)(26005)(6506007)(6916009)(54906003)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7035 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f7af2d8-bd5a-40df-45e1-08da2e9d688a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kf9D6u0EirFeIwpLN3Oc/0KT4CfCHBJJoUahf6n3etkthLcknSho131Vtm06EypuyUIHGqpRKPRleCWiuWsZpzeWeUTlz039inRXkcBCis5nnXIM5t4cSYGwDWLP3mWiWmEuEUlhojwhSEK/XPNpdd9nJiycRtMuAzS1mAPHtX2WV5T1w6XKQfE3zb8ABSCe07X2CmN2A1Ch9MpgobB5P6y2nmIb2Nnm8c29D9Q8kQUxms7f7Ij/FRDUCCTtJYlDh5sCm1T15tE9T0VNic71bUGD6PfDwj1XB245tMrq0TMtMtGho5xBI7/ZklvSfc2ff6MT3rxu2lt6DC7eBv/HUS1d7dqwuGCXqY5vgSHKwUrOSRAJvlL/JQdLS+5dmHQyGuYoBXGdTUT42w4x0w9TfdIx5uHTOTgd7I/9ZeCm7qBxrYJ1Omc5akOA3rXZKtkaV5RTobUR2PEyFhL5wmVPEERoMoIIKOqF3zae/UmZA80BPcZty7niD70l7L+7++U0dgOr1Z2qt5eKWfctkKWZaGloQB/QAJHQv2wG9pG612UeFole3SM+3T6SnJExdhi0vxNv9FtIqdM6KcLjfHe+K8urhfBRCiKcEAmOQV3csWEOgCLBkVbi75faydkHghrU2XoiapwTQpSHqH2Wt/iTyDyUGzjV7NTLOg7Tt7f1Rb2sMx3g3s5MuLgnZdW6TdKv6DrV7XfgG9n5SmghONvP8Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2906002)(5660300002)(36860700001)(40460700003)(86362001)(83380400001)(55016003)(33656002)(316002)(8676002)(6862004)(4326008)(54906003)(70206006)(70586007)(82310400005)(6506007)(8936002)(9686003)(7696005)(26005)(53546011)(47076005)(52536014)(508600001)(336012)(81166007)(356005)(186003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 13:44:51.7341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4db717ea-c20a-40ef-a575-08da2e9d6e1e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1905 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgODow NyBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+IENjOiBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT47 DQo+IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsg V2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcN Cj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA2LzZdIHhlbjogcmV0cmlldmUgcmVzZXJ2ZWQgcGFn ZXMgb24gcG9wdWxhdGVfcGh5c21hcA0KPiANCj4gT24gMDUuMDUuMjAyMiAxMToyOSwgUGVubnkg Wmhlbmcgd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gU2VudDogVGh1cnNkYXksIE1h eSA1LCAyMDIyIDQ6NTEgUE0NCj4gPj4NCj4gPj4gT24gMDUuMDUuMjAyMiAxMDo0NCwgUGVubnkg Wmhlbmcgd3JvdGU6DQo+ID4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4+PiBG cm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+Pj4gU2VudDogVGh1cnNk YXksIE1heSA1LCAyMDIyIDM6NDcgUE0NCj4gPj4+Pg0KPiA+Pj4+IE9uIDA1LjA1LjIwMjIgMDg6 MjQsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4+Pj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPg0KPiA+Pj4+Pj4gU2VudDogV2VkbmVzZGF5LCBNYXkgNCwgMjAyMiA5OjQ1 IFBNDQo+ID4+Pj4+Pg0KPiA+Pj4+Pj4gT24gMjcuMDQuMjAyMiAxMToyNywgUGVubnkgWmhlbmcg d3JvdGU6DQo+ID4+Pj4+Pj4gICNlbHNlDQo+ID4+Pj4+Pj4gIHZvaWQgZnJlZV9zdGF0aWNtZW1f cGFnZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsIHVuc2lnbmVkIGxvbmcNCj4gPj4+PiBucl9tZm5z LA0KPiA+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wgbmVlZF9zY3J1Yikg IHsNCj4gPj4+Pj4+PiAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPiA+Pj4+Pj4+ICB9DQo+ ID4+Pj4+Pj4gKw0KPiA+Pj4+Pj4+ICtpbnQgX19pbml0IGFjcXVpcmVfZG9tc3RhdGljX3BhZ2Vz KHN0cnVjdCBkb21haW4gKmQsIG1mbl90IHNtZm4sDQo+ID4+Pj4+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5yX21mbnMsDQo+ID4+Pj4+Pj4gK3Vu c2lnbmVkIGludA0KPiA+Pj4+Pj4+ICttZW1mbGFncykgew0KPiA+Pj4+Pj4+ICsgICAgQVNTRVJU X1VOUkVBQ0hBQkxFKCk7DQo+ID4+Pj4+Pj4gK30NCj4gPj4+Pj4+DQo+ID4+Pj4+PiBJIGNhbid0 IHNwb3QgYSBjYWxsZXIgb2YgdGhpcyBvbmUgb3V0c2lkZSBvZiBzdWl0YWJsZSAjaWZkZWYuDQo+ ID4+Pj4+PiBBbHNvIHRoZSBfX2luaXQgaGVyZSBsb29rcyB3cm9uZyBhbmQgeW91IGxvb2sgdG8g aGF2ZSBtaXNzZWQNCj4gPj4+Pj4+IGRyb3BwaW5nIGl0IGZyb20NCj4gPj4+PiB0aGUgcmVhbCBm dW5jdGlvbi4NCj4gPj4+Pj4+DQo+ID4+Pj4+Pj4gK21mbl90IGFjcXVpcmVfcmVzZXJ2ZWRfcGFn ZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQNCj4gPj4+Pj4+PiArbWVtZmxhZ3MpIHsN Cj4gPj4+Pj4+PiArICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPiA+Pj4+Pj4+ICt9DQo+ID4+ Pj4+Pj4gICNlbmRpZg0KPiA+Pj4+Pj4NCj4gPj4+Pj4+IEZvciB0aGlzIG9uZSBJJ2QgYWdhaW4g ZXhwZWN0IENTRSB0byBsZWF2ZSBubyBjYWxsZXJzLCBqdXN0IGxpa2UNCj4gPj4+Pj4+IGluIHRo ZSBlYXJsaWVyIHBhdGNoLiBPciBhbSBJIG92ZXJsb29raW5nIGFueXRoaW5nPw0KPiA+Pj4+Pj4N Cj4gPj4+Pj4NCj4gPj4+Pj4gSW4gYWNxdWlyZV9yZXNlcnZlZF9wYWdlLCBJJ3ZlIHVzZSBhIGZl dyBDT05GSUdfU1RBVElDX01FTU9SWS0NCj4gb25seQ0KPiA+Pj4+PiB2YXJpYWJsZXMsIGxpa2UN Cj4gPj4+Pj4gZC0+cmVzdl9wYWdlX2xpc3QsIHNvIEknZCBleHBlY3QgdG8gbGV0IGFjcXVpcmVf cmVzZXJ2ZWRfcGFnZQ0KPiA+Pj4+PiBkLT5ndWFyZGVkIGJ5IENPTkZJR19TVEFUSUNfTUVNT1JZ DQo+ID4+Pj4+IHRvbyBhbmQgcHJvdmlkZSB0aGUgc3R1YiBmdW5jdGlvbiBoZXJlIHRvIGF2b2lk IGNvbXBpbGF0aW9uIGVycm9yDQo+ID4+Pj4gd2hlbiAhQ09ORklHX1NUQVRJQ19NRU1PUlkuDQo+ ID4+Pj4NCj4gPj4+PiBBIGNvbXBpbGF0aW9uIGVycm9yIHNob3VsZCBvbmx5IHJlc3VsdCBpZiB0 aGVyZSdzIG5vIGRlY2xhcmF0aW9uIG9mDQo+ID4+Pj4gdGhlIGZ1bmN0aW9uLiBJIGRpZG4ndCBz dWdnZXN0IHRvIHJlbW92ZSB0aGF0LiBBIG1pc3NpbmcgZGVmaW5pdGlvbg0KPiA+Pj4+IHdvdWxk IG9ubHkgYmUgbm90aWNlZCB3aGVuIGxpbmtpbmcsIGJ1dCBDU0Ugc2hvdWxkIHJlc3VsdCBpbiBu bw0KPiA+Pj4+IHJlZmVyZW5jZSB0byB0aGUgZnVuY3Rpb24gaW4gdGhlIGZpcnN0IHBsYWNlLiBK dXN0IGxpa2Ugd2FzDQo+ID4+Pj4gc3VnZ2VzdGVkIGZvciB0aGUgZWFybGllciBwYXRjaC4gQW5k IGFzIG9wcG9zZWQgdG8gdGhlIGNhbGwgc2l0ZQ0KPiA+Pj4+IG9wdGltaXphdGlvbiB0aGUgY29t cGlsZXIgY2FuIGRvLCB3aXRoIC1mZnVuY3Rpb24tc2VjdGlvbnMgdGhlcmUncw0KPiA+Pj4+IG5v IHdheSBmb3IgdGhlIGxpbmtlcg0KPiA+PiB0byBlbGltaW5hdGUgdGhlIGRlYWQgc3R1YiBmdW5j dGlvbi4NCj4gPj4+Pg0KPiA+Pj4NCj4gPj4+IFN1cmUsIHBseiBjb3JyZWN0IG1lIGlmIEkgdW5k ZXJzdGFuZCB3cm9uZ2x5Og0KPiA+Pj4gTWF5YmUgaGVyZSBJIHNob3VsZCB1c2UgI2RlZmluZSB4 eHggdG8gZG8gdGhlIGRlY2xhcmF0aW9uLCBhbmQgaXQNCj4gPj4+IHdpbGwgYWxzbyBhdm9pZCBi cmluZ2luZyBkZWFkIHN0dWIgZnVuY3Rpb24uIFNvbWV0aGluZyBsaWtlOg0KPiA+Pj4gI2RlZmlu ZSBmcmVlX3N0YXRpY21lbV9wYWdlcyhwZywgbnJfbWZucywgbmVlZF9zY3J1YikgKCh2b2lkKShw ZyksDQo+ID4+PiAodm9pZCkobnJfbWZucyksICh2b2lkKShuZWVkX3NjcnViKSkgQW5kICNkZWZp bmUNCj4gPj4+IGFjcXVpcmVfcmVzZXJ2ZWRfcGFnZShkLCBtZW1mbGFncykgKElOVkFMSURfTUZO KQ0KPiA+Pg0KPiA+PiBObywgSSBkb24ndCBzZWUgd2h5IHlvdSB3b3VsZCBuZWVkICNkZWZpbmUt cy4gWW91IHdhbnQgdG8gaGF2ZSBub3JtYWwNCj4gPj4gZGVjbGFyYXRpb25zLCBidXQgbm8gZGVm aW5pdGlvbiB1bmxlc3MgU1RBVElDX01FTU9SWS4gSWYgdGhhdCBkb2Vzbid0DQo+ID4+IHdvcmss IHBsZWFzZSBwb2ludCBvdXQgd2h5IChpLmUuIHdoYXQgSSBhbSBvdmVybG9va2luZykuDQo+ID4+ DQo+ID4NCj4gPiBJIHdhcyB0cnlpbmcgdG8gYXZvaWQgZGVhZCBzdHViIGZ1bmN0aW9uLCBhbmQg SSB0aGluayAjZGVmaW5lLXMgaXMgdGhlIHdyb25nDQo+IHBhdGguLi4NCj4gPiBTbywgSSBndWVz cyBJZiBJIHJlbW92ZSB0aGUgQVNTRVJUX1VOUkVBQ0hBQkxFKCkgcGFydCBhbmQgb25seSBsZWF2 ZQ0KPiA+IHRoZSBlbXB0eSBmdW5jdGlvbiBib2R5IHRoZXJlLCB0aGUgQ1NFIGNvdWxkIGRvIHRo ZSBvcHRpbWl6YXRpb24gYW5kIHJlc3VsdA0KPiBpbiBubyByZWZlcmVuY2UuDQo+IA0KPiBObywg RENFIChJJ20gc29ycnkgZm9yIHRoZSBlYXJsaWVyIHdyb25nIHVzZXMgb2YgQ1NFKSBjYW5ub3Qg ZWxpbWluYXRlIGENCj4gZnVuY3Rpb24sIGl0IGNhbiBvbmx5IGVsaW1pbmF0ZSBjYWxsIHNpdGVz LiBIZW5jZSBpdCBkb2Vzbid0IG1hdHRlciB3aGV0aGVyIGENCj4gZnVuY3Rpb24gaXMgZW1wdHku IEFuZCBubywgaWYgYSBzdHViIGZ1bmN0aW9uIG5lZWRzIHJldGFpbmluZywgdGhlDQo+IEFTU0VS VF9VTlJFQUNIQUJMRSgpIHNob3VsZCBhbHNvIHJlbWFpbiB0aGVyZSBpZiB0aGUgZnVuY3Rpb24g aW5kZWVkIGlzDQo+IHN1cHBvc2VkIHRvIG5ldmVyIGJlIGNhbGxlZC4NCj4NCg0KT2suIFRoYW5r cyBmb3IgZXhwbGFuYXRpb24uDQpJIG1pc3VuZGVyc3RhbmQgd2hhdCB5b3Ugc3VnZ2VzdGVkIGhl cmUsIEkgdGhvdWdodCB5b3Ugd2VyZSBzdWdnZXN0aW5nIGEgd2F5IG9mIHN0dWIgZnVuY3Rpb24N CndoaWNoIGNvdWxkIGJyaW5nIHNvbWUgb3B0aW1pemF0aW9uLg0KVGhlIHJlYXNvbiBJIGludHJv ZHVjZWQgZnJlZV9zdGF0aWNtZW1fcGFnZXMgYW5kIGFjcXVpcmVfcmVzZXJ2ZWRfcGFnZSBoZXJl IGlzIHRoYXQNCndlIG5vdyB1c2VkIHRoZW0gaW4gY29tbW9uIGNvZGUsIGFuZCBpZiB0aGV5IGFy ZSBub3QgZGVmaW5lZCh1c2luZyBzdHViKSBvbiAhQ09ORklHX1NUQVRJQ19NRU1PUlksDQp3ZSB3 aWxsIGhhdmUgIiBoaWRkZW4gc3ltYm9sIGB4eHgnIGlzbid0IGRlZmluZWQgIiBjb21waWxhdGlv biBlcnJvci4NCiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 05 13:57:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 13:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322157.543372 (Exim 4.92) (envelope-from ) id 1nmbz5-0001Dz-Lw; Thu, 05 May 2022 13:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322157.543372; Thu, 05 May 2022 13:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbz5-0001Ds-Iw; Thu, 05 May 2022 13:57:35 +0000 Received: by outflank-mailman (input) for mailman id 322157; Thu, 05 May 2022 13:57:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbz3-0001Di-SN; Thu, 05 May 2022 13:57:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbz3-0007Np-L0; Thu, 05 May 2022 13:57:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmbz3-00077n-E9; Thu, 05 May 2022 13:57:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmbz3-0000ls-DZ; Thu, 05 May 2022 13:57:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KQUA9WCe15mB0kZr5LEw5H/mWQRn/Mz0gn15FclatZU=; b=wvy2YfGLOJzwzJPDdRDt21S+4O x4VKh5v76ZvfCWbUluzc5lB46ouHcqjsgkZrWkpPoT91iTkni4a9j8ROqQJmBxzEcsS+GhMhm5k6k 1kAOYhWgqeTHhSKsBS8P926pdzfxYlRukL+dJPCQ+ZowQsLc0XpH0ZBF9UUyKuRkregI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170146: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc X-Osstest-Versions-That: xen=5d2d5365ffadf075fd812038ab0841a3e868f906 From: osstest service owner Date: Thu, 05 May 2022 13:57:33 +0000 flight 170146 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170146/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc baseline version: xen 5d2d5365ffadf075fd812038ab0841a3e868f906 Last test of basis 170122 2022-05-04 22:00:25 Z 0 days Testing same since 170146 2022-05-05 11:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Juergen Gross Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5d2d5365ff..c1d5e4021c c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc -> smoke From xen-devel-bounces@lists.xenproject.org Thu May 05 14:22:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 14:22:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322166.543383 (Exim 4.92) (envelope-from ) id 1nmcMh-0004SD-JD; Thu, 05 May 2022 14:21:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322166.543383; Thu, 05 May 2022 14:21:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcMh-0004S6-Ff; Thu, 05 May 2022 14:21:59 +0000 Received: by outflank-mailman (input) for mailman id 322166; Thu, 05 May 2022 14:21:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcMf-0004Rk-Ve for xen-devel@lists.xenproject.org; Thu, 05 May 2022 14:21:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b67c7ad8-cc7e-11ec-a406-831a346695d4; Thu, 05 May 2022 16:21:56 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 10:21:53 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4498.namprd03.prod.outlook.com (2603:10b6:408:8::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 14:21:49 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 14:21:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b67c7ad8-cc7e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651760516; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=FekeaUWBEPvsa1kauS8Lrvz0i2Fk/3Hn8bhVKZtxtdE=; b=RqM/MGXQ5doQxITtVIN6bLqEqdV50Q4xUFpqWoAdUq9PXUmcWwAZovsF 6AT3XeozZIpJNkAuDibQxPz5OCftLkar8M1beHq7gUII5R/3Sui96NUCk sYF4naMwnuKVmKh9VqRutc1Mv2cNPUh9TjNd+Tl8N8oGBQtF7eqf20w8d 0=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 70654682 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:idicdqiYzyTitl3z1BypOvv2X161fBEKZh0ujC45NGQN5FlHY01je htvD26EbqzfNzP0ft0iPNji/EhXuJ/Vz9RnSwRsqXs3Ey8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvQ4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YS0XIZ2dl9kTbytdKz0uL6p42ubsfHfq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWhp7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wrL+PZpszK7IApZ64bCHtmOZYC2f/pfvxqlr 0SW8TrkDURPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ lEQ+yEuhbMv70HtRd74NzW6vXqFsxg0S9dWVeog52ml0bHI6gyUAmwFSD9pa9E8ssIyAzsw2 TehgNfBFTFp9rqPRhqgGqy8qDqzPW0fKz8EbCpdFw8duYC8+cc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNtWuVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:FG51960rgq1FmATMbQgXQwqjBVRyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZXFedU1jP94UBZ Cc7s1Iq36JfmkWVN2yAj0gU/LYr9PGuZr6aVpebiRXoTWmvHeN0vrXAhKY1hARX3dmxqojy3 HMl0jc6r+4u/+25xfA3yv47ohQmvHm1txfbfb8/PQ9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ 32rxIpL61ImgHsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGppnYIjZVZ6u ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuIoO5lbZvs3+9La1wUh4TsOscYa hT5YDnlb1rmGqhHjzkVjIF+q3tYpwxdi32MXTq9PblkAS+p0oJsHfw9PZv4kvoy6hNNaWsn9 60VJiAtIs+O/P+PpgNcNvof6OMex3waCOJFl6uCnLaM4xCE07xivfMkcUIDaeRCdQ18Kc= X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="70654682" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRTL7eEPp/pH1JOGaXI82hTPJz1Fvf1J/QI32WbabZM+BxEuydzceYYqpv/SUl3nbzNSwYFHzbC93h75qIHhW5CUIE9ebwvwyyNOoR1s/wga/n0jvpssaaMtnrFHZQ7pDvhYS4aCce+7YQoTEhts8KeYTRmG+K8Q/VOQNcMQHzbox38g+rNBeVUbGvnea91DIk4RNVxgZPUpC1oyRC/TNUc1K0VgQ366OkAQDUJAt0jVcaOe6S0zP/b0vMWRZzh5uvhnu7X8ltxNWbr1QlJivaUEzKVB/huMpYc9QBN1iPbsk+zqceINp4pLb7pMiF5ajSouxz5RR+VjTbsHqZqX4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z7MknCtDaFKJ46I5qllMrt5+TW3heupIj0BoyuJe41E=; b=jZOswFuX5NwWLWTngYUiEfb1utJZxRyLPAnsyJDUeZMYpP6CyY9XNmx3LCbIowxx4Tbzm+2bgUILLOkDN/l4HtA7IcuNH+5HN3vMsiQsOZNGAqvY5B+SZcBQvnZJkamm49kR6rwpMUhQnRBE6/L2/kAfA33gV6+n3hFGlBdOaKI7vDRbAik4SEmM2igfpgdTgWtoy9rgkuIA37bVGBtn/fqH7IUXANScQ3MpoP2f63Dl99XecxRfmsfemFa08Y8zJD6PTEEp97cnsV5A0AAlU35OfiabtpnRITExTLQdSL+bT/Ud4BiLU68rksoW68CkYPaHMwwzLho0rEFlQwjyuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z7MknCtDaFKJ46I5qllMrt5+TW3heupIj0BoyuJe41E=; b=GSvYv6+zO6THCRcuNxTdmtFgFAgpzflTsxFYpSSalruZj9DwJxkCQYrDk8Es/wNA7Hquatw8WKg8/vP3XJeFESkntHR/pTBoAtJ/pLgMiAvXKK3W13R8V0zwKNsPfwN5TCmRol+DCh+eW9xnC7o7UGQeK5k+JbkG8umpnevPlbg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] build/xen: fix symbol generation with LLVM LD Date: Thu, 5 May 2022 16:21:37 +0200 Message-Id: <20220505142137.51306-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0121.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e2d960a-0f95-42aa-81c6-08da2ea297e7 X-MS-TrafficTypeDiagnostic: BN7PR03MB4498:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gkf6eW2m4rMsFoh+oCMtwBe+8cQgMBAil/ItSSWzByt0rFSXCVluH6pNpMZFCzLRM5Dv4O20aGfw1tJqDIjzKIrmqni24ZPBjxGiDT/jeG5ZVtbxBoMgcFfttdcJ/EUE/3j4p1eEJyjpjcDk2CpW82j2/rxVK2pJjSZ56mRKtrNZf6cRxgW+6YlFCMjPWumk55Z2gAJqlIHLmIc/uZcldmIjErBltKhXTsPRAnO8NQNwjsJSXEiJruCgrpLMPfch4+/SHL59aTzpbnKnMF6oZCX4QH5SyGBWw/kbdxJHfFkqIm6qfQamZLeIiSD7+pRjscunF+jzX51NSnU2VPL/N3EBSPUUFEKU8Y1NBB3xWZgi0bZ3sGgZ0JVX9txUB1llek+u1HkwwvBw+hftL+n2eCgphrEXkbzTge6JkOyXKRDYi0LO6Prk4XEH6qg6OuDQ3C0A0QzYXdeZ/sCmiOmRvzlseifv+syPfnVIDCQOOO1pu0L31+NDVDU1qcw3ryAsncmCOeE3qu9s1NnPFY5HpTBOtoIE4p88ISQhFlSM0E2xhvOFjaX3CB6YvLrtQk3e96vnOe1pVsLn1JJ8wY9pjOsiMbHe5gLqyZcJzjS1/yU7ASsonNxKYp+hEb9axqUKa8P9cJ2LKixZq+PucVz2Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(4326008)(5660300002)(8936002)(1076003)(6486002)(6916009)(8676002)(6666004)(2906002)(66476007)(508600001)(66946007)(54906003)(66556008)(2616005)(38100700002)(6512007)(83380400001)(6506007)(26005)(186003)(316002)(82960400001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXhQdTNmVHY0SW1wQVJVNWtta2k3cHJnNWtZQkJiZkxEaFhXYVhIbEl0cWRF?= =?utf-8?B?aTZOeUFUOHpGbHBRS2VNbGZLRU16ZnFmekEvYmZiejYvRWltWGZacjFDcDU5?= =?utf-8?B?djB2ck5ENHdJZDlhaExibzV3ZmF5RGVQakdFbG5STkg5WjU5OWNzeGh2V0F6?= =?utf-8?B?LzlmNVJjTjlrOVlkSWhWeWREeHhTY3E2ZEdIRWRXVDFudWdhMkdBRllxMlN3?= =?utf-8?B?c0RXSDBlYVBxM0NMaVROMUJwaUFBUkVkLytpblQ2SFM1RzlNcW9iNlJqUEVZ?= =?utf-8?B?by9LWFVPdzc1a0dHV01Tc1RBcHBMZFhTeE56Q1RvZ1BzMFd4bHc0QWpSVTZy?= =?utf-8?B?ZEhBNXhaRThDYzBXdUhibHRtOXlvNUNBaFVHMlBVUXpJWEx5aFFwT0w3WnYz?= =?utf-8?B?Zk1OWThFUDBaMHhVbHVFZFhMNVpUTkxMb0cvRUhUcEZuTk5EUmF4TzRCT3NZ?= =?utf-8?B?WStQYXI4ZUE5aUhvbVBWYndvK1dacTRKcDYwUGh3M0FRRWdjeWFKNDUwOFVP?= =?utf-8?B?S3g1RW52bTRWZ05TTmMwRS9TN1JETWpvMXZNSGUxODF1eFh6ZDRNQnVKTXBP?= =?utf-8?B?eUFwSElZelQ2OWtxM1I1eitkT3FMM2crUVU0bk01UzBwYUxSd250aVpzbFB4?= =?utf-8?B?UytRdE12WEZOdlVhYit2dHZiVTFhQ3Y1TTFlODhsRmtpRlhiTWpRMTR1LzZJ?= =?utf-8?B?eXJGMm4yQmQ0WHBGdGo1a3JFbDlSdHlNRHZNRWQwbkNTcHhJODNLeHBwbTJ4?= =?utf-8?B?RnhqeFVnajVPM0RyQzNuYUxFT2lJU1Rqc1hVSVJEYUs0Slp4VlF1OVJ5NVY3?= =?utf-8?B?c2FSelltYm01L09IM1hObE1FRExhZVlzdUtBZUVSZUUxUlVjaVl4QkNyNFRw?= =?utf-8?B?NUZDZDVoYTN0RlF1Mm1wOXBCV2htdTFKQ3JsUHkwT3RMOWdkSkExSHdHWXVF?= =?utf-8?B?YUpQQ2hXR1R6aHREYXpldHRqRC9mK2UyVWhMQ0llU1VDUVlQQjBlT2kzTEsy?= =?utf-8?B?eEhTeW85U1VHVjdpK05rc3BqU0wrNktnS0V1Z3Y3a0V4QXpmY2Q4NlRsV3o3?= =?utf-8?B?ZkpIWmF4NEpkVXJGNnppRXc2Y21QT0Y2YUtCTElnNDh1SmVRNUQra0p1S2hp?= =?utf-8?B?ZFBWTXRBMEJjU3BBU1JZNDV6ZVRtdDBFaFlwN0NzMEdUcVQ1QlRxTUpESGtl?= =?utf-8?B?KzF4N3pETGJsUmtET0kxSnJtdm1XTTlseFEvaWF4Sm9wUnRabFpaeHh0YzVM?= =?utf-8?B?YXJYSmEwMXIwUjJPbTJ2eGdpY1RXOTN6Z1laaFVwS2o4Z0FqbzMzeElXbWRY?= =?utf-8?B?S2FTeW4yZVh2Z3pIMG56U0xtdGhHYndKUU1BSWJnOEZKVTB5QTVaUVBLeWJv?= =?utf-8?B?dEhJNUNKZWNqWDlzR2ZQcTBvaEJadGtGY0VsZDZ5R1lGdU56emxzckVrQ2ZN?= =?utf-8?B?cWE4ZGJJblN3Q2J3SG5MY016aVNucElBWWN1Vm1BemYrbDA4aG9wWlF5b2Jw?= =?utf-8?B?SUY5N3hVK2NHV2E5M0t2bjlCSUFIN0diQ1c0RFFBWTFVT3R1KzdYS2YyZDdI?= =?utf-8?B?MW9ORm8ySXYwVU82ZGhuR0tSSHl5N0ZlR0Q5alFWSUg4REV6NzBZOTZGeWFw?= =?utf-8?B?V0FSb09Dd082Q2R0MHVtSkVOa2tUQ3VjeURRc2JtU0l3eHMybnFqRmd1cTNY?= =?utf-8?B?ajl0ZVhqakJtT1pwNFFiZVI3NHN3WXZyUjJqSTZsUW5nNmcxODdub2cwV0RM?= =?utf-8?B?YlJkS25KVXlqZXBTcUZkNzZmL0pMYk1rUXViV3lWSUNhdVIrbWJHRnB3N1Fk?= =?utf-8?B?SkkxMzc5ajJxOFhnN0RzdUpiMm42QzQ4UDlDcDVjS01NZlN5RjIvUVhPejli?= =?utf-8?B?eDU5NTdaZG0zalNldS9yTUdITWZyTWh1N0FhdHMxazVxdUdZUHNwODdSMGFC?= =?utf-8?B?L2ZTaUczQ0NGRUNERWFkZ1hTWXNVV3M4YWNnTXRxRkx5WjlEQXdxUHM1TzVB?= =?utf-8?B?M1dKQmpaYXBpOHE5endwY2wxU0JQbkk0bno4d09LcGFPU0M3QjB1OVBldzhn?= =?utf-8?B?aG9Fa2NSMDZrYXI4NU1ITXR1dEd5S3JCU1QzSVhMbDhob0s3K0xjWSsxRVo1?= =?utf-8?B?d2dmeldaUVpOaEVrVW5pZzVDMUU2RWJhcUhpZ2dKRXdVVVl4Q21tN1RmcnJq?= =?utf-8?B?c1FjWEkwSndzbmVzS05pWUxhQlZCQUNXc0ZERGNPbHZQaW5nUjRHMDZocDZ6?= =?utf-8?B?ZlBpMnBPcmhHMXRIZWFIZ2licXVQNFlXUlp0NGlycXIrc0QyaHJkRzY1b01r?= =?utf-8?B?aU1VZnphc1hqLzJpMzBJR1dJQnpJUXZWVHBxYU9oMzFBSmVGeC9MeWRRZGJY?= =?utf-8?Q?GKyUZGPhIRyK7XeQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2d960a-0f95-42aa-81c6-08da2ea297e7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 14:21:49.6801 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cjbili7scbL6DcbTHaj51zBCZMtEZjABcjYQgxalOP3lQJcpI56M1827N+FnjEFT8QKAwJwO8dAgdPHtj16IZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4498 Current LLVM LD implementation will turn global hidden symbols in object files into local ones when generating the .symtab of the Xen binary image. This is different from GNU ld implementation, that will only do the conversion (or remove the symbols) when generation .dynsym but not .symtab. Such conversion breaks the processing of symbols done by tools/symbols. Use protected symbol visibility instead of hidden, as that preserves the symbol binding while not generating GOT or PLT indirections that are not compatible with some of the inline assembly constructs currently used. While there also make the visibility setting compiler support non-optional: compilers not supporting it won't be able to build Xen anyway, and will just throw a compiler error sooner rather than later during the build. Signed-off-by: Roger Pau Monné --- xen/Kconfig | 4 ---- xen/include/xen/compiler.h | 9 +++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/xen/Kconfig b/xen/Kconfig index 134e6e68ad..a9182fb13d 100644 --- a/xen/Kconfig +++ b/xen/Kconfig @@ -29,10 +29,6 @@ config LD_IS_GNU config LD_IS_LLVM def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD") -# -fvisibility=hidden reduces -fpic cost, if it's available -config CC_HAS_VISIBILITY_ATTRIBUTE - def_bool $(cc-option,-fvisibility=hidden) - # Use -f{function,data}-sections compiler parameters config CC_SPLIT_SECTIONS bool diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 933aec09a9..c144b17217 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -125,10 +125,11 @@ #define __must_be_array(a) \ BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE -/* Results in more efficient PIC code (no indirections through GOT or PLT). */ -#pragma GCC visibility push(hidden) -#endif +/* + * Results in more efficient PIC code (no indirections through GOT or PLT) + * and is also required by some of the assembly constructs. + */ +#pragma GCC visibility push(protected) /* Make the optimizer believe the variable can be manipulated arbitrarily. */ #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 05 14:23:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 14:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322172.543394 (Exim 4.92) (envelope-from ) id 1nmcOA-00050W-U9; Thu, 05 May 2022 14:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322172.543394; Thu, 05 May 2022 14:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcOA-00050P-R4; Thu, 05 May 2022 14:23:30 +0000 Received: by outflank-mailman (input) for mailman id 322172; Thu, 05 May 2022 14:23:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcO9-0004zk-T8 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 14:23:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eedeceaf-cc7e-11ec-a406-831a346695d4; Thu, 05 May 2022 16:23:29 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-9-xbZDc1CjOUKtZ0eXXb4K2w-1; Thu, 05 May 2022 16:23:27 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB4359.eurprd04.prod.outlook.com (2603:10a6:209:3f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 14:23:25 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 14:23:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eedeceaf-cc7e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651760608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZWuj8Kbs9RpkWZUyqB+n3G9WZ1g1mL6RXD6kY1HC/sw=; b=I/pUT6WCSoEcMTaDvBh4E/Xc/87EzGAdgcfEhvdX05wSIeREH3vcOX1Zrty93y9Fq9d9FY mSU3IvnUaLRcbSdqvDL5dRpRYJUiP39AWZgVFNgxH8IaxURpOMiHfyS1use9+DQh/8RvM8 YEgemZXb272PM6bwhAoTsACxd/fMu78= X-MC-Unique: xbZDc1CjOUKtZ0eXXb4K2w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjV7hF0hYGaTLZJhQ7pDh4z4n9d26UKOUUtu16KoV89VvOCrPuXXf3h4ENUb3EsMbhRGNtezpxwMGE9i2xopAlRZEuKA2JvPBVeRTe8t80vShz/bvKSZUuPGmUPnxaxz41henNjrGYqRNZE7O9u2Ze7BQaCsbRVaVyj2rTdpXqB+pBvm3jdf1MFrNEM4lde1M6DjgMLLqtbi+vIQJgvM2w71HEvvxF5eCagMCepyJ5/ThG6MZKWXXfj62iyfa5tiM/qmpds3cFVyep5vPAWlo/fJKySyONkq2OpwdSkbeaY82sU8RtjsWc26BVJiQP+eSC1Qo7SnCqpWsyHn60GAsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWuj8Kbs9RpkWZUyqB+n3G9WZ1g1mL6RXD6kY1HC/sw=; b=ZviE3uj1uYL00E9IaJkY0AOcUI5eQ1eoBcMa1oE/TW7Ekbgq2OpNQPPOrBQcP5iGYOkLdzFnJKw0kK0wmHnr8BOg+NoC9zCtdaeG2A7CmOI5YLx6Iz50rtAEBqHK9e3VoVq4ulZ7qiaSedYzlmdxH34e4cKAcaDxY/p89mokYVYBkgXrdJzDaqTuqL4oz09taLDxWI/cJ0ie0qXXdnRVlA10ogs8Z36sCv38h8s4xl5v7Hc176jwTfjoohsCig2d9Pgghz7OK5rlv3nN2gvM8SLifst4oWGPQWpjd3GAmcnNmq09ROQqg2htEhES881r9WICBmfLFPZMGBFmRNO0pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <306532fc-939d-efdf-047c-7b8556d40738@suse.com> Date: Thu, 5 May 2022 16:23:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0098.eurprd04.prod.outlook.com (2603:10a6:20b:31e::13) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32eacfc0-13fe-412d-9dcd-08da2ea2d0fc X-MS-TrafficTypeDiagnostic: AM6PR04MB4359:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +UYw6LCSRGli3yam44ROtYuFW37lqUfrMucqdg0IurRwP/fJ/fTErPl6Kw4SRamG5Q+GfQm1PL7bf8hR8Kn3hwVrDKsaYcBoZKGkZNtAc6wERJEgnlvqpJTtMESWOEhIGDi2qdUIG5oRn693/obDAigONEPdzdDXkFoAuwZcrjLo6JSgzk1S5GqESk3hMhiiEnyLFejtkzMX0iZUBcgzHcRyvhxkl370GYZXEZOi0ck1atryE0q1j/0m2PqQHQoXa4usYifDVwqEGzsIqcTBXnGipfLEwGW2Zle1rrKsSyZnm3qI9oJg/lJsbe5E2W4BRuxQmnsjUZHkp4oVR6frKXuhxh72CytmWZQVF04ePZ8DAEU+exJ4ozSX1uq8lWFOEMrKduB8KYXr0OSIE3bgd8S8ULLMbItXtjEiAPcWhIal1J5G4McSa5eWCBnzA7nUvlWCeij6oVX7TEvaTEInRgtxpEyCAf/PbvK3WrhU+J9SNBlsrcK+SQttbzVTwL6QahgKaluy+eOcPx5wTUaCH6QRufUy1mTlW1bNZo0R2Z7Us3C8KuU9ybDE8iG0xg1ySXtCk88ENogvp7zIe1f2xCvviqcfYPTnc971NRPoSwGUHS5PS+4gUxWBVoEV1qyJrS6vUBcS37OBtsf4CLDcqiOAGBLHVNIU/Cs8u1jqXtUsxg72LZArgAuc6QVA+U6jV1+bBFGsQ1Qj2rX70ZqoaYvMVV7qcdIQ9CrPx8ZSoLHSiKSf95/IJ/xcQ072bOmLdYHV+t4hyUawCBNAQuJuCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6512007)(186003)(6486002)(2616005)(26005)(86362001)(31696002)(36756003)(31686004)(54906003)(6916009)(5660300002)(66476007)(4744005)(66946007)(66556008)(8676002)(316002)(38100700002)(2906002)(53546011)(6506007)(8936002)(4326008)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmJ6V0VpV1hkL0doMU5MbGZUbVNpazkxZnFaVWdqVjVwM1cvdmFRZFlSd3V1?= =?utf-8?B?ZUhwa1BFbDVLUWV5ZjFBd21iS3FibTNUK0owbWt1RDVoTHVQVE5MVHdGMkFL?= =?utf-8?B?TFBRbUx4ekdkWDYyUXVvMHRUazdXUWo1WW1UUGFpczUzeDVtWDAxcmlDUEN0?= =?utf-8?B?QXRGZkN1aHVqbGpidGVWN1RVdnFPUE9xU0hyM0VUVldHaXpsNTdsMzJ4bDkw?= =?utf-8?B?K21tWG53M3hHZE9ZZmpudGlVdU9CTDlTbm43OUVwZlNRQ05FUjJyb0kyTFJu?= =?utf-8?B?T3IzK3FFTWhrYWljcWNML1lOZkJocHpBb1VLanhObDdXdit2TmNSVU9TeDdI?= =?utf-8?B?YWlaTEI0ZnlHQ1V4QjdLaHJJS2t4ZTdId1RmQnViVGo2YXQwTXdLTGhqa0Zm?= =?utf-8?B?Wk13R2hqT1A5TVhUeEM2djlHcTBkOWFvNnl2N25TSHkrL0hBbTA3MXM2Mmtl?= =?utf-8?B?czN1TkdMZ01NeDlTYTJTdVZ0TlZ5djVGNGtyeTNrRlAzb2xqbmNzUzVRNXZF?= =?utf-8?B?dy9JRU5pajNLQ3MyVHVmSHpqdk5lcFJXaFFZb01zVVhqeTNQVmlhenhVSFlm?= =?utf-8?B?Mnc1SDNlWU1Gdlh2M0I5aTQybHk0NzNZOFYwM0N5SDVnNzd1NGNQSDJWZDFm?= =?utf-8?B?ZTZnNWVueW9RTC9aOFphc3pCRU1KOVpkY1BsTTdOcE1GSlp4azBSbFlrVHI2?= =?utf-8?B?ZCtVc0U0RjFJUTQvMjZQWThkODNqZm1Fdlo1ZUkxYzRkbmZkcDhQOFlyS0cr?= =?utf-8?B?cm5iYlhtamdtVXpHNlV1N3JNekZEcjJWOWFUY3pTSXZJQkdRSE1ROEU5Mkdk?= =?utf-8?B?S0wyM0NvMnZpaFhaU0xxWXBhZTE3WmNRNXI2ZWhYSFNQazRKUDYwcm9WUGlK?= =?utf-8?B?THltVTNOU051K1RTL0JDaG9URTc1TGkrbll0cTdlci9UZldPSlFJZjEwV2dY?= =?utf-8?B?dllvR0dPQ3Rxam5jNTFGNC9EZ2VFWERSaWg4Z0Q4aDZUV05YZWp0aWtyMUM0?= =?utf-8?B?OXhYOEFGc0ZoN1loMHFYeE9jOC94cTVKT1dGaWl6MS9PR3pGRXdadThuTlNN?= =?utf-8?B?a3AvR2FyVUsvMFczYlZSeTA5TXlJWW8xVjJ1enRHbFVSK1dVS0R0akJuZDVz?= =?utf-8?B?QnRHNGc3RFM2OXNLTGRzTzVsMWtjNEpJS2ZQZ2R6Rm5KMUVCQU55ZnZQbjZn?= =?utf-8?B?NzA0TGl5NlA4QkgycU0yd25zdHdMaFRXOWVQakdQazNSMTBUUXhWMnR2WGZl?= =?utf-8?B?c0hRVUxvSWMzRGVacFpXN0oyUXVoZWIwZHNhSW5zVWJ1Tmp5aFVyN0pYd3Ba?= =?utf-8?B?d1NmYm1LdjI3WVVHNDQybW1ybFhTM1FSMTZaV25tcnRtWTl3VDhHd2RYcVI3?= =?utf-8?B?SithZVEvSVlIWGFTWTN6LzlENjBrQ1BVVHFrZWpXVEJic2NzVmx5UVRDRzNn?= =?utf-8?B?M0J2U2NXdkRFNzBqQ21ncHRqNkhoM0xNaEtWNkQveGtvL2pMekE5MUtTVzFL?= =?utf-8?B?NXpib3lMMkdWdkUwazhZbEM2S2NUQVR0bEtQazJWQjc4aWtXUU0wdGhDMDIv?= =?utf-8?B?c0pVVzRHL1dNUWdhLzF6TE13blhWZWxFT1FLZEZxbTZIbVZZMzZkK0ZzaHZC?= =?utf-8?B?L0Y3bjFsT1FUSDVJZkUydEdjditwTnJtUzNzRTl2SThyVHgySCtwTkNKYVRo?= =?utf-8?B?QTFaVXMwVEVoTU0zUTNSRCtIdEM1RXNJRkxBYXJUbFNuUnFzc2xxMHBqNXI1?= =?utf-8?B?TU5OeFdDMXZHTTdsNFphTjFXdGNSK2dkbTgyZ3NaTzRBZUd5cEhybnZSODJs?= =?utf-8?B?V215N2RWZHBPcWpLVWoxODllamVRRFc5VEZyelhMNXdxZEtmODBISUxCQnpt?= =?utf-8?B?VzlUVkVlTFdRb1MyZWI1UVYrekpUM1h0Q1NHRmFHaC9QSnpzdm5TTENRK1Uz?= =?utf-8?B?VG4rL1kxUWZHc204SUVSRGE0UHl0YWFRcDB0RGZuWXR1QVVFYTFuOWRPNnRp?= =?utf-8?B?UDU2S1NSWmpuNzlSUkdDZWlIdkpFRTBLbnJzam1xQ05vdFRMSlVkQURUUEY1?= =?utf-8?B?MXhybkx6czVUcXNXSnF6aHg1bE5BT3BIOUFMQmJmVUNQQ1JnMkc0NUcrdWd3?= =?utf-8?B?UHVNSFNlNUJLdGEwcjNiVVZQVy91ZkFGOWpjN3VnaHdPUHA5M1dRTS8rdGhK?= =?utf-8?B?Z3pQcVRITkZjUFkrcU1jaGdpVEZ5MHA4aDY1N2tyT0szMGg0SUtnSmNXZ0Nt?= =?utf-8?B?b2ZjRmQvR0NmMzVnSEZ2QkU5QXRjKytGcEFpMDhHRjIvUGYrS1RYYURlWTI4?= =?utf-8?B?WUxjb0lIZUxJRFZ6c2s4UTJodTVOeVUrUWljWmJqbTZBSjQ4TXgzQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32eacfc0-13fe-412d-9dcd-08da2ea2d0fc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 14:23:25.3704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JXF5ykKVcbeVvTW/xRoISZ3fQrjNTKojbFLxf1hcYF6v6YSYoeqMJ+1qXpU6XY4lpa7Wy/gplzOzAty1JQDqtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4359 On 05.05.2022 15:44, Penny Zheng wrote: > I misunderstand what you suggested here, I thought you were suggesting a way of stub function > which could bring some optimization. > The reason I introduced free_staticmem_pages and acquire_reserved_page here is that > we now used them in common code, and if they are not defined(using stub) on !CONFIG_STATIC_MEMORY, > we will have " hidden symbol `xxx' isn't defined " compilation error. This is what I've asked for clarification about: If such errors surface, I'd like to understand why the respective call sites aren't DCE-ed by the compiler. Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 14:35:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 14:35:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322183.543409 (Exim 4.92) (envelope-from ) id 1nmcZL-0006ce-6n; Thu, 05 May 2022 14:35:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322183.543409; Thu, 05 May 2022 14:35:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcZL-0006cX-3a; Thu, 05 May 2022 14:35:03 +0000 Received: by outflank-mailman (input) for mailman id 322183; Thu, 05 May 2022 14:35:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcZJ-0006cR-A9 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 14:35:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ad5fecb-cc80-11ec-a406-831a346695d4; Thu, 05 May 2022 16:35:00 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-27-f7jG_UhcPj-3UlWeVw9IHQ-1; Thu, 05 May 2022 16:34:57 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5399.eurprd04.prod.outlook.com (2603:10a6:20b:9b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 14:34:56 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 14:34:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ad5fecb-cc80-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651761299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xk+9P6950bom3ZRgp4thk8t8DeWGZS/JWvU9oUH7jp8=; b=Ycq3ncyOmNUbYcuIaag+iX1gv1VaXaNYsGCZK1hB4icUZ0PMUJRObywpV6DbG3ZAHsI5VR n/Jqm/GuVxw0c3GJtUbDAQFvEJ1UKYC+sk0+iCig3hK/gjZlNcegSmczRsDGkOULEldo+i gcRTucFE/FaYhaNRg/QmwiCqEMUOl4Y= X-MC-Unique: f7jG_UhcPj-3UlWeVw9IHQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvNc9cpanvT/a/YmmuzcD8OdAJIa5Nfaf58Lg/X7a7Nnuo7RwJikUKfJDzb76ntclR+xdR8pSD4K0xBWrRrHlTTYP58O3D2etL/Kd1JLQV37Boo/Xp0eJEZPEb0es2yS2I6arT0skzCvxu/KDTZgbqelzTigZtc5RWuaTaSA+3hfdNwmngF4QfIpB1Vm1Rwe3OTxgLLUFTGnRW4A7kR/l5vixGgA/oLEZywoyKzi5f4fg1G0pHw6QxJAL+hMWkW/YhIWbh0YrtwyvI1ex6Y18wn2XPqBH+fasruTrvpNwRMVzNScRhtE2uqSi+m0VT7V/CZclIZov9cxAaH5cdh5IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKvnMLOx6F5zJw3pKTDY0Uhbi7RbOqyNost6ZW7B7JA=; b=Ce/Z6aMnf1DB9aMlD/rOtmJpaHmkEFVv/qLtUcDr+Hmz0pGHQ76MvSdJi1N0FbNuRFgkHsErcZjhfxyXzZJqlrtN9jp1zxWZfU/h03fe13pD/NibtweZE3UP3cv2Lfpmn3im6/SsMQc4ZOD5QjtE2HvGGEJDZCWosFd4bAbFEZ60Y+okmk7Nhu0LS8U+YUPwVxhNQEVeFu7yQVsm21y35Fa2RrNjbIySP0FOlOCl6Hh24usib5dXRA3/9psKQHiQ5wmwMrlZb27Y0AqRrIUFBJJkBj9UolXTa4AIWVw1gYztvtDks6Uc4DpwcilfAsAfV/fFrEV8+x+2eGr+9pVb/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 5 May 2022 16:34:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <5866e22e-9f31-84ab-1df9-db84aa802944@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0094.eurprd06.prod.outlook.com (2603:10a6:20b:465::7) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69d6d315-2bef-4e8f-cdba-08da2ea46cb4 X-MS-TrafficTypeDiagnostic: AM6PR04MB5399:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mErE2Yur2XOpysNdcGOKuRxXbHr+GRVsGSuvVI1ZdYvsv+N/aVkVMaw2Lr2w4sCRiXn+NgSvJ+i+uV41D0jRrJ2Y0rZf0QcvmuCwrPWqRrZHs8AtnPsunMKUPQgzA1+sOhktCC2EUHunCo7QU1GA0gjIZMF/LMLwyhEFRIO/iXrndbnS/RowBNKllMDCaQfazi70JNYFPS208pd0KLt4kh6DcExKs8SnekwcfH2u3TLATQgZTOffH5d8LgWIj8HHiI50SlHSLkf+y4oTkcFoFUvL9gazC58548np1v7IUEFUPqGdIlzq5EU4cKPq3DUAwwCEWtmlPA+v4CLklIq4RHsMVOBjxc1HMdIAGl7dUcTnQceycsiyaooVpnob15ypmZdy0KCykFemgFrLdeq4ehO47jA9BJz0mzlTpKf+tPyC6enf6FyP7KeqfNur8DguGREDaI62fv/HvaBioxlhdlDeFx5lFNwQxsrEvI0iT/zDcjZEa6XptIiHSTioi8OwzEhfNRhjbqv6gRWXd/pbqNXVpx/g6cbM+cND7xswWWg44TzstHHM2Ncna9D4IqefK2BoE8d9fd+cXXcYyk6GR8edIKQ42qn8c2X6bkU4tp/MNCCuUCBRmRgLvsB0Z7pBIXDpg0LpA0dXRDnd7WAFshjzd2C7ivh9t+loFgbclZ2EKRCtcRYjkE/3I3zHgfiZAeKjfH8qTd7WPeUQJ6XIMpbERtw8w3CXT1tN5vvCVAIu3Z8dBZsEvvilU/Yc5ZIY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(8936002)(4326008)(8676002)(66946007)(31696002)(66476007)(86362001)(66556008)(6512007)(26005)(2906002)(6486002)(2616005)(5660300002)(186003)(36756003)(31686004)(6916009)(54906003)(38100700002)(6506007)(508600001)(53546011)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ym1w/a3MTFxDuwYQaHHNViJtdHguG+I4MCpdhCZitRIwG2lwnswqFIpqqoh4?= =?us-ascii?Q?7Y/w+0gwUnYMS0uid8V8jwNBUQl48eP87TQWJbxi+OM9C09dhcM/aUb+kPqo?= =?us-ascii?Q?9ru8AP77I7i1ec+pghI+5cZjwCqfkyzhiLqElhJWACPqV48Dx3vHH/jxX0fO?= =?us-ascii?Q?rBsqaj0unQThh+HY1PCERAZZshuKSvqPlnDifksdWryE+Iss6uIt8lrN0AJs?= =?us-ascii?Q?tdLAVHtDcm30DWWmA/yKiws7U83i5oiDuZkC4zd5u7g+IQ3Tz8TLg2ZQS7pb?= =?us-ascii?Q?zROghC8joxgH+qg4L1uTABuYljqUi1k9RAkI+cUl4pC3HcrwPh0jAzgKoG3a?= =?us-ascii?Q?d8exA6Fmlwv4f2XdJ1VpKgefiBEkq/PHVXKqkKTh7NFlHztMbPtPiqjKQSDe?= =?us-ascii?Q?qInqHpeCjJAJa4G/8Vjb8JKRp+t46bDtrcrC9w3YL36qa7ER8oV1QdDae97F?= =?us-ascii?Q?4EqSHVMYfrWUsIIrkG6/24Z2cOEw3hR63iV4VUxUPy7wiBJfjlcacaohg8HE?= =?us-ascii?Q?7aaJj3SBbUdYGhK27MYz7S6iuiGu1j6Mc5nXdSAclACNAQvVAC8gRyQwOjhk?= =?us-ascii?Q?3ITWZG2+eYzk5x3zvmsjT0h5ikOzXkd10gNc1kS+HKBzxVnMaXEJSDcZf9BU?= =?us-ascii?Q?unKufRg4ayv7oz/dYk9la8Se+uWg1oYZxkh4VykSNII+FopCFZyDlYKfOazC?= =?us-ascii?Q?iMg3mqPlYhqam4gqX6g5OxLLDX8NI6YvjQSfd2ExsPcUOmX3KuJWWW2zBxQH?= =?us-ascii?Q?dPuH3ixoXuxoiFYAmy97LmHBCeyJpZvKkhmwwRIhjhtJEAFl7Xqx2nrbbMTo?= =?us-ascii?Q?Z5eCR1nHimcd4COLSClty3xSoTHzP0xophyCCMU8WWhSqP8qsMy6FfSpX9Ll?= =?us-ascii?Q?O+HAxIWj0xMnO0Uf/ZLGy2LoBHdNnkQOs1WmfnKK83uJzsRW3mS9oX51lVsa?= =?us-ascii?Q?OFC3dWfm0/VuFwFpbHPzisBuIaSCY+beSNIt08xaWW4NKnmQbP3nTb4S+0m4?= =?us-ascii?Q?j1XiDNX4vYjbEJJICNEbH7bekAWYbY0XDS5c3UeYlFNmDwoGlcgIVXVmj8NE?= =?us-ascii?Q?6DtECuJDhgHGMkAFT3pMxoTGjkO6052vH1r5LGoufkeRrEX9GnzEvtLC8Jj1?= =?us-ascii?Q?z0yUx2XK/am7KvcTFlRImKAKHeeRvnkBnVj6KRoyO1mg0e/boLiyWdnEsN5H?= =?us-ascii?Q?199pEJwTFS+KWzf6Eh/uX8Wvi83r32Q8S5VugyQkAjdj9gnk1H/txfFai9Tt?= =?us-ascii?Q?JwuGA7n7gAaV3+5AOGExqnbsFjoIieMqX72xuGmpspHbjRNi5In0PMOA9bGk?= =?us-ascii?Q?YaMtFEgbpjc7RQbXKRpRWWkSZ39QCisjixLvd8Exz6sG1EbE4a3jlsIM6RDd?= =?us-ascii?Q?MbFNY8rKj8LAqx2ASOsJO2W++1McDMgRyYIJYI/wUocCKq+5OxQGnJubpDxB?= =?us-ascii?Q?Q8vD2OXV0Qhy+MFhRjJrCBfcFb0X2JjJspUtQXX7gMd+8l6zCwjH2fy6r/Kh?= =?us-ascii?Q?kqnFwv7XDllFyDUFVr+3WfHAu0qhX8/RBOHml9uGH5cXmm4RPIBw6hy39lCW?= =?us-ascii?Q?f+pzwy6iiYasKVUau1Fs1xzvqYqu7CY1UVISj8K+YESAWqop+scofKE0oyRD?= =?us-ascii?Q?R+m6v2lfBkd1f64/XETcO0F+onhp1sWVSVyylf7qZYg6mxT1TMXeME98M0JP?= =?us-ascii?Q?LYyzXRMgU3UzcWZv22jqfDtnc8mfqo3oPe9omzFIimQIPJAZNyTQtNNjmOsw?= =?us-ascii?Q?6kb9L7/7fA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69d6d315-2bef-4e8f-cdba-08da2ea46cb4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 14:34:56.0742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jDeiNFCgZBEMqw1gOgQTpG8G85vCR40PlOxj/pYtFDdKG2nyYxG0dRuh1lT/41gi5A2EBUW7RyeH/eQ91wKhwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5399 On 05.05.2022 15:19, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: >> No separate feature flags exist which would control availability of >> these; the only restriction is HATS (establishing the maximum number of >> page table levels in general), and even that has a lower bound of 4. >> Thus we can unconditionally announce 2M, 1G, and 512G mappings. (Via >> non-default page sizes the implementation in principle permits arbitrary >> size mappings, but these require multiple identical leaf PTEs to be >> written, which isn't all that different from having to write multiple >> consecutive PTEs with increasing frame numbers. IMO that's therefore >> beneficial only on hardware where suitable TLBs exist; I'm unaware of >> such hardware.) >> >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. >> --- >> I'm not fully sure about allowing 512G mappings: The scheduling-for- >> freeing of intermediate page tables would take quite a while when >> replacing a tree of 4k mappings by a single 512G one. Yet then again >> there's no present code path via which 512G chunks of memory could be >> allocated (and hence mapped) anyway, so this would only benefit huge >> systems where 512 1G mappings could be re-coalesced (once suitable code >> is in place) into a single L4 entry. And re-coalescing wouldn't result >> in scheduling-for-freeing of full trees of lower level pagetables. >=20 > I would think part of this should go into the commit message, as to > why enabling 512G superpages is fine. Together with what you say at the bottom I wonder whether, rather than moving this into the description in a slightly edited form, I shouldn't drop the PAGE_SIZE_512G there. I don't think that would invalidate your R-b. >> @@ -384,7 +406,7 @@ int cf_check amd_iommu_map_page( >> return rc; >> } >> =20 >=20 > I think it might be helpful to assert or otherwise check that the > input order is supported by the IOMMU, just to be on the safe side. Well, yes, I can certainly do so. Given how the code was developed it didn't seem very likely that such a fundamental assumption could be violated, but I guess I see your point. Jan >> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >> @@ -747,7 +747,7 @@ static void cf_check amd_dump_page_table >> } >> =20 >> static const struct iommu_ops __initconst_cf_clobber _iommu_ops =3D { >> - .page_sizes =3D PAGE_SIZE_4K, >> + .page_sizes =3D PAGE_SIZE_4K | PAGE_SIZE_2M | PAGE_SIZE_1G | PAGE_S= IZE_512G, >=20 > As mentioned on a previous email, I'm worried if we ever get to > replace an entry populated with 4K pages with a 512G superpage, as the > freeing cost of the associated pagetables would be quite high. >=20 > I guess we will have to implement a more preemptive freeing behavior > if issues arise. >=20 > Thanks, Roger. >=20 From xen-devel-bounces@lists.xenproject.org Thu May 05 15:01:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322191.543420 (Exim 4.92) (envelope-from ) id 1nmcyN-0001QQ-5Z; Thu, 05 May 2022 15:00:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322191.543420; Thu, 05 May 2022 15:00:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcyN-0001QJ-2V; Thu, 05 May 2022 15:00:55 +0000 Received: by outflank-mailman (input) for mailman id 322191; Thu, 05 May 2022 15:00:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmcyL-0001PR-1F for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:00:53 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24faa504-cc84-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 17:00:48 +0200 (CEST) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 11:00:48 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2479.namprd03.prod.outlook.com (2603:10b6:300:e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 5 May 2022 15:00:46 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 15:00:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24faa504-cc84-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651762851; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8qXF8WGRz8QHati5tnO0AUkiujnurbM7hOJwKFh1Li4=; b=Lz6v/N4P4X5BD1xYNWyf0ykKLZEsKYsfEfNyfXvM+hfbxJq42W4wfFU4 Yj74jD1uu09fUoj1f8IKNdLZ1FesGyfTqZ6u48YN0bftIpfMi7dhlVdw0 ohjVZYYTnNzIdsNjwU44Q9wE0P7vPSDPzu/bBOOAt/JMQI+BYYZ32Z/pH c=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 73142412 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7zOOpqgEXx6x2L9TXvvKKnRZX161FxEKZh0ujC45NGQN5FlHY01je htvCj3UaaqOZWqnfooiaYyy9RsOvZbcmtcyTwNv+yoxRn4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvQ4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQUwFILnhtQNaDZdHTBME4hG5e7eM2fq5KR/z2WeG5ft69NHKRhseKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMu4EegGhYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8wvJ//ZuuQA/yiR204bnIoT1f+XNQJ0JsG+8/ T/ZxTX2V0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUHBBqlz6PV50OcGTICRzsYMtg+7pdqGnoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1bUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:GH1c8akbpSrnJ4aT9PRMlkHj4FbpDfOlimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH4yGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC L4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqVnSRULAhKePZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z WxDk0nrsALciYsV9MNOA4we7rINoXze2O9DIuzGyWQKEhVAQOFl3bIiI9Flt2CSdgv8KYYvq jnfRdxiVMSEniefPFmmqc7vyzwfA== X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="73142412" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2l7GNhTWLFWbmuSryazfD7s0qNConYowvwmGcysdr2j41M3Dm1qgexN3RjQU0qwMBk2VpcDTlZP1EhjsQJ/NJVYc7DdghmZIBZjBDddZoE5ghvgHTB4HwfHg205zMzrSn5WkBNLUCCMR+QqZeENu/0Yr8c6te7M2S4c52UNZuyPpEsp3uY4jFiuq+nDMdOB9Rulkv/CeAj8nUVLQadG1uGyS8O13t7tyXG1C3i4+87GF5VCWh18lWpktXyqHkFRBvLeHI/y8gZH5KtqXrOyceuqGZGzCFkRoOrMpdRwa4OVL+lP99+wdodFhIbYvM2wok96FUuVA0wEOrUfOS8Wxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FkqHBJ5xv1vnilhPFpsMb3IdDKmG89ejqa/ekVJMMig=; b=NkgYwi+6+ZDvb2cAvcb/eAkgCbIKR7FZv7gswAnemGRcSywt0PC9Sp+hJC9l+P9scviTkmp1yGlXeRNn9/mWCVfK+zn5ZqxVUvGRYLt75bUQMS1X5eFpt9FzxuZ/7tKG/FVllMPVwpxoHGOkE/JOO8RmTxatry++QMWSpdKZ8LbaSGCl9gQBxZlI7PaLXbnZzxsUylPEJxK3ECgFI25DsEeuzvwXX80QLhsMMh0k9xMc4xFRALJyM5vNBegaxZMHwXcN4RBLH44zwXdUAHREYxUAQOf79MZ37CVKXlU0iaZuo531px2L6WwRvMiRaWmec15sLumXnoqgLhkmz72dvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FkqHBJ5xv1vnilhPFpsMb3IdDKmG89ejqa/ekVJMMig=; b=Sru0MQX5K9oNcObWeQV0ilgphoxmPqKCOvuFEiiNa4wbkwviq3n2REFet9UVLn0CY+7v1M2Gvirwrpx+0/Gl+v1mxOfx58klu5ZyL+nFwy2pjkaRRPCA5g2zAdIPPRtXFn21MdIVzIf0h3sQ7WxNGPw/FgjHFj6rwwCfrg1h+2g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 17:00:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Andrew Cooper Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Message-ID: References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> X-ClientProxiedBy: LO4P123CA0114.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66554bf7-aaf8-4883-b85d-08da2ea808f8 X-MS-TrafficTypeDiagnostic: MWHPR03MB2479:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PIF3JOa480gC9Pc95kQ0jQ8xhgxIZLecKUYw5MwwJCCmz4k7ij3VnIv26yKgTyjxEGpwZPyzB0iujaTLzOTO75aLle5QShKyRqjN6IKo4+ZDKuqtfq2YFSMnwekunlLhzaZ8p2G45Z6OfSqZQjMWIRyyD2GYaAQzezBR5qJsjjhHKSreBy+4C/EF1k8WbBowEW1QNfwAOh+HF8TexwXmiP0a7Ex46wHXRKxNrhKIVTz/I/9jHzcqcHcERep5bwlFFe2ow/Wif+Eu/acQ/nFobjjQM6N0kc0tmlchHkAWjhvkYv3E91zmdhoOiqdbXnjo+HmKtLUvNlwVHGyIuyOTF+eeZWlA/qdA1G6W/aJ7eliCCtDJSiLi8krju5xSRwV1MdDNAVTf8bqkcsB0LZ6IoRIOn1vUqvf3SGYHC2nvE248HxndODHgLth1shf26f2dx3ykokTXcAt34628W9mNKBxVLINz9dJcEjB0YqA6FPWnkTK1D4Wz2ULTxfN9CDmVa05ZcNEYo32qEzcd/+1Uae6Y5HbPWgnIJmcDXud3dlIVQBk7YnMBfQlZ7t0w8WDXlqCaI6tgd7FgcJCu0xTxDNbDfP3sk/H6ZqeTP19FzEqAgOMe4PNnr3PGuhOQ+EYNq7OqhJ8x2aTPzAs3zFTPig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(86362001)(6506007)(33716001)(6916009)(316002)(54906003)(38100700002)(26005)(6512007)(6666004)(9686003)(5660300002)(8936002)(85182001)(82960400001)(83380400001)(107886003)(508600001)(186003)(4326008)(8676002)(6486002)(66476007)(66946007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JjVGVjTTIyOERLMXpZeGNKSXBKZ1A4UUhNd29Wckh5OTgzazU4L1MxY3pP?= =?utf-8?B?WUJaWFQvNjdUeDd5bGdwU2VWUmJSMElCclVSa3dYaWs1L0s5dENhUS9mYXRN?= =?utf-8?B?VlhublV1WVhlVDhSaHVUQjg5cjhsblNwaFNZMkorUzVOVTlRSkpkelRKcUs2?= =?utf-8?B?RVdpT2FqVDBWNWMzNUJxb3RpWFlhTFhEbmtITklYOXlMcEdHYlZFcnNXUTFi?= =?utf-8?B?Vk9weWVUbm9WUkJ5ZUNrNkM5ZFlwd3pGZm1XN0QvemF0WUtKWTY5d1VqUG9o?= =?utf-8?B?c2l6ZlZjcHp1QnNYNE1QL01GeG9PbCtKMENSQnpqQ1VHUDZZRVE5akVHdWxF?= =?utf-8?B?NENVZWd5R0RYcG0wVjNaQVg0Vy9HREJvYmVVT2xPV3NJMU5RUnBVSHpkeWVM?= =?utf-8?B?TTRQdkt3MHpYcDlBWUdMNldpMUFwdTdwUlRjdnJDS1Rrd3g2SktJbU42YzNx?= =?utf-8?B?b09xOG9NN2dISnhoTjY0MStWeDhHeC9jQnczUUhNNCtvcjdVWjVvcnRGQTlS?= =?utf-8?B?dDg3MVlTcFJReHFSVVBmNEtvNU5qSHVTbmNxNG5SaWpoOHZ1cWRaM3hIWEZv?= =?utf-8?B?ak9oWGR1ZjkwbFU1blNDWVlUMkUwRDQ5ek9iV3hnbGgwcHR3cDZDdGVTZGJD?= =?utf-8?B?UzBJQk5LRHA4di9XanowdWdKZHpWNFhhdzBsOXVGYlUxTzNBODFlYW5IalJH?= =?utf-8?B?ZTNBK1k5dmpDSUwvMC9QQjFYYmdnMDFCbStaMUQrOXVNamZ1MVZWczVFQ2hv?= =?utf-8?B?ejZmODM2ckZOVjhNdjdKK2hlRzduSUJzTGt3R2Q1RVFKaWhiVDNjclFpemdu?= =?utf-8?B?dXFGUWU4MkNLaEkwU2VuZENlOVN0UFpxVWRnbEwzWjd0d2R1Z0tkR0NWNWJS?= =?utf-8?B?aXJqZDN6THh3MGZuSFh0Ky9senZXVGo4VWF5d3dGSUJTTnN4OGdSRXJRRHND?= =?utf-8?B?eW5sazQ1WmluSWxneXdCb3krdzVLRTdCcnA1M2R1cnRwMDFUTWlpYytRQ3cx?= =?utf-8?B?M0JnbnVXWW0yVVltR095U1g3eVByL0g2clE0KzJ5NzJNZ3E2MUV2a2tWajBk?= =?utf-8?B?c1Y0OXhtM0VMY2dxdWgzd2Vydy9Ib3dXSkhEbzh4cmRaQXZ6eVFhQThZUDRQ?= =?utf-8?B?R1drdUZrQ3dIeTdhZkcxWDBodXVqL3VTSG4wNklsQjYyMlRBdjVGekF1SXRr?= =?utf-8?B?YkdodzhVRWl2WWxDTW9vZHRGRW96Mmp3RXJ3VmxWTCtCdzFhWTVqMTR4TTdS?= =?utf-8?B?T2NpZWErNHZwOFVxOCtJQXJ2b250cVdHenFydDJ0RG9IWHlsRUVQUVpYQ1Bl?= =?utf-8?B?K0dRdy9XRUhFNXpiR25jaTdNcEYrbEUwbXBZR0dvdlN4UDVOc1ZCTmM3ZXhQ?= =?utf-8?B?czV0UVBxVm9xenp6Z2FkdUpMeDZXSUFGa0lacjJwQjRNcVBRL3BaZjd5RlRr?= =?utf-8?B?QWtBRGVCTHpreXArUm44bDQ5b1lURHJ3TmZLTFNvamJhckNNN21LdnFZTDkw?= =?utf-8?B?TUpaVVRRc2VIU1dkdVUyakZSYlBrZ29sR243Zmd6aSszeFgwMkVNdmgwWjBG?= =?utf-8?B?Rm1IQzhvSm8zZHNtUFpuc3hMRmlKcUtTMHdPRkpyaWFIeldwMTErbjlZWnov?= =?utf-8?B?cVRwUnQ3MmlJNE8zak9mU2FLK1JaaWJJbWFOcWJSMWJoS0MwSHJReEJWRFYw?= =?utf-8?B?ZWNqUndSbkRhTjVKWUdtUXBuaitMUVF0KzYwM3hTdiszaDh2MUpXU3VRZU94?= =?utf-8?B?bTE4TFlhR2U0aU05b25MRFlYa2IvVjhuRGdsNVBTeEdjalJNOURDbjExWm5k?= =?utf-8?B?WkdHM3RYZzdtTmZ2bjFVV3hUbkp3SERPTzVQdnE1MGl6S2x2REM4cFB1M21r?= =?utf-8?B?UHE1Y200dS8zM2tWazdldWl3RmI2V0ZST3U1cmVybmJKV3ZubWYxUlpkVjZl?= =?utf-8?B?alFRb1Y5Mld0cklZSjVGeE8vVGFzT09pS3h6Ni9QdUlRUjVRSGN2MGJWUGdu?= =?utf-8?B?cTc4WW5zOXZ6c0EvWmR0c0QxZEJUMXd4ODdnRG5ZaVp3S1AvRjZpSDBwWDRB?= =?utf-8?B?RC9UMElsdjVXaGhMenQwVTNJNU1Za2Nsc0Q3b2xZVjhxQm9Gck1PL0JDeVFp?= =?utf-8?B?MTlGQ2w2aU1YMWEraktxd1BKVWZHVGh2bm9YS2g5VU5HUGtaSTZqSDVRVHJD?= =?utf-8?B?bjdHMHozdHBTcmJ3N213cTFZNWNIdVAxajZsUHBxeU1qM3F3SWdDRXhoeEZn?= =?utf-8?B?RXVua2xUTkZyZnBmRnVUSXVMWGprNDBFNkV5VmxOUzZveUw0TW94ZFJ0NWNt?= =?utf-8?B?SC9qNG1OdnVHampTcHQreU9vVTJhaGpjTUhrTVA5bU1pRmJ5MkU5cHJGcGxT?= =?utf-8?Q?mSBs4N+fbrUQCw+I=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66554bf7-aaf8-4883-b85d-08da2ea808f8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:00:46.8747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DtLu2ENR/q3xF6R4RlP4ulTaqQ4b3NywEZ8E6BBV8BaSlxUUO0vOmejO383mA2fItZVtV9AzriPkfbFxtfhFYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2479 On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > > IOMMU code mapping / unmapping devices and interrupts will misbehave if > a wrong command line option declared a function "phantom" when there's a > real device at that position. Warn about this and adjust the specified > stride (in the worst case ignoring the option altogether). > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné FWIW, I would be fine with just discarding the stride option if one of the phantom devices happen to report vendor/device IDs on the config space. > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct > phantom_devs[i].slot == PCI_SLOT(devfn) && > phantom_devs[i].stride > PCI_FUNC(devfn) ) > { > - pdev->phantom_stride = phantom_devs[i].stride; > + pci_sbdf_t sbdf = pdev->sbdf; > + unsigned int stride = phantom_devs[i].stride; > + > + while ( (sbdf.fn += stride) > PCI_FUNC(devfn) ) > + { > + if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) == 0xffff && > + pci_conf_read16(sbdf, PCI_DEVICE_ID) == 0xffff ) > + continue; > + stride <<= 1; > + printk(XENLOG_WARNING > + "%pp looks to be a real device; bumping %04x:%02x:%02x stride to %u\n", > + &sbdf, phantom_devs[i].seg, > + phantom_devs[i].bus, phantom_devs[i].slot, Can't you use pdev->sbdf here? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 15:05:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:05:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322198.543431 (Exim 4.92) (envelope-from ) id 1nmd2X-00022W-Nt; Thu, 05 May 2022 15:05:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322198.543431; Thu, 05 May 2022 15:05:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd2X-00021y-Jc; Thu, 05 May 2022 15:05:13 +0000 Received: by outflank-mailman (input) for mailman id 322198; Thu, 05 May 2022 15:05:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd2W-00021q-Vz for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:05:12 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c18cb4ce-cc84-11ec-a406-831a346695d4; Thu, 05 May 2022 17:05:11 +0200 (CEST) Received: from mail-mw2nam08lp2175.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 11:05:08 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2479.namprd03.prod.outlook.com (2603:10b6:300:e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 5 May 2022 15:05:03 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 15:05:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c18cb4ce-cc84-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651763111; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=e12+Ir6qQ2qQlWMl37aN1oefWWj0goSiQ8/7bOI7iYQ=; b=Yxb7KuqSsoabtm3KkM/jgngyjgqiL2VS0TklPeG0PzQy1T14cXoByi+8 LC86vXOs8KNYxOIBRVMkfauk+F8miJizESBPdSuBMHvdPpLyBMsbm8xtl ZUqfFG6OBSlhxitKFmB1w/t2vMug9exsyCpARmMIqcm6V8R7n+6Mzg+Y+ U=; X-IronPort-RemoteIP: 104.47.73.175 X-IronPort-MID: 71069423 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:umcfW6lnaZ/eaPCoWZr4okDo5gydJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWCGyBa/uLa2D8cth+OYuxpx5VupfVnNQyQAc6qSw1ECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW17V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYaAQrOYDFhsshcDJxCA9+GYZm9afaPi3q2SCT5xWun3rE5dxLVB1zGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvpkBg2pYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8QrL9PZtuAA/yiRIj6W2EcTQYOCIWPtnuGyen Ezmpz3mV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN kgV8SoGtrUp+QqgSdyVdx+lpH+JuDYMVtwWFPc1gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv neWm/v5CDopt6eaIU9x7Z+RpDK2fC0Kd2kLYHdUSRNfuoa+5oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr/hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:v/GCf6gYeluGtO37GnpswxOtFXBQX0d13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMjVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xQ+A2frfKVy1zx0eWzRAzfML9n XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlYwnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MaM8F6+xrqDxSISbeE4XiQ7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri6knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdo99RrBmc4a+d RVfYDhDK48SyLbU5mZhBgk/DWUZAV9Iv/cKXJy+fB80FBt7QJEJgUjtY4id0w7he0Aoql/lp j525tT5c9zp7ctHMRA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="71069423" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enI5xvtu5mO4pavX1Lfgxp7SuwQhbDpZ9j6+P30xKoCW6V6INLAyu7bcp9fHRuduOirEw2P+pQe1eJU35h48K0Lq2qq7fbdMBYph/bvmAZLYxFG/nhbenoqI6YWH7vNMRIuCwNwllJoZ+m0I6Nj3M4LT2t5Cx3Mtav8ZSU6P1vu7qLmVi8cPcBmCHtGP7zBijV52/V5VBhUN6q/bqhREztTUkYdsUm9NmPyTV0z5OtlTfSiXx4bX31MQVBjyOX8E4vok8sFyJ5lM5+KodZdlYicPGD6DTFLS1ZJi5e0oBzuJ5s+I9OO/JdT9UKbAZwAAgh8Q5EqErqz5uW1zZgCa4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sufkpVdc1PCxK+7fv5xNB4YoUCnXEg5aE0/RPgrAw1s=; b=d+4u1jfdRNvntJahOFcd0htvDmwTMKHvYTq216Rw3wRdHUN01XaArcqcfv1G1FMDZdgkC3RJYvP7q5xMEsKqX5vY/UqoQWGbL/mE5y8OqCGL1w3QDeXpZ/Ri6ef8Jk0OPNmp89FuK+HQZnMVPu3Em1UYQdiodzWP2hHA9NdIKNHKDgOeGjX7k/FzZnr/794jJ32XiCCjZtHtrE1T4xrsoXLFv/lUNtVAi3F/EVObpgCZlEaoS7KYaUlX/ZpfcITltBbTe/lLJ1qVNe13DCdsSzvpMO8h5d1phF40ZFDdU5Rg7bMn9z6AICt4wNHAl2fjWTMCVkxrQNz5UW9uI4fuRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sufkpVdc1PCxK+7fv5xNB4YoUCnXEg5aE0/RPgrAw1s=; b=gdWtqv3K9/JC00G3qFRYNGCuJTfFpGwzgxFNVGkHktHK4c9iH8GBnn1JqTxte0iSozJxOzCnGsI17RPfqOv3w6AMA4R9PO5sUz8pQHR58Ipm55vMfHB0RfTwy0XhM7h6j6xxUunoU3nV9Fq5mBHSES6AEHvklOvNUbkrg4eRYi0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code Date: Thu, 5 May 2022 17:04:54 +0200 Message-Id: <20220505150454.51710-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0242.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37e22727-2e7d-4eb4-3bbb-08da2ea8a1fe X-MS-TrafficTypeDiagnostic: MWHPR03MB2479:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CVq/IT6x2JYDRBiC6tYz7q+3S7RI5lOhhvIDbBjW3c/sqOj9rey6ufZeE1JWhlAYyMRTPYKB2Iomabeq3Wc66O3ZWHxJ6jMnc4A1mluTRN/qCXNAWZQ2dif1u+WwWka4Q0ovSSgp0rZne7LXVSQIftxogILK6kP9h4eGPtX/BSWfTz5vtuWTDwVc8KvykBkhZacQm+6CcuGD9fp44N/CMsJiZ9geqg2Q7JCAL0Qt0V0r8bGA/lZhQrob61Svi0yevgceuB7hYAcypqu4e3a/h3kV6D4/WiUz2xi74VkFkIXsDh6o0AOMqIwKnOdaugxc51gwOG2afmfORbLP1QeLVt/Oy73bPkpK+U19rU3/1w4Q7ucLl3QBwBnjbbhOVUm9lFCIwlnK4s7jFe66Z5V8dhbDNC3E1r/16Dk+FJ+dq0oYYGcNp4TLsIm7xJNeEuPXAiS3MNUChcpM47sgQOnuLax5o7xS2VLrTXZh/V0lCWGP9+5at0Ub4SHmA2Bh3wHv9gPbrmHI+xIjUGNLbDBFfdxd8aioof/YEi+KeuuTItdBLcV1YnramRnY45z731sehC0XduwXK+P949vTu+vGiLyXirTjtUJVvF+F73ltmD4fXRV5qxjkVI+vKRmZssRajC7WlX2gPq9coR2cPM7R3g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(86362001)(6506007)(6916009)(316002)(54906003)(38100700002)(26005)(6512007)(6666004)(5660300002)(4744005)(8936002)(36756003)(82960400001)(508600001)(1076003)(2616005)(186003)(4326008)(8676002)(6486002)(66476007)(66946007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkREYWNYdHo3SHpIcTdzaUx0SjRvV0NiS0ZyTGhPemVwN1ZRdDVVVDNTT0c0?= =?utf-8?B?ZkNFbHNkRHZ2dmFmNnJ2ZlZGNTNTOE95Nk1xZ0FRRG1wY1E0SENBQWZLZVNU?= =?utf-8?B?Wno1eklKZys0bjhVa0hHb1JhZEdvMGZJMk8rVTZMVkJkL0ZXclRzaWh2WnVH?= =?utf-8?B?TVZqMzE0eWZRTGtXYXppSXVXMm1wYWNOVlE0SFpqajJyM3NYeXRZZkxVd09h?= =?utf-8?B?MmY4V21meVdGWlR2U1JvcndwTjZXR1VyZjhkdm9FazBTNGQwbXdIQ29FQlpX?= =?utf-8?B?bE9UenVZa3R3eXVqcXYyRVUzVHpsN0dHQ1pxRFBRM21Rd3JXemtHZDFNTU5w?= =?utf-8?B?eXJzNkdwL3JhSk1td2diNmVKTVA0NysvaG4vbzZ0NzJqN2RWSDZTbGJLdldH?= =?utf-8?B?M21mVG9VOENUUHQvNnZvWHRtdG9zU3pOVTVyZ04xcWN1NHcrSXFkTGE0R2Zh?= =?utf-8?B?SDB4K3pXY0RJYnNCL0lvOCtQdjJrT0xYbjJ3dkVUUHJxajlEck40bVJtWmR4?= =?utf-8?B?NHFYMmNxZ0QvaVhMWVNjNXJZWUQwb3pCWTNZam94eGMxNmNLRWcwVVBSajF3?= =?utf-8?B?NzdKdURvT3h1alVQS1JmaGZNc3RFeEZjMGdNNHNQWDFWWHovdGI5RnY5WVRl?= =?utf-8?B?NFhoQWVzTGU3WkVid2lqbGcrS3ZaRXhYZDNoL05VdTBac3NWSkpxUmVFTy9K?= =?utf-8?B?SjRXUUlrc2FtbjhTZmZnMmNMWGlsSGxsZkpBZWN1aHo2Tlhic0IwN0daU1JF?= =?utf-8?B?TWRvTGUyV2lmSGJKYU9tNnF1WGJqRm94R1RhYU1PVlhSU2RxTlJ1RUxLTE5C?= =?utf-8?B?WGlWK1FxMjZHZklJMWttWWoxZGp3cnI0OTR6eHlQYlZJOEY0VExPckJmMnZz?= =?utf-8?B?bFFXdFFZc0ZxV29BTHMwUmpscFFhS2lzTXFLRXdvZllwdUJnQklaWExLU3FW?= =?utf-8?B?bzA4cXYxeG5LWmduVkQwMzFyeWRzSmVJenJNVmlOUjNQWERQSHVpMXNmd0Y4?= =?utf-8?B?NEhaRnJGbFc5cnBqc3J3YXIwTHpuNEZFeWM0U1g1NDVkenR4S2UyeU5YWGlz?= =?utf-8?B?VW9BVEpMVm9wekdwTG9uS3ZHVHRyR3Z6bFl3a2JrVnFvWU1uVjliRU9NSmR3?= =?utf-8?B?a2h0enR4VWxoT01hVEJndkNaWWRlWEdKcWZlcElneWVQa2IrTG1ndjVEVkp1?= =?utf-8?B?eG1ESC9vVld5YUlqRjRUTDZyMVlPam10NSt2dHhiSWNPVjVxZjV6R29oQ21x?= =?utf-8?B?T0VVWWc4bHU3REtpelRuNXhEUHlnL1k2b0pLYVF5UWFVV2JSYmhNMHh6NHZa?= =?utf-8?B?Vm5pYktueFZsc05Rd0Vwd0tjd3RiZDJiQzhkaVlTUHJndWNvdU9SYWhsd29B?= =?utf-8?B?OTdUSlNZNENQai9RZWpkMisvYlJOTThzMGxEdElOUHdPT05TRVY4cDhyOGx3?= =?utf-8?B?NlYvVkFzUGFFYXE3WUFCUERvREZSaHVCakZlTHVoVVFnM2dNNEFsUjVHU0lk?= =?utf-8?B?eTVGSDZNdTRvdWZHbFFTWTFHSHhPNnVocUVvaUx5Uk0yaVZES2hXRW9BQjB6?= =?utf-8?B?RERqcGg4TlcvcjlPY2FFdmdjQkQ2Z1Y4M2srUnVjaXNKZWRuMUdpTHpIVjJw?= =?utf-8?B?OFhJOGdEMEVVTXlRaS92V2tQQVlTV0NxNjhSODVjQXRidGZyenNLcFpUMThD?= =?utf-8?B?ZWh0V1JCczFxU0p1dTBOZmE4YzAwZnhibjgzc2dHbXBvWU5GUHdPcnlvZFhh?= =?utf-8?B?QUFUcnpWMUdPSHlEQzNEYlFNNzV2RnlvUGk5YTJiTEYyZTFYMXl4NnZjR3I1?= =?utf-8?B?VnRJU09EcE9iUVlINnBCc2FTaXE0QTgyR0NzaUQ2OFE5NjUvZlJMQ1Y0MStL?= =?utf-8?B?UEd5YVhJdUQ1QXZIMENrRUZneFRsU3FmWjZ3dE1BREpZbVk5QnlBRWc2RGd1?= =?utf-8?B?RGJKZEl2TitFSzVNZnh6Vlhna0VqenZBUGJPRDh0VXFhMHNDanBDTGJiSC9Z?= =?utf-8?B?OFhSRmRCZlpJTy9RZUdRaDBQVmVtbHBhNWtBYzVLOEVNTlpvak56eTZqa0dl?= =?utf-8?B?cUhldXZTNkRrQjliMmNPcmt6aFlHUitnZXRabmxUNWxteE1JeXNoUFljN01P?= =?utf-8?B?b3RqMGdUaWxoZVQ0R0VYTWVic3pIQUpqNVIwTlYwRjhzdExYN1ZwMEU4WGlY?= =?utf-8?B?ditmdW0ycENYbFNwZVNtTlU3N1lDdi93cjBsZDQ2aVlLV0dDelIydmhiS1NE?= =?utf-8?B?QTZNWTV3bUdZb1Riclpsb1ZMcDV1WUJ1Zlk0Rm5BQURVV2ZvSUtUN0xIeWZH?= =?utf-8?B?NE1oajM3YlBhVG9rbzFkR2NSb2VWWGZPUTJFK0laMGlxYkM2ODJ6ODcyblMx?= =?utf-8?Q?vg74WG27LvMCsRTQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37e22727-2e7d-4eb4-3bbb-08da2ea8a1fe X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:05:03.4148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tHeQAma1ht5I4c3GgBbb4+WmCiPsGrxKKqLzajlOCrT2THkJhmc1zJ8QwdKVxoljBXhIb7vtqwLUxW3V84EM/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2479 That also covers the PCI bits which I'm interested on. Signed-off-by: Roger Pau Monné --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ba0d1c0c1b..96866f626e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -346,6 +346,7 @@ F: xen/arch/x86/mm/p2m-ept.c IOMMU VENDOR INDEPENDENT CODE M: Jan Beulich M: Paul Durrant +R: Roger Pau Monné S: Supported F: xen/drivers/passthrough/ X: xen/drivers/passthrough/amd/ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 05 15:06:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:06:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322206.543442 (Exim 4.92) (envelope-from ) id 1nmd49-0002hh-6c; Thu, 05 May 2022 15:06:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322206.543442; Thu, 05 May 2022 15:06:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd49-0002ha-3g; Thu, 05 May 2022 15:06:53 +0000 Received: by outflank-mailman (input) for mailman id 322206; Thu, 05 May 2022 15:06:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd47-0002gz-Qv; Thu, 05 May 2022 15:06:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd47-0000Ej-PC; Thu, 05 May 2022 15:06:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmd47-0000fs-Cu; Thu, 05 May 2022 15:06:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmd47-0004n3-CN; Thu, 05 May 2022 15:06:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rowYUau7BvO+46hNET3Kji45xRZ4Fdj/5ECp4XRMslQ=; b=T3SFTd5BhS3oHdk4WXL9cB+fNe Tmp68fKXE3Jyd8Toi2ifTU81B4dMRRU4m4I3FDA/+FvD5Y8ETANoAKmMZ+QD4AlyKO9kvXWJPNgy6 GHxIhLTND+I8wXa3jEfqbieoiatU1hpMxLVlMC/GHgcCw6JmnhB2K5lVOyW/6wyqfuAk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170151: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 15:06:51 +0000 flight 170151 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 822 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 46 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 15:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322217.543453 (Exim 4.92) (envelope-from ) id 1nmdBP-00049U-01; Thu, 05 May 2022 15:14:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322217.543453; Thu, 05 May 2022 15:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdBO-00049N-TE; Thu, 05 May 2022 15:14:22 +0000 Received: by outflank-mailman (input) for mailman id 322217; Thu, 05 May 2022 15:14:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdBN-00049H-IP for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:14:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09b0bbed-cc86-11ec-a406-831a346695d4; Thu, 05 May 2022 17:14:20 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-B2w_uR-zP-eTxxD86-lyjA-1; Thu, 05 May 2022 17:14:17 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by HE1PR0402MB2795.eurprd04.prod.outlook.com (2603:10a6:3:e1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Thu, 5 May 2022 15:14:16 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 15:14:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09b0bbed-cc86-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651763660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SeERoKnaiYcKSURIQICZjzOA+gWrdX8LlKpDIJiCnZo=; b=EWrCqSZn8gZl3chrXCXaeyC5FStq3F00hD8/BsEMSNLz1RY5NMETgEntJ1920bcplugbVX 2pmvslTqjnAIAzwe/pcSTd4DMMSuysbd4CVLQk354K7CNcR12He3KcEZj0NOE2ThTNPC37 Zk/CTYV92suH6IgbxhtwvIOHQY4y8Mk= X-MC-Unique: B2w_uR-zP-eTxxD86-lyjA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZens9wMSTeX97vI10dYOW+kpC87RsdU+XbIIfim5iDpSRIo+XZx7u9n2u3wgeSfmFFyw+E43D2RoVZY0PGY/CxyZ1CARl/E2jZzSwBxrppzpnpTm6F9jWUcgaOwaTUcqUOX7eg1H1MnJFz37WUz51vBrgD06H6xUDKGvFcn1ZrWbkwocqI/iE4RlXkfXJC99oapO4psDFyktZDFDexeBMDDoDd7UecmTYVyQXIpUXjpx6yDGmjYvM7MrT9L7Z/Dshx+gWdQD3ZSeOb8E4A3x838nj6EPUzQj/9KoFrbCyMH+fHRF6SXyMWwdGOkkD6LagvrF8ucRUE/+IDRvBmoRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JSGEanOad54z07HdaMXq6dBA1EWAZRvjIDUCclOgPuY=; b=CjDxxDQ3HvROXLq85WvFouB4nrXT4YDvjzb3BgRi5eaa1tURLjaviotEs4+oucI/aFUaAKtNqMLF5reIWp/aLfuJcOtJwX5rBywqya1cEtMC6/8ARTtqOg4M/Xd+TidUhZcX20u2P1HXlp2h2OSAD0wz+eCizBV8PsoZYaisrJvYnmnAfJq5hHE4yHvoV6w491SLmO09+GzAe0qxkmDKHCC8i01GLisxUsIdVvs6I1tc7O7Fsd2EE65PnHspB66OA3yKqNhG4fYO7yDrGcOmonPngN1SsVsZZuuycVn3PDzm513oisnkHgoN7L37F8Fjl8ivS+sCnf1PhwdlxZGZ3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7361709a-0c2a-f98b-2741-fc4c0a12bb50@suse.com> Date: Thu, 5 May 2022 17:14:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Paul Durrant , Andrew Cooper References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0410.eurprd06.prod.outlook.com (2603:10a6:20b:461::28) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3fdd81b-44cf-413b-ba3a-08da2ea9eb36 X-MS-TrafficTypeDiagnostic: HE1PR0402MB2795:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hyt2eT4nFWJ+S9Csfmh6ZGB/+l/nP9DpWDt5LN8oqiDjJ3jcFvJTY5YOau93CGocwMWKyOBlCzX8YETrrQlpPtyBXJ+4WdsPiwTRIDeRZt8UP3sQg+waoNh9Q5C07HjE/wq+Ea0RGDNKnSx079lpGZt2HZgsWGhQg6eht1phT8QTUrHeAIIhp0/8l8Fne2OLY+NwmtTC6aeUgT61LolItFSzc+0E/b/Q/I0oge7nRo8z3TYCIZXPKCz59+WSMiephDhuLfRU96PCxPDNCB7LklvyGEjVA9WYhaaNE+64ec6N/o6MqOuwsXLAbG6LZEmdaUT0yY3t5HVKQu2xHkhLMsZEryO5R8B9ruMwNwe8m56rA6lIPYRMLFs0Y72r0MmaRlBMeHsiyypXqI1yQknr64nbpB7almL7fg5uqXM6AxFKXciA7wwGjB9sjT1pOU3o9zJ2pp7ZurG7nTDoF/H1H9Sa62/wcjYN5XwAS7X2RlD214S/QY8sQ85ir1jF7CPFdwf9yAe8+uQ1R9omkDPnhVi8tK6JlgM0OOOnQ/x6GxOnq4L5SVUg7OyDrJQB0b0KX6pTeREqNav0ZQhlM/8TosT2eJmtNO9bPfdsmbtlqfyaP92KMwMwjdUmq0eYkRflCsQZnGb9fMGN4lyKK12li2QSYtNS1jYDiE6lZM4s2V7Nc7W8olNS82qqKvj3msJrriTrq3uQ+gA7zZ3fr7TuuOLJapZiX4UxGpmH5djzFvk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(2616005)(508600001)(316002)(6916009)(38100700002)(54906003)(36756003)(4326008)(8936002)(66476007)(66556008)(31686004)(8676002)(66946007)(86362001)(83380400001)(5660300002)(6512007)(6506007)(53546011)(26005)(186003)(31696002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+xOGMPpQTo8vx1MpuwiMmym9EF5JM9yzAHaqp3momW6jluWngNj6Y6PvCGw2?= =?us-ascii?Q?qSlAg8t43Qksia5T+UsmI3hDo+OBljNYOOxx+iYb1pLTx6cJ74MEM3CubJ45?= =?us-ascii?Q?dwhlcdCWVEKSiRGBg6IaK261OTwC8ApG/PPrW23ISaapNwQgv4oPe5oz5155?= =?us-ascii?Q?oaWd99ogfq7JD/EylFtCTPEwoyOwF92chnY0ZyeiVvbQTQ9dMI1rkCcgU5GE?= =?us-ascii?Q?KznkYG7O2jkewNuQEq3nm/DFEhy4wfXwxQcLQ7ngDZS9CBjjJ246oY1BWBuX?= =?us-ascii?Q?3xlTdAiPqP4oCTllOgCi0s4rQpw9rssXGGdaTA6OvQAtyrQkPLtE5tBZH5+2?= =?us-ascii?Q?GLjA9mMduqteGCkvbF8iDeZgBgEYDniQ8KAk859IwV57bp5LblNW8YTGbiL/?= =?us-ascii?Q?zMQvPFffra8KZpeSvoy2BxuLRLs6ETQ1D3Sg4K6PpjwR3lbgwZslegzNFfBE?= =?us-ascii?Q?9dJV9T7qRT0/edb4ZzKZVjtGq7Zb4rKxbg+11EtzsSK4KEKTTRd6ffSga/n1?= =?us-ascii?Q?OX0sz9FNPTadtLrlzFnruES4Nr0ry/vUcwbKJBBLNji8y/5S2rsQEHQ0Xgku?= =?us-ascii?Q?qEVqMuXZHz9ppJz/70mq12hDly4olZCTZsXG9QUfrFYPHF+FKGGiDlkyaSbd?= =?us-ascii?Q?LCqU85oFIrogwTbjrKpUEvYW/WO6m8/eA43MjY014UVmlwpowVCo0NbP+lUu?= =?us-ascii?Q?6JJfB/qo+jOTFC8XqkZcwDHNpI31PNFJmexB6XnVbsW4avkfxW1F2p5pgHEv?= =?us-ascii?Q?HvPpaK4dOUfvzEJmIfveR1UUCf5KgFep3GlhZeJAdv90ge7C5nd3qozekSGg?= =?us-ascii?Q?v6mkRMXO1Ep4CYHbCf8aUsE/Ziw3QvMPUgSCoUPtXsCTCaLr/tHKa+uWUi+I?= =?us-ascii?Q?171Syyms5Y8aIUQja4GEr8A+qEBaunll+3lPev/kdwxfTBYxL5X1bPCuhVZE?= =?us-ascii?Q?QW+OfyUBHaVY+YA2MeDZB9Cqo0Ic2m88tHmuFCCRWUEE3ge1VZ/WW508j8/R?= =?us-ascii?Q?oaRjnglnOGTspTGrk+RbNllkmixxdO99gRDWNHJWRdaoqU7hxlPhRyD8qDMA?= =?us-ascii?Q?wrBK4Swb+ll1m4TkcTEK8t/QPsHX2LsvdkfYM5Ty8Od+oDIZZ0vXKJfe88uU?= =?us-ascii?Q?nj4mJ+ZEcnRQf/aEiYK3KsSVNHE2SX9gbGlEdUYsYp3CTUNWmmx/3n20mp4d?= =?us-ascii?Q?n3uqLCPaafR6bBvegqmWcJs6u73J8XnsLEhrYBg6VyHFiZ8C7EWG5Zaiex6V?= =?us-ascii?Q?opyUmZhi46/WKWH1TjdPH/pax/hJ4/wWqUu7eHZj/3M8notqff0E6Lg4lYRF?= =?us-ascii?Q?QfQyWcsO81qBiYf9bI9KdySJBIBbN9FUWtSkg5EotQX87FBStkAFwmlSNFgJ?= =?us-ascii?Q?DKVOuvP4rAV0p9FAzoLPyBORfTswTACGpQGcKjxH5ViyTFxIi1KELvh2+wsg?= =?us-ascii?Q?K9lg0EwMkuTNq+Nk5vazmM+42V8XsSoVNdLlOBzRyr55TOAWa4JQ3oXRQyuz?= =?us-ascii?Q?PM5hKeuHor0McD/E5+gpIPweJUIwtzlpenTAYXqUgSH5GDPQBeXDVkluGTru?= =?us-ascii?Q?Ds2iSL9EK6CrttbQF6njuFyv4MZ3tIK94gC3bz3lL53T9vUJPnoNHgbz+Ma5?= =?us-ascii?Q?4e/Sm26hEg1BjhEB3s3glu7t1ucCEDB5Xb4HzSohYooFSAiPQNI7DW/dC3FV?= =?us-ascii?Q?+IEsknbtLfS6QYFyrGz0wIQAdPoP3EM75bzj/VHQ3pwgGqnNNYIMWUjjoUww?= =?us-ascii?Q?5/7RNGIYNQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3fdd81b-44cf-413b-ba3a-08da2ea9eb36 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:14:15.8335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n59fMxrF1EhEvVOTaZQoIEcE+Yzldynitl0Zk5uHyPNOflPjx15fLlyl1ZDIKNYe9Q3gI4Kmge1tUadB+9imJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2795 On 05.05.2022 17:00, Roger Pau Monn=C3=A9 wrote: > On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment= s unless you have verified the sender and know the content is safe. >> >> IOMMU code mapping / unmapping devices and interrupts will misbehave if >> a wrong command line option declared a function "phantom" when there's a >> real device at that position. Warn about this and adjust the specified >> stride (in the worst case ignoring the option altogether). >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. > FWIW, I would be fine with just discarding the stride option if one of > the phantom devices happen to report vendor/device IDs on the config > space. Well, I thought I'd try a best-effort adjustment rather than simply ignoring an option. >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct >> phantom_devs[i].slot =3D=3D PCI_SLOT(devfn) && >> phantom_devs[i].stride > PCI_FUNC(devfn) ) >> { >> - pdev->phantom_stride =3D phantom_devs[i].stride= ; >> + pci_sbdf_t sbdf =3D pdev->sbdf; >> + unsigned int stride =3D phantom_devs[i].stride; >> + >> + while ( (sbdf.fn +=3D stride) > PCI_FUNC(devfn)= ) >> + { >> + if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) = =3D=3D 0xffff && >> + pci_conf_read16(sbdf, PCI_DEVICE_ID) = =3D=3D 0xffff ) >> + continue; >> + stride <<=3D 1; >> + printk(XENLOG_WARNING >> + "%pp looks to be a real device; bump= ing %04x:%02x:%02x stride to %u\n", >> + &sbdf, phantom_devs[i].seg, >> + phantom_devs[i].bus, phantom_devs[i]= .slot, >=20 > Can't you use pdev->sbdf here? No - sbdf was altered from pdev->sbdf (and is also shorter to use), and for the 2nd item I'm intentionally omitting the function part (to match the command line option). Jan From xen-devel-bounces@lists.xenproject.org Thu May 05 15:15:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322223.543464 (Exim 4.92) (envelope-from ) id 1nmdCY-0004hj-B7; Thu, 05 May 2022 15:15:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322223.543464; Thu, 05 May 2022 15:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdCY-0004hc-8E; Thu, 05 May 2022 15:15:34 +0000 Received: by outflank-mailman (input) for mailman id 322223; Thu, 05 May 2022 15:15:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdCW-0004hM-Eb for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:15:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3414e157-cc86-11ec-a406-831a346695d4; Thu, 05 May 2022 17:15:31 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-7Oef4D1ANEud5w_wnkrvHQ-1; Thu, 05 May 2022 17:15:29 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB6238.eurprd04.prod.outlook.com (2603:10a6:803:f4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 15:15:26 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Thu, 5 May 2022 15:15:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3414e157-cc86-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651763731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yihSiwarPDnvfk7o4C8HnKUgN8VoVMYPR861ym2dfbM=; b=c6PBoYB9eDHWcmFT5PcTWRxnvwyP1DXzJQSz21CPoRR6zqAghFa5BoZeR9sC3vr8ciJrEA dvwX6TLSzaTvORf2pfYOj5wJ/4Mn3565s8d6k9A1dIauVr5BZRRXxjvGKKmznbnmyUk0w9 vsb6brJ7kzONdSfwZJnCeN62H2uLuwY= X-MC-Unique: 7Oef4D1ANEud5w_wnkrvHQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uu7E+tvUwVYjY1RaKH1W3fY4tzuqq52BKAMsM1X6OXJOys/tnyJg4dIe/dhta8m8l9mTonH87yxJAt6D2EFMwjgprSBLDU3A64xsbKDOGM0dyJuX+6OkA5dnZKO43aUzRd9ZEf1uBEodioMUiDKB1U/Wj7RKt3fcjwjrWVcJhwAM66crWdCY3up+UP0nTmPjwQNPLxmMIrMOkfAxuvsd3yEBVWJz5LGdUVildt1erjFvxVumkgssp/LwDdhDHBgfB2QtuHTOXrpjkRjuGZ/hxTwhxQtPlqbaq24pwKNtVcB0QPBvQmE8886uQ/rAYdEO0bEauAPTKp2PshnTsQET0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tGPbe7n+ppCH/NFgEAesNGBq2Qrdlji7V/V2gbxDBpM=; b=aAPNbJTp+PTDZ3onTLwhk/7eSG8afWqnrTXyGuuEyOT4rIJ4bdnyZJhiQNRw0FKloJ2Q6lEV8TB3qnxz5AfMtW0ArDCt7piSwPJLLP1JOXcrt0+USPM2+CmOXUS8Ct0OnJys8o2MK9plNU6VM6BZjw78nFMF7HPRYZMf+TKkLwLcjhLkuZbgdQzHThi4hbLfXCwugHZatkyogM407JuHfuuA8DC1dd8a11MYq2dhDt+mk1zjX0QtkV8ascRlCjuhlgjJRV1avHz2EvosSpw6DSNDABsylZIXTyCmiT/S/gtShXh44faoBP1ifSRD2sqjcb4ho41UIlCF3i5dXJZafA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20537ada-d3f5-56a9-8cb5-f274209c36e2@suse.com> Date: Thu, 5 May 2022 17:15:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505150454.51710-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220505150454.51710-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0019.eurprd08.prod.outlook.com (2603:10a6:20b:b2::31) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8a0d753-9eaf-47ec-ba78-08da2eaa1564 X-MS-TrafficTypeDiagnostic: VI1PR04MB6238:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MtLryPuHxV4q9+1ig956D0dj5o9qerEU8DWlujffhLsB62bmobm7c89zwBNvvoPgnpne25w8A/+EID5axJPE9MVoxBSJnig5MeKmgsRzwQoGpWNRb0hfqWATANkL2u44OtAt+OOgO4iYie5jWF1QcQB7yYhVblMF9O3domyUy9382pmIYeeVY0CmljVFMbARwGvATFTSjFb7I+BakeGTE8Zl+hVOxXpwiEFJ5dvTlpSdxSdcIYJIb1lWd4wkLLV6g1WQAXeMk+wMb3T1RbQC0jYsoDEJS5K9vlGiXie+O3IKOdPKjhKhE2PltdZS4CCG5xmhrEhxAf84KGFdvxcDk+/QS476zH0QqJtGufkyytNe69ky/rWEntBNYSRjNNT9IwDUfGDaLLjpx7/VVlm13k0fDDJGGE3CuygvfJ20Aa4ALbkyB8Ti5Awst3/td3JuX6NMUmG+RIMBK8cGBAEr0mHd2SQP6xrOBuLLmmxs7Y6+TmTZj6Q0681PDlNdwkg6qUNe08w1QBAiok0XUZWoMjO+ZCDVMlX4cqivlgAYl/rxyhdT6DOZ6ndb6fhorNAz1jGKsFdDXQw5On2bjotIvRdGWP/j7TBtNWY1QyvPZEk2OOieD06/dcwXpg77OF/7Jej82A3TYVyv4GSXHVt5uTbMRTWPn7sQBYuOLqcPcMPtVLZg603d5jkkpxibvG1tnQYL/TM0nSyZxTNiih8BvUxT+wVUBY2yIQ8ltKb0vzk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(86362001)(186003)(38100700002)(31696002)(316002)(6916009)(5660300002)(54906003)(36756003)(4326008)(8936002)(8676002)(4744005)(66946007)(2906002)(66556008)(66476007)(53546011)(26005)(6486002)(6512007)(6506007)(508600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yQxkuNJk0P/JQ1vZpmvJk5nL+DPBmhECXtEN5khHWVUNpEnLIjyTcW2jg3/1?= =?us-ascii?Q?znBp2GBqKWPYcOzc+5FF/LbZpDnET3ABNKEBZeMozPRBCB05j0fmq+28njnh?= =?us-ascii?Q?KSHElPBF3h6ZtR1Ge/EetTSvuXH80/6SDnrOhG/xeIzvM4rjJT+pYo00mhu1?= =?us-ascii?Q?8WPS32FcCsu8fPOO6RNRQ43/ih09QZUvHjIuo4ENw2qBtz4jl199gffM/4UA?= =?us-ascii?Q?NvSfW7Op+WrC4iJhjsEbBGmeJYG6udGPIxZw3uYEiCis/3vv4Ycz/6YM548K?= =?us-ascii?Q?P/kn3oIkyc5F+1gKeZgWC0zbzWXecO3RMYO6wkyVh0oMcEz90y774aB/+MRX?= =?us-ascii?Q?F6bocC2Cp4olh0MDZfgjsjfVdDHnPwe+s3UgUARe0tVdFmoLSruIL16G2F+t?= =?us-ascii?Q?4cAEkckXVbnc/74eTN/TFD+Mb/eXfUgwywUnHIt7OFFXp3DGw96IRt4DkvWB?= =?us-ascii?Q?rE3b2vqgtHAnu00YPJLQhap5E0w2ZhQG2vLMr9wW4j97RW0vVUaaukAS74Vs?= =?us-ascii?Q?i4MGalDvBDqAGmF4PVxNJnq1ZE8tylyFLNnCv4PPHEVQD4AHidXbl1hl8OPY?= =?us-ascii?Q?TMNu230xEsXfPFqNrUTNtfswxklma9NJ3AQEtBHOZNmmSzA3KP1/L5PePLg3?= =?us-ascii?Q?X1MOmldBExTXvLo8ELa3CPc1Uiit9AiEapAJac8twG32pH+45irc33G7qil4?= =?us-ascii?Q?nxqBmo3P6E9GbWDBjxvtYlT+RV0aJu2qzuXZrhWYIKXy4m7F/Eu6kauIy/vW?= =?us-ascii?Q?yJa2t3CG4ahoaUs8qi114Dx9Ct4gXcq8/eMLqvTbKLPr/QF3a7svxRByOkXB?= =?us-ascii?Q?hVK7Ds6FADVATNpd17wBjLubcgexj6hns/pHeq1OBvh/iWsnnEk3se1gC+XZ?= =?us-ascii?Q?XQTgPwjnXS7vTsZB065Nb+R4FOlaso5xp9IdXBsQW1xiX8u+/hlv2HFqpRRc?= =?us-ascii?Q?RQ3o+3F8zx32UfSzvorlKZc0hYdj/D294ms5KI/as7jxUb6WjokQAfniN2Xp?= =?us-ascii?Q?QTgF70HlvL3PWy2NCkVfCcyWXv4jCzoO1VP+g7M75dY8crJKwBGJQjMGUp0a?= =?us-ascii?Q?gZ+73bwOZD5xcDqLBqmvRbVlrpgHZyiiCV9VzfxpHXxjM+rfkZtzf/4TRYAp?= =?us-ascii?Q?YwJ720uoxuwthrnxwlsxNEGUHyY+UKbCkk9ZbDPDBc8pMWJ6x+nhPXMFicar?= =?us-ascii?Q?oURnvUtpeNmv7hrIPr1ZPmHpd8COkn6Uff1Bv2fDoO0hBEZvl6ieGP8GxjFf?= =?us-ascii?Q?UZTbPjkvHW39FQ9Nyg8CGFY/fPx9Eu14SSyU+KvglH4POemv87yfJTRNsnA5?= =?us-ascii?Q?EcqHJN2DG1r/LL4WR7+/t0H2ie+2Llb32lvTmxyT1KxjV844bQEGEDZnhSMb?= =?us-ascii?Q?B8aEBxcpv1doOLbgCVCb2kJZwsMtbF/0AutUU3okkKzOge38KSwIuQa5BRvJ?= =?us-ascii?Q?iEyPYDytLICEDrCAWrcnKdYKft0G0Kgr2HGR7fwHV+DZbgdyDkPVrUj3FTYt?= =?us-ascii?Q?yLd7xq+wQJofYuc9Vs7zustzd5EOo3MmwlIPvkhwnyZiBSwnFW/+7ffnr77j?= =?us-ascii?Q?42Zrdp4b4Y7um35trZl2R87+RwAFihmEEOPLxoH8FFNLHkxF8PZycJBWf2IM?= =?us-ascii?Q?8gWsMJ2JOPW5GD2LjD3FE/38KjgdYT6Cd5DlzodQJY/HannuhMxej8+SOdyV?= =?us-ascii?Q?B6T39USCJZp5FM4rCcjusimZBpGOlbX6mKRiHYhlrdfOujwQUroSdQRSrbVm?= =?us-ascii?Q?UaGyAkQ6/A=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8a0d753-9eaf-47ec-ba78-08da2eaa1564 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:15:26.5368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cqs8i6owWPrtBZ1LlHiRGix18tbseUWRDUygjp5QUMYSbrB3OBxb7yvCM05Qb65PiEbScv6/oSWuEU4Sjx/RUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6238 On 05.05.2022 17:04, Roger Pau Monne wrote: > That also covers the PCI bits which I'm interested on. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 Acked-by: Jan Beulich And thanks for volunteering. Jan > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -346,6 +346,7 @@ F: xen/arch/x86/mm/p2m-ept.c > IOMMU VENDOR INDEPENDENT CODE > M: Jan Beulich > M: Paul Durrant > +R: Roger Pau Monn=C3=A9 > S: Supported > F: xen/drivers/passthrough/ > X: xen/drivers/passthrough/amd/ From xen-devel-bounces@lists.xenproject.org Thu May 05 15:17:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:17:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322232.543474 (Exim 4.92) (envelope-from ) id 1nmdEZ-0005QQ-SF; Thu, 05 May 2022 15:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322232.543474; Thu, 05 May 2022 15:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdEZ-0005QJ-PV; Thu, 05 May 2022 15:17:39 +0000 Received: by outflank-mailman (input) for mailman id 322232; Thu, 05 May 2022 15:17:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdEZ-0005QD-5n for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:17:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdEY-0000RV-OR; Thu, 05 May 2022 15:17:38 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmdEY-0004Je-IC; Thu, 05 May 2022 15:17:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=6v2DTMBH4XCbyxhGQkUhr695b3nk/XV7CQWFDZeC45Y=; b=M9HMgu/CeE54Ozp1L2tD0ReMRs DVXv+YWiwMcrgRTI/ddRaS73GWHUTCow9hzlkQ+ahFGDNc1vcPVZUgwupDqhHwLJo4AxNh8ryUyiB vC5g8UJkhaNRG2FLmBOGPUMLkspmiKYTkeNcJ7A2xI1DTQg+5ULAoX+i05tNX0QVxCIc=; Message-ID: <282741cc-456d-2ef1-80a0-97c24ae4539c@xen.org> Date: Thu, 5 May 2022 16:17:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support From: Julien Grall To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/05/2022 09:06, Julien Grall wrote: > > > On 04/05/2022 08:24, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >> >>> On 3 May 2022, at 19:47, Julien Grall wrote: >>>> A new cpuerrata capability is introduced to enable the alternative >>> >>> 'sb' is definitely not an erratum. Errata are for stuff that are >>> meant to be specific to one (or multiple) CPU and they are not part >>> of the architecture. >>> >>> This is the first time we introduce a feature in Xen. So we need to >>> add a new array in cpufeature.c that will cover 'SB' for now. In >>> future we could add feature like pointer auth, LSE atomics... >> >> I am not quite sure why you would want to do that. >> >> Using the sb instruction is definitely something to do to solve >> erratas, if a CPU is not impacted by those erratas, why would you want >> to use this ? > > I agree that SB is used to solve errata but the instruction itself is > not a workaround (it may be part of it though). Instead, this is a more > efficient way to prevent speculation and will replace dsb/isb. > > Speculation is never going to disappear from processor. So, in the > future, there might be valid reason for us to say "We don't want the > processor to speculate". This would mean using SB. > >>>> +    .inst 0xd50330ff >>>> +    nop >>> >>> Why do we need the NOP? >> >> Alternative requires both sides to have the same size hence the nop to >> have 2 instructions as in the if. > > A few years ago we backported a patch from Linux to automatically add > nop. However, looking at the code, this would not handle this Hmmm... Going through my e-mail again. I realized my sentence has not been finished. What I was meant to write that because the code is not handling it, then adding the extra nop is fine. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 15:26:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322239.543486 (Exim 4.92) (envelope-from ) id 1nmdMu-0006sG-O6; Thu, 05 May 2022 15:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322239.543486; Thu, 05 May 2022 15:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdMu-0006s9-K8; Thu, 05 May 2022 15:26:16 +0000 Received: by outflank-mailman (input) for mailman id 322239; Thu, 05 May 2022 15:26:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdMt-0006s3-O7 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:26:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0d0c507-cc87-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 17:26:11 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 11:26:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO1PR03MB5665.namprd03.prod.outlook.com (2603:10b6:303:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 15:26:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 15:26:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0d0c507-cc87-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651764373; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=KB3DKBlrwn9GlEdbXfDbNV5pht+WhSuIoL9y6HhekIQ=; b=KGzg0MUIk0FSCB9puwAtId5arr8rCv1P/V2YTK7wmFj25Tk+DisfxUZM ZBPCkENbeSJwnO63ENJJGBNh/UL7wXb9kgJtf2LFJr2BwwpA7GI7T0j84 Na80mvHNEcMqFeKgDZaVQFhkpkEkHHozGmZGUw/JjqsYn+P0isnMt5jVr E=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 73145746 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b4PMSq3rEALhnSCe4vbD5aRwkn2cJEfYwER7XKvMYLTBsI5bpzFUn zQcDTuEaa6CNzTxf91yOYjk90IPsJTUm4VjSFQ5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw3IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Tlce6QBdyDJfKhbpEUzN6HxhDEvRJreqvzXiX6aR/zmXgWl60mbBEKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82aBfmTjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SKmL2AH9Az9SawfoFTLwkt6/rjRL9/WcYeGecYEmQWYn zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0ZjZLO+gz6QXIwKyN5Q+cXjcAVmQZNIVgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:oHUoZKmEuGQLIE5EO1O5VCZg1afpDfO+imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb WpaiIriYd1QTOlNfGz X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="73145746" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k29rgCUmlLcziN/ewwMQLsCuGfTiR7p0U1px1U+j3xFjCByOZzDXEtsX5n0gfjGO/Md7fQVJwGeL2N2wkPadGuIwLeVMdAlHp2xafJvffMmhsAKZhjuwXkKBUAB4kaPhEPXWIu0Hq4P+jt5yZPhvHwB9ql+ZDii0Ur7GDzJxQs3b1mu/c8kGoqovfcnpx/wMvHFL06JPyLi+VZ8kzHnX5RqKbozAwgXmwVmrL3Dfg+t2aXXFOOQi4rhu5YZAqDjZKyK6oev/jiIXyeNk7dTKhzLcRCsBujjgjP9+ju2GmTihoL4Tb83PSQ38Nlrpk6k1+wLcj0+vCl7PT/xjVkkrog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H/sS0UFMyGyYLTYuRV9TlNc2+7wqOivnI478LpcvgCI=; b=Jjezb63VkcG1k+0notYwCOcqfjGFLvkF0iCogjGOeToIb33ZNL+SNgsiJJlYHCJPmgG9yces2UrSYY2WsvoXYEP8euuBUgqIj5UbJ6B6nBTm3YkKPHyJXzd0iop/7Vic4jnAYcDQ2Zb/h/ootyH4pLSzqDFg/sYW+L1swcdP+4id9wCl95jRhSEgSmI/Bd7qRKzPjPzo1rP4SWyW9Lws9hPxqgnYlPwv+oAX1OQFKyB661Qft120MWZ5CZ7mWnL9ezR/WQAJoUxcgtsdoJAzQEDIlZmBAJGZSZ0up8pV1Cbps6OTiimyESsa+xTDfi678WAYqqZ70xv2GkMjtYF58Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/sS0UFMyGyYLTYuRV9TlNc2+7wqOivnI478LpcvgCI=; b=JTEira1sXhDoyWnwJ1Guw9Xs73Z2dDCdR6S+Ke/MwzaP9DBOpsFeARzNxHCZYFXixQs7UeCLmBru80iPT4kMNv3wE32h2SQefE3uGsqlKaeRpBc3yQYSwlw3a3GoFUYfSPVURarWMrW9uQP95aOjHjs7tUmuii8VHpOWm9HvLI4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 17:26:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 10/21] AMD/IOMMU: allow use of superpage mappings Message-ID: References: <5866e22e-9f31-84ab-1df9-db84aa802944@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0272.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08d47ef0-2476-4eca-182b-08da2eab929c X-MS-TrafficTypeDiagnostic: CO1PR03MB5665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5mc+/cSrheqqW/KzCBrKvaZdnSmvdvHHp5q9EShXi/1oRUS9uMLe5Sf6d1daO7WovbLLVThuWvg85WYWe1PYSHsHpmQ1brzoBJ4q+GGdYke/wDSg7ooQBUKMV9SnkK8haTtDjS7jNEcQxFc5RxLz5cT1hia8nq2vd4TxQHNVVNgpGIZGnsD+tMNuZevI0/mhCqIFVDkfTWlXA7oajc/orGCqtdrZvxCSqkLFx5j31DXwGHc2ag0Cioh9RcA5bx+GJqPEqWSRJTPekXkVbgWJL1Nx74XDAcKWab9G6Ni4qWbCkJ7lspe0L0QO7PH8l0uP+EZ95WfogTTD89+aXwodr+oHwY8bseuhyBq0CK1I6ATqz5qgs/zlOwyIanFoX8FwqT9YJNW+o3u55MacMVawGZ+k0u3KKL2hqp1wHYKEpRNaBSZ++tEcIJNJEQCVCO9ehzSfc6OqiXdEbPvxCwuH2/u6UwO9BpGFj06SxMyk6nw5l+6WaB5Z1XQB5HYtKKzhKaShsO0CxLHdpwMgYgpmyTsku2b/k0aI4PCj7XCe7ZB/F1oUhMH/8fZ2uEdVJMgJHGxj5lh2MnEmppJTm/mMquImGWcDSYZ5nYza8KKGxXNiUE0Yh0nYIW7/LN3hQzuG0ovNBgHPPzOoS70Ateyyom5Gd+txxlZZ60FFD/ynnjd835VQxaW36vvyELdzNz9fFFlX8onO4QbI+nj+wKB4hw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(2906002)(9686003)(6512007)(53546011)(82960400001)(508600001)(6666004)(26005)(38100700002)(6486002)(86362001)(316002)(66556008)(66476007)(66946007)(6916009)(54906003)(186003)(8936002)(33716001)(4326008)(8676002)(85182001)(83380400001)(5660300002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clVJOGlCMzArSHI0ZDRBZEFiMTdyMVVyOTUzemtIZlRXd05Kb2tTRElmajgy?= =?utf-8?B?UzRrRE9RdnphYTk0Q1JUbFY0YWtyTlZyeFptcW9CTHFxZmV0a2dKZEtPc1B5?= =?utf-8?B?bGptbUFUSEh5dEl6YmxsV3hYazFQMEwzTTlGcTY5WW1LaHY5L0hFOG1TL1RQ?= =?utf-8?B?VWN4MGZuRnIvM2xsUFp2NjV6YW9OT1VySWREQzdocUhRUEFJRHNNN1dVQi90?= =?utf-8?B?dVl4Y04rbjNBdk4zZGx6eHR1K2FPbWU2NTFXZk5Day9VS3dWQ1VMZTF0NmJY?= =?utf-8?B?ekdQT1QxM3pWdnVZczQvKytCWjNXSEFwQklkQ2JmeGxtU3hiUDdJUlJsYkE2?= =?utf-8?B?anlPR0Q1YVdkaHBhOWxGZG03a1VaK3M0SHEzRkpuemlvcExPVng3N3doRHFY?= =?utf-8?B?bTZVVld2SDBVTjZXTmFiajJlNURSZ0VkYUJTT3ppK2M2NjJudDZYSFFhWnZv?= =?utf-8?B?S3JmdVViejVneWVZV2FQYUovcVNnQ2pWbk5NcVJkc2haRnVhWWxicU5LM3d1?= =?utf-8?B?REdtOFJIb3dMb0JUSm1VSHh5dmh5cXVBU3RVam5mcjNVcFowblpUOGZyWitt?= =?utf-8?B?VzI2eEk4NzJXSU1sR3c2OWhBYmdtNTYrVnlOKzJtckMxRjBzc3ZzeXEyNTc4?= =?utf-8?B?OFpSQnlmenpxT0JrM0ZEdm5vL1BXNG5yU21KaTlxTXd0cnZWMnBNMmhablBK?= =?utf-8?B?enUvN0lNS0lYaEVBZkFRcW9LUTQzZFdQVVJoN2cvZ1UzUXlHS3dCSU55NkVT?= =?utf-8?B?dkhTcWE3bzlETER3VGFhWmRoeHA3WE9ubEdvRWtEeENxZGNKdFdqZmczemN5?= =?utf-8?B?Q0V3RGcrcjhxNXZYb25iZzZTa2pzcXBnejZLN1QrRUxRei9qUG4rWHYyMlhB?= =?utf-8?B?ZzhOMkgySXVrT3JMVG85S0FkSURqajNWVzlKUGxtR21GNnZZeTB3MmR0SGRv?= =?utf-8?B?NjJsb094RVY3NGRUeWdxS1RnTTQ0NkVCdks3cm5zUElYeCtidXc0R2Z1dmtJ?= =?utf-8?B?NTNhaldwamFiVW5WWTZQMXFMZkZyb3VScHFreFp3VzJud0FsNWYrVVplVWZZ?= =?utf-8?B?cW15WkJDR1I0bVRFOHR1alIwTkJMbS9uTUF6TGVvWWNFM3gzMHBybndCVUk2?= =?utf-8?B?L0hpazFQUzlHUzZWQkV2VURrcFVoR3JPdjhpNkIvL3VQQmpCM3JjYWlQbDdi?= =?utf-8?B?dlJIWHNjZFlQbFZoanliZlNmekFIRWRhemtmM2wvNEhwRFpUM0k1SzNnNWh3?= =?utf-8?B?M3hSWWlEZ1ZudU1NMnJSQjFTcEp0WFR6WTN4bUxTd1Nobmc1TkVEbFZwb3ZC?= =?utf-8?B?c3Ava2RITmxaM2lGSVIyZElGc3RYVHJTU0Z1VFdoWE05bld0R0pNZVVmbjFt?= =?utf-8?B?R0NEb0k2enl3Y2tETE05ZjYvNUZSNXpSemJjNUZmZkI1Q2MzKzRLNjhZL05J?= =?utf-8?B?THNqUkpQU3JDTlcrU29EZDFPeE9lV1lZcm9oNDI5bnUwVWxaNDkwTE1LczVB?= =?utf-8?B?bkhqY3F0dEtRL2JxSnR4SnpVNkRJcGl0UVZFRHlmMFdZTzlsK0N3cFdxRVZB?= =?utf-8?B?VFV3SGljTmZMcHVMMVhWempHMWlJOG4yZjVoNDEzWkhmODZ6MTlGNjZqd21w?= =?utf-8?B?aWxlekthUjNwcEs3Wmo1aHQ5eERra3dxbEpnVHNrNktqcmZrYmxMY0wrdDZI?= =?utf-8?B?N0JXK0IyNzFUajNpbDF5eDQ4MFpEZVlLL2JCY1R6WVdlcnQ2Qm9zVEZOTDMx?= =?utf-8?B?czFqZ2g1eFQvaUlTNi9JVzRIZWp1OW1WWStPcjVYdGFIUjV2YzdNM2JnS3dC?= =?utf-8?B?U3hQYWFrVVFrZjZsMDRwbDYrQzhYSXJ4MmIrRlR1NVRlRFJUNTY0ZHZXWW1N?= =?utf-8?B?dnVmaldObGRyVGpPbW9BQVRETU52N1NBeFVaWWVjdHdqM0x2Q3dEV2tCS01h?= =?utf-8?B?TkthZGovTXR1WWhPK2kxVGg2Qkc4QUV3NDlkcDdqV1luZm0wS2VEL2tvUnBn?= =?utf-8?B?bVg2Q2dzVWtVdXpTRzF4S2pZY295RG03UTNkRTZjOTVNb1lpK3I5d04zeVk4?= =?utf-8?B?WlQ4TlhOb3ltTVFPbHJ5VjRab3plQVlaUmFmdHJEUnNDL1E1dDFNSzduWnIr?= =?utf-8?B?UlFSdHo5MUZpYzB6YWdQVUpsUk1ucDduRXFYTjNFSHAzK0FLSytGSUxHRnhD?= =?utf-8?B?eENrNjBkbWxWY1hjcVFJNzRyeGRjZ09UcDNuNnVUWFJDcWtIK0djak4xZ3pr?= =?utf-8?B?UVU0bGZCbFNGY3lFVlc4UStjYkt2cUQydVhDUk8wUW9RY0ptSWFpLytENnZs?= =?utf-8?B?dElvbGFVQ2k4WVdjSmlaM2MxRU12NHVsZWtjQWdCUngzQ0Qxd1lDazZCVkJS?= =?utf-8?Q?ogmta3BBwynTnnpY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d47ef0-2476-4eca-182b-08da2eab929c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:26:06.1897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jwkJ0xvoyiVsmJWukqxMNNn2L5GiHvg1P58CrPTZD0hFoaZKD4VDq7cB9ass8/fGWf9Hr86rfTNRnOulXNFhOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5665 On Thu, May 05, 2022 at 04:34:54PM +0200, Jan Beulich wrote: > On 05.05.2022 15:19, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:38:06AM +0200, Jan Beulich wrote: > >> No separate feature flags exist which would control availability of > >> these; the only restriction is HATS (establishing the maximum number of > >> page table levels in general), and even that has a lower bound of 4. > >> Thus we can unconditionally announce 2M, 1G, and 512G mappings. (Via > >> non-default page sizes the implementation in principle permits arbitrary > >> size mappings, but these require multiple identical leaf PTEs to be > >> written, which isn't all that different from having to write multiple > >> consecutive PTEs with increasing frame numbers. IMO that's therefore > >> beneficial only on hardware where suitable TLBs exist; I'm unaware of > >> such hardware.) > >> > >> Signed-off-by: Jan Beulich > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > >> --- > >> I'm not fully sure about allowing 512G mappings: The scheduling-for- > >> freeing of intermediate page tables would take quite a while when > >> replacing a tree of 4k mappings by a single 512G one. Yet then again > >> there's no present code path via which 512G chunks of memory could be > >> allocated (and hence mapped) anyway, so this would only benefit huge > >> systems where 512 1G mappings could be re-coalesced (once suitable code > >> is in place) into a single L4 entry. And re-coalescing wouldn't result > >> in scheduling-for-freeing of full trees of lower level pagetables. > > > > I would think part of this should go into the commit message, as to > > why enabling 512G superpages is fine. > > Together with what you say at the bottom I wonder whether, rather than > moving this into the description in a slightly edited form, I shouldn't > drop the PAGE_SIZE_512G there. I don't think that would invalidate your > R-b. Right, might be good to add a comment that 512G super pages could be enabled (ie: there's no hardware limitation), but we need to be sure that the freeing of the removed page table pages doesn't starve the pCPU. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 15:36:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:36:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322246.543497 (Exim 4.92) (envelope-from ) id 1nmdWY-0008L3-Jw; Thu, 05 May 2022 15:36:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322246.543497; Thu, 05 May 2022 15:36:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdWY-0008Kw-GV; Thu, 05 May 2022 15:36:14 +0000 Received: by outflank-mailman (input) for mailman id 322246; Thu, 05 May 2022 15:36:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdWX-0008Kq-Dm for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:36:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 165b34d1-cc89-11ec-a406-831a346695d4; Thu, 05 May 2022 17:36:11 +0200 (CEST) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 11:36:08 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2545.namprd03.prod.outlook.com (2603:10b6:404:5a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.28; Thu, 5 May 2022 15:36:07 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 15:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 165b34d1-cc89-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651764971; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=p83qnC903DgR4ZAsrP/IDojeu4CGm3Dddul1l3esC7s=; b=FrR7i69OuNPv/OvXj4YioligZEuI3tv7n1v/FzkdPt5vLeMlWMOQwFRx KLrZs+wO7h8d5usRi6YKVlKOxZHi6RL/B1e5a4yeBnomRBJ3fMNmz5yoG wdmXB0eGYu13n1IgPaX6cOOo0aLDZ374ctCsE6G8ONEUluV0FLmNhmO8S s=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 70057089 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:loTgLKBiSNei/xVW/1/iw5YqxClBgxIJ4kV8jS/XYbTApD8mgjMOy TNLWz+Gb/6DNjP2e4oibN+3oUlUsZXSx9JhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh39Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhb4 o5Nj8KqZDwMM/yWp+EYXEZRSztxaPguFL/veRBTsOS15mifKj7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8mcHc0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjw3iSgK20JwL6TjfNovzOJ0zFb67azAYvOVsGyHM5cnW/N8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1iPwQPJVGuw+rQ2IlKzd5l/AAnBeF2EfLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:g+qPL6BkKjwG763lHeglsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl4J6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr10jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKva/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdY15dPoWXo8kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ1yHtycegB2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB26ffueChPaHbzYfJt3SU7lmtrQ3Igfwt2MVdgh8KYS8a 6xJW+w81RCNn7TNQ== X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="70057089" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LovIObcxhGQwiPyOcOg/vQczF1LeucDu7g+k02KSIjUqxUyCBWidZhsiNKh4o/xt4ocC8Ra76dXygcIh/neX9nzq8xnmxJJmH2L88enJ+d73bg8/zfPD3ZQFyLmyLmfUyrOTt6ycLfaeD+imo1xYlwn9uRf98DEZtxpwhotOwSLPnuUDX3XBuEF4togEQpsrjyh5qaB1c9AIVIttSClw0wpK8eCH4hlE9Sqhyo56+LKZd1Mv76rBgTJhlQbm/3x0kEpFnsgzIZuacPKiWbC+DiRo+R5KVTyevSXeWj5uJZJxZaCxFHLZqUQeHq5oWgb0QU0mkstN+q0UPo5fK1K5Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sXa0/MB+g4pt58q5OHvQmFFGrsxQEvV+ZbgK9Q/Cl7k=; b=UwWkvIF/8P+qYMaEIL4oq//OysB51TOKUV5kDsm2dL2RlZsAPmjJgwnx0A2em+h9JtnJGUyUpPvM9woX+SvAV7ixrMsbNmj3T6NsMnKl0mLVj9yb7zDqJkITPbQEj0S1vB4Gf7AjuPf+dTjPjOwaOHSolHItUDq7tHW9qiT+4aG0VLQIc+s23Z7LUOPBmwYsY+FfnfHbK2NDvkkEcIsos4L+L4e5iiLD2h4ITqXsIML7iqk56IpMtHJiZfeFAhN+Bb/z5KCgOz0/lB+YY/wYGmEZWyp+Qw7bAxpQFtffbicK5i4vbF9YBcY4PPIN1uUjESfal/8BcbpJlwJ2nn8Now== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sXa0/MB+g4pt58q5OHvQmFFGrsxQEvV+ZbgK9Q/Cl7k=; b=MNlqDgu2d5BHa3+lgqsR1mMir9RR+A791WV9BEztUqYzVWTK/ASNEzbTc8P28xVgVfz2Op/BhoHE5EscjGE+4U8OUbiQhvBFQc1WZ6oK2QrF6wLpRVUkOtodv0nme8i8HVa+g5nl50IUz7mqwU5C9tcYtVfj2quF1oBH3wCE5NA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 17:36:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Andrew Cooper Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Message-ID: References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> <7361709a-0c2a-f98b-2741-fc4c0a12bb50@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7361709a-0c2a-f98b-2741-fc4c0a12bb50@suse.com> X-ClientProxiedBy: LO2P265CA0327.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3fe6b687-1d53-462f-d8b6-08da2eacf8ac X-MS-TrafficTypeDiagnostic: BN6PR03MB2545:EE_ X-MS-Exchange-AtpMessageProperties: SA|SL X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hC/7VOAsx5wvqjdbnTLE+dSjIXOhCsdwHCVw7PmAgZ+fHEtalF4p7/MP5JuQal/ZdDm/JfQKiEEwOXW9vNgp/ItbXdPwqyyJlsCxqhNP+B/05cBkRanBY19elQ2EqcPhAdycrypwO/rDNp7k162gRPx741eW9cfD2XMqowVTjTeS+8WIJ+cJlRZjHi/Ndpsm6mLN5yqNhm8DYasL32/JY73ipC0u5J3KrPIqtj2DxVowxnIZyIUSatMfpl+oGbh6YUMLJQtqzfCBppXbrhmAxPrwDNEL7w36d9zUjzGIehG9Scgc0uURKgE4Izv9/YaUBxLey7FWVRlye0s/uw7A/X+oUHxLmwmYjsB9zZBhvI0k0nbQzayUusj1fhDMP3wsqHLZ1jlxwQFVADYVsrlK1hMJw8Cww/jfkOm1eXx2XgwBj17C5rnOE76KJwKMezVF+25g5+yx3ccea8YcU2LxxfFDnO6nDC4Qy0ihzax6IamoT8vUrdcMHEAkYvIjRZfYk099GRHGoyf6BCKSUtu0Op09IvcjCCzKN/g3Ll9pb7bPRVjbtMYEy8zMd9lKGwD68dVSzJiMYU06LbiyCq+SL2KbYo7zVd7bHwi6ezl16WfbnLIdx9/rS/+UmO3JQYcmcBlmd4m0gQFd+gxgcByctQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(82960400001)(6512007)(9686003)(8936002)(6486002)(2906002)(26005)(508600001)(6666004)(5660300002)(53546011)(6506007)(54906003)(6916009)(83380400001)(33716001)(316002)(86362001)(66476007)(8676002)(66946007)(66556008)(4326008)(107886003)(186003)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K01hQ3FvR1hWVnBjRHorWnNvd1hrWHQ5WkZLV3BpWVdsTHJLT09XcTBMVXZv?= =?utf-8?B?MVRhSTZNNmNLRzZrWDlCd0d4YVUydzlFZ1pFd3FxTEFLL3g4TTI1amV6UW9O?= =?utf-8?B?MTJFMmhpSENnMURGN1BybzVBZ3krdGd0YTJ3U2k3V2ZNM3U4cjZlOGpkdkhl?= =?utf-8?B?MzNUN1VIOTFDQWtpN3FDQkdjQ21PRmVJT1FWY1VyVWcrdlJ5MGkzQmxha3A2?= =?utf-8?B?Y2RWQ0o5ckdlL3dmdjRtSUlzSEtveGZ6Y0pYSHNFc1ZnNUNEWFVaZWZ0RmFI?= =?utf-8?B?UEhUWDdEL1grd0pMYm11YiszeDdxUjZyQU5Tc2JlTW5VL0RRQlBOMlcreXBj?= =?utf-8?B?bXRvdXNSWEI2ekVtSkl6UlluVTFzTnpXVVhNUUlVamlxU0Yydm1Cdk5aQ0tV?= =?utf-8?B?N24xdGZiY1NuZWFWWXNIeHh4U0xEOEhWMEYrK2FvdlBGeERYdDRpNTNxZXhP?= =?utf-8?B?UzZJdGZKUFQxNXgrbWJSRllDT253YnB3RXFXSXJxR21INFZranUxaU8xNmhH?= =?utf-8?B?MGE3WFFjdEIzRHo2ajdDQ3NiWHVxVkY4NG9Hcy9UNTMvQTh6anRrMytqZGUr?= =?utf-8?B?c2tXaW8xN0tlNGtUZFhTbEZieERaZStrTVJ5cmlTZm8zaTlad1d4RUtkYitp?= =?utf-8?B?cGJtMC81YTYvVzlIdlczMGV1RjlNbUgvcUxjMk1IUG01NDVzSEQvK25CZXRZ?= =?utf-8?B?TXJXQ3MvRDBnOGJud1VSQk9jRWJTMGJoSlBJOVB4dm9JMzZySi80VnQ3ekpl?= =?utf-8?B?a1NETG45amk0K1JmVUd4NmhvaHFNMFMzTnVIK2RaeTFHZGc0dlFPRVpSTjhY?= =?utf-8?B?d0VBNkQyWjRzRkZHaTU2VWlnNUZhb0xOQUE3eWVYSk1adkRBcjZUUk0velpk?= =?utf-8?B?Nld6Y1c4Qmxad1FtblZ4K2RXazZaOXhSNHJVcDByK1lvMWFRZU5CU3BxRnQ5?= =?utf-8?B?RlhPNXg1bmZwTUkzYitWd0hLOEVKZnl5N2RnajMzTHVTdFpzdnUxaUsxZmht?= =?utf-8?B?Q2Y0YXdoWjdVYUxZUmxQdHZKVTgvSjZvbzlyRUVkeTcveTI4b3Q3TzlnK2VQ?= =?utf-8?B?WStNZjBNMWYwS0l1ejdLdDZvMGFWZ0hrdjdwMC9kNlk4aGg1a29VaUw5ZkZy?= =?utf-8?B?OTkzWmxPUitvaFlRUEUycHo0Z0RKclp5c3NuTU1rV0g0L2ZFUWd6K1ZxbkZl?= =?utf-8?B?SVlVR054TDNjRlMwSnJNMzZ1QXB1aDZLRjAvWStXeWtubnV1dFhkUEVqVVZ6?= =?utf-8?B?QU5FejI3bEQ4RTFjUE5kL0lZSG44WGJad041RnZVUWVGandpUitLVHVIKzl6?= =?utf-8?B?SUdCdVJTcTNtK2xGMCs3bnQrVko4NFdQV3p5anU2dGl5LzZPZXpXNjB3NU5l?= =?utf-8?B?TytiZmZuR1YydUJ2K2JaN2VZNGJYQjQwNE51aTdMaWFPOGdkazY4QmlDWndH?= =?utf-8?B?MWZBZERNVENEU3dqR0FQcnphZjh2UFdZK2k4bHltOTErTERsRkViRWVkczMw?= =?utf-8?B?YVpIUVdBQTlnQ3h1bXpPZElOVzVuWnprNzFNYXRobmdSTHV6NExFTDB0dkhy?= =?utf-8?B?WkdCT2ZVV2VGVzU3dFJJN1Mza3llSHNOU3JqVzlkeUlURWdRRzIvdTBrd2ox?= =?utf-8?B?cGtiYm4zMkE2cUhsQVZuMlBNZDlMRzBSQ0JwZFlCR2FEUUFRaDVST1F0S2xL?= =?utf-8?B?Zm1JWkl0Sys5dmRtbjIrdEw2aXRieFVPOSszdWNETEhORmNsRVVwZHh0NldM?= =?utf-8?B?OWJBNjl1eFBMNkNBN2tYRU9SeEpIVldNSUxxVDZIVU5RdmdycmtSOVNtQkZL?= =?utf-8?B?YVY5VUlsTVQ4aDhxRTRUb3RTYllZbExaNW1hMGdKcWpMUEVuQnZkNDRJZE91?= =?utf-8?B?a2NFdWg2c2F4MGJpWUJ5MHhnOWxxSTRaL0p1MGM2MHl4TXBPekNjUGIyQkZP?= =?utf-8?B?Sk9PbEdBUjNBaTdnNnAzeEVFbVRmUWdwSWp3NzFxNitjc2JUazhqcW90Qkwr?= =?utf-8?B?R0RDeFgxbnUrQTJkcmF5TTEyRG91aVB4d2dlT1pPdFl4akNrL3F2aS9FL1Fj?= =?utf-8?B?ZHY3SkkyVi8zOTJiTFBtOXU3ZE9uVVR1MFYrMjZDSUZ5K0phczJlUEh1QU1o?= =?utf-8?B?WTVJUXB5MUVJYXVnb2ZTa2hXeExhYlFhR2NoV1IxQTBscXFPbTdWdEtMRjk5?= =?utf-8?B?N0lUY3hlK2xvSHBZK2l2ZjB2dkpiN25Pd1BaSkVKR2dCdzJGT2ZlK3NwaytP?= =?utf-8?B?QU4wVVV2UlYvZ1ZWSTBDUGpHZktwZndBVEdRdEIxRENjT1FSTmZEMTRKOUx0?= =?utf-8?B?cU9IRWNEYVJjSlgwT0FQZUhtZy9ndk1NRVl5MG94MFZ2R3JHSk1jdk1GSE1l?= =?utf-8?Q?NavA5tpd37l+VDPA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fe6b687-1d53-462f-d8b6-08da2eacf8ac X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 15:36:06.9238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dXzyBNhtPxLQginK/zKWkevYG+9zaGZFSi05AazF/mBf1/EgERa0/imJal073wGvY9wvBGMDOVwBu4ucgFUzuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2545 On Thu, May 05, 2022 at 05:14:14PM +0200, Jan Beulich wrote: > On 05.05.2022 17:00, Roger Pau Monné wrote: > > On Fri, Apr 29, 2022 at 03:05:32PM +0200, Jan Beulich wrote: > >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe. > >> > >> IOMMU code mapping / unmapping devices and interrupts will misbehave if > >> a wrong command line option declared a function "phantom" when there's a > >> real device at that position. Warn about this and adjust the specified > >> stride (in the worst case ignoring the option altogether). > >> > >> Requested-by: Andrew Cooper > >> Signed-off-by: Jan Beulich > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > > FWIW, I would be fine with just discarding the stride option if one of > > the phantom devices happen to report vendor/device IDs on the config > > space. > > Well, I thought I'd try a best-effort adjustment rather than simply > ignoring an option. > > >> --- a/xen/drivers/passthrough/pci.c > >> +++ b/xen/drivers/passthrough/pci.c > >> @@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct > >> phantom_devs[i].slot == PCI_SLOT(devfn) && > >> phantom_devs[i].stride > PCI_FUNC(devfn) ) > >> { > >> - pdev->phantom_stride = phantom_devs[i].stride; > >> + pci_sbdf_t sbdf = pdev->sbdf; > >> + unsigned int stride = phantom_devs[i].stride; > >> + > >> + while ( (sbdf.fn += stride) > PCI_FUNC(devfn) ) > >> + { > >> + if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) == 0xffff && > >> + pci_conf_read16(sbdf, PCI_DEVICE_ID) == 0xffff ) > >> + continue; > >> + stride <<= 1; > >> + printk(XENLOG_WARNING > >> + "%pp looks to be a real device; bumping %04x:%02x:%02x stride to %u\n", > >> + &sbdf, phantom_devs[i].seg, > >> + phantom_devs[i].bus, phantom_devs[i].slot, > > > > Can't you use pdev->sbdf here? > > No - sbdf was altered from pdev->sbdf (and is also shorter to use), > and for the 2nd item I'm intentionally omitting the function part > (to match the command line option). Sorry, should have been clearer. My question was to use pdev->sbdf for the second instance. I see now that you don't print the function, so that's fine. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 15:37:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:37:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322254.543508 (Exim 4.92) (envelope-from ) id 1nmdXh-0000YJ-3P; Thu, 05 May 2022 15:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322254.543508; Thu, 05 May 2022 15:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdXh-0000YC-0h; Thu, 05 May 2022 15:37:25 +0000 Received: by outflank-mailman (input) for mailman id 322254; Thu, 05 May 2022 15:37:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdXf-0000Xw-8C; Thu, 05 May 2022 15:37:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdXf-0000le-44; Thu, 05 May 2022 15:37:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdXe-0002Gz-Ka; Thu, 05 May 2022 15:37:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmdXe-0002cK-KA; Thu, 05 May 2022 15:37:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Syi74R34LRCqJsgRQqIZTIuNPFwfIbE0DahJnxKBCxU=; b=d/IJeq7O0Vn3fnpRQKiO7GZ/P8 M+ypu0cjuzjw/RYG8SCmdA9lcP7J65BQx8l62TB6fH97WEDp2HDyH+ihfOERvBHUgGsZK/TxkHExM ToIzJo92A77mSMlVyV7w1IiuX05SW2gbiQuWWgleb3w4Nc4MX1VkRnGlXYKsaJD9yPyE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170154: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 15:37:22 +0000 flight 170154 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170154/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 823 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 47 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 15:42:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:42:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322267.543519 (Exim 4.92) (envelope-from ) id 1nmdcJ-00020C-O9; Thu, 05 May 2022 15:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322267.543519; Thu, 05 May 2022 15:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdcJ-000205-LS; Thu, 05 May 2022 15:42:11 +0000 Received: by outflank-mailman (input) for mailman id 322267; Thu, 05 May 2022 15:42:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdcJ-0001zz-1W for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:42:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdcI-0000rJ-OY; Thu, 05 May 2022 15:42:10 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmdcI-0006QB-Hm; Thu, 05 May 2022 15:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Yg+jQsbbtK3mqpAwq5ielWTFuF24rFXyVtWodJ/+lsQ=; b=5cmqFXjCYad1JyJT9We5iKJWUb WCtzuPq4iuWIf0AupmBZtG+Hvgs+AuAW5YpANe314SqGERvAfoIl4Lh8rRU95R4w3hjK6AtpRBcrn tdIyyJG8C0iPIynbNDc1sUsjalJLXC7b5B1iYRHOPoGrprwEFYW+y7xMdk+oAiRE3P8M=; Message-ID: <19987e35-38c2-9ba3-43b0-ee8f13a07b06@xen.org> Date: Thu, 5 May 2022 16:42:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 04/05/2022 18:15, Rahul Singh wrote: > When Xen boots on the platform that implements the GIC 600, ITS > MAPC_LPI_OFF uncorrectable command error issue is observed. > > As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can > be reported if the MAPC command has tried to map a collection to a core > that does not have LPIs enabled. The definition of GICR.EnableLPIs > also suggests enabling the LPIs before sending any ITS command that > involves LPIs > > 0b0 LPI support is disabled. Any doorbell interrupt generated as a > result of a write to a virtual LPI register must be discarded, > and any ITS translation requests or commands involving LPIs in > this Redistributor are ignored. > > 0b1 LPI support is enabled. > > To fix the MAPC command error issue, enable the LPIs using > GICR_CTLR.EnableLPIs before mapping the collection table. > > gicv3_enable_lpis() is using writel_relaxed(), write to the GICR_CTLR > register may not be visible before gicv3_its_setup_collection() send the > MAPC command. Use wmb() after writel_relaxed() to make sure register > write to enable LPIs is visible. > > Signed-off-by: Rahul Singh Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 15:42:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 15:42:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322265.543530 (Exim 4.92) (envelope-from ) id 1nmdcf-0002SF-16; Thu, 05 May 2022 15:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322265.543530; Thu, 05 May 2022 15:42:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdce-0002S6-U0; Thu, 05 May 2022 15:42:32 +0000 Received: by outflank-mailman (input) for mailman id 322265; Thu, 05 May 2022 15:41:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmdc5-0001z2-FQ for xen-devel@lists.xenproject.org; Thu, 05 May 2022 15:41:57 +0000 Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e339b6c7-cc89-11ec-a406-831a346695d4; Thu, 05 May 2022 17:41:55 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id B02553F32465; Thu, 5 May 2022 08:16:14 -0700 (PDT) Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SEPHfPO_-W_I; Thu, 5 May 2022 08:16:14 -0700 (PDT) Received: from keithp.com (koto.keithp.com [192.168.11.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 18D4A3F32969; Thu, 5 May 2022 08:16:13 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id 4874D1E601B9; Thu, 5 May 2022 08:16:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e339b6c7-cc89-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1651763774; bh=O3aXJOWYxVTqOu3VmcXxOiZZOhMrUjqY/t6cXMT24+E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=M3zB+WUy+cYZq4HgtgtbfmLljWbRpIeJ5Zkg9r1D71YqvPlgOkiQ4tXheXCRGUa8+ RMuby4CqFAMCoPUIrwdzYTZDTf78io+RFFo6OcdGBDUFDZRaGhZfKKcTtwdj7WCFy4 6tn6om4NwF6owZoCYEHNTlN4dA5iODmOFbhrxNDmu4q/fHHXFfSRYzNqzWEthWHBp3 hB3E0o3k1G8NwFJfKh9rQpVZYZLwPg6CF6he0rk/+KFPQLpotGYN+CgB1L7QQOYecl ymeV9rACfLcKoB95CZdy6K628IEeM8t07ROlSN+X9O0IbQydzX/BQ3xj9k+MYZwzPf UxJC+uQh0iuJw== X-Virus-Scanned: Debian amavisd-new at keithp.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1651763773; bh=O3aXJOWYxVTqOu3VmcXxOiZZOhMrUjqY/t6cXMT24+E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=krSTvH+KcMYcsYiJs+brgDawkHD6ep7gtAt/7ImbSH+PVnVS6n5TIWQoiUP+PjBfQ TTV9zZEzFSNSLzQmSsEIJT24ancVfic/4tw1+i19H4UqIv2Soci174vL3i+L8WgOn3 3GAVx4Wwdu1vRPL7EVqx5qPLOOTreMDXIScBgNd+X5AcHfMZWw538tPrPoKpSSqHZH dCLZclbzdDsdQUL6m86l3cbny8WccVcefFqv7gslHwR8P3ZsfbW/X+4PLXD3hTeyro XMqcEagdrGN5NURX0L6R0oPpkf8LkkkUJo0DYZf6b68EQ+TuLV1TgvwIq/q3gwMiYO 4YgvEK7vCGplw== From: Keith Packard To: Johannes Berg , Kees Cook Cc: "Gustavo A . R . Silva" , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?utf-8?Q?G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?utf-8?Q?S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers In-Reply-To: <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> Date: Thu, 05 May 2022 08:16:11 -0700 Message-ID: <871qx8qabo.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Johannes Berg writes: > Yeah, dunno, I guess I'm slightly more on the side of not requiring it, > since we don't do the same for kmalloc() etc. and probably really > wouldn't want to add kmalloc_s() that does it ;-) I suspect the number of bugs this catches will be small, but they'll be in places where the flow of control is complicated. What we want is to know that there's no "real" value already present. I'd love it if we could make the macro declare a new name (yeah, I know, mixing declarations and code). Of course, we could also end up with people writing a wrapping macro that sets the variable to NULL before invoking the underlying macro... =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmJz6jsACgkQ2yIaaQAA ABGQAg/+NFgE01jSUQAsZc8G2KY9qfifpQ5rzrWtedUNXoOhcAo33tvPHnED0AxP Q4MXv/X4TRCTOD/5aBjZeKgy9I9G2jYbZq9iYf5uaD9zIECpE5XyznDZzo15cWBE B+W7olq9dqiARf6CuwNpYCjB8zv2ubR42c+faTCJNM63owpN9xpGT/7OEbE0HoKg TawmusqNU2nOkT82kjh1iVoK0BbmPSATiKkCH9ZpUVQYOQvsyieFtAlQREms/pip ccnHssDAaV1dgAg2NlKDzU30XA3rIIsfX+v3Bh+CWoj77Az7IO8+/V+nmNm5GHyy bs8LUQY3Z7/otHyGVfjVN9eU6LcEvstr7tOPLWxF0h+YxJk12uKhUZnmt4NisYrL uOcx/MC4y6tx9+kdn1U5KoV+O/ekhW/N/WwYcE6YUYZeol3Ahpve77B7uzLbwyOj TMLF83DtVqGLwl1y5mdKUfdeUeYhVMYo+eaq0ChKHdYdKj9ra2BaL1oiTc3lKqVW FdHX7C9qLA4LsTzfuDiEQDOrnwMDXhvtQrysTOjlQLIcivarCfxIKQw0co8Vubug sceCDXCr5qY2cCr51YqbDSVqEXK5Dos7IGlIyIlZH0YCktIbgOGTEPZDcidplXy2 LWWWFIK6Viz1AgjSRxRU24qmTbFCFLZdboKDuzsCHG8HDByLmNM= =BTwc -----END PGP SIGNATURE----- --=-=-=-- From xen-devel-bounces@lists.xenproject.org Thu May 05 16:14:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 16:14:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322280.543540 (Exim 4.92) (envelope-from ) id 1nme74-0006OX-HS; Thu, 05 May 2022 16:13:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322280.543540; Thu, 05 May 2022 16:13:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nme74-0006OQ-En; Thu, 05 May 2022 16:13:58 +0000 Received: by outflank-mailman (input) for mailman id 322280; Thu, 05 May 2022 16:13:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nme72-0006OK-Nr for xen-devel@lists.xenproject.org; Thu, 05 May 2022 16:13:56 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cb0a44e-cc8e-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 18:13:55 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id u3so6775726wrg.3 for ; Thu, 05 May 2022 09:13:55 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id n13-20020a056000170d00b0020c5253d911sm1595572wrc.93.2022.05.05.09.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 09:13:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cb0a44e-cc8e-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=0i9RkkeLX/a8FzO4tLn2BkIX5lR98eNO9g+/uG49UQE=; b=TFfCLhoxYT56Nn3x7jCyVrlcC07sWTbmQD1AANF/ehbQxFzjKfx9p0RhCXiQ9vZATC vT5nje7UrDRvgKIr44wPnSwPQG+pY1XmJFE4xlRE/mevmlBZUcwA4wvh3YOS0sW8jD01 RkyB1FsNIQX4gNXT/Lf6truNDyI/Weeenh7pNiIH3v48Wa1mIvHKXHJW8gTMaiplaplb Mlyp0zQn+e+A3PxkBqku7eWW5U9iGPWxfYsQplvI6Qe8UCk8ZRUyV6G8IoIU7oOphOC7 WMz7KJEMFeVpjJNnuVAHWTpqXMQlRlBpiphHq//udnTragjcHo48ZNDk4aPxXFEQHL6i QTIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0i9RkkeLX/a8FzO4tLn2BkIX5lR98eNO9g+/uG49UQE=; b=aT4C8JXT0RPs2X+CA/InrhzkvT6zxAHOMJ2i1eyjfOvCqYZUVE61DRJ+oya/3Pog65 I3Mylxl4d/LJdgg74KfWBanzY/nQphOvrVeQQxSmkCihg8yvwjrP6fyc3CfpYtcVpDFi hqDcDivk5MwsL9pSwY+uCoFPeK9YkXwHVZY94OQUFS3yjtht4k7AsUvy/a6S1n8qcpyb a6UXnhfpNM2GG+DfjR375MnaiibUju7sJ9cNmG4qTf4VlB1uHoMmUGfdRtsJsfkd7Ni0 B1GLJhGO2lJe772IZ+8f5brpkjPrW3GKac17oe3ZRas4QMnA4btbExgs/O/L5FHzPKFo dnkQ== X-Gm-Message-State: AOAM533oeP8Eb8ZO2UTjlP3/vtUIsw6oFAv2892OwnQKR38Xnk0Ina+S pmG2IgLS/2XlDmVYngPvY58= X-Google-Smtp-Source: ABdhPJwN1Z2UQzvnntlWy/amZSNuSoBj/nJlFK1rINxD93dAb5bOGKvY2oKNVEC6Zjj1GuDmcVJhpg== X-Received: by 2002:a5d:680f:0:b0:20a:d858:f703 with SMTP id w15-20020a5d680f000000b0020ad858f703mr21357176wru.414.1651767234914; Thu, 05 May 2022 09:13:54 -0700 (PDT) Subject: Re: [PATCH v3 0/2] kernel: add new infrastructure for platform_has() support To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig References: <20220504155703.13336-1-jgross@suse.com> From: Oleksandr Message-ID: Date: Thu, 5 May 2022 19:13:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220504155703.13336-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 04.05.22 18:57, Juergen Gross wrote: Hello Juergen > In another patch series [1] the need has come up to have support for > a generic feature flag infrastructure. > > This patch series is introducing that infrastructure and adds the first > use case. > > I have decided to use a similar interface as the already known x86 > cpu_has() function. As the new infrastructure is meant to be usable for > general and arch-specific feature flags, the flags are being spread > between a general bitmap and an arch specific one. > > The bitmaps start all being zero, single features can be set or reset > at any time by using the related platform_[re]set_feature() functions. > > The platform_has() function is using a simple test_bit() call for now, > further optimization might be added when needed. > > [1]: https://lore.kernel.org/lkml/1650646263-22047-1-git-send-email-olekstysh@gmail.com/T/#t For both patches: Reviewed-by: Oleksandr Tyshchenko Also I haven't faced any issues with testing current series (w/ and w/o xen-virtio series [1] applied) in Xen guest (Linux v5.18-rc4) on Arm64 based board. So, you can also add: [Arm64 only] Tested-by: Oleksandr Tyshchenko Thanks! Note, I reworked patch #3 [1] to use new platform_xxx functionality: diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 07eb69f..1f9c3ba 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -443,6 +443,8 @@ static int __init xen_guest_init(void)         if (!xen_domain())                 return 0; +       xen_set_restricted_virtio_memory_access(); +         if (!acpi_disabled)                 xen_acpi_guest_init();         else diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 517a9d8..8b71b1d 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -195,6 +195,8 @@ static void __init xen_hvm_guest_init(void)         if (xen_pv_domain())                 return; +       xen_set_restricted_virtio_memory_access(); +         init_hvm_pv_info();         reserve_shared_info(); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5038edb..fcd5d5d 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -109,6 +109,8 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc);  static void __init xen_pv_init_platform(void)  { +       xen_set_restricted_virtio_memory_access(); +         populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));         set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info); diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 313a9127..a7bd8ce 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -339,4 +339,15 @@ config XEN_GRANT_DMA_OPS         bool         select DMA_OPS +config XEN_VIRTIO +       bool "Xen virtio support" +       depends on VIRTIO +       select XEN_GRANT_DMA_OPS +       help +         Enable virtio support for running as Xen guest. Depending on the +         guest type this will require special support on the backend side +         (qemu or kernel, depending on the virtio device types used). + +         If in doubt, say n. +  endmenu diff --git a/include/xen/xen.h b/include/xen/xen.h index a99bab8..0780a81 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -52,6 +52,14 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,  extern u64 xen_saved_max_mem_size;  #endif +#include + +static inline void xen_set_restricted_virtio_memory_access(void) +{ +       if (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain()) + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); +} +  #ifdef CONFIG_XEN_UNPOPULATED_ALLOC  int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);  void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages); (END) > > Juergen Gross (2): > kernel: add platform_has() infrastructure > virtio: replace arch_has_restricted_virtio_memory_access() > > MAINTAINERS | 8 ++++++++ > arch/s390/Kconfig | 1 - > arch/s390/mm/init.c | 13 +++---------- > arch/x86/Kconfig | 1 - > arch/x86/mm/mem_encrypt.c | 7 ------- > arch/x86/mm/mem_encrypt_amd.c | 4 ++++ > drivers/virtio/Kconfig | 6 ------ > drivers/virtio/virtio.c | 5 ++--- > include/asm-generic/Kbuild | 1 + > include/asm-generic/platform-feature.h | 8 ++++++++ > include/linux/platform-feature.h | 19 ++++++++++++++++++ > include/linux/virtio_config.h | 9 --------- > kernel/Makefile | 2 +- > kernel/platform-feature.c | 27 ++++++++++++++++++++++++++ > 14 files changed, 73 insertions(+), 38 deletions(-) > create mode 100644 include/asm-generic/platform-feature.h > create mode 100644 include/linux/platform-feature.h > create mode 100644 kernel/platform-feature.c > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 05 16:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 16:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322288.543552 (Exim 4.92) (envelope-from ) id 1nmeDL-0007sq-Ap; Thu, 05 May 2022 16:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322288.543552; Thu, 05 May 2022 16:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeDL-0007sj-80; Thu, 05 May 2022 16:20:27 +0000 Received: by outflank-mailman (input) for mailman id 322288; Thu, 05 May 2022 16:20:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeDJ-0007sd-Al for xen-devel@lists.xenproject.org; Thu, 05 May 2022 16:20:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42dbb5a8-cc8f-11ec-a406-831a346695d4; Thu, 05 May 2022 18:20:23 +0200 (CEST) Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 12:20:20 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CH0PR03MB6068.namprd03.prod.outlook.com (2603:10b6:610:bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 16:20:17 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Thu, 5 May 2022 16:20:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42dbb5a8-cc8f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651767623; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+m8VIJ+tfKH9iLdbUemtpwqiQFJXXARDYXyksSgNkGs=; b=e67wl41tAwwvSDZqj1BfmxmTn9cQQ9dhAV38n32ZmgCV4o430upKp+kP /4D0UROKP9UhCJDF/X9c5/QXKDefElswFkZ/Bo0srXW31ZUzK7QbwZ3r5 eYACFC7M3NOwbBrvjItyYTJlDtXEK3kOdB2A8a1Zo6k8ns6tziMhjm0Qw U=; X-IronPort-RemoteIP: 104.47.58.170 X-IronPort-MID: 70666300 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kzQO/ax+Nl+YUwTGJvd6t+c7xyrEfRIJ4+MujC+fZmUNrF6WrkUDx mofCjyAPPyJYDTxedkiYIWz9R9TvpaDz4VkQAs9/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12YXhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl9sD3VjwNApL1uvUPeTBxLgsuMaBN5+qSSZS/mZT7I0zuVVLJmqwrJmdmeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeE+OTuocwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2MG9gnN/cLb5UCJzhVj0KnCOeGIa9etX+lNtF2B+ XPvqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsH0QhmQsHOC+BkGVLJ4EOAk6QfL1qvd5S6YAHQJSnhKb9lOiSMtbTkj1 1vMldW5AzVq6eSRUSjEqe/Sqi6uMy8IK2NEfTUDUQYO/9jkpsc0kw7LSdFgVqWyi7UZBA3N/ txDlwBm7517sCLB///TEYzv6950mqX0cw== IronPort-HdrOrdr: A9a23:Z5mB/qqMIty8Afj+kYuH5MIaV5uiL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCDwqhoPRPAh3Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegx2w 2LCNUtqFh0dL5mUUtMPpZ+fSKJMB28ffvtChPlHb21LtBPB5ryw6SHkokd1aWNRKEi6qcUtd DobG543FRCDn4GT/f+kaF2zg== X-IronPort-AV: E=Sophos;i="5.91,201,1647316800"; d="scan'208";a="70666300" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xk3Yae5ndyH8TyThio8szDecTUJOtAa6IjLtOIEyvObCn7hH3g3ioABr952m/8gRxJWb+AePMQjb6wfpJbFx2d5RAHWiR4xL+trk4qRqFjdib8Hqc+sfLhp4odOCxraltZc/tvtJQEBLFOAmuXdbVXMTtvK42tMXILDUlbYMsz3Hfsa8Y30SVCvaRW9aC6yIyokLmnnd9bSBLWWaLQh8iqqp4I2tVZcqOPbO07RNrvuvL4zvktXMrkUkjFygbjyrFgP3Im37+t4HWJSqHYZXRqO8k1rS6czWkIbyxS9dO3eSqxO4n61WHKeu/Hd4jqQY+Fhi9gHQ7qudRsZfaUXTtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qtbwLlmC0gqFVaUF7zwbjie0H2D9NdUOa+5LdUby7xs=; b=ebT959TuTFy/YtKBjTh6IF50WPblHK0mwZnAqNX2MHLUPJlm8VA8FN3tDHLXVNXDthUI626wfW+n2KYOX+uJAExGSCcWcLddNPTipfSHDM+oO5FqUNYXTwD67cK6E94ujn7j4607W8od3W1Yfc/+rJL7Mx1mN84Ob1kDQn6tc1Xjn/IMIGFPk0AD0B21sOw8oI/6t4D2XwWPBdrOGH3eudt49kYjCum+vpZarat9d0iHsuNMGL40kSblnqLESwREcSU2rPBs8mPxDelRsZ8VeBLxBahjJr8hwLeo/NOiLlYBJBb1bovorxX3TZzVVrshHwOfIB54fZN6VkV11LwoKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qtbwLlmC0gqFVaUF7zwbjie0H2D9NdUOa+5LdUby7xs=; b=FYNegkgMp/D5PAiTWSHRMATaRpvOT4PPNCgtv4SO9cy8YLoF8C2W1maVCzG/+9N7bZApKGR1IMFO5RHeZPX9uMAi24Ki7hMWSRMRYRH5v/hfCjc+eLfLK3k0fV/vjFhrK7kdNp4kPui9byMupWK5Xo151es2Qd2X3TcouHbBLxY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 5 May 2022 18:20:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 11/21] VT-d: allow use of superpage mappings Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0316.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6adad69-9e0a-4c89-a43f-08da2eb32467 X-MS-TrafficTypeDiagnostic: CH0PR03MB6068:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 73SSyg8ARZNwjOaZxvEc1nYddDS1r0geCLHWtWKFxZbBS4yF+oJpvhYuGF53ZMUMbvCKPujGYS3mr3tErjkOqDMP9e51Umqn8f90RWSO7Dn9aZsT/X/cnR9/x6hiB/YRphzMzB4XGiB2Ct5B8wSQLqOZ8iKRRMf7HYivZS2X66ra5JUbe6MrgO3Lhnb8uAMfRxsn1X4KN4qvZD2vEBY7p1gbw+W98s4VX41r3TdrlJHSCpPYpdptFAds88a92G13qG0ZcprSNeCHAL5XdVYDWDnMyuCOB0uWMPfyYhg8fP/pg1moRlelu6tPz7Y0W2n5qjjkOgQzs4D02dbW5rvFcIem+LtQkOT5HIJVaPgyrqO4C0SmG+et2epqOtejPQvF5E/B2EqLe3Ex9PgsbO8vR0I0Bx/u8NorASb8kq1oKqVubR49Z6NmYnAitoERXb1dlf3GhcxYHb3xiYPDiCDlfL4cFHX9P3x1z1rVaJVHAEnWjZ7881iE4oczdNkdo/XWe7AjBIywNj/gDSH4iZiIMw9BV725gX74M96Hwo7wkzZrguzjYwqKMbgsutaXWe1XMQhCGBsj9c1hbBlmhVG05fohPPfzNyPPKxzyOzNLiLJu4EmdDsbBftfgko/V3i3Sm/gUDJdQ9VGjjwdbPkFk/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(316002)(2906002)(4744005)(6486002)(38100700002)(8936002)(6916009)(54906003)(5660300002)(508600001)(26005)(66476007)(82960400001)(4326008)(66946007)(66556008)(8676002)(86362001)(6506007)(9686003)(33716001)(6666004)(186003)(83380400001)(6512007)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHRVQWMySk1ZNWVFMml5NTdJaERmNmtoZERCSGU5d2RrbXZ1WmlONERyVVg5?= =?utf-8?B?T3RNZmlGcHRtb0NIY0lmNzA1Rm9sd0pYamtCQ1VtdmM2UU1yRXVGM0JRQTJG?= =?utf-8?B?MDZ6WU41cVN1c2dxY3B6T2E5bXZ0NkFKUG1sbjA3NHVNSC8yc2phRHpsbldC?= =?utf-8?B?TjBudEFrdG9MUVVSeTBPci90SkhTVC9VL3hVenhoZVdGR2JzSDMzZlQ4Y3Zs?= =?utf-8?B?MitIZW1WaWNoaWM1Zkd1RTV4NWxoTzFZaS9aTmkzUmNTUzdpQmxSdGJZWCtk?= =?utf-8?B?aXpJcS94eUM5TVEvaUdJeUtWeG5Ea1FwSDRkL01MT1FmaWpWbmk2dS9lUUFZ?= =?utf-8?B?N09ETXV0SHExUFlSeTJyenJ2NXBPUTdmY2crYldaUm1sOC9HbHNQQUFaOFg3?= =?utf-8?B?eEdUUzFTWWNkbkZyTnRQbTVqQ2Z4M2phaEdYR1VOYTd5S2JqTnFYY0xPSm1J?= =?utf-8?B?VlJsOEFyOTQzZEIzNjVRY3VpRVRvQkxSeHZiUHdVM1ZQRWovOXdQa2NMWmk1?= =?utf-8?B?aGUzaEcwMkVEOEppWkVmVkg3WXZQeGJBaHJYQ2dSb3pmZHdFcm1BU1lvNFQr?= =?utf-8?B?bUsrcFBNYUFtQjd5b2hWSUk1Si9KU2dBVW05MUVYM3NzSDYrOXcrbExqMzhJ?= =?utf-8?B?UStjSFdSWERxMTdrOFZHZnVwVUM0a0dKQ1hPMDdmQTZveGhMU2krdlY2cXIw?= =?utf-8?B?SThiaXl5OVU4cUVFU0JQc3JSbUNpanNsTDBjcVJHeGlQbkhTVDR4cGJha1dI?= =?utf-8?B?M1h2R1VINnhyaVpuVVMvREFuYk5sZWNiZ3ZZKzhoTzQxL21ocnpKc0JuU0lG?= =?utf-8?B?bkFLcGMyRDQ4Nmx3anRDbVVIbStNMW1zeUs3TDlucHlHeXlKSGhvbUpwK0Ez?= =?utf-8?B?Qk15V1BwOXRmcXBQS2tVZHBhdkVMeWVTbys2YTNmSlBZanNOSE1EU1owYzJn?= =?utf-8?B?YkpNVU8xcElrY1FKUS9SRUlMa3A1bHZ6YjV5Z004b1pWckNIOGVGUEg5OEQ1?= =?utf-8?B?YXYvcGNINzNUbnR3QSsreURTUWNnMWo0NGpiRmxKSDAraGszc2t6aWx4aW9S?= =?utf-8?B?UllCUzVCTTMyQTQxWHFFeTBudUxkcTRpYVM1VGVtLzR1TktKWDdYaCszM1hN?= =?utf-8?B?bTFyZEU3LzNYMS9TZmZzb2ZpOVNnSGkzdmN2ckduQnZLczBobWYwVjhWQUNP?= =?utf-8?B?NjJpTTBxbE91aTdqWGFabWVDQTZNb1NBajdXZ2hxRFJTS1B6QmxNWmRWMjRx?= =?utf-8?B?bHliaEJIRFZ6ck4vV2tLdzJJQVBuaUtGNi9zbS9CZ3BlTW9VbHQvdDhKd3hE?= =?utf-8?B?cCtZS2pSQ1VNeHQxRVIyOFh6T2g0WFN4K1R3L0FVN0Fid3pCTWtmUFlybTJ1?= =?utf-8?B?RDVtNXhtamFNSVIxdG94TzhKelV4dGtHWXZlZ3RybkR4dXA5WmJzd1RiMmtT?= =?utf-8?B?alExMU1DWUZzYWZSQVZUSUhrKzQvQllBeFZ5V2VQVVhBN1d2NjdEcWF1RnhO?= =?utf-8?B?S0lsUjRVNkJqRmpHckIxa0RjaDhNUS8xN0lCK0lheWxJMlRZN3NtSC9kRHZY?= =?utf-8?B?eHp6cll6VVh4OEhQMVhhK2Q1eHN2ZERwbVJOQnFCaTFVRHdmT052a2ltQXFG?= =?utf-8?B?L29QMkFRdW9jbEIwdWhVTGJMOXpPMDd1SFpMNFZEQWRqbFRWditHOFB6VUhW?= =?utf-8?B?K2N1Y2lITFdLYXJGT2tQMzYrL3NhSkNVbjR1M3hCMVhpTUlDMjZzcmZndFN1?= =?utf-8?B?Q2NZbGtuc0FqYVZMbE9GbnpMQlErSHZDMkU3ZVpHY3Y5MVIvTnE3eW1tbW9N?= =?utf-8?B?NWhkcjVxMGZielM2OEpOZy90TlNmZS93UTVDTDMvS2pPc0w1Z0RKMERPbTM4?= =?utf-8?B?b0VKa0l4bDlWOTIrU3U0dlR1U3VBM09VUHZidi9EU05pNXEvSXg0VUVLNEpy?= =?utf-8?B?clkyRFR4K05oTnZnWktxWm9Jb3l5c0haMnMxR1NTcG9lZGpXTWV2M3psZkUz?= =?utf-8?B?Z3Nmbm5HYjV0amxoYjNSZHdJWjRlMnEzSEF1eDJ4L29qQUl4VVhOM1hpdmM3?= =?utf-8?B?ZXdrYWI2MlE4TXA4VTJKdytBUXE4amp5VUtyem8zL3BLbEpBUUNmbmlCa1NK?= =?utf-8?B?UTZ3dFpzU0h2bnJBL0FhVVo4Mm5wNVM0ZFB6R3Y5NXA5UmtxRUMvY2dyUGN5?= =?utf-8?B?NGhSM2VlT3hMQ0xZN1lUb0JNOG9iblVRY1FtbzU4QlJKR0FTZ0dVMVg3UkZz?= =?utf-8?B?dXl0c3RONG5GeVJuQlVlL2J4UW52T2IxYjB0clhuTk1OTHFNblE2S1RFdmhI?= =?utf-8?B?V0l2QmVtTHN2c2QvazdaMnJpMU1yaFZ3VXBVWlpFL1hOSWdzT0FQN1VTMlpD?= =?utf-8?Q?3OAhIqrhvTaBHSAo=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6adad69-9e0a-4c89-a43f-08da2eb32467 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 16:20:17.2704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eXwc/nEUf7N/HRRhIzK/8xX8PWqCbFAHaKZ1Vb6DzD54MvstKJZ3+t1WFguChNE/5CzDYGTRYkj9QUBG2gKSsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6068 On Mon, Apr 25, 2022 at 10:38:37AM +0200, Jan Beulich wrote: > ... depending on feature availability (and absence of quirks). > > Also make the page table dumping function aware of superpages. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Might be interesting to also add an assert that the passed order matches the supported values, like requested on AMD. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 05 16:35:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 16:35:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322296.543563 (Exim 4.92) (envelope-from ) id 1nmeRR-00010i-Ip; Thu, 05 May 2022 16:35:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322296.543563; Thu, 05 May 2022 16:35:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeRR-00010b-Ew; Thu, 05 May 2022 16:35:01 +0000 Received: by outflank-mailman (input) for mailman id 322296; Thu, 05 May 2022 16:35:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeRQ-00010R-ST; Thu, 05 May 2022 16:35:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeRQ-0002Hn-RI; Thu, 05 May 2022 16:35:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmeRQ-0004xt-DI; Thu, 05 May 2022 16:35:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmeRQ-0007Lk-Cn; Thu, 05 May 2022 16:35:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yhbCtz9jQuqM0krOxhaqpoVUOqM0x/Cl81tWb32lG4A=; b=5jqzVcjfT8n09sm49YRFgjUJkZ oo3OQziT/nas6wi89bHf1XKAIyDWUa5tIXZtE41YkBbg3+/GfXeXSgStL5esS/a59e9B42Zv1pknH jDxvFNTnIRQMWDYymOFcgCpexIWfrAVqZvOnFy/MUdjr6+7zfcL+JhDVsGMcWtkEB0N0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170155: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 16:35:00 +0000 flight 170155 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170155/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 824 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 48 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 17:19:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 17:19:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322305.543574 (Exim 4.92) (envelope-from ) id 1nmf7u-0005FU-S5; Thu, 05 May 2022 17:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322305.543574; Thu, 05 May 2022 17:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmf7u-0005FN-PP; Thu, 05 May 2022 17:18:54 +0000 Received: by outflank-mailman (input) for mailman id 322305; Thu, 05 May 2022 17:18:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmf7t-0005FH-W0 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 17:18:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmf7t-00033f-0Q; Thu, 05 May 2022 17:18:53 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.17]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmf7s-0000u5-Pm; Thu, 05 May 2022 17:18:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vV72h4zKeNStGZHPCXEaQRJ7zTKqQ6FLw2y+SXdYZW8=; b=igzd5EnK5F+wO7qjd+69zMiAMX zjBzH2BK1Dwsf4g2jCueP+migbJrGYz2j+/46wXpVL7PhwTIBNv+8WOtlEx3W8+GL1z+YSUzItduK PRnMAPXZigKFWSIvEwlH9lJuwJNg686dCZ4SKFwgxcd+vdjUSmzn7rOlYEH2oxT1xuKk=; Message-ID: Date: Thu, 5 May 2022 18:18:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] bump default SeaBIOS version to 1.16.0 To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <58aad4ba-af15-0189-5336-698aadfcf905@suse.com> From: Julien Grall In-Reply-To: <58aad4ba-af15-0189-5336-698aadfcf905@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 27/04/2022 11:55, Jan Beulich wrote: > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 05 17:51:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 17:51:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322312.543584 (Exim 4.92) (envelope-from ) id 1nmfdb-0000t1-FJ; Thu, 05 May 2022 17:51:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322312.543584; Thu, 05 May 2022 17:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmfdb-0000su-Cc; Thu, 05 May 2022 17:51:39 +0000 Received: by outflank-mailman (input) for mailman id 322312; Thu, 05 May 2022 17:51:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmfdZ-0000sn-Kb for xen-devel@lists.xenproject.org; Thu, 05 May 2022 17:51:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmfdY-0003ax-T4; Thu, 05 May 2022 17:51:36 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmfdY-00032l-Ie; Thu, 05 May 2022 17:51:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=G739xfSEhj+8itXA1Tf1a5FxiO1AuRF+za7m94KqYVE=; b=jcFXk0 SROVch46PQ0OqT+u8Y6Loj5WVzR3QlCY6PW0RCkPk7amm8fPqKPsHIlcRfQylMXQYD2WQYlvn6tUQ DDKAvKprBq3zupeBIM6rQCa66l86K7zQqeVn1/OqkIwXwAeLZMbbPotnExs3Fh52lr/agRFdUxR3M HiCYYRtVamI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH] xen: io: Fix race between sending an I/O and domain shutdown Date: Thu, 5 May 2022 18:51:31 +0100 Message-Id: <20220505175131.81457-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint where the expectation is the domain should continue as nothing happened afterwards. hvmemul_do_io() and handle_pio() will act differently if the return code of hvm_send_ioreq() (resp. hvmemul_do_pio_buffer()) is X86EMUL_RETRY. In this case, the I/O state will be reset to STATE_IOREQ_NONE (i.e no I/O is pending) and/or the PC will not be advanced. If the shutdown request happens right after the I/O was sent to the IOREQ, then emulation code will end up to re-execute the instruction and therefore forward again the same I/O (at least when reading IO port). This would be problem if the access has a side-effect. A dumb example, is a device implementing a counter which is incremented by one for every access. When running shutdown/resume in a loop, the value read by the OS may not be the old value + 1. Add an extra boolean in the structure hvm_vcpu_io to indicate whether the I/O was suspend. This is then used in place of checking the domain is shutting down in hvmemul_do_io() and handle_pio() as they should act on suspend (i.e. vcpu_start_shutdown_deferral() returns false) rather than shutdown. Signed-off-by: Julien Grall ---- "paused" is not quite the right word in the description but I haven't found a word that would avoid to tie the problem to shutdown only. --- xen/arch/arm/ioreq.c | 3 ++- xen/arch/x86/hvm/emulate.c | 3 ++- xen/arch/x86/hvm/io.c | 7 ++++--- xen/common/ioreq.c | 4 ++++ xen/include/xen/sched.h | 5 +++++ 5 files changed, 17 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c index bdd536e873e5..1338c86adb43 100644 --- a/xen/arch/arm/ioreq.c +++ b/xen/arch/arm/ioreq.c @@ -92,10 +92,11 @@ enum io_state try_fwd_ioserv(struct cpu_user_regs *regs, p.data = get_user_reg(regs, info->dabt.reg); vio->req = p; + vio->suspended = false; vio->info.dabt_instr = instr; rc = ioreq_send(s, &p, 0); - if ( rc != IO_RETRY || v->domain->is_shutting_down ) + if ( rc != IO_RETRY || vio->suspended ) vio->req.state = STATE_IOREQ_NONE; else if ( !ioreq_needs_completion(&vio->req) ) rc = IO_HANDLED; diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index e8d510e0be91..cb221f70e8f0 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -236,6 +236,7 @@ static int hvmemul_do_io( ASSERT(p.count); vio->req = p; + vio->suspended = false; rc = hvm_io_intercept(&p); @@ -331,7 +332,7 @@ static int hvmemul_do_io( else { rc = ioreq_send(s, &p, 0); - if ( rc != X86EMUL_RETRY || currd->is_shutting_down ) + if ( rc != X86EMUL_RETRY || vio->suspended ) vio->req.state = STATE_IOREQ_NONE; else if ( !ioreq_needs_completion(&vio->req) ) rc = X86EMUL_OKAY; diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index f70bfde90143..0309d05cfdfc 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -138,10 +138,11 @@ bool handle_pio(uint16_t port, unsigned int size, int dir) case X86EMUL_RETRY: /* - * We should not advance RIP/EIP if the domain is shutting down or - * if X86EMUL_RETRY has been returned by an internal handler. + * We should not advance RIP/EIP if the vio was suspended (e.g. + * because the domain is shutting down) or if X86EMUL_RETRY has + * been returned by an internal handler. */ - if ( curr->domain->is_shutting_down || !vcpu_ioreq_pending(curr) ) + if ( vio->suspended || !vcpu_ioreq_pending(curr) ) return false; break; diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index 5c94e74293ce..4617aef29b7e 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -1251,6 +1251,7 @@ int ioreq_send(struct ioreq_server *s, ioreq_t *proto_p, struct vcpu *curr = current; struct domain *d = curr->domain; struct ioreq_vcpu *sv; + struct vcpu_io *vio = &curr->io; ASSERT(s); @@ -1258,7 +1259,10 @@ int ioreq_send(struct ioreq_server *s, ioreq_t *proto_p, return ioreq_send_buffered(s, proto_p); if ( unlikely(!vcpu_start_shutdown_deferral(curr)) ) + { + vio->suspended = true; return IOREQ_STATUS_RETRY; + } list_for_each_entry ( sv, &s->ioreq_vcpu_list, diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index ed8539f6d297..6b724e7947c7 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -159,6 +159,11 @@ enum vio_completion { struct vcpu_io { /* I/O request in flight to device model. */ enum vio_completion completion; + /* + * Indicate whether the I/O was not handled because the domain + * is about to be paused. + */ + bool suspended; ioreq_t req; /* Arch specific info pertaining to the io request */ struct arch_vcpu_io info; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Thu May 05 18:23:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 18:23:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322320.543596 (Exim 4.92) (envelope-from ) id 1nmg7h-0004IL-VY; Thu, 05 May 2022 18:22:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322320.543596; Thu, 05 May 2022 18:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmg7h-0004IE-Sd; Thu, 05 May 2022 18:22:45 +0000 Received: by outflank-mailman (input) for mailman id 322320; Thu, 05 May 2022 18:22:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmg7h-0004I4-2u; Thu, 05 May 2022 18:22:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmg7h-0004G0-0V; Thu, 05 May 2022 18:22:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmg7g-0004m4-Ju; Thu, 05 May 2022 18:22:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmg7g-0002y4-JT; Thu, 05 May 2022 18:22:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ta4y79WxiuFWECp9UmX9CyAOhbFKGnD/X7PS/nkik3o=; b=H5DOwl+Ythg9YNAx0nb/vGS5U3 BFYVVMNDxH6/WCm6T0MoT32F9VPtKfhMIs4SBprDppMQkZ/i7zE7ctuip81VT1lb04ktEQjnT1f8r Z3AIGd7Vi4lQoAooii0nm9+iDv8MamjmfW/aHyDDmfD6BUikDmt9qWcQK/wngiNJpb/U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170156: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 18:22:44 +0000 flight 170156 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 825 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 49 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 18:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 18:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322331.543606 (Exim 4.92) (envelope-from ) id 1nmgaI-0007Yq-Cp; Thu, 05 May 2022 18:52:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322331.543606; Thu, 05 May 2022 18:52:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgaI-0007Yj-9k; Thu, 05 May 2022 18:52:18 +0000 Received: by outflank-mailman (input) for mailman id 322331; Thu, 05 May 2022 18:52:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgaH-0007YZ-50; Thu, 05 May 2022 18:52:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgaG-0004m2-RO; Thu, 05 May 2022 18:52:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgaG-0006rj-D2; Thu, 05 May 2022 18:52:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmgaG-0008Pb-CW; Thu, 05 May 2022 18:52:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AoP4bGbDeVQvVXSgHgka4158QemM/ugXP9dTVNGmXTw=; b=0JSFkN84UD8oUrTouU0+/68ah3 IY3Y2k5gIiq0HZsvNNK0V1rzRiDYBPOqyBWs9Kh0GCGK8z9vz/IUYAybLvfEMi98xaib98hQIq1XQ B7JgZ7Uw0gABkh6wqqqoc/zgS+UMidqtA8EeLLhHTQqtOcc/jYZAawXQ/VuD7d+xmUuU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170153: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 X-Osstest-Versions-That: xen=c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc From: osstest service owner Date: Thu, 05 May 2022 18:52:16 +0000 flight 170153 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170153/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 baseline version: xen c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc Last test of basis 170146 2022-05-05 11:00:26 Z 0 days Testing same since 170153 2022-05-05 15:01:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c1d5e4021c..90ba9a2da2 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 -> smoke From xen-devel-bounces@lists.xenproject.org Thu May 05 19:10:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 19:10:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322342.543618 (Exim 4.92) (envelope-from ) id 1nmgru-0001ZA-0g; Thu, 05 May 2022 19:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322342.543618; Thu, 05 May 2022 19:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgrt-0001Z3-Tx; Thu, 05 May 2022 19:10:29 +0000 Received: by outflank-mailman (input) for mailman id 322342; Thu, 05 May 2022 19:10:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgrs-0001Yw-7B for xen-devel@lists.xenproject.org; Thu, 05 May 2022 19:10:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03f3dc03-cca7-11ec-a406-831a346695d4; Thu, 05 May 2022 21:10:26 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2022 15:10:22 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MWHPR03MB3277.namprd03.prod.outlook.com (2603:10b6:301:43::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Thu, 5 May 2022 19:10:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5206.027; Thu, 5 May 2022 19:10:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03f3dc03-cca7-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651777825; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KGA2hZsAl529ZEtCEJAY/LM2QSUI5YvIhNHixGn8xfg=; b=M9bzJ0T9PIChD7MckCpb1kr9o8pzAxqfhzJkWxwa7DjBTtz9sBK8sryp QV5hxnxfNaIxvf2p9uARkRBomPdCOxb3j/ItyFwOJ4RfSd+UWpS2wy3wW ekXvcfZA8zCPQ4bPl+MfGho5WqicAV+YZ5rpdEdIsY35JDQNv5Z2P7FPc I=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 70075686 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MOeEd6Pf7bqsW9fvrR3YlsFynXyQoLVcMsEvi/4bfWQNrUp30GRWz GAZXjiOO/aKYGf3coh3Otiy/UlSu8fXzNJjTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tMw3bBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7 dB0hKK7EV4TJKDoge0UAzl6NRxlMvgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHfWiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IA8A3I+/ppi4TV5FxM7OLIL8rQQ/mhX+NeuV63i EjD812sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVRxSlpFaUsxhaXMBfe9DW8ymIw6vQpgqcWG4NS2cbbMR87ZFmAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obu5jEpMVkcG wy3kRU= IronPort-HdrOrdr: A9a23:Qv+xhaFsyqAfhOd9pLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M= X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70075686" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMDv9m0LP2WsWR7QxHckYU/WRknZmswGk1LYqoRCSQ1gp6LNrReq4DF/rz5+w5DW0a2vSTuLBgeK15b3gk+OEN0i4G14S7S8FNYsbb7X1enTrqy2loPM4BuClhEI7wzdY35MegGzPQJmeTNx98iZJ8ZFzLlUTI2Y49YUT5hdIaBiVJaq1WZb72XnGlPhGRQiS80TXtMRtVNBvg92ex2Sl5wEnKnQq8E6e/5EPRwjY5fzEWu/98AbDY3ZMhboNtIx7lbR7m49SFagVh9D5cgPlQ8SIf7gvrVPh7KnU1Qj9KJMSAC/Q5I+fs1U5ueXYlgnS1sQBw5g0Eml0B6PqlCAog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KGA2hZsAl529ZEtCEJAY/LM2QSUI5YvIhNHixGn8xfg=; b=H3ebwcTRmEyaaBh4jE5h/EgDW1RHK7KE5jQ1lSX9LImRtsmYtcg75fLsNH0AaKNPWEdaCHxwEIElTtzsjnTXNY8WkXQelMXFZDGwlebhUUq6g8i1PVnDGb0u9G4IoTtobpexsaBLvlMlcHBfqlZ5VSc9H39HdnHThntWeKnhgbVR47a0UNFUaWWqTMzKbIQzikDMY9I6VgsRs02gtLMkoIow5ZjB2pEFWGW2ndvgWj63MdmAMtvFo7WLCK+rqfxuZVANCzgmVS95Kat+gv+cPQIhhCi3Wnm5gu3xE9tpLLFfnMNGA7T/DY/ylATE64rZ70c6iAQnMeUHJ6Hq+/7cVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KGA2hZsAl529ZEtCEJAY/LM2QSUI5YvIhNHixGn8xfg=; b=gbx8tMkJc4XwTgZ/2gW7rO+wBqGZ9y/jyTefWEQ4WStZhM0A4ZPoQ8DkgtnXbuxLy6L5VUu/5Wqp1XH43Yua+p7A3kw5C4xGRG69ilGkMxa7/4OgwHQzxyxpJumb5UdTJYoMvE5ErEf6xAH0YFIe7vJXU4ED0IN9HLCpFWySK/g= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Paul Durrant Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Thread-Topic: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Thread-Index: AQHYW8nVI0Vwkw76REOxFvedZ2w8H60Qr/GA Date: Thu, 5 May 2022 19:10:20 +0000 Message-ID: References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> In-Reply-To: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5cc228b9-7c00-483a-2f71-08da2ecae63e x-ms-traffictypediagnostic: MWHPR03MB3277:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZKUpuM1bDiGidm2C8j0+ynqTD5d1eCTXvTcuqMU9kBHNCCpDOuV6Eoozc1L2s4g5shuA9XAfxKAr56wWX8CDFXApdAWEi6Xbv4LwC4Tq7EY1U2dEgeStScLFk/6ITwRSBiB5KQZdCQuFuaO5AvHhFmu0ngofjBd+zdd+oSszyXUBpduoGh8/Ky805GMprsxwihS6K5BSojzR00QWPcd4+9KS2mTBmnAlCqvNRFfnfPplgvPvl5KmxxTVUZ8G8q06gb6vWL5J6BqEUWimV0dk1n9qfz0Yuk1s/Vpcma0Imf7SqJVB59tmJV3ptAo+cxc4gVe9/f6C9kaUng4ZKBeJGxpJfSvmSwqSd1UatPDSeCrdvOUUU1fk6nd7kaU3ALv8OHHu9nkUmZl5QWkc6/QOVAO+X5LDxzT71AtVOm+Pfucjeqo+i6PInRQmigp8hE0ieRd/CFvGvvdxMGX0BSoaJutwl2DSCEYayq8hbZAJw7Tp1SjsY5j5ZCx2aIvMK7x/Hoyics2+tQsfxZg8Nodh3zhoxlithvLwcKbvATcDTGIcEGFW+/s1WyVL3Hyv43+CR4kbwd6sXvZKZo6BB2D+wd/y71B9a+LO1iZoO3GvVT4yC01BqukVDug/sGNTWG7RvbporlGZ9xjycaS99gp6C1lxO4Wx80iyp6nDilrwpxq/yfeDrNSodr4cg5TNA5O9Cp/M2Sl2hqQv8tZOGNL43FIVZ8bjkQDCjhHFuVXVTR30C8rg5zCoYXacHEBM92iq207X5co2yDLycii4T5ISFw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(53546011)(38070700005)(110136005)(38100700002)(83380400001)(6506007)(2906002)(316002)(6486002)(508600001)(71200400001)(66556008)(2616005)(36756003)(31686004)(6512007)(8936002)(86362001)(186003)(26005)(91956017)(31696002)(5660300002)(4326008)(82960400001)(76116006)(8676002)(64756008)(66446008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N3Rhc01QNHpjZ1I0UG1XOTdIOC9ieWlsZFlSTkEvL1dRWDRmVUh3dnUxdWFy?= =?utf-8?B?SHM1RFBRcW95NUgvMktLNjAyQVlCU3NtVStMcFFicXUxODFmcnc0dk9KVXA1?= =?utf-8?B?aHhPUG5uaEtlOHYxcUY2Qk1mUCtmMWQ5QU5icTR4eHJlNmxDMTFLMCtyRnNZ?= =?utf-8?B?KzYxNTlKZFEweGZqNGY5TzNncDZtaGRvRkI4RUI2VUM5Q1pBbmd4UVVheURn?= =?utf-8?B?anZ6TDBtL1FsQStIaXRRdVd4RUtJcHZscEZvbjlKTXZqcjJDVXgrU2g4SFQz?= =?utf-8?B?N2RTVjNHcE9ONHlvOFVkWXdTVTltNVA1N25ZdWlhenhhR29HMFJweGVqSUwz?= =?utf-8?B?TkYyVWNMMm8zeGRyK1pGcTM4cWxRbWZuM3hOUUtpMWQ5RE5YZ0gycWNTdEtm?= =?utf-8?B?N25jZlJrb1E3SlF6dDY3MzlRWVpjeStXNE5kN2o5blFZNS93MTV4R2pnS01h?= =?utf-8?B?ZnZJRmh1aHhvSjJEL3RoR1J3V2VBQVBXNjlrOUJuZXNGMnpCTHN1ZWk5N1JV?= =?utf-8?B?MmlUWDVvdTVBYkU2SEpQM25tNUk4Ly80bWRCTXlWQk1WZlBwR3dnSTBPVzRy?= =?utf-8?B?MTljT3dwVmhZczFLY3I1cGtLTURzVk42aHVML3dCMVFVbGRPMmt0T3pRZ3cx?= =?utf-8?B?c3dTUnA3L2FpTEV4UDJ5dGxtVW9hNzhLQXhLWlBweE5xdGQ5RFk1VTZtSWli?= =?utf-8?B?QzBqOWw3eTBDdG5MRDA4dGVSL1BqMmk4WkhmTzVOYzBFNnNySXlVM3k3emJz?= =?utf-8?B?eHFYbE9SSXRDZk81MlpFUm9qWUs1bXRlN0U0cnRvK2U2K3h2aW9lSFVScDZq?= =?utf-8?B?SUtkYWdFRTJIMk5QNmF0cDJWWEVEWGtsQUphZzE1RGU4SXErL3NvbXZTTS9p?= =?utf-8?B?SHMwRFJSaFd5QXZwQTZXU1JXc2FWdWs0UTVsVWFMUnlXTmx6aVh6WEhMWGdJ?= =?utf-8?B?cllIMmxJRFVXM0dWZngvekVVakF4Um1ibzVtcnNwd051SmF1ZmtPRlhudCsr?= =?utf-8?B?MG0vb1BHRytXRFc1WGo5V1ViMlU2MUU2RHJJSW0wQXVUSHFra0VlTm9keXMy?= =?utf-8?B?TGkzZXYzbDd0RWtQWVNJQXo2U2hoY0t3UDRXQjJuRHNWVnByTkZqcFFGaVlM?= =?utf-8?B?MkZnTi9oemxzRE5lOHFjRE9BZ0l3bkI1OWlmMW95dXFvVjREWkpkb01QbUNH?= =?utf-8?B?VFlYWjRIR0xaR2VDQ3dDdDYwMEppOE13bXFva1R6OTc1RDFYSFN2RlluUXhL?= =?utf-8?B?YjhHVXUvT2psaWhZWU9HdE5SKyt6ZEhnOW5VOUlocGorUXExOExUMTJQeGZs?= =?utf-8?B?cU12VzI3SGZDZVdaYjUyb1lSNDdhRnV6c1hXUXdUZG1oZ09VNWVZL1hIZzlC?= =?utf-8?B?RmR0cXliaTNlUU5NQjVxWE9BZGJnSHBDWm5OdlllaGY1YkkyQWRiVUlzMGlU?= =?utf-8?B?bHp0S2Q2dUdaUzg2c0kybGRWdlVCam9wMmJySFlSZlE0OGIvYjZpdDVFb0Zt?= =?utf-8?B?eUROLzB6SjlqcWtwd2UydzBPK2p4VEVKczB4b0hmMVgvSUcvVUMwbnZTVmFk?= =?utf-8?B?eEFGQnJDRmc2b2sxcUJ3Q3F0SC9TbG03Rmpwb0ZhbVRCTVV5cnRSUU9ZM1dQ?= =?utf-8?B?WVhzQWlmNE4xMVk4VTZiVzRaYTY1M3BTZWNuaVJRdnNlbzVQc1p0VC9pbUUw?= =?utf-8?B?RHY0cEpDS3Z6b3lDUFVvK21pU21aLzVsUnhBMHliTDZBMnJKWWJrZFhsTWpQ?= =?utf-8?B?WGZLZFhrWDVlY3puWWtqYXhsMExidzNMb2RYSTlBYjdaVnN4RytMNkIwajVs?= =?utf-8?B?dElCamxVTEpqOGVLYXJIclRXQTNIWFZ1RVhPYnRzWU5qQVdvNlJpMGRwTUtr?= =?utf-8?B?MEZwQzQzYU1tR2VzQitOU1Q2UmpuM0JRbTlKM2FUY0NuWXlSOUNBTzEzSkNi?= =?utf-8?B?dzVVTHFZc1JxVWxYVXdwc3JWdGxtc3pFa1FKbkR5QnVkODErNVMzdGFQMzhN?= =?utf-8?B?ckVrb1ZpektRSytFTVRxY2laQ25zUUJzUmQ1aFQ1RXdDcUNoY1k3TXRha3lo?= =?utf-8?B?ZCtHWXArZDBGVFFEc05TLzZhVFZrZ1dpTi9jZE9rR0ZCVjNxNXVSWE53dW0r?= =?utf-8?B?NXVaTjh2VHNjZklwYVVpL3g2U2toaUJVTXBtbG1HQ2g5aUxEaXQwWXR5RVlh?= =?utf-8?B?T3NTMlU3VXA1NTdjb1NvZGEyU2pxZHdjL09hVnJJbnM4UFIycm1XTGZCdFlt?= =?utf-8?B?L2tnNU5XQUFCRVkzSmtUNVZjaWt0WjNQMllyUmk1eGdNdG4rYkViWkhYR0xy?= =?utf-8?B?REJPSllFWTV1eUEvZ2hGWFlIS3hoaTBYTExVTVlwamllaTJxOC9zeCt6UFor?= =?utf-8?Q?ky+Vx77NeBdNp14c=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <0FAB84B0FBF37D40BA7FD142BD3EF9E9@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc228b9-7c00-483a-2f71-08da2ecae63e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2022 19:10:20.7140 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d7YqBqq32QMUi+rd0/NXWs6XBqlth31snjnPmnyTYyUBIJ9TMqFGffzHg4QwR0tGVJOT/wWjNahYVy/S1dIi169pTDJHwBYk7V3s1vFXtZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3277 T24gMjkvMDQvMjAyMiAxNDowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl bnQgaXMgc2FmZS4NCj4NCj4gSU9NTVUgY29kZSBtYXBwaW5nIC8gdW5tYXBwaW5nIGRldmljZXMg YW5kIGludGVycnVwdHMgd2lsbCBtaXNiZWhhdmUgaWYNCj4gYSB3cm9uZyBjb21tYW5kIGxpbmUg b3B0aW9uIGRlY2xhcmVkIGEgZnVuY3Rpb24gInBoYW50b20iIHdoZW4gdGhlcmUncyBhDQo+IHJl YWwgZGV2aWNlIGF0IHRoYXQgcG9zaXRpb24uIFdhcm4gYWJvdXQgdGhpcyBhbmQgYWRqdXN0IHRo ZSBzcGVjaWZpZWQNCj4gc3RyaWRlIChpbiB0aGUgd29yc3QgY2FzZSBpZ25vcmluZyB0aGUgb3B0 aW9uIGFsdG9nZXRoZXIpLg0KPg0KPiBSZXF1ZXN0ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4NCj4NCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMN Cj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4gQEAgLTQ1MSw3ICs0NTEs MjQgQEAgc3RhdGljIHN0cnVjdCBwY2lfZGV2ICphbGxvY19wZGV2KHN0cnVjdA0KPiAgICAgICAg ICAgICAgICAgICAgICAgICAgIHBoYW50b21fZGV2c1tpXS5zbG90ID09IFBDSV9TTE9UKGRldmZu KSAmJg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIHBoYW50b21fZGV2c1tpXS5zdHJpZGUg PiBQQ0lfRlVOQyhkZXZmbikgKQ0KPiAgICAgICAgICAgICAgICAgICAgICB7DQo+IC0gICAgICAg ICAgICAgICAgICAgICAgICBwZGV2LT5waGFudG9tX3N0cmlkZSA9IHBoYW50b21fZGV2c1tpXS5z dHJpZGU7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBwY2lfc2JkZl90IHNiZGYgPSBwZGV2 LT5zYmRmOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHN0cmlkZSA9 IHBoYW50b21fZGV2c1tpXS5zdHJpZGU7DQo+ICsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg IHdoaWxlICggKHNiZGYuZm4gKz0gc3RyaWRlKSA+IFBDSV9GVU5DKGRldmZuKSApDQoNCkknbSBm YWlybHkgc3VyZSB0aGlzIGRvZXNuJ3QgZG8gd2hhdCB5b3Ugd2FudCBpdCB0by4NCg0KLmZuIGlz IGEgMyBiaXQgYml0ZmllbGQsIG1lYW5pbmcgdGhlICs9IHdpbGwgYmUgdHJ1bmNhdGVkIGJlZm9y ZSB0aGUNCmNvbXBhcmUuDQoNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHsNCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpZiAoIHBjaV9jb25mX3JlYWQxNihzYmRmLCBQQ0lfVkVO RE9SX0lEKSA9PSAweGZmZmYgJiYNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHBjaV9jb25mX3JlYWQxNihzYmRmLCBQQ0lfREVWSUNFX0lEKSA9PSAweGZmZmYgKQ0KPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdHJpZGUgPDw9IDE7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICIlcHAgbG9va3MgdG8gYmUgYSByZWFsIGRldmljZTsgYnVtcGluZyAlMDR4OiUwMng6 JTAyeCBzdHJpZGUgdG8gJXVcbiIsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICZzYmRmLCBwaGFudG9tX2RldnNbaV0uc2VnLA0KPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBwaGFudG9tX2RldnNbaV0uYnVzLCBwaGFudG9tX2RldnNbaV0uc2xvdCwN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RyaWRlKTsNCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzYmRmID0gcGRldi0+c2JkZjsNCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgIH0NCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIGlmICggUENJX0ZVTkMo c3RyaWRlKSApDQoNClRoaXMgaXMgYW4gb2JmdXNjYXRlZCB3YXkgb2Ygd3JpdGluZyBzdHJpZGUg PCA4Lg0KDQpHaXZlbiB0aGUgcHJpbnRrKCksIGlmIHdlIGFjdHVhbGx5IGZpbmQgYW4gOC1mdW5j dGlvbiBkZXZpY2UsIHdoYXQgZ2V0cw0KcHJpbnRlZCAoQUZBSUNUKSB3aWxsIGJlICJidW1waW5n IHRvIDgiIHdoZW4gaW4gZmFjdCB3ZSBtZWFuICJ0b3RhbGx5DQppZ25vcmluZyB0aGUgb3B0aW9u Ii7CoCBJIHRoaW5rIHRoaXMgcmVhbGx5IHdhbnRzIGFuIGVsc2UgY2xhdXNlLg0KDQp+QW5kcmV3 DQo= From xen-devel-bounces@lists.xenproject.org Thu May 05 19:31:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 19:31:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322352.543629 (Exim 4.92) (envelope-from ) id 1nmhC8-0003yI-Pb; Thu, 05 May 2022 19:31:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322352.543629; Thu, 05 May 2022 19:31:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmhC8-0003yB-MF; Thu, 05 May 2022 19:31:24 +0000 Received: by outflank-mailman (input) for mailman id 322352; Thu, 05 May 2022 19:31:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmhC4-0003y3-U9 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 19:31:23 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee7cf920-cca9-11ec-a406-831a346695d4; Thu, 05 May 2022 21:31:17 +0200 (CEST) Received: from [179.113.53.197] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nmhB9-0009Pt-2n; Thu, 05 May 2022 21:30:24 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee7cf920-cca9-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=26sf2Bz2SDgQmdCQw3Y4ZTnImgJ2MyGCiyio6ZL3q3Y=; b=OX97Z/D1CJSI6hriVTxC2kAnOw 1KITEk45cAtwCpY9rkRCDUh3KDg2O2YzMgXcmuPrqXaafenIhWWC1+LyxgtF/580Mzq9ZdOBGqQII szuZz7L+gnBGPa0DhyrfUrxKFOKAOdS+/7tX8dF3YT6RRRi5n+Pvq9GzAiarMSPSGIbrEUOikWcQ4 luIwkR5QmpMMR3ULcRXOtddO+8na/Jrhq18XXAepQbZ7X+3+2omWFwgyxPBez0WA9LEkMMiNJ8gOK /vnX5br4i70krbeAId+z+Wo/kxx7sPLDtH+XBAxzqCS0vo9z0RVsXdy6BbySPaaEQO2JnHI7/cIaw LlqXpVFA==; Message-ID: <95fd6c2b-8a80-7161-953c-0660c9cc046f@igalia.com> Date: Thu, 5 May 2022 16:28:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers Content-Language: en-US To: Hari Bathini , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Nicholas Piggin , Paul Mackerras References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-9-gpiccoli@igalia.com> <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> From: "Guilherme G. Piccoli" In-Reply-To: <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/05/2022 15:55, Hari Bathini wrote: > [...] > > The change looks good. I have tested it on an LPAR (ppc64). > > Reviewed-by: Hari Bathini Thanks a bunch Hari, much appreciated! From xen-devel-bounces@lists.xenproject.org Thu May 05 20:24:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 20:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322371.543651 (Exim 4.92) (envelope-from ) id 1nmi1f-00015X-E8; Thu, 05 May 2022 20:24:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322371.543651; Thu, 05 May 2022 20:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi1f-00015O-9P; Thu, 05 May 2022 20:24:39 +0000 Received: by outflank-mailman (input) for mailman id 322371; Thu, 05 May 2022 20:24:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi1e-0000pB-4w for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:24:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61e3a317-ccb1-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 22:24:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2CEA061E85; Thu, 5 May 2022 20:24:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BC07C385A4; Thu, 5 May 2022 20:24:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61e3a317-ccb1-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651782275; bh=a14+JEcgQvZosgTIeFyNoWmCUpYVx97L0RGZOeBDFd4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PJYZ/LGNYRu4yYDWk6OmeVIGB3fGWi7bhfp2DUMJNVCUZuaWA8ue9No/RxnsXHuVq rBQO2svwv6SiJIMwxXyMxq8p4xq99bxKFZ5w7Y5bVuKkIbyXLtB9iWAgH8ggtHWhcu Xo0QMMyY/dnJFH3U+ReDAh34/0Dp4U9EF21777XsdWBiYGXXWwzDi9OTuuIBHUtShk wgDeKXYv4fn+HCjG/TZQ1CSQd86iSFsQeW/e4zGQftl8Iq3IVlLTUk8G/l93R6I519 WGTxGuo21IPhwq4ZLHn9ST+ZZrUfjs3vOnm+GD9Sr3QzWw7EjuaOxwbpJSydmKlnOg muOuFAy4YFBoA== Date: Thu, 5 May 2022 13:24:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot In-Reply-To: <6e3aa32b-5b6e-7432-a6db-f2e8f9937c2a@suse.com> Message-ID: References: <20220505001656.395419-4-sstabellini@kernel.org> <6e3aa32b-5b6e-7432-a6db-f2e8f9937c2a@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 5 May 2022, Jan Beulich wrote: > On 05.05.2022 02:16, Stefano Stabellini wrote: > > From: Luca Miccio > > > > Export evtchn_alloc_unbound and make it __must_check. > > > > If "xen,enhanced" is enabled, then add to dom0less domains: > > > > - the hypervisor node in device tree > > - the xenstore event channel > > > > The xenstore event channel is also used for the first notification to > > let the guest know that xenstore has become available. > > > > Signed-off-by: Luca Miccio > > Signed-off-by: Stefano Stabellini > > Reviewed-by: Bertrand Marquis > > CC: Julien Grall > > CC: Volodymyr Babchuk > > CC: Bertrand Marquis > > CC: jbeulich@suse.com > > Somehow my ack given for v5 was lost? I'll put it back > > --- > > Changes in v5: > > - merge with "xen: export evtchn_alloc_unbound" > > - __must_check > > > > Changes in v3: > > - use evtchn_alloc_unbound > > > > Changes in v2: > > - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation > > - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound > > > > xen: export evtchn_alloc_unbound > > > > It will be used during dom0less domains construction. > > > > Signed-off-by: Stefano Stabellini > > This is somewhat confusing to find in a post-commit-message remark. Sorry I don't know what happened there From xen-devel-bounces@lists.xenproject.org Thu May 05 20:24:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 20:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322370.543640 (Exim 4.92) (envelope-from ) id 1nmi1a-0000pO-4L; Thu, 05 May 2022 20:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322370.543640; Thu, 05 May 2022 20:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi1a-0000pH-0e; Thu, 05 May 2022 20:24:34 +0000 Received: by outflank-mailman (input) for mailman id 322370; Thu, 05 May 2022 20:24:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi1Y-0000pB-Fz for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:24:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d80063f-ccb1-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 22:24:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4FAC61E85; Thu, 5 May 2022 20:24:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA354C385A8; Thu, 5 May 2022 20:24:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d80063f-ccb1-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651782268; bh=CBuzmjBh48/sYHsi2B6nLWpcttvPPlK7PxopTiAVXHs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FY/VOdEhW9e/OtJmEWSqW7/7NemdbJ7o3QuEfZWR2DW+0ie6IlHSKxSQz6F/rrogM dg9vZBCgmt99w9FFwkkRgj0czOPMkEfdbPR+4B3v+IuE112WTKtukvvR2QHeoEo5aU u0d5iS7/D+7kklyX48wCKb6uEPEgw/CWsi+ddWys90VknMws5rqD7BX3+L/0yXndaw O8MPOn4GjTuZFBNhSa16CHaN3vEE7guz9XIV5eRJnLo+Sl/WlNnWPFDfrtubEORTqy 2tlYUN671BLWWG6kpBIUxP+vFJ3SaFnxOqhhcOlB7uk4cm6l+162JFsKAYnsF9Atqc NwVNFlI3LIZTQ== Date: Thu, 5 May 2022 13:24:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <04d6f32d-56a9-f6b2-96d0-3087328769ae@suse.com> Message-ID: References: <20220505001656.395419-6-sstabellini@kernel.org> <04d6f32d-56a9-f6b2-96d0-3087328769ae@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 5 May 2022, Juergen Gross wrote: > On 05.05.22 02:16, Stefano Stabellini wrote: > > From: Luca Miccio > > > > Add an example application that can be run in dom0 to complete the > > dom0less domains initialization so that they can get access to xenstore > > and use PV drivers. > > > > The application sets "connection" to XENSTORE_RECONNECT on the xenstore > > page before calling xs_introduce_domain to signal that the connection is > > not ready yet to be used. XENSTORE_RECONNECT is reset soon after by > > xenstored. > > > > Signed-off-by: Luca Miccio > > Signed-off-by: Stefano Stabellini > > CC: Wei Liu > > CC: Anthony PERARD > > CC: Juergen Gross > > --- > > Changes in v6: > > - include xs_wire.h and use its definitions > > > > Changes in v5: > > - set XS_CONNECTION_STATE_RECONNECTING before xs_introduce_domain > > > > Changes in v4: > > - only alloc xs page (no other magic pages) > > - add xenstore permissions > > - check all return values > > - rename restore_xenstore to create_xenstore > > - set target_memkb > > - set start_time properly > > - close xs transaction on error > > - call xc_dom_gnttab_seed instead of xc_dom_gnttab_init > > - xs_open instead of xs_daemon_open > > > > Changes in v3: > > - handle xenstore errors > > - add an in-code comment about xenstore entries > > - less verbose output > > - clean-up error path in main > > > > Changes in v2: > > - do not set HVM_PARAM_STORE_EVTCHN twice > > - rename restore_xenstore to create_xenstore > > - increase maxmem > > > > connection reconnecting > > --- > > tools/helpers/Makefile | 13 ++ > > tools/helpers/init-dom0less.c | 340 ++++++++++++++++++++++++++++++++++ > > 2 files changed, 353 insertions(+) > > create mode 100644 tools/helpers/init-dom0less.c > > > > diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile > > index 7f6c422440..8d78ab1e90 100644 > > --- a/tools/helpers/Makefile > > +++ b/tools/helpers/Makefile > > @@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y) > > ifeq ($(CONFIG_X86),y) > > PROGS += init-xenstore-domain > > endif > > +ifeq ($(CONFIG_ARM),y) > > +PROGS += init-dom0less > > +endif > > endif > > XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o > > @@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += > > $(CFLAGS_libxenstore) > > $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight) > > $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include > > $(XEN_ROOT)/tools/config.h > > +INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o > > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog) > > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore) > > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight) > > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl) > > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn) > > + > > .PHONY: all > > all: $(PROGS) > > @@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS) > > init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) > > $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) > > $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) > > $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) > > +init-dom0less: $(INIT_DOM0LESS_OBJS) > > + $(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) > > $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) > > $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) > > $(APPEND_LDFLAGS) > > + > > .PHONY: install > > install: all > > $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) > > diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c > > new file mode 100644 > > index 0000000000..bfd5ff0761 > > --- /dev/null > > +++ b/tools/helpers/init-dom0less.c > > @@ -0,0 +1,340 @@ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "init-dom-json.h" > > + > > +#define XENSTORE_PFN_OFFSET 1 > > +#define STR_MAX_LENGTH 64 > > + > > +static int alloc_xs_page(struct xc_interface_core *xch, > > + libxl_dominfo *info, > > + uint64_t *xenstore_pfn) > > +{ > > + int rc; > > + const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT; > > + xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + > > XENSTORE_PFN_OFFSET; > > + > > + rc = xc_domain_setmaxmem(xch, info->domid, > > + info->max_memkb + (XC_PAGE_SIZE/1024)); > > + if (rc < 0) > > + return rc; > > + > > + rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m); > > + if (rc < 0) > > + return rc; > > + > > + *xenstore_pfn = base + XENSTORE_PFN_OFFSET; > > + rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn); > > + if (rc < 0) > > + return rc; > > + > > + return 0; > > +} > > + > > +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, > > + domid_t domid, char *path, char *val) > > +{ > > + char full_path[STR_MAX_LENGTH]; > > + struct xs_permissions perms[2]; > > + > > + perms[0].id = domid; > > + perms[0].perms = XS_PERM_NONE; > > + perms[1].id = 0; > > + perms[1].perms = XS_PERM_READ; > > + > > + if (snprintf(full_path, STR_MAX_LENGTH, > > + "/local/domain/%u/%s", domid, path) < 0) > > + return false; > > + if (!xs_write(xsh, t, full_path, val, strlen(val))) > > + return false; > > + return xs_set_permissions(xsh, t, full_path, perms, 2); > > +} > > + > > +static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t, > > + domid_t domid, char *path, char *val) > > +{ > > + char full_path[STR_MAX_LENGTH]; > > + > > + if (snprintf(full_path, STR_MAX_LENGTH, > > + "/libxl/%u/%s", domid, path) < 0) > > + return false; > > + return xs_write(xsh, t, full_path, val, strlen(val)); > > +} > > + > > +static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t, > > + libxl_uuid uuid, char *path, char *val) > > +{ > > + char full_path[STR_MAX_LENGTH]; > > + > > + if (snprintf(full_path, STR_MAX_LENGTH, > > + "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) > > < 0) > > + return false; > > + return xs_write(xsh, t, full_path, val, strlen(val)); > > +} > > + > > +/* > > + * The xenstore nodes are the xenstore nodes libxl writes at domain > > + * creation. > > + * > > + * The list was retrieved by running xenstore-ls on a corresponding > > + * domain started by xl/libxl. > > + */ > > +static int create_xenstore(struct xs_handle *xsh, > > + libxl_dominfo *info, libxl_uuid uuid, > > + evtchn_port_t xenstore_port) > > +{ > > + domid_t domid; > > + unsigned int i; > > + char uuid_str[STR_MAX_LENGTH]; > > + char dom_name_str[STR_MAX_LENGTH]; > > + char vm_val_str[STR_MAX_LENGTH]; > > + char id_str[STR_MAX_LENGTH]; > > + char max_memkb_str[STR_MAX_LENGTH]; > > + char target_memkb_str[STR_MAX_LENGTH]; > > + char cpu_str[STR_MAX_LENGTH]; > > + char xenstore_port_str[STR_MAX_LENGTH]; > > + char ring_ref_str[STR_MAX_LENGTH]; > > + xs_transaction_t t; > > + struct timeval start_time; > > + char start_time_str[STR_MAX_LENGTH]; > > + int rc; > > + > > + if (gettimeofday(&start_time, NULL) < 0) > > + return -errno; > > + rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d", > > + (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000); > > + if (rc < 0) > > + return rc; > > + > > + domid = info->domid; > > + rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, > > LIBXL_UUID_BYTES(uuid)); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(vm_val_str, STR_MAX_LENGTH, > > + "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", > > info->current_memkb); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", > > + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + > > XENSTORE_PFN_OFFSET); > > + if (rc < 0) > > + return rc; > > + rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port); > > + if (rc < 0) > > + return rc; > > + > > +retry_transaction: > > + t = xs_transaction_start(xsh); > > + if (t == XBT_NULL) > > + return -errno; > > + > > + rc = -EIO; > > + /* /vm */ > > + if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err; > > + if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err; > > + if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto > > err; > > + > > + /* /domain */ > > + if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err; > > + for (i = 0; i < info->vcpu_max_id; i++) { > > + rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i); > > + if (rc < 0) > > + goto err; > > + rc = -EIO; > > + if (!do_xs_write_dom(xsh, t, domid, cpu_str, > > + (info->cpupool & (1 << i)) ? "online" : > > "offline")) > > + goto err; > > + } > > + > > + if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", > > max_memkb_str)) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) > > goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err; > > + > > + if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", > > "")) goto err; > > + > > + if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) > > goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) > > goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) > > goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, > > "control/platform-feature-multiprocessor-suspend", "1")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, > > "control/platform-feature-xs_reset_watches", "1")) goto err; > > + > > + if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err; > > + > > + if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) > > goto err; > > + if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) > > goto err; > > + > > + if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err; > > + if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto > > err; > > + > > + if (!xs_transaction_end(xsh, t, false)) { > > + if (errno == EAGAIN) > > + goto retry_transaction; > > + else > > + return -errno; > > + } > > + > > + return 0; > > + > > +err: > > + xs_transaction_end(xsh, t, true); > > + return rc; > > +} > > + > > +static int init_domain(struct xs_handle *xsh, > > + struct xc_interface_core *xch, > > + xenforeignmemory_handle *xfh, > > + libxl_dominfo *info) > > +{ > > + libxl_uuid uuid; > > + uint64_t xenstore_evtchn, xenstore_pfn; > > + int rc; > > + struct xenstore_domain_interface *intf; > > + > > + printf("Init dom0less domain: %u\n", info->domid); > > + > > + rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN, > > + &xenstore_evtchn); > > + if (rc != 0) { > > + printf("Failed to get HVM_PARAM_STORE_EVTCHN\n"); > > + return 1; > > + } > > + > > + /* Alloc xenstore page */ > > + if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) { > > + printf("Error on alloc magic pages\n"); > > + return 1; > > + } > > + > > + intf = xenforeignmemory_map(xfh, info->domid, XS_READ | XS_WRITE, 1, > > I don't think you want to pass the xenstore wire commands here. Did you mean > PROT_READ | PROT_WRITE? Ops, you are right. I'll fix that. > > + &xenstore_pfn, NULL); > > + if (!intf) { > > + printf("Error mapping xenstore page\n"); > > + return 1; > > + } > > + intf->connection = XENSTORE_RECONNECT; > > + xenforeignmemory_unmap(xfh, intf, 1); > > + > > + rc = xc_dom_gnttab_seed(xch, info->domid, true, > > + (xen_pfn_t)-1, xenstore_pfn, 0, 0); > > So no support for Xenstore running in a stub-domain? We don't have stub-domains on ARM yet (unfortunately), so we cannot run xenstore in one. It would not be possible for me to test it at the moment. From xen-devel-bounces@lists.xenproject.org Thu May 05 20:28:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 20:28:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322384.543662 (Exim 4.92) (envelope-from ) id 1nmi4t-00022n-SK; Thu, 05 May 2022 20:27:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322384.543662; Thu, 05 May 2022 20:27:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi4t-00022g-OJ; Thu, 05 May 2022 20:27:59 +0000 Received: by outflank-mailman (input) for mailman id 322384; Thu, 05 May 2022 20:27:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmi4s-00022U-DS for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:27:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d92095b2-ccb1-11ec-a406-831a346695d4; Thu, 05 May 2022 22:27:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 376A161EDD; Thu, 5 May 2022 20:27:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9DEFC385A8; Thu, 5 May 2022 20:27:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d92095b2-ccb1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651782475; bh=18u9jwbvpZ9hsPowDF62MYRvrao/q6fzZrVBaERoLnc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=l9UG74LFNCb7114sUqTlgnr42rzVJxuTrmoxIS2wVWEu6pAQDomM23m11SyXx91II vff91T56Oew4OoqrFZTwXXCRTEjS4JvSwWBXFvN31HQB6r5xejCPTrSRunemoM9q7A IghvpySFfHCKX7256H490YVJO5WM6bG9oraner24+poRa0WOcwOnaVZ+7Ua2RfuWLV ziPkc5cKWuJiTIEL1NAB1p52yFIXB+FgAG1wvQfetSnekvr0NoV3kHROpL2r+mbY4X 6FT2mzdO0Q7CWoakeNstXFwa/eAG7Gmu+WQoSEr+uyz83wKSoFsdlvqLUIkjsmqIFc 1Sg1nULfIaHMQ== Date: Thu, 5 May 2022 13:27:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Juergen Gross , Stefano Stabellini , boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain In-Reply-To: <5f7e5a83-0944-8464-564a-51d7a4d19c55@arm.com> Message-ID: References: <20220505002304.401417-2-sstabellini@kernel.org> <5f7e5a83-0944-8464-564a-51d7a4d19c55@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-763135260-1651782475=:43560" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-763135260-1651782475=:43560 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 5 May 2022, Michal Orzel wrote: > On 05.05.2022 14:29, Juergen Gross wrote: > >>> -        /* Avoid truncation on 32-bit. */ > >>> +        if (v == ~0ULL) { > >> No need for brackets for a single instruction. > > > > The coding style says otherwise: > > > >   This does not apply if only one branch of a conditional statement is a single > >   statement; in the latter case use braces in both branches: > > > >   .. code-block:: c > > > >         if (condition) { > >                 do_this(); > >                 do_that(); > >         } else { > >                 otherwise(); > >         } > > > > > Good to know. So Luca, you can omit this comment. Thanks Michal, I addressed the other two comments. --8323329-763135260-1651782475=:43560-- From xen-devel-bounces@lists.xenproject.org Thu May 05 20:34:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 20:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322391.543672 (Exim 4.92) (envelope-from ) id 1nmiAz-0003T1-FJ; Thu, 05 May 2022 20:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322391.543672; Thu, 05 May 2022 20:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiAz-0003Su-Cf; Thu, 05 May 2022 20:34:17 +0000 Received: by outflank-mailman (input) for mailman id 322391; Thu, 05 May 2022 20:34:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiAy-0003So-5V for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:34:16 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba923968-ccb2-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 22:34:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3369AB8304D; Thu, 5 May 2022 20:34:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02C12C385A8; Thu, 5 May 2022 20:34:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba923968-ccb2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651782852; bh=8XtDg73D5fKesmCZ+iFkxHSPPyrm4eeztlih3xK5bdg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sQ2O6lWqzLSDE2G/jU+qTI0a4yNztplD55IgN+kV/3+CCVbeYsvQC5+HrfSAQS2TJ Y7hcbU06F3TI+MbmJaRBpHaYqmc0gXs6nafthQovVjzT2fDHCgKAkWy4Px/5FYCPDq s0vRbLN6XESpCuKOrgJnHEZrO8wB1SJdqa4ZK/2hz6pBOWu6gk+JzBXLXSHlpToph6 O27lrcVVl6Qy1JUk5fosLdFqpB2K14MV+iAGCYx3942gVs7Js1jU7RgPQo2MvR7nlG zIZe6M6VYx4wthsDObfAoZtaY6238JZYT7z+0o+MDXQ1sL6JrE34C+fb4NxnklYJXO 5+mNfNwN93ewg== Date: Thu, 5 May 2022 13:34:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once In-Reply-To: Message-ID: References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-3-michal.orzel@arm.com> <0bf31f91-9a05-ac91-a258-d28d6ad9084d@suse.com> <77ba649d-89b6-8a15-191f-6e4261b7e381@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 5 May 2022, Jan Beulich wrote: > On 05.05.2022 13:25, Michal Orzel wrote: > > On 05.05.2022 13:20, Jan Beulich wrote: > >> On 05.05.2022 12:36, Michal Orzel wrote: > >>> Modify macros to evaluate all the arguments and make sure the arguments > >>> are evaluated only once. While doing so, use typeof for basic types > >>> and use const qualifier when applicable. > >> > >> Why only for basic types? To take an example, passing void * into > >> gnttab_need_iommu_mapping() would imo also better not work. > >> > > Just by looking at the majority of macros in Xen, typeof is used mostly for basic data types. > > Also I think it is better to explictly use a struct type for better readability. > > Otherwise one need to search in other files, to what type does typeof evaluates. > > > >>> @@ -98,13 +104,36 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, > >>> }) > >>> > >>> #define gnttab_shared_gfn(d, t, i) \ > >>> - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) > >>> + ({ \ > >>> + const struct domain *d_ = (d); \ > >>> + const struct grant_table *t_ = (t); \ > >>> + const typeof(i) i_ = (i); \ > >>> + \ > >>> + if ( d_ != NULL ) \ > >>> + ASSERT(d_->grant_table == t_); \ > >> > >> I'm puzzled by this NULL check (and the similar instance further down): > >> Are you suggesting NULL can legitimately come into here? If not, maybe > >> better ASSERT(d_ && d_->grant_table == t_)? > >> > > Example: > > NULL is coming explictly from macro gnttab_get_frame_gfn right above gnttab_shared_gfn. > > Hmm, that's pretty odd (and Arm specific). Just like with the other remark > above, it'll be the Arm maintainers to judge, but here I think the NULLs > would better be done away with, by introducing intermediate macros, e.g. I am fine with Jan's comments on both patches From xen-devel-bounces@lists.xenproject.org Thu May 05 20:55:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 20:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322399.543685 (Exim 4.92) (envelope-from ) id 1nmiVR-0005v6-ER; Thu, 05 May 2022 20:55:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322399.543685; Thu, 05 May 2022 20:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiVR-0005uz-8R; Thu, 05 May 2022 20:55:25 +0000 Received: by outflank-mailman (input) for mailman id 322399; Thu, 05 May 2022 20:55:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiVP-0005ur-CJ for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:55:24 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id abfe04d4-ccb5-11ec-a406-831a346695d4; Thu, 05 May 2022 22:55:19 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245Hd2cq026110; Thu, 5 May 2022 20:55:15 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruhcc97e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 20:55:14 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 245KotsK008820; Thu, 5 May 2022 20:55:13 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fruj558nf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 20:55:13 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) by DM6PR10MB3881.namprd10.prod.outlook.com (2603:10b6:5:1fe::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Thu, 5 May 2022 20:55:11 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::597f:1669:9247:7737]) by CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::597f:1669:9247:7737%7]) with mapi id 15.20.5206.027; Thu, 5 May 2022 20:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abfe04d4-ccb5-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=GIQO8laz2Br665gbcj7aJdEW2CqtFMVfO3pK2txAhxE=; b=ATlsqs8ZkS1ySUOJCUIhjCuY3u0pG2NLDRJK0QW8BRN//i9jtdaR+7QxpHWkWBiGqWU1 oDrX9z/6kusfREiLSWi8iqzA1Q3iwfHuyKT2mxjlVlm+HK+kXNaj5jZp6Sf6F4Va2TBF dJ3AG0aixUd2AyyForesxkDsNGEIltoSaAsuaWsYE1Ak281p5rq8E+cPE7q1JarCEPXG dYA/1rpEOeV2A6pegLqmxLIs5WAmpyhGs8ech4R9KGFHpTlQiDdnKVrGoeSLseYr3fy4 RTQ5ncoUSZh0rrHF02sjUlYVt3/1RjIDgYjKQRWn+AS33C8BsiLdw42MY7KJw5WEQ63v vw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RyrEqK8qm3gpCM3J6d6Ae/nwNC7JZV0jLwmoF+4qXqOUadWfZc5DEWMLCIsFvwUcm/xEM6P6MF8BpfroccaENfNDwYbmbr09qyd0gKKIzKOkWTPtVmh6xnJyQs3nb57SkKhYQK9ugzmSa7cOcdmKjwJete3653cQnPkYJW6dIUdR75PLLas/FbS7wCpoNXbz3TbAGGu658KkjbPXi96ueeoVg2ssCiz6xWVzlBGRH07zEGQmTbx+vHH75w89V7hr06X9l35P0E9ZfrEQ7Lxz7HRUucmx2i81mSsCQxtQUxDy+dYqfceyNPZIjaHZi52wsLU3kXBHVEAf4MYDrIkOZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GIQO8laz2Br665gbcj7aJdEW2CqtFMVfO3pK2txAhxE=; b=KGgWCM5ZnIJsmizEJ07Xyj2yS6MNOJ2o2Y5wCm0smq5WTOcyEv7GrCpZ0u/9hmxARnP3qtxJwAWcTCCX2UmK7CV1SlKGiAkeqp+GaAXCoK9C6VGMo+s74krHSHXNaWHkE9lQ72dJ6iZSFzYGe8Vo2HrHNXv/23U6aOOMHaP1ASAtIWZFbUP6Wwo286rR6vFIe/HQvskv7lVL+n9C1fXIjTmlb+Crpnn0dciZwJh0BI3JQeCC9505b2AhBL7bdohuhMp/EOjXs1LlnEzNWrItOj3uazsmEDviAv3MOjj976oB31KS4Xz/DgwdJCGc9Z4lsqOONzVMt5g/C+CB61CtwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIQO8laz2Br665gbcj7aJdEW2CqtFMVfO3pK2txAhxE=; b=o4uOBc2es715z2rFIpS9D/E/Jo0CHAhTXizIKzqahjPWBIlFSPC5KDcA8n/dkcpHYFSWqNORhs6mmKXN9WHQV9pHFaEEY/lf4+3RfreE4liOg+JCXAmP5DIepI1DyyGCEa8TPlMQkt0JJiu9XvEk+ka0AdUlF3hZi6uIIRtJ+xI= Message-ID: <7c8b93d8-a20b-a859-265e-bb4b6aefe10b@oracle.com> Date: Thu, 5 May 2022 16:55:06 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain Content-Language: en-US To: Stefano Stabellini , jgross@suse.com Cc: xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini References: <20220505002304.401417-2-sstabellini@kernel.org> From: Boris Ostrovsky In-Reply-To: <20220505002304.401417-2-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY5PR17CA0014.namprd17.prod.outlook.com (2603:10b6:a03:1b8::27) To CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24b8968e-cdc3-45a0-622e-08da2ed98bc7 X-MS-TrafficTypeDiagnostic: DM6PR10MB3881:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J2p+JHfb8MrH5CgNJ5dya6CYE7FUn3kPowWXufhyXfVW6sS1AsjxbezhjCnNWYScIbxOuAhq9X6j0D5OzvQlRyvbXX8eNsoWTbmP7sVHgv/0EPlWXVvZAlKjqb4KeU8G1HDKaZnQlVwSnqkrKHrvgNGfKBEcuMSCypibUm9lmSgc8T7JZPM58Uc/xw8yEtEbWIvHJvnGNFspEVmAXe6FZmeRT+Bx9vxGS3mBvxzmd72aBfIOShQI6gYckGHHOuSeIyxJZJmhIegGNsy6RIARtxXVLVZmGyM7BxD20/ScWBZq8dNwL5dT6+gSxSCSxuGgZYUTpT3rqZpywsIRtj0setmerprzh1h57Q8/k7sk0SGeUn9VduPsKStOcRVpv/KncMGA3qbsNtltAl2qriXDsk+/9sG6WfWdjd3Nb+l9NiImLHFwEpmWq17f74gnY1OVs7fyMq30pjVaVIEJ39E8/58TwWwQU9jSKBE1NwYyEXIOenNTUUUl9rfXEXx+UUwSzgF2ido4Azua1XfOKZZL7pkL5K2OwWXn3B8M/fkobyCToT3X4AeOca9dGgKIMMheyJNpEl8LVToddv84IQpJBdUDZkl5a4yed5/Yq2NQoja16V2jutk3R75tYpx/rsyyQPaJOFQ5ISkNSyzuJ46xW3hWMa/sGKFyF+hfwp5/L1jz3eIVWtpdcJBXZfn7GTk7TQMEr6XImknwhDQvwxqS3HNHCZ8vdancL75xpEs7jZJ9NrOPYG8QUvPEZEWGBEHM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(6512007)(53546011)(26005)(508600001)(4744005)(44832011)(5660300002)(2616005)(186003)(2906002)(36756003)(31686004)(66556008)(66476007)(8936002)(4326008)(8676002)(38100700002)(6666004)(6486002)(316002)(66946007)(54906003)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blNLQUNLa3d0ZEZpeHJvQkVBOVFaSld6SVRhMG9XZCtJelREM0p4MjFUTWFi?= =?utf-8?B?ekttV1JPeGFKL0tIbEphUnFFWk8vOVhHV1VtVGJCOTR4QnEzbGtINkIzb2ti?= =?utf-8?B?WWRNMHI1a3V5Zm9sVVVkeVpPU1R4OENNY1RzY2FnNzNwd2xTNEVZc1cwcXdq?= =?utf-8?B?Tm5oS1JkY0VKd3V0S2p5a1VEa2FieGdMNkVLOXRhTWhJck5SK1BWRXc4NnZm?= =?utf-8?B?Ylp6RVRTN2plQjl4Ti82bG1SaGoxb1Y3cGV5S1FBdDNiajNZYjFWTldjaVc4?= =?utf-8?B?NlBlczB6T2g4b05UT01kbDVlS0dIcmpJU0pqSFVJaVJtY2tycThMK2FrY1JB?= =?utf-8?B?MVF4ZTdpck96TFJoLzdoVHcyQXY0Tjd1dlJhdUx4M2ZKZTkwM0Y5L3NmcDcy?= =?utf-8?B?R0R2Z1Rkek0wdXpYSnFoTWRKTS9TQlBZQndHVDRwcTlvMCtSbGFXS0E0TGl2?= =?utf-8?B?bk5tdXhVYmxwSlBnQzJrZmUreFNVOFNCU2luQWNmQmhzZlhDNy84TWlEc0E0?= =?utf-8?B?NkFoL2NxemhqUDFSWkRySmFaUVcrZDBHd1Z3YTI0ZnplVHFCTkl2ZlF0YnlE?= =?utf-8?B?R3VkNS8waHVSMFVqNmxJNm5aN1ZJTHMyTk9NN0ZUUUNOZVRvR2NKYWFid1Nx?= =?utf-8?B?SzBHcXA0UTBDa3didlZZelNBdW5YaTlCNHMrd1A4dW1TejFEWnhJcGpPYW11?= =?utf-8?B?ei9kbXZDRGx0bGgwUkFrMTI1eVZjUE1LSkxVS2RjK0tkMGxleml5Vkh4QTRR?= =?utf-8?B?MzlIbmptSGVvVWRhNDBOWnhkSElzdDc1dHkzczkwRGpZZnZ0dnpEOXFWSStG?= =?utf-8?B?UlBxcVNHQWJmUXRoKzhGZEx1ako0OXZ6NTlQRkFORitjYzd3VVlHZjdtU2dO?= =?utf-8?B?ZHpYOXdWUG5jdEloa3hKU0JhS3Npcis0d2dYNFFvczI2VGhKQm5OY1RTeXdn?= =?utf-8?B?UVRVRW1GVy9KL0kxZGFqOHUwMkJWdXEvQ0ZOeGxoSThMYlZPK3hiUlNjRXJ2?= =?utf-8?B?eG1VT2dZZnVleDg5Z05LcHNxaVc1aktQL011U29aS1N5a21CWlJOckR6NGkv?= =?utf-8?B?L3MrNHhkZit5NkRyaDBvSjhIY3NPV3JBVUZIdEVNV3pNRVFhbE13RVFpYXlk?= =?utf-8?B?MkRvVGNSWnVJK1Baa3hzdVVYTTByc3JXMWxFWHhPWWZ4OTFtcW1XV3ZBa0p6?= =?utf-8?B?NU9mazBSTUNVeW83VmN2TFJJODRoTWVyRmZSV3N2MjRzVFJ5TlVIL1NjcWZZ?= =?utf-8?B?Z3FTZFZTMFdxLzhIUjE1NUUrcFFDRFdubWtYMGxnUkVUelkraWQvNWEvNy9a?= =?utf-8?B?aGQvZUlYR2UzazRjWFZCc1RUTUhDVnl4Ynl4U2ZnN0ljaDkvVGJ6aUlLbDF6?= =?utf-8?B?TVJJWmM5a3lLYUJjT0xSU1ZvcExjUld5L3RDZFNQcFI4RWlsV0dVaUE3YVpQ?= =?utf-8?B?Z1ZNeVNoMkxzQ0Q3WDk1NU0zSEI3WkRYRVdvTDBRYUFmN2VnbzlpMEs5SEM3?= =?utf-8?B?RTBmQnlNV05lQ0lrK1lPYWdUTDE0cmVvd3VNS0NERnQ2aEppOGIrZHZlUTBJ?= =?utf-8?B?UG9wZHZjMjZCdEtFU09hMW9RTFdKdzJrNmJZaXNad1QvdEVkVEs2TmIzYktX?= =?utf-8?B?RGJSYXFLMzNhaFJrMzIxODQzZSt2ZVQyaStXYXNaRGVSWXM3WVYvTlAzRW5H?= =?utf-8?B?em54anZ6TUZjbmQyb3F2WStHR1ZTNzJOR0RvTG51QXUxajlWcDJaOFo2YkNr?= =?utf-8?B?OUJ3UFUwNDEyMFVtRTdZeWIwSXdEcHNpMms3bm1FZXVFQUZ1NTRnQ1FvRDk4?= =?utf-8?B?TzJ5YXVST3NlSkVQQm1qeVZQbUppcXArb01ia05vdkxPT0lPSE1OWXBQeWR1?= =?utf-8?B?MjNZOWgya1M4U082ei9lTWhGWTZCbWMrNDVFOG0rOTlPSEhsM1EvSEtOOTJH?= =?utf-8?B?a1QvNWxxZWNMeTBTT2hjTTBDZTVleGJGMUZKYWhxVWhHVHRwWTJUblZyaFV3?= =?utf-8?B?NDVRZEdTUnUwMkdOWng0UUxNL3lGV3ZtZmFGRmpiMnN4T2orV1Z1M3l1VHYx?= =?utf-8?B?YWNneWs1b213a1NZeDRVWWxWeE5jaExRVHlITllNQ3FpVnRYM3JUTDJoN2Ev?= =?utf-8?B?eGdvRjYxZzd6VnJlY2pKTjRVbnZtaHh1SjNZL1VDNzdDNGM3UjQ1TGRYM3pT?= =?utf-8?B?Z0JPWWhWc1BiMkVoMnNicUJqWlN1SmxVc1N1WjdOWXlVZTFDTG5IemVKSExR?= =?utf-8?B?K2huTUFpWGQwVnJCRnlDSjFxMmJiTUpEdVZUUFhKTjlmUndmOS82T1ZoN1Vr?= =?utf-8?B?M2s1amsrM0x4cTVQSWR3c2tSL2YwWVJ6c2lKUmg2Zkk4eHArdGVKOTVmNExr?= =?utf-8?Q?pQ/lRDqCdrXCZ41s=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24b8968e-cdc3-45a0-622e-08da2ed98bc7 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 20:55:11.5164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OCkAidHYUFC/VMHLR48hwRNBc6GvYFt0tViMfwY8BnHddxzIZuODt86XAJy7Ms/JTtHV1qfyf+n8O0/GOugxNQzx0MIYwl8eN/6CoTnMO3Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3881 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-05_09:2022-05-05,2022-05-05 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205050134 X-Proofpoint-GUID: MtU7Z8Z7rEHBWyhcQGD0cKpMIfa78j0S X-Proofpoint-ORIG-GUID: MtU7Z8Z7rEHBWyhcQGD0cKpMIfa78j0S On 5/4/22 8:23 PM, Stefano Stabellini wrote: > @@ -957,25 +989,44 @@ static int __init xenbus_init(void) > * been properly initialized. Instead of attempting to map a > * wrong guest physical address return error. > * > - * Also recognize all bits set as an invalid value. > + * Also recognize all bits set as an invalid/uninitialized value. What I really meant (but not what I actually wrote I guess) was that now we are treating -1 differently than 0 and so that comment should go ... > */ > - if (!v || !~v) { > + if (!v) { > err = -ENOENT; > goto out_error; > } > - /* Avoid truncation on 32-bit. */ ... here. But this is ntpicking so for the series Reviewed-by: Boris Ostrovsky > + if (v == ~0ULL) { > + wait = true; > + } else { > + /* Avoid truncation on 32-bit. */ From xen-devel-bounces@lists.xenproject.org Thu May 05 21:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 21:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322406.543695 (Exim 4.92) (envelope-from ) id 1nmiuk-0000rQ-Br; Thu, 05 May 2022 21:21:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322406.543695; Thu, 05 May 2022 21:21:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiuk-0000rJ-8s; Thu, 05 May 2022 21:21:34 +0000 Received: by outflank-mailman (input) for mailman id 322406; Thu, 05 May 2022 21:21:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiuj-0000r9-3D; Thu, 05 May 2022 21:21:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiui-0007Qn-W4; Thu, 05 May 2022 21:21:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmiui-000758-LB; Thu, 05 May 2022 21:21:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmiui-0006JR-Kh; Thu, 05 May 2022 21:21:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i6FMwI0RoECiDy0jvtlYYgRQbfGv+4z20FtUeSNAq4Q=; b=lpuPOUlA9VKzxutj7mgSYE/yph HNdGIUz6pE7diLC/Z/MB8qOyrFRJF/2bqNhS1EooDGq4TgYmapsg2mDyjyUrNLLRAtVQ47U/lpmPm LtA81o3h5eVjZkBk2i34A+CbyWl1iyWJFRrkRe6bTjf0OhaDGLoNvkaUEnXvKqvRmL8w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170157: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 21:21:32 +0000 flight 170157 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 826 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 50 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 22:15:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 22:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322415.543705 (Exim 4.92) (envelope-from ) id 1nmjl3-0005zg-Bf; Thu, 05 May 2022 22:15:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322415.543705; Thu, 05 May 2022 22:15:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmjl3-0005zZ-8z; Thu, 05 May 2022 22:15:37 +0000 Received: by outflank-mailman (input) for mailman id 322415; Thu, 05 May 2022 22:15:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmjl2-0005zP-33; Thu, 05 May 2022 22:15:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmjl2-0008Lg-0S; Thu, 05 May 2022 22:15:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmjl1-0000ns-IA; Thu, 05 May 2022 22:15:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmjl1-0004su-Hf; Thu, 05 May 2022 22:15:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tcfpbGPxQouUihvYDPm4v0L75FduvCc9iX+kjQsmwJs=; b=GjvdkamvYcAxqV7yYjiGoS0cvn lVCBG2uOqIeK0R+8OKqHWfF4F5kSI1OIz45AsNotPDlJGqfAL+RHpgDZxIK1o8cEzR7Noq8ym7BH7 uHQshfJiif6onJ8oxa7hCcEVanhf8DwMo04UZGsF9i0IzcKhs6ziEnSvUKrZq/jFJKL4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170159: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 22:15:35 +0000 flight 170159 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170159/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 827 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 51 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 05 22:47:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 22:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322424.543716 (Exim 4.92) (envelope-from ) id 1nmkFy-0000vv-Si; Thu, 05 May 2022 22:47:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322424.543716; Thu, 05 May 2022 22:47:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmkFy-0000vo-Pl; Thu, 05 May 2022 22:47:34 +0000 Received: by outflank-mailman (input) for mailman id 322424; Thu, 05 May 2022 22:47:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmkFx-0000ve-HF; Thu, 05 May 2022 22:47:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmkFx-0000Qn-CE; Thu, 05 May 2022 22:47:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmkFw-0001w8-Uz; Thu, 05 May 2022 22:47:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmkFw-0008Ag-UZ; Thu, 05 May 2022 22:47:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F6Zh/byAMTWLQ4NtI6Q5FlfW18Pb9U2ta2h0jzKW+jE=; b=ulmfD87+Yl0rAejTnYUIWT9c6T RfT0wV8aSMAL9UHTWxpMvwVUUGAVhStFIOg7qlrvszLZRqI0BDAuiplRs4PwPs6jngxgfDnQehJaM Tk8j/5k8O1sHCd/G8OcuV6ugieA579XlK6Ea2HhD2OEQZi7cSZtYfIinzrY9I2XBy+/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170150: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5d5104260222cd7ffaaeb555727808f479e7103b X-Osstest-Versions-That: qemuu=1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215 From: osstest service owner Date: Thu, 05 May 2022 22:47:32 +0000 flight 170150 qemu-mainline real [real] flight 170160 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170150/ http://logs.test-lab.xenproject.org/osstest/logs/170160/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170160-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170130 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170130 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170130 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170130 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170130 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170130 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170130 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170130 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu 5d5104260222cd7ffaaeb555727808f479e7103b baseline version: qemuu 1fba9dc71a170b3a05b9d3272dd8ecfe7f26e215 Last test of basis 170130 2022-05-05 00:38:58 Z 0 days Testing same since 170150 2022-05-05 13:38:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Denis V. Lunev Eric Blake Hanna Reitz Kevin Wolf Richard Henderson Stefan Hajnoczi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 1fba9dc71a..5d51042602 5d5104260222cd7ffaaeb555727808f479e7103b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 05 23:57:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 05 May 2022 23:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322436.543727 (Exim 4.92) (envelope-from ) id 1nmlLn-0007un-A3; Thu, 05 May 2022 23:57:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322436.543727; Thu, 05 May 2022 23:57:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlLn-0007ug-7V; Thu, 05 May 2022 23:57:39 +0000 Received: by outflank-mailman (input) for mailman id 322436; Thu, 05 May 2022 23:57:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlLm-0007uW-6o; Thu, 05 May 2022 23:57:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlLm-0001bK-5E; Thu, 05 May 2022 23:57:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlLl-0003no-QD; Thu, 05 May 2022 23:57:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmlLl-0007VH-Pn; Thu, 05 May 2022 23:57:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+JivFVBXtYWCzyMJa9XjPIH1dfHWY3y5qvhrc9amw6o=; b=IsuYK3EiottqZQHinL4uviXBJ7 zzIdGlFLg3eC9h4MHJTSDH0NuiRZcnrcRvIG1oepHVrIUItY7EmDVTuECfTnzy1p8fJc/zuU2jZKD g/W30ri0hASZnJuqGFeYBt76KyBgXYQP4Y3Q82nqRjT3b0mu8yMhh++ryjl3MtYZmTTU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170161: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 05 May 2022 23:57:37 +0000 flight 170161 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170161/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 828 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 52 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 00:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 00:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322445.543738 (Exim 4.92) (envelope-from ) id 1nmlas-0002Px-Fp; Fri, 06 May 2022 00:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322445.543738; Fri, 06 May 2022 00:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlas-0002Pq-D0; Fri, 06 May 2022 00:13:14 +0000 Received: by outflank-mailman (input) for mailman id 322445; Fri, 06 May 2022 00:13:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlap-0002Pk-KI for xen-devel@lists.xenproject.org; Fri, 06 May 2022 00:13:12 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e95e6bd-ccd1-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 02:13:09 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245M2pK2003197; Fri, 6 May 2022 00:12:32 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3frw0avevw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 May 2022 00:12:32 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2460BaWH035627; Fri, 6 May 2022 00:12:31 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2109.outbound.protection.outlook.com [104.47.70.109]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fs1a7p9kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 May 2022 00:12:31 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BN8PR10MB3153.namprd10.prod.outlook.com (2603:10b6:408:c1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Fri, 6 May 2022 00:12:29 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5206.027; Fri, 6 May 2022 00:12:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e95e6bd-ccd1-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=SaCvlo62Y0mbNxGVaoty4LRK6rhNma/WwiRi++Rk5k4=; b=wU71IuQbkEJNQEecrYS3gDVvAT9i2gZsPuln39Jzh6tuAa9WYF93OWGEeK9+cKwLCa9J qu2pG3X61NAUF2UgvKwwXesnl3WkPd6fEFFwFZ5aDBUC3W7whKlg4ZM0TQ1q0mWDnCEy t3xIGPPraq7j+rqT+5/ipdRdlKIrD+9BWVc7ZC+ZpwJLzAuxw85YZidtNrqhwI7vgrLB 2uFE8MYFewtzVYIuzZ9WamhFshtaes/RlpWZoABvj5tF2MbSqxqEzuEmmyVcTzg8/tFt WJtFmfU7/hg1r2WP/eAGcdeMPQrePEsoHPwEt8ryNFbJc/KGnfih5K015tCHTG74OrL3 Fw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Etj+rlCgq6lRjOBYJxSV4BvChtY2RFq2WOG3WKI4UC73EKB775eASAaySBLOprtvW8UbS6ZWiLhBKRCLb72QanMQSTn3L9tDzVlUcj6Yzt0wN1bcel1vwE13es/QsqmzOaPFdtzVR+lJxlLrTzCc9d/FmwYHk9tzLyViLZARZ2Xvfz7AKIglVgrrorMUwGckJNtoa2H1zPgQvsA/VtSZo0rOPfRwnrYSkYTSwxg3VQMSic8f6BuCe3fmIBro3/s+mPD7SqkDrJigfsLLfzwRj/ObsCWT8VCnP2wZ7lh0eCZvgD//WWIrM2gdm2+oXAmg3NxVA+yS7cRCusVO04ofSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SaCvlo62Y0mbNxGVaoty4LRK6rhNma/WwiRi++Rk5k4=; b=EwIaY3JWc7VjJebEq2AGG9QQuJdVNQowWLMQkpcNACYWZE+Ey4gpJDtGZaIzNAKNbjQ6rsnAEy1t3p8c5nFdWi8jkAdhb61UbUU/KhwLWlisxke9O0thWeCNuHeV0a2FTG/3i3tkRoQNreWRDF/73bHLiz0kkA2UAidOyt6K3aXVTOwps7us+atrUNeBN45nx2N6QDLytklxVR5BtGulazxOO4BpEzow6kmrW514t+UaUVPHoKk31XYCKicB+UfxIStv+30GjUeVMTBNwDGY10bp3W8iEuN1RipwWS85pvzoqJwLi0Wc5FE+zA6W/eBuEavg6KUh4mGZzyS6012r/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SaCvlo62Y0mbNxGVaoty4LRK6rhNma/WwiRi++Rk5k4=; b=Vzw1PNNqjKmr37LRPuhfltu0CUt3DgJefzvsZbAdiZQ/84MdTTyjDumowYlJ/pLidEvo1PCAUSLoLIWVTtZSTYUktf3528WUuifgZfxyquwxDYTJW427o1IMV/pJJ8hs4dUF1BAWjTUAFfKUg0i7rfPjsphv7D0nqsumeZUgbSU= Message-ID: <51a1761f-9852-d064-05fc-0a98a8304506@oracle.com> Date: Thu, 5 May 2022 20:12:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 00/21] xen: simplify frontend side ring setup Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, linux-pci@vger.kernel.org Cc: Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Bjorn Helgaas References: <20220505081640.17425-1-jgross@suse.com> From: Boris Ostrovsky In-Reply-To: <20220505081640.17425-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN7P222CA0024.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::20) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14e0a6ac-6d3e-4b08-5c4a-08da2ef51bc6 X-MS-TrafficTypeDiagnostic: BN8PR10MB3153:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJSu4fd8iWYoSgOLgFOy6ufTMLJ/58x7jaLn/pdT3Fo1pRCKoqywCzViN82fgGcYo7lKu8zPv72fa+b2+CRu0v8ly5dvhf0yh7eavwdPE8YBSjKwb6P2ymriOaoSP/NS4ux/xHoudKgWvYDvLqL4yuaXnXmFkfuueOzq7h1wuDyWqYE+n1uR8pwXzw+Ni1hq7QGtCZY1cgJNlcQDteVfTz49CkOfU5ZoB49wtMGCLKZUC2m/lU9xY6cyyu4xw0RraBn21YyUfwvsJ/W7U47HiUMX3WcH9Uleo6CQ4clA5raPM5bu9IjrdKMitFFyTmtD6WWqwXiH4NBTHlswJrdnXtZZKmsPoUedzVbCkhSfAgzkmEAOscFMYrW8HspYk72RT7bdMk2iM6m9iGDGeKgtb7/xvy4hghQ/onwSiPDT6jHgklyg1eGcQL7KdLWuCP5zN0XsODGJ7p0VS3VIRGfKCWRdKNHzeidZXcfWiopKPiAH4BrSXnHBBIzYmUHl4TNMKOoeVB9Gj8GgPd+4Ikibt5/pU9uiBCVtAw3tMmWDrG6Notmb286qvvEKygLMAYn8w2YaGmNWCJ5MDGSTOBLAdzc2giBDGFdilN1ompRo4xroA6Msykrdg3+98dkq6MMcoPVOi97pni7isEdyi8YWIeG65v+PWzvOAx9PbJ9iiHeqscal+pWg1DnCjhgfQ5kdDZRyDL7DExJB/aGXqPAwcd1dsHuI+6ciPVXvccKA/Lwtvbzez1P+5YAIxvYKvR8SlF5+qB57OBu133XoAPFQJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(31686004)(53546011)(6506007)(6512007)(2616005)(26005)(6666004)(508600001)(186003)(36756003)(6486002)(44832011)(4744005)(5660300002)(54906003)(7416002)(8936002)(86362001)(2906002)(31696002)(316002)(66476007)(66946007)(921005)(66556008)(8676002)(38100700002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bytxaFk4Q0FGZ3RvTFZZOExlOHpOc3dyUzNXKzNOWExOT1d3R0Z0UTN0OU1s?= =?utf-8?B?c1lpRTMyZVpPUHNpSFIxQVZOTjhnSmdGTWJCM0txMm9XSUlHUjJSNEtVVGhy?= =?utf-8?B?QnNRcVlIYzZOVHM1R0lFQTRaQm8wNnprSCtwWGtvTnVSRjJDemJ2RW1YcHNl?= =?utf-8?B?ZW9henBhbkN1NTlrZjRyUHJWNWRpSTZndnpZb3luQUFFTWlyMW1UNmRsUWdZ?= =?utf-8?B?dFVZbStXalhxNkFmSEZ1UDQyT3VOb21nUWRhZ1hKT09zNENYQkczYkZNUTFq?= =?utf-8?B?Rm1aQzRvOS9NejdDZU1hcDE3dGwzRFp2dytVVTNyZW5ob3gwTlRCZWkwblZa?= =?utf-8?B?N0dxRElvMnlUYXd1aGxzYVNEekVrQ0Ywa01ueXBwMk5HQjVmbUt1b3h6KzF3?= =?utf-8?B?K2tIL0V1ek1sWXpiY2c1NUhIM1BRQ1JPbDZwSzVnZDFjakF4TDJLdTFpV0hz?= =?utf-8?B?OUR1RnZ6QzJOa1NlKzRLdUlqblExMXNTYVhjM1hWZUN2R3NEcDZITkJKaXBa?= =?utf-8?B?aHczTXpuS2F2bG15TlJpdWgwQXl4WXhXYk90WkpISmZ1QmExRmM3dlZCUHRQ?= =?utf-8?B?U1prSXNBc2lONWQxN3V1elI3cW1yWGFzNDd4d3hQMmZvTktJa2R0VGxtMXo3?= =?utf-8?B?VDNESzVLQkhaeWZXL211ZHhCWWUxZkdFbVhBNUNSeXZSY0s3OVFmZng0UWZn?= =?utf-8?B?R1BnYlRBbGJkZWd5RUY0alFWZDk0Qy96QmdNZHdGYjRiaVRJdWh0K3lqRDJp?= =?utf-8?B?WWRBTStQeW9wOGZxU0VYTVEyYndhQ0MzUU5OYkFiekp0WTBucm9NMEI0MW9J?= =?utf-8?B?QVZwaDJEeElIL1ZVaDZFcXJ3eS9XTEdUV2REeHhJZXFBN1doUDBqZVUzQmU1?= =?utf-8?B?bjg4RlhKNnRNbEN2UERkL0Fsc0QxditCM3lvNmJoK2ZsaGUxSi83by9wTzNi?= =?utf-8?B?SFh4TmFZNkhjUUp3SSszY2Y3ZzBGOG9uamY1bkNPS2Z2Y1F4MXZXME0wak9K?= =?utf-8?B?Z3lvdjNiVVMwVmNkbXZYdW93WXZZZDRwYkMvV3BRWkdrODVmOWwyRXVib0Jt?= =?utf-8?B?Nm5rY1lkR21BT05QRTA4SE9POVk0VGZkdFIxZ0N3VjRpVWF6Q0x4a2ZyZkho?= =?utf-8?B?UDVibWI1d3N5SUVaS1RleCtNSmJRVE1zSnhaV0FIT0Rkb1gxendEOWRQK2ds?= =?utf-8?B?TUI4Rm0zS0JOTk9YeFBHUE9YMFdINGJJK2k4bWcyZnRFR3FyMGJRY1ppL3Ru?= =?utf-8?B?SVlrdTdnTnFtK1RsL1BEMTF4dGZPMDQybW4rSTdBY1JjeVdPd3VQK2RCc3Ix?= =?utf-8?B?ZzhEejQyeERpaitjOEJKZjVjdzVsUG5ac1I2OHRCOXFDVXFrV1VZVVdHcm5S?= =?utf-8?B?R2luVlJqUllRVGhwNFowK3lPd1BvNnorZHdrOE91RW9XQWxvWElDdTh1NXBQ?= =?utf-8?B?NjdaNC83QkRNbFFyWHhJQU5EM3hGOVZjVWEzek9TVE96TGZPQUtmeldrT0o3?= =?utf-8?B?cW9ZeUd0RnMvUDMrR3JLT2VLSjVodEpZc1V3d1dDRnpoL1JsbmJBbGtaTDMw?= =?utf-8?B?dXkvb0Z5ZGw2WmhiZUIwTFVJUEF3NnE1SXBKQkEyYkJsZXlZaEoyVFlEcDZY?= =?utf-8?B?TURXcEc5WmthUy9jTUlURGJEMExxaFoxUlVsOE9aTlh6LzdyVUxsSXpxbCtz?= =?utf-8?B?aXhFMnl2eWlMRzY2d3NMdXR5S21pby9DS1NPQnh0ZCtNTWdFb0x0WmZtcmFn?= =?utf-8?B?MUR4SUNhOUhacjErWVRQYnE0OHFoTnNYQW1DUy92OUZxWExpakRWSkVkYU5I?= =?utf-8?B?REMwSFZqQ2NzQ2dYdGNkK3Q2SkNSdzRLVEh4YklFZ0Vlb0xOVWNvbXdtWmhV?= =?utf-8?B?VUZWb3oxdGZtQzdHbS8rSndRKzBqYXk3MXRyVGtwR3JkUG4vMzdjcG1RS3Fy?= =?utf-8?B?V0JoM0xUb3FCbEFIVS9saWg4NVdyU3lVZmw4ZmlTdlhHcG55eXpkWnFmZFVT?= =?utf-8?B?NXVIYUhMeGpEby9jaGpDVzNXOGFBckREUWllTVRyZVR1T3EvQ2txN2V2WXZy?= =?utf-8?B?eDVSY2Q3TStMTmtueExsZ1NsT0FjV0cvNVArT1FPRDJINW5ETUJuUlBEZnRs?= =?utf-8?B?cDZsdWcwSzNUZ3B5TFgzTXB2SzNvRmwxVWwvNGF1SGxUL1FFcEZSaS8wRFB0?= =?utf-8?B?NzdzUUpKdG9IR2puWUVORkFFcWVNRUl4dUovMlNkYUVpbWg0cHBaMkdHZmFE?= =?utf-8?B?dDM3dUJuSFUxenJVaGRpR0dOb3VwbWVmSFQ0Vk9GUkNzdnp1SmZncXliKzhh?= =?utf-8?B?OUN5dVE0QVVqckVWcXJnanRxVEduckVnZTJnTUx2WFhnL3hjWEMxNWRYRHcw?= =?utf-8?Q?sdsvwoAp5hbzZW54=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14e0a6ac-6d3e-4b08-5c4a-08da2ef51bc6 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 00:12:29.4977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hYulAuZhXmK5BaUUYMzlV9HQeCTsYoFltdGk+LDG0YX9O3CRYmG/rGitCA3acrGEhNhjaRQ/jwbjgosZ9KigRlxLMXlok9CDeFxtmfhZRiU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3153 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-05_10:2022-05-05,2022-05-05 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205050153 X-Proofpoint-GUID: XWU0bMd3BhK7XLGpuB-x1jMxs1RfxYRX X-Proofpoint-ORIG-GUID: XWU0bMd3BhK7XLGpuB-x1jMxs1RfxYRX On 5/5/22 4:16 AM, Juergen Gross wrote: > Many Xen PV frontends share similar code for setting up a ring page > (allocating and granting access for the backend) and for tearing it > down. > > Create new service functions doing all needed steps in one go. > > This requires all frontends to use a common value for an invalid > grant reference in order to make the functions idempotent. > > Changes in V3: > - new patches 1 and 2, comments addressed > > Changes in V2: > - new patch 9 and related changes in patches 10-18 For the patches that I was explicitly copied on: Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Fri May 06 00:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 00:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322457.543762 (Exim 4.92) (envelope-from ) id 1nmlva-0004xB-Gd; Fri, 06 May 2022 00:34:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322457.543762; Fri, 06 May 2022 00:34:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlva-0004x4-Cw; Fri, 06 May 2022 00:34:38 +0000 Received: by outflank-mailman (input) for mailman id 322457; Fri, 06 May 2022 00:34:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlvY-0004wy-VV for xen-devel@lists.xenproject.org; Fri, 06 May 2022 00:34:37 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c142a3e-ccd4-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 02:34:35 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E3C2E32004ED; Thu, 5 May 2022 20:34:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 05 May 2022 20:34:31 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 May 2022 20:34:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c142a3e-ccd4-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651797270; x= 1651883670; bh=4fuzwXGW6jdzk5aPMIJm9U3GDfDnsy/WcfnqqxRJkLE=; b=n scaNm3vHXqKB6RJv9Bg1zliCBfRE1RAuCUQFGM425nIbHlnMrrVMIIJzJnPNQAcZ +aDY4IScmrDBhCEUx/iCWptFaaHE5pivFEmn0oIZwK/Sr/ljYNJ6YXY3CuNmxJOG 0Z1Tim8a5yiSlkhrLEiV02IExvnWLhMnzjG1kxHYABKyygmNu1BUUMWH7yZESZL1 hsW0S07jFVHqIpYy2N5WihpubvrocP7uIkpXB0QOQbWx8hqMNrLHB0Q++DZk6wme kAVUo/ej784Y1ztxFDQlk2S4Dk9FonwAVFe26TRrzXv5jhH3YyMrGRZ6rb7dbl6q jzDuvN5qyyXd7ni8vRK6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvgdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Date: Thu, 5 May 2022 20:30:17 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Proposal: use disk sequence numbers to avoid races in blkback Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sBH/PEPWRYXGqvzq" Content-Disposition: inline In-Reply-To: --sBH/PEPWRYXGqvzq Content-Type: text/plain; charset=utf-8; protected-headers=v1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 5 May 2022 20:30:17 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Proposal: use disk sequence numbers to avoid races in blkback Proposal: Check disk sequence numbers in blkback =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Currently, adding block devices to a domain is racy. libxl writes the major and minor number of the device to XenStore, but it does not keep the block device open until blkback has opened it. This creates a race condition, as it is possible for the device to be destroyed and another device allocated with the same major and minor numbers. Loop devices are the most obvious example, since /dev/loop0 can be reused again and again, but the same problem can also happen with device-mapper devices. If the major and minor numbers are reused before blkback has attached to the device, blkback will pass the wrong device to the domain, with obvious security consequences. Other programs on Linux have the same problem, and a solution was committed upstream in the form of disk sequence numbers. A disk sequence number, or diskseq, is a 64-bit unsigned monotonically increasing counter. The combination of a major and minor number and a disk sequence number uniquely identifies a block device for the entire uptime of the system. I propose that blkback check for an unsigned 64-bit hexadecimal XenStore entry named =E2=80=9Cdiskseq=E2=80=9D. If the entry exists, blkback checks= that the number stored there matches the disk sequence number of the device. If it does not exist, the check is skipped. If reading the entry fails for any other reason, the entry is malformed, or if the sequence number is wrong, blkback refuses to export the device. The toolstack changes are more involved for two reasons: 1. To ensure that loop devices are not leaked if the toolstack crashes, they must be created with the delete-on-close flag set. This requires that the toolstack hold the device open until blkback has acquired a handle to it. 2. For block devices that are opened by path, the toolstack needs to ensure that the device it has opened is actually the device it intended to open. This requires device-specific verification of the open file descriptor. This is not needed for regular files, as the LOOP_CONFIGURE ioctl is called on an existing loop device and sets its backing file. The first is fairly easy in C. It can be accomplished by means of a XenStore watch on the =E2=80=9Cstatus=E2=80=9D entry. Once that watch fire= s, blkback has opened the device, so the toolstack can safely close its file descriptor. The second is significantly more difficult. It requires the block script to be aware of at least device-mapper devices and LVM2 logical volumes. The general technique is common to all block devices: obtain the sequence number (via the BLKGETDISKSEQ() ioctl) and its major and minor numbers (via fstat()). Then open /sys/dev/block/MAJOR:MINOR to get a directory file descriptor, and use openat(2) and read(2) to get various sysfs attributes. Finally, read the diskseq sysfs attribute and check that it matches the sequence number from BLKGETDISKSEQ(). Alternatively, one can use device-specific methods, such as device-mapper ioctls. Device-mapper devices can be detected via the =E2=80=98dm/name=E2=80=99 sys= fs attribute, which must match the name under =E2=80=98/dev/mapper/=E2=80=99. If the nam= e is of the form =E2=80=98/dev/X/Y=E2=80=99, and the =E2=80=98dm/uuid=E2=80=99 attribut= e starts with the literal string =E2=80=9CLVM-=E2=80=9D, then the expected =E2=80=98dm/name=E2=80=99 = attribute should be found by doubling all =E2=80=98-=E2=80=99 characters in X and Y, and then joining X = and Y with another =E2=80=98-=E2=80=99. This accounts for LVM2 logical volumes. Alte= rnatively, one can use device-mapper ioctls to both check if a device is a device-mapper device, and to obtain its name and UUID. I plan on going with the latter route. There are *many* other rules that might need to be followed, but these are the most important ones. In particular, this is sufficient for device-mapper devices, which are by far the most important case for now. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --sBH/PEPWRYXGqvzq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ0bRMACgkQsoi1X/+c IsFN5xAAlusB3Q7DsZRqGMbud2GkOlcxHockfDCNpbmFNwSAF8fqpahqKm33dTq9 v8veYst4jCKcEJqUiqU8rb8syGvBP6DW/PR162k/0uxtX4ox9+mxj7VtcZ/ReSQR tVN12gPHQzxhImXtTdg5vuw6qbAs4Ykch1kc+febuq4IzXzWhyI5e4DaEk8Wpmq2 ZsX9RKY/dRN9rEt5WRd66B7v4cCItA2t9lMpus6QN4uRq0SnSRqutemjr/m9vTYj thGRYskXub8SshzNUjnkwe4fBpNjfY43FXLPhJn0qzwL+OEh3bTHqNVfrJ0VAiPM Ao8+3Oiy4ENef5dJhUaBuDR4fY2UweZyuZ0J14nJ3x/eLWndIQSNu9QM7K+jYFul jGkHVjm6GxzmHcwHonksr8Hh31HwZBpmC5G+O71aW/sV7c8AtOP5N6oJHAjR7mez QMaxZaIYF2ih2mtRgyfD9CK855IfssMHkspg3zkiYQiDkGiUd77qzpxVE3/Jn2VR ik/FxbO/4K4+gB58H/Pgo4Gwp/jml8Px5IHJ6C3PxUXQr+YRhhsNmiTEK3c8UHNr Io2peTvFAJqaNE6Y8sx4udlxMCvmZGorFtlrwAvULtfVn0aonM+DKMfElvN7vaDB NViuqGND+XU8Eg2P/an74AuV/vikLdijtWCXOHTFbJkLWoZKZvg= =zoaQ -----END PGP SIGNATURE----- --sBH/PEPWRYXGqvzq-- From xen-devel-bounces@lists.xenproject.org Fri May 06 00:36:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 00:36:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322466.543773 (Exim 4.92) (envelope-from ) id 1nmlxh-0005dT-0U; Fri, 06 May 2022 00:36:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322466.543773; Fri, 06 May 2022 00:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlxg-0005dM-Tb; Fri, 06 May 2022 00:36:48 +0000 Received: by outflank-mailman (input) for mailman id 322466; Fri, 06 May 2022 00:36:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlxf-0005dA-LU; Fri, 06 May 2022 00:36:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlxf-0002ue-J0; Fri, 06 May 2022 00:36:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmlxf-0006Ex-7b; Fri, 06 May 2022 00:36:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmlxf-0006FZ-71; Fri, 06 May 2022 00:36:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WC3DgILIVRYssQbFIzXS2mvP4Vgu2ZbXoAhibUplCEg=; b=4kwNbP7d83ScxeCNxDf3rsl257 2uAUqjivbGnOo5s2idCqLQx0djWtvmrMZ+Yu1eKjIReu+ZTnS+8E7IZL7aB7RlAqaFT1j94lLiv99 YcgIWRG062WhEtVSdr0oCFe9XjUl92q0dB1AL2kdJ28D2aAaau/tJncMx4r0xAT8wUt4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170152: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc X-Osstest-Versions-That: xen=5d2d5365ffadf075fd812038ab0841a3e868f906 From: osstest service owner Date: Fri, 06 May 2022 00:36:47 +0000 flight 170152 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170152/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170133 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170133 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170133 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170133 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170133 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170133 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170133 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170133 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170133 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170133 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170133 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170133 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170133 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc baseline version: xen 5d2d5365ffadf075fd812038ab0841a3e868f906 Last test of basis 170133 2022-05-05 01:53:24 Z 0 days Testing same since 170152 2022-05-05 14:08:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5d2d5365ff..c1d5e4021c c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc -> master From xen-devel-bounces@lists.xenproject.org Fri May 06 00:56:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 00:56:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322476.543784 (Exim 4.92) (envelope-from ) id 1nmmH0-00085O-JH; Fri, 06 May 2022 00:56:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322476.543784; Fri, 06 May 2022 00:56:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmmH0-00085H-GA; Fri, 06 May 2022 00:56:46 +0000 Received: by outflank-mailman (input) for mailman id 322476; Fri, 06 May 2022 00:56:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmmGz-000857-2C; Fri, 06 May 2022 00:56:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmmGy-0003FB-Vw; Fri, 06 May 2022 00:56:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmmGy-00072A-Jz; Fri, 06 May 2022 00:56:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmmGy-00056S-JT; Fri, 06 May 2022 00:56:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mYbGl+W0lKcO/+QgbCFSN7HiogMYSqQf5DjavT1ZFn8=; b=hq1+OP/aU3Sbl76JHuivm+budF wYb3DK93iMPLHVeAvGcdvrRT/Ci1iPCTvPFeZ9wBEe1UZndkH5lNapqZX4pzj+Gsl3FSU2ZnQ8+CC pWYFU5ZenLq/SwsQnmOOl8v8ngAAtg24rTeLa1+BGjZQU6YE3/UMSOhA2keFKKEctHFY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170163: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 00:56:44 +0000 flight 170163 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170163/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 65 days 829 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 53 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 02:30:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 02:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322488.543795 (Exim 4.92) (envelope-from ) id 1nmnix-0007zy-K8; Fri, 06 May 2022 02:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322488.543795; Fri, 06 May 2022 02:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmnix-0007zr-Gj; Fri, 06 May 2022 02:29:43 +0000 Received: by outflank-mailman (input) for mailman id 322488; Fri, 06 May 2022 02:29:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmniw-0007zh-D7; Fri, 06 May 2022 02:29:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmniw-00038l-4Z; Fri, 06 May 2022 02:29:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmniv-00039w-OR; Fri, 06 May 2022 02:29:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmniv-0000dS-Nu; Fri, 06 May 2022 02:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0uKjj/S9o2NGQ5O91kciQlZjo3zGyGHCl/wTvj8v2I8=; b=231RjMhXhACyMaqBhAOFWZ2UBD wrCiwjBJ2mLKPvgUS3eCKN8hI/dyKsUD9SssKIYXJgGYT4fa1p7ZsxLd6bRta+GlbQm394Pgu+xm9 CmJtO8EFYW89949QNdb00I3JYkEldnsFMStmHC2CmHtE8aw+GMmHnjNs8IrixcL+ekCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170165: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 02:29:41 +0000 flight 170165 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170165/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 830 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 54 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 02:59:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 02:59:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322496.543806 (Exim 4.92) (envelope-from ) id 1nmoBq-0002sx-UB; Fri, 06 May 2022 02:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322496.543806; Fri, 06 May 2022 02:59:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmoBq-0002sq-RF; Fri, 06 May 2022 02:59:34 +0000 Received: by outflank-mailman (input) for mailman id 322496; Fri, 06 May 2022 02:59:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmoBp-0002sk-TR for xen-devel@lists.xenproject.org; Fri, 06 May 2022 02:59:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060a.outbound.protection.outlook.com [2a01:111:f400:fe0c::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d38e226-cce8-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 04:59:31 +0200 (CEST) Received: from AS8PR04CA0010.eurprd04.prod.outlook.com (2603:10a6:20b:310::15) by AM9PR08MB6673.eurprd08.prod.outlook.com (2603:10a6:20b:307::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 02:59:29 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::99) by AS8PR04CA0010.outlook.office365.com (2603:10a6:20b:310::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Fri, 6 May 2022 02:59:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 02:59:28 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Fri, 06 May 2022 02:59:28 +0000 Received: from c91061c06ad6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F7013265-B0AA-4429-A8CC-47403CB3C494.1; Fri, 06 May 2022 02:59:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c91061c06ad6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 02:59:18 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by PR3PR08MB5802.eurprd08.prod.outlook.com (2603:10a6:102:8a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 02:59:16 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Fri, 6 May 2022 02:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d38e226-cce8-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dFeD6UxjPW5hpZkbqGRygnO7yskpvf/e3q6QAvjHOmp49hlrTfMdaKdcSKSK2Hgz3KmHen7O98tSNB3qWgg7M6jtG15cvkEqfX4gfrn3nLCwhNk1V34/5zVE42NbAmfby/r7lbaUPAnt6QKzQr+t3G42YqwjrP0vTbzyhRGWkNvskBFpyAQFDimG8t149xrkx99py3v7ZTKxLARB2FZ1vFp5nFxzgdOBS9vwxCantZTs35Qe2T9xA//SWu0HN48Tppn7k2kRBAa9keQU6xoNouj5l2UzyOalANUBy8ppLHuymWEC1bwFVvAHCMHiz87H5u1voC2eRC5xDlQ3Zl8JWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=BHIa8Q5GEOQ7wdyCvXdI+r4wV6gI9ZzWQCuWklj8o3Il3upK2VIX1rS5VhY2T8bk8uQrpl2ySxPq/Klc6xkosJOX4+Ub7voThWmxcsJp0ctNUmf/Upinqy5S97K2pSPadGxwfIIz/SCeOR4w9eHseNWfu5o+IvGQvy4sixtD2CoSfXuDikuq0/qOQtQS0SmDgXB7Rq1+h++Ysj5Dczu2/hDYlbTlXmRs05qvjt43cU5FqcwX0u1V/iZsfNLtIQ1NRJxko59GjLQPs5cMtQApg4QBJbQSkrwpj/yxjfmCIgNFI2ohl2LBunP+loPBkiztJYGcM7ULm7FX1ksSQCZNZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=7DrQa8oSZsslZ8ceQYuMVk2yVDyjaHK7pFSFLZpWXw1ZuFf5YmwnX+DV8lfQSnalm8HtugAx2mgAF1c6xmAjGl/fYwoggRL4VPlqVF0Bmkk704115BUYbzG2NHDgD6uV7BJSpBxHIDQZmHONs0kZlC0gw3n8IN8JjPk399L70qg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=muLQIFPgaPXvY5qMMGXJDJyW+TgAryxPSqO+TUPDxemf90dP55sLISdtrluzZ6IZPm6KJII5ASEn/ODrreETwyDIMIqSoty7SOb55Apu0bgAwt39yPT0pJp0wYjcKkyYl6hg1dAObOnIg2FRC6gqwkJetDS8FWJ66z+1svBnp/NOSiVWSH+rijgNHLlW5Lys4p81sh8z0YYjUIJDIp2XYo063AnGJLymq75AYE5GhqD+i9Di1gLtESBnlZHgjw0BMImABBDqMFGxy8zDMwt3XAxj5+lcQO9yafQO7frYVqg256LSmBnnL1xT/QidAmwfU9dm8/mbKSgaLIdCIgXg4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=NI6jK89UhRisb8ZjxmXDwPArL9rwnGZlZzv5XkyEFaCNKv+Mbdp3Gveb7sao7XzArvVDlGfwR/OOODedW9dkbmwvTYjFWsnufn+hhcl2m98NG2jBl7qc/agwkuOJ6zY2AB/T1MTeYF5SJNYX8UHeyVBIP2eIt548OODWUNKyE1zTmdyQVYgDlV5NwVcxVd/gyLr8MPPDmD3V4GaUS7/n4zSCjUuyvKF1LGYJ10+V/AHSEUxUJIU3D0jK/rkRTZXtlqULVfrUqLA4P9lzekKNkdHWFEA09WZ1cJaN805//o7qcoh0ILA2Rj4AjHBHx6iPJsauRFI2cODn1QbjoGXz4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=7DrQa8oSZsslZ8ceQYuMVk2yVDyjaHK7pFSFLZpWXw1ZuFf5YmwnX+DV8lfQSnalm8HtugAx2mgAF1c6xmAjGl/fYwoggRL4VPlqVF0Bmkk704115BUYbzG2NHDgD6uV7BJSpBxHIDQZmHONs0kZlC0gw3n8IN8JjPk399L70qg= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUIAAL5+AgAAR4BCAABRbgIAA0kVw Date: Fri, 6 May 2022 02:59:16 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> <306532fc-939d-efdf-047c-7b8556d40738@suse.com> In-Reply-To: <306532fc-939d-efdf-047c-7b8556d40738@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 293709D9FBE14C4DB06254B893466E23.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fa37f831-95b5-4344-890f-08da2f0c6fc4 x-ms-traffictypediagnostic: PR3PR08MB5802:EE_|AM5EUR03FT030:EE_|AM9PR08MB6673:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bE9PzUA+m5mCInEOrSEuLNHzlLe3t/ucvhg/Fs3CcCKI+G1f59ZdZqyFxhjPMsMKqRkZMpt5Y88FV5wvjJSbbwkTQUZdFql4ZNPlC/pjW/Xg5tC6ICVm1Tm3Gq+sqSuX63955QhTljAgMDjFg8ZutZ3Hn0u1BYP4NiVCIgl0H84Hfle8GyjunTazpMN7Mj6AY5nK+DNVZymOfmis8YGnnEo+C7/M+wFugqsWdGjlXs1x9gY5RoF30am1qaJxdelVEbmH3B2WbJXaadDI1DqIKCaDvtihDNOFgOgRe4NrBm0G50iAV/n2KDBuWVkJ1iNarkv9C56/sVJaZHJpNn2yARRU+1AgjKtVGS0yx544PsUejmIo4pTmJ2llVHPHo4SKe8p6Ajmv+btW46dsiyk5Wz5GS6ZonH3vE0WlHJZybzv5pOpC2/uYTrGhHpDf6kejURXysOGuCSqU39DajhvqGabw3VBpSOl9taC3OOYmOM9inNBGr9VN8cXq2GvKnw33wo8hB7o4v3zW+9K8W2ITSHKuiDlnKjd/9wR7Y3NAkwNQt1hOqMntDAR1fmeTy83dQ/j/nbuZtp+X8nTfrO/Xdq6KRsn78Lfoyz4+RxHBaq8XfRVKPDt2AEZ3qjFylVlXmPqLHurwE3OrWpj8Gxsbsw3bWrjbvi882lNmSZdlABvaIaCfjKrfrsMuoFmN0MPdl3bbnK4PP8r5YV3L+dhQSkZBXiy21s8d/K48ZWhh8Pg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(186003)(7696005)(6506007)(9686003)(2906002)(53546011)(33656002)(86362001)(122000001)(38100700002)(38070700005)(83380400001)(55016003)(8936002)(316002)(6916009)(71200400001)(52536014)(508600001)(54906003)(5660300002)(64756008)(4326008)(66446008)(66946007)(8676002)(76116006)(66476007)(66556008)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5802 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03bf6b2f-e7d5-4502-1fa8-08da2f0c6852 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZbH0u77rXfWwUmJKbdrDicOphobB2HOgriLp/8DkZ/O/1JG697tHybZvYP6gUNN8vbZQ7Ft5ECAw/5rquuTt36g4l+v3w8+2+CGmyCZkO2WVbsm98u7+wOgNFTg7lR+JLTYXX+zxRl70Q48LqOeXnI9U5YREhVWXqC+YJRKcAbklIRFEqB+yG7UmSZnQkXJN2w/5E7xPM3VywX0WiI+aQsLTIHF7wHeXkho6V4gYcbPy6DpI96Wk5OSQWiOiIFjT2M6l9UfFiQuytArkpPdZxjIDEAmD6RYj5Rij4pdIW8L9eWXUw5K6g+TSQAsNU1pnMopFuap2SKOqiGxqc6eU38UTIYls+v21MdsmJiG7yBBHAe1r2NGmfDf+KXUQZIIp37/DNcK1pe4uEVoiBoLOx5zUYeffpnDBxSrfntvMqpIp7fuDi/3zgms6dyMW4l8BHLADX5pBuhPTlMUJAmzdm9GDpUf1aGaDhNthh4qV7xIc4WRcUdKFagssPsqtTVMQE2XN8cIUbpsMaPgNPmkpjLnTHKSEmR+QqDaMSKChM+sS+87qTQr+7WrXmmH5ziOBVf78I+dVgegx7D+ZSFMLAFbZPx+b5yP8Ubl0xB9HsRg+iiX7YWwrcIY9Mhwbdk1gOiKzYeqPYt4N1TCInqcWLkWlE+bH9ORomgIWCaCTiuw4OF8Hz2J5zKZbXlXZLv+FlZxiMkVVGk21MWrAOZcOHA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(186003)(5660300002)(33656002)(81166007)(53546011)(508600001)(6506007)(54906003)(336012)(8936002)(47076005)(52536014)(83380400001)(26005)(356005)(36860700001)(9686003)(2906002)(55016003)(8676002)(40460700003)(7696005)(4326008)(6862004)(86362001)(70206006)(70586007)(82310400005)(316002)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 02:59:28.6985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa37f831-95b5-4344-890f-08da2f0c6fc4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6673 SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgMTA6 MjMgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ Ow0KPiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1 bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5A eGVuLm9yZz47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47 IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tDQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgNi82XSB4ZW46IHJldHJpZXZlIHJlc2VydmVkIHBh Z2VzIG9uIHBvcHVsYXRlX3BoeXNtYXANCj4gDQo+IE9uIDA1LjA1LjIwMjIgMTU6NDQsIFBlbm55 IFpoZW5nIHdyb3RlOg0KPiA+IEkgbWlzdW5kZXJzdGFuZCB3aGF0IHlvdSBzdWdnZXN0ZWQgaGVy ZSwgSSB0aG91Z2h0IHlvdSB3ZXJlIHN1Z2dlc3RpbmcNCj4gPiBhIHdheSBvZiBzdHViIGZ1bmN0 aW9uIHdoaWNoIGNvdWxkIGJyaW5nIHNvbWUgb3B0aW1pemF0aW9uLg0KPiA+IFRoZSByZWFzb24g SSBpbnRyb2R1Y2VkIGZyZWVfc3RhdGljbWVtX3BhZ2VzIGFuZCBhY3F1aXJlX3Jlc2VydmVkX3Bh Z2UNCj4gPiBoZXJlIGlzIHRoYXQgd2Ugbm93IHVzZWQgdGhlbSBpbiBjb21tb24gY29kZSwgYW5k IGlmIHRoZXkgYXJlIG5vdA0KPiA+IGRlZmluZWQodXNpbmcgc3R1Yikgb24gIUNPTkZJR19TVEFU SUNfTUVNT1JZLCB3ZSB3aWxsIGhhdmUgIiBoaWRkZW4NCj4gc3ltYm9sIGB4eHgnIGlzbid0IGRl ZmluZWQgIiBjb21waWxhdGlvbiBlcnJvci4NCj4gDQo+IFRoaXMgaXMgd2hhdCBJJ3ZlIGFza2Vk IGZvciBjbGFyaWZpY2F0aW9uIGFib3V0OiBJZiBzdWNoIGVycm9ycyBzdXJmYWNlLCBJJ2QgbGlr ZSB0bw0KPiB1bmRlcnN0YW5kIHdoeSB0aGUgcmVzcGVjdGl2ZSBjYWxsIHNpdGVzIGFyZW4ndCBE Q0UtZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiANCg0KQmVjYXVzZSBib3RoIGRlZmluaXRpb24gb2Yg UEdDX3Jlc2VydmVkIGFuZCBpc19kb21haW5fdXNpbmdfc3RhdGljX21lbW9yeSBhcmUNCm5vdCBn dWFyZGVkIGJ5IENPTkZJR19TVEFUSUNfTUVNT1JZIGluIHRoZSBmaXJzdCBwbGFjZSBpbiBhcm0t c3BlY2lmaWMgZmlsZS4NCg0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Fri May 06 03:30:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 03:30:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322502.543816 (Exim 4.92) (envelope-from ) id 1nmofw-0006xT-Af; Fri, 06 May 2022 03:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322502.543816; Fri, 06 May 2022 03:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmofw-0006xM-83; Fri, 06 May 2022 03:30:40 +0000 Received: by outflank-mailman (input) for mailman id 322502; Fri, 06 May 2022 03:30:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmofu-0006xC-Jz; Fri, 06 May 2022 03:30:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmofu-0004Aj-ID; Fri, 06 May 2022 03:30:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmofu-0007b5-2Q; Fri, 06 May 2022 03:30:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmofu-0000Om-1w; Fri, 06 May 2022 03:30:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NYVeIhzlWAkHYQJSM5aBmEhQkOYy3sJBdaJoXrfuZIY=; b=TnP2zo0IenVjJAxW9xEmtckbZf 0YLICOU8uOEgu8aotdXacn6BQrRXzy4RwldbvDVfDt+EEWAAo+MGgkvlz/S6vrX/ImkgiT/Sbyc2Q 6rRx1Yl+NIFiF62X9/Sp5epVtnPm8lH/LWIv5bUmdZJ1a/ciLog3z8wERzgG88a6B4rI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170166: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 03:30:38 +0000 flight 170166 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170166/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 831 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 55 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 04:37:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 04:37:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322511.543828 (Exim 4.92) (envelope-from ) id 1nmpil-00051S-6S; Fri, 06 May 2022 04:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322511.543828; Fri, 06 May 2022 04:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmpil-00051L-34; Fri, 06 May 2022 04:37:39 +0000 Received: by outflank-mailman (input) for mailman id 322511; Fri, 06 May 2022 04:37:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmpik-00051B-6V; Fri, 06 May 2022 04:37:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmpik-0005Kz-3w; Fri, 06 May 2022 04:37:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmpij-0003Vc-Jj; Fri, 06 May 2022 04:37:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmpij-00066e-JJ; Fri, 06 May 2022 04:37:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=00xOYwkK8Iw5H77ADI7TM2WaLBN99u+Px1F+Vfkdys4=; b=if4Ml/sxu0tyHLHDkdr7aztL5T NJLse1vgYvASsxhMsnmtXvQlVtkvua77AGn7JrdNDru99Zqdn8S787msIXWHNAAiUO3nOpkPhnmA5 M8CLKB6tAhuEl5/6XF1lj42dI/KV+Zdq2NZosbdQCXe0DNAyL7JAZcfFSpSHKYkwsQyk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170167: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=101f4c789221716585b972f2c2a22a85c078ef1d X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 04:37:37 +0000 flight 170167 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170167/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 101f4c789221716585b972f2c2a22a85c078ef1d baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 832 attempts Testing same since 170038 2022-05-03 10:12:47 Z 2 days 56 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5915 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322368.543874 (Exim 4.92) (envelope-from ) id 1nmqLg-0001iS-2D; Fri, 06 May 2022 05:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322368.543874; Fri, 06 May 2022 05:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLf-0001ek-Ol; Fri, 06 May 2022 05:17:51 +0000 Received: by outflank-mailman (input) for mailman id 322368; Thu, 05 May 2022 20:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmhtS-0008NH-C8 for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:16:10 +0000 Received: from sipsolutions.net (s3.sipsolutions.net [2a01:4f8:191:4433::2]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32208640-ccb0-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 22:16:07 +0200 (CEST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nmhqM-002xoD-SS; Thu, 05 May 2022 22:12:59 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32208640-ccb0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=G+j0q72Mrx0x/OKxPueCOmNWOMddqEQljKb1F6TvYgA=; t=1651781767; x=1652991367; b=pQbO0gLnzZzZ/JwN9/vlQovy5c0eC6YPX0aMTflGu4AJLYv SbOOG1RWDmfOAljePpZyOuHS2AqFmjFlSht6R4k3Y6kKt9P3rxh5lRZj0w7ndF7n7RykPKvs2BptP B8zW0I+xEZDzv/S3EpIU7ej9+MAzZCbMIAUbDUt+N/Z7bK/VkOxQB3UC88hpAjqypXR5pJ9pSEXuO HZU2Hvg95c72SugPbtBLekT9LIqlfXXQOTVgfH70mg20Oiq5rkLsTq6NarPIWfDpu9MU25U3WyKns 1d+xrD6et18S+Kwfbea0sp29Tu/aV0DY+LV7wfSNDFgURbklvnVnlZ/t2nrCxx/A==; Message-ID: Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers From: Johannes Berg To: Keith Packard , Kees Cook Cc: "Gustavo A . R . Silva" , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?ISO-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?ISO-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Date: Thu, 05 May 2022 22:12:53 +0200 In-Reply-To: <87pmkrpwrs.fsf@keithp.com> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> <871qx8qabo.fsf@keithp.com> <202205051228.4D5B8CD624@keescook> <87pmkrpwrs.fsf@keithp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned On Thu, 2022-05-05 at 13:08 -0700, Keith Packard wrote: > I bet you've already considered the simpler form: > > struct something *instance = mem_to_flex_dup(byte_array, count, GFP_KERNEL); > if (IS_ERR(instance)) > return PTR_ERR(instance); > Sadly, this doesn't work in any way because mem_to_flex_dup() needs to know at least the type, hence passing 'instance', which is simpler than passing 'struct something'. johannes From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322360.543859 (Exim 4.92) (envelope-from ) id 1nmqLf-0001Pw-94; Fri, 06 May 2022 05:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322360.543859; Fri, 06 May 2022 05:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLf-0001Nx-0R; Fri, 06 May 2022 05:17:51 +0000 Received: by outflank-mailman (input) for mailman id 322360; Thu, 05 May 2022 19:32:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmhD4-0004WN-3d for xen-devel@lists.xenproject.org; Thu, 05 May 2022 19:32:22 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 147210c8-ccaa-11ec-a406-831a346695d4; Thu, 05 May 2022 21:32:21 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id k1so5327212pll.4 for ; Thu, 05 May 2022 12:32:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q187-20020a632ac4000000b003c14af5063fsm1666643pgq.87.2022.05.05.12.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 12:32:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 147210c8-ccaa-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EOewjZKogNzEx9zFkxTiwVeX9O73E8+rxUrKCGLnZxg=; b=TgYp87XeMuHw4kfuuIYKyJ5xg3Bf+EBlgFpOVZz9+/0BPs+Z6azVvmnOICk6zx2eTE tczIFjF07XtN/n9uGmSnmZf+pbPbkOzW9u24HVcBrKjfFRAXW8suN/eYiFsQiaSTDjAj AGDsgPRlkyLVEDH7ZM2ezggNxFIlqaWFz6sF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EOewjZKogNzEx9zFkxTiwVeX9O73E8+rxUrKCGLnZxg=; b=OJtc/+6Hh/aVYasailIzy1n2itDAEIfh5OLXb3asdy3vHE6IpEH3v8nfeMIgvvekiP ksPRGq2PUgElut+wOrDzlXpTIxfGg8UPTbJI0AEn3Jnt/2PCs7KRS1BKxbqOblMo0kvL fGZ1FHMjUdnPjFd8Czbm/K2Ya+D0/5EKxPGK9pFLwLHJka/kwmB1XrTBXSSWpKTZpyRi wYDZeOZhMTKU3C8GlBZ/PbM83NOBb5lplfrRmRD4IfiKdFdMDK00vCgGc0aVPsNCW8i4 6WvojIXm11D7J27grcGlX/xvQhyVsuwLoofGu/EPpOPqZx0+7a6JBjnpRd8O22StfR2D xZNQ== X-Gm-Message-State: AOAM532BTQWV6XmRI+RYW9y+ezliXHorqGEsBq8b8VNdPJC7F8+rtJfW UQBKfdwDOVMkzVzQ194MtGuMNw== X-Google-Smtp-Source: ABdhPJxL8Xyqbkq2ci79I6DY8zysA5FCbZa+vgjColIyO04wVwYosK0CB3nAiv0hotnSlV0fyXrrOw== X-Received: by 2002:a17:90a:c08a:b0:1d9:88de:d192 with SMTP id o10-20020a17090ac08a00b001d988ded192mr8024103pjs.8.1651779139639; Thu, 05 May 2022 12:32:19 -0700 (PDT) Date: Thu, 5 May 2022 12:32:18 -0700 From: Kees Cook To: Keith Packard Cc: Johannes Berg , "Gustavo A . R . Silva" , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Message-ID: <202205051228.4D5B8CD624@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> <871qx8qabo.fsf@keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qx8qabo.fsf@keithp.com> On Thu, May 05, 2022 at 08:16:11AM -0700, Keith Packard wrote: > Johannes Berg writes: > > > Yeah, dunno, I guess I'm slightly more on the side of not requiring it, > > since we don't do the same for kmalloc() etc. and probably really > > wouldn't want to add kmalloc_s() that does it ;-) > > I suspect the number of bugs this catches will be small, but they'll be > in places where the flow of control is complicated. What we want is to > know that there's no "real" value already present. I'd love it if we > could make the macro declare a new name (yeah, I know, mixing > declarations and code). I don't think I can do a declaration and an expression statement at the same time with different scopes, but that would be kind of cool. We did just move to c11 to gain the in-loop iterator declarations... > Of course, we could also end up with people writing a wrapping macro > that sets the variable to NULL before invoking the underlying macro... I hope it won't come to that! :) -- Kees Cook From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322329.543839 (Exim 4.92) (envelope-from ) id 1nmqLe-00018D-7I; Fri, 06 May 2022 05:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322329.543839; Fri, 06 May 2022 05:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLe-000186-36; Fri, 06 May 2022 05:17:50 +0000 Received: by outflank-mailman (input) for mailman id 322329; Thu, 05 May 2022 18:39:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgNm-0005rK-Dt for xen-devel@lists.xenproject.org; Thu, 05 May 2022 18:39:22 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ace1cade-cca2-11ec-a406-831a346695d4; Thu, 05 May 2022 20:39:20 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id o69so4959550pjo.3 for ; Thu, 05 May 2022 11:39:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a23-20020aa78657000000b0050dc762818bsm1678035pfo.101.2022.05.05.11.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 11:39:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ace1cade-cca2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bIDYG8oUb6Mu7NvJ6XCyJeRsH11vzTSCPCwxqfuBo6Q=; b=TAsZfcIzZ1Euc/qIeEg34BQq2COz7cgqBz00GoicuXUNf9pdGcbnWHwxzUdfUr95G6 aZkeIr2DXfy8REqoWNWUrHkDO72sG3i0jXoJwl1ByCdJe4nI3ufTivSeF9XGTyVfZSBt E8X9FJkYlIIwFcdiPVlMoWZYSaWqjlfPLGIK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bIDYG8oUb6Mu7NvJ6XCyJeRsH11vzTSCPCwxqfuBo6Q=; b=aZKrZZJcOgK5XxIJxJIbk6+YB4pz9jlVrFE50WJC+Hl6gM0mWYls5etgTKj6uogsCU RMwKLk5ZpdHqgy2fuVRx/bZU4pG6hnBZ3d2nP9m109Y9Cx5ZmpLb7StfEJCfkXDM+nx8 dsIzjnhB9wiid7+XjV14p06jZcFLDLhl1dF+N8s1Ha1Phb4FoXiMkF4DWQFJH296tU78 JH77jMT9Co49mGLa8RITm2xW+7Mr4TS/G3H6ojrEkneIRaEflK4AK+mzY0cLwpCzLy+8 hzf6Cobh352jY6UFYgmgx82m0eJd2+tLDvVZr+Br/XMuHvWmGzQsK/sHEMChAj1d2QnC M8lw== X-Gm-Message-State: AOAM530dBnIi/Jlm2zjLNSd9wPkXHPdZCekKuWYlwG1Z2te823n2V82n i+9J0orBeM06kjgdw25ZBcL2iA== X-Google-Smtp-Source: ABdhPJywOBGnVCItaZdbWHBhKk99ReUqQqdPAt9X91jhcKRKzWEoF57vDV5JAH3IfEnT7+kmtExgOg== X-Received: by 2002:a17:902:ea53:b0:15b:1bb8:ac9e with SMTP id r19-20020a170902ea5300b0015b1bb8ac9emr27991008plg.45.1651775959313; Thu, 05 May 2022 11:39:19 -0700 (PDT) Date: Thu, 5 May 2022 11:39:17 -0700 From: Kees Cook To: Paul Moore Cc: "Gustavo A. R. Silva" , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , Christian =?iso-8859-1?Q?G=F6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab Message-ID: <202205051124.6D80ABAE32@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> <20220504234324.GA12556@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 04, 2022 at 11:14:42PM -0400, Paul Moore wrote: > On Wed, May 4, 2022 at 7:34 PM Gustavo A. R. Silva > wrote: > > > > Hi Paul, > > > > On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote: > > > On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: > > > > [..] > > > > > > +++ b/include/uapi/linux/xfrm.h > > > > @@ -31,9 +31,9 @@ struct xfrm_id { > > > > struct xfrm_sec_ctx { > > > > __u8 ctx_doi; > > > > __u8 ctx_alg; > > > > - __u16 ctx_len; > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > > > > __u32 ctx_sid; > > > > - char ctx_str[0]; > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > > > > }; > > > > > > While I like the idea of this in principle, I'd like to hear about the > > > testing you've done on these patches. A previous flex array > > > conversion in the audit uapi headers ended up causing a problem with > > > > I'm curious about which commit caused those problems...? > > Commit ed98ea2128b6 ("audit: replace zero-length array with > flexible-array member"), however, as I said earlier, the problem was > actually with SWIG, it just happened to be triggered by the kernel > commit. There was a brief fedora-devel mail thread about the problem, > see the link below: > > * https://www.spinics.net/lists/fedora-devel/msg297991.html Wow, that's pretty weird -- it looks like SWIG was scraping the headers to build its conversions? I assume SWIG has been fixed now? > To reiterate, I'm supportive of changes like this, but I would like to > hear how it was tested to ensure there are no unexpected problems with > userspace. If there are userspace problems it doesn't mean we can't > make changes like this, it just means we need to ensure that the > userspace issues are resolved first. Well, as this is the first and only report of any problems with [0] -> [] conversions (in UAPI or anywhere) that I remember seeing, and they've been underway since at least v5.9, I hadn't been doing any new testing. So, for this case, I guess I should ask what tests you think would be meaningful here? Anything using #include should be fine: https://codesearch.debian.net/search?q=linux%2Fxfrm.h&literal=1&perpkg=1 Which leaves just this, which may be doing something weird: libabigail_2.0-1/tests/data/test-diff-filter/test-PR27569-v0.abi But I see that SWIG doesn't show up in a search for linux/audit.h: https://codesearch.debian.net/search?q=linux%2Faudit.h&literal=1&perpkg=1 So this may not be a sufficient analysis... -- Kees Cook From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322484.543889 (Exim 4.92) (envelope-from ) id 1nmqLg-0001yt-UJ; Fri, 06 May 2022 05:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322484.543889; Fri, 06 May 2022 05:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLg-0001vF-G7; Fri, 06 May 2022 05:17:52 +0000 Received: by outflank-mailman (input) for mailman id 322484; Fri, 06 May 2022 00:59:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmmJc-0000M5-Pf for xen-devel@lists.xenproject.org; Fri, 06 May 2022 00:59:28 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5ad77d8-ccd7-11ec-a406-831a346695d4; Fri, 06 May 2022 02:59:27 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF1EDB831C3; Fri, 6 May 2022 00:59:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63365C385A4; Fri, 6 May 2022 00:59:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5ad77d8-ccd7-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651798762; bh=QHLpCYQAf4+qvwVPngV5l8IrNs1LORlQXrnupp83GZw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a5h2RHlNwK/5saAV7Ze/fjqvxdNmdEP8Axbp3ZZz7Hb5HDtHWJBCICfECaYxNkXEK ANaNwCofZgiA1UzwJUSX+qaaSp0LS6eClnugCA0zNkRsSnX38kOKxMuzQLu9h9Aru9 61ul4/dcC/OBr5AmN74lb9td0B+IF4J82IuVNIPK2nsKrAPfVCrr4z9QwhtHrtczp2 tU8no/CqNF5wz/W4zNS+sWsHYpLVGoMGocTLtu6Tpa/HKE7L4BgiDVJ4hOXO4evxSg lfdeEuJUJMH7Tm4XyyRc7XgDnv8GxTr/iVsNxRCeJxXLe6iCxRyC+SfurDpCblt3Iv VNSJYc2ryzMfw== Date: Thu, 5 May 2022 20:08:22 -0500 From: "Gustavo A. R. Silva" To: Paul Moore Cc: Kees Cook , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , Christian =?iso-8859-1?Q?G=F6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab Message-ID: <20220506010822.GA18891@embeddedor> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> <20220504234324.GA12556@embeddedor> <202205051124.6D80ABAE32@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 05, 2022 at 07:16:18PM -0400, Paul Moore wrote: > On Thu, May 5, 2022 at 2:39 PM Kees Cook wrote: > > On Wed, May 04, 2022 at 11:14:42PM -0400, Paul Moore wrote: > > > On Wed, May 4, 2022 at 7:34 PM Gustavo A. R. Silva > > > wrote: > > > > > > > > Hi Paul, > > > > > > > > On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote: > > > > > On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: > > > > > > > > [..] > > > > > > > > > > +++ b/include/uapi/linux/xfrm.h > > > > > > @@ -31,9 +31,9 @@ struct xfrm_id { > > > > > > struct xfrm_sec_ctx { > > > > > > __u8 ctx_doi; > > > > > > __u8 ctx_alg; > > > > > > - __u16 ctx_len; > > > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > > > > > > __u32 ctx_sid; > > > > > > - char ctx_str[0]; > > > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > > > > > > }; > > > > > > > > > > While I like the idea of this in principle, I'd like to hear about the > > > > > testing you've done on these patches. A previous flex array > > > > > conversion in the audit uapi headers ended up causing a problem with > > > > > > > > I'm curious about which commit caused those problems...? > > > > > > Commit ed98ea2128b6 ("audit: replace zero-length array with > > > flexible-array member"), however, as I said earlier, the problem was > > > actually with SWIG, it just happened to be triggered by the kernel > > > commit. There was a brief fedora-devel mail thread about the problem, > > > see the link below: > > > > > > * https://www.spinics.net/lists/fedora-devel/msg297991.html > > > > Wow, that's pretty weird -- it looks like SWIG was scraping the headers > > to build its conversions? I assume SWIG has been fixed now? > > I honestly don't know, the audit userspace was hacking around it with > some header file duplication/munging last I heard, but I try to avoid > having to touch Steve's audit userspace code. > > > > To reiterate, I'm supportive of changes like this, but I would like to > > > hear how it was tested to ensure there are no unexpected problems with > > > userspace. If there are userspace problems it doesn't mean we can't > > > make changes like this, it just means we need to ensure that the > > > userspace issues are resolved first. > > > > Well, as this is the first and only report of any problems with [0] -> [] > > conversions (in UAPI or anywhere) that I remember seeing, and they've > > been underway since at least v5.9, I hadn't been doing any new testing. > > ... and for whatever it is worth, I wasn't expecting it to be a > problem either. Surprise :) > > > So, for this case, I guess I should ask what tests you think would be > > meaningful here? Anything using #include should be fine: > > https://codesearch.debian.net/search?q=linux%2Fxfrm.h&literal=1&perpkg=1 > > Which leaves just this, which may be doing something weird: > > > > libabigail_2.0-1/tests/data/test-diff-filter/test-PR27569-v0.abi > > > > > > > > > > > > > > But I see that SWIG doesn't show up in a search for linux/audit.h: > > https://codesearch.debian.net/search?q=linux%2Faudit.h&literal=1&perpkg=1 > > > > So this may not be a sufficient analysis... > > I think from a practical perspective ensuring that the major IPsec/IKE > tools, e.g. the various *SWANs, that know about labeled IPSec still > build and can set/get the SA/SPD labels correctly would be sufficient. > I seriously doubt there would be any problems, but who knows. There are certainly some cases in which the transformation of zero-length arrays into flexible-array members can bring some issues to the surface[1][2]. This is the first time that we know of one of them in user-space. However, we haven't transformed the arrays in UAPI yet (with the exception of a couple of cases[3][4]). But that is something that we are planning to try soon[5]. -- Gustavo [1] https://github.com/KSPP/linux/issues?q=invalid+use+of+flexible+array [2] https://github.com/KSPP/linux/issues?q=invalid+application+of+%E2%80%98sizeof%E2%80%99+to+incomplete+type [3] https://git.kernel.org/linus/db243b796439c0caba47865564d8acd18a301d18 [4] https://git.kernel.org/linus/d6cdad870358128c1e753e6258e295ab8a5a2429 [5] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?h=for-next/kspp-fam0-uapi From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322350.543852 (Exim 4.92) (envelope-from ) id 1nmqLe-0001JJ-VV; Fri, 06 May 2022 05:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322350.543852; Fri, 06 May 2022 05:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLe-0001IE-N8; Fri, 06 May 2022 05:17:50 +0000 Received: by outflank-mailman (input) for mailman id 322350; Thu, 05 May 2022 19:27:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmh8U-00039Z-3f for xen-devel@lists.xenproject.org; Thu, 05 May 2022 19:27:38 +0000 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [2607:f8b0:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a2712ba-cca9-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 21:27:35 +0200 (CEST) Received: by mail-pl1-x630.google.com with SMTP id q4so2427215plr.11 for ; Thu, 05 May 2022 12:27:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g4-20020a170902c38400b0015e8d4eb20bsm3383plg.85.2022.05.05.12.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 12:27:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a2712ba-cca9-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/twjVtbcWPue2Jf3IhiwlWWY7Rof9WWSi6Cv9vIoV/Q=; b=Zw4fRetuqYTkqeq+yVUkdhxXm/8i81f3Tz5yiq/8IIDSZ024zV3L+pNdERes4bJaav 31/Q4CkRhBZLAixBgNaxyPQDOPUfRkG6V2Lznu+vqnnAE8TdezgewvauqqI6bgLcXe8G 8pjfVWQFjtIzIDipg+thK9X2Q1whG0Xu+Ovt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/twjVtbcWPue2Jf3IhiwlWWY7Rof9WWSi6Cv9vIoV/Q=; b=cwl8/4avMzq4C7aRe9r/YYLpXZhKg5+cXwas20fwcysx2qn3KLAfD9w8wR2cnX5GFX q/VRe4XPtZfPfxVzVGoaFDfqcWJliuWnl0FlYntlid0Tk7ZZGCZ40Q6Ct+OhWjsH0d+Z TXic/feyFcfMcNP4+CRKKFJGdk+NcswBPz0W08NGhWTQXa2PQTDr4L9RlmWuAZx3KQvn LQ4vaBfQwJMsLYFcomQaEbIz8SHY+usyeUIgptint5NbEPmr5l4KCgJ98lXwMJIGtQkA MX77QMsYhgJ2oMYcmY1y8kmh/N5awdC4upTtFii6+AbMyNpuAuw3npVX/A8AzYD132SK 5+zw== X-Gm-Message-State: AOAM533fCDP3t1zESFl0LmqzkKjz2Jdszovzrc3QkuW2mulln3IWacsp WUPgIyyB//AZucM1ctLQcpdB7w== X-Google-Smtp-Source: ABdhPJyMt9gPdDTw+FpTk8LuZ7KJ4bSEOkJZBvChi1uFf0GDszQUqKrXsHdzONZd+UaK2I++GKA26A== X-Received: by 2002:a17:90b:1d11:b0:1dc:5dd1:b50e with SMTP id on17-20020a17090b1d1100b001dc5dd1b50emr7869285pjb.218.1651778853785; Thu, 05 May 2022 12:27:33 -0700 (PDT) Date: Thu, 5 May 2022 12:27:32 -0700 From: Kees Cook To: Johannes Berg Cc: "Gustavo A . R . Silva" , Keith Packard , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Message-ID: <202205051143.6B19E63983@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> On Thu, May 05, 2022 at 03:16:19PM +0200, Johannes Berg wrote: > On Wed, 2022-05-04 at 08:38 -0700, Kees Cook wrote: > > > > It seemed like requiring a structure be rearranged to take advantage of > > the "automatic layout introspection" wasn't very friendly. On the other > > hand, looking at the examples, most of them are already neighboring > > members. Hmmm. > > A lot of them are, and many could be, though not all. Yeah, I did a pass through them for the coming v2. Only a few have the struct order as part of an apparent hardware interface. > > And DECLARE_FLEX_ARRAY_ELEMENTS could actually be expanded to include > > the count_name too, so both methods could be "forward portable" to a > > future where C grew the syntax for bounded flex arrays. > > I guess I don't see that happening :) Well ... it's on my roadmap. ;) I want it for -fsanitize=array-bounds so that dynamic array indexing can be checked too. (Right now we can do constant-sized array index bounds checking at runtime, but the much harder to find problems tend to come from flex arrays.) > > Requiring instance to be NULL is debatable, but I feel pretty strongly > > about it because it does handle a class of mistakes (resource leaks), > > and it's not much of a burden to require a known-good starting state. > > Yeah, dunno, I guess I'm slightly more on the side of not requiring it, > since we don't do the same for kmalloc() etc. and probably really > wouldn't want to add kmalloc_s() that does it ;-) Well, I dislike all the *alloc APIs. :P > I mean, you _could_ go there: > > int kmalloc_s(void **ptr, size_t size, gfp_t gfp) Oh, and I really do (though as a macro, not a "real" function), since having type introspection would be _extremely_ useful. Though maybe it needs to be through some kind of type-of-lvalue thing... https://github.com/KSPP/linux/issues/189 https://github.com/KSPP/linux/issues/87 > So I'm not really sure why this aspect here should need to be different, > except of course that you already need the input argument for the magic. Right, and trying to move the kernel code closer to a form where the compiler can take more of the burden of handling code safety. > And btw, while I was writing it down I was looking to see if it should > be "size_t elements" or "size_t len" (like memcpy), it took me some time > to figure out, and I was looking at the examples: > > 1) most of them actually use __u8 or some variant thereof, so you > couldprobably add an even simpler macro like > BOUNDED_FLEX_DATA(int, bytes, data) > which has the u8 type internally. I didn't want these helpers to be "opinionated" about their types (just their API), so while it's true u8 is usually "good enough", I don't think it's common enough to make a special case for. > 2) Unless I'm confusing myself, you got the firewire change wrong, > because __mem_to_flex_dup takes the "elements_count", but the > memcpy() there wasn't multiplied by the sizeof(element)? Or maybe > the fact that it was declared as __u32 header[0] is wrong, and it > should be __u8, but it's all very confusing, and I'm really not > sure about this at all. Yes indeed; thanks for catching that. In fact, it's not a strict flex array struct, since, as you say, it's measuring bytes, not elements. Yeah, I'll see if that needs to be adjusted/dropped, etc. > One "perhaps you'll laugh me out of the room" suggestion might be to > actually be able to initialize the whole thing too? > > mydata = flex_struct_alloc(mydata, GFP_KERNEL, > variable_data, variable_len, > .member = 1, > .another = 2); > > (the ordering can't really be otherwise since you have to use > __VA_ARGS__). Oooh, that's a cool idea for the API. Hmmmm. > That might reduce some more code too, though I guess it's quite some > additional magic ... :) Yay preprocessor magic! > I was going to point to struct cfg80211_bss_ies, but I realize now > they're RCU-managed, so we never resize them anyway ... So maybe it's > less common than I thought it might be. > > I suppose you know better since you converted a lot of stuff already :-) Well, I've seen a lot of fragile code (usually in the form of exploitable flaws around flex arrays) and they do mostly look the same. Not everything fits perfectly into the forms this API tries to address, but my goal is to get it fitting well enough, and the weird stuff can be more carefully examined -- they're easier to find and audit if all the others are nicely wrapped up in some fancy flex*() API. Thanks for your thoughts on all of this! I'll continue to work on a v2... -Kees -- Kees Cook From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322366.543865 (Exim 4.92) (envelope-from ) id 1nmqLf-0001aJ-IY; Fri, 06 May 2022 05:17:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322366.543865; Fri, 06 May 2022 05:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLf-0001Yq-EG; Fri, 06 May 2022 05:17:51 +0000 Received: by outflank-mailman (input) for mailman id 322366; Thu, 05 May 2022 20:09:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmhmZ-0007Up-AJ for xen-devel@lists.xenproject.org; Thu, 05 May 2022 20:09:03 +0000 Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 327837f0-ccaf-11ec-a406-831a346695d4; Thu, 05 May 2022 22:09:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 891C13F3296F; Thu, 5 May 2022 13:08:56 -0700 (PDT) Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5VTuAkNJ6jJp; Thu, 5 May 2022 13:08:56 -0700 (PDT) Received: from keithp.com (koto.keithp.com [192.168.11.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 067933F3296B; Thu, 5 May 2022 13:08:56 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id A1FFA1E601B9; Thu, 5 May 2022 13:08:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 327837f0-ccaf-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1651781336; bh=FYwb/JL7BiNf1ERDNYW+QEpxdN3SDh8ueitySQdIrBQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Np/XZ4pFy233AB0Yh+gi2AcW/e9+t3y/fWG6qdh4wkqzGzyv/5d60R37rlx2q0dkx ZcA/OHcd/fQ1CoFSDxr0Vi8FXjWjSwahx9raUDyKmUlHDNFden+UlqdoPoL9lb3N6j z/Qqv9Wa2pLIQ3ZQ4WNbOu4gllTZvT8Le/cE0WdmezbxN7Lo811QY78xROKox4aoxD YtJ5TG07Cfh89+3GGGmDQQjL7bmwxYOqopOZ5A82byaJA6k7cohAwc8JRFZ33WFxKZ /7mx5KCwL1wU3NFmP6UKOcEgk9zOwdOR12cnrjAgCLv/62+PIg/yKTdgVBApfc2HeW bh24dG0NyBe9A== X-Virus-Scanned: Debian amavisd-new at keithp.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1651781336; bh=FYwb/JL7BiNf1ERDNYW+QEpxdN3SDh8ueitySQdIrBQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Np/XZ4pFy233AB0Yh+gi2AcW/e9+t3y/fWG6qdh4wkqzGzyv/5d60R37rlx2q0dkx ZcA/OHcd/fQ1CoFSDxr0Vi8FXjWjSwahx9raUDyKmUlHDNFden+UlqdoPoL9lb3N6j z/Qqv9Wa2pLIQ3ZQ4WNbOu4gllTZvT8Le/cE0WdmezbxN7Lo811QY78xROKox4aoxD YtJ5TG07Cfh89+3GGGmDQQjL7bmwxYOqopOZ5A82byaJA6k7cohAwc8JRFZ33WFxKZ /7mx5KCwL1wU3NFmP6UKOcEgk9zOwdOR12cnrjAgCLv/62+PIg/yKTdgVBApfc2HeW bh24dG0NyBe9A== From: Keith Packard To: Kees Cook Cc: Johannes Berg , "Gustavo A . R . Silva" , Francis Laniel , Daniel Axtens , Dan Williams , Vincenzo Frascino , Guenter Roeck , Daniel Vetter , Tadeusz Struk , Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?utf-8?Q?G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?utf-8?Q?S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 02/32] Introduce flexible array struct memcpy() helpers In-Reply-To: <202205051228.4D5B8CD624@keescook> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> <871qx8qabo.fsf@keithp.com> <202205051228.4D5B8CD624@keescook> Date: Thu, 05 May 2022 13:08:55 -0700 Message-ID: <87pmkrpwrs.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kees Cook writes: > I don't think I can do a declaration and an expression statement at the > same time with different scopes, but that would be kind of cool. We did > just move to c11 to gain the in-loop iterator declarations... Yeah, you'd end up creating a statement-level macro, and I think that would have poor syntax: mem_to_flex_dup(struct something *instance, rc, byte_array, count, GFP_KERNEL); if (rc) return rc; I bet you've already considered the simpler form: struct something *instance =3D mem_to_flex_dup(byte_array, count, G= FP_KERNEL); if (IS_ERR(instance)) return PTR_ERR(instance); This doesn't allow you to require a new name, so you effectively lose the check you're trying to insist upon. Some way to ask the compiler 'is this reference dead?' would be nice -- it knows if a valid pointer was passed to free, or if a variable has not been initialized, after all; we just need that exposed at the source level. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmJ0LtcACgkQ2yIaaQAA ABHC0hAAr3uHP5hrK0TrjV0miTlsckS+Z8SZ2+xvHioDubRTMMdfP79BMu5ndZB4 QaRps+OPUgs6f0p8V2N5qN2jruvrUHrKXQyiIjdsRQmUp+3qyvpjuYrtNDeHHTD2 vfM0b48EgU8kkiVZH9ksTQ/b48dkf2r7GYLnmd3VO/LkFTymGVqvodKSYl/6dZOZ x7yTZYIRcbsjqPumSocldZhrYNuDwDWd3K2voU8pDD202q2xk3BpatYQOCnRYAzk Le8pCTMAkJmy3VcKuORvTyRaq0/AvjfjEVHVP9ucCk68zGEU1/egKnkv3iQ5b7UY RzyQTJSlFZQv2EomuxRRhmKQ/Ubqr//1Y5P8FLqQjJFdocf7x/wCkMdE5X/WZhIN tjA64pkC+b20mi6NQ5XouaUSTBKTnU44rsSCWsabc+fBx96Arj1tMJCrOoqYCWpy yg2mbeB3A55aDXAVSoC9vKoeleOJER70z7sOfycFpLPcO/XAoDOUOlfH46McYIIK 0xMfYCih17SZ/wY5s/NAamDnihpT26Zkm028+XJtQdxgyS3rSIjH+TxqQ3dpl+Tq q78xgiJ/GBR6QVyfdgbWEbXlJUOTIA1gtT+YvkC9NwhJszdT72psVFUXtZraEaRs +XEV7uZeDpyI0x1VGRqSDZgJtavhxjCqeR9SZ21Vch7I0NhT24I= =lS49 -----END PGP SIGNATURE----- --=-=-=-- From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322434.543880 (Exim 4.92) (envelope-from ) id 1nmqLg-0001no-DN; Fri, 06 May 2022 05:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322434.543880; Fri, 06 May 2022 05:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLg-0001lx-2k; Fri, 06 May 2022 05:17:52 +0000 Received: by outflank-mailman (input) for mailman id 322434; Thu, 05 May 2022 23:16:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmki1-0004GV-6c for xen-devel@lists.xenproject.org; Thu, 05 May 2022 23:16:33 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65459c16-ccc9-11ec-a406-831a346695d4; Fri, 06 May 2022 01:16:30 +0200 (CEST) Received: by mail-wr1-x42e.google.com with SMTP id u3so7913670wrg.3 for ; Thu, 05 May 2022 16:16:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65459c16-ccc9-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNb5FwciOrnmYbDhJp90kHEHFZ0681UtkEHiY9rBD84=; b=Ohr3X3EP78LxuYDKhnz8KuPiuz1PhY8VlacN2n0UZF33p11lrzHmoTg5FkuLveaWWc B+PHWzpGocOw99rYrrwOT2j6K7yl6TZjHfwiwfQv58T2SgC8RJjpZCrBvbUHRa3tAEjw vBvW2uixSk3X4wocsWWICUIdWEyFIPpXBQF7km3BjP4lO/AiOmnrqBvYof/Hmrk8g3Ui VsyTbQQECGTWGpH9GRnc/7V1pdbEyCgAuGzq4iO4E+9FajCsxUmBzSMnYaru+xQE/MDx VovhSYGTu5JLsFhCQL0rb2sLJwJC/ZTQ8Ao2n8UXvDJkacdd5/9qZgjSKryNtgTW6CEs aKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNb5FwciOrnmYbDhJp90kHEHFZ0681UtkEHiY9rBD84=; b=dVEcUIAfIp4KBwBoeSGEMZOY0bC2lGhUEbOY6GzLDwIvpU64/XvcyFoY6RNkimNMFe BGD/P/8vea3kxhS6Tv5pq4F3V4C4cGXgzT5u1uMtgjKvXGBxhFsKTgeX4HCyvfbFZkdA YxpMxUp1MdYugV15Z+3BPgjXswxWbx5BfgSCOm+GxNOl4f+yKr3allsWDUE9Q9ASJtAF 3B9pfQxDiPr8PYU67QcqmBeuIiVDfyGzLIRy9KCN7AVbCnQGGnUfXKJQ/Wv89wxJaqPW EcM72MIlDwU7s2528+OWLLkIe0fpOFQwYuRY892lugDZzMJqZRWdoBCfi9vKtOAUykGQ zF0g== X-Gm-Message-State: AOAM530aZUr8+WmX1wjDihib7Mb9y72edaTBkK4tOmlVRoWI5trF6rhu sgh74pluluNpswVG6hTRRbHbHYa06k94al5L2n4j X-Google-Smtp-Source: ABdhPJyI6zIzqRKP45wkz/HSJ9ebgV2/QaH+Jh5XG21YfFQB+clnUfHaAanM4WnjOyZZ77zPKKT04iIWWkNblva8IBo= X-Received: by 2002:a5d:590d:0:b0:20a:c3eb:2584 with SMTP id v13-20020a5d590d000000b0020ac3eb2584mr325652wrd.18.1651792589559; Thu, 05 May 2022 16:16:29 -0700 (PDT) MIME-Version: 1.0 References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-29-keescook@chromium.org> <20220504234324.GA12556@embeddedor> <202205051124.6D80ABAE32@keescook> In-Reply-To: <202205051124.6D80ABAE32@keescook> From: Paul Moore Date: Thu, 5 May 2022 19:16:18 -0400 Message-ID: Subject: Re: [PATCH 28/32] selinux: Use mem_to_flex_dup() with xfrm and sidtab To: Kees Cook Cc: "Gustavo A. R. Silva" , Steffen Klassert , Herbert Xu , "David S. Miller" , Stephen Smalley , Eric Paris , Nick Desaulniers , Xiu Jianfeng , =?UTF-8?Q?Christian_G=C3=B6ttsche?= , netdev@vger.kernel.org, selinux@vger.kernel.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , =?UTF-8?B?TnVubyBTw6E=?= , Paolo Abeni , Rich Felker , Rob Herring , Russell King , "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Stephen Hemminger , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Yang Yingliang Content-Type: text/plain; charset="UTF-8" On Thu, May 5, 2022 at 2:39 PM Kees Cook wrote: > On Wed, May 04, 2022 at 11:14:42PM -0400, Paul Moore wrote: > > On Wed, May 4, 2022 at 7:34 PM Gustavo A. R. Silva > > wrote: > > > > > > Hi Paul, > > > > > > On Wed, May 04, 2022 at 06:57:28PM -0400, Paul Moore wrote: > > > > On Tue, May 3, 2022 at 9:57 PM Kees Cook wrote: > > > > > > [..] > > > > > > > > +++ b/include/uapi/linux/xfrm.h > > > > > @@ -31,9 +31,9 @@ struct xfrm_id { > > > > > struct xfrm_sec_ctx { > > > > > __u8 ctx_doi; > > > > > __u8 ctx_alg; > > > > > - __u16 ctx_len; > > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(__u16, ctx_len); > > > > > __u32 ctx_sid; > > > > > - char ctx_str[0]; > > > > > + __DECLARE_FLEX_ARRAY_ELEMENTS(char, ctx_str); > > > > > }; > > > > > > > > While I like the idea of this in principle, I'd like to hear about the > > > > testing you've done on these patches. A previous flex array > > > > conversion in the audit uapi headers ended up causing a problem with > > > > > > I'm curious about which commit caused those problems...? > > > > Commit ed98ea2128b6 ("audit: replace zero-length array with > > flexible-array member"), however, as I said earlier, the problem was > > actually with SWIG, it just happened to be triggered by the kernel > > commit. There was a brief fedora-devel mail thread about the problem, > > see the link below: > > > > * https://www.spinics.net/lists/fedora-devel/msg297991.html > > Wow, that's pretty weird -- it looks like SWIG was scraping the headers > to build its conversions? I assume SWIG has been fixed now? I honestly don't know, the audit userspace was hacking around it with some header file duplication/munging last I heard, but I try to avoid having to touch Steve's audit userspace code. > > To reiterate, I'm supportive of changes like this, but I would like to > > hear how it was tested to ensure there are no unexpected problems with > > userspace. If there are userspace problems it doesn't mean we can't > > make changes like this, it just means we need to ensure that the > > userspace issues are resolved first. > > Well, as this is the first and only report of any problems with [0] -> [] > conversions (in UAPI or anywhere) that I remember seeing, and they've > been underway since at least v5.9, I hadn't been doing any new testing. ... and for whatever it is worth, I wasn't expecting it to be a problem either. Surprise :) > So, for this case, I guess I should ask what tests you think would be > meaningful here? Anything using #include should be fine: > https://codesearch.debian.net/search?q=linux%2Fxfrm.h&literal=1&perpkg=1 > Which leaves just this, which may be doing something weird: > > libabigail_2.0-1/tests/data/test-diff-filter/test-PR27569-v0.abi > > > > > > > But I see that SWIG doesn't show up in a search for linux/audit.h: > https://codesearch.debian.net/search?q=linux%2Faudit.h&literal=1&perpkg=1 > > So this may not be a sufficient analysis... I think from a practical perspective ensuring that the major IPsec/IKE tools, e.g. the various *SWANs, that know about labeled IPSec still build and can set/get the SA/SPD labels correctly would be sufficient. I seriously doubt there would be any problems, but who knows. -- paul-moore.com From xen-devel-bounces@lists.xenproject.org Fri May 06 05:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322340.543845 (Exim 4.92) (envelope-from ) id 1nmqLe-0001CK-If; Fri, 06 May 2022 05:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322340.543845; Fri, 06 May 2022 05:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqLe-0001BL-CU; Fri, 06 May 2022 05:17:50 +0000 Received: by outflank-mailman (input) for mailman id 322340; Thu, 05 May 2022 18:57:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmgfA-0008HL-1e for xen-devel@lists.xenproject.org; Thu, 05 May 2022 18:57:20 +0000 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2eba1ced-cca5-11ec-8fc4-03012f2f19d4; Thu, 05 May 2022 20:57:17 +0200 (CEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245IsCDC021810; Thu, 5 May 2022 18:56:22 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fvm92012c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 May 2022 18:56:22 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 245IuAu6029325; Thu, 5 May 2022 18:56:21 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fvm92011f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 May 2022 18:56:21 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 245IbA58012918; Thu, 5 May 2022 18:55:39 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03ams.nl.ibm.com with ESMTP id 3ftp7fvexe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 May 2022 18:55:39 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 245ItaGm14352888 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 May 2022 18:55:36 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B81D11C05B; Thu, 5 May 2022 18:55:36 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6820611C04C; Thu, 5 May 2022 18:55:10 +0000 (GMT) Received: from [9.211.36.212] (unknown [9.211.36.212]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 5 May 2022 18:55:10 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2eba1ced-cca5-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=XNUaK5MXNumQ2GC419CM2tT56hGe0D54FACFQZzubag=; b=gSD1byPqJD9U14RM7yqXNGjhCvGv5EceJcS49ikn+rpVMYCw5l/cE2/RfhpfxgDrdFXF bkw+3uP6vU/C7MIPvjf+1/BQcDGTmd58m1jCKBcC75Xc3IwagCsVfPCOPegq8b4MZ3p/ mQN9mkPuV1Btua3UKzIpudLBdtJkA5WoYucCFThdzTDSpYwo6Nc6tDpcKD+hvfEHi+OM CWja8vfEeVW5JzydzGv1uvP94K0n/yjRgwV8RQXFJagBheg9E5Imh/dRMjKSs9LZirwJ /CWejco2WiCA9LRB8XRjw7cjAD2OqALQniaNM+6CBO4ZnFoxNe9gtVMrz4B16UghR6hV VA== Message-ID: <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> Date: Fri, 6 May 2022 00:25:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers Content-Language: en-US To: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Nicholas Piggin , Paul Mackerras References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-9-gpiccoli@igalia.com> From: Hari Bathini In-Reply-To: <20220427224924.592546-9-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: FmL43udCg7zOaYTyNU5fYcYIiC3L3tsY X-Proofpoint-ORIG-GUID: op15TFwB187r4kWWn80Xf8P42QMt9UB1 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-05_08,2022-05-05_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1011 lowpriorityscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 phishscore=0 suspectscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205050125 On 28/04/22 4:19 am, Guilherme G. Piccoli wrote: > The panic notifiers infrastructure is a bit limited in the scope of > the callbacks - basically every kind of functionality is dropped > in a list that runs in the same point during the kernel panic path. > This is not really on par with the complexities and particularities > of architecture / hypervisors' needs, and a refactor is ongoing. > > As part of this refactor, it was observed that powerpc has 2 notifiers, > with mixed goals: one is just a KASLR offset dumper, whereas the other > aims to hard-disable IRQs (necessary on panic path), warn firmware of > the panic event (fadump) and run low-level platform-specific machinery > that might stop kernel execution and never come back. > > Clearly, the 2nd notifier has opposed goals: disable IRQs / fadump > should run earlier while low-level platform actions should > run late since it might not even return. Hence, this patch decouples > the notifiers splitting them in three: > > - First one is responsible for hard-disable IRQs and fadump, > should run early; > > - The kernel KASLR offset dumper is really an informative notifier, > harmless and may run at any moment in the panic path; > > - The last notifier should run last, since it aims to perform > low-level actions for specific platforms, and might never return. > It is also only registered for 2 platforms, pseries and ps3. > > The patch better documents the notifiers and clears the code too, > also removing a useless header. > > Currently no functionality change should be observed, but after > the planned panic refactor we should expect more panic reliability > with this patch. > > Cc: Benjamin Herrenschmidt > Cc: Hari Bathini > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Paul Mackerras > Signed-off-by: Guilherme G. Piccoli The change looks good. I have tested it on an LPAR (ppc64). Reviewed-by: Hari Bathini > --- > > We'd like to thanks specially the MiniCloud infrastructure [0] maintainers, > that allow us to test PowerPC code in a very complete, functional and FREE > environment (there's no need even for adding a credit card, like many "free" > clouds require ¬¬ ). > > [0] https://openpower.ic.unicamp.br/minicloud > > arch/powerpc/kernel/setup-common.c | 74 ++++++++++++++++++++++-------- > 1 file changed, 54 insertions(+), 20 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c > index 518ae5aa9410..52f96b209a96 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -680,8 +679,25 @@ int check_legacy_ioport(unsigned long base_port) > } > EXPORT_SYMBOL(check_legacy_ioport); > > -static int ppc_panic_event(struct notifier_block *this, > - unsigned long event, void *ptr) > +/* > + * Panic notifiers setup > + * > + * We have 3 notifiers for powerpc, each one from a different "nature": > + * > + * - ppc_panic_fadump_handler() is a hypervisor notifier, which hard-disables > + * IRQs and deal with the Firmware-Assisted dump, when it is configured; > + * should run early in the panic path. > + * > + * - dump_kernel_offset() is an informative notifier, just showing the KASLR > + * offset if we have RANDOMIZE_BASE set. > + * > + * - ppc_panic_platform_handler() is a low-level handler that's registered > + * only if the platform wishes to perform final actions in the panic path, > + * hence it should run late and might not even return. Currently, only > + * pseries and ps3 platforms register callbacks. > + */ > +static int ppc_panic_fadump_handler(struct notifier_block *this, > + unsigned long event, void *ptr) > { > /* > * panic does a local_irq_disable, but we really > @@ -691,45 +707,63 @@ static int ppc_panic_event(struct notifier_block *this, > > /* > * If firmware-assisted dump has been registered then trigger > - * firmware-assisted dump and let firmware handle everything else. > + * its callback and let the firmware handles everything else. > */ > crash_fadump(NULL, ptr); > - if (ppc_md.panic) > - ppc_md.panic(ptr); /* May not return */ > + > return NOTIFY_DONE; > } > > -static struct notifier_block ppc_panic_block = { > - .notifier_call = ppc_panic_event, > - .priority = INT_MIN /* may not return; must be done last */ > -}; > - > -/* > - * Dump out kernel offset information on panic. > - */ > static int dump_kernel_offset(struct notifier_block *self, unsigned long v, > void *p) > { > pr_emerg("Kernel Offset: 0x%lx from 0x%lx\n", > kaslr_offset(), KERNELBASE); > > - return 0; > + return NOTIFY_DONE; > } > > +static int ppc_panic_platform_handler(struct notifier_block *this, > + unsigned long event, void *ptr) > +{ > + /* > + * This handler is only registered if we have a panic callback > + * on ppc_md, hence NULL check is not needed. > + * Also, it may not return, so it runs really late on panic path. > + */ > + ppc_md.panic(ptr); > + > + return NOTIFY_DONE; > +} > + > +static struct notifier_block ppc_fadump_block = { > + .notifier_call = ppc_panic_fadump_handler, > + .priority = INT_MAX, /* run early, to notify the firmware ASAP */ > +}; > + > static struct notifier_block kernel_offset_notifier = { > - .notifier_call = dump_kernel_offset > + .notifier_call = dump_kernel_offset, > +}; > + > +static struct notifier_block ppc_panic_block = { > + .notifier_call = ppc_panic_platform_handler, > + .priority = INT_MIN, /* may not return; must be done last */ > }; > > void __init setup_panic(void) > { > + /* Hard-disables IRQs + deal with FW-assisted dump (fadump) */ > + atomic_notifier_chain_register(&panic_notifier_list, > + &ppc_fadump_block); > + > if (IS_ENABLED(CONFIG_RANDOMIZE_BASE) && kaslr_offset() > 0) > atomic_notifier_chain_register(&panic_notifier_list, > &kernel_offset_notifier); > > - /* PPC64 always does a hard irq disable in its panic handler */ > - if (!IS_ENABLED(CONFIG_PPC64) && !ppc_md.panic) > - return; > - atomic_notifier_chain_register(&panic_notifier_list, &ppc_panic_block); > + /* Low-level platform-specific routines that should run on panic */ > + if (ppc_md.panic) > + atomic_notifier_chain_register(&panic_notifier_list, > + &ppc_panic_block); > } > > #ifdef CONFIG_CHECK_CACHE_COHERENCY From xen-devel-bounces@lists.xenproject.org Fri May 06 05:36:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:36:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322561.543927 (Exim 4.92) (envelope-from ) id 1nmqdD-0007iu-LN; Fri, 06 May 2022 05:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322561.543927; Fri, 06 May 2022 05:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqdD-0007in-Gr; Fri, 06 May 2022 05:35:59 +0000 Received: by outflank-mailman (input) for mailman id 322561; Fri, 06 May 2022 05:35:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqdC-0007id-1f; Fri, 06 May 2022 05:35:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqdB-0006mE-Ut; Fri, 06 May 2022 05:35:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqdB-0005rC-Hg; Fri, 06 May 2022 05:35:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmqdB-00058Q-HD; Fri, 06 May 2022 05:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=twlk2zfio0fxd5EzgVk2oKFg32qDLDx2hyOAzifr9VY=; b=3v9YxKcSaLmcg+dmbEaWOQA0qO GA1EtINUZF1nF1NNaE2dq+/mVCsv3n/m60yOUeHhgf34sqQocqsWYSammXNEB7jsQ0EbsVGkVU9q1 WG+bPBhcDT5qHBmA2oWXy2nyf9vb2vC78rC+ctA73E/s8itUGDDOWEp5Od1CkMXyif+s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170169: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a64b944942d828fe98e4843929662aad7f47bcca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 05:35:57 +0000 flight 170169 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170169/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a64b944942d828fe98e4843929662aad7f47bcca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 833 attempts Testing same since 170169 2022-05-06 04:40:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5951 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 05:52:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:52:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322570.543938 (Exim 4.92) (envelope-from ) id 1nmqsy-0001gU-W9; Fri, 06 May 2022 05:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322570.543938; Fri, 06 May 2022 05:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqsy-0001gN-TN; Fri, 06 May 2022 05:52:16 +0000 Received: by outflank-mailman (input) for mailman id 322570; Fri, 06 May 2022 05:52:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqsx-0001gH-LU for xen-devel@lists.xenproject.org; Fri, 06 May 2022 05:52:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ad519e61-cd00-11ec-a406-831a346695d4; Fri, 06 May 2022 07:52:13 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA3761063; Thu, 5 May 2022 22:52:12 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ECC513FA27; Thu, 5 May 2022 22:52:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad519e61-cd00-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang Subject: [PATCH v2 0/2] Adjustment after introducing ASSERT_ALLOC_CONTEXT Date: Fri, 6 May 2022 13:51:59 +0800 Message-Id: <20220506055201.999277-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores on Arm will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. To solve this issue, this series introduces two patches. The first one defers the calling of request_irq on secondary CPUs after local_irq_enable on Arm. The second one moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). Henry Wang (2): xen/arm: Defer request_irq on secondary CPUs after local_irq_enable xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() xen/arch/arm/smpboot.c | 12 +++++++++--- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 2 +- xen/include/xen/irq.h | 7 +++++++ 4 files changed, 17 insertions(+), 11 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 05:52:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:52:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322572.543960 (Exim 4.92) (envelope-from ) id 1nmqtB-0002Gv-I3; Fri, 06 May 2022 05:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322572.543960; Fri, 06 May 2022 05:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqtB-0002Go-Ed; Fri, 06 May 2022 05:52:29 +0000 Received: by outflank-mailman (input) for mailman id 322572; Fri, 06 May 2022 05:52:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqtA-0001gH-8b for xen-devel@lists.xenproject.org; Fri, 06 May 2022 05:52:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b5a16f76-cd00-11ec-a406-831a346695d4; Fri, 06 May 2022 07:52:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBE191063; Thu, 5 May 2022 22:52:26 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7B7DD3FA27; Thu, 5 May 2022 22:52:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5a16f76-cd00-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Date: Fri, 6 May 2022 13:52:01 +0800 Message-Id: <20220506055201.999277-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506055201.999277-1-Henry.Wang@arm.com> References: <20220506055201.999277-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xmalloc() will use a pool for allocation smaller than a page. The pool is extended only when there are no more space. At which point, alloc_xenheap_pages() is called to add more memory. xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in alloc_xenheap_pages(). Hence, this commit moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang --- v1 -> v2: - No changes --- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 2 +- xen/include/xen/irq.h | 7 +++++++ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e866e0d864..ea59cd1a4a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -162,13 +162,6 @@ static char __initdata opt_badpage[100] = ""; string_param("badpage", opt_badpage); -/* - * Heap allocations may need TLB flushes which may require IRQs to be - * enabled (except when only 1 PCPU is online). - */ -#define ASSERT_ALLOC_CONTEXT() \ - ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) - /* * no-bootscrub -> Free pages are not zeroed during boot. */ diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index d2ad909502..b8f838ae74 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long size, unsigned long align) { void *p = NULL; - ASSERT(!in_irq()); + ASSERT_ALLOC_CONTEXT(); if ( !size ) return ZERO_BLOCK_PTR; diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index d8beadd16b..300625e56d 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -10,6 +10,13 @@ #include #include +/* + * Heap allocations may need TLB flushes which may require IRQs to be + * enabled (except when only 1 PCPU is online). + */ +#define ASSERT_ALLOC_CONTEXT() \ + ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) + struct irqaction { void (*handler)(int, void *, struct cpu_user_regs *); const char *name; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 05:52:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 05:52:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322571.543948 (Exim 4.92) (envelope-from ) id 1nmqt5-0001wc-7x; Fri, 06 May 2022 05:52:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322571.543948; Fri, 06 May 2022 05:52:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqt5-0001wT-5A; Fri, 06 May 2022 05:52:23 +0000 Received: by outflank-mailman (input) for mailman id 322571; Fri, 06 May 2022 05:52:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmqt3-0001gH-Pw for xen-devel@lists.xenproject.org; Fri, 06 May 2022 05:52:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b1c5d8ee-cd00-11ec-a406-831a346695d4; Fri, 06 May 2022 07:52:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67A3814BF; Thu, 5 May 2022 22:52:20 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E58803FA27; Thu, 5 May 2022 22:52:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1c5d8ee-cd00-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v2 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Date: Fri, 6 May 2022 13:52:00 +0800 Message-Id: <20220506055201.999277-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506055201.999277-1-Henry.Wang@arm.com> References: <20220506055201.999277-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. Moving the call of request_irq() past local_irq_enable() on secondary cores will make sure the assertion condition in alloc_xenheap_pages(), i.e. !in_irq && local_irq_enabled() is satisfied. It is also safe because the timer and GIC maintenance interrupt will not be used until the CPU is fully online. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang --- v1 -> v2: - Explain why the moving of code is safe in the commit message and add comments. --- xen/arch/arm/smpboot.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7bfd0a73a7..9bb32a301a 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -361,9 +361,6 @@ void start_secondary(void) init_secondary_IRQ(); - init_maintenance_interrupt(); - init_timer_interrupt(); - set_current(idle_vcpu[cpuid]); setup_cpu_sibling_map(cpuid); @@ -380,6 +377,15 @@ void start_secondary(void) cpumask_set_cpu(cpuid, &cpu_online_map); local_irq_enable(); + + /* + * Calling request_irq() after local_irq_enable() on secondary cores + * will make sure the assertion condition in alloc_xenheap_pages(), + * i.e. !in_irq && local_irq_enabled() is satisfied. + */ + init_maintenance_interrupt(); + init_timer_interrupt(); + local_abort_enable(); check_local_cpu_errata(); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 06:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322601.543970 (Exim 4.92) (envelope-from ) id 1nmr1d-0004Qm-B0; Fri, 06 May 2022 06:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322601.543970; Fri, 06 May 2022 06:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmr1d-0004Qf-87; Fri, 06 May 2022 06:01:13 +0000 Received: by outflank-mailman (input) for mailman id 322601; Fri, 06 May 2022 06:01:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmr1c-0004QV-00; Fri, 06 May 2022 06:01:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmr1b-0007KX-UM; Fri, 06 May 2022 06:01:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmr1b-0007Ah-Jq; Fri, 06 May 2022 06:01:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmr1b-0005Ei-JO; Fri, 06 May 2022 06:01:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gsE+Q7AmCWA9VKfBahwJWhg6jj9CX/5qldHGm5XXzqo=; b=UE6v63vnsmo0TRHd8ulgld2xy2 JIMpFTwXkA99ferVDsdNta2R4QDr2Sy1gLxqT8G+imX5ATsmKXPnfNvAkeW8CAPEGblH/x53GfGp2 Jrg2zboMxKtecAZZXUdBdiKjR9tKOApPiheM/chpGg/eoexWYcuW3TATCluPxfD4ucGs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170171: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=826527c9db11f34ca500033e131633f831da2ac2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 06:01:11 +0000 flight 170171 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170171/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 826527c9db11f34ca500033e131633f831da2ac2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 834 attempts Testing same since 170171 2022-05-06 05:41:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5967 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 06:13:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322610.543982 (Exim 4.92) (envelope-from ) id 1nmrDo-00060Q-J2; Fri, 06 May 2022 06:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322610.543982; Fri, 06 May 2022 06:13:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrDo-00060J-FO; Fri, 06 May 2022 06:13:48 +0000 Received: by outflank-mailman (input) for mailman id 322610; Fri, 06 May 2022 06:13:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrDn-00060D-39 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 06:13:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af2326fd-cd03-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 08:13:45 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-JcT1k8aqM56bkPfpwUokgw-2; Fri, 06 May 2022 08:13:43 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AS8PR04MB7494.eurprd04.prod.outlook.com (2603:10a6:20b:23f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 06:13:42 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 06:13:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af2326fd-cd03-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651817625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/m6M5PdIo183XNuhsQof18u125pEv+4w031oOJ0NaAg=; b=TUiwnpiuHtCS0+F3QeOIOa1Arq6X7iC0IFNnecspyIGPvMVHlbNSoZDUMmYXttg1C0ZuHV 9ndhgwqGHlInQD9HS8DwpoiNcRzAVMiM3VFNq6LLj9x8CcFOW9VrCfjtGJKxPIFM8fx/Ef fUhMrpEVLn2XGC4nZR8KZ3myjSf6CEw= X-MC-Unique: JcT1k8aqM56bkPfpwUokgw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJ2wZZISCL3Fcd4DsJEfq9NLPXUvLY+ucRgDxVTtHvrNhPAj3nB4abhayhjU512wCP3Co2WqVBBhkr+upAo7g7ge10kYVvM47oAJxCgkePSBz04DTkpKqNtdLibLk143Zl5wKskCzFLOn4Xf2+df+OFt2GBPWUALu7xRbvweg+/TTGT8CZETwzovjGs5k9bJic1OJlOIBUChB+lVzaEyXNZKM5sh5naFyoLf4R7KeM2QL0CW5irPX374Mresm981T2Nl9e4qFfivCXPdlc1T8eVnLzK0QyA6xr+H0lRqa6aItI3Z1WZ0y7hrM5bbkyDBhGDjNsjri2WZIhF4VuUNsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aC/TCQ7O2lIYL6GEdrh5mryY1iCV2JHTnM3E8OD/ylA=; b=V4m0wNU7QiVZx/P+jGFktMw+rW4JhE1DqKZj6EQPRtMFUOZngWikPjEy/4ZSkgL8KdfD1YdDSOFcncw6VpdC+n4ksR+WR3SRqcwYyeSYgiwF8D1ZoTR+4gnxx2un9Tagj/eVl6K58fyr6fiSuz0wRj2albAkavaMxSoXR2sTUkKXaYf6hcifVoZ1ANyfcp1rf4Vi+U0kWu2QqrZH6wuyHqujSrbgN8jzoB+1IMyLMF4IdY9qHSyhLPsTFQS2BRAvVp0unfBGGLksBDc7XYxOvGwS+YzmRipvMqEcZeAUhPD2MAnmJIadoSSCoh9ZeBII/mhDMz4yMyRMdJTNH7qE6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 08:13:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 11/21] VT-d: allow use of superpage mappings Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR0301CA0005.eurprd03.prod.outlook.com (2603:10a6:20b:468::9) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: acf39d95-79eb-4f02-1581-08da2f2791b7 X-MS-TrafficTypeDiagnostic: AS8PR04MB7494:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3pf+lyQAzAf2zbDYMobZM26naYJMGVuRAQUQf2fUnXBBLiH+lH/lfuAUGbYUa0UWgqLQ0OHnUlqobkCImuPFyxLP6nqxTg7BMUR0+TGdxUw56uIKRqRAMfgaL0yKMqcglkR3vHjvhXddXlGz/CdGzjJCV08DqtwnizHs9eqLKK63E2JxZS/Fy4jppyMLnYU1FBuW1rZmtAXMZzKiiRj54EWR4WASEuRuED6FZyrI2du/DT4rLQYIaxQq4z+RBDmEt8/N2cZxxofkB78aS+4J0/v6j/iypgnEQxB50/5XRVozanYPp9Xgp5+quMrVIgBQB9R7GVQSOyyH6B0BxJn++gPogMV+OzV73n06MU1US6raTx1/GSbrwkOw7irfL6V8u1pEtoGOnt1xVtD6bErT3rQni9JRyjqff137UDN2iUE3aOnYwlaGj5jNZ1QELN0IH27XLVKY3iDWxYbSvzyUUd4qonLBkqYqrVA5JCEtlWnDF7Nw0V6G1hAalgj2qNgQ65PJW2tB9aGZ1ilaajZej0FcOcezwT9pC6OCkiwaS5i/5yXX3itpjt487TiXM4BTOyhPvgxVLjyH/Dsgwj/n4fXwo5vZPRdlkSjkoADblfQdno68N6AVN1QeTDzIkaicqBSg2L5thCmsmnW7Ryfu3AV6spuG8mz+cEotzd1iAv/jzHHcP52c/Nq2qyoLMIz+wjVSBEH6+/tR3UfLR5/xAWQqdOX+hdrzNFawAE3WS+0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(31686004)(4326008)(6512007)(8676002)(83380400001)(66556008)(26005)(6506007)(4744005)(2906002)(86362001)(2616005)(53546011)(186003)(5660300002)(66476007)(38100700002)(66946007)(316002)(8936002)(6486002)(6916009)(54906003)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?olcsdQlWVSlHzPd0Yy6/vXfqKQ2SpmgYsPJVNn9hNC1SPlDKrTtFT2jaYIFi?= =?us-ascii?Q?cSKJMXFpLCH+ZeJstxu5NqQmSNMTM+Bhz+I/YT4DEH+CMlY93kepmSMJuXXY?= =?us-ascii?Q?j3LFD/z6lKRzMKyIh8+qDTcMdvfxuddML+igV9gUKu0ttjXs9MtmpS/bcRHO?= =?us-ascii?Q?EyVjRXgEE6GCvfmms25binC1yzLPwGFisI9cREDqekce0R2vJpUm8gR++FyM?= =?us-ascii?Q?swdNUPgkamSzQS6qbQMIRfTcVNWAeU6SJDEFL/2NEmsGfkDEMqIllcvg1RIf?= =?us-ascii?Q?+ObkLCT7lHC8Pwt/CEV60Um0AZj8OgoV+uTuBXsys2dO+6iKDea2f/s7iPVo?= =?us-ascii?Q?LwRAIvN4ozffYJMf0Wjl6shKStfQ1rEjOKsR729g7QpaNQ0vtA6acn4ts9IF?= =?us-ascii?Q?uNfFZLsvZTQCs+7VgmbWYOMwZrhnnp8rpvUznsMcS0VzXTgUFvhcVeXha02b?= =?us-ascii?Q?VOY/uumfLHZZpSBECVnJKuq+pLEQXpKTGr53AsQio5REwM4KTJPBvBCCGOCQ?= =?us-ascii?Q?BsGAC9apcZREu/RJKmtVUmVTtzoKWTPmMgl3yvaFyry2lFALaU8Ddpz1JJLY?= =?us-ascii?Q?KZMKkNEdudm6Hsi7ICLTCck3kNazMUEW7TbVOLB4FsGwgtqe3KvN2Zo944cg?= =?us-ascii?Q?WpEnjypUeDlhEOTCUtkTU7BuwxVxY017/1Aw/ZLANjIh74uZEp264t2JsiHm?= =?us-ascii?Q?3cL8g0TV5g+seGe7g/3wJIoWs5eRl3VokPjtAGqvlG1zSb8Mh+5PttUzR549?= =?us-ascii?Q?91SgK1V2Zq6+Fpvqi/vlOg2f/tXTOcPftvcKsyIc9c4kKoyLCprinonUj5EZ?= =?us-ascii?Q?7tiGq+qvMSal0PcWgZTtusMkrZITWMlil5srOha+6VxrQhAuhCUjDN2RF31N?= =?us-ascii?Q?Bv31D1ovtGpXQARg3COqX2oyQluNV+oofGwtptAShrPGbqmXEL95WKaXDGhT?= =?us-ascii?Q?cwzXRnBEq/T/gjmgy07ayuRjgkCkrttw/OrxqEhZbY3+Qw2SSj+Th5GRVjcA?= =?us-ascii?Q?GwFpt7QPCq9MDJvhpc2VVSOPr10yjL0iO5m+I4vKYg5irnxQg4CSQZLNKGkt?= =?us-ascii?Q?o9ZDck6Jx1g79rpfgWhwywe3w3gOWerE+pwSt008IBZOpy1jMwwZH4NGyVIu?= =?us-ascii?Q?ZGETZbR3QmD9Gc+epWs2Jhp+CU1J5/anjuk/lpRZci2spwTo6pYa2oyzdfjq?= =?us-ascii?Q?wwyVViHSMZ4xfPZNWuOc6v06Kxolhz0M2FhmnTPTf4N8+9wssoFQHJF/eij0?= =?us-ascii?Q?M09t3dK0YabGQQvM5YIAiqrR/cSvKXbMzEGf9oRpsmqAnOyC7qnvKjg4r/0k?= =?us-ascii?Q?QBy8Ho4yxxqQGKFheCKaeePbGb76fqV0CRo/zqqdjBE8P25DPWvfr2DFmlBa?= =?us-ascii?Q?IxS+C5UYc7YFBu5RnWs/AIyS3FgeoE8HTgHk1GFR18fH8qDpcMdLhitOgMln?= =?us-ascii?Q?YXRA9FOCLY2M2LrjIzVM6+di9xxmwPk06kH9pMnNai9EzvaVJaued+KJPiOa?= =?us-ascii?Q?ygCwZV0TN7D5u0PJn2gsymEuWMnjbCL1t2McodolHasLUv2cVVFS80a6XQFm?= =?us-ascii?Q?XFYX4S/K4iTzhQqee1FvAibwAklIKi5QQwtRCVssHP0/tf7N1x0ZHg4manId?= =?us-ascii?Q?MpG2SWtHBgg7W8CCtZyWdoaXhkRlxlmGeItQ/fHgvIAw8yUTx/70CwsqTWjs?= =?us-ascii?Q?AvWbiKjE/Aa2OFqDs/v1MRyQLrkQvmb/FZN9gtVwm9t/KxF46/w6Ru2kfSnx?= =?us-ascii?Q?xZ/+P6O8IQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: acf39d95-79eb-4f02-1581-08da2f2791b7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 06:13:42.2364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NyR9O3fwWlmd5ioA0hZElt4fN8oGdLnuHzjAhtXpnl1Spl6YuF2oc0O0QD7/BmeWs3t+BckuLp8HZlVXrKEW4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7494 On 05.05.2022 18:20, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:38:37AM +0200, Jan Beulich wrote: >> ... depending on feature availability (and absence of quirks). >> >> Also make the page table dumping function aware of superpages. >> >> Signed-off-by: Jan Beulich >> Reviewed-by: Kevin Tian >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. > Might be interesting to also add an assert that the passed order > matches the supported values, like requested on AMD. Sure - I did extend your comment there to the patch here right away. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 06:14:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:14:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322615.543994 (Exim 4.92) (envelope-from ) id 1nmrEZ-0006Uk-UD; Fri, 06 May 2022 06:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322615.543994; Fri, 06 May 2022 06:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrEZ-0006Ud-PG; Fri, 06 May 2022 06:14:35 +0000 Received: by outflank-mailman (input) for mailman id 322615; Fri, 06 May 2022 06:14:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrEY-0006M6-LK for xen-devel@lists.xenproject.org; Fri, 06 May 2022 06:14:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc456f5d-cd03-11ec-a406-831a346695d4; Fri, 06 May 2022 08:14:34 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-P8U6oUfjP7-FqdII_VHThw-1; Fri, 06 May 2022 08:14:30 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PA4PR04MB7871.eurprd04.prod.outlook.com (2603:10a6:102:c2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 06:14:29 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 06:14:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc456f5d-cd03-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651817673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3G2EPdRZbYZXLcg0XbTX+qnuH8xgX3vTMGts2VbuJfs=; b=R9KBUAr+EkfI9kTJkXHE2YkzklPkE0VL/z2oH/09xbLwX7KYqNAAkshGZxSKuMwjpgg2IV yZ1vpchuTVea6T9GJeM5oQq89WTkdev3EpimfAVKKyfSs+U4HQS1ZgxrL0suROghqJdiTJ dUOpsVqJQhkkcx1ZDOHeeyzdB3v1oPg= X-MC-Unique: P8U6oUfjP7-FqdII_VHThw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSi7xsyivMEA/FuMg07VONv+uv6dJWwff0C8YHZxISHjEtNuN8rE4Ro1eIBYZsecqydCObiEJwASgcJQ9pY5UUq/fzTwCZmafsnzyYAkRCBXtFWxCer+X17ypaH02zlF5GsG3M/4Jch9FBfs/4c+mCQRH14LpblRLa9Vp7w0Ymj17wPt+r++GJMd9eLcindvjSZEmdXQpIIrQcfC6cRpOuktk70IP+S6dm5GYlpHU5lGqLL6+c5IVVQmeGW4t27yFC+vLVnmv+nFXsJ/lsnETkws3afPoPQjg6F6sdfOdNOElQXbBg1I/zmuVtgb7VlmB5cfNeh+ancmceVbm49FYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3G2EPdRZbYZXLcg0XbTX+qnuH8xgX3vTMGts2VbuJfs=; b=GRzZmoXyxfbe9v7L7TbNk8tLDst2YaYSkGnUrf/lSvnawBYkdIwfJucfyMBeqX3E2iZweaJqN5sRuAAq5rj7lciB9WT8/YNf01v4oEwyvBv/RX0eQFSjca8uSBQsjlRNQeUVc8M0Jk2ieovqgyJKMOnw3fMtOYjBulLDQ3cwUdzYf7oXhvm7hK4UaaRPO8g3tGsVhLa6yJsf0qXqJl2yGsscNWP2TM8lw0TIJ2AKTeuNbv8EhTWvbG9cT0BRE8Dsjj/IuIVwVbjJ/ueLBoGS9KWLYiNk2c3dUDIjiMlkNGdnoFTeDQWzY4NMJxZ/gG2ahb33q/BWhxfMADAtdw7cNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6eb6f0d0-ba46-9d4f-28f1-9612bd876e9c@suse.com> Date: Fri, 6 May 2022 08:14:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> <306532fc-939d-efdf-047c-7b8556d40738@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0001.eurprd03.prod.outlook.com (2603:10a6:20b:468::8) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6fea9d53-1322-4307-97d8-08da2f27adaf X-MS-TrafficTypeDiagnostic: PA4PR04MB7871:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I1tFqVVdFb2SEQgefuypQ8Y4/To/DYQLYwunhlqbf6R9eA60GDniDzq4YFSATn7jj2Q3BM3AX4VEfkoU+10daAtlau5AAnn6PrjUaNXRHTi7SvOyGveB46ANHqgnWi84Xtd9rD15qauLoCn5JgPkbnxzfGgkMXageFYoHefvJR5tscsHjQkO3XsqOCGLpknHiekOkObANQSaM6NheWAvNkt1YsRPbEBoDVn05/1lomyWBP1ZpIZ/CBrANvtwncAnv7kZ2fIOYU7tF89w5GwmpZMdqzBhjBvAF9qEgmRhdQymmtsr1JM/0D84s86bl0wgaPjhLUHp58oKdr81IOAnWqPG8lqJwNU0AV49fabsY+b1Go4f4O9CtY2NfRnJx/Ng3MfMof04/oYVjRfygr0fZUbWkG8aaBn8TdLGf5n++xunUUUE+sJWUuJnoQ2hfXSAQcl7FPHde4SR35f5B4U88j/s7P9LzJRuZme6tEGQQk9R39OdA/10PV2PBrSJndB/RWupqO3J3BXSegS9XrpbkuLVi540Gr1koSesU4GWg2NiQSl8Smp09cYUEElFZ/U0yX+P27p7SEglJhqyMnYHoKiBgrvk1vfeyNNX2HU9FYtxYhhWEogvsP/CxvuF7oYPPxuySOEiRyEzivAp/1TqS5i8K8pEAVP5PkgAa0P34HK8vn4iFHDAtbLorI90bh7CkOBnzmGqriYp0YQ5U8IuuneAU0gB0/NTYErsoVqlt3ibvxCpXunkeNa0GROSxszm9mEE+Rp/MuHKtK/UHX3HCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(31686004)(6506007)(8936002)(2906002)(38100700002)(316002)(6486002)(186003)(83380400001)(2616005)(86362001)(6512007)(36756003)(5660300002)(53546011)(66946007)(66556008)(8676002)(26005)(31696002)(66476007)(54906003)(6916009)(4326008)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elgzeU16cm5id1pVL0VLVFRYY2pUYWVjUm9wV3JkY0ZtYzFoMXgxNFVUNm10?= =?utf-8?B?WXIrcEd5TGlKV2Joa3FaZjJ6T29nY0JvRSswbGQ5RXFIQzZRcXdWWlhvNWhZ?= =?utf-8?B?NzQzdTZybU1PQ3pYalMzOGhBaVVlelNOeCtZZFZ1clNRSnlUbUE1OTI0U0pk?= =?utf-8?B?UThvZ1Ria01qU001TjkxNDNINU1HZ0RlZWpjNGc5aXJXUU1UVFdBVFd2aTdO?= =?utf-8?B?bGdkYU5rUWVObmZPQU1CRzJWUkdKdUdWRU5QbjRoRkJ0d1RUc2dVcmNkcGxW?= =?utf-8?B?b1F2THhBK3Z2UHBpNTNkQTkxWHo5UVdVSVBGRUJpMzIxQXZVU1p2RWt5ZXVx?= =?utf-8?B?TDdHeEFEK0tQRVRBaEVYTlU4ZFJmcVZjQlNBUHc0Z1RlYjBIcGxHOFlHRVlR?= =?utf-8?B?YnJta2lQYStBL0tKQU45eitKU1UzWStFdjlxdnRmN0ZNTmNheWdidDdTWUhv?= =?utf-8?B?QmlKMHFLd1pVYWhmVitjZjhBamJhb0owTW5STU1sYnh3V2Y0bUUwMUNFSFJK?= =?utf-8?B?anQrZS9tR0cxZTR3Y0VtZ2JLZmZyemwzNFQ4bkg1TnlLK2UyUUlUNVRobzh1?= =?utf-8?B?dHVHYkl5MUZWSyszNGFvVHNONTBWQU5Ca1NBWXBoOEp4c1dTU2N5U05OVmJD?= =?utf-8?B?RitacEM4cU42QVNFaDVvdHMxMm1vTGZtZE4wVmt4NVlabldTNGd2QVZvUzJP?= =?utf-8?B?cXVOWXZvNzAwUW1tV25OQXZjVFNaVTBJTkpQc3VkalZJZnJ0ekdHSlZCMkNr?= =?utf-8?B?MDZhMGV2WlVKS1ZSc0grbGNQVWI2UXZtUk9oK2NkNDlnVkwxV21hUGc3Y0FF?= =?utf-8?B?dGt3cWlLemZPZ0dCRngwcFNWYy9TQUJTbGR2UjQ5Tm4zcXZZUm1sRzBwU1hN?= =?utf-8?B?RlZ2cVIwWk9heDJBTW9TdzE4blFPN004Mkh6ajVyZWkvTHB2SUtibWEwcG1S?= =?utf-8?B?RFZ5eWI3ZVBSY2gyOXlTK2ZLYmpoL01lcG51VE9salhJQXhXelZTdnlKQXda?= =?utf-8?B?ZjRaV3RSaFY1U25JNGtLZWRoZ2d6R0RpQUtKUmZSY29pcTBPVmlKTG9kcXBl?= =?utf-8?B?b2dYZHhUbkJMYWpxdXp4aVM5WDFBQlY1VWVDZXkxdUlOVEtmUm9lclNkL1NV?= =?utf-8?B?UkJrdjVrc2x0dWJWSjcrcTQreHVYbVRKY3UxcDJPSXYyeGVzYVg1OXNjRy9h?= =?utf-8?B?dk5OL01nMWs3OWVWTHYzTEpsSGUvWHdUWEpwK0ZrT2l0ZkVlNXN3Nk9YSk9D?= =?utf-8?B?elVWSVkzb2VEUDFocTNsd1puYW9RT0lFeG5acFM4SUUrMEJEbUVJdDdMbnJY?= =?utf-8?B?dTZKTFM1THhPd0RXKzZCcWtsWFNjSWRwcWFTU3lZMDFoMXNIeFV1a25MeHVJ?= =?utf-8?B?L0doZmdydHBCNllGelFuNUV0RDMxNkJyK1B2QnhiSjA5ZDlYZmNtV3lPWmh2?= =?utf-8?B?M0J4VXQ3dVFnejZzZzhLaHQ3QmdmUmt6a3lHR2pQME50M2tWVEp2ZG9vUkZs?= =?utf-8?B?cDh3c29pZjc3SmI5OUgrY0pBWWJZeFhzZW1mazZudFdIUThrbHpqc0g4Mjlh?= =?utf-8?B?RWl3aHAwdWdZc2FUOVh6RHdXZ1RWT3ZXREFLMkJDa0VQZzdhdkdkL0lVUkFM?= =?utf-8?B?dFN4cVNGSzJlendkeHQ2YjlwTGUyTmQ2eVBENndvb1NsMlVTeHpIRlFNWldI?= =?utf-8?B?eFdScE1CY0grQUF3YXlOQ3NTeFdscnBSMTJ5U3QzbVJXYVFldWo2dXJSUFkr?= =?utf-8?B?emp2VWJDajB5WXY3OWRyUjQ2YUNGM00xQ3VZWmw5VEFPMEI3ei90Tm5UTEtr?= =?utf-8?B?V21CRFdmazhwNksvaE1lUXRDeXZpV3MweGNZZVZtcGREbWdiNVdIek5XdTFh?= =?utf-8?B?bkJrbG9lWGx4RUtPL2VmRFNXZ2krVnRqMDkrZld6Zk5EUFZpa2FhSVhjd21N?= =?utf-8?B?bE5nSi9yNkpoQXdadGpkeWhNTG9LY3cvWTQvWnMzaDNEYXVuYk0rUnVpWkZ2?= =?utf-8?B?ZEdQSzNOdkNSL2daWmtLSHdjK1hkczZ0YU5uSmRBNzhLMXhVa2xqU1BLZnVj?= =?utf-8?B?WExRYVdFeXF1cHY3VGlmN1JVYm1QdWRGaFZxbzVheVJBMDZsSlVWSjAwZzUw?= =?utf-8?B?K3pZeDUxUm5XRjI3L1FSZG5vbmd4NE5ISzQyRjJtNnVyMS9UbU9jam50MHlB?= =?utf-8?B?eFRIek1oemZWcEU3SDdmWlU4TFRtRGdWbWtFWlFCN2kzamdaRkkzTXNpZUpI?= =?utf-8?B?WURQd2pIMW9IRkdmNWVHa282WkNRcUUyRGVRdTBhWVkrR214UlhpSTJDeGwx?= =?utf-8?B?cHJvS3A2Zzh2NHI1R0dBRTJlL0lsWGtrckVzaGFVMGJ1U3BvQWcwUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fea9d53-1322-4307-97d8-08da2f27adaf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 06:14:29.1479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UcGL9pW3q8F7BEPP8jn9SFZDhvJNLebDbNNrovCuFKTe8h9xgNacoAUnNwIooumZf6MA2soaPW1/5uKNXvZrZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7871 On 06.05.2022 04:59, Penny Zheng wrote: > Hi jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Thursday, May 5, 2022 10:23 PM >> To: Penny Zheng >> Cc: Wei Chen ; Henry Wang ; >> Andrew Cooper ; George Dunlap >> ; Julien Grall ; Stefano Stabellini >> ; Wei Liu ; xen- >> devel@lists.xenproject.org >> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap >> >> On 05.05.2022 15:44, Penny Zheng wrote: >>> I misunderstand what you suggested here, I thought you were suggesting >>> a way of stub function which could bring some optimization. >>> The reason I introduced free_staticmem_pages and acquire_reserved_page >>> here is that we now used them in common code, and if they are not >>> defined(using stub) on !CONFIG_STATIC_MEMORY, we will have " hidden >> symbol `xxx' isn't defined " compilation error. >> >> This is what I've asked for clarification about: If such errors surface, I'd like to >> understand why the respective call sites aren't DCE-ed by the compiler. >> > > Because both definition of PGC_reserved and is_domain_using_static_memory are > not guarded by CONFIG_STATIC_MEMORY in the first place in arm-specific file. So perhaps that's what wants changing (at least for PGC_reserved)? Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 06:21:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322621.544004 (Exim 4.92) (envelope-from ) id 1nmrLA-00084L-K7; Fri, 06 May 2022 06:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322621.544004; Fri, 06 May 2022 06:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrLA-00084E-GR; Fri, 06 May 2022 06:21:24 +0000 Received: by outflank-mailman (input) for mailman id 322621; Fri, 06 May 2022 06:21:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrL9-000848-PB for xen-devel@lists.xenproject.org; Fri, 06 May 2022 06:21:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf553445-cd04-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 08:21:21 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-ssxPRdBzNTCJ9Wp8D0gS2g-1; Fri, 06 May 2022 08:21:21 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB4012.eurprd04.prod.outlook.com (2603:10a6:5:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Fri, 6 May 2022 06:21:20 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 06:21:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf553445-cd04-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651818082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+pGjnbweYaHA4xayDkkEXpE+qb//DH67g+T0OmdbJA=; b=a7lc0JtovLBgwleFOxkGNrqBth1fgJ02a/Ivb2jTAcm/oUzRLhpGa4VIuHr095yNKEmKfj juenPzuO22RkNplqSfr6ap7vQLcgQtOIjLtf6jqZodvZ2mrVIR9osZzXYXfdevXcmBCR/y EawsCalsTxC5tdS1Q337pbD6q5xyCWY= X-MC-Unique: ssxPRdBzNTCJ9Wp8D0gS2g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNsTm+VxutYSou4lX50b/dwxWoyM5xdYPDiMAXSSDE37PdV91nPTIvqxLrLZdAY0JRlICw15JbHUtrbxIobnIFOw3o72d4DdG2ZM1ELLaCEO5gCKBJGnViTD1qbOLUPT/CzZLliY7WQrjrFJqpmD79N5m87I+VwRE0L7SM3HRBL39Z5eqfaVTmAppECE7v8cWGR1FuPzzBfIH9P9IlBaLQzzP+tqN2RcpfX0gLFJe/9i9k9Uruwl+AbOMvtuQ3oc/H0pLHIwWfLxl9N8XpvrMuGgsE6FwCkidEOp6Mo8KzB/F4P8fUnzd0yg0MrBjuobppAid3oAkUdhiP+qh2ad0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5iYyXUBKqtr61nfZQ7cUsWxfB4MPrsV9/ZPu50W9QA=; b=LddJzEKQ0YPqxLJx8KqORlkEaNvCLdRXwIXsPJEHHFD8AsDy7wGwlDO+Bquus+UtswVdC7mQBw+2nlgAqO+f8BOYm00SVcAtTamXsHAV9Y9TEvtCSqeySv7m5+1lHlgZvQ/aOKeVePtL7wt+/8YXfA+OkG2eEEuR1WYm6ypVEL+YiAZhLvQxMznif8bqUOoHPV/AGJ73GBaEUn7AkgdUcKRs9/ei232N2i2TsP9lpkUAlrjMwHvwCQ80pS8rTcPZAme0/buh2TeLLCprF4nNTk3aAhnsOq3SZEV6fSiw7WGzucq0ldR37zYdL9uuoIIouGNf9ewn6w3GuIocAomd0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3e7eef54-975f-4c2b-2ab0-bcd16289a0c1@suse.com> Date: Fri, 6 May 2022 08:21:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Content-Language: en-US To: Andrew Cooper CC: Paul Durrant , "xen-devel@lists.xenproject.org" References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb2603da-b6a6-40dd-76d1-08da2f28a2ca X-MS-TrafficTypeDiagnostic: DB7PR04MB4012:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QcQT48w79fzpm51YhtjHxJpc0+UzRMOLs6sbZwjj7wawC5PdZs9ac4ohAaFjQhSIn1FhfHRnUSpmeZ6RSA6m55Fb3v0VCjxLFn4BRE3twN1wNN06VLqEYpS6z7cfnpzt1lkCfa4Yi2THjspX3Foxg6cYtoiU8rG21oWcG/CNFGQ1F9IoKKrmrwe7BThOD0bbRSXF9+DbJ0lIsRgqifBeIhMoVM+cVV9/rNzXXVsgvhchuiZR8M1w+NI0lKTAp+Kxv026DjSl9pMOpwAIA+e1RhL4KA8Gckwu/Qk5P/K2LtNYlv5LVLlYpAEYyqrX6EvlH9HulVPy+ObylF6n5Et7PYVwdmJjvtlAqwGNZ1hwD6qJfL07zlPg/n8QEr/jvHKZ+kGx6NjOyKCOeScunEsiu6SLB7NUGPJTo2cNQdZRm3s0UvizZoBXb5a+NOyuFg4YGmwdZmkWfwFBXYv5m3ubilfMc2V7Ud1t1qnMzTbOW4nQWaKYgSzEirUA5d8FuOyiRbDIN9TMVIBgkHvCW9BTWN9+I0++qQude2vBvqMWRBG6wqvzPXhM4WKG7jD1YbjhDYIlcZ/t3ACAIr48V+UDmy/2ryV9KuQ91NO+Tup/9Udz0zHaDFhMk1BZJ6COQCdiEb4yVm0/rxxd6WJWcft5p9loKu9iPJyJoBXWHHVVd8jAf7S8FnwoTk/Kcdg4FTugVnP7xC7Ip02yrIsWhseXI7JrPH6x8zqHAK7Lx86mQAMdX3CkEBgWy7T7rK2h6Ml7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(31686004)(508600001)(6506007)(38100700002)(53546011)(2616005)(6486002)(36756003)(8936002)(2906002)(54906003)(6512007)(26005)(186003)(86362001)(31696002)(66556008)(66476007)(4326008)(8676002)(5660300002)(66946007)(6916009)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/dn65tCrhXOwJcjDb+9+yG6er3KuWux6D3dajKf85E3F6EBgBhprmtioZbBr?= =?us-ascii?Q?Bhr0RDLBuu/VMSuJ0qTfoNN9oEhkQfjKpQZOY02cliWelqre1gYpipsYFvwi?= =?us-ascii?Q?QpYLeF8eN946dAre9SJ7HwYcRSUK9MoX5CtMvPcjRnfYZ7nNlnkdHs2PX30U?= =?us-ascii?Q?CXRt0btsgcVWHwwgbaZJa3JxHbMpxubjP1ZTXdr309Mcz5wgrDgupdiDfxwi?= =?us-ascii?Q?Nkj03C1e3y3QrydA3PL5aF8xRQUUodWHC4vHhLML7OxdDfJd3lSs8TE+BK+Q?= =?us-ascii?Q?9p7BSyXgx1LypNBStlhlQp805Q/lSLj0MUqhhrN1FTxI7H718TZIBpPH+Ltc?= =?us-ascii?Q?LCo4JI/+Oj8CxWPaqd1xDQHwUp+obCBJKJmNZBvPfDwheUl+WLHSLNaRybPN?= =?us-ascii?Q?mw7vr9rg362Bi7Ha4FhNXvlDvWnxtFRztiC21N2CGpGDxQp0ohqFXA1jTiT1?= =?us-ascii?Q?qsI8aZ6d4ODuGrDtp102tSnkHnI2CXXnzg+v/zzNChDSDQtcOkFQ2L0Oeug3?= =?us-ascii?Q?Hat0LW/iISzi5jVcLJAiL6PX8SQu40rrtmN88S0h3Nrqe7YmfkxrcROxA+IM?= =?us-ascii?Q?GlPA4+llcVAxZrI3Bv6lN/aAHXBTN/MTtF+cAvIy458aVC3u0/9EIBVgd+eU?= =?us-ascii?Q?FeUkZmB4sPmzzKT/IsjX36kXazGKsuZSa1ckl4zS8VSn6DNK8VIzDtQzceo9?= =?us-ascii?Q?HYAXQtDC3bN08Z3QgyPqgWiK0PuzUMXR8G0MHmwGkeWb8zqsmnooY4B6OUGc?= =?us-ascii?Q?Is1TBzk5r+3WV1E8GkwVBqhcH3EFdXTrx7HS8Gh+W8BEOfSlSWNIJgEL/YMi?= =?us-ascii?Q?yobKuzNYA0VEMyD632+f50C0yhmcjUBlnu+VHLwGWCAUPUIe9WAmjybGSwsD?= =?us-ascii?Q?mH2Yo0wvcRyhMHLH08Lf//REh/o49gZ2QpMe0Pwc2BEAMGnlxljLjsnjta2e?= =?us-ascii?Q?Vdl0uIdBiNRHwvuzn85e2Xo47lF+dIE3oq5AHSlZyvm7jILQKD1LJCdLU2Vl?= =?us-ascii?Q?bghlrWd3vb/9/C+3oNttNToVGCpAM+0011mZ51SX3Dk1f2Jq8BrQ8NxrHmi/?= =?us-ascii?Q?YX0i78UGjONBFKgSikbsXawN4GdNPH2XkP/RoyLKCY+lRE6ttxEo9O1QBzwV?= =?us-ascii?Q?L0zSIPeaKg3iaCvxq13slTKDHWby8ihQqDMNis1HODl9LwHK+VHQ/X/RC6Gl?= =?us-ascii?Q?ZUftsdhKHn74g1cIEBmt74St2/q66k2myvVOi5RcllaQUllumbQAe2SaUg1E?= =?us-ascii?Q?32NhYoWSKhbeUCmLoq+oyKCMFjLTnxh9uYjNQA+BtyvsutYoY2s+OljwjMrt?= =?us-ascii?Q?I9eZTF2cfxs7zcA2W8Vn5408+6DMxZo8BYtxC5ccIm5CvoJkJZnWlSucWfWP?= =?us-ascii?Q?IBWDN9/t+SS/G+lNDsd1QhoxFSfyueprIFB/j4W6Q2AP3H3/3NcO0FqBQtyk?= =?us-ascii?Q?s1UhhnBzyO0g/YHqm9mxDqcbVNjoTPb9MRDk8sBW5fydePOH6xOJv3nRU2/Y?= =?us-ascii?Q?BF49j+k3OKWKEZLKpMas9q9ne9+F9r/bqtobshprGnx2h2JIR326sIlwIjiu?= =?us-ascii?Q?8eLKw6EWd80dpCMtstRkzqrkAiUxeA1U1Q9QLF4wMx4Hzc1wLkEgczREKCQt?= =?us-ascii?Q?R0D7LrFmdmcSFB85AyoqeNlbcPfAOeKKgYyTsneq/mSaIrPohIRGXqaudXt9?= =?us-ascii?Q?0bv7WBXZZPyF3l24Q1dSNj9aJq5p74Ly9+NKZPOYW6KxkJUg1w8WO9zFzMkv?= =?us-ascii?Q?w47nnUUpXA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb2603da-b6a6-40dd-76d1-08da2f28a2ca X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 06:21:20.3970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9vDNtZLFcfkoDqsP8NtG8W4Ro+heq4+4+E9CKwDF8bSvcQJqngZJPLwFJcQm0Z9gkXFX6QEkW7wcQ6S/+n85mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4012 On 05.05.2022 21:10, Andrew Cooper wrote: > On 29/04/2022 14:05, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment= s unless you have verified the sender and know the content is safe. >> >> IOMMU code mapping / unmapping devices and interrupts will misbehave if >> a wrong command line option declared a function "phantom" when there's a >> real device at that position. Warn about this and adjust the specified >> stride (in the worst case ignoring the option altogether). >> >> Requested-by: Andrew Cooper >> Signed-off-by: Jan Beulich >> >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct >> phantom_devs[i].slot =3D=3D PCI_SLOT(devfn) && >> phantom_devs[i].stride > PCI_FUNC(devfn) ) >> { >> - pdev->phantom_stride =3D phantom_devs[i].stride= ; >> + pci_sbdf_t sbdf =3D pdev->sbdf; >> + unsigned int stride =3D phantom_devs[i].stride; >> + >> + while ( (sbdf.fn +=3D stride) > PCI_FUNC(devfn)= ) >=20 > I'm fairly sure this doesn't do what you want it to. >=20 > .fn is a 3 bit bitfield, meaning the +=3D will be truncated before the > compare. And this is precisely what I'm after: I want to stop once the value has wrapped. >> + { >> + if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) = =3D=3D 0xffff && >> + pci_conf_read16(sbdf, PCI_DEVICE_ID) = =3D=3D 0xffff ) >> + continue; >> + stride <<=3D 1; >> + printk(XENLOG_WARNING >> + "%pp looks to be a real device; bump= ing %04x:%02x:%02x stride to %u\n", >> + &sbdf, phantom_devs[i].seg, >> + phantom_devs[i].bus, phantom_devs[i]= .slot, >> + stride); >> + sbdf =3D pdev->sbdf; >> + } >> + if ( PCI_FUNC(stride) ) >=20 > This is an obfuscated way of writing stride < 8. And intentionally so, matching a few other similar instances elsewhere. An open-coded 8 here doesn't really make clear where that 8 would be coming from. The use of PCI_FUNC(), otoh, documents what's meant. > Given the printk(), if we actually find an 8-function device, what gets > printed (AFAICT) will be "bumping to 8" when in fact we mean "totally > ignoring the option".=C2=A0 I think this really wants an else clause. Yes, "bumping to 8" is what is being printed in that case. I did realize the slight anomaly when writing the code and I observed (verified) it also in testing. But I didn't see a good reason for an "else" here - 8 being mentioned in the log message is clear enough for anyone vaguely understanding phantom functions. But if you strongly think we need to make the code yet larger and indentation yet unhelpfully deeper, then I will (begrudgingly) do what you ask for. But please explicitly confirm. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 06:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322629.544015 (Exim 4.92) (envelope-from ) id 1nmrV3-0001GA-Mx; Fri, 06 May 2022 06:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322629.544015; Fri, 06 May 2022 06:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrV3-0001G3-K1; Fri, 06 May 2022 06:31:37 +0000 Received: by outflank-mailman (input) for mailman id 322629; Fri, 06 May 2022 06:31:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrV2-0001Ft-Fj; Fri, 06 May 2022 06:31:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrV2-0007pT-5Y; Fri, 06 May 2022 06:31:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrV1-00082h-LL; Fri, 06 May 2022 06:31:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmrV1-0006c9-Kv; Fri, 06 May 2022 06:31:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=we+6sD8xH/w9br7iUaGrH33a1gq1/8Ue+sxmtgM0s1c=; b=KRAnIVIcidYKqgBN3mgvidA3bP fBxK93qJ1Ow/pOJXRJuGa0zxbNgyNpnWntQ0kP8wZWDs0IzgExpliu9R1n3JPkE2kKDaVYprh6k44 aGsf9l1Taeufw8CVcIWSoTC9OKM/K3bMTc6QzntGaXkx02pZbMJYe/0vZqogDDSsmg+4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170172: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=826527c9db11f34ca500033e131633f831da2ac2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 06:31:35 +0000 flight 170172 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170172/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 826527c9db11f34ca500033e131633f831da2ac2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 835 attempts Testing same since 170171 2022-05-06 05:41:36 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5967 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 06:39:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 06:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322636.544026 (Exim 4.92) (envelope-from ) id 1nmrcU-0001zP-H1; Fri, 06 May 2022 06:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322636.544026; Fri, 06 May 2022 06:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrcU-0001zI-EB; Fri, 06 May 2022 06:39:18 +0000 Received: by outflank-mailman (input) for mailman id 322636; Fri, 06 May 2022 06:39:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrcS-0001z8-Q8; Fri, 06 May 2022 06:39:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrcS-0007y2-Mi; Fri, 06 May 2022 06:39:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmrcS-0008Ig-45; Fri, 06 May 2022 06:39:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmrcS-00075l-3c; Fri, 06 May 2022 06:39:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Uqd4lzt/V4VAzF+Zu6+G4YvFfZ38STsZ96cG2FJe24o=; b=TUZXn1FA1MDPZZw9Ga2hf7I7Dg pcTnE8NHnqGsJ+aXeB3Ypx9dXN0KAtK5TUBUrbFH3Ntdnw1RejI6OFnfxRgqVv8uMr6vux8XrpIqY x6vCL1dVbZ9dXzBsVa9mcunAOAXYRB9kVnPBO1KOGuvKkeK52FxxXYqWe1Z0iZ/Fw7cw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170158: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0f5d752b1395e777ef81e28886945e5e939b7c8a X-Osstest-Versions-That: linux=a7391ad3572431a354c927cf8896e86e50d7d0bf From: osstest service owner Date: Fri, 06 May 2022 06:39:16 +0000 flight 170158 linux-linus real [real] flight 170170 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170158/ http://logs.test-lab.xenproject.org/osstest/logs/170170/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 170170-retest test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 170170-retest test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 170170-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 170170 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 170170 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170116 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170116 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170116 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170116 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170116 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170116 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170116 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170116 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 0f5d752b1395e777ef81e28886945e5e939b7c8a baseline version: linux a7391ad3572431a354c927cf8896e86e50d7d0bf Last test of basis 170116 2022-05-04 18:40:06 Z 1 days Testing same since 170158 2022-05-05 19:09:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andreas Larsson Ariel Levkovich Arun Ramadoss Aya Levin Christian Borntraeger Daniel Hellstrom David Hildenbrand David Howells David S. Miller Duoming Zhou Eric Dumazet Florian Fainelli Hangbin Liu Heiko Carstens Ido Schimmel Jakub Kicinski Janis Schoetterl-Glausch Jason A. Donenfeld Linus Torvalds Maciej W. Rozycki Marc Kleine-Budde Mark Bloch Mark Zhang Matthew Hagan Michael Chan Mohammad Athari Bin Ismail Moshe Shemesh Moshe Tal Niels Dossche Oliver Hartkopp Paolo Abeni Paul Blakey Prasanna Vengateshan Qiao Ma Radhey Shyam Pandey Russell King (Oracle) Saeed Mahameed Sergey Shtylyov Shravya Kumbham Somnath Kotur Sven Schnelle syzbot Tan Tee Min Tetsuo Handa Thomas Bogendoerfer Thomas Gleixner Vlad Buslov Vladimir Oltean Willem de Bruijn Willy Tarreau Wong Vee Khee Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git a7391ad35724..0f5d752b1395 0f5d752b1395e777ef81e28886945e5e939b7c8a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322647.544059 (Exim 4.92) (envelope-from ) id 1nmsLg-0007gE-LE; Fri, 06 May 2022 07:26:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322647.544059; Fri, 06 May 2022 07:26:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLg-0007g7-HI; Fri, 06 May 2022 07:26:00 +0000 Received: by outflank-mailman (input) for mailman id 322647; Fri, 06 May 2022 07:25:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLe-0007P7-RG for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:25:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c590b3ba-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:25:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 102A81063; Fri, 6 May 2022 00:25:57 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6713B3FA27; Fri, 6 May 2022 00:25:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c590b3ba-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io Date: Fri, 6 May 2022 15:24:55 +0800 Message-Id: <20220506072502.2177828-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 133 +++++++++++++++++++++++++++++++++++- xen/common/domain.c | 18 ++++- 2 files changed, 148 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1472ca4972..e97bb6eeba 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -527,7 +527,13 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, mfn_t smfn; int res; - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); + /* + * acquire_static_memory_bank() is also used for acquiring static shared + * memory, in such case, we don't need to parse 'cell' here since it is + * already parsed in process_shm(). + */ + if ( cell ) + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); if ( PFN_DOWN(*psize) > UINT_MAX ) { @@ -751,6 +757,125 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + + page = maddr_to_page(pbase); + ASSERT(page); + + if ( page_get_owner(page) == NULL ) + return false; + + ASSERT(page_get_owner(page) == dom_io); + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t *pbase, paddr_t *psize) +{ + /* + * Pages of statically shared memory shall be included + * in domain_tot_pages(). + */ + d->max_pages += PFN_DOWN(*psize); + + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, + pbase, psize); + +} + +/* + * Func allocate_shared_memory is supposed to be only called + * from the owner. + */ +static int __init allocate_shared_memory(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, addr_cells, size_cells, &pbase, + &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. + * It sees RAM 1:1 and we do not need to create P2M mapping for it + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + int ret = 0; + const struct dt_property *prop; + const __be32 *cells; + u32 shm_id; + u32 addr_cells, size_cells; + paddr_t gbase, pbase, psize; + + dt_for_each_child_node(node, shm_node) + { + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + if ( !dt_property_read_u32(shm_node, "xen,shm-id", &shm_id) ) + { + printk("Shared memory node does not provide \"xen,shm-id\" property.\n"); + return -ENOENT; + } + + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + if ( !prop ) + { + printk("Shared memory node does not provide \"xen,shared-mem\" property.\n"); + return -ENOENT; + } + cells = (const __be32 *)prop->value; + /* xen,shared-mem = ; */ + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); + gbase = dt_read_number(cells, addr_cells); + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * Per static shared memory region could be shared between multiple + * domains. + * In case re-allocating the same shared memory region, we check + * if it is already allocated to the default owner dom_io before + * the actual allocation. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* Allocate statically shared pages to the default owner dom_io. */ + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3149,6 +3274,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index 8d2c2a9897..0c41ecb197 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -777,8 +777,22 @@ void __init setup_system_domains(void) /* * Initialise our DOMID_IO domain. - * This domain owns I/O pages that are within the range of the page_info - * array. Mappings occur at the priv of the caller. + * DOMID_IO is used for mapping memory and MMIO regions when no explicit + * Domain need to be specified. + * + * For instance, DOMID_IO is the owner of memory pre-shared among + * multiple domains at boot time, when no explicit owner is specified. + * + * Also, DOMID_IO is used to restrict page-table updates to mapping I/O + * memory. Although no Foreign Domain need to be specified to map I/O + * pages, DOMID_IO is useful to ensure that no mappings to the OS's own + * heap are accidentally installed. (e.g., in Linux this could cause + * havoc as reference counts aren't adjusted on the I/O-mapping code + * path). This only makes sense as HYPERVISOR_mmu_update()'s and + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument. + * For HYPERVISOR_mmu_update() context it can be specified by any + * calling domain, otherwise it's only permitted if the caller is + * privileged. * Quarantined PCI devices will be associated with this domain. */ dom_io = domain_create(DOMID_IO, NULL, 0); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322646.544048 (Exim 4.92) (envelope-from ) id 1nmsLf-0007Py-CC; Fri, 06 May 2022 07:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322646.544048; Fri, 06 May 2022 07:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLf-0007Pn-7m; Fri, 06 May 2022 07:25:59 +0000 Received: by outflank-mailman (input) for mailman id 322646; Fri, 06 May 2022 07:25:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLd-0007P7-E9 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:25:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c3096221-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:25:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E184714BF; Fri, 6 May 2022 00:25:52 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5EF3B3FA27; Fri, 6 May 2022 00:25:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3096221-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 1/9] xen/arm: introduce static shared memory Date: Fri, 6 May 2022 15:24:54 +0800 Message-Id: <20220506072502.2177828-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch serie introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 120 ++++++++++++++++++++++++++ xen/arch/arm/Kconfig | 6 ++ xen/arch/arm/bootfdt.c | 68 +++++++++++++++ xen/arch/arm/include/asm/setup.h | 3 + 4 files changed, 197 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index a94125394e..e63ce171fc 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -355,3 +355,123 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An u8 value represents the unique identifier of the shared memory region. + The maximum identifier shall be "xen,shm-id = <0xff>". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. The number of cells + for the host address (and size) is the same as the guest pseudo-physical + address and they are inherited from the parent node. + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + "dom_shared", a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as 0x0, host physical +address starting at 0x10000000 of 256MB will be reserved to be shared between +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest physical address +space, and at 0x50000000 in DomU1 guest physical address space. Dom0 is +explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as 0x1, host physical +address starting at 0x50000000 of 512MB will be reserved to be shared between +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical +address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 +and DomU2 are both the borrower domain, the owner domain is the default owner +domain dom_shared. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..5ee9921f56 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -106,6 +106,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index e318ef9603..9bd08776a7 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -363,6 +363,70 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + u32 address_cells, u32 size_cells) +{ + const struct fdt_property *prop; + const __be32 *cell; + paddr_t paddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned long i; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + prop = fdt_get_property(fdt, node, "xen,shared-mem", NULL); + if ( !prop ) + return -ENOENT; + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * A static shared memory region could be shared between multiple + * domains. + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + break; + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of domains, which later may be used to + * calculate the number of the reference count. + */ + mem->bank[i].nr_shm_domain++; + + return 0; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -383,6 +447,10 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); +#ifdef CONFIG_STATIC_SHM + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); +#endif if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 7a1e1d6798..38e02ced36 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -27,6 +27,9 @@ struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + unsigned long nr_shm_domain; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322648.544070 (Exim 4.92) (envelope-from ) id 1nmsLi-0007yU-Ue; Fri, 06 May 2022 07:26:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322648.544070; Fri, 06 May 2022 07:26:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLi-0007xu-Qm; Fri, 06 May 2022 07:26:02 +0000 Received: by outflank-mailman (input) for mailman id 322648; Fri, 06 May 2022 07:26:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLi-0007P7-8H for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c78a1812-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:26:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D0E41063; Fri, 6 May 2022 00:26:00 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 89F2B3FA27; Fri, 6 May 2022 00:25:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c78a1812-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 3/9] xen/arm: allocate static shared memory to a specific owner domain Date: Fri, 6 May 2022 15:24:56 +0800 Message-Id: <20220506072502.2177828-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 55 +++++++++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 12 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index e97bb6eeba..f43378227a 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -798,9 +798,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, */ static int __init allocate_shared_memory(struct domain *d, u32 addr_cells, u32 size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -813,10 +815,20 @@ static int __init allocate_shared_memory(struct domain *d, /* * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. - * It sees RAM 1:1 and we do not need to create P2M mapping for it + * It sees RAM 1:1 and we do not need to create P2M mapping for it. */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR + "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -829,6 +841,8 @@ static int __init process_shm(struct domain *d, u32 shm_id; u32 addr_cells, size_cells; paddr_t gbase, pbase, psize; + const char *role_str; + bool owner_dom_io = true; dt_for_each_child_node(node, shm_node) { @@ -855,19 +869,36 @@ static int __init process_shm(struct domain *d, ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); gbase = dt_read_number(cells, addr_cells); - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * Per static shared memory region could be shared between multiple * domains. - * In case re-allocating the same shared memory region, we check - * if it is already allocated to the default owner dom_io before - * the actual allocation. + * So when owner domain is the default dom_io, in case re-allocating + * the same shared memory region, we check if it is already allocated + * to the default owner dom_io before the actual allocation. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { - /* Allocate statically shared pages to the default owner dom_io. */ - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + struct domain *od = d; + paddr_t o_gbase = gbase; + + if ( owner_dom_io ) + { + od = dom_io; + /* For dom_io, GFN is always equal to PFN. */ + o_gbase = pbase; + } + + /* Allocate statically shared pages to the owner domain. */ + ret = allocate_shared_memory(od, addr_cells, size_cells, + pbase, psize, o_gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322645.544037 (Exim 4.92) (envelope-from ) id 1nmsLZ-00079W-UN; Fri, 06 May 2022 07:25:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322645.544037; Fri, 06 May 2022 07:25:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLZ-00079P-RW; Fri, 06 May 2022 07:25:53 +0000 Received: by outflank-mailman (input) for mailman id 322645; Fri, 06 May 2022 07:25:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLZ-00078X-4R for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:25:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id c1484b5a-cd0d-11ec-a406-831a346695d4; Fri, 06 May 2022 09:25:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA97B1063; Fri, 6 May 2022 00:25:49 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3C8FE3FA27; Fri, 6 May 2022 00:25:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1484b5a-cd0d-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v2 0/9] static shared memory on dom0less system Date: Fri, 6 May 2022 15:24:53 +0800 Message-Id: <20220506072502.2177828-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (9): xen/arm: introduce static shared memory xen/arm: allocate static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: add P2M type parameter in guest_physmap_add_pages xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 docs/misc/arm/device-tree/booting.txt | 120 ++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 68 +++++ xen/arch/arm/domain_build.c | 397 +++++++++++++++++++++++++- xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/p2m.h | 5 +- xen/arch/arm/include/asm/setup.h | 4 + xen/arch/arm/mm.c | 36 ++- xen/common/domain.c | 18 +- 10 files changed, 643 insertions(+), 16 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322649.544081 (Exim 4.92) (envelope-from ) id 1nmsLm-0008KI-7b; Fri, 06 May 2022 07:26:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322649.544081; Fri, 06 May 2022 07:26:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLm-0008K7-4S; Fri, 06 May 2022 07:26:06 +0000 Received: by outflank-mailman (input) for mailman id 322649; Fri, 06 May 2022 07:26:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLl-0007P7-8u for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c97ddbd2-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:26:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB3E51063; Fri, 6 May 2022 00:26:03 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D8BBA3FA27; Fri, 6 May 2022 00:26:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c97ddbd2-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr Date: Fri, 6 May 2022 15:24:57 +0800 Message-Id: <20220506072502.2177828-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 36 +++++++++++++++++++++++++---------- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -347,6 +347,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4906..e565979f3c 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; @@ -1545,13 +1546,14 @@ struct domain *page_get_owner_and_reference(struct page_info *page) do { x = y; /* + * Consider the minimum case(nr = 1): * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1559,36 +1561,50 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT(((y - nr) & PGC_count_mask) >= 0); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); if ( unlikely((nx & PGC_count_mask) == 0) ) - { free_domheap_page(page); - } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) { - const struct domain *owner = page_get_owner_and_reference(page); + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) +{ + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322650.544092 (Exim 4.92) (envelope-from ) id 1nmsLq-0000K9-La; Fri, 06 May 2022 07:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322650.544092; Fri, 06 May 2022 07:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLq-0000Jx-I8; Fri, 06 May 2022 07:26:10 +0000 Received: by outflank-mailman (input) for mailman id 322650; Fri, 06 May 2022 07:26:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLo-0007P7-KV for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id cb80e8d5-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:26:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0219A1063; Fri, 6 May 2022 00:26:07 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 30C683FA27; Fri, 6 May 2022 00:26:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb80e8d5-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Fri, 6 May 2022 15:24:58 +0800 Message-Id: <20220506072502.2177828-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f43378227a..b3ba0c501d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -792,6 +792,34 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, } +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned long bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( pbase == bank_start && psize == bank_size ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + if ( d == dom_io ) + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain; + else + /* Exclude the owner domain itself. */ + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain - 1; + + return 0; +} + /* * Func allocate_shared_memory is supposed to be only called * from the owner. @@ -803,6 +831,8 @@ static int __init allocate_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -817,6 +847,7 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it. */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); @@ -828,6 +859,37 @@ static int __init allocate_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrow domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of let borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + dprintk(XENLOG_ERR, + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322656.544103 (Exim 4.92) (envelope-from ) id 1nmsLw-0000yF-0p; Fri, 06 May 2022 07:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322656.544103; Fri, 06 May 2022 07:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLv-0000xz-Qd; Fri, 06 May 2022 07:26:15 +0000 Received: by outflank-mailman (input) for mailman id 322656; Fri, 06 May 2022 07:26:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLt-00078X-PQ for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cd75e8c0-cd0d-11ec-a406-831a346695d4; Fri, 06 May 2022 09:26:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E7161063; Fri, 6 May 2022 00:26:10 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7BDE93FA27; Fri, 6 May 2022 00:26:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd75e8c0-cd0d-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages Date: Fri, 6 May 2022 15:24:59 +0800 Message-Id: <20220506072502.2177828-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to cover the scenario where users intend to set up guest p2m foreign mapping with nr_pages, this commit adds a new P2M type parameter in guest_physmap_add_pages. Signed-off-by: Penny Zheng --- v2 change: - no change --- xen/arch/arm/domain_build.c | 5 +++-- xen/arch/arm/include/asm/p2m.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b3ba0c501d..089b9e99fc 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -507,7 +507,7 @@ static bool __init append_static_memory_to_bank(struct domain *d, else sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); - res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages, p2m_ram_rw); if ( res ) { dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); @@ -850,7 +850,8 @@ static int __init allocate_shared_memory(struct domain *d, nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, nr_pages, + p2m_ram_rw); if ( ret ) { printk(XENLOG_ERR diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 8cce459b67..58590145b0 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -317,9 +317,10 @@ guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, static inline int guest_physmap_add_pages(struct domain *d, gfn_t gfn, mfn_t mfn, - unsigned int nr_pages) + unsigned int nr_pages, + p2m_type_t t) { - return p2m_insert_mapping(d, gfn, nr_pages, mfn, p2m_ram_rw); + return p2m_insert_mapping(d, gfn, nr_pages, mfn, t); } mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:27:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:27:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322668.544114 (Exim 4.92) (envelope-from ) id 1nmsMh-0002b6-AK; Fri, 06 May 2022 07:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322668.544114; Fri, 06 May 2022 07:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsMh-0002az-68; Fri, 06 May 2022 07:27:03 +0000 Received: by outflank-mailman (input) for mailman id 322668; Fri, 06 May 2022 07:27:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLz-00078X-QD for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cf6aa5d6-cd0d-11ec-a406-831a346695d4; Fri, 06 May 2022 09:26:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A3E7C1063; Fri, 6 May 2022 00:26:13 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C7FB53FA27; Fri, 6 May 2022 00:26:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf6aa5d6-cd0d-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 7/9] xen/arm: set up shared memory foreign mapping for borrower domain Date: Fri, 6 May 2022 15:25:00 +0800 Message-Id: <20220506072502.2177828-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 089b9e99fc..8d299a3616 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -965,6 +965,16 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = guest_physmap_add_pages(d, _gfn(PFN_UP(gbase)), + _mfn(PFN_UP(pbase)), PFN_DOWN(psize), + p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:27:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322678.544125 (Exim 4.92) (envelope-from ) id 1nmsMo-00030V-JC; Fri, 06 May 2022 07:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322678.544125; Fri, 06 May 2022 07:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsMo-00030O-El; Fri, 06 May 2022 07:27:10 +0000 Received: by outflank-mailman (input) for mailman id 322678; Fri, 06 May 2022 07:27:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsM4-00078X-Qy for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d3333901-cd0d-11ec-a406-831a346695d4; Fri, 06 May 2022 09:26:20 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04C201063; Fri, 6 May 2022 00:26:20 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 765BD3FA27; Fri, 6 May 2022 00:26:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3333901-cd0d-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 9/9] xen/arm: enable statically shared memory on Dom0 Date: Fri, 6 May 2022 15:25:02 +0800 Message-Id: <20220506072502.2177828-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f08606d2c0..9da0a0c88b 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2628,6 +2628,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + d->arch.shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3639,6 +3644,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3673,6 +3681,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:27:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322694.544136 (Exim 4.92) (envelope-from ) id 1nmsN8-0003oJ-QH; Fri, 06 May 2022 07:27:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322694.544136; Fri, 06 May 2022 07:27:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsN8-0003oC-NN; Fri, 06 May 2022 07:27:30 +0000 Received: by outflank-mailman (input) for mailman id 322694; Fri, 06 May 2022 07:27:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsLy-0007P7-JD for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:26:18 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d157c0c9-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:26:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0FB61063; Fri, 6 May 2022 00:26:16 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 298193FA27; Fri, 6 May 2022 00:26:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d157c0c9-cd0d-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 8/9] xen/arm: create shared memory nodes in guest device tree Date: Fri, 6 May 2022 15:25:01 +0800 Message-Id: <20220506072502.2177828-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506072502.2177828-1-Penny.Zheng@arm.com> References: <20220506072502.2177828-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. Signed-off-by: Penny Zheng --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 144 ++++++++++++++++++++++++++++++ xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/include/asm/setup.h | 1 + 3 files changed, 146 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 8d299a3616..f08606d2c0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -894,6 +894,26 @@ static int __init allocate_shared_memory(struct domain *d, return ret; } +static int __init append_shm_bank_to_domain(struct domain *d, + paddr_t start, paddr_t size, + u32 shm_id) +{ + /* Allocate memory at first insertion. */ + if ( d->arch.shm_mem == NULL ) + { + d->arch.shm_mem = xzalloc(struct meminfo); + if ( d->arch.shm_mem == NULL ) + return -ENOMEM; + } + + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].start = start; + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].size = size; + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].shm_id = shm_id; + d->arch.shm_mem->nr_banks++; + + return 0; +} + static int __init process_shm(struct domain *d, const struct dt_device_node *node) { @@ -975,6 +995,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(d, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1305,6 +1333,117 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + unsigned long i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + uint8_t shm_id = mem->bank[i].shm_id; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + __be32 reg[4]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_cell(fdt, "xen,id", shm_id); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + char resvbuf[16] = "reserved-memory"; + + if ( mem == NULL ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3041,6 +3180,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + d->arch.shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index ed63c2b6f9..d0d1e12cfe 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -104,6 +104,7 @@ struct arch_domain #endif bool directmap; + struct meminfo *shm_mem; } __cacheline_aligned; struct arch_vcpu diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 38e02ced36..b5909acf68 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -29,6 +29,7 @@ struct membank { bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ #ifdef CONFIG_STATIC_SHM unsigned long nr_shm_domain; + uint8_t shm_id ; /* ID identifier of a static shared memory bank. */ #endif }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 07:31:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322697.544147 (Exim 4.92) (envelope-from ) id 1nmsQq-0005XN-AA; Fri, 06 May 2022 07:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322697.544147; Fri, 06 May 2022 07:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsQq-0005XG-7L; Fri, 06 May 2022 07:31:20 +0000 Received: by outflank-mailman (input) for mailman id 322697; Fri, 06 May 2022 07:31:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsQo-0005X6-PI; Fri, 06 May 2022 07:31:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsQo-0000SQ-M2; Fri, 06 May 2022 07:31:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsQo-0001Sh-3s; Fri, 06 May 2022 07:31:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmsQo-00024J-3P; Fri, 06 May 2022 07:31:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wxdGzWAKqkmPaAN5EaK0fj3DojNAR5UU97eiZ79qZEI=; b=wn6n7knUoWVEFIFnS92vcZXebK JGecoObYIFhNLqLNJdWAFQkTuGLLFREziYZ38vC1EgI6c157dsJ5OO5vIg8NHm4iFmzgwEcCbgPQL o4iHuvSdqoCHM+OjVvlQc9n3AkgYI5HcJ7l3/H7hfLTHjGo78C7sQmLEPS02EjTevd6Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170174: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=826527c9db11f34ca500033e131633f831da2ac2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 07:31:18 +0000 flight 170174 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170174/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 826527c9db11f34ca500033e131633f831da2ac2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 836 attempts Testing same since 170171 2022-05-06 05:41:36 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5967 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 07:37:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322727.544158 (Exim 4.92) (envelope-from ) id 1nmsWV-0006KY-3g; Fri, 06 May 2022 07:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322727.544158; Fri, 06 May 2022 07:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsWV-0006KR-0e; Fri, 06 May 2022 07:37:11 +0000 Received: by outflank-mailman (input) for mailman id 322727; Fri, 06 May 2022 07:37:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsMt-0007P7-DE for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:27:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id f3789dcf-cd0d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:27:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 159B61063; Fri, 6 May 2022 00:27:14 -0700 (PDT) Received: from [10.57.2.250] (unknown [10.57.2.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9C883FA27; Fri, 6 May 2022 00:27:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3789dcf-cd0d-11ec-8fc4-03012f2f19d4 Message-ID: <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> Date: Fri, 6 May 2022 09:27:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-2-michal.orzel@arm.com> <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> From: Michal Orzel In-Reply-To: <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05.05.2022 13:13, Jan Beulich wrote: > On 05.05.2022 12:36, Michal Orzel wrote: >> --- a/xen/arch/arm/include/asm/grant_table.h >> +++ b/xen/arch/arm/include/asm/grant_table.h >> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >> #endif >> } >> >> +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, >> + struct domain *rd) >> +{ >> + return false; >> +} >> + >> +static inline bool gnttab_release_host_mappings(struct domain *d) >> +{ >> + return true; >> +} > > Looking at x86 I think all three instances of struct domain * want to > be const struct domain *. Then > Reviewed-by: Jan Beulich > > Jan > Thanks. I think we should mark all parameters as const meaning also const bool ro. Cheers, Michal From xen-devel-bounces@lists.xenproject.org Fri May 06 07:42:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 07:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322750.544169 (Exim 4.92) (envelope-from ) id 1nmsb9-0007lb-Ms; Fri, 06 May 2022 07:41:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322750.544169; Fri, 06 May 2022 07:41:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsb9-0007lU-JQ; Fri, 06 May 2022 07:41:59 +0000 Received: by outflank-mailman (input) for mailman id 322750; Fri, 06 May 2022 07:41:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmsb8-0007lO-Jg for xen-devel@lists.xenproject.org; Fri, 06 May 2022 07:41:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061d.outbound.protection.outlook.com [2a01:111:f400:fe0c::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01648439-cd10-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 09:41:57 +0200 (CEST) Received: from DB6P195CA0012.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::22) by PA4PR08MB7411.eurprd08.prod.outlook.com (2603:10a6:102:2a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Fri, 6 May 2022 07:41:54 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::8a) by DB6P195CA0012.outlook.office365.com (2603:10a6:4:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Fri, 6 May 2022 07:41:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 07:41:54 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Fri, 06 May 2022 07:41:54 +0000 Received: from 7e7175c2d624.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E9657C8-E63B-409A-B1C1-1778F4605172.1; Fri, 06 May 2022 07:41:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7e7175c2d624.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 07:41:48 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by DB9PR08MB7470.eurprd08.prod.outlook.com (2603:10a6:10:36e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 6 May 2022 07:41:46 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Fri, 6 May 2022 07:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01648439-cd10-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YTz7zwhNwAgODmBY1hDe0HjKqhSxEQxOq+sCu/ff3LjIaz3z4mU1fVao9tCRB8vTDCReO4x17lXoeUrp3CoZIatanTwhdpC83iDiaTZiiSC3LgwtJgvkiwr5REKjcazsXIhIMjmB24AbJQ1SsPWleRqcaEvfZswWKGhRSSaeIEwSbO0TOkI/y2NEqj2YT50jUA4MZswfdgBLl+585HTe6a7h2ys2YVr0xusdVxYxd70CM9QicBr4Ahgzb+yVLThRsIDRox7vFxLuOdyrSZn4/1jOfRzw7+VmcRkW6+QLknG54dM55vFb7yi59jWCTa0pvSWc3JyphA5hmBYqgg+gkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=fxwVZyw1q6wLtDMIvz68lmVsw6U2dBmIljQatK/pLTJjkRIDNOgF47Zvu52h0c4CPs6l3z+5oEIsR4YiPYgplTnNd4zxSmo5SIzr4ZXes+nG9TdHqkPzevt2dW2uJ2QsOtpmzPSErouMx8eI6RyODaJzQ+LfAlingsBjbVu+YGxO3tKXiTQnH0p5M32p0GalpLNEv2otAaZDPEi/1iJYschCLQJFjJk6lTO3FKeNpXY959RqsaXpBOJbl1eBAXfABYorxkxRxzx4zijgx9lei/yxHg7txZQx4y4+ayk6OoFe06KazHC7F8HxVoHTlcOkvewalxFKiDTy7EOJra379g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=nKovzNh0phjQEUGvYK/ODVUfdUMBkUCDoGNXxLBwLCmd8NlOYGcbhNr+OmcMVXLdDU+tYnec9wProaMUEH8H2HjZNZzkFaI/7rfk85Lp9CozT5UzB43dLVrFMcBZgRYU7WLN0MB10v2/+sJeVNhXD6EkGGlJh/WT4IS9M6F5ywY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqWKfLO4cMCtHEscYi5KcqCV3VzrAJ+WXSfMJd+Tq3BIsuDGfIII/NxZYmTerFLEoAaDhWHYrLX9+2oCUsZnRLjVD813W4UAU17UNitfYB0wU91JQ2xqaTDqT/1qFha820GpM+KM6JDFY2lWE0+kdBCI+N9ua8+yEBDe7Gvr1/oYaOTLlgttIWn1y86H7uFk4ukWDPFJZliGKDx9P/thPgC+73Bn8R/exyvSbVo1DovITbuAp6n4jw2w6D+LtFhQI1sSrAyrERoig3i+QWhzkaJ8aFhnH8qwAqeYJihufuFzvmWrtyLfe/Fqdpl9GCsghnsICZZF3UUgnQPc95vBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=QW+azcNbZ9mrFNoYOp1gsyAxYpE4GsPb3B6QJrngkbspKY4J7yYeElpph9mAL2x8WrKplA+K7zG5dUdw8MS7b06pWlQuM6PRxTb4UJjlrw607C7WmF6+TddIefCTOKkHemhRYeFbOrHMvg5sUm2UaxDC5wPBRJgRVenocWC1z9CHQ/p/fZtYxSSNidCQLLqax5HOIT4qb8MlRbvMbt2vry7Po+urInZ6FGZj6Ho4PVprhxZTDYzAY2v50yvTZ/8MabVnq+ygqkTkvUkvBToEPa8E/opWrQ06u0dx16fluoWWsAm4qZrxr8EkQsVF15zWvxYikKQvaf3QqCkkd7kk+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/fwamjDyhMY1+r6Zvyn14EhElwtqTNh011wO5XqgNw=; b=nKovzNh0phjQEUGvYK/ODVUfdUMBkUCDoGNXxLBwLCmd8NlOYGcbhNr+OmcMVXLdDU+tYnec9wProaMUEH8H2HjZNZzkFaI/7rfk85Lp9CozT5UzB43dLVrFMcBZgRYU7WLN0MB10v2/+sJeVNhXD6EkGGlJh/WT4IS9M6F5ywY= From: Penny Zheng To: Jan Beulich , "julien@xen.org" CC: Wei Chen , Henry Wang , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUIAAL5+AgAAR4BCAABRbgIAA0kVwgAA3dYCAABUWYA== Date: Fri, 6 May 2022 07:41:45 +0000 Message-ID: References: <20220427092743.925563-1-Penny.Zheng@arm.com> <20220427092743.925563-7-Penny.Zheng@arm.com> <03430522-16cb-5ad3-272a-ca0cee79c7e3@suse.com> <6ee0b5b6-e099-c17f-48df-58ba1deb4066@suse.com> <306532fc-939d-efdf-047c-7b8556d40738@suse.com> <6eb6f0d0-ba46-9d4f-28f1-9612bd876e9c@suse.com> In-Reply-To: <6eb6f0d0-ba46-9d4f-28f1-9612bd876e9c@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 67006881CA8C734481BC2D219B9FE7B1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4cd6f9f4-46e6-4647-6d96-08da2f33e438 x-ms-traffictypediagnostic: DB9PR08MB7470:EE_|DBAEUR03FT004:EE_|PA4PR08MB7411:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VbGP/FKtvNgIvzyxtDq34V+Hv0Jnl8NWbudUkFUweSDGkrRUK9y84rSYJjoArEVF3ctjP22FOFpwkO2TRwGdaVu95L7dxC8Z5s3swPrj/hFRMybKjvhIP/R71IbtzKLUFwPwE2ycMRRN3rXBLngl3iN/2x7bROz6M62VWnQENGotA382cg835xnFWwlNyL1F5eZ0aCN9MCSravw+KkxbNWaqP7rn+qaTQXYfg7huxsBIcxsfIye1w/TM1732oiRbp6dwkzphH4OW2LY4voOXFijz5AFUXwCRNSk3WV+Zsu9kD9e2NthAzJzlCuRswPLJKlnfv+kDRenpP6Z422f82zI4I71O49XefpUl0oID6PYOszoO7xZ9b2Zv/LBgPqvEnVtaZOPXw1Ji0ziqGmcV1evxnam9cnAFAS9T40Tk9HfJRwWfyltWg+VNFCRG7x2pr0kYtLDgSaeJ1fUtDxJBO/zHVDZ4jt9vjwjyza1u2EnUfU2Xj3qP7KP4042ZLNugHE7plpPD0K1JDhIlALhxF9Yk2xYAD3sZWitaOtyQ4AJsLdsAdFLukRj0bkbTze84fUWqqzYFj8OWMkLrPc98CGW295ftt/IPLafzFa67ix4JvRCZudJHWmakYylnxOZypdLapkZ8UGtvEt1EurY6rvhbzXdbEeGUbOqxnT+PEW/xz8nOVgE1HzZdbY2r+czWIuaDl1Azb6zuGjO8yC5pI9Bja4kJwqvx9EBvf71nWeVuG2PBWfcXdtsHnNEVOBkzQBZWswWeNvcgQBo+LUjCVCGEW7Tg3iJMpAVP8QOko8pvFHz94sLX5stywRT1tifo X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(55016003)(508600001)(33656002)(6506007)(38070700005)(186003)(9686003)(5660300002)(122000001)(26005)(86362001)(83380400001)(64756008)(38100700002)(71200400001)(52536014)(8936002)(7696005)(2906002)(76116006)(54906003)(110136005)(66476007)(66446008)(316002)(8676002)(4326008)(66556008)(66946007)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7470 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b9ecbdc5-3381-4752-a6eb-08da2f33deeb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hsMy/UaKq8K+9sF8u/g6R/zmybAS1ZqIRvICslZ+DYMaf5+9/3NATWV5g9qOCJWAyYMreow0qB/HpG8XhP0qLuOhcjjX9XTEI15CyOaX5vlkJXpVgoAM1mNRcYrwVL0uckOqtdiR9Vf53/cAtHvGD2aijsUlzfweBpki2bw+MRcyPwW48OilHCuISkB/xBD2Qt6eeFCLusHk4eOJoIJ30hJK5bM7npdv7PkysynVzLL90PC4bL62PFJTbk2+1TnOybWXxTqCY4gAN1HGuGiFq4x35/yHk83ecGGolYewNHnxUmKNp4DIutMJuywJOGrqxgjQCtWrnpJIfcI35IJWnwLLT8aOAILd/YGI5tbBVDHL8RyfUO+9RWklTLppY7iUktsvVZF10qXnO8fwOel6vcFQ7iIQnTfWwL2XwhSgFcGDqNJdrJGk9pIvxV0Z0sMw/QNSLWOVv8NJXdtm/mcjuwLPkMWEk7RJiBvwQ+dajx9XsuPcMcasWznUYLu97l09DRLqr5ek3zc6ZKTYHScbIbMZczqNSRRbqTBtnKIi6oC+ogMpAcFOsiz7g1s7K5Z9VLlrq1Df8g3I1nmGqs518xBG8QVfaMsjWV8q3osR2c2w9cyi62TVUWy+nI5X3YEU08TOrj3F+4z3aGwXP2Uat832PhFLou9gh3VDTC5k0z99Tv/lCOjtoH0Gury1qZoYpWOOSEqqdk9bGOLMXZdPmnIzyqJLKRC4TO0yDzXjd1A2ZnQa4Ds8mHvrvySndWmH9ei0yEqgKcvpuclM0OeexQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(336012)(9686003)(186003)(53546011)(6506007)(47076005)(26005)(33656002)(7696005)(356005)(81166007)(86362001)(40460700003)(55016003)(110136005)(83380400001)(36860700001)(82310400005)(5660300002)(54906003)(508600001)(316002)(70586007)(70206006)(8676002)(4326008)(52536014)(8936002)(2906002)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 07:41:54.5087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cd6f9f4-46e6-4647-6d96-08da2f33e438 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7411 SGkgamFuIGFuZCBqdWxpZW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IEZyaWRheSwgTWF5IDYs IDIwMjIgMjoxNCBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+ IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdA YXJtLmNvbT47DQo+IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBH ZW9yZ2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJu ZWwub3JnPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA2LzZdIHhlbjogcmV0cmlldmUgcmVz ZXJ2ZWQgcGFnZXMgb24gcG9wdWxhdGVfcGh5c21hcA0KPiANCj4gT24gMDYuMDUuMjAyMiAwNDo1 OSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgamFuDQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t Pg0KPiA+PiBTZW50OiBUaHVyc2RheSwgTWF5IDUsIDIwMjIgMTA6MjMgUE0NCj4gPj4gVG86IFBl bm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiA+PiBDYzogV2VpIENoZW4gPFdlaS5D aGVuQGFybS5jb20+OyBIZW5yeSBXYW5nDQo+IDxIZW5yeS5XYW5nQGFybS5jb20+Ow0KPiA+PiBB bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcA0K PiA+PiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz47IFN0ZWZhbm8NCj4gPj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47 IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tDQo+ID4+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnDQo+ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgNi82XSB4ZW46IHJldHJpZXZlIHJlc2Vy dmVkIHBhZ2VzIG9uDQo+ID4+IHBvcHVsYXRlX3BoeXNtYXANCj4gPj4NCj4gPj4gT24gMDUuMDUu MjAyMiAxNTo0NCwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiBJIG1pc3VuZGVyc3RhbmQgd2hh dCB5b3Ugc3VnZ2VzdGVkIGhlcmUsIEkgdGhvdWdodCB5b3Ugd2VyZQ0KPiA+Pj4gc3VnZ2VzdGlu ZyBhIHdheSBvZiBzdHViIGZ1bmN0aW9uIHdoaWNoIGNvdWxkIGJyaW5nIHNvbWUgb3B0aW1pemF0 aW9uLg0KPiA+Pj4gVGhlIHJlYXNvbiBJIGludHJvZHVjZWQgZnJlZV9zdGF0aWNtZW1fcGFnZXMg YW5kDQo+ID4+PiBhY3F1aXJlX3Jlc2VydmVkX3BhZ2UgaGVyZSBpcyB0aGF0IHdlIG5vdyB1c2Vk IHRoZW0gaW4gY29tbW9uIGNvZGUsDQo+ID4+PiBhbmQgaWYgdGhleSBhcmUgbm90IGRlZmluZWQo dXNpbmcgc3R1Yikgb24gIUNPTkZJR19TVEFUSUNfTUVNT1JZLCB3ZQ0KPiA+Pj4gd2lsbCBoYXZl ICIgaGlkZGVuDQo+ID4+IHN5bWJvbCBgeHh4JyBpc24ndCBkZWZpbmVkICIgY29tcGlsYXRpb24g ZXJyb3IuDQo+ID4+DQo+ID4+IFRoaXMgaXMgd2hhdCBJJ3ZlIGFza2VkIGZvciBjbGFyaWZpY2F0 aW9uIGFib3V0OiBJZiBzdWNoIGVycm9ycw0KPiA+PiBzdXJmYWNlLCBJJ2QgbGlrZSB0byB1bmRl cnN0YW5kIHdoeSB0aGUgcmVzcGVjdGl2ZSBjYWxsIHNpdGVzIGFyZW4ndCBEQ0UtZWQgYnkNCj4g dGhlIGNvbXBpbGVyLg0KPiA+Pg0KPiA+DQo+ID4gQmVjYXVzZSBib3RoIGRlZmluaXRpb24gb2Yg UEdDX3Jlc2VydmVkIGFuZA0KPiA+IGlzX2RvbWFpbl91c2luZ19zdGF0aWNfbWVtb3J5IGFyZSBu b3QgZ3VhcmRlZCBieQ0KPiBDT05GSUdfU1RBVElDX01FTU9SWSBpbiB0aGUgZmlyc3QgcGxhY2Ug aW4gYXJtLXNwZWNpZmljIGZpbGUuDQo+IA0KPiBTbyBwZXJoYXBzIHRoYXQncyB3aGF0IHdhbnRz IGNoYW5naW5nIChhdCBsZWFzdCBmb3IgUEdDX3Jlc2VydmVkKT8NCj4gDQoNCkhtbW0sIEkgcmVt ZW1iZXJlZCB0aGF0IHdoZW4gSSBmaXJzdGx5IGludHJvZHVjZWQgUEdDX3Jlc2VydmVkIHRocm91 Z2gNCiJEb21haW4gb24gc3RhdGljIGFsbG9jYXRpb24iLCBKdWxpZW4gY29tbWVudGVkIHRoYXQg aGUgbWF5IGxpa2UgaXQgdG8gYmUNCnVzZWQgZm9yIG90aGVyIHB1cnBvc2UsIG5vdCBvbmx5IHN0 YXRpYyBtZW1vcnkuIEFuZCBvbmUgZXhhbXBsZSBpcyByZXNlcnZlZA0KbWVtb3J5IHdoZW4gTGl2 ZSBVcGRhdGluZy4oaHR0cHM6Ly93d3cubWFpbC1hcmNoaXZlLmNvbS94ZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcvbXNnOTc4MjkuaHRtbA0KKQ0KDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 06 08:32:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 08:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322768.544179 (Exim 4.92) (envelope-from ) id 1nmtNX-0005Ah-Qy; Fri, 06 May 2022 08:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322768.544179; Fri, 06 May 2022 08:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtNX-0005Aa-OH; Fri, 06 May 2022 08:31:59 +0000 Received: by outflank-mailman (input) for mailman id 322768; Fri, 06 May 2022 08:31:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtNW-0005AQ-9S; Fri, 06 May 2022 08:31:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtNW-00021i-7D; Fri, 06 May 2022 08:31:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtNV-0004OD-Oz; Fri, 06 May 2022 08:31:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmtNV-0005Qb-OW; Fri, 06 May 2022 08:31:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YyElcxeQvYxA4ZCdnKE9X8+gdC0iFVWqsiIrAfvnydw=; b=sa6O5iU9kyRtaBLl9XxkfQ5EL7 kNNBMWn9htTFs6uhzEqS0jIbKr6nIUqATJgZHzJfxhUS23fKwGPLrWQ0zqB5PzUv+wgl9bE+Y+a74 rv6NY3KHWoT6iLVw1t8JNueRQUy31bfaQzWUw+dyppWrM8ewJpXzuREZeqnYSA6VN0Cg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170175: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=826527c9db11f34ca500033e131633f831da2ac2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 08:31:57 +0000 flight 170175 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170175/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 826527c9db11f34ca500033e131633f831da2ac2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 837 attempts Testing same since 170171 2022-05-06 05:41:36 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5967 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 08:38:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 08:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322776.544191 (Exim 4.92) (envelope-from ) id 1nmtU8-0005t9-KD; Fri, 06 May 2022 08:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322776.544191; Fri, 06 May 2022 08:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtU8-0005t2-Gi; Fri, 06 May 2022 08:38:48 +0000 Received: by outflank-mailman (input) for mailman id 322776; Fri, 06 May 2022 08:38:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmtU7-0005sw-8x for xen-devel@lists.xenproject.org; Fri, 06 May 2022 08:38:47 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efcabaf9-cd17-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 10:38:45 +0200 (CEST) Received: from mail-mw2nam10lp2106.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 04:38:41 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MW4PR03MB6967.namprd03.prod.outlook.com (2603:10b6:303:1a6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 08:38:38 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 08:38:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efcabaf9-cd17-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651826325; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=DVeDfpe+UVSYt2ytASu6qe8PsoXrNawj2kyO+YKxyQ0=; b=WUMLCjK7Au3je9+Hw4xInHBIKY5VMx0GoRhOic6940cuFtoII3+MvdAI IvEpZLD/drhYbVeEohZuaXbzenpzR9VJYpi3dcyskl5Xx7pwzQJCC281+ DmRjK4jreI6wkAIdeZgR8VISHzjoecGTH7mKi6ooDMspU42eC3yCIqUlP g=; X-IronPort-RemoteIP: 104.47.55.106 X-IronPort-MID: 70737645 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lCPRN6OxHh2glQvvrR3TlsFynXyQoLVcMsEvi/4bfWQNrUolhTwBm zNOXG2Gb67ZZmv2c9x2YIWypB9VvpDUzYJjGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tMw3bBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0 fEKq4SeEBcQfZLFtqMXTTpSUCtgMvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/uiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iakLGME9Tp5o4I7uGaLyVVQ4IHDc9WNUNm4ReF7t0iX8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FSiU93VTxC+5nmesXYht8F4FuQ77ESI1fDS6gPAXmwcFGcZNpohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnEb6PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:YRFYnKDVRCX0B0blHegwsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dOwEPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wk9HaIGOuZ5Dt v/Q9VVfZF1P7srhPFGdZA8qfXeMB28fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70737645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iLGZOr+YuqGW4lFSBeL21McsNG/FRHq2oeWnW/hAcOdf5atcguSNPMyFY8V6IV3t4UWNcey4tCdYQOW0pyfVPc8ERBIuc71zs8I0eE8H7Z1BQrxppLgI8TFoOkuHDIKWg6/UT1UvgrOnzCn+DhRvfwGkgIVD9EfWjU+j03P5SCaidNuru2M8wNsevOd94FOHswJlu7w011HAnPw/ZdqFKB84ugcXGSZy9ptUIDcBBiv8+5n/Rx7KaVzLYf8MCKPjGEzKzh9u4dPvBqcdJvJpJ/uYcq52JS5eW0zzZ0BJabAwb/1T10LIMeJHDoDnKR13CuZD3493HGI2Ad5lQRvvJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6nPBJArNKj75A1bY9/7rifvJdi50/wj3Om+ibh/8hCs=; b=MyWl5X4/7YjnaFT6AE2ZMzdouWPMJ9fWaEhSD67P+th0ejkQQE/oKSX+lcvG0uvNJvZr/pakB1qK7/0MbXZaiiTkjJkjdqqHyA4hd+TvJqFxqnExuxm3FP1R4FmBC6laf5dq5nKu58NHZzmVgDpxAnW64ynT2VB8AYPcdxgoZreA9oSiuX0eIjke/Ua2NI4cd6LL6Pf8JIKA1z+s/kxmKPWmF6c1VthOT/5X99pl2L+jORFeRCuQKqR5DZGsf82XmvMTFOXukkgMfAdZMHi7Xwzh9fNpwa0QAh2pXwJQKRtcPic/fOZXQmfQROl33ISbU38jYsnGHutsvwshMgOKGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6nPBJArNKj75A1bY9/7rifvJdi50/wj3Om+ibh/8hCs=; b=Y9djcEXTfgBCOnd+sklh0lqquWP2+ruzJ4Z+15bLDE5jxjKLHhVT0h1D4m4J2G2pMs8ctTXGEoB9JfDGqctC8f1YrYCkDURvT+9trgumg0kHv07ciDwKssYbpE5QkMFHY9LpI+LmVU2uvjsqKXxGs80gyniVX9tWVdLXQwTOLg8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 May 2022 10:38:33 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 12/21] IOMMU: fold flush-all hook into "flush one" Message-ID: References: <024c89df-9cf9-4d74-116d-ca8481dca90b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <024c89df-9cf9-4d74-116d-ca8481dca90b@suse.com> X-ClientProxiedBy: LO2P265CA0058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9962f22b-c4e0-4820-00bf-08da2f3bd10f X-MS-TrafficTypeDiagnostic: MW4PR03MB6967:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZiyT3QRvVu4BLPGq02nJj9WKD6K5BDQ7Fhjg3WexCElXStrAHm/zKScpSNO4sjS/s8E5UoB/k76XgCFCqYJ4zdyO+HqTXdLc8P1qaM1yVXRvmvEmoapZrtLuYj7qaXLCizHBrPFkMCqJ18E0dqKGzopGNC8i4QRfZXi1XtePwow1n3zpAsmPoIdX2B0ysS+RpARqKZ6tSoCtjPQsmIc4E/s0vXX24+lcR6rWDgmNzPyjogFeEhQw/JULOwk3w7bdezOkg73qFWZnOqs203BNV2r8LLqkNVKfuhvY1wu1UsBs9zrOkjYQJ9fo9q98V0bGEaMhjcxMbmix6JU6OjII4Hxx6VCokgvzuqeix0+ODZoNX269dlF6piaqaa1zBrl/aHLAeXp3q/d//vsRfuFwSlyJdDxDgz3N32fbLmf8Qe+cHTC7fjISdwr0B0HIR1criucXzv4y+X9FpH0K7J+oZWN+NFiX+tlnjO3HNqtO93k3sgHv0n8RFVOT+zWfGJgGei1aQVmD5mk/cjCj5XQ3f595uMS6k5hrYx/7SCyJLHOoYojShLnb9AOsgAt1oc4eQ7/xrEKQMTOSynBzNFjJV2fMHT58Qc+QC5/bEkZYcGrfdvoPjywYSJW3mD6QWK1UDjUtN9nIo9Jwv5M0wCPNcw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(6486002)(6916009)(54906003)(508600001)(6506007)(66946007)(4326008)(8936002)(8676002)(66556008)(66476007)(26005)(5660300002)(6512007)(9686003)(33716001)(6666004)(316002)(186003)(38100700002)(4744005)(86362001)(85182001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGlsOTlscnRiVzlNMmlydTJLUjJIN0RaNjkwNXVJVDEyaEdRV0NacVZ5bzZS?= =?utf-8?B?MWprQXY4dG13dWhZR1VsWUpBSTY4THRGNTdIR1R1OWlxS3hjVExpL2ZyeWVy?= =?utf-8?B?R0I3Y2pWZi9sTGZMTUgrekNQWlhYUVhpRzgrSUJDbDYvVzUzaXB5dW12VnFa?= =?utf-8?B?K2dTRGdVV1FVSi81OUYwaVRZNnE4SW8wejB6a2p5N1dhQkJpdWx4OGxkUlM5?= =?utf-8?B?QnlmUkF4Yyt4VThBczNjdWFSbm1IVEsxNEREK2tlU1Fwbm1jczVCZytBclFT?= =?utf-8?B?TWdva3FML0JXRzBxMUl1Y2FkTUVZTUJXUlE4aW14MGpDb1AxSUZ1YnBHR04z?= =?utf-8?B?Y0VuVUFWRHJzZnR2eDFpUGFUeXlFcUxlWXBnWDFKeVY4V2FlMWw2NmJzSkx0?= =?utf-8?B?NVFFWnE0WkQ1MTB6MktKQTFNY09qZmRnczFoNkUycUpVMXZEN0ovcWtPSjV3?= =?utf-8?B?R204cktrNmQ1aHc5YUtVS2JPbmlxUjBIb3F1aWp0MDRYNk9FN2g2WnZlclZM?= =?utf-8?B?Vm9ja3JQSTdNWGVqRE5KSnBZOWRDeVdsTlMwZXZNVllFaXBrZFEzRjJxVEdY?= =?utf-8?B?Y1kwTnVDWUt4dDB1V3RNT3I0cXc4WUJOQ3JUWmJ5Mnd0aW1yZEpQQmM1VnpC?= =?utf-8?B?M1lXdndCRkVqZmxnTEY3Z3E5STI1SzZKMCt1WCtEQnBxSzE1V2FiZzBNSG1x?= =?utf-8?B?QklUZ2xaZDc2dk9pT3h1d2FPandyQkI1WWlxZ3BRS1FHbDlna0x2dVRPY056?= =?utf-8?B?VG9VUUpydlUwdFUvWXR5clpOQi9TM0k1SXczamhsUkJnNi9tRm16MGFnMHpH?= =?utf-8?B?RVZkVmlhTEVlRm44NWdoWEYxRDdEdVZheVVORGdVU0dEN1BNcWwzSnB1U0Nx?= =?utf-8?B?NjRnUDJKQTdNSEMvUXpmd0E3akNmR3FiU1paN201YWx3YjJpbDBXTVlqeUVB?= =?utf-8?B?NmJqR2I1dTdCZjNadWs2VGYwdHljeVJKZ05oRnRwV3F6UGZWZFZrODZOK0JD?= =?utf-8?B?dzFZNlo2MHRUWlBlOEtNMzJ1Y2pYTXpZcWYyVW9uNUFGKzMreUZwbnhhbngw?= =?utf-8?B?dHdRL3FBQnpnem4vYkFWeE1MR21RT2d3WFFPUnFYSGFUOXoxWG5tK2lVN0o0?= =?utf-8?B?Uy84bklBeTBNbEpwZTNWbEU4NzdPZ25hYW1ZcCtpLzhrTndMT2FKdGNIQkFw?= =?utf-8?B?N3ZzaEdVLzkyaXFnN0p3RXEvTHpaQ0p4S3RnWCtQeWRuSEd6R1U2QUxVZWxq?= =?utf-8?B?cFYrR1o3VzdVY01CMS9qSjdBYUpvRmw1WHpaV3Q0OGFnRzhUenFyeEFUYTFT?= =?utf-8?B?RmM1d1drUEhUdnpzQmN0VzdBN1l2WFJBSGJZM3Uxa2l2R3JhVjZVV0tyNDJY?= =?utf-8?B?UmRVMmt5cXZRMzhiTXdyTE5pSGo5YjArb0F2eGFUZ284RkhkT1lReERGbzB4?= =?utf-8?B?cUNjd1d3U2NQQk41TldiM1BLWWYzZG5nRDF6b2FQNXBDbWppT2daVzVZeDZC?= =?utf-8?B?aGNrdXl3cERyNnlvbmU1NlBERlBwaElvdkVIVXlneEk5TzZUOFlmcDhxVUJ4?= =?utf-8?B?WEZRU0wvQS9Ib0kwNitxNkwzbjdZQzNkQnd6VUVndVNLN3JDL0FzSk92NmI4?= =?utf-8?B?OWx6eVN1OUpUYUg4YXpuNHQzaXoxcEV2Q3lIYldSVDQwckh1ckQvYmlndUlz?= =?utf-8?B?bVVIRWNzTFNnbTFycG1kVnpvTGdqQXprbm94V2szWjlmdzd1NVg5WFQ2RkI2?= =?utf-8?B?Sk1sR0ZlSHJNRUVkdHhQbUQ5TkNjWkJTRCsrU0lwQmRqZ3JETUdrMmczbEtS?= =?utf-8?B?dllXSGFhOVJubDJ0QmRuZkYvRWFIKzVybkdjdFM3RGU3eThHNjhvczdGcGNL?= =?utf-8?B?YXZBUXpCdWduV2pqSnNzdCtWWjNWMEV3d2VJcFNyVkYzNGhwcnYyM3FtVlVn?= =?utf-8?B?YVJmWWdqbjd4c2RZUTQvbnZXRnBtT1FKbXBvNmphbkhoK09TalBjbkpBbVl1?= =?utf-8?B?QS9PRi9kZ1JkVEE4Zkl3eEJpWGIzQ0JjcENrUENBQWJXTDc0cExRL0FUWmsw?= =?utf-8?B?YktvMERGZ2Y1eEI0RFhMRy81cUJPak80VGhodm93bVMxWVdYUzZjaFRrQXk2?= =?utf-8?B?WFd3NmZ5YVFHUTFzV1VrMWNaekJKU1VValdIazlFSmo3TThBYkpvQjkyQXhV?= =?utf-8?B?czBNVDZRVzE3MFNWKy93TWxWNGFaUmUvbEw5NzlYNkE5TCtaOCtJQ3YzN0g5?= =?utf-8?B?b2I2RnY4TEVSN3VOdDVNSUljVGIwWG1PZWdCQVo2T1JiRUNzZWRadnhEUytO?= =?utf-8?B?QjRKbVZ5RXJwYVRCampzQnAxdUVmSWtqeDJYSyt0NUIwOW1SdUxTY2xhZllE?= =?utf-8?Q?NJxgGascszkwqycM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9962f22b-c4e0-4820-00bf-08da2f3bd10f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 08:38:38.4593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kqQzZPTRCZMfmO23VJ7UtUeiB83WgVuqIBiD7m1xUbYMLi9hPQd8wBol+F2bv/CX4TJik6h6GGmZtozfc0VaJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6967 On Mon, Apr 25, 2022 at 10:40:06AM +0200, Jan Beulich wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f > struct domain *d, dfn_t dfn, unsigned long page_count, > unsigned int flush_flags) > { > - ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); > - ASSERT(flush_flags); > + if ( flush_flags & IOMMU_FLUSHF_all ) > + { > + dfn = INVALID_DFN; > + page_count = 0; > + } > + else > + { > + ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); > + ASSERT(flush_flags); > + } > > return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified, > page_count); In a future patch we could likely move the code in iommu_flush_iotlb into iommu_flush_iotlb_pages, seeing as iommu_flush_iotlb_pages is the only caller of iommu_flush_iotlb. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 06 09:18:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:18:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322785.544201 (Exim 4.92) (envelope-from ) id 1nmu6N-0001sk-QK; Fri, 06 May 2022 09:18:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322785.544201; Fri, 06 May 2022 09:18:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmu6N-0001sd-Nf; Fri, 06 May 2022 09:18:19 +0000 Received: by outflank-mailman (input) for mailman id 322785; Fri, 06 May 2022 09:18:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmu6M-0001sT-FT; Fri, 06 May 2022 09:18:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmu6M-0002qn-C0; Fri, 06 May 2022 09:18:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmu6L-0006aO-Sv; Fri, 06 May 2022 09:18:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmu6L-0007JL-SU; Fri, 06 May 2022 09:18:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FCFK/v/e0Sndh3jGUie0Ocquj+cvJjGPxLW80xKFqNw=; b=bcFf/Hp0y86uEc9eoE6+2yp7Z8 KAhK4RLEHLxIuUR3Q+pqA8vdefg38Q9nhnKmMhiY5y2Efw1SThciisLQnJbxrzc0Le9vLkNzBrppi fQImL4eg+FyRxR1Jp4Wm2KvFetfLfegbwsIFiMaQIsJXm6COMao37PCbwMGQxI40v0Jw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170177: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=2434f6f206230c77ed45b9d5cd60c8a48e764c21 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 09:18:17 +0000 flight 170177 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170177/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 2434f6f206230c77ed45b9d5cd60c8a48e764c21 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 838 attempts Testing same since 170177 2022-05-06 08:40:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6066 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 09:42:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:42:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322793.544213 (Exim 4.92) (envelope-from ) id 1nmuTy-00059K-OK; Fri, 06 May 2022 09:42:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322793.544213; Fri, 06 May 2022 09:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuTy-00059D-LU; Fri, 06 May 2022 09:42:42 +0000 Received: by outflank-mailman (input) for mailman id 322793; Fri, 06 May 2022 09:42:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuTw-000595-U4 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:42:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ddb4766d-cd20-11ec-a406-831a346695d4; Fri, 06 May 2022 11:42:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0ACC3152B; Fri, 6 May 2022 02:42:38 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.2.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 541EA3FA31; Fri, 6 May 2022 02:42:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddb4766d-cd20-11ec-a406-831a346695d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich Subject: [PATCH v2 0/2] xen/arm: gnttab: macros modifications Date: Fri, 6 May 2022 11:42:23 +0200 Message-Id: <20220506094225.181815-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series modifies macros inside xen/arch/arm/include/asm/grant_table.h to be resistant to static analyzer/compiler warnings about unused-but-set variables. The first patch acts as a fix for a gcc warning when -Wunused-but-set-variable flag is enabled by converting the macro to static inline helper. The adjacent macro is modified as well. These macros can be converted to inline helpers as they do not take argument of type struct grant_table which is not fully defined yet. The second patch modifies the remaining macros to evaluate all their arguments and only once. Previous discussion: https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg119708.html Michal Orzel (2): xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* xen/arm: gnttab: modify macros to evaluate all arguments and only once xen/arch/arm/include/asm/grant_table.h | 89 +++++++++++++++++++------- 1 file changed, 66 insertions(+), 23 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 09:42:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:42:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322795.544229 (Exim 4.92) (envelope-from ) id 1nmuU1-0005Rk-8z; Fri, 06 May 2022 09:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322795.544229; Fri, 06 May 2022 09:42:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuU1-0005RK-4w; Fri, 06 May 2022 09:42:45 +0000 Received: by outflank-mailman (input) for mailman id 322795; Fri, 06 May 2022 09:42:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuU0-00059C-3i for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:42:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id e02f8aee-cd20-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 11:42:42 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2091F152B; Fri, 6 May 2022 02:42:42 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.2.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6ADF43FA31; Fri, 6 May 2022 02:42:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e02f8aee-cd20-11ec-8fc4-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich Subject: [PATCH v2 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Date: Fri, 6 May 2022 11:42:25 +0200 Message-Id: <20220506094225.181815-3-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506094225.181815-1-michal.orzel@arm.com> References: <20220506094225.181815-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Modify macros to evaluate all the arguments and make sure the arguments are evaluated only once. Introduce following intermediate macros: gnttab_status_gfn_, gnttab_shared_gfn_ that do not take domain as a parameter. These are to be used locally and allow us to avoid passing NULL from gnttab_get_frame_gfn to the respective macros (without _ suffix). Make use of a domain parameter from gnttab_shared_gfn and gnttab_status_gfn by adding an ASSERT. Signed-off-by: Michal Orzel --- Changes since v1: - use typeof for all data types - introduce intermediate macros --- xen/arch/arm/include/asm/grant_table.h | 75 ++++++++++++++++++-------- 1 file changed, 54 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index 5ccaf6d51f..3550990ceb 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -58,54 +58,87 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, #define gnttab_init_arch(gt) \ ({ \ - unsigned int ngf_ = (gt)->max_grant_frames; \ + typeof(gt) gt_ = (gt); \ + unsigned int ngf_ = gt_->max_grant_frames; \ unsigned int nsf_ = grant_to_status_frames(ngf_); \ \ - (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ - (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ - if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ + gt_->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ + gt_->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ + if ( gt_->arch.shared_gfn && gt_->arch.status_gfn ) \ { \ while ( ngf_-- ) \ - (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ + gt_->arch.shared_gfn[ngf_] = INVALID_GFN; \ while ( nsf_-- ) \ - (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ + gt_->arch.status_gfn[nsf_] = INVALID_GFN; \ } \ else \ - gnttab_destroy_arch(gt); \ - (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ + gnttab_destroy_arch(gt_); \ + gt_->arch.shared_gfn ? 0 : -ENOMEM; \ }) #define gnttab_destroy_arch(gt) \ do { \ - XFREE((gt)->arch.shared_gfn); \ - XFREE((gt)->arch.status_gfn); \ + typeof(gt) gt_ = (gt); \ + XFREE(gt_->arch.shared_gfn); \ + XFREE(gt_->arch.status_gfn); \ } while ( 0 ) #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ ({ \ int rc_ = 0; \ - gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx); \ - if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) || \ - (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn, \ + const typeof(gt) gt_ = (gt); \ + const typeof(st) st_ = (st); \ + const typeof(idx) idx_ = (idx); \ + const typeof(gfn) gfn_ = (gfn); \ + const gfn_t ogfn_ = gnttab_get_frame_gfn(gt_, st_, idx_); \ + if ( gfn_eq(ogfn_, INVALID_GFN) || gfn_eq(ogfn_, gfn_) || \ + (rc_ = guest_physmap_remove_page(gt_->domain, ogfn_, mfn, \ 0)) == 0 ) \ - ((st) ? (gt)->arch.status_gfn \ - : (gt)->arch.shared_gfn)[idx] = (gfn); \ + (st_ ? gt_->arch.status_gfn \ + : gt_->arch.shared_gfn)[idx_] = gfn_; \ rc_; \ }) #define gnttab_get_frame_gfn(gt, st, idx) ({ \ - (st) ? gnttab_status_gfn(NULL, gt, idx) \ - : gnttab_shared_gfn(NULL, gt, idx); \ + (st) ? gnttab_status_gfn_(gt, idx) \ + : gnttab_shared_gfn_(gt, idx); \ }) +#define gnttab_shared_gfn_(t, i) \ + ({ \ + const typeof(t) t_ = (t); \ + const typeof(i) i_ = (i); \ + (i_ >= nr_grant_frames(t_)) ? INVALID_GFN \ + : t_->arch.shared_gfn[i_]; \ + }) + +#define gnttab_status_gfn_(t, i) \ + ({ \ + const typeof(t) t_ = (t); \ + const typeof(i) i_ = (i); \ + (i_ >= nr_status_frames(t_)) ? INVALID_GFN \ + : t_->arch.status_gfn[i_]; \ + }) + #define gnttab_shared_gfn(d, t, i) \ - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + ({ \ + const typeof(t) t_ = (t); \ + ASSERT((d)->grant_table == t_); \ + gnttab_shared_gfn_(t_, i); \ + }) #define gnttab_status_gfn(d, t, i) \ - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + ({ \ + const typeof(t) t_ = (t); \ + ASSERT((d)->grant_table == t_); \ + gnttab_status_gfn_(t_, i); \ + }) -#define gnttab_need_iommu_mapping(d) \ - (is_domain_direct_mapped(d) && is_iommu_enabled(d)) +#define gnttab_need_iommu_mapping(d) \ + ({ \ + const typeof(d) d_ = (d); \ + is_domain_direct_mapped(d_) && is_iommu_enabled(d_); \ + }) #endif /* __ASM_GRANT_TABLE_H__ */ /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 09:42:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:42:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322794.544224 (Exim 4.92) (envelope-from ) id 1nmuU1-0005Ox-0s; Fri, 06 May 2022 09:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322794.544224; Fri, 06 May 2022 09:42:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuU0-0005Oq-TC; Fri, 06 May 2022 09:42:44 +0000 Received: by outflank-mailman (input) for mailman id 322794; Fri, 06 May 2022 09:42:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuTz-00059C-M8 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:42:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id dee23dd7-cd20-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 11:42:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 150D8153B; Fri, 6 May 2022 02:42:40 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.2.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EB373FA31; Fri, 6 May 2022 02:42:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee23dd7-cd20-11ec-8fc4-03012f2f19d4 From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich Subject: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Date: Fri, 6 May 2022 11:42:24 +0200 Message-Id: <20220506094225.181815-2-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220506094225.181815-1-michal.orzel@arm.com> References: <20220506094225.181815-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function unmap_common_complete (common/grant_table.c) defines and sets a variable ld that is later on passed to a macro: gnttab_host_mapping_get_page_type(). On Arm this macro does not make use of any arguments causing a compiler to warn about unused-but-set variable (when -Wunused-but-set-variable is enabled). Fix it by converting this macro to a static inline helper and using the boolean return type. While there, also convert macro gnttab_release_host_mappings. Signed-off-by: Michal Orzel Reviewed-by: Jan Beulich --- Changes since v1: - mark parameters as const --- xen/arch/arm/include/asm/grant_table.h | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index d31a4d6805..5ccaf6d51f 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) #endif } +static inline bool gnttab_host_mapping_get_page_type(const bool ro, + const struct domain *ld, + const struct domain *rd) +{ + return false; +} + +static inline bool gnttab_release_host_mappings(const struct domain *d) +{ + return true; +} + int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned int flags, unsigned int cache_flags); -#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, unsigned long new_gpaddr, unsigned int flags); -#define gnttab_release_host_mappings(domain) 1 /* * The region used by Xen on the memory will never be mapped in DOM0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 09:51:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:51:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322823.544246 (Exim 4.92) (envelope-from ) id 1nmuci-0007q4-6p; Fri, 06 May 2022 09:51:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322823.544246; Fri, 06 May 2022 09:51:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuci-0007px-44; Fri, 06 May 2022 09:51:44 +0000 Received: by outflank-mailman (input) for mailman id 322823; Fri, 06 May 2022 09:51:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmucg-0007pn-OT; Fri, 06 May 2022 09:51:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmucg-0003Qr-Fh; Fri, 06 May 2022 09:51:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmucg-0000Gy-3Z; Fri, 06 May 2022 09:51:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmucg-0002b3-35; Fri, 06 May 2022 09:51:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GIPN3FdzAEvz+GhnQg/3BT55o0UqvZotx7qPO3CidrY=; b=KHqR7UDQnZsQvow2TQg3MMkL9g nVdp9z9ZiY82DROgi+7WWIh6qQ17iEWhgtjeITjlMcQjU22O0pPCn5F9O+w78n7+sCi3RGR8q4B7d tBNeCwEe4TpLjDyHYopmb/xfn95uUd7MkWU0DkPC/rTx90X6CQdoTsyBUIeFZcNocYvs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170164: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 X-Osstest-Versions-That: xen=c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc From: osstest service owner Date: Fri, 06 May 2022 09:51:42 +0000 flight 170164 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170164/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170152 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170152 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170152 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170152 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170152 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170152 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170152 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170152 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170152 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170152 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170152 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170152 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 baseline version: xen c1d5e4021c9d3878eab9bb1c65eb3c21ef9d5ddc Last test of basis 170152 2022-05-05 14:08:06 Z 0 days Testing same since 170164 2022-05-06 01:08:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c1d5e4021c..90ba9a2da2 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 -> master From xen-devel-bounces@lists.xenproject.org Fri May 06 09:56:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322833.544260 (Exim 4.92) (envelope-from ) id 1nmuhN-000099-WE; Fri, 06 May 2022 09:56:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322833.544260; Fri, 06 May 2022 09:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuhN-000092-TW; Fri, 06 May 2022 09:56:33 +0000 Received: by outflank-mailman (input) for mailman id 322833; Fri, 06 May 2022 09:56:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuhM-00008w-7K for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:56:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuhI-0003WT-Rt; Fri, 06 May 2022 09:56:28 +0000 Received: from [54.239.6.185] (helo=[192.168.5.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmuhI-00043m-Lp; Fri, 06 May 2022 09:56:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=LVAOA5nlxtkofU+oKgZhiLFbxapG32M4X+g1oatNMuU=; b=wqrUVGpnI0p+60lXf/A8kIhpRq q42bH766xlxaHsLI9J86FRY0GwgO6kaJAvTOM6Stjf07M2JqagwlOA7qw6gpUP1/Jl0gXFztMJ3LC KmfUAmHXs+f/wKYjyHEKHDdB9VthrqiaqAiERUTMmmTREL7T6PcZ5XzgHD5WQaj5yPs4=; Message-ID: <310a44f4-84d8-f72b-6993-42dc3ca46b87@xen.org> Date: Fri, 6 May 2022 10:56:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* To: Michal Orzel , Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-2-michal.orzel@arm.com> <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> From: Julien Grall In-Reply-To: <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/05/2022 08:27, Michal Orzel wrote: > On 05.05.2022 13:13, Jan Beulich wrote: >> On 05.05.2022 12:36, Michal Orzel wrote: >>> --- a/xen/arch/arm/include/asm/grant_table.h >>> +++ b/xen/arch/arm/include/asm/grant_table.h >>> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >>> #endif >>> } >>> >>> +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, >>> + struct domain *rd) >>> +{ >>> + return false; >>> +} >>> + >>> +static inline bool gnttab_release_host_mappings(struct domain *d) >>> +{ >>> + return true; >>> +} >> >> Looking at x86 I think all three instances of struct domain * want to >> be const struct domain *. Then >> Reviewed-by: Jan Beulich >> >> Jan >> > Thanks. I think we should mark all parameters as const meaning also const bool ro. Hmmmm... ro is not a pointer and so the value can only be modified within the inline helper. So isn't it a bit pointless to set it to const? If that's the only comment on the next version, this could be dealt on commit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 06 09:58:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322838.544271 (Exim 4.92) (envelope-from ) id 1nmuip-0000oX-Br; Fri, 06 May 2022 09:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322838.544271; Fri, 06 May 2022 09:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuip-0000oQ-8r; Fri, 06 May 2022 09:58:03 +0000 Received: by outflank-mailman (input) for mailman id 322838; Fri, 06 May 2022 09:58:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuio-0000oK-Lp for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:58:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03a6a6c9-cd23-11ec-a406-831a346695d4; Fri, 06 May 2022 11:58:01 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-27-PS658qyYNjGSZMFx3ufzJw-1; Fri, 06 May 2022 11:57:56 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AS1PR04MB9359.eurprd04.prod.outlook.com (2603:10a6:20b:4db::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.17; Fri, 6 May 2022 09:57:55 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 09:57:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03a6a6c9-cd23-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651831081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Jcgw0lQ7VK7kWoEy2HNfbVhD4LlU/OJsjypeM2ORk8=; b=BlXbqrzgDAFewHZhxb+vXx20toswYx4XcLHW8emyOG9LqBe0//llviDIYMT6byV6m9lNFY 3x6z7jdkcLYZt1ZCWBpWjo5EZWfNxFCk+S+0UZgIRthADokuTC3Donyd9gzppz3H3Ci3cJ IUSfjGKt8ZJ1pl7IfWElbzn71YhagyE= X-MC-Unique: PS658qyYNjGSZMFx3ufzJw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbEPlwQNO2WirrE15tdkFqADNgw8Ssx0mLnLEAU/CjdueeXSdj24Uih74HwvpxAO7AfB+pj0mzQU7FyYEFKHv1GILYv2vNeUihpTU/GyJDJRGxZ7FfkhXIOp4kJ38gykgvLLMxBGRUtgsJCsey0Xt7xqKd+A62kvzyDg1kCFj492cJ/B/4P1va3deWK8Cod1ZGiH7D9hAPgujS1RTwS2uqbBLEYjFAJ0TDeTAxOpbaRuQt2CORsT7vhofZ04IAgVGMOeNIxtexpS0x1FhwqT70SWmfw1Kio34+lKPaYx1qur5twl0VsRMwETBui90U+PbM2HhoXg7LbIPvYYOzGDHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Jcgw0lQ7VK7kWoEy2HNfbVhD4LlU/OJsjypeM2ORk8=; b=kaU30F2USUy7o8d9bSj9K+sZYIvTYfaXyFNE3aJ2TLQPeyhtqLhQvKPdrmMyU++nqxLtL/wOGKwxyrudnIuTHCrBifoUBdXST/FDWoTgAeIOXHa4kTf+KrBlDLDJZ8UganQHlfE+BEk9Q4fO5K8z/egxAEdQ1rIUQgeduTvknDcLNtZhvHZX1lYBlTaBkCD48B/06+DaR3bz/o69tMENrHCWfuvkLgiWP8925HpYad7Y8jFJGg1xAAfh1WYy6D7l53T7QTJRMDaamCX7NIZ2vfNOSihad8CLEX9R5ouwgEAggXGR6/9KWIb8LtaMNE+fm9C2ri9IjlQl00RGTgwzsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <476cab6f-93a1-fa31-567d-4f31c9669cb8@suse.com> Date: Fri, 6 May 2022 11:57:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-2-michal.orzel@arm.com> <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> From: Jan Beulich In-Reply-To: <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0372.eurprd06.prod.outlook.com (2603:10a6:20b:460::26) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88f05131-ae09-47e5-2b5f-08da2f46e488 X-MS-TrafficTypeDiagnostic: AS1PR04MB9359:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kl5n9NMC2r5EoyAR8ouy9nunQBw1Cltz6jMrUlsnUuEgAb8Qi9llADXX1H+DL8X0cHPevRqLdF7dfV+xetjaWJv3fIqSyL6INymY9vyfIZIjt73lgr0gFxRsiCWdBmiGBxCDZS61GJz5Sc40/OqcJB31W5WShDzD94ZMxxdA2a42MJp4U/8atWCEl5Y3wfafp0VOxQwgndWyvrCMgSIzjmd9IS5MJJrO4MyRRUlbXscPoEoVGf7ERYi/QfY1ofTbZnuTfuNO7l6df4Yb2X4mXn9N1WRGxTYA+1W6jhT66rVoGNmjWQx4w01SgoX84VJkhq2tmW+SCEW9oooC35t7FWMDWZyMR3p8jPCDYfCzvR/bfLXfEWEVzNq113YCb+pMsy/2F2ohQzkiaGX5x6dDMOY9pIcIpl1/rHjrVH/25zTY6zuIOV0l6i8nXTXraCnQZsmdiaEVQ/8Q3AL71hikEXrebBUA9viMd4lQkK0oQHuT30h2b8i54UtJU/UZ6/HIKNJU32VDIngu9tiOReZ20pbibcu3sSvYjHdNGhSAAtkwzWJntAzqxGrdv2Sfiq4JqjB4sy5AuHfiIiDAxpQOZ7C4lrtBCghnBG4DGnUXraqYzX0UJIIrrGvoXRtI9OPWKzEOYvsdGE6M2uap/4Y4kqNvaHvZe+ORmvLRnk3xEEDEFgEv2BDR20dgVRfCWETU8qU6W7UMXwObLuuktbYe3Y11PAaqn2HL2zBgIhoiqcnEvWf6DuD8TTJDBWvDUtVW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6512007)(66946007)(316002)(86362001)(6916009)(2616005)(6486002)(26005)(508600001)(2906002)(5660300002)(66476007)(31686004)(36756003)(53546011)(6506007)(8936002)(66556008)(38100700002)(4326008)(31696002)(186003)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1BwQUZBRDZjbWxudXArWU5MODk5eVdRVGd3Vm9QRm0zWGtMM3hRM3AxZFRN?= =?utf-8?B?YXBXMFFkcThoV1dkQzVzeG5tYUJyTlpYS2xQOUVlNVE0SXVWbHZjLzlHN3Zn?= =?utf-8?B?K0ozK3pTVW42bXJDVy9rR3pOeXZEaXVQMm9PdXBDN3pmT3BzTFZrWVR5RTVU?= =?utf-8?B?UXBmSkdiVlZrS0lRamE4dkh3UDFTZjVwK1NhUW1Qd0Q1TmhGOTBOUnMyNndq?= =?utf-8?B?bS9IQXNTeHdHbVF1aDRKVWJoR2RPOVp0d0FCVzgyRjc5ekliZjBSU2pwanQ2?= =?utf-8?B?Y0tZVEhoeUh5SnZPTHRURElMamg4VWVZWktNS3ZpczhBeW9wTUxQdExTNTRO?= =?utf-8?B?ZUxtejlwZkxvMk9id0plOHdselg4OWx0MSt6VHJFOTlBTWFpQWZqTXJ1QldF?= =?utf-8?B?bXJvUlJQdlFUYWxOQXl2TUdKOWtoa05VZkRSWVZrL2FvcnpKSHh4VU9JcXBk?= =?utf-8?B?ck1JMi81UUR5OXRHc1h5bUh3b0kySXJQUzF2MEozVFpvamx1MFV2WEd6MUR1?= =?utf-8?B?OFpDWDNXODZ3Tm5wSFlnYXVrc3BqVm94M0E3Q2UySVpWVFZYUG5saUNRdUZt?= =?utf-8?B?ZmVUT2V1Nm9PdDRtVGRCVHRHSGdmYXVML2kyRzVMQVliNStkNllXL0VtaHVK?= =?utf-8?B?dUk0M1Nvblh2SGVKY0FWSGtURklJbUxNclpwTFRMRVdwRXA4L3VLc3NWQ0p1?= =?utf-8?B?YzB1RzZLdm1vMU92RFFxWFUxejdZNWczNXlZUjcxWHVXUWhEL1JkM0VXRCtz?= =?utf-8?B?SjQ2bkRDNWZMb1p5bVVvVG5FYlJ1dlBwVk5LbnI1Y092ZDh2emVKTTJrblZP?= =?utf-8?B?ZVVmTmUzd2NxTDl1VnA2WHpiSk5XSXJFWWtsYnE2WFFvTXRCZ3hGOGQyUzFK?= =?utf-8?B?Q1ovMWpCdzViNVdDeHZDTVBiNHJwZ0lkSHBoR3N2QkI0UnVnUXZ5VHdhdTV2?= =?utf-8?B?UjdqclVsVFBUd25HbXFkaDlOTnRkOGdDWmJicnJ3MlZGUWNBaXFMenVobUhU?= =?utf-8?B?UWorU1pyNzl5Ni9ORXRnelpCMVZBZXJOM2orcjJCUGVIbVJmMCsyM280R3Nm?= =?utf-8?B?ellZZWVDbVhhUVprWmQ1Zm9OU0QzcThhNkg4azA0cDFHcWhmRzFaZlg3M2tz?= =?utf-8?B?TWJJSEoxN0FxVitYSklQdGVCZU5SMjZDcmVJT1RmaTZMclM0NDZWYzI2eFhW?= =?utf-8?B?bWVmZloxVXdJY0NaelIzRndySzMyeWgwNFh1T01ueVg0bmc5bk8vcG9kZEtS?= =?utf-8?B?UkV4UUJHKzMwR1lLdmtZQkdXNnhpcnl4a3YyVWRzczV6WkpPQVV0blpDd0VU?= =?utf-8?B?cHdGS3czTmhsQ3IwOUwyaCt2Zmp0am42NS9UaENLMjY2czZlaVpFWDIzaE14?= =?utf-8?B?UG1Fa1R1STg0RndOVDg2ZHlQaXJ3V2ZVS3JxYjRxb0ZtSUM2M3p6TFU3cjdI?= =?utf-8?B?OFpiWndKZ3ZwVnhtVDR2RC9JMzYvcjNoNmR2aTgyQWVtUzl2NUVaSndWTjU5?= =?utf-8?B?ZFowRXFxSEVET24yMG80QndjTHNRY2tSRERuRlNCWk13QysxdGVDRGNESG5z?= =?utf-8?B?MEFDeU54OERjNnBMZXFWUURKVi80YmZuUlRYbWtHZmp5b0hLNUR6NEw0TjVR?= =?utf-8?B?Rld1aGdXVngyS1BLc0FCb0RUYTV1R0d4RG14REkzQjZxNm4rQk1FQmhuOXhp?= =?utf-8?B?Q0taNW4zRVJwSFlGZ09jQVltQjFIRDhHaWZCelRoY01FRDFQbEMvTG9yYVQz?= =?utf-8?B?M3pESStPQUVXRXBzeUhqM0dzNzJwM0VEbXdrc1pOWHVzdmJ5RU12d0U4QWwz?= =?utf-8?B?cE9Xc2FzOU5VbmVwa2x4RnpvdklWVGFIU3RoTkEwa1lPdm10c0JSK0xaWmNE?= =?utf-8?B?ZmJrVmVTTXo3WmVyTHZNQ3dmRGZaUjRIUFZFWTNPRG95VDZQcFNBRWZVOS8r?= =?utf-8?B?cmhsTTFHY0NmaWRPblhmWTcyTkxYWmVSVmV0a1JVblJjamRrN0NIY1JDd3dN?= =?utf-8?B?VFg3VEdXK3dzQnNTaFplejNOZkNDT0M5S2w0ZjR6REZvY05VTmtGOTRuR2J0?= =?utf-8?B?TkxCUmFoajhEMXRpQU01VFM5b1dyUXJaaStGSkRiQkdQWXEyQUlqejEyUnZh?= =?utf-8?B?YUFMamFEMXh2QzhVNi9kMkh4a0pMcHI0NzVya0xBNnJLRkdOM0IxMVVkVWRv?= =?utf-8?B?TzBXbHlmbVZEZ3hsdlhMbTFjdmR2M3hNZ0NHYnJPTkpOQWc0bGMxL2pZQnNJ?= =?utf-8?B?NHdsNWdKT3hzL0dsMzQyTTdtOFZFT1U3QlRRU3lHNFVkRmVzQzlkOWpqT0Jk?= =?utf-8?B?R2VZZXRsVld2SmRIVi95aEY5NWF4VkZQUjNOWUQ1ZlBqeVpTd3pidz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88f05131-ae09-47e5-2b5f-08da2f46e488 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 09:57:55.5486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p1wzkBOj5ujQn+tpXdZXiedx+8+Uep6x03BUhl9Q8/Np0FBlqiqAlEhFYF2Y59yVDKMAqUzWlLp8FH8bFh+r6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9359 On 06.05.2022 09:27, Michal Orzel wrote: > > > On 05.05.2022 13:13, Jan Beulich wrote: >> On 05.05.2022 12:36, Michal Orzel wrote: >>> --- a/xen/arch/arm/include/asm/grant_table.h >>> +++ b/xen/arch/arm/include/asm/grant_table.h >>> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >>> #endif >>> } >>> >>> +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, >>> + struct domain *rd) >>> +{ >>> + return false; >>> +} >>> + >>> +static inline bool gnttab_release_host_mappings(struct domain *d) >>> +{ >>> + return true; >>> +} >> >> Looking at x86 I think all three instances of struct domain * want to >> be const struct domain *. Then >> Reviewed-by: Jan Beulich >> > Thanks. I think we should mark all parameters as const meaning also const bool ro. Not really - I did suggest "pointer to const" which is different from the parameter itself being const. We don't normally do the latter, and I'd recommend we don't start, or else we'll end up with static inline bool gnttab_host_mapping_get_page_type(const bool ro, const struct domain *const ld, const struct domain *const rd) { ... Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 09:59:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 09:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322843.544283 (Exim 4.92) (envelope-from ) id 1nmukT-0001Pc-Pf; Fri, 06 May 2022 09:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322843.544283; Fri, 06 May 2022 09:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukT-0001PV-Ml; Fri, 06 May 2022 09:59:45 +0000 Received: by outflank-mailman (input) for mailman id 322843; Fri, 06 May 2022 09:59:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukS-0001PP-UL for xen-devel@lists.xenproject.org; Fri, 06 May 2022 09:59:44 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40add70b-cd23-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 11:59:43 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-Ji18vRBoMDCbSM4Fh5TEdA-1; Fri, 06 May 2022 11:59:42 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by HE1PR04MB3307.eurprd04.prod.outlook.com (2603:10a6:7:23::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 09:59:40 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 09:59:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40add70b-cd23-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651831183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWgqBKMYwVL1ucTGvYfEd14aArsaIvpUJfq5Cn+RyA8=; b=Pw6/29a3Wl4tefwS+rP8VqqqDYsRW/JJ+3ZKtvtM05IsIL1INZAy9kVFwWi5PO6oRi4xZr ga5wyscDtFIRE8LgAoENCxTdMSD+q7ZaWshIvLqj1n4vUgO/i4bBFokfzzWDKYfE/hBnob 0d5jUg2oH81lUAL1JopAWaAqOTGjkyw= X-MC-Unique: Ji18vRBoMDCbSM4Fh5TEdA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkumnEpyo+bGYCA1eZRSkFJA+5DKWt7gDZomGVi+m9Vqp93DvK9mypCwX0UDS7WZfIcYBo/V30ECcxVm34QEBW9Dsw2iKgng8XR/reY8AUA72i/FvBGrxENLuk+xTNdXrLNEfMhC11d0XQbLqAHH2XMqeTr7k668AWh3sMAQi+cv/VKQYzLLQKlFkaI/U3JFd9F6ebeofI+eMrtcpieseWZQvDn3T6ER50ignjrBwavvEw6ptR5S/Nh6hTuwo57vGm9sVWowek259HRMVQo7mS/9p/u2FptOHlSump5uPRMa4Gsu83LmVHxaeEk3qlvnaPeD08XalnKAGjriGHrGow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iMvuZ7/xlozp6ZJdbEAzUbBzJf9NxYJWRlrX/bBoddE=; b=Kdr4cVAN70ijhNkQty3yr5udnnda2YupBD6LqbyW1j6mM2HTua5a5JFGcrsi322rOhTRvExnx7IWGYEaKHSg0rMxzbYRTFSkDdxrWucn2p+NrTce4SQyB1LaCX8JeVEFfmEbVFWUTgZRGvtfgqBhec/6mjnHJNcdKfCkrlgFNMv2Dfw/taTnqUI7myDepwES6EMDj3kACCD4HLO298ojTaIuSmpgDRTP2smD1uHYDoSrkBcfetS+kVOGZFS4em0g6iME4BFpyAoZZuitSd75T7Vm9gOV3PvP9ME4GYL9jVG/M9PvePcuI2IkQspOcQtRLVWEJ4JnYd71ZRf+wxzOpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29ac1ea3-9661-f349-aa3c-55437903639d@suse.com> Date: Fri, 6 May 2022 11:59:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 12/21] IOMMU: fold flush-all hook into "flush one" Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <024c89df-9cf9-4d74-116d-ca8481dca90b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e110a15e-eb2e-45af-512a-08da2f4722bb X-MS-TrafficTypeDiagnostic: HE1PR04MB3307:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U9jm/xSxR2ZDwWJ49lMU50MZubMOd/GgPbwJs/bkstw0OQ2HW3bpuRXV8sgF981oa4aDSk19w9+fyfj0lmfSfabkG9d8fu0mu51xqp/AWi0YyyYJJ8L738j/2O+qvBPo2ce0B77C/uLAvCr9bdxMClvkm92vm2NGnBZXNYCNNG35QK+R6heSEUjvHUXHwYERBb9pbAIYRCcrJ43QMlwHn3Nxqv8AnTDyIECImRqR+hrgKuSKtQ3lR3StxCJZ4zwSEkfKzUJhF+WghqmvsrA2sAeL42T2eeVk/JFOCue+k8iJXDydUgKDha9F03zIWtm6IjYSexsV2IKyOvwaTgO6YsRFrwIOpTKY530KLOP+YhgZLnZQytmf6jgeJbwZWKlmw1WRBlmp+KF8ZRBBlEeh2efy2JlK9BXHgvbxhOChFvgaUA9Fbj9DxjA7OwqJzH3Mb/e9RXwA/thadlsXSNgDg64Qh8jRwSdAu5L8kC8BEaYiDdNiDetF2zlv9GaPxCTMSUxJSeuG2j/o0GK81T68rtK88UCqweQHq/gAphGJrLtg4vVeD/SU2jgAPVorWysF8B9XJprkZD2FaaJA3i/B+C/Sly5R+YhSLsTWB5DjWqaCdAbq7zmOEDjkftkRWkZp3qDtJVQRNLMVjeS6prK8PA4Bknaszpw/JYERFZAz+zGAWkU50BVuiCHZVnHc38AI4EKY2Dub1u+8wg8ixCqZTZSEmOvg1lmY840Sofr06i9Z0eNMIEU0v0QIl79Oxc62 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(36756003)(4326008)(2906002)(66476007)(8676002)(66946007)(6916009)(54906003)(316002)(6486002)(508600001)(5660300002)(8936002)(83380400001)(38100700002)(2616005)(6512007)(26005)(86362001)(31696002)(53546011)(186003)(6506007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Za5LGkmL8NToVyQbAvqRcIJxqiroExiwcJDXvFJw8jhGqJA7zJApIZNI9WGl?= =?us-ascii?Q?V053S01wxz5e33jqrafPxxeGYexJgoia+mYc9/Odc7x38PM/UO3nlJkqTSFs?= =?us-ascii?Q?lzGICekNuc2JyiEKnu5ktZ7irLO7KXXe8G0KmUTTlrK9Mk07b9IF1JnwNOw5?= =?us-ascii?Q?EU93M4UFVb95RcpfUryk/8L2SSpYTSE4p8f78GW57YryZM/LxMr9Jjr/Gmyh?= =?us-ascii?Q?tMBSqIJT7u0jPjyKHb/I0nrwPco9Olkm3tg1EW3B4YzMRUmNeaUZ7cYM9x3n?= =?us-ascii?Q?okU430igT+wDi6ZZI5ZtYYkgrFndylBZYRsV6B2ncC9s7WWrik2u+rLjLIal?= =?us-ascii?Q?GXPWclsqE+cjbiR0kTU215GdoiM8WfFa/hDsJjinaI1JIkD/gdbtVLHlqPWl?= =?us-ascii?Q?95mcxhvY4w4UAH+OYaj8EDkJ4Tp4QS07XfxvJ2bn+R0kHK0KmZ34MUyNwHk0?= =?us-ascii?Q?+ikxXrNsgRRKWcOMmVv1eT2GaeETOW8lRiifJ+cjNxWw+EtWTf5/F55ydQ2v?= =?us-ascii?Q?ommz3BfC+7BFK1WXnWG7AwKqvniYAzRwvJsbw2t/WC7h68dVKrla6v4NisNW?= =?us-ascii?Q?jC7KYiy1NmqZeiGal1+Mj1OHSmYmOoXwr9f4ll7qTPUW91CYx68k04WUf05a?= =?us-ascii?Q?M0Px4s+IOmdwmM+jQN4z7XFeRuxRkW/t5wS18nzp1rFh3PkLECcKk4dhv8aV?= =?us-ascii?Q?4RH0zM1UxL9J3p1ILCS7wrKJQ5PdbFnyuNEXOG4VAUDkI4EoUP41VL48M4aM?= =?us-ascii?Q?dAsqawR6izHR2F5vpxSjZuG5dbjIabAnNBGwnoNXxvVBJ0s8KhOKnEXutYmC?= =?us-ascii?Q?RZowEUcED6upNw8Wqk+fxgBSLrZdD86c3DUuns+EJ1axyd6BdvT81sPxjpAt?= =?us-ascii?Q?rpjXJj/XXQEVRUn95p2WB4cMPFPe5pbWWmodZfnWxoUz3lthEguYWv2eofqN?= =?us-ascii?Q?GCLwrpz7twP0KS2bkdOLpQzf2CVfZWQ/Cqcao4CoCcWHxCB808VMtvVi1bGv?= =?us-ascii?Q?sBzPThyRXW1PrfAoblt7Fxg9M6nM6abwoW96RQ5VWFfEXEQ4dCpr699RutYP?= =?us-ascii?Q?mWowQA8OTEogRudPVqSjmf2JQEXNbPul2TDlXOkM/DWK2DMtCVWeTO/+k92a?= =?us-ascii?Q?ynFv4MKaHKZ4Chq/QnqY1Q9EhdicLGLSf4QfNCF43ZRICcRnfRfox9qLOfL/?= =?us-ascii?Q?l3ejXFx3fFeS+zsYe2KsnHv92gIf/xIEGpW6QJvDg4bJkyrtXtpogt8NTmlF?= =?us-ascii?Q?+QRO6itTB113gJhebeLr0pC/iSmIqjw8s4H/RbvtlrSJRnbC1ksTglvrjEUq?= =?us-ascii?Q?Kxs2VYIoyHGfqdTEsfKMZ+7RUPSvbpwyXX5qDKmzwFP8LQxgUcG66sLIwG6O?= =?us-ascii?Q?UhEuBu/rEzIoFcb3XS0z6oqE0a32dvCr0HNvy4lq8+3vqxLgo0HiF41QlCiS?= =?us-ascii?Q?Eq+CZPSM+ZToOVEvha37HND6emJCD2Rj5GOVioaQrd+bt/2Nb8mJnZTyGmHT?= =?us-ascii?Q?x+S2BnI6m6h2fm2NEJBMdpgvsdf6U3cp+A9tmQIIBMAU7OTV6XoLiMmshcHx?= =?us-ascii?Q?Z5/taQQBcgyc+jd2RpRikHRpkShAp2viRdorym2bC3LFX+mdUvDI1JtcZaEp?= =?us-ascii?Q?pxpufbeNJNrkmMGvw6g6oRyimbVoy8D3yNIBa9rGL6KdYx6uQsmNdlA7NQAx?= =?us-ascii?Q?LGGNLCsBhladg1PfSVGxe4Kv0Aam3/5TF9NKgBPIi1dHaYiZgXW0nmXxVN6f?= =?us-ascii?Q?WbrFvvXDmA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e110a15e-eb2e-45af-512a-08da2f4722bb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 09:59:39.8966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2o3HLxrk8SUR8VZBu/+qMgCyxihcxIoWS7qxtTHBO9AmG4sIg2CUiPpheVvi5g6n+ZNW+AcfqSZtqDQSgIN/7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3307 On 06.05.2022 10:38, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:40:06AM +0200, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f >> struct domain *d, dfn_t dfn, unsigned long page_count, >> unsigned int flush_flags) >> { >> - ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); >> - ASSERT(flush_flags); >> + if ( flush_flags & IOMMU_FLUSHF_all ) >> + { >> + dfn =3D INVALID_DFN; >> + page_count =3D 0; >> + } >> + else >> + { >> + ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); >> + ASSERT(flush_flags); >> + } >> =20 >> return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modifie= d, >> page_count); >=20 > In a future patch we could likely move the code in iommu_flush_iotlb > into iommu_flush_iotlb_pages, seeing as iommu_flush_iotlb_pages is the > only caller of iommu_flush_iotlb. And indeed a later patch does so, and an earlier version of the patch here did say so in a post-commit-message remark. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 10:00:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322845.544294 (Exim 4.92) (envelope-from ) id 1nmuks-0002gy-2j; Fri, 06 May 2022 10:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322845.544294; Fri, 06 May 2022 10:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukr-0002gr-Vn; Fri, 06 May 2022 10:00:09 +0000 Received: by outflank-mailman (input) for mailman id 322845; Fri, 06 May 2022 10:00:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukq-0002fK-Hg; Fri, 06 May 2022 10:00:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukq-0003hN-EL; Fri, 06 May 2022 10:00:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmukq-0000Vr-2r; Fri, 06 May 2022 10:00:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmukq-0000cJ-2N; Fri, 06 May 2022 10:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u97R9Vgt6TuYhkP1opzrMElVMnfay1bErDCUZUONf0k=; b=3DpcQOvj/2Mkxlh2LpVq4zSvBF 99nqjV4B2romu5KBDjtwaD72JuH1lEjt9LRYpLsOAX/x3zq1n4lQaaiCBYwAMAJ9Bnju5ne7Rm3X1 +TuhcFqqaSC7a2hCp4uBACHty5A10k+m+4TTEfgp+hOyKYw3cfD+2WHWewXu7m7xX7ZE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170178: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 10:00:08 +0000 flight 170178 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 66 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 839 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 10:02:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322857.544305 (Exim 4.92) (envelope-from ) id 1nmumf-0003V3-Lq; Fri, 06 May 2022 10:02:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322857.544305; Fri, 06 May 2022 10:02:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmumf-0003Uw-Id; Fri, 06 May 2022 10:02:01 +0000 Received: by outflank-mailman (input) for mailman id 322857; Fri, 06 May 2022 10:02:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmume-0003Um-59 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:02:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 913d0e7f-cd23-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 12:01:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30AB014BF; Fri, 6 May 2022 03:01:58 -0700 (PDT) Received: from [10.57.2.250] (unknown [10.57.2.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7ACB03FA31; Fri, 6 May 2022 03:01:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 913d0e7f-cd23-11ec-8fc4-03012f2f19d4 Message-ID: <19e36d4b-864a-2eb4-505b-d9db69805b01@arm.com> Date: Fri, 6 May 2022 12:01:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220505103601.322110-1-michal.orzel@arm.com> <20220505103601.322110-2-michal.orzel@arm.com> <9e759dc2-42f7-01d4-3c3f-17ddfe85018d@suse.com> <1be8409a-d550-94d1-bf2e-d53ced5edd0c@arm.com> <310a44f4-84d8-f72b-6993-42dc3ca46b87@xen.org> From: Michal Orzel In-Reply-To: <310a44f4-84d8-f72b-6993-42dc3ca46b87@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06.05.2022 11:56, Julien Grall wrote: > > > On 06/05/2022 08:27, Michal Orzel wrote: >> On 05.05.2022 13:13, Jan Beulich wrote: >>> On 05.05.2022 12:36, Michal Orzel wrote: >>>> --- a/xen/arch/arm/include/asm/grant_table.h >>>> +++ b/xen/arch/arm/include/asm/grant_table.h >>>> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >>>>   #endif >>>>   } >>>>   +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain *ld, >>>> +                                                     struct domain *rd) >>>> +{ >>>> +    return false; >>>> +} >>>> + >>>> +static inline bool gnttab_release_host_mappings(struct domain *d) >>>> +{ >>>> +    return true; >>>> +} >>> >>> Looking at x86 I think all three instances of struct domain * want to >>> be const struct domain *. Then >>> Reviewed-by: Jan Beulich >>> >>> Jan >>> >> Thanks. I think we should mark all parameters as const meaning also const bool ro. > > Hmmmm... ro is not a pointer and so the value can only be modified within the inline helper. So isn't it a bit pointless to set it to const? > > If that's the only comment on the next version, this could be dealt on commit. > > Cheers, > >From the code point of view it is pointless. However it is also about self-documenting the code. If this is something that cannot occur in Xen, I'd be greatful for dealing with this on commit. Cheers, Michal From xen-devel-bounces@lists.xenproject.org Fri May 06 10:03:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:03:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322863.544316 (Exim 4.92) (envelope-from ) id 1nmuo5-00045k-W5; Fri, 06 May 2022 10:03:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322863.544316; Fri, 06 May 2022 10:03:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuo5-00045d-T5; Fri, 06 May 2022 10:03:29 +0000 Received: by outflank-mailman (input) for mailman id 322863; Fri, 06 May 2022 10:03:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuo5-00045X-G2 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:03:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c694b450-cd23-11ec-a406-831a346695d4; Fri, 06 May 2022 12:03:28 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2174.outbound.protection.outlook.com [104.47.51.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-rLG7vvWDPfyfPO0EWc33TA-1; Fri, 06 May 2022 12:03:26 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB6833.eurprd04.prod.outlook.com (2603:10a6:208:17d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 10:03:24 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 10:03:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c694b450-cd23-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651831408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vcus4KzsWrufXtEPEasfCu5qSPVsJwNNR29zq4QtvhQ=; b=T8BqNZhNFKaikOJm3+DCFe9aeSy75xh8396BoxSdkwpoFzM2xY8bCTUutJKTk1wH6Cz9RL gzn1Abs56bwSta1pdTieSwdscVTYcLOjUut7QYDrgDHP831o6qtOjBky54AShsUvXJpJDG mIzvay5B01YA3u7Rzh3wjnNtSpcc5wg= X-MC-Unique: rLG7vvWDPfyfPO0EWc33TA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QjON0tRISC64XJxAO161hFdsL8HWR/2oixp/+9O6gdiM9dqCpO+xdz4lijom6i4nhUhqpiW/DsOs3qG1nb6JqPop10vYj84XE2Wcll6sNbfghbEqpjWpCAMTQODcBm3m59YyWIGNHyxJjuXIWOzINhWOu96le636R3MoLJu748Rq91QOkhFJr7YGk4kEY8BsbWsdGsWuwcKl/ceLUhYcxZRXBA/s/8nhhJUzDEqdLduhFU99jR9ZkcolfZIrzutOSKscCjagAVnFvMviv2q5RITo7wm4UGjHOtjQdejuBhwGUYoylBSnz8T7ZIvgJ4R+5SJT8X9MB++CUh6TSygbQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vcus4KzsWrufXtEPEasfCu5qSPVsJwNNR29zq4QtvhQ=; b=XlqF+ahUNi9dve6VBtQUKf3dnWJGyl+f66jHv6/AKg9HVBEeVmQ/AOxb3158qBrxth+puAf2cV+UiTIbfzTkDsiSxV3F62nHZpWOUSF0u90OfCy57L2lHBvYYAtFZnI/aKSDMSqkOK9NZ7PFXhxRhmHP+dquiPbBx3pq/CLcmA7QWwO5qFgNUGlKZiixOevi8ISbizFMIDuseaIKuRPbFCgxdeoMUIamfnmHiJpTRG5xBKnSnEMLw2Lwtt94uLh+HGfXXbLdNSoCiyqg/1xIg2lvhkfr0rrAVUaM82ZhXQI8DRpF0VIrDygiI0rvb0cfK1rke8dEAi+edq0T7kLaGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 12:03:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-2-michal.orzel@arm.com> From: Jan Beulich In-Reply-To: <20220506094225.181815-2-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:20b:462::13) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bad065f-afa7-4d8d-9453-08da2f47a87a X-MS-TrafficTypeDiagnostic: AM0PR04MB6833:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: byK7IEUTWRbU3mgJPfB6sJJRQry7U+0/tbMCx0SVRfkxe4/kdaHUa30pl+YVGMu/biX9czZ49c0WTNQ9JssZcPGZWo1R9bk7iiIF04E0BfdEcsxRUZJmi7tr0ubQtmUt/3p7NvH23OuJ17MeSlaQVxduCgyZAl4WcichDi7FRgf+XpBXgjVWyyfr94YRj8ue8SKV0WPRQfNqrqsYQ6m8ubWFYLrpqFmJJNkowezAblHrQU7wXNRI1FbTULmoXUJ/deCmuSlTXlmSMTHrUOVz0xhsi33p1N/EmHgo/d7bvG2c9+8Nh8B19zY6++RQ+/7fG9hc+GSsC39P8BcI9TvUG/Ve2UbQGDLt2Wqrfqklu+1IR71N6ORPu51x4yB5Eogy3HE8aJ9NR/0uIKC+3bBAz0cJsT8EIkGOh2z4rCSIIGA070JBXm0ec4B/fuMAj0jatJvZSF/XRhh8+J/qXQprjaQG4NErzNiYYuGZItPeBDEt0Xuj9spnNpYRIXweVh3m+Muxxz53zmq9/Gn58ryP29fBAMJcqddEKM/WQ4jAD2daHhlvPfGDAWsNZm/ueoAZCyY0D0qRdsFSQGMvDD3ag+VKHghIxhw6psOqkqKC0KpZwQK68V6/0nhzxtOsshPIamOxc5+nTnmUN3M3KMqL/F/1Xdkw389Sar6JQpVZHx0Knh3PEq0ecKLRhc+lRazDQc6/RFYsGOVj2Cvsv1UDhvQrgSqRkidfbu+HKfXGppvsC53PgCRx4LmoaFHwJpO8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6506007)(53546011)(31686004)(5660300002)(2906002)(36756003)(8936002)(66476007)(8676002)(4326008)(66556008)(508600001)(6486002)(66946007)(38100700002)(26005)(6512007)(186003)(6916009)(31696002)(86362001)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGYxa3ZuQXBmODdud2QrdVE0TFo0aUQzaE9zQjUydHhkbko3V0h0QVd3YXJz?= =?utf-8?B?Rk1xNlh3SVppbVRsNmxsUDJnOThVa3RzekI3VU00NXZwVUVlMS9GZTFZb2Rq?= =?utf-8?B?RGs5SmllYzgzSnp3dnNRYitMMGVMTHV4eS9oWHo5UmZpN1ZQVGtpNElsdXc4?= =?utf-8?B?QnY5Wkp3SEFEZ2pvSHBFSEF3OTc2MkpzMFhOODRtcmRtZ1hjRmhScUkzSmhw?= =?utf-8?B?RUVXeFFpaHA0WUtVaTVHL3I0cHlPTy93ejBNQzRXYzdJM1pvS2tQSDk5OWhk?= =?utf-8?B?Zm1ZdXV0TEI1c2xrNXlBbXFmRENBaDYzWkF2QXdDQXhhRnAxaW1BTEJiSVIr?= =?utf-8?B?Um1mZTJWeXVGeno3bkE0UHhyaDR2WVFtMU4yK3dEcFU0QmRMaDFSNGthM0lE?= =?utf-8?B?SWJFWHBxNUhQcnRSSHdJQy93aDdjcDFKMHluUlRxejFWb3hjbHJSZW9lbFBq?= =?utf-8?B?RE00MDlJbUJQM0tNYzh3WmZHcUVSYmNUaFNjdTZUMDhtdzRrL1o3WDdSc3ZX?= =?utf-8?B?WEtCMTlHTUZpelhOR1FKYXo5eUl2d0c5WXU0eXFKMnFKenFYaktXQTBRU284?= =?utf-8?B?Y2hpYzdmaXNiTXN5UU1icERLbGloTHV5QUpneGRSTVltVnI2eTloR3pRVzZy?= =?utf-8?B?S2laVnlpeVNXa0F0aWZ3Mkh2d2RTaVFZY2tBOXppbUR6TkcyOGJpT2tVdWxP?= =?utf-8?B?bWsrWGZ6akFDUmdKRGRKakxhU2Eza3FDQmR1S3NRZnRWL1JLSjBsTkZjNTA2?= =?utf-8?B?czNUQ2Z1dENoMWdqOFdpSE5mZm9UYnNhOG1xVDc2ZHlVMk0xSXNKMVF3ak1r?= =?utf-8?B?S3hpN2JLRGJOSTFzWkEzVWlUdmc1ZXlva0JnWHJ0alFLdkZnRkkxKzZSK3Na?= =?utf-8?B?YzVMMENERHFZZ3BXZlRraUhwY092cGdzN2dDUm5DWWNydEE3eW5UV2tZblZj?= =?utf-8?B?RGJVWFl6SUZYZmRVakt1QUNjMmxIS3h6N3c3d2RDYVd4b2Q4aDlIZTJpWUYx?= =?utf-8?B?emNJTFBtUFdZRHVZaDZ0SGFjTnB6WmpRcmF0UHNPRXBkUXdTNDJyOTRuSHc1?= =?utf-8?B?MHpsa2o1VjVIMVJrcDRIL0ZXOXhzQktQZTVBZjBBV2daeWE4ODJ3TnB4R2hV?= =?utf-8?B?NHc3NFZVckIwcldON0FtV3BvRUp0bEdyUW5lZDI4b2czMlhhbTUrbkMrc1ov?= =?utf-8?B?OHJaMjRTV3p2cDMrRWE0S21lbFliMExLeURBeEd5NUxveTY0ZlNhdUIrNElV?= =?utf-8?B?dVoxN25zR0pqeHZadFMyeGVBbng5b21aZjVqRklLUlB5cDdUbGhGLzN0V1NY?= =?utf-8?B?MW5DNm1rTFdrOXhPTDVZYmttTC9mbTJDVkF0S1JoZ1Vza1F3ejZ2NTBsOEMr?= =?utf-8?B?dW9rR0ZaVmUzN3JjZU0yK011MTU0UWY5amZQenZpaHBjdnUvdG1YYmp4YXVz?= =?utf-8?B?bjFabDBEbjlDUXRMZ0Q1MEhjeFNCY0dtODBYRUg0cmxqKzk3a1VSNmJrdWUz?= =?utf-8?B?RS93eTN1MU0xY1NxdEN2MmtYTzZ1U3hIYjFJQ3hnM0doUWM5bXF5OVJaUTdx?= =?utf-8?B?Ujg1Q1FKQUlUajJjNm5LSmRJZkR3OFVyZldmcElhaE45WEs1cC9VbEQ5YlVN?= =?utf-8?B?V3ZkSm94ako0MTF3WGluaUcreVRtQTErWUl1K0h5Wmtlc3c3NUtaZnk2c3dT?= =?utf-8?B?WnYrMTQyazdSMzhSZ0JDdU9sQnUxSVg1VldZY01ueGhWSnVzc3cvZUxsMjI0?= =?utf-8?B?V1g2UDQ0SmpXYmd5anFEMUpOenA0YVozQzZPWWxyVTZWM0d2citRWUM4SHkx?= =?utf-8?B?TDByN0laRGpDZE5ETWRtNm1CdnJPUXRISDBCN0V1Z21zQTNQQzliOFZLTkFR?= =?utf-8?B?RjRHaU5EK2l1Tm5JU29sNnBnNlprYi9KQ2JrQjNWbGVvRWx2RjRoOS9HUXRw?= =?utf-8?B?dWdBbkd4UktvdmpqbG5HQzc0dzR3enJyTURuUVZVQ2JTSnpLU1lnTFdUYnpS?= =?utf-8?B?L0dFQTRzWTRJV1lPSnQ3NkVSQ0ZnOWQwSHNXS3k0NG9MOGdLd2NsZjh6MnUy?= =?utf-8?B?QmFObHJNbnpCSVpLZHRENllnUHR5R01kQVBPZ0tFNXhUQ0lyWkgwayt0WDc1?= =?utf-8?B?VktxSFVBSkpPSis0ZVJQRG5vcllYQTJLMWRXWWNLZmxuY1EyTWZBMnNRTTRR?= =?utf-8?B?TmhGMDJKWjRTVWlYT1drcEUvd3NYVGovdDlhTUZiTXFDWU5kejMwQlhtZVht?= =?utf-8?B?dWx0N2RKR1JsUmhNUVdERzJQQS80Ui8yNE1QVmJqZEt5Sm01YjM3ZVFNTFBE?= =?utf-8?B?NmZ4WDNITWdEOGlVRTBJRk92NklQTitVK1h0cXBGNmwxMXV2Q3NZQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bad065f-afa7-4d8d-9453-08da2f47a87a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 10:03:24.2916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NAbjLzQl91K1aQhLm1wjmvm2t/6VFLlO1a6IqOBJvHB+7bAcPgoL8o3Jcy13jL88TE68vwSW/66Lr+f6m6xnGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6833 On 06.05.2022 11:42, Michal Orzel wrote: > Function unmap_common_complete (common/grant_table.c) defines and sets > a variable ld that is later on passed to a macro: > gnttab_host_mapping_get_page_type(). > On Arm this macro does not make use of any arguments causing a compiler > to warn about unused-but-set variable (when -Wunused-but-set-variable > is enabled). Fix it by converting this macro to a static inline > helper and using the boolean return type. > > While there, also convert macro gnttab_release_host_mappings. > > Signed-off-by: Michal Orzel > Reviewed-by: Jan Beulich This R-b applies only ... > --- a/xen/arch/arm/include/asm/grant_table.h > +++ b/xen/arch/arm/include/asm/grant_table.h > @@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) > #endif > } > > +static inline bool gnttab_host_mapping_get_page_type(const bool ro, ... with this const dropped again. As said elsewhere, while not technically wrong we don't normally do so elsewhere, and this ends up inconsistent with ... > + const struct domain *ld, > + const struct domain *rd) ... there being just a single const here. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 10:13:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:13:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322871.544327 (Exim 4.92) (envelope-from ) id 1nmuxX-0005dk-TG; Fri, 06 May 2022 10:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322871.544327; Fri, 06 May 2022 10:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuxX-0005dd-QP; Fri, 06 May 2022 10:13:15 +0000 Received: by outflank-mailman (input) for mailman id 322871; Fri, 06 May 2022 10:13:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmuxX-0005dX-3J for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:13:15 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23c86e23-cd25-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 12:13:14 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-dCmWwwOrMOKOdWYPf_NhEQ-1; Fri, 06 May 2022 12:13:09 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5109.eurprd04.prod.outlook.com (2603:10a6:20b:a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 10:13:07 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 10:13:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23c86e23-cd25-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651831993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4yn/mjopIcsdwKCI+lQ+IMj95fSkjNZVLS4gd1rMHn0=; b=fx+dcz1V32d3QdNZCKiXjjSPrwoujb6ifJwxfRa398aE9TGM0SuW1vfDuPAkDqeEce8yLu J+2M+bcIvT5kEZO38ocP2GB5vV6zbH8M8YAD4npMszFHiaAw3OoK1MQYl1zLtRdpdfvE6/ agbXJFme/+gYvEOIeTbVZB+OtWORvfs= X-MC-Unique: dCmWwwOrMOKOdWYPf_NhEQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwB5tFTHBfgR7CClXhM7sSvtukjUaBneU7FV6cY2is85f5HQzfrCLYQ6XON7SMe1B/8C/Y2N13peXWicpoOCUi/JzbduhxNbggJZhNbw/i/kyqpdm2L+sZOtml4pev6SsRvRaF/uKb9Elgo2ucm8lob4CPWQs7DcPtmWYKOkMVrml7RjmaRtvFQBO8au048IcQBv9XYm4B9Q9yqxZH6YuJhnyq5MOHsltxY4Sdn6fXuOR6ppcra7amzTWLLNP3TzrJ1YZufLRw+BXhWuWHIuuEIiBWhOLIhGIU+Oo2nKR3/PP90ub4rsMUY3U3Yc5lKIVqbSoGTo7dQKAzNM81kmSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yn/mjopIcsdwKCI+lQ+IMj95fSkjNZVLS4gd1rMHn0=; b=KOtukV/OKzJsV38kdNVA+EN8lVn8/GKQjhlIMcducHHhkqlJ/38gbj1tY7IOy/eUjip3V6SKXDWBUY4yG9hQ0l0CSl0bJ/k/4Q8gTSAH1QXa+gTl5Cdre3dW1XmdPTQGQ1WhDKmN6CSgDecf7Qa+angFpdB/1vpSoDXT4yQ2xXWsdcZtIUzwZRO+5GvoD+pHX1JdlySVdTYWeBPGAs+Bvd2TLmKOj3BMc7mQG3aH8+yFUBgsuIr/I3D+qnXTE/bK98d0e8PKiO9uRqg+Roh2cnZylOKryz+3QIoYxwvKvdXU70w2pzuZlHaeQ9aMf+N5ZLYm2oCZzVqyeAzpXVZt+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <387bcb63-f9a7-0032-bcd5-088b65b9c10d@suse.com> Date: Fri, 6 May 2022 12:13:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220506072502.2177828-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0356.eurprd06.prod.outlook.com (2603:10a6:20b:466::23) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 571a1230-d970-4a26-c864-08da2f490426 X-MS-TrafficTypeDiagnostic: AM6PR04MB5109:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /gL09UHpH0efU1eqmym6FfWwAbOisqZzhOtbh3yrY7E89edyRXoK+nEbLp8fD82xUOMDYlYvg3tPUYlNunBafp28FKIOKfLuHxOTvxTNUIVHBi4O2zmaZTuT8u/zrOM6KbYhh2do1c1pJXpZdZ4W1zJZ2YCJcCZHHkcMyV2cDupiKQR646RnFZ08Qy66SAMEqeTixC/FvNj5g5Cam8IPh4z4DlLVDNmcPuXhwZyK5BGbiMAWWykgNPmszf+MRHDCF64infQpXNHWTm7l+Cd0G+Txl6WmWeiNFsxgogRtaw/FaVJV0mPK+ZywWJXJiUcEYpEwWlNSwYKzB94Wv0mqSLYv6GIoAR5YdBYkazPstSEU6FWDRiK5qNZnOAgGBJx2F1fw/D9yUdizsslMu0u09KIMLUUqUZDn6yteCGf/Qa0aelWvPEne/jX/6DFUHwbdlUgf02s/2tTUSDJm4iuVeGIbS1KnzUaa5mh8KMBQOuB9Ct4ezGwRQixEQGopOqJ882QdHOGgnHMt/Is2ahHEn7fykdFZI2ZGgD2S7FKtQKRILpK7zLyosx0cWeUGQwVqjwe2yF2YZgH5HQufES0NcckE7xWzMbCBXRRmGolJEJg/q9jccwSDuRTp/WZN9TQWSbky37AuGlEw07FQwFupvV/Lers7eP6JFfsSL+FmSSQe4TAV6anlf/SvmkqsoDZbAsh5bCw27QN3ajEKupyhlSLSzGJ7XVpqzcuwqyzuprMxIlTIvjKidNYVFoC7A6v+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(6486002)(8936002)(186003)(7416002)(5660300002)(38100700002)(66946007)(66556008)(31686004)(66476007)(86362001)(6916009)(316002)(4326008)(2906002)(8676002)(26005)(31696002)(83380400001)(508600001)(6512007)(36756003)(53546011)(6506007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmlsZUpVL09FWGZvUnRaeHQ2S09ublpoWTBneWVhajZkUmo0bE9nWDFZSURT?= =?utf-8?B?ZEdkaEYzalBVRWJmQ0YzdWE0dVdVOXE0ajVpdXhncW5yOWtFQVlKSFE5b2ph?= =?utf-8?B?ZTVsajFQcUk3R0FvY01lOStsTitRZG9jeDdEbWNSYkhDSHBxeU40SFdiS3Vo?= =?utf-8?B?TU5IWjJBbXo1Q1E2eitnSHhSRlRzU3ZKVnAxZWQ4aU1STkVxRXVsMk5kTUU1?= =?utf-8?B?bDRYUkk2Mm1kOGpsMGR4SlJhaDB4Wk9QNk5xMmVBRXpaT2NUSkhOOGFBSlNJ?= =?utf-8?B?bXNXNWQzbitGdHJ0TlVLSjZwR1pialdKVVp0SzJLTjRoN0FTL1d4cDFNTkdo?= =?utf-8?B?RTRRSjV3RkQ3MWR0VlpZWUJSMlBPa0JLY3g5OWtqSEtsa0tmTmpQL1VDV2tC?= =?utf-8?B?YlBFT3JqcTN0OG8zcDdzUVh4RmtsZHQwOWFCM1VQd1hCc2RPeC85a3dDSGF1?= =?utf-8?B?S3NVZUwzWG9Yb3FMNHNmSjFkWE5adGIrZjNwVGF5RUxBSXRmQTNNeEV0S1p6?= =?utf-8?B?ajBPQ0F2Y0ZSSzZxWGlPQVpzZm15cWZXNzdzdWptUGhLcHI3WW5Xb2FNdDFy?= =?utf-8?B?WkZiSGc5ZTJtbzVjaC9XZTlEazFjYnJ3MUpiQ0lCL1FLZHFnTmxIaGpjak00?= =?utf-8?B?VlUrSUJUU1hKTzNCRFNOdFZsWVdzRjVRSzZML2ZaS0hWTVZ3VTkxSEU1Q0sz?= =?utf-8?B?QnF5TStrckxVOWpzNC9ZYTFQYXFyMS85bjZCZjlKb0R5R2kzS3ZKVTNOamRp?= =?utf-8?B?bVR0NW5rbjJYRG8zVVAvVU95YUtpYTZaamR5NTAxSHU0ZjdkdExQa0ZUTTVK?= =?utf-8?B?M1N5UjZKOWNIKzJ0a2tpNUVPcDF1Uy9VQ0gvTDhGWVcyeUZtTUV4bXJ4YWxr?= =?utf-8?B?cFlKTGFZY3BFOG9pOW16M0FoNUxOK3A2SGlUNEJrUnZTZzBUR0J1Z1hrUFlm?= =?utf-8?B?L25XNXBpR2RTUTVIVVNUZjcwU1Vsb1Z0ZVlrdkxmTVN4cmltZVkrS1VMRjhM?= =?utf-8?B?Sy9UYkJiOVpCTVNObkdDU245Q1V3MENWKzlTZnB1c09pM2lTV0dZZjQxaVoy?= =?utf-8?B?U0pkUDdFZWhCN2VxUmdzbkdSeXZvYWtpUk1Wbm5lVld6T3JXRDNzbVFXeThU?= =?utf-8?B?ekRhbXA2SHNxM1VXa3R2MXBsbll5bEFmenVVRjVxTllsbWFmQ1owNlArU1Ir?= =?utf-8?B?WWpvR0pzRFIxcURDQndpbEdYMko1aXVUa1ZiSE5IOE12ZlFMT2RqbXJMOC9C?= =?utf-8?B?WVIxekdWK29PNWxmWDNaaUdhSEYvaXlQK1FVQ3U5eUI5RFhQUDVvZ2owUS9q?= =?utf-8?B?K05OSDhlb2c2RFI3WkhCVDhmZHAxc0xMRkpiYnlRRmRZdUs3d2R3QUtMTEJi?= =?utf-8?B?YldnK1JoYmdZMVBoanpMVEtiVzgwSWludXJmOS9ENWFWWXFjd2E1RUJYMHJI?= =?utf-8?B?ZTBuMkVDS1hxajJ0S3RFb3RYcVVFV1Y1QkZnZUZva0ZnVC8ybVlCbDFKWmRy?= =?utf-8?B?YUNvamFhV1RTci9IS2ZIRTlGd24zeWRSVnlBZDJjbThxdUtwbk4xb2VFaXVG?= =?utf-8?B?MnB4OXNrRVVWWDhQR2k4N0J5VlREaFV3NnR1N2tDREcxZytMNFJFMktvUWtH?= =?utf-8?B?SzZRY0hjWmV6U2Jtek9WWG1YMzNwWkxidFhsanJSRGtyS1lPYmNzZzJON21w?= =?utf-8?B?ZHF1VmxFdTlxak4wTmptRXdtRGRISzd5RGlFVkhGOGVOOVZwd1dBODZFRzla?= =?utf-8?B?cDBCdTQyNXIwamNrZ2VsV2FKVjh3T1dDWkNBb1VibE5hOCtpOXBYL01SdzZP?= =?utf-8?B?emE5T1MvSmxlYS9GWGZlVWZQcEd3QTRNQnl2S09yUUZGWWtNeWtQbENwWk4v?= =?utf-8?B?b3VTa1ZDZ2wrZ0dneVJsanNYWU1oUFpZUUJsVG5iSFM1TnBRTEcrVWgySVRQ?= =?utf-8?B?d0JONHBZZ29YeTFBYmREaW4vZGRGeVR5SG9xTS9vTlovcTZ4b0s1US9oRGtK?= =?utf-8?B?ck5yOFVEMFNnOEFMSkR1dThGUTdnS3psa3o1UTFHMU1iQnFsWVZ3VmNZL2cx?= =?utf-8?B?ODI2OTNqek9sN0NORE02S1FwNTFqZEFqcytQTThKb1JFb3hVSE5VOS9RZGpL?= =?utf-8?B?NEZPL2UzdmxLLzhTaDlxaU9CZDNQaDIvMzgyTjVzbEszVGNHb3FYNVlSTXR1?= =?utf-8?B?akR1TktMRE1TUWdlTmhvSm0rRG9PN25QWVNmU2tvTlJuSitwZlJNU3hwRDFK?= =?utf-8?B?eTA5RlpVbHhjeGtYelJOSFJ0QUF6MWJ6M3IrSjV4QklHV3JMZzlPS0ZBeS9o?= =?utf-8?B?QnkxUTVUV3JqTEpYaVIvS2hFTUk5bTZqSmUwS3V3dDQxVVVuSDdOdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 571a1230-d970-4a26-c864-08da2f490426 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 10:13:07.6521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2JqP4dqW5/GtN3SI80IXpIMPMSeUXRGY/tjiBkGuZgfXX+5vpYtMeD4pguKR6sCpVb1LRJskz14qbKmXOaRwdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5109 On 06.05.2022 09:24, Penny Zheng wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -777,8 +777,22 @@ void __init setup_system_domains(void) > > /* > * Initialise our DOMID_IO domain. > - * This domain owns I/O pages that are within the range of the page_info > - * array. Mappings occur at the priv of the caller. This information is effectively lost; I cannot spot a suitable replacement in the new text. > + * DOMID_IO is used for mapping memory and MMIO regions when no explicit > + * Domain need to be specified. > + * > + * For instance, DOMID_IO is the owner of memory pre-shared among > + * multiple domains at boot time, when no explicit owner is specified. > + * > + * Also, DOMID_IO is used to restrict page-table updates to mapping I/O > + * memory. Although no Foreign Domain need to be specified to map I/O > + * pages, DOMID_IO is useful to ensure that no mappings to the OS's own > + * heap are accidentally installed. (e.g., in Linux this could cause > + * havoc as reference counts aren't adjusted on the I/O-mapping code > + * path). This only makes sense as HYPERVISOR_mmu_update()'s and > + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument. > + * For HYPERVISOR_mmu_update() context it can be specified by any > + * calling domain, otherwise it's only permitted if the caller is > + * privileged. Much of this looks to have been copied from the public header. I don't see why you did this; if anything a reference there would suffice. > * Quarantined PCI devices will be associated with this domain. > */ I would also like to ask that you add the new purpose of this domain _below_ all pre-existing ones, such that this also somewhat expressed how things have evolved. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 10:17:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:17:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322877.544338 (Exim 4.92) (envelope-from ) id 1nmv1l-0006LF-EZ; Fri, 06 May 2022 10:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322877.544338; Fri, 06 May 2022 10:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmv1l-0006L8-Bd; Fri, 06 May 2022 10:17:37 +0000 Received: by outflank-mailman (input) for mailman id 322877; Fri, 06 May 2022 10:17:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmv1k-0006Ky-0s; Fri, 06 May 2022 10:17:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmv1j-0003zi-Ta; Fri, 06 May 2022 10:17:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmv1j-0000xy-BC; Fri, 06 May 2022 10:17:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmv1j-0005Wz-Ak; Fri, 06 May 2022 10:17:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BFYcSZ3rQlK8XlSOJ2KO4PWQvwj+d4EoYIHZModjF7c=; b=52MJ+xNUyv6D/PxS1fNwj2mNJQ I4Icazm4gPytmLfVknlwPJdt08rl0/dUrIFUiYDuWeLxfYdpZwt1qzoD6LHzLYr1/ArdM1g8r3RDY dwSL0X9dF8ZY/CXsmGDZaFGW2JJi/G1JsaQnc+WfCphscGKCVunDLpp7cUJAgZLeleR4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170162: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e91b8994115d2f093e7556c9af2d051a26a98cfb X-Osstest-Versions-That: qemuu=5d5104260222cd7ffaaeb555727808f479e7103b From: osstest service owner Date: Fri, 06 May 2022 10:17:35 +0000 flight 170162 qemu-mainline real [real] flight 170176 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170162/ http://logs.test-lab.xenproject.org/osstest/logs/170176/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170176-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail blocked in 170150 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170150 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170150 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170150 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170150 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170150 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170150 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170150 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170150 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: qemuu e91b8994115d2f093e7556c9af2d051a26a98cfb baseline version: qemuu 5d5104260222cd7ffaaeb555727808f479e7103b Last test of basis 170150 2022-05-05 13:38:31 Z 0 days Testing same since 170162 2022-05-05 23:08:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Zuepke Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 5d51042602..e91b899411 e91b8994115d2f093e7556c9af2d051a26a98cfb -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 06 10:26:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:26:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322886.544349 (Exim 4.92) (envelope-from ) id 1nmvA7-0007qh-CW; Fri, 06 May 2022 10:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322886.544349; Fri, 06 May 2022 10:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvA7-0007qa-9g; Fri, 06 May 2022 10:26:15 +0000 Received: by outflank-mailman (input) for mailman id 322886; Fri, 06 May 2022 10:26:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvA6-0007qU-31 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:26:14 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3f53cd8-cd26-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 12:26:12 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-WZR22LKOPh6taO9J-Gn2KQ-1; Fri, 06 May 2022 12:26:04 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by HE1PR0401MB2505.eurprd04.prod.outlook.com (2603:10a6:3:7e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 10:26:01 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 10:26:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3f53cd8-cd26-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651832772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fbnpP/3egBtL4ZVrLWoaM3TVWYCSmK5xk+Mr3WSUwYg=; b=nmFxS/Z6cM9gvPEem6fKCcQ4OchEBaalDm2pCO6w2iCNs/92oN4/a2B3Y8+yVZfkQGIpWy QkrMcUr6wfvnFoYEAHXMNv4xyWt3uLJGlBpCmvvJJaqpHvDA61ACw/BUz/q5V73vtk7ea4 aHAdpIOprsf/68JpjFbc6iUoM2U+w4M= X-MC-Unique: WZR22LKOPh6taO9J-Gn2KQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/BCjMHi4wzhCBqahURwlrO/8DC3bteRpDOekgrehIIxx2U7MF4mG+FfeZtTuy0eyEnMtwkwRFPcjmqOW0y7hoeSbCfhFzjt/hfKVgol0eqiMMjQ+3ETg8OTKFcqK9jTfa2JK23mBHxdrdJcBSYHv3RgGL6TKMyGkl7LnJmBZGxxDI0PRf8C/w480W2bPF0f2lbeeoJtB2DY04CFUnf8BU2aH/3FuL43D6UNehTasKEDEUZ7mgLSFph5uMRCGsk8sAcUEXGuvLsiy3oe+Yi7LQ4+On+J0aAdnJgFf6b8sVBoO4ydzmGmzB3WSiWeUgBLQic8yRlxqzNlHN/R8R8nKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1/HN3TYj6xdaitfmXgNazLjDH8rKKK5HfSedp9HooM=; b=PJKEpw0Uer6/2eO6+L7I9BTZOLSR0iCtr3+enuqBsCGOpecugTkAHomt0C37mCg3Dh0aFN9hAvhfD7PRRL5txBNrgqwFGKXdem24XjNT8DKJdSYptdb1+ymjoMUCbyoRG7Ai334OwzAxp+vp6oKFRbVS5In8pF7OBc+NDd+1xkHEie4HOkUBKUrYCbPRWC2MF6yIccKSntybFyQGEUbfT43PLSaDCQNCHGwxWGv3ZdR/AH1swU7jOf8fyXf82RpMZ4vUgUUjz2Vw7SOHRe/aMvOykOYlGP/rV3BJPOAurGGh0uYS3NzlDjOWzb/BiMhUIFRaLP5Cw1zBOOU/fgRidA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 12:25:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505142137.51306-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220505142137.51306-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::23) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ffc7f0d-29ca-4a19-6937-08da2f4ad13d X-MS-TrafficTypeDiagnostic: HE1PR0401MB2505:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vyzZ3dutDQNiUqZ0XtrZguROcpNVqy8QOhsR2Pyem7WQ0879LtrPwTiYYnLcwx1nLpBcomQuFMksDmpicuFK7+d1kE0ysLO94VHSzwCndoUkMy5BVo0M2alTXyQRBpYwe3lBy3DUVGX/oefBd99NcIaY773zcV1GGlvhobkaXNJEpmDZVkAq6OXGWIghtNlsdE8qb/yxlETPbizJ31gvlblC0LSLB8+tOKlhWVdaAARHZY2NocdRK2bLLpXKJoTHSeagP4bJ2wLEYSOBXNy6ky2sJDPHHVtLe3JkjMZ+lVRj7hJTyIk/Ozb9KR8H2z533Y4XnQb3lhn8S5683jGs2jNu0USbzq7fJoR4z2AKxxxMTUisA8RsYOL/91IDO/SjIQ135lQxR8/dBXmtxBkrIiEsprshkGhaHrUS2ZfYMndrV04OOVGVtYciUp/m4wAdY1cvW+gLCVbJ0PjaUDmokRjJCXYeA+Rb/VSUYgL0DkxRuRS1RzRV1THpvMQkthFCWiU+s8Sn8vszx6qYJu4RJnpxMoinAqGX9stFdmawN9iqY+C5Gy+2ivIySW4jbcLZ3gIIe1Tz6ZxWvHUPZnKaDDS0FLNRdR+O9a9r9EPY1aE/js2c5DOKDBfG6vUEKOo5rDW2S2UkmWRQOGzHkrw2Dw93K8y9Hp6wziHTkqyhsKZXK7nZUbKmju9aQRwA0X5EdtHBs6oTXj0jlGWwgQCHJZbNAPQd93IV+8lgzdXwYyk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(5660300002)(66476007)(66556008)(6512007)(26005)(53546011)(6506007)(4744005)(6916009)(36756003)(54906003)(2616005)(8936002)(186003)(2906002)(6486002)(508600001)(38100700002)(86362001)(31696002)(66946007)(4326008)(8676002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LJJgRY8TxdTi50rk8dtfJbsCt1vuEGbPj9TN6Gk3sBBT6qwv35U0jkutNf8e?= =?us-ascii?Q?EeXDRik2aJpzkK5cPlXF+h+nXrayui6SO2W4goa2tajXk4guFZyZtdKnmz75?= =?us-ascii?Q?doDT7Tt0x8gEjk6fuBZxq7UlvH3fpZsyb9b9oE3cntWi9KSBeUlbQVJpNylP?= =?us-ascii?Q?FoWhppnkW1LFHe0IcsooB3xCnIDsiMo4dPGDCCDW/rvak5a1Cb2MjUtd1+eA?= =?us-ascii?Q?4gi/usg1Ka47NCvLohljnkyCMD1ToyUqNshcIZCWIMZygKyq4i3dQLsBXmIK?= =?us-ascii?Q?RTGJtZQ/4tAFa4VhjPAG8CgRfpgjigWMW0gTFp40xJ+MUIlApICiunV6ckPW?= =?us-ascii?Q?NZv98VE+ORoLhblx0IQpOTxuZP4ta9zBBYXP5aiChnKpVWDektLlTzfUSyai?= =?us-ascii?Q?CThGk+GonwuCLXJGZ8WwCuampjolFdgIjCP5sQtjbZil72IUWAYGBXIkyMpI?= =?us-ascii?Q?haFeSGU87dbwtI8szUjMtewEqtpy5TqgvBk6o3cmZkf+trWiFm56jfwgnIAi?= =?us-ascii?Q?zZwYtX5LTjmKNwSOImaq+w6n8U0sFLSKvZHxqgw+FnGCxVJ75X3gTLxtykDf?= =?us-ascii?Q?5drBFX5lAj7GmKjDMiNg8iNsLHV+/44GKh8QEuKxC6gpPzGUhpaDzCDBakVg?= =?us-ascii?Q?PJ28WoQa7YOEQgXBLYvdkNRtehVjB5p75beTyHSvYlg8XiGvqpJgkdV2Yrw8?= =?us-ascii?Q?MWjPJ7VgUYfXsBmoO7XnVHyR/nvr0xQtki8izoaQO75viMMg9Zo6mAR2DKck?= =?us-ascii?Q?NOrRpGFRLMH5P9C9d6YHXHHReMuQcnNk4sNnrFYt9i9/lHLWex0UgRm3FQRg?= =?us-ascii?Q?X2Kec3M7UTZpJcmAsJfvFOQBCUn3d4KjzbK8MFE9a+IjMO9jh1ZOgb53cvn8?= =?us-ascii?Q?u6y9i/OG50tAnf3Y71/LouD09ITFaTFbEbcFjnQnDnSSECkJcnKvBBdoi1xM?= =?us-ascii?Q?BJBtF4bZd6eZdcTUFY3WoPTpP7giulk1lzaZElgvEiNquD2EtEi/SF5PMcon?= =?us-ascii?Q?+q+kyeu9uiRcyHWAHqCIUvqhISyx5ZAwGH3ATfvmPlaWu97pm8wrKqxOuymU?= =?us-ascii?Q?jQgKpdx02xW+NSzMtgi3AgDKe4c3cggrhhqScB+PN1XJsUYoLCnUps4ERojz?= =?us-ascii?Q?ZFHPkviaNPiB6vfwkTd0boTow0pbiFGE/Ie95ncHDgHZ8+qh+c6jsxfemiLd?= =?us-ascii?Q?6ilX8EFAYZfz3xBYC4WDw4VLpZ4rK/rDcT1f49pk9d6P4vvplvuPIueW1h3i?= =?us-ascii?Q?NEPoUz/d95ZMp07TGbIdmQSZtcEQTN/XV5X+12TX4Hq723Vby3XJbMMh83Ob?= =?us-ascii?Q?ET+8n9Vd+soJaYiq87Jrfs+zOg31nRv84t3mE1zq0AU/dqXA8QTvMusuAz5X?= =?us-ascii?Q?PozrfBGGNFO3wGP7TncmPCR0ofC0BfF8quXGolMTee+83UZPwjdV8wIXOZ4A?= =?us-ascii?Q?xMNf61JAg5w48iKqpoEBBZWsMZ5xQ1u0KS+1ujOkafFJg8/WbwqXL060fAXh?= =?us-ascii?Q?WqGjfYCnggcAasN6ofB0hqMPNlYMsk1WCh5vWhrLWfKhgSQvm7h22sbp+DGX?= =?us-ascii?Q?Jt4bBgtCg1CO/RHV8jQqVl7WSgFxlUPvOgUeMe6VT4ficSLxRu5e5CvnY22l?= =?us-ascii?Q?f7yl1fm2sOMg7mx0lVaVkipG+Ob1Y60MQIO+je8VUdHmIxdNLGGXYtkHMKGi?= =?us-ascii?Q?ixOHU8Qs41Bp9MvJ5aKyqr0xEY15kkd4Z7nN5y9JPhOkjCTSBR5jv5wffGpU?= =?us-ascii?Q?XB6s2o3SFA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ffc7f0d-29ca-4a19-6937-08da2f4ad13d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 10:26:01.2144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lvXSi6CQozoeQRwcKYTy5PERSeg71nygIWYt8OVjOa791fII2gOl8Bhw6xNfWR8eQ2071GOiXSTWfulRw1Gm5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2505 On 05.05.2022 16:21, Roger Pau Monne wrote: > Current LLVM LD implementation will turn global hidden symbols in > object files into local ones when generating the .symtab of the Xen > binary image. >=20 > This is different from GNU ld implementation, that will only do the > conversion (or remove the symbols) when generation .dynsym but not > .symtab. Such conversion breaks the processing of symbols done by > tools/symbols. >=20 > Use protected symbol visibility instead of hidden, as that preserves > the symbol binding while not generating GOT or PLT indirections that > are not compatible with some of the inline assembly constructs > currently used. >=20 > While there also make the visibility setting compiler support > non-optional: compilers not supporting it won't be able to build Xen > anyway, and will just throw a compiler error sooner rather than later > during the build. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri May 06 10:32:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:32:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322893.544360 (Exim 4.92) (envelope-from ) id 1nmvGR-0000tw-2X; Fri, 06 May 2022 10:32:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322893.544360; Fri, 06 May 2022 10:32:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvGQ-0000tp-Vt; Fri, 06 May 2022 10:32:46 +0000 Received: by outflank-mailman (input) for mailman id 322893; Fri, 06 May 2022 10:32:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvGQ-0000tj-3W for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:32:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dd8e699d-cd27-11ec-a406-831a346695d4; Fri, 06 May 2022 12:32:44 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-P7C1Xv04M2qGnW4pGDcwJg-1; Fri, 06 May 2022 12:32:43 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB5825.eurprd04.prod.outlook.com (2603:10a6:208:127::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 10:32:42 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 10:32:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd8e699d-cd27-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651833164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FBQaB2sZPb208sBnZSPd/XKVkSsfPTM0ag6+UNZh5TM=; b=j28tnklILJ4O0E/RoW9ErrtN6RfE7tMdcf8Lt6CcFD0a0+ThajhJnZuOOu1kLzzYdqadkD LpjWEHkCFOnIMBUBj4RjiMGv+0c5xt5c9Hco61dP4I4ZPlQFHn8CTqXUBAcMDGm/vUZOtu 4EgwuiDm3a7SydiyUuukV9B8g5WGRmw= X-MC-Unique: P7C1Xv04M2qGnW4pGDcwJg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pw0B3evi2UOinBV+dqtVJWmb6CMYS/Xa9R4KKNF4MStljy7msSF4tQtY4GDbEj8Kdc/EWQ6bZIx2AYKTgvOr8ZccO+tIpST0mcNxbBLGW3L+EpkHnMoYsny6usvRAcbXxUARJvuiI4JNGKjEgt/MzFKHKi5iRvNI+coVsq5IQwbgu2u4M2oZWModkFMSys7s5aGgl0E9VPHtOF8+c5fIVzhKLNMw42PUTXZQJoNvWLCrIT81E+me1f1wujHOQzKU7pviNgPzTbLgD9j3vQC02pMyIvFtU1Ugsifc6Ogy+yE0FsxEXaodHWPGRd8EFwiQ8Q+ZVndw19yFLw7vW3zrrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FBQaB2sZPb208sBnZSPd/XKVkSsfPTM0ag6+UNZh5TM=; b=akcWXf7K0r/ZHmGdpK2r41KWlP/asRT1QBn4wUMINHmcHYMfcwEToHoXcwpEaQkZ5Bit/qOhY5FoqvOOHH0VNh6JMSba5nCOIsWPVO8HS3beipYbGywEqFgdjbpOOhqujk5n7d62QGGpOJ1Urfsh3FW9PaSE+7pegeV/iYSi1Kews+Kah+KKW9lS3ZPaE9bPD1PCpaq7b4G55EbMLTztLUe5pYZQggYoHVs02qiLPR4fMHOt9kYLTQKDJ3/7/hnt8RnjWLgepGnmqwJeUKut6X8VYl5S7OeCVQgKYHifK2uC/PRGLe+Uc706bZA3e3B3cRJ7pkmQJKKWzga4p/i0wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6a44bc43-c392-2eac-d350-ec87cb2c3ab3@suse.com> Date: Fri, 6 May 2022 12:32:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Content-Language: en-US To: Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Wei Chen , Julien Grall , xen-devel@lists.xenproject.org References: <20220506055201.999277-1-Henry.Wang@arm.com> <20220506055201.999277-3-Henry.Wang@arm.com> From: Jan Beulich In-Reply-To: <20220506055201.999277-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:20b:310::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5e51bc2-4986-4bfc-0484-08da2f4bc023 X-MS-TrafficTypeDiagnostic: AM0PR04MB5825:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: od3py4I0Hcnjg6u7j5iGYVWwzwcWswG56UtVXI6ch/JhPjUEPnWChgg49b9EdOm7JXjotSsO9mjDxX9wzDTSR04XeZfcZMq8Vniub9Cf1xlHWC1FBc9nhwNgg0AyRqqtGTjCqd56btfQfdyX6V2O5jGH7Ug+e5xt0lHLODJTGZhpOgAUecZG8/XY+kdWowM/0hgGRFpOttNUS0EqDbUuOLcM8MyuV5p6V1FM2KARiREzFZADByoi9wTqaMA2+UpPrCOinGZ2mrqSsfqYapis03ahfxbBM+ezq45QsuSMU4j4Uc3HniPbj3mfFqq+CdvgcDwIW4LY/g3eHIprStDMCVC8cW6K9YEpXlX8JuScbwElIMtuke/N+0g5O8Dqpi4ldrmSQSxFHDj9HwWm430ka3JNcWQs5y7ESX3QBt4PbXeZ7n6SFUb3sWfZ1iJ5tzm4ljnfSJB/m8Wm3svc4gY6j/o08mb2k8Mwb4NJ48bUhENKnK/TPCf4Lnp55O06PGhWo+1zG+zOQ+GHj3BZxdVvmUR7zVeXisr4oTBEAuKwcnu44k1n71pxq/IzIhB8gb5jhz+i960wyuN2f2oGjTE2GDVJYlMVZ+Ua3nC5uRhKy3sAH38yC7oXwXU85uNGVzHDFjTY7azQtZYrkf1pcnhAudb1rvphV/EATc3b//FNxDEqwYDr99WVAw+BwP47OGrsGuOVKqJ1yOK4mK7xV/5tnOgtvVS9SaIXjj4j2FMuwXg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(7416002)(4744005)(6486002)(36756003)(31696002)(2906002)(5660300002)(26005)(31686004)(508600001)(316002)(38100700002)(8936002)(2616005)(54906003)(186003)(66476007)(66556008)(6512007)(6916009)(53546011)(8676002)(6506007)(4326008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enR5TjQ2Y2F4M3NlUjdnUDRzTGt5SitDZlVVNjlqM0VTZHJEV3lrbFArcjIr?= =?utf-8?B?MVBnS1lHZUU0dG1UNzcvL3hZVk1KUXNVVTU3OVdhOGxBOUxHUUZxZUVuSVcz?= =?utf-8?B?U3BEeEdSWEQ5Wnh0L0hxTmFwa20zaXdRV2lIcDZtVFU0T2I5UFlybHRMU0p3?= =?utf-8?B?b3cyWjRFWHpFcmxxVmlnTWVPd1FLMWF1UkFKaEZPcDR4b2M5WTVqWDFmamM2?= =?utf-8?B?SGRRVEdBZjUySDhEY2EzOGdnOEpaRlM0SUJoVkdTcU9KVENmS0hGRjR3cmRG?= =?utf-8?B?ajd3MzV6N1AvNTRNK1FQWVpOSDNtQXN1NW51NWRuZm9uZC8waERjTEwreEFM?= =?utf-8?B?ZGFNai9QaGtSems1d1g0VngvZ05xMFpjYXFZQ2EvWHkwcmhoMUlNSzdyUC9G?= =?utf-8?B?L0VyMjNKSjA5WWJWN2haWEJuVURIaC9OUFl6aEhuT0FkbTFta0tIU01NRmQ3?= =?utf-8?B?VXF3YUM2Z0ZnQjhjbEl4QnVxLzIwYklCeEtJQ2pzZERXRFc2YUhtekw3a3R2?= =?utf-8?B?U2dJZmNRYW5nT24yNFlQRTA4WEpiYUJhZHpaclJwMko2YkxTYjhubGFFcXRU?= =?utf-8?B?WDBOTlpHdndCMEN4SkFkdk00ai9mSEh0OVMxbG8zOHlkd0NGbEl1cnZteVds?= =?utf-8?B?QS82YStScWJjWkY2SmZZZHNqRUF0QWZOdFU0NnozUUJhS29BdlFRK2V2enEx?= =?utf-8?B?TW4ybG1jeHhHbDFqcXJVejBGdGgwQmx4OVRYUThpaFpOSElZdy92ZWJWeWg0?= =?utf-8?B?QjdaOUIzMmQxVHRnTU1VdlJVNjBtWVVXSjU2OW5ZVWVRR3pOQVdwZmFwRnNs?= =?utf-8?B?REtZVHVjbURoWGdQenFDR25wL3Z3Z2lJMkFOUW96OWpGb0oxam94YmdBOEhI?= =?utf-8?B?QWhiUEtPSWxoTWIvZTI4bjRNd0EvUkZrVkFuQzZVa3pmeWNsSFN5aTFiQmI0?= =?utf-8?B?SjJSTFc3ZnF4a0VQeFlRN0ZXdWZ3T1Y1TVZyS3BGQVpCci9ndlRaam02WWhZ?= =?utf-8?B?aDNZaVFOZ24zZWl0bklYUGpVWWUwc0lqVkVyTGlzeGRIeTNvNUlseVd4dFRy?= =?utf-8?B?RzN3SS8zd242S25XREJPQkxyUWRJNE9HTENlUVBWQWEvd1NIU1ZZSmk5N3RH?= =?utf-8?B?eDFDOHRlZnpiZlc4TlJDR0Z4dm1FWHJUdmRxV0lDNDVBNmJBbDV5VVEyc0tS?= =?utf-8?B?NUlXWUhxMmQ4TlNjbExNbXNCc3phQmgveXY0dGVLSzVyeUg4cS9DVmdwd1VH?= =?utf-8?B?dXYxb0QxZ2Mvb01pZ3VUbHhSU0R4MUxRYVZaNUZoREEwSWNRMmcwQ2M5blZh?= =?utf-8?B?ZlFWMTVmRnZOMmljWXhGd09OUG5yMmx3bVI1ZFhFNVJBL2t4Y1pBdFk5bVBr?= =?utf-8?B?dXVMRW16K016a1BkNUFoa000Q2p1WEorRnNFSHNoM0wzVkFLSnBIYWswQjMw?= =?utf-8?B?WTJqQ0djLzAraUJINFdLS0l1V1dybnoycEhENFdPZCtmbUV0NnAxR2IvNTR3?= =?utf-8?B?emtGYmtYQXRiWTlIZjRuTW1PcGF0SThjTTlXZ3BtcFJSNllDeFc4UEdjTmND?= =?utf-8?B?ZmJYVmZoU0JZdGVCL1NWZVVQWUJzMmd1bHFXalRrQytwN3BiTGMwZWFjUVZ2?= =?utf-8?B?T0RISXBxdWZaM1ljbXdIb0x0RWhnbTBEak5wczF1V0JMMmJ4cTBKaUpQZFlL?= =?utf-8?B?NTFJN2JhZzMyRXRDdi9ieGlCMlNHWWgxZFJiS2lGYjBzZzA1emtMdDFld1E2?= =?utf-8?B?cEtHQUxXMG9TVHJQU0ZNbFE5cGp2VS82d0w0QlUrTnVGUkRXdkNCN003VUdl?= =?utf-8?B?clFnS1owcU9nY3Vydy80V203aWFlV1FNbDRPOGR3QU5DZjRhTkgrTCs1TGQv?= =?utf-8?B?Uk1laXdiblcvckc3dnoyR0pENGJoUC9tdWFsL2tFbnNMTFhQbjcxdFN2REEz?= =?utf-8?B?WGR2ZUxibFBMMlpzVEZQY2ljSkxvNXozNUEveEQ4bjVSQTZ5cjY2SlNWVTFP?= =?utf-8?B?YXV5NG9rd1lTL2lsZ1l3ZHpITm4wT0Zwd0RJaXROTFV1aHJmcDBZYXlyeWRB?= =?utf-8?B?R0JLUjZLMDA2aStlREpzQUQ4c0hHMnJNVWoydjZWT2ZPRXVRdXU2czVmV1k1?= =?utf-8?B?REtmT1FQL3RPSXU4Y3hMK2szKzNCNTNzaStSeks1UEJSY0hyT1lQUTBWMTJS?= =?utf-8?B?Z21hTTNjcEl1UTJQbFRDR0gyd2lEWG40Q3ZJS2ppK0JYMFZaSWd2WkhlVHJr?= =?utf-8?B?aU12dDE4YmlKR0VWVVJqb0R4V0w5VTFyUHNSS2FkdUJEZnRWS2xnV0pzVmgw?= =?utf-8?B?OWR6UTNabWhnR1V1YUpFdHA3K0xxdnc0cHpnZXpvU08rOWdQOW0rdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5e51bc2-4986-4bfc-0484-08da2f4bc023 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 10:32:42.0181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VQnl2jgsSDxekHjnRFaSB1smdlIony63JY0I2eljybI0os69nHYsyB8wz00b9SpibsfzHK6uCi2sj+e0kYLwOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5825 On 06.05.2022 07:52, Henry Wang wrote: > --- a/xen/common/xmalloc_tlsf.c > +++ b/xen/common/xmalloc_tlsf.c > @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long size, unsigned long align) > { > void *p = NULL; > > - ASSERT(!in_irq()); > + ASSERT_ALLOC_CONTEXT(); For one - what about xfree()? And then did you consider taking the opportunity and moving both to the respective pool alloc functions, thus giving even better coverage? Granted there's one downside to moving it to xmem_pool_alloc(): Then the early zero-size and error returns won't be covered, so maybe we actually want checks in both places. In xfree() I think the check would then also want to move ahead of the early return. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 10:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 10:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322899.544370 (Exim 4.92) (envelope-from ) id 1nmvg1-0003Wc-6O; Fri, 06 May 2022 10:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322899.544370; Fri, 06 May 2022 10:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvg1-0003WV-3e; Fri, 06 May 2022 10:59:13 +0000 Received: by outflank-mailman (input) for mailman id 322899; Fri, 06 May 2022 10:59:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvg0-0003W1-9z for xen-devel@lists.xenproject.org; Fri, 06 May 2022 10:59:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e092485-cd2b-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 12:59:09 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-s5J9htH7MD-Hvj3PNEPl-g-1; Fri, 06 May 2022 12:59:08 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PA4PR04MB7919.eurprd04.prod.outlook.com (2603:10a6:102:c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Fri, 6 May 2022 10:59:06 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 10:59:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e092485-cd2b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651834749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yHgJ52YHejUk3gYauOHYjxRwapqI9poP6xLYhR0n7V8=; b=TNuUfvdrmk3wvZ9SniNVSKoq4WyGfWyfaCyuJZaH9tY03i8VZDDBWOA4W+U0HbZXovMWIZ PWu7J8ENG4tBJMGAe3zt3IESiUTtEp1O9U62sb58q3zO+G0yT327R/6yFv6YTl9HylXUTq 8sn6d0S+JonZBmj8zYuQuhSlSKa+ooM= X-MC-Unique: s5J9htH7MD-Hvj3PNEPl-g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVIjcMKZdD/xdE3C1BFY1w8rgOIul7IF/WEbKthxPMpKSe2kxJ0agnQf7YMO2yQAA/o2zrmTXljauOxUxLqwBEZ4UWw/7yMrzeuuqJ+m5XHXRMaDVgxJx5G34mMrOpGlXF9DifaYCz03R9PQOE/qs0beSL0WZAdpe2wH0sKkIRGzIyPMkSyDvAVteMogN3/BtCBH9gtri0J+cyHEIvi1V7hLtSDb1IbSIIQS8GHd+/HZUzKQEQfmVGEjohNLlqkNOR0315hwXOiMW1KaQKbfUcjOiqGwMXrgt2r1818j+rdDxpDdhknpMlMU4GS2D7NnBgP5td5YWwzX3ad+REh3kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHgJ52YHejUk3gYauOHYjxRwapqI9poP6xLYhR0n7V8=; b=eFSjbQ3MGpgdLuXMNl5Ubazwid0hV/Z9HZJVMzTUP3ZcKlUIU5T4IWKQhIWY7tWmR6mzv282u3IeDvAp/18k6geNFQTq7H7pv/GkeJUq521B30uaE5+neMQVnpOfYdBQHXfuf6MBUPyknQ3uOLO3aoyOSR+Ikh/mY8WjZiDKMng9q0QBxreoO3xanz+7SCVqjwUsG0lGZeEFoNwm0hEZ3TLC9Z2Z2dpuSneMZLO2KLWqy4NJouMNXuGwV0eZhy4ywm2HCDvAvpikN9oQ1LuGY5qIwgLqMPRhz3YzXbvtheHxKj0iBGRaMW9Q42+8BRURLTMfZOdiO0wPViHk7yoWeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 12:59:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour References: From: Jan Beulich Cc: xen-devel@lists.xenproject.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR05CA0003.eurprd05.prod.outlook.com (2603:10a6:20b:2e::16) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cb93258-8f15-46bd-de65-08da2f4f70c5 X-MS-TrafficTypeDiagnostic: PA4PR04MB7919:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lNRu/hDhOCB6ZWfeIsVLrzuwmkzeY1cDZZbcn1nP9h3jtI94h7/ctwfJ+YbXXYdI+HhWI5R6QPTE3tTIHgbQIw//tNhJJL2a0/nQS517EfaAy5kIEc+2JjOrs7ckM4AKnJTBq8MaPhEnq22dwCis/5B85Es1FV8xY7FxqGkwQ+OLaNF4YPAyiA5sZn3I/9n+OidbmbbCuuauz9z9niOEuP1vLRmyYStGzfJG4UQv2qwPh7T43dGA6ziHRFBXFC4DBXu6j3TH/P/kUmNcpkEBK8vg+gcAWNizIvqvhC0UJDxkgyF1CUuvrY6EW0wdhnM4guxvrhlHebW8iA/H75fvjWdtOqwFRN8qKyxHCYlrpM90pXvbaEdedIe9Hp2aGdRowPEIKnpDjQEaaFRVnTmg6t4ZhJkQpCSWy2l3asNZj1KCOnQroUNNQmmlUuIdTlrhWfTgCbYh686Wzw8RFp+FLyl7oZsQu0Aq+70k6Ko3efpt7pirMG5pc1lJKpy9UifaFDD+J8UA/EJCuyuZGFKb+UO+ZzCoLmxT/wTeCa2zq4JugY9sR4TyINumMmr8GtDdN7rnBaRhYX9fsAEefVxy2pXzKgW38R02fqMv118x9JfGwT9KHOPPNu4kQ/yFz8yDCUdV2IuBYjJqm/Z+z+DsK7J7kTwGwwRYkzCEJTW8pxSIGI1Sn/apYTM7hVErPB7Z8t6cRZYqW8Rq66YZf6enNUpOwXZZs6AAJootK0jk4z0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(186003)(36756003)(316002)(2616005)(508600001)(53546011)(6916009)(31686004)(38100700002)(6506007)(8936002)(83380400001)(26005)(6512007)(6486002)(2906002)(31696002)(4326008)(66556008)(8676002)(66946007)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzZpMmNtQlB4R0k2SXJEMkxiRXRYTDZKYUNybWw5c1A4ZU1sQnVxUmRCRGRO?= =?utf-8?B?ZGF0NmFwK2J6eC9SeE1WYkVjbzVHcTBWOVlTcmhodXpwSHBNNm5KVzd1NzFZ?= =?utf-8?B?Mm9CUVFPOW5aNDkrSFpBOENBRkRocDlCazkveDRVVDBvd3BMZ3REUzN1TWEv?= =?utf-8?B?bSt6VElKSVlYdmdCRnFGUnpFTXdTc1h4eStaV1ZzODlXY1ViWGFNdHB1M2V3?= =?utf-8?B?SVRRTTk1SEpZNUY4SG03bmFDZ29uOGdVT3VFdkhYZlFXMDhUM0NSK0dpR3NF?= =?utf-8?B?MUNSRWZ0R2I4Q1l1Y1hacy8yT3E5Nit1WDlxTVVSYUdPVHBHdk5LdXg5Y0JR?= =?utf-8?B?aTZhcWFpZXpHT0pnVExRMExyVmI4WEZScGVMbnVvS1FkUG41TTZSZWJKdkNo?= =?utf-8?B?U0ZOZW1CbGswUG5WOFQ5WGNXdFMxYUxxQlhtdDZSUkx4cVRkdUVCSDhUWmZK?= =?utf-8?B?ci9YVkpiWkpYbkFHa3NURHh3UmkxRzBWbC9FTkZTU0YwNXlPdVNhYStBVUha?= =?utf-8?B?bktGL2h6QWVmL2FmZnFDQ1dPMzh3QWVRcW5GeEV2TTBJekhEMTFUelhaV2ti?= =?utf-8?B?d0xiUENiZlRRTHgrc0lHQWpkSm1EcVJGQURwZVM5cXVrQVU1TWcwZ1RKM1dJ?= =?utf-8?B?MWxXdC9hUHNKNCtOVEVrZW5TbEgyS2ZBL0Rlcll6OWFLWVBGbjdOYkZyQ21v?= =?utf-8?B?eG5ZNkw1dXU5b0t1cENyb2p1aEJnRGFvR3V4MndjcmRnWXNoNWdqMTJMRmxq?= =?utf-8?B?Mk5vTk8xTk51UXFUTDBrL1VnN2NiUDZEd2hLMkljTjIxZ2lFT1ZlOXFZTkMz?= =?utf-8?B?N2U3MlU3OXhpd0o5OGZmRTEvQUtaa3F1MTNnSUkwV2RnZEZpc0Z5ZGx4cC9X?= =?utf-8?B?L2dPVE51TUR4d1BhYWJFbzlsNlNBcnZURlpNQXlsSHczQ1EwZkhPNUJTV3hY?= =?utf-8?B?SWRwTGxaYnNPOW1UQzk1OVlhU2x0NGJCWk1DMW1LbVZ1OXF1SGFxQzRjdndN?= =?utf-8?B?dUp4WmNhVWZVRzZoZjI0ZmFxTnR4YUd5OE1DTlNCblNTLzEzK1BJSW9kOFZK?= =?utf-8?B?ZkRyYzJMdUpPaUxiU1ZMTiszVHlaQzhmallJdXIvZy9GSURLMExhMkNvMG9R?= =?utf-8?B?cHgwZXN6bHltQ0V3blZ6ZnkrazMvS1RNTGgvSjc2bGN3SEdDNVFncEJxWHd3?= =?utf-8?B?R0hTV0V0Ym5jK0FxZTZsNnZYRUY2Y3RReExOM05rOC9GUVhma0FnVzkzUmkx?= =?utf-8?B?Q0NsekpkQXdnOHpMTWVKR2ZoVWJMdzdndGQyaWVtd1hYNXpmUlN6MnVGVVRO?= =?utf-8?B?YjhuOTQxTDMzc3lvQWJnZ1FsbVAzM1ZyMDJGMEl4cGp0azhkZHZzbzJWditj?= =?utf-8?B?VlV2MXNyUTlvK01IR2hYQUhWcXA5akM0bXpwMlkrNkdDU0NYeWlldG03emh3?= =?utf-8?B?M2JUbkFlQjZjTndjcDVOV1FaR0JRWlVpbzlDMFdTYTZuUE5TNEFBdVRMN2E1?= =?utf-8?B?STJaaGFtMlM0Wmxkc0tkMWx4aE9wcG41M1ZLdDJoS0NIUElpZEsvYWNmZ0N1?= =?utf-8?B?T1lqL2xhYzZTdVBMZFhRY1JGTzJjc0dXbWp1VkVBZkZrL2pxMEYyVFpvUlZI?= =?utf-8?B?SmFhUGNIMDY5NjE1NjN5UmxiRzV6Smh5WW94Mjk1VUJMN04zN2JxSjJiL1FQ?= =?utf-8?B?RUpRODgxeVFFclVvTWc5M1JHWlFZVHJnRkprTDVtVkgvSGRyenJhUnN4T0kr?= =?utf-8?B?MVdLVUtpK2Qzc05pdU02SHZ1Q0JnZUZFOGdxRHNuK3EyNURPMUJGU1FYUWZH?= =?utf-8?B?Y1U0Ym43U2xSNHlua09aaTNML2FuTUpLbjhhK2w3Y1Jsc3ZIQUU1anBvR3E3?= =?utf-8?B?dTJWUTZhVHJDa3pjV1cyaEtaT2dkbmtDZnI5ZEc3eExWeUc1RjhCWDVObzZJ?= =?utf-8?B?cEIyZllDOEI1aXR2NDdoODNnd2p0eVdMaGlmbDduUGZzNG1LWTNZOG1DMDhJ?= =?utf-8?B?endWayt1RllqeUUyMXN4SkZiU29sWWk1ekdLdlFxM2hEYTh1TUZUYkQrU2Z0?= =?utf-8?B?Zzg3aUZSQjdtOXlIemIwVkh5enQzMFFVd3ZNTHhUaDVWb0t5WGpPU3BkQ1Fl?= =?utf-8?B?aWVOd1d4U2V0TDZia1lDcjlRVEVxMVc4OTZwYTRYN2RFdzE2SlBrTlVlc3h3?= =?utf-8?B?VGx0RnlPSW1oT2ZmaXlRTzllRmppOGdudFVFSEVRMEdkQmdIUlpMbVFvOTRL?= =?utf-8?B?dTBXS2pEai9wMG5XTmRJN3R1ZDVkOTFicnk4UCsySHdoTTE0QmNacUFuSW9v?= =?utf-8?B?dGt0cGJuNENRbG5YNnJXYkFIRVg4YjFsaEFScmhBdHJhN01kcVZ3UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb93258-8f15-46bd-de65-08da2f4f70c5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 10:59:06.8690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xi14XCzSrrA6kjWM1HqOXIxoxKSCzncV5PScSypnnQY34Syh6O2Oj3Nn544dADAChnJ+QwSUebYDbAKGiTiI1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7919 On 05.05.2022 07:38, Demi Marie Obenour wrote: > @@ -1056,13 +1091,11 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > EFI_STATUS status; > UINTN info_size = 0, map_key; > bool retry; > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP > unsigned int i; > -#endif > > efi_bs->GetMemoryMap(&info_size, NULL, &map_key, > &efi_mdesc_size, &mdesc_ver); > - info_size += 8 * efi_mdesc_size; > + info_size += 8 * (efi_mdesc_size + 1); I think I did ask on an earlier version already why you're making this change. It continues to look to me like a leftover which was needed by an early version only. > @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > if ( EFI_ERROR(status) ) > PrintErrMesg(L"Cannot obtain memory map", status); > > + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) > + { > + if ( !is_esrt_valid(efi_memmap + i) ) > + continue; Instead of repeating the size calculation below, could you make the function (with an altered name) simply return the size (and zero if not [valid] ESRT), simplifying things below? > + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type != > + EfiRuntimeServicesData ) > + { > + /* ESRT needs to be moved to memory of type EfiRuntimeServicesData > + * so that the memory it is in will not be used for other purposes */ Nit: Comment style. > + size_t esrt_size = offsetof(ESRT, Entries) + > + ((ESRT *)esrt)->Count * sizeof(ESRT_ENTRY); > + void *new_esrt = NULL; > + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, &new_esrt); Nit: Please have a blank line between declaration(s) and statement(s). > + if ( status != EFI_SUCCESS ) > + { > + PrintErrMesg(L"Cannot allocate memory for ESRT", status); Neither this nor ... > + break; > + } > + memcpy(new_esrt, (void *)esrt, esrt_size); > + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); > + if ( status != EFI_SUCCESS ) > + { > + PrintErrMesg(L"Cannot install new ESRT", status); > + efi_bs->FreePool(new_esrt); ... this ought to be fatal to the booting of Xen. Yet PrintErrMesg() ends in blexit(). > + } > + } > + break; > + } > + > efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_size, > efi_mdesc_size, mdesc_ver); The allocation may have altered the memory map and hence invalidated what was retrieved just before. You'd need to "continue;" without setting "retry" to true, but then the question is why you make this allocation after retrieving the memory map in the first place. It's not entirely clear to me if it can be done _much_ earlier (if it can, doing it earlier would of course be better), but since you need to do it before ExitBootServices() anyway, and since you will need to call GetMemoryMap() afterwards again, you could as well do it before calling GetMemoryMap(). > --- a/xen/common/efi/efi.h > +++ b/xen/common/efi/efi.h > @@ -10,6 +10,23 @@ > #include > #include > > +typedef struct _ESRT_ENTRY { > + EFI_GUID FwClass; > + UINT32 FwType; > + UINT32 FwVersion; > + UINT32 FwLowestSupportedVersion; > + UINT32 FwCapsuleFlags; > + UINT32 FwLastAttemptVersion; > + UINT32 FwLastAttemptStatus; > +} ESRT_ENTRY; > + > +typedef struct _ESRT { > + UINT32 Count; > + UINT32 Max; > + UINT64 Version; > + ESRT_ENTRY Entries[]; > +} ESRT; I'm pretty sure I did indicate before that types used in just a single source file should be put in that source file, unless we obtain them by importing a header (e.g. the ones in include/efi/) from elsewhere. > --- a/xen/common/efi/runtime.c > +++ b/xen/common/efi/runtime.c > @@ -269,7 +269,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info *info) > case XEN_FW_EFI_MEM_INFO: > for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) > { > - EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i; > + const EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i; > u64 len = desc->NumberOfPages << EFI_PAGE_SHIFT; > > if ( info->mem.addr >= desc->PhysicalStart && With the restructured approach I don't think this stray change should be left in here anymore. Or am I overlooking anything requiring this adjustment? > --- a/xen/include/efi/efiapi.h > +++ b/xen/include/efi/efiapi.h > @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES { > #define SAL_SYSTEM_TABLE_GUID \ > { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d} } > > +#define ESRT_GUID \ > + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} } Like above I'm pretty sure I did ask that you do not alter this imported header. If gnu-efi now has these definitions, we should import them all in one go (i.e. then the two struct declarations would also want to go into their appropriate place under include/efi/. Otherwise this wants putting next to the other GUIDs defined in boot.c. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 11:02:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322906.544382 (Exim 4.92) (envelope-from ) id 1nmvjF-0004yy-Pt; Fri, 06 May 2022 11:02:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322906.544382; Fri, 06 May 2022 11:02:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvjF-0004yr-N0; Fri, 06 May 2022 11:02:33 +0000 Received: by outflank-mailman (input) for mailman id 322906; Fri, 06 May 2022 11:02:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvjE-0004yf-H7; Fri, 06 May 2022 11:02:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvjE-0004nQ-05; Fri, 06 May 2022 11:02:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvjD-0002HN-J0; Fri, 06 May 2022 11:02:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmvjD-00024S-IY; Fri, 06 May 2022 11:02:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1QwrIlxjwLCMfR7iKn3vszTCboIxCUKvpyy/sQ9HZ2A=; b=hJWTZN0aGa9v+XmkoyaZA8qfkq f3/b72b25o0Ch/oLa6L7u3bc+DAmpq7lKdQgqhBU7b1VnF06dD2ftKbuUrHBtUW341DPLsmPSJrvT zaE6032wSESh0r5yupO/dXKG/AfXqsni31zaHgtSLkdSCqHbbflhqNNmS2uqCDggc9EA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170168: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=5e5d030b1c6b542dfe22224d78bea84f85769503 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 06 May 2022 11:02:31 +0000 flight 170168 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 5e5d030b1c6b542dfe22224d78bea84f85769503 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 665 days Failing since 151818 2020-07-11 04:18:52 Z 664 days 646 attempts Testing same since 170168 2022-05-06 04:18:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106409 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 11:14:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:14:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322914.544392 (Exim 4.92) (envelope-from ) id 1nmvuS-0006Wu-TB; Fri, 06 May 2022 11:14:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322914.544392; Fri, 06 May 2022 11:14:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvuS-0006Wn-QU; Fri, 06 May 2022 11:14:08 +0000 Received: by outflank-mailman (input) for mailman id 322914; Fri, 06 May 2022 11:14:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvuR-0006Wd-0m; Fri, 06 May 2022 11:14:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvuQ-000515-VR; Fri, 06 May 2022 11:14:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvuQ-0002he-D3; Fri, 06 May 2022 11:14:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmvuQ-0002se-CV; Fri, 06 May 2022 11:14:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PDcU4OXMk2+Nm/F4gBawRSss+oTM3YXjKFb2WUzrT3E=; b=P2yL3F8FZG5D9T0qscQJir5Hwr 2x6gfOMfYbpJOrMbZLiKHgqUeckZU0mYxh5217/tPKDnvDkGdu39s7OKsPQcJHMppX82r9QQedsdz vIw96olUy6Gu1ZCnVipT/zoJY1lghjZ3gzGviwRnibW+SLIeGrtD9vNqsI5grcfSw9as=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170180: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 11:14:06 +0000 flight 170180 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170180/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 840 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 11:16:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:16:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322924.544403 (Exim 4.92) (envelope-from ) id 1nmvwf-00079o-Bv; Fri, 06 May 2022 11:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322924.544403; Fri, 06 May 2022 11:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvwf-00079h-9D; Fri, 06 May 2022 11:16:25 +0000 Received: by outflank-mailman (input) for mailman id 322924; Fri, 06 May 2022 11:16:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvwd-00079X-C5 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:16:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4121ea2-cd2d-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 13:16:21 +0200 (CEST) Received: from mail-mw2nam08lp2173.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 07:16:18 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4388.namprd03.prod.outlook.com (2603:10b6:408:39::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 11:16:14 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 11:16:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4121ea2-cd2d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651835781; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KofVYXAQpkaVCAEjQn7ua47HVDW7o6zFrctFxfdUSuo=; b=BmBLZiQG1dZUtEvr0Zbf6ZXK9susk648R/RvMr1BurG5uZz72AuN19OG JHUwjBTrgMPrHf9WYaOippiola+kG1ASrJNBVFqrm8zTeRtrE7Eu0dcfh 4ibr6O5I/KvED9YsQXHpng14u32MRsT6vrzk9YVwNAtexqZ7sINZxkBhJ s=; X-IronPort-RemoteIP: 104.47.73.173 X-IronPort-MID: 70602401 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zFCahq0KtaqT4dYtBvbD5alwkn2cJEfYwER7XKvMYLTBsI5bpzFTy 2IfX2uBb6rZa2v1fdFza4Tlph5X65fSm9YyTQZvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw34Dga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /12j621Cg0UGZTsp70tDhxWNTkkLK5/reqvzXiX6aR/zmXgWl60n7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfyVvre03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianLWUC9ArMzUYxy2XR7FxD9+L0CfX2YtOLad1Hl23Cg luTqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM/JPF8Uq5QfLzbDbizt1HUABRz9FLdk57sk/QGR60 kfTxoyyQztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:HcI3f6kEzCL3HnQHVpmlsQT9FdfpDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp r525RT5c5zp/AtHNNA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70602401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Suqd5Xc5BazROHJB96adv6AL3gXb7qL3BCxweyTOpwLniXKkFhGyDqgsajmQFk8jcUAHaHMte4JFTMJqqh+V8v3bPWuNH5QOAHu2AeakJiUheuIPceQkB8iVTJFTjjEZ5OvnuTakyyrCiAfYJzxfRjcVvE6dqCxiQf0vR4502QzbIrBIB4zdgzkXd09mTcnm2iub6ifQo+RmB8BekiR5smzMnczFoKdIcKcwJvRG1EmjW4jH94hQvWIXi86lGxC0zG6IPzRGTo5MP263C+Y81q6dSh20M/0lyyIJ7rdF4iFh3Zn6Qmnl8PDsr1D8t554VIdEPowPjnE1dCs74hAL8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5mWNDydRom74FI2cvlU8uvhR7nBz88hVQp5h7X4TY4=; b=NjnUxTKtcKMYKHHQeUhvjGJJI01SowiSw0ESma2dOY2xM7jewFULP3I7abe8MLxZWboXfajtdRC/koUeG9AGSg1D3+LLH8ZCGKkM8PRj2+WgfWR7oPlx1Ouq1in6G4VLX+UyU2oS1nQrqjqF8CAGIFAyMG5em4+6juiFqaRII9ptBqLseZH/jOE4XjQw3+7WZBvbdAj8XuiQlGgiikDr9vUiujxy410x/RA6wv8TSPuKiz28ZE1VV9KerspSOyhC+HWq0TJYOylQA/2+Dkfg+76Rl7UnybRad5DZpP97m31xCSw1779d2dhDKPpT5WwgxZ01j2e7Ji/tFmkObxq5qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D5mWNDydRom74FI2cvlU8uvhR7nBz88hVQp5h7X4TY4=; b=TYHM9QzRQWNycbqPCXjbULkhZo6BE2OXlCVqeHN1w5X0Z0G+9agGVvDsnU6tMdiHljvYloVE3Zhqf8+XyIntmDSQ0Yk079Y2qQlskuHixzYhScmQ2pcCF0bdo2burkOgGtaC/f9X1bu7gUMcBPv++15aXNxmc2kRAeIdJGo4LHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 May 2022 13:16:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> X-ClientProxiedBy: LO4P123CA0458.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 560d618b-a5d2-4b67-7773-08da2f51d50b X-MS-TrafficTypeDiagnostic: BN7PR03MB4388:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S2ENZc0ekqZZFUCvmzP/WA/Y2AKNka4Q72zO73Q+Iya6hVaW/yvkHPC2V+6yB21GtHE5DrUYKQLTl2+rBw+FnGDWZZvoupT+77Gd2JxIeidhp3tSXdDg2ULI9OycAY2oJALf3vSPO0LfCO+GBU1m1xEMDeWQ4pYod/qSL1w/JkhAaBMu8dBu4eXhrZkYEvcoSJz0Teln4nKmTFmc49el8LuaSOgqdTtLTqKGWuAtipB34m0yLDFF7uWyFtygv7nq4652CFXc6teZQcqSOlkCvHXvL4D7gqmv0Bs4kwxjdCMCUEy0XONUxlGyX89lFxiA54MGs+PPCMwg+bw0LMxVlu9zpKRJ/M7N+CYU/d8cZan/1oKIKVmKD3IDAhQOIJ+D3mfO15ip40kLDf9BU7l9+00A+GUevVvasTwYdcL2qOWF2OzZaDUghGsp4ryQUgVQcEd/b8+9NdiZHN1xRCB8Sxx4A5ZNSv8a+JnNI/rvTW/xQVNP4oLZOhMGkdXR9WGkBiox+Dxrnzs3ZcPx++IKl1uV1OEqqQnU6ryo2Z8GYEoL/WlQGkTzkEZx5o2z70v7m9UiAIs6lgp+GO2S+9JeKl6Wm72SCs3XBfHqsM7nPUDtmLWqVEtquU99cCjBX+oXNJNmItuMly0c4RifV8Xwwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(85182001)(54906003)(6916009)(508600001)(316002)(6486002)(83380400001)(2906002)(8936002)(82960400001)(6666004)(66556008)(6512007)(9686003)(33716001)(66946007)(66476007)(6506007)(26005)(4326008)(186003)(8676002)(5660300002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmhsTC81WWRTOTFpeWIwZjR4ZEhVd2FsYk1ER1loelo4S29vaUxNWVRJVWNQ?= =?utf-8?B?cmVkUzUzYW9GNnhJQjJrSWNmTVdBb0FIREJId3I0UjBPZDRRZmc0TkttcVE2?= =?utf-8?B?d09ubnVsdzhUSmJ6R3I0U2NTU0pHc2VVTnF5d1BBNzdYVUZranFPNkFsRVVE?= =?utf-8?B?SVMyK3ZJazdORGdTL1hpeEMxSGlCTFFHR3JIK2szK2dGclQxai9PRXZNdnc4?= =?utf-8?B?Unl6WmQ5aFNtMmwvWVZXQ1ZtcXdZZVo2WWVUVUFNcmlPdXVTa3laWWxmVEYw?= =?utf-8?B?SmpSQnBDbmVWTnZNSFRjck50dEZNcUxOTXBhSTIvRlU0bGxoMng3RGxyRFo2?= =?utf-8?B?QkpRK3ZwTXgrRlVWOG9EMFVnMnk3K3U4dlJnZTYxMzR3YzFwYm5taldOYXow?= =?utf-8?B?R1dqZzJhMUJpWFNPYy9yazhYNDE2ZXJTRG8wblZzQWd1VlQrODFLOVJYVXpG?= =?utf-8?B?UTcwRVRSNUpSZGlpS1crdkRMOS9VbVY1ZXFpRE1UUUQvNnMxNTVyM0tEbU8w?= =?utf-8?B?ajB6bkpVYnFYVnliZER5ekk1R0xRVEJVWnVvSUhza2tGd3VyWXVhcmptRnhh?= =?utf-8?B?cUJHOEpqNk1UVmhKZG84d1RqWWVjRTRvQVoxTE1iOU5uRDZ2VTFzK3VCQ1Zn?= =?utf-8?B?WFZHV1M1NC9nbXhsdVJJTEdnYWxYcXBwdFF3TFQ3NWUzd2kxNlYzT3BvaXBN?= =?utf-8?B?ZVM2NFBqRXJiUy9MNW85ZHhtQkxTMmtmWUp4VUE4UW1uUzV3VVFscTZQbzg4?= =?utf-8?B?b0JWVEl6S1pxaXZqbU9HTDI3aWtROEpLSzFWYlVqM2QrbFdXRnBUTXg0Mitj?= =?utf-8?B?MDVtbVo5ZVY4Mjc2MG10ZS9LaEcrd2VWQk04TkxCS1Q4OU9HZE5FWDBsMEVj?= =?utf-8?B?YkdRL2p0VDZVdXVYQnZ0NDl6Y09uNFlUVjZIbVJzS2EvZGFCakhuclpBS2lT?= =?utf-8?B?dTdRRk1nOTBMLzd1Q1pFNCtPRnY1RE96NkZiM05LR1VvMlhOS1ZNN2NNbExq?= =?utf-8?B?czRuZ3JkanQ4NEk3ejgzVTFvWFgvU3k1QWI5TGZmYTFjSXVNTHhRMW1qdWdM?= =?utf-8?B?L3RxRG5UR2lIU2pZV0dWUHNOOW9tUnZkRUxQU2lFMXRzVnJqWkUzUTRTbEV0?= =?utf-8?B?MDhCMmhCNkYxaDJiUWVFVEhaVk9ZUStKTStHYllVN0laenp4L1B6Z3l5Wjdi?= =?utf-8?B?SFR4bm02bkNkeGRZZ0VjRVBuYi9YeERNMWRFWGNoU083eUR0Rk5XcStHL2RR?= =?utf-8?B?bzc2Q0NaTUFRUDdXM200bXlxTkpqK3VKbHhQTmJtUGZmNXc3bjRkMDAwRW1m?= =?utf-8?B?NUVKRjlJNkNqaTVTQkd4Nm9ZQVZxMmI0NUZnQzBiWm1UYU5ydkNPaGJVa0V6?= =?utf-8?B?ZTZHamp5UFBaeUhMRmt2S3ZjVk1SNGFqc2NJTUtZQmlzNVhyS08vNFpRWXMv?= =?utf-8?B?dmtBRkV0dC9TU3ZWc3k5SXIwYUNXQWcrdTF2WHB0WUorRlZRSHoyeG5NOXhm?= =?utf-8?B?ZFRKNCsyUGJHR2NlT1lIOWhSckl3VmYrSGYwUVh4UEUzeWdrYlMxOWtISENh?= =?utf-8?B?N0VOcTg2QnpraXRxTStRWnRFNnBKT3Z3UEluOVZKSmRJZXBPN2lsU3AwRW1P?= =?utf-8?B?Ry9PWTVtRGRWckc1ZjNkZEN2NEJwb3Y4TDJuSFF4UUVOc2p4Qk9WMjFDclh5?= =?utf-8?B?elQ2cHBFVzQ1Y1A5NHlTVkV4NGVQSDRZZDFGSkxNMEZJcmhCYUdBbDF6bW51?= =?utf-8?B?SkF1ME03U2kvSm81ajdTdnVDT3lTVHQ4aG1sdzNlbVY4bkg0Y05WZUVzdEVu?= =?utf-8?B?VWdvY01lNE1MUGF1amUxaWpqeHRWbmlYS3JaSEJqVkNNSmNPT0xuY1NFMHFh?= =?utf-8?B?aXAzRGFuYnNWYzVWbDErZDNscFhmRGRVR2RHd0lwT0haSitLbXdmdUliN0dD?= =?utf-8?B?cGZpb2I3NGZqeWR4dU00aFFVdkZ4MEdjT2NtNEdJWG9iTFpNTVZxVkZuQXF6?= =?utf-8?B?YjcrZU9oN2cwblpJZldsa0ZUSG9xS1lMODlYZmlmRE9RMlhmVWZsVnJjOE15?= =?utf-8?B?MGxQSnJ2anNoaTNldmg3Ym1zcUdmMURnZEZFUUtQQ2thQisrZFZVZ3ZOdnRx?= =?utf-8?B?aGxaUzNWMDkweVlpUm9EQVdqTW9iMTJxM0Q1Q0xJVDhHblhLSld2M3dmczNx?= =?utf-8?B?TUxjaDZPeVViOFJWSXFRb0QraFhIbFR1VmZINVViUytoVUF1emduc255Z29o?= =?utf-8?B?UktYanIwbjN4UzllWE1USy9TREp4YVRaS3d4bDYvVnVLZllQTTdXbGI2Snp1?= =?utf-8?B?QkRlbGZkcEI3YWd5M2VPWXF0ZTFGUGFORW52cHppaW1xck1oYWN4Zz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 560d618b-a5d2-4b67-7773-08da2f51d50b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:16:14.2469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ExixGw1XxhPVUOXHCfJLvWIrZDM+dq756XuK54FoXuqsyaU9wCAspz3sYKKYJ1tfY01O/Ho/fPAvqL8ffIMHAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4388 On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > Page tables are used for two purposes after allocation: They either > start out all empty, or they get filled to replace a superpage. > Subsequently, to replace all empty or fully contiguous page tables, > contiguous sub-regions will be recorded within individual page tables. > Install the initial set of markers immediately after allocation. Make > sure to retain these markers when further populating a page table in > preparation for it to replace a superpage. > > The markers are simply 4-bit fields holding the order value of > contiguous entries. To demonstrate this, if a page table had just 16 > entries, this would be the initial (fully contiguous) set of markers: > > index 0 1 2 3 4 5 6 7 8 9 A B C D E F > marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 > > "Contiguous" here means not only present entries with successively > increasing MFNs, each one suitably aligned for its slot, but also a > respective number of all non-present entries. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > --- > An alternative to the ASSERT()s added to set_iommu_ptes_present() would > be to make the function less general-purpose; it's used in a single > place only after all (i.e. it might as well be folded into its only > caller). I would think adding a comment that the function requires the PDE to be empty would be good. Also given the current usage we could drop the nr_ptes parameter and just name the function fill_pde() or similar. > > While in VT-d's comment ahead of struct dma_pte I'm adjusting the > description of the high bits, I'd like to note that the description of > some of the lower bits isn't correct either. Yet I don't think adjusting > that belongs here. > --- > v4: Add another comment referring to pt-contig-markers.h. Re-base. > v3: Add comments. Re-base. > v2: New. > > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -146,7 +146,8 @@ void iommu_free_domid(domid_t domid, uns > > int __must_check iommu_free_pgtables(struct domain *d); > struct domain_iommu; > -struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); > +struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd, > + uint64_t contig_mask); > void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); > > #endif /* !__ARCH_X86_IOMMU_H__ */ > --- a/xen/drivers/passthrough/amd/iommu-defs.h > +++ b/xen/drivers/passthrough/amd/iommu-defs.h > @@ -446,11 +446,13 @@ union amd_iommu_x2apic_control { > #define IOMMU_PAGE_TABLE_U32_PER_ENTRY (IOMMU_PAGE_TABLE_ENTRY_SIZE / 4) > #define IOMMU_PAGE_TABLE_ALIGNMENT 4096 > > +#define IOMMU_PTE_CONTIG_MASK 0x1e /* The ign0 field below. */ > + > union amd_iommu_pte { > uint64_t raw; > struct { > bool pr:1; > - unsigned int ign0:4; > + unsigned int ign0:4; /* Covered by IOMMU_PTE_CONTIG_MASK. */ > bool a:1; > bool d:1; > unsigned int ign1:2; > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > > while ( nr_ptes-- ) > { > - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > + ASSERT(!pde->next_level); > + ASSERT(!pde->u); > + > + if ( pde > table ) > + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > + else > + ASSERT(pde->ign0 == PAGE_SHIFT - 3); I think PAGETABLE_ORDER would be clearer here. While here, could you also assert that next_mfn matches the contiguous order currently set in the PTE? > + > + pde->iw = iw; > + pde->ir = ir; > + pde->fc = true; /* See set_iommu_pde_present(). */ > + pde->mfn = next_mfn; > + pde->pr = true; > > ++pde; > next_mfn += page_sz; > @@ -295,7 +307,7 @@ static int iommu_pde_from_dfn(struct dom > mfn = next_table_mfn; > > /* allocate lower level page table */ > - table = iommu_alloc_pgtable(hd); > + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); > if ( table == NULL ) > { > AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); > @@ -325,7 +337,7 @@ static int iommu_pde_from_dfn(struct dom > > if ( next_table_mfn == 0 ) > { > - table = iommu_alloc_pgtable(hd); > + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); > if ( table == NULL ) > { > AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); > @@ -717,7 +729,7 @@ static int fill_qpt(union amd_iommu_pte > * page table pages, and the resulting allocations are always > * zeroed. > */ > - pgs[level] = iommu_alloc_pgtable(hd); > + pgs[level] = iommu_alloc_pgtable(hd, 0); Is it worth not setting up the contiguous data for quarantine page tables? I think it's fine now given the current code, but you having added ASSERTs that the contig data is correct in set_iommu_ptes_present() makes me wonder whether we could trigger those in the future. I understand that the contig data is not helpful for quarantine page tables, but still doesn't seem bad to have it just for coherency. > if ( !pgs[level] ) > { > rc = -ENOMEM; > @@ -775,7 +787,7 @@ int cf_check amd_iommu_quarantine_init(s > return 0; > } > > - pdev->arch.amd.root_table = iommu_alloc_pgtable(hd); > + pdev->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); > if ( !pdev->arch.amd.root_table ) > return -ENOMEM; > > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -342,7 +342,7 @@ int amd_iommu_alloc_root(struct domain * > > if ( unlikely(!hd->arch.amd.root_table) && d != dom_io ) > { > - hd->arch.amd.root_table = iommu_alloc_pgtable(hd); > + hd->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); > if ( !hd->arch.amd.root_table ) > return -ENOMEM; > } > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -334,7 +334,7 @@ static uint64_t addr_to_dma_page_maddr(s > goto out; > > pte_maddr = level; > - if ( !(pg = iommu_alloc_pgtable(hd)) ) > + if ( !(pg = iommu_alloc_pgtable(hd, 0)) ) > goto out; > > hd->arch.vtd.pgd_maddr = page_to_maddr(pg); > @@ -376,7 +376,7 @@ static uint64_t addr_to_dma_page_maddr(s > } > > pte_maddr = level - 1; > - pg = iommu_alloc_pgtable(hd); > + pg = iommu_alloc_pgtable(hd, DMA_PTE_CONTIG_MASK); > if ( !pg ) > break; > > @@ -388,12 +388,13 @@ static uint64_t addr_to_dma_page_maddr(s > struct dma_pte *split = map_vtd_domain_page(pte_maddr); > unsigned long inc = 1UL << level_to_offset_bits(level - 1); > > - split[0].val = pte->val; > + split[0].val |= pte->val & ~DMA_PTE_CONTIG_MASK; > if ( inc == PAGE_SIZE ) > split[0].val &= ~DMA_PTE_SP; > > for ( offset = 1; offset < PTE_NUM; ++offset ) > - split[offset].val = split[offset - 1].val + inc; > + split[offset].val |= > + (split[offset - 1].val & ~DMA_PTE_CONTIG_MASK) + inc; > > iommu_sync_cache(split, PAGE_SIZE); > unmap_vtd_domain_page(split); > @@ -2173,7 +2174,7 @@ static int __must_check cf_check intel_i > if ( iommu_snoop ) > dma_set_pte_snp(new); > > - if ( old.val == new.val ) > + if ( !((old.val ^ new.val) & ~DMA_PTE_CONTIG_MASK) ) > { > spin_unlock(&hd->arch.mapping_lock); > unmap_vtd_domain_page(page); > @@ -3052,7 +3053,7 @@ static int fill_qpt(struct dma_pte *this > * page table pages, and the resulting allocations are always > * zeroed. > */ > - pgs[level] = iommu_alloc_pgtable(hd); > + pgs[level] = iommu_alloc_pgtable(hd, 0); > if ( !pgs[level] ) > { > rc = -ENOMEM; > @@ -3109,7 +3110,7 @@ static int cf_check intel_iommu_quaranti > if ( !drhd ) > return -ENODEV; > > - pg = iommu_alloc_pgtable(hd); > + pg = iommu_alloc_pgtable(hd, 0); > if ( !pg ) > return -ENOMEM; > > --- a/xen/drivers/passthrough/vtd/iommu.h > +++ b/xen/drivers/passthrough/vtd/iommu.h > @@ -253,7 +253,10 @@ struct context_entry { > * 2-6: reserved > * 7: super page > * 8-11: available > - * 12-63: Host physcial address > + * 12-51: Host physcial address > + * 52-61: available (52-55 used for DMA_PTE_CONTIG_MASK) > + * 62: reserved > + * 63: available > */ > struct dma_pte { > u64 val; > @@ -263,6 +266,7 @@ struct dma_pte { > #define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE) > #define DMA_PTE_SP (1 << 7) > #define DMA_PTE_SNP (1 << 11) > +#define DMA_PTE_CONTIG_MASK (0xfull << PADDR_BITS) > #define dma_clear_pte(p) do {(p).val = 0;} while(0) > #define dma_set_pte_readable(p) do {(p).val |= DMA_PTE_READ;} while(0) > #define dma_set_pte_writable(p) do {(p).val |= DMA_PTE_WRITE;} while(0) > @@ -276,7 +280,7 @@ struct dma_pte { > #define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE) > #define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K) > #define dma_set_pte_addr(p, addr) do {\ > - (p).val |= ((addr) & PAGE_MASK_4K); } while (0) > + (p).val |= ((addr) & PADDR_MASK & PAGE_MASK_4K); } while (0) While I'm not opposed to this, I would assume that addr is not expected to contain bit cleared by PADDR_MASK? (or PAGE_MASK_4K FWIW) Or else callers are really messed up. > #define dma_pte_present(p) (((p).val & DMA_PTE_PROT) != 0) > #define dma_pte_superpage(p) (((p).val & DMA_PTE_SP) != 0) > > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -522,11 +522,12 @@ int iommu_free_pgtables(struct domain *d > return 0; > } > > -struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd) > +struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd, > + uint64_t contig_mask) > { > unsigned int memflags = 0; > struct page_info *pg; > - void *p; > + uint64_t *p; > > #ifdef CONFIG_NUMA > if ( hd->node != NUMA_NO_NODE ) > @@ -538,7 +539,29 @@ struct page_info *iommu_alloc_pgtable(st > return NULL; > > p = __map_domain_page(pg); > - clear_page(p); > + > + if ( contig_mask ) > + { > + /* See pt-contig-markers.h for a description of the marker scheme. */ > + unsigned int i, shift = find_first_set_bit(contig_mask); > + > + ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) == PAGE_SHIFT - 3); I think it might be clearer to use PAGETABLE_ORDER rather than PAGE_SHIFT - 3. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 06 11:17:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322922.544414 (Exim 4.92) (envelope-from ) id 1nmvxi-0007rJ-Qr; Fri, 06 May 2022 11:17:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322922.544414; Fri, 06 May 2022 11:17:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvxi-0007rC-OF; Fri, 06 May 2022 11:17:30 +0000 Received: by outflank-mailman (input) for mailman id 322922; Fri, 06 May 2022 11:15:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmvvp-00075p-E6 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:15:33 +0000 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7cd5438-cd2d-11ec-a406-831a346695d4; Fri, 06 May 2022 13:15:32 +0200 (CEST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-141-BS4UFLXEN-G9ZvjPcy_Qeg-2; Fri, 06 May 2022 12:15:30 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Fri, 6 May 2022 12:15:23 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Fri, 6 May 2022 12:15:23 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7cd5438-cd2d-11ec-a406-831a346695d4 X-MC-Unique: BS4UFLXEN-G9ZvjPcy_Qeg-2 From: David Laight To: 'Johannes Berg' , Keith Packard , Kees Cook CC: "Gustavo A . R . Silva" , Francis Laniel , Daniel Axtens , "Dan Williams" , Vincenzo Frascino , Guenter Roeck , "Daniel Vetter" , Tadeusz Struk , Alexei Starovoitov , "alsa-devel@alsa-project.org" , Al Viro , "Andrew Gabbasov" , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , "brcm80211-dev-list.pdl@broadcom.com" , Christian Brauner , =?utf-8?B?Q2hyaXN0aWFuIEfDtnR0c2NoZQ==?= , Christian Lamparter , Chris Zankel , Cong Wang , "David Gow" , David Howells , "David S. Miller" , Dennis Dalessandro , "devicetree@vger.kernel.org" , Dexuan Cui , "Dmitry Kasatkin" , Eli Cohen , "Eric Dumazet" , Eric Paris , "Eugeniu Rosca" , Felipe Balbi , Frank Rowand , Franky Lin , "Greg Kroah-Hartman" , Gregory Greenman , Haiyang Zhang , "Hante Meuleman" , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , John Keeping , Juergen Gross , Kalle Valo , "keyrings@vger.kernel.org" , "kunit-dev@googlegroups.com" , Kuniyuki Iwashima , "K. Y. Srinivasan" , "Lars-Peter Clausen" , Lee Jones , Leon Romanovsky , Liam Girdwood , "linux1394-devel@lists.sourceforge.net" , "linux-afs@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "linux-hardening@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "llvm@lists.linux.dev" , Loic Poulain , Louis Peens , Luca Coelho , "Luiz Augusto von Dentz" , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , "Max Filippov" , Mimi Zohar , Muchun Song , Nathan Chancellor , "netdev@vger.kernel.org" , Nick Desaulniers , =?utf-8?B?TnVubyBTw6E=?= , Paolo Abeni , Paul Moore , "Rich Felker" , Rob Herring , Russell King , "selinux@vger.kernel.org" , "Serge E. Hallyn" , "SHA-cyfmac-dev-list@infineon.com" , Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Takashi Iwai , Tom Rix , Udipto Goswami , "wcn36xx@lists.infradead.org" , Wei Liu , "xen-devel@lists.xenproject.org" , Xiu Jianfeng , "Yang Yingliang" Subject: RE: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Thread-Topic: [PATCH 02/32] Introduce flexible array struct memcpy() helpers Thread-Index: AQHYYLyA1R9dSzYVM0KNCrE+uTLPFK0RsSYw Date: Fri, 6 May 2022 11:15:23 +0000 Message-ID: <46ec2f1d6e9347eaba1feeb00e8c508a@AcuMS.aculab.com> References: <20220504014440.3697851-1-keescook@chromium.org> <20220504014440.3697851-3-keescook@chromium.org> <202205040819.DEA70BD@keescook> <970a674df04271b5fd1971b495c6b11a996c20c2.camel@sipsolutions.net> <871qx8qabo.fsf@keithp.com> <202205051228.4D5B8CD624@keescook> <87pmkrpwrs.fsf@keithp.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 RnJvbTogSm9oYW5uZXMgQmVyZw0KPiBTZW50OiAwNSBNYXkgMjAyMiAyMToxMw0KPiBPbiBUaHUs IDIwMjItMDUtMDUgYXQgMTM6MDggLTA3MDAsIEtlaXRoIFBhY2thcmQgd3JvdGU6DQo+IA0KPiAN Cj4gPiBJIGJldCB5b3UndmUgYWxyZWFkeSBjb25zaWRlcmVkIHRoZSBzaW1wbGVyIGZvcm06DQo+ ID4NCj4gPiAgICAgICAgIHN0cnVjdCBzb21ldGhpbmcgKmluc3RhbmNlID0gbWVtX3RvX2ZsZXhf ZHVwKGJ5dGVfYXJyYXksIGNvdW50LCBHRlBfS0VSTkVMKTsNCj4gPiAgICAgICAgIGlmIChJU19F UlIoaW5zdGFuY2UpKQ0KPiA+ICAgICAgICAgICAgIHJldHVybiBQVFJfRVJSKGluc3RhbmNlKTsN Cj4gPg0KPiANCj4gU2FkbHksIHRoaXMgZG9lc24ndCB3b3JrIGluIGFueSB3YXkgYmVjYXVzZSBt ZW1fdG9fZmxleF9kdXAoKSBuZWVkcyB0bw0KPiBrbm93IGF0IGxlYXN0IHRoZSB0eXBlLCBoZW5j ZSBwYXNzaW5nICdpbnN0YW5jZScsIHdoaWNoIGlzIHNpbXBsZXIgdGhhbg0KPiBwYXNzaW5nICdz dHJ1Y3Qgc29tZXRoaW5nJy4NCg0KWW91IGNhbiB1c2U6DQogICAgICAgICBzdHJ1Y3Qgc29tZXRo aW5nICppbnN0YW5jZTsNCiAgICAgICAgIG1lbV90b19mbGV4X2R1cChpbnN0YW5jZSwgYnl0ZV9h cnJheSwgY291bnQsIEdGUF9LRVJORUwpOw0KICAgICAgICAgaWYgKElTX0VSUihpbnN0YW5jZSkp DQogICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIoaW5zdGFuY2UpOw0KYW5kIGhhdmUgbWVtX3Rv X2ZsZXhfZHVwKCkgKHdoaWNoIG11c3QgYmUgYSAjZGVmaW5lKSB1cGRhdGUgJ2luc3RhbmNlJy4N CihZb3UgY2FuIHJlcXVpcmUgJmluc3RhbmNlIC0gYW5kIGp1c3QgcHJlY2VkZSBhbGwgdGhlIHVz ZXMgd2l0aA0KYW4gZXh0cmEgJyonIHRvIG1ha2UgaXQgbW9yZSBvYnZpb3VzIHRoZSB2YXJpYWJs ZSBpcyB1cGRhdGVkLg0KQnV0IHRoZXJlIGlzIGxpdHRsZSBwb2ludCByZXF1aXJpbmcgaXQgYmUg TlVMTC4pDQoNCklmIHlvdSByZWFsbHkgd2FudCB0byBkZWZpbmUgdGhlIHZhcmlhYmxlIG1pZC1i bG9jayB5b3UgY2FuIHVzZToNCiAgICAgICAgIG1lbV90b19mbGV4X2R1cChzdHJ1Y3Qgc29tZXRo aW5nICosIGluc3RhbmNlLCBieXRlX2FycmF5LCBjb3VudCwgR0ZQX0tFUk5FTCk7DQoNCmJ1dCBJ IHJlYWxseSBoYXRlIGhhdmluZyBkZWNsYXJhdGlvbnMgYW55d2hlcmUgb3RoZXIgdGhhbiB0aGUg dG9wIG9mDQphIGZ1bmN0aW9uIGJlY2F1c2UgaXQgbWFrZXMgdGhlbSBoYXJkIGZvciB0aGUgJ21r MSBleWViYWxsJyB0byBzcG90Lg0KDQoJRGF2aWQNCg0KLQ0KUmVnaXN0ZXJlZCBBZGRyZXNzIExh a2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50IEZhcm0sIE1pbHRvbiBLZXluZXMsIE1LMSAxUFQs IFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTczODYgKFdhbGVzKQ0K From xen-devel-bounces@lists.xenproject.org Fri May 06 11:25:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:25:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322941.544426 (Exim 4.92) (envelope-from ) id 1nmw5m-0000tH-LQ; Fri, 06 May 2022 11:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322941.544426; Fri, 06 May 2022 11:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmw5m-0000tA-Id; Fri, 06 May 2022 11:25:50 +0000 Received: by outflank-mailman (input) for mailman id 322941; Fri, 06 May 2022 11:25:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmw5l-0000t4-KY for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:25:49 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060e.outbound.protection.outlook.com [2a01:111:f400:fe1a::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46994dfa-cd2f-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 13:25:47 +0200 (CEST) Received: from AM6P191CA0099.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::40) by VI1PR08MB5453.eurprd08.prod.outlook.com (2603:10a6:803:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 11:25:44 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::a9) by AM6P191CA0099.outlook.office365.com (2603:10a6:209:8a::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18 via Frontend Transport; Fri, 6 May 2022 11:25:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 11:25:44 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Fri, 06 May 2022 11:25:43 +0000 Received: from ec58c580f8c0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 85A57C7F-F104-49F0-9479-1E36873D6502.1; Fri, 06 May 2022 11:25:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec58c580f8c0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 11:25:32 +0000 Received: from VI1PR08MB3967.eurprd08.prod.outlook.com (2603:10a6:803:df::16) by DB7PR08MB3690.eurprd08.prod.outlook.com (2603:10a6:10:77::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 11:25:28 +0000 Received: from VI1PR08MB3967.eurprd08.prod.outlook.com ([fe80::d529:a34d:5df0:47ae]) by VI1PR08MB3967.eurprd08.prod.outlook.com ([fe80::d529:a34d:5df0:47ae%3]) with mapi id 15.20.5206.028; Fri, 6 May 2022 11:25:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46994dfa-cd2f-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=D5Qq/iqscHstFEly7eQkcPDv8y37VtMvkZdC7JfF94ixLyLPJdsmJeBrrUGRgSYKuY0b+R3d27RT1dj/ANBDKGwtYgiwesg5Z/4XI8Gnn2B11+rA5QCIO+TACMc8Dp1UjK+BAgQOgLbeXLlvMgylAsPIYwhu1xUCq8DW5qI+YMl27eAEwLhZ/KcG+q4txFnbIXLUXcSapG/phy3bNbRhq/Ky0pft4W20JwSs1EzcbQrr0iGtTLyg13fUzd7YALb8M7qcNLDJUwgfKdMKYIMcivPhsYLlUzuhz+QCPYhSfMAkUUvTPCI5+iLI2BhJa/sywE+WetJyds8RAnpXLOjO6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2jDlgMdK0c13yFMcIYkbpv9Ytu+wtPg74tMKt6JOgsA=; b=D9Zmqa07N5xK2SrgFx+5yU+3yHu+GPxz59lFwno3uoUSxjbKivtDe6qxNaARqhyDWPKYxrwjYya2ZnMLj2TvG/HuWVpAABEP9Cnbqat8nVhdRNtINeWmKeU/RcCS+fwnm8bsGJKd1baj3ruRFkizAKQO+UzuqhuIh1UisFEL6ZflM2VT0L1BfmCsX/44QI5eUbwmW7d7Y89Sr0PjsWdHxz/QaLHv9mQdcLidLm9pDmDs0yO1pl0XIE+vGiJZhNGCgy+hw6Hdk+dr5+4/m1Y16T6+cF8G4qH3ZfiJ/HIhnkEHagaG3xrBf/61kDcJzb26otYk9CJylzcVvVtzwiQZSg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jDlgMdK0c13yFMcIYkbpv9Ytu+wtPg74tMKt6JOgsA=; b=sKin7I0oMiQDmPMueJdidyJY81QFrCpPDufSXNR3+/fZ3DoKORLMNl4WppYeVjENzkACQTDmXFCwDpDXX5IXDpKpo06w539yc8KP32cu5DRh4VvWNTHode/ZHpjfL8+3X2Hyte0HfiyNtp1kxYFwZVU5MogoiPsc0W1W6RWsQ20= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 642b9b04e2d45376 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MzubadFKfvxMLFYEG6lGWpbNDL/Ezk5600FosEjzNyuMLI79J9djfgfU/+JVEOhSNmlXHs2y8sACpSvYuMr9DnlHq22HoMDQT2NcVD7ApoUgu6P0mNOIr/XsQbamSdwubb7Vgg8F+WxkZcenIkuPHfLXUIVCZ+6xbhSLSM2HpLNA4jggnfn4lHpnngyDzYpAV4ytcd7Wwv7+/qMFIkukQk8Qep435U/FTu/V9GoEp4EFbi4j7ss8pVLEJFBT1sWbS8jKUeIWdi/5VqNkTK8aIkSYn+Ilm2PhGnJQhSLnXlcIVBpUaqSFI7yp2QNV/YPAiFmnEJW7vatP36p0JMjTrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2jDlgMdK0c13yFMcIYkbpv9Ytu+wtPg74tMKt6JOgsA=; b=QJ2gnGfSJXC+0x4QdkWFUjX4MYyzT16GPPPOCB2kfmZwLpZfrsX5iOSI0Pj41vKAQZebHrm6l9NYFPzzbghZ/JeMvvbm1IhFY32ZJb/Z7nzMCG5sUFE6uXR1DRhFIm5A8UAs+s5SzQWy1ZNbOkeUIIrWkKyhurljbZs0VgW6cYZmaGQUye7+lg3gJp+Q9zO7jZShPSnHkxcMRHzqvayXJ9a3HpeoJGbPA48ZABe3IoM9NrQJ/W05JhGAXmlAeUKd/KOvzmWcKsm/BFjgtQETdeh8R6y1mBD2lBPKR0KTbsFNnQIaDq+INxUL5MUtEdrh3ToUlaoql3UQNgVoiY3vMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jDlgMdK0c13yFMcIYkbpv9Ytu+wtPg74tMKt6JOgsA=; b=sKin7I0oMiQDmPMueJdidyJY81QFrCpPDufSXNR3+/fZ3DoKORLMNl4WppYeVjENzkACQTDmXFCwDpDXX5IXDpKpo06w539yc8KP32cu5DRh4VvWNTHode/ZHpjfL8+3X2Hyte0HfiyNtp1kxYFwZVU5MogoiPsc0W1W6RWsQ20= From: Luca Fancellu To: xen-devel CC: Bertrand Marquis , Wei Chen Subject: Re: [PATCH v8 0/7] Boot time cpupools Thread-Topic: [PATCH v8 0/7] Boot time cpupools Thread-Index: AQHYVVhdzvmSbSkA9kKhcVjYQ/ksyq0RzUeA Date: Fri, 6 May 2022 11:25:28 +0000 Message-ID: <0EA6F35B-89E9-45AC-9274-567F86E67C6E@arm.com> References: <20220421081645.40235-1-luca.fancellu@arm.com> In-Reply-To: <20220421081645.40235-1-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0b0cd7ea-cc8d-4f2b-7e9d-08da2f5328eb x-ms-traffictypediagnostic: DB7PR08MB3690:EE_|AM5EUR03FT027:EE_|VI1PR08MB5453:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: q36mS1ve368yZK/S8X51YoN+iy+tobr2ukT3Eli1cS3fq6SAs1S+ZZOqGaHGeFzLTwAMdB1BFVRchhOfqPk7UHPn4W0U5lXn0Yi9z7l0Mx9rzgkLG89iHzfUnnjKJkGh4KBhC3oj165b7t196lZEtUODy6dznjDo9V3byh6e4LXVoYX/p8/a0QwO80OVnXNoQN+pPyevd7F6I/EjGQV3n/jW0MctygdnPu7BQ8H1BFl/igaT1L3fkqgKvm/JK/nTwIIteizIalb1RM0R/4FzpHHLWha3S+gcjqgPK42qSAccZ17Vpl8gjRSqXZbIqZP+W6aeOEIAeRN+kDIZeQ8X/+Hb75kh79Vhn3XUMBS95dYr65JW2SCZ0YT8b/nUqszikEuqlO6hn16RmwQkifZGr1Ip6McLkUj4TEA23bo5B4GjA/0yPj6V5aLanSn8pnLK+92T4ioG3H7ClqLJWFqQyPifkmic0+P3XyvdkpBvQcmK8OYJJi7V8jnxJuw4dAFcLbjEvNTaXXmfkK6CMIdtVS5+elw/vXwgbbeQfA+Yydk0hrA/4wgCChQs8hkyMiLgG+tChwbijGBobiYQS/K48mEA1Vp0JIbUXwycdIz/44kEeHeFcG/LXuKZm4kIzjjVwIPPxHPEPujU7k4fUpyaP3ve+y8dqfRSALIMbF7PsFafauxPuJdnnDWMDgxYczEhLGxSLSHLlRm96Ua1yZBdXpiWnSyrXy0rBhGr+rxv/xjLYqZ1WiCN2iB/ZFvcuzbp55F340yhAVVOfZRLVKZvmyrvhUA4AanIDkNzZPaiRD9/lp1lOYjy+5UArowVWyyWtny0vAhoowCOhondkQM22Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3967.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2616005)(186003)(83380400001)(6512007)(26005)(33656002)(2906002)(54906003)(6916009)(316002)(91956017)(76116006)(5660300002)(6506007)(508600001)(64756008)(66446008)(66476007)(8676002)(66946007)(66556008)(38100700002)(8936002)(38070700005)(86362001)(6486002)(122000001)(966005)(4326008)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <78CEBBFDFD70FF4DBAD6E604FB738CDC@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3690 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fb2a4167-ee2f-42ea-928b-08da2f531f6c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 22f5GuglIz9dDFXu8A6sUjpRWHxrVnt2wAL7DaxdagpvoijgbU1Yc/4oXuOpNXHvNjfoj4Dt8UdNsTzIPMy1Mx5ZMTEediLlC+nscNKty5PibIfpZYVEoav+H/oc6N/jC+yIrMJIGgoiz/yPEEBo/OIzHO4wjf2JuhQtcgF4BIT1XrmcAOrC+Xpt0R/SdgvD7VeydQAxLZtGxgbqLiN7sGdjGtRB6//X1RY/ME+yDt+kPIe0z91+E3Nzx/Q5xD7G3b7JMTdj68bocodueeYBQXw7QJpJGDO7AZ+qRjCsAX7mbYAtaV7WTCsRyCGaBLva7ljPdSr0uagTwNXTJ0dirwMkhEhI4g7EefkNqtCPzYmRC1rxjyhv8okaOEkM8CXVYf0SS06PSR2ucGdPOBk9g338+Uo/+T+xl+ZfRTEhcWWOP8Na2BlOrLtafR7qxRBTkojDTtwmYhh7Sn1QW1VJcf7RicH3QUXgSJbOiE7yWP7zrHGHJLqfzyoFk4i/IugZds9MrQ8acn2BGK6oQ9YFJv9XxCvjqDM4JkiwsdiQg1e3cBjeHHBwsj0qXGrz/6pZr7C39yeZD46Z5gxvEtbCRxmSOgEFI4pIJtEOxnKHr2JUCHKcEvkeGiHklRm7I9GsdfHDMzYoIhfk+XxSnmoTukAofENg5zr1JwgsVeC9pWUpTCZzMjxQ0iQVtNZkC/unUPg9HvwmyUUVsIK5+M99xcCyVmr0xTAcfDSQEx1Jnm2Eb+wVFvggR6XcskWFy8XqZT/ML0PyNyKtMX9mG5v0QQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(47076005)(336012)(356005)(81166007)(186003)(316002)(8936002)(4326008)(36756003)(83380400001)(70586007)(8676002)(36860700001)(54906003)(86362001)(33656002)(40460700003)(6916009)(5660300002)(508600001)(2616005)(966005)(6486002)(82310400005)(6506007)(6512007)(26005)(2906002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:25:44.1034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b0cd7ea-cc8d-4f2b-7e9d-08da2f5328eb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5453 > The example DT is instructing Xen to have two cpu pools, one having two p= hisical > cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses= the > null scheduler and from the /chosen node we can see that a dom0less guest= will > be started on that cpu pool. >=20 > In this particular case Xen must boot with different type of cpus, so the > boot argument hmp_unsafe must be enabled. >=20 > Luca Fancellu (7): > tools/cpupools: Give a name to unnamed cpupools > xen/sched: create public function for cpupools creation > xen/sched: retrieve scheduler id by name > xen/cpupool: Create different cpupools at boot time > xen/cpupool: Don't allow removing cpu0 from cpupool0 > arm/dom0less: assign dom0less guests to cpupools > xen/cpupool: Allow cpupool0 to use different scheduler >=20 > MAINTAINERS | 2 +- > docs/misc/arm/device-tree/booting.txt | 5 + > docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++ > tools/helpers/xen-init-dom0.c | 37 +++- > tools/libs/light/libxl_utils.c | 3 +- > xen/arch/arm/domain_build.c | 19 +- > xen/arch/arm/include/asm/smp.h | 3 + > xen/common/domain.c | 2 +- > xen/common/sched/Kconfig | 7 + > xen/common/sched/Makefile | 1 + > xen/common/sched/boot-cpupool.c | 234 +++++++++++++++++++++++++ > xen/common/sched/core.c | 40 +++-- > xen/common/sched/cpupool.c | 43 ++++- > xen/include/public/domctl.h | 5 +- > xen/include/xen/sched.h | 53 ++++++ > 15 files changed, 563 insertions(+), 31 deletions(-) > create mode 100644 docs/misc/arm/device-tree/cpupools.txt > create mode 100644 xen/common/sched/boot-cpupool.c >=20 > --=20 > 2.17.1 >=20 Ping? The v8 seems to be reviewed for all patch https://patchwork.kernel.org/project/xen-devel/list/?series=3D634064 Any other thought about that? Cheers, Luca From xen-devel-bounces@lists.xenproject.org Fri May 06 11:29:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:29:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322947.544437 (Exim 4.92) (envelope-from ) id 1nmw97-0001c1-42; Fri, 06 May 2022 11:29:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322947.544437; Fri, 06 May 2022 11:29:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmw97-0001bu-18; Fri, 06 May 2022 11:29:17 +0000 Received: by outflank-mailman (input) for mailman id 322947; Fri, 06 May 2022 11:29:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmw96-0001bn-5f for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:29:16 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0c::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c26f8bd6-cd2f-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 13:29:15 +0200 (CEST) Received: from AS9PR0301CA0007.eurprd03.prod.outlook.com (2603:10a6:20b:468::27) by AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 11:29:13 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:468:cafe::c8) by AS9PR0301CA0007.outlook.office365.com (2603:10a6:20b:468::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Fri, 6 May 2022 11:29:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 11:29:13 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Fri, 06 May 2022 11:29:13 +0000 Received: from f869d83e6440.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 938EE3C6-F697-46BA-A842-E4D03FCFFCCE.1; Fri, 06 May 2022 11:29:05 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f869d83e6440.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 11:29:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB7637.eurprd08.prod.outlook.com (2603:10a6:10:31c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 6 May 2022 11:28:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5206.027; Fri, 6 May 2022 11:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c26f8bd6-cd2f-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qzv6pV1iCNjVcJ4dJ/xpbCMGgodMUF2lWwEN1uPgVzNx582dBscXjDqzGs7+g6515gIL2IcNBJeU3H8CRhokbuu5X2R5ZMvsapXiNgMbPWRuIYndt4nAd5WfGXIJfUBEZJ1lguH9Hm73oaxECBjX6maX1o5ywqvBFqdvJcxRrhcccpBhYLn04NPn/nZqU6oqEV/vredocdyhnbBD/XlD8BMMdyK7vhL8Q5MRjgE0lgXh9xFfee/G8WlkWyFX8z5V1ZmQc6tUCgYWRYUJggoX33hg04AxyCePU9wsRrveZugq32x9HjUsKNZvxetBVA3iCmmVrFqDogAkye4Ao/d+0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=kRhosTmdVz5ytMjpN/SHwhA7vvve6rztHWLF8KqVq4nS74hl0jXGKkmkQB8dbGmmo6szizqFim+6Ix+u9SZ5lHwARKgp8pWLJ1g7ctI565ATsFPQF9IGpLTGZv30Pu67zUKmwpuQuwA8U3s/ouC1Fmg3yg6JZgJiwLTIp7ReDzjNzLFe0A0lhIoLK4nGID44NZe9NfkON4exTQccU6XmukEnHDzuD+JQC+mDIs3bqniGTyiBImZxqhIEUnJusGQN48W9se/94OHLCCtJ/O6y5lTN5gqkkpRMCRM9u2RpZMUtzudbyHe9hnYqDOHXsvIpeRdts+XqorQvI4EvY9h2kw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=hot+OkuLoPRAOwck3+y0F5lVP6RHTZJYxBIqsfitEyKTtwEvUOzntPEzbLky6ldaEDL0nalRUqSrp9yVwCeUEss7e78CV1qNY1+ECE17TipbH2RtFugEpunB1GdlbZ/C7uFxd+GX1i61pZTzmkGD1sXfxt/o7IeZvOqDvyvnGd0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 211cf9109fcd1cd5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPVnZH8Ovk2Okdnq1y7qftBOgSiHaymX5HNF1lDqPHkAHNQxjLb6+Zj+uWJvPlLuMr8wSb+ur4fiL7q8Oj4vitHEb7ownT1D76cCkBclqIuB7PpumRgN6BtGFMVcSqIYTymT3+fErO5Pk72sMW+QjNNGVmTUV44oBmPOkYyxlFvuDUWbhmSPRlbXksa1QlWDoETcNaIIWk8Ko15/9Vye1El94YW8ObMvZJHL92rzXq3fGVJD2APyHjAhCHdbzODbZwf59qodVz/1f10RtqbrjbdOObRIBlE9gXJa3LnAgdm2thoc7lOCaKF2gReFArpPRlXbNPCdrtI606tG9fYoJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=aAHdUs08tVpLbtD+y4+OyHUV1d7vsr/XVrOO5POqUlkladHIIAxA7gtIK1AJElA9qdOJg+dgGuipIW9zsCu7WdtkIc3Znh9T1iyKHF62juZVfCr84eaVNIsIDur63NYMHD8jca7t8eOz0zVr1zkewq7mlhzLCiz6ghulokdB1us7jiCZimKmdrCjTofuVAJqEbPcV2dmWxGVk1GfD5RgBmD5/TvWIjWY9X08gJ7n5Uw948CGG3hwk8Zeh4hWfCR5HDBtx0/y9Ad61T6MpmYDRb2nFggKmGGj/aKH2kda5XZmD4thBSrxeQE2UBveSWR62ZSFD++vodyW0nQzCwyqUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=hot+OkuLoPRAOwck3+y0F5lVP6RHTZJYxBIqsfitEyKTtwEvUOzntPEzbLky6ldaEDL0nalRUqSrp9yVwCeUEss7e78CV1qNY1+ECE17TipbH2RtFugEpunB1GdlbZ/C7uFxd+GX1i61pZTzmkGD1sXfxt/o7IeZvOqDvyvnGd0= From: Bertrand Marquis To: Rahul Singh CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table Thread-Topic: [PATCH v2] arm/its: enable LPIs before mapping the collection table Thread-Index: AQHYX9qXT7uheGBkRkeP+IHSC5Nb6K0RuToA Date: Fri, 6 May 2022 11:28:55 +0000 Message-ID: <0CE12746-697A-4005-8FD1-FE2546A8E018@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7c885409-affb-4294-64f2-08da2f53a5a7 x-ms-traffictypediagnostic: DU0PR08MB7637:EE_|AM5EUR03FT060:EE_|AM0PR08MB3778:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BnYgr9Czh3yzga5fknHsUy4JAhkMApEwXWjxIMXIzrYxguZ1/DrANrwMaKIQvknRGoVcM6Vn5yJ/SB7FR4dy6AG186lGhl6feIufrjzaJHu6aEKCIiNCqrJmmvxfnS4qQLGNKCAyzxKz2NwwHNmO31ZTY5f9cFq9v4eu0JxLblL9Gl0HdwbdMS6AjOmxN56sX+z+5l9nKYcRP1IEqsbUNcV9IDWt6CJZZdV6dlEurbEPrdgRlJ1NS2p/cQVgMB+obyhkmy0KXkLJ+YS1mGklJAlrUV+HCmHPjTUJLkUINv9LpoQgWwOJpZlwJWuNJCvPMdIZe3cnf1xOMKIWxnBq3qRi/D53ypKvbhom7f+7urKh771ufKF9yIIPi8BbaxE1UpEHXE/aFKEnyPfGlhkEpMJJkyLqXEKXuesf+ImjhXaBEOoibYcmTCwW2rTUyCFK9Hz1MCADfYv5xqs5qak8p8ZuiBELd8DJD9LflH+05Nal8+aaZug9invadBmGupHUGBEi/MXunVokMZ7WJn47ETkv2hotC1MXws1NHFKDF9RKTntVd/bmP6pjtxHFDnarBZ/gIogBVfpPYExiKXH5iM0LilN8tfMUya8C1dx/oDWgoABInfJPtBahkpOP+83EwhSvWHJOU8DwP9RHejqkRKxDvU1Y8ZofMWIwVrhKtWjeVczpjdXnaKulFIulfIUp1Ei0Dy++Lo4CzbTTjxUZCJNQmWGDC+5lX0bdmQfPedx/Upri/7BoRjO56UV8Fl2A X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(2906002)(6636002)(37006003)(83380400001)(2616005)(186003)(38100700002)(8936002)(26005)(6512007)(5660300002)(508600001)(54906003)(38070700005)(53546011)(71200400001)(33656002)(86362001)(91956017)(66946007)(66446008)(6486002)(66556008)(66476007)(76116006)(316002)(122000001)(8676002)(64756008)(6862004)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7637 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5af975a9-340d-41d3-d00b-08da2f539b09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h9h+d3nXIpSUaWOmQM7qlohLBmn9+D9aZ5fe+sSlJ8fp0ru1PzvmbcjUS1Aa7RUQMs3pzAGpoy3RcFzSvo5IFmsCJmCGC0j28L0J/XkhvzWK4oK+FvThXDiDXbiJBWdsLA4jUyQzbATyVQdU8b98FzBR2KxMkllxz0rUp1/XBK279ywvmx0cLctloajSCK6V8OFUZjnBdKZ7iUbyWfOQgzVbem91Ger1RYveKjXbCkGew4DhAMBsvmOqFWSo2RN38nzP6GT/Qi1mfuDsywZQpjc+bjecVhW0IkpnuPotPYW0cRzRuwwrsbeCJTLLhLYtjwAzIgogP/9raXs9KcVWkNddH8uvFozgRbriGeOT300J5N71jVWwu4aYyniCfkkPVTf6/4LKd+N8nOwhBK/fVjvNyxyyFlWjHhO7juNkE6R9iq+SWN42gEOXc/wKTFvVOHXEdSC/NCTNNBdMWRcFTHKFiaaV1nP1+L9WgquG1rP4ifex+cS5cBlpG3JC4PiURH1XzxMJu8iU5FXvfzAfmzetoVUObj4btlCUpi6IDYBQganDkJKQl3dctWTRxxTMKorusZW7zFdTBiaMsmrYUtG3j6N7gNUFslY1eU/UYEOMumUk9R2gNyGIqm1Fnxva4PyDaaGHwB+W7+0E1PYyELAwhqkJRKCJ3zlkIRpCgNUER2LUXuWbYtTT+bb4Jfvv X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6506007)(6512007)(81166007)(26005)(53546011)(316002)(6636002)(33656002)(2616005)(54906003)(37006003)(36860700001)(82310400005)(5660300002)(83380400001)(8936002)(186003)(336012)(47076005)(40460700003)(2906002)(107886003)(70206006)(86362001)(6862004)(4326008)(36756003)(70586007)(8676002)(6486002)(508600001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:29:13.3723 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c885409-affb-4294-64f2-08da2f53a5a7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3778 Hi Rahul, > On 4 May 2022, at 18:15, Rahul Singh wrote: >=20 > When Xen boots on the platform that implements the GIC 600, ITS > MAPC_LPI_OFF uncorrectable command error issue is observed. >=20 > As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can > be reported if the MAPC command has tried to map a collection to a core > that does not have LPIs enabled. The definition of GICR.EnableLPIs > also suggests enabling the LPIs before sending any ITS command that > involves LPIs >=20 > 0b0 LPI support is disabled. Any doorbell interrupt generated as a > result of a write to a virtual LPI register must be discarded, > and any ITS translation requests or commands involving LPIs in > this Redistributor are ignored. >=20 > 0b1 LPI support is enabled. >=20 > To fix the MAPC command error issue, enable the LPIs using > GICR_CTLR.EnableLPIs before mapping the collection table. >=20 > gicv3_enable_lpis() is using writel_relaxed(), write to the GICR_CTLR > register may not be visible before gicv3_its_setup_collection() send the > MAPC command. Use wmb() after writel_relaxed() to make sure register > write to enable LPIs is visible. >=20 > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Fri May 06 11:40:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:40:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322954.544447 (Exim 4.92) (envelope-from ) id 1nmwJs-0003y2-8o; Fri, 06 May 2022 11:40:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322954.544447; Fri, 06 May 2022 11:40:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwJs-0003xv-68; Fri, 06 May 2022 11:40:24 +0000 Received: by outflank-mailman (input) for mailman id 322954; Fri, 06 May 2022 11:40:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwJq-0003xp-UZ for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:40:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwJq-0005Rh-Il; Fri, 06 May 2022 11:40:22 +0000 Received: from [54.239.6.185] (helo=[192.168.5.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmwJq-0002qz-Bn; Fri, 06 May 2022 11:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=W8x6LzBWusOs15c1UMfyH3kcsdbMXBPeYE6vUVLayE4=; b=S5DE60CqUdQ0GVHvF/aYXDL3To nH9cz+pR3Z+BGKkLne7WvMdy3ElHNW9riJLPah+m8UCJQuVwjt7rFPQe5L3DG1SqaeZTUfEFpdHNJ Fvx/cwM8/A28UKDRc/tItCsLgMKsLjzEdy+q07UtWv2z56Dlhr/N9jrPQ2RHrI9pPP+A=; Message-ID: Date: Fri, 6 May 2022 12:40:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 0/7] Boot time cpupools To: Luca Fancellu , xen-devel Cc: Bertrand Marquis , Wei Chen References: <20220421081645.40235-1-luca.fancellu@arm.com> <0EA6F35B-89E9-45AC-9274-567F86E67C6E@arm.com> From: Julien Grall In-Reply-To: <0EA6F35B-89E9-45AC-9274-567F86E67C6E@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 06/05/2022 12:25, Luca Fancellu wrote: > >> The example DT is instructing Xen to have two cpu pools, one having two phisical >> cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the >> null scheduler and from the /chosen node we can see that a dom0less guest will >> be started on that cpu pool. >> >> In this particular case Xen must boot with different type of cpus, so the >> boot argument hmp_unsafe must be enabled. >> >> Luca Fancellu (7): >> tools/cpupools: Give a name to unnamed cpupools >> xen/sched: create public function for cpupools creation >> xen/sched: retrieve scheduler id by name >> xen/cpupool: Create different cpupools at boot time >> xen/cpupool: Don't allow removing cpu0 from cpupool0 >> arm/dom0less: assign dom0less guests to cpupools >> xen/cpupool: Allow cpupool0 to use different scheduler >> >> MAINTAINERS | 2 +- >> docs/misc/arm/device-tree/booting.txt | 5 + >> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++ >> tools/helpers/xen-init-dom0.c | 37 +++- >> tools/libs/light/libxl_utils.c | 3 +- >> xen/arch/arm/domain_build.c | 19 +- >> xen/arch/arm/include/asm/smp.h | 3 + >> xen/common/domain.c | 2 +- >> xen/common/sched/Kconfig | 7 + >> xen/common/sched/Makefile | 1 + >> xen/common/sched/boot-cpupool.c | 234 +++++++++++++++++++++++++ >> xen/common/sched/core.c | 40 +++-- >> xen/common/sched/cpupool.c | 43 ++++- >> xen/include/public/domctl.h | 5 +- >> xen/include/xen/sched.h | 53 ++++++ >> 15 files changed, 563 insertions(+), 31 deletions(-) >> create mode 100644 docs/misc/arm/device-tree/cpupools.txt >> create mode 100644 xen/common/sched/boot-cpupool.c >> >> -- >> 2.17.1 >> > > Ping? You seemed to have forgotten to CC the relevant maintainers on each patch and the cover letter. I only got this e-mail because I have a filter for some keywords. > > The v8 seems to be reviewed for all patch > > https://patchwork.kernel.org/project/xen-devel/list/?series=634064 AFAICT, patchwork only tells you the number of reviewed-by tag. It doesn't tell you whether the patch was suitably reviewed. Looking through the patches: #1: Ready #2: Ready #3: Ready #4: Missing review from the cpupool maintainers (Juergen or Dario) #5: Ready #6: Missing review from the cpupool maintainers #7: Ready Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 06 11:43:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:43:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322960.544458 (Exim 4.92) (envelope-from ) id 1nmwNB-0004bU-Pf; Fri, 06 May 2022 11:43:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322960.544458; Fri, 06 May 2022 11:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwNB-0004bN-Mi; Fri, 06 May 2022 11:43:49 +0000 Received: by outflank-mailman (input) for mailman id 322960; Fri, 06 May 2022 11:43:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwNA-0004bH-U4 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:43:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0629.outbound.protection.outlook.com [2a01:111:f400:fe0c::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca272749-cd31-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 13:43:47 +0200 (CEST) Received: from DBBPR09CA0042.eurprd09.prod.outlook.com (2603:10a6:10:d4::30) by VE1PR08MB5006.eurprd08.prod.outlook.com (2603:10a6:803:113::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 11:43:43 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::29) by DBBPR09CA0042.outlook.office365.com (2603:10a6:10:d4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Fri, 6 May 2022 11:43:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 11:43:42 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Fri, 06 May 2022 11:43:42 +0000 Received: from e7368ddd322b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B220FD43-CA9A-48F2-BF41-3EE879EE918E.1; Fri, 06 May 2022 11:43:31 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e7368ddd322b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 11:43:31 +0000 Received: from VI1PR08MB3967.eurprd08.prod.outlook.com (2603:10a6:803:df::16) by DBBPR08MB6059.eurprd08.prod.outlook.com (2603:10a6:10:202::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 11:43:27 +0000 Received: from VI1PR08MB3967.eurprd08.prod.outlook.com ([fe80::d529:a34d:5df0:47ae]) by VI1PR08MB3967.eurprd08.prod.outlook.com ([fe80::d529:a34d:5df0:47ae%3]) with mapi id 15.20.5206.028; Fri, 6 May 2022 11:43:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca272749-cd31-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FckjDgDMccQb0C1CHBKH+5kGn0Nvni0IkkJuu9yC0xoyTMVoxjyaJxl0tj8oep4E98eOC9yoURlVzL12uSi+gMpHoSnw238WcYqC+QLe2kt3GakpGIVlq1plsnE1tLJHygbGEXR7GtK9Fj8SP+mD9ERvGpBN+c2/p1wJyFBPGMiM8rz4BX/74Ct7UuUurxq3F256K9n0FggGnBu10c/uEJx1o9jungbFO4KbNCaJwRwhvuKrQHVqvnKz3KD6sPQPZMzFyoC9NFZk/X7+V5RU4wHDWpccirpq02N/ZDTIhrnM73LjNbXIBupuEAtYvjrRYUcs+GlCgq26zblnmUNShQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WXy3JtLng7ohu1dj92FGp1hY+RNsJ9Vt+cO9IyT1eQI=; b=aIaM4xUA8WXI0pfJooriG/vtjSZ2n+1QZBkWUqbwMfo0c9KLcOKyauBw7j5xdj4wC+0nyBSvfBGe6xsWiEb1hS/52IOxq5M8Tw3wQ2Tq8flhAl6EtSZWO8PEBo09Pj9Zzetluy1npfqSPvBUxWRWqOraLLacJrtS0UZC1NtBEwQYCE1LuIIBDuIKrxnmXdbxGMy0Vr773iVBEv7km3iaw4AZ8XYAgkgrj8AtPbYGj2Qdc9aHU/x4P/puWmF36iS+iqyxEpq+MDE48dN1Ya3de2Z1PDYk8BiGMnE4Whs4QbT2ENVgfZtJUSfI6Escqd6v64QUdcl/bLS5rwZIME4Scg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXy3JtLng7ohu1dj92FGp1hY+RNsJ9Vt+cO9IyT1eQI=; b=V/heoh6rliWkrxn08Gu203PUr/m7xYYYUb0axTVuWl3CoJZ3XLJir1MeUOVoEiS5wPfN7K/d9k6UMFwPaiu8RGLC1auZMOJZlL+PxkOuHneK+AS0SG95d0ocu2yJQam6HbOVA6kZEzxZPSxvEGs8Z8TuPiN/TXK3RYSqANoniD0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 22b35c96146ad874 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCRb3bXjg78sPFOwipwk3l/E0bnyQc5egu1o9UEETYTOJ+fwAS+HK2l5nZ+0FGUxNJ8AQg21sd7IahVOaqHNoshAsaA22ybfnM5ySP8qgar6c+RcAZ/8PKRfeJbwBKJ6wkK9zxUvbMSLVnLkbFdAw49XvIvmIaeGH8BTxQm+w/J8elmTQOBmUk2dg50aXXo0cpLkjaIk0majS5iV4Wff7XVPbVsXvi20rLcGHi4F4+a5zMUF1buL/DVvEqKcOtfK4dsC6Ph9AXBuv9nWFF+SaSzNBG9Y4HK/kvUtQs8pG/ecvNhmVB+IgplV2gjiC8gl+IeWg4MmvsMLpCGO7Z7TKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WXy3JtLng7ohu1dj92FGp1hY+RNsJ9Vt+cO9IyT1eQI=; b=SeTKjBGkC0T3d+dD4AECYiWq07SQc5dv8hdXa06IhZdNTCV/6EOJGfXqDDYdTL+bexK5xaWPDtV8ADQywTW5q08H663aYqpSlGc6flWierXen0/8n0yZ08ztTes+cytMX6JWB2b2aYCeCt0QuIWpIIM3iIrT6FrWNbq4ZMs9HAClEscb3+ACcWzHdExxqAUvzEP4AIwYl41igeUZeLAVcSzmvAaPsuZuwt/aRAjOp8CUg8EX8DZZsZ5CL6DfIHuBD9+m2L7Ur3G6XinZT7TVEJx5fNU7I1lq57NQQUeTOrhK3j8SUX8ps34yXye8OofEkxsCa5+vqmO1ldqSWepf4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXy3JtLng7ohu1dj92FGp1hY+RNsJ9Vt+cO9IyT1eQI=; b=V/heoh6rliWkrxn08Gu203PUr/m7xYYYUb0axTVuWl3CoJZ3XLJir1MeUOVoEiS5wPfN7K/d9k6UMFwPaiu8RGLC1auZMOJZlL+PxkOuHneK+AS0SG95d0ocu2yJQam6HbOVA6kZEzxZPSxvEGs8Z8TuPiN/TXK3RYSqANoniD0= From: Luca Fancellu To: Julien Grall CC: xen-devel , Bertrand Marquis , Wei Chen Subject: Re: [PATCH v8 0/7] Boot time cpupools Thread-Topic: [PATCH v8 0/7] Boot time cpupools Thread-Index: AQHYVVhdzvmSbSkA9kKhcVjYQ/ksyq0RzUeAgAAEKQCAAADfgA== Date: Fri, 6 May 2022 11:43:27 +0000 Message-ID: <4A9E62B2-0038-4558-A422-50E3E09B8480@arm.com> References: <20220421081645.40235-1-luca.fancellu@arm.com> <0EA6F35B-89E9-45AC-9274-567F86E67C6E@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f2ffc2a3-428d-4c5e-a90e-08da2f55abbb x-ms-traffictypediagnostic: DBBPR08MB6059:EE_|DBAEUR03FT053:EE_|VE1PR08MB5006:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vcFXAD8FRa9dNn2oV58mvgJuZGh8PiQSTpAYCNLmd9BpIxSXFOYt3qPycdJzYKPTigb9HZKH5fCXaU+RPKIH4EM9lwouzaxFpKK4lng1JyhbatidSQ6pc5WAF5C4Ew2NBPbPutjeFwHFSYmaGRpiHace2BRz5guURAt85NvLL2/wxotyqkCpTSS5L9VGMRw4ertmGDQ24CntG1glS23zgDR28jetOzQ1ifKnONwAyuubVgtUqCA2Xl2pFSTEQwqZGx6hN5GdM/8ApKryZzSWSlLOPH6JFS9h52S/cT0IhB8EyGj+4xDkbza6xdFbxT/ZIoOSsHrou9V0HaBYLuLh+YQ2pVuv5pXmB5cDS3AGksAVPZ7OsvHYdy+4TdfboJ3AQL4BetSTBMeyEz/Vl2ZwIpDl0BEM2DnMe4lR/SjRKkVL3R+UzVSm9t20KtIy20/8THLtZnMNbsflJSGg9gRzPkzojy+edUluSKuxW3YDFHR9Gtv1m6Em8pgdw3spWWHZR5J3M6fEhSEUp+alw3+4kHy2PLQ9XoyC09EPF1Yy3dPtUClVMZT1SjgatPskldV4KdM+ltIzKPdq/tErM92J2MgLpW7ZT0oSfPFJE8+G62Uizcru+hGWBjlzZwEra/3AGoWh/NmK3dwNYknV18KhYywvEfyl9PvI4BUwg6CLNWcee+rOibdZ5RqjMDhEFZ+rnsVQVg8VsgRrHM9GyrGLXs4SnGHvIso/uIsuD2/Jr59QXKsYqMOFYdTp6dzJ6hGnl1wNOkyR5UF1J7RFFHgTboIntXes2XT7g5YK6inCLsbajMSu8aV3xt/ynwoIprsWIFSIEM6k5wZq0yXzwbvhXw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3967.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(71200400001)(186003)(6486002)(508600001)(966005)(33656002)(6506007)(8936002)(66476007)(66556008)(66946007)(2906002)(76116006)(316002)(91956017)(8676002)(64756008)(4326008)(66446008)(36756003)(5660300002)(38100700002)(38070700005)(122000001)(86362001)(26005)(6512007)(6916009)(2616005)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <6C507B5DC23F9C4EAD8D843DD0A83E44@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6059 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 93c14bd0-32ff-48a1-bbe9-08da2f55a2d5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JDJUmqALx3e099qTLhyq3eBgh2fLuxEDY9H87FdADbikDAcZKTzrGhFwNDwk+aeqXbABbx1oKdxZZMdiOhrL2YXlwFH42S3JuTV/I7hNo0SxUIBtGepjA+rrIzzxVzLV5n1TD+L7dJ5bgLD/578JFLELB9MJwjPWkegCTYWpnVTWZfmwUuCTyM9VR6imY8K/pb8RdVmN7NfCPHUbm/pllfAGcVLX/0MEH7V0D1JIc/M5L2nNoGrHwcsaf0mIPXofKTm/5lBSiwDC+lnWl9vd961Mp4hFnBY2QPRX7+AKGIolGPOc4ie9DjsY1nEIL3+rC4miAnZCs8gEstaojNvctAfLoPwr0DyoqUlRrjlHMyyt+63NpQFWJR6VV6rvCRMUEPipvVAIxujfCXJotpm/ye3cklKvenVZw1TTbG2XdXtOPQPJh8m1C5rENa9K4k2TTnHD3G4sbboblln+yOz7PKIERaZAlxo50qfnJwY55Y1XMyi2yBv1sILqiQlwS11zui79XQKoLUv8NbPGy3iVwEfkkvzx2r58qy1ldhU1S8WGe0JlY7gIgAd/jfziOmkUY15oPTmhFp1wz8Db8LHi7fH+HoqJUNSJs9tGcBHJG1ILxYn5QjF2ss6TLuTV2jwNHxkvoc17aOjnCOpGRF49Le85gpmiRjBENVXTGZieW+Na5mHVph1dTlMFOo/K6jMm34V4FDmlVexvPpQmXshwPS7Ab8hd7kFxp6KdNi0FOSTSA+lWcs759SzdQchZ2tqhE5xuAz5b3h3wly1uLfNZAA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(86362001)(81166007)(966005)(5660300002)(2906002)(26005)(6486002)(508600001)(316002)(36756003)(2616005)(336012)(47076005)(186003)(8936002)(54906003)(82310400005)(33656002)(40460700003)(6512007)(83380400001)(8676002)(70586007)(356005)(4326008)(6862004)(70206006)(6506007)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:43:42.6118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2ffc2a3-428d-4c5e-a90e-08da2f55abbb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5006 Pj4+IA0KPj4+IEx1Y2EgRmFuY2VsbHUgKDcpOg0KPj4+IHRvb2xzL2NwdXBvb2xzOiBHaXZlIGEg bmFtZSB0byB1bm5hbWVkIGNwdXBvb2xzDQo+Pj4geGVuL3NjaGVkOiBjcmVhdGUgcHVibGljIGZ1 bmN0aW9uIGZvciBjcHVwb29scyBjcmVhdGlvbg0KPj4+IHhlbi9zY2hlZDogcmV0cmlldmUgc2No ZWR1bGVyIGlkIGJ5IG5hbWUNCj4+PiB4ZW4vY3B1cG9vbDogQ3JlYXRlIGRpZmZlcmVudCBjcHVw b29scyBhdCBib290IHRpbWUNCj4+PiB4ZW4vY3B1cG9vbDogRG9uJ3QgYWxsb3cgcmVtb3Zpbmcg Y3B1MCBmcm9tIGNwdXBvb2wwDQo+Pj4gYXJtL2RvbTBsZXNzOiBhc3NpZ24gZG9tMGxlc3MgZ3Vl c3RzIHRvIGNwdXBvb2xzDQo+Pj4geGVuL2NwdXBvb2w6IEFsbG93IGNwdXBvb2wwIHRvIHVzZSBk aWZmZXJlbnQgc2NoZWR1bGVyDQo+Pj4gDQo+Pj4gTUFJTlRBSU5FUlMgfCAyICstDQo+Pj4gZG9j cy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCB8IDUgKw0KPj4+IGRvY3MvbWlzYy9h cm0vZGV2aWNlLXRyZWUvY3B1cG9vbHMudHh0IHwgMTQwICsrKysrKysrKysrKysrKw0KPj4+IHRv b2xzL2hlbHBlcnMveGVuLWluaXQtZG9tMC5jIHwgMzcgKysrLQ0KPj4+IHRvb2xzL2xpYnMvbGln aHQvbGlieGxfdXRpbHMuYyB8IDMgKy0NCj4+PiB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMg fCAxOSArLQ0KPj4+IHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zbXAuaCB8IDMgKw0KPj4+IHhl bi9jb21tb24vZG9tYWluLmMgfCAyICstDQo+Pj4geGVuL2NvbW1vbi9zY2hlZC9LY29uZmlnIHwg NyArDQo+Pj4geGVuL2NvbW1vbi9zY2hlZC9NYWtlZmlsZSB8IDEgKw0KPj4+IHhlbi9jb21tb24v c2NoZWQvYm9vdC1jcHVwb29sLmMgfCAyMzQgKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4+ IHhlbi9jb21tb24vc2NoZWQvY29yZS5jIHwgNDAgKysrLS0NCj4+PiB4ZW4vY29tbW9uL3NjaGVk L2NwdXBvb2wuYyB8IDQzICsrKystDQo+Pj4geGVuL2luY2x1ZGUvcHVibGljL2RvbWN0bC5oIHwg NSArLQ0KPj4+IHhlbi9pbmNsdWRlL3hlbi9zY2hlZC5oIHwgNTMgKysrKysrDQo+Pj4gMTUgZmls ZXMgY2hhbmdlZCwgNTYzIGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQ0KPj4+IGNyZWF0 ZSBtb2RlIDEwMDY0NCBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2NwdXBvb2xzLnR4dA0KPj4+ IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vY29tbW9uL3NjaGVkL2Jvb3QtY3B1cG9vbC5jDQo+Pj4g DQo+Pj4gLS0gDQo+Pj4gMi4xNy4xDQo+Pj4gDQo+PiBQaW5nPw0KPiANCj4gWW91IHNlZW1lZCB0 byBoYXZlIGZvcmdvdHRlbiB0byBDQyB0aGUgcmVsZXZhbnQgbWFpbnRhaW5lcnMgb24gZWFjaCBw YXRjaCBhbmQgdGhlIGNvdmVyIGxldHRlci4gSSBvbmx5IGdvdCB0aGlzIGUtbWFpbCBiZWNhdXNl IEkgaGF2ZSBhIGZpbHRlciBmb3Igc29tZSBrZXl3b3Jkcy4NCj4gDQo+PiBUaGUgdjggc2VlbXMg dG8gYmUgcmV2aWV3ZWQgZm9yIGFsbCBwYXRjaA0KPj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVs Lm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9saXN0Lz9zZXJpZXM9NjM0MDY0DQo+IA0KPiBBRkFJQ1Qs IHBhdGNod29yayBvbmx5IHRlbGxzIHlvdSB0aGUgbnVtYmVyIG9mIHJldmlld2VkLWJ5IHRhZy4g SXQgZG9lc24ndCB0ZWxsIHlvdSB3aGV0aGVyIHRoZSBwYXRjaCB3YXMgc3VpdGFibHkgcmV2aWV3 ZWQuDQo+IA0KPiBMb29raW5nIHRocm91Z2ggdGhlIHBhdGNoZXM6DQo+ICMxOiBSZWFkeQ0KPiAj MjogUmVhZHkNCj4gIzM6IFJlYWR5DQo+ICM0OiBNaXNzaW5nIHJldmlldyBmcm9tIHRoZSBjcHVw b29sIG1haW50YWluZXJzIChKdWVyZ2VuIG9yIERhcmlvKQ0KPiAjNTogUmVhZHkNCj4gIzY6IE1p c3NpbmcgcmV2aWV3IGZyb20gdGhlIGNwdXBvb2wgbWFpbnRhaW5lcnMNCj4gIzc6IFJlYWR5DQo+ IA0KDQpUaGFua3MgSnVsaWVuLCBpbmRlZWQgbXkgcGluZyBkaWRu4oCZdCBDQyB0aGUgbWFpbnRh aW5lcnMsIEkgd2lsbCBwaW5nIHNlcGFyYXRlbHkgb24gdGhlICM0IGFuZCAjNiBwYXRjaGVzLg0K DQpDaGVlcnMsDQpMdWNhDQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0K DQo= From xen-devel-bounces@lists.xenproject.org Fri May 06 11:47:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 11:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322966.544470 (Exim 4.92) (envelope-from ) id 1nmwR1-0005Ji-BF; Fri, 06 May 2022 11:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322966.544470; Fri, 06 May 2022 11:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwR1-0005Jb-8G; Fri, 06 May 2022 11:47:47 +0000 Received: by outflank-mailman (input) for mailman id 322966; Fri, 06 May 2022 11:47:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwQz-0005JV-OZ for xen-devel@lists.xenproject.org; Fri, 06 May 2022 11:47:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57660ed7-cd32-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 13:47:44 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-28-Uyc_Q3PNPpOlIRvDEebKUQ-1; Fri, 06 May 2022 13:47:41 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DU2PR04MB8503.eurprd04.prod.outlook.com (2603:10a6:10:2d2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 11:47:40 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 11:47:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57660ed7-cd32-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651837663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHj7kxwdA7oUVypSDJu19yI0OKWwgUQFQbOc/diBkww=; b=XO7FvvIBcsE4sk1SpiuQIg5wmSFM7LuztnBP3bZFDJrHaeszulHXMIr6uZZp/xcLN/WGhV Ug0pWhiI2WgFaENAU6MhyaXToTgHHzYkAO1A2Lfqnd1ONaabw/L/KdTx4Zp3zH9FfM+x2v f8SwwU72h/dPTHF8qiFYG5snAvynuyQ= X-MC-Unique: Uyc_Q3PNPpOlIRvDEebKUQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FO5ZFrVFFiahHpz9wA9f93JRQ0pAtldNYb7hMxjyJrs/WelJWdfzUTH/LWxwJ42gZMdhUjciD+BW1hJXiSVzYJ8mw/JxGiEXNq3WiurSQOHjvun4xSdYyq8MA2BtG8mKPcGDqdoMtPvhTpBbVIUugA0fE8AlFiYOLWK106sRNXj7eduYG8eOWa1sXduocrwfU68ImRgLvKsP7jSDkEFaxHhTy78ZsqYEwXEuGgZxBdXVWbop0ycd7kjWxvqP6WnYmtfJrzG5+PpqB5xfGr+pRd+rmf/x0BALMOuomap1Qngjd/wwY9EtU9x31g2T34rB0XclDFbzETJr1qEpitODFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHj7kxwdA7oUVypSDJu19yI0OKWwgUQFQbOc/diBkww=; b=ZcjKRMwKX1AkXeHWH9PPU1IQNOeXfpEqolfjNZeq5iTC392pYs6lRqMqtsjdxMHaL+IgQQ2eWdr4Wxk1DgUtBq3/SBOkdan8j6jklhDIJl4udI2Tpgtj4sUTgTy/AfH4T7expIJMA32AgPpZ6cE0Eep8b8K0BmxOPc6qA/MxQpA6I8Qew3ubY7CenIZ52NEroh1bneIh95F21O9QdCfxEvv2yBfR4Se31sW8WcJIBO/7haDy6BJwSRQLK5vmOn1JSn/s3KsaXJXWiNOncoRe5Edxalt0gUaaOEnwl01cQ2HuKFr/pYNeapf3LvW059bZ7/kre43Hf/m8vp6/by08vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 13:47:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 Content-Language: en-US From: Jan Beulich To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99ec0333-917c-4051-7da7-08da2f563929 X-MS-TrafficTypeDiagnostic: DU2PR04MB8503:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5rHF6Bsqgo+FjjAcEOJWUG4GHWZFWzJ8zy8ncCVcRnUFxnBR8NEmBui/p1UfDJ/0p4l5HHBc4GRdset+tSjUmyYqyzFHTCxd3d99JrJPdfxYMTJhCCBpLStYOfS7afeXWL1u8a6pgjWU9mrDdVgpBkGbSz5qEASrzsAKxRQL5HPGEBK1nBGgSCfydXEkmZLhGzdODk53y+a5/hUqc6nd/EEKFfihHdP8L/dXmyG4z8aqqJfHyHSLu/+MZ2yrSDJqhEES6TWSFBiIAY8LEbPEbjW4WWvMoPlOCpnL5MLwwSCEpU6w7buseGxJsw1muiaM/p+JzDo1bg2/IyJxTJ86ZAilkj5WLzA28bXG704p8f7/mXgfZB1iW6a6CZi0uC8nVHUsx/QOz3GrKWcUwHixwNN0mGEEeU1bnp2dre2FBrye80OgYRXJcn8nmv9NjZI//SI3QT6FVTUBxF66G+dXWujiQ5MG5gceV8dM/UnGua4yEGw38mqU40dnbgnKk/Jqio2z3we1bk6AHg2gIkLQMmKu+w0xo2QmUj10cIvU/zJhheM8m+JCEQbCy+tXF+tVOZn3Wyi04cOTtZUiXQcm9jlUcQ882B68oSQma3Bu2tzknLxjaPexofR/E53w3uefU0E0vXHCszTMjgr6SmZYg7XpEHZFEPeFA8T0DjWBHujyWfN5H+TkG1nRxNDwOBdRm+cQ84o3BpsjEesZXm0ZHyBwdR1t0iWXGzooqQs0Qqw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(5660300002)(31696002)(508600001)(86362001)(6916009)(31686004)(186003)(6486002)(36756003)(316002)(53546011)(66946007)(8676002)(4326008)(66556008)(6506007)(2616005)(83380400001)(2906002)(66476007)(8936002)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0QzRWdYdmYrUHp5cjdBU1NCWWMyeTBxM1ZPWUhDM2FSUEs3Z3VyM3kvMVY4?= =?utf-8?B?bk9YU3RyV3JMTFBldEF1OXI3ZnQvV0hsV05tUmdZUzJLYTRrNVdyUW9HM0dO?= =?utf-8?B?ekNpRWo5Q1BDdzNBK2ZUa0RaS3pXSFhteGRZQXNKSGg1MGRLeTdSbTJpSFhF?= =?utf-8?B?dGpMSlpsMG5TR1dra2ZaM0k1S2gvYndqL3RYb0RGWS93Y3RESk9ueWNSWGU4?= =?utf-8?B?b0lWVmVPRzhFdFN3UnR4VExJUmhNMDh0Unl4M202Z21La2ZzYUtvMlBBckpy?= =?utf-8?B?Mmg5YzNxTklvck45NEUxT0xJbTBHYUlGeWgzK3ZwWXg4dXp0ZGZUL21hQlBI?= =?utf-8?B?eUZua0N2bHNnZG0wbHJKRTFNOTBHZW9Tc0ZSL0NxQ0lkZFdvZWRWaFJLKzBE?= =?utf-8?B?UWhWbGxJUU1mMDVIT0pwSFl5a1F3TnprTDk5WTdCU3RmSkdmL2xtb1owMktC?= =?utf-8?B?M1NocU1SUnFGUld4R1UvNDljTUdiaW5EZmxyellIK1BMZk1OalR0WE8xWTZ5?= =?utf-8?B?SXgrVVpjQlo4dFNQSTAraUVyZ3JCemxJSzhmTE5wNDhiamRkRjlTNVpzUHd1?= =?utf-8?B?UTl6V1lQajh0VGdZYUlPRzE5VVhqNUdhZVh4VklnK2I1R2RFZ3Q3UW1NS0RQ?= =?utf-8?B?RlhPQmhEeG9DM0NkQzVSekFiNmc4QzVsbTlBSFlTZ281ZmlvelY5U0xReTBU?= =?utf-8?B?RzFYVXhtbDVVeExFT1UrczIzVU1PVG4rK3RIeHVhRUVrWEMrVFd3UC9ET29x?= =?utf-8?B?NlV5a1NELzIycHRseW93Mms1MG85WTR0NU9KakE0WWV6NnIxaU9UelJzMXZh?= =?utf-8?B?WXNFR2hDSVZkYmU3OVZ6RGdodnFHU2dSZ2R2eWNkRlIvRjJpcEUwY0ppWVpl?= =?utf-8?B?YUw3ME1PM2Y4aUtLeCtyTTF2R2t2N09BaCs1aTh3elBCN21NeTRXYUZQbTJ3?= =?utf-8?B?SFAxUWJpK2Q1U2VmWXBySFUzT3llMGNrOWJUQnBMTU05ZDh4Wno2aXg5Z2Q5?= =?utf-8?B?MEc4bkQwaDlHV3RnWFdHWm9xSkRWOXB6Wk9BZkNOL1pjbytIUXRwU2owTS85?= =?utf-8?B?Zkl1b3RXcGIzU3phWHZQamZXRGowOEJGbGF3b2FrOEhNVVFsTXNGY1RYc3Bh?= =?utf-8?B?b0RjZ3lGa3V6ZEtwMUdMRi8ycjVxaFRWMHFBNGZUNlVkUVh1QXlEWm1KTXJT?= =?utf-8?B?ZTZ6ZVRHZ1czWHgvbENvdDYzNjh4eUZMb291NC8wZmhQS1ZON0ZSSmErSllu?= =?utf-8?B?Z0pJL0tYR3E1L2w5VndWMTBtNlFkRUhNSzgremtRRGUyQU9xS3locnBuVzBL?= =?utf-8?B?bC9qdk1iTmdTL0l0UXpieXB3T0xoV3U5cHdtdnlxenlqOFNHTFBEb3gvYVVQ?= =?utf-8?B?R00rYVdIOFcvbUF6MnRORVVSVGV3b1M0VjZFNENoZGN4bmZQSW55SEZZRFZ0?= =?utf-8?B?bHV2ZHlzNHlhL3NGM3dmUE5xakwzbUdyaDdlQnFEQWVPNmJWMmdmUlU3K2J2?= =?utf-8?B?TVNuOUdmVlFralU3VUZ0Vk5wdUJhSndKek42aXhlemkzSnNSbEM0dmRBV0xk?= =?utf-8?B?ZFlWOWt5bFRWUDV5LzlGMng4NVZtOHZTMFlQRWQyRW1FRDlRM0hNd0VscHQ0?= =?utf-8?B?U0VTaURMT2FOYlNlQUZJb1IrendrU0d6OXJxZVp2QVltc3I1T0ZuMldzb0Z5?= =?utf-8?B?SWZkMWlUUmJGeGR4a2R3dC8yK2lpM0xQOTNUaHhaTm0rS1VXMXhMM0NsWjl6?= =?utf-8?B?QjRzNHpibytFN1pJUXFmR21lNDdOZ0kzejFDOUYyQjliUFM0eWhmeHRUeXhT?= =?utf-8?B?clNSVFJXZHE1MGhmUzhjVEt6N3pEQ2g0OElUcjVxY0FuMkRLRG82SWhDUlAx?= =?utf-8?B?bVp6czlnb1QrRVo2WGV4b1lhbVVYQTNCbHdMTGtwVHBIQi80bUN5dm5mYVNR?= =?utf-8?B?SEQyMTFMUTNGNmRLb1kwQkxlS2I4bHg0TStyaHIzMGdXL1Z2bXRFa3QzUjBo?= =?utf-8?B?OEh0UERtcUVtanZlZmxGVVpiVk41VC9IMiswby9la3RKR3VVcDJ1dFp3Zm03?= =?utf-8?B?TE90bTJDa2d0SW93bS9HZHJ5N25sVXB5VFkwbUJzK296SEdGc1p3U0Z1eFNB?= =?utf-8?B?QU04N29PRUlWRWJzemhsQXREM0Y4elppV1RkVFRwZ1Y0UGd3SW55UjhmakJZ?= =?utf-8?B?MTg1bUVNWmllM3Nwc3hsK2VZM05RcVczeG1VUUxqTUhUV2xiR1NkS3YxeDBa?= =?utf-8?B?S1NuU1BtbXBkajZlYWl1cER5VlczMXZnT2grT2xUcnJBZ2trMENIcndpd0ti?= =?utf-8?B?VlhJNWpqSDhmekVKYXdHSEFVTEdEZk1UYW4vTTQyTjV2UlVwelJlUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99ec0333-917c-4051-7da7-08da2f563929 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:47:40.0947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: up+/+dRWt6LxUcs0ygMLKamZps0fgvPYCL6SVqRc7MH2SPfuJFqbbt5+7H2EJnf//dsUX1NjfHqG/FyOz9dHRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8503 On 06.05.2022 12:59, Jan Beulich wrote: > On 05.05.2022 07:38, Demi Marie Obenour wrote: >> @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste >> if ( EFI_ERROR(status) ) >> PrintErrMesg(L"Cannot obtain memory map", status); >> >> + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) >> + { >> + if ( !is_esrt_valid(efi_memmap + i) ) >> + continue; > > Instead of repeating the size calculation below, could you make the > function (with an altered name) simply return the size (and zero if > not [valid] ESRT), simplifying things below? > >> + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type != >> + EfiRuntimeServicesData ) >> + { >> + /* ESRT needs to be moved to memory of type EfiRuntimeServicesData >> + * so that the memory it is in will not be used for other purposes */ > > Nit: Comment style. > >> + size_t esrt_size = offsetof(ESRT, Entries) + >> + ((ESRT *)esrt)->Count * sizeof(ESRT_ENTRY); >> + void *new_esrt = NULL; >> + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, &new_esrt); > > Nit: Please have a blank line between declaration(s) and statement(s). > >> + if ( status != EFI_SUCCESS ) >> + { >> + PrintErrMesg(L"Cannot allocate memory for ESRT", status); > > Neither this nor ... > >> + break; >> + } >> + memcpy(new_esrt, (void *)esrt, esrt_size); >> + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); >> + if ( status != EFI_SUCCESS ) >> + { >> + PrintErrMesg(L"Cannot install new ESRT", status); >> + efi_bs->FreePool(new_esrt); > > ... this ought to be fatal to the booting of Xen. Yet PrintErrMesg() > ends in blexit(). > >> + } >> + } >> + break; >> + } >> + >> efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_size, >> efi_mdesc_size, mdesc_ver); > > The allocation may have altered the memory map and hence invalidated what > was retrieved just before. You'd need to "continue;" without setting > "retry" to true, but then the question is why you make this allocation > after retrieving the memory map in the first place. It's not entirely > clear to me if it can be done _much_ earlier (if it can, doing it earlier > would of course be better), but since you need to do it before > ExitBootServices() anyway, and since you will need to call GetMemoryMap() > afterwards again, you could as well do it before calling GetMemoryMap(). Over lunch I figured that this was partly rubbish. Of course you need to do the check after GetMemoryMap(). But I still think it would be better if you moved this out of this function (or at the very least out of the loop) and not piggy-back on the ExitBootServices() retry mechanism. I'd be afraid this could end up in a single retry not being sufficient. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322978.544531 (Exim 4.92) (envelope-from ) id 1nmwdO-0000Pe-6h; Fri, 06 May 2022 12:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322978.544531; Fri, 06 May 2022 12:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdN-0000P7-VZ; Fri, 06 May 2022 12:00:33 +0000 Received: by outflank-mailman (input) for mailman id 322978; Fri, 06 May 2022 12:00:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdM-0007iX-9T for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 20c4ebcb-cd34-11ec-a406-831a346695d4; Fri, 06 May 2022 14:00:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB718113E; Fri, 6 May 2022 05:00:30 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F36EF3F7F5; Fri, 6 May 2022 05:00:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20c4ebcb-cd34-11ec-a406-831a346695d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Juergen Gross , Dario Faggioli , George Dunlap Subject: [PATCH v8 5/7] xen/cpupool: Don't allow removing cpu0 from cpupool0 Date: Fri, 6 May 2022 13:00:10 +0100 Message-Id: <20220506120012.32326-6-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Cpu0 must remain in cpupool0, otherwise some operations like moving cpus between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, might not work in a sane way. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - Add R-by (Juergen) Changes in v7: - new patch --- xen/common/sched/cpupool.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 86a175f99cd5..0a93bcc631bf 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -572,6 +572,7 @@ static long cf_check cpupool_unassign_cpu_helper(void *info) * possible failures: * - last cpu and still active domains in cpupool * - cpu just being unplugged + * - Attempt to remove boot cpu from cpupool0 */ static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu) { @@ -582,7 +583,12 @@ static int cpupool_unassign_cpu(struct cpupool *c, unsigned int cpu) debugtrace_printk("cpupool_unassign_cpu(pool=%u,cpu=%d)\n", c->cpupool_id, cpu); - if ( !cpu_online(cpu) ) + /* + * Cpu0 must remain in cpupool0, otherwise some operations like moving cpus + * between cpupools, cpu hotplug, destroying cpupools, shutdown of the host, + * might not work in a sane way. + */ + if ( (!c->cpupool_id && !cpu) || !cpu_online(cpu) ) return -EINVAL; master_cpu = sched_get_resource_cpu(cpu); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322979.544547 (Exim 4.92) (envelope-from ) id 1nmwdP-0000u9-UF; Fri, 06 May 2022 12:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322979.544547; Fri, 06 May 2022 12:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdP-0000tu-Ky; Fri, 06 May 2022 12:00:35 +0000 Received: by outflank-mailman (input) for mailman id 322979; Fri, 06 May 2022 12:00:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdO-0007iY-9s for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 21bff693-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:33 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2B24113E; Fri, 6 May 2022 05:00:32 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21AFB3F7F5; Fri, 6 May 2022 05:00:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21bff693-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Juergen Gross , Dario Faggioli Subject: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Date: Fri, 6 May 2022 13:00:11 +0100 Message-Id: <20220506120012.32326-7-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Introduce domain-cpupool property of a xen,domain device tree node, that specifies the cpupool device tree handle of a xen,cpupool node that identifies a cpupool created at boot time where the guest will be assigned on creation. Add member to the xen_domctl_createdomain public interface so the XEN_DOMCTL_INTERFACE_VERSION version is bumped. Add public function to retrieve a pool id from the device tree cpupool node. Update documentation about the property. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v8: - no changes Changes in v7: - Add comment for cpupool_id struct member. (Jan) Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes - add R-by Changes in v3: - Use explicitely sized integer for struct xen_domctl_createdomain cpupool_id member. (Stefano) - Changed code due to previous commit code changes Changes in v2: - Moved cpupool_id from arch specific to common part (Juergen) - Implemented functions to retrieve the cpupool id from the cpupool dtb node. --- docs/misc/arm/device-tree/booting.txt | 5 +++++ xen/arch/arm/domain_build.c | 14 +++++++++++++- xen/common/domain.c | 2 +- xen/common/sched/boot-cpupool.c | 24 ++++++++++++++++++++++++ xen/include/public/domctl.h | 5 ++++- xen/include/xen/sched.h | 9 +++++++++ 6 files changed, 56 insertions(+), 3 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index a94125394e35..7b4a29a2c293 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -188,6 +188,11 @@ with the following properties: An empty property to request the memory of the domain to be direct-map (guest physical address == physical address). +- domain-cpupool + + Optional. Handle to a xen,cpupool device tree node that identifies the + cpupool where the guest will be started at boot. + Under the "xen,domain" compatible node, one or more sub-nodes are present for the DomU kernel and ramdisk. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 5df5c8ffb8ba..aa777741bdd0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3174,7 +3174,8 @@ static int __init construct_domU(struct domain *d, void __init create_domUs(void) { struct dt_device_node *node; - const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); + const struct dt_device_node *cpupool_node, + *chosen = dt_find_node_by_path("/chosen"); BUG_ON(chosen == NULL); dt_for_each_child_node(chosen, node) @@ -3243,6 +3244,17 @@ void __init create_domUs(void) vpl011_virq - 32 + 1); } + /* Get the optional property domain-cpupool */ + cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0); + if ( cpupool_node ) + { + int pool_id = btcpupools_get_domain_pool_id(cpupool_node); + if ( pool_id < 0 ) + panic("Error getting cpupool id from domain-cpupool (%d)\n", + pool_id); + d_cfg.cpupool_id = pool_id; + } + /* * The variable max_init_domid is initialized with zero, so here it's * very important to use the pre-increment operator to call diff --git a/xen/common/domain.c b/xen/common/domain.c index 8d2c2a989708..7570eae91a24 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -697,7 +697,7 @@ struct domain *domain_create(domid_t domid, if ( !d->pbuf ) goto fail; - if ( (err = sched_init_domain(d, 0)) != 0 ) + if ( (err = sched_init_domain(d, config->cpupool_id)) != 0 ) goto fail; if ( (err = late_hwdom_init(d)) != 0 ) diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c index 9429a5025fc4..240bae4cebb8 100644 --- a/xen/common/sched/boot-cpupool.c +++ b/xen/common/sched/boot-cpupool.c @@ -22,6 +22,8 @@ static unsigned int __initdata next_pool_id; #define BTCPUPOOLS_DT_NODE_NO_REG (-1) #define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2) +#define BTCPUPOOLS_DT_WRONG_NODE (-3) +#define BTCPUPOOLS_DT_CORRUPTED_NODE (-4) static int __init get_logical_cpu_from_hw_id(unsigned int hwid) { @@ -56,6 +58,28 @@ get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node) return cpu_num; } +int __init btcpupools_get_domain_pool_id(const struct dt_device_node *node) +{ + const struct dt_device_node *phandle_node; + int cpu_num; + + if ( !dt_device_is_compatible(node, "xen,cpupool") ) + return BTCPUPOOLS_DT_WRONG_NODE; + /* + * Get first cpu listed in the cpupool, from its reg it's possible to + * retrieve the cpupool id. + */ + phandle_node = dt_parse_phandle(node, "cpupool-cpus", 0); + if ( !phandle_node ) + return BTCPUPOOLS_DT_CORRUPTED_NODE; + + cpu_num = get_logical_cpu_from_cpu_node(phandle_node); + if ( cpu_num < 0 ) + return cpu_num; + + return pool_cpu_map[cpu_num]; +} + static int __init check_and_get_sched_id(const char* scheduler_name) { int sched_id = sched_get_id_by_name(scheduler_name); diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index b85e6170b0aa..84e75829b980 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -38,7 +38,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000014 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. @@ -106,6 +106,9 @@ struct xen_domctl_createdomain { /* Per-vCPU buffer size in bytes. 0 to disable. */ uint32_t vmtrace_size; + /* CPU pool to use; specify 0 or a specific existing pool */ + uint32_t cpupool_id; + struct xen_arch_domainconfig arch; }; diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 74b3aae10b94..32d2a6294b6d 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -1188,6 +1188,7 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi); void btcpupools_allocate_pools(void); unsigned int btcpupools_get_cpupool_id(unsigned int cpu); void btcpupools_dtb_parse(void); +int btcpupools_get_domain_pool_id(const struct dt_device_node *node); #else /* !CONFIG_BOOT_TIME_CPUPOOLS */ static inline void btcpupools_allocate_pools(void) {} @@ -1196,6 +1197,14 @@ static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu) { return 0; } +#ifdef CONFIG_HAS_DEVICE_TREE +static inline int +btcpupools_get_domain_pool_id(const struct dt_device_node *node) +{ + return 0; +} +#endif + #endif #endif /* __SCHED_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322976.544514 (Exim 4.92) (envelope-from ) id 1nmwdL-0008Tg-GB; Fri, 06 May 2022 12:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322976.544514; Fri, 06 May 2022 12:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdL-0008TZ-Cy; Fri, 06 May 2022 12:00:31 +0000 Received: by outflank-mailman (input) for mailman id 322976; Fri, 06 May 2022 12:00:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdJ-0007iY-Lj for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1ef06350-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:28 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E389C113E; Fri, 6 May 2022 05:00:27 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 87C9C3F7F5; Fri, 6 May 2022 05:00:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ef06350-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Dario Faggioli , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v8 3/7] xen/sched: retrieve scheduler id by name Date: Fri, 6 May 2022 13:00:08 +0100 Message-Id: <20220506120012.32326-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Add a static function to retrieve the scheduler pointer using the scheduler name. Add a public function to retrieve the scheduler id by the scheduler name that makes use of the new static function. Take the occasion to replace open coded scheduler search with the new static function in scheduler_init. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross Reviewed-by: Dario Faggioli --- Changes in v8: - no changes Changes in v7: - Add R-by (Dario) Changes in v6: - no changes Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - add R-by Changes in v2: - replace open coded scheduler search in scheduler_init (Juergen) --- xen/common/sched/core.c | 40 ++++++++++++++++++++++++++-------------- xen/include/xen/sched.h | 11 +++++++++++ 2 files changed, 37 insertions(+), 14 deletions(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 8a8c25bbda47..8c73489654a1 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2947,10 +2947,30 @@ void scheduler_enable(void) scheduler_active = true; } +static inline +const struct scheduler *__init sched_get_by_name(const char *sched_name) +{ + unsigned int i; + + for ( i = 0; i < NUM_SCHEDULERS; i++ ) + if ( schedulers[i] && !strcmp(schedulers[i]->opt_name, sched_name) ) + return schedulers[i]; + + return NULL; +} + +int __init sched_get_id_by_name(const char *sched_name) +{ + const struct scheduler *scheduler = sched_get_by_name(sched_name); + + return scheduler ? scheduler->sched_id : -1; +} + /* Initialise the data structures. */ void __init scheduler_init(void) { struct domain *idle_domain; + const struct scheduler *scheduler; int i; scheduler_enable(); @@ -2981,25 +3001,17 @@ void __init scheduler_init(void) schedulers[i]->opt_name); schedulers[i] = NULL; } - - if ( schedulers[i] && !ops.name && - !strcmp(schedulers[i]->opt_name, opt_sched) ) - ops = *schedulers[i]; } - if ( !ops.name ) + scheduler = sched_get_by_name(opt_sched); + if ( !scheduler ) { printk("Could not find scheduler: %s\n", opt_sched); - for ( i = 0; i < NUM_SCHEDULERS; i++ ) - if ( schedulers[i] && - !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) ) - { - ops = *schedulers[i]; - break; - } - BUG_ON(!ops.name); - printk("Using '%s' (%s)\n", ops.name, ops.opt_name); + scheduler = sched_get_by_name(CONFIG_SCHED_DEFAULT); + BUG_ON(!scheduler); + printk("Using '%s' (%s)\n", scheduler->name, scheduler->opt_name); } + ops = *scheduler; if ( cpu_schedule_up(0) ) BUG(); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 0164db996b8b..4442a1940c25 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -764,6 +764,17 @@ void sched_destroy_domain(struct domain *d); long sched_adjust(struct domain *, struct xen_domctl_scheduler_op *); long sched_adjust_global(struct xen_sysctl_scheduler_op *); int sched_id(void); + +/* + * sched_get_id_by_name - retrieves a scheduler id given a scheduler name + * @sched_name: scheduler name as a string + * + * returns: + * positive value being the scheduler id, on success + * negative value if the scheduler name is not found. + */ +int sched_get_id_by_name(const char *sched_name); + void vcpu_wake(struct vcpu *v); long vcpu_yield(void); void vcpu_sleep_nosync(struct vcpu *v); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322974.544487 (Exim 4.92) (envelope-from ) id 1nmwdJ-0007mU-04; Fri, 06 May 2022 12:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322974.544487; Fri, 06 May 2022 12:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdI-0007mL-RB; Fri, 06 May 2022 12:00:28 +0000 Received: by outflank-mailman (input) for mailman id 322974; Fri, 06 May 2022 12:00:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdH-0007iY-Sc for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1d168bd3-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:25 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1DDB14BF; Fri, 6 May 2022 05:00:24 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C1E603F7F5; Fri, 6 May 2022 05:00:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d168bd3-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v8 1/7] tools/cpupools: Give a name to unnamed cpupools Date: Fri, 6 May 2022 13:00:06 +0100 Message-Id: <20220506120012.32326-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> With the introduction of boot time cpupools, Xen can create many different cpupools at boot time other than cpupool with id 0. Since these newly created cpupools can't have an entry in Xenstore, create the entry using xen-init-dom0 helper with the usual convention: Pool-. Given the change, remove the check for poolid == 0 from libxl_cpupoolid_to_name(...). Signed-off-by: Luca Fancellu Reviewed-by: Anthony PERARD --- Changes in v8: - no changes Changes in v7: - Add R-by from Anthony Changes in v6: - Reworked loop to have only one error path (Anthony) Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - no changes, add R-by Changes in v2: - Remove unused variable, moved xc_cpupool_infofree ahead to simplify the code, use asprintf (Juergen) --- tools/helpers/xen-init-dom0.c | 37 +++++++++++++++++++++++++++++++++- tools/libs/light/libxl_utils.c | 3 +-- 2 files changed, 37 insertions(+), 3 deletions(-) diff --git a/tools/helpers/xen-init-dom0.c b/tools/helpers/xen-init-dom0.c index c99224a4b607..37eff8868f25 100644 --- a/tools/helpers/xen-init-dom0.c +++ b/tools/helpers/xen-init-dom0.c @@ -43,7 +43,10 @@ int main(int argc, char **argv) int rc; struct xs_handle *xsh = NULL; xc_interface *xch = NULL; - char *domname_string = NULL, *domid_string = NULL; + char *domname_string = NULL, *domid_string = NULL, + *pool_path = NULL, *pool_name = NULL; + xc_cpupoolinfo_t *xcinfo; + unsigned int pool_id = 0; libxl_uuid uuid; /* Accept 0 or 1 argument */ @@ -114,9 +117,41 @@ int main(int argc, char **argv) goto out; } + /* Create an entry in xenstore for each cpupool on the system */ + do { + xcinfo = xc_cpupool_getinfo(xch, pool_id); + if (xcinfo != NULL) { + if (xcinfo->cpupool_id != pool_id) + pool_id = xcinfo->cpupool_id; + xc_cpupool_infofree(xch, xcinfo); + if (asprintf(&pool_path, "/local/pool/%d/name", pool_id) <= 0) { + fprintf(stderr, "cannot allocate memory for pool path\n"); + rc = 1; + goto out; + } + if (asprintf(&pool_name, "Pool-%d", pool_id) <= 0) { + fprintf(stderr, "cannot allocate memory for pool name\n"); + rc = 1; + goto out; + } + pool_id++; + if (!xs_write(xsh, XBT_NULL, pool_path, pool_name, + strlen(pool_name))) { + fprintf(stderr, "cannot set pool name\n"); + rc = 1; + goto out; + } + free(pool_name); + free(pool_path); + pool_path = pool_name = NULL; + } + } while(xcinfo != NULL); + printf("Done setting up Dom0\n"); out: + free(pool_path); + free(pool_name); free(domid_string); free(domname_string); xs_close(xsh); diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c index 1d8a7f64ef4a..e5e6b2da9660 100644 --- a/tools/libs/light/libxl_utils.c +++ b/tools/libs/light/libxl_utils.c @@ -146,8 +146,7 @@ char *libxl_cpupoolid_to_name(libxl_ctx *ctx, uint32_t poolid) snprintf(path, sizeof(path), "/local/pool/%d/name", poolid); s = xs_read(ctx->xsh, XBT_NULL, path, &len); - if (!s && (poolid == 0)) - return strdup("Pool-0"); + return s; } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322980.544557 (Exim 4.92) (envelope-from ) id 1nmwdS-0001HM-3h; Fri, 06 May 2022 12:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322980.544557; Fri, 06 May 2022 12:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdR-0001H9-VH; Fri, 06 May 2022 12:00:37 +0000 Received: by outflank-mailman (input) for mailman id 322980; Fri, 06 May 2022 12:00:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdQ-0007iY-3k for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 22def1e5-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F91D153B; Fri, 6 May 2022 05:00:34 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC9473F7F5; Fri, 6 May 2022 05:00:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22def1e5-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Juergen Gross , Dario Faggioli , George Dunlap , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v8 7/7] xen/cpupool: Allow cpupool0 to use different scheduler Date: Fri, 6 May 2022 13:00:12 +0100 Message-Id: <20220506120012.32326-8-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Currently cpupool0 can use only the default scheduler, and cpupool_create has an hardcoded behavior when creating the pool 0 that doesn't allocate new memory for the scheduler, but uses the default scheduler structure in memory. With this commit it is possible to allocate a different scheduler for the cpupool0 when using the boot time cpupool. To achieve this the hardcoded behavior in cpupool_create is removed and the cpupool0 creation is moved. When compiling without boot time cpupools enabled, the current behavior is maintained (except that cpupool0 scheduler memory will be allocated). Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - no changes Changes in v7: - no changes Changes in v6: - Add R-by Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - fix typo in commit message (Juergen) - rebase changes Changes in v2: - new patch --- xen/common/sched/boot-cpupool.c | 5 ++++- xen/common/sched/cpupool.c | 8 +------- xen/include/xen/sched.h | 5 ++++- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c index 240bae4cebb8..5955e6f9a98b 100644 --- a/xen/common/sched/boot-cpupool.c +++ b/xen/common/sched/boot-cpupool.c @@ -205,8 +205,11 @@ void __init btcpupools_allocate_pools(void) if ( add_extra_cpupool ) next_pool_id++; + /* Keep track of cpupool id 0 with the global cpupool0 */ + cpupool0 = cpupool_create_pool(0, pool_sched_map[0]); + /* Create cpupools with selected schedulers */ - for ( i = 0; i < next_pool_id; i++ ) + for ( i = 1; i < next_pool_id; i++ ) cpupool_create_pool(i, pool_sched_map[i]); } diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 0a93bcc631bf..f6e3d97e5288 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -312,10 +312,7 @@ static struct cpupool *cpupool_create(unsigned int poolid, c->cpupool_id = q->cpupool_id + 1; } - if ( poolid == 0 ) - c->sched = scheduler_get_default(); - else - c->sched = scheduler_alloc(sched_id); + c->sched = scheduler_alloc(sched_id); if ( IS_ERR(c->sched) ) { ret = PTR_ERR(c->sched); @@ -1248,9 +1245,6 @@ static int __init cf_check cpupool_init(void) cpupool_hypfs_init(); - cpupool0 = cpupool_create(0, 0); - BUG_ON(IS_ERR(cpupool0)); - cpupool_put(cpupool0); register_cpu_notifier(&cpu_nfb); btcpupools_dtb_parse(); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 32d2a6294b6d..6040fa3b3830 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -1191,7 +1191,10 @@ void btcpupools_dtb_parse(void); int btcpupools_get_domain_pool_id(const struct dt_device_node *node); #else /* !CONFIG_BOOT_TIME_CPUPOOLS */ -static inline void btcpupools_allocate_pools(void) {} +static inline void btcpupools_allocate_pools(void) +{ + cpupool0 = cpupool_create_pool(0, -1); +} static inline void btcpupools_dtb_parse(void) {} static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu) { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322975.544494 (Exim 4.92) (envelope-from ) id 1nmwdJ-0007t3-9Y; Fri, 06 May 2022 12:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322975.544494; Fri, 06 May 2022 12:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdJ-0007qP-2h; Fri, 06 May 2022 12:00:29 +0000 Received: by outflank-mailman (input) for mailman id 322975; Fri, 06 May 2022 12:00:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdI-0007iY-Dc for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1e0e4039-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5DFF6153B; Fri, 6 May 2022 05:00:26 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DBB363F7F5; Fri, 6 May 2022 05:00:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e0e4039-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Juergen Gross , Dario Faggioli , George Dunlap , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v8 2/7] xen/sched: create public function for cpupools creation Date: Fri, 6 May 2022 13:00:07 +0100 Message-Id: <20220506120012.32326-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Create new public function to create cpupools, can take as parameter the scheduler id or a negative value that means the default Xen scheduler will be used. Signed-off-by: Luca Fancellu Reviewed-by: Juergen Gross --- Changes in v8: - no changes Changes in v7: - no changes Changes in v6: - add R-by Changes in v5: - no changes Changes in v4: - no changes Changes in v3: - Fixed comment (Andrew) Changes in v2: - cpupool_create_pool doesn't check anymore for pool id uniqueness before calling cpupool_create. Modified commit message accordingly --- xen/common/sched/cpupool.c | 15 +++++++++++++++ xen/include/xen/sched.h | 16 ++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index a6da4970506a..89a891af7076 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -1219,6 +1219,21 @@ static void cpupool_hypfs_init(void) #endif /* CONFIG_HYPFS */ +struct cpupool *__init cpupool_create_pool(unsigned int pool_id, int sched_id) +{ + struct cpupool *pool; + + if ( sched_id < 0 ) + sched_id = scheduler_get_default()->sched_id; + + pool = cpupool_create(pool_id, sched_id); + + BUG_ON(IS_ERR(pool)); + cpupool_put(pool); + + return pool; +} + static int __init cf_check cpupool_init(void) { unsigned int cpu; diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index ed8539f6d297..0164db996b8b 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -1153,6 +1153,22 @@ int cpupool_move_domain(struct domain *d, struct cpupool *c); int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op); unsigned int cpupool_get_id(const struct domain *d); const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool); + +/* + * cpupool_create_pool - Creates a cpupool + * @pool_id: id of the pool to be created + * @sched_id: id of the scheduler to be used for the pool + * + * Creates a cpupool with pool_id id. + * The sched_id parameter identifies the scheduler to be used, if it is + * negative, the default scheduler of Xen will be used. + * + * returns: + * pointer to the struct cpupool just created, or Xen will panic in case of + * error + */ +struct cpupool *cpupool_create_pool(unsigned int pool_id, int sched_id); + extern void cf_check dump_runq(unsigned char key); void arch_do_physinfo(struct xen_sysctl_physinfo *pi); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322973.544482 (Exim 4.92) (envelope-from ) id 1nmwdI-0007iw-N4; Fri, 06 May 2022 12:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322973.544482; Fri, 06 May 2022 12:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdI-0007io-I0; Fri, 06 May 2022 12:00:28 +0000 Received: by outflank-mailman (input) for mailman id 322973; Fri, 06 May 2022 12:00:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdG-0007iX-Il for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:26 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1c7c33dd-cd34-11ec-a406-831a346695d4; Fri, 06 May 2022 14:00:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A916113E; Fri, 6 May 2022 05:00:23 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1FC63F7F5; Fri, 6 May 2022 05:00:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c7c33dd-cd34-11ec-a406-831a346695d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , Anthony PERARD , Juergen Gross , Dario Faggioli , George Dunlap , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: [PATCH v8 0/7] Boot time cpupools Date: Fri, 6 May 2022 13:00:05 +0100 Message-Id: <20220506120012.32326-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 *** Resending the serie adding the maintainers *** *** Patches #4 and #6 needs a review from the maintainer of that area *** This serie introduces a feature for Xen to create cpu pools at boot time, the feature is enabled using a configurable that is disabled by default. The boot time cpupool feature relies on the device tree to describe the cpu pools. Another feature is introduced by the serie, the possibility to assign a dom0less guest to a cpupool at boot time. Here follows an example, Xen is built with CONFIG_BOOT_TIME_CPUPOOLS=y. >From the DT: [...] a72_0: cpu@0 { compatible = "arm,cortex-a72"; reg = <0x0 0x0>; device_type = "cpu"; [...] }; a72_1: cpu@1 { compatible = "arm,cortex-a72"; reg = <0x0 0x1>; device_type = "cpu"; [...] }; a53_0: cpu@100 { compatible = "arm,cortex-a53"; reg = <0x0 0x100>; device_type = "cpu"; [...] }; a53_1: cpu@101 { compatible = "arm,cortex-a53"; reg = <0x0 0x101>; device_type = "cpu"; [...] }; a53_2: cpu@102 { compatible = "arm,cortex-a53"; reg = <0x0 0x102>; device_type = "cpu"; [...] }; a53_3: cpu@103 { compatible = "arm,cortex-a53"; reg = <0x0 0x103>; device_type = "cpu"; [...] }; chosen { #size-cells = <0x1>; #address-cells = <0x1>; xen,dom0-bootargs = "..."; xen,xen-bootargs = "..."; cpupool0 { compatible = "xen,cpupool"; cpupool-cpus = <&a72_0 &a72_1>; cpupool-sched = "credit2"; }; cp1: cpupool1 { compatible = "xen,cpupool"; cpupool-cpus = <&a53_0 &a53_1 &a53_2 &a53_3>; cpupool-sched = "null"; }; module@0 { reg = <0x80080000 0x1300000>; compatible = "multiboot,module"; }; domU1 { #size-cells = <0x1>; #address-cells = <0x1>; compatible = "xen,domain"; cpus = <1>; memory = <0 0xC0000>; vpl011; domain-cpupool = <&cp1>; module@92000000 { compatible = "multiboot,kernel", "multiboot,module"; reg = <0x92000000 0x1ffffff>; bootargs = "..."; }; }; }; [...] The example DT is instructing Xen to have two cpu pools, one having two phisical cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the null scheduler and from the /chosen node we can see that a dom0less guest will be started on that cpu pool. In this particular case Xen must boot with different type of cpus, so the boot argument hmp_unsafe must be enabled. Luca Fancellu (7): tools/cpupools: Give a name to unnamed cpupools xen/sched: create public function for cpupools creation xen/sched: retrieve scheduler id by name xen/cpupool: Create different cpupools at boot time xen/cpupool: Don't allow removing cpu0 from cpupool0 arm/dom0less: assign dom0less guests to cpupools xen/cpupool: Allow cpupool0 to use different scheduler MAINTAINERS | 2 +- docs/misc/arm/device-tree/booting.txt | 5 + docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++ tools/helpers/xen-init-dom0.c | 37 +++- tools/libs/light/libxl_utils.c | 3 +- xen/arch/arm/domain_build.c | 19 +- xen/arch/arm/include/asm/smp.h | 3 + xen/common/domain.c | 2 +- xen/common/sched/Kconfig | 7 + xen/common/sched/Makefile | 1 + xen/common/sched/boot-cpupool.c | 234 +++++++++++++++++++++++++ xen/common/sched/core.c | 40 +++-- xen/common/sched/cpupool.c | 43 ++++- xen/include/public/domctl.h | 5 +- xen/include/xen/sched.h | 53 ++++++ 15 files changed, 563 insertions(+), 31 deletions(-) create mode 100644 docs/misc/arm/device-tree/cpupools.txt create mode 100644 xen/common/sched/boot-cpupool.c -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:00:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322977.544525 (Exim 4.92) (envelope-from ) id 1nmwdN-0000La-PE; Fri, 06 May 2022 12:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322977.544525; Fri, 06 May 2022 12:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdN-0000LM-Lr; Fri, 06 May 2022 12:00:33 +0000 Received: by outflank-mailman (input) for mailman id 322977; Fri, 06 May 2022 12:00:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwdL-0007iY-Sw for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:00:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 200c9d7c-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:00:30 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C77F814BF; Fri, 6 May 2022 05:00:29 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A1193F7F5; Fri, 6 May 2022 05:00:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 200c9d7c-cd34-11ec-8fc4-03012f2f19d4 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Dario Faggioli , Juergen Gross Subject: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time Date: Fri, 6 May 2022 13:00:09 +0100 Message-Id: <20220506120012.32326-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> Introduce a way to create different cpupools at boot time, this is particularly useful on ARM big.LITTLE system where there might be the need to have different cpupools for each type of core, but also systems using NUMA can have different cpu pools for each node. The feature on arm relies on a specification of the cpupools from the device tree to build pools and assign cpus to them. ACPI is not supported for this feature. With this patch, cpupool0 can now have less cpus than the number of online ones, so update the default case for opt_dom0_max_vcpus. Documentation is created to explain the feature. Signed-off-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v8: - moved Kconfig parameter from xen/common/Kconfig to xen/common/sched/Kconfig (Jan) - Add R-by (Stefano) Changes in v7: - rename xen/common/boot_cpupools.c to xen/common/sched/boot-cpupool.c (Jan) - reverted xen/common/Makefile, add entry in xen/common/sched/Makefile - changed line in MAINTAINERS under CPU POOLS section (Dario) - Fix documentation, update opt_dom0_max_vcpus to the number of cpu in cpupool0 (Julien) Changes in v6: - Changed docs, return if booted with ACPI in btcpupools_dtb_parse, panic if /chosen does not exists. Changed commit message (Julien) - Add Juergen R-by for the xen/common/sched part that didn't change Changes in v5: - Fixed wrong variable name, swapped schedulers, add scheduler info in the printk (Stefano) - introduce assert in cpupool_init and btcpupools_get_cpupool_id to harden the code Changes in v4: - modify Makefile to put in *.init.o, fixed stubs and macro (Jan) - fixed docs, fix brakets (Stefano) - keep cpu0 in Pool-0 (Julien) - moved printk from btcpupools_allocate_pools to btcpupools_get_cpupool_id - Add to docs constraint about cpu0 and Pool-0 Changes in v3: - Add newline to cpupools.txt and removed "default n" from Kconfig (Jan) - Fixed comment, moved defines, used global cpu_online_map, use HAS_DEVICE_TREE instead of ARM and place arch specific code in header (Juergen) - Fix brakets, x86 code only panic, get rid of scheduler dt node, don't save pool pointer and look for it from the pool list (Stefano) - Changed data structures to allow modification to the code. Changes in v2: - Move feature to common code (Juergen) - Try to decouple dtb parse and cpupool creation to allow more way to specify cpupools (for example command line) - Created standalone dt node for the scheduler so it can be used in future work to set scheduler specific parameters - Use only auto generated ids for cpupools --- MAINTAINERS | 2 +- docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++ xen/arch/arm/domain_build.c | 5 +- xen/arch/arm/include/asm/smp.h | 3 + xen/common/sched/Kconfig | 7 + xen/common/sched/Makefile | 1 + xen/common/sched/boot-cpupool.c | 207 +++++++++++++++++++++++++ xen/common/sched/cpupool.c | 12 +- xen/include/xen/sched.h | 14 ++ 9 files changed, 388 insertions(+), 3 deletions(-) create mode 100644 docs/misc/arm/device-tree/cpupools.txt create mode 100644 xen/common/sched/boot-cpupool.c diff --git a/MAINTAINERS b/MAINTAINERS index ba0d1c0c1bfa..a417c3586051 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -279,7 +279,7 @@ CPU POOLS M: Juergen Gross M: Dario Faggioli S: Supported -F: xen/common/sched/cpupool.c +F: xen/common/sched/*cpupool.c DEVICE TREE M: Stefano Stabellini diff --git a/docs/misc/arm/device-tree/cpupools.txt b/docs/misc/arm/device-tree/cpupools.txt new file mode 100644 index 000000000000..1f640d680317 --- /dev/null +++ b/docs/misc/arm/device-tree/cpupools.txt @@ -0,0 +1,140 @@ +Boot time cpupools +================== + +When BOOT_TIME_CPUPOOLS is enabled in the Xen configuration, it is possible to +create cpupools during boot phase by specifying them in the device tree. +ACPI is not supported for this feature. + +Cpupools specification nodes shall be direct childs of /chosen node. +Each cpupool node contains the following properties: + +- compatible (mandatory) + + Must always include the compatiblity string: "xen,cpupool". + +- cpupool-cpus (mandatory) + + Must be a list of device tree phandle to nodes describing cpus (e.g. having + device_type = "cpu"), it can't be empty. + +- cpupool-sched (optional) + + Must be a string having the name of a Xen scheduler. Check the sched=<...> + boot argument for allowed values [1]. When this property is omitted, the Xen + default scheduler will be used. + + +Constraints +=========== + +If no cpupools are specified, all cpus will be assigned to one cpupool +implicitly created (Pool-0). + +If cpupools node are specified, but not every cpu brought up by Xen is assigned, +all the not assigned cpu will be assigned to an additional cpupool. + +If a cpu is assigned to a cpupool, but it's not brought up correctly, Xen will +stop. + +The boot cpu must be assigned to Pool-0, so the cpupool containing that core +will become Pool-0 automatically. + + +Examples +======== + +A system having two types of core, the following device tree specification will +instruct Xen to have two cpupools: + +- The cpupool described by node cpupool_a will have 4 cpus assigned. +- The cpupool described by node cpupool_b will have 2 cpus assigned. + +The following example can work only if hmp-unsafe=1 is passed to Xen boot +arguments, otherwise not all cores will be brought up by Xen and the cpupool +creation process will stop Xen. + + +a72_1: cpu@0 { + compatible = "arm,cortex-a72"; + reg = <0x0 0x0>; + device_type = "cpu"; + [...] +}; + +a72_2: cpu@1 { + compatible = "arm,cortex-a72"; + reg = <0x0 0x1>; + device_type = "cpu"; + [...] +}; + +a53_1: cpu@100 { + compatible = "arm,cortex-a53"; + reg = <0x0 0x100>; + device_type = "cpu"; + [...] +}; + +a53_2: cpu@101 { + compatible = "arm,cortex-a53"; + reg = <0x0 0x101>; + device_type = "cpu"; + [...] +}; + +a53_3: cpu@102 { + compatible = "arm,cortex-a53"; + reg = <0x0 0x102>; + device_type = "cpu"; + [...] +}; + +a53_4: cpu@103 { + compatible = "arm,cortex-a53"; + reg = <0x0 0x103>; + device_type = "cpu"; + [...] +}; + +chosen { + + cpupool_a { + compatible = "xen,cpupool"; + cpupool-cpus = <&a53_1 &a53_2 &a53_3 &a53_4>; + }; + cpupool_b { + compatible = "xen,cpupool"; + cpupool-cpus = <&a72_1 &a72_2>; + cpupool-sched = "credit2"; + }; + + [...] + +}; + + +A system having the cpupools specification below will instruct Xen to have three +cpupools: + +- The cpupool described by node cpupool_a will have 2 cpus assigned. +- The cpupool described by node cpupool_b will have 2 cpus assigned. +- An additional cpupool will be created, having 2 cpus assigned (created by Xen + with all the unassigned cpus a53_3 and a53_4). + +chosen { + + cpupool_a { + compatible = "xen,cpupool"; + cpupool-cpus = <&a53_1 &a53_2>; + }; + cpupool_b { + compatible = "xen,cpupool"; + cpupool-cpus = <&a72_1 &a72_2>; + cpupool-sched = "null"; + }; + + [...] + +}; + +[1] docs/misc/xen-command-line.pandoc diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1472ca4972b0..5df5c8ffb8ba 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -73,7 +73,10 @@ custom_param("dom0_mem", parse_dom0_mem); unsigned int __init dom0_max_vcpus(void) { if ( opt_dom0_max_vcpus == 0 ) - opt_dom0_max_vcpus = num_online_cpus(); + { + ASSERT(cpupool0); + opt_dom0_max_vcpus = cpumask_weight(cpupool_valid_cpus(cpupool0)); + } if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS ) opt_dom0_max_vcpus = MAX_VIRT_CPUS; diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index af5a2fe65266..83c0cd69767b 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -34,6 +34,9 @@ extern void init_secondary(void); extern void smp_init_cpus(void); extern void smp_clear_cpu_maps (void); extern int smp_get_max_cpus (void); + +#define cpu_physical_id(cpu) cpu_logical_map(cpu) + #endif /* diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig index 3d9f9214b8cc..b2ef0c99a3f8 100644 --- a/xen/common/sched/Kconfig +++ b/xen/common/sched/Kconfig @@ -64,3 +64,10 @@ config SCHED_DEFAULT default "credit2" endmenu + +config BOOT_TIME_CPUPOOLS + bool "Create cpupools at boot time" + depends on HAS_DEVICE_TREE + help + Creates cpupools during boot time and assigns cpus to them. Cpupools + options can be specified in the device tree. diff --git a/xen/common/sched/Makefile b/xen/common/sched/Makefile index 3537f2a68d69..697bd54bfe93 100644 --- a/xen/common/sched/Makefile +++ b/xen/common/sched/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_BOOT_TIME_CPUPOOLS) += boot-cpupool.init.o obj-y += cpupool.o obj-$(CONFIG_SCHED_ARINC653) += arinc653.o obj-$(CONFIG_SCHED_CREDIT) += credit.o diff --git a/xen/common/sched/boot-cpupool.c b/xen/common/sched/boot-cpupool.c new file mode 100644 index 000000000000..9429a5025fc4 --- /dev/null +++ b/xen/common/sched/boot-cpupool.c @@ -0,0 +1,207 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/common/boot_cpupools.c + * + * Code to create cpupools at boot time. + * + * Copyright (C) 2022 Arm Ltd. + */ + +#include +#include + +/* + * pool_cpu_map: Index is logical cpu number, content is cpupool id, (-1) for + * unassigned. + * pool_sched_map: Index is cpupool id, content is scheduler id, (-1) for + * unassigned. + */ +static int __initdata pool_cpu_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 }; +static int __initdata pool_sched_map[NR_CPUS] = { [0 ... NR_CPUS-1] = -1 }; +static unsigned int __initdata next_pool_id; + +#define BTCPUPOOLS_DT_NODE_NO_REG (-1) +#define BTCPUPOOLS_DT_NODE_NO_LOG_CPU (-2) + +static int __init get_logical_cpu_from_hw_id(unsigned int hwid) +{ + unsigned int i; + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_physical_id(i) == hwid ) + return i; + } + + return -1; +} + +static int __init +get_logical_cpu_from_cpu_node(const struct dt_device_node *cpu_node) +{ + int cpu_num; + const __be32 *prop; + unsigned int cpu_reg; + + prop = dt_get_property(cpu_node, "reg", NULL); + if ( !prop ) + return BTCPUPOOLS_DT_NODE_NO_REG; + + cpu_reg = dt_read_number(prop, dt_n_addr_cells(cpu_node)); + + cpu_num = get_logical_cpu_from_hw_id(cpu_reg); + if ( cpu_num < 0 ) + return BTCPUPOOLS_DT_NODE_NO_LOG_CPU; + + return cpu_num; +} + +static int __init check_and_get_sched_id(const char* scheduler_name) +{ + int sched_id = sched_get_id_by_name(scheduler_name); + + if ( sched_id < 0 ) + panic("Scheduler %s does not exists!\n", scheduler_name); + + return sched_id; +} + +void __init btcpupools_dtb_parse(void) +{ + const struct dt_device_node *chosen, *node; + + if ( !acpi_disabled ) + return; + + chosen = dt_find_node_by_path("/chosen"); + if ( !chosen ) + panic("/chosen missing. Boot time cpupools can't be parsed from DT.\n"); + + dt_for_each_child_node(chosen, node) + { + const struct dt_device_node *phandle_node; + int sched_id = -1; + const char* scheduler_name; + unsigned int i = 0; + + if ( !dt_device_is_compatible(node, "xen,cpupool") ) + continue; + + if ( !dt_property_read_string(node, "cpupool-sched", &scheduler_name) ) + sched_id = check_and_get_sched_id(scheduler_name); + + phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++); + if ( !phandle_node ) + panic("Missing or empty cpupool-cpus property!\n"); + + while ( phandle_node ) + { + int cpu_num; + + cpu_num = get_logical_cpu_from_cpu_node(phandle_node); + + if ( cpu_num < 0 ) + panic("Error retrieving logical cpu from node %s (%d)\n", + dt_node_name(node), cpu_num); + + if ( pool_cpu_map[cpu_num] != -1 ) + panic("Logical cpu %d already added to a cpupool!\n", cpu_num); + + pool_cpu_map[cpu_num] = next_pool_id; + + phandle_node = dt_parse_phandle(node, "cpupool-cpus", i++); + } + + /* Save scheduler choice for this cpupool id */ + pool_sched_map[next_pool_id] = sched_id; + + /* Let Xen generate pool ids */ + next_pool_id++; + } +} + +void __init btcpupools_allocate_pools(void) +{ + unsigned int i; + bool add_extra_cpupool = false; + int swap_id = -1; + + /* + * If there are no cpupools, the value of next_pool_id is zero, so the code + * below will assign every cpu to cpupool0 as the default behavior. + * When there are cpupools, the code below is assigning all the not + * assigned cpu to a new pool (next_pool_id value is the last id + 1). + * In the same loop we check if there is any assigned cpu that is not + * online. + */ + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpumask_test_cpu(i, &cpu_online_map) ) + { + /* Unassigned cpu gets next_pool_id pool id value */ + if ( pool_cpu_map[i] < 0 ) + { + pool_cpu_map[i] = next_pool_id; + add_extra_cpupool = true; + } + + /* + * Cpu0 must be in cpupool0, otherwise some operations like moving + * cpus between cpupools, cpu hotplug, destroying cpupools, shutdown + * of the host, might not work in a sane way. + */ + if ( !i && (pool_cpu_map[0] != 0) ) + swap_id = pool_cpu_map[0]; + + if ( swap_id != -1 ) + { + if ( pool_cpu_map[i] == swap_id ) + pool_cpu_map[i] = 0; + else if ( pool_cpu_map[i] == 0 ) + pool_cpu_map[i] = swap_id; + } + } + else + { + if ( pool_cpu_map[i] >= 0 ) + panic("Pool-%d contains cpu%u that is not online!\n", + pool_cpu_map[i], i); + } + } + + /* A swap happened, swap schedulers between cpupool id 0 and the other */ + if ( swap_id != -1 ) + { + int swap_sched = pool_sched_map[swap_id]; + + pool_sched_map[swap_id] = pool_sched_map[0]; + pool_sched_map[0] = swap_sched; + } + + if ( add_extra_cpupool ) + next_pool_id++; + + /* Create cpupools with selected schedulers */ + for ( i = 0; i < next_pool_id; i++ ) + cpupool_create_pool(i, pool_sched_map[i]); +} + +unsigned int __init btcpupools_get_cpupool_id(unsigned int cpu) +{ + ASSERT((cpu < NR_CPUS) && (pool_cpu_map[cpu] >= 0)); + + printk(XENLOG_INFO "Logical CPU %u in Pool-%d (Scheduler id: %d).\n", + cpu, pool_cpu_map[cpu], pool_sched_map[pool_cpu_map[cpu]]); + + return pool_cpu_map[cpu]; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index 89a891af7076..86a175f99cd5 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -1247,12 +1247,22 @@ static int __init cf_check cpupool_init(void) cpupool_put(cpupool0); register_cpu_notifier(&cpu_nfb); + btcpupools_dtb_parse(); + + btcpupools_allocate_pools(); + spin_lock(&cpupool_lock); cpumask_copy(&cpupool_free_cpus, &cpu_online_map); for_each_cpu ( cpu, &cpupool_free_cpus ) - cpupool_assign_cpu_locked(cpupool0, cpu); + { + unsigned int pool_id = btcpupools_get_cpupool_id(cpu); + struct cpupool *pool = cpupool_find_by_id(pool_id); + + ASSERT(pool); + cpupool_assign_cpu_locked(pool, cpu); + } spin_unlock(&cpupool_lock); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 4442a1940c25..74b3aae10b94 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -1184,6 +1184,20 @@ extern void cf_check dump_runq(unsigned char key); void arch_do_physinfo(struct xen_sysctl_physinfo *pi); +#ifdef CONFIG_BOOT_TIME_CPUPOOLS +void btcpupools_allocate_pools(void); +unsigned int btcpupools_get_cpupool_id(unsigned int cpu); +void btcpupools_dtb_parse(void); + +#else /* !CONFIG_BOOT_TIME_CPUPOOLS */ +static inline void btcpupools_allocate_pools(void) {} +static inline void btcpupools_dtb_parse(void) {} +static inline unsigned int btcpupools_get_cpupool_id(unsigned int cpu) +{ + return 0; +} +#endif + #endif /* __SCHED_H__ */ /* -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Fri May 06 12:03:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:03:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.322998.544569 (Exim 4.92) (envelope-from ) id 1nmwgQ-0003zw-Ps; Fri, 06 May 2022 12:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 322998.544569; Fri, 06 May 2022 12:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwgQ-0003zp-L6; Fri, 06 May 2022 12:03:42 +0000 Received: by outflank-mailman (input) for mailman id 322998; Fri, 06 May 2022 12:03:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwgP-0003zZ-1z for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:03:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90db9586-cd34-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:03:39 +0200 (CEST) Received: from AM6P191CA0028.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::41) by DB9PR08MB7161.eurprd08.prod.outlook.com (2603:10a6:10:2ca::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 12:03:37 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::4f) by AM6P191CA0028.outlook.office365.com (2603:10a6:209:8b::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Fri, 6 May 2022 12:03:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 12:03:36 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Fri, 06 May 2022 12:03:36 +0000 Received: from 16eaaaab0055.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1C7135CC-DC7B-4674-82B0-F9A03719975D.1; Fri, 06 May 2022 12:03:25 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 16eaaaab0055.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 12:03:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB5981.eurprd08.prod.outlook.com (2603:10a6:102:e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 6 May 2022 12:03:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c%7]) with mapi id 15.20.5144.027; Fri, 6 May 2022 12:03:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90db9586-cd34-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ntH+jH9s2SIop0JhZ2+C/ylcvr9r3Uwvsw1gPRmboCmohoCQF+R0XvEGjY2WcQ9TR8ulmxBhrneo0rdKyReuRo6u0MCu4teDc9WqECdkG8sh8Donwj8RDNouv+FydZ4mFReisa60kHSV5o5Ty+eXeF8cpCvRvKrQSvvr9L+/yb2m0sHrSOnGlCdHfpVo7lmUXvEIfaAVKv4zSWfbP3RBsL0XrYlouNN4wFoqIodj4gNdwvClEJi8iO4tShRmIhAZtogb4/H2lkxiM3uok3B5dkeQ5XZUT1oqOdtIxu9rUIGVsnsnUrm/PNrw41vinw82jFGi7DojvjCmeJG8SJq8fg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ngeQtgrxCaWSrBPVmd67JBnD1aLnowqKALKoCu1V0g=; b=I5AajyWBttD+aoVrncfo1sVp9ByUGjMCdS39Qu62CgCK0YCdshNlFMF6zS3Nl5AegDG7gnJ5VPNqkOu7+elE2jXmcI7H8FW4pOPOLLPek2L6cCdNJQCE6cvSZoLn44JSPgOW1iH0PVlLWWAYsT62mpbY39dPexc+lbn5FMC7Gths7L8q8dH3Ni90lzXSX46FKxtDDVIRaSwcWLSbHQYCl6a1Zn99LMWJYHy0dFI9mt1rzUnLbzECWi9sGC79fDmXPWiNkVnCDMrEXzUV6pHedqUzEWdDwAGHa/uRs7Gt6L/N0JAKpqbY26bRE631LCajri8OEvNcniupY6qkf+o6Zg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ngeQtgrxCaWSrBPVmd67JBnD1aLnowqKALKoCu1V0g=; b=GOj52XuPV1OS4xn5IBQtrfEIjBRukzzeHRIhk3x2zPrTxJ+FcEijeheKPXUc9yudn13lbjnn3DxNIXnhu0M5lUkT5wHCatAwr4N5k8DOSiJa4ipGiX7A5u/LT2K5yNDWcMFiejIQSA/aEJxBp667CDglvR4yFv3g6WxxHIPh0Xk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cgWIcq+TXEqFkn7ATUpLEeekh+D06WeDm6/iWfMAsKL4czylh3xRYBG9lEuHXXfF6jtDgoGkFGMUtMbos2mjYP91Vt+EeveJp8jx7Pf3m+VqV1Y1cZIgosG+4JKEVNr8WQGtlhpEthK7sOC3l61C4rXAQkdVuHZftm7RQOKhhSFen2XzF5B0+Fc9y0CvnRIov4sGolSTKSY+6yJ3Q65mKR/gqFW1EeMke/FznNgYWpEAXvqpJN5m2dp3bAmlKNTeYmG2mF9R4Zd54ATyWv4cjlrq5F+RYVWl0lJjKta6P6SwCnkFYhNXYOPFfx923jo2xAbv5uyhH4WiDO5Lb/nOTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ngeQtgrxCaWSrBPVmd67JBnD1aLnowqKALKoCu1V0g=; b=NlWm5hRQY6Xbq+VzP48YMaDAwP/QfcxYizN8bQ4kwp1GV7G3ftxPzY0LWZmRK4ua0djL+ECuZidh/MXKm3QJSxbTJN7XxTUEXKEB9YixYfbEEzV9X7mdYUdU1Mm9POZY+7Kemzma2a8KvO/ic760LWOgmou+zv5adJ2BAVZquMVZUBzjHKaKGcY1i0nj3ZN6uqiQmJ7t256ycKu6JgGmXYluG99w3XfOj+oYRroVhTlpB8JQEV4sT0tRdB2MNbsStJa9UzEtfupKDPvk0Z7uvABkSeGxrEQ0H5jcz3+6STBgVpDLAK/SSFBBgGzpuSyzwcJkYhRrtRH1qBIY4PTmkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ngeQtgrxCaWSrBPVmd67JBnD1aLnowqKALKoCu1V0g=; b=GOj52XuPV1OS4xn5IBQtrfEIjBRukzzeHRIhk3x2zPrTxJ+FcEijeheKPXUc9yudn13lbjnn3DxNIXnhu0M5lUkT5wHCatAwr4N5k8DOSiJa4ipGiX7A5u/LT2K5yNDWcMFiejIQSA/aEJxBp667CDglvR4yFv3g6WxxHIPh0Xk= From: Henry Wang To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Wei Chen , Julien Grall , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Topic: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Index: AQHYYQ1+wSNISpljvkG6pMKyJcwNSq0Rpx4AgAAWlnA= Date: Fri, 6 May 2022 12:03:23 +0000 Message-ID: References: <20220506055201.999277-1-Henry.Wang@arm.com> <20220506055201.999277-3-Henry.Wang@arm.com> <6a44bc43-c392-2eac-d350-ec87cb2c3ab3@suse.com> In-Reply-To: <6a44bc43-c392-2eac-d350-ec87cb2c3ab3@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3E0E6FAB06ADAE4CB84E0CAAE5AFB91F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9c5174aa-5cfa-4f41-c55c-08da2f587359 x-ms-traffictypediagnostic: PA4PR08MB5981:EE_|VE1EUR03FT051:EE_|DB9PR08MB7161:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QIreALH1mh4V27Kia3GoiRxHduStCjvoUkmwSoh1/B1PVxa3626MsLGY2l/lDr1ZJcrCPFsBgkn+Ax3fBi5FRSc5PJvaPw//PAYDRvEXQMHSBf18jx9ffdlcaSwwrWsewPrq2Ph0Fc7OV2QomESuhgXBjxz6HYTwoQiqS3Ekvz0vxBP3vmlRbw1tYmLVMdqBSSI3K1gGBOPgS8yDlKlOeeVq8i1Z0L+s/48zAsai0YMcPnF+0wPTqsecH+5z5UnoIWmmstX1AePh8oRhQHLEDve6jOeoKJEsbhLrw40mXXqnkdXxjp2EuKbTzgX7k9ISOtIa8MiKMPRda3Ts+xyzUP4eHxbce0yIeTsQR3tjsrTotzrB1c+xejMnhKFY2F5BTUfwnzs+6OAkF1CjDtq2Pps7Gg9/EELlpy6SnZ1Mf26n51v0z9f5euoXfnRXPVDjZS6YL3T2QU+x7xaiklEL+/Nca/NVCHE+aaodseubPiyTXvIxIlfNY+BxqfpeqL6t9Ow5vRE5wfsOPH0BPE1ktomiVFWHMkUBHDHMYidB58qZvfI8Rp2haB8D/8xSnJjfi6edXfgWwNpheXpqQ+WbmoJOh4RQO5n0xBOOpjHDdMpCI2eKtEztYLSKObVEaxE27W67HHrVr30mXm2WaRrqJCUUnSoQGG9MkU5AXkSPkAI2A0PxR8dc/TaavlOlGqEqOvAqlttYyuyz9i2bFH78Eg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66446008)(64756008)(8676002)(9686003)(71200400001)(186003)(26005)(66946007)(4326008)(66556008)(5660300002)(6506007)(53546011)(8936002)(7696005)(52536014)(2906002)(86362001)(55016003)(508600001)(6916009)(76116006)(54906003)(316002)(38100700002)(38070700005)(33656002)(122000001)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5981 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 45e00738-b8c1-46c8-92de-08da2f586bd4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qgiYK+873Ew1ob+1eK8lrB+oidMlEGqv/mn794bzTz2+++Zdr7981eTF+cty6O+WzXzfKUWY92TdJvk0RmMz07GJRRJsBIJIMLYVJf6DWJZ9dZDJXxfs6ceSx3cRxycK5t9cxzUlbLfEFIfH5RUB5/6BunJrUERCcB8c5+HueG/93HDaED/N+3lcAtIpzFTkcpomQFPT0Dnwv4Azd92k6GZsTE8lBJnNdd0nUiArrbqaA5dcZoMgbq8RZIUOZJm6QrRC6o0kDyAA9GRP0wLuOMycgE4dFE5lux47+PhC87I4sVG2hyQl+P35GIfdUYTv7JKsOAxl3ASgUGhQSL3nnZ/yj6f9k10VUVRXc8/8++CJcl8anP3B/chv43O80IG3VCP+ZekTmLrY6l+ANFaKBL6blBlmqXYXOU8h5pPdGgCSudRzOMETQu9vFngEUhlz8YBYKBFQ26u8sSVoq1omVBbImUgHoSUUNU/g4AUIluxYAJTJJaPnegG3iDwyo4LqW0q4Vw8vuy4jO0F3dPHQNKxAvAMy72siPQW+6Xdim+g27UysgYcpHiN8k+OtLah6Zi1keq/7T4CrgKWC4ZPz2CP1o3kZhuPFiH/JwRfOMDvOEP8vk5UCEpG5ygJb9q/RH+qYnaRSRrJzeAc0XDu607yCZxULJ83WtKPml6rAw5XJYMybhJFsxpSVR3i3kFHg X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(54906003)(36860700001)(55016003)(70206006)(2906002)(316002)(70586007)(9686003)(47076005)(508600001)(336012)(356005)(8676002)(81166007)(7696005)(6862004)(8936002)(5660300002)(40460700003)(26005)(4326008)(52536014)(33656002)(53546011)(6506007)(83380400001)(82310400005)(86362001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:03:36.4299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5174aa-5cfa-4f41-c55c-08da2f587359 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7161 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogRnJpZGF5LCBNYXkgNiwgMjAyMiA2OjMz IFBNDQo+IFRvOiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IENjOiBTdGVmYW5v IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPjsNCj4gQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgQW5k cmV3IENvb3Blcg0KPiA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAg PGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47DQo+IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBXZWkg Q2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IEp1bGllbiBHcmFsbA0KPiA8amdyYWxsQGFtYXpvbi5j b20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRD SCB2MiAyLzJdIHhlbi9jb21tb246IFVzZSBlbmhhbmNlZA0KPiBBU1NFUlRfQUxMT0NfQ09OVEVY VCBpbiB4bWFsbG9jKCkNCj4gDQo+IE9uIDA2LjA1LjIwMjIgMDc6NTIsIEhlbnJ5IFdhbmcgd3Jv dGU6DQo+ID4gLS0tIGEveGVuL2NvbW1vbi94bWFsbG9jX3Rsc2YuYw0KPiA+ICsrKyBiL3hlbi9j b21tb24veG1hbGxvY190bHNmLmMNCj4gPiBAQCAtNTk0LDcgKzU5NCw3IEBAIHZvaWQgKl94bWFs bG9jKHVuc2lnbmVkIGxvbmcgc2l6ZSwgdW5zaWduZWQgbG9uZw0KPiBhbGlnbikNCj4gPiAgew0K PiA+ICAgICAgdm9pZCAqcCA9IE5VTEw7DQo+ID4NCj4gPiAtICAgIEFTU0VSVCghaW5faXJxKCkp Ow0KPiA+ICsgICAgQVNTRVJUX0FMTE9DX0NPTlRFWFQoKTsNCj4gDQo+IEZvciBvbmUgLSB3aGF0 IGFib3V0IHhmcmVlKCk/DQoNCk9oIHlvdSBhcmUgZGVmaW5pdGVseSBjb3JyZWN0LCB0aGFua3Mg Zm9yIHBvaW50aW5nIHRoaXMgb3V0LiBJIHdpbGwNCmRlZmluaXRlbHkgY2hhbmdlIHRoZSBhc3Nl cnRpb24gaW4geGZyZWUoKSBhcyB3ZWxsIGluIHYzLg0KDQo+IA0KPiBBbmQgdGhlbiBkaWQgeW91 IGNvbnNpZGVyIHRha2luZyB0aGUgb3Bwb3J0dW5pdHkgYW5kIG1vdmluZyBib3RoIHRvDQo+IHRo ZSByZXNwZWN0aXZlIHBvb2wgYWxsb2MgZnVuY3Rpb25zLCB0aHVzIGdpdmluZyBldmVuIGJldHRl ciBjb3ZlcmFnZT8NCg0KWWVhaCBJIHdvdWxkIGxvdmUgdG8uIEJ1dCBzb3JyeSBhYm91dCB0aGUg cXVlc3Rpb24gKGp1c3QgZm9yIGxlYXJuaW5nKToNCkkgYXNzdW1lIHlvdSBhcmUgdGFsa2luZyBh Ym91dCBjb2RlIGNvdmVyYWdlLCBjb3VsZCB5b3UgcGxlYXNlIGtpbmRseQ0KYWRkIGEgbGl0dGxl IGJpdCBtb3JlIGRldGFpbCB0byBoZWxwIG1lIHVuZGVyc3RhbmQgd2h5IGFkZGluZyB0aGUgc2Ft ZQ0KQVNTRVJUX0FMTE9DX0NPTlRFWFQgd291bGQgaGVscCB0byBhIGJldHRlciBjb3ZlcmFnZT8g U2luY2UuLi4NCg0KPiBHcmFudGVkIHRoZXJlJ3Mgb25lIGRvd25zaWRlIHRvIG1vdmluZyBpdCB0 byB4bWVtX3Bvb2xfYWxsb2MoKTogVGhlbg0KPiB0aGUgZWFybHkgemVyby1zaXplIGFuZCBlcnJv ciByZXR1cm5zIHdvbid0IGJlIGNvdmVyZWQsIHNvIG1heWJlIHdlDQo+IGFjdHVhbGx5IHdhbnQg Y2hlY2tzIGluIGJvdGggcGxhY2VzLiANCg0KLi4uYWZ0ZXIgcmVhZGluZyB0aGVzZSBJIGhhdmUg YSBmZWVsaW5nIHRoYXQgd2UgbmVlZCB0byBhZGQgdGhlIHNhbWUNCkFTU0VSVF9BTExPQ19DT05U RVhUIGluIHRoZSBiZWdpbm5pbmcgb2YgdGhlIHhtZW1fcG9vbF9hbGxvYywNCnhtYWxsb2Nfd2hv bGVfcGFnZXMsIGFuZCB4bWVtX3Bvb2xfZnJlZSwgd2hpbGUga2VlcGluZw0KQVNTRVJUX0FMTE9D X0NPTlRFWFQgaW4gX3htYWxsb2MuIEkgdGhpbmsgeG1lbV9wb29sX2FsbG9jIGFuZA0KeG1hbGxv Y193aG9sZV9wYWdlcyBhcmUgb25seSBjYWxsZWQgaW4gX3htYWxsb2MgYW5kIHhtZW1fcG9vbF9m cmVlDQppcyBvbmx5IGNhbGxlZCBpbiB4ZnJlZS4gQWRkaW5nIHRoZSBzYW1lIGFzc2VydGlvbiBp biB0aGVzZSB0aHJlZSBmdW5jdGlvbnMNCmlzIGR1cGxpY2F0aW9uIG9mIGNvZGU/DQoNClRoYW5r IHlvdSBmb3IgeW91ciBleHBsYW5hdGlvbiBhbmQgcGF0aWVuY2UuDQoNCj4gSW4geGZyZWUoKSBJ IHRoaW5rIHRoZSBjaGVjaw0KPiB3b3VsZCB0aGVuIGFsc28gd2FudCB0byBtb3ZlIGFoZWFkIG9m IHRoZSBlYXJseSByZXR1cm4uDQoNClN1cmUsIHdpbGwgZG8gYXMgeW91IHN1Z2dlc3RlZC4NCg0K S2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri May 06 12:16:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:16:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323052.544580 (Exim 4.92) (envelope-from ) id 1nmwsH-0005ia-07; Fri, 06 May 2022 12:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323052.544580; Fri, 06 May 2022 12:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwsG-0005iT-RT; Fri, 06 May 2022 12:15:56 +0000 Received: by outflank-mailman (input) for mailman id 323052; Fri, 06 May 2022 12:15:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmwsF-0005iK-Jz for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:15:55 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46cdbbda-cd36-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:15:54 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-Od0Br0g3PZ6a_hV4mjaVWQ-1; Fri, 06 May 2022 14:15:51 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB5500.eurprd04.prod.outlook.com (2603:10a6:10:87::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 12:15:49 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 12:15:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46cdbbda-cd36-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651839354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fZ1qEo4Rd9MIG4RAQQAmB4EKLXIO9dWWevg+YaxVE44=; b=diNPVQX914Mdnuv/PGeuTN1LjQQWcMWQO2tlBNyD5kulipHIcAN9A+CzWo4j0t/SJ/rnsQ y27LW0CmKdxUp5FzfMyPiTpOYyz/cD7zSHKHu+Iv9WG7HIw/gV2EMh4CZJFYcdbrnhRVrm hOlkCw8onMy+gLb5k8XkcycbUV191xA= X-MC-Unique: Od0Br0g3PZ6a_hV4mjaVWQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVWOnjfkOJVjLWxo6ZLpJwl+Uu30NVn2mw2JiUmxpuWKrTO5tO0JFtjUzYbcfCw8Y+nfYwm8x4407yXxOfFP1Af41Jlf+b8KWJLRLmLLRLwGBWDVKkoMp0tY2nYyoECBaRIUXRAtJNeIEZ31KWsFyPdryabH4gx7AvW/QXhEE3iDScGkMBpuMxqr0cQkEbExwrO6Kr5LFexk0Sr73Jj0n5kccAVY2lzmhcGa/OspUqsAv0H/NPI0xo97G449nuSonGbP2Gv+cuWydMQUd1BvXQ4ucg6xCEWcskDH/UiBESJs//HU220sydZNim/RbhAoXQ11HVSnIhG8AmFkHK5EHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fZ1qEo4Rd9MIG4RAQQAmB4EKLXIO9dWWevg+YaxVE44=; b=FSmPlYFwBp7U2ddqsWuwMQ7tvGd5CnRHfOTYnzKM8o8eHzTQ2BpxyrRrOXPKT9UAMxCRGQExI2aZ4409CRXBgQSYgTj4motpHhUqvDfJniIobg758zEGO60oJjgzRGMr9641XeyqyieAuSXTGJYWQLchlL1zS5H8iva589C2YjLCgwyBxEpHL8bKIdHRl46X1Z700/4mOTqLvfDxP8oXtX7aaK2Eh/GDvcfutFdWCgXMZV1LmK734iqnhUiLRY8m2EuaTyV5WM6rVtxu6xEESSbLSGLhGrInXAPTpjjPkHSoyKCehrBuiPXLBG9ao8mqxrxOIJrsYSiImHtsUF3INw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> Date: Fri, 6 May 2022 14:15:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220503082650.23049-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0043.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::20) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bffa1e0-6e62-49d9-ce84-08da2f5a2807 X-MS-TrafficTypeDiagnostic: DB7PR04MB5500:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XNGVlhW2/n9m6uXqnAfxVNtkUFdd95BDZOoMj1Yv5PcRLVHD94MC7DchGKXmhcbGO+QsP9WNeNSUYSw+xpoGH602eFjyg69IG2JI91C9iHcH7Yx00VwE7+eqNvKJyAEVg2AC0YmvddjVVhqE+klEhwCS2QbwrQZVvCba/5vxLbo6ZCWIolpJ4A7qzEt3hT7cu4pWFsF9ADnll6dRAgvO0hroDVp4l0R5zZxYbOV+LNt9tywihhoVsiSOzFIpDo7YUUNQAVbeR0rn8qM4PX2lLLQJ5gMSj2Uiz7HFgcuXFTojLb0uydslUdcI6Cdfud4sPs7/jXgBxW8KuqqLwUMuanXQlNuSlb/t55CtVyXCM5oj9R8hv2DCz86VwR7vAWmfhWdhZq97QAWOuUc5kuyBKZAECblz5OPjZNLSmiPKMzV3PutU6O9VrgxFmgfqFk+bVMazskVlScxxU8z3OJRFV4FFZbGu+REhJJkc5286rKMZ3MDDMG3QbFJckJlCpwVJvmYq/gx0aiMUGQGl9HTjF0NcpCQ0cMYQEJiZaFdkYVymdibZVsoks0zCfBN75rK5XnoFTT3+YUcf6rYNk+FRDwJZaLhVP4bWg95e148mGYnJRJC31lYoZl6YMr2pa7WmxDVusKF20KysPBfDUX2FHBuu3Q8CMMXlcLjr58zr9c0xCatpq6z6CJ5naUFEQbRFcPqvPraxLdUrQrbh6H8TzmR+RZyMawD4cz+UdQQnD7g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(83380400001)(36756003)(31686004)(2616005)(54906003)(31696002)(186003)(6512007)(26005)(86362001)(6486002)(316002)(508600001)(8676002)(53546011)(6506007)(66946007)(66476007)(66556008)(2906002)(4326008)(8936002)(38100700002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWFnS0QvdGRJYUFzT1ZsWjlVWFlhN29UVzdZVjY4bnFTS3hNUDJMM29XdDRo?= =?utf-8?B?bnRpbFJPSFRpOFFUeVJkZXJKK1E5M21XeWxZSVJjQkhzM3N1dm5GdStUODVN?= =?utf-8?B?YkkySmJSNmIzcXY1cGlETWh1djRoK3hsUEhaNksxbVNMR0FFcWlqZ091Tkhy?= =?utf-8?B?YitZNlJrbzlJTHBGaEhRVXpPS1lYc1ZCU2Fhclk5S3lzeWRPNk15VkJOSTc2?= =?utf-8?B?WS9nV2hzVjYxNTZzVzJ1Z1dGdnJwRlhFOWpiem05Wmo1THQ0RlJ6ZWtnSmNu?= =?utf-8?B?QWZYY2x0cmQ3M3B3SlRnS09QUCs3TVBKNyt1cFBISjVCT2pxdTR6TVhBZ29H?= =?utf-8?B?aUpWUjgyYmt4ZnBvY1EvcGNhdVpmZ1JISndSMlUzeVR2Ulp1ZUJ4NVcvdE15?= =?utf-8?B?ZkdoMTRzQWhuZ0MwV2hKSFEvZ0x1K1dnUWszQ1JTK2Z5ZFRaaGJMc1lJQUZs?= =?utf-8?B?bmpCU1BhSDczVVd4YndEdmVZdThna0tNYVU0N1Bra21MY2NNZzJERysxK2Zq?= =?utf-8?B?K2EzM1RUd1J0OHBwZFprTkgrWC9RSzFZcWRQTldWMTNJcjR6dEtwcXczL2tN?= =?utf-8?B?TlJEQ0dKbXRZZEVBcVNPSTNnWjQxQWFkTjNVTm16d1BEeEtNQ3JhN0NMQU1B?= =?utf-8?B?WU9YelB5cmYwM0JsQjNvUjhQQk5FSnd6V1AzL0hoZzZ4VkdHT29raGMzYVIz?= =?utf-8?B?dkdYZEZzVHpEYWdLSktHTnk0UGtsdHhyVFF5M2k2Q2pwWlk1RVE2dHB3cG9L?= =?utf-8?B?M1RlMVRoc2t4L21VTmRQRjdta2VEZW10YmJHTCtxZmpZbTc2aXl5bzRmbis4?= =?utf-8?B?S0hUWWtTcHJ2ZGJ3TnhEcnZnRndxZnhYZnNiMHMvTVAreVpnaS90anp3dlFY?= =?utf-8?B?YzFSN0psdlFIWlNvZm9sM1RDODVnV2NZRUZzRXBtc1k1TTlPNWd0eVlDUHAz?= =?utf-8?B?dThFTmRDbndHdE9PVmFzcmZKOGFrOWhzMzFId1p0a3czWTBLRHhIUy8rS0NX?= =?utf-8?B?ZVovbHZGcHJYakxGY1A3bEJXUmx1SU9jTVJHNzcyMDB5bGROeDVUWjlreSsv?= =?utf-8?B?Tmt4UXBhckE1Mm9GeWpPZlZ6d0xBVkUra0NmOS81NXMzaTdRaklrWUVwVTJo?= =?utf-8?B?R2V4SnFCNTBPZko0a1dBZHpMaWYvSEY4czF3R3VDUHdDNDQxNEtMNjh2ZEts?= =?utf-8?B?cjBuc2swSnJTa0VkMFZQTVY0Nll0dDgvUXNkQUdXSmZMMTdZblpQVzIyMzhG?= =?utf-8?B?N2t6c0VaTW44ajlMQWYxUitJTnhEeTZsWEVxQ1NTZ0xQOEdKZWpTRGxFdnAr?= =?utf-8?B?YVo5ZmN6MkRqSmtUZFNqT2FGcUVHSEY2SEJVTkJ2aDRrc3dwOHhHR1Z5WFdH?= =?utf-8?B?bk0wSVcreGtlbHpJNFZPeWR1eHNnS1g1K3BGdDRJcXhXWFZxQktJRDRYclht?= =?utf-8?B?cnYwK1ljdElCN2h3clFaOEorK2JhMWJhWnZETTd2T29QeWlZZFp5cnRGaDQ2?= =?utf-8?B?VHRlK3p0T2N5MWpaNC93Zi9nWXc1d1NnY2hranVYUkkxSmt6clRQdE5Vb3RB?= =?utf-8?B?QmdUMU5rY2VQOVpZSzVLa2g4QnBja2haSHBVRnlnSStrYTVSbmwyWW5UZGRw?= =?utf-8?B?NGhLNnlFdllTVTB4UFAvR2NUUVNJazRPS2xvNm8wNXg2Wkp4QjBENlBkUXNo?= =?utf-8?B?V2tveVF5eTdhODlGR1FicDJ6MFFQejNYSWFLUitnTndpOFZFZXNkcFBKdXlQ?= =?utf-8?B?SXZ0eW1Jazh5S1hQcmNPNHFqOU1pVVFlRVhTS1U1OThWMzNmSFFabDZtcHNW?= =?utf-8?B?MUNZQmFRV3MxckVvTzNkMWN5R3pyNlRsb0ZSRzBsM2hsQXc0cXZXOXNiZFMx?= =?utf-8?B?VElmQ0YzaUI0WUd5Ukt5Qi91MGY0MXkrVDdaQ2NpU1poWHZ1QW90cXFJRk91?= =?utf-8?B?ZW1TcjBCRng3SFo5THR3Q0JSRmZwRjAwTFR0K2xzVndpV05qL2YwbzBBbHJS?= =?utf-8?B?YmhVZ0VIeEFEMGlselZtazR3TVREZTc1VkRYVVQwUTVjNkFvZkx2WVFtY3cw?= =?utf-8?B?dkdoaElhTUhha1BGeW5tV2xGZEozcVE0c1lKazlJYnNXeHE3K04yOWJ6YWJV?= =?utf-8?B?RGRIWnJvOURXdjlqWk14ZTNBdmpYRjdRTFRqVk9KNDRVby9OTWx1b3NPK1Vz?= =?utf-8?B?Q2ZQZit5ejloYW8xR3I4ZUZzdjhMOVJtZ01peXRYUkNZZjhEdjhCUTkzRHNR?= =?utf-8?B?RWo2alJrQ2dkMytZTzZQam03R3hIcmJZc0FheFpCSnpwenppZHhoMndUTFBC?= =?utf-8?B?NUZvME96c3VnVGtkZlBtWUUyTmZrclJwdmlSQUxScjJuRTQxKzRBdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bffa1e0-6e62-49d9-ce84-08da2f5a2807 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:15:49.3539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhRHXoVLufBulJLrBk8T7/R4B2K3F1qM8bTD5/jtze3L3g1KznaybPxFKA6JnDVsbUVtotI16tt0r+HUeVHNcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5500 On 03.05.2022 10:26, Roger Pau Monne wrote: > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) > raw_cpuid_policy.basic.sep ) > __set_bit(X86_FEATURE_SEP, hvm_featureset); > > + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > + > /* > * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional > * availability, or admin choice), hide the feature. Especially with the setting of VIRT_SSBD below here (from patch 1) I don't think this can go without comment. The more that the other instance ... > @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void) > guest_common_feature_adjustments(hvm_featureset); > guest_common_default_feature_adjustments(hvm_featureset); > > + /* > + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus > + * VIRT_SC_MSR_HVM is set. > + */ > + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > + > sanitise_featureset(hvm_featureset); > cpuid_featureset_to_policy(hvm_featureset, p); > recalculate_xstate(p); ... here is about default exposure, so cannot really be extended to the condition under which this is put in "max" (except that of course "max" needs to include everything "def" has). > @@ -3105,6 +3116,30 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > vmcb_set_vintr(vmcb, intr); > } > > +/* Called with GIF=0. */ > +void vmexit_virt_spec_ctrl(void) > +{ > + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; > + > + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) > + return; > + > + if ( cpu_has_virt_ssbd ) > + wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); > +} > + > +/* Called with GIF=0. */ > +void vmentry_virt_spec_ctrl(void) > +{ > + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; > + > + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) > + return; > + > + if ( cpu_has_virt_ssbd ) > + wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0); > +} I guess the double use of current makes it difficult for the compiler to CSE both uses. Furthermore for symmetry with the other function how about void vmentry_virt_spec_ctrl(void) { unsigned int val = current->arch.msrs->virt_spec_ctrl.raw; if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) ) return; if ( cpu_has_virt_ssbd ) wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); } i.e. "val" always representing the value we want to write? With at least a comment added above, and preferably with the change to the function (unless that gets in the way of the 3rd patch) Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:28:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:28:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323063.544591 (Exim 4.92) (envelope-from ) id 1nmx3t-0007N4-0e; Fri, 06 May 2022 12:27:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323063.544591; Fri, 06 May 2022 12:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmx3s-0007Mx-U8; Fri, 06 May 2022 12:27:56 +0000 Received: by outflank-mailman (input) for mailman id 323063; Fri, 06 May 2022 12:27:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmx3r-0007Mr-Qa for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:27:55 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f410b16e-cd37-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:27:54 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-xoQQ9-TfP4-mOPEjy5Gm_g-2; Fri, 06 May 2022 14:27:48 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB8PR04MB6505.eurprd04.prod.outlook.com (2603:10a6:10:10d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 12:27:45 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 12:27:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f410b16e-cd37-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651840074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4dyWkB4aRxEjKwy9UllWtQ8l0p1Mlsa1ZfrvkuDi0Ag=; b=j2JYpz1pUH4vTM90qXJowIpera/yDX3t+GqdWFQ8Fx9U2wwGiOChRbyrabLx7taW7X6Yx9 Mbphv65Mdumu2nBtAWuX3TP5P5au4vybK6YEa6pKOeEJBWY+rslXtEdRFrP/sXo6mO3dHG +d2RttjAMXgWs0502N2qk4ot50z0hG8= X-MC-Unique: xoQQ9-TfP4-mOPEjy5Gm_g-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kJ7b/dH2oQdIGd30uIUddeoKXCi9x6jkUZm71XKsYvqvTktcuIdE4174esXHUn2pEK0DrXQANS4sUsUsTJbJTHfPJ4IcNMbTl2X+c5ekumQXZCsZPb6y7BUodHOxplBHZe8+bp4XiJ5IBcFxnaVYn9exhYEW3YhH5FLgnULF63h/CkVVS9UT93JLuF5d06anjF/ZMCf/cD210LbfB5OzhGmJYyOgxrNm8+EC3NZBu28G7AHCGTPv/l60Z4kGRqLUTkoRX7N+a86Njh59YtkY03KurPkt1DShi2j4PhX3+U+vp6LN9/xs+G3JM1A8d36BinKNEZ5C5oxXbTYdVi1ShA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dyWkB4aRxEjKwy9UllWtQ8l0p1Mlsa1ZfrvkuDi0Ag=; b=OszG/VNJqrYXCH0Ee91tnXkfCIwa/VEUUpX2Mz/XGv2ifnTVNLBQy+8JNf5OC6isc/AmDRc1h7iPncu4UCXN93LK2HznDhZLb9tjcrNo0DwFIdGzUPG3sH51fKz+NScvYKaSr+9SbCKsDL80XxUBkpcaewJ/ERTKp5iSmT4PMw2Zd+XomfaZwC72XHN14dGtCov9K8WVDeiItffYJjdoIBPlX3pz+iR98wGvHBJeBgCLe6y6kDlRHUn7rokKSR3c+rcP/XTX30UQ2pCFykPtc2+mbaX/5yqvMYfLqRRY4s+F4RXVameMwip/Zocip4BYnL1RfyoF2ZY2/mpcK8MEaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3dbdf5a8-1257-01b1-f61a-a39163be26fe@suse.com> Date: Fri, 6 May 2022 14:27:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Content-Language: en-US To: Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Wei Chen , Julien Grall , "xen-devel@lists.xenproject.org" References: <20220506055201.999277-1-Henry.Wang@arm.com> <20220506055201.999277-3-Henry.Wang@arm.com> <6a44bc43-c392-2eac-d350-ec87cb2c3ab3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0032.eurprd06.prod.outlook.com (2603:10a6:20b:463::8) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b556587e-8cd9-429b-6293-08da2f5bd310 X-MS-TrafficTypeDiagnostic: DB8PR04MB6505:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8PYqv/D32W+ltMwYoDv840/m5kVj0cpAID4EN5SYlKRB8kXwSZP2WG985uddfI85y/44gm3xSpC/APi50lA/rpF2/9kGReEiesvdLPQggMePhRGdTJdp+yuNP5+85zv65g30V444aDENUhN7wWEZYmC8zHZVUjJJ4nI2e12j9taJdR06c+ZFbLB0l1sdIGD49peDgPO9ExDlKeIBG5KHNNzQY5/0A7/CjryU/yDXB4vZXF+n3xr9AL3cM3gCieiEGev/yeIwnOCV1/jUZfeXKsN+kQpU2NLbla2yh4CesOeeih7iaOz7wttA8L6rqLOBoFSHkRj69mAzf9jG4O7cxwaS8vHPQyt0kZ/0JY2KYxSvTjvl17Rryo2NSkraYMDawGWOLDzHdKGQk1kdBr4UC3K3tIidWNSYh0mUlEc0YCH3MFxNxuek5e9c8cnL04bvHVSok+eRWOdsxXZCxDaETAKPNNoSDKV0jNEUhXka8BtnHgifFbOx9kXzIp9TKr0h3GUrecq+3PGbj33bI5ZLXPkLqIa/jmLEOP6pB94g7r0KUZEiAJqqjGEzhI/AqQ0bovJkumeAx/S7R8+TxybhDcGR53/xT3lrqkMrNHUokJHrvDm3TUWh6Iq1vocTUgmAgqm8+0fdNYQb41JfoQYiPNDfZK7fA1qcVKzoIp5U11uptmXZzwi/Elz+xWMS8+2u2qEnlMEl6zGWk5PrZMIK7sin9fUEP6waVKkSqvAGXUzSnRWt+P2FAJ2+wUpTtkT1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(7416002)(38100700002)(6512007)(316002)(6506007)(53546011)(5660300002)(66556008)(8676002)(66476007)(83380400001)(2616005)(4326008)(86362001)(186003)(8936002)(31696002)(36756003)(54906003)(6916009)(6486002)(31686004)(2906002)(508600001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGFZWitYR21PTm1iSlRnOHZ0bGgwZXZwc1VaNTAzQWdzUHRVU0hRamdaOVJR?= =?utf-8?B?dXk4Z002Mk1LRkRvTUFHMERNang3UTNlRHVXaEJUTGVyb29keTRFYjA0RWVI?= =?utf-8?B?a1d3TDdma2ZEOWtIY3R1L0wzMmFOM1ZzZW9yV0lROEdDYjA3UllDaHVOcHlj?= =?utf-8?B?dzhUY0JuNldtZ3l5dnNHMjhKaUhkc1hwOXRMNXI0SWdzZmZmeUZPS1ZOYTNU?= =?utf-8?B?bzdVcWhDSFVlMlhvNTlkRDlLREFrM2Vyby9GQUpiVExacERQY2FTSElsQ3NX?= =?utf-8?B?QVYwTmNxTzM2NWg3QlEvK2hUR0VqdkM1b0pGZ2xta1F6cEx1S1g3SHZ5Q2tX?= =?utf-8?B?eXdJU1BvUGFuK0NIT3VjcFRVZ2g0N1BrV0ZQQWVSTlUzNGpxOEp2SUFud2lx?= =?utf-8?B?Snd1SmdTa1B2elBqbkJreUxQYTcrZXFyMmhNOGprQURaTHAvaXZtd3hqenE2?= =?utf-8?B?bU5UbkhOcVNsdVBTVmlaakZ5WXFacTBFQXdPdWRwOG5iTy9ubnd3bXpEa0Z6?= =?utf-8?B?SzV5eW1qUW43d09yK0JlUWIxdGF6V2ZTa2dHYW5NNzB5ZWs5RzNpZXRndzlU?= =?utf-8?B?eXNJN3ZCREJ1RjhBWitCeUk4MERSODNCZ3BmUmJGbmdyalBXY3Mwd0VoeDB1?= =?utf-8?B?NzZlbkpMRi9LWEF4U0M3Nko1eVozTGdSWE5tUGR6T3pnMG9uV2o1RjVDWS9a?= =?utf-8?B?MkMwNHpranVoNDJmZEVZOGZTM3p4bEFwTW9DcjVrSnozZ1R6bW05T1I5T2Fj?= =?utf-8?B?Ykx4UmJ2azlLaDhqd21zeC9pSlRjNFB2ZFdVYkQzNy9EbTVWdUdLRDVIQWZz?= =?utf-8?B?emFxQTJub3VWN0ovSXRHNnpqWWxTTDRWN0h0dmdHMlFXWnZwV1JyZy90WWJx?= =?utf-8?B?WEhtWTRpVjhJaTVwS0FrNUkxWmlMaG5BQ2hYMllaamxoTnhFNUo2aE9HcXJt?= =?utf-8?B?U3lFaUdoSzNVcjBuRGltcWF6TU5YWktrQ3FGQldabGtORFdsUVVMWUVLd2lt?= =?utf-8?B?QnFITDI2NVhKSWZ5SnRPVTE5SFNTbDRBL2E2aWN1VWVDTUQ0U2dLUVFuTVRK?= =?utf-8?B?ZXZvTjNmb1FmNzAza0JQVFVzZkNhaHV1a3ljbnZJY1kxTW10bTZkd1pYT01y?= =?utf-8?B?cWowamFOeHoxbUhxUE43MDU4OWMzaGhHY3kzcytqbHp3UWltM0NOV1ZaUzZM?= =?utf-8?B?d21iK2dJVGptUklQNGhFUEVxRUVOR1JUMVd5YmVSbUlRUzluL3JWaXhlSUI0?= =?utf-8?B?TWZpVy9GNmpXbkdlUHhZZDUrbmZlTk11UmgxNkNvZU1QK016cEsyQ0tOSkVI?= =?utf-8?B?T2p2M1dsR1pESTdMUW0xSnMydTNFYStwNVNseUNWZ0FFT0hkTm56SEZtVCtP?= =?utf-8?B?YjBmY05yMEZFZHBHd2toQTRjaE1ReTBhRVdyelNCcCsyMzJLbXlQNE9CS1Jr?= =?utf-8?B?MHJjUVcrOENRT0ZkRWlVR09FY1RpK1VHeXA0ZDZWdFpPa3hhQzZjb1k0Q0lY?= =?utf-8?B?NlFXaFBrUzRZNWY4WnBLRXlsRVV5b05wMkd6WE5MOW1hUG5JL3ZidllLV2ho?= =?utf-8?B?ZUdIdVRQeHk5cHEwLzZKd05iWXcvOU5IZjB3WUdWajRoUGlQTFFtNGxkYUk5?= =?utf-8?B?SGRjYzh2Y01WWmtBcEpXYnF1MjNLdWl2V0xSRnVCOXo3TUZWVTRiRHQvdmdS?= =?utf-8?B?ZjI3cDl2Zjd4UDkzU0Fsano0bVM1eTNxR0RBZGpxY25XNVIrRDFhbmMzS2lK?= =?utf-8?B?eS9jNDBReEtnUC9LQVVKS1ZXTG9LeFN1eXB3ZjB1a3AwN2JjOUU0TkplUnh1?= =?utf-8?B?T25SOEtDQmZvd21LUS9RajY3aE9FbW5pYUdEaERhM21iVDZjaXp3Ni8yRFJ5?= =?utf-8?B?cEgyckNhVGZGMVhjaTlzSlBORUUxTGdTY3FtSnpzekUyMEJweE55cFBORnNB?= =?utf-8?B?UVUvRDJKWGwrQzd3dGJpMjlPUWpKd010MkZUeTZ4c1dlVHVPK2xOS0hRUHg2?= =?utf-8?B?Q0xTVDF6dzJzaG9TekEwbmE5OFp6RFhrVUNpa2hqTkdzd2g5MzNSMWlKcFJl?= =?utf-8?B?L25qRnVqMm5xWVJtRmxkeUhGYTA1U01YZkNnNmprY1BKZi9WRy9QamZ3TURH?= =?utf-8?B?WHk5dWJUdmNqdWZseERlMUtqNUFzL1J4ZUJ2MHd6Nm1oU0dvbWJFTXVJaDJT?= =?utf-8?B?b0c4VXUxdmZ2ODFUMjRqdHVXdUU5YUNhOWx6OC9IUlY5cllCQTFpMEFuZlJU?= =?utf-8?B?NnZRdkhrYnQ3YXdneXJRekIyTTZ4TVpXU3RLU1VHODZlSTM4Mld2WTZhNVNJ?= =?utf-8?B?U1JSa3BJcnpNbnk4NzY2UmtseXJvcVVMdkRSWUNFWGJXZHVLS09kUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b556587e-8cd9-429b-6293-08da2f5bd310 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:27:45.7192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5DcQzuEqrArQ166a6ea2R5H9Vc4RyvWVx2j1rj8fwCE1jPg2cKk3lvDUkVF6LHq8Li+VUhe1WjAYQiMd5OxNhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6505 On 06.05.2022 14:03, Henry Wang wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, May 6, 2022 6:33 PM >> >> On 06.05.2022 07:52, Henry Wang wrote: >>> --- a/xen/common/xmalloc_tlsf.c >>> +++ b/xen/common/xmalloc_tlsf.c >>> @@ -594,7 +594,7 @@ void *_xmalloc(unsigned long size, unsigned long >> align) >>> { >>> void *p = NULL; >>> >>> - ASSERT(!in_irq()); >>> + ASSERT_ALLOC_CONTEXT(); >> >> For one - what about xfree()? > > Oh you are definitely correct, thanks for pointing this out. I will > definitely change the assertion in xfree() as well in v3. > >> >> And then did you consider taking the opportunity and moving both to >> the respective pool alloc functions, thus giving even better coverage? > > Yeah I would love to. But sorry about the question (just for learning): > I assume you are talking about code coverage, could you please kindly > add a little bit more detail to help me understand why adding the same > ASSERT_ALLOC_CONTEXT would help to a better coverage? Since... > >> Granted there's one downside to moving it to xmem_pool_alloc(): Then >> the early zero-size and error returns won't be covered, so maybe we >> actually want checks in both places. > > ...after reading these I have a feeling that we need to add the same > ASSERT_ALLOC_CONTEXT in the beginning of the xmem_pool_alloc, > xmalloc_whole_pages, and xmem_pool_free, xmem_pool_{alloc,free}() are what my comment was about. And "coverage" was meant as "if the assertions were there, more [potential] call sites would be covered". xmalloc_whole_pages(), as you ... > while keeping > ASSERT_ALLOC_CONTEXT in _xmalloc. I think xmem_pool_alloc and > xmalloc_whole_pages are only called in _xmalloc and xmem_pool_free > is only called in xfree. Adding the same assertion in these three functions > is duplication of code? ... validly note, is of no interest in this regard, as it's (1) a static helper and (2) would hit the checks in page_alloc.c. xmem_pool_{alloc,free}() otoh are non-static functions, so we will want to care about not only existing callers, but also potential future ones. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:40:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323069.544602 (Exim 4.92) (envelope-from ) id 1nmxFm-0001GL-6W; Fri, 06 May 2022 12:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323069.544602; Fri, 06 May 2022 12:40:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxFm-0001GE-3D; Fri, 06 May 2022 12:40:14 +0000 Received: by outflank-mailman (input) for mailman id 323069; Fri, 06 May 2022 12:40:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxFk-0001G8-VK for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:40:13 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on061f.outbound.protection.outlook.com [2a01:111:f400:fe06::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf0e34c-cd39-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:40:11 +0200 (CEST) Received: from AS9P251CA0018.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::16) by AM6PR08MB4232.eurprd08.prod.outlook.com (2603:10a6:20b:b4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 12:40:08 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::bc) by AS9P251CA0018.outlook.office365.com (2603:10a6:20b:50f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Fri, 6 May 2022 12:40:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 12:40:07 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Fri, 06 May 2022 12:40:07 +0000 Received: from bece71d4864c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A40D9F2E-CBCC-4B1F-96AC-25882DBD365B.1; Fri, 06 May 2022 12:39:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bece71d4864c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 12:39:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM0PR08MB4307.eurprd08.prod.outlook.com (2603:10a6:208:13d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 12:39:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d49:4e03:8569:a07c%7]) with mapi id 15.20.5144.027; Fri, 6 May 2022 12:39:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf0e34c-cd39-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DVcQjT/kz2UDVTXJl/p5LK1MG/mM0AVi6S73eqJzTVs53dGcH0NhHl9DEjEnzN7/K8OIYuZG+ghHtkeBBmCMFJ12Hm+uFhhxBg5XiRkMLFJOmu8TO1l9rYRanJ1PPrjLGw4Jh1PBzkVvbTrxs4lpk0pVN+TlfT/l41gHgqjCCxOiCnBSXy/Jf9zHtvGGNlIgqcyFmF6wIMno1Cb+IvPoHCLQIyryLn7Q6CArfWlPAHfWchlPV6/lLTl0nzFOFUtSzlNgab0H9X3mrOjlfzwLTTgVujuDwRJD4D6oXY3kzK7m77u0l4cgamAM3ZRgb/SZsI9vY9HXjv/ZfNkwkOd7VQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFNE7/+zluslQcX6pwyHXxsd++W2iDNOce2ssCCoTcM=; b=n43R5hRr630NkPQrAyFwhKV7UGFmKjFqXKMkuBOZQS77x86kMYsmqIrYq31HaOj91bKAx2ANQHpDJEapYgqEnw49bMIoReIHmZ5sTFGjdUbiBbefwqxf7uHWSK2qOxuk3/AbEAnVcgrhN2BxgcgYskCtVhBgTZCxlT0Z32OISLMcaKumq46W2RveDXkKZF240Fz0DCsKHuX4wb3chlxSKBFefODgOV+5nILBWMEEvEjAMXpbZFL3Frkso+Qm3+U1I0sEApcqYIZZcVgibNFKYL4YFKHs53dBaK39plBYwRRDce5nZYo7NSUV0FCiuuSkZ8M7T+i9VyuQO0VZLOkOKQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFNE7/+zluslQcX6pwyHXxsd++W2iDNOce2ssCCoTcM=; b=ECtA9jZjM7QTGsOJAm3oqTbDjgexnd25lVTNJaZEDiq5QjeEmi22XVmVo808XJwcpVHg6/mMqcI+NZceWuNxVQRPFuTgE4jPlJITp5QnhZU4nz6SU89JfSAn7VPxlOCx5pcpOKSLO8/TfVluDaCtJeKThttoGHng2pDvMV28pYY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYGlGCC1zLPQ6n+PMqt57GI6YeoeyNfjH/ibDM34mbMQCvfnyyfYXSNS9e19yLhido+a3TFmJFJFgg94LcFEeJvCF+ovRxkNpfgkEm0Jjm1hfLivOOCLU9WShz5OSSeD7canHsnaTNjjPRdvfEOnyGZnT1j9z93sWgWLzmZrvWhziLnjELOzwfikFttsuf3oxWYtejSMXKsvqL6ECQRdbTwG1juNsjG+MS/4PHUKNon5CppL0NNp3ZHtKW+XyrSEJ6IQFNMS7gLIkohKhnG+IUgEzlVq+aOm/tafNhnjbblo/McnbAy7j13EXJan0JCmT01FGdyXCAleX2L6Fllcdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFNE7/+zluslQcX6pwyHXxsd++W2iDNOce2ssCCoTcM=; b=Wvd/ITjzwtqbDQ0efDsMaohdpz2jqUVMQaDklJFfQDcqWNwxZ04iTmeeOhS9OKbdhYLYf0I2rXtxiM/QlSSw97aEmbVXgqondO/wFTYhJdfB30a5wOsNyPoRQr/bkGaG6TVyqlPsPekZ/D5BNqsq8VLho/gMVmisL7UUGm3mkoZnyVkA+KRwF6IXOTP1YEMghYf5kCsQ/s71DEWpHrmf8tYG+anazDPKYYVQUbuU1YguTjk5NuU0yyUuxwkThPiCEKanrB6B6nQ0Ga8s8oGoy8yomILSfUutGCH75Xu/2fSRuQtk/2JYaEyhNEh8GOO0rB8bk8BkJZVXCtVCAZrxAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UFNE7/+zluslQcX6pwyHXxsd++W2iDNOce2ssCCoTcM=; b=ECtA9jZjM7QTGsOJAm3oqTbDjgexnd25lVTNJaZEDiq5QjeEmi22XVmVo808XJwcpVHg6/mMqcI+NZceWuNxVQRPFuTgE4jPlJITp5QnhZU4nz6SU89JfSAn7VPxlOCx5pcpOKSLO8/TfVluDaCtJeKThttoGHng2pDvMV28pYY= From: Henry Wang To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Wei Chen , Julien Grall , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Topic: [PATCH v2 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Index: AQHYYQ1+wSNISpljvkG6pMKyJcwNSq0Rpx4AgAAWlnCAAAmQAIAAAnVQ Date: Fri, 6 May 2022 12:39:55 +0000 Message-ID: References: <20220506055201.999277-1-Henry.Wang@arm.com> <20220506055201.999277-3-Henry.Wang@arm.com> <6a44bc43-c392-2eac-d350-ec87cb2c3ab3@suse.com> <3dbdf5a8-1257-01b1-f61a-a39163be26fe@suse.com> In-Reply-To: <3dbdf5a8-1257-01b1-f61a-a39163be26fe@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 52DDF5847446FA4E9E1445B6DC27DECB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f2eb56e6-acbf-4428-f308-08da2f5d8d5b x-ms-traffictypediagnostic: AM0PR08MB4307:EE_|VE1EUR03FT024:EE_|AM6PR08MB4232:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8bpyQNapg8MDc5iRxVCZgnK2u42NMhbEi6eh0pOVxJcE0K+VYReqbH83nJ5vvBxdtQxOzHtDbgyQpU8+yrie+3xKoQ/B3VebFMbeldDFSIUF57lMSQ5Fg1CMgMjDqpoqC3A0nRHaCudg0oVS+mUjS1dvOa+wLVO1sIqLQVXxgF0Tfa2xEFRgdUZHmhkPqw+HrVzvB2IrkmyHJnggU/+eCI1c/dBMtBC7wRaffILq+IhdQ1boP9cOjvo6DXi+EGD8yOdEyLWpv/jxnCMRswuJtXwdCWtOJW3hscrUngbMpVXVh2282Xzab/rePj8XxLmntSq6VYHqyZivXQWIkcmRV9x5XM7vSnqJXTrRglGX1V7Jvx+P+dv1U8k6ACmeh4M96KgUOxaTavTckn6S6FZSHYjIpUucdyehr0w4LdUHze3lIEu+EW4YSEW5Nz4ReqsN43YQeQ55jFR7pYbYZd23WgO/3nJQ3BtHUgz2+OJpKkImnVdm8dP4igUA4n/E/mSHARm9bXqKaeWb8eVYeWekS2qFhR0q8zkxTMUR2na9XEK+3WFeWml0IXXGBoXWMsNBsNsPzMM4FLXQFgUYf2c2X0Drig0fRevGY1nvEdreDRfR26tpmH7iCUJZnB03TmhnJa4PLjoItvsDOnec253t/C4U8qGBya7+zLBDwQLuQZTVa0ZmtMVAfGNtOVJhM1IcPMMAMKpCy6WqudcUlXRwfg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(52536014)(55016003)(8936002)(5660300002)(316002)(83380400001)(6916009)(54906003)(186003)(33656002)(53546011)(2906002)(71200400001)(6506007)(7696005)(122000001)(38070700005)(38100700002)(66946007)(66476007)(66446008)(64756008)(66556008)(4326008)(76116006)(9686003)(8676002)(508600001)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4307 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bb782574-97f5-415b-50a2-08da2f5d85ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c+nVRhg9Ua8bqQmCuIxasjhqRUAgqJI5UPpDMQfNYDUMTiTlK8bBh6czop0d8IHPa1NBDqdoFxfbx4Ge/MG/CPVDCJGwUxySSwOAASMdK7O0ZjIh2haOLLwzAzq9yqqL+b0Npde2v4zL1pRWugEuxcSOar+omI8P/5nO0ACKnx9hDzwPO95ft7u6GMXBp2t7W7zs91wb2l+Ob9nHXGAow5/s6N5McRww+D4ODwEceX33cAUHNrojHXAo0O1xniW9SAMfWXmzzstjv/qK6rFCHRaUxlwroL+3xxVt34lgo6KkrBBC5cwnQXhvQaDrNO72ihDnwFs+qplD0yI9vkM5faihLk1KiG81018Gurqvti48Wd3WCsZ+4fcjul5RAKeUK7+MYrgQhV3iRlZ1Q+D3CewIWSxZny6B7RfYmlUVvl58GJ6rIazX1ttNeqssHiX4ws3O+hCLQlkauFPdHZOWWt5dRdG8AGBmcLAX8l0q5QhNMRbjjWPtw4h+D88w0zylxurS+UP2rP1MigbBsXWeGL55z1QzxT3WMsD2MMYetl0sh/P4V+roDQHQJewZzqWynTwPbq2nGZPaoK1lii50eD9AcqxhxllrM1RID/1b3UehsyNHeJ034aOmGSJGC/98vY1tE5FgYy8Qrv2JKVZZGwb+QoIcWGScfhCDIS1EiqTcFLez1w+LUqBR9HmnhsMA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(508600001)(316002)(54906003)(7696005)(40460700003)(9686003)(82310400005)(53546011)(6506007)(26005)(70206006)(6862004)(70586007)(186003)(8676002)(47076005)(336012)(83380400001)(33656002)(4326008)(2906002)(86362001)(356005)(81166007)(55016003)(52536014)(8936002)(5660300002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:40:07.5330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2eb56e6-acbf-4428-f308-08da2f5d8d5b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4232 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IE9uIDA2LjA1LjIwMjIgMTQ6MDMsIEhlbnJ5 IFdhbmcgd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gU2VudDogRnJpZGF5LCBNYXkg NiwgMjAyMiA2OjMzIFBNDQo+ID4+DQo+ID4+IE9uIDA2LjA1LjIwMjIgMDc6NTIsIEhlbnJ5IFdh bmcgd3JvdGU6DQo+ID4+PiAtLS0gYS94ZW4vY29tbW9uL3htYWxsb2NfdGxzZi5jDQo+ID4+PiAr KysgYi94ZW4vY29tbW9uL3htYWxsb2NfdGxzZi5jDQo+ID4+PiBAQCAtNTk0LDcgKzU5NCw3IEBA IHZvaWQgKl94bWFsbG9jKHVuc2lnbmVkIGxvbmcgc2l6ZSwgdW5zaWduZWQgbG9uZw0KPiA+PiBh bGlnbikNCj4gPj4+ICB7DQo+ID4+PiAgICAgIHZvaWQgKnAgPSBOVUxMOw0KPiA+Pj4NCj4gPj4+ IC0gICAgQVNTRVJUKCFpbl9pcnEoKSk7DQo+ID4+PiArICAgIEFTU0VSVF9BTExPQ19DT05URVhU KCk7DQo+ID4+DQo+ID4+IEZvciBvbmUgLSB3aGF0IGFib3V0IHhmcmVlKCk/DQo+ID4NCj4gPiBP aCB5b3UgYXJlIGRlZmluaXRlbHkgY29ycmVjdCwgdGhhbmtzIGZvciBwb2ludGluZyB0aGlzIG91 dC4gSSB3aWxsDQo+ID4gZGVmaW5pdGVseSBjaGFuZ2UgdGhlIGFzc2VydGlvbiBpbiB4ZnJlZSgp IGFzIHdlbGwgaW4gdjMuDQo+ID4NCj4gPj4NCj4gPj4gQW5kIHRoZW4gZGlkIHlvdSBjb25zaWRl ciB0YWtpbmcgdGhlIG9wcG9ydHVuaXR5IGFuZCBtb3ZpbmcgYm90aCB0bw0KPiA+PiB0aGUgcmVz cGVjdGl2ZSBwb29sIGFsbG9jIGZ1bmN0aW9ucywgdGh1cyBnaXZpbmcgZXZlbiBiZXR0ZXIgY292 ZXJhZ2U/DQo+ID4NCj4gPiBZZWFoIEkgd291bGQgbG92ZSB0by4gQnV0IHNvcnJ5IGFib3V0IHRo ZSBxdWVzdGlvbiAoanVzdCBmb3IgbGVhcm5pbmcpOg0KPiA+IEkgYXNzdW1lIHlvdSBhcmUgdGFs a2luZyBhYm91dCBjb2RlIGNvdmVyYWdlLCBjb3VsZCB5b3UgcGxlYXNlIGtpbmRseQ0KPiA+IGFk ZCBhIGxpdHRsZSBiaXQgbW9yZSBkZXRhaWwgdG8gaGVscCBtZSB1bmRlcnN0YW5kIHdoeSBhZGRp bmcgdGhlIHNhbWUNCj4gPiBBU1NFUlRfQUxMT0NfQ09OVEVYVCB3b3VsZCBoZWxwIHRvIGEgYmV0 dGVyIGNvdmVyYWdlPyBTaW5jZS4uLg0KPiA+DQo+ID4+IEdyYW50ZWQgdGhlcmUncyBvbmUgZG93 bnNpZGUgdG8gbW92aW5nIGl0IHRvIHhtZW1fcG9vbF9hbGxvYygpOiBUaGVuDQo+ID4+IHRoZSBl YXJseSB6ZXJvLXNpemUgYW5kIGVycm9yIHJldHVybnMgd29uJ3QgYmUgY292ZXJlZCwgc28gbWF5 YmUgd2UNCj4gPj4gYWN0dWFsbHkgd2FudCBjaGVja3MgaW4gYm90aCBwbGFjZXMuDQo+ID4NCj4g PiAuLi5hZnRlciByZWFkaW5nIHRoZXNlIEkgaGF2ZSBhIGZlZWxpbmcgdGhhdCB3ZSBuZWVkIHRv IGFkZCB0aGUgc2FtZQ0KPiA+IEFTU0VSVF9BTExPQ19DT05URVhUIGluIHRoZSBiZWdpbm5pbmcg b2YgdGhlIHhtZW1fcG9vbF9hbGxvYywNCj4gPiB4bWFsbG9jX3dob2xlX3BhZ2VzLCBhbmQgeG1l bV9wb29sX2ZyZWUsDQo+IA0KPiB4bWVtX3Bvb2xfe2FsbG9jLGZyZWV9KCkgYXJlIHdoYXQgbXkg Y29tbWVudCB3YXMgYWJvdXQuIEFuZCAiY292ZXJhZ2UiDQo+IHdhcyBtZWFudCBhcyAiaWYgdGhl IGFzc2VydGlvbnMgd2VyZSB0aGVyZSwgbW9yZSBbcG90ZW50aWFsXSBjYWxsIHNpdGVzDQo+IHdv dWxkIGJlIGNvdmVyZWQiLiB4bWFsbG9jX3dob2xlX3BhZ2VzKCksIGFzIHlvdSAuLi4NCj4gDQo+ ID4gd2hpbGUga2VlcGluZw0KPiA+IEFTU0VSVF9BTExPQ19DT05URVhUIGluIF94bWFsbG9jLiBJ IHRoaW5rIHhtZW1fcG9vbF9hbGxvYyBhbmQNCj4gPiB4bWFsbG9jX3dob2xlX3BhZ2VzIGFyZSBv bmx5IGNhbGxlZCBpbiBfeG1hbGxvYyBhbmQgeG1lbV9wb29sX2ZyZWUNCj4gPiBpcyBvbmx5IGNh bGxlZCBpbiB4ZnJlZS4gQWRkaW5nIHRoZSBzYW1lIGFzc2VydGlvbiBpbiB0aGVzZSB0aHJlZSBm dW5jdGlvbnMNCj4gPiBpcyBkdXBsaWNhdGlvbiBvZiBjb2RlPw0KPiANCj4gLi4uIHZhbGlkbHkg bm90ZSwgaXMgb2Ygbm8gaW50ZXJlc3QgaW4gdGhpcyByZWdhcmQsIGFzIGl0J3MgKDEpIGEgc3Rh dGljDQo+IGhlbHBlciBhbmQgKDIpIHdvdWxkIGhpdCB0aGUgY2hlY2tzIGluIHBhZ2VfYWxsb2Mu Yy4NCj4geG1lbV9wb29sX3thbGxvYyxmcmVlfSgpIG90b2ggYXJlIG5vbi1zdGF0aWMgZnVuY3Rp b25zLCBzbyB3ZSB3aWxsIHdhbnQNCj4gdG8gY2FyZSBhYm91dCBub3Qgb25seSBleGlzdGluZyBj YWxsZXJzLCBidXQgYWxzbyBwb3RlbnRpYWwgZnV0dXJlIG9uZXMuDQoNCkdyZWF0IHRoYW5rcyBm b3IgeW91ciBleHBsYW5hdGlvbi4gVGhpcyBtYWtlcyBncmVhdCBzZW5zZSwgc28gSSB3aWxsIGFk ZA0KQVNTRVJUX0FMTE9DX0NPTlRFWFQgaW4gdGhlIGJlZ2lubmluZyBvZiB4bWVtX3Bvb2xfe2Fs bG9jLGZyZWV9KCkuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 06 12:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323076.544612 (Exim 4.92) (envelope-from ) id 1nmxGo-0001t7-LA; Fri, 06 May 2022 12:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323076.544612; Fri, 06 May 2022 12:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxGo-0001t0-I9; Fri, 06 May 2022 12:41:18 +0000 Received: by outflank-mailman (input) for mailman id 323076; Fri, 06 May 2022 12:41:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxGn-0001ru-Fl for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:41:17 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d23d1ad4-cd39-11ec-a406-831a346695d4; Fri, 06 May 2022 14:41:16 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2173.outbound.protection.outlook.com [104.47.51.173]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-65kvHPxANMm4lXE-arKfhw-1; Fri, 06 May 2022 14:41:14 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5133.eurprd04.prod.outlook.com (2603:10a6:803:5a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 12:41:11 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 12:41:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d23d1ad4-cd39-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651840876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqPRCmpTyAOOuUj8jQCEonRiqgbSakYPd+qQkcSn6Wk=; b=TGwWEbvLpFWmN633Sjal0NQGjnwratBIQmh5xi/RsBCjBydS0nMn78impmcAJQt2TSU5k6 Hat+mYB9ddfsNH7tMf2gXMaohvEIEdeW45r2Dh+FgpcZTL+Jo8d1oWk5nT/vP99vM38C6w qSvXjiHfHD/QHtUfoGA1EW10a67LyxA= X-MC-Unique: 65kvHPxANMm4lXE-arKfhw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVRMXn4jSz0OgNBY5Gsu/5EvVUv6bxlaWf6lgOl3ZHlB2r94bQ5x9+YlZzykR+TqDxLxf1+Q+1M9L6SfHe3PQICFNIlo6oCiz3O9HnwdXCgs7TyiJRmFQc4ehXfIKlH5Yfl7EsPNZ+zKF2oCQEbhtjfOlL7dCj1bdHdfvKtTL2sz//xMcb6m0fVh/slyQXsiIME9oRxOnhYLLLr7nNfgQILafMiDSp2TCTHSMwXdV1n2FTNICQMynUmmriqEd1Zimmivuoak4lxxHUFK+8JKBG0V6gG35ea3sxS3I3RDwF1J83x0D/qc+RMz2lfPS4v8inf0/6fxmK6nQjelt3VfiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XEDhe/YcaFNWtFa5mlIhtq1tl7msIAasVJli4k2Qn0g=; b=DpuR/xNKynR3Rq/zcKfuKYvcVvWVMiUsdKTigmPFBZRT18TmDa/y6O9z+vYjlEn71u/Yc2vX5Yby6P167AifIwulwq5yy89jQm1HVbhD7VZvGBw24c/tWK80bSK5Fl4DgiddkhV5QBWV4aXJyJfDvy+YZxJ7b1CECZddN2EugUG1IWwycAJ5qgqzs+sqMle1QwLM+gm+eha28qg3euy86PILeSPZ5FHottHJeg2x3VyClRAcAH7zaSrC/IJ27Kz3FAvFupn0f3dgARe0ZVK9VxN1IBbqg1F56S+kJVrqaYSUhPR6lORMbx6SzECU90cthpWR21f+4PoSobo5ez35hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 14:41:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD Content-Language: en-US To: Roger Pau Monne CC: Henry Wang , Community Manager , Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-4-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220503082650.23049-4-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0407.eurprd06.prod.outlook.com (2603:10a6:20b:461::14) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99161919-ee3d-4559-8e9d-08da2f5db2f2 X-MS-TrafficTypeDiagnostic: VI1PR04MB5133:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M49zq6c3NbYiSsamUOK5Ti22kcD1FDEjkdualovYWDi4H6DqemrbP8bzmES4CQ9X9nJoBWqIKENwEhaogt2vW8WJcugzjx9VBy8b+LeOseYshK+Ihsy1W8Jtg5K4uIvFFOcTja0JybadHzOdZfHZyLth30s0g7GreqKNAT6I/Q9PRh3yJQqjuCewS6xvQphBEnoZ9wu6NteKI2TkGVexL+bN4MaZ8hP8u32MRnaW2kl2ukeI4+Uz9sug4fi9Iq2b/XWpCy3fo+GEEQVIuNJCJBV9cmcGScY+1pZoK7aEX/J659HtEHxaTa6y8N9/gSI9vAJylAAPbSGOKBO9+S9CQ3mHg2YXP7oohzuz2NSDQCIO5qt/1StwHm/O6VLOp/Ox+2F+5J3MwVtY1zCVQDczDcIgoMXHzm04sqmIbEKsIQ8sTwxlVc1De7YnO06hyJ7npq0hpJKYkqmaDE0yEJ6ghxXNEqfRzzZM7xMzqW+04rmAyNT0xUyR4WSTXtuqFIz4ppIut/oMfwOWMUVI/nF1hio5bA916UU7wJYQA4KRoKzHJ3S8h25PSWjBJ09pBWKLkAQjOhZloWBY+hsnu7gVO13ju252as+f07RcdGra3Y3e5AP7q42ckr4ncvHP5PWVeUCsmKDkOFSh1TZN5+WChGC7U54nKA0ucxrXM3D4nCSBqpDKxDzVAiPktW5WV1B+jocqUg8kY3+SLcVaKSuyhRcTJ1wvT+2T/vdclX6efqk7i5W2F23YmilTyznsXe8E X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(31696002)(53546011)(86362001)(2906002)(8936002)(83380400001)(38100700002)(26005)(6486002)(508600001)(6512007)(54906003)(5660300002)(6916009)(2616005)(186003)(31686004)(36756003)(4326008)(8676002)(66476007)(66556008)(66946007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pMGGfb8Pa8Z5mDlQ7EKG3jIlEZeMXh2J+GRmSPkzP0EeFrjbtUjQtqsj2ivc?= =?us-ascii?Q?A9Ugxb3RXKe3NegQN0hOBQFZPYVC1YtHFnaS6eA8Yu3d7kQXuPJMKhE85P/Q?= =?us-ascii?Q?hCwVHiifnyVH5sNNtD1o92hRyePpiADWvzaIfyXx6jl8TxxmjoYCyefc3lCQ?= =?us-ascii?Q?MLPO9E5WGpdfFRlLXabUtkGhKUE3hSz0ZvtLxAlBBau6H5d0oxWkcN8VbYmU?= =?us-ascii?Q?dVdhlxrwa1WDl+K4uyGfPTADllJRd5jTZU7PxHDJFcp2U/SbuvPlLe/EngD/?= =?us-ascii?Q?0A7GoZdL4NkZJUARxEbqZ4fC2WYoCESPwaoYZV4OKKNzGP0YKVjOiP5WaOsU?= =?us-ascii?Q?LU7Pfst37TWRjhBmJY4KuWYZygdD5UezDS1bAT/ZdrPLSHMRjnwGGkPnANEH?= =?us-ascii?Q?e9XmFNPATWWvdXNU4ARwhJwPFKni3FgQ3vmWF07Lvs3D8K3YLdUtwWeRsFk4?= =?us-ascii?Q?FiqZHNekw0mRMnRRkcYFhMhOH3onQ2VXibXZBCz4xKObDKqvyMdVAAO2kL9J?= =?us-ascii?Q?94cf+MCDx5Pt+LEHFczS6Hvp2pdBpyXE7jskf2gJvCXXTyBWQ7dY18SC7kFM?= =?us-ascii?Q?ksF82pP414FzsJZK8BboLayhEcENDkU3tb7D5l3HagM5H7V3IC67/C8KNg6A?= =?us-ascii?Q?xj+LonHT52ze+99IdC7ad/S09a8GDBt8XhKN8cAqzqxcLbfJfgji8jhfxnWJ?= =?us-ascii?Q?HJjuRbwl5eTm5sUmE0qj7hndiQaxWXSaYOe4gkaKogEJN7IdQjMTMYft20Uh?= =?us-ascii?Q?kiiERwVUWSpJeHMJRS0VOsN6ts9LZQhT/Zo8cH0ulq7hqF+4xyGyciu6Niwf?= =?us-ascii?Q?mpzuu11UaPhZmfwcVJL3IVD27XXwhQQRDfmySXH+MhiTU8Nfl+w9oF77q8Bd?= =?us-ascii?Q?ncWd36PLS2yHu4uWqA8yIOYkCJ59JMNpJXZtel7Dd+d02PaHGYq6g0lYmDWw?= =?us-ascii?Q?i0WDE/k0dHJaqq2sClMsEwGfu661ZIN0N8GOlEGcAxHxLXQ02sV7R8laxnu3?= =?us-ascii?Q?1ZesNAcpIBvgQ8I+LnckZi8TDgev7bHz0BGsPGw28vWVH0xxHktz0p6+YZMY?= =?us-ascii?Q?gvx98RePTqz+EKaNmaeeLAu1pd+uB3RLQ2dz7CXVk+8dfHo2mXfWSySXz1w/?= =?us-ascii?Q?sUU0dyTCNIJwIhZfgPQi5WMaybL+uBpwWSfYIT5Xarvch3Z11aC+rR7PmwTg?= =?us-ascii?Q?kNApyVs/WYdGNa4ofWEqPwTW2ROmAM2Ndz/XEg9cD4QpcxnkpHqzxqiVhuDZ?= =?us-ascii?Q?N7UnVZ31td4T3tw5ArNnLA+xEz/wspXGRe/2B/NuoWlt+7WPzmaNwnyy+7y7?= =?us-ascii?Q?evNu6vPDc5YibLtsUZdctzicPhVQqwQ1GrCUiOXJk5fjFDC90M69JrbCIrXh?= =?us-ascii?Q?r8n9eKL2zl+uMPGQwJa0/qbZmvcfAlX2M8Fu6FPN3Dg92QGW5Pm8bgJP7fac?= =?us-ascii?Q?NvCSbQGOJFNoP37jkYwWYpepjLlD2qrImiD73LWO9LdQwpO7xuE/ONx3cOvY?= =?us-ascii?Q?B9hv0xUkEAnDw4PN4X6Uf6kN8EMO7unTBOKqmsNF2ZMPVmbIh0kE7a4DrQwO?= =?us-ascii?Q?sU4p/SvKciIHEJdS1jFPscPOx1xkXOL+ZW7IjVOhyIZS9xXyNVxGeyEwhSZR?= =?us-ascii?Q?htEy/aoi2b1Hwqm+DYMY80Ie7ITOVbwqSl0XeS6b+Ao5GSObDo9bP6kI74j1?= =?us-ascii?Q?lYV9yS7V8vvxIXwdaGRg+jBgeQC5xWWylNTWBZstkfygBK4NcrTX0yMwDk5d?= =?us-ascii?Q?dDFwbTZ1sA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99161919-ee3d-4559-8e9d-08da2f5db2f2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:41:10.8144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GAj5TgQmZLo30cyb1MtEe/wXa+n/TdN5tOGr2PpF2w6LXwzVDL503m7ViOlzVj3RYrh8wUIOjdAozSjxxxDYrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5133 On 03.05.2022 10:26, Roger Pau Monne wrote: > Expose VIRT_SSBD to guests if the hardware supports setting SSBD in > the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU > families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD > allows for an unified way of exposing SSBD support to guests on AMD > hardware that's compatible migration wise, regardless of what > underlying mechanism is used to set SSBD. >=20 > Note that on AMD Family 17h and Hygon Family 18h processors the value > of SSBD in LS_CFG is shared between threads on the same core, so > there's extra logic in order to synchronize the value and have SSBD > set as long as one of the threads in the core requires it to be set. > Such logic also requires extra storage for each thread state, which is > allocated at initialization time. >=20 > Do the context switching of the SSBD selection in LS_CFG between > hypervisor and guest in the same handler that's already used to switch > the value of VIRT_SPEC_CTRL. >=20 > Suggested-by: Andrew Cooper > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich with one nit: > +void amd_set_legacy_ssbd(bool enable) > +{ > + const struct cpuinfo_x86 *c =3D ¤t_cpu_data; > + struct ssbd_ls_cfg *status; > + > + if ((c->x86 !=3D 0x17 && c->x86 !=3D 0x18) || c->x86_num_siblings <=3D = 1) { > + set_legacy_ssbd(c, enable); > + return; > + } > + > + status =3D &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + > + c->cpu_core_id]; > + > + /* > + * Open code a very simple spinlock: this function is used with GIF=3D= =3D0 > + * and different IF values, so would trigger the checklock detector. > + * Instead of trying to workaround the detector, use a very simple lock > + * implementation: it's better to reduce the amount of code executed > + * with GIF=3D=3D0. > + */ > + while ( test_and_set_bool(status->locked) ) Nit: A bit of Xen style slipped into here. > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void) > =20 > if ( cpu_has_virt_ssbd ) > wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); > + else > + amd_set_legacy_ssbd(val); > } > =20 > /* Called with GIF=3D0. */ > @@ -3138,6 +3140,8 @@ void vmentry_virt_spec_ctrl(void) > =20 > if ( cpu_has_virt_ssbd ) > wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw= , 0); > + else > + amd_set_legacy_ssbd(!val); > } Aiui the adjustment suggested for patch 2 will not really get in the way of this, by only requiring to drop the ! . Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323082.544623 (Exim 4.92) (envelope-from ) id 1nmxHb-0002Pr-UC; Fri, 06 May 2022 12:42:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323082.544623; Fri, 06 May 2022 12:42:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxHb-0002Pk-RM; Fri, 06 May 2022 12:42:07 +0000 Received: by outflank-mailman (input) for mailman id 323082; Fri, 06 May 2022 12:42:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxHa-0002PZ-Ou; Fri, 06 May 2022 12:42:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxHa-0006Zs-NS; Fri, 06 May 2022 12:42:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxHa-0007ac-Gg; Fri, 06 May 2022 12:42:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nmxHa-00084E-GB; Fri, 06 May 2022 12:42:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o2B6n6ab4blHXQbbZf2dKl2PVEusiR1LfN5G4vGww2Y=; b=TgUqwaY0Jww6lf2cgqubksew6V MlgkTsThqgqar+DoN2pfAh6uY0yGKy+O41aZxnCQrSxkKKw9I6hY53AYq2y1zQ8VsRjla8DK7/sO4 640Au1Kti6G7au/ZStBYppkqJEuJkVapWcpXaWOLsti8Ov6vwvk5wc69glwZRwqkfakY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170182: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 12:42:06 +0000 flight 170182 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170182/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 841 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 12:45:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323089.544635 (Exim 4.92) (envelope-from ) id 1nmxKS-00037d-CV; Fri, 06 May 2022 12:45:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323089.544635; Fri, 06 May 2022 12:45:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxKS-00037W-9J; Fri, 06 May 2022 12:45:04 +0000 Received: by outflank-mailman (input) for mailman id 323089; Fri, 06 May 2022 12:45:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxKQ-00037M-Sj for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:45:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5828acf0-cd3a-11ec-a406-831a346695d4; Fri, 06 May 2022 14:45:01 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-4Hg4q188PRC2uyHj_v-nnQ-1; Fri, 06 May 2022 14:45:00 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5280.eurprd04.prod.outlook.com (2603:10a6:803:5f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 12:44:58 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 12:44:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5828acf0-cd3a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651841101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EK+DTPaAA1jcEZ7Zb2OAGNLR3RD4Q+rFnmNrccLNiDs=; b=D/eVi6MlVTI8ldKDl53/45pNgM3jWaMKByS0PEMnNcK7ctS7KRbYMCqNyR2dKZ0VCuk+// v4+c3osBZl2ELZL/VDCVeg/gb3BWnObst3aKl7PS+2MC/yNXomsifoeYuPShfItA9vQmcO j7Ec0gLbg2C33TTEpSBvUOkUoaBR5ts= X-MC-Unique: 4Hg4q188PRC2uyHj_v-nnQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=itkLwzLxbsA0b41PL98FUqFBnF3SQ2JrPIfikEEy/+OI8NpO1e/MqoK71V4L4PboT+WRrRObXXQiiM72ERt7Ivuuvv0EdVlxX8lLe2m5exd8LocGp11ugXbXlzbzuALm65NDYqR3skOr5Iy2LfPwtDWKzTYVqmtc4IPpAUvpsWPyugtsxImLo0XVQ0gUlb6UPZuAmCgsW1j2I5ME/uEpuhasCrrr4W+3OuvuVXJvekJqaT1wBAQ5lZ2CFJ1rLgUgbSxKZerplCUMH6eEi9270CLF9Nv6k+963ISXBbTdNzuuUUo5Q7yx5CMtgbi8e/tlTpLAwQIP/hnQvPLC1mFWJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0jWkRXuOmtKcjdq1XEADF1gapWmxABP1tVakRSYur6c=; b=fzXFCAbuI4miKpgNknJTut9hRgSteW6au0A4SSNlCaA4315I+oEtPXHmrUyNrrVYaZTZdlwZWu5DHvb95cFAEGRPmgCtjICn4OQ8Zny++Ub1iKwbfE6p6VAyc3k+Z/x9m7pDXrN38Dai6Ymzr7iZ8S8eVI8ZVV3rQMfc7oEjxjIg5vjYlOjiokbVGRsAQDu3aROkX1CeuND9ua1xUOsNk2G6VRoGMkFXXp+kdsLF8TWsWRJx8XAImOIPZcYbdEcqXTMOWaPJxJYoKOyt92I+/XIiTpsp+wnxyRBisdYXMQ1oGEbR0hRaaGq6bZoEQYnuEIPyVRrhQ1F3ix9/D3/5Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8e2b64f7-fda9-9a79-c809-cd3e92ffd356@suse.com> Date: Fri, 6 May 2022 14:44:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] MAINTAINERS: add myself as reviewer for IOMMU vendor independent code Content-Language: en-US From: Jan Beulich To: Roger Pau Monne CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505150454.51710-1-roger.pau@citrix.com> <20537ada-d3f5-56a9-8cb5-f274209c36e2@suse.com> In-Reply-To: <20537ada-d3f5-56a9-8cb5-f274209c36e2@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:20b:488::6) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16a6a45c-4070-4459-5a06-08da2f5e3a9b X-MS-TrafficTypeDiagnostic: VI1PR04MB5280:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h55Hn7QeVIOekEDUlZStKUkxrbae1UoMnW6u1N4tm7so0Ez3EOHtiamJBQ46YMBeu2337Nwk3+QZ8E9Wp4L3O/RYl3hU8XQs3VuudCa1CVRgF7gmvACJSrbXu2DpMvbkmNoazICDEIXDEW7uyHJiGDLyRDDegirNlFEHzSCBNhgK9B2Xe4J5sI0Z8m6uwDXaSZVGeWKPaeJFj+Ryrwt8y1mglOheoTvBTgChrbT/g94r85/QkQ9uKgqP4v1IIsrgv/1R9jgmIvYpgnmJTHQAL2Urj5soAJoqErgIbaWJ/q6crhc4ibE7Ml++FO/iqHq12Nuy3SC3++OHGoFsweFK4mLgTucLDl/GzmIox0SFyDIAHIpU9+FYNdC/zHWfrMiESykDy/qwlrwWwv8SrjPkpZxqb3qbTJlBFEzvBkgelC0dMErix9+F4glS4GxoXjtLtLgm7oz70lssA9CxrWBIV8vr8BaqozOPz+CC60nddaDWd/yN7UCchlg0mSnW59dePLYMqy+XFX5HveEEmK/zB+aNu4atxpTMygMuRZqJLpWP/mm1LE9pGbHxAGxblRWhA2BIkggYtr9eFZ/Xh42/mTDkFS3bxQAz1UyunU0sLDAnYmvS3obMHLFgCspzd/fskTpnCtVub3bm0fCDcL4BFRytdjZy0jMfTuUkAanMEUDyTh8yqEtru2kDGdIZKpvGEMEh5qm40kVwsm1531sU6mMgeY3w3oTkT9vdJHpZanA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(31696002)(6506007)(86362001)(2906002)(8936002)(4744005)(83380400001)(38100700002)(26005)(6486002)(508600001)(6512007)(5660300002)(54906003)(6916009)(2616005)(31686004)(186003)(8676002)(4326008)(66476007)(66556008)(36756003)(66946007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OULFxpeNx7jSp8p/NdN2CFNc+y63qXMvAzj4yYtnSR8t01lh8edbCHx2s5tj?= =?us-ascii?Q?XU/X6vMB5WvwNj3WrAIAN0ewuU7HsZ1edc3xFGvZ8D+8j1XD6FNPiwicu/BJ?= =?us-ascii?Q?fObmx9p/qEAFhd9OBzSRlbfEfinVQEbeLZhOH3UsG24NeQNnq7I7j+0/9Gph?= =?us-ascii?Q?sdGH60HVAdFgfovlVgkYSJSnTLZ8rXGAE92dsPmt47p1mVCE0+b4kwS60iYT?= =?us-ascii?Q?QD/8aq45avLyynsDQO0RvNEVUBTiPkY59NM+YTf+iwfn2DxD0TDhX8ivRAO/?= =?us-ascii?Q?7QWNZMJfxACy6MJhvTDrDj4joxWTJxMphZkgl8X3vHRvsvibPziQkTAJT2EW?= =?us-ascii?Q?pNThb1yQrnYKMSfh0220IuXw8Pkge/iKSaq4T0pZtSr3RM69RSJsIRrn2b3X?= =?us-ascii?Q?uWS7sWhHoiM18WheWe4dvvtwS15YOGvewUuxOEA90/YjBTe2Oeo552e9uE3n?= =?us-ascii?Q?YtD9ab4p6oTM/lPDUobTxVVI/vXxB76SAH4r0OxxsM9yQcsfGKScqF9ehJyh?= =?us-ascii?Q?GSJ8MlQn80QsWuaI17jQHfed508g03HXkWz8l53UmS2Tg7DjXW14rWRsF0hB?= =?us-ascii?Q?bJGWf5GGCK4jESzAxV8p7Df59KzxKP77e4kOA7gayfkTqidU8YSaKySLkuoP?= =?us-ascii?Q?hcnaIKTmYiy2JUSWgwSuIJRA5YlxM9cw5NBJet0KzXEwz6l/8qqlUhu9ajiQ?= =?us-ascii?Q?xWT1GnO9KXKPu00Vv5Zw9PuRDrmR54vblW3vtBL4ND8dGemhKEt5PPVgUMLs?= =?us-ascii?Q?4E0wRNLvhDBDg9Bfu2Fivm/NKtvxZxNqOclkh5OKqpd+MRS2wjYPL/a1mG9/?= =?us-ascii?Q?EdnHTRTmjMy+4c8X3/eUHkHbZRvX8cZJM1erL8pMl7TccljGkAh4HcxRwqz0?= =?us-ascii?Q?GY4fgPffunKklPF8R38gjC7/U1C6SQWATt71UCBggcdUsGZS0oXMvzGVwJO9?= =?us-ascii?Q?bHIpSkvBxKnwq4cex1JjUnVmylTT7ju0xMwG6vFwF8F7+Zqnod38jWLtTXVb?= =?us-ascii?Q?IgflVM1wCdFcGRJnXtAo045JYo56Ej3YnELvu1wBNZneJMl3n+aqwvezKgpH?= =?us-ascii?Q?M+ZnP7Pjy1IkZOWYhR6ErGGPv6v5c3RdbLMs3U2IwGlHnZG8M/OEJ0PbQgUq?= =?us-ascii?Q?ZHyRas5gwemlJqvs1ufIKSaiol5z4w4+Tips1Z7A9ra4shhm4LmMMVzbiLJ0?= =?us-ascii?Q?pnl78Ux+akog0SU1R/rzSxQwB0oxXyq+4iQBqSJ/rBF8tttU3qSaPPwgS7YR?= =?us-ascii?Q?OcjSm4oSaCYmfQpfPa01pxjsPPjtxUgjSFtIwROTsI1UPqke9UJzoLZhmX70?= =?us-ascii?Q?rbFv6ryRNLoXVmXOUyKBJflcygz9SdHzIKSTkRBP+8HUIubUw1prHBWXiNB6?= =?us-ascii?Q?suG6+zQHY0DU1B6uyoZRns2alVwOVqbp8ZbkzWK0ZQb4OVQvgtAmoAiD5kj9?= =?us-ascii?Q?vIvylXNHYSuaUKdtssg0V3Ae8RwXhD1mQEhg3um2KCWqPijkkcu8KgUDy3aa?= =?us-ascii?Q?kUp33dnDfHngvE121106SZSdYC8n2cJgoWEIPe3+duIneXVQvhPkxpaxsnDO?= =?us-ascii?Q?9VZBpgZRn14j18G7gK7G7MBI4zYnpbGeMOxRnuCAQER1jsJT5Xfo/DIoMVwD?= =?us-ascii?Q?COPP0NEo21gAItuG2X5y/FjxOnD1BW42BbqYIyHKSGZAvEHg+2sj1o4ZDlVd?= =?us-ascii?Q?5I0/4lwIpBQx2v31Dt8F1J5jnJlYbp/nm90sYr+IC0d3dyVuIEfEe/pm34n8?= =?us-ascii?Q?tDnOxNPKMA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16a6a45c-4070-4459-5a06-08da2f5e3a9b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:44:58.5380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BnkUEW/V3bQb9rQ0dmEwRz3rmv9SBwD4JDFPVNyqu6TEWjnq/qfyjiQLTouISrnz/WJwDoOArEXf8I8D6FtEtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5280 On 05.05.2022 17:15, Jan Beulich wrote: > On 05.05.2022 17:04, Roger Pau Monne wrote: >> That also covers the PCI bits which I'm interested on. >> >> Signed-off-by: Roger Pau Monn=C3=A9 >=20 > Acked-by: Jan Beulich >=20 > And thanks for volunteering. Or should I have said thanks for formalizing what you have already been doing to quite some extent ... Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:57:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:57:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323100.544654 (Exim 4.92) (envelope-from ) id 1nmxW5-0004t5-NA; Fri, 06 May 2022 12:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323100.544654; Fri, 06 May 2022 12:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxW5-0004sy-KF; Fri, 06 May 2022 12:57:05 +0000 Received: by outflank-mailman (input) for mailman id 323100; Fri, 06 May 2022 12:57:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxW4-0004sq-Aq for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:57:04 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 067e826b-cd3c-11ec-a406-831a346695d4; Fri, 06 May 2022 14:57:03 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2170.outbound.protection.outlook.com [104.47.51.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-gjcIu7mENb2ZEDPuPAKvKg-1; Fri, 06 May 2022 14:57:01 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by VI1PR04MB5472.eurprd04.prod.outlook.com (2603:10a6:803:d3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 12:56:58 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 12:56:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 067e826b-cd3c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651841823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ArrKCQKNcUdBZ27Feomc/vyeJEr4bMub3Aov7mlP2Y=; b=kidclYY3LBx59VANqhzuW2Qq3HbsWsjAN+1eMJmGAS4M+tOl63rs2OYs6bKZTHVy2P+XNC chidgelTTo8f4F/AOjp9pTQjsW9WMDLBmYl/XMJyVdMaQv5RrUYBe1a4P/vsxONuKb82b0 Sog3pJrneuf+S0TCjJmgylaVQazZ3gA= X-MC-Unique: gjcIu7mENb2ZEDPuPAKvKg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ka/qHkLopxGc6dxEzxiZVlJCO944mKaiM8Yhe3NDs1wcYroKPaC6Sg34uJ6y040fnVwbhO+Xh/McJPG3KGrMYPFUxivWISajr49UjrlmR9ADIPFrmRPxuf9fFjKOquhJsbEUEZ/wNuKUyeJSTuFhBwjIh0n0Est89X7UB8hpj0iIwBoCDb+km/ESDxCcjEt3ZV7o5Ju1NqwZpTzB/6OXyRBnTKo5e9tfq4T1FfkjyPP+GvvlN9D2rlrkUThJxIgJ+OQkKGe6mZCuwtR8C/L4PjsQ0QXkOo64TvCyt2TpCSzgBkaY+TST6GnYkD/CNsrrKs78i+DgY91PLorwFWAU3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ArrKCQKNcUdBZ27Feomc/vyeJEr4bMub3Aov7mlP2Y=; b=i9HrbU+0lmpY7ox5jTgYkVYlj/hHJZ61axuqCsKXhecc/EIryXb231eZafLxMa5lZfRRDXfzyC9McEWvaN/CiA5OwDkb0nIDjDowXTE4dX/7N2mY2abJOd+G5YmTXOawk1eQs72e8t4r7fGSh+MrRoPjhJavsfYzFaxp2DmK0xUnI4bHCwxEIukPNrgDWQaKD1zbxGsexc318NlfC0u958DJT9Z9BdKqADUOLekxbhd1PffCoBucqWu9fa4nqlM4HgcbhP/xH7NxdpW9izdtzP8Qc1JpIxrWKOMFA3bQJM5O8QzARw8k4GWIwSukdnT1BjDGDiNLQXLnMaIplt2WSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 14:56:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505142137.51306-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220505142137.51306-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0264.eurprd06.prod.outlook.com (2603:10a6:20b:45f::9) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34229bd9-331a-4000-ee32-08da2f5fe76e X-MS-TrafficTypeDiagnostic: VI1PR04MB5472:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R8PPl3yLJ1oIb3uRcjnaDGI/wAU4Rnw5byimNyysm7Rx8ypEVmLWDZI68ZghCrsPgvcU5kupZwXxToYzt56bbOWQgvdajSVOI+fTYlrAzAGdPpSwRj7ZmY8tToSWIcXyI2u4ZkkiUZ4wgW9yzREganRKj8+cLoiZ5n0JqIE7dwtnSk0ks4VDO10NQvyRxzpE+BvZVbECK9JRlbonhm46Ydc/sEFBO30Ixwau/CDDhjm8v3ng+wrjE6fJ5w1ZuJ/5gK+UINitmH+r/T5J0icYbxOFwHVUr9LntGFBDHi+XDGm0+qg4ZqgfoNr0Tft0GooCCgQP8h8wb3HcL+3/F8UH9NQ7h5IdUF/SDu7rLnUvBxut4fTneToA176Oe3Ly60mvJGNwiZ5aTiaDLzRJK1xdUbXwKKPpA3d4jCD8U9dfHRKYmSybDY31VAmChNIiBUoP0VH170NWP6XgpKq3BikM4i93g5P5F6yhtm5Ck48xM2/UTzAQVTo0pr/vA+kOS/KsBp/1B2CEhvxpZWzhI4oOyU1EG0Z6PEVve/2zhekllNOntKdtVQR3LGK5Iw6ehPkga5AEcz5KnRvt+TpfSfzGZI0o47+Mud5R86+XYdRXodaFDEhAS+9n758EWhlH0W4K/zkG0q7C2VxOliVXDuA06IVKuLxv63rjHe5suZouevUB3GbBttycqBd3BbPIMkhuU/cchYrFUUJ6XnMuzpar1epRyO4Aiw3+wgm/+87J/w1szgC8PsV/037HZ3NT5N5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(6512007)(6486002)(54906003)(6916009)(26005)(31686004)(5660300002)(316002)(38100700002)(36756003)(508600001)(2906002)(6506007)(53546011)(8936002)(2616005)(31696002)(4744005)(66476007)(4326008)(66556008)(66946007)(186003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1l1T29oSlRISXVPa1hJeEc0bi9kOXVNc0psZFpiWFVsV2pYRkhPeFAxN2hz?= =?utf-8?B?c1YxcldKbVZ5Q2VXSlByNjVZWENNZ2hyL25jUFZPbEpzRkh3TmdnSEwrQ0dE?= =?utf-8?B?N0xhTUdFbXNja2Uyemg3dm1JV3Z2Yk1JKzhUOVRnbEJpR3FKNStFRjg0Nnhv?= =?utf-8?B?VmJ3N0VTamZEcVJIUDhEY1Nhc0ZJSXlpTnFsQjB1bjRZRy9RM3hjalVXa2c5?= =?utf-8?B?MGk5TlB1MXk3K091ejVOSTVoQWxZTi9WWTRDYWdTL2FvZVNoUzJ2VzJEaVcr?= =?utf-8?B?S2xlUDRhbElkMDZNME12bjdmWGplYUdFWCtJcklXUmNubllUZW5MeXVhYnRZ?= =?utf-8?B?c1hKdlF0SkpmTDE0QTR4WUZYaFREYXRVZGk3bE94UHF0NmFNNEl4OEhickFM?= =?utf-8?B?ZFBla01tbnQrUVJoTGUzTXN4ajJCNnBlTEZ3QkJ5WmFnLzZIOE9iaFdWSGNS?= =?utf-8?B?eUtDRjBWSldtUko5Qi9sY3RiemVYUlRTT0c5Qm1HSXJZZFFtZWFja3lxMXo3?= =?utf-8?B?N1FBT0NSSFNJZDR1QVpJOHRsOHNmaStBNC9YQkEvWVo4cGhlbGVNY3BCanJ0?= =?utf-8?B?MERETjQrVE5xOHR1Nm5KTzJVcFFqaHZUTmpKTWVSY3gzSzVhYmZPY01hT3Mx?= =?utf-8?B?cW95dU1xNDMyR1ErMThmMTFQUHNjZXE4NE0yUWlXeWJwK2ZRTGYrZmRwUW1V?= =?utf-8?B?cFpBNzF5M2VJRURSeU9sQktudVg0REtvWFRhV1dMamtxWU8rSVBidDFIelFp?= =?utf-8?B?ejFqT3B1NTZRamw5eGpsOGplU3JYNloyR1NMczhUSEplSU1SZ0NUS0xnR3NJ?= =?utf-8?B?SGJYMUZLNkI4TmVGUTRqSTRVTjIvTm9DZGtvRFlJSnZoSVhqdjViWlNoV2NF?= =?utf-8?B?dmlnZTZaMUNTekM5ZytxTk9vUGpjU2ZoM3paZElQTVZRWG0wWk5HU0VqR2RP?= =?utf-8?B?elEvZUhDUHVNbEpjRU9OTWNyTWlOenlMUHJDc2xoVmxsbEpUNU5YdEVReVk0?= =?utf-8?B?VENNcjZHY2hCOHZpNm4yYXNlWmcxamFMMVB3YVp6YjBNRUI1WXZvWGI2Nk8y?= =?utf-8?B?VC9OVDRkVGcvd3IzNzZLWVg0ajFDOG1jMXVPZzRkNHFGL1dsaDZFR0dEQXYw?= =?utf-8?B?VUR2NXNPZkRKdkdYSHdZVUY3VkRSMHNaUWwyRXVUeEJRaG9saDVidmRzZTV1?= =?utf-8?B?c0ZvUlpiTXpScnVSOTgxUG9pK2ttVzBCaFMzeWlEOHpERXUvWWlNdmQ5ODdv?= =?utf-8?B?VW9TamVsR2RjVVlUbUxFZnllbDBxejM0ZmNlQ2huS3FtSVo1QlI5VzM5UzN5?= =?utf-8?B?Qm9XamhwaVg3dnJwVnVxRzFyNzk3aDEzQ3EyT1Y0TnVRcTNLQlZ6ejZGQmR0?= =?utf-8?B?ZFIySG5JSjdmQlF3RG9LRUZRRTB1aGlaZGhjME9Sb1IvV3VBaU01ZmhsV1hH?= =?utf-8?B?WkdiZGRSQ1dRWTJLTEZGMVhQVkk0UnZDcWVmV0xzbFR0WFBTTWQ1amgzcVNy?= =?utf-8?B?VXFXY0w4cHExWGNMMDhmV3FWemV5Um1UdTBxbCtCbEhSNFdFcmpEbCtvTkFT?= =?utf-8?B?eU1qRjVpUGttdm5CQmh5c0gySWlCOEpqTDZWa0piWlRYWXNCeGZ3YWt6NllW?= =?utf-8?B?S2kwdWdpMUFncDhNYzlrUFZNRFNsejB3TUVab0Y5L0kxY2FnUm9HZDE2R1pz?= =?utf-8?B?S0NFV0RpYzN0VTBoRitSVTAxSjJSWFcvaVo0UnpQZVJSU2l5TmZOZElIbmM2?= =?utf-8?B?V2hxOWVGYVlFWVJSVmZ2dHhoUk5zSXo0V3FOK3FsemZ0OUJOVExGNjlFU2hv?= =?utf-8?B?cy9WRmFCdUNrVHhCazE1YlZRSDlzSU0rcVlRMFdEdlp6amY0OExYU0loOE1C?= =?utf-8?B?M01SZlJYRGJhMDVxRzEvaWEwVFUxTnFEMVByRmdoWmJPZTUxMFhQU1oxeUNI?= =?utf-8?B?bWdrMFYreVRpekxGR2lXTStDZGZtSzZ6TVhVZFFhZ2tzV0FBWkJvMHdFb1dl?= =?utf-8?B?NTFncmgxV1diRDRWOW1wMHNZaW80MlpnRldYRlorMUIvWmdWQ1VQT0lERGpl?= =?utf-8?B?QjhHS1VjS0lpTG9yUUxVNkdhT3I4QksyeS9nQm9sanZycFJOcG45SG94NHox?= =?utf-8?B?RWVzOXNJeVRBV2lYOWRvc2wxTlhFMkhRNzRwT3FWSjBhWjVlYkRtU21FcFdI?= =?utf-8?B?dGliaSttRlBSMEc1QTlxY3poamdhRTVuUW9DcFR5MkI0aG1GWkswbFlCMFhL?= =?utf-8?B?VnhVQnA5UU9XWk5CS3lOZ2kvOHc3Z3kzMVZBa3RhMllETG5vRmxYQmI3OVNV?= =?utf-8?B?VTAyUGJoQjBJOUtQZ3p5Q0R0NlN1K1pFd3dhVHFBTUtiUWNnc3lnZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34229bd9-331a-4000-ee32-08da2f5fe76e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:56:58.3800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BAbSxLge2S4YJ8ovBj1zjYJTq931e+38SFwdT+XZzM8XIN96XMaOPs7fKFeUtple2jsQrzWVNreiaqvTYf+rKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5472 On 05.05.2022 16:21, Roger Pau Monne wrote: > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -125,10 +125,11 @@ > #define __must_be_array(a) \ > BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > > -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE > -/* Results in more efficient PIC code (no indirections through GOT or PLT). */ > -#pragma GCC visibility push(hidden) > -#endif > +/* > + * Results in more efficient PIC code (no indirections through GOT or PLT) > + * and is also required by some of the assembly constructs. > + */ > +#pragma GCC visibility push(protected) > > /* Make the optimizer believe the variable can be manipulated arbitrarily. */ > #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) This has failed my pre-push build test, with massive amounts of errors about asm() constraints in the alternative call infrastructure. This was with gcc 11.3.0. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 12:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323101.544665 (Exim 4.92) (envelope-from ) id 1nmxWM-0005E3-0Q; Fri, 06 May 2022 12:57:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323101.544665; Fri, 06 May 2022 12:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxWL-0005Dt-TZ; Fri, 06 May 2022 12:57:21 +0000 Received: by outflank-mailman (input) for mailman id 323101; Fri, 06 May 2022 12:57:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxWK-0005DL-BW for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:57:20 +0000 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e8e753d-cd3c-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 14:57:17 +0200 (CEST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 246Bhqsi032725; Fri, 6 May 2022 12:57:05 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fw3279f16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 May 2022 12:57:05 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 246C6GE1009740; Fri, 6 May 2022 12:57:04 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3fw3279f0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 May 2022 12:57:04 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 246CrK4Z028206; Fri, 6 May 2022 12:57:02 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 3ftp7fwgbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 May 2022 12:57:02 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 246Cv0dI39256422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 May 2022 12:57:00 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F2900A4053; Fri, 6 May 2022 12:56:59 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1CD1EA4040; Fri, 6 May 2022 12:56:59 +0000 (GMT) Received: from [9.145.54.141] (unknown [9.145.54.141]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 6 May 2022 12:56:59 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e8e753d-cd3c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=evV7zW0Pkptdgxryp8q/nhaiY9RbM7s7Y7FBYLM1+3A=; b=Jpd/LqQ8qRyc1xkIsreNzVu3YNJxk4TaXrlRk5EXzrQXl5UeIjcnnMKpZQPsVJ0GWk+H 4OO+eKdI0ysFLbuy272CQquw7xLwkRQ1s5GUWbXY8kFuS71Ceev4HZ45AsEQ8oZBvzjh vj9ZT2cWF915zG+QEbX57A1GZjGTBqhBXVby9LhxAVMXfdHc8D2HNV+6fPiIWZDjoX8J xQc3nUSMfgk+A0yFcqxH7BuTTwMYt5urI5Cc5SR3b708MtZCLHe7iDRxY/w+5R6s+qyZ 89+99+cfayWa/722v5Fz4JyhE/P1cqJ/2euDxDC5GLt/zC7591d5SNeke9efRBlC4wae 9g== Message-ID: <1f26f6b4-4d33-6291-31c2-5cb68a5be829@linux.ibm.com> Date: Fri, 6 May 2022 14:56:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 07/11] dasd: don't set the discard_alignment queue limit Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Johannes Berg , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Mike Snitzer , Song Liu , Stefan Haberland , "Martin K. Petersen" , linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, dm-devel@redhat.com References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-8-hch@lst.de> From: =?UTF-8?Q?Jan_H=c3=b6ppner?= In-Reply-To: <20220418045314.360785-8-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8a7-K9CSYxb93olkIOkZv_aoAnTW7JGG X-Proofpoint-GUID: eBrk8yaxusH63MjrlJz40h5tJPgmJePg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-06_04,2022-05-06_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205060070 On 18/04/2022 06:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to PAGE_SIZE while the discard granularity is the block size > that is smaller or the same as PAGE_SIZE as done by dasd is mostly > harmless but also useless. > > Signed-off-by: Christoph Hellwig Acked-by: Jan Höppner Sorry for a rather late answer. I saw that Jens already applied the patches so it's fine when the Ack isn't added anymore. Wanted to send it anyway so that you know we're aware of it. > --- > drivers/s390/block/dasd_fba.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c > index 8bd5665db9198..60be7f7bf2d16 100644 > --- a/drivers/s390/block/dasd_fba.c > +++ b/drivers/s390/block/dasd_fba.c > @@ -782,7 +782,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block) > blk_queue_segment_boundary(q, PAGE_SIZE - 1); > > q->limits.discard_granularity = logical_block_size; > - q->limits.discard_alignment = PAGE_SIZE; > > /* Calculate max_discard_sectors and make it PAGE aligned */ > max_bytes = USHRT_MAX * logical_block_size; From xen-devel-bounces@lists.xenproject.org Fri May 06 12:58:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 12:58:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323112.544675 (Exim 4.92) (envelope-from ) id 1nmxXh-00060e-AZ; Fri, 06 May 2022 12:58:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323112.544675; Fri, 06 May 2022 12:58:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxXh-00060X-7b; Fri, 06 May 2022 12:58:45 +0000 Received: by outflank-mailman (input) for mailman id 323112; Fri, 06 May 2022 12:58:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxXf-00060R-NY for xen-devel@lists.xenproject.org; Fri, 06 May 2022 12:58:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41ad5f8c-cd3c-11ec-a406-831a346695d4; Fri, 06 May 2022 14:58:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D2DC21A74; Fri, 6 May 2022 12:58:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C8F6F13AA2; Fri, 6 May 2022 12:58:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UIlBL4EbdWKERQAAMHmgww (envelope-from ); Fri, 06 May 2022 12:58:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41ad5f8c-cd3c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651841922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AIK5gDkSxMABdACCbZYluPBFGhfe0mpNG0zAK0prmZ8=; b=IPuote7ktH4WQ3z4STjwe9xfyNEiot1BRYOhYJIUBLJyYJwfxLxb93HO+aDsVSxE/oGbIB 4a7CZHCWL1U7cJDXh8pHLGp70MO4tpoWLH9cORzXdUYy0jTzeMweNmbcPqee+Xs6Ko+myQ SzhwkyD96F9sRtbug7x74HUPFLABlv8= Message-ID: Date: Fri, 6 May 2022 14:58:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Dario Faggioli References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-5-luca.fancellu@arm.com> From: Juergen Gross In-Reply-To: <20220506120012.32326-5-luca.fancellu@arm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------u4WzxrSPY02h22m91YWuwaqp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------u4WzxrSPY02h22m91YWuwaqp Content-Type: multipart/mixed; boundary="------------WsFafX1VRqWSUJPv08TX00rt"; protected-headers="v1" From: Juergen Gross To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Dario Faggioli Message-ID: Subject: Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-5-luca.fancellu@arm.com> In-Reply-To: <20220506120012.32326-5-luca.fancellu@arm.com> --------------WsFafX1VRqWSUJPv08TX00rt Content-Type: multipart/mixed; boundary="------------eMOXUorfrTiu2rWhSQJnK7Fs" --------------eMOXUorfrTiu2rWhSQJnK7Fs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDUuMjIgMTQ6MDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEludHJvZHVjZSBh IHdheSB0byBjcmVhdGUgZGlmZmVyZW50IGNwdXBvb2xzIGF0IGJvb3QgdGltZSwgdGhpcyBp cw0KPiBwYXJ0aWN1bGFybHkgdXNlZnVsIG9uIEFSTSBiaWcuTElUVExFIHN5c3RlbSB3aGVy ZSB0aGVyZSBtaWdodCBiZSB0aGUNCj4gbmVlZCB0byBoYXZlIGRpZmZlcmVudCBjcHVwb29s cyBmb3IgZWFjaCB0eXBlIG9mIGNvcmUsIGJ1dCBhbHNvDQo+IHN5c3RlbXMgdXNpbmcgTlVN QSBjYW4gaGF2ZSBkaWZmZXJlbnQgY3B1IHBvb2xzIGZvciBlYWNoIG5vZGUuDQo+IA0KPiBU aGUgZmVhdHVyZSBvbiBhcm0gcmVsaWVzIG9uIGEgc3BlY2lmaWNhdGlvbiBvZiB0aGUgY3B1 cG9vbHMgZnJvbSB0aGUNCj4gZGV2aWNlIHRyZWUgdG8gYnVpbGQgcG9vbHMgYW5kIGFzc2ln biBjcHVzIHRvIHRoZW0uDQo+IA0KPiBBQ1BJIGlzIG5vdCBzdXBwb3J0ZWQgZm9yIHRoaXMg ZmVhdHVyZS4NCj4gDQo+IFdpdGggdGhpcyBwYXRjaCwgY3B1cG9vbDAgY2FuIG5vdyBoYXZl IGxlc3MgY3B1cyB0aGFuIHRoZSBudW1iZXIgb2YNCj4gb25saW5lIG9uZXMsIHNvIHVwZGF0 ZSB0aGUgZGVmYXVsdCBjYXNlIGZvciBvcHRfZG9tMF9tYXhfdmNwdXMuDQo+IA0KPiBEb2N1 bWVudGF0aW9uIGlzIGNyZWF0ZWQgdG8gZXhwbGFpbiB0aGUgZmVhdHVyZS4NCj4gDQo+IFNp Z25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4g UmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y Zz4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4gIyBu b24tYXJtIHBhcnRzDQoNCg0KSnVlcmdlbg0K --------------eMOXUorfrTiu2rWhSQJnK7Fs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------eMOXUorfrTiu2rWhSQJnK7Fs-- --------------WsFafX1VRqWSUJPv08TX00rt-- --------------u4WzxrSPY02h22m91YWuwaqp Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ1G4EFAwAAAAAACgkQsN6d1ii/Ey95 JwgAnxk9mU5Rerf2cY3oTfRO2uouUNSrmkcXSqje1bDZ05N5+/hs47pBptaPiiApHabSguU8LLdK z6reBjb+MrAy8FcHKHMFDaKWRSeXotmBrlHhH4ww2q+c7BLhHCmTiIPlOTvHd1xmZwy48FwprjgT FQB57nqH1WX0dX+GbM+7HW5Pe/H4X2U6MpRV1vmYR5Auvd0r/hPl/HZRZV5pP0XsDXI8TMkdzpS8 c/d83clxL2Pw+oTHyF1fZ85O4iwgoIobehe3hvhLD4/UQRFYrB04dYE/D0SXr+ZXUPXIzlRi0njo Qb/iV759LK52eHX0QKy+g12nL8ilvQ2hZ6pNcLPUkw== =wo1l -----END PGP SIGNATURE----- --------------u4WzxrSPY02h22m91YWuwaqp-- From xen-devel-bounces@lists.xenproject.org Fri May 06 13:06:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323119.544687 (Exim 4.92) (envelope-from ) id 1nmxfE-0007bs-3J; Fri, 06 May 2022 13:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323119.544687; Fri, 06 May 2022 13:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxfE-0007bl-0V; Fri, 06 May 2022 13:06:32 +0000 Received: by outflank-mailman (input) for mailman id 323119; Fri, 06 May 2022 13:06:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxfC-0007bf-NH for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:06:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57ed45e1-cd3d-11ec-a406-831a346695d4; Fri, 06 May 2022 15:06:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF4071F913; Fri, 6 May 2022 13:06:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74F2613AA2; Fri, 6 May 2022 13:06:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WOkYG1QddWKfSQAAMHmgww (envelope-from ); Fri, 06 May 2022 13:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57ed45e1-cd3d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651842388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6a9ZGw0GY6RgYYmGitejl7H5z66xjohimuOWf1P2y4c=; b=elpjT74/11ktSiW19gH3WTt0nNVRkPnxhL218+BdGSnO9jO7mtjjdPhGkU7bPWFQNFni52 6/fOzwoK1secXr127UYSKkwN7cBBEeec+FGNaZakF9WVVGuOywuliD6Q3j2YAkvheZIxT1 08eUS9ZFuEflDisbj8DnFIU6LiKqIWE= Message-ID: <7792f3f2-51ef-640f-136c-97df51113ee6@suse.com> Date: Fri, 6 May 2022 15:06:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Dario Faggioli References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> From: Juergen Gross In-Reply-To: <20220506120012.32326-7-luca.fancellu@arm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------60G66dl5FzFFVRBRis0l7p2A" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------60G66dl5FzFFVRBRis0l7p2A Content-Type: multipart/mixed; boundary="------------0FAWCLdQUfBDrA0eLhIpvXZ7"; protected-headers="v1" From: Juergen Gross To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Dario Faggioli Message-ID: <7792f3f2-51ef-640f-136c-97df51113ee6@suse.com> Subject: Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> In-Reply-To: <20220506120012.32326-7-luca.fancellu@arm.com> --------------0FAWCLdQUfBDrA0eLhIpvXZ7 Content-Type: multipart/mixed; boundary="------------yLkwVEA90wjCuHO03vSQQAP6" --------------yLkwVEA90wjCuHO03vSQQAP6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDUuMjIgMTQ6MDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IEludHJvZHVjZSBk b21haW4tY3B1cG9vbCBwcm9wZXJ0eSBvZiBhIHhlbixkb21haW4gZGV2aWNlIHRyZWUgbm9k ZSwNCj4gdGhhdCBzcGVjaWZpZXMgdGhlIGNwdXBvb2wgZGV2aWNlIHRyZWUgaGFuZGxlIG9m IGEgeGVuLGNwdXBvb2wgbm9kZQ0KPiB0aGF0IGlkZW50aWZpZXMgYSBjcHVwb29sIGNyZWF0 ZWQgYXQgYm9vdCB0aW1lIHdoZXJlIHRoZSBndWVzdCB3aWxsDQo+IGJlIGFzc2lnbmVkIG9u IGNyZWF0aW9uLg0KPiANCj4gQWRkIG1lbWJlciB0byB0aGUgeGVuX2RvbWN0bF9jcmVhdGVk b21haW4gcHVibGljIGludGVyZmFjZSBzbyB0aGUNCj4gWEVOX0RPTUNUTF9JTlRFUkZBQ0Vf VkVSU0lPTiB2ZXJzaW9uIGlzIGJ1bXBlZC4NCj4gDQo+IEFkZCBwdWJsaWMgZnVuY3Rpb24g dG8gcmV0cmlldmUgYSBwb29sIGlkIGZyb20gdGhlIGRldmljZSB0cmVlDQo+IGNwdXBvb2wg bm9kZS4NCj4gDQo+IFVwZGF0ZSBkb2N1bWVudGF0aW9uIGFib3V0IHRoZSBwcm9wZXJ0eS4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJt LmNvbT4NCj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlA a2VybmVsLm9yZz4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNl LmNvbT4gIyBub24tYXJtIHBhcnRzDQoNCg0KSnVlcmdlbg0K --------------yLkwVEA90wjCuHO03vSQQAP6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------yLkwVEA90wjCuHO03vSQQAP6-- --------------0FAWCLdQUfBDrA0eLhIpvXZ7-- --------------60G66dl5FzFFVRBRis0l7p2A Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ1HVQFAwAAAAAACgkQsN6d1ii/Ey9I +wf/YfbGp0xREQSj+DhZycOfMeWZFc6y0zj+Jjt2TOq/MV1KPNgEJOkvKAoQO4ZgArRtBA2OvKR2 StrfrhRMdj0IEqu8GVs8NJjmh/XXksg5jL124xBMZ1003y3s0RUP15eeoXbA001YcyL8r6IH1lTW meOgru3cksTQ8agnfB0zhjmVH3/d//hDFKra0mxYE8OtzTyvoDb9MrHzuisu+/Hn2VUS3EMmfu0m fQ7gDCsIBuX2fgbDwVfg92/QsdnpELdYYta6tN4JyvotqV1PhD4cFxHS3jrgH+iLA842NuJGJ6yx /vhCRxMXALn+YJBvVUel6FbxGIDlmwY4VJSIAU4iKQ== =D6M4 -----END PGP SIGNATURE----- --------------60G66dl5FzFFVRBRis0l7p2A-- From xen-devel-bounces@lists.xenproject.org Fri May 06 13:26:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323127.544698 (Exim 4.92) (envelope-from ) id 1nmxyC-0001mB-RU; Fri, 06 May 2022 13:26:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323127.544698; Fri, 06 May 2022 13:26:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxyC-0001m4-OV; Fri, 06 May 2022 13:26:08 +0000 Received: by outflank-mailman (input) for mailman id 323127; Fri, 06 May 2022 13:26:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmxyB-0001ly-GA for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:26:07 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 14011e30-cd40-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 15:26:05 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 09:26:02 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MW4PR03MB6668.namprd03.prod.outlook.com (2603:10b6:303:123::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Fri, 6 May 2022 13:25:59 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 13:25:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14011e30-cd40-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651843565; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6O4CAnYwv9/djAWOzx4n9NDXRVzdkRxyrdTNyMCykpQ=; b=SIh3rYwEiG/qmwv6MRp7ZthEcPxc8h1miEtDkwbPEbVqlpH4Lrvy0Id6 cIxCWjEcy8BxsadLFhwZW3zPfMXiO3/6XHfgs8VmHwRx4YumjDm2AI1+V MWayOShGRoHX8UElQ/AHmbjBPh+mvOF3MCfQLADuiwPuOYdCShcC9DWi0 M=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 70735659 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tQsa3a2GSaHLeBRA5PbD5alwkn2cJEfYwER7XKvMYLTBsI5bpzZTm zBJDTjXOvfeY2HwKosgYYW+8BtT7cPcxoVgTwM+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw34Dga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0O6r2wVl4PEJfu2/k/cDx+OQR/HZx/reqvzXiX6aR/zmXgWl61mbBCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82SBfyVube03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrianLGYF9g/EzUYxy2fZliJw25bxCcGLRdOgBsdexkm6+ H2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM/JPF8Uq5QfLzbDbizt1HUABRz9FLdAj6sk/QGVw0 kfTxoy1QztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:DPIzDKDZbZ0RreDlHej0sseALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+U0ssQIb6Kq90ci7MD7hHPtOgLX5Uo3SJTUO1FHYTr2KjrGSjwEIeReOjtK1vJ 0IG8MVZb2AbmSS5vyKhDVQZuxQpuVvh5rY4ts2oU0dKD1CWuVF1UNUGwybGkp5SE1tHpwiDq eR4cJBun6JZWkXRt7TPAhLY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJ0x6s4+2 StqX222kzjiYD79vbv7R6R031koqqi9jKFPr3ItiEhEESttu9vXvUkZ1TNhkFznAjl0idWrD CFmWZdAy000QKWQoj9m2qS5yDwlDkp8HPs0lmenD/qptH4XiszD45biZteaQax0TtpgDjS6t M444u1jesgMfr7plW12zEIbWAeqmOk5X451eIDhX1WVoUTLLdXsIwE5UtQVJMNBjjz5owrGP RnSJi03ocdTXqKK3TC+mV/yt2lWXo+Wh+AX0gZo8SQlzxbhmpwwUcUzNEW2n0A6JU+QZ9Z4P msCNUiqJheCssNKa5tDuYIRsW6TmTLXBLXKWqXZU/qEakWUki93KLf8fEw/qWnaZYIxJw9lN DKWFZVsmM7YAb1BdaP0IcO8hfWXW27Vzioysw23ekJhlQ9fsueDcSuciFcryL7mYRhPiTyYY fCBK5r X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70735659" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BIpGKkLojpeMOsI+/KTWkKuK6nj4CPvPJBO5v0/MXr+hAllNYuYBjCHpTtXzUwvaZS249sw3eN3HHI+cgFEuuWPOJi1mbFQZ6T73Qx0/FoVByICx7mm6rejZp2Hr/QG5GFx4ti1QnpRoZkSlvXkZ/oLU9570iitIzwJ7XumSDQVBkYhRKBV8CyuJ08S+lXNYUIQF9BiI5p3WXMW57SW/bNS4IIH5QvTssR8dm4+Gg7YiNVd11fD1MDnjBT0UqBab3+U5ZGrQYVBwqpsE9dbtMNsOy2zwituLrVGzesf0qKpL8iv8O3GazmySwIZRV9F6Az7xgcaQtxgzG07XYh30Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0zNji4fmI6m8Qd0nVtMxOFicFEkdsmHD2NrHiaWTF4=; b=aFzFvM2nPAARL0/Df77scVcCG/ywaDPhuI5kBhE1Rl67ZSfGaEl7BX1vJUGUARYepHPYNfbby+AIs+a7xKrTZJZtrvwzCGLtZen7kg2Dbd7licmDyYmc0UkTMK0zrIOAZyhduqgw/JXfXfHul6g6TQ++D3qp7odMp5knPN1lYrAi5P/785dnJtEtBmoHRcIHL3htO7G6SRhpGShURmjXwW32q/riZY6hVj9CyVMLqEl9sdXhbNj9LPNSq0v0HlUOwh5bWhVSQNZECKMzXQyNVvD0rkb8vOo6NfrdXaLbvVn5j96ECW7NEqZB+F3Grg3SIyq7Th6kTc67GPoXTnlKNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0zNji4fmI6m8Qd0nVtMxOFicFEkdsmHD2NrHiaWTF4=; b=e8J2aoSP/DTJoaPZHvqd9bl06qHUToL92sNvaxz6r6OjCUw1C7C7e+3EKPbKYLQRAwzoAXB3NvLk2xRX08j4TxhnQfsYtQ/8HP8BzGWjzZvlpyTOjYcI65xC23VGCY+iVWCGzPwoKRVTkiH5wDdtUoTS7POtKniVBDwPrzcWhfY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 May 2022 15:25:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0245.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f6ed142-21ba-4d78-6b08-08da2f63f519 X-MS-TrafficTypeDiagnostic: MW4PR03MB6668:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IK0HLrVlcmj54jX/h7YFlPfNfzRYxxBnKkcHHXetOqpEZ2rwuLJ5Wcl9qwQ2WF9HAkHBQgSNRlTbBo7bcLDjqvH4F4MMnS9eAsysfuwPAMM8nvz60+co/KuWt7+rYotJRfutoXZE3b46jLukCs56gfcZ7G6FqDfPb60mwiTZc9TayqCCXHR7ccGgvBYV5CRHMuHqmixnntCV50Ev4Cco2MJJ/ymQd4o0PEB8VjgZjP3cvGikcz4TfD07PqNaJ522MTNOw2NTeE/jz1bIY+bVTAEqTsU7NqSGPT6PWUmEAFRoJSVom/mqyykGn1se0pOcrkmyDI0id+BR6dr8VzgnQNNdMafnlkrW5oHk6cxyExYSPCzySm6EzESnjx6jwvUmxVUYBAZcJKEF6Nlq6RZv95bwT+/3Yql58ArEHSRhPVEtEzf2PNhaH70aaywruEOt23JzAraXTecmYeMSDXjVef2Miegk7XH6sp6J3Q+FVEw5G1C8SbraLdhU9aSXfUwXlGaDc0kk8Xu6voMuQ2NjIp8HTjSPBnrGKCfAuZq9WCk+TDg6511OX1nU+mIxGVoWGEwltziJobQQyKwlg/ALdPfwPS6SGukZ5JqAsZ9/N4rDX3xMmyFmgUUE2RW76LQHB7P5RfXrfIlYkfSgLD3BCw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(6512007)(38100700002)(6506007)(6486002)(83380400001)(85182001)(26005)(508600001)(9686003)(54906003)(2906002)(86362001)(316002)(6916009)(6666004)(82960400001)(186003)(4326008)(8936002)(8676002)(33716001)(66476007)(66556008)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmdOeFErNHd5aTZLMjlzY09sd1RKdlgvY0JuUXRJb1lrSjVkQnBXdGtqbmpO?= =?utf-8?B?SDZMMjFvclRLdkl0SnRiQUxDc1hHR1YwbExEUzcvZ3RUT25vZGxoZkg3WEZV?= =?utf-8?B?SG1qdy9iMms2K1B0VlNNcnVzNG54RnBFRWxkWTl4aXYrK0pYc0dlUFByMk5j?= =?utf-8?B?c25SNVY1Sk1xc2c2VkhUSDYzZm84UXA5NkVacTY5NXpSYllJdzRKUEZCNUZN?= =?utf-8?B?ekpibXNpQjM2ZDB0WVVtWUdnWnVZejhFZzUvWGlkSERzQjFraFBYeXJDaU9V?= =?utf-8?B?bWhGK0ZWd0wzZXlDTkhiNTZjelc5S0JpN29jSEpQMGhKRitHZEpBa0pTSGZn?= =?utf-8?B?S2xJWjJ0NmdsVVBUdHNoOFRQRVRtRUhuRjRDOVJnMGhFemJMOHljbVNuTkFy?= =?utf-8?B?ZnJPMEwweEltaDN3QVJaQVpSYWR4clBRbzJIZFhpYkMwL1lITHdBZi9VSkhk?= =?utf-8?B?ckpJdk5tYnk2UU0xbnBoUEdEaGNDcjdFRnQ0T3o1RzVpT1FULzlMazNWSVJh?= =?utf-8?B?Mmd4dDh1c1FTUXJIeTlZdkM5bE5udDh6TW9LRks0UjhKazBtU2d2Qkt5bFlE?= =?utf-8?B?OG1Fa290Uld4YmVTaDNsVmgvbDdSdklXZ3UwaVh1eDlsV0xBdzlRZlJvZXBW?= =?utf-8?B?bi9JcUdDbkFNZ1J3d2NhamdSVHZLamxnRXY5Tzc3WUlHcGZDMmF5aTVaeHZl?= =?utf-8?B?MWpxMWovWGRpZjZnM0FkTXNNTEVkb1lkeW5MOTMrR2kzeEhWUjY3WU84SGxZ?= =?utf-8?B?TkpxbnppcXJwMWZXTlVjWmYwSTJWcFdDMFJrNE50aVJtVnlQeHo2QTY1Qk14?= =?utf-8?B?dWtyZTdIYjh0bjVDVEtjemk2VW5BU1g0QlJ4Y21UZDU0ZUlreVBmNEptTmQz?= =?utf-8?B?MHdnYXdEdTY2NElMb25reFlwbDNTY05FeWVNdU1XZVFnLzl0eTZ3MzFjZnFi?= =?utf-8?B?VGY1dlU4am9XR1pPdVJLc0hSamlZNkc0Z3FFSFNsaXFIWFZ2RHBvUGlqY0Nj?= =?utf-8?B?eHBJMTh0cVA3L1NjZllWOGdFVXh4WTA5QjlHdVVrK2piVzYrOHZrYkFaK01x?= =?utf-8?B?dFBxbEdqWS9PNHpyZlZBaU5MOVp6cTVxcjJwbTExUXluY2ErS3M2VXAvMVVV?= =?utf-8?B?NnB0RmlHRDQxWi9JUjQybnQzUzhqR0oxY0tqRThKdlFUK1Y3dmpFU3FFRWRW?= =?utf-8?B?cnhScmYzRHl2cllQaWFxazJuekVNb1B1TVgrZDE3MnlSNjVEKy90eGVFNGlB?= =?utf-8?B?eTBDK3l3TlU1TGtvSVhqcFNoZ0FxMG5KYk94YnoxMW0vaGFRdnhrR2JNd1JX?= =?utf-8?B?RVl4OXh5SXdkdjJMd2FmTWk4RjlOaW4wRXlnWjh6UmxGRnBBU25La05PNnZk?= =?utf-8?B?TjhEWkRLRzFYMVJRSnRRS0JzSGVMeUJiOU82M0hQdEp0U1UrRC9sUlBMUVlS?= =?utf-8?B?cHZqNkVlckh5K00waFZiYVAwWkxBUGRNUHR5bmZBemhweCtjZzErSUMzWm45?= =?utf-8?B?M2lVTmk0U0FJTmlidUVWaFVaNjNvWEZhMThkR2Zub1ppQVZyT2pJaU1nUStI?= =?utf-8?B?RmRwT0dVd3BKUVEzK0tOM2ozeTdxc0FwVDVramxLTUJFVkN1YlVtK3AzRkow?= =?utf-8?B?MVlMT1VDSDF0cGNjRXRqMDRHZVE3ZkhhdjhIVHc0cWNKQ2M3MDhpN3E3cml2?= =?utf-8?B?Umd0Wm1USEd2K2Jaa2FVZlNUU29yd1BzajNoWVU0NDN2MGxjaEdXMHBsV3dW?= =?utf-8?B?cWllY1RUOHFYb3Yrcm9LMy9oc1A3eWNNYzJQR28zd0drSGtZZFczVTZuNWJv?= =?utf-8?B?d1A4YWI3RXZrZVZvYjZvTjdXRlRKT1R0TmtvL1k1blBqWGFWNHVLazVsUWJs?= =?utf-8?B?bWlZR2tmYzZjRGErMGJWUjF5SWozSkZ4WE02RGNnYXZsR1ZackZPaXNBQW9J?= =?utf-8?B?Y1o3N29VYUVGYWZSRXMzM050cndlS2pPUmpXbE9tSWl6bnZLaEk2MTVTK0x2?= =?utf-8?B?ZUhCOUZ2M05iMnlTVmtaOGQvV0NyeGlzMWEvUXQwbnJ6U0ZZR05ETG1KZHRO?= =?utf-8?B?clF5Z3ZzcHE5RFBhRTVkRGZTTjk0QjdmYjNHek91bVBXODBVTFprblJ4a0tj?= =?utf-8?B?c3Rzb1JKUzBnRG5keEY0aEhoNXJCaHU0ZkxXM3l1eHVBV0FoV3FMdTJkZVhG?= =?utf-8?B?L0JUWVF2M3Rya0ljTG5PSGdXUVF3M08xZ1REaE9tWWhvd1NsUjZ5U0daNmhY?= =?utf-8?B?cnZRSEFGZSs4Mno1OEwxcWE1SW9KQVh6c3V3ODNSeVk1N2VHdU96ZlBLYVNS?= =?utf-8?B?V2JyMFNMbU5RZ2RXeXdkOGZaZ2FVT0h1aGNBWVZ0bGJCMC9zRzdQNUpSTEpW?= =?utf-8?Q?we05s3DyRKmDHN2A=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f6ed142-21ba-4d78-6b08-08da2f63f519 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:25:58.8416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zAazuu2GtxJprTyQeY91/j1nfZX04g0w4SLdryuvTkVnTPkPizS8rZHZyKV1WPUy5ns9S7cQHWuiom4st3XqDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6668 On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: > This is a re-usable helper (kind of a template) which gets introduced > without users so that the individual subsequent patches introducing such > users can get committed independently of one another. > > See the comment at the top of the new file. To demonstrate the effect, > if a page table had just 16 entries, this would be the set of markers > for a page table with fully contiguous mappings: > > index 0 1 2 3 4 5 6 7 8 9 A B C D E F > marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 > > "Contiguous" here means not only present entries with successively > increasing MFNs, each one suitably aligned for its slot, but also a > respective number of all non-present entries. > > Signed-off-by: Jan Beulich > --- > v3: Rename function and header. Introduce IS_CONTIG(). > v2: New. > > --- /dev/null > +++ b/xen/arch/x86/include/asm/pt-contig-markers.h > @@ -0,0 +1,105 @@ > +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H > +#define __ASM_X86_PT_CONTIG_MARKERS_H > + > +/* > + * Short of having function templates in C, the function defined below is > + * intended to be used by multiple parties interested in recording the > + * degree of contiguity in mappings by a single page table. > + * > + * Scheme: Every entry records the order of contiguous successive entries, > + * up to the maximum order covered by that entry (which is the number of > + * clear low bits in its index, with entry 0 being the exception using > + * the base-2 logarithm of the number of entries in a single page table). > + * While a few entries need touching upon update, knowing whether the > + * table is fully contiguous (and can hence be replaced by a higher level > + * leaf entry) is then possible by simply looking at entry 0's marker. > + * > + * Prereqs: > + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 > + * contiguous bits (ignored by hardware), before including this file, > + * - page tables to be passed here need to be initialized with correct > + * markers. Not sure it's very relevant, but might we worth adding that: - Null entries must have the PTE zeroed except for the CONTIG_MASK region in order to be considered as inactive. > + */ > + > +#include > +#include > +#include > + > +/* This is the same for all anticipated users, so doesn't need passing in. */ > +#define CONTIG_LEVEL_SHIFT 9 > +#define CONTIG_NR (1 << CONTIG_LEVEL_SHIFT) > + > +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK) > +#define SET_MARKER(e, m) \ > + ((void)((e) = ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK))) > + > +#define IS_CONTIG(kind, pt, i, idx, shift, b) \ > + ((kind) == PTE_kind_leaf \ > + ? (((pt)[i] ^ (pt)[idx]) & ~CONTIG_MASK) == (1ULL << ((b) + (shift))) \ > + : !((pt)[i] & ~CONTIG_MASK)) > + > +enum PTE_kind { > + PTE_kind_null, > + PTE_kind_leaf, > + PTE_kind_table, > +}; > + > +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, > + unsigned int level, enum PTE_kind kind) > +{ > + unsigned int b, i = idx; > + unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT; > + > + ASSERT(idx < CONTIG_NR); > + ASSERT(!(pt[idx] & CONTIG_MASK)); > + > + /* Step 1: Reduce markers in lower numbered entries. */ > + while ( i ) > + { > + b = find_first_set_bit(i); > + i &= ~(1U << b); > + if ( GET_MARKER(pt[i]) > b ) > + SET_MARKER(pt[i], b); Can't you exit early when you find an entry that already has the to-be-set contiguous marker <= b, as lower numbered entries will then also be <= b'? Ie: if ( GET_MARKER(pt[i]) <= b ) break; else SET_MARKER(pt[i], b); Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 06 13:31:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:31:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323134.544709 (Exim 4.92) (envelope-from ) id 1nmy3M-0003H9-HO; Fri, 06 May 2022 13:31:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323134.544709; Fri, 06 May 2022 13:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy3M-0003H2-Cq; Fri, 06 May 2022 13:31:28 +0000 Received: by outflank-mailman (input) for mailman id 323134; Fri, 06 May 2022 13:31:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy3L-0003Gw-I9 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:31:27 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d32455b1-cd40-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 15:31:26 +0200 (CEST) Received: from mail-bn8nam08lp2043.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 09:31:22 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB4138.namprd03.prod.outlook.com (2603:10b6:5:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 13:31:16 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 13:31:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d32455b1-cd40-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651843885; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=1VVhjZskjIkyDgfUOQOgRjo2mEr+FFeZD2ZUhp6yUPE=; b=gTmvGMXxNygiA77jDWN3+jVpgxoqiQazcuPU/vOU2ykMJIVxWObSLaAE y8STaMbpFq2UJIc4vknRmRA3HeSILWvaLcDZ3RaolthTm+lCZ2gL6q22T eig1a/22FwEtRuAVgfRSRDOHSh5wjdYT63db0II6S/XBomN5w0X08oGa4 c=; X-IronPort-RemoteIP: 104.47.74.43 X-IronPort-MID: 71145896 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3aob4a0nZ4Yd115JG/bD5c5wkn2cJEfYwER7XKvMYLTBsI5bpzxSx mMeX2CAOqrbM2P8e9pwPIXl8ENQ65aHzNAwHgBspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw34Dga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0WpZ61WxwxZZbzhdtADz8HERFuGYFvreqvzXiX6aR/zmXgWl60n7BEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+fBfmRjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SCmL2AI+Qz9SawfunXV7xRp9YXXIdPQOcWXeulXlFmkn zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCgkCXx2EVIA0bUx28u/bRolWlR9tVJ kgQ+ywvhas/7kqmSp/6RRLQiGGAlg4RXZxXCeJSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRSXKa9THuc8vKeq2O0MC1NfWsaP3dYFk0C/sXpp5w1glTXVNF/HaWpj9rzXzbt3 zSNqyt4jLIW5SIW65iGEZn8q2rEjvD0osQdum07gkrNAttFWbOY IronPort-HdrOrdr: A9a23:lv2Ql6mI+qQJeV04qdf1fRIBwp/pDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp r525RT5c5zp/AtHNNA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="71145896" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT/G/s9qPZFrVSdzuIGui5IYP7hzCDa+VtzYNwlU9x8hW5er73Y3VJK+WFFMa9UYdhlv8E6DJerJmNSk07iJorbWAbwIv3Jm+6Z80/cynsD4WRHlrfxm0tx/qNr0HhrhR4UmqvTlmeiGooIBp1giSDqgDEtPTUUaJNNm6v0+AZtw8qI3Z/XRlqQ7TWIYyH3F06FSTeCplq+5Mlm9wYH65XrTSerAQ8qLie2LHQ1dSbhDwXG+CphuFGTa3byKDSH1T+M7q8TytFtMVP3M5f7iD/1m5i/wGx40+DNpofU/wBjHzIO2gmrhmzrKgGiWb1eLkE61i+hCg7cgN/CvSCd7GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aDXZa8VyqidZWzbaEeMMnoyqNAhOgGA7+An6ZwKWWDg=; b=fpiOY0U5F8nxtvHzTAr9IVqb8jphmsxChE7yEtP3DC4fQyuN8G3mPw5USuUCePvzogW+k4h5j6r6Ic2+GJl7Q16pXfOk/v2xW+SD61a9eqj870Kvyu3PIrT/4KC36qQTfz5mlWHgOX0CpUKRfDWWYq3tio53KVJjVLN0B+QzNHzBwdckEThH7jKSoyxWzgULVSffdOi+iRISXxYinZfmlZ9En5U4C3qqJWzGaHeo3DEfy+eCzfvPk+9qoel4l7Ze2I3aGWYBJ8PjmIpiUNl9r+EI9moMpZZ/KIt48F+cY+uu+Ht0GjLaB1pvREHkO0m+r7reB+LNOmNwgaeZb+cMXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aDXZa8VyqidZWzbaEeMMnoyqNAhOgGA7+An6ZwKWWDg=; b=p+E8yH+bqyohiHZ+3BTj1E4B5anAOC9kPeenx/kgHOeBT51OxoW+t64fT1JfRJX8+zVdZvofNTjW8qSGtDUNwl+WYfl9VVjuOFtDp+ntolb6TU35nKiipYdtACys6lUJsOG9dPzYdUM84utgaGoX/ak14wr4SVydlwrJjD+Ugbw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 May 2022 15:31:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Message-ID: References: <20220505142137.51306-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab2e4455-f1c8-422d-eafe-08da2f64b206 X-MS-TrafficTypeDiagnostic: DM6PR03MB4138:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RooO4dqpXCycul+zfKmQaXFvyBQrFk5jpQm16W6g3VmV13vJPmujPXh6+3af7aT/zP5tZMEi9b7Xo4pp8WzjZaPSx5Vb7PaOVdTD3wHzTS5uWkD8tIu3WVq9SpAOPoCnVDyHbignBpi4Z3th9mgpCiOe/eKdQ3jgwpcXZXbQgosKC3VelDHpqiGvLLw7AXFrjUDo89f5RC14gi91PhkOpdUM85qomfs/+qRb4bSwMztWEijQ7v0/DhA9YHDv1aUtkKEqR4OnwD2Exd1so13eVpaXZNSjaJHlkHQ6CuGI4M7Wmg4fAHCLjmZq3qlq+9Wgt2QQPKhSxbKYxp5HOnUeBoboBQ/LWyV0W7HUDZnOR6g4k9QBPW84hW4egnUCaXMST4X7MiUDk6NL/VQqDSMEE7Muh67ejfKB1eGOXqWt7r5Sn6lnfuazm1oxgmx465RpR+PGCdg3v7sbFxXwInORJ26IkxTqUbGJHO5X7wtp7oHgwZDgcVt0jcYrw6qwAWdXzBk9HeABvKas9JSslFyz70WqYYblrp6kmutAyOViTmGCxFb5Us/wKl/zHUibtv3azwwC7iFlKFz9s6FFw2romE3ijt5l9Gr/P2lB073AZVbNo80+yq3JnKJtoC+D1jJ8Wp9Z0UmtcRN7DyL6Cm3Lp5/9nBDzlxDbKtXi2HqLdraGbNMVYe3dU3VmPajdbU3I+LQGYfaFtPIv8WX+6Hv203jR8zYy0kxrrPTexkzehR4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6512007)(9686003)(26005)(82960400001)(38100700002)(508600001)(8936002)(5660300002)(86362001)(6486002)(966005)(8676002)(4326008)(6506007)(66946007)(2906002)(6666004)(53546011)(66476007)(66556008)(54906003)(85182001)(6916009)(33716001)(316002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MExIZDJ0WDA4UzZTRjJoRjlDclVPK2M1cFp3SU9sZnR4NTB2WTl1dHFnWEVs?= =?utf-8?B?ak8yaGZhbElMOEFDbk9BeWZuNTF4dU90VUtQeUVSRHpyZisyVXZoQjJkYnVa?= =?utf-8?B?UjBEa1E3aUpMbUxSNng0eVNGWm12dUhYWEg4cmxvRzVaYWw0SUsxTkpodElU?= =?utf-8?B?bFcwSEVLV3FLY0Y4YllZOVBPUmIxQ3ZEVGxUM0lOZDZabnlCSEZpbzlaMGV0?= =?utf-8?B?dVYySndKclhXNWlFUVVsMEtuRzdyai9SOFNGOVBaR0crbTNsaFJCdWRUc0My?= =?utf-8?B?V2FIUThPUVJyZndGMmtlTElFZ1lnSkRBb2ZlajdXUjMxR3BRMHY1SnR0a3VP?= =?utf-8?B?aE5jY2VScDhWaVhRNmtVWTBOMDJQRy9ybEpVaWpaZWlSdEVTNGZTWlY1b2VS?= =?utf-8?B?dHV5aUg4Yk5wS0VDRkY3Qmhhd3VXM1AzOVhxK3NIS0xUMTdkRXJDZ2xrSHFP?= =?utf-8?B?MFI2bjNZZVJTamdHcnBEY3RnZ3YxRTJ1UkpvSmNBS0o5REpKeXJCcnJJc0lj?= =?utf-8?B?dVk5UVVQdDY5WXorSXNyaXZqa3BLQkIwakt0c0ZmYjVsdTVBNStzcmdYbm9w?= =?utf-8?B?L1RoUWdsM2pMYkdLN25GSUdtV0lvQU5rSU5ib3NRNnJDSDVpdzFtVVhzWDFi?= =?utf-8?B?bWJhN1U0V3lnbnJjMjE4Z0E0dlM4anMzRGY3TlZmWXZMZDJvYVA3Nlo5L1Fo?= =?utf-8?B?di9obmNZdmpxUFRFMzU1TW9SQXptL25Gemt2Z3JHNFV6cDhicGZ2bWdhOTNt?= =?utf-8?B?ZVJXZXFGMEhhQmJmT0NIK0I1OVlRUUhuWE0ydHgzTzFNV01WRlFvRkxIS1JO?= =?utf-8?B?Q1J4MjJ4NVM4dzhSRVBVc29EZzdaMk5nN2IraWgxNCs2S0RHNkVYbnFxdmVK?= =?utf-8?B?OUlzeHNrcURBMlI1OUk1RVJrWk1UYWhVa2RmMDdDR212VVlXcWtwOER3OHJ0?= =?utf-8?B?UWcyTkplclBSdjNIMERod2Jzc1JtQ1ZFL1pMaHBGUitKNkpOWGJTVDlPdGd3?= =?utf-8?B?eXdGN1V5MzZ6UlZhdlZFNm5CRmVLaThUTExhazhlV0lmUkgyNkZ6cUp3WFU1?= =?utf-8?B?VnJrRWxNcmgzclgrdW96eXk3YjMwUnBWQlF6TXlWNzBkWnFGNzkwYUhydXJr?= =?utf-8?B?Zldta0x3eTRTbzRvN21yZkE5WHFRejRlK3RtOWpiVlFZM0tLVXRVSG44dlM0?= =?utf-8?B?NmRpYjdSVEhyM0xUMVdwb1ZOaDJjUUpkRkhMVmQ3UG42cUVZZ2VwSjMzUzlV?= =?utf-8?B?cEljYncrU1M4N0NPR1VFK3JUTHM0OWV0Z2M0WUdzWWROTys3cWt3anN3TlhD?= =?utf-8?B?MnI3TzVvcW5wd3BUbmVhUEVyOFc1bGtQMm5VS1NlcVlIdHNlRjlESk9UazN4?= =?utf-8?B?L044elhBVDVLSEF4UldnUFlxTS95YXNMaFRNN3BpM0xYdDcvdSsrVVo0dnVE?= =?utf-8?B?cWFiVGNIR2RYVnZVR293elJVY21Od3ozekp2QlgxUUFaU293M2p3R1QwNmZw?= =?utf-8?B?TW5aYWQ0eVVLYk9VcW9wNjhqcGJFVkxjTHNKaE94eVQ2YzJ5V29nUGw1QVdp?= =?utf-8?B?M2d4eFdhbUdtVXdLNGpWejhVekxOdUhvSWJPRVUyK21nRnBsYUxsTXh1OEly?= =?utf-8?B?Y3lzZkY1MHMrRWFMaG1DYXpBQ0ozNWJMQUR3QW5aejFBOGhjQmVOODhIM0FR?= =?utf-8?B?TE1OZkhJL29Rb0Q1Z0QrV0xhdGFYVkRrZVVpZnVveVZWVnl6Tldzem0yeVZO?= =?utf-8?B?UDNXekdGNFJtajhsYVgrMDYraTlKdndNTVdJajRTdmhHdnV1a2M5Vkg0eFdo?= =?utf-8?B?UFY5SGJmWGxGZzFyVFRpQVc1RVYydkpqWlJqQTZmdmVEb2ErWmhleklxM20x?= =?utf-8?B?VHErOExyL2pOeDVDdjMwVTJObU5iT3QvV05zWFQ3MWtpVjJnNjRzUzFKVGJZ?= =?utf-8?B?WWlyVDFUMjRMQll2L3lMWTR6WmdHZkF0eW5rVUcwT3ZXNW1XeXIvZFhaeG9w?= =?utf-8?B?Y3dIUTBlemQ4RnpXMzVEV1loc3QxbU9QMkhrbnZxNHdCbzlEc3B6MFo5TmR1?= =?utf-8?B?VG1MdGZZUGRRT3h1WmVCai9tM1pzSndXM2dSSG5VS1pEQUFyVytSaUoycmpR?= =?utf-8?B?UFpBUmZ0K1BqK1BOR200SUhucXpJTmthSXgrVCtMTWp1ZmRZVitXZG9JVTgx?= =?utf-8?B?RWQwK0VzVjM4TjdVeDJ0Njk0YlFUbm9rK0JEcitNT3IwRWw4QWZpNDVVRTdH?= =?utf-8?B?QTdNMmxIeEFRb3J2VkFiVHcvYXZjc3N0bVpNUUpPOU03UERmTWZXcUVYMlI5?= =?utf-8?B?UzYzcnVvRWhLdllCYVhnWXJYbm1rc3RjNVRnRGdQUEZvUDFaZk1tTW1uVGxm?= =?utf-8?Q?+NfIrV1nY8X4b7dA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab2e4455-f1c8-422d-eafe-08da2f64b206 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:31:15.9347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jBbYDJisgKFapOB9p7tJzTMVMAIO+rFoESVAj7nYJrZhqMsHZ3Xl21XH85sxKbCuu5XHO33fs2fSokAIdMRC6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4138 On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: > On 05.05.2022 16:21, Roger Pau Monne wrote: > > --- a/xen/include/xen/compiler.h > > +++ b/xen/include/xen/compiler.h > > @@ -125,10 +125,11 @@ > > #define __must_be_array(a) \ > > BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > > > > -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE > > -/* Results in more efficient PIC code (no indirections through GOT or PLT). */ > > -#pragma GCC visibility push(hidden) > > -#endif > > +/* > > + * Results in more efficient PIC code (no indirections through GOT or PLT) > > + * and is also required by some of the assembly constructs. > > + */ > > +#pragma GCC visibility push(protected) > > > > /* Make the optimizer believe the variable can be manipulated arbitrarily. */ > > #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) > > This has failed my pre-push build test, with massive amounts of errors > about asm() constraints in the alternative call infrastructure. This > was with gcc 11.3.0. Hm, great. I guess I will have to use protected with clang and hidden with gcc then, for lack of a better solution. I'm slightly confused as to why my godbolt example: https://godbolt.org/z/chTnMWxeP Seems to work with gcc 11 then. I will have to investigate a bit I think. Thanks, and sorry for the trouble. From xen-devel-bounces@lists.xenproject.org Fri May 06 13:36:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:36:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323141.544720 (Exim 4.92) (envelope-from ) id 1nmy8P-0003ul-4E; Fri, 06 May 2022 13:36:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323141.544720; Fri, 06 May 2022 13:36:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy8P-0003ue-07; Fri, 06 May 2022 13:36:41 +0000 Received: by outflank-mailman (input) for mailman id 323141; Fri, 06 May 2022 13:36:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy8N-0003uX-8e for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:36:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8dbf0aa4-cd41-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 15:36:37 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-Pi409zZCO7eAyAVCWaaR3g-1; Fri, 06 May 2022 15:36:36 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB4244.eurprd04.prod.outlook.com (2603:10a6:208:5d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 13:36:35 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 13:36:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dbf0aa4-cd41-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651844197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TEu/d+isEYnxaYmttcn60/lZx307T302lV5inrNhwjk=; b=bSTiN9M99Wjr5WucOmHgxkHwnlBLhRg0BySO7yT7qCjYjcUhlVbKrG8bsaqBYIIhnMT1QL xSu1AcNYARoMaIJbIFfS4K8Wc2pCoqCh5htRhRqkMGmZWng5HkzKRG5C3e/fc7ciiD7TeQ Eq/jTJHuwN06hcj9bqiJuwpdyW8uJNU= X-MC-Unique: Pi409zZCO7eAyAVCWaaR3g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oV1ZM1mTOSC/lCHQ8DmN40iuIaiULmT3+y3q5LNeDbmCx40VBj97uKRNWzTs3cUAVOgCWapEtppH0sg4FfdlilbPftkg7hzMNU674UaOYrcV4NePbg0r47+X2Ypm8bmvKP8WBt2JlUyD5FRn32uBUEemr/nRFcn+9OQH/BFSdgWrhtRLWOTtqpeuPD5duGEjDOZPHSBf6As5GguZoTqyYVVBAJi5SLK/jEZCObItameVpdXAbHl3lcBZTgIz4UeHWQzEn9SZbaErxk3DecPm38fJ/0YcbkV4I3KyYeqFPPCcdr2dNzW45yreTPT5KjgQolyzn7DMW4bo09PviO0otg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TEu/d+isEYnxaYmttcn60/lZx307T302lV5inrNhwjk=; b=FCHggz/oslih1mC6eB9AguMqJBAmwdlIfIiIOUEsqplyW1P75ikAHQAO4O8gR++Qm0vDaRlJtFd3aIDVOcT+IjkFxhR2AUbqTu4EKCkYcgndxHyoqoVmuSoq0F1CpJhsmKnRkLsb/98vea7JrWuWv0C589nSJOjFulSQ+sRLRUTY+BdVq0DKXbEhSR37M1AG9b65Y0SbLzLp36X1kT5/XrJd4deKvNflibILruwgAMh5JRjafJQ6LQiRwugmQ1IoNXL36B2zg3Wn+WJJxKJYjK7upKvUHRsNrOL3HvwzPDjX2cuT6S4WAmTvFlkhWGMfMLWXSMK3UYLhagSt/NLTAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 15:36:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH 0/2] build: deal with future GNU ld warnings Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0092.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::33) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35fcd030-8403-4ae7-f3e3-08da2f6570a7 X-MS-TrafficTypeDiagnostic: AM0PR04MB4244:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kbXGMWJ19SQtxAH8SYWLmoNBWgECrqbtpQWLyoR0b7FO1/3orwTVR8bSjWKyVKvzIPo55E77GQRO2ovl+uM5BGNKoWlZeazqBfum8gsxsGXbpsMZQCUBd/jjmRKfHSeVp8jup446TZDm5agRP4aeM5+vdT9kudjs7fWe/cahZ+XmzY/wNvJ987FXXbmxpb+hxsl2Yb4EW8rX9PXdX5Sgb3lPjaxfzCUqNwnbqDOrObTVI3fei+NUrhSZ/jka0sx4arFuB5pg4ul0gmhcGXekMznkwhPLr0VqZmItlkmwAdVq12KqAUpaLDixt2Mq3pd3hd8YyNxOudVdXK1x7CmWleO0+iz1Sk5PrSfeNgbep2lMzzNV9rbNadLuJqo0Xhc1RZh2HJGKxW3iA8fqbuQvAfhgMbQWKoq8vwjNrRU8kRt93rL2xBn561MC1w7yQ9DGeEWZS0DLjhJ4xiuXt9+WU+GESuR8TYZrWynxzDBvgoaj3LSXL5X6IUIBddfICfy6y+2kugOZnmldt/ju1CBt1jbt2DcXb1nWEMJQjcqI2RBafVRQFyVGyVi6v+8G1peq4HYg02Z3IImW0oDjx0YLIX0KmT41qvZyk28XUShiGSP3tOKbtj0PGz60Oyc8msYdw3nzp7PLn3uV5ItYijmIESvit9sbHNMecTR3j6iLbJ9vNF5Jt0KSZ7JnnHwzecKIo1jDINgwMn6Sv434H09eMT9mXEQShasOxYv0siiWiiE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(86362001)(38100700002)(2616005)(83380400001)(31696002)(54906003)(26005)(66476007)(8676002)(4326008)(6916009)(36756003)(66946007)(66556008)(5660300002)(8936002)(6506007)(508600001)(31686004)(186003)(558084003)(2906002)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1BHZzBoUW9kQThGK2xBdFJEVzlXbm1OSDl4ZHU2aUlxZlJuTjl4VHRjYmtK?= =?utf-8?B?RTFXWjFONkcwUGZOQzBRVTVlaXFvT3F4THArem5qYkc5VUVpTXVaNXRtWXZQ?= =?utf-8?B?QU5mTjFTUnlkSXQrL1BLaDhPNkhLKytOOTlCTSsrZlpINmdKeWZxZStjNEFn?= =?utf-8?B?bm51ZmxXNTIrSUoyd3FCUng0ZW1pb1FybS9WS0g0RlhTckVodi91NlVJSnVW?= =?utf-8?B?MjNoQzl4d0FvcnVqRXZuS0xSdE4zSit1dDBkWnJsQ0JHL0ptQTFKTXBZelIy?= =?utf-8?B?SUYzQVljdmV1TW5PKzVxVVpLK0ppT1RqYnlObTZCRVREYW9UWU5WOFJBeDlO?= =?utf-8?B?U3dOZkk1UXVKRW9sL1JVVUtERTIrTDBnTUdIU1RkbHZJL2VOTW1yWllZdWth?= =?utf-8?B?Skdsb1JiVWVMS0taU0trV1N6OTdJb1QyM0xISFZpQzI5OVQvdjc1VmNjS3pS?= =?utf-8?B?cDM1RjNaTmFqZithakRxSXN1djdkQmlZQVFZSVFTVUtKcko0R3c1dHM5WWdE?= =?utf-8?B?UWtRTWJrVXl4ZS9YZ1NCTURXaTFnYlMwSWU5cUVsMjg0dm8yMGo5K2h1OG9L?= =?utf-8?B?b1Npd0c5aTJuN0s4ZUtrVmhZMERPTGltZXhYdkVuZitiQkdRVThOUXliWFZj?= =?utf-8?B?U1RBS0RoVmp0aWErdVIydzRLUVJCc1JUU3lYRXowYm9OVlJhSThNS2JtTXhv?= =?utf-8?B?U1lKemRKMkJ4YjlLUXhaV0FNaFhBd1VZTWdoSDd1aEZzdmdMM1NReStrSTZo?= =?utf-8?B?QkFUdVVFd2hRYU1lb3JIc0ZLSUh3Z1VDMVhrNXZRdUM5MkpHNnZOaUgzWWxx?= =?utf-8?B?LzczOFBjYjg1a09taHJDaDAxcmZQY3NZdUN6YlQxR0NPZXE0SXZDUVpMeGVj?= =?utf-8?B?ekhYVFN0bElDTGZFeW9uVVp0TkovYkVLRkk2bm1PSkszL25hTmw3ZnprWXVv?= =?utf-8?B?UEV4Z0dZOTZtTGdCbjNKNC9sUHQwZHJpbGR0dVViRHgzbW5iY3RlbVhXMWYw?= =?utf-8?B?TWM5SzkveFFFcUUvOUpkNkl0VkJQaitmTFZaWlY1Mk96Y3BpZk5lQVN1cXZp?= =?utf-8?B?bHRrZzZhWDhob2sxeFBmeHF1ODkxMTgzeUVvS01sdEtHajIwM09vbG5ZQW1w?= =?utf-8?B?R2lRamxPOXBLaWsxdHJZdnp6SmluKzhqUXEzU1Vkd0c4cGtwWjh0ZHZBQ0Ex?= =?utf-8?B?VzQzVXRFQVZkUitIQUlURkdHKy80K0QxUmloS2JQKytYdlVXa2EwRjdVTUlP?= =?utf-8?B?WlpDNVhSVXc5czI3dTdBM1JmVFdhZG1meGpqTUNtV3hITXJiZWtnV3N0Ty9W?= =?utf-8?B?UW5BWkp5VjFVemkzNy9RVGQzNlFSY0s5UVYwY1FuQ3h2TGdqRldBU1MyUDJx?= =?utf-8?B?T3JxQmdaQ25tSUVteDZKdTdqUm55TUhpUnIwRktPdnJpcHVzVm5oOXJTMXli?= =?utf-8?B?VFJDNzVjSDR1OHZDRnV0dXRaT05zZmxqWXRFSmo0ajl4RnEzcTQyb3N0cFNa?= =?utf-8?B?MEtvYWdaKzc1RWIraVNyejRXS0JlL1dBdnhuYi9wd1hzeDFXeHZiWUtLV1Zz?= =?utf-8?B?dVNFem0ySEJvN1ZoVzhrWjRERlY4MFBwek52MklGWUtham9yMG5NSmRTQ2FU?= =?utf-8?B?KzExM3dDbDBNSU1KZktCbUZwQmlkeWNqNUpwU0NiUThZOFRZdkVxdE1tZXVR?= =?utf-8?B?UDlrR1F4aWtEWVhISGg2VWxEdzF1NjU1ZjRtVDhvZFVKbFZ3M3FyeTkwREJ5?= =?utf-8?B?VDNlKzRoNGRPaVpPSkZJRTJZcDBIUkN2Ly96dzFFNjcxS0doMWhmN3BFbGFY?= =?utf-8?B?ZzFCTnFKcnhpR3VUR0RyNjdlZmdGMzJYVmxKV2QwSFd1eXNpU3M0RU12U1Jj?= =?utf-8?B?b2c5QWFmMGk1cnpNcmpjMFpqM3Q1MkVEUU9YWXN2T0d1Nk5tL1FmMnk5Tm9i?= =?utf-8?B?WTBIM3o0UkYvR2JrdFdEOU85S3VZNWVONkZraTlKaEJjbHAyZTEvb0JYSXVx?= =?utf-8?B?U0laMVJtZDZoc1N3dGx6QmhoTVdoZDVqTjNIeCtpNkdGT2ZLWkJvbkRxMUls?= =?utf-8?B?azAvam5oaTM0cURoL2t3Mll2VkZTOXVlMUlZaktDakRsSWNya2dkektzc0RV?= =?utf-8?B?N2E0TGZ0aWpwSTVST2dKRklwbzd3QXlSZmNWSjV6U1d0SVZhN0NrK0VqZnZW?= =?utf-8?B?SlFGajBLMmR1WXRiM0FDMGplKytvM3AzakVhMm1jYTFYSWlzSVJNYlNGUzBJ?= =?utf-8?B?ZFV3L2psaFZFZ1FGYzNlbHFxSlZKait3SzZHdDJ1UkNBenhnTHNiRmdOS3Vo?= =?utf-8?B?Ny9OeFM1OG8vWDVtc0NNRFNBTmFJeTk5czZ5M3A2R1poWnRqeGpkQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35fcd030-8403-4ae7-f3e3-08da2f6570a7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:36:35.6478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MvmNeN7CdggRdrnGJhxoB2Rqqf9HUIYYOFzBdNRWGWNHxzGBI0MrHjZknPIZVL1BFv6sohTQlEF5cDc/k6eFsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4244 1: suppress future GNU ld warning about RWX load segments 2: silence future GNU ld warning about executable stacks Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 13:37:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323147.544731 (Exim 4.92) (envelope-from ) id 1nmy9Q-0004dU-Hm; Fri, 06 May 2022 13:37:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323147.544731; Fri, 06 May 2022 13:37:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy9Q-0004dN-Em; Fri, 06 May 2022 13:37:44 +0000 Received: by outflank-mailman (input) for mailman id 323147; Fri, 06 May 2022 13:37:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy9Q-0004d9-2o for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:37:44 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4b59d72-cd41-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 15:37:43 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-jYY1Q5NYPMGGWEvEFhXd7Q-1; Fri, 06 May 2022 15:37:41 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB4244.eurprd04.prod.outlook.com (2603:10a6:208:5d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 13:37:40 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 13:37:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4b59d72-cd41-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651844262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bHJuGSU0qKTwmTKHxZiO8PSa+xZzXEfsSIdvXPh7LlY=; b=HWc2Y1agR+oS+hNgd4Yv5L32zmBlWGc3PFxeePJWLO3Jjbq7JOaY8R+Zo93h0Q7UEPfmXP Z8XlMwj+JQdo16kWe1J+HSyhnvm9zPtEFm2uF+Ufd9R2LUYXnMEgEdrkOxYHNHzi4wnb66 eW/zGTvwyi3lNjZcl5nym/ZDfwV6T9c= X-MC-Unique: jYY1Q5NYPMGGWEvEFhXd7Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+6qqa68+qJQZC6OmDmEL8l5TBngI/OjRHx4aHIDnaCxA3ZThp8xkRjGJBQYihSV6l215aFkIjiiwT4PWV1WLIeEVYiCip6ZshCV3u1YmbL6Fj8NLWn8CLfgx8INxh3LnGJTh+jru5cEJvkttVoUNMHkg6K21UFmFLyxvjmRweGn79MO4k1JE8KXdmGXC4i7XD2dN42Jmer6KO3ce09rT3AasKTmFxzeIbTRaon8Xh4rovXELs35n/o3sk7vVUpBWhb+viv6QTOMgY9qTv68Ig3jUHoUwq+tdoLrM5Z6ogbdmPUEfFRbQg1kFaspsF1kA/coMDD5Ko76XjxjLXqjzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHJuGSU0qKTwmTKHxZiO8PSa+xZzXEfsSIdvXPh7LlY=; b=mlnnOWQ+CtNzh40GzewOjzGU/3+U8ReBVICvpoq0ZjfV396+vKfE+l5N/hYeavuERtFNuV18Ypamc6XkL0DR+89TV3xeUJ4Kxg5Zqldsvz4OcwMJx5qVABdgjq8oN9/EeB/sVzFOYyYvUOrXwZPuIuwKDxIJWG6OywNqhdIEcmOwuQUh+BZB2yqro84JgoZyjFIGlQXe4Dk9euw8myiiWOlI44+C2heg5MGq2EwoZHLLEvFf3AF8EL8tQn91iwTFuYqXpeDA/+GNEOL3C/rQd5kdGHxSsTeSZTvJ8Tj27UrbRWXd3Do++IctrdO8H8HWFuY6E50aI8lVHiKnq5EuqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> Date: Fri, 6 May 2022 15:37:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0114.eurprd04.prod.outlook.com (2603:10a6:20b:31e::29) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b0e3288-8a0c-4f1a-f06f-08da2f65975b X-MS-TrafficTypeDiagnostic: AM0PR04MB4244:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iSykRxGxM4p1i9PDSSCk5qJfN95c9N6a6sbm1jzSW8euqNUFT/bqCoFIifrqNCiJBiw/hmAmaUMh1x+ISef2AehvBii5J3Red9bXnRXWPZTpu585afUn+y80Vi8ys1WxsHsgmMWuFDXfGWGoaRs4rEwuaCAqcfWk26xy3oOBFVsjG4CPxlV2kwsQcXW5fYP6npd5dkv4QN01tXUUUU1QZx+dAkZxRv8KotCO8bovL6uee4ab/k0IzdCgOmskxKHda9ogYh/AWQtFbCfo6/VPPYqoS1VxX/hGtkTq/Jbq4Lfzo+J5U3AdFCZBanhEQ/yNnu4uEfOYa9oB+MltK7zK9XorqbsPTpAEhzAxa5Hsno+eWtVtXvkNFojiMv7EID2wvSOPKBSUWatq/FR1Gvbe2V0mHhKgkzfcdmH09NMjpBK4nSlaAmF+po2IEYsjRIoyqK5Y9Jw0GbYcD7CD539tpSfsfWMJ6Dha6JnaSnAo4QSiI9wWqQ2XMMUazHglxSSBWJxlOuFAa/fGGjtsJuq5ZBxevSPm+wqjS+Gv6QWw4OsfA/YT/jg2Lh3Q8DZpcOQfwW8dnZO0LO7BvzTAutPZVmK85Y/muaqN5u2HZrrakrx+eOsO4lra2ObwaRxeVV/MVN7Rise1XeIzBwAJPRep/MQFVxx1uA1kzDxe0mqixq/KGblwir+xHymtnAPGp7/UOK+3eV7TPxjk3U1hlLjWJaG8WrEwH+SY5TfWtxFVQl0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(86362001)(38100700002)(2616005)(83380400001)(31696002)(54906003)(26005)(66476007)(8676002)(4326008)(6916009)(36756003)(66946007)(66556008)(5660300002)(8936002)(6506007)(508600001)(31686004)(4744005)(186003)(2906002)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0NVaHB2TGQ1c1FTRlFjaGtESC9rQTYzS1JPeFIyc2c4THRCckRCNDJpakYz?= =?utf-8?B?UCtmaTBtTFZlUkRpTklOUEJqSHFsNCtyaHJFanZOYWo3eW1CUlJNZlVoTGNx?= =?utf-8?B?Snl6UVpCbUszZUdDSW02L0pBeXFBcXpsVjBZOXQ0TXlITnlncVFPTVJoTU40?= =?utf-8?B?SGlRam0weFYwV29kT09SNjFNNlZGM2dYT3pJV090c0FhZDkzV3pLZlhQbDlj?= =?utf-8?B?TDRlaHlsKzRWTEZVWTI0bmExWVE4Tlp5OHZXdXBoTnlFQkpLc0lzOS9CcmFr?= =?utf-8?B?STZMNGl0blZiMllSeGc4Qzd3TW50dDdnMFZiek91RWI2czBoZU1OMlJnRWpU?= =?utf-8?B?YkRQelFpYUlxdlZFRVpUK1pZeTBQWklZcVJIU2g2eGo4dm1CQ0pBcUFiWGRk?= =?utf-8?B?NGVOVytXb3g4bTc5S2dCTkxWZGpJRUFkaVd0dnIrRTNjRk5MOWtJYUllekJq?= =?utf-8?B?d2h0LzNIaXlIZDBDNEQ0OUJtUGpFcTE1b3puS05ZQ2hDNVFJbWFVazdLVm9Y?= =?utf-8?B?d3RFMnNyQWFwUG5DSE9VcHNncDJDcFdCcFBpS0hxZzMrN25QSVpUdXJ3dXNa?= =?utf-8?B?SW1rOThKanI2TFVFbmcvaGUxSWY4QmJTcHd5Tld3N1lOdlJLcTh0QmY5M2px?= =?utf-8?B?TTdxV0JHS2NvVnQ4ZW9nOHBtam9CRk1IQndMZ21tRlR3NVpXbXhjQUV1UmJJ?= =?utf-8?B?TjNacVhHOVFlcldjNkRoenZNM2lZZ0xiUyt6TGxEUEFMNC8reE1kWHIyZUJl?= =?utf-8?B?dUUyUXpFdFZpbUhqaFFVazRtZjZ4UElXdmMwbW1nTXh5eVVaL3FBYm1xN01C?= =?utf-8?B?YWtmdnlRY2pEZXc5Q0pZbGNvek1uaGZPdDRleW9ralc4S1l4a0E5R0lkcG9T?= =?utf-8?B?SEZ1cVJRcUZQZGRGWTRsV0RrNTFjSDN2aXdxSWUxcjJ1R1pQQTAvdi9PcGVx?= =?utf-8?B?MXVlOHNtTmhvdjZwakZ5dVJ6d2J1bU5SSkRTZEc2SEs0eFZ6ZDhmRGxlNDMz?= =?utf-8?B?alFGek1UeXdBMWdGYmNyejl6YSsxZ3hOOUk3MnhxWkRTM3VqN0JjZ0VmcnlE?= =?utf-8?B?ditLdXNRTkVuVVNoRlRHL3FpeGFyUnIvY01UUEhTQkxCSVBMdGZqRHNveC90?= =?utf-8?B?Z3FVQnF6UytTMWNsMGJMMnF4QyszVnVzRzNZaWI4NkJDUlhYL002RGJadzZm?= =?utf-8?B?K2l1OTNFZFo3MFhCSXVXcWM5bGtBU2MwcWhuSlAwdXE2UFFVNnZlMFlOVGhN?= =?utf-8?B?Yi9RcTBDdmIxZ1lJRTVxR0VTU3U5djZGRUpEeENSZjloUWY4VVRkc0JPT0Jy?= =?utf-8?B?S0NpR1Nxb3JrenhQdVJqSmdPMUlQUGRTeHhVcmpKZFhhS2ZjajU2eHY3d3ZQ?= =?utf-8?B?RFRKbWVhTCtQeHNLNFg1VkJiay81aVBZajAxR0lIVGlkZm5qSnpETHFpNVor?= =?utf-8?B?VUlhcU9rRHQ5Tm9yTWpmRWNSM3hhM2cvRW4rVzdzd0VvZlVzdnBqRnczQjVR?= =?utf-8?B?YWRxV1VWS3prMFN2RWdpeG5EcWlqWG5Yb2ZLTDd5T2ZNNFVyVVpGa29NUWgv?= =?utf-8?B?bHhBenRyL1hvZXZDWEFxbERxQldUS3RHVHRzbmNPODRSUHFMcThXR3JPcVdS?= =?utf-8?B?MW9nWWNTemc4b3NtNlBGOXQrRXI1citBQk5DYjUzWmw1ZGNwdWxxZFY2QzVJ?= =?utf-8?B?ZllkcWJEZytEWWo0WitNYmZPdUN5aWZzWTNVN0RQTjNFTGtmMXdwakpuUlpV?= =?utf-8?B?S2VJUnpnZ3QxQ29kQkRuQkd2R1NVczhTeHZSS2tJRzBGeSt0cERscW8xUTBP?= =?utf-8?B?LzBKbzhoN2lHTGJVVXF6dmhnNURrVFBsTm1ZRHUwQUV4RDlXRXIrTGhaOWh1?= =?utf-8?B?VnYyMXVodER2OEtRRnA3b0JqMUl3dUlKc1JENGNZeWxHZTNxUlVBNXpmbENJ?= =?utf-8?B?YllZb1NCQ1dDMThjdjBqTXBDdHlmWWt3ZUhyUnMyVDJRRTNUbmV2UHpoN09G?= =?utf-8?B?WDlHL0JBNVdVNmlpalVCL096cElWQnhOTnJ3amtDT2VWWkozSnQ2RmlSeFVr?= =?utf-8?B?UVF6ZGlsOUVmSzQwRVJqeTBHYzFQSEZlNWdNVWlTeDA2dFVHSnJsY2hXWE5Q?= =?utf-8?B?Tms5M3hIWE9hdWhEOUE4NU9nWWFBZmQrTGJOVmVERkRnbWJuekh6OGxUb082?= =?utf-8?B?dmc0blVZUDU4TXYzMUthWlVsc01LelhCNURqY3pOenZJdXZkbWdUMU05bmxZ?= =?utf-8?B?R05qakdqcWRiTU10UWN1VWk3bmNTMVA0VnFYS2o1QmcyU0VCYUZSSDc1bTl1?= =?utf-8?B?SDZwVTdqVkFwYUdoZ3JOWVRZRXE1bXBRMUhSQWszWkpDcVZIRnUzUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0e3288-8a0c-4f1a-f06f-08da2f65975b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:37:40.5712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RmqsKmzm+twmlrRl1bblFBFY1E+OPOzMQYCm9yX+aq4hX2DIEvvKUd1TkN57yXH7KQ8E5giyjVGsS+oscDB/Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4244 We cannot really avoid such and we're also not really at risk because of them, as we control page table permissions ourselves rather than relying on a loader of some sort. Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -397,6 +397,8 @@ endif AFLAGS += -D__ASSEMBLY__ +LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments + CFLAGS += $(CFLAGS-y) # allow extra CFLAGS externally via EXTRA_CFLAGS_XEN_CORE CFLAGS += $(EXTRA_CFLAGS_XEN_CORE) From xen-devel-bounces@lists.xenproject.org Fri May 06 13:38:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:38:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323152.544742 (Exim 4.92) (envelope-from ) id 1nmyA4-0005AX-Qz; Fri, 06 May 2022 13:38:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323152.544742; Fri, 06 May 2022 13:38:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyA4-0005AQ-OC; Fri, 06 May 2022 13:38:24 +0000 Received: by outflank-mailman (input) for mailman id 323152; Fri, 06 May 2022 13:38:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyA3-0004wM-Ji for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:38:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc6f518a-cd41-11ec-a406-831a346695d4; Fri, 06 May 2022 15:38:23 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-cs_4PFg5Mrenl35e3IAWxQ-1; Fri, 06 May 2022 15:38:20 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR0402MB3911.eurprd04.prod.outlook.com (2603:10a6:209:1c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 13:38:18 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 13:38:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc6f518a-cd41-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651844302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f8GNy0NWX6iFubC+WKy9yx2VYFaxzWyaihBYAh3/6F0=; b=OZWidaoum/twGLG/rqXWzINqM5DkeEcxH3XLImqPE4yzMBG1jGQBLT4zpPK00QpV4ynRv9 KV9j2lJpJTpSC/vU+iSmR/LI2MGpsEdKsMjKnvHDXcHAghjJwKnqZyUZSfH71IoP3Vaq60 Oxr3xzshjckv7m6e/QttGaK7R1JVZxc= X-MC-Unique: cs_4PFg5Mrenl35e3IAWxQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLwUsErMnGmApkLGb8SqvxqUEmGM0fhi73v+xETWkCkbf3lexPWT9grTdKKGsjLFPgxaPUXTt2kRUzZmnhA3ApG4D31vIVMpBMxofyoUqPOU0tXncwZBo3jzfixN5wnwrz05LxJVLvpyZkbYZ/q/UXpSx6pvsRM6hyyAs0E7d/OjIG66l4kyvjXk3UhcihXsgIazEHkvYbOOjD1TNnM+tlfqOPFe75D0Aft96VQfUqWnmW6nptxQErjmj8YSZhgGVWKdcwu3df8mfJViQFpo75U/bz4aCqlMEH7XL/rKg4ArxnP+pXRBDfrwqKTvs1+w6tJdJxoRmL48ACk5c1KUdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f8GNy0NWX6iFubC+WKy9yx2VYFaxzWyaihBYAh3/6F0=; b=N2wVBOF+SrwaLkKmD/1hQc80JsMm46mnESls1GhlFtXo+bmFRutpZ1FvcHqPrfnIJZTeo7b9bJw3IGWtTjWhuE8I0L+MzeeONYw9WlQIfTX5aMQXcWC3Xabq3eJGPL3/K8eMqkxDahMy+f0O0GAkxIQ4vlhzgVm0E3snyfUhOVncfQJDm0NS8Q63b8kpcjdAMN9WgV0WBJ2940r5h7TFon7nUmBS1oFIMGyEHLqZNzC/3Nwqpe2UNR4X4HjZkymmxqrZtA6z/jGimh2cBL++TtllKd+ZZx5mW6I8IXSncEXILhJ7RmgsTF2POZD8kgW4bf/3VWKQpKBOFq1HczbdaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1905d86c-6363-c6b0-97b3-beb91aca9055@suse.com> Date: Fri, 6 May 2022 15:38:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: [PATCH 2/2] build: silence future GNU ld warning about executable stacks Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0108.eurprd04.prod.outlook.com (2603:10a6:20b:31e::23) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4a393a5-b1d2-44db-75f1-08da2f65ae10 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3911:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uvBZPavvvCsVKmYIwT7ZcpUJo8ZTAbg1oc/rvFXjB7rJhUgVf25LX/GgFgILW9UjkJvs8oOwsaEhtVlP9c8EmBLzBKcMHUCbpewehLemaIQUBhLir4qpEs1NrR8laKGHH8/8EzXZSehxBNQGs1FAHED6N2oiFHqP6k6gLYTQJJyq6OY186jQ8NinE8ZPZuTu7d4ykkff67RnA9Mg2xpWtdiUPInYYKr4YIbc5p6hvneeowFL3qyEH61TVUbD4GGNlWmSkXUdeX4TWe8Rqdxa4O21AgYcqx8bEp7X52NF4oBE5vQP0Ko3aoQHLohUm9XDDvB0LhlsCytVsB8RJQHgayp+hfI3/mWolVvDs9yoMelvdKf0frtQPwx6odvx2b/sFkvPedy/dtouH8lmfwVxRjXqKmzqfyd8t53ao0OoHFUqiR94oxPG5tkdh6IowMR8rfUQsqTad1t1Z8/tlOJXVc0IEsh2CbV5Gvm7XEU8LMz+D6iENTdSsDouKNZ4qMnHjkIfw+wqYzYN5Hw13ZYdszQXMkEY3cHTrpLIVB5H4zbqD2FOzat2CnomClSKZj+qbQeqb+vN0e1CU7oYlRyawBrrb7eRTeETR7dN+SEec/KPKRfhOfh5U/8mslugzcQXMu4R1qH6jEWSOzAa0vZ39K8+3p+3o0fqNWTP+sbgikWo6b6SXd8OxVobSmjFCJA6z539Ufhd3kHQyBIWbUUoVebdb4JVh27Kw2Z16M7K3v4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(8936002)(66476007)(31696002)(86362001)(4326008)(4744005)(5660300002)(2906002)(38100700002)(26005)(54906003)(6916009)(2616005)(508600001)(6486002)(6506007)(6512007)(316002)(186003)(36756003)(31686004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0N1YzNuQWp6L1h5aitrRk4xWlB2cUx3VlQzdzN1SXB1YnhFekxqMGNxSXpy?= =?utf-8?B?VWh0ZzhvMDc3QmxnNEhBRVRXeUxZc0tMckU5eFJmRWF2blNBTEY5NFA3RFV6?= =?utf-8?B?R2daOVNkUEFseW1aRjdzK1F3cjZwNGcwZWhaejFZa0pwd2J4YVJuaktneG4r?= =?utf-8?B?bkJ4K0MzWjd4K3FVY0RacFg3SWxNRGh3QzN4TTR6L2ZRcTlaSGJHd0I0NElC?= =?utf-8?B?dFBaT2U4NnN1dkFwTlNDU3lzN1paMVdiMlhjTWo1dTljUHIxY2pqajZWMlYx?= =?utf-8?B?MzFkekx0QlNVRzl5cTA1RjROQWxKYzNNbnVoMnpHR3BzaExSS3hzVnljMHp5?= =?utf-8?B?MkVxdkZDLzE5dGowWWp4S0tzL3UrRVlMMlpNZE5JeHp0NkhMZE1uRTdNNzFW?= =?utf-8?B?WldwVlNrYWZueHcyUEZrU21EUXd4MUpQdTQzTy93LzI3bXVKRVNmZnBKOHgv?= =?utf-8?B?V0tRU0UxUk5PNmw3MU1vbUxNaUN2a1BqdDg4dUtSbXNacm8xa2FHdWhLZktT?= =?utf-8?B?ZzRTQStQQUJJcDlrUWVYZFoxcHhHaEZXT2R4LzdpZ0xTUEE1cmZabXNSNW1y?= =?utf-8?B?RGQ5Qm11WWVnRmZES2xCcHpHSkh5Q3ZFbWcrOW5ZMnRtMU50Z0dGWjJrb0dh?= =?utf-8?B?aHlCSnQ5OWZrM1JpRTl5NUJzbi9ZOVNRNWVTWXU3cllmL1pRdi93THQweitM?= =?utf-8?B?dDR6bUVEZE03alVPQ1dTdzlGK2VhQXorcjFOOW1tbnp6QjJoNExnVjBlT2VY?= =?utf-8?B?OUlERGlPVTRGdFNJaU5RWGgrenJsWmRJOGF2bmtEc0pZY1pMZHdYb0F0bHV2?= =?utf-8?B?d0NQRXN2MUNyUDloZm55QXpHUDd3WUZRZlo3MWdMNnlka1NnODl0emlQbkxi?= =?utf-8?B?TE5wZDV6amhHUTNnMTU5U3hiUldtN2hXVStTOXZHUmpUbU92d3NkY2t2MnJP?= =?utf-8?B?eG50ZlNJdElrRnpDbzRURWZISzlhdk0rKzYybHd2NGhUWXNlWnZLMm5zejVu?= =?utf-8?B?ODNiZWt6QWxlQnRHVGRqb1kxbUhiOERtamRWOGxEWjdKdnA0U1cvcFhzb3dR?= =?utf-8?B?UUFYcm1NVXM5MFVwUm43NU5PQ0ZLVlo1VnBEbmZMU2VzbmhNZWd5NmUxdDFh?= =?utf-8?B?cHNNdVhSWmNyVXI4Nll6N3lGczVZVzErZFdCaW1VaDJMTHpSYjUvYnZJNk9t?= =?utf-8?B?UHdKMkQ3MkJVQnJOYkxXWmlGcXptRDlMSS90MEdpK29SZGRGcy9WRWxKSHBS?= =?utf-8?B?RnBFT3dSKzhsSVRVaWt3b1k2MHliRHEwOHJJTTdIT2s5R2FkeGtIb2tiUnkz?= =?utf-8?B?UFhSbmNMTVQ1L1B4cE1ZTzJiNWlCQ2RLVm4vVmRuT2tiQWZjYUk2NFRMdVR2?= =?utf-8?B?MGRxVVdBMTg2SGZuVm1kc3RONzNHNDFCUzFPM0lxa3ZiK2gwYlZRK3NQc0p6?= =?utf-8?B?aVRXZkptM3JiUEY1ZWVJSksvTC9qeVh2aE1Fa3pySjR5Mk5qMWNPUFlWVkxR?= =?utf-8?B?amdIbFdBaExUdlkwRGJDckVrS0JQaDV6cE5xT1E1M0xTSXRhSUFmN0ZrNjBC?= =?utf-8?B?d05EeGVHVW9PSlRrQXI3cWRSRnJaVVRVWTJ1emRza0pzaWZtZDZreWFZSFEz?= =?utf-8?B?azN5bU0yMC9TV2NTaHdRSVlScmIwTHI0UFlodGpCbGh5R1cxS3VaaHA0WXZ0?= =?utf-8?B?NzNLWlloVjFpdDFGYVJrN0M4clJHcFRNalR2bnMzYklXbFV0cWhRZHpCT0hq?= =?utf-8?B?Tkc2M3ZwanBVRTdmbEY0ZzRZb3dqTUtYOWoxY3MrN3JYVzR6eHpDZXNJbTN5?= =?utf-8?B?UkdhYmRWVG5kSUhKUVFtbWJJMDRHQ2RJWlRjTmxEYUNkNHRUNDJTU015TUlO?= =?utf-8?B?bHNGa3JYeVprV1EyMGQ0Q1FHbXVmRDFmT3I3N2ZaUFFQeHBCd1lYWlhNN21a?= =?utf-8?B?N0dlSGQ4bFV5YlRsQWNWditteDNBQUN6ZlJGOTcvQlR3MzZOcGU2VHFQdjVG?= =?utf-8?B?OUZkU2VTNmtxZUJ1SVZEbDRxTUt2bVFJYW9Cc09Sd1p0UG5DMEx0dS9Hck90?= =?utf-8?B?VHNCbTdROXRDQ2VJUkpLYnVFVytTL2g3UDAvUVVXaTRRbm90aGxQSkRDay9J?= =?utf-8?B?QmNDTUFQN2drRXJ6bHVFQ2g1bHM2WjQrcWtPbGltK1psSFRyRTNsRmRWaWd5?= =?utf-8?B?b0U3c2NCRjUyZlpKWWNGeUdHQk53cVBOZURnNjd3bkVzQWY5d0wrSFo3TTVR?= =?utf-8?B?bHpkT1dZMktGeFlsci9OUmJBVG0walRtVHlOUnBJbGdmWCtRSldHcFhpM1VQ?= =?utf-8?B?eGx6dXlQejB4NVBqTmNaSnk5OVhubnp6all6ZjFIYUR0NEI0cW1RUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4a393a5-b1d2-44db-75f1-08da2f65ae10 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:38:18.6581 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dG6UK0bo1gNvTBRj583cGYc6HNBtb1uGZVRQW4zMXbbDv/TNxCLgQyhRszPncPZmyM/QM4B4JS5bHjBPOooD1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3911 While for C files the compiler is supposed to arrange for emitting respective information, for assembly sources we're responsible ourselves. Signed-off-by: Jan Beulich --- a/xen/Makefile +++ b/xen/Makefile @@ -397,6 +397,8 @@ endif AFLAGS += -D__ASSEMBLY__ +$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y) From xen-devel-bounces@lists.xenproject.org Fri May 06 13:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323159.544753 (Exim 4.92) (envelope-from ) id 1nmyEp-0006dk-DO; Fri, 06 May 2022 13:43:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323159.544753; Fri, 06 May 2022 13:43:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyEp-0006dd-Af; Fri, 06 May 2022 13:43:19 +0000 Received: by outflank-mailman (input) for mailman id 323159; Fri, 06 May 2022 13:43:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyEo-0006dX-3u for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:43:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyEn-0007ex-0J; Fri, 06 May 2022 13:43:17 +0000 Received: from [54.239.6.185] (helo=[192.168.5.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmyEm-0002WN-Pd; Fri, 06 May 2022 13:43:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Fze8Ns8JZM5hC8IrpXG+iqBtHLN6C5qeDRULqH9Myeg=; b=b9pN64hMBSrEyMOz5rVu+lufou MQYYMDDwKA65+fW9M2CMVmrUZaq2lWRVNQJGrtqDwpEqwCZgiaWy2HfPf/3vEzkgMsGSELzBcrxqJ x3T0JoX+FJCJe2l6m1idhshWbxjP/pI9O5GwXuBvt8Gb5rIZb6YcO5royJsmNMdxrxQY=; Message-ID: <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> Date: Fri, 6 May 2022 14:43:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> From: Julien Grall In-Reply-To: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, You say future, has this option been merged or still in discussion on the ML? On 06/05/2022 14:37, Jan Beulich wrote: > We cannot really avoid such and we're also not really at risk because of > them, as we control page table permissions ourselves rather than relying > on a loader of some sort. Is this a preventive commit, or you have seen it in action? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 06 13:44:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323164.544764 (Exim 4.92) (envelope-from ) id 1nmyFc-0007AP-NN; Fri, 06 May 2022 13:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323164.544764; Fri, 06 May 2022 13:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyFc-0007AI-KH; Fri, 06 May 2022 13:44:08 +0000 Received: by outflank-mailman (input) for mailman id 323164; Fri, 06 May 2022 13:44:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyFb-0007A8-H1 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:44:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyFa-0007i3-MR; Fri, 06 May 2022 13:44:06 +0000 Received: from [54.239.6.185] (helo=[192.168.5.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nmyFa-0002iG-G3; Fri, 06 May 2022 13:44:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QG9hHc8bsKRmRzxolbMqsjFmvuikn1laUWKe+oLth6k=; b=LY8vBAUKgTfdLm0RYsYi8NkTKM ixrCnTiBL4kUtP2ywCm6LiW+Y6PHWksy4aCLeg+K+W77XOlSQ4s+X9/z7cik2IDM7V7GO3P3kYKw9 jQiTozZ70NC22puYZQB/YkOBHYqp0IyRiqWPAOLjQRXoW5ecNyL/efYIA9fAkQjhDJhE=; Message-ID: <20ab3107-a548-450c-0c2c-98be53f6270b@xen.org> Date: Fri, 6 May 2022 14:44:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <1905d86c-6363-c6b0-97b3-beb91aca9055@suse.com> From: Julien Grall In-Reply-To: <1905d86c-6363-c6b0-97b3-beb91aca9055@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, You say future, has this option been merged or still in discussion on the ML? On 06/05/2022 14:38, Jan Beulich wrote: > While for C files the compiler is supposed to arrange for emitting > respective information, for assembly sources we're responsible ourselves. Is this a preventive measure, or you have seen it in action? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 06 13:46:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:46:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323169.544775 (Exim 4.92) (envelope-from ) id 1nmyHo-0007pH-3o; Fri, 06 May 2022 13:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323169.544775; Fri, 06 May 2022 13:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyHo-0007pA-0z; Fri, 06 May 2022 13:46:24 +0000 Received: by outflank-mailman (input) for mailman id 323169; Fri, 06 May 2022 13:46:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyHl-0007p2-VY for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:46:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e96f29be-cd42-11ec-a406-831a346695d4; Fri, 06 May 2022 15:46:21 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-wsy77zbdO62-h8nUUfs_ZQ-1; Fri, 06 May 2022 15:46:17 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM9PR04MB7554.eurprd04.prod.outlook.com (2603:10a6:20b:2da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 13:46:16 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 13:46:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e96f29be-cd42-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651844780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MloX4GcdCxxi6KFR4VLPQ+Iq3sulx/22tFb9Ls/1s7Q=; b=IZKc5xz4BeszVopREj140u7WB7ipcG/SCL6llZDdLsqHjm776Upr6JPu2XsVZQPqynVttQ 10H2uQjxzTseClkZ7PJn/bA3nICqx235Le8tnquoIdQskRbMSHR04dpFoXbTiCC+MCx2+E soGpafpwQgZS42GFDzO1jEUsdpxXhDI= X-MC-Unique: wsy77zbdO62-h8nUUfs_ZQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l3W+WBnX5kJ35W6n+dTAHnIiGoaGkscwK/xZgxHQkKqZCcca1Y6IfTWcTY6Kq8wa4oKrottUKtW4Q1Juid78nN9yx9WtYyE1b41k1HeFZXCXck+0lC9RHHVHPT6sXjayb26V5rcYc8RazQx8035onL7BswabeyxSB5QIRvwbK8ycmSfA+BJNGMYJTEEqRGmEU7NO6vhJ5YvfoXwJ8w46xF4l8uzEQKjJxLGz2Qr/SUoSOjQ+7Q6YyYIJu1DyY8c/QZ3xUf0Sfc7jncI0mkegWOUONsvWI3ciW90cksORmNhwYGpubO3p0RBEPgaxxcq7nSNl5xQEt6Il0FMX7DRGJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MloX4GcdCxxi6KFR4VLPQ+Iq3sulx/22tFb9Ls/1s7Q=; b=F1UecsvkhU0/7gEkZWU+GNUwRIA/JB/mpOw1s/gi4M7vz6GvFEKo+lCxIKJ6dFKPrA1tJknquEGFiJaoK6TvMDuMlzSJejFYsagESbY6/XCnfkRAK+7xu8CL/UM7HCekpOg91Loc89MdWgEsV9RNqy5Btr1vyZEQ0aS2A+RvZ3AatWKXI+FE+t7F3SSVr5gAtJSOfVAhNCQxzua1EYlLOIQ/iSV4GtS6E/a1ixBY9tJKwBGCzJb0DcEsZsfYeottVtENeJqBMwwrodlqR5BnqDNVOESMIfhivcwI5Ikxyb+QDWQEQxQ0TIdpHH+O9PUiDdKHFVqJMGkid83t7NKxvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 15:46:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> From: Jan Beulich In-Reply-To: <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0050.eurprd04.prod.outlook.com (2603:10a6:20b:f0::27) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6ac7990-6584-4aff-b6f5-08da2f66ca9c X-MS-TrafficTypeDiagnostic: AM9PR04MB7554:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XlXAAyDaLX3uJUDYBqbrIPY1XhXvFi+fwT64VpZFgi7CyAA1yB6m6hQ56LivCFCgbkGoExLtxXUtwZL1Ev8s/mypyKy2YZKqj7sWiGhRr/wdw8ZPvbSjMkZydwRv0xwrrx2o//B+vLRHxw2LWMo7PQ+o/qrqJvUiZ5+IXdazO8wC5Tn/LrlSwjyu+TDYRjgSbYHIq9fhwmGTlNJJYiqsKAG9Gjw4XBF96PR2MbGm05o6pS2HliSYzzEXdf4J2w+9LMY0n9UpY0WHctW63+hBKZF1EtZ2GtbPyyzHbx8XrSJk+mtQnvGdYCnL3FSunJjBgGLHsmBhYb0pwekX9LJtu5J2RksRUmjPbxwITVPvJ9YL5V+h9q3khB0qqkC4+jtn3vWWtPPvF7v/+ABhTUXJiyqdejxN+p0bIzX2lskh4wCIXu+IsebIGEXR6d38Iguq59PRJekoTdDFLULMNmbbxAT4fcf6wRH17jSG52NsszuxmC1ZMKQUsiTY7sJev25G1M3Nv1Mt2OSZrAA+QJfVOfY5SYRA7lZZAs2mP29PjDkECnlK1RK7LdHg2yKWWU8obt3O9wg1Qk6tc9+nti8wfvVb5viANFGHrMp76GMLjOErvEsO5qWFTfz4jmgRgEIckVYSVba6foBJhu1NDuGyN6kDjJKEhAouDjuTNLackNX5R/rVp/YzreA88Tocf9CkT5zgoAlOfqwjKbO99H6XrGUG0rr/aGxcp5bgI36paQzJ8XHGkEp2GFcn3Nr6GYFe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(6916009)(6506007)(54906003)(53546011)(2616005)(6512007)(6486002)(36756003)(31686004)(508600001)(8676002)(5660300002)(4326008)(2906002)(316002)(66556008)(66946007)(66476007)(38100700002)(83380400001)(8936002)(4744005)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnM0cy9PNVRHWTdzdkJqSjZVUi8xN21uck81ajJ6OFA2Y1Q2RnFvYU1sUzNS?= =?utf-8?B?a2M4ZEExM0ZOeXRQamI1UXIxK0pwVXI3b3BlREo3VnI2V0xsYVQ4Rnp4VlZq?= =?utf-8?B?L1UyTmczYWxTTi9yUEdmMGZIeVpFVHJqY0t3K1pyWTVReFhWV1pKR21JVjhh?= =?utf-8?B?NkIxYWx6K0dXNTdGQ1hyOFhYM2RKcndvNkdwZng0QW9FUmZ3THNFTjBUbjg3?= =?utf-8?B?aWMvSitPdTROQ0lmd3BnSVdJWkhqY1YyUk96UnU5bGNQQXJMYkxaNUxTYlVW?= =?utf-8?B?VlRybjlaM29pYThVL1NjYnFVOU41NTgyYWU2UHJFb2J2L0h6RzMwZ3NMMjcv?= =?utf-8?B?cmVvQW9lVndIbG9acmViRnZlenFHUG5ETTFEazVod0tINGFOeDcxSzNnUitP?= =?utf-8?B?VFZaWkFWNlUrRmpiQWl5T2oyZ2pJZDFBUTFFL1hxOUFzUGViMWdVTE5uRXRZ?= =?utf-8?B?NEgyWWRWV0VxTnFqdS90MEFCRXJyYzlOMnQzc0VaQzhid3RhSnB2Tlg4NHov?= =?utf-8?B?MW8xQkxIVWhEc3ZVdHdWMXcxUUloTTdhMVc2MUhjZ1gweDVSMWxFODVxTlRt?= =?utf-8?B?dHBvbWx1eEFCMUtCYy8rK0Qwc1lZbS8rSGs1UDFiY2lBd1k4KytVQnZRcXh2?= =?utf-8?B?QzYza0xEZUtqN21rNDlPWENtYmNIZDlSd2syZ2tVQ3RDL1lLc29QSFZUWkJM?= =?utf-8?B?a3NidEI0TXRnSzFvMXR0S3QyQjdMM1dWUjlrYU9WY05OejJodmxRVHk3aHkx?= =?utf-8?B?UGpORU1VMW9LaENXSE8xVUtkdVg4cXdVd3doc3AvUkFJT3J1b2RuMkxyZHp5?= =?utf-8?B?MVVpY29zNmgwbGIyU051OHA2MzB3VXFZeDhWeVI5UlZQemQxMlhtQWc4NmxQ?= =?utf-8?B?MUJGZStkSU4weGNsWTFJM1dsSHNESFlQL044YmRnMjdIRDlLM1dTOW4wTlMr?= =?utf-8?B?QU1nbWtOZGJnWE8waWR6Z0ZzYk5yTEF5aFdGYWxBWms1MFZ4eUhxRVoyL2Zj?= =?utf-8?B?V0NVRkxFeXhpU01KYTlmWkdQbWxzdityd3Z2V2Ria1RNV21UNnJOckhadkFL?= =?utf-8?B?U25nOU5SYVh5YjRpaGMvZ0RCRWNsMzNMMTJFSjQwQ2lXTGdRRkd0OFY0K1RS?= =?utf-8?B?VmZyNjBYSWJ4aWkwWk04ZG5MbVcrN05zSU1WRmZycHpMOEI2NXNGc2o4SW94?= =?utf-8?B?NU5GQjhhNnMwSi82Y3J6c0l2aVQvay9jWmZsOEx3OWg1ZS9SZVAyRy9kRnFE?= =?utf-8?B?am83eGF5T1RiSWdRRDN5Uk1FSXZYcVg0VFFSSE5saUlNaEtQY2FtODl1VGx5?= =?utf-8?B?UmEzK0toWk5Oc3RtVlk5UkpFTlRLZHBDOURqWXJQd0F1ZUxRMVMvdXpKNTZV?= =?utf-8?B?aTZ6NlhaQjVudkl3dEJERXN4YW9pankvYzlsa0Nsb0QyKytmbXZRcC84aVFj?= =?utf-8?B?WS83QjNyK25oVGJwWHNFZWgyN0xEaGNMZ3A5alNwL04rTitQQ3JjdFp3VVRB?= =?utf-8?B?VGwrbko3cEU1L0ptTkdtLzN1RlJSVjNvczQ5M3JWaFdhYzNrZ0VGYytrZ01I?= =?utf-8?B?M0RybjhyekFzblpLOEwwNGErbnNuUXVUNS9BSnlMRFl4ZWllL1hVdWRSTTBa?= =?utf-8?B?TXY0ZE9pNmpnNFpYUmJ1QThTUG9HL2x5UFJkdktTbFBrRW1qUEo4Q1psQk83?= =?utf-8?B?NzJTNVhvWFZlZXJWUXJydGtKNFI0TElWNHM1YVJKdmZxc0ZPYW5FVktrOVli?= =?utf-8?B?WW42R0k0dVM2eFB3YmRSS252TTkzY1o5V0ovU1dXVXE2OEdWK3NIb1QzRXd4?= =?utf-8?B?TWluL0FtYnhveENOQ2gzaDhRcUJId0Z5ZEhybis5dnBoSXRuRE9aOWpYQ293?= =?utf-8?B?OHZTZHIvb1Z2ZFIyNUNON3dJRzR4MUUvakV5RzZWdDNhUnMwMnFrYVMrWVpB?= =?utf-8?B?eHZMcFVTU2JRTWNUc1dXZWRlK0tOUS9nblJQak4zVFQyZW5NUW1NVFdKWHYv?= =?utf-8?B?N0RyQWwwaEZ0cklYR08yV1FYMTdUY2VHMHRyZ1NxV1NWQzE3SnVKWW1Fa0pr?= =?utf-8?B?VlUyNXZ2dkRQeUhhSVBZc2h4Um03NFRpZFgzS1lVc0hhT3lMVldaS3l4VWdl?= =?utf-8?B?OTFleXEwVTFvZUpDKzZVQis5WitoSFNNWm54TE93U2d3OGMxTjRiNjNnQlJD?= =?utf-8?B?T1IxbFRucU9nVHhjWjJqcXFPVVVscHZvWVJMcy9ncUdpWXBnbnppekNncGVF?= =?utf-8?B?MGsrWTFQYVBwMnI5WXk3MjFnamZ0d250elNQcHAxNUFqSEcxS1lOanhZNklO?= =?utf-8?B?TlduS1F4eVBlSFFRQUprQVRhRk1TUzI3anVreVNwV3N6cEVnQ0Rjdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6ac7990-6584-4aff-b6f5-08da2f66ca9c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:46:15.9877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WWcAg5umHRjDHOLhMLrdZaFXj6BHdqUdpYSicoWQf12SGhg2f6oo9ZYGJSblTMP39oRbrf7bxhwtUKfHHWdt6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7554 On 06.05.2022 15:43, Julien Grall wrote: > You say future, has this option been merged or still in discussion on > the ML? "future" as in "no released version yet". The change is present on the binutils master branch. > On 06/05/2022 14:37, Jan Beulich wrote: >> We cannot really avoid such and we're also not really at risk because of >> them, as we control page table permissions ourselves rather than relying >> on a loader of some sort. > > Is this a preventive commit, or you have seen it in action? I've seen it in action. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 13:47:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 13:47:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323173.544786 (Exim 4.92) (envelope-from ) id 1nmyIQ-0008RX-HS; Fri, 06 May 2022 13:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323173.544786; Fri, 06 May 2022 13:47:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyIQ-0008RP-EX; Fri, 06 May 2022 13:47:02 +0000 Received: by outflank-mailman (input) for mailman id 323173; Fri, 06 May 2022 13:47:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyIP-0008A6-JC for xen-devel@lists.xenproject.org; Fri, 06 May 2022 13:47:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe99ec6e-cd42-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 15:46:56 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-_QqnlWJvNSGsYLkoLUtsQA-1; Fri, 06 May 2022 15:46:57 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR0402MB3911.eurprd04.prod.outlook.com (2603:10a6:209:1c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 13:46:49 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 13:46:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe99ec6e-cd42-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651844820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rRZMAgT/r95Dn4OiUM99nO9GHGmOz0xsBpQbOtmT7cc=; b=jR01wx3t2ysWsmS2L02FQTEMcF2QxCXLMLrvmY5w3l+rwlqj+oNebLbUn9qingB4/QIWUO EeMBLGRo0SsINnP6KcYQ+bWJkPB3mebNI4xGVcv2YIiCtASkSagUwW4vEjAmIYnw98DsAE c9WWhFJ9gpa4Ecx3v/HMp4XxjeXjUK4= X-MC-Unique: _QqnlWJvNSGsYLkoLUtsQA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ArpHw1dbewj5FdOyefUHEa8OEr0A3zGcqPcii1EQJCoEiFApT+tCMgtEDkzHK8Nxz1KLsyCBzRxVsjYQhpBt/1/DYXTqVqeT10CgM+ctaLfS7xljgzf9EG8dJFq0C2FZBiei/BpesvqypjvwW3WC+Ue4Iiu5KMN6AFVMD9uvF6LUrH302Uaxt/IKqGCvvk0wfFvIob/VBx1f35ere5/KTxkqQYpktcFf4sy9pvJXKf1HjEznfjpe0Qq35KqltavbqJKxcbHO6UGn6LS0jiypCzwWiWxFQpmydLDaElfBQ2bKtaKe+GtgcwcP9QTiJK73UjARRMVuUsd2pthNitZg9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRZMAgT/r95Dn4OiUM99nO9GHGmOz0xsBpQbOtmT7cc=; b=WIsc3FhJeBdajQ+/7LnuXR1GDfSjUq6OTH6uEowJ4fxODntPNwHhC54KlGRQU4knNKmD2tb9bmFlPz176j6E31U3gHlwElW2rSvHwO1VwXWd+dvDnmEnu7+FxmP/Bs+HeGO/f1+1OwdDvqa5TPtljRavIOFenA904FVCjeRXhizK1t7uJunOVvoOk6oMwozAlfap6N8XOf05wxdemOPs9p5jO6oBVignHDaZ+IgGEc67ui8SmtQlNloYRHlI8aF2ICc+IY3zOoMahtSX01333f0dNj6Lrw7z5bUJQYdQMtBxL+GdXZmQjL5+z2XZ6nU31cJIZXJoGLSzsse5opTHGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 6 May 2022 15:46:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] build: silence future GNU ld warning about executable stacks Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <1905d86c-6363-c6b0-97b3-beb91aca9055@suse.com> <20ab3107-a548-450c-0c2c-98be53f6270b@xen.org> From: Jan Beulich In-Reply-To: <20ab3107-a548-450c-0c2c-98be53f6270b@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:20b:f0::21) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a0b21dc6-8221-4ec4-af13-08da2f66de9d X-MS-TrafficTypeDiagnostic: AM6PR0402MB3911:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IdjDTSMO8NVrp2SBDKb4gK5iWwtnquhNhTpCYh/LTaFsp2j7eS+dn83cbsOime4y48VXNqJasSQCobiBjCqrZp3TYdhpb7daPXRoJPTZ4q9vUG7CRh8AhMNmAGbw6BAO6Mq3HBHxzXORyClDOxbx0rrAzrihzN0BaxeBX4JJVK2yZr46eriJ+kmuwj9zP388v7SnJM+nMnagTX19cUxdlR9S0I8qoOeDjqmRRxI8YLjMeFzu5Ncgfsxpbg+Tut0Qq6sPO4Jb/UhE3D/qdP9/osukHAOYnGNSASpMhNYO+T+NEDq4R5SC9VK2zHMOYcw+wWAU5lZMkqx+Nfd2aJzUtpPpWRf4V4ITbVfqBHyoBDISn2tuSem/wb5AFwf4eRfbyiWzx3uuzcp+h/72ATAnzjw+7StrYQQgegc/DWlAMgwMc9Vbcp7tGIieZiYz3VmCGcK7QPITmPNoQEI6KJoBwSfDYfzLNcFCqPg/Nrgcl/E0CsVw1hRPyANaqbymW0STHs0EmCMMITv39cHVUQm5YDAI2Trbbmg1WbJlo/P40L3jwiYnIIVDKdxlLeqzjOr2/UbWo56x7CzrQFvvncJCHU4Hci0zoBy5Y5CkrRBBP2XItcMbsGK+ekRg70v7wZHIpLZR5HwWHCsYJrInRivbs8ZYBZ9/+PYBvm6Q2X9FNmHzVpETTu9qfo+4mNeS0Pzz9THkUUBABoK+OTIdasYL8LqN6IFZjr2I1i155kFxHuFy4a+PWn0l1XeXxmlUpB9V X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66556008)(8936002)(66476007)(31696002)(86362001)(4326008)(4744005)(5660300002)(2906002)(38100700002)(53546011)(26005)(54906003)(6916009)(2616005)(508600001)(6486002)(6506007)(6512007)(316002)(186003)(36756003)(31686004)(83380400001)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzJpWFNyVlo5QzY1N2dFeGZLaElnVGhkeEhRZ3FIUHJXRVM0STNZYlNPMHNS?= =?utf-8?B?OHo0RUdxTHN4VFZRUEc3NTN0d3h1ejlFZGN5M2JCUkJNbHh4VGpwMXIzbHNz?= =?utf-8?B?UUNha1BUZVM5eHZUTG1LZTlpM3BRYjJVMjFCTWJMKzRKbW9hSVdmM3RaRy9m?= =?utf-8?B?QWFGclBUSGJheFU5YzdOeTNsOHMyNHVkRWxzRFJxNlRua3NDNkF3Uld3bmEw?= =?utf-8?B?R2dNbURyc2FyL2tMcElPLzRPYmdvRVVCaDFpQkhFOFNVamNBc2VYM3ZZL0ZP?= =?utf-8?B?bUJMcHlMcVdpeUpSNzA2Z3k4VGM0ZUMzYlhnd1Bxems0cVppTTB5Q2dGd2hm?= =?utf-8?B?Q1E1M1AxR3JjeVhsOUhHWUpGS3ZHUDdFZzc2RTZVNHJYMW1TVDcvTXVVSTRz?= =?utf-8?B?MFg0R2hsZ1BMUXBSMnArSE0xdTFZN09wek5uWTFyeE5sa1p2RTYxS2pJSy91?= =?utf-8?B?VVVHWWVaWVRWcUllZ05oZFl5Q2NTelp0RWFWdGtsTktuTURaQjk1VkhzZkVL?= =?utf-8?B?Q3UwZEVlYUY2VkZPbGNZLy9wa0xGQXZuYU00NU9zcDJOdzFuY2duRTVybThl?= =?utf-8?B?cjRGMGtTK0h0a0krd1JRdVUyUHNLVFFJNm9RZnh1RUdZUDZCQzJHcFprQUxW?= =?utf-8?B?SC9ja0o1UVZyR0lkcDQrYXQ5V2FQVjc5bjc1a1RLZ3gzUWppV2wzNy84WWh1?= =?utf-8?B?MmJrNXBkTW9JQ1pSSkYzSC9lUFo2YWpVeEFtdktmTytUTUxTSUd3Z3E0ZDdU?= =?utf-8?B?OUdyb1RWeWtiMmN2aGpDSUxxTG5iTi9ZeVBYUWxGbHhocjE3aHB0VEVONzIx?= =?utf-8?B?OWtUSTVMVnFNNnJnd2hOOFZ2YjkvU3B0L3JKWHJmSkEyeXFNUk5ZZHpDbmxQ?= =?utf-8?B?K1diRXB4cmxIME1FWU93dWRUejdja2s1ZWMvN1JYY1NmMGNZVWxxcXN5Q0tx?= =?utf-8?B?dXhmOFQveDNNQXpBaG8rMTZMMUVrd3plbGhJUEhYbVlZRWpTYVg2alMydzM5?= =?utf-8?B?bElTcEQyQ1FmQlM2ZStFa1lZK1VHREJHV0d3Um5kbnB6VXZabm51NEtLOHcz?= =?utf-8?B?aWtRRjJpUjAvMEVzS2J4ZWYyVGJ6a3lQUTBrc0ErdXh4U2JKL2M3SjlvQlp3?= =?utf-8?B?YWxHN3A0ZVVWWVlBTXRXQWVTSHZWVFJLNXkwd3dGRlNHUjZYUzJidlE0WmtZ?= =?utf-8?B?MGRxNUFHM0FiaFg1Y0RBSTRuZkt6RUJHbDU3M2pZaHZUeXJKcW15eXhrVXBN?= =?utf-8?B?UTlQRVUwVGpmYmR1SzFxM2RhNVR0RlBjQUMwNVQ2eitvN3c0NDRsUnFWc2pL?= =?utf-8?B?ZnZMbWxOSm1pK21FMithVEpBckRuc1dmQ1EwY1RMWnI5Sm52dU93VWE3T1BZ?= =?utf-8?B?QWNmWFI0d2k3MzNpODFmR21rV1BUMVFrdkRJVGVLbFJMK3U3dmdhdWgrc0tD?= =?utf-8?B?VGk0WHVWVE9DRGFFZmRqbU5KMDVWS3B6d2ZDLzJzOUN1b0lDbG5ROTFNa0Vt?= =?utf-8?B?emwzbXhQTXZ2UFJyYjliTjZjVUNyVU9IV2ZlTTBsNVJHVlhFL0FXcVV1clh1?= =?utf-8?B?SlBnMlZ4U2xtT3RBRU8zTWU4NWpsOC9rM2o2WnVYZHN4cXkzZElXWVU2MnV0?= =?utf-8?B?N0gwY0wyT0JRMTZvYVZaVGZxWS9oYmxrb1ZBZ005NzUvclZzNzg5VGpEck9t?= =?utf-8?B?Mm5jSXFVdEFob1pxWTdUM0o2MlhpRHdNNE05WUI0bnQwWnJ3YTZmSDQxdndS?= =?utf-8?B?alZUZ1lIdW5vMWRkaFQ5N21UYnJ0NHdBL3U2cjR3VzQ5eFd4a2Q5eldLdkhD?= =?utf-8?B?VWZZSE1WQVJBMnZ3OXRTd1VpMy90TitJV2NsdHpzRE5zc0p6NHMvTCtGY0hD?= =?utf-8?B?WmhiVU5uclBGcmlwREFuQ3daY0hNUDNPK1Z4R3haOUMzT2U1VWcyQytoZitT?= =?utf-8?B?eWd6TllkZGlvQkh3YlRUUDR3SUNZa0JsbWFkTGF0cmNxREtXc1BaME5JNjRD?= =?utf-8?B?Rytra0tUN3JnOTNxcGFUMmRPVnlXdWU5VURQZkVjRkFEQjA5RTVqbzZnZlpV?= =?utf-8?B?dW1ZR2xGblRCYzd4eDNVaTZkVDFLOGhsNGpkelJOTUN1Ui9YYkgveTNnaWFv?= =?utf-8?B?YjFEdWdQczc3ZWMvWTFpUWpoRTE2bVkwV2lUZlJSRm8vYTN5Wmk0RTJuZFh4?= =?utf-8?B?cFptR083UWZUMzZNTDdXS3VaQWNOOGVzN2dOVHNaZ2RTallIdkdUT0xYam9L?= =?utf-8?B?Z3hkNUowMEdHUlQ1T0x3OVBZUi85TElTaVlkOGVkUXJzYzcwRStpK2xvQm5X?= =?utf-8?B?c1NtUnBCamF5SVF0NzBrb05ZQWJxRGJ4bVZWVVhRMlJBWGFjV1Aydz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0b21dc6-8221-4ec4-af13-08da2f66de9d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 13:46:49.5954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ORr/uxOrfiB41z3o/ML9czkpQBvH7mOwXseGdh/SgHkkNgPOPJL8k1cZkvX3a5Pfa0idgPNeoT8AnS4IFmn/Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3911 On 06.05.2022 15:44, Julien Grall wrote: > You say future, has this option been merged or still in discussion on > the ML? > > On 06/05/2022 14:38, Jan Beulich wrote: >> While for C files the compiler is supposed to arrange for emitting >> respective information, for assembly sources we're responsible ourselves. > > Is this a preventive measure, or you have seen it in action? Same answers as for patch 1. Jan From xen-devel-bounces@lists.xenproject.org Fri May 06 14:10:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 14:10:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323270.544840 (Exim 4.92) (envelope-from ) id 1nmyeR-0003bd-U7; Fri, 06 May 2022 14:09:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323270.544840; Fri, 06 May 2022 14:09:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyeR-0003bW-R8; Fri, 06 May 2022 14:09:47 +0000 Received: by outflank-mailman (input) for mailman id 323270; Fri, 06 May 2022 14:09:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyeP-0003bE-Ue for xen-devel@lists.xenproject.org; Fri, 06 May 2022 14:09:45 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2bb5e424-cd46-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 16:09:40 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id e24so10200672wrc.9 for ; Fri, 06 May 2022 07:09:45 -0700 (PDT) Received: from [10.7.237.9] (54-240-197-225.amazon.com. [54.240.197.225]) by smtp.gmail.com with ESMTPSA id n10-20020a5d67ca000000b0020c5253d8cfsm4513058wrw.27.2022.05.06.07.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 07:09:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bb5e424-cd46-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YeJOWl3F+wY65E3bdK8hLOeADUm6Dg14aaKfYaDEWbk=; b=ZDhoq1mDERS27mL0qTpl6hnXBcFn1pSdwAwI29XppLx1xiAyb4TX3sartthd3Y0pNX NBiu+HZQRGZ/7y3QxyUvFltFFenTPwX/33bn4fZt75fwLNF1uCNvKu1S5QJYGOp16WVN 0Dk4JyquQUAJNRF/XNdDyKVrPpwqJ2sbGlU14xHkRexC4sfhEKKhf9g3P3GuC0AiMXwr B6JdzkKz9cZ5v6MBvP8LhpdJvtq/giP21HeajauTzR0thxkAHf1Dbo66oLZpgWfqjQDS dRkn/EmUxSQusjzrKLD/fkQNw+//FyyHirlBF4NYWvBC1f/6IbQvFX2emkKTU6i6InHM b9yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YeJOWl3F+wY65E3bdK8hLOeADUm6Dg14aaKfYaDEWbk=; b=qS7ssN/S6QxhVlHKQ3u+d1npeSv6K38t+2ztDIL97M7wmKYCgTak448s6h/zctd2GN AfSD27+FnO7q9CI45EXx9r0j3QP+g765AF80iAxgBjuT7iovGKpcNzB9pk+1n6J0e0GR QZa9g9mkhXBE3p149rma3hFoDyihR8aqevLUuk59AsdfqMbzs/6oF+ZfNjMD7/AvFS42 wXzVgB8MfmtpKKirmwmL/OeqBrvpdCxv7u7HJDscwWzcqKQDyh3wJ7N+2IqIOZxIMgpX +GgBkNpGna03aqXkGxFveWxVahsXX7VfB0YUlDY8Yr6rK6Q263RcNVohWq7yAluEeF4k W3pw== X-Gm-Message-State: AOAM532JAKKoH86ulY0xgZ11uy1mSMov6m9NPTovqEwAou3xyW3H0Hod XvdKQywpuW47bulgy/3xE6M= X-Google-Smtp-Source: ABdhPJx4ZVyywK9VkVJUQTLh1htFU+dklmVe0yjncSUImFFe0I3SW0lr8AXpYlruHChodZF4SOPMSw== X-Received: by 2002:adf:9dcc:0:b0:20a:ed44:fd48 with SMTP id q12-20020adf9dcc000000b0020aed44fd48mr2873120wre.120.1651846184543; Fri, 06 May 2022 07:09:44 -0700 (PDT) Message-ID: <2bbdb007-1a28-67ea-0801-fa471bb6e416@gmail.com> Date: Fri, 6 May 2022 15:09:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Reply-To: paul@xen.org Subject: Re: [PATCH] xen: io: Fix race between sending an I/O and domain shutdown Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220505175131.81457-1-julien@xen.org> From: "Durrant, Paul" In-Reply-To: <20220505175131.81457-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/05/2022 18:51, Julien Grall wrote: > From: Julien Grall > > Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and > resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint > where the expectation is the domain should continue as nothing happened > afterwards. > > hvmemul_do_io() and handle_pio() will act differently if the return > code of hvm_send_ioreq() (resp. hvmemul_do_pio_buffer()) is X86EMUL_RETRY. > > In this case, the I/O state will be reset to STATE_IOREQ_NONE (i.e > no I/O is pending) and/or the PC will not be advanced. > > If the shutdown request happens right after the I/O was sent to the > IOREQ, then emulation code will end up to re-execute the instruction > and therefore forward again the same I/O (at least when reading IO port). > > This would be problem if the access has a side-effect. A dumb example, > is a device implementing a counter which is incremented by one for every > access. When running shutdown/resume in a loop, the value read by the > OS may not be the old value + 1. > > Add an extra boolean in the structure hvm_vcpu_io to indicate whether > the I/O was suspend. This is then used in place of checking the domain > is shutting down in hvmemul_do_io() and handle_pio() as they should > act on suspend (i.e. vcpu_start_shutdown_deferral() returns false) rather > than shutdown. > > Signed-off-by: Julien Grall Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri May 06 14:10:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 14:10:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323281.544851 (Exim 4.92) (envelope-from ) id 1nmyfK-0004qC-7d; Fri, 06 May 2022 14:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323281.544851; Fri, 06 May 2022 14:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyfK-0004q5-52; Fri, 06 May 2022 14:10:42 +0000 Received: by outflank-mailman (input) for mailman id 323281; Fri, 06 May 2022 14:10:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmyfI-0003bK-Nd for xen-devel@lists.xenproject.org; Fri, 06 May 2022 14:10:41 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a0365cf-cd46-11ec-a406-831a346695d4; Fri, 06 May 2022 16:10:38 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id C4EBD1F46719 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a0365cf-cd46-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651846231; bh=aPzN11eOYyBmn6uYxSJ4z+OxGW0B11goKlzatjEFOG4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A5kW1JJmvHfMp+G3BYZfs1DtIoJxwTSAkQcm9HkU230sGHCbaarPy3d3ylVb7ghQK QFidNeP16CsPIu7NGef5buR6vQrZaa2Bu2Ol7ocivR52MK99+p14lZHhPhckFBadHq LWO8HGz0L5XHJgOXIl4zHum9KGrTPQ8XNRCAiPLiBFHqfgiXkDJFYnZvSeZjgWY6Sf b+r6JcWvC90AjEGx12tTLe293/2dwUtSGPf4vDeIZmmldanQoeJoRJ1W5+Zs/dm4mK YMULBdy55mQ6HS0+7WhL/7UJ3ikAvXuW+YZrNYtURWDPqYm9/aozEGozBwUb1cqkv6 H0OATVRjsYPpg== Message-ID: Date: Fri, 6 May 2022 17:10:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-5-dmitry.osipenko@collabora.com> <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/20/22 21:47, Rafael J. Wysocki wrote: >>>> + POWEROFF_PREPARE, >>>> +}; >>>> + >>>> +/** >>>> + * struct power_off_data - Power-off callback argument >>>> + * >>>> + * @cb_data: Callback data. >>>> + */ >>>> +struct power_off_data { >>>> + void *cb_data; >>>> +}; >>>> + >>>> +/** >>>> + * struct power_off_prep_data - Power-off preparation callback argument >>>> + * >>>> + * @cb_data: Callback data. >>>> + */ >>>> +struct power_off_prep_data { >>>> + void *cb_data; >>>> +}; >>> Why does this need to be a separate data type? >> To allow us extend the "struct power_off_prep_data" with more parameters >> later on without a need to update each driver with the new arguments. > I'm not really sure what you mean here. Can you give an example? > The restart callbacks use more than the cb_data and we have: struct restart_data { void *cb_data; const char *cmd; bool stop_chain; enum reboot_mode mode; }; If we'll ever need to extended struct power_off_data similarly to the restart_data, then we will need to update all the power-off callbacks instead of adding a new field to the power_off_data. Hence, for example, if you'll want to extend power_off_data with "enum poweroff_mode mode", then for each driver you'll need to do this change: -power_off(void *cb_data) +power_off(void *cb_data, enum poweroff_mode mode) and you won't need to do that using struct power_off_data. Why do we need this? Because I saw in the past people changing kernel APIs that way when they wanted to add new arguments and then needed to update every call site around the kernel. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Fri May 06 14:19:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 14:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323288.544863 (Exim 4.92) (envelope-from ) id 1nmynR-0005kP-1t; Fri, 06 May 2022 14:19:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323288.544863; Fri, 06 May 2022 14:19:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmynQ-0005kI-VF; Fri, 06 May 2022 14:19:04 +0000 Received: by outflank-mailman (input) for mailman id 323288; Fri, 06 May 2022 14:19:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmynQ-0005kC-6F for xen-devel@lists.xenproject.org; Fri, 06 May 2022 14:19:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 796b38a5-cd47-11ec-a406-831a346695d4; Fri, 06 May 2022 16:19:02 +0200 (CEST) Received: from mail-dm3nam07lp2047.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 10:18:59 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CY1PR03MB2298.namprd03.prod.outlook.com (2a01:111:e400:c614::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 14:18:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5206.027; Fri, 6 May 2022 14:18:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 796b38a5-cd47-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651846742; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ofbIHtgfD8zcGkZSLBLC5Lb0bdRVTgcAqOpyEDvh4Qs=; b=GpO5qmVsBRWNWw8YlDexNBsSOLrUVTAxdTyUU9/oNxAEJoXZk5zmGpEF 7F86Tqpv9WKK6U26O+s6jChZT3aPJyedPzoKfEb5fZMC8iTTHCeVBejYp 2oRrI21NfcWA5DhJ84rAX1xZanAxSGRuMEiRNp4CGzKCysp3wm4/ewk9x c=; X-IronPort-RemoteIP: 104.47.56.47 X-IronPort-MID: 70616882 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:txxSGal3nW8gOxQJJjAtd8ro5gyZJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIYC2CCO/fYYmH3fNoiYIvg/RlXupWAzYQwTQFqpCAxRCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW13V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSQgyP/PUg8QmC0NGMi1BOfV+5LvJGC3q2SCT5xWun3rE5dxLVBtzEahDv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kEg1/chegXdRraT +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+vJpujaDnFYZPL7FP+DXS/uFdfhsv1elq zLX2kjjLR4AO4nKodaC2jf27gPVpgv5Uo8PELyz9tZxnUaegGcUDXU+V0a/oPS/ol6zXZRYM UN80jE1saE4+UivT9/8dx61uniJulgbQdU4O/I+wBGAzOzT+QnxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoOYHQCRA5dvN37+tlv0VTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPeZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:p0A9UaMegNSPL8BcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70616882" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTjVAsQ74QbgA4kAIRpannDgUNOUNlILfsmMNX+IeSZ+cjUEcfIKIVER/uXEnlrxmhkvk9RANQ3o67m1ZBzM3SPizFAlcAyaBDWKpHkDVs+mr0peAvUM9/KkcMcbadXJNhvfOc2YvqV2P6Ebx+LCEbhwDXyYisHzTyEHDkPtYxHYVOhUpelDY0Tpo+0PXI6YPhmU74FwmEIcGkMQQXffQSslBC8XDJBK1kFYXmZoaW8rYTP8l5WZ9MEbc8S3mf1GsivWZXtZwtGebukiPwcrUDtQnCo4kX3AeuFxeIUjcG1THTCkClrfgZdaFOssHJo0ECwpwDs5bJ9Mw4jgaJ+omA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofbIHtgfD8zcGkZSLBLC5Lb0bdRVTgcAqOpyEDvh4Qs=; b=hZMcpAqVWPr2WXGgTOgjdVHEquw70NdhpYQghJ+u/Md3miT5NYioHMXpg7gElyPJEBb2EzPzi+8X3EWztL7q90kyXwr90KZ4m5Y81s2iamy78ptEY7mOBZtbSI7QJTr18vpW1i8nqxJWH+VdhKxZKdXrn+NCw5JY+TsZbbXB27zThFriYc8ygkTQOqRKORclWw+j//rQ9y5Rlyz01a2ldsCQQhNiaFlMlrsU3bSNN86j+SJlCFDwMZKKk4AWF3kqE1ffn7IMx+xJ3nt1nDbVjPPR2tna/oYgrTa2UPivufzqKviMw9f9Cv77x5E0W4YzGk+g1YLYMYe7LuICmZ9tiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofbIHtgfD8zcGkZSLBLC5Lb0bdRVTgcAqOpyEDvh4Qs=; b=wsS5gdHhYqfJw5VDHcdSldDeVDkHGb5K789f2lUmfttOtdIEpiHuYoqjxqjuzmCvbB5H2Qyt2tauvwKT2vG1ll9Krx3IKXRmyDp2outFU/7J524hZHYXHVOWmafwv1naYwu+CSDZ1SMHc3+Aetbw6c421/XS4CP4bqxEF80fKA8= From: Andrew Cooper To: Jan Beulich , Julien Grall CC: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Thread-Topic: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Thread-Index: AQHYYU55+oh7RWMLI0OTKLhiZzDiLK0R29oAgAAA1wCAAAkkgA== Date: Fri, 6 May 2022 14:18:57 +0000 Message-ID: <15d44a31-853a-5f61-2632-6e3faa7083d0@citrix.com> References: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eca4a1c1-dea6-44c9-91cf-08da2f6b5c06 x-ms-traffictypediagnostic: CY1PR03MB2298:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IDR4HVBgvmTG5riGUMJU33xS29SfFEExtA4SeGMHaxjOTcuIvV2kWT2NhHIk2KqD7q9hIBazCLSaa6uzTCMQZlrDF93yv69qNtJJSpitAIwuXZXdOGpgJtO3Sdd+MssVA+O5kRmRQDML+Yhw5GfdOl217O6TKN5fbyIDlUQGnH4YB+J5azfZS2Kyh9ZNHgY9Ff96WSMiY1wQq3DE5TvHdonyXDX7QeJlJa+E3FsKe3tOEXxEx+4eSthJTBnys9T50uInikgKw6y6i2EDZJr/Ycj4w1ildeH0VnXieH4KIj1ig2bczXtdh/vATpGwojR+82YoosG3MhPcjq3i+zFQ+p67SmthyI8Y/UdoX6eyO+iibYUmSz67msxAGcnMNvyv4R4kcD3MbuWX26dYB3zTbW6RjxF5049YQhOVtX+lqNWGW9DDZHeuMG0/Va7gpAikt7AH/yL0DOcaj4YCEAWNPiahz6wpBMbNBXdeGEgtwJ3e4vvnRKL0yFkIc6bZYd7U5SEE0z/dd1uHJSmGN8hI9ZhpOAGQEuAMLO+N4u4h1OlDYDrJPgqyzrT6fXMmXmh7x6yb8UrmuuykuG6XyPeH/WZ2ctKHpOBoHIIw5DHlejqcFpwJ7Dm1317jRAx9ytp3PuvsO29TymaDI4AWrZhTJyY8+EiXrep0ldQGd8sp/PPspmkjPBHXEwWHsXRbApYqQdmYEzt1ByJLkS70keC692i6dX5Vo1ot2uswwIEKA1twNBW85vRV9hs7eyx0meSlckd2sUkVJxHTzqxcm0ybbA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(54906003)(5660300002)(6486002)(508600001)(4744005)(2616005)(26005)(31686004)(6506007)(82960400001)(186003)(36756003)(316002)(6512007)(110136005)(83380400001)(86362001)(31696002)(122000001)(38100700002)(38070700005)(71200400001)(66946007)(66556008)(76116006)(64756008)(66476007)(4326008)(2906002)(8676002)(53546011)(91956017)(66446008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OGp0aC9Od2RrUmhwRW81N3Vyd2pZRGJwcy9sMFpQcFNWdG1ZTzZuOG4yMWYy?= =?utf-8?B?c1ZSNXA3UmVNM2dwcEk1WUVqd05ZVktITVVNUG1maWFQTWxhd0JjOE54VFp5?= =?utf-8?B?RzdVWm1JU3lkYTArSEtIOERLZHJXTkNPbVZQRlFSOEErTWphQjNZdGVkUUZR?= =?utf-8?B?VkxWMThnVDg2ZnI5VFJ0WTcrak8xN1JSaytkSXhDbHpwYmFPQzZtcFVOZmpn?= =?utf-8?B?RGdxTFgveW5ydHg1a1JzM2NRcVVyYTlJYmZkSkpMNExkNnR4akJMcDYvUVYy?= =?utf-8?B?USs2cGhlOTRLMVRSM0ZaZEh4bk84Q3FtckEvU2IzcVAwV0xwK1JrRE9rY0lm?= =?utf-8?B?M1dUNFd1WWppcHErd2M1VG43dnBndlEzV01aZDkzaWVWYlJNdDRaVG9LWjgy?= =?utf-8?B?cVhyemlobWFrZlRZK1RLcFRPb2wxVWx6dTlKOFl0RDNOYlM2NHRpWGZjMDZY?= =?utf-8?B?S3dXdmYydnp1N0ZOVG1yaVlFUTVISVRTNklibFNST1B5OStmaEp6QVBnU1lj?= =?utf-8?B?M2lWM2FvZjZDQUFoa0xYbXpvVWJQL1NUcHBYWjZ1OG5vcHdvRnlLeUpHMzlv?= =?utf-8?B?TnFINGJjejFubmc1MHVjNC9nT3M1d3JtWlBDTlltVGlEUi9qMlNIOEo2R0dt?= =?utf-8?B?bHFkc21yWFhmSVJOc2xaaHZLQ0Z4S1ZiUDJMY2w4aXhlczdHaTIrQmpZTU9F?= =?utf-8?B?TUpUV3NxR240UHBQc1prb0pQLzE2dFNOVmZUWVgrTmhjWXo2b2crcmdvZEFp?= =?utf-8?B?RkZ2QWFiYW9BSmhQTnpWbGZvSUxjQkJKcW01WHFURU1hL044czZqdW1xRE1W?= =?utf-8?B?MVo3Vm5UZmZEQmJmVkRFNUkwbFRpSnF3UW5iTjhFUnQ5OTJFVzdwVFFDd3Ni?= =?utf-8?B?SStHZkY2YnpVU2lyOTJTeHlCcU9nYjUxdWh3MUZLcFd0aU01TTMvcWFSYTNJ?= =?utf-8?B?aXljTkJKWUQxN2hRajk4VDNLTVlJMmxIZVRZb0FBc3gybWl4UTdHNnBDd2pX?= =?utf-8?B?TjE3SERsMC9NdnZ2eExBYnpIVytBRHdhLzNlY1g5VVYyQTZpcXkxMGlWWHRE?= =?utf-8?B?aGROMzlFd3Y3ZEJDbXZyaXJPKzF1a3pQY1RaUGR1Rkdsem1kMkhlZXpJYUZz?= =?utf-8?B?VXlQQWkwVEVZZ052aCtQSUkrWEFTZURYMk0rT1BuK2tUSXFvWFM4ekFqTUI5?= =?utf-8?B?cjh2M1RoWHloR0Zua3BQbTZOdlZwUWhEN3FFb25hbFZIb3A3a2l5MjYwVXN5?= =?utf-8?B?SUZRVzNaYkluNFNXREV2TG1pU0xTQk42K0ExZjMrUEtRbTJKM1hUTEZFV2I3?= =?utf-8?B?WWJLYTY5UytoaFlrZHlpQlpFeDJTZHRYOWpsN3lIN0NPeGJOWC9nM1VoZE90?= =?utf-8?B?Ly8vMEwwbHVUOUM1LzB3Y2pzaUNtcWFjQnlNQTJuZjR4alN4RU1XczBtUnFh?= =?utf-8?B?RndUQ1YrWVRXUndvbzBlZTRISlNaak5IbUovWDJZWktEaE9HZ0Y0WjFnVmg3?= =?utf-8?B?bENYNU1BSXFVR1paYUtFaWhObGtKWkhXZmJSWGNUV29xK2czUHdIMk1tVE9s?= =?utf-8?B?OUJ1bDlnUldCbW8vMlBiejRhc1J0VVhpQVY0dnNWZXB5ZVcwYWI1Y2UrNGJk?= =?utf-8?B?SFlhQk02NFJqNFcxRDd6TFplTW5EenFZdXQ5aFpKZjU1cHBJM1N3Z011TnBy?= =?utf-8?B?eisrOEJiNCs3Zy8wbTRSY0Y2TTlNcGYxRjlkM1FKdmtQbHZRLzVlMjNHN3dp?= =?utf-8?B?ZzJGbWFDcWcrREVpc0ZmT28rV0VqV0QyRkozQUFLMVJ6SjBPRXNXSUFlcWhR?= =?utf-8?B?T2ljcjZ0YmkxSGlHNVdIZE4xMGUwTnpneGh5WjhLNWdHSHJDTjNublZCNHJH?= =?utf-8?B?ejBnMkIyMGJRaEdPQ0RxZCtnSklWV0o5K3E5cXJldkNLVy9CRkpCWnZ4c1NJ?= =?utf-8?B?RU1EbFltaDdiV1R3aFJNYWZ4b0FRRVJvRUxNRXZ4a2NhanlNekRTMW1rbjdz?= =?utf-8?B?ekgzRzVPM1k4MHhaTGFoejNMMGhhQzd3SGtjZW15UEl4RTh1dE5JbWkyN3Q3?= =?utf-8?B?N2xXSDA2NCtHeDdPanNNOVFWeElXUWdVcStIdmVGTFZBRzRFa3lKQnY1Umsx?= =?utf-8?B?Nmd0VzZQUjM3T3RGNkx0MXBiWTRiTnVvc2NSb3dCSHBKbTNvYUV4MjJZV3hU?= =?utf-8?B?Z2ZvR09DbWgwYTZzdE15ZG1USkl5eWQ0aFRxSU5uSDl6ZVIzMmhoY0RlYm5o?= =?utf-8?B?QXBhcy85bWZhVFRFK1BGMXFuK3cwOVRkOENjR0plU1RYcUtTS1Y5c28vZWlS?= =?utf-8?B?UTZRVjVFRkRkSE1wT0tJWWNrNDF5NllQcmMveEN3Nm5hOWhkd2V0N0R4UmtZ?= =?utf-8?Q?JQBKV4u83Yi5I1LQ=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eca4a1c1-dea6-44c9-91cf-08da2f6b5c06 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 14:18:57.8130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: all6+EAaUEAQ2emS8U1wXTdqk5zZ4WpwqfBYb5L0e55G9/FqK+sekorZsBwHG1nXnoBRgodHJfChLRdPDtZ7iOVY2bgAZYCGNutosYRjrLo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2298 T24gMDYvMDUvMjAyMiAxNDo0NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA2LjA1LjIwMjIg MTU6NDMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IFlvdSBzYXkgZnV0dXJlLCBoYXMgdGhpcyBv cHRpb24gYmVlbiBtZXJnZWQgb3Igc3RpbGwgaW4gZGlzY3Vzc2lvbiBvbiANCj4+IHRoZSBNTD8N Cj4gImZ1dHVyZSIgYXMgaW4gIm5vIHJlbGVhc2VkIHZlcnNpb24geWV0Ii4gVGhlIGNoYW5nZSBp cyBwcmVzZW50IG9uIHRoZQ0KPiBiaW51dGlscyBtYXN0ZXIgYnJhbmNoLg0KDQpJbiB3aGljaCBj YXNlLCBJJ2QgcmVjb21tZW5kIHNheWluZyAiYnVpbGQ6IHN1cHByZXNzIEdOVSBsZCB3YXJuaW5n DQphYm91dCBSV1ggbG9hZCBzZWdtZW50cyIgaW4gdGhlIHN1YmplY3QsIGFuZCBpbiB0aGUgY29t bWl0IG1lc3NhZ2UNCnNheWluZyAid2FybmluZyBwcmVzZW50IGluIG1hc3RlciwgYW50aWNpcGF0 ZWQgdG8gYmUgaW5jbHVkZWQgaW4gcmVsZWFzZQ0KMi4kd2hhdGV2ZXIiLg0KDQpUaGF0LCBjb21i aW5lZCB3aXRoIHRoZSBkYXRlLCBpcyBlbm91Z2ggaW5mb3JtYXRpb24gZm9yIHBlb3BsZSB0byB0 cmFjaw0KdGhpbmdzIGRvd24gZXZlbiBpZiB1cHN0cmVhbSBiaW51dGlscyBjaGFuZ2UgdGhlaXIg dmVyc2lvbmluZyBzY2hlbWUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri May 06 14:21:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 14:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323295.544874 (Exim 4.92) (envelope-from ) id 1nmypS-00078G-Il; Fri, 06 May 2022 14:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323295.544874; Fri, 06 May 2022 14:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmypS-000789-Fl; Fri, 06 May 2022 14:21:10 +0000 Received: by outflank-mailman (input) for mailman id 323295; Fri, 06 May 2022 14:21:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmypQ-000783-Gd for xen-devel@lists.xenproject.org; Fri, 06 May 2022 14:21:08 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3f4ce52-cd47-11ec-a406-831a346695d4; Fri, 06 May 2022 16:21:07 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 10:21:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6223.namprd03.prod.outlook.com (2603:10b6:a03:37f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 14:21:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5206.027; Fri, 6 May 2022 14:21:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3f4ce52-cd47-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651846867; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=B9InUODRWQcDoXS0uKJOpw+7KpM44wE34j9qY1bUAr4=; b=GxgG0++qrW/6ZfL9pCkmDP6TpKO14D9nUpxErTTfjgLNhgS5wBr7IvwD fAAEqfWQUw5+QwrWEcc4lZ2qBXFlYMnUlFhrVoTZy0WUtN+hvP83IV7ON lfpj9iii6AuzrCyJ7wiE6s86b192e89aVR6Z34vZ5Y6hbLPm+QuqMCfU0 w=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 70740489 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Dc7z76mlxjEa6TstxpkvYsXo5gyaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWWTyFM/aDYGCkL4wgOdy1p0ICsJGBnYJkSlBuriEyRSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW13V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSjcOOIPDnuUmWlp2TAVsI655/7bYGC3q2SCT5xWun3rE5dxLVRhzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkBg2tYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvvDSLkFwguFTrGIXfY8GpS85vp3/Cg TrL5mL2HBdGBtPKnFJp9Vrp3IcjhxjTWogfCbm5/f5Cm0CIyyoYDxh+fVmmpfi0jGauVtQZL FYbkgI1trQ7/kGvStj7XjW7rWSCsxpaXMBfe8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHaSpaSwIAuoDnuNtq0U6JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNXNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:NFx6fau8z9b4lWnNUzOyk6fn7skCL4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP v2MI5KApbYXB7TJbo= X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70740489" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FSNJ3+nleJTjM5lOtt/CAauEzXHvBR/15wsQG66sprAYW/C7t/iJK3Zs1IzMVEjveFP+ZV5MDIgBHcM19C+mnw7YL9FSqrD2aFW6zdQcClk5+DgNQKoJJRECT2EIgyE8ULxPLrU58IrzLR1yQahIsgVyWQrQh4dexmgS3QKXUhGddLwrlye7FR2JDq2O5r8Rs1vB1Z91TGiBFvFh5d4F5Bh0lt+0SOSkNJUSDiGnMO6kUE05JSV0z86+OmgC30kIuweZ1UDLNoIfgRRWiU4Vy9Zr1ouB/Fz8yQCsa3z6wuIUMhFi05eXlccPzJWkaSQa4yIaWu1AcoODAlKRJK5L5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B9InUODRWQcDoXS0uKJOpw+7KpM44wE34j9qY1bUAr4=; b=U6sKfSLzjIHuMwhRl/A8AX2zKllbbMbz04CrR6nLCrsq75L2buleZb83itsQsLC4QxMoJ2UZcOMEYz6+lHPuHvd6MbzG3AcxZnANF+Lsmkc++LpZ6xm0Dz95wKAXhmerLBqoY9hc3bZCM2ThH2HYaExPPc9S8Wr2dyFq8NbLTyOlonr4Jkf21zQpf/r2vr+vM588XSKbydUODMjT8rLy8SQAhEGkyKPeTDK7pPpF+a+QOIlXJHam0m+dAUMyWCYuDey5hR1eOvNEfOd67p7E9bsNkRJLxZ7MBdiZPMLxVtND8TB+gDadQP/+CyjTRMznfUYdSN2vS/FWycnpHs4Dkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B9InUODRWQcDoXS0uKJOpw+7KpM44wE34j9qY1bUAr4=; b=FF+s/FzmpUrqjZBaOefMnqePTodUZSeudsjqYML0qQ85WS+XD9wPGkAxj01ydjKKpkZjLpaYJoeugxyGc4jdLU7IAdqAko00MSVxVY3gHdTk/HndodzT0pDJvrx0LYBhrZkNJn3Mfe14bg0UjYw0DeZatZklk2N971HKNJ/s8Fo= From: Andrew Cooper To: Andrew Cooper , Jan Beulich , Julien Grall CC: George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Thread-Topic: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments Thread-Index: AQHYYU55+oh7RWMLI0OTKLhiZzDiLK0R29oAgAAA1wCAAAkkgIAAAJUA Date: Fri, 6 May 2022 14:21:02 +0000 Message-ID: <5cd22d0d-768c-a0fb-b75b-0eb2c92b8c33@citrix.com> References: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> <15d44a31-853a-5f61-2632-6e3faa7083d0@citrix.com> In-Reply-To: <15d44a31-853a-5f61-2632-6e3faa7083d0@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e18a8eb-5b52-434c-c1ee-08da2f6ba65b x-ms-traffictypediagnostic: SJ0PR03MB6223:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wnUMNkKsn/KvEGU8xCvwXxWbIppM/YXHJPCxUUTv3sT/jBp9P+p8wK0lpzw+yureKirh+dBZBkD8JNOII01KCUErbvt/3uCzdq0i4i2q2AtpNq9PTI6cmHlNtNvSSbfPDOLInA13KzL7JXay+zLJcHoRjeXV2B7aFilwW0eehX4inSk0CwGP7LrSK+TBmYH/YBHvvVbrjg+qk4WY0aAqoDl2OqQFuYZpqnno4KVY9c09pQquu8GxPuHDeejZLOPl8q+210xBb6G6/k777K2QA2QbT/5KEZFqsEI8HLEGhPc00e1a9D5sUqQzuf4NmafYYbA2wi+UVyb5Ww3RSILqnV1PQMlE604mEqO2vOXHPZaxSj70Z1aYB/daaKt3d3M2MnBxkFZScyGs4N6PSVgUBW/IeEJrn/3b+QbK2PdqsP9rqQzj2dAjuaAdpGNo1lrGMXxpLO2DTyupK8K3Wg1aeFmjTrorQ1On8EWtxXo5Dl6/5oBwPR14xI7jnJK8kPnOz/E9b9kvDiHevwMGYpqVHh/pfjBqN4KWbXQZ9511+PieKZZptYcYU5YBsLiTtkPmxgEdxqCQR4Q6+YONRhhmdC78mDtXC1AuHtYLOry8m7vW/ihmOnr6L2t4mlSSRGeLwG+E71pHkSXr2lnkT6KjI9vQiP3H0rttcJKFWDu0KUSTDWRHjUNU2Zfs9Fj1YPwdLPaBSRGe5YLt8ckUvUav16G5YhN+sXJCSb5viVy6DEmyoJHT2GrXQPzmc/LOoAS7PqYr2wnZpfNu3cJDvpBF2A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(38100700002)(38070700005)(508600001)(83380400001)(2616005)(82960400001)(122000001)(31696002)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(91956017)(110136005)(8936002)(76116006)(4744005)(86362001)(8676002)(26005)(186003)(36756003)(71200400001)(6512007)(54906003)(6506007)(53546011)(316002)(6486002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WDNmNGw2SWwrZU1yR3lIY0dGdyt2Qlk1MUhJTit5YTUwMVFvRTE1WW9TQkx5?= =?utf-8?B?YlVEc1d5Y1NJTXRCZjdxVk04Z0FUcmJpQmZNSVNHUXF0ZUttbW1BcG1FR1g1?= =?utf-8?B?K3pJM09ocm9NVkZEZzlwQ3A2VnA5SHNxVlpRNUpWUTUxSjZHZHBzV3ZCK3o5?= =?utf-8?B?TnpSSnoySTVWc3NPbjE4U1pVV1BVYkxZeGtKQ3Z2SENWMlZINDBlNTFDR3Qy?= =?utf-8?B?SUc2U3dURElNbW1TUm5CZEJIUnpNMTJWQi9lYzNDZGduVU5aMmRXaHhmWWo1?= =?utf-8?B?ZVllQzFuSzE2OFRDaUxLRUtIbG9VMDdFNUxkUW84ZWFsOHg2SVlrMktYRHR2?= =?utf-8?B?eVp3UTJua3ROc3d5aFNhbnczcFhRRCtnQU5iSEVKM25hMlVha2V4S0xWdkcz?= =?utf-8?B?bm5mVTZjNHBQamZMaGsvNWxBbjRFRVpOZTVHU0JKbVh4dkQwWHh4NU1IeUhx?= =?utf-8?B?djcvdGlkeGEwUWh2a0w2bUFDankyS1J0eitjTGp6Tjh4bm5BV05nQSs4WThF?= =?utf-8?B?SC91QXJxRkFDSmhiQ3ZRczJmSGtaclhvQUtjOVk1QU5OY1U4UmtxaHlab0V5?= =?utf-8?B?VTdiQUYybTN3Q1pEVXQ1VUpzdFFHd1A5T2pZRjJ3Vkd6VzMyU3paVHhJWVlI?= =?utf-8?B?aEw0ODNzVldyZ1lTRnIzbUVuZUVzcDlaODVxOGlxRWdocUgrc2JrSnlOMENO?= =?utf-8?B?MHRXSHRJVkprendzcW0vNSsyTDRMK1Q2Tjgyc3crbXdQazdicVhBY0tnTGp2?= =?utf-8?B?aFRKeTNYRkxGWWRtZHphZDlhRUU4VTU3a2o0TWhnQzlOYnRRSW1SaHozQVZI?= =?utf-8?B?aDR0V2pKcjJ0UlR2Y0pxYWs1SnNZN08xMytRSEpueVEvNFdYM2Z5bmVqSi95?= =?utf-8?B?WHo2V1ZGVDYxbC9ialp4MUJBSkZBWTRIUExxUVNJZGljRmUvYzB6Q3JaU05U?= =?utf-8?B?UmhLOVNlVXY5NGRLZk9pd1NlMVM2aWRjVGE4MjJFeUZqVGE1MXo2aDhqZ1h1?= =?utf-8?B?eDVheTBSQkVYcGk3Z3BRNWRiMG1wbk9tNkQxUlJDOUdsNEZBZWZla245SmdL?= =?utf-8?B?MUZVNmJWY2hFdVh3S2RMa3RmT0gwLyswSTl2R2loK1Jxc3MzbGoyaXM0NUln?= =?utf-8?B?WnVnWm1zUmVoUm5vb0V1UWt5b1pMVHNWdzRKVWJTdmYyS0RydDhUYjNDTzlQ?= =?utf-8?B?ajNNR3JaQUFYc0dUMlRKVlNRbVZnTkVJeDI5ZGtHTGo2cU9aY1RvbmZuTURu?= =?utf-8?B?T05lam95TkFUQzlaakdnUXFaV0o3d2dBU2xWQVJJM1JYejZXcVVEQnZJQmRq?= =?utf-8?B?bk9sbUNoWnYrUktiYXhpWDJNWjlxRXF3RE9TSXhKNVY3S2ZkWTlabStNKzJr?= =?utf-8?B?bWMrempPTVBBdm5lc0c0TnBxU1pSZ1Mybm5sNS8xQ2pOd3U1N0ppQ05aYjZT?= =?utf-8?B?Nk11Q1Bwbld0OEQycFVkMUcyZGJCellzMmVESTQ5bDVBQWU4UU9YSDE1OXNS?= =?utf-8?B?Q1luQkZTZDNxMnF0c2xZaDJvUXVielV6d1V2Y2lBVVpnekJLYTVuN2EvOU0v?= =?utf-8?B?MzJuQkhIcmU3cElHREkwd1drVnE1dzNPWlZMYktjaDZybTJTUWowVkd6M0hE?= =?utf-8?B?WVpUUkpTYlZVNldWaTE3ZEFWVE56cnFzcTdxK1BzMWFmWFJmbTFVOE9VdjI3?= =?utf-8?B?TXhIUlZVUDhobm15eUYxbXJwaEs4ZTI3aytDY1B0encrYlduekV6d2p3NzF6?= =?utf-8?B?SXZKSnJTbVpwVll4ZjZQT3dJT3M2RkRNVkJYdHpSOFgzQVk4VHJTdjBVSDhw?= =?utf-8?B?K2VGQkRmZE80Q0FUaE5jTkZtMGVtUVNqU2h1VnNpM3ViUUNoNkZuazhsSlZQ?= =?utf-8?B?RWt6aWhoZ0ptK2NnbzZTRVlOYXJzZFdJYkFoWXJnRWxYSUFrd1ZrVlN5Ylk2?= =?utf-8?B?czNDYUYzdm1CT0FvVEcvaUVHSTZ6Q1pjeG1FNjIyMnJCMWo1SGJDZGZSVWpG?= =?utf-8?B?R0o5QkRPYmMxTnRvWmVvYk5LZCt2YXlIU0VWTTVXcnBybUNhd2pvd2k5WE51?= =?utf-8?B?RVFJWDhMSHptd3dDdkgrY2ZrQURLQWRnMy9pRUsvSUx2MTEwbXF1VGtuOE9l?= =?utf-8?B?MWtrOHpZaWpIV3htcllyOEN3MDhLZVc5bndhYnp5VFV1T2hjS1RCeVBOUHRZ?= =?utf-8?B?aWhOcmRsandDQzdyaHBRRWwwYm5TZnI4T09sb0prZ2ZJOXlleWFjSEJIOXdi?= =?utf-8?B?WktkOGtMTXkrV2JNMEMreUZhWkdaMko2TnBTRVhQUnBZWXpxN2VCelJPZytQ?= =?utf-8?B?cnFiZlhXY0FCR2p0N0MyREM5RVJpMU9jK0ZDTTFhTzBUK2U4NmJTek90aVF2?= =?utf-8?Q?CMyDAfcArZeOlrPE=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <5B9E21A608F0B947B986A27D0C1B7338@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e18a8eb-5b52-434c-c1ee-08da2f6ba65b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 14:21:02.4915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WuJ9I1ryQmsA3QxRael5ZPxmNRlU5StPGTAFz7/UanUzR3Gd2HELxpLf+3pC9o4gyVhKrxVvkWrFzsQxlr9QqOlDASQYvezc7Sp3Ujkid+Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6223 T24gMDYvMDUvMjAyMiAxNToxOCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDYvMDUvMjAy MiAxNDo0NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAwNi4wNS4yMDIyIDE1OjQzLCBKdWxp ZW4gR3JhbGwgd3JvdGU6DQo+Pj4gWW91IHNheSBmdXR1cmUsIGhhcyB0aGlzIG9wdGlvbiBiZWVu IG1lcmdlZCBvciBzdGlsbCBpbiBkaXNjdXNzaW9uIG9uIA0KPj4+IHRoZSBNTD8NCj4+ICJmdXR1 cmUiIGFzIGluICJubyByZWxlYXNlZCB2ZXJzaW9uIHlldCIuIFRoZSBjaGFuZ2UgaXMgcHJlc2Vu dCBvbiB0aGUNCj4+IGJpbnV0aWxzIG1hc3RlciBicmFuY2guDQo+IEluIHdoaWNoIGNhc2UsIEkn ZCByZWNvbW1lbmQgc2F5aW5nICJidWlsZDogc3VwcHJlc3MgR05VIGxkIHdhcm5pbmcNCj4gYWJv dXQgUldYIGxvYWQgc2VnbWVudHMiIGluIHRoZSBzdWJqZWN0LCBhbmQgaW4gdGhlIGNvbW1pdCBt ZXNzYWdlDQo+IHNheWluZyAid2FybmluZyBwcmVzZW50IGluIG1hc3RlciwgYW50aWNpcGF0ZWQg dG8gYmUgaW5jbHVkZWQgaW4gcmVsZWFzZQ0KPiAyLiR3aGF0ZXZlciIuDQo+DQo+IFRoYXQsIGNv bWJpbmVkIHdpdGggdGhlIGRhdGUsIGlzIGVub3VnaCBpbmZvcm1hdGlvbiBmb3IgcGVvcGxlIHRv IHRyYWNrDQo+IHRoaW5ncyBkb3duIGV2ZW4gaWYgdXBzdHJlYW0gYmludXRpbHMgY2hhbmdlIHRo ZWlyIHZlcnNpb25pbmcgc2NoZW1lLg0KDQpPbmUgb3RoZXIgdGhpbmcuwqAgV2l0aCBzb21ldGhp bmcgdG8gXiBlZmZlY3QsIGJvdGggcGF0Y2hlcyBBY2tlZC1ieToNCkFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri May 06 14:47:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323320.544893 (Exim 4.92) (envelope-from ) id 1nmzEc-0001Yv-Ne; Fri, 06 May 2022 14:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323320.544893; Fri, 06 May 2022 14:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzEc-0001Yo-Kk; Fri, 06 May 2022 14:47:10 +0000 Received: by outflank-mailman (input) for mailman id 323320; Fri, 06 May 2022 14:47:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzEb-0001Yi-Am for xen-devel@lists.xenproject.org; Fri, 06 May 2022 14:47:09 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 670cd564-cd4b-11ec-a406-831a346695d4; Fri, 06 May 2022 16:47:08 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id C32391F468F5 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 670cd564-cd4b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651848427; bh=utol468ApKu3UfEFy7x8r+aU8cRRwOmqk4bK/1Di3gM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jBE3ytwUGToW06KmZyXbQlLMQh11EfcrZ6bdwLxbmA9KbTMiYuuNn3kvbqh632rH2 Jgx0CZHq1E9lNHGEsuRz21D8kAvAh8rFaR8jds1ArktyMwvqKLxX4GAkX19BTWUmPP b1quvNeRnJpwzsGfRULjPmqW94UBaLvY+SdyGZ2o/bAt8UYAzh00sKV0zWBnlAl37N VELNP3WacCdMrm2dk8Vabl3yhZXLesCAV/s6oeDX+kpR+1yBykPgcYSQODD7Vr7gKd V7A6zoiXfzrqEzkhyai26Ys6RbYpjgl9Ni5GI2/IasHsLcZOIHlsySI8JROUyGnbmg dahigOUrcy3KA== Message-ID: Date: Fri, 6 May 2022 17:46:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-5-dmitry.osipenko@collabora.com> <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/20/22 21:47, Rafael J. Wysocki wrote: >>>> +/** >>>> + * devm_register_prioritized_power_off_handler - Register prioritized power-off callback >>>> + * @dev: Device that registers callback >>>> + * @priority: Callback's priority >>>> + * @callback: Callback function >>>> + * @cb_data: Callback's argument >>>> + * >>>> + * Registers resource-managed power-off callback with a given priority. >>>> + * It will be called as last step of the power-off sequence. Callbacks >>>> + * chaining is disabled, i.e. further lower priority callbacks won't >>>> + * be executed if this @callback will fail to execute. >>>> + * >>>> + * Returns zero on success, or error code on failure. >>> What's the case in which this should be used instead of registering a >>> full sys_off handler? >> There are a lot of drivers that just want to register power-off handler >> with a non-default priority and don't need to stop the chain or do >> anything else special. This is a convinient helper for them. >> >> Please note that the callback here takes only the cb_data for the >> argument, while sys_off uses "struct power_off_data". >> >> Similar for the reset of the convinient helpers. > So if there is a way to do this, why would anyone prefer to use the > full sys_off handler at all? There are couple occurrences around kernel where there is no device available for the devm_ functions, like this for example [1]. [1] https://gitlab.collabora.com/dmitry.osipenko/linux-kernel-rd/-/commit/184dfd3983e774d3cf9050dc5b4ec23a662a9551 -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Fri May 06 15:10:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 15:10:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323326.544904 (Exim 4.92) (envelope-from ) id 1nmzbR-00051b-HS; Fri, 06 May 2022 15:10:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323326.544904; Fri, 06 May 2022 15:10:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzbR-00051U-E6; Fri, 06 May 2022 15:10:45 +0000 Received: by outflank-mailman (input) for mailman id 323326; Fri, 06 May 2022 15:10:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzbQ-00051O-BC for xen-devel@lists.xenproject.org; Fri, 06 May 2022 15:10:44 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1833c0d-cd4e-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 17:10:41 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3BE091F46A77 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1833c0d-cd4e-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651849840; bh=W4lTpGoqRDp9jGpQmSeg75zdqgDSf5NBF1xaIYSJv90=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nzDQfSC0mATKPl7KMFojVZYi/BuoRw0OpfD54szXaDeylL+J+qQoXJUCJwPnICT/+ I/8Sy9s84BogRpRojC6gImDJ92xHSdZ7FPiQMJZURPxR9roLC1xtjbIKIwiggwbDrJ UyaTMJ/2JU2bfO9WoTWZ2N7xEm7TpEz7ocN5RCxlOhvhrIBNeygJsGOPczykA2dH3Y ihMVuTbEr72h1fNuHXeA9KS5RWNyWO9XvwVu/QHvJStTZHleWev97ymTDjkKKIqCsB bhqNsJtDoTgZz1cxiqs29hp9q3R5MhFc8U2fUaOt4aKqtIuVwJRIWZP1u5mW0Ypayn BRUe8/CfvIiJQ== Message-ID: <3fc21eb5-218b-f783-a7ef-f805f13c66da@collabora.com> Date: Fri, 6 May 2022 18:10:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-5-dmitry.osipenko@collabora.com> <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/20/22 21:47, Rafael J. Wysocki wrote: >>>> + void (*platform_power_off_cb)(void); >>>> + void (*simple_power_off_cb)(void *data); >>>> + void *simple_power_off_cb_data; >>> Is there any particular reason to put these callbacks here and not >>> directly into struct sys_off_handler? >> They are used internally by reboot.c and shouldn't be touched by the >> kernel API users, so I wanted to factor out and protect all the private >> data. > But they come from these users anyway, don't they? > Yes, the point is that these callback pointers are owned by the kernel core while callbacks are registered. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Fri May 06 15:29:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 15:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323332.544914 (Exim 4.92) (envelope-from ) id 1nmzt8-0006ko-3g; Fri, 06 May 2022 15:29:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323332.544914; Fri, 06 May 2022 15:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzt8-0006kh-0m; Fri, 06 May 2022 15:29:02 +0000 Received: by outflank-mailman (input) for mailman id 323332; Fri, 06 May 2022 15:29:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzt6-0006kb-Kj for xen-devel@lists.xenproject.org; Fri, 06 May 2022 15:29:00 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4016bbeb-cd51-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 17:28:59 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id A73061F46AFF X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4016bbeb-cd51-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651850936; bh=36GvcdSB/pf30ZP9RtiH75vOy9s3MxY1/p1dsQRCX00=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=j4PWvQ+KBo4etBUy0FbW/p7HgcgQKy32GPpN6vjoThFzS1+RGmcEmteL2lFd/bVBT AknDobZqw5O4tK0BEn0jni1jZ1Y8w81F2B2OWV3FF7FrvJT7Y7bQUJJnPaIFMtFHn0 reKyy4wB8Xbrn+puiesHuayZefx8p/F1dSlMuhF2rKVyTgZW8aR+4U0aGftdyXJz/m 3XXXthcoiK77QOv1j4fPfZKN7nj7ru6E9U9WMrpUGrEUEDI35YvC+Jqrddc9aKOX41 7IjiAmfXml1CMKMBOqZ8jj6SNKFVNBjY8WGAT41UAfMzpF3zkqjQi1yQ9WbfUjIX3x 36sMhgh0cdItw== Message-ID: <296e6f6f-e96d-2db1-77b9-288dc47d1b98@collabora.com> Date: Fri, 6 May 2022 18:28:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 04/20] kernel: Add combined power-off+restart handler call chain API Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220411233832.391817-1-dmitry.osipenko@collabora.com> <20220411233832.391817-5-dmitry.osipenko@collabora.com> <990621e7-9f8a-8b4a-02ec-fd6c1e1f48ff@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/20/22 21:47, Rafael J. Wysocki wrote: >>>> + spin_unlock(&platform_power_off_lock); >>>> + >>>> + if (ret) >>>> + return ret; >>>> + >>>> + ret = register_power_off_handler(&priv->power_off_nb); >>>> + if (ret) >>>> + priv->platform_power_off_cb = NULL; >>>> + >>>> + return ret; >>>> +} >>>> +EXPORT_SYMBOL_GPL(register_platform_power_off); >>>> + >>>> +/** >>>> + * unregister_platform_power_off - Unregister platform-level power-off callback >>>> + * @power_off: Power-off callback >>>> + * >>>> + * Unregisters previously registered platform power-off callback. >>>> + * >>>> + * Returns zero on success, or error code on failure. >>>> + */ >>>> +int unregister_platform_power_off(void (*power_off)(void)) >>>> +{ >>>> + struct sys_off_handler_private_data *priv; >>>> + int ret; >>>> + >>>> + priv = sys_off_handler_private_data(&platform_power_off_handler); >>>> + >>>> + if (priv->platform_power_off_cb != power_off) >>>> + return -EINVAL; >>>> + >>>> + ret = unregister_power_off_handler(&priv->power_off_nb); >>>> + priv->platform_power_off_cb = NULL; >>>> + >>>> + return ret; >>>> +} >>>> +EXPORT_SYMBOL_GPL(unregister_platform_power_off); >>>> + >>>> +/** >>>> + * do_kernel_power_off - Execute kernel power-off handler call chain >>>> + * >>>> + * Calls functions registered with register_power_off_handler. >>>> + * >>>> + * Expected to be called as last step of the power-off sequence. >>>> + * >>>> + * Powers off the system immediately if a power-off handler function has >>>> + * been registered. Otherwise does nothing. >>>> + */ >>>> +void do_kernel_power_off(void) >>>> +{ >>>> + /* legacy pm_power_off() is unchained and has highest priority */ >>>> + if (pm_power_off && pm_power_off != dummy_pm_power_off) >>>> + return pm_power_off(); >>>> + >>>> + blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL, >>>> + NULL); >>>> +} >>>> + >>>> +static void do_kernel_power_off_prepare(void) >>>> +{ >>>> + /* legacy pm_power_off_prepare() is unchained and has highest priority */ >>>> + if (pm_power_off_prepare) >>>> + return pm_power_off_prepare(); >>>> + >>>> + blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE, >>>> + NULL); >>>> +} >>>> + >>>> /** >>>> * kernel_power_off - power_off the system >>>> * >>>> @@ -304,8 +893,7 @@ EXPORT_SYMBOL_GPL(kernel_halt); >>>> void kernel_power_off(void) >>>> { >>>> kernel_shutdown_prepare(SYSTEM_POWER_OFF); >>>> - if (pm_power_off_prepare) >>>> - pm_power_off_prepare(); >>>> + do_kernel_power_off_prepare(); >>>> migrate_to_reboot_cpu(); >>>> syscore_shutdown(); >>>> pr_emerg("Power down\n"); >>>> @@ -314,6 +902,16 @@ void kernel_power_off(void) >>>> } >>>> EXPORT_SYMBOL_GPL(kernel_power_off); >>>> >>>> +bool kernel_can_power_off(void) >>>> +{ >>>> + if (!pm_power_off && >>>> + blocking_notifier_call_chain_is_empty(&power_off_handler_list)) >>>> + return false; >>>> + >>>> + return true; >>> return pm_power_off || >>> blocking_notifier_call_chain_is_empty(&power_off_handler_list); >> Thank you for the thorough review! > You're very welcome! Thanks again for taking a look at the patches. I don't have strong preferences about the names and etc, so I'll update it all in v8 like you suggested. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Fri May 06 15:35:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 15:35:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323339.544927 (Exim 4.92) (envelope-from ) id 1nmzzV-0008Gs-0j; Fri, 06 May 2022 15:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323339.544927; Fri, 06 May 2022 15:35:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzzU-0008Gl-Rr; Fri, 06 May 2022 15:35:36 +0000 Received: by outflank-mailman (input) for mailman id 323339; Fri, 06 May 2022 15:35:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nmzzT-0008Gf-8G for xen-devel@lists.xenproject.org; Fri, 06 May 2022 15:35:35 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29c60805-cd52-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 17:35:33 +0200 (CEST) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 11:35:30 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB2923.namprd03.prod.outlook.com (2603:10b6:3:11a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 15:35:28 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5206.027; Fri, 6 May 2022 15:35:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29c60805-cd52-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651851332; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=oKW6JIqzJT9l/kdrfSFk+it6IsUNY83Bc9oZcr041A4=; b=gXLYRQIpSru3S+WgUT9jWMReBspRsMMK1zPYS+rzAZqHJV3QEOCSqiqQ 15XBcFHWLw/kupGMDhFEeCBkubi5BI8iSftSoV6bzerBpQpb7n7graxyI 6/Jooz9XU8lSa7vI4GOm7zS4KFZ0H8WXmADy/fTcdXwZ4/MUBPUEOA+ha c=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 70623337 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pqXdJqmyL5ALffzoDLW484Xo5gydJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOW2jTOayKNjOnfN5zad+/o00F7J/WzINqT1Bt+SEzFCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW13V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSgEJN4OLsfomWABZKWZSY6Me8p76GC3q2SCT5xWun3rE5dxLVRhzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkBgmZYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8AzP/vFsvAA/yiQh4KbtatvxZuCmH8txkBeYq GKe+V3AV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQRFRkXWF2TsfS/zEmkVLp3M FcI8yAjqawz8k2DTdTnWRC85nmesXY0RN54A+A8rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIU9x7Z+RpDK2fCQQc2kLYHZdSRNfuoey5oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr8hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:Nuw3Wav6OYs2KDwwoAroXdIf7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,203,1647316800"; d="scan'208";a="70623337" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LG9xdNJATDhiJZeFPFcZqngwEYqsdg918F6IeiW6dYva2smqSTXwLGQxS+X5K/C08+A+M/ZnSo3dRGpdJf9zk1qw3MZmDi7VNsWw3sbxGVe5M6vemfcl8qCLLGGizQA6qHjP/cnu6gKcZGsaMEew56jkpCKTjbuXq2YXck0dwa6RBEUMIcYWY1fJXa5j+A6w4BUV4FaJZG/kBHcV/1UaCcl7/Gs0ccaF46sOaBimSSJC7gBgeisxjCtLj4y1gwVAjjr8DF3H2UKbqX12pYeC3tUjK5lo9rVUkHa6Gz5xJjkR2DEd5PxDsxE1e83ncBViWNbySzqzs+h+nwYphnc3KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PmLsG8TMb93Qe7yuPQkF7sZunb94UW5ByYTU30X0JOQ=; b=IfeyBbnslXLkUzm4b9rhszZOt6Mm3s8ZyZI/7qKZPMtDc1mYXEA768r6NW+EktzhoiF6BMGfw6NTpxAz9ZbCFCyq510rTAIpDreHOsM3HEcU1ug7wDV/+1r1dJzqtWIRgiFMt+MCVndUuBgO0KLfS6iY3SQKVvl6wsXRWPtuumKm8mX/YQWaSLBKly3lWXupA7oe0vY45IyZsceSYiYIDXvFMp6oRhJlac02C9fwqMTZ0F13w21YVyVQrFL+nppfIGH+NJe+gzb2H2gKXudBbfX0/j5wXhjC3MiNwf8TceLW9R0UEEBmAGKwuMXeXevZIDGdMCMmCgkmuzhxiCqzYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmLsG8TMb93Qe7yuPQkF7sZunb94UW5ByYTU30X0JOQ=; b=ofYod+n3a0zHPFWglSMCwedcwei72Kya4LxWbWMl6oHW/0JFBn48q/7yCrRWInWGor92RXb87DDa3KNc43YjAy6FFQSPplAUOZZ+qYTRLv4nrOs38UQWXLVbyTRO7Pc9349QZYzL9ptnoztnrEyQhSSE8as9MHIBfHki6bPA4rw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 May 2022 17:35:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Message-ID: References: <20220505142137.51306-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c8e2dec-c0d7-4d0b-73c0-08da2f760c50 X-MS-TrafficTypeDiagnostic: DM5PR03MB2923:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TVDxQvmZOtX0WWGSJCa6c2tLlFKnwrEh7KkazvzNDDGOlvsCMAHXL0gzasYPimEXoeSCSCAmRrRPgda+iuyNg4z4smq2Mna46dNvKmTykOT9S3PEc7KIeqQ0HOOwPGKhpC494p5nRam1N5k3dii7v+mPDy2e8B78nC16o5Wk0UJn0tSu5BwRHDhiR2RATbHzxX/tBB8CSB29C9IiNIobYFDkKTK1tkGIcftn9tnLnnl2gEJRuAcmuTfqLNOLRQC0breeS3w25uFjSXxgVBmxaxnuH73fa3DZYHmV64q9gfqyZKQrrBbSrGt48Lu1sSAF+aQrt0MaRIPutWbAX4he0B+OlimvZu3I4BR9P5NN+Ul1kNUCy70nCVYbwknd6w7AufSgM4JJnj5A7zr5gUTBNoAfwDWPyMPBCY/gu5tOg7/+prcGqrLJ3BEZQ09IKkaMBKfauxE3gKy4erUAbPGX4GaZpD5rsHZkbVPt6WcOWZd22zZuNDlW19Y3+zDs7gB9Z167RMbN1R3Kqcmr1kXnp49cyQMLfE3OB1Eo6ICOZzcoXc1KUhHVIFO8AQknJfdty8+4W/GdH3HpYrOMOnmvTxUUYkmXQiVCsONFr/OGBWwrDx7yXj72x71BiVVEO7rFpft+2x4tkqxTqiftBUrxx2No/e1E6v6NNgTxwBnD+680PPMctJPwqLy+A1nMcDya/Jmo/C5WOdewPAcpVRA6sY4raN4NsJsmfnFVHlCkIxrQ6Do6E1PDkRQQsdSVlWCCg6xQ62fO80SSMVUgvTz+aEASCAi4scslbJUSSvOnszQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(66556008)(54906003)(6916009)(66946007)(66476007)(316002)(8676002)(86362001)(4326008)(33716001)(8936002)(53546011)(6512007)(2906002)(26005)(85182001)(38100700002)(186003)(9686003)(6486002)(82960400001)(508600001)(966005)(6506007)(6666004)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG81djhYemZBclpkdHZvMmRTa1VoZUVFY0krN3BmU2xkbmZOa2pFRDFyS3By?= =?utf-8?B?Y2I2S1pCWUVoeElvMHV3ckt0TlhzY09mOEJTZXFJZlMvWVV2UXFSeThOVnVl?= =?utf-8?B?ZkZ5ZXFUS1Nrb0c0UlB2SkhWNWozZUZRd1lPZ1hJN2RzbUR6ZkVhQTFZNTVV?= =?utf-8?B?MVNobkR5R2pUbnlydmZwUGwrWXovajBpdVhSeTdOaWk2eTE2KzVBTTRBVUNk?= =?utf-8?B?TjBLb3NZNUFuU0JzOHF6SFhmenAxNk5uWTM0V0lmSEdSUnl4ZXQyMDBhRHFo?= =?utf-8?B?eGZDdXFiSmZHa0NhZ3QwTHVQUDdISjdiT1YyRWlwYU5TLzBzSWhDVld1cUdR?= =?utf-8?B?VnZzUlloSWVra1ExNHdrNm9pOG9iL0FYOEJpSEExQklIeW5sb3hWWlJJRmJP?= =?utf-8?B?OTcyTklSMERDUFVhMmY2YVdvbUF2bTFvWnRqTXdyWlh1WkdoT3dibFE2YWg1?= =?utf-8?B?SS9YVW9JMnZoRERDZFkzWXhSbGd2a0o5ZUJOZzZqRTVwUmE0UXVNR3NQeU9m?= =?utf-8?B?SzRGZ2p0bFNFNEltT2lxNGloSWJIMldVT2VzcVZnMXN4dklCUW1HTURWWDVk?= =?utf-8?B?c2haRTFtWk0rNC9wdFFVMGhOT1JBbHVWT3A4RmxUNmxuTGF2S2M1ZENBZDEr?= =?utf-8?B?Tk8rVFhvTHFSOUxURUYyYk5vMms4Q0lqRmJ5c3dtM09hajZia1R1NG1vVmIy?= =?utf-8?B?Yk9aaVpRdnZiV0hvM2ZsZXFPTGQ1eFVXWmNCczZKQWxhZko3S3lMRW1TSlJm?= =?utf-8?B?NG1hQjB5NGZhZlR1eFQvWHBXTUkrR3k2UytPbHJ1MmFYeldncXZEbU5TN0VX?= =?utf-8?B?QnVlNTc0eG9DNGZXN0Irb0RmeDRadENpNWpYYXNKQm9kUFZqTGFYOXBZc1FD?= =?utf-8?B?VW5oT3VrRjNZRTY0K2d5OUVtd1FsbFN1QlBNME1SZGhGK1FJR1R5b3BNMFZT?= =?utf-8?B?cDRCbmdGK3FIaGh0RVVUb0dXWWRQYVFHbm1icUVCOWNxM1hmWUJaZ0c0b3JO?= =?utf-8?B?RUxnZ3lNN1pEbnZocklyaU42VXREMGRtYzMvUzRzNERZVTA2MCszZEo2VGc2?= =?utf-8?B?UmRuaUtnTWx5aVUyNGpGRU1qZ1FvUis1c0JqdE0vdFp6REVwT0JsaVNkdm8z?= =?utf-8?B?WkoydlNiWHFaNFhQcmVvRWJzSGlqdVdqWCtXVDZqMzFHYVZXY0J0OTJObWc4?= =?utf-8?B?OHBBeU43SE9TeGNiTDZwS1Q2eVFHL2RsdGRvbHVCS0Q1T0hnVXl4Vk95ZVll?= =?utf-8?B?K0pzNWVQem4vVURPZUlYRVo2RFprRGo3QWY2eDJyNXMxQ2dOaGV1ZDY3ZVhO?= =?utf-8?B?OG9Pc3lKQy9xVU00YzA4M2xNMkNJYUdnNlRSY25pbmVKb0VXajEyckV5ZEVV?= =?utf-8?B?UWdMUDhTY2pWNHZqL01PdERiK09yeHFqb2F4WkUrU1R0RXIyTmdGRmVvSlRZ?= =?utf-8?B?MnNMaklUSjljUEdyVlZ3bklwb01uT0svVjUyTnJmcUE1VTlsMEZidCtUcnEw?= =?utf-8?B?dmtneFR6TERXNVBRNDhtN1BMUm9COFZnNEdpMTNTWFdBQ2g1MU85MEFMUUFo?= =?utf-8?B?blpIMEtQTTU1UzdJOGJVR3R0WSt4d1JsK1B4OWh5QmxGSEFJajdtaWxheFlL?= =?utf-8?B?T013dFc3eDAremR5QmEyNU1kdkhTNUF1enhwZ0Z1dVlSOWZMRkZMYmd3Mjgv?= =?utf-8?B?cnlLUXpNWWc5RXh1VW1KNXk2MXdOam9PMWRnanBCWm93MWxFRFl4dzBRWnhG?= =?utf-8?B?WEhZUURacG5YR0xLYmFZVHpjZmg5V0ZsMkppaFRlemNyTUFFQkFjYXU1TmtG?= =?utf-8?B?ZUR6Rmg5dVFqd2svUlM0c0N4UW9sMEY3YkVxVU5zMXdSdGFTZzZvcVY0bU9i?= =?utf-8?B?ZENzMElPTExmSFdLOUUvTVQvdy9OMjFYL2dLanJ5SElYRTN3TnJOY1B0RnBT?= =?utf-8?B?S1JhZ3Y3djYvVnF1MVdkUWpxRkp3ZWd5K1pqUFpkRktVSzdHeEpLSTZnb2Ju?= =?utf-8?B?Wm1TVUhkZ2FubWVQTWF2bVlHUFc2MEl5aUUxc1hyRlkrT1p5ZksxYjJEcVlm?= =?utf-8?B?V2FDTGVvMENPbXVuQUtyS3JIRjg2ZDA4L1BtOTgxa3dkOUtWVlFSTCs4Q0dN?= =?utf-8?B?M1lFTEsxeEtXbzFZVmFNNkFhNFhvVXhkZ1RHRTczWnEwODRYNkwxbG80c0NH?= =?utf-8?B?UHBKL1ZOY2s0YnRWVzdVdDRTWkVxYURXSzN1ZnRtRWpWK2p2SUpmK1g4bk1p?= =?utf-8?B?b1haekVBWGpUeUg2cjRmazhMb3BucGNqdG00NndHUTVpVmVSN0I4c2Jab2pr?= =?utf-8?B?cVB5NmxMUGxKY3BlbXkzRVoyWkdVZEVPUS9RdHhEV2dwYTBCYVBRbXdJNTJ5?= =?utf-8?Q?WvTXI20QKSFE6/z8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8e2dec-c0d7-4d0b-73c0-08da2f760c50 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 15:35:28.7310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: huadGEemcS6E35yYakzJoYU6Fjx3UG0LvNUkPl72hN9cce147FN7Glm8J/h9yYX+CY+vkQ+swOEf+pb/HyiHgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2923 On Fri, May 06, 2022 at 03:31:12PM +0200, Roger Pau Monné wrote: > On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: > > On 05.05.2022 16:21, Roger Pau Monne wrote: > > > --- a/xen/include/xen/compiler.h > > > +++ b/xen/include/xen/compiler.h > > > @@ -125,10 +125,11 @@ > > > #define __must_be_array(a) \ > > > BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > > > > > > -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE > > > -/* Results in more efficient PIC code (no indirections through GOT or PLT). */ > > > -#pragma GCC visibility push(hidden) > > > -#endif > > > +/* > > > + * Results in more efficient PIC code (no indirections through GOT or PLT) > > > + * and is also required by some of the assembly constructs. > > > + */ > > > +#pragma GCC visibility push(protected) > > > > > > /* Make the optimizer believe the variable can be manipulated arbitrarily. */ > > > #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) > > > > This has failed my pre-push build test, with massive amounts of errors > > about asm() constraints in the alternative call infrastructure. This > > was with gcc 11.3.0. > > Hm, great. I guess I will have to use protected with clang and hidden > with gcc then, for lack of a better solution. > > I'm slightly confused as to why my godbolt example: > > https://godbolt.org/z/chTnMWxeP > > Seems to work with gcc 11 then. I will have to investigate a bit I > think. So it seems the problem is explicitly with constructs like: void (*foo)(void); void test(void) { asm volatile (".long [addr]" :: [addr] "i" (&(foo))); } See: https://godbolt.org/z/TYqeGdWsn AFAICT gcc will consider the function pointer foo to go through the GOT/PLT redirection table, while clang will not. I think gcc behavior is correct because in theory foo could be set from a different module? protect only guarantees that references to local functions cannot be overwritten, but not external ones. I don't really see a good way to fix this, rather that setting different visibilities based on the compiler. clang would use protected and gcc would use hidden. I think it's unlikely to have a toolstack setup to use gcc as the compiler and LLVM LD as the linker, which would be the problematic configuration, and even in that case it's kind of a cosmetic issue with symbol resolution, binary output from the linker would still be correct. Let me know if that seems acceptable. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 06 16:17:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 16:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323346.544936 (Exim 4.92) (envelope-from ) id 1nn0dj-000536-Qd; Fri, 06 May 2022 16:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323346.544936; Fri, 06 May 2022 16:17:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0dj-00052z-Nr; Fri, 06 May 2022 16:17:11 +0000 Received: by outflank-mailman (input) for mailman id 323346; Fri, 06 May 2022 16:17:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0di-00052t-62 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 16:17:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0dh-0002Yq-F8; Fri, 06 May 2022 16:17:09 +0000 Received: from [54.239.6.185] (helo=[192.168.5.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nn0dh-0004f2-8S; Fri, 06 May 2022 16:17:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4PsJ2p8gl2WRLAkuRh83cgXpd+XbhZBgagZHQm4qswo=; b=mQacDNdgs+8dxE2FZ6j6gJ61fm hqUPczqLF9K4Z2m2rFFwKk7N0+5Wp1p502rT0+GCw6EoBkJlSTVltHo4m5v3Ds420w4TXqlLZCgbO IRpPR6vCn0WyAP16Z/O04+HSSyeonoyaioNnDF2Sao3m0sOS0l/9IFhghEeqsYowSRtg=; Message-ID: <96d997d5-d4ea-3db4-c331-0813a0af3907@xen.org> Date: Fri, 6 May 2022 17:17:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen: io: Fix race between sending an I/O and domain shutdown To: paul@xen.org, xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220505175131.81457-1-julien@xen.org> <2bbdb007-1a28-67ea-0801-fa471bb6e416@gmail.com> From: Julien Grall In-Reply-To: <2bbdb007-1a28-67ea-0801-fa471bb6e416@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/05/2022 15:09, Durrant, Paul wrote: > On 05/05/2022 18:51, Julien Grall wrote: >> From: Julien Grall >> >> Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and >> resume a domain (XEN_DOMCTL_resumedomain). They can be used for >> checkpoint >> where the expectation is the domain should continue as nothing happened >> afterwards. >> >> hvmemul_do_io() and handle_pio() will act differently if the return >> code of hvm_send_ioreq() (resp. hvmemul_do_pio_buffer()) is >> X86EMUL_RETRY. >> >> In this case, the I/O state will be reset to STATE_IOREQ_NONE (i.e >> no I/O is pending) and/or the PC will not be advanced. >> >> If the shutdown request happens right after the I/O was sent to the >> IOREQ, then emulation code will end up to re-execute the instruction >> and therefore forward again the same I/O (at least when reading IO port). >> >> This would be problem if the access has a side-effect. A dumb example, >> is a device implementing a counter which is incremented by one for every >> access. When running shutdown/resume in a loop, the value read by the >> OS may not be the old value + 1. >> >> Add an extra boolean in the structure hvm_vcpu_io to indicate whether >> the I/O was suspend. This is then used in place of checking the domain >> is shutting down in hvmemul_do_io() and handle_pio() as they should >> act on suspend (i.e. vcpu_start_shutdown_deferral() returns false) rather >> than shutdown. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Paul Durrant Thanks! I have committed it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 06 16:31:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 16:31:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323353.544952 (Exim 4.92) (envelope-from ) id 1nn0rS-0007Sq-1q; Fri, 06 May 2022 16:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323353.544952; Fri, 06 May 2022 16:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0rR-0007Sj-Uo; Fri, 06 May 2022 16:31:21 +0000 Received: by outflank-mailman (input) for mailman id 323353; Fri, 06 May 2022 16:31:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0rQ-0007Sb-SN for xen-devel@lists.xenproject.org; Fri, 06 May 2022 16:31:20 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4b4d7b1-cd59-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 18:31:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 80B7F61FB9; Fri, 6 May 2022 16:31:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EEF1C385A8; Fri, 6 May 2022 16:31:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4b4d7b1-cd59-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651854676; bh=fqSe8gBcsjumhyxaOhPZoyaVhRLo0kUXBBdD3j0zYdY=; h=Date:From:To:cc:Subject:From; b=dmUfhjsDKvRAvpiKXqtSwwF9HcBhmx6+a/CNOLTbt6UWJ6Jj8NgRE0KTJVeTliybg aeHncVtOFmfXlJVN4DzS5wgPdhf4RwJz8lfkRzWdJGBohC4qvB93411uHbyNAOhNby WwkZevH677cQpGYxDeq/MBk8TGgL+vw37rL8iqZWdKzmXIHtAogMEdVUjAgD2fzkI+ gFhu6fP4mWr9mrvDFMMLmqgyyV0EiIVXNhTtkPohz/AqsctBHLZqqpU2McTFUrbNpb xM11A9oujEd3h7TaLQPpU4Za/p/Aa+eSKfjWWq5qsRkjgXwws0sd6s8RMIRsAbBxmT jwfMMvGnzu9MA== Date: Fri, 6 May 2022 09:31:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: jbeulich@suse.com, andrew.cooper3@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, roger.pau@citrix.com cc: sstabellini@kernel.org, george.dunlap@citrix.com, Artem_Mygaiev@epam.com, roberto.bagnara@bugseng.com, xen-devel@lists.xenproject.org Subject: ECLAIR Xen x86 results and progress Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, Roberto kindly provided the ECLAIR x86 results: https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ Click on "See ECLAIR in action", then you can select "Show 100 entries" and see all the results in one page. As an example MC3R1.R1.3 corresponds to Rule 1.3 in the spreadsheet. If you are OK with this, I would like to aim at a follow-up meeting on Tue May 17 at the same time (8AM California / 4PM UK). If the date/time doesn't work, I'll run another Doodle poll. By then, I am hoping that the group has already gone through the first 20 rules in the list, up until Rule 8.10. Is that reasonable for all of you? Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Fri May 06 16:37:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 16:37:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323359.544962 (Exim 4.92) (envelope-from ) id 1nn0wr-0008DL-Lj; Fri, 06 May 2022 16:36:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323359.544962; Fri, 06 May 2022 16:36:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0wr-0008DE-J0; Fri, 06 May 2022 16:36:57 +0000 Received: by outflank-mailman (input) for mailman id 323359; Fri, 06 May 2022 16:36:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0wq-0008D4-Tp; Fri, 06 May 2022 16:36:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0wq-0002t8-Sh; Fri, 06 May 2022 16:36:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn0wq-00059C-DA; Fri, 06 May 2022 16:36:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn0wq-00040B-Ca; Fri, 06 May 2022 16:36:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5Rp1yYtIdbU/qOdxj7CHomy8iHwziKg2unMM7N+Svhg=; b=P1qWx468apNdsy2J4jfSCAUesy vq8Kx6REJBleHUOC1ceMC7HbJIPknffi/MCDx1isKub/jJtJfWI4vSa4fN7kMvvT7mJxHyQIoFww9 7fjBSZIbsrC17LfHkV+M/LOR2n3pCkokzFhayasthSCf/u5XQpOkq2Wk4RZpF2yVwIF0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170184: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 16:36:56 +0000 flight 170184 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170184/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 842 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 16:54:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 16:54:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323368.544973 (Exim 4.92) (envelope-from ) id 1nn1DL-0002Fn-7g; Fri, 06 May 2022 16:53:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323368.544973; Fri, 06 May 2022 16:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1DL-0002Fg-59; Fri, 06 May 2022 16:53:59 +0000 Received: by outflank-mailman (input) for mailman id 323368; Fri, 06 May 2022 16:53:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1DK-0002FW-7H; Fri, 06 May 2022 16:53:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1DK-0003Bp-3E; Fri, 06 May 2022 16:53:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1DJ-0005oY-N4; Fri, 06 May 2022 16:53:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn1DJ-0006Zw-Mb; Fri, 06 May 2022 16:53:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yjW/oXuffs65CVamawEq/oSoSyoBs4i1DxQwiKxM/eo=; b=wxittoO+LH/dwWT3yKereyQFBt 1yRGQ9phLx4unI/+DqqQkyP3Q9rlHDGXJMph5mmXzpL2Bw9AOsiS6oKYLDd3RwN3E552qkBC/4Ryu GZkEg9zem0N7AYUSVEfLzKvcwLd5j4rDh+hsuXKVF/NcD7bY/8gfhTxoc9F422Q8G+NE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170183: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef98495a165030636e43627b3d7351e7b6f66004 X-Osstest-Versions-That: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 From: osstest service owner Date: Fri, 06 May 2022 16:53:57 +0000 flight 170183 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170183/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ef98495a165030636e43627b3d7351e7b6f66004 baseline version: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 Last test of basis 170153 2022-05-05 15:01:43 Z 1 days Testing same since 170183 2022-05-06 13:03:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90ba9a2da2..ef98495a16 ef98495a165030636e43627b3d7351e7b6f66004 -> smoke From xen-devel-bounces@lists.xenproject.org Fri May 06 17:03:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 17:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323376.544985 (Exim 4.92) (envelope-from ) id 1nn1Mn-0003qn-5Z; Fri, 06 May 2022 17:03:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323376.544985; Fri, 06 May 2022 17:03:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1Mn-0003qg-2R; Fri, 06 May 2022 17:03:45 +0000 Received: by outflank-mailman (input) for mailman id 323376; Fri, 06 May 2022 17:03:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1Mm-0003qW-4b; Fri, 06 May 2022 17:03:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1Mm-0003Nn-20; Fri, 06 May 2022 17:03:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1Ml-0006Nr-JY; Fri, 06 May 2022 17:03:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn1Ml-00026W-J8; Fri, 06 May 2022 17:03:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1Y0avDMosTDDTg+R0lmCy6oWHyoRBKzJ3+4bHkWHOK8=; b=JsJSKDLm0HcmQo3UWTfsXT8g9d 6b/ld83LQNX6RiD5X1XkLI1fs7kCG+50Av3BaXHPM8UbokEA6x7P+RGDHPx/qQQtKGvY7gtX//5fB gxD+6UBCuZUE6Az9AlXVHNhEug+ex27hTjMmyQHqAgkwuH2ZUctJey537K69iZOr9yIk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170185: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 17:03:43 +0000 flight 170185 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170185/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 843 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 17:38:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 17:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323384.544995 (Exim 4.92) (envelope-from ) id 1nn1uV-0007YR-Pa; Fri, 06 May 2022 17:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323384.544995; Fri, 06 May 2022 17:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1uV-0007YK-Mx; Fri, 06 May 2022 17:38:35 +0000 Received: by outflank-mailman (input) for mailman id 323384; Fri, 06 May 2022 17:38:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn1uU-0007YE-Cf for xen-devel@lists.xenproject.org; Fri, 06 May 2022 17:38:34 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5922bb68-cd63-11ec-a406-831a346695d4; Fri, 06 May 2022 19:38:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D10D0B837AA; Fri, 6 May 2022 17:38:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7033C385A8; Fri, 6 May 2022 17:38:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5922bb68-cd63-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651858710; bh=PdofVy+N2MvzwjYD9Y32SXkQB0aeH6rkr1uWhj5O6Pw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=J6meZLCrtgOz9ikIG2RdqJTIJUCk7OrzRf0RvRFQ0UAVUjNN19rs0JiDlEWTbSPIJ MZc2KuHGvNn8KUJBkwp7l0E+HQ7IpE3l0CVseI4smQ9R3Eu8OhwjUV8OIiDDydqlRn 9+pzD34BiEY4AoUqLQeNbGLTxU7tBoVtQJUCaUluW1lkfkU4EC7D2SqO3f8vK0hYYK dP8qbGaSzqk0XUfgBtdcql+jUzt3f0QLRVNe8+8HmEXztK5rIG0bEMgWJ+fyFX5rj9 MWauye+y6KPanPTWp/tzTDX3qSsjbGV+R+oyLIuZ0Vr1slJwOIxZGHp82ojkO63lXf 1VTKAY9v3PNAw== Date: Fri, 6 May 2022 10:38:29 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: Luca Fancellu , xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Dario Faggioli Subject: Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time In-Reply-To: Message-ID: References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-5-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Juergen Gross wrote: > On 06.05.22 14:00, Luca Fancellu wrote: > > Introduce a way to create different cpupools at boot time, this is > > particularly useful on ARM big.LITTLE system where there might be the > > need to have different cpupools for each type of core, but also > > systems using NUMA can have different cpu pools for each node. > > > > The feature on arm relies on a specification of the cpupools from the > > device tree to build pools and assign cpus to them. > > > > ACPI is not supported for this feature. > > > > With this patch, cpupool0 can now have less cpus than the number of > > online ones, so update the default case for opt_dom0_max_vcpus. > > > > Documentation is created to explain the feature. > > > > Signed-off-by: Luca Fancellu > > Reviewed-by: Stefano Stabellini > > Reviewed-by: Juergen Gross # non-arm parts With this, I think the whole series is ready to be committed. I would like an Ack from Dario/George for the minimal changes to sched/ kconfig and sched.h. From xen-devel-bounces@lists.xenproject.org Fri May 06 18:00:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 18:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323390.545007 (Exim 4.92) (envelope-from ) id 1nn2FI-0002Lp-Ht; Fri, 06 May 2022 18:00:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323390.545007; Fri, 06 May 2022 18:00:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2FI-0002L8-FC; Fri, 06 May 2022 18:00:04 +0000 Received: by outflank-mailman (input) for mailman id 323390; Fri, 06 May 2022 18:00:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2FH-0002Dg-QH; Fri, 06 May 2022 18:00:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2FH-0004Nz-My; Fri, 06 May 2022 18:00:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2FH-00081b-AB; Fri, 06 May 2022 18:00:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn2FH-00041b-9X; Fri, 06 May 2022 18:00:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ys45iMHCskLMrjT1gCcW/KP/AD3IYUuMJZROfr7OEbc=; b=crWi5uF3V0a8kC1DhKG4yKsi11 nw7oc5U9nMEalkLJ9sqmH2dl1FQW33VwK4xQYP5zjFfc4Pt5hpugeSyvGjHga6AYNkicTOU2r+AqF IhTSWYNU2qATsqxOucs5v5JQIcSnUX+f5iB2gU/hLilbwqqW3guwAIrkGrvlAw3JIFEI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170187: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 18:00:03 +0000 flight 170187 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170187/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 844 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 18:24:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 18:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323398.545018 (Exim 4.92) (envelope-from ) id 1nn2d0-0005D6-EZ; Fri, 06 May 2022 18:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323398.545018; Fri, 06 May 2022 18:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2d0-0005Cz-Bh; Fri, 06 May 2022 18:24:34 +0000 Received: by outflank-mailman (input) for mailman id 323398; Fri, 06 May 2022 18:24:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2cz-0005Cp-94; Fri, 06 May 2022 18:24:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2cz-0004mj-4W; Fri, 06 May 2022 18:24:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2cy-0000J6-UB; Fri, 06 May 2022 18:24:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn2cy-0002rW-Ti; Fri, 06 May 2022 18:24:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7WZue8VIiVUCeC5Tfkvu1hLzvlkimk2IriN6PT3xu4Y=; b=6dT1IR+FRWv1opts0bJ9ldr4Gw 7B+iVudjmCeTM0hX/SGYfGvW9RJbnHYRoYr0ZnDyB6rDnSWE+7nAYkTSyxO3RTcUUr3bTrAjOrQvf Lq7azDsztwQtxp4HeVvGg5XvZcEHi+kjK8NmrUxQKRrPlmVwwSh7+cB9CTEC0X4oVj4w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170173: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=fe27d189e3f42e31d3c8223d5daed7285e334c5e X-Osstest-Versions-That: linux=0f5d752b1395e777ef81e28886945e5e939b7c8a From: osstest service owner Date: Fri, 06 May 2022 18:24:32 +0000 flight 170173 linux-linus real [real] flight 170188 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170173/ http://logs.test-lab.xenproject.org/osstest/logs/170188/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 170188-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170158 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170158 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170158 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170158 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170158 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170158 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170158 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170158 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux fe27d189e3f42e31d3c8223d5daed7285e334c5e baseline version: linux 0f5d752b1395e777ef81e28886945e5e939b7c8a Last test of basis 170158 2022-05-05 19:09:54 Z 0 days Testing same since 170173 2022-05-06 06:43:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Brian Foster Darrick J. Wong Hector Martin Jonathan Cameron #for IIO Krzysztof Kozlowski Linus Torvalds Marc Kleine-Budde Mark Brown Matthew Wilcox (Oracle) Rob Herring Ulf Hansson # For MMC Vinod Koul jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0f5d752b1395..fe27d189e3f4 fe27d189e3f42e31d3c8223d5daed7285e334c5e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 06 18:36:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 18:36:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323407.545029 (Exim 4.92) (envelope-from ) id 1nn2oK-0006sO-O1; Fri, 06 May 2022 18:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323407.545029; Fri, 06 May 2022 18:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2oK-0006sH-KJ; Fri, 06 May 2022 18:36:16 +0000 Received: by outflank-mailman (input) for mailman id 323407; Fri, 06 May 2022 18:36:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2oJ-0006rr-B7; Fri, 06 May 2022 18:36:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2oJ-0004yH-7o; Fri, 06 May 2022 18:36:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn2oI-0000h5-TI; Fri, 06 May 2022 18:36:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn2oI-0000Yn-Sq; Fri, 06 May 2022 18:36:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=biYzrm5aLPpt1ypsITEG6SBQwCUfX2g0y7QOAHwvb48=; b=54OhYCmCXtghA33u/l5KQMyZZ/ xtWYY5nDZz+2VSJ60WZo9+Ll3Ar5Xpqs/voD41IAw+LjVmT1JwmXvxxDGQYi7q/Epkujno3BJSm3t xrnBbfYMv4fYIiL/JEP7EpbRc8Tqx5553E/ySdlmXhzQsMOWciKODRhEEj+eqZTWpGgI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170189: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 18:36:14 +0000 flight 170189 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170189/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 845 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 19:20:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 19:20:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323415.545040 (Exim 4.92) (envelope-from ) id 1nn3Up-0003sc-0O; Fri, 06 May 2022 19:20:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323415.545040; Fri, 06 May 2022 19:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3Uo-0003sV-T5; Fri, 06 May 2022 19:20:10 +0000 Received: by outflank-mailman (input) for mailman id 323415; Fri, 06 May 2022 19:20:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3Un-0003sI-6h; Fri, 06 May 2022 19:20:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3Un-0005jR-3F; Fri, 06 May 2022 19:20:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3Um-0001pq-Nc; Fri, 06 May 2022 19:20:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn3Um-0005QX-N1; Fri, 06 May 2022 19:20:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0NDK1HVzaGYbwIk5e+epVO5UJYda/nle7bq+iIUy0Lc=; b=2lDY2YDNfOoxD78ECSzsJGpP2M c/253RznC1zFspmDH8/Txcdsn2OiUZG8M73X71D3pFHRL3LxffcLz9zxEBLG16hz17dR03VVau5Fm K4aMBI/B7FJFpgelwEKlFu5EdtWW4LMlfEmASKcBOV/HwSc3+U53hYh5FMGspGSDoOG4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170179: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug xen-unstable:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 X-Osstest-Versions-That: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 From: osstest service owner Date: Fri, 06 May 2022 19:20:08 +0000 flight 170179 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170179/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 22 guests-nbd-mirror/debian fail pass in 170164 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail pass in 170164 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 170164 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170164 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170164 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170164 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170164 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170164 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170164 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170164 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170164 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170164 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170164 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170164 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170164 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 baseline version: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 Last test of basis 170179 2022-05-06 09:53:58 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 06 19:40:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 19:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323423.545051 (Exim 4.92) (envelope-from ) id 1nn3nt-0005YS-Mh; Fri, 06 May 2022 19:39:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323423.545051; Fri, 06 May 2022 19:39:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3nt-0005YL-Jm; Fri, 06 May 2022 19:39:53 +0000 Received: by outflank-mailman (input) for mailman id 323423; Fri, 06 May 2022 19:39:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn3nr-0005YE-7s for xen-devel@lists.xenproject.org; Fri, 06 May 2022 19:39:51 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 495c7f4e-cd74-11ec-8fc4-03012f2f19d4; Fri, 06 May 2022 21:39:49 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 May 2022 15:39:45 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN3PR03MB2403.namprd03.prod.outlook.com (2a01:111:e400:7bb1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 6 May 2022 19:39:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5206.027; Fri, 6 May 2022 19:39:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 495c7f4e-cd74-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1651865988; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bZzx+L6wGo6YelnL7p14XuNDn14mIwZ+1GirtjQfpbc=; b=LWmhUAp4LZksRAiJGEuj1zb3tMmuDi34De5tMnv4/7q0wmCdAr41mW37 pHplW2i2Edw0leWOUJvvLOLDOnXrfENxNeTLJbm84rRWvPG6nvdQ2ygEw OOUYRp1jiGrMkkDBQNG7ZpFm3GMH6zyNDk4Mnt7GuJi3TO9JDPYTGimPE Q=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 70640969 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:01xS96P2puEBVDfvrR1BlsFynXyQoLVcMsEvi/4bfWQNrUp33jBSz jAfCD+GPvfZZGv2ed0iPI6zpk0H78KEydA1TAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2tAw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl ZIXj7uiZVkTGILmgcQ4SklESh5TFPgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHP6iCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IA9g7N9PRmi4TV5A9Y9LLWa/3LQfWhedp5gHmZ9 2Ts7U2sV3n2M/Tak1Jp6EmEnfTTlCn2XIYTEryQ9fNwhlCXgGsJB3U+V1G2vP24gU6WQM9EJ gof/S9Ghaov8E2mSPHtUhv+p2SL1jY2VsBMCeQ85Eeow7DN/geCLmEeS3hKb9lOnOYsWTEv4 XqYkNroCCJHvaWcTDSW8bL8hSm1MyUPMWhEbyYLSwIf6vHpvY4ogxTACN1kFcadntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJjPZ/S3SV2Ohqw98OoisYtXy7UCBtKkbaoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhknTKu1Gq7ooQPUX XI= IronPort-HdrOrdr: A9a23:tei2RK3JyLr6X8t2nXXArAqjBetxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+ UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/ 6uJZM+OY6XEVfT X-IronPort-AV: E=Sophos;i="5.91,205,1647316800"; d="scan'208";a="70640969" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yba9JUjsHoLa5Pr7cOZ9/P+8BjEp5HxvnRzdjoLNIwk8Cq7Jl2Fx3346Tpz4vYS5jhrzCU9B4KwxAQH/2XDfvhZltwr4etKMy1byaGvxUnqLz2Pi8e3DMbHmqOK8lIFQ1CRHZtrz7rDgGk9AOdUatY5aoB2fCQtSTjlv3ppMxYdaMh2PuYZ+sljJWsABmP7sEOQYY/0El/4hJ7+goS2qkRr16HrNjx2+5PRvvAJwChnq7O8IE073QicoKD4lE4dwsU6XRhq3pbRJjK3JcfvWKSmjOD6Q2tsk6OKgcHGuK/8i3RReSg3OCyRLV6GMOe/vVNUdppyfVYDw44o5ux88nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZzx+L6wGo6YelnL7p14XuNDn14mIwZ+1GirtjQfpbc=; b=AkfZ4MztxpQrIXMuzwBseri0gv2MqgrszZQyP7F1kvHlKSl1G2A/om6zmd7CiDdeVsYyDAKeGyMFedUa1YN8ldpXE4DuRDYkQnzfkg1DcTfkjUBMXvjHo0Bqrr6pOXl20gDnMZKBudpL8+8uiqNr43vJ4zF2f3cGVdwgO+4LgawhNhKWHb62/gjzyVgbrcnpaCOOYoHZLhrvEf0hSnnOGWJJ3S7LJqRrXYsmV0eU7W/4iB9HnRpP6Q0K1TOhQl61vv8XWJ+PlgmrSe44Et23zZJlguy3FJGQPgIlTIXSi6sx+4H+yKWmLgN5alrD8s/1nGfqUgoDS7tToHuhmOwFxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZzx+L6wGo6YelnL7p14XuNDn14mIwZ+1GirtjQfpbc=; b=Gis0sOJYgnDrKZL7Re+QRcvQs5tsqLuxuopztXIQFiOsbdXBi2xkycm+TiCTzXxxc/+pnRR46L9Zasi1P1vVgC4YFPVJ11SME0Gf9jq8tbQFhTn+Zvpakal5uZC9jlJjxYRz28jPvQEVR3mh/nZG45Wx5m/h0/xw2pMgwDzJEPs= From: Andrew Cooper To: Stefano Stabellini , "jbeulich@suse.com" , "julien@xen.org" , "Bertrand.Marquis@arm.com" , Roger Pau Monne CC: George Dunlap , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" Subject: Re: ECLAIR Xen x86 results and progress Thread-Topic: ECLAIR Xen x86 results and progress Thread-Index: AQHYYWbKxDkd+3tW3E+LoQLYc1h9j60SP0GA Date: Fri, 6 May 2022 19:39:42 +0000 Message-ID: <659c5058-1404-01b5-63d7-48c33159dc48@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 540d611b-ab32-44d0-88d4-08da2f982abf x-ms-traffictypediagnostic: BN3PR03MB2403:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0yXIfSjZJsZCtluO8w7l3o72z+j/Z/m6kB87tkqZDrzXk8uXkvHnvYJna5p8hUg2/jZe2hvVIxthOu4HeO+/3dZhPtdL5SMub30qcmWUiWls0XmyvLIr/8vj/q9UbaQ78sFBjjkLSeSD+o1SEleIrAqtvMtV33XeS+dWa4ah/mJMV9oqrmZwRpjT91G+jI3tslNNFIVqpReRsKm+b4fjd0s0lsJMvv1vPe5zyY4+ejRRIKr9pziT5mA+iMkEDR35lDD0/jEsMIOzRpDrz+uYIGGO9DkYW3m6GqdYQrByycLsJBUPg6bnBWA3PS+IXtWLqghwdylAm7ARwCg+m2X7SSpvT1YhyjYvMrQkhPY0+A005Lla2QrhSBygKYmqKlx0H/wYPnSQty4ndWTw3gQFSOmH8zpJZbp74Fmnj7UHq+obDq/1Hiev5peB2T7mCejOzGfFmucE4g9+p5ownEKQxrPmfm/iE3BLN8YHWoK0yW7ykA8TkbbhKM9sK81SiubAgtZOAyO2BAGFXO7u12w0/L7335NF46UiDH31xfIcwnQD1a3RnIc35COauHDQXD+/JZC87pFPJ+AV5ZW0ZhPujA8Q1SkkiPU+VfSUIMkzpUK9JAcN2yOdEvaSF/KsNLyoizO2ngVKegm5k7MK29XHU6qzTr0SZ+Hud6beCQQqYgAWtzIQ3vX+SjqtjAknk+oOKVdugOTrVVfHiNhn9mNWCBn8ejK/cuU7eTsXegM5/5wEQqfXJ60Ko8s0L9KObsr0NFSeoOf5SrGnBBIUMVipvixrqE3JlByEjaSKDpal143GmTfM0o4HQR0i7bk0jSr1+nNozIjMKs+t5+Vrp+blFLuaEplXCCfwygltM4qYO10= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6506007)(83380400001)(53546011)(966005)(6486002)(2906002)(186003)(31696002)(6512007)(508600001)(26005)(5660300002)(2616005)(86362001)(54906003)(110136005)(36756003)(316002)(66556008)(66446008)(8676002)(4326008)(64756008)(6636002)(66476007)(76116006)(91956017)(66946007)(31686004)(122000001)(38070700005)(38100700002)(82960400001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VXdOWDlTTlVaNitJclpxVXZ0eUs0WStCTHlhQmlVcFp5b0RSSWNiTDNxMmFv?= =?utf-8?B?V08vbkRKcVFIRWcramIxZ2paWUdWZUdDejFXV2NPSWhnOHZmY0R3NXdrbTNG?= =?utf-8?B?d2dUdG5sRjBpZVJOYlZKZmpSNUdpOENhWnVaM0VqVCtTY2tLNmZpeEJIbUxz?= =?utf-8?B?MDd4bU5IRi9talVUd1BZRldMRm5VN0RGQmhCc2FiSm9na3hYTUkxaVEwWnR2?= =?utf-8?B?aEw0UWZiVDV5RkdNSEd6TlZSYVdlMlR1eVlhdFNRWFFZcnBNUjE1SW9rMmRR?= =?utf-8?B?V0thVWFDcTFLaGlEN1RPcHk0YkYrWk10aEphNm80QTRmczZkejlvdG55cXdK?= =?utf-8?B?bzZ5S3VkN2Y4emZmSTMvK3VqbEdsWUU1N3NFQmVGSmNuWkxDS2l4RlNrZG5L?= =?utf-8?B?aTZlZGR4U2JBemYxY3Z2alR3eXRPSnhyN0EzU2N3SFBEZGt0SHB2Q3Q4SURH?= =?utf-8?B?MDhBbmh0RWU0RnpYTVlhTFA0SWNSOG9YdGJKKzVVVlk3b2E5N3BVN3JSczhG?= =?utf-8?B?LzFkWXppWWxEdHVSNG1wZlFKWVVPOGI3MzZsc1NsOWdTQkdIQjBmSnlFeElE?= =?utf-8?B?UFdUQ0xqeVRYNU9tM0RjU1U0T1J0WFY0dVBkS1pKUXFtWUlySS9wbVRUSnVn?= =?utf-8?B?TEMwNTdvUzg4eUhNQlYvcWJnUU1Fci9vaU1PMHpVTzZ3MlZWQ1NrRUNDcWJt?= =?utf-8?B?MWlaNmVOYWRDSDNNVnRkT1ZjN3Z6aEhsa01GMVp6VkZBd3N3TGk1WCs2cVF1?= =?utf-8?B?STdNRWNoaDV3NGxWMHlRS2Eyempsa0p6RUpEZGlqenpQK2RTN3VSYUpvRVg2?= =?utf-8?B?aTh1dlp5cmVHL2pvcVVJK1E4Z1ZBcFkra2xtSlNNQVNEZ2lqdW0wMGlocWFx?= =?utf-8?B?ZlBHWlZXOHJvQWExQ1lsWHR2TnhCdnJTa2pWSUNIcWhiSnNIMDZrcFlWRys0?= =?utf-8?B?R0dEb0pFYlB1aWZZVC9uWit6dmVHcHVWTUtTWVNxSWVZNk94NlUyQ2F2MGY3?= =?utf-8?B?QlBzWjFCcUhiSk11RE0wUDB0SmdFTzBBa0syeUZXY2FjWjR6ZnEzNi9YTm5p?= =?utf-8?B?UWd1bjRUcHh0NDFBNFdCVzh2ZjkzUm05bUFjVEtBNUxkczdta2xsRkhNSEND?= =?utf-8?B?SW9FeUNaR3VlUUR0OXJzdVFWU2xEU0JRTHl5UTY4MEJ6aVZmQ04zVXcxMDNu?= =?utf-8?B?V0FzKys2aW5lNTFFVTNnSFNFRWNiay9jR25xSVIzY2xscnMwcDRWOU1TOFVs?= =?utf-8?B?OHJyN2U5anE2K21xdFdFOCtMcU4vRWJiUkg3SDFCUDF0ODcyMDljNERoVE1U?= =?utf-8?B?QmdJQSttNzlPSWNHUkZuTSthVFZucElRam93bTlPSGVKamQ1VG9mYXJBSmh4?= =?utf-8?B?REcwanBPYXFGbjVOTmlxdlRSaUlaNlJCM1Z1STd1aURZRG1KclNpeWRKSUc0?= =?utf-8?B?a2wvOUVXNnBtY0VxMmp3emd1VHFmTDR4clQwaFFSanVTb3dTdnBtVERpdS9T?= =?utf-8?B?RCs2MFFGYkNrOEVRbmM3VWNic0c5eEs5V0ZXdmRaMC92QjdGTU5DdnYzL1pZ?= =?utf-8?B?MVJMK1pPM3BQWWd6dERvWXJBZXpXeUNaUE50dnFtZkI3VVdnZDAwOEtTcHcw?= =?utf-8?B?TGpPSGxOcmp6cVhKMTNUTi9ST1Y3K1BITWs0c2lXQ1BZeTErTFpxbGdveUli?= =?utf-8?B?NHZZQUM4OElWSXppK3QrYlQwYWFZR005MFd5Tlg0OUpIU0NwZWZ2VlBFQ09u?= =?utf-8?B?clRaSUM2RDJhZWRVT1c1MzdoVlBHdnozUHZQc2JwMXpKcXBJelYrR2Ird29w?= =?utf-8?B?b0dIb1hIcmZCSDlpS2ZrMnhIeXZKREVteFQ3QmhvSVAwbm9NUVZDT3JWNkF5?= =?utf-8?B?OEV6UUJ1d2VseXFzK1FoUEFIQ2MxN1pZa0RQY2QwTHR6bnpmTGhWTnE1QUxn?= =?utf-8?B?TU01QlRrR2I4ZTM1aFhQQm1wY2tKMjVlRU9Nc2lUSE9Xb1lIVHVKRUR4dlly?= =?utf-8?B?Zjd0WUJnVTFNczJxcWp5bVVRblNOM0lMN003aXNFNFoybG5PRE5kelRDNG53?= =?utf-8?B?OGxNS294MjR0MHg3MFVWQWE1dXhBbUxMTjhISVVPNFNGcVNKSC91dHRBU3Ez?= =?utf-8?B?UllWT0xZZlVJZHJSOUU1T1A3ekgyaHBPMVdId2JXYjh1ekVDUHd4cVJyZ3pz?= =?utf-8?B?Q2phQ0t5VVJDU1lkSDUzV0RoTVpZVlkyVUlMcUFpNUQzc3hLTmhtckRGanQw?= =?utf-8?B?c2NnTlUzdHZuQmZQNEx2eTlidWVkMmFCV2ZOY00xdUFlTy9yamtCQmZDSE5X?= =?utf-8?B?bEdsY2VvUHVYcHJUWFBwTFFOYlg4SHlvMHBZQnlFUHhoTnlOTGxjVjlsSDl5?= =?utf-8?Q?By+5UakoiRwwHsxU=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 540d611b-ab32-44d0-88d4-08da2f982abf X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 19:39:42.4607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JSs59cySmkkK67MF61tDN6nkDBpm7ndPhbbZRLw00o+NeRMd/x7w6C/PiY3G3KMJZ1u13gnpnG/ZkqyESWz9xVquu++tZ2fYUOR17nuefHM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2403 T24gMDYvMDUvMjAyMiAxNzozMSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBIaSBhbGws DQo+DQo+IFJvYmVydG8ga2luZGx5IHByb3ZpZGVkIHRoZSBFQ0xBSVIgeDg2IHJlc3VsdHM6DQo+ DQo+IGh0dHBzOi8vZWNsYWlyaXQuY29tOjg0NDMvam9iL1hFTi9UYXJnZXQ9WDg2XzY0LGFnZW50 PXB1YmxpYy9sYXN0U3VjY2Vzc2Z1bEJ1aWxkL2VjbGFpci8NCj4NCj4gQ2xpY2sgb24gIlNlZSBF Q0xBSVIgaW4gYWN0aW9uIiwgdGhlbiB5b3UgY2FuIHNlbGVjdCAiU2hvdyAxMDAgZW50cmllcyIN Cj4gYW5kIHNlZSBhbGwgdGhlIHJlc3VsdHMgaW4gb25lIHBhZ2UuIEFzIGFuIGV4YW1wbGUgTUMz UjEuUjEuMw0KPiBjb3JyZXNwb25kcyB0byBSdWxlIDEuMyBpbiB0aGUgc3ByZWFkc2hlZXQuDQoN ClRoYW5rcy7CoCBTb21lIG9ic2VydmF0aW9uczoNCg0KMSkgRDQuMTAgInVzZSBoZWFkZXIgZ3Vh cmRzIHRvIHByZXZlbnQgbXVsdGlwbGUgaW5jbHVzaW9uIg0KDQphc20vcDJtLmggbGFja3MgaGVh ZGVyIGd1YXJkcyBhdCBhbGwuwqAgYXNtL3NvZnRpcnEuaCBoYXMgc29tZSBkZWNpZGVkbHkNCmRv ZGd5IGxvb2tpbmcgbG9naWMuwqAgVGhlc2Ugc2hvdWxkIG9idmlvdXNseSBiZSBmaXhlZCwgYW5k IHRoZXJlIGFyZQ0KcHJvYmFibHkgbW9yZSB0b28gaW4gdGhlIDU3IHZpb2xhdGlvbnMuDQoNCkhv d2V2ZXIsIHdlIGhhdmUgZmlsZXMgbGlrZSBwdWJsaWMvZXJybm8uaCB3aGljaCBhcmUgZXhwbGlj aXRseSBkZXNpZ25lZA0KdG8gYmUgaW5jbHVkZWQgbXVsdGlwbGUgdGltZXMsIGFuZCBhcmUgbm90 IGdvaW5nIHRvIGNoYW5nZSB1bmxlc3Mgd2UNCmhhdmUgYSBmdW5kYW1lbnRhbCBzaGlmdCBpbiBv cGluaW9uIG9uIHRoZSB1dGlsaXR5IG9mIHRyeWluZyB0byBtYWtlIGENCnNpbmdsZSBzZXQgb2Yg aGVhZGVyIGZpbGVzIGZvciBhbGwgZW52aXJvbm1lbnRzLg0KDQpBbHNvLCBFY2xhaXIgcmVhbGx5 IGRvZXNuJ3QgbGlrZSBob3cgd2UgaW5jbHVkZSBDIGZpbGVzLsKgIFRCSCwgSSBkb24ndA0KbXVj aCBlaXRoZXIsIGJ1dCBzb21lIG9mIHRoZSBoeXBlcmNhbGwgY29tcGF0IGxvZ2ljIGV4cGxpY2l0 bHkgZGVwZW5kcw0Kb24gaW5jbHVkaW5nIGl0c2VsZiwgdG8gYXZvaWQgY29kaW5nIHRoZSBoeXBl cmNhbGwgbG9naWMgdHdpY2UuwqAgVGhlcmUNCmlzIGFuIGFyZ3VtZW50IHRvIHNheSB0aGF0IHRo aXMgaXMgZGlmZmVyZW50bHktbGVzcy1iYWQgdGhhbiBvdGhlcg0Kb3B0aW9ucywgYnV0IGl0IGNl cnRhaW5seSBkb2Vzbid0IGhlbHAgd2l0aCBnZW5lcmFsIGNvbXByZWhlbnNpYmlsaXR5IG9mDQp0 aGUgY29kZS4NCg0KMikgUjYuMiAiZG9uJ3QgdXNlIHNpZ25lZCBiaXRmaWVsZHMiDQoNCldlIGhh dmUgb25lIHNpbmdsZSB2aW9sYXRpb24sIGFuZCBpdCdzIG9ubHkgdXNlZCBhcyBhIHJlZ3VsYXIg Ym9vbGVhbi7CoA0KSXQgZG9lc24ndCBldmVuIG5lZWQgdG8gYmUgYSBiaXRmaWVsZCBhdCBhbGws IGJlY2F1c2UgdGhlcmUncyA2MyBiaXRzIG9mDQpwYWRkaW5nIGF0IHRoZSBlbmQgb2Ygc2hfZW11 bGF0ZV9jdHh0Lg0KDQooSW4gdGhlIHRpbWUgdGhhdCBJJ3ZlIGJlZW4gYnJvd3NpbmcsIHNvbWVv bmUgaGFzIGFwcGFyZW50bHkgZG9uZQ0KYW5vdGhlciBidWlsZCB3aXRoIGluIHBhcnRpY3VsYXIg Q09ORklHX1NIQURPV19QQUdJTkcgZGlzYWJsZWQsIHNvIHRoaXMNCmhhcyBmYWxsZW4gb2ZmIHRo ZSBsaXN0IG9mIHZpb2xhdGlvbnMuKQ0KDQozKSBSOC4xMCAiaW5saW5lIGZ1bmN0aW9ucyBzaGFs bCBiZSBzdGF0aWMiLg0KDQpXZSBoYXZlIDMgdmlvbGF0aW9ucy7CoCBPbmUgaXMgYSBsZWdpdGlt YXRlIGNvbXBsYWludCBpbiBzcGlubG9jay5jLg0KDQpUaGUgb3RoZXIgdHdvIHZpb2xhdGlvbnMg YXJlIGZyb20gZXh0ZXJuIGlubGluZS7CoCBHaXZlbiB0aGF0IGV4dGVybg0KaW5saW5lIGV4cGxp Y2l0bHkgZ2l2ZXMgdGhlIGNvbXBpbGVyIHRoZSBjaG9pY2UgdG8gaW5saW5lLCBvciB1c2UgYQ0K c2luZ2xlIGNvbW1vbiBvdXQtb2YtbGluZSBpbXBsZW1lbnRhdGlvbiwgSSB0aGluayBleHRlcm4g aW5saW5lIGFsc28NCm1lZXRzIHRoZSBzcGlyaXQgb2Ygd2hhdCBNSVNSQSBpcyB0cnlpbmcgdG8g ZG8gaGVyZSwgaW5zb2ZhciBhcyBpdA0KcHJldmVudHMgdGhlcmUgYmVpbmcgZGVhZCBmdW5jdGlv bnMgZW1pdHRlZCBpbnRvIHRoZSBmaW5hbCBiaW5hcnkuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri May 06 19:54:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 19:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323429.545062 (Exim 4.92) (envelope-from ) id 1nn41b-0007oQ-UQ; Fri, 06 May 2022 19:54:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323429.545062; Fri, 06 May 2022 19:54:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn41b-0007oJ-Rd; Fri, 06 May 2022 19:54:03 +0000 Received: by outflank-mailman (input) for mailman id 323429; Fri, 06 May 2022 19:54:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn41a-0007o9-NO; Fri, 06 May 2022 19:54:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn41a-0006Hc-G6; Fri, 06 May 2022 19:54:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn41a-0003xg-7Z; Fri, 06 May 2022 19:54:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn41a-0006M4-75; Fri, 06 May 2022 19:54:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5fqoSG+iqWyV0ppMTa9DugpfctjRaecd+/MVM55xDpk=; b=JQS65gted9wCaWPbudjAItGwp4 vMG9ZxsBsXld0vpJvMprN4auA8FwU+zdNG6EnUUdj4CwflrYOKhUHb4WpOQvQbxFE2NdZsCaHl6Tf kiokkyVTc3qTRciwQ3Um4anJvHEdk0EaXMbEOtpauo1Vx3RX3N4IrqXYv2XdkcwNfo04=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170191: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 19:54:02 +0000 flight 170191 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170191/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 846 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 20:04:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 20:04:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323436.545073 (Exim 4.92) (envelope-from ) id 1nn4BT-0000vl-Tk; Fri, 06 May 2022 20:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323436.545073; Fri, 06 May 2022 20:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn4BT-0000ve-QE; Fri, 06 May 2022 20:04:15 +0000 Received: by outflank-mailman (input) for mailman id 323436; Fri, 06 May 2022 20:04:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn4BS-0000vU-RG; Fri, 06 May 2022 20:04:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn4BS-0006XS-Pc; Fri, 06 May 2022 20:04:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn4BS-0004P6-5r; Fri, 06 May 2022 20:04:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn4BS-0002eg-5L; Fri, 06 May 2022 20:04:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b7Ni8fuxHXtdRc13hSKfWCnIB4S45XBUpFghcw/rCms=; b=Sqta/uHq+y8hHAyd+ndelO4Fu+ ImgVy92obZ5TQJC4mKAvZLl3OYgzFixRG3EbhMcqCw+LziR4NNcX+ppXL3Dl4Fc9pOhcDtdmXZbwh nZRYTqeIqwPsMa/hSP9kD4mMZq6uwgROIz7d6/GaJRXCKYUr7imVACNVzLL1aau2qCT8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170186: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b7e0d8978810b534725e94a321736496928f00a5 X-Osstest-Versions-That: xen=ef98495a165030636e43627b3d7351e7b6f66004 From: osstest service owner Date: Fri, 06 May 2022 20:04:14 +0000 flight 170186 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170186/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b7e0d8978810b534725e94a321736496928f00a5 baseline version: xen ef98495a165030636e43627b3d7351e7b6f66004 Last test of basis 170183 2022-05-06 13:03:06 Z 0 days Testing same since 170186 2022-05-06 17:03:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ef98495a16..b7e0d89788 b7e0d8978810b534725e94a321736496928f00a5 -> smoke From xen-devel-bounces@lists.xenproject.org Fri May 06 21:32:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 21:32:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323445.545084 (Exim 4.92) (envelope-from ) id 1nn5YZ-00012r-7s; Fri, 06 May 2022 21:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323445.545084; Fri, 06 May 2022 21:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn5YZ-00012k-4s; Fri, 06 May 2022 21:32:11 +0000 Received: by outflank-mailman (input) for mailman id 323445; Fri, 06 May 2022 21:32:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn5YX-00012a-Et; Fri, 06 May 2022 21:32:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn5YX-00080O-DF; Fri, 06 May 2022 21:32:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn5YX-0008EZ-2U; Fri, 06 May 2022 21:32:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn5YX-000606-1Z; Fri, 06 May 2022 21:32:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=38vjSPm0lI49yZT+ZOmBrUdd9EDTHJbK7omFvGfKPUY=; b=t8eTVROMCKiIIwMjGQe+hGLPNd b1+UfMvsGV4b9gi5AM+q1jGI6JrmZntOheVhAQXpdUedLXMz4CUz6D7Z/2E3wScPNmzIsAvWkfKW9 +Bm/JqK7jO0hkWf7tvyfar0zuRAEr+U1e6k+bO/BWC8Lyj4ysroV7S03GMtEZKCArPw8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170193: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 21:32:09 +0000 flight 170193 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 847 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 22:49:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 22:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323455.545095 (Exim 4.92) (envelope-from ) id 1nn6lO-0007xF-6J; Fri, 06 May 2022 22:49:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323455.545095; Fri, 06 May 2022 22:49:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn6lO-0007x8-2T; Fri, 06 May 2022 22:49:30 +0000 Received: by outflank-mailman (input) for mailman id 323455; Fri, 06 May 2022 22:49:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn6lM-0007wy-Se; Fri, 06 May 2022 22:49:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn6lM-0000rH-Qo; Fri, 06 May 2022 22:49:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn6lM-0005HT-CI; Fri, 06 May 2022 22:49:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn6lM-0002SV-Bq; Fri, 06 May 2022 22:49:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/09fGqvxBcTvbxrEF0i+aL/S8xSRw9ubD6x82SmITzk=; b=zlUcfrRi9bO+QreOPXoYXF1VH7 80DqvkS6/Xs+22dV2VJC0/4ZAOklEha1s/ZNn6vzxn8LrwSY3IdDr9qcqTqLtYkIMGCgVQMa2DAIn MDNt5+zA/7lSc3gWhVQefbpolXRZ3ArfDbNMRfq5cYJeBLsJL3RwrwQ4lPvQp9G3RtEg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170194: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 06 May 2022 22:49:28 +0000 flight 170194 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170194/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 66 days 848 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 06 23:28:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 06 May 2022 23:28:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323462.545106 (Exim 4.92) (envelope-from ) id 1nn7Mr-0003e4-2i; Fri, 06 May 2022 23:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323462.545106; Fri, 06 May 2022 23:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn7Mq-0003dx-WD; Fri, 06 May 2022 23:28:13 +0000 Received: by outflank-mailman (input) for mailman id 323462; Fri, 06 May 2022 23:28:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn7Mp-0003dr-U9 for xen-devel@lists.xenproject.org; Fri, 06 May 2022 23:28:11 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30cc2703-cd94-11ec-a406-831a346695d4; Sat, 07 May 2022 01:28:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 45231B82164; Fri, 6 May 2022 23:28:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BB3EC385A8; Fri, 6 May 2022 23:28:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30cc2703-cd94-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651879688; bh=KCQPANVlV8BdVwg187fEpKXPCJ98yJE+CsBSs6LdDZw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TURlB6bsCpMNjJhJYFYtVqjtnzh2DzazZYVfE1okJfksVF27tDCPwx+FGAmh7NsaD AlJ4js28JDet2tjAEs8EDZ04aHZM57f5oM+Pi9mpdFVavNJUOuKeEMZh0wmKD/sZ8S URjcRNBe89t3ivOiebDY4nhSoRBUUZtX3vKxHPzgma7kVnWGRPTGLjMcowqWrnzVOI kJ/ieQgPhkQaVN62XynJeUBLsMXOayZd0+s/FOl+/sU7fYk7ylxMNNONEo9v4MMOX2 EkYNW096rhmgfyvnaZeodFH9vvp0oqJ2vJng7y8OA4b8jBAcXw02cKVF6BTj48zyvm Cmnxhtaz9z7ww== Date: Fri, 6 May 2022 16:28:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , "jbeulich@suse.com" , "julien@xen.org" , "Bertrand.Marquis@arm.com" , Roger Pau Monne , George Dunlap , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" Subject: Re: ECLAIR Xen x86 results and progress In-Reply-To: <659c5058-1404-01b5-63d7-48c33159dc48@citrix.com> Message-ID: References: <659c5058-1404-01b5-63d7-48c33159dc48@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-821358349-1651877477=:43560" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-821358349-1651877477=:43560 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 6 May 2022, Andrew Cooper wrote: > On 06/05/2022 17:31, Stefano Stabellini wrote: > > Hi all, > > > > Roberto kindly provided the ECLAIR x86 results: > > > > https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ > > > > Click on "See ECLAIR in action", then you can select "Show 100 entries" > > and see all the results in one page. As an example MC3R1.R1.3 > > corresponds to Rule 1.3 in the spreadsheet. > > Thanks.  Some observations: > > 1) D4.10 "use header guards to prevent multiple inclusion" > > asm/p2m.h lacks header guards at all.  asm/softirq.h has some decidedly > dodgy looking logic.  These should obviously be fixed, and there are > probably more too in the 57 violations. > > However, we have files like public/errno.h which are explicitly designed > to be included multiple times, and are not going to change unless we > have a fundamental shift in opinion on the utility of trying to make a > single set of header files for all environments. > > Also, Eclair really doesn't like how we include C files.  TBH, I don't > much either, but some of the hypercall compat logic explicitly depends > on including itself, to avoid coding the hypercall logic twice.  There > is an argument to say that this is differently-less-bad than other > options, but it certainly doesn't help with general comprehensibility of > the code. I think we should accept this rule because in general we would want new headers to follow the rule. We should fix things like asm/p2m.h, and we should deviate (not fix, but document) any of the existing cases we don't want to fix (e.g. errno.h.) > 2) R6.2 "don't use signed bitfields" > > We have one single violation, and it's only used as a regular boolean.  > It doesn't even need to be a bitfield at all, because there's 63 bits of > padding at the end of sh_emulate_ctxt. This is an easy rule to follow > (In the time that I've been browsing, someone has apparently done > another build with in particular CONFIG_SHADOW_PAGING disabled, so this > has fallen off the list of violations.) > > 3) R8.10 "inline functions shall be static". > > We have 3 violations.  One is a legitimate complaint in spinlock.c. > > The other two violations are from extern inline.  Given that extern > inline explicitly gives the compiler the choice to inline, or use a > single common out-of-line implementation, I think extern inline also > meets the spirit of what MISRA is trying to do here, insofar as it > prevents there being dead functions emitted into the final binary. As we only have 3 violations, it is another easy rule to follow. The reason for the rule seems to be to avoid undefined behavior which can happen if the inline function (not static) is defined with external linkage but it is not defined in the same translation unit. Looking at the code, we are using extern gnu_inline which actually has a defined behavior, so it looks like we are meeting the spirit of the MISRA rule. In any case, the details on those 2 violations don't matter too much. I think we should accept the rule because if someone submitted a patch with an inline function (non static) we would definitely ask them why, and we would want ECLAIR to highlight the issue. --8323329-821358349-1651877477=:43560-- From xen-devel-bounces@lists.xenproject.org Sat May 07 00:28:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 00:28:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323467.545117 (Exim 4.92) (envelope-from ) id 1nn8IX-0001fI-1M; Sat, 07 May 2022 00:27:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323467.545117; Sat, 07 May 2022 00:27:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8IW-0001fB-Tx; Sat, 07 May 2022 00:27:48 +0000 Received: by outflank-mailman (input) for mailman id 323467; Sat, 07 May 2022 00:27:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8IU-0001f1-O5; Sat, 07 May 2022 00:27:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8IU-00036m-M9; Sat, 07 May 2022 00:27:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8IU-0001p9-6v; Sat, 07 May 2022 00:27:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn8IU-0005Ra-6T; Sat, 07 May 2022 00:27:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Of1BYNFtSkWpM0OHVmBTIYGg9wSZHYKN9o81g6yCwto=; b=qN0M3KF6OmaXZEFPVjIa1wgTVS oTsnzDmy0srTtl0loshvsLPEx/jXd7FPF6VoCV3F+E/rSW6xxK/6ZDw+Auq7MmZyzqgwA6MR21i+D 4zVjg2yswTMow4fGo4WV70xL/T9Xk/AGEyOGzTotuRN7N+HRr76AhqwZ6Xz9QAoucrqI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170181: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=31abf61c4929a91275fe32f1fafe6e6b3e840b2a X-Osstest-Versions-That: qemuu=e91b8994115d2f093e7556c9af2d051a26a98cfb From: osstest service owner Date: Sat, 07 May 2022 00:27:46 +0000 flight 170181 qemu-mainline real [real] flight 170195 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170181/ http://logs.test-lab.xenproject.org/osstest/logs/170195/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 170195-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170162 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170162 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170162 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170162 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170162 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170162 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170162 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170162 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 31abf61c4929a91275fe32f1fafe6e6b3e840b2a baseline version: qemuu e91b8994115d2f093e7556c9af2d051a26a98cfb Last test of basis 170162 2022-05-05 23:08:25 Z 1 days Testing same since 170181 2022-05-06 10:18:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bin Meng Daniel Henrique Barboza Frederic Barrat Murilo Opsfelder Araujo Richard Henderson Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git e91b899411..31abf61c49 31abf61c4929a91275fe32f1fafe6e6b3e840b2a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 07 01:08:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323475.545127 (Exim 4.92) (envelope-from ) id 1nn8w0-00045f-90; Sat, 07 May 2022 01:08:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323475.545127; Sat, 07 May 2022 01:08:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8w0-00045Y-61; Sat, 07 May 2022 01:08:36 +0000 Received: by outflank-mailman (input) for mailman id 323475; Sat, 07 May 2022 01:08:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8vz-00045S-4Y for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:08:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35eab187-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:08:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFCEE61D48; Sat, 7 May 2022 01:08:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA137C385A8; Sat, 7 May 2022 01:08:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35eab187-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885710; bh=0OA13OCQQD4sy8PnYYHChoy0+eOjGGqnw3ftitWrgFE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LARMJpkgZjp1uvYTm3shy2d1/ZaouxGbnqGEhtTa4cL+177kaSLQK89o6LjMpPY5j /ckDncSlL67wGcsX8lJBTFtlubuCLP6Rq6wZYXU6iIhGYxWG+g5xiH9oW9uphU2H/H JV3pDcXlSNuTCaREWLswamt2mOpShMmWVbOBvcorkUN72oL6h3WgZTEoa1IV5BmT3A B5tpRmCvkdE7vlmjROmEjeaAqreGE9Fu6p6chHJSWfjn5NSj0xK4w6R1Z9WXr7LSlu YxCTQp1jho9DiFHbfDNxHa/b+QwViY4iLPRYuKrDPgVrrWRHHNG3YcAufp1zrS2qOU a6IiVUimwqPpQ== Date: Fri, 6 May 2022 18:08:29 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 1/9] xen/arm: introduce static shared memory In-Reply-To: <20220506072502.2177828-2-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-2-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This patch serie introduces a new feature: setting up static > shared memory on a dom0less system, through device tree configuration. > > This commit parses shared memory node at boot-time, and reserve it in > bootinfo.reserved_mem to avoid other use. > > This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap > static-shm-related codes, and this option depends on static memory( > CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few > helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, > on static shared memory. > > Signed-off-by: Penny Zheng Thanks Penny, this version of the series is already so much better than v1! I have only few minor comments left on the series. One NIT at the bottom of this file. > --- > v2 change: > - document refinement > - remove bitmap and use the iteration to check > - add a new field nr_shm_domain to keep the number of shared domain > --- > docs/misc/arm/device-tree/booting.txt | 120 ++++++++++++++++++++++++++ > xen/arch/arm/Kconfig | 6 ++ > xen/arch/arm/bootfdt.c | 68 +++++++++++++++ > xen/arch/arm/include/asm/setup.h | 3 + > 4 files changed, 197 insertions(+) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index a94125394e..e63ce171fc 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -355,3 +355,123 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > +Static Shared Memory > +==================== > + > +The static shared memory device tree nodes allow users to statically set up > +shared memory on dom0less system, enabling domains to do shm-based > +communication. > + > +- compatible > + > + "xen,domain-shared-memory-v1" > + > +- xen,shm-id > + > + An u8 value represents the unique identifier of the shared memory region. > + The maximum identifier shall be "xen,shm-id = <0xff>". > + > +- xen,shared-mem > + > + An array takes a physical address, which is the base address of the > + shared memory region in host physical address space, a size, and a guest > + physical address, as the target address of the mapping. The number of cells > + for the host address (and size) is the same as the guest pseudo-physical > + address and they are inherited from the parent node. > + > +- role (Optional) > + > + A string property specifying the ownership of a shared memory region, > + the value must be one of the following: "owner", or "borrower" > + A shared memory region could be explicitly backed by one domain, which is > + called "owner domain", and all the other domains who are also sharing > + this region are called "borrower domain". > + If not specified, the default value is "borrower" and owner is > + "dom_shared", a system domain. > + > +As an example: > + > +chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; > + > + ...... > + > + /* this is for Dom0 */ > + dom0-shared-mem@10000000 { > + compatible = "xen,domain-shared-memory-v1"; > + role = "owner"; > + xen,shm-id = <0x0>; > + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; > + } > + > + domU1 { > + compatible = "xen,domain"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + memory = <0 131072>; > + cpus = <2>; > + vpl011; > + > + /* > + * shared memory region identified as 0x0(xen,shm-id = <0x0>) > + * is shared between Dom0 and DomU1. > + */ > + domU1-shared-mem@10000000 { > + compatible = "xen,domain-shared-memory-v1"; > + role = "borrower"; > + xen,shm-id = <0x0>; > + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; > + } > + > + /* > + * shared memory region identified as 0x1(xen,shm-id = <0x1>) > + * is shared between DomU1 and DomU2. > + */ > + domU1-shared-mem@50000000 { > + compatible = "xen,domain-shared-memory-v1"; > + xen,shm-id = <0x1>; > + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; > + } > + > + ...... > + > + }; > + > + domU2 { > + compatible = "xen,domain"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + memory = <0 65536>; > + cpus = <1>; > + > + /* > + * shared memory region identified as 0x1(xen,shm-id = <0x1>) > + * is shared between domU1 and domU2. > + */ > + domU2-shared-mem@50000000 { > + compatible = "xen,domain-shared-memory-v1"; > + xen,shm-id = <0x1>; > + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; > + } > + > + ...... > + }; > +}; > + > +This is an example with two static shared memory regions. > + > +For the static shared memory region identified as 0x0, host physical > +address starting at 0x10000000 of 256MB will be reserved to be shared between > +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest physical address > +space, and at 0x50000000 in DomU1 guest physical address space. Dom0 is > +explicitly defined as the owner domain, and DomU1 is the borrower domain. > + > +For the static shared memory region identified as 0x1, host physical > +address starting at 0x50000000 of 512MB will be reserved to be shared between > +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical > +address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 > +and DomU2 are both the borrower domain, the owner domain is the default owner > +domain dom_shared. > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ecfa6822e4..5ee9921f56 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -106,6 +106,12 @@ config TEE > > source "arch/arm/tee/Kconfig" > > +config STATIC_SHM > + bool "Statically shared memory on a dom0less system" if UNSUPPORTED > + depends on STATIC_MEMORY > + help > + This option enables statically shared memory on a dom0less system. > + > endmenu > > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index e318ef9603..9bd08776a7 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -363,6 +363,70 @@ static int __init process_domain_node(const void *fdt, int node, > size_cells, &bootinfo.reserved_mem, true); > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init process_shm_node(const void *fdt, int node, > + u32 address_cells, u32 size_cells) > +{ > + const struct fdt_property *prop; > + const __be32 *cell; > + paddr_t paddr, size; > + struct meminfo *mem = &bootinfo.reserved_mem; > + unsigned long i; > + > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); > + return -EINVAL; > + } > + > + prop = fdt_get_property(fdt, node, "xen,shared-mem", NULL); > + if ( !prop ) > + return -ENOENT; > + > + /* > + * xen,shared-mem = ; > + * Memory region starting from physical address #paddr of #size shall > + * be mapped to guest physical address #gaddr as static shared memory > + * region. > + */ > + cell = (const __be32 *)prop->data; > + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); > + for ( i = 0; i < mem->nr_banks; i++ ) > + { > + /* > + * A static shared memory region could be shared between multiple > + * domains. > + */ > + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) > + break; > + } > + > + if ( i == mem->nr_banks ) > + { > + if ( i < NR_MEM_BANKS ) > + { > + /* Static shared memory shall be reserved from any other use. */ > + mem->bank[mem->nr_banks].start = paddr; > + mem->bank[mem->nr_banks].size = size; > + mem->bank[mem->nr_banks].xen_domain = true; > + mem->nr_banks++; > + } > + else > + { > + printk("Warning: Max number of supported memory regions reached.\n"); > + return -ENOSPC; > + } > + } > + /* > + * keep a count of the number of domains, which later may be used to > + * calculate the number of the reference count. > + */ > + mem->bank[i].nr_shm_domain++; > + > + return 0; > +} > +#endif > + > static int __init early_scan_node(const void *fdt, > int node, const char *name, int depth, > u32 address_cells, u32 size_cells, > @@ -383,6 +447,10 @@ static int __init early_scan_node(const void *fdt, > process_chosen_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) > rc = process_domain_node(fdt, node, name, address_cells, size_cells); > +#ifdef CONFIG_STATIC_SHM > + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) > + rc = process_shm_node(fdt, node, address_cells, size_cells); > +#endif > > if ( rc < 0 ) > printk("fdt: node `%s': parsing failed\n", name); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 7a1e1d6798..38e02ced36 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -27,6 +27,9 @@ struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > +#ifdef CONFIG_STATIC_SHM > + unsigned long nr_shm_domain; > +#endif This is a NIT but unsigned int would be more than enough. The benefit is that the following uint8_t end up not needing extra memory on arm64. I realize this is an overoptimization so it is fine anyway. Other than this, the patch looks good to me. From xen-devel-bounces@lists.xenproject.org Sat May 07 01:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323476.545139 (Exim 4.92) (envelope-from ) id 1nn8wA-0004NZ-Gh; Sat, 07 May 2022 01:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323476.545139; Sat, 07 May 2022 01:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wA-0004NS-Dn; Sat, 07 May 2022 01:08:46 +0000 Received: by outflank-mailman (input) for mailman id 323476; Sat, 07 May 2022 01:08:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8w9-00045S-1c for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:08:45 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d37d35c-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:08:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 235D8B81031; Sat, 7 May 2022 01:08:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C5F3C385A8; Sat, 7 May 2022 01:08:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d37d35c-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885721; bh=qKLsxrkRx6OnqjuwOvuzu03qa5vsk11A0xOi+U4j1lI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tPz0YgqN+UsFlseRhjcn9brfrdPAw/Oajy0oK/6Da848auWRe4nC+9QQWsFvoBh2p cxWYBkbw06F+U+pgCF3LE/hv9bayiEFjKH4oEzhkQm4ykl8qP/Hm9KprRxnH+mmiDu iFFNdb3Nsp891g36/vJRXrp1pUxrBkx1GL1/kybvC9ez8yAS65uRKgGOa/dws+PPFv crN9afE5xKLktWMqQpbliZeYoMR8TYNQcZ0D0qGwKu4HZOUQ9Fd8znhIRu6dQ5hxRj mxdX6ASf7yrZcd/wyKyecyLOvTk5i6dWrbscbDh9ILiO2MHP8uSN+08SClxYCg33PY NypF6VXaLy5fw== Date: Fri, 6 May 2022 18:08:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v2 2/9] xen/arm: allocate static shared memory to the default owner dom_io In-Reply-To: <20220506072502.2177828-3-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-3-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This commit introduces process_shm to cope with static shared memory in > domain construction. > > DOMID_IO will be the default owner of memory pre-shared among multiple domains > at boot time, when no explicit owner is specified. > > This commit only considers allocating static shared memory to dom_io > when owner domain is not explicitly defined in device tree, all the left, > including the "borrower" code path, the "explicit owner" code path, shall > be introduced later in the following patches. > > Signed-off-by: Penny Zheng > --- > v2 change: > - instead of introducing a new system domain, reuse the existing dom_io > - make dom_io a non-auto-translated domain, then no need to create P2M > for it > - change dom_io definition and make it wider to support static shm here too > - introduce is_shm_allocated_to_domio to check whether static shm is > allocated yet, instead of using shm_mask bitmap > - add in-code comment > --- > xen/arch/arm/domain_build.c | 133 +++++++++++++++++++++++++++++++++++- > xen/common/domain.c | 18 ++++- > 2 files changed, 148 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 1472ca4972..e97bb6eeba 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -527,7 +527,13 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, > mfn_t smfn; > int res; > > - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); > + /* > + * acquire_static_memory_bank() is also used for acquiring static shared > + * memory, in such case, we don't need to parse 'cell' here since it is > + * already parsed in process_shm(). > + */ I would prefer if the comment was moved on top of acquire_static_memory_bank and rephrased as: /* * If cell is NULL, pbase and psize should hold valid values. * Otherwise, cell will be populated together with pbase and psize. */ Other than that, it looks good. I'll leave it to Jan to comment on the in-code comment in xen/common/domain.c. > + if ( cell ) > + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); > ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); > if ( PFN_DOWN(*psize) > UINT_MAX ) > { > @@ -751,6 +757,125 @@ static void __init assign_static_memory_11(struct domain *d, > panic("Failed to assign requested static memory for direct-map domain %pd.", > d); > } > + > +#ifdef CONFIG_STATIC_SHM > +/* > + * This function checks whether the static shared memory region is > + * already allocated to dom_io. > + */ > +static bool __init is_shm_allocated_to_domio(paddr_t pbase) > +{ > + struct page_info *page; > + > + page = maddr_to_page(pbase); > + ASSERT(page); > + > + if ( page_get_owner(page) == NULL ) > + return false; > + > + ASSERT(page_get_owner(page) == dom_io); > + return true; > +} > + > +static mfn_t __init acquire_shared_memory_bank(struct domain *d, > + u32 addr_cells, u32 size_cells, > + paddr_t *pbase, paddr_t *psize) > +{ > + /* > + * Pages of statically shared memory shall be included > + * in domain_tot_pages(). > + */ > + d->max_pages += PFN_DOWN(*psize); > + > + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, > + pbase, psize); > + > +} > + > +/* > + * Func allocate_shared_memory is supposed to be only called > + * from the owner. > + */ > +static int __init allocate_shared_memory(struct domain *d, > + u32 addr_cells, u32 size_cells, > + paddr_t pbase, paddr_t psize) > +{ > + mfn_t smfn; > + > + dprintk(XENLOG_INFO, > + "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > + pbase, pbase + psize); > + > + smfn = acquire_shared_memory_bank(d, addr_cells, size_cells, &pbase, > + &psize); > + if ( mfn_eq(smfn, INVALID_MFN) ) > + return -EINVAL; > + > + /* > + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > + * It sees RAM 1:1 and we do not need to create P2M mapping for it > + */ > + ASSERT(d == dom_io); > + return 0; > +} > + > +static int __init process_shm(struct domain *d, > + const struct dt_device_node *node) > +{ > + struct dt_device_node *shm_node; > + int ret = 0; > + const struct dt_property *prop; > + const __be32 *cells; > + u32 shm_id; > + u32 addr_cells, size_cells; > + paddr_t gbase, pbase, psize; > + > + dt_for_each_child_node(node, shm_node) > + { > + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > + continue; > + > + if ( !dt_property_read_u32(shm_node, "xen,shm-id", &shm_id) ) > + { > + printk("Shared memory node does not provide \"xen,shm-id\" property.\n"); > + return -ENOENT; > + } > + > + addr_cells = dt_n_addr_cells(shm_node); > + size_cells = dt_n_size_cells(shm_node); > + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); > + if ( !prop ) > + { > + printk("Shared memory node does not provide \"xen,shared-mem\" property.\n"); > + return -ENOENT; > + } > + cells = (const __be32 *)prop->value; > + /* xen,shared-mem = ; */ > + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); > + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > + gbase = dt_read_number(cells, addr_cells); > + > + /* TODO: Consider owner domain is not the default dom_io. */ > + /* > + * Per static shared memory region could be shared between multiple > + * domains. > + * In case re-allocating the same shared memory region, we check > + * if it is already allocated to the default owner dom_io before > + * the actual allocation. > + */ > + if ( !is_shm_allocated_to_domio(pbase) ) > + { > + /* Allocate statically shared pages to the default owner dom_io. */ > + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, > + pbase, psize); > + if ( ret ) > + return ret; > + } > + } > + > + return 0; > +} > +#endif /* CONFIG_STATIC_SHM */ > #else > static void __init allocate_static_memory(struct domain *d, > struct kernel_info *kinfo, > @@ -3149,6 +3274,12 @@ static int __init construct_domU(struct domain *d, > else > assign_static_memory_11(d, &kinfo, node); > > +#ifdef CONFIG_STATIC_SHM > + rc = process_shm(d, node); > + if ( rc < 0 ) > + return rc; > +#endif > + > /* > * Base address and irq number are needed when creating vpl011 device > * tree node in prepare_dtb_domU, so initialization on related variables > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 8d2c2a9897..0c41ecb197 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -777,8 +777,22 @@ void __init setup_system_domains(void) > > /* > * Initialise our DOMID_IO domain. > - * This domain owns I/O pages that are within the range of the page_info > - * array. Mappings occur at the priv of the caller. > + * DOMID_IO is used for mapping memory and MMIO regions when no explicit > + * Domain need to be specified. > + * > + * For instance, DOMID_IO is the owner of memory pre-shared among > + * multiple domains at boot time, when no explicit owner is specified. > + * > + * Also, DOMID_IO is used to restrict page-table updates to mapping I/O > + * memory. Although no Foreign Domain need to be specified to map I/O > + * pages, DOMID_IO is useful to ensure that no mappings to the OS's own > + * heap are accidentally installed. (e.g., in Linux this could cause > + * havoc as reference counts aren't adjusted on the I/O-mapping code > + * path). This only makes sense as HYPERVISOR_mmu_update()'s and > + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument. > + * For HYPERVISOR_mmu_update() context it can be specified by any > + * calling domain, otherwise it's only permitted if the caller is > + * privileged. > * Quarantined PCI devices will be associated with this domain. > */ > dom_io = domain_create(DOMID_IO, NULL, 0); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:08:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:08:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323478.545150 (Exim 4.92) (envelope-from ) id 1nn8wI-0004kx-QP; Sat, 07 May 2022 01:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323478.545150; Sat, 07 May 2022 01:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wI-0004km-NK; Sat, 07 May 2022 01:08:54 +0000 Received: by outflank-mailman (input) for mailman id 323478; Sat, 07 May 2022 01:08:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wH-00045S-C7 for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:08:53 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42628f14-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:08:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07F9CB838E6; Sat, 7 May 2022 01:08:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7752EC385A8; Sat, 7 May 2022 01:08:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42628f14-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885730; bh=BoNFKBKfzSpWyDeOheFiBCiFvaa73UsP6sYCZE+3E/w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LNy7OYrxWr8ICZh1Cg2fWmy1Hih4oOyyk8bP1DrRkeWiXLk9wfhZdqsQBoLchNggL wKvBu2mrwpYH/PK3CHt3ffMzuyhTAb4MUYfxFcmXgLmT4Gs1IgbBdg/S1HmBTuBd9R LY6upvyA9z6QGwIlAlWAAt5vbeYC+KwC3t/UAkka/1g+JQ1E9up+qHjyhKWLS34/hj fWx3BwNVPpQeQMhf2oGRBqHk8Xy3dwBZuaRvWSYwk+x7/vyLBjGu5IO7fmqJ4PPkyF evtmGbL79VjzKUpfpZhrspAI+9pFjkEY6nK9D74j+6WwIlQo4GvRxWfnEP+mIz6ddR 5y2CbyMLJx9EA== Date: Fri, 6 May 2022 18:08:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 3/9] xen/arm: allocate static shared memory to a specific owner domain In-Reply-To: <20220506072502.2177828-4-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-4-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > If owner property is defined, then owner domain of a static shared memory > region is not the default dom_io anymore, but a specific domain. > > This commit implements allocating static shared memory to a specific domain > when owner property is defined. > > Coding flow for dealing borrower domain will be introduced later in the > following commits. > > Signed-off-by: Penny Zheng > --- > v2 change: > - P2M mapping is restricted to normal domain > - in-code comment fix > --- > xen/arch/arm/domain_build.c | 55 +++++++++++++++++++++++++++++-------- > 1 file changed, 43 insertions(+), 12 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index e97bb6eeba..f43378227a 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -798,9 +798,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > */ > static int __init allocate_shared_memory(struct domain *d, > u32 addr_cells, u32 size_cells, > - paddr_t pbase, paddr_t psize) > + paddr_t pbase, paddr_t psize, > + paddr_t gbase) > { > mfn_t smfn; > + int ret = 0; > > dprintk(XENLOG_INFO, > "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > @@ -813,10 +815,20 @@ static int __init allocate_shared_memory(struct domain *d, > > /* > * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > - * It sees RAM 1:1 and we do not need to create P2M mapping for it > + * It sees RAM 1:1 and we do not need to create P2M mapping for it. > */ > - ASSERT(d == dom_io); > - return 0; > + if ( d != dom_io ) > + { > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > + if ( ret ) > + { > + printk(XENLOG_ERR > + "Failed to map shared memory to %pd.\n", d); > + return ret; > + } > + } > + > + return ret; > } > > static int __init process_shm(struct domain *d, > @@ -829,6 +841,8 @@ static int __init process_shm(struct domain *d, > u32 shm_id; > u32 addr_cells, size_cells; > paddr_t gbase, pbase, psize; > + const char *role_str; > + bool owner_dom_io = true; > > dt_for_each_child_node(node, shm_node) > { > @@ -855,19 +869,36 @@ static int __init process_shm(struct domain *d, > ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > gbase = dt_read_number(cells, addr_cells); > > - /* TODO: Consider owner domain is not the default dom_io. */ > + /* > + * "role" property is optional and if it is defined explicitly, > + * then the owner domain is not the default "dom_io" domain. > + */ > + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > + owner_dom_io = false; > + > /* > * Per static shared memory region could be shared between multiple > * domains. > - * In case re-allocating the same shared memory region, we check > - * if it is already allocated to the default owner dom_io before > - * the actual allocation. > + * So when owner domain is the default dom_io, in case re-allocating > + * the same shared memory region, we check if it is already allocated > + * to the default owner dom_io before the actual allocation. > */ > - if ( !is_shm_allocated_to_domio(pbase) ) > + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > - /* Allocate statically shared pages to the default owner dom_io. */ > - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, > - pbase, psize); > + struct domain *od = d; > + paddr_t o_gbase = gbase; > + > + if ( owner_dom_io ) > + { > + od = dom_io; > + /* For dom_io, GFN is always equal to PFN. */ > + o_gbase = pbase; > + } > o_gbase is not used if the domain is dom_io, so I would simplify it further to: ret = allocate_shared_memory(owner_dom_io ? dom_io : d, addr_cells, size_cells, pbase, psize, gbase); > + /* Allocate statically shared pages to the owner domain. */ > + ret = allocate_shared_memory(od, addr_cells, size_cells, > + pbase, psize, o_gbase); > if ( ret ) > return ret; > } > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:09:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323480.545161 (Exim 4.92) (envelope-from ) id 1nn8wQ-0005F0-9O; Sat, 07 May 2022 01:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323480.545161; Sat, 07 May 2022 01:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wQ-0005En-5Q; Sat, 07 May 2022 01:09:02 +0000 Received: by outflank-mailman (input) for mailman id 323480; Sat, 07 May 2022 01:09:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wO-00045S-TN for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 465f87b0-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:08:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B76216186A; Sat, 7 May 2022 01:08:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFDFCC385A6; Sat, 7 May 2022 01:08:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 465f87b0-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885738; bh=Hk8DpJt15cB50wh8M5ef9fhZkSCraUVqftXhgNALNKA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hCAe9w9w7dSfjA9UFjYrDXG165r2bWiHPB44lj69uUc938p/PI1K8/gvaZLeshEXk Z8acQ/Bm/zRY1ebjDCXckIyax5WvXabpCliCuLrASq+qIPx4NYvTiSkY4KwyiBJ0DX nGZQPxHrP7VB5dzpS+o05HW/Ix4snjv2/eX/6N6UQRNVfFKG9Z3Z7MAeG30hDio9C5 iQAjIIG/SnPwFininXMx/kR/QYwzD+KLn7ugalPfdgazFOD5PeYnQkNvS1bNSKSpRY UWwhvSzLZnxKvScMFU2EwskRNGg5hwFk4M3K94SQ5L1qksIS7m4V6SKGsSYMUgp5hk XA7IoKBBoANJQ== Date: Fri, 6 May 2022 18:08:56 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr In-Reply-To: <20220506072502.2177828-5-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-5-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-consuming. > > To save the loop time, this commit introduces a set of new helpers > put_page_nr() and get_page_nr() to increment/drop the page reference by nr. > > Signed-off-by: Penny Zheng > --- > v2 change: > - new commit > --- > xen/arch/arm/include/asm/mm.h | 4 ++++ > xen/arch/arm/mm.c | 36 +++++++++++++++++++++++++---------- > 2 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 424aaf2823..c737d51e4d 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -347,6 +347,10 @@ void free_init_memory(void); > int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, > unsigned int order); > > +extern bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr); > +extern void put_page_nr(struct page_info *page, unsigned long nr); > + > extern void put_page_type(struct page_info *page); > static inline void put_page_and_type(struct page_info *page) > { > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7b1f2f4906..e565979f3c 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) > return 0; > } > > -struct domain *page_get_owner_and_reference(struct page_info *page) > +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, > + unsigned long nr) > { > unsigned long x, y = page->count_info; > struct domain *owner; > @@ -1545,13 +1546,14 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > do { > x = y; > /* > + * Consider the minimum case(nr = 1): > * Count == 0: Page is not allocated, so we cannot take a reference. > * Count == -1: Reference count would wrap, which is invalid. > */ > if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) > return NULL; > } > - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); > + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); > > owner = page_get_owner(page); > ASSERT(owner); > @@ -1559,36 +1561,50 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > return owner; > } > > -void put_page(struct page_info *page) > +struct domain *page_get_owner_and_reference(struct page_info *page) > +{ > + return page_get_owner_and_nr_reference(page, 1); > +} > + > +void put_page_nr(struct page_info *page, unsigned long nr) > { > unsigned long nx, x, y = page->count_info; > > do { > - ASSERT((y & PGC_count_mask) != 0); > + ASSERT(((y - nr) & PGC_count_mask) >= 0); Why this change? The original ASSERT is to check that we enter the loop only when count_info is greater than 0. It should still apply even for put_page_nr without modifications? > x = y; > - nx = x - 1; > + nx = x - nr; > } > while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); > > if ( unlikely((nx & PGC_count_mask) == 0) ) > - { > free_domheap_page(page); > - } > } > > -bool get_page(struct page_info *page, const struct domain *domain) > +void put_page(struct page_info *page) > { > - const struct domain *owner = page_get_owner_and_reference(page); > + put_page_nr(page, 1); > +} > + > +bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr) > +{ > + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); > > if ( likely(owner == domain) ) > return true; > > if ( owner != NULL ) > - put_page(page); > + put_page_nr(page, nr); > > return false; > } > > +bool get_page(struct page_info *page, const struct domain *domain) > +{ > + return get_page_nr(page, domain, 1); > +} > + > /* Common code requires get_page_type and put_page_type. > * We don't care about typecounts so we just do the minimum to make it > * happy. */ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:09:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323486.545172 (Exim 4.92) (envelope-from ) id 1nn8wY-0005mn-JW; Sat, 07 May 2022 01:09:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323486.545172; Sat, 07 May 2022 01:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wY-0005mY-G7; Sat, 07 May 2022 01:09:10 +0000 Received: by outflank-mailman (input) for mailman id 323486; Sat, 07 May 2022 01:09:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wW-0004gy-NY for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b1dd347-cda2-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 03:09:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B24BB61D48; Sat, 7 May 2022 01:09:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C208FC385A8; Sat, 7 May 2022 01:09:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b1dd347-cda2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885746; bh=tvJ8vHOgeXadbKseYtdzdG7b5YDjhBrgmuFtkclQREw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kFAeEoAfHwzRiLbGYwaL6IvVOZFJlhGA41rpEAdPQTaG296YsrcP8h/8bt0OTfjTm R1ZR2a00ElciGmZ1w7y85/kJR8rTnVHvtcNBsE+JbqnvA490agxrEZ+NnWG5lBVs1y mJ1oRppoBN6n/JynmcZUmonUbP1pDcQiDvioGoXiyS+z1yxdY1Qja9U/0I2WBZaomR mSuXRztcXtAQcCe9QAYzCMVxlIfSI8VDecu5/8k89kGMAMxb6OsydXhFQvMFt3JNbk kZJ5YBf3sgQ3KelJvz4Jo59zENsehB2Qq58vGfraIUarxMsw0dalRO0r7ip/FCOTbd 9XtL2JVTTxRHg== Date: Fri, 6 May 2022 18:09:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated In-Reply-To: <20220506072502.2177828-6-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-6-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > Borrower domain will fail to get a page ref using the owner domain > during allocation, when the owner is created after borrower. > > So here, we decide to get and add the right amount of reference, which > is the number of borrowers, when the owner is allocated. > > Signed-off-by: Penny Zheng > > --- > v2 change: > - new commit > --- > xen/arch/arm/domain_build.c | 62 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index f43378227a..b3ba0c501d 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -792,6 +792,34 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > > } > > +static int __init acquire_nr_borrower_domain(struct domain *d, > + paddr_t pbase, paddr_t psize, > + unsigned long *nr_borrowers) > +{ > + unsigned long bank; > + > + /* Iterate reserved memory to find requested shm bank. */ > + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > + { > + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; > + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; > + > + if ( pbase == bank_start && psize == bank_size ) > + break; > + } > + > + if ( bank == bootinfo.reserved_mem.nr_banks ) > + return -ENOENT; > + > + if ( d == dom_io ) > + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain; > + else > + /* Exclude the owner domain itself. */ > + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain - 1; > + > + return 0; > +} > + > /* > * Func allocate_shared_memory is supposed to be only called > * from the owner. > @@ -803,6 +831,8 @@ static int __init allocate_shared_memory(struct domain *d, > { > mfn_t smfn; > int ret = 0; > + unsigned long nr_pages, nr_borrowers, i; > + struct page_info *page; > > dprintk(XENLOG_INFO, > "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > @@ -817,6 +847,7 @@ static int __init allocate_shared_memory(struct domain *d, > * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > * It sees RAM 1:1 and we do not need to create P2M mapping for it. > */ > + nr_pages = PFN_DOWN(psize); > if ( d != dom_io ) > { > ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > @@ -828,6 +859,37 @@ static int __init allocate_shared_memory(struct domain *d, > } > } > > + /* > + * Get the right amount of references per page, which is the number of > + * borrow domains. > + */ > + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); > + if ( ret ) > + return ret; > + > + /* > + * Instead of let borrower domain get a page ref, we add as many > + * additional reference as the number of borrowers when the owner > + * is allocated, since there is a chance that owner is created > + * after borrower. > + */ > + page = mfn_to_page(smfn); > + for ( i = 0; i < nr_pages; i++ ) > + { > + if ( !get_page_nr(page + i, d, nr_borrowers) ) > + { > + dprintk(XENLOG_ERR, > + "Failed to add %lu references to page %"PRI_mfn".\n", > + nr_borrowers, mfn_x(smfn) + i); dprintk only prints errors when DEBUG is selected. This is actually a pretty serious error so I think it should be printed in all cases. A normal printk would be fine. > + goto fail; > + } > + } > + > + return 0; > + > + fail: > + while ( --i >= 0 ) > + put_page_nr(page + i, nr_borrowers); > return ret; > } > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:09:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:09:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323488.545183 (Exim 4.92) (envelope-from ) id 1nn8we-0006CD-Qg; Sat, 07 May 2022 01:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323488.545183; Sat, 07 May 2022 01:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8we-0006C6-Ns; Sat, 07 May 2022 01:09:16 +0000 Received: by outflank-mailman (input) for mailman id 323488; Sat, 07 May 2022 01:09:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wd-00045S-Dp for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:15 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f9db029-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:09:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48060B838E8; Sat, 7 May 2022 01:09:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96936C385A9; Sat, 7 May 2022 01:09:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f9db029-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885752; bh=dlOiVTvBiFvLzuo8f1RuvGBEH2ogOHIZC6uMOZSoHfw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NKRxZDD2TQU1ctJa3cG3MYFAuIDZHB6XzDzuCEDSDQ4bcQw6v/jGJOd3A4hARBA1r YvKwBYHss5V5MU9SWQiJBzbErUjNo+wgag8tFSO+hvDpeq0w99+zBLPShxNFEIgTfy V3h/uN5Q2DlXQa3vGjVC8PxLMDVRHbyWBgvB5B2snf6Bwq93TriEo+6jsG3dhEAKu2 N26H03cppDxsZcxup6TDVdrLdzFplMYIIG7gun7XCmWO1yysRJ4J4iDvpZOG+9KBRp mKb4COwdpI0qBgkdlOuGEivVgY/N1yiJP3gvuKH0pKBmenS1FKIPhJkNyEdD39V+PY ShvewZU2oZ2hg== Date: Fri, 6 May 2022 18:09:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages In-Reply-To: <20220506072502.2177828-7-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-7-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > In order to cover the scenario where users intend to set up guest > p2m foreign mapping with nr_pages, this commit adds a new P2M type > parameter in guest_physmap_add_pages. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v2 change: > - no change > --- > xen/arch/arm/domain_build.c | 5 +++-- > xen/arch/arm/include/asm/p2m.h | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index b3ba0c501d..089b9e99fc 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -507,7 +507,7 @@ static bool __init append_static_memory_to_bank(struct domain *d, > else > sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); > > - res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); > + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages, p2m_ram_rw); > if ( res ) > { > dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); > @@ -850,7 +850,8 @@ static int __init allocate_shared_memory(struct domain *d, > nr_pages = PFN_DOWN(psize); > if ( d != dom_io ) > { > - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, nr_pages, > + p2m_ram_rw); > if ( ret ) > { > printk(XENLOG_ERR > diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h > index 8cce459b67..58590145b0 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -317,9 +317,10 @@ guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, > static inline int guest_physmap_add_pages(struct domain *d, > gfn_t gfn, > mfn_t mfn, > - unsigned int nr_pages) > + unsigned int nr_pages, > + p2m_type_t t) > { > - return p2m_insert_mapping(d, gfn, nr_pages, mfn, p2m_ram_rw); > + return p2m_insert_mapping(d, gfn, nr_pages, mfn, t); > } > > mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:13:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323495.545194 (Exim 4.92) (envelope-from ) id 1nn90T-0008Py-Cu; Sat, 07 May 2022 01:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323495.545194; Sat, 07 May 2022 01:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn90T-0008Pr-9G; Sat, 07 May 2022 01:13:13 +0000 Received: by outflank-mailman (input) for mailman id 323495; Sat, 07 May 2022 01:13:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn90R-0008Ph-Tq; Sat, 07 May 2022 01:13:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn90R-0001jW-RE; Sat, 07 May 2022 01:13:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn90R-0003y0-9E; Sat, 07 May 2022 01:13:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nn90R-0002hg-8b; Sat, 07 May 2022 01:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zKbMrZOKLsMgLGhoORkfAAwAaYprr/BvxifEOBg7qa0=; b=3Tyu26Xic0uYLRR8AnqV35zCn0 Lz4j5blknAYtCOTl/4xhJHKHS0LwF0V4086xyXXI8glVBm4O1OX51eHiEeHb/ABWO+ma2yK9/cTdq pGVU3Wb6/PQHuREgB37ok5meTnq73oIg8nTzeJQO32vPXp+C/I54ZUQL+fMPqQTqYsR0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170190: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4df22ca85d3d73f9822b1a354bb56dd1872180cd X-Osstest-Versions-That: linux=fe27d189e3f42e31d3c8223d5daed7285e334c5e From: osstest service owner Date: Sat, 07 May 2022 01:13:11 +0000 flight 170190 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170190/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170173 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170173 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170173 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170173 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170173 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170173 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170173 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170173 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 4df22ca85d3d73f9822b1a354bb56dd1872180cd baseline version: linux fe27d189e3f42e31d3c8223d5daed7285e334c5e Last test of basis 170173 2022-05-06 06:43:21 Z 0 days Testing same since 170190 2022-05-06 18:40:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Alex Deucher Bob Pearson Brian Norris Cheng Xu Dave Airlie Duoming Zhou Fabien Parent Harry Wentland Jason Gunthorpe Javier Martinez Canillas Konrad Dybcio Kuogee Hsieh Linus Torvalds Luca Weiss Maarten Lankhorst Marek Marczykowski-Górecki Mustafa Ismail Neil Armstrong Rob Clark Rob Clark Samuel Holland Shaik Sajida Bhanu Shiraz Saleem Tatyana Nikolova Ulf Hansson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git fe27d189e3f4..4df22ca85d3d 4df22ca85d3d73f9822b1a354bb56dd1872180cd -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat May 07 01:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323505.545205 (Exim 4.92) (envelope-from ) id 1nn943-0000hY-1a; Sat, 07 May 2022 01:16:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323505.545205; Sat, 07 May 2022 01:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn942-0000hM-UL; Sat, 07 May 2022 01:16:54 +0000 Received: by outflank-mailman (input) for mailman id 323505; Sat, 07 May 2022 01:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8ws-0004gy-QB for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5826c5b8-cda2-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 03:09:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97C7961D48; Sat, 7 May 2022 01:09:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A96B7C385A8; Sat, 7 May 2022 01:09:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5826c5b8-cda2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885768; bh=7mxKR5V7yjX3pVVFvNZXazmwCrgjUR55tn8aB+Zr22k=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Dz+pjQijuVNFVy8qYnrNBUTfi7/3tc/jjqHafn5hykgYBNLDZnUZQN0sKHVXzH9/Z p63LHDg44uOhJ84GBqHZcMg3ABtXrIe2qP+5svrdzULN9zBUQdAF18X0WQH/5j/rGK TYRwnOu/mS9couoGW8CZ6iSsuAJGZLdTSCICxcqqa5S704KAnrcUsU/o+2TrXyI58q KplDzN1rniVcrGH5Gv0GSiIZYz6xgulzpxED5NdLVMSGSv6pWdBH0Na33eyOBt3fOJ o2fSGx2B6j4UNFbyulU8OFz02eNxABovUMfu4UJ5e/KI9UlQgxgOhBpMT0aoQu6zzN UFuuVY8EZ9/GA== Date: Fri, 6 May 2022 18:09:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 8/9] xen/arm: create shared memory nodes in guest device tree In-Reply-To: <20220506072502.2177828-9-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-9-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > We expose the shared memory to the domU using the "xen,shared-memory-v1" > reserved-memory binding. See > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > in Linux for the corresponding device tree binding. > > To save the cost of re-parsing shared memory device tree configuration when > creating shared memory nodes in guest device tree, this commit adds new field > "shm_mem" to store shm-info per domain. > > For each shared memory region, a range is exposed under > the /reserved-memory node as a child node. Each range sub-node is > named xen-shmem@
and has the following properties: > - compatible: > compatible = "xen,shared-memory-v1" > - reg: > the base guest physical address and size of the shared memory region > - xen,id: > a string that identifies the shared memory region. > > Signed-off-by: Penny Zheng > --- > v2 change: > - using xzalloc > - shm_id should be uint8_t > - make reg a local variable > - add #address-cells and #size-cells properties > - fix alignment > --- > xen/arch/arm/domain_build.c | 144 ++++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/domain.h | 1 + > xen/arch/arm/include/asm/setup.h | 1 + > 3 files changed, 146 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 8d299a3616..f08606d2c0 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -894,6 +894,26 @@ static int __init allocate_shared_memory(struct domain *d, > return ret; > } > > +static int __init append_shm_bank_to_domain(struct domain *d, > + paddr_t start, paddr_t size, > + u32 shm_id) > +{ > + /* Allocate memory at first insertion. */ > + if ( d->arch.shm_mem == NULL ) > + { > + d->arch.shm_mem = xzalloc(struct meminfo); > + if ( d->arch.shm_mem == NULL ) > + return -ENOMEM; > + } > + > + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].start = start; > + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].size = size; > + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].shm_id = shm_id; > + d->arch.shm_mem->nr_banks++; > + > + return 0; > +} Can we call xfree(d->arch.shm_mem) at domain destruction? Even better, we might be able to call it earlier, soon after the make_resv_memory_node() call because we don't need it any longer after that? > static int __init process_shm(struct domain *d, > const struct dt_device_node *node) > { > @@ -975,6 +995,14 @@ static int __init process_shm(struct domain *d, > if ( ret ) > return ret; > } > + > + /* > + * Record static shared memory region info for later setting > + * up shm-node in guest device tree. > + */ > + ret = append_shm_bank_to_domain(d, gbase, psize, shm_id); > + if ( ret ) > + return ret; > } > > return 0; > @@ -1305,6 +1333,117 @@ static int __init make_memory_node(const struct domain *d, > return res; > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + unsigned long i = 0; > + int res = 0; > + > + if ( mem->nr_banks == 0 ) > + return -ENOENT; > + > + /* > + * For each shared memory region, a range is exposed under > + * the /reserved-memory node as a child node. Each range sub-node is > + * named xen-shmem@
. > + */ > + dt_dprintk("Create xen-shmem node\n"); > + > + for ( ; i < mem->nr_banks; i++ ) > + { > + uint64_t start = mem->bank[i].start; > + uint64_t size = mem->bank[i].size; > + uint8_t shm_id = mem->bank[i].shm_id; > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > + char buf[27]; > + const char compat[] = "xen,shared-memory-v1"; > + __be32 reg[4]; > + __be32 *cells; > + unsigned int len = (addrcells + sizecells) * sizeof(__be32); > + > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); > + res = fdt_begin_node(fdt, buf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > + if ( res ) > + return res; > + > + cells = reg; > + dt_child_set_range(&cells, addrcells, sizecells, start, size); > + > + res = fdt_property(fdt, "reg", reg, len); > + if ( res ) > + return res; > + > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", > + i, start, start + size); > + > + res = fdt_property_cell(fdt, "xen,id", shm_id); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + if ( res ) > + return res; > + } > + > + return res; > +} > +#else > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + ASSERT_UNREACHABLE(); > +} > +#endif > + > +static int __init make_resv_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + int res = 0; > + /* Placeholder for reserved-memory\0 */ > + char resvbuf[16] = "reserved-memory"; > + > + if ( mem == NULL ) > + /* No shared memory provided. */ > + return 0; > + > + dt_dprintk("Create reserved-memory node\n"); > + > + res = fdt_begin_node(fdt, resvbuf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "ranges", NULL, 0); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#address-cells", addrcells); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#size-cells", sizecells); > + if ( res ) > + return res; > + > + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + > + return res; > +} > + > static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) > { > struct meminfo *ext_regions = data; > @@ -3041,6 +3180,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > if ( ret ) > goto err; > > + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, > + d->arch.shm_mem); > + if ( ret ) > + goto err; > + > /* > * domain_handle_dtb_bootmodule has to be called before the rest of > * the device tree is generated because it depends on the value of > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > index ed63c2b6f9..d0d1e12cfe 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -104,6 +104,7 @@ struct arch_domain > #endif > > bool directmap; > + struct meminfo *shm_mem; > } __cacheline_aligned; > > struct arch_vcpu > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 38e02ced36..b5909acf68 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -29,6 +29,7 @@ struct membank { > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > #ifdef CONFIG_STATIC_SHM > unsigned long nr_shm_domain; > + uint8_t shm_id ; /* ID identifier of a static shared memory bank. */ > #endif > }; > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323513.545216 (Exim 4.92) (envelope-from ) id 1nn946-0000ye-Ab; Sat, 07 May 2022 01:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323513.545216; Sat, 07 May 2022 01:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn946-0000yV-6Z; Sat, 07 May 2022 01:16:58 +0000 Received: by outflank-mailman (input) for mailman id 323513; Sat, 07 May 2022 01:16:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wm-0004gy-TW for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:24 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [2604:1380:40e1:4800::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 545316b0-cda2-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 03:09:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 79CCECE39B4; Sat, 7 May 2022 01:09:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78FD4C385A8; Sat, 7 May 2022 01:09:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 545316b0-cda2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885759; bh=ojvUw6bFrH0aOC5u6kRpyNDbEo2VhzHvbfqSK2MOr38=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=A5AEQBsTSd1d32bw/tZxjikFPWhleQrAlvjhYQOyLIyuBiUdV9zRPsWU/2bZBYKaN 5DcNRKy6jP+pm6taoIHP5WfQNtC+wDH9wxU/OADDPA4UQA4GJ2dO9YvCT5h1pt1gd5 Ik5eYSKYfWUC9No3R0YwCfCUFUeXhZwIvkSD71wWO+5tchqyPY4dCoGfEl8DKnIHeE YNbkTdTZOjXcPDStImTaOjnhtE5Ow8WR3Q6sS8K7ilqX0wfPbLRlV/25qdntEvqMkf tyjFcIyylyA/eIO9092J8uTsKGAGiqh3crfbDgSI3ejgeNBMTtW76XpokmD2ToGcDD nKlyiY8XDQIfQ== Date: Fri, 6 May 2022 18:09:18 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 7/9] xen/arm: set up shared memory foreign mapping for borrower domain In-Reply-To: <20220506072502.2177828-8-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-8-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > This commit sets up shared memory foreign mapping for borrower domain. > > If owner domain is the default dom_io, all shared domain are treated as > borrower domain. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v2 change: > - remove guest_physmap_add_shm, since for borrower domain, we only > do P2M foreign memory mapping now. > --- > xen/arch/arm/domain_build.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 089b9e99fc..8d299a3616 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -965,6 +965,16 @@ static int __init process_shm(struct domain *d, > if ( ret ) > return ret; > } > + > + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) > + { > + /* Set up P2M foreign mapping for borrower domain. */ > + ret = guest_physmap_add_pages(d, _gfn(PFN_UP(gbase)), > + _mfn(PFN_UP(pbase)), PFN_DOWN(psize), > + p2m_map_foreign_rw); > + if ( ret ) > + return ret; > + } > } > > return 0; > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 01:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 01:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323515.545220 (Exim 4.92) (envelope-from ) id 1nn946-00011z-KS; Sat, 07 May 2022 01:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323515.545220; Sat, 07 May 2022 01:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn946-00011A-F7; Sat, 07 May 2022 01:16:58 +0000 Received: by outflank-mailman (input) for mailman id 323515; Sat, 07 May 2022 01:16:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn8wy-00045S-RD for xen-devel@lists.xenproject.org; Sat, 07 May 2022 01:09:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bf8543f-cda2-11ec-a406-831a346695d4; Sat, 07 May 2022 03:09:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3D3461E61; Sat, 7 May 2022 01:09:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09109C385A9; Sat, 7 May 2022 01:09:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bf8543f-cda2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651885774; bh=aA4C8jSkYdAJjgPPvopg2ZqZSMeGrTrWfX/13ovueJk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hAfipu8E7PfevwDKq7eGsQzWAGrUlw55IfqWmCgTUqK+hCOid46uROIebGxuYFm3J 6ZFMOVwfhGaWu4TO98jrVjbZqTppdHyYuUZvlGVexChbo/utVyoE++3kl/0Jc51fU5 DckWXvc2UOURo9x9RC3krNG0zXiRH2hZ/Tfim5DzycUaBRTILyIwiMVKJzRhCLdvVZ fr1iCS7WypeE00wyHaq8TwhYsXnV7+R+6hvENAPqRiTOrfPrWNR7wXnMJ+w7RrVHmI swYS5UT0S35Q6kVqxjCXY4RJMwT2/1sr2WE6pOpXFfepL+uyYbxvuN37YxDSyzzJty 74+ygOJpYJ/TQ== Date: Fri, 6 May 2022 18:09:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 9/9] xen/arm: enable statically shared memory on Dom0 In-Reply-To: <20220506072502.2177828-10-Penny.Zheng@arm.com> Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-10-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Penny Zheng wrote: > From: Penny Zheng > > To add statically shared memory nodes in Dom0, user shall put according > static shared memory configuration under /chosen node. > > This commit adds shm-processing function process_shm in construct_dom0 > to enable statically shared memory on Dom0. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v2 change: > - no change > --- > xen/arch/arm/domain_build.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index f08606d2c0..9da0a0c88b 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2628,6 +2628,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, > if ( res ) > return res; > } > + > + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, > + d->arch.shm_mem); > + if ( res ) > + return res; > } > > res = fdt_end_node(kinfo->fdt); > @@ -3639,6 +3644,9 @@ static int __init construct_dom0(struct domain *d) > { > struct kernel_info kinfo = {}; > int rc; > +#ifdef CONFIG_STATIC_SHM > + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); > +#endif > > /* Sanity! */ > BUG_ON(d->domain_id != 0); > @@ -3673,6 +3681,12 @@ static int __init construct_dom0(struct domain *d) > allocate_memory_11(d, &kinfo); > find_gnttab_region(d, &kinfo); > > +#ifdef CONFIG_STATIC_SHM > + rc = process_shm(d, chosen); > + if ( rc < 0 ) > + return rc; > +#endif > + > /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ > rc = gic_map_hwdom_extra_mappings(d); > if ( rc < 0 ) > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Sat May 07 02:28:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 02:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323529.545237 (Exim 4.92) (envelope-from ) id 1nnAB5-0000d4-OW; Sat, 07 May 2022 02:28:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323529.545237; Sat, 07 May 2022 02:28:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAB5-0000cx-Lm; Sat, 07 May 2022 02:28:15 +0000 Received: by outflank-mailman (input) for mailman id 323529; Sat, 07 May 2022 02:28:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAB4-0000cn-MS; Sat, 07 May 2022 02:28:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAB4-0003SC-Kj; Sat, 07 May 2022 02:28:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAB4-0007B6-7p; Sat, 07 May 2022 02:28:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnAB4-0003NP-7A; Sat, 07 May 2022 02:28:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HjQzRymXft9zsXyVzJNGLzZh0EyGivJ7hd8zOzRDULM=; b=N/Ls/30gap0buBvcK/rW5gL+Hl YV5/ratyb0yfq9rJHTYpWlS/CTcQVqd3JEfe5Rat2Q7oemskTKjQsazD7eg+Al/0zfp9ScjkZdSAp xgEFEYPOREphoVFsNVaWxi0OoR9gETiEPHWiD/C8bRTdm3GoCsWV46rBHvOumeHGl4qg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170196: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 02:28:14 +0000 flight 170196 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170196/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 849 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 02:55:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 02:55:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323537.545259 (Exim 4.92) (envelope-from ) id 1nnAav-00047Y-9M; Sat, 07 May 2022 02:54:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323537.545259; Sat, 07 May 2022 02:54:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAav-00047R-6E; Sat, 07 May 2022 02:54:57 +0000 Received: by outflank-mailman (input) for mailman id 323537; Sat, 07 May 2022 02:54:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAat-00046g-T0 for xen-devel@lists.xenproject.org; Sat, 07 May 2022 02:54:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1280da6d-cdb1-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 04:54:54 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DECB14BF; Fri, 6 May 2022 19:54:54 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 922923F800; Fri, 6 May 2022 19:54:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1280da6d-cdb1-11ec-8fc4-03012f2f19d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v3 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable Date: Sat, 7 May 2022 10:54:33 +0800 Message-Id: <20220507025434.1063710-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507025434.1063710-1-Henry.Wang@arm.com> References: <20220507025434.1063710-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. Moving the call of request_irq() past local_irq_enable() on secondary cores will make sure the assertion condition in alloc_xenheap_pages(), i.e. !in_irq && local_irq_enabled() is satisfied. It is also safe because the timer and GIC maintenance interrupt will not be used until the CPU is fully online. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang --- v2 -> v3: - No changes. v1 -> v2: - Explain why the moving of code is safe in the commit message and add comments. --- xen/arch/arm/smpboot.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7bfd0a73a7..9bb32a301a 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -361,9 +361,6 @@ void start_secondary(void) init_secondary_IRQ(); - init_maintenance_interrupt(); - init_timer_interrupt(); - set_current(idle_vcpu[cpuid]); setup_cpu_sibling_map(cpuid); @@ -380,6 +377,15 @@ void start_secondary(void) cpumask_set_cpu(cpuid, &cpu_online_map); local_irq_enable(); + + /* + * Calling request_irq() after local_irq_enable() on secondary cores + * will make sure the assertion condition in alloc_xenheap_pages(), + * i.e. !in_irq && local_irq_enabled() is satisfied. + */ + init_maintenance_interrupt(); + init_timer_interrupt(); + local_abort_enable(); check_local_cpu_errata(); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat May 07 02:55:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 02:55:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323536.545249 (Exim 4.92) (envelope-from ) id 1nnAam-0003pd-Rx; Sat, 07 May 2022 02:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323536.545249; Sat, 07 May 2022 02:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAam-0003pW-Ox; Sat, 07 May 2022 02:54:48 +0000 Received: by outflank-mailman (input) for mailman id 323536; Sat, 07 May 2022 02:54:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAal-0003pQ-7r for xen-devel@lists.xenproject.org; Sat, 07 May 2022 02:54:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0cc602d5-cdb1-11ec-a406-831a346695d4; Sat, 07 May 2022 04:54:45 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73E8914BF; Fri, 6 May 2022 19:54:44 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 883673F800; Fri, 6 May 2022 19:54:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cc602d5-cdb1-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang Subject: [PATCH v3 0/2] Adjustment after introducing ASSERT_ALLOC_CONTEXT Date: Sat, 7 May 2022 10:54:32 +0800 Message-Id: <20220507025434.1063710-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before local_irq_enable on secondary cores on Arm will lead to (XEN) Xen call trace: (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 (XEN) [<0000000084000200>] 0000000084000200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 4: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** on systems without a big enough pool for xmalloc() to cater the requested size. To solve this issue, this series introduces two patches. The first one defers the calling of request_irq on secondary CPUs after local_irq_enable on Arm. The second one moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). Also take the chance to enhance the assertion in xmalloc_tlsf.c. Henry Wang (2): xen/arm: Defer request_irq on secondary CPUs after local_irq_enable xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() xen/arch/arm/smpboot.c | 12 +++++++++--- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 10 +++++++--- xen/include/xen/irq.h | 7 +++++++ 4 files changed, 23 insertions(+), 13 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat May 07 02:55:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 02:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323539.545271 (Exim 4.92) (envelope-from ) id 1nnAb3-0004Ta-IT; Sat, 07 May 2022 02:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323539.545271; Sat, 07 May 2022 02:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAb3-0004TM-FO; Sat, 07 May 2022 02:55:05 +0000 Received: by outflank-mailman (input) for mailman id 323539; Sat, 07 May 2022 02:55:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnAb2-0003pQ-Iu for xen-devel@lists.xenproject.org; Sat, 07 May 2022 02:55:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 17b6c4e7-cdb1-11ec-a406-831a346695d4; Sat, 07 May 2022 04:55:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD24F14BF; Fri, 6 May 2022 19:55:02 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4D3233F800; Fri, 6 May 2022 19:54:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17b6c4e7-cdb1-11ec-a406-831a346695d4 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Henry Wang , Wei Chen , Julien Grall Subject: [PATCH v3 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Date: Sat, 7 May 2022 10:54:34 +0800 Message-Id: <20220507025434.1063710-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507025434.1063710-1-Henry.Wang@arm.com> References: <20220507025434.1063710-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xmalloc() will use a pool for allocation smaller than a page. The pool is extended only when there are no more space. At which point, alloc_xenheap_pages() is called to add more memory. xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in alloc_xenheap_pages(). Hence, this commit moves the definition of ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT to replace the original assertion in xmalloc(). For consistency, the same assertion should be used in xfree(), and the position of the assertion should be at the beginning of the xfree(). Also take the opportunity to enhance the non-static functions xmem_pool_{alloc,free}() with the same assertion so that future callers of these two functions can be benefited. Reported-by: Wei Chen Suggested-by: Julien Grall Signed-off-by: Henry Wang --- v2 -> v3: - Add ASSERT_ALLOC_CONTEXT in xmem_pool_{alloc,free}() - Also change the assertion in xfree to ASSERT_ALLOC_CONTEXT and move the position of assertion to the beginning of the function. v1 -> v2: - No changes --- xen/common/page_alloc.c | 7 ------- xen/common/xmalloc_tlsf.c | 10 +++++++--- xen/include/xen/irq.h | 7 +++++++ 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e866e0d864..ea59cd1a4a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -162,13 +162,6 @@ static char __initdata opt_badpage[100] = ""; string_param("badpage", opt_badpage); -/* - * Heap allocations may need TLB flushes which may require IRQs to be - * enabled (except when only 1 PCPU is online). - */ -#define ASSERT_ALLOC_CONTEXT() \ - ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) - /* * no-bootscrub -> Free pages are not zeroed during boot. */ diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index d2ad909502..75bdf18c4e 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -378,6 +378,8 @@ void *xmem_pool_alloc(unsigned long size, struct xmem_pool *pool) int fl, sl; unsigned long tmp_size; + ASSERT_ALLOC_CONTEXT(); + if ( size < MIN_BLOCK_SIZE ) size = MIN_BLOCK_SIZE; else @@ -456,6 +458,8 @@ void xmem_pool_free(void *ptr, struct xmem_pool *pool) struct bhdr *b, *tmp_b; int fl = 0, sl = 0; + ASSERT_ALLOC_CONTEXT(); + if ( unlikely(ptr == NULL) ) return; @@ -594,7 +598,7 @@ void *_xmalloc(unsigned long size, unsigned long align) { void *p = NULL; - ASSERT(!in_irq()); + ASSERT_ALLOC_CONTEXT(); if ( !size ) return ZERO_BLOCK_PTR; @@ -697,11 +701,11 @@ void *_xrealloc(void *ptr, unsigned long size, unsigned long align) void xfree(void *p) { + ASSERT_ALLOC_CONTEXT(); + if ( p == NULL || p == ZERO_BLOCK_PTR ) return; - ASSERT(!in_irq()); - if ( !((unsigned long)p & (PAGE_SIZE - 1)) ) { unsigned long size = PFN_ORDER(virt_to_page(p)); diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index d8beadd16b..300625e56d 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -10,6 +10,13 @@ #include #include +/* + * Heap allocations may need TLB flushes which may require IRQs to be + * enabled (except when only 1 PCPU is online). + */ +#define ASSERT_ALLOC_CONTEXT() \ + ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) + struct irqaction { void (*handler)(int, void *, struct cpu_user_regs *); const char *name; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat May 07 03:35:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 03:35:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323564.545282 (Exim 4.92) (envelope-from ) id 1nnBDp-0000rD-Iu; Sat, 07 May 2022 03:35:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323564.545282; Sat, 07 May 2022 03:35:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnBDp-0000r6-FA; Sat, 07 May 2022 03:35:09 +0000 Received: by outflank-mailman (input) for mailman id 323564; Sat, 07 May 2022 03:35:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnBDn-0000qw-PI; Sat, 07 May 2022 03:35:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnBDn-0004aW-Nc; Sat, 07 May 2022 03:35:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnBDn-0001v2-8X; Sat, 07 May 2022 03:35:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnBDn-0000Dw-87; Sat, 07 May 2022 03:35:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HgIBxm8LyckbUP9sbsLM3Pjq+l+FIxwjUEoC/Anmf5E=; b=woAKCvjUz64AT/cfthqGe48DZV aFv3njLeOaodg/sCGb2azmzV4aN334Zs1dg80k/j/EZPr3dk1+tXwW9YfPHjmPwInVoVDZGV/MYaq 7fqNC0ztDZ+KzIq4Qspr9/DIAI0MbDQhLnmrjyEEhPvQ+hTXXUttBZOwEExfAmaDCa5g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170198: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 03:35:07 +0000 flight 170198 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170198/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 850 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 04:27:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 04:27:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323571.545293 (Exim 4.92) (envelope-from ) id 1nnC1z-0006CR-IY; Sat, 07 May 2022 04:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323571.545293; Sat, 07 May 2022 04:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnC1z-0006CK-Fd; Sat, 07 May 2022 04:26:59 +0000 Received: by outflank-mailman (input) for mailman id 323571; Sat, 07 May 2022 04:26:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnC1x-0006CE-FJ for xen-devel@lists.xenproject.org; Sat, 07 May 2022 04:26:57 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec6a3549-cdbd-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 06:26:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AAC565C00D4; Sat, 7 May 2022 00:26:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 07 May 2022 00:26:53 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 May 2022 00:26:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec6a3549-cdbd-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651897613; x= 1651984013; bh=UjF4a0x/jI5KpzirwbXr3IlpbRiot7nUSen/bltVqso=; b=P wPcP1SILJ7ZGyel76cqDNTaRG8hPf0Y8rqeMMJdJWZA7YkBvesqugCxHdYb6qdUZ ZvTYycivdB8x7WKYzPYBLPFpqldtYBSaFli36es/IG1jssTdkSMhgB+yCFvrH3hL Lg9E3S4iRGjp7igVwqNv+wsJXat0eFT5IllJEAO2qg2nZWiTyAGM2afs7i3QW2Bx wBFX5rG8jNsGlK58o15AiOyqhC2p7nle+R+KKEn5NlxkLwmZp0vTqGlLowcTH71y +mGWGvuVfD5m+doPpen4OhChwL97ywFZvgCgTfNquNL5GVPp93TVk3T/mlkIGZGn CFx5dLL+jiC6gCVW1sUFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeggdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Date: Sat, 7 May 2022 00:26:48 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sIQBc1dY37ee9/6a" Content-Disposition: inline In-Reply-To: --sIQBc1dY37ee9/6a Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 7 May 2022 00:26:48 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 On Fri, May 06, 2022 at 12:59:05PM +0200, Jan Beulich wrote: > On 05.05.2022 07:38, Demi Marie Obenour wrote: > > @@ -1056,13 +1091,11 @@ static void __init efi_exit_boot(EFI_HANDLE Ima= geHandle, EFI_SYSTEM_TABLE *Syste > > EFI_STATUS status; > > UINTN info_size =3D 0, map_key; > > bool retry; > > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP > > unsigned int i; > > -#endif > > =20 > > efi_bs->GetMemoryMap(&info_size, NULL, &map_key, > > &efi_mdesc_size, &mdesc_ver); > > - info_size +=3D 8 * efi_mdesc_size; > > + info_size +=3D 8 * (efi_mdesc_size + 1); >=20 > I think I did ask on an earlier version already why you're making this > change. It continues to look to me like a leftover which was needed by > an early version only. Will revert in v5. > > @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE Imag= eHandle, EFI_SYSTEM_TABLE *Syste > > if ( EFI_ERROR(status) ) > > PrintErrMesg(L"Cannot obtain memory map", status); > > =20 > > + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) > > + { > > + if ( !is_esrt_valid(efi_memmap + i) ) > > + continue; >=20 > Instead of repeating the size calculation below, could you make the > function (with an altered name) simply return the size (and zero if > not [valid] ESRT), simplifying things below? Will fix in v5. > > + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type !=3D > > + EfiRuntimeServicesData ) > > + { > > + /* ESRT needs to be moved to memory of type EfiRuntime= ServicesData > > + * so that the memory it is in will not be used for ot= her purposes */ >=20 > Nit: Comment style. Will fix in v5. > > + size_t esrt_size =3D offsetof(ESRT, Entries) + > > + ((ESRT *)esrt)->Count * sizeof(ESRT_ENTRY); > > + void *new_esrt =3D NULL; > > + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData= , esrt_size, &new_esrt); >=20 > Nit: Please have a blank line between declaration(s) and statement(s). Will fix in v5. > > + if ( status !=3D EFI_SUCCESS ) > > + { > > + PrintErrMesg(L"Cannot allocate memory for ESRT", s= tatus); >=20 > Neither this nor ... >=20 > > + break; > > + } > > + memcpy(new_esrt, (void *)esrt, esrt_size); > > + status =3D efi_bs->InstallConfigurationTable(&esrt_gui= d, new_esrt); > > + if ( status !=3D EFI_SUCCESS ) > > + { > > + PrintErrMesg(L"Cannot install new ESRT", status); > > + efi_bs->FreePool(new_esrt); >=20 > ... this ought to be fatal to the booting of Xen. Yet PrintErrMesg() > ends in blexit(). Whoops! I did not realized PrintErrMsg() was fatal. > > + } > > + } > > + break; > > + } > > + > > efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memma= p_size, > > efi_mdesc_size, mdesc_ver); >=20 > The allocation may have altered the memory map and hence invalidated what > was retrieved just before. You'd need to "continue;" without setting > "retry" to true, but then the question is why you make this allocation > after retrieving the memory map in the first place. It's not entirely > clear to me if it can be done _much_ earlier (if it can, doing it earlier > would of course be better), but since you need to do it before > ExitBootServices() anyway, and since you will need to call GetMemoryMap() > afterwards again, you could as well do it before calling GetMemoryMap(). This would mean the allocation would need to be unconditional. Right now, I avoid the allocation if it is not necessary. > > --- a/xen/common/efi/efi.h > > +++ b/xen/common/efi/efi.h > > @@ -10,6 +10,23 @@ > > #include > > #include > > =20 > > +typedef struct _ESRT_ENTRY { > > + EFI_GUID FwClass; > > + UINT32 FwType; > > + UINT32 FwVersion; > > + UINT32 FwLowestSupportedVersion; > > + UINT32 FwCapsuleFlags; > > + UINT32 FwLastAttemptVersion; > > + UINT32 FwLastAttemptStatus; > > +} ESRT_ENTRY; > > + > > +typedef struct _ESRT { > > + UINT32 Count; > > + UINT32 Max; > > + UINT64 Version; > > + ESRT_ENTRY Entries[]; > > +} ESRT; >=20 > I'm pretty sure I did indicate before that types used in just a single > source file should be put in that source file, unless we obtain them > by importing a header (e.g. the ones in include/efi/) from elsewhere. Will fix in v5. > > --- a/xen/common/efi/runtime.c > > +++ b/xen/common/efi/runtime.c > > @@ -269,7 +269,7 @@ int efi_get_info(uint32_t idx, union xenpf_efi_info= *info) > > case XEN_FW_EFI_MEM_INFO: > > for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) > > { > > - EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i; > > + const EFI_MEMORY_DESCRIPTOR *desc =3D efi_memmap + i; > > u64 len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; > > =20 > > if ( info->mem.addr >=3D desc->PhysicalStart && >=20 > With the restructured approach I don't think this stray change should > be left in here anymore. Or am I overlooking anything requiring this > adjustment? It=E2=80=99s a trivial cleanup but I can get rid of it. > > --- a/xen/include/efi/efiapi.h > > +++ b/xen/include/efi/efiapi.h > > @@ -882,6 +882,9 @@ typedef struct _EFI_BOOT_SERVICES { > > #define SAL_SYSTEM_TABLE_GUID \ > > { 0xeb9d2d32, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, = 0xc1, 0x4d} } > > =20 > > +#define ESRT_GUID \ > > + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6,= 0x21, 0x80} } >=20 > Like above I'm pretty sure I did ask that you do not alter this > imported header. If gnu-efi now has these definitions, we should > import them all in one go (i.e. then the two struct declarations > would also want to go into their appropriate place under include/efi/. > Otherwise this wants putting next to the other GUIDs defined in > boot.c. Will fix in v5. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --sIQBc1dY37ee9/6a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ19QwACgkQsoi1X/+c IsFS5RAA0P8Hl2FV9XnN6W5BN591niY0nEeEW+804VSnesT0pTrhjbhLFP10SV21 a4ubt6aRhEJN5CxAmq3kX+D28JYIEE3UC+HB0V66UnsRoBZTKXs298fzijNxJ7rw a5GqIdQOWXjaNEoyAMN7cdLNo1MdDo60MjsNnIP4SAp7ppOKcPvFDSrUkBsIuWcX MwzGafQPuML1b1BQj6sZWknTcZbE6uhCXw4zncelIptKRDjk6QaRYbTWti+Xtm/d RPmhLSwwOSE5JgEQKZ7CvhKnDT7DEvsZvnZf0MmXf8aSdFZLXFt8bER61avHgBCG 3MMV8LtPo7nkASDWS9f32Q+bFApdC4iE3gFtM+VfGHicyptEg1gw89P3WmX49FyR wFpQ/v+vSn1+CoXmopioUx5AyrWfRbh33iN9j0T2IPq6tpkAGso/EQVOV2R/LY9X YI2b5g/KSzXuRV7Aqj+cU2Mj3gCAR5ifbDUc4AnmxXsY+uFA98w2E5deK1MMfrAM adXgdXfyAGmuW9el7HP4w8zW2EZZzTjWsDuCF4UVW4igxJ4hz45w7PuyutM3/5yz ub2LEWilq9ub5710seI7YEy9EReM+aoE/2U3DmJ5ftBi8xiuZbB6jNGa+BykY4ei 1FzXe684SMjkWPg/0kKrE4sfdyTSWPCAMWiKgMHDPAO75jD0OHM= =VTnj -----END PGP SIGNATURE----- --sIQBc1dY37ee9/6a-- From xen-devel-bounces@lists.xenproject.org Sat May 07 04:32:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 04:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323581.545304 (Exim 4.92) (envelope-from ) id 1nnC6s-0007fj-8c; Sat, 07 May 2022 04:32:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323581.545304; Sat, 07 May 2022 04:32:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnC6s-0007fc-5Z; Sat, 07 May 2022 04:32:02 +0000 Received: by outflank-mailman (input) for mailman id 323581; Sat, 07 May 2022 04:32:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnC6r-0007fW-Cu for xen-devel@lists.xenproject.org; Sat, 07 May 2022 04:32:01 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a288b875-cdbe-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 06:32:00 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 413775C006B; Sat, 7 May 2022 00:31:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 07 May 2022 00:31:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 May 2022 00:31:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a288b875-cdbe-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651897919; x=1651984319; bh=VHaYN/l9+j9mz nxryBHFWC+rCMLhHeDMBWZDG/SBAUQ=; b=yNGj3p3dq13CA+Mrk5kbMKu2PPeRq tYICJdoWjoIEQexwBkWvESWiXYAa7H3AWBq9z+Lli5QTdEJCD9so5TFaWQRk1bUD qRtTvcAoTJWEXbHRyTnEoxphFbWt3qqxKY0Det+kpIfaFL8chV8sSZRONxAja75q Ah8LwGpr694jTBTy360wCoolb1JB7eO2Ak/IIdxc0hz9zc0EiGPB+Divz9DJVqOr 6mA0KpYWUWEw2ZguT2sW9jRbKa5G0opyvOS52v738/9mlUnj++2X381ub0BljXTL 0m/mYtXTE8heBKLxdPgIAYfRU0wgir0npKPLejsRcByr3VowKaRq1Lmvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeggdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggusehgtderredttdejnecuhfhrohhmpeffvghmihcuofgr rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhmqeenucggtffrrghtthgvrhhnpedukeetkeekkeekvdetgedtkeetffdthfdt tdfgieffhfekhefhjefhveeggfeiheenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhi sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Sat, 7 May 2022 00:31:54 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v5] Preserve the EFI System Resource Table for dom0 Message-ID: <65b8c4b59ea92c6d79dcd60ba3a0b85a5e1609b5.1651897415.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xdYGmixzvS7L29mQ" Content-Disposition: inline --xdYGmixzvS7L29mQ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 7 May 2022 00:31:54 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v5] Preserve the EFI System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification =C2=A723.= 4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour --- xen/common/efi/boot.c | 106 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..3d56422dfa 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -39,6 +39,25 @@ { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b,= 0x23} } #define APPLE_PROPERTIES_PROTOCOL_GUID \ { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a= , 0xe0} } +#define ESRT_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21,= 0x80} } + +typedef struct _ESRT_ENTRY { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 FwLowestSupportedVersion; + UINT32 FwCapsuleFlags; + UINT32 FwLastAttemptVersion; + UINT32 FwLastAttemptStatus; +} ESRT_ENTRY; + +typedef struct _ESRT { + UINT32 Count; + UINT32 Max; + UINT64 Version; + ESRT_ENTRY Entries[]; +} ESRT; =20 typedef EFI_STATUS (/* _not_ EFIAPI */ *EFI_SHIM_LOCK_VERIFY) ( @@ -567,6 +586,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I= MAGE *loaded_image) } #endif =20 +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; + +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start =3D desc->PhysicalStart; + const ESRT *esrt_ptr; + + len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR ) + return 0; + if ( physical_start > esrt || esrt - physical_start >=3D len ) + return 0; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type !=3D EfiRuntimeServicesData) && + (desc->Type !=3D EfiBootServicesData) ) + return 0; + available_len =3D len - (esrt - physical_start); + if ( available_len <=3D offsetof(ESRT, Entries) ) + return 0; + available_len -=3D offsetof(ESRT, Entries); + esrt_ptr =3D (const ESRT *)esrt; + if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count ) + return 0; + if ( esrt_ptr->Count > available_len / sizeof(esrt_ptr->Entries[0]) ) + return 0; + return esrt_ptr->Count * sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +896,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTP= UT_PROTOCOL *gop, return gop_mode; } =20 +static EFI_GUID __initdata esrt_guid =3D ESRT_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +921,8 @@ static void __init efi_tables(void) efi.smbios =3D (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt =3D (UINTN)efi_ct[i].VendorTable; } =20 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1056,9 +1111,7 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHand= le, EFI_SYSTEM_TABLE *Syste EFI_STATUS status; UINTN info_size =3D 0, map_key; bool retry; -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP unsigned int i; -#endif =20 efi_bs->GetMemoryMap(&info_size, NULL, &map_key, &efi_mdesc_size, &mdesc_ver); @@ -1067,6 +1120,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan= dle, EFI_SYSTEM_TABLE *Syste if ( !efi_memmap ) blexit(L"Unable to allocate memory for EFI memory map"); =20 + efi_memmap_size =3D info_size; + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, + efi_memmap, &map_key, + &efi_mdesc_size, + &mdesc_ver); + if ( EFI_ERROR(status) ) + PrintErrMesg(L"Cannot obtain memory map", status); + + /* Try to obtain the ESRT. Errors are not fatal. */ + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) + { + /* + * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * so that the memory it is in will not be used for other purposes. + */ + void *new_esrt =3D NULL; + size_t esrt_size =3D get_esrt_size(efi_memmap + i); + + if ( !esrt_size ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D=3D + EfiRuntimeServicesData ) + break; /* ESRT already safe from reuse */ + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + &new_esrt); + if ( status =3D=3D EFI_SUCCESS && new_esrt ) + { + memcpy(new_esrt, (void *)esrt, esrt_size); + status =3D efi_bs->InstallConfigurationTable(&esrt_guid, new_e= srt); + if ( status !=3D EFI_SUCCESS ) + { + PrintStr(L"Cannot install new ESRT\r\n"); + efi_bs->FreePool(new_esrt); + } + } + else + PrintStr(L"Cannot allocate memory for ESRT\r\n"); + break; + } + for ( retry =3D false; ; retry =3D true ) { efi_memmap_size =3D info_size; @@ -1753,3 +1846,12 @@ void __init efi_init_memory(void) unmap_domain_page(efi_l4t); } #endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --xdYGmixzvS7L29mQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ19j4ACgkQsoi1X/+c IsGgghAAoP34EA3hSfs7Hrj2ghAeCKoA3N0RIZ4scbyOjmIUm7RhCd9Z+goDfMCU UaDYFaF7+s5g+Tqp4nVyRMTtup0frD01o6NQcbs/VKxxkiOQTeSHn7suT53o8nya grsK6tjh9s2J7suKZ8G8HiNsVq7VpUHMNE+iY+O2+kAkkIzhDpaitf/blPMTYhXx SLIEIpktUlZpG1ViWdFzKo7Q0Tq5L+KuEoMgx653q8bqe5xLhxuE+gLnfYLwNBko WLcO43+ru2rKCNj1TY4N/FX+d4goAHnk6N6D3EKRoE22Lb8+BPWQCA9hCN6wmy30 jGcTj/hIVAJg9rukSpWsqwO20hxBpFdd4tcdB8brbWgPvjgampovp+D4wo7lmRds iE2Ib9ze2MyOlwLyTXqLvndMfndqicnbJb4ga9A7GNIdU1upUxm35ie7NhCXvU7m 6AHbKxsNtFa4s8F6D28YcqqtbYCZcIMsoDbMrcDDgvrJXEEaVej9OroyyStuXiqY iGhPKzo9RkuykkSH1VAPrYaryYCgRtCwHJKGL6KeziCTXhZhKQ9JVchJoOI39P0/ vfeMvE1uTUuwCbu68kiIeWrhnIKPvf/aEU1DU1xOvd3RKX9xVJZ1XGTyzj5BW8qV /QSdGpsAj66Qw+Alkdr0GoXKR4F1tF49kPDpz1GStIu5peXDC2U= =QQfX -----END PGP SIGNATURE----- --xdYGmixzvS7L29mQ-- From xen-devel-bounces@lists.xenproject.org Sat May 07 05:42:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 05:42:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323590.545314 (Exim 4.92) (envelope-from ) id 1nnDDD-0006Pr-7M; Sat, 07 May 2022 05:42:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323590.545314; Sat, 07 May 2022 05:42:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnDDD-0006Pk-4g; Sat, 07 May 2022 05:42:39 +0000 Received: by outflank-mailman (input) for mailman id 323590; Sat, 07 May 2022 05:42:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnDDC-0006Pa-6Z; Sat, 07 May 2022 05:42:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnDDC-0007Bm-36; Sat, 07 May 2022 05:42:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnDDB-0008VQ-Pl; Sat, 07 May 2022 05:42:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnDDB-0000qI-Ku; Sat, 07 May 2022 05:42:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WE/VXIrkUkBqa8m2WfpNme7PhGtcPKVwav1/U3x0RQI=; b=YUOSVm/5m9oMbJBoJkvhK/594j OaNcDVFS8gFUZVmQz0dOM+bjEvDI1bcZECKUxFPI4VD2deqRg9lVxhp02ESAYlJl4HLzcT17YBSpV JiGQN+vGT8y9SNotmCqNj99USAjeUlB1zGR7m+swVCfbjxrWkdYR+hMju9gE+Y3u0EA0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170200: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 05:42:37 +0000 flight 170200 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170200/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 851 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 05:55:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 05:55:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323453.545326 (Exim 4.92) (envelope-from ) id 1nnDP6-0007vx-BZ; Sat, 07 May 2022 05:54:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323453.545326; Sat, 07 May 2022 05:54:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnDP6-0007vq-8K; Sat, 07 May 2022 05:54:56 +0000 Received: by outflank-mailman (input) for mailman id 323453; Fri, 06 May 2022 22:30:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nn6T8-0006wS-AF for xen-devel@lists.xenproject.org; Fri, 06 May 2022 22:30:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25e36b85-cd8c-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 00:30:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E99FB60B28; Fri, 6 May 2022 22:30:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA910C385A8; Fri, 6 May 2022 22:30:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25e36b85-cd8c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651876234; bh=sxTU7PppLMUUauXKN/Szps48K3+Yp2KuJRpingZK3pc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SDBkPEfCg1pTGI8Srn8739MyPkk2qMvSwV5sgShyDnzwm2lTu+dc0YamxXpUd+wDB kQej8guNE45PJAKhANDPCD6M2I4/LJ6fWESpOBSJWaVip8jbACe5/ga4LBByuK1YpK AkA//mqxjAC19szynaJE4BOdiKcR5dJRdP20m/z89Xetfoy9/QHLLoGPEcA8dhdJRl QHnws7EP1tPtJMFxLJyPzZzlukTQpemzHiWMBmJH0EYpwV6nae3L38HZu1twa4HhPm 2FYcfdXI14oxzvGIIlBpMyRbIBw8gIRil/yEq9nphSPTscJeQdv5AoP7tRldrWfj7x 4IJ1vYhpVH4gA== Date: Sat, 7 May 2022 01:32:08 +0300 From: Jarkko Sakkinen To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe Subject: Re: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() Message-ID: References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-16-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505081640.17425-16-jgross@suse.com> On Thu, May 05, 2022 at 10:16:34AM +0200, Juergen Gross wrote: > Simplify tpmfront's ring creation and removal via xenbus_setup_ring() > and xenbus_teardown_ring(). > > Signed-off-by: Juergen Gross Please add to the commit message why these provide an equivalent functionality. BR, Jarkko From xen-devel-bounces@lists.xenproject.org Sat May 07 06:43:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 06:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323601.545337 (Exim 4.92) (envelope-from ) id 1nnEAI-0004ge-H1; Sat, 07 May 2022 06:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323601.545337; Sat, 07 May 2022 06:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEAI-0004gV-1g; Sat, 07 May 2022 06:43:42 +0000 Received: by outflank-mailman (input) for mailman id 323601; Sat, 07 May 2022 06:43:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEAG-0004gP-2g for xen-devel@lists.xenproject.org; Sat, 07 May 2022 06:43:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1a::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0522b857-cdd1-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 08:43:36 +0200 (CEST) Received: from AS8PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:20b:310::17) by VI1PR08MB4207.eurprd08.prod.outlook.com (2603:10a6:803:ed::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Sat, 7 May 2022 06:43:32 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::50) by AS8PR04CA0012.outlook.office365.com (2603:10a6:20b:310::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21 via Frontend Transport; Sat, 7 May 2022 06:43:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Sat, 7 May 2022 06:43:31 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Sat, 07 May 2022 06:43:31 +0000 Received: from 0158c3fa1218.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B14774C5-6F5D-42C0-A8D6-96582F17B614.1; Sat, 07 May 2022 06:43:20 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0158c3fa1218.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 07 May 2022 06:43:20 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM9PR08MB7071.eurprd08.prod.outlook.com (2603:10a6:20b:415::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sat, 7 May 2022 06:43:18 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5206.024; Sat, 7 May 2022 06:43:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0522b857-cdd1-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KtBIBoPTFLOdCeKXpGMrNhN4uf+jGeH45NtKrSplykV2dAyngvP9CYpxFhHUmg/jgStPibUi5DPV/eaEs2k0CtTUjqbjEqKnv0yC2W/uZLt40qErbbGXqiXawNgLGjOc2azOQvp/f46qX2Sev0KEceTV/9l9VMW5feoykrSG8roBaUKV4QEQjtx8J4GEgjNCvrHv3q0dKocRnESjNJZITyi3A8nJqmWGUsKArW0HXVb2hWM2T1dNuC9jaelstg5khgSUWyiESNIwKq0qI1TkF9l49IU4ErnMIu/6jDVLjRLktcpdrn7qvVaWoYyIQVYH2upYbAKPL/VNPjHOMODc/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEiiX07JvvGPBAErHzJhNAJamY4VBqiqKSdmZWhzzOo=; b=YVuJ4myuZCvu/9sd3/sG7o1OjoyYkER0zdQi8FW2EyRO00hvrsuo2L/eVYG4gMIkT5Cup4U3Jucx7cAL1hohSflbj+kCca64020mpGcf0ut1+eNtlPyT00OmeDk5KzA4eicxZoeRJ6kBn43qDVASPqJGqOJI/YbYIBkPv+dFf5xUPaxEiwJoIKN5D0vFgX9kU9aX+ilYeYHYqKBYY6GyCBrX+oN56mTco+qLHfoQnlZ6B1wln+Bd13QjsBUF9gk08sdemkxpu5QU+sNsm4txwn8e56QbE2+04ILHZSbUGnD5GdXNtdzpQ8qTY3t8TfEUgfxsOgGPu4dOJu3350pgSw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yEiiX07JvvGPBAErHzJhNAJamY4VBqiqKSdmZWhzzOo=; b=sZY7Ilwd3fXNI2mS4AqwGsV9X826OUK8nHUnpH4GPCOyFjZehjJOQ3PGrjJDOuZ43xMW8Y3SYlrcPrEID3EIB/Fwy+dFYrYTR4sAty4+NbW/RcRhNpF7h2IxdOzUR/vVAlknF2P15oQLDpKdEa409/2C6shMxPat/1JWNGv0FzE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 50d55c62ad8f6493 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KkO4E+h0z8ZzKIrp3hOUF2MVb9+NQC+lW65uWeYfUl2QXBLByCx0MJO5PlRrt6/v8vyVCLQ/xdBeNmpwmk+PtMBwd95z7mEeXBStlurgJKGtnIa+V0URlYsGaKF6Cnli9habJfwMNN8xod2N4EBFDVF5SLBhctzXHc2gwMMSDNSGCqe8EzXXud632R06ULfdqOXegB9dyqyseQt/XtoWY9qEpU6GxPng3jZsOowVG1XKGBd+ny4G3pRV7RtDcEqPI4w8EJXJS3qoUdIKc0ZyQC7Vlfho8+yefRyhtB2KJ5Fgyidp7sA9NCyDZp8obRLbke7H76KOlfe6vs5R6uUmnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEiiX07JvvGPBAErHzJhNAJamY4VBqiqKSdmZWhzzOo=; b=OAtbJQaMMa5JHTH5EVBaPv/gcmHGROlQdUerXhbh5ZGiMdkHGoNdBMlKZPyZmaquRPKMyN0TayopsYyRScMUmUwc1i6PZKtapWAVO9D/EGW01+wRs+BhESPKZsQGpTkpbhqWHjmZf8Rwq8NFi/lK0Tb3tBUjZM4SdttM7wye5k+3u2lZiVPEbedwEZm2u8qBOTt/ghTQmvUHZYfNLyaBB6Fvh+UiBjUywW7FqHYUXLBcMTuVB3B6KyemecTXASlJolVvkUzssk15KMnGmysiPFVdI49wfc8wrHfy74OWkoVItsKxqtTR5VPKqqx/NMUbMWjFfb8O+YqbTo975lQS9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yEiiX07JvvGPBAErHzJhNAJamY4VBqiqKSdmZWhzzOo=; b=sZY7Ilwd3fXNI2mS4AqwGsV9X826OUK8nHUnpH4GPCOyFjZehjJOQ3PGrjJDOuZ43xMW8Y3SYlrcPrEID3EIB/Fwy+dFYrYTR4sAty4+NbW/RcRhNpF7h2IxdOzUR/vVAlknF2P15oQLDpKdEa409/2C6shMxPat/1JWNGv0FzE= From: Penny Zheng To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Wei Chen , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 1/9] xen/arm: introduce static shared memory Thread-Topic: [PATCH v2 1/9] xen/arm: introduce static shared memory Thread-Index: AQHYYRqKvHG5G59kK0mtK53ka20rwa0Sm7eAgABc2oA= Date: Sat, 7 May 2022 06:43:18 +0000 Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-2-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 85DE39E766A24C4B99039503DCD7AA5F.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: dfdcfa57-5247-4ee7-74db-08da2ff4e6e6 x-ms-traffictypediagnostic: AM9PR08MB7071:EE_|VE1EUR03FT022:EE_|VI1PR08MB4207:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NXIj/gXDCnFJ9jFd9hd3yDDWiYTRVgdrZbONPSqJQOxDkPNNQrgpR5vavr938BwLYrKMGuA7nX5ui9AffvfaZ0Gtr9sSILClbQy7gwXwyFnHSAVpi0NjebcX7bz3PjjRgX9RAq+jJacx1Bw7TiMFKBGa0v69AIpQ395PZD/+H6fCBfHC+aK9Nh2dFnGZFnIP/M7nH+8uiEJcNJpnrd7Kb9VlunScQrmkzctNUzBtMBXuD9ZERQjh+c/TAj6fVjpNg9YzkzIxN3RMHMQaBtnhcbPHhJaGrKXLGlDxCixKyRkzXTTliFmNw2z2RQpdRI2GA0sKmjxTOTd5DecLbHcHA1zanPWlqVyHJXK9rHwNRZuDHggOCJPzaH4tUrAUE79GjVg6hRur46IFJ1Yf7lFcQZm4Bz19DpHJdmARhKnysU5Q4jLTp0qHZ8TPz14XuhzEZbe5GbjgQxknXt8fKI5UvlhPD5LQ1EXQbKxWbiIw06KsKCF1vt5p/d8HKLClKSFnH9W+gt6mOhIeWLVWEH1AuAyrbJn/uUzIGE0YAiDJidsdVNybTCAj3UZ80tHje33EvZGf0sJzDSZ2C7b0HWxw3fkAeefV9sSnIYU+zhVM1fJjSdTfqjGVjDJdegLfOGANSigwhgGabjY3IoC9D7L/mkRc71OWprwknScIPczus+mtJm9p0G5HNp+dpJDIjHOW4DK3coWnLGlOhWrdxzyAQv7SbxJy5OKyZ3Tl+FvWGKS4W4gO8UM3oWfJd/MEEIeB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(33656002)(122000001)(71200400001)(4326008)(9686003)(38100700002)(8676002)(55016003)(38070700005)(26005)(7696005)(66476007)(53546011)(508600001)(66946007)(5660300002)(66446008)(6916009)(52536014)(54906003)(76116006)(316002)(64756008)(8936002)(186003)(83380400001)(86362001)(2906002)(30864003)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7071 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fef89b69-b8f3-41ce-4d83-08da2ff4deb6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T/csahFeg7hIciyhOFG7ZYXnVMqljv7kOpGvabZIu0cwZSH8MgmF+sWzWEuktrX1RS78N05weQw5qEgSP6TSyv76bu+Za7IySPnZf8n9ytgbZtSDXbv8hBSaRz1wRLvuHZt4LjGybtaCQqi2G3ajf5M6sPusM0GWew1qL9UduNHv1wu3yIf1ksYTZrgKO2gkJXgF8YaohA8MiWAF/qMqq2tMYXq+7WA0COua49EF7k8W5W02deNDkIwyf04qRMUad5snyQCRhT2/qi+1ZTV0xoI9abt+xvZFF8DgEz01HiPExvN+eDPdRLX2wpkz7kdqXcWoJ9sHJsblH/tuOFvlu0eD2pjX6kyYclZ9b3rXWe9HjOAHEmQ9tcS+tMDGYiba2D1ExsrZIDKNRy4v1/0UOSCzUkeYUOhEO2gWzE007U3lwgx6HNUVBAVqFb/2DDuX6OHd62PX2r1xdibUvRC4jr0A0SAkFZLSgXPC/YNV7SBX3KprSZz6kQFCnJy5UiK4jJg0K/k2V47pYnkRpbgVkKB690CcqGafa8aZQ10shLIhbV/580nogAjjungnmISLLMdpsaUSZ9OL107dHFduEntqYbMXGLcbQUKQvg1+g0EhyATUxCfax3xybgxhNpwICd/83GRYWCXAxexEAWvylNJbgwF2otKYVazcZcx5SD1EowvFuFwGkbJ/FZLuqnpe X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(9686003)(26005)(7696005)(336012)(53546011)(6506007)(186003)(83380400001)(107886003)(47076005)(508600001)(86362001)(70206006)(70586007)(4326008)(6862004)(8676002)(54906003)(82310400005)(40460700003)(36860700001)(316002)(55016003)(33656002)(356005)(5660300002)(30864003)(81166007)(2906002)(8936002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2022 06:43:31.7387 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfdcfa57-5247-4ee7-74db-08da2ff4e6e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4207 Hi Stefano > -----Original Message----- > From: Stefano Stabellini > Sent: Saturday, May 7, 2022 9:08 AM > To: Penny Zheng > Cc: xen-devel@lists.xenproject.org; Wei Chen ; Stefano > Stabellini ; Julien Grall ; Bertr= and > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v2 1/9] xen/arm: introduce static shared memory >=20 > On Fri, 6 May 2022, Penny Zheng wrote: > > From: Penny Zheng > > > > This patch serie introduces a new feature: setting up static shared > > memory on a dom0less system, through device tree configuration. > > > > This commit parses shared memory node at boot-time, and reserve it in > > bootinfo.reserved_mem to avoid other use. > > > > This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap > > static-shm-related codes, and this option depends on static memory( > > CONFIG_STATIC_MEMORY). That's because that later we want to reuse a > > few helpers, guarded with CONFIG_STATIC_MEMORY, like > > acquire_staticmem_pages, etc, on static shared memory. > > > > Signed-off-by: Penny Zheng >=20 > Thanks Penny, this version of the series is already so much better than v= 1! I > have only few minor comments left on the series. One NIT at the bottom of > this file. > >=20 > > --- > > v2 change: > > - document refinement > > - remove bitmap and use the iteration to check > > - add a new field nr_shm_domain to keep the number of shared domain > > --- > > docs/misc/arm/device-tree/booting.txt | 120 > ++++++++++++++++++++++++++ > > xen/arch/arm/Kconfig | 6 ++ > > xen/arch/arm/bootfdt.c | 68 +++++++++++++++ > > xen/arch/arm/include/asm/setup.h | 3 + > > 4 files changed, 197 insertions(+) > > > > diff --git a/docs/misc/arm/device-tree/booting.txt > > b/docs/misc/arm/device-tree/booting.txt > > index a94125394e..e63ce171fc 100644 > > --- a/docs/misc/arm/device-tree/booting.txt > > +++ b/docs/misc/arm/device-tree/booting.txt > > @@ -355,3 +355,123 @@ device-tree: > > > > This will reserve a 512MB region starting at the host physical > > address > > 0x30000000 to be exclusively used by DomU1. > > + > > +Static Shared Memory > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +The static shared memory device tree nodes allow users to statically > > +set up shared memory on dom0less system, enabling domains to do > > +shm-based communication. > > + > > +- compatible > > + > > + "xen,domain-shared-memory-v1" > > + > > +- xen,shm-id > > + > > + An u8 value represents the unique identifier of the shared memory = region. > > + The maximum identifier shall be "xen,shm-id =3D <0xff>". > > + > > +- xen,shared-mem > > + > > + An array takes a physical address, which is the base address of th= e > > + shared memory region in host physical address space, a size, and a= guest > > + physical address, as the target address of the mapping. The number= of > cells > > + for the host address (and size) is the same as the guest pseudo-ph= ysical > > + address and they are inherited from the parent node. > > + > > +- role (Optional) > > + > > + A string property specifying the ownership of a shared memory regi= on, > > + the value must be one of the following: "owner", or "borrower" > > + A shared memory region could be explicitly backed by one domain, w= hich > is > > + called "owner domain", and all the other domains who are also shar= ing > > + this region are called "borrower domain". > > + If not specified, the default value is "borrower" and owner is > > + "dom_shared", a system domain. > > + > > +As an example: > > + > > +chosen { > > + #address-cells =3D <0x1>; > > + #size-cells =3D <0x1>; > > + xen,xen-bootargs =3D "console=3Ddtuart dtuart=3Dserial0 bootscrub= =3D0"; > > + > > + ...... > > + > > + /* this is for Dom0 */ > > + dom0-shared-mem@10000000 { > > + compatible =3D "xen,domain-shared-memory-v1"; > > + role =3D "owner"; > > + xen,shm-id =3D <0x0>; > > + xen,shared-mem =3D <0x10000000 0x10000000 0x10000000>; > > + } > > + > > + domU1 { > > + compatible =3D "xen,domain"; > > + #address-cells =3D <0x1>; > > + #size-cells =3D <0x1>; > > + memory =3D <0 131072>; > > + cpus =3D <2>; > > + vpl011; > > + > > + /* > > + * shared memory region identified as 0x0(xen,shm-id =3D <0x0>= ) > > + * is shared between Dom0 and DomU1. > > + */ > > + domU1-shared-mem@10000000 { > > + compatible =3D "xen,domain-shared-memory-v1"; > > + role =3D "borrower"; > > + xen,shm-id =3D <0x0>; > > + xen,shared-mem =3D <0x10000000 0x10000000 0x50000000>; > > + } > > + > > + /* > > + * shared memory region identified as 0x1(xen,shm-id =3D <0x1>= ) > > + * is shared between DomU1 and DomU2. > > + */ > > + domU1-shared-mem@50000000 { > > + compatible =3D "xen,domain-shared-memory-v1"; > > + xen,shm-id =3D <0x1>; > > + xen,shared-mem =3D <0x50000000 0x20000000 0x60000000>; > > + } > > + > > + ...... > > + > > + }; > > + > > + domU2 { > > + compatible =3D "xen,domain"; > > + #address-cells =3D <0x1>; > > + #size-cells =3D <0x1>; > > + memory =3D <0 65536>; > > + cpus =3D <1>; > > + > > + /* > > + * shared memory region identified as 0x1(xen,shm-id =3D <0x1>= ) > > + * is shared between domU1 and domU2. > > + */ > > + domU2-shared-mem@50000000 { > > + compatible =3D "xen,domain-shared-memory-v1"; > > + xen,shm-id =3D <0x1>; > > + xen,shared-mem =3D <0x50000000 0x20000000 0x70000000>; > > + } > > + > > + ...... > > + }; > > +}; > > + > > +This is an example with two static shared memory regions. > > + > > +For the static shared memory region identified as 0x0, host physical > > +address starting at 0x10000000 of 256MB will be reserved to be shared > > +between > > +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest > > +physical address space, and at 0x50000000 in DomU1 guest physical > > +address space. Dom0 is explicitly defined as the owner domain, and Dom= U1 > is the borrower domain. > > + > > +For the static shared memory region identified as 0x1, host physical > > +address starting at 0x50000000 of 512MB will be reserved to be shared > > +between > > +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest > > +physical address space, and at 0x70000000 in DomU2 guest physical > > +address space. DomU1 and DomU2 are both the borrower domain, the > > +owner domain is the default owner domain dom_shared. > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index > > ecfa6822e4..5ee9921f56 100644 > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -106,6 +106,12 @@ config TEE > > > > source "arch/arm/tee/Kconfig" > > > > +config STATIC_SHM > > + bool "Statically shared memory on a dom0less system" if > UNSUPPORTED > > + depends on STATIC_MEMORY > > + help > > + This option enables statically shared memory on a dom0less system. > > + > > endmenu > > > > menu "ARM errata workaround via the alternative framework" > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index > > e318ef9603..9bd08776a7 100644 > > --- a/xen/arch/arm/bootfdt.c > > +++ b/xen/arch/arm/bootfdt.c > > @@ -363,6 +363,70 @@ static int __init process_domain_node(const void > *fdt, int node, > > size_cells, > > &bootinfo.reserved_mem, true); } > > > > +#ifdef CONFIG_STATIC_SHM > > +static int __init process_shm_node(const void *fdt, int node, > > + u32 address_cells, u32 size_cells) > > +{ > > + const struct fdt_property *prop; > > + const __be32 *cell; > > + paddr_t paddr, size; > > + struct meminfo *mem =3D &bootinfo.reserved_mem; > > + unsigned long i; > > + > > + if ( address_cells < 1 || size_cells < 1 ) > > + { > > + printk("fdt: invalid #address-cells or #size-cells for static = shared memory > node.\n"); > > + return -EINVAL; > > + } > > + > > + prop =3D fdt_get_property(fdt, node, "xen,shared-mem", NULL); > > + if ( !prop ) > > + return -ENOENT; > > + > > + /* > > + * xen,shared-mem =3D ; > > + * Memory region starting from physical address #paddr of #size sh= all > > + * be mapped to guest physical address #gaddr as static shared mem= ory > > + * region. > > + */ > > + cell =3D (const __be32 *)prop->data; > > + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &siz= e); > > + for ( i =3D 0; i < mem->nr_banks; i++ ) > > + { > > + /* > > + * A static shared memory region could be shared between multi= ple > > + * domains. > > + */ > > + if ( paddr =3D=3D mem->bank[i].start && size =3D=3D mem->bank[= i].size ) > > + break; > > + } > > + > > + if ( i =3D=3D mem->nr_banks ) > > + { > > + if ( i < NR_MEM_BANKS ) > > + { > > + /* Static shared memory shall be reserved from any other u= se. */ > > + mem->bank[mem->nr_banks].start =3D paddr; > > + mem->bank[mem->nr_banks].size =3D size; > > + mem->bank[mem->nr_banks].xen_domain =3D true; > > + mem->nr_banks++; > > + } > > + else > > + { > > + printk("Warning: Max number of supported memory regions > reached.\n"); > > + return -ENOSPC; > > + } > > + } > > + /* > > + * keep a count of the number of domains, which later may be used = to > > + * calculate the number of the reference count. > > + */ > > + mem->bank[i].nr_shm_domain++; > > + > > + return 0; > > +} > > +#endif > > + > > static int __init early_scan_node(const void *fdt, > > int node, const char *name, int dept= h, > > u32 address_cells, u32 size_cells, > > @@ -383,6 +447,10 @@ static int __init early_scan_node(const void *fdt, > > process_chosen_node(fdt, node, name, address_cells, size_cells= ); > > else if ( depth =3D=3D 2 && device_tree_node_compatible(fdt, node, > "xen,domain") ) > > rc =3D process_domain_node(fdt, node, name, address_cells, > > size_cells); > > +#ifdef CONFIG_STATIC_SHM > > + else if ( depth <=3D 3 && device_tree_node_compatible(fdt, node, > "xen,domain-shared-memory-v1") ) > > + rc =3D process_shm_node(fdt, node, address_cells, size_cells); > > +#endif > > > > if ( rc < 0 ) > > printk("fdt: node `%s': parsing failed\n", name); diff --git > > a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > > index 7a1e1d6798..38e02ced36 100644 > > --- a/xen/arch/arm/include/asm/setup.h > > +++ b/xen/arch/arm/include/asm/setup.h > > @@ -27,6 +27,9 @@ struct membank { > > paddr_t start; > > paddr_t size; > > bool xen_domain; /* whether the memory bank is bound to a Xen > > domain. */ > > +#ifdef CONFIG_STATIC_SHM > > + unsigned long nr_shm_domain; > > +#endif >=20 > This is a NIT but unsigned int would be more than enough. The benefit is = that > the following uint8_t end up not needing extra memory on arm64. I realize > this is an overoptimization so it is fine anyway. >=20 Oh, padding! Learned it, I'll fix thanks~~~ > Other than this, the patch looks good to me. From xen-devel-bounces@lists.xenproject.org Sat May 07 06:45:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 06:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323607.545348 (Exim 4.92) (envelope-from ) id 1nnECK-0005JY-4k; Sat, 07 May 2022 06:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323607.545348; Sat, 07 May 2022 06:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnECK-0005JR-0u; Sat, 07 May 2022 06:45:48 +0000 Received: by outflank-mailman (input) for mailman id 323607; Sat, 07 May 2022 06:45:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnECI-0005JF-CF; Sat, 07 May 2022 06:45:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnECI-0008Lw-8l; Sat, 07 May 2022 06:45:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnECH-0002dh-Mm; Sat, 07 May 2022 06:45:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnECH-0005wZ-M2; Sat, 07 May 2022 06:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ub/lrTWoczXH0Goe/zw0HwJwMqCTn6wZ929CCOHnRC4=; b=wJsUimpMBfP8ENCW6pR/6YVmE/ c+lcktcXrsCNU4jgcZE3+e/XK4o0G5DfXiZqQvnAeCO9qffQAYYpYEhw3l2yifqIHQZLL7zXe06he gr+q/qhyEFjScSgOKv6QzT6HDN03Bc39r/iXAcKdM7Ya5nqWTYHE6yhLNqxFm7t1wbh8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170192: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-saverestore:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef98495a165030636e43627b3d7351e7b6f66004 X-Osstest-Versions-That: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 From: osstest service owner Date: Sat, 07 May 2022 06:45:45 +0000 flight 170192 xen-unstable real [real] flight 170202 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170192/ http://logs.test-lab.xenproject.org/osstest/logs/170202/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170179 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail pass in 170202-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170179 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170179 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170179 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170179 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen ef98495a165030636e43627b3d7351e7b6f66004 baseline version: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 Last test of basis 170179 2022-05-06 09:53:58 Z 0 days Testing same since 170192 2022-05-06 19:39:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit ef98495a165030636e43627b3d7351e7b6f66004 Author: Roger Pau Monné Date: Fri May 6 14:53:31 2022 +0200 MAINTAINERS: add myself as reviewer for IOMMU vendor independent code That also covers the PCI bits which I'm interested on. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich commit 944e389daa133dd310d87c4eebacba9f6da76018 Author: Jan Beulich Date: Fri May 6 14:46:52 2022 +0200 bump default SeaBIOS version to 1.16.0 Signed-off-by: Jan Beulich Acked-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat May 07 06:59:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 06:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323615.545362 (Exim 4.92) (envelope-from ) id 1nnEPo-0006uy-Tg; Sat, 07 May 2022 06:59:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323615.545362; Sat, 07 May 2022 06:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEPo-0006ur-R2; Sat, 07 May 2022 06:59:44 +0000 Received: by outflank-mailman (input) for mailman id 323615; Sat, 07 May 2022 06:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEPn-0006uh-Qo; Sat, 07 May 2022 06:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEPn-00008D-Pu; Sat, 07 May 2022 06:59:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnEPn-00034l-F2; Sat, 07 May 2022 06:59:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnEPn-0005JL-Eb; Sat, 07 May 2022 06:59:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=48TY7vOwp44QsWoUQ+M3OH662Hqw8agzbZrgdYZtpXk=; b=EQmJtTHB6Ix2gBocL2HsJ0nyPJ DgHnSVkfHdbEUtL9WnvQ9Yn4R2rhj7Cjb9zmfdBQfgq3rE+i02kodEmV21mcepkfDsZGvy+EwAQT2 W58wrA6fp+NaE5CwKiJgGpwdkrIQip1SakcWdScLoA4LQscRT8dlKHj3DFQEjZoHJ8GY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170203: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 06:59:43 +0000 flight 170203 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170203/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 852 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 08:05:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 08:05:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323629.545372 (Exim 4.92) (envelope-from ) id 1nnFRI-0005zX-8g; Sat, 07 May 2022 08:05:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323629.545372; Sat, 07 May 2022 08:05:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFRI-0005zQ-5h; Sat, 07 May 2022 08:05:20 +0000 Received: by outflank-mailman (input) for mailman id 323629; Sat, 07 May 2022 08:05:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFRG-0005zK-Px for xen-devel@lists.xenproject.org; Sat, 07 May 2022 08:05:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7d00::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d275660-cddc-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 10:05:15 +0200 (CEST) Received: from AS9PR06CA0298.eurprd06.prod.outlook.com (2603:10a6:20b:45a::6) by DU2PR08MB7343.eurprd08.prod.outlook.com (2603:10a6:10:2f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Sat, 7 May 2022 08:05:11 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::15) by AS9PR06CA0298.outlook.office365.com (2603:10a6:20b:45a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Sat, 7 May 2022 08:05:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Sat, 7 May 2022 08:05:10 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Sat, 07 May 2022 08:05:10 +0000 Received: from cc4782ae7878.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4B5EC9F4-4945-4F3E-9806-1DF314DF1D0F.1; Sat, 07 May 2022 08:05:00 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc4782ae7878.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 07 May 2022 08:05:00 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM8PR08MB6371.eurprd08.prod.outlook.com (2603:10a6:20b:363::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sat, 7 May 2022 08:04:58 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%4]) with mapi id 15.20.5227.021; Sat, 7 May 2022 08:04:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d275660-cddc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GAO0ZtIuxRpuO+8bhf9sAe+tev9Bi9o8n4kXJKh7O5xq51EAglIkqywNtxm1ZpAPEGpsH+/xiv4qqPIK04Jawo52mLBeAXANa67saHlJ8NkrFCiWhJmk5Cp007H+UkyXTx9ortVR4ABQpDfOIUSHEs0oDw32AFcH9AwJgY4kG3yAYjF4O2/GMSKmuM8AOcbRraWyZAHWY5g1/gX19KVhkbMstsy2YWcf0vlgRrkuzuLgg06vh1fjJzFKUUlSlrH6G3hIg21XZoN28vFfSxjHCHUogJ+GL2IXwhercYK9kOOA0L/tBeT2JaoS5+yB2K4y2xjVRuTGf89/kLbKGtlMvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GtoGPaGTeUDaR/NHaU+hBPzcM8I0IL7vUBR/US4uTO0=; b=XEHgwHKojvNia1m1O3aIAr6+nk5UUPLvMtApOKUYvucVvezXCBrQuKGO3UBZAHu+Ay+T/DDNcwws8xA6adg2W5Lb73Py9CU30/mVn+e5U7Dp42NNfPbDIoLqqGJc67QidQmUhuVZE+OoRRVY7N7jZKMrdhUarYctPGbfpOaIYdykVIyg+iXauYXpDnBoO/UFe8yz8G73VMYtpMff+bGnAHAYXJHC2Aqj07D+kuM3JVdSSqmaQygdEXusnV+eSP1dOynuK3ijafNs89KKYdJYXSx9w57JW2bo+Z+Dzgc5xDy0wv+lJOxEP6xcX5vVv/nZLUmwoJ5udlybz85Q0qjvuQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GtoGPaGTeUDaR/NHaU+hBPzcM8I0IL7vUBR/US4uTO0=; b=qMSMBPALrlWjiYxPw7gQVM/zyWuAeybzOKp1TYyU5KxAJuXAF3qe/1f0Gc9naG0tx8IsBfseAKtHPm8hPOYUqmmgWsUI2pIz2IxgfF2YV6/YW4IRcwQniHCNDCC5JoUGgQZhiGNx9y/J1s8Oorotcqnm0T1C555U+et+7DJINbI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=An/P7SyRCiQ7XgWRDgqPLLJ1wSCWoviTsZ9gGzEeSQaJgPxSP/mFg+m8ZMaj4OVhlO6Ed7s7sY8QpKEpAknHQQcAy1GvM+XZ+r2XbLZLgd4Tyol5XT4Xh1qaLeCANBl9N2dkhY5yCl1xOUfiysco+LfaxKj53VcalGiLoeExIgNSI4yln30xXlOT5dbeFvSbw3gWihn37h9PJyI/WYlXUEpMKqXVK6pwzjwHI2RFAPy2F87QsBAi7Gsp+LlFnYWIrpJh6qfiZJpN5ARmr+qzWCtIIQyuscWZBugtGMsMSq9DvnUYrARgWn/vmHHaOKkF55GGb8kMGKdsCpIydi3hGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GtoGPaGTeUDaR/NHaU+hBPzcM8I0IL7vUBR/US4uTO0=; b=nBjnb/ookbKqFHny3fMpjuJIAJcjCSgbUJ0ASp/NN0YgngaKhRtMpYlyh/YHRi5rgzMS7zJ4Jepg0Y9Gqk0amHMua3xxS3lWZ7K5dSH48Hnak7TSxXuXzO7PLoLws6jEmSf63KN5NaB6vXGKytWI0k0eprC/51pMD+IMLx2Sgoe2xampclSqPxhVN3tO4ysCKhN1LxtsRI6bRACo2TXyihq/2lIPyRr4VWGnbsfHa4EBEp1uHKrYZz+JdDYnUBAH3JyXu3jznXQfG2eX8B238zZ8NfQGtxbWU92vMCdlmgzbjQMCO2Q5n+OjOYxKe9aUrURoW2wC9sS3jChiYoc9rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GtoGPaGTeUDaR/NHaU+hBPzcM8I0IL7vUBR/US4uTO0=; b=qMSMBPALrlWjiYxPw7gQVM/zyWuAeybzOKp1TYyU5KxAJuXAF3qe/1f0Gc9naG0tx8IsBfseAKtHPm8hPOYUqmmgWsUI2pIz2IxgfF2YV6/YW4IRcwQniHCNDCC5JoUGgQZhiGNx9y/J1s8Oorotcqnm0T1C555U+et+7DJINbI= From: Penny Zheng To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Wei Chen , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr Thread-Topic: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr Thread-Index: AQHYYRqQd1unnA/4u0udLI/iXEbzaa0Sm9cAgABx6kA= Date: Sat, 7 May 2022 08:04:57 +0000 Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-5-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3D1BC52727CD0542A602F215BAAD2E68.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: be9d3cf0-ff83-462f-a314-08da30004f04 x-ms-traffictypediagnostic: AM8PR08MB6371:EE_|AM5EUR03FT059:EE_|DU2PR08MB7343:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IvpnA0NVS+ILGIM9emkqq3zY0pBRbepvWMCcwwb0/h5aigQTYraZojV9IfZM8PA3fMlmfd+dTJgle3p37GqApVtDcJx7L9fs2AOhANBJighkcA4u+Vz+vIFS3pqIGtNUOcetYoZWUdDwBQeMS16GpaA4/GhEApZhew7eLT9lSQ99accEcD3yUCdqhTXdhMZ/0EVzcmOdY9DtxfN6CVNqWv+jM9XYpU6tr4pcz1a0nwqiqecjCotkut6NtjestLj/fInnLD7MqHpzwmsQyKjxba5heWIegAQmI5m4KJyXslhmRS5Y0ub0iPvqtYzR+7syAAd5gdxOI0yqje/npPpX93sI7cMjhfbShF1rbw6dsbiKID/SEIc1ellG10xWwyBlSM4PAQbgzsnAgQT43v0JhDHTo87DDm1K1trLkmoGMODh1KAH6i6LgzXLuFW1fCa/kb4PQPuwoH81thLM08lcAHVMlJrJ1TaKSd+xo31MglYxFEU4i9H6J1XzW8YH9f67vZSqOo7jFs2teiLnrhQOmxUhYQ5XoWPG2tV3qf8/GfTB3Tnf1MogZeEXT18X/cmK57o2545kbKNr/CJuds+PKrkYr/aKvSpeNOgB7W1Z6bkr6SYtU8M8szuFOqOrGDt1rnmTg3i5DPO5nWUbsd0KdF+Ze8I+U9Vwu6wKcu6qzixz5lajvw8AObbO6obf8UL0ht8kzfcCwER5OkGUjz5+0Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(38100700002)(8936002)(52536014)(122000001)(6916009)(66446008)(186003)(4326008)(76116006)(53546011)(71200400001)(54906003)(316002)(2906002)(9686003)(26005)(508600001)(7696005)(55016003)(33656002)(5660300002)(6506007)(66946007)(83380400001)(86362001)(66476007)(64756008)(66556008)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6371 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 057e0d5d-487c-461a-3c30-08da3000472c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZvGXdslT5VkKd5WKsDkuNm6p7Opa7WL0sTVv43QVKwI//3lU7L02Sh+/i0Bs1awSk63NyXxB4QiIYTQlN6hwtWKbexTQLDyyCorQ50hSsIgh+mL23tThxOHnmtvKKDYqzimw0gsZWgRA7flG+mp77mvPr1ROr7JzDVQ4dxo/Rjb/WEU7gvQoQBrR2KUIxqdbgvYWuv8pMJ0DEw09kipfsP4RhY4+TAh43lEZEp88ancHZjAw/v0tEGLal9vowX0pUrVivOBI/oTES1Ps5AREQoEwv0zY+etHEJZKVwtxVjWWhDtpqGu7db05otmphhAk6Xi3cPi+fh9CE/jAbHVOyqZhYd6ZsSKdTx0Uf9lBcq9BtZhq+OfYCz7Ym/e97Ue3rTVIWaqN0ZRMS40nCY0zjDnv8JZA5etS+K9ETQpk+I6lAdPKeaCLRto3lED8eb79t+X8TjipGq9NnxWGPMJw6XuoDr37Z2FJx6vK+LctIYhTNoPPsYGQ1ZzOZyD3zruaUFHA3c+N9JaEBBehz66+uD4Ah9JbYAiY+0beDn1uTE/oADZMgzNgohoMEIjh+AkUEAresnUaWifsvO54xGpPskHcRJE3gQTNM0o6pX4GeNuHmLHl7dyRSPAk0YyjPFxiQvJIpe/7HRucsS201E6P5ZpZ4vVUqXgG1EDmye38pdEs5zg7h8GfmKA72d6vPxhi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(5660300002)(55016003)(33656002)(36860700001)(2906002)(7696005)(81166007)(53546011)(8936002)(52536014)(508600001)(6506007)(40460700003)(186003)(47076005)(336012)(83380400001)(107886003)(82310400005)(316002)(356005)(54906003)(70206006)(70586007)(86362001)(4326008)(26005)(9686003)(6862004)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2022 08:05:10.9420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be9d3cf0-ff83-462f-a314-08da30004f04 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7343 Hi Stefano > -----Original Message----- > From: Stefano Stabellini > Sent: Saturday, May 7, 2022 9:09 AM > To: Penny Zheng > Cc: xen-devel@lists.xenproject.org; Wei Chen ; Stefano > Stabellini ; Julien Grall ; Bertr= and > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_n= r >=20 > On Fri, 6 May 2022, Penny Zheng wrote: > > Later, we need to add the right amount of references, which should be > > the number of borrower domains, to the owner domain. Since we only > > have > > get_page() to increment the page reference by 1, a loop is needed per > > page, which is inefficient and time-consuming. > > > > To save the loop time, this commit introduces a set of new helpers > > put_page_nr() and get_page_nr() to increment/drop the page reference by > nr. > > > > Signed-off-by: Penny Zheng > > --- > > v2 change: > > - new commit > > --- > > xen/arch/arm/include/asm/mm.h | 4 ++++ > > xen/arch/arm/mm.c | 36 +++++++++++++++++++++++++---------- > > 2 files changed, 30 insertions(+), 10 deletions(-) > > > > diff --git a/xen/arch/arm/include/asm/mm.h > > b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 > > --- a/xen/arch/arm/include/asm/mm.h > > +++ b/xen/arch/arm/include/asm/mm.h > > @@ -347,6 +347,10 @@ void free_init_memory(void); int > > guest_physmap_mark_populate_on_demand(struct domain *d, unsigned > long gfn, > > unsigned int order); > > > > +extern bool get_page_nr(struct page_info *page, const struct domain > *domain, > > + unsigned long nr); extern void > > +put_page_nr(struct page_info *page, unsigned long nr); > > + > > extern void put_page_type(struct page_info *page); static inline > > void put_page_and_type(struct page_info *page) { diff --git > > a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4906..e565979f3c > > 100644 > > --- a/xen/arch/arm/mm.c > > +++ b/xen/arch/arm/mm.c > > @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, > XEN_GUEST_HANDLE_PARAM(void) arg) > > return 0; > > } > > > > -struct domain *page_get_owner_and_reference(struct page_info *page) > > +static struct domain *page_get_owner_and_nr_reference(struct page_info > *page, > > + unsigned long > > +nr) > > { > > unsigned long x, y =3D page->count_info; > > struct domain *owner; > > @@ -1545,13 +1546,14 @@ struct domain > *page_get_owner_and_reference(struct page_info *page) > > do { > > x =3D y; > > /* > > + * Consider the minimum case(nr =3D 1): > > * Count =3D=3D 0: Page is not allocated, so we cannot take a= reference. > > * Count =3D=3D -1: Reference count would wrap, which is inval= id. > > */ > > if ( unlikely(((x + 1) & PGC_count_mask) <=3D 1) ) > > return NULL; > > } > > - while ( (y =3D cmpxchg(&page->count_info, x, x + 1)) !=3D x ); > > + while ( (y =3D cmpxchg(&page->count_info, x, x + nr)) !=3D x ); > > > > owner =3D page_get_owner(page); > > ASSERT(owner); > > @@ -1559,36 +1561,50 @@ struct domain > *page_get_owner_and_reference(struct page_info *page) > > return owner; > > } > > > > -void put_page(struct page_info *page) > > +struct domain *page_get_owner_and_reference(struct page_info *page) { > > + return page_get_owner_and_nr_reference(page, 1); } > > + > > +void put_page_nr(struct page_info *page, unsigned long nr) > > { > > unsigned long nx, x, y =3D page->count_info; > > > > do { > > - ASSERT((y & PGC_count_mask) !=3D 0); > > + ASSERT(((y - nr) & PGC_count_mask) >=3D 0); >=20 > Why this change? The original ASSERT is to check that we enter the loop o= nly > when count_info is greater than 0. It should still apply even for put_pag= e_nr > without modifications? >=20 >=20 Oh, I understand wrongly about the ASSERT. I thought it was to check the result count_info after the loop will be not smaller than 0. Do you think we still need to ensure that? Maybe ASSERT( ((y & PGC_count_ma= sk) !=3D 0) && (((y - nr) & PGC_count_mask) >=3D 0)); ? >=20 > > x =3D y; > > - nx =3D x - 1; > > + nx =3D x - nr; > > } > > while ( unlikely((y =3D cmpxchg(&page->count_info, x, nx)) !=3D x)= ); > > > > if ( unlikely((nx & PGC_count_mask) =3D=3D 0) ) > > - { > > free_domheap_page(page); > > - } > > } > > > > -bool get_page(struct page_info *page, const struct domain *domain) > > +void put_page(struct page_info *page) > > { > > - const struct domain *owner =3D page_get_owner_and_reference(page); > > + put_page_nr(page, 1); > > +} > > + > > +bool get_page_nr(struct page_info *page, const struct domain *domain, > > + unsigned long nr) > > +{ > > + const struct domain *owner =3D > > +page_get_owner_and_nr_reference(page, nr); > > > > if ( likely(owner =3D=3D domain) ) > > return true; > > > > if ( owner !=3D NULL ) > > - put_page(page); > > + put_page_nr(page, nr); > > > > return false; > > } > > > > +bool get_page(struct page_info *page, const struct domain *domain) { > > + return get_page_nr(page, domain, 1); } > > + > > /* Common code requires get_page_type and put_page_type. > > * We don't care about typecounts so we just do the minimum to make it > > * happy. */ > > -- > > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Sat May 07 08:36:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 08:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323634.545383 (Exim 4.92) (envelope-from ) id 1nnFuz-0000uT-Mb; Sat, 07 May 2022 08:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323634.545383; Sat, 07 May 2022 08:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFuz-0000uM-JM; Sat, 07 May 2022 08:36:01 +0000 Received: by outflank-mailman (input) for mailman id 323634; Sat, 07 May 2022 08:36:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFux-0000uC-US; Sat, 07 May 2022 08:35:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFux-0002Ok-Iu; Sat, 07 May 2022 08:35:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnFux-0007eW-Bd; Sat, 07 May 2022 08:35:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnFux-00036m-BD; Sat, 07 May 2022 08:35:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d09t78GWQIWzSYjiV9jFEyyR2K1bUcDF1SzYTPqEJTA=; b=LDzNUFDpMKeW951PjiBJJ9bbQ4 A3G8vME+jweDqpDj4Fu0nOK817vNm98vlH2jSemBzBDlFl1J6hoD/1oxXAHAMRW5INAhvoCZRn+11 oIFKam7pwxjzXTRqs60LtruUQ6gG2mOA8ZLPzbTZ17CsSmMnFc5cPPGnrSLWwXT2+kuY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170206: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 08:35:59 +0000 flight 170206 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170206/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 853 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 09:00:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 09:00:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323642.545398 (Exim 4.92) (envelope-from ) id 1nnGIv-00049z-RE; Sat, 07 May 2022 09:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323642.545398; Sat, 07 May 2022 09:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGIv-00049s-Nr; Sat, 07 May 2022 09:00:45 +0000 Received: by outflank-mailman (input) for mailman id 323642; Sat, 07 May 2022 09:00:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGIt-00049m-Ve for xen-devel@lists.xenproject.org; Sat, 07 May 2022 09:00:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGIt-0002r6-LV; Sat, 07 May 2022 09:00:43 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nnGIt-0001GM-FQ; Sat, 07 May 2022 09:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=vH7ONMyoV7A8LBQjawjCukMjk6aiZB7UH/oyEHMDvbg=; b=J3QtpLfFrfMPoKkNT6Sy5zQ3D+ EVyCbGEdmUcLbQzDYx/TIQucJjDhUz/fCwOi4MPVGg6z7afhyb/5AcWMhaD2Jj6tM1P6rEBF8Lqvg UDOTgsHVJUwciw0+/S9ZIG+ddABSmlYiZ3pl17OGdSA9Ib/IagqyyRLA1sUwqauSLT0o=; Message-ID: <442a17fb-b859-8067-417e-a1286dfcec80@xen.org> Date: Sat, 7 May 2022 10:00:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-7-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages In-Reply-To: <20220506072502.2177828-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/05/2022 08:24, Penny Zheng wrote: > In order to cover the scenario where users intend to set up guest > p2m foreign mapping with nr_pages, this commit adds a new P2M type > parameter in guest_physmap_add_pages. With this patch, guest_physmap_add_pages() and guest_physmap_add_page() will behave differently. The former will be able to deal with any type whilst the latter can only handle RAM type. I think we need to stay consistent with the name. Looking at the existing helper, we already have one that should suit you (see map_regions_p2mt()). So this patch looks unnecessary. Cheers, > > Signed-off-by: Penny Zheng > --- > v2 change: > - no change > --- > xen/arch/arm/domain_build.c | 5 +++-- > xen/arch/arm/include/asm/p2m.h | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index b3ba0c501d..089b9e99fc 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -507,7 +507,7 @@ static bool __init append_static_memory_to_bank(struct domain *d, > else > sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); > > - res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); > + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages, p2m_ram_rw); > if ( res ) > { > dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); > @@ -850,7 +850,8 @@ static int __init allocate_shared_memory(struct domain *d, > nr_pages = PFN_DOWN(psize); > if ( d != dom_io ) > { > - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, nr_pages, > + p2m_ram_rw); > if ( ret ) > { > printk(XENLOG_ERR > diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h > index 8cce459b67..58590145b0 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -317,9 +317,10 @@ guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, > static inline int guest_physmap_add_pages(struct domain *d, > gfn_t gfn, > mfn_t mfn, > - unsigned int nr_pages) > + unsigned int nr_pages, > + p2m_type_t t) > { > - return p2m_insert_mapping(d, gfn, nr_pages, mfn, p2m_ram_rw); > + return p2m_insert_mapping(d, gfn, nr_pages, mfn, t); > } > > mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn); -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 07 09:10:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 09:10:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323648.545408 (Exim 4.92) (envelope-from ) id 1nnGSE-0005hN-S6; Sat, 07 May 2022 09:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323648.545408; Sat, 07 May 2022 09:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGSE-0005hG-PV; Sat, 07 May 2022 09:10:22 +0000 Received: by outflank-mailman (input) for mailman id 323648; Sat, 07 May 2022 09:10:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGSE-0005hA-Bz for xen-devel@lists.xenproject.org; Sat, 07 May 2022 09:10:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGSE-00030v-5G; Sat, 07 May 2022 09:10:22 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nnGSD-0001mD-Vn; Sat, 07 May 2022 09:10:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=zkocKGVSy5OPtTBTK5xNgrKaOceMwXMtbM4UXd6wfi4=; b=DtWC70XTIToecDBG9NQuI7cycN kYFto4IOrp2hH3YK9uAm7qAGzpHa8wJ0I+C7OAIpHtYcQsg4FbvZL/KwdFwKyyfJGY6bjqbC4/drU Y3GiUMb80wnHZ9JKK9NUHzom8KGGId61OFGaMMI8v7Nr5oQdy7xRWi74ZOHpND1hsLbE=; Message-ID: Date: Sat, 7 May 2022 10:10:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-5-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220506072502.2177828-5-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 06/05/2022 08:24, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-consuming. > > To save the loop time, this commit introduces a set of new helpers > put_page_nr() and get_page_nr() to increment/drop the page reference by nr. > > Signed-off-by: Penny Zheng > --- > v2 change: > - new commit > --- > xen/arch/arm/include/asm/mm.h | 4 ++++ > xen/arch/arm/mm.c | 36 +++++++++++++++++++++++++---------- > 2 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 424aaf2823..c737d51e4d 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -347,6 +347,10 @@ void free_init_memory(void); > int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, > unsigned int order); > > +extern bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr); > +extern void put_page_nr(struct page_info *page, unsigned long nr); > + > extern void put_page_type(struct page_info *page); > static inline void put_page_and_type(struct page_info *page) > { > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7b1f2f4906..e565979f3c 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) > return 0; > } > > -struct domain *page_get_owner_and_reference(struct page_info *page) > +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, > + unsigned long nr) > { > unsigned long x, y = page->count_info; > struct domain *owner; > @@ -1545,13 +1546,14 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > do { > x = y; > /* > + * Consider the minimum case(nr = 1): > * Count == 0: Page is not allocated, so we cannot take a reference. > * Count == -1: Reference count would wrap, which is invalid. > */ > if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) Shouldn't this be updated to check overflow with "n"? > return NULL; > } > - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); > + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); > > owner = page_get_owner(page); > ASSERT(owner); > @@ -1559,36 +1561,50 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > return owner; > } > > -void put_page(struct page_info *page) > +struct domain *page_get_owner_and_reference(struct page_info *page) > +{ > + return page_get_owner_and_nr_reference(page, 1); > +} > + > +void put_page_nr(struct page_info *page, unsigned long nr) > { > unsigned long nx, x, y = page->count_info; > > do { > - ASSERT((y & PGC_count_mask) != 0); > + ASSERT(((y - nr) & PGC_count_mask) >= 0); > x = y; > - nx = x - 1; > + nx = x - nr; > } > while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); > > if ( unlikely((nx & PGC_count_mask) == 0) ) > - { > free_domheap_page(page); > - } Sounds like a spurious change. > } > > -bool get_page(struct page_info *page, const struct domain *domain) > +void put_page(struct page_info *page) > { > - const struct domain *owner = page_get_owner_and_reference(page); > + put_page_nr(page, 1); > +} > + > +bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr) > +{ > + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); > > if ( likely(owner == domain) ) > return true; > > if ( owner != NULL ) > - put_page(page); > + put_page_nr(page, nr); > > return false; > } > > +bool get_page(struct page_info *page, const struct domain *domain) > +{ > + return get_page_nr(page, domain, 1); > +} > + > /* Common code requires get_page_type and put_page_type. > * We don't care about typecounts so we just do the minimum to make it > * happy. */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 07 09:21:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 09:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323653.545420 (Exim 4.92) (envelope-from ) id 1nnGcf-0007DF-Si; Sat, 07 May 2022 09:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323653.545420; Sat, 07 May 2022 09:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGcf-0007D8-Oh; Sat, 07 May 2022 09:21:09 +0000 Received: by outflank-mailman (input) for mailman id 323653; Sat, 07 May 2022 09:21:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGce-0007D2-Uq for xen-devel@lists.xenproject.org; Sat, 07 May 2022 09:21:09 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on062c.outbound.protection.outlook.com [2a01:111:f400:fe05::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05dcbb27-cde7-11ec-a406-831a346695d4; Sat, 07 May 2022 11:21:06 +0200 (CEST) Received: from DB7PR03CA0099.eurprd03.prod.outlook.com (2603:10a6:10:72::40) by DB7PR08MB3115.eurprd08.prod.outlook.com (2603:10a6:5:1d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Sat, 7 May 2022 09:21:04 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::97) by DB7PR03CA0099.outlook.office365.com (2603:10a6:10:72::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21 via Frontend Transport; Sat, 7 May 2022 09:21:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Sat, 7 May 2022 09:21:03 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Sat, 07 May 2022 09:21:03 +0000 Received: from 583370501699.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25E482B6-2BDE-4250-9BD1-D38480D77F5B.1; Sat, 07 May 2022 09:20:52 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 583370501699.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 07 May 2022 09:20:52 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR08MB3088.eurprd08.prod.outlook.com (2603:10a6:803:3f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Sat, 7 May 2022 09:20:49 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%4]) with mapi id 15.20.5227.021; Sat, 7 May 2022 09:20:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05dcbb27-cde7-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZcABmErkokP8iYM3OMIexxrXkKzGreZrK88fwCUBWJue22I7fpdL8CnPzXOEt3swYp2luvgqo5XbiVaBo+qjQN+N49WoOaC7Zx8lPb+v9j8A486DJy11rhfLS5oTfYrsMCmVwHnnW4Kf1AsHGpKlB7Ej0InCFEVWncNnm0FrAmrRMoWOIQcWfKq/WEdR6nHrJBNzyOOSqrYGMxQKJCKYS08pzojkvJwopfMd2t0/JbQ2vi9itwsbWwGJWYZnHuwpjM/TS1Qtc1+kcueiydPfqRbcGaSJF4+Q/QtdYIOBy8gzdXsN89qKpbh2EHFjQo8e0Uw15l5aOehH6IiUjwZtnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4cXI1jrvipil1Uc8qsyj9LOctdmx7HmZqFp41ZPEdY=; b=D5DnCjGSfRqwRVRnORQRQ+EEljNwUTphd+iGmR+wlY4brWCezY/Y2A7VYnRfjiSARwCBl1SrdyqDJbkzhIIjxRvnJBK456Z80vIvy33dfYyi60nojquBBGT/gjyX5gAN0S1wwKgcbzIwGqksGPiGYD/8SlgjVzTwz00iAqQs8P7Rs4we6VUHhBcNlGP64JBkZmtnpYikXThfZ/53wp72lHLehlbPXbztFSUBSqOlyUzfk9003kjuoHpbDcR9pCYcVRzYo4BYwPIRriocHqTnq9XcIdgOPLZUPCkWXYzcUOH4wrP6nxgeIXAdznk4oMi+9IDnw3HLt6MEGV8HgDocwA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4cXI1jrvipil1Uc8qsyj9LOctdmx7HmZqFp41ZPEdY=; b=h0XwuWBlTu11hkHY/a+23Ogz5qF3ObJidgLBXjJ3tvhPAWX56iohR6khrauG5Nb6Q4q1Bt4GUQ4P3ksaOzHD5EqKjNQWVoD948iFERSMj2kOZYOu9Gr3lcO+cOrNIiJrT+qxqJQ2uJ+OuvLyMY3ckQGC+D89nINORrVN/9hEIec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SVcBIPe5ch5oihU7G5NQP70K88mnuV9as8YVtuQGVaCWOZ0i0WuByHO5uDtvXWR236IS4NZKWSth0NjycOuDAgOGoA9NExNjTcRYCpkuxazn/JkP8B/d6Ju18csG82yYCtNu+gE0AJAOAtloimVWAq9Yd/lM195hc0t1nLfowuH3vLFDB+U4A1EHT76yXF5tVeSctEMuW6iUZfUCnSEODma7miIgRSBbHoXwcfkDjbbcgI2sDgPI6IZYag+wGF6DQ2++SjLr9sYzW68UC1lDZFTiRoq0GKsvO//N/XMCdRegMi91Yn8YOBqzVNfWaRBiWldaflHo4ArZ5FA166Cxpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4cXI1jrvipil1Uc8qsyj9LOctdmx7HmZqFp41ZPEdY=; b=Md3EqsYUFEOIh0pGV4gdCuu3uaeiNuFh0D3uXO0Tz98PpX02Suyf8Nw+mH5oIkYsk03C7QL143kGUPZnT8nnHDE3sYV71nPzspmMp69EP9cBwJwiEf8oLlggVWGrjdDeNvGfZcAbgktHnXmIx3y8bnRkVkVM0AX/kcC+61e88dMZXF8ifGzXfMVAEKfptEJQ50dlqTwbTBGOQEqATziH6zq2GWhjh2Om7FMOs5E+N7BAy8AvoHMJZTwZXFtA/mM1GADYRei8SXEa5VvWf2jMuwsKsOktgrz8gLk1fPRvFnfcBl1xBiJhiTxy8//yh6PJeCaG/HrPc96Kp53Q8bt+XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4cXI1jrvipil1Uc8qsyj9LOctdmx7HmZqFp41ZPEdY=; b=h0XwuWBlTu11hkHY/a+23Ogz5qF3ObJidgLBXjJ3tvhPAWX56iohR6khrauG5Nb6Q4q1Bt4GUQ4P3ksaOzHD5EqKjNQWVoD948iFERSMj2kOZYOu9Gr3lcO+cOrNIiJrT+qxqJQ2uJ+OuvLyMY3ckQGC+D89nINORrVN/9hEIec= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages Thread-Topic: [PATCH v2 6/9] xen/arm: add P2M type parameter in guest_physmap_add_pages Thread-Index: AQHYYRqTRs6WKDynUESu6+gNH4KxLK0TH6WAgAAFK1A= Date: Sat, 7 May 2022 09:20:49 +0000 Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-7-Penny.Zheng@arm.com> <442a17fb-b859-8067-417e-a1286dfcec80@xen.org> In-Reply-To: <442a17fb-b859-8067-417e-a1286dfcec80@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1E505C8F72B33C4AAABFAD19E397AF95.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c939fb91-ea8c-4663-0679-08da300ae88f x-ms-traffictypediagnostic: VI1PR08MB3088:EE_|DBAEUR03FT058:EE_|DB7PR08MB3115:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: u6KE8Rs6/6nlFIsr4/IlH3y8GPKz/RJNMMo6tVbNBadRIu6hRFwhIPaCXl1DvQS/CUb3Gq1ePVHjKkrIUUdy/JKK2hb6AbA4xST222hHQIAzZ6akxzFpsb7LngNC+nhLko2rzJ4nbmqRM2al6OiZgEQHx92a3y17fD/Crk++kJdDT6A8kAOG7mxa3d5HrfCqcXfXTifsufmsIlyE+gLF/jkh7hbn6rAy/dblJcnEMmKcateJPOqpfUCvVD6QSLwT/CqpWVE+gqMXb6e0rUo+w8s+aZC94gsOqoAhIatDgca7w8SkGB9867y5kkkFrWUg610K+s9wASjV/UyR6RYQf0bkbOuDicd/gUek4MlCG1Z6DynTKt3zO2n2vYb74RF+cnK/r6ZhcnS3YL9LWlfmmacQwt6KbiPi3W3B299ybZCoeRn9cMJIS2W6k3jQDp9fz0vPRSWBjP07ltm1Xu3c/r9pfR6lLAXeEieN8Q6rF/rBIgSWkkufgUdnkuZdZxeL767Cm5qiJj5BtCLwYw822uDeDVJbSpeYwY+lzQAYvYy52YmWj0nhrE+wlI6+OFcymuvsKT5ynHTCE8DLd2Pf6GWdRbxcHp/67Ji1YdYthg2CeXUgZrDI5UZbNcX1QOi6OhXA+SJbOxRMfFl0EAZq8Lh8U3cjAgK/cZqJZfxLt4xW6CHWa7R3PumlBMuLTkFqbTeveP+vLVfqRtSJzOpVOQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(4326008)(2906002)(7696005)(5660300002)(508600001)(9686003)(8936002)(66476007)(66556008)(26005)(76116006)(66946007)(66446008)(64756008)(6506007)(53546011)(33656002)(86362001)(71200400001)(52536014)(316002)(83380400001)(54906003)(122000001)(38070700005)(186003)(38100700002)(55016003)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3088 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c540d85c-eeec-4912-a78e-08da300adff0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cTi38DY2hrxTL+VTVe8knLObB6HqtAJumM0sbjqsv3PUW8Gq6PvtHLOatUaiC3ZJPM+TJEOFBXjREwIZ0lpATy519LdmAanLI7roO2L1170F0/XrtijZmr1K7dg2yjMPmjM6c9AAVxvzTun8NwsdyESWs96ITu+9RLdeMpRwmT85Fo7rq+nrjKrSUh9ad+a5bggSIDi1Dpyy7m1gYg9d5zINf/P3rWpXwPCPcW2mRgQpB/ux6lJVeO7QL6cYeNbGVmvXQB1r38FAyLZcCxvN5gR5G7x4gG1L23Nytd7mEQGEeXeNT8Vi+3pck3LMn1FnbIkGmEk8gBy9g61EpRt7oAWurwXkRyOm23w/enlVqjv3nu6Y9E4E9h8GN1WxioGMyyH6C6H4LlnitgZpGd2Y23ga/BQCfYiIBA2/d9Ol3kmF4Qt9PgPd/Il5cGVcUJS7+ccJA3T+id9qE7AvF7yz1a/aIuTCjas5rKDCxNrakh/tmf+udyGn6LUTZjjCK2eX4qwJ8ag1f1/kt4k8UTq/BHXg3IL48Q2m3CLgJX8NKQm2CfrvuQFW0pRmDk2CSpyfZmiT41CBzO8C07GKhLFCoTPdsgAIG6Xlq3wx4UL9fOWRCxtMtWNaVfibq9g4RjOPrihi4Mt6YdqdcxZJ1Za+JBbxzzLPtIdsThQg7VH7E6XLKZKDOQ4TcXwjCFjAAg2b X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(55016003)(356005)(26005)(8676002)(4326008)(336012)(86362001)(8936002)(53546011)(7696005)(5660300002)(2906002)(47076005)(52536014)(40460700003)(36860700001)(508600001)(70206006)(70586007)(6506007)(83380400001)(82310400005)(110136005)(81166007)(54906003)(316002)(186003)(9686003)(33656002)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2022 09:21:03.5840 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c939fb91-ea8c-4663-0679-08da300ae88f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3115 SGkganVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogU2F0dXJkYXksIE1heSA3LCAyMDIyIDU6 MDEgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5k IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJjaHVr IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiA2 LzldIHhlbi9hcm06IGFkZCBQMk0gdHlwZSBwYXJhbWV0ZXIgaW4NCj4gZ3Vlc3RfcGh5c21hcF9h ZGRfcGFnZXMNCj4gDQo+IEhpLA0KPiANCj4gT24gMDYvMDUvMjAyMiAwODoyNCwgUGVubnkgWmhl bmcgd3JvdGU6DQo+ID4gSW4gb3JkZXIgdG8gY292ZXIgdGhlIHNjZW5hcmlvIHdoZXJlIHVzZXJz IGludGVuZCB0byBzZXQgdXAgZ3Vlc3QgcDJtDQo+ID4gZm9yZWlnbiBtYXBwaW5nIHdpdGggbnJf cGFnZXMsIHRoaXMgY29tbWl0IGFkZHMgYSBuZXcgUDJNIHR5cGUNCj4gPiBwYXJhbWV0ZXIgaW4g Z3Vlc3RfcGh5c21hcF9hZGRfcGFnZXMuDQo+IA0KPiBXaXRoIHRoaXMgcGF0Y2gsIGd1ZXN0X3Bo eXNtYXBfYWRkX3BhZ2VzKCkgYW5kIGd1ZXN0X3BoeXNtYXBfYWRkX3BhZ2UoKQ0KPiB3aWxsIGJl aGF2ZSBkaWZmZXJlbnRseS4gVGhlIGZvcm1lciB3aWxsIGJlIGFibGUgdG8gZGVhbCB3aXRoIGFu eSB0eXBlIHdoaWxzdCB0aGUNCj4gbGF0dGVyIGNhbiBvbmx5IGhhbmRsZSBSQU0gdHlwZS4NCj4g DQo+IEkgdGhpbmsgd2UgbmVlZCB0byBzdGF5IGNvbnNpc3RlbnQgd2l0aCB0aGUgbmFtZS4gTG9v a2luZyBhdCB0aGUgZXhpc3RpbmcNCj4gaGVscGVyLCB3ZSBhbHJlYWR5IGhhdmUgb25lIHRoYXQg c2hvdWxkIHN1aXQgeW91IChzZWUgbWFwX3JlZ2lvbnNfcDJtdCgpKS4NCj4gU28gdGhpcyBwYXRj aCBsb29rcyB1bm5lY2Vzc2FyeS4NCj4gDQoNClJpZ2h0LCBtYXBfcmVnaW9uc19wMm10IGhhcyB0 aGUgUDJNIHR5cGUgYXMgcGFyYW1ldGVyLiBJJ2xsIGNoYW5nZSB0byBpdC4gVGh4fg0KIA0KPiBD aGVlcnMsDQo+IA0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55Lnpo ZW5nQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gdjIgY2hhbmdlOg0KPiA+IC0gbm8gY2hhbmdlDQo+ ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgICAgfCA1ICsrKy0tDQo+ ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcDJtLmggfCA1ICsrKy0tDQo+ID4gICAyIGZp bGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC9hcm0vZG9t YWluX2J1aWxkLmMNCj4gPiBpbmRleCBiM2JhMGM1MDFkLi4wODliOWU5OWZjIDEwMDY0NA0KPiA+ IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2Fy bS9kb21haW5fYnVpbGQuYw0KPiA+IEBAIC01MDcsNyArNTA3LDcgQEAgc3RhdGljIGJvb2wgX19p bml0DQo+IGFwcGVuZF9zdGF0aWNfbWVtb3J5X3RvX2Jhbmsoc3RydWN0IGRvbWFpbiAqZCwNCj4g PiAgICAgICBlbHNlDQo+ID4gICAgICAgICAgIHNnZm4gPSBnYWRkcl90b19nZm4obWZuX3RvX21h ZGRyKHNtZm4pKTsNCj4gPg0KPiA+IC0gICAgcmVzID0gZ3Vlc3RfcGh5c21hcF9hZGRfcGFnZXMo ZCwgc2dmbiwgc21mbiwgbnJfcGFnZXMpOw0KPiA+ICsgICAgcmVzID0gZ3Vlc3RfcGh5c21hcF9h ZGRfcGFnZXMoZCwgc2dmbiwgc21mbiwgbnJfcGFnZXMsDQo+ID4gKyBwMm1fcmFtX3J3KTsNCj4g PiAgICAgICBpZiAoIHJlcyApDQo+ID4gICAgICAgew0KPiA+ICAgICAgICAgICBkcHJpbnRrKFhF TkxPR19FUlIsICJGYWlsZWQgdG8gbWFwIHBhZ2VzIHRvIERPTVU6ICVkIiwgcmVzKTsNCj4gPiBA QCAtODUwLDcgKzg1MCw4IEBAIHN0YXRpYyBpbnQgX19pbml0IGFsbG9jYXRlX3NoYXJlZF9tZW1v cnkoc3RydWN0DQo+IGRvbWFpbiAqZCwNCj4gPiAgICAgICBucl9wYWdlcyA9IFBGTl9ET1dOKHBz aXplKTsNCj4gPiAgICAgICBpZiAoIGQgIT0gZG9tX2lvICkNCj4gPiAgICAgICB7DQo+ID4gLSAg ICAgICAgcmV0ID0gZ3Vlc3RfcGh5c21hcF9hZGRfcGFnZXMoZCwgZ2FkZHJfdG9fZ2ZuKGdiYXNl KSwgc21mbiwNCj4gUEZOX0RPV04ocHNpemUpKTsNCj4gPiArICAgICAgICByZXQgPSBndWVzdF9w aHlzbWFwX2FkZF9wYWdlcyhkLCBnYWRkcl90b19nZm4oZ2Jhc2UpLCBzbWZuLA0KPiBucl9wYWdl cywNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fcmFtX3J3 KTsNCj4gPiAgICAgICAgICAgaWYgKCByZXQgKQ0KPiA+ICAgICAgICAgICB7DQo+ID4gICAgICAg ICAgICAgICBwcmludGsoWEVOTE9HX0VSUg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vcDJtLmgNCj4gPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wMm0uaCBp bmRleCA4Y2NlNDU5YjY3Li41ODU5MDE0NWIwIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2Fy bS9pbmNsdWRlL2FzbS9wMm0uaA0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9w Mm0uaA0KPiA+IEBAIC0zMTcsOSArMzE3LDEwIEBAIGd1ZXN0X3BoeXNtYXBfYWRkX3BhZ2Uoc3Ry dWN0IGRvbWFpbiAqZCwgZ2ZuX3QNCj4gZ2ZuLCBtZm5fdCBtZm4sDQo+ID4gICBzdGF0aWMgaW5s aW5lIGludCBndWVzdF9waHlzbWFwX2FkZF9wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLA0KPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2ZuX3QgZ2ZuLA0KPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuLA0K PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgbnJfcGFnZXMpDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGludCBucl9wYWdlcywNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcDJtX3R5cGVfdCB0KQ0KPiA+ICAgew0KPiA+IC0gICAgcmV0dXJu IHAybV9pbnNlcnRfbWFwcGluZyhkLCBnZm4sIG5yX3BhZ2VzLCBtZm4sIHAybV9yYW1fcncpOw0K PiA+ICsgICAgcmV0dXJuIHAybV9pbnNlcnRfbWFwcGluZyhkLCBnZm4sIG5yX3BhZ2VzLCBtZm4s IHQpOw0KPiA+ICAgfQ0KPiA+DQo+ID4gICBtZm5fdCBnZm5fdG9fbWZuKHN0cnVjdCBkb21haW4g KmQsIGdmbl90IGdmbik7DQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Sat May 07 09:36:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 09:36:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323658.545430 (Exim 4.92) (envelope-from ) id 1nnGrM-0000LX-5k; Sat, 07 May 2022 09:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323658.545430; Sat, 07 May 2022 09:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGrM-0000LQ-2q; Sat, 07 May 2022 09:36:20 +0000 Received: by outflank-mailman (input) for mailman id 323658; Sat, 07 May 2022 09:36:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGrL-0000LG-4v; Sat, 07 May 2022 09:36:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGrL-0003RJ-2h; Sat, 07 May 2022 09:36:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnGrK-0002mC-NB; Sat, 07 May 2022 09:36:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnGrK-0005t0-Mk; Sat, 07 May 2022 09:36:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GadGc3wXM6A/dPmSSpyhagRMn4SJMznW6MbsggRJQF8=; b=p8RglUgk0scrMGeD06l5vPbmwb imXsNK6t6fHXS+A8LblJF4M7VmPoSR4EXqwyHc1+mjdMrWKJZ+gpifqxLpDCiP9LhI9ElTKtfmovl AQyqc4j5qGLqFbpeLj6lsSO5jM0TvB9zHSCDG/72/HyHAgihxe0FDP+UxG+bqoUu7riY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170207: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 09:36:18 +0000 flight 170207 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170207/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 67 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 854 attempts Testing same since 170178 2022-05-06 09:40:34 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 09:52:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 09:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323666.545442 (Exim 4.92) (envelope-from ) id 1nnH78-0002kn-Pe; Sat, 07 May 2022 09:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323666.545442; Sat, 07 May 2022 09:52:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnH78-0002kg-Kn; Sat, 07 May 2022 09:52:38 +0000 Received: by outflank-mailman (input) for mailman id 323666; Sat, 07 May 2022 09:52:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnH77-0002kW-AU; Sat, 07 May 2022 09:52:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnH77-0003hV-2Z; Sat, 07 May 2022 09:52:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnH76-0003UC-F2; Sat, 07 May 2022 09:52:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnH76-0004Aj-Ea; Sat, 07 May 2022 09:52:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w+k5Kbj/+jwU39pJ+EvJfOWhVupW+I7igK6jt1xMrME=; b=mn5lIAfktp0QTKDsfmSIAX35NQ MPaxip7W3yCdFYlWENPhjtKNtynVE/IgjcyQR09/q0ndwMN2hAIBe+7l8JMFiUjH+Qvnc0yVkwA0S /iaQHTUPKK/zFSFFbba3rYcAbkAA20M4E2gJmLcMBPwfYKXRyT7DkkCO39s7T/gf5+/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170197: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b97bac0756a81cda5afd45417a99b5bccdcff67 X-Osstest-Versions-That: linux=4df22ca85d3d73f9822b1a354bb56dd1872180cd From: osstest service owner Date: Sat, 07 May 2022 09:52:36 +0000 flight 170197 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170197/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170190 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170190 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170190 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170190 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170190 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170190 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170190 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170190 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 4b97bac0756a81cda5afd45417a99b5bccdcff67 baseline version: linux 4df22ca85d3d73f9822b1a354bb56dd1872180cd Last test of basis 170190 2022-05-06 18:40:06 Z 0 days Testing same since 170197 2022-05-07 01:43:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Conor Dooley David Sterba Filipe Manana Kyle Huey Linus Torvalds Naohiro Aota Nick Kossifidis Olga Kornievskaia Palmer Dabbelt Paolo Bonzini Peter Gonda Qu Wenruo Sandipan Das Sean Christopherson Trond Myklebust jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4df22ca85d3d..4b97bac0756a 4b97bac0756a81cda5afd45417a99b5bccdcff67 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat May 07 11:19:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 11:19:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323673.545452 (Exim 4.92) (envelope-from ) id 1nnIT3-0002PY-16; Sat, 07 May 2022 11:19:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323673.545452; Sat, 07 May 2022 11:19:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIT2-0002PR-U2; Sat, 07 May 2022 11:19:20 +0000 Received: by outflank-mailman (input) for mailman id 323673; Sat, 07 May 2022 11:19:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIT1-0002PH-Ph; Sat, 07 May 2022 11:19:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIT1-0005FF-KK; Sat, 07 May 2022 11:19:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIT1-0000LC-Ar; Sat, 07 May 2022 11:19:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnIT1-0001nk-AR; Sat, 07 May 2022 11:19:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4+JDo0To8tqHvthgkQgdQ/5NaBVReL6DUmIqL8MwAq0=; b=WzWx2v3OKSpjM3z2tOWw9Uzjw6 T/xN0IhZphAqtUy/FYteH+M3eMv2+OVyvdOMOAndqKdIwNbmLHrlaiylCX9ieRyIyTRsYpuTjXsL+ 7jFNd3Q7ENd76T7NlHdLp6nB6IkAyVbSf6VKKMSbqMjyEHX1cJf2zXtvIao+5NAbKJ60=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170201: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=5890a320f893b7db63b15a55feebb0e314baf47b X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 07 May 2022 11:19:19 +0000 flight 170201 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 5890a320f893b7db63b15a55feebb0e314baf47b baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 666 days Failing since 151818 2020-07-11 04:18:52 Z 665 days 647 attempts Testing same since 170201 2022-05-07 04:20:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106819 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 11:26:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 11:26:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323681.545464 (Exim 4.92) (envelope-from ) id 1nnIZd-0003v6-SB; Sat, 07 May 2022 11:26:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323681.545464; Sat, 07 May 2022 11:26:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIZd-0003uz-Oh; Sat, 07 May 2022 11:26:09 +0000 Received: by outflank-mailman (input) for mailman id 323681; Sat, 07 May 2022 11:26:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIZb-0003ut-Sj for xen-devel@lists.xenproject.org; Sat, 07 May 2022 11:26:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIZb-0005Lh-JK; Sat, 07 May 2022 11:26:07 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nnIZb-0001EV-DZ; Sat, 07 May 2022 11:26:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=zO5nDulVJvMCj0o0muvGfrPjkZiTuCeyskrlGulD5V4=; b=wVCneGceeoFVk/B7hgP26fzwC5 0pjNrMUd46y3sMdNpw6oHLxxaTzqtOpjtQjHQh528dEV2jjR+KiRW145yisJ6bASH2fB9go9EB2Pw 8Ok4TL+vxVhwxtneAw0nNhS5/u2OZBDeMbVz+oqCCUCHUhwAo5XW2xPsCV9ZpSqhdcHg=; Message-ID: Date: Sat, 7 May 2022 12:26:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 8/9] xen/arm: create shared memory nodes in guest device tree To: Stefano Stabellini , Penny Zheng Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Bertrand Marquis , Volodymyr Babchuk References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-9-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/05/2022 02:09, Stefano Stabellini wrote: > On Fri, 6 May 2022, Penny Zheng wrote: >> We expose the shared memory to the domU using the "xen,shared-memory-v1" >> reserved-memory binding. See >> Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt >> in Linux for the corresponding device tree binding. >> >> To save the cost of re-parsing shared memory device tree configuration when >> creating shared memory nodes in guest device tree, this commit adds new field >> "shm_mem" to store shm-info per domain. >> >> For each shared memory region, a range is exposed under >> the /reserved-memory node as a child node. Each range sub-node is >> named xen-shmem@
and has the following properties: >> - compatible: >> compatible = "xen,shared-memory-v1" >> - reg: >> the base guest physical address and size of the shared memory region >> - xen,id: >> a string that identifies the shared memory region. >> >> Signed-off-by: Penny Zheng >> --- >> v2 change: >> - using xzalloc >> - shm_id should be uint8_t >> - make reg a local variable >> - add #address-cells and #size-cells properties >> - fix alignment >> --- >> xen/arch/arm/domain_build.c | 144 ++++++++++++++++++++++++++++++ >> xen/arch/arm/include/asm/domain.h | 1 + >> xen/arch/arm/include/asm/setup.h | 1 + >> 3 files changed, 146 insertions(+) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 8d299a3616..f08606d2c0 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -894,6 +894,26 @@ static int __init allocate_shared_memory(struct domain *d, >> return ret; >> } >> >> +static int __init append_shm_bank_to_domain(struct domain *d, >> + paddr_t start, paddr_t size, >> + u32 shm_id) >> +{ >> + /* Allocate memory at first insertion. */ >> + if ( d->arch.shm_mem == NULL ) >> + { >> + d->arch.shm_mem = xzalloc(struct meminfo); >> + if ( d->arch.shm_mem == NULL ) >> + return -ENOMEM; >> + } >> + >> + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].start = start; >> + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].size = size; >> + d->arch.shm_mem->bank[d->arch.shm_mem->nr_banks].shm_id = shm_id; >> + d->arch.shm_mem->nr_banks++; bank[] is a fixed size array. So we should check we don't overflow. >> + >> + return 0; >> +} > > Can we call xfree(d->arch.shm_mem) at domain destruction? > > Even better, we might be able to call it earlier, soon after the > make_resv_memory_node() call because we don't need it any longer after > that? If this is only used during domain build, then the field should move to kernel_info. With that, there will also be no concern on whether we need to allocate the structure or not. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 07 11:27:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 11:27:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323686.545475 (Exim 4.92) (envelope-from ) id 1nnIbI-0004X9-8D; Sat, 07 May 2022 11:27:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323686.545475; Sat, 07 May 2022 11:27:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIbI-0004X2-4T; Sat, 07 May 2022 11:27:52 +0000 Received: by outflank-mailman (input) for mailman id 323686; Sat, 07 May 2022 11:27:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIbG-0004Wp-VZ; Sat, 07 May 2022 11:27:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIbG-0005Mr-Um; Sat, 07 May 2022 11:27:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnIbF-0000cP-TT; Sat, 07 May 2022 11:27:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnIbF-0006Eh-T1; Sat, 07 May 2022 11:27:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ja/Oz40Ey5qpPffQRnE1Zonk1HoHAfilgtyUQD1ejdc=; b=SJ09U97WeGj1bzR44BxUSuvNp7 Lc+ukPIopLw2RZkuuldDmaBxitWBddcueXWUpsgARgFSb8rz9OtnBwz46pcwJkhrSK7iPtjhyoMxo 3wgri6ehFabDVc5j21FY8+su07Lsk9U3m7eTqyOyusvBWhupVS9UAmSMSTwtsTcagziw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170208: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 11:27:49 +0000 flight 170208 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170208/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 855 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 12:16:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 12:16:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323696.545485 (Exim 4.92) (envelope-from ) id 1nnJLm-0001LN-33; Sat, 07 May 2022 12:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323696.545485; Sat, 07 May 2022 12:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJLm-0001LG-0L; Sat, 07 May 2022 12:15:54 +0000 Received: by outflank-mailman (input) for mailman id 323696; Sat, 07 May 2022 12:15:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJLk-0001Ks-W3; Sat, 07 May 2022 12:15:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJLk-0006D0-Tb; Sat, 07 May 2022 12:15:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJLk-0002NT-Hx; Sat, 07 May 2022 12:15:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnJLk-0001gM-HV; Sat, 07 May 2022 12:15:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aG1WYdTj7n4tStFcD0FtlaBVGwvCCdy2/Mnz9woaliY=; b=EbYGQFIPOSFfO6d/O07gNGQtWu WQR4YegvBYMGvL4kiVkhagvdmkt9vbROmsmfUswskPkAT6sSAkwQ+htLYY0Xz7Ex2Ewp5BN1iJKyl 1dUJXu174vLsj8upDpXU7K9MEZKr19BcqPYK5d+GZKsHb/SxYm8g/Fh0XXMkKiYRgPgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170209: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 12:15:52 +0000 flight 170209 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170209/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 856 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 12:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 12:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323703.545497 (Exim 4.92) (envelope-from ) id 1nnJw3-0006Nq-2w; Sat, 07 May 2022 12:53:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323703.545497; Sat, 07 May 2022 12:53:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJw2-0006Nj-Vt; Sat, 07 May 2022 12:53:22 +0000 Received: by outflank-mailman (input) for mailman id 323703; Sat, 07 May 2022 12:53:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJw1-0006NZ-GH; Sat, 07 May 2022 12:53:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJw1-0006n3-Do; Sat, 07 May 2022 12:53:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnJw0-0004g7-SO; Sat, 07 May 2022 12:53:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnJw0-0002sm-Rv; Sat, 07 May 2022 12:53:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kAlkkWwlRmH3e0OAEcX4LkhpV3HGw/zEvWhcNs4LM68=; b=n1EJsZiNEAV1RSCDLDVmpfWmb2 fHZqsOBUjnv+kKhDWDnlPr5hTaPDNBt9Az7tQYFanj9SvamCVFeP0hBd0EHanzhssxhnMRzHqSyzT sr2JQ3bwnOwJ0jZ6kOT6RkyfPEUvMXaXRJRveYHHMcWWbShcQh6RGWpVK/Q6R8IeX1fU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170199: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl:xen-boot:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=13220a46e27ef95159651acd5e408b6aac9dbf3e X-Osstest-Versions-That: qemuu=31abf61c4929a91275fe32f1fafe6e6b3e840b2a From: osstest service owner Date: Sat, 07 May 2022 12:53:20 +0000 flight 170199 qemu-mainline real [real] flight 170210 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170199/ http://logs.test-lab.xenproject.org/osstest/logs/170210/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl 8 xen-boot fail pass in 170210-retest test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 170210-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 15 migrate-support-check fail in 170210 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 170210 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170181 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170181 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170181 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170181 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170181 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170181 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170181 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170181 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 13220a46e27ef95159651acd5e408b6aac9dbf3e baseline version: qemuu 31abf61c4929a91275fe32f1fafe6e6b3e840b2a Last test of basis 170181 2022-05-06 10:18:20 Z 1 days Testing same since 170199 2022-05-07 03:07:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Williamson Eric Auger Longpeng(Mike) Richard Henderson Stefan Berger Xiang Chen Yi Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 31abf61c49..13220a46e2 13220a46e27ef95159651acd5e408b6aac9dbf3e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 07 13:28:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 13:28:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323713.545508 (Exim 4.92) (envelope-from ) id 1nnKTh-0001QN-O9; Sat, 07 May 2022 13:28:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323713.545508; Sat, 07 May 2022 13:28:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnKTh-0001QG-KJ; Sat, 07 May 2022 13:28:09 +0000 Received: by outflank-mailman (input) for mailman id 323713; Sat, 07 May 2022 13:28:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnKTg-0001Q6-Lh; Sat, 07 May 2022 13:28:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnKTg-0007OC-IQ; Sat, 07 May 2022 13:28:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnKTg-0005RT-0I; Sat, 07 May 2022 13:28:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnKTf-0005Qx-W6; Sat, 07 May 2022 13:28:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OJLyrAVKrkkyCbFleJv/KGS48fQYf+wgPR9tucjmzGU=; b=PKYuvGoJYSH67GklNjOSp1zK4a 7gRUJS/Op5tx1JXNDUS7z/CVkHgwIorENcFtefYGQ1xTgTx3nzkkwbi8/2MU5vCQvK5W43i6qc2n5 Hap4bJQfTNln/OuSPhUx6L/agnBz6kI2Xd14KvLskIOilbaYtGlbqQy8Q6dF7Yb7Pmg8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170211: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 13:28:07 +0000 flight 170211 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170211/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 857 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 14:20:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 14:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323721.545519 (Exim 4.92) (envelope-from ) id 1nnLHu-0006rx-R6; Sat, 07 May 2022 14:20:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323721.545519; Sat, 07 May 2022 14:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnLHu-0006rM-Ns; Sat, 07 May 2022 14:20:02 +0000 Received: by outflank-mailman (input) for mailman id 323721; Sat, 07 May 2022 14:20:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnLHt-0006hd-4Q; Sat, 07 May 2022 14:20:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnLHt-0008Jm-2k; Sat, 07 May 2022 14:20:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnLHs-0007qp-Nz; Sat, 07 May 2022 14:20:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnLHs-0000Cv-NV; Sat, 07 May 2022 14:20:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CJCRZtX2whfG4+Xx4Hj39osEd5OvQWdH4ejkUKQvWsA=; b=5Pl0R2BNloPzwOu6h2nIfgEblK vHpmIy2dAS5iqeYRt60Mp5gFI4isUYCoEl0SV0ZaoNFzTpIv/T5x6yQWKxg1iboAk3ReHggden677 Mj9ieVnNfcd8DETFJRXMahxN4K4dWXJeZj8RuuHWeSz8RIhkmZVQxX3gbZa4VSDSTMgg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170213: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 14:20:00 +0000 flight 170213 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170213/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 858 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 15:40:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 15:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323732.545530 (Exim 4.92) (envelope-from ) id 1nnMXj-0006ws-Ni; Sat, 07 May 2022 15:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323732.545530; Sat, 07 May 2022 15:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnMXj-0006wl-Kc; Sat, 07 May 2022 15:40:27 +0000 Received: by outflank-mailman (input) for mailman id 323732; Sat, 07 May 2022 15:40:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnMXi-0006wb-J7; Sat, 07 May 2022 15:40:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnMXi-0001Dg-FJ; Sat, 07 May 2022 15:40:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnMXh-0002pd-Vg; Sat, 07 May 2022 15:40:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnMXh-0000pC-VE; Sat, 07 May 2022 15:40:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XEmwcrkVdDLjpSq1IZTCu/bDSamG7NYh8BYh3MexE8E=; b=gufj0de9sagy0zgj7csUjm7Thd AqPCcOEkLgf90CGN6c0Ocvyujfgt/zk8oYK/muM1TFMg5AHXmD0+FzNi+MCSCj3B0SZyDXp+IjOjF 1pyyiEB4bFWLOatQCbaUjmk9Ps0TnRvZGJFYz1bDVjIK76JzY1pSxr52GcT+gNClMFCM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170214: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 15:40:25 +0000 flight 170214 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170214/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 859 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 16:49:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 16:49:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323739.545540 (Exim 4.92) (envelope-from ) id 1nnNbw-0005Hm-Pl; Sat, 07 May 2022 16:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323739.545540; Sat, 07 May 2022 16:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnNbw-0005Hf-N9; Sat, 07 May 2022 16:48:52 +0000 Received: by outflank-mailman (input) for mailman id 323739; Sat, 07 May 2022 16:48:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnNbv-0005HV-IW; Sat, 07 May 2022 16:48:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnNbv-0002wi-G7; Sat, 07 May 2022 16:48:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnNbv-0007BF-2c; Sat, 07 May 2022 16:48:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnNbv-0002Lt-2C; Sat, 07 May 2022 16:48:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2x+9vPhXXGn7bKz1vXQm4f11UhB+AJK4QZClqoTJk7c=; b=NsWpmFbeLOeS2GkQ5GFPcOsycj bpysItRuz5W8z4TsoYtqOOXL3G66fF7IOZGHV6sj1R4WS/8KHI3XLgY1oVXo6fQtU6VjT67GQMj5r 24c5oq2TVTb5qZjmDRIWR+mT7V7jaGGH/GDxu5bCAoOF2hsGf9LpeJZ7RAdXM0N2KncU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170215: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 16:48:51 +0000 flight 170215 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170215/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 860 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 17:29:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 17:29:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323746.545552 (Exim 4.92) (envelope-from ) id 1nnOFX-00019V-Uf; Sat, 07 May 2022 17:29:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323746.545552; Sat, 07 May 2022 17:29:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnOFX-00019O-Rt; Sat, 07 May 2022 17:29:47 +0000 Received: by outflank-mailman (input) for mailman id 323746; Sat, 07 May 2022 17:29:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnOFW-00019C-VM; Sat, 07 May 2022 17:29:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnOFW-0003g8-TY; Sat, 07 May 2022 17:29:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnOFW-0008Js-Ic; Sat, 07 May 2022 17:29:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnOFW-0007Q3-IE; Sat, 07 May 2022 17:29:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6SbHVLnR1jiFYjz8oJin/r9ZlOHExxG+TsSclIc6zVQ=; b=GHi+JQdbfHV/IF4GAd0Flq5daN hcwHI6xBIizlcmLn15AOZB0vL/JoeLbrRADK7/f7cv2KJIuGb/Kox2UHYyRPZukj2FAffhoFPyVN9 xOenvpRo/aSI6JHi246ZWyy54xvTIA4gEUTkflOUjvZJM19MygCJCB584aYdLXAB2UJI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170217: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 17:29:46 +0000 flight 170217 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170217/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 861 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323754.545563 (Exim 4.92) (envelope-from ) id 1nnP1W-0006U4-L2; Sat, 07 May 2022 18:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323754.545563; Sat, 07 May 2022 18:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1W-0006Tx-ID; Sat, 07 May 2022 18:19:22 +0000 Received: by outflank-mailman (input) for mailman id 323754; Sat, 07 May 2022 18:19:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1V-0006Tm-01 for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:21 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35fb33b5-ce32-11ec-a406-831a346695d4; Sat, 07 May 2022 20:19:19 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso8572902wme.5 for ; Sat, 07 May 2022 11:19:19 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35fb33b5-ce32-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XX78GWwMd1nia7nwVqcpbwaGJYOhbuMkDsq/dHRQm1Y=; b=NMekUxOk5A9I52CMEmMbtbPh5mza3hWVxCElP9ubE0KvS685lAQ6mzs2uEPkqTYBK5 FOtr+BdB6ua9HG1LiAdwO4OQ/ebkBrNvHN1d0E5RgAetlfcCL9tAiR43Og6zAlRYW55W 88r+oBoEZNEYeE4R4NV8LEcDnq8OEteXHou8aU/wrzVABEqgAjc7i4hhEk2ZK2u1/oZ5 tgrOFy5uwz0lMPGxrMtC90bOEVjYYOCBCs8FlIuoyp4LB7p3QuIBSKqqtl6lhwkMVfIP 03ZEu+ufqYvoSDN/C1JgVRCqUCkWH+mdS79q9RnfT6RP+tvDiP45mUuKhqCYaxTE2DLc JP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XX78GWwMd1nia7nwVqcpbwaGJYOhbuMkDsq/dHRQm1Y=; b=kPYWkx/ScKm2tjDKFKz0a7BNSEcH/BcpJODma8SLrV5RGWPDi8wBCooF5+SlIY/6Yx oP6CO2xqnBlyrp3p7R+NqXOfZ+YJW8Q6o+gNpExk9eUMLV027sPt6QIGW0UyZKxdOx83 Ur5LMCQPnSnlt1ZN0R+u165LK6Y+gOJ0MGSNSvN5V+v4PDxlLfOseykqubcDCesAjKhl JVL9VvPkXDNoe4QHzbsMg+TDQrCsvjbxpWL2um3ZQhcg2UburRkygSuSuytePxaoM1hF K7Y1dfCIckh1zdCQcjUUCdq3+1AWS0fxVIu77fCWWR9l9jds9iq2CQl92HJqAy/WPEyU lOIw== X-Gm-Message-State: AOAM530L/GNlThdNeqJZO8XggpDe0cq42QDxSfE9Lc15wBpeIZhgQtk8 KtP3Bqf3mG4whevHOSmos6FbVgt3eFw= X-Google-Smtp-Source: ABdhPJwccDv2hxVU9RUi+xr7GLJPabMJIGyT1Ic0dLKzlXNKKB7nSQ4aD1yIw6UH2GBRi7PQazSapw== X-Received: by 2002:a05:600c:2112:b0:393:ff25:fb92 with SMTP id u18-20020a05600c211200b00393ff25fb92mr8827389wml.194.1651947557846; Sat, 07 May 2022 11:19:17 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, x86@kernel.org Cc: Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , Bertrand Marquis , Wei Chen , Henry Wang , Kaly Xin , Jiamei Xie , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH V2 0/7] virtio: Solution to restrict memory access under Xen using xen-grant DMA-mapping layer Date: Sat, 7 May 2022 21:19:01 +0300 Message-Id: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add support for restricting memory access under Xen using specific grant table [1] based DMA-mapping layer. Patch series is based on Juergen Gross’ initial work [2] which implies using grant references instead of raw guest physical addresses (GPA) for the virtio communications (some kind of the software IOMMU). You can find RFC-V1 patch series (and previous discussions) at [3]. The high level idea is to create new Xen’s grant table based DMA-mapping layer for the guest Linux whose main purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page to be shared with the backend) with offset and setting the highest address bit (this is for the backend to be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern transport for 64-bit addresses in the virtqueue). Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else. According to the discussions in various mainline threads this solution would likely be welcome because it perfectly fits in the security model Xen provides. What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table for that particular device). We only need to update toolstack to insert a new "xen,dev-domid" property to the virtio-mmio device node when creating a guest device-tree (this is an indicator for the guest to use grants and the ID of Xen domain where the corresponding backend resides, it is used as an argument to the grant mapping APIs). It worth mentioning that toolstack patch is based on non upstreamed yet “Virtio support for toolstack on Arm” series which is on review now [4]. Please note the following: - Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access feature on Arm the following option should be set: CONFIG_XEN_VIRTIO = y - Patch series is based on "platform_has()" patch series which is on review now [5] - Xen should be built with the following options: CONFIG_IOREQ_SERVER=y CONFIG_EXPERT=y Patch series is rebased on Linux 5.18-rc4 tag with "platform_has()" series applied and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy' use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices or a mix of virtio and Xen PV block devices to the guest. Patch series was build-tested on Arm32 and x86. 1. Xen changes located at (last patch): https://github.com/otyshchenko1/xen/commits/libxl_virtio_next1 2. Linux changes located at (last 7 patches): https://github.com/otyshchenko1/linux/commits/virtio_grant7 3. virtio-disk changes located at: https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant Any feedback/help would be highly appreciated. [1] https://xenbits.xenproject.org/docs/4.16-testing/misc/grant-tables.txt [2] https://www.youtube.com/watch?v=IrlEdaIUDPk [3] https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gmail.com/ [4] https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ [5] https://lore.kernel.org/xen-devel/20220504155703.13336-1-jgross@suse.com/ Juergen Gross (3): xen/grants: support allocating consecutive grants xen/grant-dma-ops: Add option to restrict memory access under Xen xen/virtio: Enable restricted memory access using Xen grant mappings Oleksandr Tyshchenko (4): arm/xen: Introduce xen_setup_dma_ops() dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 +++ Documentation/devicetree/bindings/virtio/mmio.yaml | 7 + arch/arm/include/asm/xen/xen-ops.h | 2 + arch/arm/mm/dma-mapping.c | 7 +- arch/arm/xen/enlighten.c | 2 + arch/arm64/include/asm/xen/xen-ops.h | 2 + arch/arm64/mm/dma-mapping.c | 7 +- arch/x86/xen/enlighten_hvm.c | 2 + arch/x86/xen/enlighten_pv.c | 2 + drivers/xen/Kconfig | 15 + drivers/xen/Makefile | 1 + drivers/xen/grant-dma-ops.c | 324 +++++++++++++++++++++ drivers/xen/grant-table.c | 238 +++++++++++++-- include/xen/arm/xen-ops.h | 18 ++ include/xen/grant_table.h | 4 + include/xen/xen-ops.h | 13 + include/xen/xen.h | 8 + 17 files changed, 647 insertions(+), 42 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml create mode 100644 arch/arm/include/asm/xen/xen-ops.h create mode 100644 arch/arm64/include/asm/xen/xen-ops.h create mode 100644 drivers/xen/grant-dma-ops.c create mode 100644 include/xen/arm/xen-ops.h -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323757.545596 (Exim 4.92) (envelope-from ) id 1nnP1c-0007IE-IO; Sat, 07 May 2022 18:19:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323757.545596; Sat, 07 May 2022 18:19:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1c-0007I4-Ef; Sat, 07 May 2022 18:19:28 +0000 Received: by outflank-mailman (input) for mailman id 323757; Sat, 07 May 2022 18:19:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1b-00079i-4b for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:27 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 392a1dbf-ce32-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 20:19:24 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id k126so6254940wme.2 for ; Sat, 07 May 2022 11:19:24 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 392a1dbf-ce32-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/tE24Epa/B9t6hINhti+0qrrH2Ayc1ZVkfo5g4wLeJM=; b=pHunhm5LcGaWGqSqpnCaJLx1HKwwGm+QcAnyHXni4G05/DDzLu2dBCIMlTSs7Kro1r Imn+rsvPoXSJMbnO9sqeeo6fJ0w/25pXPesstI2pdMmYSHfUc4SHlTQw98HSRt1LNzk8 x153rz6Sd6vfTRIX0+v3B5mC4ntIR/NWR2YUs8BMSHF5A/agx379p/zUe5ACZoNhwHDZ NPCdJK9Inl/jdm8S1FpBqyILR9jorjdbdrJR+jR/4DRbHzewrO/YMAp8eRwi1fA3FfD+ aABoI/isygKUQxu1kQNlDPhC/e19Jz2I8BoUYqpdFbYShAwaVq8FSMb30nCHea6JeW0L hjwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/tE24Epa/B9t6hINhti+0qrrH2Ayc1ZVkfo5g4wLeJM=; b=0Fd341ACJEUR+ydJjft/Y0EkDX/yBnOdjfY+RE6JN4NWcgpNuoi4ZFt04AjruGLSjc nZEHY6lA4i8pwfkjxLWWrggbEl9654TybtswIohmaS9ZcZnA68Ynond6HzfZWLmTbObG R8DtShOLJ949PykrmkLrF1FkQfG6OZU/lbbXPjUTonkuXCHQCVp0Y/6AgHlledjvR9i9 0xwHGB6a++8tshDxM61WrXepaB0ONoF3encygbDwroiE8Uez3HFAHIPBXDrOcEmZHtMR YFWyackjIsBw7oy20GF//l3JkTqeggll5NkOdLy2/T7nuTWYiwfeEJwYd9IAyi5ujXGA KV8A== X-Gm-Message-State: AOAM530KP1DIEPKIcYvirtsMP2HMYmDUix1lrEAYSZTOjGWT5SQTms22 qlQmbHApouTHOVQNTSoce6UtxuoTFss= X-Google-Smtp-Source: ABdhPJxBOOgVAgBRCVt+whQtaQ1bMotolbL617ZTixMBeupKujHPOUz5W2K18bpkn4k6f+wihFjJ5g== X-Received: by 2002:a05:600c:1909:b0:394:47d2:eca9 with SMTP id j9-20020a05600c190900b0039447d2eca9mr15802949wmq.82.1651947563308; Sat, 07 May 2022 11:19:23 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 3/7] xen/grant-dma-ops: Add option to restrict memory access under Xen Date: Sat, 7 May 2022 21:19:04 +0300 Message-Id: <1651947548-4055-4-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Juergen Gross Introduce Xen grant DMA-mapping layer which contains special DMA-mapping routines for providing grant references as DMA addresses to be used by frontends (e.g. virtio) in Xen guests. Add the needed functionality by providing a special set of DMA ops handling the needed grant operations for the I/O pages. The subsequent commit will introduce the use case for xen-grant DMA ops layer to enable using virtio devices in Xen guests in a safe manner. Signed-off-by: Juergen Gross Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - squash with almost all changes from commit (except handling "xen,dev-domid" property): "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" - update commit subject/description and comments in code - leave only single Kconfig option XEN_VIRTIO and remove architectural dependencies - introduce common xen_has_restricted_virtio_memory_access() in xen.h and update arch_has_restricted_virtio_memory_access() for both Arm and x86 to call new helper - use (1ULL << 63) instead of 0x8000000000000000ULL for XEN_GRANT_ADDR_OFF - implement xen_virtio_dma_map(unmap)_sg() using example in swiotlb-xen.c - optimize padding by moving "broken" field in struct xen_virtio_data - remove unneeded per-device spinlock - remove the inclusion of virtio_config.h - remane everything according to the new naming scheme: s/virtio/grant_dma - add new hidden config option XEN_GRANT_DMA_OPS Changes V1 -> V2: - fix checkpatch.pl warnings - remove the inclusion of linux/pci.h - rework to use xarray for data context - remove EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops); - remove the line of * after SPDX-License-Identifier - split changes into grant-dma-ops.c and arch_has_restricted_virtio_memory_access() and update commit subject/description accordingly - remove "default n" for config XEN_VIRTIO - implement xen_grant_dma_alloc(free)_pages() --- drivers/xen/Kconfig | 4 + drivers/xen/Makefile | 1 + drivers/xen/grant-dma-ops.c | 314 ++++++++++++++++++++++++++++++++++++++++++++ include/xen/xen-ops.h | 8 ++ 4 files changed, 327 insertions(+) create mode 100644 drivers/xen/grant-dma-ops.c diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 120d32f..313a9127 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -335,4 +335,8 @@ config XEN_UNPOPULATED_ALLOC having to balloon out RAM regions in order to obtain physical memory space to create such mappings. +config XEN_GRANT_DMA_OPS + bool + select DMA_OPS + endmenu diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 5aae66e..1a23cb0 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -39,3 +39,4 @@ xen-gntalloc-y := gntalloc.o xen-privcmd-y := privcmd.o privcmd-buf.o obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF) += xen-front-pgdir-shbuf.o obj-$(CONFIG_XEN_UNPOPULATED_ALLOC) += unpopulated-alloc.o +obj-$(CONFIG_XEN_GRANT_DMA_OPS) += grant-dma-ops.o diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c new file mode 100644 index 00000000..29ad7bf --- /dev/null +++ b/drivers/xen/grant-dma-ops.c @@ -0,0 +1,314 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Xen grant DMA-mapping layer - contains special DMA-mapping routines + * for providing grant references as DMA addresses to be used by frontends + * (e.g. virtio) in Xen guests + * + * Copyright (c) 2021, Juergen Gross + */ + +#include +#include +#include +#include +#include +#include +#include + +struct xen_grant_dma_data { + /* The ID of backend domain */ + domid_t dev_domid; + /* Is device behaving sane? */ + bool broken; +}; + +static DEFINE_XARRAY(xen_grant_dma_devices); + +#define XEN_GRANT_DMA_ADDR_OFF (1ULL << 63) + +static inline dma_addr_t grant_to_dma(grant_ref_t grant) +{ + return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT); +} + +static inline grant_ref_t dma_to_grant(dma_addr_t dma) +{ + return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT); +} + +static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) +{ + struct xen_grant_dma_data *data; + + xa_lock(&xen_grant_dma_devices); + data = xa_load(&xen_grant_dma_devices, (unsigned long)dev); + xa_unlock(&xen_grant_dma_devices); + + return data; +} + +/* + * DMA ops for Xen frontends (e.g. virtio). + * + * Used to act as a kind of software IOMMU for Xen guests by using grants as + * DMA addresses. + * Such a DMA address is formed by using the grant reference as a frame + * number and setting the highest address bit (this bit is for the backend + * to be able to distinguish it from e.g. a mmio address). + * + * Note that for now we hard wire dom0 to be the backend domain. In order + * to support any domain as backend we'd need to add a way to communicate + * the domid of this backend, e.g. via Xenstore, via the PCI-device's + * config space or DT/ACPI. + */ +static void *xen_grant_dma_alloc(struct device *dev, size_t size, + dma_addr_t *dma_handle, gfp_t gfp, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + unsigned long pfn; + grant_ref_t grant; + void *ret; + + data = find_xen_grant_dma_data(dev); + if (!data) + return NULL; + + if (unlikely(data->broken)) + return NULL; + + ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp); + if (!ret) + return NULL; + + pfn = virt_to_pfn(ret); + + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) { + free_pages_exact(ret, n_pages * PAGE_SIZE); + return NULL; + } + + for (i = 0; i < n_pages; i++) { + gnttab_grant_foreign_access_ref(grant + i, data->dev_domid, + pfn_to_gfn(pfn + i), 0); + } + + *dma_handle = grant_to_dma(grant); + + return ret; +} + +static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr, + dma_addr_t dma_handle, unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + + data = find_xen_grant_dma_data(dev); + if (!data) + return; + + if (unlikely(data->broken)) + return; + + grant = dma_to_grant(dma_handle); + + for (i = 0; i < n_pages; i++) { + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); + data->broken = true; + return; + } + } + + gnttab_free_grant_reference_seq(grant, n_pages); + + free_pages_exact(vaddr, n_pages * PAGE_SIZE); +} + +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size, + dma_addr_t *dma_handle, + enum dma_data_direction dir, + gfp_t gfp) +{ + void *vaddr; + + vaddr = xen_grant_dma_alloc(dev, size, dma_handle, gfp, 0); + if (!vaddr) + return NULL; + + return virt_to_page(vaddr); +} + +static void xen_grant_dma_free_pages(struct device *dev, size_t size, + struct page *vaddr, dma_addr_t dma_handle, + enum dma_data_direction dir) +{ + xen_grant_dma_free(dev, size, page_to_virt(vaddr), dma_handle, 0); +} + +static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page, + unsigned long offset, size_t size, + enum dma_data_direction dir, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + dma_addr_t dma_handle; + + if (WARN_ON(dir == DMA_NONE)) + return DMA_MAPPING_ERROR; + + data = find_xen_grant_dma_data(dev); + if (!data) + return DMA_MAPPING_ERROR; + + if (unlikely(data->broken)) + return DMA_MAPPING_ERROR; + + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) + return DMA_MAPPING_ERROR; + + for (i = 0; i < n_pages; i++) { + gnttab_grant_foreign_access_ref(grant + i, data->dev_domid, + xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE); + } + + dma_handle = grant_to_dma(grant) + offset; + + return dma_handle; +} + +static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, + size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + + if (WARN_ON(dir == DMA_NONE)) + return; + + data = find_xen_grant_dma_data(dev); + if (!data) + return; + + if (unlikely(data->broken)) + return; + + grant = dma_to_grant(dma_handle); + + for (i = 0; i < n_pages; i++) { + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); + data->broken = true; + return; + } + } + + gnttab_free_grant_reference_seq(grant, n_pages); +} + +static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + struct scatterlist *s; + unsigned int i; + + if (WARN_ON(dir == DMA_NONE)) + return; + + for_each_sg(sg, s, nents, i) + xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir, + attrs); +} + +static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + struct scatterlist *s; + unsigned int i; + + if (WARN_ON(dir == DMA_NONE)) + return -EINVAL; + + for_each_sg(sg, s, nents, i) { + s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset, + s->length, dir, attrs); + if (s->dma_address == DMA_MAPPING_ERROR) + goto out; + + sg_dma_len(s) = s->length; + } + + return nents; + +out: + xen_grant_dma_unmap_sg(dev, sg, i, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC); + sg_dma_len(sg) = 0; + + return -EIO; +} + +static int xen_grant_dma_supported(struct device *dev, u64 mask) +{ + return mask == DMA_BIT_MASK(64); +} + +static const struct dma_map_ops xen_grant_dma_ops = { + .alloc = xen_grant_dma_alloc, + .free = xen_grant_dma_free, + .alloc_pages = xen_grant_dma_alloc_pages, + .free_pages = xen_grant_dma_free_pages, + .mmap = dma_common_mmap, + .get_sgtable = dma_common_get_sgtable, + .map_page = xen_grant_dma_map_page, + .unmap_page = xen_grant_dma_unmap_page, + .map_sg = xen_grant_dma_map_sg, + .unmap_sg = xen_grant_dma_unmap_sg, + .dma_supported = xen_grant_dma_supported, +}; + +void xen_grant_setup_dma_ops(struct device *dev) +{ + struct xen_grant_dma_data *data; + uint32_t dev_domid; + + data = find_xen_grant_dma_data(dev); + if (data) { + dev_err(dev, "Xen grant DMA data is already created\n"); + return; + } + + /* XXX The dom0 is hardcoded as the backend domain for now */ + dev_domid = 0; + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + goto err; + + data->dev_domid = dev_domid; + + if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, + GFP_KERNEL))) { + dev_err(dev, "Cannot store Xen grant DMA data\n"); + goto err; + } + + dev->dma_ops = &xen_grant_dma_ops; + + return; + +err: + dev_err(dev, "Сannot set up Xen grant DMA ops, retain platform DMA ops\n"); +} + +MODULE_DESCRIPTION("Xen grant DMA-mapping layer"); +MODULE_AUTHOR("Juergen Gross "); +MODULE_LICENSE("GPL"); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a3584a3..4f9fad5 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { } #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */ +#ifdef CONFIG_XEN_GRANT_DMA_OPS +void xen_grant_setup_dma_ops(struct device *dev); +#else +static inline void xen_grant_setup_dma_ops(struct device *dev) +{ +} +#endif /* CONFIG_XEN_GRANT_DMA_OPS */ + #endif /* INCLUDE_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323755.545574 (Exim 4.92) (envelope-from ) id 1nnP1X-0006jT-T4; Sat, 07 May 2022 18:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323755.545574; Sat, 07 May 2022 18:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1X-0006jM-Pn; Sat, 07 May 2022 18:19:23 +0000 Received: by outflank-mailman (input) for mailman id 323755; Sat, 07 May 2022 18:19:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1V-0006Tm-Ow for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:21 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36f9c426-ce32-11ec-a406-831a346695d4; Sat, 07 May 2022 20:19:21 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id m2-20020a1ca302000000b003943bc63f98so6129843wme.4 for ; Sat, 07 May 2022 11:19:20 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f9c426-ce32-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JdehnkGLqTKFFqJmno6u7ZfWHrdJGNPcR0+Jk9IE3ng=; b=W2CM1/+K9Zk1Kt7dirJgx2bl5Gzq0zuZnPN5BVRpPATox1liMddFAgkXT9YhMEJKJW 3O660mwRMAf8TC005txxxBgmgrS9oiMeZwotoJPeew+vIvCdOm765wKV5c9x0BQ00/qM lOgnr6KN7alyGkPQQDDUnMJeacpkc2gh1QJmK01mhUdDzdgbsOjUoKte+pU3cJeipEuf YSvs0HkqOPU6wQ5cIxg7hJrG1hxCK2aJ4ZjSYAp3T1krrkp7p1CUCOkmJSjmRJV2FUhp N7Fr3JhClK19P4klrT/48MqsDShlu0CI9z8qoywZr6bhKFckl2kixdga3Z5rYAdM4lNL NeOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JdehnkGLqTKFFqJmno6u7ZfWHrdJGNPcR0+Jk9IE3ng=; b=KJaxT8T12HeSmZK9j2tBWHIlTGJsmkd9MS4knL28sOpMmBfHi+265HQCtpvfS6CSx+ jo3d1+W8kMiAeD4EUgxU3bUBrtsprPpDeVESpjMgKvI3FOWIVZ8mlRSEGh6C/6JYyxCx +It6wyniH31NSKtmgy5+XU48+B/gtpCYclL82nKMSS4bjwKxDPOxYngZ2hhiApZutMu1 Adi3rpdxtRK5Q5Emr8zJbPDbI6E0rCemPH+RNVYG7vvHo1k3PpnTN1bOlMLim6otYj+0 tbERcAJWLEDlW7lZVJO/6ZyKNPph3F6bsxU1XwdraeuYBTDU2KUsv5hgZJyWzCH7lDxs Txrg== X-Gm-Message-State: AOAM531rKDnJgUwpnhw2iqbzm4QhteuDaLcLwm1yhqFhqstFUAfM9Fr9 MsSFBsAIsnygeWlGihgxCu5JqxsA248= X-Google-Smtp-Source: ABdhPJwcoJACAJIOBQsEykFr9K/bH+BLZEo0MgY60F8IfPkFfRkCVpyNg4ZkPrg0s2ewaX0SV0R9DQ== X-Received: by 2002:a7b:c446:0:b0:394:3293:a88f with SMTP id l6-20020a7bc446000000b003943293a88fmr8943853wmi.22.1651947559848; Sat, 07 May 2022 11:19:19 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Catalin Marinas , Will Deacon , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 1/7] arm/xen: Introduce xen_setup_dma_ops() Date: Sat, 7 May 2022 21:19:02 +0300 Message-Id: <1651947548-4055-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko This patch introduces new helper and places it in new header. The helper's purpose is to assign any Xen specific DMA ops in a single place. For now, we deal with xen-swiotlb DMA ops only. The one of the subsequent commits in current series will add xen-grant DMA ops case. Also re-use the xen_swiotlb_detect() check on Arm32. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini --- Changes RFC -> V1: - update commit description - move commit to the beginning of the series - move #ifdef CONFIG_XEN from dma-mapping.c to xen-ops.h Changes V1 -> V2: - add Stefano's R-b - add missing SPDX-License-Identifier to xen-ops.h --- arch/arm/include/asm/xen/xen-ops.h | 2 ++ arch/arm/mm/dma-mapping.c | 7 ++----- arch/arm64/include/asm/xen/xen-ops.h | 2 ++ arch/arm64/mm/dma-mapping.c | 7 ++----- include/xen/arm/xen-ops.h | 15 +++++++++++++++ 5 files changed, 23 insertions(+), 10 deletions(-) create mode 100644 arch/arm/include/asm/xen/xen-ops.h create mode 100644 arch/arm64/include/asm/xen/xen-ops.h create mode 100644 include/xen/arm/xen-ops.h diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h new file mode 100644 index 00000000..7ebb7eb --- /dev/null +++ b/arch/arm/include/asm/xen/xen-ops.h @@ -0,0 +1,2 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 82ffac6..059cce0 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include "dma.h" #include "mm.h" @@ -2287,10 +2287,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, set_dma_ops(dev, dma_ops); -#ifdef CONFIG_XEN - if (xen_initial_domain()) - dev->dma_ops = &xen_swiotlb_dma_ops; -#endif + xen_setup_dma_ops(dev); dev->archdata.dma_ops_setup = true; } diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h new file mode 100644 index 00000000..7ebb7eb --- /dev/null +++ b/arch/arm64/include/asm/xen/xen-ops.h @@ -0,0 +1,2 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 6719f9e..6099c81 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -9,9 +9,9 @@ #include #include #include -#include #include +#include void arch_sync_dma_for_device(phys_addr_t paddr, size_t size, enum dma_data_direction dir) @@ -52,8 +52,5 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, if (iommu) iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1); -#ifdef CONFIG_XEN - if (xen_swiotlb_detect()) - dev->dma_ops = &xen_swiotlb_dma_ops; -#endif + xen_setup_dma_ops(dev); } diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h new file mode 100644 index 00000000..288deb1 --- /dev/null +++ b/include/xen/arm/xen-ops.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_ARM_XEN_OPS_H +#define _ASM_ARM_XEN_OPS_H + +#include + +static inline void xen_setup_dma_ops(struct device *dev) +{ +#ifdef CONFIG_XEN + if (xen_swiotlb_detect()) + dev->dma_ops = &xen_swiotlb_dma_ops; +#endif +} + +#endif /* _ASM_ARM_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323758.545602 (Exim 4.92) (envelope-from ) id 1nnP1d-0007Lv-0L; Sat, 07 May 2022 18:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323758.545602; Sat, 07 May 2022 18:19:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1c-0007Kh-O9; Sat, 07 May 2022 18:19:28 +0000 Received: by outflank-mailman (input) for mailman id 323758; Sat, 07 May 2022 18:19:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1b-00079i-PL for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:27 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a2ff787-ce32-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 20:19:26 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 125-20020a1c1983000000b003941f354c62so6139733wmz.0 for ; Sat, 07 May 2022 11:19:26 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a2ff787-ce32-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7ptoks8wk67ER3ivOLNGqLnlrp2ieijG6XsCJH8U+xs=; b=d0kYK2iQ+DUSxY8TIV5wRNyHPklomH/v8OiDA4avtHKXjmkp4Zp1juytfZVUe5R9jw 6iI1z703N161/p94YTEgZzBvV9tNZtwPoy1WZ99vf+cAGadEz6RqANGY9FVDwr2m9bcl Vq7ONdNVKafzqy9lZM8s8n4nvRB9ora+yUZoAt2GW5V39j3rxHySpA1Bl9hCr6EfO8wr wcE7f5iYJhMtLTBFXVXiEc4fKvgbgVfEgQsPHaAzdWDsIo3wWtkzNdw3r6VK/JIMDzna jKGEcTMofqI63n2NHbaC2hXBtSEP29EI9mF7SGOUoo5t1apStnAP1DkfYc+vLXvc6o9J 31OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7ptoks8wk67ER3ivOLNGqLnlrp2ieijG6XsCJH8U+xs=; b=qc4hcwkvrlIVkWPqgkZGhfV32e8c/kay79SVXhB3SZF+G+yk8CP+uaR7pAwNzRHIDK Jm5WwBFUSSMPM/ojNbwQW7kShxwJI/qKW57IjgZ0pAn0l2EBGfGb+vk09bTZtlXdgOIE W5qSXu6YYuM+7xsTtOusKTsMiDp3OKlGnxIydqt2zHaBYU0VJmWr7+H4nyuJ/H5xq7fZ cbPUAdgEyL2Wx2vqsOjCoh7WcIb+7SrHhdoi+nJ/NGBZcsaHcRfP5eKu0n+yHcjUsOWT icD9+Xz67EpDT9H5pY407EIPEbf3JDVDm7/UZpW3/MP2LNwQOnZSayGMY3wqAw3akBla mtCA== X-Gm-Message-State: AOAM532D0WV+uDK4SbYssZ/6XhaDBM/k5NtLXzEVXqVxPKC6s8D1QxhI eeWSVZXjYY55qD+i0HUqyxHHeR0m3tI= X-Google-Smtp-Source: ABdhPJzE5bIacIcwrc1M6w7qJQB9mFgFaaKn933CxgAcdM1oZCHeWaRYPU3HEcjcxuQeVC7j1yiIqw== X-Received: by 2002:a05:600c:3393:b0:394:160a:18aa with SMTP id o19-20020a05600c339300b00394160a18aamr15602115wmp.58.1651947565193; Sat, 07 May 2022 11:19:25 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 4/7] xen/virtio: Enable restricted memory access using Xen grant mappings Date: Sat, 7 May 2022 21:19:05 +0300 Message-Id: <1651947548-4055-5-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Juergen Gross In order to support virtio in Xen guests add a config option XEN_VIRTIO enabling the user to specify whether in all Xen guests virtio should be able to access memory via Xen grant mappings only on the host side. Also set PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS feature from the guest initialization code on Arm and x86 if CONFIG_XEN_VIRTIO is enabled. Signed-off-by: Juergen Gross Signed-off-by: Oleksandr Tyshchenko --- Changes V1 -> V2: - new patch, split required changes from commit: "[PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen" - rework according to new platform_has() infrastructure --- arch/arm/xen/enlighten.c | 2 ++ arch/x86/xen/enlighten_hvm.c | 2 ++ arch/x86/xen/enlighten_pv.c | 2 ++ drivers/xen/Kconfig | 11 +++++++++++ include/xen/xen.h | 8 ++++++++ 5 files changed, 25 insertions(+) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 07eb69f..1f9c3ba 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -443,6 +443,8 @@ static int __init xen_guest_init(void) if (!xen_domain()) return 0; + xen_set_restricted_virtio_memory_access(); + if (!acpi_disabled) xen_acpi_guest_init(); else diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 517a9d8..8b71b1d 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -195,6 +195,8 @@ static void __init xen_hvm_guest_init(void) if (xen_pv_domain()) return; + xen_set_restricted_virtio_memory_access(); + init_hvm_pv_info(); reserve_shared_info(); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5038edb..fcd5d5d 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -109,6 +109,8 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc); static void __init xen_pv_init_platform(void) { + xen_set_restricted_virtio_memory_access(); + populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP)); set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info); diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 313a9127..a7bd8ce 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -339,4 +339,15 @@ config XEN_GRANT_DMA_OPS bool select DMA_OPS +config XEN_VIRTIO + bool "Xen virtio support" + depends on VIRTIO + select XEN_GRANT_DMA_OPS + help + Enable virtio support for running as Xen guest. Depending on the + guest type this will require special support on the backend side + (qemu or kernel, depending on the virtio device types used). + + If in doubt, say n. + endmenu diff --git a/include/xen/xen.h b/include/xen/xen.h index a99bab8..0780a81 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -52,6 +52,14 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, extern u64 xen_saved_max_mem_size; #endif +#include + +static inline void xen_set_restricted_virtio_memory_access(void) +{ + if (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain()) + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); +} + #ifdef CONFIG_XEN_UNPOPULATED_ALLOC int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages); void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323759.545618 (Exim 4.92) (envelope-from ) id 1nnP1f-0007sH-AU; Sat, 07 May 2022 18:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323759.545618; Sat, 07 May 2022 18:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1f-0007s4-48; Sat, 07 May 2022 18:19:31 +0000 Received: by outflank-mailman (input) for mailman id 323759; Sat, 07 May 2022 18:19:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1c-0006Tm-SQ for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:28 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b384a03-ce32-11ec-a406-831a346695d4; Sat, 07 May 2022 20:19:28 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id k126-20020a1ca184000000b003943fd07180so6133137wme.3 for ; Sat, 07 May 2022 11:19:28 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b384a03-ce32-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f9eTxQwBpqmyE5YQv8y/mSGc6BFKrmx/9RtbXRM94yk=; b=q0QvHmJEV199SvJxS8MMwMhMnT/+xhVpVqbOLeHgkt06Xhs2dBC0jVTbeKOwr91pvR ndKaasEP0xJG1RLgJyqL7ROM0gZzZQdJc/q0MNhHsXPKClgmJU88UwkBbKhnyLTjrxeH akHWUnH51O7ewtusDhyChb/efNbilF+VAy0f52Ter98LqUPNVkvzci9eD41asZ+qZHI8 cxd6Fw0R6dR9XKl9hBhot2Ml9a+SI7h0b6qTcC3h1dkFbCIGTfD57A7X/PwLBhWUviLJ RMrUlN4pHsO1OCXg4EHqgP/3qgV4jfWL/K1p0l8arjpAUs+e6MkOmajqxI/Xjre5TUMj SXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f9eTxQwBpqmyE5YQv8y/mSGc6BFKrmx/9RtbXRM94yk=; b=LYgk0x+raOODGwiaT56Bckp+VpV5v1BOi1404LdMTQ/ChmyNXG42wSudv1HzGWKID3 la1nsWxioDaBF3M6MbGXVVe+mcmlDfKaJmwKbbRfxwXWDns1aVVnHArVnMG4IQVJ16cs gE+cD371rgL7Kh5IrIHUdWmOsf9y2U/gICyCS+K0d5YqcsxZ4xovUHg/xWIB1KWTut+b faqOzAhFP9sKNigRBTwqrq+VOfPnPVIApQgD5fUs22wVt1C0/YWghNMZiym7+XABdvtE SH+XwUs8Fw1X1MTeMSEiTkVRjNjIhZqAu5jV8jm/kibShwLSQCgYXNwDy/yd6HG+SrXT s1OQ== X-Gm-Message-State: AOAM532XRnqaesVbMTR1nMmglkUxpNn/OCIFE7FQXgVDuyB3rPKo6DZU F0PoxK1ZfTwfR8EOgAJ8ys7lO7iQ/1s= X-Google-Smtp-Source: ABdhPJzhvjQBg6LQrWKFmAkWoYNYrT/dAdUxxfWwxE0Fo8ocoWuRQNu1extz5NXA4crK+Rzl3m2uBw== X-Received: by 2002:a05:600c:4f03:b0:394:6499:21c7 with SMTP id l3-20020a05600c4f0300b00394649921c7mr8976554wmq.103.1651947566943; Sat, 07 May 2022 11:19:26 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Date: Sat, 7 May 2022 21:19:06 +0300 Message-Id: <1651947548-4055-6-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Introduce Xen specific binding for the virtualized device (e.g. virtio) to be used by Xen grant DMA-mapping layer in the subsequent commit. This binding indicates that Xen grant mappings scheme needs to be enabled for the device which DT node contains that property and specifies the ID of Xen domain where the corresponding backend resides. The ID (domid) is used as an argument to the grant mapping APIs. This is needed for the option to restrict memory access using Xen grant mappings to work which primary goal is to enable using virtio devices in Xen guests. Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - update commit subject/description and text in description - move to devicetree/bindings/arm/ Changes V1 -> V2: - update text in description - change the maintainer of the binding - fix validation issue - reference xen,dev-domid.yaml schema from virtio/mmio.yaml --- .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ Documentation/devicetree/bindings/virtio/mmio.yaml | 7 ++++ 2 files changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml new file mode 100644 index 00000000..750e89e --- /dev/null +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xen specific binding for virtualized devices (e.g. virtio) + +maintainers: + - Stefano Stabellini + +select: true + +description: + This binding indicates that Xen grant mappings need to be enabled for + the device, and it specifies the ID of the domain where the corresponding + device (backend) resides. The property is required to restrict memory + access using Xen grant mappings. + +properties: + xen,dev-domid: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + The domid (domain ID) of the domain where the device (backend) is running. + +additionalProperties: true + +examples: + - | + virtio@3000 { + compatible = "virtio,mmio"; + reg = <0x3000 0x100>; + interrupts = <41>; + + /* The device is located in Xen domain with ID 1 */ + xen,dev-domid = <1>; + }; diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml index 10c22b5..29a0932 100644 --- a/Documentation/devicetree/bindings/virtio/mmio.yaml +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml @@ -13,6 +13,9 @@ description: See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for more details. +allOf: + - $ref: /schemas/arm/xen,dev-domid.yaml# + properties: compatible: const: virtio,mmio @@ -33,6 +36,10 @@ properties: description: Required for devices making accesses thru an IOMMU. maxItems: 1 + xen,dev-domid: + description: Required when Xen grant mappings need to be enabled for device. + $ref: /schemas/types.yaml#/definitions/uint32 + required: - compatible - reg -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323756.545585 (Exim 4.92) (envelope-from ) id 1nnP1Z-0006yx-4w; Sat, 07 May 2022 18:19:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323756.545585; Sat, 07 May 2022 18:19:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1Z-0006yq-1S; Sat, 07 May 2022 18:19:25 +0000 Received: by outflank-mailman (input) for mailman id 323756; Sat, 07 May 2022 18:19:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1X-0006Tm-RS for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:24 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38019e83-ce32-11ec-a406-831a346695d4; Sat, 07 May 2022 20:19:22 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id p189so6244075wmp.3 for ; Sat, 07 May 2022 11:19:22 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38019e83-ce32-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OrgzCi2vWreU0D3K+vX8BJWItQ5HoVmyJ6Y4kPIhynE=; b=OUAhv9vXITWVMU9TeHHBFXF+xNxB5VE882DW65aTxQO9VaGcSIkn1h0II2gUa8W+cg oIwLH5eetSj3mlQfVgEc/AWmjip/UKoCGQj8eTrn9uMsIUmcrTiCXaswFFUmP79k2cO+ U8LmQDpnGRWYUo1x2xy1Ne9W1L4r6LEYYwHF0Hl7RHpwtAhFph/ixx9SvqDTDJjEI/et O+F5fnrB+Z/JhzefM4sN3B25lzgA2/A/aGxdRmbwB54vv29wzxEEJPCLpLgtTsKwVeQ3 ZiVdRo8kt+20WXxug38HrZkNGZSPuISLsBBvMU7gHkv81+FWRTzAFw0t+EbSkCNsLzmL RtZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OrgzCi2vWreU0D3K+vX8BJWItQ5HoVmyJ6Y4kPIhynE=; b=Q+WXYwFDsGo3X5TwGwHBJ86wU8xLDpM2aDDzUzeiLypzCWm5jtiBZiJ0y5aUluEBQD GJMgq2EySM94CbYsvCZhdu5u6asKk6mC/dAETKevFPB6Zr1PGdJFTWgaFnMz9YGO3EpW 3pE3Ng0wxDvpb1V81pftzxB0fH5ySzNQ3FvF6963m8GHiXaXxQIf8OHoyCqSjB7hcrc3 qbdVA/c6g/v0l9q/RTwqk45Af/vCuX7GWtukEw4NNMQ6C12i9HRcxZUcPOlQ2XkWrKbW j5+shWQpqzn0XwXBfHdnq0o7sgqSXpp/kFiScfdUcAh2YI0IC3adBylsrnRYU/SP9TbV 8vTQ== X-Gm-Message-State: AOAM531eXIEFl1IYbYGO4Y7zjqEcDB5bnJDSa8IXKOL9ZYIlMqGGN7eR 5g85TKOQhbU0juEEiyXfDDdLCVQXKng= X-Google-Smtp-Source: ABdhPJwbvqsd8GXKWxFUVsXuDTyUOhkUCHUMiidTybWZFxP/+3NjFKIjeYM0vnYNwa7eE5HX0o+fYg== X-Received: by 2002:a7b:c04d:0:b0:394:61ea:4fa2 with SMTP id u13-20020a7bc04d000000b0039461ea4fa2mr8926671wmc.40.1651947561575; Sat, 07 May 2022 11:19:21 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Date: Sat, 7 May 2022 21:19:03 +0300 Message-Id: <1651947548-4055-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Juergen Gross For support of virtio via grant mappings in rare cases larger mappings using consecutive grants are needed. Support those by adding a bitmap of free grants. As consecutive grants will be needed only in very rare cases (e.g. when configuring a virtio device with a multi-page ring), optimize for the normal case of non-consecutive allocations. Signed-off-by: Juergen Gross --- Changes RFC -> V1: - no changes Changes V1 -> V2: - no changes --- drivers/xen/grant-table.c | 238 +++++++++++++++++++++++++++++++++++++++------- include/xen/grant_table.h | 4 + 2 files changed, 210 insertions(+), 32 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 8ccccac..1b458c0 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -33,6 +33,7 @@ #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt +#include #include #include #include @@ -72,9 +73,32 @@ static grant_ref_t **gnttab_list; static unsigned int nr_grant_frames; + +/* + * Handling of free grants: + * + * Free grants are in a simple list anchored in gnttab_free_head. They are + * linked by grant ref, the last element contains GNTTAB_LIST_END. The number + * of free entries is stored in gnttab_free_count. + * Additionally there is a bitmap of free entries anchored in + * gnttab_free_bitmap. This is being used for simplifying allocation of + * multiple consecutive grants, which is needed e.g. for support of virtio. + * gnttab_last_free is used to add free entries of new frames at the end of + * the free list. + * gnttab_free_tail_ptr specifies the variable which references the start + * of consecutive free grants ending with gnttab_last_free. This pointer is + * updated in a rather defensive way, in order to avoid performance hits in + * hot paths. + * All those variables are protected by gnttab_list_lock. + */ static int gnttab_free_count; -static grant_ref_t gnttab_free_head; +static unsigned int gnttab_size; +static grant_ref_t gnttab_free_head = GNTTAB_LIST_END; +static grant_ref_t gnttab_last_free = GNTTAB_LIST_END; +static grant_ref_t *gnttab_free_tail_ptr; +static unsigned long *gnttab_free_bitmap; static DEFINE_SPINLOCK(gnttab_list_lock); + struct grant_frames xen_auto_xlat_grant_frames; static unsigned int xen_gnttab_version; module_param_named(version, xen_gnttab_version, uint, 0); @@ -170,16 +194,111 @@ static int get_free_entries(unsigned count) ref = head = gnttab_free_head; gnttab_free_count -= count; - while (count-- > 1) - head = gnttab_entry(head); + while (count--) { + bitmap_clear(gnttab_free_bitmap, head, 1); + if (gnttab_free_tail_ptr == __gnttab_entry(head)) + gnttab_free_tail_ptr = &gnttab_free_head; + if (count) + head = gnttab_entry(head); + } gnttab_free_head = gnttab_entry(head); gnttab_entry(head) = GNTTAB_LIST_END; + if (!gnttab_free_count) { + gnttab_last_free = GNTTAB_LIST_END; + gnttab_free_tail_ptr = NULL; + } + spin_unlock_irqrestore(&gnttab_list_lock, flags); return ref; } +static int get_seq_entry_count(void) +{ + if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr || + *gnttab_free_tail_ptr == GNTTAB_LIST_END) + return 0; + + return gnttab_last_free - *gnttab_free_tail_ptr + 1; +} + +/* Rebuilds the free grant list and tries to find count consecutive entries. */ +static int get_free_seq(unsigned int count) +{ + int ret = -ENOSPC; + unsigned int from, to; + grant_ref_t *last; + + gnttab_free_tail_ptr = &gnttab_free_head; + last = &gnttab_free_head; + + for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); + from < gnttab_size; + from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { + to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, + from + 1); + if (ret < 0 && to - from >= count) { + ret = from; + bitmap_clear(gnttab_free_bitmap, ret, count); + from += count; + gnttab_free_count -= count; + if (from == to) + continue; + } + + while (from < to) { + *last = from; + last = __gnttab_entry(from); + gnttab_last_free = from; + from++; + } + if (to < gnttab_size) + gnttab_free_tail_ptr = __gnttab_entry(to - 1); + } + + *last = GNTTAB_LIST_END; + if (gnttab_last_free != gnttab_size - 1) + gnttab_free_tail_ptr = NULL; + + return ret; +} + +static int get_free_entries_seq(unsigned int count) +{ + unsigned long flags; + int ret = 0; + + spin_lock_irqsave(&gnttab_list_lock, flags); + + if (gnttab_free_count < count) { + ret = gnttab_expand(count - gnttab_free_count); + if (ret < 0) + goto out; + } + + if (get_seq_entry_count() < count) { + ret = get_free_seq(count); + if (ret >= 0) + goto out; + ret = gnttab_expand(count - get_seq_entry_count()); + if (ret < 0) + goto out; + } + + ret = *gnttab_free_tail_ptr; + *gnttab_free_tail_ptr = gnttab_entry(ret + count - 1); + gnttab_free_count -= count; + if (!gnttab_free_count) + gnttab_free_tail_ptr = NULL; + bitmap_clear(gnttab_free_bitmap, ret, count); + + out: + spin_unlock_irqrestore(&gnttab_list_lock, flags); + + return ret; +} + static void do_free_callbacks(void) { struct gnttab_free_callback *callback, *next; @@ -206,17 +325,48 @@ static inline void check_free_callbacks(void) do_free_callbacks(); } -static void put_free_entry(grant_ref_t ref) +static void put_free_entry_locked(grant_ref_t ref) { - unsigned long flags; - spin_lock_irqsave(&gnttab_list_lock, flags); gnttab_entry(ref) = gnttab_free_head; gnttab_free_head = ref; + if (!gnttab_free_count) + gnttab_last_free = ref; + if (gnttab_free_tail_ptr == &gnttab_free_head) + gnttab_free_tail_ptr = __gnttab_entry(ref); gnttab_free_count++; + bitmap_set(gnttab_free_bitmap, ref, 1); +} + +static void put_free_entry(grant_ref_t ref) +{ + unsigned long flags; + + spin_lock_irqsave(&gnttab_list_lock, flags); + put_free_entry_locked(ref); check_free_callbacks(); spin_unlock_irqrestore(&gnttab_list_lock, flags); } +static void gnttab_set_free(unsigned int start, unsigned int n) +{ + unsigned int i; + + for (i = start; i < start + n - 1; i++) + gnttab_entry(i) = i + 1; + + gnttab_entry(i) = GNTTAB_LIST_END; + if (!gnttab_free_count) { + gnttab_free_head = start; + gnttab_free_tail_ptr = &gnttab_free_head; + } else { + gnttab_entry(gnttab_last_free) = start; + } + gnttab_free_count += n; + gnttab_last_free = i; + + bitmap_set(gnttab_free_bitmap, start, n); +} + /* * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2. * Introducing a valid entry into the grant table: @@ -448,23 +598,31 @@ void gnttab_free_grant_references(grant_ref_t head) { grant_ref_t ref; unsigned long flags; - int count = 1; - if (head == GNTTAB_LIST_END) - return; + spin_lock_irqsave(&gnttab_list_lock, flags); - ref = head; - while (gnttab_entry(ref) != GNTTAB_LIST_END) { - ref = gnttab_entry(ref); - count++; + while (head != GNTTAB_LIST_END) { + ref = gnttab_entry(head); + put_free_entry_locked(head); + head = ref; } - gnttab_entry(ref) = gnttab_free_head; - gnttab_free_head = head; - gnttab_free_count += count; check_free_callbacks(); spin_unlock_irqrestore(&gnttab_list_lock, flags); } EXPORT_SYMBOL_GPL(gnttab_free_grant_references); +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count) +{ + unsigned long flags; + unsigned int i; + + spin_lock_irqsave(&gnttab_list_lock, flags); + for (i = count; i > 0; i--) + put_free_entry_locked(head + i - 1); + check_free_callbacks(); + spin_unlock_irqrestore(&gnttab_list_lock, flags); +} +EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq); + int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) { int h = get_free_entries(count); @@ -478,6 +636,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) } EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references); +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first) +{ + int h; + + if (count == 1) + h = get_free_entries(1); + else + h = get_free_entries_seq(count); + + if (h < 0) + return -ENOSPC; + + *first = h; + + return 0; +} +EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq); + int gnttab_empty_grant_references(const grant_ref_t *private_head) { return (*private_head == GNTTAB_LIST_END); @@ -570,16 +746,13 @@ static int grow_gnttab_list(unsigned int more_frames) goto grow_nomem; } + gnttab_set_free(gnttab_size, extra_entries); - for (i = grefs_per_frame * nr_grant_frames; - i < grefs_per_frame * new_nr_grant_frames - 1; i++) - gnttab_entry(i) = i + 1; - - gnttab_entry(i) = gnttab_free_head; - gnttab_free_head = grefs_per_frame * nr_grant_frames; - gnttab_free_count += extra_entries; + if (!gnttab_free_tail_ptr) + gnttab_free_tail_ptr = __gnttab_entry(gnttab_size); nr_grant_frames = new_nr_grant_frames; + gnttab_size += extra_entries; check_free_callbacks(); @@ -1424,7 +1597,6 @@ int gnttab_init(void) int i; unsigned long max_nr_grant_frames; unsigned int max_nr_glist_frames, nr_glist_frames; - unsigned int nr_init_grefs; int ret; gnttab_request_version(); @@ -1452,6 +1624,13 @@ int gnttab_init(void) } } + i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; + gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); + if (!gnttab_free_bitmap) { + ret = -ENOMEM; + goto ini_nomem; + } + ret = arch_gnttab_init(max_nr_grant_frames, nr_status_frames(max_nr_grant_frames)); if (ret < 0) @@ -1462,15 +1641,9 @@ int gnttab_init(void) goto ini_nomem; } - nr_init_grefs = nr_grant_frames * - gnttab_interface->grefs_per_grant_frame; - - for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) - gnttab_entry(i) = i + 1; + gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame; - gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END; - gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES; - gnttab_free_head = NR_RESERVED_ENTRIES; + gnttab_set_free(NR_RESERVED_ENTRIES, gnttab_size - NR_RESERVED_ENTRIES); printk("Grant table initialized\n"); return 0; @@ -1479,6 +1652,7 @@ int gnttab_init(void) for (i--; i >= 0; i--) free_page((unsigned long)gnttab_list[i]); kfree(gnttab_list); + bitmap_free(gnttab_free_bitmap); return ret; } EXPORT_SYMBOL_GPL(gnttab_init); diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index dfd5bf3..d815e1d 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -129,10 +129,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref); */ int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head); +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first); + void gnttab_free_grant_reference(grant_ref_t ref); void gnttab_free_grant_references(grant_ref_t head); +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count); + int gnttab_empty_grant_references(const grant_ref_t *pprivate_head); int gnttab_claim_grant_reference(grant_ref_t *pprivate_head); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323760.545623 (Exim 4.92) (envelope-from ) id 1nnP1f-0007xV-Rl; Sat, 07 May 2022 18:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323760.545623; Sat, 07 May 2022 18:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1f-0007wN-Jz; Sat, 07 May 2022 18:19:31 +0000 Received: by outflank-mailman (input) for mailman id 323760; Sat, 07 May 2022 18:19:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1e-0006Tm-Ds for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:30 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c2dbbfb-ce32-11ec-a406-831a346695d4; Sat, 07 May 2022 20:19:29 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id l62-20020a1c2541000000b0038e4570af2fso6114904wml.5 for ; Sat, 07 May 2022 11:19:29 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c2dbbfb-ce32-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=i20ZoV0Dy7aIhximSqwDLxqvQZkpduCzRqaqQhDs+Gw=; b=kaeAxv8eQCkCyM/YsKefnviDP9GsVHb7/51955hWaPMeqjaXkbK/uyVclInXeCIUdE X8IXEo2iLyaRQragIBliJUttM3m9nzwxKVQiWuRmtv46zoTAxr+TSDhNPCDeGLBzpq1X 49JcoOjn13VevVWcxYzJrKiK6peJgDk6R4HwUT1NR3m/lvWnFhUk8bsPpDQ1f9I7QBD2 33LCxLFmevZNmxrucdGWpD9GNkaUtqTcfGH95is2ZEuijHlLJi2xWq6+Rv3EOoL7eK2c Wfthv4gIYltKPDkuCDjm9ROaxIFniVwE1HfbHBVyoPo58rw1q35dbgiELmS1saNmOgEZ oWqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=i20ZoV0Dy7aIhximSqwDLxqvQZkpduCzRqaqQhDs+Gw=; b=6UsJxtIx4RWcLGgk0Rxi5/mXcGZXh5dAOfmlikY3nNxDsKXWMFU1VRonSAg7LOlMLF Lye8Dwcs+gqCFgV9o2xjVixbMBUcgwvgae8tj3PfpDU40ylDrhHCf8s/yDksFPg+lzVF 6JDHhYX3SxSJhuU7B08uKuNIXVUi1PlqpjeDvh1prP3Pinsy3LkJdVlmtX/4ERsGePy+ Ya8OXYp8PTvPVSYruuEwnvzgjN9JwHxuJuSwSnE0BJWhrrc7t+fkszRrrEZ3+z0ctDMy 8akuvhpj/hAQrebVURrrnSeg7Jk49r5vBQuvmwYxqDn3akROojP1dq9y1v2CyXjfGqhl ENOA== X-Gm-Message-State: AOAM533cZ2xdVgstuiiytKAtbRfCvlyWraRoWQ4+u3dxptD64x9etNyN i3mthp8LJ8YCobl4ITlUoW307nRQkOg= X-Google-Smtp-Source: ABdhPJwPA0kb7aWDicLsLDhgAaPwApIyoCaRdYZ+eHdlC/fExsCO5IbDdRUI+wRMk84GSOATJZsaLQ== X-Received: by 2002:a7b:cbc2:0:b0:388:faec:2036 with SMTP id n2-20020a7bcbc2000000b00388faec2036mr9020942wmi.190.1651947568572; Sat, 07 May 2022 11:19:28 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 6/7] xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices Date: Sat, 7 May 2022 21:19:07 +0300 Message-Id: <1651947548-4055-7-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Use the presence of recently introduced "xen,dev-domid" property in the device node as a clear indicator of enabling Xen grant mappings scheme for that device and read the ID of Xen domain where the corresponding backend resides. The ID (domid) is used as an argument to the Xen grant mapping APIs. Also introduce xen_is_grant_dma_device() to check whether xen-grant DMA ops need to be set for a passed device. Remove the hardcoded domid 0 in xen_grant_setup_dma_ops(). Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - new patch, split required changes from commit: "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" - update checks in xen_virtio_setup_dma_ops() to only support DT devices for now - remove the "virtio,mmio" check from xen_is_virtio_device() - remane everything according to the new naming scheme: s/virtio/grant_dma Changes V1 -> V2: - remove dev_is_pci() check in xen_grant_setup_dma_ops() - remove EXPORT_SYMBOL_GPL(xen_is_grant_dma_device); --- drivers/xen/grant-dma-ops.c | 24 +++++++++++++++++------- include/xen/xen-ops.h | 5 +++++ 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c index 29ad7bf..8924178 100644 --- a/drivers/xen/grant-dma-ops.c +++ b/drivers/xen/grant-dma-ops.c @@ -55,11 +55,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) * Such a DMA address is formed by using the grant reference as a frame * number and setting the highest address bit (this bit is for the backend * to be able to distinguish it from e.g. a mmio address). - * - * Note that for now we hard wire dom0 to be the backend domain. In order - * to support any domain as backend we'd need to add a way to communicate - * the domid of this backend, e.g. via Xenstore, via the PCI-device's - * config space or DT/ACPI. */ static void *xen_grant_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp, @@ -275,6 +270,15 @@ static const struct dma_map_ops xen_grant_dma_ops = { .dma_supported = xen_grant_dma_supported, }; +bool xen_is_grant_dma_device(struct device *dev) +{ + /* XXX Handle only DT devices for now */ + if (!dev->of_node) + return false; + + return of_property_read_bool(dev->of_node, "xen,dev-domid"); +} + void xen_grant_setup_dma_ops(struct device *dev) { struct xen_grant_dma_data *data; @@ -286,8 +290,14 @@ void xen_grant_setup_dma_ops(struct device *dev) return; } - /* XXX The dom0 is hardcoded as the backend domain for now */ - dev_domid = 0; + /* XXX ACPI device unsupported for now */ + if (!dev->of_node) + goto err; + + if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) { + dev_err(dev, "xen,dev-domid property is not present\n"); + goto err; + } data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data) diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index 4f9fad5..62be9dc 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { } #ifdef CONFIG_XEN_GRANT_DMA_OPS void xen_grant_setup_dma_ops(struct device *dev); +bool xen_is_grant_dma_device(struct device *dev); #else static inline void xen_grant_setup_dma_ops(struct device *dev) { } +static inline bool xen_is_grant_dma_device(struct device *dev) +{ + return false; +} #endif /* CONFIG_XEN_GRANT_DMA_OPS */ #endif /* INCLUDE_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:19:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:19:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323761.545640 (Exim 4.92) (envelope-from ) id 1nnP1i-00004t-9l; Sat, 07 May 2022 18:19:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323761.545640; Sat, 07 May 2022 18:19:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1i-0008WF-4p; Sat, 07 May 2022 18:19:34 +0000 Received: by outflank-mailman (input) for mailman id 323761; Sat, 07 May 2022 18:19:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP1g-00079i-5q for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:19:32 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d24b932-ce32-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 20:19:31 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id n126-20020a1c2784000000b0038e8af3e788so6133525wmn.1 for ; Sat, 07 May 2022 11:19:31 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b10-20020a5d4d8a000000b0020c5253d8f3sm8198457wru.63.2022.05.07.11.19.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 May 2022 11:19:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d24b932-ce32-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JQ4/wPcUQ3XIBwyiOH+85aEeFtvLk17ZXfaTMabSQhQ=; b=M0nL9AqbUiqgoGeBXuGJocL7BzhM9dpf6lZVm6z1MjjHA7Ksx3fAI6nsxT0Nt1TL05 V9n3RuTkUTnoTUTcWzbDZzYyXq+nDqhodBqF5QWBpLz3KG7WkLCJw+dMLaWXpmXERYF1 Z/ciVWktZyebFps/o8q2Oq5Yq41Pu3hxh+stWpNbBkwcaCkgIOQ5WYEwn7lV+jJsEdSh +HhxY/jdkwpoWo5uCgqY6+fdKmpb5rQY+LpZDKBI6NpE+HUIsQOlFS0+S/WN3zq9WuIL TiiJg4uvRYrYvsi0W51dYzG/nuX5J3xAnuGzn1LhIo6s+ydhszeik8BNC8Hg3Kloj1TO zwOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JQ4/wPcUQ3XIBwyiOH+85aEeFtvLk17ZXfaTMabSQhQ=; b=QKuK7H4mHW4Rb2TWgRjgWF1dfvgqErexTsqBgTKml00O+VM8PJiFhefq5+P6EQg6fF +s9m2h4EdQG6KTbhlsE6zeFL0zGD9CWVMjc9/OlfNjD+r1hbRBmwFY15NRfgaMGVo3iX lqYURc6UhBBTkf3auVrEgsuxy/ypz9LfMnuEn/L0UrjRsqnTXpRowDUQqch+Rt3bG6JP IK5psoGYcHXPoEG9Erzn7AwvXjThBdzgnI5H2hzkGucBhYIMVo2ckiUtE6macY+0VcKh t2zVCYm+XRVFHaOz2xJgo/lEer0nTDyfQ0QDRoPrULYj9Mq94buj16fyc1Mul5F/kK7V kpDA== X-Gm-Message-State: AOAM531WipuSW3tgh8U5619w7wi87yaTonjC9r/QwbY60vhjck9PHfg4 OZPcPXDbyOeV7BZmAfgHzwUmWvHJSjg= X-Google-Smtp-Source: ABdhPJx4KKTzPkd6Pb55J8tu0qaETBwCwPrhXqxi1bGV5Mve7UPIQCUHgzJRC6duNfUV/2m203EIIQ== X-Received: by 2002:a1c:3b54:0:b0:394:3910:3c7b with SMTP id i81-20020a1c3b54000000b0039439103c7bmr8718493wma.3.1651947570262; Sat, 07 May 2022 11:19:30 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V2 7/7] arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices Date: Sat, 7 May 2022 21:19:08 +0300 Message-Id: <1651947548-4055-8-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko By assigning xen-grant DMA ops we will restrict memory access for passed device using Xen grant mappings. This is needed for using any virtualized device (e.g. virtio) in Xen guests in a safe manner. Please note, for the virtio devices the XEN_VIRTIO config should be enabled (it forces ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS). Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini --- Changes RFC -> V1: - update commit subject/description - remove #ifdef CONFIG_XEN_VIRTIO - re-organize the check taking into the account that swiotlb and virtio cases are mutually exclusive - update according to the new naming scheme: s/virtio/grant_dma Changes V1 -> V2: - add Stefano's R-b - remove arch_has_restricted_virtio_memory_access() check - update commit description - remove the inclusion of virtio_config.h --- include/xen/arm/xen-ops.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h index 288deb1..b0766a6 100644 --- a/include/xen/arm/xen-ops.h +++ b/include/xen/arm/xen-ops.h @@ -3,11 +3,14 @@ #define _ASM_ARM_XEN_OPS_H #include +#include static inline void xen_setup_dma_ops(struct device *dev) { #ifdef CONFIG_XEN - if (xen_swiotlb_detect()) + if (xen_is_grant_dma_device(dev)) + xen_grant_setup_dma_ops(dev); + else if (xen_swiotlb_detect()) dev->dma_ops = &xen_swiotlb_dma_ops; #endif } -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Sat May 07 18:22:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323774.545651 (Exim 4.92) (envelope-from ) id 1nnP46-0003Vh-PG; Sat, 07 May 2022 18:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323774.545651; Sat, 07 May 2022 18:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP46-0003Va-MD; Sat, 07 May 2022 18:22:02 +0000 Received: by outflank-mailman (input) for mailman id 323774; Sat, 07 May 2022 18:22:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP46-0003VK-2d; Sat, 07 May 2022 18:22:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP45-0004lz-Ub; Sat, 07 May 2022 18:22:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnP45-0001JG-FU; Sat, 07 May 2022 18:22:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnP45-0003Bb-Ez; Sat, 07 May 2022 18:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UjKlg8SoJlMGRGVZ1kBtAXfdid6lgBNqm+/8iCeqFSs=; b=5Ha7o2GMFLlG/O5xujHgNtrJ2H Uv9RU8eTnQgHo8doIoiQ6rpwOFQzZlnwggzooPcarI0xuhy7LPNLR5xuhEyuPA4De2+HsuQxUlIyc DN+A/0TI7aoy+rXJv1xuGWCrMxvnqm+AfKBpAGGG0SKWbnyecKoRFjmBUDlsXYkZkG6c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170204: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b7e0d8978810b534725e94a321736496928f00a5 X-Osstest-Versions-That: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 From: osstest service owner Date: Sat, 07 May 2022 18:22:01 +0000 flight 170204 xen-unstable real [real] flight 170216 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170204/ http://logs.test-lab.xenproject.org/osstest/logs/170216/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 170179 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170179 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170179 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170179 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170179 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170179 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen b7e0d8978810b534725e94a321736496928f00a5 baseline version: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 Last test of basis 170179 2022-05-06 09:53:58 Z 1 days Failing since 170192 2022-05-06 19:39:47 Z 0 days 2 attempts Testing same since 170204 2022-05-07 06:49:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b7e0d8978810b534725e94a321736496928f00a5 Author: Julien Grall Date: Thu May 5 18:51:31 2022 +0100 xen: io: Fix race between sending an I/O and domain shutdown Xen provides hypercalls to shutdown (SCHEDOP_shutdown{,_code}) and resume a domain (XEN_DOMCTL_resumedomain). They can be used for checkpoint where the expectation is the domain should continue as nothing happened afterwards. hvmemul_do_io() and handle_pio() will act differently if the return code of hvm_send_ioreq() (resp. hvmemul_do_pio_buffer()) is X86EMUL_RETRY. In this case, the I/O state will be reset to STATE_IOREQ_NONE (i.e no I/O is pending) and/or the PC will not be advanced. If the shutdown request happens right after the I/O was sent to the IOREQ, then emulation code will end up to re-execute the instruction and therefore forward again the same I/O (at least when reading IO port). This would be problem if the access has a side-effect. A dumb example, is a device implementing a counter which is incremented by one for every access. When running shutdown/resume in a loop, the value read by the OS may not be the old value + 1. Add an extra boolean in the structure hvm_vcpu_io to indicate whether the I/O was suspended. This is then used in place of checking the domain is shutting down in hvmemul_do_io() and handle_pio() as they should act on suspend (i.e. vcpu_start_shutdown_deferral() returns false) rather than shutdown. Signed-off-by: Julien Grall Reviewed-by: Paul Durrant commit ef98495a165030636e43627b3d7351e7b6f66004 Author: Roger Pau Monné Date: Fri May 6 14:53:31 2022 +0200 MAINTAINERS: add myself as reviewer for IOMMU vendor independent code That also covers the PCI bits which I'm interested on. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich commit 944e389daa133dd310d87c4eebacba9f6da76018 Author: Jan Beulich Date: Fri May 6 14:46:52 2022 +0200 bump default SeaBIOS version to 1.16.0 Signed-off-by: Jan Beulich Acked-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat May 07 18:36:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:36:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323808.545665 (Exim 4.92) (envelope-from ) id 1nnPIJ-0005Ix-9W; Sat, 07 May 2022 18:36:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323808.545665; Sat, 07 May 2022 18:36:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPIJ-0005Iq-6I; Sat, 07 May 2022 18:36:43 +0000 Received: by outflank-mailman (input) for mailman id 323808; Sat, 07 May 2022 18:36:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPII-0005Ig-7a; Sat, 07 May 2022 18:36:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPII-00052s-6g; Sat, 07 May 2022 18:36:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPIH-0001ki-P8; Sat, 07 May 2022 18:36:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnPIH-0001oL-Of; Sat, 07 May 2022 18:36:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KMB5iU3rieDxlXp5hIFgOH397yBviKp6GW7atSJHZOI=; b=7JkIGOnMhWH63KkXdDb038rYLf 0+IVfpx3dfoxfU7PS3cMLMJ861851FM21bmUfRtjBfzFPe6NtnZU0/cAArSZPnO2kXwup8tPRLdMt rmpVUnPZCuCDr1TqkWjpgsahFwSwE3/5ImPq8esNELWRzrgp5exUE+8gy6F0T2G6Tbl8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170218: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 18:36:41 +0000 flight 170218 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170218/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 862 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 07 18:52:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 18:52:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323815.545676 (Exim 4.92) (envelope-from ) id 1nnPXS-0007h5-LY; Sat, 07 May 2022 18:52:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323815.545676; Sat, 07 May 2022 18:52:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPXS-0007gy-IY; Sat, 07 May 2022 18:52:22 +0000 Received: by outflank-mailman (input) for mailman id 323815; Sat, 07 May 2022 18:52:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnPXR-0007gs-46 for xen-devel@lists.xenproject.org; Sat, 07 May 2022 18:52:21 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1cfae4c-ce36-11ec-8fc4-03012f2f19d4; Sat, 07 May 2022 20:52:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4C086143F; Sat, 7 May 2022 18:52:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6E04C385A5; Sat, 7 May 2022 18:52:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1cfae4c-ce36-11ec-8fc4-03012f2f19d4 Date: Sat, 7 May 2022 19:52:11 +0100 From: Catalin Marinas To: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Will Deacon , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V2 1/7] arm/xen: Introduce xen_setup_dma_ops() Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-2-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651947548-4055-2-git-send-email-olekstysh@gmail.com> On Sat, May 07, 2022 at 09:19:02PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch introduces new helper and places it in new header. > The helper's purpose is to assign any Xen specific DMA ops in > a single place. For now, we deal with xen-swiotlb DMA ops only. > The one of the subsequent commits in current series will add > xen-grant DMA ops case. > > Also re-use the xen_swiotlb_detect() check on Arm32. > > Signed-off-by: Oleksandr Tyshchenko > Reviewed-by: Stefano Stabellini For arm64: Acked-by: Catalin Marinas From xen-devel-bounces@lists.xenproject.org Sat May 07 20:21:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 20:21:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323826.545693 (Exim 4.92) (envelope-from ) id 1nnQvQ-0008Ie-4W; Sat, 07 May 2022 20:21:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323826.545693; Sat, 07 May 2022 20:21:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnQvQ-0008IX-1m; Sat, 07 May 2022 20:21:12 +0000 Received: by outflank-mailman (input) for mailman id 323826; Sat, 07 May 2022 20:21:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnQvP-0008IN-Ev; Sat, 07 May 2022 20:21:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnQvP-0006s5-CN; Sat, 07 May 2022 20:21:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnQvP-0005bB-2Q; Sat, 07 May 2022 20:21:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnQvP-0004Ld-20; Sat, 07 May 2022 20:21:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gVDEUcgliDsQt4V2mRMC4sXhfpgKQShdZM/tokA/A68=; b=yG0IoqgZjTKBxbL1YOBOH8vSl4 KoL2hVqBgDWmq/6Cbxm2kfqZZRuu9VE0mSmIQ48LUqdE8Bt4JmsEOtW2Wx/Xz4BfQQDxCmEPibqo2 7itIhBzGtwLUQg2P1Wt57zGaLsvSM9JvYjYztIhpqvv+dfb/zkXlsNMvuL7ZDtnu0ICk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170212: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=11314643c35401b18c5374f4ec82ee7d3d5d2692 X-Osstest-Versions-That: qemuu=13220a46e27ef95159651acd5e408b6aac9dbf3e From: osstest service owner Date: Sat, 07 May 2022 20:21:11 +0000 flight 170212 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170212/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170199 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170199 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170199 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170199 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170199 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170199 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170199 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170199 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170199 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 11314643c35401b18c5374f4ec82ee7d3d5d2692 baseline version: qemuu 13220a46e27ef95159651acd5e408b6aac9dbf3e Last test of basis 170199 2022-05-07 03:07:05 Z 0 days Testing same since 170212 2022-05-07 13:08:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Max Filippov Richard Henderson Simon Safar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 13220a46e2..11314643c3 11314643c35401b18c5374f4ec82ee7d3d5d2692 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 07 21:31:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 07 May 2022 21:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323836.545710 (Exim 4.92) (envelope-from ) id 1nnS15-00071p-FF; Sat, 07 May 2022 21:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323836.545710; Sat, 07 May 2022 21:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnS15-00071i-B9; Sat, 07 May 2022 21:31:07 +0000 Received: by outflank-mailman (input) for mailman id 323836; Sat, 07 May 2022 21:31:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnS14-00071Y-3j; Sat, 07 May 2022 21:31:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnS14-000857-2o; Sat, 07 May 2022 21:31:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnS13-0001OJ-Ol; Sat, 07 May 2022 21:31:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnS13-0007yu-OF; Sat, 07 May 2022 21:31:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EN1YrqCwk7KalhAO5sqVqNIlRrzd4TPBbbhfdEJYzRE=; b=gMzRnZl5mjuVtmumkAnnuQpBRj ssPQC8MePoZC+jhTzLlry8XZzhB2Vgj8SVaTb445iEO7o4x2sExFvPyimjwsHjHtJ8v1g6THTWwJR eXJWbIe18SfMpFSefNv8eIwQ8D/qGry+ZdYYV9VkcOUZQBZ2WwCDLI9aT5BP+NGFVzp8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170222: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 07 May 2022 21:31:05 +0000 flight 170222 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170222/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 863 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 00:40:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 00:40:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323846.545727 (Exim 4.92) (envelope-from ) id 1nnUy1-0000ci-JO; Sun, 08 May 2022 00:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323846.545727; Sun, 08 May 2022 00:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnUy1-0000cb-G3; Sun, 08 May 2022 00:40:09 +0000 Received: by outflank-mailman (input) for mailman id 323846; Sun, 08 May 2022 00:40:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnUy0-0000cR-1n; Sun, 08 May 2022 00:40:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnUxz-0003TQ-WF; Sun, 08 May 2022 00:40:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnUxz-00053d-KJ; Sun, 08 May 2022 00:40:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnUxz-0001YR-Js; Sun, 08 May 2022 00:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ucMCWDaHQKCKlSnBDO2OROtNvx/dbBZZlgWL+oa3B90=; b=1yb8EUSfMQxyThCYgdf3gj2eOT JI9zurpode35+XdAHPb03KHiifVlUJjVO/Wq42da+WM/sa1CwK1rBh+Dn6ENce4Qgb6ho906J8oIJ dVwSIJqJMPZnOtoph2OulcpipgcrclvwPVDW5A9u6BwpUhmlno/+QxzNSYAYj/darPN8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170226: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 00:40:07 +0000 flight 170226 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 67 days 864 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 03:14:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 03:14:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323857.545747 (Exim 4.92) (envelope-from ) id 1nnXN9-0005PL-O4; Sun, 08 May 2022 03:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323857.545747; Sun, 08 May 2022 03:14:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnXN9-0005PD-Ix; Sun, 08 May 2022 03:14:15 +0000 Received: by outflank-mailman (input) for mailman id 323857; Sun, 08 May 2022 03:14:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnXN8-0005P7-EK for xen-devel@lists.xenproject.org; Sun, 08 May 2022 03:14:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0620.outbound.protection.outlook.com [2a01:111:f400:fe0c::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecf9fc5b-ce7c-11ec-8fc4-03012f2f19d4; Sun, 08 May 2022 05:14:09 +0200 (CEST) Received: from AS9PR05CA0044.eurprd05.prod.outlook.com (2603:10a6:20b:489::34) by DB6PR0802MB2565.eurprd08.prod.outlook.com (2603:10a6:4:a1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Sun, 8 May 2022 03:14:05 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::77) by AS9PR05CA0044.outlook.office365.com (2603:10a6:20b:489::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Sun, 8 May 2022 03:14:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Sun, 8 May 2022 03:14:05 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Sun, 08 May 2022 03:14:04 +0000 Received: from e0797aeb21f5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 84E6AC0C-E63D-4A2E-8C00-167B8754F84E.1; Sun, 08 May 2022 03:13:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e0797aeb21f5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 08 May 2022 03:13:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB5286.eurprd08.prod.outlook.com (2603:10a6:20b:aa::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.25; Sun, 8 May 2022 03:13:51 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5227.018; Sun, 8 May 2022 03:13:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecf9fc5b-ce7c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GBVnmS/90LOPq7ZEXRb7/aUXpCRlPW5X2R/qSyQzVWcrZ+vPtc8eB7TR1LZk35glpyV39uas08rFRqS6JRf5LEhVnkboMg4Kg/39iN/45hOSyKP4+LeKAYAzFtzTKN6MDuFlYTCA2JxxD46M4G6zXJn2PSYxvyT+R9PTTabER/jq+Jas18x4fCgVoH663qco2IEiZfLt0vh5BbU9YTH2UK7/lPM6na7MxEvctIdBH+3+eb4am81HmWpDQKE0PkScr4z9jBtxPzCikndifg/UHbYWG+zOh5J7rH4IFmZ44Yca5RwL3Gh9ChbDPp0xcPD554Dakn06kfxBk0PXC122Wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYyamzAjjg8kElrjSX/zthgqFQnzQRvH1by5BqKiDWE=; b=gZ3MD2p8IR4/HqVU5vtkzDhHwZ00TWGmNqKrMzRytNlO9LOBfpH7plzW4HiXRjWAx6nuRqW5J/wC5T5ytm1QXd0bNfPw3copMI11GPBvgDkT+1ceygVb7OMrjEt0WyRAL8s+KOTaAZWbc6pg9DkXn/Ej+av7J0HoGmNSDAR5Lbn1kcOI/0YYvsIEOQIEs30lmnzUQOlxuHCRMn+DK9CY6odqW1II3WvrlvmjFZo6OMXD4ll0aR2onqMQJFoyuUkqxDRWQCuR+BVsok//xUYAT43kfggLGogZc6oRCgRcboaJObA9wevrhQTiQV1I0tdz0/DmTVZL7B4UbV8jg8pLFw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYyamzAjjg8kElrjSX/zthgqFQnzQRvH1by5BqKiDWE=; b=lKJS/2/ThttQ5ixZxnXXQZFi6U0IqhsIVrva0PYiptM4pxfkBoMXMAr0ZhJOWpXvSoxAocY9i81RP3pTjZZ5cn1WZjPBrP7WVQLL042MfiP5i/PrK8dIw2ItrR0GDsqRpZcZ3sVcIEyF3Z/9VcaPd0lV9FZ4sB9cVK9qeQ5kgbU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+RmFIBsJMDnnZ4/ctK02bISdoWH4ykbHqURuvkVE0JPkIHQG61NvtaEdoyhxt3XJlo8TWVnRUYuD8rjm5sU6QG9F3TRvwvBt04rcrTr0AOdzKlWAXOcf2W2McQElURvlHZVgASKvp/xXrGaiOGxTfGb/lJbQMcVcBK1tMNpg1rqjHvr02SBVofdxUzMwulrcH2/bxmVsogSHSir/yuO2rEeTuncX/YqJqweQIWg1d6C0BFDUjiGkO3yarwF9Jzy4Oo71wwsqtbQZMM4XKjyGTWKlSHLqTrZvm+Dxn4an18YwmSx+AkCvCpHr0Hect6EsdsDPHjVCreu6FVowt1hXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tYyamzAjjg8kElrjSX/zthgqFQnzQRvH1by5BqKiDWE=; b=e0oyi1CmIBU58kQEsN5omcHbcHy0hnFaJjff6POAqc0ZusS4L0bC/2lu3enJcQliWlFNaGK3rTp4vd+QXKFzlYOqtdVXbmLGStM05mF3l+wEPul9N+nH7GZatltbAdsKLjHg8DEt3sZny7JMr7Hg4dCmkNTPFX61N99EFpqETUUoUcVzIEn50toEjsG441weK3QQ0xaSgFv6MXZtxSR5x4gsGGwNf7wc/HtWkhP7d8qGqsrpzzUUKOOBI2vSbE/smLM45EmV03s6GLBjeA3KF8VvC5Ip5iGLQMxegtdaBzThFa1QXY4UpTVpk/oWQ074jMxXYXJmUHCTgSHim/U8CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tYyamzAjjg8kElrjSX/zthgqFQnzQRvH1by5BqKiDWE=; b=lKJS/2/ThttQ5ixZxnXXQZFi6U0IqhsIVrva0PYiptM4pxfkBoMXMAr0ZhJOWpXvSoxAocY9i81RP3pTjZZ5cn1WZjPBrP7WVQLL042MfiP5i/PrK8dIw2ItrR0GDsqRpZcZ3sVcIEyF3Z/9VcaPd0lV9FZ4sB9cVK9qeQ5kgbU= From: Wei Chen To: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Stefano Stabellini CC: Bertrand Marquis , Penny Zheng Subject: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1) Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1) Thread-Index: AdhiiZ/pFQ8D6hDLSDWFvMIljUxbzQ== Date: Sun, 8 May 2022 03:13:50 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1C29708CE76EC841B3AF97F6355EFF17.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 46059300-1f0b-4eaa-8b0f-08da30a0cf02 x-ms-traffictypediagnostic: AM6PR08MB5286:EE_|AM5EUR03FT009:EE_|DB6PR0802MB2565:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +rLZxwyj4TmjS5lhQ40GGnA8Fn85KqDgzGj8flOLH76EafRUlB8YrO15ruiIkVlrCkxEhzTDR9FPiF4EZMl2enem5XTcE3xXKWeM+ARTIuBaKYXz/LoqtZ2pOjPyWN1nVAUpl7UaetbiVzFp6UFB/XFS6VaO7nsVe2V73qjBPTfQIPofWzq5mr15TUoA8p1Nday/XEiDO8nt2uSLDVl9ZH07WnJzBjwE4QkkjGV/wxWnRxUlfaeTsG0zIX/1rgGHd7U2H6EBZQeVTf6ZybMwTN63UqKNOvXjGvUaHLflT09QXuAAlXmC3aIiO5t6KJy04CMdYWNXDnc1gG1cXvv7LgUAmZzTpBn0DaA4fLNtFbdE/Bsi6yZg+BhWiAqpTcY8+qBhSN9P5LcGX2YrdCmVM9Qo3hLXADkIfMEvJK0t+uUCU0veapVpeqSxn413tTpeFTWITzD2ztuqaM3i1GtNw4C/+G6GCO36iKZxzs+2UA4Q58dnfFA8VVJS03gJSo07h+erHIDT6WXVZquq9Eqla9SF+JBd4H6G0DUVvhfbTl8oJkLblS4Lz6Zhr0iBmp2JSgk7+KpGLuoF9pegYTpq1KpopzpeytLDvDHLSqCEVmz+cavyqaWgTdOzLYk0TH7gLPi12TVNxhfkqX9/Wb1P5u3wcon9+bkv92us0v+TT2UoCHdSDbeYffKNcozUyrgiBCaCVcDL2IGdh/z66iOwg2Y50F/VoohlSL1LxqYvZhWFp9TEcoZSSMr8AKmGuwfgnhIVAdiuUYgytfODQVxD8tpcEx3j0p9fhHEV80JtMC3iMN4btQCucc4VuM5nZYY7W4ew0QA/owfgcrYPRy2WqJldfhyE6EBkaNj9K3oBjm4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(33656002)(5660300002)(30864003)(64756008)(6506007)(55016003)(71200400001)(7696005)(66476007)(8676002)(52536014)(26005)(9686003)(83380400001)(66446008)(54906003)(2906002)(186003)(66946007)(122000001)(110136005)(66556008)(4326008)(38100700002)(38070700005)(76116006)(316002)(86362001)(508600001)(21314003)(579004)(559001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5286 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53829009-87a4-4486-e168-08da30a0c66f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PsBaus80GEQG8at5uZuAA01A/YQPQ6/I0IaVt1zq1yn5LuCvxtNO1OKruqEy9sYuEROcSmB/1AIXJNsqKg5BktY6ADmXOprxVWLHm173Qx7rTaNGweb+T7QXAbqWleBIbGYx6CQVH927SLDIhpIBSlLAV9IGPRijCSOIZ2/Dp5Aish2Gf+D7PJAttSgkmZMFzZCpsa64yU6d02buy4qUCdhuIa2i2JQ5ktg4HqWwmbO33NAVvi/04ZPjH/2bntBnWNVilhwQkhxIWqpqJwf/z9cuUHI6GbEMl0dypAm/6B4ZqLDOEXkKCy1mZDi24Ef1ofR8fYMDAHQhObRfPoXINMkUSbG4rND9oX1v2tIssXsBAacFevgxj+1BnaZRtigWbS7fADRMpAiRiykBexjvlu3vOi8wgyw7IUQdT2HIhvaqQSYWTfOf5aeN+kJBbqBCaztDcga9ccqaUyTcY5LsPtjZR+99IlYlsvK8qx5z0uK0I0zFdWniewwIGqBMHL3zWX1DPddfwgkbO4MnJtoe6788mAyqdaTGNKe0s9ItvM3l0YSWSiUbiFbRuC71iQ1LM4v9Tw3TVoUKIX43QCrpMWX6QPiBrj/LPjkq3WSlys8f9/w5o9jovCmDPMh+FyDHHG+Jj3a40iaeFu13wa8GATSlmMyDGbByg3lrjaxpvoQKEO/tLrHcca0MtM1yOiu59ki7pCYWKbwUElSS7QcQ0WO1q8RUqbQGh1iv9iJnN0xlyEhhWXg/thPhTahRK1T8NirvCRFNt8utojhslp/rItH5y3m/BgY40aTyavaHBRc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(8676002)(70206006)(70586007)(2906002)(110136005)(55016003)(5660300002)(7696005)(30864003)(9686003)(33656002)(4326008)(52536014)(8936002)(26005)(356005)(36860700001)(83380400001)(508600001)(6506007)(54906003)(86362001)(316002)(336012)(82310400005)(47076005)(81166007)(186003)(21314003)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2022 03:14:05.1516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46059300-1f0b-4eaa-8b0f-08da30a0cf02 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2565 # Proposal for Porting Xen to Armv8-R64 (Update to Draft-C as a discussion archive for Day1 patches) This proposal will introduce the PoC work of porting Xen to Armv8-R64, which includes: - The changes of current Xen capability, like Xen build system, memory management, domain management, vCPU context switch. - The expanded Xen capability, like static-allocation and direct-map. ***Notes:*** 1. ***This proposal only covers the work of porting Xen to Armv8-R64*** ***single CPU.Xen SMP support on Armv8-R64 relates to Armv8-R*** ***Trusted-Frimware (TF-R). This is an external dependency,*** ***so we think the discussion of Xen SMP support on Armv8-R64*** ***should be started when single-CPU support is complete.*** 2. ***This proposal will not touch xen-tools. In current stange,*** ***Xen on Armv8-R64 only support dom0less, all guests should*** ***be booted from device tree.*** ## Changelogs Draft-B -> Draft-C: 1. Update the event-channel support section to use runtime MPU mapping instead of whole MPU context switch. 2. Split two stages for Armv8-R64 Xen start address solution. 3. Remove "malicious tools". 4. Remove GCC version bump. Draft-A -> Draft-B: 1. Update Kconfig options usage. 2. Update the section for XEN_START_ADDRESS. 3. Add description of MPU initialization before parsing device tree. 4. Remove CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS. 5. Update the description of ioremap_nocache/cache. 6. Update about the free_init_memory on Armv8-R. 7. Describe why we need to switch the MPU configuration later. 8. Add alternative proposal in TODO. 9. Add use tool to generate Xen Armv8-R device tree in TODO. 10. Add Xen PIC/PIE discussion in TODO. 11. Add Xen event channel support in TODO. ## Contributors: Wei Chen Penny Zheng ## 1. Essential Background ### 1.1. Armv8-R64 Profile The Armv-R architecture profile was designed to support use cases that have a high sensitivity to deterministic execution. (e.g. Fuel Injection, Brake control, Drive trains, Motor control etc) Arm announced Armv8-R in 2013, it is the latest generation Arm architecture targeted at the Real-time profile. It introduces virtualization at the high= est security level while retaining the Protected Memory System Architecture (PM= SA) based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82, which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. - The latest Armv8-R64 document can be found here: [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch6= 4 architecture profile](https://developer.arm.com/documentation/ddi0600/lat= est/). - Armv-R Architecture progression: Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64 The following figure is a simple comparison of "R" processors based on different Armv-R Architectures. ![image](https://drive.google.com/uc?export=3Dview&id=3D1nE5RAXaX8zY2KPZ8= imBpbvIr2eqBguEB) - The Armv8-R architecture evolved additional features on top of Armv7-R: - An exception model that is compatible with the Armv8-A model - Virtualization with support for guest operating systems - PMSA virtualization using MPUs In EL2. - The new features of Armv8-R64 architecture - Adds support for the 64-bit A64 instruction set, previously Armv8-R only supported A32. - Supports up to 48-bit physical addressing, previously up to 32-bit addressing was supported. - Optional Arm Neon technology and Advanced SIMD - Supports three Exception Levels (ELs) - Secure EL2 - The Highest Privilege, MPU only, for firmware, hyper= visor - Secure EL1 - RichOS (MMU) or RTOS (MPU) - Secure EL0 - Application Workloads - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0= . This means it's possible to run rich OS kernels - like Linux - either bare-metal or as a guest. - Differences with the Armv8-A AArch64 architecture - Supports only a single Security state - Secure. There is not Non-Secu= re execution state supported. - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the highest EL. - Supports the A64 ISA instruction - With a small set of well-defined differences - Provides a PMSA (Protected Memory System Architecture) based virtualization model. - As opposed to Armv8-A AArch64's VMSA based Virtualization - Can support address bits up to 52 if FEAT_LPA is enabled, otherwise 48 bits. - Determines the access permissions and memory attributes of the target PA. - Can implement PMSAv8-64 at EL1 and EL2 - Address translation flat-maps the VA to the PA for EL2 Stage = 1. - Address translation flat-maps the VA to the PA for EL1 Stage = 1. - Address translation flat-maps the IPA to the PA for EL1 Stage= 2. - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable. ### 1.2. Xen Challenges with PMSA Virtualization Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run with an MPU and host multiple guest OSes. - No MMU at EL2: - No EL2 Stage 1 address translation - Xen provides fixed ARM64 virtual memory layout as basis of EL2 stage 1 address translation, which is not applicable on MPU syste= m, where there is no virtual addressing. As a result, any operation involving transition from PA to VA, like ioremap, needs modificat= ion on MPU system. - Xen's run-time addresses are the same as the link time addresses. - Enable PIC/PIE (position-independent code) on a real-time target processor probably very rare. Further discussion in 2.1 and TODO sections. - Xen will need to use the EL2 MPU memory region descriptors to manage access permissions and attributes for accesses made by VMs at EL1/0. - Xen currently relies on MMU EL1 stage 2 table to manage these accesses. - No MMU Stage 2 translation at EL1: - A guest doesn't have an independent guest physical address space - A guest can not reuse the current Intermediate Physical Address memory layout - A guest uses physical addresses to access memory and devices - The MPU at EL2 manages EL1 stage 2 access permissions and attributes - There are a limited number of MPU protection regions at both EL2 and EL1: - Architecturally, the maximum number of protection regions is 256, typical implementations have 32. - By contrast, Xen does not need to consider the number of page table entries in theory when using MMU. - The MPU protection regions at EL2 need to be shared between the hyperviso= r and the guest stage 2. - Requires careful consideration - may impact feature 'fullness' of bot= h the hypervisor and the guest - By contrast, when using MMU, Xen has standalone P2M table for guest stage 2 accesses. ## 2. Proposed changes of Xen ### **2.1. Changes of build system:** - ***Introduce new Kconfig options for Armv8-R64***: Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not expect one Xen binary to run on all machines. Xen images are not common across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64 platforms. Because these platforms may have different memory layout and link address. - `ARM64_V8R`: This option enables Armv8-R profile for Arm64. Enabling this option results in selecting MPU. This Kconfig option is used to gate some Armv8-R64 specific code except MPU code, like some code for Armv8-R64 only system ID registers access. - `ARM_MPU` This option enables MPU on Armv8-R architecture. Enabling this option results in disabling MMU. This Kconfig option is used to gate some ARM_MPU specific code. Once when this Kconfig option has been enabled= , the MMU relate code will not be built for Armv8-R64. The reason why not depends on runtime detection to select MMU or MPU is that, we don= 't think we can use one image for both Armv8-R64 and Armv8-A64. Another reason that we separate MPU and V8R in provision to allow to support = MPU on 32bit Arm one day. ***Try to use `if ( IS_ENABLED(CONFIG_ARMXXXX) )` instead of spreading*** ***`#ifdef CONFIG_ARMXXXX` everywhere, if it is possible.*** - ***About Xen start address for Armv8-R64***: On Armv8-A, Xen has a fixed virtual start address (link address too) on a= ll Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. On Armv8-A platforms, the Xen start addres= s does not need to be configurable. But on Armv8-R platforms, they don't ha= ve MMU to map loaded address to a fixed virtual address. And different platf= orms will have very different address space layout, so it's impossible for Xen= to specify a fixed physical address for all Armv8-R platforms' start address= . - Stage 1, introduce `XEN_START_ADDRESS` This option allows to set the custom address at which Xen will be linked. This address must be aligned to a page size. Xen's run-time addresses are the same as the link time addresses. ***Notes: Fixed link address means the Xen binary could not be*** ***relocated by EFI loader. So in current stage, Xen could not*** ***be launched as an EFI application on Armv8-R64.(TODO#3.3)*** - Provided by platform files. We can reuse the existed arm/platforms store platform specific files. And `XEN_START_ADDRESS` is one kind of platform specific information. So we can use platform file to define default `XEN_START_ADDRESS` for each platform. - Provided by Kconfig. This option can be a supplymental option. Users can define a customiz= ed `XEN_START_ADDRESS` to override the default value in platform's file. - Stage 2, generated `XEN_START_ADDRESS` from device tree by build script= s Vendors who want to enable Xen on their Armv8-R platforms, they can use some tools/scripts to parse their boards device tree to generate the basic platform information, like `XEN_START_ADDRESS`. These tools/scripts do not necessarily need to be integrated in Xen, but Xe= n can give some recommended configuration. For example, Xen can recomme= nd Armv8-R platforms to use lowest ram start address + 2MB as the defaul= t Xen start address. The generated platform files can be placed to arm/platforms for maintenance. - ***About MPU initialization before parsing device tree***: Before Xen can start parsing information from device tree and use this information to setup MPU, Xen need an initial MPU state. This is because: 1. More deterministic: Arm MPU supports background regions, if we don't configure the MPU regions and don't enable MPU. The default MPU background attributes will take effect. The default background attributes are `IMPLEMENTATION DEFINED`. That means all RAM region= s may be configured to device memory and RWX. Random values in RAM o= r maliciously embedded data can be exploited. 2. More compatible: On some Armv8-R64 platforms, if MPU is disabled, the `dc zva` instruction will make the system halt (This is one side effect of MPU background attributes, the RAM has been configu= red as device memory). And this instruction will be embedded in some built-in functions, like `memory set`. If we use `-ddont_use_dc` t= o rebuild GCC, the built-in functions will not contain `dc zva`. However, it is obviously unlikely that we will be able to recompil= e all GCC for ARMv8-R64. - Stage 1, reuse `XEN_START_ADDRESS` In the very beginning of Xen boot, Xen just need to cover a limited memory range and very few devices (actually only UART device). So we can use two MPU regions to map: 1. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_size`as normal memory. 2. `UART` MMIO region base to `UART` MMIO region end to device memory= . These two are enough to support Xen run in boot time. And we don't ne= ed to provide additional platform information for initial normal memory and device memory regions. In current PoC we have used this option for implementation, and it's the same as Armv8-A. - Stage 2, generate information for initial MPU state from device tree Introduce some macros to allow users to set initial normal memory regions: `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END` and device memory: `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END` These macros are the same platform specific information as `XEN_START_ADDRESS`, so the script of generating `XEN_START_ADDRESS` also can be applied to these macros. - ***Define new system registers for compiliers***: Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4 specific system registers. As Armv8-R64 only have secure state, so at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the first GCC version that supports Armv8.4 is GCC 8.1. In addition to these, PMSA of Armv8-R64 introduced lots of MPU related system registers: `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and `MPUIR_ELx`. But the first GCC version to support these system registers is GCC 11. We don't want to bump GCC version to 11 in the first stage, it will affect some makefile scripts of common and other architectures. Instead, we will: - Encode new system registers in macros ``` /* Virtualization Secure Translation Control Register */ #define VSTCR_EL2 S3_4_C2_C6_2 /* Virtualization System Control Register */ #define VSCTLR_EL2 S3_4_C2_C0_0 /* EL1 MPU Protection Region Base Address Register encode */ #define PRBAR_EL1 S3_0_C6_C8_0 ... /* EL2 MPU Protection Region Base Address Register encode */ #define PRBAR_EL2 S3_4_C6_C8_0 ... ``` If we encode all above system registers, we don't need to bump GCC version. And the common CFLAGS Xen is using still can be applied to Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS. ***Notes:*** ***Armv8-R AArch64 supports the A64 ISA instruction set with*** ***some modifications:*** ***Redefines DMB, DSB, and adds an DFB. But actually, the*** ***encodings of DMB and DSB are still the same with A64.*** ***And DFB is an alias of DSB #12. In this case, we think*** ***we don't need a new architecture specific flag to*** ***generate new instructions for Armv8-R.*** ### **2.2. Changes of the initialization process** In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent initialization process. In addition to some architecutre differences, there is no more than reusable code that we will distinguish through CONFIG_ARM_M= PU or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable between Armv8-R64 and Armv8-A64. - We will reuse the original head.s and setup.c of Arm. But replace the MMU and page table operations in these files with configuration operation= s for MPU and MPU regions. - We provide a boot-time MPU configuration. This MPU configuration will support Xen to finish its initialization. And this boot-time MPU configuration will record the memory regions that will be parsed from device tree. In the end of Xen initialization, we will use a runtime MPU configuration to replace boot-time MPU configuration. The runtime MPU configuration wil= l merge and reorder memory regions to save more MPU regions for guests. ![img](https://drive.google.com/uc?export=3Dview&id=3D1wTFyK2XfU3lTlH1PqR= DoacQVTwUtWIGU) - Defer system unpausing domain after free_init_memory. When Xen initialization is about to end, Xen unpauses guests created during initialization. But this will cause some issues. The unpause action occurs before free_init_memory, however the runtime MPU configuration is built after free_init_memory. In Draft-A, we had discussed whether a zeroing operation for init code and data is enough or not. Because I had just given a security reason for doing free_init_memory on Armv8-R (free_init_memory will drop the Xen init code & data, this will reduce the code an attacker can exploit). But I forgot other very important reasons: 1. Init code and data will occupy two MPU regions, because they have different memory attributes. 2. It's not easy to zero init code section, because it's readonly. We have to update its MPU region to make this section RW. This operation doesn't do much less than free_init_memory. 3. Zeroing init code and data will not release the two MPU regions they are using. This would be a very big waste of a limited MPU regions resource. 4. Current free_init_memory operation is reusing lots of Armv8-A codes, except re-add init memory to Xen heap. Because we're using static heap on Armv8-R. So if the unpaused guests start executing the context switch at this point, then its MPU context will base on the boot-time MPU configuration. Probably it will be inconsistent with runtime MPU configuration, this will cause unexpected problems (This may not happen in a single core system, but on SMP systems, this problem is foreseeable, so we hope to solve it at the beginning). Why we need to switch the MPU configuration that late? Because we need to re-order the MPU regions to reduce complexity of runti= me MPU regions management. 1. In the boot stage, we allocate MPU regions in sequence until the max. Since a few MPU regions will get removed along the way, they will leav= e holes there. For example, when heap is ready, fdt will be reallocated in the heap, which means the MPU region for device tree is never neede= d. And also in free_init_memory, although we do not add init memory to he= ap, we still reclaim the MPU regions they are using. Without ordering, we may need a bitmap to record such information. In context switch, the memory layout is quite different for guest mode and hypervisor mode. When switching to guest mode, only guest RAM, emulated/passthrough devices, etc could be seen, but in hypervisor mod= e, all Xen used devices and guests RAM shall be seen. And without reorder= ing, we need to iterate all MPU regions to find according regions to disabl= e during runtime context switch, that's definitely a overhead. So we propose an ordering at the tail of the boot time, to put all fix= ed MPU regions in the head, like xen text/data, etc, and put all flexible ones at tail, like device memory, guests RAM. Then later in runtime, like context switch, we could easily just disab= le ones from tail and inserts new ones in the tail. ### **2.3. Changes to reduce memory fragmentation** In general, memory in Xen system can be classified to 4 classes: `image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel= , initrd and dtb)` Currently, Xen doesn't have any restriction for users how to allocate memory for different classes. That means users can place boot modules anywhere, can reserve Xen heap memory anywhere and can allocate guest memory anywhere. In a VMSA system, this would not be too much of a problem, since the MMU can manage memory at a granularity of 4KB after all. But in a PMSA system, this will be a big problem. On Armv8-R64, the max MPU protection regions number has been limited to 256. But in typical processor implementations, few processors will design more than 32 MPU protection regions. Add in the fact that Xen shares MPU protection regions with guest's EL1 Stage 2. It becomes even more important to properly plan the use of MPU protection regions. - An ideal of memory usage layout restriction: ![img](https://drive.google.com/uc?export=3Dview&id=3D1kirOL0Tx2aAypTtd3kXA= td75XtrngcnW) 1. Reserve proper MPU regions for Xen image (code, rodata and data + bss). 2. Reserve one MPU region for boot modules. That means the placement of all boot modules, include guest kernel, initrd and dtb, will be limited to this MPU region protected area. 3. Reserve one or more MPU regions for Xen heap. On Armv8-R64, the guest memory is predefined in device tree, it will not be allocated from heap. Unlike Armv8-A64, we will not move all free memory to heap. We want Xen heap is deterministic too, so Xen on Armv8-R64 also rely on Xen static heap feature. The memory for Xen heap will be defined in tree too. Considering that physical memory can also be discontinuous, one or more MPU protection regions needs to be reserved for Xen HEAP. 4. If we name above used MPU protection regions PART_A, and name left MPU protection regions PART_B: 4.1. In hypervisor context, Xen will map left RAM and devices to PART_B. This will give Xen the ability to access whole memory. 4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B. In this case, Xen just need to update PART_B in context switch, but keep PART_A as fixed. ***Notes: Static allocation will be mandatory on MPU based systems*** **A sample device tree of memory layout restriction**: ``` chosen { ... /* * Define a section to place boot modules, * all boot modules must be placed in this section. */ mpu,boot-module-section =3D <0x10000000 0x10000000>; /* * Define a section to cover all guest RAM. All guest RAM must be locat= ed * within this section. The pros is that, in best case, we can only hav= e * one MPU protection region to map all guest RAM for Xen. */ mpu,guest-memory-section =3D <0x20000000 0x30000000>; /* * Define a memory section that can cover all device memory that * will be used in Xen. */ mpu,device-memory-section =3D <0x80000000 0x7ffff000>; /* Define a section for Xen heap */ xen,static-mem =3D <0x50000000 0x20000000>; domU1 { ... #xen,static-mem-address-cells =3D <0x01>; #xen,static-mem-size-cells =3D <0x01>; /* Statically allocated guest memory, within mpu,guest-memory-secti= on */ xen,static-mem =3D <0x30000000 0x1f000000>; module@11000000 { compatible =3D "multiboot,kernel\0multiboot,module"; /* Boot module address, within mpu,boot-module-section */ reg =3D <0x11000000 0x3000000>; ... }; module@10FF0000 { compatible =3D "multiboot,device-tree\0multiboot,module"; /* Boot module address, within mpu,boot-module-section */ reg =3D <0x10ff0000 0x10000>; ... }; }; }; ``` It's little hard for users to compose such a device tree by hand. Based on the discussion of Draft-A, Xen community suggested users to use some tools like [imagebuilder](https://gitlab.com/xen-project/imagebuilder) to g= enerate the above device tree properties. Please goto TODO#3.3 section to get more details of this suggestion. ### **2.4. Changes of memory management** Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA. 1. ***Use buddy allocator to manage physical pages for PMSA*** From the view of physical page, PMSA and VMSA don't have any difference. So we can reuse buddy allocator on Armv8-R64 to manage physical pages. The difference is that, in VMSA, Xen will map allocated pages to virtual addresses. But in PMSA, Xen just convert the pages to physical address. 2. ***Can not use virtual address for memory management*** As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtua= l address to manage memory. This brings some problems, some virtual addres= s based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vu= map`, `ioremap` and `alternative`. But the functions or macros of these features are used in lots of common code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate cod= e everywhere. In this case, we propose to use stub helpers to make the cha= nges transparently to common code. 1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operati= ons. This will return physical address directly of fixmapped item. 2. For `vmap/vumap`, we will use some empty inline stub helpers: ``` static inline void vm_init_type(...) {} static inline void *__vmap(...) { return NULL; } static inline void vunmap(const void *va) {} static inline void *vmalloc(size_t size) { return NULL; } static inline void *vmalloc_xen(size_t size) { return NULL; } static inline void vfree(void *va) {} ``` 3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always return `NULL`, they could not work well on Armv8-R64 without changes. `ioremap` will return input address directly. But if some extended functions like `ioremap_nocache`, `ioremap_cache`, need to ask a new memory attributes. As Armv8-R doesn't have infinite MPU regions for Xen to split the memory area from its located MPU region and assign the new attributes to it. So in `ioremap_nocache`, `ioremap_cache`, if the input attributes are different from current memory attributes, these functions will return `NULL`. ``` static inline void *ioremap_attr(...) { /* We don't have the ability to change input PA cache attribute= s */ if ( CACHE_ATTR_need_change ) return NULL; return (void *)pa; } static inline void __iomem *ioremap_nocache(...) { return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE); } static inline void __iomem *ioremap_cache(...) { return ioremap_attr(start, len, PAGE_HYPERVISOR); } static inline void __iomem *ioremap_wc(...) { return ioremap_attr(start, len, PAGE_HYPERVISOR_WC); } void *ioremap(...) { return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); } ``` 4. For `alternative`, it has been listed in TODO, we will simply disabl= e it on Armv8-R64 in current stage. But simply disable `alternative` will make `cpus_have_const_cap` always return false. ``` * System capability check for constant cap */ #define cpus_have_const_cap(num) ({ \ register_t __ret; \ \ asm volatile (ALTERNATIVE("mov %0, #0", \ "mov %0, #1", \ num) \ : "=3Dr" (__ret)); \ \ unlikely(__ret); \ }) ``` So, before we have an PMSA `alternative` implementation, we have to implement a separate `cpus_have_const_cap` for Armv8-R64: ``` #define cpus_have_const_cap(num) cpus_have_cap(num) ``` ### **2.5. Changes of guest management** Armv8-R64 only supports PMSA in EL2, but it supports configurable VMSA or PMSA in EL1. This means Xen will have a new type guest on Armv8-R64 - MPU based guest. 1. **Add a new domain type - MPU_DOMAIN** When user want to create a guest that will be using MPU in EL1, user should add a `mpu` property in device tree `domU` node, like following example: ``` domU2 { compatible =3D "xen,domain"; direct-map; mpu; --> Indicates this domain will use PMSA in EL1. ... }; ``` Corresponding to `mpu` property in device tree, we also need to introdu= ce a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as a= n MPU domain. This flag will be used in domain creation and domain doing vCPU context switch. 1. Domain creation need this flag to decide enable PMSA or VMSA in EL1. 2. vCPU context switch need this flag to decide save/restore MMU or MPU related registers. 2. **Add MPU registers for vCPU to save EL1 MPU context** Current Xen only supports MMU based guest, so it hasn't considered to save/restore MPU context. In this case, we need to add MPU registers to `arch_vcpu`: ``` struct arch_vcpu { ... #ifdef CONFIG_ARM_MPU /* Virtualization Translation Control Register */ register_t vtcr_el2; /* EL1 MPU regions' registers */ pr_t *mpu_regions; #endif ... } ``` Armv8-R64 can support max to 256 MPU regions. But that's just theoretic= al. So we don't want to embed `pr_t mpu_regions[256]` in `arch_vcpu` direct= ly, this will be a memory waste in most cases. Instead we use a pointer in `arch_vcpu` to link with a dynamically allocated `mpu_regions`: ``` p->arch.mpu_regions =3D _xzalloc(sizeof(pr_t) * mpu_regions_count_el1, = SMP_CACHE_BYTES); ``` As `arch_vcpu` is used very frequently in context switch, so Xen define= s `arch_vcpu` as a cache alignment data structure. `mpu_regions` also wil= l be used very frequently in Armv8-R context switch. So we use `_xzalloc` to allocate `SMP_CACHE_BYTES` alignment memory for `mpu_regions`. `mpu_regions_count_el1` can be detected from `MPUIR_EL1` system registe= r in Xen boot stage. The limitation is that, if we define a static `arch_vcpu`, we have to allocate `mpu_regions` before using it. 3. **MPU based P2M table management** Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through PMSA, it still has the ability to control the permissions and attributes of EL1 stage 2. In this case, we still hope to keep the interface consistent with MMU based P2M as far as possible. p2m->root will point to an allocated memory. In Armv8-A64, this memory is used to save the EL1 stage 2 translation table. But in Armv8-R64, this memory will be used to store EL2 MPU protection regions that are used by guest. During domain creation, Xen will prepare the data in this memory to make guest can access proper RAM and devices. When the guest's vCPU will be scheduled in, this data will be written to MPU protection region registers. ### **2.6. Changes of exception trap** As Armv8-R64 has compatible exception mode with Armv8-A64, so we can reuse = most of Armv8-A64's exception trap & handler code. But except the trap based on = EL1 stage 2 translation abort. In Armv8-A64, we use `FSC_FLT_TRANS` ``` case FSC_FLT_TRANS: ... if ( is_data ) { enum io_state state =3D try_handle_mmio(regs, hsr, gpa); ... } ``` But for Armv8-R64, we have to use `FSC_FLT_PERM` ``` case FSC_FLT_PERM: ... if ( is_data ) { enum io_state state =3D try_handle_mmio(regs, hsr, gpa); ... } ``` ### **2.5. Changes of device driver** Because Armv8-R64 only has single secure state, this will affect some devices that have two secure state, like GIC. But fortunately, most vendors will not link a two secure state GIC to Armv8-R64 processors. Current GIC driver can work well with single secure state GIC for Armv8-R64= . ### **2.7. Changes of virtual device** Currently, we only support pass-through devices in guest. Because event channel, xen-bus, xen-storage and other advanced Xen features haven't been enabled in Armv8-R64. ## 3. TODO This section describes some features that are not currently implemented in the PoC. Those features are things that should be looked in a second stage and will not be part of the initial support of MPU/Armv8-R. Those jobs coul= d be done by Arm or any Xen contributors. ### 3.1. Alternative framework support On Armv8-A system, `alternative` is depending on `VMAP` function to rem= ap a code section to a new read/write virtual address. But on Armv8-R, we = do not have virtual address to do remap. So as an alternative method, we w= ill disable the MPU to make all RAM `RWX` in "apply alternative all patches= " progress temporarily. 1. Disable MPU -> Code section becomes RWX. 2. Apply alternative patches to Xen text. 3. Enable MPU -> Code section restores to RX. All memory is RWX, there may be some security risk. But, because "alternative apply patches" happens in Xen init stage, it probably doesn't matter as much. ### 3.2. Xen Event Channel Support In Current RFC patches we haven't enabled the event channel support. But I think it's good opportunity to do some discussion in advanced. On Armv8-R, all VMs are native direct-map, because there is no stage2 MMU translation. Current event channel implementation depends on some shared pages between Xen and guest: `shared_info` and per-cpu `vcpu_inf= o`. There are two issues with these two pages: 3.2.1. Direct-mapping: For `shared_info`, in current implementation, Xen will allocate a page from heap for `shared_info` to store initial meta data. When guest is trying to setup `shared_info`, it will allocate a free gfn and use a hypercall to setup P2M mapping between gfn and `shared_info`. For direct-mapping VM, this will break the direct-mapping concept. And on an MPU based system, like Armv8-R system, this operation will be very unfriendly. Xen need to pop `shared_info` page from Xen heap and insert it to VM P2M pages. If this page is in the middle of Xen heap, this means Xen need to split current heap and use extra MPU regions. Also for the P2M part, this page is unlikely to form a new continuous memory region with the existing p2m pages, and Xen is likely to need another additional MPU region to set it up, which is obviously a waste for limited MPU regions. And This kind of dynamic is quite hard to imagine on an MPU system. For `vcpu_info`, in current implementation, Xen will store `vcpu_info` meta data for all vCPUs in `shared_info`. When guest is trying to setup `vcpu_info`, it will allocate memory for `vcpu_info` from guest side. And then guest will use hypercall to copy meta data from `shared_info` to guest page. After that both Xen `vcpu_info` and guest `vcpu_info` are pointed to the same page that allocated by guest. This implementation has serval benefits: 1. There is no waste memory. No extra memory will be allocated from Xen= heap. 2. There is no P2M remap. This will not break the direct-mapping, and is MPU system friendly. So, on Armv8-R system, we can still keep current implementation for per-cpu `vcpu_info`. So, our proposal is that, can we reuse current implementation idea of `vcpu_info` for `shared_info`? We still allocate one page for `d->shared_info` at domain construction for holding some initial meta-d= ata, using alloc_domheap_pages instead of alloc_xenheap_pages and share_xen_page_with_guest. And when guest allocates a page for `shared_info` and use hypercall to setup it, We copy the initial data = from `d->shared_info` to it. And after copy we can update `d->shared_info` t= o point to guest allocated 'shared_info' page. In this case, we don't have to t= hink about the fragmentation of Xen heap and p2m and the extra MPU regions. As guest cannot access 'shared_info' until it makes the XENMAPSPACE_shared_info hypercall. So it should be possible to get rid of the initial 'shared_info' allocation in Xen. 3.2.2. How to access these pages of remote domain in hypercall As 'shared_info' and 'vcpu_info' are allocated by Guest. And these page= s are not mapped in Xen's MPU regions, instead they should be mapped in guest's P2M MPU regions. When guest issues a hypercall to notify a peer domain through event channel. Xen needs to update the pending bitmap in peer domain's page. For MMU system, Xen has a full view of system memory in runtime. Becaus= e it has dedicated EL2 MMU to map whole system memory. So it has the abil= ity to update peer domain's pending bitmap. But in MPU system, the EL2 MPU = is shared by Xen and guest P2M mapping. In hypercall context, the EL2 MPU only contains Xen memory (code, data and heap) and current running gues= t's P2M mapping. When Xen accesses peer domain's pending bitmap, it will ca= use EL2 data abort. So, for MPU system, we need to reserve one EL2 MPU region to map peer domain's page to handle hypercalls which need to access this peer domai= n's page. More detailed discussions have been listed in [Draft-B](https://l= ists.xenproject.org/archives/html/xen-devel/2022-04/msg01719.html). But here still has some concerns: `d->shared_info` in Xen is accessed without any lock. So it will not be that simple to update `d->shared_info`. It might be possible to protect d->shared_info (or other structure) with a read-write lock. Do we need to add PGT_xxx flags to make it global and stay as much the same with the original op, a simple investigation tells us that it only be referred in `get_page_type`. Since ARM doesn't care about type count= s and always return 1, it doesn't have too much impact. ### 3.3. Xen Partial PIC/PIE We have mentioned about PIC/PIE in section 1.2. With PIC/PIE support, Xen can be loaded at any address and run properly. But it's rare to use PIC/PIE on a real-time system (code size, more memory access). So a partial PIC/PIE image maybe better. But partial PIC/PIE image may not solve the Xen start address issue. But a partial PIC/PIE support may be needed for Armv8-R. Because Arm [EBBR](https://arm-software.github.io/ebbr/index.html) require Xen on Armv8-R to support EFI boot service. Due to lack of relocation capability, EFI loader could not launch xen.efi on Armv8-R. So maybe we still need a partially supported PIC/PIE. Only some boot code support PIC/PIE to make EFI relocation happy. This boot code will help Xen to check its loaded address and relocate Xen image to Xen's run-time address if need. ### 3.4. A tool to generate Armv8-R Xen device tree 1. Use a tool to generate above device tree property. This tool will have some similar inputs as below: --- DEVICE_TREE=3D"fvp_baremetal.dtb" XEN=3D"4.16-2022.1/xen" NUM_DOMUS=3D1 DOMU_KERNEL[0]=3D"4.16-2022.1/Image-domU" DOMU_RAMDISK[0]=3D"4.16-2022.1/initrd.cpio" DOMU_PASSTHROUGH_DTB[0]=3D"4.16-2022.1/passthrough-example-dev.dtb" DOMU_RAM_BASE[0]=3D0x30000000 DOMU_RAM_SIZE[0]=3D0x1f000000 --- Using above inputs, the tool can generate a device tree similar as we have described in sample. - `mpu,guest-memory-section`: This section will cover all guests' RAM (`xen,static-mem` defined region= s in all DomU nodes). All guest RAM must be located within this section. In the best case, we can only have one MPU protection region to map all guests' RAM for Xen. If users set `DOMU_RAM_BASE`, `DOMU_RAM_SIZE` or `DOMU_STATIC_MEM_RANGES= `, these will be converted to the base and size of `xen,static-mem`. This t= ool will scan all `xen, static-mem` in DomU nodes to determine the base and size of `mpu,guest-memory-section`. If any other kind of memory has been detected in this section, this tool can report an error. Except build time check, Xen also need to do runtime check to prevent a bad device tree that generated by malicious tools. If users set `DOMU_RAM_SIZE` only, this will be converted to the size of `xen,static-mem` only. Xen will allocate the guest memory in runtime, bu= t not from Xen heap. `mpu,guest-memory-section` will be calculated in runt= ime too. The property in device tree doesn't need or will be ignored by Xen. - `mpu,boot-module-section`: This section will be used to store the boot modules like DOMU_KERNEL, DOMU_RAMDISK, and DOMU_PASSTHROUGH_DTB. Xen keeps all boot modules in this section to meet the requirement of DomU restart on Armv8-R. In current stage, we don't have a privilege domain like Dom0 that can access filesystem to reload DomU images. And in current Xen code, the base and size are mandatory for boot module= s If users don't specify the base of each boot module, the tool will allocate a base for each module. And the tool will generate the `mpu,boot-module-section` region, when it finishes boot module memory allocation. Users also can specify the base and size of each boot module, these will be converted to the base and size of module's `reg` directly. The tool will scan all modules `reg` in DomU nodes to generate the base and size = of `mpu,boot-module-section`. If there is any kind of other memory usage has been detected in this section, this tool can report an error. Except build time check, Xen also need to do runtime check to prevent a bad device tree. - `mpu,device-memory-section`: This section will cover all device memory that will be used in Xen. Like `UART`, `GIC`, `SMMU` and other devices. We haven't considered multiple `mpu,device-memory-section` scenarios. The devices' memory and RAM are interleaving in physical address space, it would be required to use multiple `mpu,device-memory-section` to cover all devices. This layout is common on Armv8-A system, especially in server. But it's rare in Armv8-R. So in current stage, we don't want to allow multiple `mpu,device-memory-section`. The tool can scan baremetal device tree to sort all devices' memory ranges. And calculate a proper region for `mpu,device-memory-section`. If it find Xen need multiple `mpu,device-memory-section`, it can report an unsupported error. 2. Use a tool to generate device tree property and platform files This opinion still uses the same inputs as opinion#1. But this tool only generates `xen,static-mem` and `module` nodes in DomU nodes, it will not generate `mpu,guest-memory-section`, `mpu,boot-module-section` and `mpu,device-memory-section` properties in device tree. This will generate following macros: `MPU_GUEST_MEMORY_SECTION_BASE`, `MPU_GUEST_MEMORY_SECTION_SIZE` `MPU_BOOT_MODULE_SECTION_BASE`, `MPU_BOOT_MODULE_SECTION_SIZE` `MPU_DEVICE_MEMORY_SECTION_BASE`, `MPU_DEVICE_MEMORY_SECTION_SIZE` in platform files in build time. In runtime, Xen will skip the device tree parsing for `mpu,guest-memory-section`, `mpu,boot-module-section` and `mpu,device-memory-section`. And instead Xen will use these macros to do runtime check. But, this also means these macros only exist in local build system, these macros will not be maintained in Xen repo. Both options are acceptable and we could support both. The main difference = for the user is that option #2 requires a Xen build after running ImageBuilder, while option #1 might not. But we don't have to implement both options right away. We can start from option#1, it will be easier for initial implementation, and the current PoC implementation will still be possible to use. -- Cheers, Wei Chen From xen-devel-bounces@lists.xenproject.org Sun May 08 04:06:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 04:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323864.545758 (Exim 4.92) (envelope-from ) id 1nnYBN-0002LS-Oz; Sun, 08 May 2022 04:06:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323864.545758; Sun, 08 May 2022 04:06:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYBN-0002LL-Lm; Sun, 08 May 2022 04:06:09 +0000 Received: by outflank-mailman (input) for mailman id 323864; Sun, 08 May 2022 04:06:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYBM-0002LB-Em; Sun, 08 May 2022 04:06:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYBM-0005JL-Bd; Sun, 08 May 2022 04:06:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYBM-0006SX-15; Sun, 08 May 2022 04:06:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnYBM-00070n-0c; Sun, 08 May 2022 04:06:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ILAjagl66yxMS78KID5HrwI1B2OSX0yhi3tdj+bdr/o=; b=GJO/HDjF73CzkzJr0mMoXyR6Ag E79lwV1/xrxlXU0otTPNs57F7H1orWlCv/cDQFw3wGViHte2UBwJxUZQdKdXIXZLNXc7WNJagL+T2 PKZ9JCPuRXRSLlnDWJu0xzpL+wtReKZg7VjLUwoaGSiypMT6XVWEHb4+KcrsS16RMAm4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170229: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 04:06:08 +0000 flight 170229 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170229/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 865 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 04:44:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 04:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323872.545769 (Exim 4.92) (envelope-from ) id 1nnYmD-0006aZ-NE; Sun, 08 May 2022 04:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323872.545769; Sun, 08 May 2022 04:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYmD-0006aS-KH; Sun, 08 May 2022 04:44:13 +0000 Received: by outflank-mailman (input) for mailman id 323872; Sun, 08 May 2022 04:44:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYmC-0006aI-I2; Sun, 08 May 2022 04:44:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYmC-00065d-G0; Sun, 08 May 2022 04:44:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnYmB-0007hE-UR; Sun, 08 May 2022 04:44:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnYmB-0008Pi-U2; Sun, 08 May 2022 04:44:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D/2RcaOW7v1o7juBuG7Q6bRgb8uFM++XQkpWiZ9RPXw=; b=O06PduQ5UvjkjD83cWp2gK4t8n wRgHJ+MO/4XXykb/PiefUOgIgVja0+qzQw2mjHgv5mgNOJTdMmh0B2m5LWAtkIYpFF2xX7BgNbrql obNSuRd9jwhBzFv+8MCHhzsonQlCTaepqXsVXBZypVJoTG3XFITh4tGT5rzdTDRw6fYc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170221: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=30c8e80f79329617012f07b09b70114592092ea4 X-Osstest-Versions-That: linux=4b97bac0756a81cda5afd45417a99b5bccdcff67 From: osstest service owner Date: Sun, 08 May 2022 04:44:11 +0000 flight 170221 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170221/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170197 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170197 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170197 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 30c8e80f79329617012f07b09b70114592092ea4 baseline version: linux 4b97bac0756a81cda5afd45417a99b5bccdcff67 Last test of basis 170197 2022-05-07 01:43:28 Z 1 days Testing same since 170221 2022-05-07 18:41:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Bartosz Golaszewski Baruch Siach Haowen Bai Jan Höppner Jens Axboe Linus Torvalds Linus Walleij Ming Lei Nobuhiro Iwamatsu Puyou Lu Stefan Haberland jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4b97bac0756a..30c8e80f7932 30c8e80f79329617012f07b09b70114592092ea4 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 08 05:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 05:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323880.545780 (Exim 4.92) (envelope-from ) id 1nnZ3e-00012g-6W; Sun, 08 May 2022 05:02:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323880.545780; Sun, 08 May 2022 05:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ3e-00012Z-3B; Sun, 08 May 2022 05:02:14 +0000 Received: by outflank-mailman (input) for mailman id 323880; Sun, 08 May 2022 05:02:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ3d-00012P-00; Sun, 08 May 2022 05:02:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ3c-0006h5-Mg; Sun, 08 May 2022 05:02:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ3c-00088g-B3; Sun, 08 May 2022 05:02:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnZ3c-0005Po-Ad; Sun, 08 May 2022 05:02:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RoLN9CuFgfn8QKkT034ytVKJWufXyglRrulc2jsO//A=; b=23POwp4nM5PMMCkT12kC1rkqib kOdAB3SFKDCV4tOoEGLxnGY5rj+zoxUe4YjOxb8se4IWNISjGl0xHjGrsuPwl/uKAQlZj9H3Es+ar D1KKnzes8kzTNEEO3iZxWPEPV98zT8+e/8l+pz8NJE+oMTKxpSZ8BHC9Zd9l7FS1aMTE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170230: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 05:02:12 +0000 flight 170230 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170230/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 866 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 05:08:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 05:08:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323889.545791 (Exim 4.92) (envelope-from ) id 1nnZ9U-0001nz-0V; Sun, 08 May 2022 05:08:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323889.545791; Sun, 08 May 2022 05:08:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ9T-0001ns-Sk; Sun, 08 May 2022 05:08:15 +0000 Received: by outflank-mailman (input) for mailman id 323889; Sun, 08 May 2022 05:08:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ9T-0001ni-HW; Sun, 08 May 2022 05:08:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ9T-0006me-CJ; Sun, 08 May 2022 05:08:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnZ9S-0008Gz-VI; Sun, 08 May 2022 05:08:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnZ9S-0003bQ-Uo; Sun, 08 May 2022 05:08:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bsWXzp71fBC3mVvdLB+WZjj8vCENX2PijuO1fa0CLiQ=; b=FgET9T9gJPum7hxEKQ2AhcEiNz lMz9rIwPPdwRB9yKhKJuDUt2+nKFD3shb8TuVn8l/FvYANDoj+i9keQ4CZ+9xlYnzmtc7/CQXjdGV OTMyVQq/ef83xb/lAuAN6nJPyu6DenY4SSZrbtVdqZ1ie8FY4ABVrQTaP4bP+ikYeLsw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170220: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b7e0d8978810b534725e94a321736496928f00a5 X-Osstest-Versions-That: xen=90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 From: osstest service owner Date: Sun, 08 May 2022 05:08:14 +0000 flight 170220 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170220/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 170204 pass in 170220 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 170204 pass in 170220 test-arm64-arm64-libvirt-xsm 8 xen-boot fail pass in 170204 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 170204 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 170204 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170179 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170179 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170179 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170179 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170179 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170179 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170179 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen b7e0d8978810b534725e94a321736496928f00a5 baseline version: xen 90ba9a2da23fbdb69c8d822f636447e8a42d1eb8 Last test of basis 170179 2022-05-06 09:53:58 Z 1 days Failing since 170192 2022-05-06 19:39:47 Z 1 days 3 attempts Testing same since 170204 2022-05-07 06:49:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 90ba9a2da2..b7e0d89788 b7e0d8978810b534725e94a321736496928f00a5 -> master From xen-devel-bounces@lists.xenproject.org Sun May 08 06:25:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 06:25:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323936.545814 (Exim 4.92) (envelope-from ) id 1nnaMJ-0001dz-M8; Sun, 08 May 2022 06:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323936.545814; Sun, 08 May 2022 06:25:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnaMJ-0001ds-J2; Sun, 08 May 2022 06:25:35 +0000 Received: by outflank-mailman (input) for mailman id 323936; Sun, 08 May 2022 06:25:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnaMJ-0001di-08; Sun, 08 May 2022 06:25:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnaMI-00088b-PE; Sun, 08 May 2022 06:25:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnaMI-00027c-A7; Sun, 08 May 2022 06:25:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnaMI-0003mC-9b; Sun, 08 May 2022 06:25:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mQjbroWghJOAvnU0cWDEfks9lZV8mwImYqhHN3WvTkI=; b=HWz+KU6eRT12CvB0N27/p51pEX HI6qwgtwJ3uWo5Y6BKbCszBR/7Zvch5HDuXWvKF0V7y2QMUNlw5xkbUg+0a6qGPLPQ2azVoAEnlnX sVqk/a+Y2Yi9FkbB9l6hNcf/RXXQrCKKJs/XQeP1PqQZDn1i4ERhk4kIs5H0QVp/GfVI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170233: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 06:25:34 +0000 flight 170233 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170233/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 867 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 07:15:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 07:15:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323946.545825 (Exim 4.92) (envelope-from ) id 1nnb83-0006zB-IZ; Sun, 08 May 2022 07:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323946.545825; Sun, 08 May 2022 07:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnb83-0006z4-Fn; Sun, 08 May 2022 07:14:55 +0000 Received: by outflank-mailman (input) for mailman id 323946; Sun, 08 May 2022 07:14:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnb81-0006yu-Uq; Sun, 08 May 2022 07:14:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnb81-0000Y6-Sz; Sun, 08 May 2022 07:14:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnb81-0004ZU-Hw; Sun, 08 May 2022 07:14:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnb81-0001Da-HT; Sun, 08 May 2022 07:14:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pZv+iV5Xmv5nZcAABJPXszKXo+xseJwjPh9ist0g1gA=; b=R6GHtv9Dlp2pzX7lTCd0dmsStS AJb/KDZ6ye6VH5Olc8yvr+/+35GaiWoBnPQRzGaAafkWBMzgq/wVdytGBZKMERpUfkyp9PXE9uv/Q 21o7LwwXTpk3etnnXcmyB9MdujJm9m0ofKOqFqayOygezPQKhO5DkslIgYx2GGcldpX4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170234: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 07:14:53 +0000 flight 170234 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170234/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 868 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 08:35:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 08:35:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323963.545836 (Exim 4.92) (envelope-from ) id 1nncNS-0007A0-RJ; Sun, 08 May 2022 08:34:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323963.545836; Sun, 08 May 2022 08:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncNS-00079t-ND; Sun, 08 May 2022 08:34:54 +0000 Received: by outflank-mailman (input) for mailman id 323963; Sun, 08 May 2022 08:34:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncNR-00079m-9k for xen-devel@lists.xenproject.org; Sun, 08 May 2022 08:34:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9be8ad0-cea9-11ec-8fc4-03012f2f19d4; Sun, 08 May 2022 10:34:50 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-9-kEfqWQKoPJ6rYcdBSWTWnw-1; Sun, 08 May 2022 10:34:48 +0200 Received: from DB6PR04MB3159.eurprd04.prod.outlook.com (2603:10a6:6:11::25) by PAXPR04MB9325.eurprd04.prod.outlook.com (2603:10a6:102:2b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Sun, 8 May 2022 08:34:46 +0000 Received: from DB6PR04MB3159.eurprd04.prod.outlook.com ([fe80::cf9:4a87:2c14:aebc]) by DB6PR04MB3159.eurprd04.prod.outlook.com ([fe80::cf9:4a87:2c14:aebc%6]) with mapi id 15.20.5227.022; Sun, 8 May 2022 08:34:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9be8ad0-cea9-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1651998890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HiU1mAd1O3/oJ2eDLJEdoOia9ggJEiEAacNYAszM1Bc=; b=SGv76GCR7CGuUV7TUrkoTB7PJNzOPKZ+FfpVDny5hOoBDBvZpDZogMbbqtX+y2w+9cnA24 RKfIC7/VHntmVwaWOULxPpjkrR+9sfZw5CBuf32J9yP5LbSrc9wraUzPJ9e1FLvuOlCliq kKEUVPJDvBaRc9HodhCZ1Is5aVcH00c= X-MC-Unique: kEfqWQKoPJ6rYcdBSWTWnw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b65xESupKEMNwFHdFBEHo1QjeiBNDW1Df/dci6UBWraxmhfKJOCJuvUPHiQ1nqYbN4CGoN6cWvGkcktudTcuE26SxK3GslkDvROhaEGhoYsrmr5DOVs921ZJafRpNbC9dLzKPEoEB3bUF/6WTOfdUyai9LZ7fbnV/Lq0Uz9fyy/MERx7sFMbHjJpD0yX9u+gcu0Os/+vJVV//xb6/oXP+/pRFhrvk9DGozgQV49rLXliwmfkdWad046TcGkAVTx4BuqGkcd5YdCRVV/lWQ+snvANXC0Yv34DonJNskzyF5pgEDRFQ6ActXzN8v7kA/n7DvsfzrcMZrf5ntZkOkIZsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZAFEYnDOT9eWcDTZSxyHNacLa0a6evqvAOC1nhPlTEU=; b=Ip2Fo8ZUZIlsfzqUT26+AAxIu7gQLToojVwoEHHwQOMadsk7DCxHaS2OhjIuOkmT5um5+hV/8ARnO9fRfiZFi2n/KQmGd4F0ICx0L4P+dNa4Aa2u7PR9VjclfA78RPfEMzaAgaWqJNAMJwdY+1cAKaR6mQO3XSFETRwqtNvTIfqhePHNDqK81WaVi0TW5pQb4ajLgBh38BPniWdzL1wN14ox8hH2+TURlllf99mzcslpnNeAA2AixyWTOpBhqCti+GoqHHM1IlfLkdC5LZOp8eAnlRWuja6EwPL/WGtvfQ3VSn79ITPyjtne0N4c7HPJ97q+5icrYPtI2FW9U3uC4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5cb23441-d8c1-5640-d630-30881841db0c@suse.com> Date: Sun, 8 May 2022 10:34:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505142137.51306-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To DB6PR04MB3159.eurprd04.prod.outlook.com (2603:10a6:6:11::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d35e5c4-c031-4834-f980-08da30cd9bc8 X-MS-TrafficTypeDiagnostic: PAXPR04MB9325:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Isl8c7pIqkvLLG7XSO5kU3XknYAZgEbDOkfOeCK3Za24sf1+jT0G0yX93H/MG2XxsHm2P0PKMjIG5D78lw5/D8rS6l/sO2ReVpOPF9elBkd5gfjwCu59u1Saz7CHwaGcetwf9qbUr4GJKx0g8fNie3Zr7Z6sxijU1+9zNJmEBFEgjNLae9J1/mOp3Wa97Zup08L4IZdUYFOPN43A2vLdsDeco0FWYss00aWaE+X10lC3d6prboRLZ82w4fqke5VXu5LiR9SZE5oMUpszC8j9gLAeBfJUuYPNorkmYizI21aHAE794UIXiCFflTKgkKeo4hYrnBrsIdJjH8qRhkvV9v4UkrhfcCh38BH9nNS1pLpcZDi3otAMvJD0UGQA2im3EegcwdNNz9UhpQAW0pqvXbjUjl1aihQ/as0UeDmyjk7AkFPrBjWw9IG4bO8TT5fi6qhiVcOxANhqwN81f5dg/2td8Zdo87SHW3KOBLz3gDEgQW/b07EJ2oSxtiz68yFT52ZDxZTTXu1I4Nke4zJX6W4ClV86EGM/FLVHZXicGKti9zpU7uCfyucgnnlSeYFvhsoFCqdVI/Q1mqGKwJY1TcAGFK3jvpdhDdHIv37dPr9W3rHztwlUBVkKTlyodT/kcA3DT0PYyjSp0d7NkPPfLWJkoiwEF9tzkFYhs8EskofdqGquID/QuxsierxIbQhBFSe/4rXIk5PAIF4tXvJl4ha9zWjcbos1f18FLDrz9xp9OkgXP+JiGjjljEoAn6Ihu5ga0nmSmJj0P3EZw6rLicwe5XQ+Q9RjuBaaKAmGhW1gNDMQVZjjnQgvMBNp6n3F X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB6PR04MB3159.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(2616005)(8936002)(6506007)(6486002)(966005)(5660300002)(53546011)(508600001)(6512007)(38100700002)(31696002)(186003)(86362001)(2906002)(83380400001)(316002)(66946007)(36756003)(4326008)(66556008)(8676002)(6916009)(66476007)(31686004)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TXzJbZBQE7Y5hCRHjuygxPBdMWSjxVDsswZtVvSlpENpvY/SCnRg7qu+wSw8?= =?us-ascii?Q?XcGCqDxWgsG8P+zLWy72nIi1fDf665m5LgTD1WVeXjaPMGZ38zLhaXF3s/Fi?= =?us-ascii?Q?O3n7K5uYTRTjEWJu2d+v2eWIj/UbaUEubv/Ws4mbY9qo+ZoYbvqDuNwGgHo7?= =?us-ascii?Q?Km9/hFAzQKmoJ4K1Q0YV0Pq5CzBB2MeYCNijQYTB14iXu94rnQWBvv33CRrd?= =?us-ascii?Q?wLX1tCgCTGEV4AH0sG47DojBrvhPcdGsY+KoRANp0xzNgEWkaUtWTn1pdJEl?= =?us-ascii?Q?CrdR/Vrcqxf1ucKJ7+N9gZnmtmHbjfMvJz/O9AgIWkYb2xYU2yPNYPCmHoHv?= =?us-ascii?Q?Q1mv/SrBLOKGudIy4ptxbv704eDgIrrQSIMH3qloqV3Eweay2rgEFofYnivr?= =?us-ascii?Q?oL7tUSqEgDP5H/Gze9IM4hg3JibHzqEmCKbDGuJMniGuS0617CHzIGIUympU?= =?us-ascii?Q?tb2pCr1KawcV/mXGlA0D/xgwjMrx1LFglCtoJl67XVzutWzdGg+ePwqhevp+?= =?us-ascii?Q?+tHnnpK/InG/jBM4vCddmg76MlZ7x3gj4hN85sm2kT8nvaCaupo9Gc7me/6t?= =?us-ascii?Q?U7FgJ9MGAadkTdHrroBT3CTbKRvzDGS8GTzwI/JgMFbdTaEtD34EnXQxtiTa?= =?us-ascii?Q?jwe7VLY9x6sJAS0Six/lbMAhpnegZQ9zRKlnjjKceROa9BYBLcjkVqIn41US?= =?us-ascii?Q?wKJa4pnD+bIlcTHnnSRuMmCPG/85xovDhFeUCK0GL17gv8x3sHItjFzXB3ZM?= =?us-ascii?Q?Z6r58M+gTc/JJXL1b5IGrx9IrqAVO+HhJalTmH35MsOVslsvzzmW+BUtSm1m?= =?us-ascii?Q?3JoTtjz/QWdUMvd+YYpVSlvAnPyEpge8nqW3jK38zX3IDp6TuV7R0tLlmxBq?= =?us-ascii?Q?QXX0rdW1oQEq9z6fEHq6eogMWHVvHzgneL8FvwCUPkFF4BYojV5h8mK8Xsaa?= =?us-ascii?Q?aNjFGWzgi7rgzEaF7u85vrF49W4uQV5f81Xk95J9kANoIH1hgDLFxCMDduVv?= =?us-ascii?Q?wXQrGElwvPT3Gh9t4qlrJRttVIALZknR6+eGL58ZTcHhwlkvEsSGnfvHiNve?= =?us-ascii?Q?ZXG2v1XhK4cdom/r59C+REwGNfxxNUhhp+qREmW2inc+ErrkjgKIha9KCqvj?= =?us-ascii?Q?Kv7yHZ+8czLId399QRpsl0wAw+NKzyzv+T//ts5+NryV/PCQcj0aTKpGjsUy?= =?us-ascii?Q?LQZTVySfUqJiXNOjOP0Qw4JfJUSY5Tr2c0Bdg3svq+woukdSCGx8O+rD5XVH?= =?us-ascii?Q?jpjpqz5unIqLIA5Ir7tjPfldeTkqi70zki57Ym58fRvkBp53Yh67FM//YZ8k?= =?us-ascii?Q?b7I2XOyQBWJvHMejdUx7zX4NM3iyRfFc5i2QZzfHR7M2M6DLcsgnM++eBlll?= =?us-ascii?Q?DNsRpnFcJu53DNs9EExgJQgIB2DwE8Vjou5B0/Mxzjzv/rN5oSon0qVpfnTI?= =?us-ascii?Q?9ZCcW0hoi/l3w0BPYS9xgELuuCBJklRoHSi0f2nVqqeY3BD11fEx9xt0KMFL?= =?us-ascii?Q?RqG0SB4aA66S5hOPoe8oTWvg8hkWI05mutp+r/z6wDhIoVnaFS11mdPMTHIc?= =?us-ascii?Q?LH0Lcx+iNj3i69gznQAs2KlYAFMgnicbIXCfLTJuQH56Bk4oFcrLyodqYr9d?= =?us-ascii?Q?sAI8vVNEtRSN8oMGfWNEvICIGinXO4aEy1hYbpUzZo0yuzGKNp+mc5suPsal?= =?us-ascii?Q?2QBNADjDoVwn226R1QFxe+ohaMN7IbECSEQAEIhTySRQjKmiH4VZE/fBZjtT?= =?us-ascii?Q?cwYT7no5it4c9Ze5p0EvWE0VUDh6JSMF9UcRZymR4fGN7TRh3IrLXNqhGVSW?= X-MS-Exchange-AntiSpam-MessageData-1: J9YWVZ1a6B6yHw== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d35e5c4-c031-4834-f980-08da30cd9bc8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR04MB3159.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2022 08:34:46.8289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkRuEUsWnkYR6tSEJYTsfgzF8XqCHXBoIGVy4RfFbNRc5iJYgwyfvGC0lBCF5O9jJmcHY8BQgZciFwSrAivq4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9325 On 06.05.2022 17:35, Roger Pau Monn=C3=A9 wrote: > On Fri, May 06, 2022 at 03:31:12PM +0200, Roger Pau Monn=C3=A9 wrote: >> On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: >>> On 05.05.2022 16:21, Roger Pau Monne wrote: >>>> --- a/xen/include/xen/compiler.h >>>> +++ b/xen/include/xen/compiler.h >>>> @@ -125,10 +125,11 @@ >>>> #define __must_be_array(a) \ >>>> BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a= [0]))) >>>> =20 >>>> -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE >>>> -/* Results in more efficient PIC code (no indirections through GOT or= PLT). */ >>>> -#pragma GCC visibility push(hidden) >>>> -#endif >>>> +/* >>>> + * Results in more efficient PIC code (no indirections through GOT or= PLT) >>>> + * and is also required by some of the assembly constructs. >>>> + */ >>>> +#pragma GCC visibility push(protected) >>>> =20 >>>> /* Make the optimizer believe the variable can be manipulated arbitra= rily. */ >>>> #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) >>> >>> This has failed my pre-push build test, with massive amounts of errors >>> about asm() constraints in the alternative call infrastructure. This >>> was with gcc 11.3.0. >> >> Hm, great. I guess I will have to use protected with clang and hidden >> with gcc then, for lack of a better solution. >> >> I'm slightly confused as to why my godbolt example: >> >> https://godbolt.org/z/chTnMWxeP >> >> Seems to work with gcc 11 then. I will have to investigate a bit I >> think. >=20 > So it seems the problem is explicitly with constructs like: >=20 > void (*foo)(void); >=20 > void test(void) > { > asm volatile (".long [addr]" :: [addr] "i" (&(foo))); > } >=20 > See: >=20 > https://godbolt.org/z/TYqeGdWsn >=20 > AFAICT gcc will consider the function pointer foo to go through the > GOT/PLT redirection table, while clang will not. I think gcc behavior > is correct because in theory foo could be set from a different module? > protect only guarantees that references to local functions cannot be > overwritten, but not external ones. Right, since there's no way to tell the compiler that the symbol will be resolved in the same "module". > I don't really see a good way to fix this, rather that setting > different visibilities based on the compiler. clang would use > protected and gcc would use hidden. If gcc's behavior is indeed correct, then moving to protected with clang would set us up for going through GOT/PLT there - either right away (if the implement this like gcc), or once they correct their behavior. I don't think we want that. Therefore I think we want to alter visibility between compilation and linking (i.e. presumably right in prelink.o), going from compile-time hidden to link-time protected. That would likely be closer to what your original patch did (sadly there's no "convert to option to objcopy, and making it have one wouldn't really help us here; it's also not clear to me whether llvm comes with its own objcopy, or whether they re-use GNU's). > I think it's unlikely to have a > toolstack setup to use gcc as the compiler and LLVM LD as the > linker, which would be the problematic configuration, and even in that > case it's kind of a cosmetic issue with symbol resolution, binary > output from the linker would still be correct. While likely moot with the above, I agree that we could make such an assumption if need be. Jan > Let me know if that seems acceptable. >=20 > Thanks, Roger. >=20 From xen-devel-bounces@lists.xenproject.org Sun May 08 08:56:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 08:56:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323969.545847 (Exim 4.92) (envelope-from ) id 1nncho-0001Bv-IB; Sun, 08 May 2022 08:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323969.545847; Sun, 08 May 2022 08:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncho-0001Bo-Ez; Sun, 08 May 2022 08:55:56 +0000 Received: by outflank-mailman (input) for mailman id 323969; Sun, 08 May 2022 08:55:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnchn-0001Be-68; Sun, 08 May 2022 08:55:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnchn-0002kV-4L; Sun, 08 May 2022 08:55:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnchm-00033J-Iy; Sun, 08 May 2022 08:55:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnchm-0006Cx-IW; Sun, 08 May 2022 08:55:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jY4tPmwh5MDJ22Pu4bht4yAD1T+HFo7rlRil40CA/40=; b=Eg5bwH5bmpsf6A5CfxnDK7uKcq Uy4CXPi9/deXPAJDSLZ/WVDK9KopOJODScQFM6N9OnBnKSosGbRLxiVDx9RHjOo4KNxY0vwMPyFNe M2WFQB9aDUFhS3M2tJHA14EKLg0nSLyL7Bkz2tncxSTIsNbQs/d0DwebnpeuP+HH2rzg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170236: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 08:55:54 +0000 flight 170236 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 68 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 869 attempts Testing same since 170178 2022-05-06 09:40:34 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 09:03:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 09:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323978.545857 (Exim 4.92) (envelope-from ) id 1nncoj-0002ks-Fr; Sun, 08 May 2022 09:03:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323978.545857; Sun, 08 May 2022 09:03:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncoj-0002kl-DA; Sun, 08 May 2022 09:03:05 +0000 Received: by outflank-mailman (input) for mailman id 323978; Sun, 08 May 2022 09:03:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncoh-0002kb-Qk; Sun, 08 May 2022 09:03:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncoh-0002t5-O3; Sun, 08 May 2022 09:03:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncoh-0003Ub-Aq; Sun, 08 May 2022 09:03:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nncoh-0000Hw-AO; Sun, 08 May 2022 09:03:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0WSI7pAKpw/U95AgkPBNYRR9tiLz9CCdjsAJzeB6Q2Q=; b=pQkqvI0VERsXEEyGUYzvHTKkSL f/T7vl2gMqYobGJzQwoEmCZcp+rG82UKHhxldznOhnuqPTvywqulxSwVe+6LOuGbvF06mT/keryS7 SADWPqQR67H5igyKYeP17zMqpfjUysN4SeD/LPjhoezCMMaK232YVCnHPpW2I1Afd8oQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170231: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=5890a320f893b7db63b15a55feebb0e314baf47b X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 08 May 2022 09:03:03 +0000 flight 170231 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170231/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 5890a320f893b7db63b15a55feebb0e314baf47b baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 667 days Failing since 151818 2020-07-11 04:18:52 Z 666 days 648 attempts Testing same since 170201 2022-05-07 04:20:26 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106819 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 09:09:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 09:09:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323986.545869 (Exim 4.92) (envelope-from ) id 1nncv8-0003TB-9D; Sun, 08 May 2022 09:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323986.545869; Sun, 08 May 2022 09:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncv8-0003T4-54; Sun, 08 May 2022 09:09:42 +0000 Received: by outflank-mailman (input) for mailman id 323986; Sun, 08 May 2022 09:09:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncv6-0003Sb-Q7; Sun, 08 May 2022 09:09:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncv6-00030Z-Mg; Sun, 08 May 2022 09:09:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nncv6-0003tw-5m; Sun, 08 May 2022 09:09:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nncv6-0000xw-5K; Sun, 08 May 2022 09:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o19aI8hzr6u3gPhJFmLFU1OSNYehdn0p0ptnpXt8SCo=; b=sdGoOaj80Cz5susKmPijnIyNEJ 0KKm92S6hfBFGuCP+3m+g+6FXKTc98mdOAUZ9mtASJJtTfUnzujeqzhfBUHx03rigLGB79EwCEE17 pVY5/wXwfS2iaak97GdeaOZgOX7TVgcMr8l2Z3CtVEXwd91IYGGz69judKwrCJ5QHIEw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170224: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-multivcpu:guest-localmigrate:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f1336649156cf57f5d874a98e619fb362e3fcb59 X-Osstest-Versions-That: qemuu=11314643c35401b18c5374f4ec82ee7d3d5d2692 From: osstest service owner Date: Sun, 08 May 2022 09:09:40 +0000 flight 170224 qemu-mainline real [real] flight 170235 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170224/ http://logs.test-lab.xenproject.org/osstest/logs/170235/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-multivcpu 18 guest-localmigrate fail pass in 170235-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170212 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170212 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170212 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170212 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170212 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170212 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170212 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170212 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu f1336649156cf57f5d874a98e619fb362e3fcb59 baseline version: qemuu 11314643c35401b18c5374f4ec82ee7d3d5d2692 Last test of basis 170212 2022-05-07 13:08:21 Z 0 days Testing same since 170224 2022-05-07 20:39:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Kostiuk Marc-André Lureau Paolo Bonzini Richard Henderson Sunil Muthuswamy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 11314643c3..f133664915 f1336649156cf57f5d874a98e619fb362e3fcb59 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun May 08 10:35:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 10:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.323995.545880 (Exim 4.92) (envelope-from ) id 1nneFs-000419-KI; Sun, 08 May 2022 10:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 323995.545880; Sun, 08 May 2022 10:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nneFs-000412-Gd; Sun, 08 May 2022 10:35:12 +0000 Received: by outflank-mailman (input) for mailman id 323995; Sun, 08 May 2022 10:35:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nneFr-00040w-Ov for xen-devel@lists.xenproject.org; Sun, 08 May 2022 10:35:11 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87ed232b-ceba-11ec-a406-831a346695d4; Sun, 08 May 2022 12:35:09 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id l18so21820494ejc.7 for ; Sun, 08 May 2022 03:35:08 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-183-246-161.77.183.pool.telefonica.de. [77.183.246.161]) by smtp.gmail.com with ESMTPSA id ci18-20020a170907267200b006f388f6f927sm3901948ejc.1.2022.05.08.03.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 03:35:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87ed232b-ceba-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ij5oGJCJI6PW/a2beKsWQ2NZIiZzUBei2wkeohldNg0=; b=qy1+i0Nrp7bat4BckqAb7DFru/UJobFqUCSHUm86RtfvAfhDDeVdEUFGwgyJcMBNMd ysRMszci8ba/1p6p4KzMGdnlcGqn9uukof7N0Zd3IaK7gq2jLk+XzRgIc/QPdH+DYeAN BitjM5O/pasuYw7o+1OD+1BPYa5jcqWsxOJo1wHXzm1xNTSXOK9rU6mWBWmNF9sEJpRD 6PSzw4TDbbxM9wK1WvAjg+poctNAhSV1ZMdliQMnSGMuC79VgWYQ3C5rljxjljJg0TcP BQcsXHoC5WJJjYEoCmlczUgj84ZX5S+0gj2QwAAlNBftxigkqrhBA1fE06FuEoorMg8C 3sEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ij5oGJCJI6PW/a2beKsWQ2NZIiZzUBei2wkeohldNg0=; b=vnw3xO2nXZ21YA9d+YVZXN81N+ippJT+Mzh6bszzr7BNhngfxNp9ysRYVYtbqv2iDX 3pEz/cAwpK2SqZqc2G8FL6xte3XDnDRaCPr5p+2cD0dlTsbFDqDkdoPwZKuAj0+cp/mW I2Mn3eKe7lXbMFKuG2JSXSrSoS6u0M5vHQjESwF9EBWI4szza1NlG2QWcjaUrv1yOZL3 vR8xFkW/Ot1DcxXie/D32/mnns6TNYANAZg5G/CqRlgqhGksGjnnuW7E3NXPIiksGuye jKRs7DD242GaLU7V3cAGOtz5UuWd5khAO88ZTJzDGcxT63wXNDcDkFF1zSRm6DntqEiq F29w== X-Gm-Message-State: AOAM533OyQGSOZu66B84/sXepdA17pt+tle+Oi3+BYNwX/ch6c3OUnm6 SeH00D/KEnEdpCe7THtBAyvxSOvWPyM3Yw== X-Google-Smtp-Source: ABdhPJz2AmiXieVCbzTsOl+b158iSqM9IPIh52EIWcA9jlMcRkM1lrjwbjNUt1QadDAhCun39mirMQ== X-Received: by 2002:a17:907:7f14:b0:6f4:2a57:e1df with SMTP id qf20-20020a1709077f1400b006f42a57e1dfmr10348828ejc.18.1652006107890; Sun, 08 May 2022 03:35:07 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Bernhard Beschow , Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs), qemu-block@nongnu.org (open list:IDE) Subject: [PATCH 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Date: Sun, 8 May 2022 12:34:32 +0200 Message-Id: <20220508103432.14874-4-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220508103432.14874-1-shentey@gmail.com> References: <20220508103432.14874-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This function was declared in a generic and public header, implemented in a device-specific source file but only used in xen_platform. Given its 'aux' parameter, this function is more xen-specific than piix-specific. Also, the hardcoded magic constants seem to be generic and related to PCIIDEState and IDEBus rather than piix. Therefore, move this function to xen_platform, unexport it, and drop the "piix3" in the function name as well. Signed-off-by: Bernhard Beschow --- hw/i386/xen/xen_platform.c | 49 +++++++++++++++++++++++++++++++++++++- hw/ide/piix.c | 46 ----------------------------------- include/hw/ide.h | 3 --- 3 files changed, 48 insertions(+), 50 deletions(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 72028449ba..124ffeae35 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -26,6 +26,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "hw/ide.h" +#include "hw/ide/pci.h" #include "hw/pci/pci.h" #include "hw/xen/xen_common.h" #include "migration/vmstate.h" @@ -134,6 +135,52 @@ static void pci_unplug_nics(PCIBus *bus) pci_for_each_device(bus, 0, unplug_nic, NULL); } +/* + * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to + * request unplug of 'aux' disks (which is stated to mean all IDE disks, + * except the primary master). + * + * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks + * is simultaneously requested is not clear. The implementation assumes + * that an 'all' request overrides an 'aux' request. + * + * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc + */ +static int pci_xen_ide_unplug(DeviceState *dev, bool aux) +{ + PCIIDEState *pci_ide; + int i; + IDEDevice *idedev; + IDEBus *idebus; + BlockBackend *blk; + + pci_ide = PCI_IDE(dev); + + for (i = aux ? 1 : 0; i < 4; i++) { + idebus = &pci_ide->bus[i / 2]; + blk = idebus->ifs[i % 2].blk; + + if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { + if (!(i % 2)) { + idedev = idebus->master; + } else { + idedev = idebus->slave; + } + + blk_drain(blk); + blk_flush(blk); + + blk_detach_dev(blk, DEVICE(idedev)); + idebus->ifs[i % 2].blk = NULL; + idedev->conf.blk = NULL; + monitor_remove_blk(blk); + blk_unref(blk); + } + } + qdev_reset_all(dev); + return 0; +} + static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) { uint32_t flags = *(uint32_t *)opaque; @@ -147,7 +194,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) { case PCI_CLASS_STORAGE_IDE: - pci_piix3_xen_ide_unplug(DEVICE(d), aux); + pci_xen_ide_unplug(DEVICE(d), aux); break; case PCI_CLASS_STORAGE_SCSI: diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bc1b37512a..9a9b28078e 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -173,52 +173,6 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) } } -/* - * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to - * request unplug of 'aux' disks (which is stated to mean all IDE disks, - * except the primary master). - * - * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks - * is simultaneously requested is not clear. The implementation assumes - * that an 'all' request overrides an 'aux' request. - * - * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc - */ -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) -{ - PCIIDEState *pci_ide; - int i; - IDEDevice *idedev; - IDEBus *idebus; - BlockBackend *blk; - - pci_ide = PCI_IDE(dev); - - for (i = aux ? 1 : 0; i < 4; i++) { - idebus = &pci_ide->bus[i / 2]; - blk = idebus->ifs[i % 2].blk; - - if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { - if (!(i % 2)) { - idedev = idebus->master; - } else { - idedev = idebus->slave; - } - - blk_drain(blk); - blk_flush(blk); - - blk_detach_dev(blk, DEVICE(idedev)); - idebus->ifs[i % 2].blk = NULL; - idedev->conf.blk = NULL; - monitor_remove_blk(blk); - blk_unref(blk); - } - } - qdev_reset_all(dev); - return 0; -} - static void pci_piix_ide_exitfn(PCIDevice *dev) { PCIIDEState *d = PCI_IDE(dev); diff --git a/include/hw/ide.h b/include/hw/ide.h index c5ce5da4f4..60f1f4f714 100644 --- a/include/hw/ide.h +++ b/include/hw/ide.h @@ -8,9 +8,6 @@ ISADevice *isa_ide_init(ISABus *bus, int iobase, int iobase2, int isairq, DriveInfo *hd0, DriveInfo *hd1); -/* ide-pci.c */ -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux); - /* ide-mmio.c */ void mmio_ide_init_drives(DeviceState *dev, DriveInfo *hd0, DriveInfo *hd1); -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Sun May 08 10:59:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 10:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324001.545891 (Exim 4.92) (envelope-from ) id 1nnedM-0006aZ-FU; Sun, 08 May 2022 10:59:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324001.545891; Sun, 08 May 2022 10:59:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnedM-0006aS-CZ; Sun, 08 May 2022 10:59:28 +0000 Received: by outflank-mailman (input) for mailman id 324001; Sun, 08 May 2022 10:59:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnedL-0006aI-1O; Sun, 08 May 2022 10:59:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnedK-0004yp-UZ; Sun, 08 May 2022 10:59:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnedK-00075p-Dy; Sun, 08 May 2022 10:59:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnedK-0000bo-DY; Sun, 08 May 2022 10:59:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C5s3SM+tb8b2mCSt3WYxbXJJdGrtkntqCeIW0lXVRPc=; b=EW7RZwxBooCBkVYrpKcnsZXbAp yggRKePAA0sSFwnD1xUHBlFm4kXEpq4vIqqZ7Bs8/CJOe1BuXSXi4LAJIDHzvqLRkbMKxu5novzge Aoe5o9bDnc6Zpx2E52LABYHT3Nn9/2MbKhGceQ+PqyHhia3Kx8beZUbBt/OA/73c/haQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170237: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 10:59:26 +0000 flight 170237 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170237/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 870 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 11:43:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 11:43:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324009.545902 (Exim 4.92) (envelope-from ) id 1nnfK4-0003Hh-Uf; Sun, 08 May 2022 11:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324009.545902; Sun, 08 May 2022 11:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnfK4-0003Ha-Ro; Sun, 08 May 2022 11:43:36 +0000 Received: by outflank-mailman (input) for mailman id 324009; Sun, 08 May 2022 11:43:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnfK3-0003HQ-E8; Sun, 08 May 2022 11:43:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnfK3-0005qu-BX; Sun, 08 May 2022 11:43:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnfK2-0008Bs-Vx; Sun, 08 May 2022 11:43:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnfK2-0003dh-VU; Sun, 08 May 2022 11:43:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gmDM8IP6Z1sNQ8eudnQoLt5488mQ93E9OJi2tFecKlM=; b=GZSGW/BwR3bEjrK4EMHwc18iYs P0Vy2Fu0ZtGAuxfLKCjBAWfl9SacJKB2tgmDDEVIZhDxsB6GtdrXqttsPfewnHrPmLlSR7P1Y9r0N iJTLECgQg4K9x+LQTPaWAW8M7DNmj1ioAA2q/F+WrUhG2Klj4baoGCjnHmQ+BBBNrALM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170238: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 11:43:34 +0000 flight 170238 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170238/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 871 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 12:44:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 12:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324019.545913 (Exim 4.92) (envelope-from ) id 1nngGP-00018Z-KZ; Sun, 08 May 2022 12:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324019.545913; Sun, 08 May 2022 12:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nngGP-00018S-H7; Sun, 08 May 2022 12:43:53 +0000 Received: by outflank-mailman (input) for mailman id 324019; Sun, 08 May 2022 12:43:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nngGO-00018I-AA; Sun, 08 May 2022 12:43:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nngGO-0006ue-6t; Sun, 08 May 2022 12:43:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nngGN-0001I5-Mu; Sun, 08 May 2022 12:43:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nngGN-0002q7-MT; Sun, 08 May 2022 12:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rqw9afFe6w9uxPA4ss1EiySv1K49gPdb1QS3CuNFmZA=; b=wVte6QVm7GIjryccPgX3Z1p11b BySnIAaYXR53+klUcFBf4/V8qfrWFuuvhMuvl91KALg18cdLKujjy7QfAldbd7SlbQC5ewvfxA7VH ionJBmuHW4EXV2kr9nrCYtDOVBrcP5mRxmysh6PbWnZcdGQFUonoXQnZFmRGtrSkbBC8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170239: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 12:43:51 +0000 flight 170239 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170239/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 872 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 14:11:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 14:11:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324027.545924 (Exim 4.92) (envelope-from ) id 1nnhcl-0001mS-VF; Sun, 08 May 2022 14:11:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324027.545924; Sun, 08 May 2022 14:11:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnhcl-0001mL-Sc; Sun, 08 May 2022 14:11:03 +0000 Received: by outflank-mailman (input) for mailman id 324027; Sun, 08 May 2022 14:11:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnhck-0001mB-AO; Sun, 08 May 2022 14:11:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnhck-0008UW-8h; Sun, 08 May 2022 14:11:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnhcj-0003M6-SE; Sun, 08 May 2022 14:11:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnhcj-0006Rd-Rm; Sun, 08 May 2022 14:11:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aCIZ2/k4miDXPuClym6awATaA2XMLYnPhHNvCqzCDoI=; b=Pp7AWuB+COl5AONg4NmhIWn6zB gUYgDLA3hn1HbwqiCvdw/ivHvJrngojJ2CGXyfTGHN7wwDeqognCQHb2s7sPeP7PWVPndWek9M4Xj /KGRugS+hn2wck6EEzZVXF4kgJ70KQZmmOgojI2/d/v1UHoXOg8AWy+O1LRVI9T4hlJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170240: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 14:11:01 +0000 flight 170240 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170240/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 873 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 14:22:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 14:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324035.545935 (Exim 4.92) (envelope-from ) id 1nnho4-0003Is-1h; Sun, 08 May 2022 14:22:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324035.545935; Sun, 08 May 2022 14:22:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnho3-0003Il-UG; Sun, 08 May 2022 14:22:43 +0000 Received: by outflank-mailman (input) for mailman id 324035; Sun, 08 May 2022 14:22:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnho3-0003Ib-GN; Sun, 08 May 2022 14:22:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnho3-0000GR-Cl; Sun, 08 May 2022 14:22:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnho2-0003ct-QL; Sun, 08 May 2022 14:22:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnho2-0000F0-Pt; Sun, 08 May 2022 14:22:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Yp6u9nIatI6VjY8VvkCyi3aLq4k5lOaUd5CS1jcHhpY=; b=jr6eQpMULmqIIaKNxv68EyZ9Q7 NNqR46ArOx6dzwFOd7S9OzvZE559Qyej1luwGU7CXakiOH9qfJrhRpxHT4V3YUCpAlsOz4pULEsAk VUzGSUB3VIK3LmMOabPVAr9V5i20l0c16Ey/Gh7zgJL04J/DkIOwEi8zt+BDO3THBEdM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170232: tolerable FAIL X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b7e0d8978810b534725e94a321736496928f00a5 X-Osstest-Versions-That: xen=b7e0d8978810b534725e94a321736496928f00a5 From: osstest service owner Date: Sun, 08 May 2022 14:22:42 +0000 flight 170232 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170232/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-xsm 8 xen-boot fail in 170220 pass in 170232 test-amd64-i386-examine-uefi 6 xen-install fail pass in 170220 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 170220 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 170220 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170220 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170220 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170220 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170220 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170220 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170220 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170220 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170220 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170220 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170220 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170220 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170220 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen b7e0d8978810b534725e94a321736496928f00a5 baseline version: xen b7e0d8978810b534725e94a321736496928f00a5 Last test of basis 170232 2022-05-08 05:12:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 08 15:08:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 15:08:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324044.545946 (Exim 4.92) (envelope-from ) id 1nniWS-0007r3-Nr; Sun, 08 May 2022 15:08:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324044.545946; Sun, 08 May 2022 15:08:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniWS-0007qw-K8; Sun, 08 May 2022 15:08:36 +0000 Received: by outflank-mailman (input) for mailman id 324044; Sun, 08 May 2022 15:08:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniWR-0007qm-Bn; Sun, 08 May 2022 15:08:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniWR-000152-A3; Sun, 08 May 2022 15:08:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniWQ-0004by-TN; Sun, 08 May 2022 15:08:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nniWQ-0000rA-Sv; Sun, 08 May 2022 15:08:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0YondWtSVkDxq34JQtqr9cjedmBcQ6EnIO3OpvuZ2rI=; b=iYftPz94BR9A32YGx3gkAuusI2 LUFJOfyTIkblxAupCD9zxtP6O45n/nIsxI3EEQYRay8IL2JT5JOTJXibTMMIFG54ze9F5r612ni65 yl4U40JdA5UzzMfbgdoGSu7MPLW1U4HnjyYsIVmuSFL0291mYe+lBAYnstG8AFo5mxSA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170241: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 15:08:34 +0000 flight 170241 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170241/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 874 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 15:29:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 15:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324054.545956 (Exim 4.92) (envelope-from ) id 1nniqb-0001sr-Ey; Sun, 08 May 2022 15:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324054.545956; Sun, 08 May 2022 15:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniqb-0001sk-CM; Sun, 08 May 2022 15:29:25 +0000 Received: by outflank-mailman (input) for mailman id 324054; Sun, 08 May 2022 15:29:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniqa-0001se-0t for xen-devel@lists.xen.org; Sun, 08 May 2022 15:29:24 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2ed176c-cee3-11ec-a406-831a346695d4; Sun, 08 May 2022 17:29:23 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id s27so14417895ljd.2 for ; Sun, 08 May 2022 08:29:22 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id i38-20020a0565123e2600b0047255d211a5sm1571754lfv.212.2022.05.08.08.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 08:29:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2ed176c-cee3-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=TPJZvkVngAln1O8pkkTy/BND3SA2mso/c6GA+lTw/Es=; b=JJOXkCVjEm954y79H+Sqs1TKNZ9tRegNS8FEP3Ev11lz+ClaPjkLTkKzKlXabaHg+L 9UoqJeOki3gWi+49YrYP9DFYQUbJ/Jg2hcxM7BNzew+1ZX/jWzRY4UwFPlW8K2VpjcHD ofO/eLC+K7gpSWr/8IrN1ermda1P/Xcris8iuZtBo+TGhRhZaVFdeQ52eZ1zYoHj28h0 iM5xIbC+XZtE/gQku3bfGAemJJlYIw612EmzWdBVBhC81DQhZQC6iZPX9h/3arCtvyTH NY3Vooudg17Fpw2r6cEcs6q1baCsnJQvL3lacOmChqQh6Qdf0vvPTSQ4CcCE1KSQE3U4 bauw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=TPJZvkVngAln1O8pkkTy/BND3SA2mso/c6GA+lTw/Es=; b=rEPiP6/zeRye2dsPE+oG8QW4gNdEHqw8Xs7TZjmDhpG5Z7lfYyhIUlqkWW5C4nwQPI DVQXVkXOLRLkXsYcuY5x/QVkl7lLs8T4zYMjR/o31AXqIMmxzZkz90eRSOBhn4tdYq2p PWI4kHBh2b+GLZzR3wclnqKZEQP5Y1A0d/dQWydjM+7CV3N3lfvNQnCKhcwjjqvIsuVl 2AQZItr+kACvRAgGBVH6lsM/mngvJ/xIK5xYkK/aUcpMndW/nDjzx2WkuIFPckrPef5Q fiN9DW4QvVKmog17vN0N6D0K946w1pR7871KE8Awrp17jV6QHbvkiYeGvBFuOpjxsTBL rNiw== X-Gm-Message-State: AOAM532o5RSqp7FASC1gaO7EGOMU8yW9K1BYm+os8Krulzd0H05Ogyz9 SweYpeCIJvg8VZHn3y6dNlg= X-Google-Smtp-Source: ABdhPJwgIA/8OvUSydPmWxcsTzRrElEcZw8tPQ6hPhQLhWxrnBB2uHJXxpRwFOy3jGHb5ZXd24WLYw== X-Received: by 2002:a05:651c:19aa:b0:250:60b9:2301 with SMTP id bx42-20020a05651c19aa00b0025060b92301mr7973492ljb.69.1652023762325; Sun, 08 May 2022 08:29:22 -0700 (PDT) Subject: Re: [PATCH 3/4] libxl: Allocate MMIO params for I2c device and update DT To: Viresh Kumar Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Wei Liu , Juergen Gross , Julien Grall References: From: Oleksandr Message-ID: <35e9f70d-3077-067a-afae-4ad11019f764@gmail.com> Date: Sun, 8 May 2022 18:29:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 05.05.22 10:33, Viresh Kumar wrote: Hello Viresh > This patch allocates Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree. > > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 57 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 55 insertions(+), 2 deletions(-) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index 8132a47a72b6..ea633d6f91df 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -115,6 +115,26 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > } > } > > + for (i = 0; i < d_config->num_i2cs; i++) { > + libxl_device_i2c *i2c = &d_config->i2cs[i]; > + > + i2c->base = alloc_virtio_mmio_base(gc); > + if (!i2c->base) > + return ERROR_FAIL; > + > + i2c->irq = alloc_virtio_mmio_irq(gc); > + if (!i2c->irq) > + return ERROR_FAIL; > + > + if (virtio_irq < i2c->irq) > + virtio_irq = i2c->irq; > + > + virtio_enabled = true; > + > + LOG(DEBUG, "Allocate Virtio MMIO params for I2C: IRQ %u BASE 0x%"PRIx64, > + i2c->irq, i2c->base); > + } > + > if (virtio_enabled) > nr_spis += (virtio_irq - 32) + 1; > > @@ -874,7 +894,7 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, > } > > > -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > +static int _make_virtio_mmio_node(libxl__gc *gc, void *fdt, > uint64_t base, uint32_t irq) NIT: I am not sure the leading underscore in the name would be welcome. I would probably rename it. How about s/_make_virtio_mmio_node/make_virtio_mmio_node_common here and ... > { > int res; > @@ -897,7 +917,35 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > res = fdt_property_interrupts(gc, fdt, &intr, 1); > if (res) return res; > > - res = fdt_property(fdt, "dma-coherent", NULL, 0); > + return fdt_property(fdt, "dma-coherent", NULL, 0); > +} > + > +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > + uint64_t base, uint32_t irq) ... s/make_virtio_mmio_node/make_virtio_mmio_node_simple here or something like that? > +{ > + int res; > + > + res = _make_virtio_mmio_node(gc, fdt, base, irq); > + if (res) return res; > + > + return fdt_end_node(fdt); > +} > + > +static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, > + uint64_t base, uint32_t irq) > +{ > + int res; > + > + res = _make_virtio_mmio_node(gc, fdt, base, irq); > + if (res) return res; > + > + res = fdt_begin_node(fdt, "i2c"); > + if (res) return res; > + > + res = fdt_property_compat(gc, fdt, 1, "virtio,device22"); Please provide a link (in the commit description) to the corresponding Linux device tree binding. I assume it is: Documentation/devicetree/bindings/i2c/i2c-virtio.yaml > + if (res) return res; > + > + res = fdt_end_node(fdt); > if (res) return res; > > res = fdt_end_node(fdt); > @@ -1221,6 +1269,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); > } > > + for (i = 0; i < d_config->num_i2cs; i++) { > + libxl_device_i2c *i2c = &d_config->i2cs[i]; > + FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); > + } > + > if (pfdt) > FDT( copy_partial_fdt(gc, fdt, pfdt) ); > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Sun May 08 15:37:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 15:37:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324060.545967 (Exim 4.92) (envelope-from ) id 1nniyN-0003OI-8K; Sun, 08 May 2022 15:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324060.545967; Sun, 08 May 2022 15:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniyN-0003OB-5k; Sun, 08 May 2022 15:37:27 +0000 Received: by outflank-mailman (input) for mailman id 324060; Sun, 08 May 2022 15:37:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniyL-0003O1-7l; Sun, 08 May 2022 15:37:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniyL-0001Zn-0A; Sun, 08 May 2022 15:37:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nniyK-0005F7-Hp; Sun, 08 May 2022 15:37:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nniyK-000643-HP; Sun, 08 May 2022 15:37:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5tD4h26fsKmds/FssOzm9iR4upoVfhRycTP+RD0PQ+Y=; b=kIV69uAXo06WJEC56fQQXZpI/i vpZbh5MTa1y5qlMeMXGqgfsbq0RVlsR+ZmLiDR28oVzTabEu1ApDxzczL/2AaKlBPgiPJkg+pZRNW LfMnmq6ui942pze0tpaTDpjfp93St+/NRtulMc+mRFO6qVNX+9/ojayVvx+cbj1s5RfA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170242: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 15:37:24 +0000 flight 170242 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170242/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 875 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 16:22:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 16:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324070.545979 (Exim 4.92) (envelope-from ) id 1nnjfx-0000et-JH; Sun, 08 May 2022 16:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324070.545979; Sun, 08 May 2022 16:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjfx-0000em-Ga; Sun, 08 May 2022 16:22:29 +0000 Received: by outflank-mailman (input) for mailman id 324070; Sun, 08 May 2022 16:22:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjfw-0000eg-LI for xen-devel@lists.xen.org; Sun, 08 May 2022 16:22:28 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ce68bdb-ceeb-11ec-8fc4-03012f2f19d4; Sun, 08 May 2022 18:22:27 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id p26so6870986lfh.10 for ; Sun, 08 May 2022 09:22:27 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h22-20020a056512221600b0047255d21100sm1596463lfu.47.2022.05.08.09.22.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 09:22:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ce68bdb-ceeb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ZVN1ItfsN1Qmb4kY3fi0Ttt70ALg1dF1ykX9870ihD8=; b=dDNG3dUceOhEkV44kGi9nIZXY0/tMjWZN4P1Vqbf/4vpX2+sBPjXp5GNH142L6K20S yv/bcuYZn9/5fNjfod5UGKtPWnQLbqJLvoBwEeb6UeVJJAzAQpGA5+QhklFv6Abg0EoT CrtivEmirKy/DM7kB4ncwEyindPV/bdjtTf74fQ8tf7BNvZ4gUiICKv+VlHxZdnZHjZx pH5Rv0MsMMMyDZO16wE+dKm2Ga4oe0s0P05X6iwDVC8R1GgLuj53AgLodOtrzytRWl12 foc52pM/6+5+MZUwAKbC217Wl/blG8LPdoi7s44AJtJN8W1vayV4ssxTUwgeduBWlIcG Y3DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ZVN1ItfsN1Qmb4kY3fi0Ttt70ALg1dF1ykX9870ihD8=; b=hidq+r5/07Vcdcocii9gRlmIL1GpbXa/atO9dTg8hWkar/IABaQsyRAa7Y17qOlMzq juFwLjUxY9MrrGGxIdYR6CrHuLjdQU1BxMLKhHvL6RKwPfbh+ZMtPMtN5nyymcBmQw2D lvbkJYvoCf5FIjMjBMgHokkP2jg9D/G6DXCT866CcALCi5hNkjOZ1Cy06F4M9DIgEEfg WtiyzVYzKWSAlVNmisGQaEackLPWFfbSr3Tr+xr+hHzdSOhQbuorllNpnBX8V3AQxqWw FTy7YzIez2ctep28A7UFgmuRRlhw5quYnVc/BPNmOZarQle9Xzj4l4a/TCnGIgRcrgq+ DNVQ== X-Gm-Message-State: AOAM532FytOMeUCmw7LgcSGuLHnaAuvZPCrZomjewTI4YL23coakQd9H mtdQoGIAfIXtZXVDF5EofoM= X-Google-Smtp-Source: ABdhPJw11DECU6dpnRLgAr1LpmkI7H6nEjzWDh/7TUMAGsDlDUF+qfUabAgUyyqkFgaPpN7+e9jIqw== X-Received: by 2002:a05:6512:a88:b0:473:e080:40e8 with SMTP id m8-20020a0565120a8800b00473e08040e8mr9785101lfu.359.1652026946701; Sun, 08 May 2022 09:22:26 -0700 (PDT) Subject: Re: [PATCH 4/4] libxl: Allocate MMIO params for GPIO device and update DT To: Viresh Kumar Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Wei Liu , Juergen Gross , Julien Grall References: <0b8d38ef26bfa9bc150f3818108ca9e875652e5e.1651734854.git.viresh.kumar@linaro.org> From: Oleksandr Message-ID: Date: Sun, 8 May 2022 19:22:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0b8d38ef26bfa9bc150f3818108ca9e875652e5e.1651734854.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 05.05.22 10:33, Viresh Kumar wrote: Hello Viresh > This patch allocates Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree. > > Signed-off-by: Viresh Kumar > --- > tools/libs/light/libxl_arm.c | 60 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index ea633d6f91df..89e5a1e5780d 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -135,6 +135,26 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > i2c->irq, i2c->base); > } > > + for (i = 0; i < d_config->num_gpios; i++) { > + libxl_device_gpio *gpio = &d_config->gpios[i]; > + > + gpio->base = alloc_virtio_mmio_base(gc); > + if (!gpio->base) > + return ERROR_FAIL; > + > + gpio->irq = alloc_virtio_mmio_irq(gc); > + if (!gpio->irq) > + return ERROR_FAIL; > + > + if (virtio_irq < gpio->irq) > + virtio_irq = gpio->irq; > + > + virtio_enabled = true; > + > + LOG(DEBUG, "Allocate Virtio MMIO params for GPIO: IRQ %u BASE 0x%"PRIx64, > + gpio->irq, gpio->base); > + } > + Looks like, we are going to end up with some duplication in libxl__arch_domain_prepare_config(). This is already a third chunk (the second was in patch #3/4). I would probably consider moving some code to a separate function. Below the non-tested diff (based on the recent V8 patch [1]), how it could look like. I am not sure this is an ideal variant, but rather to demonstrate what I mean. diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 25969e0..6e23c26 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -48,6 +48,23 @@ static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq)      return irq;  } +static int alloc_virtio_mmio_params(libxl__gc *gc, uint64_t *base, uint32_t *irq, +                                    uint64_t *virtio_mmio_base, +                                    uint32_t *virtio_mmio_irq) +{ +    *base = alloc_virtio_mmio_base(gc, virtio_mmio_base); +    if (!*base) +        return ERROR_FAIL; + +    *irq = alloc_virtio_mmio_irq(gc, virtio_mmio_irq); +    if (!*irq) +        return ERROR_FAIL; + +    LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, *irq, *base); + +    return 0; +} +  static const char *gicv_to_string(libxl_gic_version gic_version)  {      switch (gic_version) { @@ -85,25 +102,18 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,          libxl_device_disk *disk = &d_config->disks[i];          if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { -            disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); -            if (!disk->base) -                return ERROR_FAIL; - -            disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); -            if (!disk->irq) -                return ERROR_FAIL; - -            if (virtio_irq < disk->irq) -                virtio_irq = disk->irq; -            virtio_enabled = true; - -            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, -                disk->vdev, disk->irq, disk->base); +            int rc = alloc_virtio_mmio_params(gc, &disk->base, &disk->irq, + &virtio_mmio_base, &virtio_mmio_irq); +            if (rc) +                return rc;          }      } -    if (virtio_enabled) +    if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { +        virtio_irq = virtio_mmio_irq - 1;          nr_spis += (virtio_irq - 32) + 1; +        virtio_enabled = true; +    }      for (i = 0; i < d_config->b_info.num_irqs; i++) {          uint32_t irq = d_config->b_info.irqs[i]; (END) So, if this was done before (in a prereq patch), your new addition here would be just the following: diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 6e23c26..ae64cbd 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -109,6 +109,14 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,          }      } +    for (i = 0; i < d_config->num_gpios; i++) { +        libxl_device_gpio *gpio = &d_config->gpios[i]; +        int rc = alloc_virtio_mmio_params(gc, &gpio->base, &gpio->irq, +                                          &virtio_mmio_base, &virtio_mmio_irq); +        if (rc) +            return rc; +    } +      if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) {          virtio_irq = virtio_mmio_irq - 1;          nr_spis += (virtio_irq - 32) + 1; > if (virtio_enabled) > nr_spis += (virtio_irq - 32) + 1; > > @@ -954,6 +974,41 @@ static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, > return 0; > } > > +static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt, > + uint64_t base, uint32_t irq) > +{ > + int res; > + > + res = _make_virtio_mmio_node(gc, fdt, base, irq); > + if (res) return res; > + > + res = fdt_begin_node(fdt, "gpio"); > + if (res) return res; > + > + res = fdt_property_compat(gc, fdt, 1, "virtio,device29"); Please provide a link (in the commit description) to the corresponding Linux device tree binding. I assume it is: Documentation/devicetree/bindings/gpio/gpio-virtio.yaml > + if (res) return res; > + > + res = fdt_property(fdt, "gpio-controller", NULL, 0); > + if (res) return res; > + > + res = fdt_property_cell(fdt, "#gpio-cells", 2); > + if (res) return res; > + > + res = fdt_property(fdt, "interrupt-controller", NULL, 0); > + if (res) return res; > + > + res = fdt_property_cell(fdt, "#interrupt-cells", 2); > + if (res) return res; > + > + res = fdt_end_node(fdt); > + if (res) return res; > + > + res = fdt_end_node(fdt); > + if (res) return res; > + > + return 0; > +} > + > static const struct arch_info *get_arch_info(libxl__gc *gc, > const struct xc_dom_image *dom) > { > @@ -1269,6 +1324,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, > FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); > } > > + for (i = 0; i < d_config->num_gpios; i++) { > + libxl_device_gpio *gpio = &d_config->gpios[i]; > + FDT( make_virtio_mmio_node_gpio(gc, fdt, gpio->base, gpio->irq) ); > + } > + > for (i = 0; i < d_config->num_i2cs; i++) { > libxl_device_i2c *i2c = &d_config->i2cs[i]; > FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); [1] https://lore.kernel.org/xen-devel/1651598763-12162-3-git-send-email-olekstysh@gmail.com/ -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Sun May 08 16:27:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 16:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324078.545989 (Exim 4.92) (envelope-from ) id 1nnjlD-0001Qr-CA; Sun, 08 May 2022 16:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324078.545989; Sun, 08 May 2022 16:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjlD-0001Qk-9W; Sun, 08 May 2022 16:27:55 +0000 Received: by outflank-mailman (input) for mailman id 324078; Sun, 08 May 2022 16:27:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjlB-0001Qa-PI; Sun, 08 May 2022 16:27:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjlB-00030U-MY; Sun, 08 May 2022 16:27:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnjlB-0006KT-7d; Sun, 08 May 2022 16:27:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnjlB-0006Mk-7A; Sun, 08 May 2022 16:27:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vmsd9uf5W8/xwHAKJjbCjTh5pMdGaWWpr4MaduyQ6xw=; b=bD8tuSAGeClkw39QqU+BVP3ESz shiPlN8s0rTc212bijbdvxBIEbkdtwIF8p/9RMgovT1AI8IQzIxUZc5jkzf1boZDkQevw8yCL+hYR lBdSKFQ4Z/tgsOJINiey3dQVN8RnrDpGRXAyq8+JG8HtnBmHswPGUlZuUjM9/Np/YltU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170243: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 16:27:53 +0000 flight 170243 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170243/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 876 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 17:16:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 17:16:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324087.546001 (Exim 4.92) (envelope-from ) id 1nnkVh-0006fI-2s; Sun, 08 May 2022 17:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324087.546001; Sun, 08 May 2022 17:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkVg-0006fB-W3; Sun, 08 May 2022 17:15:56 +0000 Received: by outflank-mailman (input) for mailman id 324087; Sun, 08 May 2022 17:15:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkVf-0006ey-Bq; Sun, 08 May 2022 17:15:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkVf-0003rX-3E; Sun, 08 May 2022 17:15:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkVe-0007MH-Ls; Sun, 08 May 2022 17:15:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnkVe-0007oX-LQ; Sun, 08 May 2022 17:15:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rvcj5aeRYNF1e5UoWko7oJaGca0JwANVLH/U33FHZnI=; b=0WkAlNLAe6TYI+a+O/zhokVJuc 4z4D27twfFrLb/ICPXrlxlxNUogVAO1KldVF7vV2ysI2wMIKzf/hY3e+tPy1CDVT57IqceKh+idn4 YoeVYJYfcZKV4dlXW6XjpTZiRWGNPDeOtqBmSj5744D6RozwwOOCEfLTIZ07wgRqoTY8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170244: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 17:15:54 +0000 flight 170244 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170244/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 877 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 17:29:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 17:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324095.546012 (Exim 4.92) (envelope-from ) id 1nnkiK-0008Gk-9g; Sun, 08 May 2022 17:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324095.546012; Sun, 08 May 2022 17:29:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkiK-0008Gd-4T; Sun, 08 May 2022 17:29:00 +0000 Received: by outflank-mailman (input) for mailman id 324095; Sun, 08 May 2022 17:28:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnkiI-0008GX-Lp for xen-devel@lists.xen.org; Sun, 08 May 2022 17:28:58 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57352646-cef4-11ec-a406-831a346695d4; Sun, 08 May 2022 19:28:57 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id h29so20321442lfj.2 for ; Sun, 08 May 2022 10:28:57 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t16-20020a056512069000b0047255d2114bsm1608206lfe.122.2022.05.08.10.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 May 2022 10:28:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57352646-cef4-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=WRz9xv0fmBEp2JAlnucnVl6yJb0kOq13ngn6JVHazMU=; b=qqmzexPzwBfSQ0gHfvXngAz0XgYnIsFd0ZpS8j0ckvknBpaph4fQQeGRX5+UHHnOOT ulQUuh8LnR9ZL3JN/ECdr9b7UvB3zEsDxuFvAnFWV0N6yXzOEJ5xE5pX2yAvIIpyrxcH VA1Oo0Mfxu3y44l5XQzwMNtjhIsDsHhwP+m5DAs6cDw3YCxYDQaOe/3mURcbEpW3GG2S eZQzHaJhsq0vNlOYmOXGDrcRn+Hf2AvphM8hri/mtV08Ignc8n+dNUEEw8o6mAVzCsYn 7rDlBv+mPdD8emlbh3ZggjELeYKG64QCKH4qmXXRJes/gUf+AXwvhOyWM+w8VGNb3LrH z+fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WRz9xv0fmBEp2JAlnucnVl6yJb0kOq13ngn6JVHazMU=; b=g2pRFOf3BO8JEMHv5z4i4pfwsBkySPaxCzYw0EpfxfQsQsVjNFTWoPfFKZgvClJtsn R2PbDydgm+vw60xTmcWlInvHTECo7YSI4XDNoiZUX3aUqbfZik5j1NnVJSUFtJ7sg3Rn GHu0Lkg4FkpkAQ+p5qjE0neDNe3GPsn6B5EgStC/uUMtnWZnLQayQeRRoJsb7+Bgbza8 bYPWmCPXnkCB/H5STZWuepcQkd1RxesDR+FO+E6VfYGuiv0z5UY0tzlnpiIY5Dm+aKKV H2DMRg/Oc+WXVvgfVRlnWYIKlqkDBXsW+ikJUs4IoW/wEQxVnoA1oa1M2NS1M9hF6yy5 kpcg== X-Gm-Message-State: AOAM5326bDcM4NTFS0/EajgbeD28ikQtXurCtLadS62NXD+pbV59RtfX w63/yzC9OITZuOsrV7Kt/hQ= X-Google-Smtp-Source: ABdhPJxwf77LK5q/yL0rfV1/j/98QqkCxFE1iqZP+RaBYaJ18lxv/E5854RYROvcrwIlZz2ZTNlHHg== X-Received: by 2002:a05:6512:2398:b0:473:9cf5:1750 with SMTP id c24-20020a056512239800b004739cf51750mr9934073lfv.300.1652030936704; Sun, 08 May 2022 10:28:56 -0700 (PDT) Subject: Re: [PATCH 0/4] Virtio toolstack support for I2C and GPIO on Arm To: Viresh Kumar Cc: xen-devel@lists.xen.org, Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Wei Liu , Juergen Gross , Julien Grall References: From: Oleksandr Message-ID: Date: Sun, 8 May 2022 20:28:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 05.05.22 10:33, Viresh Kumar wrote: Hello Viresh > Hello, > > This patchset adds toolstack support for I2C and GPIO virtio devices. This is > inspired from the work done by Oleksandr for the Disk device [1]. Great work! > > The first two patches can be applied right away, but the last two need > Oleksandr's series [1] to be applied first. I have reviewed patches #3/4 and #4/4 (libxl_arm.c changes). FYI, I have recently pushed V8 of my series [1], which changes the code in libxl_arm.c a bit. > > This is developed as part of Linaro's Project Stratos, where we are working > towards Hypervisor agnostic Rust based backend [2]. > > I must accept that I am a beginner to Xen and developed this patchset based on > support for existing devices like Disk or Keyboard. There may be bits which I > missed or the one I added which aren't really required. > > Thanks. > > -- > Viresh > > Viresh Kumar (4): > libxl: Add support for Virtio I2C device > libxl: Add support for Virtio GPIO device > libxl: Allocate MMIO params for I2c device and update DT > libxl: Allocate MMIO params for GPIO device and update DT > > tools/golang/xenlight/helpers.gen.go | 220 ++++++++++++++++++++ > tools/golang/xenlight/types.gen.go | 54 +++++ > tools/include/libxl.h | 64 ++++++ > tools/include/libxl_utils.h | 6 + > tools/libs/light/Makefile | 2 + > tools/libs/light/libxl_arm.c | 117 ++++++++++- > tools/libs/light/libxl_create.c | 26 +++ > tools/libs/light/libxl_dm.c | 34 +++- > tools/libs/light/libxl_gpio.c | 236 ++++++++++++++++++++++ > tools/libs/light/libxl_i2c.c | 236 ++++++++++++++++++++++ > tools/libs/light/libxl_internal.h | 2 + > tools/libs/light/libxl_types.idl | 52 +++++ > tools/libs/light/libxl_types_internal.idl | 2 + > tools/ocaml/libs/xl/genwrap.py | 2 + > tools/ocaml/libs/xl/xenlight_stubs.c | 2 + > tools/xl/Makefile | 2 +- > tools/xl/xl.h | 6 + > tools/xl/xl_cmdtable.c | 30 +++ > tools/xl/xl_gpio.c | 143 +++++++++++++ > tools/xl/xl_i2c.c | 143 +++++++++++++ > tools/xl/xl_parse.c | 160 +++++++++++++++ > tools/xl/xl_parse.h | 2 + > tools/xl/xl_sxp.c | 4 + > 23 files changed, 1540 insertions(+), 5 deletions(-) > create mode 100644 tools/libs/light/libxl_gpio.c > create mode 100644 tools/libs/light/libxl_i2c.c > create mode 100644 tools/xl/xl_gpio.c > create mode 100644 tools/xl/xl_i2c.c [1] https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Sun May 08 18:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 18:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324101.546023 (Exim 4.92) (envelope-from ) id 1nnm1Q-0000TG-6t; Sun, 08 May 2022 18:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324101.546023; Sun, 08 May 2022 18:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnm1Q-0000St-3E; Sun, 08 May 2022 18:52:48 +0000 Received: by outflank-mailman (input) for mailman id 324101; Sun, 08 May 2022 18:52:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnm1O-0000Si-HI; Sun, 08 May 2022 18:52:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnm1O-0005Yg-Eo; Sun, 08 May 2022 18:52:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnm1N-0002sK-W5; Sun, 08 May 2022 18:52:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnm1N-0000U5-Va; Sun, 08 May 2022 18:52:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=84IhuXfxf1NB2f/458O7AA4yBRzf05an+Sq7zTTEWRs=; b=0QuNmHIx7l5t0SRmlTCFkVCIAH /tiZdfrUzje+mNpIYPZZPcm2SriAyGeFSpaj4uMkEs7sMIFTJ/uwEcfP+t5oqVD0t42dJcFR+g9ZB kqm13rD9mBfuquyayXl1Q1FkefFq96L4+NsW4csRml4/RZlEZxTcOhSDWCMTyJgXqzEg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170246: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 18:52:45 +0000 flight 170246 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 878 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 19:50:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 19:50:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324110.546034 (Exim 4.92) (envelope-from ) id 1nnmug-00064t-Ln; Sun, 08 May 2022 19:49:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324110.546034; Sun, 08 May 2022 19:49:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnmug-00064m-Iy; Sun, 08 May 2022 19:49:54 +0000 Received: by outflank-mailman (input) for mailman id 324110; Sun, 08 May 2022 19:49:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnmuf-00064c-Nn; Sun, 08 May 2022 19:49:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnmuf-0006aq-I7; Sun, 08 May 2022 19:49:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnmuf-000525-A0; Sun, 08 May 2022 19:49:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnmuf-0003EZ-9Z; Sun, 08 May 2022 19:49:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VcBXWPKlEZ62recrOdRl12wWRSyxzapikJSlnoz7xrY=; b=HKVC+kxzIZiNPyKfYThfLQXKVc VM+V2wnTGHlOJM1mN5T70mhrxDDLYt9pQppEkBaO15XaZe5gufItm9hLw0edq07tS6F/fnMl/yxEy HGT1PxqbXe1eDbSoSxaG154GzFIfVsjTxZi1e3aUyKxRffzkM1gPcWeikiCVKbQUff8g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170247: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 19:49:53 +0000 flight 170247 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 879 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 20:45:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 20:45:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324120.546045 (Exim 4.92) (envelope-from ) id 1nnnm9-0003wU-Sm; Sun, 08 May 2022 20:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324120.546045; Sun, 08 May 2022 20:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnnm9-0003wN-Pm; Sun, 08 May 2022 20:45:09 +0000 Received: by outflank-mailman (input) for mailman id 324120; Sun, 08 May 2022 20:45:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnnm8-0003wD-VW; Sun, 08 May 2022 20:45:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnnm8-0007ma-Rt; Sun, 08 May 2022 20:45:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnnm8-0006iN-CN; Sun, 08 May 2022 20:45:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnnm8-0007ZK-Br; Sun, 08 May 2022 20:45:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Wh4zqylkqngtFUjL9PkADjO07npIIgrKLfdbEzXZiHk=; b=OWEZ4nxUsJvaK0zupRRC2md8tC yeFeCNkpwY5IUj5uicaA6mXheQmlpc4Z9H0UDZnvQ8AeUnaB7UC3ExjZplLNPjNM96aYw1DQ6WcyG ws5Rt8U3N0YAN5iU3pfLoWLG43uvuKjMQIqwVQ/PD/ANCTPuKPS2pi/H9ufSXzj1LjhM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170248: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 20:45:08 +0000 flight 170248 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170248/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 880 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 22:01:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 22:01:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324128.546055 (Exim 4.92) (envelope-from ) id 1nnoxc-0003uG-Fc; Sun, 08 May 2022 22:01:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324128.546055; Sun, 08 May 2022 22:01:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnoxc-0003u9-D1; Sun, 08 May 2022 22:01:04 +0000 Received: by outflank-mailman (input) for mailman id 324128; Sun, 08 May 2022 22:01:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnoxa-0003tt-NG; Sun, 08 May 2022 22:01:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnoxa-0000d2-MA; Sun, 08 May 2022 22:01:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnoxa-0000VP-BV; Sun, 08 May 2022 22:01:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnoxa-0008Fu-B3; Sun, 08 May 2022 22:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aN99gI6UCrSyeVXC3/g87GpRCFfFf9bmOH7XgwC8MQw=; b=57oL0oQIIn9cr8+sUO/5ijiFQU MKXexhGUEVTfHut8SizTqvLHVP7PFDB1V0YgYypTfrH7xX+cG5W9cmtKWtIucYKwwT3lWx8G/gEeU STCRV/TbvHPWBxveOMB33K+SIiz0pAFjdRHpsI4SCaFnHRcWGhl8Fj75hNs2twQYbDaQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170249: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 22:01:02 +0000 flight 170249 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170249/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 881 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 22:39:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 22:39:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324136.546067 (Exim 4.92) (envelope-from ) id 1nnpYw-0007Zp-Hr; Sun, 08 May 2022 22:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324136.546067; Sun, 08 May 2022 22:39:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpYw-0007Zi-D2; Sun, 08 May 2022 22:39:38 +0000 Received: by outflank-mailman (input) for mailman id 324136; Sun, 08 May 2022 22:39:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpYu-0007ZY-Di; Sun, 08 May 2022 22:39:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpYu-0001FW-Bs; Sun, 08 May 2022 22:39:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpYt-0001eK-W0; Sun, 08 May 2022 22:39:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnpYt-0000rb-VT; Sun, 08 May 2022 22:39:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n9cHgLnlVAHTPDQtwajVQNdaYBazObxMnfVjmXjb5Jg=; b=5qKlcgHIvdur1N5inivQ57K4g7 nTxS5xjkWmEOqzLqbNoTJ/e++Vbw8rzHiA+EfrAijMFq5jl4GBCIryv+EUgtjYRJAHjC5eKhi+NX/ qIBm/AzXXla7Yu0hUWlTkYkAGlOlTkoNRZrNlwy74wijpRgvzV50st/kydAdi/9YkFTI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170250: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 22:39:35 +0000 flight 170250 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170250/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 882 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 44 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 08 22:53:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 22:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324145.546078 (Exim 4.92) (envelope-from ) id 1nnpm8-0001Zf-SZ; Sun, 08 May 2022 22:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324145.546078; Sun, 08 May 2022 22:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpm8-0001ZY-Pt; Sun, 08 May 2022 22:53:16 +0000 Received: by outflank-mailman (input) for mailman id 324145; Sun, 08 May 2022 22:53:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpm7-0001ZO-Rw; Sun, 08 May 2022 22:53:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpm7-0001T2-Nu; Sun, 08 May 2022 22:53:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnpm7-0001ys-7d; Sun, 08 May 2022 22:53:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnpm7-0005yI-79; Sun, 08 May 2022 22:53:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i0fniGFIiIn99FT3SBfRfwqEJh9ID0AMQBxO1eRHXM8=; b=U/W4N1fRwH6yh72d2Dd17AEVXG iqH8sUaZuN/uqP1Ohfb8yiNKPVvBncRsBNyxNKyHxa6J50ihdq1Or44fXt20Bd60bKqk0+mELMrBy moDEIowszDuy9cKS1rR0QVDnrJ3arMCEvczvZa/TvfjjFNo1dhp3QA/P8x+EkLGC8cog=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170245: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=379c72654524d97081f8810a0e4284a16f78a25e X-Osstest-Versions-That: linux=30c8e80f79329617012f07b09b70114592092ea4 From: osstest service owner Date: Sun, 08 May 2022 22:53:15 +0000 flight 170245 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170245/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170221 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170221 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170221 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170221 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170221 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170221 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170221 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170221 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 379c72654524d97081f8810a0e4284a16f78a25e baseline version: linux 30c8e80f79329617012f07b09b70114592092ea4 Last test of basis 170221 2022-05-07 18:41:40 Z 1 days Testing same since 170245 2022-05-08 17:39:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ajit Kumar Pandey Andy Chi Charles Keepax Chengfeng Ye ChiYuan Huang Codrin Ciubotariu Denis Efremov Hui Wang Jakob Koschel Jerome Brunet Linus Torvalds Mark Brown Neil Armstrong Niels Dossche Olivier Moysan Pierre-Louis Bossart Takashi Iwai Takashi Sakamoto Willy Tarreau Zihao Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 30c8e80f7932..379c72654524 379c72654524d97081f8810a0e4284a16f78a25e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 08 23:10:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 08 May 2022 23:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324153.546089 (Exim 4.92) (envelope-from ) id 1nnq28-0003JJ-9d; Sun, 08 May 2022 23:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324153.546089; Sun, 08 May 2022 23:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnq28-0003JC-6h; Sun, 08 May 2022 23:09:48 +0000 Received: by outflank-mailman (input) for mailman id 324153; Sun, 08 May 2022 23:09:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnq27-0003J2-IC; Sun, 08 May 2022 23:09:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnq27-0001li-Fc; Sun, 08 May 2022 23:09:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnq27-0002KL-42; Sun, 08 May 2022 23:09:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnq27-0000wp-3W; Sun, 08 May 2022 23:09:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b7AX/WlLM6DLloTuCNwr/SXsQEMFGCNHnAFA0yd1Co4=; b=CI8tVXlO6O4cCJKHFT8YfC6nme IqhY361GkYzA7djfhwP2mBf9FknW48f6/g+4JOzaziGrxectV2J0IzS9MSF8w3uXYR8iyQiNUyWIv B6vMM2vbtK50/4EGXHv12Uw2J+7CWIVrhp9/vrLJxyi6q5YEBx3Re0DUTV+eOlNxvY9o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170251: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 08 May 2022 23:09:47 +0000 flight 170251 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170251/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 883 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 45 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 00:27:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 00:27:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324161.546100 (Exim 4.92) (envelope-from ) id 1nnrEk-0003xc-VF; Mon, 09 May 2022 00:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324161.546100; Mon, 09 May 2022 00:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrEk-0003xV-QY; Mon, 09 May 2022 00:26:54 +0000 Received: by outflank-mailman (input) for mailman id 324161; Mon, 09 May 2022 00:26:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrEj-0003xI-Js; Mon, 09 May 2022 00:26:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrEj-0003fh-Hy; Mon, 09 May 2022 00:26:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrEj-0005sw-8M; Mon, 09 May 2022 00:26:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnrEj-0006d4-7q; Mon, 09 May 2022 00:26:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rdUSIFMHAFqzzmG7Wgo7Ikr+fja6Xg8Sc7d9jnPHvBk=; b=3NbXYZWL2OCy1wczgyqi+hIe0w Onl9680wS0DxjPORgdhv3YQOkA/Z3sLtH1DD07iRSff+5b3er9x58MBou38xIqehkRmgt6n90W24/ +jfql8spkzpwzNdTyh0L0n94HxW8AzoFwvDvhQdgjmojH6JbkYFJrJnbUs2oiSx60x00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170253: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 00:26:53 +0000 flight 170253 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170253/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 884 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 46 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 01:06:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 01:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324170.546111 (Exim 4.92) (envelope-from ) id 1nnrrC-0006gW-4d; Mon, 09 May 2022 01:06:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324170.546111; Mon, 09 May 2022 01:06:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrrC-0006gP-0J; Mon, 09 May 2022 01:06:38 +0000 Received: by outflank-mailman (input) for mailman id 324170; Mon, 09 May 2022 01:06:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrrB-0006gF-A8; Mon, 09 May 2022 01:06:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrrB-0002Bu-7V; Mon, 09 May 2022 01:06:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnrrA-0007Q4-TB; Mon, 09 May 2022 01:06:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnrrA-0001Hi-Sg; Mon, 09 May 2022 01:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dvEieqJykMop6kLMi2j2RMTqw8ln/DwbPs4/WpDJOHc=; b=jmb6/7FVkcQE3jMV/uVklRPHra oKMDbd5Og6Qfu6gATKxfpHgyR5ZctbE9IZ/YxytcJnGHCCAJcw8/ahoHqzng9JcB6fXFi89mz9WGm QtrJVB46KmboPnAacEyLKXnZ81SLQCWKW6OWugqlbJpfyA/RpAV9OP9gausJaIeN9ibk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170254: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 01:06:36 +0000 flight 170254 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170254/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 68 days 885 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 47 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 01:57:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 01:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324178.546122 (Exim 4.92) (envelope-from ) id 1nnseT-0003oI-Tx; Mon, 09 May 2022 01:57:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324178.546122; Mon, 09 May 2022 01:57:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnseT-0003oB-Qs; Mon, 09 May 2022 01:57:33 +0000 Received: by outflank-mailman (input) for mailman id 324178; Mon, 09 May 2022 01:57:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnseS-0003nz-Pk; Mon, 09 May 2022 01:57:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnseS-000342-LI; Mon, 09 May 2022 01:57:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnseS-0000dl-33; Mon, 09 May 2022 01:57:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnseS-00022r-2W; Mon, 09 May 2022 01:57:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EOb+WtvtYpwQqCFjn9LLTzLf31T6cJDhegjpIyvtx7w=; b=a6azt6UgGM/UINEE6ofPrOOhZP pG+aEb1WM9Y+HGmk8O6tKxEs5gwtNHrUBY6MnTBSjk+ze8luUUzrN5CSJKyF+MWK1tGXnWVDngXB8 q7paAHh/2pXeTsKSBC/erSw98f0Ww4ouHVCN3y85yYBsPHD371f6Z0Ic1W+2TSGpyiog=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170255: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 01:57:32 +0000 flight 170255 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170255/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 886 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 48 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 03:09:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 03:09:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324186.546133 (Exim 4.92) (envelope-from ) id 1nntlo-0003fb-2T; Mon, 09 May 2022 03:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324186.546133; Mon, 09 May 2022 03:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nntln-0003fU-W1; Mon, 09 May 2022 03:09:11 +0000 Received: by outflank-mailman (input) for mailman id 324186; Mon, 09 May 2022 03:09:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nntln-0003fK-5U; Mon, 09 May 2022 03:09:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nntln-0005CW-17; Mon, 09 May 2022 03:09:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nntlm-0003oh-LO; Mon, 09 May 2022 03:09:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nntlm-0003Pb-Kt; Mon, 09 May 2022 03:09:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zuWJiW9fWdJdUQjiKuhLIW5ipVDVwF19Iq6ao3p9XsY=; b=GRpI2GhmX4B0s7tmXwCekTFAXR Q/UGZXczCpd72AhZtJH5QJPisUm7Fd5rdikLV4eRBJE0y5SvG+QUdLFN+vcR9Dq3t9U8rS5M/JYIl aJ5kIM+yruD04hEjKe1k3JCpthGk9yr1MdNlaV6CJo16ktZa2jX/paq9yyuLcHywb2uI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170258: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=247a0fc65e5deea58a1486a0e506bc38fd9bed6b X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 03:09:10 +0000 flight 170258 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170258/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 247a0fc65e5deea58a1486a0e506bc38fd9bed6b baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 887 attempts Testing same since 170178 2022-05-06 09:40:34 Z 2 days 49 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6086 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 03:33:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 03:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324194.546144 (Exim 4.92) (envelope-from ) id 1nnu8b-00070r-1A; Mon, 09 May 2022 03:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324194.546144; Mon, 09 May 2022 03:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnu8a-00070k-U5; Mon, 09 May 2022 03:32:44 +0000 Received: by outflank-mailman (input) for mailman id 324194; Mon, 09 May 2022 03:32:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnu8Z-00070a-VJ; Mon, 09 May 2022 03:32:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnu8Z-0005Zr-SG; Mon, 09 May 2022 03:32:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnu8Z-0004rs-Ea; Mon, 09 May 2022 03:32:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnu8Z-0006ux-E7; Mon, 09 May 2022 03:32:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cqHySbN6U6ichO6XW1lnCXd85CubRtU742+YN6DpFHU=; b=rLFV/RkDwFKJglx+pnKkN7r1HB oWc6S/Re0qOohYoBLBBxbKF0a8AO6jbQgAv/wcae69/ZJSIhpB7l370pjzAiy74AJv7p9rubA8u1B 6AykkSBV9JoEXV2gfuFgU0u+DSwfC1k8qWkAKkyLEEu4Ra1r9NfgFHfOY2HtcNJUNhc4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170259: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=29ae55a0b8194fef2e769f2882297aa601b4777a X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 03:32:43 +0000 flight 170259 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170259/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 29ae55a0b8194fef2e769f2882297aa601b4777a baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 888 attempts Testing same since 170259 2022-05-09 03:12:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6163 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 05:26:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 05:26:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324205.546155 (Exim 4.92) (envelope-from ) id 1nnvub-0002DM-HI; Mon, 09 May 2022 05:26:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324205.546155; Mon, 09 May 2022 05:26:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnvub-0002DF-EO; Mon, 09 May 2022 05:26:25 +0000 Received: by outflank-mailman (input) for mailman id 324205; Mon, 09 May 2022 05:26:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnvua-0002D5-6a; Mon, 09 May 2022 05:26:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnvua-0008Fn-4G; Mon, 09 May 2022 05:26:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnvuZ-0003Wr-T0; Mon, 09 May 2022 05:26:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnvuZ-0000EJ-SW; Mon, 09 May 2022 05:26:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=prrnIrPLEqY4o/p4K2vFN1Y6tY1WyU0LULiPquw3WWw=; b=VNVGeGsn55kJBXOX7AE1qzoULH wivG9lj0TacJgMsoylJmHqQKD6+gE8awYuWZO0X7bWm65lbqsxSZ62qEkf3ZA6XQdkP7+lawuiclo NRFRrE8ZAkZbkMzP7L0Z5ZkpSj1sZnjNXoNqnTxjC8mldiP2KIUqm5RMMTrnvy2obY7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170260: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=29ae55a0b8194fef2e769f2882297aa601b4777a X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 05:26:23 +0000 flight 170260 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170260/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 29ae55a0b8194fef2e769f2882297aa601b4777a baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 889 attempts Testing same since 170259 2022-05-09 03:12:13 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6163 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 06:18:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 06:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324213.546166 (Exim 4.92) (envelope-from ) id 1nnwib-0007sx-FB; Mon, 09 May 2022 06:18:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324213.546166; Mon, 09 May 2022 06:18:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwib-0007sq-Bs; Mon, 09 May 2022 06:18:05 +0000 Received: by outflank-mailman (input) for mailman id 324213; Mon, 09 May 2022 06:18:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwia-0007sk-Fu for xen-devel@lists.xenproject.org; Mon, 09 May 2022 06:18:04 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c80371db-cf5f-11ec-a406-831a346695d4; Mon, 09 May 2022 08:18:03 +0200 (CEST) Received: by verein.lst.de (Postfix, from userid 2407) id EFE0668AFE; Mon, 9 May 2022 08:18:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c80371db-cf5f-11ec-a406-831a346695d4 Date: Mon, 9 May 2022 08:18:00 +0200 From: Christoph Hellwig To: Stefano Stabellini Cc: Boris Ostrovsky , Christoph Hellwig , jgross@suse.com, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Rahul Singh Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm Message-ID: <20220509061800.GC17190@lst.de> References: <20220423171422.1831676-1-hch@lst.de> <20220428132737.GA13999@lst.de> <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Apr 28, 2022 at 03:49:53PM -0700, Stefano Stabellini wrote: > On one hand, Linux doesn't boot on a platform without this fix. On the > other hand, I totally see that this patch could introduce regressions on > x86 so I think it is fair that we are careful with it. > > >From my point of view, it might be better to wait for 5.19 and mark it > as backport. Sounds good to me. Based on the other mails I assume you want me to take it through the dma-mapping tree, so I will do that tomorrow unless I hear otherwise. From xen-devel-bounces@lists.xenproject.org Mon May 09 06:31:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 06:31:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324223.546177 (Exim 4.92) (envelope-from ) id 1nnwvI-0001pi-N5; Mon, 09 May 2022 06:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324223.546177; Mon, 09 May 2022 06:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwvI-0001pb-Ib; Mon, 09 May 2022 06:31:12 +0000 Received: by outflank-mailman (input) for mailman id 324223; Mon, 09 May 2022 06:31:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwvG-0001pV-7a for xen-devel@lists.xenproject.org; Mon, 09 May 2022 06:31:10 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99ca3c03-cf61-11ec-a406-831a346695d4; Mon, 09 May 2022 08:31:06 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnwv5-00Cgzc-Gk; Mon, 09 May 2022 06:30:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99ca3c03-cf61-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=o+pQ2wGG2YVWS04fCC8y8+WAIR OMv/pg4hxMPTD5mPiCT91kL+mAyrLelwTcwQ07UY9WfUCxctEn/0fZ+K6CnVCzuGg3JC3G8zkg+Yl 6WlVZyz4KU4W7nzIiD1myHbqCRByD7J59wpGzBohi7UMmJ5MPQjRWTNe9M1IHLbNSe1747n8AA4TF 4bM6O/7hSbCgH42ZfLYGmyFALaHZvcqYXWJPWpwkU6r87XSNhTpH3vjhzuBCn/StFI5LgwFkUXzYV PQIFWOA940r35Nxv7DVXtr6tXAEI9VQfACQXdaRWXH0xCOPX4/txiFZADLOBqCBQf1F46BPDj/iQZ ZIIwvI6g==; Date: Sun, 8 May 2022 23:30:59 -0700 From: Christoph Hellwig To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: Re: [PATCH v3 1/2] kernel: add platform_has() infrastructure Message-ID: References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504155703.13336-2-jgross@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looks good: Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Mon May 09 06:32:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 06:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324231.546188 (Exim 4.92) (envelope-from ) id 1nnwwL-0002Mp-0Z; Mon, 09 May 2022 06:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324231.546188; Mon, 09 May 2022 06:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwwK-0002Mi-Tn; Mon, 09 May 2022 06:32:16 +0000 Received: by outflank-mailman (input) for mailman id 324231; Mon, 09 May 2022 06:32:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnwwI-0001pV-T4 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 06:32:14 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3123db9-cf61-11ec-a406-831a346695d4; Mon, 09 May 2022 08:32:14 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnwve-00Ch7b-DM; Mon, 09 May 2022 06:31:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3123db9-cf61-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=jDAHALn3z0Emv+RGmX479eTK4G TkPNPwyX6ucjzOI85+8H3QueAzXGbLUYDfEaUHHVsbZU/e0hr1Lz5vXKUYhR7P+cl+7ZL12iDj6Y5 OkOaOgHGZDQCx4NrGi7cbp/uecHLpDTMZqNd54+eNuluCp93IsXuau33dF9WDqqvECfh/pBWHktN5 H64KFA8elJFZUtTvkUZPQfodC94Gu76Tv121FTsCCfmYmcht3AXwhyx1oM48WCaP3EOI2k4IIGMA4 DAfYiU10yoTxDec4sp6qN+OfqhCT06RbgLPuydxhAf7Na+/KLsXuOktEYqlZSkyuPfaXFRejdTgEE 8bFe3qVQ==; Date: Sun, 8 May 2022 23:31:34 -0700 From: Christoph Hellwig To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: Re: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access() Message-ID: References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504155703.13336-3-jgross@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looks good: Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Mon May 09 07:57:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 07:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324243.546199 (Exim 4.92) (envelope-from ) id 1nnyGv-0002NN-63; Mon, 09 May 2022 07:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324243.546199; Mon, 09 May 2022 07:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyGv-0002NG-32; Mon, 09 May 2022 07:57:37 +0000 Received: by outflank-mailman (input) for mailman id 324243; Mon, 09 May 2022 07:57:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyGt-0002N6-Nb; Mon, 09 May 2022 07:57:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyGt-0002Qg-Lg; Mon, 09 May 2022 07:57:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyGt-0005Hu-7y; Mon, 09 May 2022 07:57:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nnyGt-0004Un-59; Mon, 09 May 2022 07:57:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BFxPUdMfTq0yhObwQatsyIcJ45OomePjZ8Z40fIaN48=; b=5P2Z21wMt1yiqi8+SLWqshLMDX evOCGhsm4f01mgpHjPnuqq1esg963tIE/waYRc+SGBxFtDuzTCUVT5OIP8dtD+i8YgIK53Crz4UAq B7rDkC97PEihUyUMREI1KMrFwVNicUtXNifdS8XQkN9rP6uwgjC8crqX5spZrDhIz5Kc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170252: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a X-Osstest-Versions-That: linux=379c72654524d97081f8810a0e4284a16f78a25e From: osstest service owner Date: Mon, 09 May 2022 07:57:35 +0000 flight 170252 linux-linus real [real] flight 170262 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170252/ http://logs.test-lab.xenproject.org/osstest/logs/170262/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170262-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170245 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170245 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170245 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170245 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170245 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170245 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170245 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170245 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a baseline version: linux 379c72654524d97081f8810a0e4284a16f78a25e Last test of basis 170245 2022-05-08 17:39:51 Z 0 days Testing same since 170252 2022-05-08 23:11:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: André Almeida Borislav Petkov Fenghua Yu Filipe Manana Guenter Roeck Haren Myneni Helge Deller John Stultz Josh Poimboeuf Julia Lawall Kajol Jain Kurt Kanzenbach Linus Torvalds Michael Ellerman Sumit Semwal Thomas Gleixner Thomas Pfaff Zhangfei Gao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 379c72654524..c5eb0a61238d c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 09 08:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324258.546209 (Exim 4.92) (envelope-from ) id 1nnyLT-0004OT-Ac; Mon, 09 May 2022 08:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324258.546209; Mon, 09 May 2022 08:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyLT-0004OM-7g; Mon, 09 May 2022 08:02:19 +0000 Received: by outflank-mailman (input) for mailman id 324258; Mon, 09 May 2022 08:02:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyLR-0004OG-PL for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:02:17 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57929c5f-cf6e-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 10:02:16 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id o12-20020a1c4d0c000000b00393fbe2973dso10280646wmh.2 for ; Mon, 09 May 2022 01:02:16 -0700 (PDT) Received: from [10.7.237.11] (54-240-197-227.amazon.com. [54.240.197.227]) by smtp.gmail.com with ESMTPSA id s6-20020a1cf206000000b003942a244f3fsm16317179wmc.24.2022.05.09.01.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 May 2022 01:02:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57929c5f-cf6e-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mqtL2gCCHPlBEBtIXSoW8gskUPGT59zht12YCRBFAJg=; b=TnEceOlku5O2LhN349fYQZpDLct6g/bOMC3cK32D2a9yyHC/wR8kQ3c2Ti3DLbWnwI qFf1g2/juO84NhnFgiirKUCWy90RQErkKtT7JcHiUdjqxt51X2vAVRi0IrF84GWP0Efr JnUz2vvfiVEWAiTpacxPdR/w/IKHOmNyicKp9E+EBNxM7aW+WYdrtLpBxiTsL+Hi9A12 6L6deeP+v1CmKRhvLcp/dCKxrE46CDd/h6bqsrCoOovl7dPvlLilas+AKZOjjxBqU7ef sBqrFdhdttyPwRlTq9tL4u9ajt5phOT1whpGoF1KCecFHMmpTzMMOrhSQGvCIcd7QLav /7hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mqtL2gCCHPlBEBtIXSoW8gskUPGT59zht12YCRBFAJg=; b=VPzos5VbhubMAcbXFuTRb/5LeWuusbHUs3t/krWjBOUq9U3+SbgZt7vsGj8plI11r+ EEWmRmZooQeoLEnjf+BQjOPfKfHdk8l3zcd1xdIIFHxBwCuF+K1hEG2cKahxlwWld3ii NKXnwuACJ+/QvK5DHKXB8As03GKmHTNDhN+1pXmt8nbpvVvdoyYxR51FJrWsTarfksFH MO0u3xzgRoCPippCqJhAmpmJu5DMPqY76g8wUWbQ2V77ABBfAXla6GMGrNwDL0Vd532J Qd7MJ8en032UyTfTTIhOW3sGwkAQ9WqP94tyIKuafa5XQ0kyX05OxgQRbXib00FoDsVg PB7w== X-Gm-Message-State: AOAM533zz5ql4M9mJI2eaNzBd/2uTw+QwriWYYcNc/7LzFHwE+TcQBcb 1roGETVNk7Ejo9UImsb9sXo= X-Google-Smtp-Source: ABdhPJxmKjHv2n8qTwpXp+fiZDf4jFcPCZM/5haHKnowSi0ZwuuvyGaWWMGogXOoBgnyRcTDBfcIIA== X-Received: by 2002:a1c:f710:0:b0:394:1960:e8a1 with SMTP id v16-20020a1cf710000000b003941960e8a1mr14595010wmh.154.1652083335977; Mon, 09 May 2022 01:02:15 -0700 (PDT) Message-ID: <724c6af0-277b-a6d1-b773-89e1b03e0c53@gmail.com> Date: Mon, 9 May 2022 09:02:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Reply-To: paul@xen.org Subject: Re: [PATCH 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , "open list:X86 Xen CPUs" , "open list:IDE" References: <20220508103432.14874-1-shentey@gmail.com> <20220508103432.14874-4-shentey@gmail.com> From: "Durrant, Paul" In-Reply-To: <20220508103432.14874-4-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/05/2022 11:34, Bernhard Beschow wrote: > This function was declared in a generic and public header, implemented > in a device-specific source file but only used in xen_platform. Given its > 'aux' parameter, this function is more xen-specific than piix-specific. > Also, the hardcoded magic constants seem to be generic and related to > PCIIDEState and IDEBus rather than piix. > > Therefore, move this function to xen_platform, unexport it, and drop the > "piix3" in the function name as well. > > Signed-off-by: Bernhard Beschow Reviewed-by: Paul Durrant ... with one suggestion... > --- > hw/i386/xen/xen_platform.c | 49 +++++++++++++++++++++++++++++++++++++- > hw/ide/piix.c | 46 ----------------------------------- > include/hw/ide.h | 3 --- > 3 files changed, 48 insertions(+), 50 deletions(-) > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c > index 72028449ba..124ffeae35 100644 > --- a/hw/i386/xen/xen_platform.c > +++ b/hw/i386/xen/xen_platform.c > @@ -26,6 +26,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "hw/ide.h" > +#include "hw/ide/pci.h" > #include "hw/pci/pci.h" > #include "hw/xen/xen_common.h" > #include "migration/vmstate.h" > @@ -134,6 +135,52 @@ static void pci_unplug_nics(PCIBus *bus) > pci_for_each_device(bus, 0, unplug_nic, NULL); > } > > +/* > + * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to > + * request unplug of 'aux' disks (which is stated to mean all IDE disks, > + * except the primary master). > + * > + * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks > + * is simultaneously requested is not clear. The implementation assumes > + * that an 'all' request overrides an 'aux' request. > + * > + * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc > + */ > +static int pci_xen_ide_unplug(DeviceState *dev, bool aux) > +{ > + PCIIDEState *pci_ide; > + int i; > + IDEDevice *idedev; > + IDEBus *idebus; > + BlockBackend *blk; > + > + pci_ide = PCI_IDE(dev); > + > + for (i = aux ? 1 : 0; i < 4; i++) { > + idebus = &pci_ide->bus[i / 2]; > + blk = idebus->ifs[i % 2].blk; > + > + if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { > + if (!(i % 2)) { > + idedev = idebus->master; > + } else { > + idedev = idebus->slave; > + } > + > + blk_drain(blk); > + blk_flush(blk); > + > + blk_detach_dev(blk, DEVICE(idedev)); > + idebus->ifs[i % 2].blk = NULL; > + idedev->conf.blk = NULL; > + monitor_remove_blk(blk); > + blk_unref(blk); > + } > + } > + qdev_reset_all(dev); > + return 0; The return value is ignored so you may as well make this a static void function. Paul > +} > + > static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) > { > uint32_t flags = *(uint32_t *)opaque; > @@ -147,7 +194,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) > > switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) { > case PCI_CLASS_STORAGE_IDE: > - pci_piix3_xen_ide_unplug(DEVICE(d), aux); > + pci_xen_ide_unplug(DEVICE(d), aux); > break; > > case PCI_CLASS_STORAGE_SCSI: > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > index bc1b37512a..9a9b28078e 100644 > --- a/hw/ide/piix.c > +++ b/hw/ide/piix.c > @@ -173,52 +173,6 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) > } > } > > -/* > - * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to > - * request unplug of 'aux' disks (which is stated to mean all IDE disks, > - * except the primary master). > - * > - * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks > - * is simultaneously requested is not clear. The implementation assumes > - * that an 'all' request overrides an 'aux' request. > - * > - * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc > - */ > -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) > -{ > - PCIIDEState *pci_ide; > - int i; > - IDEDevice *idedev; > - IDEBus *idebus; > - BlockBackend *blk; > - > - pci_ide = PCI_IDE(dev); > - > - for (i = aux ? 1 : 0; i < 4; i++) { > - idebus = &pci_ide->bus[i / 2]; > - blk = idebus->ifs[i % 2].blk; > - > - if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { > - if (!(i % 2)) { > - idedev = idebus->master; > - } else { > - idedev = idebus->slave; > - } > - > - blk_drain(blk); > - blk_flush(blk); > - > - blk_detach_dev(blk, DEVICE(idedev)); > - idebus->ifs[i % 2].blk = NULL; > - idedev->conf.blk = NULL; > - monitor_remove_blk(blk); > - blk_unref(blk); > - } > - } > - qdev_reset_all(dev); > - return 0; > -} > - > static void pci_piix_ide_exitfn(PCIDevice *dev) > { > PCIIDEState *d = PCI_IDE(dev); > diff --git a/include/hw/ide.h b/include/hw/ide.h > index c5ce5da4f4..60f1f4f714 100644 > --- a/include/hw/ide.h > +++ b/include/hw/ide.h > @@ -8,9 +8,6 @@ > ISADevice *isa_ide_init(ISABus *bus, int iobase, int iobase2, int isairq, > DriveInfo *hd0, DriveInfo *hd1); > > -/* ide-pci.c */ > -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux); > - > /* ide-mmio.c */ > void mmio_ide_init_drives(DeviceState *dev, DriveInfo *hd0, DriveInfo *hd1); > From xen-devel-bounces@lists.xenproject.org Mon May 09 08:07:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:07:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324264.546221 (Exim 4.92) (envelope-from ) id 1nnyQE-00057E-TF; Mon, 09 May 2022 08:07:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324264.546221; Mon, 09 May 2022 08:07:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyQE-000577-QL; Mon, 09 May 2022 08:07:14 +0000 Received: by outflank-mailman (input) for mailman id 324264; Mon, 09 May 2022 08:07:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyQC-000571-RT for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:07:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyQC-0003Aa-5v; Mon, 09 May 2022 08:07:12 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nnyQB-0002bW-TP; Mon, 09 May 2022 08:07:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=G9Bbls4G9n6yauL8aeteYZoGXkJGKanNRrS0wL0KSG0=; b=ZK9zen hzimCMdcIwr02c+qAZ/DEeOW8eKoT7rrt1hPO/r7GZ9HtacaBEEy+Z2kTY+hnqB7vXQxOGIk1aj+y Z0K24b6Lw9toR9TAftNuJKl0/vkRdo4YC+n9v7zk3DI0qiGx8RgVNGIOJvOZn9Su9uislwsyP9HXT 93zv/ER0NME=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH] docs: Fix SUPPORT matrix generation after a5968a553f6a Date: Mon, 9 May 2022 09:07:07 +0100 Message-Id: <20220509080707.50926-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Commit a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory supported for Arm" added a support statement split over two lines. Unfortunately, docs/support-matrix-generate throw an error for it: Generating support matrix (origin/stable-NN ) + docs/support-matrix-generate HEAD https://xenbits.xen.org/docs/unstable/SUPPORT.html origin/stable-NN https://xenbits.xen.org/docs/NN-testing/SUPPORT.html Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. Status, Arm32: Supported up to 12 GiB Status, Arm64: Supported up to 2 TiB ^ cannot parse status codeblock line: supported, but not security supported. ? at docs/parse-support-md line 172, chunk 1. It would be good to allow split support statement (to keep lines below 80 characters) but my knowledge of the script is very limited. Therefore, workaround the error by describing the support statement in one long line. Fixes: a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory supported for Arm" Signed-off-by: Julien Grall --- SUPPORT.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/SUPPORT.md b/SUPPORT.md index cdf93181cf65..ee2cd319e2f8 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -50,8 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Errata 832075. ### Physical Memory - Status, x86: Supported up to 8 TiB. Hosts with more memory are - supported, but not security supported. + Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. Status, Arm32: Supported up to 12 GiB Status, Arm64: Supported up to 2 TiB -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Mon May 09 08:21:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324270.546232 (Exim 4.92) (envelope-from ) id 1nnydL-0001GR-UG; Mon, 09 May 2022 08:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324270.546232; Mon, 09 May 2022 08:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnydL-0001G1-No; Mon, 09 May 2022 08:20:47 +0000 Received: by outflank-mailman (input) for mailman id 324270; Mon, 09 May 2022 08:20:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnydK-0001Fv-1x for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:20:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e94d17ad-cf70-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 10:20:43 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 04:20:37 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4488.namprd03.prod.outlook.com (2603:10b6:a03:c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 08:20:33 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 08:20:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e94d17ad-cf70-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652084443; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=O6aDSZMd6MOZ6SA5SLHLDLM/We7AU7S5b8oZBc068kw=; b=JY5ZkjWVwfbrsza/qrB3y4XTOQsjBcKpaBUR+3pI0KgdPLMLgyTgjK4z K9lkbzVzQx8/H9+QnoDSKHpB4Q/YdY6i8ZA4RcURfvWBK9IoWoCTROwCw TraprLlaEBpZHlaY+Cs1rv2nvqMM/WmaXkde63/H+lZt5/m82aTVDY1/7 c=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 70253922 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LwkdOqo28khlQVplpcDx2s+vKnleBmL+ZBIvgKrLsJaIsI4StFCzt garIBnUbK7ZNzT2c4h/YNi2/UhU6p7XndNnSVdkripmEXgW8puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 YOq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBfaLTvNoQUz5hNCxRO5ZD2bb3KnODiJnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2JAm8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/fBquDmJlmSd1pDTMZmMR4GzY/x0sVaKl HueomfBWi0FYYn3JT2ttyjEavX0tSH0QoUJD5Wj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNzW8oXiZrlsWX91bEMUk5wyXjKnZ+QCUAi4DVDEpQNgnstImAD8nz FmEm/v3CjF19r6YU3SQ8vGTtzzaESISN24ZIygfUREC/cLgsak0lBvEStslG6mw5vXuAi35y T2OqCk4hp0QgNQN2qH9+krI6xqltpLOQyY26x/RU2bj4gARWWK+T4mh6Fye5/AQKo+cFwCFp CJdxZjY6/0SB5aQkiDLWP8KALyi+/eCNnvbnEJrGJ4isT+q/hZPYLxt3d23H28xWu5sRNMjS Ba7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:QOYS365euNG77LK9dwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,210,1647316800"; d="scan'208";a="70253922" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=byNAVGgn5Wu5/93wrheCYdKldVDGy+Xh0Xdn02BRVC/PD6k8XcQiZaAw29ley2J96VeqNxCmv35g/CERSsmtVdZ1dFPFmaXi31gbFsbH9YLJEm1uNQqdLs9ILli1iWDP3D3t6I+pbjSEL9Jt2TN7aOVEDIJwamyanXhUES8cGD5b9tz7uywgX+y46G6i0otnrfWa8CzqCxZx7cy/2vZoBt1KDglDiRTJtvmbE6ec85hkTtWFHx9smICVV3dIftlad8HNTRbMxaF+FG8UWHxdBkpzoqkRK0adzlkbQWIVbRKlrPZegHInkftwmd5A0J5LpBFGfmiaSiDdkmwvLJjgfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tNblGtQgBJC4CHC5HvWW1EtnAyu/hj3bwrctcYARug=; b=lKpskpc/0kd6mgXbMM55GyI8vM64RtW8Bn9NWvxJCU3TmCN0IA/Q/HV0UwWY8Okv+f8nsuU2vAxxWIzrAs/bi5ceu1MuRzCw03KZhU8/4uXfPA9vK09joZeers0MiVtpYRKZRKNEc0Z9zDNneUNOtAHlPMv1pQNI0B2PGSQtCbFBzMYzPNMfDi8wGucx9WpYGhVMDgGcOaJULg0hyaJw3y2lea+tinq3ftUdCQsIkEG4owca/3BzK3RgzkxGwfrQNFs0tKzV2rLRIY7nElHN2D++E/6dQXhevSJ0KVozFAnMNr3pPbylqiu6z+aRORLKU3kNkUAW1L0z0vK8dDbILQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tNblGtQgBJC4CHC5HvWW1EtnAyu/hj3bwrctcYARug=; b=o+ekJ8lBY+hoVhcqAslE3hn1HPdLaarksHHo5qXWP5ul6gUZd4Sek/Lh2nw9AVa8wPifX7icAJ6gdAVKJyxH4BGGVgTsRvoaZ394fJ8QCA5mu3x7YdfM1K/KfGIRJhSmaeOpzrCZ3lODs68CuluUMH1CiEJwhtHl5IELDweDvsM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 10:20:26 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , Jens Axboe Subject: Re: [PATCH v3 03/21] xen/blkfront: switch blkfront to use INVALID_GRANT_REF Message-ID: References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-4-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505081640.17425-4-jgross@suse.com> X-ClientProxiedBy: PR1PR01CA0009.eurprd01.prod.exchangelabs.com (2603:10a6:102::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5707a7a0-7768-416d-d176-08da3194c98d X-MS-TrafficTypeDiagnostic: BYAPR03MB4488:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zxMU32zho4/N7Q5IEj+QphV0HyBMiGJqo1G4VDeFF9pQPRTaAcRZk5Lz2Kpgd0Z5vPlz1sLHA2j8S/yRV2Ugxx/ngsMcHQmxJrcYp8QaCTVLz8lyRtoqkNW88m6E1cIOTMz8bMl0duMavYJCinD5S9lkcY5usVomP2HuxTwSRYBKBV/78/Di4tIVB/ZgcSFKFQEyO58NlI7QU1lDexlec2xEwEtd0HrOhPXIrBv/reqWNbOE0aylptU+E9Eog1TVMZlheWp3ILrXRtJheEeSKm9qajhux8Kjgw6yU9ZTnzfu546OxVCjV9C9Pq5gZDVkNLyNvb6975Sm2Ud6azgwlxqPJHAmVbJCiAKwtRQDs+C3rzJ26LqefNaqB3+nSmZunQU/ZkCI9vlkqrHB88w5s5RDjHkkXTku60gswmsuVsha+BnKjJnU7YvpZ+uIx5fMgYpgmd3R/kvcNUDltCqfPwLJeQ5TAJaYZwEFmXW0jwNQfZ0edx2d7zM1DVuSy4zAk2Wms9oZzEfgZERCGS/4V6NTjoRusSkx08IK6/C4CuCnqeGNYZjxJCV4GoPeFZOVyzFLO9MJ767M5N90kyjWzpQj1LIIJEOSwFc+FTEc/hagmC4Wr8L5fGmZpH9eyGCXxtUbI1nR+AgILPZXEKsOBw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(85182001)(33716001)(508600001)(8676002)(4326008)(66476007)(2906002)(66556008)(66946007)(82960400001)(6666004)(6916009)(6512007)(9686003)(6506007)(26005)(558084003)(5660300002)(6486002)(316002)(38100700002)(54906003)(86362001)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUxqbDNBOWo2aUtqeG1XcjNmRVdHcXVHZHUrSk9aTllKN28rdDlGZlRUaWhZ?= =?utf-8?B?VnVuaTRKcmtZbS9UQTFOdjBRWjZSMEs3blEvVGVsRlhRNUJ1ZHZyaVlmT3lp?= =?utf-8?B?dlBMUE5VRUdveWlBeHdQeGVtTTRqbDV1SEZxazB6SnJkdS9USkcwemppZG82?= =?utf-8?B?WGY4WWtialNPanlCZld3d0o0T1ZpZEJjVG1teWpQV1FNVllOMnkwTTQvTHph?= =?utf-8?B?WjFhV1FuSnczTDRKTjJIbmRESWdxK0NMMkthZ1RrS1Rya1RpM2RxSlVlRnFR?= =?utf-8?B?TkowMUNTT3NuYUdJL1h4eUI2QzQ3TDA3ME96dW9UVTVEcHAwNTczRmdwY01a?= =?utf-8?B?VDVMQVNyUGpvQnF0cDVmWUF2TVBibXFuM0VyV1Yrc2xYQjgxOXNWM3d2d3Jj?= =?utf-8?B?TGJjR29FT05UcWtyN0QxdXU2RUJkU05TdWlaYTFERnBtbHVsWE1BeElZRDc3?= =?utf-8?B?RSthZXFIMk9IeVFoS2l5M3N0T3M3ZitmL1J5RndXT0tqek5NWmlQbmxSOVVH?= =?utf-8?B?a1gxUkFZSHFWUEFlMnI0UGg0eVExdzhNY2VqOHU1b1VqcFg3ZjFXYWVSSjlp?= =?utf-8?B?YVFzRTNuUUZVYTF1M0g2Rm5SRkVlUUVoVzhsSFpJKzFLYUJROHNIdzM2TGVY?= =?utf-8?B?Z1ZLdU9xV1krRk1wNTljQkdJbW9tVWFHUkFqZzdIMXdNcEZ2aXdUT1F0L2Vm?= =?utf-8?B?cWQ3UnFjc3RyOERVd1kyZzhPTTlNMEtlYjE0eWhoL2txM0N3VjgraVRUMGhF?= =?utf-8?B?MFEwSmtIeGtiUEl2K2N0YTR2ZTc4ZzkzTmVkM1NnZVRkRDRKYTZBUkl6cTRT?= =?utf-8?B?UUtHVGdhMHphdk1haHdISWV5dWZuamN6MFlXS2QrZkRFVnhjWnIzN05Tck8x?= =?utf-8?B?c3JNRFVESWFIdXI3VUZtSWVid0VXbWttVEUrZUxrWmloa2lwc0ZGbm5pMkhz?= =?utf-8?B?dlVCVmxLUHd3QWZJVEdkZCt1VnBhRno0TGRyVVluclN5T2huZVc5NWJpT0tQ?= =?utf-8?B?T1lsZDNUTStLQUQ2VDlaNHJEL21vS3Y3aFNMelM3MUlBYm5hUUphUU5wMVFn?= =?utf-8?B?b1Q0WFRyWUpBQUlSaDZ5bDVNUFQyY3JaS2RJdks0Um9GRTdKUzRGRUxxY1FK?= =?utf-8?B?ZkE3RlFNTVBJVUhuTTFSRnVLL3VnRGtkaVlHZ281azdhMnQvaUxnSitKUkM1?= =?utf-8?B?WFpoYTZmSUpra1JYWkg2dlpQeHZrMEZQVXVTZ01EOUJHamZaeWlSaVJlNUhD?= =?utf-8?B?QzhCYXNHMm4zbndCWmZRQXEvTS9BckRGY2sraWxNdUVSMGw1V2N4VTlvaFlv?= =?utf-8?B?WW82NTRta0xtZzl4Wm9kTU03cVlhMHRwRm1SWG5jS3VqMktCNkdwZmVIYytP?= =?utf-8?B?TU5HVk9QTVBBRjMxbW9DWTJkV1p4ZzJobWdwUFZjSkMvYXlKSlNMb1hHM3A5?= =?utf-8?B?dlE4TzJDOVBhZTliTEZ3SlBMc0hqSmMvcksyeHJKMGdqK1oybExGOTMvV0li?= =?utf-8?B?d21Jd2FWejd6a3JzR3VTSW5HRVBIT0pXRzhVTkY5VlV5bm53eXpqUjQwOU4w?= =?utf-8?B?TUNTRXdvL0hGSStZQWw0Znh2b3JJSVdDRGhkblRMc3hhNklwSzUxUmt6NkRo?= =?utf-8?B?cU44VkNweXRicUpSMkk1YWJBVEQzMHdvUzVSRVBOWnl0b1lVN1dUS1p6ZDZm?= =?utf-8?B?L0RHakp0RnVrRTBFZWxhTGRHdTRTZnFFMmVnakVLd09nNEFGT3dvcU5NVEEw?= =?utf-8?B?M3JqM2xZSThQbGdmeUo0THU5OEJ3MGNjb09lNW5IVm1PcENPSk1uSU51bU92?= =?utf-8?B?WkgwUEJqYzJmZ2orSVVBeEZkNDJtUnA3WGs3dlZWeVIyaXpqSGdOZHc5WDJ2?= =?utf-8?B?Znh2SDBmZWY4ZEVrM1lTZ252azRzL0I4cll6ajZQQ2laWkpXcFJ3K0xVNWFw?= =?utf-8?B?aDVRb0JQWHhpbHRsR2NWaVI1cHk3Wlk5UCtEUnpSTkEvWjJqd3pqSkhtUmFH?= =?utf-8?B?S0hwV20ybDJIMzhjNFZVN2tRczlIVDE4bzNlV2FlOC9XSDFOVGlSdkpZZ2Fr?= =?utf-8?B?bDVob0ZhdzRYbGMvZ1FKTGNJMVlaQ3RRRlVjbGhiS1Y3UXdjYnVRMTZGQ0VV?= =?utf-8?B?VndzM2E5dllvTjhOZ0FUWExDSEtUa0tnZ2JVVUp1NnZqSGNMNkluVzA5WUpM?= =?utf-8?B?M2tZbEFZVkFkN3ZDZjJ1WllyZUV6b3N6WW9zRHFuVVN2Tk9QZXJrOVlvWHJY?= =?utf-8?B?WnRKdkZyZHl6YnhuckhYeVpyVThMUTJFakVEdzdVbXB0TmRuTHpyVEFRYXFC?= =?utf-8?B?Y01vY3NBL3FBVnpUdmViQ1VqU2hTd2xpWjFoWW0raXVwd2E2NUxwdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5707a7a0-7768-416d-d176-08da3194c98d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 08:20:33.4187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FMDVE+vsWBnSKwc6MQKKBVFpNN9OM67dcrF1ZymzLl/abGWMkQung0lu2rzckiTYISDeqRp+4kkfskWQcq1Cgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4488 On Thu, May 05, 2022 at 10:16:22AM +0200, Juergen Gross wrote: > Instead of using a private macro for an invalid grant reference use > the common one. > > Signed-off-by: Juergen Gross Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 08:42:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:42:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324277.546242 (Exim 4.92) (envelope-from ) id 1nnyyP-0003qs-Ia; Mon, 09 May 2022 08:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324277.546242; Mon, 09 May 2022 08:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyyP-0003ql-Fe; Mon, 09 May 2022 08:42:33 +0000 Received: by outflank-mailman (input) for mailman id 324277; Mon, 09 May 2022 08:42:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyyO-0003qf-GF for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:42:32 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f56e92eb-cf73-11ec-a406-831a346695d4; Mon, 09 May 2022 10:42:30 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 04:42:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4404.namprd03.prod.outlook.com (2603:10b6:408:37::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 08:42:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 08:42:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f56e92eb-cf73-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652085750; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/kVMDohfijxrA6GLao/+q7NNSaAxPnsTEzrObM1QEwI=; b=JqDN/z4AfabOE+7XKV6MjmhoIj77u160lgEDLwGBhK3TXZYzw6DCgnw3 kuqujpl62PBt/V9u4domIYLSoI301TU/P01fqKVIu1lKMAS19aTkdn3qX qHwwdrMLgaOeg2gf1EcDgSleEo8KBdlmQFg2rMp+K2rlvWAhYh3npwbzm E=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 70860795 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Kli3ta4+r2gOgMI4H9f4hAxRtN7GchMFZxGqfqrLsTDasY5as4F+v jEdWGGEaf6KNmbyfdwnao7l9xsBvcWAmNE2GlZoryA0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhU1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSOVTwpOfPVv95MCTtjCAgvF5Fe6Jz+dC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAgV/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA+AzN+vtqi4TV5A546ZzKMfGEQcOtHf1MnXe5m Vqe+HusV3n2M/Tak1Jp6EmEhODVmjjgcJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZt38WQCo5XSAuRUfc8RfHvd86wyXzKfQpQGDCQAsSj9Hdcxjt8IsQzEu/ kGGksmvBjF1trCRD3WH+d+8pzSoODNTKnQefygaVggUy975qYo3g1TESdMLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1VnXiTWhjpvEVAg44kPbXQqYAhhRYYekY8mt9gLd5PMZdIKBFADZ4 T4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsI1cFv Ge7Vdtt2aJu IronPort-HdrOrdr: A9a23:rQ1sfqyJ60B9+dZq0ScsKrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1rop5PzuN5d3B+3Z W0Dk1ZrsAxciYoV9MMOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.91,210,1647316800"; d="scan'208";a="70860795" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YR23JBKeG02epImxgjflKndIYniPOnRvyvoHWPLfYq4AVwuPFuz6AsY8od8iET3T/U+YpJ4UQhVq4OYspR12gbpdFFaSJ83WmqHwpyJieofmQBjW1lNGttc0K92EWDt2HABijbp+TnKSE1P+27NXC76WQ/lx9c52SGoh2sBxdRgCtrBeAIKq6nZ6OtXSTS1yu1mcFPWZHUaehGB9sebI/LYFeNQKP+OLqEd6CSdGUrMdj62ZxYfSIfDHJE5HQEeJgGvOnpOV0qyXQWtSEK9CJDtlNBlCsH3X7gUUgFVGpFc8NxVvd5jucduHvGB/xGb9KrJaBhfo2dZcvKGhQZrfIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Drd8/4xtkZhH7KNfYnWw0NfKtXeJLp5V3qr0IHqLIA=; b=j4UNI5rFHZbPKs6v5bOQFp/LvxO4alSPd63tdwdxSMZtsIF5LPDPcnhyWuYnMNHukscYjKNKEA9o1Jxyc+nu3h2YUjdAklE3ygh8geYHSwsrkaNtpBbuLr8P7ti3nFvDrv9o1EOXkF1PRjHld4WDZ2TR+0Td8oBtmfNMSyNYXtH7WzWWGuuUcGPIppxjT9gf3JGzd4Apv7591iC3IPYF6oqa0F5gBV13EEe+8TGhplKB7IiHr4Hkqzy1HPXDvB2gPax+59ocmGRF5i9/tED1UR+iBvl/f3z/43XbodhGir/r5Mh5SNu3f15oEtsscxTPWWCoXCxeYziUISx6ZivtOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Drd8/4xtkZhH7KNfYnWw0NfKtXeJLp5V3qr0IHqLIA=; b=ux8xwY4qu1pCEMh18xd/Tbm3e7WcudqDjGpf95kzi1XbZQrI/AyNZsq05aRQDbW2uMWPeJlJ212NXiLGkTmWBMTnc3xTuiiZCMWYA0igWBde80rNZN2sqUr8j4Nzk9I6nBNYnOyTP6hVc1pDXmA9J0jzvm2QC+xjc57TpCtqhYE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 10:42:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , Jens Axboe Subject: Re: [PATCH v3 13/21] xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() Message-ID: References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-14-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505081640.17425-14-jgross@suse.com> X-ClientProxiedBy: MR2P264CA0018.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a66d1586-8db2-473d-924f-08da3197d76a X-MS-TrafficTypeDiagnostic: BN7PR03MB4404:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GH6rXwjQ16cKRI5UlOK1GtIx1H1urpG7g8mxc6JQ4Gjymy7K+1P3BY3jhGezz9nxeixC0LC1Zsqs9WNP3ARkzs4sE0eSygoKL032Zl+JJ8ZJ5/lBPIgPxiKIGG05UXwBRE06xzf8I/fj/eR14ipbfgWaT3iHE8l8P1LVlDY31gX+5DZYPoc6y0RWunBp77Q0+C4o8HeoKB1w0WNEOOsSzYtVX+zCOVDARD4nRBoplEDCYTkFTJvq/hzhTpX/FS4l9Pe7PNj/1xhS8RfYr8/nzCFUaEn+5/4GdMgTJ0QryT4rGEI4XZ3Vl3A7tzE49oWtMMeeDm6mrxx2v0oYpWEESFuJI5elkrVQo0Aq0v3/1YaPRlebDkf+8w45vph/jz1qmvto9Vk1JU8Nd1iHXr1f8QO+xX2dZRvsydA5kCc9+wq4H/TFTuCjoOOGngmgJZq2Dg3kopOCbu6fgksKuFRqsNlA4182ev2ApKRDXVnC2RCU0azSQANweN05XSfhUb4wTkrzlkjITcjtNvSFtZ98YR+54MjElwX5xkNJDsKrXJsZNI4h/wTmkhZHXK5aBMT4L7lSLJ6UEsgQE2yhcL2JPlyLMbVah8UX9aEA/jzChCPUGs+3+Jote8Tums3nk+T5wciikkf7hEkJr3xg/Nka6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(9686003)(6666004)(6512007)(6506007)(38100700002)(82960400001)(6916009)(26005)(54906003)(85182001)(33716001)(8936002)(186003)(2906002)(558084003)(6486002)(508600001)(86362001)(4326008)(316002)(8676002)(66946007)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzdlTFRoMU1aSk9JUDU3dnMyU0dWT1A2Mnltek96K3VSVlRRVjNyUmcxd01C?= =?utf-8?B?eDZSWUJkVVR4RzVDdlJWZzEwd0s5bDByTzZhUFUzMmRYL01sTlpmdUFOczBu?= =?utf-8?B?NW1hTUg1elEvUVlQdzlwS3UxUE9UM0lKdkQ1b2F4SXpPby9xUzdmMzNua0U3?= =?utf-8?B?S21YUEw0UkxwU0p1YTZaWmYwMTBoSGFucEcyZXhRNDNldWVKVHU4SS9MT3lC?= =?utf-8?B?S01ueXlxdlg3cGRSQW1zMUVKdjU0MjhSeDRFOWxLSEdNSHVVc0JVUVl3UEMw?= =?utf-8?B?azluaXcxSHJXcVNBMmpIVlpnYzdCb3h0NFhPRktTYWxXTmpnak5SYzEyQW05?= =?utf-8?B?WFA4dW92MXl6eDZZUFQyU0lxaVVtRW5jdVdQR0Z3eVRaSEZCZWRWTmtIQ3hF?= =?utf-8?B?aEtuK1FlMlcwb2o1VWg5ZzZzZkpHRHB1NEZ4S3hKcTcvQW45S2RUYzZrY2tO?= =?utf-8?B?ZjVPWm5KUGZCY2NQK1lZeXdlVk1FQ1pkN2hVUzg1TnpmS0o3MEZCY09Ccnow?= =?utf-8?B?cmN0WHYrV3l0d2FkeVlpekhsdlhhT0t3aExXOXo5ODF0eVNKUE9GRUlZNThw?= =?utf-8?B?ZnZVOUlkN254WXNNdk1JUG5FWmJzOHVzNnlSd1BZSWhOSjJEY240azQ2N29r?= =?utf-8?B?R0YzTTFuRndEQXYza1Bvbmw4UW5nT3lqT0IxVnhxa215YXp4VzJBY3Z5azlM?= =?utf-8?B?YS8xZ09CdHFtOWcwOUpyN2hGelcxM2ZiN21XbG5PVThvK2xSdDBCaVlLV3ZH?= =?utf-8?B?QU15M3V2bk1QY2tuWWxyRVZkalBoNVpxVG8xMThaSjNzaWlxRE5WN0xxM0Vi?= =?utf-8?B?YWlNeUx3WkNSN2tmR1BYVkVnbm9rL3J4Y2JsWFRDZEJzZXJiZEdCRkVGR3RR?= =?utf-8?B?bFNRbTBNWjRTZ0JvVjVSeVducXBKZVozMDllVGRpektZeDRqZWNpYTJ3bFpn?= =?utf-8?B?ODJycERlUlBmQnpKamdCN1BjZzlmcXh4YVVjVlU1L0c1RXdmRGFYcmFpVkx5?= =?utf-8?B?eXZMbkdQdlE3dHBLbkttZVlKRnAvbWFUUHNTdDYxVHBFMjlaaUE3bkxpdS9S?= =?utf-8?B?YnNRUndMOTVHcmI1S1ltbmRnTzAybWk5OUNraGcwelJBaG9HeitBSmlVdW1S?= =?utf-8?B?TlhIaTduMlFlL2Q4VGswd21XamFld3hsK2tIQUdWTU1qMFNvTFViTHpvU3NO?= =?utf-8?B?UWNaNTVrYkg0QjkxV2RKcEp4TWxxYkt1eHRYM2Y1RG5uTktWeGE1aVNmcWRG?= =?utf-8?B?WC9NaUx2dUlKSVZOdkswb2dyR3JMN0k5dDhUcXVDVE1UbGlXWklCTWtzQXNQ?= =?utf-8?B?WWd0eFFvUUt0WnhrVUU2ZUZ3bkRBb0hoUFRlMWF2VHVlZlJ2K3hqZnlmbTRU?= =?utf-8?B?dUU1enpKZ3JqTDVaTzVkL0NoR0wrNDFuVldWbjNRT3hEM2hXcEFLWnN5bTdK?= =?utf-8?B?akE4eU4zZUhJL0FFNjk4cW8vQkR6bHJsdi8rQXpKVU1mL1pXOHBLRlNhemxz?= =?utf-8?B?aWVrRCt0SThna3NEczBIUENZbWwvVVhZcG53ODJ5bnZiM3phOTVmMWhlQVlZ?= =?utf-8?B?WDBZMGV3eDZmRHBFZkJ2UHkvU1RzbGE1OFBlbmk1TDkyblpyMjNlY2Q3aDYy?= =?utf-8?B?dFVHd2lyaGtjQXZoZ1F4RXk4Q2E1Vjdlb053bm9ydU1ZbHFoemRwd2RuQXg3?= =?utf-8?B?T3laMU5WL3NQMjlUTjFDU2lrQURuRDhpYnh2S3piZUdZMEtYU282VysrRjJC?= =?utf-8?B?Rjh2dkNTN3R3ODVqQ3RrMU5iSVZLTC9WY3htL2FPdjFQTVN6RnVwSUdIcXZN?= =?utf-8?B?RDlvd3BuVFNuTUh1SGRiQjYzZjhHMUdxZlE3cEJwUDBZcnFEZHU0bFJEYklR?= =?utf-8?B?T0l4ZGhHblNhcW83dnVYQ1ZFWGl5WFdhelZHSlEvQ2gxM3NiMFUzOWhZWk1N?= =?utf-8?B?VVdPOUE5SjVTQVR5aDd5a0lVMXdTTWdRYm9YK05na2xFRkRYSUlXc1lJN05v?= =?utf-8?B?ODZNVTV0SHZoR0d2NndNb1FYOU9NZzFIWkJZUWh3YW1qT3hEdGRBcUwxZmR1?= =?utf-8?B?SkRGMVNLdHB0MkRCYzNCQnc4dlAzb25paFF3eFN4a0U4WU5oSklCblEvMzVI?= =?utf-8?B?c01JbG8yNFdRbHNscEE0WmY3NkVuak5qU3drTEtrN2J1RENZdDBxb2RPc0R2?= =?utf-8?B?cERCL1VtRHltWXpLcGoramJZOW1BRFJscmxwK3NSMUdBRFFYSkJiL2tnRWtM?= =?utf-8?B?VUpnQzZlaG03dnZOcWVMZ3dNc0I4Zk1oSmt4TXQvS1NiUmE3WTE3Y0J6bjYv?= =?utf-8?B?SEhYelNOblhmU3J0eXJ5aCtrZ1NZYkdSWmxPV1gyTk5PZS9PaXMyNjV6eTNr?= =?utf-8?Q?J4go+lCItpgu3sQA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a66d1586-8db2-473d-924f-08da3197d76a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 08:42:25.1348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nQPC8ryiS3dt5PMJMLabGCoTrfyVU+9aXZ9Tqjx/s30gjmrb0PNAXkRs6g/TuaB1g9z9frmm/mW2eiSEXvDjsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4404 On Thu, May 05, 2022 at 10:16:32AM +0200, Juergen Gross wrote: > Simplify blkfront's ring creation and removal via xenbus_setup_ring() > and xenbus_teardown_ring(). > > Signed-off-by: Juergen Gross Acked-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 08:43:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:43:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324282.546254 (Exim 4.92) (envelope-from ) id 1nnyyr-0004Np-Vv; Mon, 09 May 2022 08:43:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324282.546254; Mon, 09 May 2022 08:43:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyyr-0004Ng-Si; Mon, 09 May 2022 08:43:01 +0000 Received: by outflank-mailman (input) for mailman id 324282; Mon, 09 May 2022 08:43:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnyyq-0004Br-MB for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:43:00 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 067514e2-cf74-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 10:42:58 +0200 (CEST) Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 04:42:55 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BN9PR03MB6187.namprd03.prod.outlook.com (2603:10b6:408:100::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 08:42:54 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 08:42:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 067514e2-cf74-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652085778; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=NsDYcOpl7cB4xnZK0SlA4GMcWWFt11cgRIwWu/b++LA=; b=Oawk3+OROb14SFWZc8EGUxV6V1jIqumwkVhzIB2zbvYyz+6Ef+mDkV92 25SvhipVH7pr0ddUALo0vu5eGLKlL1PeExtlT6M52Vp/wb7t9fxfa/caQ C+bBiOlZemEnlq8pAcMgl/RIx+vBx5tNipTRbKPeqw5uhpUw9UyLfoglh M=; X-IronPort-RemoteIP: 104.47.58.109 X-IronPort-MID: 70255180 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/mWJz63SVEN63NXk+vbD5XZwkn2cJEfYwER7XKvMYbSIYQITYwd3j TtIBzjCf73ffDO2KOnCW/3j9kJTu8TTztNrT1NsqS1gF39E8JuaXIqSfkytNH7PdJbNHR8/s JgUNdWbfcloESfSqBmnbbTo8Cgnia+BTbb1YAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm PujrpSCM1T5gWN4Pm4YsPiJ8U0/4aX5tW1J7gM3O6kVsg6CmyEZAqxEKPDqJRMUYGX18s1W5 Qrn5Ovklo8M1051UrtJqp6iLgtSBOS60TGm0hK6YYD76vR5jnF0g/9T2MY0Mx8N0W3Ux4Apk r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji 8QlhTVHQRrjaR9sY3IuVL1nrMa2lyPgSz0BgQfAzUY3yzC7IA1Z9pHIaYKQVvnUAMJfkwCfu 37M+Hn/DlcCLtuDxDGZ83WqwOjSgSf8X4FUH7q9nhJoqATLmipPV1tLBR3i+ajRZk2WArqzL 2Q79y00oqV02FGtStDldxa5vGSFrlgXXN84/+gSt1nXl/eNs17x6m4sax9MZ916sPMKYBMy+ Fuss5CzDhVmmejAIZ6a3vLOxd+oAgAXMGsDaCksXQYDpd75r+kbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lXjFjCilopzhRws89ALRGGmi62tRZoSoeoip4ljz9utbIcCSSVzpl GMfh8GU4eQKDJeMvC+AWuMAGPeu/fntGCLYqU5iGd8m7TvFxpK4VYVZ4TU7KEI3NM8BIGfte BWK4VIX44JPNny3a6Mxe5i2F8kh0annE5LiS+zQad1NJJN2cWdr4R1TWKJZ5Ei1+GBErE31E c7znRqEZZrCNZla8Q== IronPort-HdrOrdr: A9a23:KWRGjqtUaoPctlVt0QS54Do47skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,210,1647316800"; d="asc'?scan'208";a="70255180" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5zWYniBJg8kPKiQ+APn+X1uE9VlocRJHgCnEqeqGX612obHwJlv6TT5S1LY8HRIcVsrsGOHXO94OT1rqxihzIq79Xp7u0Zsujy5ApL/uuaZZ6zADKrSrrKm7MKl5hMtYMDtWuHJ5Mn/ZY7gGywQ8UwHkcKFCotiHCwLgJg7tLz0DVI4W8j4JsJ6mEQsyoTs8eK7RrLbVjGmjEdge3DZMX52sVt3Mh08atXpqLmULoMdCw+cD0oTV1+B9uCVmqfGe+QONnAafBGP0GtpVE1rLw7U8LJz0vH2UwwscBaNkV+lQUoRRprl3YjfNAcdbSgLG7CQiWGodHSENKinz1br8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lnPwht9zsyhzIHBlQqBJ/kjjwTR50im8scQl/KiiHLY=; b=KpkwHDkAb3GJtxWrLMXa3KUJK/X+nOQn6AQsmV2zTbsX5nNZ2Q5qAT3Mvy+RcCdqRqI74MD0P0WvV/Q/6q/PgPidS0qiPs8LlHPLIJ0A13Xa7yZZR++4ZYMgDsInjvI7KsoTEfhQaOsR0TJqBCn6oX1OogD45FhVzmvec1JieVuRqWFs3bwk0PfwzD5Eef0V+J6XfQMWkpewRjiJ3ba+xe+ppI2RZnYl2E0jABq9hvN68W05vyw+4vArwU3QqAN2ULNZdGkLtpAinNWppFC4FEua5ndbClTpcEdt/jx/67/xNPu/JgD5E2vMZigqdRwkz7B9bOYKPK8orCaM7j3hlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lnPwht9zsyhzIHBlQqBJ/kjjwTR50im8scQl/KiiHLY=; b=Pqw2yYWqbUzCEA9DVz5AtbcBCAJFyJM+HEX41p7G2QSerNNwUpwGMtvZ3V4MXwswvm2XJEbf7kIVmoewNREZXUYB1itMDrh0WHao/SYNhssbC1pxDB0zFSWPzqM+4SyFjltas0+GTWYO6fucVVIySyrJorpaSXB+E/tCtnypJHc= From: George Dunlap To: Julien Grall CC: xen-devel , Julien Grall , Andrew Cooper , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] docs: Fix SUPPORT matrix generation after a5968a553f6a Thread-Topic: [PATCH] docs: Fix SUPPORT matrix generation after a5968a553f6a Thread-Index: AQHYY3vOnJXgy22N0UmeoXtzBuT6lq0WOoyA Date: Mon, 9 May 2022 08:42:53 +0000 Message-ID: References: <20220509080707.50926-1-julien@xen.org> In-Reply-To: <20220509080707.50926-1-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 329e2d44-b23e-4ba9-42c6-08da3197e8a4 x-ms-traffictypediagnostic: BN9PR03MB6187:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lye3d0afSoszHs1Vi9xTdx8ngQjinARGdiSQjsHBbai0RveYsVV38h6wA0ZEL/fXgMWaH7BGxWyH0xaS+1b4hHDvBFFIglYswMR4+PoBduSi9QDxn0tHAcIPPcU9mrtC6GIM2ed+5sgvaF9bXnOslMiTxm259vK82gr1DR6rXJChhWmKNmak806tdzLfC5BNYSNu+Rv/BH6Gs/sKzSTDc1/Yw2zTfWZrvYSXr8LyEJQSp8bERfYc8DoklmLrSnllWu2NfinTNRE4iyUTyMLeBd+mxpN+BihrVN9UvalEUD9jOPtXk6ZZpiGPkGYAPsx6TUBaA9F0HdQps2mVVEvNo1anTb3g2BAPo3LrSjd5QE+nIRDfZ3/j0dDOKHZDc32j+qNHvR8NGhCl6NpZka/OB5Y2+CnEPQtK/4gzfrouaITElHp8tUkED1YicePrvI9VF5H54LmQ7TU5Nh6/8Sd10TngYP1FaSfkIm/2hhFwZc74UxtuH41EWMfvpmH1PZ//nFbhKYDTDzetpCuDrE2WGTcVHlkVp027xZsSVRXI2mLoXUoCCGg2ZALCoR4UYHk3cmOQRmuPKt6M7bHvaUODRVSfdMTLMg2aTqwmKDZcIRPTu7LBh+ppb6q3YFAeH1yQCMHY8ngXtEtA0RCAnL8bJrXcl48T+x95XvyBH8attUEiVoGSbsfnVNf7hYujOBRu94RT0526F9vv8QI8j3xTHJUUqdqumF7HxALqBArnCyS+Q+oN27jrThYiAqk6LFeacWAZPqiMFE94zETG74vxzloIr8/lT+NSzbqtpPZnxQc/EMcJ3pmnNXwsk1WbmNaFztXlXh8LviFRwc7/kjN5yRXxPfieIlbtyJrx/Dmk5697Jk7onFSsQvY1xDO/q/RK7CL2aOeeLZbfVXAes48t9Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(966005)(6506007)(86362001)(8936002)(6486002)(33656002)(53546011)(5660300002)(71200400001)(508600001)(83380400001)(99936003)(38100700002)(26005)(82960400001)(2616005)(6512007)(38070700005)(122000001)(186003)(54906003)(66946007)(66556008)(316002)(66476007)(91956017)(76116006)(66446008)(64756008)(6916009)(4326008)(8676002)(36756003)(98903001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zw0lX5SpobM8HYyoVUJKlDjFHY5tXVtHGLpktDQn3QXvjq1PR332OyJvijZ4?= =?us-ascii?Q?AvRIhqEbNNjRhMrGm4NM1cxkH3+pFIF9WOtvt9NvEKTbhdXGAJaoa4IFfcQ1?= =?us-ascii?Q?+em38DoX+2noUMkbXDt8NDjjtSnRLw1AIE5uUhq6XiPyafba1nrqDvo6+Qey?= =?us-ascii?Q?GLCvWdBtXTwcbQOf2zfHuM+d+p7IYuSkgQTJEEoN1MgiupGLqztJm4SW1+Kk?= =?us-ascii?Q?zypu0T8Neir3W8iAa3MuCf/KdnAVDJeQ0qWpMA4bP2WmHvGGqNETnwnbKufC?= =?us-ascii?Q?miJx+J8q0Xvyywpd4iL6mkUy7zdUfMA3mETh6mqP1pgAXi5pI31AuVl32zHz?= =?us-ascii?Q?MAwAF7/Yt+mIKegJiuTligZ4XUjDzCDl9hxdlCsoQdW7WhkoV60d+r8mHmk9?= =?us-ascii?Q?bLhz3hG1BxgYOrk84Ggx3/RThoNcbckB69/MzFnFlYv0U5vwXNDlb+pSsevw?= =?us-ascii?Q?Eizyc9dDObetQpnzvBnpk0LhLlodmh1x6cwsQr1Gbd8C4fhe+0lDM2Kb80Eb?= =?us-ascii?Q?0m9J7dS/oGXxI66Rj5R4hSXsNk7xz343o+zZTUOhZRDHHxCzItBer46zK/XW?= =?us-ascii?Q?ovWAZfVgh6W2yv2ws6atT+80Bu2Uhg/C+gnuTvcAJW9RqMFyUugsgca6+djW?= =?us-ascii?Q?q3Glg7JlZWrEcFNF726oJaOrOl3k1SP/p69ZfNUAprQi344n1x+mZph7SrlO?= =?us-ascii?Q?iLD1AwfsZOepNNOYs/x+3Y8/Yd8Gczxlo4EgSw6NculYcKKWiTIcmSsj9R3U?= =?us-ascii?Q?VeG5bJQcZJ64oNuKbVcgWDTFPp2nrKWOjpqD0LpkF7d8k19HavHMSyNQYZYa?= =?us-ascii?Q?DggQxAVFdEKmFsDAnRrbBKCQAc0RvFoGUj7sHH6QNs71q21aAt3yUiUuDnS/?= =?us-ascii?Q?2DqJn7ENP+CLKSTzDLzjYrN95Ea35lhjGENqrg0kgeR1EmJSWzKs3CQ2CFWI?= =?us-ascii?Q?nrkwgGo6fVLCxHWaCdbKaD0Zt512kOkljsHuZrZAoD/EubY3a+oedu8Sk8I5?= =?us-ascii?Q?edR8E5ncaZ3BdUJapWBGH1XqlRHcoI4PTOq4JZIIjPLNqxnH3a5GVWKiGVSX?= =?us-ascii?Q?P0MbwR9n9DH3dSoKmqBucmL5Qi9U18uudMn1vyPnkZXCCm9vp8eGPghHG93t?= =?us-ascii?Q?um4FVv6FUDI/uH8JAJJD2geqfgYLk16rZ+aLSDGfhOqykpbCy5hu4enz7Eac?= =?us-ascii?Q?7osjnZJjY329L4HrI5r8/AFyoXcpZfBpfxHsCzIVKZ1yg6kFMCN0EeX9Pygj?= =?us-ascii?Q?Cga7vcyhCmbkG+b1MrjpWqRknvxnnj9nG5NaBitXTzCJE8EQIZ8g7XqsPZrs?= =?us-ascii?Q?Rh1WP+LqNws9Hnc45mU9xZOPOq6YGyhsj/zrApOHPOXN3/qTaSGjoK5G5ARP?= =?us-ascii?Q?mUC32EyWjMrjulK77g6kzzlYhGmSDIMuiTbc3olPeUIdEIerDNX8SaVaPa/q?= =?us-ascii?Q?2oCKgyoDsaU1Bwcg25hlPNtj127EoX2p7S5y7BeOspeE+2veV6tjCSeHZT0P?= =?us-ascii?Q?K6LjusodsaF3QBrJXxS4ZPs5ZY2RXp1NnEzSzN3x6UAZxFZuq/ckLSHe1tFn?= =?us-ascii?Q?YuBx/9Kq4zlkmflPbuMl0NBUwXwgsU7vkjvhcQ5swpSZMb3o2ObgRQQyEcJ0?= =?us-ascii?Q?qtRvTuFlYRBVyvu0IDKnzstLYz4mdyTmExo79LuuFn/S5IWcYETOK1qCXSn0?= =?us-ascii?Q?c2F+gM8Fv2mIlaoA7MaFQAH9zW4xklYnEMUp29q7ynXz2Se/5mqgSM8x+rv/?= =?us-ascii?Q?W8wZveKJLTFl0BBoC4LM1iVzySysstA=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_4316FA7F-0966-4832-906A-544C64B3E387"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 329e2d44-b23e-4ba9-42c6-08da3197e8a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 08:42:53.8936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oqsV5BP0FU3VjpTpCKVQiC/EqKu/7nwbWUzhElAJ6EkUzoaxuAIBZWnXakaXaLiCGcawz3s4Y5Ika1RQZVtlRW9dqjZFdyWl/8Il81jlziQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6187 --Apple-Mail=_4316FA7F-0966-4832-906A-544C64B3E387 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On May 9, 2022, at 9:07 AM, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Commit a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory > supported for Arm" added a support statement split over two lines. >=20 > Unfortunately, docs/support-matrix-generate throw an error for it: >=20 > Generating support matrix (origin/stable-NN ) > + docs/support-matrix-generate HEAD = https://xenbits.xen.org/docs/unstable/SUPPORT.html origin/stable-NN = https://xenbits.xen.org/docs/NN-testing/SUPPORT.html > Status, x86: Supported up to 8 TiB. Hosts with more memory are > supported, but not security supported. > Status, Arm32: Supported up to 12 GiB > Status, Arm64: Supported up to 2 TiB > ^ cannot parse status codeblock line: > supported, but not security supported. > ? at docs/parse-support-md line 172, chunk 1. >=20 > It would be good to allow split support statement (to keep lines below > 80 characters) but my knowledge of the script is very limited. >=20 > Therefore, workaround the error by describing the support statement > in one long line. >=20 > Fixes: a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory = supported for Arm" > Signed-off-by: Julien Grall Acked-by: George Dunlap --Apple-Mail=_4316FA7F-0966-4832-906A-544C64B3E387 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJ41AcACgkQshXHp8eE G+2Adgf/TVuk7sM2ac1pDZFoAbJaLQEqMG+L1LNMupeso2hYBLiZnLmahclA4U12 HsHkCJYDwTgwzrIVQeeVaEEqTLz8DlfIRkRndgRSpuv2BSgqWTRPhku8sFjDe/MT JzHkDd8UMmkGSnfDI1PRVgNJ/OcEEpoSU8dpgkZ6zWa4oy1OpnsSuNv3D8PSVyzL m9LDJQsnvYPsevNm+gl29+z+4bhgPQsm+/kh3qwdDO0/1qC/vU8wjqbC7LQOSK7W UFzZQ69LWlzNulVqy1FuOomy232/vTOxcJNlDsqhxlbxhHcjJ0lIF3JmgAzleyz/ ROTwU8qwHHfSPGmwvG/sPiwaSoD1SA== =L5d+ -----END PGP SIGNATURE----- --Apple-Mail=_4316FA7F-0966-4832-906A-544C64B3E387-- From xen-devel-bounces@lists.xenproject.org Mon May 09 08:47:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324292.546265 (Exim 4.92) (envelope-from ) id 1nnz30-000584-KZ; Mon, 09 May 2022 08:47:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324292.546265; Mon, 09 May 2022 08:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnz30-00057x-FX; Mon, 09 May 2022 08:47:18 +0000 Received: by outflank-mailman (input) for mailman id 324292; Mon, 09 May 2022 08:47:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnz2y-00057r-HZ for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:47:16 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a05db9b0-cf74-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 10:47:15 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id l19so16133042ljb.7 for ; Mon, 09 May 2022 01:47:15 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id x24-20020a0565123f9800b0047255d210f9sm1873536lfa.40.2022.05.09.01.47.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 May 2022 01:47:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a05db9b0-cf74-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DYNt4TBqj6ErOEIb2vmeDUEERsqugwRt+n6gRx6FEKI=; b=Mq5M0v2gQEeCQHi//3MX5o3RITeEaX9QoaxxaxGof+tAtKg33WpCYXYGSQvBpt6SUj yzHLogFl9drbImkUax0mi+oIkGKev1MF31FmpnyWawJV76w0UQGzXgiWowRaicmtwykz c3O2p5wqFBGTbN3z5FLz8XduhQ0dH4F8oOSvTczB124rlTXcxm+o9erIB4QIl754Kth8 fGheBg0syAeef7GFsFvOSjdgJA0odNQZ53yMSLD4DS4DVCafwq9fkBg4Mef/xNddvhTC qTZpfuiF4EpLRGI982VEeiC7diU0ydRKJ+j6cDctXDUR6cd83hXaSjQgpCU5r9SNAlpM 3nqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DYNt4TBqj6ErOEIb2vmeDUEERsqugwRt+n6gRx6FEKI=; b=qqbqEIHWOJsbIiLaU1vasS8RTqEyLbDKlJS8G8bpEJGgC0la6ub4rkHdnEg8igkX3V uHPJtm4UAFVY40iRWu9H3dGvkbrmI5OmFAcz6XWLYVGh8L2bgGks3BC+0c94zeqZATcj wMdMC/0jwlAmPJer/B6elIrRP9kbmGy2zPyAbkeiZivKPrmI+HeYtr1tMAGxD57TZ6rN dtyd0WKRu06cixHa5tmhDSMu+wWbtGpgpCEcPjpdGZuwYKbTrVlWdLs3/BnldXjwzAek iA2/VPDEYmfm4KtgMNtMhf2/DY/aAtN8Gem/l5W0jNBIxlbjcwSFqdzx34BXAIGiY+GA KXjg== X-Gm-Message-State: AOAM530rGYw4Le0bweQiderqHJwb1tetjguA9YsS9S9h+Ibkwi7cJxYj 5//glchNQJq+tsjKS64lBAQ= X-Google-Smtp-Source: ABdhPJyxcF3KC3PxB+4E8Fv7u5DB6AZHIdMNTboOqQO9vjVuh8yyzTf9QASCslnG2AmUu2/UwH0Mlg== X-Received: by 2002:a2e:934b:0:b0:24f:cce:5501 with SMTP id m11-20020a2e934b000000b0024f0cce5501mr10238843ljh.443.1652086035017; Mon, 09 May 2022 01:47:15 -0700 (PDT) Subject: Re: [PATCH v3 10/21] xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-11-jgross@suse.com> From: Oleksandr Message-ID: Date: Mon, 9 May 2022 11:47:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220505081640.17425-11-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 05.05.22 11:16, Juergen Gross wrote: Hello Juergen > Instead of using a private macro for an invalid grant reference use > the common one. > > Signed-off-by: Juergen Gross > --- > V3: > - terminate grant ref list with 0 (Oleksandr Tyshchenko) Reviewed-by: Oleksandr Tyshchenko > --- > drivers/xen/xen-front-pgdir-shbuf.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c > index a959dee21134..b6433761d42c 100644 > --- a/drivers/xen/xen-front-pgdir-shbuf.c > +++ b/drivers/xen/xen-front-pgdir-shbuf.c > @@ -21,15 +21,6 @@ > > #include > > -#ifndef GRANT_INVALID_REF > -/* > - * FIXME: usage of grant reference 0 as invalid grant reference: > - * grant reference 0 is valid, but never exposed to a PV driver, > - * because of the fact it is already in use/reserved by the PV console. > - */ > -#define GRANT_INVALID_REF 0 > -#endif > - > /** > * This structure represents the structure of a shared page > * that contains grant references to the pages of the shared > @@ -38,6 +29,7 @@ > */ > struct xen_page_directory { > grant_ref_t gref_dir_next_page; > +#define XEN_GREF_LIST_END 0 > grant_ref_t gref[1]; /* Variable length */ > }; > > @@ -83,7 +75,7 @@ grant_ref_t > xen_front_pgdir_shbuf_get_dir_start(struct xen_front_pgdir_shbuf *buf) > { > if (!buf->grefs) > - return GRANT_INVALID_REF; > + return INVALID_GRANT_REF; > > return buf->grefs[0]; > } > @@ -142,7 +134,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_shbuf *buf) > int i; > > for (i = 0; i < buf->num_grefs; i++) > - if (buf->grefs[i] != GRANT_INVALID_REF) > + if (buf->grefs[i] != INVALID_GRANT_REF) > gnttab_end_foreign_access(buf->grefs[i], 0UL); > } > kfree(buf->grefs); > @@ -355,7 +347,7 @@ static void backend_fill_page_dir(struct xen_front_pgdir_shbuf *buf) > } > /* Last page must say there is no more pages. */ > page_dir = (struct xen_page_directory *)ptr; > - page_dir->gref_dir_next_page = GRANT_INVALID_REF; > + page_dir->gref_dir_next_page = XEN_GREF_LIST_END; > } > > /** > @@ -384,7 +376,7 @@ static void guest_fill_page_dir(struct xen_front_pgdir_shbuf *buf) > > if (grefs_left <= XEN_NUM_GREFS_PER_PAGE) { > to_copy = grefs_left; > - page_dir->gref_dir_next_page = GRANT_INVALID_REF; > + page_dir->gref_dir_next_page = XEN_GREF_LIST_END; > } else { > to_copy = XEN_NUM_GREFS_PER_PAGE; > page_dir->gref_dir_next_page = buf->grefs[i + 1]; -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 09 08:49:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 08:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324298.546275 (Exim 4.92) (envelope-from ) id 1nnz5K-0005kT-1A; Mon, 09 May 2022 08:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324298.546275; Mon, 09 May 2022 08:49:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnz5J-0005kM-UL; Mon, 09 May 2022 08:49:41 +0000 Received: by outflank-mailman (input) for mailman id 324298; Mon, 09 May 2022 08:49:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnz5I-0005kA-0s for xen-devel@lists.xenproject.org; Mon, 09 May 2022 08:49:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3a02bfb-cf74-11ec-a406-831a346695d4; Mon, 09 May 2022 10:49:36 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 04:49:34 -0400 Received: from PH0PR03MB6382.namprd03.prod.outlook.com (2603:10b6:510:ab::9) by DS7PR03MB5589.namprd03.prod.outlook.com (2603:10b6:5:2cd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 08:49:31 +0000 Received: from PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce]) by PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 08:49:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3a02bfb-cf74-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652086176; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uBL5yez/gVKzNfigMX7hU1FYTJ3y+nnpEpqMg/3heoU=; b=Yl/EEVEOkLc5hnCt9RtpGuzoEqrHuWYsN5bh5Qlw5AaN94yqSWSJOH81 /180wJYQ5Bo5ThqtAm+yuq0BDwWU0iwkzOFtQIAdCiSj1h0LGuz+FXUzj Kn9Z12qWwOsB1KRaR5Rdo7PlLPYwVmEVNVlKPsG0TSEa5s53dTHIPRMWR c=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 70255539 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jJiCuK6lwbY2nWjdV0oovwxRtCnGchMFZxGqfqrLsTDasY5as4F+v mdNXm7VMv7bamfweo8kao20oRlXvJKAmtQwGQJlpH0zHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhU1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSfFwd2JanVodgzdBBqKxh5IZRJ263+dC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YHgV/chegXdRraT 9AeciEpaB3PbgdQM1MTIJk/gP2plj/0dDgwRFe9+vJtvjWOl10ZPL7FKIbnStmQW8Nsh1uWh X//wkfQH0E1K4nKodaC2jf27gPVpgvgQ54bHrC88v9sgXWQy3YVBRlQUkG0ydGhg1O6c8JSL QoT4CVGhbE/8VHuQtTjUhmQpnmCsRgBHd1KHIUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbQGDq5WQQHOZs7uR8zW7PHFPKXdYPHBZCwwY/9PkvYc/yArVScpuG7K0iduzHizsx zeNr241gLB7YdM36phXNGvv21qEzqUlhCZsjukLdgpJNj9EWbM= IronPort-HdrOrdr: A9a23:76KOMaqbWHst+WCxiVtzBIIaV5uJL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7EZnirhILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wfnbimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,210,1647316800"; d="scan'208";a="70255539" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJkskl2140nx0g+xpTb3DoMZmEtsE5jKZwF49iaNbK/IONOutmf5xIobN7L32p1BgwG7sLyQwEQ3ARW8K2wTIbr1FBfCVhnOUn2/4R2hC0BzBt09dF/X4ePCJhgsZtc5ZROlaehH/IEwIZ8yIBwD0KBtzskZgvsMxzjzWyrd8ok/xJCbUvmuYhya3ifjib2SJy8iWDGit2aXiBK7XwhKNjGZLCT/uo2e1lJdMxw4oxQTwLsVSlIWusIo55JcMOkgUDpMtZOQqMTd/s1Lm0k56rTULHc38o3bPdvVBgsrDTj5sgG+7gH/H3CIjogErMnuLLxg6xaLjih6ylup9nXlCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4ffbgMF998iVYrdqam9WmKjOZmFHBmdRCUa7te/1mg=; b=UPoKsn4i66vfpa/vggpxrPA397sN04otXmzcFJSiyxxLqEC2/GVRxQGUZbWaD7Xqu14GuWapM+OFUhoCz8K/JBngqdhuMGL27+70LNN/hnJPlqJmcn7vHWnuMnjhXKWBm1FOBmzb5J3Xdu5x0dcACYauiU4hmo4lP9kHAaW0TopafBKiT3uJkO7i/mAWXCAJfRHb/AmDigpDkqo54OAho6Xcj8bGEuM63/4Q28Qj7AS3r/D4EhYoj0HkGlhNBCX6SQIeGhRfQkgU14t6xY0n/L+sr01cBNJNLc0h3HY3WWfHs1wpXZlUWlKyJUnlLbmZydH88+MqEPjFJgEcVyM39Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4ffbgMF998iVYrdqam9WmKjOZmFHBmdRCUa7te/1mg=; b=ciurISsqP6uhzcR127G1qvuyIXPCCDcvW2syruIUmCdQ7pXDyb88lAuRxuxqGvWzR2SN1mbTC/q7TyIt/lyWcahBobiDbQ2XcHIH0az+DvPFeeHR0bPPgfNiHUNiUjPlv0U+IRIRrRThe+IJezg6VD1e7sJCnQ6MRtK8s/xbGmk= From: Ross Lagerwall To: Stefano Stabellini , Anthony Perard , Paul Durrant CC: "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Topic: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Index: AQHYWlVI6k4vzeGas0CbAgtnJ0rrZq0WTf75 Date: Mon, 9 May 2022 08:49:25 +0000 Message-ID: References: <20220427163812.2461718-1-ross.lagerwall@citrix.com> In-Reply-To: <20220427163812.2461718-1-ross.lagerwall@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20355d79-b671-45b0-83aa-08da3198d24d x-ms-traffictypediagnostic: DS7PR03MB5589:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E0suAd6mbsUVhtq8x0l3LqvQTcKkMGBXoXTah3T7Awzd19M+SHIlmva0y+oSlL4Tgzib1tNYCijReX6L/VuHLZvGfLiUSrIQHCdfHWLTq+u4CcL0xyQyPy9asNn2G/Z4xpkjT8JQBya6/dki9cw/z5UOqM5K+tpkBh388Uh8IVJCD5b3DrOaqf1oy7FtvYYcmkpzpjnMJRWrneGlmsG76t/7LnbmljZDg3PrdUiPJm/jiFP2z2MFCjHKpVCgvMkLl9iZ31lioVqaBONPFKv2lU3R54oMtOel7G71cEA5Ij0++IS/A4WyWhUXnfU+7KgmT2Hy2LwVgalTDGTSQug25/1zw+IPMOCTb57kS6yWdUERz/3fx4cq87YXiYRoy9T4AMoVpV5OEyPW0noDVPQWJry8BuLMNFQfN/0zsPMVq77YJd1fYP7r3N5vrGt2fPt1Un8O8cMJuIaZypKkEfWijY62cKyMdILaXYv1I49QRl/+7xelQQW46IR2wbfphBep9urwV0z24qyE4WObnTbS18YCIhKyIMtF1g4BeQ71oDUMynOtaZdSuuHzh//tzTS7l6qnB3l5B5QZq1JD+qtSu+GX7ygJMjADdO+4Ii7EhHXO0nrZ92fF3dvlIjb6rnThjIgXYy/6QJg394FpGTuXK+lR5AeWl2skVX7GJPI/CIBXbe4rIDFoeaq6EeK98NNAdFULX6LGb/CUdPxG/ad6WA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(64756008)(66946007)(9686003)(71200400001)(26005)(66476007)(53546011)(91956017)(38100700002)(76116006)(38070700005)(4326008)(8676002)(86362001)(66446008)(33656002)(44832011)(52536014)(5660300002)(8936002)(30864003)(508600001)(7696005)(2906002)(110136005)(122000001)(54906003)(55016003)(316002)(82960400001)(83380400001)(186003)(6506007)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5NUvKspv3QgEKqxR+mz163/RjWb2oRo7uaWuqWMeVXXC/4nQ13Nl7Yt5K8?= =?iso-8859-1?Q?oFcpz+VErDkAA/RJavPNrAtvA0M/zEZwHFGcgnbEedE+3jsrgaHMFbImgf?= =?iso-8859-1?Q?JXfjYUbmNpJXBwh/FXSByc9iz5/E4E61mWVBezuiK8TB57/DZ36zX8x71g?= =?iso-8859-1?Q?Y0gT+wv3wpe3XOi9/H0mPkvbnkJ8x/n9vaWbTXrymEhcN9/wlRdnMBBLIJ?= =?iso-8859-1?Q?6H3EJDQl77ioj3SQhmPQU0DrdP9RN0h8zCQ/L6JBY6/3JO2iWbuXOcPEzr?= =?iso-8859-1?Q?aSNBFFBAZuwfhVLBn3n3ZqDMZsIqBwqLfcL2Q+LW9iSSUnzF60tZSY5d5X?= =?iso-8859-1?Q?Eouaiw+uQaQvquxneYTEMF5jfpw/aQBLD8ighhSod037T4bSzpdEmREglm?= =?iso-8859-1?Q?bLQmEtsvhOLsv/KHwbXrw9oPH1aIQKRyQLu/g2FY4V7qBJRlX6hcNXLKt5?= =?iso-8859-1?Q?ByODxc3XA82pBpd/SNQmzC9MQ2LoC85E/jqiKgxQKMb6q/ehzRpOuUMkkI?= =?iso-8859-1?Q?BZPfn6UffUqyX5PQE8KStsmNzIiR/V6VdSy2FI539ry9TgAySaOuTggS9M?= =?iso-8859-1?Q?cxaQMAdIqA+Ji0uj9MML50M+V7XWDLSKC2ZujG9LDR8t3XcpXJsQcKN6Gv?= =?iso-8859-1?Q?gktPnn4isFvsRkQFqJe9A/T9zYznlEAonrTlgAGavayref4xDmJwpoqj36?= =?iso-8859-1?Q?jg/L2Ea4Rq+jmfF1Z3pbO6eedKhiViu8FlGUesSYk4yHwatucVw+oa5fdj?= =?iso-8859-1?Q?eUpd4H3TR1UO5cNl/nQeRyosBNTUHj+Atqip8xNUKOaUo/oZMIr57mxFwT?= =?iso-8859-1?Q?Hd2zWIF5uADvnPbS3RE7bNxR5ZQZXJjJat8z9snOYxzM6lIW8MxlM9NiEL?= =?iso-8859-1?Q?USiF8l2EhG1ZttjxcWWEDKKKD8kgTWgXNxiahivEMwwPLl98b8Pps56j5u?= =?iso-8859-1?Q?5yFirZQ5rZL/kiMRvPDhq+SYZ9SSO16OepeHtPZ5gZsLEwSll3JUzAgDa3?= =?iso-8859-1?Q?XW4yr/cJtKpsIp/hS5l6c/js2WVlsFlBYNs3XXky8G7nGfaQVlYdbDF1S6?= =?iso-8859-1?Q?l1fSlEtRXhs3hMPNCmtJOJ8qbVnrP1lS8YV8czbQpcCZXQMPMG9q1GTsYa?= =?iso-8859-1?Q?IL6ROPokVOVFWvcdG6gcq7hGIZ9R9bFU1oM4YqVTTX6D7kbwtwnzZLVmmi?= =?iso-8859-1?Q?5q7u5iT0CnZCt3UBlZkmnmbNJV2iZWObK207RUAlY8E3bopi5qQEM83puG?= =?iso-8859-1?Q?k8++R2J+GfGn8OesxZbAe481OMtRA7taPw4RVw0GT0jjA1dwloqqV+jkxt?= =?iso-8859-1?Q?KAaaaiaAbpY7wDO6SDAQSHeNU+l7qgotbl+fwlS04RXBplX7w34rbcUnCa?= =?iso-8859-1?Q?p45Nx3YHbvMQHkok5VE8rOwcUeF4Sm1OQAwfl1f5KJaI5u1zDPI+KhbZjC?= =?iso-8859-1?Q?jCRoUeSjkBgeQJSnvFjOxV5ig9FaeL7gFuJ82gFJHA+nIKajv9ZqdabN90?= =?iso-8859-1?Q?HWWKhfSwF4I1Z28+EIU2PEz6VP+MgPOpkqGgMo59W8mU32hUZiQgfmKIdx?= =?iso-8859-1?Q?gLi9d9rPGEOfvSckkWtGKjjGESU3lDPpuTEyxsvps52kmBoqQXPCJ5vsRJ?= =?iso-8859-1?Q?Ogq2EGbJbJi1/3ZEniCdiATsiKehaRnDPEGb6OJeiAFrvSC+ICDbIyIdnD?= =?iso-8859-1?Q?s76PHIDHmw2AvM8l0bt5MXhDGv8iKkqHxgShXfceMMQjtM1u1+KIxKRx5Q?= =?iso-8859-1?Q?NAIU/vbj1lJADYo1v0ZoSIWPOJATKL8edVqXcgQWRdmM4+cHie526dKbHx?= =?iso-8859-1?Q?yU/IRrYj0l6zPXuh/CsfVGr+djLl3lE=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20355d79-b671-45b0-83aa-08da3198d24d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 08:49:25.6151 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7VrMOW0jcdCt6tFZsQgJ9MwmJ7f29EOpYTxPS8ZgtTc0MkFqZAR+2B8HJeJTduHIz+QbPsLWdPUXjImQmUTTjG3JMMmk/5OoQshiTyy12LU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5589 Ping?=0A= =0A= > From: Ross Lagerwall =0A= > Sent: Wednesday, April 27, 2022 5:38 PM=0A= > To: xen-devel@lists.xenproject.org =0A= > Cc: Stefano Stabellini ; Anthony Perard ; Paul Durrant ; qemu-devel@nongnu.org ; Ross Lagerwall =0A= > Subject: [PATCH] xen/pt: Avoid initializing BARs from the host ones =0A= > =0A= > The BAR emulated register definition does not set emu_mask because it=0A= > varies depending on bar_flag. If emu_mask is not set, then the BAR is=0A= > initialized based on the host value which causes the BAR to be initially= =0A= > mapped at whatever value the host device was using. Although it does=0A= > eventually get mapped at the correct location, it causes unnecessary=0A= > mapping/unmappings.=0A= > =0A= > To fix this, initialize a per-register emu_mask in XenPTReg from the=0A= > initial value in XenPTRegInfo and then let the register's init() function= =0A= > set/modify the emu_mask if necessary. Update the code to use emu_mask=0A= > in XenPTReg consistently and rename the existing emu_mask in=0A= > XenPTRegInfo to emu_mask_init to help with refactoring.=0A= > =0A= > Signed-off-by: Ross Lagerwall =0A= > ---=0A= > hw/xen/xen_pt.c | 2 +-=0A= > hw/xen/xen_pt.h | 5 +-=0A= > hw/xen/xen_pt_config_init.c | 221 ++++++++++++++++++------------------= =0A= > 3 files changed, 115 insertions(+), 113 deletions(-)=0A= > =0A= > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c=0A= > index 027190fa44..f0af1cfcec 100644=0A= > --- a/hw/xen/xen_pt.c=0A= > +++ b/hw/xen/xen_pt.c=0A= > @@ -327,7 +327,7 @@ static void xen_pt_pci_write_config(PCIDevice *d, uin= t32_t addr,=0A= > uint32_t real_offset =3D reg_grp_entry->base_offset + reg->o= ffset;=0A= > uint32_t valid_mask =3D 0xFFFFFFFF >> ((4 - emul_len) << 3);= =0A= > uint8_t *ptr_val =3D NULL;=0A= > - uint32_t wp_mask =3D reg->emu_mask | reg->ro_mask;=0A= > + uint32_t wp_mask =3D reg_entry->emu_mask | reg->ro_mask;=0A= > =0A= > valid_mask <<=3D (find_addr - real_offset) << 3;=0A= > ptr_val =3D (uint8_t *)&val + (real_offset & 3);=0A= > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h=0A= > index 6b8e13cdee..dbb917a46c 100644=0A= > --- a/hw/xen/xen_pt.h=0A= > +++ b/hw/xen/xen_pt.h=0A= > @@ -46,7 +46,7 @@ void igd_write_opregion(XenPCIPassthroughState *s, uint= 32_t val);=0A= > =0A= > /* function type for config reg */=0A= > typedef int (*xen_pt_conf_reg_init)=0A= > - (XenPCIPassthroughState *, XenPTRegInfo *, uint32_t real_offset,=0A= > + (XenPCIPassthroughState *, XenPTReg *, uint32_t real_offset,=0A= > uint32_t *data);=0A= > typedef int (*xen_pt_conf_dword_write)=0A= > (XenPCIPassthroughState *, XenPTReg *cfg_entry,=0A= > @@ -117,7 +117,7 @@ struct XenPTRegInfo {=0A= > /* reg read/write-1-clear field mask (ON:RW1C/RW1CS, OFF:other) */= =0A= > uint32_t rw1c_mask;=0A= > /* reg emulate field mask (ON:emu, OFF:passthrough) */=0A= > - uint32_t emu_mask;=0A= > + uint32_t emu_mask_init;=0A= > xen_pt_conf_reg_init init;=0A= > /* read/write function pointer=0A= > * for double_word/word/byte size */=0A= > @@ -146,6 +146,7 @@ struct XenPTReg {=0A= > uint16_t *half_word;=0A= > uint32_t *word;=0A= > } ptr; /* pointer to dev.config. */=0A= > + uint32_t emu_mask;=0A= > };=0A= > =0A= > typedef const struct XenPTRegGroupInfo XenPTRegGroupInfo;=0A= > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c=0A= > index c5c4e943a8..2a934494ed 100644=0A= > --- a/hw/xen/xen_pt_config_init.c=0A= > +++ b/hw/xen/xen_pt_config_init.c=0A= > @@ -25,7 +25,7 @@=0A= > =0A= > /* prototype */=0A= > =0A= > -static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s, XenPTRegInfo *= reg,=0A= > +static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s, XenPTReg *reg_= entry,=0A= > uint32_t real_offset, uint32_t *data);=0A= > =0A= > =0A= > @@ -98,9 +98,10 @@ XenPTReg *xen_pt_find_reg(XenPTRegGroup *reg_grp, uint= 32_t address)=0A= > }=0A= > =0A= > static uint32_t get_throughable_mask(const XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t valid_m= ask)=0A= > + XenPTReg *reg_entry, uint32_t valid= _mask)=0A= > {=0A= > - uint32_t throughable_mask =3D ~(reg->emu_mask | reg->ro_mask);=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > + uint32_t throughable_mask =3D ~(reg_entry->emu_mask | reg->ro_mask);= =0A= > =0A= > if (!s->permissive) {=0A= > throughable_mask &=3D ~reg->res_mask;=0A= > @@ -116,10 +117,10 @@ static uint32_t get_throughable_mask(const XenPCIPa= ssthroughState *s,=0A= > /* register initialization function */=0A= > =0A= > static int xen_pt_common_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offse= t,=0A= > + XenPTReg *reg_entry, uint32_t real_off= set,=0A= > uint32_t *data)=0A= > {=0A= > - *data =3D reg->init_val;=0A= > + *data =3D reg_entry->reg->init_val;=0A= > return 0;=0A= > }=0A= > =0A= > @@ -128,12 +129,11 @@ static int xen_pt_common_reg_init(XenPCIPassthrough= State *s,=0A= > static int xen_pt_byte_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg= _entry,=0A= > uint8_t *value, uint8_t valid_mask)=0A= > {=0A= > - XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint8_t valid_emu_mask =3D 0;=0A= > uint8_t *data =3D cfg_entry->ptr.byte;=0A= > =0A= > /* emulate byte register */=0A= > - valid_emu_mask =3D reg->emu_mask & valid_mask;=0A= > + valid_emu_mask =3D cfg_entry->emu_mask & valid_mask;=0A= > *value =3D XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);=0A= > =0A= > return 0;=0A= > @@ -141,12 +141,11 @@ static int xen_pt_byte_reg_read(XenPCIPassthroughSt= ate *s, XenPTReg *cfg_entry,=0A= > static int xen_pt_word_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg= _entry,=0A= > uint16_t *value, uint16_t valid_mask)=0A= > {=0A= > - XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint16_t valid_emu_mask =3D 0;=0A= > uint16_t *data =3D cfg_entry->ptr.half_word;=0A= > =0A= > /* emulate word register */=0A= > - valid_emu_mask =3D reg->emu_mask & valid_mask;=0A= > + valid_emu_mask =3D cfg_entry->emu_mask & valid_mask;=0A= > *value =3D XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);=0A= > =0A= > return 0;=0A= > @@ -154,12 +153,11 @@ static int xen_pt_word_reg_read(XenPCIPassthroughSt= ate *s, XenPTReg *cfg_entry,=0A= > static int xen_pt_long_reg_read(XenPCIPassthroughState *s, XenPTReg *cfg= _entry,=0A= > uint32_t *value, uint32_t valid_mask)=0A= > {=0A= > - XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint32_t valid_emu_mask =3D 0;=0A= > uint32_t *data =3D cfg_entry->ptr.word;=0A= > =0A= > /* emulate long register */=0A= > - valid_emu_mask =3D reg->emu_mask & valid_mask;=0A= > + valid_emu_mask =3D cfg_entry->emu_mask & valid_mask;=0A= > *value =3D XEN_PT_MERGE_VALUE(*value, *data, ~valid_emu_mask);=0A= > =0A= > return 0;=0A= > @@ -173,11 +171,11 @@ static int xen_pt_byte_reg_write(XenPCIPassthroughS= tate *s, XenPTReg *cfg_entry,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint8_t writable_mask =3D 0;=0A= > - uint8_t throughable_mask =3D get_throughable_mask(s, reg, valid_mask= );=0A= > + uint8_t throughable_mask =3D get_throughable_mask(s, cfg_entry, vali= d_mask);=0A= > uint8_t *data =3D cfg_entry->ptr.byte;=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > =0A= > /* create value for writing to I/O device register */=0A= > @@ -192,11 +190,11 @@ static int xen_pt_word_reg_write(XenPCIPassthroughS= tate *s, XenPTReg *cfg_entry,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint16_t writable_mask =3D 0;=0A= > - uint16_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint16_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > uint16_t *data =3D cfg_entry->ptr.half_word;=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > =0A= > /* create value for writing to I/O device register */=0A= > @@ -211,11 +209,11 @@ static int xen_pt_long_reg_write(XenPCIPassthroughS= tate *s, XenPTReg *cfg_entry,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint32_t writable_mask =3D 0;=0A= > - uint32_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint32_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > uint32_t *data =3D cfg_entry->ptr.word;=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > =0A= > /* create value for writing to I/O device register */=0A= > @@ -229,7 +227,7 @@ static int xen_pt_long_reg_write(XenPCIPassthroughSta= te *s, XenPTReg *cfg_entry,=0A= > /* XenPTRegInfo declaration=0A= > * - only for emulated register (either a part or whole bit).=0A= > * - for passthrough register that need special behavior (like interacti= ng with=0A= > - * other component), set emu_mask to all 0 and specify r/w func proper= ly.=0A= > + * other component), set emu_mask_init to all 0 and specify r/w func p= roperly.=0A= > * - do NOT use ALL F for init_val, otherwise the tbl will not be regist= ered.=0A= > */=0A= > =0A= > @@ -238,21 +236,21 @@ static int xen_pt_long_reg_write(XenPCIPassthroughS= tate *s, XenPTReg *cfg_entry,=0A= > */=0A= > =0A= > static int xen_pt_vendor_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offse= t,=0A= > + XenPTReg *reg_entry, uint32_t real_off= set,=0A= > uint32_t *data)=0A= > {=0A= > *data =3D s->real_device.vendor_id;=0A= > return 0;=0A= > }=0A= > static int xen_pt_device_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offse= t,=0A= > + XenPTReg *reg_entry, uint32_t real_off= set,=0A= > uint32_t *data)=0A= > {=0A= > *data =3D s->real_device.device_id;=0A= > return 0;=0A= > }=0A= > static int xen_pt_status_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offse= t,=0A= > + XenPTReg *unused, uint32_t real_offset= ,=0A= > uint32_t *data)=0A= > {=0A= > XenPTRegGroup *reg_grp_entry =3D NULL;=0A= > @@ -287,17 +285,17 @@ static int xen_pt_status_reg_init(XenPCIPassthrough= State *s,=0A= > return 0;=0A= > }=0A= > static int xen_pt_header_type_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_= offset,=0A= > - uint32_t *data)=0A= > + XenPTReg *reg_entry,=0A= > + uint32_t real_offset, uint32_t *d= ata)=0A= > {=0A= > /* read PCI_HEADER_TYPE */=0A= > - *data =3D reg->init_val | 0x80;=0A= > + *data =3D reg_entry->reg->init_val | 0x80;=0A= > return 0;=0A= > }=0A= > =0A= > /* initialize Interrupt Pin register */=0A= > static int xen_pt_irqpin_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offse= t,=0A= > + XenPTReg *reg_entry, uint32_t real_off= set,=0A= > uint32_t *data)=0A= > {=0A= > if (s->real_device.irq) {=0A= > @@ -313,7 +311,7 @@ static int xen_pt_cmd_reg_write(XenPCIPassthroughStat= e *s, XenPTReg *cfg_entry,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint16_t writable_mask =3D 0;=0A= > - uint16_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint16_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > uint16_t *data =3D cfg_entry->ptr.half_word;=0A= > =0A= > /* modify emulate register */=0A= > @@ -405,13 +403,13 @@ static inline uint32_t base_address_with_flags(XenH= ostPCIIORegion *hr)=0A= > }=0A= > }=0A= > =0A= > -static int xen_pt_bar_reg_init(XenPCIPassthroughState *s, XenPTRegInfo *= reg,=0A= > +static int xen_pt_bar_reg_init(XenPCIPassthroughState *s, XenPTReg *reg_= entry,=0A= > uint32_t real_offset, uint32_t *data)=0A= > {=0A= > uint32_t reg_field =3D 0;=0A= > int index;=0A= > =0A= > - index =3D xen_pt_bar_offset_to_index(reg->offset);=0A= > + index =3D xen_pt_bar_offset_to_index(reg_entry->reg->offset);=0A= > if (index < 0 || index >=3D PCI_NUM_REGIONS) {=0A= > XEN_PT_ERR(&s->dev, "Internal error: Invalid BAR index [%d].\n",= index);=0A= > return -1;=0A= > @@ -423,6 +421,21 @@ static int xen_pt_bar_reg_init(XenPCIPassthroughStat= e *s, XenPTRegInfo *reg,=0A= > reg_field =3D XEN_PT_INVALID_REG;=0A= > }=0A= > =0A= > + /* set emulate mask depend on BAR flag */=0A= > + switch (s->bases[index].bar_flag) {=0A= > + case XEN_PT_BAR_FLAG_MEM:=0A= > + reg_entry->emu_mask =3D XEN_PT_BAR_MEM_EMU_MASK;=0A= > + break;=0A= > + case XEN_PT_BAR_FLAG_IO:=0A= > + reg_entry->emu_mask =3D XEN_PT_BAR_IO_EMU_MASK;=0A= > + break;=0A= > + case XEN_PT_BAR_FLAG_UPPER:=0A= > + reg_entry->emu_mask =3D XEN_PT_BAR_ALLF;=0A= > + break;=0A= > + default:=0A= > + break;=0A= > + }=0A= > +=0A= > *data =3D reg_field;=0A= > return 0;=0A= > }=0A= > @@ -431,7 +444,6 @@ static int xen_pt_bar_reg_read(XenPCIPassthroughState= *s, XenPTReg *cfg_entry,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint32_t valid_emu_mask =3D 0;=0A= > - uint32_t bar_emu_mask =3D 0;=0A= > int index;=0A= > =0A= > /* get BAR index */=0A= > @@ -444,23 +456,8 @@ static int xen_pt_bar_reg_read(XenPCIPassthroughStat= e *s, XenPTReg *cfg_entry,=0A= > /* use fixed-up value from kernel sysfs */=0A= > *value =3D base_address_with_flags(&s->real_device.io_regions[index]= );=0A= > =0A= > - /* set emulate mask depend on BAR flag */=0A= > - switch (s->bases[index].bar_flag) {=0A= > - case XEN_PT_BAR_FLAG_MEM:=0A= > - bar_emu_mask =3D XEN_PT_BAR_MEM_EMU_MASK;=0A= > - break;=0A= > - case XEN_PT_BAR_FLAG_IO:=0A= > - bar_emu_mask =3D XEN_PT_BAR_IO_EMU_MASK;=0A= > - break;=0A= > - case XEN_PT_BAR_FLAG_UPPER:=0A= > - bar_emu_mask =3D XEN_PT_BAR_ALLF;=0A= > - break;=0A= > - default:=0A= > - break;=0A= > - }=0A= > -=0A= > /* emulate BAR */=0A= > - valid_emu_mask =3D bar_emu_mask & valid_mask;=0A= > + valid_emu_mask =3D cfg_entry->emu_mask & valid_mask;=0A= > *value =3D XEN_PT_MERGE_VALUE(*value, *cfg_entry->ptr.word, ~valid_e= mu_mask);=0A= > =0A= > return 0;=0A= > @@ -474,7 +471,6 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughStat= e *s, XenPTReg *cfg_entry,=0A= > PCIDevice *d =3D PCI_DEVICE(s);=0A= > const PCIIORegion *r;=0A= > uint32_t writable_mask =3D 0;=0A= > - uint32_t bar_emu_mask =3D 0;=0A= > uint32_t bar_ro_mask =3D 0;=0A= > uint32_t r_size =3D 0;=0A= > int index =3D 0;=0A= > @@ -493,7 +489,6 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughStat= e *s, XenPTReg *cfg_entry,=0A= > /* set emulate mask and read-only mask values depend on the BAR flag= */=0A= > switch (s->bases[index].bar_flag) {=0A= > case XEN_PT_BAR_FLAG_MEM:=0A= > - bar_emu_mask =3D XEN_PT_BAR_MEM_EMU_MASK;=0A= > if (!r_size) {=0A= > /* low 32 bits mask for 64 bit bars */=0A= > bar_ro_mask =3D XEN_PT_BAR_ALLF;=0A= > @@ -502,13 +497,11 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughSt= ate *s, XenPTReg *cfg_entry,=0A= > }=0A= > break;=0A= > case XEN_PT_BAR_FLAG_IO:=0A= > - bar_emu_mask =3D XEN_PT_BAR_IO_EMU_MASK;=0A= > bar_ro_mask =3D XEN_PT_BAR_IO_RO_MASK | (r_size - 1);=0A= > break;=0A= > case XEN_PT_BAR_FLAG_UPPER:=0A= > assert(index > 0);=0A= > r_size =3D d->io_regions[index - 1].size >> 32;=0A= > - bar_emu_mask =3D XEN_PT_BAR_ALLF;=0A= > bar_ro_mask =3D r_size ? r_size - 1 : 0;=0A= > break;=0A= > default:=0A= > @@ -516,7 +509,7 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughStat= e *s, XenPTReg *cfg_entry,=0A= > }=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D bar_emu_mask & ~bar_ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~bar_ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > =0A= > /* check whether we need to update the virtual region address or not= */=0A= > @@ -547,7 +540,7 @@ static int xen_pt_exp_rom_bar_reg_write(XenPCIPassthr= oughState *s,=0A= > XenPTRegion *base =3D NULL;=0A= > PCIDevice *d =3D PCI_DEVICE(s);=0A= > uint32_t writable_mask =3D 0;=0A= > - uint32_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint32_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > pcibus_t r_size =3D 0;=0A= > uint32_t bar_ro_mask =3D 0;=0A= > uint32_t *data =3D cfg_entry->ptr.word;=0A= > @@ -594,7 +587,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xFFFF,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_vendor_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -605,7 +598,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xFFFF,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_device_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -616,7 +609,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .res_mask =3D 0xF880,=0A= > - .emu_mask =3D 0x0743,=0A= > + .emu_mask_init =3D 0x0743,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_cmd_reg_write,=0A= > @@ -627,7 +620,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -643,7 +636,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .res_mask =3D 0x0007,=0A= > .ro_mask =3D 0x06F8,=0A= > .rw1c_mask =3D 0xF900,=0A= > - .emu_mask =3D 0x0010,=0A= > + .emu_mask_init =3D 0x0010,=0A= > .init =3D xen_pt_status_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -654,7 +647,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0x00,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -665,7 +658,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0x00,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -676,7 +669,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0x00,=0A= > + .emu_mask_init =3D 0x00,=0A= > .init =3D xen_pt_header_type_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -687,7 +680,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0x00,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -698,7 +691,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_irqpin_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -764,7 +757,7 @@ static XenPTRegInfo xen_pt_emu_reg_header0[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D ~PCI_ROM_ADDRESS_MASK & ~PCI_ROM_ADDRESS_ENABLE,= =0A= > - .emu_mask =3D (uint32_t)PCI_ROM_ADDRESS_MASK,=0A= > + .emu_mask_init =3D (uint32_t)PCI_ROM_ADDRESS_MASK,=0A= > .init =3D xen_pt_bar_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_exp_rom_bar_reg_write,=0A= > @@ -786,7 +779,7 @@ static XenPTRegInfo xen_pt_emu_reg_vpd[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -795,7 +788,7 @@ static XenPTRegInfo xen_pt_emu_reg_vpd[] =3D {=0A= > .offset =3D PCI_VPD_ADDR,=0A= > .size =3D 2,=0A= > .ro_mask =3D 0x0003,=0A= > - .emu_mask =3D 0x0003,=0A= > + .emu_mask_init =3D 0x0003,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -817,7 +810,7 @@ static XenPTRegInfo xen_pt_emu_reg_vendor[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -854,9 +847,10 @@ static inline uint8_t get_device_type(XenPCIPassthro= ughState *s,=0A= > =0A= > /* initialize Link Control register */=0A= > static int xen_pt_linkctrl_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_off= set,=0A= > + XenPTReg *reg_entry, uint32_t real_o= ffset,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint8_t cap_ver =3D get_capability_version(s, real_offset - reg->off= set);=0A= > uint8_t dev_type =3D get_device_type(s, real_offset - reg->offset);= =0A= > =0A= > @@ -872,9 +866,10 @@ static int xen_pt_linkctrl_reg_init(XenPCIPassthroug= hState *s,=0A= > }=0A= > /* initialize Device Control 2 register */=0A= > static int xen_pt_devctrl2_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_off= set,=0A= > + XenPTReg *reg_entry, uint32_t real_o= ffset,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint8_t cap_ver =3D get_capability_version(s, real_offset - reg->off= set);=0A= > =0A= > /* no need to initialize in case of cap_ver 1.x */=0A= > @@ -887,9 +882,10 @@ static int xen_pt_devctrl2_reg_init(XenPCIPassthroug= hState *s,=0A= > }=0A= > /* initialize Link Control 2 register */=0A= > static int xen_pt_linkctrl2_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_of= fset,=0A= > + XenPTReg *reg_entry, uint32_t real_= offset,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint8_t cap_ver =3D get_capability_version(s, real_offset - reg->off= set);=0A= > uint32_t reg_field =3D 0;=0A= > =0A= > @@ -921,7 +917,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -932,7 +928,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0xFFFFFFFF,=0A= > - .emu_mask =3D 0x10000000,=0A= > + .emu_mask_init =3D 0x10000000,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_long_reg_write,=0A= > @@ -943,7 +939,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x2810,=0A= > .ro_mask =3D 0x8400,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -965,7 +961,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xFC34,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_linkctrl_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -986,7 +982,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xFFE0,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_devctrl2_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -997,7 +993,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xE040,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_linkctrl2_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -1020,7 +1016,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -1031,7 +1027,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0xFFFF,=0A= > - .emu_mask =3D 0xF9C8,=0A= > + .emu_mask_init =3D 0xF9C8,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -1044,7 +1040,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] =3D {=0A= > .res_mask =3D 0x00F0,=0A= > .ro_mask =3D 0x610C,=0A= > .rw1c_mask =3D 0x8000,=0A= > - .emu_mask =3D 0x810B,=0A= > + .emu_mask_init =3D 0x810B,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_word_reg_write,=0A= > @@ -1066,7 +1062,7 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] =3D {=0A= > =0A= > /* Message Control register */=0A= > static int xen_pt_msgctrl_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offs= et,=0A= > + XenPTReg *reg_entry, uint32_t real_of= fset,=0A= > uint32_t *data)=0A= > {=0A= > XenPTMSI *msi =3D s->msi;=0A= > @@ -1088,7 +1084,7 @@ static int xen_pt_msgctrl_reg_init(XenPCIPassthroug= hState *s,=0A= > msi->initialized =3D false;=0A= > msi->mapped =3D false;=0A= > =0A= > - *data =3D reg->init_val;=0A= > + *data =3D reg_entry->reg->init_val;=0A= > return 0;=0A= > }=0A= > static int xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,=0A= > @@ -1098,7 +1094,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthrou= ghState *s,=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > XenPTMSI *msi =3D s->msi;=0A= > uint16_t writable_mask =3D 0;=0A= > - uint16_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint16_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > uint16_t *data =3D cfg_entry->ptr.half_word;=0A= > =0A= > /* Currently no support for multi-vector */=0A= > @@ -1107,7 +1103,7 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthrou= ghState *s,=0A= > }=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > msi->flags |=3D *data & ~PCI_MSI_FLAGS_ENABLE;=0A= > =0A= > @@ -1148,14 +1144,14 @@ static int xen_pt_msgctrl_reg_write(XenPCIPassthr= oughState *s,=0A= > =0A= > /* initialize Message Upper Address register */=0A= > static int xen_pt_msgaddr64_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_of= fset,=0A= > + XenPTReg *reg_entry, uint32_t real_= offset,=0A= > uint32_t *data)=0A= > {=0A= > /* no need to initialize in case of 32 bit type */=0A= > if (!(s->msi->flags & PCI_MSI_FLAGS_64BIT)) {=0A= > *data =3D XEN_PT_INVALID_REG;=0A= > } else {=0A= > - *data =3D reg->init_val;=0A= > + *data =3D reg_entry->reg->init_val;=0A= > }=0A= > =0A= > return 0;=0A= > @@ -1163,15 +1159,16 @@ static int xen_pt_msgaddr64_reg_init(XenPCIPassth= roughState *s,=0A= > /* this function will be called twice (for 32 bit and 64 bit type) */=0A= > /* initialize Message Data register */=0A= > static int xen_pt_msgdata_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offs= et,=0A= > + XenPTReg *reg_entry, uint32_t real_of= fset,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint32_t flags =3D s->msi->flags;=0A= > uint32_t offset =3D reg->offset;=0A= > =0A= > /* check the offset whether matches the type or not */=0A= > if (xen_pt_msi_check_type(offset, flags, DATA)) {=0A= > - *data =3D reg->init_val;=0A= > + *data =3D reg_entry->reg->init_val;=0A= > } else {=0A= > *data =3D XEN_PT_INVALID_REG;=0A= > }=0A= > @@ -1181,9 +1178,10 @@ static int xen_pt_msgdata_reg_init(XenPCIPassthrou= ghState *s,=0A= > /* this function will be called twice (for 32 bit and 64 bit type) */=0A= > /* initialize Mask register */=0A= > static int xen_pt_mask_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offset,= =0A= > + XenPTReg *reg_entry, uint32_t real_offse= t,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint32_t flags =3D s->msi->flags;=0A= > =0A= > /* check the offset whether matches the type or not */=0A= > @@ -1200,9 +1198,10 @@ static int xen_pt_mask_reg_init(XenPCIPassthroughS= tate *s,=0A= > /* this function will be called twice (for 32 bit and 64 bit type) */=0A= > /* initialize Pending register */=0A= > static int xen_pt_pending_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offs= et,=0A= > + XenPTReg *reg_entry, uint32_t real_of= fset,=0A= > uint32_t *data)=0A= > {=0A= > + XenPTRegInfo *reg =3D reg_entry->reg;=0A= > uint32_t flags =3D s->msi->flags;=0A= > =0A= > /* check the offset whether matches the type or not */=0A= > @@ -1227,7 +1226,7 @@ static int xen_pt_msgaddr32_reg_write(XenPCIPassthr= oughState *s,=0A= > uint32_t *data =3D cfg_entry->ptr.word;=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > s->msi->addr_lo =3D *data;=0A= > =0A= > @@ -1261,7 +1260,7 @@ static int xen_pt_msgaddr64_reg_write(XenPCIPassthr= oughState *s,=0A= > }=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > /* update the msi_info too */=0A= > s->msi->addr_hi =3D *data;=0A= > @@ -1301,7 +1300,7 @@ static int xen_pt_msgdata_reg_write(XenPCIPassthrou= ghState *s,=0A= > }=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > /* update the msi_info too */=0A= > msi->data =3D *data;=0A= > @@ -1343,7 +1342,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -1355,7 +1354,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .init_val =3D 0x0000,=0A= > .res_mask =3D 0xFE00,=0A= > .ro_mask =3D 0x018E,=0A= > - .emu_mask =3D 0x017E,=0A= > + .emu_mask_init =3D 0x017E,=0A= > .init =3D xen_pt_msgctrl_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_msgctrl_reg_write,=0A= > @@ -1366,7 +1365,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0x00000003,=0A= > - .emu_mask =3D 0xFFFFFFFF,=0A= > + .emu_mask_init =3D 0xFFFFFFFF,=0A= > .init =3D xen_pt_common_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_msgaddr32_reg_write,=0A= > @@ -1377,7 +1376,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0x00000000,=0A= > - .emu_mask =3D 0xFFFFFFFF,=0A= > + .emu_mask_init =3D 0xFFFFFFFF,=0A= > .init =3D xen_pt_msgaddr64_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_msgaddr64_reg_write,=0A= > @@ -1388,7 +1387,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0x0000,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_msgdata_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_msgdata_reg_write,=0A= > @@ -1399,7 +1398,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 2,=0A= > .init_val =3D 0x0000,=0A= > .ro_mask =3D 0x0000,=0A= > - .emu_mask =3D 0xFFFF,=0A= > + .emu_mask_init =3D 0xFFFF,=0A= > .init =3D xen_pt_msgdata_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_msgdata_reg_write,=0A= > @@ -1410,7 +1409,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0xFFFFFFFF,=0A= > - .emu_mask =3D 0xFFFFFFFF,=0A= > + .emu_mask_init =3D 0xFFFFFFFF,=0A= > .init =3D xen_pt_mask_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_mask_reg_write,=0A= > @@ -1421,7 +1420,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0xFFFFFFFF,=0A= > - .emu_mask =3D 0xFFFFFFFF,=0A= > + .emu_mask_init =3D 0xFFFFFFFF,=0A= > .init =3D xen_pt_mask_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_mask_reg_write,=0A= > @@ -1432,7 +1431,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0xFFFFFFFF,=0A= > - .emu_mask =3D 0x00000000,=0A= > + .emu_mask_init =3D 0x00000000,=0A= > .init =3D xen_pt_pending_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_long_reg_write,=0A= > @@ -1443,7 +1442,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > .size =3D 4,=0A= > .init_val =3D 0x00000000,=0A= > .ro_mask =3D 0xFFFFFFFF,=0A= > - .emu_mask =3D 0x00000000,=0A= > + .emu_mask_init =3D 0x00000000,=0A= > .init =3D xen_pt_pending_reg_init,=0A= > .u.dw.read =3D xen_pt_long_reg_read,=0A= > .u.dw.write =3D xen_pt_long_reg_write,=0A= > @@ -1460,7 +1459,7 @@ static XenPTRegInfo xen_pt_emu_reg_msi[] =3D {=0A= > =0A= > /* Message Control register for MSI-X */=0A= > static int xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_off= set,=0A= > + XenPTReg *reg_entry, uint32_t real_o= ffset,=0A= > uint32_t *data)=0A= > {=0A= > uint16_t reg_field;=0A= > @@ -1479,7 +1478,7 @@ static int xen_pt_msixctrl_reg_init(XenPCIPassthrou= ghState *s,=0A= > =0A= > s->msix->ctrl_offset =3D real_offset;=0A= > =0A= > - *data =3D reg->init_val;=0A= > + *data =3D reg_entry->reg->init_val;=0A= > return 0;=0A= > }=0A= > static int xen_pt_msixctrl_reg_write(XenPCIPassthroughState *s,=0A= > @@ -1488,12 +1487,12 @@ static int xen_pt_msixctrl_reg_write(XenPCIPassth= roughState *s,=0A= > {=0A= > XenPTRegInfo *reg =3D cfg_entry->reg;=0A= > uint16_t writable_mask =3D 0;=0A= > - uint16_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k);=0A= > + uint16_t throughable_mask =3D get_throughable_mask(s, cfg_entry, val= id_mask);=0A= > int debug_msix_enabled_old;=0A= > uint16_t *data =3D cfg_entry->ptr.half_word;=0A= > =0A= > /* modify emulate register */=0A= > - writable_mask =3D reg->emu_mask & ~reg->ro_mask & valid_mask;=0A= > + writable_mask =3D cfg_entry->emu_mask & ~reg->ro_mask & valid_mask;= =0A= > *data =3D XEN_PT_MERGE_VALUE(*val, *data, writable_mask);=0A= > =0A= > /* create value for writing to I/O device register */=0A= > @@ -1527,7 +1526,7 @@ static XenPTRegInfo xen_pt_emu_reg_msix[] =3D {=0A= > .size =3D 1,=0A= > .init_val =3D 0x00,=0A= > .ro_mask =3D 0xFF,=0A= > - .emu_mask =3D 0xFF,=0A= > + .emu_mask_init =3D 0xFF,=0A= > .init =3D xen_pt_ptr_reg_init,=0A= > .u.b.read =3D xen_pt_byte_reg_read,=0A= > .u.b.write =3D xen_pt_byte_reg_write,=0A= > @@ -1539,7 +1538,7 @@ static XenPTRegInfo xen_pt_emu_reg_msix[] =3D {=0A= > .init_val =3D 0x0000,=0A= > .res_mask =3D 0x3800,=0A= > .ro_mask =3D 0x07FF,=0A= > - .emu_mask =3D 0x0000,=0A= > + .emu_mask_init =3D 0x0000,=0A= > .init =3D xen_pt_msixctrl_reg_init,=0A= > .u.w.read =3D xen_pt_word_reg_read,=0A= > .u.w.write =3D xen_pt_msixctrl_reg_write,=0A= > @@ -1555,7 +1554,7 @@ static XenPTRegInfo xen_pt_emu_reg_igd_opregion[] = =3D {=0A= > .offset =3D 0x0,=0A= > .size =3D 4,=0A= > .init_val =3D 0,=0A= > - .emu_mask =3D 0xFFFFFFFF,=0A= > + .emu_mask_init =3D 0xFFFFFFFF,=0A= > .u.dw.read =3D xen_pt_intel_opregion_read,=0A= > .u.dw.write =3D xen_pt_intel_opregion_write,=0A= > },=0A= > @@ -1817,7 +1816,7 @@ static const XenPTRegGroupInfo xen_pt_emu_reg_grps[= ] =3D {=0A= > =0A= > /* initialize Capabilities Pointer or Next Pointer register */=0A= > static int xen_pt_ptr_reg_init(XenPCIPassthroughState *s,=0A= > - XenPTRegInfo *reg, uint32_t real_offset,= =0A= > + XenPTReg *reg_entry, uint32_t real_offset= ,=0A= > uint32_t *data)=0A= > {=0A= > int i, rc;=0A= > @@ -1926,8 +1925,10 @@ static void xen_pt_config_reg_init(XenPCIPassthrou= ghState *s,=0A= > unsigned int offset;=0A= > uint32_t val;=0A= > =0A= > + reg_entry->emu_mask =3D reg->emu_mask_init;=0A= > +=0A= > /* initialize emulate register */=0A= > - rc =3D reg->init(s, reg_entry->reg,=0A= > + rc =3D reg->init(s, reg_entry,=0A= > reg_grp->base_offset + reg->offset, &data);=0A= > if (rc < 0) {=0A= > g_free(reg_entry);=0A= > @@ -1961,7 +1962,7 @@ static void xen_pt_config_reg_init(XenPCIPassthroug= hState *s,=0A= > /* Set bits in emu_mask are the ones we emulate. The dev.config = shall=0A= > * contain the emulated view of the guest - therefore we flip th= e mask=0A= > * to mask out the host values (which dev.config initially has) = . */=0A= > - host_mask =3D size_mask & ~reg->emu_mask;=0A= > + host_mask =3D size_mask & ~reg_entry->emu_mask;=0A= > =0A= > if ((data & host_mask) !=3D (val & host_mask)) {=0A= > uint32_t new_val;=0A= > -- =0A= > 2.31.1= From xen-devel-bounces@lists.xenproject.org Mon May 09 09:29:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 09:29:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324316.546292 (Exim 4.92) (envelope-from ) id 1nnzhV-00022Z-9v; Mon, 09 May 2022 09:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324316.546292; Mon, 09 May 2022 09:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnzhV-00022S-6L; Mon, 09 May 2022 09:29:09 +0000 Received: by outflank-mailman (input) for mailman id 324316; Mon, 09 May 2022 09:29:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnzhU-00022M-16 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 09:29:08 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7711e206-cf7a-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 11:29:05 +0200 (CEST) Received: from mail-bn1nam07lp2045.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 05:29:00 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA1PR03MB6499.namprd03.prod.outlook.com (2603:10b6:806:1c6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 09:29:00 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 09:29:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7711e206-cf7a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652088543; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3GM1zbJPwWsWE0hSD6pZIlx2Z/U1P7416Sb5p9d9kxA=; b=BcEywQBg1Aa5zqk3BtI0NVNawKBoml/mIxzmVHWm1aEURi5hxN+2eeBb o/DOgXw0sRZ+f0xamAbhAsA0aqSnci83YetUfkmuQqjgHa8Zd4ExGR7pc +oItArkWbSmDsuEwXAXT/Gcaq9zLqefNoCT71jP/JCrSSOgmg8I/F8PT4 0=; X-IronPort-RemoteIP: 104.47.51.45 X-IronPort-MID: 70884467 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:q6w5Ga0t9H/PuJP/8/bD5dhwkn2cJEfYwER7XKvMYLTBsI5bpzACm GEfXj2HPPqMYmrxftonboW1oE4B6pbcmN9hT1E+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw0IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Si6G9CiAWGpHns74MbzplMgNVEaB/reqvzXiX6aR/zmXgWl60mbBEKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82aBfmXjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGvI2EE9g39Sawf6HXw9QN8ioDRDfWNZfvWd5gWml66q TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTieKilke0VtZbK koV0ikjt64/8AqsVNaVdwWxvXqsrhMaHd1KHIUS8QyI1+/Y7hiUAkACSThObsFgs9U5LQHGz XeMltLtQDZp6bucTCrC8q/O9W/vfy8IMWUFeCkICxMf5MXuq50yiRSJSct/FKmyjZv+HjSYL y22kRXSTo471aYjv5hXN3ie695wjvAlljII2zg= IronPort-HdrOrdr: A9a23:e+tFcagslWTILilv5qXFhjaS2HBQX0Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCJSWa+eAcWSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AWV0gK1XYcNu/0KDwVeOEQbqBJbq Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0md gsAp4Y642mcfVmHJ6VJN1xNfdfWVa9Ni4lDgqpUCTaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd L6IRhliVI= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70884467" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=legTYK14R1hQr/aZxvFeQbKXmcAnxneUw6Rfb/FPL7QEtI13+vdpvjAOFHetfDbid9wU/XRF7RByGaooVkNv+DCTzSmz8XwP2Gj9ATOIrhvz4A87BzngGOFh0tUIoxx1trgHrASd9BKQU11rJ72SQxNsDvw/ICvmPEuLtBVXd9ZHvRMs5mTfm+i53BeNM9r2JJfJbgoZYwRaev5RwgSVWq+OXJIWx7VcLD/4IAhwPo2DJD4mFmxcktny/bEe0CKGBe+JvGztkxd9Kvzd7JO+eZBsCoGLjNmRM9tsF7xB+RJ30bO1pZvdebtLprbTp1RjKnlMi9X83HG2XO9F7CZ7Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m1TAsXIGLYlcNKZMFTXJDMlYCNcdtunkvSue/yghOTU=; b=PIm0SsPRrJD67kIKYjMrjRO4UHdlKWNTWZ9+6yE/X8QA9KO1AvTlIrNg1sQ8XOVW6xiNR8/+++FZFKA07mbgHVWDAr0+33t5v6BsRRYDAraQNqkpIYKoKMVM0yhhf0PB8oDPtrrEcspT80rhm8jmcDAXL8rcjgIJS72IfWAmOHvZAn0sqALZfVgquh5pzDRHr6heO9IM6c/PGEEi8sNmEDPL7BJ9sNedm/Ud/uD4DMc/QQqhH76SLKMe4gjMzVJE+0HgSsx0GtNWGX/23fEDTkhDKuj1+G2FdX7IQUcod1wWyXKMY1VKbZJuJuVUhVyAlnpnrDgWg+NnJXOogJVDqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m1TAsXIGLYlcNKZMFTXJDMlYCNcdtunkvSue/yghOTU=; b=t/DoTtPf2/YtcaefX12i+6l8BOTG8yeX2d6cRzD/iCo31srmXYBPXZcRDwoJVv5JZJELm0Wq7smBVetRUIzs5L5eOtzuU/393qBrytAnnK2Cz6HDGbDRBq15oNFbUmAVac0SJflT3vK2HVgAAfTRLXj6SIGurC68u+JFrpZ1iys= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 11:28:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ross Lagerwall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony Perard , Paul Durrant , qemu-devel@nongnu.org Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones Message-ID: References: <20220427163812.2461718-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220427163812.2461718-1-ross.lagerwall@citrix.com> X-ClientProxiedBy: LO2P265CA0013.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9f8119a-3fbf-4875-8d09-08da319e5940 X-MS-TrafficTypeDiagnostic: SA1PR03MB6499:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2AnUUqIn0WrYSlBOkcgpWtuCcJRbfM8dwzG92ZZl9hkDvg9b8LenuwMoNcbGFqdaXXCkTKizCXBp1p+ODnsVhNarhLLi6AupGjy2/1PIHNL+ewh5/u9gve74N1BtVysckyf7n4Lr/K96RKEfTtMfHHX9gWN4do5IgRAklCGVt1amY2IEP877A7YLbu7xEh+Gxime3baN0VfHAyrL5nmR7n8NPLsB7Qx07YzWViFMitZN5Q0PeuKotaxIHnfcgdvOJzmRDEkL4//6yK/p2iyxAU6PMv7eL/wjeATviavWW077qimSebvdI4mgMC4FVQgkjK7vJYOR9n+bnGJ0O2+lwdlHOkC9gCOzcog/RaZUoZnvs3QKj6EZE1+OE/3KaSkIWDcWNACETXPhSvL6Sb55tq5NWCfuSi+s/omudSgMr338J6lVu4GB9KWXGNTnKe7PygQ7sC5uTgFmS80Syu4Pgy2cSxlsV5iBNEktaKU3S3oE8wE3U24++X8bLMI7TOEb2Ru+Fs1V2Tx90z8bN0W5ECoorTpQ6H8sHAFbXwSbsiQ2Hc+nDuuzyG3sfqICSWGJayySKn0sqWkfwr5WQOLjiXb3iNcdNb/3USneOQUQj7GiCIguGNH7BwJDb3Ncp2QIzlkLjnDgGkUULJd5vB9bfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(4326008)(86362001)(66476007)(66946007)(66556008)(186003)(8936002)(6486002)(54906003)(6636002)(83380400001)(316002)(5660300002)(508600001)(85182001)(38100700002)(82960400001)(2906002)(6666004)(6862004)(6506007)(9686003)(26005)(6512007)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjNlRy9vTmlxM3E0d0tFWnRucTN0OC9zVmdFOWNyMzB0WW5ZN0xZMjZhSmlL?= =?utf-8?B?NXJQcjZ4L1Jick14UzBOS29KY29ZK1hDRHUwSk1XSFl3OEh1VUxKbmpEcWQr?= =?utf-8?B?eSswa2VDdXhqM1BTQW9zVFhxS0RUSTA5QU12RmtnZ2NLenFGMm95VkFnaGRv?= =?utf-8?B?QlRSK1R5TnNkRkJHd2FPRGlybjk2MG9pNHRibUhJTitONW1QaFBiUCs3TkFY?= =?utf-8?B?dzg0UW9PQXI3b3VQVVE5U3hMbWFKSkkwRW5rV3oxNVZlTkI1TG9BZVhiOXk5?= =?utf-8?B?ZjUvUE1KWnJ2dm1yQXVteXRJS2FsdjR4c2N2cU1UNXRnb1ZxSE1ZNGRyWXdB?= =?utf-8?B?bkIxZUF2aEE1MkxvMDd4S0dkU3A3am5yV2c3RHBWVGdSNURyblB6alJwR0ZP?= =?utf-8?B?NnhaNTdPU1BGcy9pNXU1cENrREFKQWo5VTlQTkp6QUNzQXJpWXg1QllRYTdE?= =?utf-8?B?bWFobVhseEdkVFk1VUVxRngwVm9taVR5NDJpRFRvRGtQM1UzeFI4RVBEZ1lp?= =?utf-8?B?R2VBb0pqeUtQUE11T2p2Y0ZESW1kNVlpcnhKRTZQLzkvbkw0bnJXWTNrT0E2?= =?utf-8?B?VkdQTlFtR0orejBLYnRobTFydzlxMmxRQXBwR0RPd09waG4yTVpUQm5kMlNN?= =?utf-8?B?UGtuVGdlYlFhMENLRitnWkgwcVJ5bDZoWG1YRzJTVHJ4cVlzWTZ2dVFUMzBD?= =?utf-8?B?c1hPRlA2L1NXbHJnVW9NemtxR3VBR2Q3OStFS2dsTktSQmJPMjJmUTFuUE5D?= =?utf-8?B?ZWh6N3JBRExQeDVZMXp2RFk5R21MR3BBS0pydlNHOVBlcFFYRkRQMGFXUTRY?= =?utf-8?B?SjFIckZWbnIxMjE3bG5SMXNkc2k0YjFvVWkrOUxQMkFZRURLS2c5di80aklZ?= =?utf-8?B?dUgxSCtKTTFDUlI5STZvaUIybW81blBiTG9SZHJvZHBjTWR4TThwellyVkRL?= =?utf-8?B?K1NTMmJCbGZvc3dnV3g0b09hdWFCbnFDbHdmbTlBNnBWUWxydUFaeVM2MHNy?= =?utf-8?B?cmdWYXExNWlzNzJMSzgrZFd3YzdqV09FYzgwOGxmTTlTS1A1VWJQWnVzQkJw?= =?utf-8?B?MTMxelU4Mzc4blNzazdwVEZjTUxGNnpBdjAzRXdQeGp3Zm9UQ0xSNHJDSHMz?= =?utf-8?B?TzBYb1JuVWpXSy9EQUxoVFJCUlpUZ1VBT0RMRDZEdFVBcXlKK0RUN3IrTGt6?= =?utf-8?B?VkYrUUxFY0pwSVVlOERLVnJabWx2U2FTL1l3OWE2Y3poNktBRUxNeUJWUENa?= =?utf-8?B?UlVXOGJXbjZNd1g2NXhORTlqMStuem5yQjlUdUpIczdZWUxyc0t5ZmIrazFj?= =?utf-8?B?VC9LeERrL0JEd0lZbWxDb0ZtbjdTTU1zZUd1QjB6cTVPRU1UdFV0VThLOTVZ?= =?utf-8?B?OTBEMktoc0E0MTdxOVpaa0tlTXBiYnl0alduTmppeHBvLzVuL05pWHYxK29k?= =?utf-8?B?NjZsVTFVdXg4RXZQa3ZWNEt3Q0NCUUpscTd1SEZFR2JKWFBjcDQreUQ5ek5H?= =?utf-8?B?ZkNiV0F6SG9PeVZvV2N3RHhBR2FPY3dLUW00Z29Bc3piYkdjVUxrSWV0eDg2?= =?utf-8?B?aW5FRVJseG0wSlhXanR1MUNQRFFSY0g3UXF4TXJES1JBeEIvRlV0NTJreVY2?= =?utf-8?B?U1U3Y1VRMFBkeGo1MFA1Qnl2VWxMbmpYWmxoQ3YycUVJM3FlZWFYSDNYcGpO?= =?utf-8?B?dXRSRms5SkZxUUVoYkpyVEd4U3pScGFvakpnS2RPNVBuckRQY0JpcFpIUXhL?= =?utf-8?B?bW1ESjNUQkpmMlBCLy9iN2J3N0pFcUxPSWhCT05XMXpyNFhEZUExcnh4T3lD?= =?utf-8?B?bkdPVmVWaDRMSXNsVlpmTGRiTkhBRkNjRzVRZmJXOFpjYnRwUEtpV3pTbWgy?= =?utf-8?B?TEwxK2dMUUZpOFRtYTdWYSs5dEZwdUJJRTVGQ3pMZmJKWFRxYmxUSnRGNGtJ?= =?utf-8?B?Yk0rTmJoYjNEVVRuV29CTTlWOVpoUk5sOUYyY3FCMXNXODQwRWM4Q0pPb2JZ?= =?utf-8?B?bWFzdURidThUbVlwWGhCZnBWdlFRYUFVWVYvaXhMclBweUsyY2FWOTEwVTFM?= =?utf-8?B?L1JqUXhPbjUzWWgyUkJwcGdDeE5lYW1kSUFzbW5YcXRQMlczalN2eWdNNHRx?= =?utf-8?B?Z25GSkFhUDU4M3hiMUJoMG0zZXgreFN5SHAzblFzUThuZDhoTldFR3RMcVM0?= =?utf-8?B?c2FkTHllMW1kbnUycXNMbWpvdkMxSm5IRHZJNTlUNno2TWdDb1Vya21OVTJp?= =?utf-8?B?S2d0VFBzenRkMVFEUHgxVXFodEh3MjlmRmpQWWx4SUFoYUZXa3NVSUliNGJO?= =?utf-8?B?d09IVHp4N0NxZlZVU3pJMGhOOWY5UEtFQ3BpTDRHWjEwbnJlZzA2UT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9f8119a-3fbf-4875-8d09-08da319e5940 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 09:28:59.9592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AbTFKTN4HvXIdP3WsDCpjC1KIEYYXpV+tiReV2qnTgFtMTg3ZRpNqAc5GCHmHUOjX4J0B2GOL+QFTpWns+HJfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6499 On Wed, Apr 27, 2022 at 05:38:12PM +0100, Ross Lagerwall via wrote: > The BAR emulated register definition does not set emu_mask because it > varies depending on bar_flag. If emu_mask is not set, then the BAR is > initialized based on the host value which causes the BAR to be initially > mapped at whatever value the host device was using. Although it does > eventually get mapped at the correct location, it causes unnecessary > mapping/unmappings. Would it be possible to just unset the memory decoding bit in the command register if it's set? > To fix this, initialize a per-register emu_mask in XenPTReg from the > initial value in XenPTRegInfo and then let the register's init() function > set/modify the emu_mask if necessary. Update the code to use emu_mask > in XenPTReg consistently and rename the existing emu_mask in > XenPTRegInfo to emu_mask_init to help with refactoring. Iff we really need this refactoring it would better be done in a separate (pre)patch, so it's clear what's the fix and what are refactoring changes. I also wonder whether why it isn't enough to set emu_mask in xen_pt_bar_reg_init(), without having to introduce a new field. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 09:47:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 09:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324324.546303 (Exim 4.92) (envelope-from ) id 1nnzyy-0004Us-Pt; Mon, 09 May 2022 09:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324324.546303; Mon, 09 May 2022 09:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnzyy-0004Ul-MV; Mon, 09 May 2022 09:47:12 +0000 Received: by outflank-mailman (input) for mailman id 324324; Mon, 09 May 2022 09:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nnzyx-0004Uf-JA for xen-devel@lists.xenproject.org; Mon, 09 May 2022 09:47:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7d00::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe7b3bf5-cf7c-11ec-a406-831a346695d4; Mon, 09 May 2022 11:47:09 +0200 (CEST) Received: from AM6PR08CA0001.eurprd08.prod.outlook.com (2603:10a6:20b:b2::13) by AM6PR08MB3989.eurprd08.prod.outlook.com (2603:10a6:20b:b0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 9 May 2022 09:47:07 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::a9) by AM6PR08CA0001.outlook.office365.com (2603:10a6:20b:b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18 via Frontend Transport; Mon, 9 May 2022 09:47:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 09:47:07 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Mon, 09 May 2022 09:47:06 +0000 Received: from efe468709104.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24A9F1B1-E78C-4897-88B5-B1DDD34ABEA1.1; Mon, 09 May 2022 09:46:59 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id efe468709104.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 09:46:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB4122.eurprd08.prod.outlook.com (2603:10a6:10:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 09:46:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 09:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe7b3bf5-cf7c-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hG4rjsWVRCyQeSzI38QBCj+6rnGLRI4MS7u/2L3cLxnYgdKPLoy/qoZmC0nRFdXkr3SsTeWwyknUmF08xwQztGtoya3RCsL1R4t3Aon8oS4nJT5qXzIrTzzcgvRFvGAI5pFwYfe7N1CzLGJTLEwPy31pgf/J6ghznswjWspO/9g3dkIAmHV/zDciEJrheGD583/Tldu2hnI8ukSRsExGFGTdtlvHlHg1l2GWDm4xtsKK5WOAdCsyzQQO/ZBgBPn/DB4pHgO5q5KzKqTP5pLORsR9n7MB7iIxBhwtlJm6FNfHYb0WSGGF1yD/WJTM7Wi7WWrUzbREBlw3b8D4GtOfvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYT1EqkJ3FLOiwWV9EZXmDjeaH5HDWuuXGwUQGzONGI=; b=KRVU8ySZ4tr+J71u+9B/TujbESsHfvzpeKRHUrzUb/Y/H8Ti7MajyuEiNNPeJLkOmxbABXkb91JqMApYr3GPwafx64puhEe7uZ7nnd62XWhpcUQX+jxVOK/nDb2TGGREJ+vqFShiqAmj53mpKpOuztlBL3Z67/WaTt/viJTrQPiA9Dsi5bhowo2TLbx0vOfpOXai+hm/jafTtngvf2C1rWqNgDuzdP4uBaTgFwGH3xSuf5m+611/wSzx06Q1B5IGlcEDYVTHi0pbYjqdPR5+ixSOb+6nf2WWZBJtwiAZeIKNbeHNX+vw6WkoHJvxdFs6Ob7k9vwdry1q2HWKuQvd9Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYT1EqkJ3FLOiwWV9EZXmDjeaH5HDWuuXGwUQGzONGI=; b=DG7Va+kKu5RJsRmmd7IUhJxzdmmT5AWh8yfEcfwNKhZPwSHs22V3dqoamP8nktBgQBBD7GpgHelxFn8Wta5/FtM84k39vQGmbikGeMTDdULMZQDvV7MbjNn8qkoPE9FUrnNfJtziCQF1E2wJO2X0Gh7bdHCp/3Ihh/0DsNdosSg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 3d9e81029e671d8d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adWp9jXT4mDdrqKOIgBMoUKyaOPU6EwhSPUG/QJIXAr4QdrNsD7PHWVuPrk+W+Fh+8P82z6Mb6KuckEEzu5NIHVstBT4K3FlmQRYnICFM3Yu4d5I1/+59Am2IsrWZyAHiJg8Tb/augjTJUZqpHnWB/9nzrfjkCNhk382p7U80r8Pxjq+xaM9wDUpwCbAw0Z5rpDECqa2MOGrw3SwwL5VzlRDiTZJPJRWCpyE/fPsGekrJZ0E4K1CwKQUsmwqaffF9kTqzZocxJt6rIAdV2JNg2X5nJqIJNIO0zjHr4thUnnQB8N7imjswvQQLPuIBcKisHXUj/+jNP5ww3Ee3CpB2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYT1EqkJ3FLOiwWV9EZXmDjeaH5HDWuuXGwUQGzONGI=; b=Pl0QfP4kavN2SSxARxuNYf6SyGQQg0HnCTeGhQJbaf7eSsrsIlaH+XahW1Kir233TYDAUHgg8GiJ6GPeJnFLKr8pmdwPXowTHg6GRIhufOQHfkWGAL8gmLM+PS7HHOpCXNHDjYJ7tAbXy/CaL5WfDmMBzXjL3lg73miadWfoP0MPnF2n0oiV+2DBTjn6Bgj9Oyx7CsI/IE7traUpRDfZEHLevC5s6IE60UNJnwyqPDm3xY/OTck4eaPkjPnKFfp5dk8/4ApQdvA8wq1tpl181FBS4rb6VyJpDXVJBMoWLESWO8pcrysHXiG+Eb1fvsbd4XTOptPjpd8HJnapVzqDIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYT1EqkJ3FLOiwWV9EZXmDjeaH5HDWuuXGwUQGzONGI=; b=DG7Va+kKu5RJsRmmd7IUhJxzdmmT5AWh8yfEcfwNKhZPwSHs22V3dqoamP8nktBgQBBD7GpgHelxFn8Wta5/FtM84k39vQGmbikGeMTDdULMZQDvV7MbjNn8qkoPE9FUrnNfJtziCQF1E2wJO2X0Gh7bdHCp/3Ihh/0DsNdosSg= From: Bertrand Marquis To: Stefano Stabellini CC: Jan Beulich , "andrew.cooper3@citrix.com" , "julien@xen.org" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" Subject: Re: ECLAIR Xen x86 results and progress Thread-Topic: ECLAIR Xen x86 results and progress Thread-Index: AQHYYWa8wpeTjlErNka5mMv8kda4r60WUKGA Date: Mon, 9 May 2022 09:46:56 +0000 Message-ID: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8479fff3-eb68-4ea4-7e18-08da31a0e150 x-ms-traffictypediagnostic: DB8PR08MB4122:EE_|AM5EUR03FT043:EE_|AM6PR08MB3989:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IT5feKVNAoRGDMFZZOed57vUtoGxd08iI/BVucQ4emoI2+/WmbdsXXXidrZhOp0EB9wwbwTxLZOWega4AAAipxI/2LzmH65Gsc9mYDQsMP8wcUP4NeCIpCBqMkJ3CtXUT16vRtkngCBwvJsZsrZ5yK2EKnZ1IKdetCM/bdxdcSWX4budXuVez9WJyPKABuIxPDHLL4pg9HtZcYMhfJFAq5NAz446dK4sADzXpIwn4H4820Lq13+XNOjPLaBEAAm+EsO84kMApDRf1mBJhH5ELQ4YRuiGuEdgfZA2Q90quO/Dtjb44cgzMVKcIwgMOuayNmC85D+3yLyAR0A68damPbvBJHnKyVM2zKAhIEGrQyQAT6ffjq6bcFDXOVwQyJdY6D0fV6Eeuxg/dI5PNfI7P3Ob3AlBEs/4B/Nyl+GP2HX9EnipNzqbAD34EdjZTwnXOhkWvyJfnHCzNk+NBnVn15BHggccAvHAlu0sfFVfsArnvldZFDnuXNx4vZFfafi/5TvEBcFfuq6prRKEiyuAevWsmDMJo2oXratElWSLV5LmlV4BWxQs0gxRFsAv/Ts/n7drd1Mb/ay/K3gxWHZjzMalaB5+B5STHgkp9YGyrtc+GxvjD49KXxh3d9wQA7sRxGWAkldHpoiOsrBK6VLCcLASDGz2ipVon03dji5YZPgQV1i0kaEDzoPmNO1GdRoVThdQd2yGCLc398L3mCII8A9DNbZxBt0qf0/d0C/515tsCtZN2mBsnV8Mta1wflIAXrQfgLLS8+As/LXtOzSDL+7m5ZyzJ4W1wX4uu6yzwglK6xHyQM0Dd52q5t4ZdaR9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(91956017)(8936002)(71200400001)(508600001)(8676002)(4326008)(66556008)(66946007)(66476007)(66446008)(2906002)(64756008)(33656002)(76116006)(54906003)(6916009)(53546011)(122000001)(86362001)(6506007)(2616005)(5660300002)(4744005)(6486002)(966005)(316002)(38070700005)(38100700002)(186003)(6512007)(26005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <58B4670E96597C49856BC417329EC4A2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4122 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 86640104-dbd8-4fdf-48be-08da31a0dacf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kk6XTh1mUGRwWLcW1OsBG8yyE+r7KXgWDEjhAeWie3mQytEjQzRhufCaAApjCIw9AguuAATV0xH//TaTnDbYcHt4mjUhuSypo+LSeS8vZiL+PKKlZwZ+qIMqbstC+Rp8zUSo7Xv4f3qXoXPaQyQ4kOs6Xr4NnsmWxvGAyaz3nLdAm42vJy+wtsn/4ZsvKS97npvkRD986l6S707S40chKFU1ep2/9+c7m+PomQQPam2XXkkNRG9DIFJ270y0B+pRjk7OVFU9J4Mx/siHhxqjYIfwZbdRWX6jfbFdaD2abBVWXoDSz3+ErMu8pCcKy4vmOiWDDIebfgWmY9QqsBYq2MmwahuulgQCnAAVNlKHjggRtfPhrF74YBKJErQg1dKtXWFkMT1HEc8mQKy1/Tmp8cj6Cdv+c+tIQJrvnGJ5nVMz4DgNY4Le+SHnhXf+1oJHny/WtdGl3SFmynwBn0v36y08EAMRDrvH77rGyFpJWZyDfIByFyT5BTQz4bNezyG0CYLDXAV4aYkITZbEmTz2DvozgNdMnC1x43ddhC4XB0/4yaFh7A++/mnLCEwav/mT6I7SJnz7VCU+hxV+yvx15wIdfGHcjlzjTXvZEWyavf3s3xdp0NsVKsNNpbDnTwVAq+QDca3exIMZJ/zyZyXsthYRweSnW+HTZd3tHDFOey5llh+rUTXcpIPw9+c3ixNhrQ+gYpTK6m6HGjgWKE+QWgmxKCHLnqUksgxw1dpWkjoJ1hK70V6UEwMxfaEB+QnZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(6506007)(53546011)(2906002)(40460700003)(70586007)(81166007)(6486002)(86362001)(26005)(4744005)(966005)(6512007)(356005)(70206006)(6862004)(8676002)(54906003)(4326008)(82310400005)(8936002)(33656002)(5660300002)(336012)(316002)(186003)(47076005)(2616005)(36756003)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 09:47:07.0554 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8479fff3-eb68-4ea4-7e18-08da31a0e150 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3989 Hi Stefano, > On 6 May 2022, at 17:31, Stefano Stabellini wrot= e: >=20 > Hi all, >=20 > Roberto kindly provided the ECLAIR x86 results: >=20 > https://eclairit.com:8443/job/XEN/Target=3DX86_64,agent=3Dpublic/lastSucc= essfulBuild/eclair/ >=20 > Click on "See ECLAIR in action", then you can select "Show 100 entries" > and see all the results in one page. As an example MC3R1.R1.3 > corresponds to Rule 1.3 in the spreadsheet. >=20 >=20 > If you are OK with this, I would like to aim at a follow-up meeting on > Tue May 17 at the same time (8AM California / 4PM UK). If the date/time > doesn't work, I'll run another Doodle poll. Works for me. >=20 > By then, I am hoping that the group has already gone through the first > 20 rules in the list, up until Rule 8.10. Is that reasonable for all of > you? I completed that part of the table this morning (up to 8.14), it took me 30= minutes. Cheers Bertrand >=20 > Cheers, >=20 > Stefano From xen-devel-bounces@lists.xenproject.org Mon May 09 09:51:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 09:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324330.546314 (Exim 4.92) (envelope-from ) id 1no02x-0005si-9k; Mon, 09 May 2022 09:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324330.546314; Mon, 09 May 2022 09:51:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no02x-0005sb-6u; Mon, 09 May 2022 09:51:19 +0000 Received: by outflank-mailman (input) for mailman id 324330; Mon, 09 May 2022 09:51:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no02w-0005sR-2Q; Mon, 09 May 2022 09:51:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no02v-0001xs-Vw; Mon, 09 May 2022 09:51:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no02v-0004no-J7; Mon, 09 May 2022 09:51:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no02v-000069-Ig; Mon, 09 May 2022 09:51:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oNmcYj+kL8Ny2FbJoVfkw0Lh9FhlGhipHCPatWb8LoQ=; b=6FIwyCz25a1XdONOHi7XXurWUy WlJawTYpWcH93UKB2usHzEjn1wFagKmQMMn5BjbnN0bdKctQCHXfbiNvM2EjAOi2LU1ov7EK7jfJC FyzsVQf5mkeXREgy/6DbxOhbgH58r8OqJa4CR/vGM+uCJLS/DniHfj1cp/8Obz+70Bc0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170261: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=5890a320f893b7db63b15a55feebb0e314baf47b X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 09 May 2022 09:51:17 +0000 flight 170261 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170261/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 5890a320f893b7db63b15a55feebb0e314baf47b baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 668 days Failing since 151818 2020-07-11 04:18:52 Z 667 days 649 attempts Testing same since 170201 2022-05-07 04:20:26 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106819 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 10:01:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:01:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324339.546325 (Exim 4.92) (envelope-from ) id 1no0Ct-0007fN-GL; Mon, 09 May 2022 10:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324339.546325; Mon, 09 May 2022 10:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Ct-0007fG-CI; Mon, 09 May 2022 10:01:35 +0000 Received: by outflank-mailman (input) for mailman id 324339; Mon, 09 May 2022 10:01:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Ct-0007fA-45 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:01:35 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01900365-cf7f-11ec-a406-831a346695d4; Mon, 09 May 2022 12:01:33 +0200 (CEST) Received: by mail-ed1-x532.google.com with SMTP id w24so7880799edx.3 for ; Mon, 09 May 2022 03:01:33 -0700 (PDT) Received: from [127.0.0.1] (dynamic-077-013-108-001.77.13.pool.telefonica.de. [77.13.108.1]) by smtp.gmail.com with ESMTPSA id a7-20020a170906274700b006f8c8e43a45sm2190376ejd.103.2022.05.09.03.01.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 May 2022 03:01:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01900365-cf7f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:references:message-id :mime-version:content-transfer-encoding; bh=ZqQErfe033WzHkqHcREjfuujLxdUhRLTfIeWA8F3QSc=; b=HPWXpRZ++l5RkZjWDXctKK5FylWMfIv3rm+URBWIAWThmqJjRr/u/Hhv70CT8b+Sws /sK31hBRwEhnjI/CJjCR0BynLWl+Phkvgo5QCEG0B1G7oy7o3rQUgqEM7Fkv1djhYKAP O+WQAgbLCjGIC4YbRmaIQQKqiULdR7B2LdMx17E1UeRMzf2Y7ois2kmFzbGQEmcywQa8 FWeikIBym23eS1a+1B+vJcZedX1BklcdWA1maWduwYAnwVUuzHf7qJDPo0CQjS3GKvH2 pJn635MYIWmIlpoA/oxJbf/U7FF+cniP4agUBc9YAelhZWp1G51htOODBSTWlaN7t7Li 8Dmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=ZqQErfe033WzHkqHcREjfuujLxdUhRLTfIeWA8F3QSc=; b=WpK2yDSn6U1XuELjcGrA5ab2KLntnQtPjiPbBcD0BB/Ad96tT0oT/uUSLKBkEojf1g 9VSlFHZNRoqEuCb54hl4mLCJmBoCATakQZmu/m5kE5xXnqI/ZJDL7eOvKF1WvH0xzrki FxQoaxEDle3Y8BWvxi0hBmdmZ4zM5d8nlmmFV0hDZ71tgBOBrGhoM2IozWQzk7ZyBGRt kBPWLRdMbCXjWS966Gb3t0BKWsxVFgCrrYWjsQ+ttZLfNUlE1BDmlOOUHuvN4ClERV19 UPcY1cBhO3V7kQZco6nFiKMA+Tvh0tA+Ue6jfMCW51ZJUOdGVBJtRgzIiVe3+pqgxA1S SCwQ== X-Gm-Message-State: AOAM531s3F3Q2qL5TFcFP/8EjkkaDdH+ShMD1eDTl8CVXrnwIFkzMiYI ilRqskVj6uC5rPmHxZYHnTE= X-Google-Smtp-Source: ABdhPJz84zv7VmcS6ff/C+IzKqHG8uhClLj5BrvVbBtth3kgGsLcbb7tOqsakQ8+5hQ2I1SuYgDWFg== X-Received: by 2002:a50:ed16:0:b0:425:f420:e51a with SMTP id j22-20020a50ed16000000b00425f420e51amr16590673eds.23.1652090493268; Mon, 09 May 2022 03:01:33 -0700 (PDT) Date: Mon, 09 May 2022 10:01:28 +0000 From: Bernhard Beschow To: paul@xen.org, "Durrant, Paul" , qemu-devel@nongnu.org CC: qemu-trivial@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , "open list:X86 Xen CPUs" , "open list:IDE" Subject: Re: [PATCH 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() In-Reply-To: <724c6af0-277b-a6d1-b773-89e1b03e0c53@gmail.com> References: <20220508103432.14874-1-shentey@gmail.com> <20220508103432.14874-4-shentey@gmail.com> <724c6af0-277b-a6d1-b773-89e1b03e0c53@gmail.com> Message-ID: <51E7FF85-EF4C-408F-96A9-71DB622D11E7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 9=2E Mai 2022 08:02:13 UTC schrieb "Durrant, Paul" : >On 08/05/2022 11:34, Bernhard Beschow wrote: >> This function was declared in a generic and public header, implemented >> in a device-specific source file but only used in xen_platform=2E Given= its >> 'aux' parameter, this function is more xen-specific than piix-specific= =2E >> Also, the hardcoded magic constants seem to be generic and related to >> PCIIDEState and IDEBus rather than piix=2E >>=20 >> Therefore, move this function to xen_platform, unexport it, and drop th= e >> "piix3" in the function name as well=2E >>=20 >> Signed-off-by: Bernhard Beschow > >Reviewed-by: Paul Durrant > >=2E=2E=2E with one suggestion=2E=2E=2E > >> --- >> hw/i386/xen/xen_platform=2Ec | 49 +++++++++++++++++++++++++++++++++++= ++- >> hw/ide/piix=2Ec | 46 ----------------------------------- >> include/hw/ide=2Eh | 3 --- >> 3 files changed, 48 insertions(+), 50 deletions(-) >>=20 >> diff --git a/hw/i386/xen/xen_platform=2Ec b/hw/i386/xen/xen_platform=2E= c >> index 72028449ba=2E=2E124ffeae35 100644 >> --- a/hw/i386/xen/xen_platform=2Ec >> +++ b/hw/i386/xen/xen_platform=2Ec >> @@ -26,6 +26,7 @@ >> #include "qemu/osdep=2Eh" >> #include "qapi/error=2Eh" >> #include "hw/ide=2Eh" >> +#include "hw/ide/pci=2Eh" >> #include "hw/pci/pci=2Eh" >> #include "hw/xen/xen_common=2Eh" >> #include "migration/vmstate=2Eh" >> @@ -134,6 +135,52 @@ static void pci_unplug_nics(PCIBus *bus) >> pci_for_each_device(bus, 0, unplug_nic, NULL); >> } >> +/* >> + * The Xen HVM unplug protocol [1] specifies a mechanism to allow gues= ts to >> + * request unplug of 'aux' disks (which is stated to mean all IDE disk= s, >> + * except the primary master)=2E >> + * >> + * NOTE: The semantics of what happens if unplug of all disks and 'aux= ' disks >> + * is simultaneously requested is not clear=2E The implementatio= n assumes >> + * that an 'all' request overrides an 'aux' request=2E >> + * >> + * [1] https://xenbits=2Exen=2Eorg/gitweb/?p=3Dxen=2Egit;a=3Dblob;f=3D= docs/misc/hvm-emulated-unplug=2Epandoc >> + */ >> +static int pci_xen_ide_unplug(DeviceState *dev, bool aux) >> +{ >> + PCIIDEState *pci_ide; >> + int i; >> + IDEDevice *idedev; >> + IDEBus *idebus; >> + BlockBackend *blk; >> + >> + pci_ide =3D PCI_IDE(dev); >> + >> + for (i =3D aux ? 1 : 0; i < 4; i++) { >> + idebus =3D &pci_ide->bus[i / 2]; >> + blk =3D idebus->ifs[i % 2]=2Eblk; >> + >> + if (blk && idebus->ifs[i % 2]=2Edrive_kind !=3D IDE_CD) { >> + if (!(i % 2)) { >> + idedev =3D idebus->master; >> + } else { >> + idedev =3D idebus->slave; >> + } >> + >> + blk_drain(blk); >> + blk_flush(blk); >> + >> + blk_detach_dev(blk, DEVICE(idedev)); >> + idebus->ifs[i % 2]=2Eblk =3D NULL; >> + idedev->conf=2Eblk =3D NULL; >> + monitor_remove_blk(blk); >> + blk_unref(blk); >> + } >> + } >> + qdev_reset_all(dev); >> + return 0; > >The return value is ignored so you may as well make this a static void fu= nction=2E Good catch! I'll prepare a v2=2E Meanwhile, I'm looking forward to comment= s on the other patches as well=2E Thanks, Bernhard > Paul > >> +} >> + >> static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) >> { >> uint32_t flags =3D *(uint32_t *)opaque; >> @@ -147,7 +194,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, v= oid *opaque) >> switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) { >> case PCI_CLASS_STORAGE_IDE: >> - pci_piix3_xen_ide_unplug(DEVICE(d), aux); >> + pci_xen_ide_unplug(DEVICE(d), aux); >> break; >> case PCI_CLASS_STORAGE_SCSI: >> diff --git a/hw/ide/piix=2Ec b/hw/ide/piix=2Ec >> index bc1b37512a=2E=2E9a9b28078e 100644 >> --- a/hw/ide/piix=2Ec >> +++ b/hw/ide/piix=2Ec >> @@ -173,52 +173,6 @@ static void pci_piix_ide_realize(PCIDevice *dev, E= rror **errp) >> } >> } >> -/* >> - * The Xen HVM unplug protocol [1] specifies a mechanism to allow gues= ts to >> - * request unplug of 'aux' disks (which is stated to mean all IDE disk= s, >> - * except the primary master)=2E >> - * >> - * NOTE: The semantics of what happens if unplug of all disks and 'aux= ' disks >> - * is simultaneously requested is not clear=2E The implementatio= n assumes >> - * that an 'all' request overrides an 'aux' request=2E >> - * >> - * [1] https://xenbits=2Exen=2Eorg/gitweb/?p=3Dxen=2Egit;a=3Dblob;f=3D= docs/misc/hvm-emulated-unplug=2Epandoc >> - */ >> -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) >> -{ >> - PCIIDEState *pci_ide; >> - int i; >> - IDEDevice *idedev; >> - IDEBus *idebus; >> - BlockBackend *blk; >> - >> - pci_ide =3D PCI_IDE(dev); >> - >> - for (i =3D aux ? 1 : 0; i < 4; i++) { >> - idebus =3D &pci_ide->bus[i / 2]; >> - blk =3D idebus->ifs[i % 2]=2Eblk; >> - >> - if (blk && idebus->ifs[i % 2]=2Edrive_kind !=3D IDE_CD) { >> - if (!(i % 2)) { >> - idedev =3D idebus->master; >> - } else { >> - idedev =3D idebus->slave; >> - } >> - >> - blk_drain(blk); >> - blk_flush(blk); >> - >> - blk_detach_dev(blk, DEVICE(idedev)); >> - idebus->ifs[i % 2]=2Eblk =3D NULL; >> - idedev->conf=2Eblk =3D NULL; >> - monitor_remove_blk(blk); >> - blk_unref(blk); >> - } >> - } >> - qdev_reset_all(dev); >> - return 0; >> -} >> - >> static void pci_piix_ide_exitfn(PCIDevice *dev) >> { >> PCIIDEState *d =3D PCI_IDE(dev); >> diff --git a/include/hw/ide=2Eh b/include/hw/ide=2Eh >> index c5ce5da4f4=2E=2E60f1f4f714 100644 >> --- a/include/hw/ide=2Eh >> +++ b/include/hw/ide=2Eh >> @@ -8,9 +8,6 @@ >> ISADevice *isa_ide_init(ISABus *bus, int iobase, int iobase2, int isa= irq, >> DriveInfo *hd0, DriveInfo *hd1); >> -/* ide-pci=2Ec */ >> -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux); >> - >> /* ide-mmio=2Ec */ >> void mmio_ide_init_drives(DeviceState *dev, DriveInfo *hd0, DriveInfo= *hd1); > =20 From xen-devel-bounces@lists.xenproject.org Mon May 09 10:08:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324345.546336 (Exim 4.92) (envelope-from ) id 1no0Jv-0008Of-7a; Mon, 09 May 2022 10:08:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324345.546336; Mon, 09 May 2022 10:08:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Jv-0008OY-4O; Mon, 09 May 2022 10:08:51 +0000 Received: by outflank-mailman (input) for mailman id 324345; Mon, 09 May 2022 10:08:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Jt-0008OS-HP for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:08:49 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0631.outbound.protection.outlook.com [2a01:111:f400:fe02::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04bcc21b-cf80-11ec-a406-831a346695d4; Mon, 09 May 2022 12:08:48 +0200 (CEST) Received: from AM6PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:20b:f0::26) by DB7PR08MB3244.eurprd08.prod.outlook.com (2603:10a6:5:17::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 10:08:46 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::8d) by AM6PR04CA0049.outlook.office365.com (2603:10a6:20b:f0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Mon, 9 May 2022 10:08:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 10:08:45 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Mon, 09 May 2022 10:08:45 +0000 Received: from dea0c9bfe622.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0DFDE5AA-A4E0-44E8-BE26-EDF900733E6D.1; Mon, 09 May 2022 10:08:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dea0c9bfe622.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 10:08:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5498.eurprd08.prod.outlook.com (2603:10a6:10:11c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 10:08:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:08:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04bcc21b-cf80-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WrSKzBJTanAkqMLP45F3XWtKC+2oGaZ27lDjW1mYwIZQvf0N0vhoIvBkg3o7VXQ3VqYj7tXNkHvA1ja8UUPjtoHYwSBOCtjKOoNQ3MnQmtH4SE95/9BBiMYzg1EKSjN18SIr4UYoTEySD+VDJ1Leem0rSzYzBx5o6JBLR4W7rQDG6Siji24hkJW/GQzaai9GAOob2+LlV0BaqFdlTktIfFcysfKM6trDUxKVPmFSFloysaAUkOESWFoRpMbMoOX6fK3MYlLXuGvVykjJndlIq9oATJAwJSKtg5Cw1DV+02uxDBIRtVlS3xhlDSo2HNK+SmgHTh47hzJ78Z6h0rNfOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NMD+1rX2smqdWe5glCzpCqzZ041JJCDEaklYaBOfhsM=; b=UT8Dazjp8r5Y8PdtG/bgPb/4KHWugfD+4EHJmQg+GDUqZiyZdlno5wDaUXX3JO1NXjKL0/GODf6Ah0nX+qHg+tlfAx6mBHwViZWEhkusVoihvo2UYZAh7xDHFHd+7v31ABz4YEZaRtnEzi6sAaklrMEHBxL/Z7aLEv53ebsShkPKInK2l3gpq3iR/vMCnybJukegEaUAXu4GxdIzVXZjBCom5pu34d4fUaGyJXDr3Sl8XnFecya86RsGyJMDX9AloGp6NXR5zU8wsuPb4ysvy5wbxj1DQ+nSb3gezojV0WGQWDUBX5gb3yAz8xWbXOUt/Y287BRB2xF0eKXsenAPiQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NMD+1rX2smqdWe5glCzpCqzZ041JJCDEaklYaBOfhsM=; b=bda58VfYaAluWBzZ4rvzhDbHjJPvIOJROYE+pZUWTfFw5ty+Y9vI6XlhmfajJlXTYj0ZLwSSBNjwBiZNFD78UP9C8gsgq2Wt4hKLNQ0BZ3P54MQD5Wiw+sCpDbAwx1vMPOjKCDikVxI3OqOfsSD6nV9yPdgrcdQ1h9lKJ8dWCYE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: ac1fe656c88eda96 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z46g1YaqoAcsJtJYfsqPk/oFn90NPJxtJauA1iQH2YAwrtEcdyAZJnWRVaIdh3QwJz66I9I0kvIH3UqCf4QUfefCj/qTgLsrFDyuGsstDrzTxNYN0QjLY0N4JMPAyMVRCzp8TZRsB+HjaTrZqO9KFG1T0yaigo+Cvq1GWFNoZfnjf64ifgDIbbx5RUZDF52ODUq9SfB7QqjHH2YZJOv601cD7e9ZDmxnz3gI90Jr63zdicTFtunTjFjopEZj0lB1yEpAkjZg7tuBB2bN/09OOQBu6MzGgALSbLFEy2IwM56UCu0YZCql9ds4CbBwnlt/gAYFaZhQFiYpch9hpKbPHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NMD+1rX2smqdWe5glCzpCqzZ041JJCDEaklYaBOfhsM=; b=EMms+gqD+nD9BM9RQruzJ+OBvANTHvkNamIlMgeoq6tF0BC8R/RIQpUMBk3X2OpWD4hzbB/v57oDTYsteuCDurBb9ZGEeWxLGxIXoHRvAlYFPscAeyYS3aMUDqev+70o5WHwbbG8xpU/GCHhMAjlRYtbdqUzkQA+RDjSwq6QxPX7clklkR0Yu+KKPlztztYNTT+8nTeufLs4W4WfpUzdX7aW+of6QUB2bamwFpX4AxH3HYUy1LaFnFv7Kt+n2mdDyMkUtoS31Jopmk9CxIk1xC5gruJE8CnwUr0QeH6g65CWQG+GfwP4+mLCqKMZeb0+CrMXkP1xdOa9L2AgnME+HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NMD+1rX2smqdWe5glCzpCqzZ041JJCDEaklYaBOfhsM=; b=bda58VfYaAluWBzZ4rvzhDbHjJPvIOJROYE+pZUWTfFw5ty+Y9vI6XlhmfajJlXTYj0ZLwSSBNjwBiZNFD78UP9C8gsgq2Wt4hKLNQ0BZ3P54MQD5Wiw+sCpDbAwx1vMPOjKCDikVxI3OqOfsSD6nV9yPdgrcdQ1h9lKJ8dWCYE= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Topic: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Index: AQHYXtGbLw8lUArxPEOQFl634Avmjq0NftKAgADToQCAAAuUAIAH/dMA Date: Mon, 9 May 2022 10:08:36 +0000 Message-ID: <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1992bf01-2ae1-4895-41bf-08da31a3e754 x-ms-traffictypediagnostic: DB8PR08MB5498:EE_|VE1EUR03FT029:EE_|DB7PR08MB3244:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SZT/yyZ4e/K4nNghjsYsn2oQKtwaBmHKbs+ix0wmQQvoHT0laKD+38UaTI92oFH5h7bidacVJabi3YkkRvm33/PXwyqdrZTclagWo07+HgPz4t7Gvct1FqiuWoQLc5yHxBbSo/R52o0ugjD9eNVkdAdeCRpYWzt2drhjpUslZ+Qq28OvDCs+hrM4AZfRZ0zsxWrjsgsnAIheAZ5OwMWbK41l36xxq8fWZXjn2Sx4blKQPFVYDDhfSmmdpozlyV1DBFby4YzB7tJCtzPa8ixHQyypQ6n/go0sIkkZQQEmutOZoiWAtV22nHmv2mYvvUAs4lmeREAgFKTorxd5wy5CkJDT/KkdEhainVpgK5wBDVHhMBiXqUv+4XezksMf3ecqP7zIUEGSE2ISVXwbpKmd1Kr8Ex5HUboJkMM8j/qklZsDatIBUsecRPikO6ukv8+HKOW7cLjWisL1BeIH5wd2GQR8t94kVpWUeJfTUwk7nFOWEAEOCocJafYiJ614eQZ399gHKLC3fcrhgadFBS87sNCZ1zPWGvLE+yNoA0g8AwoMgid4N96royVtzD7qbBHvxckC/BpJbI2ECeGYqHYNgqEOJOf+foOrjp+XWZz8NpQg2Dq2rj6AmXuPtW6i+L+gVpsmT4eq9/uyxunmHZeodh2quizFygDH7jdfzhl7e/g3C6qmRj9Tub2odhvVxbJa1MLHsygF+7epu0bnErNXl9iK9Gzk6RhwaCehuaZc1bF71o44Uu7YjVKzco4pQCXH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(508600001)(6512007)(26005)(6486002)(86362001)(186003)(2616005)(316002)(6506007)(2906002)(5660300002)(36756003)(122000001)(91956017)(66556008)(4326008)(66476007)(8676002)(64756008)(6916009)(54906003)(66446008)(76116006)(66946007)(38100700002)(38070700005)(8936002)(33656002)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9CB0CE77BE888F4E8A5F5806BCC5E0D5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5498 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 619f2a3e-e1b0-474b-f4bf-08da31a3e1db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4vRCyOrffJYaHpEN2svwxWyldV+9Y5oOZv10Go2ahcmYRE591/M77mS1WTcQcxvk6tD8/lyim8uXU9jDTqsfdtTqt4GOeo1qBM7jTf2ah9Ogr/bNXFC6DluYvKYqQPtyc+rYdswGDEQtWrfL3q637Ns/iqBT2ps7mJCefBBHAYReXTsrkETFD8MIQM0eU5SH9TQWh488JT4J2+06kD8AACEAlpim1mS9id8Zi6JYpBrbDvptXUj3cFxC1IniC30w2cxdjC168CGmZdKXjZpc7NKLpvAQ8QnHig9wDDNkjifrmjkyBFku1z3J3EDtMcq5WrpWRoHmABTXQiMf3NYBkW/LuiDqsTjYtV+vo2GZx0ALK5Bq9zG/At5sVn22IZgITNoxFMt3kRezOF2ZLqdShedN8xudfY7AnxYSSz7G2QQO/KZCQYBOCTHvPi7S94BA/8ClsQVwMTQJQVloAJ4gSr7rNlBC4CsErjZ85Er6oRNKzglWh8W02mhvo+0tUlpeR5sLRJ6xCljCBtnyRN1mPZ1Gt8oC0TSyVbybaX62mD4A67Ih8sG68HP2NPwFtLw7Nu44lmNbHzQVbHPb4jGP97dbWJHHSFKeMPr8hu2dpxO7F+x2zknUqYZi2c5vuoHlYpylgWsNWz0EMvCmnI7SLCAtd64URNHdNlldlWM1zpr6T2j8CXsFdWoxIy2fDzBw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(81166007)(82310400005)(26005)(36756003)(2616005)(356005)(8936002)(53546011)(8676002)(70586007)(6862004)(4326008)(70206006)(54906003)(107886003)(47076005)(336012)(36860700001)(6486002)(6512007)(40460700003)(508600001)(33656002)(2906002)(5660300002)(6506007)(186003)(86362001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 10:08:45.5741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1992bf01-2ae1-4895-41bf-08da31a3e754 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3244 SGkgSnVsaWVuLA0KDQo+IE9uIDQgTWF5IDIwMjIsIGF0IDA5OjA2LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMDQvMDUvMjAyMiAwODoyNCwg QmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEJlcnRyYW5k LA0KPiANCj4+PiBPbiAzIE1heSAyMDIyLCBhdCAxOTo0NywgSnVsaWVuIEdyYWxsIDxqdWxpZW5A eGVuLm9yZz4gd3JvdGU6DQo+Pj4+IEEgbmV3IGNwdWVycmF0YSBjYXBhYmlsaXR5IGlzIGludHJv ZHVjZWQgdG8gZW5hYmxlIHRoZSBhbHRlcm5hdGl2ZQ0KPj4+IA0KPj4+ICdzYicgaXMgZGVmaW5p dGVseSBub3QgYW4gZXJyYXR1bS4gRXJyYXRhIGFyZSBmb3Igc3R1ZmYgdGhhdCBhcmUgbWVhbnQg dG8gYmUgc3BlY2lmaWMgdG8gb25lIChvciBtdWx0aXBsZSkgQ1BVIGFuZCB0aGV5IGFyZSBub3Qg cGFydCBvZiB0aGUgYXJjaGl0ZWN0dXJlLg0KPj4+IA0KPj4+IFRoaXMgaXMgdGhlIGZpcnN0IHRp bWUgd2UgaW50cm9kdWNlIGEgZmVhdHVyZSBpbiBYZW4uIFNvIHdlIG5lZWQgdG8gYWRkIGEgbmV3 IGFycmF5IGluIGNwdWZlYXR1cmUuYyB0aGF0IHdpbGwgY292ZXIgJ1NCJyBmb3Igbm93LiBJbiBm dXR1cmUgd2UgY291bGQgYWRkIGZlYXR1cmUgbGlrZSBwb2ludGVyIGF1dGgsIExTRSBhdG9taWNz Li4uDQo+PiBJIGFtIG5vdCBxdWl0ZSBzdXJlIHdoeSB5b3Ugd291bGQgd2FudCB0byBkbyB0aGF0 Lg0KPj4gVXNpbmcgdGhlIHNiIGluc3RydWN0aW9uIGlzIGRlZmluaXRlbHkgc29tZXRoaW5nIHRv IGRvIHRvIHNvbHZlIGVycmF0YXMsIGlmIGEgQ1BVIGlzIG5vdCBpbXBhY3RlZCBieSB0aG9zZSBl cnJhdGFzLCB3aHkgd291bGQgeW91IHdhbnQgdG8gdXNlIHRoaXMgPw0KPiANCj4gSSBhZ3JlZSB0 aGF0IFNCIGlzIHVzZWQgdG8gc29sdmUgZXJyYXRhIGJ1dCB0aGUgaW5zdHJ1Y3Rpb24gaXRzZWxm IGlzIG5vdCBhIHdvcmthcm91bmQgKGl0IG1heSBiZSBwYXJ0IG9mIGl0IHRob3VnaCkuIEluc3Rl YWQsIHRoaXMgaXMgYSBtb3JlIGVmZmljaWVudCB3YXkgdG8gcHJldmVudCBzcGVjdWxhdGlvbiBh bmQgd2lsbCByZXBsYWNlIGRzYi9pc2IuDQo+IA0KPiBTcGVjdWxhdGlvbiBpcyBuZXZlciBnb2lu ZyB0byBkaXNhcHBlYXIgZnJvbSBwcm9jZXNzb3IuIFNvLCBpbiB0aGUgZnV0dXJlLCB0aGVyZSBt aWdodCBiZSB2YWxpZCByZWFzb24gZm9yIHVzIHRvIHNheSAiV2UgZG9uJ3Qgd2FudCB0aGUgcHJv Y2Vzc29yIHRvIHNwZWN1bGF0ZSIuIFRoaXMgd291bGQgbWVhbiB1c2luZyBTQi4NCg0KSWYgdGhl IG5lZWQgYXJpc2UgdGhlbiB3ZSB3aWxsIGNoZWNrIGRlcGVuZGluZyBvbiB0aGF0IGhvdyB3ZSBj YW4gc3VwcG9ydCBpdCBidXQgaW4gdGhlIGN1cnJlbnQgc3RhdHVzIGFzIHRoZXJlIGlzIG5vIHVz ZSBjYXNlIEkgZG9u4oCZdCB0aGluayB3ZSBuZWVkIHRoYXQuDQoNCkNoZWVycw0KQmVydHJhbmQN Cg0K From xen-devel-bounces@lists.xenproject.org Mon May 09 10:15:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:15:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324351.546347 (Exim 4.92) (envelope-from ) id 1no0Qk-0001Su-V3; Mon, 09 May 2022 10:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324351.546347; Mon, 09 May 2022 10:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Qk-0001Sn-Rs; Mon, 09 May 2022 10:15:54 +0000 Received: by outflank-mailman (input) for mailman id 324351; Mon, 09 May 2022 10:15:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Qj-0001Sd-7U; Mon, 09 May 2022 10:15:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Qj-0002Tq-5i; Mon, 09 May 2022 10:15:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Qi-0006Q3-Kk; Mon, 09 May 2022 10:15:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no0Qi-0003A1-KH; Mon, 09 May 2022 10:15:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rp85xHbOkb1acMeRrINXqr7woUsgQTCe+N4h+CkwFyk=; b=I4loyN5RwKzeIguKjfEzu+pTug k57eqB9lrf/q/phQ4Dl/V3yuQ3ZnXRMBzG8/BaMFmBBraIOK2hd8jCRUEF1ZrXNBBe+5kT03iC2+J 8froaKgJFqUj9emaic+AFansxh2kwuNtqvXqTpLig+raxMKr8vuzF2O0d1itaGkfwmLg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170263: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=29ae55a0b8194fef2e769f2882297aa601b4777a X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 10:15:52 +0000 flight 170263 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170263/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 29ae55a0b8194fef2e769f2882297aa601b4777a baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 69 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 890 attempts Testing same since 170259 2022-05-09 03:12:13 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6163 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 10:24:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:24:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324360.546357 (Exim 4.92) (envelope-from ) id 1no0Yi-00033r-Ue; Mon, 09 May 2022 10:24:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324360.546357; Mon, 09 May 2022 10:24:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Yi-00033k-Rp; Mon, 09 May 2022 10:24:08 +0000 Received: by outflank-mailman (input) for mailman id 324360; Mon, 09 May 2022 10:24:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0Yh-00033e-Mb for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:24:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26afec6d-cf82-11ec-a406-831a346695d4; Mon, 09 May 2022 12:24:06 +0200 (CEST) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 06:23:46 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB5018.namprd03.prod.outlook.com (2603:10b6:5:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 10:23:45 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:23:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26afec6d-cf82-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652091845; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ECX+p35mrydB94rmIvJyxaxOhWegFt77CGPc3szY65I=; b=IZ5FvQeNK1SRrHnxRQFS/v0qAoi7CCjjR/DyCJdxaKRH3K8rgJdZ/HEI jZJ9ctS6HM2ByiRzFJrVDvfq4Wq8iRaKwjFA/WoOWKU8HBUFd9//ZpHen KtGdwvN0HtxT75WoCS3pSTP4G4LH8aNvtdlxJsQmp4Uc3d50753ZHerez s=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 73357848 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gsvRAaLlLhfkTjC7FE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENS1GcAm zdNDWvQbvzYNmv9ett3OYqy8EoHvpHWm4JlSAJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Y52YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 NFQ7reTEQkRBbLnqrQsfgNVNnFdYpQTrdcrIVDn2SCS52vvViK2htlLUgQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMGFGvqSjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SKkLmII9AL9Sawfv1bU8Cpj0unWG8fUV/iSfZpHh3y0n zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCn1m71mEVThoMWjOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPJVGuw+rQ2IlKzd5l/DAnBeF2EZLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqfJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:aMdE4KOz04jkDMBcT13155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2c6YRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv4EvoxKhNNKWs2N 60Q5iAtIs+OvP+PpgNc9vof6OMexzwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="73357848" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BPK91CIX8qTdGBp8JLz4yktWNkianaoUaIMt8/HdLxCmfqmXJsxVsU+P3jrV7eMY1/0XT3IaelcD13XeAsvYvn0+J0EPq6omXRzosoxveTvzf8PWAcpr0y3cyAH6S2WZmvkvj1RXJZpOwXcrGrfBpr45hzd4dSI3AWsJp1iWLfm+oDQEH8rxLDiydguritS4djkT4u2eiki9qVwWlRsNOn4MqRXApejzYv3cV09BqtrVQ/Ql7sgffboH3lXrCkkdvCik5rhltYyYoS1ZUMX/Nrs93ztH8ss1bT1H3bm+aG72v6SCXveqgDovo083T0HzzYuxkZxnSNYlERku3mCaAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GjRohO2w6zWAWxxxxyMvxjPFxMF3NNR0gFdp/U8yXKU=; b=fsmTmaeSp+wS2Vj484hPBklIZ4yU6DYW/yVF4cT3f5kwM+ZBaUYdoGuObyTIr26oGnvGU4otkxmC95cERBKoS7dY7dxFtCdd+5HwKuoDx+VXQBR9s3ZgOqbjrm4txNrM+VNuVBoWnNmBw+67+ZKRKc18YsYS/vx0F4Ea9Om6WNgGh/QYI45SdfhkM4uqd6guuc8VRfv2R+0cvXazAg0KQ9le08P++GjAjqm0XsP+9lHuVGXuEqq+JhVwOhfiizJBrH+qTMxJ1CsmGu0JF6qLMk/cD6Du3AXI+UXndjyK3FgK2Qy54vSUWzwn77C6zoyZSVCXHGX973jNiR8QH+9QUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GjRohO2w6zWAWxxxxyMvxjPFxMF3NNR0gFdp/U8yXKU=; b=QwbKdLYCcijnXHHeNG51nNOY/Z+D4uyJRRlF39LIEjN2qvYgU573CVxU7nfKpW5ORhPtCfL/wLVY8U4CPKf9cEVajiXSagX+opI6CpWcFYjWabeHCcQxNsrgVXsT0PZdvwvUS40/IrYdznwqWLnmOloZ+YMHCGg3VShyoXIkoGE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 12:23:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Message-ID: References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-3-roger.pau@citrix.com> <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> X-ClientProxiedBy: LO2P265CA0395.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 567ca1c4-28d5-436f-a607-08da31a5ff6e X-MS-TrafficTypeDiagnostic: DM6PR03MB5018:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NSKY0xYmQfwtbsTIBCHYNtTMWwxsiZMOPq5dtkkWadfLaROJITdRSr7A8RMIvH1oaAU9Lf7Kg9OOPvlbOvrimsb9bjJhvReopZE4Up/44UbJDxn7S5r/qLDL4slqQD+eC82nLBZyF+l6mS/5imYFlp+Mxk1VG2zie+5NDdwZRRt+mHrDeYxiXcXNTXiUWTK4tN/3/u+eXQ7rPbfEkAgYvg4oODkg3TI7DBuhubsHek9+WuvrPZmOOM//1OCL5vf4u2Ipur8o6FTARnnCnwoJI8wvu+zwOBrnqx/V26QiOh6d1lnogjhcRqaw1Vx71cHwKLWNKwjzMpMq2GKqVyCuPPY3xTI4vR1DjUijFlIUb4W8QNETK3lPTtpx8oT+UycbG+pQK5JcjAoAFvq+XZPljHzuZ7AU1ql6OFX4ZoL2C/CCbZ4FBbNvAyvVM3nX38u0O1mxnlj2QzENm5syuUYlt5ZBEARe1oP4npA2/OpNFawD8g6PqZ5llpFsyhKhZA/zYcIFgFa8pN8M1uuiNnQeIVvva6OCsbAPk/WyxLFkDLCfWAtzyjDCC6zt9Ujf2d4U0rKUsm63HxJDbhdD2qQc6uS1rkVWli18CeIIfiHobSdImH5vdg9/VqmhXOnVFdT5N+/HTGbJb5yoe8TUgSqk9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(9686003)(6666004)(6506007)(6512007)(2906002)(4326008)(8676002)(33716001)(8936002)(86362001)(5660300002)(66556008)(66476007)(53546011)(26005)(66946007)(6486002)(508600001)(38100700002)(316002)(54906003)(85182001)(82960400001)(186003)(6916009)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVg1aFN1dlhOcXNXbVFpMDE3RUhkSUQybjB2T3hJRm5SdjJjdjlSRnNJRUZR?= =?utf-8?B?QVR0VVhRSVVkeE12NG5MM0Q4R2lBSExtbVdzUFV0KzgxcW1LWXdDM0hmOVZY?= =?utf-8?B?c3lHcGFMUTBBcXZjenJPMTZ0aC9iQ3BIQm52MWZiNys2cU9vUklBSi82Z3p1?= =?utf-8?B?cVJQQmRUUEt1VHRIbWFjNVJ4dXNqNHBOQUJnUVdnK1JQMXBSbHdhTk50bVVw?= =?utf-8?B?cVdjcjd4ZEo3SE0wU0hwdDRMUnhDNVYrazJ6OGkwa3hPYVVtbnFVUGRhWHg4?= =?utf-8?B?VHo3bTAwTkZGM0xxekFrdUJyc0lMenIwUzF1YXNhaDJUa0ZHRkkvVTRJTnht?= =?utf-8?B?d3JTWmdFMFhiYnhUdHdLYmxSSmxMU2ZEcElVR0tRS0UvQTVaWXljZzB5YVlt?= =?utf-8?B?SC9YQUpMSUw5ODBENG0zZ2NDS0VOVFFHMjFsMXRJQnJzcVlSTjFJTTN3VmdQ?= =?utf-8?B?NUZjN1J6MWJ5cUdteDlYUzRXTTc4M1diZ1k1WGtZODA4NlY1TnVsWjNzQ3ds?= =?utf-8?B?bGVKRWgxRThCYU9PT0x0b054Um1IQlZ3M252bGtxUmExZ0ZFS3dYd2pQYmVp?= =?utf-8?B?TU41ckhWK1JVZGJzcmNsZnFScVFNMmpkR2xLWnRnRkpFQUovRjduQmExYndQ?= =?utf-8?B?ODlORjNtSlNiK0w2NGNHMFpSa3dmR0pWWTlTdnIxdUlFT2dHNEVWYXFiNVpp?= =?utf-8?B?bEtNRlBBNFRIYWlwazNHZVZpa1JEMWJVMkhjVnRsVEVERGpvdnhsTlZwN1Rw?= =?utf-8?B?aThUQlJobVBxNUdtTVA3NHFYSkczbHFucDFMTW15WGlWZ283amlEQ2czdm9Y?= =?utf-8?B?L2xNRW95Tk9PeGc0TllxTURhWmRvSy9sUmNlZnllYUg5c1ZQT1EvM2NSaGtj?= =?utf-8?B?eElyS0hMTC9GMER1RlNDaDNsQUdDSWs5dmxseXlVRGhXN2ZqNEZTMTV6MU9z?= =?utf-8?B?M2NFMHlqWlpWV2NVd1VzdG5jYWQwTWQ5aXI4OTR1K3ErSjJrRTZHYXR5R2tT?= =?utf-8?B?Sk9CSlBLckNHZXpjOVJRYjJ0OVVxY25FbkZRRnJFQW1OOCs2MUNzVTNXN0ZB?= =?utf-8?B?bVZMWXhCTzZVYm1vczFYL2VJN2E4ejhsQTBCbkdsRjlNcVZ1Sm91ZGJDa0tT?= =?utf-8?B?aTY5c1RwcGEzSHJTTmZCaVhoNzBIWmpzWSsySi9HbkxZWXFGQ2VGOU4zNkU1?= =?utf-8?B?M0wxSm9uajgzRU1JeW5YdnBBOFF0V25wSDVEQ1lRSTRQb2VkZGJNREZVakVZ?= =?utf-8?B?VE1hUERWOGhiSlJSc2ZhRnROWHRpNmRDT0dMYm1UWXozellWdHJLRGVuVHFO?= =?utf-8?B?NTc1TCtvQldrMnp2SUE4NzBZVWJhMUltYnlGTVl0MGt1MGd5cUYzK1lud0xH?= =?utf-8?B?MDl2dUpqcjNDMVAvQUl2N1dTaE9ubUtNclZpR0dqWE4xOVdESXJJRUhlbXU0?= =?utf-8?B?M3pnYzBHd1diY1Fpd0lsM1pWOXJBMmpJcXU0NXJ0bi9DOG5zSDh5ck9aMEgx?= =?utf-8?B?OVp2d1FHa1ZQZ25jT0V4bU81MmdSWDB2YmZkUVIzM2FCc0tQYWIvdEVKcjkr?= =?utf-8?B?WDdjdXVKT0N1MEZjY0Nmd1I4bzh0cVQwZjl0dGVBbUVuOGt1U3NxcTlqSWlz?= =?utf-8?B?bExqVFJJQ1p0RXVVRDlFNXA2NzhUeEF2cWVsQTgzSUpyLzBBWWRhcVlpdmZ4?= =?utf-8?B?ZVFFODM1bEJSQWUyMkR5bnZKVFFSU1F4eHMzaFk2bEVpdXlDWloyZjhRKzBL?= =?utf-8?B?MUtEYkpxdlRrSUZ4NHduQmp0VVAzektpZFBtY1BaeGUrT3VFQk8wTFNkSFNX?= =?utf-8?B?cjFTMWpoSTgwdSs0V2Vkd0EzQ2JRb0hsSE1KSXAzNUFLVytTTUV2MVZoOXg0?= =?utf-8?B?dU5rTEs3NkJKM2Q4SHh0N05DbUZkUU9XVTh4V0ZLcWhpQlJlQUQ2Y0IyU0ZJ?= =?utf-8?B?em1sbWh3R0JoUUZWNG5MMk0xVERMZGRyR1ZqVHBwd1VDbkYxOFEyNkkzQmxp?= =?utf-8?B?RHJGL2pMOVRnYS9ab0ZsS0NaMEZXdlVhbHhseXE4WlppZTFXODRTWWQzcE8r?= =?utf-8?B?alFPRXlhTWN0VGMzbDVlU244NlhaSTBSemdMQzZ1S3ZhWEtZUWdaa255M3BG?= =?utf-8?B?cm4rQ3JxNDlmQ3RwczZDZTJKYjIzWTRRUVNjK1QvYlpvOUtpK09ITmc4aWhi?= =?utf-8?B?SFBsbnhwaHZOcytWSGthdUFBeGRxYXdva05wajUxcEtKamhGQnBsZnRMVTVU?= =?utf-8?B?cGZqY3JOcnAvbUxxKy9IbVlOMk1MWkhmZFdJaEx2TVZrYmVCMDY0M25Jd3Iv?= =?utf-8?B?UGxRdkFSVEYwL1NpOFE2K29UbDFzOHhiUjJ5a3dvOWFtS05ZeFBUUy9ZS2I5?= =?utf-8?Q?cX5bmtmPX5+KHUWg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 567ca1c4-28d5-436f-a607-08da31a5ff6e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 10:23:45.3027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a4enBX0m/J37nYIrhHwwD0/DtbfwNyhejz6qakasHY8k92sElDYxjxjBzMfQ5zoKD2inZ0Yi4Njm8pBXBCLwTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5018 On Fri, May 06, 2022 at 02:15:47PM +0200, Jan Beulich wrote: > On 03.05.2022 10:26, Roger Pau Monne wrote: > > --- a/xen/arch/x86/cpuid.c > > +++ b/xen/arch/x86/cpuid.c > > @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) > > raw_cpuid_policy.basic.sep ) > > __set_bit(X86_FEATURE_SEP, hvm_featureset); > > > > + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > > + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > > + > > /* > > * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional > > * availability, or admin choice), hide the feature. > > Especially with the setting of VIRT_SSBD below here (from patch 1) I > don't think this can go without comment. The more that the other > instance ... > > > @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void) > > guest_common_feature_adjustments(hvm_featureset); > > guest_common_default_feature_adjustments(hvm_featureset); > > > > + /* > > + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus > > + * VIRT_SC_MSR_HVM is set. > > + */ > > + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > > + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > > + > > sanitise_featureset(hvm_featureset); > > cpuid_featureset_to_policy(hvm_featureset, p); > > recalculate_xstate(p); > > ... here is about default exposure, so cannot really be extended to > the condition under which this is put in "max" (except that of course > "max" needs to include everything "def" has). Would you be OK with adding: /* * VIRT_SC_MSR_HVM ensures the selection of SSBD is context * switched between the hypervisor and guest selected values for * HVM when the platform doesn't expose AMD_SSBD support. */ > > @@ -3105,6 +3116,30 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > > vmcb_set_vintr(vmcb, intr); > > } > > > > +/* Called with GIF=0. */ > > +void vmexit_virt_spec_ctrl(void) > > +{ > > + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; > > + > > + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) > > + return; > > + > > + if ( cpu_has_virt_ssbd ) > > + wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); > > +} > > + > > +/* Called with GIF=0. */ > > +void vmentry_virt_spec_ctrl(void) > > +{ > > + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; > > + > > + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) > > + return; > > + > > + if ( cpu_has_virt_ssbd ) > > + wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, 0); > > +} > > I guess the double use of current makes it difficult for the compiler > to CSE both uses. Furthermore for symmetry with the other function > how about > > void vmentry_virt_spec_ctrl(void) > { > unsigned int val = current->arch.msrs->virt_spec_ctrl.raw; > > if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) ) > return; > > if ( cpu_has_virt_ssbd ) > wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); > } > > i.e. "val" always representing the value we want to write? Yes, that's fine. I've adjusted the function. > With at least a comment added above, and preferably with the change > to the function (unless that gets in the way of the 3rd patch) > Reviewed-by: Jan Beulich Thanks, will wait for confirmation that the proposed comment is fine. Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 10:31:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:31:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324367.546368 (Exim 4.92) (envelope-from ) id 1no0fz-0004Yi-Mh; Mon, 09 May 2022 10:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324367.546368; Mon, 09 May 2022 10:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0fz-0004Yb-K3; Mon, 09 May 2022 10:31:39 +0000 Received: by outflank-mailman (input) for mailman id 324367; Mon, 09 May 2022 10:31:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0fx-0004YV-KV for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:31:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0fx-0002mJ-B0; Mon, 09 May 2022 10:31:37 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no0fx-0003an-4m; Mon, 09 May 2022 10:31:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YzYQEWXqF4mmeF9MkGzosy6IevOTDVLvxL6FoXKhWuw=; b=4mwEM3urYX9s9cdEhe3Nhgb15Z mmfrq/6KfEEhq1ywzqdGI/Mck5X8979Xf4rJM3rifDHzIA429Gi3ffBxy27o4ILUnkoELZpYLGxfy Fde6cIlVgIah1XkMZz2v2tCeTlyXX8DCfZdHjjR1SUwylNM0RamicSFBHfim+0N3VZQs=; Message-ID: <0ac6d6c0-4f34-ad1e-c473-2278dd7289c9@xen.org> Date: Mon, 9 May 2022 11:31:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> From: Julien Grall In-Reply-To: <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/05/2022 11:08, Bertrand Marquis wrote: > Hi Julien, Hi, >> On 4 May 2022, at 09:06, Julien Grall wrote: >> >> >> >> On 04/05/2022 08:24, Bertrand Marquis wrote: >>> Hi Julien, >> >> Hi Bertrand, >> >>>> On 3 May 2022, at 19:47, Julien Grall wrote: >>>>> A new cpuerrata capability is introduced to enable the alternative >>>> >>>> 'sb' is definitely not an erratum. Errata are for stuff that are meant to be specific to one (or multiple) CPU and they are not part of the architecture. >>>> >>>> This is the first time we introduce a feature in Xen. So we need to add a new array in cpufeature.c that will cover 'SB' for now. In future we could add feature like pointer auth, LSE atomics... >>> I am not quite sure why you would want to do that. >>> Using the sb instruction is definitely something to do to solve erratas, if a CPU is not impacted by those erratas, why would you want to use this ? >> >> I agree that SB is used to solve errata but the instruction itself is not a workaround (it may be part of it though). Instead, this is a more efficient way to prevent speculation and will replace dsb/isb. >> >> Speculation is never going to disappear from processor. So, in the future, there might be valid reason for us to say "We don't want the processor to speculate". This would mean using SB. > > If the need arise then we will check depending on that how we can support it but in the current status as there is no use case I don’t think we need that. It is not clear how I should read this answer... If you add SB in cpuerrata.c, then a user will start to see message like: "enabled workaround for Speculation Barrier". Which is completely bogus. Replacing "dsb; isb" with "sb" is mostly an optimization and none of the current use will end up to be architecturaly executed. I appreciate this is more work to add cpufeature.c. However, AFAIK, there are no rush to get this optimization in (see why above) and muddy (even temporarily) the logs. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 10:39:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:39:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324373.546380 (Exim 4.92) (envelope-from ) id 1no0n2-0005F3-G1; Mon, 09 May 2022 10:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324373.546380; Mon, 09 May 2022 10:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0n2-0005Ew-DB; Mon, 09 May 2022 10:38:56 +0000 Received: by outflank-mailman (input) for mailman id 324373; Mon, 09 May 2022 10:38:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0n1-0005Em-NP; Mon, 09 May 2022 10:38:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0n1-0002t7-IH; Mon, 09 May 2022 10:38:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0n1-0007gk-1B; Mon, 09 May 2022 10:38:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no0n1-00023L-0H; Mon, 09 May 2022 10:38:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iSOVv/gOeCbpwM6EYXWPY0d+9d2Wh12SaLpyw98ndD0=; b=yFW9Drwe6weOs2VEG/7FvRtGt5 A7gGTqmMLqZ1mO4/Bcx6+RvQyjxr1ihEJ7W7ACOd7udxR1QEJL+P1TwimcJbiF6OhowoFzkzGm4N4 CRgpinmQpeT5PZ/XrjncmGz0bvrt5HisQCji7yID6mtoJhF7uZY2wCtYITBY8ezAv90s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170256: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=554623226f800acf48a2ed568900c1c968ec9a8b X-Osstest-Versions-That: qemuu=f1336649156cf57f5d874a98e619fb362e3fcb59 From: osstest service owner Date: Mon, 09 May 2022 10:38:55 +0000 flight 170256 qemu-mainline real [real] flight 170265 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170256/ http://logs.test-lab.xenproject.org/osstest/logs/170265/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 13 guest-start fail pass in 170265-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170224 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170224 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170224 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170224 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170224 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170224 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170224 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170224 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 554623226f800acf48a2ed568900c1c968ec9a8b baseline version: qemuu f1336649156cf57f5d874a98e619fb362e3fcb59 Last test of basis 170224 2022-05-07 20:39:09 Z 1 days Testing same since 170256 2022-05-09 01:39:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Helge Deller Mark Cave-Ayland Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f133664915..554623226f 554623226f800acf48a2ed568900c1c968ec9a8b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon May 09 10:39:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324382.546391 (Exim 4.92) (envelope-from ) id 1no0np-0005qU-0Y; Mon, 09 May 2022 10:39:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324382.546391; Mon, 09 May 2022 10:39:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0no-0005qN-Td; Mon, 09 May 2022 10:39:44 +0000 Received: by outflank-mailman (input) for mailman id 324382; Mon, 09 May 2022 10:39:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0nn-0005qB-La for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:39:43 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53877c2b-cf84-11ec-a406-831a346695d4; Mon, 09 May 2022 12:39:41 +0200 (CEST) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 06:39:36 -0400 Received: from PH0PR03MB6382.namprd03.prod.outlook.com (2603:10b6:510:ab::9) by CO6PR03MB6306.namprd03.prod.outlook.com (2603:10b6:5:35f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 10:39:32 +0000 Received: from PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce]) by PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:39:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53877c2b-cf84-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652092781; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gbCaxO3gVVhh3FWHiIWPid9PzO/ldwJDnuiz7Bwe5/I=; b=fdNOZwpAbyOI2nalQtpSUa65uVklHgmtbbw9ua/LI75h4ERhzhON+i6w LEDE9B1B2MieumDlXdi7AJ9klDrUY8GLaiiC6ALyHNfXqPCRHm9MqXVwD BIlRMVkoeKg2QXv8yYXn9ocPsVPy355qOR2fhi0wHnd0iAM01dXiCsfu6 Y=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 70744986 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3knHEK4JdIDcnFqO3SxawwxRtCnGchMFZxGqfqrLsTDasY5as4F+v jEWCmmBM6qCamr2f911O420phwP7cCBnIU2Tgc9rH80Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXhUlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSqES0qJI+cvN08WkZWOQRTDLJl5OX+dC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YGjV/chegXdRraT 9AeciEpaB3PbgdQM1MTIJk/gP2plj/0dDgwRFe9+vJovzSCnFIZPL7FFOuSYfmDfNhvl1+h/ G//2Tj6PA8EHYnKodaC2jf27gPVpgvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A 1cP5iMkoKw29UqqZtrwRRu1pDiDpBF0c8JZDukS+AyLjK3O7G6xH2UBU3tNZcIrsOcwQjol0 ELPmMnmbQGDq5WQQHOZs72S/TW7PHFPKXdYPHFVCwwY/9PkvYc/yArVScpuG7K0iduzHizsx zeNr241gLB7YdM36phXNGvv21qEzqUlhCZsjukLdgpJNj9EWbM= IronPort-HdrOrdr: A9a23:bB/7/qA5ozu/C/3lHegOsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEDyewKnyXcT2/hcAV7CZniqhILMFu1fBOTZslrd8kHFl9K1kJ 0QC5SWa+eAQmSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+zA+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRiuerRfb8yfT9GA+czzpAV74RH4FqewpF591H3Wxa0u UkZS1QefibpUmhJ11d6iGdpjUImAxel0MKj2Xoz0cL6PaJOg7TB6d69P1kWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5wKJSFcZ4JguZkZkIMIjgX5q3P4i1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwI/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFnxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIuiYfzQTObNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRrPvHm X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70744986" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PBTgzUi4QlX+Gxk3RyC1OMWndfsKkkWb/W0H7EERxfBDxDBjZww7emJubWCT+rC7ei5ZgnKFJ6knI9XYWuwXtRGY3Qwtw1oC+xaG/R6sXyOvI47uDa97AA2YnBjw5mpAJ6iN/G92VCgyq3Rf0S2dPkve4ufdcRTFmItwBcCCthWcF9WbSgXSqpQX9aaSAMepsmPuSUijinb1JU2ooYKNTKHHyIdtKNOkQy//cmwVrAt23I4eUEWOKCofB3i11qttQpHZHr5Dq9JMr05/T+GJY+iR19aq2Z4oBYLP7TWIkBAr8O/pUmqLxnaTd1FrIr02Y2rzBt3YX+4yH8pp7Wl2Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2jD1O5zLnOSIsMU/9++7kis5g3HRa9EjhEyeVhDByHY=; b=Z5Dz+DgcEMvfCmEtSRHG8jKq3E3+yugDdeIZ3NCxjk6x0Re4Mosn/HEic9vTh09ZdLN6rMc+57wOyzgPqj87bzgU8e4DC+ZT8UpNLk8FB5eyidnYOmwH0+SVp6+xlsNZ2uEsqQY+JwZcLRm6JAkz2H9bkPygxECbePBJi0Wkaf9yuWFo8+LRgURqK2AX9t/srOrPDATkXrzNYUIY9Mu4sC9UCD0WZ+QKfsyRYH2vib0s+Z61QxGJvV2xKRSJxfRiBVyGx+sliyL1Hsy5ek3w3L5f3kAwGnvOOMhq0cg8NLMED8YAYczwwaNiVFk/m51wQrEcy96bjDcXbLHq64mf8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jD1O5zLnOSIsMU/9++7kis5g3HRa9EjhEyeVhDByHY=; b=WqWK/T+jec5bmBKHH8RE+bc9eTJBJWNDhrUw6HYXZB/sXwzUbRYreX2Tk06sqvVYuhuqlNBEMY1FQRwtcNO5OxrSjIZUttwbgmRWTTMaCctNiiWsu3AcuPMkx+8idjfY1kOUngxkgwqgOp3mWNP3ylAHOyNcNkjT3jaCpjCpvNQ= From: Ross Lagerwall To: Roger Pau Monne CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Anthony Perard , Paul Durrant , "qemu-devel@nongnu.org" Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Topic: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Index: AQHYWlVI6k4vzeGas0CbAgtnJ0rrZq0WWb2AgAAQ5LU= Date: Mon, 9 May 2022 10:39:32 +0000 Message-ID: References: <20220427163812.2461718-1-ross.lagerwall@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d51da80b-d31b-454c-7916-08da31a833e6 x-ms-traffictypediagnostic: CO6PR03MB6306:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hL5+FPtclczwjgCXfi0miMmVNPz/+6z64zoZUGm+Kc2CXfJZUwUrzC70UucnkqZAZnNfz+YfRAnIPBU12QQpuY0/nfFY/Tx3uzPcD3lacJB6Gjf+8kIUmY7NolAgbaaGN6OyB1Dr9UBkpigfO/GFFw71g7yCxSPiqLetgn08yLdFsg1Eq3O8hrR+iSaQKORQRQ7oq2+0D1UrBHHxvpdK5+l79mfHT8MF4bYdhQK0DgtaBAGWKv7QPiRHLfi+U4up44P3sCQ9iCBdlZ65/JYzkT1yWEbTWZhXJsHeHWuJ2RiTSI88TAANDxZslmahvfLRseJTpEwd6sjvBIVTLNh3jeu9hZ06xc24gSBUhlZJkzU2M1yq5+oPcZC4AdjOo3n65zQa+zNbcKCFtk0tal6itzAzZ1u/hCG83bY8A0IifSFPNTWgn1AdJ7CG8sLNAjtSQMvkXVsXBEgGNwh3Hmw6UtgMwAol3O7al4S5xtRPXHfZ5EUbMeHOZUx6bhiXsmPwm7DXOhWY4+jAliqueG74fydUHly34vk4IH7EANzhF8F0Zr6ZRv0s/6bQ0kOqCqiuEosZ/PPwm9rWg8WUUxqDZ7MVTI5e6M1Tojjn/anT5auj7SY2noswKnJZvvoa4AK/HR659avgx+z0+oMSGnVBAJP+XALeWzK8pzZLKqPS7teVXyW05dZQn4zJ4Ti/uCl67YE6/fQk2BZtjX/WenaSmg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(38070700005)(55016003)(44832011)(38100700002)(33656002)(9686003)(2906002)(5660300002)(6636002)(54906003)(26005)(86362001)(6862004)(4326008)(64756008)(52536014)(53546011)(91956017)(66946007)(8676002)(66556008)(66476007)(8936002)(66446008)(83380400001)(7696005)(76116006)(508600001)(6506007)(186003)(122000001)(71200400001)(82960400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4Iy4JVNGL6OBebHFJd395futqT5dyjgsrFYtJ8f8bosNoi2WkayUX8cGhg?= =?iso-8859-1?Q?BMrWC1kh0pZ35Py809WMXvUwi2iliiokazvyfWTbY14yBYxHzc8k7GxLD/?= =?iso-8859-1?Q?j+RuKCv3A1cebWTfnW7i8yLe85GxT5JXmDEQI020sP/LbMgDskvxYx2Xnq?= =?iso-8859-1?Q?ujpXWcFg2OYBCRCO4SdXJy5B9jWiskKmwnJB3P7HB4wi6Cimt5HYsd1qyp?= =?iso-8859-1?Q?zCFWILFZgLwNsVM74WvB3b5N5KVHXkc9aTqJybdEgAMyYDlFv40NHdfpFU?= =?iso-8859-1?Q?F2rHT+ci2Sc4RF6YOtnYz0dep1GCqpJgUm6zxN29iYZO2RezT9oCTF8DTK?= =?iso-8859-1?Q?z2ewpVYWLf5EDmuxPCJG9L1Y8aZCx0KX6W6NBkgPt5nkNKrUXBM2efRD8e?= =?iso-8859-1?Q?3MGRQA5F3OgBEQ5jEvKziUUFTjIU81m6bbRqbwHnmmeKcOLfNIp49vmXzj?= =?iso-8859-1?Q?5bFv8qZupNEXLvk0PiS0FVa5SEvsWo7C/cslEGWbYOriZun49ywIV5LlZi?= =?iso-8859-1?Q?HnXyp1TbrPw+p5K3/8OJQEFIzUuvQNeDJ+q/PRTCJdSGhxq+Txx9GhbIEp?= =?iso-8859-1?Q?D2cDx9fvvcbdW7+QZTTXyX+ByHXQuu6Il6e5bri8Aj9WKXBsgekjisewN7?= =?iso-8859-1?Q?SatWlV27lDP6Yq/15qDKpNxrUy+n/x9PMBkh9n034Rom6UI2A/Eo/vugDZ?= =?iso-8859-1?Q?mfT+lb4v+8vYfJb/msmcpkjHjZSYux6ARb7Ka68Smz+MvIfrO2k5eMH4af?= =?iso-8859-1?Q?tCsKHy628cDxfIot1Sje0WY2D97EqJHRDiXcpjHw4AozmjrIHYNyjfx5Dh?= =?iso-8859-1?Q?EUNdMZrEaIhhPDa+a6s26VgS4rMYWX8kdWOoEGAr/hRI1Bkp7KoScKqEGc?= =?iso-8859-1?Q?jE3tVUO7F0h6GIDfPq/4a96xRXYcY4I+OJFQweYdzG6Ev0gaXSXThqJozR?= =?iso-8859-1?Q?kuAu7Y/QnDGoVxmoQ3p5/BpmhZWlfhZpkQ7cJpqMxXJZr9GzGwBbclo6ca?= =?iso-8859-1?Q?Rdw3lwLgRe/Ft031pGtpcgkzdrt2xt8bEFSWA2k59Ti+BuEa6e91T8Xu91?= =?iso-8859-1?Q?Ju2LKfjzJOFJn+IVE3gfrMAW+N4dF+mcrVW9yXFMDX4wbGqSxN+3G/30o3?= =?iso-8859-1?Q?ivc6js2DMAOXPfbyi7S5kgNDVjgK5a6NeSdy33BJ2AclzpYEf4E8REcMEO?= =?iso-8859-1?Q?dAg7DMyoUU/IWhz066XLaOgcy2wcy5pA6D+v+xFEMx7o8j9NxC0fJXylXj?= =?iso-8859-1?Q?n9J/KrsKWMD27w56siLRyVwbyCO5enDJRkAbMaUdc6DD1RyJ+GK4eGN3xa?= =?iso-8859-1?Q?Fu9qsa8V6JpitY0q9waXYtjITTD/+iqVrmuMtBmfc3urdwCKuvHaPngajV?= =?iso-8859-1?Q?JE8/A0ZD/hg2nWBDlk2BbBq4q6pP31BD9WRhZg6NI0g8nbI/GdYY2+Mjr6?= =?iso-8859-1?Q?zyZEn5VDKt9WCdeYL0fSZQrZLoSalkWV/OIemhcf1wxSR3ojkixYT7HZC/?= =?iso-8859-1?Q?sMsC7W1csiOb3z397y1ay9LyHV1/B0o86NeBLIxx1wurX6Udn43HuF6VZz?= =?iso-8859-1?Q?p5295OeRvgnZi2Wxgfz1V9M364ejuPQIstmoptlEjIdeG+bJuuu/M2M3ce?= =?iso-8859-1?Q?gWjm6LpboYTjimvisk89Q0DhwcSYvX+cfhExT3sTSzQGP1IbY5XwrBHENd?= =?iso-8859-1?Q?lhV5Ttkp/zWHx/OSftdDuCw7YBUsB00V5SMlmkdiZCWkS/tywFIBO6E1Vq?= =?iso-8859-1?Q?Ubuct/4YJtKFwBIkyEPjLKVqH+T9L4IGC9+Wq6+EpYCoHGMe4+UOiP0Hlc?= =?iso-8859-1?Q?u4SPQnywt7pCifAQPxnX7HuSQc8+ReA=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d51da80b-d31b-454c-7916-08da31a833e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 10:39:32.0729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pnf6QlHhbUcQ22TzJdCyWQ7amvIRAq0ls9rO67SJiPo+TTRqCk897xDDTqDsIHxQbHGRof02LL+zKSM+eV7tQZfOV4A7RaQUjlgBA6IRQ3c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6306 > From: Roger Pau Monne =0A= > Sent: Monday, May 9, 2022 10:28 AM=0A= > To: Ross Lagerwall =0A= > Cc: xen-devel@lists.xenproject.org ; Stef= ano Stabellini ; Anthony Perard ; Paul Durrant ; qemu-devel@nongnu.org =0A= > Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones = =0A= > =0A= > On Wed, Apr 27, 2022 at 05:38:12PM +0100, Ross Lagerwall via wrote:=0A= > > The BAR emulated register definition does not set emu_mask because it= =0A= > > varies depending on bar_flag. If emu_mask is not set, then the BAR is= =0A= > > initialized based on the host value which causes the BAR to be initiall= y=0A= > > mapped at whatever value the host device was using. Although it does=0A= > > eventually get mapped at the correct location, it causes unnecessary=0A= > > mapping/unmappings.=0A= > =0A= > Would it be possible to just unset the memory decoding bit in the=0A= > command register if it's set?=0A= =0A= I don't think that would be sufficient since AFAICT qemu does not read that= =0A= bit so will still call into Xen to update memory mappings, etc.=0A= =0A= > =0A= > > To fix this, initialize a per-register emu_mask in XenPTReg from the=0A= > > initial value in XenPTRegInfo and then let the register's init() functi= on=0A= > > set/modify the emu_mask if necessary. Update the code to use emu_mask= =0A= > > in XenPTReg consistently and rename the existing emu_mask in=0A= > > XenPTRegInfo to emu_mask_init to help with refactoring.=0A= > =0A= > Iff we really need this refactoring it would better be done in a=0A= > separate (pre)patch, so it's clear what's the fix and what are=0A= > refactoring changes.=0A= > =0A= > I also wonder whether why it isn't enough to set emu_mask in=0A= > xen_pt_bar_reg_init(), without having to introduce a new field.=0A= > =0A= =0A= That doesn't work since emu_mask is part of xen_pt_emu_reg_header0 which=0A= is static and is not defined per passthrough device so having multiple=0A= passthrough devices would cause issues.=0A= =0A= I have an idea to achieve the same result with less code churn so I'll=0A= try it and send an updated patch.=0A= =0A= Ross= From xen-devel-bounces@lists.xenproject.org Mon May 09 10:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 10:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324389.546402 (Exim 4.92) (envelope-from ) id 1no0xe-0007RZ-UI; Mon, 09 May 2022 10:49:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324389.546402; Mon, 09 May 2022 10:49:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0xe-0007RS-RE; Mon, 09 May 2022 10:49:54 +0000 Received: by outflank-mailman (input) for mailman id 324389; Mon, 09 May 2022 10:49:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no0xd-0007RM-1E for xen-devel@lists.xenproject.org; Mon, 09 May 2022 10:49:53 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062d.outbound.protection.outlook.com [2a01:111:f400:fe1f::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c13941e4-cf85-11ec-a406-831a346695d4; Mon, 09 May 2022 12:49:52 +0200 (CEST) Received: from DB7PR02CA0032.eurprd02.prod.outlook.com (2603:10a6:10:52::45) by GV1PR08MB8033.eurprd08.prod.outlook.com (2603:10a6:150:9a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 10:49:48 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::7c) by DB7PR02CA0032.outlook.office365.com (2603:10a6:10:52::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Mon, 9 May 2022 10:49:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 10:49:47 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Mon, 09 May 2022 10:49:47 +0000 Received: from 84f40401e50f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA19423F-48C7-47B4-95EA-BA81C219835E.1; Mon, 09 May 2022 10:49:40 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 84f40401e50f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 10:49:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by HE1PR0801MB2058.eurprd08.prod.outlook.com (2603:10a6:3:50::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 10:49:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 10:49:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c13941e4-cf85-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XuGlKkjAAAShlHyDPRN2Bx5ZOy3UbugYEUcDFSvSmiQ1zV3udJBhGdvd0WlgXwW6rMgBDnpinC7ZRJViYzxua9az8gYag31yPNOXJQEj8Dj+lUoY4TPZeqZ8TGLqH/C2o/A48kxMEK/l2Et7GDocOHVqfsxcNhs3mELT/Or7LRRh95pNZTeJSGDC/9upwOmpyVOwkBOYX1rXRDpR18QiIdAh6C/prAj1CghkmGMbv+H5xbuOdyIcgT3qBXhXxQjqBS2WvYhcK8pZmnuiO9yIk3508OAV4r5fXwT/g+oFkIRIgvzch941t/7EMPqsPIi8AmA4nvBKDbSPvmonf4WasQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UxVaQMx+lv0ITeN6nkEB0ETAt3MqVsfGx9fx5K+EEsI=; b=Wtj6VQhX+Cq37viFaceI1i6hpibrNscAAXYhGG/jcMxpK+9UNxToAvSEhVZ86unmCiyTINbZg+jb+6oWk52wxLBwFYtOef75mVSvNSTqJBZxrMozOyje1nPb5S4D/z9ZCz7MhusEf1INDgTOS9gQHYPQZTp9RnJFhOhx+5Rysupdm+G8EAYtkVbPIJyQKlKTKjO8yomiNfEJJItvNYndRA88VVrlxtKakOZa3kgi/lRnBtpDPDve/RVQ4ZNu8w2XlctBuIKXepg/ETlZFlupcbKkRQUJrCvo/quZ90f1MWTGFWNxeTKmqNZOXslSHg4mLXTnlVIdTvGgyGqKlFmKzg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxVaQMx+lv0ITeN6nkEB0ETAt3MqVsfGx9fx5K+EEsI=; b=kxOKGmNg0HquXaA4lCTOVzCccMmWyyR8jB6kenwYapgW0GWe9MtF6ZilrW4Qf+P1qXm446GHiCOPaethJlDz2cXBGp1uoXVBTOFzZRPHtbJNUPegs0HIc0ICjRC3BllGS7qD2WdlfLdn2X+R5zhy9rQQz0zw4JOOjVD6RNSjrX4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 2dc891999b583186 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MimHVU/747JlH8fqkjmImlwkT4MTgKTqzwegGtwA5RjQP1sDRjnfX5GhQLSSsopQSg2JADl2A3pRu1x2XPjQQ/0hztgKd2DfVWqTt76x3o6JjuHnb6k5n/Hv/uBHAmJnL+ZJ9HxYmM1ChECxPrhnXBuEXfh27CguLsiAQ577UE5qOzCtyozio1wZ+jlCLZ+epMYLUzMeTjJ7wevxoekzd84hIyhSsgc2jis2OqJHKBF4R0PxwMKePMxX2ZPqSfeOYp4rsiTzHIuH1uoPBOaQu7f7+OVpkf89QCQh6Ts1HbqAWYYIopEC8SiCWPjBSfPMX07YdtGj5KwJ7L+1fTsH/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UxVaQMx+lv0ITeN6nkEB0ETAt3MqVsfGx9fx5K+EEsI=; b=fVK+HPkcE6aZpp+KzIHXZGCwAfCjhnZloCdazJ9QJalQqARRwo/eF0+NG3UxfBPOvpnTwD5IxJEeiz9Ir2V6Np8mylyavEAIDA0ts0mQ2PAxo5QHEFT+6/lnNmYAC+HWyZtb1Gseew8xHABl4qzubOvNMbPgdvue95VQspKpK881NsMbeHloSVszVqqUiyfFzoCRMIGXXivGuwYOROKTjVBxnxHXEIXpF25HrQ35GlHe3+JoIhAuQxORLeJPkm3JzhEDPN9NtH5lcvMdvod66wov70Vm87H4XMPvAJPdTLWP+iQohHD3H7gMFUKKuHLBD6833p9JdXMgIujcwrF2zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxVaQMx+lv0ITeN6nkEB0ETAt3MqVsfGx9fx5K+EEsI=; b=kxOKGmNg0HquXaA4lCTOVzCccMmWyyR8jB6kenwYapgW0GWe9MtF6ZilrW4Qf+P1qXm446GHiCOPaethJlDz2cXBGp1uoXVBTOFzZRPHtbJNUPegs0HIc0ICjRC3BllGS7qD2WdlfLdn2X+R5zhy9rQQz0zw4JOOjVD6RNSjrX4= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Topic: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Index: AQHYXtGbLw8lUArxPEOQFl634Avmjq0NftKAgADToQCAAAuUAIAH/dMAgAAGbICAAAULAA== Date: Mon, 9 May 2022 10:49:38 +0000 Message-ID: <3E6AFDF4-A55B-4C7C-ADFB-A451C478661C@arm.com> References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> <0ac6d6c0-4f34-ad1e-c473-2278dd7289c9@xen.org> In-Reply-To: <0ac6d6c0-4f34-ad1e-c473-2278dd7289c9@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d953eeb3-585b-4693-b361-08da31a9a2e6 x-ms-traffictypediagnostic: HE1PR0801MB2058:EE_|DBAEUR03FT010:EE_|GV1PR08MB8033:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9FFdhTB0kH2X21Xc3VJX7lJlpsYGw7EhbNDnt5gBoeWeManw93jySUVQxfSq6Bn/gVo91qNx6SwiYNtZlhLEi7C78RQa4ha4TYkOlR8ZIk/kvJDA5Xg6fBaguJQHIn5Aij/Xe/T8rLIqN9KgA6+Vr0J/Wn7LXLv/YflghqWPzPMxEhdLyCg3syksKZvvhA24JoX5Udik+SepVqRzsGsLHq9Qvgbr4seTnXZVr7m65FjjATL0TRUG1eJp2n7cuZH2tcl9nyeSrviyq3X9/UzoLWC5+JlD2mG9kK/JUN1qHXbnCpw9n55oaNRhYmbZBHIZF1NWMbUNPtP52AE0EV+hRzeblNkwW5R1jA8jSwjvfuwj6KLfNc84OkP4pk8e8MDcrzf8V9QVJY/p+hOZEPgZkd9H3Mv4UyhqSSsx2iELzK6/aUQ4MVH0D0SyqM5h3dFstNev/8FtIGrAlMea/OfDyQPk5y6pwZ7gtCBOtBwRpUUsYT0IDX9QgY1eZMvfpLnELQiVdGwLHOK7kVWjEduFzNoIUtJiUNk6D2L6CPJWUbtKzIcu0gOYRRYAPOF35LCKGVnwkMfVBhPM1jUX6oa3O4+rmxp27hjMvdxS+m8DugIXpSa9JqS9TJwIV07Q7L+Ak16qt2F5Lw3cspxOYYNiw5vOG9Kbp8ftPZMJA925AXB/2r//locC+4R/gzz51USBwxVJKhx0mQ3gmgLJCed1nap4uWXZWbx9zVp6mStFlfNp1aML5JeAIC6Vjt1ZJV9u X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(316002)(38070700005)(2616005)(86362001)(38100700002)(26005)(53546011)(4326008)(5660300002)(6486002)(186003)(6506007)(71200400001)(8936002)(36756003)(91956017)(508600001)(64756008)(2906002)(33656002)(76116006)(66556008)(66446008)(66946007)(66476007)(54906003)(83380400001)(6916009)(8676002)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <076F3F001CC9E145B50DFC372D383FEE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2058 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dc09accc-3736-4dbf-7e21-08da31a99d79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 18mTVnRTBtW4/KfhBzft/xs7OUsQgLDjjTvF30EerdnoFBVfLHnjYs1BLhytjvikRkrgruhJ5PXIxGJGo+HfCWEy9ymFg7ISAwbCVWsK9vM4wesxhCH0W7raZsWD5i/Rkr6+NN8hMGOtrWgBeQtzjsJKeMh5KSk0Pvp0KcIx/1P4gzizj4jgeEq6K+nDi+516ibsrQSwK5tLu6lhPGVMh7xkx69xkqxxGSxoaIdKAUeRkgFSXJfZef8I/To08smaFfpJbCGk8pFlE9Cb/Hl4oi+lowk4ZFx7QYS/t9CdF9vH5pGxC5vx2cYx72Dxs6kfmwftk6DjE4z46b+1nmn8EEMLEzmUp97L0TCZaDBUtxtjpLB2ITQ3NNH06EehgHk3ZvNCBZnYgX0plAQOpCeTjjKJ4JYITds1JnAzRvadpVRTPh9GfMjYfAesXGZngU3YcFx/JP5g9fe3bZ2a/eCAsa8QKZ5OQ0gKz9h/hrVE2ND5KMnAZkGe++ugPc5x/xAE+78lmbDz+FZq1RKAr1UcmP1VrFEpCow40N33PrZ+pOtJl1Bj9Mjw1V39PunmAgRtnOyLo3Fpt1HA9bOLTCjKyYmivneptqPGHmk6TKez+ayHQao5K8OuQKV9rfC9atWxX1FozBDGsXTjZlYouGezD5J2MxyhqyRVZACX9V3g+ZWfTa78s8r75+dXGNM5FNFL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(186003)(83380400001)(33656002)(36860700001)(26005)(107886003)(2616005)(2906002)(6512007)(36756003)(336012)(82310400005)(47076005)(40460700003)(6486002)(356005)(86362001)(5660300002)(8936002)(70206006)(54906003)(70586007)(8676002)(6862004)(81166007)(4326008)(6506007)(53546011)(316002)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 10:49:47.8452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d953eeb3-585b-4693-b361-08da31a9a2e6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8033 SGkgSnVsaWVuLCwNCg0KPiBPbiA5IE1heSAyMDIyLCBhdCAxMTozMSwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDA5LzA1LzIwMjIgMTE6MDgs IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSwNCj4gDQo+ Pj4gT24gNCBNYXkgMjAyMiwgYXQgMDk6MDYsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ IHdyb3RlOg0KPj4+IA0KPj4+IA0KPj4+IA0KPj4+IE9uIDA0LzA1LzIwMjIgMDg6MjQsIEJlcnRy YW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEhpIEp1bGllbiwNCj4+PiANCj4+PiBIaSBCZXJ0cmFu ZCwNCj4+PiANCj4+Pj4+IE9uIDMgTWF5IDIwMjIsIGF0IDE5OjQ3LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+PiBBIG5ldyBjcHVlcnJhdGEgY2FwYWJpbGl0eSBp cyBpbnRyb2R1Y2VkIHRvIGVuYWJsZSB0aGUgYWx0ZXJuYXRpdmUNCj4+Pj4+IA0KPj4+Pj4gJ3Ni JyBpcyBkZWZpbml0ZWx5IG5vdCBhbiBlcnJhdHVtLiBFcnJhdGEgYXJlIGZvciBzdHVmZiB0aGF0 IGFyZSBtZWFudCB0byBiZSBzcGVjaWZpYyB0byBvbmUgKG9yIG11bHRpcGxlKSBDUFUgYW5kIHRo ZXkgYXJlIG5vdCBwYXJ0IG9mIHRoZSBhcmNoaXRlY3R1cmUuDQo+Pj4+PiANCj4+Pj4+IFRoaXMg aXMgdGhlIGZpcnN0IHRpbWUgd2UgaW50cm9kdWNlIGEgZmVhdHVyZSBpbiBYZW4uIFNvIHdlIG5l ZWQgdG8gYWRkIGEgbmV3IGFycmF5IGluIGNwdWZlYXR1cmUuYyB0aGF0IHdpbGwgY292ZXIgJ1NC JyBmb3Igbm93LiBJbiBmdXR1cmUgd2UgY291bGQgYWRkIGZlYXR1cmUgbGlrZSBwb2ludGVyIGF1 dGgsIExTRSBhdG9taWNzLi4uDQo+Pj4+IEkgYW0gbm90IHF1aXRlIHN1cmUgd2h5IHlvdSB3b3Vs ZCB3YW50IHRvIGRvIHRoYXQuDQo+Pj4+IFVzaW5nIHRoZSBzYiBpbnN0cnVjdGlvbiBpcyBkZWZp bml0ZWx5IHNvbWV0aGluZyB0byBkbyB0byBzb2x2ZSBlcnJhdGFzLCBpZiBhIENQVSBpcyBub3Qg aW1wYWN0ZWQgYnkgdGhvc2UgZXJyYXRhcywgd2h5IHdvdWxkIHlvdSB3YW50IHRvIHVzZSB0aGlz ID8NCj4+PiANCj4+PiBJIGFncmVlIHRoYXQgU0IgaXMgdXNlZCB0byBzb2x2ZSBlcnJhdGEgYnV0 IHRoZSBpbnN0cnVjdGlvbiBpdHNlbGYgaXMgbm90IGEgd29ya2Fyb3VuZCAoaXQgbWF5IGJlIHBh cnQgb2YgaXQgdGhvdWdoKS4gSW5zdGVhZCwgdGhpcyBpcyBhIG1vcmUgZWZmaWNpZW50IHdheSB0 byBwcmV2ZW50IHNwZWN1bGF0aW9uIGFuZCB3aWxsIHJlcGxhY2UgZHNiL2lzYi4NCj4+PiANCj4+ PiBTcGVjdWxhdGlvbiBpcyBuZXZlciBnb2luZyB0byBkaXNhcHBlYXIgZnJvbSBwcm9jZXNzb3Iu IFNvLCBpbiB0aGUgZnV0dXJlLCB0aGVyZSBtaWdodCBiZSB2YWxpZCByZWFzb24gZm9yIHVzIHRv IHNheSAiV2UgZG9uJ3Qgd2FudCB0aGUgcHJvY2Vzc29yIHRvIHNwZWN1bGF0ZSIuIFRoaXMgd291 bGQgbWVhbiB1c2luZyBTQi4NCj4+IElmIHRoZSBuZWVkIGFyaXNlIHRoZW4gd2Ugd2lsbCBjaGVj ayBkZXBlbmRpbmcgb24gdGhhdCBob3cgd2UgY2FuIHN1cHBvcnQgaXQgYnV0IGluIHRoZSBjdXJy ZW50IHN0YXR1cyBhcyB0aGVyZSBpcyBubyB1c2UgY2FzZSBJIGRvbuKAmXQgdGhpbmsgd2UgbmVl ZCB0aGF0Lg0KPiANCj4gSXQgaXMgbm90IGNsZWFyIGhvdyBJIHNob3VsZCByZWFkIHRoaXMgYW5z d2VyLi4uIElmIHlvdSBhZGQgU0IgaW4gY3B1ZXJyYXRhLmMsIHRoZW4gYSB1c2VyIHdpbGwgc3Rh cnQgdG8gc2VlIG1lc3NhZ2UgbGlrZToNCj4gDQo+ICJlbmFibGVkIHdvcmthcm91bmQgZm9yIFNw ZWN1bGF0aW9uIEJhcnJpZXIiLg0KPiANCj4gV2hpY2ggaXMgY29tcGxldGVseSBib2d1cy4gUmVw bGFjaW5nICJkc2I7IGlzYiIgd2l0aCAic2IiIGlzIG1vc3RseSBhbiBvcHRpbWl6YXRpb24gYW5k IG5vbmUgb2YgdGhlIGN1cnJlbnQgdXNlIHdpbGwgZW5kIHVwIHRvIGJlIGFyY2hpdGVjdHVyYWx5 IGV4ZWN1dGVkLg0KDQpTbyB1bHRpbWF0ZWx5IHNvbWV0aGluZyBsaWtlIHRoaXMgaXMgd2hhdCB5 b3UgYXJlIGxvb2tpbmcgZm9yID8NCg0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9jcHVlcnJh dGEuYyBiL3hlbi9hcmNoL2FybS9jcHVlcnJhdGEuYw0KaW5kZXggZTc0NGFiZTgwMC4uN2MzZTUx NDFhNiAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL2FybS9jcHVlcnJhdGEuYw0KKysrIGIveGVuL2Fy Y2gvYXJtL2NwdWVycmF0YS5jDQpAQCAtNjgxLDkgKzY4MSwxMiBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGFybV9jcHVfY2FwYWJpbGl0aWVzIGFybV9lcnJhdGFbXSA9IHsNCiAgICAgICAgIC5jYXBh YmlsaXR5ID0gQVJNNjRfV09SS0FST1VORF9BVF9TUEVDVUxBVEUsDQogICAgICAgICBNSURSX0FM TF9WRVJTSU9OUyhNSURSX0NPUlRFWF9BNTUpLA0KICAgICB9LA0KK307DQorDQorc3RhdGljIGNv bnN0IHN0cnVjdCBhcm1fY3B1X2NhcGFiaWxpdGllcyBhcm1fZmVhdHVyZXNbXSA9IHsNCiAjaWZk ZWYgQ09ORklHX0FSTV82NA0KICAgICB7DQotICAgICAgICAuZGVzYyA9ICJTcGVjdWxhdGlvbiBi YXJyaWVyIChTQikiLA0KKyAgICAgICAgLmRlc2MgPSAiU3BlY3VsYXRpb24gYmFycmllciBpbnN0 cnVjdGlvbiAoU0IpIiwNCiAgICAgICAgIC5jYXBhYmlsaXR5ID0gQVJNNjRfSEFTX1NCLA0KICAg ICAgICAgLm1hdGNoZXMgPSBoYXNfc2JfaW5zdHJ1Y3Rpb24sDQogICAgIH0sDQpAQCAtNjk0LDYg KzY5Nyw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXJtX2NwdV9jYXBhYmlsaXRpZXMgYXJtX2Vy cmF0YVtdID0gew0KIHZvaWQgY2hlY2tfbG9jYWxfY3B1X2VycmF0YSh2b2lkKQ0KIHsNCiAgICAg dXBkYXRlX2NwdV9jYXBhYmlsaXRpZXMoYXJtX2VycmF0YSwgImVuYWJsZWQgd29ya2Fyb3VuZCBm b3IiKTsNCisgICAgdXBkYXRlX2NwdV9jYXBhYmlsaXRpZXMoYXJtX2ZlYXR1cmVzLCAiZW5hYmxl ZCBzdXBwb3J0IGZvciIpOw0KIH0NCg0KPiANCj4gSSBhcHByZWNpYXRlIHRoaXMgaXMgbW9yZSB3 b3JrIHRvIGFkZCBjcHVmZWF0dXJlLmMuIEhvd2V2ZXIsIEFGQUlLLCB0aGVyZSBhcmUgbm8gcnVz aCB0byBnZXQgdGhpcyBvcHRpbWl6YXRpb24gaW4gKHNlZSB3aHkgYWJvdmUpIGFuZCBtdWRkeSAo ZXZlbiB0ZW1wb3JhcmlseSkgdGhlIGxvZ3MuDQoNClRoZSB1cHBlciBJIGFtIG9rIHRvIGRvIGJ1 dCBpZiB3ZSB3YW50IHRvIGRlc2lnbiBzb21ldGhpbmcgbmV3IHRvIGhhbmRsZSBwb3NzaWJsZSBm ZWF0dXJlcyBhbmQgbW92ZSB0aGlzIHRvIGNwdWZlYXR1cmUsIHdlIHdpbGwgbmVlZCB0byBzdGVw IGJhY2sgYW5kIGNoZWNrIG1vcmUgcG9zc2libGUgdXNlIGNhc2VzIGFuZCBob3cgd2Ugd2FudCB0 byBoYW5kbGUgdGhlbS4NCg0KVGhpcyBpcyB0aGUgcGFydCB3aGljaCBJIGRvIG5vdCB3YW50IHRv IGhhbmRsZSBpbiB0aGlzIHNlcmllLg0KUG9pbnQgaGVyZSBpcyB0byBlbmFibGUgdGhlIHVzZSBv ZiB0aGUgcHJvcGVyIGluc3RydWN0aW9uIHdoZW4gcG9zc2libGUgb24gbmV3IHByb2Nlc3NvcnMg KG5hbWVseSBOZW92ZXJzZSBOMiBhdCB0aGUgbW9tZW50KS4NCg0KSXMgZG9pbmcgaXQgbGlrZSB0 aGlzIChtYXliZSB3aXRoIGEgVE9ETyB0byBzYXkgdGhhdCB0aGlzIHNob3VsZCBiZSBtb3ZlZCB0 byBjcHVmZWF0dXJlKSBvayBmb3IgeW91ID8NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiBD aGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon May 09 11:08:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324396.546413 (Exim 4.92) (envelope-from ) id 1no1FX-0001dR-JR; Mon, 09 May 2022 11:08:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324396.546413; Mon, 09 May 2022 11:08:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1FX-0001dK-Fq; Mon, 09 May 2022 11:08:23 +0000 Received: by outflank-mailman (input) for mailman id 324396; Mon, 09 May 2022 11:08:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1FW-0001dE-73 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 11:08:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1FV-0003Q8-Sm; Mon, 09 May 2022 11:08:21 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no1FV-00062d-Mg; Mon, 09 May 2022 11:08:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jUQCt3/EQTlW/N6YMxfHB2s6esNnhj05x2VWRTuu0jc=; b=R7UuBsLR76vAryHeGx0mU5fs96 bBdCmS8EJLJTRL/RS04aWEtvKovhJmP80fMiBy76zxR5zr8zDxOjf32Mc61l5kq+0TGSXZI6+AlGt New4ScfXJkCJTdFDx3TW3lOuBhjRm3WEr4xERqOOLCeHUJUBapsmAQjbeJU4JwpbV/Dc=; Message-ID: <1a80d099-6fe4-377b-c3b1-a08c7d8f59cf@xen.org> Date: Mon, 9 May 2022 12:08:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> <0ac6d6c0-4f34-ad1e-c473-2278dd7289c9@xen.org> <3E6AFDF4-A55B-4C7C-ADFB-A451C478661C@arm.com> From: Julien Grall In-Reply-To: <3E6AFDF4-A55B-4C7C-ADFB-A451C478661C@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 09/05/2022 11:49, Bertrand Marquis wrote: >> On 9 May 2022, at 11:31, Julien Grall wrote: >> On 09/05/2022 11:08, Bertrand Marquis wrote: >>>> On 4 May 2022, at 09:06, Julien Grall wrote: >>>> >>>> >>>> >>>> On 04/05/2022 08:24, Bertrand Marquis wrote: >>>>> Hi Julien, >>>> >>>> Hi Bertrand, >>>> >>>>>> On 3 May 2022, at 19:47, Julien Grall wrote: >>>>>>> A new cpuerrata capability is introduced to enable the alternative >>>>>> >>>>>> 'sb' is definitely not an erratum. Errata are for stuff that are meant to be specific to one (or multiple) CPU and they are not part of the architecture. >>>>>> >>>>>> This is the first time we introduce a feature in Xen. So we need to add a new array in cpufeature.c that will cover 'SB' for now. In future we could add feature like pointer auth, LSE atomics... >>>>> I am not quite sure why you would want to do that. >>>>> Using the sb instruction is definitely something to do to solve erratas, if a CPU is not impacted by those erratas, why would you want to use this ? >>>> >>>> I agree that SB is used to solve errata but the instruction itself is not a workaround (it may be part of it though). Instead, this is a more efficient way to prevent speculation and will replace dsb/isb. >>>> >>>> Speculation is never going to disappear from processor. So, in the future, there might be valid reason for us to say "We don't want the processor to speculate". This would mean using SB. >>> If the need arise then we will check depending on that how we can support it but in the current status as there is no use case I don’t think we need that. >> >> It is not clear how I should read this answer... If you add SB in cpuerrata.c, then a user will start to see message like: >> >> "enabled workaround for Speculation Barrier". >> >> Which is completely bogus. Replacing "dsb; isb" with "sb" is mostly an optimization and none of the current use will end up to be architecturaly executed. > > So ultimately something like this is what you are looking for ? > > diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c > index e744abe800..7c3e5141a6 100644 > --- a/xen/arch/arm/cpuerrata.c > +++ b/xen/arch/arm/cpuerrata.c > @@ -681,9 +681,12 @@ static const struct arm_cpu_capabilities arm_errata[] = { > .capability = ARM64_WORKAROUND_AT_SPECULATE, > MIDR_ALL_VERSIONS(MIDR_CORTEX_A55), > }, > +}; > + > +static const struct arm_cpu_capabilities arm_features[] = { > #ifdef CONFIG_ARM_64 > { > - .desc = "Speculation barrier (SB)", > + .desc = "Speculation barrier instruction (SB)", > .capability = ARM64_HAS_SB, > .matches = has_sb_instruction, > }, > @@ -694,6 +697,7 @@ static const struct arm_cpu_capabilities arm_errata[] = { > void check_local_cpu_errata(void) > { > update_cpu_capabilities(arm_errata, "enabled workaround for"); > + update_cpu_capabilities(arm_features, "enabled support for"); > } What I am looking for is two separate arrays: one for workaround and the other for features. Something like (untested): diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index a58965f7b9bf..54c10751dba8 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -70,6 +70,20 @@ void __init enable_cpu_capabilities(const struct arm_cpu_capabilities *caps) } } +static const struct arm_cpu_capabilities arm_features[] = { + /* XXX: Add SB */ + {}, +}; + +void check_local_cpu_features(void) +{ + update_cpu_capabilities(arm_features, "enabled support for"); +} + +void __init enable_cpu_features(void) +{ + enable_cpu_capabilities(arm_features); +} + /* * Run through the enabled capabilities and enable() them on the calling CPU. * If enabling of any capability fails the error is returned. After enabling a diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed48a..c2cd442844df 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -951,6 +951,7 @@ void __init start_xen(unsigned long boot_phys_offset, * (called from smp_init_cpus()). */ check_local_cpu_errata(); + check_local_cpu_features(); init_xen_time(); @@ -1021,6 +1022,7 @@ void __init start_xen(unsigned long boot_phys_offset, */ apply_alternatives_all(); enable_errata_workarounds(); + enable_cpu_features(); /* Create initial domain 0. */ if ( !is_dom0less_mode() ) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 7bfd0a73a7d2..d6b8c598df98 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -383,6 +383,7 @@ void start_secondary(void) local_abort_enable(); check_local_cpu_errata(); + check_local_cpu_features(); printk(XENLOG_DEBUG "CPU %u booted.\n", smp_processor_id()); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 11:21:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:21:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324402.546424 (Exim 4.92) (envelope-from ) id 1no1Rq-0003xP-Nf; Mon, 09 May 2022 11:21:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324402.546424; Mon, 09 May 2022 11:21:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Rq-0003xI-K3; Mon, 09 May 2022 11:21:06 +0000 Received: by outflank-mailman (input) for mailman id 324402; Mon, 09 May 2022 11:21:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Rp-0003x8-GE; Mon, 09 May 2022 11:21:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Rp-0003dx-Dp; Mon, 09 May 2022 11:21:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Rp-0000j2-1b; Mon, 09 May 2022 11:21:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no1Rp-0000jV-1B; Mon, 09 May 2022 11:21:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NO9rVkrg1VdL/GADTiuEikJvkzVflcJEiXpC61S3iLw=; b=4/Ad8dFd3f2YiyraWFcnyqh9VF 12NSg9gc2dSIS9A/s24d8Z4W0SpOLm/05txt5kx5DLs+buqFGKgnrNkPH8s88pNDpfLQIMQdZGL0A sOIPZxxAFhrB475UNfDfPtY2BGgHq85bq9xkiA1eb01Awj0fe0yXWnpuTV04hybkSzNA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170266: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=29ae55a0b8194fef2e769f2882297aa601b4777a X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 11:21:05 +0000 flight 170266 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170266/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 29ae55a0b8194fef2e769f2882297aa601b4777a baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 891 attempts Testing same since 170259 2022-05-09 03:12:13 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6163 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 11:24:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:24:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324410.546435 (Exim 4.92) (envelope-from ) id 1no1Uv-0004gJ-5v; Mon, 09 May 2022 11:24:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324410.546435; Mon, 09 May 2022 11:24:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Uv-0004gC-2v; Mon, 09 May 2022 11:24:17 +0000 Received: by outflank-mailman (input) for mailman id 324410; Mon, 09 May 2022 11:24:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1Ut-0004g1-N7 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 11:24:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d473b9e-cf8a-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 13:24:14 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 07:23:52 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB2423.namprd03.prod.outlook.com (2603:10b6:903:37::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 11:23:48 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 11:23:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d473b9e-cf8a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652095454; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=a1Y3cAQS2t6zZFi8Z0xsPVz00QSCNCZX6hQtaxPLchs=; b=WWlgHJ5picqE8Nvgpz1dpzFY73zWSvktHUnCGsj9FU4bMOp0VFcDDGV3 uGsmXOp2GjnW7QWn4MmpzIos+tmxImD9OgBPQmLh8WuOXx17krcAHNaz7 l+rIipoI/XYg1M6pZi87G9ZDe66hcLGxk1cmaIwyeJuNHAPWP4w56zj+e A=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 73361340 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CQom3asC+0hDRaIkDdf2Z2hywOfnVFxfMUV32f8akzHdYApBsoF/q tZmKTuCO/7YZGD3eIhza9nj8kgH68XWndVmSFZp+C08Qn9H+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17V6 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8yJ6rWxsgAViVGUAV+NOpGv7DcJnag5Jn7I03uKxMAwt1IJWRvZMgz3b8yBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IGmm5v2KiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3O/vRuuDSLpOB3+Oi8d96FJdiJfPdIrEuSn FPi1T3lXChPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pEM FAd8Ccqqak09WSoQ8P7Uhn+p2SL1jYEUsdUO/037keK0KW8yx+UA3VBQjNfZdgOssgwSjo3k FiTkLvU6SdHtbSUTTeW8e6SpDbrYCwNdzZdO2kDUBcP5MTlrMcrlBXTQ91/EamzyNroBTX3x DPMpy8771kOsfM2O2yA1Qivq1qRSlLhEGbZOi2/srqZ0z5E IronPort-HdrOrdr: A9a23:CEDAp6PZmBFKZMBcT13155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2c6YRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv4EvoxKhNNKWs2N 60Q5iAtIs+OvP+PpgNc9vof6OMexzwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="73361340" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hDhtDFtvtCntXY50n+O6h0RqxcYerV8+MP2fn/i9reVVCjN9A4YkVr0TOQ/x8f0+L7ABvz5CcgDx/KTNm13p1J/upjnrcKYG2z4DEcrJgWCGK3W74MHGAW35HLktF39gkYjB+rDVQ0zajepqvlVHUhffi4CnY+kMIXpalopX/sR7QeGHI0ODNukVghnj/ZIctThaUtoW6gDQiN4mDdO+djpkPLRkn7l2kc3N2uZ6/j+x6dvAHTLSUiofQ2LNaOm3CxVUKPawMQ7xDTfB2Hsfz5cigD4zVIwwWoSFtFrJWqa88o28t96FW8/JKBwZxPZSYzQKAgOI5l6wGSQ4ZHdDVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VffK7Rx0PzdI8/ZOYnCDg0VcwYzuxbAC5a3rXo9jS8E=; b=gWqszc9NQ7Yrj/8FH6R+ToefXaCEtAp/Dm6DiO3t1jb+mdfqXOiqyAPbhNeO1QkrpMsuOeLOMsYxOdsIsc+53p894UIVDuDHjQIye+tmA/yuhGeoKDWSOgVYfd3EkF5FMJREOCC5XkM841P5PYhfH4jZcxkPqYGAp4WSIES+RP5DhZIOmPcfkeZ4Dd789FBKn2refpNqizBeMsagJKvmnZD9IhzvRxSDmaqXMA/Z54tX/ffb8BWkc1ijUlbTf4lB/NDqxZFrTJbsqDi0qYGosaayy4XYT/Y/651eJc2NgjTo6Qd868xugZpNRxAsKn2WXTobzLN65DNBi48YPAWZ6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VffK7Rx0PzdI8/ZOYnCDg0VcwYzuxbAC5a3rXo9jS8E=; b=Ng0prWXpAcWdkOBhzVWIMyzGTMS+dV0OAsSj8oy51hCNMc+CACmD+a1bMwrIt4kFah65qj2sSevOx9ugwgM5LwTAed087OR5LKv5YVl88w34Nfmmmpdapvgdw3aCLXltE6twYEOwqufhI/YN4XOOE3X40gz0pG3bv3jES7LEWoM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 13:23:44 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ross Lagerwall Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Anthony Perard , Paul Durrant , "qemu-devel@nongnu.org" Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones Message-ID: References: <20220427163812.2461718-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0428.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8328b8b-73e2-45dc-619e-08da31ae6317 X-MS-TrafficTypeDiagnostic: CY4PR03MB2423:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /TOxkwH3BFNDiGi7ZxhTZvDAfB/U5Q3Qdq+W21Qpklgtr8EVLF02unjkLmyrXScz9Ngzjnf3iNtr4ceG2VsKmu09RzmOm4LFMh+s5x3kc2t29WxeEtnv+JWp6/vdOW7I2cGOCsGIICB5MQ3bJh4ZWuSCcoz+ssQ4Jaz4x8sjkBMfHX8naQfhrlIT0oNcNBPJvux+FYJ1FtRb/6H2smHv79op9WRdMj8QKsWSVyI4jkC0F/jWRLBLVne3Yehyd+wR6Itz6LO6RRHh9Ri9uN1VypFz5aXPRLlSonDsfgnkaKCYi4iJEMhvNa9wozTrpYG1+FSMis/zdw66Opr6DSMnNhUguxjEL1XpnPtXcj43aVJFpQzZ4Slay26rR86vKb5VcjIbeqWmmmMyQCaAjenI9ME0ta6Xeu2a+GSIw8OpCGFQrg0dAcwJUiT7vhdLL7qlSrnpVdnV4NqTv+TVffeLgVJhM5Fq7/uBrcV1RbV8A1BxeHw6/BqApXU+3jKivjyNrXtOVqqKFxajSviLxQiB4yFS6gTtfXII5eotEqUNlqdKCf80gcEqJFL80GYRcQncnoeXhKRqeaG/G+PG2yOfGM6w6w+Xfcznc/aYfg1qDnziby6Zh96C2U//DQU6pe8tMrc44/fgw/q3Vaq4rH3K1g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6636002)(85182001)(83380400001)(82960400001)(33716001)(53546011)(8676002)(6862004)(4326008)(66476007)(66946007)(66556008)(54906003)(38100700002)(8936002)(6512007)(9686003)(6486002)(316002)(26005)(508600001)(2906002)(5660300002)(6506007)(186003)(6666004)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGJ2Z0ZwQVJhMnl0UEcyNlIzTWdZOW1ueExkYlhkWXdReDM1OW1xRk5tMHho?= =?utf-8?B?bmVURWFsWG5VKzI0NERuZGJMdE5HRFBqc0NmdHY3NktuMUQ3YmhXVVA5WUJp?= =?utf-8?B?aWkvN1pSU2tROVlNd253aFdsRVdiRFJCcTc1L0hqcmZSeTltbE1DelJjYTUz?= =?utf-8?B?ZUkrb09XSTZKY0FJYll0WkN3VUtxNmtQS0VlRE5RWFF2UTJ0M2FZSEtqaHFr?= =?utf-8?B?eTVPOW9rOEJ3azQwUWhmc3NKOE1tSG1RVzdvNkF6YmdkR1hrWElzVm5xbDdY?= =?utf-8?B?eTZGMkdaZzhRbHB6V0dBOUdIZW03cTBNeVFxd1MzSThSaHIyekJYS3lNV2Vr?= =?utf-8?B?QUttRTBGZkR2ZGlHRkVzelRsSVZ3YWNVbGFlZXI2d2gwTkQyckNPeFFJTjVE?= =?utf-8?B?YW80Q0dYTEI3cDJDazEyZUxYd01JZDNxNWVjOFFmL0greWxqV1hQSm9KSmw5?= =?utf-8?B?dHVkdHlkOEpSWnpGSTJVLzFqOW5CR2FXc3hkOFNrcGh2YmR5L1BDaGZKeGhp?= =?utf-8?B?UjRGaTJkNmcwb2tZcmU1QlRIY2tFUVE5UjFxWFRxU01pWGpvYS9lY2QwaThP?= =?utf-8?B?Rzc2a3R3NFdrSWsyVnB2YjVwSmNpTDZPYmlPQUtRMmcvQm1Jc25aK3QxN3BQ?= =?utf-8?B?RFd1aG9CbE9oVEtqNzlKdVpmbUh5L0EzbERvd1VLU0NramZSUldDd2wxVFNV?= =?utf-8?B?bCtIMm5UTzRDNmMxbnJDNmdYdWtFbHUweVBlbXYzNVNya2t2MlpzR0pIMzBo?= =?utf-8?B?TTZ2Q0VXM29uK0hVcENhVW9kZUY5bnNZWW10eDZjSVlaWGNmcUZQVXpRYnds?= =?utf-8?B?dVhUbWI1YlcrdEVtWkNYNTJDYTRKWUJCVjBrNis0dG9YaFA5MzMrbHdQZldJ?= =?utf-8?B?WTNtYTllTWdmWlNMdVdELzBIUWlpNmw4R29wQXRKcjNrVSt4bXRWeU1Sb3Bl?= =?utf-8?B?YmtnYW9xNm1tOVM3L29MT2JSY0JlTUE5UjFRRmZDWlB2bGVjQ09hbXMrYklt?= =?utf-8?B?dHUrcVFNamVDOW0xdmpFK0E5NThQSnRRcnZFKzBGaUZUV0pxVDFQVnN4eGIy?= =?utf-8?B?d055ZWJmWEcwR0NQdlpqckdmV0xOMVRUUGpuS3M0VVhSQWVSRjhzUlY0R1c5?= =?utf-8?B?MFhqOTJHVTNmTjc5VkZFWmVCWW5mcHMrMUNoZlM1ZEgvY0ZWVk1HdnF2YTVy?= =?utf-8?B?ejRxalQyYkg5QVBZa0M2aWRubE12UlpmcDVhdTBjc2tUaUNhMDJkY0phOURr?= =?utf-8?B?TS9mcUZ3MmwzNW03WlpicGF6MVV1ZXBNTStRY0wvMitYa3Z5QkR0eVplMWYv?= =?utf-8?B?aFdJTDZDWVVOemNFNjU3SUpBTDRueTlxM3dFK09WRmpodG1lUDlsRFpNelNY?= =?utf-8?B?aXN0dXJXZFpjdEk2SnpQQUhERUJxSy9zcjZmQml4U2R6TUFGaERBZlBocmpD?= =?utf-8?B?NjQwKzdTSUZhSG1BdjhPQlB5TmlLOGIyNDk1aVFTRElTSXYrbjJydGlXRjBE?= =?utf-8?B?bDRlajJKajhFK05yRytGUWt4RlRZanhUY25yWXRtdmI5M2JOakpWRzBGaFBZ?= =?utf-8?B?VkNDbUVnSXBzTCt1QXlvTU1yaHpabGZjT2E1U3VUTlMyQU0zQk1pTFE4bTlm?= =?utf-8?B?TWQ5WE90WGZUcEZSdWxQaHJHSExXY05SYzN2TXlHZUdYbjhoWlV4c1RUOVkv?= =?utf-8?B?MXlaVUtidGY1NVhxQkpWZFZDb3hocUpyQldhRFEzU3QrWXpJOWJVaEloQUFV?= =?utf-8?B?OGpaald5Z25ZWjVVSFo4dForM28wMmhKcjhtVG1xdkxFTVRXZjJRdE84U2NL?= =?utf-8?B?WFZvRVRmUk5VOHRTWUxWTkV4ZzZ6WW1vQytua1djTU5tMU9vTGh0VHZHNEFR?= =?utf-8?B?NGtqM3FzRS9KQUdQQVgrVzBnTFg0TmR3bWFPaUN5NFdldG5WUnl1eForRXhE?= =?utf-8?B?em5WUWRzTGRqZ3hhaUd3M2FJaitlbVFHQXNaNW1HUVRXMXhjKzl1ejZ5a0Jv?= =?utf-8?B?WjNSOElPWjlxWVNrL0c1Wjd5RE1penNHZ3EyKzAwRVB6L1RQSGRRNG5KWmh0?= =?utf-8?B?ekF0OWdWRWI1cnY4ZEpNOEhxdDBzTWhOMDdWYUxHWDNIZDFJZ1djV1UzOWda?= =?utf-8?B?WmFML2RhNCsvM2ZXL2tFMy84eWpHdHhOQ2tYRm1xTUhDY1RLOVpCZjBnNllR?= =?utf-8?B?Rk9aUXltN1NTblYvUXlvZWNER20xUDdqV3NlWG5YNVVlcnRCS1hUR2x3bU5t?= =?utf-8?B?Y0pYUVBNRFV3T2J1elBBT1dEOEUyNnlnYjFFcnhVS3dMYjV4ZjJKbG9RNjBM?= =?utf-8?B?dHdrbUpjaDlHT0k1cjViSG5PNmxPYUpGN080QjJCc1VMTGpsYUxUZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8328b8b-73e2-45dc-619e-08da31ae6317 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 11:23:48.4924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jRVydQ39htpoGiyWgi7E5aFew7BzGlqjJKR28qToYZQPGUSAcuk6OYHszrj7w4D52rfz6CfcuRnumi614tnLCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2423 On Mon, May 09, 2022 at 10:39:32AM +0000, Ross Lagerwall wrote: > > From: Roger Pau Monne > > Sent: Monday, May 9, 2022 10:28 AM > > To: Ross Lagerwall > > Cc: xen-devel@lists.xenproject.org ; Stefano Stabellini ; Anthony Perard ; Paul Durrant ; qemu-devel@nongnu.org > > Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones > > > > On Wed, Apr 27, 2022 at 05:38:12PM +0100, Ross Lagerwall via wrote: > > > The BAR emulated register definition does not set emu_mask because it > > > varies depending on bar_flag. If emu_mask is not set, then the BAR is > > > initialized based on the host value which causes the BAR to be initially > > > mapped at whatever value the host device was using. Although it does > > > eventually get mapped at the correct location, it causes unnecessary > > > mapping/unmappings. > > > > Would it be possible to just unset the memory decoding bit in the > > command register if it's set? > > I don't think that would be sufficient since AFAICT qemu does not read that > bit so will still call into Xen to update memory mappings, etc. Hm, but this seems wrong? QEMU should not set memory mappings if the memory decoding bit is unset. While the bit will be set for the underlying physical device, it shouldn't be set in the emulated command register provided to the guest, and hence no mappings should be established until that bit is set by the guest. In the description you mention not using the host BAR positions, which is fine, but you also need to prevent mappings from being created until the guest has positioned the BARs and enabled the memory decoding bit, or else you end up positioning the BARs wrongly has QEMU has no knowledge of where should BARs reside. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 11:36:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324418.546445 (Exim 4.92) (envelope-from ) id 1no1gH-0006JE-Bq; Mon, 09 May 2022 11:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324418.546445; Mon, 09 May 2022 11:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1gH-0006J7-92; Mon, 09 May 2022 11:36:01 +0000 Received: by outflank-mailman (input) for mailman id 324418; Mon, 09 May 2022 11:36:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1gF-0006Ix-UW; Mon, 09 May 2022 11:35:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1gF-0003t4-KD; Mon, 09 May 2022 11:35:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1gF-00019h-53; Mon, 09 May 2022 11:35:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no1gF-0000jK-4a; Mon, 09 May 2022 11:35:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lhF6bWKySazdYJnbM4MShhLpwwU7fpZAwGS4YkuFMO8=; b=GX/SfmXi0EyiHcH6GVNbwkUF+b 4MuKO8M/0ffSIzx7IpmtuBgh6Y/Y6EceICGsXv+AaAwugeLyHQpLZVkQ0+228Zzc1h5JKQxbsgh/J /r1lXociw9nsuDduccFuEKO6rmZJT3DlfZ3J1Qxe1WI04W4r9tbQm1TNu26AB468KRRc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170257: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-raw::broken:regression xen-unstable:test-arm64-arm64-libvirt-raw:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b7e0d8978810b534725e94a321736496928f00a5 X-Osstest-Versions-That: xen=b7e0d8978810b534725e94a321736496928f00a5 From: osstest service owner Date: Mon, 09 May 2022 11:35:59 +0000 flight 170257 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170257/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw broken Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 5 host-install(5) broken pass in 170232 test-amd64-i386-examine-uefi 6 xen-install fail in 170232 pass in 170257 test-amd64-i386-libvirt-raw 7 xen-install fail in 170232 pass in 170257 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 170232 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 170232 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 170232 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170232 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170232 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170232 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170232 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170232 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170232 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170232 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170232 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170232 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170232 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170232 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170232 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen b7e0d8978810b534725e94a321736496928f00a5 baseline version: xen b7e0d8978810b534725e94a321736496928f00a5 Last test of basis 170257 2022-05-09 01:53:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw broken test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-arm64-arm64-libvirt-raw broken broken-step test-arm64-arm64-libvirt-raw host-install(5) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 09 11:40:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:40:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324426.546457 (Exim 4.92) (envelope-from ) id 1no1l2-0007hg-0G; Mon, 09 May 2022 11:40:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324426.546457; Mon, 09 May 2022 11:40:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1l1-0007hZ-Tc; Mon, 09 May 2022 11:40:55 +0000 Received: by outflank-mailman (input) for mailman id 324426; Mon, 09 May 2022 11:40:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1l0-0007hT-8G for xen-devel@lists.xenproject.org; Mon, 09 May 2022 11:40:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0e::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e16cb939-cf8c-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 13:40:53 +0200 (CEST) Received: from AS9PR06CA0245.eurprd06.prod.outlook.com (2603:10a6:20b:45f::13) by DBBPR08MB4505.eurprd08.prod.outlook.com (2603:10a6:10:cf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 11:40:50 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::9b) by AS9PR06CA0245.outlook.office365.com (2603:10a6:20b:45f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Mon, 9 May 2022 11:40:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 11:40:49 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Mon, 09 May 2022 11:40:49 +0000 Received: from 2b216b7fe393.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D6E0D1CA-B36C-4A28-BBA9-4413DECFB67E.1; Mon, 09 May 2022 11:40:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b216b7fe393.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 11:40:43 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB2671.eurprd08.prod.outlook.com (2603:10a6:802:1d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Mon, 9 May 2022 11:40:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 11:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e16cb939-cf8c-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GwnC2NFp62oPunkYlk5HzwEbaw1Pi6HfJYY9u5o2Dk4qvibN2hqDG1NYRPzSVQXdwzQS5zvl1T4LL9zxVm8eJVYdfplqonhUmOzJf0JNXqSzqVegoitC0u/wJNiczsTTE6i+EjO/BgSnfIWCQWGQV29JCdBwkasxcrKXH7YimkliS8SxbLH72kn1tuJo83a645w0UNgyKkwGJv/tHxip/KorAmKVeG0VUwI7+zusnbuE/lJ4x6kivlP0bgxfMk9i6/yZmvTo0Ph1UtqH5+9Jiy/3z/4Mwnv+FDZc0ggmp9iFrxhUIEmrBk+O+WhU4ahP86EsIRtKNXc2/2sjzgz/5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Msn3m+DRMQj53msMoJYzgRF0YR3qtSOqc2blhVCClx8=; b=S/mV+pJcLbbIw4ToO4ij28fxTp8q+LBiSOlj+RzkzMRn44BBDXxtuSMKZN369gHdLrAAeKMLgmS3hIFjA3/z1evzZjDhgRXlyA+1HuL2EqCddUZvfGHWsraLVmSHaLRqjrzMUybn4AXU2xg220T1phEUrIh44fgb7tbDDvDfPxOY5vgAFbJGmvOdPZ94NfFYEp2URE1fFfDgqlDocAYdO3cJAQTcPD4DBH6+RZQgzBRCq0Hbe1q80y14XkJOvjTqcytd3hPbo4D9+rmlLO2JwU/Cas9aRtPKWrvl/LkixmrVur0F27+aCa9YTve2Mz+ldxqgGgdrB3g79ruYfVMnfw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Msn3m+DRMQj53msMoJYzgRF0YR3qtSOqc2blhVCClx8=; b=ab4dxnlPQd09P9uFvyK7LRpNmrm3iVK/MmMf5vLrzPClwZzF+upOzKgXzISHR0qGob37abpYKhS5gtvLwS4jnFORjBjpRNzgT32tlBbQAmcR3jbYl1ZSkLTR75LUQGwfFQjUf9kHDpiOuxevIJCIJqg+Qbn/HjRAaVXPq+qtnOg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 857c88c09eb1e90e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJLtZAVz04LXE1VWv9WzC4E6H1E35RWhAUxPvs5C1f0wMXmppmmwVnqOD6hfMKHr8927S0+pB1EvUeMYWbDRVvRtz3rLrgUupgh9ZjPVHvdnEBzKmHD2XbPocI7rF8v0G1z/2xeN1H8qWPg8wy5TUZrYrg513cfOZDVBpHuy4g+F8a237xWkXD+zHRuO43v1Pt/D/di706UgWBK1/ie++VYVXDCIzUYQtXGPs1pZJgWM8Mtd5qj3rJrxqW8XUVAo/exKjfFfEbI4TTQRxa8YbyiBy4cFHRpabEgQyWyeRamcPp7nuUvjeKnqxV8aPDbA4cY9dPmpal7ATAaq2b9TKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Msn3m+DRMQj53msMoJYzgRF0YR3qtSOqc2blhVCClx8=; b=TIfr6EAWepaYj7stvsPOn5xNsd2wIeh1AAmBLY8gjLA2peJ7HwpYTyFuHIzs46tNTKj/WPMfKB3bveCWX+HSa8qunYZBwcMMH3XUTTB0NslRekHpQVQMbisqezaKYKk94FkHTdsnm7LY5t6KfxQcLL7HgYztk5WFgoCmASzebPCCB2RmCqk7xjT4QJZUjVQEv0Cdn54qFN5P9jWgArwbezTL9yPkcFmsbQ2hfz7HaBGrBRZoxbx9HF0tDCw6/Fgw1tK7rH38jnsPEFKBIObRKEoeD/xs+SGtSe6U36PwrYSyIewjbhl+5lx6ylhu3a8U8p/M/6r6iSVsuLaecbwxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Msn3m+DRMQj53msMoJYzgRF0YR3qtSOqc2blhVCClx8=; b=ab4dxnlPQd09P9uFvyK7LRpNmrm3iVK/MmMf5vLrzPClwZzF+upOzKgXzISHR0qGob37abpYKhS5gtvLwS4jnFORjBjpRNzgT32tlBbQAmcR3jbYl1ZSkLTR75LUQGwfFQjUf9kHDpiOuxevIJCIJqg+Qbn/HjRAaVXPq+qtnOg= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Topic: [PATCH 3/3] xen/arm: Add sb instruction support Thread-Index: AQHYXtGbLw8lUArxPEOQFl634Avmjq0NftKAgADToQCAAAuUAIAH/dMAgAAGbICAAAULAIAABToAgAAJA4A= Date: Mon, 9 May 2022 11:40:35 +0000 Message-ID: <2229A6CD-5B04-46F4-BAAC-56C1F3C55DFD@arm.com> References: <24fd2364294345f103cb13bdab2ad0b706681071.1651570561.git.bertrand.marquis@arm.com> <6571ead7-ff94-acb5-1e55-53ae69944bf0@xen.org> <15DEAB6E-3130-49E8-87BD-AC82C08C7698@arm.com> <0ac6d6c0-4f34-ad1e-c473-2278dd7289c9@xen.org> <3E6AFDF4-A55B-4C7C-ADFB-A451C478661C@arm.com> <1a80d099-6fe4-377b-c3b1-a08c7d8f59cf@xen.org> In-Reply-To: <1a80d099-6fe4-377b-c3b1-a08c7d8f59cf@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b9c1a0c4-08a5-49b7-4834-08da31b0c3eb x-ms-traffictypediagnostic: VI1PR08MB2671:EE_|AM5EUR03FT061:EE_|DBBPR08MB4505:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: yZf5Fogg3n7uLCkvJ8QsaK4I96eKQh9cM/r36GlD1SFDosBro6ClkItdoyxpEuMlpeAB7xEpEAAQW6IyWlFpKDyOZsqWHbPjAcbVVh3Y+KOhifFDmeOLQfq3D5AnPMXFhxoyoid2Fzkx0TBNboYFzsZlDRsF+BgIsbierIpFb7g9VzN2p0pwbuBT4vOGkdF4/yNEXsv8iB6r4Gvd2eamFr/tqCoOjaetQu4W1Hbc1S9pANnTBR39G/497/zFG5bH+19eP+Y/hcAsEd4a3H1VJpmHv7z5qrNDp58PmWO6gVR+EhotmhL6DMe4sLCRIK8n+VrvIuJl69e7CUvcYnhqbmb1dvyAAbCIz89g1ugz1Gyjvc4rrS7ok8I/PIpo8NOiJHghIJVgL3EoTd5VtgDkgAtbZwk4cb0nr/MzwzeCrn2Bi0rIKSA0hxOB3+X9qwhES5hu3X0PQ2s2tv+oGyBlH4CFUFux8pqB4E87ZcmjS0MqSQ//yuMTr14eX7eBgNG78UdhX506DMj0574qE4RRqq6g9GdWItk5z2wnImWcFspYyMRC2jafNoebcQ2rJea8cPZ+8sC2P7y+T9DT/klkNwCs9S5unEpWTpkqZBPMPR3yGxBiMWj/vgh362F2/Skkf9g6yKP1RIUsupVJL8/KKf7Lw4cRUCbFfR728ggOIocHkH1Q/DtHZmbjRMQJD1pAaVAub+hmyxXJAXBZe3+V3DnDhiOGt2+AuiN6HIofSTV2kV2Q0TqB4svkF7xgV4656O9z2xUyDrVt0sCX1vwNqg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(186003)(316002)(2616005)(76116006)(54906003)(36756003)(33656002)(6512007)(71200400001)(26005)(508600001)(6506007)(53546011)(6486002)(4326008)(66446008)(66556008)(86362001)(8676002)(66476007)(64756008)(66946007)(83380400001)(2906002)(38070700005)(38100700002)(122000001)(5660300002)(6916009)(8936002)(21314003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2671 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81b7b004-5402-4d3e-645b-08da31b0bb6c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: henh0OwSg7XvoS/UJl2renBrRzNHzCcllJEQGpNiTqPe5EAx2DO9WIGxOw/5LSf/2aWu4SIfRSJ2FJMxHBT94WZ38RSFqiMBhkfzuLs0JcNyZG/coygAfreczqAiFkUd0e3Gax7s528DiNdDpdhLdBLNFzVlrcXc6KKo75aHpc1WIwr7qE9XxzuxxV5TKuxUKGzDYi4uYD+ROH3PE10TL4gz/4sXfZqbBs66ERqzjul5kMm0dk5r7y9lG/M/4hOH+rMkGfzWIGHNioNOgYIDg3aQykel6Fq4qI2ZUozw3CymQyoWGJa/9fD+3YYf2RLQVDrb1I+5pcqgD2MfXfxLUaQrQsPBrKaNqV+MDZ61VW7WL5BV1hQSu2B1hbJoLy7IdfbKHFlt57qeY9s6Iqtpc52edokKW2YIvVV8Mxuh+4zknrz+JfIY88cuDFhMk62+eJRBQ2Zn4KaAi9IinSYZMhPmOkuwivFryLLDyEAH0gbteok9kVLIK4/IXhKta3nic+z9rhrC3BHTrC8aW9bsjNi6VXKhh9vSvbPX0JxhbvAAbSWdzmuhoatosJqZNW0vvWvxSPs12siq4pJInapCUXBJkyOU8tWcVBaINYAAZfqHJrNZdEf46k6RPmobENEHkusBPYhb8a8g/z8WEYT/La9jU4y9k/3R6WPxwCa/ehFzr5ywqOEQKK5AkDEaIQ/3B9iDNfqZB8XKso5/zN62TQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(70206006)(6486002)(316002)(47076005)(6512007)(70586007)(508600001)(186003)(40460700003)(81166007)(86362001)(36860700001)(2906002)(4326008)(8676002)(6862004)(54906003)(336012)(26005)(82310400005)(33656002)(356005)(2616005)(8936002)(83380400001)(6506007)(107886003)(36756003)(5660300002)(53546011)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 11:40:49.6546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9c1a0c4-08a5-49b7-4834-08da31b0c3eb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4505 SGksDQoNCj4gT24gOSBNYXkgMjAyMiwgYXQgMTI6MDgsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiAwOS8wNS8yMDIyIDExOjQ5LCBCZXJ0 cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IE9uIDkgTWF5IDIwMjIsIGF0IDExOjMxLCBKdWxpZW4g R3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+PiBPbiAwOS8wNS8yMDIyIDExOjA4LCBC ZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4gT24gNCBNYXkgMjAyMiwgYXQgMDk6MDYsIEp1 bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiANCj4+Pj4+ IA0KPj4+Pj4gT24gMDQvMDUvMjAyMiAwODoyNCwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+ Pj4+PiBIaSBKdWxpZW4sDQo+Pj4+PiANCj4+Pj4+IEhpIEJlcnRyYW5kLA0KPj4+Pj4gDQo+Pj4+ Pj4+IE9uIDMgTWF5IDIwMjIsIGF0IDE5OjQ3LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3Jn PiB3cm90ZToNCj4+Pj4+Pj4+IEEgbmV3IGNwdWVycmF0YSBjYXBhYmlsaXR5IGlzIGludHJvZHVj ZWQgdG8gZW5hYmxlIHRoZSBhbHRlcm5hdGl2ZQ0KPj4+Pj4+PiANCj4+Pj4+Pj4gJ3NiJyBpcyBk ZWZpbml0ZWx5IG5vdCBhbiBlcnJhdHVtLiBFcnJhdGEgYXJlIGZvciBzdHVmZiB0aGF0IGFyZSBt ZWFudCB0byBiZSBzcGVjaWZpYyB0byBvbmUgKG9yIG11bHRpcGxlKSBDUFUgYW5kIHRoZXkgYXJl IG5vdCBwYXJ0IG9mIHRoZSBhcmNoaXRlY3R1cmUuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBUaGlzIGlz IHRoZSBmaXJzdCB0aW1lIHdlIGludHJvZHVjZSBhIGZlYXR1cmUgaW4gWGVuLiBTbyB3ZSBuZWVk IHRvIGFkZCBhIG5ldyBhcnJheSBpbiBjcHVmZWF0dXJlLmMgdGhhdCB3aWxsIGNvdmVyICdTQicg Zm9yIG5vdy4gSW4gZnV0dXJlIHdlIGNvdWxkIGFkZCBmZWF0dXJlIGxpa2UgcG9pbnRlciBhdXRo LCBMU0UgYXRvbWljcy4uLg0KPj4+Pj4+IEkgYW0gbm90IHF1aXRlIHN1cmUgd2h5IHlvdSB3b3Vs ZCB3YW50IHRvIGRvIHRoYXQuDQo+Pj4+Pj4gVXNpbmcgdGhlIHNiIGluc3RydWN0aW9uIGlzIGRl ZmluaXRlbHkgc29tZXRoaW5nIHRvIGRvIHRvIHNvbHZlIGVycmF0YXMsIGlmIGEgQ1BVIGlzIG5v dCBpbXBhY3RlZCBieSB0aG9zZSBlcnJhdGFzLCB3aHkgd291bGQgeW91IHdhbnQgdG8gdXNlIHRo aXMgPw0KPj4+Pj4gDQo+Pj4+PiBJIGFncmVlIHRoYXQgU0IgaXMgdXNlZCB0byBzb2x2ZSBlcnJh dGEgYnV0IHRoZSBpbnN0cnVjdGlvbiBpdHNlbGYgaXMgbm90IGEgd29ya2Fyb3VuZCAoaXQgbWF5 IGJlIHBhcnQgb2YgaXQgdGhvdWdoKS4gSW5zdGVhZCwgdGhpcyBpcyBhIG1vcmUgZWZmaWNpZW50 IHdheSB0byBwcmV2ZW50IHNwZWN1bGF0aW9uIGFuZCB3aWxsIHJlcGxhY2UgZHNiL2lzYi4NCj4+ Pj4+IA0KPj4+Pj4gU3BlY3VsYXRpb24gaXMgbmV2ZXIgZ29pbmcgdG8gZGlzYXBwZWFyIGZyb20g cHJvY2Vzc29yLiBTbywgaW4gdGhlIGZ1dHVyZSwgdGhlcmUgbWlnaHQgYmUgdmFsaWQgcmVhc29u IGZvciB1cyB0byBzYXkgIldlIGRvbid0IHdhbnQgdGhlIHByb2Nlc3NvciB0byBzcGVjdWxhdGUi LiBUaGlzIHdvdWxkIG1lYW4gdXNpbmcgU0IuDQo+Pj4+IElmIHRoZSBuZWVkIGFyaXNlIHRoZW4g d2Ugd2lsbCBjaGVjayBkZXBlbmRpbmcgb24gdGhhdCBob3cgd2UgY2FuIHN1cHBvcnQgaXQgYnV0 IGluIHRoZSBjdXJyZW50IHN0YXR1cyBhcyB0aGVyZSBpcyBubyB1c2UgY2FzZSBJIGRvbuKAmXQg dGhpbmsgd2UgbmVlZCB0aGF0Lg0KPj4+IA0KPj4+IEl0IGlzIG5vdCBjbGVhciBob3cgSSBzaG91 bGQgcmVhZCB0aGlzIGFuc3dlci4uLiBJZiB5b3UgYWRkIFNCIGluIGNwdWVycmF0YS5jLCB0aGVu IGEgdXNlciB3aWxsIHN0YXJ0IHRvIHNlZSBtZXNzYWdlIGxpa2U6DQo+Pj4gDQo+Pj4gImVuYWJs ZWQgd29ya2Fyb3VuZCBmb3IgU3BlY3VsYXRpb24gQmFycmllciIuDQo+Pj4gDQo+Pj4gV2hpY2gg aXMgY29tcGxldGVseSBib2d1cy4gUmVwbGFjaW5nICJkc2I7IGlzYiIgd2l0aCAic2IiIGlzIG1v c3RseSBhbiBvcHRpbWl6YXRpb24gYW5kIG5vbmUgb2YgdGhlIGN1cnJlbnQgdXNlIHdpbGwgZW5k IHVwIHRvIGJlIGFyY2hpdGVjdHVyYWx5IGV4ZWN1dGVkLg0KPj4gU28gdWx0aW1hdGVseSBzb21l dGhpbmcgbGlrZSB0aGlzIGlzIHdoYXQgeW91IGFyZSBsb29raW5nIGZvciA/DQo+PiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvYXJtL2NwdWVycmF0YS5jIGIveGVuL2FyY2gvYXJtL2NwdWVycmF0YS5j DQo+PiBpbmRleCBlNzQ0YWJlODAwLi43YzNlNTE0MWE2IDEwMDY0NA0KPj4gLS0tIGEveGVuL2Fy Y2gvYXJtL2NwdWVycmF0YS5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vY3B1ZXJyYXRhLmMNCj4+ IEBAIC02ODEsOSArNjgxLDEyIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXJtX2NwdV9jYXBhYmls aXRpZXMgYXJtX2VycmF0YVtdID0gew0KPj4gICAgICAgICAgLmNhcGFiaWxpdHkgPSBBUk02NF9X T1JLQVJPVU5EX0FUX1NQRUNVTEFURSwNCj4+ICAgICAgICAgIE1JRFJfQUxMX1ZFUlNJT05TKE1J RFJfQ09SVEVYX0E1NSksDQo+PiAgICAgIH0sDQo+PiArfTsNCj4+ICsNCj4+ICtzdGF0aWMgY29u c3Qgc3RydWN0IGFybV9jcHVfY2FwYWJpbGl0aWVzIGFybV9mZWF0dXJlc1tdID0gew0KPj4gICNp ZmRlZiBDT05GSUdfQVJNXzY0DQo+PiAgICAgIHsNCj4+IC0gICAgICAgIC5kZXNjID0gIlNwZWN1 bGF0aW9uIGJhcnJpZXIgKFNCKSIsDQo+PiArICAgICAgICAuZGVzYyA9ICJTcGVjdWxhdGlvbiBi YXJyaWVyIGluc3RydWN0aW9uIChTQikiLA0KPj4gICAgICAgICAgLmNhcGFiaWxpdHkgPSBBUk02 NF9IQVNfU0IsDQo+PiAgICAgICAgICAubWF0Y2hlcyA9IGhhc19zYl9pbnN0cnVjdGlvbiwNCj4+ ICAgICAgfSwNCj4+IEBAIC02OTQsNiArNjk3LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhcm1f Y3B1X2NhcGFiaWxpdGllcyBhcm1fZXJyYXRhW10gPSB7DQo+PiAgdm9pZCBjaGVja19sb2NhbF9j cHVfZXJyYXRhKHZvaWQpDQo+PiAgew0KPj4gICAgICB1cGRhdGVfY3B1X2NhcGFiaWxpdGllcyhh cm1fZXJyYXRhLCAiZW5hYmxlZCB3b3JrYXJvdW5kIGZvciIpOw0KPj4gKyAgICB1cGRhdGVfY3B1 X2NhcGFiaWxpdGllcyhhcm1fZmVhdHVyZXMsICJlbmFibGVkIHN1cHBvcnQgZm9yIik7DQo+PiAg fQ0KPiBXaGF0IEkgYW0gbG9va2luZyBmb3IgaXMgdHdvIHNlcGFyYXRlIGFycmF5czogb25lIGZv ciB3b3JrYXJvdW5kIGFuZCB0aGUgb3RoZXIgZm9yIGZlYXR1cmVzLiBTb21ldGhpbmcgbGlrZSAo dW50ZXN0ZWQpOg0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9jcHVmZWF0dXJlLmMg Yi94ZW4vYXJjaC9hcm0vY3B1ZmVhdHVyZS5jDQo+IGluZGV4IGE1ODk2NWY3YjliZi4uNTRjMTA3 NTFkYmE4IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vY3B1ZmVhdHVyZS5jDQo+ICsrKyBi L3hlbi9hcmNoL2FybS9jcHVmZWF0dXJlLmMNCj4gQEAgLTcwLDYgKzcwLDIwIEBAIHZvaWQgX19p bml0IGVuYWJsZV9jcHVfY2FwYWJpbGl0aWVzKGNvbnN0IHN0cnVjdCBhcm1fY3B1X2NhcGFiaWxp dGllcyAqY2FwcykNCj4gICAgIH0NCj4gfQ0KPiANCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXJt X2NwdV9jYXBhYmlsaXRpZXMgYXJtX2ZlYXR1cmVzW10gPSB7DQo+ICsgICAgLyogWFhYOiBBZGQg U0IgKi8NCj4gKyAgICB7fSwNCj4gK307DQo+ICsNCj4gK3ZvaWQgY2hlY2tfbG9jYWxfY3B1X2Zl YXR1cmVzKHZvaWQpDQo+ICt7DQo+ICsgICAgdXBkYXRlX2NwdV9jYXBhYmlsaXRpZXMoYXJtX2Zl YXR1cmVzLCAiZW5hYmxlZCBzdXBwb3J0IGZvciIpOw0KPiArfQ0KPiArDQo+ICt2b2lkIF9faW5p dCBlbmFibGVfY3B1X2ZlYXR1cmVzKHZvaWQpDQo+ICt7DQo+ICsgICAgZW5hYmxlX2NwdV9jYXBh YmlsaXRpZXMoYXJtX2ZlYXR1cmVzKTsNCj4gK30NCj4gKw0KPiAvKg0KPiAgKiBSdW4gdGhyb3Vn aCB0aGUgZW5hYmxlZCBjYXBhYmlsaXRpZXMgYW5kIGVuYWJsZSgpIHRoZW0gb24gdGhlIGNhbGxp bmcgQ1BVLg0KPiAgKiBJZiBlbmFibGluZyBvZiBhbnkgY2FwYWJpbGl0eSBmYWlscyB0aGUgZXJy b3IgaXMgcmV0dXJuZWQuIEFmdGVyIGVuYWJsaW5nIGENCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo L2FybS9zZXR1cC5jIGIveGVuL2FyY2gvYXJtL3NldHVwLmMNCj4gaW5kZXggZDVkMDc5MmVkNDhh Li5jMmNkNDQyODQ0ZGYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+ICsr KyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+IEBAIC05NTEsNiArOTUxLDcgQEAgdm9pZCBfX2lu aXQgc3RhcnRfeGVuKHVuc2lnbmVkIGxvbmcgYm9vdF9waHlzX29mZnNldCwNCj4gICAgICAqIChj YWxsZWQgZnJvbSBzbXBfaW5pdF9jcHVzKCkpLg0KPiAgICAgICovDQo+ICAgICBjaGVja19sb2Nh bF9jcHVfZXJyYXRhKCk7DQo+ICsgICAgY2hlY2tfbG9jYWxfY3B1X2ZlYXR1cmVzKCk7DQo+IA0K PiAgICAgaW5pdF94ZW5fdGltZSgpOw0KPiANCj4gQEAgLTEwMjEsNiArMTAyMiw3IEBAIHZvaWQg X19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nIGJvb3RfcGh5c19vZmZzZXQsDQo+ICAgICAg Ki8NCj4gICAgIGFwcGx5X2FsdGVybmF0aXZlc19hbGwoKTsNCj4gICAgIGVuYWJsZV9lcnJhdGFf d29ya2Fyb3VuZHMoKTsNCj4gKyAgICBlbmFibGVfY3B1X2ZlYXR1cmVzKCk7DQo+IA0KPiAgICAg LyogQ3JlYXRlIGluaXRpYWwgZG9tYWluIDAuICovDQo+ICAgICBpZiAoICFpc19kb20wbGVzc19t b2RlKCkgKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NtcGJvb3QuYyBiL3hlbi9hcmNo L2FybS9zbXBib290LmMNCj4gaW5kZXggN2JmZDBhNzNhN2QyLi5kNmI4YzU5OGRmOTggMTAwNjQ0 DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9zbXBib290LmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL3Nt cGJvb3QuYw0KPiBAQCAtMzgzLDYgKzM4Myw3IEBAIHZvaWQgc3RhcnRfc2Vjb25kYXJ5KHZvaWQp DQo+ICAgICBsb2NhbF9hYm9ydF9lbmFibGUoKTsNCj4gDQo+ICAgICBjaGVja19sb2NhbF9jcHVf ZXJyYXRhKCk7DQo+ICsgICAgY2hlY2tfbG9jYWxfY3B1X2ZlYXR1cmVzKCk7DQo+IA0KPiAgICAg cHJpbnRrKFhFTkxPR19ERUJVRyAiQ1BVICV1IGJvb3RlZC5cbiIsIHNtcF9wcm9jZXNzb3JfaWQo KSk7DQoNClRoYW5rcyBmb3IgdGhlIGNvZGUsIEkgZ2V0IHRoZSBpZGVhIGFuZCB3aWxsIGRvIHRo YXQuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1 bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Mon May 09 11:49:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 11:49:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324433.546469 (Exim 4.92) (envelope-from ) id 1no1sp-00007z-1v; Mon, 09 May 2022 11:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324433.546469; Mon, 09 May 2022 11:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1so-00007s-T7; Mon, 09 May 2022 11:48:58 +0000 Received: by outflank-mailman (input) for mailman id 324433; Mon, 09 May 2022 11:48:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no1sl-00007m-00 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 11:48:58 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff4ef892-cf8d-11ec-a406-831a346695d4; Mon, 09 May 2022 13:48:52 +0200 (CEST) Received: from [127.0.0.1] (unknown [46.183.103.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 601E71EC0529; Mon, 9 May 2022 13:48:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff4ef892-cf8d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1652096927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OBcNvdGojA+kgezS1jEjzLjyoytYIqi04DLdwTBilBk=; b=jS4tFDIHbr7C3Uu/RAAiy+WGqeZJHXRjw/EI6aNobbXRodJ0Tb4PfSNpoOHW+KbqVJeaHw cv0CqgBMT/MbupN4iHymfPvSKpYZkSx6O42ICf+XF0of+KIBHBQgjFpRjluZ0Nz7tlLUS1 0hHrdCu2/GVq2VEhhdnUoA07R5Levug= Date: Mon, 09 May 2022 13:48:44 +0200 From: Boris Petkov To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org CC: Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: Re: [PATCH v3 1/2] kernel: add platform_has() infrastructure User-Agent: K-9 Mail for Android In-Reply-To: <20220504155703.13336-2-jgross@suse.com> References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-2-jgross@suse.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On May 4, 2022 5:57:02 PM GMT+02:00, Juergen Gross wro= te: >Add a simple infrastructure for setting, resetting and querying >platform feature flags=2E > >Flags can be either global or architecture specific=2E > >Signed-off-by: Juergen Gross >--- >V2: >- rename set/reset functions to platform_[set|clear]() (Boris Petkov, > Heiko Carstens) >- move function implementations to c file (Boris Petkov) >--- > MAINTAINERS | 8 ++++++++ > include/asm-generic/Kbuild | 1 + > include/asm-generic/platform-feature=2Eh | 8 ++++++++ > include/linux/platform-feature=2Eh | 15 ++++++++++++++ > kernel/Makefile | 2 +- > kernel/platform-feature=2Ec | 27 ++++++++++++++++++++++++++ > 6 files changed, 60 insertions(+), 1 deletion(-) > create mode 100644 include/asm-generic/platform-feature=2Eh > create mode 100644 include/linux/platform-feature=2Eh > create mode 100644 kernel/platform-feature=2Ec Nice and simple, I like=2E Acked-by: Borislav Petkov --=20 Sent from a device which is good for reading mail but awful for writing=2E= Please excuse any shortcomings=2E From xen-devel-bounces@lists.xenproject.org Mon May 09 12:00:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324439.546479 (Exim 4.92) (envelope-from ) id 1no23c-0002Ux-4p; Mon, 09 May 2022 12:00:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324439.546479; Mon, 09 May 2022 12:00:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no23c-0002Uq-1r; Mon, 09 May 2022 12:00:08 +0000 Received: by outflank-mailman (input) for mailman id 324439; Mon, 09 May 2022 12:00:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no23b-0002Ub-3K for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:00:07 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90257bdc-cf8f-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:00:05 +0200 (CEST) Received: from [127.0.0.1] (unknown [46.183.103.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 56BFE1EC0529; Mon, 9 May 2022 13:59:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90257bdc-cf8f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1652097600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SZ0FUxK106JbsF1xbRYLQqCEry+KRNYRswr1LpAp2pE=; b=VxzKXdJGegayDkmVXDvQFwrNls2RPi2YfuiEOm93VxrDV7gOSr5Sr6E2eqQXUDudljUWm2 naM86eaoC/NmDPrzV3lyAs+o3FssqBbS9HxGYrGrmlxM95YCGfpfObKvrMb/fxKltUycds KZlVEiMd3cmC5Uyz/n2jiE3kMh2rc2M= Date: Mon, 09 May 2022 11:59:49 +0000 From: Boris Petkov To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org CC: Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_2/2=5D_virtio=3A_replace_arc?= =?US-ASCII?Q?h=5Fhas=5Frestricted=5Fvirtio=5Fmemory=5Faccess=28=29?= In-Reply-To: <20220504155703.13336-3-jgross@suse.com> References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-3-jgross@suse.com> Message-ID: <1376936D-E067-430C-A02D-565959F83BE0@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On May 4, 2022 3:57:03 PM UTC, Juergen Gross wrote: >Instead of using arch_has_restricted_virtio_memory_access() together >with CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, replace those >with platform_has() and a new platform feature >PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS=2E > >Signed-off-by: Juergen Gross >--- >V2: >- move setting of PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS in SEV case > to sev_setup_arch()=2E >V3: >- remove Hyper-V chunk (Michael Kelley) >- remove include virtio_config=2Eh from mem_encrypt=2Ec (Oleksandr Tyshch= enko) >- add comment for PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS (Oleksandr Tyshch= enko) >--- > arch/s390/Kconfig | 1 - > arch/s390/mm/init=2Ec | 13 +++---------- > arch/x86/Kconfig | 1 - > arch/x86/mm/mem_encrypt=2Ec | 7 ------- > arch/x86/mm/mem_encrypt_amd=2Ec | 4 ++++ > drivers/virtio/Kconfig | 6 ------ > drivers/virtio/virtio=2Ec | 5 ++--- > include/linux/platform-feature=2Eh | 6 +++++- > include/linux/virtio_config=2Eh | 9 --------- > 9 files changed, 14 insertions(+), 38 deletions(-) Acked-by: Borislav Petkov --=20 Sent from a device which is ok for reading mail but awful for writing=2E P= lease excuse any shortcomings=2E From xen-devel-bounces@lists.xenproject.org Mon May 09 12:01:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324448.546490 (Exim 4.92) (envelope-from ) id 1no24h-00034A-Fo; Mon, 09 May 2022 12:01:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324448.546490; Mon, 09 May 2022 12:01:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no24h-000343-CS; Mon, 09 May 2022 12:01:15 +0000 Received: by outflank-mailman (input) for mailman id 324448; Mon, 09 May 2022 12:01:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no24g-00033r-10; Mon, 09 May 2022 12:01:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no24f-0004Mc-Ve; Mon, 09 May 2022 12:01:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no24f-0001qO-JZ; Mon, 09 May 2022 12:01:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no24f-0007rs-J8; Mon, 09 May 2022 12:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jdLzcvmPwv+Yo9dRctTQXe4qOxJ6aROIOcbUbnVCu2Y=; b=UZfBuG/stjPC0STC1uwQbdEegN +nSCyTFyde1j3i4XFn8BX1PFauA+L2aoMWJJcqKSX6ckcp5oEyShbxVOU2W2ZryWWd4tC3asSwb5A 2GkauCBxX0NMWRMRBIy+XXVscSsWo/TEd580YnZhTD6J914h3xQe0S1h5Omm7JWDJhLQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170267: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 12:01:13 +0000 flight 170267 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170267/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 892 attempts Testing same since 170267 2022-05-09 11:41:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6180 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 12:24:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324457.546505 (Exim 4.92) (envelope-from ) id 1no2RM-0005uA-Og; Mon, 09 May 2022 12:24:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324457.546505; Mon, 09 May 2022 12:24:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RM-0005tD-JZ; Mon, 09 May 2022 12:24:40 +0000 Received: by outflank-mailman (input) for mailman id 324457; Mon, 09 May 2022 12:24:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RK-0005qB-Jq for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:24:38 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc86521b-cf92-11ec-a406-831a346695d4; Mon, 09 May 2022 14:24:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc86521b-cf92-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652099076; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fowPN6uXsJ6EOPSGQzvLCD4ytt1t0sestCDBrkvZGDo=; b=V92nxxuZINB2Qt39f4aQoYVZ8Fa0TYxq5lJodadD7pKnmC1taIjl1abb ZERkSCFyhvWMJ8yxHeqVfZu4rU2aDK09ok9bz0sEiV9hap4kW5wkG2avy 9q+0M1IQExpJYpTEtGMPbdrA9oT7ICSQHBdrQCco6Kg8xyabT+CCcrs42 w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71286218 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:il8wza9A/Lr4jLAj7EdTDrUDSX6TJUtcMsCJ2f8bNWPcYEJGY0x3x 2RNDW2OOf6DZWOmf4x2PoWzoU8HuZbVztZiQAU9/CE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IDoW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZizGBoiBLadpNscVjpSNxFyHY9I1KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O JNDOWQ1NUSojxtnH1c5NM9grMmSl0b0TyFIo0+tr4oa/D2GpOB2+Oe0a4eEEjCQfu1Xg0KZq 2Tu72n/RBYAO7S39z2B9X69g/7VqgnyUokSCb6Q++ZjhRuYwWl7IBcbT0ehqP+1zEu3QctCK lc88zAr66M18SSDUd3VTxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv nertd70AT1ksJWOVGmQsLyTqFuaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5e/LWd14OvX2uqm nbT8XZ41+57YdM3O7uT+VOWnjmWvcn1cQ8wxQ/zbm6FzA1Ve9vwD2C30mTz4fFFJYefa1COu nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yT7Fb289g2SM6uA3iwsXTbyK HHetgpKjHO4FCv7NPQnC25d5ilD8EQBKTgHfq2PBjatSsIoHONiwM2JTRTJt10BaGB2zckC1 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGMqjkk/2iefBPiH9pVI53LymNLtR0U95iF+Nr 4Y32zWilX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul lngCxQw4Aeu2hX6xfCiNykLhEXHBs4v8xrW/EUEYD6V5pTUSdvxvPpHK8trLNHKNoVLlJZJc hXMQO3Yatwnd9gN0251gUXVxGC6SCmWuA== IronPort-HdrOrdr: A9a23:qO4Onq3J0GhCuD/pohO2hwqjBL4kLtp133Aq2lEZdPRUGvb3qy nIpoV96faUskd0ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfREWndQ96U 4PScdD4aXLfDpHsfo= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="71286218" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH 0/3] xen: Trivial MISRA fixes Date: Mon, 9 May 2022 13:24:06 +0100 Message-ID: <20220509122409.14184-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Trivial fixes for MISRA issues while idly looking through the x86 report. Andrew Cooper (3): x86/p2m.h: Add include guards x86/shadow: Don't use signed bitfield in sh_emulate_ctxt common/spinlock: Drop inline from _spin_lock_cb() xen/arch/x86/mm/p2m.h | 5 +++++ xen/arch/x86/mm/shadow/private.h | 2 +- xen/common/spinlock.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon May 09 12:24:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324458.546512 (Exim 4.92) (envelope-from ) id 1no2RN-0005xK-1T; Mon, 09 May 2022 12:24:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324458.546512; Mon, 09 May 2022 12:24:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RM-0005vV-RP; Mon, 09 May 2022 12:24:40 +0000 Received: by outflank-mailman (input) for mailman id 324458; Mon, 09 May 2022 12:24:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RL-0005qB-Cm for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:24:39 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc806ad4-cf92-11ec-a406-831a346695d4; Mon, 09 May 2022 14:24:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc806ad4-cf92-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652099076; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BQHAL2/JZ7BiUyF6Ggb3MxDFFtfKott8B5+vLAiqkKM=; b=IrxhVwgaoSRLRJlxtcAUD2G2lfnSR7+Y3fNfwj4qrXE92pl5ObbED8Bi r7moyFY/qQY/gJxPGWs+Hya2l/nAXpiGChLcJ+EUhOqYHvGlt/UqEbHIm a7hkdksFVezwoJC8SNYxorRMSCZIufqGEC+km2lsrm0QgABqvpdHn20fA 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70895895 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:MPrh06gOIz0p/RjHJP1zqgkRX161qRAKZh0ujC45NGQN5FlHY01je htvWWqEP/vbN2qgKNxzYY3npkICv5GBzNUwGwo6rng1EyMb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvc4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTknYrLOoPUiakNzKS1MAK4dpOXkAmfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i 88xNmI/PUmQMkAn1lE/B4kUkfqahnXDLRIEtRWXpI8Hv0zpw1kkuFTqGIWMIYHbLSlPpW6au 2bH8mLREhwcctuFxlKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVG2u+Wjg0iyHddWM VUJ+zEGpLI3skesS7HVQBmQsHOC+BkGVLJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vLLzFytLyeSVqG66yZ6zi1PEA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8aIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7vvTzwuZrxXzEMvC7tUlCY7VglPq2GeNn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2VdoIiAySMnuFJSrtldXBR EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RocVCnSSXFXelM2LWaJ39zq0+HXAaYllZ f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlkk7/jOHPPCPKE+ht3L6yggcRtvjsneko2 4wHa5viJ+t3DoUSnRU7AaZMdAtXfBDX9Lj9qtBNd/7rH+aVMDpJNhMl+pt4I9YNt/0Mzo/gp yjhMmcFmQGXrSCWdm23hoVLNeqHsWBX9iprY0TB/D+AhhAeXGpYxPpBJ8ZvIel7pYSOD5dcF pE4RilJOdwXIhyvxtjXRcKVQFBKHPhzuT+zAg== IronPort-HdrOrdr: A9a23:GYvOeaCjKkr8nWXlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN 9dmsNFaeEYY2IUsS+D2njbL+od X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70895895" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH 1/3] x86/p2m.h: Add include guards Date: Mon, 9 May 2022 13:24:07 +0100 Message-ID: <20220509122409.14184-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220509122409.14184-1-andrew.cooper3@citrix.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Spotted by Eclair MISRA scanner. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- xen/arch/x86/mm/p2m.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h index cc0f6766e4df..dc706b8e4799 100644 --- a/xen/arch/x86/mm/p2m.h +++ b/xen/arch/x86/mm/p2m.h @@ -15,6 +15,9 @@ * along with this program; If not, see . */ +#ifndef __ARCH_MM_P2M_H__ +#define __ARCH_MM_P2M_H__ + struct p2m_domain *p2m_init_one(struct domain *d); void p2m_free_one(struct p2m_domain *p2m); @@ -39,6 +42,8 @@ int ept_p2m_init(struct p2m_domain *p2m); void ept_p2m_uninit(struct p2m_domain *p2m); void p2m_init_altp2m_ept(struct domain *d, unsigned int i); +#endif /* __ARCH_MM_P2M_H__ */ + /* * Local variables: * mode: C -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon May 09 12:24:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324456.546501 (Exim 4.92) (envelope-from ) id 1no2RM-0005qa-EH; Mon, 09 May 2022 12:24:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324456.546501; Mon, 09 May 2022 12:24:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RM-0005qT-AV; Mon, 09 May 2022 12:24:40 +0000 Received: by outflank-mailman (input) for mailman id 324456; Mon, 09 May 2022 12:24:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RK-0005qA-Iv for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:24:38 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc755ce5-cf92-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:24:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc755ce5-cf92-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652099076; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uq1foPJpvaO1u+wSYrV1CFyZhCk56IBZRoJ5uogU+Oo=; b=MGXZoehUnaea7hS+Wo72qck8/13+MJ6pTQuQyizYIv56qHGyfTypqHQa 6SZoxgGmazWa0XSXbf3pTlfUEKX4V3EqeRPqRYqvdcuymdzJNr87zgrTO OT+rKRiCF0rPOjZhRm+R0Jy9KcLogVjJPP84KP3vPKSf1l3nVO49BoKsz s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70874005 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:AJbh3aKqaJHA+IRnFE+RGJUlxSXFcZb7ZxGr2PjKsXjdYENSgmQGz GUZWWvSa/7cYmKjedB0borj/EwD7JfcmIcyQVFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Y52YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 P9J7ICrexclBPDJwMctTwFeFwYlbLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQq6OO JZBMWcHgBLoOy9uP1U8OrMFu+aKlD7jXB0JgmmWqv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt m/AuWPjDXkyCtubzjaU92O2scXGlyj7RYE6GaWx87hhh1j77mYeEgEMXF235/ywkFejWsl3I lYRvCEpqMAa60iDXtT7GRqirxasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQI/ FKUm9LiBRR0raaYD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXryos1LSfDvyIevQHepn m7M/HNWa6gvYdAj/aHi4Uv1kz6W+52RbT4p/gPTeTn08VYsDGK6XLCA5V/e5PdGCY+WSFido XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U03271k0NPa7y8992XyK1BFs8fMQHkb 0bI0e+6zM8CZSD6BUObjm/YNijL8UQCPYm+Phw3RoAXCnSUSONg1Hs3DXN8J0i3zCARfVgXY P93i/qEA3cAErhAxzGrXeob2rJD7nlgmDmLGMuql0n4i+X2iJuppVAtagDmUwzExPnc/FW9H yh3aaNmNCmzoMWhO3KKoOb/3HgBLGQhBICeliCkXrXrH+aSI0l4U6W56ep4I+RNxv0J/s+Vr yrVchIJlzLCaYjvdFzihoZLM+u/A/6SbBsTYEQRALpf8yV9Mdv3sPdDJvPav9APrYRe8BK9d NFdE+3oPxiFYm2vF+g1BXUlkLFfSQ== IronPort-HdrOrdr: A9a23:y82ea6N6KMpEesBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ uIGJIeNDSfNzdHZL7BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70874005" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH 2/3] x86/shadow: Don't use signed bitfield in sh_emulate_ctxt Date: Mon, 9 May 2022 13:24:08 +0100 Message-ID: <20220509122409.14184-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220509122409.14184-1-andrew.cooper3@citrix.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit 'int' bitfields in particular have implementation defined behaviour under gcc and can change signed-ness with -funsigned-bitfields. There is no need for low_bit_was_clear to be a bitfield in the first place; it is only used as a boolean. Doing so even improves the code generation in sh_emulate_map_dest() to avoid emitting a merge with structure padding. Spotted by Eclair MISRA scanner. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- xen/arch/x86/mm/shadow/private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h index 3dc024e30f20..772521b55dd3 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -827,7 +827,7 @@ struct sh_emulate_ctxt { #if (SHADOW_OPTIMIZATIONS & SHOPT_SKIP_VERIFY) /* Special case for avoiding having to verify writes: remember * whether the old value had its low bit (_PAGE_PRESENT) clear. */ - int low_bit_was_clear:1; + bool low_bit_was_clear; #endif }; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon May 09 12:24:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324459.546534 (Exim 4.92) (envelope-from ) id 1no2RO-0006WV-84; Mon, 09 May 2022 12:24:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324459.546534; Mon, 09 May 2022 12:24:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RO-0006W4-2y; Mon, 09 May 2022 12:24:42 +0000 Received: by outflank-mailman (input) for mailman id 324459; Mon, 09 May 2022 12:24:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2RM-0005qB-D3 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:24:40 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe502daa-cf92-11ec-a406-831a346695d4; Mon, 09 May 2022 14:24:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe502daa-cf92-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652099078; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pISlbMmZOOlDowYEzoDw1/7aI4xrXsrkKlI9u5f/53s=; b=OdkN+dAOvi9PJp1dC9SqMjslLHlAV+ncd0i4UxLZpdEntAtWj3jnFcQ1 SlfaYh8Afg5W5YNSG39I5lEJSXhNBfazndG27RfdmfcGD1JOurl06h4R0 i2+e7d9xUVWAad6WxMA/3yUIhPuSw1hLU+yWqN3IBWVmyDaCeNNbl6dM0 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71286219 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:bqFWmahaV9g5r/LmrDery3ZJX161qRAKZh0ujC45NGQN5FlHY01je htvCm3VMvbYa2r2ctAlYd7i8EsH7cDTnNNqTQQ9qXo3RH4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvc4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQMqb7DHov9MbyZZFgJ0GZ1K2J3JDWfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i 88xNmM1PEqaOkwn1lE/A6svmdz1vXjGSxJEuX64hvNpwHnM01kkuFTqGIWMIYHbLSlPpW6au 2bH8mLREhwcctuFxlKtzHWogePemDLhb6gbHra46/1CjUWawyoYDxh+fVG2u+Wjg0iyHddWM VUJ+zEGpLI3skesS7HVQBmQsHOC+BkGVLJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vLLzFytLyeSVqG66yZ6zi1PEA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8aIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7vhzH9u5PzVV8J2QTSfWiB3g9ZRoCJeNn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2VdoIiAySMnuFJSrtldXBR EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RocVCnSSXFXelM2LWaJ39zq0+HXAaYllZ f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlkk7/jOHPPCPKE+ht3L6yggcRtvjsneko2 4wHa5viJ+t3DoUSnRU7AaZMdAtXfBDX9Lj9qtBNd/7rH+aVMDpJNhMl+pt4I9YNt/0Mzo/gp yjhMmcFmQGXrSCWdm23hoVLNeqHsWBX9iprY0TB/D+AhhAeXGpYxPpBJ8ZvIel7pYSOD5dcF pE4RilJOdwXIhyvxtjXRcOVQFBKHPhzuT+zAg== IronPort-HdrOrdr: A9a23:b7QBUattKOmXFOeqZ4TYEYrI7skDTNV00zEX/kB9WHVpmszxra GTdZMgpGfJYVcqKQgdcL+7Scq9qB/nmqKdpLNhWYtKPzOW3ldATrsSj7cKqgeIc0aVm4JgPO VbAs9D4bXLfCNHZK3BgDVQfexP/DD+ytHMudvj X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="71286219" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH 3/3] common/spinlock: Drop inline from _spin_lock_cb() Date: Mon, 9 May 2022 13:24:09 +0100 Message-ID: <20220509122409.14184-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220509122409.14184-1-andrew.cooper3@citrix.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is undefined behaviour, because there is no _spin_lock_cb() in a separate translation unit (C11 6.7.4.11). Moreover, MISRA prohibits this construct because, in the case where it is well defined, the compiler is free to use either implementation and nothing prevents the two from being different. This function has external users, so drop the inline. Spotted by Eclair MISRA scanner. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- xen/common/spinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index 62c83aaa6a73..8cb3b316c5b1 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -159,7 +159,7 @@ static always_inline u16 observe_head(spinlock_tickets_t *t) return read_atomic(&t->head); } -void inline _spin_lock_cb(spinlock_t *lock, void (*cb)(void *), void *data) +void _spin_lock_cb(spinlock_t *lock, void (*cb)(void *), void *data) { spinlock_tickets_t tickets = SPINLOCK_TICKET_INC; LOCK_PROFILE_VAR; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon May 09 12:30:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:30:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324480.546545 (Exim 4.92) (envelope-from ) id 1no2XB-0000fL-1M; Mon, 09 May 2022 12:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324480.546545; Mon, 09 May 2022 12:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2XA-0000fE-UN; Mon, 09 May 2022 12:30:40 +0000 Received: by outflank-mailman (input) for mailman id 324480; Mon, 09 May 2022 12:30:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2X9-0000f3-0f; Mon, 09 May 2022 12:30:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2X8-0004tk-SW; Mon, 09 May 2022 12:30:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2X8-0002jI-GH; Mon, 09 May 2022 12:30:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no2X8-0001ZH-Fs; Mon, 09 May 2022 12:30:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vf2l+1qxNJHRsMdvPEnYLZSodvyvJoM8CrfVn/0SZXg=; b=yLvTeXioeZuE8gpMnofWyfhUul EB7bEXd6XYVYyqAzE1nNMuaJpOjLSSiZOvkqFhmdH1//s2IE8meYUA8LnLdY3Cn+t/bSGi3+AJsnw AxvBEde+g/S04ElIiUPuNZTX33IufzULSzVe/iQ1uJ9wHCqSikRu/HQfMy97gsUgEdJs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170268: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 12:30:38 +0000 flight 170268 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170268/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 893 attempts Testing same since 170267 2022-05-09 11:41:59 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6180 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 12:32:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324493.546556 (Exim 4.92) (envelope-from ) id 1no2Yl-0001Lq-DS; Mon, 09 May 2022 12:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324493.546556; Mon, 09 May 2022 12:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2Yl-0001Lj-9k; Mon, 09 May 2022 12:32:19 +0000 Received: by outflank-mailman (input) for mailman id 324493; Mon, 09 May 2022 12:32:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2Yj-0001Lb-Ox for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:32:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7d00::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0fbb18e6-cf94-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:32:17 +0200 (CEST) Received: from AS8P251CA0029.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::35) by AM0PR08MB3155.eurprd08.prod.outlook.com (2603:10a6:208:56::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 12:32:13 +0000 Received: from AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::87) by AS8P251CA0029.outlook.office365.com (2603:10a6:20b:2f2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Mon, 9 May 2022 12:32:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT012.mail.protection.outlook.com (10.152.16.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 12:32:13 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Mon, 09 May 2022 12:32:12 +0000 Received: from 37d1078781b9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D0269610-5B13-4E96-9873-012BC9950D72.1; Mon, 09 May 2022 12:32:06 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 37d1078781b9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 12:32:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB5488.eurprd08.prod.outlook.com (2603:10a6:803:137::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 12:32:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 12:32:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fbb18e6-cf94-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=N3T1qSrCsnviprb0jv0aumc2UVC3u2qmj6NHTYYHa0UNZuAAvKjQKABnAapKZcMKRtGDpBuGvzN62v3eL1gMzpkNexGoGOeGaDpKcIX2rCMJJ/lGl8jyG6wwNb3PzzCMOvn97bBW7WODccKAJ4+QrqPNYGBUMHwaXo0FTmAZ+kqHziHA8J2hDSPhFHyvvgoBwOSuqHQ7pqMgxtM5e9MJ7arqe/xB2Upvxwe/M0PZQpNSw5qGKx4vC4rMF1fQg4971jWTzKcQQT7b9nRppCVKvR9qIOyA65SPMztjLCYnurzFC8iKrK6cJ+XL6TREvgqm523xyzuZJ2n+oqQH0HM8rg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ypSRWaJX/Pb+aosoabiPX5Pz8E6HAGyWByGENQmagv0=; b=ItVMSeNZLCZAqLsc1zIe5Dr4o8LJxHE4NdMitCj7Fm0h/C/0Zl6Jsl3Z3vGxftGDLqVAzXzHJyoR44z3nvCNlqigCwPSX2tunvhTl0jzC0Vn0qigYS7dC9K+h6buFVubqkCb9C38ZfBB8qVxsZhLqUQUlubeN+9HsrjNflZHE1qKDeyQ7URWl5abYp6pgMTn9CNDcRBpb1BzUT8WDWMBol9tm5kUlWMLRU0deyURTgcROug8zruBDDLp9ty0k6e53wCbQCrvkkR+ufZMOidk6JTyLF/WHYs7QUs1H7I/4q4Nnfd6vOpn8YWeDgae0wTSDnA6Ht/tcwk8Y4EtyIZJCg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ypSRWaJX/Pb+aosoabiPX5Pz8E6HAGyWByGENQmagv0=; b=zjyjzetfnJ2PS6KEi8hGXte5QOlAPLlTV93oT6adr9aQ7Fuz0aEBKBvA9gASvZ4nO2Pc7pIa9V7y9RSCv2e97YzmzK+PwfWWA4wwuMsiDJVXc7qAE8cjYXZp66loXdoSM7bUsaLZCGLMl6vhmG/hudvgNbHIcnbyVNcaIogdTAQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 3c2a32fb7850638f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9JHPBCyrDIZXxYvCm0RyO9qQRsQDXI65q/R5EiNiLpohuoCZWnXkOmWpHe/1Nid+9MN2Moe6APKhszYeTlN9bURrhYdC5QdtuBbYw7QaKIen+P2ZI7EU0FQsfOb2ZsMB7Cdz7v7FZC+qofpONtA1iBiHnq8D5nogatA3IMX4Q1zaynL1dlJPxUHaShOhYAINoCrA8mn/xdXQV/LC/ww4eLNYZbEdtgdQAxnAW3F9guNXWGu7gTUJhzj0luxiOX2rZF4uZjxRJ8UDUGwasWyqbPbi455jJs1UPDXGAOFZU90mE6WyYpPPa6QL/9GWGIE1nWheIxHI2U+z1RhyY0SaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ypSRWaJX/Pb+aosoabiPX5Pz8E6HAGyWByGENQmagv0=; b=nJxsCAPjSD6vrhb4Mtfdv8fvIhNk+PmNGpQak8lGaKUoe/VRaL3UlYEHNuvVANuiy7SsWC04TofExxE3IcNu8j7mUcbG0jrKdvaNVBJcvpDgErg61m63wozYDx841Lrs//TWsAeDUGdg/Ehie8EfRGnZ8AM1lX7pxtAUSkwk55ZvzrD4jFqsZJFO3MyBiW4uLy+ERu59PvNVuJiwefdqYYwwK0eJnbrsl9EE8h9CJ1+IQEVGH0kS2X7oHqvjakE7RBHQN5RZYXcglLidiAkNl21BYnlUyBbWG+BoHTPc6aOnXMpzG55YDmK7x0/AH8VFOMSN56FnGOlnVAcCeuHKeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ypSRWaJX/Pb+aosoabiPX5Pz8E6HAGyWByGENQmagv0=; b=zjyjzetfnJ2PS6KEi8hGXte5QOlAPLlTV93oT6adr9aQ7Fuz0aEBKBvA9gASvZ4nO2Pc7pIa9V7y9RSCv2e97YzmzK+PwfWWA4wwuMsiDJVXc7qAE8cjYXZp66loXdoSM7bUsaLZCGLMl6vhmG/hudvgNbHIcnbyVNcaIogdTAQ= From: Bertrand Marquis To: Andrew Cooper CC: Xen-devel , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Thread-Topic: [PATCH 1/3] x86/p2m.h: Add include guards Thread-Index: AQHYY5/FNS5uiu9/s0usThGyJ8iSXa0WelEA Date: Mon, 9 May 2022 12:32:03 +0000 Message-ID: <12981FF7-81B0-4CA3-8FF0-D1B870F402E2@arm.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> In-Reply-To: <20220509122409.14184-2-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1b185a41-f270-4564-8a4b-08da31b7f1c7 x-ms-traffictypediagnostic: VI1PR08MB5488:EE_|AM5EUR03FT012:EE_|AM0PR08MB3155:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OWzMOXqMe9LaY2WrboXtgJfJ6HpvLWET29AXfnqhWj1q/9+z6lD3RWsYOiFSO0jEWrckogYr0gfm2Y22iDG7Uc0P95soYynoFF50EGLMX9o2qIZEFsGVlahKXlHU7bCTEWI9rR2ICshty5eAdj1IVidPm6/msr8VTm/LxE1lHYNxd0xfViEKxb8NmEf+TB8bnm0ovZXx+YMPAn9gFQ1Xg8ohWwEXPptWTKlxrsJaKr35Nzt2UPN4lNsVr1el7nUuSGG5bQnTR679i8U34ISkKmFl+Utut25ZYAE4MxItgmKY1ZuUdqhDYepu7QWSXq9bLj1Xgy9HGMxwz+2njsZXyH+LPJPpyLUM9WKiyWbVRFluVNmolbzfY5p0a4QTAu6ZFZkeTY0XxJJhnoJ5wnNTfVVNl/Z5u/tSImV65KiXuraBhrB5cPJoiHR+FpP1/AuYhLwXk8djbzE47pKQWShIU+ijYFoS22PWpKtcfs+KkgRVO2MPrZt+JFuPug36UglxYRl2ojaoaUCJ4Y2z/tdmCBt4voOyDdoC7ob0Y1BW+3yCuDyjURlJ65T1lbOfD7jF5KQuplq11lG7CBfVYUTSWgYBaUxQMALI76j4Yr6lLgkyFNZ/XYVkIcjry2IpnwCvfCjgB/270CPFZP1PtUhXUJn+ji/Nlk4HogqXtn/o5Gn/3QB18WMp4k3CH213XjIry7oIhzobew6sjITEuGPbaBbGpxeZXBkKYuaZV4yy/wdn1df7JrpirnzAzaDbIVZv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6916009)(54906003)(8936002)(86362001)(316002)(53546011)(6506007)(6486002)(5660300002)(508600001)(36756003)(71200400001)(66446008)(558084003)(33656002)(4326008)(66476007)(2906002)(38100700002)(64756008)(76116006)(38070700005)(66946007)(8676002)(186003)(26005)(122000001)(2616005)(91956017)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <55F5EC3AD510284A9F64ECD0E294738D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5488 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 235fa1a5-177c-4bb8-e763-08da31b7ec20 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WRLR4Ag7hLzzasqP34UP5RtQT8zL0Ryw28jFG2BrSUgPM1dmxW4kTobnbtEi73EHOQX7DvBSXpNuR7xlbUHLIZtc/G2NYYWNb9Tjd2Gmq2Unw5WEYLxI4+l3drOXJv3YWHMl81ktvQQpHtrcF1HjFIHy6F5HRlam2gfrHOvxvXockuodA5+1vpE05YxcgaTt67EtuTPV4P9mXuyV8bepPvu77Csw2jWhyDJV8PH6zhCAyFKAyKQbISzffgCugiL/azKtRzC4aj9+ifY2XHTMtYhWDiPBF9ZPwvtiVZwq97hd8o2fvAyXTqA/5ku/rOp2oqXhTsEh+4103E4C1w6jDi7XweyZqSYWMWEU6EKhLLajE1o1MK/GE+uXHSu4cu8/EIZ9g0IycbBUSNb5c4hWgDWGmFiYUphIe/xj/rs7w8JKn5ddzGOEFwKqf5XexRLAYFylGDnSk77p4CFYJ2sw1d6KgdDdgiMHPuG/Ulnxe67s89KN6EslVzZCTwz1BgphJFYoLQ/K2DFPiJvgWgzVbWCgGQjZ2tmTak4A7zRBaDpj5Km63mGJ7LpBiCJ9QfGb/S4OqSIAn+b+gyHLHPY66D2av+MDpgdzFhOcRH7JBQ1V2dzsf4Ekui2sCH9u7mBIIYPawzT833/kP2TkpYiYT55cseXuToNZW/kZA01JkYvHmMPAfMsunmyOHen5q2kS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(33656002)(186003)(36860700001)(107886003)(26005)(2616005)(2906002)(558084003)(6512007)(36756003)(336012)(40460700003)(47076005)(82310400005)(6486002)(356005)(86362001)(5660300002)(8936002)(70586007)(70206006)(54906003)(8676002)(6862004)(4326008)(81166007)(6506007)(53546011)(316002)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 12:32:13.0883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b185a41-f270-4564-8a4b-08da31b7f1c7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3155 Hi Andrew, > On 9 May 2022, at 13:24, Andrew Cooper wrote: >=20 > Spotted by Eclair MISRA scanner. >=20 > Signed-off-by: Andrew Cooper Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon May 09 12:34:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324499.546566 (Exim 4.92) (envelope-from ) id 1no2aR-0001y8-QV; Mon, 09 May 2022 12:34:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324499.546566; Mon, 09 May 2022 12:34:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2aR-0001y1-NC; Mon, 09 May 2022 12:34:03 +0000 Received: by outflank-mailman (input) for mailman id 324499; Mon, 09 May 2022 12:34:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2aO-0001xv-6c for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:34:02 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4be68b6a-cf94-11ec-a406-831a346695d4; Mon, 09 May 2022 14:33:58 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no2ZO-0002Vw-CD; Mon, 09 May 2022 14:32:58 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4be68b6a-cf94-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L3p0/83L4yDVyZoegOtsQfWmJV/6wtv6TZoOXChWFJg=; b=Gm1PabHNS+/VMjWNpRDgN0q7Gz okgDM+2WHp5z93ZUGeQzJtlj40ch1Djul+F9LKvzWURwbafLBOoP/NgGu9GSmPuuE28KOgN2Dlog/ GHXl8dWWFH9IUIBQmU28gspF2npPpEWaJ19eWl8SzxR3mk4Q/F4kmhrZuCV0rVMHSE4nkq5aDi9ss tskoNSlPr3h/0gKp/FmRCE42MZtPYeJf36WeID1+imZk2dUy5vrTX2Nb6oqUW3HqWx20YRVV7+Jqn 2U5xO3lqX+ogULZEqtYM74LQ/XjYNOdW70A5rw6LBK7UHwdRlT2URD08Y6BIbm5BwJqTO8MAols4i vbgjN92g==; Message-ID: Date: Mon, 9 May 2022 09:32:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 01/30] x86/crash,reboot: Avoid re-disabling VMX in all CPUs on crash/restart Content-Language: en-US To: Paolo Bonzini , Sean Christopherson , vkuznets@redhat.com Cc: kexec@lists.infradead.org, pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, will@kernel.org, "David P . Reed" References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-2-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220427224924.592546-2-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/04/2022 19:48, Guilherme G. Piccoli wrote: > In the panic path we have a list of functions to be called, the panic > notifiers - such callbacks perform various actions in the machine's > last breath, and sometimes users want them to run before kdump. We > have the parameter "crash_kexec_post_notifiers" for that. When such > parameter is used, the function "crash_smp_send_stop()" is executed > to poweroff all secondary CPUs through the NMI-shootdown mechanism; > part of this process involves disabling virtualization features in > all CPUs (except the main one). > > Now, in the emergency restart procedure we have also a way of > disabling VMX in all CPUs, using the same NMI-shootdown mechanism; > what happens though is that in case we already NMI-disabled all CPUs, > the emergency restart fails due to a second addition of the same items > in the NMI list, as per the following log output: > > sysrq: Trigger a crash > Kernel panic - not syncing: sysrq triggered crash > [...] > Rebooting in 2 seconds.. > list_add double add: new=, prev=, next=. > ------------[ cut here ]------------ > kernel BUG at lib/list_debug.c:29! > invalid opcode: 0000 [#1] PREEMPT SMP PTI > > In order to reproduce the problem, users just need to set the kernel > parameter "crash_kexec_post_notifiers" *without* kdump set in any > system with the VMX feature present. > > Since there is no benefit in re-disabling VMX in all CPUs in case > it was already done, this patch prevents that by guarding the restart > routine against doubly issuing NMIs unnecessarily. Notice we still > need to disable VMX locally in the emergency restart. > > Fixes: ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported) > Fixes: 0ee59413c967 ("x86/panic: replace smp_send_stop() with kdump friendly version in panic path") > Cc: David P. Reed > Cc: Hidehiro Kawai > Cc: Paolo Bonzini > Cc: Sean Christopherson > Signed-off-by: Guilherme G. Piccoli > --- > arch/x86/include/asm/cpu.h | 1 + > arch/x86/kernel/crash.c | 8 ++++---- > arch/x86/kernel/reboot.c | 14 ++++++++++++-- > 3 files changed, 17 insertions(+), 6 deletions(-) > Hi Paolo / Sean / Vitaly, sorry for the ping. But do you think this fix is OK from the VMX point-of-view? I'd like to send a V2 of this set soon, so any review here is highly appreciated! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 09 12:34:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324504.546578 (Exim 4.92) (envelope-from ) id 1no2b2-0002VU-3D; Mon, 09 May 2022 12:34:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324504.546578; Mon, 09 May 2022 12:34:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2b2-0002VM-0D; Mon, 09 May 2022 12:34:40 +0000 Received: by outflank-mailman (input) for mailman id 324504; Mon, 09 May 2022 12:34:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2b0-0002Ja-Ng for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:34:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0604.outbound.protection.outlook.com [2a01:111:f400:fe02::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63a2262e-cf94-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:34:38 +0200 (CEST) Received: from AM0PR04CA0104.eurprd04.prod.outlook.com (2603:10a6:208:be::45) by DB7PR08MB3001.eurprd08.prod.outlook.com (2603:10a6:5:23::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 12:34:35 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:be:cafe::f5) by AM0PR04CA0104.outlook.office365.com (2603:10a6:208:be::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Mon, 9 May 2022 12:34:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 12:34:34 +0000 Received: ("Tessian outbound 62985e3c34b6:v118"); Mon, 09 May 2022 12:34:34 +0000 Received: from 5cc2941eca59.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E30F407-528B-4A77-91C6-66432A985CBD.1; Mon, 09 May 2022 12:34:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5cc2941eca59.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 12:34:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3718.eurprd08.prod.outlook.com (2603:10a6:20b:81::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 12:34:25 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 12:34:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63a2262e-cf94-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dDwKZ6UWDbmVV5IJv2anZ+KHkre23ViMUSN4ETgK38Sz10INpSEhD80/u26tsTX3tbwCXK88DM/zjeoxdiO0ronPvA+0O1AZCzXtf+c2CchNAsf4UTD4xG2OoXMtdEfsB3jnVhYswl3vzKQpFBYkvl+Jz8qWo1uLNI87liVm6TubXFQT5DvUCYtN2guixLpWNvkvmbMC2gzYyzcf3Ef0KZhuy9kzt/E2HSvz36dTm7Pr8kM65gj5bWpn2ifwknytLCltlk+JGbqciCQw6xd3Qqn7CslQenDXzKpKKy9anpOGy3gQ/+bOjQxI3jXRf/heN4ZNQnNPf4XuUL3D1oQgIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=we7cYj+zv6onSLWc1euP+JGCeVSw8yIc2+ETd7AdoFk=; b=RmlkOe41i+i1qghWLExrk8gbf6m8QxiLLy0thKzeSqS263JNX5rZ+uakQJzispGvlAYLlH6efH9C8E8Mip6FlPhLQ89BmLRosFGPkkEmIyMEoTNzqRDM9GRvRU7UQo9AeeUwZEkkDXE9uC/OP8aoCIIZ2Y/lAD8UV/T+MwAToKO7Pf3Nt/iVxk9z4ayfaMQ1vzHR8QaQsapVy+JKMR8SfDB8ISQEV1116qR/3Z/wV31vSLllmTBdbqCfbRzaHOONKTZQN3uP8CLWeHXm9UFrCVJv6MECOrqq7zEF6dLmJJBYDNyDVLGkruBlLErrwU2Qtg2VBrfyWIpF1JxEfrgGmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=we7cYj+zv6onSLWc1euP+JGCeVSw8yIc2+ETd7AdoFk=; b=2Iu+Bbxxa/lrSU1uEkx4EwCnSwKThFFAogWXt2xqv5AgQw4xkWWlQ3N6e2YbDYs5HDii5IBchTyFh6xmhHELV84ma4BLOQS5/WfmG3YjrUfXCMXaV4rwfOs6dbL4PQhFTmV9AP58yV7HJt034nNbgbSLAzHAH4vzsDT6yx07hM8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8e06dda47a7405a9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cgs8++dEF7JJ8dfFcHcIUI7piw6CzjLXqYi0jbJxkWsWj8aGg97xZ7+Cpe1rUFC0MJ6KkXaQzoTPWQZwJkK/KQtysdsNThKlfYqwkOgwK8mpwDckrocGpSTbBPKzFfifaOjadwSGSwPrxDI9hz1/CFFvMw9lA5dsgIgR0YY/Kmmmu0qabDDzn43aS68AwnLtKAkPq6vKMPE1I6Dyrs30DpmyFIknLvt69+eM5JVkpFmjUGVNdAn7iMTxN32UVwLU4s57d6HHJ8U7Gv+bMiKT1g7EwBuoHPowHyUZ1OcjwFDMUmgxNZMWawADJw5/h3kV6u9XbUn8Y2kKFP4e9dJmiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=we7cYj+zv6onSLWc1euP+JGCeVSw8yIc2+ETd7AdoFk=; b=B65DuZgOY6UEm8TNoPS8C3MLv6CnYXUaPtBH2iN0vC2v9ZLBtXdtv6UjYtEJPieMu+fVlvIdsIaoGpYfamda7pQmqopx0rAfFzBMCd4iEyjspotHKF0BIsa0XDpWkFYoR6l1QgPcY4Pg52sPbjs4Salf9nPndLXS/OF+42X0LhPhgDtxnzULDN24Yq33OqFNIVEfQJemXTH+ZilR/wEMeddoJNBNdiIux2XLv5vj67OEX1UhWKCObP87xBc5aHf2xuDPp6rY7Vgg0xU44Iv5Rz/St3ZZ2xnoEwOYGfd6w67lJ0BYzpNG1cVexNL2iPQBULsMdXy1EivVLzwcnQG7fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=we7cYj+zv6onSLWc1euP+JGCeVSw8yIc2+ETd7AdoFk=; b=2Iu+Bbxxa/lrSU1uEkx4EwCnSwKThFFAogWXt2xqv5AgQw4xkWWlQ3N6e2YbDYs5HDii5IBchTyFh6xmhHELV84ma4BLOQS5/WfmG3YjrUfXCMXaV4rwfOs6dbL4PQhFTmV9AP58yV7HJt034nNbgbSLAzHAH4vzsDT6yx07hM8= From: Bertrand Marquis To: Andrew Cooper CC: Xen-devel , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 3/3] common/spinlock: Drop inline from _spin_lock_cb() Thread-Topic: [PATCH 3/3] common/spinlock: Drop inline from _spin_lock_cb() Thread-Index: AQHYY5/GrhlUL/nSv0SXN7TEruaNTq0WevsA Date: Mon, 9 May 2022 12:34:25 +0000 Message-ID: <02D177BE-0299-4D32-9A21-2CDCE24006AB@arm.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-4-andrew.cooper3@citrix.com> In-Reply-To: <20220509122409.14184-4-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: eea6169c-4de0-4557-6d45-08da31b84625 x-ms-traffictypediagnostic: AM6PR08MB3718:EE_|AM5EUR03FT030:EE_|DB7PR08MB3001:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KVvYIqPdgkuVya4tnLxjEWcLSjjiP/PG5zTnaYQWPS7OWHuPBO7xt2b3iPHuYLtXuMjqwk2Up5+8d4BkkzySFL4okQ4rJsow9PoP9xQCSlg/TMgr+EOgghKaI8FQDHUnxBpp/pYiKkhjJk/iCLz7++M9yOuSwTBGE8mfYZDH9Kzu57hfOmJe4m7YN7tX7Opu8L8Snh7r/FUP4yhLBT24ep2vM+SwChNLcLH/q4FIl4vJo0ViCNg/v23J/e39/JQVNXYtBO8wsuq56JQm77fJXpsIorL1/ujrvrLeoUi9JO24I82cOw8E3QXh/Gq/IVhUXGTWpTz+Cx/Nsjcw5ZJRkFaBVNH3CaDWCMdhTiv542p4EdJQXym/MUnSn0qjE1yqlmS3FEU+BrH4KgpkotKxCKzJGi/JYXIc55AXGh/XQ1MyukzBFADtKmC3vD+bckN9Jqz2ei1FhH/eU+NGHQJ/I8JBZhSYrUkoSqe/yzcfUFt0W3xPxINeGPRmKjpSCAseIS/l6YNlVNhfQFKydYJwnkaYq6VQiIkuZIELJRtAnVJRtrBymW5nTDdqzXZPpBiotS/Cb9zO35FaA2mjHw6IJlp0ZR0Zz8CSmWQyPS4fZND5PBmjHxTJ4QeTEHIZZ0dA9FHBsmSAm2MXRo10yMkINuOu7ziR1Oj3iGc/RFh4thQId8Xud/enM0PHX7/ZqyQkyW9WPgPCuAoeZ3OPv+4/Fddq87fEe8m36f594bLm72VWDlURJCVlzTdZdk3HPiYA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6916009)(508600001)(5660300002)(38070700005)(33656002)(38100700002)(8936002)(76116006)(91956017)(66556008)(54906003)(66446008)(64756008)(66476007)(186003)(36756003)(66946007)(26005)(4744005)(6512007)(2616005)(86362001)(8676002)(4326008)(122000001)(2906002)(83380400001)(6486002)(6506007)(53546011)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3718 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d5d3df5c-6119-4165-3009-08da31b840e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: efZqLVM35lZOmoKa65LcFwN/cExYV9NidOPwVIY5hhPnmBjw2SgBJjEWuxIuVGxBuVyje0mFyAkCz/oBPVnlf+3i2fNXyotA2kgydCIIb+7W8d4Hgv9bMyMvr9VbWxp8eprKZLdM4AMHVRlhd6oe8TonRvOD6wj/x2zATAYXDBksUJQDDlQK2wCUTUIcN91LgrMpYcEsnF0kQo4vKvZiXbA2lU75AjnI31W9sMEraUDIU+QZVuDhWASB2DnoaZxRo3YyKA4o7MwvYiodK6YwBOBDGaIv7IzjSVHiOxH0ji4khU3zURNIg4ppXrBT5tJo7GeAyHPnUbXG3KtIZMZBYUabKFoEJLNx9+TzM8vFnHzqdYk5JZsID67IMj0iPXXKK6NqyB5xeff9J2FyQrjOdpDRL5gAUaKwmh5RbUxcXJek2fNtvyXdTixT+iut4bIfJZBIufDXVqwP1IkgyAuJCqwl/xpNzDaa6QYtEMlhGxd+mOPavzKbHwrV2NBfX1XjBBG28FgSKm6nLIXmvriRGsZPI0Rm9AeFxjxcyflE5KKHvHzW5oCs/BIwzk2Rx5NyJd8LQbjiwDLBh3PrSCS/UFpkTWKd38uaTePY7RHoTf3VR5EvmWB9pYv2xXn4d9EiwWxzQeYJcMDnVGxzr0P5LVwgItJuq1tMsydtyqZSq69tny8bvobId5EpHUvOEhOH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(5660300002)(6512007)(53546011)(6506007)(54906003)(26005)(8936002)(36756003)(356005)(2906002)(186003)(47076005)(336012)(107886003)(82310400005)(4744005)(83380400001)(36860700001)(6486002)(33656002)(508600001)(4326008)(70206006)(70586007)(86362001)(316002)(2616005)(8676002)(81166007)(6862004)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 12:34:34.6322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eea6169c-4de0-4557-6d45-08da31b84625 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3001 Hi Andrew, > On 9 May 2022, at 13:24, Andrew Cooper wrote: >=20 > This is undefined behaviour, because there is no _spin_lock_cb() in a sep= arate > translation unit (C11 6.7.4.11). >=20 > Moreover, MISRA prohibits this construct because, in the case where it is= well > defined, the compiler is free to use either implementation and nothing > prevents the two from being different. >=20 > This function has external users, so drop the inline. >=20 > Spotted by Eclair MISRA scanner. >=20 > Signed-off-by: Andrew Cooper Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon May 09 12:41:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:41:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324512.546589 (Exim 4.92) (envelope-from ) id 1no2h4-00041i-Tr; Mon, 09 May 2022 12:40:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324512.546589; Mon, 09 May 2022 12:40:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2h4-00041b-Qi; Mon, 09 May 2022 12:40:54 +0000 Received: by outflank-mailman (input) for mailman id 324512; Mon, 09 May 2022 12:40:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2h3-00041V-03 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:40:53 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0605.outbound.protection.outlook.com [2a01:111:f400:fe06::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4218766f-cf95-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:40:51 +0200 (CEST) Received: from DB6PR07CA0011.eurprd07.prod.outlook.com (2603:10a6:6:2d::21) by VI1PR08MB2703.eurprd08.prod.outlook.com (2603:10a6:802:25::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 12:40:46 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::83) by DB6PR07CA0011.outlook.office365.com (2603:10a6:6:2d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Mon, 9 May 2022 12:40:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Mon, 9 May 2022 12:40:45 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Mon, 09 May 2022 12:40:45 +0000 Received: from 08004081d201.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 344F47BC-7D6B-404A-92CD-5363E948F5E2.1; Mon, 09 May 2022 12:40:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 08004081d201.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 May 2022 12:40:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR0802MB2287.eurprd08.prod.outlook.com (2603:10a6:800:9d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 12:40:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Mon, 9 May 2022 12:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4218766f-cf95-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=neqWhOWh4YVFDay/iyWb6YMr8ElK62YSGWeq93gmXshjsl63lEMoM3ZitxOBRz0krcF20ES48zCA+KE5faNCQfvlZhd6jgTF4Crcujq0HWj1vhMlIUhWF+ZxF5kRCFGUWBRLfDWf9aTzgiIa9Dxe2jJ2bk38Gsiie9sxkdk9ADhlxevK2WI5zcXqDg6RNklveewVOSPbYYXYPlSVQMBdn0HjNzrvIeSz1om2qgotB15SjpF1RxIizMO+gwhkeVkY5PFCCe6Z6GrdS+k+F3Ljwv0GMRS+iZwVI5lbTrPiU79mp1+Hbd9E9dNo7/xc1TiW4nIl9oX05U6h5zcgUqZ6cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xp2I61m9Euis7KFkFoxjtRVQDm4E+k2+RKCuqZHlTXI=; b=C0JGkslR1RjHOPyz6AoFcZzzCaKUTzfWgK5o6R9/RYaMFsASOsXuwJdeQ4XXtUSdU/UXb11HdqjLpQivwO39mOcYsykN8ZmDzOiozrWB7brCn6jQwpD3WsWqe9XyFjckyrvB7PaXaAQnR6hKKEhoJtf0OgV7nZqqngTN/CJkQDHtxpPJ1CQrrVY3Z1hBnGZs+MMFwqta+CIuUDqQEe2LnKzuc5XCeekSPNnHSs5fw4x3K/PjO2cRacymXk+FSLR511+HsJ0DFj/uxHxGgACZbRupjgLFhiFGLNCQc3T/lShN5iU/jIFuKgRyj5ABCphgYRTm6jqK0LjSB+oQteY97Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xp2I61m9Euis7KFkFoxjtRVQDm4E+k2+RKCuqZHlTXI=; b=TsJsbFD5VB2RUxnuwQ7H30O3X+7a/uutxb4QS7B3jwh8whY2cR2YMsFm4KVjIRDqF0ElEar/Ep3O4yFTSFumYjyvW9V9ny7z1am33vd3LpZTrMdEbJFa20Q/7FxcegrQaEb28Yz8UyqrMZrIJ1d2Ncp1WwM9T7MDEod61FIsGyc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a74bf73c8547bf1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kd/k1BWb62fFgP6GSTX7B3eH7QWlKo0Jn1ULUZD2AfaiRzDlNiSwLs3yxSNYx3ZERvTPM26+NSfPBCqsWoiAzm2kSowTP6CuqthGuUkRxcvIpLRUn1gd8EKQVMNAOL7oHt5KCi+PkiddR6i14u5aG1M3v9tharQn5r1W8zYlec6zxPb732ewGwneO0EnRKYtM1Z2mRzfyNECb4hKQobTQWydV02ZQR2blqvsjAhba27ymp4SS+1k1icLw3k37KOOfljxdGdzWtVimpMCrxjPDEkRe3X3LVwMMJ1XIeVnpzrk1JU3mFQttplr7UhfgP/sLo0JUbFGYtr+JoNG94tojg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xp2I61m9Euis7KFkFoxjtRVQDm4E+k2+RKCuqZHlTXI=; b=IfbuLuTAUyxXLPV9jwetLLmn4DHD1Gq5q4JgHbr8edXYG/fDY+HyegfzigaA98IYUrTNEexVL2HnMq4vrLutrYhZQncFC8aBcawMud2Yv22BJb0DJ3APaBXn7FBW0LsgTaJzkTi0bYKHEaJxaU/U1vslhdr8C5cFY57Dc3W5nWtu5xvLt/9Gk22sAL6ap4aV6QpsD/X6SJsvNF8qijAVWgbRG4eilm8GyeD5oiNlSuEqYKc5VVDRkWo2SONPDvYUhOcE9n1nF0cjlsjUgVQ9qYd4e56XLCDoxl0JLCed1OebTBKAwbB85RUbEcKi9+YBErDyRhUuCWPmsqNkH2ouHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xp2I61m9Euis7KFkFoxjtRVQDm4E+k2+RKCuqZHlTXI=; b=TsJsbFD5VB2RUxnuwQ7H30O3X+7a/uutxb4QS7B3jwh8whY2cR2YMsFm4KVjIRDqF0ElEar/Ep3O4yFTSFumYjyvW9V9ny7z1am33vd3LpZTrMdEbJFa20Q/7FxcegrQaEb28Yz8UyqrMZrIJ1d2Ncp1WwM9T7MDEod61FIsGyc= From: Bertrand Marquis To: Andrew Cooper CC: Xen-devel , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 2/3] x86/shadow: Don't use signed bitfield in sh_emulate_ctxt Thread-Topic: [PATCH 2/3] x86/shadow: Don't use signed bitfield in sh_emulate_ctxt Thread-Index: AQHYY5/DJ7m5gzay0kyOU7fQ4wwz4q0WfLWA Date: Mon, 9 May 2022 12:40:36 +0000 Message-ID: <2DE6B0C0-BF4E-41C0-AA93-8B09CC58FC9A@arm.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-3-andrew.cooper3@citrix.com> In-Reply-To: <20220509122409.14184-3-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c6554e41-e155-47eb-b534-08da31b92316 x-ms-traffictypediagnostic: VI1PR0802MB2287:EE_|DBAEUR03FT052:EE_|VI1PR08MB2703:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0WPRFthzpGYmoMKwDKhIUMXp5mi7V54k2VK5axDUaemhO/lau+yU6r6EwIl5BxHQz3U6HvUonIQ1RwWvqDGzQDUdcZIOYDyTteqnXSqE/VCZftun2E/nhsFRrgbF+XSwC/gw9izrjn2TBJcrNgClHgLIYv7Qe9RF2wTVVTqFPZfIZ0Zk5OAwOc6T1r9grqqI4t3NeFXljwHJb78Q/Y7wCxtY0bNdpqAGOSO1PyZ6WWajSsmeyQYncxU9hcB0WxL2k9z3X430YCoRHXYCGveswErXrZ48D02aGDKacwnfaxyx4p8kVdt+bAiwvX8dZn3gGClJQZxvPML4XuD9vCaxH0UMX5y5oqc/G+X61kfD3kvpiNEL5KXaLKdVP7oSSzDq8PAjWAQDnegDbYOBQA5kZY0usv6karW0b6jkW5p0ww5J055uP+qR5tfoeBf8SQGjq5WK623vzTM5k9Rkpdlylr0g2/gu2de2vzQL8IEeuIu8Ld+MU6Y+7uXMfKb8hXAR6mD+fkyPwnvdIqLC+Kha6iD2eNV4KHvo25cHa8tMCuvWMn6sWuVdvpIsefPPGy/x3l18TYmqZjgIt198xhsApKvK1cyz+Hl8/GXJFya2PqjKFYhecvkcX4E1n33h+4cnw+q3C4VTRoL4c5INgB3HV98SC6jYMXgh7Jq00GCNWpIxwFiA6ePZzsP26ZIwwUwLPeHoESiFcdQ2WBv6GVYWQ5ny0jR2BzdoRdC8YPCcMJjGfDyVQHzHH9tho7kVQx8S X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(38070700005)(33656002)(38100700002)(8936002)(5660300002)(508600001)(91956017)(66476007)(64756008)(66446008)(66556008)(54906003)(186003)(36756003)(76116006)(66946007)(6916009)(26005)(2616005)(8676002)(86362001)(4326008)(71200400001)(6512007)(4744005)(122000001)(6486002)(2906002)(6506007)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2287 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 277b8099-0434-40ad-e53b-08da31b91ddb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5mtkppqL7gpPDWZlCUEHgOhowe3Y5FPL2n2c+R+7klf1afM5K+g14y/6oVyNQp7lOgHdwcw8TNOXTNsFn1nYWgWcItqU/tUAM825v+KlRZ7cPaFmojpn2d+a7jPDi4CVusQ/6Pxpkg89MNNGXqc9U3HZUcopdqTtMOxMI/1DMf5QYnDBw/VIPsX37Uc1JhTGZit1aY7vmVsYEKMdyaOOhDjDr3T27/v65hal4Fkv9aJ9zksMYk+ugAzdXmXM8TNCgNYKpEm2zpSYQBQSdt539SL1XyJysoTWBxv92q3XVdftiNppB/tqGaAnoRPXrSxgAmifr5NrnM6kiWLNfs7NVnOJR9nTohCIf2MWLJG23OpJofNM29a7z2PM2KhjDlieP1ZSBr6QGpDDFNC5lcpiGlM2vdSIYDDirFmssOOHQxelGeryqOK3zWKalpDt88Gv2fZMs8Rdov/2ffj7TUsOLWMWYWVOG0/CqNFSr6qTBKt8MiS5gTgnT3+7a5JqWpS0RiDp+yAnUg3+rkWnZkYZC/MTaUHUC4G3rY5YU6dMDnXxERNf4yT1SwAdmOIVEy3jL7JGErkvLQ4H/uILM4CPHAhsQ9a4gCaODCHzzBtZA4AVc/e+skOFW5ECt30pd0UYJEZsZ7cw9MqOpfLb36TtZ2x/qQ9p1N2SCf1ahdg3MWBZsGYTTtAsnEBN8dhmDfi7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(107886003)(47076005)(508600001)(6486002)(8936002)(36860700001)(336012)(356005)(54906003)(316002)(186003)(6862004)(36756003)(4326008)(8676002)(6506007)(82310400005)(2906002)(6512007)(81166007)(26005)(53546011)(70586007)(70206006)(4744005)(2616005)(5660300002)(40460700003)(33656002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 12:40:45.3591 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6554e41-e155-47eb-b534-08da31b92316 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2703 Hi Andrew, > On 9 May 2022, at 13:24, Andrew Cooper wrote: >=20 > 'int' bitfields in particular have implementation defined behaviour under= gcc > and can change signed-ness with -funsigned-bitfields. >=20 > There is no need for low_bit_was_clear to be a bitfield in the first plac= e; it > is only used as a boolean. Doing so even improves the code generation in > sh_emulate_map_dest() to avoid emitting a merge with structure padding. >=20 > Spotted by Eclair MISRA scanner. >=20 > Signed-off-by: Andrew Cooper Reviewed-by: Bertrand Marquis Is in fact only used as boolean in hvm.c so does make sense. Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon May 09 12:51:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 12:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324518.546599 (Exim 4.92) (envelope-from ) id 1no2r6-0005ad-Sd; Mon, 09 May 2022 12:51:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324518.546599; Mon, 09 May 2022 12:51:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2r6-0005aW-Q1; Mon, 09 May 2022 12:51:16 +0000 Received: by outflank-mailman (input) for mailman id 324518; Mon, 09 May 2022 12:51:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no2r5-0005aQ-E2 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 12:51:15 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4dfc307-cf96-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 14:51:13 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no2qT-0003gn-07; Mon, 09 May 2022 14:50:37 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4dfc307-cf96-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vNWZxas8t1kFoCf13D7/vaEHrhXkMcvheesCeQUODMg=; b=LiRqvKrtw9XJxMP26bz+wzbn1n fBHqZS6c/XR8QMIkcDbMMcoNGulyS43Rfp83nqthIjvwxcC0/rE6EUbNIf51/kQdvFB0MZLjpT1Zt jPlWUhML/RrgwA/8AbWtoLwz1yzaOdGTpwde1q8bM8ZApOffPjJ50hQj+UprMTPvFMZ+3kTukzvDC T+M3aUntgoIptglMOe9noJu8WxIIHyHpxsCC1uL0UNNnEkCrtSTA6MLc7ESoFMKljoD3/1VBzhboF ZG7o2pwmSFhOEypVckR6q5+g5/pOsvXV3qshYFBj5WEOrVLcV95X7vQdrWZ9lJh80TjIodpEGtnLe +KvSh8AA==; Message-ID: Date: Mon, 9 May 2022 09:50:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers Content-Language: en-US To: Hari Bathini , Michael Ellerman Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, pmladek@suse.com, kexec@lists.infradead.org, bhe@redhat.com, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Nicholas Piggin , Paul Mackerras , akpm@linux-foundation.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-9-gpiccoli@igalia.com> <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> From: "Guilherme G. Piccoli" In-Reply-To: <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/05/2022 15:55, Hari Bathini wrote: > [...] > The change looks good. I have tested it on an LPAR (ppc64). > > Reviewed-by: Hari Bathini > Hi Michael. do you think it's possible to add this one to powerpc/next (or something like that), or do you prefer a V2 with his tag? Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 09 13:11:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324524.546611 (Exim 4.92) (envelope-from ) id 1no3AH-0008Az-Hb; Mon, 09 May 2022 13:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324524.546611; Mon, 09 May 2022 13:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3AH-0008As-DE; Mon, 09 May 2022 13:11:05 +0000 Received: by outflank-mailman (input) for mailman id 324524; Mon, 09 May 2022 13:11:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3AD-0008Am-Om for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:11:04 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77d2252b-cf99-11ec-a406-831a346695d4; Mon, 09 May 2022 15:10:59 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no39b-0005V6-KV; Mon, 09 May 2022 15:10:24 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77d2252b-cf99-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c6E44QfcLWCPcpfVVn8DZm/tazb9qDNjecxU8jgjjwM=; b=JQ1X+XDjDPRoAxPLkbe9tWes8w l11iC7oa/HVnyRK3qB7UvK9JEgQqPIREqD5654T0lMLes3kGheOm/R45s0nxu4hyBPxmCTVnzlJkN ZvlwDaZFuWVIh4IaLUzoP+QdJvpm215SH2+0rVomODoRdVpIAavgxOQl3rDnkTMN+fyPnfNOV7B7S PwRkKHJor0sF94EKnip9+x+OMSUvYBWlrOB2NiCodRGVM8ztswBp00gdyDLuMLY0TLuRV/nOMh+Z7 dku4FKzrs/p9E3LkAgwz4nFi/oHL/EcQWXaMAdDUro5POIL0/IvuDCL2llWo8K6mm9F1PYJhGhMV8 hibQS8tw==; Message-ID: <65f24bc5-2211-0139-ee12-b2608e81ceb1@igalia.com> Date: Mon, 9 May 2022 10:09:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier Content-Language: en-US To: Suzuki K Poulose , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Leo Yan , Mathieu Poirier , Mike Leach References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-10-gpiccoli@igalia.com> <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com> From: "Guilherme G. Piccoli" In-Reply-To: <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/04/2022 05:11, Suzuki K Poulose wrote: > Hi Guilherme, > > On 27/04/2022 23:49, Guilherme G. Piccoli wrote: >> The panic notifier infrastructure executes registered callbacks when >> a panic event happens - such callbacks are executed in atomic context, >> with interrupts and preemption disabled in the running CPU and all other >> CPUs disabled. That said, mutexes in such context are not a good idea. >> >> This patch replaces a regular mutex with a mutex_trylock safer approach; >> given the nature of the mutex used in the driver, it should be pretty >> uncommon being unable to acquire such mutex in the panic path, hence >> no functional change should be observed (and if it is, that would be >> likely a deadlock with the regular mutex). >> >> Fixes: 2227b7c74634 ("coresight: add support for CPU debug module") >> Cc: Leo Yan >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Cc: Suzuki K Poulose >> Signed-off-by: Guilherme G. Piccoli > > How would you like to proceed with queuing this ? I am happy > either way. In case you plan to push this as part of this > series (I don't see any potential conflicts) : > > Reviewed-by: Suzuki K Poulose Hi Suzuki, some other maintainers are taking the patches to their next branches for example. I'm working on V2, and I guess in the end would be nice to reduce the size of the series a bit. So, do you think you could pick this one for your coresight/next branch (or even for rc cycle, your call - this is really a fix)? This way, I won't re-submit this one in V2, since it's gonna be merged already in your branch. Thanks in advance, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 09 13:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324530.546622 (Exim 4.92) (envelope-from ) id 1no3HF-0000Xq-9M; Mon, 09 May 2022 13:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324530.546622; Mon, 09 May 2022 13:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3HF-0000Xj-5z; Mon, 09 May 2022 13:18:17 +0000 Received: by outflank-mailman (input) for mailman id 324530; Mon, 09 May 2022 13:18:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3HD-0000Ws-M6 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:18:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a48178c-cf9a-11ec-a406-831a346695d4; Mon, 09 May 2022 15:18:14 +0200 (CEST) Received: from mail-mw2nam08lp2174.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 09:18:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO2PR03MB2213.namprd03.prod.outlook.com (2603:10b6:102:e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 13:18:09 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 13:18:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a48178c-cf9a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652102294; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=GiO6rbo7xTqCqt3bQ74lzuBmepLrShCoF5uMoZEuQfY=; b=QPoC9sWo2RZNVM7mbJ8PwPR/webBlvzFwsTmpoi3E3IIT9Y+lwL+9mfk bev4/OJlm2QGmoH6QQF3BPTrIiztqtxv/2CMTQYS0cPB6tbGpENVgu/V5 4FsALrr3Wrr1Cc3Z16WhI5nvpyi5aCxwRdTvSr++V/vLiMuxPWjcRIbsO o=; X-IronPort-RemoteIP: 104.47.73.174 X-IronPort-MID: 73371252 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sIbm+KCHONxN6hVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApDt3g2YCz 2RJUWCFPKyKY2emctslbNu19UsAupOAn4ViQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhM0 thji7Kydzx4M6bwkdYwcEQbFixHaPguFL/veRBTsOS15mieLz7J/K8rC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l9B8mcH80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjz3SamKWACwL6Tjas452/80FZ77L3SNeX/V/CSf+pRm1nN8 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXOZi/Skjk+1W/pEN lcZvCEpqMAa60iDXtT7GRqirxaspQUAUtBdF+k77gClyafO5QudQG8eQVZpasEitcIwbSwn0 BmOhdyBLQJotLqZWHeM7IC+pDm5OTUWBWIabCpCRgwAi/HprZsvlBvJQpBmGbSsk9zuMTjqx naBqy1WulkIpcsC1qH++E+dhTup/sjNVlRsuVmRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:f0SrVakjaECjSF8cGK6E/LKSwhXpDfO+imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb WpaiIriYd1QTOlNfGz X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="73371252" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f84cehYY0/PnrbryA6Demg2+3rJ0CHZvJE9VzDERrFfRpJglbpAgr1UB/JLzdip4JlN1ZWLyRiHgUoKHEQAvdq5GHs/2bd74uWx4Y2ZzmGo/NXAbgunOitJWWxqLn+d2ZFVm9KO26ZlbmSL1yXnYDG6cMOzt9j1DhFMSqC9n1vh5W1I+tKi6b9y7iWQ8Xel9fMkQUa1tBrp2s6tb78Twooy/0ToQ0C6oUwBuWyWiS2Vcy4I57AEb8V8/l+zZpge5iIxT+89o3Ki8vHhj3ExnwXrTKtQjUopSCJSkbIsuWGECZ3+A4PwA7gZy8ZR5AVCIhgV49ZhS1NzunmcVjNUY3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GnGle4RGWx4BY466ADnhbAXUBtP+/xrcMWvgmzz2Sbw=; b=JRaA17EVP1CxtkGt6A2UrGak3U5aevF4amU4BJ38EDMB5c/SyLsCq+ipknusZoZISPUjKOw1+wZ9jc4WFwhbpL5IKsUDEB5VL2TeCsiltK9z1CvN9g4cJ+t6dPHqjXMLiiQXFtArk8OaKfhDYPt50YWDY0rPV7OAvp9TUBs3rxBgs/HJCEnDzQe2y67EVgXaZ4Go68ar4QDWuSoeB0OzIohI65aadzHA5lw8++O3/KUHjKeeISKsn1UvoI9KvSLQ4z6A0TKL4Jhb+68fvGiAfrpHSRCV1apM2va5Qe42gY3d+K3IqNRKw00XdSRAkZUo1Iw/VA0PpwRcvYoXuZsUHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GnGle4RGWx4BY466ADnhbAXUBtP+/xrcMWvgmzz2Sbw=; b=P/9W7aY9XxDVOTq+/3Z/GUX8T8nc9BnLB3tWODyb8Pk2sbvieVCcGJSsSzgGC/ovzemmx0erI+81knaxNjr7DDgVVGlRU5ZNDD72+CMb7sLpnIKhHxr0bepfiMKnDrSxpukcVFfTk7QQEOMyhxm9Dktm/E1FbpA8PpoShxxHWXs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 15:18:05 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Message-ID: References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220509122409.14184-2-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P123CA0460.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 572a4d1f-d0b2-4c8f-4a7d-08da31be5cb2 X-MS-TrafficTypeDiagnostic: CO2PR03MB2213:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Zd90o3LjkaPCFjCZXCJpAGCibgVB0FnJqY9T43TN7d2ZBru/D5zomeGVluAfMJ6PmlfrvAF/hM4gTaviNo8kRggFC3w8BAimGjKVXQ71Q+JY0km6p3o4W4okKHkZF/4NQrgv1tJYnHOOt1GOdgfDWl9Cr+GUI9Glgd4M0V9W7A/CYj2Q0E8kMaDeHkn16r/neu7EmznW1pcCCQuVItAYIvM6fw7o7LplpAjoR+oHSdVuFdjth5K/HypuGt1E+EzKIPMw7wHC6F2T0fqyzd7I3Qk4Eyj+uqv8glvQ3XiAyAW/JzhU+tA9A3qo++aF8iQHc9ZFXlfJ4IeflhMUOXa16JupqoD3GI2Eh1xnEcIS+WJ+ZCIrWQgx13aIeIxl201ESqa1ICu9tXDkHzuEPq5yXnp3Jd+s6amHehIqcWrPX85k/HSCkyduhU3DbM+bREUTMGfufa4lfsSvUihWeNUuzS/OwRkyt2Lyu/okOOSEV1SjW0DdT2w1cEeXf+DGJ53LuZQcr6hNylPLU/YiO03F1Uhi0h6s88wxCKyuFIL3evp/bYcExa4WGKeq6A7KwTGTXhqo+J88zudCxIFKxdXmcQWEnRGn8tb28QeTMMByM6FLxNfjnWs1gPpuwRFDWKn0x4tI00n5GCb9QB9s6uol8eFc/54ppOoeISZDIc/8dcuLvteezXjvS1BIpnJ+HI/1J6fFLkwVQ0ubfOo+oO1B+ISZ5fwKTl3so5uyJknvBA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(316002)(6666004)(6506007)(66946007)(6862004)(8676002)(4326008)(66476007)(66556008)(186003)(38100700002)(85182001)(6636002)(54906003)(5660300002)(33716001)(8936002)(82960400001)(26005)(6512007)(9686003)(6486002)(86362001)(508600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzZsaGFUQUY5UlQ1aEFkWFNiUzd3Rm9tcVZNc0hIQTlWL1FrR3lLWU0xU3JK?= =?utf-8?B?NzF4YzAwdk1XUjdmSVNldS9JK0VCYmJTWUNOMCtXL0hvWkxwcWVXU3hHK04x?= =?utf-8?B?YlowcHU2a1ZiMll0Rlpid09kQTZ0YUhaNW4yeVpVdXpwT2dUVmRWTUNqTzlU?= =?utf-8?B?SE44V2lEQkdBSG9CaC9kSnd6MC8wNEt2NUZwY2haWkZmY1hhWUJxOTJ4WXRh?= =?utf-8?B?Q1pZSTlXUGNMekpXUC9SNk1YL0NETllQdUFEbk5udDM2OTIycjRwWnVEWE1p?= =?utf-8?B?Y2wrbGJxeWJjVmo4OVdPakx4blFrU0JrcXNSR1g4Z0ZESXdIUDFzZkVJWnRw?= =?utf-8?B?YlIwLzMvVy83WDRwaW5SL3RieWZmOWxiVmdmWDJYRFRvc1lDeUN2TFlWYTJ5?= =?utf-8?B?OWxuK0NBRmIrTTNGVHdGekNmYWtpeWJ1ZGwwRlhnWHp3bVR6T2lGNVVNMUE1?= =?utf-8?B?Q1IydEZUN0tBUnpCZ1JGRUwvTVFsNmpFT1VtbEFDNHBYRzN0NUlKRmhjaVhs?= =?utf-8?B?aVQvT05qM3kyeWtTU0FwWlVEM2NWaTNiaDJCYWRPOE5QUW85YVQ2cjdwY1VN?= =?utf-8?B?OWQrWk0wVWxmbExqYWhvb21qdnRoZ002Ym9Wc2hkbWZxTDlTbjNmT0NQWUNh?= =?utf-8?B?c1EyZkk1N1R3LzJtQ3hGQUxHNE9yeVZlT0tZQkR2dzRPcG1EMzgvRW9mUDJB?= =?utf-8?B?ZXNOREh1RFByQlpxMnVHenhHVDlJdUNhOTVNRHNERE16aW50bnl6UmxQcVpk?= =?utf-8?B?Z25uWndHdTRPZVNEa0c1a2NUUmZzeng0NVVqUVQ2N1BUSHF1MzIrak90c0hK?= =?utf-8?B?RHZBRktvb1dQRnJaK3RRSTBFYmtMZml3REpYKzNJZ2hEQVdpMTVRSFZVblRF?= =?utf-8?B?YWZhZVZ0UGg0S3dGWXR5YlRtbi9pUDdrQWZ1OXlFb3BjaUFMVytIS0kvS2Zr?= =?utf-8?B?TG4wWFB0RVBLUmtEY0NpMkJJS0F4a1p6ZEFPZ01mejJ2Z05Bd0tCMUZMc2to?= =?utf-8?B?Q2tPQlNmTHBDY3RsY05vL0NETG1FZXpQcnJTL0QrMXVnbVJYdVUwbG1rd2Np?= =?utf-8?B?YnIxTU5zSEtOenpnMGdkaC83VDVnUGl6aUR5YXJrR0NPbENMTFdmcHordGg1?= =?utf-8?B?S2tmc1ErbDRhOU15MUNhUTdyc1YzTS8wWUVMZ1FKS1pyVUJCR2V1RUZrZ2t6?= =?utf-8?B?WWxwWE5mOWpvRXF6SUwyWU5YR2phUXZ0U0pXZHE2cC9OVytRRk91WUg0Wm1x?= =?utf-8?B?SEJNYnBGS3ZlcVpycnNvTW0vcXdqZ1ZKSlJNZW83Yk1kam13ajU0MTJHQ2da?= =?utf-8?B?MlAvajlTNGpjQ1JZMHBFeUo4V3VqMWhKNVU4ekZLK1d1Z2dCdW1OemZac0do?= =?utf-8?B?NGx5MVB5azdaMXk2OW1aQk1SWVdzSXNMZ2hnOHhPaWJvV2UxOFdDWUNGbElQ?= =?utf-8?B?ZVJpanZFUDI4OVV4bWZMTWh5ckZoUzhEYXFtUEROQnR3dndrTmNPSHpTWWsy?= =?utf-8?B?ZVNyWlQ1UzNJT1g0Q1U5OXZtTW56OU1mVWh5ckRCNi9TVk8yMElxMVRqczRJ?= =?utf-8?B?Z2ZyVGUzY0hVblY0U2RLZE9NSGZjRkJ5Y1BDenFpVVJ5U3pvWndzVUlFWEZV?= =?utf-8?B?Zy94a3poMTRSV0NYWjZ1Z050OGxsZFZNcnk1dVVmcFZURTlTTVVxM2x5TGg2?= =?utf-8?B?ZGVYcDJJWGFWSTdJK3dRUzFzQjBMVnlsNDBucUk3Sm1JbkhET3hWV1A1OGZU?= =?utf-8?B?TU9NdC9NaVlZMUVvYnJNS3hhSnljZThZMTJpbFJjS2lGaEVhZDVPeHhIN0hv?= =?utf-8?B?MmdKTWY2UHFaVGRHWEJ0TmxpR1c1dGsyM2tQb0I2MTBrRnA3QUlBZ0hxNzFz?= =?utf-8?B?N091dVk4NHNmZGdkckJkanpkUHpMczdCcWFnTFBkYnBWUTR1N1NiS3NZcG5M?= =?utf-8?B?eThueTkyMUVjdVVKZUtyMFgrOVRSVTJCK04xSDJKT25Oa3BRd2pDNlg1V0FB?= =?utf-8?B?aVV4eWV1bkxCSHMvYndIM3Vuam1NY3FlK1IxWHFGL0paRGxleWo0Tk11Rjcx?= =?utf-8?B?YVJKMVd6OGVmWDhZYm9TUSsvclJORFlnTXNQUG1jRzJxc0ppOHlxa1lSdk8z?= =?utf-8?B?TjhPYytzMGJNdjJ6c1E3OXgzaWhMa25pcHlLNHRCV2VtdldJSW9ZNkxJNEYx?= =?utf-8?B?N0dtM00xR0FpNXNyTzdJVXVYUEIyZzJ5TWU0LzlaY3N6QlFUTTJxUGZGRzVI?= =?utf-8?B?TWp3NlBPMmxOczIzTlZLMXQwT2gwUHhKWXo0WUFxT3I4REpDckxydkk3d09o?= =?utf-8?B?NHR2S3lkNWFjMERQMzJVWHEzTVBDVTRIMjRDQ1ZjeUxBeDI2OGYrUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 572a4d1f-d0b2-4c8f-4a7d-08da31be5cb2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 13:18:09.7405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JMVsrgrBEzKDQvGB8avPcUKONUVjE7Js6R+sW7O7qhR2KNAH/aRE50Mj1fPmCBHIC5RtCKbmUOhM2ZKYlI2GLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2213 On Mon, May 09, 2022 at 01:24:07PM +0100, Andrew Cooper wrote: > Spotted by Eclair MISRA scanner. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > --- > xen/arch/x86/mm/p2m.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h > index cc0f6766e4df..dc706b8e4799 100644 > --- a/xen/arch/x86/mm/p2m.h > +++ b/xen/arch/x86/mm/p2m.h > @@ -15,6 +15,9 @@ > * along with this program; If not, see . > */ > > +#ifndef __ARCH_MM_P2M_H__ > +#define __ARCH_MM_P2M_H__ Do we have any guidelines regarding guard naming? Some files seem to use __ASM_X86_, others just __ASM and some just _X86. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 13:19:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:19:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324537.546633 (Exim 4.92) (envelope-from ) id 1no3Ij-0001C3-Qh; Mon, 09 May 2022 13:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324537.546633; Mon, 09 May 2022 13:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Ij-0001Bw-Mm; Mon, 09 May 2022 13:19:49 +0000 Received: by outflank-mailman (input) for mailman id 324537; Mon, 09 May 2022 13:19:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Ii-0001Bm-Cf for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:19:48 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b143967b-cf9a-11ec-a406-831a346695d4; Mon, 09 May 2022 15:19:46 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 09:19:42 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB3695.namprd03.prod.outlook.com (2603:10b6:805:4b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 13:19:40 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 13:19:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b143967b-cf9a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652102386; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=tATOXAnbmdgsf2o/UzATsF1kogSU5808J3WZMNfRTUo=; b=WP2hMdiQ9MAEe0Kgf2TuBs5eT80Eoo9Ltw1qslxfKppTdeioUyVRlh61 XNyw93fwFaCWcU2ATc/D0AH4LjcswkbRaYqgcgCYM+3sdqCXoHI/WtYYS SoyEUE2fWyRTs46ammfflUbCRDga9IZAjbAdwnT+HiBEQKH+pK4bgj2pj Q=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 70757991 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4ayOBaAUBuSpkRVW/+Liw5YqxClBgxIJ4kV8jS/XYbTApDwl12cAy TZODDyHaazfY2Wkf4oia9yz8kkDvZPVn9NnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nh09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhR0 YRB7cfoTTsLP/fCybtCfiAFGBNHaPguFL/veRBTsOS15mieKT7G5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t/B8yaK0nJzYYwMDMYnMdBEOyYf 8MEQTFucA7Bc1tEPVJ/5JcWw7/32yauImQwRFS95rJ08yvzyxxN7bnkNtmSQ+zWfJRxpxPNz o7B1yGjav0AD/SPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fXmRrOS9i0W+c8lCM EFS8S0rxYAt8GS7Q9+7WAe3yFafpQIVUddUF+w86SmOx7DS7gLfAXILJhZDddgnuckeVTEsk FiTkLvBOztrt7GETGOHwZ2dpziyJCs9IHcLYGkPSg5ty9Puup0phxTDCNNqCreoj8bdECv1h TuNqUADa647iMcK0+Cx+wnBijf0+ZzRFFZpv0PQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytbFUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:jeDaq6h05L0udvigLsJ+m+tpZnBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70757991" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8tKRAU6NzclfOOrRYBcCChAHOkF8cHOvDwTUBcFweaF9ZBD+8KiTkLGB9z9GCJNlfV7HcYTO2tAmRrCI1JFxQfdLT3J4OgBGj9evJeGsRrpGiiJtjoiqkirvfDMia7+oBetaxYfUl1lOmaq+NzzrEnujs0zkURMrCwbY9GifX3QOyFZ6lBtGTGub8srOxZosZ5FohC0fqFnYU6c09uFQfNTqL3aYo0IawcKVSbH+y3PbVOJT9CFqG1c0tHEfIz1hXjGcs48eSvmhyyZE+4sQXB1NzYwYF1m2cJUpxFOBBQnLDeshANk7+LiXpHzSZG7hS9AOWdv8rSZLFKKiZU+uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x3J9GGBre8qxJQVjdYz1Xg5oJYU2Mu3jLazozNoGKLI=; b=NRibSyhyljOjz4EHLgP9tNjQ1DeNRvMk66pzs4Ov9ioOCCI4DWGUmYqrYLatV3Z+oX1C1q16jFdx2stSw8CLblfLgCxij2UK9J/kZKWi1FvVqQQwrR7lwUem0RRfVL96fAu59F3h6IthG9o4SDUTTUNh8Mlf5sg9zHLtcGGxrKajC3zPxYucqToEwOlIsZ/DB2CEZf7i3GNlpqyEbiDwJDE7jckiDeOW/oyB7vVz6WlPL5CVMCbyga7qcZTE7qo9Vjd3H9INY8hrS2I4JGa4rzdnRBkm5hbI77euDg0GukO4g4xIbNaxRa3rmCcvaeVRRADC/I3b/f3yszGvrlFRvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x3J9GGBre8qxJQVjdYz1Xg5oJYU2Mu3jLazozNoGKLI=; b=a4lzXO/WWmXly4LEn50gRSrzad/gQOCX3d5Iq4GxrjxKM57TON4L6IckKQuR9zSyuA9e18SPWEDD3gJotzKL/C992C0KaKxbibtJzchqj8vfdDdfbISWbfwUYuv0/kHNAJLZwpG0dvtgZkTj0SmQfusXjOOMfsPntAelVsu6zbA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 15:19:35 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH 2/3] x86/shadow: Don't use signed bitfield in sh_emulate_ctxt Message-ID: References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220509122409.14184-3-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P123CA0062.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: febfcbb9-3032-411d-b7e9-08da31be92b5 X-MS-TrafficTypeDiagnostic: SN6PR03MB3695:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GO+kk21inPUXO4OyjiNwLmtuZFgBFbCdAxTkKUq6ynZw4RwKbiYgzeXWE1lJfLV1xwwq8XqatwbuMdwm1kAnxGyNzqoC8aKG4INI1RvQvExbQaURqyIo52Ya/sLdlHiADCtfxjPN9yUX3V9b4ZFUmbw+saRdIIM5WK6LoNRNmv5SAqy0shhd+HEGfcsSW24xJk/4hvxHrCiHN7fiYyjlrh125QGbSPpHO1Ag+s6y6b0GYt74rc8v3qXsT/h60hpN5QBRCv74VfNPzHi4lvvubUShG50Ute191dFe5oaHVhvBARTL78orzMQLbPSM8ZcHZYJgu0f6/GUL8asOcXFeQQt3V2FvxL/wahn+DLDSvSiyXQwHWHBtQubFc6JmBq0xEutBt2tsPqMdTfmkWpIiXVE9DCMl4nrDKNpzSrgZjWPBIgoMj+MP8AsldlrKbqF7V3StixVLUgGg9gSqzefMMt/W07yXKVnIamwT4ts4yc08jSsFHf9TtJMNizVV9IEIGJNojGRIlGUo2JilE7Ami4rdEqT3cvXF/Jp2VBG99zn1DC/NUaqVkF/t7s6hXKoMpKqvwcJQd9rG6xZMitWLkzTjCrSvKV8sZ/+xfmVKDPPPOz55ZwFYEeBIQGvErL57q/pXHPp20iECkHEoEm/FPA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(2906002)(82960400001)(38100700002)(8936002)(6486002)(4744005)(186003)(508600001)(85182001)(86362001)(9686003)(26005)(6506007)(5660300002)(66556008)(6512007)(66476007)(8676002)(6862004)(4326008)(66946007)(54906003)(6636002)(316002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1RKZEZQblEzTEZ4eDhmSVh6aXRsbk0zNnp3UE1wUVJYdnByU3ZIU2VZZW5G?= =?utf-8?B?MXFDODBCNGFPSVZTZlBwUTA5RDdETWhJME9qbVY4Ulg0Zk1zaUp0am0xYTU0?= =?utf-8?B?K2JpdDdsTms5cm1UR2xKY0ZVU2MrdGRGVHpMZnB2ZFV3N2RIT1E2U3l0U1hx?= =?utf-8?B?SFdBT0NjL01Sd3N2aHFjek02YjlwL3QrS0xhdHBUZmc1RnZPakx6d2ZnNDVF?= =?utf-8?B?dk1wTkxWOHFaNUdYNTlXNk4xTmUzUWVYUTVHYzMzcTR3MHFhb2FSRjh6QmJs?= =?utf-8?B?NzB4eHRlN2M3aUMxNVRGVlVhMm83QlhRVGF2MzEvRkFaT2FoVk9MZ21mUExn?= =?utf-8?B?OG0vRDJocFpJZzYzU3VRRW5nYVh1QmYvemRISnlqRHg1VFlCYXZta1p1dEdm?= =?utf-8?B?YWFKWE9mc2c5dmdIQlNOTVNGSjRLRlM0Ulh6UzZhNnpxemtJcnNtcE9OLzE4?= =?utf-8?B?eE1VNWptSTBqTnhTejZPcGtKbSszekVrL3VUMUFBVUc0ak1FOG80bXNINkJy?= =?utf-8?B?ZHBxQUVralk5S0xldjNEKzJhcXdNMjZVdGhLTkgzZWhiblBBNVU2L1dKdGo0?= =?utf-8?B?eFhJY1RCQTBPZUJQSXVEdDdHdzgrOFd0YUg4WlVqVENmbmhQWXVtbXVwRlpP?= =?utf-8?B?NU4yUWd4NjJERFY4RDNtZ3JITC9GZDE2L2pTandFSzUzYUxMVnJHS0Z2VGlR?= =?utf-8?B?N2dUMXltTlVkQkszQk1BR0lOa1NyT2FwVnVqbUpvUXpNcVhuMU1LbUgrZUxs?= =?utf-8?B?M0J6cGFvLzZQMmlWcVh1RHpPMTdtTllGTktSdzNnczVCUis3bnhlSkJlU2M4?= =?utf-8?B?VU5XRlJEZGg2R3UxR21jcU10eUpWeXJYdytCMHI5WlNTaVNTb2tUeGREUlJH?= =?utf-8?B?ek9BazJjMk1IeDB2Qm83bHhwQ1ZRcWRya0dYZHFVVm1lSXNidEIrWjE2N3pG?= =?utf-8?B?QnFhd0pJYzJvSjVjRmNTaXZ0cU1Ga0dwc21UWnRjdnM5L0w3U1BFWFFMb1dY?= =?utf-8?B?T3k0aGxyRngwVkUxUCtJVzlxU1RPZlJxbmdTSjJMckVxS3luL21BVlMyUlRP?= =?utf-8?B?ZDlMYnNaQUNQaXFYNTVBRXlJNXpMZ1I4QS90QzN2T0FRZ0RPc2E3dWlYZTJu?= =?utf-8?B?NVRUN0g2ZnVua1J2SnYraG1qQThHQVZiSXFMeEFQVkR1eTd5Y0xnUkI1Ui9t?= =?utf-8?B?ZXJPNEUyU3hBanQwcXZKRkFlK3VVNkZDZ2k5bms3VG5pWWlVcmI0Umswa2ZS?= =?utf-8?B?NTJCWG14VGVkdkY4by9XMFYzOWM2TmdOcUpkbElXYnRoVDRxWUJMa1dGbG9y?= =?utf-8?B?eER2N1hoRGI1WWhKZ1BEM1VoSkI3bk9KVjF6U3NCYWZXb2NQT0E5RmFFRDlB?= =?utf-8?B?cVRaK2NrNWZGaHlqTVB6SllnVW04c1k5SjErMkoxM292U2R3ZHE3SE9aN01S?= =?utf-8?B?WXFWR0pEVlNFZ1E4RjlYSlJESllUMGNOd2RsSTN4Q0w4YitNUEpvMEY0TVdO?= =?utf-8?B?TFpteGEwYXhId3hPdzUrWXdETnBSWXNyYWZ1Y2h6KzFicjI3RkM1VXlONGxE?= =?utf-8?B?R1JPN0NiR2xJOXlpbVNwSU92WmJ4SmNWcWJ6eHpIdTFxWlVSNFFXTXo2VURT?= =?utf-8?B?cVczbVFHdzY2azZJc0NmNnFMc3ozNGxFTmg0emlnOSsvQzF0TWM0elVtT1RS?= =?utf-8?B?T09rdS81R0tFcUVERFFIME15ZUsvdjRDaldsQ054aEIwQk0vTWdpRzZGQTVP?= =?utf-8?B?ZjZxRzVSV0FUd2Y1T2JkdisrNkp6cS9wdGR1TEtSTmlGWjgrbnBYMjlxVmpU?= =?utf-8?B?REV4Mkw4UTR2NTFmY2xCdG9iQWw1dXJONkRCenBqdHYzOThkSXJJRm42Sjhn?= =?utf-8?B?K21McjAzUy9aWWVDcFJDVXlNenE0RGNTS0RQc0JPeXRidURBS3hqLyt0OW94?= =?utf-8?B?N1lvN01ieFV1c1gwRXRidnZVQVdKekUxQUZYQzZoNXBnb0FKWDFWekhEZnNF?= =?utf-8?B?cExDRksyNFpxQVZUaGRRaXZHSjNzcksvTFgvaERYL1hDWk81SFd2MFB3Y3ZX?= =?utf-8?B?ZnhWSVcrMGRyN1MzQm5LamlUMk1ydDE5dTlvZVpqK3pGcjRBTGNyK3FraG1s?= =?utf-8?B?TG9ReHQwYm80TGhsekRzZ1V2dGkwUHQvQXQyM2JkdXpybkRxZzJuZ1VoQUw4?= =?utf-8?B?U1A3Y0F4NHNxSlo3NWF1VXc2N0lkV3ltUXVaeFFOK3ZXUkZIc24rMXNXWEZN?= =?utf-8?B?Mk05dWVaaWFwVlh6L1RvVDEvbGhXTWNxY2hOd2NOUFRpWThMWDdUQXdBRGxG?= =?utf-8?B?KzdpQzZrcFM1Zmp5S2x4WlZvYUhOUUtqUkw1K2IzOFI2OXNoL2lRZkdSZlJO?= =?utf-8?Q?vtvDcCpyPZnR3PWE=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: febfcbb9-3032-411d-b7e9-08da31be92b5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 13:19:40.3151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UJ7hJ8OTTw/gO9O3FGm+GDW5hQsRs2vM10xvWPKHtvngb4e/UvH/fWS0wf11P1ucX/1abYmcWf9SN+rP7a37g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3695 On Mon, May 09, 2022 at 01:24:08PM +0100, Andrew Cooper wrote: > 'int' bitfields in particular have implementation defined behaviour under gcc > and can change signed-ness with -funsigned-bitfields. > > There is no need for low_bit_was_clear to be a bitfield in the first place; it > is only used as a boolean. Doing so even improves the code generation in > sh_emulate_map_dest() to avoid emitting a merge with structure padding. > > Spotted by Eclair MISRA scanner. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Mon May 09 13:23:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:23:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324545.546644 (Exim 4.92) (envelope-from ) id 1no3MH-0002hk-8q; Mon, 09 May 2022 13:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324545.546644; Mon, 09 May 2022 13:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3MH-0002hd-68; Mon, 09 May 2022 13:23:29 +0000 Received: by outflank-mailman (input) for mailman id 324545; Mon, 09 May 2022 13:23:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3MG-0002hX-1X for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:23:28 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ee86ba5-cf9b-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 15:23:15 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id p26so10507767lfh.10 for ; Mon, 09 May 2022 06:23:27 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h5-20020a056512338500b0047255d2111csm1941442lfg.75.2022.05.09.06.23.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 May 2022 06:23:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ee86ba5-cf9b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1K2obVx3YG8QEPrenU4QI5guJQ8Phbo/6yP70JTaawU=; b=ctuOdHCyg4DfJDMuVyrfXjafqsIBGrPq9u27BiBAquJftMSjYFJ55Dztcsr8bNMn0w oeM//L+QbMc5cqR/YL4ZYXu9SspJYNvQLipuO/dxUV/COK7qJD4YPieEuwN+Da6gnICg tiL5ifQOF61sLM7j5k+TfKf3keD2QE9+mfbjkcLau1uokLQ0TJXXWGRj10hWZc6mNTCY ZiPlrCXkxh/d8AP+hVzj144bdbLZ6gunWEeo3XTOHdZMf+1T4Dk4fDvhUDM82hKq6q3x a24gfPwl0eQuynyAnF+v9tUB7WbmPEsnBDi3opOHoOjQkJbqyH8fYmRySBDQ1lHi3t+I lY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1K2obVx3YG8QEPrenU4QI5guJQ8Phbo/6yP70JTaawU=; b=DUjh/Eb0Uqjrv1QWktIlfIv0P8WIdLR/aeEDWz2zLdlZ+8o+4v7aINZMzC9CmZgI+d HE6Pu9PN/1lYvhxwbWwmAGMEAMDJfgFm9fH6q/ZcTT7MDs1DqLa+qN72V8csebMpfWli AeIMeQ6wwPfctn8K31ex6VIYglG4gR7p2lAzrnMau2TO2rIm5JiNKSxxSYiXhQTFkhoY GR5tU2Nzh2z6mZ3rk84XX1AShITT/DjellbMdFLt+L2cxNg97//9uzb3CmeazQdnksI2 ycr+2TCHLiwHg27dKp8EIGfv2tytfR/0KjyRvtSs6+GBC/YynjRl3byjo6yTRREP0Vkx CsRg== X-Gm-Message-State: AOAM532UDEopi24ndeVqOLma6nfTU8OXfvQ2QKdMDXBEJKIR7bO84XK9 yGWkVP9TaGMuLvwzPkeMTgY= X-Google-Smtp-Source: ABdhPJy54uNV0a0Y5a5xZUhU6QHCMVecZmAJ2frVW6KAYppShjM44jXuH8rdrMemcTVYgMIiSG1E7g== X-Received: by 2002:ac2:4c49:0:b0:473:ca4f:9345 with SMTP id o9-20020ac24c49000000b00473ca4f9345mr12622420lfk.203.1652102606387; Mon, 09 May 2022 06:23:26 -0700 (PDT) Subject: Re: [PATCH v3 00/21] xen: simplify frontend side ring setup To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-integrity@vger.kernel.org, linux-pci@vger.kernel.org Cc: Boris Ostrovsky , Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Bjorn Helgaas References: <20220505081640.17425-1-jgross@suse.com> From: Oleksandr Message-ID: <409fb110-646a-2973-aff3-c97fdfb9bfbc@gmail.com> Date: Mon, 9 May 2022 16:23:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220505081640.17425-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 05.05.22 11:16, Juergen Gross wrote: Hello Juergen. > Many Xen PV frontends share similar code for setting up a ring page > (allocating and granting access for the backend) and for tearing it > down. > > Create new service functions doing all needed steps in one go. > > This requires all frontends to use a common value for an invalid > grant reference in order to make the functions idempotent. > > Changes in V3: > - new patches 1 and 2, comments addressed > > Changes in V2: > - new patch 9 and related changes in patches 10-18 > > Juergen Gross (21): > xen: update grant_table.h > xen/grant-table: never put a reserved grant on the free list > xen/blkfront: switch blkfront to use INVALID_GRANT_REF > xen/netfront: switch netfront to use INVALID_GRANT_REF > xen/scsifront: remove unused GRANT_INVALID_REF definition > xen/usb: switch xen-hcd to use INVALID_GRANT_REF > xen/drm: switch xen_drm_front to use INVALID_GRANT_REF > xen/sound: switch xen_snd_front to use INVALID_GRANT_REF > xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF > xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF > xen: update ring.h > xen/xenbus: add xenbus_setup_ring() service function > xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring() > xen/xenbus: eliminate xenbus_grant_ring() For the patches that touch PV display (#07, #16), PV sound (#08, #20) and shared buffer framework used by both frontends (#10): Reviewed-by: Oleksandr Tyshchenko Also I didn't see any issues with these frontends while testing on Arm64 based board. So, you can also add: [Arm64 only] Tested-by: Oleksandr Tyshchenko Thanks! > > drivers/block/xen-blkfront.c | 57 +++---- > drivers/char/tpm/xen-tpmfront.c | 18 +-- > drivers/gpu/drm/xen/xen_drm_front.h | 9 -- > drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++---- > drivers/net/xen-netfront.c | 85 ++++------- > drivers/pci/xen-pcifront.c | 19 +-- > drivers/scsi/xen-scsifront.c | 31 +--- > drivers/usb/host/xen-hcd.c | 65 ++------ > drivers/xen/gntdev-dmabuf.c | 13 +- > drivers/xen/grant-table.c | 12 +- > drivers/xen/xen-front-pgdir-shbuf.c | 18 +-- > drivers/xen/xenbus/xenbus_client.c | 82 +++++++--- > include/xen/grant_table.h | 2 - > include/xen/interface/grant_table.h | 161 ++++++++++++-------- > include/xen/interface/io/ring.h | 19 ++- > include/xen/xenbus.h | 4 +- > sound/xen/xen_snd_front_evtchnl.c | 44 ++---- > sound/xen/xen_snd_front_evtchnl.h | 9 -- > 18 files changed, 287 insertions(+), 404 deletions(-) > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 09 13:23:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324549.546655 (Exim 4.92) (envelope-from ) id 1no3Mf-00039y-Is; Mon, 09 May 2022 13:23:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324549.546655; Mon, 09 May 2022 13:23:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Mf-00039r-ED; Mon, 09 May 2022 13:23:53 +0000 Received: by outflank-mailman (input) for mailman id 324549; Mon, 09 May 2022 13:23:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Me-00039Y-7z for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:23:52 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42fff34e-cf9b-11ec-a406-831a346695d4; Mon, 09 May 2022 15:23:50 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 09:23:47 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5282.namprd03.prod.outlook.com (2603:10b6:a03:22a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 13:23:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Mon, 9 May 2022 13:23:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42fff34e-cf9b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652102630; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=iL73GEIo0RvvqQPfebHpzrj1wMJsKL8iY3j3lm8kTBo=; b=JhoDxMOMcXYcswNjIVxEcCHiHkTY3K4Mz2gcK4y4YlM10FN5JPVal9XZ 6rnD/jbkkY+imXDe423pb1FUSfjunTJLwhcutQVGMNq8KHr3VLp8GibFL 6PHSO1DgNv+uByaWYcPk5RAaP67URuKTfGg6nWy7QYfEzaL5b7EVzJ/Di w=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 70901613 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kn/Mua8JzvxLZIZkAs/oDrUDUX+TJUtcMsCJ2f8bNWPcYEJGY0x3n WoZDGGEMqmMa2CgKo1+Yd7np0wD65ODxtcxSAVtpXs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IDoW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbWsVQsEI6znotoMbyZ3AS9bPIAewYaSdBBTseTLp6HHW13F5qw3SWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIEItNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK/ftvujaKl2Sd1pDfYN/YWoTbb/5ZvUiIr 2LKwmHJLC4VYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3C WYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ l2Um9LkAxR/vbvTTmiSnp+qqje1NTkQPHU1TyYORgsY4PHuuIg2yBnIS75LGqOvksf8Hz22x jmQtTU/nJ0al8tN3KK+lW0rmBqpr5nNCwQztgPeWzv86hsjPdD1IYu19VLc8PBMap6DSUWMt 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz3k5J/Vei8OA1DGXo= IronPort-HdrOrdr: A9a23:JBOHlqDnggfoqEvlHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDTa5rPw== X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="70901613" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRKdd4Zys4RJ2XK110MrzUEeAP4aHRTcA4hpMVfcQCaCnLS9rZbAUIl/fsR4e7/dmHtbB6OQ9g+/tk+eOX4fLyCK4YhrGfBbxL3jMJ71cpHp+Q8Sn+/hv55DkD05bO69I3LD7MPtsovekUPzqWBbMXeIF2Xe8OFWwd/oOfAoODsiYGVF7zaTKXYc2vnfNY8sipok8+BV3BZ921nrQ53UfDaN/CN8+WtwrpkEf9fmJg7lbzaQoEHpgwUIDQ20cTG/qZtdOzNRsgpLv5ahaWXf3KHnFRsOOPnIqSZlf8q7am3hyzSvO3i+9sB5g48DTJ0pise/jX0OY0shRDez0C884A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iL73GEIo0RvvqQPfebHpzrj1wMJsKL8iY3j3lm8kTBo=; b=HzMreJDAqMVKCMQzn/y/NAXlpyRXBZr2ciJslU5H/HDeiQBz7pHUbgxdudo3DoldvBeYyIQ8V902o/X1B7jIBDWhB3D4K0c8N/oHr0p3jHjTkWIF6MBCAj+osusX6A0RELAo0PfMx1DCH4t3401Xn6NGKDs3HdJ3gdxiBBctkYwn0Lj1Z6s/sBEJ9crT0FUVmucbs/xoll0fS5cChxl97U+qXtuirsC96OsS+zGS+Su0k0H1ta4l5+7SFh5m5E4ztruSMm1hU0D/WRsajTr61jwDpA4HpZ/X5OB4lfIhZdEj+qtuGk3nJFzrAJElMhfnJSm6HBOAeDxe2xWXC104sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iL73GEIo0RvvqQPfebHpzrj1wMJsKL8iY3j3lm8kTBo=; b=DlZEWawoQOcZ+zug4DYoiYxqWH2pnDdGS53oGXd6IvAaEkWzTbpEcTu0XDUAWNRO76QXa4cxjJK2cP6E605KxJuWc6sZk6QMsJXhinySx+WfKmk0u51B2VQrv7b9mHzc2ruzJ9xqePahaB76vV4TUgbW9ism9JbMiF5B90dBWz4= From: Andrew Cooper To: Roger Pau Monne CC: Xen-devel , Jan Beulich , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Thread-Topic: [PATCH 1/3] x86/p2m.h: Add include guards Thread-Index: AQHYY5/ES9ABGv/aoE600JAs5fhuma0Why+AgAABlYA= Date: Mon, 9 May 2022 13:23:45 +0000 Message-ID: <21c74c28-db16-e5d1-e688-992cc84d6893@citrix.com> References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97cac84c-e2df-47c2-e449-08da31bf24e4 x-ms-traffictypediagnostic: BY5PR03MB5282:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: URyhRRNZ/Reqbeha5D0j1n1eg4CmM+YEm8FaReYOYhu0Hitkwgobprt6vcATJquXnVNm4nIqBgiabzx57wJ0yRtz4/T9FlEJD7sYWTXkZg7Fussrv8ALjYc/sYlik3srXmH3s9XQvWFZJ8eER0ocTOmU6bwb2K6aSWG5grWMaEm/phdwvZQZEe/2H2nJP+aXW49+/9oE3gFGX0CI8rIzodsxX1yoEKLHwm1+BIFhU290nKr1CYK7t9vzyeMIexK01F014B20CtiV2UFSdXNmAEnH+CL8pWrrgA0jyzAN3hMccJU4OHl8XrANXCldbEh6Z7IXQvJMSqlEsLd2PlXI6W3eQQSDMRuUzlNQU7PKQdIvyysmu1lSbn4bUQmaH+m9JsxpWdNqRJ3YssxyhtNqSkGNTE4r8HpNlZuHOVF/h6MFVmiRQYKq5YVjSJ/wN+rgpqpXPWnN1jQjdQwF3tJqZ1oVV3f0cI8XiQwZvC2ZEG09UKPWmbxFvhnVD5K54aXhlzey581z/ibac4ukPkLtXH/Q9mu4+Z//EnIuScUsYCv6q52SJLyskLYbqRDGBVvH6ntow8Mj0Nnn1CcoO1IF6oqsl0y9z7J1Sj+zFDbnmkac5F2i1Gl1rvKx/zYdSXUKpQByX6Nvwu9ti5XqeLIoXRyCqhCGAscFXI3ZGtFVT87VD1K829lYW0jq/r+6WKMrlv6FYdjsoCBj6+pSw6YQnf8SlJHeVvtQWPGD8Kg/P33vuz+i8zZYXJxCgzQMneIuZsBDgY4hFVIyr4DMZIkr1X6Dctvp2AGVM0fQZ5Wkk7X3Ptv7koYdspQGmo5g6fBD2BbBT4kzKHDJ6J6Qzn2sJ60cHdH+uN+yiHrzRblUJjw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(38070700005)(6486002)(508600001)(37006003)(6636002)(54906003)(122000001)(316002)(82960400001)(186003)(64756008)(4326008)(71200400001)(36756003)(8676002)(91956017)(6506007)(6862004)(76116006)(2906002)(66446008)(6512007)(66476007)(66556008)(53546011)(26005)(66946007)(31686004)(2616005)(31696002)(5660300002)(86362001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MGV2MEZ5eVFVcGJ6RmV2UjlKcnZkcnNINEd0bXdwRGN5Q2ZHUlp4VXdqV29N?= =?utf-8?B?ZUpVKytseEhhU3JZNFZhRW5qc1VkVWVoMFZoQ3NhcTZvOTg0aVdGTGpMVjRx?= =?utf-8?B?MGVFeEhYNnVLMnFGUzZFZEZteVVlenltbE4wZVo3Q0VvbldQVnI3Nk9lTG41?= =?utf-8?B?eDZNSjU5anZPc21Fc1FvZXNZeUpWUnlvaDl1eUhNOG85b2l5VHFrcnpwaFBh?= =?utf-8?B?Rms3Tko5S211ZStYL096aUVaVmZDQlozcVRqbFBEMVR1dzNQY0pMWG0xVWVl?= =?utf-8?B?Q2xtZFVEc2xiVVRnbzdNbFQyenhLU3Y1L0EzalRXK1hSdmFWSGgxb29qZDU4?= =?utf-8?B?RGVGdUxwbGV2Yy91RkFLN0c5ZkZPZW5JL3dpTjdqbGtZVGMxY3YxTGlTVjF6?= =?utf-8?B?OHVZTGJ0ZzdPWlVMUlRSNW4xVllPYk0rMUZiTk1iVUtXWFhSaEJHVlI3VG15?= =?utf-8?B?clhPTVAyRW5nUDQydmx4WnkxZTRnYjdjOEsvcHhOM3hQaTZPaUZINUhEWDFo?= =?utf-8?B?bDlkZ2RldVVyMWhmRWJ5VG1NQ2EzbDBLSndaQ2FJQnZCcDBPYTJBQmJIemdZ?= =?utf-8?B?a3MrNFM4anREa1RUaXoxN2E5aGx5aEhaVTlEMG5GNUdJdkQ5RGxBbUpMOXZi?= =?utf-8?B?dWlvcU55QmpPS1h2UnhwUHN6U3NWZU51R21ZckcwNC9YeGNpbmdKR3pZUFR1?= =?utf-8?B?VGg5cDFLSUhDazlEWUtyR3JRcUkwYXB1akNpSkp5ckxqVkNrRlV3bTRyeUt0?= =?utf-8?B?b1poSzdaQ2c4d1ExWnV1d0hDaFNpSndFYUFQSnJnVHhOcVlBQU94akphMndq?= =?utf-8?B?Q3h3eC94YnBaZittR0tVR1pYOHZtdzJmVk9DWXM3cytYT01mRjhXdUg0Tktr?= =?utf-8?B?NE5XRmlLU01GaWhPUXI2bVpXY3RVU3hpaFhmN3NOYmNWV3p1U0ZkcnRrT1JO?= =?utf-8?B?cnJ3cTRqdklEMVJPYW9mOFVubWtkNkxKR0xjeG1YSXlaamRDa0Q4Wlo3K1pT?= =?utf-8?B?cmNXWE5Ba21vd2dRTXpqZlJMQVNDeW1oeSsrUStNS3dSZUVubGtrZDQxelpN?= =?utf-8?B?dS8vMEtva2dESTJUZHpIZmx1SlJaZVdNNXl4Z0p1d0kvOVVxK2hGSE9pSXlU?= =?utf-8?B?YlQxaldnTU5QMmF0Zm93NVNFa0RtNUNXZDVqVkdEZ0JFOUlrWFVrWCtXVDJQ?= =?utf-8?B?VnZMWGF1eGNYWHB4blZIOElISCtWN1NEU0p5TUdMMU9zUFJPM3RYVVR0S01Q?= =?utf-8?B?cXM0ZWRZc0FQOW1MTVlJWFpyc00wU0JXUk85TEl1NVRCTzVmWi85WmJkMGY2?= =?utf-8?B?K1FlN2h0bHFYbnhmY0RTTkh4NGgranIzUFRaUjFBZlplZUdSbTlGdWErNnBh?= =?utf-8?B?OUg3MXFGYzYzNG5OL1VyelY1OHhyTTlRbVBMR2prVlNqZnN5cWFpZGZiNmN6?= =?utf-8?B?bllmcVBWanpOdExOd1cyN29ISXpvd1FTU3BYcllRc0xxT0tqN1VwcHB6NVZq?= =?utf-8?B?eWdwWGFBeXlzdTFQZ0VDYytEN0QvOVhPdnpqTGtvbXVweEwvdEdRamZZbVRu?= =?utf-8?B?clB6MnA2NzBkektOby9HU3VOais1dWJsYlhKMDZyQ2FoeXoyZzUwZDBtOXZI?= =?utf-8?B?TEpxUllxdXpkRTF1UVNkYUJzNmxlSy9ZS0tLOGNjcmpHbkNYZDc0ZFlsM2tt?= =?utf-8?B?MEx5NW5OblkyZVpyMjliU1hlQkF0ckx2K3UyVXBLTForbUJHMWRBVS95cUhQ?= =?utf-8?B?K0VCRkt3MmoydFFBQUFlQ2JJWU5tQjhDU2ROL2x5YUVvMTBrN1VHb2VNcktL?= =?utf-8?B?cFBmRlpTZkJRWFkwbHpOVS9XY0pCWGxsbGltUTJUSWtZV2d0R2VlZng4UVU3?= =?utf-8?B?SGs3TjFMRTJUd091VXdoME9hL1NtQWRwa3pGQzJ1RUtoUENsMUFpRG5BVzll?= =?utf-8?B?MUROUWRoQzNoUmplZHBhbVppeXByTWh1MjRPemNzY3lFcGRPS2cvcE1YS0dQ?= =?utf-8?B?Q0IxRnhuWUNITlk5OGpEa0d5NGduR1c4KzNHNnNmQnMvVndiTDAramxVaExG?= =?utf-8?B?S2RxeVQ1QVRkY0hSRWhIM0Q1SThQV3pVSXJDQ0ZhdGx3U1R4MUp5cHJHK1JV?= =?utf-8?B?a2hCOERmREpvT1pEbUUzWG1aMVljVTlGcExMNWFqdkZXZFVXUTFyTkpTazlY?= =?utf-8?B?dDFLenl2enNuQ0NjUFhNYVFjNHF2OXk2dG5EbDlScDE2K2VwR1A0VWY2a2NR?= =?utf-8?B?MVZ3c2N2aGV6bytJckUyUE1uSVdUcUdBZXlhTDFueWoydi9udC84c094MkhD?= =?utf-8?B?dmsxUTRDZlc3eFdRNkloN1pOdzhwSXZ5cGxZcDBWQUs3UFpSd1haMmNQWmsv?= =?utf-8?Q?QrKR/CCo87Nd3dPk=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97cac84c-e2df-47c2-e449-08da31bf24e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 13:23:45.3216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dj5xHpK32J+osgpIa7/oloAawBmBY2lK4PLDCFNJ4zmiUUoJ3MNry/Quaj1ZGciZ4QIPHy4T+fMINedrDkOJ/iI7vZOtU2C3Hr2JydRGOOM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5282 T24gMDkvMDUvMjAyMiAxNDoxOCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gTW9uLCBN YXkgMDksIDIwMjIgYXQgMDE6MjQ6MDdQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+ IFNwb3R0ZWQgYnkgRWNsYWlyIE1JU1JBIHNjYW5uZXIuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gUmV2aWV3ZWQtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPg0KPj4gLS0tDQo+PiBD QzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPj4gQ0M6IFJvZ2VyIFBhdSBNb25u w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4gQ0M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+ PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4gQ0M6 IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDQzogVm9sb2R5bXlyIEJhYmNodWsg PFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPj4gQ0M6IEJlcnRyYW5kIE1hcnF1aXMgPGJl cnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gIHhlbi9hcmNoL3g4Ni9tbS9wMm0u aCB8IDUgKysrKysNCj4+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspDQo+Pg0KPj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0uaCBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0u aA0KPj4gaW5kZXggY2MwZjY3NjZlNGRmLi5kYzcwNmI4ZTQ3OTkgMTAwNjQ0DQo+PiAtLS0gYS94 ZW4vYXJjaC94ODYvbW0vcDJtLmgNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uaA0KPj4g QEAgLTE1LDYgKzE1LDkgQEANCj4+ICAgKiBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbTsgSWYgbm90 LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+Lg0KPj4gICAqLw0KPj4gIA0KPj4g KyNpZm5kZWYgX19BUkNIX01NX1AyTV9IX18NCj4+ICsjZGVmaW5lIF9fQVJDSF9NTV9QMk1fSF9f DQo+IERvIHdlIGhhdmUgYW55IGd1aWRlbGluZXMgcmVnYXJkaW5nIGd1YXJkIG5hbWluZz8gU29t ZSBmaWxlcyBzZWVtIHRvDQo+IHVzZSBfX0FTTV9YODZfLCBvdGhlcnMganVzdCBfX0FTTSBhbmQg c29tZSBqdXN0IF9YODYuDQoNCk5vdCByZWFsbHkuwqAgVGhpcyBvbmUgaXMgZXNwZWNpYWxseSBj b21wbGljYXRlZCBiZWNhdXNlIHg4NiBoYXMgdHdvIG9mIHRoZW0uDQoNCiQgZ2l0IGxzLWZpbGVz IHwgZ3JlcCAvcDJtXC5oDQphcmNoL2FybS9pbmNsdWRlL2FzbS9wMm0uaA0KYXJjaC94ODYvaW5j bHVkZS9hc20vcDJtLmgNCmFyY2gveDg2L21tL3AybS5oDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon May 09 13:27:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:27:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324560.546666 (Exim 4.92) (envelope-from ) id 1no3Pj-0003x1-4M; Mon, 09 May 2022 13:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324560.546666; Mon, 09 May 2022 13:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Pj-0003wu-0R; Mon, 09 May 2022 13:27:03 +0000 Received: by outflank-mailman (input) for mailman id 324560; Mon, 09 May 2022 13:27:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Ph-0003wk-GE; Mon, 09 May 2022 13:27:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Ph-0005w7-DC; Mon, 09 May 2022 13:27:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3Ph-0004Pg-6O; Mon, 09 May 2022 13:27:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no3Ph-0002NJ-5w; Mon, 09 May 2022 13:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OBUmcBGc5vWUW3sCEDOa4hIf0ZFhTm3Tft/OmH5lXRE=; b=654rSKqD6lHGY1sWt9O8yDKrdA +9crZhxUe27lK/2i1RCzZsVydIPGhstxpQvSihEmb51U+j69nxLAB1ePwtVPJ5ZmXBvNtVn/lQAw4 bcDYGhLwRkRvloMF4KWJBFnhg0oH3DOAIC7DgyZlv1JdVh4goRIdNWeRMbEMK4CWEw3o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170269: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 13:27:01 +0000 flight 170269 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 894 attempts Testing same since 170267 2022-05-09 11:41:59 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6180 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 13:41:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:41:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324568.546677 (Exim 4.92) (envelope-from ) id 1no3d7-0006KJ-Ax; Mon, 09 May 2022 13:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324568.546677; Mon, 09 May 2022 13:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3d7-0006KC-8G; Mon, 09 May 2022 13:40:53 +0000 Received: by outflank-mailman (input) for mailman id 324568; Mon, 09 May 2022 13:40:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3d5-0006K6-Cx for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:40:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9bed3273-cf9d-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 15:40:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 601B01480; Mon, 9 May 2022 06:40:48 -0700 (PDT) Received: from [10.57.80.111] (unknown [10.57.80.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F32E63F73D; Mon, 9 May 2022 06:40:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bed3273-cf9d-11ec-8fc4-03012f2f19d4 Message-ID: <234a41ef-3e39-d0ad-5e1c-575f575bb8f0@arm.com> Date: Mon, 9 May 2022 14:40:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] arm/acpi: don't expose the ACPI IORT SMMUv3 entry to dom0 Content-Language: en-GB To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk References: From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2022-04-27 17:12, Rahul Singh wrote: > Xen should control the SMMUv3 devices therefore, don't expose the > SMMUv3 devices to dom0. Deny iomem access to SMMUv3 address space for > dom0 and also make ACPI IORT SMMUv3 node type to 0xff. ...making the resulting IORT technically useless to consumers. ID mappings for all the Root Complex, Named Component and RMR nodes which were supposed to be translated through that SMMU node are now invalid, because ID mappings can only target an SMMU or ITS node. I can't guess at how other consumers may react, but Linux's IORT code is going to experience undefined behaviour when tries to translate any MSI DeviceID mappings through this invalid node, since it uses a bitmap of (1 << node->type) internally; beyond that we're not as strict as we could be and make some pretty loose assumptions about what we're parsing, so it might even appear to work, but that could easily change at any time in future and is absolutely not something Xen or any other software should try to rely on. Thanks, Robin. > Signed-off-by: Rahul Singh > --- > xen/arch/arm/acpi/domain_build.c | 40 ++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c > index bbdc90f92c..ec0b5b261f 100644 > --- a/xen/arch/arm/acpi/domain_build.c > +++ b/xen/arch/arm/acpi/domain_build.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -30,6 +31,7 @@ static int __init acpi_iomem_deny_access(struct domain *d) > { > acpi_status status; > struct acpi_table_spcr *spcr = NULL; > + struct acpi_table_iort *iort; > unsigned long mfn; > int rc; > > @@ -55,6 +57,44 @@ static int __init acpi_iomem_deny_access(struct domain *d) > printk("Failed to get SPCR table, Xen console may be unavailable\n"); > } > > + status = acpi_get_table(ACPI_SIG_IORT, 0, > + (struct acpi_table_header **)&iort); > + > + if ( ACPI_SUCCESS(status) ) > + { > + int i; > + struct acpi_iort_node *node, *end; > + node = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->node_offset); > + end = ACPI_ADD_PTR(struct acpi_iort_node, iort, iort->header.length); > + > + for ( i = 0; i < iort->node_count; i++ ) > + { > + if ( node >= end ) > + break; > + > + switch ( node->type ) > + { > + case ACPI_IORT_NODE_SMMU_V3: > + { > + struct acpi_iort_smmu_v3 *smmu; > + smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > + mfn = paddr_to_pfn(smmu->base_address); > + rc = iomem_deny_access(d, mfn, mfn + PFN_UP(SZ_128K)); > + if ( rc ) > + printk("iomem_deny_access failed for SMMUv3\n"); > + node->type = 0xff; > + break; > + } > + } > + node = ACPI_ADD_PTR(struct acpi_iort_node, node, node->length); > + } > + } > + else > + { > + printk("Failed to get IORT table\n"); > + return -EINVAL; > + } > + > /* Deny MMIO access for GIC regions */ > return gic_iomem_deny_access(d); > } From xen-devel-bounces@lists.xenproject.org Mon May 09 13:52:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324578.546688 (Exim 4.92) (envelope-from ) id 1no3o8-00081O-8h; Mon, 09 May 2022 13:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324578.546688; Mon, 09 May 2022 13:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3o8-00081H-5D; Mon, 09 May 2022 13:52:16 +0000 Received: by outflank-mailman (input) for mailman id 324578; Mon, 09 May 2022 13:52:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3o6-00081B-FH for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:52:14 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a9fb32f-cf9f-11ec-a406-831a346695d4; Mon, 09 May 2022 15:52:13 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id l19so17106722ljb.7 for ; Mon, 09 May 2022 06:52:13 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id n16-20020a2eb790000000b0024f3d1dae7csm1817440ljo.4.2022.05.09.06.52.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 May 2022 06:52:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a9fb32f-cf9f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=8UNXwi7En+f6mmpMgmfaP7ZbRHw3s6lmPr0wkjJTWaM=; b=P1cUqIcKS0Pz77ERJTJIQfingexbjURyhZ0OwewbC1M1aOsav69UutqdBtMfQ2HXDU zwMc4ZqdjbbEZed4ctX0ISGY93zAHp+FkVsiizCineeISfdlHBWkxxYTA0u/59FHnYL4 +N+Xi1zvo4muTCVv7U54Y5d/VIpAlFFjqBUH0fPhjOPM7u+sC0MedLFgN+Bw1y1tTQqa 6tlQgIGVvMEZ2SElF+ZcQb1FjKEGe7QWDp6QRC8kG64/7JRbCq4DfHWoZtIurPkbhK80 9PjzRN96KbCSEDRXZA79tahFCEynlyePLykguWyKDG2ziMwLn6TxgZy/2S1GIERvRUrc klng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8UNXwi7En+f6mmpMgmfaP7ZbRHw3s6lmPr0wkjJTWaM=; b=YEZukwkVkonWFhZwyxYzwAopS+cmoASh/5qhrZXZRgcQXL9q8maG7AxC1CVc3OwiaX nuyXCBl6UMe1pPlaGxXG0dVj+zcohIQIbnXmFkY3knKxBKTUkrQlJ2C5sYudjAbjKi+a +Zc0GrO2Za1IAIGpcXGppDLWctzR3RopFNI7p1nTT+9GkKjGl2L7TvuC2R/DjVx4fDO3 X1K/UNNs3F829gtkBJ7G3SNAlZwF+Slo3yWS2bQlTJiNy+bohBUtjqr0X0NDp0jwanJQ GoqqLHQwVD6Cp3CtuZQXsFkvYT/zFW1jp/HdTWsYB4iYgdJ0sdz1KrCJVPI2ptaCrwHS Fbxw== X-Gm-Message-State: AOAM532L0HqXSZvNurpKF+qQnrqC2s9QqAcQ4qQoLw4429K/o5CDUEV0 kupvVBKPrrb6eMYk5Pbfkb2vYkRdi7g= X-Google-Smtp-Source: ABdhPJzJiKpFr+qJniu4vmrliAJnDQM5Cx7W/ly6EkrD5z16nFtffkMwE9R1AM8IQBk5F/7wNvlTTg== X-Received: by 2002:a2e:a7c4:0:b0:250:5c78:9a99 with SMTP id x4-20020a2ea7c4000000b002505c789a99mr10624317ljp.10.1652104332211; Mon, 09 May 2022 06:52:12 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, dri-devel@lists.freedesktop.org Cc: Oleksandr Tyshchenko , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Juergen Gross Subject: [PATCH] drm/xen: Add missing VM_DONTEXPAND flag in mmap callback Date: Mon, 9 May 2022 16:51:43 +0300 Message-Id: <1652104303-5098-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 From: Oleksandr Tyshchenko With Xen PV Display driver in use the "expected" VM_DONTEXPAND flag is not set (neither explicitly nor implicitly), so the driver hits the code path in drm_gem_mmap_obj() which triggers the WARNING. Signed-off-by: Oleksandr Tyshchenko --- This patch eliminates a WARNING which occurs during running any user space application over drm (weston, modetest, etc) using PV Display frontend in Xen guest (it worth mentioning the frontend still works despite the WARNING): root@salvator-x-h3-4x2g-xt-domu:~# modetest -M xendrm-du -s 31:1920x1080 (XEN) common/grant_table.c:1882:d2v0 Expanding d2 grant table from 5 to 9 frames [ 31.566759] ------------[ cut here ]------------ [ 31.566811] WARNING: CPU: 0 PID: 235 at drivers/gpu/drm/drm_gem.c:1055 drm_gem_mmap_obj+0x16c/0x180 [ 31.566864] Modules linked in: [ 31.566886] CPU: 0 PID: 235 Comm: modetest Not tainted 5.18.0-rc4-yocto-standard-00009-gabe87d78bbc9 #1 [ 31.566922] Hardware name: XENVM-4.17 (DT) [ 31.566940] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 31.566973] pc : drm_gem_mmap_obj+0x16c/0x180 [ 31.567001] lr : drm_gem_mmap_obj+0x78/0x180 [ 31.567026] sp : ffff800009d03bb0 [ 31.567044] x29: ffff800009d03bb0 x28: 0000000000000008 x27: ffff0001c42d43c0 [ 31.567080] x26: ffff0001c42d4cc0 x25: 00000000000007e9 x24: ffff0001c0136000 [ 31.567116] x23: ffff0001c0310000 x22: ffff0001c4002b80 x21: 0000000000000000 [ 31.567150] x20: ffff0001c42d43c0 x19: ffff0001c0137600 x18: 0000000000000001 [ 31.567186] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000035c81 [ 31.567220] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 [ 31.567258] x11: 0000000000100000 x10: 0000ffff95d69000 x9 : ffff0001c435ac30 [ 31.567294] x8 : ffff8001f65ce000 x7 : 0000000000000001 x6 : ffff0001c24de000 [ 31.567329] x5 : ffff800009d03a10 x4 : 0000000000000090 x3 : 0000000010046400 [ 31.567365] x2 : 00000000000007e9 x1 : 9dd8cb7c02b1bd00 x0 : 00000000100000fb [ 31.567401] Call trace: [ 31.567415] drm_gem_mmap_obj+0x16c/0x180 [ 31.567439] drm_gem_mmap+0x128/0x228 [ 31.567460] mmap_region+0x384/0x5a0 [ 31.567484] do_mmap+0x354/0x4f0 [ 31.567505] vm_mmap_pgoff+0xdc/0x108 [ 31.567529] ksys_mmap_pgoff+0x1b8/0x208 [ 31.567550] __arm64_sys_mmap+0x30/0x48 [ 31.567576] invoke_syscall+0x44/0x108 [ 31.567599] el0_svc_common.constprop.0+0xcc/0xf0 [ 31.567629] do_el0_svc+0x24/0x88 [ 31.567649] el0_svc+0x2c/0x88 [ 31.567686] el0t_64_sync_handler+0xb0/0xb8 [ 31.567708] el0t_64_sync+0x18c/0x190 [ 31.567731] ---[ end trace 0000000000000000 ]--- setting mode 1920x1080-60.00Hz@XR24 on connectors 31, crtc 34 --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c index 5a5bf4e..e31554d 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c @@ -71,7 +71,7 @@ static int xen_drm_front_gem_object_mmap(struct drm_gem_object *gem_obj, * the whole buffer. */ vma->vm_flags &= ~VM_PFNMAP; - vma->vm_flags |= VM_MIXEDMAP; + vma->vm_flags |= VM_MIXEDMAP | VM_DONTEXPAND; vma->vm_pgoff = 0; /* -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 09 13:53:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:53:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324584.546698 (Exim 4.92) (envelope-from ) id 1no3pj-0000BU-LX; Mon, 09 May 2022 13:53:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324584.546698; Mon, 09 May 2022 13:53:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3pj-0000BN-Ie; Mon, 09 May 2022 13:53:55 +0000 Received: by outflank-mailman (input) for mailman id 324584; Mon, 09 May 2022 13:53:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3pi-0000B1-9P for xen-devel@lists.xenproject.org; Mon, 09 May 2022 13:53:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7498433a-cf9f-11ec-a406-831a346695d4; Mon, 09 May 2022 15:53:52 +0200 (CEST) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 09:53:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB2971.namprd03.prod.outlook.com (2603:10b6:3:122::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 13:53:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 13:53:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7498433a-cf9f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652104432; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/c3ie2XGLJXXW9etjGgzHiUJqMIHHEiG8sVQSFPzLRY=; b=LvEP0neH0lk8SQE28KZShV8HYCLvn0wIixOgOIsF+NkPTr9v0i/qGPhc 2bUKb4tLsxbBOQPfaM69ngOssI6ewa00MnvdyJxPULpTBEI9raoM7uklQ 7++i/ouPmALCe6rhFCczzVzujCzHKSEsoHtLLZu9ZZA7WeROC6FrFXYEB w=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 71294654 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nhGFwKgg30CmLu/F+UhjgH68X161qhEKZh0ujC45NGQN5FlHY01je htvDWqOPvuON2ejLYskat62o0kAsZCBzYVhTQc9qyAyFy8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlvc4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVY4IqHNubsEahZ7S3tCD61rybWfeHfq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWhu7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvP9PZpvjS7IApZ973KLMTyRsGxSuoIx0rHt CX+4kXEO0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc/B1J lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe8Uh8x2EwKfQ5wefB0AHQyRHZdhgs9U5LRQoy 1uIktXBFTFp9rqPRhq1yLCQqj+jPDkPGkULbyQEUAgt7sHqpcc4iRenZtxuCrKvh9v5XzT52 SmXrTMWjq8Wy8UM0s2GEUvvhjutot3DSF4z7wCOBGa9tFomOsiiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrlxBJ1bLkVhs3QxD IronPort-HdrOrdr: A9a23:lyKTR6n6U4f/n4/f39R0XblclErpDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp r525RT5c5zp/AtHNNA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="scan'208";a="71294654" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EKWyZxMu+nsxHVnmgFL4TGVfDLmZRMBZoPN3EE4OF7sWBxIaAyy+T2vi5JdnIG+uCZAz7Q5xxDxafwPwjCYoiNy7mwTcUt1ua0i9cBNhtBv8xEhhSDuqwBgc9Yman9d+a3VnbH6sPAUlT68Nu/4St7o1tv7fcDzTMYN8AX4dWkowcYySX3ASuh6S4+ZnBwwDk2bjhsu7D5h7BS96v72XMbivY4KbSL9aDJxR4Bfyhwcka84Q3zqvA3O6vs6a/SfJpojkCXgKUHK0pU2DT4mqx5Nq9bYmqX8R7/Qax+zKUGqMH61pvIAcBbLh0R/QylADxxjF7Vk1t4u/ztEX3PVCsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UeFhHXcUn8QzX8DuAxhxcA27qps7HWPARRHyB4uGeas=; b=Y7BKu3VMinX8R811I1yl8JkipX1igHEzL6A24dE2EXTmoFez2vk21RktS1dz1azlfqRHoXksgvvj6wQcfzOOzePF1ur7D47vtMN0g6sVp7uW+YfRtlpiN0U8bN7KYlwYS9cKR50kOawH/pR3chUVx8gRyve3AyIISl0wNoD5yvK3EtJmvgcSXDEDrD+MxUnICMPYElXzPXVptukyIX8PW6+Zk3eoSXDIERXLyrOKmuin1z3qV95M98ae4eoymWS2aojkWMTUBR2P/GwvG+tAmcy0Xo/9Buh+rPtHr1j7xpA/AABIhUI0nIhs5SnnU6e4hMUG0dZSlrRUYxZGs7Y4vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UeFhHXcUn8QzX8DuAxhxcA27qps7HWPARRHyB4uGeas=; b=cDzsg0ZLWRT/hwcZUULwYgGFc5f4cNVsKZIujued00nXABJFItAZk4dXAM5384H/bz6+FR8jULEnUtebzR1ROxlgJD8yxwn8DQMa1McpEKSKQ/hmPFSzIXsOuQkPIATT8o4mwnagLXrkGkeKE/9eEh4YeFPC0J6WiGHG1+BS9b0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 9 May 2022 15:53:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH 3/3] common/spinlock: Drop inline from _spin_lock_cb() Message-ID: References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220509122409.14184-4-andrew.cooper3@citrix.com> X-ClientProxiedBy: LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c7cce90-2553-4c78-cca1-08da31c349f8 X-MS-TrafficTypeDiagnostic: DM5PR03MB2971:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2uhQ9JmHtbORYPqRdUQhh8QUC6dKIjZF8LQX5YBsTjXort8wm0R8moQ/npiyUhlsJxnJ9JgqLDCU6eqNZpz2pDJUdD9cbEJH0QsXp1wBU/rJH9hItbPseD76wEdrE4/Dzc+jRqvQOQGGJu+6hzSx/LzrlKAm8t2XRCrM0KGgZRCxotFo6dKmOVLvrnmX6sQDcNS/iHAZxmH9MNQovsy27asKCXeCSPS1UEnAEBMybMDbD/g4ldUXVCZqnxz4l3NrmxzqCWugOleqOHa3eYL6C8Jw5eO0qrtuSuJI52eSy1vw2JGZthxNXgUx7nIgOclk6Xt0C5E9fpUYicH3YlnC0nn82p9zx55cuWdErmfKdAU3WR01WYNqI6Kiivo8lFhXy/iK0eQdTeB+8bWPR5o01qq/G+eMGsUFPArw6R5yM+ExPzy52J5yd0DTy/ln/0HhTljcRB6U96q9TLx4MC15b54DVqXxIU3ehNJy2dKr2a/ImlVVlvsHTGVVE96JP6UithUzjq5jlOhJODlCFYSJ4QMBhMNxIuZoBKNbcPitcGjddsua7MLG1DtwyytMB1SDuJ5tyiUX/PlzO87f5+RWeIckP1X6KHgJZ9XGhQT9IveU5/VszTOU2uY0ALGszmJ2O9JmUcxQ1XGZ/C6N+JV7zQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(316002)(85182001)(6506007)(2906002)(54906003)(6636002)(6666004)(26005)(6862004)(66946007)(4326008)(508600001)(66556008)(66476007)(6486002)(5660300002)(8676002)(38100700002)(8936002)(83380400001)(9686003)(6512007)(4744005)(33716001)(82960400001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjFONzRjc2pQdWM0a21IK3dCdXJkRlRiTnh5WTg4ZEVDL0ZKTy93dkJqWW9M?= =?utf-8?B?Q0ZZbWk5djJQMUhjMVFDUElTZHJWTWErUmlTTFlxeFhhL1FzamFmcm4xNTQx?= =?utf-8?B?RjhZdVpPazRGRm1Db2JOcU5CN253U05OYlZlcWJmNFhnb2VZQ3dtUVNyZ0o4?= =?utf-8?B?WC8yY3Q3VEYzOVFDcDl3bVJzVkl2UTJ5eGI1aUJUbnQ3eUVYalNOaGE1NUkv?= =?utf-8?B?UHRBZHRIdlBMMlFncEJmNjVBbDMyR2Jmb2NJRnpCdDdzQnNzTE9sTDRObmw2?= =?utf-8?B?SW5zU0huWlNpWWpjaTFHSmk3N2IzR3JhRFYvL044SGNRUm9QcWZZMlpwU2NP?= =?utf-8?B?dTNvZWQ2UGs5Y01iaGpIeGYvUFNNMXM4N3FONDBtNVBEYWpJUndEYlFpSEJr?= =?utf-8?B?ZFlZREJSb052KzRoM09aSnk4KzhaRHhPWE9IaDZsSCtsZHVhbjRacWtSOEww?= =?utf-8?B?Y3doS1o0bXJSdndBeHRZZWZsNnRrYnZnV3hkOCtCRkJ6WVFpcjVNRnRwSis5?= =?utf-8?B?WjRCbm5vYnp6aXNQODBsZXg4SU9FSmJteDUyUklhMWNnbktSa1pFczJNUDBo?= =?utf-8?B?K2IySk5pZDdxQWt1cy9mMm5PdnA4VXh4dTJUcnhmcllrQnBLWjh3dVF0STlz?= =?utf-8?B?ME1ja1g3QVJlSEMxK0todW8rQ3V0ajJpVlM2Y2dVNGM1VnhSSDlyQklIODFB?= =?utf-8?B?aGc3S21uV1dYZ1F5eDA0eWxqaUFXYU45bkVENUZOZGhOQ0JQVmtSR2tzVWVw?= =?utf-8?B?YUFCaWZwcysvUCt0WHF5Y1FadmZjcFNENks4aUdSSDBDYUgzRGlEZStJbWVJ?= =?utf-8?B?anFUVFh5KzN1ZFZoZlJIY2t1WnFKM25vV0RBTmg2SkhlY05uM3ZLSHl5d2x3?= =?utf-8?B?MWltcTR0bnIrMzVQanJzVVp4K2liRTB5SzIrRjNMMVlkMU9mVVRvVmNpbTNh?= =?utf-8?B?T0ZDNENnZ2liRysrRTkzdEFPMnhPUkEzVHlMclJwTEg3YmovM1owMGJtenJE?= =?utf-8?B?TnJUNEZzY1VlVEIwVGxTTi92a1lBb3Y3ZHE4YTRYRjlYQ2RiSCtGcFhQOCtt?= =?utf-8?B?VE1qSXd5cHhtMmVyT0R6NnBhSi9sd01Hcmh0TmVqcFJSaS81TVkzN1Y1Z1Qw?= =?utf-8?B?SFVuMVFLWHBqdDJFZWd3T3Z1dDlpMkJUdG1STWNTbVpFclo0QkFwalZIUHpm?= =?utf-8?B?cmtGWE9USmFyZnRycDVDWjh2djVFQTVBcm5sWi81QXpPMjNFeWlCMkF6ME1G?= =?utf-8?B?WXBPeUc1bEpuY0w4VG1SSkR1MDBtTUVqdHMyYWNWa3dTTTFXK0I0cjErZDNZ?= =?utf-8?B?bjdmUzdHY2czUzZhMjM3SDJ2WllLUFlWbzNiZzl6VGpxYjZRYlVmMUxlWUhz?= =?utf-8?B?T0tWcldZVjBjSmN1Q2tOc1FlQWJZdVJhS29DaFowcVJBeVRTK3lsMzFCRWgv?= =?utf-8?B?eEM0aVZTMmJtaFJrQmJ4UVoyYnVHaENtVStTR2JjL0hJekhnSVdqNS91VExU?= =?utf-8?B?SzRQMHR6RWRTdnIzUTYzQm80WEwvdDN1dC9lendTSEN4eEtJZms5ZWlBSHdw?= =?utf-8?B?NmN5OXpJUjVHSW9Vek4rZFhLOHRkN1dRcTUreXV6ZlZEQnRpWHVLdm9DTE1y?= =?utf-8?B?UUthcGVMVndLL2w1SHlKQ3h2akJyaUFsUVRjWkRkV0RoZXh0aVpjcjdmMWhv?= =?utf-8?B?aU5yRUJ3aUlSdDZMRzY4RTVtZ1VBamhkckZXOTQweTRBRVpsTHN2SlVCUk1X?= =?utf-8?B?UUd1dWl0cFl0TldHYnZ6WFdxNFo2SnR6dTFEVGZDQ2hLV3N2MGNqa3pnSUdk?= =?utf-8?B?SitWNHhwdDJmcE1McWF2M0xpMjU2T0MwRGJGRjRhbUZMKzJaM2pqTzNyOEUx?= =?utf-8?B?TlBGRndBZ29oTWFPcXkralBxNGZSTFZXeFRHNFArZTdnRkFNRXlDWlVRUFlS?= =?utf-8?B?SDdkK0kzMm50NWtYZS91bVdVeWxMTUxDcklsS2VObnFPN2ZIN01FQ2R6bTU4?= =?utf-8?B?SHQ4b1BTRVU5aW9pTGlIVUtaRFdjUWp1alZ2YVZHV0k5RkFTQ3d3bjV4aDVz?= =?utf-8?B?WHZnMVliS2hFZ2ZnbStMZ1Q0N1BPcUVjYW1RWnduOEViS0plOTdWQTF5bVFU?= =?utf-8?B?WXlKQnExbjNPVjJnQ3pNT2xJSzJZejB6Y21lVldGR2JrMnY1anJoMWdOZzlP?= =?utf-8?B?anJSbmQ2ZzdtUm03YUZkanVYM3pkQkJDR3Z4aFQ0aUt2ZVFnQ09kUWs1NXdE?= =?utf-8?B?ZUlObGhpSnJ3b0NpbU5EdUV3dnczWVZ0K2oxM2I1VndabzR3bUR1VHN1bHdS?= =?utf-8?B?d20rQ05RdWlwaUVpOVRSRWVXeGZLT1RPeVYyNVNTaUdvWW9EMktORmpremV0?= =?utf-8?Q?tCMmhqSkbj9stsK0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c7cce90-2553-4c78-cca1-08da31c349f8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 13:53:25.7334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fmzudn+pQ8aow4xzqqA54xEgQQMDw5FIFIWJakzBmcIlilDkAMvrtuemSCOEC4VDMoSY66i7tOI3rL4+xFIydQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2971 On Mon, May 09, 2022 at 01:24:09PM +0100, Andrew Cooper wrote: > This is undefined behaviour, because there is no _spin_lock_cb() in a separate > translation unit (C11 6.7.4.11). > > Moreover, MISRA prohibits this construct because, in the case where it is well > defined, the compiler is free to use either implementation and nothing > prevents the two from being different. >From my reading of the spec, using inline defined function with an extern declaration could allow the function to be (re)defined in the scope of a different compilation unit, kind of similar to the usage of the weak attribute? > This function has external users, so drop the inline. > > Spotted by Eclair MISRA scanner. Like wants a: Fixes: 462090402a ('spinlock: Introduce spin_lock_cb()') Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 09 13:59:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 13:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324592.546709 (Exim 4.92) (envelope-from ) id 1no3vF-0000wN-DC; Mon, 09 May 2022 13:59:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324592.546709; Mon, 09 May 2022 13:59:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3vF-0000wG-AY; Mon, 09 May 2022 13:59:37 +0000 Received: by outflank-mailman (input) for mailman id 324592; Mon, 09 May 2022 13:59:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3vD-0000w6-U2; Mon, 09 May 2022 13:59:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3vD-0006Sk-Qs; Mon, 09 May 2022 13:59:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no3vD-0005C8-B0; Mon, 09 May 2022 13:59:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no3vD-0002d8-AY; Mon, 09 May 2022 13:59:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QZpaoRz2Hf0M8HpuH01YlpdXEJn5SYwoVSnl1LT9YG4=; b=TB/e2Vsqw1zsyLx9uAyi+j79lv g6dM+tb4dn5229TIvIVL9mCVZIZCInK78LiyJaXJTwoQdfTxI2/LIJ4qNd/d8EqaxPI0HQa79Y9Y7 ewBpaAeOIQ3axtOugW9TUj7Bj8ggRyhNwsuKew7WpEGNB+hgrqXL9Igw8bG67fkPWRe8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170270: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 13:59:35 +0000 flight 170270 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170270/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 895 attempts Testing same since 170267 2022-05-09 11:41:59 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6180 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 14:14:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 14:14:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324600.546720 (Exim 4.92) (envelope-from ) id 1no49f-0003Vx-P0; Mon, 09 May 2022 14:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324600.546720; Mon, 09 May 2022 14:14:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no49f-0003Vq-M9; Mon, 09 May 2022 14:14:31 +0000 Received: by outflank-mailman (input) for mailman id 324600; Mon, 09 May 2022 14:14:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no49d-0003Vk-Qn for xen-devel@lists.xenproject.org; Mon, 09 May 2022 14:14:30 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55351a32-cfa2-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 16:14:27 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no48z-000Acu-NN; Mon, 09 May 2022 16:13:50 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55351a32-cfa2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=21Vuf08H7s2roER44d4b0UgJl5trrJFyPVjW1sFjFZE=; b=ruDiqyoExl2jG8ttjj8Kva7F0Z 0gmy1ZjUnSZw1kESJcz3XDyEnMdDBnsUYP/IGGe7AdFcEsabz8oUBo80VtrFGlI8cQnzWF9UlpBBK 4aFG0PgEAjxrGpxgz2rOXDVYxrjQeGb+FiM0Mo8j9WOU5B7iKslK22FH7g8xu7/o+vhoBdIcLeTVq TXR8EZtHjX3vb/+hbwrFc/UcTSPrqLuaLvGSeO7jUEfo1fKsk4NXM02lMULpMgFIGTd5/R8izOFMK smJXU8ctgfXKSVE5XSrKVK5cDdrQAjusLpX81WYReyDmurYDvxkw6DQoXAKa1dqFr5Ui2vHbk0ezv WsObUf8Q==; Message-ID: Date: Mon, 9 May 2022 11:13:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 10/30] alpha: Clean-up the panic notifier code Content-Language: en-US To: Ivan Kokshaysky , Matt Turner , rth@gcc.gnu.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, bhe@redhat.com, kexec@lists.infradead.org, linux-edac@vger.kernel.org, pmladek@suse.com, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-11-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220427224924.592546-11-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/04/2022 19:49, Guilherme G. Piccoli wrote: > The alpha panic notifier has some code issues, not following > the conventions of other notifiers. Also, it might halt the > machine but still it is set to run as early as possible, which > doesn't seem to be a good idea. > > This patch cleans the code, and set the notifier to run as the > latest, following the same approach other architectures are doing. > Also, we remove the unnecessary include of a header already > included indirectly. > > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: Richard Henderson > Signed-off-by: Guilherme G. Piccoli > --- > arch/alpha/kernel/setup.c | 36 +++++++++++++++--------------------- > 1 file changed, 15 insertions(+), 21 deletions(-) > > diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c > index b4fbbba30aa2..d88bdf852753 100644 > --- a/arch/alpha/kernel/setup.c > +++ b/arch/alpha/kernel/setup.c > @@ -41,19 +41,11 @@ > #include > #include > #endif > -#include > #include > #include > #include > #include > > -static int alpha_panic_event(struct notifier_block *, unsigned long, void *); > -static struct notifier_block alpha_panic_block = { > - alpha_panic_event, > - NULL, > - INT_MAX /* try to do it first */ > -}; > - > #include > #include > #include > @@ -435,6 +427,21 @@ static const struct sysrq_key_op srm_sysrq_reboot_op = { > }; > #endif > > +static int alpha_panic_event(struct notifier_block *this, > + unsigned long event, void *ptr) > +{ > + /* If we are using SRM and serial console, just hard halt here. */ > + if (alpha_using_srm && srmcons_output) > + __halt(); > + > + return NOTIFY_DONE; > +} > + > +static struct notifier_block alpha_panic_block = { > + .notifier_call = alpha_panic_event, > + .priority = INT_MIN, /* may not return, do it last */ > +}; > + > void __init > setup_arch(char **cmdline_p) > { > @@ -1427,19 +1434,6 @@ const struct seq_operations cpuinfo_op = { > .show = show_cpuinfo, > }; > > - > -static int > -alpha_panic_event(struct notifier_block *this, unsigned long event, void *ptr) > -{ > -#if 1 > - /* FIXME FIXME FIXME */ > - /* If we are using SRM and serial console, just hard halt here. */ > - if (alpha_using_srm && srmcons_output) > - __halt(); > -#endif > - return NOTIFY_DONE; > -} > - > static __init int add_pcspkr(void) > { > struct platform_device *pd; Hi folks, I'm updating Richard's email and re-sending the V1, any reviews are greatly appreciated! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 09 14:17:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 14:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324606.546732 (Exim 4.92) (envelope-from ) id 1no4CC-000468-7M; Mon, 09 May 2022 14:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324606.546732; Mon, 09 May 2022 14:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4CC-000461-33; Mon, 09 May 2022 14:17:08 +0000 Received: by outflank-mailman (input) for mailman id 324606; Mon, 09 May 2022 14:17:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4CA-00045s-GY for xen-devel@lists.xenproject.org; Mon, 09 May 2022 14:17:06 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b29197c2-cfa2-11ec-a406-831a346695d4; Mon, 09 May 2022 16:17:03 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no4Bp-000ApE-Jf; Mon, 09 May 2022 16:16:45 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b29197c2-cfa2-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vHtkmd2lwLYVtO4FWqrbyaVkWxRk4axb2Qa+PPeChZA=; b=LskkzzJmYfWYXPeDfr2IdCaTLR 3hA3AwAXsFwPvw1yZOWysZYMySqHGiMeZOm0bDb2Q6RbJ01gLxUFvc0TPbGO4CNTknFlmWLHek9+j fNw6GIgfVAC2AwFEbPjx/A49ZgvLf4C98a1NhLhauKhl6X16yGXgUhVYkbLiMhd2bcyjc8FRhGAlV b0fE3r5ZHANgTVnzKk9zmgNYn+K1dB4VlK+OrOntysNOTeFSF6+gnM24q5MRGfpCActKh2ASDkGBP /lhbboZ2BaxSaPQdOYRyUWk/WZOTlB1ImMULVLiCjsomiGL/EUGjICR18d54kbZvnwoQGALy9IH6V nZhYpE5g==; Message-ID: <7017c234-7c73-524a-11b6-fefdd5646f59@igalia.com> Date: Mon, 9 May 2022 11:16:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list Content-Language: en-US To: Alexander Gordeev , Christian Borntraeger , "David S. Miller" , Heiko Carstens , Sven Schnelle , Vasily Gorbik Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-23-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20220427224924.592546-23-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/04/2022 19:49, Guilherme G. Piccoli wrote: > Currently we have 3 notifier lists in the panic path, which will > be wired in a way to allow the notifier callbacks to run in > different moments at panic time, in a subsequent patch. > > But there is also an odd set of architecture calls hardcoded in > the end of panic path, after the restart machinery. They're > responsible for late time tunings / events, like enabling a stop > button (Sparc) or effectively stopping the machine (s390). > > This patch introduces yet another notifier list to offer the > architectures a way to add callbacks in such late moment on > panic path without the need of ifdefs / hardcoded approaches. > > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: "David S. Miller" > Cc: Heiko Carstens > Cc: Sven Schnelle > Cc: Vasily Gorbik > Signed-off-by: Guilherme G. Piccoli Hey S390/SPARC folks, sorry for the ping! Any reviews on this V1 would be greatly appreciated, I'm working on V2 and seeking feedback in the non-reviewed patches. Thanks in advance, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 09 14:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 14:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324616.546742 (Exim 4.92) (envelope-from ) id 1no4Kk-0005g5-1C; Mon, 09 May 2022 14:25:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324616.546742; Mon, 09 May 2022 14:25:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Kj-0005fy-Ul; Mon, 09 May 2022 14:25:57 +0000 Received: by outflank-mailman (input) for mailman id 324616; Mon, 09 May 2022 14:25:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Ki-0005fs-0T for xen-devel@lists.xenproject.org; Mon, 09 May 2022 14:25:56 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef4dcd6e-cfa3-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 16:25:55 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no4KQ-000BPa-6C; Mon, 09 May 2022 16:25:38 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef4dcd6e-cfa3-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Cc:To:From:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P7ItdBTC+KXB0aqEwbSMXisX2R2Wb9V+tpF+BUJ3fMQ=; b=afqWOj15+1L7ZOehgz4TDp3T9b MarVdwm0LTk8+i9B4YSy7xFp7vHwG1/w4WbfDff1U5lUjMxS0vk2DRuV0fJ7wbVLLeaMw89VjYM5x WVJwpPzVyva0X5NmUi/i4nuSyMS2YeO8WasLcgi1Y8xImc6fOPpwaaWR9ocIpTn6nZEFaqdopezXx OHjXA1hjw9QuPDRbTOoKOwl5vTqszrquVcmDp1xGYYzEdEOTzOi8SiNmSxJjEIE9o/SJMrBbQG4MO b+UdR8rUhoog9dM2StftHOG35g7VaJwxTPUyd5VBoTJ128N6lfMi0IgW+WU1FzuWQA7pga9h2J0Nf 78MmVTaA==; Message-ID: <260dccd8-a4f6-882c-8767-5bc27576df14@igalia.com> Date: Mon, 9 May 2022 11:25:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US From: "Guilherme G. Piccoli" To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, bhe@redhat.com, akpm@linux-foundation.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, kexec@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, pmladek@suse.com References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <4fe85e9c-4e96-e9d5-9fd8-f062bafcda4f@infradead.org> <7518924e-5bb4-e6e9-0e3e-3f5cb03bf946@igalia.com> In-Reply-To: <7518924e-5bb4-e6e9-0e3e-3f5cb03bf946@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/04/2022 13:04, Guilherme G. Piccoli wrote: > On 27/04/2022 21:28, Randy Dunlap wrote: >> >> >> On 4/27/22 15:49, Guilherme G. Piccoli wrote: >>> + crash_kexec_post_notifiers >>> + This was DEPRECATED - users should always prefer the >> >> This is DEPRECATED - users should always prefer the >> >>> + parameter "panic_notifiers_level" - check its entry >>> + in this documentation for details on how it works. >>> + Setting this parameter is exactly the same as setting >>> + "panic_notifiers_level=4". >> > > Thanks Randy, for your suggestion - but I confess I couldn't understand > it properly. It's related to spaces/tabs, right? What you suggest me to > change in this formatting? Just by looking the email I can't parse. > > Cheers, > > > Guilherme Complete lack of attention from me, apologies! The suggestions was s/was/is - already fixed for V2, thanks Randy. From xen-devel-bounces@lists.xenproject.org Mon May 09 14:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 14:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324626.546754 (Exim 4.92) (envelope-from ) id 1no4Rq-0007EO-QM; Mon, 09 May 2022 14:33:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324626.546754; Mon, 09 May 2022 14:33:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Rq-0007EH-N8; Mon, 09 May 2022 14:33:18 +0000 Received: by outflank-mailman (input) for mailman id 324626; Mon, 09 May 2022 14:33:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Rp-0007Dt-UI; Mon, 09 May 2022 14:33:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Rp-00077s-Pg; Mon, 09 May 2022 14:33:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4Rp-00060A-8R; Mon, 09 May 2022 14:33:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no4Rp-0002At-80; Mon, 09 May 2022 14:33:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2junC6ik0JAhvpRKQEf5M4wphGLyyhZgXLVvh452lc0=; b=OWHOic2wajDiAezrxt/EXK5DI8 mDnp+qmsyRxwATUFuxad3L/fAub0J37EXU90fU7RstzNLkcCIjBDtDnSJKXp8iLGY1THtWaB9nuSF V33ahaKdxsOXpjVgAVMjIrge1L0PcHzZ/JcQQV+bJNnMCI6TfoDPiAXcQ4YnMo4FgdmE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170264: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1d72b776f6dc973211f5d153453cf8955fb3d70a X-Osstest-Versions-That: linux=4426e6017f73bbbd65270965ecc11b6b3ff4af4d From: osstest service owner Date: Mon, 09 May 2022 14:33:17 +0000 flight 170264 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170264/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 169782 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 169782 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 169782 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 169782 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 169782 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 169782 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 169782 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 169782 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 169782 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 169782 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 169782 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 169782 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 1d72b776f6dc973211f5d153453cf8955fb3d70a baseline version: linux 4426e6017f73bbbd65270965ecc11b6b3ff4af4d Last test of basis 169782 2022-04-27 12:13:13 Z 12 days Testing same since 170264 2022-05-09 07:12:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Ford Alex Deucher Andrew Morton Ariel Elior Borislav Petkov Bruno Thomsen Christian Hewitt Christophe JAILLET Christophe Leroy Chuanhong Guo Cong Wang Dan Vacura Daniel Borkmann Daniel Starke Daniele Palmas David Christensen David S. Miller Denis Efremov Denys Drozdov Dinh Nguyen Duoming Zhou Eric Dumazet Eyal Birger Fabien Parent Fabio Estevam Fabio Estevam Florian Fainelli Florian Westphal Francesco Ruggeri Greg Kroah-Hartman Guangbin Huang H. Nikolaus Schaller Hangyu Hua Hauke Mehrtens Heikki Krogerus Helge Deller Henry Lin Hulk Robot Jakub Kicinski Jan Hoffmann Jernej Skrabec Jian Shen Johan Hovold Jon Hunter Jonathan Cameron Jonathan Lemon Julian Anastasov Karsten Graul Kees Cook Konrad Jankowski Krzysztof Kozlowski Kyle D. Pelton Leon Romanovsky Lin Ma Linus Torvalds Linus Walleij Linux Kernel Functional Testing liuyacan Lv Ruyi Maciej W. Rozycki Macpaul Lin Manish Chopra Marcel Ziswiler Marcelo Ricardo Leitner Mark Brown Martin Blumenstingl Mathias Nyman Max Krummenacher Maxim Mikityanskiy Miaoqian Lin Michael Hennerich Mike Kravetz Mikulas Patocka Miquel Raynal Neal Cardwell Neil Armstrong Nicolas Ferre Oliver Neukum Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Pavel Skripkin Pawan Gupta Peilin Ye Pengcheng Yang Ronnie Sahlberg Samuel Holland Sasha Levin Shawn Guo Shijie Hu Simon Horman Slark Xiao Soheil Hassas Yeganeh Steve French Tainping Fang Thinh Nguyen Tony Lindgren Tony Nguyen Vijayavardhan Vennapusa Vinod Koul Viresh Kumar Wang Qing Weitao Wang William Tu Willy Tarreau Xiaobing Luo Xin Long Yang Yingliang Zheyu Ma Zizhuang Deng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4426e6017f73..1d72b776f6dc 1d72b776f6dc973211f5d153453cf8955fb3d70a -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Mon May 09 14:45:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 14:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324635.546764 (Exim 4.92) (envelope-from ) id 1no4dx-0000U7-53; Mon, 09 May 2022 14:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324635.546764; Mon, 09 May 2022 14:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4dx-0000U0-1r; Mon, 09 May 2022 14:45:49 +0000 Received: by outflank-mailman (input) for mailman id 324635; Mon, 09 May 2022 14:45:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4dv-0000Tq-OG; Mon, 09 May 2022 14:45:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4dv-0007LT-J7; Mon, 09 May 2022 14:45:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no4dv-0006Gj-Av; Mon, 09 May 2022 14:45:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no4dv-0004gM-AU; Mon, 09 May 2022 14:45:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8hdZCwuIJ3woMNnmyB3TDjWlrhYOgFS+1lUh6LnIuxA=; b=pIk4ebNudVrBibR069EaltGUO7 v1qbekOZqEexeAAVms+UJ217AtgxFf4EHhVY1IlUeNKwcwvFXSUbm1PjnF6/9h2uLu9rqRtoMsWck oxl3ugiFSwhmIYTEZqpmtK1KZ3bZZt3LIRWELMGMElfD/Bhp+zmPehq0+0XeyAGpfmfk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170271: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 14:45:47 +0000 flight 170271 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170271/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a658ed30e51f2b2024d7bf8d2aa8be2dfa0b02a2 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 896 attempts Testing same since 170267 2022-05-09 11:41:59 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6180 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 15:22:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 15:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324643.546775 (Exim 4.92) (envelope-from ) id 1no5DR-000519-V3; Mon, 09 May 2022 15:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324643.546775; Mon, 09 May 2022 15:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5DR-000512-Rq; Mon, 09 May 2022 15:22:29 +0000 Received: by outflank-mailman (input) for mailman id 324643; Mon, 09 May 2022 15:16:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no57h-00044C-9I for xen-devel@lists.xenproject.org; Mon, 09 May 2022 15:16:33 +0000 Received: from esa5.fujitsucc.c3s2.iphmx.com (esa5.fujitsucc.c3s2.iphmx.com [68.232.159.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff4c7314-cfaa-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 17:16:28 +0200 (CEST) Received: from mail-os0jpn01lp2110.outbound.protection.outlook.com (HELO JPN01-OS0-obe.outbound.protection.outlook.com) ([104.47.23.110]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 00:16:12 +0900 Received: from TYAPR01MB6507.jpnprd01.prod.outlook.com (2603:1096:400:a2::7) by TYCPR01MB7578.jpnprd01.prod.outlook.com (2603:1096:400:f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Mon, 9 May 2022 15:16:09 +0000 Received: from TYAPR01MB6507.jpnprd01.prod.outlook.com ([fe80::dd9:8ea4:f7a3:bba1]) by TYAPR01MB6507.jpnprd01.prod.outlook.com ([fe80::dd9:8ea4:f7a3:bba1%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 15:16:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff4c7314-cfaa-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1652109388; x=1683645388; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xS2ZDM92CvkpLSnJq7Jznk26/ZMDw29ra/drEifi+4M=; b=Zx3UKgDVWtxYwpPjPoDluawbvsFRKqPq+T5iYAQkwfALEx4o/268puXs ot3fAo3xla+fpGjEPxcAzTecBGse+qqqb/MLDClw6VDTkfGxtagycSW30 IC+6Iw68bI92qkijkPN4hWT4uUh963JmP1vqY1XfT/van65QWuTUaCrd7 OUFnkQeFDOHhxq3AMah3SD8psSGMe+KOhGwLe4IPlXuABb9Jky92V7e2z UUiaNaiK9FvqSKWZI9PX3ukgfRP+C2Gg/ecaSx6whDCNku6DokitSC+Ed nxmlAS5/UeYe5Uf1LnnrJ8Fuj1RIQE9Phnuj+RIGMX3pyvYcRUj74rnV4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10342"; a="55509155" X-IronPort-AV: E=Sophos;i="5.91,211,1647270000"; d="scan'208";a="55509155" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KP0CFKYRNmTXTmwL9JG0oC4GQgkB/pl4TAXCxaquTQi2mpfikgwQYy0i8q2i6vPeVpaH2GuK7gBuR63t1JW1LUNFxAjNVersbC9h8TdiBjflezHpU53Q82lnXPLv4wirYyJRKEuA73ZQCrb57ZakIuUVwqcJ+JrPKcYeATrnxhN28xpHXiJO2rffSK1Jw5uxRkQfFPudZpwdXRfmJr8fD9Fp4hSxcYDf9d2dYPWTHymwX3/ZrvUs3NQQnno5t2u1Tkf53IqwaAxjVtkhkHSIHVvIL8BkcyVOYUH1NXbXYQQxKeT5PLbIV2LxAq3TnGTE4TncUGKkynpMGLIjrmygdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlXVxI2FnzGbvIu/CWm8gKBJ3ZWwolqRQs9xSfL0o60=; b=H+1Tk6iUFRaot1orKC1GRgl1SqDJXk5D2hXPcq48LhPh7gXvRwAju3ZJFbMzj6OjqSUOxrUqwP5QxUHlUtIwQf9Sbv11I8FuhMTDnHm9jTlJ8XnYR8eRZuGiGabL9xVnbfLrXmvTitKevsolEAyiCz8BKyZgayo7SIJbDtYciudVYTh5smc2WUV4/Xf5hw9rGx7ax2cfKXWimUANarDTZNV/KntgpM+JGW52DuY0ow3ik4XUuMIis57FWFq1Ij/VGkKE6W9VYUcyujJ6hW+y+zp3dDojEsR4nIytU/riRvA36esOaKgCTxTbJmvx932z0jUkCFfaf4RSuOsaN4+Itg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.onmicrosoft.com; s=selector2-fujitsu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MlXVxI2FnzGbvIu/CWm8gKBJ3ZWwolqRQs9xSfL0o60=; b=h3jSOTQ/49e3CdAkGQmnT0kRfsZxVeHwnmHFjQIrg5SEwgadX6SIM218KZ4TTXnCicgDCVAuNJ5K36tGTV1PjiR6VVO4vPyaEXnMWkJYWxSMBENMBLbvoa90+8Vm3enWQ2GtCp7sSMFxA1XVsdggp5hIBlPRt0gWqyL7U6Qy1YM= From: "d.hatayama@fujitsu.com" To: "Guilherme G. Piccoli" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "coresight@lists.linaro.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , "d.hatayama@fujitsu.com" Subject: Re: [PATCH 24/30] panic: Refactor the panic path Thread-Topic: [PATCH 24/30] panic: Refactor the panic path Thread-Index: AQHYWooYRc5K2GmPwUyqsvUuWmK42q0WuNLD Date: Mon, 9 May 2022 15:16:08 +0000 Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> In-Reply-To: <20220427224924.592546-25-gpiccoli@igalia.com> Accept-Language: en-US, ja-JP Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=True;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2022-05-09T15:16:07.522Z;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0;MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; suggested_attachment_session_id: 7401546d-aea9-ffcc-3451-b3d59ad5888b authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb59992a-950f-4d9b-bb1c-08da31ced84d x-ms-traffictypediagnostic: TYCPR01MB7578:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /EPiPQ1iE6MAZZ3/WceQFfMaYOr3hQFI/B3njzUVTDpd2qqrdleVcVSpf2FVTxNNtbalFncurAfPSJh1TGekcVWhzGdngBQ1+1y4fpWxXGD4YbqP27hsV7t4f7edAJIa9NqvJ6n7aibYfCzJx3iCrgiakRvsQh+iG5l9bKWYIK9lR7U4sye5Ffr14bJM2DpODKZvgppK8wyMgyMnjj9zz9lKGpjtILIclyn9Cfxq7iI638lUEA+mX4g4zSn1iKbKIJuWOJ3wgQ4jYqCBsSjpaxF1HlO5mWp7q0WJMtlCD0BjB0ch6tZlY4AQFxnYjeUGNuxeoCOm1YjAXRB9jem+BLs2lLj2CUbfNKym9+HxzC2Pv6xmsq0K3lYUsZZPcvE6+2d0lcxXWKVWm7YLPqOKlRiwnw4OI2vDsNJI4/8LrtAiqLYsnmqIlUTgnHPK7io6xN9jXchkeV3Q9sjEe4hhdahLh1dwAB8LYIGr617lu+R8whOHRJa4M5tWuF2EvZ62teL7MYNxzCHbmiACl3mgo5ShSQ0DDxRTasN1jxNptwPdxEF7mHZIjH/caTRYuN3gomF2nisqKzgGg4spIBbsN2pZXB2htS0vpAAc+pFjcEK/Tyjvjsahu/O5fdELQCKYR+Lwd1Bwj2cvdOJquN0ygm/3FOS0+8mAEr4IZfbABNALU/lSCwrulCmPjai/zOTT7PqtftdxjvSq3wSowSe8pQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB6507.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(5660300002)(52536014)(85182001)(86362001)(38070700005)(83380400001)(82960400001)(122000001)(508600001)(186003)(6506007)(7416002)(8936002)(2906002)(107886003)(55016003)(71200400001)(7366002)(26005)(110136005)(8676002)(4326008)(9686003)(54906003)(33656002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(316002)(7406005)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?Q2ZoaFpvc0xSMVIydW9vRDUvemw1eXFIbUlmTmRuc0dEdVEwZzdFcTlC?= =?iso-2022-jp?B?MnBtd2NvZ2tkTVRnYzZHdDRGSi85MXhRNGhoV2hSb2daYm1hTm94RXJx?= =?iso-2022-jp?B?THdsTjhIUDg4c21tTzdSYzZ0c2l3VTFtdTRmWTZyM3pMV1BZV1E4YnF5?= =?iso-2022-jp?B?KzNibHMwSGUrQ3RTK2tXemw5VEZQN1FaUXhONTRHSTBWU2FqSEJwLzRQ?= =?iso-2022-jp?B?N29OTmV1bkIrR1huOVN6L3hBaURRRm9Wb21vMXlwNjJiSnRzbFNBbDJS?= =?iso-2022-jp?B?Kzgrd1p5bXBESGdrakpDUFdIa1pyNTdRRFp6RnE0YWpEcG4zL1RtY2tk?= =?iso-2022-jp?B?amlvbUpJNTZOcTlkWVdsb2dFdk94OXdRbHM1WDF6Wkd2Zk5zb09rTlRD?= =?iso-2022-jp?B?M0YyOEVaaSt6dUdwTldNRU00am4relFSbm4wSVNuYktiMWszMTRGUU5k?= =?iso-2022-jp?B?bWJ3bWJqMVA3TE9kWENrdE5QQUp2aDZ6SjhaRFRQd2tQUVVQUXI5V3po?= =?iso-2022-jp?B?dGQzdGFTQkxXRy8yRW5RK2IwR3l5RHo1M1I0bmdYa1dhcS9NQ3luV013?= =?iso-2022-jp?B?TTlXYmgzSXl1ZnVVMGlOc3dMTTFFbXhkYzJldmZRL3NOZVVzU2RucDFU?= =?iso-2022-jp?B?TjNXengxZ3I5UFY3amdYeDN0ZDhlTnFpYkVpUXRLaTlNaGNKc2JsZGlz?= =?iso-2022-jp?B?S0tSQ2NKMkdqQzlud0hUSEJ5OXM2TkJnN3A3NG1TKzJCdG9NWWhPQ0pl?= =?iso-2022-jp?B?ZlRQSDBjdU1WWW5QOEdkbTlDYjF5YkhrVmMwcnNoMndIemRXZnRRNm1O?= =?iso-2022-jp?B?aW45cWFXVDZLSHRKVm9JVU5ROWJYNFV3aHlvNFFXTkVla013NTN1c3Zy?= =?iso-2022-jp?B?NTZsbEhFRE1BY1NQdnQreVU3dGlmMm1MN3ZYQUIzRTMrSG9CaC9rMm03?= =?iso-2022-jp?B?UHpJN0k2Nk0wWkcrZEJkZTJ1czZoK1JNZEY4VGdPWmEzQ1JJSDV1Q0xa?= =?iso-2022-jp?B?QzNveU5nWmIwc1IyR0dRcDZmb2VESHY0MWw0VjBvRnJRNG84WGpnbmRp?= =?iso-2022-jp?B?NWpwSUR2WXljdVA3OGpyNHZGcW10WjdFdUlFYWI5dlN1ZnhPZncrNGNw?= =?iso-2022-jp?B?NVhDNW1NbU1iQjZxRU1sQktJMjNrZ09rMWRmbWo0eWd1Y21Pd3FUcGlU?= =?iso-2022-jp?B?TzhWNmlTbUI5djY4eTRNSStjekdqcjc2QlRPSGp6bzY2LzdKRXkxOUVN?= =?iso-2022-jp?B?clJRRjhsbWFKT3F0TjY2cEJqMWl1aTdnOGZPOU8rN1d4VnIza2wxOHpw?= =?iso-2022-jp?B?YUJscjlYOTRjSVE0VXVqUUNiSHVYRE44QmRSUGV3WjJxT1JOSkxjeVVR?= =?iso-2022-jp?B?SDVDc1ZlL2VKb2xxUFAvR05SVC9oOVZVUVYrU1BTUlhLb0p2VEN6WG0x?= =?iso-2022-jp?B?dHcycEVHVmEzRmpjQldpWHd5dXdnTFBUbi9FQkd6NTg5VTJuMGJDQnZ2?= =?iso-2022-jp?B?NlBKb3hrQThvTkpoK2xPU1kwSUg1MDhvbVlHOWpIamR4OXJhQmxEdDBx?= =?iso-2022-jp?B?MEdFdXJXYkpCaGwrMmJBaUNaUnFVL2xKY2lpY0p6cHhpNFdTNG9MUVIv?= =?iso-2022-jp?B?Q0RMUTZJTmVKWEVmMDNrYnFOT3l2aUFzTmFxV09kQSs5eCthQXkwdmsw?= =?iso-2022-jp?B?SGRsSnkzK3c3V3N1V0FaYVFFMGFKTG5FUU8rTmFVT3N1ekx0cDBVbDlv?= =?iso-2022-jp?B?QXV3UTRCTlN1WGo2MWQwSVo4c2VGUnk0aVNNNFJzd3BNOVB2ZCtMWmxP?= =?iso-2022-jp?B?dGlzVjVNQnQ2b01aWXhRdXJtRGVJWGZsSXBJZ1VGMWlFR2NESjFTcVlw?= =?iso-2022-jp?B?M1JELzNUd013T1ByVGF1Ykh0Nm91MW5xai9ZUU5lRjFsdHdEQ0NtUnNR?= =?iso-2022-jp?B?L00xTkhpaithV1pYY1krR05zUTZYTFZPUk9RU0xtSkhhRmhpdFc4RGNX?= =?iso-2022-jp?B?eTFpMnd0QlloT0plSm9NdjBuakFweWUwRGtqUjVsNVovRkRob0c0TDQr?= =?iso-2022-jp?B?cW1PZ3FYRHBtc3Q2c1FwOFR1Lzk5czhMenVER01OZm9Xa2VwSjM4a1Vm?= =?iso-2022-jp?B?OUFBTFpRdTBiY3lqTXIvVHNhN2JWZHVra2dTTFhaTzRFSmh1c0taRERB?= =?iso-2022-jp?B?YTdqeGI3dWRDYTYzR1lYcTF1T3dHZ1RGWXYza1cvM0lxUGtldDhmUVZv?= =?iso-2022-jp?B?c1dJelE5d1hSV3hybS9VUVN4aEh0aTRPSDd3OElVZVdaSUlxY2wwd2lR?= =?iso-2022-jp?B?Slh6TFJjMXMrN25OaG9ibS9hQWZkYmNVb0RFZ1d0aFZLcU5lNUpzV1lX?= =?iso-2022-jp?B?YjBEZlRDZE1CeGMyaWRMa1dvT05rVW9RUG1WOUl4aHRkenoyTjFXaitY?= =?iso-2022-jp?B?YW1oQ001bUIyRFJYdUJTdzlKekt0WndWSEJpaXU5dzhkVEpOb3p4TzIr?= =?iso-2022-jp?B?MUdoTXV6ZVIycy9nblliVHY4clRkRTNlcVNwdWhhQWM4UlBFTDZBYmw0?= =?iso-2022-jp?B?ME5aQThQQT0=?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6507.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb59992a-950f-4d9b-bb1c-08da31ced84d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 15:16:08.8030 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q5IRFdj2tV7IAxoGvUQ3KW79KqhlLrLxHCiqQH9LHk/aZve0Mz95uDPlSCWwe/uJV5hchYymXmHVnJXclB022HSy1r9hKQtbFufztomtIsU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB7578 Sorry for the delayed response. Unfortunately, I had 10 days holidays=0A= until yesterday...=0A= =0A= > .../admin-guide/kernel-parameters.txt | 42 ++-=0A= > include/linux/panic_notifier.h | 1 +=0A= > kernel/kexec_core.c | 8 +-=0A= > kernel/panic.c | 292 +++++++++++++-----= =0A= > .../selftests/pstore/pstore_crash_test | 5 +-=0A= > 5 files changed, 252 insertions(+), 96 deletions(-)=0A= > =0A= > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin-guide/kernel-parameters.txt=0A= > index 3f1cc5e317ed..8d3524060ce3 100644=0A= > --- a/Documentation/admin-guide/kernel-parameters.txt=0A= > +++ b/Documentation/admin-guide/kernel-parameters.txt=0A= ...snip...=0A= > @@ -3784,6 +3791,33 @@=0A= > timeout < 0: reboot immediately=0A= > Format: =0A= > =0A= > + panic_notifiers_level=3D=0A= > + [KNL] Set the panic notifiers execution order.=0A= > + Format: =0A= > + We currently have 4 lists of panic notifiers; bas= ed=0A= > + on the functionality and risk (for panic success)= the=0A= > + callbacks are added in a given list. The lists ar= e:=0A= > + - hypervisor/FW notification list (low risk);=0A= > + - informational list (low/medium risk);=0A= > + - pre_reboot list (higher risk);=0A= > + - post_reboot list (only run late in panic and af= ter=0A= > + kdump, not configurable for now).=0A= > + This parameter defines the ordering of the first = 3=0A= > + lists with regards to kdump; the levels determine= =0A= > + which set of notifiers execute before kdump. The= =0A= > + accepted levels are:=0A= > + 0: kdump is the first thing to run, NO list is=0A= > + executed before kdump.=0A= > + 1: only the hypervisor list is executed before kd= ump.=0A= > + 2 (default level): the hypervisor list and (*if*= =0A= =0A= Hmmm, why are you trying to change default setting?=0A= =0A= Based on the current design of kdump, it's natural to put what the=0A= handlers for these level 1 and level 2 handlers do in=0A= machine_crash_shutdown(), as these are necessary by default, right?=0A= =0A= Or have you already tried that and figured out it's difficult in some=0A= reason and reached the current design? If so, why is that difficult?=0A= Could you point to if there is already such discussion online?=0A= =0A= kdump is designed to perform as little things as possible before=0A= transferring the execution to the 2nd kernel in order to increase=0A= reliability. Just detour to panic() increases risks of kdump failure=0A= in the sense of increasing the executed codes in the abnormal=0A= situation, which is very the note in the explanation of=0A= crash_kexec_post_notifiers.=0A= =0A= Also, the current implementation of crash_kexec_post_notifiers uses=0A= the panic notifier, but this is not from the technical=0A= reason. Ideally, it should have been implemented in the context of=0A= crash_kexec() independently of panic().=0A= =0A= That is, it looks to me that, in addition to changing design of panic=0A= notifier, you are trying to integrate shutdown code of the crash kexec=0A= and the panic paths. If so, this is a big design change for kdump.=0A= I'm concerned about increase of reliability. I'd like you to discuss=0A= them carefully.=0A= =0A= Thanks.=0A= HATAYAMA, Daisuke=0A= =0A= From xen-devel-bounces@lists.xenproject.org Mon May 09 15:35:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 15:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324650.546786 (Exim 4.92) (envelope-from ) id 1no5Pj-0006dX-3l; Mon, 09 May 2022 15:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324650.546786; Mon, 09 May 2022 15:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5Pj-0006dQ-0w; Mon, 09 May 2022 15:35:11 +0000 Received: by outflank-mailman (input) for mailman id 324650; Mon, 09 May 2022 15:35:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5Ph-0006dK-3m for xen-devel@lists.xenproject.org; Mon, 09 May 2022 15:35:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9948effb-cfad-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 17:35:07 +0200 (CEST) Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 11:35:03 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by SA2PR03MB5820.namprd03.prod.outlook.com (2603:10b6:806:114::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Mon, 9 May 2022 15:35:01 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%5]) with mapi id 15.20.5227.023; Mon, 9 May 2022 15:35:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9948effb-cfad-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652110507; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=jFUZginQskNjPnmtkncsklCnP5tc+S/vTS+tOD5YSHk=; b=SkSvSCo45qDkEhIeUl8OMD+g0sny7PMcYgb4gWAzdA8NElMy7MDDi2KH X7Uiv2x/Q9+xTEGJUWQRL2UYQM9KbsXL3xHDidbbpF7XTzKSQk6+txU38 LypD9n/d57wXh6yYnHoEAdTUc98+IQwlOKZqhLLTX+LI0UKXhvuxQ2lg6 k=; X-IronPort-RemoteIP: 104.47.57.175 X-IronPort-MID: 71304678 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FFM6qKD74z+ifxVW/z3jw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk DNbHCvTJK7JMVJBSKlzYNy08hgP68Pcx4MwTAVkq31mEyNE9prOCNiUJ0v9ZnPKcZCfRR8/t ZoVYICbfJxkRC+A+03waee49XV3ha3RLlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIiuD6 Iz5/5XRZ1X9hGQpPzNKuq6P8Eplta6v528W5QVjaaEXsAfSmUdOAcNEL8ldDZdZrqq4vAKeb 7yepF1s1jqBp3/BMvv8zvCjNBdirof6ZWBisFIPM0SZqkUE93VaPpoTbqJGMx8K02TRxrid9 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii 8UxSAR2dVfjbCF0F0oTNs8Ckrm1gWjHbGgNwL6VjfJfD2n76iVUieGoHP+LP9uASINSg1qSo X/A8yLhGBYGOdeDyD2DtHWxmuvImiC9U4UXfFG63qcy3BvPmSpOV1tPCgbTTfqR0yZSX/pwJ ksO9SdogbU08EWzZtL8Qwe5sDiPuRt0t994TLRhsF3Tlfq8DwCxGWgEEABKYYYfnugLFQAr8 EaxgM33Gmk62FGSYTfHnluOlhuWJCMca0ELYyQJSQ8Yy9D5pcc4iRenZsZuFuu5g8P4HRn0w iuWt24uirMLl8kJ2q6nu1fdjFqErJXTUhQ84AmRW2u/9x54f6asfYnu4l/ehd5fIYffRVmMu lANgc3Y5+cLZbmPniGQROQGHJmy+u2IdjbbhDZHHYQl9jmr026ue8ZX+j4WDFxyLs8OdDvtY UnSkQBc/pleOD2td6AfS521I9Qny+7nD9uNfs7Tat1Cc51gbjit9StlZVOT9231mU1qmqY6U b+Xf8+jAncdDaVP1yetSqEW1rpD7iIx32TIXrjg0g+ql7GZYRaopawtNVKPaqU16f2CqQCMq tJHbZLVllNYTfH0ZTTR/cgLN1cWIHMnBJfw7ctKauqEJQkgE2YkYxPM/Y4cl0Vet/w9vo/1E ruVAye0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:kp/K06vH9+s0ZuDQHBR8whDb7skC2oMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKdkrNhR4tKPTOW9VdASbsP0WKM+UyGJ8STzI9gPO JbAtBD4b7LfBRHZKTBkW+F+r8bqbHpnpxAx92utkuFJjsaCZ2Imj0JbjpzZXcGITWua6BYKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/H2VwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5p+7Y23+4gowwfX+0SVjbdaKvi/VfcO0aWSAWMR4Z rxStEbToNOAj3qDyeISFDWqnTdOX4VmgPfIBmj8DTeSIXCNUwHItsEioRDfhTD7U08+Nl6za JQxmqc84FaFBXagU3GlpD1v4EDrDvKnZMOq59ks5Vka/pWVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlJhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OGDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowlLau3ieffFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vd/HmZw == X-IronPort-AV: E=Sophos;i="5.91,211,1647316800"; d="asc'?scan'208";a="71304678" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U2CXBphqbPUDWF005CHglklJDzfviSIjePQBmDJIMIpZVm63MLTwLmVfCDFS6NrhATp83JWozn7iPG/nrS8qcpkkGOLTDuV5DSVyEPi6pq5aDe2xLhBEsdD4w1mdTALikkbBA8o49FgY/ofZEmmRzjZKUIi23EpOjnzSNSOAfS7tt1G6I+LRdDx/zK5c7vF7npd+T3fzYQ5najDOpVz3d859sYHLAeKKiZT+qlr2rqMQVocOPlRx3FLOgpjgdAJJ7eaDMlm/X8WfsSqMxkhFckBCN1F3jmWa8IDEeFNx3ipOISi7L2LHHnRxOAaETXyYih5Ysjpy8ejxdz9oDVna+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQloM8hPI4fMtoJMVnArrw57I8qAMa/XGbQPEd9+IVk=; b=Ef71g8suOYTUr4GGnXiadPDoWq7zW+bm1T0t+iQPauA0anAbv5C9SuBimnDUdAMXvlfj4nIJb+Wyanra4BZv7HfNjF7IVdJiRTsTiuBGKgr38ge9wAWlMiu1s6+61xx5danXgDNnN1WGvqxEK5txDCDG6po9/hTbKA2LWj91B9esmjQChYDmzYSO5KNjHSRW/Pxl0j2nPzl89xhqvGVlKv+mCfmi/4NPc9JVOmQPt5lO9BFKm28yqngggCiutTfTB6Wnig7dw7AJZE4bShgWWHwdO/qAxbYDW4Z2GR2ulOgPFMX/hTjn02hGOHJMGtGF46DjQ5tignOh0ef+3bpqEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQloM8hPI4fMtoJMVnArrw57I8qAMa/XGbQPEd9+IVk=; b=AR8NYfm7IAtEKgni7eXbxC2jta5PqgaFHYAfX6vU42abJxat0AJAMSjxivwrUYz0EHylmSq8B606r3k8ySSASW/lEcjJmRlU7CkX80heJv6T28KoTgFW4fYScME+QGU0aI4s6zLm0ovE8DpWa6TCPBoL78iNN9CCTwOdMNTUuHQ= From: George Dunlap To: Luca Fancellu CC: xen-devel , "bertrand.marquis@arm.com" , "wei.chen@arm.com" , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Dario Faggioli , Juergen Gross Subject: Re: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time Thread-Topic: [PATCH v8 4/7] xen/cpupool: Create different cpupools at boot time Thread-Index: AQHYYUDkkyUfpJQf80OfJO0ylO5+mq0WsiiA Date: Mon, 9 May 2022 15:35:00 +0000 Message-ID: <71190A8E-EC33-4A72-97A2-CE9EC69EA0B8@citrix.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-5-luca.fancellu@arm.com> In-Reply-To: <20220506120012.32326-5-luca.fancellu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 81ff1508-a0d4-4c28-02c8-08da31d17af6 x-ms-traffictypediagnostic: SA2PR03MB5820:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NoAZVkkAER6PrhSI7gBg22MZFPAoAUh5hqaIwcEUH1By/890uQV2p1ydtiCXm70ls+8U64iRz2YAC5UkSXmUlwB2LC22k4cPUR1IsDMhqJUZv8uaEIjI0jPBGJxK5mudr1OKZRRg2sgttAbZJAm63dluvvBkAdNDzHBn9xgIrE0KDxEDFxHIe3NTAtLBEOGR/Um1bCsnJYk7IfQ766x+QIJq7E/Q2t7F9V/crH2Nyy23jcRJ7OF1710QTO8Mmcq0q7qGPfQmo+nfou+Uyujp0kev2SavqfUt2CRMmP7hYJCzca+w4SBvBK7sUJVLVwV2tZalcJhmx/UzzL4/TxL4oK22t2E2xzEuk3T8GJbexso1Uo14tyAHGCpjoVwF4946WjC6aWWASPL0NY9DTNG6vCSCyo18NLwdNWLOkVG8Iw0Pv66MMv06jVCjt+2wlyMnYRAH0sI70VUNDM27nnwFCaO+d5UnPNURHtK0oAnu8k0XQPfgS8MoP15wivAPO4/JOk0UgTVZm52ijSfbQH7Zps4dqUxcNL4XsNrf77IDHT7RfQrtqE04uU/LUIUbqegNNnFf8cKcTLE3CNUqbAkpQoTC50oIgZPzC+t/dqCgXXAlhQ7zDJ/bB3LFBFPpq8RK4iFZt0MxixBt3XN2gWqv5rYL3L/Kfuql9UjO5ukWZZZy4KV8HoIO8WgKlv1LRzQULgUIWvUNOPWXdJUpwmuiNY6HnPcl44KQ5vhfDZdd/lbBnQTtjob5CRMAPtg1CMEd x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(33656002)(2616005)(38100700002)(82960400001)(86362001)(91956017)(26005)(5660300002)(36756003)(53546011)(38070700005)(83380400001)(6506007)(8936002)(7416002)(64756008)(66446008)(4744005)(508600001)(6512007)(66556008)(316002)(6486002)(66476007)(66946007)(76116006)(4326008)(54906003)(8676002)(99936003)(71200400001)(6916009)(186003)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tNGmZOlgJrWXJa/Mum1jCYBSZH2yFcvblQlVC7GTKtI/Up8jDkM0yJdMr3q+?= =?us-ascii?Q?5XnKu/vS3lhyanbIwrcNxiTUbZCxpwhia2H05fLQIcsKQH4jjsgd3ppYGNvw?= =?us-ascii?Q?cnArZg2Q+cNc3YXIQ49HbUwt1g+MAuj8DjvqmDUskJGT9JkiAYzpdLBt8aMW?= =?us-ascii?Q?gbedxaDKyy8ktssvZ++s+X5NNQ6zP6U3ucovJoP9ftExtpQeyWN9+SDicejv?= =?us-ascii?Q?tG6fE4R8qpThRuOjVmAaHZ4chftQ6hArlHnSlUCyNIUpThGGBqtOP+czBgGb?= =?us-ascii?Q?pc3Px6b5c4Ty3ItkCIR1XsMRm6H5G69Fd352rmPqglBxk3/Ix6PdMcTkqjVC?= =?us-ascii?Q?SedvZJEPW2iOo+4KNunFz6p6tW19iKNV/Y41eXPrmcq6Cl+C6oWhreWsPxug?= =?us-ascii?Q?UEW2HfA1+jJjPG4RXXmpokfqH12/L2og9vT8dhRGnvGR9VX0UtILZKNXTRlW?= =?us-ascii?Q?mpvDKkiZYYTQR6mn2/o2gPd5WU8MmQUwvd1d0d24JzZkwAv6vDZ5B6LXYvaz?= =?us-ascii?Q?rrK7VdHlxPyJ67AwF+cHFCnx4VRKoaAid1slkfQtpp7jjqsN+O0lISNFEXxW?= =?us-ascii?Q?8zi9d5AXl+AZXx1FQXJ3FM6FevBB07C3QSyC5LDSAKYli6xID5colFQhdHPK?= =?us-ascii?Q?p+ATCNvVbBu/JXtkzHZ+SS+2VKf9lrZnAE4tLU9eqUdaIt4vx4NtAKzOI4e3?= =?us-ascii?Q?GpBqpci+FxZzX+KxKykFTBu6MG8O7bOJYG73ktC/YrSa4XhnTOSpxqqN12/B?= =?us-ascii?Q?YEE/xMkFYUqiNMf3lnoJG6CkiKO6VMbtHUcMmH55YCGK4rE59c7UYNVGJgiT?= =?us-ascii?Q?+8jTLqLxC8U6qVdWcS1OLfA4DKpbPEd4ctr13UqPzvQCa6Q0TCTI4usc8/rR?= =?us-ascii?Q?LzGlFzHKmdJddihIcCrTVgAMHetBJBAatv09NQ0ftuG5zUUBfjAvlSUcG1IM?= =?us-ascii?Q?f7zJopCLfoHjtQeVqyG3/kFlZHN4W75wxNmtLNXx4X4aIOQUKUOGSwSaCtst?= =?us-ascii?Q?GVrv8nkCpDHsWNE/AP78YriwGO+GbtZgU0l56KVnpP6qKLHyxWhdt0SnnXlq?= =?us-ascii?Q?ptPS4SEp+d7040dPUWkWMaRDmm8wl83TnRpeherQkc9hvZganJeJUYJ0jL+o?= =?us-ascii?Q?PyZPlukBCSulU4Pwq5UI3GlnpZozGcOeHOZHo6TFgTGjdjSvymjIljCtyfVW?= =?us-ascii?Q?SuRILhtESZjoPuN89SsyE5RezITZCwRdHb9S9dYbf/zWesc/EsPxo930cefM?= =?us-ascii?Q?GXpDg+X3u+EeNjDTEG4MEYoTHocTXLGUYYqZZjh3rQSEPIXcOQftiBWsCwBe?= =?us-ascii?Q?EKaSdHoRzuj4bXJtOC7WwX4oL+x5ay2uPKgZwqPY8pvZ4PVCpsE+Qqr14E9k?= =?us-ascii?Q?6HaKhEKLWpJArbagIeAwVg1gGlGW4TSGXXm6CIGgt/3oZmDWrmjIX3/XWEyB?= =?us-ascii?Q?csJzTRWWl5zBhcG29+k2l4CuqEars7voTelTmh6iflhpSa4YIxMgA11ncnpe?= =?us-ascii?Q?bjTDElgWwiT/dKnF5YonHTtbOeQGjvIuA7tlPM37DlAg3KNRTIomnmmKO2XG?= =?us-ascii?Q?2rVDNsOIAVrf8rigj8eDVJlAgyvwVDchiLFbpK+LTddOR6n0aiAn9b+rkP0h?= =?us-ascii?Q?WYBtHjg4ec4Psbtgp0ynh+B9oWV3JO/6a9oKvbsRNdmK9VEbhEFFpdiZ/tNz?= =?us-ascii?Q?CpeGr23OGIXvvky+E8ASAOtqkC0w35YBfijWIbW35VaWbffs4it9VDb9MUWW?= =?us-ascii?Q?EVkCOrjTHEYcET2COoY9V88UmrOmOKU=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_4E702316-1A38-4A59-99D3-F06F9063C5B1"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81ff1508-a0d4-4c28-02c8-08da31d17af6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 15:35:00.6590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yc7510TmwaOZ6F1sefqjbIbjQG6G+Uerb+CjIYwo3WDlq4v+/nLFRF4SobkvcK0rKQLoHyCgBdcqZx3DMzGh/E7CJ15eLrEhn197ZyVmENM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5820 --Apple-Mail=_4E702316-1A38-4A59-99D3-F06F9063C5B1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On May 6, 2022, at 1:00 PM, Luca Fancellu wrote: > > Introduce a way to create different cpupools at boot time, this is > particularly useful on ARM big.LITTLE system where there might be the > need to have different cpupools for each type of core, but also > systems using NUMA can have different cpu pools for each node. > > The feature on arm relies on a specification of the cpupools from the > device tree to build pools and assign cpus to them. > > ACPI is not supported for this feature. > > With this patch, cpupool0 can now have less cpus than the number of > online ones, so update the default case for opt_dom0_max_vcpus. > > Documentation is created to explain the feature. > > Signed-off-by: Luca Fancellu > Reviewed-by: Stefano Stabellini Changes to sched.h: Acked-by: George Dunlap --Apple-Mail=_4E702316-1A38-4A59-99D3-F06F9063C5B1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJ5NJ8ACgkQshXHp8eE G+24YAf+L+4wYaAeh82FUYk7g2UnlV/xSWFU8i8FP8XLc+ogE5dSaVtskvnZ3J7E GHbQiaYIz8fjF1d3FuSDTTV3+I+nGIszaVEPmZLz21nM9OyEAhZmLxYT0ZF6ZQhu mPsLfVQYS0V0pju2tOjrvROAAFLIy5Ya9f04ROOrdQu70TiAIWy0AfEEgfShCjgU iMLpjqUNoPBgdlv4zRh+lmMohzfAWx6vY2lZUE2yVhwUQ5HReL1RavAfl+Ip3UW4 IxKCwnYTPEZvKn9yCdzQPV4xr/U/b9Vt1srTNTZf/YublVVhoW3ZCsO6E8wZEFZH HUdZQu6+OBU3K3eLFs8XfMGk8jwnoA== =znIE -----END PGP SIGNATURE----- --Apple-Mail=_4E702316-1A38-4A59-99D3-F06F9063C5B1-- From xen-devel-bounces@lists.xenproject.org Mon May 09 15:53:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 15:53:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324658.546798 (Exim 4.92) (envelope-from ) id 1no5gw-0000p2-O1; Mon, 09 May 2022 15:52:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324658.546798; Mon, 09 May 2022 15:52:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5gw-0000ov-L5; Mon, 09 May 2022 15:52:58 +0000 Received: by outflank-mailman (input) for mailman id 324658; Mon, 09 May 2022 15:52:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5gw-0000op-1v for xen-devel@lists.xenproject.org; Mon, 09 May 2022 15:52:58 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 173382ea-cfb0-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 17:52:56 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id q4so11356543plr.11 for ; Mon, 09 May 2022 08:52:56 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id c2-20020aa79522000000b0050dc7628164sm8941672pfp.62.2022.05.09.08.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 08:52:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 173382ea-cfb0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CAxFYwx9au8ndjamrxPXEwi/2awSLBgQaCrWU0hhgV8=; b=sFEfltNQCVk2gKdSF95eO+6o5Oi9iHPAu9XMn5y7AVrB1PpZKrmSauv2vxy2epRHmZ NSr62ka7zLG3Gl54pw2fv1HHOqJzmWG+qcYMGudJBID58EtUah//Q/zwiMX8Beifo5Lh iXK5FpZRJsooYlIrPkKyk6xy3QQYJz/0u49tSn3qe+yDBvjo3SSASrt46ZFrb6+hHFvW H7/yN/ph8EWKTn0C9heTUB8cdpuCpaAeBHKYWIuDAIJkN6Hj0/oODbz/oRPz+ovRDe/T g9WoeDulJNTK3wKvSf95Pd6PuXhjpO0IWRLXy6yWL9wRfFaZ8a0IDJZWtt84gKIK5eWZ z7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CAxFYwx9au8ndjamrxPXEwi/2awSLBgQaCrWU0hhgV8=; b=wMoU0nR63jQt8w0+IgB1mofzsO7NuiQz+UhPFWoEuBKEqpZhhph9Ra8MLz2wd14di0 Jozkog6C4cbIK2sudT7Jiaw0095a57EPkxK032MaZfcYCC0P063Wv/Ga7HV/65UhPM5N /wNkA4AvKkPXmXjxGngIQfdsu7jXAfPTgqHYHF8QQBYFxdw+EgP5a5LLqKwiBzI8tFFb q5LUD7d8VWewTJOwoLRMX902kgwvC/sPj/DeooA7MU1tthElKdWJcgHKZB1psx4LVRUz pWwzKdIkSHtjtcOdhzLTfVquDS5Aihz3cNBy2TcKQ5UiR/7ZXy3Fef8Tg3vKnpyeNcph mJfg== X-Gm-Message-State: AOAM533n+mWluqE4iZbGA1a5sVOBctLIUMVlX2sfGplvi3D07ew/EXoE agpCrSGkoP4wKd3GjFVXa6nvXg== X-Google-Smtp-Source: ABdhPJysrIMHQqC/1OMD5SyWpentMn8Vwv24RP/WWPrWWVvg2aHHDob94JmsHZxC4PVEzZOqPXHCmA== X-Received: by 2002:a17:90b:1091:b0:1d8:b371:4b29 with SMTP id gj17-20020a17090b109100b001d8b3714b29mr26584916pjb.234.1652111574246; Mon, 09 May 2022 08:52:54 -0700 (PDT) Date: Mon, 9 May 2022 15:52:49 +0000 From: Sean Christopherson To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, "David P . Reed" , Paolo Bonzini Subject: Re: [PATCH 01/30] x86/crash,reboot: Avoid re-disabling VMX in all CPUs on crash/restart Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-2-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="J4vquNhda08TmTtV" Content-Disposition: inline In-Reply-To: <20220427224924.592546-2-gpiccoli@igalia.com> --J4vquNhda08TmTtV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I find the shortlog to be very confusing, the bug has nothing to do with disabling VMX and I distinctly remember wrapping VMXOFF with exception fixup to prevent doom if VMX is already disabled :-). The issue is really that nmi_shootdown_cpus() doesn't play nice with being called twice. On Wed, Apr 27, 2022, Guilherme G. Piccoli wrote: > In the panic path we have a list of functions to be called, the panic > notifiers - such callbacks perform various actions in the machine's > last breath, and sometimes users want them to run before kdump. We > have the parameter "crash_kexec_post_notifiers" for that. When such > parameter is used, the function "crash_smp_send_stop()" is executed > to poweroff all secondary CPUs through the NMI-shootdown mechanism; > part of this process involves disabling virtualization features in > all CPUs (except the main one). > > Now, in the emergency restart procedure we have also a way of > disabling VMX in all CPUs, using the same NMI-shootdown mechanism; > what happens though is that in case we already NMI-disabled all CPUs, > the emergency restart fails due to a second addition of the same items > in the NMI list, as per the following log output: > > sysrq: Trigger a crash > Kernel panic - not syncing: sysrq triggered crash > [...] > Rebooting in 2 seconds.. > list_add double add: new=, prev=, next=. > ------------[ cut here ]------------ > kernel BUG at lib/list_debug.c:29! > invalid opcode: 0000 [#1] PREEMPT SMP PTI Call stacks for the two callers would be very, very helpful. > In order to reproduce the problem, users just need to set the kernel > parameter "crash_kexec_post_notifiers" *without* kdump set in any > system with the VMX feature present. > > Since there is no benefit in re-disabling VMX in all CPUs in case > it was already done, this patch prevents that by guarding the restart > routine against doubly issuing NMIs unnecessarily. Notice we still > need to disable VMX locally in the emergency restart. > > Fixes: ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported) > Fixes: 0ee59413c967 ("x86/panic: replace smp_send_stop() with kdump friendly version in panic path") > Cc: David P. Reed > Cc: Hidehiro Kawai > Cc: Paolo Bonzini > Cc: Sean Christopherson > Signed-off-by: Guilherme G. Piccoli > --- > arch/x86/include/asm/cpu.h | 1 + > arch/x86/kernel/crash.c | 8 ++++---- > arch/x86/kernel/reboot.c | 14 ++++++++++++-- > 3 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h > index 86e5e4e26fcb..b6a9062d387f 100644 > --- a/arch/x86/include/asm/cpu.h > +++ b/arch/x86/include/asm/cpu.h > @@ -36,6 +36,7 @@ extern int _debug_hotplug_cpu(int cpu, int action); > #endif > #endif > > +extern bool crash_cpus_stopped; > int mwait_usable(const struct cpuinfo_x86 *); > > unsigned int x86_family(unsigned int sig); > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c > index e8326a8d1c5d..71dd1a990e8d 100644 > --- a/arch/x86/kernel/crash.c > +++ b/arch/x86/kernel/crash.c > @@ -42,6 +42,8 @@ > #include > #include > > +bool crash_cpus_stopped; > + > /* Used while preparing memory map entries for second kernel */ > struct crash_memmap_data { > struct boot_params *params; > @@ -108,9 +110,7 @@ void kdump_nmi_shootdown_cpus(void) > /* Override the weak function in kernel/panic.c */ > void crash_smp_send_stop(void) > { > - static int cpus_stopped; > - > - if (cpus_stopped) > + if (crash_cpus_stopped) > return; > > if (smp_ops.crash_stop_other_cpus) > @@ -118,7 +118,7 @@ void crash_smp_send_stop(void) > else > smp_send_stop(); > > - cpus_stopped = 1; > + crash_cpus_stopped = true; This feels like were just adding more duct tape to the mess. nmi_shootdown() is still unsafe for more than one caller, and it takes a _lot_ of staring and searching to understand that crash_smp_send_stop() is invoked iff CONFIG_KEXEC_CORE=y, i.e. that it will call smp_ops.crash_stop_other_cpus() and not just smp_send_stop(). Rather than shared a flag between two relatively unrelated functions, what if we instead disabling virtualization in crash_nmi_callback() and then turn the reboot call into a nop if an NMI shootdown has already occurred? That will also add a bit of documentation about multiple shootdowns not working. And I believe there's also a lurking bug in native_machine_emergency_restart() that can be fixed with cleanup. SVM can also block INIT and so should be disabled during an emergency reboot. The attached patches are compile tested only. If they seem sane, I'll post an official mini series. > } > > #else > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > index fa700b46588e..2fc42b8402ac 100644 > --- a/arch/x86/kernel/reboot.c > +++ b/arch/x86/kernel/reboot.c > @@ -589,8 +589,18 @@ static void native_machine_emergency_restart(void) > int orig_reboot_type = reboot_type; > unsigned short mode; > > - if (reboot_emergency) > - emergency_vmx_disable_all(); > + /* > + * We can reach this point in the end of panic path, having > + * NMI-disabled all secondary CPUs. This process involves > + * disabling the CPU virtualization technologies, so if that > + * is the case, we only miss disabling the local CPU VMX... > + */ > + if (reboot_emergency) { > + if (!crash_cpus_stopped) > + emergency_vmx_disable_all(); > + else > + cpu_emergency_vmxoff(); > + } > > tboot_shutdown(TB_SHUTDOWN_REBOOT); > > -- > 2.36.0 > --J4vquNhda08TmTtV Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-x86-crash-Disable-virt-in-core-NMI-crash-handler-to-.patch" >From 8a4573b7cf3a3e49b409ba3a504934de181c259d Mon Sep 17 00:00:00 2001 From: Sean Christopherson Date: Mon, 9 May 2022 07:36:34 -0700 Subject: [PATCH 1/2] x86/crash: Disable virt in core NMI crash handler to avoid double list_add Disable virtualization in crash_nmi_callback() and skip the requested NMI shootdown if a shootdown has already occurred, i.e. a callback has been registered. The NMI crash shootdown path doesn't play nice with multiple invocations, e.g. attempting to register the NMI handler multiple times will trigger a double list_add() and hang the sytem (in addition to multiple other issues). If "crash_kexec_post_notifiers" is specified on the kernel command line, panic() will invoke crash_smp_send_stop() and result in a second call to nmi_shootdown_cpus() during native_machine_emergency_restart(). Invoke the callback _before_ disabling virtualization, as the current VMCS needs to be cleared before doing VMXOFF. Note, this results in a subtle change in ordering between disabling virtualization and stopping Intel PT on the responding CPUs. While VMX and Intel PT do interact, VMXOFF and writes to MSR_IA32_RTIT_CTL do not induce faults between one another, which is all that matters when panicking. WARN if nmi_shootdown_cpus() is called a second time with anything other than the reboot path's "nop" handler, as bailing means the requested isn't being invoked. Punt true handling of multiple shootdown callbacks until there's an actual use case for doing so (beyond disabling virtualization). Extract the disabling logic to a common helper to deduplicate code, and to prepare for doing the shootdown in the emergency reboot path if SVM is supported. Note, prior to commit ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported), nmi_shootdown_cpus() was subtly protected against a second invocation by a cpu_vmx_enabled() check as the kdump handler would disable VMX if it ran first. Fixes: ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported) Cc: stable@vger.kernel.org Reported-by: Guilherme G. Piccoli Signed-off-by: Sean Christopherson --- arch/x86/include/asm/reboot.h | 1 + arch/x86/kernel/crash.c | 16 +-------------- arch/x86/kernel/reboot.c | 38 ++++++++++++++++++++++++++++++++--- 3 files changed, 37 insertions(+), 18 deletions(-) diff --git a/arch/x86/include/asm/reboot.h b/arch/x86/include/asm/reboot.h index 04c17be9b5fd..8f2da36435a6 100644 --- a/arch/x86/include/asm/reboot.h +++ b/arch/x86/include/asm/reboot.h @@ -25,6 +25,7 @@ void __noreturn machine_real_restart(unsigned int type); #define MRR_BIOS 0 #define MRR_APM 1 +void cpu_crash_disable_virtualization(void); typedef void (*nmi_shootdown_cb)(int, struct pt_regs*); void nmi_panic_self_stop(struct pt_regs *regs); void nmi_shootdown_cpus(nmi_shootdown_cb callback); diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index e8326a8d1c5d..fe0cf83843ba 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -81,15 +81,6 @@ static void kdump_nmi_callback(int cpu, struct pt_regs *regs) */ cpu_crash_vmclear_loaded_vmcss(); - /* Disable VMX or SVM if needed. - * - * We need to disable virtualization on all CPUs. - * Having VMX or SVM enabled on any CPU may break rebooting - * after the kdump kernel has finished its task. - */ - cpu_emergency_vmxoff(); - cpu_emergency_svm_disable(); - /* * Disable Intel PT to stop its logging */ @@ -148,12 +139,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs) */ cpu_crash_vmclear_loaded_vmcss(); - /* Booting kdump kernel with VMX or SVM enabled won't work, - * because (among other limitations) we can't disable paging - * with the virt flags. - */ - cpu_emergency_vmxoff(); - cpu_emergency_svm_disable(); + cpu_crash_disable_virtualization(); /* * Disable Intel PT to stop its logging diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index fa700b46588e..f9543a4e9b09 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -528,9 +528,9 @@ static inline void kb_wait(void) } } -static void vmxoff_nmi(int cpu, struct pt_regs *regs) +static void nmi_shootdown_nop(int cpu, struct pt_regs *regs) { - cpu_emergency_vmxoff(); + /* Nothing to do, the NMI shootdown handler disables virtualization. */ } /* Use NMIs as IPIs to tell all CPUs to disable virtualization */ @@ -554,7 +554,7 @@ static void emergency_vmx_disable_all(void) __cpu_emergency_vmxoff(); /* Halt and exit VMX root operation on the other CPUs. */ - nmi_shootdown_cpus(vmxoff_nmi); + nmi_shootdown_cpus(nmi_shootdown_nop); } } @@ -802,6 +802,18 @@ static nmi_shootdown_cb shootdown_callback; static atomic_t waiting_for_crash_ipi; static int crash_ipi_issued; +void cpu_crash_disable_virtualization(void) +{ + /* + * Disable virtualization, i.e. VMX or SVM, so that INIT is recognized + * during reboot. VMX blocks INIT if the CPU is post-VMXON, and SVM + * blocks INIT if GIF=0. Note, CLGI #UDs if SVM isn't enabled, so it's + * easier to just disable SVM unconditionally. + */ + cpu_emergency_vmxoff(); + cpu_emergency_svm_disable(); +} + static int crash_nmi_callback(unsigned int val, struct pt_regs *regs) { int cpu; @@ -819,6 +831,12 @@ static int crash_nmi_callback(unsigned int val, struct pt_regs *regs) shootdown_callback(cpu, regs); + /* + * Prepare the CPU for reboot _after_ invoking the callback so that the + * callback can safely use virtualization instructions, e.g. VMCLEAR. + */ + cpu_crash_disable_virtualization(); + atomic_dec(&waiting_for_crash_ipi); /* Assume hlt works */ halt(); @@ -840,6 +858,20 @@ void nmi_shootdown_cpus(nmi_shootdown_cb callback) unsigned long msecs; local_irq_disable(); + /* + * Invoking multiple callbacks is not currently supported, registering + * the NMI handler twice will cause a list_add() double add BUG(). + * The exception is the "nop" handler in the emergency reboot path, + * which can run after e.g. kdump's shootdown. Do nothing if the crash + * handler has already run, i.e. has already prepared other CPUs, the + * reboot path doesn't have any work of its to do, it just needs to + * ensure all CPUs have prepared for reboot. + */ + if (shootdown_callback) { + WARN_ON_ONCE(callback != nmi_shootdown_nop); + return; + } + /* Make a note of crashing cpu. Will be used in NMI callback. */ crashing_cpu = safe_smp_processor_id(); base-commit: 2764011106d0436cb44702cfb0981339d68c3509 -- 2.36.0.512.ge40c2bad7a-goog --J4vquNhda08TmTtV Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-x86-reboot-Disable-virtualization-in-an-emergency-if.patch" >From ce4b8fb50962c00a9bb29663e96501e90d68bd8b Mon Sep 17 00:00:00 2001 From: Sean Christopherson Date: Mon, 9 May 2022 08:28:14 -0700 Subject: [PATCH 2/2] x86/reboot: Disable virtualization in an emergency if SVM is supported Disable SVM on all CPUs via NMI shootdown during an emergency reboot. Like VMX, SVM can block INIT and thus prevent bringing up other CPUs via INIT-SIPI-SIPI. Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson --- arch/x86/kernel/reboot.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index f9543a4e9b09..33c1f4883b27 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -533,27 +533,29 @@ static void nmi_shootdown_nop(int cpu, struct pt_regs *regs) /* Nothing to do, the NMI shootdown handler disables virtualization. */ } -/* Use NMIs as IPIs to tell all CPUs to disable virtualization */ -static void emergency_vmx_disable_all(void) +static void emergency_reboot_disable_virtualization(void) { /* Just make sure we won't change CPUs while doing this */ local_irq_disable(); /* - * Disable VMX on all CPUs before rebooting, otherwise we risk hanging - * the machine, because the CPU blocks INIT when it's in VMX root. + * Disable virtualization on all CPUs before rebooting to avoid hanging + * the system, as VMX and SVM block INIT when running in the host * * We can't take any locks and we may be on an inconsistent state, so - * use NMIs as IPIs to tell the other CPUs to exit VMX root and halt. + * use NMIs as IPIs to tell the other CPUs to disable VMX/SVM and halt. * - * Do the NMI shootdown even if VMX if off on _this_ CPU, as that - * doesn't prevent a different CPU from being in VMX root operation. + * Do the NMI shootdown even if virtualization is off on _this_ CPU, as + * other CPUs may have virtualization enabled. */ - if (cpu_has_vmx()) { - /* Safely force _this_ CPU out of VMX root operation. */ - __cpu_emergency_vmxoff(); + if (cpu_has_vmx() || cpu_has_svm(NULL)) { + /* Safely force _this_ CPU out of VMX/SVM operation. */ + if (cpu_has_vmx()) + __cpu_emergency_vmxoff(); + else + cpu_emergency_svm_disable(); - /* Halt and exit VMX root operation on the other CPUs. */ + /* Disable VMX/SVM and halt on other CPUs. */ nmi_shootdown_cpus(nmi_shootdown_nop); } } @@ -590,7 +592,7 @@ static void native_machine_emergency_restart(void) unsigned short mode; if (reboot_emergency) - emergency_vmx_disable_all(); + emergency_reboot_disable_virtualization(); tboot_shutdown(TB_SHUTDOWN_REBOOT); -- 2.36.0.512.ge40c2bad7a-goog --J4vquNhda08TmTtV-- From xen-devel-bounces@lists.xenproject.org Mon May 09 15:58:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 15:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324664.546808 (Exim 4.92) (envelope-from ) id 1no5mZ-0001Ua-Cn; Mon, 09 May 2022 15:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324664.546808; Mon, 09 May 2022 15:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5mZ-0001UT-9i; Mon, 09 May 2022 15:58:47 +0000 Received: by outflank-mailman (input) for mailman id 324664; Mon, 09 May 2022 15:58:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5mY-0001UN-Jw for xen-devel@lists.xenproject.org; Mon, 09 May 2022 15:58:46 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7e0062c-cfb0-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 17:58:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ECEB421C61; Mon, 9 May 2022 15:58:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3A3413AA5; Mon, 9 May 2022 15:58:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uKZbLjQ6eWLmKAAAMHmgww (envelope-from ); Mon, 09 May 2022 15:58:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7e0062c-cfb0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652111924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=P/OgPWCVZKUWEFp1J72cVhxUxrlEAJuWxOjMgjzT0+4=; b=O7bwUGYwrb2u7m+SGtFmrX6h9gUY5vqr/Q8reRO9Yt8IWjfxBYGf7/MjhEthr7PL9wihar bJgTMv+zCiZh0EF4Vpqsk1pPpWMYrCFFjyQ2FuTDZ3fB0xONB3TVUYopleXASv17f530zH iv+nsDO1uDcgYNxknAIHkH0Wu4Cx5Ac= Message-ID: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> Date: Mon, 9 May 2022 17:58:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky , Stefano Stabellini From: Juergen Gross Subject: Attributing linux related patches on xen-devel Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------boP0QB8PHvLpQv71qaXBTatA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------boP0QB8PHvLpQv71qaXBTatA Content-Type: multipart/mixed; boundary="------------RZFWhIZHvLdkJ6qz3WVXs2O8"; protected-headers="v1" From: Juergen Gross To: "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky , Stefano Stabellini Message-ID: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> Subject: Attributing linux related patches on xen-devel --------------RZFWhIZHvLdkJ6qz3WVXs2O8 Content-Type: multipart/mixed; boundary="------------554QSrryLEfQyiYfCsPxRgYf" --------------554QSrryLEfQyiYfCsPxRgYf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gSVJDIHRoZSBxdWVzdGlvbiBjYW1lIHVwIHdoZXRoZXIgaXQgd291bGQgYmUgcG9zc2li bGUgdG8gaGF2ZSBhDQpzcGVjaWFsIG1hcmtlciBmb3IgTGludXggcGF0Y2hlcyBvbiB0aGUg eGVuLWRldmVsIE1MLg0KDQpJIHN1Z2dlc3RlZCB0byB1c2UgeGVuLWRldmVsK2xpbnV4QGxp c3RzLnhlbnByb2pleHQub3JnIGZvciB0aG9zZQ0KcGF0Y2hlcy4gV2l0aCBhIHBhdGNoIGZv ciB0aGUga2VybmVsJ3MgTUFJTlRBSU5FUlMgZmlsZSB0aGlzIHdvdWxkDQpiZSBxdWl0ZSBl YXN5IHRvIGFjaGlldmUuDQoNCkFueSB0aG91Z2h0cz8NCg0KDQpKdWVyZ2VuDQoNClAuUy46 IHNpbWlsYXIgdGFnZ2luZyBjb3VsZCBiZSBwZXJmb3JtZWQgZm9yIHFlbXUgYW5kIE1pbmkt T1MNCiAgICAgICByZWxhdGVkIG1haWxzDQo= --------------554QSrryLEfQyiYfCsPxRgYf Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------554QSrryLEfQyiYfCsPxRgYf-- --------------RZFWhIZHvLdkJ6qz3WVXs2O8-- --------------boP0QB8PHvLpQv71qaXBTatA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ5OjQFAwAAAAAACgkQsN6d1ii/Ey8+ BAf/RRZgAJIWhUxJlH1niYaIvuy/AkXwtPXIDTiRIaP++4uRwFiQ4M/L97gr3VmsdU1Jtiv3f2ZY D7hLUA5P5C1smwcigsBPMoyeyYKKGcBSRBSr0xe2KTp2pTeT4g5mwqwsElA8oIMFgGbHS6AmJoK0 rSjRK06w2qDkHlrpiDPxy+PUQA6LPew4BnboDd6BQNCezlzAtN58pupgzPoxFo+/z+l4Zi2GHagJ n/yiK+kJDhCFXaxL25dpSihhlkibPVy8V4W09wNlMLdCSMUr6VfXoFCSfxxwW8GxuNXlg4pPfiYH hy3mxwusgH3BMtfvdDSsPsaT9Z+24Bdh/pZUDs83gA== =ymPn -----END PGP SIGNATURE----- --------------boP0QB8PHvLpQv71qaXBTatA-- From xen-devel-bounces@lists.xenproject.org Mon May 09 15:59:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 15:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324670.546820 (Exim 4.92) (envelope-from ) id 1no5nW-00022P-N5; Mon, 09 May 2022 15:59:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324670.546820; Mon, 09 May 2022 15:59:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5nW-00022G-JQ; Mon, 09 May 2022 15:59:46 +0000 Received: by outflank-mailman (input) for mailman id 324670; Mon, 09 May 2022 15:59:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5nV-000224-Cs; Mon, 09 May 2022 15:59:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5nV-00004t-B2; Mon, 09 May 2022 15:59:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no5nV-0007rO-3O; Mon, 09 May 2022 15:59:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no5nV-0005QL-2w; Mon, 09 May 2022 15:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zWNGMdD+1RlJ2da8o+Kd1ixThfQJeptyrCmhK4TPGTY=; b=KOx8XeGvp6HJe9DL/TbXkovg3C TycUILJuDRqTz/ppF61sCZ/dsdtIMAMbOg9VCYQd+Rf+BVqeY00taWgqtCYDqJ+WWzpE4tA134h4B W1A42nGJwB/e0t6mzcjf3Ru/3l3+6o1ZtjC+cH9PvumGuyyzSqPsgRBQk8W+NkFv8tY8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170272: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 15:59:45 +0000 flight 170272 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170272/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 897 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 16:15:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 16:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324679.546831 (Exim 4.92) (envelope-from ) id 1no62T-0005Q0-4R; Mon, 09 May 2022 16:15:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324679.546831; Mon, 09 May 2022 16:15:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no62T-0005Pt-1Y; Mon, 09 May 2022 16:15:13 +0000 Received: by outflank-mailman (input) for mailman id 324679; Mon, 09 May 2022 16:15:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no62R-0005Pn-NL for xen-devel@lists.xenproject.org; Mon, 09 May 2022 16:15:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 327ea382-cfb3-11ec-a406-831a346695d4; Mon, 09 May 2022 18:15:09 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD7641480; Mon, 9 May 2022 09:15:08 -0700 (PDT) Received: from [10.57.1.248] (unknown [10.57.1.248]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 15C183F73D; Mon, 9 May 2022 09:14:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 327ea382-cfb3-11ec-a406-831a346695d4 Message-ID: Date: Mon, 9 May 2022 17:14:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier To: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Leo Yan , Mathieu Poirier , Mike Leach References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-10-gpiccoli@igalia.com> <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com> <65f24bc5-2211-0139-ee12-b2608e81ceb1@igalia.com> From: Suzuki K Poulose In-Reply-To: <65f24bc5-2211-0139-ee12-b2608e81ceb1@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi On 09/05/2022 14:09, Guilherme G. Piccoli wrote: > On 28/04/2022 05:11, Suzuki K Poulose wrote: >> Hi Guilherme, >> >> On 27/04/2022 23:49, Guilherme G. Piccoli wrote: >>> The panic notifier infrastructure executes registered callbacks when >>> a panic event happens - such callbacks are executed in atomic context, >>> with interrupts and preemption disabled in the running CPU and all other >>> CPUs disabled. That said, mutexes in such context are not a good idea. >>> >>> This patch replaces a regular mutex with a mutex_trylock safer approach; >>> given the nature of the mutex used in the driver, it should be pretty >>> uncommon being unable to acquire such mutex in the panic path, hence >>> no functional change should be observed (and if it is, that would be >>> likely a deadlock with the regular mutex). >>> >>> Fixes: 2227b7c74634 ("coresight: add support for CPU debug module") >>> Cc: Leo Yan >>> Cc: Mathieu Poirier >>> Cc: Mike Leach >>> Cc: Suzuki K Poulose >>> Signed-off-by: Guilherme G. Piccoli >> >> How would you like to proceed with queuing this ? I am happy >> either way. In case you plan to push this as part of this >> series (I don't see any potential conflicts) : >> >> Reviewed-by: Suzuki K Poulose > > Hi Suzuki, some other maintainers are taking the patches to their next > branches for example. I'm working on V2, and I guess in the end would be > nice to reduce the size of the series a bit. > > So, do you think you could pick this one for your coresight/next branch > (or even for rc cycle, your call - this is really a fix)? > This way, I won't re-submit this one in V2, since it's gonna be merged > already in your branch. I have queued this to coresight/next. Thanks Suzuki From xen-devel-bounces@lists.xenproject.org Mon May 09 16:27:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 16:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324685.546841 (Exim 4.92) (envelope-from ) id 1no6EQ-00070B-90; Mon, 09 May 2022 16:27:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324685.546841; Mon, 09 May 2022 16:27:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6EQ-000704-5s; Mon, 09 May 2022 16:27:34 +0000 Received: by outflank-mailman (input) for mailman id 324685; Mon, 09 May 2022 16:27:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6EN-0006zx-QF for xen-devel@lists.xenproject.org; Mon, 09 May 2022 16:27:33 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eaa26e73-cfb4-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 18:27:28 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no6Dc-0008Ch-Cc; Mon, 09 May 2022 18:26:44 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaa26e73-cfb4-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9i+OK+B4WtRAOc8WSMPsYke6rlZ4xBWZoesmtMxOiqA=; b=GajbuIp7qtfA1gL+RPS2SXW7q0 Vraxp03Er1/ulBPczR4jeK2gXNYw1QHwX+65lsLXsgoQAcIdxZGe/+WWRC335caKoXycxD0Z3x4PP PCChOAEvQHFR3h4UawQfb9N6Z8knUowIzg0/dNyhzWus6YExYHQOg3lgx3zNijxQY/5UEVyTsU5Ee oRSolpioMk06T89IZHAQg91xzRBm4fNuENY64OTsnaWwgm+PjfUORhXl2iNP0+mT/pErDsk4F7R+0 xGrr2cJy2Cu50umiX4PUdpi4rNkK5XT6AYQf77hlh8AUJqbCwwyU3G8+vIO6rDA82b9ywoWo/D9EX Ws9UFdfQ==; Message-ID: Date: Mon, 9 May 2022 13:26:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 09/30] coresight: cpu-debug: Replace mutex with mutex_trylock on panic notifier Content-Language: en-US To: Suzuki K Poulose , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Leo Yan , Mathieu Poirier , Mike Leach References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-10-gpiccoli@igalia.com> <3cafe4fd-8a0b-2633-44a3-2995abd6c38c@arm.com> <65f24bc5-2211-0139-ee12-b2608e81ceb1@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/05/2022 13:14, Suzuki K Poulose wrote: > [...]> > I have queued this to coresight/next. > > Thanks > Suzuki Thanks a lot Suzuki! From xen-devel-bounces@lists.xenproject.org Mon May 09 16:40:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 16:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324695.546853 (Exim 4.92) (envelope-from ) id 1no6Qn-0000yt-F6; Mon, 09 May 2022 16:40:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324695.546853; Mon, 09 May 2022 16:40:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6Qn-0000ym-AN; Mon, 09 May 2022 16:40:21 +0000 Received: by outflank-mailman (input) for mailman id 324695; Mon, 09 May 2022 16:40:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6Qm-0000yg-La for xen-devel@lists.xenproject.org; Mon, 09 May 2022 16:40:20 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b611e419-cfb6-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 18:40:19 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1no6QL-0009Bp-09; Mon, 09 May 2022 18:39:53 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b611e419-cfb6-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=48dgNwNPuCnyD3VVOBf09xe2NjnTaXdW0ldox8dhrAY=; b=eLWL69Jp3Hs5nKIC07c/DVmIhZ tbuXXOS52wa7kstrEszNfv7tW4JmReP+jwvf/WSB2LnPtAjsR79TSRqPXDYlR/UhgTYs3JxE63TxY WFAF2HLKU7kQDGOjOij/SccvoodNoUy/77Q7Rw1bHNyMkUGePOlK3tPiGlMKv0HFeJaDvBKfB5C4T 7/g7A8xShBgXvVATUWH+9aEVvFCEwhRR4Tyt7Zyibz7aNPTHMnncwalkA+46VUbkJ44ERvwAtMmTs hWWtwgYVptx9ug9t6aPZQ1zrU+TA/lel56oNayZ3d7me/ZMI8w2lxg28JbHkciwHu/jkRujv3gimI sEcDvBWQ==; Message-ID: <92e03ebf-6a64-69dc-bf16-9552b9fedad8@igalia.com> Date: Mon, 9 May 2022 13:39:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: "d.hatayama@fujitsu.com" , "akpm@linux-foundation.org" , "bhe@redhat.com" , "pmladek@suse.com" , "kexec@lists.infradead.org" , Mark Rutland , Marc Zyngier , "mikelley@microsoft.com" , Hari Bathini Cc: "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "feng.tang@intel.com" , "gregkh@linuxfoundation.org" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hey Hatayma, thanks for your great analysis and no need for apologies! I'll comment/respond properly inline below, just noticing here that I've CCed Mark and Marc (from the ARM64 perspective), Michael (Hyper-V perspective) and Hari (PowerPC perspective), besides the usual suspects as Petr, Baoquan, etc. On 09/05/2022 12:16, d.hatayama@fujitsu.com wrote: > Sorry for the delayed response. Unfortunately, I had 10 days holidays > until yesterday... > [...] >> + We currently have 4 lists of panic notifiers; based >> + on the functionality and risk (for panic success) the >> + callbacks are added in a given list. The lists are: >> + - hypervisor/FW notification list (low risk); >> + - informational list (low/medium risk); >> + - pre_reboot list (higher risk); >> + - post_reboot list (only run late in panic and after >> + kdump, not configurable for now). >> + This parameter defines the ordering of the first 3 >> + lists with regards to kdump; the levels determine >> + which set of notifiers execute before kdump. The >> + accepted levels are: >> + 0: kdump is the first thing to run, NO list is >> + executed before kdump. >> + 1: only the hypervisor list is executed before kdump. >> + 2 (default level): the hypervisor list and (*if* > > Hmmm, why are you trying to change default setting? > > Based on the current design of kdump, it's natural to put what the > handlers for these level 1 and level 2 handlers do in > machine_crash_shutdown(), as these are necessary by default, right? > > Or have you already tried that and figured out it's difficult in some > reason and reached the current design? If so, why is that difficult? > Could you point to if there is already such discussion online? > > kdump is designed to perform as little things as possible before > transferring the execution to the 2nd kernel in order to increase > reliability. Just detour to panic() increases risks of kdump failure > in the sense of increasing the executed codes in the abnormal > situation, which is very the note in the explanation of > crash_kexec_post_notifiers. > > Also, the current implementation of crash_kexec_post_notifiers uses > the panic notifier, but this is not from the technical > reason. Ideally, it should have been implemented in the context of > crash_kexec() independently of panic(). > > That is, it looks to me that, in addition to changing design of panic > notifier, you are trying to integrate shutdown code of the crash kexec > and the panic paths. If so, this is a big design change for kdump. > I'm concerned about increase of reliability. I'd like you to discuss > them carefully. >From my understanding (specially based on both these threads [0] and [1]), 3 facts are clear and quite complex in nature: (a) Currently, the panic notifier list is a "no man's land" - it's a mess, all sort of callbacks are added there, some of them are extremely risk for breaking kdump, others are quite safe (like setting a variable). Petr's details in thread [0] are really clear and express in great way how confusing and conflicting the panic notifiers goals are. (b) In order to "address" problems in the antagonistic goals of notifiers (see point (a) above and thread [0]), we have this quirk/workaround called "crash_kexec_post_notifiers". This is useful, but (almost as for attesting how this is working as band-aid over complex and fundamental issues) see the following commits: a11589563e96 ("x86/Hyper-V: Report crash register data or kmsg before running crash kernel") 06e629c25daa ("powerpc/fadump: Fix inaccurate CPU state info in vmcore generated with panic") They hardcode such workaround, because they *need* some notifiers' callbacks. But notice they *don't need all of them*, only some important ones (that usually are good considering the risk, it's a good cost/benefit). Since we currently have an all-or-nothing behavior for the panic notifiers, both PowerPC and Hyper-V end-up bringing all of them to run before kdump due to the lack of flexibility, increasing a lot the risk of failure for kdump. (c) To add on top of all such complexity, we don't have a custom machine_crash_shutdown() handler for some architectures like ARM64, and the feeling is that's not right to add a bunch of callbacks / complexity in such architecture code, specially since we have the notifiers infrastructure in the kernel. I've recently started a discussion about that with ARM64 community, please take a look in [1]. With that said, we can use (a) + (b) + (c) to justify our argument here: the panic notifiers should be refactored! We need to try to encompass the antagonistic goals of kdump (wants to be the first thing to run, early as possible) VS. the notifiers that are necessary, even before kdump (like Hyper-V / PowerPC fadump ones, but there are more of these, the FW/hypervisors notifiers). I guarantee to you we cannot make 100% of people happy - the panic-related areas like kdump, etc are full of trade-offs. We improve something, other stuff breaks. This series attempts to clearly distribute the notifiers in 3 buckets, and introduces a level setting that tunes such buckets to run before or after the kdump in a highly flexible way, trying to make the most users happy and capable of tuning their systems. I understand that likely setting the notifiers to 0 would make kdump maintainers happy, because we'd keep the same behavior as before. But..then we make PPC / Hyper-V and some other users unsatisfied. Level 2 seems to me a good compromise. I'm willing to add a KConfig option to allow distros to hard set their defaults - that might make sense to legacy distros as older RHEL / CentOS or server-only distros. Finally, you mention about integrating the crash shutdown and the panic paths - I'm not officially doing that, but I see that they are very related and all cases I've ever seen in the last 3-4 years I've been working with kdump, it was triggered from panic, from settings "panic_on_X". I understand we have the regular kexec path (!kdump), some notifiers might make sense in both paths, and in this case we could duplicate them (one callback, 2 notifier lists) and control against double execution. I tried doing that in patch 16 of this series (Hyper-V stuff), but due to the lack of ARM64 custom crash shutdown handler, I couldn't. We can think in some alternatives, and improve these (naturally) connected/related paths, but this is not the goal of this specific series. I'm hereby trying to improve/clarify the panic (and kdump) path, not the pure kexec path. Let me know if I can clarify more specific points you have or if there are flaws in my logic - I appreciate the discussions/reviews. Cheers, Guilherme [0] "notifier/panic: Introduce panic_notifier_filter" - https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/ [1] "Should arm64 have a custom crash shutdown handler?" - https://lore.kernel.org/lkml/427a8277-49f0-4317-d6c3-4a15d7070e55@igalia.com/ From xen-devel-bounces@lists.xenproject.org Mon May 09 17:11:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 17:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324705.546863 (Exim 4.92) (envelope-from ) id 1no6v6-0004ja-Oc; Mon, 09 May 2022 17:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324705.546863; Mon, 09 May 2022 17:11:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6v6-0004jT-Lr; Mon, 09 May 2022 17:11:40 +0000 Received: by outflank-mailman (input) for mailman id 324705; Mon, 09 May 2022 17:11:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6v5-0004jJ-Tq; Mon, 09 May 2022 17:11:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6v5-0001si-RH; Mon, 09 May 2022 17:11:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no6v5-0001QY-FE; Mon, 09 May 2022 17:11:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no6v5-00047s-EZ; Mon, 09 May 2022 17:11:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=19ieyY9SclifwFuglRSdY+dgKyoz5fdfvVrKRGDJD4w=; b=t7mwi7fgEPxJLBZ1aOs/PQ3XqP v3blZzHHg4SDVRvJod8Al6oXxYiKdAiZR8K8c6PfxDeUS1vU8GyKj8quORn0QW2KpUp3Jl/sCC6VE HSJi+R6WTJqfNNuFu3FBAlJRaG+iSPG/gyhPmshO63x5W7bMZafdbfNt7AfnummD3L4g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170274: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 17:11:39 +0000 flight 170274 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170274/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 898 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 18:11:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324714.546875 (Exim 4.92) (envelope-from ) id 1no7qW-0002uF-DI; Mon, 09 May 2022 18:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324714.546875; Mon, 09 May 2022 18:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7qW-0002u8-91; Mon, 09 May 2022 18:11:00 +0000 Received: by outflank-mailman (input) for mailman id 324714; Mon, 09 May 2022 18:10:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7qU-0002u2-Sk for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:10:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7qU-0002w9-FL; Mon, 09 May 2022 18:10:58 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no7qU-0004YM-8v; Mon, 09 May 2022 18:10:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hOKnFSgeeaBsBQW9p5fEs6SznPvPnPosq2qduJAVSKg=; b=rBP+K7RXuxn/cUFqfdQBmdxHcy D6mCLZCvhGdlsjAUztjT8DzRWr9gZB9raIX5wqbG8wcdk4qUvBO1/ukynrA6RTeRvSLLw7OnRde/O QIXo8p4wJtQH8eT/4UZQmcMFwq029wCfXxbuiXxAlW2WHShiUa5zX2CxKcMwFZnbgXbU=; Message-ID: Date: Mon, 9 May 2022 19:10:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] docs: Fix SUPPORT matrix generation after a5968a553f6a To: George Dunlap Cc: xen-devel , Julien Grall , Andrew Cooper , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220509080707.50926-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/05/2022 09:42, George Dunlap wrote: > > >> On May 9, 2022, at 9:07 AM, Julien Grall wrote: >> >> From: Julien Grall >> >> Commit a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory >> supported for Arm" added a support statement split over two lines. >> >> Unfortunately, docs/support-matrix-generate throw an error for it: >> >> Generating support matrix (origin/stable-NN ) >> + docs/support-matrix-generate HEAD https://xenbits.xen.org/docs/unstable/SUPPORT.html origin/stable-NN https://xenbits.xen.org/docs/NN-testing/SUPPORT.html >> Status, x86: Supported up to 8 TiB. Hosts with more memory are >> supported, but not security supported. >> Status, Arm32: Supported up to 12 GiB >> Status, Arm64: Supported up to 2 TiB >> ^ cannot parse status codeblock line: >> supported, but not security supported. >> ? at docs/parse-support-md line 172, chunk 1. >> >> It would be good to allow split support statement (to keep lines below >> 80 characters) but my knowledge of the script is very limited. >> >> Therefore, workaround the error by describing the support statement >> in one long line. >> >> Fixes: a5968a553f6a "SUPPORT.MD: Correct the amount of physical memory supported for Arm" >> Signed-off-by: Julien Grall > > Acked-by: George Dunlap Thanks! I have committed it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 18:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324721.546890 (Exim 4.92) (envelope-from ) id 1no7u9-0003hw-V8; Mon, 09 May 2022 18:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324721.546890; Mon, 09 May 2022 18:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7u9-0003hp-Qh; Mon, 09 May 2022 18:14:45 +0000 Received: by outflank-mailman (input) for mailman id 324721; Mon, 09 May 2022 18:14:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7u9-0003hj-DM for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:14:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no7u9-000308-5e; Mon, 09 May 2022 18:14:45 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no7u9-0004xG-06; Mon, 09 May 2022 18:14:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=79IwOqeLdCM3sFEealN76rJn8rVZJ7E8O4fMOeu+ORE=; b=WkdMMUR5qo/ZE89M5gX+wcRQUf 9Y8xL4XAZRVN5HAkm9EUuC29cLvwXmYol2/FQwmA1YeeWZr6bx8rqyRthWn1P2bAuS/yNDB1xb7CQ cHkPCQTRlB6eVeGoS+oB7xLevh2dkAr8FZo73CzsCpMbgutNry8zg2xRL261yUohP2Vw=; Message-ID: <52708a7f-03d5-8133-f7d6-e2288fae0b57@xen.org> Date: Mon, 9 May 2022 19:14:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table To: Bertrand Marquis , Rahul Singh Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <0CE12746-697A-4005-8FD1-FE2546A8E018@arm.com> From: Julien Grall In-Reply-To: <0CE12746-697A-4005-8FD1-FE2546A8E018@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/05/2022 12:28, Bertrand Marquis wrote: >> On 4 May 2022, at 18:15, Rahul Singh wrote: >> >> When Xen boots on the platform that implements the GIC 600, ITS >> MAPC_LPI_OFF uncorrectable command error issue is observed. >> >> As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can >> be reported if the MAPC command has tried to map a collection to a core >> that does not have LPIs enabled. The definition of GICR.EnableLPIs >> also suggests enabling the LPIs before sending any ITS command that >> involves LPIs >> >> 0b0 LPI support is disabled. Any doorbell interrupt generated as a >> result of a write to a virtual LPI register must be discarded, >> and any ITS translation requests or commands involving LPIs in >> this Redistributor are ignored. >> >> 0b1 LPI support is enabled. >> >> To fix the MAPC command error issue, enable the LPIs using >> GICR_CTLR.EnableLPIs before mapping the collection table. >> >> gicv3_enable_lpis() is using writel_relaxed(), write to the GICR_CTLR >> register may not be visible before gicv3_its_setup_collection() send the >> MAPC command. Use wmb() after writel_relaxed() to make sure register >> write to enable LPIs is visible. >> >> Signed-off-by: Rahul Singh > Reviewed-by: Bertrand Marquis Committed. Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 18:22:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324728.546905 (Exim 4.92) (envelope-from ) id 1no81Y-0005Ht-Nt; Mon, 09 May 2022 18:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324728.546905; Mon, 09 May 2022 18:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no81Y-0005Hm-L2; Mon, 09 May 2022 18:22:24 +0000 Received: by outflank-mailman (input) for mailman id 324728; Mon, 09 May 2022 18:22:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no81W-0005Hc-C4 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:22:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no81R-00038u-0S; Mon, 09 May 2022 18:22:17 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no81Q-0005WR-QJ; Mon, 09 May 2022 18:22:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rzTlxfHjWXtIR41vc5Crw3Am92UuoLpRph9ARsoN050=; b=cLP4TZjh/G4y27HmQNsGUZCHbg Xc0GUIGBUP4W1LmYMSizDRpIS7RneT/fi85uUhdjtuMLJT0+XNly1L/wt8U25QoMNW2FMk/Q4iZn7 E38JVtn6e0IXygl6eFludmbDhO009eUNYTDKCtyRaC4E+wCMpDRX5R77pVJO+xyHJZos=; Message-ID: Date: Mon, 9 May 2022 19:22:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 26/04/2022 13:38, Bertrand Marquis wrote: > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h > index 852b5f3c24..ef37cfa16f 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -219,9 +219,11 @@ > SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\ > SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE) > > +#ifndef CPPCHECK Can you add a comment explaining why you need this check? With that: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 18:30:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:30:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324734.546915 (Exim 4.92) (envelope-from ) id 1no89D-0006j7-IK; Mon, 09 May 2022 18:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324734.546915; Mon, 09 May 2022 18:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89D-0006j0-FD; Mon, 09 May 2022 18:30:19 +0000 Received: by outflank-mailman (input) for mailman id 324734; Mon, 09 May 2022 18:30:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89C-0006iu-4e for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:30:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89B-0003H6-Op; Mon, 09 May 2022 18:30:17 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no89B-0005z6-If; Mon, 09 May 2022 18:30:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1cMY2WjmVzdoY//sq9qPo+5OBr0bW9FtGCyCu7eFM8E=; b=0y/bKBGWJP3ub+/dr9ebbLLBSU Vb6OdlUn/I2bDGyJ6HyXZnh16NnVY/kXQMcjy/uGfcnwxkQuoeC9p4/KB7Kk3iRw/WMPcCGOqIM84 EyK8kudD34265ZoDrA0HjBuIvWBTyXEqj7eKrAzpVBsgIzJkEiWvjLZqLiq1q/Z81Eh0=; Message-ID: <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> Date: Mon, 9 May 2022 19:30:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , xen-devel@lists.xenproject.org Cc: stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220428103410.2723837-1-alex.bennee@linaro.org> From: Julien Grall In-Reply-To: <20220428103410.2723837-1-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Alex, On 28/04/2022 11:34, Alex Bennée wrote: > When we introduced FEAT_LPA to QEMU's -cpu max we discovered older > kernels had a bug where the physical address was copied directly from > ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits > the same error by blindly copying across the max supported range. > > Unsurprisingly when the page tables aren't set up for these greater > ranges hilarity ensues and the hypervisor crashes fairly early on in > the boot-up sequence. This happens when we write to the control > register in enable_mmu(). > > Attempt to fix this the same way as the Linux kernel does by gating > PARange to the maximum the hypervisor can handle. I also had to fix up > code in p2m which panics when it sees an "invalid" entry in PARange. > > Signed-off-by: Alex Bennée > Cc: Richard Henderson > Cc: Stefano Stabellini > Cc: Julien Grall > Cc: Volodymyr Babchuk > Cc: Bertrand Marquis Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 18:30:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:30:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324735.546927 (Exim 4.92) (envelope-from ) id 1no89I-00070R-R9; Mon, 09 May 2022 18:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324735.546927; Mon, 09 May 2022 18:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89I-00070I-Ns; Mon, 09 May 2022 18:30:24 +0000 Received: by outflank-mailman (input) for mailman id 324735; Mon, 09 May 2022 18:30:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89I-0006zv-2q; Mon, 09 May 2022 18:30:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89I-0003HM-1n; Mon, 09 May 2022 18:30:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no89H-0005JK-Od; Mon, 09 May 2022 18:30:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no89H-0002rA-OC; Mon, 09 May 2022 18:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5mw2Vz2YhTqosDBFCfYaHCazG7H/2A82ZuYdscTjIMw=; b=alQ4symhoCelM3f5cuxhDd+X+K +C1r6yETztyk37Rt449a3q//x09jf+2Anob0elINVkRTACK4eoVbqH/cNe/YgU4ur7T6MIiq/Y777 788Ux6joMVH3upADVVDtJ9seI2qxB/gCAOis5I+n2b3Lw1QJE2PDaAZbOxhrjT8gJ8fQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170276: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 18:30:23 +0000 flight 170276 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170276/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 899 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 18:34:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324748.546938 (Exim 4.92) (envelope-from ) id 1no8Co-00084a-FE; Mon, 09 May 2022 18:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324748.546938; Mon, 09 May 2022 18:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Co-00084T-AM; Mon, 09 May 2022 18:34:02 +0000 Received: by outflank-mailman (input) for mailman id 324748; Mon, 09 May 2022 18:34:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Cn-00084N-9I for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:34:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Cj-0003Lc-J7; Mon, 09 May 2022 18:33:57 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no8Cj-0006K4-B5; Mon, 09 May 2022 18:33:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rLTSljuycOZML5T9a6BEbJXuZn4e4N2aaJvj3LctdeY=; b=L3hnZM6QDWXBvb0Pns8PMSABD+ mukios6hy/QKkc4EXyCWRlXI55PlwO6ZY2oZTN7MTFnbioSKw63XobDMo+U6jvFA/AXpnU7quayHE eP1LWWrkUjeLwum+6eaUsWkl3Oaso50iBnX/m2JAZkF7ISwVleEioIgBrLo0zHYTOdsw=; Message-ID: Date: Mon, 9 May 2022 19:33:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup To: Luca Fancellu , "Daniel P. Smith" Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Stefano Stabellini , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> From: Julien Grall In-Reply-To: <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/05/2022 14:17, Luca Fancellu wrote: >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index 0bf63ffa84..b93101191e 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) >> return 0; >> } >> >> +static int cf_check flask_set_system_active(void) >> +{ >> + struct domain *d = current->domain; >> + >> + ASSERT(d->is_privileged); >> + >> + if ( d->domain_id != DOMID_IDLE ) >> + { >> + printk("xsm_set_system_active should only be called by idle domain\n"); > > Sorry I spotted that now, here in the printk probably you mean “flask_set_system_active” > instead of “xsm_set_system_active”, you can keep my R-by after this change. I tend to use "%s: ...", __func__ so the name always name the function. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 18:38:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 18:38:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324755.546948 (Exim 4.92) (envelope-from ) id 1no8Gw-0000IY-3H; Mon, 09 May 2022 18:38:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324755.546948; Mon, 09 May 2022 18:38:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Gw-0000IR-0D; Mon, 09 May 2022 18:38:18 +0000 Received: by outflank-mailman (input) for mailman id 324755; Mon, 09 May 2022 18:38:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Gu-0000Gh-Oc for xen-devel@lists.xenproject.org; Mon, 09 May 2022 18:38:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8Gs-0003Qs-Jc; Mon, 09 May 2022 18:38:14 +0000 Received: from [54.239.6.187] (helo=[192.168.22.23]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1no8Gs-0006cG-Co; Mon, 09 May 2022 18:38:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tAY/67Q+Kq7e/CWJjPVJjGE18LY2xrMUriNunhgLuGc=; b=SQF+au6AousHCyi9SpNgfwDx5h 6pk/J9Kn2DNr2yLlNoH87VIH+7D/5CMOHthzHlu1+G0Zoqzeskosfy+KxkcZofdKJTaUcG9MthCpq sPpurjNO8kaSy+Chj1dIVwCVfXG21d3OAeZavVS6si6ti1IizoNlah08kKyIRFnt9oSI=; Message-ID: Date: Mon, 9 May 2022 19:38:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup To: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Stefano Stabellini , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20220503111731.12642-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daniel, On 03/05/2022 12:17, Daniel P. Smith wrote: > There are new capabilities, dom0less and hyperlaunch, that introduce internal > hypervisor logic which needs to make resource allocation calls that are > protected by XSM access checks. This creates an issue as a subset of the > hypervisor code is executed under a system domain, the idle domain, that is > represented by a per-CPU non-privileged struct domain. To enable these new > capabilities to function correctly but in a controlled manner, this commit > changes the idle system domain to be created as a privileged domain under the > default policy and demoted before transitioning to running. A new XSM hook, > xsm_set_system_active(), is introduced to allow each XSM policy type to demote > the idle domain appropriately for that policy type. In the case of SILO, it > inherits the default policy's hook for xsm_set_system_active(). > > For flask a stub is added to ensure that flask policy system will function > correctly with this patch until flask is extended with support for starting the > idle domain privileged and properly demoting it on the call to > xsm_set_system_active(). > > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk > --- > xen/arch/arm/setup.c | 4 ++++ > xen/arch/x86/setup.c | 5 +++++ > xen/common/sched/core.c | 7 ++++++- > xen/include/xsm/dummy.h | 17 +++++++++++++++++ > xen/include/xsm/xsm.h | 6 ++++++ > xen/xsm/dummy.c | 1 + > xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ > 7 files changed, 62 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed4..39a654926d 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long boot_phys_offset, > /* Hide UART from DOM0 if we're using it */ > serial_endboot(); > > + if ( (rc = xsm_set_system_active()) != 0 ) > + panic("xsm(err=%d): " > + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", rc); We usually don't split error message over multiple lines (even if they are over 80 characters). > + > system_state = SYS_STATE_active; > > for_each_domain( d ) > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 6f20e17892..36a60ce884 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -620,6 +620,11 @@ static void noreturn init_done(void) > { > void *va; > unsigned long start, end; > + int err; > + > + if ( (err = xsm_set_system_active()) != 0 ) > + panic("xsm(err=%d): " > + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); Same here. Other than the two remarks above and Luca's one: Acked-by: Julien Grall # arm Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 09 19:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324762.546959 (Exim 4.92) (envelope-from ) id 1no8dq-0003tF-1X; Mon, 09 May 2022 19:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324762.546959; Mon, 09 May 2022 19:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8dp-0003t8-V3; Mon, 09 May 2022 19:01:57 +0000 Received: by outflank-mailman (input) for mailman id 324762; Mon, 09 May 2022 19:01:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8do-0003t2-QB for xen-devel@lists.xenproject.org; Mon, 09 May 2022 19:01:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e1905f1-cfca-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 21:01:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 358E9B81905; Mon, 9 May 2022 19:01:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA6FBC385B2; Mon, 9 May 2022 19:01:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e1905f1-cfca-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652122913; bh=QGHpPW4mD7cfq68T2fhvbHMwoqZ1U49MMrkmwM5FncU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rbfPdH5AmsxB4QMwPRBFS2lFYl21tvVSJNF4IWfu1kO58A9GQPkkMZp52XCOf28o8 ZmOjQWIhf+jbkaucfou9Qjod4U84F20tdZva/SMjDJ7MpqMLhbh35eR2ZK1JVvPg41 pjOTq6VHkL/AxJ57BrG1OJKOBJXw9+hzwuFxYUDJ7kKDj+bxS9Y+xvqsmqZV/smuOq VtFWGOE5SSycEheHYUOqNYL/tnJ6ttyj1YWjy0DyUllmMS/rTPEBNBulwcqMWRM4hc EeCA35LguvP3uWUnJEBi7TSPqtxzF5BVR1P1q09r6YFU6ElLPimedbX/LSeQSDMQvL TMJ18IX7KMDyw== Date: Mon, 9 May 2022 12:01:52 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Stefano Stabellini Subject: Re: Attributing linux related patches on xen-devel In-Reply-To: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> Message-ID: References: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 9 May 2022, Juergen Gross wrote: > On IRC the question came up whether it would be possible to have a > special marker for Linux patches on the xen-devel ML. > > I suggested to use xen-devel+linux@lists.xenprojext.org for those > patches. With a patch for the kernel's MAINTAINERS file this would > be quite easy to achieve. > > Any thoughts? Fine by me, as long as xen-devel+linux@lists.xenprojext.org works :-) The alternative would be to come up with a different subject tag (e.g. "PATCH LINUX") but that doesn't work as it is not supported by today's Linux MAINTAINERS file. So I think xen-devel+linux is fine. From xen-devel-bounces@lists.xenproject.org Mon May 09 19:10:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324768.546971 (Exim 4.92) (envelope-from ) id 1no8m7-0005RZ-UL; Mon, 09 May 2022 19:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324768.546971; Mon, 09 May 2022 19:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8m7-0005RS-RA; Mon, 09 May 2022 19:10:31 +0000 Received: by outflank-mailman (input) for mailman id 324768; Mon, 09 May 2022 19:10:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no8m7-0005RM-0P for xen-devel@lists.xenproject.org; Mon, 09 May 2022 19:10:31 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0feb8e8-cfcb-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 21:10:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD0C5B81905; Mon, 9 May 2022 19:10:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A4D7C385B2; Mon, 9 May 2022 19:10:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0feb8e8-cfcb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652123427; bh=lTmuOdIDLlvJ7DRmxlzn/RBRVVrlQTLw1z2YtHjZGNE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HIFZ8JMeZzjy8iXj6NQMQ6a5XEZAhqxrs6MI5SZ+ra2SlrknXOK1ebdDcvsMoSY2O jEauGoshF7/sruBBPepz9prWLxT/Nr9+d1qtE3/4Vv+vSTAVZLVHtXFUhYSY/r1GdE JC8uYsppKINfeetcfZPjzEUnE6IyqMH9dTyWrwNQ+R8IO0EelfA/VVgR8CA8ncxgPc Xx7iHukiO15ELY0zH0Zt7hbN9LiDW9gSg2Ic/gJ9lvutx2YsG/C8Zk7HJ9KbAW3d3D AI83gYH+9esp0HARxMa851KiJb0nN5gz2VY2eBOktWr55vvusKZOd0tDh5jKjDIOtI rf89TBelmxjLw== Date: Mon, 9 May 2022 12:10:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Wei Chen , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 4/9] xen/arm: introduce put_page_nr and get_page_nr In-Reply-To: Message-ID: References: <20220506072502.2177828-1-Penny.Zheng@arm.com> <20220506072502.2177828-5-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 7 May 2022, Penny Zheng wrote: > > On Fri, 6 May 2022, Penny Zheng wrote: > > > Later, we need to add the right amount of references, which should be > > > the number of borrower domains, to the owner domain. Since we only > > > have > > > get_page() to increment the page reference by 1, a loop is needed per > > > page, which is inefficient and time-consuming. > > > > > > To save the loop time, this commit introduces a set of new helpers > > > put_page_nr() and get_page_nr() to increment/drop the page reference by > > nr. > > > > > > Signed-off-by: Penny Zheng > > > --- > > > v2 change: > > > - new commit > > > --- > > > xen/arch/arm/include/asm/mm.h | 4 ++++ > > > xen/arch/arm/mm.c | 36 +++++++++++++++++++++++++---------- > > > 2 files changed, 30 insertions(+), 10 deletions(-) > > > > > > diff --git a/xen/arch/arm/include/asm/mm.h > > > b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 > > > --- a/xen/arch/arm/include/asm/mm.h > > > +++ b/xen/arch/arm/include/asm/mm.h > > > @@ -347,6 +347,10 @@ void free_init_memory(void); int > > > guest_physmap_mark_populate_on_demand(struct domain *d, unsigned > > long gfn, > > > unsigned int order); > > > > > > +extern bool get_page_nr(struct page_info *page, const struct domain > > *domain, > > > + unsigned long nr); extern void > > > +put_page_nr(struct page_info *page, unsigned long nr); > > > + > > > extern void put_page_type(struct page_info *page); static inline > > > void put_page_and_type(struct page_info *page) { diff --git > > > a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4906..e565979f3c > > > 100644 > > > --- a/xen/arch/arm/mm.c > > > +++ b/xen/arch/arm/mm.c > > > @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, > > XEN_GUEST_HANDLE_PARAM(void) arg) > > > return 0; > > > } > > > > > > -struct domain *page_get_owner_and_reference(struct page_info *page) > > > +static struct domain *page_get_owner_and_nr_reference(struct page_info > > *page, > > > + unsigned long > > > +nr) > > > { > > > unsigned long x, y = page->count_info; > > > struct domain *owner; > > > @@ -1545,13 +1546,14 @@ struct domain > > *page_get_owner_and_reference(struct page_info *page) > > > do { > > > x = y; > > > /* > > > + * Consider the minimum case(nr = 1): > > > * Count == 0: Page is not allocated, so we cannot take a reference. > > > * Count == -1: Reference count would wrap, which is invalid. > > > */ > > > if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) > > > return NULL; > > > } > > > - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); > > > + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); > > > > > > owner = page_get_owner(page); > > > ASSERT(owner); > > > @@ -1559,36 +1561,50 @@ struct domain > > *page_get_owner_and_reference(struct page_info *page) > > > return owner; > > > } > > > > > > -void put_page(struct page_info *page) > > > +struct domain *page_get_owner_and_reference(struct page_info *page) { > > > + return page_get_owner_and_nr_reference(page, 1); } > > > + > > > +void put_page_nr(struct page_info *page, unsigned long nr) > > > { > > > unsigned long nx, x, y = page->count_info; > > > > > > do { > > > - ASSERT((y & PGC_count_mask) != 0); > > > + ASSERT(((y - nr) & PGC_count_mask) >= 0); > > > > Why this change? The original ASSERT is to check that we enter the loop only > > when count_info is greater than 0. It should still apply even for put_page_nr > > without modifications? > > > > > > Oh, I understand wrongly about the ASSERT. I thought it was to > check the result count_info after the loop will be not smaller than 0. > > Do you think we still need to ensure that? Maybe ASSERT( ((y & PGC_count_mask) != 0) && (((y - nr) & PGC_count_mask) >= 0)); ? I think it should be: ASSERT((y & PGC_count_mask) >= nr); From xen-devel-bounces@lists.xenproject.org Mon May 09 19:36:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:36:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324774.546982 (Exim 4.92) (envelope-from ) id 1no9Aj-0008GJ-Ri; Mon, 09 May 2022 19:35:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324774.546982; Mon, 09 May 2022 19:35:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9Aj-0008GC-Ok; Mon, 09 May 2022 19:35:57 +0000 Received: by outflank-mailman (input) for mailman id 324774; Mon, 09 May 2022 19:35:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9Ah-0008G6-OJ for xen-devel@lists.xenproject.org; Mon, 09 May 2022 19:35:56 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c52620f-cfcf-11ec-a406-831a346695d4; Mon, 09 May 2022 21:35:53 +0200 (CEST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 249H0G8S011683; Mon, 9 May 2022 19:35:48 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fwgcsmr85-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 May 2022 19:35:48 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 249JFGaV028936; Mon, 9 May 2022 19:35:46 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fwf71d3r3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 May 2022 19:35:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BYAPR10MB3653.namprd10.prod.outlook.com (2603:10b6:a03:11d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 19:35:43 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5227.023; Mon, 9 May 2022 19:35:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c52620f-cfcf-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=T+CgMYyjQkCeahmqv0vL31WZfcvhBPwpDW5yq5QCD4w=; b=HLGY4f3/XvdBmheMkWhEfwTvqBp0HFh5+ZMf5wOPL1+W0z/NQSWsP8t2fXFW3FNbBwRK 4TO6LYD0TEqJcQFD9/FbLi90+FXZy97xT81RsadaASXQY7H5YkSwcg2RSajE5ysv4c4a D/Nsq85tRm1bEU8cIIhFAVAXtYvouCDHyPwzet1VJMA0L9L4sU+6b4LR6vxY/bNZ3nED /JE9m2O4BBsh+yuFOxex/y0+beCKBWpOqKgMF4LTVtGF9EojzD+OcmGr+v3WxcEBGHbP HsgpM273DZ4qWwebUEwFFIk6w9q94Mkl0liZmJBk9gCNQDVjGqfYmFTrMmgLWNqYn7Uj bQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJ5aAVafm5E1xynfgxxw2lNwqApDpr8UzpFOzmPJ0GzwosXYgYmezP9My8URLzRndLQtg1p/N5EICTYuEGWOgKxeUc2wugreUvx/nehv3+2CWNFGrtXjcexPY5/C/pV9jbpYEf4kMVixkOZWSkajktj4rdis226wS2Leq8cYuUrPSC2or7XvkUIB3j5GY0zS31HC1wiJmz/vxL2lDdtholRsMBF1iHJUFcfm6JnT/1Bip3+3SbbMrLD2ZUnSqt7WI0PG2LC6cy1bFc69r9I+Ph8dJL1/KJG6uZiz4cXQRvtferMhAdaDWJzqnxWd0l1yze+N8mu6+qxTikLPj8LtiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T+CgMYyjQkCeahmqv0vL31WZfcvhBPwpDW5yq5QCD4w=; b=DtAGsA3mkQOToJg5q8FMYRcG1Q0qN7H0wsiKEBFOt5fZqjsgQoEfVC6a+a7pf8rdA6zE4p7lJHPNdIT2TXu0bOruACUzgip+x2vFuHXsnRy+58ZIDvu7uZlH2XPuFrxpk7oDBxHz9UPeVkdw1uUxo24pnGf0z1gIwcFgm/TNxAcIJBLRgLCCK8/IpErdTLvxEjngEz+taMvBkrM7qUWKaDAS7hLSqcEV/+AZ7Ypz8bZd/kgUmRMQpOCM7on1dN5fEwzrp4w7zXmSSMcaefHJ37GH3cBlXQ+qO7iwf9UgP24YC30pn6MMPIxCDVVPYE/bIrjfNyoNV2FrfoyjQTrUrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+CgMYyjQkCeahmqv0vL31WZfcvhBPwpDW5yq5QCD4w=; b=FIN0bFZedhCi6vCPOr0TU4pGxgtZrueg7a/UFOmvRJ56qT6ZAuE8eZ5KZf5YuwKgBDz9/Gd9tgZnmcnL4F2rv1PvamOPxPsIirnyzTj/6isMtBOuP1wqKWB4j/sLbbAxk8UYHNysKOCkicWYS8YDSn9ImekQ2Iko9tawgPfgaNM= Message-ID: <15ec8f3b-7d04-9fa2-dd32-b834fb660a89@oracle.com> Date: Mon, 9 May 2022 15:35:39 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Attributing linux related patches on xen-devel Content-Language: en-US To: Stefano Stabellini , Juergen Gross Cc: "xen-devel@lists.xenproject.org" References: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR08CA0043.namprd08.prod.outlook.com (2603:10b6:a03:117::20) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed0e3372-2a42-43d2-c17e-08da31f31b5d X-MS-TrafficTypeDiagnostic: BYAPR10MB3653:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RgUFAWZYf7YaV/cHQqUSGPNcytX0i7ezGEAyIOmMhgKUFowR2P2DcDboXUj7pvXh48DlC8sV4y5TYs7RnvNV0z4Zvl1ILW6NSfJJAY6tVHbMcamHT4khlcVjkJNz+RWU4VlAbXbEo/H38P3Gp7mGU5G+i3bgCdKYccKEkoRH2zYT5kaToUAMeFnLxRoh4SGsh0qOTzKaonrcwkY/6QP0Z8cDCuLkSpi8gv+dh0CEx+KRc8wXMlAqNiL1WYXf7XZYRIWjMHey9eXyPQxV6Z5mGn3cCr5qLr2B2dDmOxb6pEvsVd4frNyx7cK5ywAiXyU6GOOAMvHt+csg31GLUPft4pRmw86z3+dKBneYSwfmkSQ2tO5hvhXfA18VLOl+T2hD4Rd4DMCjRtwbh3+2VAbusIntUnLjC4Dhgrez/LsSN7JEdXvgZU487ltJnneKzvCoJeHru+eVoV93FyN3Qao64D3aR/jd4zlBoD7PAqXhBz1yyPKmSCMZ9whljWyrrIuAvuVD1sIUKrggCBpf3ZMFjFd3/cMSl9KAA4FVBFywq45AaOjgsWxit0rbEfBiNvWktkgvbT83S2rNAuYPOKUdNPnNrzw1Gimw5LTuWzD2gWAU4APSV54h+NSb65Cos4Vu4p1cK74fTc3BF8p1eJqs1/FvrWXbQih7cBiiXcG8egTzB4U2utn5w5O9sdbC73sL1qQTU/9P9o06T/b+bjus1A3FoYK+zIjBJMa0SKcPlBPj259Fsa+vVCezXCMpKGo0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(6506007)(53546011)(38100700002)(6486002)(508600001)(6666004)(8936002)(2616005)(186003)(26005)(6512007)(36756003)(5660300002)(110136005)(2906002)(316002)(4326008)(4744005)(66556008)(8676002)(66946007)(44832011)(66476007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjVvSzh5anJlMndLbm5SNC9aM0RtOWNQNnN1UDJvdWRQZXE0ODlHRXFvSGdw?= =?utf-8?B?Qlk0bHBKZFJUSloxL2I3K041T0VMdFgyWFR5YkJYTitqY2VIN2dtazN1ZDNa?= =?utf-8?B?Y1dGMG9telRJOGNROGp4bU91RVN2VlBVRHZqVzJJaVdodERZSTlHT1lITHkz?= =?utf-8?B?aEFnUFFEZjREcXdTVVJ2NU1LRjdKRG1zM0swdHBhaHR6RnQwZXFUVmp6dUdt?= =?utf-8?B?ZytJaUkrREljT0JZeFpwcXhaU1dyeGxJZXdMRUpoRnhIZWQzOXZVSmJuVXla?= =?utf-8?B?UjVNSnl5N1RYUTh0QW5wdnMwZG1YSzJZTWx4YW5LNzlTMXdsQndXREhEWllz?= =?utf-8?B?ZGV4ck1qV25aK1pHVGtTRXRDWjZ3Z2VGNXBjWTMvcHZGalFMWEIzUlZ0dUlS?= =?utf-8?B?S1JNRUF2aGdHdHFBaG0zR1FGYWl0WlcvODhVRC9qMGQrNDA0OGhJVG5XQW5F?= =?utf-8?B?STJjV1ZJeVg0U244eEl6Ykk0TXJwamFSdCtmQk50UVgvTS9CTUN4OGF3RzJR?= =?utf-8?B?eG1Yem5lbTZkeHV3N08ybTRjZzIvMVhhWDRmUHlRdk16REp3SnZDVGpjdWdB?= =?utf-8?B?N2dwU1ZyZ3NPS2NNTEhBclZmdmJDZmp1Mi9NWGxJOTdoWlRTYWRKUmRlU0hs?= =?utf-8?B?TjV2cWJRZFpLS1ZhYkdrYXpteEJvbGRVU3hsRjlRQXRFR1Z0YTR1MXkrMmdo?= =?utf-8?B?cm1keWl4Vk43T2d1TmdOclBjakJSVW8zaHRBd3I2ZjNNUVQzaGtwRHo1MzZ4?= =?utf-8?B?cWRKaUE5MG5XVk40eEJvWUowbkMyM2svVzNNNHdrTnhhVXVsN3FYMkZ3Ylcw?= =?utf-8?B?OEl3TVJsZ0FBZXZtUXZEckU0OGNOK08xalg0Qk9ZY0xydFN5c3ZuVVNCV3BF?= =?utf-8?B?ODhPOHYzMmliTGVHQVh5azR6RWVhWitzVHA1WFhuSnNwWk5OZ2EweWZCM2J3?= =?utf-8?B?dG5KaS8xbDc1eU9ROThrazVZOFlnREdFSm5ZQi96Rk41RnNRNFEwbDRjL2NR?= =?utf-8?B?K2N4UHo2QWdwVmlNSHIzbFVnTWlQdVp1VmtjdEMvbXZONy9KTEhCT3MyeW05?= =?utf-8?B?djJKY3phRnEwby8zVXZUUmVUYVROK25ENENJZHdmbDk4QjZrUDIzZWhPKzBR?= =?utf-8?B?R2g1MTBLeXk4TEkyeGZGVXF0cW5NZ05KbWUxeVU4ODNHSkw5NGMwNnZEQndS?= =?utf-8?B?MWN5VGM5Qkk3TDNxTWpqd3VVcXhKKzFWd2tOcUs4WTFabmRLeTJxekEzb2lH?= =?utf-8?B?UG9CUFliblhkSStjbU1mbGd2OEg0RW9GWkR2YzFwaEhwUm1jS2FmR3U4YVpy?= =?utf-8?B?NjNIdVBldi9yajZjb214ZkUyaUFOY25UaE1UejlIM0c1Wk1RdHQ2T3c3cUo0?= =?utf-8?B?aDVlY1NxTkFUZktwd0dxM3htQlZ3TDZwUVlZUTAyUHU0Zi8vS24vc3ZydDNv?= =?utf-8?B?MkVUcU9EejlPUmc3YmRFWmpHK0h2cVFHbXo3a0RhV3hJQVA4NjVweVBXSGYv?= =?utf-8?B?MS9ZSU9GcFBIb3ozRlRJY3Q0c05Na2pDTjB0ZmV5MnRtN3VLZlViTmdzeklW?= =?utf-8?B?M2xzNXc0c2RYdGZwK2lNSkF5dTYvdTZmclJUZ0U3RnVFeGZLY1RjZzF0WFIx?= =?utf-8?B?MDRwZytRUm9qaklDWFdmVHhtVXAxUXY3aXJUTS81SThyL1VTaEpuMzA3Yks2?= =?utf-8?B?Zkd1NEkwU1VZY0hKcWNnY0U3RkZNNWQ3ZmZEZWdueHVaZXVYb0dheXNmQXBC?= =?utf-8?B?RzVFNGZJTkhhUWhQYkQ5dC91SjhsbHZVVFcvOFVtUjBNZkFUUkVvKzBYeDZU?= =?utf-8?B?QU5LZ3BJZ09ZN0dXU0V5TnRCNVM5UDVOSWJzNmxsMHBGL0FjNzQxNDU4djQ5?= =?utf-8?B?dTBWd3FJMjNEbC9PN05VODg2aUpLMmUyNzl3WDAxRDJnbTFnRmwyMm9HTVRm?= =?utf-8?B?TTRESEY2Wldwa0kwQ2x0T2JuWENRejltQ0Y5UWFRWU4vbXZhU1JPU2ozUUcx?= =?utf-8?B?cXZzQkdvcndqWVBKei9YT0hnWDRXajQyOHEwMkc1TS9LTVJSemJkSE9mT09x?= =?utf-8?B?a3dxREtaRENodlZBOEdOMHV2UUdCaVk1RjN3WUtrVjdGZmpVanNzR0NyaUxM?= =?utf-8?B?QzZVejZUNndJQzR2b1I3UzZUdHlCb05VbXd3ODZlZXpHMzRyZlF2L3liYzNx?= =?utf-8?B?RXg2cmZZdzNNMVAxVFMwZk8vZUVWcUhqRlpxR3I2OGRweVIxVGM3M3Joc05T?= =?utf-8?B?dmYrQ2REUW5qR2Z3SjJGa0praHU2VnJlOHFyMXZwbzV0dkIraXBjK2dZVGky?= =?utf-8?B?YUtzMWVnd3RHV1YwcVI1blQ1Wm9YTUdDSWpMNFNRbjhHckRiWGQrVERqTnpq?= =?utf-8?Q?eKFe5yauzNivSZkk=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed0e3372-2a42-43d2-c17e-08da31f31b5d X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 19:35:43.4164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1BPqSGdgfs2szPqfyyCtBfvRFrD7aVARwDPgFmM8RtvszgjQ+Nd8XVAk0oJXPU9yDLEBKoEIYk+4pONXK0D6A2U3KjlBXpmyE+UsJM/Gmuk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3653 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-09_05:2022-05-09,2022-05-09 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205090101 X-Proofpoint-GUID: Zl_cvVY6YTMI_57jwDDROJW3S240xOcc X-Proofpoint-ORIG-GUID: Zl_cvVY6YTMI_57jwDDROJW3S240xOcc On 5/9/22 3:01 PM, Stefano Stabellini wrote: > On Mon, 9 May 2022, Juergen Gross wrote: >> On IRC the question came up whether it would be possible to have a >> special marker for Linux patches on the xen-devel ML. >> >> I suggested to use xen-devel+linux@lists.xenprojext.org for those >> patches. With a patch for the kernel's MAINTAINERS file this would >> be quite easy to achieve. >> >> Any thoughts? > Fine by me, as long as xen-devel+linux@lists.xenprojext.org works :-) > > The alternative would be to come up with a different subject tag (e.g. > "PATCH LINUX") but that doesn't work as it is not supported by today's > Linux MAINTAINERS file. > > So I think xen-devel+linux is fine. I'd prefer '-' instead of '+' but either way is fine. -boris From xen-devel-bounces@lists.xenproject.org Mon May 09 19:45:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:45:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324780.546993 (Exim 4.92) (envelope-from ) id 1no9K5-0001Rb-Q3; Mon, 09 May 2022 19:45:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324780.546993; Mon, 09 May 2022 19:45:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9K5-0001RU-Ml; Mon, 09 May 2022 19:45:37 +0000 Received: by outflank-mailman (input) for mailman id 324780; Mon, 09 May 2022 19:45:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9K3-0001R1-Ul; Mon, 09 May 2022 19:45:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9K3-0004bb-RO; Mon, 09 May 2022 19:45:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9K3-0000tU-9t; Mon, 09 May 2022 19:45:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1no9K3-0005j3-9Q; Mon, 09 May 2022 19:45:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ut6OyNV0nyWNxa7WpRByieF4mS84tzEdi3Zrdr1kF7I=; b=jTKyYshUOSGlTnkHQvjRvet9hZ /54sfPfyBUR6xScGInS7CNjxCyjchbQlZBK3zXATeP80sjGoeXW5xtg0CKx/A9p9Qmvcc3WRv1psq i+90Xlh8YxFenoY6/kp5x/u4i2VshUtzDZbDThiDGn89LZwhasH3ruOht05qh/XKotb0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170277: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 19:45:35 +0000 flight 170277 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170277/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 900 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 19:56:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:56:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324789.547004 (Exim 4.92) (envelope-from ) id 1no9U7-00036b-Uq; Mon, 09 May 2022 19:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324789.547004; Mon, 09 May 2022 19:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9U7-00036U-RP; Mon, 09 May 2022 19:55:59 +0000 Received: by outflank-mailman (input) for mailman id 324789; Mon, 09 May 2022 19:55:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9U7-00036O-1g for xen-devel@lists.xenproject.org; Mon, 09 May 2022 19:55:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0aebb477-cfd2-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 21:55:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC8A5B81910; Mon, 9 May 2022 19:55:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18A57C385B6; Mon, 9 May 2022 19:55:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aebb477-cfd2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652126155; bh=QQ+jFJnnwU/YpFNYAZy9a4tFzWXxCZoOFUz0yvOs7Mw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jVReeMSfptLqD+pTxnkqIIhwHDUXMC/sJGQ424+hkAfZuvOuUnVgf7Tk6Eah4UAij KbjpUcinVQaJNklFhN2LW0n5PM9THc6vSYdI2VuOiQ6d5TNNR7JM6FunxoKvuSWnPI C5IRa4GlRX7hFc84CfIs0p5JIAAx+BwmycR2OEcmk2irfMMuR7M5+tkvv5BOPhksC9 4q+ERT/Rx7gY1QUY+Z0qrXhyzYX6d2UeVqpGw8Y6DUlX8q4ymk0xU/zflxNesyJ9zx zjnoe5yycl0hQWQ21mjxq3lkr1tGeDXGAZcT739HBUIXb+uzX6k6fk4z/CqMS/IJEm csDEe4BffJ9BQ== Date: Mon, 9 May 2022 12:55:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Stefano Stabellini , Jan Beulich , "andrew.cooper3@citrix.com" , "julien@xen.org" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" Subject: Re: ECLAIR Xen x86 results and progress In-Reply-To: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> Message-ID: References: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 9 May 2022, Bertrand Marquis wrote: > > On 6 May 2022, at 17:31, Stefano Stabellini wrote: > > > > Hi all, > > > > Roberto kindly provided the ECLAIR x86 results: > > > > https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ > > > > Click on "See ECLAIR in action", then you can select "Show 100 entries" > > and see all the results in one page. As an example MC3R1.R1.3 > > corresponds to Rule 1.3 in the spreadsheet. > > > > > > If you are OK with this, I would like to aim at a follow-up meeting on > > Tue May 17 at the same time (8AM California / 4PM UK). If the date/time > > doesn't work, I'll run another Doodle poll. > > Works for me. Actually, to make sure more people are able to attend, I would like to suggest May 19 8AM California / 4PM UK / 5PM Europe (which is the same slot typically used by the Xen Community Call). Please let me know if that works or if it is a problem. > > By then, I am hoping that the group has already gone through the first > > 20 rules in the list, up until Rule 8.10. Is that reasonable for all of > > you? > > I completed that part of the table this morning (up to 8.14), it took me 30 minutes. Thank you! I did so as well in about the same amount of time. I think I should provide a clarification on a couple of rules that are not clear from the examples. # Rule 5.4 "Macro identifiers shall be distinct" This one is about the length of the Macro itself. C90 requires the first 31 characters to be different, while C99 requires the first 63 characteres to be different. So the problem is the following: #define this_macro_is_way_way_way_too_long #define this_macro_is_way_way_way_too_loooong I don't think we have any violations. # Rule 8.6 " An identifier with external linkage shall have exactly one external definition" This one is meant to catch cases where there are 2 definitions for 1 declaration: header.h: extern int hello; file1.c: int hello; file2: int hello; There was a question on whether having 1 declaration with no definitions would be OK, so only the following: header.h: extern int hello; for instance because file1.c has been removed from the build due to a kconfig. Reading MISRA, I don't think it is a violation of Rule 8.6. Roberto please correct me if I am wrong. Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Mon May 09 19:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 19:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324795.547014 (Exim 4.92) (envelope-from ) id 1no9WS-0003iA-Cm; Mon, 09 May 2022 19:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324795.547014; Mon, 09 May 2022 19:58:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9WS-0003i3-9u; Mon, 09 May 2022 19:58:24 +0000 Received: by outflank-mailman (input) for mailman id 324795; Mon, 09 May 2022 19:58:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1no9WQ-0003hv-N9 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 19:58:22 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f46e371-cfd2-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 21:58:20 +0200 (CEST) Received: from mail-bn8nam08lp2041.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 May 2022 15:58:17 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO2PR03MB2181.namprd03.prod.outlook.com (2603:10b6:102:14::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Mon, 9 May 2022 19:58:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Mon, 9 May 2022 19:58:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f46e371-cfd2-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652126300; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=WbqcYYVgHJuYaBndmOeD3n0mMrXfn1pCY9u6GI4npg0=; b=GTQyOrJBc1VCl+ZFUtz4rz9LkAYiJBBCnqvRRU+gwbwn3qyDOQcELfua exjUe17n7O5pTdGN+Uu4KyltMT5XssDI5GyogISmypZ6bKCmzgm4ikJF7 Sl0GPkZk0Sqf0rS8VUoOeT/4qvNI96e56OiDUMr03yf3G3V3EQe3j1jNQ Q=; X-IronPort-RemoteIP: 104.47.74.41 X-IronPort-MID: 73405879 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:W9+COq+7nBAa3LfnF+WqDrUDnn+TJUtcMsCJ2f8bNWPcYEJGY0x3y jEWXjuFaK7bZmv9eIskadjjo0kBvcWBndQwTQNqrSs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IDoW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaWtEw03I6fhpOIcQStoFHt1Yf1W8bCSdBBTseTLp6HHW13F5q0ySWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHPmMuYYwMDQY36iiGd73Y cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgA3O+fJqszeCpOB3+ISqd/XEUdm4f+l6wk2i/ lDtxHrdDg5PYbRzzhLAqBpAnNTnhjjnUYgfELm58P9Cg1CJwGEXThoMWjOTo/ajjVWlc8lCM EFS8S0rxYA481aqVZ/6RAGip2CfvQ80XMBZGOk3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIU9x7Z+RpDK2fCITfWkLYHdUSRNfu4W65oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr+hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:93Z2TqBagU5X53/lHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDTa5rPw== X-IronPort-AV: E=Sophos;i="5.91,212,1647316800"; d="scan'208";a="73405879" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgojBs7GvmcztUpj1kOrXQemuTFKzs7uXuPl1FfWFvwwmPB+GfC0YE6QbUPc5GJ/6KrIHxhwD6RjZIJHERH10uj83PuuLLLKD6JXCK90smxhuy/x5sT5CAhN5eBk70TEIR5rLdKcFq7zZum/MvvM73qZClcWqwFgc4Xx7u8NT65AR3X+sI/gvZ5CPL7Lv13M7Lf1MvDIrotWhDHO2YTuo10rV81blQThLsu2rmpOT3Ueow5bJmCvP4cKRz9IMSq2rJyY/t0LRQKtDezHefSxXuRMB194arx7/s5PpJoaIj4jTRmm4UJyRkYx4TgtLtdGw8A0B30E7NmNwCjZkCmNIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WbqcYYVgHJuYaBndmOeD3n0mMrXfn1pCY9u6GI4npg0=; b=WXTs6YbxKOjFXW8Yf8Y1850R8hjY5Slf8iJr6VqvLwCCBwB/A1jpFXwlFG/r3lVeMGfsW84qSgu9ZO8bevmFxqOE1jPXFCfFtalUBwx2lqfApDBFzTMnqZ+B++ofO5qu/ngzRpo5jnwczfyQ75m8VcV0l3EUpIVqEcwoMRdmanA5bXV34sK+GBPkPyQToI4ohSDymybil1SgtS1NyI/Ks8M3bU6O96s4/mab+q402GNVXT8gNFhnwqAOA2bPt04c90rawad9I0pBZzxy75wunofJugwP/mb+ri2tkFXBz452Gdah8/Q/bvFvNkM8VjnyWFDEdu8xTYBPukPoQmM1Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WbqcYYVgHJuYaBndmOeD3n0mMrXfn1pCY9u6GI4npg0=; b=nOd1idY29JtvjwVKzPpdMnYZprCeejHw9XDxE/1zyoSZN0akf957/8EfOumPBJB0JW0RHJ57Tl/ysQ2Tw9Oykqzzlc5CdO3Ksh+GNgr72d3qDrZRWaec1kipoIXSv5Io5yhiTPc4I4X2Jdz2U42AVQ73jw4y7ecNNvwujXEw3bU= From: Andrew Cooper To: Stefano Stabellini , Juergen Gross CC: Boris Ostrovsky , xen-devel Subject: Re: Attributing linux related patches on xen-devel Thread-Topic: Attributing linux related patches on xen-devel Thread-Index: AQHYY72xbnLDDfw++ka99EP7Gb4Sqa0W5wEAgAAHugCAAAgEgA== Date: Mon, 9 May 2022 19:58:13 +0000 Message-ID: References: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> <53eed7eb-e563-2ec0-262d-a96f092d683a@citrix.com> In-Reply-To: <53eed7eb-e563-2ec0-262d-a96f092d683a@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0d3385f-8b00-48a8-d3c0-08da31f64016 x-ms-traffictypediagnostic: CO2PR03MB2181:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 674gfXqEJrJM2xXidn1DU0pB1FRNPKNj5cbDEeGBA4e2NKKYV8Tra4wiqLOp6WIbuYp801lgIg7BUa8n5kaZJaQmv1/0nsYky/e2YsT3SyKcBgBa9R9pqCrTVsMY6V5wyi/Zu2Vu+7KLm+G1nvHsNdqprpsAgBqCeYrxnz1d13K7s/UtHxEPQU1sO7oWrB9u4aFhIy+L8WTiIaudiYBMpjMTZ2PhdFoI4DeYiWHSNi69XyxxHyXH1s3ac6XlQTZJVC5roPESDmh0dQKETkHHKQF99KXtJde1La8m15z2UvQmhtltcVcPPW3em2OVu/pyDECKvqyH7A1g9fKUyTudNA+btARwY+DJoa/mCKKfsTsmyZyvltd9X/NcxTN1fynaYricJDJ0uF/zFDQdtRHTXTYHiFlvCU6ZF+8z/BSkc31QcsytI2KycSeYK9nusC1feloU8omkKPEpmDwLO/b/XJTfkdeGHT2FlFcV7n+3pXkT9bQtSAz3HR7JtHVcXUjCkRJ1++atQeMzTbZ8+aQC/DIJZkzR95Ph9JK1E6LIzdyTMoJq83gc31AW+ecE9SiQZtRTyfOC19lxxnuuvitw/d+VhfuKAXkP7cTBWQTCYAKa/gauPbIwQj9Ira0Slv3eao+1zKlRTfSAHFxFMYrU+h581G0IHwgzrgXxWjd/pDbX2/qiqu4h6gwZ0wwb6VYsc5+MLfiBGz34evv9OoxbEWdRJ08NEcK5ZBXZwgR4DdUYcUHNNGJvcn3YmKYaBpendEJsCDAMmc9+VjHojzR2ug== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(31696002)(91956017)(71200400001)(26005)(53546011)(83380400001)(66476007)(8676002)(66446008)(76116006)(66556008)(66946007)(64756008)(8936002)(508600001)(186003)(38070700005)(6506007)(5660300002)(4744005)(2616005)(2906002)(6512007)(4326008)(54906003)(82960400001)(6486002)(122000001)(316002)(110136005)(36756003)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NHMrcFJmYWdhMW80OFU1QlprRUt1VjVXWTdzM3l3V2kvYm45Zi9rcGcwVFIw?= =?utf-8?B?dUFjQWc5Z25UZWI2WFJLRmorcGdqN2dCMmFnbkFMSDlDTThQT3gyeWNuVEJm?= =?utf-8?B?bU1Qeld6bnR1eGZkbU9XM2NMOVhhVGdzMkVYMEJnQ1BPL2VDK0RZMEJNSUdB?= =?utf-8?B?NkZaS0lBTFVPQjRvemhjWSt6Zzh3c3kyVzVsV0RNak5HcVlkQW1jNW15SGlO?= =?utf-8?B?dUFtWXJTOVBNQUhDUm81OHFSbGF2Sm4xYnBSYnQwd2ROeEFsNUFWcjRXaFg2?= =?utf-8?B?QWR0bVE1YnRLYUExV3J4dnNOQjdmUjVhZXN5dkRmZHBCVGUyR1I0cmgzTTJ3?= =?utf-8?B?R0hTNExUdzJJR2JrVW9uZ3piNE9IMnkyUzlodGJSSkRrbDFzZ2FOck82U2N4?= =?utf-8?B?SWxZWlM5UWNLL1R1Vnl6aGtKM3VXaHV2NGYzUE9MSFlKaUtsMHg0UEVEQjNi?= =?utf-8?B?cTVqcTZvN3Frb2I0N2VQZEZKS3FJcC9IUTRLRG1nS1R0ZEdlWFkzQmZCOGpa?= =?utf-8?B?TW1oeTdGTkZKUWZ4OGFHSGpyQUVwWDVqRHRzZ1lkaGlyNXBNNGNyT2MvbWFx?= =?utf-8?B?djV6WjRDaG83V01iL2RXUmJEZCs2TXZQQk44VkV4c2FMZFRrR2JhTzg5c3lp?= =?utf-8?B?SUFxTVZwcUZmQ0RpTGlLc1VQcnRUMHhoWGxjcFZYRHU0ejBacFJWRE5YczZr?= =?utf-8?B?SlltaElUVzhTQ2JaTXFRY1ZEOXYydzFnLzQ4ekZrOFpKL3YvU09tM3dPczZN?= =?utf-8?B?TVVFenJHdjg4dTU4d2NyTC92TEh6ZlNKNXptTW5SMzhvZDhCaldMTU5qNnk4?= =?utf-8?B?QS9pQUsrNGRVV1g4NWdxNjBlZEFJOU1zdGt1WUtZSnNmMCs5YjIraXNiNzNr?= =?utf-8?B?ZGh3NGN6cWFRdVNhSU94dkhRZThST2oxamltVmM3TE1uUmhZZUhXdHBUUmVt?= =?utf-8?B?cXhzOVRPd2F6b2dGVHZRQ1dlOTVlUS9pUHk1TFBnbnJrSGJrd0NMZk8rd09T?= =?utf-8?B?aWVKbkNYNEdRS2dleC9ibXRYUnBkL3NjT0dZUEU4Z3ZjVjJpSUp3aW1BWjRG?= =?utf-8?B?UEFacWRhQ2JhVlQyYUNQTkIrSFdVU2Nqby8vZlFFakdaY0JFQ3l2RE1aK0N6?= =?utf-8?B?ai9MREoya2VrR0hTbUtTcE80N0o1cmpIOWREVFZxNzVIdkM3M0NHZ1ZjUWlE?= =?utf-8?B?YzJXWS9uM0FhUGlKWUR6eFRwcU9kY2hjMzhBT2wzZkw0U0ErZU8reTMxQ2tq?= =?utf-8?B?cmU1L2ZpN25IbHZnbzJHM2lhWDhzeWJRbnhtYWxTYWZRa3VwQW1LQTFVOUVy?= =?utf-8?B?R1p4UEx6RWljOTlxeE13TGFwcXJkV2V6V1NiekJQNlZFNm5sWE9TL3BrWm1V?= =?utf-8?B?WGFkMnVQRlMxSGkwWjg4RStqbENyeStTZmdNNUNtT3ROb001aGJ3UUtXK1dF?= =?utf-8?B?bmdwYjlZZFVoVEc4VTYyemZvcWpNQkFvL0JUdWdaeExvRXJqalpJUHVBWjM3?= =?utf-8?B?dXBXVUpWaUJiTlZER0grRXp4MWlZWXVib1p4R3Z0QTBISlIyQW8vYllNVkVD?= =?utf-8?B?dUt4Y3llVDhnRUJsdGlnUGsvc3QrTGhrcTRXNFJwTGg0ak1rUXJuUmtYbGVz?= =?utf-8?B?dVo3T3l4WkVXdDc0b2RJUkJmMXVxWDhXUHJyK2FQZnkxYUJEN1l1dzhnaFVY?= =?utf-8?B?Y0liNTZrYlRJN0R0Y1hjZCtOVXVHZUc5V1loWEM4M2ovMkYzQ1p5citIS0d6?= =?utf-8?B?b25WdEUzdXhBL1dYM0VIMTNYeWc0NE5kOUpnSEZxbzJ4WlRLVmJlRlpFOGlS?= =?utf-8?B?cjJpVUNZUXRuU3JHVWpHSEFVZ1I0RjhyeThBWUFKU29WZGlxazRlWnI2Y21G?= =?utf-8?B?QWpFQmZzbEp6QktSUkNOTWRiY0Zla055dks2TG5FcEVTdWRuaXJrOWkyU1lW?= =?utf-8?B?dmV5QUk1bVZnT2Zkd2duRUZqN1FUTEUyN3N0SktWSlBiK3VDMVFhOWswOHhl?= =?utf-8?B?bnVYZWxHT0htVGU1T2JLNGpTVmdvTnliaE9oa0p5NkRGOGRYWThIcStnT2hS?= =?utf-8?B?SmtDNEg4VzFxbXBlaFozN3pEbGZtdVl3ck9OTjRBWEY0eXNIQkc3L05tbXB6?= =?utf-8?B?MDYyL3hGNmNFRlQzOWlaTjY5NjhCaHY1N0x2VFhJdGNJSVVSUnJOL1duTU1j?= =?utf-8?B?T0o2RUZwanhINitpYXBsbkdmeTFvVTg1eW9tSWZoaUlFVVhjdHVWLzBQUXFk?= =?utf-8?B?WDMzeUVubmVBQ1VzZkhnUkVPcVB0b0MxK2s1ZDRrc3lITGs1UmtmQUFiM0F3?= =?utf-8?B?RGk2cmM1TlVnRXpvZWI4Y2JEajJ4ZkJWeXFRWkxrZDRjWFBvMGRBVGhFUThz?= =?utf-8?Q?VuUfOGXtAyUw48I0=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0d3385f-8b00-48a8-d3c0-08da31f64016 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2022 19:58:13.2831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m3TNolkQxmt0qCySbOp4Dhr1P8aRdMaN6pF+YjeSpwKwKv8jcEkSSuMS42RoTB0cSiRT8Jv+FD6YpqwnJ4xIdD5r8uPWlaqj7RyIMMM5sPQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2181 T24gMDkvMDUvMjAyMiAyMDoyOSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDkvMDUvMjAy MiAyMDowMSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4gT24gTW9uLCA5IE1heSAyMDIy LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+IE9uIElSQyB0aGUgcXVlc3Rpb24gY2FtZSB1cCB3 aGV0aGVyIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGhhdmUgYQ0KPj4+IHNwZWNpYWwgbWFya2Vy IGZvciBMaW51eCBwYXRjaGVzIG9uIHRoZSB4ZW4tZGV2ZWwgTUwuDQo+Pj4NCj4+PiBJIHN1Z2dl c3RlZCB0byB1c2UgeGVuLWRldmVsK2xpbnV4QGxpc3RzLnhlbnByb2pleHQub3JnIGZvciB0aG9z ZQ0KPj4+IHBhdGNoZXMuIFdpdGggYSBwYXRjaCBmb3IgdGhlIGtlcm5lbCdzIE1BSU5UQUlORVJT IGZpbGUgdGhpcyB3b3VsZA0KPj4+IGJlIHF1aXRlIGVhc3kgdG8gYWNoaWV2ZS4NCj4+Pg0KPj4+ IEFueSB0aG91Z2h0cz8NCj4+IEZpbmUgYnkgbWUsIGFzIGxvbmcgYXMgeGVuLWRldmVsK2xpbnV4 QGxpc3RzLnhlbnByb2pleHQub3JnIHdvcmtzIDotKQ0KPiBXZWxsLCB0aGF0IG9uZSBkb2Vzbid0 Li4uDQo+DQo+IExldHMgdHJ5ICh0YWtlIDIpLg0KDQpOb3BlLg0KDQpUaGUgZm9sbG93aW5nIG1l c3NhZ2UgdG8gPHhlbi1kZXZlbCtsaW51eEBsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gd2FzDQp1bmRl bGl2ZXJhYmxlLg0KVGhlIHJlYXNvbiBmb3IgdGhlIHByb2JsZW06DQo1LjEuMCAtIFVua25vd24g YWRkcmVzcyBlcnJvciA1NTAtJzQuNy4xIFVucm91dGVhYmxlIGFkZHJlc3MnDQoNCldlJ2xsIG5l ZWQgdG8gZG8gc29tZSByZWNvbmZpZ3VyYXRpb24gZmlyc3QuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon May 09 20:35:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 20:35:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324802.547025 (Exim 4.92) (envelope-from ) id 1noA6P-0008Px-9m; Mon, 09 May 2022 20:35:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324802.547025; Mon, 09 May 2022 20:35:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noA6P-0008Pq-6y; Mon, 09 May 2022 20:35:33 +0000 Received: by outflank-mailman (input) for mailman id 324802; Mon, 09 May 2022 20:35:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noA6N-0008Pk-Od for xen-devel@lists.xenproject.org; Mon, 09 May 2022 20:35:31 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90a6cbc6-cfd7-11ec-a406-831a346695d4; Mon, 09 May 2022 22:35:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD758616EB; Mon, 9 May 2022 20:35:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F63AC385BA; Mon, 9 May 2022 20:35:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90a6cbc6-cfd7-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652128528; bh=JCyEzhSs3fnamCMlMIPypnKlHjQavh2tngborH1qRgM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=U/WOUBKvKbEQNou1Mkn5jl6u6yvfq2mTfppnqrU893UsQADjdb3fKsZshufBgd1Xx 3VBJXr4IFRWnUhQMSzARifhcT3coIPKRlcJcKMRnwUTtX/XCYNyBA2OWBJd6Q47SLO JKuFuDR32hMYnkfv6aGpvMsZhKQT7Q/hPix1HhYsoD7w3uWhUBOqxhKQSGpnY+V8KP o8Nmr1+YMikqLrEOyYxdtjMIrayTa2Gqz11zsbnTxgTTA/2MlIQOEDOrqNu57ifHkX K6g2xcp0d4SEMJAMp9P639Sz8ct4U6S6uscr3nKtFHimyj6dncSyUiZJMjTOwLUcHC JZQE58/efcnkA== Date: Mon, 9 May 2022 13:35:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , Anthony PERARD , Juergen Gross , Dario Faggioli , George Dunlap , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v8 0/7] Boot time cpupools In-Reply-To: <20220506120012.32326-1-luca.fancellu@arm.com> Message-ID: References: <20220506120012.32326-1-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 6 May 2022, Luca Fancellu wrote: > *** Resending the serie adding the maintainers *** > *** Patches #4 and #6 needs a review from the maintainer of that area *** Committed, thanks! From xen-devel-bounces@lists.xenproject.org Mon May 09 20:51:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 20:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324815.547065 (Exim 4.92) (envelope-from ) id 1noALF-0002j7-St; Mon, 09 May 2022 20:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324815.547065; Mon, 09 May 2022 20:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noALF-0002j0-Pw; Mon, 09 May 2022 20:50:53 +0000 Received: by outflank-mailman (input) for mailman id 324815; Mon, 09 May 2022 20:50:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noALD-0002iu-Ic for xen-devel@lists.xenproject.org; Mon, 09 May 2022 20:50:51 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b475cc16-cfd9-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 22:50:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DDF90B81982; Mon, 9 May 2022 20:50:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DA89C385BB; Mon, 9 May 2022 20:50:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b475cc16-cfd9-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652129446; bh=xJHKAPfi/62DzZrgyAcgK/3GP9N1eeUJPC8tNsGbC/8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OCsW31iwPo53roGuztxOUUJxd3Pk3rzXTicz9ZdgmgI6CE6wzk0QZx1QUaXlWoiV6 /B/+E5OBp63Fbi0ocYZO3lgYZ5O6KyhelIDqATrPghS/tr8fBLDcgxCTpfaoR11zMt 1gaVtA6Q+CDAwPcAUYQG6OQs7ux6lOgegQS+UCF4iV+AauM5VR8XIBA53acBcLbNAZ uqFt1nR+Ul/kbzAgaTOGmW/OyRTmCByGPEwEXXVm0Xox+hKLCzHsC3waycnUkxeEPu 9xWMB30QaAvbKaB/9hloNrafhwhRjbV2txYxpVWtgKgKgngYr9a+9xC8AuLxsqr0Xo mrfZLUCECl9Fg== Date: Mon, 9 May 2022 13:50:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling In-Reply-To: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> Message-ID: References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 May 2022, Rahul Singh wrote: > This patch introduces a new feature to support the signaling between > two domains in dom0less system. > > Signed-off-by: Rahul Singh > --- > v2 changes: > - switch to the one-subnode-per-evtchn under xen,domain" compatible node. > - Add more detail about event-channel > --- > docs/designs/dom0less-evtchn.md | 126 ++++++++++++++++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 docs/designs/dom0less-evtchn.md > > diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md > new file mode 100644 > index 0000000000..62ec8a4009 > --- /dev/null > +++ b/docs/designs/dom0less-evtchn.md > @@ -0,0 +1,126 @@ > +# Signaling support between two domUs on dom0less system > + > +## Current state:???Draft version Something went wrong with the encoding of this email. Aside from that the proposal looks good to me. Thanks Rahul! Reviewed-by: Stefano Stabellini > +## Proposer(s): Rahul Singh, Bertrand Marquis > + > +## Problem Statement: > + > +Dom0less guests would benefit from a statically-defined memory sharing and > +signally system for communication. One that would be immediately available at > +boot without any need for dynamic configurations. > + > +In embedded a great variety of guest operating system kernels exist, many of > +which don't have support for xenstore, grant table, or other complex drivers. > +Some of them are small kernel-space applications (often called "baremetal", > +not to be confused with the term "baremetal" used in the data center which > +means "without hypervisors") or RTOSes. Additionally, for safety reasons, users > +often need to be able to configure the full system statically so that it can > +be verified statically. > + > +Event channels are very simple and can be added even to baremetal applications. > +This proposal introduces a way to define them statically to make them suitable > +for dom0less embedded deployments. > + > +## Proposal: > + > +Event channels are the basic primitive provided by Xen for event notifications. > +An event channel is a logical connection between 2 domains (more specifically > +between dom1,port1, and dom2,port2). Each event has a pending and a masked bit. > +The pending bit indicates the event has been raised. The masked bit is used by > +the domain to prevent the delivery of that specific event. Xen only performs a > +0 ??? 1 transition on the pending bits and does not touch the mask bit. The > +domain may toggle masked bits in the masked bit field and should clear the > +pending bit when an event has been processed > + > +Events are received by a domain via an interrupt from Xen to the domain, > +indicating when an event arrives (setting the bit). Further notifications are > +blocked until the bit is cleared again. Events are delivered asynchronously to > +a domain and are enqueued when the domain is not running. > +More information about FIFO based event channel can be found at: > +https://xenbits.xen.org/people/dvrabel/event-channels-H.pdf > + > +The event channel communication will be established statically between two > +domains (dom0 and domU also) before unpausing the domains after domain creation. > +Event channel connection information between domains will be passed to XEN via > +the device tree node. The event channel will be created and established > +beforehand in XEN before the domain started. The domain doesn???t need to do any > +operation to establish a connection. Domain only needs hypercall > +EVTCHNOP_send(local port) to send notifications to the remote guest. > + > +There is no need to describe the static event channel info in the domU device > +tree. Static event channels are only useful in fully static configurations, > +and in those configurations the domU device tree dynamically generated by Xen > +is not needed. > + > +Under the "xen,domain" compatible node, there need to be sub-nodes with > +compatible "xen,evtchn" that describe the event channel connection between two > +domains(dom0 and domU also). > + > +The event channel sub-node has the following properties: > + > +- compatible > + > + "xen,evtchn" > + > +- xen,evtchn > + > + The property is tuples of two numbers > + (local-evtchn link-to-foreign-evtchn) where: > + > + local-evtchn is an integer value that will be used to allocate local port > + for a domain to send and receive event notifications to/from the remote > + domain. > + > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > + local-evtchn will be connected. > + > + > +Example: > + > + chosen { > + .... > + > + domU1: domU1 { > + compatible = "xen,domain"; > + > + /* one sub-node per local event channel */ > + ec1: evtchn@1 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec3>; > + }; > + > + ec2: evtchn@2 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xc &ec4>; > + }; > + .... > + }; > + > + domU2: domU2 { > + compatible = "xen,domain"; > + > + /* one sub-node per local event channel */ > + ec3: evtchn@3 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xb &ec1>; > + }; > + > + ec4: evtchn@4 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xd &ec2>; > + }; > + .... > + }; > + }; > + > +In above example two event channel comunication will be established between > +domU1 and domU2. > + > + domU1 (port 0xa) <-----------------> domU2 (port 0xb) > + domU1 (port 0xc) <-----------------> domU2 (port 0xd) > + > +domU1 and domU2 can send the signal to remote domain via hypercall > +EVTCHNOP_send(.) on local port. > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon May 09 21:39:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 21:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324823.547087 (Exim 4.92) (envelope-from ) id 1noB65-0007zn-UN; Mon, 09 May 2022 21:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324823.547087; Mon, 09 May 2022 21:39:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB65-0007zg-Qo; Mon, 09 May 2022 21:39:17 +0000 Received: by outflank-mailman (input) for mailman id 324823; Mon, 09 May 2022 21:39:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB64-0007ym-9u for xen-devel@lists.xenproject.org; Mon, 09 May 2022 21:39:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7865f89e-cfe0-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 23:39:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0D8E61746; Mon, 9 May 2022 21:39:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35EC9C385BA; Mon, 9 May 2022 21:39:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7865f89e-cfe0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652132353; bh=H2dwaPwrXL4nxxXBdrMYB4OYXvEzLLPVoM3JTYQ5/l8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Me4tlFG4jGnLbuMeyoXfSkn5ct7XSBu3oHjHxskr6Fpm7aFmYoNMlvHM6QLhqvMbc tPpOOo4ntqvnBaahgw60upteBF05PNLgjTAaVZ2BBJHkP+xenkUOZG5P9BVoZqmJ4V 6QXU5VSj2B6uogMr4U+u4JWx4vTnEhF0hoVHBGXueVpLhsyHQj3wTA70E/R0ZcRCCw jWBsrRIBUu6+2LgYxAeipVJBCaiFtAaq9O3LEtz5tnxSAhfRpuUoT4x8BZHKQkamXy ZgZ5DkQWP2ewyhCNgnsUHZxThyGny2cUFN7u3HrvAbNSua7hViTu0JF2ItIrLlX8Ol feJ9kW4H8CUWw== Date: Mon, 9 May 2022 14:39:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Juergen Gross , Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V2 4/7] xen/virtio: Enable restricted memory access using Xen grant mappings In-Reply-To: <1651947548-4055-5-git-send-email-olekstysh@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-5-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 7 May 2022, Oleksandr Tyshchenko wrote: > From: Juergen Gross > > In order to support virtio in Xen guests add a config option XEN_VIRTIO > enabling the user to specify whether in all Xen guests virtio should > be able to access memory via Xen grant mappings only on the host side. > > Also set PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS feature from the guest > initialization code on Arm and x86 if CONFIG_XEN_VIRTIO is enabled. > > Signed-off-by: Juergen Gross > Signed-off-by: Oleksandr Tyshchenko The patch looks OK to me Reviewed-by: Stefano Stabellini > --- > Changes V1 -> V2: > - new patch, split required changes from commit: > "[PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen" > - rework according to new platform_has() infrastructure > --- > arch/arm/xen/enlighten.c | 2 ++ > arch/x86/xen/enlighten_hvm.c | 2 ++ > arch/x86/xen/enlighten_pv.c | 2 ++ > drivers/xen/Kconfig | 11 +++++++++++ > include/xen/xen.h | 8 ++++++++ > 5 files changed, 25 insertions(+) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index 07eb69f..1f9c3ba 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -443,6 +443,8 @@ static int __init xen_guest_init(void) > if (!xen_domain()) > return 0; > > + xen_set_restricted_virtio_memory_access(); > + > if (!acpi_disabled) > xen_acpi_guest_init(); > else > diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c > index 517a9d8..8b71b1d 100644 > --- a/arch/x86/xen/enlighten_hvm.c > +++ b/arch/x86/xen/enlighten_hvm.c > @@ -195,6 +195,8 @@ static void __init xen_hvm_guest_init(void) > if (xen_pv_domain()) > return; > > + xen_set_restricted_virtio_memory_access(); > + > init_hvm_pv_info(); > > reserve_shared_info(); > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c > index 5038edb..fcd5d5d 100644 > --- a/arch/x86/xen/enlighten_pv.c > +++ b/arch/x86/xen/enlighten_pv.c > @@ -109,6 +109,8 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc); > > static void __init xen_pv_init_platform(void) > { > + xen_set_restricted_virtio_memory_access(); > + > populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP)); > > set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info); > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index 313a9127..a7bd8ce 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -339,4 +339,15 @@ config XEN_GRANT_DMA_OPS > bool > select DMA_OPS > > +config XEN_VIRTIO > + bool "Xen virtio support" > + depends on VIRTIO > + select XEN_GRANT_DMA_OPS > + help > + Enable virtio support for running as Xen guest. Depending on the > + guest type this will require special support on the backend side > + (qemu or kernel, depending on the virtio device types used). > + > + If in doubt, say n. > + > endmenu > diff --git a/include/xen/xen.h b/include/xen/xen.h > index a99bab8..0780a81 100644 > --- a/include/xen/xen.h > +++ b/include/xen/xen.h > @@ -52,6 +52,14 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, > extern u64 xen_saved_max_mem_size; > #endif > > +#include > + > +static inline void xen_set_restricted_virtio_memory_access(void) > +{ > + if (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain()) > + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); > +} > + > #ifdef CONFIG_XEN_UNPOPULATED_ALLOC > int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages); > void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages); From xen-devel-bounces@lists.xenproject.org Mon May 09 21:39:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 21:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324822.547075 (Exim 4.92) (envelope-from ) id 1noB5z-0007iw-Lo; Mon, 09 May 2022 21:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324822.547075; Mon, 09 May 2022 21:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB5z-0007ip-J2; Mon, 09 May 2022 21:39:11 +0000 Received: by outflank-mailman (input) for mailman id 324822; Mon, 09 May 2022 21:39:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB5x-0007ij-SN for xen-devel@lists.xenproject.org; Mon, 09 May 2022 21:39:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73fe1fab-cfe0-11ec-a406-831a346695d4; Mon, 09 May 2022 23:39:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 331A46173D; Mon, 9 May 2022 21:39:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01498C385BF; Mon, 9 May 2022 21:39:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73fe1fab-cfe0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652132345; bh=Dbtg2A5V81LNmPefQmULq927PV8gft+l2ipWRJFWT7s=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g6CDK1MLOQhA5reDjuBvvixu6InPhbiwWfeAZ5S82+Fc/OqF7xH0FzXZyX3xU7AvA THUskIIobad3C2c1jIiWb5tED9BreTCOydBjR07o4GVyQ6HVsmZkCmP8X13OKX9uKL QlQcfONiRYujYaVQVbN7fiH4OQrUUaVgHzF2VFvd9WoTilIg3mDK777XuqJUFr4kmB 0+YmguCnzd6IrDslQpUJya1uJpn7xzGeDy/uSWZc8sdJz0XQf8D85pJDtz2sUSimFZ b8kMsnGKfIDP+oR4ylKYZzCXlxTxFdTfxEVh5iQl3o8wkIjGJZoZhTpQ4FufPaYADl xGyGpsgabRJzg== Date: Mon, 9 May 2022 14:39:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V2 3/7] xen/grant-dma-ops: Add option to restrict memory access under Xen In-Reply-To: <1651947548-4055-4-git-send-email-olekstysh@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-4-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1745592087-1652131303=:43560" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1745592087-1652131303=:43560 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Sat, 7 May 2022, Oleksandr Tyshchenko wrote: > From: Juergen Gross > > Introduce Xen grant DMA-mapping layer which contains special DMA-mapping > routines for providing grant references as DMA addresses to be used by > frontends (e.g. virtio) in Xen guests. > > Add the needed functionality by providing a special set of DMA ops > handling the needed grant operations for the I/O pages. > > The subsequent commit will introduce the use case for xen-grant DMA ops > layer to enable using virtio devices in Xen guests in a safe manner. > > Signed-off-by: Juergen Gross > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini > --- > Changes RFC -> V1: > - squash with almost all changes from commit (except handling "xen,dev-domid" > property): > "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" > - update commit subject/description and comments in code > - leave only single Kconfig option XEN_VIRTIO and remove architectural > dependencies > - introduce common xen_has_restricted_virtio_memory_access() in xen.h > and update arch_has_restricted_virtio_memory_access() for both > Arm and x86 to call new helper > - use (1ULL << 63) instead of 0x8000000000000000ULL for XEN_GRANT_ADDR_OFF > - implement xen_virtio_dma_map(unmap)_sg() using example in swiotlb-xen.c > - optimize padding by moving "broken" field in struct xen_virtio_data > - remove unneeded per-device spinlock > - remove the inclusion of virtio_config.h > - remane everything according to the new naming scheme: > s/virtio/grant_dma > - add new hidden config option XEN_GRANT_DMA_OPS > > Changes V1 -> V2: > - fix checkpatch.pl warnings > - remove the inclusion of linux/pci.h > - rework to use xarray for data context > - remove EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops); > - remove the line of * after SPDX-License-Identifier > - split changes into grant-dma-ops.c and arch_has_restricted_virtio_memory_access() > and update commit subject/description accordingly > - remove "default n" for config XEN_VIRTIO > - implement xen_grant_dma_alloc(free)_pages() > --- > drivers/xen/Kconfig | 4 + > drivers/xen/Makefile | 1 + > drivers/xen/grant-dma-ops.c | 314 ++++++++++++++++++++++++++++++++++++++++++++ > include/xen/xen-ops.h | 8 ++ > 4 files changed, 327 insertions(+) > create mode 100644 drivers/xen/grant-dma-ops.c > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index 120d32f..313a9127 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -335,4 +335,8 @@ config XEN_UNPOPULATED_ALLOC > having to balloon out RAM regions in order to obtain physical memory > space to create such mappings. > > +config XEN_GRANT_DMA_OPS > + bool > + select DMA_OPS > + > endmenu > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 5aae66e..1a23cb0 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -39,3 +39,4 @@ xen-gntalloc-y := gntalloc.o > xen-privcmd-y := privcmd.o privcmd-buf.o > obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF) += xen-front-pgdir-shbuf.o > obj-$(CONFIG_XEN_UNPOPULATED_ALLOC) += unpopulated-alloc.o > +obj-$(CONFIG_XEN_GRANT_DMA_OPS) += grant-dma-ops.o > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c > new file mode 100644 > index 00000000..29ad7bf > --- /dev/null > +++ b/drivers/xen/grant-dma-ops.c > @@ -0,0 +1,314 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Xen grant DMA-mapping layer - contains special DMA-mapping routines > + * for providing grant references as DMA addresses to be used by frontends > + * (e.g. virtio) in Xen guests > + * > + * Copyright (c) 2021, Juergen Gross > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct xen_grant_dma_data { > + /* The ID of backend domain */ > + domid_t dev_domid; > + /* Is device behaving sane? */ > + bool broken; > +}; > + > +static DEFINE_XARRAY(xen_grant_dma_devices); > + > +#define XEN_GRANT_DMA_ADDR_OFF (1ULL << 63) > + > +static inline dma_addr_t grant_to_dma(grant_ref_t grant) > +{ > + return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT); > +} > + > +static inline grant_ref_t dma_to_grant(dma_addr_t dma) > +{ > + return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT); > +} > + > +static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) > +{ > + struct xen_grant_dma_data *data; > + > + xa_lock(&xen_grant_dma_devices); > + data = xa_load(&xen_grant_dma_devices, (unsigned long)dev); > + xa_unlock(&xen_grant_dma_devices); > + > + return data; > +} > + > +/* > + * DMA ops for Xen frontends (e.g. virtio). > + * > + * Used to act as a kind of software IOMMU for Xen guests by using grants as > + * DMA addresses. > + * Such a DMA address is formed by using the grant reference as a frame > + * number and setting the highest address bit (this bit is for the backend > + * to be able to distinguish it from e.g. a mmio address). > + * > + * Note that for now we hard wire dom0 to be the backend domain. In order > + * to support any domain as backend we'd need to add a way to communicate > + * the domid of this backend, e.g. via Xenstore, via the PCI-device's > + * config space or DT/ACPI. > + */ > +static void *xen_grant_dma_alloc(struct device *dev, size_t size, > + dma_addr_t *dma_handle, gfp_t gfp, > + unsigned long attrs) > +{ > + struct xen_grant_dma_data *data; > + unsigned int i, n_pages = PFN_UP(size); > + unsigned long pfn; > + grant_ref_t grant; > + void *ret; > + > + data = find_xen_grant_dma_data(dev); > + if (!data) > + return NULL; > + > + if (unlikely(data->broken)) > + return NULL; > + > + ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp); > + if (!ret) > + return NULL; > + > + pfn = virt_to_pfn(ret); > + > + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) { > + free_pages_exact(ret, n_pages * PAGE_SIZE); > + return NULL; > + } > + > + for (i = 0; i < n_pages; i++) { > + gnttab_grant_foreign_access_ref(grant + i, data->dev_domid, > + pfn_to_gfn(pfn + i), 0); > + } > + > + *dma_handle = grant_to_dma(grant); > + > + return ret; > +} > + > +static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr, > + dma_addr_t dma_handle, unsigned long attrs) > +{ > + struct xen_grant_dma_data *data; > + unsigned int i, n_pages = PFN_UP(size); > + grant_ref_t grant; > + > + data = find_xen_grant_dma_data(dev); > + if (!data) > + return; > + > + if (unlikely(data->broken)) > + return; > + > + grant = dma_to_grant(dma_handle); > + > + for (i = 0; i < n_pages; i++) { > + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { > + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); > + data->broken = true; > + return; > + } > + } > + > + gnttab_free_grant_reference_seq(grant, n_pages); > + > + free_pages_exact(vaddr, n_pages * PAGE_SIZE); > +} > + > +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size, > + dma_addr_t *dma_handle, > + enum dma_data_direction dir, > + gfp_t gfp) > +{ > + void *vaddr; > + > + vaddr = xen_grant_dma_alloc(dev, size, dma_handle, gfp, 0); > + if (!vaddr) > + return NULL; > + > + return virt_to_page(vaddr); > +} > + > +static void xen_grant_dma_free_pages(struct device *dev, size_t size, > + struct page *vaddr, dma_addr_t dma_handle, > + enum dma_data_direction dir) > +{ > + xen_grant_dma_free(dev, size, page_to_virt(vaddr), dma_handle, 0); > +} > + > +static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page, > + unsigned long offset, size_t size, > + enum dma_data_direction dir, > + unsigned long attrs) > +{ > + struct xen_grant_dma_data *data; > + unsigned int i, n_pages = PFN_UP(size); > + grant_ref_t grant; > + dma_addr_t dma_handle; > + > + if (WARN_ON(dir == DMA_NONE)) > + return DMA_MAPPING_ERROR; > + > + data = find_xen_grant_dma_data(dev); > + if (!data) > + return DMA_MAPPING_ERROR; > + > + if (unlikely(data->broken)) > + return DMA_MAPPING_ERROR; > + > + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) > + return DMA_MAPPING_ERROR; > + > + for (i = 0; i < n_pages; i++) { > + gnttab_grant_foreign_access_ref(grant + i, data->dev_domid, > + xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE); > + } > + > + dma_handle = grant_to_dma(grant) + offset; > + > + return dma_handle; > +} > + > +static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, > + size_t size, enum dma_data_direction dir, > + unsigned long attrs) > +{ > + struct xen_grant_dma_data *data; > + unsigned int i, n_pages = PFN_UP(size); > + grant_ref_t grant; > + > + if (WARN_ON(dir == DMA_NONE)) > + return; > + > + data = find_xen_grant_dma_data(dev); > + if (!data) > + return; > + > + if (unlikely(data->broken)) > + return; > + > + grant = dma_to_grant(dma_handle); > + > + for (i = 0; i < n_pages; i++) { > + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { > + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); > + data->broken = true; > + return; > + } > + } > + > + gnttab_free_grant_reference_seq(grant, n_pages); > +} > + > +static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg, > + int nents, enum dma_data_direction dir, > + unsigned long attrs) > +{ > + struct scatterlist *s; > + unsigned int i; > + > + if (WARN_ON(dir == DMA_NONE)) > + return; > + > + for_each_sg(sg, s, nents, i) > + xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir, > + attrs); > +} > + > +static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg, > + int nents, enum dma_data_direction dir, > + unsigned long attrs) > +{ > + struct scatterlist *s; > + unsigned int i; > + > + if (WARN_ON(dir == DMA_NONE)) > + return -EINVAL; > + > + for_each_sg(sg, s, nents, i) { > + s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset, > + s->length, dir, attrs); > + if (s->dma_address == DMA_MAPPING_ERROR) > + goto out; > + > + sg_dma_len(s) = s->length; > + } > + > + return nents; > + > +out: > + xen_grant_dma_unmap_sg(dev, sg, i, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC); > + sg_dma_len(sg) = 0; > + > + return -EIO; > +} > + > +static int xen_grant_dma_supported(struct device *dev, u64 mask) > +{ > + return mask == DMA_BIT_MASK(64); > +} > + > +static const struct dma_map_ops xen_grant_dma_ops = { > + .alloc = xen_grant_dma_alloc, > + .free = xen_grant_dma_free, > + .alloc_pages = xen_grant_dma_alloc_pages, > + .free_pages = xen_grant_dma_free_pages, > + .mmap = dma_common_mmap, > + .get_sgtable = dma_common_get_sgtable, > + .map_page = xen_grant_dma_map_page, > + .unmap_page = xen_grant_dma_unmap_page, > + .map_sg = xen_grant_dma_map_sg, > + .unmap_sg = xen_grant_dma_unmap_sg, > + .dma_supported = xen_grant_dma_supported, > +}; > + > +void xen_grant_setup_dma_ops(struct device *dev) > +{ > + struct xen_grant_dma_data *data; > + uint32_t dev_domid; > + > + data = find_xen_grant_dma_data(dev); > + if (data) { > + dev_err(dev, "Xen grant DMA data is already created\n"); > + return; > + } > + > + /* XXX The dom0 is hardcoded as the backend domain for now */ > + dev_domid = 0; > + > + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + goto err; > + > + data->dev_domid = dev_domid; > + > + if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, > + GFP_KERNEL))) { > + dev_err(dev, "Cannot store Xen grant DMA data\n"); > + goto err; > + } > + > + dev->dma_ops = &xen_grant_dma_ops; > + > + return; > + > +err: > + dev_err(dev, "Сannot set up Xen grant DMA ops, retain platform DMA ops\n"); > +} > + > +MODULE_DESCRIPTION("Xen grant DMA-mapping layer"); > +MODULE_AUTHOR("Juergen Gross "); > +MODULE_LICENSE("GPL"); > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h > index a3584a3..4f9fad5 100644 > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { } > > #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */ > > +#ifdef CONFIG_XEN_GRANT_DMA_OPS > +void xen_grant_setup_dma_ops(struct device *dev); > +#else > +static inline void xen_grant_setup_dma_ops(struct device *dev) > +{ > +} > +#endif /* CONFIG_XEN_GRANT_DMA_OPS */ > + > #endif /* INCLUDE_XEN_OPS_H */ > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > --8323329-1745592087-1652131303=:43560-- From xen-devel-bounces@lists.xenproject.org Mon May 09 21:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 21:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324826.547098 (Exim 4.92) (envelope-from ) id 1noB6G-0008Op-8J; Mon, 09 May 2022 21:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324826.547098; Mon, 09 May 2022 21:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB6G-0008Of-5T; Mon, 09 May 2022 21:39:28 +0000 Received: by outflank-mailman (input) for mailman id 324826; Mon, 09 May 2022 21:39:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB6E-0007ym-6G for xen-devel@lists.xenproject.org; Mon, 09 May 2022 21:39:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e8f0386-cfe0-11ec-8fc4-03012f2f19d4; Mon, 09 May 2022 23:39:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C2F16173E; Mon, 9 May 2022 21:39:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D98FBC385BF; Mon, 9 May 2022 21:39:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e8f0386-cfe0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652132363; bh=bGVROk1yCVFbw1tN5TwGGaOX8G0Pd3s1D8n+lUcuavY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jIjU+8tpltcUUdOqWb8RQToebMMi7jlG6EnTVHQBvz5t4l//CxxmzayoSnWIXtjIq fy84fHDqbtXeMASASk++DG2/cUJ91hHqe+1Of9X3a0Eqm2Ev0LsG2q4HBN1O49pRh/ joc0a+YLoJYyXOtV+WB+uOq6+Eg9WZ38FDg+fEdO7rWaYwefXDFa+7Z2682LO0g4He fqu6yjT37l+A8wnb4ZLJ51/OtFAAs5lLs25jPNFrue7rXsnPkmBkwix4cn5/5iwLu6 rQglFPRi0M/Wk8iwB4xrNXNUkRTDsHz+TWohutLj7rphd2GX07IfzohFQHQSlMvjcM 6uDxuOP7Y4MIQ== Date: Mon, 9 May 2022 14:39:22 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen, dev-domid property description for xen-grant DMA ops In-Reply-To: <1651947548-4055-6-git-send-email-olekstysh@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 7 May 2022, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings scheme needs to be > enabled for the device which DT node contains that property and specifies > the ID of Xen domain where the corresponding backend resides. The ID > (domid) is used as an argument to the grant mapping APIs. > > This is needed for the option to restrict memory access using Xen grant > mappings to work which primary goal is to enable using virtio devices > in Xen guests. > > Signed-off-by: Oleksandr Tyshchenko The binding is OK and the wording is OK too. Reviewed-by: Stefano Stabellini I am not an expert on the details of writing a good schema, I'll defer to Rob if he has any comments on that. > --- > Changes RFC -> V1: > - update commit subject/description and text in description > - move to devicetree/bindings/arm/ > > Changes V1 -> V2: > - update text in description > - change the maintainer of the binding > - fix validation issue > - reference xen,dev-domid.yaml schema from virtio/mmio.yaml > --- > .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ > Documentation/devicetree/bindings/virtio/mmio.yaml | 7 ++++ > 2 files changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > new file mode 100644 > index 00000000..750e89e > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xen specific binding for virtualized devices (e.g. virtio) > + > +maintainers: > + - Stefano Stabellini > + > +select: true > + > +description: > + This binding indicates that Xen grant mappings need to be enabled for > + the device, and it specifies the ID of the domain where the corresponding > + device (backend) resides. The property is required to restrict memory > + access using Xen grant mappings. > + > +properties: > + xen,dev-domid: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The domid (domain ID) of the domain where the device (backend) is running. > + > +additionalProperties: true > + > +examples: > + - | > + virtio@3000 { > + compatible = "virtio,mmio"; > + reg = <0x3000 0x100>; > + interrupts = <41>; > + > + /* The device is located in Xen domain with ID 1 */ > + xen,dev-domid = <1>; > + }; > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > index 10c22b5..29a0932 100644 > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > @@ -13,6 +13,9 @@ description: > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > more details. > > +allOf: > + - $ref: /schemas/arm/xen,dev-domid.yaml# > + > properties: > compatible: > const: virtio,mmio > @@ -33,6 +36,10 @@ properties: > description: Required for devices making accesses thru an IOMMU. > maxItems: 1 > > + xen,dev-domid: > + description: Required when Xen grant mappings need to be enabled for device. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > required: > - compatible > - reg > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From xen-devel-bounces@lists.xenproject.org Mon May 09 21:39:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 21:39:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324829.547108 (Exim 4.92) (envelope-from ) id 1noB6O-0000UE-Na; Mon, 09 May 2022 21:39:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324829.547108; Mon, 09 May 2022 21:39:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB6O-0000U5-KP; Mon, 09 May 2022 21:39:36 +0000 Received: by outflank-mailman (input) for mailman id 324829; Mon, 09 May 2022 21:39:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noB6N-0007ij-5Y for xen-devel@lists.xenproject.org; Mon, 09 May 2022 21:39:35 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83f43437-cfe0-11ec-a406-831a346695d4; Mon, 09 May 2022 23:39:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D6D3FB8199C; Mon, 9 May 2022 21:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 048DBC385BF; Mon, 9 May 2022 21:39:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83f43437-cfe0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652132371; bh=w64WFP+FS1qwSJLrrBULSTI0uZjKMayFTRWfozu9uWY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=gAGP0xXbaGOEmZFA7GOCOb7EDosDpfZvPezk79kmKm3UiwHBf638JxXgRhKRp1UyW QaU6dZQSHhE5zxRgkH9CvAl//cKb2nmmJrhVw8jezSaCzUIVlnu1jTgAF/d0byUFDp vXqkl0oMdf5/259HkFfAITGp5NyZf98LwoRiWxEJgeH3Fhh6YW9tS06MLDVYaqShip c/6yOX1XoQTH6geB1X7IG4QFq0qWHTdIQ7SPvIsR900+rggdPmvlSkvOKPx2Yp8Yta L+7Ya24X20Y695X34KBvaYmzpcQqK835jSoTGiN4TmxPPB/IbY2vDOR3m6Q9tIJIKD vjmxrqjRK4IFg== Date: Mon, 9 May 2022 14:39:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: Re: [PATCH V2 6/7] xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices In-Reply-To: <1651947548-4055-7-git-send-email-olekstysh@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-7-git-send-email-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 7 May 2022, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Use the presence of recently introduced "xen,dev-domid" property > in the device node as a clear indicator of enabling Xen grant > mappings scheme for that device and read the ID of Xen domain where > the corresponding backend resides. The ID (domid) is used as > an argument to the Xen grant mapping APIs. > > Also introduce xen_is_grant_dma_device() to check whether xen-grant > DMA ops need to be set for a passed device. > > Remove the hardcoded domid 0 in xen_grant_setup_dma_ops(). > > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini > --- > Changes RFC -> V1: > - new patch, split required changes from commit: > "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" > - update checks in xen_virtio_setup_dma_ops() to only support > DT devices for now > - remove the "virtio,mmio" check from xen_is_virtio_device() > - remane everything according to the new naming scheme: > s/virtio/grant_dma > > Changes V1 -> V2: > - remove dev_is_pci() check in xen_grant_setup_dma_ops() > - remove EXPORT_SYMBOL_GPL(xen_is_grant_dma_device); > --- > drivers/xen/grant-dma-ops.c | 24 +++++++++++++++++------- > include/xen/xen-ops.h | 5 +++++ > 2 files changed, 22 insertions(+), 7 deletions(-) > > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c > index 29ad7bf..8924178 100644 > --- a/drivers/xen/grant-dma-ops.c > +++ b/drivers/xen/grant-dma-ops.c > @@ -55,11 +55,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) > * Such a DMA address is formed by using the grant reference as a frame > * number and setting the highest address bit (this bit is for the backend > * to be able to distinguish it from e.g. a mmio address). > - * > - * Note that for now we hard wire dom0 to be the backend domain. In order > - * to support any domain as backend we'd need to add a way to communicate > - * the domid of this backend, e.g. via Xenstore, via the PCI-device's > - * config space or DT/ACPI. > */ > static void *xen_grant_dma_alloc(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t gfp, > @@ -275,6 +270,15 @@ static const struct dma_map_ops xen_grant_dma_ops = { > .dma_supported = xen_grant_dma_supported, > }; > > +bool xen_is_grant_dma_device(struct device *dev) > +{ > + /* XXX Handle only DT devices for now */ > + if (!dev->of_node) > + return false; > + > + return of_property_read_bool(dev->of_node, "xen,dev-domid"); > +} > + > void xen_grant_setup_dma_ops(struct device *dev) > { > struct xen_grant_dma_data *data; > @@ -286,8 +290,14 @@ void xen_grant_setup_dma_ops(struct device *dev) > return; > } > > - /* XXX The dom0 is hardcoded as the backend domain for now */ > - dev_domid = 0; > + /* XXX ACPI device unsupported for now */ > + if (!dev->of_node) > + goto err; > + > + if (of_property_read_u32(dev->of_node, "xen,dev-domid", &dev_domid)) { > + dev_err(dev, "xen,dev-domid property is not present\n"); > + goto err; > + } > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > if (!data) > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h > index 4f9fad5..62be9dc 100644 > --- a/include/xen/xen-ops.h > +++ b/include/xen/xen-ops.h > @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { } > > #ifdef CONFIG_XEN_GRANT_DMA_OPS > void xen_grant_setup_dma_ops(struct device *dev); > +bool xen_is_grant_dma_device(struct device *dev); > #else > static inline void xen_grant_setup_dma_ops(struct device *dev) > { > } > +static inline bool xen_is_grant_dma_device(struct device *dev) > +{ > + return false; > +} > #endif /* CONFIG_XEN_GRANT_DMA_OPS */ > > #endif /* INCLUDE_XEN_OPS_H */ > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From xen-devel-bounces@lists.xenproject.org Mon May 09 22:40:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 22:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324847.547120 (Exim 4.92) (envelope-from ) id 1noC2k-0007sd-5v; Mon, 09 May 2022 22:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324847.547120; Mon, 09 May 2022 22:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noC2k-0007sW-38; Mon, 09 May 2022 22:39:54 +0000 Received: by outflank-mailman (input) for mailman id 324847; Mon, 09 May 2022 22:39:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noC2i-0007sM-ST; Mon, 09 May 2022 22:39:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noC2i-0007dN-Ql; Mon, 09 May 2022 22:39:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noC2i-0000JQ-At; Mon, 09 May 2022 22:39:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noC2i-00021n-AQ; Mon, 09 May 2022 22:39:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9jQU81qvI1sba4z0ua+/JjDIfPqptIFMXvjRkc8WvjQ=; b=T1SmJiQPQzerowhy7LOsjAChIY MCHQrZFWiwWBukktaZtxhB0uFf68WexWGjJh0dMUDrYp3K79s4IHHAxVyNYahW9ZRF1w+nzk/ENAb osXnHYEBdlptma1PvpELjWst3N6EMcOgq2BiWeFncPpuEbRodUsonaiyux3jCn/dl7/4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170278: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=95604873ccf56eb81e96ed0dc8b4dec3278f40ca X-Osstest-Versions-That: xen=b7e0d8978810b534725e94a321736496928f00a5 From: osstest service owner Date: Mon, 09 May 2022 22:39:52 +0000 flight 170278 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170278/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 95604873ccf56eb81e96ed0dc8b4dec3278f40ca baseline version: xen b7e0d8978810b534725e94a321736496928f00a5 Last test of basis 170186 2022-05-06 17:03:05 Z 3 days Testing same since 170278 2022-05-09 19:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Julien Grall Rahul Singh jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b7e0d89788..95604873cc 95604873ccf56eb81e96ed0dc8b4dec3278f40ca -> smoke From xen-devel-bounces@lists.xenproject.org Mon May 09 22:52:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 22:52:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324855.547131 (Exim 4.92) (envelope-from ) id 1noCFG-00020v-BD; Mon, 09 May 2022 22:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324855.547131; Mon, 09 May 2022 22:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCFG-00020o-7k; Mon, 09 May 2022 22:52:50 +0000 Received: by outflank-mailman (input) for mailman id 324855; Mon, 09 May 2022 22:52:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCFF-00020d-9X; Mon, 09 May 2022 22:52:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCFF-0007rf-2g; Mon, 09 May 2022 22:52:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCFE-0000hO-I4; Mon, 09 May 2022 22:52:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noCFE-0005rP-Hh; Mon, 09 May 2022 22:52:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sgS+eK+rwETep1jK2RbColU/5T/P+qQ42vQHlGGMWLI=; b=HuRkrHOADGdABOBOdVyLpGwj0G WKq0Uixtwe1CIihLcxptMxq3va+1mWtLywQlX/GlkCEVrH+rHHBOUbJfW8mqAagThGcnELwgyLNZI 7Zbtfzcg25kuNaOu9yveMiZmXTCu+PU4ZxfPfVYzIh9AYlH4e5Q69Zx8XIJdMmYkIRz8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170279: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 09 May 2022 22:52:48 +0000 flight 170279 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170279/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 901 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 09 23:07:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:07:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324863.547142 (Exim 4.92) (envelope-from ) id 1noCTp-0003jg-Lp; Mon, 09 May 2022 23:07:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324863.547142; Mon, 09 May 2022 23:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCTp-0003jZ-Iv; Mon, 09 May 2022 23:07:53 +0000 Received: by outflank-mailman (input) for mailman id 324863; Mon, 09 May 2022 23:07:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCTo-0003jO-7F; Mon, 09 May 2022 23:07:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCTo-00088L-37; Mon, 09 May 2022 23:07:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCTn-000159-H1; Mon, 09 May 2022 23:07:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noCTn-0007yh-Gb; Mon, 09 May 2022 23:07:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A+XnL2aQ24ugFXbMgORmCoBpEpylLmRQO7tB8uEk8eM=; b=T5OQR6NHmyjsWY9FMjnzxqs3Zg k7xUhh4vKqlLHnwhOksv7qqZtrudp1M/y7gs+zNpCwEQOAwCZpjtTxfOUGmn3AfG/259aH5G+l3wJ uuRgAzc9iDQAGWEgcJF+I1kUpzCi+VGDAuYxKIlOSzgRrM8rWuLAXvNFR53A+tMG2QjY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170273: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9be9ed2612b5aedb52a2c240edb1630b6b743cb6 X-Osstest-Versions-That: linux=c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a From: osstest service owner Date: Mon, 09 May 2022 23:07:51 +0000 flight 170273 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170273/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170252 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170252 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170252 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170252 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170252 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170252 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170252 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170252 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 9be9ed2612b5aedb52a2c240edb1630b6b743cb6 baseline version: linux c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a Last test of basis 170252 2022-05-08 23:11:10 Z 0 days Testing same since 170273 2022-05-09 16:11:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Arcari Hans de Goede Linus Torvalds Mario Limonciello Mark Pearson Mark Pearson Maximilian Luz Prarit Bhargava jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c5eb0a61238d..9be9ed2612b5 9be9ed2612b5aedb52a2c240edb1630b6b743cb6 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324872.547153 (Exim 4.92) (envelope-from ) id 1noCsG-0007Ps-T2; Mon, 09 May 2022 23:33:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324872.547153; Mon, 09 May 2022 23:33:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsG-0007Pl-Pn; Mon, 09 May 2022 23:33:08 +0000 Received: by outflank-mailman (input) for mailman id 324872; Mon, 09 May 2022 23:33:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsE-0007Pf-AX for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:06 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f1d9648-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:04 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 607931F416C1 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f1d9648-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139183; bh=lLgNEvskjYPed89A1nrHxa9JSdRs0IUn4pOHSUK7jTc=; h=From:To:Cc:Subject:Date:From; b=WUHzEmLOMl++gIYprzLY4Y5ZgwkylBFM3NXfpKcZkd+7BNaZaUmiGqg0VUYWRABmv hJH1Ou7MvzVQEeCAUDDHWRMZxDQoppEXGKbM2j06jRJrIABXsEZZwm7i9NM879gB6O 2Y1Se37TomGB4d2h1mXO6OlgzOTBjNFsW3GHIFZ7/mIkei0JXAEQaCq8Rz0ut+bUea RPU0PjopsaMLBS9qFclxouby5tVIWXA/d0NuIMg3imq9abL7b/0/41RgiE9Je581Oh wDZpoyFknmJS5vpV9L2nPVYSN0vUloiI1KAFaWeUbC9qrgYElXNzM0KEblyCj/O68o va3jAifDGqHhA== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 00/27] Introduce power-off+restart call chain API Date: Tue, 10 May 2022 02:32:08 +0300 Message-Id: <20220509233235.995021-1-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem ------- SoC devices require power-off call chaining functionality from kernel. We have a widely used restart chaining provided by restart notifier API, but nothing for power-off. Solution -------- Introduce new API that provides call chains support for all restart and power-off modes. The new API is designed with simplicity and extensibility in mind. This is a third attempt to introduce the new API. First was made by Guenter Roeck back in 2014, second was made by Thierry Reding in 2017. In fact the work didn't stop and recently arm_pm_restart() was removed from v5.14 kernel, which was a part of preparatory work started by Guenter Roeck. Adoption plan ------------- This patchset introduces the new API. It also converts multiple drivers and arch code to the new API to demonstrate how it all looks in practice, removing the pm_power_off_prepare global variable. The plan is: 1. Merge the new API and convert arch code to use do_kernel_power_off(). For now the new API will co-exist with the older API. 2. Convert all drivers and platform code to the new API. 3. Remove obsoleted pm_power_off and pm_power_off_prepare variables. Results ------- 1. Devices can be powered off properly. 2. Global variables are removed from drivers. 3. Global pm_power_off and pm_power_off_prepare callback variables are removed once all users are converted to the new API. The latter callback is removed by patch #24 of this series. 4. Ambiguous call chain ordering is prohibited for non-default priorities. Changelog: v8: - Reworked sys-off handler like was suggested by Rafael Wysocki in the comments to v7. - The struct sys-off handler now is private to kernel/reboot.c and new API is simplified. - There is a single sys-off API function for all handler types. Users shall pass the required sys-off mode type (restart, power-off and etc). - There is single struct sys_off_data callback argument for all handler modes. - User's callback now must return NOTIFY_DONE or NOTIFY_STOP. - The default priority level is zero now. - Multiple handlers now allowed to be registered at the default priority level. - Power-off call chain is atomic now, like the restart chain. - kernel/reboot.c changes are split up into several logical patches. - Added r-b from Michał Mirosław to unmodified patches from v7. - Added acks that were missing in v7 by accident. v7: - Rebased on a recent linux-next. Dropped the recently removed NDS32 architecture. Only SH and x86 arches left un-acked. - Added acks from Thomas Bogendoerfer and Krzysztof Kozlowski to the MIPS and memory/emif patches respectively. - Made couple minor cosmetic improvements to the new API. - A month ago I joined Collabora and continuing to work on this series on the company's time, so changed my email address to collabora.com v6: - Rebased on a recent linux-next. - Made minor couple cosmetic changes. v5: - Dropped patches which cleaned up notifier/reboot headers, as was requested by Rafael Wysocki. - Dropped WARN_ON() from the code, as was requested by Rafael Wysocki. Replaced it with pr_err() appropriately. - Dropped *_notifier_has_unique_priority() functions and added *_notifier_chain_register_unique_prio() instead, as was suggested by Michał Mirosław and Rafael Wysocki. - Dropped export of blocking_notifier_call_chain_is_empty() symbol, as was suggested by Rafael Wysocki. - Michał Mirosław suggested that will be better to split up patch that adds the new API to ease reviewing, but Rafael Wysocki asked not add more patches, so I kept it as a single patch. - Added temporary "weak" stub for pm_power_off() which fixes linkage failure once symbol is removed from arch/* code. Previously I missed this problem because was only compile-testing object files. v4: - Made a very minor improvement to doc comments, clarifying couple default values. - Corrected list of emails recipient by adding Linus, Sebastian, Philipp and more NDS people. Removed bouncing emails. - Added acks that were given to v3. v3: - Renamed power_handler to sys_off_handler as was suggested by Rafael Wysocki. - Improved doc-comments as was suggested by Rafael Wysocki. Added more doc-comments. - Implemented full set of 180 patches which convert whole kernel in accordance to the plan, see link [1] above. Slightly adjusted API to better suit for the remaining converted drivers. * Added unregister_sys_off_handler() that is handy for a couple old platform drivers. * Dropped devm_register_trivial_restart_handler(), 'simple' variant is enough to have. - Improved "Add atomic/blocking_notifier_has_unique_priority()" patch, as was suggested by Andy Shevchenko. Also replaced down_write() with down_read() and factored out common notifier_has_unique_priority(). - Added stop_chain field to struct restart_data and reboot_prep_data after discovering couple drivers wanting that feature. - Added acks that were given to v2. v2: - Replaced standalone power-off call chain demo-API with the combined power-off+restart API because this is what drivers want. It's a more comprehensive solution. - Converted multiple drivers and arch code to the new API. Suggested by Andy Shevchenko. I skimmed through the rest of drivers, verifying that new API suits them. The rest of the drivers will be converted once we will settle on the new API, otherwise will be too many patches here. - v2 API doesn't expose notifier to users and require handlers to have unique priority. Suggested by Guenter Roeck. - v2 API has power-off chaining disabled by default and require drivers to explicitly opt-in to the chaining. This preserves old behaviour for existing drivers once they are converted to the new API. Dmitry Osipenko (27): notifier: Add atomic_notifier_call_chain_is_empty() notifier: Add blocking/atomic_notifier_chain_register_unique_prio() kernel/reboot: Introduce sys-off handler API kernel/reboot: Wrap legacy power-off callbacks into sys-off handlers kernel/reboot: Add do_kernel_power_off() kernel/reboot: Add stub for pm_power_off kernel/reboot: Add kernel_can_power_off() kernel/reboot: Add register_platform_power_off() ARM: Use do_kernel_power_off() csky: Use do_kernel_power_off() riscv: Use do_kernel_power_off() arm64: Use do_kernel_power_off() parisc: Use do_kernel_power_off() xen/x86: Use do_kernel_power_off() powerpc: Use do_kernel_power_off() m68k: Switch to new sys-off handler API sh: Use do_kernel_power_off() x86: Use do_kernel_power_off() ia64: Use do_kernel_power_off() mips: Use do_kernel_power_off() memory: emif: Use kernel_can_power_off() ACPI: power: Switch to sys-off handler API regulator: pfuze100: Use devm_register_sys_off_handler() reboot: Remove pm_power_off_prepare() soc/tegra: pmc: Use sys-off handler API to power off Nexus 7 properly kernel/reboot: Add devm_register_power_off_handler() kernel/reboot: Add devm_register_restart_handler() arch/arm/kernel/reboot.c | 4 +- arch/arm64/kernel/process.c | 3 +- arch/csky/kernel/power.c | 6 +- arch/ia64/kernel/process.c | 4 +- arch/m68k/emu/natfeat.c | 3 +- arch/m68k/include/asm/machdep.h | 1 - arch/m68k/kernel/process.c | 5 +- arch/m68k/kernel/setup_mm.c | 1 - arch/m68k/kernel/setup_no.c | 1 - arch/m68k/mac/config.c | 4 +- arch/mips/kernel/reset.c | 3 +- arch/parisc/kernel/process.c | 4 +- arch/powerpc/kernel/setup-common.c | 4 +- arch/powerpc/xmon/xmon.c | 3 +- arch/riscv/kernel/reset.c | 12 +- arch/sh/kernel/reboot.c | 3 +- arch/x86/kernel/reboot.c | 4 +- arch/x86/xen/enlighten_pv.c | 4 +- drivers/acpi/sleep.c | 16 +- drivers/memory/emif.c | 2 +- drivers/regulator/pfuze100-regulator.c | 42 ++- drivers/soc/tegra/pmc.c | 87 +++++-- include/linux/notifier.h | 7 + include/linux/pm.h | 1 - include/linux/reboot.h | 91 +++++++ kernel/notifier.c | 101 +++++-- kernel/reboot.c | 347 ++++++++++++++++++++++++- 27 files changed, 639 insertions(+), 124 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324874.547175 (Exim 4.92) (envelope-from ) id 1noCsL-0007wV-FX; Mon, 09 May 2022 23:33:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324874.547175; Mon, 09 May 2022 23:33:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsL-0007wM-C2; Mon, 09 May 2022 23:33:13 +0000 Received: by outflank-mailman (input) for mailman id 324874; Mon, 09 May 2022 23:33:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsK-0007Pf-7l for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:12 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63937d67-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:11 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3E0D01F41C11 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63937d67-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139191; bh=lukCDvlh+VQrMdDntGqnw63sEvxpUquxvKx6zCB6dFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E6Htd2NUIVyNQjm3zjNspKkqxKR6i+iW9w4XOpsS37hUGOUw3VGPJrC2rx39+Tvjo ocX71hfI+QjZ1lP5+X1LQsBmPL7dlCcXv+9SS+Q5TjrCltdIh3RX5eeIHiXvwmIHOF Kulj0kJ1lapR0UDvwLlgi7z12iGZUG5kArtm4alE5b6tURKwWMHCIIuDOdtxMBBqfN uPcI4HMaMJSb1mmQeveHzBRcA1W+g1oEcT8ghi9sEibaTcITp0l5yKtDFG6Z0k8iC2 z8WaqKpN987G8alEhWQWRlQTun+nTX2I87+5WJt9cIsDvplddvAA31I22KuGrIBoCV U5x0xoyuIdD+g== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 02/27] notifier: Add blocking/atomic_notifier_chain_register_unique_prio() Date: Tue, 10 May 2022 02:32:10 +0300 Message-Id: <20220509233235.995021-3-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add variant of blocking/atomic_notifier_chain_register() functions that allow registration of a notifier only if it has unique priority, otherwise -EBUSY error code is returned by the new functions. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- include/linux/notifier.h | 5 +++ kernel/notifier.c | 88 +++++++++++++++++++++++++++++++--------- 2 files changed, 74 insertions(+), 19 deletions(-) diff --git a/include/linux/notifier.h b/include/linux/notifier.h index 95e2440037de..aef88c2d1173 100644 --- a/include/linux/notifier.h +++ b/include/linux/notifier.h @@ -150,6 +150,11 @@ extern int raw_notifier_chain_register(struct raw_notifier_head *nh, extern int srcu_notifier_chain_register(struct srcu_notifier_head *nh, struct notifier_block *nb); +extern int atomic_notifier_chain_register_unique_prio( + struct atomic_notifier_head *nh, struct notifier_block *nb); +extern int blocking_notifier_chain_register_unique_prio( + struct blocking_notifier_head *nh, struct notifier_block *nb); + extern int atomic_notifier_chain_unregister(struct atomic_notifier_head *nh, struct notifier_block *nb); extern int blocking_notifier_chain_unregister(struct blocking_notifier_head *nh, diff --git a/kernel/notifier.c b/kernel/notifier.c index aaf5b56452a6..684fe04f5f70 100644 --- a/kernel/notifier.c +++ b/kernel/notifier.c @@ -20,7 +20,8 @@ BLOCKING_NOTIFIER_HEAD(reboot_notifier_list); */ static int notifier_chain_register(struct notifier_block **nl, - struct notifier_block *n) + struct notifier_block *n, + bool unique_priority) { while ((*nl) != NULL) { if (unlikely((*nl) == n)) { @@ -30,6 +31,8 @@ static int notifier_chain_register(struct notifier_block **nl, } if (n->priority > (*nl)->priority) break; + if (n->priority == (*nl)->priority && unique_priority) + return -EBUSY; nl = &((*nl)->next); } n->next = *nl; @@ -144,12 +147,35 @@ int atomic_notifier_chain_register(struct atomic_notifier_head *nh, int ret; spin_lock_irqsave(&nh->lock, flags); - ret = notifier_chain_register(&nh->head, n); + ret = notifier_chain_register(&nh->head, n, false); spin_unlock_irqrestore(&nh->lock, flags); return ret; } EXPORT_SYMBOL_GPL(atomic_notifier_chain_register); +/** + * atomic_notifier_chain_register_unique_prio - Add notifier to an atomic notifier chain + * @nh: Pointer to head of the atomic notifier chain + * @n: New entry in notifier chain + * + * Adds a notifier to an atomic notifier chain if there is no other + * notifier registered using the same priority. + * + * Returns 0 on success, %-EEXIST or %-EBUSY on error. + */ +int atomic_notifier_chain_register_unique_prio(struct atomic_notifier_head *nh, + struct notifier_block *n) +{ + unsigned long flags; + int ret; + + spin_lock_irqsave(&nh->lock, flags); + ret = notifier_chain_register(&nh->head, n, true); + spin_unlock_irqrestore(&nh->lock, flags); + return ret; +} +EXPORT_SYMBOL_GPL(atomic_notifier_chain_register_unique_prio); + /** * atomic_notifier_chain_unregister - Remove notifier from an atomic notifier chain * @nh: Pointer to head of the atomic notifier chain @@ -222,18 +248,9 @@ bool atomic_notifier_call_chain_is_empty(struct atomic_notifier_head *nh) * synchronized by an rwsem. */ -/** - * blocking_notifier_chain_register - Add notifier to a blocking notifier chain - * @nh: Pointer to head of the blocking notifier chain - * @n: New entry in notifier chain - * - * Adds a notifier to a blocking notifier chain. - * Must be called in process context. - * - * Returns 0 on success, %-EEXIST on error. - */ -int blocking_notifier_chain_register(struct blocking_notifier_head *nh, - struct notifier_block *n) +static int __blocking_notifier_chain_register(struct blocking_notifier_head *nh, + struct notifier_block *n, + bool unique_priority) { int ret; @@ -243,15 +260,48 @@ int blocking_notifier_chain_register(struct blocking_notifier_head *nh, * such times we must not call down_write(). */ if (unlikely(system_state == SYSTEM_BOOTING)) - return notifier_chain_register(&nh->head, n); + return notifier_chain_register(&nh->head, n, unique_priority); down_write(&nh->rwsem); - ret = notifier_chain_register(&nh->head, n); + ret = notifier_chain_register(&nh->head, n, unique_priority); up_write(&nh->rwsem); return ret; } + +/** + * blocking_notifier_chain_register - Add notifier to a blocking notifier chain + * @nh: Pointer to head of the blocking notifier chain + * @n: New entry in notifier chain + * + * Adds a notifier to a blocking notifier chain. + * Must be called in process context. + * + * Returns 0 on success, %-EEXIST on error. + */ +int blocking_notifier_chain_register(struct blocking_notifier_head *nh, + struct notifier_block *n) +{ + return __blocking_notifier_chain_register(nh, n, false); +} EXPORT_SYMBOL_GPL(blocking_notifier_chain_register); +/** + * blocking_notifier_chain_register_unique_prio - Add notifier to a blocking notifier chain + * @nh: Pointer to head of the blocking notifier chain + * @n: New entry in notifier chain + * + * Adds a notifier to an blocking notifier chain if there is no other + * notifier registered using the same priority. + * + * Returns 0 on success, %-EEXIST or %-EBUSY on error. + */ +int blocking_notifier_chain_register_unique_prio(struct blocking_notifier_head *nh, + struct notifier_block *n) +{ + return __blocking_notifier_chain_register(nh, n, true); +} +EXPORT_SYMBOL_GPL(blocking_notifier_chain_register_unique_prio); + /** * blocking_notifier_chain_unregister - Remove notifier from a blocking notifier chain * @nh: Pointer to head of the blocking notifier chain @@ -354,7 +404,7 @@ EXPORT_SYMBOL_GPL(blocking_notifier_call_chain); int raw_notifier_chain_register(struct raw_notifier_head *nh, struct notifier_block *n) { - return notifier_chain_register(&nh->head, n); + return notifier_chain_register(&nh->head, n, false); } EXPORT_SYMBOL_GPL(raw_notifier_chain_register); @@ -433,10 +483,10 @@ int srcu_notifier_chain_register(struct srcu_notifier_head *nh, * such times we must not call mutex_lock(). */ if (unlikely(system_state == SYSTEM_BOOTING)) - return notifier_chain_register(&nh->head, n); + return notifier_chain_register(&nh->head, n, false); mutex_lock(&nh->mutex); - ret = notifier_chain_register(&nh->head, n); + ret = notifier_chain_register(&nh->head, n, false); mutex_unlock(&nh->mutex); return ret; } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324873.547164 (Exim 4.92) (envelope-from ) id 1noCsJ-0007fW-5A; Mon, 09 May 2022 23:33:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324873.547164; Mon, 09 May 2022 23:33:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsJ-0007fP-1v; Mon, 09 May 2022 23:33:11 +0000 Received: by outflank-mailman (input) for mailman id 324873; Mon, 09 May 2022 23:33:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsH-0007bw-Up for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:09 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6138bb6d-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:08 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5E2CD1F4195B X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6138bb6d-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139187; bh=fLk9P/8GBXV/gow9gw4QGytkxQFyLU71HSagZYJ8o5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YhxhnTI9NvbLfj67ZcRhPX86XV8hnVmvB2+NtO95NIqYARKmayRkU9nopvPEQT8Me W2nnVXm0D2hSk50qdVKpG+UHHCKbjvMu3DEa3LaZ5ZzUrWUuvj9BT9vVQEbRgMTGth m/otgMrFJikr7jdN+Q40cxAuxrylVYKjYtjLq4WIIwC/OBLKnmv6GgSMh0Y+uGoD/L 1hhg9iEoCH1Pdja7DSW7Pk4PTjR/qfW5ULonIQQvmnkEROj2Q2BUmPpY9d1Q7Ecq17 xmwMvW1NNWwMi/Qww4oq/Msiaz19CBS0NzvNZDBPy+6YaGpixClw4HeYhLf1899Vzj FC16JVNO96lKg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 01/27] notifier: Add atomic_notifier_call_chain_is_empty() Date: Tue, 10 May 2022 02:32:09 +0300 Message-Id: <20220509233235.995021-2-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add atomic_notifier_call_chain_is_empty() that returns true if given atomic call chain is empty. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- include/linux/notifier.h | 2 ++ kernel/notifier.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/include/linux/notifier.h b/include/linux/notifier.h index 87069b8459af..95e2440037de 100644 --- a/include/linux/notifier.h +++ b/include/linux/notifier.h @@ -173,6 +173,8 @@ extern int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh extern int raw_notifier_call_chain_robust(struct raw_notifier_head *nh, unsigned long val_up, unsigned long val_down, void *v); +extern bool atomic_notifier_call_chain_is_empty(struct atomic_notifier_head *nh); + #define NOTIFY_DONE 0x0000 /* Don't care */ #define NOTIFY_OK 0x0001 /* Suits me */ #define NOTIFY_STOP_MASK 0x8000 /* Don't call further */ diff --git a/kernel/notifier.c b/kernel/notifier.c index ba005ebf4730..aaf5b56452a6 100644 --- a/kernel/notifier.c +++ b/kernel/notifier.c @@ -204,6 +204,19 @@ int atomic_notifier_call_chain(struct atomic_notifier_head *nh, EXPORT_SYMBOL_GPL(atomic_notifier_call_chain); NOKPROBE_SYMBOL(atomic_notifier_call_chain); +/** + * atomicnotifier_call_chain_is_empty - Check whether notifier chain is empty + * @nh: Pointer to head of the blocking notifier chain + * + * Checks whether notifier chain is empty. + * + * Returns true is notifier chain is empty, false otherwise. + */ +bool atomic_notifier_call_chain_is_empty(struct atomic_notifier_head *nh) +{ + return !rcu_access_pointer(nh->head); +} + /* * Blocking notifier chain routines. All access to the chain is * synchronized by an rwsem. -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324875.547186 (Exim 4.92) (envelope-from ) id 1noCsP-0008JH-TP; Mon, 09 May 2022 23:33:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324875.547186; Mon, 09 May 2022 23:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsP-0008Iz-PV; Mon, 09 May 2022 23:33:17 +0000 Received: by outflank-mailman (input) for mailman id 324875; Mon, 09 May 2022 23:33:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsO-0007Pf-7i for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:16 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65e4033c-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:15 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 2F8AA1F41C30 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65e4033c-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139194; bh=bWEhd2ly681MLGj7UVCJAzYeXMznG9pbqJy3OeFWJRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BPDQwkauvsVGCV6donoyMBQqi6nfKh7S+Iw/1P9iMbIBBqyoUvSgbLuYvsqdYh/ls GMjWJ14AyXBDnXQre3telXmHCJzLKXlCCI3qHan6n6N+oKtio7vMszlQ/fxWkoZQss FWDRbd6hKveTgyIf56hKjN7sgj9kRrU43a5oXc/b4FYAyh/tffvNibZf6DI0vK54ws zhTvXytd8B9ucimFodcLV0sRbymSo1ScARgq6soV9eL7++8Wv9QDXGNUEog3feDRa0 8MU4GtColV6cUkO+UZwfe5puFbTFwvmAXe5mtb2I6jqpygEimE8CDtmiPOapiivdh/ Y3sLj2Qbwqplg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 03/27] kernel/reboot: Introduce sys-off handler API Date: Tue, 10 May 2022 02:32:11 +0300 Message-Id: <20220509233235.995021-4-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to support power-off chaining we need to get rid of the global pm_* variables, replacing them with the new kernel API functions that support chaining. Introduce new generic sys-off handler API that brings the following features: 1. Power-off and restart handlers are registered using same API function that supports chaining, hence all power-off and restart modes will support chaining using this unified function. 2. Prevents notifier priority collisions by disallowing registration of multiple handlers at the non-default priority level. 3. Supports passing opaque user argument to callback, which allows us to remove global variables from drivers. This patch adds support of the following sys-off modes: - SYS_OFF_MODE_POWER_OFF_PREPARE that replaces global pm_power_off_prepare variable and provides chaining support for power-off-prepare handlers. - SYS_OFF_MODE_POWER_OFF that replaces global pm_power_off variable and provides chaining support for power-off handlers. - SYS_OFF_MODE_RESTART that provides a better restart API, removing a need from drivers to have a global scratch variable by utilizing the opaque callback argument. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 77 +++++++++++++++++ kernel/reboot.c | 182 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 259 insertions(+) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index a2429648d831..05981ef079d8 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -7,6 +7,7 @@ #include struct device; +struct sys_off_handler; #define SYS_DOWN 0x0001 /* Notify of system down */ #define SYS_RESTART SYS_DOWN @@ -62,6 +63,82 @@ extern void machine_shutdown(void); struct pt_regs; extern void machine_crash_shutdown(struct pt_regs *); +/* + * sys-off handler API. + */ + +/* + * Standard sys-off priority levels. Users are expected to set priorities + * relative to the standard levels. + * + * SYS_OFF_PRIO_PLATFORM: Use this for platform-level handlers. + * + * SYS_OFF_PRIO_LOW: Use this for handler of last resort. + * + * SYS_OFF_PRIO_DEFAULT: Use this for normal handlers. + * + * SYS_OFF_PRIO_HIGH: Use this for higher priority handlers. + * + * SYS_OFF_PRIO_FIRMWARE: Use this if handler uses firmware call. + */ +#define SYS_OFF_PRIO_PLATFORM -256 +#define SYS_OFF_PRIO_LOW -128 +#define SYS_OFF_PRIO_DEFAULT 0 +#define SYS_OFF_PRIO_HIGH 192 +#define SYS_OFF_PRIO_FIRMWARE 224 + +enum sys_off_mode { + /** + * @SYS_OFF_MODE_POWER_OFF_PREPARE: + * + * Handlers prepare system to be powered off. Handlers are + * allowed to sleep. + */ + SYS_OFF_MODE_POWER_OFF_PREPARE, + + /** + * @SYS_OFF_MODE_POWER_OFF: + * + * Handlers power-off system. Handlers are disallowed to sleep. + */ + SYS_OFF_MODE_POWER_OFF, + + /** + * @SYS_OFF_MODE_RESTART: + * + * Handlers restart system. Handlers are disallowed to sleep. + */ + SYS_OFF_MODE_RESTART, +}; + +/** + * struct sys_off_data - sys-off callback argument + * + * @mode: Mode ID. Currently used only by the sys-off restart mode, + * see enum reboot_mode for the available modes. + * @cb_data: User's callback data. + * @cmd: Command string. Currently used only by the sys-off restart mode, + * NULL otherwise. + */ +struct sys_off_data { + int mode; + void *cb_data; + const char *cmd; +}; + +struct sys_off_handler * +register_sys_off_handler(enum sys_off_mode mode, + int priority, + int (*callback)(struct sys_off_data *data), + void *cb_data); +void unregister_sys_off_handler(struct sys_off_handler *handler); + +int devm_register_sys_off_handler(struct device *dev, + enum sys_off_mode mode, + int priority, + int (*callback)(struct sys_off_data *data), + void *cb_data); + /* * Architecture independent implemenations of sys_reboot commands. */ diff --git a/kernel/reboot.c b/kernel/reboot.c index 8ce30fa0a104..672a658f21ee 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -48,6 +48,15 @@ int reboot_cpu; enum reboot_type reboot_type = BOOT_ACPI; int reboot_force; +struct sys_off_handler { + struct notifier_block nb; + int (*sys_off_cb)(struct sys_off_data *data); + void *cb_data; + enum sys_off_mode mode; + bool blocking; + void *list; +}; + /* * If set, this is used for preparing the system to power off. */ @@ -281,6 +290,179 @@ void kernel_halt(void) } EXPORT_SYMBOL_GPL(kernel_halt); +/* + * Notifier list for kernel code which wants to be called + * to prepare system for power off. + */ +static BLOCKING_NOTIFIER_HEAD(power_off_prep_handler_list); + +/* + * Notifier list for kernel code which wants to be called + * to power off system. + */ +static ATOMIC_NOTIFIER_HEAD(power_off_handler_list); + +static int sys_off_notify(struct notifier_block *nb, + unsigned long mode, void *cmd) +{ + struct sys_off_handler *handler; + struct sys_off_data data = {}; + + handler = container_of(nb, struct sys_off_handler, nb); + data.cb_data = handler->cb_data; + data.mode = mode; + data.cmd = cmd; + + return handler->sys_off_cb(&data); +} + +/** + * register_sys_off_handler - Register sys-off handler + * @mode: Sys-off mode + * @priority: Handler priority + * @callback: Callback function + * @cb_data: Callback argument + * + * Registers system power-off or restart handler that will be invoked + * at the step corresponding to the given sys-off mode. Handler's callback + * should return NOTIFY_DONE to permit execution of the next handler in + * the call chain or NOTIFY_STOP to break the chain (in error case for + * example). + * + * Multiple handlers can be registered at the default priority level. + * + * Only one handler can be registered at the non-default priority level, + * otherwise ERR_PTR(-EBUSY) is returned. + * + * Returns a new instance of struct sys_off_handler on success, or + * an ERR_PTR()-encoded error code otherwise. + */ +struct sys_off_handler * +register_sys_off_handler(enum sys_off_mode mode, + int priority, + int (*callback)(struct sys_off_data *data), + void *cb_data) +{ + struct sys_off_handler *handler; + int err; + + handler = kzalloc(sizeof(*handler), GFP_KERNEL); + if (!handler) + return ERR_PTR(-ENOMEM); + + switch (mode) { + case SYS_OFF_MODE_POWER_OFF_PREPARE: + handler->list = &power_off_prep_handler_list; + handler->blocking = true; + break; + + case SYS_OFF_MODE_POWER_OFF: + handler->list = &power_off_handler_list; + break; + + case SYS_OFF_MODE_RESTART: + handler->list = &restart_handler_list; + break; + + default: + kfree(handler); + return ERR_PTR(-EINVAL); + } + + handler->nb.notifier_call = sys_off_notify; + handler->nb.priority = priority; + handler->sys_off_cb = callback; + handler->cb_data = cb_data; + handler->mode = mode; + + if (handler->blocking) { + if (priority == SYS_OFF_PRIO_DEFAULT) + err = blocking_notifier_chain_register(handler->list, + &handler->nb); + else + err = blocking_notifier_chain_register_unique_prio(handler->list, + &handler->nb); + } else { + if (priority == SYS_OFF_PRIO_DEFAULT) + err = atomic_notifier_chain_register(handler->list, + &handler->nb); + else + err = atomic_notifier_chain_register_unique_prio(handler->list, + &handler->nb); + } + + if (err) { + kfree(handler); + return ERR_PTR(err); + } + + return handler; +} +EXPORT_SYMBOL_GPL(register_sys_off_handler); + +/** + * unregister_sys_off_handler - Unregister sys-off handler + * @handler: Sys-off handler + * + * Unregisters given sys-off handler. + */ +void unregister_sys_off_handler(struct sys_off_handler *handler) +{ + int err; + + if (!handler) + return; + + if (handler->blocking) + err = blocking_notifier_chain_unregister(handler->list, + &handler->nb); + else + err = atomic_notifier_chain_unregister(handler->list, + &handler->nb); + + /* sanity check, shall never happen */ + WARN_ON(err); + + kfree(handler); +} +EXPORT_SYMBOL_GPL(unregister_sys_off_handler); + +static void devm_unregister_sys_off_handler(void *data) +{ + struct sys_off_handler *handler = data; + + unregister_sys_off_handler(handler); +} + +/** + * devm_register_sys_off_handler - Register sys-off handler + * @dev: Device that registers handler + * @mode: Sys-off mode + * @priority: Handler priority + * @callback: Callback function + * @cb_data: Callback argument + * + * Registers resource-managed sys-off handler. + * + * Returns zero on success, or error code on failure. + */ +int devm_register_sys_off_handler(struct device *dev, + enum sys_off_mode mode, + int priority, + int (*callback)(struct sys_off_data *data), + void *cb_data) +{ + struct sys_off_handler *handler; + + handler = register_sys_off_handler(mode, priority, callback, cb_data); + if (IS_ERR(handler)) + return PTR_ERR(handler); + + return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler, + handler); +} +EXPORT_SYMBOL_GPL(devm_register_sys_off_handler); + /** * kernel_power_off - power_off the system * -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324876.547197 (Exim 4.92) (envelope-from ) id 1noCsU-0000GQ-5N; Mon, 09 May 2022 23:33:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324876.547197; Mon, 09 May 2022 23:33:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsU-0000GF-18; Mon, 09 May 2022 23:33:22 +0000 Received: by outflank-mailman (input) for mailman id 324876; Mon, 09 May 2022 23:33:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsR-0007bw-Rq for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:19 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6841f3a4-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:19 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 17BD61F41D8C X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6841f3a4-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139198; bh=95ioqXFiu/sMhB4rC2pN2mOqsgk/IiTVsJJFignNnOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kd6IbYNbTMtYO8XHzDROg022CiuVMjD14vclGIX2y/UPqQJTY83k+AAQHlzWmnvvY DIbOq+AJ+ca0dm9KVPtIZY6LIwJR0dvHVODvj+gWmFv2rrA23tSPFfLb/Ld7WXpuF/ H2du8HyPkBmRsP8eQLukPdey+A1NM1blJJ0oKFmsjrsM19cx1w60DHdJiFj+BNJHgA CT2Gw205sJVKh3AqToaLUeLHth6M3pyFt+gPqA8mU19vHxX0uyWcQDKqZ8zNR9Nmqu cRtxZ2gdReA9506AcmJOJiJA6+rn1NttYLHyho2AlivK1XjmQN+dXmlaF9eF72LNY1 oD4iLEbpsl5mw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 04/27] kernel/reboot: Wrap legacy power-off callbacks into sys-off handlers Date: Tue, 10 May 2022 02:32:12 +0300 Message-Id: <20220509233235.995021-5-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Wrap legacy power-off callbacks into sys-off handlers in order to support co-existence of both legacy and new callbacks while we're in process of upgrading legacy callbacks to the new API. Signed-off-by: Dmitry Osipenko --- kernel/reboot.c | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/kernel/reboot.c b/kernel/reboot.c index 672a658f21ee..2fb0357d9483 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -463,6 +463,47 @@ int devm_register_sys_off_handler(struct device *dev, } EXPORT_SYMBOL_GPL(devm_register_sys_off_handler); +static int legacy_pm_power_off_prepare(struct sys_off_data *data) +{ + if (pm_power_off_prepare) + pm_power_off_prepare(); + + return NOTIFY_DONE; +} + +static int legacy_pm_power_off(struct sys_off_data *data) +{ + if (pm_power_off) + pm_power_off(); + + return NOTIFY_DONE; +} + +/* + * Register sys-off handlers for legacy PM callbacks. This allows legacy + * PM callbacks co-exist with the new sys-off API. + * + * TODO: Remove legacy handlers once all legacy PM users will be switched + * to the sys-off based APIs. + */ +static int __init legacy_pm_init(void) +{ + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF_PREPARE, + SYS_OFF_PRIO_DEFAULT, + legacy_pm_power_off_prepare, NULL); + + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, + legacy_pm_power_off, NULL); + + return 0; +} +core_initcall(legacy_pm_init); + +static void do_kernel_power_off_prepare(void) +{ + blocking_notifier_call_chain(&power_off_prep_handler_list, 0, NULL); +} + /** * kernel_power_off - power_off the system * @@ -471,8 +512,7 @@ EXPORT_SYMBOL_GPL(devm_register_sys_off_handler); void kernel_power_off(void) { kernel_shutdown_prepare(SYSTEM_POWER_OFF); - if (pm_power_off_prepare) - pm_power_off_prepare(); + do_kernel_power_off_prepare(); migrate_to_reboot_cpu(); syscore_shutdown(); pr_emerg("Power down\n"); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324881.547208 (Exim 4.92) (envelope-from ) id 1noCsX-0000dc-GP; Mon, 09 May 2022 23:33:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324881.547208; Mon, 09 May 2022 23:33:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsX-0000dK-Bd; Mon, 09 May 2022 23:33:25 +0000 Received: by outflank-mailman (input) for mailman id 324881; Mon, 09 May 2022 23:33:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsV-0007bw-Sw for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:23 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a98b542-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:23 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 0842C1F41E8A X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a98b542-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139202; bh=8Fx2NXCMOUBUfmtFhnG6e+1bhUvia7Lkro+EJHtjozI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RryRpTBWSvFrqD7A7EctZOMN6tE1a1/5heQcWEPcVbcoeASmRzyrn+watrDphnz1q gr0qo93ZE/53tbomd6WV1UoDxm182gd/Hwbei2xLmUuosOcOg00u121ZZYdCv5U0Ec ADOyWCsjg1iIXn/9D6iPK+ueBrwxIG/eVse+9TJHcuDRFcjJUAqLMIwnYbPaNy2viZ LcZ/hWkRfc3wjZpKDS3wxSoVKAByM9jcjXSEITcDoaj2VrvHgo3EaXqnrqMzZkrxws AbnZOxmEdJ1KPvFAifSKgdx2cTW2g9ZZvBuT5AlXPNuvg1BMexEMF47dJ+tuFKEEYa aihfJhaIo/8qw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 05/27] kernel/reboot: Add do_kernel_power_off() Date: Tue, 10 May 2022 02:32:13 +0300 Message-Id: <20220509233235.995021-6-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add do_kernel_power_off() helper that will remove open-coded pm_power_off invocations from the architecture code. This is the first step on the way to remove the global pm_power_off variable, which will allow us to implement consistent power-off chaining support. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 2 ++ kernel/reboot.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index 05981ef079d8..6b951d68c0c7 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -63,6 +63,8 @@ extern void machine_shutdown(void); struct pt_regs; extern void machine_crash_shutdown(struct pt_regs *); +void do_kernel_power_off(void); + /* * sys-off handler API. */ diff --git a/kernel/reboot.c b/kernel/reboot.c index 2fb0357d9483..9afa99a32d62 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -504,6 +504,19 @@ static void do_kernel_power_off_prepare(void) blocking_notifier_call_chain(&power_off_prep_handler_list, 0, NULL); } +/** + * do_kernel_power_off - Execute kernel power-off handler call chain + * + * Expected to be called as last step of the power-off sequence. + * + * Powers off the system immediately if a power-off handler function has + * been registered. Otherwise does nothing. + */ +void do_kernel_power_off(void) +{ + atomic_notifier_call_chain(&power_off_handler_list, 0, NULL); +} + /** * kernel_power_off - power_off the system * -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324886.547219 (Exim 4.92) (envelope-from ) id 1noCsb-0001Gh-SY; Mon, 09 May 2022 23:33:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324886.547219; Mon, 09 May 2022 23:33:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsb-0001Fe-NN; Mon, 09 May 2022 23:33:29 +0000 Received: by outflank-mailman (input) for mailman id 324886; Mon, 09 May 2022 23:33:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsa-0007Pf-Fe for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:28 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cf07609-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:27 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id EB6021F43062 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cf07609-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139206; bh=ADq4GZWEPNK7q9JUz/PJH0s7RkDgF/Hn0bL9XYpd1xY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KGyjgFeHS4c4whO9DLRPI4YnH/I1kcxhGjuZMUHWMXxrPTowBH3nsSioG+grbG2E8 mnkheS9YppXiE1XFZmpN8+NhD/nzj2UXihmV79dBZXmBvvWVTCKWXHTP8bvClUAXj1 4nlNgidw2ooBaq465rODMaKeABNVE6nkuJ7Q8Xm3bGYMUs6PLqgcdGYa5CtQU2PUK/ Jza3RN8pd4IlpFmarCSW5s3ufDshdt5+jjA/5gruEo9hsKxIniPgqZA10L6lW8+LoM tuiD7AddByNEUUZsYAIaBWxhshHGAxlCDHWH4Mq16erEhm603eMlSqLobcqsLKpUet qm4lCWHEs4Jdw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 06/27] kernel/reboot: Add stub for pm_power_off Date: Tue, 10 May 2022 02:32:14 +0300 Message-Id: <20220509233235.995021-7-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add weak stub for the global pm_power_off callback variable. This will allow us to remove pm_power_off definitions from arch/ code and transition to the new sys-off based API that will replace the global variable. Signed-off-by: Dmitry Osipenko --- kernel/reboot.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/reboot.c b/kernel/reboot.c index 9afa99a32d62..eaede35f45e2 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -57,6 +57,12 @@ struct sys_off_handler { void *list; }; +/* + * Temporary stub that prevents linkage failure while we're in process + * of removing all uses of legacy pm_power_off() around the kernel. + */ +void __weak (*pm_power_off)(void); + /* * If set, this is used for preparing the system to power off. */ -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324889.547230 (Exim 4.92) (envelope-from ) id 1noCse-0001k6-Ju; Mon, 09 May 2022 23:33:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324889.547230; Mon, 09 May 2022 23:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCse-0001js-ET; Mon, 09 May 2022 23:33:32 +0000 Received: by outflank-mailman (input) for mailman id 324889; Mon, 09 May 2022 23:33:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsd-0007Pf-HY for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:31 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f3f321f-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:30 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id DDF821F430B3 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f3f321f-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139210; bh=YK0F6fR8XWeV2rG0cbTxAWJjHbs9t/ROkX6NXAfeuRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WX2wLAoFqw2NcqFA+1BgEi+pnSqQ/OT0ntArBclZh3rRdgYWFpNobAvm6ZwR47f5O UVB/nJt08DF0z35eem1y5e29iS6TGa3FlqumDo8Gztlg9RTEy3yXgoM/PdqWZ72qjH BBXHhpZMhXXq1gmyrAUnf9JuPFEL0VuxOWgpl0g7gErLQMCAr8EBR7mlBfM7b/CzpF rbbVZCAv5Su19JHE0dZAYAwszfCQR2CPfwc4wUkYqtr+WKd4w8pxs2RFEPFv5Qa681 /mjY+RYiodQ7Rz1Y3p36rejWNrVlI8LiNaH4VL6v6O9rIPyvlE8v1d9uqae+R0n5sB mZdrZdLthuUpw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off() Date: Tue, 10 May 2022 02:32:15 +0300 Message-Id: <20220509233235.995021-8-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add kernel_can_power_off() helper that replaces open-coded checks of the global pm_power_off variable. This is a necessary step towards supporting chained power-off handlers. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 1 + kernel/reboot.c | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index 6b951d68c0c7..c52f77ee4ddd 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -149,6 +149,7 @@ extern void kernel_restart_prepare(char *cmd); extern void kernel_restart(char *cmd); extern void kernel_halt(void); extern void kernel_power_off(void); +extern bool kernel_can_power_off(void); void ctrl_alt_del(void); diff --git a/kernel/reboot.c b/kernel/reboot.c index eaede35f45e2..982e58c11ce8 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -523,6 +523,18 @@ void do_kernel_power_off(void) atomic_notifier_call_chain(&power_off_handler_list, 0, NULL); } +/** + * kernel_can_power_off - check whether system can be powered off + * + * Returns true if power-off handler is registered and system can be + * powered off, false otherwise. + */ +bool kernel_can_power_off(void) +{ + return !atomic_notifier_call_chain_is_empty(&power_off_handler_list); +} +EXPORT_SYMBOL_GPL(kernel_can_power_off); + /** * kernel_power_off - power_off the system * @@ -581,7 +593,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd, /* Instead of trying to make the power_off code look like * halt when pm_power_off is not set do it the easy way. */ - if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !pm_power_off) + if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !kernel_can_power_off()) cmd = LINUX_REBOOT_CMD_HALT; mutex_lock(&system_transition_mutex); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:33:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324891.547241 (Exim 4.92) (envelope-from ) id 1noCsj-0002ND-0C; Mon, 09 May 2022 23:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324891.547241; Mon, 09 May 2022 23:33:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsi-0002N0-Sq; Mon, 09 May 2022 23:33:36 +0000 Received: by outflank-mailman (input) for mailman id 324891; Mon, 09 May 2022 23:33:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsh-0007Pf-Ho for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:35 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7192045c-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:34 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id C21B61F430BF X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7192045c-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139214; bh=hTMdSPi0zN4MGEkpm7fbCDxWpGgYrC/cc+PuY565mHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sk8pDCwXSAwTQ9cVTZlPz8a8ySrGY3hGrPt+VGDskV6R+uCOw9LADMc/JKfeftNPo asFxJcHbxHiK/3w91N3jvIgWMJgwCq+N4MlCfsgguAazqG3J0kdIxL0enJF0AIFfvB qrj4DZBOnMGXRehw13w/Gqu1lXja85Nu7DH8kFwOkMscD0FBV8ggmpXlUuebyAbpd6 13JtTCF+jbP9cTENV6T22N6ht/UOp/jY7vlhjRhQskgAm5LbyaAdU+aqJl1oWzNotR zhh4iJ4DmsyzvGmL9Z1V2DZh2YCAdFZhUlWdl4dlLp7iND0uYa6NncprgcDCwwXRCN BwArMJ/2esCeg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 08/27] kernel/reboot: Add register_platform_power_off() Date: Tue, 10 May 2022 02:32:16 +0300 Message-Id: <20220509233235.995021-9-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add platform-level registration helpers that will ease transition of the arch/platform power-off callbacks to the new sys-off based API, allowing us to remove the global pm_power_off variable in the future. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 3 +++ kernel/reboot.c | 55 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index c52f77ee4ddd..f185b64faae0 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -141,6 +141,9 @@ int devm_register_sys_off_handler(struct device *dev, int (*callback)(struct sys_off_data *data), void *cb_data); +int register_platform_power_off(void (*power_off)(void)); +void unregister_platform_power_off(void (*power_off)(void)); + /* * Architecture independent implemenations of sys_reboot commands. */ diff --git a/kernel/reboot.c b/kernel/reboot.c index 982e58c11ce8..e74103f2a801 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -469,6 +469,61 @@ int devm_register_sys_off_handler(struct device *dev, } EXPORT_SYMBOL_GPL(devm_register_sys_off_handler); +static struct sys_off_handler *platform_power_off_handler; + +static int platform_power_off_notify(struct sys_off_data *data) +{ + void (*platform_power_power_off_cb)(void) = data->cb_data; + + platform_power_power_off_cb(); + + return NOTIFY_DONE; +} + +/** + * register_platform_power_off - Register platform-level power-off callback + * @power_off: Power-off callback + * + * Registers power-off callback that will be called as last step + * of the power-off sequence. This callback is expected to be invoked + * for the last resort. Only one platform power-off callback is allowed + * to be registered at a time. + * + * Returns zero on success, or error code on failure. + */ +int register_platform_power_off(void (*power_off)(void)) +{ + struct sys_off_handler *handler; + + handler = register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_PLATFORM, + platform_power_off_notify, + power_off); + if (IS_ERR(handler)) + return PTR_ERR(handler); + + platform_power_off_handler = handler; + + return 0; +} +EXPORT_SYMBOL_GPL(register_platform_power_off); + +/** + * unregister_platform_power_off - Unregister platform-level power-off callback + * @power_off: Power-off callback + * + * Unregisters previously registered platform power-off callback. + */ +void unregister_platform_power_off(void (*power_off)(void)) +{ + if (platform_power_off_handler && + platform_power_off_handler->cb_data == power_off) { + unregister_sys_off_handler(platform_power_off_handler); + platform_power_off_handler = NULL; + } +} +EXPORT_SYMBOL_GPL(unregister_platform_power_off); + static int legacy_pm_power_off_prepare(struct sys_off_data *data) { if (pm_power_off_prepare) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324892.547251 (Exim 4.92) (envelope-from ) id 1noD0P-00059W-R0; Mon, 09 May 2022 23:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324892.547251; Mon, 09 May 2022 23:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0P-00059P-OT; Mon, 09 May 2022 23:41:33 +0000 Received: by outflank-mailman (input) for mailman id 324892; Mon, 09 May 2022 23:41:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCss-0007bw-2E for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:46 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7638ec4d-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:42 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 959D61F441CC X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7638ec4d-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139222; bh=6s0maqcEZmA2YXgu3K4UCDPu+D53/76G+RW0Zx9hW8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h4OvUVSAAn8ONu+FqbmPB/ZUg1Qkbk6CMBh2JL9wBLZZNByEx452+sfFnsAzbrW5g WobsFtZ/ugKUfeWEuu8gKnblyxG7kr6RGNcK/DuRUjgE7VnPsIPzVT6BWE/ogkwXcM ZEa6zQM9Ud51zEudJ43wylNsHR/LBoT0+ycy6T0RzK3M4I3LXqeJ068zrXIUjA3hEU FWiFVtYOTuHH+O/MM14WQytKXOng1sNd/DkdhgtmsB0Ohc4IKE/Ry6rNzouXX33NP9 PLUYHYobr5c/gP/EBTkVk4jNp31Iu2OSNaJdJc28/R7zEnpy6HkG+xlpPc3bqWbG1U Qw6/DNrpVeC/A== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 10/27] csky: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:18 +0300 Message-Id: <20220509233235.995021-11-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Guo Ren Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/csky/kernel/power.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c index 923ee4e381b8..86ee202906f8 100644 --- a/arch/csky/kernel/power.c +++ b/arch/csky/kernel/power.c @@ -9,16 +9,14 @@ EXPORT_SYMBOL(pm_power_off); void machine_power_off(void) { local_irq_disable(); - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); asm volatile ("bkpt"); } void machine_halt(void) { local_irq_disable(); - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); asm volatile ("bkpt"); } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324897.547262 (Exim 4.92) (envelope-from ) id 1noD0f-0005Zp-4G; Mon, 09 May 2022 23:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324897.547262; Mon, 09 May 2022 23:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0e-0005Ze-Vp; Mon, 09 May 2022 23:41:48 +0000 Received: by outflank-mailman (input) for mailman id 324897; Mon, 09 May 2022 23:41:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtO-0007Pf-Ho for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:18 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b427652-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:34:17 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id CD6681F44218 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b427652-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139257; bh=vRb4DtICDxJaROyEtMW3UwUdcH4tg+twL9gOXYS6wp8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gt4u81G/LFxhoOEWGR2YMg+vhkXhorm0jgFd64YTZTuXmM+7vG7f3q4ZdaFuqYRJS tGUmDGjP5E8g3OsXjzvy7rc8/B4hk2wxUh254z6arCFJCq4Zn4nYnOEuMGAFxhhkwc FeFBnrORsJSOriC3iEOi3iWo3k8QOf23bj2Nt6IUYGS+Vok5FiMxP+66U31QsS8qsL mVpptTyKx3JXLvhtJiVMPU7cAlmSudorXN3MNL4LPBNQ56Fm1aY+u8x67N3P+KtJ22 6BIPyxJsFkQfhUsOqyWUF/BWHTPKTs8seyIqQEcyu9CdhBsdEQuumAGveCtmifiXNx wIYCEzEJi6pLw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 19/27] ia64: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:27 +0300 Message-Id: <20220509233235.995021-20-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/ia64/kernel/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c index 167b1765bea1..416305e550e2 100644 --- a/arch/ia64/kernel/process.c +++ b/arch/ia64/kernel/process.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -602,8 +603,7 @@ machine_halt (void) void machine_power_off (void) { - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); machine_halt(); } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324899.547268 (Exim 4.92) (envelope-from ) id 1noD0f-0005dp-GW; Mon, 09 May 2022 23:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324899.547268; Mon, 09 May 2022 23:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0f-0005d4-9l; Mon, 09 May 2022 23:41:49 +0000 Received: by outflank-mailman (input) for mailman id 324899; Mon, 09 May 2022 23:41:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtE-0007Pf-G3 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:08 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84442b42-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:34:06 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 27D201F441E8 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84442b42-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139245; bh=UIPgsOrU+7AAtuw/dxUkFlU2eOnuIo9CRihQlVqmebk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fku9vc/2LuyumwlnC4+CCfHyXuo2y9yUU8GPF/ZI7s8OKQFM74txrzVi6nNXLlzUX tyRuTLx1n3NoysMf0kVYsv7We+si4accSBbu6VVwIE3dNI64qNCz390xl2MEQBdJgP XCk5VY/gacC4aFPizlR8qXmXItj5EltNXSZOhG0q5C/otCou8Y+oeWHt1b7/84FtcJ V46TUTlkaRTyV8fgcad20JX4TsWNYb6KjhEurv1g4P603cs1svTnBoGtuJwRNL4fAb wRy/NdoI0yfdehGCDv15CZSP4Ye2AgBXXEmNdgpKZ6EiezR2K2vEQfbxIoMMTv1Ho+ Gs0IHfjDLhj5g== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 16/27] m68k: Switch to new sys-off handler API Date: Tue, 10 May 2022 02:32:24 +0300 Message-Id: <20220509233235.995021-17-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use register_power_off_handler() that registers power-off handlers and do_kernel_power_off() that invokes chained power-off handlers. Legacy pm_power_off() will be removed once all drivers will be converted to the new sys-off API. Normally arch code should adopt only the do_kernel_power_off() at first, but m68k is a special case because it uses pm_power_off() "inside out", i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing], while it's machine_power_off() that should invoke the pm_power_off(), and thus, we can't convert platforms to the new API separately. There are only two platforms changed here, so it's not a big deal. Acked-by: Geert Uytterhoeven Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/m68k/emu/natfeat.c | 3 ++- arch/m68k/include/asm/machdep.h | 1 - arch/m68k/kernel/process.c | 5 ++--- arch/m68k/kernel/setup_mm.c | 1 - arch/m68k/kernel/setup_no.c | 1 - arch/m68k/mac/config.c | 4 +++- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/arch/m68k/emu/natfeat.c b/arch/m68k/emu/natfeat.c index 71b78ecee75c..b19dc00026d9 100644 --- a/arch/m68k/emu/natfeat.c +++ b/arch/m68k/emu/natfeat.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -90,5 +91,5 @@ void __init nf_init(void) pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16, version & 0xffff); - mach_power_off = nf_poweroff; + register_platform_power_off(nf_poweroff); } diff --git a/arch/m68k/include/asm/machdep.h b/arch/m68k/include/asm/machdep.h index 8fd80ef1b77e..8d8c3ee2069f 100644 --- a/arch/m68k/include/asm/machdep.h +++ b/arch/m68k/include/asm/machdep.h @@ -24,7 +24,6 @@ extern int (*mach_get_rtc_pll)(struct rtc_pll_info *); extern int (*mach_set_rtc_pll)(struct rtc_pll_info *); extern void (*mach_reset)( void ); extern void (*mach_halt)( void ); -extern void (*mach_power_off)( void ); extern unsigned long (*mach_hd_init) (unsigned long, unsigned long); extern void (*mach_hd_setup)(char *, int *); extern void (*mach_heartbeat) (int); diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c index 221feb0269f1..2cb4a61bcfac 100644 --- a/arch/m68k/kernel/process.c +++ b/arch/m68k/kernel/process.c @@ -67,12 +67,11 @@ void machine_halt(void) void machine_power_off(void) { - if (mach_power_off) - mach_power_off(); + do_kernel_power_off(); for (;;); } -void (*pm_power_off)(void) = machine_power_off; +void (*pm_power_off)(void); EXPORT_SYMBOL(pm_power_off); void show_regs(struct pt_regs * regs) diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c index 78ab562beb31..42691abcd908 100644 --- a/arch/m68k/kernel/setup_mm.c +++ b/arch/m68k/kernel/setup_mm.c @@ -98,7 +98,6 @@ EXPORT_SYMBOL(mach_get_rtc_pll); EXPORT_SYMBOL(mach_set_rtc_pll); void (*mach_reset)( void ); void (*mach_halt)( void ); -void (*mach_power_off)( void ); #ifdef CONFIG_HEARTBEAT void (*mach_heartbeat) (int); EXPORT_SYMBOL(mach_heartbeat); diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c index 5e4104f07a44..00bf82258233 100644 --- a/arch/m68k/kernel/setup_no.c +++ b/arch/m68k/kernel/setup_no.c @@ -55,7 +55,6 @@ int (*mach_hwclk) (int, struct rtc_time*); /* machine dependent reboot functions */ void (*mach_reset)(void); void (*mach_halt)(void); -void (*mach_power_off)(void); #ifdef CONFIG_M68000 #if defined(CONFIG_M68328) diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c index 65d124ec80bb..382f656c29ea 100644 --- a/arch/m68k/mac/config.c +++ b/arch/m68k/mac/config.c @@ -12,6 +12,7 @@ #include #include +#include #include #include #include @@ -140,7 +141,6 @@ void __init config_mac(void) mach_hwclk = mac_hwclk; mach_reset = mac_reset; mach_halt = mac_poweroff; - mach_power_off = mac_poweroff; #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP) mach_beep = mac_mksound; #endif @@ -160,6 +160,8 @@ void __init config_mac(void) if (macintosh_config->ident == MAC_MODEL_IICI) mach_l2_flush = via_l2_flush; + + register_platform_power_off(mac_poweroff); } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324900.547275 (Exim 4.92) (envelope-from ) id 1noD0f-0005ko-Uq; Mon, 09 May 2022 23:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324900.547275; Mon, 09 May 2022 23:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0f-0005hj-Kp; Mon, 09 May 2022 23:41:49 +0000 Received: by outflank-mailman (input) for mailman id 324900; Mon, 09 May 2022 23:41:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtK-0007bw-Ji for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:14 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88ece6ef-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:14 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id E7D5B1F441FD X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88ece6ef-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139253; bh=i0EpyUpthjBui1PGSfTlV0XdMEaBb9rmJl1vNRe/ntg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cOsU2r2Eblivwj/4cs5M9vQ+EIm4O22kzOvkVpXBwVaGlQQqUaU+9c9J8h2kpjBSt GpXjMQQdLCoJJlIHF5IfMSLeGCyJvESoQPCKt3kCPQedCVqLaoeEopcTf+HEY5q1lO jJ/uDMUpGaMZkBso16PjrWo29hM7vhwjdcV20pn3IDz86wk5E9pcvm7DLWuJ5eN3xe Rv7XJipXyrsWHlwyWVQKKYth00nFChhonNPtOvFo1TEnjkAjXR2JiSFF1yvm2SKeAq YVHXAi1edwQHbtnVBglD/8RVeEInLaeMWxknedL6gsMlzSmRogo0SRclXVYd+laLv3 s6F3Ihd0ore/g== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 18/27] x86: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:26 +0300 Message-Id: <20220509233235.995021-19-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/x86/kernel/reboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index fa700b46588e..c3636ea4aa71 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -739,10 +739,10 @@ static void native_machine_halt(void) static void native_machine_power_off(void) { - if (pm_power_off) { + if (kernel_can_power_off()) { if (!reboot_force) machine_shutdown(); - pm_power_off(); + do_kernel_power_off(); } /* A fallback in case there is no PM info available */ tboot_shutdown(TB_SHUTDOWN_HALT); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324903.547283 (Exim 4.92) (envelope-from ) id 1noD0g-0005xX-Od; Mon, 09 May 2022 23:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324903.547283; Mon, 09 May 2022 23:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0g-0005vz-Dl; Mon, 09 May 2022 23:41:50 +0000 Received: by outflank-mailman (input) for mailman id 324903; Mon, 09 May 2022 23:41:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsv-0007bw-3B for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:49 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78984768-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:46 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 73E431F441D0 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78984768-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139226; bh=NosviWpVno2jyBA/nRbYSTQtEBj8GV4Z9PewSWM1PEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZGjg6ajBdqbT1rRkOpHVX0Fuw48bMRqsSdYq9OtGSbC/n4RUaCQK6bD1TfVppwXu A7CMRQ1sz+q7MHQphaKKP01aCStcy0QSDdJj6vPvNjv9pUTGAbqF3VBfFZMfHZLrUT 4gIsmgu/2N3okauIgJNPFKpgzlwu1WqpdL2MvAV4GSqjXPbt4r9xFqMPheNolvDet2 kMcoUipX5yr2TOyCk4QjYL0MBISYscS7bfG03xrjN4MwX8RPG34WsyJWFAxY/Npiwj 8KVsTsWb21V2VhPTYdzbV4VLe2voj7X93srVxn9dA4Uv/y1s9ujK0+2rqIH75bp++P fqEdP4SIC3mNA== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 11/27] riscv: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:19 +0300 Message-Id: <20220509233235.995021-12-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Palmer Dabbelt Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/riscv/kernel/reset.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index 9c842c41684a..912288572226 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -23,16 +23,12 @@ void machine_restart(char *cmd) void machine_halt(void) { - if (pm_power_off != NULL) - pm_power_off(); - else - default_power_off(); + do_kernel_power_off(); + default_power_off(); } void machine_power_off(void) { - if (pm_power_off != NULL) - pm_power_off(); - else - default_power_off(); + do_kernel_power_off(); + default_power_off(); } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:41:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324907.547302 (Exim 4.92) (envelope-from ) id 1noD0i-0006WZ-Dx; Mon, 09 May 2022 23:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324907.547302; Mon, 09 May 2022 23:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0i-0006UN-5o; Mon, 09 May 2022 23:41:52 +0000 Received: by outflank-mailman (input) for mailman id 324907; Mon, 09 May 2022 23:41:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCt1-0007Pf-4W for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:55 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d54017e-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:54 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 777391F441DA X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d54017e-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139234; bh=CZQ7QwYyjXyLiPmx1jEp6oFdo06Stqavz0Fvz+iublM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SDwxSlJbQCiHJPQR1lFxat/dNwe8Cw95mO18xUWrblUCwDvptuIvvEihxQgGpz5lE v2+pPQDPfEo3nnjLdmECYiEfCheycMmmwveoEMSaWwJXDRf8e887FYh72xXKEegajp QaQcT3OCtuH2kjObn8s3MAYD2oH9anmXSqs9c04hn+AcRFQ/mX1WKGwRGep7JOFA4H C4Kw1/Eunfbvp/ckKUJxjBvsJXFMHtbcJothUCcVahPvTLvth5UGn5EftS+9NNh38M HjrUmzlEFiFFJMInbk7G2giz3tbBsMgkXr4iYVpbDdzeOedK37AnhRRRKckmNr0O4x VvnSrMrlH5ppw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 13/27] parisc: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:21 +0300 Message-Id: <20220509233235.995021-14-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Helge Deller # parisc Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/parisc/kernel/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c index a6a2a558fc5b..7c37e09c92da 100644 --- a/arch/parisc/kernel/process.c +++ b/arch/parisc/kernel/process.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -116,8 +117,7 @@ void machine_power_off(void) pdc_chassis_send_status(PDC_CHASSIS_DIRECT_SHUTDOWN); /* ipmi_poweroff may have been installed. */ - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); /* It seems we have no way to power the system off via * software. The user has to press the button himself. */ -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324921.547318 (Exim 4.92) (envelope-from ) id 1noD0u-0007iV-Ox; Mon, 09 May 2022 23:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324921.547318; Mon, 09 May 2022 23:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0u-0007iI-JZ; Mon, 09 May 2022 23:42:04 +0000 Received: by outflank-mailman (input) for mailman id 324921; Mon, 09 May 2022 23:42:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCt5-0007Pf-1T for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:59 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fa59ed8-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:58 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 6209F1F441DD X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fa59ed8-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139238; bh=UUAJJ/IBIhNY6NA1AxJmIDD0rKb6vfi9bj1ZHogZ1sk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TkUASExCPh+FoXzL2OnCGIIu2Z2HXaBISDFgR7ixWfN1WdyIfCSpaUflnD7rWGxDG vQCzwQpQuFj71TlHQA9DCAV9sF+sdQH9hcN7lAC3LqA9C4TbZrGN3bNuc1ngng/O7i rySb86VyOpMwBjDX/TS735BJig4rEchyEIwVD9KJ+d21dHQBFQDukdAhgeiYB28NSu ynWq6arqtBNX91H7sywe74sjkSSFI7BlaiTD+aG/xhTaRyK3ZGoePGigvGG/rQBHkh cCEmV1YRV999ye8BFKhlDYmcEURuTzQcgUzY2QPWWaOq0izK+9ObffwREMFkcbNPRX aXMbf/7L3uBQA== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 14/27] xen/x86: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:22 +0300 Message-Id: <20220509233235.995021-15-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Juergen Gross Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/x86/xen/enlighten_pv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5038edb79ad5..af1f6e886225 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include @@ -1071,8 +1072,7 @@ static void xen_machine_halt(void) static void xen_machine_power_off(void) { - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); xen_reboot(SHUTDOWN_poweroff); } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324925.547327 (Exim 4.92) (envelope-from ) id 1noD0w-0007yE-56; Mon, 09 May 2022 23:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324925.547327; Mon, 09 May 2022 23:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0v-0007xo-Vn; Mon, 09 May 2022 23:42:05 +0000 Received: by outflank-mailman (input) for mailman id 324925; Mon, 09 May 2022 23:42:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtm-0007Pf-H0 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:42 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 994fdaa8-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:34:41 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 5FA2B1F44233 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 994fdaa8-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139281; bh=Ge1//7i6Q7MuMgcY2ArEpQFOii60ywtSL9zBDeDpHaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H63Tb2tlpLUiWc6ACD6bN74KE3zuMrgz9FpthVYg38IHOdVsOtd5gN8jhFLo+Pa26 hs3OdXJ/W7jQd8mbRnl7S0Tm0sIYF5zc1kuEqf5uJUQxP7C97twdtSpF0zmaMHFZpP ONQppB1vE3Lpbt5fwJ8pEErw8LFPXaCyFxpYTqpIqc9itsfVnIkxxLday9aSt7wpJs YxQBKfwJ/Iz+5zQnhlFym5/j9qqEfpuYXBe4Vcz//MAzUbelLYvi5aQm6UbmkDj593 dwr3JjS/IdqCE0xS5mAXyMmGozEFSLnZzAzFvgIjlivvRPRrzc9t4UYSSRAb0HfzCv wv4pCpKHdQ9Jw== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 25/27] soc/tegra: pmc: Use sys-off handler API to power off Nexus 7 properly Date: Tue, 10 May 2022 02:32:33 +0300 Message-Id: <20220509233235.995021-26-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Nexus 7 Android tablet can be turned off using a special bootloader command which is conveyed to bootloader by putting magic value into the special scratch register and then rebooting normally. This power-off method should be invoked if USB cable is connected. Bootloader then will display battery status and power off the device. This behaviour is borrowed from downstream kernel and matches user expectations, otherwise it looks like device got hung during power-off and it may wake up on USB disconnect. Switch PMC driver to sys-off handler API, which provides drivers with chained power-off callbacks functionality that is required for powering-off devices properly. It also brings resource-managed API for the restart handler registration that makes PMC driver code cleaner. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 87 +++++++++++++++++++++++++++++------------ 1 file changed, 62 insertions(+), 25 deletions(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index c77ecf61818b..5611d14d3ba2 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -108,6 +109,7 @@ #define PMC_USB_DEBOUNCE_DEL 0xec #define PMC_USB_AO 0xf0 +#define PMC_SCRATCH37 0x130 #define PMC_SCRATCH41 0x140 #define PMC_WAKE2_MASK 0x160 @@ -1101,8 +1103,7 @@ static struct notifier_block tegra_pmc_reboot_notifier = { .notifier_call = tegra_pmc_reboot_notify, }; -static int tegra_pmc_restart_notify(struct notifier_block *this, - unsigned long action, void *data) +static void tegra_pmc_restart(void) { u32 value; @@ -1110,14 +1111,31 @@ static int tegra_pmc_restart_notify(struct notifier_block *this, value = tegra_pmc_readl(pmc, PMC_CNTRL); value |= PMC_CNTRL_MAIN_RST; tegra_pmc_writel(pmc, value, PMC_CNTRL); +} + +static int tegra_pmc_restart_handler(struct sys_off_data *data) +{ + tegra_pmc_restart(); return NOTIFY_DONE; } -static struct notifier_block tegra_pmc_restart_handler = { - .notifier_call = tegra_pmc_restart_notify, - .priority = 128, -}; +static int tegra_pmc_power_off_handler(struct sys_off_data *data) +{ + /* + * Reboot Nexus 7 into special bootloader mode if USB cable is + * connected in order to display battery status and power off. + */ + if (of_machine_is_compatible("asus,grouper") && + power_supply_is_system_supplied()) { + const u32 go_to_charger_mode = 0xa5a55a5a; + + tegra_pmc_writel(pmc, go_to_charger_mode, PMC_SCRATCH37); + tegra_pmc_restart(); + } + + return NOTIFY_DONE; +} static int powergate_show(struct seq_file *s, void *data) { @@ -2879,6 +2897,42 @@ static int tegra_pmc_probe(struct platform_device *pdev) pmc->clk = NULL; } + /* + * PMC should be last resort for restarting since it soft-resets + * CPU without resetting everything else. + */ + err = devm_register_reboot_notifier(&pdev->dev, + &tegra_pmc_reboot_notifier); + if (err) { + dev_err(&pdev->dev, "unable to register reboot notifier, %d\n", + err); + return err; + } + + err = devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_RESTART, + SYS_OFF_PRIO_LOW, + tegra_pmc_restart_handler, NULL); + if (err) { + dev_err(&pdev->dev, "failed to register sys-off handler: %d\n", + err); + return err; + } + + /* + * PMC should be primary power-off method if it soft-resets CPU, + * asking bootloader to shutdown hardware. + */ + err = devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_FIRMWARE, + tegra_pmc_power_off_handler, NULL); + if (err) { + dev_err(&pdev->dev, "failed to register sys-off handler: %d\n", + err); + return err; + } + /* * PCLK clock rate can't be retrieved using CLK API because it * causes lockup if CPU enters LP2 idle state from some other @@ -2910,28 +2964,13 @@ static int tegra_pmc_probe(struct platform_device *pdev) goto cleanup_sysfs; } - err = devm_register_reboot_notifier(&pdev->dev, - &tegra_pmc_reboot_notifier); - if (err) { - dev_err(&pdev->dev, "unable to register reboot notifier, %d\n", - err); - goto cleanup_debugfs; - } - - err = register_restart_handler(&tegra_pmc_restart_handler); - if (err) { - dev_err(&pdev->dev, "unable to register restart handler, %d\n", - err); - goto cleanup_debugfs; - } - err = tegra_pmc_pinctrl_init(pmc); if (err) - goto cleanup_restart_handler; + goto cleanup_debugfs; err = tegra_pmc_regmap_init(pmc); if (err < 0) - goto cleanup_restart_handler; + goto cleanup_debugfs; err = tegra_powergate_init(pmc, pdev->dev.of_node); if (err < 0) @@ -2954,8 +2993,6 @@ static int tegra_pmc_probe(struct platform_device *pdev) cleanup_powergates: tegra_powergate_remove_all(pdev->dev.of_node); -cleanup_restart_handler: - unregister_restart_handler(&tegra_pmc_restart_handler); cleanup_debugfs: debugfs_remove(pmc->debugfs); cleanup_sysfs: -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324928.547335 (Exim 4.92) (envelope-from ) id 1noD0x-00087C-C1; Mon, 09 May 2022 23:42:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324928.547335; Mon, 09 May 2022 23:42:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0w-00085x-VC; Mon, 09 May 2022 23:42:06 +0000 Received: by outflank-mailman (input) for mailman id 324928; Mon, 09 May 2022 23:42:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtW-0007bw-9c for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:26 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8feaabfa-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:25 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id A135D1F44222 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8feaabfa-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139265; bh=0HjIUgv+906XrAObDigD/ThUSuZMAL8DnPYgjzjpmC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TWCiuLNt7/xJ8odTWc8GyA2loDND0GGWRmOLSDJZ3/1EOOM46MoO6kcL0XNk3HwPe FBPpCFoePNs4rPAAZRKP+rw/ZolMsMxYimmM4SWHpv67kFo+HnqMhIKFI3o9iJnuWS vNlcat+YAoNJG0U7fH5nF+xZr/J3ldOvzJraAO0ornmvSG33Iwh+7D/WO9KPdopL/I 4fstIQm6rGU1cDpxZRjjzwcmAnN/r2ufy/hVwsd2Ga1ZdsJDzAOFQPmAS1qD2fVhxO UL54muri0ZQhU7rjF30W/z7G7m5ZKwocnvqA9RnpgcfN4zFZ8kzOBHH30lfBRBp5PE p0vvde97M8jrQ== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 21/27] memory: emif: Use kernel_can_power_off() Date: Tue, 10 May 2022 02:32:29 +0300 Message-Id: <20220509233235.995021-22-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace legacy pm_power_off with kernel_can_power_off() helper that is aware about chained power-off handlers. Acked-by: Krzysztof Kozlowski Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- drivers/memory/emif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index 6c2a421b86e3..f305643209f0 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id) dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n"); /* If we have Power OFF ability, use it, else try restarting */ - if (pm_power_off) { + if (kernel_can_power_off()) { kernel_power_off(); } else { WARN(1, "FIXME: NO pm_power_off!!! trying restart\n"); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324931.547339 (Exim 4.92) (envelope-from ) id 1noD0y-0008BC-0i; Mon, 09 May 2022 23:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324931.547339; Mon, 09 May 2022 23:42:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD0x-00089B-CA; Mon, 09 May 2022 23:42:07 +0000 Received: by outflank-mailman (input) for mailman id 324931; Mon, 09 May 2022 23:42:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtT-0007bw-EK for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:23 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e31ecc5-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:22 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id C06B91F4421D X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e31ecc5-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139261; bh=8v4IT57+mYAUaWHgG2SWPXczQ+re0x8/DMpbbFlIS8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=isHqVuBEBya3ws/kEg+oG4SY7cz7IlcFyGnrUpkaZVcGOjpZxRhpzSw44LoLfDOJa WG+MtxGMzWjlq+wBMlpt+KNs2yTOPSWGcQVJuCZGKQnBwwK5ItMuAZjFF+prk5PVOf dbW8U+TBV0uJ/lW7DoEmYBN+dWUUR3JmXsjCQnAoqtd+e/OC4UCPn1dbpDb9NKnPOR gwWBLXpkonDuICKTRolr5FU0p5ifDNqvOUcqTMXX1M5CkKwte65fYr/AmYqOdZnoWi vrDx1AIDfO9+OLCEpYijEbVExDT6hmoW8p3VzsnPd6npIRWlURULaN5k1zAUbNcY2c KQvzdoNzeUO7A== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 20/27] mips: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:28 +0300 Message-Id: <20220509233235.995021-21-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Thomas Bogendoerfer Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/mips/kernel/reset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c index 6288780b779e..e7ce07b3e79b 100644 --- a/arch/mips/kernel/reset.c +++ b/arch/mips/kernel/reset.c @@ -114,8 +114,7 @@ void machine_halt(void) void machine_power_off(void) { - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); #ifdef CONFIG_SMP preempt_disable(); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324944.547362 (Exim 4.92) (envelope-from ) id 1noD17-0001IW-Gu; Mon, 09 May 2022 23:42:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324944.547362; Mon, 09 May 2022 23:42:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD17-0001IC-BU; Mon, 09 May 2022 23:42:17 +0000 Received: by outflank-mailman (input) for mailman id 324944; Mon, 09 May 2022 23:42:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtq-0007bw-1k for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:46 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ba55251-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:45 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 58F021F44236 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ba55251-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139285; bh=eYJEb1cGtJb7wgluz0Ogjp7ayyCB95M+pYV0qM2nZAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gOPDp8rDBp4JqzhH2ZY5PDoY4HXZSGmIYDZVHq2wPZhnNa0ZEY8wHzDjSwJXSOy7G Jn3P0RpsPvdV1ccR1c7FYtekDBuMdIqHI/aiWT1xUalNbFQIYMAsQPzQQO8ErrDaIV kFrKBSZ34QZiDdDEnum/2k5lZYT4smZCS4dGksm9MkJP9yRifE3HhcgGF8QQaRxUHF 8OKJXTbYQqx54XKJP3i2UuHvKC5MKIza6raMDWqSj+SRWUPFaJv5JM9CKz9jAfGOsk BzabK5ee86xDicvVDuzYlfJK/71F5OymwPMUD0bsqwdZmlvXd7xuIOWT8u8Gpbk/9q 9o+MDWgOLAD0w== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 26/27] kernel/reboot: Add devm_register_power_off_handler() Date: Tue, 10 May 2022 02:32:34 +0300 Message-Id: <20220509233235.995021-27-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add devm_register_power_off_handler() helper that registers sys-off handler using power-off mode and with a default priority. Most drivers will want to register power-off handler with a default priority, so this helper will reduce the boilerplate code and make code easier to read and follow. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 4 ++++ kernel/reboot.c | 22 ++++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index f185b64faae0..7c6e1f308f7c 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -141,6 +141,10 @@ int devm_register_sys_off_handler(struct device *dev, int (*callback)(struct sys_off_data *data), void *cb_data); +int devm_register_power_off_handler(struct device *dev, + int (*callback)(struct sys_off_data *data), + void *cb_data); + int register_platform_power_off(void (*power_off)(void)); void unregister_platform_power_off(void (*power_off)(void)); diff --git a/kernel/reboot.c b/kernel/reboot.c index 66033e12e8eb..b790025154ac 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -462,6 +462,28 @@ int devm_register_sys_off_handler(struct device *dev, } EXPORT_SYMBOL_GPL(devm_register_sys_off_handler); +/** + * devm_register_power_off_handler - Register power-off handler + * @dev: Device that registers callback + * @callback: Callback function + * @cb_data: Callback's argument + * + * Registers resource-managed sys-off handler with a default priority + * and using power-off mode. + * + * Returns zero on success, or error code on failure. + */ +int devm_register_power_off_handler(struct device *dev, + int (*callback)(struct sys_off_data *data), + void *cb_data) +{ + return devm_register_sys_off_handler(dev, + SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_DEFAULT, + callback, cb_data); +} +EXPORT_SYMBOL_GPL(devm_register_power_off_handler); + static struct sys_off_handler *platform_power_off_handler; static int platform_power_off_notify(struct sys_off_data *data) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324946.547367 (Exim 4.92) (envelope-from ) id 1noD18-0001NP-5z; Mon, 09 May 2022 23:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324946.547367; Mon, 09 May 2022 23:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD17-0001Ly-Qn; Mon, 09 May 2022 23:42:17 +0000 Received: by outflank-mailman (input) for mailman id 324946; Mon, 09 May 2022 23:42:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCta-0007Pf-Jf for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:30 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9271a10d-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:34:29 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 8E5731F44225 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9271a10d-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139269; bh=EWW47oALn1Py7rO4Rd4kvLdqb3xgTFAdsjGRYU8cAKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdL/zWKlCfq+TjvuU5fks/wPZFNjeji7AfXoYAF4bTiiFsU+GbQDWY5508Nou7Rce WYBcyhfJDaUwS8cKmQ/6xhTDhEn7DgZ437y6IJmFfUHbyhUr2I0pUQT65Nc5H/sWQX 4CQ3Oqfcv1qGbFpHVtnQr4Z3IC7yIc9gWPTXPgaxSTbFDl6YwL8B3phA9z7ZaOppvE f7qvUmb7kMaTIEa9YuMPH0XJi4FR1vaJB4JWphvOXWQxkyMm2uwk+0LT1pd1wpZb/e wcTKgqKz4FgaEUjSUJQHs+uwYiB91IQ/Go1i+BrOc9tM3Caq7CuU3nClpmaBT9NJXU qmHj9eFJTTNIg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 22/27] ACPI: power: Switch to sys-off handler API Date: Tue, 10 May 2022 02:32:30 +0300 Message-Id: <20220509233235.995021-23-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch to sys-off API that replaces legacy pm_power_off callbacks, allowing us to remove global pm_* variables and support chaining of all restart and power-off modes consistently. Signed-off-by: Dmitry Osipenko --- drivers/acpi/sleep.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index c992e57b2c79..c3e3cee27f01 100644 --- a/drivers/acpi/sleep.c +++ b/drivers/acpi/sleep.c @@ -1023,20 +1023,22 @@ static void acpi_sleep_hibernate_setup(void) static inline void acpi_sleep_hibernate_setup(void) {} #endif /* !CONFIG_HIBERNATION */ -static void acpi_power_off_prepare(void) +static int acpi_power_off_prepare(struct sys_off_data *data) { /* Prepare to power off the system */ acpi_sleep_prepare(ACPI_STATE_S5); acpi_disable_all_gpes(); acpi_os_wait_events_complete(); + return NOTIFY_DONE; } -static void acpi_power_off(void) +static int acpi_power_off(struct sys_off_data *data) { /* acpi_sleep_prepare(ACPI_STATE_S5) should have already been called */ pr_debug("%s called\n", __func__); local_irq_disable(); acpi_enter_sleep_state(ACPI_STATE_S5); + return NOTIFY_DONE; } int __init acpi_sleep_init(void) @@ -1055,8 +1057,14 @@ int __init acpi_sleep_init(void) if (acpi_sleep_state_supported(ACPI_STATE_S5)) { sleep_states[ACPI_STATE_S5] = 1; - pm_power_off_prepare = acpi_power_off_prepare; - pm_power_off = acpi_power_off; + + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF_PREPARE, + SYS_OFF_PRIO_FIRMWARE, + acpi_power_off_prepare, NULL); + + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_FIRMWARE, + acpi_power_off, NULL); } else { acpi_no_s5 = true; } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324947.547379 (Exim 4.92) (envelope-from ) id 1noD19-0001qV-EA; Mon, 09 May 2022 23:42:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324947.547379; Mon, 09 May 2022 23:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD19-0001nX-7G; Mon, 09 May 2022 23:42:19 +0000 Received: by outflank-mailman (input) for mailman id 324947; Mon, 09 May 2022 23:42:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtu-0007bw-21 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:50 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e06d0b5-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:49 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 3F0BE1F44239 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e06d0b5-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139289; bh=pGHmFEEjaXj2663JV2ZbLu8gGj/vTytf7TAeEENRqwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j6TdMpmPOCtsPovulFCfAQHz4uF7UDkPzJj/3CmgFYBImRy8M4O8YGcz4W706uWok oiILXGafhBbX7n+gHJn6RXTuMBUQC8tJ+EhQAGsuO/iXIERVRLzkR/44dQES7yRA6/ FtuuqnjfOGSov1+k3mURGR/0OqutTfvEFLoWalI2/ND2VETgVusAQFBX2DfNOA/g7I j0l9XZgvP22CfJfFfA6ZxZIqFh1T34qNRlUcm5bkUIByJGzf9sEM5G0d3YHcPWZak3 l8eX2DCnZSObZ31khwPUziOiMTJxqBOzynYhlqeRkrRRR5tLIOpk/iZhwBgqc0RGs9 Toz7YL4ixFXdA== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 27/27] kernel/reboot: Add devm_register_restart_handler() Date: Tue, 10 May 2022 02:32:35 +0300 Message-Id: <20220509233235.995021-28-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add devm_register_restart_handler() helper that registers sys-off handler using restart mode and with a default priority. Most drivers will want to register restart handler with a default priority, so this helper will reduce the boilerplate code and make code easier to read and follow. Signed-off-by: Dmitry Osipenko --- include/linux/reboot.h | 4 ++++ kernel/reboot.c | 22 ++++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/include/linux/reboot.h b/include/linux/reboot.h index 7c6e1f308f7c..e5d9ef886179 100644 --- a/include/linux/reboot.h +++ b/include/linux/reboot.h @@ -145,6 +145,10 @@ int devm_register_power_off_handler(struct device *dev, int (*callback)(struct sys_off_data *data), void *cb_data); +int devm_register_restart_handler(struct device *dev, + int (*callback)(struct sys_off_data *data), + void *cb_data); + int register_platform_power_off(void (*power_off)(void)); void unregister_platform_power_off(void (*power_off)(void)); diff --git a/kernel/reboot.c b/kernel/reboot.c index b790025154ac..2e78bd754a75 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -484,6 +484,28 @@ int devm_register_power_off_handler(struct device *dev, } EXPORT_SYMBOL_GPL(devm_register_power_off_handler); +/** + * devm_register_restart_handler - Register restart handler + * @dev: Device that registers callback + * @callback: Callback function + * @cb_data: Callback's argument + * + * Registers resource-managed sys-off handler with a default priority + * and using restart mode. + * + * Returns zero on success, or error code on failure. + */ +int devm_register_restart_handler(struct device *dev, + int (*callback)(struct sys_off_data *data), + void *cb_data) +{ + return devm_register_sys_off_handler(dev, + SYS_OFF_MODE_RESTART, + SYS_OFF_PRIO_DEFAULT, + callback, cb_data); +} +EXPORT_SYMBOL_GPL(devm_register_restart_handler); + static struct sys_off_handler *platform_power_off_handler; static int platform_power_off_notify(struct sys_off_data *data) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324948.547386 (Exim 4.92) (envelope-from ) id 1noD1A-0001yF-87; Mon, 09 May 2022 23:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324948.547386; Mon, 09 May 2022 23:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD19-0001xA-Qc; Mon, 09 May 2022 23:42:19 +0000 Received: by outflank-mailman (input) for mailman id 324948; Mon, 09 May 2022 23:42:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCti-0007bw-7q for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:38 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96f58f30-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:37 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 6D3621F4422E X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96f58f30-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139277; bh=G4Vm4i3PSuNHHHXU+oCPvsxvVX3S/U1mmDmC4crDrZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J1T7cZ+8sXSyoqCiUswKzOPFbdK4lnLHa5BLo2lX4nJpcRZIVTEMOuLWjxgIELGye ufjX2Hcm977X8wW9VIKwmYrPBZIT2jZyQSJcd3y3ctDLGwG6vbfYYfBucmxM0e6f69 n4G6fiy/jZG4ulLYGXCzk/NXBNl9yxR3LdmM8xgsi+aeIQil2CBs1nL1/qF9yAqQb6 TwsvXlIqKT1rIXf2rsjmkGmeFCnf76sZCJi24rB3dPW7e5fbOXyqchk0i1LS7WPsiA hJ3XzxAXeaIo84Zou6nGR4l+Tqo+kILO2aR+d7l0+SuSwY5z4aIqVSkb+wJg4dCx15 lDprZUGzZAd+g== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 24/27] reboot: Remove pm_power_off_prepare() Date: Tue, 10 May 2022 02:32:32 +0300 Message-Id: <20220509233235.995021-25-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All pm_power_off_prepare() users were converted to sys-off handler API. Remove the obsolete global callback variable. Signed-off-by: Dmitry Osipenko --- include/linux/pm.h | 1 - kernel/reboot.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/include/linux/pm.h b/include/linux/pm.h index 70ec69d8bafd..871c9c49ec9d 100644 --- a/include/linux/pm.h +++ b/include/linux/pm.h @@ -21,7 +21,6 @@ * Callbacks for platform drivers to implement. */ extern void (*pm_power_off)(void); -extern void (*pm_power_off_prepare)(void); struct device; /* we have a circular dep with device.h */ #ifdef CONFIG_VT_CONSOLE_SLEEP diff --git a/kernel/reboot.c b/kernel/reboot.c index e74103f2a801..66033e12e8eb 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -63,13 +63,6 @@ struct sys_off_handler { */ void __weak (*pm_power_off)(void); -/* - * If set, this is used for preparing the system to power off. - */ - -void (*pm_power_off_prepare)(void); -EXPORT_SYMBOL_GPL(pm_power_off_prepare); - /** * emergency_restart - reboot the system * @@ -524,14 +517,6 @@ void unregister_platform_power_off(void (*power_off)(void)) } EXPORT_SYMBOL_GPL(unregister_platform_power_off); -static int legacy_pm_power_off_prepare(struct sys_off_data *data) -{ - if (pm_power_off_prepare) - pm_power_off_prepare(); - - return NOTIFY_DONE; -} - static int legacy_pm_power_off(struct sys_off_data *data) { if (pm_power_off) @@ -549,10 +534,6 @@ static int legacy_pm_power_off(struct sys_off_data *data) */ static int __init legacy_pm_init(void) { - register_sys_off_handler(SYS_OFF_MODE_POWER_OFF_PREPARE, - SYS_OFF_PRIO_DEFAULT, - legacy_pm_power_off_prepare, NULL); - register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, legacy_pm_power_off, NULL); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324951.547392 (Exim 4.92) (envelope-from ) id 1noD1B-0002EV-5x; Mon, 09 May 2022 23:42:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324951.547392; Mon, 09 May 2022 23:42:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD1A-0002CJ-Ru; Mon, 09 May 2022 23:42:20 +0000 Received: by outflank-mailman (input) for mailman id 324951; Mon, 09 May 2022 23:42:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtG-0007bw-Pf for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:10 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 869aa623-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:10 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 0C7481F441F6 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 869aa623-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139249; bh=Py3C74Fq8ylx1e5iD4JoOoDZdx6Zp6SNSGp+S5YdLlo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lNksTBbv27hDu8EEkAEQj5GgsoEmm7+0+sHXFCTDwyFiMFRucGT2C4NwrUODWnqgr ker012zTH+ctY/bp/DvwLFYX0BnRgZndrr/ZRjink8umONJEtYCTtZ06hu9J7zZfp+ tPWTki3zd/xPgsYlgiwfh4bnzqB4jl+L8lmX11KCP90ezvUibrmiKuFylcYpZC9yxM 3zLDLP7la9iYLOj7OJwr2On2lvE0/j+wGY2Uu+4im/JyIWDAWttXWW119bvaCzZOTH P4wdljiq4jUyZlUuMy51pkx0/V6VzS5/w46i2URtlgrHZ77oWiTkKDRAuW0/bxBj0C uupvU5EOk7DKg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 17/27] sh: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:25 +0300 Message-Id: <20220509233235.995021-18-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/sh/kernel/reboot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/sh/kernel/reboot.c b/arch/sh/kernel/reboot.c index 5c33f036418b..e8eeedc9b182 100644 --- a/arch/sh/kernel/reboot.c +++ b/arch/sh/kernel/reboot.c @@ -46,8 +46,7 @@ static void native_machine_shutdown(void) static void native_machine_power_off(void) { - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); } static void native_machine_halt(void) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324952.547417 (Exim 4.92) (envelope-from ) id 1noD1H-0003ju-Og; Mon, 09 May 2022 23:42:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324952.547417; Mon, 09 May 2022 23:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD1H-0003jA-Hb; Mon, 09 May 2022 23:42:27 +0000 Received: by outflank-mailman (input) for mailman id 324952; Mon, 09 May 2022 23:42:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsl-0007bw-Bl for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:39 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73ebdbdc-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:33:38 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id A88FB1F441C3 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73ebdbdc-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139218; bh=/bbH+Hh9V2YndQhc7/67mfw0LR0d7fqSt60jiFNw1kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XE7jAqlilaRm1qFyVJmdFiOcQE2mx2GpAzjp9x+hQpDU+THCNRvBbiF6FVpK3+5yS 82w4D4eeCNNvv6nQPxE5UwDkhkPAxFHquaCbm89nOaewJDUdVYjX5Yphlz72I9m2oP aqrsHnyfl/saba93bLh4VJUO8giHF8bPUVfUyZMjgLAS+bzTpXF7ychpLmP1Vt+aIl Zu/FmOq55jBKM4kYdGNSVn7a+x3olBfZR181fkRaNnBCZ3S1S989WuVERiM8OC6pcj oxTa+Q4R/ks+7k0J6Yl56HJvyuX8TCYUq+eaffXZQvgEDu5aAWj74y2TJU/dyn1+Qq RnfUlcGWtezjA== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 09/27] ARM: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:17 +0300 Message-Id: <20220509233235.995021-10-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Reviewed-by: Russell King (Oracle) Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/arm/kernel/reboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c index 3044fcb8d073..2cb943422554 100644 --- a/arch/arm/kernel/reboot.c +++ b/arch/arm/kernel/reboot.c @@ -116,9 +116,7 @@ void machine_power_off(void) { local_irq_disable(); smp_send_stop(); - - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); } /* -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324957.547427 (Exim 4.92) (envelope-from ) id 1noD1K-0004Jc-9a; Mon, 09 May 2022 23:42:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324957.547427; Mon, 09 May 2022 23:42:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD1K-0004Iz-48; Mon, 09 May 2022 23:42:30 +0000 Received: by outflank-mailman (input) for mailman id 324957; Mon, 09 May 2022 23:42:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCtE-0007bw-P3 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:08 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 81f7efab-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:02 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 45B061F441E2 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81f7efab-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139242; bh=BNiJLGjWIzGOPAZM2z9DxroGBpHA3jtv2OqTTX3KfaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MmRFtkxF0t/0s1mqVHp01wCQk0mHdGbFnJOLd8QQOIiCDNKQBR758oQ+y5MhaYpyf Vy0KMBI+NogV4y1/lztnyP+eWOumRqyH/7Ud9zokUK3YMWpbn23Wfky/48H0Ts7zw/ LCGnhPuXyGu+uCO0m//ObCybeeRvhsNMjOPEqXyRR4OPYBnLFRbLOegI5pqM7s690n 5ToJOQerGy3mdVzfhdHyV6ukfnLe4tSg+adT21ugi4lX7Uump+8xi7Rl2MDO9ayAQi 9kS2NkEPO6JPciRSBzlS4TWGKPWFABJNEIrYzWa+p9T3AxEnGi+vCuMmKT1EaAokkK XUhEqjDRDlmfg== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 15/27] powerpc: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:23 +0300 Message-Id: <20220509233235.995021-16-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Michael Ellerman Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/powerpc/kernel/setup-common.c | 4 +--- arch/powerpc/xmon/xmon.c | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 518ae5aa9410..1b586577e75b 100644 --- a/arch/powerpc/kernel/setup-common.c +++ b/arch/powerpc/kernel/setup-common.c @@ -161,9 +161,7 @@ void machine_restart(char *cmd) void machine_power_off(void) { machine_shutdown(); - if (pm_power_off) - pm_power_off(); - + do_kernel_power_off(); smp_send_stop(); machine_hang(); } diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index b423812e94e0..0300bdfa20d5 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1243,8 +1243,7 @@ static void bootcmds(void) } else if (cmd == 'h') { ppc_md.halt(); } else if (cmd == 'p') { - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324958.547432 (Exim 4.92) (envelope-from ) id 1noD1L-0004OL-66; Mon, 09 May 2022 23:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324958.547432; Mon, 09 May 2022 23:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD1K-0004Mh-Lq; Mon, 09 May 2022 23:42:30 +0000 Received: by outflank-mailman (input) for mailman id 324958; Mon, 09 May 2022 23:42:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCsx-0007Pf-82 for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:33:51 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7afd11ba-cff0-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 01:33:50 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 6D3491F441D2 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7afd11ba-cff0-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139230; bh=qKcEaaqMIJ4u5Ci+7b2uBSMlhy7r7OU77hT8ObUoKho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YmHmlZT4yyO6cWM3Bz5JftChowVg/M2fXvwFMhRS4e+Wuq4sD1q3OkohJJlDsPPL2 j5kr4/JUymIkLlQMnmeGWx/oL/gzhnBQuKsL8jB4iuv6hwrbHMcsw3LuhebKodzWFk rmnjBC0+wPIYX6c0ORsexWKd3U+jCsIpfbjSiclXE3M9LeCXBn+ESKjT58ePCxxTWV Zl82L0X/fkIGQBuqIcNG6Jl9nhzo3I5HfMrX4c7iNnVoa+PkQdE4O3elLjDQsPpn1Q MEclW34sJqJsqXbvF7sjn3ufyEIcH1MhP4YeSXnfNNyguaVxY5pj3bnr/70Q51dzF8 7fEmC00bkHk/g== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 12/27] arm64: Use do_kernel_power_off() Date: Tue, 10 May 2022 02:32:20 +0300 Message-Id: <20220509233235.995021-13-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Kernel now supports chained power-off handlers. Use do_kernel_power_off() that invokes chained power-off handlers. It also invokes legacy pm_power_off() for now, which will be removed once all drivers will be converted to the new sys-off API. Acked-by: Catalin Marinas Reviewed-by: Michał Mirosław Signed-off-by: Dmitry Osipenko --- arch/arm64/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 142a51256669..92bcc1768f0b 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -111,8 +111,7 @@ void machine_power_off(void) { local_irq_disable(); smp_send_stop(); - if (pm_power_off) - pm_power_off(); + do_kernel_power_off(); } /* -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Mon May 09 23:42:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 09 May 2022 23:42:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.324960.547439 (Exim 4.92) (envelope-from ) id 1noD1M-0004Un-32; Mon, 09 May 2022 23:42:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 324960.547439; Mon, 09 May 2022 23:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noD1L-0004Ru-DQ; Mon, 09 May 2022 23:42:31 +0000 Received: by outflank-mailman (input) for mailman id 324960; Mon, 09 May 2022 23:42:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noCte-0007bw-Bo for xen-devel@lists.xenproject.org; Mon, 09 May 2022 23:34:34 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 949daf10-cff0-11ec-a406-831a346695d4; Tue, 10 May 2022 01:34:33 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 7BE1A1F4422B X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 949daf10-cff0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652139273; bh=XtOxeNpEZBzsEZoOwk1w0xc4u4++IeNM8JHEy/MILRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DGGv7NB7YFjR/XyFr6bky/W+z/hPJaeKzOrZp6S3NkKmsspZefTK98eiyR/2PprHF SZXwZ9k9uPPdX2japixfTOG/AkmkZ3D+LB7Udgq8t/o13fV+sK+wTnOE/L4HgXdA53 nvSDO9U/xKP8LpKY1VJetO4hoBC6fW0zfXiuOgG/3L6dFRe9KpmJts3DTUhBhSu7D4 /z4YOyQOb4V/fbU6Imyw0C5sByK4+txkAyVBFrLWSJ5ovT1rrtNZtFjsKgKayHBUAG dYw8SdmUATaBmvB/AvJb06MJ7Bn9SOe65TF2LOFEbL8F4bwXe+OpgmwAQ88g/rheVt rGHHW0DMlZ6Ag== From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v8 23/27] regulator: pfuze100: Use devm_register_sys_off_handler() Date: Tue, 10 May 2022 02:32:31 +0300 Message-Id: <20220509233235.995021-24-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_register_sys_off_handler() that replaces global pm_power_off_prepare variable and allows to register multiple power-off handlers. Acked-by: Mark Brown Signed-off-by: Dmitry Osipenko --- drivers/regulator/pfuze100-regulator.c | 42 +++++++++++--------------- 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c index d60d7d1b7fa2..0322f6b1fb60 100644 --- a/drivers/regulator/pfuze100-regulator.c +++ b/drivers/regulator/pfuze100-regulator.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -569,10 +570,10 @@ static inline struct device_node *match_of_node(int index) return pfuze_matches[index].of_node; } -static struct pfuze_chip *syspm_pfuze_chip; - -static void pfuze_power_off_prepare(void) +static int pfuze_power_off_prepare(struct sys_off_data *data) { + struct pfuze_chip *syspm_pfuze_chip = data->cb_data; + dev_info(syspm_pfuze_chip->dev, "Configure standby mode for power off"); /* Switch from default mode: APS/APS to APS/Off */ @@ -607,28 +608,30 @@ static void pfuze_power_off_prepare(void) regmap_update_bits(syspm_pfuze_chip->regmap, PFUZE100_VGEN6VOL, PFUZE100_VGENxLPWR | PFUZE100_VGENxSTBY, PFUZE100_VGENxSTBY); + + return NOTIFY_DONE; } static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip) { + int err; + if (pfuze_chip->chip_id != PFUZE100) { dev_warn(pfuze_chip->dev, "Requested pm_power_off_prepare handler for not supported chip\n"); return -ENODEV; } - if (pm_power_off_prepare) { - dev_warn(pfuze_chip->dev, "pm_power_off_prepare is already registered.\n"); - return -EBUSY; + err = devm_register_sys_off_handler(pfuze_chip->dev, + SYS_OFF_MODE_POWER_OFF_PREPARE, + SYS_OFF_PRIO_DEFAULT, + pfuze_power_off_prepare, + pfuze_chip); + if (err) { + dev_err(pfuze_chip->dev, "failed to register sys-off handler: %d\n", + err); + return err; } - if (syspm_pfuze_chip) { - dev_warn(pfuze_chip->dev, "syspm_pfuze_chip is already set.\n"); - return -EBUSY; - } - - syspm_pfuze_chip = pfuze_chip; - pm_power_off_prepare = pfuze_power_off_prepare; - return 0; } @@ -837,23 +840,12 @@ static int pfuze100_regulator_probe(struct i2c_client *client, return 0; } -static int pfuze100_regulator_remove(struct i2c_client *client) -{ - if (syspm_pfuze_chip) { - syspm_pfuze_chip = NULL; - pm_power_off_prepare = NULL; - } - - return 0; -} - static struct i2c_driver pfuze_driver = { .driver = { .name = "pfuze100-regulator", .of_match_table = pfuze_dt_ids, }, .probe = pfuze100_regulator_probe, - .remove = pfuze100_regulator_remove, }; module_i2c_driver(pfuze_driver); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 00:09:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 00:09:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325046.547461 (Exim 4.92) (envelope-from ) id 1noDRX-0002ir-Bs; Tue, 10 May 2022 00:09:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325046.547461; Tue, 10 May 2022 00:09:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noDRX-0002ik-7H; Tue, 10 May 2022 00:09:35 +0000 Received: by outflank-mailman (input) for mailman id 325046; Tue, 10 May 2022 00:09:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noDRV-0002ia-G5; Tue, 10 May 2022 00:09:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noDRV-0001PJ-Dr; Tue, 10 May 2022 00:09:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noDRV-0003CU-13; Tue, 10 May 2022 00:09:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noDRV-0007rx-0Z; Tue, 10 May 2022 00:09:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tIkHt3mmVQm7mwhkrnHT3GgsvjhoTxdZWbhlx8z40CQ=; b=IujQrdA5ByQDPLnQ2O4PhLnNDy U3x5uuxdF0NhDkatb6sBxGc8VSdftzl10QGY4APgh/9GQK+0veCNHx86QAsnx59BMwX/fWWIDuyM7 /fnnmSkerHRPbXXWeSQwqI1nurXBaXg8KFEp4mG+vSY9YXiURzBXjwdnndY200I/6mWY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170282: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 00:09:33 +0000 flight 170282 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170282/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 902 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 01:06:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 01:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325054.547471 (Exim 4.92) (envelope-from ) id 1noEJx-0007wS-IM; Tue, 10 May 2022 01:05:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325054.547471; Tue, 10 May 2022 01:05:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noEJx-0007wL-FZ; Tue, 10 May 2022 01:05:49 +0000 Received: by outflank-mailman (input) for mailman id 325054; Tue, 10 May 2022 01:05:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noEJw-0007wB-Tm; Tue, 10 May 2022 01:05:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noEJw-0000Hs-S0; Tue, 10 May 2022 01:05:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noEJw-0005YN-GO; Tue, 10 May 2022 01:05:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noEJw-0002AZ-Fw; Tue, 10 May 2022 01:05:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3x4MEyyrBmJWos3RaBlBRevs9p0tdpb0Aw1O3ZQIlWU=; b=HgxaaA1jlGUWuywg30u/HKPW4e vnXpRsqvR+nCr6Wt+4ROaOnHZmlPogf6m5vxZt5XJi1YabpO/CZ8EtS8zrc0xlqIG0Zdjz7fg/QeF p84gWvkkcesXuhozLj9PODSJmDlH6O5QrW+rUPUcuslJvWnNTxaAzmgbc5wQRS5T1tmI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170283: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 01:05:48 +0000 flight 170283 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170283/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 69 days 903 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 02:04:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:04:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325062.547483 (Exim 4.92) (envelope-from ) id 1noFEI-00070B-WD; Tue, 10 May 2022 02:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325062.547483; Tue, 10 May 2022 02:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFEI-000704-R8; Tue, 10 May 2022 02:04:02 +0000 Received: by outflank-mailman (input) for mailman id 325062; Tue, 10 May 2022 02:04:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFEH-0006zy-QJ for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:04:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 748373f8-d005-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 04:04:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DF3561635; Tue, 10 May 2022 02:03:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF8F2C385C5; Tue, 10 May 2022 02:03:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 748373f8-d005-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652148238; bh=wv5RBevj0czTyXQWaA+qsNaS23nZylpb7fsKMvVga/0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=S5MMBHTA7Refuh8SG8aHtXOVwFgHOgUagvpKdcG4Aip3Uk20FdITZKY086uc8Dv/9 pItKXopdJZRSdb1CM2C7lJ1k1LhlHBjibeywYI4Fcdg5TahwjmC6QqmebHrpZZZGmt BHiKZBKiCWccPPzxVYhqNvAbmKQIyDmFnovRisR2MayQGOMTZ/rhXRlIrI+TvcnQhC OgtTcuOmmZXV/EGbhd9n/spP1hNf7i002uHdmF76ZW1w162ligueU2B/blCIi/fHeG lOmovNNy3zo25VE50GqIAvE/HvQxqDsk4tk0440KCBXuifkLfBJ474WkBdHByNfCvn O+yOhGzXU8rxg== Date: Mon, 9 May 2022 19:03:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand.Marquis@arm.com cc: julien@xen.org, "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 In-Reply-To: <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 4 May 2022, Julien Grall wrote: > > Do I understand right that it is ok for you if I push one patch mentioning > > all the commits done in Linux corresponding to the changes (instead of one > > patch per commit) ? > > For this case yes. I managed to do a review of the patch by doing a diff of the relevant portion of Xen cpufeature.c with Linux cpufeature.c (from commit b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux sysregs.h (diff -E -b -u). Everything checks out. In my opinion, this patch should be split in 2 patches: the changes to cpufeature.c and sysregs.c that come from the Linux sources; and the updates to cpufeature.h that do not. If you do that you can add my reviewed-by to the first patch with the changes from Linux. The list of individual commit IDs would be nice, but thanksfully the two source files are still "diffable" so in my opinion are not required. I have a couple of comments on the changes to cpufeature.h (the ones not from Linux) which I'll reply directly to the patch. From xen-devel-bounces@lists.xenproject.org Tue May 10 02:04:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325068.547493 (Exim 4.92) (envelope-from ) id 1noFF3-0007Wp-7x; Tue, 10 May 2022 02:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325068.547493; Tue, 10 May 2022 02:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFF3-0007Wi-4l; Tue, 10 May 2022 02:04:49 +0000 Received: by outflank-mailman (input) for mailman id 325068; Tue, 10 May 2022 02:04:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFF1-0007Ll-D8 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:04:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ffe093c-d005-11ec-a406-831a346695d4; Tue, 10 May 2022 04:04:46 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91F8C61634; Tue, 10 May 2022 02:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF8F4C385C2; Tue, 10 May 2022 02:04:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ffe093c-d005-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652148284; bh=Rc1IqJm7w0mILySRKMWGIu8iqsYw8vMfMJYJLTfkINE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=RD6JFLqnY8Ozkwa8FzMUZeJ/CirDiiTrMUO2ov2GeNFq14koIJScJdHcgyxvtvlvL vvEvJxUj/GtUg6KEXUtUrEfM3UO+bQhU3zhtbDWQsSj7uqrGEhWX2Rym1WVeIWh8wm UxKuE0jDyTLp/Cm8BF3v5GcTYxGicog3e9I4//fWst5DsSJGHEI2M7ETrntFMtal/t U1DcOlhfuNUxlmE2bOfFOoq+DzKIqT+Z+LB4AxK3na4n3Ox3JH8PjL0yKWGV9Sligt vrFEHIE5ol/tcV8foVMXvkcuK04xe2tl7x7oCBf6O2SnbwKdaz6kezssMFen1NfTgF p6EgSvBYhn2ng== Date: Mon, 9 May 2022 19:04:43 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 In-Reply-To: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 3 May 2022, Bertrand Marquis wrote: > Sync arm64 sysreg bit shift definitions with status of Linux kernel as > of 5.18-rc3 version (linux commit b2d229d4ddb1). > Sync ID registers sanitization with the status of Linux 5.18-rc3 and add > sanitization of ISAR2 registers. > Complete AA64ISAR2 and AA64MMFR1 with more fields. > While there add a comment for MMFR bitfields as for other registers in > the cpuinfo structure definition. > > Signed-off-by: Bertrand Marquis > --- > xen/arch/arm/arm64/cpufeature.c | 18 +++++- > xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- Linux cpufeature.c has a couple more structures compared to Xen. So I would add the word "existing" in the commit message: "Sync existing ID registers sanitization with the status of Linux 5.18-rc3 and add sanitization of ISAR2 registers." A couple of comments about the cpufeature.h changes below. > xen/arch/arm/include/asm/cpufeature.h | 14 ++++- > 3 files changed, 91 insertions(+), 17 deletions(-) > > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > index 6e5d30dc7b..d9039d37b2 100644 > --- a/xen/arch/arm/arm64/cpufeature.c > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { > ARM64_FTR_END, > }; > > +static const struct arm64_ftr_bits ftr_id_aa64isar2[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_CLEARBHB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_GPA3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_RPRES_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV3_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV2_SHIFT, 4, 0), > @@ -158,8 +168,8 @@ static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { > S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_FP_SHIFT, 4, ID_AA64PFR0_FP_NI), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL3_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL2_SHIFT, 4, 0), > - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_EL1_64BIT_ONLY), > - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_EL0_64BIT_ONLY), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), > ARM64_FTR_END, > }; > > @@ -197,7 +207,7 @@ static const struct arm64_ftr_bits ftr_id_aa64zfr0[] = { > }; > > static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { > - ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_FGT_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EXS_SHIFT, 4, 0), > /* > @@ -243,6 +253,7 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { > }; > > static const struct arm64_ftr_bits ftr_id_aa64mmfr1[] = { > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_AFP_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_ETS_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_TWED_SHIFT, 4, 0), > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_XNX_SHIFT, 4, 0), > @@ -588,6 +599,7 @@ void update_system_features(const struct cpuinfo_arm *new) > > SANITIZE_ID_REG(isa64, 0, aa64isar0); > SANITIZE_ID_REG(isa64, 1, aa64isar1); > + SANITIZE_ID_REG(isa64, 2, aa64isar2); > > SANITIZE_ID_REG(zfr64, 0, aa64zfr0); > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index eac08ed33f..54670084c3 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -144,6 +144,30 @@ > > /* id_aa64isar2 */ > #define ID_AA64ISAR2_CLEARBHB_SHIFT 28 > +#define ID_AA64ISAR2_APA3_SHIFT 12 > +#define ID_AA64ISAR2_GPA3_SHIFT 8 > +#define ID_AA64ISAR2_RPRES_SHIFT 4 > +#define ID_AA64ISAR2_WFXT_SHIFT 0 > + > +#define ID_AA64ISAR2_RPRES_8BIT 0x0 > +#define ID_AA64ISAR2_RPRES_12BIT 0x1 > +/* > + * Value 0x1 has been removed from the architecture, and is > + * reserved, but has not yet been removed from the ARM ARM > + * as of ARM DDI 0487G.b. > + */ > +#define ID_AA64ISAR2_WFXT_NI 0x0 > +#define ID_AA64ISAR2_WFXT_SUPPORTED 0x2 > + > +#define ID_AA64ISAR2_APA3_NI 0x0 > +#define ID_AA64ISAR2_APA3_ARCHITECTED 0x1 > +#define ID_AA64ISAR2_APA3_ARCH_EPAC 0x2 > +#define ID_AA64ISAR2_APA3_ARCH_EPAC2 0x3 > +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC 0x4 > +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC_CMB 0x5 > + > +#define ID_AA64ISAR2_GPA3_NI 0x0 > +#define ID_AA64ISAR2_GPA3_ARCHITECTED 0x1 > > /* id_aa64pfr0 */ > #define ID_AA64PFR0_CSV3_SHIFT 60 > @@ -165,14 +189,13 @@ > #define ID_AA64PFR0_AMU 0x1 > #define ID_AA64PFR0_SVE 0x1 > #define ID_AA64PFR0_RAS_V1 0x1 > +#define ID_AA64PFR0_RAS_V1P1 0x2 > #define ID_AA64PFR0_FP_NI 0xf > #define ID_AA64PFR0_FP_SUPPORTED 0x0 > #define ID_AA64PFR0_ASIMD_NI 0xf > #define ID_AA64PFR0_ASIMD_SUPPORTED 0x0 > -#define ID_AA64PFR0_EL1_64BIT_ONLY 0x1 > -#define ID_AA64PFR0_EL1_32BIT_64BIT 0x2 > -#define ID_AA64PFR0_EL0_64BIT_ONLY 0x1 > -#define ID_AA64PFR0_EL0_32BIT_64BIT 0x2 > +#define ID_AA64PFR0_ELx_64BIT_ONLY 0x1 > +#define ID_AA64PFR0_ELx_32BIT_64BIT 0x2 > > /* id_aa64pfr1 */ > #define ID_AA64PFR1_MPAMFRAC_SHIFT 16 > @@ -189,6 +212,7 @@ > #define ID_AA64PFR1_MTE_NI 0x0 > #define ID_AA64PFR1_MTE_EL0 0x1 > #define ID_AA64PFR1_MTE 0x2 > +#define ID_AA64PFR1_MTE_ASYMM 0x3 > > /* id_aa64zfr0 */ > #define ID_AA64ZFR0_F64MM_SHIFT 56 > @@ -228,17 +252,37 @@ > #define ID_AA64MMFR0_ASID_SHIFT 4 > #define ID_AA64MMFR0_PARANGE_SHIFT 0 > > -#define ID_AA64MMFR0_TGRAN4_NI 0xf > -#define ID_AA64MMFR0_TGRAN4_SUPPORTED 0x0 > -#define ID_AA64MMFR0_TGRAN64_NI 0xf > -#define ID_AA64MMFR0_TGRAN64_SUPPORTED 0x0 > -#define ID_AA64MMFR0_TGRAN16_NI 0x0 > -#define ID_AA64MMFR0_TGRAN16_SUPPORTED 0x1 > +#define ID_AA64MMFR0_ASID_8 0x0 > +#define ID_AA64MMFR0_ASID_16 0x2 > + > +#define ID_AA64MMFR0_TGRAN4_NI 0xf > +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0 > +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MAX 0x7 > +#define ID_AA64MMFR0_TGRAN64_NI 0xf > +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0 > +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MAX 0x7 > +#define ID_AA64MMFR0_TGRAN16_NI 0x0 > +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MIN 0x1 > +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MAX 0xf > + > +#define ID_AA64MMFR0_PARANGE_32 0x0 > +#define ID_AA64MMFR0_PARANGE_36 0x1 > +#define ID_AA64MMFR0_PARANGE_40 0x2 > +#define ID_AA64MMFR0_PARANGE_42 0x3 > +#define ID_AA64MMFR0_PARANGE_44 0x4 > #define ID_AA64MMFR0_PARANGE_48 0x5 > #define ID_AA64MMFR0_PARANGE_52 0x6 > > +#define ARM64_MIN_PARANGE_BITS 32 > + > +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_DEFAULT 0x0 > +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_NONE 0x1 > +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MIN 0x2 > +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MAX 0x7 > + > /* id_aa64mmfr1 */ > #define ID_AA64MMFR1_ECBHB_SHIFT 60 > +#define ID_AA64MMFR1_AFP_SHIFT 44 > #define ID_AA64MMFR1_ETS_SHIFT 36 > #define ID_AA64MMFR1_TWED_SHIFT 32 > #define ID_AA64MMFR1_XNX_SHIFT 28 > @@ -271,6 +315,9 @@ > #define ID_AA64MMFR2_CNP_SHIFT 0 > > /* id_aa64dfr0 */ > +#define ID_AA64DFR0_MTPMU_SHIFT 48 > +#define ID_AA64DFR0_TRBE_SHIFT 44 > +#define ID_AA64DFR0_TRACE_FILT_SHIFT 40 > #define ID_AA64DFR0_DOUBLELOCK_SHIFT 36 > #define ID_AA64DFR0_PMSVER_SHIFT 32 > #define ID_AA64DFR0_CTX_CMPS_SHIFT 28 > @@ -284,11 +331,18 @@ > #define ID_AA64DFR0_PMUVER_8_1 0x4 > #define ID_AA64DFR0_PMUVER_8_4 0x5 > #define ID_AA64DFR0_PMUVER_8_5 0x6 > +#define ID_AA64DFR0_PMUVER_8_7 0x7 > #define ID_AA64DFR0_PMUVER_IMP_DEF 0xf > > +#define ID_AA64DFR0_PMSVER_8_2 0x1 > +#define ID_AA64DFR0_PMSVER_8_3 0x2 > + > #define ID_DFR0_PERFMON_SHIFT 24 > > -#define ID_DFR0_PERFMON_8_1 0x4 > +#define ID_DFR0_PERFMON_8_0 0x3 > +#define ID_DFR0_PERFMON_8_1 0x4 > +#define ID_DFR0_PERFMON_8_4 0x5 > +#define ID_DFR0_PERFMON_8_5 0x6 > > #define ID_ISAR4_SWP_FRAC_SHIFT 28 > #define ID_ISAR4_PSR_M_SHIFT 24 > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index f7368766c0..4719de47f3 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -230,6 +230,7 @@ struct cpuinfo_arm { > union { > register_t bits[3]; > struct { > + /* MMFR0 */ > unsigned long pa_range:4; > unsigned long asid_bits:4; > unsigned long bigend:4; > @@ -240,16 +241,21 @@ struct cpuinfo_arm { > unsigned long tgranule_4K:4; > unsigned long __res0:32; > > + /* MMFR1 */ > unsigned long hafdbs:4; > unsigned long vmid_bits:4; > unsigned long vh:4; > unsigned long hpds:4; > unsigned long lo:4; > unsigned long pan:4; > - unsigned long __res1:8; > - unsigned long __res2:28; > + unsigned long specsei:4; > + unsigned long xnx:4; > + unsigned long twed:4; > + unsigned long ets:4; > + unsigned long __res1:20; We might as well complete the fields by also adding hcx, afp, ntlbpa, tidcp1, cmow. What do you think? > unsigned long ecbhb:4; > > + /* MMFR2 */ > unsigned long __res3:64; > }; > } mm64; > @@ -293,7 +299,9 @@ struct cpuinfo_arm { > unsigned long __res2:8; > > /* ISAR2 */ > - unsigned long __res3:28; > + unsigned long wfxt:4; > + unsigned long rpres:4; > + unsigned long __res3:20; Also here we can add gpa3, apa3, mops, bc, and pac_frac? > unsigned long clearbhb:4; > > unsigned long __res4:32; From xen-devel-bounces@lists.xenproject.org Tue May 10 02:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325075.547505 (Exim 4.92) (envelope-from ) id 1noFNE-0000s7-8V; Tue, 10 May 2022 02:13:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325075.547505; Tue, 10 May 2022 02:13:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFNE-0000s0-47; Tue, 10 May 2022 02:13:16 +0000 Received: by outflank-mailman (input) for mailman id 325075; Tue, 10 May 2022 02:13:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFNC-0000ro-W2; Tue, 10 May 2022 02:13:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFNC-0001qU-Sr; Tue, 10 May 2022 02:13:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFNC-0002Fm-9p; Tue, 10 May 2022 02:13:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noFNC-0000SW-9Q; Tue, 10 May 2022 02:13:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EDYKKSPyD/59shCqFOJvllPO+XCsj+kR2e4l1Iiyx7k=; b=3gUol2bsrzPE1/8I9pkjWNLv5s /lfXslwYAODIwcfOrWXcM9XOCEbnT9WfbRCLuIQKDzJq/7VQytSfW9iz09bl4Usq04exY1aguO8dV kuA45De3uHA4CQ5aGgeh5QvZFZ1MdxVPMfpb4CpBXI85LSgFdFaqNC7Rlao1er/8sfpc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170284: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 02:13:14 +0000 flight 170284 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 904 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 02:25:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325083.547515 (Exim 4.92) (envelope-from ) id 1noFYw-0002aG-BU; Tue, 10 May 2022 02:25:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325083.547515; Tue, 10 May 2022 02:25:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFYw-0002a9-8R; Tue, 10 May 2022 02:25:22 +0000 Received: by outflank-mailman (input) for mailman id 325083; Tue, 10 May 2022 02:25:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFYv-0002Zz-Ae; Tue, 10 May 2022 02:25:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFYv-000222-3z; Tue, 10 May 2022 02:25:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFYu-0002jk-P8; Tue, 10 May 2022 02:25:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noFYu-0006eI-Oe; Tue, 10 May 2022 02:25:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MnLcF1DcZjmOGzF9C+bLsqI6ryoKBaVln4JMVvnlKY4=; b=Q2z/vTebkwmiKW3mTV9fXtlMNb qZkCRyK5NwP4RkoZ39jiSU4Mz5YZwkVoI5pU5G5GJHA7jngz4sIay8CFykCaNwG8TCyeMfd4tGGuM 6rb8Awzn/Ahq7WLwM0tz+E8tKw9shUmEdeI+XcDsJAr/YLFZIqKwxPi/3GooHwpF1c8s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170275: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7e314198157bf38ae7fdd5a000b8795db015d582 X-Osstest-Versions-That: qemuu=554623226f800acf48a2ed568900c1c968ec9a8b From: osstest service owner Date: Tue, 10 May 2022 02:25:20 +0000 flight 170275 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170275/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170256 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170256 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170256 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170256 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170256 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170256 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170256 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170256 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 7e314198157bf38ae7fdd5a000b8795db015d582 baseline version: qemuu 554623226f800acf48a2ed568900c1c968ec9a8b Last test of basis 170256 2022-05-09 01:39:31 Z 1 days Testing same since 170275 2022-05-09 17:08:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Brad Smith Gautam Agrawal Richard Henderson Thomas Huth Yonggang Luo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 554623226f..7e31419815 7e314198157bf38ae7fdd5a000b8795db015d582 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 10 02:27:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:27:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325091.547526 (Exim 4.92) (envelope-from ) id 1noFbS-0003B2-QS; Tue, 10 May 2022 02:27:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325091.547526; Tue, 10 May 2022 02:27:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbS-0003Av-NZ; Tue, 10 May 2022 02:27:58 +0000 Received: by outflank-mailman (input) for mailman id 325091; Tue, 10 May 2022 02:27:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbR-0003Ap-Jk for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:27:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cc9b77b2-d008-11ec-a406-831a346695d4; Tue, 10 May 2022 04:27:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDE2312FC; Mon, 9 May 2022 19:27:54 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1F9223F66F; Mon, 9 May 2022 19:27:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc9b77b2-d008-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH V4 0/6] populate/unpopulate memory when domain on static Date: Tue, 10 May 2022 10:27:27 +0800 Message-Id: <20220510022733.2422581-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so they shall never go back to heap allocator. This patch serie intends to fix this issue, by adding pages on the new list resv_page_list after having taken them off the "normal" list, when unpopulating memory, and retrieving pages from resv page list(resv_page_list) when populating memory. --- v4 changes: - commit message refinement - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" - change name from "is_domain_static()" to "is_domain_using_staticmem" - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. - move #ifndef is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - change name from "is_domain_on_static_allocation" to "is_domain_static()" - put reserved pages on resv_page_list after having taken them off the "normal" list - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 - fix coding style Penny Zheng (6): xen: do not free reserved memory into heap xen: do not merge reserved pages in free_heap_pages() xen: add field "flags" to cover all internal CDF_XXX xen/arm: introduce CDF_staticmem xen/arm: unpopulate memory when domain is static xen: retrieve reserved pages on populate_physmap xen/arch/arm/domain.c | 2 -- xen/arch/arm/domain_build.c | 5 ++- xen/arch/arm/include/asm/domain.h | 5 +-- xen/arch/arm/include/asm/mm.h | 12 +++++++ xen/common/domain.c | 7 ++++ xen/common/memory.c | 23 +++++++++++++ xen/common/page_alloc.c | 54 ++++++++++++++++++++++++++++--- xen/include/xen/domain.h | 6 ++++ xen/include/xen/mm.h | 3 +- xen/include/xen/sched.h | 6 ++++ 10 files changed, 112 insertions(+), 11 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:28:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:28:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325092.547538 (Exim 4.92) (envelope-from ) id 1noFbW-0003SS-8K; Tue, 10 May 2022 02:28:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325092.547538; Tue, 10 May 2022 02:28:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbW-0003SH-3n; Tue, 10 May 2022 02:28:02 +0000 Received: by outflank-mailman (input) for mailman id 325092; Tue, 10 May 2022 02:28:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbU-0003Ap-8b for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id cee46989-d008-11ec-a406-831a346695d4; Tue, 10 May 2022 04:27:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9CB9F12FC; Mon, 9 May 2022 19:27:58 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 424D13F66F; Mon, 9 May 2022 19:27:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cee46989-d008-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v4 1/6] xen: do not free reserved memory into heap Date: Tue, 10 May 2022 10:27:28 +0800 Message-Id: <20220510022733.2422581-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. free_staticmem_pages will be called by free_heap_pages in runtime for static domain freeing memory resource, so let's drop the __init flag. Signed-off-by: Penny Zheng --- v4 changes: - no changes --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - fix the indentation --- v2 changes: - new commit --- xen/common/page_alloc.c | 17 ++++++++++++++--- xen/include/xen/mm.h | 2 +- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 319029140f..5e569a48a2 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1443,6 +1443,10 @@ static void free_heap_pages( ASSERT(order <= MAX_ORDER); + if ( pg->count_info & PGC_reserved ) + /* Reserved page shall not go back to the heap. */ + return free_staticmem_pages(pg, 1UL << order, need_scrub); + spin_lock(&heap_lock); for ( i = 0; i < (1 << order); i++ ) @@ -2636,8 +2640,8 @@ struct domain *get_pg_owner(domid_t domid) #ifdef CONFIG_STATIC_MEMORY /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; @@ -2653,7 +2657,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, } /* In case initializing page of static memory, mark it PGC_reserved. */ - pg[i].count_info |= PGC_reserved; + if ( !(pg[i].count_info & PGC_reserved) ) + pg[i].count_info |= PGC_reserved; } } @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } +#else +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) +{ + ASSERT_UNREACHABLE(); +} #endif /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3be754da92..9fd95deaec 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,10 +85,10 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) -#ifdef CONFIG_STATIC_MEMORY /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +#ifdef CONFIG_STATIC_MEMORY int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:28:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325093.547549 (Exim 4.92) (envelope-from ) id 1noFbZ-0003ls-IO; Tue, 10 May 2022 02:28:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325093.547549; Tue, 10 May 2022 02:28:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbZ-0003lf-EW; Tue, 10 May 2022 02:28:05 +0000 Received: by outflank-mailman (input) for mailman id 325093; Tue, 10 May 2022 02:28:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbY-0003k7-FD for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d1426c74-d008-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 04:28:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C100A12FC; Mon, 9 May 2022 19:28:02 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 215A33F66F; Mon, 9 May 2022 19:27:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1426c74-d008-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v4 2/6] xen: do not merge reserved pages in free_heap_pages() Date: Tue, 10 May 2022 10:27:29 +0800 Message-Id: <20220510022733.2422581-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The code in free_heap_pages() will try to merge pages with the successor/predecessor if pages are suitably aligned. So if the pages reserved are right next to the pages given to the heap allocator, free_heap_pages() will merge them, and give the reserved pages to heap allocator accidently as a result. So in order to avoid the above scenario, this commit updates free_heap_pages() to check whether the predecessor and/or successor has PGC_reserved set, when trying to merge the about-to-be-freed chunk with the predecessor and/or successor. Signed-off-by: Penny Zheng Suggested-by: Julien Grall Reviewed-by: Jan Beulich --- v4 changes: - commit message refinement --- v3 changes: - no changes --- v2 changes: - new commit --- xen/common/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 5e569a48a2..290526adaf 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1483,6 +1483,7 @@ static void free_heap_pages( /* Merge with predecessor block? */ if ( !mfn_valid(page_to_mfn(predecessor)) || !page_state_is(predecessor, free) || + (predecessor->count_info & PGC_reserved) || (PFN_ORDER(predecessor) != order) || (phys_to_nid(page_to_maddr(predecessor)) != node) ) break; @@ -1506,6 +1507,7 @@ static void free_heap_pages( /* Merge with successor block? */ if ( !mfn_valid(page_to_mfn(successor)) || !page_state_is(successor, free) || + (successor->count_info & PGC_reserved) || (PFN_ORDER(successor) != order) || (phys_to_nid(page_to_maddr(successor)) != node) ) break; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:28:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:28:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325095.547560 (Exim 4.92) (envelope-from ) id 1noFbf-0004B6-UX; Tue, 10 May 2022 02:28:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325095.547560; Tue, 10 May 2022 02:28:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbf-0004As-PO; Tue, 10 May 2022 02:28:11 +0000 Received: by outflank-mailman (input) for mailman id 325095; Tue, 10 May 2022 02:28:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbe-0003k7-7I for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:10 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d40deea3-d008-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 04:28:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73DE512FC; Mon, 9 May 2022 19:28:07 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 458EE3F66F; Mon, 9 May 2022 19:28:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d40deea3-d008-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v4 3/6] xen: add field "flags" to cover all internal CDF_XXX Date: Tue, 10 May 2022 10:27:30 +0800 Message-Id: <20220510022733.2422581-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng Acked-by: Julien Grall --- v4 changes: - no change --- v3 changes: - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - fix coding style --- xen/arch/arm/domain.c | 2 -- xen/arch/arm/include/asm/domain.h | 3 +-- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 +++ 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 8110c1df86..74189d9878 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d, ioreq_domain_init(d); #endif - d->arch.directmap = flags & CDF_directmap; - /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) goto fail; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index ed63c2b6f9..fe7a029ebf 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -29,7 +29,7 @@ enum domain_type { #define is_64bit_domain(d) (0) #endif -#define is_domain_direct_mapped(d) (d)->arch.directmap +#define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) /* * Is the domain using the host memory layout? @@ -103,7 +103,6 @@ struct arch_domain void *tee; #endif - bool directmap; } __cacheline_aligned; struct arch_vcpu diff --git a/xen/common/domain.c b/xen/common/domain.c index 8d2c2a9897..6373407047 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -567,6 +567,9 @@ struct domain *domain_create(domid_t domid, /* Sort out our idea of is_system_domain(). */ d->domain_id = domid; + /* Holding CDF_* internal flags. */ + d->cdf = flags; + /* Debug sanity. */ ASSERT(is_system_domain(d) ? config == NULL : config != NULL); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index ed8539f6d2..49415a113a 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -591,6 +591,9 @@ struct domain struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; #endif + + /* Holding CDF_* constant. Internal flags for domain creation. */ + unsigned int cdf; }; static inline struct page_list_head *page_to_list( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:28:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:28:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325102.547571 (Exim 4.92) (envelope-from ) id 1noFbk-0004dP-6Z; Tue, 10 May 2022 02:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325102.547571; Tue, 10 May 2022 02:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbk-0004dG-1e; Tue, 10 May 2022 02:28:16 +0000 Received: by outflank-mailman (input) for mailman id 325102; Tue, 10 May 2022 02:28:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbi-0003Ap-U3 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d6ccfa6f-d008-11ec-a406-831a346695d4; Tue, 10 May 2022 04:28:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D937B12FC; Mon, 9 May 2022 19:28:11 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EE5533F66F; Mon, 9 May 2022 19:28:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6ccfa6f-d008-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v4 4/6] xen/arm: introduce CDF_staticmem Date: Tue, 10 May 2022 10:27:31 +0800 Message-Id: <20220510022733.2422581-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 changes: - no changes --- v3 changes: - change name from "is_domain_static()" to "is_domain_using_staticmem" --- v2 changes: - change name from "is_domain_on_static_allocation" to "is_domain_static()" --- xen/arch/arm/domain_build.c | 5 ++++- xen/arch/arm/include/asm/domain.h | 2 ++ xen/include/xen/domain.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1472ca4972..6830a282a0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3190,9 +3190,12 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + if ( dt_property_read_bool(node, "direct-map") ) { - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) + if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) ) panic("direct-map is not valid for domain %s without static allocation.\n", dt_node_name(node)); diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index fe7a029ebf..110c672589 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -31,6 +31,8 @@ enum domain_type { #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) + /* * Is the domain using the host memory layout? * diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 1c3c88a14d..35dc7143a4 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -34,6 +34,8 @@ void arch_get_domain_info(const struct domain *d, #ifdef CONFIG_ARM /* Should domain memory be directly mapped? */ #define CDF_directmap (1U << 1) +/* Is domain memory on static allocation? */ +#define CDF_staticmem (1U << 2) #endif /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:28:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:28:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325106.547582 (Exim 4.92) (envelope-from ) id 1noFbn-0005AF-GW; Tue, 10 May 2022 02:28:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325106.547582; Tue, 10 May 2022 02:28:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbn-00059x-Bx; Tue, 10 May 2022 02:28:19 +0000 Received: by outflank-mailman (input) for mailman id 325106; Tue, 10 May 2022 02:28:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbl-0003Ap-Uc for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d96cd610-d008-11ec-a406-831a346695d4; Tue, 10 May 2022 04:28:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49FDB12FC; Mon, 9 May 2022 19:28:16 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5E0043F66F; Mon, 9 May 2022 19:28:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d96cd610-d008-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v4 5/6] xen/arm: unpopulate memory when domain is static Date: Tue, 10 May 2022 10:27:32 +0800 Message-Id: <20220510022733.2422581-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never go back to heap allocator. This commit puts reserved pages on the new list resv_page_list only after having taken them off the "normal" list, when the last ref dropped. Signed-off-by: Penny Zheng --- v4 changes: - no changes --- v3 changes: - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. --- v2 changes: - put reserved pages on resv_page_list after having taken them off the "normal" list --- xen/arch/arm/include/asm/mm.h | 12 ++++++++++++ xen/common/domain.c | 4 ++++ xen/include/xen/sched.h | 3 +++ 3 files changed, 19 insertions(+) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c6426c1705 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -358,6 +358,18 @@ void clear_and_clean_page(struct page_info *page); unsigned int arch_get_dma_bitsize(void); +/* + * Put free pages on the resv page list after having taken them + * off the "normal" page list, when pages from static memory + */ +#ifdef CONFIG_STATIC_MEMORY +#define arch_free_heap_page(d, pg) ({ \ + page_list_del(pg, page_to_list(d, pg)); \ + if ( (pg)->count_info & PGC_reserved ) \ + page_list_add_tail(pg, &(d)->resv_page_list); \ +}) +#endif + #endif /* __ARCH_ARM_MM__ */ /* * Local variables: diff --git a/xen/common/domain.c b/xen/common/domain.c index 6373407047..13fe7cecff 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid, INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); INIT_PAGE_LIST_HEAD(&d->xenpage_list); +#ifdef CONFIG_STATIC_MEMORY + INIT_PAGE_LIST_HEAD(&d->resv_page_list); +#endif + spin_lock_init(&d->node_affinity_lock); d->node_affinity = NODE_MASK_ALL; diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 49415a113a..368e5c1c53 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -376,6 +376,9 @@ struct domain struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ +#ifdef CONFIG_STATIC_MEMORY + struct page_list_head resv_page_list; /* linked list (size resv_pages) */ +#endif /* * This field should only be directly accessed by domain_adjust_tot_pages() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325121.547592 (Exim 4.92) (envelope-from ) id 1noFfN-0007bn-1Q; Tue, 10 May 2022 02:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325121.547592; Tue, 10 May 2022 02:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFfM-0007bI-UX; Tue, 10 May 2022 02:32:00 +0000 Received: by outflank-mailman (input) for mailman id 325121; Tue, 10 May 2022 02:32:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFbq-0003Ap-Kt for xen-devel@lists.xenproject.org; Tue, 10 May 2022 02:28:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id dba07557-d008-11ec-a406-831a346695d4; Tue, 10 May 2022 04:28:20 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2738012FC; Mon, 9 May 2022 19:28:20 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C2C0E3F66F; Mon, 9 May 2022 19:28:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dba07557-d008-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap Date: Tue, 10 May 2022 10:27:33 +0800 Message-Id: <20220510022733.2422581-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220510022733.2422581-1-Penny.Zheng@arm.com> References: <20220510022733.2422581-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When static domain populates memory through populate_physmap on runtime, other than allocating from heap, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. And this commit introduces a new helper acquire_reserved_page to make it work. Signed-off-by: Penny Zheng --- v4 changes： - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - move is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 --- xen/common/memory.c | 23 +++++++++++++++++++++++ xen/common/page_alloc.c | 35 +++++++++++++++++++++++++++++++++-- xen/include/xen/domain.h | 4 ++++ xen/include/xen/mm.h | 1 + 4 files changed, 61 insertions(+), 2 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index f2d009843a..cb330ce877 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) mfn = _mfn(gpfn); } + else if ( is_domain_using_staticmem(d) ) + { + /* + * No easy way to guarantee the retrieved pages are contiguous, + * so forbid non-zero-order requests here. + */ + if ( a->extent_order != 0 ) + { + gdprintk(XENLOG_WARNING, + "Cannot allocate static order-%u pages for static %pd\n", + a->extent_order, d); + goto out; + } + + mfn = acquire_reserved_page(d, a->memflags); + if ( mfn_eq(mfn, INVALID_MFN) ) + { + gdprintk(XENLOG_WARNING, + "%pd: failed to retrieve a reserved page\n", + d); + goto out; + } + } else { page = alloc_domheap_pages(d, a->extent_order, a->memflags); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 290526adaf..06e7037a28 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2740,8 +2740,8 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, * then assign them to one specific domain #d. */ -int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, - unsigned int nr_mfns, unsigned int memflags) +int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, + unsigned int memflags) { struct page_info *pg; @@ -2769,12 +2769,43 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } + +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + struct page_info *page; + mfn_t smfn; + + /* Acquire a page from reserved page list(resv_page_list). */ + page = page_list_remove_head(&d->resv_page_list); + if ( unlikely(!page) ) + return INVALID_MFN; + + smfn = page_to_mfn(page); + + if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) + { + page_list_add_tail(page, &d->resv_page_list); + return INVALID_MFN; + } + + return smfn; +} #else void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub) { ASSERT_UNREACHABLE(); } + +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + ASSERT_UNREACHABLE(); + return INVALID_MFN; +} #endif /* diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 35dc7143a4..c613afa57e 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -38,6 +38,10 @@ void arch_get_domain_info(const struct domain *d, #define CDF_staticmem (1U << 2) #endif +#ifndef is_domain_using_staticmem +#define is_domain_using_staticmem(d) ((void)(d), false) +#endif + /* * Arch-specifics. */ diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 9fd95deaec..74810e1f54 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -92,6 +92,7 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); #endif +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 02:49:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 02:49:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325157.547604 (Exim 4.92) (envelope-from ) id 1noFwG-0001BL-PL; Tue, 10 May 2022 02:49:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325157.547604; Tue, 10 May 2022 02:49:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFwG-0001BE-MM; Tue, 10 May 2022 02:49:28 +0000 Received: by outflank-mailman (input) for mailman id 325157; Tue, 10 May 2022 02:49:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFwF-0001B2-Ju; Tue, 10 May 2022 02:49:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFwF-0002Tu-HO; Tue, 10 May 2022 02:49:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noFwF-0003vS-6W; Tue, 10 May 2022 02:49:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noFwF-0008Nq-67; Tue, 10 May 2022 02:49:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MBAgA5cKbYArA7aRxx+5UHcPRl/ypBheufOvLk6sCi8=; b=5CSePhCm0sry/Jl85Zi5H/kEAO +i8O0XVq4Mi7XpRxa7WQYyueZFCGD0/RlEQz6LYpz7uqFIbMOYwkhFDo7cwjyF7Df3adK3KIggjH8 2Cg5IDbxy+3R7b5e6XIcpdIGc+8XbqnGIsht00tHKbXrM0Wfc91NXt//EbHalGpl4d/0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170280: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0badfb110fa33ca9ffd3bdc3a5200cded03e6106 X-Osstest-Versions-That: xen=95604873ccf56eb81e96ed0dc8b4dec3278f40ca From: osstest service owner Date: Tue, 10 May 2022 02:49:27 +0000 flight 170280 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170280/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 baseline version: xen 95604873ccf56eb81e96ed0dc8b4dec3278f40ca Last test of basis 170278 2022-05-09 19:01:55 Z 0 days Testing same since 170280 2022-05-09 23:01:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Luca Fancellu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 95604873cc..0badfb110f 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 -> smoke From xen-devel-bounces@lists.xenproject.org Tue May 10 05:03:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 05:03:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325168.547615 (Exim 4.92) (envelope-from ) id 1noI1w-0000dc-Ed; Tue, 10 May 2022 05:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325168.547615; Tue, 10 May 2022 05:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noI1w-0000dV-9s; Tue, 10 May 2022 05:03:28 +0000 Received: by outflank-mailman (input) for mailman id 325168; Tue, 10 May 2022 05:03:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noI1v-0000dL-9w; Tue, 10 May 2022 05:03:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noI1v-0005Cj-7W; Tue, 10 May 2022 05:03:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noI1u-0002Ml-Rx; Tue, 10 May 2022 05:03:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noI1u-0002mA-RV; Tue, 10 May 2022 05:03:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ML0a94T8WcF9XSUQzB0z/MvlbjCwEO9Kn1dZNdvM7A8=; b=sIHVyZXarCvhcUFK0lmFvL1V/s dNe13kQq/Hr7FlujjmbM0/Lo+XreuLHyR64vV39GpyqE+gmcmj+aqg0r7ACU/wfHcDAU/Bv/FSj6J 1ocw6GJDvDUMb8UFZYC8/j9jjTfUwnU4wUK5Uw4fNhc1YSqPn4WUgE42D+/5WroV6vyg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170285: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 05:03:26 +0000 flight 170285 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170285/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 905 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325177.547636 (Exim 4.92) (envelope-from ) id 1noIzd-00084N-Ag; Tue, 10 May 2022 06:05:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325177.547636; Tue, 10 May 2022 06:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzd-00084G-7o; Tue, 10 May 2022 06:05:09 +0000 Received: by outflank-mailman (input) for mailman id 325177; Tue, 10 May 2022 06:05:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzb-0007z7-TW for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:08 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b61a37a-d027-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 08:04:53 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id n8so15878727plh.1 for ; Mon, 09 May 2022 23:05:04 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id y7-20020a170902b48700b0015e8d4eb2d5sm945764plr.287.2022.05.09.23.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b61a37a-d027-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BFckj9YfDJ61q1eBueMecImTvynCt5bpUOPgONXR2+I=; b=VmD81tx1qhFdTJ3yJqAZlYYVX/2/bqKI7qgHYaWH15qkRgQjm3Ec8ytBI9S1NfNNtT oWfdsQFa43UmXZ/lf36tjVtGf58oS+eo8qB3jfQj3snX2/94Zu6S3DKRpLQX8hxge40W 1dprtTWO8bqrw3G6KI6JbV41NKO0cACe95Qv4E1s+Q8dEumDyjRbESCyry7sKv3YGJGO S+ztpmHMkpuBEq56jXQaJaVC+olDVIp/fPyfKeFSw5veyRFENa8OHwMGBEO2h6ePGzVs fXerO/QQaEcr/ymtwWvSQ1BL0Kroiltbv3gJY2xetu4jfIEzm9S+RDCa5BnIBB3ZklDc ta/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BFckj9YfDJ61q1eBueMecImTvynCt5bpUOPgONXR2+I=; b=j1WzjpgOd9eVEn7uo1bTE+DKRw3XmPlDd2NSxGwrN6UVGZOD7UFjPkgDhD0NWKhloQ 9ov5RH9lBxJlSi4QHT6zYj9f2LXdEakCPf/k1B/8b+otoI7L3z7V0OGJj94qPFpze5C/ KhmnzK1QarYflN+yPdauhALcTzqph6dVEvuDCJq0FDIeGZEMaY2+In+Pg5+FmpINw7Z5 DioiaWn3Jw6i8+yB0eGIozw57WpWULW74Ep7gdd92IT/jQAKTGnZ1Jb/HgHAkOGHrzj5 3x9NOIjtaKyBjNVoNYOXmZV6C+hICGdiM2NX3Kl8XvsB0KuPCsCSexx+j81mn338TB5V QkMg== X-Gm-Message-State: AOAM5320cJEAVjzlu1wZ7Mq00Mzvm/8nZPLgnnHtjab9E83aHCsb3my7 2/RrESRkRdky3Ezz+dZD5tYTiDidBUMiOQ== X-Google-Smtp-Source: ABdhPJzWkYCoIzBMXoxeV9//CjBVxE2XQjNCmGmzVecsd1JqpI+QmhCOMOpZVHWgw+6gwFL8VeJH8w== X-Received: by 2002:a17:90a:9914:b0:1db:d10f:1fcf with SMTP id b20-20020a17090a991400b001dbd10f1fcfmr29740584pjp.241.1652162702586; Mon, 09 May 2022 23:05:02 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 1/6] libxl: Add support for Virtio I2C device Date: Tue, 10 May 2022 11:34:46 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for configuring and assisting virtio-mmio based virtio-i2c backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio I2c: i2c = [ "" ] Please note, this patch is not enough for virtio-i2c to work on Xen (Arm), as for every Virtio device we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. A subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. Signed-off-by: Viresh Kumar --- tools/golang/xenlight/helpers.gen.go | 110 ++++++++++ tools/golang/xenlight/types.gen.go | 27 +++ tools/include/libxl.h | 32 +++ tools/include/libxl_utils.h | 3 + tools/libs/light/Makefile | 1 + tools/libs/light/libxl_create.c | 13 ++ tools/libs/light/libxl_dm.c | 19 +- tools/libs/light/libxl_i2c.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 26 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_i2c.c | 143 +++++++++++++ tools/xl/xl_parse.c | 80 ++++++++ tools/xl/xl_parse.h | 1 + tools/xl/xl_sxp.c | 2 + 20 files changed, 714 insertions(+), 3 deletions(-) create mode 100644 tools/libs/light/libxl_i2c.c create mode 100644 tools/xl/xl_i2c.c diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff108131..ad23b0969abd 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1215,6 +1215,9 @@ x.Usbdevice = C.GoString(tmp.usbdevice) if err := x.VkbDevice.fromC(&tmp.vkb_device);err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := x.I2cDevice.fromC(&tmp.i2c_device);err != nil { +return fmt.Errorf("converting field I2cDevice: %v", err) +} x.Soundhw = C.GoString(tmp.soundhw) if err := x.XenPlatformPci.fromC(&tmp.xen_platform_pci);err != nil { return fmt.Errorf("converting field XenPlatformPci: %v", err) @@ -1532,6 +1535,9 @@ hvm.usbdevice = C.CString(tmp.Usbdevice)} if err := tmp.VkbDevice.toC(&hvm.vkb_device); err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := tmp.I2cDevice.toC(&hvm.i2c_device); err != nil { +return fmt.Errorf("converting field I2cDevice: %v", err) +} if tmp.Soundhw != "" { hvm.soundhw = C.CString(tmp.Soundhw)} if err := tmp.XenPlatformPci.toC(&hvm.xen_platform_pci); err != nil { @@ -1722,6 +1728,46 @@ xc.multi_touch_num_contacts = C.uint32_t(x.MultiTouchNumContacts) return nil } +// NewDeviceI2c returns an instance of DeviceI2c initialized with defaults. +func NewDeviceI2c() (*DeviceI2c, error) { +var ( +x DeviceI2c +xc C.libxl_device_i2c) + +C.libxl_device_i2c_init(&xc) +defer C.libxl_device_i2c_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *DeviceI2c) fromC(xc *C.libxl_device_i2c) error { + x.BackendDomid = Domid(xc.backend_domid) +x.BackendDomname = C.GoString(xc.backend_domname) +x.Devid = Devid(xc.devid) +x.BackendType = I2cBackend(xc.backend_type) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) + + return nil} + +func (x *DeviceI2c) toC(xc *C.libxl_device_i2c) (err error){defer func(){ +if err != nil{ +C.libxl_device_i2c_dispose(xc)} +}() + +xc.backend_domid = C.libxl_domid(x.BackendDomid) +if x.BackendDomname != "" { +xc.backend_domname = C.CString(x.BackendDomname)} +xc.devid = C.libxl_devid(x.Devid) +xc.backend_type = C.libxl_i2c_backend(x.BackendType) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) + + return nil + } + // NewDeviceDisk returns an instance of DeviceDisk initialized with defaults. func NewDeviceDisk() (*DeviceDisk, error) { var ( @@ -2835,6 +2881,15 @@ if err := x.Vkbs[i].fromC(&v); err != nil { return fmt.Errorf("converting field Vkbs: %v", err) } } } +x.I2cs = nil +if n := int(xc.num_i2cs); n > 0 { +cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:n:n] +x.I2cs = make([]DeviceI2c, n) +for i, v := range cI2cs { +if err := x.I2cs[i].fromC(&v); err != nil { +return fmt.Errorf("converting field I2cs: %v", err) } +} +} x.Vtpms = nil if n := int(xc.num_vtpms); n > 0 { cVtpms := (*[1<<28]C.libxl_device_vtpm)(unsafe.Pointer(xc.vtpms))[:n:n] @@ -2996,6 +3051,16 @@ return fmt.Errorf("converting field Vkbs: %v", err) } } } +if numI2cs := len(x.I2cs); numI2cs > 0 { +xc.i2cs = (*C.libxl_device_i2c)(C.malloc(C.ulong(numI2cs)*C.sizeof_libxl_device_i2c)) +xc.num_i2cs = C.int(numI2cs) +cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:numI2cs:numI2cs] +for i,v := range x.I2cs { +if err := v.toC(&cI2cs[i]); err != nil { +return fmt.Errorf("converting field I2cs: %v", err) +} +} +} if numVtpms := len(x.Vtpms); numVtpms > 0 { xc.vtpms = (*C.libxl_device_vtpm)(C.malloc(C.ulong(numVtpms)*C.sizeof_libxl_device_vtpm)) xc.num_vtpms = C.int(numVtpms) @@ -3683,6 +3748,51 @@ if err != nil{ C.libxl_vkbinfo_dispose(xc)} }() +if x.Backend != "" { +xc.backend = C.CString(x.Backend)} +xc.backend_id = C.uint32_t(x.BackendId) +if x.Frontend != "" { +xc.frontend = C.CString(x.Frontend)} +xc.frontend_id = C.uint32_t(x.FrontendId) +xc.devid = C.libxl_devid(x.Devid) +xc.state = C.int(x.State) +xc.evtch = C.int(x.Evtch) +xc.rref = C.int(x.Rref) + + return nil + } + +// NewI2cinfo returns an instance of I2cinfo initialized with defaults. +func NewI2cinfo() (*I2cinfo, error) { +var ( +x I2cinfo +xc C.libxl_i2cinfo) + +C.libxl_i2cinfo_init(&xc) +defer C.libxl_i2cinfo_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *I2cinfo) fromC(xc *C.libxl_i2cinfo) error { + x.Backend = C.GoString(xc.backend) +x.BackendId = uint32(xc.backend_id) +x.Frontend = C.GoString(xc.frontend) +x.FrontendId = uint32(xc.frontend_id) +x.Devid = Devid(xc.devid) +x.State = int(xc.state) +x.Evtch = int(xc.evtch) +x.Rref = int(xc.rref) + + return nil} + +func (x *I2cinfo) toC(xc *C.libxl_i2cinfo) (err error){defer func(){ +if err != nil{ +C.libxl_i2cinfo_dispose(xc)} +}() + if x.Backend != "" { xc.backend = C.CString(x.Backend)} xc.backend_id = C.uint32_t(x.BackendId) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d525843..c232e4811ac3 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -241,6 +241,11 @@ VkbBackendQemu VkbBackend = 1 VkbBackendLinux VkbBackend = 2 ) +type I2cBackend int +const( +I2cBackendVirtio I2cBackend = 0 +) + type Passthrough int const( PassthroughDefault Passthrough = 0 @@ -568,6 +573,7 @@ Usb Defbool Usbversion int Usbdevice string VkbDevice Defbool +I2cDevice Defbool Soundhw string XenPlatformPci Defbool UsbdeviceList StringList @@ -630,6 +636,15 @@ MultiTouchHeight uint32 MultiTouchNumContacts uint32 } +type DeviceI2c struct { +BackendDomid Domid +BackendDomname string +Devid Devid +BackendType I2cBackend +Irq uint32 +Base uint64 +} + type DeviceDisk struct { BackendDomid Domid BackendDomname string @@ -913,6 +928,7 @@ Rdms []DeviceRdm Dtdevs []DeviceDtdev Vfbs []DeviceVfb Vkbs []DeviceVkb +I2cs []DeviceI2c Vtpms []DeviceVtpm P9S []DeviceP9 Pvcallsifs []DevicePvcallsif @@ -1067,6 +1083,17 @@ Evtch int Rref int } +type I2cinfo struct { +Backend string +BackendId uint32 +Frontend string +FrontendId uint32 +Devid Devid +State int +Evtch int +Rref int +} + type Numainfo struct { Size uint64 Free uint64 diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 51a9b6cfaceb..4d19194c3dc2 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -800,6 +800,15 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 +/* + * LIBXL_HAVE_BUILDINFO_I2C_DEVICE + * + * If this is defined, then the libxl_domain_build_info structure will + * contain a boolean hvm.i2c_device which instructs libxl whether to include + * a i2c at build time or not. + */ +#define LIBXL_HAVE_BUILDINFO_I2C_DEVICE 1 + /* * LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST * @@ -2368,6 +2377,29 @@ int libxl_device_vkb_getinfo(libxl_ctx *ctx, uint32_t domid, libxl_vkbinfo *vkbinfo) LIBXL_EXTERNAL_CALLERS_ONLY; +/* I2C */ +int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_remove(libxl_ctx *ctx, uint32_t domid, + libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_destroy(libxl_ctx *ctx, uint32_t domid, + libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; + +libxl_device_i2c *libxl_device_i2c_list(libxl_ctx *ctx, + uint32_t domid, int *num) + LIBXL_EXTERNAL_CALLERS_ONLY; +void libxl_device_i2c_list_free(libxl_device_i2c* list, int num) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_i2c_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_i2c *i2c, + libxl_i2cinfo *i2cinfo) + LIBXL_EXTERNAL_CALLERS_ONLY; + /* Framebuffer */ int libxl_device_vfb_add(libxl_ctx *ctx, uint32_t domid, libxl_device_vfb *vfb, const libxl_asyncop_how *ao_how) diff --git a/tools/include/libxl_utils.h b/tools/include/libxl_utils.h index 46918aea847f..72b7796b7e4b 100644 --- a/tools/include/libxl_utils.h +++ b/tools/include/libxl_utils.h @@ -83,6 +83,9 @@ int libxl_devid_to_device_usbctrl(libxl_ctx *ctx, uint32_t domid, int libxl_devid_to_device_vkb(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vkb *vkb); +int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_i2c *i2c); + int libxl_devid_to_device_vdispl(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vdispl *vdispl); diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 453bea006723..dca46846e586 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,7 @@ SRCS-y += libxl_vdispl.c SRCS-y += libxl_pvcalls.c SRCS-y += libxl_vsnd.c SRCS-y += libxl_vkb.c +SRCS-y += libxl_i2c.c SRCS-y += libxl_genid.c SRCS-y += _libxl_types.c SRCS-y += libxl_flask.c diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 69ec405858a8..d604171e504c 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -363,6 +363,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); libxl_defbool_setdefault(&b_info->u.hvm.usb, false); libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); + libxl_defbool_setdefault(&b_info->u.hvm.i2c_device, true); libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); libxl_defbool_setdefault(&b_info->u.hvm.spice.enable, false); @@ -1755,6 +1756,7 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl__device_console console; libxl__device device; libxl_device_vkb vkb; + libxl_device_i2c i2c; init_console_info(gc, &console, 0); console.backend_domid = state->console_domid; @@ -1767,6 +1769,12 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl_device_vkb_dispose(&vkb); } + if (libxl_defbool_val(d_config->b_info.u.hvm.i2c_device)) { + libxl_device_i2c_init(&i2c); + libxl__device_add(gc, domid, &libxl__i2c_devtype, &i2c); + libxl_device_i2c_dispose(&i2c); + } + dcs->sdss.dm.guest_domid = domid; if (libxl_defbool_val(d_config->b_info.device_model_stubdomain)) libxl__spawn_stub_dm(egc, &dcs->sdss); @@ -1799,6 +1807,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl__device_add(gc, domid, &libxl__i2c_devtype, + &d_config->i2cs[i]); + } + if (d_config->b_info.arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART) { init_console_info(gc, &vuart, 0); vuart.backend_domid = state->console_domid; diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 1864ee30f0a2..9340ae4628a2 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -2095,7 +2095,8 @@ static void libxl__dm_vifs_from_hvm_guest_config(libxl__gc *gc, static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, const libxl_domain_config *guest_config, libxl_device_vfb *vfb, - libxl_device_vkb *vkb) + libxl_device_vkb *vkb, + libxl_device_i2c *i2c) { const libxl_domain_build_info *b_info = &guest_config->b_info; @@ -2104,6 +2105,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, libxl_device_vfb_init(vfb); libxl_device_vkb_init(vkb); + libxl_device_i2c_init(i2c); vfb->backend_domid = 0; vfb->devid = 0; @@ -2114,6 +2116,9 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, vkb->backend_domid = 0; vkb->devid = 0; + i2c->backend_domid = 0; + i2c->devid = 0; + return 0; } @@ -2276,6 +2281,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) int ret; libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; char **args; struct xs_permissions perm[2]; xs_transaction_t t; @@ -2348,11 +2354,14 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) || libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { GCNEW(vfb); GCNEW(vkb); - libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb); + GCNEW(i2c); + libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, i2c); dm_config->vfbs = vfb; dm_config->num_vfbs = 1; dm_config->vkbs = vkb; dm_config->num_vkbs = 1; + dm_config->i2cs = i2c; + dm_config->num_i2cs = 1; } if (guest_config->b_info.stubdomain_kernel && @@ -2494,6 +2503,12 @@ static void spawn_stub_launch_dm(libxl__egc *egc, if (ret) goto out; } + if (dm_config->num_i2cs) { + ret = libxl__device_add(gc, dm_domid, &libxl__i2c_devtype, + &dm_config->i2cs[0]); + if (ret) goto out; + } + if (guest_config->b_info.u.hvm.serial) { num_console++; } else if (guest_config->b_info.u.hvm.serial_list) { diff --git a/tools/libs/light/libxl_i2c.c b/tools/libs/light/libxl_i2c.c new file mode 100644 index 000000000000..fd13c07826ff --- /dev/null +++ b/tools/libs/light/libxl_i2c.c @@ -0,0 +1,236 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +#include + +static int libxl__device_i2c_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, bool hotplug) +{ + if (i2c->backend_type != LIBXL_I2C_BACKEND_VIRTIO) { + i2c->backend_type = LIBXL_I2C_BACKEND_VIRTIO; + } + + return libxl__resolve_domid(gc, i2c->backend_domname, &i2c->backend_domid); +} + +static int libxl__device_i2c_dm_needed(void *e, uint32_t domid) +{ + libxl_device_i2c *elem = e; + + return elem->backend_type == LIBXL_I2C_BACKEND_VIRTIO; +} + +static int libxl__set_xenstore_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *i2c, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + flexarray_append_pair(back, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", i2c->base)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", i2c->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", i2c->base)); + + return 0; +} + +static int libxl__i2c_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_i2c *i2c) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + i2c->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &i2c->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + i2c->backend_type = LIBXL_I2C_BACKEND_VIRTIO; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + i2c->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static int libxl__device_from_i2c(libxl__gc *gc, uint32_t domid, + libxl_device_i2c *type, libxl__device *device) +{ + device->backend_devid = type->devid; + device->backend_domid = type->backend_domid; + device->backend_kind = LIBXL__DEVICE_KIND_I2C; + device->devid = type->devid; + device->domid = domid; + device->kind = LIBXL__DEVICE_KIND_I2C; + + return 0; +} + +int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, + const libxl_asyncop_how *ao_how) +{ + AO_CREATE(ctx, domid, ao_how); + int rc; + + rc = libxl__device_add(gc, domid, &libxl__i2c_devtype, i2c); + if (rc) { + LOGD(ERROR, domid, "Unable to add i2c device"); + goto out; + } + +out: + libxl__ao_complete(egc, ao, rc); + return AO_INPROGRESS; +} + +int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_i2c *i2c) +{ + GC_INIT(ctx); + + libxl_device_i2c *i2cs = NULL; + int n, i; + int rc; + + libxl_device_i2c_init(i2c); + + i2cs = libxl__device_list(gc, &libxl__i2c_devtype, domid, &n); + + if (!i2cs) { rc = ERROR_NOTFOUND; goto out; } + + for (i = 0; i < n; ++i) { + if (devid == i2cs[i].devid) { + libxl_device_i2c_copy(ctx, i2c, &i2cs[i]); + rc = 0; + goto out; + } + } + + rc = ERROR_NOTFOUND; + +out: + + if (i2cs) + libxl__device_list_free(&libxl__i2c_devtype, i2cs, n); + + GC_FREE; + return rc; +} + +int libxl_device_i2c_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_i2c *i2c, + libxl_i2cinfo *info) +{ + GC_INIT(ctx); + char *libxl_path, *dompath, *devpath; + char *val; + int rc; + + libxl_i2cinfo_init(info); + dompath = libxl__xs_get_dompath(gc, domid); + info->devid = i2c->devid; + + devpath = libxl__domain_device_frontend_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_I2C); + libxl_path = libxl__domain_device_libxl_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_I2C); + + info->backend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + NULL); + if (!info->backend) { rc = ERROR_FAIL; goto out; } + + rc = libxl__backendpath_parse_domid(gc, info->backend, &info->backend_id); + if (rc) goto out; + + val = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/state", devpath)); + info->state = val ? strtoul(val, NULL, 10) : -1; + + info->frontend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + NULL); + info->frontend_id = domid; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_EVT_CHANNEL, devpath)); + info->evtch = val ? strtoul(val, NULL, 10) : -1; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_RING_GREF, devpath)); + info->rref = val ? strtoul(val, NULL, 10) : -1; + + rc = 0; + +out: + GC_FREE; + return rc; +} + +static LIBXL_DEFINE_UPDATE_DEVID(i2c) + +#define libxl__add_i2cs NULL +#define libxl_device_i2c_compare NULL + +LIBXL_DEFINE_DEVICE_LIST(i2c) +LIBXL_DEFINE_DEVICE_REMOVE(i2c) + +DEFINE_DEVICE_TYPE_STRUCT(i2c, I2C, i2cs, + .skip_attach = 1, + .dm_needed = libxl__device_i2c_dm_needed, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_i2c, + .from_xenstore = (device_from_xenstore_fn_t)libxl__i2c_from_xenstore +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index bdef5a605ea9..b4dfbe7e5db1 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4001,6 +4001,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__i2c_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; extern const libxl__device_type libxl__vtpm_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 2a42da2f7d78..e9454e669224 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -266,6 +266,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_i2c_backend = Enumeration("i2c_backend", [ + (0, "VIRTIO") + ]) + libxl_passthrough = Enumeration("passthrough", [ (0, "default"), (1, "disabled"), @@ -614,6 +618,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ # - "mouse" for PS/2 protocol relative mouse ("usbdevice", string), ("vkb_device", libxl_defbool), + ("i2c_device", libxl_defbool), ("soundhw", string), ("xen_platform_pci", libxl_defbool), ("usbdevice_list", libxl_string_list), @@ -691,6 +696,15 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_i2c = Struct("device_i2c", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("backend_type", libxl_i2c_backend), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_disk = Struct("device_disk", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -960,6 +974,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("i2cs", Array(libxl_device_i2c, "num_i2cs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), ("pvcallsifs", Array(libxl_device_pvcallsif, "num_pvcallsifs")), @@ -1121,6 +1136,17 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_i2cinfo = Struct("i2cinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ("evtch", integer), + ("rref", integer) + ], dir=DIR_OUT) + # NUMA node characteristics: size and free are how much memory it has, and how # much of it is free, respectively. dists is an array of distances from this # node to each other node. diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 3593e21dbb64..1b87d1480bf9 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "I2C"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index 7bf26bdcd831..a9db0b97d80f 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_i2c": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), ("of_vdev", ["ctx", "domid", "string", "t"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74a..cdf473f4ed57 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(i2c) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/Makefile b/tools/xl/Makefile index b7f439121a3a..06801962f11e 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -23,7 +23,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o XL_OBJS += xl_info.o xl_console.o xl_misc.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_i2c.o $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XL_OBJS): CFLAGS += $(CFLAGS_XL) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd5d..210bc1b6d47a 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -177,6 +177,9 @@ int main_vsnddetach(int argc, char **argv); int main_vkbattach(int argc, char **argv); int main_vkblist(int argc, char **argv); int main_vkbdetach(int argc, char **argv); +int main_i2cattach(int argc, char **argv); +int main_i2clist(int argc, char **argv); +int main_i2cdetach(int argc, char **argv); int main_usbctrl_attach(int argc, char **argv); int main_usbctrl_detach(int argc, char **argv); int main_usbdev_attach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d4884e..30bd614fc275 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -406,6 +406,21 @@ const struct cmd_spec cmd_table[] = { "Destroy a domain's virtual keyboard device", " ", }, + { "i2c-attach", + &main_i2cattach, 1, 1, + "Create a new virtual i2c device", + " ...", + }, + { "i2c-list", + &main_i2clist, 0, 0, + "List virtual i2c devices for a domain", + "", + }, + { "i2c-detach", + &main_i2cdetach, 0, 1, + "Destroy a domain's virtual i2c device", + " ", + }, { "vdispl-attach", &main_vdisplattach, 1, 1, "Create a new virtual display device", diff --git a/tools/xl/xl_i2c.c b/tools/xl/xl_i2c.c new file mode 100644 index 000000000000..a916d05604f2 --- /dev/null +++ b/tools/xl/xl_i2c.c @@ -0,0 +1,143 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include + +#include +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +int main_i2cattach(int argc, char **argv) +{ + int opt; + int rc; + uint32_t domid; + libxl_device_i2c i2c; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-attach", 2) { + /* No options */ + } + + libxl_device_i2c_init(&i2c); + domid = find_domain(argv[optind++]); + + for (argv += optind, argc -= optind; argc > 0; ++argv, --argc) { + rc = parse_i2c_config(&i2c, *argv); + if (rc) goto out; + } + + if (dryrun_only) { + char *json = libxl_device_i2c_to_json(ctx, &i2c); + printf("i2c: %s\n", json); + free(json); + goto done; + } + + if (libxl_device_i2c_add(ctx, domid, &i2c, 0)) { + fprintf(stderr, "libxl_device_i2c_add failed.\n"); + rc = ERROR_FAIL; goto out; + } + +done: + rc = 0; + +out: + libxl_device_i2c_dispose(&i2c); + return rc; +} + +int main_i2clist(int argc, char **argv) +{ + int opt; + libxl_device_i2c *i2cs; + libxl_i2cinfo i2cinfo; + int nb, i; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-list", 1) { + /* No options */ + } + + /* Idx BE Hdl Sta evch ref ID BE-type BE-path */ + printf("%-3s %-2s %-6s %-5s %-6s %6s %-10s %-10s %-30s\n", + "Idx", "BE", "handle", "state", "evt-ch", "ref", + "ID", "BE-type", "BE-path"); + for (argv += optind, argc -= optind; argc > 0; --argc, ++argv) { + uint32_t domid = find_domain(*argv); + i2cs = libxl_device_i2c_list(ctx, domid, &nb); + if (!i2cs) { + continue; + } + for (i = 0; i < nb; ++i) { + if (libxl_device_i2c_getinfo(ctx, domid, &i2cs[i], &i2cinfo) == 0) { + printf("%-3d %-2d %6d %5d %6d %6d %-10s %-30s\n", + i2cinfo.devid, i2cinfo.backend_id, + i2cinfo.devid, i2cinfo.state, i2cinfo.evtch, + i2cinfo.rref, + libxl_i2c_backend_to_string(i2cs[i].backend_type), + i2cinfo.backend); + libxl_i2cinfo_dispose(&i2cinfo); + } + } + libxl_device_i2c_list_free(i2cs, nb); + } + return 0; +} + +int main_i2cdetach(int argc, char **argv) +{ + uint32_t domid, devid; + int opt, rc; + libxl_device_i2c i2c; + + SWITCH_FOREACH_OPT(opt, "", NULL, "i2c-detach", 2) { + /* No options */ + } + + domid = find_domain(argv[optind++]); + devid = atoi(argv[optind++]); + + libxl_device_i2c_init(&i2c); + + if (libxl_devid_to_device_i2c(ctx, domid, devid, &i2c)) { + fprintf(stderr, "Error: Device %d not connected.\n", devid); + rc = ERROR_FAIL; + goto out; + } + + rc = libxl_device_i2c_remove(ctx, domid, &i2c, 0); + if (rc) { + fprintf(stderr, "libxl_device_i2c_remove failed.\n"); + rc = ERROR_FAIL; + goto out; + } + + rc = 0; + +out: + libxl_device_i2c_dispose(&i2c); + return rc; +} + + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index b98c0de378b6..95483e551c38 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1204,6 +1204,74 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +int parse_i2c_config(libxl_device_i2c *i2c, char *token) +{ + char *oparg; + + if (MATCH_OPTION("backend", token, oparg)) { + i2c->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("backend-type", token, oparg)) { + libxl_i2c_backend backend_type; + if (libxl_i2c_backend_from_string(oparg, &backend_type)) { + fprintf(stderr, "Unknown backend_type \"%s\" in i2c spec\n", + oparg); + return -1; + } + i2c->backend_type = backend_type; + } else if (MATCH_OPTION("irq", token, oparg)) { + i2c->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + i2c->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in i2c spec\n", token); + return -1; + } + + return 0; +} + +static void parse_i2c_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *i2cs; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "i2c", &i2cs, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(i2cs, entry)) != NULL) { + libxl_device_i2c *i2c; + char *p; + + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, + d_config->num_i2cs, + libxl_device_i2c_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_i2c_config(i2c, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + void parse_config_data(const char *config_source, const char *config_data, int config_len, @@ -2305,13 +2373,16 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_i2cs = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->i2cs = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; char *buf2 = strdup(buf); char *p, *p2; @@ -2322,6 +2393,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, + libxl_device_i2c_init); + p = strtok(buf2, ","); if (!p) goto skip_vfb; @@ -2579,6 +2653,7 @@ void parse_config_data(const char *config_source, if (vnc_enabled) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_i2c *i2c; vfb = ARRAY_EXTEND_INIT(d_config->vfbs, d_config->num_vfbs, libxl_device_vfb_init); @@ -2586,6 +2661,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, + libxl_device_i2c_init); + parse_top_level_vnc_options(config, &vfb->vnc); parse_top_level_sdl_options(config, &vfb->sdl); xlu_cfg_replace_string (config, "keymap", &vfb->keymap, 0); @@ -2700,6 +2778,7 @@ void parse_config_data(const char *config_source, exit(-ERROR_FAIL); } xlu_cfg_get_defbool(config, "vkb_device", &b_info->u.hvm.vkb_device, 0); + xlu_cfg_get_defbool(config, "i2c_device", &b_info->u.hvm.i2c_device, 0); xlu_cfg_replace_string (config, "soundhw", &b_info->u.hvm.soundhw, 0); xlu_cfg_get_defbool(config, "xen_platform_pci", &b_info->u.hvm.xen_platform_pci, 0); @@ -2748,6 +2827,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_i2c_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", &c_info->xend_suspend_evtchn_compat, 0); diff --git a/tools/xl/xl_parse.h b/tools/xl/xl_parse.h index bab2861f8c3e..4b972d525199 100644 --- a/tools/xl/xl_parse.h +++ b/tools/xl/xl_parse.h @@ -36,6 +36,7 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config **config, char *token); int parse_vdispl_config(libxl_device_vdispl *vdispl, char *token); int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec); int parse_vkb_config(libxl_device_vkb *vkb, char *token); +int parse_i2c_config(libxl_device_i2c *i2c, char *token); int match_option_size(const char *prefix, size_t len, char *arg, char **argopt); diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c index 359a0015709e..a44c765aa515 100644 --- a/tools/xl/xl_sxp.c +++ b/tools/xl/xl_sxp.c @@ -140,6 +140,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) fprintf(fh, "\t\t\t(usbdevice %s)\n", b_info->u.hvm.usbdevice); fprintf(fh, "\t\t\t(vkb_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.vkb_device)); + fprintf(fh, "\t\t\t(i2c_device %s)\n", + libxl_defbool_to_string(b_info->u.hvm.i2c_device)); fprintf(fh, "\t\t)\n"); break; case LIBXL_DOMAIN_TYPE_PV: -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325180.547670 (Exim 4.92) (envelope-from ) id 1noIzi-0000UG-Kh; Tue, 10 May 2022 06:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325180.547670; Tue, 10 May 2022 06:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzi-0000U3-HU; Tue, 10 May 2022 06:05:14 +0000 Received: by outflank-mailman (input) for mailman id 325180; Tue, 10 May 2022 06:05:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzg-0007ob-PR for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:12 +0000 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [2607:f8b0:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26a1bf24-d027-11ec-a406-831a346695d4; Tue, 10 May 2022 08:05:12 +0200 (CEST) Received: by mail-pg1-x533.google.com with SMTP id a191so13834968pge.2 for ; Mon, 09 May 2022 23:05:12 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id g8-20020a1709029f8800b0015e8d4eb277sm971751plq.193.2022.05.09.23.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26a1bf24-d027-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PPqz95lztCC38dTJHeWNR5iEVbeizZheBx488usygyI=; b=vMHmiiogda0eo2/FDg6G7b/iTEveRUAuIW2QZ0etiRM4FaQNA6XkuU+P+GXpnXf+5b enCYqyc1TUOUd26J0sLkxH/e6wIA6yU4ZJptcid0h+KsWU+69ifJTbbgyTivLDvgG6SH L1PodZd2PtLXYXUtl8DwkcGyBom3cTecCzSEdwlaTIfNAV2tlorluAa0qsJuYkYap1RD OnRZiBUkmd+c/5JNSKaAfpCaNouATNjXvBRXBeIetFY+k9GyV91ls6DnwguiUVny6z7P LYMpAaKnKKeLCeweY8nJHftRFAIZf4olPFXkC6rRKP5HqP38WlRQ94l+yuRDulWPETzY 7EyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PPqz95lztCC38dTJHeWNR5iEVbeizZheBx488usygyI=; b=wqFfOkEHmjwZvEpgj7z60JbdSmePlxHgdzMLBvGsYpT4HzZvIfoDOvdjizzLtvtnLW 37UHPNljVw8kRDK4F/vqAEvAbTjt2olJ70w6eIHq7xLfDr75bYwkXev9Wn6J3MntIT3M CpcHcCWdM3sBEZ3gd+50lO2Kc1jyX2V7VH3yKqHAh0xPb12+oIz3PNoIVjjybo4FZAsv LpKj33LMKbA7yEmKokF9vc9C8DIJuoow8pHOIRnExDxVfk+VxIxyzi2X31qGnwhdGNQv h0FsrH3oql33Sk5vEPo7/+YnCXt6N5QqtRDGfV2HvOE+oLBw+IaravqPx6uDwTbSKeXl Wmew== X-Gm-Message-State: AOAM530DOH2XUMJ76s73PBKGM90BBWKppchh/UpP+iMYXamfLj3sogAI b/Fb8drxjux6ATwflnSF7tMtDKFS5r7d6g== X-Google-Smtp-Source: ABdhPJzcx6XKRkhlGQEGnNBK9sTlPxZap2TWqCwx24Uvq6gyUKoCCpT28whgCMXvS+N9E7dqP+t5aQ== X-Received: by 2002:a63:a50e:0:b0:3c6:d417:6704 with SMTP id n14-20020a63a50e000000b003c6d4176704mr4793374pgf.526.1652162710796; Mon, 09 May 2022 23:05:10 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 4/6] libxl: arm: Split make_virtio_mmio_node() Date: Tue, 10 May 2022 11:34:49 +0530 Message-Id: <65dfe45db3829990335c0c5307d4bcfb40647986.1652162646.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit make_virtio_mmio_node() creates the DT node for simple MMIO devices currently, i.e. the ones that don't require any additional properties. In order to allow using it for other complex device types, split the functionality into two, one where the fdt node isn't closed and the other one to create a simple DT node. Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 6b95ded82dc3..3a038d388cf0 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -872,8 +872,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, } -static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, - uint64_t base, uint32_t irq) +static int make_virtio_mmio_node_common(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq) { int res; gic_interrupt intr; @@ -895,13 +895,18 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property_interrupts(gc, fdt, &intr, 1); if (res) return res; - res = fdt_property(fdt, "dma-coherent", NULL, 0); - if (res) return res; + return fdt_property(fdt, "dma-coherent", NULL, 0); +} - res = fdt_end_node(fdt); +static int make_virtio_mmio_node_simple(libxl__gc *gc, void *fdt, uint64_t base, + uint32_t irq) +{ + int res; + + res = make_virtio_mmio_node_common(gc, fdt, base, irq); if (res) return res; - return 0; + return fdt_end_node(fdt); } static const struct arch_info *get_arch_info(libxl__gc *gc, @@ -1216,7 +1221,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) - FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base, disk->irq) ); } if (pfdt) -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325179.547655 (Exim 4.92) (envelope-from ) id 1noIzg-0008TC-Eo; Tue, 10 May 2022 06:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325179.547655; Tue, 10 May 2022 06:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzg-0008QY-6C; Tue, 10 May 2022 06:05:12 +0000 Received: by outflank-mailman (input) for mailman id 325179; Tue, 10 May 2022 06:05:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIze-0007ob-TK for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:11 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25223eee-d027-11ec-a406-831a346695d4; Tue, 10 May 2022 08:05:09 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so1176648pjb.3 for ; Mon, 09 May 2022 23:05:09 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id g17-20020a170902d5d100b0015e8d4eb1f0sm1027055plh.58.2022.05.09.23.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25223eee-d027-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=svVS82OvBdmvv7JLfSbwnD8mRf2Q0xw4MKyZG61zwPs=; b=bZHc71ib68Kyd06jqtULLoUCaA3zns/ci74fepqyPN3W8EsEXTQcdBKGX1HPQ1u1/h U7YfPdGh8YBaWTrGEEHDS/ma/YUWpv4Jv3+RKulsB9cWgKHacDoHGaSz6FwBKNVPjDj1 AzuzYPvDkEe9YyCuSGzeh1Kx5PdBaO+zzQgXkphqf9xX2cVMr4Ea9OBMsBeuClFxup1k ESpZwGz+8FTsGWOV+VzjaWO0Czk6dA8ETlBi+1VaiMfQ/Hud/0tvof9yXgP7NuT/WIG4 /j3FvDFe9t25WEr9yb1zgRBSeDd620fn9u6+UAkPS4yFqhZpGSqdB1U4r6/kEvbs2EgZ Ezuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=svVS82OvBdmvv7JLfSbwnD8mRf2Q0xw4MKyZG61zwPs=; b=nTzvYPlP0AWNuH2p/llEe97CdN6Dcdn+VSWW4Ht/0S/4gnOqFNbEOkun7igIFLULGq b/psYNC/2hjlXbgg8EV+y2Umx/dohdnIemhbEob84OEroILcC5tZk0pPbxEgoZ901PZQ MgLwmZaBXhDP66lu26LKQFBjpVT2A2yH7kHYanb1fcmnEH9hVmmtrDnzdizHnpZUSR4l 3tT1kDV3hPxlxzsqNz8SWNsgULkoH6gvdep5/WwgUTa+JSEB2WAlF1qj2P50BJOc6br+ 9Rc9wie0ofjasgqvu1/5reoV03/v7wdPUU5B7S2qzWWvvgWeOwBkoKvu8CS8EhvpI9M0 VuSg== X-Gm-Message-State: AOAM532BLOLGrvtVJyriGc6F2Uk9R6XSkOTYnCPTwrYBT++xok+Q+TYP 20Jq+iKTTtJKmJ2cdFnwGp67BGcvmL7cgA== X-Google-Smtp-Source: ABdhPJw0NKJ4Q/0dkxs8PCIcoIpZRhB2dwZKfpWje1lHYFkWpSYYwaA1BNIRtzlezkm2oH3TFk6mBw== X-Received: by 2002:a17:902:a981:b0:156:229d:6834 with SMTP id bh1-20020a170902a98100b00156229d6834mr18791093plb.128.1652162708233; Mon, 09 May 2022 23:05:08 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall , Oleksandr Tyshchenko Subject: [PATCH V2 3/6] libxl: arm: Create alloc_virtio_mmio_params() Date: Tue, 10 May 2022 11:34:48 +0530 Message-Id: <32fa4a77c76187f68b074ff1cc81d8de5f683638.1652162646.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a separate routine to allocate base and irq for a device as the same code will be required for each device type. Suggested-by: Oleksandr Tyshchenko Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 41 +++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 37403a2cebb1..6b95ded82dc3 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -48,6 +48,24 @@ static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq) return irq; } +static int alloc_virtio_mmio_params(libxl__gc *gc, uint64_t *base, + uint32_t *irq, uint64_t *virtio_mmio_base, + uint32_t *virtio_mmio_irq) +{ + *base = alloc_virtio_mmio_base(gc, virtio_mmio_base); + if (!*base) + return ERROR_FAIL; + + *irq = alloc_virtio_mmio_irq(gc, virtio_mmio_irq); + if (!*irq) + return ERROR_FAIL; + + LOG(DEBUG, "Allocate Virtio MMIO params: IRQ %u BASE 0x%"PRIx64, *irq, + *base); + + return 0; +} + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -85,25 +103,18 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { - disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); - if (!disk->base) - return ERROR_FAIL; - - disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); - if (!disk->irq) - return ERROR_FAIL; - - if (virtio_irq < disk->irq) - virtio_irq = disk->irq; - virtio_enabled = true; - - LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, - disk->vdev, disk->irq, disk->base); + int rc = alloc_virtio_mmio_params(gc, &disk->base, &disk->irq, + &virtio_mmio_base, &virtio_mmio_irq); + if (rc) + return rc; } } - if (virtio_enabled) + if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { + virtio_irq = virtio_mmio_irq - 1; nr_spis += (virtio_irq - 32) + 1; + virtio_enabled = true; + } for (i = 0; i < d_config->b_info.num_irqs; i++) { uint32_t irq = d_config->b_info.irqs[i]; -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325181.547681 (Exim 4.92) (envelope-from ) id 1noIzk-0000oB-TZ; Tue, 10 May 2022 06:05:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325181.547681; Tue, 10 May 2022 06:05:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzk-0000nu-Q1; Tue, 10 May 2022 06:05:16 +0000 Received: by outflank-mailman (input) for mailman id 325181; Tue, 10 May 2022 06:05:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzj-0007z7-DY for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:15 +0000 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [2607:f8b0:4864:20::1035]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21985c21-d027-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 08:05:03 +0200 (CEST) Received: by mail-pj1-x1035.google.com with SMTP id qe3-20020a17090b4f8300b001dc24e4da73so1083663pjb.1 for ; Mon, 09 May 2022 23:05:14 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id w25-20020a637b19000000b003c659b92b8fsm6944713pgc.32.2022.05.09.23.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21985c21-d027-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ao4t6jWg9wZG5OnDiYaWDYf/ncDqRjTgOzFX6e4AW7A=; b=UPx3Q2aoAHaO3I1yFQqVelKV/6W5jaFEHonFI7K1vNYNSPZkKKorN4QpzncTrf/2+q oUX0TV661jcRoXXPwoBVkN0rhopAQv4JB2iwi8/fJGkoQXFV+W3u5X6ik1UyxhgOS440 RVyiptw3alpJWWCv9Gi5behftA8O/ZlTpM2ZSeDh0tzVbWozho5AiN/BuyPQKi9dEjw8 yvgFl8NHEv75UfxAT99tj1NuEj3fJzgzH+KbIxN3dVE+gOIWjecxz2oN4xJucv5cam4L EkZ9qlIlNkekjeF63g93oIWXfGIniHiIBEwaBFLXy/irr7WwfL0tTzjFkFvzILpfBE8x cC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ao4t6jWg9wZG5OnDiYaWDYf/ncDqRjTgOzFX6e4AW7A=; b=oQ7PWMxN2PyQtoCVIbQh1TD2NGeA1lDRlHAVwIyO5/R8bPc2JUCr8vpxBxyoUFylcv iOYbF91PvBy51n0N5/Pwcvy5A/vYidDge3Kp4hWRvXFiET7K4bpb7aH+J8ZvtXfLKn2S PkeBMTjt+wAWZhuD1fHlC4b1ND97pKbgRX6CU3OcGWy5/nU5hivwlLpJNUmYY/aV/JZx KO2PO50uWF7oc7EFt3CDJr+M+PWaulHQxcQxccoPJFcAO9BGmSwvAEh9XD1UhbyeIytS +dsMACc1UYwwhD6uYq+qvU8y2Kf2aoGnE/1MkSjjMEXLsjHsgSqqkSauftgHDS4xIoJ0 IBhA== X-Gm-Message-State: AOAM532kKwptW2VeUUrfTVM1aJ7e9t0ML9ZR/Z3FaPifYTk+kjKpDZ/K z9+2h9bUPUhb6L9y5DTtq3q/GWIXX11h3Q== X-Google-Smtp-Source: ABdhPJyfZUHybYDgF9ZHX0pJJsJ84E9YhfxmEXMI2wt9ElM159gGUSMwD5S4ScHo0c4LarwHE9MEYw== X-Received: by 2002:a17:90a:d308:b0:1dc:eff1:d74e with SMTP id p8-20020a17090ad30800b001dceff1d74emr15672286pju.109.1652162713277; Mon, 09 May 2022 23:05:13 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 5/6] libxl: Allocate MMIO params for I2c device and update DT Date: Tue, 10 May 2022 11:34:50 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree based on Virtio I2C DT bindings [1]. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/i2c/i2c-virtio.yaml Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 3a038d388cf0..d085c7cf4dbd 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -110,6 +110,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, } } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + + int rc = alloc_virtio_mmio_params(gc, &i2c->base, &i2c->irq, + &virtio_mmio_base, &virtio_mmio_irq); + if (rc) + return rc; + } + if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { virtio_irq = virtio_mmio_irq - 1; nr_spis += (virtio_irq - 32) + 1; @@ -909,6 +918,26 @@ static int make_virtio_mmio_node_simple(libxl__gc *gc, void *fdt, uint64_t base, return fdt_end_node(fdt); } +static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + + res = make_virtio_mmio_node_common(gc, fdt, base, irq); + if (res) return res; + + res = fdt_begin_node(fdt, "i2c"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device22"); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return fdt_end_node(fdt); +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -1224,6 +1253,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base, disk->irq) ); } + for (i = 0; i < d_config->num_i2cs; i++) { + libxl_device_i2c *i2c = &d_config->i2cs[i]; + FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); + } + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325176.547625 (Exim 4.92) (envelope-from ) id 1noIza-0007oo-2u; Tue, 10 May 2022 06:05:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325176.547625; Tue, 10 May 2022 06:05:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzZ-0007oh-Vw; Tue, 10 May 2022 06:05:05 +0000 Received: by outflank-mailman (input) for mailman id 325176; Tue, 10 May 2022 06:05:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzY-0007ob-UV for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:05 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20081880-d027-11ec-a406-831a346695d4; Tue, 10 May 2022 08:05:03 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id n8so15878622plh.1 for ; Mon, 09 May 2022 23:05:01 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id g8-20020aa78748000000b0050dc762817bsm9630965pfo.85.2022.05.09.23.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:04:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20081880-d027-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3A4Fz3icoaqYWOy0LXYpOvOE150j94z1YZl1bmEKoNY=; b=O6C+Vqls72T9sdXBXiucliRUx7XAxZXGb7ihjbS8Kg2fZIakaY2CZMe+1rh3VHvstU p1UkcJAWp9+NnhK++ho5/nWLZcK5BuCeoI/RR5FrLK6Q6SCCoUf6sEXA1hSuEg5tZMnS V0IqlxtgAg2pMEACpqea84OQdACAIsvSuLP5jH5W43k2D07tAjeAnN+0QAh1+W+Vv+cS BJ3LfL+sDtFkb+BiwxZUDtFm8tuYv3l5+vBTytFq0WHbY2FHEqc9Hiyl2AGR3eve3D48 tS/W23eB2z8swj32XBv5C2DsQzTnVajd/LA29GTJqY90NUQiscLn44c9sW/1xgEQQY0Y rExQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3A4Fz3icoaqYWOy0LXYpOvOE150j94z1YZl1bmEKoNY=; b=QFUXf2RW0jNdnaARxLfkOGuWMPxMz7T2cyr4Le7ms/JwMiwzV1Ces7bWhmDyWRk6gB UAo3oeSmFq7Nb5UJ5bWVdPecGfFmZXqya7XbPPE05HNLvzGH/sVdk5ChMRW1gn53arkP 0I4Poor7xXnOk0QiauHT7y7yPBT4EZg4dQenArW3xapUVwEf4qSyyM0qhRnNgY9Q4Ojs T42eiComvHaNGmpyY9tdo4Us+6Vx6sZl75BV31liC9drqCNWcP3FZLAwH94v5h/wQp6D DvQpiQyfo91ix2MFSxhfwdF4gNwkVkCCSJ2cShfQs5peoAtny/wgRs7qc4Ds6hihPHuh QCJQ== X-Gm-Message-State: AOAM530xKUrM2aioTOJ8WoMVGjvUlbNhJLuvYxTaYTfyUZWqL9c6FVrt i8XylQIDdj9hURw0I2vcyXPQoAFhq8MCBg== X-Google-Smtp-Source: ABdhPJwCxRkKD10uDYmbJ335yA9KSzlH1ygVEJjIIhfvKzTcSCFySjE4bus3nOl/WhJQZ5UigtrR9A== X-Received: by 2002:a17:902:e851:b0:15e:93ac:41db with SMTP id t17-20020a170902e85100b0015e93ac41dbmr19320885plg.26.1652162699592; Mon, 09 May 2022 23:04:59 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 0/6] Virtio toolstack support for I2C and GPIO on Arm Date: Tue, 10 May 2022 11:34:45 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This patchset adds toolstack support for I2C and GPIO virtio devices. This is inspired from the work done by Oleksandr for the Disk device [1]. The first two patches can be applied right away, while the last four need Oleksandr's series [1] to be applied first. This is developed as part of Linaro's Project Stratos, where we are working towards Hypervisor agnostic Rust based backend [2]. I must accept that I am a beginner to Xen and developed this patchset based on support for existing devices like Disk or Keyboard. There may be bits which I missed or the one I added which aren't really required. Thanks. -- Viresh [1] https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ [2] https://lore.kernel.org/xen-devel/20220414092358.kepxbmnrtycz7mhe@vireshk-i7/ Viresh Kumar (6): libxl: Add support for Virtio I2C device libxl: Add support for Virtio GPIO device libxl: arm: Create alloc_virtio_mmio_params() libxl: arm: Split make_virtio_mmio_node() libxl: Allocate MMIO params for I2c device and update DT libxl: Allocate MMIO params for GPIO device and update DT tools/golang/xenlight/helpers.gen.go | 220 ++++++++++++++++++++ tools/golang/xenlight/types.gen.go | 54 +++++ tools/include/libxl.h | 64 ++++++ tools/include/libxl_utils.h | 6 + tools/libs/light/Makefile | 2 + tools/libs/light/libxl_arm.c | 132 ++++++++++-- tools/libs/light/libxl_create.c | 26 +++ tools/libs/light/libxl_dm.c | 34 +++- tools/libs/light/libxl_gpio.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_i2c.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 52 +++++ tools/libs/light/libxl_types_internal.idl | 2 + tools/ocaml/libs/xl/genwrap.py | 2 + tools/ocaml/libs/xl/xenlight_stubs.c | 2 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 6 + tools/xl/xl_cmdtable.c | 30 +++ tools/xl/xl_gpio.c | 143 +++++++++++++ tools/xl/xl_i2c.c | 143 +++++++++++++ tools/xl/xl_parse.c | 160 +++++++++++++++ tools/xl/xl_parse.h | 2 + tools/xl/xl_sxp.c | 4 + 23 files changed, 1539 insertions(+), 21 deletions(-) create mode 100644 tools/libs/light/libxl_gpio.c create mode 100644 tools/libs/light/libxl_i2c.c create mode 100644 tools/xl/xl_gpio.c create mode 100644 tools/xl/xl_i2c.c -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325178.547648 (Exim 4.92) (envelope-from ) id 1noIzf-0008LN-Qk; Tue, 10 May 2022 06:05:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325178.547648; Tue, 10 May 2022 06:05:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzf-0008LG-M0; Tue, 10 May 2022 06:05:11 +0000 Received: by outflank-mailman (input) for mailman id 325178; Tue, 10 May 2022 06:05:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzd-0007ob-TE for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:10 +0000 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [2607:f8b0:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23aae201-d027-11ec-a406-831a346695d4; Tue, 10 May 2022 08:05:07 +0200 (CEST) Received: by mail-pg1-x52b.google.com with SMTP id s16so3726784pgs.3 for ; Mon, 09 May 2022 23:05:07 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id u67-20020a626046000000b0050dc762814esm9751334pfb.40.2022.05.09.23.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23aae201-d027-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HyzuOp/tvITGfFX9GJge8V/26LSsI0eF8GbficmNu7U=; b=M67x4/R6jdy471wEvDx2Ve38kbtBlyYrBJXglB/TFrMRgV1dBgfFZK8iIqQ2Ket3VS o67j+LHFwD4JxoM/NhqQPry9PFxr/pl/XwgRMbtjL9Nrf+Vw+B5M0cD6ci0s4AIzivSW yfVNhsjgLuC0EQEO/jiBjc+2WTTyyOzDrPt2HlsYie06sDeQ2Sep8PIrpw8vg/dqokJv FPbfmcUcqOsI/N7aYBrgLoZZxMMwSwpDAMON4qftJbqCheNLaO52rp+n2JbyMNc/e/vd tP61jErQOkjzzzaQhtbfyPWKkYKihCuPZIKM6KJiQwztqUKRK65kXFOVw+Wy/VDJ3G/S pxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HyzuOp/tvITGfFX9GJge8V/26LSsI0eF8GbficmNu7U=; b=cjDOYvihfifQCsuXZtg8Ux1nBAQYqSJVna0qhV4SjKQcWt5Whc/LyVTpiG0KEsTuH2 NfVQwIF3ip8r1qsj/feexYokyoxZkMmoynFzoe8kc3vhePa4NlJfxI9bkGjucQMN2XgU Tagp2+YZqJi/VPpjeLaXSdf1yu6iQmA7KKFxr0GHznbmG51wISR+s9QZCgTBqRA9cfZS 32QT3dYzkOnG7dVL/ClFfEPG7Pnr4+yopcJkworfIqrVmMPt/djV6Dt56lZ4QlNRDVsT No8RSVbeWD1sQSqOWC/0BBjQBpQBzhsgyX8WkYNmhWYSQMcriuJPJWmicqzMV1/okTXf nzhg== X-Gm-Message-State: AOAM533YI6yLlidOK+8AOqMP2wXM4gmgF37pUdBz2lxskLFag/aiSHzl aJN0U6iM0ueeE8c3tcCYI6uG43zcufE25Q== X-Google-Smtp-Source: ABdhPJyNA//hYlvOjkaQBC1aLhOM4ZNdmASuAYyWnwX7TpT86LK5x4woDWmunCqOZS2h/Fm76aQWUQ== X-Received: by 2002:a63:e155:0:b0:3c6:7514:6c0d with SMTP id h21-20020a63e155000000b003c675146c0dmr11777055pgk.249.1652162705486; Mon, 09 May 2022 23:05:05 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 2/6] libxl: Add support for Virtio GPIO device Date: Tue, 10 May 2022 11:34:47 +0530 Message-Id: <48d5e96ab0f1c1e85f77144e31ca199e04c00e9b.1652162646.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds basic support for configuring and assisting virtio-mmio based virtio-gpio backend (emualator) which is intended to run out of Qemu and could be run in any domain. An example of domain configuration for Virtio Gpio: gpio = [ "" ] Please note, this patch is not enough for virtio-gpio to work on Xen (Arm), as for every Virtio device we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. A subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. Signed-off-by: Viresh Kumar --- tools/golang/xenlight/helpers.gen.go | 110 ++++++++++ tools/golang/xenlight/types.gen.go | 27 +++ tools/include/libxl.h | 32 +++ tools/include/libxl_utils.h | 3 + tools/libs/light/Makefile | 1 + tools/libs/light/libxl_create.c | 13 ++ tools/libs/light/libxl_dm.c | 17 +- tools/libs/light/libxl_gpio.c | 236 ++++++++++++++++++++++ tools/libs/light/libxl_internal.h | 1 + tools/libs/light/libxl_types.idl | 26 +++ tools/libs/light/libxl_types_internal.idl | 1 + tools/ocaml/libs/xl/genwrap.py | 1 + tools/ocaml/libs/xl/xenlight_stubs.c | 1 + tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_gpio.c | 143 +++++++++++++ tools/xl/xl_parse.c | 80 ++++++++ tools/xl/xl_parse.h | 1 + tools/xl/xl_sxp.c | 2 + 20 files changed, 713 insertions(+), 2 deletions(-) create mode 100644 tools/libs/light/libxl_gpio.c create mode 100644 tools/xl/xl_gpio.c diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index ad23b0969abd..ed880cad3fa7 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1215,6 +1215,9 @@ x.Usbdevice = C.GoString(tmp.usbdevice) if err := x.VkbDevice.fromC(&tmp.vkb_device);err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := x.GpioDevice.fromC(&tmp.gpio_device);err != nil { +return fmt.Errorf("converting field GpioDevice: %v", err) +} if err := x.I2cDevice.fromC(&tmp.i2c_device);err != nil { return fmt.Errorf("converting field I2cDevice: %v", err) } @@ -1535,6 +1538,9 @@ hvm.usbdevice = C.CString(tmp.Usbdevice)} if err := tmp.VkbDevice.toC(&hvm.vkb_device); err != nil { return fmt.Errorf("converting field VkbDevice: %v", err) } +if err := tmp.GpioDevice.toC(&hvm.gpio_device); err != nil { +return fmt.Errorf("converting field GpioDevice: %v", err) +} if err := tmp.I2cDevice.toC(&hvm.i2c_device); err != nil { return fmt.Errorf("converting field I2cDevice: %v", err) } @@ -1728,6 +1734,46 @@ xc.multi_touch_num_contacts = C.uint32_t(x.MultiTouchNumContacts) return nil } +// NewDeviceGpio returns an instance of DeviceGpio initialized with defaults. +func NewDeviceGpio() (*DeviceGpio, error) { +var ( +x DeviceGpio +xc C.libxl_device_gpio) + +C.libxl_device_gpio_init(&xc) +defer C.libxl_device_gpio_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *DeviceGpio) fromC(xc *C.libxl_device_gpio) error { + x.BackendDomid = Domid(xc.backend_domid) +x.BackendDomname = C.GoString(xc.backend_domname) +x.Devid = Devid(xc.devid) +x.BackendType = GpioBackend(xc.backend_type) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) + + return nil} + +func (x *DeviceGpio) toC(xc *C.libxl_device_gpio) (err error){defer func(){ +if err != nil{ +C.libxl_device_gpio_dispose(xc)} +}() + +xc.backend_domid = C.libxl_domid(x.BackendDomid) +if x.BackendDomname != "" { +xc.backend_domname = C.CString(x.BackendDomname)} +xc.devid = C.libxl_devid(x.Devid) +xc.backend_type = C.libxl_gpio_backend(x.BackendType) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) + + return nil + } + // NewDeviceI2c returns an instance of DeviceI2c initialized with defaults. func NewDeviceI2c() (*DeviceI2c, error) { var ( @@ -2881,6 +2927,15 @@ if err := x.Vkbs[i].fromC(&v); err != nil { return fmt.Errorf("converting field Vkbs: %v", err) } } } +x.Gpios = nil +if n := int(xc.num_gpios); n > 0 { +cGpios := (*[1<<28]C.libxl_device_gpio)(unsafe.Pointer(xc.gpios))[:n:n] +x.Gpios = make([]DeviceGpio, n) +for i, v := range cGpios { +if err := x.Gpios[i].fromC(&v); err != nil { +return fmt.Errorf("converting field Gpios: %v", err) } +} +} x.I2cs = nil if n := int(xc.num_i2cs); n > 0 { cI2cs := (*[1<<28]C.libxl_device_i2c)(unsafe.Pointer(xc.i2cs))[:n:n] @@ -3051,6 +3106,16 @@ return fmt.Errorf("converting field Vkbs: %v", err) } } } +if numGpios := len(x.Gpios); numGpios > 0 { +xc.gpios = (*C.libxl_device_gpio)(C.malloc(C.ulong(numGpios)*C.sizeof_libxl_device_gpio)) +xc.num_gpios = C.int(numGpios) +cGpios := (*[1<<28]C.libxl_device_gpio)(unsafe.Pointer(xc.gpios))[:numGpios:numGpios] +for i,v := range x.Gpios { +if err := v.toC(&cGpios[i]); err != nil { +return fmt.Errorf("converting field Gpios: %v", err) +} +} +} if numI2cs := len(x.I2cs); numI2cs > 0 { xc.i2cs = (*C.libxl_device_i2c)(C.malloc(C.ulong(numI2cs)*C.sizeof_libxl_device_i2c)) xc.num_i2cs = C.int(numI2cs) @@ -3748,6 +3813,51 @@ if err != nil{ C.libxl_vkbinfo_dispose(xc)} }() +if x.Backend != "" { +xc.backend = C.CString(x.Backend)} +xc.backend_id = C.uint32_t(x.BackendId) +if x.Frontend != "" { +xc.frontend = C.CString(x.Frontend)} +xc.frontend_id = C.uint32_t(x.FrontendId) +xc.devid = C.libxl_devid(x.Devid) +xc.state = C.int(x.State) +xc.evtch = C.int(x.Evtch) +xc.rref = C.int(x.Rref) + + return nil + } + +// NewGpioinfo returns an instance of Gpioinfo initialized with defaults. +func NewGpioinfo() (*Gpioinfo, error) { +var ( +x Gpioinfo +xc C.libxl_gpioinfo) + +C.libxl_gpioinfo_init(&xc) +defer C.libxl_gpioinfo_dispose(&xc) + +if err := x.fromC(&xc); err != nil { +return nil, err } + +return &x, nil} + +func (x *Gpioinfo) fromC(xc *C.libxl_gpioinfo) error { + x.Backend = C.GoString(xc.backend) +x.BackendId = uint32(xc.backend_id) +x.Frontend = C.GoString(xc.frontend) +x.FrontendId = uint32(xc.frontend_id) +x.Devid = Devid(xc.devid) +x.State = int(xc.state) +x.Evtch = int(xc.evtch) +x.Rref = int(xc.rref) + + return nil} + +func (x *Gpioinfo) toC(xc *C.libxl_gpioinfo) (err error){defer func(){ +if err != nil{ +C.libxl_gpioinfo_dispose(xc)} +}() + if x.Backend != "" { xc.backend = C.CString(x.Backend)} xc.backend_id = C.uint32_t(x.BackendId) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index c232e4811ac3..cb959d5fa87a 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -241,6 +241,11 @@ VkbBackendQemu VkbBackend = 1 VkbBackendLinux VkbBackend = 2 ) +type GpioBackend int +const( +GpioBackendVirtio GpioBackend = 0 +) + type I2cBackend int const( I2cBackendVirtio I2cBackend = 0 @@ -573,6 +578,7 @@ Usb Defbool Usbversion int Usbdevice string VkbDevice Defbool +GpioDevice Defbool I2cDevice Defbool Soundhw string XenPlatformPci Defbool @@ -636,6 +642,15 @@ MultiTouchHeight uint32 MultiTouchNumContacts uint32 } +type DeviceGpio struct { +BackendDomid Domid +BackendDomname string +Devid Devid +BackendType GpioBackend +Irq uint32 +Base uint64 +} + type DeviceI2c struct { BackendDomid Domid BackendDomname string @@ -928,6 +943,7 @@ Rdms []DeviceRdm Dtdevs []DeviceDtdev Vfbs []DeviceVfb Vkbs []DeviceVkb +Gpios []DeviceGpio I2cs []DeviceI2c Vtpms []DeviceVtpm P9S []DeviceP9 @@ -1083,6 +1099,17 @@ Evtch int Rref int } +type Gpioinfo struct { +Backend string +BackendId uint32 +Frontend string +FrontendId uint32 +Devid Devid +State int +Evtch int +Rref int +} + type I2cinfo struct { Backend string BackendId uint32 diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 4d19194c3dc2..f2fe616dee18 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -800,6 +800,15 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_BUILDINFO_VKB_DEVICE 1 +/* + * LIBXL_HAVE_BUILDINFO_GPIO_DEVICE + * + * If this is defined, then the libxl_domain_build_info structure will + * contain a boolean hvm.gpio_device which instructs libxl whether to include + * a gpio at build time or not. + */ +#define LIBXL_HAVE_BUILDINFO_GPIO_DEVICE 1 + /* * LIBXL_HAVE_BUILDINFO_I2C_DEVICE * @@ -2377,6 +2386,29 @@ int libxl_device_vkb_getinfo(libxl_ctx *ctx, uint32_t domid, libxl_vkbinfo *vkbinfo) LIBXL_EXTERNAL_CALLERS_ONLY; +/* GPIO */ +int libxl_device_gpio_add(libxl_ctx *ctx, uint32_t domid, libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_remove(libxl_ctx *ctx, uint32_t domid, + libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_destroy(libxl_ctx *ctx, uint32_t domid, + libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) + LIBXL_EXTERNAL_CALLERS_ONLY; + +libxl_device_gpio *libxl_device_gpio_list(libxl_ctx *ctx, + uint32_t domid, int *num) + LIBXL_EXTERNAL_CALLERS_ONLY; +void libxl_device_gpio_list_free(libxl_device_gpio* list, int num) + LIBXL_EXTERNAL_CALLERS_ONLY; +int libxl_device_gpio_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_gpio *gpio, + libxl_gpioinfo *gpioinfo) + LIBXL_EXTERNAL_CALLERS_ONLY; + /* I2C */ int libxl_device_i2c_add(libxl_ctx *ctx, uint32_t domid, libxl_device_i2c *i2c, const libxl_asyncop_how *ao_how) diff --git a/tools/include/libxl_utils.h b/tools/include/libxl_utils.h index 72b7796b7e4b..91f5c68172cb 100644 --- a/tools/include/libxl_utils.h +++ b/tools/include/libxl_utils.h @@ -83,6 +83,9 @@ int libxl_devid_to_device_usbctrl(libxl_ctx *ctx, uint32_t domid, int libxl_devid_to_device_vkb(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_vkb *vkb); +int libxl_devid_to_device_gpio(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_gpio *gpio); + int libxl_devid_to_device_i2c(libxl_ctx *ctx, uint32_t domid, int devid, libxl_device_i2c *i2c); diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index dca46846e586..6caa15cc1148 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -112,6 +112,7 @@ SRCS-y += libxl_vdispl.c SRCS-y += libxl_pvcalls.c SRCS-y += libxl_vsnd.c SRCS-y += libxl_vkb.c +SRCS-y += libxl_gpio.c SRCS-y += libxl_i2c.c SRCS-y += libxl_genid.c SRCS-y += _libxl_types.c diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index d604171e504c..836d43bd3f03 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -363,6 +363,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_defbool_setdefault(&b_info->u.hvm.altp2m, false); libxl_defbool_setdefault(&b_info->u.hvm.usb, false); libxl_defbool_setdefault(&b_info->u.hvm.vkb_device, true); + libxl_defbool_setdefault(&b_info->u.hvm.gpio_device, true); libxl_defbool_setdefault(&b_info->u.hvm.i2c_device, true); libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); @@ -1756,6 +1757,7 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl__device_console console; libxl__device device; libxl_device_vkb vkb; + libxl_device_gpio gpio; libxl_device_i2c i2c; init_console_info(gc, &console, 0); @@ -1769,6 +1771,12 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, libxl_device_vkb_dispose(&vkb); } + if (libxl_defbool_val(d_config->b_info.u.hvm.gpio_device)) { + libxl_device_gpio_init(&gpio); + libxl__device_add(gc, domid, &libxl__gpio_devtype, &gpio); + libxl_device_gpio_dispose(&gpio); + } + if (libxl_defbool_val(d_config->b_info.u.hvm.i2c_device)) { libxl_device_i2c_init(&i2c); libxl__device_add(gc, domid, &libxl__i2c_devtype, &i2c); @@ -1807,6 +1815,11 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev, &d_config->vkbs[i]); } + for (i = 0; i < d_config->num_gpios; i++) { + libxl__device_add(gc, domid, &libxl__gpio_devtype, + &d_config->gpios[i]); + } + for (i = 0; i < d_config->num_i2cs; i++) { libxl__device_add(gc, domid, &libxl__i2c_devtype, &d_config->i2cs[i]); diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 9340ae4628a2..124b73f1dd00 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -2096,6 +2096,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, const libxl_domain_config *guest_config, libxl_device_vfb *vfb, libxl_device_vkb *vkb, + libxl_device_gpio *gpio, libxl_device_i2c *i2c) { const libxl_domain_build_info *b_info = &guest_config->b_info; @@ -2105,6 +2106,7 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, libxl_device_vfb_init(vfb); libxl_device_vkb_init(vkb); + libxl_device_gpio_init(gpio); libxl_device_i2c_init(i2c); vfb->backend_domid = 0; @@ -2116,6 +2118,9 @@ static int libxl__vfb_and_vkb_from_hvm_guest_config(libxl__gc *gc, vkb->backend_domid = 0; vkb->devid = 0; + gpio->backend_domid = 0; + gpio->devid = 0; + i2c->backend_domid = 0; i2c->devid = 0; @@ -2281,6 +2286,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) int ret; libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; char **args; struct xs_permissions perm[2]; @@ -2354,12 +2360,15 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) || libxl_defbool_val(guest_config->b_info.u.hvm.sdl.enable)) { GCNEW(vfb); GCNEW(vkb); + GCNEW(gpio); GCNEW(i2c); - libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, i2c); + libxl__vfb_and_vkb_from_hvm_guest_config(gc, guest_config, vfb, vkb, gpio, i2c); dm_config->vfbs = vfb; dm_config->num_vfbs = 1; dm_config->vkbs = vkb; dm_config->num_vkbs = 1; + dm_config->gpios = gpio; + dm_config->num_gpios = 1; dm_config->i2cs = i2c; dm_config->num_i2cs = 1; } @@ -2503,6 +2512,12 @@ static void spawn_stub_launch_dm(libxl__egc *egc, if (ret) goto out; } + if (dm_config->num_gpios) { + ret = libxl__device_add(gc, dm_domid, &libxl__gpio_devtype, + &dm_config->gpios[0]); + if (ret) goto out; + } + if (dm_config->num_i2cs) { ret = libxl__device_add(gc, dm_domid, &libxl__i2c_devtype, &dm_config->i2cs[0]); diff --git a/tools/libs/light/libxl_gpio.c b/tools/libs/light/libxl_gpio.c new file mode 100644 index 000000000000..2bf68deb3850 --- /dev/null +++ b/tools/libs/light/libxl_gpio.c @@ -0,0 +1,236 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_internal.h" + +#include + +static int libxl__device_gpio_setdefault(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *gpio, bool hotplug) +{ + if (gpio->backend_type != LIBXL_GPIO_BACKEND_VIRTIO) { + gpio->backend_type = LIBXL_GPIO_BACKEND_VIRTIO; + } + + return libxl__resolve_domid(gc, gpio->backend_domname, &gpio->backend_domid); +} + +static int libxl__device_gpio_dm_needed(void *e, uint32_t domid) +{ + libxl_device_gpio *elem = e; + + return elem->backend_type == LIBXL_GPIO_BACKEND_VIRTIO; +} + +static int libxl__set_xenstore_gpio(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *gpio, + flexarray_t *back, flexarray_t *front, + flexarray_t *ro_front) +{ + flexarray_append_pair(back, "irq", GCSPRINTF("%u", gpio->irq)); + flexarray_append_pair(back, "base", GCSPRINTF("%lu", gpio->base)); + + flexarray_append_pair(front, "irq", GCSPRINTF("%u", gpio->irq)); + flexarray_append_pair(front, "base", GCSPRINTF("%lu", gpio->base)); + + return 0; +} + +static int libxl__gpio_from_xenstore(libxl__gc *gc, const char *libxl_path, + libxl_devid devid, + libxl_device_gpio *gpio) +{ + const char *be_path, *fe_path, *tmp; + libxl__device dev; + int rc; + + gpio->devid = devid; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) goto out; + + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + &fe_path); + if (rc) goto out; + + rc = libxl__backendpath_parse_domid(gc, be_path, &gpio->backend_domid); + if (rc) goto out; + + rc = libxl__parse_backend_path(gc, be_path, &dev); + if (rc) goto out; + + gpio->backend_type = LIBXL_GPIO_BACKEND_VIRTIO; + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/irq", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + gpio->irq = strtoul(tmp, NULL, 0); + } + + rc = libxl__xs_read_checked(gc, XBT_NULL, + GCSPRINTF("%s/base", be_path), &tmp); + if (rc) goto out; + + if (tmp) { + gpio->base = strtoul(tmp, NULL, 0); + } + + rc = 0; + +out: + + return rc; +} + +static int libxl__device_from_gpio(libxl__gc *gc, uint32_t domid, + libxl_device_gpio *type, libxl__device *device) +{ + device->backend_devid = type->devid; + device->backend_domid = type->backend_domid; + device->backend_kind = LIBXL__DEVICE_KIND_GPIO; + device->devid = type->devid; + device->domid = domid; + device->kind = LIBXL__DEVICE_KIND_GPIO; + + return 0; +} + +int libxl_device_gpio_add(libxl_ctx *ctx, uint32_t domid, libxl_device_gpio *gpio, + const libxl_asyncop_how *ao_how) +{ + AO_CREATE(ctx, domid, ao_how); + int rc; + + rc = libxl__device_add(gc, domid, &libxl__gpio_devtype, gpio); + if (rc) { + LOGD(ERROR, domid, "Unable to add gpio device"); + goto out; + } + +out: + libxl__ao_complete(egc, ao, rc); + return AO_INPROGRESS; +} + +int libxl_devid_to_device_gpio(libxl_ctx *ctx, uint32_t domid, + int devid, libxl_device_gpio *gpio) +{ + GC_INIT(ctx); + + libxl_device_gpio *gpios = NULL; + int n, i; + int rc; + + libxl_device_gpio_init(gpio); + + gpios = libxl__device_list(gc, &libxl__gpio_devtype, domid, &n); + + if (!gpios) { rc = ERROR_NOTFOUND; goto out; } + + for (i = 0; i < n; ++i) { + if (devid == gpios[i].devid) { + libxl_device_gpio_copy(ctx, gpio, &gpios[i]); + rc = 0; + goto out; + } + } + + rc = ERROR_NOTFOUND; + +out: + + if (gpios) + libxl__device_list_free(&libxl__gpio_devtype, gpios, n); + + GC_FREE; + return rc; +} + +int libxl_device_gpio_getinfo(libxl_ctx *ctx, uint32_t domid, + const libxl_device_gpio *gpio, + libxl_gpioinfo *info) +{ + GC_INIT(ctx); + char *libxl_path, *dompath, *devpath; + char *val; + int rc; + + libxl_gpioinfo_init(info); + dompath = libxl__xs_get_dompath(gc, domid); + info->devid = gpio->devid; + + devpath = libxl__domain_device_frontend_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_GPIO); + libxl_path = libxl__domain_device_libxl_path(gc, domid, info->devid, + LIBXL__DEVICE_KIND_GPIO); + + info->backend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + NULL); + if (!info->backend) { rc = ERROR_FAIL; goto out; } + + rc = libxl__backendpath_parse_domid(gc, info->backend, &info->backend_id); + if (rc) goto out; + + val = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/state", devpath)); + info->state = val ? strtoul(val, NULL, 10) : -1; + + info->frontend = xs_read(ctx->xsh, XBT_NULL, + GCSPRINTF("%s/frontend", libxl_path), + NULL); + info->frontend_id = domid; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_EVT_CHANNEL, devpath)); + info->evtch = val ? strtoul(val, NULL, 10) : -1; + + val = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/"XENKBD_FIELD_RING_GREF, devpath)); + info->rref = val ? strtoul(val, NULL, 10) : -1; + + rc = 0; + +out: + GC_FREE; + return rc; +} + +static LIBXL_DEFINE_UPDATE_DEVID(gpio) + +#define libxl__add_gpios NULL +#define libxl_device_gpio_compare NULL + +LIBXL_DEFINE_DEVICE_LIST(gpio) +LIBXL_DEFINE_DEVICE_REMOVE(gpio) + +DEFINE_DEVICE_TYPE_STRUCT(gpio, GPIO, gpios, + .skip_attach = 1, + .dm_needed = libxl__device_gpio_dm_needed, + .set_xenstore_config = (device_set_xenstore_config_fn_t) + libxl__set_xenstore_gpio, + .from_xenstore = (device_from_xenstore_fn_t)libxl__gpio_from_xenstore +); + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index b4dfbe7e5db1..7bbd9601ea7c 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -4001,6 +4001,7 @@ static inline int *libxl__device_type_get_num( extern const libxl__device_type libxl__vfb_devtype; extern const libxl__device_type libxl__vkb_devtype; +extern const libxl__device_type libxl__gpio_devtype; extern const libxl__device_type libxl__i2c_devtype; extern const libxl__device_type libxl__disk_devtype; extern const libxl__device_type libxl__nic_devtype; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index e9454e669224..b5a5cb99c2b4 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -266,6 +266,10 @@ libxl_vkb_backend = Enumeration("vkb_backend", [ (2, "LINUX") ]) +libxl_gpio_backend = Enumeration("gpio_backend", [ + (0, "VIRTIO") + ]) + libxl_i2c_backend = Enumeration("i2c_backend", [ (0, "VIRTIO") ]) @@ -618,6 +622,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ # - "mouse" for PS/2 protocol relative mouse ("usbdevice", string), ("vkb_device", libxl_defbool), + ("gpio_device", libxl_defbool), ("i2c_device", libxl_defbool), ("soundhw", string), ("xen_platform_pci", libxl_defbool), @@ -696,6 +701,15 @@ libxl_device_vkb = Struct("device_vkb", [ ("multi_touch_num_contacts", uint32) ]) +libxl_device_gpio = Struct("device_gpio", [ + ("backend_domid", libxl_domid), + ("backend_domname", string), + ("devid", libxl_devid), + ("backend_type", libxl_gpio_backend), + ("irq", uint32), + ("base", uint64) + ]) + libxl_device_i2c = Struct("device_i2c", [ ("backend_domid", libxl_domid), ("backend_domname", string), @@ -974,6 +988,7 @@ libxl_domain_config = Struct("domain_config", [ ("dtdevs", Array(libxl_device_dtdev, "num_dtdevs")), ("vfbs", Array(libxl_device_vfb, "num_vfbs")), ("vkbs", Array(libxl_device_vkb, "num_vkbs")), + ("gpios", Array(libxl_device_gpio, "num_gpios")), ("i2cs", Array(libxl_device_i2c, "num_i2cs")), ("vtpms", Array(libxl_device_vtpm, "num_vtpms")), ("p9s", Array(libxl_device_p9, "num_p9s")), @@ -1136,6 +1151,17 @@ libxl_vkbinfo = Struct("vkbinfo", [ ("rref", integer) ], dir=DIR_OUT) +libxl_gpioinfo = Struct("gpioinfo", [ + ("backend", string), + ("backend_id", uint32), + ("frontend", string), + ("frontend_id", uint32), + ("devid", libxl_devid), + ("state", integer), + ("evtch", integer), + ("rref", integer) + ], dir=DIR_OUT) + libxl_i2cinfo = Struct("i2cinfo", [ ("backend", string), ("backend_id", uint32), diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 1b87d1480bf9..3bb79c2a063a 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -33,6 +33,7 @@ libxl__device_kind = Enumeration("device_kind", [ (15, "VSND"), (16, "VINPUT"), (17, "I2C"), + (18, "GPIO"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index a9db0b97d80f..ffab4b362d2a 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -36,6 +36,7 @@ DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), functions = { # ( name , [type1,type2,....] ) "device_vfb": DEVICE_FUNCTIONS, "device_vkb": DEVICE_FUNCTIONS, + "device_gpio": DEVICE_FUNCTIONS, "device_i2c": DEVICE_FUNCTIONS, "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index cdf473f4ed57..0114cc22a1b6 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -707,6 +707,7 @@ DEVICE_ADDREMOVE(disk) DEVICE_ADDREMOVE(nic) DEVICE_ADDREMOVE(vfb) DEVICE_ADDREMOVE(vkb) +DEVICE_ADDREMOVE(gpio) DEVICE_ADDREMOVE(i2c) DEVICE_ADDREMOVE(pci) _DEVICE_ADDREMOVE(disk, cdrom, insert) diff --git a/tools/xl/Makefile b/tools/xl/Makefile index 06801962f11e..34ff203bfd86 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -23,7 +23,7 @@ XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o XL_OBJS += xl_info.o xl_console.o xl_misc.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o -XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_i2c.o +XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o xl_gpio.o xl_i2c.o $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XL_OBJS): CFLAGS += $(CFLAGS_XL) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 210bc1b6d47a..b2110b125ae4 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -177,6 +177,9 @@ int main_vsnddetach(int argc, char **argv); int main_vkbattach(int argc, char **argv); int main_vkblist(int argc, char **argv); int main_vkbdetach(int argc, char **argv); +int main_gpioattach(int argc, char **argv); +int main_gpiolist(int argc, char **argv); +int main_gpiodetach(int argc, char **argv); int main_i2cattach(int argc, char **argv); int main_i2clist(int argc, char **argv); int main_i2cdetach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 30bd614fc275..20bfedb74a7b 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -406,6 +406,21 @@ const struct cmd_spec cmd_table[] = { "Destroy a domain's virtual keyboard device", " ", }, + { "gpio-attach", + &main_gpioattach, 1, 1, + "Create a new virtual gpio device", + " ...", + }, + { "gpio-list", + &main_gpiolist, 0, 0, + "List virtual gpio devices for a domain", + "", + }, + { "gpio-detach", + &main_gpiodetach, 0, 1, + "Destroy a domain's virtual gpio device", + " ", + }, { "i2c-attach", &main_i2cattach, 1, 1, "Create a new virtual i2c device", diff --git a/tools/xl/xl_gpio.c b/tools/xl/xl_gpio.c new file mode 100644 index 000000000000..85c0b25411c7 --- /dev/null +++ b/tools/xl/xl_gpio.c @@ -0,0 +1,143 @@ +/* + * Copyright (C) 2022 Linaro Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include + +#include +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +int main_gpioattach(int argc, char **argv) +{ + int opt; + int rc; + uint32_t domid; + libxl_device_gpio gpio; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-attach", 2) { + /* No options */ + } + + libxl_device_gpio_init(&gpio); + domid = find_domain(argv[optind++]); + + for (argv += optind, argc -= optind; argc > 0; ++argv, --argc) { + rc = parse_gpio_config(&gpio, *argv); + if (rc) goto out; + } + + if (dryrun_only) { + char *json = libxl_device_gpio_to_json(ctx, &gpio); + printf("gpio: %s\n", json); + free(json); + goto done; + } + + if (libxl_device_gpio_add(ctx, domid, &gpio, 0)) { + fprintf(stderr, "libxl_device_gpio_add failed.\n"); + rc = ERROR_FAIL; goto out; + } + +done: + rc = 0; + +out: + libxl_device_gpio_dispose(&gpio); + return rc; +} + +int main_gpiolist(int argc, char **argv) +{ + int opt; + libxl_device_gpio *gpios; + libxl_gpioinfo gpioinfo; + int nb, i; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-list", 1) { + /* No options */ + } + + /* Idx BE Hdl Sta evch ref ID BE-type BE-path */ + printf("%-3s %-2s %-6s %-5s %-6s %6s %-10s %-10s %-30s\n", + "Idx", "BE", "handle", "state", "evt-ch", "ref", + "ID", "BE-type", "BE-path"); + for (argv += optind, argc -= optind; argc > 0; --argc, ++argv) { + uint32_t domid = find_domain(*argv); + gpios = libxl_device_gpio_list(ctx, domid, &nb); + if (!gpios) { + continue; + } + for (i = 0; i < nb; ++i) { + if (libxl_device_gpio_getinfo(ctx, domid, &gpios[i], &gpioinfo) == 0) { + printf("%-3d %-2d %6d %5d %6d %6d %-10s %-30s\n", + gpioinfo.devid, gpioinfo.backend_id, + gpioinfo.devid, gpioinfo.state, gpioinfo.evtch, + gpioinfo.rref, + libxl_gpio_backend_to_string(gpios[i].backend_type), + gpioinfo.backend); + libxl_gpioinfo_dispose(&gpioinfo); + } + } + libxl_device_gpio_list_free(gpios, nb); + } + return 0; +} + +int main_gpiodetach(int argc, char **argv) +{ + uint32_t domid, devid; + int opt, rc; + libxl_device_gpio gpio; + + SWITCH_FOREACH_OPT(opt, "", NULL, "gpio-detach", 2) { + /* No options */ + } + + domid = find_domain(argv[optind++]); + devid = atoi(argv[optind++]); + + libxl_device_gpio_init(&gpio); + + if (libxl_devid_to_device_gpio(ctx, domid, devid, &gpio)) { + fprintf(stderr, "Error: Device %d not connected.\n", devid); + rc = ERROR_FAIL; + goto out; + } + + rc = libxl_device_gpio_remove(ctx, domid, &gpio, 0); + if (rc) { + fprintf(stderr, "libxl_device_gpio_remove failed.\n"); + rc = ERROR_FAIL; + goto out; + } + + rc = 0; + +out: + libxl_device_gpio_dispose(&gpio); + return rc; +} + + +/* + * Local variables: + * mode: C + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 95483e551c38..7ab4f22821c4 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1204,6 +1204,74 @@ static void parse_vkb_list(const XLU_Config *config, if (rc) exit(EXIT_FAILURE); } +int parse_gpio_config(libxl_device_gpio *gpio, char *token) +{ + char *oparg; + + if (MATCH_OPTION("backend", token, oparg)) { + gpio->backend_domname = strdup(oparg); + } else if (MATCH_OPTION("backend-type", token, oparg)) { + libxl_gpio_backend backend_type; + if (libxl_gpio_backend_from_string(oparg, &backend_type)) { + fprintf(stderr, "Unknown backend_type \"%s\" in gpio spec\n", + oparg); + return -1; + } + gpio->backend_type = backend_type; + } else if (MATCH_OPTION("irq", token, oparg)) { + gpio->irq = strtoul(oparg, NULL, 0); + } else if (MATCH_OPTION("base", token, oparg)) { + gpio->base = strtoul(oparg, NULL, 0); + } else { + fprintf(stderr, "Unknown string \"%s\" in gpio spec\n", token); + return -1; + } + + return 0; +} + +static void parse_gpio_list(const XLU_Config *config, + libxl_domain_config *d_config) +{ + XLU_ConfigList *gpios; + const char *item; + char *buf = NULL; + int rc; + + if (!xlu_cfg_get_list (config, "gpio", &gpios, 0, 0)) { + int entry = 0; + while ((item = xlu_cfg_get_listitem(gpios, entry)) != NULL) { + libxl_device_gpio *gpio; + char *p; + + gpio = ARRAY_EXTEND_INIT(d_config->gpios, + d_config->num_gpios, + libxl_device_gpio_init); + + buf = strdup(item); + + p = strtok (buf, ","); + while (p != NULL) + { + while (*p == ' ') p++; + + rc = parse_gpio_config(gpio, p); + if (rc) goto out; + + p = strtok (NULL, ","); + } + + entry++; + } + } + + rc = 0; + +out: + free(buf); + if (rc) exit(EXIT_FAILURE); +} + int parse_i2c_config(libxl_device_i2c *i2c, char *token) { char *oparg; @@ -2373,15 +2441,18 @@ void parse_config_data(const char *config_source, d_config->num_vfbs = 0; d_config->num_vkbs = 0; + d_config->num_gpios = 0; d_config->num_i2cs = 0; d_config->vfbs = NULL; d_config->vkbs = NULL; + d_config->gpios = NULL; d_config->i2cs = NULL; if (!xlu_cfg_get_list (config, "vfb", &cvfbs, 0, 0)) { while ((buf = xlu_cfg_get_listitem (cvfbs, d_config->num_vfbs)) != NULL) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; char *buf2 = strdup(buf); @@ -2393,6 +2464,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + gpio = ARRAY_EXTEND_INIT(d_config->gpios, d_config->num_gpios, + libxl_device_gpio_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, libxl_device_i2c_init); @@ -2653,6 +2727,7 @@ void parse_config_data(const char *config_source, if (vnc_enabled) { libxl_device_vfb *vfb; libxl_device_vkb *vkb; + libxl_device_gpio *gpio; libxl_device_i2c *i2c; vfb = ARRAY_EXTEND_INIT(d_config->vfbs, d_config->num_vfbs, @@ -2661,6 +2736,9 @@ void parse_config_data(const char *config_source, vkb = ARRAY_EXTEND_INIT(d_config->vkbs, d_config->num_vkbs, libxl_device_vkb_init); + gpio = ARRAY_EXTEND_INIT(d_config->gpios, d_config->num_gpios, + libxl_device_gpio_init); + i2c = ARRAY_EXTEND_INIT(d_config->i2cs, d_config->num_i2cs, libxl_device_i2c_init); @@ -2778,6 +2856,7 @@ void parse_config_data(const char *config_source, exit(-ERROR_FAIL); } xlu_cfg_get_defbool(config, "vkb_device", &b_info->u.hvm.vkb_device, 0); + xlu_cfg_get_defbool(config, "gpio_device", &b_info->u.hvm.gpio_device, 0); xlu_cfg_get_defbool(config, "i2c_device", &b_info->u.hvm.i2c_device, 0); xlu_cfg_replace_string (config, "soundhw", &b_info->u.hvm.soundhw, 0); xlu_cfg_get_defbool(config, "xen_platform_pci", @@ -2827,6 +2906,7 @@ void parse_config_data(const char *config_source, } parse_vkb_list(config, d_config); + parse_gpio_list(config, d_config); parse_i2c_list(config, d_config); xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat", diff --git a/tools/xl/xl_parse.h b/tools/xl/xl_parse.h index 4b972d525199..6e041abe5d50 100644 --- a/tools/xl/xl_parse.h +++ b/tools/xl/xl_parse.h @@ -36,6 +36,7 @@ int parse_nic_config(libxl_device_nic *nic, XLU_Config **config, char *token); int parse_vdispl_config(libxl_device_vdispl *vdispl, char *token); int parse_vsnd_item(libxl_device_vsnd *vsnd, const char *spec); int parse_vkb_config(libxl_device_vkb *vkb, char *token); +int parse_gpio_config(libxl_device_gpio *gpio, char *token); int parse_i2c_config(libxl_device_i2c *i2c, char *token); int match_option_size(const char *prefix, size_t len, diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c index a44c765aa515..632e1f338d09 100644 --- a/tools/xl/xl_sxp.c +++ b/tools/xl/xl_sxp.c @@ -140,6 +140,8 @@ void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) fprintf(fh, "\t\t\t(usbdevice %s)\n", b_info->u.hvm.usbdevice); fprintf(fh, "\t\t\t(vkb_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.vkb_device)); + fprintf(fh, "\t\t\t(gpio_device %s)\n", + libxl_defbool_to_string(b_info->u.hvm.gpio_device)); fprintf(fh, "\t\t\t(i2c_device %s)\n", libxl_defbool_to_string(b_info->u.hvm.i2c_device)); fprintf(fh, "\t\t)\n"); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:05:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:05:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325182.547692 (Exim 4.92) (envelope-from ) id 1noIzn-00019b-7a; Tue, 10 May 2022 06:05:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325182.547692; Tue, 10 May 2022 06:05:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzn-00019P-3p; Tue, 10 May 2022 06:05:19 +0000 Received: by outflank-mailman (input) for mailman id 325182; Tue, 10 May 2022 06:05:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noIzm-0007z7-44 for xen-devel@lists.xen.org; Tue, 10 May 2022 06:05:18 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 232c783a-d027-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 08:05:06 +0200 (CEST) Received: by mail-pj1-x1029.google.com with SMTP id w17-20020a17090a529100b001db302efed6so1258812pjh.4 for ; Mon, 09 May 2022 23:05:17 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id i63-20020a636d42000000b003c14af5062esm9489879pgc.70.2022.05.09.23.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:05:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 232c783a-d027-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LdUL/a7ibfgZJBH8Cwv9KTcb3UJUgKsljFq91lvqCvU=; b=k181qsg4Qqs42nA6b8nsKIeuG8Fdeh1LZm41PT3KKx6dGkeV/r8YFGCtyV57yQuzjo kIptadhPH57dwBQtf0tn1kRKYhyF+sC+KZvhttghy8dnvrYJAA0A1v93+Ovo28q34zvS cRhJFtZh4Fn015Q9ZING6/pjkd9+PBoKa9vaYQzXm1hkOqrVS2ACRbwKNts1dVD1z4KR hOzxtV7WYkIHKmgTbJwg7DkSfa7EKdrNqf60YoeJItsYva2LqK2puY+vy9S/pdxYSfrB YWLg1q8SjkmLT9ZUp74vAzgRJJd9HUrhVd/hLn2sSDCEXOeKnHoCihy8S7gK1in4dNWL ZOMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LdUL/a7ibfgZJBH8Cwv9KTcb3UJUgKsljFq91lvqCvU=; b=gzoozIml9x0MjzhbJ4PpqUYaaFlJVkAsb4r5X8U5R5Z4TbLBMA+Zr9RarJ6ZN6XN6j vWdi+X0pwfQ2ypDlNaX41nzBY2IzEPzZz/8NoIvgcNiuOU2KOwSSc9j2LQfsl0Rzbl7B 6ic4sB2+03ylata/CVWszOiZhVzMOJf0yvz2SqBTE38KXw84ugbqP/FsjW3lvnJ5SLo6 /pXP6L7IRmeNC8h7VSGes+B1h+PIDHsSalqB4hMHznOUKh/Z9BT+pGQPuZiXWSWmlTmj SwnkQTw1uAJsg185gL1MPux24uMP6FQWN0v3U4EfTp0DD5oSofYMntZfjq7Eg59sazWz BJkQ== X-Gm-Message-State: AOAM533XgfFtaAnDZcVBT+NOMAQG+qSn8mP/t9U91hRJjCcqCTmgHWzi EIH9Yi9E+29EfOkB8FYTtiZzXIiyFmM1ZQ== X-Google-Smtp-Source: ABdhPJw/ICaJJRhvcX/HWYXMOuOkkNrEi+Qx5x4tMRG+zUNhqhq33zc7z7WNf7qxwb1Sgq1hPehPuw== X-Received: by 2002:a17:902:70c9:b0:15f:a78:fd15 with SMTP id l9-20020a17090270c900b0015f0a78fd15mr9855184plt.12.1652162715940; Mon, 09 May 2022 23:05:15 -0700 (PDT) From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Viresh Kumar , Vincent Guittot , stratos-dev@op-lists.linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: [PATCH V2 6/6] libxl: Allocate MMIO params for GPIO device and update DT Date: Tue, 10 May 2022 11:34:51 +0530 Message-Id: <5bae7f1e7fe2415f075e71353e3ca12f8f662b05.1652162646.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch allocates Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree based on Virtio GPIO DT bindings [1]. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/gpio/gpio-virtio.yaml Signed-off-by: Viresh Kumar --- tools/libs/light/libxl_arm.c | 46 ++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index d085c7cf4dbd..2f23430a3ea3 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -119,6 +119,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return rc; } + for (i = 0; i < d_config->num_gpios; i++) { + libxl_device_gpio *gpio = &d_config->gpios[i]; + + int rc = alloc_virtio_mmio_params(gc, &gpio->base, &gpio->irq, + &virtio_mmio_base, &virtio_mmio_irq); + if (rc) + return rc; + } + if (virtio_mmio_irq != GUEST_VIRTIO_MMIO_SPI_FIRST) { virtio_irq = virtio_mmio_irq - 1; nr_spis += (virtio_irq - 32) + 1; @@ -938,6 +947,38 @@ static int make_virtio_mmio_node_i2c(libxl__gc *gc, void *fdt, return fdt_end_node(fdt); } +static int make_virtio_mmio_node_gpio(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + + res = make_virtio_mmio_node_common(gc, fdt, base, irq); + if (res) return res; + + res = fdt_begin_node(fdt, "gpio"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,device29"); + if (res) return res; + + res = fdt_property(fdt, "gpio-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#gpio-cells", 2); + if (res) return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if (res) return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 2); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return fdt_end_node(fdt); +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -1253,6 +1294,11 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base, disk->irq) ); } + for (i = 0; i < d_config->num_gpios; i++) { + libxl_device_gpio *gpio = &d_config->gpios[i]; + FDT( make_virtio_mmio_node_gpio(gc, fdt, gpio->base, gpio->irq) ); + } + for (i = 0; i < d_config->num_i2cs; i++) { libxl_device_i2c *i2c = &d_config->i2cs[i]; FDT( make_virtio_mmio_node_i2c(gc, fdt, i2c->base, i2c->irq) ); -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue May 10 06:07:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325196.547702 (Exim 4.92) (envelope-from ) id 1noJ25-0003TT-OZ; Tue, 10 May 2022 06:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325196.547702; Tue, 10 May 2022 06:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJ25-0003TM-Ll; Tue, 10 May 2022 06:07:41 +0000 Received: by outflank-mailman (input) for mailman id 325196; Tue, 10 May 2022 06:07:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJ24-0003TA-3o for xen-devel@lists.xen.org; Tue, 10 May 2022 06:07:40 +0000 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [2607:f8b0:4864:20::1036]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e557d2b-d027-11ec-a406-831a346695d4; Tue, 10 May 2022 08:07:39 +0200 (CEST) Received: by mail-pj1-x1036.google.com with SMTP id cx11-20020a17090afd8b00b001d9fe5965b3so1181120pjb.3 for ; Mon, 09 May 2022 23:07:39 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id v68-20020a626147000000b0050dc762814asm9701843pfb.36.2022.05.09.23.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 23:07:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e557d2b-d027-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Diw5Bh3G0TJTjkhyoZQxR6xkH7Og/Lu6z99GDbmvy04=; b=MpNjXlUgWOtNvz6qvoE0hxclMe0DKfuZiD/e487Jbwo4RGtZPASb/jIp+oihmB6/xR NPfyQGw7LjlFy5hr+N3GN9EbU0ppVNTE5X5ITEA0PGGr7j0mlpnsfq4SvQ+hbp7EJeYQ lal9PBdpkPfrgaWroQSH6+yHNmJtmFV6P1OnAKaN5CSGlf/9Ay5CaOPOnm+sRgdmRupe Ad526SwQg8dLz9TLy6luRocMPV3Gu/flx2z3v0yw8bPfb11DOY7qG9Vyj4JPJuG1vM3T alxWIEXH4qdDR1Den4ytNIfAnqc96MFk7uk3W7dJH07AI2SUnKHqrM/+Z8XG+ES4xgrr +HRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Diw5Bh3G0TJTjkhyoZQxR6xkH7Og/Lu6z99GDbmvy04=; b=VblUlYe4UwoSl1QsP5bOLuyisffAIeLbtsgFJvg5LeFFFTqLyzaYsDJgxqOKG5D4qr UE3iqVBP14doO4bKfD2SKPmXbxjtotZmOV6SdbCthdGmMZsejMVrcgPmrH+h9kfC2JSQ r2hFNeCB2Sg7x+gVk2L0gr//iZq8AK8sEKLMHPWLWd21+kENIC6LnzCiCUNbkSZVNWiD BuztO1n5D06qCDippYPZTpn3UV270e04PVprigWQX9fA9wm3/7CYHxYojKCeT3+g22iM 1HUvdzlpm1b2x7An3CKzXWiC6oHKx/6aPZoEzTUO6/RZuBPzT6KAZLhdC6kpsXcEw/Xq QVag== X-Gm-Message-State: AOAM5315gLvHgallWVrPe9LosPhLIO+x2kfDc5SXGzEwoX8ei7PSuPLo sfzxXljS28DW00Nxmmv7EZcVnegRg11XSg== X-Google-Smtp-Source: ABdhPJwrIZZzL3t2mvNWJBPDziqpnvOys/Ln2P3htx1jXNbh07hDxY3rInmqmzJqTg8ZpXFrJ2Nkow== X-Received: by 2002:a17:902:da90:b0:15e:adc2:191d with SMTP id j16-20020a170902da9000b0015eadc2191dmr19157565plx.134.1652162857909; Mon, 09 May 2022 23:07:37 -0700 (PDT) Date: Tue, 10 May 2022 11:37:35 +0530 From: Viresh Kumar To: xen-devel@lists.xen.org Cc: Vincent Guittot , stratos-dev@op-lists.linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Stefano Stabellini , Mathieu Poirier , Mike Holmes , Oleksandr Tyshchenko , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH V2 0/6] Virtio toolstack support for I2C and GPIO on Arm Message-ID: <20220510060735.aw5rzzj24su7cc7i@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 On 10-05-22, 11:34, Viresh Kumar wrote: > Hello, > > This patchset adds toolstack support for I2C and GPIO virtio devices. This is > inspired from the work done by Oleksandr for the Disk device [1]. > > The first two patches can be applied right away, while the last four need > Oleksandr's series [1] to be applied first. > > This is developed as part of Linaro's Project Stratos, where we are working > towards Hypervisor agnostic Rust based backend [2]. > > I must accept that I am a beginner to Xen and developed this patchset based on > support for existing devices like Disk or Keyboard. There may be bits which I > missed or the one I added which aren't really required. Missed adding version history: V1->V2: - Patches 3/6 and 4/6 are new. - Patches 5/6 and 6/6 updated based on the above two patches. - Added link to the bindings for I2C and GPIO. - Rebased over latest master branch. -- viresh From xen-devel-bounces@lists.xenproject.org Tue May 10 06:20:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:20:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325228.547713 (Exim 4.92) (envelope-from ) id 1noJDv-0005LT-WA; Tue, 10 May 2022 06:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325228.547713; Tue, 10 May 2022 06:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJDv-0005LM-TT; Tue, 10 May 2022 06:19:55 +0000 Received: by outflank-mailman (input) for mailman id 325228; Tue, 10 May 2022 06:19:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJDu-0005LB-6R for xen-devel@lists.xenproject.org; Tue, 10 May 2022 06:19:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34022310-d029-11ec-a406-831a346695d4; Tue, 10 May 2022 08:19:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5CCF51FA35; Tue, 10 May 2022 06:19:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3906613AC1; Tue, 10 May 2022 06:19:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OpAxCwgEemL5WQAAMHmgww (envelope-from ); Tue, 10 May 2022 06:19:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34022310-d029-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652163592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NJxgkt+9muhPnfdpekGe4J9H+bDH8Vrk2WszTx0k0QI=; b=OThfI19W1LY6G7PLbWxoGywO3oi5m/ujjz52Es6h9OSKmnHDn5FxYymJBO5ON29B1wVmLx pKM42HcA3ZdCsSb6AS55/PF0tIW83SWiT/vyhTedbWMT+JVmz391S/JOWC7LjsOy/IreMu Bz1nyFRBxn/atNkSee1jkB5EJ/6M5Oc= Message-ID: Date: Tue, 10 May 2022 08:19:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: Attributing linux related patches on xen-devel Content-Language: en-US To: Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" References: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> <15ec8f3b-7d04-9fa2-dd32-b834fb660a89@oracle.com> From: Juergen Gross In-Reply-To: <15ec8f3b-7d04-9fa2-dd32-b834fb660a89@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tZgb9WAHBGfGRLFe7WVNugCV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tZgb9WAHBGfGRLFe7WVNugCV Content-Type: multipart/mixed; boundary="------------jKbKInT0rUtRQ8mRLOzWAQeI"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: Attributing linux related patches on xen-devel References: <1c5619ff-0872-8c0a-9dbd-9f419b9c957f@suse.com> <15ec8f3b-7d04-9fa2-dd32-b834fb660a89@oracle.com> In-Reply-To: <15ec8f3b-7d04-9fa2-dd32-b834fb660a89@oracle.com> --------------jKbKInT0rUtRQ8mRLOzWAQeI Content-Type: multipart/mixed; boundary="------------Ih2Hr9Z8Xk24Ttq0JJmFcIUE" --------------Ih2Hr9Z8Xk24Ttq0JJmFcIUE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDUuMjIgMjE6MzUsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDUv OS8yMiAzOjAxIFBNLCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+PiBPbiBNb24sIDkg TWF5IDIwMjIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4gT24gSVJDIHRoZSBxdWVzdGlv biBjYW1lIHVwIHdoZXRoZXIgaXQgd291bGQgYmUgcG9zc2libGUgdG8gaGF2ZSBhDQo+Pj4g c3BlY2lhbCBtYXJrZXIgZm9yIExpbnV4IHBhdGNoZXMgb24gdGhlIHhlbi1kZXZlbCBNTC4N Cj4+Pg0KPj4+IEkgc3VnZ2VzdGVkIHRvIHVzZSB4ZW4tZGV2ZWwrbGludXhAbGlzdHMueGVu cHJvamV4dC5vcmcgZm9yIHRob3NlDQo+Pj4gcGF0Y2hlcy4gV2l0aCBhIHBhdGNoIGZvciB0 aGUga2VybmVsJ3MgTUFJTlRBSU5FUlMgZmlsZSB0aGlzIHdvdWxkDQo+Pj4gYmUgcXVpdGUg ZWFzeSB0byBhY2hpZXZlLg0KPj4+DQo+Pj4gQW55IHRob3VnaHRzPw0KPj4gRmluZSBieSBt ZSwgYXMgbG9uZyBhcyB4ZW4tZGV2ZWwrbGludXhAbGlzdHMueGVucHJvamV4dC5vcmcgd29y a3MgOi0pDQo+Pg0KPj4gVGhlIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRvIGNvbWUgdXAgd2l0 aCBhIGRpZmZlcmVudCBzdWJqZWN0IHRhZyAoZS5nLg0KPj4gIlBBVENIIExJTlVYIikgYnV0 IHRoYXQgZG9lc24ndCB3b3JrIGFzIGl0IGlzIG5vdCBzdXBwb3J0ZWQgYnkgdG9kYXkncw0K Pj4gTGludXggTUFJTlRBSU5FUlMgZmlsZS4NCj4+DQo+PiBTbyBJIHRoaW5rIHhlbi1kZXZl bCtsaW51eCBpcyBmaW5lLg0KPiANCj4gDQo+IA0KPiBJJ2QgcHJlZmVyICctJyBpbnN0ZWFk IG9mICcrJyBidXQgZWl0aGVyIHdheSBpcyBmaW5lLg0KDQpNeSBzdWdnZXN0aW9uIHdhcyBi YXNlZCBvbiBSRkMtNTIzMzoNCg0KaHR0cHM6Ly9kYXRhdHJhY2tlci5pZXRmLm9yZy9kb2Mv aHRtbC9yZmM1MjMzDQoNCg0KSnVlcmdlbg0K --------------Ih2Hr9Z8Xk24Ttq0JJmFcIUE Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Ih2Hr9Z8Xk24Ttq0JJmFcIUE-- --------------jKbKInT0rUtRQ8mRLOzWAQeI-- --------------tZgb9WAHBGfGRLFe7WVNugCV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ6BAcFAwAAAAAACgkQsN6d1ii/Ey95 lwf/QRkMu0lkA6+O8VPhDwA2p3EDgSHk/5EbuD7P1/ASohor5WgqpCmhvwsG/CH1a2o1pHH0NvVs qYelGcQsUwcukfn09cNG/2GGiOuuja0lHKwc87jRZvZldES7WrXrK3RFnBkiyCKOF+s5usCgPzeL fTxQfBlBo/9CHrsdWr0GHboPq4JG0rvX486NpplfOtuEpwetgsKvlmQ+7Sp/N2jkCkqUweFQLP5D xGesDwF8wwg8pDpTrvWyNMHBH4RMpNMsxyU+zL6fWn7nsOCe07J1IrKVdE1g340aYqcUxGSxg4rh Vm3PFpP5WZIokNaHZRbB0HC5QMeTUlDSq0GLyaLJ4Q== =iVrZ -----END PGP SIGNATURE----- --------------tZgb9WAHBGfGRLFe7WVNugCV-- From xen-devel-bounces@lists.xenproject.org Tue May 10 06:20:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325232.547725 (Exim 4.92) (envelope-from ) id 1noJEX-0006a0-AG; Tue, 10 May 2022 06:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325232.547725; Tue, 10 May 2022 06:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJEX-0006Zt-7S; Tue, 10 May 2022 06:20:33 +0000 Received: by outflank-mailman (input) for mailman id 325232; Tue, 10 May 2022 06:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJEW-0006Zb-MQ; Tue, 10 May 2022 06:20:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJEW-0006fA-Kd; Tue, 10 May 2022 06:20:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJEW-0006ZD-9e; Tue, 10 May 2022 06:20:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noJEW-0007fd-9B; Tue, 10 May 2022 06:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R+Vl+DeRfM4RBczFkG6u35L+MFB+s+wKgNyHHVRpL78=; b=eliuNkmTSJme4h33XOTHEhfLRY fZbstKtckf572XO565Lm3NNoCOpExC914i/sQt51DdzWnsLFe8+mZ/fcnH55zS60ScYlUUD7QepUi L0noApJcJe2kwsX69iJ777U8880pc0H9kvtr0jkUg7Nw5oxNyoWoFjtZycKTmMOg5I3Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170288: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 06:20:32 +0000 flight 170288 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170288/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 906 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 06:49:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:49:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325242.547736 (Exim 4.92) (envelope-from ) id 1noJgL-0001GT-Ko; Tue, 10 May 2022 06:49:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325242.547736; Tue, 10 May 2022 06:49:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJgL-0001GM-Hd; Tue, 10 May 2022 06:49:17 +0000 Received: by outflank-mailman (input) for mailman id 325242; Tue, 10 May 2022 06:49:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJgK-0001GG-EW for xen-devel@lists.xenproject.org; Tue, 10 May 2022 06:49:16 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4db2daa6-d02d-11ec-a406-831a346695d4; Tue, 10 May 2022 08:49:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A02E12FC; Mon, 9 May 2022 23:49:13 -0700 (PDT) Received: from [10.57.3.29] (unknown [10.57.3.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6ACDB3F73D; Mon, 9 May 2022 23:49:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4db2daa6-d02d-11ec-a406-831a346695d4 Message-ID: Date: Tue, 10 May 2022 08:49:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Content-Language: en-US To: Catalin Marinas Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20220505115906.380416-1-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Catalin, On 05.05.2022 14:13, Catalin Marinas wrote: > On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: >> Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer >> and can lead to overflow. Currently there is no issue as it is used >> in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. >> To avoid possible problems, fix the macro. >> >> Signed-off-by: Michal Orzel >> Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com >> Signed-off-by: Catalin Marinas >> Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) >> --- >> Changes since v1: >> - add Origin tag as the patch was merged in upstream arm64 linux tree > > Note that there's always a risk that the commit Id will be changed > before it hits mainline (Linus' tree). > This commit is now in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48e6f22e25a44e43952db5fbb767dea0c9319cb2 so we can be sure that the SHA will stay unmodified there (and will be the same in Linus' tree). Question to maintainers: Do you want me to update Origin to point to linux-next? Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 10 06:52:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 06:52:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325252.547747 (Exim 4.92) (envelope-from ) id 1noJjE-0002o9-24; Tue, 10 May 2022 06:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325252.547747; Tue, 10 May 2022 06:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJjD-0002o2-VO; Tue, 10 May 2022 06:52:15 +0000 Received: by outflank-mailman (input) for mailman id 325252; Tue, 10 May 2022 06:52:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJjC-0002nw-FE for xen-devel@lists.xenproject.org; Tue, 10 May 2022 06:52:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b2236eb0-d02d-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 08:52:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0EE513D5; Mon, 9 May 2022 23:52:12 -0700 (PDT) Received: from [10.57.3.29] (unknown [10.57.3.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 118063F73D; Mon, 9 May 2022 23:52:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2236eb0-d02d-11ec-8fc4-03012f2f19d4 Message-ID: Date: Tue, 10 May 2022 08:52:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-2-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jan, On 06.05.2022 12:03, Jan Beulich wrote: > On 06.05.2022 11:42, Michal Orzel wrote: >> Function unmap_common_complete (common/grant_table.c) defines and sets >> a variable ld that is later on passed to a macro: >> gnttab_host_mapping_get_page_type(). >> On Arm this macro does not make use of any arguments causing a compiler >> to warn about unused-but-set variable (when -Wunused-but-set-variable >> is enabled). Fix it by converting this macro to a static inline >> helper and using the boolean return type. >> >> While there, also convert macro gnttab_release_host_mappings. >> >> Signed-off-by: Michal Orzel >> Reviewed-by: Jan Beulich > > This R-b applies only ... > >> --- a/xen/arch/arm/include/asm/grant_table.h >> +++ b/xen/arch/arm/include/asm/grant_table.h >> @@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >> #endif >> } >> >> +static inline bool gnttab_host_mapping_get_page_type(const bool ro, > > ... with this const dropped again. As said elsewhere, while not > technically wrong we don't normally do so elsewhere, and this ends > up inconsistent with ... > >> + const struct domain *ld, >> + const struct domain *rd) > > ... there being just a single const here. > > Jan > Do you have any remarks related to the second patch in this series? If yes, I will handle removal of const in the next version. If not, Julien said in v1 that this can be handled on commit. Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 10 07:30:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 07:30:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325262.547757 (Exim 4.92) (envelope-from ) id 1noKK2-0007X3-1e; Tue, 10 May 2022 07:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325262.547757; Tue, 10 May 2022 07:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKK1-0007Ww-VG; Tue, 10 May 2022 07:30:17 +0000 Received: by outflank-mailman (input) for mailman id 325262; Tue, 10 May 2022 07:30:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKK0-0007Wm-38; Tue, 10 May 2022 07:30:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKK0-0007qI-1N; Tue, 10 May 2022 07:30:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKJz-0001Jw-Lm; Tue, 10 May 2022 07:30:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noKJz-0006nh-LN; Tue, 10 May 2022 07:30:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BRFVuxgOS7b8LpUDw2zAYtw3M9wtguF2+NrqaI0OAZE=; b=H4A9OHfNn6Yr3mxZFglhWRiXyp o0MltiOx5puXDxBEC96LmBm9uhSLBS8S2IT5yjmV11rMRaSvQ1f3uwDPvRPGjHRSkl86OIyK+a2qX d7nPEZ+ymjG2PIRh8kC+iSFgqD0w6XYwxWgYOnVjQxFg9VYSM7h7lsWYdSZ1EqnXDfUY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170289: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 07:30:15 +0000 flight 170289 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170289/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 907 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 08:00:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325277.547769 (Exim 4.92) (envelope-from ) id 1noKnG-0003VM-4e; Tue, 10 May 2022 08:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325277.547769; Tue, 10 May 2022 08:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKnG-0003VF-1V; Tue, 10 May 2022 08:00:30 +0000 Received: by outflank-mailman (input) for mailman id 325277; Tue, 10 May 2022 08:00:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKnE-0003V5-G1; Tue, 10 May 2022 08:00:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKnE-0000Vu-Cz; Tue, 10 May 2022 08:00:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noKnE-00020q-13; Tue, 10 May 2022 08:00:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noKnE-0006Kw-0c; Tue, 10 May 2022 08:00:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kkD6lTaWE8M3DSnsHGUFmF3EwnZ6faGC8Bsc5+69UhA=; b=A8vOGdeBuqCG+d3vgS6EkV3+Au TKfXcbyW1xYOjMZDTOnsmxBTZqarwqv6AvpupkpyAWetrxr+5bFm9Ro1vITvk3R33D6xv+/ltp3SC 8Ds5DRA58ndqFBNsbZsQZ/3oEKHE3GrBoYLqS2xJFo1uIsVZpcJ10mPud2mnnyPqhEE0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170291: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 08:00:28 +0000 flight 170291 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 908 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 08:27:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325287.547788 (Exim 4.92) (envelope-from ) id 1noLCo-0006Yj-CQ; Tue, 10 May 2022 08:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325287.547788; Tue, 10 May 2022 08:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLCo-0006Yc-9Z; Tue, 10 May 2022 08:26:54 +0000 Received: by outflank-mailman (input) for mailman id 325287; Tue, 10 May 2022 08:26:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLCm-0006YS-O4; Tue, 10 May 2022 08:26:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLCm-0000wd-Lf; Tue, 10 May 2022 08:26:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLCm-0002dB-3f; Tue, 10 May 2022 08:26:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noLCm-0006M6-3B; Tue, 10 May 2022 08:26:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zYsQAAdfjhd/59/3sYGRDr2By37W63oOJaz5cecUWMw=; b=tPyKp8aDDUFBZtl81OhKfwpHjB LA9czD59MilZH+7yXGgXpFiTIq516CZWMNWfPZxapXSrUPxThjV31e+xgO2xjdaVQ+HxVMonN6ll3 UKmmHeNS2uoXwb3FNblGt+ecGtEGnJfMzFG8YF1q7PUlJ2I7D02w2pIvad9EUY1dzmlw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170281: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=95604873ccf56eb81e96ed0dc8b4dec3278f40ca X-Osstest-Versions-That: xen=b7e0d8978810b534725e94a321736496928f00a5 From: osstest service owner Date: Tue, 10 May 2022 08:26:52 +0000 flight 170281 xen-unstable real [real] flight 170290 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170281/ http://logs.test-lab.xenproject.org/osstest/logs/170290/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 170290-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170257 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170257 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170257 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170257 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170257 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170257 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170257 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170257 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170257 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170257 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170257 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170257 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170257 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass version targeted for testing: xen 95604873ccf56eb81e96ed0dc8b4dec3278f40ca baseline version: xen b7e0d8978810b534725e94a321736496928f00a5 Last test of basis 170257 2022-05-09 01:53:05 Z 1 days Testing same since 170281 2022-05-09 23:09:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Julien Grall Rahul Singh jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b7e0d89788..95604873cc 95604873ccf56eb81e96ed0dc8b4dec3278f40ca -> master From xen-devel-bounces@lists.xenproject.org Tue May 10 08:27:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:27:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325295.547799 (Exim 4.92) (envelope-from ) id 1noLDR-00075H-TG; Tue, 10 May 2022 08:27:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325295.547799; Tue, 10 May 2022 08:27:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLDR-00075A-OS; Tue, 10 May 2022 08:27:33 +0000 Received: by outflank-mailman (input) for mailman id 325295; Tue, 10 May 2022 08:27:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLDQ-00073H-9r for xen-devel@lists.xenproject.org; Tue, 10 May 2022 08:27:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLDP-0000xF-Uu; Tue, 10 May 2022 08:27:31 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noLDP-0001ov-P2; Tue, 10 May 2022 08:27:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BVaGfHciAAfijaGQQ902PnINeeOqwpNqMN0kNSEUiuE=; b=40xdfE8vVRbaeuRTaPdOKpIVSI LXU5Pm7QPtHDsxfY6B89rx6qhLYZChBb5DUc59S89chiAail4qwL+wo5ZjJ2RyGRux4rNqVmKWvu9 qlcsyGC7C42hp8k0vOKG6+Jyf036bGIUwurYItUbownLxgPpFeQDaTteEz6y9WYV1LD4=; Message-ID: Date: Tue, 10 May 2022 09:27:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK To: Michal Orzel , Catalin Marinas Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220505115906.380416-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/05/2022 07:49, Michal Orzel wrote: > On 05.05.2022 14:13, Catalin Marinas wrote: >> On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: >>> Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer >>> and can lead to overflow. Currently there is no issue as it is used >>> in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. >>> To avoid possible problems, fix the macro. >>> >>> Signed-off-by: Michal Orzel >>> Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com >>> Signed-off-by: Catalin Marinas >>> Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) >>> --- >>> Changes since v1: >>> - add Origin tag as the patch was merged in upstream arm64 linux tree >> >> Note that there's always a risk that the commit Id will be changed >> before it hits mainline (Linus' tree). >> > > This commit is now in linux-next: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48e6f22e25a44e43952db5fbb767dea0c9319cb2 > so we can be sure that the SHA will stay unmodified there (and will be the same in Linus' tree). AFAIK, linux-next branch is just a merge of all the maintainers branch and often rewritten. So there are no guarantee a commit id is valid until it reached Linus' tree. > > Question to maintainers: > Do you want me to update Origin to point to linux-next? So we have a link to the patch and a name. This should be sufficient to find the commit. Therefore, I would simply on top of Origin: [The commit ID may be different in linus' tree] -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 08:30:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325302.547810 (Exim 4.92) (envelope-from ) id 1noLFz-00008A-8i; Tue, 10 May 2022 08:30:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325302.547810; Tue, 10 May 2022 08:30:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLFz-000083-5r; Tue, 10 May 2022 08:30:11 +0000 Received: by outflank-mailman (input) for mailman id 325302; Tue, 10 May 2022 08:30:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLFy-00007r-Gi; Tue, 10 May 2022 08:30:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLFy-0000zl-Fw; Tue, 10 May 2022 08:30:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLFx-0002gz-Qi; Tue, 10 May 2022 08:30:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noLFx-00080T-QJ; Tue, 10 May 2022 08:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FicrpqkVrl2JectySpipVfFZLPNwmiuDhsiTMpX91cI=; b=ZAGs32utnT7DZguR0akRXvFC8l Pv5S/KN9I6zzZyaq8TW7STgCyW93kqV661cHzuAGBWxQ9u4STC9j/HZtzkHBE8jG+tSSKBEabyQIn Lw60PWZpwv4vzixRmMPcDrre6uMUIJg17IDqYVMxpZWCwzpjBjt8FEueGpTywOjujpqg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170292: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 08:30:09 +0000 flight 170292 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170292/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 909 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 08:52:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:52:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325310.547821 (Exim 4.92) (envelope-from ) id 1noLbn-00035D-4z; Tue, 10 May 2022 08:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325310.547821; Tue, 10 May 2022 08:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLbn-000356-1o; Tue, 10 May 2022 08:52:43 +0000 Received: by outflank-mailman (input) for mailman id 325310; Tue, 10 May 2022 08:52:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLbm-000350-34 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 08:52:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8c46bf0c-d03e-11ec-a406-831a346695d4; Tue, 10 May 2022 10:52:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9DD211FB; Tue, 10 May 2022 01:52:39 -0700 (PDT) Received: from [10.57.3.29] (unknown [10.57.3.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 877CD3F66F; Tue, 10 May 2022 01:52:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c46bf0c-d03e-11ec-a406-831a346695d4 Message-ID: <462ed3d7-df90-6d57-90f2-c5991d47a783@arm.com> Date: Tue, 10 May 2022 10:52:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Content-Language: en-US To: Julien Grall , Catalin Marinas Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220505115906.380416-1-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 10.05.2022 10:27, Julien Grall wrote: > > Therefore, I would simply on top of Origin: > > [The commit ID may be different in linus' tree] > Could you please do that on commit as this is just one line of commit change? Thanks, Michal From xen-devel-bounces@lists.xenproject.org Tue May 10 08:55:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 08:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325316.547832 (Exim 4.92) (envelope-from ) id 1noLec-0003hD-Jw; Tue, 10 May 2022 08:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325316.547832; Tue, 10 May 2022 08:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLec-0003h6-GG; Tue, 10 May 2022 08:55:38 +0000 Received: by outflank-mailman (input) for mailman id 325316; Tue, 10 May 2022 08:55:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLea-0003h0-S8 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 08:55:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f403aeaf-d03e-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 10:55:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CFAB614A1; Tue, 10 May 2022 08:55:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF230C385A6; Tue, 10 May 2022 08:55:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f403aeaf-d03e-11ec-8fc4-03012f2f19d4 Date: Tue, 10 May 2022 09:55:28 +0100 From: Catalin Marinas To: Julien Grall Cc: Michal Orzel , xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Message-ID: References: <20220505115906.380416-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 10, 2022 at 09:27:29AM +0100, Julien Grall wrote: > Hi, > > On 10/05/2022 07:49, Michal Orzel wrote: > > On 05.05.2022 14:13, Catalin Marinas wrote: > > > On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: > > > > Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer > > > > and can lead to overflow. Currently there is no issue as it is used > > > > in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. > > > > To avoid possible problems, fix the macro. > > > > > > > > Signed-off-by: Michal Orzel > > > > Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com > > > > Signed-off-by: Catalin Marinas > > > > Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) > > > > --- > > > > Changes since v1: > > > > - add Origin tag as the patch was merged in upstream arm64 linux tree > > > > > > Note that there's always a risk that the commit Id will be changed > > > before it hits mainline (Linus' tree). > > > > > > > This commit is now in linux-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48e6f22e25a44e43952db5fbb767dea0c9319cb2 > > so we can be sure that the SHA will stay unmodified there (and will be the same in Linus' tree). > > AFAIK, linux-next branch is just a merge of all the maintainers branch and > often rewritten. So there are no guarantee a commit id is valid until it > reached Linus' tree. Indeed. While I try not to rebase it, it may happen occasionally. > > Question to maintainers: > > Do you want me to update Origin to point to linux-next? > > So we have a link to the patch and a name. This should be sufficient to find > the commit. > > Therefore, I would simply on top of Origin: Yeah, just keep the link to the mailing list. I guess you can drop my Singed-off-by as well if it appears to be picked from the list rather than the kernel repo. If you want an ack: Acked-by: Catalin Marinas -- Catalin From xen-devel-bounces@lists.xenproject.org Tue May 10 09:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 09:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325326.547843 (Exim 4.92) (envelope-from ) id 1noMQF-0001EP-Af; Tue, 10 May 2022 09:44:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325326.547843; Tue, 10 May 2022 09:44:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMQF-0001Dz-3y; Tue, 10 May 2022 09:44:51 +0000 Received: by outflank-mailman (input) for mailman id 325326; Tue, 10 May 2022 09:44:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMQD-0001Dp-RA; Tue, 10 May 2022 09:44:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMQD-0002Ht-QE; Tue, 10 May 2022 09:44:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMQD-0006Io-Ah; Tue, 10 May 2022 09:44:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noMQD-0008G6-AI; Tue, 10 May 2022 09:44:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=08r98TxmnJp5bWpGZGBjJBB2Mm+/8E+M6rd69X7sHBg=; b=jg8BY6+V4eqgbwoprMA5X+kmIy L0EJzkvgYbZQTwvp4QfvX4wk+yR0egi/h60OHVVNTEhdjzKI2pH6XglUDkaUnm9wNMttzwMhD4osu kD2pzaa2bntWOOzR1mdnFwoh7PFmnn9gF26H9VBwymFdKaYic7XRfHRJWHnxN5IjEdVk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170294: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 09:44:49 +0000 flight 170294 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170294/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 70 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 910 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325334.547854 (Exim 4.92) (envelope-from ) id 1noMuI-00056K-Hi; Tue, 10 May 2022 10:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325334.547854; Tue, 10 May 2022 10:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuI-00056C-EM; Tue, 10 May 2022 10:15:54 +0000 Received: by outflank-mailman (input) for mailman id 325334; Tue, 10 May 2022 10:15:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuG-00055w-Ox for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:15:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29d0fca6-d04a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 12:15:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29d0fca6-d04a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177750; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9/53ScNxOaKweIeaPofc3f9ymrzpAqLfKE0Re3kkOsI=; b=VIxZQP+zdIqR6muP76aWIn3qTsYyBdublT7hKHgiFZktfB0vxk/1a/sI g2Gw14URNMnKMScAMEe6AGCj6B89npI/R17eHgQsYCW1prKMCJciHcr3e 4LuBj4Q5lOS2RMypJgnYsBPSTEpwe7y9jfl+5uu5B38TkupAy1iEv1k5R g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70977058 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:FTEYOKOMemRM5WnvrR2vl8FynXyQoLVcMsEvi/4bfWQNrUoh0DADz 2BJDWCHP66NM2rxeY11b9/n9xwDuJTTyNJmGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Yw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+ tJSjJmvSAsSJ/eWuM8jD0hUIyphIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYAAjWhv3p0edRrYT 5syampBfBPCXzARJFUQJZsXjeiTgnaqJlW0r3rK/PFqsgA/1jdZ0qXpMdfTUsyHQ4NShEnwj n3C13T0BFcdLtP34SGe7numi+vLnCX6cIEfDru18rhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVXRe1vXqFtR40QMdLHqsx7wTl90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt+HuGgVqr7yZcmvHrJe/k2/jNRgeMnBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/ 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZvvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7 SFfy6ByAA3jZKxhdRBhos1QRdlFBN7faVUwZGKD+LF7rlyQF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPd/rUp5zkviwSYy4PhwxUjapSsIqHDJrAQk0PRLAt4wTuBZEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7FihIvZ8Vq9z jqqH5bTo/mpeLamMne/HE96BQ1iEEXX8ris9ZMNKr7YcloO9aNII6a5/I7NsrdNx8x9/tokN FnkMqOE4DITXUH6FDg= IronPort-HdrOrdr: A9a23:YlRGr6A5DbBvFI7lHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN 5dmsNFaeEYY2IUsS+D2njbL+od X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70977058" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 5/6] byteorder: Remove byteorder Date: Tue, 10 May 2022 06:15:23 -0400 Message-ID: <97e346648d356f621170bcb89fd7d86c120aca70.1652170719.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain include/xen/byteswap.h has simplify the interface, just clean the old interface No functional change Signed-off-by: Lin Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu --- xen/include/xen/byteorder/big_endian.h | 102 ------------ xen/include/xen/byteorder/generic.h | 68 -------- xen/include/xen/byteorder/little_endian.h | 102 ------------ xen/include/xen/byteorder/swab.h | 183 ---------------------- 4 files changed, 455 deletions(-) delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h diff --git a/xen/include/xen/byteorder/big_endian.h b/xen/include/xen/byteorder/big_endian.h deleted file mode 100644 index 40eb80a390..0000000000 --- a/xen/include/xen/byteorder/big_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_BIG_ENDIAN_H__ -#define __XEN_BYTEORDER_BIG_ENDIAN_H__ - -#ifndef __BIG_ENDIAN -#define __BIG_ENDIAN 4321 -#endif -#ifndef __BIG_ENDIAN_BITFIELD -#define __BIG_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)___constant_swab64((x))) -#define __constant_le64_to_cpu(x) ___constant_swab64((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)___constant_swab32((x))) -#define __constant_le32_to_cpu(x) ___constant_swab32((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)___constant_swab16((x))) -#define __constant_le16_to_cpu(x) ___constant_swab16((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)__swab64((x))) -#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)__swab32((x))) -#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)__swab16((x))) -#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __be16_to_cpu(x) ((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)__swab64p(p); -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)__swab32p(p); -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)__swab16p(p); -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return __swab16p((__u16 *)p); -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)*p; -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return (__force __u64)*p; -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)*p; -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return (__force __u32)*p; -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)*p; -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return (__force __u16)*p; -} -#define __cpu_to_le64s(x) __swab64s((x)) -#define __le64_to_cpus(x) __swab64s((x)) -#define __cpu_to_le32s(x) __swab32s((x)) -#define __le32_to_cpus(x) __swab32s((x)) -#define __cpu_to_le16s(x) __swab16s((x)) -#define __le16_to_cpus(x) __swab16s((x)) -#define __cpu_to_be64s(x) do {} while (0) -#define __be64_to_cpus(x) do {} while (0) -#define __cpu_to_be32s(x) do {} while (0) -#define __be32_to_cpus(x) do {} while (0) -#define __cpu_to_be16s(x) do {} while (0) -#define __be16_to_cpus(x) do {} while (0) - -#include - -#endif /* __XEN_BYTEORDER_BIG_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/generic.h b/xen/include/xen/byteorder/generic.h deleted file mode 100644 index 8a0006b755..0000000000 --- a/xen/include/xen/byteorder/generic.h +++ /dev/null @@ -1,68 +0,0 @@ -#ifndef __XEN_BYTEORDER_GENERIC_H__ -#define __XEN_BYTEORDER_GENERIC_H__ - -/* - * Generic Byte-reordering support - * - * The "... p" macros, like le64_to_cpup, can be used with pointers - * to unaligned data, but there will be a performance penalty on - * some architectures. Use get_unaligned for unaligned data. - * - * The following macros are to be defined by : - * - * Conversion of XX-bit integers (16- 32- or 64-) - * between native CPU format and little/big endian format - * 64-bit stuff only defined for proper architectures - * cpu_to_[bl]eXX(__uXX x) - * [bl]eXX_to_cpu(__uXX x) - * - * The same, but takes a pointer to the value to convert - * cpu_to_[bl]eXXp(__uXX x) - * [bl]eXX_to_cpup(__uXX x) - * - * The same, but change in situ - * cpu_to_[bl]eXXs(__uXX x) - * [bl]eXX_to_cpus(__uXX x) - * - * See asm-foo/byteorder.h for examples of how to provide - * architecture-optimized versions - */ - -#define cpu_to_le64 __cpu_to_le64 -#define le64_to_cpu __le64_to_cpu -#define cpu_to_le32 __cpu_to_le32 -#define le32_to_cpu __le32_to_cpu -#define cpu_to_le16 __cpu_to_le16 -#define le16_to_cpu __le16_to_cpu -#define cpu_to_be64 __cpu_to_be64 -#define be64_to_cpu __be64_to_cpu -#define cpu_to_be32 __cpu_to_be32 -#define be32_to_cpu __be32_to_cpu -#define cpu_to_be16 __cpu_to_be16 -#define be16_to_cpu __be16_to_cpu -#define cpu_to_le64p __cpu_to_le64p -#define le64_to_cpup __le64_to_cpup -#define cpu_to_le32p __cpu_to_le32p -#define le32_to_cpup __le32_to_cpup -#define cpu_to_le16p __cpu_to_le16p -#define le16_to_cpup __le16_to_cpup -#define cpu_to_be64p __cpu_to_be64p -#define be64_to_cpup __be64_to_cpup -#define cpu_to_be32p __cpu_to_be32p -#define be32_to_cpup __be32_to_cpup -#define cpu_to_be16p __cpu_to_be16p -#define be16_to_cpup __be16_to_cpup -#define cpu_to_le64s __cpu_to_le64s -#define le64_to_cpus __le64_to_cpus -#define cpu_to_le32s __cpu_to_le32s -#define le32_to_cpus __le32_to_cpus -#define cpu_to_le16s __cpu_to_le16s -#define le16_to_cpus __le16_to_cpus -#define cpu_to_be64s __cpu_to_be64s -#define be64_to_cpus __be64_to_cpus -#define cpu_to_be32s __cpu_to_be32s -#define be32_to_cpus __be32_to_cpus -#define cpu_to_be16s __cpu_to_be16s -#define be16_to_cpus __be16_to_cpus - -#endif /* __XEN_BYTEORDER_GENERIC_H__ */ diff --git a/xen/include/xen/byteorder/little_endian.h b/xen/include/xen/byteorder/little_endian.h deleted file mode 100644 index 4955632793..0000000000 --- a/xen/include/xen/byteorder/little_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_LITTLE_ENDIAN_H__ -#define __XEN_BYTEORDER_LITTLE_ENDIAN_H__ - -#ifndef __LITTLE_ENDIAN -#define __LITTLE_ENDIAN 1234 -#endif -#ifndef __LITTLE_ENDIAN_BITFIELD -#define __LITTLE_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)___constant_swab64((x))) -#define __constant_be64_to_cpu(x) ___constant_swab64((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)___constant_swab32((x))) -#define __constant_be32_to_cpu(x) ___constant_swab32((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)___constant_swab16((x))) -#define __constant_be16_to_cpu(x) ___constant_swab16((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)__swab64((x))) -#define __be64_to_cpu(x) __swab64((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)__swab32((x))) -#define __be32_to_cpu(x) __swab32((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)__swab16((x))) -#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)*p; -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return (__force __u64)*p; -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)*p; -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return (__force __u32)*p; -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)*p; -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return (__force __u16)*p; -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)__swab64p(p); -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)__swab32p(p); -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)__swab16p(p); -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return __swab16p((__u16 *)p); -} -#define __cpu_to_le64s(x) do {} while (0) -#define __le64_to_cpus(x) do {} while (0) -#define __cpu_to_le32s(x) do {} while (0) -#define __le32_to_cpus(x) do {} while (0) -#define __cpu_to_le16s(x) do {} while (0) -#define __le16_to_cpus(x) do {} while (0) -#define __cpu_to_be64s(x) __swab64s((x)) -#define __be64_to_cpus(x) __swab64s((x)) -#define __cpu_to_be32s(x) __swab32s((x)) -#define __be32_to_cpus(x) __swab32s((x)) -#define __cpu_to_be16s(x) __swab16s((x)) -#define __be16_to_cpus(x) __swab16s((x)) - -#include - -#endif /* __XEN_BYTEORDER_LITTLE_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/swab.h b/xen/include/xen/byteorder/swab.h deleted file mode 100644 index b7e30f0503..0000000000 --- a/xen/include/xen/byteorder/swab.h +++ /dev/null @@ -1,183 +0,0 @@ -#ifndef __XEN_BYTEORDER_SWAB_H__ -#define __XEN_BYTEORDER_SWAB_H__ - -/* - * Byte-swapping, independently from CPU endianness - * swabXX[ps]?(foo) - * - * Francois-Rene Rideau 19971205 - * separated swab functions from cpu_to_XX, - * to clean up support for bizarre-endian architectures. - */ - -/* casts are necessary for constants, because we never know how for sure - * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way. - */ -#define ___swab16(x) \ -({ \ - __u16 __x = (x); \ - ((__u16)( \ - (((__u16)(__x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(__x) & (__u16)0xff00U) >> 8) )); \ -}) - -#define ___swab32(x) \ -({ \ - __u32 __x = (x); \ - ((__u32)( \ - (((__u32)(__x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(__x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(__x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(__x) & (__u32)0xff000000UL) >> 24) )); \ -}) - -#define ___swab64(x) \ -({ \ - __u64 __x = (x); \ - ((__u64)( \ - (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) )); \ -}) - -#define ___constant_swab16(x) \ - ((__u16)( \ - (((__u16)(x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(x) & (__u16)0xff00U) >> 8) )) -#define ___constant_swab32(x) \ - ((__u32)( \ - (((__u32)(x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(x) & (__u32)0xff000000UL) >> 24) )) -#define ___constant_swab64(x) \ - ((__u64)( \ - (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) )) - -/* - * provide defaults when no architecture-specific optimization is detected - */ -#ifndef __arch__swab16 -# define __arch__swab16(x) ({ __u16 __tmp = (x) ; ___swab16(__tmp); }) -#endif -#ifndef __arch__swab32 -# define __arch__swab32(x) ({ __u32 __tmp = (x) ; ___swab32(__tmp); }) -#endif -#ifndef __arch__swab64 -# define __arch__swab64(x) ({ __u64 __tmp = (x) ; ___swab64(__tmp); }) -#endif - -#ifndef __arch__swab16p -# define __arch__swab16p(x) __arch__swab16(*(x)) -#endif -#ifndef __arch__swab32p -# define __arch__swab32p(x) __arch__swab32(*(x)) -#endif -#ifndef __arch__swab64p -# define __arch__swab64p(x) __arch__swab64(*(x)) -#endif - -#ifndef __arch__swab16s -# define __arch__swab16s(x) do { *(x) = __arch__swab16p((x)); } while (0) -#endif -#ifndef __arch__swab32s -# define __arch__swab32s(x) do { *(x) = __arch__swab32p((x)); } while (0) -#endif -#ifndef __arch__swab64s -# define __arch__swab64s(x) do { *(x) = __arch__swab64p((x)); } while (0) -#endif - - -/* - * Allow constant folding - */ -#if defined(__GNUC__) && defined(__OPTIMIZE__) -# define __swab16(x) \ -(__builtin_constant_p((__u16)(x)) ? \ - ___swab16((x)) : \ - __fswab16((x))) -# define __swab32(x) \ -(__builtin_constant_p((__u32)(x)) ? \ - ___swab32((x)) : \ - __fswab32((x))) -# define __swab64(x) \ -(__builtin_constant_p((__u64)(x)) ? \ - ___swab64((x)) : \ - __fswab64((x))) -#else -# define __swab16(x) __fswab16(x) -# define __swab32(x) __fswab32(x) -# define __swab64(x) __fswab64(x) -#endif /* OPTIMIZE */ - - -static inline __attribute_const__ __u16 __fswab16(__u16 x) -{ - return __arch__swab16(x); -} -static inline __u16 __swab16p(const __u16 *x) -{ - return __arch__swab16p(x); -} -static inline void __swab16s(__u16 *addr) -{ - __arch__swab16s(addr); -} - -static inline __attribute_const__ __u32 __fswab32(__u32 x) -{ - return __arch__swab32(x); -} -static inline __u32 __swab32p(const __u32 *x) -{ - return __arch__swab32p(x); -} -static inline void __swab32s(__u32 *addr) -{ - __arch__swab32s(addr); -} - -#ifdef __BYTEORDER_HAS_U64__ -static inline __attribute_const__ __u64 __fswab64(__u64 x) -{ -# ifdef __SWAB_64_THRU_32__ - __u32 h = x >> 32; - __u32 l = x & ((1ULL<<32)-1); - return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h))); -# else - return __arch__swab64(x); -# endif -} -static inline __u64 __swab64p(const __u64 *x) -{ - return __arch__swab64p(x); -} -static inline void __swab64s(__u64 *addr) -{ - __arch__swab64s(addr); -} -#endif /* __BYTEORDER_HAS_U64__ */ - -#define swab16 __swab16 -#define swab32 __swab32 -#define swab64 __swab64 -#define swab16p __swab16p -#define swab32p __swab32p -#define swab64p __swab64p -#define swab16s __swab16s -#define swab32s __swab32s -#define swab64s __swab64s - -#endif /* __XEN_BYTEORDER_SWAB_H__ */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325335.547861 (Exim 4.92) (envelope-from ) id 1noMuJ-0005EX-2F; Tue, 10 May 2022 10:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325335.547861; Tue, 10 May 2022 10:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuI-0005D6-T2; Tue, 10 May 2022 10:15:54 +0000 Received: by outflank-mailman (input) for mailman id 325335; Tue, 10 May 2022 10:15:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuH-000561-Gr for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:15:53 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29c50bdf-d04a-11ec-a406-831a346695d4; Tue, 10 May 2022 12:15:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29c50bdf-d04a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177751; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0T/JNn3Dww3wHscmgvdIRfZs4Ekns00pQ2CWndQ/ZWk=; b=EEmsDdzTkk3Q8tscErIHkq4n3sRwpWEHI/InD3TnzKClI7uVBOATLtNn 1BZ53g0S3DKWFLJCiNIIHrU9YP9Xq9iIx2XPE2hFrWAxSV8QPSVm68EGY tu/7NijKfS0Hb4zpbLJiKHuPrR91Y6ikMliSlmHRAHHWIU/dBiNGSJZ6k U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70954409 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:bve7HqOmaevnueDvrR2vl8FynXyQoLVcMsEvi/4bfWQNrUok3jxUx 2cbWmzTOvePZTSkfN5zPtvkpk4FupSEn942Gwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Yw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw sRwqqKtCj8SAI7Kk8gZagVoMAZjBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYAAjWps2pgfdRrYT 8MpKgI+dw3qXxRKAFMnVs4Yrd6CoUCqJlW0r3rK/PFqsgA/1jdZ0qXpMdfTUsyHQ4NShEnwj n3C13T0BFcdLtP34TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FewUtD3Uhm8oXiFlh0RQdxdF6s98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt9n4OCNRrf6tcky+8Ly4qQquCQsyMFZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/ 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZvvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7 SFfy6ByAA3jZKxhdRBhos1QRdlFBN7faVUwZGKD+LF7rlyQF4aLJ9w43d2HDB4B3jw4UTHoe lTPngha+YVeOnCnBYcuPd/rUp5zkviwSYy4PhwxUjapSsIqHDJrAQk0PRLAt4wTuBZEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7FihIvZ8Vq9z jqqH5bTo/mpeLamMne/HE96BQ1iEEXX8ris9ZMNKr7YcloO9aNII6a5/I7NsrdNx8x9/tokN FnnMqOE4DITXUH6FDg= IronPort-HdrOrdr: A9a23:zPaLjKAGn+9BzZPlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN 5dmsNFaeEYY2IUsS+D2njbL+od X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70954409" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v3 4/6] xen: Switch to byteswap Date: Tue, 10 May 2022 06:15:22 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Update to use byteswap to swap bytes. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Changes in v3: - Update xen/common/device_tree.c to use be32_to_cpu - Keep const in type cast in unaligned.h --- xen/common/device_tree.c | 44 +++++++++++++++--------------- xen/common/libelf/libelf-private.h | 6 ++-- xen/common/xz/private.h | 2 +- xen/include/xen/unaligned.h | 24 ++++++++-------- 4 files changed, 38 insertions(+), 38 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..70d3be3be6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, if ( !val || len < sizeof(*out_value) ) return 0; - *out_value = be32_to_cpup(val); + *out_value = be32_to_cpu(*val); return 1; } @@ -264,7 +264,7 @@ int dt_property_read_variable_u32_array(const struct dt_device_node *np, count = sz; while ( count-- ) - *out_values++ = be32_to_cpup(val++); + *out_values++ = be32_to_cpu(*val++); return sz; } @@ -490,7 +490,7 @@ static int __dt_n_addr_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#address-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_ADDR_CELLS_DEFAULT; @@ -507,7 +507,7 @@ int __dt_n_size_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#size-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_SIZE_CELLS_DEFAULT; @@ -660,7 +660,7 @@ static void dt_bus_pci_count_cells(const struct dt_device_node *np, static unsigned int dt_bus_pci_get_flags(const __be32 *addr) { unsigned int flags = 0; - u32 w = be32_to_cpup(addr); + u32 w = be32_to_cpu(*addr); switch((w >> 24) & 0x03) { case 0x01: @@ -1077,7 +1077,7 @@ dt_irq_find_parent(const struct dt_device_node *child) if ( parp == NULL ) p = dt_get_parent(child); else - p = dt_find_node_by_phandle(be32_to_cpup(parp)); + p = dt_find_node_by_phandle(be32_to_cpu(*parp)); child = p; } while ( p && dt_get_property(p, "#interrupt-cells", NULL) == NULL ); @@ -1110,7 +1110,7 @@ unsigned int dt_number_of_irq(const struct dt_device_node *device) intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1241,7 +1241,7 @@ int dt_for_each_irq_map(const struct dt_device_node *dev, imaplen -= addrsize + intsize; /* Get the interrupt parent */ - ipar = dt_find_node_by_phandle(be32_to_cpup(imap)); + ipar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1358,8 +1358,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, int match, i; dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n", - parent->full_name, be32_to_cpup(intspec), - be32_to_cpup(intspec + 1), ointsize); + parent->full_name, be32_to_cpu(*intspec), + be32_to_cpu(*(intspec+1)), ointsize); ipar = parent; @@ -1471,7 +1471,7 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, dt_dprintk(" -> match=%d (imaplen=%d)\n", match, imaplen); /* Get the interrupt parent */ - newpar = dt_find_node_by_phandle(be32_to_cpup(imap)); + newpar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1565,7 +1565,7 @@ int dt_device_get_raw_irq(const struct dt_device_node *device, intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1676,7 +1676,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, * If phandle is 0, then it is an empty entry with no * arguments. Skip forward to the next entry. * */ - phandle = be32_to_cpup(list++); + phandle = be32_to_cpu(*list++); if ( phandle ) { /* @@ -1745,7 +1745,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, out_args->np = node; out_args->args_count = count; for ( i = 0; i < count; i++ ) - out_args->args[i] = be32_to_cpup(list++); + out_args->args[i] = be32_to_cpu(*list++); } /* Found it! return success */ @@ -1826,7 +1826,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, int has_name = 0; int new_format = 0; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag != FDT_BEGIN_NODE ) { printk(XENLOG_WARNING "Weird tag at start of node: %x\n", tag); @@ -1919,7 +1919,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, u32 sz, noff; const char *pname; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag == FDT_NOP ) { *p += 4; @@ -1928,8 +1928,8 @@ static unsigned long __init unflatten_dt_node(const void *fdt, if ( tag != FDT_PROP ) break; *p += 4; - sz = be32_to_cpup((__be32 *)(*p)); - noff = be32_to_cpup((__be32 *)((*p) + 4)); + sz = be32_to_cpu(*(__be32 *)(*p)); + noff = be32_to_cpu(*(__be32 *)((*p) + 4)); *p += 8; if ( fdt_version(fdt) < 0x10 ) *p = ROUNDUP(*p, sz >= 8 ? 8 : 4); @@ -1956,13 +1956,13 @@ static unsigned long __init unflatten_dt_node(const void *fdt, (strcmp(pname, "linux,phandle") == 0) ) { if ( np->phandle == 0 ) - np->phandle = be32_to_cpup((__be32*)*p); + np->phandle = be32_to_cpu(*(__be32*)*p); } /* And we process the "ibm,phandle" property * used in pSeries dynamic device tree * stuff */ if ( strcmp(pname, "ibm,phandle") == 0 ) - np->phandle = be32_to_cpup((__be32 *)*p); + np->phandle = be32_to_cpu(*(__be32 *)*p); pp->name = pname; pp->length = sz; pp->value = (void *)*p; @@ -2034,7 +2034,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, *p += 4; else mem = unflatten_dt_node(fdt, mem, p, np, allnextpp, fpsize); - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); } if ( tag != FDT_END_NODE ) { @@ -2086,7 +2086,7 @@ static void __init __unflatten_device_tree(const void *fdt, /* Second pass, do actual unflattening */ start = ((unsigned long)fdt) + fdt_off_dt_struct(fdt); unflatten_dt_node(fdt, mem, &start, NULL, &allnextp, 0); - if ( be32_to_cpup((__be32 *)start) != FDT_END ) + if ( be32_to_cpu(*(__be32 *)start) != FDT_END ) printk(XENLOG_WARNING "Weird tag at end of tree: %08x\n", *((u32 *)start)); if ( be32_to_cpu(((__be32 *)mem)[size / 4]) != 0xdeadbeef ) diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h index 47db679966..6062598fb8 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -31,9 +31,9 @@ printk(fmt, ## args ) #define strtoull(str, end, base) simple_strtoull(str, end, base) -#define bswap_16(x) swab16(x) -#define bswap_32(x) swab32(x) -#define bswap_64(x) swab64(x) +#define bswap_16(x) bswap16(x) +#define bswap_32(x) bswap32(x) +#define bswap_64(x) bswap64(x) #else /* !__XEN__ */ diff --git a/xen/common/xz/private.h b/xen/common/xz/private.h index 511343fcc2..97131fa714 100644 --- a/xen/common/xz/private.h +++ b/xen/common/xz/private.h @@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p) #endif -#define get_le32(p) le32_to_cpup((const uint32_t *)(p)) +#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p)) #define false 0 #define true 1 diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..16b2e6f5f0 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -20,62 +20,62 @@ static inline uint16_t get_unaligned_be16(const void *p) { - return be16_to_cpup(p); + return be16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_be16(uint16_t val, void *p) { - *(__force __be16*)p = cpu_to_be16(val); + *(__be16 *)p = cpu_to_be16(val); } static inline uint32_t get_unaligned_be32(const void *p) { - return be32_to_cpup(p); + return be32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_be32(uint32_t val, void *p) { - *(__force __be32*)p = cpu_to_be32(val); + *(__be32 *)p = cpu_to_be32(val); } static inline uint64_t get_unaligned_be64(const void *p) { - return be64_to_cpup(p); + return be64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_be64(uint64_t val, void *p) { - *(__force __be64*)p = cpu_to_be64(val); + *(__be64 *)p = cpu_to_be64(val); } static inline uint16_t get_unaligned_le16(const void *p) { - return le16_to_cpup(p); + return le16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_le16(uint16_t val, void *p) { - *(__force __le16*)p = cpu_to_le16(val); + *(__le16 *)p = cpu_to_le16(val); } static inline uint32_t get_unaligned_le32(const void *p) { - return le32_to_cpup(p); + return le32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_le32(uint32_t val, void *p) { - *(__force __le32*)p = cpu_to_le32(val); + *(__le32 *)p = cpu_to_le32(val); } static inline uint64_t get_unaligned_le64(const void *p) { - return le64_to_cpup(p); + return le64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_le64(uint64_t val, void *p) { - *(__force __le64*)p = cpu_to_le64(val); + *(__le64 *)p = cpu_to_le64(val); } #endif /* __XEN_UNALIGNED_H__ */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325338.547898 (Exim 4.92) (envelope-from ) id 1noMuP-0006C4-15; Tue, 10 May 2022 10:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325338.547898; Tue, 10 May 2022 10:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuO-0006Bu-TG; Tue, 10 May 2022 10:16:00 +0000 Received: by outflank-mailman (input) for mailman id 325338; Tue, 10 May 2022 10:15:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuN-000561-Cd for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:15:59 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f292f68-d04a-11ec-a406-831a346695d4; Tue, 10 May 2022 12:15:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f292f68-d04a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177758; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tSkw06p+M7uP7rlqOhJWwx1pKczcdXCgiRbYRyRDoo0=; b=YITwRWslsgDcRp/wyUTVR+IdD1LIxVUSgmx6s5C/nfy/ODUz9SnQuhQg WkwyV1ecEZAv9jntZfi//147gwBM2gBE41nY7Yq5wd3cxGlNFKmz662ZJ cLt+46ozJ5Rc/wrhecirW14R0Eykvyq2idsQ7yW5miXOOt9uw9rpt8XdE s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 73450899 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:tPyCraw07xLtcff5x7V6t+cUxirEfRIJ4+MujC+fZmUNrF6WrkUFx 2QWD2qGP/3eYWX3e9EjbY7k/BtU65HRnYBlQAo5pCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IDhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplv7fuGSN0IfD3vuUMCAVSAisvA6hcweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DOIIZ/HVh0BnSDOo8QICFSKLPjTNd9Ghr2p0WTaePD yYfQWI/UhODaUZIAGZJVZEzsqSzgVLVcCIN/Tp5ooJoujOOnWSdyoPFOtfPZsaDQ8kTm0+Cv 3/H5EzwGBRcP9uaoRK79Xariv7KjDnMcosYH72l9dZnmFSWgGcUDXU+V0a/oPS/ol6zXZRYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8+B2FD2IJSjpAbt0Ot8IsQzEuk FiTkLvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsRyBbs/2+v9wIqBPeFcppAaTksNjvIGSlq 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgPZ1 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGwnTKuKGpxdEdMMX KM0kVkIjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwOBTJhTmywBhwyfxX1 XKnnSGEVy1yNEia5GDuG7d1PUEDmEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy P4Gb5Hi40wGCIXWO3CLmaZOfAtiBSVqWvjLRzl/K7frzvxOQzlxVZc8ANoJJuRYokiivr2Wo SvhChQImDISRxTvcG23V5yqU5u3Nb4XkJ7xFXVE0YqAs5T7XbuS0Q== IronPort-HdrOrdr: A9a23:tzgFw6P4s74yIMBcTvujsMiBIKoaSvp037Eqv3oRdfUzSL3gqy nOpoVh6faaskdzZJhNo7+90ey7MBfhHP1OkO8s1NWZLWvbUQKTRekIh+aP/9SjIVyYygc079 YZT0EUMr3N5DZB4/oSmDPIduod/A== X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="73450899" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 3/6] arm64/find_next_bit: Remove ext2_swab() Date: Tue, 10 May 2022 06:15:21 -0400 Message-ID: <48bdc1be03a77bcc405e327b8022fcd937186e9e.1652170719.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain ext2 has nothing to do with this logic. Clean up the code with xen/byteswap.h which now has an unsigned long helper. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk This patche is not well tested without running environment for arm --- xen/arch/arm/arm64/lib/find_next_bit.c | 36 +++++--------------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c index 8ebf8bfe97..e3b3720ff4 100644 --- a/xen/arch/arm/arm64/lib/find_next_bit.c +++ b/xen/arch/arm/arm64/lib/find_next_bit.c @@ -161,30 +161,6 @@ EXPORT_SYMBOL(find_first_zero_bit); #ifdef __BIG_ENDIAN -/* include/linux/byteorder does not support "unsigned long" type */ -static inline unsigned long ext2_swabp(const unsigned long * x) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64p((u64 *) x); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32p((u32 *) x); -#else -#error BITS_PER_LONG not defined -#endif -} - -/* include/linux/byteorder doesn't support "unsigned long" type */ -static inline unsigned long ext2_swab(const unsigned long y) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64((u64) y); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32((u32) y); -#else -#error BITS_PER_LONG not defined -#endif -} - #ifndef find_next_zero_bit_le unsigned long find_next_zero_bit_le(const void *addr, unsigned long size, unsigned long offset) @@ -199,7 +175,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp |= (~0UL >> (BITS_PER_LONG - offset)); if (size < BITS_PER_LONG) goto found_first; @@ -217,7 +193,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp |= ~0UL << size; if (tmp == ~0UL) /* Are any bits zero? */ @@ -226,7 +202,7 @@ found_middle: return result + ffz(tmp); found_middle_swap: - return result + ffz(ext2_swab(tmp)); + return result + ffz(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_zero_bit_le); #endif @@ -245,7 +221,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp &= (~0UL << offset); if (size < BITS_PER_LONG) goto found_first; @@ -264,7 +240,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp &= (~0UL >> (BITS_PER_LONG - size)); if (tmp == 0UL) /* Are any bits set? */ @@ -273,7 +249,7 @@ found_middle: return result + __ffs(tmp); found_middle_swap: - return result + __ffs(ext2_swab(tmp)); + return result + __ffs(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_bit_le); #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325336.547868 (Exim 4.92) (envelope-from ) id 1noMuJ-0005KU-Ex; Tue, 10 May 2022 10:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325336.547868; Tue, 10 May 2022 10:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuJ-0005Iy-6v; Tue, 10 May 2022 10:15:55 +0000 Received: by outflank-mailman (input) for mailman id 325336; Tue, 10 May 2022 10:15:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuI-000561-9M for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:15:54 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c2a401e-d04a-11ec-a406-831a346695d4; Tue, 10 May 2022 12:15:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c2a401e-d04a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177753; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vAwEG8ep7queso8cVxSz5fAnFQyJV9WnYmQA5HibJZQ=; b=gqC1vIksuqG7vDX2TFXtryrua+qX9mYL2qQFyS9HhyZW1G8ZHx0KoOZE 4AjuGs8QsC+1Rfe8zDuFaBrU4UT5NEHWaqnKXPBGRqCp2snc/ZXQid5pD HbCLJpJbKI8qLBLbFPFSg7FtRWOSOnHE4SuZDU1gVbezkO8nK6qGpzYcj 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70954410 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:97wGWqkTf3tYqL35HcatMPHo5gzhJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdXDiAafaJMGLwLo8nad61oUIPvpWHyNRqHVNtqHpgQyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWlvV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYYhp1EKGQm/Ukb0d7HAclOZ1KpeHLCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3vnBmizXYEN4tQIzZQrWM7thdtNs1rp8WTKuCO 5NBAdZpRBDPRyxxCl4RNKkvsuiNgnX1IgF68XvA8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv W+A9GP8ajkFMPSPxDzD9Wij7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA xVKoGx09/F0rRH1CImmN/GlnJKaljUBB/RcT+4r0T3T6aXyuAKpCjVaQhcUPbTKq/QKbTAt0 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/45SMaIYsvJ9SYcK txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPeZJhKTysDA3CMqsy67DFzG8U IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWn3oiT6ItAAvGkjTKuMDirjUWWyC HI/RCsLvMMDVJdURfEfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY M/zWZ/1UR4yVPU8pBLrFrh17FPe7n1nrY8lbcujn0rPPHv3TCP9dIrpx3PUML9jsPPf8FW9H hQ2H5Li9iizmdbWOkH/mbP/53hQRZTnLfgac/BqS9M= IronPort-HdrOrdr: A9a23:7Iquia4cpNTL9TfGrAPXwPDXdLJyesId70hD6qhwISY6TiX+rb HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70954410" From: Lin Liu To: CC: Lin Liu , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v3 6/6] tools: Remove unnecessary header Date: Tue, 10 May 2022 06:15:24 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain xen/byteorder/little_endian.h is included but not used, Remove it. No functional change. Signed-off-by: Lin Liu --- Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross --- tools/libs/guest/xg_dom_decompress_unsafe_zstd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c index 01eafaaaa6..47e071574d 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c @@ -31,7 +31,6 @@ typedef uint64_t __be64; #define __BYTEORDER_HAS_U64__ #define __TYPES_H__ /* xen/types.h guard */ -#include "../../xen/include/xen/byteorder/little_endian.h" #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ #include "../../xen/include/xen/unaligned.h" #include "../../xen/include/xen/xxhash.h" -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325339.547909 (Exim 4.92) (envelope-from ) id 1noMuQ-0006Ut-O2; Tue, 10 May 2022 10:16:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325339.547909; Tue, 10 May 2022 10:16:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuQ-0006Tt-Ga; Tue, 10 May 2022 10:16:02 +0000 Received: by outflank-mailman (input) for mailman id 325339; Tue, 10 May 2022 10:16:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuO-000561-Ih for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:16:00 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ed209b0-d04a-11ec-a406-831a346695d4; Tue, 10 May 2022 12:15:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ed209b0-d04a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177758; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FBx5VXViH2N+eGGpOUcQCz2z12c6GtTDSfMwDmCLLRQ=; b=gwBvgm3VJ/R45JGo/aVGhZ+ohl1fRCfMbZioevIqAhmV6lrU0x3jws5a BpIyc7tpz+LNkyyS7zZ0WfQcQVQ6qg3hPa8EfokGissi649zJzNQgYwQc FqL5FvFSwKuqq7Iw3/RJzoZ/PEDPhMdgJp0i2AwZ6HXLWYJI5VWYtIUqI o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70351037 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:KqtWoK58/i/gMmkLaNnoBAxRtPjHchMFZxGqfqrLsTDasY5as4F+v jMXCmiDbKyDazf1f4sibti19xkOvZWEx4I2Sgc+rCE9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgW1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS8Thx1P7HQoN4fUgRhA2J7J51gxZLIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsbu3cmyTDEJf0nXYrCU+PB4towMDIY2ZgVQK+GP JVxhTxHZkXgYT5iKn0uNcgjpb2Ull/neRFCtwfAzUYwyzeKl1EguFT3C/LXcNGXQcRenm6Du 3nLuW/+B3kyNsGbyDeD2mKhgKnIhyyTcJ0WPK218LhtmlL77lIUDBoaRF6qu86Tg0S1W89cA 0EM8y9opq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9YXiQ7KuOpDW+fy0cN3YfZDQsRBEApdLkpekOYgnnF4g5VvTv15usRG+2k 2viQDUCa6s7gckQi6Sn4Wj9gTOxn4iKSxQFwDj6UTfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8N5nwlB7UJPamy5DNtWAE5yevgJdjbyC KM4kVMAvcQDVJdGgEIeXm5QNyjI5fW5fTgGfqqNBjarXnSWXFXelByCnWbKgwjQfLEEyMnTw 6uzf8e2Fmo9Aq961jewTOp1+eZ1m3pnnzqMFcCnl0nPPV+iiJm9E+xtDbdzRrphsPPsTPv9r b6zyPdmOz0ACbajM0E7AKYYLEwQLGhTOHwFg5c/SwJ3GSI/QDtJI6aImdsJItU594wIx7yg1 izsBSdlJK/X2CSvxfOiMSgzNtsCnP9X8BoGAMDbFQz2hCJ/Md3/vM/ytfIfJNEayQCq9tYsJ 9FtRilKKq0npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:GBFz3K8Uk8EIMM93lWFuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70351037" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 1/6] xen: implement byteswap Date: Tue, 10 May 2022 06:15:19 -0400 Message-ID: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit swab() is massively over complicated and can be simplified by builtins. The compilers provide builtin function to swap bytes. * gcc: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html * clang: https://clang.llvm.org/docs/LanguageExtensions.html This patch simplify swab() with builtins and fallback for old compilers. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Cc: "Roger Pau Monné" Changes in v3: - Check __has_builtin instead of GNUC version Changes in v2: - Add fallback for compilers without __builtin_bswap - Implement with plain C instead of macros --- xen/arch/arm/include/asm/byteorder.h | 14 ++----- xen/arch/x86/include/asm/byteorder.h | 34 ++--------------- xen/include/xen/byteorder.h | 56 ++++++++++++++++++++++++++++ xen/include/xen/byteswap.h | 44 ++++++++++++++++++++++ xen/include/xen/compiler.h | 12 ++++++ 5 files changed, 120 insertions(+), 40 deletions(-) create mode 100644 xen/include/xen/byteorder.h create mode 100644 xen/include/xen/byteswap.h diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h index 9c712c4788..622eeaba07 100644 --- a/xen/arch/arm/include/asm/byteorder.h +++ b/xen/arch/arm/include/asm/byteorder.h @@ -1,16 +1,10 @@ #ifndef __ASM_ARM_BYTEORDER_H__ #define __ASM_ARM_BYTEORDER_H__ -#define __BYTEORDER_HAS_U64__ +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -#include +#include #endif /* __ASM_ARM_BYTEORDER_H__ */ -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/xen/arch/x86/include/asm/byteorder.h b/xen/arch/x86/include/asm/byteorder.h index 1f77e502a5..82aadee7bd 100644 --- a/xen/arch/x86/include/asm/byteorder.h +++ b/xen/arch/x86/include/asm/byteorder.h @@ -1,36 +1,10 @@ #ifndef __ASM_X86_BYTEORDER_H__ #define __ASM_X86_BYTEORDER_H__ -#include -#include +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -static inline __attribute_const__ __u32 ___arch__swab32(__u32 x) -{ - asm("bswap %0" : "=r" (x) : "0" (x)); - return x; -} - -static inline __attribute_const__ __u64 ___arch__swab64(__u64 val) -{ - union { - struct { __u32 a,b; } s; - __u64 u; - } v; - v.u = val; - asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" - : "=r" (v.s.a), "=r" (v.s.b) - : "0" (v.s.a), "1" (v.s.b)); - return v.u; -} - -/* Do not define swab16. Gcc is smart enough to recognize "C" version and - convert it into rotation or exhange. */ - -#define __arch__swab64(x) ___arch__swab64(x) -#define __arch__swab32(x) ___arch__swab32(x) - -#define __BYTEORDER_HAS_U64__ - -#include +#include #endif /* __ASM_X86_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteorder.h b/xen/include/xen/byteorder.h new file mode 100644 index 0000000000..2ec434e6a6 --- /dev/null +++ b/xen/include/xen/byteorder.h @@ -0,0 +1,56 @@ +#ifndef __XEN_BYTEORDER_H__ +#define __XEN_BYTEORDER_H__ + +#include + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ + +# ifndef __LITTLE_ENDIAN +# define __LITTLE_ENDIAN 1234 +# endif + +# ifndef __LITTLE_ENDIAN_BITFIELD +# define __LITTLE_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) (x) +# define le64_to_cpu(x) (x) +# define cpu_to_le32(x) (x) +# define le32_to_cpu(x) (x) +# define cpu_to_le16(x) (x) +# define le16_to_cpu(x) (x) +# define cpu_to_be64(x) bswap64(x) +# define be64_to_cpu(x) bswap64(x) +# define cpu_to_be32(x) bswap32(x) +# define be32_to_cpu(x) bswap32(x) +# define cpu_to_be16(x) bswap16(x) +# define be16_to_cpu(x) bswap16(x) + +#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ + +# ifndef __BIG_ENDIAN +# define __BIG_ENDIAN 4321 +# endif + +# ifndef __BIG_ENDIAN_BITFIELD +# define __BIG_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) bswap64(x) +# define le64_to_cpu(x) bswap64(x) +# define cpu_to_le32(x) bswap32(x) +# define le32_to_cpu(x) bswap32(x) +# define cpu_to_le16(x) bswap16(x) +# define le16_to_cpu(x) bswap16(x) +# define cpu_to_be64(x) (x) +# define be64_to_cpu(x) (x) +# define cpu_to_be32(x) (x) +# define be32_to_cpu(x) (x) +# define cpu_to_be16(x) (x) +# define be16_to_cpu(x) (x) + +#else +# error "Unknown Endianness" +#endif /* __BYTE_ORDER__ */ + +#endif /* __XEN_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteswap.h b/xen/include/xen/byteswap.h new file mode 100644 index 0000000000..0dd5567557 --- /dev/null +++ b/xen/include/xen/byteswap.h @@ -0,0 +1,44 @@ +#ifndef __XEN_BYTESWAP_H__ +#define __XEN_BYTESWAP_H__ + +#include +#include + +#if !__has_builtin(__builtin_bswap16) +static always_inline uint16_t __builtin_bswap16(uint16_t val) +{ + return ((val & 0x00FF) << 8) | ((val & 0xFF00) >> 8); +} +#endif + +#if !__has_builtin(__builtin_bswap32) +static always_inline uint32_t __builtin_bswap32(uint32_t val) +{ + return ((val & 0x000000FF) << 24) | + ((val & 0x0000FF00) << 8) | + ((val & 0x00FF0000) >> 8) | + ((val & 0xFF000000) >> 24); +} +#endif + +#if !__has_builtin(__builtin_bswap64) +static always_inline uint64_t __builtin_bswap64(uint64_t val) +{ + return ((val & 0x00000000000000FF) << 56) | + ((val & 0x000000000000FF00) << 40) | + ((val & 0x0000000000FF0000) << 24) | + ((val & 0x00000000FF000000) << 8) | + ((val & 0x000000FF00000000) >> 8) | + ((val & 0x0000FF0000000000) >> 24) | + ((val & 0x00FF000000000000) >> 40) | + ((val & 0xFF00000000000000) >> 56); +} +#endif + +#define bswap16(x) __builtin_bswap16(x) +#define bswap32(x) __builtin_bswap32(x) +#define bswap64(x) __builtin_bswap64(x) + +#define bswap_ul(x) PASTE(bswap,BITS_PER_LONG)(x) + +#endif /* __XEN_BYTESWAP_H__ */ diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 933aec09a9..05b1b8b24d 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -185,4 +185,16 @@ # define CLANG_DISABLE_WARN_GCC_COMPAT_END #endif +#ifndef __has_builtin +/* + * Backwards compatibility for GCC < 10. + * All supported versions of Clang support __has_builtin + * */ +#define __has_builtin(x) GCC_has ## x + +#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >= 40800) +#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >= 40400) +#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >= 40400) +#endif + #endif /* __LINUX_COMPILER_H */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325337.547887 (Exim 4.92) (envelope-from ) id 1noMuK-0005q7-Mc; Tue, 10 May 2022 10:15:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325337.547887; Tue, 10 May 2022 10:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuK-0005pK-IT; Tue, 10 May 2022 10:15:56 +0000 Received: by outflank-mailman (input) for mailman id 325337; Tue, 10 May 2022 10:15:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuJ-000561-92 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:15:55 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b6f09a4-d04a-11ec-a406-831a346695d4; Tue, 10 May 2022 12:15:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b6f09a4-d04a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177753; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=/Nhh6O3K3Agbq3nu1O78zNSNYAf52U6Xs2gVsrQwIMk=; b=b1FzRXq62AvVsdvGCyH+mov/xEhhYaO8O/JUFyPXWGez79fVzkt0HPzm SJWFsZtYSEhIvPfB4o7lME+llGA6ZXNZsW926+b6cH7jRcsjEZRv98VH8 ksJXlCByqx9YSZ0jD+y7sD/oYBPAQhy6eEnRuhs6Joz34QQVUP4is3+uM s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 73450891 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+XnD/6wXK1JbawCRDnt6t+e+xirEfRIJ4+MujC+fZmUNrF6WrkUBm mYWC27SOfuMNGH0eI9ya4SwoRgB6pKDzNJlHgBt+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IDhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npll4GZECp1IJH1ts89SkQDFgAvA7QbweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DOIIZ/HVh0BnSDOo8QICFSKLPjTNd9Ghr2p0WTaeHD yYfQT1wczHqe0NEA3RJL5Yalv2wh1LmdzIN/Tp5ooJoujOOnWSdyoPFK8HJc9aHQcFUmEewp W/c+Wn9RBYAO7S3yj2D6HugwPDOmSDTX5gbH7m1sPVthTW7+GsXDxEHUEqhltOwgEW+RtF3J lQd/2wlqq1a3FOvZsnwWVu/unHslhwBX9tdFcUq5QfLzbDbiy6VCWQJQSRIQMA3v88xAzox3 xmGmM2BLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbggrUS9d/EIa8ltDvBSzr2 DeOsTQ/gLMIy8UM0s2T/1rKnjatrZjhVRMu60PcWWfNxgJmZqa1aoqw81/Z4P1caoGDQTG8U GMswpbEqrpUVNfUyXLLEL5l8KyVC+itEiD12HMzAaUY2R+N4iP4eKEB3igjHRI8WiobQgPBb EjWsAJXwZZcOnq2cKN6C76M59QWIbvIToq8CK2NBjZaSt0oLVLconkyDaKF9zq1+HXAh53TL ntynSyEKX8BQZpqwzOtLwv2+e96n3turY8/qH2S8vhG7VZ8TCPMIVvmGAHXBgzc0E9jiF+Mm +uzz+PQl31ivBTWO0E7C7I7I1EQNmQcDpvrscFRfePrClM4RTt4UaaOkeN9I9ENc0FpegDgp CrVZ6Ol4ACn2S2vxfuiNBiPl48Drb4g9ClmbETAzH6j2mQ5YJbH0UvsX8BfQFXTz8Q6laQcZ 6BcI62oW60TIhyaqm91RcSs8+RfmOGD2Fvm09yNO2BvIfaNhmXhp7fZQ+cY3HNQUXDr5ZBu8 9VNFGrzGPI+euirN+6OANrH8r97lSN1dD5aN6cQHuRuRQ== IronPort-HdrOrdr: A9a23:dhdoR6kuisvMKGMujIlWtkvmY9TpDfIg3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7wr5OUtQ/exoV5PhfZqxz/JICOoqTNKftWvdyQiVxehZhOOIqVDd8kXFh4hgPM xbEpSWZueeMbEDt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="73450891" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , Daniel De Graaf , "Daniel P. Smith" , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Konrad Rzeszutek Wilk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Ross Lagerwall , Stefano Stabellini , Volodymyr Babchuk , Wei Liu Subject: [PATCH v3 0/6] Implement byteswap and update references Date: Tue, 10 May 2022 06:15:18 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The swab() is massively over complicated Simplify it with compiler builtins and fallback to plain C function if undefined. Update components to switch to this new swap bytes. Lin Liu (6): xen: implement byteswap crypto/vmac: Simplify code with byteswap arm64/find_next_bit: Remove ext2_swab() xen: Switch to byteswap byteorder: Remove byteorder tools: Remove unnecessary header .../guest/xg_dom_decompress_unsafe_zstd.c | 1 - xen/arch/arm/arm64/lib/find_next_bit.c | 36 +--- xen/arch/arm/include/asm/byteorder.h | 14 +- xen/arch/x86/include/asm/byteorder.h | 34 +--- xen/common/device_tree.c | 44 ++--- xen/common/libelf/libelf-private.h | 6 +- xen/common/xz/private.h | 2 +- xen/crypto/vmac.c | 76 +------- xen/include/xen/byteorder.h | 56 ++++++ xen/include/xen/byteorder/big_endian.h | 102 ---------- xen/include/xen/byteorder/generic.h | 68 ------- xen/include/xen/byteorder/little_endian.h | 102 ---------- xen/include/xen/byteorder/swab.h | 183 ------------------ xen/include/xen/byteswap.h | 44 +++++ xen/include/xen/compiler.h | 12 ++ xen/include/xen/unaligned.h | 24 +-- 16 files changed, 167 insertions(+), 637 deletions(-) create mode 100644 xen/include/xen/byteorder.h delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h create mode 100644 xen/include/xen/byteswap.h -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:16:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325340.547920 (Exim 4.92) (envelope-from ) id 1noMuV-0006wd-7U; Tue, 10 May 2022 10:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325340.547920; Tue, 10 May 2022 10:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuV-0006wQ-1w; Tue, 10 May 2022 10:16:07 +0000 Received: by outflank-mailman (input) for mailman id 325340; Tue, 10 May 2022 10:16:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noMuT-00055w-Hu for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:16:05 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 320097b6-d04a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 12:16:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 320097b6-d04a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652177763; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pihspNLolWNcndSwdSRcONnMwvkmXayMv7dBXhsK0NA=; b=OGNl9bp7B0VLuVwxx+tmiSBE3iV49cnZrVlJ5RuxIrtLbcS+/IzIODcD 1q1kgsIbn3JyDLhtmAcCw/M+bj9h9qjWtF2pBOYgnPMDGcMqQ7og7mMiI C+fO8viY7KwKDGAh+tBO99bMZk59i3rVP8XAT2egAoGi5fylTBIEleGu+ g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70954436 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/nf4JajtdGeUrUHiFT/tVwvMX161ahAKZh0ujC45NGQN5FlHY01je htvXGGBbPfcN2L9ed1/bI+19xwE65DTxoQyHFFt+SpgEi0b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrV4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQR3IpKUiOM/akljGTBUeupt4eTVPHfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknVhy3fdDOsOSpHfWaTao9Rf2V/cg+gRRaeDO 5ZCN1KDajzaQURNJlUeLagEu9zxpHnTSRla91288P9fD2/7k1UqjemF3MDuUt6XQcRYmG6Iq 2SA+H72ajkFMPSPxDzD9Wij7sfUhj/yUo8WELy+99ZpjUeVy2hVDwcZPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcblXoVRYYNoZg7pVvA2V3i BnZxLsFGACDrpWWF26irqeTjwriAiIEByhFTjZfXxYKtoyLTJ4IsjrDSdNqEaiQh9LzGC3tz z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNtFsRWWKzW2C/BbE3B95kJZ3RcFSOt WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWS0bb1HRcBJG9GRF5mLJ9k43d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa9T42/D6+EPoYWP/CdkTNrGwk0PiatM53FyhBwwcnTx 7/FGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiEq L53aprVoyizpcWjO0E7B6ZIdQBURZX6bLirw/FqmhmreFQ5Qj1xUK+BqV7jEqQ895loei7z1 inVcidlJJDX3hUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:ygCE/auHafWTU2F1XNJ3+MoA7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70954436" From: Lin Liu To: CC: Lin Liu , Jan Beulich , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 2/6] crypto/vmac: Simplify code with byteswap Date: Tue, 10 May 2022 06:15:20 -0400 Message-ID: <4bf9200cfbd798130d2ef68c9b0f5373f72a1b95.1652170719.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This file has its own implementation of swap bytes. Clean up the code with xen/byteswap.h. No functional change. Signed-off-by: Lin Liu Acked-by: Jan Beulich --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu --- xen/crypto/vmac.c | 76 ++--------------------------------------------- 1 file changed, 3 insertions(+), 73 deletions(-) diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index 294dd16a52..acb4e015f5 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -8,6 +8,7 @@ /* start for Xen */ #include +#include #include #include #include @@ -50,7 +51,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ * MUL64: 64x64->128-bit multiplication * PMUL64: assumes top bits cleared on inputs * ADD128: 128x128->128-bit addition - * GET_REVERSED_64: load and byte-reverse 64-bit word * ----------------------------------------------------------------------- */ /* ----------------------------------------------------------------------- */ @@ -68,22 +68,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({uint64_t x; \ - asm ("bswapq %0" : "=r" (x) : "0"(*(uint64_t *)(p))); x;}) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && __i386__) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint64_t x; \ - uint32_t *tp = (uint32_t *)(p); \ - asm ("bswap %%edx\n\t" \ - "bswap %%eax" \ - : "=A"(x) \ - : "a"(tp[1]), "d"(tp[0])); \ - x; }) /* ----------------------------------------------------------------------- */ #elif (__GNUC__ && __ppc64__) @@ -103,37 +87,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ppc__ || __PPC__)) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ARMEL__ || __ARM__)) -/* ----------------------------------------------------------------------- */ - -#define bswap32(v) \ -({ uint32_t tmp,out; \ - asm volatile( \ - "eor %1, %2, %2, ror #16\n" \ - "bic %1, %1, #0x00ff0000\n" \ - "mov %0, %2, ror #8\n" \ - "eor %0, %0, %1, lsr #8" \ - : "=r" (out), "=&r" (tmp) \ - : "r" (v)); \ - out;}) - /* ----------------------------------------------------------------------- */ #elif _MSC_VER /* ----------------------------------------------------------------------- */ @@ -154,11 +107,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ (rh) += (ih) + ((rl) < (_il)); \ } -#if _MSC_VER >= 1300 -#define GET_REVERSED_64(p) _byteswap_uint64(*(uint64_t *)(p)) -#pragma intrinsic(_byteswap_uint64) -#endif - #if _MSC_VER >= 1400 && \ (!defined(__INTEL_COMPILER) || __INTEL_COMPILER >= 1000) #define MUL32(i1,i2) (__emulu((uint32_t)(i1),(uint32_t)(i2))) @@ -219,24 +167,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ } #endif -#ifndef GET_REVERSED_64 -#ifndef bswap64 -#ifndef bswap32 -#define bswap32(x) \ - ({ uint32_t bsx = (x); \ - ((((bsx) & 0xff000000u) >> 24) | (((bsx) & 0x00ff0000u) >> 8) | \ - (((bsx) & 0x0000ff00u) << 8) | (((bsx) & 0x000000ffu) << 24)); }) -#endif -#define bswap64(x) \ - ({ union { uint64_t ll; uint32_t l[2]; } w, r; \ - w.ll = (x); \ - r.l[0] = bswap32 (w.l[1]); \ - r.l[1] = bswap32 (w.l[0]); \ - r.ll; }) -#endif -#define GET_REVERSED_64(p) bswap64(*(uint64_t *)(p)) -#endif - /* ----------------------------------------------------------------------- */ #if (VMAC_PREFER_BIG_ENDIAN) @@ -247,9 +177,9 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #if (VMAC_ARCH_BIG_ENDIAN) # define get64BE(ptr) (*(uint64_t *)(ptr)) -# define get64LE(ptr) GET_REVERSED_64(ptr) +# define get64LE(ptr) bswap64(*(uint64_t *)(ptr)) #else /* assume little-endian */ -# define get64BE(ptr) GET_REVERSED_64(ptr) +# define get64BE(ptr) bswap64(*(uint64_t *)(ptr)) # define get64LE(ptr) (*(uint64_t *)(ptr)) #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Tue May 10 10:51:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:51:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325385.547931 (Exim 4.92) (envelope-from ) id 1noNSA-0004u3-S9; Tue, 10 May 2022 10:50:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325385.547931; Tue, 10 May 2022 10:50:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSA-0004tw-Oo; Tue, 10 May 2022 10:50:54 +0000 Received: by outflank-mailman (input) for mailman id 325385; Tue, 10 May 2022 10:50:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSA-0004tq-3x for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:50:54 +0000 Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ece334d-d04f-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 12:50:51 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47088) by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noNS0-000Sjz-K5 (Exim 4.95) (return-path ); Tue, 10 May 2022 11:50:44 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id DF8C51FA59; Tue, 10 May 2022 11:50:43 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ece334d-d04f-11ec-8fc4-03012f2f19d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Tue, 10 May 2022 11:50:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-GB To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> From: Andrew Cooper Subject: Re: [PATCH v3 1/6] xen: implement byteswap In-Reply-To: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/05/2022 11:15, Lin Liu wrote: > swab() is massively over complicated and can be simplified by builtins. > The compilers provide builtin function to swap bytes. > * gcc: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html > * clang: https://clang.llvm.org/docs/LanguageExtensions.html > This patch simplify swab() with builtins and fallback for old compilers. Arguably, this patch introduces a new byteswapping infrastructure in terms of compiler builtins and bswapXX(), so the swab() infrastructure can be retired. > diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h > index 9c712c4788..622eeaba07 100644 > --- a/xen/arch/arm/include/asm/byteorder.h > +++ b/xen/arch/arm/include/asm/byteorder.h > @@ -1,16 +1,10 @@ > #ifndef __ASM_ARM_BYTEORDER_H__ > #define __ASM_ARM_BYTEORDER_H__ > > -#define __BYTEORDER_HAS_U64__ > +#ifndef __BYTE_ORDER__ > + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ > +#endif This won't actually do what you want on GCC 4.5 or older.  You also want #ifndef __ORDER_LITTLE_ENDIAN__ # define __ORDER_LITTLE_ENDIAN__ 1234 #endif #ifndef __ORDER_BIG_ENDIAN__ # define __ORDER_BIG_ENDIAN__ 4321 #endif in compiler.h to cope with older GCC. Otherwise, LGTM.  Reviewed-by: Andrew Cooper I can fix this on commit if its the only issue issue.  Otherwise, please correct it when posting v4. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 10 10:51:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325386.547941 (Exim 4.92) (envelope-from ) id 1noNSL-0005Bn-5s; Tue, 10 May 2022 10:51:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325386.547941; Tue, 10 May 2022 10:51:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSL-0005Be-1q; Tue, 10 May 2022 10:51:05 +0000 Received: by outflank-mailman (input) for mailman id 325386; Tue, 10 May 2022 10:51:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSJ-0005B5-92 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:51:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSJ-0003Vv-2F; Tue, 10 May 2022 10:51:03 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noNSI-0002ie-SH; Tue, 10 May 2022 10:51:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4fPIwetfaqg9PTZws7aNS+236Yx6R85O3VbUY8WxxfA=; b=kqQEUHVPnimSit+0SnuWp04JtY e+YrGPHIE9OZrYhS4aayv8GMExtxLEsHOiKtYSXnOaR5lxQFr/rDpZW2BGkQNDbCzGPesdo0N71fz qtKTVhUYhZS++MpVv5bEvdxnvjiDXECa6Q0DFV1dDQQFJ6OoA1hGeGeO7CXnqCSx24N8=; Message-ID: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> Date: Tue, 10 May 2022 11:51:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/05/2022 11:15, Lin Liu wrote: > Update to use byteswap to swap bytes. > > No functional change. > > Signed-off-by: Lin Liu > --- > Cc: Stefano Stabellini > Cc: Julien Grall > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Wei Liu > Changes in v3: > - Update xen/common/device_tree.c to use be32_to_cpu > - Keep const in type cast in unaligned.h > --- > xen/common/device_tree.c | 44 +++++++++++++++--------------- > xen/common/libelf/libelf-private.h | 6 ++-- > xen/common/xz/private.h | 2 +- > xen/include/xen/unaligned.h | 24 ++++++++-------- > 4 files changed, 38 insertions(+), 38 deletions(-) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 4aae281e89..70d3be3be6 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, > if ( !val || len < sizeof(*out_value) ) > return 0; > > - *out_value = be32_to_cpup(val); > + *out_value = be32_to_cpu(*val); This code has been taken from Linux and I would rather prefer to keep the *cpup* helpers to avoid any changes when backporting. > diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h > index 0a2b16d05d..16b2e6f5f0 100644 > --- a/xen/include/xen/unaligned.h > +++ b/xen/include/xen/unaligned.h > @@ -20,62 +20,62 @@ > > static inline uint16_t get_unaligned_be16(const void *p) > { > - return be16_to_cpup(p); > + return be16_to_cpu(*(const uint16_t *)p) I haven't checked the existing implementation of be16_to_cpup(). However, this new approach would allow the compiler to use a single load instruction to read the 16-bit value from memory. So this change may break on platform where unaligned access is forbidden (such as arm32). > } > > static inline void put_unaligned_be16(uint16_t val, void *p) > { > - *(__force __be16*)p = cpu_to_be16(val); > + *(__be16 *)p = cpu_to_be16(val); Why did you drop the __force? > } > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 10:51:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:51:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325388.547953 (Exim 4.92) (envelope-from ) id 1noNSQ-0005WY-Ki; Tue, 10 May 2022 10:51:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325388.547953; Tue, 10 May 2022 10:51:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSQ-0005WP-He; Tue, 10 May 2022 10:51:10 +0000 Received: by outflank-mailman (input) for mailman id 325388; Tue, 10 May 2022 10:51:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNSP-0004tq-Mf for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:51:09 +0000 Received: from ppsw-31.csi.cam.ac.uk (ppsw-31.csi.cam.ac.uk [131.111.8.131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 197c483c-d04f-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 12:51:09 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47090) by ppsw-31.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noNSL-000SzX-Jf (Exim 4.95) (return-path ); Tue, 10 May 2022 11:51:05 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D389A1FA59; Tue, 10 May 2022 11:51:04 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 197c483c-d04f-11ec-8fc4-03012f2f19d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <5d7a33e6-aae1-a6fe-8141-0ac27274aa53@srcf.net> Date: Tue, 10 May 2022 11:51:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 2/6] crypto/vmac: Simplify code with byteswap Content-Language: en-GB To: Lin Liu , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <4bf9200cfbd798130d2ef68c9b0f5373f72a1b95.1652170719.git.lin.liu@citrix.com> From: Andrew Cooper In-Reply-To: <4bf9200cfbd798130d2ef68c9b0f5373f72a1b95.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 11:15, Lin Liu wrote: > This file has its own implementation of swap bytes. Clean up > the code with xen/byteswap.h. > > No functional change. > > Signed-off-by: Lin Liu > Acked-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue May 10 10:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325406.547964 (Exim 4.92) (envelope-from ) id 1noNTQ-0006oD-W2; Tue, 10 May 2022 10:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325406.547964; Tue, 10 May 2022 10:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNTQ-0006o6-Rc; Tue, 10 May 2022 10:52:12 +0000 Received: by outflank-mailman (input) for mailman id 325406; Tue, 10 May 2022 10:52:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNTP-0005rW-Te for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:52:11 +0000 Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d1f3320-d04f-11ec-a406-831a346695d4; Tue, 10 May 2022 12:52:10 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:60476) by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noNTI-000086-QN (Exim 4.95) (return-path ); Tue, 10 May 2022 11:52:04 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EFA221FA59; Tue, 10 May 2022 11:52:03 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d1f3320-d04f-11ec-a406-831a346695d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <2bf10a9c-f5bf-3d7f-95a8-2151440f5b06@srcf.net> Date: Tue, 10 May 2022 11:52:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 3/6] arm64/find_next_bit: Remove ext2_swab() Content-Language: en-GB To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <48bdc1be03a77bcc405e327b8022fcd937186e9e.1652170719.git.lin.liu@citrix.com> From: Andrew Cooper In-Reply-To: <48bdc1be03a77bcc405e327b8022fcd937186e9e.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 11:15, Lin Liu wrote: > ext2 has nothing to do with this logic. Clean up the code with > xen/byteswap.h which now has an unsigned long helper. > > No functional change. > > Signed-off-by: Lin Liu Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue May 10 10:58:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 10:58:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325415.547975 (Exim 4.92) (envelope-from ) id 1noNZ2-0007Yi-Jy; Tue, 10 May 2022 10:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325415.547975; Tue, 10 May 2022 10:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNZ2-0007Yb-Fi; Tue, 10 May 2022 10:58:00 +0000 Received: by outflank-mailman (input) for mailman id 325415; Tue, 10 May 2022 10:57:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNZ1-0007YV-FX for xen-devel@lists.xenproject.org; Tue, 10 May 2022 10:57:59 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c38c9a3-d050-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 12:57:57 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 06:57:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB4814.namprd03.prod.outlook.com (2603:10b6:208:ac::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Tue, 10 May 2022 10:57:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 10:57:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c38c9a3-d050-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652180277; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0YJCzUL+Kw8/iAMlgog79jPLeJCHYgxkGHBsb/FGtYs=; b=ge47EEoS3DxrEvADW5Ydj4a6F0eXWx9Pq5PPzGcJGALzpTIQdUoT4AB1 F7MZUOQBOVsIfnCYOQYGFvR8qHdW40LgKjzG/O0g74g1WMnFuvFUZEevm a7JmEoeBLhiRhRmRxDqV/yEqmrokibQ6GfxYAyrChQuEVARKYWy9HxveZ Q=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 70956713 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jEBF1azyUOrs/EnWenF6t+cixyrEfRIJ4+MujC+fZmUNrF6WrkUGy 2ZJXW6Ba/reYmemKohyYd6wpxsA65aHydMwSwo+rSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IDhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl5bWVVCsUOfzwyc84VjxHST55GbMW0eqSSZS/mZT7I0zuVVLJmq0rJmdpeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtacG+OTvY8wMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgK2wF9g3M/sLb5UD5yhV2zJHwHOCMRd6maoJWjmSyg WfvqjGR7hYycYb3JSC+2n6hg+7nnCXlWZkTHrm16v5rhlKIwmUZThYRUDOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYZUsBVGvc36ymMzLTV+AeTAmUYTj9HZ8civcVwTjsvv mJlhPvsDD1r9beTFnSU8+7MqSvoYHBFa2gfeSUDUA0JpcH5p50+hQ7OSdAlF7OpitryGnf7x DXiQDUCuoj/RPUjj82TlW0rSRr1znQVZmbZPjnqY18= IronPort-HdrOrdr: A9a23:ykcoZaEkvpco7fcypLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70956713" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3oynJkTBePB8R/vIma7LbpntyGRwHx7eGAzYh5MOKbqbzXDdyl5wBG4rtS41FeC/AjQ1TNydt/6CUQPws2V8BADgggnT2ZstKcbEMG6SfU1DTgcyb+AMxQJ5ib77VSrTHYy2NPe3XhsqV2JVFDl/YbVozOBUh1Jaj9sloAdH2Hza1gf46wsUWg2Glx0Hhj59yLMGucjEUwW3ImQ0RTo0utxtUQGbels43o+mGBH7vMadFFCGOES7+USb5djYn6gru3WtNlxjFsL3avrVbZkb87Mam/C5eoUlYdVbI0ttVwmKYCrZ2LpEl8NgsJ5AKXap2BNYAlWmTyXGZApl3P87Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/kWedNJU5vEz0bEvj9CLmWre4hLCaCi5+i1k0Q1Tow=; b=by+mD2peuMGgGsbDtlH0TdFsusGLvGen7gRFWMuwGKObzzCO4zMH0rVlzih37Hd5p5ZUCPebFsiithV7H/whWgHR6pFNHFihu9D68Z7Yz6BCPeV5BvOPAvYcGICObLlyBi9HuSXqNmN4SrBiACbsXERwybLSljTS+BzsemdgZwXZB3vXRmTrukIyxP3/hVL4LBW9xSRo90U5V/UMzhNNIg3gq9FHX8zeoGX8w+FpdrZ+CFjfNEic8ov1BYSK9uj0mqu+sbQmtqEHpW/8AGhuzrxTw+5MnbHRIeFqxkuD65oL38Uw0s961Dzjjlf4FHjlpTyAkPTTwd2YORECfN5KxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/kWedNJU5vEz0bEvj9CLmWre4hLCaCi5+i1k0Q1Tow=; b=kzBCNXIdhzqHqkwncdaRtpKEUrI5DPBtPQboMmsFqXxBFAR6e4JyHcBtfmOhXiIRSnryzcCN0snduxOn3Zu+Yg3EfRumG6mzo/SVTqeyILlBcnQv6j+7Kjs314DQrWWjqe1XV5/JS1kfSzekD3swteTG2Dhd8q9NzZWh+F5eMts= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 12:57:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Demi Marie Obenour Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53866a7f-61be-4137-3800-08da3273ee51 X-MS-TrafficTypeDiagnostic: MN2PR03MB4814:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLQwX2BC6UP9Ngcfp3w+NDyEd3rYaEBzSJm/Avt3Hc7CJC6UGeoMLWNgiESeu5htb8p3otxUOiM7YukMw1YreWZz7qIcD27Gglmmf6MGUdM8MaZueJ/w/rojFi9if9mwiugkMsKT7FkknEEUeehk/61NFZEWgszR50AROz8/iMS1SNhH9ThFlmar8jFnhI3oLgYKHXWfJPMQCa3CqEXuHeJ4kJtp0RJkjuBooc9CEueX049Lor5bcy8+q5dsR4W2z+KJZENlwrUMYouarfjnxuxC+0RlloyLgEfkymSgy6DjbmUf9uYqBpTCSgNDjQRSaI/nDwnCA551gIVf5ImCd7VARToiNEiPMWYek67g3/NFNx2Tu6A0q9DfKLYjY4RSozcZp9uYDQyt53nC/8U4UiANJR+F38cwHUb3TD8UlyR5VXLDlZhOynf17JhF+vg6b95C/zFmCTjcWI08z9im7l+1Y3AclzPLC5X7O3g+RxYGvoS6mmHAecLQoqQxdllgD5IbU3ZLG6eUsDP3pFxLW79Em5fVorVlMMtIGalpq6Yh+hMTHmcfje9w1Y0QoK6DsyJU91QB5wFazj9MdpSquWH0lnIo0JeeV906HzUjSkeBHGKV9yCg0h92ysZzIRxRipEUgLqXXU+6TRxnp2ErHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(26005)(6512007)(86362001)(186003)(5660300002)(9686003)(82960400001)(8936002)(2906002)(66946007)(4326008)(8676002)(66476007)(66556008)(83380400001)(38100700002)(6506007)(6486002)(6916009)(508600001)(54906003)(316002)(85182001)(33716001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkpEdGZ6VzR6ZU80YXhob2hoWXZsMzMzOGJJL1lYZXR2eEl6MVdmclFGcjQ5?= =?utf-8?B?MDdBMitTUEZFN3RSRUpXTGRKVEtFWGdweEFyZVUxYzVEdi8xVmduZEN6OVJr?= =?utf-8?B?THlqaHFBaHRVY253MFdZYytGaTBPTGJ0MzZTTUJXRkZ6aUF0NUxiVUhuajZx?= =?utf-8?B?Z3VLdGFzcUxaVVN1dHhXY2w5Z1pzN1loa0JGRHdTVGlDc2o5UXZrYmpNT1hE?= =?utf-8?B?WjZWN1Z4V3Vhd0d1SS9NcVZhdHNOVHVqUjVZUDZOUjdxWWNjeVRDSFkrRW1h?= =?utf-8?B?N1ZyT1hwTGs3VWxmY1ZZeWcwUW4rV3JVWHVaQU0vc09yMVM2OVJMS2k3TEpo?= =?utf-8?B?SktBa0o0RnJCem9WL1NmZ0ZENVNxOUg2MVNhQjBNUnZxVWRjTE52Z0hIRjFE?= =?utf-8?B?Qm9Zb1pWdVdMV2kwbkp4V29qOEdQaW9DRU4xSCs0VGVOWWNIZ214UnFZTzRn?= =?utf-8?B?N2RCY1lWWWkwZEFrMW4xS2drZWE5VlZKaXgrMytjZ1Q0c1hBaUZWZVBrWVBm?= =?utf-8?B?NTBOY0Vpd05zL3BrMzhxNjA4Z0VTeE12UXNOM1RFWUcya2dHaUlmakw1NHpS?= =?utf-8?B?azhDR3hCTnRDZUZlUjBZd2RhZmk5TGZzTEl5dFM5N0lQSEU4TUk3Z0c5Qy9h?= =?utf-8?B?Y2pObnpiMnZrYU5mR0tSeWNWR3dwd3NNZTBtUGUzMU91bHhLQTlpUEJqNFdN?= =?utf-8?B?TndlL1pCamdRY296SlZZZmpjdGh0cVk0dko1T3c5ckpnS2J5NTBheXlOU0Z3?= =?utf-8?B?OVplUDYwbVNOM05Scm1zbG5MSllxSk42QmlUUnQ4cUtBa0F0M0xHWEZ5MnBR?= =?utf-8?B?VDA3cGk1bkRpUnJNbmhXRXhlYXVHcWpHNHV6LzNmU0ZjQ1hpdEkvNjZnWVpP?= =?utf-8?B?TFp6ODUrVERBd1doa3VZZlNjc2Z5TUpXaW4zT1kvZHVSZndYa2N2TUVYak82?= =?utf-8?B?anpqNXlMTWljOWlDVkVMbzRqOU54V2NNUWoyMjZNemtHaWs3alRiSHdDVXEv?= =?utf-8?B?YjhBTUF6ZGNRZ25JMTg0dFRWcHdwdkQzZUlEK2UxZTJ4MW44RVpsWjRNOWgv?= =?utf-8?B?M0dCTGx0RDZYV1Z4UGtsWkRTeFZiQW5PVTdTalJFWGRDVDlkWkR0a3NMMktN?= =?utf-8?B?MGtoaVRoMWE0UHRjL1J0d1A2TzFGOVUwdzRnUG5BdzZYY3l3UzdZc3MxQlBK?= =?utf-8?B?U2IyUHJndzBBY1R2b3ZNd0oxdTBhaERmckpqOTdBVXozb2dVZlBwR0xsNU1S?= =?utf-8?B?SjQyVnJvbkdtVU9kK2c1MytMcWt4RGsvSXZJS0xNelBXRVR1MThkS0lTbktC?= =?utf-8?B?ZTRqNncxaG9EOEVaN0V4clRodkxMYmEvUTdrR0JMV1d0SUNjS3Z2aDRuNVVs?= =?utf-8?B?YTF2MHc3L0Rkek5IeXRoNVUzWXUwanRyUlRDMHRoUHNvWXJmM1NFYURyLzE1?= =?utf-8?B?ZEZFR25WaW9sTWEzc2dUMG4zVGxoUVZmVnBQYTk0MkpnTTU2S2M1UXRRUDJG?= =?utf-8?B?enNnRE92M0V4OWJWNHVVK3k5TXdXNHh0VU82blU2UHNHL0xubnVYNnJSdFRK?= =?utf-8?B?L1lCNkt1SzlMOExOR1JpWnlPNE9NamtDNlc1Z2NrK3BTKytSTXU0ek5BUDVW?= =?utf-8?B?dTlvbFh1N1Vpb0ZCV096NkFXbkYxOTUzWXZvN1RMNUJPVmU0N3Z0Z3ZvenEz?= =?utf-8?B?a2l3bEJWaElnaVk1YUxMUlhTQm1xVXlId3JMenZ1THhucXA5dWRBU1A2RVJu?= =?utf-8?B?U3lLbTluNno4Z1F6a1JGbUp4UkNYcXM5NVUrZWJ2M0FwUXowcEI5aGx4OHB4?= =?utf-8?B?Yms5amM2OUtIQ1FLcUtCYzJ4VzE1akdBWUcvWkx4cm9wa0NYVmRPNVZ3ODNQ?= =?utf-8?B?clRmZmpGd0ludnhiQkh3aG5YQ04wM2VYTExkRlJNWFlVT3YvL3lYUkJTalpS?= =?utf-8?B?V1RyUDg5R2VtNWNscSswLysvdUNDVWhOVk5UZUhNZnNoa0p1blFDVzRjWGRP?= =?utf-8?B?YlIvS09Wb216V1RmTnV5QlFidHpBeW5OSW9SOWVsMkNyQ1ZMYWV0Q1ZVMUZx?= =?utf-8?B?UTM4ck1oMjRtU2E4elBHR01FZytSbTVrTmQvdWR6QlF2dTk4VTVpSysrUTJ3?= =?utf-8?B?ekRaRTljaW1MT3R4S3VsaThwREdmK2VrQjIzaTg2cERWbndsWnlvZzNoTVlK?= =?utf-8?B?a204VWVHWm9Eb25raVQvVDdrcEF5NURzMG90dFdBZUhoZGQxZFRFZUdyZVFO?= =?utf-8?B?SjF4R3pzK0F4T0YvQmlPUmhzdEFnVVdxS0Z0eStlN1F4ZUdLZG9YUmJ1WmxV?= =?utf-8?B?c3VmTkFIVEFxTzREQSthU2J2MTZ2eEZQYmNWWXVvalgwQVdrcmt6emxLVm1Q?= =?utf-8?Q?pdMzxaXWBv81YvVc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53866a7f-61be-4137-3800-08da3273ee51 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 10:57:52.8992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U1LoHcCc+/PRHgIf9O6lWUj9RSN05NPI7n0tOlK6D7ZiCQzbHT2yjhHJUyv2+xtAgR1QPlE5w0CWa7uMXAv54A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4814 On Thu, May 05, 2022 at 08:30:17PM -0400, Demi Marie Obenour wrote: > Proposal: Check disk sequence numbers in blkback > ================================================ > > Currently, adding block devices to a domain is racy. libxl writes the > major and minor number of the device to XenStore, but it does not keep > the block device open until blkback has opened it. This creates a race > condition, as it is possible for the device to be destroyed and another > device allocated with the same major and minor numbers. Loop devices > are the most obvious example, since /dev/loop0 can be reused again and > again, but the same problem can also happen with device-mapper devices. > If the major and minor numbers are reused before blkback has attached to > the device, blkback will pass the wrong device to the domain, with > obvious security consequences. > > Other programs on Linux have the same problem, and a solution was > committed upstream in the form of disk sequence numbers. A disk > sequence number, or diskseq, is a 64-bit unsigned monotonically > increasing counter. The combination of a major and minor number and a > disk sequence number uniquely identifies a block device for the entire > uptime of the system. Seems fine to me, this is just an extra check to make sure the block device opened by blkback is the one that user space intended. I would see diskseq as a kind of checksum. > I propose that blkback check for an unsigned 64-bit hexadecimal XenStore > entry named “diskseq”. If the entry exists, blkback checks that the > number stored there matches the disk sequence number of the device. If > it does not exist, the check is skipped. If reading the entry fails for > any other reason, the entry is malformed, or if the sequence number is > wrong, blkback refuses to export the device. > > The toolstack changes are more involved for two reasons: > > 1. To ensure that loop devices are not leaked if the toolstack crashes, > they must be created with the delete-on-close flag set. This > requires that the toolstack hold the device open until blkback has > acquired a handle to it. Does this work with loop devices? I would expect that you need to issue a losetup call to detach the device. Even more, the loop device is created by the block script, but there's also a window between the block script execution and the toolstack knowing about the device, which could also allow for a leak? > > 2. For block devices that are opened by path, the toolstack needs to > ensure that the device it has opened is actually the device it > intended to open. This requires device-specific verification of the > open file descriptor. This is not needed for regular files, as the > LOOP_CONFIGURE ioctl is called on an existing loop device and sets > its backing file. > > The first is fairly easy in C. It can be accomplished by means of a > XenStore watch on the “status” entry. Once that watch fires, blkback > has opened the device, so the toolstack can safely close its file > descriptor. Does the toolstack really need to close the device? What harm does it do to keep the handle open until the domain is destroyed? What about disk hotplug? Which entity will keep the device opened in that case? Is xl block-attach going to block until the device switches to the connected state? > The second is significantly more difficult. It requires the block > script to be aware of at least device-mapper devices and LVM2 logical > volumes. The general technique is common to all block devices: obtain > the sequence number (via the BLKGETDISKSEQ() ioctl) and its major and > minor numbers (via fstat()). Then open /sys/dev/block/MAJOR:MINOR to > get a directory file descriptor, and use openat(2) and read(2) to get > various sysfs attributes. Finally, read the diskseq sysfs attribute and > check that it matches the sequence number from BLKGETDISKSEQ(). > Alternatively, one can use device-specific methods, such as > device-mapper ioctls. > > Device-mapper devices can be detected via the ‘dm/name’ sysfs attribute, > which must match the name under ‘/dev/mapper/’. If the name is of the > form ‘/dev/X/Y’, and the ‘dm/uuid’ attribute starts with the literal > string “LVM-”, then the expected ‘dm/name’ attribute should be found by > doubling all ‘-’ characters in X and Y, and then joining X and Y with > another ‘-’. This accounts for LVM2 logical volumes. Alternatively, > one can use device-mapper ioctls to both check if a device is a > device-mapper device, and to obtain its name and UUID. I plan on going > with the latter route. Likely a stupid remark, but needs obviously needs to be kept to Linux only. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 11:05:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:05:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325428.547986 (Exim 4.92) (envelope-from ) id 1noNgJ-0000oL-Df; Tue, 10 May 2022 11:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325428.547986; Tue, 10 May 2022 11:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgJ-0000oE-8G; Tue, 10 May 2022 11:05:31 +0000 Received: by outflank-mailman (input) for mailman id 325428; Tue, 10 May 2022 11:05:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgH-0000o4-E7; Tue, 10 May 2022 11:05:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgH-0003nH-Ba; Tue, 10 May 2022 11:05:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgG-0001z3-UP; Tue, 10 May 2022 11:05:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noNgG-0007De-Tz; Tue, 10 May 2022 11:05:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=V2py+hPXrOsPl0ODSK63fETebxoawOqbsgbUHlbOXac=; b=dxUP72hrPyLitpNS72x9nLQti4 d9wwuvuXH181eXznYbYw6C4EjWNNvlu7G9DMS7bdYo/sTntnNaa5+l+lDDxe/32Np994ww6c0ZiNp 4inDbgNKAaU/KkyLxZuHLnT3jS8s3HzZmQ+ln/rv3Gi3N4nshAC4tmDMKTxUd2nUcvY4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170295: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 11:05:28 +0000 flight 170295 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170295/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 911 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 11:05:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325431.547997 (Exim 4.92) (envelope-from ) id 1noNgT-00018j-Pw; Tue, 10 May 2022 11:05:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325431.547997; Tue, 10 May 2022 11:05:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgT-00018c-MY; Tue, 10 May 2022 11:05:41 +0000 Received: by outflank-mailman (input) for mailman id 325431; Tue, 10 May 2022 11:05:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgR-00017S-PK for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:05:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNgR-0003nZ-Gg; Tue, 10 May 2022 11:05:39 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noNgR-0003hC-Ae; Tue, 10 May 2022 11:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4B6gPS4hNc09H9nn1sd2lEFZrF5+tOw6YuXJeEJ3JWQ=; b=mzfnRrXomKs2AAJSYV/DD/yqL2 +nuwMWZWcg2qYfvcWiPEC6qZpxsbFqGRRLXf4wHBC4+MHsCTJldNMAvh212XY2Eot+nbwyX4c5J7m ZliV93kfm4AuSQTp8qXOF2U8rMvJ7DeHnVOaPNCpOwABhFRKIejQ5MEyv54NfH7p/ZEw=; Message-ID: <616d2587-610d-9222-26df-739d185e0341@xen.org> Date: Tue, 10 May 2022 12:05:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 3/6] arm64/find_next_bit: Remove ext2_swab() To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <48bdc1be03a77bcc405e327b8022fcd937186e9e.1652170719.git.lin.liu@citrix.com> From: Julien Grall In-Reply-To: <48bdc1be03a77bcc405e327b8022fcd937186e9e.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/05/2022 11:15, Lin Liu wrote: > ext2 has nothing to do with this logic. This code was a verbatim copy from Linux. Looking at the history, I am not sure there was even a connection with the ext2 filesystem (I guess this is what you mean?). So I would drop this and simply say that we could use the new helpers. > Clean up the code with > xen/byteswap.h which now has an unsigned long helper. > > No functional change. > > Signed-off-by: Lin Liu Other that what I wrote above: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:09:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:09:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325443.548008 (Exim 4.92) (envelope-from ) id 1noNju-000261-Bt; Tue, 10 May 2022 11:09:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325443.548008; Tue, 10 May 2022 11:09:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNju-00025u-9D; Tue, 10 May 2022 11:09:14 +0000 Received: by outflank-mailman (input) for mailman id 325443; Tue, 10 May 2022 11:09:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNjt-00025o-47 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:09:13 +0000 Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e6be9af-d051-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:09:12 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:60480) by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noNjn-000BAz-Q7 (Exim 4.95) (return-path ); Tue, 10 May 2022 12:09:07 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id DBD321FBB6; Tue, 10 May 2022 12:09:06 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e6be9af-d051-11ec-8fc4-03012f2f19d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <00d82608-9430-6b20-26b5-207c62358179@srcf.net> Date: Tue, 10 May 2022 12:09:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-GB To: Julien Grall , Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> From: Andrew Cooper Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap In-Reply-To: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/05/2022 11:51, Julien Grall wrote: > On 10/05/2022 11:15, Lin Liu wrote: >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index 4aae281e89..70d3be3be6 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct >> dt_device_node *np, >>       if ( !val || len < sizeof(*out_value) ) >>           return 0; >>   -    *out_value = be32_to_cpup(val); >> +    *out_value = be32_to_cpu(*val); > > This code has been taken from Linux and I would rather prefer to keep > the *cpup* helpers to avoid any changes when backporting. I specifically requested that this be de-obfuscated.  Hiding indirection is a fantastic way to introduce bugs, and we've had XSAs in the past because of it (admittedly in libxl, but still...). This file is already Xen style, not Linux, so won't be taking backports directly, and the resulting compiler diagnostic will make it obvious what is going on. be32_to_cpu(*val) works fine on older versions of Xen too. In this case, the cost of changing is well worth the improvements and simplifications gained.  See the 0/6 diffstat and see that the compiler can make better optimisations when it can see the builtin. > >> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h >> index 0a2b16d05d..16b2e6f5f0 100644 >> --- a/xen/include/xen/unaligned.h >> +++ b/xen/include/xen/unaligned.h >> @@ -20,62 +20,62 @@ >>     static inline uint16_t get_unaligned_be16(const void *p) >>   { >> -    return be16_to_cpup(p); >> +    return be16_to_cpu(*(const uint16_t *)p) > > I haven't checked the existing implementation of be16_to_cpup(). It's a plain dereference, just like this.  AFAICT, it wasn't unaligned safe before, either. It should be reasonably easy to fix in a followup patch.  Just memcpy() to/from the void pointer to a stack variable of the appropriate type. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 10 11:10:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:10:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325450.548019 (Exim 4.92) (envelope-from ) id 1noNkd-0002df-MX; Tue, 10 May 2022 11:09:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325450.548019; Tue, 10 May 2022 11:09:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNkd-0002dY-IT; Tue, 10 May 2022 11:09:59 +0000 Received: by outflank-mailman (input) for mailman id 325450; Tue, 10 May 2022 11:09:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNkc-00025o-K1 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:09:58 +0000 Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba440ca2-d051-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:09:58 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44498) by ppsw-30.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noNkR-000XGY-cl (Exim 4.95) (return-path ); Tue, 10 May 2022 12:09:47 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id B53D21FBB6; Tue, 10 May 2022 12:09:46 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba440ca2-d051-11ec-8fc4-03012f2f19d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <474f4ad4-e1ee-0ca9-5ba5-2ee39d651286@srcf.net> Date: Tue, 10 May 2022 12:09:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 5/6] byteorder: Remove byteorder Content-Language: en-GB To: Lin Liu , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <97e346648d356f621170bcb89fd7d86c120aca70.1652170719.git.lin.liu@citrix.com> From: Andrew Cooper In-Reply-To: <97e346648d356f621170bcb89fd7d86c120aca70.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 11:15, Lin Liu wrote: > include/xen/byteswap.h has simplify the interface, just clean > the old interface > > No functional change > > Signed-off-by: Lin Liu > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Julien Grall > Cc: Stefano Stabellini > Cc: Wei Liu > --- > xen/include/xen/byteorder/big_endian.h | 102 ------------ > xen/include/xen/byteorder/generic.h | 68 -------- > xen/include/xen/byteorder/little_endian.h | 102 ------------ > xen/include/xen/byteorder/swab.h | 183 ---------------------- > 4 files changed, 455 deletions(-) Reviewed-by: Andrew Cooper Good riddance. From xen-devel-bounces@lists.xenproject.org Tue May 10 11:10:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325456.548030 (Exim 4.92) (envelope-from ) id 1noNkp-0003jA-Uh; Tue, 10 May 2022 11:10:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325456.548030; Tue, 10 May 2022 11:10:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNkp-0003j3-RJ; Tue, 10 May 2022 11:10:11 +0000 Received: by outflank-mailman (input) for mailman id 325456; Tue, 10 May 2022 11:10:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNko-0003iZ-P7 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:10:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNko-0003rC-8M; Tue, 10 May 2022 11:10:10 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noNko-0004Ly-2Q; Tue, 10 May 2022 11:10:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9Y5Dc8DTxN41reqtY0sDfzdciWQDrbpS3yCS4DjJcjI=; b=pQ4bDq3vJ+uC1NIyTsNtQXckyU 5i93EhUpMXM94r1L0KgbysIqw8gKeNIOaLuUripbdQUyhplt6r6YZ48y41/oiCzSoGrM3Cbcl4d82 cxu9R/PvqDDpkPJm3Dz2Q+EZfWdHIooCm+OySygtR5VqKc9HMSGClgJkLsjpANVXUtNM=; Message-ID: <11269227-ba07-b2b1-c2ef-ea6309980f67@xen.org> Date: Tue, 10 May 2022 12:10:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/6] xen: implement byteswap To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> From: Julien Grall In-Reply-To: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 10/05/2022 11:15, Lin Liu wrote: > swab() is massively over complicated and can be simplified by builtins. NIT: "by builtins" -> "by re-implementing using compiler builtins". > The compilers provide builtin function to swap bytes. > * gcc: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html > * clang: https://clang.llvm.org/docs/LanguageExtensions.html > This patch simplify swab() with builtins and fallback for old compilers. > > Signed-off-by: Lin Liu > --- > Cc: Stefano Stabellini > Cc: Julien Grall > Cc: Bertrand Marquis > Cc: Volodymyr Babchuk > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Wei Liu > Cc: "Roger Pau Monné" > Changes in v3: > - Check __has_builtin instead of GNUC version > > Changes in v2: > - Add fallback for compilers without __builtin_bswap > - Implement with plain C instead of macros > --- > xen/arch/arm/include/asm/byteorder.h | 14 ++----- > xen/arch/x86/include/asm/byteorder.h | 34 ++--------------- > xen/include/xen/byteorder.h | 56 ++++++++++++++++++++++++++++ > xen/include/xen/byteswap.h | 44 ++++++++++++++++++++++ > xen/include/xen/compiler.h | 12 ++++++ > 5 files changed, 120 insertions(+), 40 deletions(-) > create mode 100644 xen/include/xen/byteorder.h > create mode 100644 xen/include/xen/byteswap.h > > diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h > index 9c712c4788..622eeaba07 100644 > --- a/xen/arch/arm/include/asm/byteorder.h > +++ b/xen/arch/arm/include/asm/byteorder.h > @@ -1,16 +1,10 @@ > #ifndef __ASM_ARM_BYTEORDER_H__ > #define __ASM_ARM_BYTEORDER_H__ > > -#define __BYTEORDER_HAS_U64__ > +#ifndef __BYTE_ORDER__ > + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ > +#endif > > -#include > +#include > > #endif /* __ASM_ARM_BYTEORDER_H__ */ > -/* > - * Local variables: > - * mode: C > - * c-file-style: "BSD" > - * c-basic-offset: 4 > - * indent-tabs-mode: nil > - * End: > - */ This change looks unrelated to this patch. Can you explain it? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:11:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:11:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325461.548040 (Exim 4.92) (envelope-from ) id 1noNm7-0004YI-9X; Tue, 10 May 2022 11:11:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325461.548040; Tue, 10 May 2022 11:11:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNm7-0004YB-6u; Tue, 10 May 2022 11:11:31 +0000 Received: by outflank-mailman (input) for mailman id 325461; Tue, 10 May 2022 11:11:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNm5-0004Xx-Ay; Tue, 10 May 2022 11:11:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNm5-0003uv-73; Tue, 10 May 2022 11:11:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNm4-0002E1-KN; Tue, 10 May 2022 11:11:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noNm4-0000G1-Ju; Tue, 10 May 2022 11:11:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wz7LO8ftnILY4gsbSA14haWHaHxl0xeCL+aAoC/0CBU=; b=TVNTJW5blxZjnh82SginjKuN3z z7GeLCOU1MU2K7B486fT+Ed82r96mfYFEbSVNWWkZgkSUwRfG6NkUXuCTWlJZqzYM9PIWBCTKaNHp y6rejmKiRm/WOVveAazRA7ai81za03d5zVVmKCeRhabHpM1dd6/daXWgsaZa6zlzabxE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170287: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=8cb37bac33c39c9632f91d13734f0d7a6918f313 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 10 May 2022 11:11:28 +0000 flight 170287 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170287/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 8cb37bac33c39c9632f91d13734f0d7a6918f313 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 669 days Failing since 151818 2020-07-11 04:18:52 Z 668 days 650 attempts Testing same since 170287 2022-05-10 04:22:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106898 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 11:17:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325478.548052 (Exim 4.92) (envelope-from ) id 1noNrU-0005X2-6W; Tue, 10 May 2022 11:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325478.548052; Tue, 10 May 2022 11:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNrU-0005Wv-1f; Tue, 10 May 2022 11:17:04 +0000 Received: by outflank-mailman (input) for mailman id 325478; Tue, 10 May 2022 11:17:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNrT-0005Wp-El for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:17:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNrS-00041F-In; Tue, 10 May 2022 11:17:02 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noNrS-0004l7-CR; Tue, 10 May 2022 11:17:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mCxbbTQPQMhPyZIq4yEaMnbmrYRTVPLZu4+MspCr/eg=; b=xyJ71VTD0oVU/XVRZftsUoj1nZ buOGgSh3OWLek5qL0C1YxnIyWlRJBV8zMUpCiOxz41MYcPQ2/yl2+fy08cHwKHlK83ocmQPskj5FR 89KUzYgl96mVHwqZzf5pVmuADqGaLJQLKBzD9I8numn/hbm/oEw8szVDCWA7sHNe1iYQ=; Message-ID: <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> Date: Tue, 10 May 2022 12:17:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Andrew Cooper , Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> From: Julien Grall In-Reply-To: <00d82608-9430-6b20-26b5-207c62358179@srcf.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 10/05/2022 12:09, Andrew Cooper wrote: > On 10/05/2022 11:51, Julien Grall wrote: >> On 10/05/2022 11:15, Lin Liu wrote: >>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>> index 4aae281e89..70d3be3be6 100644 >>> --- a/xen/common/device_tree.c >>> +++ b/xen/common/device_tree.c >>> @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct >>> dt_device_node *np, >>>       if ( !val || len < sizeof(*out_value) ) >>>           return 0; >>>   -    *out_value = be32_to_cpup(val); >>> +    *out_value = be32_to_cpu(*val); >> >> This code has been taken from Linux and I would rather prefer to keep >> the *cpup* helpers to avoid any changes when backporting. > > I specifically requested that this be de-obfuscated.  Hiding indirection > is a fantastic way to introduce bugs, and we've had XSAs in the past > because of it (admittedly in libxl, but still...). Care providing a link to those XSAs? But I don't really see what's the problem here, this is no better no worth than passing pointer to other functions... > > This file is already Xen style, not Linux, so won't be taking backports > directly, and the resulting compiler diagnostic will make it obvious > what is going on. be32_to_cpu(*val) works fine on older versions of Xen too. > > In this case, the cost of changing is well worth the improvements and > simplifications gained.  See the 0/6 diffstat and see that the compiler > can make better optimisations when it can see the builtin. I take your point... However, the commit message provides virtually zero justification into why we should switch to be32_to_cpup(). So to me, the changes so far looks unwanted. > >> >>> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h >>> index 0a2b16d05d..16b2e6f5f0 100644 >>> --- a/xen/include/xen/unaligned.h >>> +++ b/xen/include/xen/unaligned.h >>> @@ -20,62 +20,62 @@ >>>     static inline uint16_t get_unaligned_be16(const void *p) >>>   { >>> -    return be16_to_cpup(p); >>> +    return be16_to_cpu(*(const uint16_t *)p) >> >> I haven't checked the existing implementation of be16_to_cpup(). > > It's a plain dereference, just like this.  AFAICT, it wasn't unaligned > safe before, either. Well, technically an architecture could provide an override for the copy. I agree that arm32 is already bogus but... > > It should be reasonably easy to fix in a followup patch.  Just memcpy() > to/from the void pointer to a stack variable of the appropriate type. ... I disagree that it should be fixed in a follow-up patch. It should be fixed now as this is where the badness is spread to any architecture. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:18:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325484.548063 (Exim 4.92) (envelope-from ) id 1noNt3-00067V-Hf; Tue, 10 May 2022 11:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325484.548063; Tue, 10 May 2022 11:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNt3-00067O-Eo; Tue, 10 May 2022 11:18:41 +0000 Received: by outflank-mailman (input) for mailman id 325484; Tue, 10 May 2022 11:18:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noNt2-00067I-I7 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:18:40 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea8de687-d052-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:18:38 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 07:18:26 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB4287.namprd03.prod.outlook.com (2603:10b6:805:bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 11:18:21 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 11:18:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea8de687-d052-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652181518; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HyIgtJGvVS55IG8M/JKzgwUvD7lI6WTq7uyYO0vAdh0=; b=XADpH5786FC/iVObr5XmbFORAN+AwskrNZ0J0YhrQdoAcUhszaYvkCWo ACgDnv6X54zStxBhUypDmvAjUAsqg8U5jY9WpTBuWtfBanccqvHh082Ej jQ8B7pbV2lJ7dn83JwiB2Gi9H4CaFT9xhZlS5YR2XfAVpvJOapGI9fTYn o=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 70958111 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JbF6u6N6NUNRKLnvrR3clsFynXyQoLVcMsEvi/4bfWQNrUoj1D0Fx msZCzqDOvnYamTwf90ia9m19EkC78Tdzd9qGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Yw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8 P5VhZv3aAYSIJLru786WhgbL3FkIvgTkFPHCSDXXc276WTjKiGp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7ENaaHPmiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33iiiI2QB8Tp5o4IawzLj3TVg34T9LeL4UPKLHtcEkUGx8 zeuE2PRR0ty2Mak4TGC9m6rgKnVkC73VZg6G7ix9/osi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdx+3unmfpTYHRsFdVeY97WmwJrH85g+YAi0IS2BHYdl/7ssuH2V1i hmOgs/jAiFpvPuNU3WB+7yIrDS0fy8IMWsFYixCRgwAizX+nLwOYtv0Zo4LOMaIYhfdR1kcH xjiQPACuogu IronPort-HdrOrdr: A9a23:ol86RaE6jWB1gmCnpLqFdJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tOKL Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfgWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdrjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkloJk29Tpb+CUlpAZ/yHsMceg62w 36CNUYqFhvdL5jUUsvPpZ3fSOIYla9MS7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA == X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70958111" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mRnZRAh8iQ2PYwO4yoekytOHiFZzpNYd/u9IeFsvxQvlGczvaCDlx54/CnLAdtfCvHy/c6Q88vRjJ+v2gN1BXDHbqYwAQN27TPUve84PbGnDOJJDxxtoMCyP9Zfl5km9PVcGf8Bx5gEDWpD8wMjXLM5I3i/A0YGMlXaVRQlNTND2O6L3SkZ2rrvoPGTt/l8c3cDgFV0T14h4Xj4Ach2e0T+i46JL+On3+F8bxqZzO/X/fzN6KLhLutGvM5afBKVHE4VYHVfBW3H+PsSY7Qhxk6yyTaHoZ210O1d6nox2KEFD8wixu+1BIUIcnbAbDoed1aF703Ol20kl27yaOzeCcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cmeste97dBajqSDs43BpoyLnifzvAhV7iQP9o2WvMps=; b=KBdp8/0ZKgbiryxICHNCWlT5DSH3QcZOlaQdFlDEQbr2t9KX54Q1HxVtkh0LPQ7jTh+NgQPD/cKkhaPb/hwgNhWsOII2vKqlvWCUATxZXeYSSOIZ5+ng8bIDG4mjXNveCjnDLZuqm6PrOkul1f7O4+f7CMIVdzLIKIKgZxIxtg3Ou0Km1IKwajhfZQ7hDfL0a9gvW3yKmf4ZMz2sGuuwwPSO1EliR5Ce6Tkop2Rw2RDt9boagyiLrtPoVvv1PWERM2DdSpJrj9xODqF4Q/QQiwxidOl6dMYxcxzM42OeNLiypgYC+AGT3F4ChlcpV2fCnB1SboDwu1iYwRqm7Hx6gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cmeste97dBajqSDs43BpoyLnifzvAhV7iQP9o2WvMps=; b=be/5Yz9tnBo9tlSgp+sc4plZdnS6FzEHDj9X405CCC3hplnLhYWaNlhK5s7Y2Z19M15g9LbZP0XV1KqF+yADGCn2Lm6YOQJZ20rnbbS2lToYzeYRdbyh7jvvaS21tDyCSAxy9jzI8dxpPj/TL3DnLo0fk3pLek7cTyuFK8W4R58= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 13:18:16 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Colton Reeder Cc: xen-devel@lists.xenproject.org, Juergen Gross , Anthony PERARD Subject: Re: OPNSense running in domU has no network connectivity on 5.15.29+ Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LNXP265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cac7ded-be9e-4fea-e3db-08da3276ca46 X-MS-TrafficTypeDiagnostic: SN6PR03MB4287:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TI4PCRGrctwUf9qTh2GNYb+dNZ6sVOlhvgzJ01tZxlIjaQkpu1TMupZDhncjm51Xr1MTD3AhFnfS9h/tlgsvNxx5409d9OCmgYceZv1Y94uj31GyTPKN3QpJmQlgWTOs827Aw6d2fiI7u+CwitKnedGlIsxM91/Z0nfo2Rd/JYSXE1XccGKB7mJR+lG69owJShMGtePwQghWcGKRfVG1VVx5riszEOwzv6Wy7bwLkCAUz8Vl3BYBL4dG/wMMC8xiHgJBot5RP1Yhksizd4PCGbSO+7CERUFJfyYx8KEIMJ/i/aDXWVKKHVGA2ijwMEZ5c4lYi6lUHiZ5F9cDoYEXYqClst6Ib6seYnau39wGTfqbXz9MHFUT/SK/4zNz0PswrrthDB/XmSGZTSPEVYXaWdfIwi8BAwpwSt3BugNQOStmtWPSEZBwNlV1Nap3GA7yMYAvMAS/OLrzOAbCTnITSlifTHXCmBUuROGtsKbPcg1HlXS2OQxn27LcsV6MmTk6sr0iarmfKXclqu2f0NnsU/QzUd44yr/cBZMhlo/yMr2WO3zRQNb/hWZPYphR1GNq+8RTPcouxOpQlSOD7EzpaZWZ9A0YmpGDwnYdW1zrS6xDcVmXsOZhtsFyAtIXaq+C0AJLJnSHi6GQ/ePYFeiPRiPqJWx4ZGJYNLocE156b04KA/4BvjCssN1+L7ryQl7o9FueNA12oWEtHo9LdBWqf2hASqQgXmv8TPcVMYzF40wV9Lii6KuCo6KckSCL/SsnM0Und5qakPRkzfi6QliM9BuOWnDcTqWrg6OGQvzhafWH9aGo4XpFrgl6d+3xsQUC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(508600001)(38100700002)(6486002)(107886003)(966005)(8936002)(6916009)(66574015)(83380400001)(85182001)(54906003)(316002)(82960400001)(186003)(8676002)(33716001)(9686003)(6666004)(6506007)(4326008)(6512007)(2906002)(26005)(66556008)(66476007)(66946007)(5660300002)(86362001)(10126625002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE03WTdZZm1wbTRFcVh5RkdHa2R5VFhyeE9VNjVGY1NWS1RFOXp1YXV5UE5x?= =?utf-8?B?ZzlUeU16WFdVUm4vNnVISFNubGgwTVZUSTllaFd6RmNheXJVZmh1QTFJblh5?= =?utf-8?B?OG1EVlVVQjJXZHZtU3hXN1NwcG42dW5idWJ2Mm1abTFhdFJvb05ibCtFaHV1?= =?utf-8?B?L2dWUDE0cVRzSEtKU29hQlBrSEV6VGduN3NXb01sK0FHWkJDUXh1dUs2MVVO?= =?utf-8?B?RE1FR2t5SG1mWmM0MWE3bU01WEVWQ2pxVVV0RkhyL2xuakxDd0N0U3JmVXZh?= =?utf-8?B?bmlPWkVQNmxqUEdtcTh1R2E1SEUwYVdzL3VwQ3hDSTNXQUduWnJReHozUVRu?= =?utf-8?B?WEd0UGkrTk9oQStETW5RazQxZ3k4YmlZZFNSR3dOQzZwOWFzVlZXYTZiUGdx?= =?utf-8?B?SThQZVJCeFdhR2VNc0I5WkV3bnNURVFPa0M2aWZUUE50cEpkV1ZzUks4RlE1?= =?utf-8?B?a1g1ck9JWlZhMlhXTUFsYW5abHFrbC9BY0c2SktWYnRZVmhNcmhXZW84LzNs?= =?utf-8?B?TFNSU2lnT1dkUHBwdnB6L2tDaUVBWDBVMlhvazcwVkRNeXVNWWZnMldYcXJl?= =?utf-8?B?Um5QUE43T1ZCVHZKaGhweFRxREt6MmRRQXZLWHo2bnVaMk5TZGZrV1h1bGZM?= =?utf-8?B?K0NHY1BYaU1nbU1IeFJML2V2VjRmd201R1Yrc004V1EwWEQ0V21HMXMrMjZI?= =?utf-8?B?a2VPVGVQL0RoOEMwRGJzaUV5WXYvZWFZZEJnYVVSeERnSXU4LzhDWUtYUmsv?= =?utf-8?B?YXlMTkF3YXFkVExjeENTTVZmNitkVmIyOU92b3NWL0hkMEhyajFTQ28wQ1B1?= =?utf-8?B?MzYyZzlOMG5OMEZYbm1yN3d4aEJXVTVOZjJ5R1RVNDY0VmRVUTlxaGJmVUJU?= =?utf-8?B?ZWJmWE14Uk5TUnBoK0F5YUhzc0tNN1luOXgrQzV1VVhub2lhNGhTWENLL2Vm?= =?utf-8?B?SFhRa0pHdVE0MzAza3RiWS8xYnZGVG0wcEZRSk8vbWQrclJjWTBKYjd1NHpH?= =?utf-8?B?bmdXamIwVGxXUkRRMlZiTXkzT05pTmtud2kwM2t5RnljV3ZVN2xpWHljUzY4?= =?utf-8?B?dldEU05ISGdNY2ttd2tXWHlwZGJZU0VSazZ4M3Bud1hldTFjVDdLSEdTVE9H?= =?utf-8?B?dmFTZ1lLWVl1MEVrZVJITFRVZnFlcG5kckFuZDVTTHplR1hDTjVidFUrVW9a?= =?utf-8?B?MWh1TzFKc2s5RWxSNkc5M2JydE84OXVKMTZCdDEyZlB6ZktvYUFvTmhpU0dX?= =?utf-8?B?eDJXUkdWOHRldGJta1FNdTlwKzVMd0Z0ZiszM0owZzRvSU9CWXpoL3pVbk1V?= =?utf-8?B?a1BNQVFYMEVvKzF2M1pGeVY5SUhTQ1pqbU83NmxrYjJxdHJENVhlUVZvaFdn?= =?utf-8?B?ZyswakE5VDlwcjBtdHZyZFhMWDBCbnhCTGlqVVdlMGhaZjJwNGN4TG1nVmFm?= =?utf-8?B?Uzh2TlV6Y3hwZmZ2N3NNSU5McVg4ZGgvOUJqU2JraTllNUl4bkIvYWRQNnpX?= =?utf-8?B?MDFTVFRHajFxWm14QlB2NGloV3QzN2YrZXl5RnpPdVV0Ni9xQ0xGbUdqVktq?= =?utf-8?B?anRBVGhvUTlMZk5CSzZpK0ZSQ29VK3RvNXNLMmE0Z0RjZkVvVFFZa0ZWM2s2?= =?utf-8?B?cU1MM3d3V21pakpHU1o5bTl6bmU5OElKQnh6T0VHUm5WcldyWjg1d3Vvdjl4?= =?utf-8?B?TDBSU0lxQnFRYVZoSzY3WU9KNFF2cnJDV2x1WlZjaG5UVjNxTmx1Q2hDaEdP?= =?utf-8?B?VVo1Vyt0Rk9MVEI4UkZzNVY4R2pOUjY1bmlmaHlwSFpGd2g0QXc5WHNwMXkz?= =?utf-8?B?Wm9XbGN6OWpJV3p4Q3dvbGdIRUJOUjM1TWtLSTh2RURJSUV6L0h5NmcwRjJO?= =?utf-8?B?WUNrWE55NC85b3pDUURFSmVEM0U3azlzS0JnWmxHRy9ZRkFOZVZnUzVZM1VV?= =?utf-8?B?SVVqZDB0NXRubnROQ2h4MHNqT1E5dG1kYVV1SXNuZ3Q0YnN5b3BuVFBFeFZs?= =?utf-8?B?V0hLSDBOakF3akw1ckhrL0N2YUlNNTNxWnp5ZzNMZWtqOUZoOUdES2k5bWpr?= =?utf-8?B?WWxWd0M1YjF3aUhqY0VzSUpLdVRCZnYxWThUYUplb1V4RDJkbFp3K2Q2ZWdX?= =?utf-8?B?b2JrWUZXREJpdk0xR29leGxXb0dCZWJGK1RmeFJORW1YWWZSYVNrMjhQcCtp?= =?utf-8?B?VURpQUdVUk5BQ2FGT1JwRDBhRytWakRXYlZPN2VVT1VCWmkvUTJwTHdXb2lT?= =?utf-8?B?N0xHaXdhY2ZLc3prSU1DKzZvb3FPcmIweGJiTVJLc0RYekQ5WWFXVzhrSitt?= =?utf-8?B?ZENaSW1KdWFjV1p2SERkVytYYTJGWDhPRW51REVWNXJUN1M1S2lNVzFvMity?= =?utf-8?Q?xYIuzKCn6DOozFS0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cac7ded-be9e-4fea-e3db-08da3276ca46 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 11:18:20.9550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u1LDQvEpA4NBEuEdFrg9YN9/qVVtREJnDHi849dfovj9odZEWX4oM7fEkZKcsdJjiUUG68WspSbqk7fO5X+Nww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4287 On Tue, May 03, 2022 at 12:36:43PM -0700, Colton Reeder wrote: > Hello, > > I am running the FreeBSD-based router OS OPNSense in a domU. I > recently upgraded my dom0 kernel from 5.15.26 to 5.15.32 and with the > new kernel, OPNSense had no connectivity. I downloaded from kernel.org > 5.15.26-32, built and installed each version and booted them > consecutively until I found the version that no longer worked. It > turned out to be 5.15.29. > > I looked through the change log of 5.15.29 and found two commits for xen-netback > > commit 2708ceb4e5cc84ef179bad25a2d7890573ef78be commit > fe39ab30dcc204e321c2670cc1cf55904af35d01 > > I reverted these changes (a revert of a revert, yes) in 5.15.32, > built and installed. Now the network works. Now I dont know enough to > know thats for sure the right fix. Could you try if reverting only one of those fixes your issue? > Maybe I have a config issue, I dont > know, but reverting that change fixes the problem. What should I do? > I was asked to provide xenstore -ls https://pastebin.com/hHPWgrEy It's better to post the output of `xenstore-ls -fp`, as that's way easier to read. So it's only OPNSense that's affected, other VMs run fine? Do you get any output from Linux dmesg? >From the output of xenstore that you pasted, you do have another guests that seems to be running fine regarding network, are there any differences in the configuration file? FWIW, it seems like the netback instances are stuck in state 2. I think we need the guest config file, plus the output from `xl -vvv create config_file.cfg` Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 11:34:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:34:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325491.548073 (Exim 4.92) (envelope-from ) id 1noO8B-0000Oy-Sq; Tue, 10 May 2022 11:34:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325491.548073; Tue, 10 May 2022 11:34:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noO8B-0000Or-Q2; Tue, 10 May 2022 11:34:19 +0000 Received: by outflank-mailman (input) for mailman id 325491; Tue, 10 May 2022 11:34:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noO8A-0000Ol-3e for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:34:18 +0000 Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f39a196-d055-11ec-a406-831a346695d4; Tue, 10 May 2022 13:34:16 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40840) by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1noO84-000PcQ-ks (Exim 4.95) (return-path ); Tue, 10 May 2022 12:34:12 +0100 Received: from [192.168.1.10] (host-92-26-109-251.as13285.net [92.26.109.251]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2096F1FA59; Tue, 10 May 2022 12:34:12 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f39a196-d055-11ec-a406-831a346695d4 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Tue, 10 May 2022 12:34:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-GB To: Julien Grall , Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> From: Andrew Cooper Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap In-Reply-To: <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/05/2022 12:17, Julien Grall wrote: >> >>> >>>> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h >>>> index 0a2b16d05d..16b2e6f5f0 100644 >>>> --- a/xen/include/xen/unaligned.h >>>> +++ b/xen/include/xen/unaligned.h >>>> @@ -20,62 +20,62 @@ >>>>      static inline uint16_t get_unaligned_be16(const void *p) >>>>    { >>>> -    return be16_to_cpup(p); >>>> +    return be16_to_cpu(*(const uint16_t *)p) >>> >>> I haven't checked the existing implementation of be16_to_cpup(). >> >> It's a plain dereference, just like this.  AFAICT, it wasn't unaligned >> safe before, either. > > Well, technically an architecture could provide an override for the > copy. I agree that arm32 is already bogus but... > >> >> It should be reasonably easy to fix in a followup patch.  Just memcpy() >> to/from the void pointer to a stack variable of the appropriate type. > ... I disagree that it should be fixed in a follow-up patch. It should > be fixed now as this is where the badness is spread to any architecture. No.  That is an inappropriate request to make. Lin's patch does not alter the broken-ness of unaligned on arm32, and does improve the aspect of the hypervisor that it pertains to.  It therefore stands on its own merit. Your choices are to either fix it yourself (after all, you are the maintainer who cares about this unrelated bug), or you ask Lin kindly if he has time to look into fixing the unrelated bug after this series is complete. It is not reasonable to say "this unrelated thing is broken, and you need to fix it first to get your series in".  Requests like that are, I'm sure, part of what Bertrand raised in the community call as unnecessary fiction getting work submitted. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 10 11:38:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325501.548084 (Exim 4.92) (envelope-from ) id 1noOCT-000145-Dr; Tue, 10 May 2022 11:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325501.548084; Tue, 10 May 2022 11:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOCT-00013y-BB; Tue, 10 May 2022 11:38:45 +0000 Received: by outflank-mailman (input) for mailman id 325501; Tue, 10 May 2022 11:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOCR-00013s-Ot for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:38:43 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be4b475b-d055-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:38:42 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E799F21C06; Tue, 10 May 2022 11:38:41 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id F0AB42C141; Tue, 10 May 2022 11:38:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be4b475b-d055-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652182721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QjxQbnD6WUcAB5XSGPbhgiXq5Z1nB8h07eo4ZkZ4QC8=; b=ux1OKlKPpQAZrqb3VSx/+cdnKv+z0GMrb7Vrl4wT7av9mwtdsYHmGTFl15YLILBNoNipDu zhzvyNUQ0tVf4I8bosAIddNvm3hk9CLYxTFt2W7RQIuTrmM1G9742/mw3JpxDF9W//N0xh 4YsR4kO61TX2TGUrgE/V7TAnZzSnJsg= Date: Tue, 10 May 2022 13:38:39 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Evan Green , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2022-05-03 16:12:09, Guilherme G. Piccoli wrote: > On 03/05/2022 15:03, Evan Green wrote: > > [...] > > gsmi_shutdown_reason() is a common function called in other scenarios > > as well, like reboot and thermal trip, where it may still make sense > > to wait to acquire a spinlock. Maybe we should add a parameter to > > gsmi_shutdown_reason() so that you can get your change on panic, but > > we don't convert other callbacks into try-fail scenarios causing us to > > miss logs. > > > > Hi Evan, thanks for your feedback, much appreciated! > What I've done in other cases like this was to have a helper checking > the spinlock in the panic notifier - if we can acquire that, go ahead > but if not, bail out. For a proper example of an implementation, check > patch 13 of the series: > https://lore.kernel.org/lkml/20220427224924.592546-14-gpiccoli@igalia.com/ . > > Do you agree with that, or prefer really a parameter in > gsmi_shutdown_reason() ? I'll follow your choice =) I see two more alternative solutions: 1st variant is a trick already used in console write() callbacks. They do trylock() when oops_in_progress is set. They remember the result to prevent double unlock when printing Oops messages and the system will try to continue working. For example: pl011_console_write(struct console *co, const char *s, unsigned int count) { [...] int locked = 1; [...] if (uap->port.sysrq) locked = 0; else if (oops_in_progress) locked = spin_trylock(&uap->port.lock); else spin_lock(&uap->port.lock); [...] if (locked) spin_unlock(&uap->port.lock); } 2nd variant is to check panic_cpu variable. It is used in printk.c. We might move the function to panic.h: static bool panic_in_progress(void) { return unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID); } and then do: if (panic_in_progress()) { ... > > Though thinking more about it, is this really a Good Change (TM)? The > > spinlock itself already disables interrupts, meaning the only case > > where this change makes a difference is if the panic happens from > > within the function that grabbed the spinlock (in which case the > > callback is also likely to panic), or in an NMI that panics within > > that window. As already mentioned in the other reply, panic() sometimes stops the other CPUs using NMI, for example, see kdump_nmi_shootdown_cpus(). Another situation is when the CPU using the lock ends in some infinite loop because something went wrong. The system is in an unpredictable state during panic(). I am not sure if this is possible with the code under gsmi_dev.lock but such things really happen during panic() in other subsystems. Using trylock in the panic() code path is a good practice. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 11:47:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:47:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325508.548096 (Exim 4.92) (envelope-from ) id 1noOL1-0002m6-BZ; Tue, 10 May 2022 11:47:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325508.548096; Tue, 10 May 2022 11:47:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOL1-0002lz-8v; Tue, 10 May 2022 11:47:35 +0000 Received: by outflank-mailman (input) for mailman id 325508; Tue, 10 May 2022 11:47:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOL0-0002lt-M9 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:47:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOKz-0004XF-Eo; Tue, 10 May 2022 11:47:33 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noOKz-0006ev-8H; Tue, 10 May 2022 11:47:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PBCnjY1Xs7W8fg99x7eyE7kLdyVJN+nzlRK29bfjA08=; b=OmlEcytSMcbaUV7ibfUceGeY6q O3bgi3VUV3gQSt4r1Mj+uIRaMTc+LlxYuQahHbCvsCilEiQtyMED3yK+BoB5qUkkAoXepd3SkTpT1 T7uAE5N+Ji7IKexv2gHeizm8e54ZR509NTBaGfFbY/J+DmkWMYYTaa8O+wS7Tl+lANLU=; Message-ID: <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> Date: Tue, 10 May 2022 12:47:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Andrew Cooper , Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 10/05/2022 12:34, Andrew Cooper wrote: > On 10/05/2022 12:17, Julien Grall wrote: >>> >>>> >>>>> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h >>>>> index 0a2b16d05d..16b2e6f5f0 100644 >>>>> --- a/xen/include/xen/unaligned.h >>>>> +++ b/xen/include/xen/unaligned.h >>>>> @@ -20,62 +20,62 @@ >>>>>      static inline uint16_t get_unaligned_be16(const void *p) >>>>>    { >>>>> -    return be16_to_cpup(p); >>>>> +    return be16_to_cpu(*(const uint16_t *)p) >>>> >>>> I haven't checked the existing implementation of be16_to_cpup(). >>> >>> It's a plain dereference, just like this.  AFAICT, it wasn't unaligned >>> safe before, either. >> >> Well, technically an architecture could provide an override for the >> copy. I agree that arm32 is already bogus but... >> >>> >>> It should be reasonably easy to fix in a followup patch.  Just memcpy() >>> to/from the void pointer to a stack variable of the appropriate type. >> ... I disagree that it should be fixed in a follow-up patch. It should >> be fixed now as this is where the badness is spread to any architecture. > > No.  That is an inappropriate request to make. > > Lin's patch does not alter the broken-ness of unaligned on arm32, and > does improve the aspect of the hypervisor that it pertains to.  It > therefore stands on its own merit. I am not sure sure why switching from *cpup* improves things... and as usual you haven't answered to the clarification questions. > > Your choices are to either fix it yourself (after all, you are the > maintainer who cares about this unrelated bug), or you ask Lin kindly if > he has time to look into fixing the unrelated bug after this series is > complete. Or 3) keep *cpup* so there is only one place to fix it. > > It is not reasonable to say "this unrelated thing is broken, and you > need to fix it first to get your series in".  Requests like that are, > I'm sure, part of what Bertrand raised in the community call as > unnecessary fiction getting work submitted. To be honest, you put the contributor in this situation. I would have been perfectly happy if we keep *cpup* around as there would be only a place to fix. With this approach, you are effectively going to increase the work later one because now we would have to chase all the open-coded version of *cpup* and check which one is not safe. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:49:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:49:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325514.548107 (Exim 4.92) (envelope-from ) id 1noOMp-0003Nk-P1; Tue, 10 May 2022 11:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325514.548107; Tue, 10 May 2022 11:49:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOMp-0003Nd-Lf; Tue, 10 May 2022 11:49:27 +0000 Received: by outflank-mailman (input) for mailman id 325514; Tue, 10 May 2022 11:49:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOMo-0003NV-AC for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:49:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061c.outbound.protection.outlook.com [2a01:111:f400:fe0e::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3cd013ca-d057-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:49:24 +0200 (CEST) Received: from DB8P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::21) by DB7PR08MB3498.eurprd08.prod.outlook.com (2603:10a6:10:4c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Tue, 10 May 2022 11:49:23 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::c4) by DB8P191CA0011.outlook.office365.com (2603:10a6:10:130::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Tue, 10 May 2022 11:49:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 11:49:22 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Tue, 10 May 2022 11:49:22 +0000 Received: from 5dd077443832.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0D1975CA-742C-488C-99FE-C3271F74CB54.1; Tue, 10 May 2022 11:49:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5dd077443832.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 11:49:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB5778.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 11:49:15 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Tue, 10 May 2022 11:49:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cd013ca-d057-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ALxE5FNwy0+AKLVoat9S+AGIo1vptNCRcfcu8BIFv4OJZ1KW7IoWLqhQyBHUrybmi8RNat0CYd+PzCSCs7NnlO05gBB/174yu0o8f9JNSnlhg4H+0wNic8Q+GzYoYJ8tysktm+hw+FXcMRj+Kqhy8Npsd215E6yDzKG6wbWWn2M6oOMTGKPIpdV6FOOFbHDM8N7pVKWfZvEtAPe5wC5al666T18Q166r3v5B0QNoGyyS+bdqjOFlnSvETFZFL393Ggel2u0STSBOfonWyamxSjv9RzrBVSTWs6ROoQKoirdeEdYQyrdumaC2RCPAdeE4O3Ew+FkY/ZGHv/LJ57Sj7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=Fz4cL0j4GBNvQfvsYptEHAIqH6ZdFNmTeUaQtPJH9FGtRwjQoSjqM7iNq9EYHd8PVBmUtDJH9n28jq2WH5qgSeCzKPt13mIScOAaXBFeRT2IP+3NfG5JtP4ss6qbVTobb9kyfpN3clEc4PMH2YHIASEobkY5lMleEWFcLym6eJhBBI0eyXbsr0EMbrjGxyZEdqggHyFZ9j9DZuRcFcZH/omexXpQiPFGPsH41CyLzVn/+VBZAlGbkCCGlOfscWbCOyugGF591gIXD1enAnM04tHLveN/kB9NmrVLNYgUGhH8LJYun7YSW6k3ywUYDN0WBt45VUJfHh9gfyRY3GkLZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=EJdj6igrvyeexdT3CfEqcNrsnsRkwMaHPQSpJfW1mf5z0Gbhya8iQrvTVQpzxvHpjDw9p+MNHGWkJQY32vUSrSf2ODsyyrObxizWUfs+11WYBTxHVRZicRPXfwIrMSEU8N+Jz3PuzvLCvUI0A59bDKulpTLQm03KGFfIhAKRuMs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 388f78bf1f728a58 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=baYjLXh185jWjMTNNJr+MDA7sLn8ZBKake3gT5eROg3TQqMG4/OwwHNCTl+U/clb5L4IBgTzeaN2wbwxNXS8DYFz/6UEvyHGPWpzWdZ3E2I3lKI+UogO0oklGCAlk8gmyJeNzNsL9tMbn7uKHQRP63iqFAdWi1L3p63YpTPipyX60508ZHmVqyCfRnyV8V2UBqSGh78V9a63GSaZs8saorym4AMvJeG2Y8WZlt9k6DlRJX5H+lTOVCzNKO8qRLEWapVDXCQyclsQy8K+rag1oOKVNuz+QEn7z63nOQa3uC0zRrBBYCh5WVeCc+6dJakkbht5DPCxjzV7tmtTNBnaPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=Dl2vajc6q1g5NFZwDZo/i2vNdpDwonXTF2oRLXddKrj7K6bl0VaYvjr4CfBAe0nbS/Xu2OJwF8ATbHF5ZjZsAfD1agoOp4YoaGnTFu6iLqhNzXWcARN1a7UixawvI+V4f9T66uMR0VJR3qEVyCusVDqvp5/63SJgfTMoH9dHgd0LyFJIkeFoIqyF5DqJtYvudmGHwlK43cjJDqs3z9peIfwvJ7Q4z0VMuGWUMkBFU3jkGV4CvCl2R7jaSxbB6mheLSA83E0R6BInPw+LCZpqF4MbXufMSVzxkTHwTuLELrMUcwk2G7zUkWKgpMd1x9l6Fw50Kj6IICdKqwb9PZyk8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=EJdj6igrvyeexdT3CfEqcNrsnsRkwMaHPQSpJfW1mf5z0Gbhya8iQrvTVQpzxvHpjDw9p+MNHGWkJQY32vUSrSf2ODsyyrObxizWUfs+11WYBTxHVRZicRPXfwIrMSEU8N+Jz3PuzvLCvUI0A59bDKulpTLQm03KGFfIhAKRuMs= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0W8JQAgAEkhwA= Date: Tue, 10 May 2022 11:49:15 +0000 Message-ID: <5CD3173A-77CB-46C0-81BA-38CDFC6DF5E9@arm.com> References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9862ed13-d3a6-492f-7563-08da327b1fff x-ms-traffictypediagnostic: AM8PR08MB5778:EE_|DBAEUR03FT035:EE_|DB7PR08MB3498:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fNEhxsL7RqT9FRfP1JRvf796m2liHwwIowCw2yGYi4+sRIS/G8sstet5bUU8hlJXq6h5BZrKFbwvc1C/tRlnxrvPjXUO5d/frpKAcFxCekgIksEYrb5fbbYWvvxsPbleXn+6q22kjzPpbRlVzC/SOwhOtBbvos3GDyxodDaHlbQ0NrorxBHza/erD54Arfp5CWOPFBx7kcLu6qrqRmWcabHEk/kfNOdRD/KhD+ooFI+15hqZaBncCKgqKLigpWQ7ZNkJkIXqPBxSzb3p8hkDpgwB3GjGWFaviWHoaqwh5c8+mHfoCyBCWYVH56vFiYLvPyUVj17nnqzj0e992w8t8ONqNRnW4+k8pvdbKY4W4HlOlRLpCNHIMIaTR0OOUUMAtvIFA54UbCBB5Z9T1B2yg0AxRrxjyV6cs4khmYigvjWjvpcYkX75iLA5aXK9skPXVd6Et2pmva8lYfl5D/I9ZiqJdc3IU21Pb++HdiuOWt0wQc0Lj0+sbKCLqTzSWKH+ipBmanZt2fLFbP1wpNguFoNrDYtLM04HuHShwsxEf+PhXaQuGutksVadVNAIlZ5RoF5/kg+zd/le0K7G7Mvz7KUJlxvrDzH+KdNtVpB9f4UA1AJaFS9f6zrqdh1AamrOl7aK1TvI+M5pTpm6sXOMtoVWGO9CL34G/OjmgJwIgsLDfPWBrjfF0qZoLlqKV7+eC+UPiFNhQxj3DO76eH866TlUMAHWVokHt4hemL348dL6NATmN79vXbBrIs1qU76y X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(38100700002)(38070700005)(6486002)(6916009)(54906003)(122000001)(316002)(186003)(91956017)(8676002)(8936002)(4326008)(64756008)(66446008)(6506007)(71200400001)(36756003)(6512007)(2906002)(76116006)(26005)(66556008)(66476007)(53546011)(66946007)(2616005)(4744005)(33656002)(5660300002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <15D83459BAFA28409AE8B7F645C30925@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5778 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bc98fda3-aace-4e96-c960-08da327b1b90 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hLPU8++1c+iTFn69PNjdXvvApw3q6pBgNB0JxCf5RrE5R+alp9cmGsd5ogSZyFbxGHYUYwuF/wm29e5oHnJmlth1lf4yuVugTVCUAAhdi+3y4f45xyvaWXW4C8U2Eub7oU1vtZPOKtlbFbin9yfa/xnJh71zLpje+u+tf9vpxAY/XurrP7KlSyENW+nD3YjMqQU5dMxKh7eSqRcSuqUab/tZaFZy6Byaug9cGZq8S+K3dFGZMfXhilmobQjyQICiZk/14+zjTBhqSIDu451EFSz4Jd01bqH0V8MRwFFr4kuw7VY7P4frdulGv37Np9IPOT6u7UMnQZZqoGkCexZ+kpH6LvdARuVtH62hxkkwBYYp7wuTpde4DeBgofLsUQzysE0bUar9XFeMiLsw+3z6uLBCnsdyj+jpo+EZBKjhzOIoonKxtpzIB6lOoHzjFfu0r7n+NTBGewI6eOxqOaA6uVV7MLXDjCAJpm0BZPUwAjYeUv1bl/dmsA94Bk45Z6i6azriNE1kXqO2X4Er0H1P7C1QNVljowfQ4YvcBmghIJed8h1Vtw6VcTMgYa8qach5gMNyUSjJkt55DkZ/lgvMbN/JOHUSqangX+pMa5Lqoy+5IJMngJY1UL1LFaBrZY7/PGhWBpyoW8RlnFl0A67FdujSDEj5AXRhTL6E32yy5bP6ZmoGVwwn1SabUElUyOP8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(86362001)(36756003)(47076005)(54906003)(336012)(316002)(8676002)(70206006)(70586007)(2616005)(6512007)(36860700001)(82310400005)(6862004)(26005)(356005)(186003)(4326008)(40460700003)(6486002)(53546011)(33656002)(6506007)(508600001)(81166007)(5660300002)(2906002)(8936002)(4744005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 11:49:22.5391 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9862ed13-d3a6-492f-7563-08da327b1fff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3498 Hi > On 9 May 2022, at 19:22, Julien Grall wrote: >=20 > Hi, >=20 > On 26/04/2022 13:38, Bertrand Marquis wrote: >> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include= /asm/processor.h >> index 852b5f3c24..ef37cfa16f 100644 >> --- a/xen/arch/arm/include/asm/processor.h >> +++ b/xen/arch/arm/include/asm/processor.h >> @@ -219,9 +219,11 @@ >> SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\ >> SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE) >> +#ifndef CPPCHECK >=20 > Can you add a comment explaining why you need this check? Sure, would the following be ok ? Cppcheck preprocessor is wrongly throwing the error here so disable this ch= eck for cppcheck runs >=20 > With that: >=20 > Acked-by: Julien Grall >=20 Thanks Bertrand > Cheers, >=20 > --=20 > Julien Grall >=20 From xen-devel-bounces@lists.xenproject.org Tue May 10 11:51:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325520.548118 (Exim 4.92) (envelope-from ) id 1noOOJ-0004il-50; Tue, 10 May 2022 11:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325520.548118; Tue, 10 May 2022 11:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOOJ-0004ie-1l; Tue, 10 May 2022 11:50:59 +0000 Received: by outflank-mailman (input) for mailman id 325520; Tue, 10 May 2022 11:50:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOOH-0004iY-9F for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:50:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOOG-0004bt-S7; Tue, 10 May 2022 11:50:56 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noOOG-0006lM-M0; Tue, 10 May 2022 11:50:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=aIIYG68/syJ4xQkdjo/1h0cXzMZTlXJWfMrMZXSSCnY=; b=kpZV5yxjXnLtSjt8mdtBw4ssJR Ro+EiG7hyZkCHcgxuTt7cmNpMrMkK1OOgC6RcP9VTqatO9cS9gLdyfsvYZSCG/dlPpKWBHBzMHp7A fc+vK8ZBKxxXrY/zd1jmJf8JoVXWg4fOF1oT4c21L7Qrwv6EhnRcjQfTRqfyJp0IXnv0=; Message-ID: <1086632c-daba-96cc-9b3c-ef918a47f71c@xen.org> Date: Tue, 10 May 2022 12:50:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> <5CD3173A-77CB-46C0-81BA-38CDFC6DF5E9@arm.com> From: Julien Grall In-Reply-To: <5CD3173A-77CB-46C0-81BA-38CDFC6DF5E9@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/05/2022 12:49, Bertrand Marquis wrote: > Hi Hi Bertrand, > >> On 9 May 2022, at 19:22, Julien Grall wrote: >> >> Hi, >> >> On 26/04/2022 13:38, Bertrand Marquis wrote: >>> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h >>> index 852b5f3c24..ef37cfa16f 100644 >>> --- a/xen/arch/arm/include/asm/processor.h >>> +++ b/xen/arch/arm/include/asm/processor.h >>> @@ -219,9 +219,11 @@ >>> SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\ >>> SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE) >>> +#ifndef CPPCHECK >> >> Can you add a comment explaining why you need this check? > > Sure, would the following be ok ? > Cppcheck preprocessor is wrongly throwing the error here so disable this check for cppcheck runs That's fine with me. I think my ack is technically sufficient here and Stefano tested the patch. So will do the modification and commit it in a bit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:53:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:53:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325526.548128 (Exim 4.92) (envelope-from ) id 1noOQE-0005Nz-Ha; Tue, 10 May 2022 11:52:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325526.548128; Tue, 10 May 2022 11:52:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOQE-0005Ns-Ej; Tue, 10 May 2022 11:52:58 +0000 Received: by outflank-mailman (input) for mailman id 325526; Tue, 10 May 2022 11:52:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOQC-0005Ng-IL for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:52:56 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0626.outbound.protection.outlook.com [2a01:111:f400:fe05::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba232a22-d057-11ec-a406-831a346695d4; Tue, 10 May 2022 13:52:55 +0200 (CEST) Received: from AM0PR05CA0090.eurprd05.prod.outlook.com (2603:10a6:208:136::30) by AS8PR08MB5990.eurprd08.prod.outlook.com (2603:10a6:20b:296::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 11:52:53 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:136:cafe::89) by AM0PR05CA0090.outlook.office365.com (2603:10a6:208:136::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Tue, 10 May 2022 11:52:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 11:52:52 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 10 May 2022 11:52:52 +0000 Received: from 32cd8a470739.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6DAD282B-D678-4FAB-BA80-346B261696A4.1; Tue, 10 May 2022 11:52:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32cd8a470739.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 11:52:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VE1PR08MB5789.eurprd08.prod.outlook.com (2603:10a6:800:1b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 11:52:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Tue, 10 May 2022 11:52:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba232a22-d057-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QH00rNmOEp01+rpMk/gHuGg7MVBtVV0EdBTetPdpyaGosYRNk3zMNl+OvP0709MN4Yg41RgcVQcbZCRANCaehQyAwh327tZg7zliNpm+WFwEJ1H0whoBY0vB0jewH+7EimGp09+a8URk4pB0pfeiI4z5Xgnea9lE6quJj+rNXedFsIHgzpP8SdOIle7u8vsBt62mVO2YRsf4C36Krr+kxgE21Bb1FSvRp6/HHn6RMipaUnXryUa/8biSFmG8a+FL3xu0HmXZ58NwnhItgEDKpmccpfngZosGBJksp2Q7ubGZbB4EPpwMAOI5qaMmQTeys8lz/yyuOJ8ruc7R21jNIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=O5oO3dze7tS/Tjj1itsa1kMcLGrEt7oHzFuT1Wnp/K05RxK+Bdb6u++FUwtofaVQ1nWQednd0HiiBGHWz9wmr1nU41flmIrrpVGiyYLAWmihr/mFymUPfLkkRydsMQw22DRtH3FEaBWJB4nqHmRyz6+pbelVxQ2t0YgDN778kNgN3ZnNi3aHV3IG6CR70+dz8VctKlr2x3IQoXCKa92Mnounw/MY0ikJLI11L6McWMiuuX2TOstroteheJY3b0bc/uD+paY530emEoghr11PXOB0ngEx4BKvK+xmy3b6B9dxyAHWgHI0E1pciedQ3Y0Y50O1G+j74rmN8K249qwTIg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=h5IrHUI1YX/tq8zstT/uRQvZW0R1APw1eTRTWLgSEQ6zu9cEDiNNMtyl6HBPiQg8MBd/omjaF6UCcKaT1zw9PpgwobFxk3ZqxIFDrwO1P1ENSmR2cLmWlu1ItcIj5zhlEZgEoV1udBKFttvSDxsMl+UcActZA7FOnA9jODGMFtk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1a9a7972b6583793 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LmnpdxflorWsXQnquQMOqgrt1jJp+sUxAwwiaJQ3FDR1hbOb2Ej+H+CGzAl02hK8Cli8cS5P3Dy1AKrdLGS+gFhRb5wDJ5L6hqSNjRawNU8e1bHojZ0Ray9hVcFwzDXR3tSJgPcQ/wcTcsR0hIPPzLkFMl3gp8aX/6JiTUOlMmpd5j81Cdtin3cbq9OMC4XOtYL9TbjzRohaE7kOZgJQyvgIPlvPypoiQZAeucyearc8Y5cc4WBQxAlFPHhxcBRUZag/Uidj/wMfSWrQ7sQ2/3MgSlxL113Jb+dI0ZO7/AoEhyKWGrr8V+xhoziDd5OUg1h4da5MwmfZFjVOOs//IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=NyPH4ccZ3RheP9QblWpgusc3OJf6Nyb8XStw+VGaAfV23lL/JVbhIyhhplBc77ZYHAiIBjmdJYQWMZkgLwSh97h0Qq3CrtLN8ZhVwyK/I6fr4xNV6GzLwaNxRp1B/gzeLZBaiXjmyrNDPnDqK1qjz/sXnSVTzXGq8O8e5yCkufzr4vuY3H1EPQ8GZPZuC/gTtWQoTStKRAsYD2BxvWVeOkuVfVtd3lL1VbMXGVA3u6M+jEw0xFu/BNmfT0+qojgnZQrAi8affLFTIQpUiCN8vnaoqmQhGD9Kck96+lmIiJaNWquRz/GItqrnha2FcsO+tsS0y7WAeZjDLdnJ+eLXLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zr980hwglPXKbEtBZQOr5MfKE8T8o2fCZSx9I06tq3U=; b=h5IrHUI1YX/tq8zstT/uRQvZW0R1APw1eTRTWLgSEQ6zu9cEDiNNMtyl6HBPiQg8MBd/omjaF6UCcKaT1zw9PpgwobFxk3ZqxIFDrwO1P1ENSmR2cLmWlu1ItcIj5zhlEZgEoV1udBKFttvSDxsMl+UcActZA7FOnA9jODGMFtk= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0W8JQAgAEkhwCAAAB3AIAAAHwA Date: Tue, 10 May 2022 11:52:38 +0000 Message-ID: <9D2EFB29-8A31-49BB-B5D3-A3AECBC83847@arm.com> References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> <5CD3173A-77CB-46C0-81BA-38CDFC6DF5E9@arm.com> <1086632c-daba-96cc-9b3c-ef918a47f71c@xen.org> In-Reply-To: <1086632c-daba-96cc-9b3c-ef918a47f71c@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 97b877bd-10a7-44e2-ffe1-08da327b9d58 x-ms-traffictypediagnostic: VE1PR08MB5789:EE_|VE1EUR03FT012:EE_|AS8PR08MB5990:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EoRs8rOn+fT/VSCSTqAZUqA3O//fJlARyS9le9uvtoru2u9HyrVhHO7HOYTmg/6iLK6mWgd9dkqBhi3KCv7aWNv+TNUCOIaMKRVQciIFg/YPIB6ktMs2difxU89jDLIDYstjwkRJH+OuW9A9caZakRrA8BLqmvFQ9GAK02f5y1xEh3QajXOTASWrxaVJ0IaV549oS9V3rGn1Nc9PfHe30klfUEVGM0youENbNA1uPNYexREu/ST1QGncUjFhqORtcj1I9h9xEBzdV829qj68PJwpGLrJEC/6GfKuEbEG4t3ksS9qGq50Rdtl0i/m2U+yp226rT+93xPvGZvI0JuSFcji3MuaE79EZegfnzGX+eyo2mG/w0Nb2o2JgP4ZNdpoadD9pp5pcGObZY2Ikf5taHqSWDp5cxaBJsFZzun8Lam+sS+e/nAwEgtn+etHnn/ULFpsAEEljY0XiNyrFiqsTHpHyTrBGjdakXiqckXrxEwkwh8oVk+zosYhEwHERRh9c3nrvoENetGL8BaWacbXl0IRPeXM1JNtHba2X4FfwL1zG96tEf3PNrwTodKTqJY4gFicLjoiy4rGXkw6bWozJRjKHKHGyMHzJNMCvMKTUbbNRlwv/8mldhBl8tJbQP9F4JAN6rwBRWR8OJMIJFQzIPEl7Ghz9uxweJMJnk26j16lOgC3i84Uxa4BRbLkv3iLTVCKJv4w/JVY2uc04yu71LbR8CFpaylrGxapOVMm4A8UUNvVTEe2ykr61xlA2k+V X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(38100700002)(8936002)(6486002)(38070700005)(6916009)(186003)(122000001)(54906003)(316002)(66446008)(36756003)(71200400001)(6506007)(91956017)(8676002)(2906002)(6512007)(64756008)(76116006)(26005)(66556008)(66476007)(53546011)(66946007)(2616005)(5660300002)(33656002)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5789 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e5cff8cc-168e-418e-1db9-08da327b94ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEFLQMs7ddsU/QGPYSgNB0GWY6edvfUAPVSysQDQRl2GYcaZlCiZzW+Li/+1bntxr6FKAykqOTxqizxNmz8h8Uxs+/IcEsta4NHouzJAPGGylPYSHOJD/iyJ/YmEi5h4UiaJsvTlu3QoLgmx+oRs0kAa1wmsLxE0IotdaOV92067EGWaaRmFyDQ/KmtgEdJs6a+1lVln3DxPq/FcdE4rmEd1X8k9QDXJkkNHm/MzpuZICL1VBwhWBFStZiomIMYsTZk8U00G4vqbv8Z9ajLFbyRkvE3hPcLAWS4hwWl/U/ce2nysp4TpamRORNpMR/RdgBZbvvZxj9B/+G2Ae0I5Hr7qa5mW3O4MqZNdw14OJpeud9TxblsEG1T4LjU1Lgo52gdfBn0G6F5lMBVYE4o9DfabY/LUDa80tEZgmd1eSmM61aevjsGQHEu1x8DKi+XD4CGCmnZs+p5hQZsXYzxaoamMeJGXviXuPDPUu0gMKdFpoPs+jgLD09+9+oxRGRe56kpuEXV8xRi7hFo5SWH+g+iA6OxklgvfdfLcooB7gAVw/s/iqEmYrXRAbGMzKGyuBqgvl3KaRVzDG5rqhHfDPjG1zF+LCOqD6jKQ4Hj5Qbgj4fOmEZ71ZKnPNzJtV5EElusvNGl4mbrmRpahrCuN1Cg5sXnTJSjr+gYpUDebYfbYhgRSVNpG8vtyN0KBKs/x X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36860700001)(2906002)(36756003)(8936002)(356005)(81166007)(40460700003)(5660300002)(70206006)(508600001)(33656002)(4326008)(47076005)(186003)(8676002)(6862004)(336012)(70586007)(2616005)(54906003)(82310400005)(316002)(53546011)(6506007)(86362001)(26005)(6486002)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 11:52:52.7474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97b877bd-10a7-44e2-ffe1-08da327b9d58 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5990 Hi Julien, > On 10 May 2022, at 12:50, Julien Grall wrote: >=20 >=20 >=20 > On 10/05/2022 12:49, Bertrand Marquis wrote: >> Hi >=20 > Hi Bertrand, >=20 >>> On 9 May 2022, at 19:22, Julien Grall wrote: >>>=20 >>> Hi, >>>=20 >>> On 26/04/2022 13:38, Bertrand Marquis wrote: >>>> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/inclu= de/asm/processor.h >>>> index 852b5f3c24..ef37cfa16f 100644 >>>> --- a/xen/arch/arm/include/asm/processor.h >>>> +++ b/xen/arch/arm/include/asm/processor.h >>>> @@ -219,9 +219,11 @@ >>>> SCTLR_Axx_ELx_A | SCTLR_Axx_ELx_C |\ >>>> SCTLR_Axx_ELx_WXN | SCTLR_Axx_ELx_EE) >>>> +#ifndef CPPCHECK >>>=20 >>> Can you add a comment explaining why you need this check? >> Sure, would the following be ok ? >> Cppcheck preprocessor is wrongly throwing the error here so disable this= check for cppcheck runs >=20 > That's fine with me. I think my ack is technically sufficient here and St= efano tested the patch. >=20 > So will do the modification and commit it in a bit. Thanks a lot :-) Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 11:56:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:56:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325534.548146 (Exim 4.92) (envelope-from ) id 1noOTL-0006IW-Gn; Tue, 10 May 2022 11:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325534.548146; Tue, 10 May 2022 11:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOTL-0006I4-A3; Tue, 10 May 2022 11:56:11 +0000 Received: by outflank-mailman (input) for mailman id 325534; Tue, 10 May 2022 11:56:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOTK-0006Eh-D5 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:56:10 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c3a9240-d058-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:56:07 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C61EF3200907; Tue, 10 May 2022 07:56:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 10 May 2022 07:56:05 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 07:56:02 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c3a9240-d058-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652183764; x=1652270164; bh=56kiObAcqtyPo DVU7lVVW82nxC2+/WT3a7Eom84LACA=; b=eCIVkSXedPt6zjeBTwDJGjb+0KGVR ZEiVbUe/wf+yWAqvwlPWJWWR4+wAvB8VdfywQHiOWI1CgxqPNplgBFvu8CuaEL4U eY850XE6ptqDfRcx77iN6JCMK4BB67jf3BHECjd8dvcddbHHQph3Ca+gK/A8Cw/b lWRLQiu4a8DXgu8b2G2U6c/ZeOVcKk4VmizfyTVJLmoPvjF/WzO+GaovBgfg0xmM LbKFGrASikTbxRVaFLlu6Mfotjq0yj3BbWN62d3FXFuS1ZAwWqXcOK04RqSJsOXG UgyQG8xPYQ2mChHpXR+hB6XAo9/LerPMJyEswohXQYE4kjmVMuIcjjh6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/2] ns16550: Add more device IDs for Intel LPSS UART Date: Tue, 10 May 2022 13:55:46 +0200 Message-Id: <20220510115546.1779279-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> References: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is purely based on the spec: - Intel 500 Series PCH: 635218-006 - Intel 600 Series PCH: 691222-001, 648364-003 This is tested only on TGL-LP added initially, but according to the spec, they should behave the same. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - new patch, adding more IDs to the patch that went in already --- xen/drivers/char/ns16550.c | 80 +++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 0c6f6ec43de1..b4486a4e8768 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1077,12 +1077,90 @@ static const struct ns16550_config __initconst uart_config[] = .dev_id = 0x0358, .param = param_exar_xr17v358 }, - /* Intel Corp. TGL-LP LPSS PCI */ + /* Intel Corp. TGL-LP LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #2 */ { .vendor_id = PCI_VENDOR_ID_INTEL, .dev_id = 0xa0c7, .param = param_intel_lpss }, + /* Intel Corp. TGL-H LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51c7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51da, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7afe, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7adc, + .param = param_intel_lpss + }, }; static int __init -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 11:56:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 11:56:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325533.548140 (Exim 4.92) (envelope-from ) id 1noOTL-0006Ez-4j; Tue, 10 May 2022 11:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325533.548140; Tue, 10 May 2022 11:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOTL-0006Es-1h; Tue, 10 May 2022 11:56:11 +0000 Received: by outflank-mailman (input) for mailman id 325533; Tue, 10 May 2022 11:56:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOTJ-0006Eh-Jv for xen-devel@lists.xenproject.org; Tue, 10 May 2022 11:56:09 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ac8f4b2-d058-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 13:56:05 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C08E33200035; Tue, 10 May 2022 07:56:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 10 May 2022 07:56:02 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 07:55:59 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ac8f4b2-d058-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1652183761; x=1652270161; bh=l470sTk6AYbXl/5StCvjUCS8xfxEHkh+cnC xv6SFlLs=; b=ZCUmZT3Os/s28TZniTUEc9go6riZk3N372WE1HduPF3qrdmJawx av0VkpNGQHtuzo4YPQFvGfd/BbSg0ZjFzEiqg4JXnZrmJAOxbt3ONgRGHspa723V 9O3cggoTMIx77F4SMAKXxa7qfYTHTjdgWUnB1fF1lv86zpv93M0BsBbe/Z59AbXh Lxdnar9tCi/Y6jEBHnAKMHDVgkSAFkEcZMrfiBZuhboW9QE5ABuPIIbJEJNRmVyk ukDXMVWmNFI3jkUwsiBasRN2bq+UgdwN5VoqVj+lvxeC7hF32Mm18BdPnz3ciayP /DTIqeBSMCU/C/ZZOdrLjDWmOMjaruyWblg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi Date: Tue, 10 May 2022 13:55:45 +0200 Message-Id: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel LPSS has INTERRUPT_LINE set to 0xff by default, that can't possibly work. While a proper IRQ configuration may be useful, validating value retrieved from the hardware is still necessary. If it fails, use the device in poll mode, instead of crashing down the line (at smp_initr_init()). Currently it's x86-specific, as the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - add log message - extend commit message - code style fix --- xen/drivers/char/ns16550.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index fb75cee4a13a..0c6f6ec43de1 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1238,6 +1238,15 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) pci_conf_read8(PCI_SBDF(0, b, d, f), PCI_INTERRUPT_LINE) : 0; + if ( uart->irq >= nr_irqs_gsi ) + { + printk(XENLOG_WARNING + "ns16550: %02x:%02x.%u reports invalid IRQ %d, " + "falling back to a poll mode\n", + b, d, f, uart->irq); + uart->irq = 0; + } + return 0; } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 12:04:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:04:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325548.548162 (Exim 4.92) (envelope-from ) id 1noOb5-000091-EV; Tue, 10 May 2022 12:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325548.548162; Tue, 10 May 2022 12:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb5-00008u-BC; Tue, 10 May 2022 12:04:11 +0000 Received: by outflank-mailman (input) for mailman id 325548; Tue, 10 May 2022 12:04:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb4-00008e-2K for xen-devel@lists.xenproject.org; Tue, 10 May 2022 12:04:10 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0602.outbound.protection.outlook.com [2a01:111:f400:fe0d::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c3074e1-d059-11ec-a406-831a346695d4; Tue, 10 May 2022 14:04:09 +0200 (CEST) Received: from AM6P195CA0084.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::25) by DBBPR08MB4903.eurprd08.prod.outlook.com (2603:10a6:10:df::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Tue, 10 May 2022 12:04:03 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::77) by AM6P195CA0084.outlook.office365.com (2603:10a6:209:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18 via Frontend Transport; Tue, 10 May 2022 12:04:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 12:04:02 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 10 May 2022 12:04:02 +0000 Received: from 4c4182ad7005.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6F851DFA-308D-42F8-8E79-377E59BFB180.1; Tue, 10 May 2022 12:03:56 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4c4182ad7005.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 12:03:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2520.eurprd08.prod.outlook.com (2603:10a6:4:96::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 12:03:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Tue, 10 May 2022 12:03:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c3074e1-d059-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YYkZkeMvLGSK6mQI3bDihkj8VnbJTOBv4tiCzp4kerTEBd/xuz502ZONv8CAyeB8Bay5NSE0+6etHwD8ZQ2YsAF7G9PeCbG9TLvKIevkNIJiYGhr4BSezd1u4Wf22f6K+I2NL83uckdrmskmKLmJp/9gDOB6HnlsIVIdl0bQkC4Nd3Z/LZRUvkMqzF4SwDfw1nzYqmov/jZqIXvAR+nMCBn+WIFBYzROAPggyY9R5/fuVTAh/gQaQJlxkWDHCE7OSY5qkLo7mz8cWm3JVJSzF06RG43FaFMi9+9SU2xqZYkfJzZHRMGtiE+Pf0ZAh6KGor2clD3y9o6sdthlUrUB+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/mCpW3FKt1Sl1r6ofgLzStfyndj2h/i9tchyQMN0Ao=; b=eusfpq44U5YnZCqODwBDyw4rFi5swH+taKd9SnAkZhPEwkoMDq9cLajGeARo99yqs5qBDDui07KNAnkVNjnISFUmSc+zJX/KBRhA58RTfHi1c2PdNEDu198ZX/xOb1Sb2sUTNYra+IcaQazBvzc4+HXBIEeYrQotJAKRHuGO/cDIZXFxNFio/s/O7fK3vGpGU+iK+ZwSLa/w5t5K7yewkMnRK3437XvdG0XAqO3DGG4Br2x47XIsV7KYMg07AMLjQFdru8OY8roJBcNv9CLPOzqfnlhlxQb/VvL/g3ITTyy8K28t/qiWiD9mfV5e8fVopxd+j/d/JrAYVOQyOfmj5g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/mCpW3FKt1Sl1r6ofgLzStfyndj2h/i9tchyQMN0Ao=; b=reviudpqOpkjlEKZ/p/W7b8UbT0Z7bs3jBNu5fS3noAA1VPXOdmYvDDzQFcUZYN4HfHiLi7tw+jIWqkO0IdYIbykitWfDuDSiFJgdZ0DuCFEWWkd+vSYtz9cHozJhxrSpcVT/S/xMoP0UP1/O6W/W4Pl4lHhOPU9ZwOP9l3C6b0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 965403c85fc9ca0a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EzBOTw2Dj3QEWw+S7CtNKZsSFZzpffvYDSZ6PBMtdWCl+Lw7ZtQIRh6TAkJLqzv1kq0HHosDJ2z8/XmpQZ3kcOAzYjqwYQoEcs8oNj64di1QZcJilLdXbDG5kHd2QHXNbh0NBzHaQT8VHXUaEoyHjx6T5/M1XbClehHR0xTUBkcEjoYiVMzJyRbxD8QE2ATdDKGNrS/jnLrFuOKM8hsxQ+ep0ACLLG9fDNwUIOqQ7eWm9P0sT8MK1D1n9vJsfK9Q5vOupzfvjN6qViqdslJuMNfi7vAHqLVdAMPvqvmXm+qZL/yn1Nt3Z6eNRZkDmPq/gufOm/ecm4RVLC+55nuxHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/mCpW3FKt1Sl1r6ofgLzStfyndj2h/i9tchyQMN0Ao=; b=aVYIj5IDpJnPYQDAUYNdbMCLE8WgdHzZ5GovFIhKeLRsu5DVhveDKetA5GcZ8C8zXc6EtW9aHDNh4dMgjVNg5mTjAzKdJOCk1DyeEWwAhRF3p+Mh2vnvSArk6M2oEdlFElS225o1QzfnXVITx0/bhSthVfDkfdydNkbtiejhyhGA+rOmINcYPh0a6haYJsjhSStlmORrj5cSfljPeNWTeckzXgm/V1dLr+so1zx8MBPFZYBD3a6Aev8bS5Xz7gGzYU4BeCMSQcaf6mO+ZJLyfdkddzqrL4MOBTIDs/qB7rM0CU7zogHP8gHZse/qP0TBwAK89VQ7jBK3IY7hvhdubQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/mCpW3FKt1Sl1r6ofgLzStfyndj2h/i9tchyQMN0Ao=; b=reviudpqOpkjlEKZ/p/W7b8UbT0Z7bs3jBNu5fS3noAA1VPXOdmYvDDzQFcUZYN4HfHiLi7tw+jIWqkO0IdYIbykitWfDuDSiFJgdZ0DuCFEWWkd+vSYtz9cHozJhxrSpcVT/S/xMoP0UP1/O6W/W4Pl4lHhOPU9ZwOP9l3C6b0= From: Bertrand Marquis To: Stefano Stabellini CC: Rahul Singh , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Topic: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Index: AQHYX91LyQUbnRX4102lMt+LkaTZwq0XDS2AgAD/IgA= Date: Tue, 10 May 2022 12:03:54 +0000 Message-ID: <079FF3B4-79B1-457F-AF45-ADB704E7FF7D@arm.com> References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0bd90788-b4b5-4f29-c3c1-08da327d2cb2 x-ms-traffictypediagnostic: DB6PR0802MB2520:EE_|AM5EUR03FT049:EE_|DBBPR08MB4903:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pYWq6iDkf6Xpgl9QOEuayvcphIi5W/O2AZyJYDggx6ReAUFe55hnA5LgVSQzgq+0rc/5tr7ItmpYAsY5xW1o91uh+Hu4Z6jdZBSv6hgKKyNeYKRVBZ12KMCZkugLyxqzYcKIqdAt0BkpS3ICsfe/s/hPOg9pJPEV0GPF9SWCNF3ebyNMWNGoPr9ZVd5YmiDH/2RNALhJmo02eP5ubBxb7mWlBklVEumpKnM/RDKDPz6A+1LJdKgLiID4Q0gxrxKoVpGaV0VNtOYvfEXBktgEwzjZltgokOHvaXryrhJMLNaINvjBmSCtX0cz1Pdr5E9YuzznzlEo+ldE7mEDV5UXW2tj1KeCFBBzBCvDhCcSlAZRGEvtA9LgOpRvHvOTCL7auWsYnekC7mZuoWNUD1xgjz0rvU1Vpajczq3Ohi7KOr+RKmOAww4M5CUQzoEO6mqLLUM+a6Ywu8QKZBMTl5k5h9mRamVo2dcDzNuJiKkEm9ez2FTbxUgLhzuHZRsCZxBjCcRfYqMUQwpwajBx8Hian+FrseZS+xUgquNxSSC61jeDSx4McN48dh7KGqJITuZdVgOyzE7hO5y78OKb6VJd/vBia5RUgXYd1SKTbA8fQu27VHsTi1sYwZi0ZMT9d8GOWr97T5DG75reLo6E1CmvoQOmgGotZZW8Rt549T66ERZbGcqRW5ZvfRqV557s3mGiC5sXlr0fciaAAE+PE1jQpdGbFM9TVWpaMZeGW7GCnPr7N3nweVrQg/o4Zb5hI1Qp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(91956017)(2616005)(36756003)(122000001)(8936002)(53546011)(33656002)(6916009)(76116006)(66476007)(8676002)(66446008)(64756008)(66946007)(4326008)(66556008)(54906003)(38070700005)(38100700002)(316002)(71200400001)(6512007)(558084003)(6486002)(508600001)(26005)(2906002)(5660300002)(186003)(6506007)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <151819EC70C86441B2F55C7D2771F8A0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2520 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c00981b7-588b-4df1-76f5-08da327d27ff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +xKDsXBq746OsZDOdofZPpzHjCpt7Kx0Pf8rkLHkHXLZ0tPz5iJREJtRh5jYi/trmbFMisfZexRW2NUlfCD8gLAN7g1lwKjukBtMru264SzZ6NQBkglC3owNh76RE5CSa3dtgCu6DZmazzPovpKrxDio8SL8xEyCybm1VB3pp4ETd6hnyI5xsvccbU10eyiRrdx0T+E84FXsra5W92Dn67qE1ZintNCeE+54Xm+rAV0GTIzo6w+ZmZSz06UGdQgayfOIymK5Y1tbcYORIb+jkwPWTBq7xZBeoT1Aa1Vm6OFs100b63LoCDvCEwF9lLzfwgZVO5YajmJNrgr5KK464Xiob/VBQpBNGkbT74o9gKn5kmdu1fV8Q0uO1BUxjqY4sdMtLIofATQ6PwnbCp8w8awK4C2YQoUYVHDthz83LBHwWToSZrgpD2uAY70VcDBzdRDyo7ZZyxODef8oc1Rs782YvO4h+gh0Tmq/fjRAefkejjs+PZWDft8+BK3rjY1n5BIY2xbLZqqh0sLVViiZAFdZsSLHm1tNyXdqdgIk/Ox0kKYUlIIYziT8jTph98tDrtC5lkUgtwTc7ip9g8DvKJ2GUPrWLFSAOzQieAjZC3DUi9pbuFBigXqRMlW8YVikIvTqGI9p6zB7C5MRb5A8VSt2ghrdmpYkDpTiYwTBsvPZpL4ovlr8X2i/8CEBk5J0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(5660300002)(356005)(508600001)(8936002)(86362001)(6486002)(53546011)(316002)(6506007)(70586007)(70206006)(54906003)(81166007)(4326008)(8676002)(6862004)(36860700001)(33656002)(186003)(36756003)(47076005)(82310400005)(40460700003)(336012)(2616005)(2906002)(6512007)(26005)(4744005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 12:04:02.7935 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd90788-b4b5-4f29-c3c1-08da327d2cb2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4903 Hi, > On 9 May 2022, at 21:50, Stefano Stabellini wrot= e: >=20 > On Wed, 4 May 2022, Rahul Singh wrote: >> This patch introduces a new feature to support the signaling between >> two domains in dom0less system. >>=20 >> Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 10 12:04:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:04:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325549.548169 (Exim 4.92) (envelope-from ) id 1noOb5-0000Cg-ST; Tue, 10 May 2022 12:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325549.548169; Tue, 10 May 2022 12:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb5-0000BT-LB; Tue, 10 May 2022 12:04:11 +0000 Received: by outflank-mailman (input) for mailman id 325549; Tue, 10 May 2022 12:04:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb4-00008k-DG; Tue, 10 May 2022 12:04:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb4-0004rU-Aq; Tue, 10 May 2022 12:04:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOb3-0005kl-Qt; Tue, 10 May 2022 12:04:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noOb3-0004fD-QP; Tue, 10 May 2022 12:04:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YD3kKs+yL74jpuUlufztEi3aYbimXMyxBBFOjSJq/+g=; b=vGN2WbevTSGhQXbcUrF17XEnHE Qt4MxBLmf/QzgdAL6UWuTwRMFuVfBloj2o0omW8LSrfRnnwXql+jejcUyz7fnD19Jofzur1rT2AOJ aBfRnC4XNtG++7bU74ycgAbx5/9e2ZQOfE9nHohH5waARTR/zdmUTOdWo637Vvnqjbmg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170286: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab X-Osstest-Versions-That: qemuu=7e314198157bf38ae7fdd5a000b8795db015d582 From: osstest service owner Date: Tue, 10 May 2022 12:04:09 +0000 flight 170286 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170286/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170275 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170275 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170275 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170275 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170275 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170275 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170275 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170275 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab baseline version: qemuu 7e314198157bf38ae7fdd5a000b8795db015d582 Last test of basis 170275 2022-05-09 17:08:38 Z 0 days Testing same since 170286 2022-05-10 02:27:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gavin Shan Igor Mammedov Leif Lindholm Markus Armbruster Michael S. Tsirkin Nicolas Saenz Julienne Nir Soffer Peter Maydell Richard Henderson Stefan Hajnoczi Yanan Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7e31419815..178bacb66d 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 10 12:05:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325563.548183 (Exim 4.92) (envelope-from ) id 1noOcS-0001L1-AK; Tue, 10 May 2022 12:05:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325563.548183; Tue, 10 May 2022 12:05:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOcS-0001Ku-7X; Tue, 10 May 2022 12:05:36 +0000 Received: by outflank-mailman (input) for mailman id 325563; Tue, 10 May 2022 12:05:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOcR-0001Ki-Ff; Tue, 10 May 2022 12:05:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOcR-0004uW-Cm; Tue, 10 May 2022 12:05:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOcQ-0005ns-Vv; Tue, 10 May 2022 12:05:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noOcQ-0006hK-VU; Tue, 10 May 2022 12:05:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7YZE/IR+JGCYBh3IDPivO+Auef1WnZBIMvF6eWCiDvY=; b=FI3X1u96y6m3MKYaxL+ezBERvv NyByVDSnK3FitSRiJl2VpIKVPIGlG5qGZ1HX6qzprDHV3V1vfNgrXVkJ8AHTH2OcknP3f8FxJV8yq WFrHRXzpn7r5olgwViX/+BzwAwgjbQ/BYDunz9kgVccBMPbgqPiv7AQfY1UXW7gEujic=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170296: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 12:05:34 +0000 flight 170296 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170296/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 912 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 12:10:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:10:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325571.548195 (Exim 4.92) (envelope-from ) id 1noOhH-0002nQ-SI; Tue, 10 May 2022 12:10:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325571.548195; Tue, 10 May 2022 12:10:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOhH-0002nJ-OF; Tue, 10 May 2022 12:10:35 +0000 Received: by outflank-mailman (input) for mailman id 325571; Tue, 10 May 2022 12:10:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOhG-0002nD-4r for xen-devel@lists.xenproject.org; Tue, 10 May 2022 12:10:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f7dda66-d05a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 14:10:31 +0200 (CEST) Received: from mail-mw2nam08lp2177.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 08:10:28 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by DM5PR03MB3115.namprd03.prod.outlook.com (2603:10b6:4:40::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Tue, 10 May 2022 12:10:26 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::6821:288d:5d32:98e7]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::6821:288d:5d32:98e7%7]) with mapi id 15.20.5206.027; Tue, 10 May 2022 12:10:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f7dda66-d05a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652184631; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=bpdndaNXXSm1m9Cwda7xV13DUgIUQRz8cTzD5WdQI8s=; b=JASDHEiymKf/P8h+nMe6/eohRHAcwoMP12qMonilSG2xZL3GqMS1QJ6H PpvNqqK0pJgqk+S2uqUks+ds5tU4eHb2X29EQTuI3VcCn/6X7mwPW6/Hd AzOUOj9MqsxyhPblASFETAWqC9bFs9h1zp/ZGRNmCAdbDm27We8sgWv5c c=; X-IronPort-RemoteIP: 104.47.73.177 X-IronPort-MID: 71373732 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:AaKl/KjOypke1SvRwQtLkLNWX161qBEKZh0ujC45NGQN5FlHY01je htvUD3VOayIMzP1fIwlbIq0o0pQvZKGxtEySVE9rytgEiMb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrV4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQd4Z53W3+00aTJjTHh9Lath4ZbpHmfq5KR/z2WeG5ft69NHKRlqeKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQehWhv7ixNNa+2i 84xbTtpKhDBfjVEO0sNCYJ4l+Ct7pX6W2IB8w3O+vFti4TV5F1Q4J/yYeuOQMPJZdh0s2iR5 UvMzU2sV3n2M/Tak1Jp6EmEhPLLnC79cJIfEvu/7PECqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL86QuDGnINSDIHbdU8rdI3XhQjz FrPlNTsbRRRt7mSRWOY562jhzq4MigILkcPfSYBCwAC5rHLoos+kxbORdZLC7Oug5v+HjSY6 y+OhDgzgfMUl8Fj6kmg1VXOgjbpo4eTSAcwvlXTRjj8sVw/Y5O5bYu171Sd9exHMIuSUliGu j4DhtSa6+cNS5qKkURhXdkwIV1g3N7dWBW0vLKlN8BJG+iFk5J7Qb1t3Q== IronPort-HdrOrdr: A9a23:UcR9cK+ELgkxq9lSyR1uk+Ftdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3vDRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw1RgVyuK4IC2CrHDE10bKUNRj/EB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK 1rANvH7PhbfFuGZzSB11Mfi+CETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76 DPM7hulrtJUsgKBJgNTNspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCeg1JVsJ6e H8uX9jxB8PkhjVeLOzNbVwg2DwaXT4WyjxwcdD4JU8sqHgRdPQQF++dGw= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208,217";a="71373732" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=juRWu/OIiMwGb2kOYrN/OSp0qwuFFDZuF6y6uQQCFT/SBDRJaD0jeuyXs1UpP8lM38m2FXFxO7JQd/Q0gBCueXLTfnsnecYC6x1KYpAPiXgGqtvZzp6XhoG+Rt7nBPmIU4sEHBNNAjVHHX5Ypsmb7Xvr3QMJoajkOQFO830IEdoySoAe5RYpvbM/xNMlTMwyT6HfaGUN6tY3a+F5ENie2unngjpS6n0y/wjgLTDTdIEOwh77iBT3kbkPFrqqrtS7RVXn4Q5qds4vzw5PvspuKBjCbHBLbgfJ22LJgcHtUwl0QfAFXJSRBO1GyVi7ki0VQzN/QR8VNrSLSvqxJ43urg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PFKuD9etltBqEaM+5XMhtGOpO/FTPxSZggd8NgZ9YC8=; b=ZE61uJIRHrvuhBGpVdEE7zr1JKeCoUGwt/0HLzQ9EP2OnP/HuAtWfJG1wB4cV2ri1Ckn8xu2wz8jp3wEyPwARjoUqdRbQ87W2leaDPnaG0GQaVHHjYBU0UVQGPRSdLhQkg1gEmEl9IQcd63AqFNdV/NOTqihbbaFBfNQQSUS6KI2LIv5E8XhN5nwYZ2SAyZVG6BpcbEpJ8Axv12CTyr02SexiQFKWd1rNKdFF7I7YRrQN0ZDjQQOOeHpCzHKPE8txSH+v7a4y+mEl7Os1nlPY5MgjuvJITr4rQBgfMNsoEnV6/HFpIA2nqmcR9ohA/X968rdwlk746Rac+zy0UfuIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PFKuD9etltBqEaM+5XMhtGOpO/FTPxSZggd8NgZ9YC8=; b=KrPYy1qRFrjZ+w5x/7QwRBX2moDBIR1XX3OND8amKb82Y07BcXq3+KZumfF78+0WfAvH5tqmIMOO5ECaauK9oHpjO+8i6Icb3oEpsIQXJNz1OokaM/gPEP+PYCxoRytoXWDg8Fa4Fq3YLSHvvf83xVeWOfjFeLw2d0mxHrUZf/k= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Roger Pau Monne Subject: Re: [PATCH v3 1/6] xen: implement byteswap Thread-Topic: [PATCH v3 1/6] xen: implement byteswap Thread-Index: AQHYZFb0Ik5G7uZNNE+lQn3ZaONJQ60X9FWAgAAQFI4= Date: Tue, 10 May 2022 12:10:26 +0000 Message-ID: References: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> <11269227-ba07-b2b1-c2ef-ea6309980f67@xen.org> In-Reply-To: <11269227-ba07-b2b1-c2ef-ea6309980f67@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a5c6abe2-8cff-4b21-fbc6-08da327e1154 x-ms-traffictypediagnostic: DM5PR03MB3115:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2ohLYqYNihmOc8Jz9TWQ+sbJhMIptKYOqdSsJunq61FGgJF2WYFwxaPNKqLF7PCgJz/nUnXEn+pJ/s0/SxU2L693onIoGSZLbqfSSdiTicFPbIFv1oeHaCM2/PPv8gAWJS0OEuW+fIj/6qfqa6D7u0095xu0XMzVd+7sm35AV13QBOec3y0xeXJRSfOA+YH+7pgshehBmgYiGPDQ89suY1XIH2+KMlbcsqqtA9/arsCso17rq1pbMhSidETyhwylNv/MsIsWfRiugK6sWD1zY5hbNYO9wsFs3C4Wa54XweTLm8jj+MRcxdjUKNhFOm0AnfZbHnRNp5WP4ao6eucjSpi5+vtkKHKVJq84qLJtTWLjRulKp6i9Z7OUXDlaFprm89X4AXwnbyYDcyPla+a49QY4U0+2Z3KAoxWWHP+/Ger0BP6dp6S8pCKTuoAMyHjnTkGSf64iUjMTwa2ICkvL5zG/qh13o/nOIhFydurHyp5xbMjvnITsFvSBlEJlk0U/OFBiMW3L0C25eggfm5EUuPML0qC9r9Ht6cKjZW+sVw3LQeW4Lgr2fpqKbMmSQNSbuPlIZUh0z1YjHjnWLoy7G0WJH864xGeGN1H8nbBfmwaLZ9heAunrbdbEejUN5LJ1kHRbatq+7eemZmkHJtT3Y3DGOXgX+yvgbXPDci2g//S7If8/S9Riz9CFDzyhbkySwkCZShXAW3nMQIJnO0/rtVuGcVNkMXKeia3aBglaEGDwC2nnb90fJwnSNscGk0zPq8jfTME1dn3uCKQ89McokDdxL8d0FIUoJGlCrwV8WVk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(38100700002)(2906002)(76116006)(91956017)(8676002)(66556008)(5660300002)(55016003)(33656002)(85182001)(186003)(83380400001)(966005)(52536014)(110136005)(8936002)(316002)(64756008)(66446008)(4326008)(66476007)(107886003)(54906003)(66946007)(86362001)(38070700005)(26005)(166002)(7696005)(71200400001)(122000001)(9686003)(45080400002)(6506007)(82960400001)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?SlFIcDdIMW51QzZDUEs1RWd3eDlnM0JtM1ovdm9BNXVmYXZhM3hoQis4Uk1m?= =?gb2312?B?T2I2M2JUZWtjOUZaNUFoWlZuWldFSHFtb1dtWk8xRmV5dEN0RXN5UlozTmN5?= =?gb2312?B?Z1N2MGw3RnFFdnVNZXE3OWhHTGo5NXA2NkZkY2FsS2tQdVIvQWtKOUMzdENl?= =?gb2312?B?OWZsYndlcFRCeWxnZXRaNi9MbFBYZGhlTkViYzQ3bWh3QVpvZ3FZejhadUpE?= =?gb2312?B?UzJmWDZqK0ROeUlQaWJudzB3Zk9NcGxQaUR0Tm52KzgrK0xLbUxndkUzVlFz?= =?gb2312?B?aDUyYi9jdFR3T3BRU1lmRUdWUGNTRDl5YjBLTlhlVld6ejlSb3o0MzhoYmtG?= =?gb2312?B?ZXl2YkE1K29ld0xuNlo2cXpoKzZVaGFDbmhvSGFoc1hUbnJoRTNuWU00ZVpV?= =?gb2312?B?UEd6MHBvSTdBd2tMSTJSbStFY2VCc2JWNGd6Z296L0IxRGVtLytEVzJiYjdO?= =?gb2312?B?WkVGeGlIcGRpWnVrSk5YdnhZTUpkZGh2K3JVUjNwQlp1VTBOTkRISmpkcHNr?= =?gb2312?B?OW52SHpZZGEva2F4L3Nmbk9mMzVFRy9QemE2T3BaSTdJa3NERncvVDcrb3Rr?= =?gb2312?B?UWJNTm1wdTNPZFFZNTV6WXR6MXI1c3BKckd1NlBYVjlFUjI5L3kwalV3QSti?= =?gb2312?B?eVU4eEFiT0lpWDIxVDhGcnp0S0QzSm4yd2czRlhINWRDNnMvMWhUMkt5Ylg4?= =?gb2312?B?dys5aERhUEp2TytWUVBWSHZ3Z0grVDNXVEpGc1RIK3FrV01BWkZseU5HVnVk?= =?gb2312?B?T0xrbHR6Zm5tTmdHRzFiMGZqMmFsRjk1ekFPTUR3TkZGK3lZS1JzeGprR1lz?= =?gb2312?B?ajdwYWMyOTRHbXBOeE5wcFdYbTJQWUZ2WmFBWW00Wm5iSFoyRHhERjE1b3No?= =?gb2312?B?aDU5SU5lVmFzR1BpeHIwU0V2cStpNlc3WGNpdXpTb3ZCcGUwdEhRbXBQWlFw?= =?gb2312?B?SVU3NVFjUTZ0eGw1U2VPY01BVDJCSXRGbWc3NzdlQlRYWnIxMHdITFd1U1ZH?= =?gb2312?B?Wk9yQXlQM1Nlb1NqakRqcHpvdmcwQnBzNDAvMSs5cWRwZ2c3NkhYdzI2QThV?= =?gb2312?B?VFVjZVJEek4xUVdHSHNuaExQZEtJZ3FyUGw4MTBIeDVKQlEybU5XMlliNk1k?= =?gb2312?B?cDB3b1Q4cHVKeVN6RzZhSld4MmFMend1aUNXcWtZbStuL3k1MEJjQUhXditw?= =?gb2312?B?Vkt6dzBMd1pzVGFJcTBiNGRJRFM4MUZ4Mk9MTGJFZWxlNFhQOFcyZ3JDZVds?= =?gb2312?B?dGxOSFdPK3lZMmF3Ums1VENIaUYxam8rak1KKzQ4QjVyZGNDeGVxVzVWQXg2?= =?gb2312?B?aTMwbFRBVWxjMURkdi8vSncxc2hpTkZCdEtIL2xEeStMcjlpMzV2ckZRdHFr?= =?gb2312?B?MzRFVWdoeDk3bkYyK3JjYnZuRHdSbkNoVENYSVh6Q3g0dnh3WEZieTFDL0FU?= =?gb2312?B?Yk15Tkx2TVc4dDZMM1BLNGtXYnpNM1ZiTHI3THR4b1lONzNlNVFMYnhOLzBY?= =?gb2312?B?YWJNRERSMmIybGRiMWpTN0lWTVJ3ekE1c2RsNFJuNU9WRFRWUS9zN250WENW?= =?gb2312?B?T0lnTHJXUDYzcTQ3STVndTBFUm9Gc01BUDF0c1hBSW82NjZubTF3WUIxYnF4?= =?gb2312?B?N0JnZnVlbWZ4SS9lcldicHJVa2Rsckx1ZXhWYnM4YjhLbk12QjN0NFFJVUN3?= =?gb2312?B?cWxPZDBKejQxeHFNU0hMekNIMjVkTzJkNnZRRTRJOXpmeU5qdDFRUWgrdDQ5?= =?gb2312?B?WkVOWVpEb3lSL08wN1RVd21ieG5VWlRUSThJdEJpYzh1UWV0R3RMNXR0VVVT?= =?gb2312?B?LytuVU5ZVVNzbmlVMm9Lb2NHRGN0U1FRa01VUjJsaFl6ZWV1MStXUHlxR1E0?= =?gb2312?B?eitOVVVjVWRScVRSU1JOMWZXcG8vMFd1bDZ0RjV5U3h5aU15QWl6R0VDNFk1?= =?gb2312?B?MmN4V0F2N29mTnlFc2NqS2pZdXF0OVBYWU53ZnZOY2FDUFlOQyszUmoyaXly?= =?gb2312?B?VHdDb3dsRTVlSzk3cXJvOW15U2REeThXL1cwaHZqZkd4bDZVbUZYRTVMY1Ew?= =?gb2312?B?THBuYzJZSkUreTVacFhHQ3Jhdnh2dTRSa3ZnMVRGMjZiS2ZjUGJkWkc3WDFy?= =?gb2312?B?ME5IVUFGVGhzWXZzUXN5WWhzMkpRR2locGxLME1lRkdDU3BMQVhCOU0zQzB0?= =?gb2312?B?ZEpmYVZ5eDI2c1QvVi9Ya1ZOZFpZbDhZb2tQUjBKRG5VKzRqa2p3V25aNzdw?= =?gb2312?B?Z2FKb3h6YnAxbTE5WWVFVE56VmdNTzVYd0RMekhYWnRIWldCdnpqOEhZcSts?= =?gb2312?B?L3dKMDhWOVZPVmticGcyR2Z0aGFkcXR1NTNtRkw5b1cvRWJTbHk5S1llYkZz?= =?gb2312?Q?T23aih4JvYjR9lsQ=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB540509C0FCD040A3680DE3799DC99SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5c6abe2-8cff-4b21-fbc6-08da327e1154 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 12:10:26.3928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D/VC5FPmAs/AUy97W99yUbc4rdK8g0Qf+LYrhO8lzbpL5LMQ1gVfYjqUVEhZfu9UWYarZWla/hqUuT6/0QZ+cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3115 --_000_SJ0PR03MB540509C0FCD040A3680DE3799DC99SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SGksDQoNCk9uIDEwLzA1LzIwMjIgMTE6MTUsIExpbiBMaXUgd3JvdGU6DQo+IHN3YWIoKSBpcyBt YXNzaXZlbHkgb3ZlciBjb21wbGljYXRlZCBhbmQgY2FuIGJlIHNpbXBsaWZpZWQgYnkgYnVpbHRp bnMuDQoNCk5JVDogImJ5IGJ1aWx0aW5zIiAtPiAiYnkgcmUtaW1wbGVtZW50aW5nIHVzaW5nIGNv bXBpbGVyIGJ1aWx0aW5zIi4NCg0KPiBUaGUgY29tcGlsZXJzIHByb3ZpZGUgYnVpbHRpbiBmdW5j dGlvbiB0byBzd2FwIGJ5dGVzLg0KPiAqIGdjYzogICBodHRwczovL25hbTA0LnNhZmVsaW5rcy5w cm90ZWN0aW9uLm91dGxvb2suY29tLz91cmw9aHR0cHMlM0ElMkYlMkZnY2MuZ251Lm9yZyUyRm9u bGluZWRvY3MlMkZnY2MlMkZPdGhlci1CdWlsdGlucy5odG1sJmFtcDtkYXRhPTA1JTdDMDElN0Ns aW4ubGl1JTQwY2l0cml4LmNvbSU3Q2UwYjNkOThkN2Y4ZDQ3YjhmZTg3MDhkYTMyNzVhZmNkJTdD MzM1ODM2ZGU0MmVmNDNhMmIxNDUzNDhjMmVlOWNhNWIlN0MwJTdDMCU3QzYzNzg3Nzc3ODI5NDA2 NzkxMSU3Q1Vua25vd24lN0NUV0ZwYkdac2IzZDhleUpXSWpvaU1DNHdMakF3TURBaUxDSlFJam9p VjJsdU16SWlMQ0pCVGlJNklrMWhhV3dpTENKWFZDSTZNbjAlM0QlN0MzMDAwJTdDJTdDJTdDJmFt cDtzZGF0YT1IRFRGMUxESmNEMlBMU0N1TSUyRmpJeiUyRldHZjFDcllrMGUlMkZMb3gyMiUyRlhu dlElM0QmYW1wO3Jlc2VydmVkPTANCj4gKiBjbGFuZzogaHR0cHM6Ly9uYW0wNC5zYWZlbGlua3Mu cHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBzJTNBJTJGJTJGY2xhbmcubGx2bS5vcmcl MkZkb2NzJTJGTGFuZ3VhZ2VFeHRlbnNpb25zLmh0bWwmYW1wO2RhdGE9MDUlN0MwMSU3Q2xpbi5s aXUlNDBjaXRyaXguY29tJTdDZTBiM2Q5OGQ3ZjhkNDdiOGZlODcwOGRhMzI3NWFmY2QlN0MzMzU4 MzZkZTQyZWY0M2EyYjE0NTM0OGMyZWU5Y2E1YiU3QzAlN0MwJTdDNjM3ODc3Nzc4Mjk0MDY3OTEx JTdDVW5rbm93biU3Q1RXRnBiR1pzYjNkOGV5SldJam9pTUM0d0xqQXdNREFpTENKUUlqb2lWMmx1 TXpJaUxDSkJUaUk2SWsxaGFXd2lMQ0pYVkNJNk1uMCUzRCU3QzMwMDAlN0MlN0MlN0MmYW1wO3Nk YXRhPUV2V2NMTWkydnRUOWhhUVZvJTJGOXVYbWpCaDJ6VkxVelpBZ1U1N2klMkZGTU5vJTNEJmFt cDtyZXNlcnZlZD0wDQo+IFRoaXMgcGF0Y2ggc2ltcGxpZnkgc3dhYigpIHdpdGggYnVpbHRpbnMg YW5kIGZhbGxiYWNrIGZvciBvbGQgY29tcGlsZXJzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBMaW4g TGl1IDxsaW4ubGl1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBDYzogU3RlZmFubyBTdGFiZWxsaW5p IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4NCj4gQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4N Cj4gQ2M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4g Q2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IENjOiBHZW9y Z2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+DQo+IENjOiBKYW4gQmV1bGljaCA8 amJldWxpY2hAc3VzZS5jb20+DQo+IENjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBDYzogIlJv Z2VyIFBhdSBNb25uqKYiIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gQ2hhbmdlcyBpbiB2MzoN Cj4gLSBDaGVjayBfX2hhc19idWlsdGluIGluc3RlYWQgb2YgR05VQyB2ZXJzaW9uDQo+DQo+IENo YW5nZXMgaW4gdjI6DQo+IC0gQWRkIGZhbGxiYWNrIGZvciBjb21waWxlcnMgd2l0aG91dCBfX2J1 aWx0aW5fYnN3YXANCj4gLSBJbXBsZW1lbnQgd2l0aCBwbGFpbiBDIGluc3RlYWQgb2YgbWFjcm9z DQo+IC0tLQ0KPiAgIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ieXRlb3JkZXIuaCB8IDE0ICsr LS0tLS0NCj4gICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vYnl0ZW9yZGVyLmggfCAzNCArKy0t LS0tLS0tLS0tLS0tLQ0KPiAgIHhlbi9pbmNsdWRlL3hlbi9ieXRlb3JkZXIuaCAgICAgICAgICB8 IDU2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gICB4ZW4vaW5jbHVkZS94ZW4vYnl0 ZXN3YXAuaCAgICAgICAgICAgfCA0NCArKysrKysrKysrKysrKysrKysrKysrDQo+ICAgeGVuL2lu Y2x1ZGUveGVuL2NvbXBpbGVyLmggICAgICAgICAgIHwgMTIgKysrKysrDQo+ICAgNSBmaWxlcyBj aGFuZ2VkLCAxMjAgaW5zZXJ0aW9ucygrKSwgNDAgZGVsZXRpb25zKC0pDQo+ICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IHhlbi9pbmNsdWRlL3hlbi9ieXRlb3JkZXIuaA0KPiAgIGNyZWF0ZSBtb2RlIDEw MDY0NCB4ZW4vaW5jbHVkZS94ZW4vYnl0ZXN3YXAuaA0KPg0KPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gvYXJtL2luY2x1ZGUvYXNtL2J5dGVvcmRlci5oIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2J5dGVvcmRlci5oDQo+IGluZGV4IDljNzEyYzQ3ODguLjYyMmVlYWJhMDcgMTAwNjQ0DQo+IC0t LSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9ieXRlb3JkZXIuaA0KPiArKysgYi94ZW4vYXJj aC9hcm0vaW5jbHVkZS9hc20vYnl0ZW9yZGVyLmgNCj4gQEAgLTEsMTYgKzEsMTAgQEANCj4gICAj aWZuZGVmIF9fQVNNX0FSTV9CWVRFT1JERVJfSF9fDQo+ICAgI2RlZmluZSBfX0FTTV9BUk1fQllU RU9SREVSX0hfXw0KPg0KPiAtI2RlZmluZSBfX0JZVEVPUkRFUl9IQVNfVTY0X18NCj4gKyNpZm5k ZWYgX19CWVRFX09SREVSX18NCj4gKyAgICNkZWZpbmUgX19CWVRFX09SREVSX18gX19PUkRFUl9M SVRUTEVfRU5ESUFOX18NCj4gKyNlbmRpZg0KPg0KPiAtI2luY2x1ZGUgPHhlbi9ieXRlb3JkZXIv bGl0dGxlX2VuZGlhbi5oPg0KPiArI2luY2x1ZGUgPHhlbi9ieXRlb3JkZXIuaD4NCj4NCj4gICAj ZW5kaWYgLyogX19BU01fQVJNX0JZVEVPUkRFUl9IX18gKi8NCj4gLS8qDQo+IC0gKiBMb2NhbCB2 YXJpYWJsZXM6DQo+IC0gKiBtb2RlOiBDDQo+IC0gKiBjLWZpbGUtc3R5bGU6ICJCU0QiDQo+IC0g KiBjLWJhc2ljLW9mZnNldDogNA0KPiAtICogaW5kZW50LXRhYnMtbW9kZTogbmlsDQo+IC0gKiBF bmQ6DQo+IC0gKi8NCg0KPj4gVGhpcyBjaGFuZ2UgbG9va3MgdW5yZWxhdGVkIHRvIHRoaXMgcGF0 Y2guIENhbiB5b3UgZXhwbGFpbiBpdD8NCg0KRG8geW91IG1lYW4gZm9sbG93aW5nIGNvZGUgYmxv Y2s/IFllcywgaXQgaXMgdW5yZWxhdGVkLCBJIHJlbW92ZWQgaXQgYXMgSSBmb3VuZCBzb21lIGZp bGVzIGRvZXMgbm90IGluY2x1ZGUgc3VjaCBmaWVsZC4NCldpbGwgcmV2ZXJ0IHN1Y2ggZmllbGQg aW4gVjQuDQo+IC0vKg0KPiAtICogTG9jYWwgdmFyaWFibGVzOg0KPiAtICogbW9kZTogQw0KPiAt ICogYy1maWxlLXN0eWxlOiAiQlNEIg0KPiAtICogYy1iYXNpYy1vZmZzZXQ6IDQNCj4gLSAqIGlu ZGVudC10YWJzLW1vZGU6IG5pbA0KPiAtICogRW5kOg0KPiAtICovDQo= --_000_SJ0PR03MB540509C0FCD040A3680DE3799DC99SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Hi,

On 10/05/2022 11:15, Lin Liu wrote:
> swab() is massively over complicated and can be simplified by builtins= .

NIT: "by builtins" -> "by re-implementing using compiler = builtins".

> The compilers provide builtin function to swap bytes.
> * gcc:   https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgcc.gnu= .org%2Fonlinedocs%2Fgcc%2FOther-Builtins.html&amp;data=3D05%7C01%7Clin.= liu%40citrix.com%7Ce0b3d98d7f8d47b8fe8708da3275afcd%7C335836de42ef43a2b1453= 48c2ee9ca5b%7C0%7C0%7C637877778294067911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC= 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&am= p;amp;sdata=3DHDTF1LDJcD2PLSCuM%2FjIz%2FWGf1CrYk0e%2FLox22%2FXnvQ%3D&am= p;reserved=3D0
> * clang: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fclang.l= lvm.org%2Fdocs%2FLanguageExtensions.html&amp;data=3D05%7C01%7Clin.liu%4= 0citrix.com%7Ce0b3d98d7f8d47b8fe8708da3275afcd%7C335836de42ef43a2b145348c2e= e9ca5b%7C0%7C0%7C637877778294067911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA= wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp= ;sdata=3DEvWcLMi2vtT9haQVo%2F9uXmjBh2zVLUzZAgU57i%2FFMNo%3D&amp;reserve= d=3D0
> This patch simplify swab() with builtins and fallback for old compiler= s.
>
> Signed-off-by: Lin Liu <lin.liu@citrix.com>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Bertrand Marquis <bertrand.marquis@arm.com>
> Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Wei Liu <wl@xen.org>
> Cc: "Roger Pau Monn=A8=A6" <roger.pau@citrix.com>
> Changes in v3:
> - Check __has_builtin instead of GNUC version
>
> Changes in v2:
> - Add fallback for compilers without __builtin_bswap
> - Implement with plain C instead of macros
> ---
>   xen/arch/arm/include/asm/byteorder.h | 14 ++-----
>   xen/arch/x86/include/asm/byteorder.h | 34 ++--------------= -
>   xen/include/xen/byteorder.h     &= nbsp;    | 56 ++++++++++++++++++++++++++++
>   xen/include/xen/byteswap.h     &n= bsp;     | 44 ++++++++++++++++++++++
>   xen/include/xen/compiler.h     &n= bsp;     | 12 ++++++
>   5 files changed, 120 insertions(+), 40 deletions(-)
>   create mode 100644 xen/include/xen/byteorder.h
>   create mode 100644 xen/include/xen/byteswap.h
>
> diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/inclu= de/asm/byteorder.h
> index 9c712c4788..622eeaba07 100644
> --- a/xen/arch/arm/include/asm/byteorder.h
> +++ b/xen/arch/arm/include/asm/byteorder.h
> @@ -1,16 +1,10 @@
>   #ifndef __ASM_ARM_BYTEORDER_H__
>   #define __ASM_ARM_BYTEORDER_H__
>  
> -#define __BYTEORDER_HAS_U64__
> +#ifndef __BYTE_ORDER__
> +   #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
> +#endif
>  
> -#include <xen/byteorder/little_endian.h>
> +#include <xen/byteorder.h>
>  
>   #endif /* __ASM_ARM_BYTEORDER_H__ */
> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */

>> This change looks unrelated to this patch. Can= you explain it?

Do y= ou mean following code block? Yes, it is unrelated, I removed it as I found= some files does not include such field.

Will= revert such field in V4.

> -/*
> - * Local variables:
> - * mode: C
> - * c-file-style: "BSD"
> - * c-basic-offset: 4
> - * indent-tabs-mode: nil
> - * End:
> - */=

--_000_SJ0PR03MB540509C0FCD040A3680DE3799DC99SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 10 12:14:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:14:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325579.548206 (Exim 4.92) (envelope-from ) id 1noOkw-0003is-FN; Tue, 10 May 2022 12:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325579.548206; Tue, 10 May 2022 12:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOkw-0003il-BX; Tue, 10 May 2022 12:14:22 +0000 Received: by outflank-mailman (input) for mailman id 325579; Tue, 10 May 2022 12:14:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noOkv-0003if-8Y for xen-devel@lists.xenproject.org; Tue, 10 May 2022 12:14:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b81388ee-d05a-11ec-a406-831a346695d4; Tue, 10 May 2022 14:14:19 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 671FF1F8B8; Tue, 10 May 2022 12:14:19 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 552522C141; Tue, 10 May 2022 12:14:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b81388ee-d05a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652184859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z0qCXGbgchboCgbitrJZObbFnXC/YqP7fhEXmnIw2vY=; b=OcxDFXmKKoVdDJUxSKREkD35h3cfh7L/UHzdGP/cbflejeipwrciY4AbOjnQu6DKNCs7aq Tea2QFXBj209QcyaHp7BuefH2IIusivsxr3vlgfi6p9lZaMFpVOppWn8lIP/+rweBZrcrm +Lwt8IUC7jK6VwI0ouYkElgPt01wPwE= Date: Tue, 10 May 2022 14:14:16 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Christophe JAILLET , Mihai Carabas , Shile Zhang , Wang ShaoBo , zhenwei pi Subject: Re: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-6-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-6-gpiccoli@igalia.com> On Wed 2022-04-27 19:48:59, Guilherme G. Piccoli wrote: > The pvpanic driver relies on panic notifiers to execute a callback > on panic event. Such function is executed in atomic context - the > panic function disables local IRQs, preemption and all other CPUs > that aren't running the panic code. > > With that said, it's dangerous to use regular spinlocks in such path, > as introduced by commit b3c0f8774668 ("misc/pvpanic: probe multiple instances"). > This patch fixes that by replacing regular spinlocks with the trylock > safer approach. It seems that the lock is used just to manipulating a list. A super safe solution would be to use the rcu API: rcu_add_rcu() and list_del_rcu() under rcu_read_lock(). The spin lock will not be needed and the list will always be valid. The advantage would be that it will always call members that were successfully added earlier. That said, I am not familiar with pvpanic and am not sure if it is worth it. > It also fixes an old comment (about a long gone framebuffer code) and > the notifier priority - we should execute hypervisor notifiers early, > deferring this way the panic action to the hypervisor, as expected by > the users that are setting up pvpanic. This should be done in a separate patch. It changes the behavior. Also there might be a discussion whether it really should be the maximal priority. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 12:33:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 12:33:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325585.548217 (Exim 4.92) (envelope-from ) id 1noP2z-0006J1-1T; Tue, 10 May 2022 12:33:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325585.548217; Tue, 10 May 2022 12:33:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noP2y-0006Iu-UX; Tue, 10 May 2022 12:33:00 +0000 Received: by outflank-mailman (input) for mailman id 325585; Tue, 10 May 2022 12:32:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noP2x-0006Io-8z for xen-devel@lists.xenproject.org; Tue, 10 May 2022 12:32:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noP2w-0005NB-Qo; Tue, 10 May 2022 12:32:58 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noP2w-0001bJ-KE; Tue, 10 May 2022 12:32:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7h7Yw7tNQ24qD99Cl5/gMsYGdW5f+JrvI7xCOVuYn8k=; b=L/vn6pIOURKWdXbOLcflQwvQCz dSR+s8RsiAdaKBpnfJW+uvXwNgbqyOBdZJJqCo0ZbcVPoLx6+psf37AAMTqJgzJDJjQiXtAUfAgZm s00Czo7swja3sQXczKJO6c71sA6k8m6s7BSX8gGErlps5NJqHqwfWM5xrNKfZ073Pqu0=; Message-ID: Date: Tue, 10 May 2022 13:32:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Rahul, On 04/05/2022 18:34, Rahul Singh wrote: > This patch introduces a new feature to support the signaling between > two domains in dom0less system. > > Signed-off-by: Rahul Singh > --- > v2 changes: > - switch to the one-subnode-per-evtchn under xen,domain" compatible node. > - Add more detail about event-channel > --- > docs/designs/dom0less-evtchn.md | 126 ++++++++++++++++++++++++++++++++ Answering here to also keep the history. On IRC, Bertrand was asking whether we merge design proposal. We have merged proposal in the past (e.g. non-cooperative migration) and I would be ready to do it again as it is easier to find them afterwards. However, I wonder whether it would be better to turn this proposal to a binding change in misc/arm/device-tree/. Any thoughts? > 1 file changed, 126 insertions(+) > create mode 100644 docs/designs/dom0less-evtchn.md > > diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md > new file mode 100644 > index 0000000000..62ec8a4009 > --- /dev/null > +++ b/docs/designs/dom0less-evtchn.md > @@ -0,0 +1,126 @@ > +# Signaling support between two domUs on dom0less system > + > +## Current state: Draft version > + > +## Proposer(s): Rahul Singh, Bertrand Marquis > + > +## Problem Statement: > + > +Dom0less guests would benefit from a statically-defined memory sharing and > +signally system for communication. One that would be immediately available at > +boot without any need for dynamic configurations. > + > +In embedded a great variety of guest operating system kernels exist, many of > +which don't have support for xenstore, grant table, or other complex drivers. I am not sure I would consider event channel FIFO a "trival" drivers :). > +Some of them are small kernel-space applications (often called "baremetal", > +not to be confused with the term "baremetal" used in the data center which > +means "without hypervisors") or RTOSes. Additionally, for safety reasons, users > +often need to be able to configure the full system statically so that it can > +be verified statically. > + > +Event channels are very simple and can be added even to baremetal applications. > +This proposal introduces a way to define them statically to make them suitable > +for dom0less embedded deployments. > + > +## Proposal: > + > +Event channels are the basic primitive provided by Xen for event notifications. > +An event channel is a logical connection between 2 domains (more specifically > +between dom1,port1, and dom2,port2). Each event has a pending and a masked bit. > +The pending bit indicates the event has been raised. The masked bit is used by > +the domain to prevent the delivery of that specific event. Xen only performs a > +0 → 1 transition on the pending bits and does not touch the mask bit. The NIT: I think → is not an ascii character. Can you use "->"? > +domain may toggle masked bits in the masked bit field and should clear the > +pending bit when an event has been processed > + > +Events are received by a domain via an interrupt from Xen to the domain, > +indicating when an event arrives (setting the bit). Further notifications are > +blocked until the bit is cleared again. Events are delivered asynchronously to > +a domain and are enqueued when the domain is not running. > +More information about FIFO based event channel can be found at: I think the explanation is fine for a design proposal. If you want to use it as documentation, then I would suggest to clarify there are two different ABI for event channel: FIFO and 2L. 2L is the easiest one to implement and for embedded we may want to steer the users towards it. > +https://xenbits.xen.org/people/dvrabel/event-channels-H.pdf It is quite unfortunate that this wasn't merged in docs/. Oh well, no action for you here. > + > +The event channel communication will be established statically between two > +domains (dom0 and domU also) before unpausing the domains after domain creation. > +Event channel connection information between domains will be passed to XEN via NIT: above you are using "Xen". So s/XEN/Xen/ for consistency. > +the device tree node. The event channel will be created and established > +beforehand in XEN before the domain started. The domain doesn’t need to do any Same here. NIT: I think "beforehand" and "before" is redundant. > +operation to establish a connection. Domain only needs hypercall > +EVTCHNOP_send(local port) to send notifications to the remote guest. > + > +There is no need to describe the static event channel info in the domU device > +tree. Static event channels are only useful in fully static configurations, > +and in those configurations the domU device tree dynamically generated by Xen > +is not needed. > + > +Under the "xen,domain" compatible node, there need to be sub-nodes with > +compatible "xen,evtchn" that describe the event channel connection between two > +domains(dom0 and domU also). Below you provided an example between two domUs. Can you provide one between dom0 and a domU? > + > +The event channel sub-node has the following properties: > + > +- compatible > + > + "xen,evtchn" > + > +- xen,evtchn > + > + The property is tuples of two numbers > + (local-evtchn link-to-foreign-evtchn) where: > + > + local-evtchn is an integer value that will be used to allocate local port > + for a domain to send and receive event notifications to/from the remote > + domain. Port 0 is reserved and both FIFO/2L have limit on the port numbers. I think we should let know the users about those limitations but I am not sure whether the binding is the right place for that. > + > + link-to-foreign-evtchn is a single phandle to a remote evtchn to which > + local-evtchn will be connected. I would consider to relax the wording so a user can create an event channel with the both end in the same domain. Implementation wise, it should make no difference as you still need to lookup the domain. > + > + > +Example: > + > + chosen { > + .... > + > + domU1: domU1 { > + compatible = "xen,domain"; > + > + /* one sub-node per local event channel */ > + ec1: evtchn@1 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xa &ec3>; > + }; > + > + ec2: evtchn@2 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xc &ec4>; > + }; > + .... > + }; > + > + domU2: domU2 { > + compatible = "xen,domain"; > + > + /* one sub-node per local event channel */ > + ec3: evtchn@3 { > + compatible = "xen,evtchn-v1"; > + /* local-evtchn link-to-foreign-evtchn */ > + xen,evtchn = <0xb &ec1>; > + }; > + > + ec4: evtchn@4 { > + compatible = "xen,evtchn-v1"; > + xen,evtchn = <0xd &ec2>; > + }; > + .... > + }; > + }; > + > +In above example two event channel comunication will be established between > +domU1 and domU2. > + > + domU1 (port 0xa) <-----------------> domU2 (port 0xb) > + domU1 (port 0xc) <-----------------> domU2 (port 0xd) > + > +domU1 and domU2 can send the signal to remote domain via hypercall > +EVTCHNOP_send(.) on local port. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 13:02:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:02:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325591.548228 (Exim 4.92) (envelope-from ) id 1noPVZ-00020P-CW; Tue, 10 May 2022 13:02:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325591.548228; Tue, 10 May 2022 13:02:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPVZ-00020I-8c; Tue, 10 May 2022 13:02:33 +0000 Received: by outflank-mailman (input) for mailman id 325591; Tue, 10 May 2022 13:02:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPVX-00020C-Dn for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:02:32 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7143e740-d061-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 15:02:28 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noPUd-0004lT-6O; Tue, 10 May 2022 15:01:35 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7143e740-d061-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JWyep5EFfEPXN0/UUFSWkvsTwBT4W/fOxchQHhKa4RM=; b=sx6DF8PoUIO1mHu5cZY1RxwoA9 niB1KysO8rrmF0zp8Z8GTN/NtCj2d4QR4yv3E2E5W17RExRi8A0KAmcw+03c1G1ooU/Pm21U+zIEh 0zp/hEbV2HUhNtVPnHFdp5DB6IlN6W8R3VOm7oythqBX2GRaLpOj+rJPIjIYg4FRTMuO76QGoLFC6 YTJOWt6WzTDBhnK8IJgaIHAnWrK2atb9lCglavMKbFL3MElzKi625NHcWNdIldxGBU96c/pM4S0g8 wJXsSSNXtcQC2Akbyu07xQvQmC9j0tVwKiovTIAilxmwfqg23OLqdBOLywiRmkuVFih5uNhaytVXp cz9YcgaQ==; Message-ID: <0a20dd06-f459-638e-cb4d-8255ab1a1f23@igalia.com> Date: Tue, 10 May 2022 10:00:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Christophe JAILLET , Mihai Carabas , Shile Zhang , Wang ShaoBo , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-6-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 09:14, Petr Mladek wrote: > [...] >> With that said, it's dangerous to use regular spinlocks in such path, >> as introduced by commit b3c0f8774668 ("misc/pvpanic: probe multiple instances"). >> This patch fixes that by replacing regular spinlocks with the trylock >> safer approach. > > It seems that the lock is used just to manipulating a list. A super > safe solution would be to use the rcu API: rcu_add_rcu() and > list_del_rcu() under rcu_read_lock(). The spin lock will not be > needed and the list will always be valid. > > The advantage would be that it will always call members that > were successfully added earlier. That said, I am not familiar > with pvpanic and am not sure if it is worth it. > >> It also fixes an old comment (about a long gone framebuffer code) and >> the notifier priority - we should execute hypervisor notifiers early, >> deferring this way the panic action to the hypervisor, as expected by >> the users that are setting up pvpanic. > > This should be done in a separate patch. It changes the behavior. > Also there might be a discussion whether it really should be > the maximal priority. > > Best Regards, > Petr Thanks for the review Petr. Patch was already merged - my goal was to be concise, i.e., a patch per driver / module, so the patch kinda fixes whatever I think is wrong with the driver with regards panic handling. Do you think it worth to remove this patch from Greg's branch just to split it in 2? Personally I think it's not worth, but opinions are welcome. About the RCU part, this one really could be a new patch, a good improvement patch - it makes sense to me, we can think about that after the fixes I guess. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 10 13:04:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:04:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325597.548239 (Exim 4.92) (envelope-from ) id 1noPXs-0002cD-PB; Tue, 10 May 2022 13:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325597.548239; Tue, 10 May 2022 13:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPXs-0002c6-M8; Tue, 10 May 2022 13:04:56 +0000 Received: by outflank-mailman (input) for mailman id 325597; Tue, 10 May 2022 13:04:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPXr-0002by-QP for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:04:55 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8eb3d91-d061-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 15:04:55 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noPXc-0005Ct-K8; Tue, 10 May 2022 15:04:40 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8eb3d91-d061-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ERCDIneY1Q4o8JFrn6huil0jOKhd5NF1nm9+poeBUGY=; b=C1bwe/Dp28hHJCcth6j9FIvLRX pDXbwTw3GNkAuVoDVZ2t1Ig0Ha8VAgFyN1qfYHmoUYQVyDRHd7IRdBkOHux1OzR9Q7hmNC/ZbkDNy i9N1ZP1KkXJYzqp8Xch5cykWJAl8GjhN23tq785F2kRMcqVY6TftmyHyPJZTtkL8PDJb7GYsR63+v CyHpUemygecHOqy6UnkI5sacYa9DSfBokIBgO1vbgxAO3Lo/ZpYDMcX65a4mJHituF1N7bEMHTqnl wjibh2hSmhpgeMzHripimwe7gT4RuGZfcia5HzNoWvLT/w9CiRN4l1p9e5qQ/+lp5TdT6UNVMzl77 9RtLUAvA==; Message-ID: Date: Tue, 10 May 2022 10:04:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Content-Language: en-US To: Petr Mladek , Evan Green Cc: Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 08:38, Petr Mladek wrote: > [...] > I see two more alternative solutions: > > 1st variant is a trick already used in console write() callbacks. > They do trylock() when oops_in_progress is set. They remember > the result to prevent double unlock when printing Oops messages and > the system will try to continue working. For example: > > pl011_console_write(struct console *co, const char *s, unsigned int count) > { > [...] > int locked = 1; > [...] > if (uap->port.sysrq) > locked = 0; > else if (oops_in_progress) > locked = spin_trylock(&uap->port.lock); > else > spin_lock(&uap->port.lock); > > [...] > > if (locked) > spin_unlock(&uap->port.lock); > } > > > 2nd variant is to check panic_cpu variable. It is used in printk.c. > We might move the function to panic.h: > > static bool panic_in_progress(void) > { > return unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID); > } > > and then do: > > if (panic_in_progress()) { > ... Thanks for the review Petr! I feel alternative two is way better, it checks for panic - the oops_in_progress isn't really enough, since we can call panic() directly, not necessarily through an oops path, correct? For me, we could stick with the lock check, but I'll defer to Evan - I didn't work the V2 patch yet, what do you prefer Evan? > [...] > As already mentioned in the other reply, panic() sometimes stops > the other CPUs using NMI, for example, see kdump_nmi_shootdown_cpus(). > > Another situation is when the CPU using the lock ends in some > infinite loop because something went wrong. The system is in > an unpredictable state during panic(). > > I am not sure if this is possible with the code under gsmi_dev.lock > but such things really happen during panic() in other subsystems. > Using trylock in the panic() code path is a good practice. > > Best Regards, > Petr Makes total sense, thanks for confirming! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 10 13:09:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:09:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325606.548250 (Exim 4.92) (envelope-from ) id 1noPca-0003Gu-Bp; Tue, 10 May 2022 13:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325606.548250; Tue, 10 May 2022 13:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPca-0003Gn-8K; Tue, 10 May 2022 13:09:48 +0000 Received: by outflank-mailman (input) for mailman id 325606; Tue, 10 May 2022 13:09:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPcY-0003GK-KK; Tue, 10 May 2022 13:09:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPcY-00060S-H7; Tue, 10 May 2022 13:09:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPcY-0007em-8Y; Tue, 10 May 2022 13:09:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noPcY-0000ad-88; Tue, 10 May 2022 13:09:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oBrLK0L38lck2oBT2rEnKCquhPo61nCZ27MiP/WUHWY=; b=b7t5I/GyZ1cgpTyIiYTc1JVORK WlrMN1BJ/3scd5MMBvcz7RXCOVmmPyY4ccl686wUboVdegSryLOOA1QpmHNvnqC8nt2qPuanqf79O Lo1JcW7DN6Q/AT9BXRZm9fpj4s5rD6iDVvkT5Vjxu3WsLAsZif0KfS6IxuJGo6XkPoKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170297: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 13:09:46 +0000 flight 170297 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170297/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 913 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 13:30:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:30:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325615.548260 (Exim 4.92) (envelope-from ) id 1noPwk-0006tY-7j; Tue, 10 May 2022 13:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325615.548260; Tue, 10 May 2022 13:30:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPwk-0006tR-4G; Tue, 10 May 2022 13:30:38 +0000 Received: by outflank-mailman (input) for mailman id 325615; Tue, 10 May 2022 13:30:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPwj-0006tL-1I for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:30:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e86351d-d065-11ec-a406-831a346695d4; Tue, 10 May 2022 15:30:35 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 09:30:31 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6437.namprd03.prod.outlook.com (2603:10b6:a03:398::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Tue, 10 May 2022 13:30:28 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 13:30:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e86351d-d065-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652189435; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=dr21bRf3x3WPOJUV3Hv7yosF59950Oq3PX0P99tY4gA=; b=GM5z5WgxgibhJE6bmnWA3RVGbFMa5UgEjSBzpoxdCXyDykhqZAljkVTm ad+4zzGQd+TF8cuDM8e8u+VLdbBTC1sYtpIvpB2LucH1+Jj21lrL1QcYc xjU2XpEOG9I2lrQYDpvx6T+x+pBvD1Yf/bA4QsCaYxhyJdu5f84hrD5b3 Y=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 70969237 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vroLtqmFDZVszNyeyM2lbYfo5gz3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXD2GOaa3famH1edxzO4uxpkgB7ZHTztFrG1E/qnsxESMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWlvV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYaVgmZqiUkfsnY0cDS3wvIpZrv7udGC3q2SCT5xWun3rE5dxLVRlzF6tHv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvZkBhGdYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8APL9PBsvAA/yiRh1pjgH+vLS+eXWMZfvVyVj Hvj+0/2V0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUHBBqlz6PV50OTADcCRzsYMNg+7pZuFXoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1bUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:05hAmqPG3HcT2MBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70969237" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWSlrshCqepRHPAGDj4sS5/foBjZDSKk6NQHSv/WjYr2Km9hC8/L5+IPJbvEAZEkveM4wpagtEkdcDcNzLNtYAVXIFoN10gXGYL2d43QB7aisHFkz9TAEWqFBymfu6xl62q4NSJGEjVMi0jTzmk3NdnCEao4Wtgw3HMNvxDygKzQp2h5n69RjG9+CdiBwnATdgJy+iIQ76CBUkm8IabkKT0fsjryLeswJnu+HJ51ONF8bCWif7TsGpt/5oqN1W9klLqeNcgoP6i/gsFRfoIQ2vORY4GJwz6aDmvzjdRrZcmsCHZ0XEH1KOO/bvfu4Oxk3yrQoHS+l7G8E2wcv0N/SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7l0EaIzwaBZrDZkYVGaiDs6kTZCqmXmKBNv7zBHnkYY=; b=Qr6R61AbHzTPJefd4byWr2CARyv6xEzCxdwD6BgpH8OQspIrWrQ4AKMJC9HrHfcoNC6+NCXmkdQ2gn7jzHx+1uU+5WJbMU83U+dDmVmiA74X4E+kWZR1lfMu7kAGoB0D3ZqVL/9sedrE2djy5n7xnepl7pqAeLt+93kYgHmqBTtHv8s2SN8jF9cKB0xj0wAaGFi6JpkcOLfZymPPwEB3pIqeICHPGr5siU1CmOtXEPYqAoHna84HK+TbgqEkKXnkFjshbvHb6hZiMBbcMCjXrkz9TfuzcieMMVgEgCIQSHSufG3UhykmH31QoTBsacF1upArkrhmRIiA83qvJbnOAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7l0EaIzwaBZrDZkYVGaiDs6kTZCqmXmKBNv7zBHnkYY=; b=bRA3a/PuRBWOlBVvIPBIKU2lSRqlpSzjqujt0Y0k6qgkqMoYcIypvq8UJsw7XEnWKJnK9Nco27+Ex4NoHkKrTtGgyA7lZBGWxOIkzoqHqC/5S0EQ0YVgeUXifQj2cyIlLrxZotK/V0uHcsUd/D+Sv620UmuUX5NMcbGoUv5yVoM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 15:30:23 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 15/21] AMD/IOMMU: free all-empty page tables Message-ID: References: <16f5b398-56f6-a70c-9ce0-0ad72eab5058@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16f5b398-56f6-a70c-9ce0-0ad72eab5058@suse.com> X-ClientProxiedBy: LO2P265CA0299.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a79b83e5-21c3-44f2-b674-08da32893f68 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6437:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mADddAtWYWWr+AAwE9IG5nbsM85lyvY5Q5MfXbpK1/L40enNXP41lVJ9Ux3pLIZOhALmkHqHrA8X4ZlHofh2v0uJo3x5NlpkfUFITG179YEo7mKKseVasXIkKugXT+QfvVPZBUidsW6h2uEUQYZTUBpo1zNUa5bN8x28Y88bbt9eZVhqlL+NAe8+I3PEXiG5ofX0hH/Kk+wOe/PV90IVVaNZx9AKClfQ079D03i7+H5T+zZl7Y66AuX5mYD2C317DJcxomb7ytZa3lr6r6si+iHdaVhGJ45ovgGTlYfJrfzO6sFUgP8B4TSuYXQl04CFOGx1ypSBSeQA1airlTZ5nXXSr6GE/LpnZV30fy+mgI8vOfvjuKloErphiz415TMbX/2AiNxTLFAhXt9sI0RqXUqB5AO6IDyf05JSmqWs/dSUKHsOGX6BY5uWtbHMqELfsQ9bIruHU62E5fJa34lYNviGdKdSsbRMbcgUYFX0yQmSAtmkf71UPjbU3W0kEyP+SZRldGfy1x99raZ7tnkzyiaRnJOJBLApXcwjOYwH4aiw7OvP3dLnljmfQgVvGNFOMhpVIqAw6051EF8el1IhiagzARYyJkC8ua2ppdKbfEUi+luqyV+qUqh3MZsT8ADqJzNn5Zhs/Fuf5QNj8FwGag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(38100700002)(8936002)(9686003)(86362001)(6486002)(82960400001)(316002)(6506007)(508600001)(54906003)(66476007)(66556008)(6916009)(66946007)(8676002)(4326008)(6666004)(83380400001)(186003)(85182001)(33716001)(26005)(2906002)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3JDMmtHakQ5U05aeG9nT1cvZjJ3ZmJKcFBteG9kbCtnakw4MlNIN0lQRlVs?= =?utf-8?B?aGcxaXZyVWhNSnE0NjVoTGtlempzZElYNUdiano0d1QvMDMzSlZOMWRMcTl2?= =?utf-8?B?bEd2dit2QVRKZkRTNVQ1aDBGeXpjQjVPUkxqWGdsTTg2cjE2YTk0ZUQ1YVFj?= =?utf-8?B?M0NQbFo4dWY5alFoMXlkZFJzQ0tzVk9DRTlJU1ZxNzdmQlEwQXR2eHAvVUcv?= =?utf-8?B?aWJmUTl4YWVyZUZ5WktiZFNoMUxnTEZjK3hsQ0V0MnA3S2pVNTNNT0dKL05j?= =?utf-8?B?N1hEWnRjdlB2MmpnSVIzTUFYSENsMVJrWVNpRzRNNkZjaFF1bk9mcnlhMWRM?= =?utf-8?B?clBoUEsvQVVWUGkwUU9UUGxKR09td3l0b3pHY0VmN05La2cxV1pDMlFueThP?= =?utf-8?B?dGpUT0JUYTFzZ1hGVlQ5YVhmam4zOGc4Z1VCQzdsd0lwMWRkM2dRT2hib0ox?= =?utf-8?B?dmNHR2ZYWGxzbmZhMURtWE5vV1lQeTFrTVZXZ1FEdWwxUXlWZHgyS2k3d1Bk?= =?utf-8?B?WERRZU5IeW9iVDI5VEJyY0t1eUR3cFMrSUE4WWR1SjJKSStnVW5hMy9NWXRj?= =?utf-8?B?MWhGQmJSMUp0Tk4wbFNMdmE4elcwcGY5ZWRxa2NMWmtqUU1EOEpRVnMvUnc0?= =?utf-8?B?bzZHMU95aGtCMzhZVnd6US9jd0hmUzJVMVltUFByMnlRUVN2Ry9DR3FxMi85?= =?utf-8?B?UDFNMFNqODlMZDVyU1VRSjU3VzlQT09NTk9ab2lORU9iWlEwQ0p0dmVSVVNO?= =?utf-8?B?QnorNUVWNjdtS1ppekgzTWZlY3FNUG1na3FreGtCUEVKSnczVE1jUVVDNDEy?= =?utf-8?B?bDlKRVZsQ1BObStKMmJHQjh0eWo1VFd1V2hCNi9BZW9VcHdPbEJmTW0vL3Zq?= =?utf-8?B?NXROTU9jZTFNdXlaM0U4R2FXR09mYlpiMEZOOE9OaVZGOFd2eHdnYlViYUlW?= =?utf-8?B?L05haUxOT2ZBNGlKQUhtTUxFTnpXWHBQd083WENLemtVUVErRUtLR0N0VGVR?= =?utf-8?B?MFdUdHJkUGVTYWczWmFPc2c1N3dHSTJXUU1WZUdMSUY3dXJUeHBqR2lwNW1G?= =?utf-8?B?bEQya0xzcXZnbDZkYTE1RC9xaEFNemNFQ0hKQTlORXpBR29mWWdWeWdNVVBz?= =?utf-8?B?eWExcHE2Ui9Lc3pOT3hnTGlNWUhpanNFLzAzQXI4MXpmSnY2WHlWUENMYnRm?= =?utf-8?B?ajBWZUlZdU12QUtlVFNyZ3FWcWtXeW1Ja0taUzduNUlack0xeHJ6dzlrZ202?= =?utf-8?B?cGR6MkcwM2RhK1ByZzFQWFBYTGllSjVZTXJscXNYbHpoWXN3Rm5JUis3SGhs?= =?utf-8?B?VTYrbTlpNzBGRUZFUjFsaGsvdUdZeFlheFdSNi8vcytlOTFib2hkNlk0U1Z1?= =?utf-8?B?QzNGcVFrRjR0cE5GcFhJREJuWG1RVXV4ekpOdnIxWG03dzFHRTY0ZDZ1Qlk1?= =?utf-8?B?bURVMVdwVVJ0NXk1bnd4YWpFQ0oyazVSZmdPMkFGZG5KRVJkVkdDdm9aT1Zt?= =?utf-8?B?dTJmWng5dHdqMkIrY29xU0V6QzgxYk1iT29iVjdkemhQWWVoTmF3ejh0MGpw?= =?utf-8?B?RGFIOURnbFhDQlptUndBWk90TE9BRUhiWVM2dytWaUdIV3hBT1NCSHZQVFl4?= =?utf-8?B?bmZGQ3V6QTNLS2lCTzRZa3oreEYvTGNZQk00d3ZNZW5aRVNHSUhSRU8wLzBl?= =?utf-8?B?cWprSi9WTTNUVUY5MFhKY3JUaXFoMFErSG9vYURNSVdrdXhLZHJOQTdjWE85?= =?utf-8?B?RHgxU25GU0hqS0V2a25iSTdQWjdNREdBdTJlRzhmREFtRVdoYVY5ZnBMSWEy?= =?utf-8?B?bDlVbWw4Q0JrUExXSGdUVGkzTGtoRFFORG5rSWNMOW14RlFmaWV3UnZkZFZQ?= =?utf-8?B?MWt5b3lrbGYra2EzNVl3U2tyNTFIMWZLRkpVQ0g3VW5zclB1QlVBbFJtelFq?= =?utf-8?B?TmtZMEt1RGVzR2RmK2NkK1Q1ZWQvbUw2cFc4RGlXWVBhbVRPdlBvWXpEMWRN?= =?utf-8?B?N1ZGSVY5TnkxQVoyV2NiOS9iK0RuQ2pyVHVjU0FjQ0NucStEbFc1MkVDM0Vz?= =?utf-8?B?VVdzTXUwQ2ljYTU5TGJZblBVejNHaDdXNWJNV1BIdU9ad3NnNHN3Vmlpc0tI?= =?utf-8?B?UUlvTnhjaE80NVJLd0o0ZkJJWENscnV3eVAzSWNkUmhQSlpBTUx1QnFBZjBW?= =?utf-8?B?MWRMQncrU0NrVHBWVnFaUE5zaEZ3Y2JUdW1tRGJYR0FHaWU3ckRSMENxYmsz?= =?utf-8?B?WG9jQXlMTUVWVXQxVXNCcGx2dlI0RU93eU9oUU43cVdCbzNQRVBOWkFLeFUz?= =?utf-8?B?NU1Qb0c0d0V2bzdOZFpFbnVqYml2VHo1MExvQk9GZWE4SVdsM2xnUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a79b83e5-21c3-44f2-b674-08da32893f68 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 13:30:28.3800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FNXEk9F6OBKdr9BPi7VBncBnZQEXuOxNoF9bDo9Yga0eS/swflxCUnYtoA6JeQMpDg4ZbgYj0nTaVoHs6CF5rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6437 On Mon, Apr 25, 2022 at 10:42:19AM +0200, Jan Beulich wrote: > When a page table ends up with no present entries left, it can be > replaced by a non-present entry at the next higher level. The page table > itself can then be scheduled for freeing. > > Note that while its output isn't used there yet, > pt_update_contig_markers() right away needs to be called in all places > where entries get updated, not just the one where entries get cleared. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Some comments below. > --- > v4: Re-base over changes earlier in the series. > v3: Re-base over changes earlier in the series. > v2: New. > > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -21,6 +21,9 @@ > > #include "iommu.h" > > +#define CONTIG_MASK IOMMU_PTE_CONTIG_MASK > +#include > + > /* Given pfn and page table level, return pde index */ > static unsigned int pfn_to_pde_idx(unsigned long pfn, unsigned int level) > { > @@ -33,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig > > static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, > unsigned long dfn, > - unsigned int level) > + unsigned int level, > + bool *free) > { > union amd_iommu_pte *table, *pte, old; > + unsigned int idx = pfn_to_pde_idx(dfn, level); > > table = map_domain_page(_mfn(l1_mfn)); > - pte = &table[pfn_to_pde_idx(dfn, level)]; > + pte = &table[idx]; > old = *pte; > > write_atomic(&pte->raw, 0); > > + *free = pt_update_contig_markers(&table->raw, idx, level, PTE_kind_null); > + > unmap_domain_page(table); > > return old; > @@ -85,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte > if ( !old.pr || old.next_level || > old.mfn != next_mfn || > old.iw != iw || old.ir != ir ) > + { > set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > + pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), > + level, PTE_kind_leaf); It would be better to call pt_update_contig_markers inside of set_iommu_pde_present, but that would imply changing the parameters passed to the function. It's cumbersome (and error prone) to have to pair calls to set_iommu_pde_present() with pt_update_contig_markers(). > + } > else > old.pr = false; /* signal "no change" to the caller */ > > @@ -322,6 +333,9 @@ static int iommu_pde_from_dfn(struct dom > smp_wmb(); > set_iommu_pde_present(pde, next_table_mfn, next_level, true, > true); > + pt_update_contig_markers(&next_table_vaddr->raw, > + pfn_to_pde_idx(dfn, level), > + level, PTE_kind_table); > > *flush_flags |= IOMMU_FLUSHF_modified; > } > @@ -347,6 +361,9 @@ static int iommu_pde_from_dfn(struct dom > next_table_mfn = mfn_x(page_to_mfn(table)); > set_iommu_pde_present(pde, next_table_mfn, next_level, true, > true); > + pt_update_contig_markers(&next_table_vaddr->raw, > + pfn_to_pde_idx(dfn, level), > + level, PTE_kind_table); > } > else /* should never reach here */ > { > @@ -474,8 +491,24 @@ int cf_check amd_iommu_unmap_page( > > if ( pt_mfn ) > { > + bool free; > + > /* Mark PTE as 'page not present'. */ > - old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); > + old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); > + > + while ( unlikely(free) && ++level < hd->arch.amd.paging_mode ) > + { > + struct page_info *pg = mfn_to_page(_mfn(pt_mfn)); > + > + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, > + flush_flags, false) ) > + BUG(); > + BUG_ON(!pt_mfn); > + > + clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); Not sure it's worth initializing free to false (at definition and before each call to clear_iommu_pte_present), just in case we manage to return early from clear_iommu_pte_present without having updated 'free'. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 13:31:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:31:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325621.548272 (Exim 4.92) (envelope-from ) id 1noPxj-0007Qv-In; Tue, 10 May 2022 13:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325621.548272; Tue, 10 May 2022 13:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxj-0007Qo-Ft; Tue, 10 May 2022 13:31:39 +0000 Received: by outflank-mailman (input) for mailman id 325621; Tue, 10 May 2022 13:31:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxh-0007QY-FZ for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:31:38 +0000 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 828044c9-d065-11ec-a406-831a346695d4; Tue, 10 May 2022 15:31:35 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2a-11a39b7d.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 10 May 2022 13:31:23 +0000 Received: from EX13D08EUC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2a-11a39b7d.us-west-2.amazon.com (Postfix) with ESMTPS id A4BD64191A; Tue, 10 May 2022 13:31:13 +0000 (UTC) Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D08EUC001.ant.amazon.com (10.43.164.184) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 10 May 2022 13:31:12 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 10 May 2022 13:31:10 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 0CF9541131; Tue, 10 May 2022 13:31:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 828044c9-d065-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652189496; x=1683725496; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LcBCa7IjI6XtJDgdMuUyaVbxzp9zN8ViQS6A7OjaIjg=; b=XVbCC6R09i0BcE7YycOoM5NfMItVr3FjxqS4fys/6IIvDIVVq7DWuLPq UAyy9jW17iGMlJczcOkjMA15kBd7T7R6ZHqbseqAX+XmUdx4d2yBn+Eb+ e5m8Fq1+sXNqEA7T5M+/ORlv2SU8mhqGkg6k9LVfChjC9VWAm0sWbPFEl 4=; X-IronPort-AV: E=Sophos;i="5.91,214,1647302400"; d="scan'208";a="193949666" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Josh Poimboeuf , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Maximilian Heyne , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 3/4] x86: xen: insn: Decode Xen and KVM emulate-prefix signature Date: Tue, 10 May 2022 13:30:32 +0000 Message-ID: <20220510133036.46767-4-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220510133036.46767-1-mheyne@amazon.de> References: <20220510133036.46767-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit 4d65adfcd1196818659d3bd9b42dccab291e1751 upstream Decode Xen and KVM's emulate-prefix signature by x86 insn decoder. It is called "prefix" but actually not x86 instruction prefix, so this adds insn.emulate_prefix_size field instead of reusing insn.prefixes. If x86 decoder finds a special sequence of instructions of XEN_EMULATE_PREFIX and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Acked-by: Josh Poimboeuf Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/insn.h | 6 ++++ arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 7 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h diff --git a/arch/x86/include/asm/insn.h b/arch/x86/include/asm/insn.h index a51ffeea6d87..a8c3d284fa46 100644 --- a/arch/x86/include/asm/insn.h +++ b/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct insn *insn) return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c index 0b5862ba6a75..404279563891 100644 --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include #include +#include + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64) insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn) if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); diff --git a/tools/arch/x86/include/asm/emulate_prefix.h b/tools/arch/x86/include/asm/emulate_prefix.h new file mode 100644 index 000000000000..70f5b98a5286 --- /dev/null +++ b/tools/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif diff --git a/tools/arch/x86/include/asm/insn.h b/tools/arch/x86/include/asm/insn.h index d7f0ae8f3c44..52c6262e6bfd 100644 --- a/tools/arch/x86/include/asm/insn.h +++ b/tools/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct insn *insn) return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c index 79e048f1d902..0151dfc6da61 100644 --- a/tools/arch/x86/lib/insn.c +++ b/tools/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include "../include/asm/inat.h" #include "../include/asm/insn.h" +#include "../include/asm/emulate_prefix.h" + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64) insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn) if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh index c3ae1e8ae119..2a1261bfbb62 100755 --- a/tools/objtool/sync-check.sh +++ b/tools/objtool/sync-check.sh @@ -4,6 +4,7 @@ FILES=' arch/x86/include/asm/inat_types.h arch/x86/include/asm/orc_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk ' @@ -46,4 +47,4 @@ done check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh index cea13cb987d0..499235a41162 100755 --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -28,6 +28,7 @@ arch/x86/include/asm/disabled-features.h arch/x86/include/asm/required-features.h arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/inat_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/include/uapi/asm/prctl.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk @@ -116,7 +117,7 @@ check lib/ctype.c '-I "^EXPORT_SYMBOL" -I "^#include " -B check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' # diff non-symmetric files check_2 tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 10 13:31:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:31:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325622.548277 (Exim 4.92) (envelope-from ) id 1noPxj-0007Te-UL; Tue, 10 May 2022 13:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325622.548277; Tue, 10 May 2022 13:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxj-0007TB-OE; Tue, 10 May 2022 13:31:39 +0000 Received: by outflank-mailman (input) for mailman id 325622; Tue, 10 May 2022 13:31:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxi-0007QY-Q4 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:31:38 +0000 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84292ea5-d065-11ec-a406-831a346695d4; Tue, 10 May 2022 15:31:37 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-b69ea591.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP; 10 May 2022 13:31:18 +0000 Received: from EX13D08EUB004.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1e-b69ea591.us-east-1.amazon.com (Postfix) with ESMTPS id EE987C040C; Tue, 10 May 2022 13:31:08 +0000 (UTC) Received: from EX13MTAUWC001.ant.amazon.com (10.43.162.135) by EX13D08EUB004.ant.amazon.com (10.43.166.158) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 10 May 2022 13:31:06 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.162.232) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 10 May 2022 13:31:05 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 2BD5441131; Tue, 10 May 2022 13:31:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 84292ea5-d065-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652189498; x=1683725498; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TwU6CtF1V9/2Y57AY/B4As4rfmtIlL8LhHI2uYJkLIs=; b=FyYmvnRUcsJVS69Tcrvo195ERsck9rceHbxR90e6tmjuHwvDT6odIS9X bdluVY4t8L3641WU8nCUuyPHK5sq2ZR6CsfbHLdux05sCArduEDYIcMon /kqYuPcDIqIbHgvjab8jaKeis/Cvrke0Nh6PuvojC9M8rOHjxszypRA// E=; X-IronPort-AV: E=Sophos;i="5.91,214,1647302400"; d="scan'208";a="193949634" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 1/4] x86/asm: Allow to pass macros to __ASM_FORM() Date: Tue, 10 May 2022 13:30:30 +0000 Message-ID: <20220510133036.46767-2-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220510133036.46767-1-mheyne@amazon.de> References: <20220510133036.46767-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit f7919fd943abf0c77aed4441ea9897a323d132f5 upstream Use __stringify() at __ASM_FORM() so that user can pass code including macros to __ASM_FORM(). Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/asm.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h index 3ff577c0b102..1b563f9167ea 100644 --- a/arch/x86/include/asm/asm.h +++ b/arch/x86/include/asm/asm.h @@ -7,9 +7,11 @@ # define __ASM_FORM_RAW(x) x # define __ASM_FORM_COMMA(x) x, #else -# define __ASM_FORM(x) " " #x " " -# define __ASM_FORM_RAW(x) #x -# define __ASM_FORM_COMMA(x) " " #x "," +#include + +# define __ASM_FORM(x) " " __stringify(x) " " +# define __ASM_FORM_RAW(x) __stringify(x) +# define __ASM_FORM_COMMA(x) " " __stringify(x) "," #endif #ifndef __x86_64__ -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 10 13:31:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:31:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325623.548294 (Exim 4.92) (envelope-from ) id 1noPxt-00085d-C7; Tue, 10 May 2022 13:31:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325623.548294; Tue, 10 May 2022 13:31:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxt-00085U-8W; Tue, 10 May 2022 13:31:49 +0000 Received: by outflank-mailman (input) for mailman id 325623; Tue, 10 May 2022 13:31:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxr-0007IC-Ip for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:31:47 +0000 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8953d80f-d065-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 15:31:46 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-90d70b14.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 10 May 2022 13:31:31 +0000 Received: from EX13D08EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-90d70b14.us-east-1.amazon.com (Postfix) with ESMTPS id 14F59C08D3; Tue, 10 May 2022 13:31:23 +0000 (UTC) Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D08EUB003.ant.amazon.com (10.43.166.117) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 10 May 2022 13:31:03 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 10 May 2022 13:31:02 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 3590B41131; Tue, 10 May 2022 13:31:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 8953d80f-d065-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652189507; x=1683725507; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ZcFtI8jvSLQdq7u3zXtig0/LPNcCJ80T1zsBtiZt0Y0=; b=lOiTCicUUZUUf+HCag81O0D02YFgU8DEUEpPd0EAWUa5A7RPHzV4BfT2 qF37xbVu5LMuDvsFsvRHWuc7RUrIMDwYsPiBlTlCDPLsWZ1UQV4tsYB8z 2aH5tzgVKFN9oqy3FtlQOcS0v2dHFC/UUlanBOflNJpFxtBMrN6l5WAqO o=; X-IronPort-AV: E=Sophos;i="5.91,214,1647302400"; d="scan'208";a="200152145" From: Maximilian Heyne To: CC: Maximilian Heyne , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Josh Poimboeuf , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Masami Hiramatsu , Sasha Levin , , , Subject: [PATCH 0/4] x86: decode Xen/KVM emulate prefixes Date: Tue, 10 May 2022 13:30:29 +0000 Message-ID: <20220510133036.46767-1-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This is a backport of a patch series for 5.4.x. The patch series allows the x86 decoder to decode the Xen and KVM emulate prefixes. In particular this solves the following issue that appeared when commit db6c6a0df840 ("objtool: Fix noreturn detection for ignored functions") was backported to 5.4.69: arch/x86/xen/enlighten_pv.o: warning: objtool: xen_cpuid()+0x25: can't find jump dest instruction at .text+0x9c Also now that this decoding is possible, also backport the commit which prevents kprobes on probing such prefixed instructions. This was also part of the original series. The series applied mostly cleanly on 5.4.192 except for a contextual problem in the 3rd patch ("x86: xen: insn: Decode Xen and KVM emulate-prefix signature"). Masami Hiramatsu (4): x86/asm: Allow to pass macros to __ASM_FORM() x86: xen: kvm: Gather the definition of emulate prefixes x86: xen: insn: Decode Xen and KVM emulate-prefix signature x86: kprobes: Prohibit probing on instruction which has emulate prefix arch/x86/include/asm/asm.h | 8 +++-- arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ arch/x86/include/asm/insn.h | 6 ++++ arch/x86/include/asm/xen/interface.h | 11 +++---- arch/x86/kernel/kprobes/core.c | 4 +++ arch/x86/kvm/x86.c | 4 ++- arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 12 files changed, 128 insertions(+), 13 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h base-commit: 1d72b776f6dc973211f5d153453cf8955fb3d70a -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 10 13:31:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:31:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325627.548305 (Exim 4.92) (envelope-from ) id 1noPxw-0008RH-Ls; Tue, 10 May 2022 13:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325627.548305; Tue, 10 May 2022 13:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxw-0008Qv-IB; Tue, 10 May 2022 13:31:52 +0000 Received: by outflank-mailman (input) for mailman id 325627; Tue, 10 May 2022 13:31:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPxv-0007IC-Gp for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:31:51 +0000 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8aa34397-d065-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 15:31:48 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 10 May 2022 13:31:36 +0000 Received: from EX13D08EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1a-828bd003.us-east-1.amazon.com (Postfix) with ESMTPS id 3037C80C1F; Tue, 10 May 2022 13:31:26 +0000 (UTC) Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D08EUB003.ant.amazon.com (10.43.166.117) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 10 May 2022 13:31:09 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 10 May 2022 13:31:08 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 1F08041131; Tue, 10 May 2022 13:31:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 8aa34397-d065-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652189509; x=1683725509; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/jlcjyqHJJuyQxaME83nVeMauiezhLHJNpjQ1y9lQkI=; b=VWpQLELEF/G7CE0nH8+rjYQrtpcHT+2WfqFs+S9ZiAAA/t40vJpCp4kn n/5G4QyMqU0uKgnkMatyLgwMiF6SE/nEp/pHId23u69KCG5vGezi53Yz8 S7ocn0TxWWYEPOaYjwSJ+FaJahc8t/tHi5bpVfFW4ea/5xN8uQRc5CWww I=; X-IronPort-AV: E=Sophos;i="5.91,214,1647302400"; d="scan'208";a="196877995" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Ingo Molnar , Boris Ostrovsky , Andrew Cooper , Stefano Stabellini , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 2/4] x86: xen: kvm: Gather the definition of emulate prefixes Date: Tue, 10 May 2022 13:30:31 +0000 Message-ID: <20220510133036.46767-3-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220510133036.46767-1-mheyne@amazon.de> References: <20220510133036.46767-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 upstream Gather the emulate prefixes, which forcibly make the following instruction emulated on virtualization, in one place. Suggested-by: Peter Zijlstra Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Ingo Molnar Cc: Boris Ostrovsky Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777563917.25081.7286628561790289995.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/emulate_prefix.h | 14 ++++++++++++++ arch/x86/include/asm/xen/interface.h | 11 ++++------- arch/x86/kvm/x86.c | 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h diff --git a/arch/x86/include/asm/emulate_prefix.h b/arch/x86/include/asm/emulate_prefix.h new file mode 100644 index 000000000000..70f5b98a5286 --- /dev/null +++ b/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif diff --git a/arch/x86/include/asm/xen/interface.h b/arch/x86/include/asm/xen/interface.h index 62ca03ef5c65..9139b3e86316 100644 --- a/arch/x86/include/asm/xen/interface.h +++ b/arch/x86/include/asm/xen/interface.h @@ -379,12 +379,9 @@ struct xen_pmu_arch { * Prefix forces emulation of some non-trapping instructions. * Currently only CPUID. */ -#ifdef __ASSEMBLY__ -#define XEN_EMULATE_PREFIX .byte 0x0f,0x0b,0x78,0x65,0x6e ; -#define XEN_CPUID XEN_EMULATE_PREFIX cpuid -#else -#define XEN_EMULATE_PREFIX ".byte 0x0f,0x0b,0x78,0x65,0x6e ; " -#define XEN_CPUID XEN_EMULATE_PREFIX "cpuid" -#endif +#include + +#define XEN_EMULATE_PREFIX __ASM_FORM(.byte __XEN_EMULATE_PREFIX ;) +#define XEN_CPUID XEN_EMULATE_PREFIX __ASM_FORM(cpuid) #endif /* _ASM_X86_XEN_INTERFACE_H */ diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1f7dfa5aa42d..6dd77e426889 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #define CREATE_TRACE_POINTS @@ -5583,6 +5584,7 @@ EXPORT_SYMBOL_GPL(kvm_write_guest_virt_system); int handle_ud(struct kvm_vcpu *vcpu) { + static const char kvm_emulate_prefix[] = { __KVM_EMULATE_PREFIX }; int emul_type = EMULTYPE_TRAP_UD; char sig[5]; /* ud2; .ascii "kvm" */ struct x86_exception e; @@ -5590,7 +5592,7 @@ int handle_ud(struct kvm_vcpu *vcpu) if (force_emulation_prefix && kvm_read_guest_virt(vcpu, kvm_get_linear_rip(vcpu), sig, sizeof(sig), &e) == 0 && - memcmp(sig, "\xf\xbkvm", sizeof(sig)) == 0) { + memcmp(sig, kvm_emulate_prefix, sizeof(sig)) == 0) { kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(sig)); emul_type = EMULTYPE_TRAP_UD_FORCED; } -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 10 13:32:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:32:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325640.548316 (Exim 4.92) (envelope-from ) id 1noPyV-0001Cq-1G; Tue, 10 May 2022 13:32:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325640.548316; Tue, 10 May 2022 13:32:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPyU-0001Cj-UG; Tue, 10 May 2022 13:32:26 +0000 Received: by outflank-mailman (input) for mailman id 325640; Tue, 10 May 2022 13:32:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noPyT-0007QY-Rf for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:32:25 +0000 Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com [99.78.197.218]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f69fde0-d065-11ec-a406-831a346695d4; Tue, 10 May 2022 15:32:24 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com) ([10.25.36.210]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP; 10 May 2022 13:31:25 +0000 Received: from EX13D08EUB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b27d4a00.us-east-1.amazon.com (Postfix) with ESMTPS id 236BC81236; Tue, 10 May 2022 13:31:15 +0000 (UTC) Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D08EUB001.ant.amazon.com (10.43.166.236) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 10 May 2022 13:31:14 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 10 May 2022 13:31:14 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id E83F641131; Tue, 10 May 2022 13:31:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 9f69fde0-d065-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652189544; x=1683725544; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fXdsCza0w8qNDoFrKMYkMnUAwI+hskYjRxqBpTNbyyY=; b=Q+en0i+uN9Ewn4HE01M9eacVUESE3pgE5cwho5e5IWi62pH9e/u5Mfja mrtT5oOq4z60NqPkk4psDxexwiumYpTdv3Q9NxgWVMHg7CZaRXT9ahmi2 UzXFeQN7WKSztv61XndBk4+G7gNYfKdXjfnDq3kKJHc2KsvBj/7XbCnQb g=; X-IronPort-AV: E=Sophos;i="5.91,214,1647302400"; d="scan'208";a="87035422" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 4/4] x86: kprobes: Prohibit probing on instruction which has emulate prefix Date: Tue, 10 May 2022 13:30:33 +0000 Message-ID: <20220510133036.46767-5-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220510133036.46767-1-mheyne@amazon.de> References: <20220510133036.46767-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit 004e8dce9c5595697951f7cd0e9f66b35c92265e upstream Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/kernel/kprobes/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index c205d77d57da..3700dc94847c 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -358,6 +358,10 @@ int __copy_instruction(u8 *dest, u8 *src, u8 *real, struct insn *insn) kernel_insn_init(insn, dest, MAX_INSN_SIZE); insn_get_length(insn); + /* We can not probe force emulate prefixed instruction */ + if (insn_has_emulate_prefix(insn)) + return 0; + /* Another subsystem puts a breakpoint, failed to recover */ if (insn->opcode.bytes[0] == BREAKPOINT_INSTRUCTION) return 0; -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 10 13:45:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:45:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325668.548326 (Exim 4.92) (envelope-from ) id 1noQAe-0003SD-64; Tue, 10 May 2022 13:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325668.548326; Tue, 10 May 2022 13:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQAe-0003S6-2p; Tue, 10 May 2022 13:45:00 +0000 Received: by outflank-mailman (input) for mailman id 325668; Tue, 10 May 2022 13:44:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQAc-0003Rw-4T; Tue, 10 May 2022 13:44:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQAb-0006cW-W9; Tue, 10 May 2022 13:44:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQAb-0000Ak-8d; Tue, 10 May 2022 13:44:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noQAb-0003U8-89; Tue, 10 May 2022 13:44:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eC3cOA/zMGWHPRVPoqnNCS1y4WepktRvw0BMI8z8zDU=; b=TjKuZMo0r3a23MfGry8O3O2Gd0 4FoBi13EQIat9oAmwJWl7+LAPsEzzgCT0JuHbYWf2J3B0ID+rAcEf/eSMV0TIUJtq9Pj8clDNxQG6 JGT8eBRNmTXPa8hFcX3Rzp8e8d42JhpBjGty7jOgP/5YFPSpChG67TNn0mkXwqtzlcv0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170298: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 13:44:57 +0000 flight 170298 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170298/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 914 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 13:54:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 13:54:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325677.548338 (Exim 4.92) (envelope-from ) id 1noQJf-0005FR-7e; Tue, 10 May 2022 13:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325677.548338; Tue, 10 May 2022 13:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQJf-0005FK-4V; Tue, 10 May 2022 13:54:19 +0000 Received: by outflank-mailman (input) for mailman id 325677; Tue, 10 May 2022 13:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQJd-0005FE-NZ for xen-devel@lists.xenproject.org; Tue, 10 May 2022 13:54:18 +0000 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab387754-d068-11ec-a406-831a346695d4; Tue, 10 May 2022 15:54:14 +0200 (CEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KyKJp4qqdz4yTd; Tue, 10 May 2022 23:54:02 +1000 (AEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab387754-d068-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1652190848; bh=RKiZUE5HvPhTVnUibJtmltdG/qpHsl+mSP0bgs2lHhQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z05kSyfn/tRZEkMC+xx0iIJQ7Am+MQO7HLgvv0mZSHOcfpqTom2o/uwqzS0x8Mf2S +MV9rZ+Fzf71f3gh47v8ZN6FuQpE+0hL2e6Ug+4kF9Y6fEpYke0W/joqSUA70Lwp5I 4Ppma9tFa9PkRNG20BN4X8MRlMpJ63sRO/S19u9v0FZlEHa4Js3eqk1sS3wGAa85dR +Jh96R1o2OAtJhZFfuVMo1EZ8CMSa8mkEAFP0AyoLzOV+kygqKbLAfKRxs3fKgbcsD 1Vaxn4RMiVSaImYmC7RQ1ktIs3LG4P5Jb+tgoFnzybYroBhkWvfkc77elbZWKz1nx/ 2xhke52QkhhQQ== From: Michael Ellerman To: "Guilherme G. Piccoli" , Hari Bathini Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, pmladek@suse.com, kexec@lists.infradead.org, bhe@redhat.com, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Nicholas Piggin , Paul Mackerras , akpm@linux-foundation.org Subject: Re: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers In-Reply-To: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-9-gpiccoli@igalia.com> <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> Date: Tue, 10 May 2022 23:53:56 +1000 Message-ID: <87fslh8pe3.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain "Guilherme G. Piccoli" writes: > On 05/05/2022 15:55, Hari Bathini wrote: >> [...] >> The change looks good. I have tested it on an LPAR (ppc64). >> >> Reviewed-by: Hari Bathini >> > > Hi Michael. do you think it's possible to add this one to powerpc/next > (or something like that), or do you prefer a V2 with his tag? Ah sorry, I assumed it was going in as part of the whole series. I guess I misread the cover letter. So you want me to take this patch on its own via the powerpc tree? cheers From xen-devel-bounces@lists.xenproject.org Tue May 10 14:04:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325683.548349 (Exim 4.92) (envelope-from ) id 1noQTU-00071v-5w; Tue, 10 May 2022 14:04:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325683.548349; Tue, 10 May 2022 14:04:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQTU-00071o-2g; Tue, 10 May 2022 14:04:28 +0000 Received: by outflank-mailman (input) for mailman id 325683; Tue, 10 May 2022 14:04:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQTS-00071i-Uf for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:04:27 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18f572bb-d06a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 16:04:25 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id v12so23934092wrv.10 for ; Tue, 10 May 2022 07:04:25 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a15-20020a056000100f00b0020c5253d8d9sm14142078wrx.37.2022.05.10.07.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 07:04:23 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 64DA01FFB7; Tue, 10 May 2022 15:04:22 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18f572bb-d06a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=PInxcsz/FcQAW9iY+fuesUscvZ7z/Uz8rPe6ZunJA3Q=; b=TI7OUEQnKF5mSjEs+eQWLGaJB/1jfs8PXIuMv8Dvo1y3ECGqY8X+LprTaki/ZhLYK6 ANl1aGr981ejGL83JWOl5Uk9n1hCrEr1aB6pnev6uAnM6lrU2AM6d1ppkalVHBqA5XF1 tibh6j4YjCqEs2zme5tAvsefi3BgmK3C9AHDpMJfOLjAHkWC/MPK6Cro90gl2KR3GwIu 2YWOcWmjNtb+7m9QawI1zqP6FHmBHp9RdQkAHZxO9MQOvydE3woPO8MBtBO/+7CHcqA0 zh2H795x2IKTXfomllkT1fRHt2Hn9qxHN06tsi7V++BlnbMeKEYWlqubwvqocT6OWxkF M2lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=PInxcsz/FcQAW9iY+fuesUscvZ7z/Uz8rPe6ZunJA3Q=; b=IDTG72ARrBFszlclx8ik1EjlX8NAZEk8dUW4cxVWL5QMEjZJEYM41djbm0v0GZ/ake jWwB63emDShpvzvVkxdLHxQ9ZfYtk1C1vVTsuBDz3q4bAItmRkMTpNEmuBd+mITKXnHn PwYBUfrjfagapSYgh3Z5+XM5hUs5AGrw2m6qgtSByo3eINSkESJi0iFrt9htX7L1R4cC VoXkypMzn9uBoUF85sAXlZcbDiFoksfc/53N3LhB4DPaxQ3SsG0tLeKigUqf90LPMUsy wADkrTLJCbPtYqHkElSWR7eXdRHW+6QCddnAi/WUJ9W4rzVoPJzdyrA6uLrnSYV8t0+D E/nA== X-Gm-Message-State: AOAM531e38KRI6vsBSEByrN8RvTV/HwRXTVwzcTlez8wIBBdEq03Au9c wEYr1NAL3miMzVBWGw2jxyjQCQ== X-Google-Smtp-Source: ABdhPJw/rU56ddlG3Pdq/rLOu+Gd3KFsTifKK/JPDWXEk2hej13zBXTaNs29LkPoYfAzSN+UjAkERQ== X-Received: by 2002:adf:e942:0:b0:20a:c907:90d6 with SMTP id m2-20020adfe942000000b0020ac90790d6mr18753237wrn.163.1652191464301; Tue, 10 May 2022 07:04:24 -0700 (PDT) References: <20220428103410.2723837-1-alex.bennee@linaro.org> <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> User-agent: mu4e 1.7.13; emacs 28.1.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Julien Grall Cc: xen-devel@lists.xenproject.org, stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw Date: Tue, 10 May 2022 15:03:52 +0100 In-reply-to: <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> Message-ID: <8735hhtrfd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Grall writes: > Hi Alex, > > On 28/04/2022 11:34, Alex Benn=C3=A9e wrote: >> When we introduced FEAT_LPA to QEMU's -cpu max we discovered older >> kernels had a bug where the physical address was copied directly from >> ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits >> the same error by blindly copying across the max supported range. >> Unsurprisingly when the page tables aren't set up for these greater >> ranges hilarity ensues and the hypervisor crashes fairly early on in >> the boot-up sequence. This happens when we write to the control >> register in enable_mmu(). >> Attempt to fix this the same way as the Linux kernel does by gating >> PARange to the maximum the hypervisor can handle. I also had to fix up >> code in p2m which panics when it sees an "invalid" entry in PARange. >> Signed-off-by: Alex Benn=C3=A9e >> Cc: Richard Henderson >> Cc: Stefano Stabellini >> Cc: Julien Grall >> Cc: Volodymyr Babchuk >> Cc: Bertrand Marquis > > Acked-by: Julien Grall Will you pick this up via your tree or do I need to do something else to get it upstreamed? I guess it needs to go on master and last stable? --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Tue May 10 14:05:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325689.548359 (Exim 4.92) (envelope-from ) id 1noQUf-0007ZX-Fn; Tue, 10 May 2022 14:05:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325689.548359; Tue, 10 May 2022 14:05:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQUf-0007ZQ-DE; Tue, 10 May 2022 14:05:41 +0000 Received: by outflank-mailman (input) for mailman id 325689; Tue, 10 May 2022 14:05:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQUe-0007ZI-Fg for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:05:40 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4422a734-d06a-11ec-a406-831a346695d4; Tue, 10 May 2022 16:05:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4422a734-d06a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652191538; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ShYoC//Fj+0SVz6SvliLV+WMXZfPQSkzrta4M19aexI=; b=C9EFJjcDwLaefy9tK+LH334n2WmbaLJEMbe8f8qbRv2lHOSlCWi84Z8O 1eUbHpFC2mNfaW/RZukvd0YOaDNLcxuPzQfcwoi2YkSSUKLsXDh0U07gO W/imgJWQ0LKNeCUZz0jWiywMFa9zpf/RU1RkkOF47TuxAJ0emBMkXKjHl Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70975971 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:cTvzF6vosbgmWV9nmz51NfgiaefnVEVeMUV32f8akzHdYApBsoF/q tZmKWGFPPaJY2Pyed91b9zlpkIA7Z/cmNdhTQdo/CE2HytG+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U4 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8mbrf+w+hDAyJfLCN/B49vxaLicV6g5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWU3PUudMkIWUrsRINFlvO6X3H3+SmxRpmCvgrU732KM7CUkhdABN/KKI4fXFK25hH2wv Xna9m70BhUbMt23yjef9H+owOjVkkvTR4Y6BLC+sPlwjzW7xHEXCRAQfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhTziIxpOITFSXig7Two/wfDevaRjqA2aG76PD5WJptHyHDjxx RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqTysTDmAeB8wJF1p7Vrl FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8rlxBGFb5JOi8BQ2Sw28za645lcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIcUO8IoK1/XoHkzDaJ144wKuBJ3+ZzTx L/BKZr8ZZrkIfoPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292 48Ga6OilkQEOMWjM3a/zGLmBQ1TRZTNLcuu+5I/my/qClcOJVzN/NeLn+x7J9w+z/Q9eyWh1 ijVZ3K0AWHX3RXvQThmoFg6AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:tHpFIqyHWEpBK2/QKLHFKrPwJr1zdoMgy1knxilNoRw8SKOlfq eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78 tdmtBFeb7NMWQ= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70975971" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [XEN PATCH] docs: fix path to code in migration doc Date: Tue, 10 May 2022 15:05:06 +0100 Message-ID: <20220510140506.64930-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- docs/features/migration.pandoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/features/migration.pandoc b/docs/features/migration.pandoc index 719925818e..5334536d48 100644 --- a/docs/features/migration.pandoc +++ b/docs/features/migration.pandoc @@ -54,10 +54,10 @@ legacy stream into a migration v2 stream. * `docs/specs/libxc-migration-stream.pandoc` * `docs/specs/libxl-migration-stream.pandoc` * `libxc` - * `tools/libxc/xc_sr_*.[hc]` + * `tools/libs/guest/xg_sr_*.[hc]` * `libxl` - * `tools/libxl/libxl_stream_{read,write}.c` - * `tools/libxl/libxl_convert_callout.c` + * `tools/libs/light/libxl_stream_{read,write}.c` + * `tools/libs/light/libxl_convert_callout.c` * Scripts * `tools/python/xen/migration/*.py` * `tools/python/scripts/convert-legacy-stream` -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 10 14:12:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325696.548371 (Exim 4.92) (envelope-from ) id 1noQau-0000qk-6d; Tue, 10 May 2022 14:12:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325696.548371; Tue, 10 May 2022 14:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQau-0000qd-2x; Tue, 10 May 2022 14:12:08 +0000 Received: by outflank-mailman (input) for mailman id 325696; Tue, 10 May 2022 14:12:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQap-0000qX-Tn for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:12:06 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28a72f31-d06b-11ec-a406-831a346695d4; Tue, 10 May 2022 16:12:01 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noQa0-000AUZ-9j; Tue, 10 May 2022 16:11:12 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28a72f31-d06b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vlPcmXA97Qhtkz3pBw6LdXf1X8P0UYvVzj4VthO5jgc=; b=e9qBavzt7iSXqotIL+kEfOWSDC iVRppT3Hb/vZk3YrAi/b/1Sks4coJ4CDDP+7PsBf/3PYaPFt1gdo8rsOdKqYQ7smquEWj28eStWqL CRF+oqCbuJG6ZM1a8GSMIH+b891MTAxbko/s3bV28TSILNPx0vJS6lKq9Hi1OrpvIOMJ2yAsDH+AE 5UZLLIZnAX0XkUOFElR9JGQkkK04aCtF/juYrAyo+JJs0W0WZech05pCgMVZEF/gDbG3lXHdR+nlg gc7p3pNqQj2cprKtyF3OhhaP7dxC5PNGfWWqohU3giKekM5UQ60wlcwHLGqdoJfnT4tcYUBBcGgto etn8qzNQ==; Message-ID: <58837e3d-0e2a-42ac-f198-9fe7be7aa823@igalia.com> Date: Tue, 10 May 2022 11:10:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 08/30] powerpc/setup: Refactor/untangle panic notifiers Content-Language: en-US To: Michael Ellerman , Hari Bathini Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, pmladek@suse.com, kexec@lists.infradead.org, bhe@redhat.com, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Nicholas Piggin , Paul Mackerras , akpm@linux-foundation.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-9-gpiccoli@igalia.com> <3c34d8e2-6f84-933f-a4ed-338cd300d6b0@linux.ibm.com> <87fslh8pe3.fsf@mpe.ellerman.id.au> From: "Guilherme G. Piccoli" In-Reply-To: <87fslh8pe3.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 10:53, Michael Ellerman wrote: > "Guilherme G. Piccoli" writes: >> On 05/05/2022 15:55, Hari Bathini wrote: >>> [...] >>> The change looks good. I have tested it on an LPAR (ppc64). >>> >>> Reviewed-by: Hari Bathini >>> >> >> Hi Michael. do you think it's possible to add this one to powerpc/next >> (or something like that), or do you prefer a V2 with his tag? > > Ah sorry, I assumed it was going in as part of the whole series. I guess > I misread the cover letter. > > So you want me to take this patch on its own via the powerpc tree? > > cheers Hi Michael, thanks for the prompt response! You didn't misread, that was the plan heh But some maintainers start to take patches and merge in their trees, and in the end, it seems to make sense - almost half of this series are fixes or clean-ups, that are not really necessary to get merged altogether. So, if you can take this one, I'd appreciate - it'll make V2 a bit smaller =) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 10 14:12:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:12:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325701.548381 (Exim 4.92) (envelope-from ) id 1noQbX-0001Mr-Fs; Tue, 10 May 2022 14:12:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325701.548381; Tue, 10 May 2022 14:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQbX-0001Mk-Ch; Tue, 10 May 2022 14:12:47 +0000 Received: by outflank-mailman (input) for mailman id 325701; Tue, 10 May 2022 14:12:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQbV-0001LY-II for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:12:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQbV-0007Cj-65; Tue, 10 May 2022 14:12:45 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noQbU-0000Sr-VU; Tue, 10 May 2022 14:12:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PF0BN+jzVmzYpLhdi5IOIUWNCs8skRYGLmpOpdJtS6M=; b=mER6+lrzvuWvE1nR1uW4qjPtdx wE8g3CQ3zdem2yRoBLTLg1YgSQEdTSUkLfKW/vMUTy5Fmg5qWE6jdrrfDenldXxRwQ0wveHTxvH6p pueXEg3mdL66t9e4pnwVrl4G/D+Z0PyqFW5h61+xywVydDMQ9x7NjWlKg3k/svz3FvHM=; Message-ID: <191159cc-f26d-f161-3f44-431507a6c270@xen.org> Date: Tue, 10 May 2022 15:12:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: xen-devel@lists.xenproject.org, stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220428103410.2723837-1-alex.bennee@linaro.org> <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> <8735hhtrfd.fsf@linaro.org> From: Julien Grall In-Reply-To: <8735hhtrfd.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Alex, On 10/05/2022 15:03, Alex Bennée wrote: > > Julien Grall writes: > >> Hi Alex, >> >> On 28/04/2022 11:34, Alex Bennée wrote: >>> When we introduced FEAT_LPA to QEMU's -cpu max we discovered older >>> kernels had a bug where the physical address was copied directly from >>> ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits >>> the same error by blindly copying across the max supported range. >>> Unsurprisingly when the page tables aren't set up for these greater >>> ranges hilarity ensues and the hypervisor crashes fairly early on in >>> the boot-up sequence. This happens when we write to the control >>> register in enable_mmu(). >>> Attempt to fix this the same way as the Linux kernel does by gating >>> PARange to the maximum the hypervisor can handle. I also had to fix up >>> code in p2m which panics when it sees an "invalid" entry in PARange. >>> Signed-off-by: Alex Bennée >>> Cc: Richard Henderson >>> Cc: Stefano Stabellini >>> Cc: Julien Grall >>> Cc: Volodymyr Babchuk >>> Cc: Bertrand Marquis >> >> Acked-by: Julien Grall > > Will you pick this up via your tree or do I need to do something else to > get it upstreamed? I guess it needs to go on master and last stable? We only have one tree in Xen where committers (such as Stefano and I) will commit patches regularly to staging. Osstest will then push to master once the testing passed. I have done that now. Interestingly, git am wasn't able to apply this patch. I had to do with: 42sh> git am --show-current-patch=diff | patch -p1 patching file xen/arch/arm/arm64/head.S Hunk #1 succeeded at 474 (offset 1 line). patching file xen/arch/arm/p2m.c Hunk #1 succeeded at 32 with fuzz 2. Hunk #2 succeeded at 2023 (offset -7 lines). Hunk #3 succeeded at 2031 (offset -7 lines). Hunk #4 succeeded at 2062 (offset -7 lines). Which branch did you use for sending the patch? Regarding stable, I will add the patch in my backport candidate list and send a list to Stefano when we prepare the backports. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 14:16:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:16:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325708.548393 (Exim 4.92) (envelope-from ) id 1noQer-00024U-W6; Tue, 10 May 2022 14:16:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325708.548393; Tue, 10 May 2022 14:16:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQer-00024N-T2; Tue, 10 May 2022 14:16:13 +0000 Received: by outflank-mailman (input) for mailman id 325708; Tue, 10 May 2022 14:16:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQer-00024H-Gp for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:16:13 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bea19b27-d06b-11ec-a406-831a346695d4; Tue, 10 May 2022 16:16:12 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 932901F896; Tue, 10 May 2022 14:16:11 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 01C5F2C141; Tue, 10 May 2022 14:16:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bea19b27-d06b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652192171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A8/NZJeBAhTKLHLb3PoAvlXD/AvbEgaBaR5HXaRNdkM=; b=BeTzacf3mS4VoGHK6i1jVn2p93FIleajbiX/lqLZYQzEPT5BuEThdtby46ST2AJUboj/I/ VqEG9r83Q4xijGW9lCE2hweKm6E7raa+vKstZ+w2OtTvG5P31Un3HT5rf7nvpJdK7CHBFy VZPQPYk1mnBdJ3vUcDiFbXkwBcjlkRU= Date: Tue, 10 May 2022 16:16:06 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Ivan Kokshaysky , Matt Turner , rth@gcc.gnu.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, bhe@redhat.com, kexec@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 10/30] alpha: Clean-up the panic notifier code Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-11-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 2022-05-09 11:13:17, Guilherme G. Piccoli wrote: > On 27/04/2022 19:49, Guilherme G. Piccoli wrote: > > The alpha panic notifier has some code issues, not following > > the conventions of other notifiers. Also, it might halt the > > machine but still it is set to run as early as possible, which > > doesn't seem to be a good idea. Yeah, it is pretty strange behavior. I looked into the history. This notifier was added into the alpha code in 2.4.0-test2pre2. In this historic code, the default panic() code either rebooted after a timeout or ended in a infinite loop. There was not crasdump at that times. The notifier allowed to change the behavior. There were 3 notifiers: + mips and mips64 ended with blinking in panic() + alpha did __halt() in this srm case They both still do this. I guess that it is some historic behavior that people using these architectures are used to. Anyway, it makes sense to do this as the last notifier after dumping other information. Reviewed-by: Petr Mladek Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 14:21:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:21:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325716.548404 (Exim 4.92) (envelope-from ) id 1noQk8-0003nI-QA; Tue, 10 May 2022 14:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325716.548404; Tue, 10 May 2022 14:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQk8-0003nB-M5; Tue, 10 May 2022 14:21:40 +0000 Received: by outflank-mailman (input) for mailman id 325716; Tue, 10 May 2022 14:21:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQk7-0003mR-BO for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:21:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fcfa91e-d06c-11ec-a406-831a346695d4; Tue, 10 May 2022 16:21:37 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 10:21:34 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN7PR03MB3890.namprd03.prod.outlook.com (2603:10b6:408:21::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 14:21:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Tue, 10 May 2022 14:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fcfa91e-d06c-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652192497; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dcQ9oHjMEvTxEoarpbDOixReM0JF1JKmsGKP20YXIvE=; b=Ev2tI1B9GK/a6p92EjNE+0OrUOtgtN323yLT8Na0OL1xv5wiDqBRbf1A uEHlnuhZ0hYzTImdXAM6YOFsRWL9rfwKiiIBrNMkpdXvx1gcJ/wxRIaMw BLEFRivO/8FkMXY0ZoN7Y7ZNOblquNeTtO9FY0Qx8fxXzNaib+2PDiaE/ U=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 70371536 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Pt3+KKnd68em36t69mmXlnzo5gyaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXD2uGM66PYTDzfYt1PIuxo00OvpaDyNAyGlZu/C1gECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWlvV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYWVYOHYv3l+khQjJWFDNaOo5o+rbXPi3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhGpYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvuDeKkVcvuFTrGOb7K+KVfphapUCnv 2Lq+EvHMh8na9PKnFJp9Vrp3IcjhxjTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ 2QW8Cczqak59GSwU8LwGRa/pRasvAMYWtdWO/037keK0KW8yx2CGmEOQzpFadonnMw7Xzon0 hmOhdyBLSNrmK2YTzSa7Lj8kN+pES0cLGtHYDBeSwIAuoHnuNtq1k+JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNTNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:MscN/K2yLwhL2v11LF8ppgqjBetxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+ UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/ 6uJZM+OY6XEVfT X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70371536" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGUkbEwpq5dbU2s1zekJAFpwDt5x8gtuxlqSShC9LFE41iRAOwIycTv8iwtmcnSyoR6GMG5b/jANIju6oYBvcHy/KZ6bq7vZTWJ2FWoZQJf3cGRKgENMkuzMx/Jg0EQH8xM1h2R7lSrdP91DT6Ee0B86EqY1khpY13Gif+Fcx4MjSKhhlF5QV2k25rsViA843zCKLUMa0O+71d83dghwvBgiS0H1X+8DZ8mru4mFBH8X6ZKiGEFNq/nY7tbt2MFjD9rpuhusc2mWvBACh/HjkMnBEAtDMDrdXXDLqwC2/SzaN2yMy3khsN5mCfvFHpaf7lIqCLa3U+CktbQM4ti2JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dcQ9oHjMEvTxEoarpbDOixReM0JF1JKmsGKP20YXIvE=; b=AghOEDIRN6KOrdIRue05WqKnQwq8+Wi8/PvjNZiHrKbTxMMsjXUCcNu5mg2a9TLT2I8U3MyUJCiBOHluCmB4crJ3GSC9mGtyXHyibeDoL2aSe+OYyQb88IT+dWCAJ/vrOw/3H5F8pfQl3yff8ZZlWw4V2Gc+u2b3AQ0VW7w8S9i35C+1RHzu51j92Rg0nzMaralUqeMqQhQ9wlC9IAIC6SK4CznxULUHZiSpaF3xblWbt4PMDHadvveekyu6iE1vvy0et+9I+A/5t5X0SD1MTukbHd8kEZJ5gjbCaxwdnV2liC//vfJVk6nNY6M5qtmbWXXmirM6ixwbgr8Ha1gEow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dcQ9oHjMEvTxEoarpbDOixReM0JF1JKmsGKP20YXIvE=; b=nAPdAzFhUOFBeX6y/y9jU/ZwzDsMXIGFwPnFVuGncLejczv06yHsEBSRz/Dqx4JDi7Ro4SdrFyT6V4sPEBoBvpQOZmn++UOG6C5GEz6nSGJ5r8SdZD5i0FmUh0XvPnsbYfKZwtprEfDO0JwpXUIjfzpDi7m0+SMosANIb2BWpaY= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH] docs: fix path to code in migration doc Thread-Topic: [XEN PATCH] docs: fix path to code in migration doc Thread-Index: AQHYZHcRr9TbxpP3i0SxnIwSV1knLK0YKY0A Date: Tue, 10 May 2022 14:21:31 +0000 Message-ID: <8c92b56a-bd7b-b91a-5a18-1865ab5b5e98@citrix.com> References: <20220510140506.64930-1-anthony.perard@citrix.com> In-Reply-To: <20220510140506.64930-1-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0999524-235f-4b18-b022-08da32906123 x-ms-traffictypediagnostic: BN7PR03MB3890:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vt1KfUbI/wBXhEKH3R2XB+7e+UwlFt+CbU2BSGYfrneLi0ASYdmEVEfdSzGpDHZLP+Daq1h8/vp/NDjWZOVE/aE6cV2sUSzgKncmn01/HiOyhdDHEYcyKkfpZFubUOAtAGKc98+pt4oWA1jNQWoIDm+bb1DdEvuYhRrgcQkNi7fmK9z5rAH66Ho+hY9Ujg0C8gfzpiCo1V4iTgofoxuaeCyeviOeDk1/B6Ivp5bRjjpfts0KWFfhGPl8dd3piPg0xl+6C44auVMpXgff0RIgyeO1cdlH7Y3tgLOwyqW0GjZhfcOlqan1rDyu72i/pN8xkt5HfHAdi1I+O3iBMDEzxG3igzHtHh6uczTwUH/1pUlBj7yetCXH89lnu9ZWmGyGyZNzO9Mvu+TidkJ8wJZR3Znb8EeRknTdIQbBII/b+uEmSWJKJBtA7T/gpGwBsx+J3VAB6j/dw20Bebv6Qr0QJW2CuDil3iJR4X4aHyCGGBUGKq5ppZ+z6Qst3WoYqdWUKGjOn3ClCe4X/5UjxYZwuR4IXa+ZoaOvlHFo6lWOJ1Ipm3zNIMGICGFEII03rs9rcFdfMdgu1yqQarDyhXJF1+ftzD1YCaCE6vTqPlggiKezgfnHS7FEu62siSpyx7CJpx72alZJYHHfj959J98hYR47gnHgSwjbyhsSx/C7a0HctLs6GyAgJ+mmCj3amf+8vrOKpgteKrQd84htlqZGqMe3vwINE8jITzCRrgihumemfXTE4tbgyxtYq0Y5jGnqmZxFwrUFYjXY4Q20H2r4rw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(31686004)(2906002)(508600001)(6486002)(6512007)(82960400001)(26005)(31696002)(5660300002)(558084003)(36756003)(53546011)(86362001)(8936002)(2616005)(6506007)(71200400001)(186003)(91956017)(8676002)(4326008)(54906003)(38070700005)(38100700002)(110136005)(66946007)(76116006)(64756008)(66476007)(66446008)(66556008)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UlVjdS82L0ZDU0U0NU1jeUZ0R1lMSlljNzhBcnhpaVlNZTNydm9GR3dFVTZ1?= =?utf-8?B?T2tpaWF0SHhmaG8xS1Uva29LMkM4Y2Q1cERHcFA1ZFdHQWhWYUxkVm03cENL?= =?utf-8?B?dTVTenl0cHNZdExLT0E3YlhFS0Iwc0lYNjVMcTJFMmJXOFpEcEFraWk1Y2d6?= =?utf-8?B?N1FsbWhMNmljY2t5UjVPUzlNTWNFbGRIdmZieXJtVEx0b09uTW5pSzJXaDNr?= =?utf-8?B?M1NzUmFtcGxoZVdlV0tvTS9EUlN6N1Z0RTQvaUwrSHhFVmRZRy9vOU40TzEz?= =?utf-8?B?bk91RWx2YjNlVmM2NGpMRElwdXJiSVdtSllzczlLZW9OaVZITVJTd1VqZ1RT?= =?utf-8?B?LzgzRHd2YnEwaXBlT0tVRnZKeXM4blJpeHcweGVCc1NXeXNjajRQbkNRRE5s?= =?utf-8?B?RTlObThIQXhoNXF5VXd5dklrQUdaRFM4dW50cEh4TnZKaWZmL2ZYcjkzYUQ5?= =?utf-8?B?TTl4MmFKcGhMenFUWlNBS3B1c1N2cVNCbVpWZnJrbHVicERsYnZUTDBOOUdi?= =?utf-8?B?T3hTaWt0MlEvUEMzSm9xZ2ZYUnJ4b1Mrc2kxOUREb2FnSitvTGhWMS9rN05l?= =?utf-8?B?YUlJcXZrdnBmNTBXeG9kQm1NVGlpOFVZN1YrLzRpeWxFWFZoemR2bCtEc3N6?= =?utf-8?B?YWdvWXNUUU01ZGRXeG9Dc2FLeFZyUzNuZTlDVTVzTnRqREFSS2VPa25UUGl6?= =?utf-8?B?SkxyeEFLbjN1ZnBtQzBSb1UxQTZLTm92YzlLZUJLWUtjR0dMZmUyTFhYc0FG?= =?utf-8?B?TlcrdHlRazlmcWdBRkpsckJ1SURsTmJjcUVRTjkvemJTa0hTQmk1eU1RcVp3?= =?utf-8?B?eTIxMzhwQy9adnJEU0djWEIxdVhwTWsydjlCd1U5Mi9PN2lBV2VQNnZ5a1Vq?= =?utf-8?B?dVByY3lGVWw4S0s5NWdtZ05uUmtjZ1ZiTmg1TkYwTXN5ODNpMi8vU2h0TFlx?= =?utf-8?B?MG1sd0RiMTNYenFJQmxHZzNBRDhsZzdtV2pkeXJCNTNzSWFOSVRmTUFpdmZ5?= =?utf-8?B?YU82d1Ayb2tUYmxXbFhybjc5bzhxS2NRM2U0aFJQZ3hoUEVqajlpVHAySkps?= =?utf-8?B?dG5jUkFJakpFamY1ME0xL3hLUTBsSzdDS3YyWnZxaVViTFJ6TUxTQVJiWlhF?= =?utf-8?B?QXNQL0RWaWxlTUdUWWttZ0o3ZWltVzNxRGhoaFQ4QmppczdxSEtnYTlsaGIx?= =?utf-8?B?U0VYM3JUVzg0NER4TjBqcWI0QTM3L0FyZzIzbmhXSFQwb0RuamdvbjVLUGE1?= =?utf-8?B?WjV0ZTZKdnJ0cGVqQ2tVUnlkbmZiQmE0Tk00cEh6M0krY29KcndVeWt1MkhU?= =?utf-8?B?OFkrYkt3d3RpdlhYSmh0U3hHbkpPbHhwK3BLdkZGbXRaWnFwaHF0MTNiTS9H?= =?utf-8?B?cXg5WlkzK2puay9EUFh0WUJWNWFwRVF1OUJtQkZMQnYzZlJKWXJSMWMrR2Er?= =?utf-8?B?c1E2QXA1ZzBzc0t3clhxVVFNZ0xudkwyRURLK0xJMVMxRDVCOFFoR21Fa3pw?= =?utf-8?B?d2lBSDNZejE0YTlRMGg0TDFpYlQzTk1kNk9JSFc2L3RPeHUzelZ4d3V3RHFo?= =?utf-8?B?TnQyY0RKdlVwaFl6N1Nvcy9aQis5elBSOXg3WitUS3pxa1ZGTU5nSXB2M0NB?= =?utf-8?B?OGtId3cwMVpNNjY4Ly9lazZJSm5iOWt4NDRsRUNhLzRWS2dIWkMrWUhVZzhI?= =?utf-8?B?WldUWkVZVWdBczdYMGRxSmd2eW1xVU1vWmNLdFVEWVp3U0tGQXI1ZFR1cG12?= =?utf-8?B?dmpqWDhnSXVKaUcyTTd2THBJdjZENW9jSSsyMUtlKzVJZkl1UjNaN2dVRUlK?= =?utf-8?B?V2FpZGdUaUovLzhDZ2NsU3d6dGdmZjBlVW5NRkR6cHYzTHpnczdzSHN1WEZK?= =?utf-8?B?bDZkcWFSUU5ZakZscEFiM0V5TG5SYVVsVXRWcytidWRaeEhYSC9vZm16SVhy?= =?utf-8?B?K3piMmJvTVBYeWlIcWduUUg5bTBPelVXQlc0aVdPV0s1SFdsb3plWDZ4MEZj?= =?utf-8?B?cDQ4Z2hiOGNNdUUzV1hWeFRRVTdXdlB3azNCemtHTnZwTDBhamxsbHkwZUp4?= =?utf-8?B?UzgyWEU5WTFCMWswalJlMGRzS3JCT01JbzlPUWU5Z0RtTldrdm90a1dJS0JN?= =?utf-8?B?TnFvbEtjSEF6REYxZVFjblNkUzFZcXpEYkVoTVltRExlT0Fyc3VWLzZDdnp1?= =?utf-8?B?NGJMQ2oyL3M2Nm4rWlFLUmxCOEwrenBsdTI2TEw5NFl4OTc3TndlVnc2L0hu?= =?utf-8?B?L1FwNW1FbVhWNlZIck4xMk5iMExhN1RYTVFnMmVyS2JCUEhyUG1aSEFwYjlP?= =?utf-8?B?WGFGRGF1VjFlaG1mWXA2bS81RkRJZks2RDNKdkprUlJhNDRQUTZpdytJbDFC?= =?utf-8?Q?a2XwyntC72FTOCoo=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0999524-235f-4b18-b022-08da32906123 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 14:21:31.2286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w19b4FyBlEWQg1c0DkkAiKqXeiIsvDJSAKrOwKHQgwjeIvoXGhE2kP1h3tZ1Jesl/aretJ/HUwPTYZjvzVB6D1tmYj62iF7wb+atHVhG+sw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3890 T24gMTAvMDUvMjAyMiAxNTowNSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IFNpZ25lZC1vZmYt Ynk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpBY2tlZC1i eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Tue May 10 14:28:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:28:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325724.548419 (Exim 4.92) (envelope-from ) id 1noQqg-0004Xz-Iv; Tue, 10 May 2022 14:28:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325724.548419; Tue, 10 May 2022 14:28:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQqg-0004Xs-EW; Tue, 10 May 2022 14:28:26 +0000 Received: by outflank-mailman (input) for mailman id 325724; Tue, 10 May 2022 14:28:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQqe-0004Xm-Ql for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:28:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72a3f512-d06d-11ec-a406-831a346695d4; Tue, 10 May 2022 16:28:23 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3A80421AAF; Tue, 10 May 2022 14:28:23 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 344FF2C141; Tue, 10 May 2022 14:28:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72a3f512-d06d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652192903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5Vk/8pdLWJKvC1pkcnRQ/HwoU2ABECojPYTjSUx9JWI=; b=qCuBe8399OKc/XhS2YM19THr9x0w+LK3v0+yrYrVMx1O5y8bO2nhr7ld/xwzdNWpoeMnQv KDbf9vzeiGs4Zk4jc5/KyT1Cq3WiPlflRqYiR6m11RKyyC/hq4LcZ09p+y2XB4Mv583rFK /mj4yXQtU5XfZ45MAwfj3oDOrq6/m9Q= Date: Tue, 10 May 2022 16:28:21 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Anton Ivanov , Johannes Berg , Richard Weinberger Subject: Re: [PATCH 11/30] um: Improve panic notifiers consistency and ordering Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-12-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-12-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:05, Guilherme G. Piccoli wrote: > Currently the panic notifiers from user mode linux don't follow > the convention for most of the other notifiers present in the > kernel (indentation, priority setting, numeric return). > More important, the priorities could be improved, since it's a > special case (userspace), hence we could run the notifiers earlier; > user mode linux shouldn't care much with other panic notifiers but > the ordering among the mconsole and arch notifier is important, > given that the arch one effectively triggers a core dump. It is not clear to me why user mode linux should not care about the other notifiers. It might be because I do not know much about the user mode linux. Is the because they always create core dump or are never running in a hypervisor or ...? AFAIK, the notifiers do many different things. For example, there is a notifier that disables RCU watchdog, print some extra information. Why none of them make sense here? > This patch fixes that by running the mconsole notifier as the first > panic notifier, followed by the architecture one (that coredumps). > Also, we remove a useless header inclusion. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 14:30:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:30:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325730.548429 (Exim 4.92) (envelope-from ) id 1noQsi-0005sh-Ut; Tue, 10 May 2022 14:30:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325730.548429; Tue, 10 May 2022 14:30:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQsi-0005sa-Ry; Tue, 10 May 2022 14:30:32 +0000 Received: by outflank-mailman (input) for mailman id 325730; Tue, 10 May 2022 14:30:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQsh-0005sS-9z for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:30:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcaf9753-d06d-11ec-a406-831a346695d4; Tue, 10 May 2022 16:30:29 +0200 (CEST) Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 10:30:26 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA0PR03MB5386.namprd03.prod.outlook.com (2603:10b6:806:b0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 14:30:22 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 14:30:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcaf9753-d06d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652193029; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=lDOPjqJ1geWMZ2Fz7X6osdAZYk3zcCHK9ulS6mQtLgw=; b=E9Vh9fUjVuw5N2Qu9mSNgwJ66ANMi6rmXuRxH5XDdIEgLhz5JVUaByW1 4cVjDnGB2vA5vT1lbUT7LzkzNPjg2dTKchOmGgZkPI6o2hUkQqmrb5S/q YkOB8LDokvY/g6CIh+9hspVIhhVepISVHxJCXvDZPbsUVLwodj63gZ+16 Q=; X-IronPort-RemoteIP: 104.47.55.101 X-IronPort-MID: 73473834 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jICCOajaIqF4J/XuQGmMyKVsX161bBEKZh0ujC45NGQN5FlHY01je htvD2uPbqrfYjSmco1wYIuz80gCu8XQmtQ2HQNl/n82FyIb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrV4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTkVHYbou7QxaT0CUAJZJqNgpbTeIGfq5KR/z2WeG5ft69NHKRhueKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehW9p7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wnJ+vFnuDS7IApZl52zHPSIINWzYu5PwUKBu zvJvH76HURPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7CxAIVF39vfiwjGa/Xc5SL wof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xHmEZShZRZdpgs9U5LQHGz XeMltLtQDlw6rucTCvF8q/O9Gvrfy8IMWUFeCkICxMf5MXuq50yiRSJSct/FKmyjZv+HjSYL y22kRXSTo471aYjv5hXN3ic695wjvAlljII2zg= IronPort-HdrOrdr: A9a23:EoQq2KEE3ykyVnq/pLqFe5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+txKH LajfA31waISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0md gsAp4Y642mcfVmHJ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="73473834" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXFPXUuTSacc4BllRLTlx1sG5pTdi7ltkiCoXrGZu+zctMyziruF0LWGd2lrMUXd28paikHTVjHU2EYgzUf+CMtRodQzBBK7cTSomXQCZSjqADtfVlHvP+fv3LCsxJdxQSNqQhL5kWvD9PApnR0tW2sFQHnzQsscyIHiTzI2t/y/dZ1xPxIXJ0zDVT0q4BIMG4oS0arAzJLhglbPM49Lwx9DCNGPi3R+ngLZgMkC39yuB8/rfulUPyI6PPZyONwva97AovJ0mgIBv41HdmoK83V7k3HECbtdjvQYao5AT6a1tm5QODgg6lEan/Nes3nFnsNhcFruT2RCYbVYb4g+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FkPxeKH8HAYRWYOLD7bIbXYFqahuxamVPN/5WElQmo0=; b=M3esar28zkkwStpeCjAi+9/dYLVutuxQOTwk9MLGPeViTqBv/yjjeYxxP3iYwEvJxbRmwJg56MGnzYPUqzPF2hqen20sjYp+Mmu5BEXeggpGRS/xjW/ETDLbReimyf4+YLouWIRVQIhZ1HbZ4scscbiVda5zYffonz5Nw9h3sedB5lejYar+P2F3TcMf7Zy1MxaJf/weEto9u9ZAlYB0mImiobwDY7SylWLPQvTkbLp2szurIeruc/gxWrOiPIAmzD+iMwovgqHHDBiq39Za35lNN4vv7oJJ6VoXGH7K2th5xmeIeiwhwH+rim1QWTeyOaK0Zoqu1ZxX/rbqOkL0zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FkPxeKH8HAYRWYOLD7bIbXYFqahuxamVPN/5WElQmo0=; b=a2gQgbeEqTMrmw9JXaPQ62Om/WM6iZXHLKf+fuyYxVvrVlR/Ob5o0FfZqsKIGxzmpdnICeVXu+bEAWQ0acVhHKcjiHIKIVUj5pSIx+9Zn7MItk/af7InWmA5Bmrgcx/3XHPYSPFJ10vXN6GQ26Mc4vwi5wsVi0fVTwwKzbUx0yQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 16:30:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich , Kevin Tian Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0277.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61b37809-bd35-46fc-cf3b-08da32919d83 X-MS-TrafficTypeDiagnostic: SA0PR03MB5386:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EMfgQr77yHUM3rPSqOZqrwP0prwHm9O740UnNEGIO8b9NytptIX+NbGHN5XBmXQ0mJrKj6V++2vIRtpWqm6AV8ZNxQIMXhXjBxkyC+a4k5v6DMOi9KZtmk6LtGkc8eH8bLPq0Krujbq25O/CrwTRytirdnBnDIN/WbJgFXt1jCuwjBt4/b4lK2kFHrK1NsZ43UTVikOF/NFRFAGp2RM42ijD86SvjL1dyLzN6MdHq0/Fo4KTkMPIpzflphnOpZQDg4EUxpVGzOqQWVznj3VfNZ/yAY78YxDMFgh4Yt49JmgeD9gHntxEkMAGHDoU3tPB1T5w3co2xY1A+5WS+vaTbe7htLSs5GzwdPXZ5J0m+yx48MYkGA48ZU19LE3yoE7SubSHi/h2xh+yIqSv3DF7KhNLbJVmezUNts9Vo3C54BZPX7NMxuXUWMKM5B36/sr5667JWs4djOmAUxiCuJ0G/86kFHL884K7aJuIxMnXyhfSOvTW2C4Fz9T5jryU3Gv1gMTHNBN1Vh8f0layIBDYIHb3eQtT6vshag586QZSlPPFoM13nfLbc6vikxGbPu9tf47ZjuuxJkkafcrkVqpXFJ17u4i6PI4i89SRdqIiLAHxLMsLwZR5/V+4SWywxDzrsR97KP7gfDNsFOcm/gTjHwmSigro3HSLNvd4cst/WYA7fO1g5ndd7RYOBY+85OcRKjGJ+DyeB2yojRrcoYQ/+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(316002)(9686003)(508600001)(6666004)(66476007)(66946007)(6486002)(6512007)(66556008)(186003)(86362001)(82960400001)(110136005)(2906002)(4326008)(54906003)(8676002)(38100700002)(26005)(33716001)(8936002)(6506007)(83380400001)(5660300002)(85182001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVdaaGhtaU1CaXdOSFRVM0V4WmRYRUp0b0N0YTNMZWRKTy9YWkVzN3UrdGd5?= =?utf-8?B?Sm5PRW01MHZDRFFPbjVRMW9sZEY5NGM2QkdBSlFxU3l6UVluSWdpcGxqVmxM?= =?utf-8?B?OEYwTVNKWXJLZGZzZlpOOU1rWHR4NldzMkYwVlJOUnllUGRKbTVIUUtXOWpn?= =?utf-8?B?bStUN1VHdGlkWEpoajZZZVRBQTgydnp2NzJmQS9iREhFSnhMSTltb05KbTdL?= =?utf-8?B?YVpGVlZKSkdjKzE5K1pGNmFUbldjZFNPN1JkM2w0bmF2MHJBVFNUZm1LSlVI?= =?utf-8?B?bTVOS0h3SC8xRUZkNWk5QTUzSTgwVklXbkd2ZEZWYTJ6VTlOMU9hMEtOQTZG?= =?utf-8?B?NlNRLzh2NjJzNE41eFFEdmRJdnkzbDQvL2FkS2RIRi9MMWlacy8wUVNkWDhI?= =?utf-8?B?czRGektQckZKRTF0dlhveTJwWnVLUkdpZzEvRmJza2FJRDNsOCtBVEpLR01H?= =?utf-8?B?N1NPcWRId255cVdHVS93UWdyVkJoSmltMHcvdnBPbk95Rmt3MkxPTGMvamRP?= =?utf-8?B?NzlldzA3cVhLWDcrSE5EOUhYTjBmMU1KMzJFQmdiTGdFMVRyOEtrY3c1VnhU?= =?utf-8?B?SmZjUmhyZUNNUEN2NnF6ZmxlRlQreXFLYkxqRHF5eENmVzFiRk5BQmFsYUZr?= =?utf-8?B?dVg5bG1oWGNmSUFRVG81NmNJaHZyNTFKTFdNV0RVMkEybnBlOTAvdGNPT0Jt?= =?utf-8?B?N0RCY214Wks5YWdGOVplZStwVjByL0VJMTFJYktvK20rUWk0ZG1ZM0tlZnZy?= =?utf-8?B?a0tBekVjWkYyL3JpVStCWStiVldoWjRzRnZKVFcwWjMybW9DUlVsWkRzanpo?= =?utf-8?B?cWs0MVUwczhlSWwvYmRDY3RFS0ZTQ3h5aXJMMWFXTkY0M3lCcktmeHZ0UGNu?= =?utf-8?B?dHBKKzROU2pQNU9mbnJudm92eVdZT2pTeGpDU2Z0c1hxRVNRcmRhWWhzVGs0?= =?utf-8?B?eUJQc3lzVlpQNTlaWkxZRjJYRkpwMGRuVS9nR2V5T2RLQXc5aGpQL0E5b3o3?= =?utf-8?B?M2ppL1BiWC9GMGxaUTJDTzQwMUNDR2tKOHNDYloyeEFXOVlmT2liNEpQMXIz?= =?utf-8?B?OXc3ZXFLT0JkUzJ3c3lwYlB0VE5rOTlIbEpKUlBzMjB6MFpiRjg5WThZelBq?= =?utf-8?B?bGk5ZmgxNmtLNGNLUVhidVFwOVQrVitMZWFIaGhwaHQyTWUveE9FS0VxMFE2?= =?utf-8?B?N05nQjRrNEx3WTNUVEZndE11elQ1azJVTUptSFJVVWVpOFlWczg4RnEySjFU?= =?utf-8?B?OUtUR0huSnp1RVZzQk9wM2xHVDNhYWNudUFtcG1LeFZNS2EyL0drYUdtQmRI?= =?utf-8?B?ZVliNjdoL2tYRnpLa2tHNzJTMmxDaUhOTEFuTXpuYzd0Q2pGMWlQT0NBdHNr?= =?utf-8?B?REdpaEVoZXd0MVI3SEQwMVRVZ1g0MjlvVjlDbTliV3p5VGRuSGFPU0pLMjNt?= =?utf-8?B?MjV3UEFIejdzOENob0l2YTFwN3B1azZSbWRvL0J1Qm5uRm9SL1M0MndHL1ZR?= =?utf-8?B?akRNb04rUDN0RTdTNXJORWV5VEpHQzhxcTJmNFJkU1lUQUtyRDJEaFNEZy9I?= =?utf-8?B?N0RGVHVEYUhJMDFQRE5WcWVIUjhNWVA1Wk9vMGl3Z2s1d1J3NkdPUklraU4r?= =?utf-8?B?dStyMW83YU1XeU5MZzN0aWJwOCs2b2RaR2szbElwMWl0SlRBbG53ZHVZeGtx?= =?utf-8?B?dUM5NzdYR1AyKzNnSFk2RTJoQUZHSjZtVWVOZDJ3SzlJYTNjNGt2aVNIdzNR?= =?utf-8?B?WlMxK08rc3hvUEk0LzRCYmhvUXZRTXpxRVNDSU9lV1gweWR2ajJmM1pNd254?= =?utf-8?B?ZEtJeHJ0N05NaFY1MURpWUZkckpWOG1UcTBpNUp4VDNxek9lSXJPc081L1gw?= =?utf-8?B?ZmRBaDhkS2pUMktCWExBSWRITXQ2VVZ1UzkrMGxOOGlCb3ptdE41WTU2MzUz?= =?utf-8?B?cmxsM3pWTXlpRmg3MmJEZDJkakpnWUJrMm1QbS9ydE1HVm5wOS9IeHI5cmo1?= =?utf-8?B?cFJoRUhuWGk1ZnU4cmR6TjkrN1RjNFRxVGRpaFNMS2s3SlpqU1BZTTFNUVZ6?= =?utf-8?B?dDNtcUZSeFNZb1NtVmZ5Y1hZa3Y0SzRNY0wrZGxNTWlYN0E2Wi9ydEFtV3M4?= =?utf-8?B?bmNvWTUyWnFXNTZhNnBzdHFLc0I0dUVuMDdnNkFQelRlM1gxSnFrUWl6QSs0?= =?utf-8?B?MXhkMzhwb3NhWFUyYVhkWmRsZlZKMzJGWlNOek13eG9pLzZPZkUzV3k5YkhT?= =?utf-8?B?YU0xUmFZRWpEZ21MVVBxWmVMOWZXRC8zZXp0UEVaQlJWWkxKVjVlK3c4K1JJ?= =?utf-8?B?QmlibjFrQWwrU3JVWVRVMWltdVcvRHlSYXZUbEtxN2pjNkZSVFVyNFBJSGZm?= =?utf-8?Q?EjBaKkUZSUtjYlag=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61b37809-bd35-46fc-cf3b-08da32919d83 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 14:30:22.2061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IQ2JDEZfg7SbBpY/16wXm5ppR6BAHQ+invleG3LhgZ1Y2jnvSB0/P9Qd2QmaZXST+GdAg3091S9+brUce9f49A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5386 On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: > When a page table ends up with no present entries left, it can be > replaced by a non-present entry at the next higher level. The page table > itself can then be scheduled for freeing. > > Note that while its output isn't used there yet, > pt_update_contig_markers() right away needs to be called in all places > where entries get updated, not just the one where entries get cleared. > > Note further that while pt_update_contig_markers() updates perhaps > several PTEs within the table, since these are changes to "avail" bits > only I do not think that cache flushing would be needed afterwards. Such > cache flushing (of entire pages, unless adding yet more logic to me more > selective) would be quite noticable performance-wise (very prominent > during Dom0 boot). > > Signed-off-by: Jan Beulich > --- > v4: Re-base over changes earlier in the series. > v3: Properly bound loop. Re-base over changes earlier in the series. > v2: New. > --- > The hang during boot on my Latitude E6410 (see the respective code > comment) was pretty close after iommu_enable_translation(). No errors, > no watchdog would kick in, just sometimes the first few pixel lines of > the next log message's (XEN) prefix would have made it out to the screen > (and there's no serial there). It's been a lot of experimenting until I > figured the workaround (which I consider ugly, but halfway acceptable). > I've been trying hard to make sure the workaround wouldn't be masking a > real issue, yet I'm still wary of it possibly doing so ... My best guess > at this point is that on these old IOMMUs the ignored bits 52...61 > aren't really ignored for present entries, but also aren't "reserved" > enough to trigger faults. This guess is from having tried to set other > bits in this range (unconditionally, and with the workaround here in > place), which yielded the same behavior. Should we take Kevin's Reviewed-by as a heads up that bits 52..61 on some? IOMMUs are not usable? Would be good if we could get a more formal response I think. > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -43,6 +43,9 @@ > #include "vtd.h" > #include "../ats.h" > > +#define CONTIG_MASK DMA_PTE_CONTIG_MASK > +#include > + > /* dom_io is used as a sentinel for quarantined devices */ > #define QUARANTINE_SKIP(d, pgd_maddr) ((d) == dom_io && !(pgd_maddr)) > #define DEVICE_DOMID(d, pdev) ((d) != dom_io ? (d)->domain_id \ > @@ -405,6 +408,9 @@ static uint64_t addr_to_dma_page_maddr(s > > write_atomic(&pte->val, new_pte.val); > iommu_sync_cache(pte, sizeof(struct dma_pte)); > + pt_update_contig_markers(&parent->val, > + address_level_offset(addr, level), I think (unless previous patches in the series have changed this) there already is an 'offset' local variable that you could use. > + level, PTE_kind_table); > } > > if ( --level == target ) > @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma > > old = *pte; > dma_clear_pte(*pte); > + iommu_sync_cache(pte, sizeof(*pte)); > + > + while ( pt_update_contig_markers(&page->val, > + address_level_offset(addr, level), > + level, PTE_kind_null) && > + ++level < min_pt_levels ) > + { > + struct page_info *pg = maddr_to_page(pg_maddr); > + > + unmap_vtd_domain_page(page); > + > + pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, > + false); > + BUG_ON(pg_maddr < PAGE_SIZE); > + > + page = map_vtd_domain_page(pg_maddr); > + pte = &page[address_level_offset(addr, level)]; > + dma_clear_pte(*pte); > + iommu_sync_cache(pte, sizeof(*pte)); > + > + *flush_flags |= IOMMU_FLUSHF_all; > + iommu_queue_free_pgtable(hd, pg); > + } I think I'm setting myself for trouble, but do we need to sync cache the lower lever entries if higher level ones are to be changed. IOW, would it be fine to just flush the highest level modified PTE? As the lower lever ones won't be reachable anyway. > spin_unlock(&hd->arch.mapping_lock); > - iommu_sync_cache(pte, sizeof(struct dma_pte)); > > unmap_vtd_domain_page(page); > > @@ -2182,8 +2210,21 @@ static int __must_check cf_check intel_i > } > > *pte = new; > - > iommu_sync_cache(pte, sizeof(struct dma_pte)); > + > + /* > + * While the (ab)use of PTE_kind_table here allows to save some work in > + * the function, the main motivation for it is that it avoids a so far > + * unexplained hang during boot (while preparing Dom0) on a Westmere > + * based laptop. > + */ > + pt_update_contig_markers(&page->val, > + address_level_offset(dfn_to_daddr(dfn), level), > + level, > + (hd->platform_ops->page_sizes & > + (1UL << level_to_offset_bits(level + 1)) > + ? PTE_kind_leaf : PTE_kind_table)); So this works because on what we believe to be affected models the only supported page sizes are 4K? Do we want to do the same with AMD if we don't allow 512G super pages? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 14:30:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:30:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325732.548440 (Exim 4.92) (envelope-from ) id 1noQsy-0006G7-BP; Tue, 10 May 2022 14:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325732.548440; Tue, 10 May 2022 14:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQsy-0006G0-8R; Tue, 10 May 2022 14:30:48 +0000 Received: by outflank-mailman (input) for mailman id 325732; Tue, 10 May 2022 14:30:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQsx-0005sS-87 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:30:47 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6b25436-d06d-11ec-a406-831a346695d4; Tue, 10 May 2022 16:30:46 +0200 (CEST) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 10:30:43 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6949.namprd03.prod.outlook.com (2603:10b6:a03:43f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Tue, 10 May 2022 14:30:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Tue, 10 May 2022 14:30:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6b25436-d06d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652193045; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xd+pqv0zgKIEDhjCh+UnuP1k0P82s3oSW9CqZZhRKRg=; b=FZDTK4HrX844MXOYqTiubdaMWVepxvhRDElHfR82b/ybDMHhXhiVCfZr gEkT3Md7aaANjAi+VL7NUXMUy9TWxEIKpNqgOi+ktlqpGZlqk5tGfSFyA zKxqnCnTuy3WEtz2Pr001Ke9puJpGbW8OhJDlHh+SYgzaMJoyJ8xEOEw3 M=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 73473881 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xsEMEKBifatBNxVW/xPiw5YqxClBgxIJ4kV8jS/XYbTApDIg3zMGx mZKWz2CM/iJZTejKdsnOtjk8R8B7MOBnYdkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2tYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh96 P5KkaSZCj4yI6LcktY/fyJ5NSRxaPguFL/veRBTsOS15mifKz7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mbG80m5vcBtNs0rulIEezTe Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGYE9wnF9fNfD277xQwqk6fJa/7pId2wZphNuHq4r 2PM8DGsav0dHJnFodafyVqpj/XKlDn2W6oTEqO57f9ghFCPxm0VBwYSXFH9qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAPQkqcs3SDoCx lKP2dTzClRHq6aJQHiQ8rOVqzKaOiUPK2IGIygeQmMt/N3LsIw1yBXVQb5e/LWdi9T0HXT8x m6MpS1n37EL15dTj+O84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComVPlhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:SIToBqizlF62dn+UrqyfyJ3Qt3BQX4N23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqaJbp0 X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="73473881" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZph9p7M4SFpMpZvuBoaKjIv9ormIkhki4/85M5WiyPgCuNBhM/27EoJRKhUbnU249b3ViGxZJ+X1b+UoNBAGUrbUCBMVUMgH1i4Y4pNw7GCkgqutDjRQzelhvbv3/65ETj1O1Hh49BmwJxH927GEXlWuRIndpDnmGfOsiyz3iKCsGkXn6crJnANnYA3k8GQ1ufEaoqzfMth0OPpJoQkE1hMbGr+jWorRDit8IT/AQbKCiAH+mxZ1W4DtxXzYg/fwS5znVJWphHgd8x3NEXGrbq++GXjwnXqgUUn9pHFq2qRMh24NBuBrbzZ4oCpxGTCbTrXY4/LJeiEEztEAYcqxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xd+pqv0zgKIEDhjCh+UnuP1k0P82s3oSW9CqZZhRKRg=; b=Ukc8kCFfogoFzNAZ+oeesIeHosyTjYyG+a4x9YRKKsKUitJ/wQCGxeatudaZf22J5YcTW+8SXlEnjvwHF3JKXx/c1L3V2SEUJNh0R5bnGqizIrU1avQA0q3i6qMH+KPvaYIz6DR/13Jk3171k1mlsRKxgAD/KC5rozlFlM3xjZRr8KAWI70R5pwPRX5SaRqudYlB8yCVsFfQsjzivrY5kY2LZ+DPpt85IUv2hjifLYY7VbTkjQ/ri77kSfAwJcIZKoPl2T3DOuDocyWLLPDOWC7lEU1/NDkz1Ff3HKdpPJWshVyxdTC3VZ3Ceuuu+8n0D19fzx6ZoAj9VbyiFQ6p6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xd+pqv0zgKIEDhjCh+UnuP1k0P82s3oSW9CqZZhRKRg=; b=Bf+6QtzrwesWs5dC3QcIK3++ghC0I8CDo3HT5u1fXBm7OIG+EtEeAUjJy252gJFnE30bn9Gh20ELl6Q9pWcvqVrMttXWwi1KbUqLaVWd1kgIeb6oc0+KX2ugpD/WWid4VrPRtOwuKtlsmBmvUGcBAobKMRHdPmxfOrVylN/8Wxo= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi Thread-Topic: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi Thread-Index: AQHYZGTv0L0FedIJ8kmYH2hX6mR3t60YLEEA Date: Tue, 10 May 2022 14:30:41 +0000 Message-ID: <4ed4e4c3-6b71-8299-69f4-7910583fd9cb@citrix.com> References: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> In-Reply-To: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3b0864b-cff3-4ca4-2942-08da3291a91e x-ms-traffictypediagnostic: SJ0PR03MB6949:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DfEN7NfyY2X7iM7LfBzQvtDT2c9ciC4axAd2vYewGazAXez+7M6XzQxCO2PnWiYurX/f6nBMdQtnZP7x/oziEqn/nrHIsnI/kEHRO/9pmTXlXQ03rt9u+eVCcE9J/kyVuNSSElf80recIzvAUqHcnnsXOoUA3JTTWD0AAhQk0m4ceE2p7CQTjAP9t58M8KUONW2lsmuJy3HANOfNqUaW3VNDbs/2TSzI3GAgufazabHy0mQOcYRa3mthFBvLpcdGWQtmKR9Kt3EjWsOXEYaVaNc4euUsCmmzrgPo3/r+xIiQeDFqhWrCHtXclJ9H6v7C/qI3K9Tpa75zc3OR3sGj9VJ+YtQ2WIcrzRGMW0AURpchCy8pOUStPH1cSeiMOt/QM9uSTd68AClsQK3/KZ+52omdV3e/zCSMJQsIXhu8/yVfefaq0aI8YtOqBLsjDHfqSDS309PThEfu9ODdDaPfVGpvoQfrzhKjE5cdUHvYic/h0yRy/CagHEnatuA6ER4sRFzZDdD/1xqJiBDC/uQzS28YjT08yyQd0+30YBXOnUl61z9mLFJXzvapEa44U5ZsRzVpGW4rmuoBqTVYw+PSV/OXADBb4/u3xV9tQHiSgDd5NtUOETKfD5KwqVsJKcF9pPqHSzVgLJgECFMxObRHWMK24TvwN6OKgsGQA0Reo3Gb/BDIvyfg0co2lt3oWIr8Ws+a+M1qVy0eLsvhb0INM28BckbtRuKshrOwIaERY31OwgkKCveXxGT+2z9+3P+dtH3s1/u8MR7HK8UR67My2g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(31696002)(66476007)(53546011)(5660300002)(6506007)(83380400001)(26005)(66556008)(91956017)(31686004)(4326008)(66446008)(8676002)(4744005)(76116006)(66946007)(6512007)(66574015)(2906002)(8936002)(186003)(36756003)(2616005)(508600001)(6486002)(71200400001)(38070700005)(38100700002)(86362001)(54906003)(122000001)(110136005)(316002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1dqL3VrQzFIcnFmcmNkRUR3S0tHVk5WcXdNb3FTb29ST08xRGQ4NXBIeUN2?= =?utf-8?B?aEVFOXFFcXZCbm1waVR0VGxwTEVidk1RWnU1WWVEQlBmbWV0aDdYUm91bUdP?= =?utf-8?B?cGh2dnpkdlNwZFZWQmozbTVTRkNzVU8vVmpxWEdOa052N3I0Mm4wcWpjMWVt?= =?utf-8?B?NUFhbUJ6cllHMjJUTlF1RXBaLy9TQmg4SFc3cThnYXppUUl3Q0xQY01HSXpt?= =?utf-8?B?cUd2V2VLWUtoU2NIWGZMSTNkSURxNHIvaFAvYU9uVlFPbzZZUmVTaDdud1Fp?= =?utf-8?B?YTlWNWZtWWtjSnRtUkNoR0ZIYU1SYllSRGZYVkp4WTY2QVBPbHpGQmRMTXN1?= =?utf-8?B?NUljcGNrSkN5WURKdGFYUzRSTjlPNEMzd3BHYTcyejIrKzgyemNmYnVzMDB6?= =?utf-8?B?WitVQkMxTFIwYlIxRGNHTjR0a2lMMnM2THZYY1VMNThzMUl3cGhtK1NUZG5h?= =?utf-8?B?U3IrcnZBS2tHV3hIakFsRzZ4Nk9FOWhOejN2VDhqb1hINUl0MmozdWhMcmtY?= =?utf-8?B?YVVFS1JELy8xRjM5OFBvczJ3RWhuYWduRmtocjg0ZlNUS3NWMlRqUVQ2TWxE?= =?utf-8?B?ZGNCN2xPTUFiWitGSzFwRFM3cFZlNGpmMjBnbDZlRzdrUndTcE9xRk55N3dG?= =?utf-8?B?MW0xeWF0QThlS2toc1NaU1RvbHQveHpMQkJPaTgrcDhHVGVUZHZyK2ZYeUMz?= =?utf-8?B?ZnhzMGkyR2Z3TEh2VnhqUXB6V25qZ25JMlREUWtiYWpEZUZHNzlsUmo4Nk5N?= =?utf-8?B?YXV3MzdJNS9rS2trd1FTNEhUU2I2L1pXZFpSUGJNUUh5Q3JmNGlCUVF2YlJv?= =?utf-8?B?M2hUU01TL2VHUlQ0Z0dROVpDNnZLdURqTzdkYUJFRXo1ajAvMUJsVFFJb0JS?= =?utf-8?B?MUR2TVkyaHI4Z0ViL0dWaldPY0ZzN2hTWHczaERQc0dOaER0aURlZTBXampm?= =?utf-8?B?b3BRZUhvdnRlaFZZWmNvclp1enpxb1FnYTM0dGFGSCtUVWMwTnFkYnZFNmpO?= =?utf-8?B?M2Z6cFFIV3B1SVY4MFRKVyt4b2RTODhvS3kwcFA4VDFSN1d6REZrcUl4VzYz?= =?utf-8?B?akVWS081Rjc4UUY5dCsrSU1iMzltTnBBVTlEQjBVblhxdktzTW4zRW9sWVps?= =?utf-8?B?OU1zaVhQbmEyM0ZBRzh4bkMvTFpkNjZYVFoycG4wczFSYnVhTjc0b3RISXgw?= =?utf-8?B?UTU5QlFkYVc4OVpqNmVwS0w3M3JSd2UrdjhYcUI4ME8rQUlreVBxNXpBZ0NC?= =?utf-8?B?SC95bkRvSkxFQUM1V0hHSVhXR0ZFTlgvUC9oS3VDZ3gwYktCZS93NFFKajgr?= =?utf-8?B?emdFTlFIR0s5dmJmdmpBd1NQRndtdlFHMGdtc0NMSFM2R1A1NnVObUpDWi9B?= =?utf-8?B?OVZ4cFhYbWxtU0krZlNoTE5IaDZsVTBCRjQzWEZrQjkrSHorV3dteUhRcWVQ?= =?utf-8?B?MkhNUWwzNWoyQjQ1Qnc1ZmNVb1RENXkxUDhzQlgvSGhCV05UdmduWVV3OHZF?= =?utf-8?B?Wm5DeDhNOEFJRG4vYndjb1JVdk9FQy82dTF2eUVIZGRhcmRBWTA4NHNwTThL?= =?utf-8?B?TkNnTFU1aVNMTnRSUUZ2V0tzRzF5OEY4NGVuTXg3dHVLaWJaYXlMYnhHMVdS?= =?utf-8?B?bGREdXU3TXN0TXdjYkxQMFZSQ3hWUEQvak0rWHRJbDJnZ1BzaTFtTHRNSGxl?= =?utf-8?B?MFJyOHFpOW1TcTVGS3FLVG9Xd29NZERFNlBmODBBY1p5MXRjRnV5SkNOc1No?= =?utf-8?B?czNlOEJ3OWE5c0x3Mm5mWDF6eWw0MU9VcEdrazNFTGZVeUV4alFUMGppZ0V4?= =?utf-8?B?SVJtd1RWT2FITlJBOUpMWkhVUW5aYjJmTGNlS21QaG5JSWh6WjBRb2paY1p1?= =?utf-8?B?ZGVKTFlROHZCeW9RalhyMDJsQ1phd281byt2SS9TZExGcWlETllSMGRTaGRU?= =?utf-8?B?QW5HWFR6M2xBbWRraXRaYXVFN1VVMFJXZ2kraElMOEF5dFMweXRYdXNSQnFT?= =?utf-8?B?a1RDWmRXeTJZWENKNnZUaWU5Y3pmZ3NFLy9TOHlmYTRhVG9BRDFidENqblMw?= =?utf-8?B?MjlzOVhIcmNyeFQ1dFdUbnVZeGxDbTJWVjlIbGthRnVQTURDTUxyRjJzTU1k?= =?utf-8?B?clFrZ2dRUWFxUjF3b3RwWDJrTWZRV3hEWXZJcXZyOC9lRGkrMS9RUE8zZlR1?= =?utf-8?B?ZE9EOWt6SzlLL1RDYUlqV0xsZlRzUUhyOEJLRzV4eFhnbGZlMDBMQVNrM2RG?= =?utf-8?B?THlUZCtnQm9uZEh4eDVwdXo0UU9NYjEyK1JNUVUvc0ZHOGx4OW1rd0tMZ2tu?= =?utf-8?B?NTk5MjJxbjc5dm9qeS9OQU5UN2h2b1N5SG5PWmtzRDVzMnBVNVVrOFBHRHJJ?= =?utf-8?Q?qdViGW8XncIUS2kg=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <424A7FCEF8D170488468D8C1709AF330@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3b0864b-cff3-4ca4-2942-08da3291a91e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 14:30:41.5006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BZP4ihRA3Zzpx7C54p3MJ8ut/+525OafL7xBkcFTWppL8AEJiOOOONmd0Yef8M+OiuA8GNwonwm6VTsngr5j0isnVkm8vbDHq6F4y+dOIe0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6949 T24gMTAvMDUvMjAyMiAxMjo1NSwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K PiBJbnRlbCBMUFNTIGhhcyBJTlRFUlJVUFRfTElORSBzZXQgdG8gMHhmZiBieSBkZWZhdWx0LCB0 aGF0IGNhbid0DQo+IHBvc3NpYmx5IHdvcmsuIFdoaWxlIGEgcHJvcGVyIElSUSBjb25maWd1cmF0 aW9uIG1heSBiZSB1c2VmdWwsDQo+IHZhbGlkYXRpbmcgdmFsdWUgcmV0cmlldmVkIGZyb20gdGhl IGhhcmR3YXJlIGlzIHN0aWxsIG5lY2Vzc2FyeS4gSWYgaXQNCj4gZmFpbHMsIHVzZSB0aGUgZGV2 aWNlIGluIHBvbGwgbW9kZSwgaW5zdGVhZCBvZiBjcmFzaGluZyBkb3duIHRoZSBsaW5lDQo+IChh dCBzbXBfaW5pdHJfaW5pdCgpKS4gQ3VycmVudGx5IGl0J3MNCj4geDg2LXNwZWNpZmljLCBhcyB0 aGUgc3Vycm91bmRpbmcgY29kZSBpcyBndWFyZGVkIHdpdGggQ09ORklHX1g4NiBhbnl3YXkuDQo+ DQo+IFNpZ25lZC1vZmYtYnk6IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtA aW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCg0KVGhpcyBpc24ndCBpbnZhbGlkIHBlciBzYXkuwqAg SXQgZXhwbGljaXRseSBtZWFucyB1bmtub3duL25vIGNvbm5lY3Rpb24NCmFuZCBpcyB1c2VkIGlu IHByYWN0aWNlIHRvIG1lYW4gIm5ldmVyIGdlbmVyYXRlIGxpbmUgaW50ZXJydXB0cywgZXZlbg0K d2hlbiBNU0kgaXMgZGlzYWJsZWQiLsKgIEl0J3MgcGFydCBvZiBQQ0kgMy4wIGlmIHRoZSBpbnRl cm5ldCBpcyB0byBiZQ0KYmVsaWV2ZWQsIGJ1dCBJU1RSIGlzIG1hbmRhdG9yeSBmb3IgU1JJT1Yg ZGV2aWNlcyB3aGVyZSB0aGUgdXNlIG9mIGxpbmUNCmludGVycnVwdHMgaXMgcHJvaGliaXRlZCBi eSB0aGUgc3BlYy4NCg0KQWxzbywgdGhlcmUgYXJlIHN5c3RlbXMgd2hlcmUgbnJfaXJxX2dzaSBp cyBncmVhdGVyIHRoYW4gMHhmZi4NCg0KSSdkIHJlY29tbWVuZCBoYW5kbGluZyAweGZmIHNwZWNp YWxseSBhcyAibm8gbGVnYWN5IGlycSIsIGFuZCBub3QNCmludm9sdmluZyBucl9pcnFfZ3NpIGF0 IGFsbC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue May 10 14:32:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325743.548451 (Exim 4.92) (envelope-from ) id 1noQv0-0007O0-NV; Tue, 10 May 2022 14:32:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325743.548451; Tue, 10 May 2022 14:32:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQv0-0007Nt-Ke; Tue, 10 May 2022 14:32:54 +0000 Received: by outflank-mailman (input) for mailman id 325743; Tue, 10 May 2022 14:32:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQuy-0007Nj-Uq for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:32:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 118c426e-d06e-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 16:32:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 118c426e-d06e-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652193171; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=wtDnE8O9gH7ClDAx5krhI8a68miaq6DilvRU+KMtMkc=; b=X9hLoULZv3LtXOyHvSvf61xlE7mr2NZ6rZb6QsOA1jIl6qwHppJN9Sjz nenX2q4hWi32b4PUpbclTgAgA1FqXvvlTJ/Jq+F14k4g06RFEImQqK2RG MtbQ/4Kyu/3zdMFUmpLGXz8FCnpybBUssliRS865mbUatIEWWq9XUYq57 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70372801 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:8FF75KD2uwdNcRVW/zrjw5YqxClBgxIJ4kV8jS/XYbTApDsmgjIBm 2MXXGiFP/2NMGr1c9t0bI229U1Su5bQm9RjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2tYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhp+ tpdrp2ITD1yM/3zvrUXUxZWMh1XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8WRqmEN 5JAAdZpRDrcTh9LHncQM7UZhf+Gq2S4YQx/q03A8MLb5ECMlVcsgdABKuH9eNaHWMFUlUawv X/d8iLyBRRyHMOb4SqI9DSrnOCntSHmXIMfEpWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwajvHeOsxoYWtxRO+438geAzuzT+QnxO4QfZmcfMpp87pZwHGF0k A/S9z/0OdBxmKWnRmKG94+Rl2i/aRczfGUCaiElcSJQtrEPv7oPph7IS99iFou8gdv0BSz8z li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBd7YaVUwYnY1RvHNEghBHFb5JOhtDMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/W6TI68CaCEMoITCnSUSONg1Hs1DXN8Iki3yBR8+U3BE cnznTmQ4YYyVv08kWveqxY12r433CEurV4/trigpylLJYG2PSbPIZ9caQPmRrlgsMus/VSOm /4CZpTi9vmqeLCnCsUh2dVLfQ5iwLlSLc2elvG7gcbZfFU8RDF6W6+5LHFIU9UNopm5X9zgp hmVMnK0AnKm7ZEbAW1mskxeVY4= IronPort-HdrOrdr: A9a23:2qc6QKpwP2R2F4oc/CfVWYcaV5oTeYIsimQD101hICG8cqSj9v xGuM5rsiMc7wxhPk3I+OrwXJVoLkmxyXcY2+Ys1PKZLXDbUQiTXeRfBOnZsl7d8kTFn4Y3v8 pdmupFeb/N5DBB/L7HCWKDc+rIruPozJyV X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="70372801" Date: Tue, 10 May 2022 15:32:45 +0100 From: Anthony PERARD To: Lin Liu CC: , Stefano Stabellini , Julien Grall , Andrew Cooper , George Dunlap , "Jan Beulich" , Wei Liu Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, May 10, 2022 at 06:15:22AM -0400, Lin Liu wrote: > Update to use byteswap to swap bytes. > > No functional change. > > Signed-off-by: Lin Liu FYI, this patch breaks build of stubdomain: In file included from /var/tmp/git.xen.lU52/stubdom/include/../../xen/common/unxz.c:124, from xg_dom_decompress_unsafe_xz.c:40: /var/tmp/git.xen.lU52/stubdom/include/../../xen/common/xz/dec_stream.c: In function ‘dec_stream_header’: /var/tmp/git.xen.lU52/stubdom/include/../../xen/common/xz/private.h:31:21: error: implicit declaration of function ‘le32_to_cpu’; did you mean ‘le32_to_cpup’? [-Werror=implicit-function-declaration] 31 | #define get_le32(p) le32_to_cpu(*(const uint32_t *)(p)) | ^~~~~~~~~~~ /var/tmp/git.xen.lU52/stubdom/include/../../xen/common/xz/dec_stream.c:393:7: note: in expansion of macro ‘get_le32’ 393 | != get_le32(s->temp.buf + HEADER_MAGIC_SIZE + 2)) | ^~~~~~~~ cc1: all warnings being treated as errors make[2]: *** [/var/tmp/git.xen.lU52/stubdom/libs-x86_64/guest/../../../tools/Rules.mk:150: xg_dom_decompress_unsafe_xz.o] Error 1 make[1]: *** [Makefile:367: libs-x86_64/guest/libxenguest.a] Error 2 make: *** [Makefile:73: build-stubdom] Error 2 Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 10 14:32:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:32:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325744.548463 (Exim 4.92) (envelope-from ) id 1noQv3-0007eQ-0p; Tue, 10 May 2022 14:32:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325744.548463; Tue, 10 May 2022 14:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQv2-0007eH-Sf; Tue, 10 May 2022 14:32:56 +0000 Received: by outflank-mailman (input) for mailman id 325744; Tue, 10 May 2022 14:32:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noQv1-0007YI-LM for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:32:55 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12a23e21-d06e-11ec-a406-831a346695d4; Tue, 10 May 2022 16:32:53 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 10:32:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5747.namprd03.prod.outlook.com (2603:10b6:303:6c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 14:32:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Tue, 10 May 2022 14:32:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12a23e21-d06e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652193173; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Ju6sxl7BTQQt7i4sdoh/6ePyA/3BMcrJMDf7/lSoxK4=; b=KIZsxo0hGSXWiweUhMHkloBHWSRWMHALi/Z7U41R2vR/UJngf9pJSBaB 01cgR7rRDtmlms9FJJ2rfgcv7cwXrr3g+q9UOKw9LKoUts7YVc2BVDs9D KEBSY0gajsIL6lNg9FQOL99BySpFm5clrnrK8LGA+ZHTSCZPOCilDtj7M c=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 71388041 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZnLAdaj2vmD8CwFJ56N65zu7X161WhEKZh0ujC45NGQN5FlHY01je htvC2vSMquMNGqnetskPYripxsA6JXTy4RkHQNuq3gzF3gb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrV4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTwLI4HxnNgQaABnKnAvDbd5yLnJL1Hq5KR/z2WeG5ft69NHKRhueKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehW9s7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJoujODnFQtidABNvLvS+asVMkLl3yF5 XPK0lTEXR1KDt+2nG/tHnWEw7WncTnAcIcbDrix7PNpqFyV2G0ICRcSWEe7oP+2kUq3UZRUL El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/ l2Um9LkAxR/vbvTTmiSnp+Pti+7MyURKW4EZAcHQBED7t2lp5s85jrQSv5zHajzicf6cQwc2 BiPpSk6wrkW08gC0vzj+Uid2mrw4J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1UdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:vHxho64bKIZ8oE3NvQPXwVuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJXa Z1oaF81kqdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbkidzk7hdcAoqJ/lp r525RT5c5zp/AtHNNA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="71388041" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQUb91l8e0jofSDqjsN9zOy8mAJcnqyJHmTcNlv4C4QQsyi6vM5GSfC9l6Mf3caONM824zdbwKwK5v2RbPLqJFCiGTBnzcsTiD8jjpcuHq5x4M7VdBEBz9XOCmHeEHg4XAMDN+5b2H5GmLNEzdtq13K0CVxcgJ6JVWDgkKSPvaGvSV67b+cddz0Xd1o9hb/ZnlIncycTQEZ2R0ROEWmZSWboaKYUDZq39KbfFcBJLOJ9ZhJEW1YFoxXrpGaVG8cTUVQpw/UcoA7l0GIq/qI8fMKfuh0WeAVEdn9mTQ24furbPWDHEYb4EkCJgYNfORg4R4cT3uC/PYbYbL+O8adHSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ju6sxl7BTQQt7i4sdoh/6ePyA/3BMcrJMDf7/lSoxK4=; b=SY7fb6OX6JMD+fc2Q0QCctBkKEMzpVdv0fs4vv52jDK5S6eixodn2I+R6Pxa/ipQSqdNEeCcNII+0y+wWn6NNMnQ0PP7Qck/Bkmqyg/6MJ0CisLEvQnu+YY4lmRubTjYExfKxZ/JrYTangKvyybO4AnUkHcU2V68Pj9Xv7jz8t2Ke9h4QSPh3hf9sqBt1SF1MTmBjs3TtkUa/P0oj/8fgUv3o+9Ijrzh6bxLJkG6BTybI44Gua0rsI8geeIIsZ9HHso4mcY/Nw+vYrxwKbz1NvbhoJzQJ16FN+qY3YJPDKskD0YnBqwvEYqgQ+OgNsZjh1/ax3+BC1rUCgzs/geQDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ju6sxl7BTQQt7i4sdoh/6ePyA/3BMcrJMDf7/lSoxK4=; b=PtWJjVammeqR3YBPNQ1DafOYpD8Ymf0QuGa0t3H2YbLwiChY5v3++T6ljyLeTqNJvjpmvM50CAiDo+XSf9QluFkJUdU4+Zl9WnIvKhlttcItitWlx9+SUqAbQm4VcHF0tWGobhSeet8Kee7rPs6FF4ts/iOclh8jbOV1g1QBn94= From: Andrew Cooper To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 2/2] ns16550: Add more device IDs for Intel LPSS UART Thread-Topic: [PATCH v2 2/2] ns16550: Add more device IDs for Intel LPSS UART Thread-Index: AQHYZGTwry5z7hjdYUSw2m/jzUjDja0YLNcA Date: Tue, 10 May 2022 14:32:47 +0000 Message-ID: <065c1ae5-d25e-5939-38b0-3473d57dbfd6@citrix.com> References: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> <20220510115546.1779279-2-marmarek@invisiblethingslab.com> In-Reply-To: <20220510115546.1779279-2-marmarek@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08b774bf-5329-4e3d-3b6f-08da3291f3fb x-ms-traffictypediagnostic: CO1PR03MB5747:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jOkG6lN/GIhuoUGPlqbPTeOG/pWTx1oiyXrYD1e1qfT9+tcgdWe47c+WacAeElmFHjE/apye1K5uJJXgJBTyDo9jamlbbsUiRl6jPIve/KV2oS8bi3LcXjNzdPLnYJm+0JgC6+wXassQFFLDLWXVX+LxVVHqhga9RNQ5IgOJhA6TPaq8ZqD6p932vxZgrftQq2WDxNp23/FwFds+vGcZ0Bkzq7pz/mKvjM0KqsN81KrjBIY6qOj+qEAclqlrkD0NuwH9Xbod3uJuJI40q3NHKB9/ony9Nxp6RvJ2UzWbxzbCUdxf3Puyl8sUtnItRfFAC3cepAl3rYxVndd4Lv0n1+YIMO3Os1npre51FyB6aERQNgXWRUfmn7eYheWcdcWSowvP5epbF3PlTlEmz3Vkp/HRCeZb+7VFxXDrT23CwbvWwoPJuM/jpI/MjF2j7nDLbOACXOyoeK8DoU1tuw+bucgt5djQmENPIR9EU2xkzM6JADWADK0rTh7qeHx1F+5xtlE20CVsFlgCdrZfawjzvhSyN26H1DIOFqEVA9FsajR08mkOUcQlGGGYpPohww2jaUmFu77QMehmwwE1EhA6V6Bu+uBcjxv+cECgsM602eD5y0x8XGO/P7Tzj/a9+jMUKaC8BleXLEfK0SWalevJnwGLgCV1OhyYy2qc8VK0AIxmkkhHLDUoz6X2w9qHHAdR/akHhquVolB/3k6/7eywjRcFB8cTzXtupwSYTa+srV220k71dDyxY6Dqv75BYVsUjD9+eDu6JtAuG/PfhLk1rA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(31696002)(26005)(66446008)(64756008)(71200400001)(4326008)(8676002)(2616005)(6506007)(53546011)(38070700005)(8936002)(508600001)(6486002)(86362001)(2906002)(66476007)(36756003)(5660300002)(54906003)(4744005)(31686004)(186003)(110136005)(316002)(66556008)(66574015)(122000001)(66946007)(91956017)(76116006)(82960400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?THpaUHFYZHNmM21kK2oxbnNheW12MldNdmg5TGh1TTB3bjkwSEgzTHNTSDNC?= =?utf-8?B?K3Q2T3ZxNHo3ZHJCeXhpTHRBd2JUNjhiLzdhSnZuQjhwVnlEamkyTzJnMXF5?= =?utf-8?B?bVBvUzExcHphU0pxSW1RSDVVVlBqdTluVWhrbW9vVGt3M3p0V1VKVlRMRTk2?= =?utf-8?B?ZmRwM0FXOHUwQ1U4eWZaZURHeUkxS2d1ZlY5RnExV3Fqdys0K3lscVNFcDRD?= =?utf-8?B?UFYyK3hWMGlQUXMzMExkY3NJL3Y3aVdqdHpsbENrSmpMK0cxS05PaEZ5Vnh6?= =?utf-8?B?d3FndHBrSFpMckRiZUtvSHNjSTMrZ2pRNGN2dGZuUmgrclAyODhoTEcxMFM1?= =?utf-8?B?SVN6SXdFVlh5Vks5UkJnbG1ucGY4SEIvU1plNDdFOU9uSEJHRjgwZ1I4Yjhk?= =?utf-8?B?YklDR3EwWk5qYXE2ck1PYWdoenNZZ1VLclExc1hJZ0dDbGZsbkkyalVoZW9J?= =?utf-8?B?QzBRQWtMWTA2eGZrdysrWWhOR1FNOFZiYUFxeXZSY3NlbEp4cHRLcTltVHQy?= =?utf-8?B?QnE2T0VmMWdUQzlLK1hPSUJFR3RoRm9RM0N1QUpIanRKSWtCQk9TWkZNRjNm?= =?utf-8?B?M1o4SThWRkp3cktLMkNBYU1ESmpwdkpsU1kvdUxEL0t6eHZTWDJMM2RzSmlx?= =?utf-8?B?S08vWXY2SWxqZHRGWW8rbG95ckFLeDdpUzJScW56ZnNBUVBNUktwRzZLZjg5?= =?utf-8?B?UXAzZHVlOTFJSFAzdUhubVVERlc0TDljak4zaDhIVllYL0h4cURoWUtnNW5z?= =?utf-8?B?ZUV1M21IaEFTMFRkOXM2NkxXVDBvbEFTUTNWQU9vald4N2lkem5DQ0tUZUR4?= =?utf-8?B?cFJjOWRyUWRtbXpVc2lZUFl5blZ4eC9xdVdIV1RMOGkvNGZ3czYydzVzS3ky?= =?utf-8?B?bDRieFNZMVdNZVpqTm5JVkNiQ0NqdnhMNkdmNzJVczN6TmRCVzBoNCthOTFO?= =?utf-8?B?N01hczZaZnVDcEkycms5UUFkTGRmdzlWb2tyZSs3TWtlSWVCT0czRm4xNGVV?= =?utf-8?B?NW93WjdmWmVHdXBMbmN6N2RnNnNzaFRFMDV6bVFabGoyYnVlOWNRZUNVM21r?= =?utf-8?B?ZG8xVTRCelZDMG94RmF6TUFoWnk5RzgzQWdnSDZscldEUm1taGNIaFZRRUhX?= =?utf-8?B?amQ5SXVKMjRWbHRjUTBZMDJyOXFqU0pkaVFaRVppYUswd29aRzRtWnY5NE5R?= =?utf-8?B?R1dvOVZTQkduNTFYeTYvWjMzSC9MNWFBdzl1VlhUQXNOemdxcUUrbGk2SnpZ?= =?utf-8?B?ZW1rS2pVU0RVUHBIUTdvUVpKVER3S2E5QjVIRG9hUi8xR2UyV0hGbFBSSjVp?= =?utf-8?B?S1BRV1pXY0swM0dvTzBpWm1VYlJJK1FVZVN2NEF4UlJYR1FVWHFQU3VKNDg0?= =?utf-8?B?UzlHcWdDVXU2NVhUZFg0SWg1eXFHZXRpNU01TWY3WGFXbEwySEU1SUNmclJE?= =?utf-8?B?S3dGZno5TmRhaU5USkpZc2hrbXNTRXM3V3pjdWpicExySS82czVxUzNJS3lU?= =?utf-8?B?V2V6NGhKT2NCeDRGRG84eEdSYnhJVHJpTmxPVzJINElnSG1xWnFKMUpkcCtZ?= =?utf-8?B?Z01TeWJGM3htd3N2alRFanlmZFpKSEJuUHZpWW1lWU5xOUc2Z1JYRG9KTEVk?= =?utf-8?B?VnFEWW03RFVwd2NGRkliWUgySzNseS9kUDlkMTdQVUltcENpMjdQTHhPNzNa?= =?utf-8?B?N3dTanBwblRCQ21VQjlpa0hEakpTa3o1cXZMaVJFQzd4blBNTnhhTUJXaHlZ?= =?utf-8?B?cVZuZ0ZNV21Qd3ZCWUwvM0RVNWMxbWUwR2ZnSlpLK2V4UmFGMm1sREc3RXM2?= =?utf-8?B?cDg4aG1nZlh3SnlWcURwVFBoYmRmRjl0U3dtZ3Z6TmZOcnZnS21XRXFFazQx?= =?utf-8?B?dllsN0hCdkJQenlzeWlwM1hSSTFmd0d3ZncyTFVjT2VTV08vRHFlOElsSkFv?= =?utf-8?B?aUtSNFV1MS9mNDVxbEVEMG54WUJkVDd5ZnU0Kyt5andDQkFzR2RacHdGdlgv?= =?utf-8?B?QktEa0lTeWFCU1JVYlNnaHliaGNLKytzNnVEMFF3OURoT2VKVkU2cWtSNU9P?= =?utf-8?B?aXRqYXd0LzdMeUdTVE5BMTFzQXA1dUFnd3p6QUlFVUl0QUtyWTJoeTlCeGcw?= =?utf-8?B?TWtMVHRmVU1HNHdZWlpybDJVeDM2enc5cWhTdm84VnQ4TEFMQ2thOE5JdWZa?= =?utf-8?B?RUJXM0IvTVExeGRGZzB5eFpWbXVLL1FhR2dQdG8vNTNqdFhWaStyTVBqUWpu?= =?utf-8?B?OThWOCtqbUxqUDdqQkdHQWR5WmE1LzBjQ29wRTVoNzdjZmxFdWJ0eGwvTnNl?= =?utf-8?B?K1BVOVhQUCtJOVVlR2xVVjhLRTVvdUZ4ZmtVZGNJL0Fkc0cyNlhKSGtaT1lw?= =?utf-8?Q?8xNOA0rM0pEHHX+4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <946070373A46374FB4ACECD1E46F1497@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08b774bf-5329-4e3d-3b6f-08da3291f3fb X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 14:32:47.1009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tKg8efihyn3epM8JZqQ+oRruPyAWpRigYqtGLRNxn2DHs3jk34Vj+1oTdaUGKoNXkk/7JHVHROWxFXBRoZhvHK+HgXB4N2giAmJm7q/A4Kc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5747 T24gMTAvMDUvMjAyMiAxMjo1NSwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0K PiBUaGlzIGlzIHB1cmVseSBiYXNlZCBvbiB0aGUgc3BlYzoNCj4gLSBJbnRlbCA1MDAgU2VyaWVz IFBDSDogNjM1MjE4LTAwNg0KPiAtIEludGVsIDYwMCBTZXJpZXMgUENIOiA2OTEyMjItMDAxLCA2 NDgzNjQtMDAzDQo+DQo+IFRoaXMgaXMgdGVzdGVkIG9ubHkgb24gVEdMLUxQIGFkZGVkIGluaXRp YWxseSwgYnV0IGFjY29yZGluZyB0byB0aGUNCj4gc3BlYywgdGhleSBzaG91bGQgYmVoYXZlIHRo ZSBzYW1lLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kg PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K From xen-devel-bounces@lists.xenproject.org Tue May 10 14:48:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325760.548474 (Exim 4.92) (envelope-from ) id 1noR9H-0001Q3-FW; Tue, 10 May 2022 14:47:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325760.548474; Tue, 10 May 2022 14:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noR9H-0001Pw-C2; Tue, 10 May 2022 14:47:39 +0000 Received: by outflank-mailman (input) for mailman id 325760; Tue, 10 May 2022 14:47:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noR9H-0001Pk-1a for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:47:39 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22989335-d070-11ec-a406-831a346695d4; Tue, 10 May 2022 16:47:37 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id ch13so5015753ejb.12 for ; Tue, 10 May 2022 07:47:37 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id mm8-20020a170906cc4800b006f3ef214e0fsm6154690ejb.117.2022.05.10.07.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 07:47:36 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A9F3D1FFB7; Tue, 10 May 2022 15:47:35 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22989335-d070-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=W3yGCrbaYFPykUPOkYnuLOD+M3hzMOScuN1dQar5WWM=; b=xRetRa+lauzpMF2OsULe+0aNxpjlaERQU2RpXPXZZSauOTIqLOjulWf/bQ5h6awHeS 6eU2UpZlI7cYZrBOg5l58lx5tB8V/N8j1GpX5EvY3zxHZwSc8lLUfrx7vAid4ABUANNz RnJjpMDbsSAMTHy1byc5IHhK4iQsSf8OYgj587G3WZ9yB3KDIIVgqvn5JrZvw4wIsp0m AVx7iExnWB7J85DMkpooq/0HyH87kAkqXYzUNVEuhUjJCBF4nUd5dhxQpSSbwxS0bkLl u1JkyK103tajA63E8UgYV3JYjjwBg0x8zc4DHePSibCTXYdDa9mf6f3tpAGXqFCWUOzs A9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=W3yGCrbaYFPykUPOkYnuLOD+M3hzMOScuN1dQar5WWM=; b=uJNizYjScM2Hy94aqBbYiYwAOl8aoCiGuwr7YMjZqiggMWRWqQt4l8Yri2VYC48C5y XzNCdKQBrgtAvrV0UIq6HOAWn711rrw5f4xi5jxvOpx2864CyOf6xHpWuUdS9ou81zIa NsUmtJKhDniaI3UnkTdvrJ6WX8PFFX533DgDVO8J42/YSV/YCdIxDgtXMTh33cbUVgBP jcFEJZd4xQ7v/MkiqwelWrBrXWD9N8SxkRJ5eLqUPRH6s5SKh4LeEtFakOuuyOJakCMn Jgksu5feSW6scrp4cnVaxuyk2mJ/NoKphSs7iTaz97TYffB39JENNQsjHhm+LnV5JgOp jgAw== X-Gm-Message-State: AOAM530VE02WoCqG5Jn4zexnydB44qNqlvf3mUo72YQG93ucTiYs57jI NEhDQfpzEhUDlTcrNPRbwbMRdg== X-Google-Smtp-Source: ABdhPJzPjehPR4R3Z5rwxN9u72FxbVjoaFreZPSv3+64ZfMoJWnvEL/2ZfVya31cYzeBT/Y40eYZMw== X-Received: by 2002:a17:907:3e94:b0:6f4:64ad:1e2 with SMTP id hs20-20020a1709073e9400b006f464ad01e2mr20095469ejc.464.1652194057391; Tue, 10 May 2022 07:47:37 -0700 (PDT) References: <20220428103410.2723837-1-alex.bennee@linaro.org> <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> <8735hhtrfd.fsf@linaro.org> <191159cc-f26d-f161-3f44-431507a6c270@xen.org> User-agent: mu4e 1.7.13; emacs 28.1.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Julien Grall Cc: xen-devel@lists.xenproject.org, stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw Date: Tue, 10 May 2022 15:47:04 +0100 In-reply-to: <191159cc-f26d-f161-3f44-431507a6c270@xen.org> Message-ID: <87y1z9sauw.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Grall writes: > Hi Alex, > > On 10/05/2022 15:03, Alex Benn=C3=A9e wrote: >> Julien Grall writes: >>=20 >>> Hi Alex, >>> >>> On 28/04/2022 11:34, Alex Benn=C3=A9e wrote: >>>> When we introduced FEAT_LPA to QEMU's -cpu max we discovered older >>>> kernels had a bug where the physical address was copied directly from >>>> ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits >>>> the same error by blindly copying across the max supported range. >>>> Unsurprisingly when the page tables aren't set up for these greater >>>> ranges hilarity ensues and the hypervisor crashes fairly early on in >>>> the boot-up sequence. This happens when we write to the control >>>> register in enable_mmu(). >>>> Attempt to fix this the same way as the Linux kernel does by gating >>>> PARange to the maximum the hypervisor can handle. I also had to fix up >>>> code in p2m which panics when it sees an "invalid" entry in PARange. >>>> Signed-off-by: Alex Benn=C3=A9e >>>> Cc: Richard Henderson >>>> Cc: Stefano Stabellini >>>> Cc: Julien Grall >>>> Cc: Volodymyr Babchuk >>>> Cc: Bertrand Marquis >>> >>> Acked-by: Julien Grall >> Will you pick this up via your tree or do I need to do something >> else to >> get it upstreamed? I guess it needs to go on master and last stable? > > We only have one tree in Xen where committers (such as Stefano and I) > will commit patches regularly to staging. Osstest will then push to > master once the testing passed. > > I have done that now. Interestingly, git am wasn't able to apply this > patch. I had to do with: > > 42sh> git am --show-current-patch=3Ddiff | patch -p1 > patching file xen/arch/arm/arm64/head.S > Hunk #1 succeeded at 474 (offset 1 line). > patching file xen/arch/arm/p2m.c > Hunk #1 succeeded at 32 with fuzz 2. > Hunk #2 succeeded at 2023 (offset -7 lines). > Hunk #3 succeeded at 2031 (offset -7 lines). > Hunk #4 succeeded at 2062 (offset -7 lines). > > Which branch did you use for sending the patch? 0941d6cb23 from RELEASE-4.16.0 > Regarding stable, I will add the patch in my backport candidate list > and send a list to Stefano when we prepare the backports. > > Cheers, --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Tue May 10 14:49:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 14:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325766.548485 (Exim 4.92) (envelope-from ) id 1noRBD-00021b-Sc; Tue, 10 May 2022 14:49:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325766.548485; Tue, 10 May 2022 14:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRBD-00021U-Oy; Tue, 10 May 2022 14:49:39 +0000 Received: by outflank-mailman (input) for mailman id 325766; Tue, 10 May 2022 14:49:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRBD-00021O-0V for xen-devel@lists.xenproject.org; Tue, 10 May 2022 14:49:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRBC-0007ra-L2; Tue, 10 May 2022 14:49:38 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noRBC-0002eI-EK; Tue, 10 May 2022 14:49:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=W6XCMEG6/dM4pA6JVqOAkoml7l7XmJbrGPNpkqZW9Ow=; b=M7xObGWDUrXCuPRBJHg1lvYt5U nXQc31Oq62Orq6IyIhScwfEDNbBZOQORZ7ucihKi1c5lPY2xSkzNAxDq2Wf6C4CaQ/kMKEJaCBK7n 98qt0PdJVI1u7N9PJiucA9+W0QgwdmaeMiPmsUpbKLO0QL8puAIX3H9cCXuhJswPeOm0=; Message-ID: Date: Tue, 10 May 2022 15:49:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: xen-devel@lists.xenproject.org, stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220428103410.2723837-1-alex.bennee@linaro.org> <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> <8735hhtrfd.fsf@linaro.org> <191159cc-f26d-f161-3f44-431507a6c270@xen.org> <87y1z9sauw.fsf@linaro.org> From: Julien Grall In-Reply-To: <87y1z9sauw.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Alex, On 10/05/2022 15:47, Alex Bennée wrote: > Julien Grall writes: >> On 10/05/2022 15:03, Alex Bennée wrote: >>> Julien Grall writes: >>> >>>> Hi Alex, >>>> >>>> On 28/04/2022 11:34, Alex Bennée wrote: >>>>> When we introduced FEAT_LPA to QEMU's -cpu max we discovered older >>>>> kernels had a bug where the physical address was copied directly from >>>>> ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commits >>>>> the same error by blindly copying across the max supported range. >>>>> Unsurprisingly when the page tables aren't set up for these greater >>>>> ranges hilarity ensues and the hypervisor crashes fairly early on in >>>>> the boot-up sequence. This happens when we write to the control >>>>> register in enable_mmu(). >>>>> Attempt to fix this the same way as the Linux kernel does by gating >>>>> PARange to the maximum the hypervisor can handle. I also had to fix up >>>>> code in p2m which panics when it sees an "invalid" entry in PARange. >>>>> Signed-off-by: Alex Bennée >>>>> Cc: Richard Henderson >>>>> Cc: Stefano Stabellini >>>>> Cc: Julien Grall >>>>> Cc: Volodymyr Babchuk >>>>> Cc: Bertrand Marquis >>>> >>>> Acked-by: Julien Grall >>> Will you pick this up via your tree or do I need to do something >>> else to >>> get it upstreamed? I guess it needs to go on master and last stable? >> >> We only have one tree in Xen where committers (such as Stefano and I) >> will commit patches regularly to staging. Osstest will then push to >> master once the testing passed. >> >> I have done that now. Interestingly, git am wasn't able to apply this >> patch. I had to do with: >> >> 42sh> git am --show-current-patch=diff | patch -p1 >> patching file xen/arch/arm/arm64/head.S >> Hunk #1 succeeded at 474 (offset 1 line). >> patching file xen/arch/arm/p2m.c >> Hunk #1 succeeded at 32 with fuzz 2. >> Hunk #2 succeeded at 2023 (offset -7 lines). >> Hunk #3 succeeded at 2031 (offset -7 lines). >> Hunk #4 succeeded at 2062 (offset -7 lines). >> >> Which branch did you use for sending the patch? > > 0941d6cb23 from RELEASE-4.16.0 This would explain why. Patch sent to xen-devel should be based on staging (or master). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 15:00:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325772.548496 (Exim 4.92) (envelope-from ) id 1noRLv-0004a2-Ri; Tue, 10 May 2022 15:00:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325772.548496; Tue, 10 May 2022 15:00:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRLv-0004Zv-Ox; Tue, 10 May 2022 15:00:43 +0000 Received: by outflank-mailman (input) for mailman id 325772; Tue, 10 May 2022 15:00:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRLu-0004Zl-GG; Tue, 10 May 2022 15:00:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRLu-000868-AX; Tue, 10 May 2022 15:00:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRLt-0002lf-Sb; Tue, 10 May 2022 15:00:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noRLt-0008Kp-S8; Tue, 10 May 2022 15:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EsSYowAmetEloummZ+oJ3DjgLKLkGxRXKrAnsSGuumw=; b=2vk8dTGL2uD4eZuSBF5RhsmmB9 AijeSfaZOdBN7qJLknoHwzpQwnrh8Mj20fZQncnc2bTeR/wwROot9D1fbBGiWNs0RnfluWKCK7mfh 4lDOpPbDN9U7J7jSV2r1lOOAKEOa4Ub8N6L8qul+9R3Jv6jbsx1dUT3w6YYS9McZ4ZxA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170299: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 15:00:41 +0000 flight 170299 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170299/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 915 attempts Testing same since 170272 2022-05-09 15:12:57 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 15:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325781.548507 (Exim 4.92) (envelope-from ) id 1noRau-0006fo-9Z; Tue, 10 May 2022 15:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325781.548507; Tue, 10 May 2022 15:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRau-0006fh-4p; Tue, 10 May 2022 15:16:12 +0000 Received: by outflank-mailman (input) for mailman id 325781; Tue, 10 May 2022 15:16:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRat-0006fb-3P for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:16:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e26c3bb-d074-11ec-a406-831a346695d4; Tue, 10 May 2022 17:16:08 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 88D9E21BB4; Tue, 10 May 2022 15:16:07 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 2901B2C141; Tue, 10 May 2022 15:16:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e26c3bb-d074-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652195767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OZqtmv8UjkqRBSiOYZ6ar9KDyJT6hDNxXl9SSULCXTQ=; b=fGhdvJlPt//dq0KQAtVijfj/ESEJ/OC2EKpevE2XN9mzQ9A1L9iCAxeXNQ+pUyb1Mv1UlE HCruB1nKt1ZaJRQk1txzbCvkQt9XnVOQap2jC6oxObMWliWuUvAfiBCulbtCmC4sio8+xa +ZqWsGMsijF1KXpHWJf4ANyjUo2sNOU= Date: Tue, 10 May 2022 17:16:01 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-15-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-15-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:08, Guilherme G. Piccoli wrote: > The notifiers infrastructure provides a way to pass an "id" to the > callbacks to determine what kind of event happened, i.e., what is > the reason behind they getting called. > > The panic notifier currently pass 0, but this is soon to be > used in a multi-targeted notifier, so let's pass a meaningful > "id" over there. > > Signed-off-by: Guilherme G. Piccoli > --- > include/linux/panic_notifier.h | 5 +++++ > kernel/panic.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h > index 41e32483d7a7..07dced83a783 100644 > --- a/include/linux/panic_notifier.h > +++ b/include/linux/panic_notifier.h > @@ -9,4 +9,9 @@ extern struct atomic_notifier_head panic_notifier_list; > > extern bool crash_kexec_post_notifiers; > > +enum panic_notifier_val { > + PANIC_UNUSED, > + PANIC_NOTIFIER = 0xDEAD, > +}; Hmm, this looks like a hack. PANIC_UNUSED will never be used. All notifiers will be always called with PANIC_NOTIFIER. The @val parameter is normally used when the same notifier_list is used in different situations. But you are going to use it when the same notifier is used in more lists. This is normally distinguished by the @nh (atomic_notifier_head) parameter. IMHO, it is a bad idea. First, it would confuse people because it does not follow the original design of the parameters. Second, the related code must be touched anyway when the notifier is moved into another list so it does not help much. Or do I miss anything, please? Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 15:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325787.548518 (Exim 4.92) (envelope-from ) id 1noRlr-0008Q4-A7; Tue, 10 May 2022 15:27:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325787.548518; Tue, 10 May 2022 15:27:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRlr-0008Px-78; Tue, 10 May 2022 15:27:31 +0000 Received: by outflank-mailman (input) for mailman id 325787; Tue, 10 May 2022 15:27:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRlp-0008Pr-9t for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:27:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1b::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2a282d5-d075-11ec-a406-831a346695d4; Tue, 10 May 2022 17:27:27 +0200 (CEST) Received: from DB6PR07CA0105.eurprd07.prod.outlook.com (2603:10a6:6:2c::19) by VE1PR08MB4766.eurprd08.prod.outlook.com (2603:10a6:802:a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Tue, 10 May 2022 15:27:12 +0000 Received: from DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::80) by DB6PR07CA0105.outlook.office365.com (2603:10a6:6:2c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 10 May 2022 15:27:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT030.mail.protection.outlook.com (100.127.142.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 15:27:12 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Tue, 10 May 2022 15:27:12 +0000 Received: from 02e0195bea29.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 254059D7-6AC7-4886-99F2-1680B921F0D9.1; Tue, 10 May 2022 15:27:05 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02e0195bea29.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 15:27:05 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB5954.eurprd08.prod.outlook.com (2603:10a6:20b:287::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 15:27:04 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::e020:ec0f:ab1d:c962]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::e020:ec0f:ab1d:c962%7]) with mapi id 15.20.5227.023; Tue, 10 May 2022 15:27:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2a282d5-d075-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=c68OmMRCPPjmMiVzX9UexYsFC6mzDDSPz6C5kGHkCJrEJmNoWh6f2rGgZQkqHN3js70hQFTkfcgz02Z/27nH1xs8Zr2twesmUjnPS21eRyRw550FWKtP+WtJOBAeZFfIgZ2xvNVXI/LCjxAYFE08lTXFu/Av9WN9bUqVV93nJ3ZmqMPxK4RQ4IuL/LV2v94kbWR5WrMsntvlcA5mC605VtfEfldHxhK4ZdahMySbuoG5/FaKW5BYuvsFKe6gA3fWiWHWM1oFnUQsmCmYd561wygV++EVCK34QHpDWeWaUvXuloSAClKvnD1B0H20JwEmev+F5dn3d23L8P9XdcCs/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=TwZkf4wa1PVAjFL5NHfG6YDgHrE5UrfE24TwIr+yWSsiLW3wNB7dqLvKRTPjkDWR+g+HRPJDoaeeEF9dYSH0AM4GTIh2MYLemLjA8MFmX/6NN8calNXRuMQAzP6iIU8G13N1LYtTqoYK/0sIkzLd7816+YtvF6Nwv60PAMtgKr+082XCa2yeuwqwSUfSXznwTiICMTiw4ZCCRKpNX5D1uhAy3iAHndT9Xk0GZ4rS+0o1HT1HGD0k1XEpeK/2XAEokgpgAJwrMrsGMe2sB/9ap7r+0d3ZfXnogotpoJbbpZlCAANr7dUQKqjXbeKwRmU0JeOoeJRe5UdIX81jiAAUpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=Dy5lMAwjuC4DU3w/vG0Kbuyn2J/tYIfhCdUuJgMVeXyJnwE+IjVIWw3oUvBFuVtge2C7LZ4XoHv4EjLcXOdiwAeBTlFlr3M9teHgeFF5my0XDfvpjkMHyp3455AEgedMQpCAFruWQ1bE5dqfo5ACaSTihE8Uz1KTMfjEIlIvA8k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b91a51e1381a7fde X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IZ4TSryOp5539bLO9+xVHevMhVxHUhWXuaKQ5MrES93l7VaRrtO/ZZEYDHUOUUepsJOMH65azGo3vdydackwCi+4FNUQcMk10/it6xEX7UG6H6XoKC1aiwUNs+NnlxWM6Ij6RYH5EqTh51diL8a6F7hJ6uFUm3NfvOlbknwr56NafaRzK4qJsf8hqCjxAElF/sy6q/OOqu+vi0orhmQw/slFYjViQQjP7G2kSt8iSLP+lzbLsxhzHXBXFewB8U/lQ9bJhgSE+hDjRfR4sHNcnThw7LOFlCW29mKYb4Uha9d6Lqdef5aBg7ZRyTqWKUdE6s+ty3omvSGbGkiECMdL0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=K1zUr0idyEVFnfV09peZRvewMjPwWimIfnKOmW9CidYn5FwVkwVghCEwe32GAdCBTGMdpj2u2r6srf8FYKkgVnV0peQb3/Xoz+W7W1GIv1dTyy8AqztL0cGqG3IrGEMPARXsKS7uA99TnhfzYoTU9PYi5ARm8oiY439oNaDQ9qQLtYC5IJovnL8kgV/CFhCkpn9hAXRkIfvmBr+4V46U4Pifqv/t3oHKwtn5SWwchAlfzcKSaGIRdqM/os5d0A/aINdDcr9J2QwgkPStHFj6TLoVPoZ3suFJ6eOpms3vHoVO+AK4o6za2dqAAyQm9srnxZbMbzGpodauaCZo7qcUgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0KzPozjC1OK9JAbkmaz8yvhSEdH4R8WcBnRb/MMjI4=; b=Dy5lMAwjuC4DU3w/vG0Kbuyn2J/tYIfhCdUuJgMVeXyJnwE+IjVIWw3oUvBFuVtge2C7LZ4XoHv4EjLcXOdiwAeBTlFlr3M9teHgeFF5my0XDfvpjkMHyp3455AEgedMQpCAFruWQ1bE5dqfo5ACaSTihE8Uz1KTMfjEIlIvA8k= From: Luca Fancellu To: Stefano Stabellini CC: Boris Ostrovsky , Juergen Gross , xen-devel , Stefano Stabellini Subject: Re: [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen Thread-Topic: [PATCH v4 1/2] xen: sync xs_wire.h header with upstream xen Thread-Index: AQHYYBZZ0f0HhWtpOEKVI6rFIZ2ezK0YRJ+A Date: Tue, 10 May 2022 15:27:03 +0000 Message-ID: <8DBA83BE-0537-40C1-8014-FFF7883CBF3B@arm.com> References: <20220505002304.401417-1-sstabellini@kernel.org> In-Reply-To: <20220505002304.401417-1-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f15434cd-d61f-405c-dd77-08da32998e13 x-ms-traffictypediagnostic: AM9PR08MB5954:EE_|DBAEUR03FT030:EE_|VE1PR08MB4766:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: J996UOs0R7T48S5E6SlKcPlyyBGXMsBppntaUuRr0ZqDEt4zcvd6nIIvVvpF3dSTs7lB+LxI48lOsGQDt3uEgSFG7IUbfRY5gTzc/Sb+NHnZL8mQMOr3Bwjl1m4d4PxiD66snxfnRTuseIDweCj5tii1eUxg/HRWSdhheG1cqCfY3CjC7KrzLjvE1uhig6+/UGCe/IAmN9CDVNr49OGvDN5LecYvxd5WJKRkGozZOaO4Bw4VgBQtnIVL7ZxN5S0V+kqu6cmTi1bSKtdn0Q48Jhcci2sZkDfct8gLTC6rZbI50MqbnMrElLoHfSaYqRCgLICEMXwjCZMLnbaZMHw2xqBBAo6qZjsh/10dvIywLEmSO/IiwIej+LUQE3kg7apPRzxc9ibS5n7HOTw3MteIz+CRPnuGHQ1CJPMvHcq544AUugXptcFZfcYCGe8ejscJE4Sd1x1GwwSRoEra21lOa9HeDmvwXatPTPOJxH/Vr3p3j/Fn4iSkjU731Y6JM6juhcRbFw9jOuXBpyj5Ex4CH0QuhvrOSOJZ+jQOD32Chn50bgfXM0jXoZmSZg/k+6cfBzFu8lMQFY7HCwojQtyOmjeFBk8ARoaoGyzRI82c93lJMPd4RPug4HMFJvwKiiPNt3jGM8+Ufbkq6XTVi+EmzrO7NKJk8G9VynETzV97HZok7FOiIV6UVddirIOyYozxN5dnCvcparD98ExiCrmoA8/NrojUm4MjxVtRYKXVXQI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(76116006)(8936002)(26005)(54906003)(66556008)(66946007)(91956017)(5660300002)(6512007)(66446008)(64756008)(2616005)(71200400001)(316002)(66476007)(4326008)(8676002)(86362001)(83380400001)(53546011)(36756003)(186003)(6506007)(6486002)(38100700002)(38070700005)(2906002)(33656002)(122000001)(508600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5954 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c8a9f0f8-045b-4ee8-6aa5-08da32998924 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gyj8DkAarUwUqUOhLpMrR7ZpiMTbz7t487U+27JMb5JPO3I8jQxm44Q8MCOk5Ovrguu6ayqi+reHroXfIqWDGqt+q3yWd4zAFypC94gjq7L9RajcRHlE+ilUZQH/ESbUzOGHpCLzWWcYBHZjWtq2PjTM8OH7tb//7mStUix7qV9eAFTvnFh0QsRkQd+sEnjUE/F965jB0w+2rmTlIu6f55ndfED4qN59Le9YvDQUdHzTqLQTnZsTDTu8TMugu+JokcTPCiZCMmDuWHhEm+/Xin2TLCCqmh2mnv6k60KgsJP84aXKZtoSGSibQ5r9AN/xuEq1dzWHnGIH1DS6jLwfLHuCnSpYRz+wIpPzYrvnqpnUK4ABb4hQ7gZVSzK9TvdLAv9co3JfEF0qGdKEx5bwQA4FdcVICR+uS2kf4nH/gL5R1VNmJOCzcvKJR70rQeVt38ujg6UjrPwZtuV7RNc7jhzqDT9Bu7V463lxlOi0x3UnVY2pQdCGJ2eEfNWBN4sl+fFeci4nSJU72r9AaDB2QybLHQylJL7zqEGhCzs/aWnxx3tGe8XfvkF68RXVRdMSwaMn83OhHebcynlHu16k0qDSb8Gk8aFAjRWjlOMn1bEtrbIgpoABNv2BqF0dJGirKBFtB7NucIMpRvbVKut1hwysER0GZlKMKhzPy8NWM6LZ0gsDc0Yt40V1bjEPo4km X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(26005)(2616005)(40460700003)(107886003)(36860700001)(6512007)(82310400005)(8676002)(4326008)(6862004)(36756003)(47076005)(186003)(336012)(316002)(70586007)(54906003)(70206006)(53546011)(2906002)(5660300002)(6506007)(86362001)(508600001)(8936002)(33656002)(6486002)(81166007)(83380400001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 15:27:12.1241 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f15434cd-d61f-405c-dd77-08da32998e13 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4766 DQpIaSBTdGVmYW5vLA0KDQo+IE9uIDUgTWF5IDIwMjIsIGF0IDAxOjIzLCBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gRnJvbTogU3RlZmFu byBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gDQo+IFN5bmMg dGhlIHhzX3dpcmUuaCBoZWFkZXIgZmlsZSBpbiBMaW51eCB3aXRoIHRoZSBvbmUgaW4gWGVuLg0K PiANCj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxp bmlAeGlsaW54LmNvbT4NCj4gLS0tDQo+IGluY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJl LmggfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0NCj4gMSBmaWxlIGNoYW5nZWQs IDMxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS94ZW4vaW50ZXJmYWNlL2lvL3hzX3dpcmUuaCBiL2luY2x1ZGUveGVuL2ludGVyZmFjZS9p by94c193aXJlLmgNCj4gaW5kZXggZDQwYTQ0ZjA5YjE2Li4wNGRjYTc3YWJjNDUgMTAwNjQ0DQo+ IC0tLSBhL2luY2x1ZGUveGVuL2ludGVyZmFjZS9pby94c193aXJlLmgNCj4gKysrIGIvaW5jbHVk ZS94ZW4vaW50ZXJmYWNlL2lvL3hzX3dpcmUuaA0KPiBAQCAtMTAsNyArMTAsOCBAQA0KPiANCj4g ZW51bSB4c2Rfc29ja21zZ190eXBlDQo+IHsNCj4gLSAgICBYU19ERUJVRywNCj4gKyAgICBYU19D T05UUk9MLA0KPiArI2RlZmluZSBYU19ERUJVRyBYU19DT05UUk9MDQo+ICAgICBYU19ESVJFQ1RP UlksDQo+ICAgICBYU19SRUFELA0KPiAgICAgWFNfR0VUX1BFUk1TLA0KPiBAQCAtMzAsOCArMzEs MTMgQEAgZW51bSB4c2Rfc29ja21zZ190eXBlDQo+ICAgICBYU19JU19ET01BSU5fSU5UUk9EVUNF RCwNCj4gICAgIFhTX1JFU1VNRSwNCj4gICAgIFhTX1NFVF9UQVJHRVQsDQo+IC0gICAgWFNfUkVT VFJJQ1QsDQo+IC0gICAgWFNfUkVTRVRfV0FUQ0hFUywNCj4gKyAgICAvKiBYU19SRVNUUklDVCBo YXMgYmVlbiByZW1vdmVkICovDQo+ICsgICAgWFNfUkVTRVRfV0FUQ0hFUyA9IFhTX1NFVF9UQVJH RVQgKyAyLA0KPiArICAgIFhTX0RJUkVDVE9SWV9QQVJULA0KPiArDQo+ICsgICAgWFNfVFlQRV9D T1VOVCwgICAgICAvKiBOdW1iZXIgb2YgdmFsaWQgdHlwZXMuICovDQo+ICsNCj4gKyAgICBYU19J TlZBTElEID0gMHhmZmZmIC8qIEd1YXJhbnRlZWQgdG8gcmVtYWluIGFuIGludmFsaWQgdHlwZSAq Lw0KPiB9Ow0KPiANCg0KSeKAmXZlIGNoZWNrZWQgYW5kIHNlZW1zIHRoYXQgaGVyZSB0aGVyZSBp cyB0aGlzIG1pc3Npbmc/DQoNCkBAIC01OSw4ICs3MSwxMCBAQCBzdGF0aWMgc3RydWN0IHhzZF9l cnJvcnMgeHNkX2Vycm9yc1tdIF9fYXR0cmlidXRlX18oKHVudXNlZCkpID0gew0KICAgICBYU0Rf RVJST1IoRVJPRlMpLA0KICAgICBYU0RfRVJST1IoRUJVU1kpLA0KICAgICBYU0RfRVJST1IoRUFH QUlOKSwNCi0gICAgWFNEX0VSUk9SKEVJU0NPTk4pDQorICAgIFhTRF9FUlJPUihFSVNDT05OKSwN CisgICAgWFNEX0VSUk9SKEUyQklHKQ0KIH07DQoNCj4gI2RlZmluZSBYU19XUklURV9OT05FICJO T05FIg0KPiBAQCAtODcsOSArOTMsMzEgQEAgc3RydWN0IHhlbnN0b3JlX2RvbWFpbl9pbnRlcmZh Y2Ugew0KPiAgICAgY2hhciByc3BbWEVOU1RPUkVfUklOR19TSVpFXTsgLyogUmVwbGllcyBhbmQg YXN5bmMgd2F0Y2ggZXZlbnRzLiAqLw0KPiAgICAgWEVOU1RPUkVfUklOR19JRFggcmVxX2NvbnMs IHJlcV9wcm9kOw0KPiAgICAgWEVOU1RPUkVfUklOR19JRFggcnNwX2NvbnMsIHJzcF9wcm9kOw0K PiArICAgIHVpbnQzMl90IHNlcnZlcl9mZWF0dXJlczsgLyogQml0bWFwIG9mIGZlYXR1cmVzIHN1 cHBvcnRlZCBieSB0aGUgc2VydmVyICovDQo+ICsgICAgdWludDMyX3QgY29ubmVjdGlvbjsNCj4g KyAgICB1aW50MzJfdCBlcnJvcjsNCj4gfTsNCj4gDQo+IC8qIFZpb2xhdGluZyB0aGlzIGlzIHZl cnkgYmFkLiAgU2VlIGRvY3MvbWlzYy94ZW5zdG9yZS50eHQuICovDQo+ICNkZWZpbmUgWEVOU1RP UkVfUEFZTE9BRF9NQVggNDA5Ng0KPiANCj4gKy8qIFZpb2xhdGluZyB0aGVzZSBqdXN0IGdldHMg eW91IGFuIGVycm9yIGJhY2sgKi8NCj4gKyNkZWZpbmUgWEVOU1RPUkVfQUJTX1BBVEhfTUFYIDMw NzINCj4gKyNkZWZpbmUgWEVOU1RPUkVfUkVMX1BBVEhfTUFYIDIwNDgNCj4gKw0KPiArLyogVGhl IGFiaWxpdHkgdG8gcmVjb25uZWN0IGEgcmluZyAqLw0KPiArI2RlZmluZSBYRU5TVE9SRV9TRVJW RVJfRkVBVFVSRV9SRUNPTk5FQ1RJT04gMQ0KPiArLyogVGhlIHByZXNlbmNlIG9mIHRoZSAiZXJy b3IiIGZpZWxkIGluIHRoZSByaW5nIHBhZ2UgKi8NCj4gKyNkZWZpbmUgWEVOU1RPUkVfU0VSVkVS X0ZFQVRVUkVfRVJST1IgICAgICAgIDINCj4gKw0KPiArLyogVmFsaWQgdmFsdWVzIGZvciB0aGUg Y29ubmVjdGlvbiBmaWVsZCAqLw0KPiArI2RlZmluZSBYRU5TVE9SRV9DT05ORUNURUQgMCAvKiB0 aGUgc3RlYWR5LXN0YXRlICovDQo+ICsjZGVmaW5lIFhFTlNUT1JFX1JFQ09OTkVDVCAxIC8qIGd1 ZXN0IGhhcyBpbml0aWF0ZWQgYSByZWNvbm5lY3QgKi8NCj4gKw0KPiArLyogVmFsaWQgdmFsdWVz IGZvciB0aGUgZXJyb3IgZmllbGQgKi8NCj4gKyNkZWZpbmUgWEVOU1RPUkVfRVJST1JfTk9ORSAg ICAwIC8qIE5vIGVycm9yICovDQo+ICsjZGVmaW5lIFhFTlNUT1JFX0VSUk9SX0NPTU0gICAgMSAv KiBDb21tdW5pY2F0aW9uIHByb2JsZW0gKi8NCj4gKyNkZWZpbmUgWEVOU1RPUkVfRVJST1JfUklO R0lEWCAyIC8qIEludmFsaWQgcmluZyBpbmRleCAqLw0KPiArI2RlZmluZSBYRU5TVE9SRV9FUlJP Ul9QUk9UTyAgIDMgLyogUHJvdG9jb2wgdmlvbGF0aW9uIChwYXlsb2FkIHRvbyBsb25nKSAqLw0K PiArDQo+ICNlbmRpZiAvKiBfWFNfV0lSRV9IICovDQo+IC0tIA0KPiAyLjI1LjENCj4gDQo+IA0K DQo= From xen-devel-bounces@lists.xenproject.org Tue May 10 15:28:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:28:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325794.548528 (Exim 4.92) (envelope-from ) id 1noRn2-0000dN-Nm; Tue, 10 May 2022 15:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325794.548528; Tue, 10 May 2022 15:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRn2-0000dG-Kx; Tue, 10 May 2022 15:28:44 +0000 Received: by outflank-mailman (input) for mailman id 325794; Tue, 10 May 2022 15:28:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRn2-0000d6-42 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:28:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e01460ca-d075-11ec-a406-831a346695d4; Tue, 10 May 2022 17:28:43 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BDCE21F8C1; Tue, 10 May 2022 15:28:42 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 913582C141; Tue, 10 May 2022 15:28:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e01460ca-d075-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652196522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e4wukkdgHyYEEL082h2+8MXPywOa6STdjbSVdRIKUGE=; b=rR4mS/+oT4jH07pNjBmARAg7zdRtaoeIif/UACNxEBTH30BjG7Bppc3qvkDfJRoCh4TawW 6luoRejPAMFZr+z9Kvz9iubCA5AxZw1bIiLsMXPqeMDKaF9ra8TkGI7FOIFKW72kOoldt+ xkdV40YW6dtF4zTHXKWuKX4kUttIYC0= Date: Tue, 10 May 2022 17:28:40 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris , Florian Fainelli Subject: Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-16-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-16-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:09, Guilherme G. Piccoli wrote: > This patch improves the panic/die notifiers in this driver by > making use of a passed "id" instead of comparing pointer > address; also, it removes an useless prototype declaration > and unnecessary header inclusion. > > This is part of a panic notifiers refactor - this notifier in > the future will be moved to a new list, that encompass the > information notifiers only. > > --- a/drivers/bus/brcmstb_gisb.c > +++ b/drivers/bus/brcmstb_gisb.c > @@ -347,25 +346,14 @@ static irqreturn_t brcmstb_gisb_bp_handler(int irq, void *dev_id) > /* > * Dump out gisb errors on die or panic. > */ > -static int dump_gisb_error(struct notifier_block *self, unsigned long v, > - void *p); > - > -static struct notifier_block gisb_die_notifier = { > - .notifier_call = dump_gisb_error, > -}; > - > -static struct notifier_block gisb_panic_notifier = { > - .notifier_call = dump_gisb_error, > -}; > - > static int dump_gisb_error(struct notifier_block *self, unsigned long v, > void *p) > { > struct brcmstb_gisb_arb_device *gdev; > - const char *reason = "panic"; > + const char *reason = "die"; > > - if (self == &gisb_die_notifier) > - reason = "die"; > + if (v == PANIC_NOTIFIER) > + reason = "panic"; IMHO, the check of the @self parameter was the proper solution. "gisb_die_notifier" list uses @val from enum die_val. "gisb_panic_notifier" list uses @val from enum panic_notifier_val. These are unrelated types. It might easily break when someone defines the same constant also in enum die_val. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 10 15:31:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:31:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325800.548539 (Exim 4.92) (envelope-from ) id 1noRpy-0002Ke-4s; Tue, 10 May 2022 15:31:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325800.548539; Tue, 10 May 2022 15:31:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRpy-0002KX-26; Tue, 10 May 2022 15:31:46 +0000 Received: by outflank-mailman (input) for mailman id 325800; Tue, 10 May 2022 15:31:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRpw-0002KR-LR for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:31:44 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bae2705-d076-11ec-a406-831a346695d4; Tue, 10 May 2022 17:31:43 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id d15so21481401lfk.5 for ; Tue, 10 May 2022 08:31:43 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id o28-20020ac2495c000000b0047255d211b3sm1682490lfi.226.2022.05.10.08.31.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 May 2022 08:31:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bae2705-d076-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Iv0IL6AtnXgnr8MUvSke35+4yXUMx4F0Bkh2lEdPPQg=; b=fBq38ROfDoJI7x6svPyWaTXK/LZQhypxQZTbZLK3CXuEpdZvQP1uOdcIqbe2CHRDWU N8IzziYBzE21gymvbJl/xsXoQ0efYKio91eBS8dLwOtqO2AWsfhBFrhnZcJS2FuiyLnl gETL6cLZe7VPbcqu8WwFGmm32Iq3GYFSeL7oBpeg1eq7ZxGVFNvNWCOdT1WfSq5XFSLy K1qrLYW0l/YkGlIwwKeqjDp3A+fW+MNVQKEtMQ6ifTIT1ftw+vsSegmWrrd9RPOo+PMl EpCYLXLjgUpkaA9yZWmcxqqYjVkss098efDmxAlyK/+xXold4ptrsGisgmxmqusKnsun yCeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Iv0IL6AtnXgnr8MUvSke35+4yXUMx4F0Bkh2lEdPPQg=; b=JZD/UCULi3cJKkXdo965rfh3ZkeKfmU8samkpLgSTTWmIL3rqaCDqnLL1Ag6gdhAlV bCnarcsDkn4pOa2Wp4C9Zk+W8NlGcFZnMYPnBcrIFjOyp+r+wAzYAW3msi1TTjPC5ieO IHmkmG7bvbSHyFtKjNj1MYnMxjQq36pU+REVxDZeJt+1n1wfzaQhSwiXh5x/36sj2/8X y0yrBP8LPY2jw86Sit48J9/9AWfuOQ+t8qesbaNLOiETPyl16jqYF4SLal2rDUyaips8 U/brhycXDpLQn/EIBMoI5AJ/jLylbM6SPGSIe9ydrQ5ApysWr+toD8tp/sPhhA7rzoT8 i0rg== X-Gm-Message-State: AOAM531zQrXYvyyxbqFjsjhDvvsbLPFv+f4EzWfQTqpYD+jipq2KP02I HETkfKNw2TYgPiuFHbcTctzlsyFLQxc= X-Google-Smtp-Source: ABdhPJxO2qsi9uz6Y+ru8QWBielkM7K/yltoMEAUq6k4ZKv+NjJfIZZ6agBVkLZJE6me5OBsHHcUAQ== X-Received: by 2002:ac2:4c42:0:b0:471:a8e2:198e with SMTP id o2-20020ac24c42000000b00471a8e2198emr16894400lfk.673.1652196702270; Tue, 10 May 2022 08:31:42 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Henry Wang , Kaly Xin , Jiamei Xie , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH V1] libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node Date: Tue, 10 May 2022 18:31:16 +0300 Message-Id: <1652196676-14745-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Use specific binding for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Based on device-tree binding from Linux: Documentation/devicetree/bindings/arm/xen,dev-domid.yaml Signed-off-by: Oleksandr Tyshchenko --- !!! This patch is based on non upstreamed yet “Virtio support for toolstack on Arm” V8 series which is on review now: https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ New device-tree binding (commit #5) is a part of solution to restrict memory access under Xen using xen-grant DMA-mapping layer (which is also on review): https://lore.kernel.org/xen-devel/1651947548-4055-1-git-send-email-olekstysh@gmail.com/ Changes RFC -> V1: - update commit description - rebase according to the recent changes to "libxl: Introduce basic virtio-mmio support on Arm" --- tools/libs/light/libxl_arm.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 37403a2..27ff328 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -862,7 +862,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, - uint64_t base, uint32_t irq) + uint64_t base, uint32_t irq, + uint32_t backend_domid) { int res; gic_interrupt intr; @@ -887,6 +888,14 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property(fdt, "dma-coherent", NULL, 0); if (res) return res; + if (backend_domid != LIBXL_TOOLSTACK_DOMID) { + uint32_t domid[1]; + + domid[0] = cpu_to_fdt32(backend_domid); + res = fdt_property(fdt, "xen,dev-domid", domid, sizeof(domid)); + if (res) return res; + } + res = fdt_end_node(fdt); if (res) return res; @@ -1205,7 +1214,8 @@ next_resize: libxl_device_disk *disk = &d_config->disks[i]; if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) - FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, + disk->backend_domid) ); } if (pfdt) -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 10 15:31:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325801.548551 (Exim 4.92) (envelope-from ) id 1noRq5-0002d6-Ds; Tue, 10 May 2022 15:31:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325801.548551; Tue, 10 May 2022 15:31:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRq5-0002cw-AZ; Tue, 10 May 2022 15:31:53 +0000 Received: by outflank-mailman (input) for mailman id 325801; Tue, 10 May 2022 15:31:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRq3-0002KR-Dz for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:31:51 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bcbc5a1-d076-11ec-a406-831a346695d4; Tue, 10 May 2022 17:31:49 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 11:31:28 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5472.namprd03.prod.outlook.com (2603:10b6:a03:27a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Tue, 10 May 2022 15:31:26 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 15:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bcbc5a1-d076-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652196709; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=A6uRi1n+JomLmF4L1lFXPu41zat7pbZVCTEakTao+hQ=; b=Dq1wLpY5zUE7GSgTDYY6YMLstlVuA8eIzgQtPX2LTju5a2KD7+l/w5wu RuuTOSJE9AwefeQG4isK2rsYRtDY4Am/KBI+IHGDZKQJuMZvSQvocD83i zW94ursX1oYgcZVjg89DHYPKD4w6OuU/ZzK2AnW2lEuICsU9s9CSbLEco 0=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 71394708 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gEiFrqAIksqoNhVW/1jiw5YqxClBgxIJ4kV8jS/XYbTApGwl3zUAn GcZWGHVOa7camT3L49wa9u1901QvpLQy4VgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2tYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhzz uxXtbLrSjsKM6j3qb82b0FFTiVHaPguFL/veRBTsOS15mifKj7G5aUrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mcHs0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx3SijLGUIwL6TjZQF/Vn+kjYp6ensFvrEI+6we+R3rm/N8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1iPwQPJVGuw+rQuLmqzd5l/AAnBeF2EcLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqUFr6PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:2YXk1qMzeCfiWcBcT13155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2c6YRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv4EvoxKhNNKWs2N 60Q5iAtIs+OvP+PpgNc9vof6OMexzwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="71394708" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIquiaxEgU5A9+M364Ulcn5LPoYegQIKgfgCu6yzJu0/RPTSYt54yd+xQATsU1MG/4RkHFNJ6bizaIE14+ivIWc7/VbiDyOcguDrGahAXweCClN85PZDJiP0665xbzCb6Q2qwg9WcbbEF7tb2aOAHgk1MvwkZcLXEvdT46px/IycB7xsBROdekGGaQMMGe26UBxbynIwzIcSCVoNgLe8PkgWhU19Xpd6DZh7nKhdFaGqPPPzwj5gvnFcagqW2lFECi6/BoKVN28x6WbTUnwqQnU2wmbVG9ag49zjznhOu10HBE/kS4sHYJd1az8Bqi8AMxpF9V7FETB5Hmu5v+425A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Z1GN4x7PzE/ViYEEyjTtXbvTs3ZPRlGD1cF4XrGlSg=; b=NtA6pRciKhnrbzLpDSRpm3D+SDcA1ddshUhlBZvqObCZOJTB/ASkYkRCCgVcykHh6L1e7awxv32OI79Q1B1TcgKRjOMPD/zA2bdBRwe2qCG8zH+xmZ1Mj4HchHWesDCO0CGqVSnmERa3+tOt8CWz7G79oa/nZylt7E9Hm3v0spOlYTYMf6+yV9DjelSfr/4yEKYM545l2Fvhb/areDLuRouOpi1aJczPZARYcFH3s3cuWbwJT7rPKpUTa3/jRqhh+DhQ/Ds+NY9MqGURXYs7iWV7YLW+3NYCoaWSaPg+zrFVpZq+MJP8qfNsahxpld7ObhWJ9XOcJSz2zv/LpVUxag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Z1GN4x7PzE/ViYEEyjTtXbvTs3ZPRlGD1cF4XrGlSg=; b=mYSyaENYABqRdJkpiDMJ55P6PweA1/QDsAf/dv/NUHN7hGZETPh8pdmUIkA2yI0uoEn2K2kHm2s6Rz851YdGQiVDXCdJ2qIR9/lLnfT2aSIVzrxSZ6mnwhh6q9kAQ2IS9HuvJOMw39BdzsLhZEdSvD0WykddBBzQHB7TtyZ7KRs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 17:31:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 17/21] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0330.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0004c40f-3631-4dc0-8ba5-08da329a255e X-MS-TrafficTypeDiagnostic: SJ0PR03MB5472:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cJfe+sM3mFDk1VekDG+IE6uU3CywIUIsjuoZbpSXr9D47HbMm3GgBDTg+zZ5j5Pu4v1KfgHSRw5FsXE5MbEHIvcUvtfrRPKXdjZWdWRNrRSgM2ZaZjquMYKh5JmY6x4THwfERldN/OAF+WlbK0T6agbigs/GBw5LOwZu5c2uuUoleT2tlyplc7oZfLTa+rjtyyCj6yzEQ3cQbyl8yHbBVG2nnwAr8eUWD6+vcNYPQnwBMOb8dGGgaSUa1bsxQ8Z8iPZ/jT0j7nshJgIRRr2Vq7fvLN1xZPzYP2+RpFp5Y1xIwH4Lly591hkEaEIhhgeh5j17Vr1SMn0ogQ0Sx4x9P8n772T7o/ZO4Sn0e+0wxhq9URKeF1Wxurns8zT2XEiUO1Qqh8NC4rd5nkaQE4dJBC46uHeHmY4FNnvccqeeyWf0utUbIMeEF6A31WPWDQofJ50X/1iGIkzwHphNUb3zZ6noBocsQyt9sngSf6ka4NvLk3T1WbUoUw8Lxo3GREX75KYXde+joFd5oO41ww3JEyB7Q7t79MR5/2ZnVNrinCvwI4fkebVoSdhdWyqTTNof1vV9fvRZ41gH1AgQ7qgEVgZGSNnX9KTdbmcHdDDHVbk3Kpg2RlGRajhmPvWYnVFjHCjdqmdz0hh5FF0BiluTKrXwDXu5VLcRWn2z7QQocInz5ghwAYWpeiLywZX0QYC8KKGpzlopm1D8YOYBAlVLrw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(82960400001)(38100700002)(33716001)(26005)(6512007)(9686003)(6916009)(8676002)(4326008)(186003)(316002)(66556008)(85182001)(66946007)(54906003)(66476007)(2906002)(6666004)(508600001)(86362001)(6506007)(6486002)(8936002)(83380400001)(5660300002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d09vN1JsRUVXQ3FXTEl3RGdlR21rSHB3Sy9KSTZoWDlJS1cxNmJMLzRsVVFt?= =?utf-8?B?dDA3SHh4M0JuWllTQ1Y4YlkzcGFNeGo1bEJjd2RJQ1MrR3BMdEdtMEZDaWdj?= =?utf-8?B?czNvMklZWURrbWl6QjBnZzdSMFNHbjRRSDlreDVQNzh0UVdZWkowYnNJZkMy?= =?utf-8?B?amhpdEQrN3pMU0NoUkRTQzJjWjIrZ1A0QlVHZ3h3czBWOUExeDA2S25GSmdl?= =?utf-8?B?dm82a0FuaSt6NC80MWRqUjdCU2ZWYStWbXdiMWw3b3FZb1lFRWwyaHZyUHNt?= =?utf-8?B?SWJ0OVRWbWVlVXB0Tk41M2poWHBEOVFoR0VGV2NsQUE0MzF2bTd3VXZrbFVT?= =?utf-8?B?R3lKa3VWUktVYnAwWEw0MDVZcE1Sc2RQY3R6R1dTdStaN3Z6YUlQS3Z0eE1w?= =?utf-8?B?WTNrZW5heW56TW1WMUxjdkQ3ajZNakZCcUdIUFVKb0FHUG1JN3dyaWxYRTV0?= =?utf-8?B?c3NGMVFqditLNndpdUgxNk9ZcDZSQTEvemRDd3lQYkVlc3pVZjFmTTlpUDhs?= =?utf-8?B?ME84M3J0UmhzOHMybGd5ZzRYQlRiZU9NaFZ1VURiT0t4ZmRMZEJLQzNqa2R4?= =?utf-8?B?Y0R5R2txRExVbm5vQkZzMjV0RlNVNXdta2c2aGNVeFZVbXlJYis5b244eDFT?= =?utf-8?B?U0F3WitDd0hnaFF3VXZkNDZDKzRLWUo0TDQ2ZW5mbWtsRjZqVFJQbTBEYjk2?= =?utf-8?B?K1NqZzhhNytSMW9FVmVQT3piVzU2UGV3TE9zMmtQRVYrU1pZYVJYanlnS1VP?= =?utf-8?B?Zlh6NGw2ZHlLYzBZRXJTRUV2WU1ZYTZIYzkwbkRsTE4zZnlwQ2cyVnRUbWhx?= =?utf-8?B?cHlSZUdSZ0FrdGttbEJjZEE0Q3laVjNkUS82QUF5dWZscWVBL1EvSWcyYXpw?= =?utf-8?B?b1BvYkZDdHQxRElwNyt6RVMxOVB3elVHUHJMUGVLNnl1VXQrSUJTVXd6RnBN?= =?utf-8?B?U0NCbmsza0hORk03OEQ4VzV5ZTMzOXdRa3doZC9neEFmbU9qOXNnYXozeTVG?= =?utf-8?B?LzRSdnpIc0ZIaGs4VXVNQmRDdEU5OWgzcEhrTUc2KysvNHowRGtqQUNacnBP?= =?utf-8?B?ZGVGVkdLQThIMjJDOXRyTjBjRUplWmxIc051K2J1VHQveWJvK1d6Ukd6b1NN?= =?utf-8?B?MGZhT2FhZkhOeit4YXplTHQrSWIveHhReDZGY0IxWWdKbldCTWpyN1NvYiti?= =?utf-8?B?WVd6d3JUZGJWMEh0QURaQWRhUmdJRUNlaGcrK05oamRtUU1FZVYwb0YwR2Zh?= =?utf-8?B?K2tVMERwWnBlL2xoVTBaaXNtbDl5SnZHMFQyQUQ5RlM0V2FCaE5yN1RGWUpz?= =?utf-8?B?V2g0M3R6N1RIT2hWK085ZmMyWmpMOFBodkxRTmpEWmhGYXU1R1RpWmMwVFRq?= =?utf-8?B?Rk9jWWtZY2FBNGpsd2NXK3FhQWRob0FsbTY5OWZnQW4zWm9sdVFvZlR2ZDNF?= =?utf-8?B?NldDcW92Uno5R2hFd2ZIemw0eTQxQml1K0dwYnM0bjVjd1Vwc0RMVEMxNkhz?= =?utf-8?B?ZmdudjFCZUFFdDJub1RZalFYL2tjZ250S2kxT1IyYW5LSG9ycnpucG9jdmJU?= =?utf-8?B?ejJBaW8raFQxeWwveW5yZDRnSndqbG9SR1UxUm9WWHdtdTVDbHd2ZHh2NXZm?= =?utf-8?B?dHVhVEdKNUlDOExpci95RXZIbTExZno4a05Wc01nVGFVeURKOW84dm9uWGYy?= =?utf-8?B?UG1yaDZqRS9QUnVvQ0trTFRsQmNmU01ZWUZYTDNFU3FSN3Y5MEs0ajZzR3k1?= =?utf-8?B?ZUJXQWlqR2tjeU9wQkVZSkdhNjQ0dExOVDVrVDUrNkp5T21aTlQrVSttblF1?= =?utf-8?B?eEd0N2FiYnRqclNEZXR1VVdFWGpwM2x1QWNRb08xOWNDdE1yTi9IRS9VN3dN?= =?utf-8?B?b2tQZGFkaEtJbW5OaytXa2hJNXdOa0pMcm50bXVUUVJKYWxWSk9mallMVlIz?= =?utf-8?B?emJEWWNsZkdHa3ZueTFoWUh4M1RGZlZtYU9TV2pXeWR4K3B3NGFEZW4vY0xO?= =?utf-8?B?cFdHUmxPMmxIQmoyYVRSQlhNb0pvWVFySjNzOVd1alpPeVNwUnViMUxkQXJW?= =?utf-8?B?TnVSbUR5TEhqR1hrU2gxa0NsZ0d0QmdPZTZ5eUVZQmprRXBuVGV2TENYaFEy?= =?utf-8?B?dW5TM1A0MXdiVDJTaDdnanlXVE9hTHVVeVhXRzV6MDZRUlpSY0VDR0hUQjRo?= =?utf-8?B?aHB6N0tLd3dvMm5maHJWeFZ0Q3h1WW5rZmNlK3N1NE5JOE9jOWFDaGxVaEtG?= =?utf-8?B?WDR1aC8vdUJGbzYzREtnNUx3QU40ZXduZkNpNTQraFJGOEhhVHBtRTAvcjRJ?= =?utf-8?B?dE4yV3hNOC8vQXlSbmM2UVMvU1kyVFlXTjN4MlNLWGgyQlNPNS9pU1U5Wldw?= =?utf-8?Q?y1Bao8gmzT2afc/o=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0004c40f-3631-4dc0-8ba5-08da329a255e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 15:31:26.1370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KxUNQiKQZoTGT3kGDhpoi980Y7G5mMB7U02UFqBpgywbjMtt4szCHXIssVKwLzemLb2Jq0l5vLOKk84xmqJfhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5472 On Mon, Apr 25, 2022 at 10:43:16AM +0200, Jan Beulich wrote: > When a page table ends up with all contiguous entries (including all > identical attributes), it can be replaced by a superpage entry at the > next higher level. The page table itself can then be scheduled for > freeing. > > Signed-off-by: Jan Beulich > --- > Unlike the freeing of all-empty page tables, this causes quite a bit of > back and forth for PV domains, due to their mapping/unmapping of pages > when they get converted to/from being page tables. It may therefore be > worth considering to delay re-coalescing a little, to avoid doing so > when the superpage would otherwise get split again pretty soon. But I > think this would better be the subject of a separate change anyway. > > Of course this could also be helped by more "aware" kernel side > behavior: They could avoid immediately mapping freed page tables > writable again, in anticipation of re-using that same page for another > page table elsewhere. > --- > v4: Re-base over changes earlier in the series. > v3: New. > > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -81,7 +81,8 @@ static union amd_iommu_pte set_iommu_pte > unsigned long dfn, > unsigned long next_mfn, > unsigned int level, > - bool iw, bool ir) > + bool iw, bool ir, > + bool *contig) > { > union amd_iommu_pte *table, *pde, old; > > @@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte > old.iw != iw || old.ir != ir ) > { > set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > - pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), > - level, PTE_kind_leaf); > + *contig = pt_update_contig_markers(&table->raw, > + pfn_to_pde_idx(dfn, level), > + level, PTE_kind_leaf); > } > else > + { > old.pr = false; /* signal "no change" to the caller */ > + *contig = false; So we assume that any caller getting contig == true must have acted and coalesced the page table? Might be worth a comment, to note that the function assumes that a previous return of contig == true will have coalesced the page table and hence a "no change" PTE write is not expected to happen on a contig page table. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 15:32:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325808.548562 (Exim 4.92) (envelope-from ) id 1noRqS-0003Jo-P4; Tue, 10 May 2022 15:32:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325808.548562; Tue, 10 May 2022 15:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRqS-0003Jf-LI; Tue, 10 May 2022 15:32:16 +0000 Received: by outflank-mailman (input) for mailman id 325808; Tue, 10 May 2022 15:32:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noRqQ-0002KR-KO for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:32:14 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d67d189-d076-11ec-a406-831a346695d4; Tue, 10 May 2022 17:32:13 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id m20so33700667ejj.10 for ; Tue, 10 May 2022 08:32:13 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id hx3-20020a170906846300b006f3ef214e7asm6236050ejc.224.2022.05.10.08.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 08:32:12 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5B9B21FFB7; Tue, 10 May 2022 16:32:11 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d67d189-d076-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=yWy4+v4Ieubc1HaVClCWgFcuV1I81g9ohGvVvx+/5r4=; b=Q6Lf0yyp1Hjkc3d57B9RztlMOOLTC8j3FJAwzHiOtNwD9v0rsjYf5GHZIjB+n3aotH 4qC3vyn5BpIzGvxwMf6s4FsCLU5bv9yYbtKO1caEDM8/d4t8EVlW7El8SlbZ+iaSi8bW 2iLS/xu/ut+WLnH5xHu7hdaHBVjfERiQq/WBfw1ojH+G566VkY18Lttqgfy837RrjqZU 2PR0ioKCRb9fWvQLC9xxLSc+QzRZBA4HsAsnjrWIlraZWn5y6p5JCEscG8gd7pKKnM7n UWedwR78KHnvukJGMMK76mUefXEUukvkn71jqFlXx6SWFh2ZlxRUwanG6qk9otoSoNGQ fwDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=yWy4+v4Ieubc1HaVClCWgFcuV1I81g9ohGvVvx+/5r4=; b=1rfDyfeENtL8ZaQi69Hgsm/2nNHydLkW1D5O76OkvB4V+0eVcQOTJ2gNrGe4+R9c8r +e3LFw0rP0/829fP376QpfIuVvS2cufiPtf1kMceLYtwHo8kK2nrwWaVYg4d/a7rAhbP iuOytsBXc/QF9Nn2IWWuweJ10lsuCLrkpe7JZNTwQpnrCK+oLAj8DZAd5b0rAan0TjDa QTXWTKfyuivkDI+QQyucr+Tq0/XCdIbIXe2RF+UtM5oazh8Ow33hhgJiSFt6vAiU9vjw g7z8IKrghBeu2EtKxuUme8FJrapiefbGfT+E+gSG+GzZUe1ov/HZeUG1s8K7JBkg7SsM XLoA== X-Gm-Message-State: AOAM533U5mHfH1yt08FdL/QUt2XbJPx1dcknlCrDwHN68MqqR6yQrppK ApD5UO/ng1WZ+fWySWNDPb2fmQ== X-Google-Smtp-Source: ABdhPJxrGRXa4fqHwJaRCUG2enRm9eucZkvXQo3dtOP77deNSjgFMNTN0h601Aw+Zz13wqGvBbls9Q== X-Received: by 2002:a17:907:1c20:b0:6f4:639e:9400 with SMTP id nc32-20020a1709071c2000b006f4639e9400mr19678215ejc.485.1652196733032; Tue, 10 May 2022 08:32:13 -0700 (PDT) References: <20220428103410.2723837-1-alex.bennee@linaro.org> <64d47797-3789-694b-0eb5-08fc7527ff5b@xen.org> <8735hhtrfd.fsf@linaro.org> <191159cc-f26d-f161-3f44-431507a6c270@xen.org> <87y1z9sauw.fsf@linaro.org> User-agent: mu4e 1.7.13; emacs 28.1.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Julien Grall Cc: xen-devel@lists.xenproject.org, stratos-dev@op-lists.linaro.org, Richard Henderson , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw Date: Tue, 10 May 2022 16:31:26 +0100 In-reply-to: Message-ID: <87tu9xs8sk.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Grall writes: > Hi Alex, > > On 10/05/2022 15:47, Alex Benn=C3=A9e wrote: >> Julien Grall writes: >>> On 10/05/2022 15:03, Alex Benn=C3=A9e wrote: >>>> Julien Grall writes: >>>> >>>>> Hi Alex, >>>>> >>>>> On 28/04/2022 11:34, Alex Benn=C3=A9e wrote: >>>>>> When we introduced FEAT_LPA to QEMU's -cpu max we discovered older >>>>>> kernels had a bug where the physical address was copied directly from >>>>>> ID_AA64MMFR0_EL1.PARange field. The early cpu_init code of Xen commi= ts >>>>>> the same error by blindly copying across the max supported range. >>>>>> Unsurprisingly when the page tables aren't set up for these greater >>>>>> ranges hilarity ensues and the hypervisor crashes fairly early on in >>>>>> the boot-up sequence. This happens when we write to the control >>>>>> register in enable_mmu(). >>>>>> Attempt to fix this the same way as the Linux kernel does by gating >>>>>> PARange to the maximum the hypervisor can handle. I also had to fix = up >>>>>> code in p2m which panics when it sees an "invalid" entry in PARange. >>>>>> Signed-off-by: Alex Benn=C3=A9e >>>>>> Cc: Richard Henderson >>>>>> Cc: Stefano Stabellini >>>>>> Cc: Julien Grall >>>>>> Cc: Volodymyr Babchuk >>>>>> Cc: Bertrand Marquis >>>>> >>>>> Acked-by: Julien Grall >>>> Will you pick this up via your tree or do I need to do something >>>> else to >>>> get it upstreamed? I guess it needs to go on master and last stable? >>> >>> We only have one tree in Xen where committers (such as Stefano and I) >>> will commit patches regularly to staging. Osstest will then push to >>> master once the testing passed. >>> >>> I have done that now. Interestingly, git am wasn't able to apply this >>> patch. I had to do with: >>> >>> 42sh> git am --show-current-patch=3Ddiff | patch -p1 >>> patching file xen/arch/arm/arm64/head.S >>> Hunk #1 succeeded at 474 (offset 1 line). >>> patching file xen/arch/arm/p2m.c >>> Hunk #1 succeeded at 32 with fuzz 2. >>> Hunk #2 succeeded at 2023 (offset -7 lines). >>> Hunk #3 succeeded at 2031 (offset -7 lines). >>> Hunk #4 succeeded at 2062 (offset -7 lines). >>> >>> Which branch did you use for sending the patch? >> 0941d6cb23 from RELEASE-4.16.0 > > This would explain why. Patch sent to xen-devel should be based on > staging (or master). Ahh at the time I wasn't sure if there was another regression in master so I was basing of stable. I'll re-base of master next time ;-) --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Tue May 10 15:46:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:46:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325821.548573 (Exim 4.92) (envelope-from ) id 1noS48-0005NG-V1; Tue, 10 May 2022 15:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325821.548573; Tue, 10 May 2022 15:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noS48-0005N9-R4; Tue, 10 May 2022 15:46:24 +0000 Received: by outflank-mailman (input) for mailman id 325821; Tue, 10 May 2022 15:46:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noS47-0005N3-BE for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:46:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55d8d60f-d078-11ec-a406-831a346695d4; Tue, 10 May 2022 17:46:21 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 May 2022 11:46:18 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM4PR03MB6999.namprd03.prod.outlook.com (2603:10b6:8:45::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Tue, 10 May 2022 15:46:17 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Tue, 10 May 2022 15:46:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55d8d60f-d078-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652197581; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mJUKc4eCFATDZw+aHSODAIcVRaZfKN9/cduWFGgo5+U=; b=haWRCMk8YopoRYpC7jg+fRJiM+9zY+d7NcFj/BKCRWWXPmkyKDOM2/EE caBsW1eehVfadh8i1Yef9Tut5Rx0uDUp9hjdaaJa8GRy3j2kpXkAR3UnJ y8H5LZ0komuce6g5I2eNnjr6Mwa0D3nyHLBNM/vEIF8ZhG9KECw/CDYIa 4=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 71006968 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aLM9rK8Xu+oBSKS5RkSkDrUDvH+TJUtcMsCJ2f8bNWPcYEJGY0x3y 2ZJC2qOM/bZZGSmLdskPY6y8h8G7JPUztEyTVBt/iA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHhW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZDgbBoRZ5eSo+YEaz5mLC4iYupWo4aSdBBTseTLp6HHW13F5qw0SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHfuMuYIwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKmUA9gPL9cLb5UCIwV0y2aX3bubqa+fRY+ResGCa+ 2DZqjGR7hYycYb3JSC+2nelnOrGhy74cIMUCryj9/RujUGTx2ocExkfXx2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQN47sM47QxQ62 1nPmMnmbRR0q6GcQ3+Z8raSrBuxNDITIGtEYjULJSMa5/HzrYd1iQjAJuuPC4awh9zxXDTvm TaDqXFkg61J1ZJWkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshQZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:Ax9eu6MzGWo22cBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,214,1647316800"; d="scan'208";a="71006968" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhJfiUDyCWNMUQPWMwAkIndLqZT1FJzMYz9+5E9aT2tHQKmWUw9z4UHUY7S3qooCmkqPHNGyZ/jX9OMYFh+nvt0MYmXOZU+nuXPLP1tj5jz//YaCagHSfjmiLy4nIdzjvp0mT5UJR8rsYsR/vIjH31FVOD5b9rCkdZecNokNgRVX3MsM/TIF8kQGAdsPe1rXRNhi8cgKYqbARLadt6h4ED0bdMy+zjpFyX18VIwYB0iVEZKn23yOk0TOhajOmY2GVKsqUCkut5Aws0Fdv1ETWrY9QTG77i+ZmcE8THVYOdAz2NG3Xo4h8k4OS7SfOaQZc0ubg3gi4Yv9MePfTzCyBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yqdWI16gotw1b+24r2GL66eTxF9CTPtNeEtGucldqiY=; b=loSVK6mmm2B8MvF+obc7NGpz5+PTZdQPMByFrLxkKF/rQawDrEsuedYQ36KZfgtjZyqUg7lf37dWEpup65sQtE0yJMecfgYY/C14V3lyh9jhMAwFoJTNy4yvIN5LrByNWYE+wPcQm9xEeq/DkkqIk8VEHlsG/obJ3IRpSP0zwcNYbnCXFyATYWJkiTjtKP2QMdF0RyEgpXG6Ku9OqbIFZifZQ4Ui6bhmE1YtLmYTdXWIRHKBgSPTFcCnV0ajF0iYR6/LAvoLOd61P4By8PavT+QruJIW+n3pCHnCGigFdCvvkKl27lEiCAWpt7ixasBFzO0wNUqkEveesmLPzx5fbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqdWI16gotw1b+24r2GL66eTxF9CTPtNeEtGucldqiY=; b=iQPFreXw0v+HqWugBlifAN+9FxV+Rrnq8qLTtXom4cGJl8//45QgjVzlZKzNJo18Wgug23yVRhNfzh27z9N3GkVeQhkxzG68Im4qZC/h6MPIt02cBxNQFuuR9bPSRCTDyoiZ5BqH4ZEpR+3eMHSo/ZZhTdA/BdcBEH+bOCAs/AY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 10 May 2022 17:46:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi Message-ID: References: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> <4ed4e4c3-6b71-8299-69f4-7910583fd9cb@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4ed4e4c3-6b71-8299-69f4-7910583fd9cb@citrix.com> X-ClientProxiedBy: LNXP265CA0042.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40ca03f7-ffbc-484d-2a6a-08da329c384c X-MS-TrafficTypeDiagnostic: DM4PR03MB6999:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o9cWy9nsGFNlkCjt9q5ViN93LiNmtz5+bMOMhnXWqXksQH9KWkBhmzwBYW9oNpokOiho34a0zR7wbDHaYsIuVi+8KwlsOj6OYb6tEhBogU2YBqvgk/l3Q7DeL0ennZ4WV0x2S373t8gnVywyrXKkHjQc7eiy72VOjSGdJp1JgArSTkJgiNju+Xeo7fZZamcW5kPxc+/wrp2ya3AHPGSTNBNiKrQZ160/qL1G4azWQvzqY+hfLFRfqjcOfpj1nMk5ddkz6ODeYN9YA/VfkGJ12pssWhZGhSV30kxUy8aW+9IJgSUm3vLon5IGrpynXcnzz9VG+Rwo9Yys/z4vvdfn1p8m3v/GngazA63p9aX3+Ba6eWRepjNvLH0awT4Y7Hc4BsQqa98XMNQwpIjUjayECOxkWml0NSa/Vr0IMS8NruBnVZj7Zb5n07/xGLi8rZBbRsbVLFSlvFtUiKUC8wvQGlPihWAx9CCoA8x/zIpCCgPxIfWA1Euw3IgEXWOe6dwOWOGJpjgr72+ZXAauaq2stfoM2o8iLZz5mLG3wN8CwCMRxgPdR6e9//nKY7NfGuY3N3U/XsuSOILvxFehFDNBiD23MoiyCvpjb8Stg6k6K7KJFEtMGRWcXOXC1XMF1lCKt9Nxdr1LiIynbaIM20B0TA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(83380400001)(316002)(9686003)(6506007)(26005)(6512007)(186003)(110136005)(6486002)(54906003)(508600001)(85182001)(8676002)(2906002)(5660300002)(86362001)(4326008)(8936002)(66946007)(66556008)(66476007)(6666004)(66574015)(38100700002)(33716001)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmtnNUp0SU55cUc5SUtzRExjNkN0ZUc1MG82eHhObnpHZTh5MnowWGZuMzVL?= =?utf-8?B?K1ZUV1MrS3h0SFVaUWJMR21mY0pCWnNzOS92bE1lNUI5SGR6ZCtVL3lHYlZN?= =?utf-8?B?OXlLeTV5NThhSDdsNmN1UG56QVpBcEw0SW56cDJTdEhaWmNwcEluSzZQWW5J?= =?utf-8?B?N2dGYnZnQVppT2VRSjRJaVVUcldPck5YUFNYRGgyVGc3Q2FxMFI0dWlmbFZk?= =?utf-8?B?Uk1TUE1weGZJR0R0YkEwWWxOTitXNnZzM2svT3VnTklSWWtzUm9PWXZvTG84?= =?utf-8?B?akthcXROK2Fjc0svSFQrZ0E0YWFqYTc3MVhUMkxNQzhkN1RnT2NjdmZPbmxr?= =?utf-8?B?Qms3QzQrMXdNbi92WHFPT05nT1NqbnVEaHE3akVIRDBXbTBicjRycHQvaUha?= =?utf-8?B?eEY0bllEZ1VIV3lZNkN1Vis4dlJCcWxqSTJkMlBabFdoUHZNSWZPYmtITVAr?= =?utf-8?B?OWhvbHVBdk4xMTZlYUpBdm1zZk5pL2pSaVZzYlhoeS85YkhTRmNHTEp4TUNa?= =?utf-8?B?clMxOWNyaEVhODZTeVBuaXRVME1DYUFmL0N4dzJxMWc2WHJnTmk0QWtsZ2hY?= =?utf-8?B?WkU3T3dEUlBxckUvL0lTMGt3UGxwc0drdFpYZzYrV3FQT1NuUTA3Y1dxWVZw?= =?utf-8?B?eldPNHhKY0p5MDZJUjBuOGt0MFJsVXFDS0IrUDI1OUVTek1vRTFEVnRucERI?= =?utf-8?B?MVdJTXo4R0tIdnYvZHRKVWxGMmVwc1c4UklTRU9PZlJCbkxXbGRua3F2bDlr?= =?utf-8?B?NmdvZ3JwcWFibWg4d2ljR3VXcjB5Q3RxRk1YZ0VNUmo0KzFVNDNYMmZMTVpt?= =?utf-8?B?bndsNGNub0E0VjBnMTRsNkdLbXI0TTY0TStZK200ZU90YlpqTG9mRzJUaXVO?= =?utf-8?B?L1I4d2FFMWpQRnVzNVF3NDRUZDZDWUFLUVVSK2J6QnkzTTVLSkpCdGxzc1ly?= =?utf-8?B?bnNDYk1RYjAvRjRsMjlHQjlyRTVIOXZlc1BXZEppNWtaS29McE4rekp5RXFx?= =?utf-8?B?NzlEM0NSWkI1aCtzOFJRcXpmUDRZR2F5d0FDb084OGVuZVozcVE2R0tURnND?= =?utf-8?B?enQvNjJOaXY0NW9JYm9vWm5uTmYzSG9VK3dRNGU0aFpIZFVIdEVGR09EVm14?= =?utf-8?B?ZVVWeTQ4Z2duYVZVMktRWFcvUE92MXMyd0RUVkxMbjVVck0rTDR4UEUrL1F0?= =?utf-8?B?Q0FTcTd1RlhsWkdJbDJBeFBUOGt3b3F3dUtjeFo4dDhTVDdHeTBpVWI0VDcx?= =?utf-8?B?R2E0OGZpNUtKenRxL0FFWGl1dHBvaWhMT3JMdkl4ano0VHVmRm1RNHhwNzlF?= =?utf-8?B?enlCU1VVbmFZc0pLVGdNa2JRT0xDOGNmLysrU0F3dUZScE5QZVhEQVJoSTA2?= =?utf-8?B?QlhnQSs1S0JYMXFnMmJIZFpYUnpYb2lITndQaVRBQWVMSUJLcEpmRWZFM2pI?= =?utf-8?B?d1RqeW1sRVlzNTl4RVM4NDJlRkJZYnBXOVBpNkE1OWpPYU80T09QLzNuMkx2?= =?utf-8?B?SzZMQ0xqRFAzVlV1VHpTRENYcXg5aWprV0VTblg3dVdUZVo4bWdIcXV0bHBW?= =?utf-8?B?blBqK3Ird1pjdDllU3FsZHpQVDFFcU81MW85SHpiZDlIclFRN2dXc3Vnb0Fl?= =?utf-8?B?Um01akx0ZW43eityOXFKRHNydlhlb1Y3YTdrenRHMEZFN2JkQm5iUWVaeG1m?= =?utf-8?B?UkhhY290Z0E5L3JubnBjWktGY2swcEZRTHJKY2Z0SDVRbytZNGFlR0VjQ043?= =?utf-8?B?STZjRG5heTIvVXAyMGU3YlhBcVVOc0tpQUJhNGN0dk9ZYVBEQ2hRdG1rOTRW?= =?utf-8?B?dGJGQ0h2ckw1N0dTSmw0WjNoUWFqaWdwTUVreDNXWjNkY25SOGMvSStuUUt5?= =?utf-8?B?WUdjMEY0YTlTTnk2NmNrZVFXZnRpbUZyMG5PNUdRYVVCVGxvR3pEMmx5bGQy?= =?utf-8?B?UmZIMHUrNHB4U09aY2MyWWJ2SXhlLzE3bmxXak05UWNSNFFYTzhlNzFEQ05V?= =?utf-8?B?R2VxSTZiazZkRWJnRnRYYWQ1MDQwUE01VlNTd3h4UFp6dFdtSUtXNysxL0Fm?= =?utf-8?B?Nnp0NjQ0Y0RuSStiY21kM0ZLYmo1OXZYbVhUZ1FpTDFyNEQxbnJ4TlYxbWhW?= =?utf-8?B?WnA0c3dmNkc1RTRMMG1tZHRyRVlrb2ZEbEJjQnBXc3JsSGxYU25jVHFDUmlQ?= =?utf-8?B?SDZaQWtIWHVBQU51RWUyN1BHVG5lZ0E2cVhhVklnVnFnOWZhektIcFYrZ0FN?= =?utf-8?B?MGZxQjFPK2dDY1AvRUxlVDFlWW1CVTBmMTBpTUFtQ1A0L1IrUEdCb05RUzRl?= =?utf-8?B?aUo2WEJ6WEk1anJnRmJHaHh1MDBvUFQzTVRMYy9GWVJxT0RxMzJ1aGNzRVJK?= =?utf-8?Q?N6s88EdCYPwzLWqY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40ca03f7-ffbc-484d-2a6a-08da329c384c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 15:46:16.8856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: goQ7MwV9oCAcmqJjnakM4JHt6g4EvNAZ6oHRRRJ+3GDm+6+KJArmmwe5KcVwiz33h4VCEBJkTBi3EhrcIqMttw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6999 On Tue, May 10, 2022 at 02:30:41PM +0000, Andrew Cooper wrote: > On 10/05/2022 12:55, Marek Marczykowski-Górecki wrote: > > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that can't > > possibly work. While a proper IRQ configuration may be useful, > > validating value retrieved from the hardware is still necessary. If it > > fails, use the device in poll mode, instead of crashing down the line > > (at smp_initr_init()). Currently it's > > x86-specific, as the surrounding code is guarded with CONFIG_X86 anyway. > > > > Signed-off-by: Marek Marczykowski-Górecki > > This isn't invalid per say.  It explicitly means unknown/no connection > and is used in practice to mean "never generate line interrupts, even > when MSI is disabled".  It's part of PCI 3.0 if the internet is to be > believed, but ISTR is mandatory for SRIOV devices where the use of line > interrupts is prohibited by the spec. > > Also, there are systems where nr_irq_gsi is greater than 0xff. > > I'd recommend handling 0xff specially as "no legacy irq", and not > involving nr_irq_gsi at all. I've finally found the reference for it in (one) PCI specification. It's in the PCI Local Bus Specification Revision 3.0 (from 2004) as a footnote, so for the reference I'm going to paste it here: Interrupt Line The Interrupt Line register is an eight-bit register used to communicate interrupt line routing information. The register is read/write and must be implemented by any device (or device function) that uses an interrupt pin. POST software will write the routing information into this register as it initializes and configures the system. The value in this register tells which input of the system interrupt controller(s) the device's interrupt pin is connected to. The device itself does not use this value, rather it is used by device drivers and operating systems. Device drivers and operating systems can use this information to determine priority and vector information. Values in this register are system architecture specific. [43] [...] [43] For x86 based PCs, the values in this register correspond to IRQ numbers (0-15) of the standard dual 8259 configuration. The value 255 is defined as meaning "unknown" or "no connection" to the interrupt controller. Values between 15 and 254 are reserved. That note however is completely missed on the newer PCI Express specifications. Marek, can you please adjust the code as suggested by Andrew and add the reference to the commit message? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 10 15:48:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325827.548584 (Exim 4.92) (envelope-from ) id 1noS5z-0005ym-AB; Tue, 10 May 2022 15:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325827.548584; Tue, 10 May 2022 15:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noS5z-0005yf-7T; Tue, 10 May 2022 15:48:19 +0000 Received: by outflank-mailman (input) for mailman id 325827; Tue, 10 May 2022 15:48:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noS5y-0005yJ-Ak for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:48:18 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ac52ef9-d078-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 17:48:17 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EF3C85C00EE; Tue, 10 May 2022 11:48:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 10 May 2022 11:48:14 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 11:48:13 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ac52ef9-d078-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652197694; x= 1652284094; bh=lcJtNWW1XlCbNiro7UWx15PiLnn2igC5kde/c5Qe+bE=; b=c xHp20Y/O6jN51F4dUWTZbfHybcqx6DLdrYDkzs9S9NgYKh31zEWTIrMJsLxbGysr smY8KAO40ntMDPbPtcdhfpvKek/hexeksMrESpT3ugOUI2tNPFOfXCSs+bOupqy+ aK/XE+it8/HimntXNTVrUPzSsxBCJWpRIitNiJT/v+ECBNSgWxR9vwACg/4umAnp oHTnIrF/8/G/2D9zwTrA4mCHK6kc0FsWkgDS0Kste0KHtpFKEDIUZBB3W5TE6X9H E9wY8H6IZZIkettNNFw37QMWXkCrBh6gg0gtnzjUNFlh9aetthQmOFbi/QIGGhwB NH7hkHhPhqscfKZJiWnhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Date: Tue, 10 May 2022 17:48:10 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi Message-ID: References: <20220510115546.1779279-1-marmarek@invisiblethingslab.com> <4ed4e4c3-6b71-8299-69f4-7910583fd9cb@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="smSIamfy3bQvh3xu" Content-Disposition: inline In-Reply-To: --smSIamfy3bQvh3xu Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 10 May 2022 17:48:10 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] ns16550: reject IRQ above nr_irqs_gsi On Tue, May 10, 2022 at 05:46:12PM +0200, Roger Pau Monn=C3=A9 wrote: > On Tue, May 10, 2022 at 02:30:41PM +0000, Andrew Cooper wrote: > > On 10/05/2022 12:55, Marek Marczykowski-G=C3=B3recki wrote: > > > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that can't > > > possibly work. While a proper IRQ configuration may be useful, > > > validating value retrieved from the hardware is still necessary. If it > > > fails, use the device in poll mode, instead of crashing down the line > > > (at smp_initr_init()). Currently it's > > > x86-specific, as the surrounding code is guarded with CONFIG_X86 anyw= ay. > > > > > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > >=20 > > This isn't invalid per say.=C2=A0 It explicitly means unknown/no connec= tion > > and is used in practice to mean "never generate line interrupts, even > > when MSI is disabled".=C2=A0 It's part of PCI 3.0 if the internet is to= be > > believed, but ISTR is mandatory for SRIOV devices where the use of line > > interrupts is prohibited by the spec. > >=20 > > Also, there are systems where nr_irq_gsi is greater than 0xff. > >=20 > > I'd recommend handling 0xff specially as "no legacy irq", and not > > involving nr_irq_gsi at all. >=20 > I've finally found the reference for it in (one) PCI specification. > It's in the PCI Local Bus Specification Revision 3.0 (from 2004) as a > footnote, so for the reference I'm going to paste it here: >=20 > Interrupt Line >=20 > The Interrupt Line register is an eight-bit register used to > communicate interrupt line routing information. The register is > read/write and must be implemented by any device (or device function) > that uses an interrupt pin. POST software will write the routing > information into this register as it initializes and configures the > system. The value in this register tells which input of the system > interrupt controller(s) the device's interrupt pin is connected to. > The device itself does not use this value, rather it is used by device > drivers and operating systems. Device drivers and operating systems > can use this information to determine priority and vector information. > Values in this register are system architecture specific. [43] >=20 > [...] >=20 > [43] For x86 based PCs, the values in this register correspond to IRQ > numbers (0-15) of the standard dual 8259 configuration. The value 255 > is defined as meaning "unknown" or "no connection" to the interrupt > controller. Values between 15 and 254 are reserved. >=20 > That note however is completely missed on the newer PCI Express > specifications. >=20 > Marek, can you please adjust the code as suggested by Andrew and add > the reference to the commit message? Sure. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --smSIamfy3bQvh3xu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJ6iToACgkQ24/THMrX 1ywG1Af9EBuQCZ1VWgMk5NGASJuM6Azy7n6wdSlKrVoTzm+MXHkQ5ZuRSc8uAyuu ERE6q6w/0xgVkGOkNw58SUIYtQD2Fy9aFvrIdtw79E35CEDu+1kMMBzPgOzNnOsg NDE3RvYXsFuqx09x8pW8hSUXNSM+ZlXFz8lTd2Y8wc8jVBqcUWL5LrwTQgwj+hIQ 0EM7cViuRmx5ShUQT9PTmQYlaHe4EJMl3Onqo2R1gaeJ0zo9+S5stZ5NyKQ4yriv VHQ+GyuvHEgL0TGn2AZf0WSxpBV6n2ZE0cUYZfvULpDOg+Onh+xHWyLiAa+Wwj/G ZxkbfR3h/JwFq0x68vLcK0RXrezA8A== =+dmy -----END PGP SIGNATURE----- --smSIamfy3bQvh3xu-- From xen-devel-bounces@lists.xenproject.org Tue May 10 15:58:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325838.548595 (Exim 4.92) (envelope-from ) id 1noSG2-0007kx-AR; Tue, 10 May 2022 15:58:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325838.548595; Tue, 10 May 2022 15:58:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSG2-0007kq-7P; Tue, 10 May 2022 15:58:42 +0000 Received: by outflank-mailman (input) for mailman id 325838; Tue, 10 May 2022 15:58:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSG0-0007kf-NJ for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:58:40 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e838c96-d07a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 17:58:39 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 976445C01D9; Tue, 10 May 2022 11:58:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 10 May 2022 11:58:38 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 11:58:37 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e838c96-d07a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1652198318; x=1652284718; bh=mYaKCBVQq7I6CRUH5kFvTjqejzct4Ce/08q PdhMHtqA=; b=ISN6lIMRNWS7GfQpVhKKFleTmeaoYkgMQmQV92FhZI5Mg8oNVM5 E8j2p4osLHk+cqWLS5vnBOdQGFnSTD0bx6rW1MAEli4C9nSxPu0QK4tuvIvpNvU9 x6gSjdvd0jJ6aYDXLVur8eAZuBrhifQwFqaG/QwaKXyBNlcdrUjp4dAYHWDLayIH +Ep5x0MJYHA//dNkzhS6jNBPq7cV/OjQJWA74tgFCo3RcMmhVfaUwDBUq6YNWDUW BF/rG4lUUQr3hL77nS0lKHMa6w6Ap3CIRj9vfrTgGgla94T++HWKrP8Hu+zl+Wsd V6SDXVjkU92LhEXOD3C6u/M6qOenmgomycA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 1/2] ns16550: reject IRQ above nr_irqs_gsi Date: Tue, 10 May 2022 17:58:23 +0200 Message-Id: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - change back to checking 0xff explicitly - adjust commit message, include spec reference - change warning to match the above Changes in v2: - add log message - extend commit message - code style fix --- xen/drivers/char/ns16550.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index fb75cee4a13a..b4434ad815e1 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1238,6 +1238,15 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) pci_conf_read8(PCI_SBDF(0, b, d, f), PCI_INTERRUPT_LINE) : 0; + if ( uart->irq == 0xff ) + { + printk(XENLOG_WARNING + "ns16550: %02x:%02x.%u has no legacy IRQ %d, " + "falling back to a poll mode\n", + b, d, f, uart->irq); + uart->irq = 0; + } + return 0; } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 15:58:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 15:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325839.548606 (Exim 4.92) (envelope-from ) id 1noSG3-00080N-KM; Tue, 10 May 2022 15:58:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325839.548606; Tue, 10 May 2022 15:58:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSG3-00080G-Gv; Tue, 10 May 2022 15:58:43 +0000 Received: by outflank-mailman (input) for mailman id 325839; Tue, 10 May 2022 15:58:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSG1-0007kf-Jf for xen-devel@lists.xenproject.org; Tue, 10 May 2022 15:58:41 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f516219-d07a-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 17:58:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1E28E5C0048; Tue, 10 May 2022 11:58:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 10 May 2022 11:58:40 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 11:58:38 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f516219-d07a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652198320; x=1652284720; bh=f2wikOacR1Pgp cgiF7iAdbBxzhDpXOHQwXdF9nAGshc=; b=J78rH3A2uDDlFcLKejFwVNWwZflzw e5AF2vvT/tLHTnTLTCwQ2Qoy+THzSyUlUz2NeULTdJlAmxKuiHP3BRHM79QyrHpC TYVNBiM0fh2Eg2Ygd4shj6DuV2JMnchY5JSsPQfnzS7gqSwwNiwYk/Mq9rag8+fe y/eMsKHBJybrRuUe62kQ8xrxoWq3Gv2Yq8bjeGXiISUDd/N89Ggf226Ix6F4TErJ miv9MZAggRQoCn4SQr/kr2P1nzMB81CRFM4oDgSwpgoZhirtV3CVvXfGfBov6Gh1 /3PRLTNyv3Mv01kA1Ro+k3J1h4buoR5p60m1CmhaGqqHwSfP2XmfFqtjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 2/2] ns16550: Add more device IDs for Intel LPSS UART Date: Tue, 10 May 2022 17:58:24 +0200 Message-Id: <20220510155824.1779789-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> References: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is purely based on the spec: - Intel 500 Series PCH: 635218-006 - Intel 600 Series PCH: 691222-001, 648364-003 This is tested only on TGL-LP added initially, but according to the spec, they should behave the same. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper --- Changes in v2: - new patch, adding more IDs to the patch that went in already --- xen/drivers/char/ns16550.c | 80 +++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index b4434ad815e1..72283c106514 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1077,12 +1077,90 @@ static const struct ns16550_config __initconst uart_config[] = .dev_id = 0x0358, .param = param_exar_xr17v358 }, - /* Intel Corp. TGL-LP LPSS PCI */ + /* Intel Corp. TGL-LP LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #2 */ { .vendor_id = PCI_VENDOR_ID_INTEL, .dev_id = 0xa0c7, .param = param_intel_lpss }, + /* Intel Corp. TGL-H LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51c7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51da, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7afe, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7adc, + .param = param_intel_lpss + }, }; static int __init -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 10 16:16:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325859.548617 (Exim 4.92) (envelope-from ) id 1noSX1-0003R8-7Z; Tue, 10 May 2022 16:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325859.548617; Tue, 10 May 2022 16:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSX1-0003R1-2A; Tue, 10 May 2022 16:16:15 +0000 Received: by outflank-mailman (input) for mailman id 325859; Tue, 10 May 2022 16:16:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSWz-0003Qr-Od; Tue, 10 May 2022 16:16:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSWz-0001XR-LJ; Tue, 10 May 2022 16:16:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSWz-0004bU-2K; Tue, 10 May 2022 16:16:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noSWz-0001mh-1t; Tue, 10 May 2022 16:16:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v7vpL2BZDL8TrhhIWqN3PwVayZ6SXiTk3l1it/xOAyg=; b=Tt1lHtFBaPvyQGSJxnmO7anY0i gYD/tGTSSflxIVu0ntu0WE2E3ghGBi0zrc6rqUuPTJdpystcz4eNQDyCBZt+2jSR/6W/Qw+Yvu6/d QWIDi2ajZYUejx9akZuDX7fWa1nESF5BuWrdi0Swi2WlGhL/pZiemrZyuxMCvI75Th48=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170301: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 16:16:13 +0000 flight 170301 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170301/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 916 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 16:18:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:18:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325867.548627 (Exim 4.92) (envelope-from ) id 1noSYm-00040o-Kt; Tue, 10 May 2022 16:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325867.548627; Tue, 10 May 2022 16:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSYm-00040h-HY; Tue, 10 May 2022 16:18:04 +0000 Received: by outflank-mailman (input) for mailman id 325867; Tue, 10 May 2022 16:18:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSYj-00040P-EW for xen-devel@lists.xenproject.org; Tue, 10 May 2022 16:18:04 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1a85d54-d07c-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 18:17:59 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noSY8-0008UD-Jz; Tue, 10 May 2022 18:17:24 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1a85d54-d07c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DG+kC/U+ySej5D6tfV4OCa8YH0d8ESpuNC4bFJt4RU8=; b=C2KkFYKUIxmXZpa9w2+Tc0j2Ea RFFr76ch465vsOUiMZW1uqZNDnhRYy0QqpFeaougTFG9GOX2EvcKO8NnFtvJdvaTDSvmTGm5I6bLE gx/SYLZAEuVfjx7NJeu1tB8cieKdzixVjql/phg2ZRqRsu9xZgqdP1nbzw6Nv7UUXN3Dua0weQYl6 +N3ACyNpHY020LPMtgokauBK3/rzBv0qIzP0VJEueNDPsJdk0Noe60ugWXyfyRTapgsSXBPVXAg4/ oobDhrEfQYteiYAwrodL1TGkVGLJREzPqDYfYYN3sh0JBT6vnlq6trf1vxZCJI19NPJiA+YiSFKJe qkMs6K7A==; Message-ID: <244a412c-4589-28d1-bb77-d3648d4f0b12@igalia.com> Date: Tue, 10 May 2022 13:16:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-15-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 12:16, Petr Mladek wrote: > [...] > Hmm, this looks like a hack. PANIC_UNUSED will never be used. > All notifiers will be always called with PANIC_NOTIFIER. > > The @val parameter is normally used when the same notifier_list > is used in different situations. > > But you are going to use it when the same notifier is used > in more lists. This is normally distinguished by the @nh > (atomic_notifier_head) parameter. > > IMHO, it is a bad idea. First, it would confuse people because > it does not follow the original design of the parameters. > Second, the related code must be touched anyway when > the notifier is moved into another list so it does not > help much. > > Or do I miss anything, please? > > Best Regards, > Petr Hi Petr, thanks for the review. I'm not strong attached to this patch, so we could drop it and refactor the code of next patches to use the @nh as identification - but personally, I feel this parameter could be used to identify the list that called such function, in other words, what is the event that triggered the callback. Some notifiers are even declared with this parameter called "ev", like the event that triggers the notifier. You mentioned 2 cases: (a) Same notifier_list used in different situations; (b) Same *notifier callback* used in different lists; Mine is case (b), right? Can you show me an example of case (a)? You can see in the following patches (or grep the kernel) that people are using this identification parameter to determine which kind of OOPS trigger the callback to condition the execution of the function to specific cases. IIUIC, this is more or less what I'm doing, but extending the idea for panic notifiers. Again, as a personal preference, it makes sense to me using id's VS comparing pointers to differentiate events/callers. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 10 16:18:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325873.548639 (Exim 4.92) (envelope-from ) id 1noSZV-0004aO-U1; Tue, 10 May 2022 16:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325873.548639; Tue, 10 May 2022 16:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSZV-0004aH-RD; Tue, 10 May 2022 16:18:49 +0000 Received: by outflank-mailman (input) for mailman id 325873; Tue, 10 May 2022 16:18:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSZU-0004a3-9M for xen-devel@lists.xenproject.org; Tue, 10 May 2022 16:18:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSZT-0001ZM-Ig; Tue, 10 May 2022 16:18:47 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noSZT-0000gK-CC; Tue, 10 May 2022 16:18:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5hIBuWjHB89ohdv+iWOwRiZQUYeICQW1Fi3o0A9eY8g=; b=cdTP4QXoCa+r/HvkPRFizRNyb0 qHjynnoiGE8jYcbFtZv9gzDL6G7Sj1GpIu57YmTE0rx1L/jkd1hjnP62F/5ZdAJIF30XyXvGC1DtT 1bDIOzMY6ot2gsv/SBoKinY4CsOile9S8BZF4x4bD4YwyCeXNHkHOd7QeA0YOXq2liZQ=; Message-ID: Date: Tue, 10 May 2022 17:18:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/6] xen: implement byteswap To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Roger Pau Monne References: <2699787cd4ba1d71448bbcdf190d927e180e80b9.1652170719.git.lin.liu@citrix.com> <11269227-ba07-b2b1-c2ef-ea6309980f67@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/05/2022 13:10, Lin Liu （刘林） wrote: > On 10/05/2022 11:15, Lin Liu wrote: >> swab() is massively over complicated and can be simplified by builtins. > > NIT: "by builtins" -> "by re-implementing using compiler builtins". > >> The compilers provide builtin function to swap bytes. >> * gcc: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fonlinedocs%2Fgcc%2FOther-Builtins.html&data=05%7C01%7Clin.liu%40citrix.com%7Ce0b3d98d7f8d47b8fe8708da3275afcd%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C637877778294067911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HDTF1LDJcD2PLSCuM%2FjIz%2FWGf1CrYk0e%2FLox22%2FXnvQ%3D&reserved=0 >> * clang: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fclang.llvm.org%2Fdocs%2FLanguageExtensions.html&data=05%7C01%7Clin.liu%40citrix.com%7Ce0b3d98d7f8d47b8fe8708da3275afcd%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C637877778294067911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EvWcLMi2vtT9haQVo%2F9uXmjBh2zVLUzZAgU57i%2FFMNo%3D&reserved=0 >> This patch simplify swab() with builtins and fallback for old compilers. >> >> Signed-off-by: Lin Liu >> --- >> Cc: Stefano Stabellini >> Cc: Julien Grall >> Cc: Bertrand Marquis >> Cc: Volodymyr Babchuk >> Cc: Andrew Cooper >> Cc: George Dunlap >> Cc: Jan Beulich >> Cc: Wei Liu >> Cc: "Roger Pau Monné" >> Changes in v3: >> - Check __has_builtin instead of GNUC version >> >> Changes in v2: >> - Add fallback for compilers without __builtin_bswap >> - Implement with plain C instead of macros >> --- >> xen/arch/arm/include/asm/byteorder.h | 14 ++----- >> xen/arch/x86/include/asm/byteorder.h | 34 ++--------------- >> xen/include/xen/byteorder.h | 56 ++++++++++++++++++++++++++++ >> xen/include/xen/byteswap.h | 44 ++++++++++++++++++++++ >> xen/include/xen/compiler.h | 12 ++++++ >> 5 files changed, 120 insertions(+), 40 deletions(-) >> create mode 100644 xen/include/xen/byteorder.h >> create mode 100644 xen/include/xen/byteswap.h >> >> diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h >> index 9c712c4788..622eeaba07 100644 >> --- a/xen/arch/arm/include/asm/byteorder.h >> +++ b/xen/arch/arm/include/asm/byteorder.h >> @@ -1,16 +1,10 @@ >> #ifndef __ASM_ARM_BYTEORDER_H__ >> #define __ASM_ARM_BYTEORDER_H__ >> >> -#define __BYTEORDER_HAS_U64__ >> +#ifndef __BYTE_ORDER__ >> + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ >> +#endif >> >> -#include >> +#include >> >> #endif /* __ASM_ARM_BYTEORDER_H__ */ >> -/* >> - * Local variables: >> - * mode: C >> - * c-file-style: "BSD" >> - * c-basic-offset: 4 >> - * indent-tabs-mode: nil >> - * End: >> - */ > >>> This change looks unrelated to this patch. Can you explain it? > > Do you mean following code block? Yes, it is unrelated, I removed it as I found some files does not include such field. So in general we try to avoid unrelated change within a same patch. In this case, the emacs magic should be present in the files rather than the other way around. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 16:23:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325879.548649 (Exim 4.92) (envelope-from ) id 1noSdZ-0006Fk-FG; Tue, 10 May 2022 16:23:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325879.548649; Tue, 10 May 2022 16:23:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSdZ-0006Fd-CJ; Tue, 10 May 2022 16:23:01 +0000 Received: by outflank-mailman (input) for mailman id 325879; Tue, 10 May 2022 16:23:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSdY-0006FX-1O for xen-devel@lists.xenproject.org; Tue, 10 May 2022 16:23:00 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74432bad-d07d-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 18:22:58 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A84FA5C010B; Tue, 10 May 2022 12:22:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 10 May 2022 12:22:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 May 2022 12:22:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74432bad-d07d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652199777; x= 1652286177; bh=1UppJaWRmY+TpH9pFD4Bb1MUuqhQ2NuSH1H9Qg1JflE=; b=y Ya8NVX/ZsHe2CeMLX9qVmRa/CqR8I8YlTDyWnO/O9DD9aONO3AHc1LQM0WTpn6+E 9BYKbjZRuqdIDCuaGc8mTF9gjbwFzTt3CEn18ijMIyGceQzYGwNvnLsZsuJhNa07 5yAQDwfJ7qQMMXBWSMK8KfHKUESIsGQt3weWzcD7P24Xdtxx7NiyTsF4QV0iJ3oO OIINy1+17/ldfino/HGI3/chx8T0wg+E4j/VooULXUvqdwGXCpRb8+xVXrAd02aN 6O1i8kpwyBIZT1XRxCPghmhSEZB34HSkjWSpJWsd5WgkTsaRqtJI5UXR/MTP0A0r I/CgRQ7dBXxT699aDh6Ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedugdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Date: Tue, 10 May 2022 12:22:51 -0400 From: Demi Marie Obenour To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Mariusz Zaborski Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KflJpp5jPHHKA+Y8" Content-Disposition: inline In-Reply-To: --KflJpp5jPHHKA+Y8 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 10 May 2022 12:22:51 -0400 From: Demi Marie Obenour To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Mariusz Zaborski Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback On Tue, May 10, 2022 at 12:57:48PM +0200, Roger Pau Monn=C3=A9 wrote: > On Thu, May 05, 2022 at 08:30:17PM -0400, Demi Marie Obenour wrote: > > Proposal: Check disk sequence numbers in blkback > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >=20 > > Currently, adding block devices to a domain is racy. libxl writes the > > major and minor number of the device to XenStore, but it does not keep > > the block device open until blkback has opened it. This creates a race > > condition, as it is possible for the device to be destroyed and another > > device allocated with the same major and minor numbers. Loop devices > > are the most obvious example, since /dev/loop0 can be reused again and > > again, but the same problem can also happen with device-mapper devices. > > If the major and minor numbers are reused before blkback has attached to > > the device, blkback will pass the wrong device to the domain, with > > obvious security consequences. > >=20 > > Other programs on Linux have the same problem, and a solution was > > committed upstream in the form of disk sequence numbers. A disk > > sequence number, or diskseq, is a 64-bit unsigned monotonically > > increasing counter. The combination of a major and minor number and a > > disk sequence number uniquely identifies a block device for the entire > > uptime of the system. >=20 > Seems fine to me, this is just an extra check to make sure the block > device opened by blkback is the one that user space intended. I would > see diskseq as a kind of checksum. Ideally, diskseq would be the primary means of identifying a device, but that isn=E2=80=99t an option without more substantial changes, sadly. > > I propose that blkback check for an unsigned 64-bit hexadecimal XenStore > > entry named =E2=80=9Cdiskseq=E2=80=9D. If the entry exists, blkback ch= ecks that the > > number stored there matches the disk sequence number of the device. If > > it does not exist, the check is skipped. If reading the entry fails for > > any other reason, the entry is malformed, or if the sequence number is > > wrong, blkback refuses to export the device. > >=20 > > The toolstack changes are more involved for two reasons: > >=20 > > 1. To ensure that loop devices are not leaked if the toolstack crashes, > > they must be created with the delete-on-close flag set. This > > requires that the toolstack hold the device open until blkback has > > acquired a handle to it. >=20 > Does this work with loop devices? I would expect that you need to > issue a losetup call to detach the device. That is what the autoclear flag is for. It will cause the device to be destroyed by the kernel as soon as the last handle to it has been closed. This is why the toolstack needs to hold a file descriptor to the device. > Even more, the loop device is created by the block script, but there's > also a window between the block script execution and the toolstack > knowing about the device, which could also allow for a leak? For this to work, either the toolstack or block script will need to open the file and perform loop(4) ioctls to assign the file descriptor to a loop device. This cannot be done by a shell script, so I plan on using a C program to perform these tasks. In Qubes OS, I expect this program to replace the block script entirely, as performance is critical and flexibility less so. For upstream, I recommend having the block script be a script that calls this C program. > > 2. For block devices that are opened by path, the toolstack needs to > > ensure that the device it has opened is actually the device it > > intended to open. This requires device-specific verification of the > > open file descriptor. This is not needed for regular files, as the > > LOOP_CONFIGURE ioctl is called on an existing loop device and sets > > its backing file. > >=20 > > The first is fairly easy in C. It can be accomplished by means of a > > XenStore watch on the =E2=80=9Cstatus=E2=80=9D entry. Once that watch = fires, blkback > > has opened the device, so the toolstack can safely close its file > > descriptor. >=20 > Does the toolstack really need to close the device? What harm does it > do to keep the handle open until the domain is destroyed? This would cause no harm, but it also would not help either, so I do not see any advantages to doing it. > What about disk hotplug? Which entity will keep the device opened in > that case? Is xl block-attach going to block until the device > switches to the connected state? Whichever program opens the file will need to do this. This could be the program that is using libxl or the block script that libxl invokes. I am not familiar with xl block-attach as Qubes OS uses a custom wrapper around libvirt. > > The second is significantly more difficult. It requires the block > > script to be aware of at least device-mapper devices and LVM2 logical > > volumes. The general technique is common to all block devices: obtain > > the sequence number (via the BLKGETDISKSEQ() ioctl) and its major and > > minor numbers (via fstat()). Then open /sys/dev/block/MAJOR:MINOR to > > get a directory file descriptor, and use openat(2) and read(2) to get > > various sysfs attributes. Finally, read the diskseq sysfs attribute and > > check that it matches the sequence number from BLKGETDISKSEQ(). > > Alternatively, one can use device-specific methods, such as > > device-mapper ioctls. > >=20 > > Device-mapper devices can be detected via the =E2=80=98dm/name=E2=80=99= sysfs attribute, > > which must match the name under =E2=80=98/dev/mapper/=E2=80=99. If the= name is of the > > form =E2=80=98/dev/X/Y=E2=80=99, and the =E2=80=98dm/uuid=E2=80=99 attr= ibute starts with the literal > > string =E2=80=9CLVM-=E2=80=9D, then the expected =E2=80=98dm/name=E2=80= =99 attribute should be found by > > doubling all =E2=80=98-=E2=80=99 characters in X and Y, and then joinin= g X and Y with > > another =E2=80=98-=E2=80=99. This accounts for LVM2 logical volumes. = Alternatively, > > one can use device-mapper ioctls to both check if a device is a > > device-mapper device, and to obtain its name and UUID. I plan on going > > with the latter route. >=20 > Likely a stupid remark, but needs obviously needs to be kept to Linux > only. Indeed so. I have CC=E2=80=99d Mariusz Zaborski to check if FreeBSD needs = any similar changes. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --KflJpp5jPHHKA+Y8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ6kV8ACgkQsoi1X/+c IsE8IQ//fpGTDbYyMzWRW9vIKj8K6G5tMSNbiWfo9ZrADxDGh10O2fuRmMAn0NHq 7BKfJ8xqe545XlU0pglm2FHG9EwqEtyY+LXItY7OYJlxznJ82688vQ/p2wGHNNsy UUh4IUUE4CRjJdqj86pGQKzdUO2vPCNmul6wak4oC2SHe3Y0oI9VIb3jbKHvBUgi 44oezeoQQDDDmjQrD+2uhDU1pPIHqO+iFynlYLYrd26AzyiysXxRwbmb6jDE8DU5 5llD0JCrPhlklgjPfnUvShGzzp1phWBl/Kzhh1MoMlTuRI65adwZS3JQ/1EZzKw8 URBYK+zPhR0MDdAeBIVUey8vRpCS+CUboH1Q6j2RrTCrIUj4o/OfiG7swqiBNutp TZ/2qO8OBkmmiu4Z2w8GuvVULBukjytcjlG1gDjlV4FyPmemKofqOHrod1vWcLht Woy9x6qqJJGqOLRIsSaGmrPcTwF3ab4hQ0cjmwPh6UesSNsDrns+4LD9JjD/vbGG j3VZm+kQhjQQM27XZfRveUbunszTvBWaL4ZPqHwA5v4DHV5nwxxit+9hfpMBDlI0 JAAnyyKATYvFhrCCCHf2W4I2qGD/9C7+WEgekoQjqjDH2si00ggD8fKtwNV6mLYm Q0wUfNdVtACwAywuilBT00NpBhAYU8vyOEv2Mbk38iGbz1Bsm9Q= =edMS -----END PGP SIGNATURE----- --KflJpp5jPHHKA+Y8-- From xen-devel-bounces@lists.xenproject.org Tue May 10 16:31:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:31:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325890.548661 (Exim 4.92) (envelope-from ) id 1noSlR-0007kx-GE; Tue, 10 May 2022 16:31:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325890.548661; Tue, 10 May 2022 16:31:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSlR-0007kq-DN; Tue, 10 May 2022 16:31:09 +0000 Received: by outflank-mailman (input) for mailman id 325890; Tue, 10 May 2022 16:31:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSlP-0007kk-1p for xen-devel@lists.xenproject.org; Tue, 10 May 2022 16:31:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0631.outbound.protection.outlook.com [2a01:111:f400:fe0c::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95bb81b3-d07e-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 18:31:04 +0200 (CEST) Received: from DB6PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::28) by PAXPR08MB6397.eurprd08.prod.outlook.com (2603:10a6:102:12f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Tue, 10 May 2022 16:30:55 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::11) by DB6PR1001CA0042.outlook.office365.com (2603:10a6:4:55::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Tue, 10 May 2022 16:30:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 16:30:54 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 10 May 2022 16:30:54 +0000 Received: from 59ffd3175b40.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9280C3EE-FD7D-4DC4-A976-7AD1C9B79635.1; Tue, 10 May 2022 16:30:48 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 59ffd3175b40.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 16:30:48 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by AM6PR08MB3080.eurprd08.prod.outlook.com (2603:10a6:209:4c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Tue, 10 May 2022 16:30:45 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Tue, 10 May 2022 16:30:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95bb81b3-d07e-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NphANF8vM5UIPp7upLLqu1z6c5u2tf/xB9re3IvS/yCbGz6jnbhs5w+SZnSCXl1ouhi793Q7U0DVrgN9nkpn4MFsMB7k34Zc7zVQZLMtJjS9kLXXAeIMYSMbgta9IKNUD/6i+oE50T/a7LM39m7FLIHuM/MNQJ0+dmmVLTsPTCEE+gUhXcO4XvvhmlKggd3i6t2rMdzvS3z5BqZGbXsXfHdyNGE3/Ijx9X9GkLolwg+4OjZ5F1+DkHVcJoxq0olP4IyLDcYCex2l53CzTC843iDKab8r28uYGZbJ+NaqJvhwvL4DH0+iXQHBvd7tRb7UrhAZEGJKhqXIi90JiEPWKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnuWlPfkWyArRFxmCIf95KmFmIIooSlgdjjb6uxE4+k=; b=gbKJn2BNm/JxZ9fSf9OwpIxcV5OH4Wy15dDJ5mh+4KWxRXJvFQnRQd+W+DTv+RUB66nqbAbeMkxXBzA5GFRAXZUI6LSJYVk6lGQuq1ZnL4fT8Gu+RuG16VMK9/x5f4agNkjyxYs6ZZp4OEyGzgj0pUYyxKKAOZxqkUTgGpB8Z3fnYfAMXU0YoU5SeT6X23MwxS3EQ1ISw9myzUZM1+X2o7hFhlh/4FF8E0kRtDrqRDY8juH2p2A/2XAmg6vDU8UVKXpRFkknBuWs9ckyCmM3PjB/Z7cwLofZCuVjNPjY54MIcKIRZPfXshAF+qymvuY9/f0OCmoxoc6uiVw+qSNECw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnuWlPfkWyArRFxmCIf95KmFmIIooSlgdjjb6uxE4+k=; b=e4P1GFg3WK9agqQveH32cE30celWXczlzlB211o0Oze5S3n+hWKz9XcdpmEVx2JKJLRTfPvWbRSoaMeoZYXMa8JeNG/0cbKMmtBHdQdQ+yanZZ+JNS/I0jt7wmx6ZLYGS9LzWRH6d/Y1GUclJdMrERA4RJHVUro24dRIl+mPxrI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 50c8826e3309cba5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWmGEdG88wUe3MsrdYKZIKbUScesf6ML3eHUN1zcB2lbYu8XXKMxZmTAFkXxbk+f1w22EMg3+ELFE7gNoSmHUcrfMSqLofsCEgfZKTsLioEzfpP17bGt1fXegIzc0y0Hj1dCTcQIXstHUm5HcIhm144GpoxvKFBDVdLCsO4X3szrvQUWTw/7Pv5RQ3tqdKhmfNYChtaU7AZvGPL45fpIn89F9ZVOgDpWiYFbtd3LL77whOsE38DCEu56jo4sh+CeAPf20TiNpK/l6Z/Zm2JrUtvo5OAUq6tESC2zRKQ8R9D1AmoU3DH2s21N6K1xIsiX8pxNumNV7TUgYYa/in1Mhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnuWlPfkWyArRFxmCIf95KmFmIIooSlgdjjb6uxE4+k=; b=eOLSz9/sFEpiPAiJDwstWf5B+9mCu4l1i7urfZUi/zWaLcS+Tqi0CkaOkRhgxNI5H0rsBFB7lt4ZHl7kzeeUH5dBg29JxrHZ8EyL1WjuqwRXvucNNbZ9OBBGgzYQNCZR1QMQQWY6gesmgXLv4H4Jnwteig1sfAMv12W78Am5fkvAG45u4agEhUcHHbvPPF1yUK0kpIbgyzq3nnoexMrj7unL3ItmeCl6vt162S2hAy8s9hoGbZHCe8pDPpgJz1LyvYa2sGiEoxflIBLy0OcalL07tF7b6ceSmJ1gTu4bxFq014wGzp7FSyv/UgTRmsAqh+gr4OA3vJN9bJXqFcAO6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnuWlPfkWyArRFxmCIf95KmFmIIooSlgdjjb6uxE4+k=; b=e4P1GFg3WK9agqQveH32cE30celWXczlzlB211o0Oze5S3n+hWKz9XcdpmEVx2JKJLRTfPvWbRSoaMeoZYXMa8JeNG/0cbKMmtBHdQdQ+yanZZ+JNS/I0jt7wmx6ZLYGS9LzWRH6d/Y1GUclJdMrERA4RJHVUro24dRIl+mPxrI= From: Rahul Singh To: Stefano Stabellini CC: xen-devel , Juergen Gross , Bertrand Marquis , "julien@xen.org" , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBWH2ZK8TL5ueU+mSOXui+uVga0YVmwA Date: Tue, 10 May 2022 16:30:45 +0000 Message-ID: <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> In-Reply-To: <20220505001656.395419-4-sstabellini@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ca486ac3-741e-48ae-dbe8-08da32a27498 x-ms-traffictypediagnostic: AM6PR08MB3080:EE_|DBAEUR03FT011:EE_|PAXPR08MB6397:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VX7nQtwFxQr6t0DG92NZv4GAjteo9h2kSBMm3XLB0NzQmLdJeDGWLNyHf2OaQcKcL7prY0E7fbNbMcQG3ZEvsIsu292r+7FRYX6x3Has9Gn+yFwdGUoV+5J1tcfNffQ98/0EaoQQ5sMt31oEDYUVV0qEOxT4E/WWMPzaNFY4aYvvyAtc7yRtZ5beZ2l8xnK8W28evihr1lxwpyFuUZB7NoJvAz7qEvqoPLRu83wkAnr5olKpuUwQ1A7usa/mOmiOQ+kEZbDlgcYmM/BQfcpNdEAl/TF7idL2EEQLWhDxhcr60LAdTXyDTm2fQ2kRz53qEa8kd1y/sekrTRg/KJAqYVp3obUYqc4hnqWgEZ/HRqunYHsVQdCNtP4BWrqFpngh0SkZlZXsSoD87a/8oTc4lVnnAbcbfSeoU42Oydtnv7QNSpkUXpVvksXe/rTioH+fR0V+alC5liI0FbWad6Takk04MTt2odJq1wRjyH95FR77CvRvGGIZJfmFRCbrPUXiBAfqQd+RqmQL0ZHep2TTgqQwbCAsCrqeYgwtqIW1j7EBvYhp+ex26TjucfyvS9837sn+We7epxVc9TgYOyxqy8L9WuegMVlj4cuMzdEnXn7OCX66F3xNLBbKYMn/zz665TmNmbWVvzJQgq9Ve5JnQPHEpu+5lLQTyFU6o5cSubxZtlKfNuOTg+0AvGypsFuB+K2kbaj3EiPXTAF6ebPp5icp4Xv1Zfr2a0btCGq0LyXcL074LYri5ULon4446KLwiEEukKhLBmHAIIL812Rjsw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(86362001)(6512007)(186003)(2616005)(5660300002)(8936002)(122000001)(2906002)(83380400001)(8676002)(4326008)(66446008)(66476007)(66946007)(64756008)(38100700002)(66556008)(38070700005)(91956017)(76116006)(6486002)(71200400001)(6506007)(6916009)(33656002)(54906003)(508600001)(53546011)(316002)(36756003)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3080 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2911d839-fa6d-4e56-46d4-08da32a26edb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eeMKgIDyzC+VVVPnGWI8OCgIbnoy+qdCVynPKCPXfRMS2eh2opksoXCvS/uCQWtcjaxliB+AJbIP+lTNPpjmpX1JQs89y0jSeDvjqpyumdm2skpW+Zknb3h0OuL2CfW2N7gDyJLVRsZ6EtR2Ae0kMgOsOQ09/dAX/skUhR5+QluIOD1LEjzOxmU2FOjnKBzyaZpYTBH63gMDof3dfRrJrAQUODw2njSB2oIhIbOqLa6oPYIziwi9IdxV6a04u1j8IEdUt9s0JOM8mf54dLEt2ZXTednoy6Dcz/MOlJyYnFxXiHMXJgpdIGB0TsvsxJdowww8+gOtccLX6NCASdO4W1unzDyuqDM/AT2me8nIczPe92aG65Bixcs8Pp4qqRtq9xI44GMXtixciEE53WfWbkBwQ3UUfVe95NWtBTFqKtbpr2pDvXcefsMyqagNP6kjikrH+xvWY1zubOIz9uwFwdiOJjjKHRMbspgSYrj0OiflnPQmRPcGbaO1XmoGHAXMTvrYeO0zawrbxIjiIZSeFoB3zvYEjEA7yu1h/a/GFrkUnAa59OJOyDtWJPzqTIqthd+BYlqpXOMZQOrD6bgXa/oOiZjBgHwTs9q/VeYCYSkBMSoX4LvF0SQYApmEbiX7GL6lFReBrdgwJjcVMv1BO4Xcquz7uWsB6PX+n6u4weY0NWSjY7eDcW+1CM4YIBUS+PU6TiJO8Mjeg666OkaTVg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(508600001)(6486002)(316002)(8936002)(54906003)(36860700001)(86362001)(356005)(8676002)(4326008)(70206006)(6862004)(70586007)(81166007)(26005)(6512007)(40460700003)(83380400001)(6506007)(53546011)(186003)(2616005)(107886003)(2906002)(82310400005)(336012)(47076005)(33656002)(36756003)(5660300002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 16:30:54.8455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca486ac3-741e-48ae-dbe8-08da32a27498 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6397 Hi Stefano, > On 5 May 2022, at 1:16 am, Stefano Stabellini wr= ote: >=20 > From: Luca Miccio >=20 > Export evtchn_alloc_unbound and make it __must_check. >=20 > If "xen,enhanced" is enabled, then add to dom0less domains: >=20 > - the hypervisor node in device tree > - the xenstore event channel >=20 > The xenstore event channel is also used for the first notification to > let the guest know that xenstore has become available. >=20 > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: jbeulich@suse.com >=20 > --- > Changes in v5: > - merge with "xen: export evtchn_alloc_unbound" > - __must_check >=20 > Changes in v3: > - use evtchn_alloc_unbound >=20 > Changes in v2: > - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation > - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound >=20 > xen: export evtchn_alloc_unbound >=20 > It will be used during dom0less domains construction. >=20 > Signed-off-by: Stefano Stabellini > --- > xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++ > xen/common/event_channel.c | 2 +- > xen/include/xen/event.h | 3 +++ > 3 files changed, 41 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 016f56a99f..bb430f2189 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include >=20 > #include > #include > @@ -2810,6 +2811,8 @@ static int __init prepare_dtb_domU(struct domain *d= , struct kernel_info *kinfo) > int ret; >=20 > kinfo->phandle_gic =3D GUEST_PHANDLE_GIC; > + kinfo->gnttab_start =3D GUEST_GNTTAB_BASE; > + kinfo->gnttab_size =3D GUEST_GNTTAB_SIZE; >=20 > addrcells =3D GUEST_ROOT_ADDRESS_CELLS; > sizecells =3D GUEST_ROOT_SIZE_CELLS; > @@ -2884,6 +2887,13 @@ static int __init prepare_dtb_domU(struct domain *= d, struct kernel_info *kinfo) > goto err; > } >=20 > + if ( kinfo->dom0less_enhanced ) > + { > + ret =3D make_hypervisor_node(d, kinfo, addrcells, sizecells); > + if ( ret ) > + goto err; > + } > + > ret =3D fdt_end_node(kinfo->fdt); > if ( ret < 0 ) > goto err; > @@ -3150,6 +3160,25 @@ static int __init construct_domain(struct domain *= d, struct kernel_info *kinfo) > return 0; > } >=20 > +static int __init alloc_xenstore_evtchn(struct domain *d) > +{ > + evtchn_alloc_unbound_t alloc; > + int rc; > + > + alloc.dom =3D d->domain_id; > + alloc.remote_dom =3D hardware_domain->domain_id; I tried to test the patch series with two dom0less domUs without dom0 and o= berved the below error. This error is because there is no hardware_domain in that case. (XEN) Data Abort Trap. Syndrome=3D0x6 (XEN) Walking Hypervisor VA 0x0 on CPU0 via TTBR 0x00000000f91f5000 (XEN) 0TH[0x0] =3D 0x00000000f91f4f7f (XEN) 1ST[0x0] =3D 0x00000000f91f1f7f (XEN) 2ND[0x0] =3D 0x0000000000000000 (XEN) CPU0: Unexpected Trap: Data Abort (XEN) ----[ Xen-4.17-unstable arm64 debug=3Dy Not tainted ]---- (XEN) CPU: 0 (XEN) PC: 00000000002e4180 domain_build.c#construct_domU+0xc90/0xd0c (XEN) LR: 00000000002e4178 (XEN) SP: 000000000031e450 (XEN) CPSR: 0000000060000249 MODE:64-bit EL2h (Hypervisor, handler) (XEN) X0: 0000000000000000 X1: 0000000000000000 X2: 0000000000000000 (XEN) X3: 0000000000000005 X4: 0000000000000000 X5: 0000000000000028 (XEN) X6: 0000000000000080 X7: fefefefefefeff09 X8: 7f7f7f7f7f7f7f7f (XEN) X9: ff6f606c2c68726c X10: 7f7f7f7f7f7f7f7f X11: 0101010101010101 (XEN) X12: 0000000000000008 X13: 00000000002ca000 X14: 00000000002cb000 (XEN) X15: 6db6db6db6db6db7 X16: fffffff800000000 X17: 0000000000000001 (XEN) X18: 0180000000000000 X19: 0000800763a34000 X20: 0000000000000000 (XEN) X21: 000000000031e4c0 X22: 000000000031e4d0 X23: 0000000000000003 (XEN) X24: 000000000031fdfc X25: 0000008400000000 X26: 0000000000000021 (XEN) X27: 0000000000300d08 X28: 00000000003fe97f FP: 000000000031e450 (XEN)=20 (XEN) VTCR_EL2: 00000000800d3590 (XEN) VTTBR_EL2: 00000083e3a67000 (XEN)=20 (XEN) SCTLR_EL2: 0000000030cd183d (XEN) HCR_EL2: 0000000080000039 (XEN) TTBR0_EL2: 00000000f91f5000 (XEN)=20 (XEN) ESR_EL2: 0000000096000006 (XEN) HPFAR_EL2: 0000000000000000 (XEN) FAR_EL2: 0000000000000000 (XEN)=20 (XEN) Xen stack trace from sp=3D000000000031e450: (XEN) 000000000031fda0 00000000002e5484 0000800763ff2390 00000000002f1ae= 0 (XEN) 00000000002c98c8 000000000031fde0 0000000000000003 000000000031fdf= c (XEN) 0000008400000000 0000000000000021 0000000000300d08 00000000003fe97= f (XEN) 00c2010000000000 000000000031e4e0 0000000000000000 00000000040f000= 0 (XEN) 0000002200000001 0010000000000000 0000020300000000 000000010000000= 0 (XEN) 00000000000c0000 0000000000000000 0000000000000001 0000800763a3400= 0 (XEN) 0000800763a0c000 0000000000000000 0000000000000001 00000000a000000= 0 (XEN) 0000000030000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) 0000000000000000 0000000000000000 0000000000000000 000000000000000= 0 (XEN) Xen call trace: (XEN) [<00000000002e4180>] domain_build.c#construct_domU+0xc90/0xd0c (PC= ) (XEN) [<00000000002e4178>] domain_build.c#construct_domU+0xc88/0xd0c (LR= ) (XEN) [<00000000002e5484>] create_domUs+0xb4/0x1e8 (XEN) [<00000000002e999c>] start_xen+0xaf0/0xbe8 (XEN) [<00000000002001a0>] arm64/head.o#primary_switched+0xc/0x1c (XEN)=20 (XEN)=20 (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) CPU0: Unexpected Trap: Data Abort (XEN) **************************************** =20 > + rc =3D evtchn_alloc_unbound(&alloc); > + if ( rc ) > + { > + printk("Failed allocating event channel for domain\n"); > + return rc; > + } > + > + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] =3D alloc.port; > + > + return 0; > +} > + > static int __init construct_domU(struct domain *d, > const struct dt_device_node *node) > { > @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; >=20 > + if ( kinfo.dom0less_enhanced ) I think we need to do something like this to fix the error. if ( hardware_domain && kinfo.dom0less_enhanced ) { } > + { > + rc =3D alloc_xenstore_evtchn(d); > + if ( rc < 0 ) > + return rc; > + d->arch.hvm.params[HVM_PARAM_STORE_PFN] =3D ~0ULL; > + } > + > return rc; > } =20 Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Tue May 10 16:35:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325896.548671 (Exim 4.92) (envelope-from ) id 1noSpU-0000D3-4T; Tue, 10 May 2022 16:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325896.548671; Tue, 10 May 2022 16:35:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSpU-0000Cw-1X; Tue, 10 May 2022 16:35:20 +0000 Received: by outflank-mailman (input) for mailman id 325896; Tue, 10 May 2022 16:35:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSpT-0000Cq-8L for xen-devel@lists.xenproject.org; Tue, 10 May 2022 16:35:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noSpS-0001qJ-KN; Tue, 10 May 2022 16:35:18 +0000 Received: from [54.239.6.189] (helo=[192.168.24.150]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noSpS-0001na-Du; Tue, 10 May 2022 16:35:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Lok7NcgowaSocHlF+3kALI8krImFTVbkL+lIoDgLr4M=; b=vBhmlsZ03+KNLMFEJOR1WsL5CN sBQADLtJuPEisf0JIiK4LCf2dcM3dOwQ9gaeEPKQh2wkGWEzst2yJnXTVPLcm9Z+aNFTRIMOCBkvh GUsKNEn+I0n761kFl3yqMmQFSx4RLWGzmM422oYkOglTu7s62uz2ZATHnA5hxo6Jyag0=; Message-ID: Date: Tue, 10 May 2022 17:35:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Rahul Singh , Stefano Stabellini Cc: xen-devel , Juergen Gross , Bertrand Marquis , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> From: Julien Grall In-Reply-To: <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 10/05/2022 17:30, Rahul Singh wrote: >> + rc = evtchn_alloc_unbound(&alloc); >> + if ( rc ) >> + { >> + printk("Failed allocating event channel for domain\n"); >> + return rc; >> + } >> + >> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; >> + >> + return 0; >> +} >> + >> static int __init construct_domU(struct domain *d, >> const struct dt_device_node *node) >> { >> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, >> if ( rc < 0 ) >> return rc; >> >> + if ( kinfo.dom0less_enhanced ) > > I think we need to do something like this to fix the error. > if ( hardware_domain && kinfo.dom0less_enhanced ) > { > > } Is there any use case to use "dom0less_enhanced" without dom0 (or a domain servicing Xenstored)? If not, then I would consider to forbid this case and return an error. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 10 16:55:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 16:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325904.548691 (Exim 4.92) (envelope-from ) id 1noT8s-0003Bo-RM; Tue, 10 May 2022 16:55:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325904.548691; Tue, 10 May 2022 16:55:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noT8s-0003Bh-OG; Tue, 10 May 2022 16:55:22 +0000 Received: by outflank-mailman (input) for mailman id 325904; Tue, 10 May 2022 16:55:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noT8q-0003B1-Uh; Tue, 10 May 2022 16:55:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noT8q-0002Bh-SC; Tue, 10 May 2022 16:55:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noT8q-0005VI-8U; Tue, 10 May 2022 16:55:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noT8q-0003h4-7z; Tue, 10 May 2022 16:55:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fQLv9EBUd1Q4YnHYNTzars5KFMzOyE0dswiNJlWGNfY=; b=2InaeyKiYkXtxYSAYUMO0Y+Olr +QEs9yQlwOSwF50ThczX5Eczi/c3KsdhTrgTUFLCeedZaWJ/+Gak7Ij3KVpaI4WRireSvyCnf3vLJ bP2rTgO1LA44PZrXlhuZhQx0mJE2qH1UXq+LzhATXWl4HmX9ClYC+ladqVF0a1RjRJYU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170293: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0badfb110fa33ca9ffd3bdc3a5200cded03e6106 X-Osstest-Versions-That: xen=95604873ccf56eb81e96ed0dc8b4dec3278f40ca From: osstest service owner Date: Tue, 10 May 2022 16:55:20 +0000 flight 170293 xen-unstable real [real] flight 170302 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170293/ http://logs.test-lab.xenproject.org/osstest/logs/170302/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-seattle 8 xen-boot fail pass in 170302-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 170302 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 170302 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170281 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170281 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170281 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170281 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170281 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170281 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170281 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170281 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170281 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170281 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170281 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170281 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 baseline version: xen 95604873ccf56eb81e96ed0dc8b4dec3278f40ca Last test of basis 170281 2022-05-09 23:09:13 Z 0 days Testing same since 170293 2022-05-10 08:28:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 95604873cc..0badfb110f 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 -> master From xen-devel-bounces@lists.xenproject.org Tue May 10 17:09:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 17:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325918.548722 (Exim 4.92) (envelope-from ) id 1noTMi-0005Hy-Ir; Tue, 10 May 2022 17:09:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325918.548722; Tue, 10 May 2022 17:09:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTMi-0005Hr-Fr; Tue, 10 May 2022 17:09:40 +0000 Received: by outflank-mailman (input) for mailman id 325918; Tue, 10 May 2022 17:09:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTMh-0005Hh-P2; Tue, 10 May 2022 17:09:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTMh-0002TG-Mu; Tue, 10 May 2022 17:09:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTMh-0005ol-6i; Tue, 10 May 2022 17:09:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noTMh-0005NO-6F; Tue, 10 May 2022 17:09:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ii5v3/ORmeGR/UgiEQ1zrifOJNCZiHCHJavX33p+IXc=; b=TixOTf++URdkaFFrqsxWG0iq4Y QKS1flZNnZ61/HcxxH1JLw1+stgAAeijVvtJ6mAKy9WfAHKXB5OmdH/7xItH6ofeH8GT9UY/9ErG4 zes/U5MaYGWCcxUGtT+druyQbFIO1ILPtbRYHhjhzXaPyzV6j96FmtVskrfqAlHbrMCc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170303: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 17:09:39 +0000 flight 170303 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170303/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 917 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 17:20:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 17:20:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325926.548733 (Exim 4.92) (envelope-from ) id 1noTXB-0007m5-LX; Tue, 10 May 2022 17:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325926.548733; Tue, 10 May 2022 17:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTXB-0007ly-Id; Tue, 10 May 2022 17:20:29 +0000 Received: by outflank-mailman (input) for mailman id 325926; Tue, 10 May 2022 17:20:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTXA-0007ls-5H for xen-devel@lists.xenproject.org; Tue, 10 May 2022 17:20:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a7f4d3b-d085-11ec-a406-831a346695d4; Tue, 10 May 2022 19:20:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08353618CD; Tue, 10 May 2022 17:20:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BA9BC385A6; Tue, 10 May 2022 17:20:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a7f4d3b-d085-11ec-a406-831a346695d4 Date: Tue, 10 May 2022 13:20:15 -0400 From: Steven Rostedt To: Petr Mladek Cc: "Guilherme G. Piccoli" , Evan Green , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Message-ID: <20220510132015.38923cb2@gandalf.local.home> In-Reply-To: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 10 May 2022 13:38:39 +0200 Petr Mladek wrote: > As already mentioned in the other reply, panic() sometimes stops > the other CPUs using NMI, for example, see kdump_nmi_shootdown_cpus(). > > Another situation is when the CPU using the lock ends in some > infinite loop because something went wrong. The system is in > an unpredictable state during panic(). > > I am not sure if this is possible with the code under gsmi_dev.lock > but such things really happen during panic() in other subsystems. > Using trylock in the panic() code path is a good practice. I believe that Peter Zijlstra had a special spin lock for NMIs or early printk, where it would not block if the lock was held on the same CPU. That is, if an NMI happened and paniced while this lock was held on the same CPU, it would not deadlock. But it would block if the lock was held on another CPU. -- Steve From xen-devel-bounces@lists.xenproject.org Tue May 10 17:29:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 17:29:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325936.548744 (Exim 4.92) (envelope-from ) id 1noTfz-0000I2-Jn; Tue, 10 May 2022 17:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325936.548744; Tue, 10 May 2022 17:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTfz-0000Hu-Gg; Tue, 10 May 2022 17:29:35 +0000 Received: by outflank-mailman (input) for mailman id 325936; Tue, 10 May 2022 17:29:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTfy-0000Ho-Cv for xen-devel@lists.xenproject.org; Tue, 10 May 2022 17:29:34 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c100f377-d086-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 19:29:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D1D5B81E8F; Tue, 10 May 2022 17:29:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2BFC385C2; Tue, 10 May 2022 17:29:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c100f377-d086-11ec-8fc4-03012f2f19d4 Date: Tue, 10 May 2022 13:29:22 -0400 From: Steven Rostedt To: Xiaoming Ni Cc: "Guilherme G. Piccoli" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Arjan van de Ven , Cong Wang , Sebastian Andrzej Siewior , Valentin Schneider Subject: Re: [PATCH 18/30] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set Message-ID: <20220510132922.61883db0@gandalf.local.home> In-Reply-To: <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-19-gpiccoli@igalia.com> <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Apr 2022 09:01:13 +0800 Xiaoming Ni wrote: > > +#ifdef CONFIG_DEBUG_NOTIFIERS > > + { > > + char sym_name[KSYM_NAME_LEN]; > > + > > + pr_info("notifiers: registered %s()\n", > > + notifier_name(n, sym_name)); > > + } > > Duplicate Code. > > Is it better to use __func__ and %pS? > > pr_info("%s: %pS\n", __func__, n->notifier_call); > > > > +#endif Also, don't sprinkle #ifdef in C code. Instead: if (IS_ENABLED(CONFIG_DEBUG_NOTIFIERS)) pr_info("notifers: regsiter %ps()\n", n->notifer_call); Or define a print macro at the start of the C file that is a nop if it is not defined, and use the macro. -- Steve From xen-devel-bounces@lists.xenproject.org Tue May 10 17:40:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 17:40:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325946.548755 (Exim 4.92) (envelope-from ) id 1noTqV-0002mD-Kj; Tue, 10 May 2022 17:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325946.548755; Tue, 10 May 2022 17:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTqV-0002m6-HT; Tue, 10 May 2022 17:40:27 +0000 Received: by outflank-mailman (input) for mailman id 325946; Tue, 10 May 2022 17:40:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTqT-0002m0-Q5 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 17:40:25 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4560267c-d088-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 19:40:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5AC4FB81EB9; Tue, 10 May 2022 17:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749E5C385C2; Tue, 10 May 2022 17:40:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4560267c-d088-11ec-8fc4-03012f2f19d4 Date: Tue, 10 May 2022 13:40:14 -0400 From: Steven Rostedt To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers Message-ID: <20220510134014.3923ccba@gandalf.local.home> In-Reply-To: <20220427224924.592546-24-gpiccoli@igalia.com> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-24-gpiccoli@igalia.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Apr 2022 19:49:17 -0300 "Guilherme G. Piccoli" wrote: > Currently we don't have a way to check if there are dumpers set, > except counting the list members maybe. This patch introduces a very > simple helper to provide this information, by just keeping track of > registered/unregistered kmsg dumpers. It's going to be used on the > panic path in the subsequent patch. FYI, it is considered "bad form" to reference in the change log "this patch". We know this is a patch. The change log should just talk about what is being done. So can you reword your change logs (you do this is almost every patch). Here's what I would reword the above to be: Currently we don't have a way to check if there are dumpers set, except perhaps by counting the list members. Introduce a very simple helper to provide this information, by just keeping track of registered/unregistered kmsg dumpers. This will simplify the refactoring of the panic path. -- Steve From xen-devel-bounces@lists.xenproject.org Tue May 10 17:46:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 17:46:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325956.548766 (Exim 4.92) (envelope-from ) id 1noTw0-0003gD-Ag; Tue, 10 May 2022 17:46:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325956.548766; Tue, 10 May 2022 17:46:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTw0-0003g6-6L; Tue, 10 May 2022 17:46:08 +0000 Received: by outflank-mailman (input) for mailman id 325956; Tue, 10 May 2022 17:46:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTvy-0003fw-Kh; Tue, 10 May 2022 17:46:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTvy-00037o-GV; Tue, 10 May 2022 17:46:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noTvy-0006aq-1b; Tue, 10 May 2022 17:46:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noTvy-0006h9-17; Tue, 10 May 2022 17:46:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YD6+ZYxtwv7iBqney1DIx5jTW5Vb/1MfTUFNXebiBWI=; b=PZyFBsj1nsP5ft41THf6nwAxQl kjGzT1F1sEjkRXToG08BBPTjiDTtypReDSghrYOM5eYUKWIBqAraqE1DjEQf9+/6FVWXnrwvL5rM6 pHFOGichDeSy0uZZd3kJuD35m54FwNF2ckXKhNnDEn0VS+9acWbsi4WZ0VxeJLXe/jY4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170304: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 17:46:06 +0000 flight 170304 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 918 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 18:14:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 18:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325965.548777 (Exim 4.92) (envelope-from ) id 1noUND-0007mI-O0; Tue, 10 May 2022 18:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325965.548777; Tue, 10 May 2022 18:14:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUND-0007mB-KV; Tue, 10 May 2022 18:14:15 +0000 Received: by outflank-mailman (input) for mailman id 325965; Tue, 10 May 2022 18:14:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUNC-0007m4-B8 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 18:14:14 +0000 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe42a14a-d08c-11ec-a406-831a346695d4; Tue, 10 May 2022 20:14:12 +0200 (CEST) Received: by mail-yb1-f174.google.com with SMTP id v59so32171681ybi.12 for ; Tue, 10 May 2022 11:14:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe42a14a-d08c-11ec-a406-831a346695d4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qpqXrLDWUEHd+BUtmgMjhwAa3QcGPruT6uNMBEv9rjU=; b=U3Um5tuc/JePLD08JZdzeJsPB022i8qjlz0FzJMOe0JoFvdG+NwPaqIbKKczkJSjni LGwPmx/lA/DQfsmVZnK0yPAJPtvNUHougiJotyNRrSlj0REk9AUiYAI4DcxcBxppsbOu 778UaN0sUn7/g/zONMhYmYDAJLiU4sua5dBiKhl3YrdyRhLAAFcvvzUuQMmLDy1QwhBA FMHp8Gw7WrYkka1wavXWlGZdXCiTh95LVocLdcEFoIRP27jtrqHWBGXA7XGtX+XI7u4x 5QYJ5L9oKHJx2aK0QXvWS6Brxv7ktbrr3NbhTNN71HAjoKGaGsp8lNMrJUpvkfAPHIT1 6nVg== X-Gm-Message-State: AOAM533vRtAstAXjUwhlzjHb5nOElZDTRqIVaMArmNBygiEX50uFFFQA RbJVFVAaZiMFaiU0TRMWeqp1ncrL/A7cevbk7AQ= X-Google-Smtp-Source: ABdhPJy/3C7Xf5XL6o3yFhMZ917Dv3JWEaRfPbmjw9NKhK3//cChodJMWe9FmxWaGm5UEgRYGP1Nqk2NauJUMOpu3kk= X-Received: by 2002:a25:e792:0:b0:645:7ddb:b5eb with SMTP id e140-20020a25e792000000b006457ddbb5ebmr19781278ybh.482.1652206451725; Tue, 10 May 2022 11:14:11 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-2-dmitry.osipenko@collabora.com> In-Reply-To: <20220509233235.995021-2-dmitry.osipenko@collabora.com> From: "Rafael J. Wysocki" Date: Tue, 10 May 2022 20:14:00 +0200 Message-ID: Subject: Re: [PATCH v8 01/27] notifier: Add atomic_notifier_call_chain_is_empty() To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko wrote: > > Add atomic_notifier_call_chain_is_empty() that returns true if given > atomic call chain is empty. It would be good to mention a use case for it. > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko > --- > include/linux/notifier.h | 2 ++ > kernel/notifier.c | 13 +++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/include/linux/notifier.h b/include/linux/notifier.h > index 87069b8459af..95e2440037de 100644 > --- a/include/linux/notifier.h > +++ b/include/linux/notifier.h > @@ -173,6 +173,8 @@ extern int blocking_notifier_call_chain_robust(struct= blocking_notifier_head *nh > extern int raw_notifier_call_chain_robust(struct raw_notifier_head *nh, > unsigned long val_up, unsigned long val_down, void *v); > > +extern bool atomic_notifier_call_chain_is_empty(struct atomic_notifier_h= ead *nh); > + > #define NOTIFY_DONE 0x0000 /* Don't care */ > #define NOTIFY_OK 0x0001 /* Suits me */ > #define NOTIFY_STOP_MASK 0x8000 /* Don't call further */ > diff --git a/kernel/notifier.c b/kernel/notifier.c > index ba005ebf4730..aaf5b56452a6 100644 > --- a/kernel/notifier.c > +++ b/kernel/notifier.c > @@ -204,6 +204,19 @@ int atomic_notifier_call_chain(struct atomic_notifie= r_head *nh, > EXPORT_SYMBOL_GPL(atomic_notifier_call_chain); > NOKPROBE_SYMBOL(atomic_notifier_call_chain); > > +/** > + * atomicnotifier_call_chain_is_empty - Check whether notifier chain= is empty > + * @nh: Pointer to head of the blocking notifier chain > + * > + * Checks whether notifier chain is empty. > + * > + * Returns true is notifier chain is empty, false otherwise. > + */ > +bool atomic_notifier_call_chain_is_empty(struct atomic_notifier_head *nh= ) > +{ > + return !rcu_access_pointer(nh->head); > +} > + > /* > * Blocking notifier chain routines. All access to the chain is > * synchronized by an rwsem. > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Tue May 10 18:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 18:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325975.548788 (Exim 4.92) (envelope-from ) id 1noUxW-0004QG-Kn; Tue, 10 May 2022 18:51:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325975.548788; Tue, 10 May 2022 18:51:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUxW-0004Q9-Hj; Tue, 10 May 2022 18:51:46 +0000 Received: by outflank-mailman (input) for mailman id 325975; Tue, 10 May 2022 18:51:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUxU-0004Pz-Sc; Tue, 10 May 2022 18:51:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUxU-0004LF-Q0; Tue, 10 May 2022 18:51:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noUxU-000853-BA; Tue, 10 May 2022 18:51:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noUxU-00050b-Ag; Tue, 10 May 2022 18:51:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sSpzyhLCbFH+z2etEqVGEUdvpU7TmJxBo0enyVeCLeA=; b=ZBBFFofokOToV8/FErTuSFFUZc eLpvL1vOrEt2p/uGybzOUrpGrM74D+JK4tNJ+HMwlgx6FmMSydgbk0Ii+y8b9dd14LurlYHNMH9sN pZlX8KPeO0DxexXdwDhRQ1LNOZYZUDJwV91E3fr+44hV/by0j8yBHinhtfn3VFMqErdg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170300: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 X-Osstest-Versions-That: xen=0badfb110fa33ca9ffd3bdc3a5200cded03e6106 From: osstest service owner Date: Tue, 10 May 2022 18:51:44 +0000 flight 170300 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170300/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 baseline version: xen 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 Last test of basis 170280 2022-05-09 23:01:42 Z 0 days Testing same since 170300 2022-05-10 15:03:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Julien Grall Luca Fancellu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0badfb110f..407b13a71e 407b13a71e324aba76b11e5f66f59ce4a304a088 -> smoke From xen-devel-bounces@lists.xenproject.org Tue May 10 18:56:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 18:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325983.548799 (Exim 4.92) (envelope-from ) id 1noV1v-000547-6u; Tue, 10 May 2022 18:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325983.548799; Tue, 10 May 2022 18:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noV1v-000540-3r; Tue, 10 May 2022 18:56:19 +0000 Received: by outflank-mailman (input) for mailman id 325983; Tue, 10 May 2022 18:56:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noV1t-00053q-Fn; Tue, 10 May 2022 18:56:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noV1t-0004Px-Ev; Tue, 10 May 2022 18:56:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noV1t-00089u-2w; Tue, 10 May 2022 18:56:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noV1t-0007f7-2V; Tue, 10 May 2022 18:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hyOvrUMoe8dZS6QEiSoRT0szFVpyKfi//5sBJGruuIU=; b=je2LdDSvbytJ28/f17aLwIDK8i D0vO9WWM6KcFbs0kgsZHaEPo4JKSuXzqfEcQ/b8qV8ZetEggrh0sotoq0qog6X29wU7931JNghto5 Cz1OIc5zLibjxlgQ503S9AVoY1SIzPJLycXX2s4yiXe7H82MSRXeEVYO5ivEuEI58pek=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170305: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 18:56:17 +0000 flight 170305 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170305/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 919 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 20:07:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 20:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325996.548810 (Exim 4.92) (envelope-from ) id 1noW8X-0005GR-A4; Tue, 10 May 2022 20:07:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325996.548810; Tue, 10 May 2022 20:07:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noW8X-0005GK-7H; Tue, 10 May 2022 20:07:13 +0000 Received: by outflank-mailman (input) for mailman id 325996; Tue, 10 May 2022 20:07:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noW8V-0005GA-MB; Tue, 10 May 2022 20:07:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noW8V-0005g0-Ke; Tue, 10 May 2022 20:07:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noW8V-0002xv-4i; Tue, 10 May 2022 20:07:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noW8V-0007aN-4F; Tue, 10 May 2022 20:07:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x82DRlM54ou1zzhjyb6vteqzjcuD6SVgMwEuL/iSNkk=; b=5je7NCahTotxpK9KPtiRcHxxD4 4orYd2Eubx+FsFodHhJyEdcyeqBl/MP8KjuxYr4q4wJq462C+5hy9PnIr07GDsWljU/xggHn0ffy8 uQFYM0cFqkHSfCZukFg3uhLhm8HQJIGbu2OVB9ceqXRzUhg/XOTNUOp9EMJJURjYhhM0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170308: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 20:07:11 +0000 flight 170308 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170308/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 920 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 20:13:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 20:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326005.548822 (Exim 4.92) (envelope-from ) id 1noWEW-0006x8-2X; Tue, 10 May 2022 20:13:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326005.548822; Tue, 10 May 2022 20:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noWEV-0006x1-TS; Tue, 10 May 2022 20:13:23 +0000 Received: by outflank-mailman (input) for mailman id 326005; Tue, 10 May 2022 20:13:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noWET-0006wv-Px for xen-devel@lists.xenproject.org; Tue, 10 May 2022 20:13:22 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a252f6db-d09d-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 22:13:20 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noWDn-0000dk-Tv; Tue, 10 May 2022 22:12:41 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a252f6db-d09d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gJbDvxZCHLE9Xc3dgTDCPLuG4mRgGmv6OD8aG7M3JDQ=; b=g3Nx+lB9bAjkoFhfBAw/tKnujE HE49wVGnvYPT6LdjDh7XC7p9pg3dQOiKQmVqs5yBTQcMLD/Qb7loz7GoYe9PtUSJMIbL1xCX7WOmP Vje/KjqWSNfESrwYFEgzZTAiGGwdZ+mo/M5Y4DNbzDEU8fdx1WAqo3dhuepVJxkwfJ6AyMl1hzYbL 37Bt4s+cXuNOUF+dflK9we5prMFoOFLTCAg4y4fzR8H75s0j2xAYXr1Tlb+YwkS4w97u5Z+/kankc sGAGYvqPkX6LoRGzU4WQr1NirsakQGzt8bG3WfLCBDveLwXiZiOyOvqFNe/oiLGpRxJijV5VJBRHK Ucite2AA==; Message-ID: <24a56892-adb3-809c-8c35-b5b5f001c283@igalia.com> Date: Tue, 10 May 2022 17:11:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 01/30] x86/crash,reboot: Avoid re-disabling VMX in all CPUs on crash/restart Content-Language: en-US To: Sean Christopherson Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, "David P . Reed" , Paolo Bonzini References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-2-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/05/2022 12:52, Sean Christopherson wrote: > I find the shortlog to be very confusing, the bug has nothing to do with disabling > VMX and I distinctly remember wrapping VMXOFF with exception fixup to prevent doom > if VMX is already disabled :-). The issue is really that nmi_shootdown_cpus() doesn't > play nice with being called twice. > Hey Sean, OK - I agree with you, the issue is really about the double list addition. > [...] > > Call stacks for the two callers would be very, very helpful. > [...] > This feels like were just adding more duct tape to the mess. nmi_shootdown() is > still unsafe for more than one caller, and it takes a _lot_ of staring and searching > to understand that crash_smp_send_stop() is invoked iff CONFIG_KEXEC_CORE=y, i.e. > that it will call smp_ops.crash_stop_other_cpus() and not just smp_send_stop(). > > Rather than shared a flag between two relatively unrelated functions, what if we > instead disabling virtualization in crash_nmi_callback() and then turn the reboot > call into a nop if an NMI shootdown has already occurred? That will also add a > bit of documentation about multiple shootdowns not working. > > And I believe there's also a lurking bug in native_machine_emergency_restart() that > can be fixed with cleanup. SVM can also block INIT and so should be disabled during > an emergency reboot. > > The attached patches are compile tested only. If they seem sane, I'll post an > official mini series. Thanks Sean, it makes sense - my patch is more a "band-aid" whereas yours fixes it in a more generic way. Confess I found the logic of your patch complex, but as you said, it requires a *lot* of code analysis to understand these multiple shutdown patches, the problem is complicated by nature heh I've tested your patch 0001 and it works well for all cases [0], so go ahead and submit the miniseries, feel free to add: Reported-and-tested-by: Guilherme G. Piccoli I've read patch 0002 and it makes sense to me as well, a good proactive bug fix =) With that said, I'll of course drop this one from V2 of this series. Cheers, Guilherme [0] A summary of my tests and the code paths that the panic shutdown take depending on some conditions: New function that disables VMX/SVM: cpu_crash_disable_virtualization() [should be executed in every online CPU on shutdown) The panic path triggers the following call stacks depending on kdump and post_notifiers: (1) kexec/kdump + !crash_kexec_post_notifiers ->machine_crash_shutdown() ----.crash_shutdown() ------native_machine_crash_shutdown() [all custom handlers except Xen PV call the native generic function] --------crash_smp_send_stop() ----------kdump_nmi_shootdown_cpus() ------------nmi_shootdown_cpus(kdump_nmi_callback) --------------crash_nmi_callback() ----------------kdump_nmi_callback() ------------------cpu_crash_disable_virtualization() (2) kexec/kdump + crash_kexec_post_notifiers ->crash_smp_send_stop() ----kdump_nmi_shootdown_cpus() ------nmi_shootdown_cpus(kdump_nmi_callback) --------crash_nmi_callback() ----------kdump_nmi_callback() ------------cpu_crash_disable_virtualization() After this path, will execute machine_crash_shutdown() but crash_smp_send_stop() is guarded against double execution. Also, emergency restart calls emergency_vmx_disable_all() . (3) !kexec/kdump + crash_kexec_post_notifiers Same as (2) (4) !kexec/kdump + !crash_kexec_post_notifiers -> smp_send_stop() ----native_stop_other_cpus() ------apic_send_IPI_allbutself(REBOOT_VECTOR) --------sysvec_reboot ----------cpu_emergency_vmxoff() If not: ------register_stop_handler() --------apic_send_IPI_allbutself(NMI_VECTOR) ----------smp_stop_nmi_callback() ------------cpu_emergency_vmxoff() After that, emergency_vmx_disable_all() gets called in the emergency restart path as well. From xen-devel-bounces@lists.xenproject.org Tue May 10 21:07:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 21:07:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326016.548832 (Exim 4.92) (envelope-from ) id 1noX4n-0004tL-8Z; Tue, 10 May 2022 21:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326016.548832; Tue, 10 May 2022 21:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noX4n-0004tE-5W; Tue, 10 May 2022 21:07:25 +0000 Received: by outflank-mailman (input) for mailman id 326016; Tue, 10 May 2022 21:07:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noX4l-0004t4-RX; Tue, 10 May 2022 21:07:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noX4l-0006jT-P2; Tue, 10 May 2022 21:07:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noX4l-0006hG-E7; Tue, 10 May 2022 21:07:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noX4l-00086F-De; Tue, 10 May 2022 21:07:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=syf8fZdE/v86Qx2oERGgBP5pKTuEUE/hxtnN5Zd8iRg=; b=gM/nMExy09VOhXInO7HJIY7Plf OV58K6MrmbHEcGsund0HXAAvcOKiJRC9i2CXDXof2mgdB8i5cfkIqbkCP3KXJ3a0bWgPEk1zedyU/ arX6t9V9sVxqGY6d21WrzKJcbpW7W4yL4Ci0LX01J6p2FRCw+S2HecCg83uwXyUZfGuk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170309: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 21:07:23 +0000 flight 170309 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170309/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 921 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 10 22:11:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 10 May 2022 22:11:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326025.548843 (Exim 4.92) (envelope-from ) id 1noY4G-0004fz-2U; Tue, 10 May 2022 22:10:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326025.548843; Tue, 10 May 2022 22:10:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noY4F-0004fs-Vs; Tue, 10 May 2022 22:10:55 +0000 Received: by outflank-mailman (input) for mailman id 326025; Tue, 10 May 2022 22:10:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noY4F-0004fi-7e; Tue, 10 May 2022 22:10:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noY4F-0007sP-5j; Tue, 10 May 2022 22:10:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noY4E-0001y8-OU; Tue, 10 May 2022 22:10:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noY4E-000128-Nz; Tue, 10 May 2022 22:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FUbD5+pnf4v9ztgttntA1+k9BLjpK4+Hg1UVvNYR6bk=; b=P5pCLx6RkoSOfYu4SzqLPyjMH9 rcCAkNyz73bGNMB+Q9vzOLhbLqtdVcEQ/G2rPPc55tBn8m8TMkGsmia8I6vCgU48cxfaYb5AIHxfL EauXxud7I2UTWPTWIZCDXeU9eWkY7vu9wzHnG50LUCDzOCsDKwiEoGQfUoUWiSYHezTU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170310: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 10 May 2022 22:10:54 +0000 flight 170310 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170310/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 922 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 01:23:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:23:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326046.548854 (Exim 4.92) (envelope-from ) id 1nob4O-0000jf-3Z; Wed, 11 May 2022 01:23:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326046.548854; Wed, 11 May 2022 01:23:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nob4O-0000jY-0T; Wed, 11 May 2022 01:23:16 +0000 Received: by outflank-mailman (input) for mailman id 326046; Wed, 11 May 2022 01:23:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nob4M-0000jO-87; Wed, 11 May 2022 01:23:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nob4L-00018m-Vi; Wed, 11 May 2022 01:23:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nob4L-0003Md-C4; Wed, 11 May 2022 01:23:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nob4L-0004Su-BY; Wed, 11 May 2022 01:23:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B+TYUIsCvFvw/KXvNsuh37feMzW2StkaWYD4bCF+nqg=; b=lggtJBq8xRM1hZw3z9YAXtKaQp o2gfU767x3p49cr8uWzYpdbM1N0Kg8Acb25WeNNssQhqrQlKOkXzqmWc054GqtRTH9tlByQCoYDZ6 l4E3eGY/jjAynI3FXstJHLsA4BQ9F6XNlVRuwCSmvHTbhYNHgQ8CZXeWKz/oly/eYB5M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170306: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=feb9c5e19e913b53cb536a7aa7c9f20107bb51ec X-Osstest-Versions-That: linux=9be9ed2612b5aedb52a2c240edb1630b6b743cb6 From: osstest service owner Date: Wed, 11 May 2022 01:23:13 +0000 flight 170306 linux-linus real [real] flight 170312 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170306/ http://logs.test-lab.xenproject.org/osstest/logs/170312/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10 fail pass in 170312-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170273 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170273 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170273 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170273 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170273 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170273 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170273 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170273 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux feb9c5e19e913b53cb536a7aa7c9f20107bb51ec baseline version: linux 9be9ed2612b5aedb52a2c240edb1630b6b743cb6 Last test of basis 170273 2022-05-09 16:11:07 Z 1 days Testing same since 170306 2022-05-10 18:39:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Michael S. Tsirkin Shunsuke Mie jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 9be9ed2612b5..feb9c5e19e91 feb9c5e19e913b53cb536a7aa7c9f20107bb51ec -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed May 11 01:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326055.548864 (Exim 4.92) (envelope-from ) id 1nobO8-0003fC-OB; Wed, 11 May 2022 01:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326055.548864; Wed, 11 May 2022 01:43:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobO8-0003f5-K9; Wed, 11 May 2022 01:43:40 +0000 Received: by outflank-mailman (input) for mailman id 326055; Wed, 11 May 2022 01:43:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobO7-0003ev-2n; Wed, 11 May 2022 01:43:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobO7-0001Uw-0x; Wed, 11 May 2022 01:43:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobO6-0003wW-D2; Wed, 11 May 2022 01:43:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nobO6-000245-CM; Wed, 11 May 2022 01:43:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NO05CXSwmiqNYW5bLcBuknDXcelvGVCuXPBvRLGqKac=; b=cQna+zbDBLlPGun0+xkpNs4O8W 8IlPVKts9OpAqECAZ7hr3F11FftdLuNYnLzH95dm4wsKQqaAxMnI4NwG9IzPmBqcmXMYXLozvLSkf SLQRGb0iKLzftKYbdNsrCRXj3Lp8uYFhGRE9VhPt1LGnnvMuwHcp9QuaDhvSbwoiszNE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170311: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=0e31124877cc8bc0140a03ad3196f0d58b2fd966 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 01:43:38 +0000 flight 170311 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170311/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 0e31124877cc8bc0140a03ad3196f0d58b2fd966 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 70 days 923 attempts Testing same since 170272 2022-05-09 15:12:57 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6200 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326064.548882 (Exim 4.92) (envelope-from ) id 1nobRX-0004KF-MM; Wed, 11 May 2022 01:47:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326064.548882; Wed, 11 May 2022 01:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRX-0004JW-Et; Wed, 11 May 2022 01:47:11 +0000 Received: by outflank-mailman (input) for mailman id 326064; Wed, 11 May 2022 01:47:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRW-0004GU-KJ for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7d00::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44e79563-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:09 +0200 (CEST) Received: from DU2PR04CA0307.eurprd04.prod.outlook.com (2603:10a6:10:2b5::12) by DB7PR08MB3084.eurprd08.prod.outlook.com (2603:10a6:5:22::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 11 May 2022 01:47:04 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::a7) by DU2PR04CA0307.outlook.office365.com (2603:10a6:10:2b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 01:47:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:04 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Wed, 11 May 2022 01:47:04 +0000 Received: from 528f68de6e65.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9156CC9-2275-4435-84E1-B2C370CF5CDB.1; Wed, 11 May 2022 01:46:57 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 528f68de6e65.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:46:57 +0000 Received: from DU2PR04CA0185.eurprd04.prod.outlook.com (2603:10a6:10:28d::10) by DB6PR08MB2903.eurprd08.prod.outlook.com (2603:10a6:6:25::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 11 May 2022 01:46:48 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::88) by DU2PR04CA0185.outlook.office365.com (2603:10a6:10:28d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 01:46:48 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:46:48 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:46:52 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:46:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44e79563-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=E5/0jwIPQJSMeP1200t0R6hTzyrkTgyQjVDXwrS/GaOBN+shXnRaaF1d9om/NFZJx7TrCOOm/+JMczjYRqLAJEp5YRXYLjPYzctcC2+zTZqYmnchJSQKGeQWSAgr9srcBtjOXJVzUbl450lnyWHqZr6jZbLLmL4XAMLcAQqof9hKv+LNNld9kitcKMI3I3032o6JNVwnil/7s5+ZhF8xyKb3UY9ljJp1R2FIrYxr9Ox0fPPaPiWQC9Tc+BkVjiWA8zBpFQUBYpFtWZrJZrneBM3eP7oxSfeEfErjR6y5M9tJqGVgn5SIhz29LnNrx+U0Cmzc7v0do6nIG6zF2HeflA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31igy7T15kES4vLMfed76VenVkekjtONt3j8NseN5AI=; b=lVjK6uQh+8P74Xz0wDztQr/qU8EoA0vP2zHw3MKN/zzZQfw4GsCdZc5ZXPNJGTw716IovTY9vDt8kdgqtqWrNq54GrCqfBqLcfAs7VFniAMyodkoZ+aJ25m88yjlO4eLdHLGN/nTGrCfE5M5RXXiaUe+KuQo9WK0ymhlbvjFLlqmjXBSRCdgaHAsKDKcTiqvlpWNupYwCO7J3qS6OUJMX1Ie6ZjdJs7T/F9lELKigOPEn8sI6D/IXvVtGV9DGk6xpJPFeNnh+rTWVi1fhuTMEognutegS3KsWx3YzGSozOPzPt0WbewLplSlNx4crR8iOmmBd3TpT5TglwDMB5tkag== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31igy7T15kES4vLMfed76VenVkekjtONt3j8NseN5AI=; b=YMOw8TBsfV72kJJh7RsbRGOiliRR2l75q/4S50BYbBH16r/NKm0d9OOULQd0szWbx9ip2XTJC5edyGuABMoi9R3dMpA0/DxuijePZP3jnwet/VGaCw4hFFKp8Js7+1XuASTi5RFujsy3XKFUUPKWeddKU3hn47RmRVjHVektrJ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: cdda4f0fc244f13b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrGfFu37Wuy3aEXZTQan2PxWxO+U91OKCzkcqfjXm308VWqSCXKdFTEZsB4axnQBa10LAc1gAMKIRy+fwGhxzxhVxHJuGdJ6foeZ7Z/90FTz4Zd2koEnAGRZre9oNt7/IESI00cERiP4+qeu2nqdsxBZVEWXyBj4MG7Y2gJ3LGZxq0pfzC0BeadqDRGY2uhRH5AO/pmhtYCCxjIDtHsJxgQPFf2nIlJBkNeUDGUgmiI8z9SmCMx8ix1gQJkT6Jinu1j75FaUBuAz4c5q+a+Hpa2dWHMFEQcNB4gclwYBztbYmBaBG/u0tY4ifg0FQHDFJsS7OZjkdw241Y3GsfkgKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31igy7T15kES4vLMfed76VenVkekjtONt3j8NseN5AI=; b=GcU+O5pMlhRYntSHMV9pvokUBL+Z0Ub9ppwxjGDrUwUtYXX91mdnKEK/RBBYrpZEXroNCl5jF3H9w2NuQ42JFJ9lYOnlURmX4Fej6adle/iCvw2V2H43Zdepn0epv8BIdYK3RBmCb87ex6g61/4oK5watwsXsTxopvy4q7rimunJuv7i8bp9SvmmBfd/LuXxDZfjcChVv9GXscWOduJbrAClRqujG/XyxA87Po0FVy4utjubVfXX645Xf+6/4n7C72DT+QYiHeNvaEdo420I0na7yyCtRb34qUX3TkszWn+xdNrS8d6OK+j8EPz/MmRIb8EI+EE9BhLul//KGW19kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31igy7T15kES4vLMfed76VenVkekjtONt3j8NseN5AI=; b=YMOw8TBsfV72kJJh7RsbRGOiliRR2l75q/4S50BYbBH16r/NKm0d9OOULQd0szWbx9ip2XTJC5edyGuABMoi9R3dMpA0/DxuijePZP3jnwet/VGaCw4hFFKp8Js7+1XuASTi5RFujsy3XKFUUPKWeddKU3hn47RmRVjHVektrJ4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap Subject: [PATCH v3 0/9] Device tree based NUMA support for Arm - Part#1 Date: Wed, 11 May 2022 09:46:30 +0800 Message-ID: <20220511014639.197825-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 9b59c7ec-64d8-4d20-11a5-08da32f0267e X-MS-TrafficTypeDiagnostic: DB6PR08MB2903:EE_|DBAEUR03FT025:EE_|DB7PR08MB3084:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DoSJPfiBllTaadMl2leN4hyv4LxB8m41Ia5tV5JqKvbZsNqxb2NZ3ks8qNGkO9RuCLO/7Ve/kHLL61OVv6bwqhEofYRK70PGjSbix1akrNZqZ4Ey9N3W2E6XGSF6bX/Kziis3qGWJ0/XpjbfbqMTyJtbxrNIkupShqe+Ya9kTR7lYWyWrRfzp78dpMbGNqzDbaLaEB5sHEzbdUrigwevMlanUb+gJsPD3Ul17l7PK232CfnYcGutS1Zrn52milRXVp20WX4WJkzXuc1yozhqrnTSsstGK4TfyAwyrG/zaqcyEJ7FL33YoaphYyDBd8JsUyUG6LHG4hBgbCwUEnCrPBjIOT+vd0QhJpEgxNysLwUQW/UU60gmk8Mv+6/IE/bE6qHwXvLxIBS1E3GmS871GqBsOhFhqQVN7g1j61uw0AmHxa9J8oFXVnTYGec7hj41cC6ScYxIQ2vzKIOlCUneziF11EwVdkdM3Kc3Gt6x92Os3rNBCdBaUylP0/gLTxHuD6iPXMXuaxK10olpP6p3NY0DHlFJmNwUkZ11hfZ9KgWzeI0+pUjhZwdnLVMB3SHNe8rZVVoBdvdSuSxlIPgIs8greJiO9PSgKuh7xe9OJ7E7NQpn2uevzvnYmRuyQhCMepG/XgVBqFvoPSxiOruBwmhUKPoZVXknX31ZaaFgAWjGK66prx9Mn5gTTbRepkFZRiAGD7AeuoKqXTYD3mKdLgucugURIg6pFU4HCAIgeJKjQCdL3iP5jMcAvK6iKhLATXx7XlU4O9ccaZ5Tou7fLg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(2616005)(1076003)(82310400005)(26005)(83380400001)(426003)(336012)(36860700001)(2906002)(47076005)(186003)(508600001)(44832011)(36756003)(5660300002)(70206006)(40460700003)(8676002)(70586007)(4326008)(86362001)(54906003)(8936002)(6666004)(81166007)(7696005)(6916009)(356005)(316002)(21314003)(17413003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2903 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0c49895a-a05f-4611-2edf-08da32f01ce0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QSnciYeDpxB79WEUaPafyMcat1xRLwEO5H1mgxwLxj2iWuDtxzPn04a3sPDR+SbpAHLpfJQK/3tKV2xbEIMcCbLpxdrJky6OblL5Oq4q1H3JyyBJ4UZ5Jj/FximqlS76lZzZ0UsUrihujgjnNbXeUiFQKTDMHxKzOMeCyfSRAdTpYWrSHkQVuBA5kh8y54/zqReontDEujpYRByb+A8/7wCCcLREECm+NmtY9JTQEnPYQjiFrH7NYwO1WQj7HLr4tU6/Tvnp9yCrp4sG4BJnRIW+vy+SKiIDjtYq17ZF7Q/WNYtf52WIWCtb22qWH66156m2EBfSa2suQXq1xhy0nnT44oOvVUxUOHIrAG6Du3m5oFvVOPqMXyyvxfqnwAVh68SYJ4qVg8iduBP6kuoCSqhAnwM25/86dJxzJFWDfsEg+dlr326sR+LC2u1Ae/qI3njsGWTxa5Vxz2navqFKZMGotVl/m5joDYz8cUiDvdKcuC6Hg9gFmuWjp6lt/ipAt9c9FjD78nOl15Yb7p5Mh7PhEK8c6HEvl4CUGDOcab0mWHt6APfr9wN52HCppKSrXU0FCt/P/RbdSAsd7ofYBDV8Z7XmqbWv7gXz6PU+pKRUxPXHmzZPe5784FaIIrh2EnRCS7O4uSyHP91/LojzXAdIGNbqdqWtHDN5f16xsbX17L33QT8MDhpy1wttsU1zyvB5WqNcO8KGV+qJyC3CX6LZy2RiWGmPX2JwocvqcSw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(8936002)(2906002)(36860700001)(508600001)(54906003)(6916009)(40460700003)(47076005)(83380400001)(316002)(336012)(426003)(36756003)(82310400005)(44832011)(8676002)(86362001)(70206006)(70586007)(107886003)(7696005)(1076003)(4326008)(2616005)(6666004)(81166007)(5660300002)(26005)(17413003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:04.5682 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b59c7ec-64d8-4d20-11a5-08da32f0267e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3084 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series. 2. Move generically usable code from x86 to common. 3. Add new code to support Arm. This series only contains the first part patches.) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. --- Part1 v2->v3: 1. Rework EFI stub patch: 1.1. Add existed file check, if exists a regular stub files, the common/stub files' links will be ignored. 1.2. Keep stub.c in x86/efi to include common/efi/stub.c 1.3. Restore efi_compat_xxx stub functions to x86/efi.c. Other architectures will not use efi_compat_xxx. 1.4. Remove ARM_EFI dependency from ARM_64. 1.5. Add comment for adding stub.o to EFIOBJ-y. 1.6. Merge patch#2 and patch#3 to one patch. 2. Rename arch_have_default_dmazone to arch_want_default_dmazone 3. Use uint64_t for size in acpi_scan_nodes, make it be consistent with numa_emulation. 4. Merge the interleaves checking code from a separate function to conflicting_memblks. 5. Use INFO level for node's without memory log message. 6. Move "xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid" to part#2. Part1 v1->v2: 1. Move independent patches from later to early of this series. 2. Drop the copy of EFI stub.c from Arm. Share common codes of x86 EFI stub for Arm. 3. Use CONFIG_ARM_EFI to replace CONFIG_EFI and remove help text and make CONFIG_ARM_EFI invisible. 4. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 6. Extend the description of Arm's workaround for reserve DMA allocations to avoid the same discussion every time for arch_have_default_dmazone. 7. Update commit messages. Wei Chen (9): xen/arm: Print a 64-bit number in hex from early uart xen: reuse x86 EFI stub functions for Arm xen/arm: Keep memory nodes in device tree when Xen boots from EFI xen: introduce an arch helper for default dma zone status xen: decouple NUMA from ACPI in Kconfig xen/arm: use !CONFIG_NUMA to keep fake NUMA API xen/x86: use paddr_t for addresses in NUMA node structure xen/x86: add detection of memory interleaves for different nodes xen/x86: use INFO level for node's without memory log message xen/arch/arm/Kconfig | 4 + xen/arch/arm/Makefile | 2 +- xen/arch/arm/arm64/head.S | 12 +-- xen/arch/arm/bootfdt.c | 8 +- xen/arch/arm/efi/Makefile | 8 ++ xen/arch/arm/efi/efi-boot.h | 25 ------ xen/arch/arm/include/asm/numa.h | 6 ++ xen/arch/x86/Kconfig | 2 +- xen/arch/x86/efi/stub.c | 32 +------ xen/arch/x86/include/asm/config.h | 1 - xen/arch/x86/include/asm/numa.h | 9 +- xen/arch/x86/numa.c | 32 ++++--- xen/arch/x86/srat.c | 137 +++++++++++++++++++++--------- xen/common/Kconfig | 3 + xen/common/efi/efi-common.mk | 3 +- xen/common/efi/stub.c | 32 +++++++ xen/common/page_alloc.c | 2 +- xen/drivers/acpi/Kconfig | 3 +- xen/drivers/acpi/Makefile | 2 +- 19 files changed, 193 insertions(+), 130 deletions(-) create mode 100644 xen/common/efi/stub.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326063.548876 (Exim 4.92) (envelope-from ) id 1nobRX-0004Gh-94; Wed, 11 May 2022 01:47:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326063.548876; Wed, 11 May 2022 01:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRX-0004Ga-5h; Wed, 11 May 2022 01:47:11 +0000 Received: by outflank-mailman (input) for mailman id 326063; Wed, 11 May 2022 01:47:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRV-0004GM-Gz for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7d00::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43c8d114-d0cc-11ec-a406-831a346695d4; Wed, 11 May 2022 03:47:07 +0200 (CEST) Received: from DB8PR06CA0061.eurprd06.prod.outlook.com (2603:10a6:10:120::35) by AM7PR08MB5462.eurprd08.prod.outlook.com (2603:10a6:20b:10b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 01:47:05 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::7) by DB8PR06CA0061.outlook.office365.com (2603:10a6:10:120::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21 via Frontend Transport; Wed, 11 May 2022 01:47:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:05 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Wed, 11 May 2022 01:47:05 +0000 Received: from f914d3d6dba5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FBA35812-C497-46EF-9CD1-C0212CE52194.1; Wed, 11 May 2022 01:46:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f914d3d6dba5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:46:58 +0000 Received: from DU2PR04CA0307.eurprd04.prod.outlook.com (2603:10a6:10:2b5::12) by PAXPR08MB6399.eurprd08.prod.outlook.com (2603:10a6:102:158::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 01:46:56 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::a7) by DU2PR04CA0307.outlook.office365.com (2603:10a6:10:2b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 01:46:51 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:46:51 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:46:55 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:46:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43c8d114-d0cc-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SfbBdKz3IRE6rjW6JFl1U//COcGT8GAfrGu38vtSt+uJl+r/Iwpm533jAeFzEYtKzrY4FmBYGI4Rz8mduGNoIpQ11mgRuHW6HoCbfFbq1Wm8zl8o8iqWR0k7X1mRHXggh9DR4GkSG+5NYhRMNt8HXciUsjpU75tDVDZSmTb12vgiHbRj1T6B+tRMZAClL8CAOiOi9pSo919ucWfTsukPy+86RrjVz10KEQ5ul3eGDE2Cl5R9/oQcI1OKpoXfwymK4w+6kYgpVn1TIvN3evX2DTPenU5+FsfdKGKZd2YgJJGZFZXW6o5RXU1A/8xjTjUKz+95xOslrVupa9/Ac1G/VQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCcl6ig9FV6KaPQMsfAvOQCZeEGBSyiayQZl78b6UYE=; b=d6hFaQ4ZyvbpHkW8nLJmgAvA8cT20HMU+I9DKe7TB0VwzkbyBjHxi07Cv2NSvi2VMpbC2dxuU/Vdrfgm9O8dkM0EnZlJ58knFLuJLl4Vo3PcKTW9ya3xtAhUVI93AH4Uk+hXtxv9HgwRFePF/K0M5QnixSaO1+VUz87iZ5BQTWPerFEpghygUBJeTHGvoTOAi7HiHZj8mtsH4NICjAVNCjFA9W2upwPHzfjrAfQN4z9FWXjLJ6nZYFS4/JeGCi674zigpaYYn33RQgkWenUk+zWe0hwe9pjlnWKKekNJZFLIrjngq0TYvJYAGLSe7tM4Wt7ut447ZEE7Ozvw9ZaJxA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCcl6ig9FV6KaPQMsfAvOQCZeEGBSyiayQZl78b6UYE=; b=SdXmnlBWvFvcmzhXwrLR1AXrud8vtJzyrsoFipvP0CxdlGlL2zRIvKPayXXxEDbJ7td6mFlvDPN9jLGBTem0ZzmAwk5YC5xnu5LvVLoAB4o6Jj01UDSpiwRUlV9idSXPs3nCh6B3H5FB3mSOmyXDTOIuLk4n0pwvR1qR+c1PMq8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1cb33a7f1a580bf6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XY5Ifc8Vn9csJGTepkqMQ+jltFn/NfXb0GOFP07WlOxu7+3xbM/GOX3pSCt2oxoLaMg/zoGD6m5nXhoqHd229x/+yBdXNOFTFNLILq80SArE7DjIU2N3asXgw6eU5YPj62HxhKEg5LLWeREkZ7UVuvavEoiF5JoUKhhRHo+6bBEgpZDjVbj375zBjgEGb/Z9Kkmprv8HojnlEBS5HKcOrhisfBlin1KRkXIDj0Xy3EFL6dPZga+vsc4bOFK9Uaj2eVFy1NnuHQQ0diqC218qvFrgX/qizHYAb6ruYnXVGSSixPAwX0o8uWvF92tGRodK7TQ+pYjVAQjmoWVwHL2Vmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCcl6ig9FV6KaPQMsfAvOQCZeEGBSyiayQZl78b6UYE=; b=fBhgomOcv0Xk263qzxrVq3U12U2uYBbyG/sEz66te3dTSySHH+I6gNTBE9f81p37PFFQ7stvNalthPb05bR1KoYOwbGa2ANMxjT7g9C/zyFNOp3y+YahbVB80GV8WCvX7j2lEAaDovXpsMavpPg0YoqTPrHffSmiVS4Uzt8/MaDNxpcCBcYA/OkTSXz6DCDmZcWz+bF1CzFSQSJoCTmkTKM9Ne9H5CqSnOZSG6ZNrlfwSVt7aY5I5Z1xiGmFmbXTVFaLN6FHSvI2adkxG4f9EH3G1w3rfwFRmgDtmBQLpVZ7R/mkHoG6FHXTvEKPozGj0qZugca9F2FhkB4r+wi56g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCcl6ig9FV6KaPQMsfAvOQCZeEGBSyiayQZl78b6UYE=; b=SdXmnlBWvFvcmzhXwrLR1AXrud8vtJzyrsoFipvP0CxdlGlL2zRIvKPayXXxEDbJ7td6mFlvDPN9jLGBTem0ZzmAwk5YC5xnu5LvVLoAB4o6Jj01UDSpiwRUlV9idSXPs3nCh6B3H5FB3mSOmyXDTOIuLk4n0pwvR1qR+c1PMq8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie , Julien Grall Subject: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart Date: Wed, 11 May 2022 09:46:31 +0800 Message-ID: <20220511014639.197825-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 6d4a99ff-c725-4725-e7f8-08da32f026ec X-MS-TrafficTypeDiagnostic: PAXPR08MB6399:EE_|DBAEUR03FT049:EE_|AM7PR08MB5462:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4Bsc7mjP40KBDCmzc0xKLQZWc53qgO4jV8MqclWCChi5pXLy41Fb4nsV8IACzzfImdTsriluxsWzdZ0HNOALSzmyNV3FAVIv8qWsRpOnICdkQ/SbvrajFp7pkNjEwo1mMR2q85VQKALPMNVGc/pHP17WdavZ7u31tKrR4oMw923265nkX8RDQBmxuRFpFzRWoyZ3m9oFzXE34p00cwYrUqW7u1UctXtltuacOWVsmYXrQHUhUiKMk7uxU3c7eFwu9XFhKvrd/Iw+yR8Ldy9lGRS5gS0b2OgXv+g9MyfpCr4BFWMyXXaIxBWSkdhqEDapk0clKwnzSP8HBCPLFCkBQOlfiqftbDaKyqzLZ7ng0g4mj81DyxAi1Uevs+s2cxDaJImKANCrjFU8uKVKAu0YTWifpOlhMPKBTqlDJ4X9LneCsNNJYzxQZg+f7BbvEoM+0eh2I1SGh9FnVGmRjnzTXJjTkLBCYQCUaFlRvveSqmolL3I2SMCzbyDyg54C4UwsKugTgWKHTmqhjEEIPZqHWqAMl1cFjoKPBp96r4r8hdJytnDfEnQB5GjxY5Ky5WQPHN96O4OeaXE4IvNcNHRcxDSptZh/xFSmpd3a9mqC9TYGKTXbS7vGGcwXqf9nVbvDKgNSYXDRVkLR2DiNlNB9bUUXt+52iIljyQJAd4+vSx/UCtEw8Stl1JPsWumPqHojW+Q5T2qMalypzt8KmuaCqw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(186003)(70206006)(47076005)(36756003)(336012)(426003)(83380400001)(36860700001)(82310400005)(8936002)(44832011)(2616005)(40460700003)(5660300002)(26005)(8676002)(4326008)(1076003)(54906003)(6916009)(508600001)(86362001)(7696005)(2906002)(81166007)(6666004)(316002)(356005)(70586007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6399 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f6fd9924-9da6-4cb2-4272-08da32f01e72 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2jPVX77OOQ4D2cb8eh0ju+YxDi2nfrfCUbvWi/rjMtU+EqainR8vCE7h5f88Glt8Mn93Puj8DwoVrb7fVzXHCqeuChUloot83pK2sU9xXF5tw7D8cHStu1Dyt0lb5YaapM3cehe66PlwFQkSEbBvjajrKZPoA3M7J3gTrH12L+LBTpxpG+EAF+yqAzIb6BbAtuYCrMr/zc7x0Byc01jVOXc+fzHXHNLhoJIu/E5xAIvzBFJayfiaMtMxcK9ZhfkEYT2nXVOeFAVgW0S6NxtUYYQ0rIbYqqKG6hnPJk658u8iO+AXoPqvVDf3101B5V+6LSQsV7D6avmS9n5y0LqUymmXtyy/0T2mxlls80MkbcZ2rfV+aBYW5e9ahCQPk7DOE90H2jej2Lh3xf3movUh+74/8SlFQ7GG2YRx45Kw+7tOG5cSg+cbukEFhYrFvTv5E5oRoIjxbk+hC/BT2kXQFOWQoda68LrfG811qEM6Tx1avw63+ZbnRl77JjvyETC51mcb6t2VagLqmsC+u0+YLALi4RWttoMxId/LFPHsLurt+hm/lR9s9RQkOeKf1Es3ra5nvl732RVQ+H8kA6/Z2EmE3OT98AiR2eNsbftSO7XKqGl3SIDv3O7/u6OWIsFMjjkYx6bAdDrE/USd/SZ7vC3ZI1/8OBtsVNBYV4HJwj8qUsDQDl+TprIY1pTLNlYZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(47076005)(426003)(336012)(186003)(8676002)(70586007)(2616005)(107886003)(70206006)(1076003)(4326008)(83380400001)(26005)(8936002)(81166007)(86362001)(6666004)(82310400005)(54906003)(316002)(6916009)(7696005)(40460700003)(36860700001)(36756003)(2906002)(44832011)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:05.2946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d4a99ff-c725-4725-e7f8-08da32f026ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5462 Current putn function that is using for early print only can print low 32-bit of AArch64 register. This will lose some important messages while debugging with early console. For example: (XEN) Bringing up CPU5 - CPU 0000000100000100 booting - Will be truncated to (XEN) Bringing up CPU5 - CPU 00000100 booting - In this patch, we increased the print loops and shift bits to make putn print 64-bit number. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Julien Grall --- v2->v3: Add Tb from Jiamei. --- xen/arch/arm/arm64/head.S | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 1fd35a8390..109ae7de0c 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -872,17 +872,19 @@ puts: ret ENDPROC(puts) -/* Print a 32-bit number in hex. Specific to the PL011 UART. +/* + * Print a 64-bit number in hex. * x0: Number to print. * x23: Early UART base address - * Clobbers x0-x3 */ + * Clobbers x0-x3 + */ putn: adr x1, hex - mov x3, #8 + mov x3, #16 1: early_uart_ready x23, 2 - and x2, x0, #0xf0000000 /* Mask off the top nybble */ - lsr x2, x2, #28 + and x2, x0, #(0xf<<60) /* Mask off the top nybble */ + lsr x2, x2, #60 ldrb w2, [x1, x2] /* Convert to a char */ early_uart_transmit x23, w2 lsl x0, x0, #4 /* Roll it through one nybble at a time */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326065.548898 (Exim 4.92) (envelope-from ) id 1nobRZ-0004ma-60; Wed, 11 May 2022 01:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326065.548898; Wed, 11 May 2022 01:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRZ-0004lX-0r; Wed, 11 May 2022 01:47:13 +0000 Received: by outflank-mailman (input) for mailman id 326065; Wed, 11 May 2022 01:47:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRX-0004GU-Dg for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:11 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0620.outbound.protection.outlook.com [2a01:111:f400:fe02::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 455f0c6e-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:10 +0200 (CEST) Received: from AS9P194CA0003.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::12) by VI1PR0802MB2174.eurprd08.prod.outlook.com (2603:10a6:800:9c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 01:47:07 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::d3) by AS9P194CA0003.outlook.office365.com (2603:10a6:20b:46d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21 via Frontend Transport; Wed, 11 May 2022 01:47:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 11 May 2022 01:47:06 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 11 May 2022 01:47:06 +0000 Received: from 6988c89139aa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66EB7FA4-648F-4F6B-BB99-DC48BFFFF6D7.1; Wed, 11 May 2022 01:47:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6988c89139aa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:00 +0000 Received: from DU2PR04CA0318.eurprd04.prod.outlook.com (2603:10a6:10:2b5::23) by AM6PR08MB4088.eurprd08.prod.outlook.com (2603:10a6:20b:a9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 01:46:58 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::9a) by DU2PR04CA0318.outlook.office365.com (2603:10a6:10:2b5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 01:46:58 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:46:58 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:02 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 455f0c6e-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ok5CyOeuc5iCr5/Ow2NlN/JVQfNgqbQI6AwdgHqgiNcm0ozSB7SGcptm7qZiH4UKvDLQCES9l0ZVkLkoD8oTJ779M8x7HRomRwXQZgLmPGZsjcq0diEoTVbdQQhPCn5fcINaSUw05+qczmjG215os32+E16CfzjctO+xX1UnizRIJVVsH243JaHED3k3859/NKzamrqe15B0fJIuU6pjeUGIXLj1elijAtqycZJ5qu1KHigWLEk3po/mCyYEyAv8K/umr1gYehNwrbQfXbIrwioPvlBoQRvluqHXSnC1CG/BVAXj/ivLEhufavxPAiQpVLywvPRPCo0zSk0ow74FxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/jj6swJvwW7oaPWf61xuXLCqACdkaqKcZ14A1cc0Po=; b=gftvtevopxys/ClG/riOg7vQ6b3XCo0eE/HmoyB/M6WyqPfoNVQHO0FHk/ipNcHOZW2iscUONold1RYRG/nIwcTEXcWA7sBN5H2dC/Fd/8aVZ8nFj08YVftSr3+m4gMolLJrg8/IAl6uQDrTcl/46ThknWBEv9mEKkUBX9UyFwQG/L6dC1fR53s0thQ+6mhH6cQUZLEutk0Hai/3AhXxIwTA/rlnHRz5OGt4HJzJ2jexI6azIKLidom7DmtO7bX1tPC+RmMkXovxLkcR0pouDWEU/6lh82T1z8s3S4FPpTel0NjejJvoNQB+0lEZVChoqReJ+CdqWzjcMQ3ITqlv0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/jj6swJvwW7oaPWf61xuXLCqACdkaqKcZ14A1cc0Po=; b=shvxiBzG8eWn8Rlrg5mTx93hUNwufAReCg+4Q8M9Tk5fpCcf4/HNhS1wAKgma6d/AH0YeLHbtz0KLzpbbcSO2/6+9QAIlBl+tPGTUpF43n06kXr9wx6UpNm8tfugnHoMxSqs/i/l+akivCFKNhWKKZpUrbPjQM/1iAloVVE5rOs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e6acb762ac9f9092 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cn6wZhv2NdrvO5W8IQE45hNexTnPLrBll7smfmwTI8UACcaVmUlQ7H5OCVDfeIWFLNIH5+fM+GjiT+CW0IjqVGp/y+6oRPUO1m5y1TG8T2lpgxKTC3wNBEVH/BmPnS3QVD1UMUkd8f/Ywqg5WNAgauKXp2Pjwg8A94D8H5V2DXBbTWiK/e9uWibDoBOtdxAlVaSdcz16hsTovt6pP7JRoc/xCWvQPUAVbajh9nhCQD6NyjcGgIx7Y8bSsgcBsbxdmNKRcIPjAYqtbOOPZpRxVLSCeDITlzXhYaQEurpktqDJ+Eh0/DJ5LOp7vfWda+EXdoyPI+p9Gi7L5hYBIaR1xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x/jj6swJvwW7oaPWf61xuXLCqACdkaqKcZ14A1cc0Po=; b=Z76qAbTvrGOEFiq0FBAdlzL2WuyJ2mh7bmClMPdXjsXnjSZBnDQ0gTNYBEdr9hJzIy+2ZaU2LOSv0l9DqrHkh+LbmnKolMl7FVa+0BeQifXDfDTixRuAdxZPO2CI2CDO8cTbwjIFuERZ/KXO2l+jW2WVSBmz70qrAuO2Qi41/5i/y/v08K59p28g6kpO51BTbZiH0VhjqxNWLxVEyvgMCw+/0M7Vrr9guboy2LyYpaD6n3mWdmOkvi464rL51svO93QRVwqlARtWM46kECUW2LPNrtgojZlSQlGvFYp3yQvguB5q3aXOIig/608n96jenpDP1KrpiHZbiXA9yuAQpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/jj6swJvwW7oaPWf61xuXLCqACdkaqKcZ14A1cc0Po=; b=shvxiBzG8eWn8Rlrg5mTx93hUNwufAReCg+4Q8M9Tk5fpCcf4/HNhS1wAKgma6d/AH0YeLHbtz0KLzpbbcSO2/6+9QAIlBl+tPGTUpF43n06kXr9wx6UpNm8tfugnHoMxSqs/i/l+akivCFKNhWKKZpUrbPjQM/1iAloVVE5rOs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: [PATCH v3 3/9] xen/arm: Keep memory nodes in device tree when Xen boots from EFI Date: Wed, 11 May 2022 09:46:33 +0800 Message-ID: <20220511014639.197825-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: bf6d0f12-d0ce-494e-3e73-08da32f027f5 X-MS-TrafficTypeDiagnostic: AM6PR08MB4088:EE_|AM5EUR03FT064:EE_|VI1PR0802MB2174:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A7jl5UZcJw9a32kcKiKE7ieB0QeUfVmpFy8dLw7AT9bz98JkWrqln0UVPJP/81OvyOYWyTDYaeqgvNPzorjLsp0i4QCEelFtqm4i8X94gjBTAG11lkidQ6Bq0ac+s/8dLf9VSMpWsDEIIUNG23Y6Ug4s+pO4xLLDs2jw+dha3ptw54ZIzpImke0sIcf5sJ6AwcyeRFSkM5CzEP9TCbmmvuXZ/fJ+j5E6ARF9XR5AvqYZl4OwNc1U7O+C1FuAVeg6nGBIbvfqrOgUWxn2roPkdXn/yO2L8F6TAE0ZZJAZ/SD2OusL+qYuDnpcNS7Jpi5G9fZnsLhWtOIuSGw4MmY+1tSCnIaNYkEVlNsCY6jDh/xkRT9m46WUSjnSWW98qJLxDhjcMGEpC1oL+NRmvO5k83eWcJ1BKC1wd1wK+/b0mL6DPE2C+OTiH41bCbRUzRxwPAsWdt6pMTEvvInrGPoOUaOVbH8myEKpMWAVaNNP5Zu1k7ThsxeLXvkOQ+btxPB+HUrx/gDNXwnH5sw8tYDDv29SD/FbbPvs3B5+JjDsfKXpPtzVHyvVfJ4OvvcF8lMISoXrio8HpOSXyvmTtu0VCgXGgS4lqqLbGUYuEgkNhA7T3pNomMPFtzjEQp+u7UzX0PRNS0k3ilmKJXs5v7wl7v2oJPLJuPzF6xRfDAgrXt/AF99X+eTSQqXxNinSVqgd0ejVBkYeq2JgbnSgDQTQVg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(26005)(1076003)(426003)(47076005)(336012)(36756003)(82310400005)(7696005)(186003)(54906003)(316002)(70206006)(6916009)(508600001)(81166007)(4326008)(70586007)(2616005)(356005)(8676002)(40460700003)(6666004)(44832011)(5660300002)(8936002)(86362001)(83380400001)(36860700001)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4088 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f67028f7-0756-4475-7423-08da32f022c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aR6x9aD0H+KPNXee7VaQr9AFdjIbGMz7YNDYsHF558JjSJsuzz23Eeki/W53Ums4vE9j0KeRA717iVN29owXXcwSor0i0xrmJzDdHwk8lgI4O5lNff4IUjOYEjm/vCQPdkdt0dCo3zF+YHgAEHn7nCD/h8nImQlDy5vYvU0F5Y6gWfCq7vPUXOXVI8jh5Wywu1VXPRaO8uOwtMrV3C8zbnzoPU4spKoA4HxHT7zDPlZhw/jM++rQ47PFcjNl6B947cjUQWyKtMKkjVEOhovG9qpBbyAXjLVkd6Qg0eYl8W1X8spqGCQIxOLF51dPLz0WEVLGJN+DTbq4bl5slQEZAxSck5Qk8f3gcpxQKEeeWH9/k16M1iFfRaFe6q3FQeKIDCmr3NaIDCmpWY7rZW7KDOB0gwEFZ9FGVwcXJzfci8v5TR4pWB3gANQ8YAQu+njdMfltTVo2mGb4xK1VI1OVyd9bmJ2eFqxZQugPLXSNUvb2Ttl2hmOf92idHZPceN/McplBDSlfsedvu/G+AqxuiRAKEH2UaKtIl+PCeFh/9TUHLmS799HpDee9mw08J8qyDr5s+NeEq0BFBDbrgNApTsUTzIGbzrtIFQ5/SWkgZJiQgpQ1o6kT092zBPiHd+Cl6SnxyEwWSh3dHsCLeHuFqKwlrhRxWiuogiwUY5RNm7g1G/U2UBCUxsiEouzrsF0n X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(81166007)(83380400001)(336012)(426003)(47076005)(82310400005)(2616005)(1076003)(6666004)(7696005)(6916009)(54906003)(186003)(40460700003)(8936002)(5660300002)(26005)(36860700001)(70206006)(70586007)(2906002)(316002)(8676002)(4326008)(44832011)(36756003)(508600001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:06.9801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf6d0f12-d0ce-494e-3e73-08da32f027f5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2174 In current code, when Xen is booting from EFI, it will delete all memory nodes in device tree. This would work well in current stage, because Xen can get memory map from EFI system table. However, EFI system table cannot completely replace memory nodes of device tree. EFI system table doesn't contain memory NUMA information. Xen depends on ACPI SRAT or device tree memory nodes to parse memory blocks' NUMA mapping. So in EFI + DTB boot, Xen doesn't have any method to get numa-node-id for memory blocks any more. This makes device tree based NUMA support become impossible for Xen in EFI + DTB boot. So in this patch, we will keep memory nodes in device tree for NUMA code to parse memory numa-node-id later. As a side effect, if we still parse boot memory information in early_scan_node, bootmem.info will calculate memory ranges in memory nodes twice. So we have to prevent early_scan_node to parse memory nodes in EFI boot. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Stefano Stabellini --- v2 -> v3: 1. Add Rb. v1 -> v2: 1. Move this patch from later to early of this series. 2. Refine commit message. --- xen/arch/arm/bootfdt.c | 8 +++++++- xen/arch/arm/efi/efi-boot.h | 25 ------------------------- 2 files changed, 7 insertions(+), 26 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 29671c8df0..ec81a45de9 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -367,7 +368,12 @@ static int __init early_scan_node(const void *fdt, { int rc = 0; - if ( device_tree_node_matches(fdt, node, "memory") ) + /* + * If Xen has been booted via UEFI, the memory banks are + * populated. So we should skip the parsing. + */ + if ( !efi_enabled(EFI_BOOT) && + device_tree_node_matches(fdt, node, "memory") ) rc = process_memory_node(fdt, node, name, depth, address_cells, size_cells, &bootinfo.mem); else if ( depth == 1 && !dt_node_cmp(name, "reserved-memory") ) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index e452b687d8..59d93c24a1 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -231,33 +231,8 @@ EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table, int status; u32 fdt_val32; u64 fdt_val64; - int prev; int num_rsv; - /* - * Delete any memory nodes present. The EFI memory map is the only - * memory description provided to Xen. - */ - prev = 0; - for (;;) - { - const char *type; - int len; - - node = fdt_next_node(fdt, prev, NULL); - if ( node < 0 ) - break; - - type = fdt_getprop(fdt, node, "device_type", &len); - if ( type && strncmp(type, "memory", len) == 0 ) - { - fdt_del_node(fdt, node); - continue; - } - - prev = node; - } - /* * Delete all memory reserve map entries. When booting via UEFI, * kernel will use the UEFI memory map to find reserved regions. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326066.548909 (Exim 4.92) (envelope-from ) id 1nobRa-00052Z-KH; Wed, 11 May 2022 01:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326066.548909; Wed, 11 May 2022 01:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRa-00052E-Dh; Wed, 11 May 2022 01:47:14 +0000 Received: by outflank-mailman (input) for mailman id 326066; Wed, 11 May 2022 01:47:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRY-0004GU-Dk for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7d00::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4558f126-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:10 +0200 (CEST) Received: from AS9PR06CA0480.eurprd06.prod.outlook.com (2603:10a6:20b:49a::30) by PR3PR08MB5866.eurprd08.prod.outlook.com (2603:10a6:102:85::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:47:06 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::44) by AS9PR06CA0480.outlook.office365.com (2603:10a6:20b:49a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 11 May 2022 01:47:06 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Wed, 11 May 2022 01:47:06 +0000 Received: from 8986669a2072.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 23BF4FED-3FF9-40EB-8E54-CC7DBF7E8E6D.1; Wed, 11 May 2022 01:46:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8986669a2072.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:46:59 +0000 Received: from DU2PR04CA0318.eurprd04.prod.outlook.com (2603:10a6:10:2b5::23) by DBBPR08MB6203.eurprd08.prod.outlook.com (2603:10a6:10:201::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:46:57 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::9a) by DU2PR04CA0318.outlook.office365.com (2603:10a6:10:2b5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 01:46:57 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:46:57 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:46:59 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4558f126-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MZbuMh0vyvP5CkXOm5Ih3G7ad1NGvgZ1mh5MQ2l4AyQNuSHgf9R+gQRjFNf3bO3krux5HOw/sL3+6Ge9upS9D6aLIxLLXCh0TA2NgbquGfnpmD7d7S0Sv2OEejwdKzBOLH0FqTwKuQZRMGhHesHrEEkksm5DQluIB3R8F+IeCRa0jF4ADBgBXMQ2nv2ZQnORePF9YXBCKAGntez54A/qPcK5G0iIkMXTIr2Hgt+FUyQp6La+SwLNAEdvXz2CtSIi17hhBPxbACUdWoMkUmwL7w/nh1XrFu7EQbpeE104dUtNjH7H6bvWzgeDilNQAvdbpG5ygCcQQVVq/tYAujcUhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQIxNpG9XWjS8jCouYiFG25ZvC/mZVVFrI47a1AK6HQ=; b=HASPY2BDwff5AOzjDPlUd/HfORdbhNdWb2Nd5sbZEEAdK+L6OHsuT1AuNb0YH3ywbA1KF3+E1ayYdpM6ML3dHVOtvlMXLiW+cZ2XeK1bd/VT/b9jC2IdCwNRdpsmQFfrReyaDJjKxISZTsiXoOinDMods0G15bvTwGR3g464WR6mkXqALIxe4+G6nN/tNwXRGr6DeNs8E43tUqiTz7GZfmiTtIL6tnWsSSmNFanG9Iny6TDmBKGQPDpPQMjjUM1YsF8/4EpDGP18cZZ/r8oANCf/Iehp4QndqHO1zJPZI8wl6B6/dBt5yfAaqKd3OUQbYIy+6LGotailyNnPT80cPw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQIxNpG9XWjS8jCouYiFG25ZvC/mZVVFrI47a1AK6HQ=; b=WRdGgamaNKVDYkE/jSutLIMrm2hRPTAGJsvW5mnm5fCwSi+VEanVmllHlV0qDx3d0wrFauDGSbKGndp7+MyOzeX8yTtlZAUvDUXvKeuhFAWLki+cV3pOHhkjFT2YD6ZxDZEvL9Eg30Q0K4Jx4Adh8uwodgqljxpn6aoHVwSAGtA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 67f312fc754eb527 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIwsCpiec2gf+aCo2fsD52e/Lg/+XIALZPTbHfSa4y199ZlBUn2HEVkMfFToi5JiGh9vbKLohQQNh0BhMHzPiaJeDd+zqpsXm7ZpokxhDlBZ2NGioFSv2H+wu5zW+oGmD8pvBOAVkWnHyMPioROUoY3qmmQvHX52xoq1BQ0vEFg885Hpn4Jh6yUNOKvNw0M5xkO2YR4A1twQ8do9ENpI6s5lvziB9muxPi07nJ+f+BVuzkAAUC4S7sGVkR4XlBUQw3WOiEVDseJZAwZFHmWqfQjChz7b1eyO+Ruuu5tuTm2LVBmVN9wf/iB4a8xZyGlZXmQHYtNo3jCSnw/U9XTvHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQIxNpG9XWjS8jCouYiFG25ZvC/mZVVFrI47a1AK6HQ=; b=E2E+7mna1QxEsOZjQD8FrAwSXXmWVpzigyPLylHJ9rVQwvRXBfbjq/UfK0x7KkDa+c/4Cj1j9W1BpBDNhLXGOqywn9aXGm97PPUVOuDLkNc6/jVBLiEgEEzcz3KIwXIAM04FzTrsDhSpR7GZyrVu/8tPeS/s8nVWcvg3WvoDv05zf105cPG9MXhh4bDJ373FemgIWr26735Fv+IVR3N1Wg3guLgVNDdqEFwd3U9uMg82IgFO6vT4qhTj0WVI49JZNaYueG2idkLcnf8pH9T7aksdJ9Ih8dvRoxKFLLpaHt48J6H2Gl1mUjWe6o95+d2aJU9dMuZeuXTKck58PcSB5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQIxNpG9XWjS8jCouYiFG25ZvC/mZVVFrI47a1AK6HQ=; b=WRdGgamaNKVDYkE/jSutLIMrm2hRPTAGJsvW5mnm5fCwSi+VEanVmllHlV0qDx3d0wrFauDGSbKGndp7+MyOzeX8yTtlZAUvDUXvKeuhFAWLki+cV3pOHhkjFT2YD6ZxDZEvL9Eg30Q0K4Jx4Adh8uwodgqljxpn6aoHVwSAGtA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Date: Wed, 11 May 2022 09:46:32 +0800 Message-ID: <20220511014639.197825-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 5f039a43-4a20-4e15-0904-08da32f027c5 X-MS-TrafficTypeDiagnostic: DBBPR08MB6203:EE_|AM5EUR03FT059:EE_|PR3PR08MB5866:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7So8BBdlnXGEl/8g6QbJfC2E8/k+qckcWxMwj7f4pkgfRFW9LMPgf1gF9divqJM36uhHjFP1kOVG3cyqjqvXTy1i3pT5NNs90im6AmgiMaOLE0ESNakQFVKn3aOHfdLQ3Vs4mDO9i4NVVinfFhJiMCp8YfDoJnAaOwNPDcrBsEG1xmaWrgKNDskUARVx1KZZwXQDHt2CDsP0MMqoLGuyYRtdzZOcYMJm1+9AKG8NFuBioIAg35dUPYdBKU0I0PNBI6V8auOw6nF8XynqzX85MV8S4lKoXAi0Me9PdOCKJTh6Y//gTyNhb3zRUWe4uFUXUTtygdm71EgkaaPCYMlfMjWppzlaW0YIbYmmt/n1h4kTJVl+G2Hi062wElu2UT2Fxh72qgV8zZJg71SopmmrOYtqxBzBiBFelyw8+6l34gkToBkZ5rICiNADPS6uqUi2fsUoOcZKXSAp9ukvKBtOdcqhfzCG/hv+y+BI29t8rclPtcQYm82X/0mJKYCBHYSDnaXcLNHhnFBIIpwV6iXgy7YnYUqBGsfMuBC41kwnle5FI49JWBAvh08nvfhaexd+nT8lnonIBDzvpvHJCAvnlakLSOYFnv7LljTqEIhRqzZnvKyklkS4OFFoTpQ0AbRDkkBwjFSBBWpb7r46RxHG72VTygI+zbXIMa2InwOYWwcJLSsZjkj6hSEvE80xjEp2KWLFAvp6Ps7gE+nFbGmcC1fbohu24NDx7316TggRNMs= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(508600001)(81166007)(316002)(8936002)(6916009)(36860700001)(54906003)(356005)(8676002)(4326008)(70206006)(70586007)(86362001)(6666004)(83380400001)(40460700003)(44832011)(26005)(7696005)(1076003)(2616005)(186003)(426003)(82310400005)(2906002)(47076005)(336012)(5660300002)(36756003)(21314003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6203 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2e0cfc15-621b-4862-79eb-08da32f02267 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: spppZHQF2dANpQblLsphI3LwiBl2dtY6EIGuLvSx3s3ZCe3QhgV/y2UT+Wl7JTeYVO65xftgfJZw3zNDV3GYgYa++dxqUrqqha6yH0XUFLzFLebVgn+mDQxJZu8bhYxHMDgWI77R/DPMcw9pd8PK80OVsfQ7Kvt4y37sGKq1/beq4y+1rLg740k4vaM0+0aO1SMogruH68g4djdsXIptt+8ZKZcAwQqX5oBo1Cu8XeyJ3IHxnpxc4QE27MfODAUqkYmNf2LprFYXOOOReBoltG07iM6yNdegS7HYGQISQIX5oNUF7Vmr+8Z22gbLe28GKnVcsmLTE85Y2YApwl13iQKA9lBTD7DD4Lf4Zx2GD0z8+JTsaarg7tp4eJLfxEHfpekAxT08cJ7iTvv5BPdh+gAUgd8sBXHrW/ppIzdmiTUuE0HYLBbWusPrtGO/wp9cIiQtOGi6Un64IaarkIUshkuP4xLfmDfInDYPWf9jnPCpYqTVujKwZInX6LxKm2OrdLnuzXE35N8emFd0JTS5c1mdLQ/UYJXtx6Ev+Aj5M2ZShA6np9VauMTamZd5jzUVvIH2nbnsnL+5oeTPgr4r2B2/4b7AywTREp/S7OqlNXDcmqYKbXL9YkG35KDiRioHYPjCCtgRGf7vLkcyj1CdQjMQ5tw+UEXy5IU+WMv3t/h0aBNKihCTtSrtlo8so6TecUQCo1t2TLI5fTzlXp/0xg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(26005)(8676002)(2906002)(83380400001)(426003)(1076003)(336012)(86362001)(186003)(4326008)(47076005)(36860700001)(70586007)(44832011)(70206006)(40460700003)(316002)(5660300002)(82310400005)(508600001)(54906003)(6916009)(81166007)(36756003)(7696005)(8936002)(2616005)(6666004)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:06.6485 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f039a43-4a20-4e15-0904-08da32f027c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5866 x86 is using compiler feature testing to decide EFI build enable or not. When EFI build is disabled, x86 will use an efi/stub.c file to replace efi/runtime.c for build objects. Following this idea, we introduce a stub file for Arm, but use CONFIG_ARM_EFI to decide EFI build enable or not. And the most functions in x86 EFI stub.c can be reused for other architectures, like Arm. So we move them to common and keep the x86 specific function in x86/efi/stub.c. To avoid the symbol link conflict error when linking common stub files to x86/efi. We add a regular file check in efi stub files' link script. Depends on this check we can bypass the link behaviors for existed stub files in x86/efi. As there is no Arm specific EFI stub function for Arm in current stage, Arm still can use the existed symbol link method for EFI stub files. Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v2 -> v3: 1. Add existed file check, if a regular stub files, the common/stub files' link will be ignored. 2. Keep stub.c in x86/efi to include common/efi/stub.c 3. Restore efi_compat_xxx stub functions to x86/efi.c. Other architectures will not use efi_compat_xxx. 4. Remove ARM_EFI dependency from ARM_64. 5. Add comment for adding stub.o to EFIOBJ-y. 6. Merge patch#2 and patch#3 to one patch. v1 -> v2: 1. Drop the copy of stub.c from Arm EFI. 2. Share common codes of x86 EFI stub for other architectures. 3. Use CONFIG_ARM_EFI to replace CONFIG_EFI 4. Remove help text and make CONFIG_ARM_EFI invisible. 5. Merge one following patch: xen/arm: introduce a stub file for non-EFI architectures 6. Use the common stub.c instead of creating new one. --- xen/arch/arm/Kconfig | 4 ++++ xen/arch/arm/Makefile | 2 +- xen/arch/arm/efi/Makefile | 8 ++++++++ xen/arch/x86/efi/stub.c | 32 +------------------------------- xen/common/efi/efi-common.mk | 3 ++- xen/common/efi/stub.c | 32 ++++++++++++++++++++++++++++++++ 6 files changed, 48 insertions(+), 33 deletions(-) create mode 100644 xen/common/efi/stub.c diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..8a16d43bd5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_64 def_bool y depends on !ARM_32 select 64BIT + select ARM_EFI select HAS_FAST_MULTIPLY config ARM @@ -33,6 +34,9 @@ config ACPI Advanced Configuration and Power Interface (ACPI) support for Xen is an alternative to device tree on ARM64. +config ARM_EFI + bool + config GICV3 bool "GICv3 driver" depends on ARM_64 && !NEW_VGIC diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 1d862351d1..bb7a6151c1 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -1,6 +1,5 @@ obj-$(CONFIG_ARM_32) += arm32/ obj-$(CONFIG_ARM_64) += arm64/ -obj-$(CONFIG_ARM_64) += efi/ obj-$(CONFIG_ACPI) += acpi/ obj-$(CONFIG_HAS_PCI) += pci/ ifneq ($(CONFIG_NO_PLAT),y) @@ -20,6 +19,7 @@ obj-y += domain.o obj-y += domain_build.init.o obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o +obj-y += efi/ obj-y += gic.o obj-y += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index 4313c39066..dffe72e589 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -1,4 +1,12 @@ include $(srctree)/common/efi/efi-common.mk +ifeq ($(CONFIG_ARM_EFI),y) obj-y += $(EFIOBJ-y) obj-$(CONFIG_ACPI) += efi-dom0.init.o +else +# Add stub.o to EFIOBJ-y to re-use the clean-files in +# efi-common.mk. Otherwise the link of stub.c in arm/efi +# will not be cleaned in "make clean". +EFIOBJ-y += stub.o +obj-y += stub.o +endif diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub.c index 9984932626..f2365bc041 100644 --- a/xen/arch/x86/efi/stub.c +++ b/xen/arch/x86/efi/stub.c @@ -1,7 +1,5 @@ #include -#include #include -#include #include #include #include @@ -10,6 +8,7 @@ #include #include #include +#include "../../../common/efi/stub.c" /* * Here we are in EFI stub. EFI calls are not supported due to lack @@ -45,11 +44,6 @@ void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle, unreachable(); } -bool efi_enabled(unsigned int feature) -{ - return false; -} - void __init efi_init_memory(void) { } bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) @@ -62,32 +56,8 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { } -bool efi_rs_using_pgtables(void) -{ - return false; -} - -unsigned long efi_get_time(void) -{ - BUG(); - return 0; -} - -void efi_halt_system(void) { } -void efi_reset_system(bool warm) { } - -int efi_get_info(uint32_t idx, union xenpf_efi_info *info) -{ - return -ENOSYS; -} - int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *) __attribute__((__alias__("efi_get_info"))); -int efi_runtime_call(struct xenpf_efi_runtime_call *op) -{ - return -ENOSYS; -} - int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *) __attribute__((__alias__("efi_runtime_call"))); diff --git a/xen/common/efi/efi-common.mk b/xen/common/efi/efi-common.mk index 4298ceaee7..3a5b9958b3 100644 --- a/xen/common/efi/efi-common.mk +++ b/xen/common/efi/efi-common.mk @@ -9,7 +9,8 @@ CFLAGS-y += -iquote $(srcdir) # e.g.: It transforms "dir/foo/bar" into successively # "dir foo bar", ".. .. ..", "../../.." $(obj)/%.c: $(srctree)/common/efi/%.c FORCE - $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( +#include +#include + +bool efi_enabled(unsigned int feature) +{ + return false; +} + +bool efi_rs_using_pgtables(void) +{ + return false; +} + +unsigned long efi_get_time(void) +{ + BUG(); + return 0; +} + +void efi_halt_system(void) { } +void efi_reset_system(bool warm) { } + +int efi_get_info(uint32_t idx, union xenpf_efi_info *info) +{ + return -ENOSYS; +} + +int efi_runtime_call(struct xenpf_efi_runtime_call *op) +{ + return -ENOSYS; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326067.548920 (Exim 4.92) (envelope-from ) id 1nobRc-0005LH-5U; Wed, 11 May 2022 01:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326067.548920; Wed, 11 May 2022 01:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRb-0005K8-Ut; Wed, 11 May 2022 01:47:15 +0000 Received: by outflank-mailman (input) for mailman id 326067; Wed, 11 May 2022 01:47:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRa-0004GM-Me for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:14 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060d.outbound.protection.outlook.com [2a01:111:f400:fe0e::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47807436-d0cc-11ec-a406-831a346695d4; Wed, 11 May 2022 03:47:13 +0200 (CEST) Received: from AS9P194CA0014.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::25) by AS8PR08MB6168.eurprd08.prod.outlook.com (2603:10a6:20b:294::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:47:12 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::c5) by AS9P194CA0014.outlook.office365.com (2603:10a6:20b:46d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 11 May 2022 01:47:11 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Wed, 11 May 2022 01:47:11 +0000 Received: from 9348a7c0bace.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 29CEBCAD-1E22-41EB-8331-B78B95476B4B.1; Wed, 11 May 2022 01:47:04 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9348a7c0bace.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:04 +0000 Received: from DB6P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::19) by AS8PR08MB6168.eurprd08.prod.outlook.com (2603:10a6:20b:294::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:47:02 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::ab) by DB6P191CA0009.outlook.office365.com (2603:10a6:6:28::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:02 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:02 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:06 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47807436-d0cc-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YiKQ1FZZNHv/Je8IQtgbwbBMH6wuLh1BNvcKBiy5P1LnlHeepHb9mmuPLV4/bQwHKyMLpfrgYPDfszkrK09YShYng9hQVumYJOO7VUKL144d6F5QGHLFLOUBTQObi60zzyjTAFERkwDcMxf1fONHi3tOoUeI56V/tpKcNk8/onBSzUxPpAHJafv9YcZKox29G6bXUxCUZHdnK7mosZor7jdSz6gurWgzi+qv82T4Qom41hllbStutthAw85GvFZSDt4wBsONJiYJzfC05j18xBLbVVFK51p8+JY37QVHj2gAr+0w7TUaD8eBvBnVNvxSUyo9fBdl8yLavpOlfkhnEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPSfIwEjnBcSkjkYn/EHN2y2ss0WA2Wo+7fHC3m1wHA=; b=aHtTsncjJ/3fqjcEOoVPaJ+vVbHWwfsHwztj5HYVVQSFV3WZIbQTAehm7Ct8PRpGnKpG1ct8Fw+zPfaSyQfQZqTDk4oQVw0GksMK4ghE9cN93mrfzCWYVEw6TP2ByUTVQHBpMI3jw7i5ECrWAbG7fVJPELKHlFpLjexQEh0nD4zy++rItVVIKgsxJ0tz8WgPpYQbKVKJ7uQiDNB0YMrL6plY+z7U02/NhGoa6cPBJ85RLED9Ax5OdCZSZUujuyOcwH8zS3vGiEKARuC22XAgsvk57ecMky1yuYwVmVXmPXcg+WAVQa5mBq0GKpWALo8QRp4D+cLOlbg/F5kdD6Kh2g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPSfIwEjnBcSkjkYn/EHN2y2ss0WA2Wo+7fHC3m1wHA=; b=eIvg2mMPDb19hnd2tZmD3Es495OepNSHX1ZbYsIQbURCzz1cz7Q3ZqpAOS3vQ6H+FxAHZAE6pRZCIBL+suT6/SqxIHzKlG66xEGGAJt56lLccJkEPZCSz8a2sbvltLnj++25CfqumFKqGJ02G226DvczgBD5AmPnMNSnTAcfNMg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7112f9e97c08240c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mOw4vk8d6PaxtAWqKBSPAcuG1Wt0ABsIDKk6C6hd8d7pJyC/Z1/7KkERwbqNLfwA0DZDP0fSBX6tUgyepyEu7n+ZStSqFumIxmNB3nOXBiTOv6/ysDPsUHmc5s6Gl6+FRQBz5x6N3eFnvWHa7OM4LDvoZvSkmZI2r3BARzhuCKzyTaeHCRuh7Phzk9ZEVZXLMRviTpDiV+qEUJhjI2GB8cj2MhfTZwHVr++W9TyN4H9s59ammJHO/ak2Vet3lNKzQY1DkdXavH8R5uAYL6xxuhdLdASvFHLy+0fIWRi3xNRGcWf0o/pEXgl/IbLTl482Atd1zGN2IJOa6eSOdjjLfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPSfIwEjnBcSkjkYn/EHN2y2ss0WA2Wo+7fHC3m1wHA=; b=eKvr/qiqMTxDc98TEiuYzexaz8pnjdORcXsQGlgrQGq2JIRgrgq72VSKQYec5yb8Y86w+D2yeJjAe1xgfYJQl1uWdTpQVb+JnWYAjs/eu4fl2CYJHoGxGdFihD7AkN96hPTdTWRsd/KkwoZKPUp/qJERBcTmN8C+lzrDfYDVkBIbT7sA8BC+ZaAOPRHt5oJcN3YknozfnswQRpRR6avSDx8V0irkf5VL1RvMmXNEsPObdsl1Lp8kuIqgjfMtSNXx8JFxZzXcsyG7+VZ5sWZjuyolT94XeBZccR2EsZIAzeegFW92mkBtWsjaz2hm4zNUDaW6gDr+NlICYKXOgPYFEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPSfIwEjnBcSkjkYn/EHN2y2ss0WA2Wo+7fHC3m1wHA=; b=eIvg2mMPDb19hnd2tZmD3Es495OepNSHX1ZbYsIQbURCzz1cz7Q3ZqpAOS3vQ6H+FxAHZAE6pRZCIBL+suT6/SqxIHzKlG66xEGGAJt56lLccJkEPZCSz8a2sbvltLnj++25CfqumFKqGJ02G226DvczgBD5AmPnMNSnTAcfNMg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jiamei Xie Subject: [PATCH v3 4/9] xen: introduce an arch helper for default dma zone status Date: Wed, 11 May 2022 09:46:34 +0800 Message-ID: <20220511014639.197825-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 27ae987c-8635-4643-8295-08da32f02a8c X-MS-TrafficTypeDiagnostic: AS8PR08MB6168:EE_|AM5EUR03FT011:EE_|AS8PR08MB6168:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9D5dSl+IHqFCQous1oWgTfK7nYLLX93Sr3N+K6lMtiRLttQrY5G+kpto9tDGfmKD0yeFaWCZZzaxqmxLYsv4J7PQKGYfqep7AOktq38hGy97w9/J+dkf/acbjUz29AM/+ngKdG+wMOMwOOiTfx6aQDrkFjNrUyPk9z2pxQ1HdxIIxoDYwM79Sj2m+61kfCJ2X75eAUXVEmqPb3EDGYKtlEJ0Pi/9Z/sC/Cx7ZlXc6V1niBl7o2J7VKpIqXEGnok6gKMN3pPS5fqhkuwY76a7ztIUr0A6/7z2bSqFHbiSQ5NoYMJPeDygJBg5bSp55PhRQpwQlFzObX2WZVIWP8CO9lfOanjYrH11TkLKpYjogp96iZDX1630wkjqZTq9dRlO0Tb91H1D0MGueDjx98C/sZLwJWiI4xlrCHiHngS68ws5L2s6iXU5HLP2Q4lFi2epFm8Zi3gKxHQZCx5/bhe4fWw7ZRPtejADgZIisy2UAEett8uOZzi53FXYu3YHkId4uuvmtoxs6IWAgTMBow3q9W8mlo45nfgP3a0Nji4L1Gw+f0juNKq/cJBmmBtfBk+vJ9GddZbFlrrjUy2BeG6G5CVby2xCQNAXxawA/oPj/6JzdaA376lwLmnUDunQgGoNJz21w53RWhoYq3lSz6+uWs+whpUxJwouVwKxG+7c8ZLJ8088bcGT3kpVhj1gxmPRLHNCk1Mb/HdOvQYPJuxQ/g== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(40460700003)(6666004)(47076005)(26005)(7696005)(508600001)(356005)(36860700001)(81166007)(186003)(82310400005)(54906003)(6916009)(83380400001)(86362001)(336012)(426003)(1076003)(2616005)(5660300002)(8936002)(36756003)(316002)(70206006)(2906002)(44832011)(70586007)(8676002)(4326008)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6168 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8f40f497-3e9a-4aa8-725d-08da32f024fc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fX5LGqlgenMDnYIvR31pbUkZK+tsyJWTtxJR4cxfQ3PKWuz/IjD1tK8H8rUDUS8BUjtd2mdlJ28WSLIvMNq3wODTBLT18kiAx9oq2tOSAIhG0ZlZOOonichqx2CHkjNl1qC97/We27HMMbqiQsJ9bsolhZOs86rpgen48wVX337YMSIkHyAKJXTtmYmheMawn9lk08aY9IOxwYHHq5Lago3mxanB7l09sqyuH+eXPGpmK+xg/JxRdn4dwbi5wll9gNNk7Qsx2RAe2sWFFvHztjQ1IKlYGiFfwT1RkqO+pYcOTeMZJOl5NQnazr60WwSmwksLK1uNVd0zdxN8psTDi27rA6wpKGMM58A29eoDPuLSEU4cdF6LpiiHHH7LnhH+Kxbppkg3Uhl5ezZ/D1ec3GnZGdeEavr8LaBPV5miHXdWhfdQB5eaUY2KalDfBZPoBx4hP1yRIpWTkj27QA8Ncriqb0D05ARLvj45kFCyMgQOtPQkIX5+KuQQnDzgoJB05+EouAX2Nj+XUcVgWLPTSKUkg0Gv6I9mmrSxOyqgTM99lCFFYH8gnrYl1KDVgIOEON3ya/EuJsvWobW5bG+rAoJVnlZbrlfKLU0HXzvkULVLnIN6jOCjUirVZhWfTmf1YWKKWAlc93GwMgaeusJ+wBKtS6Wz+HC4+viOFf3jpOdn9XaFlkJhzQi/zJwtQtxQ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(40460700003)(6666004)(47076005)(26005)(7696005)(508600001)(36860700001)(81166007)(186003)(82310400005)(54906003)(6916009)(83380400001)(86362001)(336012)(426003)(1076003)(2616005)(5660300002)(8936002)(36756003)(316002)(70206006)(2906002)(44832011)(70586007)(8676002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:11.3163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27ae987c-8635-4643-8295-08da32f02a8c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6168 In current code, when Xen is running in a multiple nodes NUMA system, it will set dma_bitsize in end_boot_allocator to reserve some low address memory as DMA zone. There are some x86 implications in the implementation. Because on x86, memory starts from 0. On a multiple-nodes NUMA system, if a single node contains the majority or all of the DMA memory, x86 prefers to give out memory from non-local allocations rather than exhausting the DMA memory ranges. Hence x86 uses dma_bitsize to set aside some largely arbitrary amount of memory for DMA zone. The allocations from DMA zone would happen only after exhausting all other nodes' memory. But the implications are not shared across all architectures. For example, Arm cannot guarantee the availability of memory below a certain boundary for DMA limited-capability devices either. But currently, Arm doesn't need a reserved DMA zone in Xen. Because there is no DMA device in Xen. And for guests, Xen Arm only allows Dom0 to have DMA operations without IOMMU. Xen will try to allocate memory under 4GB or memory range that is limited by dma_bitsize for Dom0 in boot time. For DomU, even Xen can passthrough devices to DomU without IOMMU, but Xen Arm doesn't guarantee their DMA operations. So, Xen Arm doesn't need a reserved DMA zone to provide DMA memory for guests. In this patch, we introduce an arch_want_default_dmazone helper for different architectures to determine whether they need to set dma_bitsize for DMA zone reservation or not. At the same time, when x86 Xen is built with CONFIG_PV=n could probably leverage this new helper to actually not trigger DMA zone reservation. Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v2 -> v3: 1. Add Tb. 2. Rename arch_have_default_dmazone to arch_want_default_dmazone. v1 -> v2: 1. Extend the description of Arm's workaround for reserve DMA allocations to avoid the same discussion every time. 2. Use a macro to define arch_have_default_dmazone, because it's little hard to make x86 version to static inline. Use a macro will also avoid add __init for this function. 3. Change arch_have_default_dmazone return value from unsigned int to bool. 4. Un-addressed comment: make arch_have_default_dmazone of x86 to be static inline. Because, if we move arch_have_default_dmazone to x86/asm/numa.h, it depends on nodemask.h to provide num_online_nodes. But nodemask.h needs numa.h to provide MAX_NUMANODES. This will cause a loop dependency. And this function can only be used in end_boot_allocator, in Xen initialization. So I think, compared to the changes introduced by inline, it doesn't mean much. --- xen/arch/arm/include/asm/numa.h | 1 + xen/arch/x86/include/asm/numa.h | 1 + xen/common/page_alloc.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 31a6de4e23..e4c4d89192 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -24,6 +24,7 @@ extern mfn_t first_valid_mfn; #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) #define __node_distance(a, b) (20) +#define arch_want_default_dmazone() (false) #endif /* __ARCH_ARM_NUMA_H */ /* diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index bada2c0bb9..5d8385f2e1 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -74,6 +74,7 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) #define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +#define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(u64 start, u64 end, nodeid_t node); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 319029140f..b3bddc719b 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void) } nr_bootmem_regions = 0; - if ( !dma_bitsize && (num_online_nodes() > 1) ) + if ( !dma_bitsize && arch_want_default_dmazone() ) dma_bitsize = arch_get_dma_bitsize(); printk("Domain heap initialised"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326068.548931 (Exim 4.92) (envelope-from ) id 1nobRh-0005oX-It; Wed, 11 May 2022 01:47:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326068.548931; Wed, 11 May 2022 01:47:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRh-0005oB-CT; Wed, 11 May 2022 01:47:21 +0000 Received: by outflank-mailman (input) for mailman id 326068; Wed, 11 May 2022 01:47:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRf-0004GU-7z for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0e::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a501202-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:18 +0200 (CEST) Received: from AS9PR06CA0375.eurprd06.prod.outlook.com (2603:10a6:20b:460::19) by VE1PR08MB5264.eurprd08.prod.outlook.com (2603:10a6:803:105::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 01:47:14 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::5a) by AS9PR06CA0375.outlook.office365.com (2603:10a6:20b:460::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21 via Frontend Transport; Wed, 11 May 2022 01:47:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:14 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 11 May 2022 01:47:13 +0000 Received: from 3b6bc433268b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F93D4BF4-9DEB-48C4-BE26-2F28D527AB6A.1; Wed, 11 May 2022 01:47:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3b6bc433268b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:07 +0000 Received: from DB6PR1001CA0036.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::22) by AS8PR08MB7251.eurprd08.prod.outlook.com (2603:10a6:20b:342::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:47:06 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:55:cafe::3b) by DB6PR1001CA0036.outlook.office365.com (2603:10a6:4:55::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Wed, 11 May 2022 01:47:06 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:05 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:10 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a501202-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Zv6yxqphhkd4vUjA6nkIjAcyKgGJqsrzoh9voTxuhGaxCj2z8InpHLpuOM2IX2nc4UZKH0hT8X0Kz1wwe6pm/Y3MG9ZueisoJEEDtg8vPObO6PLk1az7Ex386Knk9xPUB9FeNIXucARsyj4RFQQDMo/2JAhfLLxWMkCy8vfVXE/YlgjZ217W0Yt8oBcjP/Lrwt6LmijigueULZpFZm20mue+6awisia36WHWSmW1zmuJZc00Khzj2oOB6BIvp0P/I9UUOS3m5oaT8gegyAE6hcFWPgWQu2+tNaSAcYZ+i2KUSzdzMqNLVyZ/ilqCwYf6dH2P8fb83I4s7nB14YKVZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSt+Pu4jp4HTh5s3fyvo/zwavoKA0tqqNX8BCNWb2go=; b=iFcYnhgZ2r8yNgJvzsQGJlX+GfoRaT7zpSni2ieh2QP+eYFqCLOwRVVoJ2v+fqBYNdFf7BEdfmOMfYBaFZNKxCMLHbO2rSQ57VBTfdyi68K+9lxl/y8G5Zqr0wrWz26H7iWJE68OOMZvB+4D0SjEBIk5EdQkRLOniZH3vpzKPwWPGLxzohCLRNVqkFI3xyS5Eyg1560dOgBk80v20sx2hrjghjwylcj8IGFtfcL8Zxo4j2txLKzB1wxnyLHaY6RnCYHYy6V2/VM+8/DDe9WzCF4PPq47ev/jjYRWoOVTAl4Ibb0C+fEWtBdEfBdCBFXc5L/DEm/dIR81UcXcPTxp1Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cSt+Pu4jp4HTh5s3fyvo/zwavoKA0tqqNX8BCNWb2go=; b=bD9h99M2vQqHgxpnEefeD2D/TOb603Vy/aXfcsXVb/2flQzfwaCSdklxRDRCXtpzU7w4FSxEN/1SAJHjR4OqBTjjcFXq02BeaWYSYKzxv2kyFFZyJA7TVENXd1BAD6KnUoxkgepao6woK0Opaj+NrdLaI6BT779zGlEWGD2egpk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 139e08af208393d2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgkw1cPl6yGs945bQP4admDEBa+5+piGSUdm+VP5U+/dqGKyJVPT3PMP1jaMZb29DSKbBNpEGEqkh52+Wy31rQH+PqFzZOtQsgYt0ym3zXhzeQ2OP3i1SU8CIzp54rpaNCI+LtrrEyLCTfz7JFU45aZV62Bc1Laha6qlljfXiE9RVUqYFNH4+ZCs+ml6EY1nD6R+jH/DCDoRc84Ubh7xgizRdyO3TzKqUEBkEmJX7CSxAJnT+KG52mwBW1K+47HOEcMCIJkCePdn9AXwXzVvN+4Gq6TDdlheJ58PUpctwbq3cvxDiv63u3kqXeNRuOpDLg6NF++2Fw5odFp7gsiaCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSt+Pu4jp4HTh5s3fyvo/zwavoKA0tqqNX8BCNWb2go=; b=cJQR/jg4c/mqT5N5fTBF1LEwXIDOrVF0/Ws8biiLi5d9/UzZO3RRDLqnJaw3qpfu2Nudf1hu4FjftYy9vs5VAwVQ1BQwb5xWUq6J06UX4MRskeVNGRtQZvaQq2ORHCNxyq32IKmTciGtekCVLyb3iZIIU1EgL0g1ILqR5kbh4D9A0ctNeVkA+ky24q3KrZNEp0BBN0kAq2utOP9LIoTNNvUu04cQQLKWCla7F2ItdOyieYhI3Mla7IYIiqYXhR9SHq4afkULcSBzhjn3RG3/bg9ccKF8wuG9fJtjIOlH1Cx3+MfQWa0bqKroxqN/5bbmZFj9neGKj/KYceHeJm8IGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cSt+Pu4jp4HTh5s3fyvo/zwavoKA0tqqNX8BCNWb2go=; b=bD9h99M2vQqHgxpnEefeD2D/TOb603Vy/aXfcsXVb/2flQzfwaCSdklxRDRCXtpzU7w4FSxEN/1SAJHjR4OqBTjjcFXq02BeaWYSYKzxv2kyFFZyJA7TVENXd1BAD6KnUoxkgepao6woK0Opaj+NrdLaI6BT779zGlEWGD2egpk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jiamei Xie Subject: [PATCH v3 5/9] xen: decouple NUMA from ACPI in Kconfig Date: Wed, 11 May 2022 09:46:35 +0800 Message-ID: <20220511014639.197825-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 71c6684c-5dd5-42ec-347f-08da32f02c33 X-MS-TrafficTypeDiagnostic: AS8PR08MB7251:EE_|AM5EUR03FT013:EE_|VE1PR08MB5264:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f7qsmuAIAJZoOYhxrd3UhfQlQghtUZwF1/RvJlGmUp7xmzOX7vzceUYDSA9EoY4xsM9YPG7pPkRB3hjcfvI+bDvLd/Z+B7SFHIPyf8DCYrWiLBCNp+r22rbFrnWskGhhYQ92hVVsCkQyszzPKNdJNUE+pckd5f0yQ2Lwo+RGNOXNQ/ZKf6Y+giHK0R98+K1BzTMv1Ehn3CedFhd6Tz+feghHmhwF8/n7qZhd1W/P/neQFt/qayTlZRQEKUD2J1/4gGHl1IGR/1Ajp5wTi7c3ld8/IIbwrxH4NjA7p98zek4FU0pibKw8sL6fPrMlXiJDp0sdqAlZIUja2Oaoh5QoMfcKnSys9811D73tqW54lq0CychfQ1dYeWE7SZiwSQD16bdXWrUb7BtaQ39TM3j7n+cIjw3Rp+r2EInN+RpyLcZ1mZqMYi4S50ci+NT46JsdHYkxvPWKVHMJyIysQzcX3J9dPFRJWCEYls3a0THFg15xPTKRxJpkpN1wXb3FZFqj0SOgUts79LR3wKqiTFnCoOfYhyYd/dLW/jc2b2iUObWjR3csXBS77g8wY7N9GODeiFbRdmq80mfpFmJG8KJFEpKlBjtvGUyl9oP/RUDcErhSS7SWCT1ZK04arPNCwjvQ+a7P2361cOXu78gG6zdjp1X3zwKSCEcA/EQQMraVCNxkRQo6Gn0O7NJA2RKbHDKV7sRIQmT3z1yRMaF01/D2jg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(26005)(54906003)(7696005)(6916009)(5660300002)(6666004)(36756003)(8936002)(47076005)(336012)(426003)(186003)(2906002)(1076003)(44832011)(83380400001)(82310400005)(508600001)(36860700001)(86362001)(4326008)(70206006)(70586007)(316002)(2616005)(81166007)(8676002)(40460700003)(356005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7251 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4fdfb8e-723b-4365-5eb7-08da32f02729 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U346wT5spcNvTnCNkWKjwYy9V18tvjyoqtYRG8rOVswdTLoDEJOSIrxNA3EZSOF6p8b4IDdKVV98A9WihX/wnpNzP0ts41F4K9Ahf+1Ugw42tyvOmhOd58fNsqik1ppJelKw5adz30ipQiW75+n97URs2QW6kMcY9VyE95f6+lhmFcNVnS06+GvtYGecR93zsSaBXHMyCkP2/2mdmvgtvpszuIPAmlfos3ZmcLVau/qYFMrDGFQ/NDwXw/ZST1TgQ9EzbcHbyMSU7ktuEreDR6duVw1wo82SPTB15QEJfVT/UC1qjD19Uum5IZbjkFWnt9kW2hedG0w+2RjoVw+vfPoGWqJqKiZU2SXsNCGH71e3MbSkIdkwso9RFbvLdJNWrkfPfJc6u+7JDiZBRnBZVz4hBMC5ZcnSDkWDplQ6hMoAGML+Kk1QZlX5HVXmx/4nBO0xAfT2fgDoEVVpY+oRmc8Fa4yWYJIceW9Gb6Lbk2BIaMJgkErTAd/nQej/ZDns0AVRmq0EhKwWqEjcCV4sC+bgj9pK4wKZ6iKmgvVYCzJAUIUoX4Q2oev9Mbwg4YIdUPUaREc/g8NjmwMBsNRHWA/DsSZrvy/LOpQuPu3KdWpyV3JEy3emJ4Fvf3JlD5AQVU7awpgWjtlZVWPl6qGqzTct1b8u7k3TuNEy2TnUHSgr8OzsEs3Ga5Pe2bj/ySFn X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(2616005)(5660300002)(36860700001)(26005)(40460700003)(6916009)(82310400005)(36756003)(4326008)(8676002)(336012)(426003)(1076003)(47076005)(70206006)(186003)(316002)(70586007)(54906003)(508600001)(6666004)(86362001)(2906002)(7696005)(8936002)(81166007)(83380400001)(44832011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:14.0840 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71c6684c-5dd5-42ec-347f-08da32f02c33 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5264 In current Xen code only implements x86 ACPI-based NUMA support. So in Xen Kconfig system, NUMA equals to ACPI_NUMA. x86 selects NUMA by default, and CONFIG_ACPI_NUMA is hardcode in config.h. In a follow-up patch, we will introduce support for NUMA using the device tree. That means we will have two NUMA implementations, so in this patch we decouple NUMA from ACPI based NUMA in Kconfig. Make NUMA as a common feature, that device tree based NUMA also can select it. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Jan Beulich --- v2 -> v3: Add Tb. v1 -> v2: No change. --- xen/arch/x86/Kconfig | 2 +- xen/arch/x86/include/asm/config.h | 1 - xen/common/Kconfig | 3 +++ xen/drivers/acpi/Kconfig | 3 ++- xen/drivers/acpi/Makefile | 2 +- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 06d6fbc864..1e31edc99f 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -6,6 +6,7 @@ config X86 def_bool y select ACPI select ACPI_LEGACY_TABLES_LOOKUP + select ACPI_NUMA select ALTERNATIVE_CALL select ARCH_SUPPORTS_INT128 select CORE_PARKING @@ -26,7 +27,6 @@ config X86 select HAS_UBSAN select HAS_VPCI if HVM select NEEDS_LIBELF - select NUMA config ARCH_DEFCONFIG string diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/config.h index de20642524..07bcd15831 100644 --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -31,7 +31,6 @@ /* Intel P4 currently has largest cache line (L2 line size is 128 bytes). */ #define CONFIG_X86_L1_CACHE_SHIFT 7 -#define CONFIG_ACPI_NUMA 1 #define CONFIG_ACPI_SRAT 1 #define CONFIG_ACPI_CSTATE 1 diff --git a/xen/common/Kconfig b/xen/common/Kconfig index d921c74d61..d65add3fc6 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -70,6 +70,9 @@ config MEM_ACCESS config NEEDS_LIBELF bool +config NUMA + bool + config STATIC_MEMORY bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED depends on ARM diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig index b64d3731fb..e3f3d8f4b1 100644 --- a/xen/drivers/acpi/Kconfig +++ b/xen/drivers/acpi/Kconfig @@ -5,5 +5,6 @@ config ACPI config ACPI_LEGACY_TABLES_LOOKUP bool -config NUMA +config ACPI_NUMA bool + select NUMA diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile index 4f8e97228e..2fc5230253 100644 --- a/xen/drivers/acpi/Makefile +++ b/xen/drivers/acpi/Makefile @@ -3,7 +3,7 @@ obj-y += utilities/ obj-$(CONFIG_X86) += apei/ obj-bin-y += tables.init.o -obj-$(CONFIG_NUMA) += numa.o +obj-$(CONFIG_ACPI_NUMA) += numa.o obj-y += osl.o obj-$(CONFIG_HAS_CPUFREQ) += pmstat.o -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326070.548942 (Exim 4.92) (envelope-from ) id 1nobRk-0006Ao-77; Wed, 11 May 2022 01:47:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326070.548942; Wed, 11 May 2022 01:47:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRk-0006AO-1E; Wed, 11 May 2022 01:47:24 +0000 Received: by outflank-mailman (input) for mailman id 326070; Wed, 11 May 2022 01:47:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRj-0004GU-A7 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:23 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20619.outbound.protection.outlook.com [2a01:111:f400:fe1a::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c37f1e0-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:21 +0200 (CEST) Received: from AS9PR06CA0093.eurprd06.prod.outlook.com (2603:10a6:20b:465::22) by DB7PR08MB3338.eurprd08.prod.outlook.com (2603:10a6:5:1b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 01:47:18 +0000 Received: from VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:465:cafe::6e) by AS9PR06CA0093.outlook.office365.com (2603:10a6:20b:465::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT034.mail.protection.outlook.com (10.152.18.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 11 May 2022 01:47:16 +0000 Received: from e30a62ea6a80.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 812680A7-73AB-4567-BD49-9B4567C87BB6.1; Wed, 11 May 2022 01:47:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e30a62ea6a80.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:10 +0000 Received: from DB6PR07CA0199.eurprd07.prod.outlook.com (2603:10a6:6:42::29) by DB6PR0802MB2229.eurprd08.prod.outlook.com (2603:10a6:4:86::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 01:47:09 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::c7) by DB6PR07CA0199.outlook.office365.com (2603:10a6:6:42::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:08 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:08 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:13 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c37f1e0-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nFgckatpi8HMp7xL18QeFgsgCYfBzihroVPbCE7DKdw9fqcxWQ6Xdgw/fKqvbDIRwyYtBUfJPBnK+vSrqUVxPuVH24OF4GTUTeEFN3bH8aXM2lGspXlNON5Yxf/1UkcajhG95gWf4+jM32X/iWEZ4olD5hGEiz9UsR6zc8L6PXA3qtd6JTmMXMS3Y+9LBZMi2sE+T1Eo6mLlCxvtEIGlrISZfSgEl9W3ATOyLjeJ2oIlALRiMPl9fWSEt3igx3NdUwLMZpssjg5JwcqWimy+8H6EQ0yxjXittnV0wqJ0CNuCbKAsZdU6ocuw6ENugxcEyOMS5zlq+/AceHNvYobnkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3dvL/r4EM4eeNImD1eMM3sRpfk54sjZJGAM76OFEuNA=; b=i7tNrIAfqgIcwh9GHZoJucbWylmL3e41QzPzlg2jlW3RPTzeMcrepMAvbH2BUUCc7ateZQRLXauiCqH4zEQkET/pZ5RcT6zkHfZ0wB0BZ6ZrvWa+qlbaCgAm+SfXK1cX8th0mJOrXFAYN07LweDN16R2Orxa6eJpXx2ghDjxNZ1lHHf5bYBLoxuhXMqb9mryfzu6RUWWfhjZ/IEBmYSZv3mQICC9MAe2+Hc/BXHqEcgwtLj8L2ogJfIgQ5jvrTuwsIMF3UW0YQyshh8KwLwC901yWZ7wmWw5ClvvBBtVBRbT0QPUDSOS1AkM3yANK8UlB0OCkhEW8O1Fl/SgDdsRIw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dvL/r4EM4eeNImD1eMM3sRpfk54sjZJGAM76OFEuNA=; b=8fO1+7AhbcmeziHj2h7coAb4KGdZALo2cgG5MA1aTMwL7jxXFkMgHSgk3ZP4ziGIQf2WQtoJ/dZGucu1CfCxzaVhH24Kym+1ZRR89vVCgBzYVnI9yvvvpMwXRPIWSyp5FiTYrkunp3ixqOb6cJanb904wncJlh6pHAl9EPMIgzA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 9c5b5116c570484b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iZB08KEKptHywyDf63P/4lGE40rkdsszz8y1Jks4dw3Ztm3eBWTVZiD/+gN3VpfIqauRWalERUZYsW82yG9wv9M/PjOCE6Lj64pokGb5fYnmX0PjqxHKsmNtsGKDzjMOnsD+b2QW4f0JNu37KXys7rXtuykIj4h9TXHt/mmk9CD3x+riD8orqdRonqkVqnZMpUPVkkeR1FY+YOjLgY07mj4W2LKF7DFSpJ4pRh9QqBFuB+lac7rXps9ZGtRaAS3I9B//5bBqE7dEM9pOWpwLWHDrDYf5k4W+0kFJjxmTgSK0eGxPEtZi8GJkWX0nHhHJ9WDDTpBdwPCp9QQ7qh8ROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3dvL/r4EM4eeNImD1eMM3sRpfk54sjZJGAM76OFEuNA=; b=HCSU3SbIuo67Sc5xSvD/5ZoHrQd5pITodLJbZyO4wX1npDzRwcBkAxAVTVYoMJlTPXBgrKzJHiWkGsyQBUuoQAo77qG3KIrZUh3S9J1ATe3gslTe8BkmTnvv5i5vyJsN1c5Q5aoL/iQVrW5jODMHxfqNqxztO0CYZX9l8QkfM/ixdz4KFy/KkECT+O9O4MtUDhk5KMpDrBKfqFnrQYJd2U0WY8Kbvg3igYDa+ye9L8VlqVQcOXdf7GPbVg7VF7bKMgT8kflcuSyvWIDqR6Aoq9J5g66AxARC/PABuhE4OgRB3QhFBx9BcUVnp7taijtZQU77rSFk6u26NFL/KIgGgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dvL/r4EM4eeNImD1eMM3sRpfk54sjZJGAM76OFEuNA=; b=8fO1+7AhbcmeziHj2h7coAb4KGdZALo2cgG5MA1aTMwL7jxXFkMgHSgk3ZP4ziGIQf2WQtoJ/dZGucu1CfCxzaVhH24Kym+1ZRR89vVCgBzYVnI9yvvvpMwXRPIWSyp5FiTYrkunp3ixqOb6cJanb904wncJlh6pHAl9EPMIgzA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: [PATCH v3 6/9] xen/arm: use !CONFIG_NUMA to keep fake NUMA API Date: Wed, 11 May 2022 09:46:36 +0800 Message-ID: <20220511014639.197825-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: ce30710d-8e6e-498b-64e8-08da32f02e2b X-MS-TrafficTypeDiagnostic: DB6PR0802MB2229:EE_|VE1EUR03FT034:EE_|DB7PR08MB3338:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tnIEojpHqKnkd2FCZUzsobMG02OEaai8pYwKSJ8ewE2lwJzoJ98m0gZlOYhTNyDg9oPRdHQX6poOpelyi4hIGxPsif7zXHL1TvNeRip05kVGeg8+86jdlRcQjgvtx6St2b6uh1NZqsfeE6h8BaPwPMWUT5ogh/QC39MFRTbuWuVJxcqC42imwBVMiuIT+fjwt5me+/W62NUWIeaLFrhFth0gsxKKf8/3QtQ4NkDax2qDdKXL2+NHxZuUmfPAySj02kT0wJHC0ldxywjKzmjocHKkNVBPmAOavo+MS4KhWedKjj+k2KNKy37VeKsw+35FaxmOldE0RRCfpNsibGJiPF1y28Q34kBWvONA/hRg44Xo0EpT5o7DMcV5zBLRZdXn8Ya+2GYMHz8PCwVOiQNh4hzsyNHHg3YDEupGAmvMDAH7Gnv2cON2x6yJwNg3C/JEOFxHmoG5inAx/tgTMPNetTedKdYECL8o+uES5MLRjVRlpPrAYaxzAQXwgSCmUWpp+s6811Pc1JnayKMer1R3Xt11eXyXFlKN2etaYmWLg4gSeOxBmDwQDk0aPpfgnjp7j94NlRC07QDXmcu28TrTXjapBzH8B098dEQB0Ktbklc0qk/Lm3P53miPGXwPPE5CvWTepVBb32DY7fzkgGrDJZlD3u+zWE8Y8BPZKq1MkCE8nPUnHc43/gQPR37Qb9+DwJhX2pkWwC3xd1eSGF+zZA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(70206006)(70586007)(2906002)(36860700001)(508600001)(36756003)(86362001)(316002)(44832011)(8676002)(4326008)(336012)(83380400001)(356005)(81166007)(426003)(40460700003)(26005)(5660300002)(8936002)(1076003)(186003)(2616005)(82310400005)(47076005)(7696005)(6916009)(54906003)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2229 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6492d488-f4b9-461a-a3ac-08da32f028e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VUHHToToUjcAPCACIRCM4CJCqOSDNTn2ZOXW4TDjgvQyKa17CDFDOs63cdA8r3Vlc7TKAGg05Yep/w0YhQc6CAeuyNLKQ1RlJ+yd5nQbDMnhLk80i0mdhKJlQcf3DqrKRMDjzm6EarCrq49iWOyTKoNqzj3ssatj91PvcDOK1gi0D0sQtVKvm+XXTFsfcHbgeAQHO2qjXbOJ1g+gUuhyAXAxpLEEzi+OtRQVBJBobAphGz4S699rfC14rqSPkvfxXJ4ITQvRaF5tiSvVXSplvKJcS7EZCIdfSQbeVC4elqSEWfq210rhSVdZ4rzr0+muJkNMb1vf/sVKsE+LpFEWcKHE9OWEnXuTMxQ+jl41iHErA/Kj8xIJz9Kl8S7b+PDCKHLLc+bmN6XtCYUwd41q1LHvw8vcp4c0iVZP3a+W+iPpPoqwxwI63ZQ33W9gJ0flRICignEZTza3ltXQDGKTOIda9hfZo7FuYrfi6l4oeUSAAjuOr+F0ewE9ZP/d6JBA86pgyQNa6b/Ne9NVxgx+X2/JAj7e2V/NfxsyyqQo5ENn+tCAQVB4A6YhrezJb9uzuGjMbJ+vHZdlWRwbI3wxTv5gGxody61FgRf0PdsioWXNe8M838KOdnNnVAac3XG2rQHEX8ztaqK8mcXFU2F28Oo/wr/XrLC7o/ONSH30qO6vUx/NsVMXWekJdklMLkVK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(86362001)(8936002)(26005)(70206006)(4326008)(8676002)(81166007)(70586007)(5660300002)(44832011)(508600001)(7696005)(2906002)(1076003)(6916009)(36860700001)(6666004)(2616005)(54906003)(316002)(36756003)(336012)(40460700003)(82310400005)(426003)(186003)(47076005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:17.3388 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce30710d-8e6e-498b-64e8-08da32f02e2b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3338 We have introduced CONFIG_NUMA in a previous patch. And this option is enabled only on x86 at the current stage. In a follow up patch, we will enable this option for Arm. But we still want users to be able to disable the CONFIG_NUMA via Kconfig. In this case, keep the fake NUMA API, will make Arm code still able to work with NUMA aware memory allocation and scheduler. Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Stefano Stabellini --- v2 -> v3: Add Tb. v1 -> v2: No change. --- xen/arch/arm/include/asm/numa.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index e4c4d89192..268a9db055 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -5,6 +5,8 @@ typedef u8 nodeid_t; +#ifndef CONFIG_NUMA + /* Fake one node for now. See also node_online_map. */ #define cpu_to_node(cpu) 0 #define node_to_cpumask(node) (cpu_online_map) @@ -24,6 +26,9 @@ extern mfn_t first_valid_mfn; #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) #define __node_distance(a, b) (20) + +#endif + #define arch_want_default_dmazone() (false) #endif /* __ARCH_ARM_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326079.548953 (Exim 4.92) (envelope-from ) id 1nobRr-0006yp-IE; Wed, 11 May 2022 01:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326079.548953; Wed, 11 May 2022 01:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRr-0006yZ-Cc; Wed, 11 May 2022 01:47:31 +0000 Received: by outflank-mailman (input) for mailman id 326079; Wed, 11 May 2022 01:47:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRp-0004GM-EM for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:29 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0619.outbound.protection.outlook.com [2a01:111:f400:fe05::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4fdcd618-d0cc-11ec-a406-831a346695d4; Wed, 11 May 2022 03:47:27 +0200 (CEST) Received: from DB6PR07CA0092.eurprd07.prod.outlook.com (2603:10a6:6:2b::30) by VE1PR08MB5789.eurprd08.prod.outlook.com (2603:10a6:800:1b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 01:47:26 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::2f) by DB6PR07CA0092.outlook.office365.com (2603:10a6:6:2b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:25 +0000 Received: ("Tessian outbound 9613c00560a5:v118"); Wed, 11 May 2022 01:47:25 +0000 Received: from 1f39ac0c3d01.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79AF10E0-9FCA-40AD-8ABD-7DE9D9EA84FD.1; Wed, 11 May 2022 01:47:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1f39ac0c3d01.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:19 +0000 Received: from AS9PR06CA0370.eurprd06.prod.outlook.com (2603:10a6:20b:460::15) by AM6PR08MB4024.eurprd08.prod.outlook.com (2603:10a6:20b:a5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 01:47:17 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::ce) by AS9PR06CA0370.outlook.office365.com (2603:10a6:20b:460::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:22 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Wed, 11 May 2022 01:47:15 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fdcd618-d0cc-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HM2OipmOnCOjWgMMQgGYgpmgHNlejHWELKxbOPQIrqsFPytkU8/K4Aw2LWUhF619CDMYTqRBQ2kVzDoDRzPmyJ8Z1uV684MWN0RxJuvvP4tboLL7bJqttyogYhqA3jyZNPA/RrXaiF+Mm8a3FCE1uibtkk6C62n8W+TUAnskJIvLcqdUX5KQesssMNV4aD/CLAk2TDmZA3EyLS4vIKkcnThjv1Q7kIv21/CGQoHaS0R1LAG+ilgdwCjz1no7aRyh+GPR7+I5fzwvaYn6s9DLrQbgh+tPIO8J2xwdFUOixurtvKsAzzzYPrrA6MeoGLA3LkmodaTn3HCACGnj6F1ycQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=Xcr6ihUznxNw4Aw+EBSRCsED2Bj6f/x0IZQBsT3j4KKBecghVu8Hc+6aZWU1d2eHqqKYu4M5jYmXNydSBvBT5defpjZ6kz2BX9vobfRjwIX+M34q46zeiTmjRhu+QSXeENy9rdskhowLfBw0qblLQDA1Glrym50ApSlyK4oLc4HrZDfuB2u0QAG+pMYLWCM5h/LNQToxsFMhUNmt0eNttvGPhTO4hexMmXmqYeaZHeC9+2zJ1hL2kao6u0RPcJWGiaGa9hB2qsE+vwefe+4yTbGMTdZbXZWJ0dFLlvWOyK4xpe2TaC03okDfqsMrE8GN/hxTZj1IxFKZH3hJcaWY8w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=fHoe/tNqJo+WMZN8TFvPu5fZTN5EddyAXd9ChsG+7cFqlhJDVkkSzUkjqZiIU9aLNZTWqFfIpLlH8BddXzzZv3Wm1D6yDaX+/F01RTzWEsh2UpaVcg5YxJi4wfjTFvO//LVlfWLvhjhfGzupIzi4DaYQvIktwJbawAQGcxL9VW8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 18ade7002c5dfb26 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ITV/SBZAa0kO5Ir92jUDuHJ29d9psI8uS/+PEHB+r3GznLByAGhc6YpOOSccxVCl7DEQXautzRyREtMWffQKal8/tkWdQsDbRjx3YTA+mEjJED3h531kL6i/xOzs1/DM90BW3BAmeDgKrSCcjq9BgMOWaJXIOlW14yjXf9/22agTOYn+8HggT80L44/r3Nh4CbIOUu5Xvd8TEi53IGHAGT0AWd5cd6J+Cz3TUH0uK4B5O9V55+dtazyfdSM736aOhufwO34xbZXrswJnnsxXWr8FTFpg15bJAerqLAj19zGMWDFmf9gyXhBmKgE3BxnNZfgIDPoZX5BBgw85xz1cYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=NFgIgtxBZsjucXbcFGT+2AZ8sdIn8s64/10GhuOPziZMa9qoZJM5hpA0bV+9KLi+PII91QORwJeAiSLhHtBS9REy7BwIsly/kNujmqgO6mN1xfI3uOYaETm9oAVgqGReSBj6yjY6Sx3GsLoX+5qCg6xtZhb+CexEJoVqD0C/ngvgR93hgun/737ZFeA83BQVx76XCmsZz4ZAbbqF1IOEF1W18ufcIoNxiE4n7MKHJp46ajCvJ4ejMp/qr8gMID6NASus9xdt58KAzBzcR6yyil03QEI6c3PJOIo0BQSugED7LBD/QGSnGETlxS3e6KMWQZdEHfzMpx9xdVKkw4llVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=fHoe/tNqJo+WMZN8TFvPu5fZTN5EddyAXd9ChsG+7cFqlhJDVkkSzUkjqZiIU9aLNZTWqFfIpLlH8BddXzzZv3Wm1D6yDaX+/F01RTzWEsh2UpaVcg5YxJi4wfjTFvO//LVlfWLvhjhfGzupIzi4DaYQvIktwJbawAQGcxL9VW8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message Date: Wed, 11 May 2022 09:46:39 +0800 Message-ID: <20220511014639.197825-10-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 60aed4b5-6aab-4520-06ff-08da32f03312 X-MS-TrafficTypeDiagnostic: AM6PR08MB4024:EE_|DBAEUR03FT026:EE_|VE1PR08MB5789:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WjKq0H9vl9a1XgZI0TXbwApillIFwrzIinHvLkt6LCmyKhdEqMpg0y9bEfsRh25JSDOdtPvj0jNukvE1Ht2m/vhwSEmoLfx2sD9tYuyh1FBxSHJlb396smxaFLN4BEg2zi4PFim4LvMm6ugL3WUlb9vUa6C3oBv/zKjwndfXXaTbgAJQWv9l9/rUw0KRA3WbHhwP6/1yWdzlq+JXuhkF0f8xk0mDQEJANbb8C2qrVwpC6sIVW/j9MNLT7D5hWSlFuDKtZttOGdHiv/W3PLj9f0AFfA92E64BE6enBcXLyrKGOOZE+ckyvra8/4nP+baN7jR4YcNffqWdCBzuHMPgRcFcKoqtx8bUaXHdW7Sk6RCAPfzxQTrjCxWR5OU4hHvsos+oEk+uY4WNDsvkkPO01Estj3V6qyMuOnHR7tXiGYcsg8mZINlnxYux3yf4Hc8k7tVCn79W498PD+o77lZnJcoeaJVzQMYctg/oxN7NYCWmUhyWznwbzD0eOttoFdxwthFifYeLaocpLeYRq2s+V5Ho7Sc0jz7dTGfFzFqytvrSn+s5S1zH3iuIKhNDg5S6D20+/F2jeJu5qOJhch8wqqfn7TD+ApqbAoAj233t9APip1/zco/Rc6Wvhguty7Fc8+o0UhuaTOde8UXXhcEti+74yYtbmDCrZ3nY5EXudJkC7qMb3w7ov1q3RCD9UlattBf8rjk0sK5y5zPzaBRE2Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(508600001)(81166007)(40460700003)(8676002)(356005)(70586007)(86362001)(4326008)(70206006)(316002)(2616005)(26005)(54906003)(6916009)(5660300002)(6666004)(7696005)(426003)(15650500001)(186003)(2906002)(47076005)(336012)(83380400001)(1076003)(44832011)(82310400005)(36756003)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4024 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3b135ac5-1ca6-43e6-5607-08da32f02e4e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YpvhhI6MGYAiRnuSma01PmyUj6hiSq93df6Vi9NdSj/z3WE33Tiu6MMFw5tVW8aUTpyhLX4mDH5grCUCaZ465gihZck50szHyspplFzABZbn0P2onV//MG/JllK0WS4/Y/4Cc0iXq5weGUuwhANH5NiB9Mw/sQGdOpjY+ekDkLZRTVlm8MbTeFonghhqG4TwRECkMY4kjS/atfhyouGW5U+IhXq+jqfD4+t2AHxh2+ZqP/2vi5fuZ1IIHssHuUjiK+1SsuZqGfA1z9AJw9g4ZTUhO6rTTGhkVLSlq4jSv6S+45s57aq6waPc9vPfU5EzIqF3iw05neMCFxvnG5lLZB4gXa5RP4VWY/7BPjJEX7tGUZFCYwzl+nmE2TRybh1UvLyRCLSEK3oNPDodjCMYFZDMad+cAVPKuGdU7KiexoEJG52+xpcHrmQrYs5G1ycq8m3XWrcbb6d8n3HzyTGTL0uglL1FQWm7ynemLqFqgCLdaC2oBYyf/hf9wllWpxhUOAs5+Ltw8WqpUHTwnQ7V3vmBASmhmPEsKTVf50xIzBurTDPWb0iCEbA/wa5WYroV9iCxrtZid2IZS73yYQ/3JuyTPgiuSvXN5juW3xPQD46XsLdeG9hkmQCF6sFXtMl0Pt8fhUdXUPxSFplWQeJzaxEUQaKvR5DbS4uBggpS/bYSBXLeI/aaR5h46lJzYZ1+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(508600001)(15650500001)(1076003)(83380400001)(4326008)(6916009)(36860700001)(54906003)(336012)(316002)(426003)(186003)(8936002)(8676002)(6666004)(7696005)(36756003)(82310400005)(2906002)(81166007)(26005)(44832011)(70586007)(70206006)(2616005)(5660300002)(40460700003)(86362001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:25.6549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60aed4b5-6aab-4520-06ff-08da32f03312 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5789 In previous code, Xen was using KERN_WARNING for log message when Xen found a node without memory. Xen will print this warning message, and said that this may be an BIOS Bug or mis-configured hardware. But actually, this warning is bogus, because in an NUMA setting, nodes can only have processors, and with 0 bytes memory. So it is unreasonable to warn about BIOS or hardware corruption based on the detection of node with 0 bytes memory. So in this patch, we remove the warning messages, but just keep an info message to info users that there is one or more nodes with 0 bytes memory in the system. Signed-off-by: Wei Chen --- v2 -> v3: new commit. --- xen/arch/x86/srat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 53835ae3eb..acaebad2a2 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) uint64_t size = nodes[i].end - nodes[i].start; if ( size == 0 ) - printk(KERN_WARNING "SRAT: Node %u has no memory. " - "BIOS Bug or mis-configured hardware?\n", i); + printk(KERN_INFO "SRAT: Node %u has no memory.\n", i); setup_node_bootmem(i, nodes[i].start, nodes[i].end); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:47:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:47:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326081.548962 (Exim 4.92) (envelope-from ) id 1nobRs-0007Nk-UN; Wed, 11 May 2022 01:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326081.548962; Wed, 11 May 2022 01:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRs-0007Mi-P3; Wed, 11 May 2022 01:47:32 +0000 Received: by outflank-mailman (input) for mailman id 326081; Wed, 11 May 2022 01:47:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRq-0004GM-PB for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:31 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0627.outbound.protection.outlook.com [2a01:111:f400:fe05::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50fedb6d-d0cc-11ec-a406-831a346695d4; Wed, 11 May 2022 03:47:29 +0200 (CEST) Received: from AM6P191CA0099.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::40) by DB9PR08MB6571.eurprd08.prod.outlook.com (2603:10a6:10:25b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 01:47:27 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::e2) by AM6P191CA0099.outlook.office365.com (2603:10a6:209:8a::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:26 +0000 Received: ("Tessian outbound ac9bb5dd84f6:v118"); Wed, 11 May 2022 01:47:26 +0000 Received: from 68f414d756f5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25623349-8630-422B-A945-4B0CB7E35660.1; Wed, 11 May 2022 01:47:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 68f414d756f5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:20 +0000 Received: from DB6P193CA0013.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::23) by DB7PR08MB3355.eurprd08.prod.outlook.com (2603:10a6:5:18::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 01:47:18 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::9e) by DB6P193CA0013.outlook.office365.com (2603:10a6:6:29::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Wed, 11 May 2022 01:47:18 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:18 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:19 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50fedb6d-d0cc-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oV5j7ZYIkeRVvk11DYaw0fTklNgsogFNxhOf4/XHTIn5JzS7593K5t6thKKqowa4OVmJkuFTZwRA5rEFaLtZrFpXasgrDlwAHw26zodjoRMLhVu6/UjylJwAts+pNE1JZ+/rckJgyaoh9RWCtyI3Vy+Fkm3UJIDg+OkW+GAasg2m/Xex/hCC+CHJV4y2bTa9QYMzycrV0+Rvb+pyJAGOip3RTUmFtd9Lk+Az1IVZJRmNqhc8r+bKr+zWZ9Pe9yj2oaOYU/Of339TbPUkofOxbeoc5COkA/5A4Q2XJh8tNh1+Gx/PFVKPD1RRvGJshP6R8vuNBbNOATeZF7Hq2nWPmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oq8z5BQ/mKL1DPmKTInyHTA5bNRXdCnGU2Y2WkTA6Sw=; b=A52DrO1Xik5qegCDhLqoKbjtKBW1/th3zYhH/ucVY3VOAhw97aLFbOWHGVfTSyb0UZl1un3uhUJCIzTUE7XY6TzYVwSa3ORcdJusPKXynS/04IwRRW4TC/o6Y1xagZD8d/DvI2RjDEznk6Ofyr2RIVHziHtk5aTIAIITXCf3azafd/tx4NhW/5FbyOCFozAPk6y6q6kwrbccx8GlG6l3Fm8mKp3iccqWBeM/TbVhytUHymfgQ39DOCBm1+UdS8hFKJQ7GWxoaUzHqECEs0IOlyU4eLV56tZ1mnrs2MCuQogTYeiH3bEnANULm/HqAtujETotlsvUwjXlr7ZVYm+H1A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oq8z5BQ/mKL1DPmKTInyHTA5bNRXdCnGU2Y2WkTA6Sw=; b=ElnQyV4vg23T9YU3nZsm2v5RYFcP/3Drs9nUuf2YLopcnUcRw14nWjeX9fj+1euIGuEPlOcjPjPtNLfMjGN2fch00mmzwjuMajuCa97beRLgbyIk6Q1TYNN+wSU5v3sfS3USlsvFunoEo3xaW1oCBNrBwnztx37dVOEowyyWB9U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a0f21928d7e6863 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDzO566/WTtwdBvlANSZRebPv1+1MfOEznij5Cl4ycuMWMyRbzMjBvRN4O90ETdSXNJ68u0g5X5HSS3PnMYAZ23HlfbBCxX8W1d2VvZPWR2GPIODqFZ8PNIFFn0AOO6Ckbtw6W9x/xO9w0idMeqcf1BYDFZyWID3pn7KnSHKUJ/sVc1XKpquo7RYXpCayEzpkgZvuiUIY8hCmUwraM5uN0jRBJX5NHJs5aXOTUbleZrOoXBqwnvAwxunSII5+571lDV3EWdn+UjQij+1Q6PAd5LzqwAFfP+WL3DfegeLYoMJtloZlkD2SVTre+j5zmNHld/qKwnacHUIxqoeGEGHXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oq8z5BQ/mKL1DPmKTInyHTA5bNRXdCnGU2Y2WkTA6Sw=; b=T6vbOtBaH+T/afHD6LUTkz8eqjfW7npbPT81mya+l/dG/RFIN7p063+bbokB2eEedyEnpQk4vDohIIjxWXoZ/pcy7Eua5/C133skTn/IgAYnniO9EKILP2GG7UQvPXq6sHw255pI/wg4uCj5qipvlu1vEIbxwGWBhSdjot5VWVf+rO8D+E/1QtWr440tgMFa+xwx8JqXMVOq5faAcBx++Vax4bFqW7NGnQ2MR+oUAaw5UCOCG3wvngtxUckWq+I8E4u9cUp1DLNzwPJMs5Y3Q9pPOoNyEINWROabQSVNgx9hihBmY940TWT5JdEw3fIENs3zO5kSNUcBTzxN03RgCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oq8z5BQ/mKL1DPmKTInyHTA5bNRXdCnGU2Y2WkTA6Sw=; b=ElnQyV4vg23T9YU3nZsm2v5RYFcP/3Drs9nUuf2YLopcnUcRw14nWjeX9fj+1euIGuEPlOcjPjPtNLfMjGN2fch00mmzwjuMajuCa97beRLgbyIk6Q1TYNN+wSU5v3sfS3USlsvFunoEo3xaW1oCBNrBwnztx37dVOEowyyWB9U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v3 8/9] xen/x86: add detection of memory interleaves for different nodes Date: Wed, 11 May 2022 09:46:38 +0800 Message-ID: <20220511014639.197825-9-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 1ffc81a7-0d17-4762-f01f-08da32f033c6 X-MS-TrafficTypeDiagnostic: DB7PR08MB3355:EE_|VE1EUR03FT051:EE_|DB9PR08MB6571:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6S1QDcss7gzOhkrE9xVM1G4YAPn5IUfjvFr7g9pUbNXFL7B7XVjJIR41fOL3odLJGtu9Mi1jaOD2S26jLmht++LOFb6hEkMyohUGqBgQctaizEN+tsMW/nJG1Ep1/s0SqA1+XQnxNpEgo1JTSym2E4e7wD9XSepnHIrAHS0REWM9rj3GWvOcoxPni0lcnFuR5TeMXdPT9AwhQc4DWOgAueFp4bAvLnsfRlC8ue+KvfP43+CLbSpbAN9QVrZXC6+K7+mY5tiwSL2niXdwoxOG9Ek/JMg4WgEro59sCSPeXLTgqAchcOrkZXoyOjTZH3VqbDsatlUDPPCMKj2zDaPc44bmxxoN3eX/z3IrM9dW+2cVVz8ZLHTMahOSMy79fFwoAU4OcyBXRX1x1Ncto1Ub3NyVUeNQRwcstrIIn0PwpFeWJNtDTV/7scJ3ZaHleLhLo+gm6QWflTM+9f7EhYr3RhOhqy5kpk7mV9TovuJiAM1DVWRLdHuTc8ttJNEb1xXepJmkNGMOXHQvYR5iiUOU+sxoyX9APvoxzCFsseNY7sZqI7G3AokVAZuykyQnYqSQquYkpZHQD2w5Re7xMr6e8FAtR4n8ux96UDNfWOM8BS4V0vgAOOGrVO239iF732EGvrZv51jsiGrRFfW9KT9z0tHcCmpu3/0zCeAnkTS8/S4JThpFwDVG8eNrYXKmsCGj6A0ZiZUJvtsiYVvVMhXqVw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(82310400005)(1076003)(2906002)(36860700001)(36756003)(8936002)(5660300002)(44832011)(8676002)(70206006)(4326008)(70586007)(186003)(6916009)(83380400001)(54906003)(86362001)(40460700003)(2616005)(26005)(336012)(7696005)(47076005)(6666004)(426003)(81166007)(316002)(356005)(508600001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3355 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 31acf92d-5c68-4993-663f-08da32f02ed5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bCcgO4B++ppF3FpvhMCbK2IRMrBeznYvWUHNzHPSgRkNoxgxP9EMZMoe98Po0G1OdWVVf/v2M35pIqnqTGL563MUIqHMumi6+VbAEHQxqlDLmAO6un7YNtlNPpi2kxfS342/dbryvO+5ue1ML+cd9U0+Y9ba/x1FWixeonTmwDOWu2nUMLg9Tt6/YskrBGVwUXuSaj0/yb1lhnisaMO3cBNPCDCBlGgBauZfnWhV0P650YzgoVHvHFfH8haJmjxOQpYV8tZTZ7B5YftOsX78LNarG/3lztTa+nsweELvXPBJDLPttYTOW5mJJsOSkdP4xtKQithzHlbURHCHdVATm8jF9NS3RkFB22nTcsFq2nC1DEt7TGqzdBxihYeB8CT4n6DlscrxUSH0r1im86QxaCQn4OYFt7rohZYrBA0iQ6O9cdgRfSzlrX5H2RZL+/XdsqC3MOc80skG7keRyYPq4vap9qpLxJAAfQ/DCzaFvToXHk9a8TUcb2BR2fF3MLrqWtY5K34QtLGp2DSH+RhljMgfmDMs58Z0Qy7wBNUItQTwCJzgfrwpBqsR3zeA3p5vN1efp8ZKZISf56hIzk/4APFjMoKynJg722FFnq7Q7vSlBAHI1NDxVmlaMsExgTDSoz8DG+qIhd2gyiAL8AYom+D2DeNWowoUMsRMz1uZUyu6+f0ff0VAN/AGFBJey9aa X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(81166007)(83380400001)(336012)(426003)(47076005)(82310400005)(2616005)(1076003)(6666004)(7696005)(6916009)(54906003)(186003)(40460700003)(8936002)(5660300002)(26005)(36860700001)(70206006)(70586007)(2906002)(316002)(8676002)(4326008)(44832011)(36756003)(508600001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:26.7624 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ffc81a7-0d17-4762-f01f-08da32f033c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6571 One NUMA node may contain several memory blocks. In current Xen code, Xen will maintain a node memory range for each node to cover all its memory blocks. But here comes the problem, in the gap of one node's two memory blocks, if there are some memory blocks don't belong to this node (remote memory blocks). This node's memory range will be expanded to cover these remote memory blocks. One node's memory range contains other nodes' memory, this is obviously not very reasonable. This means current NUMA code only can support node has no interleaved memory blocks. However, on a physical machine, the addresses of multiple nodes can be interleaved. So in this patch, we add code to detect memory interleaves of different nodes. NUMA initialization will be failed and error messages will be printed when Xen detect such hardware configuration. Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v2 -> v3: 1. Merge the check code from a separate function to conflicting_memblks. This will reduce the loop times of node memory blocks. 2. Use an enumeration to indicate conflict check status. 3. Use a pointer to get conflict memory block id. v1 -> v2: 1. Update the description to say we're after is no memory interleaves of different nodes. 2. Only update node range when it passes the interleave check. 3. Don't use full upper-case for "node". --- xen/arch/x86/srat.c | 115 +++++++++++++++++++++++++++++++++----------- 1 file changed, 86 insertions(+), 29 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 8ffe43bdfe..53835ae3eb 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -42,6 +42,12 @@ static struct node node_memblk_range[NR_NODE_MEMBLKS]; static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); +enum conflicts { + NO_CONFLICT = 0, + ERR_OVERLAP, + ERR_INTERLEAVE, +}; + static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -119,20 +125,43 @@ int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) return 0; } -static __init int conflicting_memblks(paddr_t start, paddr_t end) +static enum conflicts __init +conflicting_memblks(nodeid_t nid, paddr_t start, paddr_t end, + paddr_t nd_start, paddr_t nd_end, int *mblkid) { int i; + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ for (i = 0; i < num_node_memblks; i++) { struct node *nd = &node_memblk_range[i]; + *mblkid = i; + + /* Skip 0 bytes node memory block. */ if (nd->start == nd->end) continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. + */ if (nd->end > start && nd->start < end) - return i; + return ERR_OVERLAP; if (nd->end == end && nd->start == start) - return i; + return ERR_OVERLAP; + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if (nid != memblk_nodeid[i] && + (nd_start < nd->start && nd->end < nd_end)) + return ERR_INTERLEAVE; } - return -1; + + return NO_CONFLICT; } static __init void cutoff_node(int i, paddr_t start, paddr_t end) @@ -275,6 +304,9 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { + enum conflicts status; + struct node *nd; + paddr_t nd_start, nd_end; paddr_t start, end; unsigned pxm; nodeid_t node; @@ -310,42 +342,67 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) bad_srat(); return; } + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expandsion. + */ + nd_start = start; + nd_end = end; + nd = &nodes[node]; + if (nd->start != nd->end) { + if (nd_start > nd->start) + nd_start = nd->start; + + if (nd_end < end) + nd_end = nd->end; + } + /* It is fine to add this area to the nodes data it will be used later*/ - i = conflicting_memblks(start, end); - if (i < 0) - /* everything fine */; - else if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, - node_memblk_range[i].start, node_memblk_range[i].end); - if (mismatch) { + status = conflicting_memblks(node, start, end, nd_start, nd_end, &i); + if (status == ERR_OVERLAP) { + if (memblk_nodeid[i] == node) { + bool mismatch = !(ma->flags & + ACPI_SRAT_MEM_HOT_PLUGGABLE) != + !test_bit(i, memblk_hotplug); + + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, + end, node_memblk_range[i].start, + node_memblk_range[i].end); + if (mismatch) { + bad_srat(); + return; + } + } else { + printk(KERN_ERR + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", + pxm, start, end, node_to_pxm(memblk_nodeid[i]), + node_memblk_range[i].start, + node_memblk_range[i].end); bad_srat(); return; } - } else { + } else if (status == ERR_INTERLEAVE) { printk(KERN_ERR - "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", - pxm, start, end, node_to_pxm(memblk_nodeid[i]), + "SRAT： Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves with node %u memblk (%"PRIpaddr"-%"PRIpaddr")\n", + node, nd_start, nd_end, memblk_nodeid[i], node_memblk_range[i].start, node_memblk_range[i].end); bad_srat(); return; } - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - struct node *nd = &nodes[node]; - if (!node_test_and_set(node, memory_nodes_parsed)) { - nd->start = start; - nd->end = end; - } else { - if (start < nd->start) - nd->start = start; - if (nd->end < end) - nd->end = end; - } + if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; } + printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n", node, pxm, start, end, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 01:51:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 01:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326112.548975 (Exim 4.92) (envelope-from ) id 1nobW0-0002GT-VI; Wed, 11 May 2022 01:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326112.548975; Wed, 11 May 2022 01:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobW0-0002GM-SX; Wed, 11 May 2022 01:51:48 +0000 Received: by outflank-mailman (input) for mailman id 326112; Wed, 11 May 2022 01:51:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobRs-0004GU-Rl for xen-devel@lists.xenproject.org; Wed, 11 May 2022 01:47:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7e1b::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 521906e1-d0cc-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 03:47:31 +0200 (CEST) Received: from AS9PR06CA0501.eurprd06.prod.outlook.com (2603:10a6:20b:49b::26) by GV1PR08MB7314.eurprd08.prod.outlook.com (2603:10a6:150:1d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 11 May 2022 01:47:28 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::82) by AS9PR06CA0501.outlook.office365.com (2603:10a6:20b:49b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Wed, 11 May 2022 01:47:27 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 11 May 2022 01:47:27 +0000 Received: from 749541d7139f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FABBF10E-55D3-4F8A-8A87-C0BB700317B8.1; Wed, 11 May 2022 01:47:20 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 749541d7139f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 01:47:20 +0000 Received: from DB6P193CA0013.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::23) by DB6PR08MB2662.eurprd08.prod.outlook.com (2603:10a6:6:24::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 01:47:17 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::9e) by DB6P193CA0013.outlook.office365.com (2603:10a6:6:29::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 01:47:17 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Wed, 11 May 2022 01:47:16 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Wed, 11 May 2022 01:47:10 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Wed, 11 May 2022 01:47:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 521906e1-d0cc-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h5xSsNM05uMwB3KRehpnBF3So183PuROCswDTndfEwToVMdpMaxsdh9XShVr3N4bkfM8j7//hTiQ0SWk8Ss/o5PYlmbU+nf7t1+EDrFZ6HTfAA0yrsrP43N8osGb+kskFAa+CsqX2wBNwsQrdOGEtrfAiIaada0zOpIdSwdZ75VZBpOA5pL6HNa14OMl9vok8dJiUJFQjYTnbRTDYbnbOpIkSgBMY8EC+7g7ujuOL4fbQ1uEmqkiEgcR47cvBsvLx0PEHEvoo2SNsSq7mcmrzGtsnAd27Rquo+yDw4cn6kkc50UiykIKJ0GiJ7QqrkWajtyHAI4RbChjme/5DhPjvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mklnp+4UtmYQx528gAiVFaums7OmdZxaBTqLvOripTs=; b=JmzMKZaeA7ohgMyzbIlL0Y9jojTDoFiWsPA9BUPv0s0QVpda7uhfZs9igNvgjFnoU/gdeazBfPmj6c/tHbcqmNKvaIblFAN0/KMB9BXcRhNL4NkFDAxmjM9azGfFjq57kDWeQ8Rq6M4DbDUg0VZ0pJsHGAP8ycLAPDgtnMzbh4lWKzFPJVCR6fNRDhNK+qTKcoVNgdFtlph/wlOFniv1B8yh1PlQS6rjGq3Fn5TG+4AWNHxioV3UvMScSZIUsxOwg7KJM4Kg/FbrUS/QCaDkihS8bmiOWHyN6CH+MyUV41Kd2CrvS+G/zNqAATJhJjNDkodNfNH/qGa49KYfXdE/Qw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mklnp+4UtmYQx528gAiVFaums7OmdZxaBTqLvOripTs=; b=KzqdToHFwvMUNqZgWE3UybW3XORlErehdoHPKJtJHA+x7H5R3hnNU2MT8PsYPYJ9LCsYsE5veamIpj5TRWcMMNAqAbv2T7NeTLGsVhce/x+QhDbye/7ht45wsIsIGJFJzUPgi0jAgWYsZnbngVzTt/9Z/ZT5L/dqaaeI0KpkIc0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: d8952d7c08438901 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dek1BgrnCa8Gxri9WobzMBIEOuDHykaX24N6XzvL2XCFXeC3/0SoW3XJSNMGhwdkUMMJi+sQJUrLm1CfC1PAEIHuU42sY58LpuL9PLcof38/o8tQpWUtc/RnrYqXZsOpgvipuaAi6H4b7nWpCstcBTU4mUXDQXvJwdzvy1NlEeoZ2eJhCQCWoeyg2GznPNvgeBDH2S+F8Twl00nPfFe2IBWTRO+t5sYefLVse6Hxd+k4EVErfZQewJYG0Pc/hner610qF7LAHGRDA3xbnQ8y5iVjiyuQClYyeMorsSLuMyou5uq9Yjfkwxgn8HjLYiC9aWgmP2TX4sTkD/ANvyTm8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mklnp+4UtmYQx528gAiVFaums7OmdZxaBTqLvOripTs=; b=cGNixLu9h7hx51QEawccKOoOA6uXb2ZrLa+TN3g2z4x8Jm1hmTyZUloilV4LjKz+fn47wWoRkL8JuNz2KpEdguSiwl1ENlTIqreLE/CrHYRoP4vMUOWftKTrk/99k/Zrm7h+CSGdiiP+m9z10kGbZuMsWtZixi1lv6a7a+qei051y/E6IjbF5nIkf07oYQh3w/crcomWkFjAELRpmCsE8JcuVWGgZxj+7Y2ZBhTMpVyfiJx3WNXSNY8uilIqgJvnmaBgqS0J7nA0YuVLA+f2FRm30kVyaD/k9sV6X3VBH2qDs9hF3N1sn9U9EytRq3iVq8hZUEgYcmrP6sj6YX7hIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mklnp+4UtmYQx528gAiVFaums7OmdZxaBTqLvOripTs=; b=KzqdToHFwvMUNqZgWE3UybW3XORlErehdoHPKJtJHA+x7H5R3hnNU2MT8PsYPYJ9LCsYsE5veamIpj5TRWcMMNAqAbv2T7NeTLGsVhce/x+QhDbye/7ht45wsIsIGJFJzUPgi0jAgWYsZnbngVzTt/9Z/ZT5L/dqaaeI0KpkIc0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v3 7/9] xen/x86: use paddr_t for addresses in NUMA node structure Date: Wed, 11 May 2022 09:46:37 +0800 Message-ID: <20220511014639.197825-8-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220511014639.197825-1-wei.chen@arm.com> References: <20220511014639.197825-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 95284434-5fbe-423c-5f28-08da32f03448 X-MS-TrafficTypeDiagnostic: DB6PR08MB2662:EE_|VE1EUR03FT030:EE_|GV1PR08MB7314:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GYMmS3yLFsriP4MgyZsrIjOTFFzl7kVj+mVmejyDMUzO50gmFV8DFwZDxvaR0ho0kYQ5oZsFSH3+oajyoATG0yzEt0Z+6MsIAxpSJOmFTa91k2GqKUB45FSK2LIORSHMedKnAOIT0Jhh1yM16IIe+zUV0KxxpHZp0dekJ5CAh+fHZEm38daUNMAsH4fWzZ8hAcaJfh7yvEaH2Q6lzKyRQ7CdGobEJ/TFAG0DM592J4dI/Ac+i71kfFDci29YC3JNtwO3py1ZP6/SfuQ/mGkT8NSfN5dufDNhUGfmXzGh5kVlEsC5YHcgnKQ4JUGwTK2e1JUj+ssf4IvNW+7V9Cqf/4ncNdqkUuvTai5DdJuOgpEcHO8KGorl400rnFdq5adsdSCLsjxKGhnmDxWDtNlIxDNLrETaJxLt41TTUQP0rO3lUr1ZVf/Lt5i6FYZJgPc58pHHl94vaeJ3Cld19Z6NIGslfkK7t2XFAblEWoLn7vyJZMs2IJgX8I7k4kfpwaCFtJYcXqZy6Fy9lTSOy3Zly//mM7CoxZ3wkkgXPcUsGxZGUBY8GuNnclmG3oWIglwUt7gFFxnykuFx1JSKJupyquhuoE7qA2LnPYecU26MOSXr2uQfN5KCxzWrisAVUGs6EEgqwLxu7DarcBJx3ZW2h7ZrzxMEuJUWpj1mC3OOOKB73Off47uLmSfcSBmdbzKI8t3BjfUBxSltNIEnAspZFA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(2906002)(186003)(44832011)(336012)(47076005)(426003)(26005)(54906003)(5660300002)(1076003)(40460700003)(2616005)(7696005)(8936002)(70586007)(70206006)(356005)(81166007)(8676002)(6916009)(83380400001)(36860700001)(4326008)(86362001)(82310400005)(36756003)(316002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2662 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 20c325b9-a60a-4f71-c4a0-08da32f02deb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UPC+y4RFeupyme7HqrifpdO3dTxjEJRyqD9ooeQshij23vCKtptBUE1YIrd3D6KzLmzK5fIv6H1nlGDFU6f2GSAwRKAPVMOcu+TG9l8SVw+lDVGZt5UubmUFQtEoLTWtW3Opv3/UA4fgn/7JtI4Lb4H+Uoxu2XDd2PkTDrt3T1LPWDgWlcw83MeOYrAt2OatNuYOFEshC1Xh9aWRx67qPCQV73V4wqTlZLBY4HmnGLCJmy5BOBiptTg9LWaa6ZKwhnJNLs+GQzeD0tqi/IbHnIInDji5NkbJzyzqsRBqEG5yczXNGuTpc0UuI+geBI3LxE1WKdxsKiI9QSoCzZKSgsq30cX8jt84jT8UBaKycaKM4SBnCjcmWwuBPSUXmOtDGtUmDfE/zJUOe47snFSsag9jPVXxxtgKdOWAcw+CO73rKXlUG2OzZtmfrif4bRkT7CqpZHH8TkE0e8+qV6UOqgcLdUMnye81ZiprFtJ88BLofcz6ZwD7FAQ3R9t2SKDWlOr+8Ov1acesfC7xbaATsbFHa9DTeYw2ilM0GUlUmGRpo95A4n2NR8VqDz5e5+hVpqMPxDQhOmWYr/IRxZP4Ku5DCjY4rGHcqBxkrCOnywAHW7IhUl5OhIHJEbdarMkE9VWtu9SQIh8FAofCFKhU1Bii6tXbDSitZ+EvqKdBioC8e2ttO1t8Im1hSSLlOV4e X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(5660300002)(70586007)(508600001)(8676002)(54906003)(6916009)(7696005)(1076003)(70206006)(81166007)(47076005)(82310400005)(336012)(426003)(36756003)(186003)(8936002)(86362001)(44832011)(26005)(316002)(40460700003)(2616005)(4326008)(83380400001)(6666004)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 01:47:27.5638 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95284434-5fbe-423c-5f28-08da32f03448 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7314 NUMA node structure "struct node" is using u64 as node memory range. In order to make other architectures can reuse this NUMA node relative code, we replace the u64 to paddr_t. And use pfn_to_paddr and paddr_to_pfn to replace explicit shift operations. The relate PRIx64 in print messages have been replaced by PRIpaddr at the same time. And some being-phased-out types like u64 in the lines we have touched also have been converted to uint64_t or unsigned long. Tested-by: Jiamei Xie Signed-off-by: Wei Chen --- v2 -> v3: 1. Use uint64_t for size in acpi_scan_nodes, make it be consistent with numa_emulation. 2. Add Tb. v1 -> v2: 1. Drop useless cast. 2. Use initializers of the variables. 3. Replace u64 by uint64_t. 4. Use unsigned long for start_pfn and end_pfn. --- xen/arch/x86/include/asm/numa.h | 8 ++++---- xen/arch/x86/numa.c | 32 +++++++++++++++----------------- xen/arch/x86/srat.c | 25 +++++++++++++------------ 3 files changed, 32 insertions(+), 33 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 5d8385f2e1..c32ccffde3 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -18,7 +18,7 @@ extern cpumask_t node_to_cpumask[]; #define node_to_cpumask(node) (node_to_cpumask[node]) struct node { - u64 start,end; + paddr_t start, end; }; extern int compute_hash_shift(struct node *nodes, int numnodes, @@ -38,7 +38,7 @@ extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); @@ -76,9 +76,9 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(u64 start, u64 end, nodeid_t node); +extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); -void srat_parse_regions(u64 addr); +void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 680b7d9002..627ae8aa95 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -162,12 +162,10 @@ int __init compute_hash_shift(struct node *nodes, int numnodes, return shift; } /* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end) -{ - unsigned long start_pfn, end_pfn; - - start_pfn = start >> PAGE_SHIFT; - end_pfn = end >> PAGE_SHIFT; +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); NODE_DATA(nodeid)->node_start_pfn = start_pfn; NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; @@ -198,11 +196,12 @@ void __init numa_init_array(void) static int numa_fake __initdata = 0; /* Numa emulation */ -static int __init numa_emulation(u64 start_pfn, u64 end_pfn) +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) { int i; struct node nodes[MAX_NUMNODES]; - u64 sz = ((end_pfn - start_pfn)< 1 ) @@ -218,9 +217,9 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn) memset(&nodes,0,sizeof(nodes)); for ( i = 0; i < numa_fake; i++ ) { - nodes[i].start = (start_pfn<start < start) { @@ -275,7 +275,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - u64 start, end; + paddr_t start, end; unsigned pxm; nodeid_t node; int i; @@ -318,7 +318,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) != !test_bit(i, memblk_hotplug); - printk("%sSRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with itself (%"PRIx64"-%"PRIx64")\n", + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, node_memblk_range[i].start, node_memblk_range[i].end); if (mismatch) { @@ -327,7 +327,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) } } else { printk(KERN_ERR - "SRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with PXM %u (%"PRIx64"-%"PRIx64")\n", + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", pxm, start, end, node_to_pxm(memblk_nodeid[i]), node_memblk_range[i].start, node_memblk_range[i].end); bad_srat(); @@ -346,7 +346,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) nd->end = end; } } - printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIx64"-%"PRIx64"%s\n", + printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n", node, pxm, start, end, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); @@ -369,7 +369,7 @@ static int __init nodes_cover_memory(void) for (i = 0; i < e820.nr_map; i++) { int j, found; - unsigned long long start, end; + paddr_t start, end; if (e820.map[i].type != E820_RAM) { continue; @@ -396,7 +396,7 @@ static int __init nodes_cover_memory(void) if (start < end) { printk(KERN_ERR "SRAT: No PXM for e820 range: " - "%016Lx - %016Lx\n", start, end); + "%"PRIpaddr" - %"PRIpaddr"\n", start, end); return 0; } } @@ -432,7 +432,7 @@ static int __init cf_check srat_parse_region( return 0; } -void __init srat_parse_regions(u64 addr) +void __init srat_parse_regions(paddr_t addr) { u64 mask; unsigned int i; @@ -457,7 +457,7 @@ void __init srat_parse_regions(u64 addr) } /* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(u64 start, u64 end) +int __init acpi_scan_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; @@ -489,7 +489,8 @@ int __init acpi_scan_nodes(u64 start, u64 end) /* Finally register nodes */ for_each_node_mask(i, all_nodes_parsed) { - u64 size = nodes[i].end - nodes[i].start; + uint64_t size = nodes[i].end - nodes[i].start; + if ( size == 0 ) printk(KERN_WARNING "SRAT: Node %u has no memory. " "BIOS Bug or mis-configured hardware?\n", i); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 02:12:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 02:12:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326140.548990 (Exim 4.92) (envelope-from ) id 1nobpW-0005gm-N6; Wed, 11 May 2022 02:11:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326140.548990; Wed, 11 May 2022 02:11:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobpW-0005gf-JM; Wed, 11 May 2022 02:11:58 +0000 Received: by outflank-mailman (input) for mailman id 326140; Wed, 11 May 2022 02:11:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobpV-0005gV-LK; Wed, 11 May 2022 02:11:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobpV-0002Sf-Ip; Wed, 11 May 2022 02:11:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nobpV-0004fl-58; Wed, 11 May 2022 02:11:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nobpV-0008Ci-4g; Wed, 11 May 2022 02:11:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=evIC6E+UzOjXZqJeF7i7Rs7gztzpYegOKGsUVZ5yXlE=; b=A/hDshvk9Wxa5BaK+uQAQ6n8t7 h3Gv1vmIpn7/dYwsPjPXz3RCXlq42Dp3VfA5f7EPLCIAs6QUOtTZuTHP8g2pU0eVLCn4eNQX4QTQK J7iiJoooSFsvNdOwpEIyp8Cq0FGkkUjdG3r1os+k05LivP4YqEkRe/JYMb6rQev5NK4Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170307: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 X-Osstest-Versions-That: xen=0badfb110fa33ca9ffd3bdc3a5200cded03e6106 From: osstest service owner Date: Wed, 11 May 2022 02:11:57 +0000 flight 170307 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170307/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170293 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170293 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170293 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170293 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170293 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170293 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170293 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170293 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170293 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170293 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170293 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170293 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 baseline version: xen 0badfb110fa33ca9ffd3bdc3a5200cded03e6106 Last test of basis 170293 2022-05-10 08:28:59 Z 0 days Testing same since 170307 2022-05-10 19:08:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Julien Grall Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0badfb110f..407b13a71e 407b13a71e324aba76b11e5f66f59ce4a304a088 -> master From xen-devel-bounces@lists.xenproject.org Wed May 11 02:47:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 02:47:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326150.549000 (Exim 4.92) (envelope-from ) id 1nocNn-0001Md-JO; Wed, 11 May 2022 02:47:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326150.549000; Wed, 11 May 2022 02:47:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocNn-0001MW-GX; Wed, 11 May 2022 02:47:23 +0000 Received: by outflank-mailman (input) for mailman id 326150; Wed, 11 May 2022 02:47:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocNm-0001MM-IF; Wed, 11 May 2022 02:47:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocNm-00034b-En; Wed, 11 May 2022 02:47:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocNm-0005R0-4K; Wed, 11 May 2022 02:47:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nocNm-0008LL-3r; Wed, 11 May 2022 02:47:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=13RVWOCqyQ2W3c8G92zngWRbeqSmu2YKAr9zbMtUgC8=; b=EssXFj8VEB7CXh8Fi15R4pabSx 1n5MxMWndrdXTPp1lwcrFzSq36oyJEs3y8pGni+7i1XyjykOjDJGToIj3ME8ZwzH0HZtFxZ3n5PdP fFl8/TLDD3ox9Z1nvYU+SfH1kFets5SBqA41rrogO/dLww+/CX6GNXABEmPdour3VGy8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170313: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 02:47:22 +0000 flight 170313 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170313/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 924 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 03:12:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 03:12:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326163.549012 (Exim 4.92) (envelope-from ) id 1nocm9-0005JP-Kh; Wed, 11 May 2022 03:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326163.549012; Wed, 11 May 2022 03:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocm9-0005JI-HH; Wed, 11 May 2022 03:12:33 +0000 Received: by outflank-mailman (input) for mailman id 326163; Wed, 11 May 2022 03:12:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nocm8-0005JC-01 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 03:12:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30cabfd8-d0d8-11ec-a406-831a346695d4; Wed, 11 May 2022 05:12:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EF5960BCC; Wed, 11 May 2022 03:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F8E7C385CB; Wed, 11 May 2022 03:12:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30cabfd8-d0d8-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652238748; bh=deRrOD6C1JKDypsoVeF1ot8kv+B3aIdokAzzIWtyC+g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ETje1VtdrXayv3NnGy8cF/nQoO6fhIalFC2YV+HNIolvvBzgXMbogCD08vtVyTK98 /5p3T6fiYyYldjNwut//O3qWY+ausLUQsCKfoLe820WvpFDEE07HD/m+rOMz2NfHsF QyQK0br/Bs5Zvyh5d/KQWBal2TeC3d0Jq86ocq8fQj5FK6j0/82YaCSw32zVKnkhnr 7wL+AfPpZmoSL9P3v3Nqi/O/irOktmvVSAXjrrZwWEtBxjEJqNr16Z6638pNKyiGBN vW1T2Mm1t6iDzX+ZdSjC7dTLpmL37Rb5B0kQLxAf0KCoK+G71f+rYmsgOO0bM9Zkf1 qXKE0uBJ2COKw== Date: Tue, 10 May 2022 20:12:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Andrew Cooper , Lin Liu , xen-devel@lists.xenproject.org, Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap In-Reply-To: <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> Message-ID: References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-169192622-1652218020=:43560" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-169192622-1652218020=:43560 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 10 May 2022, Julien Grall wrote: > > It is not reasonable to say "this unrelated thing is broken, and you > > need to fix it first to get your series in".  Requests like that are, > > I'm sure, part of what Bertrand raised in the community call as > > unnecessary fiction getting work submitted. > > To be honest, you put the contributor in this situation. I would have been > perfectly happy if we keep *cpup* around as there would be only a place to > fix. > > With this approach, you are effectively going to increase the work later one > because now we would have to chase all the open-coded version of *cpup* and > check which one is not safe. Without disagreeing with Julien or Andrew, I am actually happy to see an effort to make the review process faster. We have lot of room for improvement and spotting opportunities to do so is the first step toward improving the process. I have actually been thinking about how to make things faster in cases like this and I have a suggesion below. In this case all of the options are OK. Whether we fix the alignment problem as part of this patch or soon after it doesn't make much of a difference. It is more important that we don't get bogged down in a long discussion. Coding is faster and more fun. It would take less time for Julien (or Andrew) to write the code than to explain to the contributor how to do it. English is a good language for an architectural discussion, but simply replying with the example code in C would be much faster in cases like this one. So my suggestion is that it would be best if the reviewer (Julien in this case) replied directly with the code snipper he wants added. Just an example without looking too closely: --- Please do this instead so that alignment also gets fixed: return be16_to_cpu(*(const __packed uint16_t *)p); --- Alternatively, I also think that taking this patch as is without alignment fix (either using be16_to_cpu or be16_to_cpup) is fine. The alignment could be fixed afterwards. The key is that I think it should be one of the maintainers to write the follow-up fix. Both of you are very fast coders and would certainly finish the patch before finishing the explanation on what needs to be done, which then would need to be understood and implemented by the contributor (opportunity for misunderstandings), and verified again by the reviewer on v2. That would take an order of magnitude more of collective time and effort. Of course this doesn't apply to all cases, but it should apply to quite a few. In short, less English, more C ;-) --8323329-169192622-1652218020=:43560-- From xen-devel-bounces@lists.xenproject.org Wed May 11 04:06:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 04:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326170.549023 (Exim 4.92) (envelope-from ) id 1nodca-0003JL-Jh; Wed, 11 May 2022 04:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326170.549023; Wed, 11 May 2022 04:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nodca-0003JE-Gd; Wed, 11 May 2022 04:06:44 +0000 Received: by outflank-mailman (input) for mailman id 326170; Wed, 11 May 2022 04:06:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nodcZ-0003J4-8r; Wed, 11 May 2022 04:06:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nodcZ-0004X2-6r; Wed, 11 May 2022 04:06:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nodcY-0000zP-Rz; Wed, 11 May 2022 04:06:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nodcY-0007H2-RV; Wed, 11 May 2022 04:06:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SeHPe504hek4lZ8nD+z6k1mZuAqu5j3zyWCvDdfwk6I=; b=SWPq9DK5cuYouIMc6iFXLdf4Pu 3/B+855IRWD0DcwVrkxnUauzGOL9kJuBvtFbsTZKZKqlogPXMteTJpJ10ko94nVpuDZpV622Uapl7 dfMsuKhMCGcz7uKl8/z5WfOdW6ym8puOl3EVvMszvJWj8fu2IGg7uMfblHzcxPEme6fw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170315: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 04:06:42 +0000 flight 170315 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170315/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 925 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 05:24:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 05:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326506.549034 (Exim 4.92) (envelope-from ) id 1noepc-0004Pj-D0; Wed, 11 May 2022 05:24:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326506.549034; Wed, 11 May 2022 05:24:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noepc-0004Pc-9w; Wed, 11 May 2022 05:24:16 +0000 Received: by outflank-mailman (input) for mailman id 326506; Wed, 11 May 2022 05:24:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noepa-0004PS-BV; Wed, 11 May 2022 05:24:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noepa-0006Nt-9e; Wed, 11 May 2022 05:24:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noepa-0004Nk-1m; Wed, 11 May 2022 05:24:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noepa-0007gX-1I; Wed, 11 May 2022 05:24:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TlDscSiLTHhO0tnlMfRMKubnyFkuBvr+A0I/m6ToqFg=; b=BJegNSqYXpIofbTgVumoWUdQjD KWvumO4erVUekUCZNXB13SA8b4JM+lLk2/RhtcoKiEWtyphf08u76ITW31pWcWldTybyqNIo4zbsz 4HeQFReAEvLEV1NNdaA2pU/skPQGQZJy0CaVKh0GbFaM1W1cbX1ZX5B+UUpVKz+BKTIE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170316: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 05:24:14 +0000 flight 170316 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170316/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 926 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 05:28:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 05:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.325992.549045 (Exim 4.92) (envelope-from ) id 1noeu2-00057s-4i; Wed, 11 May 2022 05:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325992.549045; Wed, 11 May 2022 05:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noeu2-00057l-1r; Wed, 11 May 2022 05:28:50 +0000 Received: by outflank-mailman (input) for mailman id 325992; Tue, 10 May 2022 19:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noVis-0002aR-OT for xen-devel@lists.xenproject.org; Tue, 10 May 2022 19:40:43 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13168f69-d099-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 21:40:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13168f69-d099-11ec-8fc4-03012f2f19d4 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652211640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OEDxfxfGB0zzvmyrmmb19QrPenmgyOx+wB7aMTpPY14=; b=s9qpTYE/3WJU4N3KJVSOdyb7xWHt1vkR4fCuQ5J8Zkt0v0hhGnmBmJdDRvMzx7U23g78AD 5x0GWGYOK6up5rJgLjlqAJ0oKWgxSuZArLqIZD7/93+m719asCNv2npDv0K4E3pzaf0TU1 QT3fxi7rAkTN0NzY7sIU3W6vHFJAKmFF1D5WFGFp25IVzQ1U2GLRWaAA15JzW4DMVMPiln C4PlGutDHid0b5MW+yz4Oad3VH/9G9wKQ7qYFzrw5pmS2R8UQ108RRuRC1xOe7QqhudZaN toooF05flVTdgRJ8Mw90Ti/8UtTs7R3lmx6LjRAd0TtWQNVsyqtk/eFe4jDJKA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652211640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OEDxfxfGB0zzvmyrmmb19QrPenmgyOx+wB7aMTpPY14=; b=vLCouTuSreEprlIyaHBdxRuhj0utQMxldxJLsrUVX2CbalgS135YGbpGNA0WSY+j9euZdD GTFEAV97omDLmGAg== To: Steven Rostedt , Petr Mladek Cc: "Guilherme G. Piccoli" , Evan Green , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path In-Reply-To: <20220510132015.38923cb2@gandalf.local.home> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> <20220510132015.38923cb2@gandalf.local.home> Date: Tue, 10 May 2022 21:46:38 +0206 Message-ID: <87h75xkwg9.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain On 2022-05-10, Steven Rostedt wrote: >> As already mentioned in the other reply, panic() sometimes stops the >> other CPUs using NMI, for example, see kdump_nmi_shootdown_cpus(). >> >> Another situation is when the CPU using the lock ends in some >> infinite loop because something went wrong. The system is in >> an unpredictable state during panic(). >> >> I am not sure if this is possible with the code under gsmi_dev.lock >> but such things really happen during panic() in other subsystems. >> Using trylock in the panic() code path is a good practice. > > I believe that Peter Zijlstra had a special spin lock for NMIs or > early printk, where it would not block if the lock was held on the > same CPU. That is, if an NMI happened and paniced while this lock was > held on the same CPU, it would not deadlock. But it would block if the > lock was held on another CPU. Yes. And starting with 5.19 it will be carrying the name that _you_ came up with (cpu_sync): printk_cpu_sync_get_irqsave() printk_cpu_sync_put_irqrestore() John From xen-devel-bounces@lists.xenproject.org Wed May 11 06:30:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 06:30:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326522.549056 (Exim 4.92) (envelope-from ) id 1nofrk-0003Ma-Q2; Wed, 11 May 2022 06:30:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326522.549056; Wed, 11 May 2022 06:30:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nofrk-0003MT-MN; Wed, 11 May 2022 06:30:32 +0000 Received: by outflank-mailman (input) for mailman id 326522; Wed, 11 May 2022 06:30:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nofri-0003MN-LA for xen-devel@lists.xenproject.org; Wed, 11 May 2022 06:30:31 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d69c118b-d0f3-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 08:30:26 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 02:30:22 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by BN7PR03MB3443.namprd03.prod.outlook.com (2603:10b6:406:c4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 06:30:19 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5250.013; Wed, 11 May 2022 06:30:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d69c118b-d0f3-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652250626; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=TFL9dlCMfxbvGqkAsRJlC4OhrUU7mwiZe5djc7sZHy0=; b=g/dwzcc2XP6v+rrBzgxj3RtSJl8ftA1DuRztZvhmeRbatTRRwxdE0fm5 Qh3Mzk6Q685X0tLHzj6Mvl0EHUXaIbrjCRWWX1Slv9mIejWYy7N07XJIE 9PxAGUVXFMsbwKqzAexYdoniHSwUiTfQKsworxzx2VH+ABO/kzyg++Gfm s=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 70430529 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:msIuUKIBdS5ffLL2FE+Rw5QlxSXFcZb7ZxGr2PjKsXjdYENS0zYCx jMcUG3UMvqONjb9KtF1b4XjoE9TsMDXyIdqHFdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39cx2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MsV7o21blYsApL3tbkYbyt9FntzYoQTrdcrIVDn2SCS52vvViK1htlLUgQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM+FGvqWjTNb9G5YasRmGffYI c4YdBJkbQjaYg0JMVASYH47tLjw2iKnLmcJwL6TjYMuw1TMljFN64HWIOXnXvfWbMFq3UnN8 woq+Ey8WHn2Lue3yyeB83+qrv/Cm2X8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb UsO9UIGtrMu/UamSt38WRyQo3OeuBMYHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOnNAybSwn0 BmOhdyBONB0mLicSHbY+rLKqzq3YHERNTVbOnNCShYZ6d7+po11lgjIUttoDK+yiJvyBC30x DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlVdCtn/No590j5EWQ== IronPort-HdrOrdr: A9a23:fOHhIKgvo5dW668Cq5GGN7dpY3BQX2913DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySGVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNyk2sS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Lm1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoMOCXMsLlVFtzfsHfqWG1TYczBgNnzmpDr1L8eqq iNn/7nBbU215qeRBDznfKn4Xic7N9n0Q6f9bbfuwqunSWxfkNEN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3amAa/hGrDvCnZMZq59ks5Wfa/psVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV5Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r+NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC7K gpkGkowFLaV3ieePFmhqc7jCwlaF/NLQjF24VZ+4VzvKH6Sf7iLTCDIWpe4fednw== X-IronPort-AV: E=Sophos;i="5.91,216,1647316800"; d="scan'208,217";a="70430529" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOcqn5i9vkgFXDHWy4MTe6juThZx0BWTlUoj/S4QiVwqNPcK3BctUY8IPwZE3cfvzk6537aRaDBJYe6cGNEH+7EihycE/DiKTQUgrshzhsGY983BKyDE8GyzunBTNLT6SCWkNNjwdtSYgQ0Up4qXSDofGD2E+GED33KlptPm9xY6RXd7gC8jqtZ7chmW/4g9VEvNT7bGK9UFPJAFImQJceo68Oo3obD/4OX+r2WSFsx/xQoZxKiIjeaZBSt9QtgSRpzeNclukrjWyJe8LfIjvDgfjjCINU/3u54zOXC4l8cmyJwDWWSZBB/OltSj4FYr2b0/TsRrhW4asAnosfzRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsMDPhkf7hpkp4E2x/aTlXYhIAKY0+sqxGm/yPQjrpA=; b=Jl4N9IPWNVD+xy0ktqwLba2tmSogNNK24apmCIqOcQDb7fAhJ3k8730jGM/aPlvXuSIJly1P6XKN01hIDG6AYW0OS9HTkehWzvwnwUoQ1wOd62sBl7qhNeuOryd2dTOyjJ2rPu1hq0tmzbP5Cuz3zbGyk2sg+MF4pNd8YQno6ltoto/MMvRQhOoppx/vKDJYm25kraNpjfdBgOTEhAH5Xxuo18QujEBKRTWxSIM3CVkOMAOnP8EU01hm4bu7GFmbv+BQXPR55jm2F8V9yYvuAQkus45YQihvSEymm6ELZq9qBU5u9bFeq1tCnAq0HynDp7sM8zdhgAFjSXJ+dnslmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsMDPhkf7hpkp4E2x/aTlXYhIAKY0+sqxGm/yPQjrpA=; b=W4aEEDibzxAUn171mRh65mrPwnCcRNGPp1h0Z6HSn8wkBcSiPSDl7uCfIChQH8KmtD3aSKGHqajwrchyMhTK78/E2LxhBKripoyb/D6m7zLNl+1jYDy0HmamTrRBaNpYbEyu/G8T/EbZs0LjHS6t9UgJlC2+hX0om1sl7DLEHMY= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v3 4/6] xen: Switch to byteswap Thread-Index: AQHYZFbwMAUPLb2cVkOFb20aHHYzoa0X7v0AgAFIaw0= Date: Wed, 11 May 2022 06:30:18 +0000 Message-ID: References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> In-Reply-To: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41cba1f3-1ff1-4e89-b03f-08da3317b7f1 x-ms-traffictypediagnostic: BN7PR03MB3443:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6bRy40ICPJoKWzHqIah1roWnCezEsUil15MDXp3qpJM4fO0l/anAq6Rg+9EN9PZpzFuPmmbbZlacgBkY7UDJ2Gl0dcy3E/yNWD6Oi86NXtHNZozXNcYLDrtgnG2rslLlk3PbI5PUAaOXvzltd7VvAhC12Dso3DQa+i/ArLgNIhxl4I8OkQfvOiuL7U+AkBIbVmLs6+rMtk6kXtSxJPDUUk+wZLQkrHsdqeEwZv3JpIrNCND1eZPQCcmaOzz07K8s1KSQ2DRc6WEbPUUxo8DRJ6xUzkiY5A17ebkd5nFzfpt3QVXmJ4f0bx7enoyQM49yvJdlBdSedUQcLkM56U3D/367vTI97FmwhypUMIme0p2msifqlG6Bvr49cxUz52zWgcAWXbx3Is8Z6EVPmIcFYu5yIH4BfVUwSj+p5ZikCysUR/8AqSbNSUQftUTufvydT3J087V4niTuElX8MMmrHCYBc7faIq4pPqo9KjYg/5eWBcSUIK1fjPB76bG2vWhiDxtDV8f6gFJkaQ2GP3DVfpe96vstunL+3iw4e0beQ2L3T2/X4O0BUCRfdBPEQqaNjcNbA+ykzkda8gBvQqt4Iwz0T9O4AGL4posOCAMmHMbqLBIi0fHCoJUk5eUZS5vSn4JzjiYgMlldgWI6eLj1s8dwIJ7XV4BxkJwhunNjbMqjZyIwK7DkMTfg+rcsps4ZCG+//eICP1EAV6gVZas7fcw6UhJqcCw80Gs532BIVwtgv7AF8zvLt1q3lxb3wTCRh5uh7P7I90sp0HJ8SvyrWRmmAfXd2gvp5qiDD1h79T8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(52536014)(76116006)(82960400001)(55016003)(91956017)(38070700005)(38100700002)(966005)(316002)(508600001)(8936002)(110136005)(54906003)(8676002)(4326008)(66946007)(86362001)(66446008)(64756008)(66476007)(166002)(122000001)(83380400001)(71200400001)(26005)(53546011)(7696005)(6506007)(85182001)(9686003)(186003)(2906002)(33656002)(5660300002)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?MlErd3liWTN1Nysxd01HVXpYRnNJaUh2ZEhYRlNuOU4xc2Vwa3FPQitKRU1U?= =?gb2312?B?OVl2aXppK1ozMStHRC9EcGhnTnlsdDdSWEF3OG1QcGlneHRrYVhPR2IwdXF0?= =?gb2312?B?UEg4ZU5uSnVDOStKVTFLZ3h6dWoydHBSWUZTRzdJaXFWZ1NQY2hhcGpGL1lK?= =?gb2312?B?KzRTd3dyZlFhcUM5VmkzMDBBOEwxWSt2NlJ6Qmh3VnpxYkd3UUYzcElsTm1p?= =?gb2312?B?bnROZ2xqdlM0T0IvcEQxZ291OGo1c2c1S2txSjdRQ2Q3VGs2OW9sTXgyTnhY?= =?gb2312?B?eXM3dnJPTUVkKzRzKzI3ek9JdDhnb0ZIYjllbjh1Unl4b3RlL1N2RmVkeHR4?= =?gb2312?B?VStYZ2VrcDdxV3dRY1o0bFljVkRTb1JSR0tMLy9QazV0eUtKcHMzYWI0L1E5?= =?gb2312?B?ZEpqY2NESnZBNitaRytvM1duNVc2d1N1eUY5OFBWSVBMNmRLbFp6eUxCekZE?= =?gb2312?B?VGhabGJUS0NMVmpZVmcvOG5pVVRPR0o0ZEc2ZHFuano5YXhaRWxSbHdTMHpZ?= =?gb2312?B?Z2t5ZkovTjdvRzcxVFo4VmIvNGNmQUc3NUxjTmtpL2MzVi9Xa2JzMG4ycTJG?= =?gb2312?B?QTZYMmR0TDlUdHhUZ1hKa0VRWEZGa3ZZTG14YTZMWEd5RklHdmlTYkVqaVVX?= =?gb2312?B?STFDUTZWY25QTVdTWFRhdlJMUTM5dlk0dXJwbzdKNWsySFQ4K1F5M0ZPZTNU?= =?gb2312?B?QXR0SWR2ZWxaWmlkUlh4Y2Q0M2w1VG1oQ1N2TnFNY1lNM25yeWlvM2IvV1dK?= =?gb2312?B?anpNSmZCZGRSQk9sdDErNExrVjMvbmlGOTltS3d6d1p2RzRDNXFGNTljMW04?= =?gb2312?B?RjNKTTR6Zjk5by82RHM5QXJmbm4rRmhOc2Jyazk5S05PMDgwZkd2U3B2WWZv?= =?gb2312?B?YVFRbUs2bVlBUWpacFA1MTY5T201MjZGcERRbE9YVStWNjFON1FCZSs4a1Vh?= =?gb2312?B?cUNVY1ZIc2oreU1Xdk9BYkdWb3NNQiswcVE4Nm14Zm4xakpKbURQTXcxb1Y2?= =?gb2312?B?aDFuYzQ2eEh4b2NwMFcxUUEyR0RHWmlJQ3krdXg0c3BraWRrQkJqY3I4THpr?= =?gb2312?B?bEg1RW5PMWNNbXFoNzByVlA3cXlqTjRQdFlxS0dTNXJFcUh0Z1UzY09iUG9a?= =?gb2312?B?RmZsMWRnZGhwd0xoSW10UHhTeVo3NXJaS1ZwYzZzUUlxVkVwN1k3QWtkc2Fw?= =?gb2312?B?Z2FrOEI4SzcrWDJUN1lpUGRENjBCUjEyc1BJMXNxL1F3bGpKc1BVTWN4eGZT?= =?gb2312?B?ellOd0E3aE5CMDA3TjREb1BRZk54cjhmbFYyQUxJdjkxd2pnMjdET0kxNXlJ?= =?gb2312?B?R2V6NGRpR2FxM2pOaG9qb3lLVVRDRFpCclFGUHdCZkNxZWlLb09Ebk0yMUhH?= =?gb2312?B?RmJNa05USHZjTytLUmNkcjkyNkNvSnIyYUNNK1ZJeDRJM0pDWUZ1WWE3dkJR?= =?gb2312?B?WmpCVTFMSjJtREZTM0RtVUFmcDg4TEl3NHNjd0ZSa2FzNjdoRXVBTGpWNmpZ?= =?gb2312?B?QjB6eXQ3WkpOY25PNUZkR0MrbkN1LzUwVVl0aFRQVlhCRWtWckt0ckZ5dlZW?= =?gb2312?B?YUpTK0tzMXpUdUJjUnlzZll5Q0E3MHJUK3piVm1welMvaHA2U0J2QmxvQk9i?= =?gb2312?B?SXhPRjh2RnZJSTJhdTJDeXpobjV3dUNHd3Ayd3NHQnk0MWxYNjZRckQrOU5U?= =?gb2312?B?OVFlaFRoQk5rNjlHVEpMcHdlTmwyRk9hNFZEcHoyQVZlY0p5cGRDYVdnSFNw?= =?gb2312?B?b1lsZkR0MTg2NWx6T2MwajR4VzdUS3VFcEMycVdlelBzWk1pamNMN0NjK3Bv?= =?gb2312?B?NVJ2aE5ML00yeWMyWjIyYnhlUnVsZUNHcXFzbnM3UG9EZTF2Mjh3VjJnUUlH?= =?gb2312?B?M2dDTGQ4cGNBR3dSKzJCSVNCQWc1eEtRbjJzR2Y0MTU0NjZRcThxVkw4M21L?= =?gb2312?B?KzQ5TXVwN3NoZ0ZDQ1FDeUkyakt6MS92a0dhMFdPTU9SY2NNcTNvWHBqdjVD?= =?gb2312?B?a1BpWHl6L0pDbG9iL205QmRNcEUwT1NiZU5DaVNtTGp5dGQxR2MrOExHb1pG?= =?gb2312?B?RlVEZGNUN0pRNDQ3UmhDcGRzbU9zN3JmQ0Y5VHdXam9BMVdjeGo2Q2psaUxY?= =?gb2312?B?ZEZ1YlFXQllTQ0NsZ2NVUzlQdlNFQmdmYlNBeGRkQ0IzZ0IxK0gxaGg3Mk5w?= =?gb2312?B?VUVQa2wyZUo3bmdxZElhcVRRck1WTnJ0Z2RJMEFVeVB0V05GNnAvb0RFb2dU?= =?gb2312?B?ckNINGg0bENPdUF5alBjLzRVTDIwRVNEYnNyTWR6dU10QW5jUmNaaXBpY01E?= =?gb2312?B?d3VVaWd5cXFRdzJ1d1daYTZNUmllR1F4RnI2NjRNM0l0Z2ZzV0piNFdQRGlt?= =?gb2312?Q?OBSAkiD3caWQuSq4=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB5405E449B19691A916EA3FE79DC89SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41cba1f3-1ff1-4e89-b03f-08da3317b7f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 06:30:18.9368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PAybjAzVBGP4x57C5hhjOXU70ZmfHg4R381tTrGRWttQgNEGLHmiORjoNIXgawqPCgS+cT/1uGtuKN5KfpzTog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3443 --_000_SJ0PR03MB5405E449B19691A916EA3FE79DC89SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 U3ViamVjdDogUmU6IFtQQVRDSCB2MyA0LzZdIHhlbjogU3dpdGNoIHRvIGJ5dGVzd2FwDQpIaSwN Cg0KT24gMTAvMDUvMjAyMiAxMToxNSwgTGluIExpdSB3cm90ZToNCj4gVXBkYXRlIHRvIHVzZSBi eXRlc3dhcCB0byBzd2FwIGJ5dGVzLg0KPg0KPiBObyBmdW5jdGlvbmFsIGNoYW5nZS4NCj4NCj4g U2lnbmVkLW9mZi1ieTogTGluIExpdSA8bGluLmxpdUBjaXRyaXguY29tPg0KPiAtLS0NCj4gQ2M6 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gQ2M6IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IENjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPg0KPiBDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRy aXguY29tPg0KPiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBDYzogV2Vp IExpdSA8d2xAeGVuLm9yZz4NCj4gQ2hhbmdlcyBpbiB2MzoNCj4gLSBVcGRhdGUgeGVuL2NvbW1v bi9kZXZpY2VfdHJlZS5jIHRvIHVzZSBiZTMyX3RvX2NwdQ0KPiAtIEtlZXAgY29uc3QgaW4gdHlw ZSBjYXN0IGluIHVuYWxpZ25lZC5oDQo+IC0tLQ0KPiAgIHhlbi9jb21tb24vZGV2aWNlX3RyZWUu YyAgICAgICAgICAgfCA0NCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0NCj4gICB4ZW4v Y29tbW9uL2xpYmVsZi9saWJlbGYtcHJpdmF0ZS5oIHwgIDYgKystLQ0KPiAgIHhlbi9jb21tb24v eHovcHJpdmF0ZS5oICAgICAgICAgICAgfCAgMiArLQ0KPiAgIHhlbi9pbmNsdWRlL3hlbi91bmFs aWduZWQuaCAgICAgICAgfCAyNCArKysrKysrKy0tLS0tLS0tDQo+ICAgNCBmaWxlcyBjaGFuZ2Vk LCAzOCBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL3hl bi9jb21tb24vZGV2aWNlX3RyZWUuYyBiL3hlbi9jb21tb24vZGV2aWNlX3RyZWUuYw0KPiBpbmRl eCA0YWFlMjgxZTg5Li43MGQzYmUzYmU2IDEwMDY0NA0KPiAtLS0gYS94ZW4vY29tbW9uL2Rldmlj ZV90cmVlLmMNCj4gKysrIGIveGVuL2NvbW1vbi9kZXZpY2VfdHJlZS5jDQo+IEBAIC0xNzEsNyAr MTcxLDcgQEAgYm9vbF90IGR0X3Byb3BlcnR5X3JlYWRfdTMyKGNvbnN0IHN0cnVjdCBkdF9kZXZp Y2Vfbm9kZSAqbnAsDQo+ICAgICAgIGlmICggIXZhbCB8fCBsZW4gPCBzaXplb2YoKm91dF92YWx1 ZSkgKQ0KPiAgICAgICAgICAgcmV0dXJuIDA7DQo+DQo+IC0gICAgKm91dF92YWx1ZSA9IGJlMzJf dG9fY3B1cCh2YWwpOw0KPiArICAgICpvdXRfdmFsdWUgPSBiZTMyX3RvX2NwdSgqdmFsKTsNCg0K PiBUaGlzIGNvZGUgaGFzIGJlZW4gdGFrZW4gZnJvbSBMaW51eCBhbmQgSSB3b3VsZCByYXRoZXIg cHJlZmVyIHRvIGtlZXANCj50aGUgKmNwdXAqIGhlbHBlcnMgdG8gYXZvaWQgYW55IGNoYW5nZXMg d2hlbiBiYWNrcG9ydGluZy4NCg0KPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3VuYWxp Z25lZC5oIGIveGVuL2luY2x1ZGUveGVuL3VuYWxpZ25lZC5oDQo+IGluZGV4IDBhMmIxNmQwNWQu LjE2YjJlNmY1ZjAgMTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi91bmFsaWduZWQuaA0K PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vdW5hbGlnbmVkLmgNCj4gQEAgLTIwLDYyICsyMCw2MiBA QA0KPg0KPiAgIHN0YXRpYyBpbmxpbmUgdWludDE2X3QgZ2V0X3VuYWxpZ25lZF9iZTE2KGNvbnN0 IHZvaWQgKnApDQo+ICAgew0KPiAtICAgICByZXR1cm4gYmUxNl90b19jcHVwKHApOw0KPiArICAg ICByZXR1cm4gYmUxNl90b19jcHUoKihjb25zdCB1aW50MTZfdCAqKXApDQoNCj4gSSBoYXZlbid0 IGNoZWNrZWQgdGhlIGV4aXN0aW5nIGltcGxlbWVudGF0aW9uIG9mIGJlMTZfdG9fY3B1cCgpLg0K PiBIb3dldmVyLCB0aGlzIG5ldyBhcHByb2FjaCB3b3VsZCBhbGxvdyB0aGUgY29tcGlsZXIgdG8g dXNlIGEgc2luZ2xlIGxvYWQNCj4gaW5zdHJ1Y3Rpb24gdG8gcmVhZCB0aGUgMTYtYml0IHZhbHVl IGZyb20gbWVtb3J5LiBTbyB0aGlzIGNoYW5nZSBtYXkNCj4gYnJlYWsgb24gcGxhdGZvcm0gd2hl cmUgdW5hbGlnbmVkIGFjY2VzcyBpcyBmb3JiaWRkZW4gKHN1Y2ggYXMgYXJtMzIpLg0KDQo+ICAg fQ0KPg0KPiAgIHN0YXRpYyBpbmxpbmUgdm9pZCBwdXRfdW5hbGlnbmVkX2JlMTYodWludDE2X3Qg dmFsLCB2b2lkICpwKQ0KPiAgIHsNCj4gLSAgICAgKihfX2ZvcmNlIF9fYmUxNiopcCA9IGNwdV90 b19iZTE2KHZhbCk7DQo+ICsgICAgICooX19iZTE2ICopcCA9IGNwdV90b19iZTE2KHZhbCk7DQoN Cj4+IFdoeSBkaWQgeW91IGRyb3AgdGhlIF9fZm9yY2U/DQoNCkdvb2dsZSB0b2xkIG1lIF9fZm9y Y2UgaXMgdXNlZCBpbiBsaW51eCBrZXJuZWwgdG8gc3VwcHJlc3Mgd2FybmluZyBpbiBzcGFyc2Us DQpodHRwczovL3N0YWNrb3ZlcmZsb3cuY29tL3F1ZXN0aW9ucy81MzEyMDYxMC93aGF0LWRvZXMt dGhlLWF0dHJpYnV0ZS1mb3JjZS1kbw0KSXMgc3BhcnNlIGFsc28gdXNlZCBpbiB4ZW4/DQoNCg0K PiAgIH0NCj4NCg0KDQo= --_000_SJ0PR03MB5405E449B19691A916EA3FE79DC89SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Subject: Re: [PATCH v3 4/6] = xen: Switch to byteswap

Hi,

On 10/05/2022 11:15, Lin Liu wrote:
> Update to use byteswap to swap bytes.
>
> No functional change.
>
> Signed-off-by: Lin Liu <lin.liu@citrix.com>
> ---
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Wei Liu <wl@xen.org>
> Changes in v3:
> - Update xen/common/device_tree.c to use be32_to_cpu
> - Keep const in type cast in unaligned.h
> ---
>   xen/common/device_tree.c     &nbs= p;     | 44 +++++++++++++++---------------
>   xen/common/libelf/libelf-private.h |  6 ++--
>   xen/common/xz/private.h      = ;      |  2 +-
>   xen/include/xen/unaligned.h     &= nbsp;  | 24 ++++++++--------
>   4 files changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..70d3be3be6 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device= _node *np,
>       if ( !val || len < sizeof(*out_= value) )
>           return 0;<= br> >  
> -    *out_value =3D be32_to_cpup(val);
> +    *out_value =3D be32_to_cpu(*val);

> This code has been taken from Linux and I would ra= ther prefer to keep
>the *cpup* helpers to avoid any changes when backpo= rting.

> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h=
> index 0a2b16d05d..16b2e6f5f0 100644
> --- a/xen/include/xen/unaligned.h
> +++ b/xen/include/xen/unaligned.h
> @@ -20,62 +20,62 @@
>  
>   static inline uint16_t get_unaligned_be16(const void *p) >   {
> -     return be16_to_cpup(p);
> +     return be16_to_cpu(*(const uint16_t *)p)

> I haven't checked the existing implementation of b= e16_to_cpup().
> However, this new approach would allow the compile= r to use a single load
> instruction to read the 16-bit value from memory. = So this change may
> break on platform where unaligned access is forbid= den (such as arm32).

>   }
>  
>   static inline void put_unaligned_be16(uint16_t val, void *= p)
>   {
> -     *(__force __be16*)p =3D cpu_to_be16(val); > +     *(__be16 *)p =3D cpu_to_be16(val);

>> Why did you drop the __force?

 

Goog= le told me __force is used in linux kernel to suppress warning in sparse,

https://stackoverflow.com/questions/53120610/what-does-the-attri= bute-force-do

Is s= parse also used in xen?



>   }
>


--_000_SJ0PR03MB5405E449B19691A916EA3FE79DC89SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Wed May 11 07:21:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:21:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326529.549067 (Exim 4.92) (envelope-from ) id 1nogeb-0008Nj-O2; Wed, 11 May 2022 07:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326529.549067; Wed, 11 May 2022 07:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogeb-0008Nc-Ji; Wed, 11 May 2022 07:21:01 +0000 Received: by outflank-mailman (input) for mailman id 326529; Wed, 11 May 2022 07:20:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogeZ-0008NG-Qi for xen-devel@lists.xenproject.org; Wed, 11 May 2022 07:20:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6357489-d0fa-11ec-a406-831a346695d4; Wed, 11 May 2022 09:20:58 +0200 (CEST) Received: from mail-bn8nam11lp2172.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 03:20:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3697.namprd03.prod.outlook.com (2603:10b6:406:ca::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 07:20:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 07:20:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6357489-d0fa-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652253657; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8d/2R/9suQnaDRrYEr/mkCYZ4GL6InhWzbNI4K2wvx0=; b=F49oJAVMwI/v31oPRaRwnPmfF5ifNWYblc0KmZoSPinQdVrtctoZAgNY ln0T8wCfOpVe1pIkzkgwDBlFvgBEDOoRcPwNNgovD1E/tEBnL0o0quIUW bKhathO+awQsQbtNHn4qTvr1ZyXuUFSXnwZ7UnbfrRXOVU9g6qqS4NaZi s=; X-IronPort-RemoteIP: 104.47.58.172 X-IronPort-MID: 70433362 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RKXmsa4hqGl/siJWpAmyvwxRtAfGchMFZxGqfqrLsTDasY5as4F+v mRKUTyFb/nbZjPzKNsjPI3j/B5TusTVnd5lSlZqrS9gHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgWlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSQZBsHJJ+Xxt8lQhxUMjpxOoFe3o/+dC3XXcy7lyUqclPK6tA3VQQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YHhl/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA9AnO/vRti4TV5B5R4pbtbYfvQYCTa/RltXzIm nyXzV2sV3n2M/Tak1Jp6EmEg+bVmCrhVYE6Fbum9+Vrilme2mwSDhINUVKx5/K+jyaWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOttIyRDEs/ k+EmZXuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty8bniJE+iFTIVNkLLUKuptj8GDW1y TbaqiE73uwXlZRSiP/9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcjlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:UiUNsql0S1VbWGaE3AhUJ7HW/0HpDfIH3DAbv31ZSRFFG/Fw9v re+cjzsCWf5Qr5N0tNpTntAsa9qArnhOdICOoqTNWftWvd2FdARbsKhbcKpQePJ8SUzJ8/6U 4PSclD4erLfDxHZJbBizVQy+xQu+VvKprY49s2Ek0dKj2Ct5sQlzuR1DzraHFLeA== X-IronPort-AV: E=Sophos;i="5.91,216,1647316800"; d="scan'208";a="70433362" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbNE7DVXtAgvepCAuI8mtldRqA97OJmm9j1Mj0vDI52AMUVoDEVQ5jZJAfUPqFDDGZq+qyXsCc3X1/cC4Bo2JU5VVMyz5B/4uQ9CeBY7BKLbH3BAsOmvQkxaXMZXkNqRgr877mLeazWf01+n+DRLHyCNyOOBiAyl7qIGYlCozktfJvXqRUs1ILt/FjevCTbPjtokmQwbM42/8HBlgIgvAR4yoNrbQn9iKJNTsYcXXcOz3jvJNIDD7i4PSdpL8/UqIWYK8Ss7Lh4+u5M1Mfyi6Ogi9ColP2P6OyhxF5qgUy3Sbf9ujbuq0r/HLWU2llBqoczPCGKfHZL8Z91yGaEXkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QLbuhTosCtGsPQ/F/FC3SZ51VKfKGgXi0M+Ud5rpGiE=; b=g+vu5iRU2ZODrpYuJLF9SiAOwY/rj5NumiXmsPlrGeNZCn+XqPVb8q698bzI/NnWmQUIoGWYdLOr5T3fqwtiOt5+L3QgiU/EEEJwiuUxi/yi5DjBGM3Hv67jvzTSh4Nda27E7+g/4WEaQhJiuh1ahN/IdRahrdtkicQzFkTwicPtpNqSkNwEpy81vem5RR1oSUJdLSVk/wJOvbAwmHo9t+EG59NYL+sPPZh/N4SLcuqIT+0GTVVLkXyQLV+zXuXsf7Nz0dK928ksJXPOQY1ssFyr8XjpdnwLy1a70VyWj/cBRJM3HzQCM3bDjVtXfSG++5du2arX4+uWQ3TzTdS/iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QLbuhTosCtGsPQ/F/FC3SZ51VKfKGgXi0M+Ud5rpGiE=; b=dfvcGd+v/9QXk2+WQbeVjUPvDODvmCA0FXs+D9/PTmEbsGj41KQ+zUgSzXuMiMzHaCk/T0ejShotlLtuCcqL4rJfA9J+DbQcL5p4aP+ke5GHhQII8IaVERdrLvQkgz4wN0g6bsgSd3yo8ocws/GxZfdq6EqCl2HyhzYTqGm376Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 09:20:46 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v3 1/2] ns16550: reject IRQ above nr_irqs_gsi Message-ID: References: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> X-ClientProxiedBy: LO4P123CA0468.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4f98ab6-3f1d-4be1-5e2f-08da331ec771 X-MS-TrafficTypeDiagnostic: BN7PR03MB3697:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5gCP4X/UNdQsqlHTxoOMCqOLruASUL74rHGWyIoal314h7QqlS1B8eLCIPmh2WwHBn0bsDWEg/2Ed8Atg2FD2PBZTHFNPuUr22WsDvE76NcPusoHFKWHllP8TywPs465lVZT6gXMiD9c/+cgnk8uHqpQjnmQpJ5m1IDWXQ1QIt+Fca3I6zHQurXBtKUjmt0Pzc9gxfyYUBc7uNCw7w93oEiQjamUcRCE7CXogCT6jNsG9GDHMWa9EJDrCIRwlf9j/P9y5EyRdmn8/qc1d96pagr7fm39eIODeRYoemCp2nCbH4EvRu5giOtwmN7jt9sx2R+VCMuKI+8DAC/MPbKF0k6jvEKBqNuTlPwn7qS3cxAGJpls9jwhhv4YJi+axhCFlYOhmkJ+XzivYWc+0829oN+tMRYHGXgukK6uQvWWJNwRITNb+vd7C/UAM2Ec7jO+mHW8jSrjcLVm7Yydl7HdeJrZOLvTpouOt/NXnyogjwKcHvV06hnYpzKRQo/5pkPkIsR+dp/mZGlP3L1C/epgdBC4vWnph6KeQoviyS4+lZL17GOiASSM0QUmWgY6jjuoUzsMAk539dvbdyWn3qNV60tfFjicISNKoOH+RXKqPJh2Og61Yk4IX1PsVp90Ec+cLP4b1f18XLLtL9MRzCAd7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(8936002)(82960400001)(83380400001)(85182001)(86362001)(9686003)(6512007)(26005)(316002)(508600001)(5660300002)(4326008)(38100700002)(66946007)(66556008)(66476007)(6916009)(2906002)(54906003)(8676002)(186003)(6506007)(33716001)(66574015)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGJpYk1peVMyK0tlY2dqTXY4TCtLY0gvdjhuRFJKanpOTlZ2T3EyS1MzNFRl?= =?utf-8?B?R1pMaHlNSlJlNjZSc2pxVm9SajdRUTUvRVRsQUd4NHBCcXdPK2g3bUtON0ZQ?= =?utf-8?B?VTZVYnhJWktscEtFbVU3S1VHVWZHL3dZTmpZWGo4K1Bhc0tUOFN5U0R6ci9Y?= =?utf-8?B?S1BXY0ZwTlR3MGkxWkFhRmdpYjlyQ3RTNjFRcE5ucnRqVWViaVk4RzV3VUo5?= =?utf-8?B?WDl6L0lKODNPRnpOdnp2enZINWRYaWFOaUZSU0NxOHNFZXJGdjBqbGp5MkI3?= =?utf-8?B?T01Pb3E5dUJRcWtUdTNEQ3JPNSt6YThsNWpSbHl4ak1PaTlyY00yVmNNYWtz?= =?utf-8?B?RmFSVGFtRkQ5VDRwOTJYMnVWMU5Wak5TYmxGTDY5VXZkL3VFOU9Sa1FMZER6?= =?utf-8?B?YU44bElJOUZOdkdRclE3ZHpDQ3Ivd1F0QWtwRlpyM1lvUmcrQlMzVW5Wd1dO?= =?utf-8?B?d0NyUmo3Zm5GcGNiZ0R5eTBKZUR1cW01R1hGYTBTMElHZmIyK0hGb2NyL21Q?= =?utf-8?B?eU01MDFkWFBPeHVDWnhCY3JXOUtKazc4YXMzVnZ0bWhaaWRYckZuQUgwbGZw?= =?utf-8?B?blFjYjVEdEw3MC95RklmSmhWNVNUYU1lVU5kR2tuYy9od1I2Ty8waE9yZHFh?= =?utf-8?B?OEd5Vkl3cmdCTTN2OFcyRDNaa1ZFU1JkK1hMYkFpRzBKeDMzWlRrcXlrVkUy?= =?utf-8?B?dEh6R2hDMUVPSzN2Z09KdFpwc01SeGtHTEk2Uk4wYTZiU3J4cEVhdHpKTlpo?= =?utf-8?B?ZTd3V0RzMHp6Vkk1a1hBQS9veUk5WktaUnI3WUdYSER2dU9LZkF1Sm1ROUd0?= =?utf-8?B?cHovR1VXOUg4SWRKRlBMNWNtQkcyYy9Cd0N0Q01kUTNsL2dmbXBWOWtNMTYv?= =?utf-8?B?aHErZlRKRWN4dDFKMVluNjRHNGVYTHJNZE9jdVVzZVhqWG1uM0lzZ1h0aFA2?= =?utf-8?B?TWlIWmk4L1g4SEVCWXByTUNoeURabUIydFVsK0VsWnplWk5xNkhMNCtPaTBC?= =?utf-8?B?QVAvY1NzQzhoUXVKa0FPU1VzdURmdDlqMzV3ejJ2UjJIcitQMllzQno1dDZN?= =?utf-8?B?dGlCc2d0ZFpGSXhnR21yWUtGYmZwVVhGcFBCMzlpblFWc1Q4SEdrZG5GL0gz?= =?utf-8?B?NWdvelhMSUpUa3VHSWhNRThtK1l2M2VMRTYwb0lZYjVnMGczZzdUMDJtTGxi?= =?utf-8?B?amtKNm5taEVDQ1ltdTBNMGtVSGsrUjFvQWlid1RZbmpJcS9YM1FNYVF2TWsv?= =?utf-8?B?UDh5T3RuWXNSZEVHZDNXQ2h5WElmbUQzUllDOERsSU5PL3RKOFlyVzBKUElC?= =?utf-8?B?R1pwVTRzbE1ySml3RmtwMkw2blBJRkU1UTF6VnNJRXVxNFd1T0RpT3hxMEtZ?= =?utf-8?B?S3ZNNEVHS3pOQjd2anBrcnltQUFPMVpjb0ZGSjVaRnhBckNjZlFkNTFtWjdv?= =?utf-8?B?amRnS0d4dnVYRGJGSDZHTzBQMjd5TVB0c3UwMHBINkx1RzBvTFJyVkRRNzVE?= =?utf-8?B?eWpFV2lwanZ3REhwZjFPcW0vaHp2VFBVUk56VmdDOGNXVytCMm9PYU9RanA5?= =?utf-8?B?ZVZta0dnaHNYVFpVYXVSMEJFcUxXS2hlNnFJd2sxOHY4aHQ5TkxYeDh4aVRE?= =?utf-8?B?enBxZFkvMlN3VmpVeStPVDZqaGJVb1ZmL21iMzEyS3hJc0swazRzQkR0VWxh?= =?utf-8?B?Y3NOb2paNTUydHAzazF3eEh5TktTYjVMRDQ0dHkvUlJMemhPMkcyMVN1VWpj?= =?utf-8?B?ZTlzWWo3c1VKOFVYYW5jWmRNT2hTV2s4dHptdDlKWW12Y2ErQnpxQkIvdjcr?= =?utf-8?B?TkJ1TGxJWnhOWFhCamI4V0FpempaMEoxRlVlOUhGWXlhVUVnTkxzOGV3ZTZu?= =?utf-8?B?SUo0Sm5RK3ZXZmdCK21GeVNvOTdldTNEZFFsc2lMOHRmdURkMTArcHhKdyto?= =?utf-8?B?Nk83anVLRThoSlZEWHlUWExLVWxTcFZTL2xmblJIUVMxWnB1VjBWVTJVV0k1?= =?utf-8?B?WE00MU1vUGVML29XTk1pVCtFNWh6SndoTHlUM1ZBZEhIb01MZCtIVE1YY2lx?= =?utf-8?B?eHRnajFkRGFKTFNiTUo1Mi8rYkVrS3U5TnhmcnFBb21qcnFaMTNhczU4dnN5?= =?utf-8?B?dTNwdjJPQWczYXoreDYvdTgzVnVRWmdBdFN2dG1EeWNhRWpGNXNTVmdCM2JW?= =?utf-8?B?U1JjaXVSUFYvUGhEcWw2MlNVcFpPaFRoejJMZGRBbjg2ajNUZVBFYzFOSHFu?= =?utf-8?B?c0xlWWNWUzNSUWlCQ2g1dzNqclYvWU1RNkFPc2NUZktCODJtbkt0cnJhNTRs?= =?utf-8?B?dTBIZ3hOL29kY1NJeTRSZlVnOWtJSmlmUDRHbDBqV2FhRmlxT3dHQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4f98ab6-3f1d-4be1-5e2f-08da331ec771 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 07:20:52.9945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EHMioWKK01TGQ0pgYIcIWMKOPrpP9mLg5Z6los0HFCKu4W+9tcrERsPunWMSbqYXXEHXaR2uqBdUBrR2CECwZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3697 Subject line needs to be updated :). On Tue, May 10, 2022 at 05:58:23PM +0200, Marek Marczykowski-Górecki wrote: > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > by the PCI Local Bus Specification Revision 3.0 (from 2004) as > "unknown"/"no connection". Fallback to poll mode in this case. > > Signed-off-by: Marek Marczykowski-Górecki > --- > Changes in v3: > - change back to checking 0xff explicitly > - adjust commit message, include spec reference > - change warning to match the above > Changes in v2: > - add log message > - extend commit message > - code style fix > --- > xen/drivers/char/ns16550.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > index fb75cee4a13a..b4434ad815e1 100644 > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1238,6 +1238,15 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), > PCI_INTERRUPT_LINE) : 0; > > + if ( uart->irq == 0xff ) > + { > + printk(XENLOG_WARNING XENLOG_INFO would be better, IMO this configuration is no reason to warn the user. > + "ns16550: %02x:%02x.%u has no legacy IRQ %d, " > + "falling back to a poll mode\n", Could you use %pp and then pass the parameter using &PCI_SBDF(0, b, d, f)? Also we try to avoid splitting printk format strings, what about using: "ns16550: %02x:%02x.%u no legacy IRQ, using poll mode\n" TBH, we don't print a similar message if INTERRUPT_{PIN,LINE} is 0 (which also results in the console running in poll mode), so I wonder if we should extend the printing of the message also to ->irq == 0 for consistency. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 07:38:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:38:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326537.549078 (Exim 4.92) (envelope-from ) id 1nogvE-0001ZU-8u; Wed, 11 May 2022 07:38:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326537.549078; Wed, 11 May 2022 07:38:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogvE-0001ZN-5l; Wed, 11 May 2022 07:38:12 +0000 Received: by outflank-mailman (input) for mailman id 326537; Wed, 11 May 2022 07:38:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogvB-0001ZE-Ja for xen-devel@lists.xenproject.org; Wed, 11 May 2022 07:38:10 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4aaf9bb8-d0fd-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 09:38:05 +0200 (CEST) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 03:38:02 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3176.namprd03.prod.outlook.com (2603:10b6:910:59::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 11 May 2022 07:37:59 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 07:37:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4aaf9bb8-d0fd-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652254685; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0h9/SZozefDWWlzVuD+g2CNW7zGaj6DbUvEcRND6JGo=; b=gTucyNYE1KV2CSh8FRYYTLY+Fqx2+L0BJkQVYNzNsrUdrE13jhi3cszy /4hVrBuSxx8f60B7xHcJvMhng1APrq41xdKEiaxkc+SKk6hRsa9ik35CC m1WukilQGq9U3TF14YWK4tV+EAk0Oc95MPaWial2usNTWQEg51YR6RIiu o=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 71058832 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YDVnjahhomchQ0AL7X4SRGvOX161QBEKZh0ujC45NGQN5FlHY01je htvUWHSPa2NZmX9etsibIXlpkoB68SEytM2HVRkq3w0Fn8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrU4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSR1N6qSmfYBaRJ7Hyt3LZBrxp/1PXfq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWlh7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvN+PpnuDK7IApZ/b/faoP/Z9K2YO523Ua1h U/B53bCDURPXDCY4X/fmp62vcfDkCb6cIMUCryj9/RujUGTx2ocExkfXx2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4FuQg7QiXx6n84gCHB3MFRDpMdNwnssAtQTUgk FSOmrvBAidvt7KfTlqT7LqZpyi+fy8PIgc/iTQsSAIE55zpptE1hxeWFNJ7Svfr35vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:qC8hha7tNgeyoa0yGwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,216,1647316800"; d="scan'208";a="71058832" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J6DPeso0XoNlxxzTVcNZ4IRqPB4zpu+83Ws2+mlqup4wlZFWN5+15PZi9UVHiPshuN4qSnupd5qCmp59ksbFAf3nGWYpzJr0blir2jfhYCnZ8pVagLRTZT20Fh5fmhJb1EE5Wpbv+VvbuRuqtedoZ+MXdK6ux6ZEFBcBW5cnkQrU4W8kXc1W4DUa4pooYpUrZnsMqKtSD8BqUhlZKbkn7XTH5cG9Jpbh7ufaGpfDMCO3j4Dr4IN7m3rIl6x/sToDd90iNqS1D2mxhqtLSapySsy3hZ4BVOMJ4ff17kC8gKPNGUPgKDQ/+vT+tRt8pQJPJP/SfB3NAk5ffsWXtJOnGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mG3BJ2lOouiYMf/wKmYraYk0XNuInJnwvHltPzJZYhc=; b=HomKU7ups08ugzIVEU3FYt4gMwBNqC/x64Q/gXCoU/RxB0g+nQbECzvq4Xfcccul3Mj3uNWk6VwWjYcCVRhmzc/ta0KBqoxoPJczRD7Y8Ba9BCSGJV39TZs0K8SvgtzLZA+3JxReGzxHN3HqWAiqG2tlwUTqw0wQcwP0Gf0QVNOokVKI9LvBcJlP6Ij/cL4GRYCOtyP2fxDu9/7IpV+cm855V5yu6UfpdIYjic/GH92+X+bTwb7bGbLpDvmmxQksSjEeO3nw76wCKzULWa4WQd7bM7c8NVuLCEH2Yr6wxlv82p9Q8FNP/uREDUpFLHje3+OkCtRkjfP4m2YHrP6cpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mG3BJ2lOouiYMf/wKmYraYk0XNuInJnwvHltPzJZYhc=; b=tGVOVSCTq88WC9Yk5VtNALNXpr24AQ8gYJzDhDFe3Wa/ACN5im0VUgkeDFzerJYSzybKtXAjfLH+tlJvb/DC7JYfzZ4UuWTJT2+aZTeeLj5MSLFButPduF3h/MuvX8vYUwroAOBaSI3Q0YjFuy7q8M+5PVxfTJBNPaQUedxBISQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 09:37:54 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Demi Marie Obenour Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Mariusz Zaborski Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0001.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa0679f5-0644-4eea-eb85-08da33212bcc X-MS-TrafficTypeDiagnostic: CY4PR03MB3176:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zVfSGN5FYQlV7gDmKmVdhWHMczoMJkmoTV10tAAx5cWNfeqrmeFNcyi0du8DU+rEw7CsbxOemS82UiB50xn23YfruHToJWcqv8+cKTjtzfJTPOhwVlcvWayfKDctvqgAeLGgCPQ6DMk0ys9mAE7Cg18bFhjly8luwp5YPEOM40vPVOsa5tURlxo4PQtZUx8obL7pY4V9WclXMFPiO4CqwnoE3bElyc2TdF9HAoKUBFQOj+83KT8Vh6Zjky6Px+nSDO+I7zWvQQKVtBja63zS36Uyx6QwWDSCwY1+sptmdRjhDpKbu+CSbBi8UEzZe7Itvz8LNQxM10u+PcrOQhJzGpY/vB40fxDTBdfntKe5PAMGKalXhzT91KWZz7hr8r4wumcyiL+pFj/9FD9nVWHIiDQRHZuvpk2ib8uxuykhWNv/rM9x5oXkosoxNqBfkMwGHls1Ma0FiyavA7FSpm5dwIOAjIPDdka6SJKzSoRgMtr4NmpJPKPgrrzqtVMkzFrfvrw2Nsekugn2hVxheQqDL+GIOeO9UbU7qJJJCNNfN/IkfsOzeqKV6aMCpWSO2bBHCXgzKVwHsw1/GXA2P1qXfSePc7adDOVo2rIul3RjXGfYzA6NlNocD3nlQUtxDlrDkj6SznYQ1j5aJJfsSahjgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(316002)(6486002)(508600001)(86362001)(2906002)(82960400001)(186003)(8936002)(33716001)(6666004)(66556008)(4326008)(66946007)(6512007)(9686003)(26005)(6506007)(8676002)(66476007)(83380400001)(5660300002)(85182001)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVZKc1JxQUJHUEdtZUI1S1pZd01tK3dYTzFhVHhRL0tOeXlPcVdiZy9GVWUw?= =?utf-8?B?Nllib25Ea1NGckRtZTFFYStIWExLMDIzWEpwbjdZanBJSGgydjNrMzNxa0lG?= =?utf-8?B?YWVmbzExVUUwK010MGNRcmxVM3VxRTNmbGM3TmJWOUhEektiVFJVYmF3TVV4?= =?utf-8?B?SWF1MUZsdi9pRm1tWmlkbWpOZzJiWHZkMENHdVBvVU9xR3o4YkM0OHlLUlBt?= =?utf-8?B?blZDSm40WVdUNVBxN3lWWUU3bkJQQVZ0aWdYc09yV3dTR2piajMyUnBGZ21F?= =?utf-8?B?ajI4cEJCV0g3QWNXNndCR3RRcUlyWVhtWnRzYk5SOTQxQklOdjZCQ1ZVcEM1?= =?utf-8?B?TWMvWERDZmlLMkRndjZjeGZpcW1rcnZFbGcxT0VSb0FqdlRMaVprWFh6WVNM?= =?utf-8?B?YXg1K3lsazAxMDllcmFhWllhTU8zVy9Pc1VnRUI0SG9EWEtZcFNWbyt0SWx6?= =?utf-8?B?bm1ESDFPMmZWZEZQdmxVb3BuYUlmSEhOVlk0LzNNSzI4NFlnN0tDdHIrLzJH?= =?utf-8?B?c0VLS3dQNVJLVU1JVXJBaXhWcWpkUVFRbEdMMVpXbU9CUzBsWTlUV2dRMTFR?= =?utf-8?B?VFZXNVR0bnB1bDUzSXZtOVJiaDlzZVp1NVJoVU9NZzV1K2tKd3hJQ1pjYVpD?= =?utf-8?B?MjJLL01obThVWWR6bXZFbmxLbVI1MDZkcnpsR1E2WmRPcndHRllPbklCdDhy?= =?utf-8?B?RXBVdzllUWxhTHNzSWxadVdJRC96SXVmQ1RUQXpvQ1l1Lzg0dDd2R21LRmtl?= =?utf-8?B?VzdIS21xK3hORDl3dTloUjAreXhEd1pjcVdENkJJbXkvOEh4eE1ESXVvWXB1?= =?utf-8?B?ai8vUm9wZkl1cGVqU2hSVmY4SVJZMWJYVFBML3hWQW10aGk4dlZrN0w0TWVN?= =?utf-8?B?SU9ZWVpjTG5aZjFNOGxUNFY1eVJEczRtMUpLdkJHd2pIa2tscFg0UUlZRFRL?= =?utf-8?B?c0JnWVY3c01pdG5MTUpieFd4MHd2cENuaUtXckpEMDlsS2dpcXdSTDhOM1VP?= =?utf-8?B?UnFoUnR5dytzR2g1MWtGSy9iWVZGd1hiVjhidFE0M3RMcEpYMUJjRHVST0Jy?= =?utf-8?B?L0pTS2VzcU9DTnF1ODFHVkxKRkRmL0RzdWFhZWMzWTRuUWpDNU5Kdk44UUI3?= =?utf-8?B?cUt1bU54eDBiVUF6QjkzbUtZNzdRdUlVMVN4Smhxc25pMkNRTzR5dVJQVWM0?= =?utf-8?B?MFR6WmpZcmM1dElEamRiYlFHeXYvUk5FcW9TbE1ONzNqMThST0wyQXZLU0V2?= =?utf-8?B?M2RYcDFSQXp5aS9hRTc1WUNXcG1GSVpQVlZYZk9iU0ptLzcyTW9NbWhJMk8r?= =?utf-8?B?QUR6K2F1blRHaW9Lb3kxc2Q0SVdxSGpLdVRmeU4zM0JVZlp4Qk1aNjJsdEhV?= =?utf-8?B?RFlHUzUvaHJMaFpEQTZBN1k0a3V5TkZGU1dkRW5WQXRiakJCeG0vOHM2Q3Ja?= =?utf-8?B?YjZGSnBtMWFZVEVwSXlXNnYvVmp2UkVsRnYwbkQxWXR4OEppcXY2MmIwNDFl?= =?utf-8?B?UERkWUJYRzRlc2FCY1dQM3lKRHprdGVFTmpVOSt6NUUzSGx6VXVPSzM5bjZL?= =?utf-8?B?RWdremR0ZE5zcjFrbCtWbGd4RkMxZjc0cmVmTHU5YTZ0Z2grNlZnMksyZkJ0?= =?utf-8?B?QkJyRU1wc0IzWXZtUE5rTCs1aW5ZUkJmaTk4Q0NyN281OWJvWTluTFNWS0lO?= =?utf-8?B?cXduVGhGMDJXZXhoS1FKcnJhNmU3RGd5RzJwNUNCemRaZDAvWHFiZHFlc2M1?= =?utf-8?B?MWNsMjVyKzIxb0M5ZlpCMUIvckJKa0tORDJ5R3c1WmtleE5ZRTFQbVRWS1Y1?= =?utf-8?B?VXlSU1VVOGc5MTBJd0tZRE03QzZ3b0FMUEk1cjBFQkpMN25jMDlQREg3WXZ6?= =?utf-8?B?Z25acDk3WDNkWmZOaFVielZEZ3lEZ0U1akpXSkpxdWlUNkNMSjdVUFhxbThZ?= =?utf-8?B?b1NiRU5pU2RweWxEYjRQR09td2RFalRpK3doeUtzMHB2THZVRVhJNWpmNEsz?= =?utf-8?B?TWNmeVErNFRhN2pUS0ZBNU1NWUw5bjF1KzdjSmhRdnJaOEh3KzRIdnF5RFVF?= =?utf-8?B?cVRnTGtxQ0hQRWszaklqcFRzTUVlekxiVXUvbGFadkRwZzJ5VkIreFUxb1ZX?= =?utf-8?B?OTNiai8vUU51T0YvVlA4NUlqakFRdk9HWlZzWFhEb1p1NVJNSVhmVXhVclo2?= =?utf-8?B?czM5ZEpuWHBleC9pc2U4RlJrRjJKa3BEZnFnWWVkQkxnSzg1MlYrS2JaNFVW?= =?utf-8?B?ZWRCQTNscFNKdG45Y0pFckpwb0ErWkRFRnlJaVBPRzhLbWd5YnRXZDRZbTVx?= =?utf-8?B?QnBsUkxreTJYcUg5eUdYbW4vSlJ6T2hmakZwOGtqZFdkMmVJaUlQQ2RSR25l?= =?utf-8?Q?SVVg4Pntr0uB/87M=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa0679f5-0644-4eea-eb85-08da33212bcc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 07:37:59.0008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bZy857xGMMhUBRvy4sQY+OxC17ErBiTPhtZb66mMBqOJX6DKaSbfsMtr9ItaYJLWYfavnYnoHbj0kQdqwLxKBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3176 On Tue, May 10, 2022 at 12:22:51PM -0400, Demi Marie Obenour wrote: > On Tue, May 10, 2022 at 12:57:48PM +0200, Roger Pau Monné wrote: > > On Thu, May 05, 2022 at 08:30:17PM -0400, Demi Marie Obenour wrote: > > > Proposal: Check disk sequence numbers in blkback > > > ================================================ > > > > > > Currently, adding block devices to a domain is racy. libxl writes the > > > major and minor number of the device to XenStore, but it does not keep > > > the block device open until blkback has opened it. This creates a race > > > condition, as it is possible for the device to be destroyed and another > > > device allocated with the same major and minor numbers. Loop devices > > > are the most obvious example, since /dev/loop0 can be reused again and > > > again, but the same problem can also happen with device-mapper devices. > > > If the major and minor numbers are reused before blkback has attached to > > > the device, blkback will pass the wrong device to the domain, with > > > obvious security consequences. > > > > > > Other programs on Linux have the same problem, and a solution was > > > committed upstream in the form of disk sequence numbers. A disk > > > sequence number, or diskseq, is a 64-bit unsigned monotonically > > > increasing counter. The combination of a major and minor number and a > > > disk sequence number uniquely identifies a block device for the entire > > > uptime of the system. > > > > Seems fine to me, this is just an extra check to make sure the block > > device opened by blkback is the one that user space intended. I would > > see diskseq as a kind of checksum. > > Ideally, diskseq would be the primary means of identifying a device, but > that isn’t an option without more substantial changes, sadly. > > > > I propose that blkback check for an unsigned 64-bit hexadecimal XenStore > > > entry named “diskseq”. If the entry exists, blkback checks that the > > > number stored there matches the disk sequence number of the device. If > > > it does not exist, the check is skipped. If reading the entry fails for > > > any other reason, the entry is malformed, or if the sequence number is > > > wrong, blkback refuses to export the device. > > > > > > The toolstack changes are more involved for two reasons: > > > > > > 1. To ensure that loop devices are not leaked if the toolstack crashes, > > > they must be created with the delete-on-close flag set. This > > > requires that the toolstack hold the device open until blkback has > > > acquired a handle to it. > > > > Does this work with loop devices? I would expect that you need to > > issue a losetup call to detach the device. > > That is what the autoclear flag is for. It will cause the device to be > destroyed by the kernel as soon as the last handle to it has been > closed. This is why the toolstack needs to hold a file descriptor to > the device. What would happen if the backend closes the device (because the connection is torn down) and then try to open it again (because the guest has triggered a reconnection)? > > Even more, the loop device is created by the block script, but there's > > also a window between the block script execution and the toolstack > > knowing about the device, which could also allow for a leak? > > For this to work, either the toolstack or block script will need to open > the file and perform loop(4) ioctls to assign the file descriptor to a > loop device. This cannot be done by a shell script, so I plan on using > a C program to perform these tasks. In Qubes OS, I expect this program > to replace the block script entirely, as performance is critical and > flexibility less so. For upstream, I recommend having the block script > be a script that calls this C program. block scripts can be plain binary executables, so I think it would be fine for libxl to just call the executable directly. > > > 2. For block devices that are opened by path, the toolstack needs to > > > ensure that the device it has opened is actually the device it > > > intended to open. This requires device-specific verification of the > > > open file descriptor. This is not needed for regular files, as the > > > LOOP_CONFIGURE ioctl is called on an existing loop device and sets > > > its backing file. > > > > > > The first is fairly easy in C. It can be accomplished by means of a > > > XenStore watch on the “status” entry. Once that watch fires, blkback > > > has opened the device, so the toolstack can safely close its file > > > descriptor. > > > > Does the toolstack really need to close the device? What harm does it > > do to keep the handle open until the domain is destroyed? > > This would cause no harm, but it also would not help either, so I do not > see any advantages to doing it. Well, seems more complex because you need more synchronization between blkback and the toolstack in order to detect when blkback has opened the device. If this is not strictly required I would rather avoid it: more complexity just leads to more errors. > > What about disk hotplug? Which entity will keep the device opened in > > that case? Is xl block-attach going to block until the device > > switches to the connected state? > > Whichever program opens the file will need to do this. This is not trivial to implement with xl, as `xl block-attach` is a short-lived command that just populates the xenstore entries for the to be attached device, runs the hotplug script and exits after that. I'm not sure we would want to change `xl block-attach` behavior to wait until the backend has opened the device. > This could be > the program that is using libxl or the block script that libxl invokes. > I am not familiar with xl block-attach as Qubes OS uses a custom wrapper > around libvirt. > > > > The second is significantly more difficult. It requires the block > > > script to be aware of at least device-mapper devices and LVM2 logical > > > volumes. The general technique is common to all block devices: obtain > > > the sequence number (via the BLKGETDISKSEQ() ioctl) and its major and > > > minor numbers (via fstat()). Then open /sys/dev/block/MAJOR:MINOR to > > > get a directory file descriptor, and use openat(2) and read(2) to get > > > various sysfs attributes. Finally, read the diskseq sysfs attribute and > > > check that it matches the sequence number from BLKGETDISKSEQ(). > > > Alternatively, one can use device-specific methods, such as > > > device-mapper ioctls. > > > > > > Device-mapper devices can be detected via the ‘dm/name’ sysfs attribute, > > > which must match the name under ‘/dev/mapper/’. If the name is of the > > > form ‘/dev/X/Y’, and the ‘dm/uuid’ attribute starts with the literal > > > string “LVM-”, then the expected ‘dm/name’ attribute should be found by > > > doubling all ‘-’ characters in X and Y, and then joining X and Y with > > > another ‘-’. This accounts for LVM2 logical volumes. Alternatively, > > > one can use device-mapper ioctls to both check if a device is a > > > device-mapper device, and to obtain its name and UUID. I plan on going > > > with the latter route. > > > > Likely a stupid remark, but needs obviously needs to be kept to Linux > > only. > > Indeed so. I have CC’d Mariusz Zaborski to check if FreeBSD needs any > similar changes. So you know Mariusz, small world I guess, I've been to quite some BSD conferences with him. Hope you are doing fine Mariusz, long time no see due to the covid mess. FreeBSD blkback doesn't use loop devices because the kernel has an interface to read files (so blkback can open raw files directly), so I think this is all unneeded. My comment was mostly iff this is implemented it needs to be contained to Linux specific files (ie: libxl_linux.c). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 07:42:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:42:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326543.549089 (Exim 4.92) (envelope-from ) id 1nogzS-0002xt-Rc; Wed, 11 May 2022 07:42:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326543.549089; Wed, 11 May 2022 07:42:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogzS-0002xm-Oh; Wed, 11 May 2022 07:42:34 +0000 Received: by outflank-mailman (input) for mailman id 326543; Wed, 11 May 2022 07:42:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogzR-0002xa-Ki; Wed, 11 May 2022 07:42:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogzR-0000cM-JA; Wed, 11 May 2022 07:42:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nogzR-0002PD-7k; Wed, 11 May 2022 07:42:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nogzR-0007aJ-7F; Wed, 11 May 2022 07:42:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mF9t9rq/bV4iUNTCTTAsaDOfxuJ6nyyDri5AhfcTEGY=; b=Urh6CXWDEiaTEcC7ANhddclnFN 8HW8kL0RpPMxjowckzv7xd3mmDu1ue0vD9OfZt/HgAgszKiyt1AI8tviUbb42lsMVwThNeNFKDo9R SB5VzZ7FlhHvn277jjVkDipwjzwr7f+SQb87ZiYX+O1fxoiduLD6B0J8V72Hn0kAqh6k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170318: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 07:42:33 +0000 flight 170318 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170318/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 927 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 07:47:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:47:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326553.549100 (Exim 4.92) (envelope-from ) id 1noh3u-0003dU-Fa; Wed, 11 May 2022 07:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326553.549100; Wed, 11 May 2022 07:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noh3u-0003dN-C9; Wed, 11 May 2022 07:47:10 +0000 Received: by outflank-mailman (input) for mailman id 326553; Wed, 11 May 2022 07:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noh3s-0003dH-Ti for xen-devel@lists.xenproject.org; Wed, 11 May 2022 07:47:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7e1b::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e8ef22f-d0fe-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 09:47:07 +0200 (CEST) Received: from DB7PR05CA0028.eurprd05.prod.outlook.com (2603:10a6:10:36::41) by GV2PR08MB8052.eurprd08.prod.outlook.com (2603:10a6:150:75::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 11 May 2022 07:47:04 +0000 Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::d6) by DB7PR05CA0028.outlook.office365.com (2603:10a6:10:36::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 07:47:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 07:47:03 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Wed, 11 May 2022 07:47:03 +0000 Received: from e9b42a0efc62.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54985072-7917-4C71-8255-189BCCD694C4.1; Wed, 11 May 2022 07:46:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9b42a0efc62.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 07:46:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB4948.eurprd08.prod.outlook.com (2603:10a6:208:163::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 07:46:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 07:46:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e8ef22f-d0fe-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UVtr+zWMiF/qBr+UjORyc+/rIeiI/2PXFER0d/4+LfzNUAY1TDgn+ea04QM1mbMsMSxypniZYl+DfT0ZD5UBDxAKaXMP/iCLwOcZDFbLMK6Y2oTKUqOg8x95p5HXtJfSTZvD3esgDwthfZrVAkbMXfbcjKWUQMedUFtkkbwmc1txo+YNagr9ivmiLPz2BoJiUunCQ70xSI5Kav8Pl+wVjEIgzZ8fIVp+RfAo+1AHdnYnhysxgbKjzaYd/UZjbCh/h1pt/WasiO/X8Yy4cFrykM0X2AjPC/IxC2B8IxeoVCpbGaDH8eK+6ZFbYBV7nS+lwrV2TtM89rtR6aoZYZecHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WmDKFEpEozo5airMWCZhUUKlrRw+X/hfcwJb/+YHlb4=; b=YKVVThF1GsEqmYwXoEjzvA18yUxkA2M2z7MRnyy9v1AO4rhsRQ/M38t9o5N/qOmdkH/32jnDJXt4ovYgfoSErDwF6e6InYwGcCCQdWNhSQYTsQs1qFGYDby66vf+UP26th+yPh4tdaOPw3CiltsMUYhd96JXdw+ZsZlpUF+pfdFy47yDr5B8XsEI/7K6Qv7psvjYPmTsqgkDQ62MV1iBAFd8798CxdtRfsWqu7hRuNvPTSTR0RfqAgF/2Gszm9xeQAU5TzjYXYbzS6BGs6SBVwePlrxjzy63hFQqChq2pCLovST1Bd+BolgRwbAQQugEI25MonxmzoaNy0oFUgnPwQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WmDKFEpEozo5airMWCZhUUKlrRw+X/hfcwJb/+YHlb4=; b=NaTgFsYB5KdpYLwLY5Mm+4BFkxerVF10uyFnxjbsL2E+DkuMMx7LRw0ijAx9ODUErPSmahJewwSXHl3wBHqqWhjHipws5iKk5NYTGbstOUyQldZHHlBuULVz+ZigzltBdFc4Zof1dn3FFHMSm8uceQuccs2iIWBV9lRFbd3UpOg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7ab295fbf0dd03fd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njvbff0StlDUemxE7+zDbX5yaSivrFNxA12lxhjhBbAmACoPQvjfkhmxpKYRa2AtsWGJ+GXCfdh6XLpoOAhi767sD8gQYc88kinhh5ZjbxXugT432PbuP9bK+Zsjw8y0jtJCvxwVDVCh+GQrE2NFkJ7YqbT6f56y48tkZZd+KE3ggbZfSy1ZQgXyJYSYJkrEVbaBC3AAmqtSQWWF/OWKx8I6VTaQZX9CWtwW5vzFIpwtUX+WLqDBlVXJODb4kSI7wiT0RGkeJbpuqzju0Pp4Bv2DTQdT0mwjyqqWjc01XvJA6NntBdvh5hk5HORjbktNRjkiHlDmNamBBLPZLOMhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WmDKFEpEozo5airMWCZhUUKlrRw+X/hfcwJb/+YHlb4=; b=QaqOZQr8KlUUbcYjgqDfbfEY96PPvOD9QsFwQWiKtH8An9oHXuJrYB4qIoUG5F3B2AtBcBoHa3ZiSemiw7bbDtT3o3xhI2nDZqWU4pTAU9h/BiZZ1Hc+6UPnPN2xi4tRYCYBeXxydO1kPxo0ufgnglSUv5ZfPYd0ui6nJIJ2Ow1Hg3gAffnNnY7ORKsgyuxA61WTgmFQXGw1exgdmZFZid1gGajKgT4L+W0rUJ3X7JO75N8Jo5AyYMgt0veDBGXOcB1FdxeCbxbLx9QDnWiFXqpePSZby3w1CXAD81jy1l5lWySZX5q27eMSi8N/wSuRlK2vn7q8OKE5+CyqZFb/PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WmDKFEpEozo5airMWCZhUUKlrRw+X/hfcwJb/+YHlb4=; b=NaTgFsYB5KdpYLwLY5Mm+4BFkxerVF10uyFnxjbsL2E+DkuMMx7LRw0ijAx9ODUErPSmahJewwSXHl3wBHqqWhjHipws5iKk5NYTGbstOUyQldZHHlBuULVz+ZigzltBdFc4Zof1dn3FFHMSm8uceQuccs2iIWBV9lRFbd3UpOg= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBV7IqUb0ECYF0+NQ9CCVyUDtq0YVm2AgAABQwCAAP62gA== Date: Wed, 11 May 2022 07:46:55 +0000 Message-ID: <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e52333e1-0f34-473c-69f2-08da332270ab x-ms-traffictypediagnostic: AM0PR08MB4948:EE_|DB5EUR03FT013:EE_|GV2PR08MB8052:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JQ2+66Ux/aCew/pVo7IXwGEgpqvOqvYn2peHJkfN8hJVk38PcdkViOlHZA4/ybKctWEOu97vpyqBbLC0GZf/uUz+jw1iaoPDF5zdUP2me5bUaD0pJAoObH7o2z7+YZ7EvpfpnJ7T9IVPL/gkrQmgJsKrB/Uey6fBqpcN2l0MIXTSwR/w2fKPzHu8/Wc5IiebGsjN6A8O2y3W33ekMeG7OBrDAPiQ4F1yByYNIH554Yvgwm6OIemUwdL+IBl55ghWIfsIBrF3B6tnEw1z/cWfDSnRQ1SbnRCMQDQ+q2rIz0Z0mibbCWafPGBLrx2bZhrEnHoLZOKOvLbczchhKohHStZpqM6GqGl1OkOkY1y6GHzYtHBdHpZRzGDyGIsF1YNuTr6MdJfWPXjRQIKedfcA3W4VshuA/gDIep+W1DOWx11yyFR6qhJITNAjP60XCdnTd2QdQXv43nrcHcmlZW34gALzsSWsRRlF1trpPrpE47LXq8vV312vc0LW6L8BnBaPuB9l7rhivM8SMKJjt6faXNhmyg4cIxUE6jK4bESv9X3TfeEuflRHrx+yofPeXf7rOmGiTWw9OxD5dfPha2dFwvjf9G1/c+ggJ7pj6qZ2rrgH9qcsrYUfrJwZdzHzdi7UR1JT1dO9IlGtHrE9Sz8sdB//5jRYVDNcEzpeLpYA7kUEIBNu5RwXD3NB228XZFo7zpcg09r7M+/ffcksJ4vj+LNIwBLgLtjb40t7DrEdYnYwtoICwu8CCnYt3QlnOOVou6FFjGYtCUaEhRj3w2c8AQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(2616005)(6512007)(6506007)(53546011)(5660300002)(2906002)(8936002)(36756003)(66476007)(64756008)(66446008)(33656002)(86362001)(76116006)(6486002)(66556008)(38070700005)(66946007)(54906003)(508600001)(4326008)(8676002)(91956017)(316002)(186003)(38100700002)(71200400001)(122000001)(6916009)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <372833452B8F6941B4ABF64A151EE519@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4948 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ca13f316-49e4-4b55-2f6e-08da33226ba8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2hl3sIn8ApFcyCYP++ckyPLgQJQqou19x6v5J+7cI+HfjRNR1+UGhm7f3KPMvleg0dqS5WUWx46DukqXXGFo6F5b7AR/MrHfPKCtTPkMpI3G7O5wINhHG+KaVLon1QJJ/d+k7IQMZXmDfFnJVDMQwG7iow3RIv7EbmW7u0DL7tyCEZ8bLjGsBsCl2f8BfodU4uM9ZCcCg9Iao0iz6X37NpEzQynRY60u/DQ6bHBgf0gQrdFnwK3sOgeiT520Up/a4sIYnJ1RbWs+GZp3tGGCky5gDsLF5L9W2gDCnpks0oNtjG146e8Lbmy8LE8sOCZ9cnMozELWBjlBB/peCAL5G1GyIur474XeIwvLTLVaq4ZQkc31ajGCGWl7kdfBTbpXqCmwX6DKZbSTKZTzO+Th2dDwHXxpeu4arsGXr7hmjTJ2X8vIbvSTO/W4qqqbdvgTEdV1OgtWtA2VtbivvznerE5nw35StkDmCd9uQG2K/xmSxtomFGC6SRzv0KlNYjZLvt3lE0X0barhnu1yqKhced3sAXFYV/dvLYmgKkKP/IPVDAGHGNs0I1UlDTzyzIJ1kqxEAERIXM0kvPRKguDNXF2qBpxz0YRVB2BacHHKckRXYlWLhznuS7qXfCMELlVLL6rXYSf5kXjTJF2Ut82uBkXItyQzCUuYxXflmKs59OG6wh2D/7XRmCiFtvNjdPeVU07tnYaA78gVSR++ZoaXA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6506007)(54906003)(5660300002)(86362001)(316002)(8936002)(47076005)(336012)(33656002)(508600001)(6486002)(356005)(2616005)(53546011)(40460700003)(186003)(2906002)(36860700001)(36756003)(70586007)(70206006)(82310400005)(107886003)(8676002)(6512007)(4326008)(81166007)(26005)(6862004)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 07:47:03.8376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e52333e1-0f34-473c-69f2-08da332270ab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8052 Hi Julien, > On 10 May 2022, at 17:35, Julien Grall wrote: >=20 > Hi Rahul, >=20 > On 10/05/2022 17:30, Rahul Singh wrote: >>> + rc =3D evtchn_alloc_unbound(&alloc); >>> + if ( rc ) >>> + { >>> + printk("Failed allocating event channel for domain\n"); >>> + return rc; >>> + } >>> + >>> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] =3D alloc.port; >>> + >>> + return 0; >>> +} >>> + >>> static int __init construct_domU(struct domain *d, >>> const struct dt_device_node *node) >>> { >>> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *= d, >>> if ( rc < 0 ) >>> return rc; >>>=20 >>> + if ( kinfo.dom0less_enhanced ) >> I think we need to do something like this to fix the error. >> if ( hardware_domain && kinfo.dom0less_enhanced ) >> { >> } >=20 > Is there any use case to use "dom0less_enhanced" without dom0 (or a domai= n servicing Xenstored)? >=20 Just being curious here but would it even be possible to have non dom0 doma= in servicing xenstored ? > If not, then I would consider to forbid this case and return an error. One way or an other we need to solve the crash but if it is forbidden we mu= st prevent coming to this step earlier as it means the configuration is wro= ng. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 07:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326561.549111 (Exim 4.92) (envelope-from ) id 1nohBD-0006kP-C9; Wed, 11 May 2022 07:54:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326561.549111; Wed, 11 May 2022 07:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohBD-0006kI-9D; Wed, 11 May 2022 07:54:43 +0000 Received: by outflank-mailman (input) for mailman id 326561; Wed, 11 May 2022 07:54:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohBC-0006jZ-AS; Wed, 11 May 2022 07:54:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohBC-0000ry-4Q; Wed, 11 May 2022 07:54:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohBB-0002hC-Px; Wed, 11 May 2022 07:54:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nohBB-0002HC-PS; Wed, 11 May 2022 07:54:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mCKYN3OHBQPsOZk4J+kXp5z4s1empTO33HdbsQq6po4=; b=l2FyG6dw/s7X+SEkKC6Q/Gzg/0 9duJwmAUrUpnQPiDd4eihjt+T+3Wghctz6fRPwKAlgCVPCkfVqW3obI0IchKR8s5VsUeIco1FynDS i0PAmirfFY57qE1b3d14x2n1xJDrc9YTOCqGR6weC7I3E8lhikEr9Z1wI1+nTKECbL4I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170317: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2ba73a10fd79637888235cfee8110fe2a21a9f7e X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 11 May 2022 07:54:41 +0000 flight 170317 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170317/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 2ba73a10fd79637888235cfee8110fe2a21a9f7e baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 670 days Failing since 151818 2020-07-11 04:18:52 Z 669 days 651 attempts Testing same since 170317 2022-05-11 04:19:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106995 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 07:57:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 07:57:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326569.549122 (Exim 4.92) (envelope-from ) id 1nohDx-0007eI-Ry; Wed, 11 May 2022 07:57:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326569.549122; Wed, 11 May 2022 07:57:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohDx-0007eB-O8; Wed, 11 May 2022 07:57:33 +0000 Received: by outflank-mailman (input) for mailman id 326569; Wed, 11 May 2022 07:57:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohDw-0007e5-98 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 07:57:32 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00bc9897-d100-11ec-a406-831a346695d4; Wed, 11 May 2022 09:57:30 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 03:57:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO3PR03MB6712.namprd03.prod.outlook.com (2603:10b6:303:17b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 07:57:26 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 07:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00bc9897-d100-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652255850; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=buX/3xcPguYYtA/VPUoDQ0PmVIz4klk2Fn9IGEeFCVk=; b=JhEA1wCgUfEQCE2y5UyGrG2kU3lFuywNXsAYLyhAo8pbzar1AkdD0n36 sJpQ97i+fy731QlRK342oFjtpJNh2rSGVTDN6rCmf/ZJ10IBYyfAKFiP8 FX7kH5KMEbdvuH1QxLKQoeaNFCQ92IG6tNyatK9MnjdjG66ZjDQvdZBQW Y=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 73540412 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4cGJba/elmktc3h+qz/mDrUDvH+TJUtcMsCJ2f8bNWPcYEJGY0x3y jdLXWnSOPmMYjP2fdggb46yoRkO7cDXzYUyGQNsrnw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHgW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCncHtQxwsOqKWpLkYYxpXOSVyHbB/+bCSdBBTseTLp6HHW13F5qw0SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHfuMuYYwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKGAE8A7M/8Lb5UDQ41dh3p7RFOaFa8C3TuhLnmeSv yXZqjGR7hYycYb3JSC+2nelnOrGhy74cIMUCryj9/RujUGTx2ocExkfXx2wpvzRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQN47sM47QxQ62 1nPmMnmbRR0q6GcQ3+Z8raSrBuxNDITIGtEYjULJSMa5/HzrYd1iQjAJuuPC4awh9zxXDTvm TaDqXFkg61J1ZJSkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshUZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:JuS5VKqmdt5CoOfKtVU7aooaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,216,1647316800"; d="scan'208";a="73540412" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrZlElgn/EkNFMbf8vb+di4+gPPDLgBfc47Gxgdk8AVJtZmk124KA7XFkIF/mEJ4tUHVN6eROPj+sSWN7k+iJRbpi4e87uPeRf5u9gQ4nTZxT5hbZ5NyqBEG133fg355mI6JOO8o6QYszAo/8zqjN5c6o7lbufozAdy0/3QdTZc17g8+QGunq7yWPJuICfjzY4cRWg+NCHVOqFtqmJY/tRK3CDGSkO86gwD2NKUZWwUcS+3RYO4ApXpUSZ576Y+pnoRdUe6A3A29MmSzsfFJyjiEMpjIo2J5JYPaKrezz01wijKU5QX4LITtP+2b/kPJZ26mRa4KUt5Bf9u11alFFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5YG+5H5TaKV9mgCpKNyDoJBKbSuy8KSHr32Ip4JaUY=; b=AZx72kLxFmAtE5uZj/an6liFvV1y7++D1JMGniqU0MN94s/wqfGRro+lk5mhlV1Uqy5gNNI8jv/h0e9+CgP3cguBClv75jXI2ZIIjtulRY/buV/XqzVobFYBDKtepKQt/KXUvVZmwSkD5FBuneqdphmLBNiFcw3pXllTo1kmuW029sxXIgjJJYPx9cRaQ9+vjEy/serJqzUbXgHI2gxgeHthxFO+VYC0GpOXlPywVPZ0hg72104bZjzGwyZafq4X31tqzWTdSyJvLg16dUEID3QJkLtcAu/4xERCiqbGkvol8jbCZ32jjlFghC6Z0gdT/0UJ8N7aHxtHsDRt+eHEJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z5YG+5H5TaKV9mgCpKNyDoJBKbSuy8KSHr32Ip4JaUY=; b=T72mizp/cvs19UKuzAnnTCPj+KgEuBLeMYbY9y5dbR4+NWXexYqH4/UcYktlf6USsnfwsHsy6Rv2hI8h82Cnm/HbCwAKwKmiB7MnnTQB2WJSwpvny3l663tx4mHZkHcRGZZ9A0NZG0SRHuOwcLgBSzbnePjod9Gu/2vtDsHPRuo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 09:57:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v3 1/2] ns16550: reject IRQ above nr_irqs_gsi Message-ID: References: <20220510155824.1779789-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fc956bf-b5ce-4ca0-c836-08da3323e362 X-MS-TrafficTypeDiagnostic: CO3PR03MB6712:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7UapwuSujzjEVme14hFQSXP0+76GnQgcU9fjlrXeMhlO24r8v5oR8m+Aux5o+mtEc6U4YzjELMrMAekxi7dTBvSy3ZA08aeGcPa5X2WQwj7a4UnGpgCEU7u6HP33nVVj2OtapUckzclrBMAozcXfO529D+P+pZgPYosP4+2ZyYaAq/lrgDHwp+Q0qhKyL45IGm+tgZe1URrt3y0hWnjFY/w6y552klARkholcHtqmGwqVie+0XRErNKjfVwHejXz+o8xPsg8b3HISi0ysvd+Mmj64k8vQvImlUuyDyPcIPVXIg+XLgeSzKcqTfFQRdnYeYXXaWrU8aJ/aoFlKp7F9iMglwwXzSLIB8QuOPI5UNSBbjBYY7GNCOFL962fhl1i02RTjQPqLYPQxZIGl/84/upmSr9sV2BHi6xcnvkfeJ1LjkfCRTpYlwQqZfB/hyviN/OncbdsVTqnuBR0UuB1R6wxs2nMkoN9EckLmFHyO46F7GI9VFgjdxJwK+pEh4SXHXeyMYCk9N4FnLwFy71QqLz1do+WnP2I2iBBTlqz/VDBotjXXWQ8v6fWeJYrMTFjGv2aqEf9dP9U8oURasRsAXma5oLrQ1o/tdOEWItUcnDi1dOwWzQQ7SnTSqQBfyUV4o8J9mgylTryJqqf8w7Z6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(8936002)(6486002)(82960400001)(316002)(38100700002)(8676002)(6916009)(54906003)(4326008)(66946007)(86362001)(66476007)(66556008)(9686003)(83380400001)(6512007)(26005)(6666004)(4744005)(6506007)(85182001)(186003)(2906002)(33716001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWdrSUpnR1MxVGJYa1FTRFJJaVdjeUNiMmlpVUZ1TkVGRXpZUUcxeHYyMkhI?= =?utf-8?B?ck1aWGxQekV5YUIzbG14M21NSmdEWTI0QmFGSHRZdTduY2x1eVpkNkpKbDAy?= =?utf-8?B?MTVvbFMrWU9TZVhBb2tyRHNMZ3B6VGtIZC8wNEZETGdnY0hvdkVjYTNSMzBN?= =?utf-8?B?MlpQVjVZWkpEMjVVNzFsNmQydHJ1TkFlNC9BZGtuNXRXZWRSVWFzVVdsQlVV?= =?utf-8?B?M3Ewb2lIY2VVK0s3bjRZa1JneGJ5UXdUcEJQaEVXb1pNbUlyT0U1Uzh3WjFF?= =?utf-8?B?anBJTUlXVm9jTm4rWEJmNWxrcVVRNUVtUThYQ1ZKZmZob0I1RGdyT3dvaVVj?= =?utf-8?B?OFJnOGNGQTZuL2pXZDVEQnZpUGl3cE1xQlUvUkF2ei9pbjZ4Z3ZQUGRsZWFL?= =?utf-8?B?VWhTVWdIcW1BYlkyRk9mQW5LM0Zsa1l3VXVOYzFCQTQ1RnJZeGhudHhMSFh4?= =?utf-8?B?aE1xaXVUUDc4STFNRUYxNytGdjNZZTRqalp6RzcxNG5hcDFrcGpiK3ZwS3JB?= =?utf-8?B?RFV5Y0JyNmozV2c2RFo4RHVqZjBuYThKQnNRdHRRMjhhU09sQmc4ZG1CNXVq?= =?utf-8?B?dm01MzlVNU9sWlFteGFwT3FUdXBCcmI2QUZrLzM2ZmpHc3p2cWM4U21aZmJN?= =?utf-8?B?MmNUUjRmc01iaklEK1k2RHFReWxjMEdzdE9YRG8rR1luS1JQTGZVeGpNeWtn?= =?utf-8?B?NjdmUmRLclQ3NTZ4NjVUTVhHdTdJTVh4MktFQ1hLamFWNi9JeXprREF2cDRW?= =?utf-8?B?akVIOU1wNWtGc3pxS29zYWJpTDRZRGE0ZnFDWW9MRTUzQmtCd3NQQXJpN1Ax?= =?utf-8?B?b1AwNjJtQ0xWUEdaYTVZc2pQSzRvdXU3MFoxSllRZ3N4ditEYTlyYXFvbzZa?= =?utf-8?B?MDRlSzJSWEJLU1orYWM5TnJXcHBQTmQrZWRybXlVcTFzN2V6TXdKSUtqUWMv?= =?utf-8?B?NGtIUFRjeTlxM3l0TUNOdEFXNml6VzdNWmdsTmdzbFBDa2Mvd1ZkVGNOaXBW?= =?utf-8?B?a3pDZEx3Z2ZNZjRhU0lwWlRNUGRUdHJFUWRSY2Q5OUw0TWY1MC9NYURpeitN?= =?utf-8?B?N1d6UFlzVlFNYTgzVm5hbmlRb281L1lWbHF3N1pCc013cEN6MHRDMFBsWk80?= =?utf-8?B?YWpzNXphOWVJa1VpU0kzNEtxaTd2Zm1rVnBaUXJJK0FwRlhnL05HWGczTXNa?= =?utf-8?B?bXpuNXdKMEpCUkNsVFd6OVJyQUdRQkFqb24zTmFkTk8vOG5KbkRvb050bElz?= =?utf-8?B?NkRHNERyNVV4QnRGY29MSTlvM0hwQVk1VWluOFJqbnhwN0U4eWVpb1pObFFD?= =?utf-8?B?VDd6Mm1YcTk2b0pHOHNhb2NOdXZiMGlQT25POGpEY05MN1FmaXJ3VWhZMCtu?= =?utf-8?B?OWdQaFhrTWpidVI0Z3NKTzhaQVRKNEtaT2pnKy9HVmNmcjRGZy9PUTNVNG5Z?= =?utf-8?B?SkRnUlJ3L3lnRW1KNXNiaGJlTUIvbVZuaHNSSElPL0F4RExFSmxEd2FUbDFV?= =?utf-8?B?VnV3MGpuZkhmeUdkeG94SElyTXJwN3BPa3dTUERMcmYwYlJyQzg5WEtvV1Bw?= =?utf-8?B?NnRVSDA1NjF4b0s4cEhheXU2b1pvN2k5RUsyRGg0TlJGekNJam1sMHRvMkRB?= =?utf-8?B?cDVGeXBvUmExZzRZSm5rVDlZN2g0NmZJandiclVMT3ZLaTZFTUZqS1loeTQw?= =?utf-8?B?Mmk3RzNabHJiQXdIQ2F1RUhPZWZwbFZaVE9PQ3d4WnNvQmdjbHptaEZQMEkv?= =?utf-8?B?ZXc0UE9NS3JHaGhsNWloRFVpR2hLYmtwTi9TZ2pJcTZaYk8wUEtwaWNjNW44?= =?utf-8?B?SjZPNnRsK2xtUElZN2FGRm0yL1g1eWVEOUVqNEd3MW9ia0JmRTkxOWZDZzZj?= =?utf-8?B?QjdjOVhQNTRWNjBEclhCRnBRYXB6NVFVTTBjOEp0ZFhPN0c0UThwZ0NpQWxE?= =?utf-8?B?SUJtK0dlYWY3VVppRmFNbDdOSkhtY0ptL2FmV21ZWE9oWXA5YmJ5bWxiQW5P?= =?utf-8?B?cjJsenBVWFlPbzN0czM1bUo2MENUclVCRUZ1cGFocUwrYm85ZkJzUmh6R3pR?= =?utf-8?B?c20yRlU1bldUSDZjY1BGWnNpR2tUcG9QVW81RGxoZlJUTU5qL2tpTXZab3lF?= =?utf-8?B?Zms4eWhjNVdETEtBbHhSeEhsK25hNFE0RVNvYmZ0Rmo5YUNHODFVVW9vV0pF?= =?utf-8?B?U3lZYlNGenFneGdPUHlGUXc4RmlyNEUyK01Zc0k2cXhHc0JLcW05cTZJdVVQ?= =?utf-8?B?cGdzdlpjVkdnVnVJUmxSNHVidE9xUnJtOVRYOXJOWDdUQ2t3RlZ1OFUrdzgv?= =?utf-8?B?ZDNQUlk2dUZZNXdWTHQ1QjMxVlNZaDB3UlR0cXloZWtNZFBybHdUenhGU3Ro?= =?utf-8?Q?wgF9zmbajm999fOE=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fc956bf-b5ce-4ca0-c836-08da3323e362 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 07:57:25.9369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gWtCBYjcpIO+F8iC7N9BXgNmz3qKLJoNDIlZw+4vppJwyplLz+IieKglBSWfZPLOo6z5KFWCAk7QU9eKPyHe0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6712 On Wed, May 11, 2022 at 09:20:46AM +0200, Roger Pau Monné wrote: > Subject line needs to be updated :). > > On Tue, May 10, 2022 at 05:58:23PM +0200, Marek Marczykowski-Górecki wrote: > > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > > by the PCI Local Bus Specification Revision 3.0 (from 2004) as > > "unknown"/"no connection". Fallback to poll mode in this case. Forgot to comment: you should also mention that this 0xff special handling is for x86 only, other arches can use other meanings for the INTERRUPT_LINE register. Likely this also implies that the 0xff check should be protected by CONFIG_X86 (albeit I think that code is already only reachable from x86 as Arm doesn't yet enable CONFIG_PCI). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 08:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326584.549133 (Exim 4.92) (envelope-from ) id 1nohbB-00031a-Ce; Wed, 11 May 2022 08:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326584.549133; Wed, 11 May 2022 08:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohbB-00031T-9p; Wed, 11 May 2022 08:21:33 +0000 Received: by outflank-mailman (input) for mailman id 326584; Wed, 11 May 2022 08:21:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohb9-000310-L1 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 08:21:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohb7-0001v5-DZ; Wed, 11 May 2022 08:21:29 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nohb7-00026r-6i; Wed, 11 May 2022 08:21:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=cVuT8BsUmJCkpTwqIIBhTI5zdEZNHzUDxqOAo5Nra78=; b=uSn4LTxTdLWRY3sLQUzuo8UBPW qH0Rf2ez0CRe+WbempgARnDJRtHALah2Hi0wszEhbVm3ZX5QJqc6MqfOUAmzdpxYEe291KExEH3NK mlfaUsagmYg6WvaZvQQ6d3hq3XRuO6MBbw+nwM6QAql0b8y+59hEL8TxuJSO0E+1En68=; Message-ID: Date: Wed, 11 May 2022 09:21:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Stefano Stabellini Cc: Andrew Cooper , Lin Liu , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/05/2022 04:12, Stefano Stabellini wrote: > Alternatively, I also think that taking this patch as is without > alignment fix (either using be16_to_cpu or be16_to_cpup) is fine. The > alignment could be fixed afterwards. The key is that I think it should > be one of the maintainers to write the follow-up fix. Both of you are > very fast coders and would certainly finish the patch before finishing > the explanation on what needs to be done, which then would need to be > understood and implemented by the contributor (opportunity for > misunderstandings), and verified again by the reviewer on v2. That would > take an order of magnitude more of collective time and effort. I am happy to write a follow-up patch so long be16_to_cpup() (& co) are kept (because this is where I want to fix this issue so it is done for everyone). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 08:33:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:33:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326591.549144 (Exim 4.92) (envelope-from ) id 1nohmG-0004UZ-E2; Wed, 11 May 2022 08:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326591.549144; Wed, 11 May 2022 08:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohmG-0004US-BG; Wed, 11 May 2022 08:33:00 +0000 Received: by outflank-mailman (input) for mailman id 326591; Wed, 11 May 2022 08:32:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohmE-0004UI-AW; Wed, 11 May 2022 08:32:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohmE-00027J-7u; Wed, 11 May 2022 08:32:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohmD-00048q-NT; Wed, 11 May 2022 08:32:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nohmD-0004aa-N2; Wed, 11 May 2022 08:32:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lwg33ilBDF9uP1tmNFTVJ2fadEP1Epk6UfNK57xk+0s=; b=eAEKhiqdaLClQL/FI/7+7nK2wA eVmJ+yUc4QCcg7L5QL1gM0XgzOt/dWODS0VxnZ9NCDcjB+TSX7nIZrVZWN0Dw30hvWCoqMDGnBHmN zQMKZNCwwHmA3VKmLzWpObxYCs9qnBSWFWlz4WZtK/XkCloXZ1dxc2RPi88CNuUzCBzU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170319: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 08:32:57 +0000 flight 170319 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170319/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 928 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 08:34:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326599.549155 (Exim 4.92) (envelope-from ) id 1nohnj-00054W-Rk; Wed, 11 May 2022 08:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326599.549155; Wed, 11 May 2022 08:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohnj-00054P-OM; Wed, 11 May 2022 08:34:31 +0000 Received: by outflank-mailman (input) for mailman id 326599; Wed, 11 May 2022 08:34:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohni-00054J-Vc for xen-devel@lists.xenproject.org; Wed, 11 May 2022 08:34:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohni-00028O-OI; Wed, 11 May 2022 08:34:30 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nohni-00034p-Ij; Wed, 11 May 2022 08:34:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xsFGJDTRelUy2YDMXuTA7EDuToFbqqWaQ7fvTGFMsjU=; b=mhC8Rt0SpsVYzQVkQYLThNJCf9 V83CNNM/5AgLLujn33xl5uD4mxBg8ig/ivX5flSY9DUSN62hhLqP5LMNNgpl00ccxQcXDC1Rv9/lt jdVohaxGM8MmeJsMA9//tNsbV8M9wlexRv8gx+2h5WhayDe2nMw4KE1qlmculk8wGFIs=; Message-ID: <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> Date: Wed, 11 May 2022 09:34:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Please configure your e-mail client to send in plain text. On 11/05/2022 07:30, Lin Liu （刘林） wrote: > Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap > On 10/05/2022 11:15, Lin Liu wrote: >> Update to use byteswap to swap bytes. >> >> No functional change. >> >> Signed-off-by: Lin Liu >> --- >> Cc: Stefano Stabellini >> Cc: Julien Grall >> Cc: Andrew Cooper >> Cc: George Dunlap >> Cc: Jan Beulich >> Cc: Wei Liu >> Changes in v3: >> - Update xen/common/device_tree.c to use be32_to_cpu >> - Keep const in type cast in unaligned.h >> --- >> xen/common/device_tree.c | 44 +++++++++++++++--------------- >> xen/common/libelf/libelf-private.h | 6 ++-- >> xen/common/xz/private.h | 2 +- >> xen/include/xen/unaligned.h | 24 ++++++++-------- >> 4 files changed, 38 insertions(+), 38 deletions(-) >> >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index 4aae281e89..70d3be3be6 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, >> if ( !val || len < sizeof(*out_value) ) >> return 0; >> >> - *out_value = be32_to_cpup(val); >> + *out_value = be32_to_cpu(*val); > >> This code has been taken from Linux and I would rather prefer to keep >> the *cpup* helpers to avoid any changes when backporting. > >> diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h >> index 0a2b16d05d..16b2e6f5f0 100644 >> --- a/xen/include/xen/unaligned.h >> +++ b/xen/include/xen/unaligned.h >> @@ -20,62 +20,62 @@ >> >> static inline uint16_t get_unaligned_be16(const void *p) >> { >> - return be16_to_cpup(p); >> + return be16_to_cpu(*(const uint16_t *)p) > >> I haven't checked the existing implementation of be16_to_cpup(). >> However, this new approach would allow the compiler to use a single load >> instruction to read the 16-bit value from memory. So this change may >> break on platform where unaligned access is forbidden (such as arm32). > >> } >> >> static inline void put_unaligned_be16(uint16_t val, void *p) >> { >> - *(__force __be16*)p = cpu_to_be16(val); >> + *(__be16 *)p = cpu_to_be16(val); > >>> Why did you drop the __force? > > Google told me __force is used in linux kernel to suppress warning in sparse, > https://stackoverflow.com/questions/53120610/what-does-the-attribute-force-do > Is sparse also used in xen? I am not aware of any use of Sparse in Xen, but it would technically be possible. However, my point here is more that this change seems to be unrelated to what the patch is meant to do (i.e. switching to byteswap). So if it is unnecessary, then it should be dropped from this patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 08:39:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326607.549166 (Exim 4.92) (envelope-from ) id 1nohs7-0005kj-Cq; Wed, 11 May 2022 08:39:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326607.549166; Wed, 11 May 2022 08:39:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohs7-0005kc-9J; Wed, 11 May 2022 08:39:03 +0000 Received: by outflank-mailman (input) for mailman id 326607; Wed, 11 May 2022 08:39:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohs6-0005kW-BS for xen-devel@lists.xenproject.org; Wed, 11 May 2022 08:39:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nohs4-0002Dd-BW; Wed, 11 May 2022 08:39:00 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nohs4-0003O1-5X; Wed, 11 May 2022 08:39:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kgUC+Rs5Vn5//va/tKS75tf+yp0C6rGOJgWh8QYITi4=; b=Xr3imEWVCzvuP/UvQBnIu+zf+h JvON1wVg+RWHIA5Xk/g0CqNYcgjVEGd7VpJyQUxjhwvrtyQkoO4EI/HeYrhoW2oUyb4FvAJeXRnRh h/e5jdkal/POSzrxC22Z3UTVROePRwCfr1nUeOK3KAhVxdZM3bobUwTdmV5NPkJMSiQ8=; Message-ID: <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> Date: Wed, 11 May 2022 09:38:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Bertrand Marquis Cc: Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> From: Julien Grall In-Reply-To: <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 11/05/2022 08:46, Bertrand Marquis wrote: >> On 10 May 2022, at 17:35, Julien Grall wrote: >> >> Hi Rahul, >> >> On 10/05/2022 17:30, Rahul Singh wrote: >>>> + rc = evtchn_alloc_unbound(&alloc); >>>> + if ( rc ) >>>> + { >>>> + printk("Failed allocating event channel for domain\n"); >>>> + return rc; >>>> + } >>>> + >>>> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; >>>> + >>>> + return 0; >>>> +} >>>> + >>>> static int __init construct_domU(struct domain *d, >>>> const struct dt_device_node *node) >>>> { >>>> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, >>>> if ( rc < 0 ) >>>> return rc; >>>> >>>> + if ( kinfo.dom0less_enhanced ) >>> I think we need to do something like this to fix the error. >>> if ( hardware_domain && kinfo.dom0less_enhanced ) >>> { >>> } >> >> Is there any use case to use "dom0less_enhanced" without dom0 (or a domain servicing Xenstored)? >> > > Just being curious here but would it even be possible to have non dom0 domain servicing xenstored ? You can build Xenstored against mini-os and configure the init script to launch xenstored as a domain. > >> If not, then I would consider to forbid this case and return an error. > > One way or an other we need to solve the crash but if it is forbidden we must prevent coming to this step earlier as it means the configuration is wrong. I think this should be checked when parsing the configuration. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 08:47:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:47:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326614.549177 (Exim 4.92) (envelope-from ) id 1noi05-0007Ai-7F; Wed, 11 May 2022 08:47:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326614.549177; Wed, 11 May 2022 08:47:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi05-0007Ab-3B; Wed, 11 May 2022 08:47:17 +0000 Received: by outflank-mailman (input) for mailman id 326614; Wed, 11 May 2022 08:47:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi03-0007AV-Km for xen-devel@lists.xenproject.org; Wed, 11 May 2022 08:47:15 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0616.outbound.protection.outlook.com [2a01:111:f400:fe05::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f474ac31-d106-11ec-a406-831a346695d4; Wed, 11 May 2022 10:47:14 +0200 (CEST) Received: from AM6P195CA0029.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::42) by AM0PR08MB3427.eurprd08.prod.outlook.com (2603:10a6:208:d6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 08:47:12 +0000 Received: from VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::cf) by AM6P195CA0029.outlook.office365.com (2603:10a6:209:81::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Wed, 11 May 2022 08:47:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT020.mail.protection.outlook.com (10.152.18.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 08:47:11 +0000 Received: ("Tessian outbound 78191104f1b7:v118"); Wed, 11 May 2022 08:47:11 +0000 Received: from 1751ae4f6d90.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DDE52F69-F5C7-425D-A298-71D7B4062B44.1; Wed, 11 May 2022 08:47:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1751ae4f6d90.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 08:47:00 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM7PR08MB5415.eurprd08.prod.outlook.com (2603:10a6:20b:10d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 08:46:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 08:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f474ac31-d106-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IsIPO0N/v/ZxN8X4R4HFMZjxAkdV03nAo+oyJ32ERjlBvx6RUSEvvRnrddyBjhrb5Zc86J2fHgQDYOEz/4sYH/MwmU8xOLv5EUMBQkt1IGGYDfTNV/R8MYKWbAdlzDX6V4puulAFz0ie0NZ/NgFksVO8V+WGbRyvDPtlzNXgqU3fs0WHq3KC5OEBOK5kmVM8f1zCSXgOeLkgltwHPgm931dRB/teNQYtfyRJQyCAyxkDoj7poPD3TT4nwj069FFmQQKcZfBHR6fubo9duLJKImqA3JpcesaBhArbWmvsHdAnp6nUAf6s17nVQQ7AdbcRzW7ClTzKFKXxCpK+np/kAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wp8b2zNe43K5xxeta2aFqymt5LfwrsDjOUZBTj5Zun4=; b=gBGsi+dOgVYgFk4LXac0o/g1C7Rr56HkHWfys7W0Av2VLK+WF/xe0llbsUJF7cP5eIFpwfeBc/oAFwr3BPDvO0cvmpXEACObZ3U1cxqeYDdj8VqR+qBNa6vK7J5vfheYGqWaNnjIzM63binY/LkqiIiZJ5nsoNCZ0lOmKyDItCNZolgPk2JrmAeLPgHsywoRRgVEvJGGLUGf/Mv6YmOY7j4cFQXhe+2L4mOV+5jtaPTaE9QyME0GYGGffamlArrxeZq33UQsg22d1INNfCz7DnC4zx2fFmsIxjYqaBe7rJ69qclKu2KgAnuY+EjfwA3Zomo7/BGPFY4sE+6CP12R1g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp8b2zNe43K5xxeta2aFqymt5LfwrsDjOUZBTj5Zun4=; b=53z2B8NZ8Q+kVwhBX82NoKg1uhQhB1p9m7v2FsHUe4SkenvyOSfOeElxC86fH9v04muUPPVDR9jppPGE8CIsoWYhMS/cf+n5CWZwKeZOBG4wBDF/1+W4tER5wVMv8eoIQW269Uu7VRuY7u3lzI0md6BDj7yhdmTpviL/YZtvp+M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: eaef4afe11ba1b4c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqPK3TJDm5QN9xArOcxVXbDi8VKEWhJbnJ473xuL8C7S/6d5TJNwh4U6FU0Cn16P0+goww0THMiZMGv8kuq4rxaAdmcUcHo4AZaC+CULUUvBKP0I+s9vQYDmZSlceQrBi0+doKlC2RAvia8y0SRfJzfw5ER6q3mEkrGSeCogjAxdZgCCuBKJ2CNE9jEpiUyeC9MLlZW0ZhQDNfqm1oichFl0UNrJ84C5XQ76kxrvFHiWx2A2+yCkLgg6emDN/PhAMe/T269lzlG8LAMLPQhHBLXVPvAKl2zPoxHZrNF0vx02eHcR2bXPgfvCGH3kDUKdHcFiNGkq9WwlDnbb/Y1Ttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wp8b2zNe43K5xxeta2aFqymt5LfwrsDjOUZBTj5Zun4=; b=XMnhZIsOc+dZsF7dQcLNESYBCwsnS48j/5tEi5yBldxOpep1e45FPuIJAd+ZzyMdDZu1Sx25fNC8RUg+rXsryP1yoXuiI62249xR6Fqxt1xscX0kWY0t/31iLtMDAPfC6RyU5SpQjFgzveqlFcmFoWnLxpj2kFY28UGMGL6nkdvr2x8bwR0GY68MLatLMl4qvACIHWFmIcdbQhFfAj7zzwtyYMLVwMKkGrCSkIRtFJH6CALUV49EKsFoIp6hHwhD9MPbMp2kjI5wE2bEtzkMeVGSqZ/8B8w60CBT/fsdUQIMzLa0aD2RvMljRa5SSCrF67wwdRrMiLG6wWoIrDW5nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp8b2zNe43K5xxeta2aFqymt5LfwrsDjOUZBTj5Zun4=; b=53z2B8NZ8Q+kVwhBX82NoKg1uhQhB1p9m7v2FsHUe4SkenvyOSfOeElxC86fH9v04muUPPVDR9jppPGE8CIsoWYhMS/cf+n5CWZwKeZOBG4wBDF/1+W4tER5wVMv8eoIQW269Uu7VRuY7u3lzI0md6BDj7yhdmTpviL/YZtvp+M= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBV7IqUb0ECYF0+NQ9CCVyUDtq0YVm2AgAABQwCAAP62gIAADosAgAACPoA= Date: Wed, 11 May 2022 08:46:59 +0000 Message-ID: <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> In-Reply-To: <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7e8b2900-5d9e-4c6b-b722-08da332ad73f x-ms-traffictypediagnostic: AM7PR08MB5415:EE_|VE1EUR03FT020:EE_|AM0PR08MB3427:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gjwHmQzUAY88ZtiPLyveN4GZTRzogayvYkuBlRBQg3jdZmdTQLKn7nAB+0RUd0NevKLh2xtDAk90XMkg3AyPv6MfntsysQG2Uzhg1UHRZXb0GVA7MuuFrlf1f5PaPAq8qbR4/lbggXKLILSf25nUGYcLF1EKWAPxIyaMsxE7++LwGQF4I9SOyK1MuUwMgRhHQZCji57NvUMAQAkL57S5+FXsfrTQYgCoRQM9XdkfsYc/IU7vWZq6aLs5rZEW14SEj2JLB57BTH5L58CXtAFNam5Qs0M1vNwKkN0UwR+/rzqS7sGxCijHOIoRLU95t37GCwGhzLOn5J7XYT+fH81GGs83KGyRu25/tRPKysAnZqQu5PtR4rRMhRJnr/kN6eyV/WQzqX4Vt8t4XYbJzMhl6n2jjMf0znrSB2q6Zck+ZTTz8HeuNQDAKkzo635vinVpkkybhff5xt83QfF29PYpdjf6+jnC7vrCX7rmKIC2dRNlunSwGMNwp/WOhOdWU14PAD0DDfP9XrN0iaHLeBsQWhK/aRkubcSXjCdY1gMWmrCXl48pqyeF0CVchq4mRkcLVGsfFgsdnyF1vj14DBJad+DY9NEtWa2/nDQ2DsYrY+qtJpQs8/j+qb5lp5DUyFiAp581hk/rxPn2vL82cEoD+YEhJMI+QTM+OVDS9jftQbpMEJ0k20flXQGb9CWm9MjMOcu7Rim2t3QCcaDfxhTx8I2OPy1lwkrveXcrR/gKAepKO53F/jUeystv8FPvdKmRLz7T4HbqtPICUXqu+mzRcA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(86362001)(6506007)(8936002)(6486002)(33656002)(508600001)(5660300002)(2906002)(53546011)(83380400001)(6512007)(38070700005)(26005)(38100700002)(2616005)(122000001)(186003)(54906003)(66946007)(316002)(76116006)(66476007)(66556008)(91956017)(66446008)(64756008)(6916009)(36756003)(4326008)(8676002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6E4B5D7323D95243BEF62C9EDC1B45E6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5415 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6abd311a-1f5b-4ed8-69e1-08da332acfd7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 85qOLI4qGy54rfWJMkMGzvfgQqtL+9daJty6Xf+W7i7EeXmuQtG73kvQmm8TBckgSFCflIQGPHnZNOHPZPOvvJsXzg3GjsCTYlzReItZ0WputkTvHXHVZZuIKDruorFOd4asSZ45R/iNjHlzfpHijarq8JZv1C28o2N2SeJOeA4L9tlNaXlbtXlsKKH+91JrJRW0yGLHNUzlo9IXJfEGW+H2DwKNHiHFbWhIU2XulJI/hbzpovsro59xIOFhcI1EABXMAbSHAzrhbyhipUIluYC+5pd2sSlkm/ZG3xra41QJJzAUuAXXYWjeVexb/F+BXoVxIaxALxO5Rr6cFvLqIM9J86yEnip8oZAl8K3zLcDsr0j6/1MeWA6Nq6nbsB34iR1tOBqDd5hkkxvCBLVrubHgjsxqOk3owJ8PaRzTffYTR/7Pvcj3eKq9ngkyaoUjsfzvtUn5dTVVoSFiVuzkiJIFkJ0T/P0QikJmoTrA3xJUMVzKRitl0MwGJbeXmn/2myDxQnmVEEkXgTWNN1vQB9HDTsiUKeQQ6RaZfNk1g8H7AT0wNBKSth7Jlq+GN7Q7Ri9FCbBCBrpTYD3OU5S3bPfPbKmmZE1ymqDS+8VJ2aj7CShkcAbMgN5+7VLvH+has34/HnBLn/YOeRm8YoycxudWm6fkMg3B8C6oylrN2C3/GpZO3lX9yugzv1CjsbYEx1PlcDc/0jGvL6kpe/v6PJ74IMHdRS7hM0FJ6Lrl5PkC9zD3pZApYW8kfmKxIUQi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6486002)(36860700001)(33656002)(508600001)(6862004)(40460700003)(8676002)(81166007)(70586007)(86362001)(4326008)(70206006)(316002)(2616005)(6512007)(5660300002)(356005)(26005)(54906003)(6506007)(53546011)(186003)(47076005)(336012)(107886003)(2906002)(83380400001)(82310400005)(8936002)(36756003)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 08:47:11.8103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e8b2900-5d9e-4c6b-b722-08da332ad73f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3427 > On 11 May 2022, at 09:38, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 11/05/2022 08:46, Bertrand Marquis wrote: >>> On 10 May 2022, at 17:35, Julien Grall wrote: >>>=20 >>> Hi Rahul, >>>=20 >>> On 10/05/2022 17:30, Rahul Singh wrote: >>>>> + rc =3D evtchn_alloc_unbound(&alloc); >>>>> + if ( rc ) >>>>> + { >>>>> + printk("Failed allocating event channel for domain\n"); >>>>> + return rc; >>>>> + } >>>>> + >>>>> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] =3D alloc.port; >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> static int __init construct_domU(struct domain *d, >>>>> const struct dt_device_node *node) >>>>> { >>>>> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain= *d, >>>>> if ( rc < 0 ) >>>>> return rc; >>>>>=20 >>>>> + if ( kinfo.dom0less_enhanced ) >>>> I think we need to do something like this to fix the error. >>>> if ( hardware_domain && kinfo.dom0less_enhanced ) >>>> { >>>> } >>>=20 >>> Is there any use case to use "dom0less_enhanced" without dom0 (or a dom= ain servicing Xenstored)? >>>=20 >> Just being curious here but would it even be possible to have non dom0 d= omain servicing xenstored ? >=20 > You can build Xenstored against mini-os and configure the init script to = launch xenstored as a domain. So dom0 is not mandatory or should mini-os be started as Dom0 for this to w= ork ? >=20 >>> If not, then I would consider to forbid this case and return an error. >> One way or an other we need to solve the crash but if it is forbidden we= must prevent coming to this step earlier as it means the configuration is = wrong. >=20 > I think this should be checked when parsing the configuration. If dom0 is mandatory yes, we should still make sure that this code cannot b= e reached so an ASSERT would be nice here at least in case someone tries to= activate this code without dom0 (which might happen when we will push the = serie for static event channels). Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 08:56:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:56:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326622.549188 (Exim 4.92) (envelope-from ) id 1noi9O-0000Fx-9Q; Wed, 11 May 2022 08:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326622.549188; Wed, 11 May 2022 08:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi9O-0000Fq-6Y; Wed, 11 May 2022 08:56:54 +0000 Received: by outflank-mailman (input) for mailman id 326622; Wed, 11 May 2022 08:56:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi9M-0000Fg-Fi; Wed, 11 May 2022 08:56:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi9M-0002YS-CM; Wed, 11 May 2022 08:56:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noi9L-0004gA-VP; Wed, 11 May 2022 08:56:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noi9L-00034o-Us; Wed, 11 May 2022 08:56:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pWP5g5OJBVKQdZwXwV4gva2LSH8zINCQPEHxGi+16NU=; b=GSEsWAnB2zulnSzl6DiMsq1oag iPG8VbGPhHy9V3mNO/NdfvCAIsiARoU43USIRWO5y+LydIWfpJU5+WO3CcCGr0174qT/pg0S01cwT LKT9wLqwG7sbuyE+YJZY2L52kJBOTYDhdes0Rh5kPX5Lr+ie+n9qKU7btjN9hV65DZU4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170314: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 X-Osstest-Versions-That: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 From: osstest service owner Date: Wed, 11 May 2022 08:56:51 +0000 flight 170314 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170314/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail pass in 170307 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170307 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170307 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170307 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170307 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170307 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170307 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170307 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170307 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170307 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170307 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170307 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170307 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 baseline version: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 Last test of basis 170314 2022-05-11 02:14:01 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed May 11 08:59:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 08:59:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326630.549199 (Exim 4.92) (envelope-from ) id 1noiCC-0000tT-Og; Wed, 11 May 2022 08:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326630.549199; Wed, 11 May 2022 08:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiCC-0000tM-LA; Wed, 11 May 2022 08:59:48 +0000 Received: by outflank-mailman (input) for mailman id 326630; Wed, 11 May 2022 08:59:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiCA-0000tC-W8; Wed, 11 May 2022 08:59:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiCA-0002ah-V6; Wed, 11 May 2022 08:59:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiCA-0004ir-GI; Wed, 11 May 2022 08:59:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noiCA-0003eY-Fp; Wed, 11 May 2022 08:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SudhzE9Cqq96mtUgPGq7yJMYB8hPPduZ1TEyVivIcl4=; b=DkGKV3iEBSuou6F3KdCu0tL1iK +UcxdICZgNbgbLpkcYotMSvFLMWbnLwW9LvHUzLSXRiQvHyHpTkas2cZLlV3RFD/mOZobYrv25hkl L6ze8VJH/WvZBRwBr3cN8FbX+CWbBMLPmqtdQOqDl0xixlmXc3KvvoC3LM7c7By/UMyU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170320: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9dd964f5e5c5595a1acd5eb438fb088327db86fa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 08:59:46 +0000 flight 170320 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170320/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9dd964f5e5c5595a1acd5eb438fb088327db86fa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 929 attempts Testing same since 170313 2022-05-11 01:56:56 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6294 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 09:10:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 09:10:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326641.549210 (Exim 4.92) (envelope-from ) id 1noiMO-0003AO-Pm; Wed, 11 May 2022 09:10:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326641.549210; Wed, 11 May 2022 09:10:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiMO-0003AH-MD; Wed, 11 May 2022 09:10:20 +0000 Received: by outflank-mailman (input) for mailman id 326641; Wed, 11 May 2022 09:10:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiMO-0003AB-3v for xen-devel@lists.xenproject.org; Wed, 11 May 2022 09:10:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiMM-0002mk-1W; Wed, 11 May 2022 09:10:18 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noiML-0005WV-Rf; Wed, 11 May 2022 09:10:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=j11Dq/WrUFMoA2Y1ecSndBRqHAFGHN8tJWlvCyxpmck=; b=rnf0i89LQ7qnzFGjic7UANfTxr DlSLCKpO6IdQ4ZVfHKAYmLBlrFwNGx8bMFA1mswdxrqcxgHtoYWJ/WH/z/gfpg+nGyFNoqE2Ad/Dz fh+KwAu4Ws/H1CeTxF59kZpdVruh6vZku8rRB158O5/nwYKJ65+LMgwWtwOY8jCy2uWg=; Message-ID: <34b790af-c56a-26c7-e218-7961023b8605@xen.org> Date: Wed, 11 May 2022 10:10:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Bertrand Marquis Cc: Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> From: Julien Grall In-Reply-To: <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 11/05/2022 09:46, Bertrand Marquis wrote: > > >> On 11 May 2022, at 09:38, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 11/05/2022 08:46, Bertrand Marquis wrote: >>>> On 10 May 2022, at 17:35, Julien Grall wrote: >>>> >>>> Hi Rahul, >>>> >>>> On 10/05/2022 17:30, Rahul Singh wrote: >>>>>> + rc = evtchn_alloc_unbound(&alloc); >>>>>> + if ( rc ) >>>>>> + { >>>>>> + printk("Failed allocating event channel for domain\n"); >>>>>> + return rc; >>>>>> + } >>>>>> + >>>>>> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; >>>>>> + >>>>>> + return 0; >>>>>> +} >>>>>> + >>>>>> static int __init construct_domU(struct domain *d, >>>>>> const struct dt_device_node *node) >>>>>> { >>>>>> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, >>>>>> if ( rc < 0 ) >>>>>> return rc; >>>>>> >>>>>> + if ( kinfo.dom0less_enhanced ) >>>>> I think we need to do something like this to fix the error. >>>>> if ( hardware_domain && kinfo.dom0less_enhanced ) >>>>> { >>>>> } >>>> >>>> Is there any use case to use "dom0less_enhanced" without dom0 (or a domain servicing Xenstored)? >>>> >>> Just being curious here but would it even be possible to have non dom0 domain servicing xenstored ? >> >> You can build Xenstored against mini-os and configure the init script to launch xenstored as a domain. > > So dom0 is not mandatory or should mini-os be started as Dom0 for this to work ? In order to allocate the event channel, you need to know the ID of the domain where Xenstored will run. Stefano's patch is relying on Xenstored to be run in Domain 0. This would need to be updated if we want to run it in a separate domain. > >> >>>> If not, then I would consider to forbid this case and return an error. >>> One way or an other we need to solve the crash but if it is forbidden we must prevent coming to this step earlier as it means the configuration is wrong. >> >> I think this should be checked when parsing the configuration. > > If dom0 is mandatory yes, we should still make sure that this code cannot be reached so an ASSERT would be nice here at least in case someone tries to activate this code without dom0 (which might happen when we will push the serie for static event channels). I am fine with an ASSERT(). Are you saying that dom0less_enhanced will be set to true for the static event channel series? If yes, then I think dom0less_enhanced will need to be an enum so we know what part of Xen is exposed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 09:18:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 09:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326649.549220 (Exim 4.92) (envelope-from ) id 1noiUc-0003vr-RO; Wed, 11 May 2022 09:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326649.549220; Wed, 11 May 2022 09:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiUc-0003vk-OO; Wed, 11 May 2022 09:18:50 +0000 Received: by outflank-mailman (input) for mailman id 326649; Wed, 11 May 2022 09:18:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiUb-0003ve-QB for xen-devel@lists.xenproject.org; Wed, 11 May 2022 09:18:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d6965f0-d10b-11ec-a406-831a346695d4; Wed, 11 May 2022 11:18:49 +0200 (CEST) Received: from AM6P191CA0074.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::15) by AM6PR08MB4881.eurprd08.prod.outlook.com (2603:10a6:20b:c8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 09:18:38 +0000 Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::a0) by AM6P191CA0074.outlook.office365.com (2603:10a6:209:8a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20 via Frontend Transport; Wed, 11 May 2022 09:18:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 09:18:37 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Wed, 11 May 2022 09:18:37 +0000 Received: from 0ec2e36efa4e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E81E145-A3E0-40B5-992C-6C732D4066A8.1; Wed, 11 May 2022 09:18:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ec2e36efa4e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 09:18:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4070.eurprd08.prod.outlook.com (2603:10a6:20b:a3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 09:18:25 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 09:18:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d6965f0-d10b-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aQzDafCxsqlVqbVQ/V/8SCQdcoHqPW1cdxlhk8FOhhSCDTaBS9wJ8RXFJqeMaZJal5V6OPBxp3L2cIfJbP9ywRBkihDseK+wWxyeI7n5lnKAC1h+GLnG+ybLNSFZ4laNddidOs5u/GTRgSgrcDZl8LvJu59IJRMztgsMBJ6DAxQUrY1PZXwVmWLrDW7H2ovkGZTGAyzT+qkI42a6F83yOVoJp3n+p9DudSqVCRvm7bYr4qB8OeetyjPzax/b3nyFJykaACZ0UhZjmogNGfGjqwdWmFmopRBj/TRDY4O/Rjvhf2lHtl3OwJ0OA4pt4i4qBc2RekcoP3owgdzD/2xuxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePBCqNEeabGU59QAtnTCYsTsnYeubd91RiznUWsbB58=; b=cU5LHTG5BjAKcs/uSfftMDbnAN+yhrO7LS+v5ArIv274pzZf99aTdpT/yy6wAwEFV76lGnIC3DqzMvZOwzOUcEayI14rTT57rUG6o0De++v+6bt9gQToT+UmSz0vgu3h8Za4icdDtIpnxueTdob2ld9nkOFlbm3NoMCB6rAiMTmLXfoMa723uU5D80FiKuEyg/f8W+c1PPEkaHy77c8wA/7gzmGbzNjXAZFwRdgqa2u403zt6diBnhiD2vJDSWicp+R6ZuZgkkBkG6uz9xX2ZpoHMUJSk5zuUd24kvOrMR+Ig8YUjivp+GRJ/o/nRwBHNSVdQ4b3JTvJorNrbXKDUQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=temperror (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=temperror action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ePBCqNEeabGU59QAtnTCYsTsnYeubd91RiznUWsbB58=; b=fUJEu3zkIcB5WQ+1n9ZHZePDRFZHNyBN0ng4OWuPRbQFf4+/Y9z8D83OPb4JCbbBBVXHO1+/TDaY3LoqlVjzc8svvTy1EqP+D/oHjpwFfPoZ4l8WJgTJc7ydxNaF6UFKgOUiB2nYjmDOS2YskyVV9fdPRXHPNbtei2u9mtyI3mE= X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) X-CheckRecipientChecked: true X-CR-MTA-CID: 9b952033f3314267 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZY/r5DakMKwYJEXNEwLm09tDCqB199hkOO3QRiB/hDtdGQ01l/LMalzHdUn8uNa2YXxVsKe3snnGDJq88Jt2CkhCkWgZAlvS7KdHp+9UmHBWlrV11qWWJ7BMyV37KORInxL1jx2wmi97ImKtYkOJ0VuivbmSqNy274CufjHpR0toU4pvu6842c/ESdK6WvzPwS6ZS96xBFi7KMVOwczhjq1PfV48uiPfTKBH6R2xAJQbHM5hL/Qvtc6LsZNje7LtHT0dt6pHO7l+sSsVln0mhwHUQZ1dI1plhcW3OM8yTTuvkpi62LAWS5ChmZp3VFxgWtWQogIblzVLL6UylCwTDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePBCqNEeabGU59QAtnTCYsTsnYeubd91RiznUWsbB58=; b=bbL5LIkLffVQJo+b8G2C0ZXobNT3gqWWFcbW2yJwfmUv2AnMAgTNf8OvRmlL9ISxgiSDAFO17YFtgQLV9jgi4LmXANnKqNQV/dEM0D+sHvCQ7mJLrJw09N2YCra97BkZrZCy+eHl5rfsGu5XN2pZI7/FaGeA5iDcKJY0WfZrdTY5Ff2/tdgjjjEnVn4sOKAGwbiP3PX2Cocb3YLRahaxyqaDmQE6HCnCr4EMKrgCNYieSCRgXAqsxdlazkMoXND32y0JPs+FpK4oi6eNKr1HrAKa986wO98OvdAfZkIMeZMgRj1/Qiwq8e6kCwzRWnaZ4J+Ve9tcGHeTEkzyEfIA5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ePBCqNEeabGU59QAtnTCYsTsnYeubd91RiznUWsbB58=; b=fUJEu3zkIcB5WQ+1n9ZHZePDRFZHNyBN0ng4OWuPRbQFf4+/Y9z8D83OPb4JCbbBBVXHO1+/TDaY3LoqlVjzc8svvTy1EqP+D/oHjpwFfPoZ4l8WJgTJc7ydxNaF6UFKgOUiB2nYjmDOS2YskyVV9fdPRXHPNbtei2u9mtyI3mE= From: Bertrand Marquis To: Julien Grall CC: Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBV7IqUb0ECYF0+NQ9CCVyUDtq0YVm2AgAABQwCAAP62gIAADosAgAACPoCAAAaAgIAAAkaA Date: Wed, 11 May 2022 09:18:25 +0000 Message-ID: <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> In-Reply-To: <34b790af-c56a-26c7-e218-7961023b8605@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d516f1d3-1bf9-492e-af65-08da332f3b54 x-ms-traffictypediagnostic: AM6PR08MB4070:EE_|AM5EUR03FT008:EE_|AM6PR08MB4881:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oOvfSd4hnwRbAosFb1yulprkJQAw93s0/Qk6eTeE7oqmqWyk6pqEex0Cb8hU/Ra9uer6oYL8IzD08HdAEmfg6Pu5X9Q59OpwIodi7Uc1yNemZrZLz3qKjwFIx5Tb3348F6sic7mbr1K8bbUp0OVJAANBCFzxCpvFi3PuazmDG2x180QQAZ4DseUPYd2aaBSP2ZWRUPBwNiXC4xC/6uJGXiky29QlIFEOpTYX5U6Patz5TDN/S6ciwHgYSji8FmdPMYqoRP6PtJtyZdqhm+cGaPuiiWQN6lhcE7fR04pAcn0+L7/zP0g1U+8MYJvfOn3g2LDFJ7KOKXUXu89TcSIFS9GKoZB/bo4Irws2E7tsRbEcM1UfIKduMSQyxkxjg02tulJfKl4dtPsyHUNtoPOtK1aAL07NPepvEaxigXjHzt7L/rts9b6hXksdelReYNSsnaCk9RThJ7Ax/FqmA/Ou2Y5O5IWM42+PDga6XRJuVajmHMhsDrYBCACcpkdlxBKfpXIhrnE9yMxFPKMjcFgQs2verriZUPa1J5uKyCnLmM+iZbxXGTlR3ANtlMhKew08Lw2lpY2YnXyNWMSji3tvLn4iplcm6PAwSYU68YUUlnHKWre3eTFiVf0LAHDcJlZA931p195hE6prgNbsj0CRxWPP9YanrEy/+oqHDpyCBLkjT/gNGfalB7GPXJ8aNl5RvnqbGut1LqpiiQF1d3RTUF18hkIsi9ETC/O8xQIVmcqorzj0Kjv/squjHrO8E44p2HvmwsK6VRGqpv7dVbhsWw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(2616005)(38100700002)(122000001)(91956017)(53546011)(36756003)(5660300002)(6506007)(83380400001)(38070700005)(8936002)(26005)(66446008)(508600001)(6486002)(64756008)(66476007)(316002)(66556008)(6512007)(76116006)(66946007)(6916009)(54906003)(8676002)(4326008)(71200400001)(2906002)(186003)(86362001)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <33AED799D059CB4B9BDA01743889BE38@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4070 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3802b8f2-a5fa-4fdb-697e-08da332f3409 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aqL+0n9nmr2RgCJeKy8zOkQVy781NJUAQN8NSVKcWEnuv+myWDsgvIyruYu4SHp179cglstlkMjNSQAtQq8+XfEd2dGjoexXbhekq6hlQUNLDfdCrrx9ERvcxRp1ztjDlM40Uk1DC5uEad3Y9yDzDk4HqxJlO+jbSrByQp+l+B/NY15QSYw4liupDf/4tQYJUo9vCKOQAxvmtbWZByhd3nQDFNEK1aSL8lfVUOXZXoG6emFAm3fUQOmvtXWIe1ycG5I6KGlft7oc/q+DFLLn8qJdKecozCjjmCmLnhH3vtrRP8s1XmrWxDtqYjMbxmch1qzWLTwC/wDD6pQGErAewmwH4Fyl/73qjYFdRqCMHH4gngaCXDyOkAwrxWLu7sQg8vG9fe/JyPslSuI0ES3P0Datc3lNG7oXLzfSpr/honTewBs0K5v+i4/u3MX6XaIa62Ma9c/cLGjJB55PbNEmlltASaZtIA/nDuZgHR6MjsCGxfuvj5/sEsXRPdzzfJczHv0jE/BWJrEspIOKR67YdlzQE4DHiVKtDJpdzt5F8lyFvwR+TSLhwVop3S61W/cYMTkvTIf0khKCe0fFFU0e40MWpfNZJ3q/MTSxQbqMxfJYB+RorLLHlrQ6yzmsI6ysHuQFfNmArzaEKiM77b2S2czmG2gl6P3J8VVH6KKTPbObbOUhn3T9/GeG/wUB76SqudtA+VEobz9Zxy+9u2PpxQ23ppOUn/h+MCagU01JlLU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(26005)(5660300002)(63350400001)(86362001)(186003)(6512007)(107886003)(82310400005)(2616005)(8936002)(70206006)(356005)(2906002)(40460700003)(63370400001)(4326008)(8676002)(336012)(83380400001)(6862004)(81166007)(70586007)(36860700001)(6506007)(6486002)(33656002)(53546011)(54906003)(508600001)(36756003)(316002)(47076005)(32563001)(45980500001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 09:18:37.7762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d516f1d3-1bf9-492e-af65-08da332f3b54 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4881 SGkgSnVsaWVuLA0KDQo+IE9uIDExIE1heSAyMDIyLCBhdCAxMDoxMCwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBCZXJ0cmFuZCwNCj4gDQo+IE9uIDExLzA1 LzIwMjIgMDk6NDYsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTEgTWF5IDIwMjIs IGF0IDA5OjM4LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+ PiBIaSBCZXJ0cmFuZCwNCj4+PiANCj4+PiBPbiAxMS8wNS8yMDIyIDA4OjQ2LCBCZXJ0cmFuZCBN YXJxdWlzIHdyb3RlOg0KPj4+Pj4gT24gMTAgTWF5IDIwMjIsIGF0IDE3OjM1LCBKdWxpZW4gR3Jh bGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+IA0KPj4+Pj4gSGkgUmFodWwsDQo+Pj4+ PiANCj4+Pj4+IE9uIDEwLzA1LzIwMjIgMTc6MzAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+Pj4+ PiArIHJjID0gZXZ0Y2huX2FsbG9jX3VuYm91bmQoJmFsbG9jKTsNCj4+Pj4+Pj4gKyBpZiAoIHJj ICkNCj4+Pj4+Pj4gKyB7DQo+Pj4+Pj4+ICsgcHJpbnRrKCJGYWlsZWQgYWxsb2NhdGluZyBldmVu dCBjaGFubmVsIGZvciBkb21haW5cbiIpOw0KPj4+Pj4+PiArIHJldHVybiByYzsNCj4+Pj4+Pj4g KyB9DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyBkLT5hcmNoLmh2bS5wYXJhbXNbSFZNX1BBUkFNX1NU T1JFX0VWVENITl0gPSBhbGxvYy5wb3J0Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICsgcmV0dXJuIDA7 DQo+Pj4+Pj4+ICt9DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gc3RhdGljIGludCBfX2luaXQgY29uc3Ry dWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+Pj4gY29uc3Qgc3RydWN0IGR0X2Rldmlj ZV9ub2RlICpub2RlKQ0KPj4+Pj4+PiB7DQo+Pj4+Pj4+IEBAIC0zMjE0LDYgKzMyNDMsMTQgQEAg c3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+ Pj4gaWYgKCByYyA8IDAgKQ0KPj4+Pj4+PiByZXR1cm4gcmM7DQo+Pj4+Pj4+IA0KPj4+Pj4+PiAr IGlmICgga2luZm8uZG9tMGxlc3NfZW5oYW5jZWQgKQ0KPj4+Pj4+IEkgdGhpbmsgd2UgbmVlZCB0 byBkbyBzb21ldGhpbmcgbGlrZSB0aGlzIHRvIGZpeCB0aGUgZXJyb3IuDQo+Pj4+Pj4gaWYgKCBo YXJkd2FyZV9kb21haW4gJiYga2luZm8uZG9tMGxlc3NfZW5oYW5jZWQgKQ0KPj4+Pj4+IHsNCj4+ Pj4+PiB9DQo+Pj4+PiANCj4+Pj4+IElzIHRoZXJlIGFueSB1c2UgY2FzZSB0byB1c2UgImRvbTBs ZXNzX2VuaGFuY2VkIiB3aXRob3V0IGRvbTAgKG9yIGEgZG9tYWluIHNlcnZpY2luZyBYZW5zdG9y ZWQpPw0KPj4+Pj4gDQo+Pj4+IEp1c3QgYmVpbmcgY3VyaW91cyBoZXJlIGJ1dCB3b3VsZCBpdCBl dmVuIGJlIHBvc3NpYmxlIHRvIGhhdmUgbm9uIGRvbTAgZG9tYWluIHNlcnZpY2luZyB4ZW5zdG9y ZWQgPw0KPj4+IA0KPj4+IFlvdSBjYW4gYnVpbGQgWGVuc3RvcmVkIGFnYWluc3QgbWluaS1vcyBh bmQgY29uZmlndXJlIHRoZSBpbml0IHNjcmlwdCB0byBsYXVuY2ggeGVuc3RvcmVkIGFzIGEgZG9t YWluLg0KPj4gU28gZG9tMCBpcyBub3QgbWFuZGF0b3J5IG9yIHNob3VsZCBtaW5pLW9zIGJlIHN0 YXJ0ZWQgYXMgRG9tMCBmb3IgdGhpcyB0byB3b3JrID8NCj4gDQo+IEluIG9yZGVyIHRvIGFsbG9j YXRlIHRoZSBldmVudCBjaGFubmVsLCB5b3UgbmVlZCB0byBrbm93IHRoZSBJRCBvZiB0aGUgZG9t YWluIHdoZXJlIFhlbnN0b3JlZCB3aWxsIHJ1bi4gU3RlZmFubydzIHBhdGNoIGlzIHJlbHlpbmcg b24gWGVuc3RvcmVkIHRvIGJlIHJ1biBpbiBEb21haW4gMC4NCj4gDQo+IFRoaXMgd291bGQgbmVl ZCB0byBiZSB1cGRhdGVkIGlmIHdlIHdhbnQgdG8gcnVuIGl0IGluIGEgc2VwYXJhdGUgZG9tYWlu Lg0KDQpPayB0aGVuIERvbTAgaXMgbWFuZGF0b3J5IGF0IHRoZSBtb21lbnQsIEkgYW0gb2sgd2l0 aCB0aGF0Lg0KDQo+IA0KPj4+IA0KPj4+Pj4gSWYgbm90LCB0aGVuIEkgd291bGQgY29uc2lkZXIg dG8gZm9yYmlkIHRoaXMgY2FzZSBhbmQgcmV0dXJuIGFuIGVycm9yLg0KPj4+PiBPbmUgd2F5IG9y IGFuIG90aGVyIHdlIG5lZWQgdG8gc29sdmUgdGhlIGNyYXNoIGJ1dCBpZiBpdCBpcyBmb3JiaWRk ZW4gd2UgbXVzdCBwcmV2ZW50IGNvbWluZyB0byB0aGlzIHN0ZXAgZWFybGllciBhcyBpdCBtZWFu cyB0aGUgY29uZmlndXJhdGlvbiBpcyB3cm9uZy4NCj4+PiANCj4+PiBJIHRoaW5rIHRoaXMgc2hv dWxkIGJlIGNoZWNrZWQgd2hlbiBwYXJzaW5nIHRoZSBjb25maWd1cmF0aW9uLg0KPj4gSWYgZG9t MCBpcyBtYW5kYXRvcnkgeWVzLCB3ZSBzaG91bGQgc3RpbGwgbWFrZSBzdXJlIHRoYXQgdGhpcyBj b2RlIGNhbm5vdCBiZSByZWFjaGVkIHNvIGFuIEFTU0VSVCB3b3VsZCBiZSBuaWNlIGhlcmUgYXQg bGVhc3QgaW4gY2FzZSBzb21lb25lIHRyaWVzIHRvIGFjdGl2YXRlIHRoaXMgY29kZSB3aXRob3V0 IGRvbTAgKHdoaWNoIG1pZ2h0IGhhcHBlbiB3aGVuIHdlIHdpbGwgcHVzaCB0aGUgc2VyaWUgZm9y IHN0YXRpYyBldmVudCBjaGFubmVscykuDQo+IA0KPiBJIGFtIGZpbmUgd2l0aCBhbiBBU1NFUlQo KS4NCj4gDQo+IEFyZSB5b3Ugc2F5aW5nIHRoYXQgZG9tMGxlc3NfZW5oYW5jZWQgd2lsbCBiZSBz ZXQgdG8gdHJ1ZSBmb3IgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsIHNlcmllcz8NCj4gDQo+IElm IHllcywgdGhlbiBJIHRoaW5rIGRvbTBsZXNzX2VuaGFuY2VkIHdpbGwgbmVlZCB0byBiZSBhbiBl bnVtIHNvIHdlIGtub3cgd2hhdCBwYXJ0IG9mIFhlbiBpcyBleHBvc2VkLg0KDQpObyBpdCB3b27i gJl0LCB3ZSBqdXN0IG5lZWQgc29tZSBvZiB0aGUgY2hhbmdlcyBkb25lIGJ1dCB3aXRob3V0IHNl dHRpbmcgZG9tMGxlc3NfZW5oYW5jZWQuDQpAUmFodWw6IGNhbiB5b3UgY29uZmlybS4NCg0KQ2hl ZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxs DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 11 09:46:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 09:46:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326656.549232 (Exim 4.92) (envelope-from ) id 1noivA-000794-0l; Wed, 11 May 2022 09:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326656.549232; Wed, 11 May 2022 09:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiv9-00078x-U6; Wed, 11 May 2022 09:46:15 +0000 Received: by outflank-mailman (input) for mailman id 326656; Wed, 11 May 2022 09:46:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiv8-00078n-Qj; Wed, 11 May 2022 09:46:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiv8-0003PP-Ox; Wed, 11 May 2022 09:46:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noiv8-0005j8-EH; Wed, 11 May 2022 09:46:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noiv8-0005AV-Dq; Wed, 11 May 2022 09:46:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3QWTLvldnJ7ha7GT+1pS7Tc2aXGlGipCJjN//guUlQs=; b=L725LhOiPRzvfpulB0/3WupMK3 LgkpGnCEah/YBu59nqzq75E+0zd93otlOQMWNfbAwn5tFApY/yiLY03/N+troBnJ0jtytX4sqPdg6 f/YwOFqEZRN9fnh/rPGYLut6CAGChZ7fvOUGzW7QsRO+1ftMN0av4YrXoQoiK5FxrqmU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170321: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 09:46:14 +0000 flight 170321 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170321/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 930 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 09:56:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 09:56:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326665.549243 (Exim 4.92) (envelope-from ) id 1noj4w-0000C0-1Y; Wed, 11 May 2022 09:56:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326665.549243; Wed, 11 May 2022 09:56:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noj4v-0000Bt-UF; Wed, 11 May 2022 09:56:21 +0000 Received: by outflank-mailman (input) for mailman id 326665; Wed, 11 May 2022 09:56:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noj4u-0000Bm-1h for xen-devel@lists.xenproject.org; Wed, 11 May 2022 09:56:20 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 995c2ebd-d110-11ec-a406-831a346695d4; Wed, 11 May 2022 11:56:18 +0200 (CEST) Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 05:56:15 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB4268.namprd03.prod.outlook.com (2603:10b6:5:9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 09:56:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Wed, 11 May 2022 09:56:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 995c2ebd-d110-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652262978; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=i0NjmKknu847jEBZ5WoR2pyMVM8i3R0MuYh7Er4DYlU=; b=bVJEiGESbtO8caES5AoebJdXmTHTDZRr5+YfwoptjE7qWFZ4uPwMfj6R DfIxCQck6cIzafQu76/AXXlnvLunXipmiC9S1nz+wPQUlPGCCEht6p5Bg 6AdrJuAtumsZefaLRwtjnLQ9Bo3VJjy91Sn8x6rX6ozB4Ek/gi/PzfBjp A=; X-IronPort-RemoteIP: 104.47.58.109 X-IronPort-MID: 71457960 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FeDHTqxRWzaDPVPuGGp6t+cKxyrEfRIJ4+MujC+fZmUNrF6WrkUPx mFNXGCOOq7cY2ugLt1yao+z/RsBucXUmNI2SgBrqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IHhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplhZ+gYws3Oq72ocMGdz1TGgxfHO5n0eqSSZS/mZT7I0zuVVLJmq0rIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeE+OTvY4wMDQY36iiGd73Y cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgA3M+fdosjaLpOB3+IfLKtH7YeaxfMlukUaEl zqY8nXTLR5PYbRzzhLAqBpAnNTnnz7/WY8UPK218LhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6xBGIJUzpAY9wOr9ItSHoh0 Vrht8ztLSxitvuSU3313p2Zty+oMC4Za0oLfzYZTBAt6sPm5oo0i3ryos1LFae0ipj5HG/2y jXT9Cwm3exL3IgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tYji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:FfFfXKDYjWJf/2jlHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDTa5rPw== X-IronPort-AV: E=Sophos;i="5.91,216,1647316800"; d="scan'208";a="71457960" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SK4AEoYApWZw1vt+IPtD0dURVEK+mVucUKH1OOzKkXL8M61l8Niilh7S3aeL+yrcgVdA3LP2kkg0TWVHZLG2mgJgbRPkO49ngPZzV1uhqp5yVqjQUFA3goqO55TLOed+vzzwFcMTcWjMNJbB+DHDFeohGIEkoPNk84H6tp8ujtFk8PX4lQzO0kSyURIw1edKkLw3bYDsrK8PaM+NE2C56FuAc0Gf5gTCkSk4z7HDvz8o9vcqjmXb95rTvgEArHwl2ZrwbJ3cN6x1+rGY47wefQxvo/IySkkGjyESW/8U2kzNyBTGM2a0D63AeV01cI1YbuBp1DU5uXGYrPK26F9GTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i0NjmKknu847jEBZ5WoR2pyMVM8i3R0MuYh7Er4DYlU=; b=aPNub8s0rTXggKQO7tarUiXyHrTHnKIc0q6OhxICTF1V7ASJ2GjZHyskSguPHnvMYChAuCxTP5NaYOKkm8wbP6AZOeRyPQW2Yz4ApAGZSNFQFwVm/bugXL2TVMXQZmYJb2L4Nw8OG67o9LQju9cBybh4dnWDDQ5Vkh95IrWxx3rQPG/9jiUfqWzWVctZbrwwM2wc3f62HasauFOy/KegMvcPKnX10byIJQlMVYovTdVS81mrmothilWSqLiNh0zPH/OxudjFNJjuQ86W/TmafHGG7x4FUDN9Ge0S4eKb0tH5Uj8LeCsyAViAVL/trWPmnQcbtsyMSs4nHGNhLRM4kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i0NjmKknu847jEBZ5WoR2pyMVM8i3R0MuYh7Er4DYlU=; b=HhiUYMaUGurxjKHCurDZ4XbTSHO/uCwbrzVo458mPZuVRJ7DSqrHcKS7OusVEDMSOh9g7bk42lExaQLDr9mlk1HgWLwO2w8RxHnBDNVBA5ONkTgSTLPH3qNxGzlRW8qrDgy4j/REtQlZB6vJfI9QbC3ErUqR0xSp/SWU9rQANWo= From: Andrew Cooper To: Julien Grall , =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v3 4/6] xen: Switch to byteswap Thread-Index: AQHYZFbw3mG1/klQJUepEAoxYdrkNK0X7v0AgAAFDwCAAAI1AIAABM2AgAADuQCAAXM6gA== Date: Wed, 11 May 2022 09:56:11 +0000 Message-ID: References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> In-Reply-To: <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 365fd7bf-8e36-401d-de3a-08da33347aee x-ms-traffictypediagnostic: DM6PR03MB4268:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FC5fsonPyBA7TIWqU7wEETTRcwK4ibJzXXwMH6CpMKzvHSynj4ZACuVfB+tltfnKEhqoSlyUl7Olq7mezn1uqB7/wxRTslg7AKROeVE/LPvNDRIyJgwh+ERozsI9lijk5u+tfa0dryZBAobbEDLfL8hvTIb60k1NKg4zLGTT4gOrOSJ2w94w+Oev4GE+OxAjU5X8xq3grGPk8HBLUuajBTsR8hv39tKLqs1pA4LlsySy38H3rjW6kXeZq2m0VbBscvsbPg/6CutG4i2Sm6FhTI9qC1c0bGPsNf4Qt6mfba9N7QfWPMXpz4kfAi6ggB0piqMZrfWYhYZPJr8NyULOYiPzJpJnlbo3qVBmsZLLcbgYA75QGSDHxwSNzohPSZPvjBu3O10nTqAabtYj75/M2vGSqguOErkVBay638dZLU5eT2d6YuVwL0HOh12Vf6PdsEW+l+boQNEaLhUmta3pOuy8NrF2FfjIf9kyki9gjdRhwalbR/Un880wNY8lK2oLepWdabqbvrPeQ5SRHMl81lrv9ldmg9wuYSdRCzaB16WMWGshR3X8yk8QQjSHYv39OSlDK7UCVxVbcwjr5nUaAEk7Py5q/bqHuu8639Tge4QmYvAe9dqO1LkvzVzcZ9DA11wok1hh9ZxAeQ05LTA1LGsOBzKT4CU1EYVlGfpbkJ00oyvyksd702UO35N39qTh7OIsk6phMFoN44cEbQ2uoTx3xkKnFwD4jsT4OxISe92sqqZrafacEaCVCMrCgh+N3oNPsBFMtFuoxwIzRzOnBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(8936002)(508600001)(76116006)(66946007)(38070700005)(4326008)(38100700002)(66556008)(6512007)(91956017)(122000001)(8676002)(66476007)(66446008)(64756008)(6486002)(82960400001)(71200400001)(83380400001)(26005)(2906002)(110136005)(31686004)(53546011)(186003)(316002)(54906003)(36756003)(6506007)(31696002)(86362001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bFR4OGc1M2lHUDN6ZU5QS0NDOE0rTkRBYU5sby9wdjd1cURtSXM2TlYvKzgz?= =?utf-8?B?QWoxVC9GL2luL1YxNnJGQURuMjcwQXZFa0VEM0dKTTFnL05TMTB5UGhqZUV1?= =?utf-8?B?VEtkbG1HWklkT215Wk1tYkhMemR1ejhoUXdSQWs2cG9sSWNnQlk1SnRyNzZq?= =?utf-8?B?dU1sbVJuN2doZ0RYTVdwTjJXRGxLRjZ2WldkcDBiZDZEeERwZXpsQzFGdjE1?= =?utf-8?B?RUlBNUx6ekpGbnpna2Yxc05yNG8rVk5RUnZ6QjdZT0s4RUFQSjFWSk44b3I5?= =?utf-8?B?VWpDeGViYndoOVZ2TUVXSWhjc0J0eC9qejZVZjJ6REo3c2ZCV0MvemV6NWE1?= =?utf-8?B?eXdMQkF0d3dxL1F2cVl0dm5QdXRSRFVZRkEwbkwwNTRqSnRudytIc3ZJL0pU?= =?utf-8?B?YzFOQzAvWC9ucE1PTTBZTVJKSDFVZythVFZoV1dZbEJyN1NrRllpTnd4cloy?= =?utf-8?B?b25WNE9RRFZMVlAxRWVWRGMrUUU1SGJuUU1sYWI4VlBwaG1uMDM5QlBQYnFI?= =?utf-8?B?Y056Y09QbzlXWXBLRnFqNlRSQXRMeEJpQnpLOWlGMmJOc3I0SDY5Y1I5UjR6?= =?utf-8?B?YUtpODlxTWVFMEs5WG1YdEE0QkRyRCtERFFKU1BqVEI2UU9vZVFDaHRQeE9B?= =?utf-8?B?MXZlZjNuMk41WXlKSFFMZmRrMWFleisxNTFLM2RLMUt1cEdqeHRxaWRQeGtV?= =?utf-8?B?Z1ZXZnZXSERjM0EvTkp4RHZxc3hzNmZTNEcweHpFSEJVVVgrejBDKy84SWZ0?= =?utf-8?B?U1BTSCtoNkZsOStJMTB0eHhvcklwZFdVbVV0TGNBMW16cy9HYUhCRXVWTER5?= =?utf-8?B?ZnZibWVUTUU2NVc3eG9WdUlqMmt3U3laWnl3YUZ1L2g5NTF6QWVFTVdJQUxP?= =?utf-8?B?blBrV1g0SVEvNnVqMEJhRklKWGo5ZGlDbnVUMjVnQlZnMmVGVndxaG1hcTlu?= =?utf-8?B?amhTcWJ0TzRIZER6b05SZHo3ZlpkR0JXOEZyRmd1WTlabWd0OTArMXFEWDIr?= =?utf-8?B?WWtBcTRuSkZLRkNnVWovelRDOUg1aEE0L1ZjMXY5MnpnbFN1WFlRM3VrR29Y?= =?utf-8?B?UTRVTTlsY3lPRU9DV2FZanJrcWtwM1NDOWpQWGRvYndZQjN4RUJ1dVBFUzhk?= =?utf-8?B?REtQZXI5VnNnMWFRR3gzeVZsRVg2WXVBY2U2S2pJTllJQktDTDhNZUdxL2Fn?= =?utf-8?B?VGxQYzRVVmYybW9HR20wUElSeHlhK093NWErQ0YzUTVNdUYyWG96a2NhMXJD?= =?utf-8?B?WHRaSlUyaTRVMEZ5VVhiak5KRDFOQmJwQm53WGdkQUg4bnY2Z3pvVTNIMURJ?= =?utf-8?B?bVF1d3hEcnpjejc3UFlUREUwSXBObjJUNWg5WmRkbU05RndscHBlVXVrb0xY?= =?utf-8?B?a2M2VkxrWE1XbG9jdWJhK21HbzMwNWhPcHh5SUtvN2JtRXFLUk95QUdNTEkv?= =?utf-8?B?clhteDVDczdsMnU0d3l3cys5YzdYeUFwUE1EZml1b2t4anAxbUR2L0llMUZi?= =?utf-8?B?cTZmd0F3WWp6Y0VxeFRkZkdrRjZZNVIyNENJdEJUUVNYTlZQcnBOcW45RHBy?= =?utf-8?B?YVlOSXp5SXdtNmJwbWlyZmlINkVPNkFpellKYVpvVVg2SDFTbmFvckd2cTlD?= =?utf-8?B?RmU5SGpGR1RmVzVTRFBGTUZPaGpoOThock1mUVhIN2R2UWs1cDdKTHB1SElN?= =?utf-8?B?OFpiV3F1Qkx4eklhUVFueC9wQjFqOXprb3hTRmVUZS9nNnpaT1YrNkZwdE1P?= =?utf-8?B?OU9PYWgremxrVCsxS2l3UlFKcGJTMy94dmR1aUp5RTIyOERISTkwTm9xRGZT?= =?utf-8?B?eUd6V2dLTkRUK0pDWGd5UHljS2F1djBhYXlDYjI4aHlWKzlZRTdOZzdhY0Q3?= =?utf-8?B?ZWNWZ1pkMWxBZy9xYTFERFVaUGNSVFBlUVJ6aks3SzRYOXZnREdhSmNEWHNI?= =?utf-8?B?N1JvWEN2cjFtOEdXb2dkVzgzRXNFVFprWUxnRDIxTklBN0ZURmZwWXFPUm1K?= =?utf-8?B?dk54cSt4dUJaYnpiRzFxR2lIbWRUL1V4M3VqWlpvYTcrSkpmSlJBVlo4QThW?= =?utf-8?B?OSs3dVNtVEV2YWJidnROQ3lnY2JWdHM4SWswNklDQWNPbEtIMWVlZ0xIakk0?= =?utf-8?B?QXhobTRrNW1TOE1SbEJGUkIyN0NhOWxjUmFNR3Y1OFRwQ3NCRVRnVGlsK3Vt?= =?utf-8?B?RTlrWUxxWEkvcnhwWlBTdlJYVzl3V1Uxc0xuYVlBbGRtWjJTYWVRMUdsQnFl?= =?utf-8?B?UHpkVVo5L2ZVZGx5RFJkcHhEdGxXK0ZocHlMaktMMkJBRjRvVXhzYnBWcUEw?= =?utf-8?B?ZFlTYWhpMGVUeDNHVE82c0N1bzVJbFlkVGZValJCM20xU2hkMHdHUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <6CA202BAC8DD57469B8D1FFEAB98E109@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365fd7bf-8e36-401d-de3a-08da33347aee X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 09:56:11.9981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fDOZvfmgLV8OZqltxZM7g4z6m7XKn9sHtVytb1QUVvgzEd6mjERcKkmKEy5HfA/FHhFqST7CWCFm6a3LzVYOaywbw1xKz1zGwOqKdAQPHbE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4268 T24gMTAvMDUvMjAyMiAxMjo0NywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g MTAvMDUvMjAyMiAxMjozNCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDEwLzA1LzIwMjIg MTI6MTcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4NCj4+Pj4+DQo+Pj4+Pj4gZGlmZiAtLWdp dCBhL3hlbi9pbmNsdWRlL3hlbi91bmFsaWduZWQuaA0KPj4+Pj4+IGIveGVuL2luY2x1ZGUveGVu L3VuYWxpZ25lZC5oDQo+Pj4+Pj4gaW5kZXggMGEyYjE2ZDA1ZC4uMTZiMmU2ZjVmMCAxMDA2NDQN Cj4+Pj4+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vdW5hbGlnbmVkLmgNCj4+Pj4+PiArKysgYi94 ZW4vaW5jbHVkZS94ZW4vdW5hbGlnbmVkLmgNCj4+Pj4+PiBAQCAtMjAsNjIgKzIwLDYyIEBADQo+ Pj4+Pj4gwqDCoMKgIMKgIHN0YXRpYyBpbmxpbmUgdWludDE2X3QgZ2V0X3VuYWxpZ25lZF9iZTE2 KGNvbnN0IHZvaWQgKnApDQo+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+PiAtwqDCoMKgIHJldHVybiBi ZTE2X3RvX2NwdXAocCk7DQo+Pj4+Pj4gK8KgwqDCoCByZXR1cm4gYmUxNl90b19jcHUoKihjb25z dCB1aW50MTZfdCAqKXApDQo+Pj4+Pg0KPj4+Pj4gSSBoYXZlbid0IGNoZWNrZWQgdGhlIGV4aXN0 aW5nIGltcGxlbWVudGF0aW9uIG9mIGJlMTZfdG9fY3B1cCgpLg0KPj4+Pg0KPj4+PiBJdCdzIGEg cGxhaW4gZGVyZWZlcmVuY2UsIGp1c3QgbGlrZSB0aGlzLsKgIEFGQUlDVCwgaXQgd2Fzbid0IHVu YWxpZ25lZA0KPj4+PiBzYWZlIGJlZm9yZSwgZWl0aGVyLg0KPj4+DQo+Pj4gV2VsbCwgdGVjaG5p Y2FsbHkgYW4gYXJjaGl0ZWN0dXJlIGNvdWxkIHByb3ZpZGUgYW4gb3ZlcnJpZGUgZm9yIHRoZQ0K Pj4+IGNvcHkuIEkgYWdyZWUgdGhhdCBhcm0zMiBpcyBhbHJlYWR5IGJvZ3VzIGJ1dC4uLg0KPj4+ DQo+Pj4+DQo+Pj4+IEl0IHNob3VsZCBiZSByZWFzb25hYmx5IGVhc3kgdG8gZml4IGluIGEgZm9s bG93dXAgcGF0Y2guwqAgSnVzdA0KPj4+PiBtZW1jcHkoKQ0KPj4+PiB0by9mcm9tIHRoZSB2b2lk IHBvaW50ZXIgdG8gYSBzdGFjayB2YXJpYWJsZSBvZiB0aGUgYXBwcm9wcmlhdGUgdHlwZS4NCj4+ PiAuLi4gSSBkaXNhZ3JlZSB0aGF0IGl0IHNob3VsZCBiZSBmaXhlZCBpbiBhIGZvbGxvdy11cCBw YXRjaC4gSXQgc2hvdWxkDQo+Pj4gYmUgZml4ZWQgbm93IGFzIHRoaXMgaXMgd2hlcmUgdGhlIGJh ZG5lc3MgaXMgc3ByZWFkIHRvIGFueQ0KPj4+IGFyY2hpdGVjdHVyZS4NCj4+DQo+PiBOby7CoCBU aGF0IGlzIGFuIGluYXBwcm9wcmlhdGUgcmVxdWVzdCB0byBtYWtlLg0KPj4NCj4+IExpbidzIHBh dGNoIGRvZXMgbm90IGFsdGVyIHRoZSBicm9rZW4tbmVzcyBvZiB1bmFsaWduZWQgb24gYXJtMzIs IGFuZA0KPj4gZG9lcyBpbXByb3ZlIHRoZSBhc3BlY3Qgb2YgdGhlIGh5cGVydmlzb3IgdGhhdCBp dCBwZXJ0YWlucyB0by7CoCBJdA0KPj4gdGhlcmVmb3JlIHN0YW5kcyBvbiBpdHMgb3duIG1lcml0 Lg0KPiBJIGFtIG5vdCBzdXJlIHN1cmUgd2h5IHN3aXRjaGluZyBmcm9tICpjcHVwKiBpbXByb3Zl cyB0aGluZ3MuLi4gYW5kIGFzDQo+IHVzdWFsIHlvdSBoYXZlbid0IGFuc3dlcmVkIHRvIHRoZSBj bGFyaWZpY2F0aW9uIHF1ZXN0aW9ucy4NCg0KQWRqdXN0IHlvdXIgdG9uZSBiYWNrIHRvIHNvbWV0 aGluZyBhcHByb3ByaWF0ZSB0byB0aGUgY29udmVyc2F0aW9uLg0KDQpUaGUgcCBoZWxwZXJzIGhp ZGUgYSB1bnNhZmUgdHlwZWNhc3QmZGVyZWZlcmVuY2Ugd2hpY2ggd2lsbCBlcnJvbmVvdXNseQ0K Y29tcGlsZSBib3RoIG9mIHRoZXNlOg0KDQp2b2lkIGZvbyh2b2lkICpwdHIpDQp7DQrCoMKgwqAg YmxhaF9wKHB0cik7DQp9DQoNCnZvaWQgYmFyKGJheiAqcHRyKQ0Kew0KwqDCoMKgIGJsYWhfcChw dHIpOw0KfQ0KDQphbmQgcG90ZW50aWFsbHkgbWFsZnVuY3Rpb24gYXMgYSBjb25zZXF1ZW5jZSwg bm90IHRvIG1lbnRpb24gdGhhdCBpdCdzDQpzdWZmaWNpZW50IG9iZnVzY2F0aW9uIHRvIHRyaWNr IGEgbWFpbnRhaW5lciBpbnRvIGJlbGlldmUgYW4gdW5yZWxhdGVkDQphcmVhIG9mIGNvZGUgd2Fz IHNhZmUgd2hlbiBpdCB3YXNuJ3QuDQoNCkRlbGV0aW5nIHRoZSBwIGhlbHBlcnMgaXMgYSBzcGVj aWZpYyBvYmplY3RpdmUgb2YgdGhlIHdvcmssIGJlY2F1c2UgaXQNCmZvcmNlcyB0aGUgYXV0aG9y IHRvIHJlc29sdmUgdG8gYW4gaW50ZWdyYWwgdHlwZSwgYW5kIGhhdmUgdGhlIGRlZmVyZW5jZQ0K Y2hhaW4gdmlzaWJsZSBpbiBhIHNpbmdsZSBsb2NhdGlvbiB3aGljaCBpbXByb3ZlcyBjb2RlIGNs YXJpdHkuDQoNCk9uIGEgaHVuY2gsIEkgY2hlY2tlZCB0aGUgTUlTUkEgc3BlYywgYW5kIGl0IHR1 cm5zIG91dCB0aGVyZSBpcyBhIHJ1bGUNCmFnYWluc3QgdGhlIHAgaGVscGVycyAoc3BlY2lmaWNh bGx5IHRoZSB0eXBlIHNhZmV0eSBhc3BlY3QpLCBzbyB0aGlzDQpzZXJpZXMgaXMgcmVtb3Zpbmcg YSB3aG9sZSBsb2FkIG9mIERJUiA0LjkgdmlvbGF0aW9ucyBmcm9tIHRoZSBjb2RlYmFzZS4NCg0K fkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed May 11 10:12:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 10:12:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326673.549254 (Exim 4.92) (envelope-from ) id 1nojKN-0002fh-JW; Wed, 11 May 2022 10:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326673.549254; Wed, 11 May 2022 10:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojKN-0002fa-GF; Wed, 11 May 2022 10:12:19 +0000 Received: by outflank-mailman (input) for mailman id 326673; Wed, 11 May 2022 10:12:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojKM-0002fU-1R for xen-devel@lists.xenproject.org; Wed, 11 May 2022 10:12:18 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d536396f-d112-11ec-a406-831a346695d4; Wed, 11 May 2022 12:12:16 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 6482B1F44D36 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d536396f-d112-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652263934; bh=qcj+acMxU0ciOKBaVy6pJbQiEuRN08dsxaJseG6RfwE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ALAQu/eEe04LAruPgoaxZO/rAmAmbVl+HcocVYpgGrXIRB8C3EP1FAmUZXjQFjUKn wfogK/QUTiSxNChIDNBZqO/aeRmGclTu4TrSdSdMO/cmWfEIqdry6AZOEiAP2fouZ6 Ze5K+g3wOPlOW2v6pMuegjSC6cihNNChKdrphdfE2ltP+RE0LEmom809Y8+fvE6J4/ Ahs2yVkxSRw3aK+Wy1uhxbsXzAskjDUGhwcgP9S4/r1ElfK42qDIjASJs4PEUZO9GN V4ie/nhjCksrQsC7KjRypS3JpnKPKwmWfZcBd1V4WsAwj2K9BvhnPx92oDSMYGMk4e Jp2S214QNnEnQ== Message-ID: <5894c310-fe50-8037-fc9c-cbedb0d8e71f@collabora.com> Date: Wed, 11 May 2022 13:12:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v8 01/27] notifier: Add atomic_notifier_call_chain_is_empty() Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-2-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/10/22 21:14, Rafael J. Wysocki wrote: > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > wrote: >> Add atomic_notifier_call_chain_is_empty() that returns true if given >> atomic call chain is empty. > It would be good to mention a use case for it. > I'll update this patch for v9. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Wed May 11 10:29:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 10:29:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326680.549265 (Exim 4.92) (envelope-from ) id 1nojbE-0004Ek-0l; Wed, 11 May 2022 10:29:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326680.549265; Wed, 11 May 2022 10:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojbD-0004Ed-Tz; Wed, 11 May 2022 10:29:43 +0000 Received: by outflank-mailman (input) for mailman id 326680; Wed, 11 May 2022 10:29:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojbC-0004ET-9J; Wed, 11 May 2022 10:29:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojbC-0004Bv-7a; Wed, 11 May 2022 10:29:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojbC-0006fI-07; Wed, 11 May 2022 10:29:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nojbB-00085R-Vu; Wed, 11 May 2022 10:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=47BLTRXuecgEgD5Jie2iKFpuiHHjAX2Oe57TQFrlA9I=; b=s8JG0vgCRu0/u//XfDYoHqpIgw xLv4uIYU36HbEj6J9R7+0U54+51bQfDlfrHU7F1imck7adBN34mvYhnJFWIRdqPvwXCvBcd2+sgH+ rZWVNv7XZextFqok57J0/tjHVfFfmOIWBOiDPfESd+3m3lXF3ANZuQKGwHMWWccfkQso=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170322: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 10:29:41 +0000 flight 170322 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170322/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 71 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 931 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 10:54:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 10:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326689.549276 (Exim 4.92) (envelope-from ) id 1nojyp-0007QK-1N; Wed, 11 May 2022 10:54:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326689.549276; Wed, 11 May 2022 10:54:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojyo-0007QD-TZ; Wed, 11 May 2022 10:54:06 +0000 Received: by outflank-mailman (input) for mailman id 326689; Wed, 11 May 2022 10:54:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nojym-0007Q7-Ml for xen-devel@lists.xenproject.org; Wed, 11 May 2022 10:54:05 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0611.outbound.protection.outlook.com [2a01:111:f400:fe06::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97c1db93-d118-11ec-a406-831a346695d4; Wed, 11 May 2022 12:53:31 +0200 (CEST) Received: from DB6PR0301CA0024.eurprd03.prod.outlook.com (2603:10a6:4:3e::34) by AM8PR08MB6324.eurprd08.prod.outlook.com (2603:10a6:20b:315::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 10:53:22 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::4a) by DB6PR0301CA0024.outlook.office365.com (2603:10a6:4:3e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 10:53:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 10:53:21 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Wed, 11 May 2022 10:53:21 +0000 Received: from 0609bfa1d5de.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 812F4AB4-751F-4C52-B32F-A8F655E6018F.1; Wed, 11 May 2022 10:53:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0609bfa1d5de.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 10:53:15 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by AM6PR08MB3958.eurprd08.prod.outlook.com (2603:10a6:20b:a6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 10:53:12 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 10:53:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97c1db93-d118-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QMj9U8PIS4gyMQylabZ5WH7kxfFTAPfytz49AkVP6wHggoxT9DSUG+8q1+rxzpYRMae/Izovo77QbFEqi2j3LTSY45HNtrCUtG9AXtKcNyqJzcMhG8HVOo/C8JJp0gbKogVVItujiEMbnJ677kA9ulIeeUkdwGA0XaXv5CtDZJvLJjj28RB6jrNtt7sv0UCw3gvQ6m4IoDZyK+rO/oQA9LtNpxpU2N0uSFj88YX4DLb/WiwW/lKp53q7/5dCPokBiz5mKdGVZ6PDn92f/AsEcKrs1TYpy6VF1JBp6Zs7TncyKV5OfXd5cqY23lAII2j2l4kRtC4swUuR4lHkhT+NsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1O+F2a6vmcjR7JhjnusIHWlZB1fB9W548d5dY5ooNY=; b=kGBzLjXzvV9vvts9OSbQpPI13tcJlqWoTezweSaDHKengi4pXWN9UTIgJfwEvHr+grFGZh9ld9x7AfvI8jLab73gXxIbbApq8zmblEtH9zn1YZOX5G29aylRoNVEe4HdoYjK03HPVQ2zOmsGtqfHlW2lKkwlMmC8Hu33egeAVBZb8F4KrG6ewFjfolVlcp7dYewPGJGCgSKMllEBQ35RHVwYqjL16laegmqOAO/v9HDKwXei9sPEaN1fCcgoQrE1gfXwROwWldeuhozLrhNygjVx1N0sQ7fD3q8m8K+XCf9XLmNPSXYjegQ00sQMDTQ/DdfV/U5BktPyoHdoAsmfxw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1O+F2a6vmcjR7JhjnusIHWlZB1fB9W548d5dY5ooNY=; b=evtfm4kxnGok0EUKULRI9CDI9JsPb/Ef73AUNQswKG/yC8v8DVccFBLSnmGqXNcUCb1swjrfCTbOB/WLCMqli+IX9B+MQ3uK1k34lQge7QMeMSiCLy9/IKKR0wtnEql1GXjI5Qv36o4xZ+YGq3ZZkdpbts0Lvfgu5GVgtFxuETA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 98233ee234f0b412 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YltLhnlMWw88s/Twarrwjq/CdAKF2kaom2ULM+pgGgdNOWQ9K0Iib4bsu0WxFDagS7F99MPdGt5Igf4JpvRTlFYRDUBGcUDo+Vtah0GBZx5TkVVonetRAxPpi8YQvp2dL0b/fNdxEEPSwe99UMDNQjSiMNyWpanaufKwT9vCx83LmXOm+iuG1gKxV0nPyj43Cirg8RQPZooJosn7ZUcd1rSUstc5q9eM+QADCTTFdGp7OAA4Gy0tBqM1K1zfWDslZ2SfnCQtLNise7znYvK1gWPggvlHXBDJWrFDvzqlgUpsjVJif+KJwwOyEjK2McvQgAYnNWs6HYSzZZ2aqE4ZFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1O+F2a6vmcjR7JhjnusIHWlZB1fB9W548d5dY5ooNY=; b=gM6R5pM2uF+nMss2scDOt/sYLeBRgx6BsiM61XXw8U7DIcz3lXMsM7SYENRv03b+Y0VmAgKz9F+WN9cqv1xKWjqKx+/uLNUY2CywTOOWKA0FJRuMWxh7BDcYfFVjHYj3L6VR0op1QDzSqOYUaxqIJ2/B52LOu29toAj6pLarLlyYz6cxFSf6DVU9QFnCCZ14aqJLk3fVyk9aFxj20UlIPuV3wc30gZZe5rNEEFW/INPrduMXq+qmzD0B8O78D37hxjB8JRYmH5XJkM4E9Cq21+/TK22y3zyrTztDONHygvnZOX3+xJBz1FBzZAR4czVtjhPAfEshsSpzy6TuxoW+Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1O+F2a6vmcjR7JhjnusIHWlZB1fB9W548d5dY5ooNY=; b=evtfm4kxnGok0EUKULRI9CDI9JsPb/Ef73AUNQswKG/yC8v8DVccFBLSnmGqXNcUCb1swjrfCTbOB/WLCMqli+IX9B+MQ3uK1k34lQge7QMeMSiCLy9/IKKR0wtnEql1GXjI5Qv36o4xZ+YGq3ZZkdpbts0Lvfgu5GVgtFxuETA= From: Rahul Singh To: Bertrand Marquis CC: Julien Grall , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBWH2ZK8TL5ueU+mSOXui+uVga0YVmwAgAABRACAAP62gIAADosAgAACPoCAAAaAgIAAAkiAgAAaewA= Date: Wed, 11 May 2022 10:53:12 +0000 Message-ID: <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> In-Reply-To: <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 69be0ef8-094d-4e0d-bf6f-08da333c7746 x-ms-traffictypediagnostic: AM6PR08MB3958:EE_|DBAEUR03FT040:EE_|AM8PR08MB6324:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KV3CxdRnjGSqpGB9VGYNGg+pPoV0/adodFUwPOhZnL2lEah5cc6pAKMENvWztZvTZFIa5LvM3dUlXOIuu0wOuwC2uSF5w4j2hyrjh2aom4dWD5XuA61wqhg/cTOmARu95bj0dALDlEaDL+NPm3fNAe8WumIdUqYqGu8NR+MQSObYEtPEyZIv0FzK9qwS4bO5JyiXBgqTwzpNY0kvjlz5HkXp36oarUEwecJ7GcDb7/rIEddlzYm3y041qHmoTssr50YZFlz9kg/FWhRyykvr8qfdZoappZrTz2txAy15+gtLwrdopVneegWRecc6VzsgBdcHPulDMdblpMrN1dtDM6/64VcRceQaE/Fjs8finYQ7IZ8qXE+b9cbp11bsr24zxalxN9wlAunY/BVokXvKaEdwnlzIdATs49OHu6u97Uj5wnJAUbM1NiLpZ0wOYExaDH27uRMTX0jbyZC59oeYs6z3FQ/nCKMyIK9gCe1xxbv8lq8Y9hS3TFMGtlOxc7R8nCLJMSLAytiN/13YcODk/dTgbup/2i7tDVkLGUgJYmiLCMX2ZlFf519ScRwznwwGsVZM7VRUVviFF874Ukk5HH19flZHEjRbp7ZS9QmvgtCWeSu2GC5LN3iKv+LlFowvlwzs5oNzkB/Bfg2bLA7FWOO7hrk1gZ2Q2OnjKIpv4+HyAZSjre1yASLj+nNDoE7uwp05TMgBMp/9gPPgkwBYjAIpCBcAhamsWUkgV4uzEG8CrLsQ9CzhEehcPGZGl6vSLSuUbskrBEDD7/NM7NCFHg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(316002)(76116006)(508600001)(6512007)(66946007)(26005)(66556008)(64756008)(66446008)(6486002)(2906002)(186003)(54906003)(8676002)(37006003)(6862004)(4326008)(6636002)(71200400001)(86362001)(38100700002)(33656002)(122000001)(2616005)(6506007)(83380400001)(38070700005)(8936002)(53546011)(91956017)(36756003)(5660300002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <2A84AD5F77B9724DAF0DC051C0ED2C89@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3958 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 31a67417-36c0-4bef-f1ca-08da333c71e2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bDL0xd0JdMDticxa4asWH/2cDGHpOFs3TU6YRMBhm0igW1rlpVQp9YKdkQTKKqHeYb9dwVC0Oi9fbdihiDyrMx+QL3s2Nfrjdms8U2CjHQ8Ij15JnpwSASk9y6V+dGvuTHQ78KJqMZPUXPKVmn3T3TjTJZH/V4qxMq2yFWy8ajZWkMNmaFLdMZlX6zhGNUn7tymq+IvnD8rHJrblK7Wynztko63XaKGBeiYtTTEvt3IA3rF+9OEsewZTIzGl0ZbcmEleUDszntpERnyHJGHVIs9C62zonWkf+FNHffYECGtNhy6BcyM9f+hcrOMYwh6tGzJto3lw2d42rVOOLVT+8mUhVoxBo0S/PY4tcZXIug/iVxfxs31ZvRPwxyFo7kLS70cKQn+pfXGzUQITjai0Y0Z3lFdhUPEDLKjNgRIC2/cpaSAfah0Se/fUmgV90LQfWtk/2ejLDRhB3VeXfb7FY8j9adfpT1IfRIbySm6XrPfxoDqHP0BHs37lS3bX4MxTTciS7mtlZU/PzOUET7K2ehGVMB+sqlGNJEa23tBeXL3Q9R4EuOJrdKwNXtu2FpbWYJ1NbBVrlA3SkdI5ilc6exy/75XlP7GxiunM2hesciFM2YzWE9zlH9nx30BytDLIQeBZhS7suvcrFcVfW6TnNGTs+Arc+L+blIxjkfv0jqVVDfI4AYH+Wi1OkZz8Yuv2k48vcEEAp0idoor6sr9PHA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(47076005)(5660300002)(186003)(336012)(83380400001)(2906002)(70586007)(81166007)(36756003)(33656002)(8936002)(40460700003)(82310400005)(6486002)(8676002)(6506007)(53546011)(6636002)(26005)(4326008)(2616005)(6512007)(86362001)(356005)(508600001)(37006003)(316002)(36860700001)(54906003)(107886003)(6862004)(70206006)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 10:53:21.8369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69be0ef8-094d-4e0d-bf6f-08da333c7746 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6324 SGkgSnVsaWVuDQoNCj4gT24gMTEgTWF5IDIwMjIsIGF0IDEwOjE4IGFtLCBCZXJ0cmFuZCBNYXJx dWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+IHdyb3RlOg0KPiANCj4gSGkgSnVsaWVuLA0K PiANCj4+IE9uIDExIE1heSAyMDIyLCBhdCAxMDoxMCwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4gd3JvdGU6DQo+PiANCj4+IEhpIEJlcnRyYW5kLA0KPj4gDQo+PiBPbiAxMS8wNS8yMDIy IDA5OjQ2LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBPbiAxMSBNYXkgMjAyMiwgYXQg MDk6MzgsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+PiANCj4+Pj4g SGkgQmVydHJhbmQsDQo+Pj4+IA0KPj4+PiBPbiAxMS8wNS8yMDIyIDA4OjQ2LCBCZXJ0cmFuZCBN YXJxdWlzIHdyb3RlOg0KPj4+Pj4+IE9uIDEwIE1heSAyMDIyLCBhdCAxNzozNSwgSnVsaWVuIEdy YWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+Pj4gDQo+Pj4+Pj4gSGkgUmFodWwsDQo+ Pj4+Pj4gDQo+Pj4+Pj4gT24gMTAvMDUvMjAyMiAxNzozMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+ Pj4+Pj4+PiArIHJjID0gZXZ0Y2huX2FsbG9jX3VuYm91bmQoJmFsbG9jKTsNCj4+Pj4+Pj4+ICsg aWYgKCByYyApDQo+Pj4+Pj4+PiArIHsNCj4+Pj4+Pj4+ICsgcHJpbnRrKCJGYWlsZWQgYWxsb2Nh dGluZyBldmVudCBjaGFubmVsIGZvciBkb21haW5cbiIpOw0KPj4+Pj4+Pj4gKyByZXR1cm4gcmM7 DQo+Pj4+Pj4+PiArIH0NCj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+ICsgZC0+YXJjaC5odm0ucGFyYW1z W0hWTV9QQVJBTV9TVE9SRV9FVlRDSE5dID0gYWxsb2MucG9ydDsNCj4+Pj4+Pj4+ICsNCj4+Pj4+ Pj4+ICsgcmV0dXJuIDA7DQo+Pj4+Pj4+PiArfQ0KPj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4gc3RhdGlj IGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwNCj4+Pj4+Pj4+IGNv bnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9kZSkNCj4+Pj4+Pj4+IHsNCj4+Pj4+Pj4+IEBA IC0zMjE0LDYgKzMyNDMsMTQgQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3Ry dWN0IGRvbWFpbiAqZCwNCj4+Pj4+Pj4+IGlmICggcmMgPCAwICkNCj4+Pj4+Pj4+IHJldHVybiBy YzsNCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gKyBpZiAoIGtpbmZvLmRvbTBsZXNzX2VuaGFuY2VkICkN Cj4+Pj4+Pj4gSSB0aGluayB3ZSBuZWVkIHRvIGRvIHNvbWV0aGluZyBsaWtlIHRoaXMgdG8gZml4 IHRoZSBlcnJvci4NCj4+Pj4+Pj4gaWYgKCBoYXJkd2FyZV9kb21haW4gJiYga2luZm8uZG9tMGxl c3NfZW5oYW5jZWQgKQ0KPj4+Pj4+PiB7DQo+Pj4+Pj4+IH0NCj4+Pj4+PiANCj4+Pj4+PiBJcyB0 aGVyZSBhbnkgdXNlIGNhc2UgdG8gdXNlICJkb20wbGVzc19lbmhhbmNlZCIgd2l0aG91dCBkb20w IChvciBhIGRvbWFpbiBzZXJ2aWNpbmcgWGVuc3RvcmVkKT8NCj4+Pj4+PiANCj4+Pj4+IEp1c3Qg YmVpbmcgY3VyaW91cyBoZXJlIGJ1dCB3b3VsZCBpdCBldmVuIGJlIHBvc3NpYmxlIHRvIGhhdmUg bm9uIGRvbTAgZG9tYWluIHNlcnZpY2luZyB4ZW5zdG9yZWQgPw0KPj4+PiANCj4+Pj4gWW91IGNh biBidWlsZCBYZW5zdG9yZWQgYWdhaW5zdCBtaW5pLW9zIGFuZCBjb25maWd1cmUgdGhlIGluaXQg c2NyaXB0IHRvIGxhdW5jaCB4ZW5zdG9yZWQgYXMgYSBkb21haW4uDQo+Pj4gU28gZG9tMCBpcyBu b3QgbWFuZGF0b3J5IG9yIHNob3VsZCBtaW5pLW9zIGJlIHN0YXJ0ZWQgYXMgRG9tMCBmb3IgdGhp cyB0byB3b3JrID8NCj4+IA0KPj4gSW4gb3JkZXIgdG8gYWxsb2NhdGUgdGhlIGV2ZW50IGNoYW5u ZWwsIHlvdSBuZWVkIHRvIGtub3cgdGhlIElEIG9mIHRoZSBkb21haW4gd2hlcmUgWGVuc3RvcmVk IHdpbGwgcnVuLiBTdGVmYW5vJ3MgcGF0Y2ggaXMgcmVseWluZyBvbiBYZW5zdG9yZWQgdG8gYmUg cnVuIGluIERvbWFpbiAwLg0KPj4gDQo+PiBUaGlzIHdvdWxkIG5lZWQgdG8gYmUgdXBkYXRlZCBp ZiB3ZSB3YW50IHRvIHJ1biBpdCBpbiBhIHNlcGFyYXRlIGRvbWFpbi4NCj4gDQo+IE9rIHRoZW4g RG9tMCBpcyBtYW5kYXRvcnkgYXQgdGhlIG1vbWVudCwgSSBhbSBvayB3aXRoIHRoYXQuDQo+IA0K Pj4gDQo+Pj4+IA0KPj4+Pj4+IElmIG5vdCwgdGhlbiBJIHdvdWxkIGNvbnNpZGVyIHRvIGZvcmJp ZCB0aGlzIGNhc2UgYW5kIHJldHVybiBhbiBlcnJvci4NCj4+Pj4+IE9uZSB3YXkgb3IgYW4gb3Ro ZXIgd2UgbmVlZCB0byBzb2x2ZSB0aGUgY3Jhc2ggYnV0IGlmIGl0IGlzIGZvcmJpZGRlbiB3ZSBt dXN0IHByZXZlbnQgY29taW5nIHRvIHRoaXMgc3RlcCBlYXJsaWVyIGFzIGl0IG1lYW5zIHRoZSBj b25maWd1cmF0aW9uIGlzIHdyb25nLg0KPj4+PiANCj4+Pj4gSSB0aGluayB0aGlzIHNob3VsZCBi ZSBjaGVja2VkIHdoZW4gcGFyc2luZyB0aGUgY29uZmlndXJhdGlvbi4NCj4+PiBJZiBkb20wIGlz IG1hbmRhdG9yeSB5ZXMsIHdlIHNob3VsZCBzdGlsbCBtYWtlIHN1cmUgdGhhdCB0aGlzIGNvZGUg Y2Fubm90IGJlIHJlYWNoZWQgc28gYW4gQVNTRVJUIHdvdWxkIGJlIG5pY2UgaGVyZSBhdCBsZWFz dCBpbiBjYXNlIHNvbWVvbmUgdHJpZXMgdG8gYWN0aXZhdGUgdGhpcyBjb2RlIHdpdGhvdXQgZG9t MCAod2hpY2ggbWlnaHQgaGFwcGVuIHdoZW4gd2Ugd2lsbCBwdXNoIHRoZSBzZXJpZSBmb3Igc3Rh dGljIGV2ZW50IGNoYW5uZWxzKS4NCj4+IA0KPj4gSSBhbSBmaW5lIHdpdGggYW4gQVNTRVJUKCku DQo+PiANCj4+IEFyZSB5b3Ugc2F5aW5nIHRoYXQgZG9tMGxlc3NfZW5oYW5jZWQgd2lsbCBiZSBz ZXQgdG8gdHJ1ZSBmb3IgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsIHNlcmllcz8NCj4+IA0KPj4g SWYgeWVzLCB0aGVuIEkgdGhpbmsgZG9tMGxlc3NfZW5oYW5jZWQgd2lsbCBuZWVkIHRvIGJlIGFu IGVudW0gc28gd2Uga25vdyB3aGF0IHBhcnQgb2YgWGVuIGlzIGV4cG9zZWQuDQo+IA0KPiBObyBp dCB3b27igJl0LCB3ZSBqdXN0IG5lZWQgc29tZSBvZiB0aGUgY2hhbmdlcyBkb25lIGJ1dCB3aXRo b3V0IHNldHRpbmcgZG9tMGxlc3NfZW5oYW5jZWQuDQo+IEBSYWh1bDogY2FuIHlvdSBjb25maXJt Lg0KPiANCg0KV2UgbmVlZCB0byBzZXQgdGhlICJ4ZW4sZW5oYW5jZWTigJ0gZW5hYmxlZCBmb3Ig ZG9tMGxlc3MgZG9tVSB0byBlbmFibGUNCnRoZSBldmVudC1jaGFubmVsIGludGVyZmFjZSBpbiBk b20wbGVzcyBndWVzdC4gSWYgd2UgZGlkIG5vdCBzZXQgdGhpcyBwcm9wZXJ0eSB3ZSBjYW7igJl0 DQp1c2UgdGhlIGV2ZW50LWNoYW5uZWwgaW50ZXJmYWNlIGluIGRvbTBsZXNzIGRvbVVzIGd1ZXN0 cy4NCg0KUmVnYXJkcywNClJhaHVsDQo+IENoZWVycw0KPiBCZXJ0cmFuZA0KPiANCj4+IA0KPj4g Q2hlZXJzLA0KPj4gDQo+PiAtLQ0KPj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 11 10:55:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 10:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326696.549287 (Exim 4.92) (envelope-from ) id 1nok0b-00082T-HA; Wed, 11 May 2022 10:55:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326696.549287; Wed, 11 May 2022 10:55:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nok0b-00082M-EE; Wed, 11 May 2022 10:55:57 +0000 Received: by outflank-mailman (input) for mailman id 326696; Wed, 11 May 2022 10:55:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nok0a-00082G-Cx for xen-devel@lists.xenproject.org; Wed, 11 May 2022 10:55:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nok0Z-0004e0-Vy; Wed, 11 May 2022 10:55:55 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nok0Z-0004FK-PX; Wed, 11 May 2022 10:55:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EU7J/mSeOBr7HR2Mpi7MB3nxiM04V/F7TspNkBmDrL0=; b=MqQGHecEeQyjUG1qZX7N3e9ydS 7FYyhvRrZSM2ND2pjmjY2nPPShD/rMyOVXQoswyLX+dgRukWg3fU4sbJ1xOHril2ut1a1vhbwTuqh qErl+smctPMbn9wGu4wqaYLUSFLfLs8Ac/ZFABTWHNbji6H1+uhgA7ilW0Op51/l6jFc=; Message-ID: Date: Wed, 11 May 2022 11:55:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: Andrew Cooper , =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , George Dunlap , Jan Beulich , Wei Liu , Bertrand Marquis References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/05/2022 10:56, Andrew Cooper wrote: > On 10/05/2022 12:47, Julien Grall wrote: >> Hi, >> >> On 10/05/2022 12:34, Andrew Cooper wrote: >>> On 10/05/2022 12:17, Julien Grall wrote: >>>>> >>>>>> >>>>>>> diff --git a/xen/include/xen/unaligned.h >>>>>>> b/xen/include/xen/unaligned.h >>>>>>> index 0a2b16d05d..16b2e6f5f0 100644 >>>>>>> --- a/xen/include/xen/unaligned.h >>>>>>> +++ b/xen/include/xen/unaligned.h >>>>>>> @@ -20,62 +20,62 @@ >>>>>>>       static inline uint16_t get_unaligned_be16(const void *p) >>>>>>>     { >>>>>>> -    return be16_to_cpup(p); >>>>>>> +    return be16_to_cpu(*(const uint16_t *)p) >>>>>> >>>>>> I haven't checked the existing implementation of be16_to_cpup(). >>>>> >>>>> It's a plain dereference, just like this.  AFAICT, it wasn't unaligned >>>>> safe before, either. >>>> >>>> Well, technically an architecture could provide an override for the >>>> copy. I agree that arm32 is already bogus but... >>>> >>>>> >>>>> It should be reasonably easy to fix in a followup patch.  Just >>>>> memcpy() >>>>> to/from the void pointer to a stack variable of the appropriate type. >>>> ... I disagree that it should be fixed in a follow-up patch. It should >>>> be fixed now as this is where the badness is spread to any >>>> architecture. >>> >>> No.  That is an inappropriate request to make. >>> >>> Lin's patch does not alter the broken-ness of unaligned on arm32, and >>> does improve the aspect of the hypervisor that it pertains to.  It >>> therefore stands on its own merit. >> I am not sure sure why switching from *cpup* improves things... and as >> usual you haven't answered to the clarification questions. > > Adjust your tone back to something appropriate to the conversation. It was indeed harsh. Sorry for that. > > The p helpers hide a unsafe typecast&dereference which will erroneously > compile both of these: > > void foo(void *ptr) > { >     blah_p(ptr); > } > > void bar(baz *ptr) > { >     blah_p(ptr); > } I am assuming that blah would expect a (blah *). > > and potentially malfunction as a consequence, not to mention that it's > sufficient obfuscation to trick a maintainer into believe an unrelated > area of code was safe when it wasn't. I looked at the helpers, they are static inline and use a proper type. Therefore, I am not sure why bar would compile in this situation. In fact, to me it seems this is an inherent issue to C: any void pointer can be casted to anything. You are removing one here, but there are hundreds of other potential "unsafe" place in Xen. > > Deleting the p helpers is a specific objective of the work, because it > forces the author to resolve to an integral type, and have the deference > chain visible in a single location which improves code clarity. See above, I think dropping p helpers is not solving the underlying problem (we are not going to be able to remove pointers in Xen). What would solve the problem is forbidding cast from void pointer to any pointer. At which point, keeping *cpup* is not going to be problem. > > On a hunch, I checked the MISRA spec, and it turns out there is a rule > against the p helpers (specifically the type safety aspect), so this > series is removing a whole load of DIR 4.9 violations from the codebase. I read through DIR 4.9., AFAIU it is about using function rather than macro. The current implementation of *cpup* are using function so I don't understand how removing *cpup* would help. So I am afraid, I still see no justifications to drop *cpup* here and I actually prefer them the open-code version. I will not Nack it, but I will not support. In any case, the commit message should contain some information why they are dropped. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 11:06:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:06:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326704.549298 (Exim 4.92) (envelope-from ) id 1nokAY-0001Bp-G9; Wed, 11 May 2022 11:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326704.549298; Wed, 11 May 2022 11:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokAY-0001Bi-CV; Wed, 11 May 2022 11:06:14 +0000 Received: by outflank-mailman (input) for mailman id 326704; Wed, 11 May 2022 11:06:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokAX-0001Bc-Jr for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:06:13 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5cfa09c0-d11a-11ec-a406-831a346695d4; Wed, 11 May 2022 13:06:12 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1652267167835177.85639750326493; Wed, 11 May 2022 04:06:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cfa09c0-d11a-11ec-a406-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1652267168; cv=none; d=zohomail.com; s=zohoarc; b=jqgIHLUDhkjHEbDGN56CG/foHg07cjKNEQZhC8OzOu+/nNSzPqMq0CU92VUFeD2mftzhLj7iYjQlOnUF3q74a1oYo/719AsOzRhMAG7LKh84ovReIQ+ItTauACWmI26BsyjiOZoq8ZFfVjEeF9cCBEwfN/3JL8WvULnjZdF9zmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652267168; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=gTL+o8aNyNcXOAKDASLTIDGIYEIU0NEfdsDtKkGnT+U=; b=XWkulCxaPfh5o6/DSkZuk+XsM4OALhr5Mofko6yOdyMi1cn+eIIGaaieHWEyYYdlgyJd0i6KX9w3SYl5xZLZleV0ouIoWWLojAqBWNkKYmHHutXQmqJ/sqKWyxlnv5SXpJFeuqFhe9CPPRluIX/DihwIhKfmJoijmfvznWvy9XA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652267168; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=gTL+o8aNyNcXOAKDASLTIDGIYEIU0NEfdsDtKkGnT+U=; b=JpCras6R8ZDNBj5+EqFLo/uEP81ugHbCrhOQmuLGsTYUljiG/FE1ogdofrA8GAmq tIkN40ZV4tuDS4r6R/6FSpfl37GFROR9nv/DAZwXzGZzbgSk8/9VLTjJ+FyqR1J/IlR JN8fNiLNIT1h+sHbTW59zTPigJtbzjNIcmIW82eE= Message-ID: <97fc4e45-ebd5-d686-a3d0-01d0d524659c@apertussolutions.com> Date: Wed, 11 May 2022 07:05:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Luca Fancellu Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> From: "Daniel P. Smith" In-Reply-To: <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/3/22 09:17, Luca Fancellu wrote: > Hi Daniel, > >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index 0bf63ffa84..b93101191e 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) >> return 0; >> } >> >> +static int cf_check flask_set_system_active(void) >> +{ >> + struct domain *d = current->domain; >> + >> + ASSERT(d->is_privileged); >> + >> + if ( d->domain_id != DOMID_IDLE ) >> + { >> + printk("xsm_set_system_active should only be called by idle domain\n"); > > Sorry I spotted that now, here in the printk probably you mean “flask_set_system_active” > instead of “xsm_set_system_active”, you can keep my R-by after this change. That was intentional as that was the hook it came in as, but after you pointed it out I realized this may cause confusion since the default policy function name is the same as the hook. Though changing it I would do as Julien suggested and use __func__. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed May 11 11:06:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:06:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326708.549309 (Exim 4.92) (envelope-from ) id 1nokB9-0001gA-PT; Wed, 11 May 2022 11:06:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326708.549309; Wed, 11 May 2022 11:06:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokB9-0001g3-Li; Wed, 11 May 2022 11:06:51 +0000 Received: by outflank-mailman (input) for mailman id 326708; Wed, 11 May 2022 11:06:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokB8-0001Bc-Aa for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:06:50 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73972aab-d11a-11ec-a406-831a346695d4; Wed, 11 May 2022 13:06:49 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1652267204266268.65022183172607; Wed, 11 May 2022 04:06:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73972aab-d11a-11ec-a406-831a346695d4 ARC-Seal: i=1; a=rsa-sha256; t=1652267206; cv=none; d=zohomail.com; s=zohoarc; b=Lhb2nJ+kynrJR6BzzaA6jSc5Yoz7+1OTWG4TH1uSUcWP/6JlK5i7oXan4SnOK1TN6nXvGpEPjuoO9yiCN5YMWsPMnbXzJQ50XpOcOtTNh0/DtbSC0+3bz6K4P3buZGM4HaZSIXJ6sx59wpSRSMl69gka8hYOpYY99YvbX6A+lhQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652267206; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9n/aS6rL2TlLAqR5rCBnVob92xkCeuTrUzwXok9Ctks=; b=by+2gTOE1eg0PsTupT+jukoWl7HczTMyNFcOAJ1bch4CiyMXgr69XEjaPTHEXNb8zWJFDoA+cBQ7/Du1HFM/MPbrOOgwwUloVFrLxT/DHSmrJZPaLIiv91uwaVrFktgy9yApjMPzpXo8tdG4dXTkRfeiaRPGWHuiv1vBoNlQj94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652267206; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=9n/aS6rL2TlLAqR5rCBnVob92xkCeuTrUzwXok9Ctks=; b=YrnYlOdqz1ZsE/0Tn/CjmhjFxZqSD3mmmikZ4xyyCI6EmwIDTm15+FzBakPpkNZ0 yEkV8e21aR+A8DBIoyewBKsgys0bnJoJ911g+PzeiDAscQsSF3PTCnZO71XaB28Qlyw 9pDj8uuuRfTTjKwXsWT2cbg0KOqcXLVIsv/rKqDw= Message-ID: Date: Wed, 11 May 2022 07:05:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Julien Grall , Luca Fancellu Cc: xen-devel , Volodymyr Babchuk , Wei Liu , Scott Davis , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Stefano Stabellini , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> <08C4B263-D905-42A2-BBFF-75D7F78E20A1@arm.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/9/22 14:33, Julien Grall wrote: > > > On 03/05/2022 14:17, Luca Fancellu wrote: >>> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >>> index 0bf63ffa84..b93101191e 100644 >>> --- a/xen/xsm/flask/hooks.c >>> +++ b/xen/xsm/flask/hooks.c >>> @@ -186,6 +186,28 @@ static int cf_check >>> flask_domain_alloc_security(struct domain *d) >>>      return 0; >>> } >>> >>> +static int cf_check flask_set_system_active(void) >>> +{ >>> +    struct domain *d = current->domain; >>> + >>> +    ASSERT(d->is_privileged); >>> + >>> +    if ( d->domain_id != DOMID_IDLE ) >>> +    { >>> +        printk("xsm_set_system_active should only be called by idle >>> domain\n"); >> >> Sorry I spotted that now, here in the printk probably you mean >> “flask_set_system_active” >> instead of “xsm_set_system_active”, you can keep my R-by after this >> change. > > I tend to use "%s: ...", __func__ so the name always name the function. Ack. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed May 11 11:07:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326716.549320 (Exim 4.92) (envelope-from ) id 1nokC6-0002IN-3m; Wed, 11 May 2022 11:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326716.549320; Wed, 11 May 2022 11:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokC6-0002IG-0s; Wed, 11 May 2022 11:07:50 +0000 Received: by outflank-mailman (input) for mailman id 326716; Wed, 11 May 2022 11:07:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokC4-0001xN-Mp for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:07:48 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 966c78c3-d11a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 13:07:47 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1652267264218728.9005047314162; Wed, 11 May 2022 04:07:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 966c78c3-d11a-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1652267264; cv=none; d=zohomail.com; s=zohoarc; b=XyRQxaxojTZftLCvZG6n6s99YKtoyQ44iuFeMdJxJ6OZBdLVY/ACAOqOnquIjWVe2EQq/zbrApzsXUKa+aYjVAfXz5QI+yjedlImgqfEn75GyzCm2yepjcaQgO3j8j2R6px3QDw3WQLGGaHGo/K5qSRgQvi/cSlL5IgcETYrSFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652267264; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=LPaxX1CGyojY5W90ga7NL/xUA5jg2+WGSMaT9mSNbuU=; b=Zc1CIXH2tWUCvntkrsRO/byyOrDNX59iCRwIcXfJjxB9HrB4XKkH/tksxpCX3KWY4v8N/52eKZPGjL8wRGW3EYq+FWeSPBOz+oZDuGzff/K5CcXOnyjszkAGGaBsmc90lIqmu5swx2X0gc902PNZUu5AL15GF/51rWN89pQehVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652267264; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=LPaxX1CGyojY5W90ga7NL/xUA5jg2+WGSMaT9mSNbuU=; b=hzPV8VFHAtrnAnMEP2eC5GnzDRhK/QrK066uFmFlgBW9VNucqSRDO6g72egwxvgS 4seY5kWHWF1n8s/KPTu2pcHXM/KcXHPBZRScJBbM/NSy+MMH+w5cnXbFWgUcNsfm+cc 5s7LvZ8tQ191oqOzVsGVHFXNvhUIqFYS6VPg9vkE= Message-ID: Date: Wed, 11 May 2022 07:06:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Stefano Stabellini , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220503111731.12642-1-dpsmith@apertussolutions.com> <20220503111731.12642-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/9/22 14:38, Julien Grall wrote: > Hi Daniel, > > On 03/05/2022 12:17, Daniel P. Smith wrote: >> There are new capabilities, dom0less and hyperlaunch, that introduce >> internal >> hypervisor logic which needs to make resource allocation calls that are >> protected by XSM access checks. This creates an issue as a subset of the >> hypervisor code is executed under a system domain, the idle domain, >> that is >> represented by a per-CPU non-privileged struct domain. To enable these >> new >> capabilities to function correctly but in a controlled manner, this >> commit >> changes the idle system domain to be created as a privileged domain >> under the >> default policy and demoted before transitioning to running. A new XSM >> hook, >> xsm_set_system_active(), is introduced to allow each XSM policy type >> to demote >> the idle domain appropriately for that policy type. In the case of >> SILO, it >> inherits the default policy's hook for xsm_set_system_active(). >> >> For flask a stub is added to ensure that flask policy system will >> function >> correctly with this patch until flask is extended with support for >> starting the >> idle domain privileged and properly demoting it on the call to >> xsm_set_system_active(). >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Jason Andryuk >> --- >>   xen/arch/arm/setup.c    |  4 ++++ >>   xen/arch/x86/setup.c    |  5 +++++ >>   xen/common/sched/core.c |  7 ++++++- >>   xen/include/xsm/dummy.h | 17 +++++++++++++++++ >>   xen/include/xsm/xsm.h   |  6 ++++++ >>   xen/xsm/dummy.c         |  1 + >>   xen/xsm/flask/hooks.c   | 23 +++++++++++++++++++++++ >>   7 files changed, 62 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index d5d0792ed4..39a654926d 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long >> boot_phys_offset, >>       /* Hide UART from DOM0 if we're using it */ >>       serial_endboot(); >>   +    if ( (rc = xsm_set_system_active()) != 0 ) >> +        panic("xsm(err=%d): " >> +              "unable to set hypervisor to SYSTEM_ACTIVE >> privilege\n", rc); > > We usually don't split error message over multiple lines (even if they > are over 80 characters). > >> + >>       system_state = SYS_STATE_active; >>         for_each_domain( d ) >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index 6f20e17892..36a60ce884 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -620,6 +620,11 @@ static void noreturn init_done(void) >>   { >>       void *va; >>       unsigned long start, end; >> +    int err; >> + >> +    if ( (err = xsm_set_system_active()) != 0 ) >> +        panic("xsm(err=%d): " >> +              "unable to set hypervisor to SYSTEM_ACTIVE >> privilege\n", err); > > Same here. > > Other than the two remarks above and Luca's one: > > Acked-by: Julien Grall # arm Ack. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed May 11 11:08:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326723.549330 (Exim 4.92) (envelope-from ) id 1nokCx-0002uj-Dq; Wed, 11 May 2022 11:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326723.549330; Wed, 11 May 2022 11:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokCx-0002ua-Av; Wed, 11 May 2022 11:08:43 +0000 Received: by outflank-mailman (input) for mailman id 326723; Wed, 11 May 2022 11:08:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokCv-0001xN-GF for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:08:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b55962a4-d11a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 13:08:40 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 07:08:16 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4289.namprd03.prod.outlook.com (2603:10b6:208:6c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 11:08:11 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 11:08:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b55962a4-d11a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652267319; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=36WlfBmXSKoUB9BSOG/HJzxrNe4fjswmsS5Vb1nthtA=; b=RQhL2FVkfYnGRv+E0XnhxvY4/SRfuxpQl1apS4RhvmSioWGzDv3bOlKY yX3FTwogMrff+cYXClOW924jXbxR3RLFUnlS7plWmZ8gUZ8rbLqKofcjB cmn6llyM1XO/SW5TltiTdtkeBdu+kAiE86ONr0bhmWYawhKLveRWilLGk g=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 71462117 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:e5Ik4q09Ozx2Xc/ST/bD5d9wkn2cJEfYwER7XKvMYLTBsI5bp2FTz mUcX2jVO66KM2Wnctp+PYiypx5V7ceGnYQ1GwQ4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1vsJaLZCwTb5aUv9xFWSJkOi8lP5dvreqvzXiX6aR/zmXgWl61mbBLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B86dBfmTjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SCjLWcB8Q39SawfvHrt/Ap3y5TWEICOIIe2VNxEwheGq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0c9ldDew8rh2Mw6z84gCFC2xCRTlEAOHKr+czTD0uk 1qWxdXgAGU1tKXPES7EsLCJsTm1JC4Za3cYYjMJRhcE5N+lp5wvihXITZBoF6vdYsDJJAwcC gui9EAW74j/R+ZSiM1XIXivb+qQm6X0 IronPort-HdrOrdr: A9a23:Fcge/qAIvTEYJW7lHeg/sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dNME/N 323Ls2mxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg72w 31CNUWqFhwdL5mUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="71462117" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIaj+cb5PWp2kii8cAb26KHQqPqFY4VsUm2VKeKkKo4xiC6YSszk2JXeukq+xrLTthnOQaq8WWsNhxOZm1lOOpNwBUdqI5Zm5FIveDoBAAho1iufgGCO0ppM1t4B256JYP1lu3oF6Ejm3AvDlAeGKBAnj/Jnl2DtvTFMOnlZj/HQeO7ztKWEHGaiDdcwVBVOpIHqB+KnVep62ng4/E4du9aNGxw+E4+/uF312TBHgGRC6S3/g1P/SJI63VzVYf57ecNw/7G7A/dsuK3dPzo5Cj92CvIK056V3vk2ssCS0OOW5YHiWIa+vtiyAt38SWEB2i4MOWFM/ErRN/UdhdIxqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OJWgfGFO8DncUUY05mQZ8PEOgtI+BJ+iBil/u2rwa1w=; b=WHg76gK4JsE/skzPZ86E391T7cNfn7msGiwkXKt+uGSbCPMGUjtGrL8a8CqmCby6+k46rW8xqFYqKCIy3jWE/SIiAKEbDaViACJmmhVhXxtvBEhDivsN4Zy6CUCTEZ7ClcjroR4Yljf9isGJysvb0DU2j8lkXdEiqJkqDmNIGjGAoP1MOjKJuER/59yIjEs2CnoIMvwQzgCCYweNbjfzadoo8acDB7eWlakmrI7sl5pDqryAuB3viUP+o/DiAqcfP1ucjA1Dv898rYb7BbVnLDiIl2SurHBjxhUmSgUHUpcDc2xicVimZJCgZgXCFgpZGzLXCOT3gM+71+AfOmAepw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJWgfGFO8DncUUY05mQZ8PEOgtI+BJ+iBil/u2rwa1w=; b=GMpUJcusiq0SVKF+RGQ32iBvTSwwFnZZTRpB74Kx5IR0tcv2/y8smlL7CpULND2yKDQcsIev03UQOmaEals2HgJaCnTX8gaUIXPzd3SWITvYEJ1WWgC50rKN/Rg8FHhT7udAQGUcFpkakpqGnslYHZ/MWIMO9xqzkJNbgzWIQkg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 13:08:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 18/21] VT-d: replace all-contiguous page tables by superpage mappings Message-ID: References: <98553b89-6296-9e4c-4677-9201cd7cdeef@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <98553b89-6296-9e4c-4677-9201cd7cdeef@suse.com> X-ClientProxiedBy: LO4P265CA0095.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af930fe0-3fb8-49cd-0bfb-08da333e8992 X-MS-TrafficTypeDiagnostic: BL0PR03MB4289:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iWtrfwPB3AbHh2o7qT8xf1FotCWTTpWQJzlY6Zuka85aXgtG5wwKAJo7KbQ8bsl4APIAIDEIXE+tGl15zYLLl1PtS6gHyWjKh4cjceTDDYxriTGlOw6UiH5YZmEyo4iCEADhzT8T8v76K/96T5mjJm/dY5iuIbEyBF1qGzGVBRyTf0RiRR16jn+fRvBB+m33a8Bjxk+XninGwSd79jyMs7IMW4WzF0WrDq0ad1ZII8DLrMKjghsP0sXpuTUV2/WEaGJNFPLYj9F8AvCpimUqPZg/rfVqbO6MOVj7jlwxnFCNKAp7WHNnjRCAPXjZm367quHt9++m8UcMDQEnbar3LbB0J8Etk0KPpAKolPw+tqQpHzrR5gIAzeBSfM0O0m4ly1xgK+b5nYQ2L255Yta0//LBdMHQ+TW5EMXLtt+06pw1+vdLT3GQe2MYtwH2/ZFqfHXprk82GRLj2zbHsbd93GpBWgoMjJXuQLDdq5kqZ3PTdDAB3dqh/dAGbda/nV3JG4uVgKfNjf4JMkRGvRENfUYLG+gNDFwGl2DvDpexErTUk6hKC0X/vb+TAdcSIBlUhe2bPy03AcbulQjyxFAelOYUtUJ1D6m0Vd/gpxjnL9zFChtuRXJszqF4M5Je7LlG+HYj426duA7BNKBNc8d+Uw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(82960400001)(86362001)(38100700002)(9686003)(83380400001)(6512007)(26005)(186003)(8676002)(6666004)(4326008)(316002)(8936002)(66556008)(66476007)(66946007)(33716001)(4744005)(85182001)(6506007)(5660300002)(508600001)(2906002)(6486002)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTlkcGNaZXNWRlRkeVZRcHVDZTl3UWlPTmVybFN1N1NPUDR0QUxHcWJ4bWts?= =?utf-8?B?K2lkNWdLYmxaSjRlVXYxUWdmWWdwdlh4WlVHRWVnbEJDbk9pL2NhK0t6c0lZ?= =?utf-8?B?VHQwZmUzTTVPSnRWTzAvTDYwZGcyZE9FK01QZHNhNDMxZVpoL3ZVRWwxZ3Ja?= =?utf-8?B?QytPODdhV09zYktoVkFFM1VId0ZIUEdrTDVoTFdjZ3BMcCtKa3BmcXhoZ1FN?= =?utf-8?B?RFgvMGpqQzJzY2lmN2syM0ZoWnRVYjJOTExMTVlrV1prTU5jSGlDVFdhaGxk?= =?utf-8?B?ZjhGRFlaZHl5YWtKUmd3SWNZNFA3QU1RaWRLWkZVdzIwSDRxcTEvVXo0c0VW?= =?utf-8?B?SGtIVkNIRXRJTm92d1BiK0Y5aUxpSzJiYmhBdnRHdXJJMnB3ZEYyYjZZUXYw?= =?utf-8?B?TTBEMGpCMG0yUDloUWE1ZWdQSnZBUTdaSFUvVXNoemRJTExMU3dYS01SdlNH?= =?utf-8?B?dkQ3eDNFWk5zM1RVaU5oWTloY0FCVlpHc3daREJqT2dId0xUaEx0alE5UXpL?= =?utf-8?B?a3dSWTk3Rm14WDVRaXBBMThGVEk5NlFmV0ZTcDVGYmEwYXhNdndwdFNWaDJa?= =?utf-8?B?cG5saVcvSVN2Z1VONkZLQ0YzRmNZYzBmM04zRlh2d2d0V21IQjJMTENhZ2FK?= =?utf-8?B?S2ltNGdFYmxMVXQ4K0tyMXRQY2tBaTM4aGpxNjQrNFNQVkZrNVo2OEhxSUZm?= =?utf-8?B?SEF0SlhsSUtkWUtTTi8xa2QvVjkrcjFsSlphcGFtSXNZOVFuZ2t3VUl3SFJT?= =?utf-8?B?Mlg5SXI4cmVNYi9lYWduTVlPYWlpSFkvc29Dc2Z2K1JRU0EvL0pOUGkzV094?= =?utf-8?B?QXBnc2phS01iK1UvRUM3VWpZQWdKc3U3UWtSekJSNnZ0MHhqbFA3eTRwWC9I?= =?utf-8?B?Z2RDRHc4YkhPbDNDWm9DNnRRRVIzU1FXc0ZueHUxNTc1dm0veGwrU0hNUEEr?= =?utf-8?B?YVlWQk1PQzFQeUxySGgrdmUrUU1PTEhMTFZuVlhtUWp1MjUvZnlGTFV2a01H?= =?utf-8?B?VjYxQ2VKVGJCVUpJb3c3clNpUnczVHoxV0s5MU0zZWdqV09yZTFyMFpqUkdX?= =?utf-8?B?KzVXVTYrTENYMnVMVjlpMElQbzFjZ0t4T3MxTGdwaUxCYUp1T3ZuMytHR2hn?= =?utf-8?B?b2lTVDBWTGRQc1YrQlh6dk1GaGovcVpPRmxsK0lYR01MNFVlakxEVjJSc2NQ?= =?utf-8?B?YXBuK1VxVFBvOTE2ZllWYjF2aWdETVRPbktIVng5WC9DbkFoVlg2VHJzZmMy?= =?utf-8?B?UGU4N0VVVmI2NkxTTFZhSllpNVA1ZGRjakVRNHpvZ3FhajhmbG9wYmtLQXFx?= =?utf-8?B?WkdDcXJsZlJ0TXVTMTN1YzdCa2thOXpQalJuLzZsblhjZ2xiM3hmWjA3dFdp?= =?utf-8?B?WmIzdVMxRjdTT0VFelhFbkJ5a2c0NlJKSHF3TG5zMXY4clRIK0UvLzdlUG9o?= =?utf-8?B?U2xKYUJGWXp2TFZ0Mms3bUxDVm5kQ2Y2RjdOVW5RVWxVbHBSZmtPVTNUV251?= =?utf-8?B?VXFKbVpRRlRFKzFsRkU4WGhKOEpKNXlMSEQxZ1A4UzVGcGNxWjBYak1PUEpk?= =?utf-8?B?THFNS1NEb0lXdkZGVGpUd1N0QURZd0hQVjU4dXcvUmhaM0VVak80TXdzVXZH?= =?utf-8?B?Z05SZ0ZYbVdFdUVjQ0V4QTE0eUNxd2pDUnNROXdwREdnZ1poZ1ZGdzFLbngr?= =?utf-8?B?RDdtRnBZRktaeEdaTWx1dlNFU2hMRUlNTE85Y0F1cGFQMWRJV2gybndGbmtz?= =?utf-8?B?NUxTaHVTQjlFaUk4UXUxeE9pbzh5WDlWdFhRUmFKamdSVnlHYmhoOXh6YkZH?= =?utf-8?B?NC9XVHEzS2NFWTh3MElTWG9GMzdnZDdYbWd4MnBCbTV6WitaeTdWYXdyREov?= =?utf-8?B?K1lrYTNlRTN1RTF2UnV1aFZNNStVMHhFM1RzK09TZGV6VFhIWXdEdGFaYjUw?= =?utf-8?B?cFFjT0RFeTlxQmhqbm50QXFEZ2NuNThoYlUrKzhpOUV6cnVDaExQRVh0cmUy?= =?utf-8?B?dkhkZG1DYTJ1V21CT1hiMVpuRHM3TFU1UzJBeE9hdWp0Vks3UldGL0F5TVZJ?= =?utf-8?B?OXhNTXV2TGVBK0lRVk1yYlNOUXc3bVRJOUpRRjlUVUdiSElpRW8vKzlRcUM3?= =?utf-8?B?YmVvUWYwbVp0N3ZHbENvb2RMdCtXcnFjK0FqRFM2MVhxUndsK3FwTXRlV1Jr?= =?utf-8?B?Vlk1ODhJTXRVMWZLc2tZUjVKWXhISDMxZVk2dWlvVDNhYU8vclBiMCtyQVpI?= =?utf-8?B?d2MrejNqU0Exa2d4NWVWbTRIVzRHMVh5WHZPeEttUEdDUkdXa3hzOHpUTm9P?= =?utf-8?B?T2VRckswSlY3dU9zdkFWUEp3NmxLYWxGZzhWVHovaDd1cko1M1hlUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: af930fe0-3fb8-49cd-0bfb-08da333e8992 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 11:08:11.6322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q+H8KuXFwfoERJ+nsgWtuh2OlMb8IHkgL9oQJCIFnAUlYVhbEGxeVtlLVgRkr+vxrUl9pgd6O01UEmF1/BRezA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4289 On Mon, Apr 25, 2022 at 10:43:45AM +0200, Jan Beulich wrote: > When a page table ends up with all contiguous entries (including all > identical attributes), it can be replaced by a superpage entry at the > next higher level. The page table itself can then be scheduled for > freeing. > > The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap > for whenever we (and obviously hardware) start supporting 512G mappings. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian Like on the AMD side, I wonder whether you can get away with only doing a cache flush for the last (highest level) PTE, as the lower ones won't be reachable anyway, as the page-table is freed. Then the flush could be done outside of the locked region. The rest LGTM. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 11:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326734.549341 (Exim 4.92) (envelope-from ) id 1nokHV-0004Rb-5j; Wed, 11 May 2022 11:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326734.549341; Wed, 11 May 2022 11:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokHV-0004RU-2w; Wed, 11 May 2022 11:13:25 +0000 Received: by outflank-mailman (input) for mailman id 326734; Wed, 11 May 2022 11:13:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokHU-0004RO-At for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:13:24 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f1d6ef1-d11b-11ec-a406-831a346695d4; Wed, 11 May 2022 13:13:23 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 9864A1F37E; Wed, 11 May 2022 11:13:22 +0000 (UTC) Received: from suse.cz (pathway.suse.cz [10.100.12.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id BC7822C141; Wed, 11 May 2022 11:13:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f1d6ef1-d11b-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652267602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FC1sflG6Id2SKeEdl4FJxU/B3titx078hgJ9iLge96M=; b=PzdYpVjDm9GZjow/EUq37H7ookCOkOdew3j+O3sWtMh70hNVOnxtZzKqOPpZDQnacwtKh8 hTKee3j+Sl0MntfBuf4Onekv+PULsWjOAIitLyhS1jfqtNLxp3KL+emXCY3ZW29THEdaU3 +LT7bZxhID8yMwqQ2reWXTGMidRsh/s= Date: Wed, 11 May 2022 13:13:20 +0200 From: Petr Mladek To: John Ogness Cc: Steven Rostedt , "Guilherme G. Piccoli" , Evan Green , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, Linux PM , linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Ard Biesheuvel , David Gow , Julius Werner Subject: Re: [PATCH 04/30] firmware: google: Convert regular spinlock into trylock on panic path Message-ID: <20220511111320.GB26047@pathway.suse.cz> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-5-gpiccoli@igalia.com> <20220510132015.38923cb2@gandalf.local.home> <87h75xkwg9.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h75xkwg9.fsf@jogness.linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) On Tue 2022-05-10 21:46:38, John Ogness wrote: > On 2022-05-10, Steven Rostedt wrote: > >> As already mentioned in the other reply, panic() sometimes stops the > >> other CPUs using NMI, for example, see kdump_nmi_shootdown_cpus(). > >> > >> Another situation is when the CPU using the lock ends in some > >> infinite loop because something went wrong. The system is in > >> an unpredictable state during panic(). > >> > >> I am not sure if this is possible with the code under gsmi_dev.lock > >> but such things really happen during panic() in other subsystems. > >> Using trylock in the panic() code path is a good practice. > > > > I believe that Peter Zijlstra had a special spin lock for NMIs or > > early printk, where it would not block if the lock was held on the > > same CPU. That is, if an NMI happened and paniced while this lock was > > held on the same CPU, it would not deadlock. But it would block if the > > lock was held on another CPU. > > Yes. And starting with 5.19 it will be carrying the name that _you_ came > up with (cpu_sync): > > printk_cpu_sync_get_irqsave() > printk_cpu_sync_put_irqrestore() There is a risk that this lock might become a big kernel lock. This special lock would need to be used even during normal system operation. It does not make sense to suddenly start using another lock during panic. So I think that we should think twice before using it. I would prefer using trylock of the original lock when possible during panic. It is possible that I miss something. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Wed May 11 11:17:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326741.549352 (Exim 4.92) (envelope-from ) id 1nokLK-00053A-N4; Wed, 11 May 2022 11:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326741.549352; Wed, 11 May 2022 11:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokLK-000533-KN; Wed, 11 May 2022 11:17:22 +0000 Received: by outflank-mailman (input) for mailman id 326741; Wed, 11 May 2022 11:17:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokLJ-00052t-Qr; Wed, 11 May 2022 11:17:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokLJ-00053O-NY; Wed, 11 May 2022 11:17:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokLJ-0007i4-86; Wed, 11 May 2022 11:17:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nokLJ-00017y-7e; Wed, 11 May 2022 11:17:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w0ju5s33i/Y02AereVlUx/FPEi2BwJq4nS84SAaSFZQ=; b=F/6Os8pAbhknosP6j1PQHMMPY2 gt2Jvx8QiwPIGXrxkXSO7wUyK0w28Wqbw441lfXPbwlMdo6TMr+Jj5Kl2tq3qkOY0eepcpGoQWBfP InWGfwqlO0Yw68Zgjb7ODnJPdCdgCE3/+lWHxnlxuCZuWyFOe9KGK1i4ITJInyCzH9+c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170323: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 11:17:21 +0000 flight 170323 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170323/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 932 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 11:31:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:31:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326750.549364 (Exim 4.92) (envelope-from ) id 1nokYN-0007Lp-Vv; Wed, 11 May 2022 11:30:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326750.549364; Wed, 11 May 2022 11:30:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYN-0007Li-Rb; Wed, 11 May 2022 11:30:51 +0000 Received: by outflank-mailman (input) for mailman id 326750; Wed, 11 May 2022 11:30:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYL-0007Lc-V8 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:30:49 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd5b756d-d11d-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 13:30:48 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165226864350095.43678669338908; Wed, 11 May 2022 04:30:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd5b756d-d11d-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1652268644; cv=none; d=zohomail.com; s=zohoarc; b=jLoifKJAGJBbdkF/nx+OyUVapFDhoEX6IESdtTkYJO0c/8cTEZKmAJvM1SPn5xqiIMeijwNlk+1kYJ9qrcIw29yeVCtVnHgtO1fvlDF9Obh7V6Qf7Pn7/Tj6+RRTpIrMrjB+7lg/Vn4Farf26TmrRCot180q86khZ16eNT9ptFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652268644; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=9KX9JOgfKWP1A767M+6u3o5bxrE0Qqs6j3qcikRX04c=; b=RIygfYMjXxyD6iF46I1V2YwCdjif/afVHkEFEvE48PqOQDZbmYFhFItEGE052rlfT44pQF3Il2yfOpr+NVqpKgQXDfjldvZSp4ZZ9h0aV+NDu4UfYZed7z7WfB7v1s4cpvtQInIcNrvmehCGxNmvlwvII3KuZadEKYru4W+TLek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652268644; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=9KX9JOgfKWP1A767M+6u3o5bxrE0Qqs6j3qcikRX04c=; b=a3WyQ5Z3+qA1yVjebWJBtxBgey9NE/VfFzdq+jtEWVRH9ESE4ASZ3O9JuW8lw4EA 0L71qQT7vaqX0SDlkWE7eqrqc9CTsUGnkIWp1WQY1D9qWG4+RNc1IbB+6fAfG/8nYDM Q08qO5O35JhxqgCchdgIoL0bt5dnlRn7GrijiZbo= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io Subject: [PATCH v7 0/2] Adds starting the idle domain privileged Date: Wed, 11 May 2022 07:30:33 -0400 Message-Id: <20220511113035.27070-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series makes it so that the idle domain is started privileged under the default policy, which the SILO policy inherits, and under the flask policy. It then introduces a new one-way XSM hook, xsm_transition_running, that is hooked by an XSM policy to transition the idle domain to its running privilege level. Changes in v7: - adjusted error message in default and flask xsm_set_system_active hooks - merged panic messages in arm and x86 setup.c to a single line Changes in v6: - readded the setting of is_privileged in flask_set_system_active() - clarified comment on is_privileged in flask_set_system_active() - added ASSERT on is_privileged and self_sid in flask_set_system_active() - fixed err code returned on Arm for xsm_set_system_active() panic message Changes in v5: - dropped setting is_privileged in flask_set_system_active() - added err code returned by xsm_set_system_active() to panic message Changes in v4: - reworded patch 1 commit messaged - fixed whitespace to coding style - fixed comment to coding style Changes in v3: - renamed *_transition_running() to *_set_system_active() - changed the XSM hook set_system_active() from void to int return - added ASSERT check for the expected privilege level each XSM policy expected - replaced a check against is_privileged in each arch with checking the return value from the call to xsm_set_system_active() Changes in v2: - renamed flask_domain_runtime_security() to flask_transition_running() - added the missed assignment of self_sid Daniel P. Smith (2): xsm: create idle domain privileged and demote after setup flask: implement xsm_set_system_active tools/flask/policy/modules/xen.if | 6 +++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/arch/arm/setup.c | 3 +++ xen/arch/x86/setup.c | 4 ++++ xen/common/sched/core.c | 7 +++++- xen/include/xsm/dummy.h | 17 ++++++++++++++ xen/include/xsm/xsm.h | 6 +++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 32 +++++++++++++++++++++++++- xen/xsm/flask/policy/initial_sids | 1 + 11 files changed, 77 insertions(+), 2 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 11:31:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:31:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326751.549375 (Exim 4.92) (envelope-from ) id 1nokYT-0007c9-7e; Wed, 11 May 2022 11:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326751.549375; Wed, 11 May 2022 11:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYT-0007c2-4I; Wed, 11 May 2022 11:30:57 +0000 Received: by outflank-mailman (input) for mailman id 326751; Wed, 11 May 2022 11:30:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYR-0007Lc-DO for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:30:55 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0e61187-d11d-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 13:30:54 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1652268645659361.20293440163834; Wed, 11 May 2022 04:30:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0e61187-d11d-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1652268646; cv=none; d=zohomail.com; s=zohoarc; b=HEFdJASsBIJxXEpFJZs38cWrleq7Yg853Mk300TeYwsFEuuRF5y1mVb3eiPDuXrtjNiNAC6DgNNx3w77PeLPcMgnyI+N5BBPrK3LNiDUk1KSxVA+gBPb0E6W+RxPFFVrxRgp5RXIQREy8GMwl3QQ4Ozabt/Dq64Qa95xCvMt0cc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652268646; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=D39sTUsA8vn8SIfVh+zWHQ8erAiz1Zbi0VHvUTNhPgU=; b=QxtRf8EX308SPrw2WfnJ/FHMRFbjTF8h4faVX/pKkpo0dkYAU3SI795EDKWu5vrEu30grxAMi7W6XoRiEyA9GFZeg8XgELvipFv2iXxVPvl5tkbH7D5uc6WiQmScYrIYXd/v9y9+IJrXCI7oKHFEdT5JzO5Gn8b7qoRMaggR4bE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652268646; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=D39sTUsA8vn8SIfVh+zWHQ8erAiz1Zbi0VHvUTNhPgU=; b=DOLs36lDollgJnwO/DKKXsPkLCGM6sOxJkUmQ1FJshPZqDynnBnUuBjuqovSZTtM N6kdeIdNAAu9yFi5xwzcgK+QZ6IV60x43EcRIhEdK9MJRgEm28mHoT8ftmMOlp04L5d 2T8mWx8mqvm3Ez1MiKalTLQBIF3ZVgymC/zN8M+Y= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: [PATCH v7 1/2] xsm: create idle domain privileged and demote after setup Date: Wed, 11 May 2022 07:30:34 -0400 Message-Id: <20220511113035.27070-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220511113035.27070-1-dpsmith@apertussolutions.com> References: <20220511113035.27070-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External There are new capabilities, dom0less and hyperlaunch, that introduce internal hypervisor logic which needs to make resource allocation calls that are protected by XSM access checks. This creates an issue as a subset of the hypervisor code is executed under a system domain, the idle domain, that is represented by a per-CPU non-privileged struct domain. To enable these new capabilities to function correctly but in a controlled manner, this commit changes the idle system domain to be created as a privileged domain under the default policy and demoted before transitioning to running. A new XSM hook, xsm_set_system_active(), is introduced to allow each XSM policy type to demote the idle domain appropriately for that policy type. In the case of SILO, it inherits the default policy's hook for xsm_set_system_active(). For flask a stub is added to ensure that flask policy system will function correctly with this patch until flask is extended with support for starting the idle domain privileged and properly demoting it on the call to xsm_set_system_active(). Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk Reviewed-by: Luca Fancellu Acked-by: Julien Grall # arm --- xen/arch/arm/setup.c | 3 +++ xen/arch/x86/setup.c | 4 ++++ xen/common/sched/core.c | 7 ++++++- xen/include/xsm/dummy.h | 17 +++++++++++++++++ xen/include/xsm/xsm.h | 6 ++++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ 7 files changed, 60 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed4..7f3f00aa6a 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset, /* Hide UART from DOM0 if we're using it */ serial_endboot(); + if ( (rc = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", rc); + system_state = SYS_STATE_active; for_each_domain( d ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 6f20e17892..57ee6cc407 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -620,6 +620,10 @@ static void noreturn init_done(void) { void *va; unsigned long start, end; + int err; + + if ( (err = xsm_set_system_active()) != 0 ) + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); system_state = SYS_STATE_active; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..7b1c03a0e1 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3021,7 +3021,12 @@ void __init scheduler_init(void) sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US; } - idle_domain = domain_create(DOMID_IDLE, NULL, 0); + /* + * The idle dom is created privileged to ensure unrestricted access during + * setup and will be demoted by xsm_set_system_active() when setup is + * complete. + */ + idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged); BUG_ON(IS_ERR(idle_domain)); BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu)); idle_domain->vcpu = idle_vcpu; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 58afc1d589..77f27e7163 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -101,6 +101,23 @@ static always_inline int xsm_default_action( } } +static XSM_INLINE int cf_check xsm_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("%s: should only be called by idle domain\n", __func__); + return -EPERM; + } + + d->is_privileged = false; + + return 0; +} + static XSM_INLINE void cf_check xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..8dad03fd3d 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t; * !!! WARNING !!! */ struct xsm_ops { + int (*set_system_active)(void); void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); int (*domain_create)(struct domain *d, uint32_t ssidref); @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops; #ifndef XSM_NO_WRAPPERS +static inline int xsm_set_system_active(void) +{ + return alternative_call(xsm_ops.set_system_active); +} + static inline void xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index 8c044ef615..e6ffa948f7 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -14,6 +14,7 @@ #include static const struct xsm_ops __initconst_cf_clobber dummy_ops = { + .set_system_active = xsm_set_system_active, .security_domaininfo = xsm_security_domaininfo, .domain_create = xsm_domain_create, .getdomaininfo = xsm_getdomaininfo, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 0bf63ffa84..54745e6c6a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) return 0; } +static int cf_check flask_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("%s: should only be called by idle domain\n", __func__); + return -EPERM; + } + + /* + * While is_privileged has no significant meaning under flask, set to false + * as is_privileged is not only used for a privilege check but also as a type + * of domain check, specifically if the domain is the control domain. + */ + d->is_privileged = false; + + return 0; +} + static void cf_check flask_domain_free_security(struct domain *d) { struct domain_security_struct *dsec = d->ssid; @@ -1766,6 +1788,7 @@ static int cf_check flask_argo_send( #endif static const struct xsm_ops __initconst_cf_clobber flask_ops = { + .set_system_active = flask_set_system_active, .security_domaininfo = flask_security_domaininfo, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 11:31:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:31:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326757.549386 (Exim 4.92) (envelope-from ) id 1nokYo-0008IN-NB; Wed, 11 May 2022 11:31:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326757.549386; Wed, 11 May 2022 11:31:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYo-0008HZ-Ji; Wed, 11 May 2022 11:31:18 +0000 Received: by outflank-mailman (input) for mailman id 326757; Wed, 11 May 2022 11:31:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokYn-0007Lc-Ct for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:31:17 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de0ccf78-d11d-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 13:31:16 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165226864714325.67414717269844; Wed, 11 May 2022 04:30:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de0ccf78-d11d-11ec-8fc4-03012f2f19d4 ARC-Seal: i=1; a=rsa-sha256; t=1652268648; cv=none; d=zohomail.com; s=zohoarc; b=D6uP4uT9naQVIGCeYXwk5L/VePPNAdvCD4tmr1PUlmCCY6piGeDSwgLkHF9TPUpIl4Q4hML+unEmkd7a0fHo+ZGyUmeux/0BhxJzXIkAt1qSd+f5rFyiUxQVGxJHAwhQIOTrx34PJnVAAB7wO7FOM4vKlg+tOzGUNAiYqVM/TVo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652268648; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hkWOGdVR53Th3WCm22Vk3Yr26Y7pg3WljGO1MmeKPeA=; b=DukcWnWoILo6XTnvt2N+SZ8JU0JegHAmuLNj+rFanDG9JNDCmwSoT6C9Hrl61cEdtdwSqGQaeZoZnULYSYywuJqdelf0+r9a662nhGvBPMzlnHKSBAlA5eA8h2nY6FXweOqpRbeJG4Vsvm1QGGUTWPLELn0Zx13yArX/V4FIIbs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1652268648; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=hkWOGdVR53Th3WCm22Vk3Yr26Y7pg3WljGO1MmeKPeA=; b=o4YNBjqg5tKpgzmtYVf8rY25gt0MJo8KFB3Rmd3jje4AgStDGoZGHKAAPs7z8lqd 7R7MbGiFXKeM94atRkoH/fXYl1ybI1b2iC87NNbR8dLjSgrkKuCgVtEAYiSKhw7zfr/ r7FfSaKF0U8P3qZJiOlBBglCTukyh9Ie7xRrjEXc= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Luca Fancellu , Daniel De Graaf , Wei Liu , Anthony PERARD Subject: [PATCH v7 2/2] flask: implement xsm_set_system_active Date: Wed, 11 May 2022 07:30:35 -0400 Message-Id: <20220511113035.27070-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220511113035.27070-1-dpsmith@apertussolutions.com> References: <20220511113035.27070-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit implements full support for starting the idle domain privileged by introducing a new flask label xenboot_t which the idle domain is labeled with at creation. It then provides the implementation for the XSM hook xsm_set_system_active to relabel the idle domain to the existing xen_t flask label. In the reference flask policy a new macro, xen_build_domain(target), is introduced for creating policies for dom0less/hyperlaunch allowing the hypervisor to create and assign the necessary resources for domain construction. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk Reviewed-by: Luca Fancellu Tested-by: Luca Fancellu --- tools/flask/policy/modules/xen.if | 6 ++++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/xsm/flask/hooks.c | 9 ++++++++- xen/xsm/flask/policy/initial_sids | 1 + 5 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if index 5e2aa472b6..4ec676fff1 100644 --- a/tools/flask/policy/modules/xen.if +++ b/tools/flask/policy/modules/xen.if @@ -62,6 +62,12 @@ define(`create_domain_common', ` setparam altp2mhvm altp2mhvm_op dm }; ') +# xen_build_domain(target) +# Allow a domain to be created at boot by the hypervisor +define(`xen_build_domain', ` + allow xenboot_t $1_channel:event create; +') + # create_domain(priv, target) # Allow a domain to be created directly define(`create_domain', ` diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te index 3dbf93d2b8..de98206fdd 100644 --- a/tools/flask/policy/modules/xen.te +++ b/tools/flask/policy/modules/xen.te @@ -24,6 +24,7 @@ attribute mls_priv; ################################################################################ # The hypervisor itself +type xenboot_t, xen_type, mls_priv; type xen_t, xen_type, mls_priv; # Domain 0 diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids index 6b7b7eff21..ec729d3ba3 100644 --- a/tools/flask/policy/policy/initial_sids +++ b/tools/flask/policy/policy/initial_sids @@ -2,6 +2,7 @@ # objects created before the policy is loaded or for objects that do not have a # label defined in some other manner. +sid xenboot gen_context(system_u:system_r:xenboot_t,s0) sid xen gen_context(system_u:system_r:xen_t,s0) sid dom0 gen_context(system_u:system_r:dom0_t,s0) sid domxen gen_context(system_u:system_r:domxen_t,s0) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 54745e6c6a..80b36cc2d8 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) switch ( d->domain_id ) { case DOMID_IDLE: - dsec->sid = SECINITSID_XEN; + dsec->sid = SECINITSID_XENBOOT; break; case DOMID_XEN: dsec->sid = SECINITSID_DOMXEN; @@ -188,9 +188,14 @@ static int cf_check flask_domain_alloc_security(struct domain *d) static int cf_check flask_set_system_active(void) { + struct domain_security_struct *dsec; struct domain *d = current->domain; + dsec = d->ssid; + ASSERT(d->is_privileged); + ASSERT(dsec->sid == SECINITSID_XENBOOT); + ASSERT(dsec->self_sid == SECINITSID_XENBOOT); if ( d->domain_id != DOMID_IDLE ) { @@ -205,6 +210,8 @@ static int cf_check flask_set_system_active(void) */ d->is_privileged = false; + dsec->self_sid = dsec->sid = SECINITSID_XEN; + return 0; } diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids index 7eca70d339..e8b55b8368 100644 --- a/xen/xsm/flask/policy/initial_sids +++ b/xen/xsm/flask/policy/initial_sids @@ -3,6 +3,7 @@ # # Define initial security identifiers # +sid xenboot sid xen sid dom0 sid domio -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 11:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 11:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326772.549397 (Exim 4.92) (envelope-from ) id 1nokmo-0001kT-WD; Wed, 11 May 2022 11:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326772.549397; Wed, 11 May 2022 11:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokmo-0001kM-T8; Wed, 11 May 2022 11:45:46 +0000 Received: by outflank-mailman (input) for mailman id 326772; Wed, 11 May 2022 11:45:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nokmn-0001kG-J3 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 11:45:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3b1841e-d11f-11ec-a406-831a346695d4; Wed, 11 May 2022 13:45:44 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3226C21B6B; Wed, 11 May 2022 11:45:43 +0000 (UTC) Received: from suse.cz (pathway.suse.cz [10.100.12.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 043992C141; Wed, 11 May 2022 11:45:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3b1841e-d11f-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652269543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Q+AKogAFqrapMhSKhemsZfgkWqWDsARusHusUCyiK4=; b=iY95HDQGs4qC23cq77bOCFTEdU/S8O5CyJ+RlnRZnMkkUzmn+I2Mm5/bPWA2BvWJDPDEv9 JwfZEqzAICGf45PeIFuZlFjlIC7fxZJfv9Ryxp3gi9axon0On+MdUW3HdUoK9u0ccTLMhL Yjmk7zW6CuGXpaXXuOUQvYlsrSO1r9M= Date: Wed, 11 May 2022 13:45:41 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers Message-ID: <20220511114541.GC26047@pathway.suse.cz> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-18-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-18-gpiccoli@igalia.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Wed 2022-04-27 19:49:11, Guilherme G. Piccoli wrote: > Currently the tracing dump_on_oops feature is implemented > through separate notifiers, one for die/oops and the other > for panic. With the addition of panic notifier "id", this > patch makes use of such "id" to unify both functions. > > It also comments the function and changes the priority of the > notifier blocks, in order they run early compared to other > notifiers, to prevent useless trace data (like the callback > names for the other notifiers). Finally, we also removed an > unnecessary header inclusion. > > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -9767,38 +9766,46 @@ static __init int tracer_init_tracefs(void) > > fs_initcall(tracer_init_tracefs); > > -static int trace_panic_handler(struct notifier_block *this, > - unsigned long event, void *unused) > +/* > + * The idea is to execute the following die/panic callback early, in order > + * to avoid showing irrelevant information in the trace (like other panic > + * notifier functions); we are the 2nd to run, after hung_task/rcu_stall > + * warnings get disabled (to prevent potential log flooding). > + */ > +static int trace_die_panic_handler(struct notifier_block *self, > + unsigned long ev, void *unused) > { > - if (ftrace_dump_on_oops) > + int do_dump; > + > + if (!ftrace_dump_on_oops) > + return NOTIFY_DONE; > + > + switch (ev) { > + case DIE_OOPS: > + do_dump = 1; > + break; > + case PANIC_NOTIFIER: > + do_dump = 1; > + break; DIE_OOPS and PANIC_NOTIFIER are from different enum. It feels like comparing apples with oranges here. IMHO, the proper way to unify the two notifiers is a check of the @self parameter. Something like: static int trace_die_panic_handler(struct notifier_block *self, unsigned long ev, void *unused) { if (self == trace_die_notifier && val != DIE_OOPS) goto out; ftrace_dump(ftrace_dump_on_oops); out: return NOTIFY_DONE; } Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Wed May 11 12:11:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:11:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326780.549408 (Exim 4.92) (envelope-from ) id 1nolBZ-00053H-5f; Wed, 11 May 2022 12:11:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326780.549408; Wed, 11 May 2022 12:11:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolBZ-00053A-2a; Wed, 11 May 2022 12:11:21 +0000 Received: by outflank-mailman (input) for mailman id 326780; Wed, 11 May 2022 12:11:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolBW-000533-Nz for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:11:19 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7402aaca-d123-11ec-a406-831a346695d4; Wed, 11 May 2022 14:11:15 +0200 (CEST) Received: from mail-dm3nam07lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 08:11:13 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by CY4PR03MB3240.namprd03.prod.outlook.com (2603:10b6:910:5b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 12:11:10 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.013; Wed, 11 May 2022 12:11:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7402aaca-d123-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652271075; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=yyaq47ym0IrC1kxWgarnWjcd3rUQg8XRgrh0gxXZqOw=; b=TPt3fCQBvznfcTL0zXrWS56TSCoWybpi1QSWUJtuPCjKCOWDr1aL9EY2 yydhcME38hAJUwLk0uz3J9F2SQ5wVen2buwuR7g6HOuGVgp+2VEL1TARD rhr9drEOdDG52ENmN0lXJB8iqmKxCSLTp4DK+AFqlx1w8QZ+A/yFrenIZ c=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 70450573 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:h0t/Eat5XhiuqYKxbOIAL0XyyefnVN9fMUV32f8akzHdYApBs4E2e 1ou7Vv2eabdPDOxPpsjdtz1pnqyiubUnINiHgRq+ygyHn4apZPPCI/Ddxr6ZSicIJSeHBxtt J1EYdKRdZ1qFXaD/hmjbbS7pHMk3v7VHLetBOSaYS4oLeMIpF/NrDo68wJuqtI40bBVej+wh O4eg/EzGXf+0DMsPj5I5f6N+Roy466psmwS5g03P6tCslaDxiFEVMNDKfm9IUWjT9gPFIZWZ QpiIJJVXI/9101wYj9wuu+jKiXmepaLYU7WzCA+t5GK2nCunARrukoAHKdaOB4/ZwmhxYgrk o0Q7MXoE2/FA4WX8Agje0gAe81BFfUuFI/veRBTZuTKkiUq21O1qxlfJBle0b8wo46bMkkXn RAsExgfbwjrug6D6OnTpt+AJCgUBJKD0Is34hmMxNxCZBosacirr67ivbe00Nqs7yzn8Dm3i 8cxMFJSgBr8jxJnHg4WMrg5s+SRliOgdzJ9pAOF5odp7D2GpOBx+OCF3Nv9XPWvHZ8QsmPD4 2XM8iL+Hw0QM8GZxXyd6HWwi+TTnCT9HoUPCLm/8f0si1qWroARIEROCR3n/r/k1AjiB7qzK GRNksYqhYc/81akQ5/RQhu8qWastR8AQdtAVeY97Wlhz4KLu1rEXjVbFVatbvQ3iOIIHm0nx GOusP/RFAdrk4eEc1m0o+L8QTSafHJ9wXU5TS0ZSQoI5fHzrYd1iQjAJv5zHajwgtDrFDXYx zGRsDN4l7gVldQM1aiw4RbAmT3EjoPSUgc/6wHTX2SkxgB0foioY8qv81ezxfRKIZudT1KBl GMZgMXY5+cLZbmSkASdTeNLG6umj8tpKxXZiF9rWpUkrDKk/ib8eZgKuG0iYkB0LswDZDnlJ lfJvh9c74NSO33sarJrZ4W2CIIhyq2I+cnZa804p+FmOvBZHDJrNgk3DaJM9wgBSHQRrJw= IronPort-HdrOrdr: A9a23:tjOMt6O/3gAiysBcT23155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMQs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YtT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29JOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6T030Woqqg9jJwPr3PtiEnEESotu9uXvUkZ1S2hkF3nAho0idsrD CDmWZnAy050QKtQoj8m2qQ5+Cn6kdg15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjeseMftR9B6NmOQgeisa4HZcm0BS2NL7TkYvI7c2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFEgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCvefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzvewPcV T6ISdlXEIJCjLT4Je1rex2Gzj2MRaAdCWozN1C7J5kvbC5TKb3MES4OSUTr/c= X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="asc'?scan'208";a="70450573" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsbPoRG7/VnQapjb6KjcflAa/UdzyVMZQX933MKDmqYph+FwnBVSeHIEZIsN6a0V29YrtMs1DLqSPaZw+lVBq8ewcC1r/Qrm3e1xetnapAoMH9Sx5EtJW/Fqb3xkUYPNRCcu9e7pBONK8IQjphu/kgLu7BDVBM81Akr6ESHmkJ66pFzaMzLR0o4cr0gib1iDGd8KcE+Njfg5W8CDQAuujR2MzcEot07xUF/AiB8EG5MYWz8xbEPqICEV7G/xRJ3/FpZmN+w5dVsU8iawHN9Yy2I7rmtGLXvdsAoNxv2sWCXSAMPETeEGF9Hy5SUoHkXGX5HM0V5Xfzn61V/61CcexA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PEAGvmT1r8JHE4bBsqndB0/XJo3mx34/Ko/BlcG3Uc=; b=g1yChLrVXhH0pG1tB57M4omxdGCBQJBPFWcjheWsDOIx6H4c5J0TSukxx6w/fu2MsRBOvtXjaJ22KHpAxAgpXp5kCfsq2h+nqmLueH0rPcKUpHIo7K/9KYxjxn1yDU+2W5ioyy1JIjgH5Dwbzk4Jzmy1XopKRXTLCxcTD3zPWy34EL4gSYMe3t8YcjGQ7KC5TfsLDrHBPa2YHH9VxK1XucgmnIdLH3OmVHSnZYEFMy7RCvf4NaYe3oxsL+wv8jwdU+uSQpht5a65GZmWWk2kRGmqYTJlLkhDmlzE7cWZD+V5Ifep/U5qrIiJyK0YUGQ7i3fvTiQqTzYYZMcdhWEIbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PEAGvmT1r8JHE4bBsqndB0/XJo3mx34/Ko/BlcG3Uc=; b=skMpF5l5czqgSRM6f/KnYfUP6w5bIsirFjQsiPooIxn25cqtPerklu/9adtIVbG9p6Y1R6AYVGwf1vshEgB2S608wmZMmIkBdoCOjhCcneqJA8D7K06gPzXmpMKRsBM72ijwAFIkPmdX4SXGjOqTFeKvvshZZTTdqHSmkd5V7lo= From: George Dunlap To: Julien Grall CC: =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v3 4/6] xen: Switch to byteswap Thread-Index: AQHYZFbwaRkB21bteEenSH2F95dix60X7v0AgAFJfgCAACKyAIAAPIqA Date: Wed, 11 May 2022 12:11:10 +0000 Message-ID: <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> In-Reply-To: <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45895fd3-dca8-4996-1795-08da33475601 x-ms-traffictypediagnostic: CY4PR03MB3240:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SpZwhT74lOfBfV4SCYk7rA1gLpFqdX0NpnftY1ZDtN07GJ5r1glzFMpma00kZrw/fVDeOLREp/NqQ+czm/H2H1e1ARnFECh/er30UF5aSZF+cAxrt8R0gAKQYOq7Y2fIeTG58LHiMGiXqKYFv0hctBVeb6/3fKUt/BO0AoUDPFtPPxlTZsWOP7t6zgJueSTXhcozizFL8Utgi8uY0YZxH2ijj8s0QOUgFFCUZh/Mcff1oKs2oSltVxEAPu+iMUSoAVEXGSN6FCvN5DNWiEVfbB0Lmes0UQFGzTEZxubb1n0iAS3MXFS2vhARLY7Npoy8w9La/dcjfN5l0/Ofm3CJ48lHp05xQw/AB6bSxxyzS4uRqpA6S3o0fDfm+xyUP2T7i4mBdVQh35M7Dke4Uz8k0jrgEAFazkgtBTbfY9WTMdUqR6QSFV7hCutycUBsndsW+T8f4vFuJSKHrprajqfJ0Ut3ZiEzsxs88G0fsdK0E37qyv9E/4bv0l8BQ1cosBqwEtKg/4nDCN/KldXOZK6qP3HzE6NHDwc9f1Cvav2FmI80gEWPoCwAnqpOg0JiAnjxk7up8rVH1QulcZbqXXNymmcpnZmG0+HJoElzjyCVPBJ2CQNGwjwMpVCKX3L/pcB36j0zBfBTE+QKcq+IjhvY5mNk7K/1Tlixdo43RdepmEa2bRyzTBT4hMqn/IXnSydFP53IqPhyTNZVlE2ICqRMP/TSWlbIz2RsyTqZtFLvIszO7ezWxq5XBUKiF/7QpKss2giULDFqZ8uMuJ/6E7qFbrj1kiodl3y5zQ5oq6jAcFogwkxwQa9AMqkxGWIvsIj8cs5NT0ovZSPX6UHmuKDBBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(53546011)(64756008)(6512007)(5660300002)(99936003)(38070700005)(83380400001)(36756003)(966005)(71200400001)(508600001)(26005)(6486002)(33656002)(4326008)(86362001)(2616005)(2906002)(316002)(54906003)(6916009)(38100700002)(186003)(82960400001)(122000001)(76116006)(91956017)(8936002)(66446008)(66476007)(66556008)(66946007)(8676002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TFB5ck9DaWgyQUcxTTdnMnUyTzRTS0t3bU16a29UZ0h2c3lGY2hHd0VqaHU4?= =?utf-8?B?U1N4d2dCaFRhaVdqVElxdFJiVHBPVFUra0VXSFpyL2UzZWU3NFdzdkdCK3Vu?= =?utf-8?B?NGNOQzVlMktBZmdtWnZSK2ZobnFrMEtGOU5ubWdBb2FzQWN3N0QzcTRWckdE?= =?utf-8?B?ZTNvL3o3akVCNDhTK1RkbE5GbnhIZ0lqOFg5aHYrVXpJK1VxMkp0S2VoQmJ4?= =?utf-8?B?N01aL3FHWXpvVjl1VzZMQkdJY0pNcWM4a0hDRndaRVR2ZHZRbGd1MWxGbHl5?= =?utf-8?B?d3k1NXUzclEycCt2QXN0aVVyNTErRTQvNXhlaks4RWNKaVE0R0JaQ1ExYm1o?= =?utf-8?B?bEpEMjhlMnlrTCtqM1V4SHB0aUQ5Q2dlekdoSW93M3FFdHJpU2hBV2o4emhq?= =?utf-8?B?QmFZeHg5czhZVU1MTjNsd09DZWxKbU1aZDV2QnhpYmZGaUFnblhKQmFLVEJ3?= =?utf-8?B?WjZNRW43WEEreTlwckdvVnB6Y2pweXRIV004dEtYRm1yS3RGWkF5V0pEZGJT?= =?utf-8?B?cXdzRDZtZ2tuYWpob1AvZ2g5aUxxZnl5Y2JoOXJJZ0hPK0hhVFFyZHJPVUlI?= =?utf-8?B?emU5aC9LZFJxUWhFU2tmd0pRVmdnKzR4citHTzlETHJRNk8ydnRUWmdjbEk2?= =?utf-8?B?blltZlkxVmhyTzM1NlJJNE5rb0dMdVBrWmtsTHBVbUd3d2VIMFM0ZVBWckox?= =?utf-8?B?K2YyQ2RyWHZzWnVLM3hMUXVzbUoyY3R0YllRbkpBU215WTAzVWswNzBZTGQ3?= =?utf-8?B?emVEQ1pSa2RVSTRvOTFpWG9RSFVwV0FUN3QzRDNFSUNBVFdvMk01dmw0YTJO?= =?utf-8?B?SDk0T2pjc0xJY29DYzZtVUZ1dXVMQUdxSVNKdTJINDg5Z1RnU1dqMi9mcW1j?= =?utf-8?B?aHZoWVNHS3dkTWpnWnE3WVdWZGhzSTlpV1Q0Uml3bkVid1FWSkZLNjh1QXA0?= =?utf-8?B?Vk94eEhiNy95RXhpbzY2S3RLRlBCRmZycGhYOC9YUTlTbVhUZnhvS2ZldlFx?= =?utf-8?B?MjB6a2xoMXRNZmJIeitZUlZlUXNrMG5iblJRNjJxOGZaMU1FdnJvcW9Tc2RJ?= =?utf-8?B?cmtBcFFEOFFxMXlPUllxOGtWWTVnTlMzK0J5aHN0MXptaU9Fcm5qcEFqQ3I2?= =?utf-8?B?SjR6RVlDT1UwSk5qK1k3NG1JMXRsM2VVbHExNDNLU0lhd0ZER1d2c1VHdkoy?= =?utf-8?B?dUZGcmt4V05yOWlmWXllT2FsTlZuM3N1Zm5RSWw2aCs2SmdCK1NMNnF5bzlP?= =?utf-8?B?Y2FoNnpMbkVoaU1tN1hjRU1oYjZTUHRUbHRFRTkyaVlSWWE0QkpIRWJBS1VX?= =?utf-8?B?SkI5TjU3ZTRJS2RpdytmV1lhWHk1Nkc4bkVsaGpBTUNrTnM0Y0diS0lHcEht?= =?utf-8?B?OEFtWU9PNnhta1o0c2h6ODIra0xPY3VrY0xUS0ZuUEwzUU5CMmVXYWVGRG54?= =?utf-8?B?YUd1L2J1VFhOenZwZFNpUmdoTjgxcWJjRVR3U0xtUnBOVGlvN08ycjlqSVFW?= =?utf-8?B?OXRpZzYwZm15SnpYNjBKcUo5dVB5bi9DU1NzSTBDUlZVSHlxd2xaTnRXZ082?= =?utf-8?B?S1FmYW1rTWZlNlBXSU9VT2RkNmRma2NEVUVkYlpadDhENGp5NVU1MFo0MTh6?= =?utf-8?B?YTlwQ3NIQVFYQ0ZMZXpzUEtpQWpoL0NTN0M1WlF2QnpDZGVNV2FFM3JZcVhv?= =?utf-8?B?NW9EUEhnTktRU1d0YWVkKzJJeC9ZWmExZnJPUEluRkhzalJkbW0ya0c1MGQx?= =?utf-8?B?SGFDTTJUdnZDS0d1VG9KczErTVVac0xZUk1RMHpOdGJrVmxhaVdnbTNWTUxx?= =?utf-8?B?TXhNZ0JOK1dzNSswN2V2R3NueVNoNkd5T2RlN1JGZVZyMlZXTE1mMEtieWMv?= =?utf-8?B?dGtHZ2JmTWlJck9wYjAxQTMrRkptdDRDRFkzamZaT24xVWw0cEFLdi9qNHFa?= =?utf-8?B?cnN6aUdjNkc2OVdsOG8vOTgvaDQxYStkUDlXdXBncDVKZVRrLy9zalpBMEJ0?= =?utf-8?B?SUNkTGNpcFc4ZEltYzZQMFRxaVBSa0ZTa2NHWkgyS05PUUtnbmNMTkV3R3dN?= =?utf-8?B?TEpNTGcxS1VqNk1hVEtvZUllRU9HMSs5RUZ2MFRSTVgxbnFwdlg1bWFwM3g5?= =?utf-8?B?SUpnNkVHblpVRVVTQlhTeCtpYmpIVmhvUmF4VENNQ0hTUXpkdUtpaHlwSlZn?= =?utf-8?B?anA5am9GUkRZOWFsNjhDS1BDNE9MemtXSTM5M0ZpMzNFQlVqMUN5eXRzVXVZ?= =?utf-8?B?d0V5Y3NwdS8rK3RxUnU2cURMY2I3b3ZPRVNlRXp2eGprUVM3b056V283cGJz?= =?utf-8?B?YnNYczRqWndKMU5LWnE2cDYzT25OcERWeXNLUXN4SXZkRXh2b2JGRHljbkdC?= =?utf-8?Q?8JQiE8akAFrgt5Vw=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_11552911-C933-4D79-8517-C295F3A11C8E"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45895fd3-dca8-4996-1795-08da33475601 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 12:11:10.4484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UTgGgrcQ+LQzHnc73pM6uO3XnbUGkrYAx25Y5JK1luhdQZFIzVfjPtI5SN5p5xaegKS7D39TXpX5juaq76m7ZAEIPN3p9MW3GIL9s2/ED4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3240 --Apple-Mail=_11552911-C933-4D79-8517-C295F3A11C8E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 11, 2022, at 9:34 AM, Julien Grall wrote: >=20 > Hi, >=20 > Please configure your e-mail client to send in plain text. >=20 > On 11/05/2022 07:30, Lin Liu =EF=BC=88=E5=88=98=E6=9E=97=EF=BC=89 = wrote: >> Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap >> On 10/05/2022 11:15, Lin Liu wrote: >>> Update to use byteswap to swap bytes. >>>=20 >>> No functional change. >>>=20 >>> Signed-off-by: Lin Liu >>> --- >>> Cc: Stefano Stabellini >>> Cc: Julien Grall >>> Cc: Andrew Cooper >>> Cc: George Dunlap >>> Cc: Jan Beulich >>> Cc: Wei Liu >>> Changes in v3: >>> - Update xen/common/device_tree.c to use be32_to_cpu >>> - Keep const in type cast in unaligned.h >>> --- >>> xen/common/device_tree.c | 44 = +++++++++++++++--------------- >>> xen/common/libelf/libelf-private.h | 6 ++-- >>> xen/common/xz/private.h | 2 +- >>> xen/include/xen/unaligned.h | 24 ++++++++-------- >>> 4 files changed, 38 insertions(+), 38 deletions(-) >>>=20 >>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>> index 4aae281e89..70d3be3be6 100644 >>> --- a/xen/common/device_tree.c >>> +++ b/xen/common/device_tree.c >>> @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct = dt_device_node *np, >>> if ( !val || len < sizeof(*out_value) ) >>> return 0; >>>=20 >>> - *out_value =3D be32_to_cpup(val); >>> + *out_value =3D be32_to_cpu(*val); >>> This code has been taken from Linux and I would rather prefer to = keep >>> the *cpup* helpers to avoid any changes when backporting. >>> diff --git a/xen/include/xen/unaligned.h = b/xen/include/xen/unaligned.h >>> index 0a2b16d05d..16b2e6f5f0 100644 >>> --- a/xen/include/xen/unaligned.h >>> +++ b/xen/include/xen/unaligned.h >>> @@ -20,62 +20,62 @@ >>>=20 >>> static inline uint16_t get_unaligned_be16(const void *p) >>> { >>> - return be16_to_cpup(p); >>> + return be16_to_cpu(*(const uint16_t *)p) >>> I haven't checked the existing implementation of be16_to_cpup(). >>> However, this new approach would allow the compiler to use a single = load >>> instruction to read the 16-bit value from memory. So this change may >>> break on platform where unaligned access is forbidden (such as = arm32). >>> } >>>=20 >>> static inline void put_unaligned_be16(uint16_t val, void *p) >>> { >>> - *(__force __be16*)p =3D cpu_to_be16(val); >>> + *(__be16 *)p =3D cpu_to_be16(val); >>>> Why did you drop the __force? >> Google told me __force is used in linux kernel to suppress warning in = sparse, >> = https://stackoverflow.com/questions/53120610/what-does-the-attribute-force= -do >> Is sparse also used in xen? >=20 > I am not aware of any use of Sparse in Xen, but it would technically = be possible. >=20 > However, my point here is more that this change seems to be unrelated = to what the patch is meant to do (i.e. switching to byteswap). So if it = is unnecessary, then it should be dropped from this patch. I think making people pull little changes like this out into separate = patches is asking too much. It=E2=80=99s a lot of extra effort on the = part of the submitter for basically no value. We commonly do little = clean-ups like this in patches, and just require a comment at the = bottom, like this: 8<=E2=80=94 While here: - Drop =E2=80=98_force=E2=80=99 keyword, which is only needed when = running the Sparse analysis tool =E2=80=94>8 I do agree that minor changes like this need to be described, so that = people 5 years from now have some hope of figuring out what=E2=80=99s = going on. -George --Apple-Mail=_11552911-C933-4D79-8517-C295F3A11C8E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJ7p90ACgkQshXHp8eE G+0xMgf8CJvnQNDl2H/W9hMGUaRQWC3orwUyUdjGPbPIDTdFOgt45C5mqXrDrt/1 SpVRGvxzlNflHN/P6ZeHo2uNIwA9znCYO08vE7mi8ZH5OUJDOImGPZWW6QfrvDOQ 3eh1yfp7C3D9+6dFwzzh+KcLQesDZll7PaMku6YSlLU6sdr3wFQ8YMeZk2GV1rSj bCL564hw3xq3ZA9eFie7Zn5+Dwt5CqOzVvJPPEhS4Gb5qy+dgwSAu/qTTLK7CdpS Y0Z/e5Oa353mBZZEckvfaou9no4SjfW2n/j8HiErsoP9jImb5517s5YbMutMAXvq 65i6gUIMDXeOVUQIstWnBYQYpZd+Kw== =COAa -----END PGP SIGNATURE----- --Apple-Mail=_11552911-C933-4D79-8517-C295F3A11C8E-- From xen-devel-bounces@lists.xenproject.org Wed May 11 12:28:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:28:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326787.549419 (Exim 4.92) (envelope-from ) id 1nolS9-0006gJ-I7; Wed, 11 May 2022 12:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326787.549419; Wed, 11 May 2022 12:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolS9-0006gC-E6; Wed, 11 May 2022 12:28:29 +0000 Received: by outflank-mailman (input) for mailman id 326787; Wed, 11 May 2022 12:28:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolS8-0006g2-IY; Wed, 11 May 2022 12:28:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolS8-0006H5-G6; Wed, 11 May 2022 12:28:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolS8-0000oL-3t; Wed, 11 May 2022 12:28:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nolS8-0001pz-3S; Wed, 11 May 2022 12:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8JbEUOG6/0Ojn3oRxVk+g/7pWJIXuLet9siyhtgdWF0=; b=jFKSSdvV4RxjjfoYy0hSyPvxc7 FsIjH1FLCMzdXmJci9giG/TsXOO8uMCUFkHUsLwp/Af004TpVFd6YHg8/7UhiovCAsvxr2t5tJ1xh /1i41/MjElIXEwVrg8djUKvI2tCvoe/j53u2aBVedj2CFg9HMjQtUWO7Qslk2UvzaJaE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170324: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 12:28:28 +0000 flight 170324 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170324/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 933 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 12:39:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:39:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326796.549430 (Exim 4.92) (envelope-from ) id 1nolcp-0008Cm-IY; Wed, 11 May 2022 12:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326796.549430; Wed, 11 May 2022 12:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolcp-0008Cf-Fx; Wed, 11 May 2022 12:39:31 +0000 Received: by outflank-mailman (input) for mailman id 326796; Wed, 11 May 2022 12:39:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolco-0008CZ-DD for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:39:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolcn-0006St-Sw; Wed, 11 May 2022 12:39:29 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nolcn-0002qz-Mx; Wed, 11 May 2022 12:39:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JowkZp54Hzn/o1MfZbiUjePUk6ZiqdW+7E8xfPqKjNE=; b=YRsVWxVibiXVwdUhAxR+Ko+dFG Mypzp4lTPQY7RX2y1IN48GzWnsjBVphpkbE6nsyatsZPUP+hJDwOElrAMj06xjECO15aR5VqjVjqz bNrtypNI9bCT0gNR2EJjL1gM5yM8Z1OUsI0RN7ZKgnXGDYijfvId+9cs/DV9DldSXLaM=; Message-ID: Date: Wed, 11 May 2022 13:39:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap To: George Dunlap Cc: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Jan Beulich , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> From: Julien Grall In-Reply-To: <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi George, On 11/05/2022 13:11, George Dunlap wrote: >>> Google told me __force is used in linux kernel to suppress warning in sparse, >>> https://stackoverflow.com/questions/53120610/what-does-the-attribute-force-do >>> Is sparse also used in xen? >> >> I am not aware of any use of Sparse in Xen, but it would technically be possible. >> >> However, my point here is more that this change seems to be unrelated to what the patch is meant to do (i.e. switching to byteswap). So if it is unnecessary, then it should be dropped from this patch. > > I think making people pull little changes like this out into separate patches is asking too much. It’s a lot of extra effort on the part of the submitter for basically no value. We commonly do little clean-ups like this in patches, and just require a comment at the bottom, like this: I suggested to drop from the patch because I don't think we should remove the __force. In fact, I have contemplated a few times in the past to use sparse in Xen. Sorry I should have been clearer. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 12:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326804.549440 (Exim 4.92) (envelope-from ) id 1nolv3-0002Dl-7v; Wed, 11 May 2022 12:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326804.549440; Wed, 11 May 2022 12:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv3-0002De-59; Wed, 11 May 2022 12:58:21 +0000 Received: by outflank-mailman (input) for mailman id 326804; Wed, 11 May 2022 12:58:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv0-0002DF-Ak for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:58:19 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05e66253-d12a-11ec-a406-831a346695d4; Wed, 11 May 2022 14:58:16 +0200 (CEST) Received: from [2001:4bb8:184:7881:740a:25f7:2c13:ef7a] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nolut-006reA-JL; Wed, 11 May 2022 12:58:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05e66253-d12a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=VBAca1xXxndzNfh1X1k86JeV9qFeb8QaWGR+x5euRpI=; b=VBMFfZIBGc4yLHRm2Wa5peBxYo L7lkpBKL9qmRp7GdsRzDbo2hOxkLdrUFWSDWJAWKxk7QsvkAo2WDU1HButK/AFoRRG2iI+xRaqzne eJpGCLr8lqE1G4UklNZu5W5Via4KqfQygzftAqjThgZhRiLJT9nOUNEt91aPkno5EGtYNQKITCBm9 0qhtN7kBThU6Wf12wDMqazMp94VKvBm1Bh2nyagV+tLVCyBBcz19ufT9rcxQ1nGaInv4lWj1hvQ9c ORWQ8Tf+T/53asn71Frgu3Zufwh+iDGXlg9wwgJIvAusQNxKo6BMaE2N49S38haolif8C8QpTZGf3 yN2fiQ/g==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: [PATCH 1/3] swiotlb: don't panic when the swiotlb buffer can't be allocated Date: Wed, 11 May 2022 14:58:03 +0200 Message-Id: <20220511125805.1377025-2-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220511125805.1377025-1-hch@lst.de> References: <20220511125805.1377025-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html For historical reasons the switlb code paniced when the metadata could not be allocated, but just printed a warning when the actual main swiotlb buffer could not be allocated. Restore this somewhat unexpected behavior as changing it caused a boot failure on the Microchip RISC-V PolarFire SoC Icicle kit. Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") Reported-by: Conor Dooley Signed-off-by: Christoph Hellwig Tested-by: Conor Dooley --- kernel/dma/swiotlb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index e2ef0864eb1e5..3e992a308c8a1 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -254,8 +254,10 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, tlb = memblock_alloc(bytes, PAGE_SIZE); else tlb = memblock_alloc_low(bytes, PAGE_SIZE); - if (!tlb) - panic("%s: failed to allocate tlb structure\n", __func__); + if (!tlb) { + pr_warn("%s: failed to allocate tlb structure\n", __func__); + return; + } if (remap && remap(tlb, nslabs) < 0) { memblock_free(tlb, PAGE_ALIGN(bytes)); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed May 11 12:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326806.549462 (Exim 4.92) (envelope-from ) id 1nolv4-0002il-Qn; Wed, 11 May 2022 12:58:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326806.549462; Wed, 11 May 2022 12:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv4-0002ia-NZ; Wed, 11 May 2022 12:58:22 +0000 Received: by outflank-mailman (input) for mailman id 326806; Wed, 11 May 2022 12:58:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv3-0002DF-E7 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:58:21 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 083730a7-d12a-11ec-a406-831a346695d4; Wed, 11 May 2022 14:58:20 +0200 (CEST) Received: from [2001:4bb8:184:7881:740a:25f7:2c13:ef7a] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1noluy-006red-V1; Wed, 11 May 2022 12:58:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 083730a7-d12a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=toUCmk68b0VIqulfilEOK3I3y91LJ0y0OH/f7d0EES0=; b=GGIU1i8lkayqDGAplfrTSrhaor BLksm6LWRMLoDZZbshdWfl1zTZJw7+5EApQCx/OIN5M0EU1RtOm2OP3lgcCxN0zEnNoGvF+GODe3G ofQic3DC0LKOfP7Fkx2AeGIxyEVZb/kbjHRCDleY4wfI1k9Lp2EjpIw2epikU2kUn3o/FWk+ND78J W6sXXNB9s8fIRSBTPGBi4SnVmC8afXImzQtCfps0xo0YrB6WG5ivAudedbhd+z0axlhNGkH7zCTqI iY5Bf3S8J4EU/B25UhLHUqveOZLR1f11oopGMGBSmVNXdElnUxTs231jO3i0K+ajnFFfdiXi2/Hf5 siB5FhhA==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: [PATCH 3/3] swiotlb: use the right nslabs-derived sizes in swiotlb_init_late Date: Wed, 11 May 2022 14:58:05 +0200 Message-Id: <20220511125805.1377025-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220511125805.1377025-1-hch@lst.de> References: <20220511125805.1377025-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html nslabs can shrink when allocations or the remap don't succeed, so make sure to use it for all sizing. For that remove the bytes value that can get stale and replace it with local calculations and a boolean to indicate if the originally requested size could not be allocated. Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") Signed-off-by: Christoph Hellwig --- kernel/dma/swiotlb.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 113e1e8aaca37..d6e62a6a42ceb 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -297,9 +297,9 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, { struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); - unsigned long bytes; unsigned char *vstart = NULL; unsigned int order; + bool retried = false; int rc = 0; if (swiotlb_force_disable) @@ -308,7 +308,6 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, retry: order = get_order(nslabs << IO_TLB_SHIFT); nslabs = SLABS_PER_PAGE << order; - bytes = nslabs << IO_TLB_SHIFT; while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN, @@ -316,16 +315,13 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, if (vstart) break; order--; + nslabs = SLABS_PER_PAGE << order; + retried = true; } if (!vstart) return -ENOMEM; - if (order != get_order(bytes)) { - pr_warn("only able to allocate %ld MB\n", - (PAGE_SIZE << order) >> 20); - nslabs = SLABS_PER_PAGE << order; - } if (remap) rc = remap(vstart, nslabs); if (rc) { @@ -334,9 +330,15 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE); if (nslabs < IO_TLB_MIN_SLABS) return rc; + retried = true; goto retry; } + if (retried) { + pr_warn("only able to allocate %ld MB\n", + (PAGE_SIZE << order) >> 20); + } + mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, get_order(array_size(sizeof(*mem->slots), nslabs))); if (!mem->slots) { @@ -344,7 +346,8 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, return -ENOMEM; } - set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT); + set_memory_decrypted((unsigned long)vstart, + (nslabs << IO_TLB_SHIFT) >> PAGE_SHIFT); swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true); swiotlb_print_info(); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed May 11 12:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326805.549446 (Exim 4.92) (envelope-from ) id 1nolv3-0002HJ-JK; Wed, 11 May 2022 12:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326805.549446; Wed, 11 May 2022 12:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv3-0002GE-D7; Wed, 11 May 2022 12:58:21 +0000 Received: by outflank-mailman (input) for mailman id 326805; Wed, 11 May 2022 12:58:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv2-0002DF-1l for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:58:20 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0500bddb-d12a-11ec-a406-831a346695d4; Wed, 11 May 2022 14:58:16 +0200 (CEST) Received: from [2001:4bb8:184:7881:740a:25f7:2c13:ef7a] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1noluq-006rdz-Tk; Wed, 11 May 2022 12:58:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0500bddb-d12a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=lWal7xDNVRaQCdbknsdqk06u/bYAytOsWgd5tBb7T1Y=; b=LNjy6lTfBvzizjreZ/Kd38DWgl YtjrtV+/YFkDGXytY2CU/6HhE7eVkT/0LxMdOr5b1rcvgIYatUNxkRyJxMcR45+ZjYkQpr7UK93Ep ETfHeve5kT2fyfK78yWgEDPsh9//+hgoc0r3CiGQyiEl8OcIKQ98epke5lKoCTDJH/6NqDsX77v6Y lk4dgtnmVGV5j7ujW0bXzgQ5TpA+97iJ0JAllS9c0+ubGjCpKtpJcTHXFaVbleq2tNqJudA7mcVHB aKWfBgVn9QnLnBzEO7KPWhoBKa0WoPhE36qrSfXTImqsXATVqX33lIzdY/cdvc9f6kYxAoy04OwOR lMsTAFQA==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: swiotlb regression fixe Date: Wed, 11 May 2022 14:58:02 +0200 Message-Id: <20220511125805.1377025-1-hch@lst.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Hi all, attached are a bunch of fixes for regressions in the recent swiotlb refactoring. The first one was reported by Conor, and the other two are things I found by code inspections while trying to fix what he reported. From xen-devel-bounces@lists.xenproject.org Wed May 11 12:58:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 12:58:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326807.549474 (Exim 4.92) (envelope-from ) id 1nolv6-0002ym-31; Wed, 11 May 2022 12:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326807.549474; Wed, 11 May 2022 12:58:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv5-0002yf-VW; Wed, 11 May 2022 12:58:23 +0000 Received: by outflank-mailman (input) for mailman id 326807; Wed, 11 May 2022 12:58:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolv4-0002cJ-PT for xen-devel@lists.xenproject.org; Wed, 11 May 2022 12:58:22 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06e89449-d12a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 14:58:20 +0200 (CEST) Received: from [2001:4bb8:184:7881:740a:25f7:2c13:ef7a] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1noluw-006reJ-8R; Wed, 11 May 2022 12:58:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06e89449-d12a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=PuV44d9nkyau+qsF4HjXIzIFX/Iz+fNa7YzgjXIuJ3M=; b=KQeqn6zw5+tBwQhIwYbD033l7U Bmwb6MGWYXuK/LkzlngzGC5Qubu/BMK8ESaRHloaJRhzEWk2cFZ1/V/l4O8B2vq2MzumWvrZwnZyr 43YpFbXIsyoZJQy96aaO4hEVBhMn/WC+lJu9Jachezx9QLwtVxUwduoKFfDF9UeSfgMQ0fx1hRZPt 0LdWe9KjdTrTGyLfYx27s5kfHuPEf7J0GvFg765OJZ9W+F+cSaDYoHAsubZYbwp7D1ACiauoX1v40 kA0XO3cMZuMkKnKm1x7RM+oVv6dCiF4gS3wqNXal5uhZKXl0X7LATlX/cCqQQx1QPxg0OGZS0cmVF GL+aA81w==; From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: [PATCH 2/3] swiotlb: use the right nslabs value in swiotlb_init_remap Date: Wed, 11 May 2022 14:58:04 +0200 Message-Id: <20220511125805.1377025-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220511125805.1377025-1-hch@lst.de> References: <20220511125805.1377025-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html default_nslabs should only be used to initialize nslabs, after that we need to use the local variable that can shrink when allocations or the remap don't succeed. Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") Signed-off-by: Christoph Hellwig --- kernel/dma/swiotlb.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 3e992a308c8a1..113e1e8aaca37 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -234,7 +234,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, { struct io_tlb_mem *mem = &io_tlb_default_mem; unsigned long nslabs = default_nslabs; - size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); + size_t alloc_size; size_t bytes; void *tlb; @@ -249,7 +249,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, * memory encryption. */ retry: - bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); + bytes = PAGE_ALIGN(nslabs << IO_TLB_SHIFT); if (flags & SWIOTLB_ANY) tlb = memblock_alloc(bytes, PAGE_SIZE); else @@ -269,12 +269,13 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, goto retry; } + alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); if (!mem->slots) panic("%s: Failed to allocate %zu bytes align=0x%lx\n", __func__, alloc_size, PAGE_SIZE); - swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false); + swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false); mem->force_bounce = flags & SWIOTLB_FORCE; if (flags & SWIOTLB_VERBOSE) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed May 11 13:01:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:01:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326825.549484 (Exim 4.92) (envelope-from ) id 1nolxf-0005I1-IF; Wed, 11 May 2022 13:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326825.549484; Wed, 11 May 2022 13:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolxf-0005Hu-F0; Wed, 11 May 2022 13:01:03 +0000 Received: by outflank-mailman (input) for mailman id 326825; Wed, 11 May 2022 13:01:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolxd-0005Ha-No; Wed, 11 May 2022 13:01:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolxd-0006tJ-GN; Wed, 11 May 2022 13:01:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nolxd-0001Uy-2y; Wed, 11 May 2022 13:01:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nolxd-0000un-2U; Wed, 11 May 2022 13:01:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=77kCBk7imJhkJvYvLLFS9KQQEH+0SfNdH8OE6/9JPQ4=; b=AFf8WHlvj3IgbaMG4svTgdSR85 xDI5bPGeXNArKVKxsqHYNc0oMHX6UqPppNatDcyuWCC2pvQRO+ReerBTkGIcokjk9877ITpXwwbMb ZSGnWsJf/WBlo/AEe8l+EejfsLmZayVQ6buxI5M0r2HXlDN+PHTi7azZgWU7saucjY/g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170325: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 13:01:01 +0000 flight 170325 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170325/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 934 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 13:12:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:12:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326854.549496 (Exim 4.92) (envelope-from ) id 1nom88-0006xq-Js; Wed, 11 May 2022 13:11:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326854.549496; Wed, 11 May 2022 13:11:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nom88-0006xj-Gt; Wed, 11 May 2022 13:11:52 +0000 Received: by outflank-mailman (input) for mailman id 326854; Wed, 11 May 2022 13:11:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nom87-0006xd-9c for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:11:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nom85-00073B-As; Wed, 11 May 2022 13:11:49 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nom85-0005AN-3W; Wed, 11 May 2022 13:11:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6LJxQpv+6Ai1F95mbhnxAR79VlXpP1nEcK0rK4efYAM=; b=xR+ca6Q4A2ZfeR9tomz2l5SypC +qxrcez3w9lJ6e61iQavSbCPncZ0iD0gfDAOaC7iJJX8Avp+LXymBq96EWBSoSWhMwAzRqUdNRC5z qL62Et9SH0UTihYmGYyX/sgy2lEosM5T9WVQrdp64wwgxWIYjS6QELrHgEQNyvSFFmZU=; Message-ID: <573e94c4-7de0-e442-c9d8-559b55ae3144@xen.org> Date: Wed, 11 May 2022 14:11:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Rahul Singh , Bertrand Marquis Cc: Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> From: Julien Grall In-Reply-To: <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Rahul, On 11/05/2022 11:53, Rahul Singh wrote: >> On 11 May 2022, at 10:18 am, Bertrand Marquis wrote: >> >> Hi Julien, >> >>> On 11 May 2022, at 10:10, Julien Grall wrote: >>> >>> Hi Bertrand, >>> >>> On 11/05/2022 09:46, Bertrand Marquis wrote: >>>>> On 11 May 2022, at 09:38, Julien Grall wrote: >>>>> >>>>> Hi Bertrand, >>>>> >>>>> On 11/05/2022 08:46, Bertrand Marquis wrote: >>>>>>> On 10 May 2022, at 17:35, Julien Grall wrote: >>>>>>> >>>>>>> Hi Rahul, >>>>>>> >>>>>>> On 10/05/2022 17:30, Rahul Singh wrote: >>>>>>>>> + rc = evtchn_alloc_unbound(&alloc); >>>>>>>>> + if ( rc ) >>>>>>>>> + { >>>>>>>>> + printk("Failed allocating event channel for domain\n"); >>>>>>>>> + return rc; >>>>>>>>> + } >>>>>>>>> + >>>>>>>>> + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; >>>>>>>>> + >>>>>>>>> + return 0; >>>>>>>>> +} >>>>>>>>> + >>>>>>>>> static int __init construct_domU(struct domain *d, >>>>>>>>> const struct dt_device_node *node) >>>>>>>>> { >>>>>>>>> @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, >>>>>>>>> if ( rc < 0 ) >>>>>>>>> return rc; >>>>>>>>> >>>>>>>>> + if ( kinfo.dom0less_enhanced ) >>>>>>>> I think we need to do something like this to fix the error. >>>>>>>> if ( hardware_domain && kinfo.dom0less_enhanced ) >>>>>>>> { >>>>>>>> } >>>>>>> >>>>>>> Is there any use case to use "dom0less_enhanced" without dom0 (or a domain servicing Xenstored)? >>>>>>> >>>>>> Just being curious here but would it even be possible to have non dom0 domain servicing xenstored ? >>>>> >>>>> You can build Xenstored against mini-os and configure the init script to launch xenstored as a domain. >>>> So dom0 is not mandatory or should mini-os be started as Dom0 for this to work ? >>> >>> In order to allocate the event channel, you need to know the ID of the domain where Xenstored will run. Stefano's patch is relying on Xenstored to be run in Domain 0. >>> >>> This would need to be updated if we want to run it in a separate domain. >> >> Ok then Dom0 is mandatory at the moment, I am ok with that. >> >>> >>>>> >>>>>>> If not, then I would consider to forbid this case and return an error. >>>>>> One way or an other we need to solve the crash but if it is forbidden we must prevent coming to this step earlier as it means the configuration is wrong. >>>>> >>>>> I think this should be checked when parsing the configuration. >>>> If dom0 is mandatory yes, we should still make sure that this code cannot be reached so an ASSERT would be nice here at least in case someone tries to activate this code without dom0 (which might happen when we will push the serie for static event channels). >>> >>> I am fine with an ASSERT(). >>> >>> Are you saying that dom0less_enhanced will be set to true for the static event channel series? >>> >>> If yes, then I think dom0less_enhanced will need to be an enum so we know what part of Xen is exposed. >> >> No it won’t, we just need some of the changes done but without setting dom0less_enhanced. >> @Rahul: can you confirm. >> > > We need to set the "xen,enhanced” enabled for dom0less domU to enable > the event-channel interface in dom0less guest. If we did not set this property we can’t > use the event-channel interface in dom0less domUs guests. Is this because the domU will not know which PPI will be used for notification? The property "xen,enhanced" with an empty string (or with the value "enabled") is meant to indicate that PV drivers will be usable in the domain. AFAIU, you are suggesting to change the meaning based on dom0 whether has been created. I don't particularly like that because a user may spent a while to understand why Xenstored doesn't work. The current proposal for xen,enhanced allows us to define new values if we wanted to only enabled selected interfaces. AFAIU, in your case, you only want to expose the event channel interface, so I would create a new value to indicate that the event channel interface is exposed. Xen would then create only the part for the event channel (i.e. no extended regions, grant tables...). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 13:31:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326862.549506 (Exim 4.92) (envelope-from ) id 1nomQY-0000xk-A9; Wed, 11 May 2022 13:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326862.549506; Wed, 11 May 2022 13:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomQY-0000xd-7I; Wed, 11 May 2022 13:30:54 +0000 Received: by outflank-mailman (input) for mailman id 326862; Wed, 11 May 2022 13:30:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomQW-0000xT-LY; Wed, 11 May 2022 13:30:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomQW-0007Nz-IZ; Wed, 11 May 2022 13:30:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomQW-000293-6h; Wed, 11 May 2022 13:30:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nomQW-0008Cw-6J; Wed, 11 May 2022 13:30:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eASlWPFqgJbbJ1ZY0gEK3cjHy6nsTc6wlUQ/1ZL4eIk=; b=YOmHUKHZf0v1E+2piyi8VVn5YU Yao4X0COyK5poanDW/09muYx9OIV8oNoCNdwDbfrfGb6ac1Jp/VS6bWOPnC801100DHAX7Fpgs0K6 fN7sISgH8DtAeKkYwlx9wQEa4wxv/WOHV517iWToTgMVfgBkS/763rFxSQTBCeclJxZM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170326: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 13:30:52 +0000 flight 170326 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170326/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 935 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 13:32:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:32:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326870.549517 (Exim 4.92) (envelope-from ) id 1nomSQ-0001Zl-NZ; Wed, 11 May 2022 13:32:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326870.549517; Wed, 11 May 2022 13:32:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomSQ-0001Ze-KJ; Wed, 11 May 2022 13:32:50 +0000 Received: by outflank-mailman (input) for mailman id 326870; Wed, 11 May 2022 13:32:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomSQ-0001ZY-0l for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:32:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9748139-d12e-11ec-a406-831a346695d4; Wed, 11 May 2022 15:32:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A2B6F21C93; Wed, 11 May 2022 13:32:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 67BCD139F9; Wed, 11 May 2022 13:32:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cKjWFwC7e2KaBwAAMHmgww (envelope-from ); Wed, 11 May 2022 13:32:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9748139-d12e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652275968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jwd63v7lM58rzCcC/SeHOGCmmqEIrOQ6hior6FOrAsw=; b=RkkG4PsfRkKOQo0aSx0z20CSNuaT2/RKL2+NLM/u3xK9ZSnJS4cDwl1uZNr40hPbQHKfrU x3fQtf9Fufmb0lvMZCdfsIqn1LTqGX+LgUAv9nD4DmL8IfEVM46x4ZvGWbBxSGYwj2ufq/ a4Vd0ymq8LSv/32Nv/O6HflkJlh9Em8= Message-ID: <23237c6d-4ec7-fd13-e2bd-4ce4c071ec6b@suse.com> Date: Wed, 11 May 2022 15:32:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US From: Juergen Gross To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------AavKBMlBKEa0ldRixEb4hmW0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------AavKBMlBKEa0ldRixEb4hmW0 Content-Type: multipart/mixed; boundary="------------MPly0KBQY1Zw5ebu8eRMgFFB"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" Message-ID: <23237c6d-4ec7-fd13-e2bd-4ce4c071ec6b@suse.com> Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> In-Reply-To: --------------MPly0KBQY1Zw5ebu8eRMgFFB Content-Type: multipart/mixed; boundary="------------Ips0c0oo1GWoitmVNUvRPLrM" --------------Ips0c0oo1GWoitmVNUvRPLrM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDUuMjIgMTQ6NTQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI4LjA0LjIy IDE2OjUwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IFRoZSBsYXRlc3Qgd2l0aCBjb21taXQg YmRkOGI2Yzk4MjM5ICgiZHJtL2k5MTU6IHJlcGxhY2UgWDg2X0ZFQVRVUkVfUEFUDQo+PiB3 aXRoIHBhdF9lbmFibGVkKCkiKSBwYXRfZW5hYmxlZCgpIHJldHVybmluZyBmYWxzZSAoYmVj YXVzZSBvZiBQQVQNCj4+IGluaXRpYWxpemF0aW9uIGJlaW5nIHN1cHByZXNzZWQgaW4gdGhl IGFic2VuY2Ugb2YgTVRSUnMgYmVpbmcgYW5ub3VuY2VkDQo+PiB0byBiZSBhdmFpbGFibGUp IGhhcyBiZWNvbWUgYSBwcm9ibGVtOiBUaGUgaTkxNSBkcml2ZXIgbm93IGZhaWxzIHRvDQo+ PiBpbml0aWFsaXplIHdoZW4gcnVubmluZyBQViBvbiBYZW4gKGk5MTVfZ2VtX29iamVjdF9w aW5fbWFwKCkgaXMgd2hlcmUgSQ0KPj4gbG9jYXRlZCB0aGUgaW5kdWNlZCBmYWlsdXJlKSwg YW5kIGl0cyBlcnJvciBoYW5kbGluZyBpcyBmbGFreSBlbm91Z2ggdG8NCj4+IChhdCBsZWFz dCBzb21ldGltZXMpIHJlc3VsdCBpbiBhIGh1bmcgc3lzdGVtLg0KPj4NCj4+IFlldCBldmVu IGJleW9uZCB0aGF0IHByb2JsZW0gdGhlIGtleWluZyBvZiB0aGUgdXNlIG9mIFdDIG1hcHBp bmdzIHRvDQo+PiBwYXRfZW5hYmxlZCgpIChzZWUgYXJjaF9jYW5fcGNpX21tYXBfd2MoKSkg bWVhbnMgdGhhdCBpbiBwYXJ0aWN1bGFyDQo+PiBncmFwaGljcyBmcmFtZSBidWZmZXIgYWNj ZXNzZXMgd291bGQgaGF2ZSBiZWVuIHF1aXRlIGEgYml0IGxlc3MNCj4+IHBlcmZvcm1hbnQg dGhhbiBwb3NzaWJsZS4NCj4+DQo+PiBBcnJhbmdlIGZvciB0aGUgZnVuY3Rpb24gdG8gcmV0 dXJuIHRydWUgaW4gc3VjaCBlbnZpcm9ubWVudHMsIHdpdGhvdXQNCj4+IHVuZGVybWluaW5n IHRoZSByZXN0IG9mIFBBVCBNU1IgbWFuYWdlbWVudCBsb2dpYyBjb25zaWRlcmluZyBQQVQg dG8gYmUNCj4+IGRpc2FibGVkOiBTcGVjaWZpY2FsbHksIG5vIHdyaXRlcyB0byB0aGUgUEFU IE1TUiBzaG91bGQgb2NjdXIuDQo+Pg0KPj4gRm9yIHRoZSBuZXcgYm9vbGVhbiB0byBsaXZl IGluIC5pbml0LmRhdGEsIGluaXRfY2FjaGVfbW9kZXMoKSBhbHNvIG5lZWRzDQo+PiBtb3Zp bmcgdG8gLmluaXQudGV4dCAod2hlcmUgaXQgY291bGQvc2hvdWxkIGhhdmUgbGl2ZWQgYWxy ZWFkeSBiZWZvcmUpLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4NCj4gDQo+IEkgdGhpbmsgdGhpcyBhcHByb2FjaCBpc24ndCB0aGUg YmVzdCB3YXkgdG8gdGFja2xlIHRoZSBpc3N1ZS4NCj4gDQo+IEl0IGNhbiBiZSBzb2x2ZWQg cmF0aGVyIGVhc2lseSBieSBub3QgZGVyaXZpbmcgdGhlIHN1cHBvcnRlZCBjYWNoaW5nDQo+ IG1vZGVzIHZpYSBwYXRfZW5hYmxlZCgpLCBidXQgYnkgYWRkaW5nIHNwZWNpZmljIGZ1bmN0 aW9ucyB0byBxdWVyeQ0KPiB0aGUgbmVlZGVkIGNhY2hpbmcgbW9kZSBmcm9tIHRoZSBQQVQg dHJhbnNsYXRpb24gdGFibGVzLCBhbmQgdG8gdXNlDQo+IHRob3NlIGZ1bmN0aW9ucyBpbnN0 ZWFkIG9mIHBhdF9lbmFibGVkKCkuDQo+IA0KPiBJJ20gcHJlcGFyaW5nIGEgcGF0Y2ggZm9y IHRoYXQgcHVycG9zZS4NCg0KVGhhdCBhdHRlbXB0IHdhcyBub3QgYSBjb21wbGV0ZSBzdWNj ZXNzLg0KDQpFc3BlY2lhbGx5IHRoZXJlIGFyZSBpc3N1ZXMgd2l0aCBteSBhcHByb2FjaCB3 aGVuICJub3BhdCIgaGFzIGJlZW4NCnNwZWNpZmllZCBhcyBib290IHBhcmFtZXRlciwgYXMg dGhhdCB3b3VsZCBiZSBqdXN0IGlnbm9yZWQuDQoNClNvIHJpZ2h0IG5vdyBJIGNhbid0IHRo aW5rIG9mIGEgYmV0dGVyIGFwcHJvYWNoIHRoYW4gdGhlIG9uZSBvZiBKYW4ncw0KcGF0Y2gu DQoNCg0KSnVlcmdlbg0K --------------Ips0c0oo1GWoitmVNUvRPLrM Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Ips0c0oo1GWoitmVNUvRPLrM-- --------------MPly0KBQY1Zw5ebu8eRMgFFB-- --------------AavKBMlBKEa0ldRixEb4hmW0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ7uwAFAwAAAAAACgkQsN6d1ii/Ey8i FwgAgUuBfM4xSByIe0K7S4WShhmmmxfycYBb+tJq2OLkFHtV8mWauqEjvmW/DclycEYdoTW/3KeG Jio7fSP+bxH81f81j0/QV5F0Tv7IIumdzasXKj9H29lrwK/4Gbcbz/1gwQ8wOBackhqWHdJOXzs+ EEDDkHL9H2iOrRZgspdeJhXQ5rcj0Nxf6P5pWfEYRA2dcNTWYpZJxzuwYDm6MYyK4mFFrfbgyqBX aOjEWBbomjbSZhUDa4wfcj5fV27V7JbC39NvrWf3LF/Qhtwy1m6m6RvmMlvadIY/tPvtA7zTHS5S uKxom25fc5r+cn6lY2IBbx7crIfcIytjkK17Vl4ZCg== =NVep -----END PGP SIGNATURE----- --------------AavKBMlBKEa0ldRixEb4hmW0-- From xen-devel-bounces@lists.xenproject.org Wed May 11 13:48:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:48:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326878.549529 (Exim 4.92) (envelope-from ) id 1nomhi-0003AM-0c; Wed, 11 May 2022 13:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326878.549529; Wed, 11 May 2022 13:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomhh-0003AF-TY; Wed, 11 May 2022 13:48:37 +0000 Received: by outflank-mailman (input) for mailman id 326878; Wed, 11 May 2022 13:48:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomhg-0003A7-Tp for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:48:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b548a57-d131-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 15:48:33 +0200 (CEST) Received: from mail-bn8nam08lp2045.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 09:48:30 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4132.namprd03.prod.outlook.com (2603:10b6:208:6b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 13:48:28 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 13:48:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b548a57-d131-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652276913; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=O61RDtKo9U+/apCedeLTDR0L62zoXpuTd24VXFZsanw=; b=W2PEBSdoNqiarpe6K2ODmoLTkiSKognDBvq7jvJbXPYV/oHGE2CXnOsS SiQtOtjE37nLLpH9Xd+Ol8nI+K2DV4RZeV9cICPBaYHJHF0t4agwSFByu zgbeRsRVRP1irLwhiL0chC9uI2VU1W2RZLD/lFg7E8D6TvifBUUhAPvnD k=; X-IronPort-RemoteIP: 104.47.74.45 X-IronPort-MID: 71064079 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:em8xF6viiD1tY9flqPRh7jWiuOfnVC1fMUV32f8akzHdYApBsoF/q tZmKWzQM6qCMWf9fowkYITgo0oHuJTdyYRjHFc/pCA8QnsU+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi87EvzvwflNTiNdTR8uFohd5rrmBHew5Jn7I03uKxMAwt1IJWRuYcgy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AEmmtt7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvN+/ZvvDm7IApZiuDSb9XKYIawQJ8EgXaxq n36vEfFO0RPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNzWgqWOAlg4RXZxXCeJSwB6J4rrZ5UCeHGdsc9JaQNkvtctzTzp60 FaMx4PtHWY37ODTTm+B/LCJqz/0ITISMWIJeS4DS00C/sXnp4YwyBnIS76PDZKIszE8Ihmoq xjikcT0r+97YRIjv0ljwW36vg== IronPort-HdrOrdr: A9a23:Ft1WRKt8GzQZzMcSXgLZdhAa7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="71064079" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQadiPoFfsBUJbLZVy/Q4BjCauJApjBE4CUmIBZ+BI9z+F5CBK5UbQRVx/mJ2cC0V9bsiCjVaR38AII8dESDdDO0YICiND97xlW7MUEZfeNY+VLL8LgoY0AX+Sthx7Xpf+zJ+W59ZMxWnRICrHzQ7VFqLFkJu62BXKyCzujl6vhpGCaCqdCYKa3eeZ22v/+slIVm6tnxkU6U7oAihGiagsQEsph4xJS3zcD0vgAh8/kMDaoGYrUSPbYyyi+UMCZ4cEjD2cj7RDzFR1XxXsKpcdogrtdtsqhcxrtAWQoxdh6g6SMXoW4QXd19P6RfO+rzR+F74PWKGcCnt8xwMIf6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O61RDtKo9U+/apCedeLTDR0L62zoXpuTd24VXFZsanw=; b=LOIIYiTyqtFADC4rjHlV7+uoQaFMtrdGzxw05r064cqsIaXOFTa330Pa3ugh+HAX4lAj+foosS/PgIoS+ScCGCdm3WZle85jiYQLYTD3/syXfTeQJLWxIZH3O7f9+cTspDDxDzcrYdtYIqmx0zSQh/yuET/+9/y/68/Xy6C5nOnbqc9nUxKjo8U/r51piXeQ9xA+rfXwSIn9GT4v1gU7/z/TU2WaaM8SMs0LWTm+hmSrp/KYkmS23Ya2CnOwiKMqafDj2XM03d0Z5s7uMwOPs8WpJkOTq1fnFS4t72sithq68F7V58iJr6UCnyJCMZCkyhS88vqZJRKsaFQzWrr+Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O61RDtKo9U+/apCedeLTDR0L62zoXpuTd24VXFZsanw=; b=q/DPzPtdof5yOqaWfoL00IfIhY6o/Y8KTOVkOQZft1G4cUpzHUpTlWgJlClvtEjEUb2bcSGVK5v5aTBHseu8HnGyz7b5JdQSW45aPJHqWAk/RahYxYpEZMvm0El0qbL1KIaKOkxGmrutgLNnDX1h1DEvXFQ5VY0hjiwu1oSRZ9c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 15:48:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 19/21] IOMMU/x86: add perf counters for page table splitting / coalescing Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0136.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5eac677-d4a8-4534-32f8-08da3354ed4c X-MS-TrafficTypeDiagnostic: BL0PR03MB4132:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M+r/CbGuKveHLXJksANQRf0eBLH1hxogkoMX2Bxuk1lL2/7fzjP5yty9apHmPO19uzgrD2awvVYg1P52+IMGVeufcodasTuAox5OWDDlpLCjKxAq1CIFoXNlYsEMBsG61znx5LxdQCGNoEwja8P2K93cQ3FtvpMiXLkUm83sPqq3ovOnQeJ4JNVVX1u2TMBEVxzK9S1jNL4PMeqkTyvxUxVrUleKCSnX3k+Xh9tn+R/DVTqqZo3OiEyAxM64a5C8HtSjhCHxzxvwH1G62GS9abAa00mlkoOGD6JupQIa0ZBC/RIkRniWSyggfXP21L1b6VMkk8KcX31+G1SO+ul0gfUImAjIqqCp0V6qxTCEIYKHURxRo2NvJEj3lJX+oWu0qvTg2qYnAFUAq0je04J3BNdmeLOdSODWnOIOVNIMMnNmmeklIIYhU+DmTziPAh2PdlMqLAUzNh77jfCTKB5alteUJvEqu3TDJ95IVy2gaWfMC3ATUMo6NevmOZv2C8LuqD2fefkzFmpsrvGO6xvknFHWesjBY1iT+8vpHl3lCdHpu30DVNsKTt9dSD1Tb2PbNyux+7QMf+y/fBN2cKAfeoedmVwlvHugNMKxDW0Thxz81K82/uGQ6nL0IIdLDVoFMVIZYQU2sCPbSF+JevHPqkSo7lBxH9fM+iOqJpdHxKawmZHqTfU7OA9UpsLvPa2+1BaBQ2PMG1RePy/lXsbsNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(6666004)(2906002)(6512007)(558084003)(26005)(85182001)(33716001)(508600001)(82960400001)(5660300002)(8936002)(6486002)(86362001)(38100700002)(9686003)(66476007)(66556008)(6916009)(54906003)(66946007)(8676002)(4326008)(6506007)(316002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUxydUdGWTlWTEZsQmhneVdscVU4Z0paL3N6bHlKK3dPY1RGTDB1M2ZSdnRu?= =?utf-8?B?blBhTzhYTE1ManNMQ0ZZWk9xS2x2ZjI1NHgveFdLejFYb3BPdm4zMWFLaWVR?= =?utf-8?B?endnSzNOMkdwU05xYUxHMmJvRGE2T2VieVZYQjJEamRZMnFya2RWaVhtSjhy?= =?utf-8?B?WkM0OTJnSTVqK0FOYTB4SEhmZVNra3REVnFNMWtxSU1QcHNjaVM0K2hZbXdt?= =?utf-8?B?N1l2VGVBcHJBUjMyaVQ2MFg4UUFzeGNYSnRCVEFid1RJaVBISURHT1BhRUhx?= =?utf-8?B?SVYwbk83YmhPZnBsekprOWFrRE9XcTV6aG1RYm0zMWl3WVNxNUhPRjVUYngz?= =?utf-8?B?Q3NaVVhqSEdpcWM4Y2V2b2pWU0dkcGRHODJUQ3hVSmZBM01iWC9qaGRGa050?= =?utf-8?B?VFd0NTdib1hxN2w1eUUzMGFaSkxaekhySU1VbTAwanJIYjVDSFQ5VzREQjF6?= =?utf-8?B?NStFTE94MGMwMy9Ga21ZYy9DbitnTGJ4Ry9kLzlRRlBXZGpicERNeS94MHJZ?= =?utf-8?B?YnRGOHVhSVVJbFJxdEY5UTZ4RGl0YndaYStSREFJNjVSQ0dCdS9XZW9Id1Rj?= =?utf-8?B?NXE3SUZDTDJ6KzdJUWVrKzVxb2dZR2hPdm5UeXRTWWFtQ3ZDck5hdzNJWTlL?= =?utf-8?B?MWdnR0J6NTZpSjVkN2U1bzBxbFJjOTF0Rk8rNDBTK2sxSG0rSVdqV0Y1NGxT?= =?utf-8?B?UnE2clYzSmlreDlzam1ubnNxVzJFanNiWm5lMWhoV3l5TGRDU3QwVkJaUy9I?= =?utf-8?B?ZjR5dDNaS1U2bEQzbnJiajBXMHBBbm1GQkF3MERHcFNMNVZWckw3UXpSOC95?= =?utf-8?B?SDM0V3hWTW11NzFmbnVhYnJ2NE5TUERIY2EwcHdvSThnZFFQa2l0d3R2SGpr?= =?utf-8?B?dkNvRVdsTzNJMHp6M0ZrSklUb0Y2NUd6a3AxK0tPSE5kWFkzbEJZbU5JQ1RQ?= =?utf-8?B?UVpaL1JZam1kaFVKNURZRVZkYnltUlNENnFvcEljdW9VdmxwbTB1M05TL1Qv?= =?utf-8?B?bmtKY0RiNWpPMWlxN3pRNlZDSW5EVHIzTklYZjNGZnNHenZZcHV0Ty9OWk9n?= =?utf-8?B?bVg2K2xCM3hIQXZmUDM2N3FJZjFHQ2kzc2hNd0ZoZTU1ZE1LQjdsSEFMSTJF?= =?utf-8?B?RkEyMUVUUk9JRGY0SklBWFVhcDQrV0FpMFRIWFJ0S0F3SndOMkx6eDB2RmNv?= =?utf-8?B?S0hpRzEvSkE4bGlTQXQ2QVIwQmVzbGhueGJEQjBYWVpXL3hYamxxM1dhV0hE?= =?utf-8?B?UkF6L21mYkRrbVd6ZFYyM3lKaE1pejFqeUtBVFdpUlVlaS9FaEE2aVdIUWFj?= =?utf-8?B?aXQ2ZHpOQ2ZTSFpCbTN6dlNnREduem5HbkNKZ2poWEE4L0NJeithWXQxbjMy?= =?utf-8?B?dUY2ZXhLRXpTVitSb2xrQkw4L3B3SG1tRFNqSnFpSzJrdTkyTmpYSzRuN2pM?= =?utf-8?B?Yi9yZHVVb0F5TXdyTVhjOURhMU4zVUZaVjV0OGdNN0huOE9Gc05lYWd0am16?= =?utf-8?B?eEszZnliMWw3Z3ZFYk40V1FUVUFyOSt1ZFVIT3pEVXJwMmlzcVVCY0s3U0NR?= =?utf-8?B?SjdWZDFtaGlTUjdCTExLRkUrMCtyU29hZnFNN3R2Vkh0QkV0N09zeVd3KzJv?= =?utf-8?B?YkdRejJJTTRRb1BBdEpvUlpFbzRES01nYXBSdGYrNnVYTGgzdklieE5SZE9j?= =?utf-8?B?dU5QZXR4cis5Y0loV1ZZRjdEczYyN1lkL3AwVGhwb0VaNysyUlBoNEs1QzhT?= =?utf-8?B?Y1o0YWdoWmMxZnF4d3ZHNDVINTNicGgrOThTVGo5Y2xXVmZVYzhDYkhCSXJ6?= =?utf-8?B?ZUJFSWU0R1QreHdqU2o3YmhEYjNzMWN1U2lUcStBbUphM0d2YjZaU3JUWThs?= =?utf-8?B?UmJZYitTNC9NalA5c1FuZk50aWt1MHRKTXcranJTZkh4eWlkYXZySkpORHQ5?= =?utf-8?B?dHNoZE8vZHAwWkV6ZTJhTERQSzI4K1N1OHlDL1pCZFUvSjg4OGIydm01elhK?= =?utf-8?B?L1I3Qm12aGhEY3BGVlRVaDFmY2ZoQ215aFZYUGVWT1RHaDdNZzJBSWY5VG55?= =?utf-8?B?MUhIQmYxZnBjaExhMHZsaHRFWkxRN1lRS1p2UXY5dkhoeWdndXk0MXpPY2Na?= =?utf-8?B?ME5pUXFnV0VUc1hkOERGVWpQd3BHcFlPZmRaanI4b0hJemFVa3phYU9iVThL?= =?utf-8?B?dngvbXRFUzUvNkxRNjRlU28rcmtBTU9VaEdjZit0cG9aMUdFSzNFWEFTYUxp?= =?utf-8?B?MVgvN3lZb2I1ek1PcnNkemRRd2ppU2NXQ2Y5K0NxTFhqUU8xdzdKRzQrdnZF?= =?utf-8?B?Z2cwZnpYWUFxWEFhaEhYYXhIWnIza1gyV2F0M1pWUVppSTIyWStDL3FjbDkr?= =?utf-8?Q?ub7p6OmvHdabF7Fs=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5eac677-d4a8-4534-32f8-08da3354ed4c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 13:48:28.0634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XJqN16hLRY/99c3n1H2mM7/ig9Eu11X08vEM3zZImT+74DYEm0Y9Se6fX2IRco9O633TqBq5YBmv889RLuaHLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4132 On Mon, Apr 25, 2022 at 10:44:11AM +0200, Jan Beulich wrote: > Signed-off-by: Jan Beulich > Reviewed-by: Kevin tian Reviewed-by: Roger Pau Monné Would be helpful to also have those per-guest I think. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 13:50:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:50:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326885.549540 (Exim 4.92) (envelope-from ) id 1nomjY-0004Wt-Gv; Wed, 11 May 2022 13:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326885.549540; Wed, 11 May 2022 13:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomjY-0004Wm-Cl; Wed, 11 May 2022 13:50:32 +0000 Received: by outflank-mailman (input) for mailman id 326885; Wed, 11 May 2022 13:50:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomjW-0004Wg-Vn for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:50:30 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50c6dc71-d131-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 15:50:29 +0200 (CEST) Received: from mail-dm6nam08lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 09:50:26 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB5263.namprd03.prod.outlook.com (2603:10b6:208:1f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 13:50:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 13:50:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50c6dc71-d131-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652277029; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=sUHJTfbmi2qdpffDXNXVrXcdOZLEHvpax6szxKt+6Jc=; b=b3WzdN0ltulVRFa0GmsnJnS2ntSgLxOZGC+CmrkJh3B7g22obxaPaZSd 8VW1Q1N9PrF/xDzV+M6FSvLP7eOWHh++2ERLxl8wuXBerOuzOUqSSO9WV Jkw2kVgAyBJ+yYJeKHgNRqEVv9PDMvHqyU83ez43d3ohN98icjm6a3JC2 4=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 70942123 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gs1eK61fGb5s+cfbA/bD5d5wkn2cJEfYwER7XKvMYLTBsI5bpzYEm 2VJUW/QM6mNY2Lzc98kYYy39klQ68XSzNYwQVNopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx2IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1ip63qZAQ3YpHdt+NAXVoADwomfox/reqvzXiX6aR/zmXgWl60n7BCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfmRjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGuL2cB8gn9Sawfu0zjkBwhyZTWCfHtUPugS8N7mxmGq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0c9ldDew8rh2Mw6z84gCFC2xCRTlEAOHKr+czTD0uk 1OMwdXgAGQ/tKXPES7GsLCJsTm1JC4Za3cYYjMJRhcE5N+lp5wvihXITZBoF6vdYsDJJAwcC gui9EAW74j/R+ZRv0ln1TgrWw6Rm6U= IronPort-HdrOrdr: A9a23:Puhc56r9dK3mHAomQOlwL2MaV5uiL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCDwqhoPRPAh3Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX2y2oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iGnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegx2w 2LCNUtqFh0dL5mUUtMPpZ+fSKJMB28ffvtChPlHb21LtBPB5ryw6SHkokd1aWNRKEi6qcUtd DobG543FRCDn4GT/f+kaF2zg== X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70942123" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GM+/pCys97UrkwiXeOUlz5mZS40opGI3c8c00KKY80vCfbcokBv7zFV4YmO2L7jqFtNnPmxcf/mjCCxshdmBkQU5ycuSpF2nrxexDbH02HFYtWAu4cb8kr1uqUkzfiZ25tbE/Ex/9ZeFmIwIAkuGrJlU0fNJ91mz2aoLNR34gCtrEXDcdHHlXX8hqukUHV9Z6mgsqOIX9a6d+b3E92htxTkb0NJHHWNFy6RQ41alWlDMQqZtVgBxa/OT6W72THNBu1R75AhvUDtvem4or7wl3u/m6Aib/GdLUdcAEpkj8FbG0c6uvVeUaRTw8ie8P/LipRjGyoyqDwGTCw6kZh6cdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdJ4Yz6ryBPi6qOEetDDDksYNq+VQ8rhd0zvNvhefT8=; b=GHh1rKuOxpL1TfOTm/A81dXuG3GTfZWrwPZ1kbI36Z/RL/vssiSUf9u8lMti1fDf0W0otsPhP1YqCnwLLwaVCNdVd04fbiw0P0+xZ7Q/K+YvRAhIDQot08Mx+HudhubDTE7Bhs9a4+3FUmPZ1eVo9lfq6PsnRg2IBfLhyvv0Czpl4LsffIIOIERaYKX2oYSJxV89t55EtJhuehxaIiAFmpSpE3FQtFf0w8AhuvnlbZnWLdNwC4CxFoGaEHu6GPBcnIOu2hffDL8+alTST1aG8auCZzU/+OvoHjYc1JTrWCFd2NH+lpFql1pNSra7E7yRvzF2w6YurwMrdLQUlngpng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdJ4Yz6ryBPi6qOEetDDDksYNq+VQ8rhd0zvNvhefT8=; b=PsY/EhMfNyuRdoIYsLnMQgoCC61OLpz2ImhNGvnjepdJNMFLZvKq0zfJVjU3ME+MSlieDIs4UEtBhUwEK7CrpiGP3e5pY4a2ceXN4b5io0DoG/vd732At6XC+mPp/+RSlqRNHWmK1eAUrVNtoyQOE8AqqxMkjBeXMHi1h1yXAjg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 15:50:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 20/21] VT-d: fold iommu_flush_iotlb{,_pages}() Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0123.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::20) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74ad91fa-65af-4bc1-b269-08da335532ee X-MS-TrafficTypeDiagnostic: MN2PR03MB5263:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ly7q8Q1aRrOq3cZ/o0yuiFpF1EvTYK+CKG53H962qSg7yhDKC/bl5czNqdr5C+dxuaQ4tGH6RX6QtMn6ZtF53mgLWFnEJRYCXd3jJUn/La/hUiGn/bx6OnD+jMsMSYwSQJvUOWOzGvu5Thtyfe7IbuswNs6KFg0uPyuliDK11NCt7GjdzqNNi7jVBhm2GwM+MLENhtalXRgCpuCDH/SYeK44mhGxaSJfzD1IqBnsd/J6NRquneyfNXMA6a5ZoObh+NJVq6q8OKkz8iX7wQ0LwVvk34l9+oyz9Kz+EW/LRXKlQepAnkNYy90HY4kF0C2C2ixYhCgEtE1O4WGI/LjHnnrz5ioEhU66DzxWT1a6vwuLY9CAFhZ4OyHOel5n0HtBbR24m2W4BUFK35QrwNJJ99UQ+3DZm2Y3DGeUaZIPg6YrLBaDYZeJepn52KzAk0hJ2WXdneHPsOEurEO2nxNIL9XyExq8qZGPSK4AARpg0xW9yOWDZmnHQ3COVmDBS9/97yl3afLlGNIWdfWzzWsFk6FnvzVwuK9JdEPbGYn/Z6JJwyr4RVpmGK2pHMkeFvxw4R4o1L0GEJXES/kl9LswwcX+mBU2xzMQvnRZO64ROvSiME8e7K/ZYV3a9HLwc1bkv/i17GDbJfjvR7JSq+0jFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(33716001)(316002)(186003)(6666004)(85182001)(8676002)(508600001)(8936002)(9686003)(6512007)(6506007)(26005)(6486002)(4326008)(4744005)(5660300002)(6916009)(38100700002)(66556008)(66946007)(66476007)(82960400001)(86362001)(2906002)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yi85d2FWY3RGZXcwNUtOTjZsRmI2QVdmR1prNWc5ZFdpbFRBZ3kza01HSzky?= =?utf-8?B?RGVvRnBoclZUeDNaR3pqaVZRVi9CSEZzNkxKeituTlFHdXNQcjh0MVV3aHRR?= =?utf-8?B?STZnc0picE5GRUp0QThCeGNSeHg4SW1IOXdKdC9YakF6ODI0Qmo5TWJ3dVR3?= =?utf-8?B?Nm5YOG9xWHBQNldEUkZZUnR1cU53cEd5NzRnTzRsL3BhckZVcnZIRkd2TDJy?= =?utf-8?B?amdBd1VXQklwbzNyZjNubmU0TVB0RFdSVjBGRzRyMkhoSy9SOURVZEE3aWdQ?= =?utf-8?B?Y3ZhSll2ZVVoU29JNlBsbTlXL3EyNGJFVDdjdkltM1FqckVyV2FMbGFFTzcz?= =?utf-8?B?MCtqTE11TmZ5VlJ2YjdLaUFybVUxRTFaSTMvMCtiVUljZWs0aXlJYTIxZEVT?= =?utf-8?B?M0NrMzFQakNwV2NCRXhvSVBQeUk3bGN1KzA5ZzQ5ZUVQcTZORDllRU5FTFBu?= =?utf-8?B?SFgvQVpKMEZTQkxtcTk2UkNoSTVZT1NubXNMVmthQkRHRk82ak9XRk52M09s?= =?utf-8?B?aUJteEQ4STBUcTJZUmFYQ09ab3J4TWNlSTNpL1BMUzVHY2NTVHVPdnN6UGU4?= =?utf-8?B?dGR6L1BLWWFrYUhndkcvVmYzVUF5OCtzMGFBUHBVZW91WkxWcEpObzVoSkxs?= =?utf-8?B?SnpXcHdCNkN4clhNWmpTdnN3b0FjSmJFb3c1bURSM0dCN0dMdXNnTXBZR0FT?= =?utf-8?B?QktrRTVselJVeVJTZ0lpa3RBRUVRbnhpNjl1aC9uT293amVuRFFCcFE5M0Nu?= =?utf-8?B?aFZsc1B0MklOZTBZSkZSYVBrZXpmNXYzVzdXU0lCL1dSb2d3dy84ZG1lUjkz?= =?utf-8?B?OW5sTnJkWXhjSFJUek1MVWpuMWNrRUtnbk16RTV3NE5wcG1OMVJhOHJrSlJF?= =?utf-8?B?c1JpaS9MY3dwMm5pbUhLdEYwQTZLZnYzZWd2VkJLK1AyTHp0cHRBZm8zMGN3?= =?utf-8?B?SVNWa3RwSThCYVk3bndNWXV6VDVhN0JkNC94SHY3SXVzQ0N2Nmt2SEpXby9U?= =?utf-8?B?S3Z6L253cjl6SHVWMG95TElYMU5QYXlGa2RLdk9qSFd1SS9TcnpFa2ZRWWw3?= =?utf-8?B?Z29xR2hmdWpoSFRvenovTUsyNUZWVkV3bXh2RUQ4TytockNRNkpubmxlTG5q?= =?utf-8?B?SVJPelNpTWhwK2toY3UxSGpVd3pIZGZGN0FoU2VXRXRaeTBZQnVpdms1NVBq?= =?utf-8?B?UHZQQlJZMDlFTVIrNnZYQnFUM3lpY214OTkzSis0alQ1ZVR0bC9SQnUyYWVE?= =?utf-8?B?UHRYNWl5Ui9Bd3lMaHpsdnVRUjhVTCt1K0M4MkpzWjJwUHNoNDREUVJjVHk4?= =?utf-8?B?eGcxTm50cHNBbGpsVkdZOVB5dTRyYzRVY1Rzd2tub0QrRlk2a1JiRkJ2Y0pX?= =?utf-8?B?d2NDeUwzeERMVEo5aG8yeWZnRXczR2dUYUJxR0dvb2hWbHNwS2lBMmtiN3Aw?= =?utf-8?B?L2JjaG9Vbm1abHhQbGJNTFVNU2tsNVAzN0l5Q0EzN3ZodlN5azY3cFR2eFpY?= =?utf-8?B?Y3pwUmVUTlg4V3lBaEFRVzlNUnpRa0U4Znc4T3ZqVHdMRmVNV3VpeVFPTlhD?= =?utf-8?B?RG9iSzdYK0ZVd1RDeU53dWN1dmZ4dzVTNE9aL1RoQVd1QTdZbDNtV2N2bXdM?= =?utf-8?B?QUJFTUljM0NHcnFaNUdxVGJybmt5Ukd6S2dRem9FQTQ4b3VsRWNkVjRXMlc1?= =?utf-8?B?cTVLNUE3SXYyaG5zaHFQMDhXN2UvdXlFVFdMQ1hZNktvakx3Zml3WVpKSzBv?= =?utf-8?B?UksxTG80L1A5aHcveGdsUGRwRW5kTVR4Qnp5OStJRUVIMHNhYzZxbUdBUVBi?= =?utf-8?B?V0pRSkR1TlEzcGdEZmRIZjlrVlhtS1VMZWFNWjhQV20wa1VsZ2RyaVBNODNF?= =?utf-8?B?bi9sQ3RXMHgyUVB6dHJnVUJNeThOT2c5bjh1YUt1d0lvck1ndnpWNitDRXJa?= =?utf-8?B?K1FMRTNobXpQNlVDbTRlMGYya1MyeXdrRnBGUytxK2Y4bnkwS0RjMUUraitx?= =?utf-8?B?VXk2RWNQenNHUFFTZ2diUENzeXEwcmNNeXpoMCtxRmh6YU80L0VrZnVUTDM2?= =?utf-8?B?dkE1SE15S3orY2tOSjk0NlY5WjJKdTR1bW8raEIrbXhpUm5pc3RRZlFOT1pN?= =?utf-8?B?UFZIVGJocWxCVnhUZDV2L2dtMG5MMnhCYm94VnYxNWpQcy9rL2NPc1VvRWFX?= =?utf-8?B?dWFtZTh4K1lrSXdWR0xsY2hXVjczTFFrby9BRTJsSGh6U3BaQ2tud250dXQv?= =?utf-8?B?OFg3SHZpWTBGc1daOTh6N1JqcWgraEFkNUpXV29CN25oWUtvWVpINGMwUFJk?= =?utf-8?B?QXRlUkRpWkRGSVYxa3RwUHJRVTZoMXFtZnVMTk1ZVHk5UlVkZnV3ZVQxYVl3?= =?utf-8?Q?l0dLjCux2hLTTc4A=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74ad91fa-65af-4bc1-b269-08da335532ee X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 13:50:24.8117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wTUsN7GDTxzwnGyGA0TmuhQWFHNZwk7HwOq0dGXoSI/gdrmpXilAD+A3jLojOmBr2qJbRW0PK+voGZAGa4lxdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5263 On Mon, Apr 25, 2022 at 10:44:38AM +0200, Jan Beulich wrote: > With iommu_flush_iotlb_all() gone, iommu_flush_iotlb_pages() is merely a > wrapper around the not otherwise called iommu_flush_iotlb(). Fold both > functions. > > No functional change intended. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 13:57:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:57:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326893.549551 (Exim 4.92) (envelope-from ) id 1nomqX-0005GI-8b; Wed, 11 May 2022 13:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326893.549551; Wed, 11 May 2022 13:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomqX-0005GB-5I; Wed, 11 May 2022 13:57:45 +0000 Received: by outflank-mailman (input) for mailman id 326893; Wed, 11 May 2022 13:57:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomqV-0005G5-QD for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:57:43 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52d14dd4-d132-11ec-a406-831a346695d4; Wed, 11 May 2022 15:57:42 +0200 (CEST) Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 09:57:40 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB5277.namprd03.prod.outlook.com (2603:10b6:208:1e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 13:57:38 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 13:57:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52d14dd4-d132-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652277462; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=godTISsZJ8UQ5fdA+tpUXkqm6i0xsRLztdwsxNutTIA=; b=XQnNcKs/3kVtk0QWFY0s1lwfk3Rh5h2iTuNfld4xotZq1Tn5Q/ghBoqp 1vXiMClZprdfeohNyuJSv/wJ3fIyZ+g7UavIM58lvf8k21fPJAhkRgWnR eKtPHvzbVeseNzuNj9+osbeWElUW1QXJqY/3/LRIYMLt3w2dPggyn/lD7 E=; X-IronPort-RemoteIP: 104.47.55.101 X-IronPort-MID: 70942686 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KRjNt6Abolo5TRVW/yXiw5YqxClBgxIJ4kV8jS/XYbTApDMghjBTx zQXCG+AOf7YZjH3Kt5xO4W+8h9S65LWnd81QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng29Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhJ1 s1RksOvTD0mM53wivkXDRwHDhFhaPguFL/veRBTsOS15mifKz7J/K8rC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t7B8mbGs0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjw1yWlLW0GwL6TjawpzkHs5T1W6pPSG4rzIoKpGJ9EsVnN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1jYfVsRRFasm6QiL4qvS/wudQGMDS1Z8hMcOscY3QXkvy QWPltawXTh36uTNEDSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa38716bnC43TEYj7vg+R IronPort-HdrOrdr: A9a23:eLuUgatPHKN6LZMSuqCxxb5X7skC3oMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H4BEDyewKlyXcV2/hbAV7MZniChILFFu9fBM7Zslvd8k7Fh6RgPM VbAsxD4bTLZDAX4voSojPIdOrIq+PmzEncv5a9854bd3AIV0gP1WZEIzfeNnczaBhNBJI/Gp bZzNFAvSCcdXMeadn+LmUZXsDYzue72K7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFqQrk/a+u2svLhSM0llWjoai+quGRiuerN/b8yfT97Q+cyDpAUb4RGoFqegpF5d1Hpmxa1O Uk6C1QRfibo0mhA12dkF/I1w780DAo8RbZuCSlaD3Y0IHErXsBerZ8rJMcfR3D50U6utZglK pNwmKCrpJSSQjNhSLn+rHzJmdXf2eP0A4feNQo/gtiuEolGc9shJ1a+FkQHIYLHSr85oxiGO 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib1+7a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e zLPqlhibkLRM4LaqB2AvsHXKKMeyXwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou W1bLqZjx9BR6vDM7zx4HQQyGGzfIyUZ0Wd9uhOo55kp7b7WL3ndSWeVVFGqbrSn8ki X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70942686" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j+HL2+/nFVDqV+O+zBOGkCZCtlmQ5tQ4ufuGq/vPpSjpPycW0X6dfO7UnRC8prFkFV+NzCkgpwTNSNkdwhZBgs1fAPFvMISXnrKwOynpVc/fVo36mzs18h2PYT4fEJh0EOdHWiluIwkdM/9zQ75jjvyWE9NVt86xik8ydUS306vV+Ix9bQGpXQwXQxm/nWGiJ6tTD8Enl+nknUEAt+YSuo2N0xooCy7+p+Xs5JcT2xpFgQ3+gnFNz/YTTwHFlt+EfiJ51bYuXkFMihZ58hYLsaPfUpPO2fuR4oArsbfYVQZ+4gRtto4ZelWsAGjZ/2YcPlJUF4uATi+xc6IR+otNqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DbuupIGylCmzOrOmQ0KTN4V2PZBDzCPFZ98SU8R4ufo=; b=Kq9YaXngpvBV3PkFyasZh7W0EoPuvFAkLm+mvA76cy4Yd1C//qISb1DwR5PodOUbhLVQ0XfOhwBJDAC2qUWn0YQE6SZAa+mcpg8Kq307BWmhdqPgia1xTeoteLuMB+sNxy8zmDgucY8/RLuri837qRRNE9PzJQoct4dZlsyKVXAOSTJu/bP13LrieMOFWVY/BJ//T1iMotQe5oiS0nGQc4bXv/CNlEhn4WQ33nTtuP3XoSYfSatTlhHSXZO11kEaMJnQue0gaRExcy1IxbLH71IggJ147CAp5RUIPJHVi9/LFCUtYIHn3CkiapfQ3wwwm7Q27fY5JJK3Y3xS/R63Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DbuupIGylCmzOrOmQ0KTN4V2PZBDzCPFZ98SU8R4ufo=; b=ujSd/By7wsZw1zXssF5mkSCoxp7o23qNMnQGPA+eP8Q9hy+sU2+jJ9wBCdVVwJEigbOJURb8ji9kvhFw4a6ZLYtt/e4kPhf4R13hzVPDJXO8CQPs0fXteETFngA6igvayDbC4p0IOKSs8ZACEu4mGgs9UivCHgB9XC+dZzdnGrU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 15:57:33 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 21/21] VT-d: fold dma_pte_clear_one() into its only caller Message-ID: References: <4a24a85e-267f-9de5-4009-b32b9ab8aa0d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a24a85e-267f-9de5-4009-b32b9ab8aa0d@suse.com> X-ClientProxiedBy: LO2P265CA0504.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aca4c3f-7bb6-46c6-771c-08da3356352f X-MS-TrafficTypeDiagnostic: MN2PR03MB5277:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HMxZt7mhpPHuscbANnWG/8NwVVsjJF9md9MZCOBFdXjNDdCoXFIbbp2q300UMJOJ45i4RWQTid0ONrIFWS5vwvbqRohhHX9A/EdD0fuHRltGSwBArHGggLeqGATc9Q5ZcEQYHxym9AB+VV1kQDxsF9UylMxfp+Ecdox5hHacWoLo0YaLrugKKuR4D9g+RxFyv7A7DxsIjtxLvLUXEz3d634HLeaRvXYXTFSbjndpty3ktkHLEEJ8Ym6pXboS4ElUEFGsWpxeneI0lFtyVRrom/AK9urzKdN/zoQl2OAISyW57pPLRuI1fSS29TjbE0PkkVHaR41wN6Ple/Diss2vAbsrg3RwRW07VheK5JsgfMEJl8dJA80lhPYAaxlK0PWvYjorYX5Z04DqROsElaUpdgkMwRFW2IO2V/iuBp4g0Yy9sF72QdYNNGyYQwPCEIdVVD+8AV+rmfhlsAM00Cg0fC4GowgVDYoene+kIA/2SsAN2T5dMuIvIzLDu0YJ6kFAIObpahoASj/xiYMJAgnVSypkKdBOw1pAMTIIir2DGGB5bs2d94q+oM/X6yZ1Rf5AqSnjTNcxoaweD0cd7tPpBOcrWeTO/eRD34YtiwaqAeQcr/z/KQsHLXS4Zt1UJtCdnIJ6+DlT5Gx3ZVOv5+NYfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(186003)(5660300002)(4744005)(33716001)(85182001)(8936002)(6486002)(8676002)(4326008)(316002)(86362001)(2906002)(66946007)(6916009)(66556008)(54906003)(66476007)(38100700002)(26005)(6506007)(508600001)(6666004)(82960400001)(6512007)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDh0aWxBOHloK2Y5TzRRN25VRjBtRm9xMDdiSXF5ZVlYMG9Cd1R2ZXFaZ2Nm?= =?utf-8?B?UElDMUx5T1BHTkduVHZlT0Z0U05pVElBSGNWclRXRjBUaU9RU3Mvb0YzRTdD?= =?utf-8?B?UXROd01TU3ZMT2JpZmM2MG81UU1KVzUrNWdOUEs0MW9hbGdzeVVSd2t2U1B0?= =?utf-8?B?TzhmUG1hV1QxQkRFVjNwTTd3WTRSdEpBZ1J3VXcrcTgxcVdIOEdYSGJxZzZs?= =?utf-8?B?RnZuUDhUWjd6R1NwaXNuUk5UNkswbzVCd3VVZU5yU2JiU0t0T3NWeUE2OExw?= =?utf-8?B?ejdBMXhSVGpjektvd1ZNbTZXRWIxMmhxdlBTS2p4YnJuSlMxYjF5Q3czcmVx?= =?utf-8?B?a0JjQXcyYVhENVljV3pRcXNBTitNd1ZvTjBuK1k2Q2g4UTZoYmgxMXpRMWdH?= =?utf-8?B?anVxcmdTZm9EOWtTaFZVOUdGNWYweU9mUkNMeWJFVzlKVHYwLy9hNUtzaFVu?= =?utf-8?B?Z2RQRFVaSTJTME5wa3JkTEw1YjkwMWRsWHRoOXNuN3R0d1hNSGVWN0Y2Z2Vh?= =?utf-8?B?NmlCdUo2WEQ2eW9OV1dIYk9zWnAzdUd4NTAxcTd0aUJhQTVDZVM4R01GR3dK?= =?utf-8?B?MWV3VDR6TVh5WnZ5SWlKQTJzK2FRNWsxaFYxTWNMOHdBTmVoWTc3QlVXUERM?= =?utf-8?B?YStyek5CT3hGTU10ZHZjK1RCSVd6cHRpeC8yQ2Y3RUJaMDBFaXZPSnNzK2NH?= =?utf-8?B?M0NNZXd5TExYOVl6MnJGZ1NwV0hmelpNNTZYWnJiOVpVMDhIK3UvQzVtb2Vh?= =?utf-8?B?bCtleDdHaDhRL1h5bkFuRDkwZ1FhVjBLT2YvTkdFMkkyMWk4THFidUdqQnJZ?= =?utf-8?B?dlEwbWYzU3lzZlZWcndwQkdNRHhtdFpvTmt0ZjV1K3ZleGgzQ2RGRTNuUDNG?= =?utf-8?B?c2hGUkY5ZHNlb3dyM213dWhoK1ZJemtCMjFMeGNDcVNwSk10RUFQbGQwbGRj?= =?utf-8?B?eXVpUmdsV1FSbGZkTEN3c3h2SWh1WTBackU0RmgxSFh0eGYyNllnYkQ4eENr?= =?utf-8?B?ckVQV2ZucWc3UXdQbW0wTzJVdXZtUlJvQks4TDVueXdYZFRpMUJJVWM1UTg5?= =?utf-8?B?dTJScEZDWmsxajBkRkFDVGxOdm5KNlFkdUlGcmpFRDJ4RnVYek94QysrNUNP?= =?utf-8?B?NzlobGNWU0EvK2NmekowUEJKalZVQWFOcklxRmw3QTVqbWNaQ2pQSVBSVmsr?= =?utf-8?B?NGt3eXpRODR3MlErL3gyb0hzcnJ5ZEw3VlBRZlBsWmx2QUVma3lrVHdMeWUy?= =?utf-8?B?K3kySi9RZVpCWlMrRnVoeHEzejk3M3dIS2ozNXQ5Y2tXeDMrTjdTM2lOdHZM?= =?utf-8?B?alpqZ0ZhUFkza2daMTZuWlFPaytOUndGalIvREJYMTZsMmVFYVhpRThpc0Vh?= =?utf-8?B?UEh5VnpyYkgzZW1tRkp3aVRJVTBtYmlzUld4d2FVUS9FQmNCVlZHaFplVDRL?= =?utf-8?B?dVpMRmdmN21JdGkrS0o2NVVpRUNES2ZNK1hZaWU0REZoNmFhNHE3LzdkMXJS?= =?utf-8?B?MmsxY0pKREhXdXNmTGhiNlVaVW9YcjdCcmhuZUtuWnJXVS8vamxxL1pGSUhj?= =?utf-8?B?U2FhSFlVbXNRNVBWazk2WFNhNjQ3eVBIS2ozWW55c0xjU2F2UlhuVkRuQUJR?= =?utf-8?B?MmtBaVM1WkVEdmV6cTltTGIrTVMrMzZHSDk3WUZycmNZZTNwd1ZxL0xhY3hP?= =?utf-8?B?T21yc2ZYeUpjdUVteExzQ3dGdyszNGxhUlNyOTdlWU1EdDRISk11SFBTYStE?= =?utf-8?B?clJzYXBGOUdXNm1tbWxocnRMUHhja0hOZHpPbHo1cExkY2p5a1J0bVBXVzVG?= =?utf-8?B?T0FzRGdDYW5xbjhDcDcyVmRISXBPanI2U2tpTWdsM1ErbnNsdkVCQXJSZ1RX?= =?utf-8?B?aXc4M3RWUG1lUVhaMi9pSjlNbWJIVDcyYVlqMEc3Z09hU2pISERVOVhXRzZV?= =?utf-8?B?UTlDZ3dGdm5mTndzUHNWcEdvaklaOWtHS0l3a0NaYTRTb0VoZzV0L2Fwd2d3?= =?utf-8?B?RWhuR0hURm9LdUwzR2FhY2ZRT1l6SHdTYVFNSXNNc2dUdExIbS83MkZ3T3ZC?= =?utf-8?B?SG1tY2JjbG9YSk95VFJsNHRtaGNJQlliRGRPOU1sTEVPMGhHTTRBVFlwSTBC?= =?utf-8?B?ZGNjaUxpUGc1Mi9LMWRwME5FNHhNcStLa0dGR3J1ZlNic2NkQnBvTGFrVW5u?= =?utf-8?B?REtXTC9obWFKL2lMT0o5Q0lhVWZzMGR0L2IzZ1BhRW1zcVNsdHJySXVZMHVy?= =?utf-8?B?Tms0WmVtS1I5bmVqTXJnTDhMSHlxaHRWNjdCVUNzNm1Tejlja2ZmWlhqT2VC?= =?utf-8?B?eE4zc3lMdm5ORXlFQlZxMzVuMnFLczErNWE3WnU3SmlqbktZNGErbnQwUUox?= =?utf-8?Q?4G/1XJV6sh9yDNf8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aca4c3f-7bb6-46c6-771c-08da3356352f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 13:57:37.9947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SMxBaz8YUUxA2EEuqLgSknaphm8+7RUn2VDdGSRiofzak+7CiyCsUaKNVgWCPTMqM9KApJGRr7ijS/ekDdt4Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5277 On Mon, Apr 25, 2022 at 10:45:10AM +0200, Jan Beulich wrote: > This way intel_iommu_unmap_page() ends up quite a bit more similar to > intel_iommu_map_page(). > > No functional change intended. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 13:59:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326900.549573 (Exim 4.92) (envelope-from ) id 1nomsZ-00067n-2X; Wed, 11 May 2022 13:59:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326900.549573; Wed, 11 May 2022 13:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomsY-00067g-VG; Wed, 11 May 2022 13:59:50 +0000 Received: by outflank-mailman (input) for mailman id 326900; Wed, 11 May 2022 13:59:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomsY-0005rd-5d for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:59:50 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9eb26f5a-d132-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 15:59:49 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1CD493200991; Wed, 11 May 2022 09:59:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 11 May 2022 09:59:47 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 09:59:45 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eb26f5a-d132-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652277586; x=1652363986; bh=ZfxY+2eFR6OWb CCmCrA2H42ZM6QzR3zM4jhjtkm55Xc=; b=VJt1w9ZEu8UjoaKMPZwBHLG2ZBWsN rwSqktAkpWGW6Yi2julBbixasy70wX7MumWorCbdr6dlfXjkivEKE4xjCTFDQy7O bS2ppXmrS/zTz46qP6h7v0vyCqJEG1ViG/0k5GVOYfVxXEbnIWvFqXHUX8UYPggJ X38TqwmT6zwxLbeM1MRguczTr/vJte4ka+C/BmvaB7ZerHfilGIB89I31o6j+ckh 7ZZVoK4sT0VCQMRucEa3jK4MMxgfKCXBWB2iQzADxQhCdMYqFPedz901bK1sZN1f 0sDtYi7Q+7Hf6HZE0lPA3jYmUWO04F4stXCv0yZvXlZL12XVXELkdR46g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 2/2] ns16550: Add more device IDs for Intel LPSS UART Date: Wed, 11 May 2022 15:59:29 +0200 Message-Id: <20220511135929.1823116-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> References: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is purely based on the spec: - Intel 500 Series PCH: 635218-006 - Intel 600 Series PCH: 691222-001, 648364-003 This is tested only on TGL-LP added initially, but according to the spec, they should behave the same. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper --- Changes in v2: - new patch, adding more IDs to the patch that went in already --- xen/drivers/char/ns16550.c | 80 +++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index c0d65cff62fe..66b397391e3c 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1077,12 +1077,90 @@ static const struct ns16550_config __initconst uart_config[] = .dev_id = 0x0358, .param = param_exar_xr17v358 }, - /* Intel Corp. TGL-LP LPSS PCI */ + /* Intel Corp. TGL-LP LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #2 */ { .vendor_id = PCI_VENDOR_ID_INTEL, .dev_id = 0xa0c7, .param = param_intel_lpss }, + /* Intel Corp. TGL-H LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51c7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51da, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7afe, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7adc, + .param = param_intel_lpss + }, }; static int __init -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 13:59:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 13:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326899.549561 (Exim 4.92) (envelope-from ) id 1nomsX-0005rq-Lq; Wed, 11 May 2022 13:59:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326899.549561; Wed, 11 May 2022 13:59:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomsX-0005rj-J1; Wed, 11 May 2022 13:59:49 +0000 Received: by outflank-mailman (input) for mailman id 326899; Wed, 11 May 2022 13:59:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nomsX-0005rd-1y for xen-devel@lists.xenproject.org; Wed, 11 May 2022 13:59:49 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d40c74b-d132-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 15:59:47 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id F3B80320096F; Wed, 11 May 2022 09:59:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 11 May 2022 09:59:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 09:59:41 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d40c74b-d132-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1652277583; x=1652363983; bh=Lexwo3wAboDXzqe+46X7nnMk4/mtVtLozIW S6x7/VRo=; b=WLHZwkFadLKiZX167D+7OwsLV5K5hv4LjBYyFqyfLsOhhrc9czw 0QD7U6oGOzNaTOZSMOgWPGTeTtNU+NNK5UrLpNCx91OEotqyawBDPi6sRaklL92W Slj6S4S5Lw2n644xEsry82kk3dYNdbhUdAlvn9w+s8UgutmWJNVjejwfgX0g+nfk ouaRVBnJEoerD/ed1gEh41jhP5qHo5ZcRhGzt3AnB0Fc2VC1Ijhx+mFNUCXA0X/V ovsqpC2W3c9LHrd82cWYXePjjRBOdsw/K6frzRp3ZY811vMuJY2c8IQVrjm8VOlL ika9XVu+/AR4I5NI+GVm9DgVWmidvIlAWJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Date: Wed, 11 May 2022 15:59:28 +0200 Message-Id: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v4: - adjust log message, change it from WARNING to INFO - re-add x86 reference in the commit message Changes in v3: - change back to checking 0xff explicitly - adjust commit message, include spec reference - change warning to match the above Changes in v2: - add log message - extend commit message - code style fix --- xen/drivers/char/ns16550.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index fb75cee4a13a..c0d65cff62fe 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) pci_conf_read8(PCI_SBDF(0, b, d, f), PCI_INTERRUPT_LINE) : 0; + if ( uart->irq == 0xff ) + uart->irq = 0; + if ( !uart->irq ) + printk(XENLOG_INFO + "ns16550: %pp no legacy IRQ %d, using poll mode\n", + &PCI_SBDF(0, b, d, f), uart->irq); + return 0; } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 14:13:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:13:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326922.549583 (Exim 4.92) (envelope-from ) id 1non5r-0000Wy-A6; Wed, 11 May 2022 14:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326922.549583; Wed, 11 May 2022 14:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non5r-0000Wr-6m; Wed, 11 May 2022 14:13:35 +0000 Received: by outflank-mailman (input) for mailman id 326922; Wed, 11 May 2022 14:13:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non5p-0000Wl-Tu for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:13:33 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89c967f2-d134-11ec-a406-831a346695d4; Wed, 11 May 2022 16:13:32 +0200 (CEST) Received: by verein.lst.de (Postfix, from userid 2407) id 260F668CFE; Wed, 11 May 2022 16:13:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89c967f2-d134-11ec-a406-831a346695d4 Date: Wed, 11 May 2022 16:13:28 +0200 From: Christoph Hellwig To: Stefano Stabellini Cc: Boris Ostrovsky , Christoph Hellwig , jgross@suse.com, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Rahul Singh Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm Message-ID: <20220511141328.GA31939@lst.de> References: <20220423171422.1831676-1-hch@lst.de> <20220428132737.GA13999@lst.de> <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com> <41c2483c-ab54-41be-7815-9d4a98e0249e@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Apr 29, 2022 at 04:15:38PM -0700, Stefano Stabellini wrote: > Great! Christoph you can go ahead and pick it up in your tree if you are > up for it. The patch is in the dma-mapping for-next brancch now: http://git.infradead.org/users/hch/dma-mapping.git/commitdiff/62cb1ca1654b57589c582efae2748159c74ee356 There were a few smaller merge conflicts with the swiotlb refactoring. I think everything is fine, but please take another look if possible. From xen-devel-bounces@lists.xenproject.org Wed May 11 14:16:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:16:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326929.549595 (Exim 4.92) (envelope-from ) id 1non8D-00017P-QZ; Wed, 11 May 2022 14:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326929.549595; Wed, 11 May 2022 14:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non8D-00017I-Lh; Wed, 11 May 2022 14:16:01 +0000 Received: by outflank-mailman (input) for mailman id 326929; Wed, 11 May 2022 14:16:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non8C-00017A-0J for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:16:00 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e055ca26-d134-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:15:58 +0200 (CEST) Received: from mail-bn8nam11lp2172.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 10:15:56 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5803.namprd03.prod.outlook.com (2603:10b6:806:116::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 14:15:54 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:15:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e055ca26-d134-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652278558; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=jXPGiBibOf4CplYiKWywPrN1tFR2O4LY/Sfbp0c5l3c=; b=gve2vB1/hEWy/pyACVrqls2ugV7NcxtqHV+3aX85Cb1ycqcW/UF9/TZ2 6gRiqJEpF18CG95ov8WrSdAYS0fGT85tmav86OMvB3Oda+R4jzXI7gyjX KLxVRNZyd8QZvv2XeTc6OZIzMo4brz0dXavhLJhzJDyGzmBV/xT78Wzqn I=; X-IronPort-RemoteIP: 104.47.58.172 X-IronPort-MID: 70944886 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A5r1haDlMsuD1xVW/xbiw5YqxClBgxIJ4kV8jS/XYbTApD8mhDcDz zRMXz+AOPeCZmGgKd9+ady38k4GsMSAyoVkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng29Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPg21 OdijIGiZDssP/KVl70kQjlTSBlXaPguFL/veRBTsOS15mifKj7G5aUrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mcGc0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjw1yWjI20GwL6TjbYN3DmKkBxb7JeuPYDyRfOmYtUWkEnN8 woq+Ey8WHn2Lue3zDOf93u2i+znnCXlWZkTHrm16v5rhlKIwmUZThYRUDOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwAsTCNFadEgnN87Q3otz FDht8jyGTVlvbmRSHSc3rSZtzW/PW4SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwhNulHzj1m mmOtHJn2O9VitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5L2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:1yu9SqB4WAh6iTLlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj4lLYIk7zI9HakGOuh5Dt T/Q9pVfY51P78rhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70944886" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dV/6IHWHpJelJDVbm2f4Nzs7IiCAkdrKoixZGP5wJ9EWD7bEGr3kuaUMsjhTYojIG70IJG3hInjSnS01GAD3CmWBnL0TbgvQGX6BVCAeY/jbbRTGlBheCqDyZv5xRLOvra3VQI0EJ0ZSQ7TGRsfJGLBU20pjew1sRM32+pJZNsfRSxswniPq1WLP7qmYGglqchdAI2fFHTf3mWzp9x8MdSmZIbHwg/ny/S1LU6cuICVSOGInflyv9nbXZ+QrYHMBGEm+q4KuGIEu8jU4EeG9abJP2qD0L0pnWKUpOsTL2EZYzNTIFIPHvxczG/uGXjGIw4Sm2S2m80QKDnVCvGXNwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bSgWIYdU4lCodwgwd0CX3I9ZlWWCoBOVBvN3BKDAp44=; b=amfxIxyQsj2i9SpBbgKCd9Gd2JqOjj5toJ0UykMu5QeaRjwghR87Q1De5CloH4oWkeCn3POm9JIlGlNnW+zPHRGzFonkJWoQ6AfZPWsOsXYi1dDnYA159mt5w4lrNh06gmc0JMFC0jwMz7QKXP6JqLm/Ja7juToN3HT7y2ZfebKBTA3fmdSOgdC3PMObv2w/ZzXRxO2aA6BbsElQ4SmMJhhSJDWRore3yIlkt05nF3DV1jHZ4gGgDBacqdfQ5PA8iwoAGCaviWZhj5+wXNGe2paT9UBzfCFEdyZ3CB7upb7VrXj79t6Ccp4RI/pEVbQQzPdN/pirqwuQGlYRqKufnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSgWIYdU4lCodwgwd0CX3I9ZlWWCoBOVBvN3BKDAp44=; b=uLFUUzQQcu+tTnrwJ2C3QNJUtENIdPy7MaG2E+OB1cPPwHTaOWU4ijMBqchm17zudj85my36ynBEUTawJY8WTG7ztKHSsR5hG0NQI28txevf/TkRtjPrjsl9VkFeYQdckhGF4TQLgckOhwJtR1EnVH3r2KDCwEPmDlZENpsP4b8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 16:15:49 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> X-ClientProxiedBy: LO4P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00bc6145-e6d3-49ed-0351-08da3358c275 X-MS-TrafficTypeDiagnostic: SA2PR03MB5803:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1oenoG6UHVZG6N75iXtfDalZMlY8573UV/bGtDUKc5frRC3e8YpHGpY/2U1hHMFwfjB2FZO0Ljjnf8OgNW827ltL2loxre+xShXQyJAbD+ObowFDuTeqhRjBiLukoq/gcky7FmD/t0OUkMJ7Jx+s1AGGrlaprPITcJ4ri1J3VydGRJO/VBB6HBH5uvmF0Nk3z4QBkqvgvvPg940JkpdCgVGYdbnUFEtnCoyJyuvR8LF0gtZQHK07koheNCzslhgE6NFwZncve8/I+E0QmTmAxTYPThNUbvIxoCBB95l72U1crgDmw/ic1kd/G2JH/c3SeU/bpcTIU1mz6V4ka63s2txoHN7QZ1mrupVCIdE8TXxAjzLL5+bZvdqiQXqXio7pikjh5eeBglSqCpYOWu83OnglKvhKBKbjI/aXV7qZLzoYohbtS8Ik8uKE3n+m/ZkMUq1H0jeRc9k2dLDwjRbekOYoeQaxjeiXdZkPdF10g5pFYmz6A6GGPnO1mikc09bzi2yE/Sk3YuO6/+GRl9svg7n1yaAL7mEft5COpzd5/ZuxQ3sGfDDHab0Ckhfn+93gnBODE65c7gDGTTDaJ1xHx0hNmj3btySJAPmcg4NErG2n0LjNwQQKicWzpN6PNVgadO1jK63waTuysquBF5tfZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(85182001)(2906002)(33716001)(8936002)(82960400001)(38100700002)(5660300002)(66574015)(186003)(4326008)(83380400001)(508600001)(66556008)(8676002)(66946007)(66476007)(54906003)(316002)(6506007)(6916009)(26005)(9686003)(6512007)(86362001)(6486002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEE4ZmhjRjhwckdHeE0vM1Vkc001WGJiWHBTSGg1aUdDOHU5cW1sdlJaOGdk?= =?utf-8?B?bGJmQ282UEVjV2tId3BvOUdXYzJiVi9KVDBUUzk0a0dyL2pyZDBYVW9nM3FC?= =?utf-8?B?MUJiY3NUL1NuMGEvbzREVzdnYjdZeTJNL1ZVOW9LS3hxMDZUa1JLVkI4NlhG?= =?utf-8?B?c0VNdmdVSlUweS84cCsxZk5DeXZHaUNjT2RBODJVVHRNcGRoYW51Z09rQ0Zt?= =?utf-8?B?d2RUeEVZcGlUTjVmOE43cUd5YVorNzNwWFFnZUJKNU5YZTBlWnoxK21aSSty?= =?utf-8?B?Uzh6N0hpNXpIQk82V0wxYnFQdUdKMmcxZWMrNlphT0EvaUhFa1p5MmJPcDdV?= =?utf-8?B?YXA2dmphcmlya3NwSUdxNUEwYkNNaDZhZVNYbG1ydzdwcHZ3R0pkQVJKQmhj?= =?utf-8?B?VGd2TitFZG0rUi9KenZQT1BEdVZjaWM4b3IyVVlJbHc1dDZkY05MSk8zV2E1?= =?utf-8?B?ak9FbmxERkhvb1M0QVVjVHJCaE4yWnhleUU1UFdma0N0NWJqbHFVRGVGM3ln?= =?utf-8?B?VE42TklhVVlKbTFsbGNCSFRBTThNRlNVK01YTHljWUptUmFNdnZmT3NXL2p1?= =?utf-8?B?d0lKSDlPdDRFMkx3K255SW45RkJYcHpGM0wvaHF3VElCVG5lUnRpVHNLUm45?= =?utf-8?B?NnRlQ0I2WmZhRUJVb3VoM040VExMOEZ0dmFBQW92cGhwT2w4OW9lZ2FFV09G?= =?utf-8?B?UXY1UXUzVFVsQlZMVEVPV3BuN0dkQ0d2NUs4YzFrMm5MbjlteHQ1OUxDc1dV?= =?utf-8?B?Y09va0lLVG5CRDJKb3VRL2YrRVBkVE15cXFPNGxMTkhkWEtZT2RuSmk4cGkx?= =?utf-8?B?WlFpVVBYN2t3bDFhd05jSXVMRUNvYnd5S3ZKSXBFRnd6emJCWTE5QTBTU3d3?= =?utf-8?B?YS9oWC9pQnEyRnBFSld2TmpPUS9HZEhqQ2JjeXR5YzhnTTJ4cnpNRG9URnpl?= =?utf-8?B?UmxjdDREd0xjQ2FGUjJrRTh2dDVZTHNQdmtkbklnU3NMOEhqanFaYjdmVVJE?= =?utf-8?B?OTJPYkg4YWVjbkJYMEM4bWJRTHdobzh6WG1jSVp4SnpER3JhL25meGd0OHFr?= =?utf-8?B?U29peHgzdTRmU0h2Mkt2b1hYdzdnd3hIK1F2R2RSZVhlYjludGJlcGJVeXBP?= =?utf-8?B?ZksyV0c4UmtSb1VTUXNDRG1YUE0xYUhKZ0drb0QrMDFKT2xkTUZ2SUxBTmt3?= =?utf-8?B?YTNaRVZaWEJTR2cyNU05a0JIdGhxRzlhQ3hIdnRjTmEwQVBHbEZ0Z0FBdDRu?= =?utf-8?B?VHo4YUlBUnhrOHRkU2dKWmg0c2hiOU5lYUVXMXVEeVY2SUpSK05vSlpsRWpi?= =?utf-8?B?MG5wYTNtYnlNb2ZsR0xQZFpDcWRTTXQ1UnNvVVIxNEQ4Y2NQdVpUNXBCYnJC?= =?utf-8?B?alZkTGQxS0dTTW5tRU1XY0NSVVhBbHBtcmgzL04ydFpUSEJDaDRUVExPV2Yz?= =?utf-8?B?WWRSaFVwMVFwTnZ3SGhia01rQVRFdGVLWDNhcXRqRVhTSVVKTWdoMHFZSXdS?= =?utf-8?B?ZjJEcWJwaWpvUmpqZExqZ1QrMkxqMEpqb0tRTnlUbU1YUnlIYnIvU0NhRkxa?= =?utf-8?B?eUZodDZsM2hFT005V3NnaFVwdDNrQVJBbk1ZMWxycUJJdmxPbFY3M1A5SStj?= =?utf-8?B?VkZIRGlZU1ZHWktKSVpxckFsTGtsYUJELzEvanZXSC9OSVlIT3NaVU02WURQ?= =?utf-8?B?aGs3VzdWT3lqWE5HY21SMmlubjdHMnJFTFNJQmNFdWZBcnJEajlFa2pidWky?= =?utf-8?B?dXl5L09XWmpVNTBQVEZKY3BobXNaMWJWd3lGeDNWaUIrOFgxcHVOYzl4bVFz?= =?utf-8?B?Y2hUUDZudm5uVTZrTzhTRUZ5bkU0eE5ncDNKUnltbWNTZGhTUjY1VEl6Tzdn?= =?utf-8?B?ODNySCsybGdRSU4zK3dmNHRYTENPZnQxcTVhWEdYMmdCR25OelFJRS9rbW5k?= =?utf-8?B?L1dadWk5cUdBOXdkcUNCMXhqK0MyejVyem9tVUdpWmh5ckdheWxsMjNxSkwr?= =?utf-8?B?NVpheWhFazRneUE3aEFaVmJjWVpvL05walBpeHpwZGYydVpKRmNFZDZoVFZl?= =?utf-8?B?dlpwMklyKytLNklJMUhLQ3RWNFpzcEdVQUdObkJjVThiVHRBL2xDTzhGSnlD?= =?utf-8?B?TXZHbEE3OFVEOVZNRDcwYlF0MTNXWlRqaTMzSWlDaG85bTdnSE0wZ2ZiQlkx?= =?utf-8?B?SFJWa1pqOFE5MEJuVmRicVhUSmxmRmlwWUhxUlZrRkVpUW9SNllVbWFReHFq?= =?utf-8?B?c0hIUENheCtmNjJsdnlJNDRsTHBlc0lScFJibTYrcmtTbFNxUk02NXVkYWR6?= =?utf-8?B?QXB1aWwrMUk2aGlyUGRoT0g0ak5lc01oWHJiKzRoSnlHdFZJL1B2U0tBRTEx?= =?utf-8?Q?LBG3EREznpHsrqkM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00bc6145-e6d3-49ed-0351-08da3358c275 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:15:54.0808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OKIfzg457/n6ilQsWujETWFYpPqC2mni7gU0ltiBwA7L7km1YaXkbLRZpXLD6eRU4cLiIlaqxy8+55lPMsQ36Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5803 On Wed, May 11, 2022 at 03:59:28PM +0200, Marek Marczykowski-Górecki wrote: > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > by the PCI Local Bus Specification Revision 3.0 (from 2004) as > "unknown"/"no connection". Fallback to poll mode in this case. > The 0xff handling is x86-specific, the surrounding code is guarded with > CONFIG_X86 anyway. > > Signed-off-by: Marek Marczykowski-Górecki > --- > Changes in v4: > - adjust log message, change it from WARNING to INFO > - re-add x86 reference in the commit message > Changes in v3: > - change back to checking 0xff explicitly > - adjust commit message, include spec reference > - change warning to match the above > Changes in v2: > - add log message > - extend commit message > - code style fix > --- > xen/drivers/char/ns16550.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > index fb75cee4a13a..c0d65cff62fe 100644 > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), > PCI_INTERRUPT_LINE) : 0; > > + if ( uart->irq == 0xff ) > + uart->irq = 0; > + if ( !uart->irq ) > + printk(XENLOG_INFO > + "ns16550: %pp no legacy IRQ %d, using poll mode\n", > + &PCI_SBDF(0, b, d, f), uart->irq); There's no point in printing ->irq as it will be 0 or else the message won't be printed. With that fixed: Reviewed-by: Roger Pau Monné Thanks. From xen-devel-bounces@lists.xenproject.org Wed May 11 14:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326936.549605 (Exim 4.92) (envelope-from ) id 1non92-0001fb-58; Wed, 11 May 2022 14:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326936.549605; Wed, 11 May 2022 14:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non92-0001fU-2J; Wed, 11 May 2022 14:16:52 +0000 Received: by outflank-mailman (input) for mailman id 326936; Wed, 11 May 2022 14:16:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1non91-0001fG-6k for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:16:51 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0603.outbound.protection.outlook.com [2a01:111:f400:fe06::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff5a206e-d134-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:16:49 +0200 (CEST) Received: from AS8PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:20b:310::34) by AM4PR0802MB2225.eurprd08.prod.outlook.com (2603:10a6:200:61::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 14:16:46 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::89) by AS8PR04CA0029.outlook.office365.com (2603:10a6:20b:310::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Wed, 11 May 2022 14:16:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:16:46 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Wed, 11 May 2022 14:16:46 +0000 Received: from faeb3db08815.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE86418C-AB1B-4DAE-947D-4F1732C4237D.1; Wed, 11 May 2022 14:16:39 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id faeb3db08815.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:16:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PR2PR08MB4730.eurprd08.prod.outlook.com (2603:10a6:101:19::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 14:16:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff5a206e-d134-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T8n/oM4xfKJCQ2vaF62Y9UKRCP5z2VP9hqwPpuG6tv7PRJwVEuXf5xOshz+dkOSQPTcuwjtLCpxxt+6CsWSTg1L641scsrBOWm7BOC3legXg8zHUXYY6h+tzefqeSvaVh+wr8gs3JtOvC5nLnkfJdcWKQG7NdffprRfm6ePBPUGz7g7cgv2/XLbpyq/bjVPT3EdL2x+hJdlDX8wDuLKlxPv9igAQ7h5X06YJ3105hJCqRn+S7coUlby6edB2On4hYylQWXs+eQNj4S6Tx6/TpUkEE9IcKcPf0+mmy1qpt2GCpNsNBsUzgHxHo0rNKm28PJaD/+YeouAddlkot9SYTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Txrs/sgZUAQdW+NVVTKGqX4PfNujslWU935SxZMzkXk=; b=aenlN/3fbgzEMoFYCSUVgVlMbp+VfjVSkjskSgBUeoPAed3uMMAS0EcSX6MhOQxZPAYWamlRcmLRLEXj0FEcWCVM7mBXcLW9LGDpcTdFajrcOoUOQZW6uG+Mf1FMqfWtPJki92tLc1BeuGEGFvlB/D8zEuyFVaurhefgrhKSebDskaYEUyxxO2XmRIT6QJw+4rg8tpfhuHfGSG+oUE1qnPCdCB+GHh1DkcbCQt3YPBlAh76PxlHoBEDHnT9kfqfkR+zG+bfMR0D4kLFI5N+iradQAw+HCYnmpMaA0GqolOaZjcZ2C0gryk2Mq873KbpTWBJE5DLzM7OjMu98CMoDwQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Txrs/sgZUAQdW+NVVTKGqX4PfNujslWU935SxZMzkXk=; b=c93WPjrGLcKvQZNXKoOcBbfOyiGPEPdX3HFTBwoKftqMXh6Q7pnS+JhhIE4uMzlIJboHn1kJTzxXeECkL6lL2OPa888exAKv+gcR1fvnbgap3DAaPuGMEJ3kHS91ciFqozzvp2mcxio9bymlslVHGfj47Qk49HqEELQQhfqeHag= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 15360ac84834ea70 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SBCzh6AvmYjD33aRA68sl92McKlu1ZVjtsLMryayDN2w1a5gpJXeW4fZQ0zdcsTeYfHrXrAvPzbwR8Py8ZGbKcir5RGwNeyAMBwpGFz1HY8LeDltP/C0FeycTd5SsiyKPw1MCtaEw/M+aUHTS3QtU3qehU9Nkl12FUI3uHCpCtOXtwe993iXOYp3OsBp1a+VSvMqlJ3cKjNLRfDceTWhEf6yiBOHtSOvgrQHjzw/LOZqxRuETvdLQgU4bTN8vZrsgZiKuOOqZMvjxz5k0R2mSlTxXG01yjou5vmMxyLo8IIp9QTn/OQYhA5+eMjswDIdDIJh2emG2JNUqzRF/uxBUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Txrs/sgZUAQdW+NVVTKGqX4PfNujslWU935SxZMzkXk=; b=Q7yFRuMP+1+VDUUK4ktILVi3+joGiWUXvthgNDApOZR0KmKi46DSK4jEzwgXlJAkpwPiK6xZ8ev5icHMwkJ36FWuKBj7coRxLMqgdqVwTFQzYbNU8aidIM7VvDFFzcjCOgjkSbJ0u7wzgjv/sw/PcKcwH9W4TL8S54Uc3c4dNd0zg2k9y20bZYVtab0eWs2gPluktWf2UHCIlz7QolnZjpPmpAJapQwaJg1Wi/R+DH2q/f9PptLZWEgWHCGVyV8rsWVgFtzjzZ3XTTe2RfUeSbVvlBN/LA95S1sNboQEZV/2h1Wcgswc+FcQ/Z3zxwcWRe45arv33iwXA9mC5tNbVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Txrs/sgZUAQdW+NVVTKGqX4PfNujslWU935SxZMzkXk=; b=c93WPjrGLcKvQZNXKoOcBbfOyiGPEPdX3HFTBwoKftqMXh6Q7pnS+JhhIE4uMzlIJboHn1kJTzxXeECkL6lL2OPa888exAKv+gcR1fvnbgap3DAaPuGMEJ3kHS91ciFqozzvp2mcxio9bymlslVHGfj47Qk49HqEELQQhfqeHag= From: Bertrand Marquis To: Stefano Stabellini CC: Julien Grall , Andrew Cooper , Lin Liu , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v3 4/6] xen: Switch to byteswap Thread-Index: AQHYZFb+rXOikPJI0E2wxRXQiKvDPK0X7v0AgAAFDwCAAAI1AIAABM2AgAADuACAAQJtAIAAuZCA Date: Wed, 11 May 2022 14:16:36 +0000 Message-ID: <773ED71F-3A5A-4682-82EB-8AB881D3D7FE@arm.com> References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <00d82608-9430-6b20-26b5-207c62358179@srcf.net> <3670ae1b-fac2-7665-b2a7-f3e414cd6c84@xen.org> <2f5b0e01-2214-6150-bef2-e4f92cebd6ef@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9577166b-0f84-4864-ce85-08da3358e1c0 x-ms-traffictypediagnostic: PR2PR08MB4730:EE_|AM5EUR03FT040:EE_|AM4PR0802MB2225:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mywj+mfho+puBsqVj5wS3DFsjI1j+t/oDvvFm8Y2AtvPmTwtMHvEje3TtBn5/cxJXPNgIW8dfmGII0E2EDugcEVh71x8a17cr3mkBZCeOA6+q/RljhwLs9BitapMyRerP255oQon656hAS6+Fdj3JCIZ+GCuy/ztWKSq6WDFF7zwYwkc6r8mSKLmZCfsx1n3WZBF1AfcfQsUKxruIpHOWgk7S8F5VGRFEYDm2QTirBShnRo42+kqUQsnN7mcJr+QDGP7NlcHhw0/Fgxfhtm6ZZsjbboYJuH5wdoDBr2tPygRODHpIE8NI9DG352L9voZDC61zDzEpAZz831Zk91Ypf+Ap2iwh5SU0QdY6mkVJedlyXrC6ZoX0LbQdZBIzQrVtWyUOb0je7Z9KJAiWheVjvkhj80aEksLEkZcB+jra+R1tPTwm6aoexS6IIgiqkUqRWUuywzrYfVB+0v5JBN5AfJne0Z967mAAGkpmErXKV5P51p4Vfl0xUP823+TSx3xlqi/NPFOJhcKzaSjTX9cokMNFajXvWT1YU6KCYh61+3pA0epvkazZfvJAgY3R1L/DWDNpcHgVatz1BSkQ3Q/GFKrrloQyUBu9Y74CyTYxLk/6/Fx3L/k6O4NsqiYZCxvKZjZSPzh1TAeIMzrHtep3SNXbk8ePOt0+tZNIPL/ua3b3piXb4+ZV/20APNPifO4+4i1VgNVk59MnGDZwUgJs4DHynUlA/ZlqSHLqHFHnsP8SXJAjD+50/wNZKlEYVh+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(2906002)(38070700005)(38100700002)(122000001)(26005)(6512007)(508600001)(36756003)(5660300002)(53546011)(6486002)(86362001)(54906003)(6916009)(6506007)(83380400001)(316002)(71200400001)(91956017)(76116006)(66446008)(64756008)(66556008)(8676002)(66946007)(4326008)(66476007)(2616005)(33656002)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <7129BE7EA6E8E244AA2B77382538D35C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4730 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5eef53ab-5d53-4004-1679-08da3358db9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ys4MRYWYUtJVKW7oTDJL9jQcR5SPtdq7emNbuNdJGLMd3GG2t8/+tGcU2+0UL+7y0Qx6R5FKlzeBT+e2Rkq/OY07p0WGw4YW5qGYQGiUPCtF8EfoKrPsq0QUJzC0evzIvU17ZYNGRzG8oNuW10mxZHI4BVrnPXO5tZYQJdvioOqciV0/CCfpIclmfkSFnGk9zqT9QhUPyZNnAmQGByl9BMSGEKtSknRo1vLyhUAnoHdvkfNdqaoz/CpyYvPtGz2aSLB0hYtT5ef9BFs9PeZohF3ukLfvZY74eHkKUSrjK+fZnVKHG0T7AhKDIWdY7GrGKmNGNPaGlafaBGUhJjeM8+HyWh4uoMGBM2fDhHD6aG+kOeSvFrMpAybRz+VSDWGdNtusagnHc60vAt5yaE6PfmylaGxZMaElgzlMeoP6iWlecpMBAUVYYA7WHHericWvvbpgYy8u2GeVSoQcPgo4oISbvWoft2D2EleUIAs8K8QGI90hOifFUo6Oc4RA34OfmpHMXJWp5nFGv6o8g8vQ8jvv8RuOhiuhcxzbzPSuCXJg24WZzU5V83RUt5QFqP8hhosCP+FzYAVxg4JdH04uqEh7OKvzUeS+8YMaWBUz6vqZvlqucAxm3TfADUfNxRkhZmhic0T7o6COihevkuGRHnQVODkFTxtiaK3hz+tgjdvfuhBvtnJKJiGiDH9BU+GR X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(336012)(6512007)(508600001)(36860700001)(26005)(6486002)(47076005)(40460700003)(6506007)(86362001)(186003)(2906002)(5660300002)(2616005)(83380400001)(356005)(36756003)(53546011)(81166007)(82310400005)(8676002)(6862004)(4326008)(54906003)(70206006)(70586007)(8936002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:16:46.3213 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9577166b-0f84-4864-ce85-08da3358e1c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2225 SGksDQoNCj4gT24gMTEgTWF5IDIwMjIsIGF0IDA0OjEyLCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gVHVlLCAxMCBNYXkgMjAyMiwg SnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEl0IGlzIG5vdCByZWFzb25hYmxlIHRvIHNheSAidGhp cyB1bnJlbGF0ZWQgdGhpbmcgaXMgYnJva2VuLCBhbmQgeW91DQo+Pj4gbmVlZCB0byBmaXggaXQg Zmlyc3QgdG8gZ2V0IHlvdXIgc2VyaWVzIGluIi4gIFJlcXVlc3RzIGxpa2UgdGhhdCBhcmUsDQo+ Pj4gSSdtIHN1cmUsIHBhcnQgb2Ygd2hhdCBCZXJ0cmFuZCByYWlzZWQgaW4gdGhlIGNvbW11bml0 eSBjYWxsIGFzDQo+Pj4gdW5uZWNlc3NhcnkgZmljdGlvbiBnZXR0aW5nIHdvcmsgc3VibWl0dGVk Lg0KPj4gDQo+PiBUbyBiZSBob25lc3QsIHlvdSBwdXQgdGhlIGNvbnRyaWJ1dG9yIGluIHRoaXMg c2l0dWF0aW9uLiBJIHdvdWxkIGhhdmUgYmVlbg0KPj4gcGVyZmVjdGx5IGhhcHB5IGlmIHdlIGtl ZXAgKmNwdXAqIGFyb3VuZCBhcyB0aGVyZSB3b3VsZCBiZSBvbmx5IGEgcGxhY2UgdG8NCj4+IGZp eC4NCj4+IA0KPj4gV2l0aCB0aGlzIGFwcHJvYWNoLCB5b3UgYXJlIGVmZmVjdGl2ZWx5IGdvaW5n IHRvIGluY3JlYXNlIHRoZSB3b3JrIGxhdGVyIG9uZQ0KPj4gYmVjYXVzZSBub3cgd2Ugd291bGQg aGF2ZSB0byBjaGFzZSBhbGwgdGhlIG9wZW4tY29kZWQgdmVyc2lvbiBvZiAqY3B1cCogYW5kDQo+ PiBjaGVjayB3aGljaCBvbmUgaXMgbm90IHNhZmUuDQo+IA0KPiANCj4gV2l0aG91dCBkaXNhZ3Jl ZWluZyB3aXRoIEp1bGllbiBvciBBbmRyZXcsIEkgYW0gYWN0dWFsbHkgaGFwcHkgdG8gc2VlIGFu DQo+IGVmZm9ydCB0byBtYWtlIHRoZSByZXZpZXcgcHJvY2VzcyBmYXN0ZXIuIFdlIGhhdmUgbG90 IG9mIHJvb20gZm9yDQo+IGltcHJvdmVtZW50IGFuZCBzcG90dGluZyBvcHBvcnR1bml0aWVzIHRv IGRvIHNvIGlzIHRoZSBmaXJzdCBzdGVwIHRvd2FyZA0KPiBpbXByb3ZpbmcgdGhlIHByb2Nlc3Mu IEkgaGF2ZSBhY3R1YWxseSBiZWVuIHRoaW5raW5nIGFib3V0IGhvdyB0byBtYWtlDQo+IHRoaW5n cyBmYXN0ZXIgaW4gY2FzZXMgbGlrZSB0aGlzIGFuZCBJIGhhdmUgYSBzdWdnZXNpb24gYmVsb3cu DQoNCkRlZmluaXRlbHkgd2l0aCB5b3UgaGVyZSwgaXQgaXMgZ29vZCB0byBzZWUgdGhhdCBteSBt ZXNzYWdlIG9uIHJldmlldyBwcm9jZXNzDQphbmQgZWZmb3J0IGlzIGFjdHVhbGx5IGluIHBlb3Bs ZeKAmXMgbWluZHMgOi0pDQoNCj4gDQo+IEluIHRoaXMgY2FzZSBhbGwgb2YgdGhlIG9wdGlvbnMg YXJlIE9LLiBXaGV0aGVyIHdlIGZpeCB0aGUgYWxpZ25tZW50DQo+IHByb2JsZW0gYXMgcGFydCBv ZiB0aGlzIHBhdGNoIG9yIHNvb24gYWZ0ZXIgaXQgZG9lc24ndCBtYWtlIG11Y2ggb2YgYQ0KPiBk aWZmZXJlbmNlLiBJdCBpcyBtb3JlIGltcG9ydGFudCB0aGF0IHdlIGRvbid0IGdldCBib2dnZWQg ZG93biBpbiBhIGxvbmcNCj4gZGlzY3Vzc2lvbi4gQ29kaW5nIGlzIGZhc3RlciBhbmQgbW9yZSBm dW4uDQoNCkkgd291bGQganVzdCBtYWtlIGEgc21hbGwgZXhjZXB0aW9uIGhlcmUgKHdoaWNoIGNv cnJlc3BvbmRzIHRvIHNvbWV0aGluZw0KSnVsaWVuIGtpbmQgb2Ygc3VnZ2VzdGVkIGR1cmluZyB0 aGUgZGlzY3Vzc2lvbik6IHVubGVzcyB3ZSBpbnRyb2R1Y2UgYQ0KdGVtcG9yYXJ5IGJ1ZyBiZXR3 ZWVuIHRoZSBwYXRjaGVzLg0KQnV0IHRoaXMgY291bGQgYWN0dWFsbHkgYmUgc29sdmVkIGhlcmUg YnkgbWFraW5nIGEgcGF0Y2ggdXBmcm9udCBhbmQgbWVyZ2luZw0KaXQgYmVmb3JlIHRoZSBvbmUg aW4gZGlzY3Vzc2lvbiAod2hpY2ggbWlnaHQgcmVxdWlyZSBzb21lIHJlYmFzaW5nKS4NCg0KPiAN Cj4gSXQgd291bGQgdGFrZSBsZXNzIHRpbWUgZm9yIEp1bGllbiAob3IgQW5kcmV3KSB0byB3cml0 ZSB0aGUgY29kZSB0aGFuIHRvDQo+IGV4cGxhaW4gdG8gdGhlIGNvbnRyaWJ1dG9yIGhvdyB0byBk byBpdC4gRW5nbGlzaCBpcyBhIGdvb2QgbGFuZ3VhZ2UgZm9yDQo+IGFuIGFyY2hpdGVjdHVyYWwg ZGlzY3Vzc2lvbiwgYnV0IHNpbXBseSByZXBseWluZyB3aXRoIHRoZSBleGFtcGxlIGNvZGUNCj4g aW4gQyB3b3VsZCBiZSBtdWNoIGZhc3RlciBpbiBjYXNlcyBsaWtlIHRoaXMgb25lLg0KPiANCj4g U28gbXkgc3VnZ2VzdGlvbiBpcyB0aGF0IGl0IHdvdWxkIGJlIGJlc3QgaWYgdGhlIHJldmlld2Vy IChKdWxpZW4gaW4NCj4gdGhpcyBjYXNlKSByZXBsaWVkIGRpcmVjdGx5IHdpdGggdGhlIGNvZGUg c25pcHBlciBoZSB3YW50cyBhZGRlZC4gSnVzdA0KPiBhbiBleGFtcGxlIHdpdGhvdXQgbG9va2lu ZyB0b28gY2xvc2VseToNCj4gDQo+IC0tLQ0KPiBQbGVhc2UgZG8gdGhpcyBpbnN0ZWFkIHNvIHRo YXQgYWxpZ25tZW50IGFsc28gZ2V0cyBmaXhlZDoNCj4gDQo+IHJldHVybiBiZTE2X3RvX2NwdSgq KGNvbnN0IF9fcGFja2VkIHVpbnQxNl90ICopcCk7DQo+IC0tLQ0KPiANCj4gDQo+IEFsdGVybmF0 aXZlbHksIEkgYWxzbyB0aGluayB0aGF0IHRha2luZyB0aGlzIHBhdGNoIGFzIGlzIHdpdGhvdXQN Cj4gYWxpZ25tZW50IGZpeCAoZWl0aGVyIHVzaW5nIGJlMTZfdG9fY3B1IG9yIGJlMTZfdG9fY3B1 cCkgaXMgZmluZS4gVGhlDQo+IGFsaWdubWVudCBjb3VsZCBiZSBmaXhlZCBhZnRlcndhcmRzLiBU aGUga2V5IGlzIHRoYXQgSSB0aGluayBpdCBzaG91bGQNCj4gYmUgb25lIG9mIHRoZSBtYWludGFp bmVycyB0byB3cml0ZSB0aGUgZm9sbG93LXVwIGZpeC4gQm90aCBvZiB5b3UgYXJlDQo+IHZlcnkg ZmFzdCBjb2RlcnMgYW5kIHdvdWxkIGNlcnRhaW5seSBmaW5pc2ggdGhlIHBhdGNoIGJlZm9yZSBm aW5pc2hpbmcNCj4gdGhlIGV4cGxhbmF0aW9uIG9uIHdoYXQgbmVlZHMgdG8gYmUgZG9uZSwgd2hp Y2ggdGhlbiB3b3VsZCBuZWVkIHRvIGJlDQo+IHVuZGVyc3Rvb2QgYW5kIGltcGxlbWVudGVkIGJ5 IHRoZSBjb250cmlidXRvciAob3Bwb3J0dW5pdHkgZm9yDQo+IG1pc3VuZGVyc3RhbmRpbmdzKSwg YW5kIHZlcmlmaWVkIGFnYWluIGJ5IHRoZSByZXZpZXdlciBvbiB2Mi4gVGhhdCB3b3VsZA0KPiB0 YWtlIGFuIG9yZGVyIG9mIG1hZ25pdHVkZSBtb3JlIG9mIGNvbGxlY3RpdmUgdGltZSBhbmQgZWZm b3J0Lg0KDQpBZ3JlZSB3aXRoIHRoZSBleGNlcHRpb24gSSBtZW50aW9uZWQuDQoNCj4gDQo+IE9m IGNvdXJzZSB0aGlzIGRvZXNuJ3QgYXBwbHkgdG8gYWxsIGNhc2VzLCBidXQgaXQgc2hvdWxkIGFw cGx5IHRvIHF1aXRlDQo+IGEgZmV3Lg0KPiANCj4gSW4gc2hvcnQsIGxlc3MgRW5nbGlzaCwgbW9y ZSBDICA7LSkNCg0KU2FtZSBnb2VzIGZvciB0aGluZ3MgbGlrZSDigJxwbGVhc2UgYWRkIGEgY29t bWVudOKAnSBvciDigJxwbGVhc2Ugc2F5DQpzb21ldGhpbmcgaW4gdGhlIGNvbW1pdCBtZXNzYWdl 4oCdLCBpdCB3b3VsZCBiZSBtb3N0IG9mIHRoZSB0aW1lIGVhc2llcg0KZm9yIGV2ZXJ5b25lIHRv IGRvOiBDb3VsZCB5b3UgYWRkIHRoZSBjb21tZW50IOKAnHh4eOKAnSBvbiB0b3Agb2YgdGhpcyBv cg0KdGhlIHNlbnRlbmNlIOKAnHl5eeKAnSBpbiB5b3VyIGNvbW1pdCAob3IgZXZlbiBiZXR0ZXIg YXNrIHRoZSBjb250cmlidXRvciBpZg0KaGUgaXMgb2sgd2l0aCBpdCBhbmQgZG8gaXQgb24gY29t bWl0IHdoZW4gaXQgbm90IG1vZGlmeWluZyB0aGUgY29kZSkuDQoNCkNoZWVycw0KQmVydHJhbmQN Cg0K From xen-devel-bounces@lists.xenproject.org Wed May 11 14:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326948.549616 (Exim 4.92) (envelope-from ) id 1nonDZ-0003By-Uz; Wed, 11 May 2022 14:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326948.549616; Wed, 11 May 2022 14:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonDZ-0003Br-S2; Wed, 11 May 2022 14:21:33 +0000 Received: by outflank-mailman (input) for mailman id 326948; Wed, 11 May 2022 14:21:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonDY-0003Az-PU for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:21:32 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0620.outbound.protection.outlook.com [2a01:111:f400:fe05::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7b2a1d2-d135-11ec-a406-831a346695d4; Wed, 11 May 2022 16:21:32 +0200 (CEST) Received: from DB6PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:6:2d::12) by HE1PR0801MB1739.eurprd08.prod.outlook.com (2603:10a6:3:85::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 11 May 2022 14:21:29 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::c0) by DB6PR07CA0002.outlook.office365.com (2603:10a6:6:2d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:21:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:21:27 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Wed, 11 May 2022 14:21:26 +0000 Received: from 904b2bbc35ff.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DC167DBE-5EF8-4CD8-A855-9390517EA89E.1; Wed, 11 May 2022 14:21:20 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 904b2bbc35ff.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:21:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5370.eurprd08.prod.outlook.com (2603:10a6:10:112::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 14:21:17 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:21:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7b2a1d2-d135-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OxsH5CJT2qcBSBKQTJThH93ryCjHRRZFm4rqXg/WuMFmorvz0eh/7vzD/gLyhwmIvtlg6nSWGr15W9x8WjQO7ERgw1jNo/fl0ttOCepv3Ic0vmdZeQCNqjy8G873LMbipMyrfcg5ePwbzmXo+Vd7dvziDV2bDgGCtLqw25OQVhp2BNj8YmNPQ8+oKVRRK7c0ih52ZUrhPb0blQK70O9gLYVzQejjMcYnVrCqAe/ifHX5pOvIH1Dxbek18PQiqPUfupaBuq1WPXlmaGFX2UH5hVJsotSluD883UtV5nJHcbd8kDpHoDqzf/XKb1Mu18vrAFZgDJhzIaG22lQnkuFY9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzyET3GtCmHsu562TCVlWC4N8rKlh+0rW8RuRnsTTB8=; b=E+sBmCJ7sOzLx2IT8DX1OAnn+EDsLCa0QBWODjQxxmIRqjbbZgnPws6CmYodQOZ2ssQhicW5qQd/ghcuAssoto1ebIwabV5MtDIqqIqFZcVBi6TcB0igjLZcG4zK0/8l7TQGOrfwuJrQqszTehWsS38W4ALoDv0Y2W186GZzS60SizEv41YnYcqcvfboHZP2XCssriqtGr/KGm5dpUJ1k02TlGjAF+H5+mUddmeEGn5aNDfR6c94RPWVckkRHhOqa1NB/kH2IOKtuwoGeGKiJckZ/4nDiTxGSRr504ypH9qq9HlsN3utfGj45NHFLLwZ72KmtvcTWS8hq3KVztfiGg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FzyET3GtCmHsu562TCVlWC4N8rKlh+0rW8RuRnsTTB8=; b=cWL8nk7fSLpbjYpEZ5N4MneJkaAzmjbR1TJMr/NJrkQXY2cPCDs2ZA3oMVLm9qiMtn5OlcCtt2Zx3o+sWbyG9uGEYWvkYBp/hJHAR1FG42zYuoSqtXlUChJx5GblqweCU6tHOQ98yEnZ1i+rgNucorGrX4NViQtKJ//BnrNcdVo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 2df19b6a6c9a6106 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRMbteddE0VrDqiijUKtR9YyU2Kbuw1+HCAR/xqzTyqZHaLaq7sM7hnzMZaitpF6FExXy1XRbIr+Pm+0VxXpWQuTx+abZHSSyGPel+LCqyBn9I80Ml6DgsnWXq4aSawT3B7AkTgRlfNTCLum6Zd4XMivUnUWEdp5ozYAw7cNVl1kBk9dXmj7u1tvbgZ7JtYfsiN6H1DoB56AE2Od0i4VT/2eVdBjuxdbOdDEnc45W3ryk/BhsITMALmM+Odvy27bLI/auLFW34oP7f+auPkruLkqr1mByjcvilSwnIQyVkXjoNjwYmqooy5mtv2NOK++Jsbqj3rC+dK+YPuBEUE1Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FzyET3GtCmHsu562TCVlWC4N8rKlh+0rW8RuRnsTTB8=; b=RkfHbDoj1InugFHiDcPYquITMYDYL1H/PF6K3lHY78oof+VkoY2a69XZkeC63P6gpmJGdvKq4gwbajnHpQgchH87twxPKmLqlysIkWORZNVSZG89IUl7OtvN3EZ9zFMSvaSVHrrU4mFMrKt8hTEoVVFcuycPeQsFfg02deQiraPX0qcE9YNi+HY5u23oCrVF3wqbVS3Jz1Qrrb7CdcwNJXnq0EM+SpDs5AiYoy/YopvN+IByN0DVF8E7LvLd0CPBtElwaCAmRIgI8oL9XmZPizDVvb7IDerTOoSqGaJxpNOilcCZc5RnyRjODK5Jktgryl3qZdn56BNDRQhJmomraQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FzyET3GtCmHsu562TCVlWC4N8rKlh+0rW8RuRnsTTB8=; b=cWL8nk7fSLpbjYpEZ5N4MneJkaAzmjbR1TJMr/NJrkQXY2cPCDs2ZA3oMVLm9qiMtn5OlcCtt2Zx3o+sWbyG9uGEYWvkYBp/hJHAR1FG42zYuoSqtXlUChJx5GblqweCU6tHOQ98yEnZ1i+rgNucorGrX4NViQtKJ//BnrNcdVo= From: Bertrand Marquis To: George Dunlap CC: Julien Grall , =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v3 4/6] xen: Switch to byteswap Thread-Index: AQHYZFb+rXOikPJI0E2wxRXQiKvDPK0X7v0AgAFJfgCAACKxAIAAPIwAgAAkW4A= Date: Wed, 11 May 2022 14:21:17 +0000 Message-ID: References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> In-Reply-To: <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a8a981d1-2e26-4ec9-2301-08da33598905 x-ms-traffictypediagnostic: DB8PR08MB5370:EE_|DBAEUR03FT046:EE_|HE1PR0801MB1739:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cgHIVeD30fGkhR5qzsbZvZXhougd5pV3CVMOsCdNpok+72/Qa3jZCSw51DNrXSdd8to7owIbAvs2/YuGjSXn11F+EnNbFZg3EI4HrLen2ZCX1HN2mBxFT+v8N8gtzJEfDS/g+o+v67Jqrxc1lXxmJbR/q2ITKZpC3L89Hc5LGjaSMBJQkCZ6l7v+os8i52AZMJoFnjy90e8T+tGiKL+slZnL5Eutw/j/jXqQ6Ooy6Lc4XkHY7zyfquXLTgtN9ABneNxkoo+BXxrbCBliNRerUxV5g26oE2gOyLBIU3jYu3CRg+GvXqxCSnGgQRn0FtwOyz53kJ1laqyfuMIrUKyqXujJwA0+7UcohpGXR1PdVe4n83OgRRYZf6C4TDBGzAjWMGi8JvO7DLNzLpPLwbFz11vuIF53WZddZSsuXu2VuT5chtrOAYmHY58i3AFcUNvRxA/zEPLQnjC5vKBYcdyqHTOciihMQNO8NVXMPdOF1BUnfGIBa8Tg4db/apmGbttpbxrlQcFcp8aK16choDomAJGoNW5dFbNkc9fqPMDbAEwBAPrUADfK9tPkzQ9DoXv64ZIan/sluTUxco6L0OCWLefH0ldiSKRuQ61mtd6lBLXeJGuJlr5M9pTYpo13Vv08sIgdB9lpOmA2RYDj8Z17CocAOWn8wX4TqKdjbKEsVKF4O34/YKkYWMaAap+fGBSagDlJRGAthM0gdW260Af2+zdwJKK65M4NES78+VwCMF4S35C/kADBo80QSawAiYry+RS+J4Xsl/T9M0vO+uLaITV4xF9Nmk6Kp5GUXFCbL7DfDWBhDscg4Vodt39kr6mCjG+lf6FquI3GuEgT4Quufw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(2616005)(122000001)(6512007)(38070700005)(26005)(4326008)(66446008)(36756003)(8676002)(64756008)(6916009)(186003)(66476007)(91956017)(66556008)(316002)(76116006)(54906003)(66946007)(2906002)(5660300002)(71200400001)(53546011)(508600001)(86362001)(6506007)(966005)(33656002)(6486002)(8936002)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <00E83691E1D2BC45994C83824462032F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5370 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dce079a5-bef3-40e4-e279-08da3359837b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z3LV0rJGk5ERkGH3nZ1W2aZqpKVBRjjjmDJIuGAdZ0/AL9IWnMbtKeS1WTIQvsBD6Kfg3LYCcvCcQRlhK1iA81Ab4ygvvcSgS79nN+U87nCgoj1Xi/s2xBN3zP6MHFT+ZW1C76JD1qz+hXzyJyuJoQ887InOTJm2Tm/1OBKpjWseotWkiu5YMdgZj4uAf0Bdiuzv+ZWSDV5u4E7a+Pi3W4sAHBG4qX3R+rCk5unkk0dT6AHkn6thOqplYgmJIj2CyJhEpPiokOfQlJOzxX3O0Wtvqs7jZ2Kfyclqptt7mnO/mRdzp+dI3mJAFMCgxL3DNGuTXimDnWnpQh6/I/UlzEXTujAX+lm6TPEnLJVoXTkqEnd8X46eGTrUrbGvtJwTxXXpfHJpfoUtCHw0NpQ4q15DIII3O+u8KQvmE9+vQHmE5BXrHXrPNlA5acvRXNk82sjzYTrvG4SqjE8XEkQ0A5Y45nl49PjxpHqC6kSMkHFbE1lg4RJ56p5BqfCB8vIYS3ael7t2MAHWIpF0L1h4yrwizfrITzsiGL532N9XJdQOlxMHXAMirdkzRbKllj9Oojo+lnLWz64plhpEciTLsTP3FIGHEc7Swqp6CKP6YprtrDD/bOnaoW7lmMcVhDYyWf1q9K2ZXLOSoqgsNmjlnxEe3MGCdxcX7ARHlHX+YC6aXQg3nkwfV+WZMgQLQV0wyfIiRPo0CSgNglYoyz7+vR8IMaBXSpZ4WkZgI4YVFOyaTlh2DKglzzi+uO9ApIP9kCKJ17cC60T2pCcdaQJv+g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(508600001)(5660300002)(86362001)(6506007)(6486002)(8936002)(33656002)(966005)(53546011)(2906002)(81166007)(356005)(83380400001)(6512007)(26005)(2616005)(36860700001)(40460700003)(186003)(336012)(47076005)(54906003)(70586007)(70206006)(316002)(4326008)(6862004)(36756003)(8676002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:21:27.0267 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8a981d1-2e26-4ec9-2301-08da33598905 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1739 SGkgR2VvcmdlLA0KDQo+IE9uIDExIE1heSAyMDIyLCBhdCAxMzoxMSwgR2VvcmdlIER1bmxhcCA8 Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IA0KPiANCj4+IE9uIE1heSAx MSwgMjAyMiwgYXQgOTozNCBBTSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6 DQo+PiANCj4+IEhpLA0KPj4gDQo+PiBQbGVhc2UgY29uZmlndXJlIHlvdXIgZS1tYWlsIGNsaWVu dCB0byBzZW5kIGluIHBsYWluIHRleHQuDQo+PiANCj4+IE9uIDExLzA1LzIwMjIgMDc6MzAsIExp biBMaXUg77yI5YiY5p6X77yJIHdyb3RlOg0KPj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgNC82 XSB4ZW46IFN3aXRjaCB0byBieXRlc3dhcA0KPj4+IE9uIDEwLzA1LzIwMjIgMTE6MTUsIExpbiBM aXUgd3JvdGU6DQo+Pj4+IFVwZGF0ZSB0byB1c2UgYnl0ZXN3YXAgdG8gc3dhcCBieXRlcy4NCj4+ Pj4gDQo+Pj4+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLg0KPj4+PiANCj4+Pj4gU2lnbmVkLW9mZi1i eTogTGluIExpdSA8bGluLmxpdUBjaXRyaXguY29tPg0KPj4+PiAtLS0NCj4+Pj4gQ2M6IFN0ZWZh bm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4+Pj4gQ2M6IEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+Pj4+IENjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPg0KPj4+PiBDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBj aXRyaXguY29tPg0KPj4+PiBDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+ PiBDYzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4+Pj4gQ2hhbmdlcyBpbiB2MzoNCj4+Pj4gLSBV cGRhdGUgeGVuL2NvbW1vbi9kZXZpY2VfdHJlZS5jIHRvIHVzZSBiZTMyX3RvX2NwdQ0KPj4+PiAt IEtlZXAgY29uc3QgaW4gdHlwZSBjYXN0IGluIHVuYWxpZ25lZC5oDQo+Pj4+IC0tLQ0KPj4+PiB4 ZW4vY29tbW9uL2RldmljZV90cmVlLmMgfCA0NCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0NCj4+Pj4geGVuL2NvbW1vbi9saWJlbGYvbGliZWxmLXByaXZhdGUuaCB8IDYgKystLQ0KPj4+ PiB4ZW4vY29tbW9uL3h6L3ByaXZhdGUuaCB8IDIgKy0NCj4+Pj4geGVuL2luY2x1ZGUveGVuL3Vu YWxpZ25lZC5oIHwgMjQgKysrKysrKystLS0tLS0tLQ0KPj4+PiA0IGZpbGVzIGNoYW5nZWQsIDM4 IGluc2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQ0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBh L3hlbi9jb21tb24vZGV2aWNlX3RyZWUuYyBiL3hlbi9jb21tb24vZGV2aWNlX3RyZWUuYw0KPj4+ PiBpbmRleCA0YWFlMjgxZTg5Li43MGQzYmUzYmU2IDEwMDY0NA0KPj4+PiAtLS0gYS94ZW4vY29t bW9uL2RldmljZV90cmVlLmMNCj4+Pj4gKysrIGIveGVuL2NvbW1vbi9kZXZpY2VfdHJlZS5jDQo+ Pj4+IEBAIC0xNzEsNyArMTcxLDcgQEAgYm9vbF90IGR0X3Byb3BlcnR5X3JlYWRfdTMyKGNvbnN0 IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbnAsDQo+Pj4+IGlmICggIXZhbCB8fCBsZW4gPCBzaXpl b2YoKm91dF92YWx1ZSkgKQ0KPj4+PiByZXR1cm4gMDsNCj4+Pj4gDQo+Pj4+IC0gKm91dF92YWx1 ZSA9IGJlMzJfdG9fY3B1cCh2YWwpOw0KPj4+PiArICpvdXRfdmFsdWUgPSBiZTMyX3RvX2NwdSgq dmFsKTsNCj4+Pj4gVGhpcyBjb2RlIGhhcyBiZWVuIHRha2VuIGZyb20gTGludXggYW5kIEkgd291 bGQgcmF0aGVyIHByZWZlciB0byBrZWVwDQo+Pj4+IHRoZSAqY3B1cCogaGVscGVycyB0byBhdm9p ZCBhbnkgY2hhbmdlcyB3aGVuIGJhY2twb3J0aW5nLg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2lu Y2x1ZGUveGVuL3VuYWxpZ25lZC5oIGIveGVuL2luY2x1ZGUveGVuL3VuYWxpZ25lZC5oDQo+Pj4+ IGluZGV4IDBhMmIxNmQwNWQuLjE2YjJlNmY1ZjAgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9pbmNs dWRlL3hlbi91bmFsaWduZWQuaA0KPj4+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vdW5hbGlnbmVk LmgNCj4+Pj4gQEAgLTIwLDYyICsyMCw2MiBAQA0KPj4+PiANCj4+Pj4gc3RhdGljIGlubGluZSB1 aW50MTZfdCBnZXRfdW5hbGlnbmVkX2JlMTYoY29uc3Qgdm9pZCAqcCkNCj4+Pj4gew0KPj4+PiAt IHJldHVybiBiZTE2X3RvX2NwdXAocCk7DQo+Pj4+ICsgcmV0dXJuIGJlMTZfdG9fY3B1KCooY29u c3QgdWludDE2X3QgKilwKQ0KPj4+PiBJIGhhdmVuJ3QgY2hlY2tlZCB0aGUgZXhpc3RpbmcgaW1w bGVtZW50YXRpb24gb2YgYmUxNl90b19jcHVwKCkuDQo+Pj4+IEhvd2V2ZXIsIHRoaXMgbmV3IGFw cHJvYWNoIHdvdWxkIGFsbG93IHRoZSBjb21waWxlciB0byB1c2UgYSBzaW5nbGUgbG9hZA0KPj4+ PiBpbnN0cnVjdGlvbiB0byByZWFkIHRoZSAxNi1iaXQgdmFsdWUgZnJvbSBtZW1vcnkuIFNvIHRo aXMgY2hhbmdlIG1heQ0KPj4+PiBicmVhayBvbiBwbGF0Zm9ybSB3aGVyZSB1bmFsaWduZWQgYWNj ZXNzIGlzIGZvcmJpZGRlbiAoc3VjaCBhcyBhcm0zMikuDQo+Pj4+IH0NCj4+Pj4gDQo+Pj4+IHN0 YXRpYyBpbmxpbmUgdm9pZCBwdXRfdW5hbGlnbmVkX2JlMTYodWludDE2X3QgdmFsLCB2b2lkICpw KQ0KPj4+PiB7DQo+Pj4+IC0gKihfX2ZvcmNlIF9fYmUxNiopcCA9IGNwdV90b19iZTE2KHZhbCk7 DQo+Pj4+ICsgKihfX2JlMTYgKilwID0gY3B1X3RvX2JlMTYodmFsKTsNCj4+Pj4+IFdoeSBkaWQg eW91IGRyb3AgdGhlIF9fZm9yY2U/DQo+Pj4gR29vZ2xlIHRvbGQgbWUgX19mb3JjZSBpcyB1c2Vk IGluIGxpbnV4IGtlcm5lbCB0byBzdXBwcmVzcyB3YXJuaW5nIGluIHNwYXJzZSwNCj4+PiBodHRw czovL3N0YWNrb3ZlcmZsb3cuY29tL3F1ZXN0aW9ucy81MzEyMDYxMC93aGF0LWRvZXMtdGhlLWF0 dHJpYnV0ZS1mb3JjZS1kbw0KPj4+IElzIHNwYXJzZSBhbHNvIHVzZWQgaW4geGVuPw0KPj4gDQo+ PiBJIGFtIG5vdCBhd2FyZSBvZiBhbnkgdXNlIG9mIFNwYXJzZSBpbiBYZW4sIGJ1dCBpdCB3b3Vs ZCB0ZWNobmljYWxseSBiZSBwb3NzaWJsZS4NCj4+IA0KPj4gSG93ZXZlciwgbXkgcG9pbnQgaGVy ZSBpcyBtb3JlIHRoYXQgdGhpcyBjaGFuZ2Ugc2VlbXMgdG8gYmUgdW5yZWxhdGVkIHRvIHdoYXQg dGhlIHBhdGNoIGlzIG1lYW50IHRvIGRvIChpLmUuIHN3aXRjaGluZyB0byBieXRlc3dhcCkuIFNv IGlmIGl0IGlzIHVubmVjZXNzYXJ5LCB0aGVuIGl0IHNob3VsZCBiZSBkcm9wcGVkIGZyb20gdGhp cyBwYXRjaC4NCj4gDQo+IEkgdGhpbmsgbWFraW5nIHBlb3BsZSBwdWxsIGxpdHRsZSBjaGFuZ2Vz IGxpa2UgdGhpcyBvdXQgaW50byBzZXBhcmF0ZSBwYXRjaGVzIGlzIGFza2luZyB0b28gbXVjaC4g SXTigJlzIGEgbG90IG9mIGV4dHJhIGVmZm9ydCBvbiB0aGUgcGFydCBvZiB0aGUgc3VibWl0dGVy IGZvciBiYXNpY2FsbHkgbm8gdmFsdWUuIFdlIGNvbW1vbmx5IGRvIGxpdHRsZSBjbGVhbi11cHMg bGlrZSB0aGlzIGluIHBhdGNoZXMsIGFuZCBqdXN0IHJlcXVpcmUgYSBjb21tZW50IGF0IHRoZSBi b3R0b20sIGxpa2UgdGhpczoNCj4gDQo+IDg84oCUDQo+IA0KPiBXaGlsZSBoZXJlOg0KPiAtIERy b3Ag4oCYX2ZvcmNl4oCZIGtleXdvcmQsIHdoaWNoIGlzIG9ubHkgbmVlZGVkIHdoZW4gcnVubmlu ZyB0aGUgU3BhcnNlIGFuYWx5c2lzIHRvb2wNCj4gDQo+IOKAlD44DQo+IA0KPiBJIGRvIGFncmVl IHRoYXQgbWlub3IgY2hhbmdlcyBsaWtlIHRoaXMgbmVlZCB0byBiZSBkZXNjcmliZWQsIHNvIHRo YXQgcGVvcGxlIDUgeWVhcnMgZnJvbSBub3cgaGF2ZSBzb21lIGhvcGUgb2YgZmlndXJpbmcgb3V0 IHdoYXTigJlzIGdvaW5nIG9uLg0KDQpJIGZ1bGx5IGFncmVlIGhlcmUuIFRoZSBlZmZvcnQgaW52 b2x2ZWQgYnkgc3BsaXR0aW5nIGEgcGF0Y2ggaW4gc2V2ZXJhbCBvbmVzIChib3RoIGZvciB0aGUN CmNvbnRyaWJ1dG9yIGFuZCB0aGUgbWFpbnRhaW5lcnMpIG1lYW5zIGl0IHNob3VsZCBiZSBwcmV2 ZW50ZWQgdW5sZXNzIHRoZSBvcmlnaW5hbCBwYXRjaA0KY291bGQgbm90IGJlIHJldmlld2VkIGFz IGlzIChwYXRjaCB0byBsb25nIG9yIHRvIGNvbXBsZXggdG8gdGVzdCBmb3IgZXhhbXBsZSBidXQg dGhlcmUNCm1pZ2h0IGJlIG90aGVyIHZhbGlkIGNhc2VzKS4NCk1vZGlmeWluZyB0aGUgY29tbWl0 IG1lc3NhZ2UgdG8gZGVzY3JpYmUgYWxsIGNoYW5nZXMgaXMgZGVmaW5pdGVseSBtYW5kYXRvcnkN CiB0aG91Z2ggKGJ1dCBjb3VsZCBiZSBkb25lIHdpdGhvdXQgYSB2KzEpLg0KDQpCZXJ0cmFuZA0K DQo+IA0KPiAtR2VvcmdlDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 11 14:30:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326955.549628 (Exim 4.92) (envelope-from ) id 1nonMU-0004fP-Uj; Wed, 11 May 2022 14:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326955.549628; Wed, 11 May 2022 14:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonMU-0004fI-Pc; Wed, 11 May 2022 14:30:46 +0000 Received: by outflank-mailman (input) for mailman id 326955; Wed, 11 May 2022 14:30:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonMT-0004f8-I3; Wed, 11 May 2022 14:30:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonMT-00005q-Cy; Wed, 11 May 2022 14:30:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonMT-0003RH-0i; Wed, 11 May 2022 14:30:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nonMT-00055k-0G; Wed, 11 May 2022 14:30:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mmoe3BGqJCcaRFV2zzpK7C3Wwj/aYh9KMYrz0mCQwWI=; b=kSWXRE7NQ7lK95mN+AuCiW3eQ5 mxpHxVnmInirYQRRETgHGhh3RxY+kSsF1o3HqqP5vyOwa520kyYXsM6YhBkOX72rpxeOtOazZvFZr Jy/50+hIjxyaEQHlUgPZtUh1FXzB1eeuKc6ycOWvlkZkB6OAO9kmkI75UVdJCLPOYaF4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170327: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 14:30:45 +0000 flight 170327 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170327/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 936 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 14:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326962.549639 (Exim 4.92) (envelope-from ) id 1nonN2-000574-77; Wed, 11 May 2022 14:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326962.549639; Wed, 11 May 2022 14:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonN2-00056x-3h; Wed, 11 May 2022 14:31:20 +0000 Received: by outflank-mailman (input) for mailman id 326962; Wed, 11 May 2022 14:31:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonN0-0004zb-E0 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:31:18 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0331db8f-d137-11ec-a406-831a346695d4; Wed, 11 May 2022 16:31:17 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0CED432007BE; Wed, 11 May 2022 10:31:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 11 May 2022 10:31:13 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 10:31:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0331db8f-d137-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1652279472; x=1652365872; bh=jIkiYkh7la43OEzKPZ+DpqRnBfLZndvyLge srSS+y4A=; b=sJcH1vsra32nUbcRtqLkhTwv0fSHcGpzm+cTilyKBfVKtBW7gHj w0+HryjNqfPevIdbSjrvu34BZB5m93r0zWrBBn6XqVhplMrZ+GXIegF5wdIO8rIG wibWM873FyOXEoII4efJLxYcilHrbXbzEG2TGbqbPR6JuIJGEnj60tUbxcQdRvGG ycLeNMENve98XL6EHM/sykHMqO24atJ9LKCB1wrvung5wm1duPTMkXyuTeITOPUo U9sKu2DO6qBHGI2/W2EZ0cf4hfp61QQK+8oxmFzLXcuKDWoBPXfAYtzVaE+iSnKt 9gSTkXtKGUOelqFAG3K0zcZyJUtPu/1N50A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Date: Wed, 11 May 2022 16:30:58 +0200 Message-Id: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Roger Pau Monné --- Changes in v5: - drop IRQ 0 from the log message Changes in v4: - adjust log message, change it from WARNING to INFO - re-add x86 reference in the commit message Changes in v3: - change back to checking 0xff explicitly - adjust commit message, include spec reference - change warning to match the above Changes in v2: - add log message - extend commit message - code style fix --- xen/drivers/char/ns16550.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index fb75cee4a13a..417c07cde3dc 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) pci_conf_read8(PCI_SBDF(0, b, d, f), PCI_INTERRUPT_LINE) : 0; + if ( uart->irq == 0xff ) + uart->irq = 0; + if ( !uart->irq ) + printk(XENLOG_INFO + "ns16550: %pp no legacy IRQ, using poll mode\n", + &PCI_SBDF(0, b, d, f)); + return 0; } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 14:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326963.549645 (Exim 4.92) (envelope-from ) id 1nonN2-0005F5-Oa; Wed, 11 May 2022 14:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326963.549645; Wed, 11 May 2022 14:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonN2-0005Bm-Go; Wed, 11 May 2022 14:31:20 +0000 Received: by outflank-mailman (input) for mailman id 326963; Wed, 11 May 2022 14:31:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonN1-0004zb-Aa for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:31:19 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0495c8de-d137-11ec-a406-831a346695d4; Wed, 11 May 2022 16:31:18 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 129193200368; Wed, 11 May 2022 10:31:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 11 May 2022 10:31:16 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 10:31:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0495c8de-d137-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652279475; x=1652365875; bh=5gOHCoO1SJFfX dPVixx2/Z9rK5CgcQ7j85MTwz+/pus=; b=Lf3SDq/UiiL6FYTKCRrGa8PyOc6Db e6VUVR5hVh0m+LfQf0T/IYaQLFOPcKQlJ8aw8+t9eWTEwlfcSUdcxWBTyDYDjwBT 5S24yj7CcpwX8BW59Utm4OL/vFCWU5KT25qOdALNGjMMtVyMTgSZ5dwIpycVfksa BKKLEuTctcL9eHlgCLDmi39gAulJfw2KCQOn2MMWnsU/IkpohV+hAD9q5NP5xou3 TuwMotC8vSCAPM29YtPMzTXHrxBtJRFsIbrMOrLRUo0YfBu+xEZDKwUnkAzIvP+s pIxeN6/hc+Yi2oDWen9bwqQp/a8hV2HzjMWGAuQlK6JonkJwQW0UNl5YA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v5 2/2] ns16550: Add more device IDs for Intel LPSS UART Date: Wed, 11 May 2022 16:30:59 +0200 Message-Id: <20220511143059.1826794-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is purely based on the spec: - Intel 500 Series PCH: 635218-006 - Intel 600 Series PCH: 691222-001, 648364-003 This is tested only on TGL-LP added initially, but according to the spec, they should behave the same. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper --- Changes in v2: - new patch, adding more IDs to the patch that went in already --- xen/drivers/char/ns16550.c | 80 +++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 417c07cde3dc..cb17947e002f 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1077,12 +1077,90 @@ static const struct ns16550_config __initconst uart_config[] = .dev_id = 0x0358, .param = param_exar_xr17v358 }, - /* Intel Corp. TGL-LP LPSS PCI */ + /* Intel Corp. TGL-LP LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #2 */ { .vendor_id = PCI_VENDOR_ID_INTEL, .dev_id = 0xa0c7, .param = param_intel_lpss }, + /* Intel Corp. TGL-H LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51c7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51da, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7afe, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7adc, + .param = param_intel_lpss + }, }; static int __init -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed May 11 14:32:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326975.549661 (Exim 4.92) (envelope-from ) id 1nonOI-0006SQ-2l; Wed, 11 May 2022 14:32:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326975.549661; Wed, 11 May 2022 14:32:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonOH-0006SJ-VR; Wed, 11 May 2022 14:32:37 +0000 Received: by outflank-mailman (input) for mailman id 326975; Wed, 11 May 2022 14:32:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonOG-0006S0-1M for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:32:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0c::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 322f3bc3-d137-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:32:34 +0200 (CEST) Received: from DB6PR0402CA0023.eurprd04.prod.outlook.com (2603:10a6:4:91::33) by AM8PR08MB6514.eurprd08.prod.outlook.com (2603:10a6:20b:36b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 14:32:21 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::b0) by DB6PR0402CA0023.outlook.office365.com (2603:10a6:4:91::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:32:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:32:21 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Wed, 11 May 2022 14:32:21 +0000 Received: from f7ac67b3825a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8CB356FF-6A02-4D43-8EE1-4F60662E25DF.1; Wed, 11 May 2022 14:32:14 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7ac67b3825a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:32:14 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by VI1PR08MB3024.eurprd08.prod.outlook.com (2603:10a6:803:45::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 14:32:12 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:32:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 322f3bc3-d137-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WbWI1uv/ITPu28AT9OlxO+Q6op1geG+a1BU1q2wU8AjhFwd+s7SOLd5XH9MJljZY7VSny4+yyZo61KLGOyNOUQ/vRscT+9cZZQa//XhOzCtlDhAP/Wt1XymIsCZ+YucnLm+0oTT8Bh9nN9S4NwQijcfEPKqTXLA8k4dIUc22bFMaRafon6YIi5hh1oUemN2xGGI3AglcGW7RArBorRKZ8CMCBpMghlGiZ9x+vVoQ4r8BfN1137EGMev2O8Yeuo4wxo4+g/IFhOKJGGmj68YNyOI8S9YVBD8QvmBcNXJTqRo923M6PUS0EsVWhjkuVpc+/koDcvyrOA4up/WY4F5I6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enBMQK0dPx4KY+Ea7ZkAJcVaM7PbJR8pO6XB8EeJtmo=; b=SE76akA3B0N8nxzyMBDe4/aDOyLgZ1iDeDfvI+4Aa5aB3HYc77K02atomKvzmm2oFbqzdaZoAUVerDEW9JohsFobAURvMWnqiZSKqFDPZuT4dRQfpQsltoAjRMlM7HgD4uQ/mhiGLPPQsIE0kOtdphjpDRe2THbk5XXbW2FSltYZWBScI27WXbmdbIHrq1t31zpbEnUN0/2WH7FKHi51ZMRgcbBVcK/u1zU5/srF9IU1oL2BrZTWx8c92LqNhnNwpEniJUuTnh7n/wAyMQMWwyDBfIiWafCDmrhU8gMDuN5Rg+UetFcmwiyB4M/f3t2e3U0vUJqxm4mAzf2yY4bTXQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enBMQK0dPx4KY+Ea7ZkAJcVaM7PbJR8pO6XB8EeJtmo=; b=9VTKfoeQcMPX63QprBQBBLfjL14HeQHTIgXoVk67CiN1e4ySvVCTdsH7n2huRG0I96KlDT1IFXUuTQRG3s//px5sJOQjvbS35492JofZIkzstrwFbd+7RVqVN0yf27RXW0tvTfiKtFqbNkyTBAZv3+KeTXvWk/HmuKBPfztoYzc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e302cca1c95d8f3e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1DTzPk8gZ7o5nsrod4PZw1V81CGZ+nBfbxEiHrd1qYUz0zIZmjOABzA6v+LCPfr9L/gr6mENc6pHT8WpkmJzXrPSwiL05dIJUV+5DEswHf1VnUTQnzYgko99J6D6uTtkeYntxAPNqLAvHk+VBKu9sykex0r9Q/6EQ9HXg4YjGwwq+a+Uu69D4RWBL5IWidE7nGe1d8egxD66daSeVzWDz5lnxpt/exxiIow4pZcvgc3IC+ripmKPuIxmEwkkNlq0PwVs8LU+zGd13Cq592Y53+yNNQxwd62OqOTTb3q56DpOwSAdZvzWk0Ag7ouUk3f+BYiGXUbMhAazEw8X3FCDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enBMQK0dPx4KY+Ea7ZkAJcVaM7PbJR8pO6XB8EeJtmo=; b=iAKuf31r0rOffH3zCVtV9pg2YfSiHS4DqGNtudz9RI9ekD1utYS2BvSIr4BvRAECjoOiOkR1O3mfrfznN3Ggk+mFuPZQHQgZL/kLBRPuh2cTQfJOAnbZ0Ys4stV+chEnhw0EJGabOgq4HaLClECNaEkvqn0Gxed5c0+iXGvElsFXR0VgQGsskNH/+FNnnHcHFoy1mSWKlU+6HoeLYm5W5BE8H62siUGhdhkfuxF+6CLtsJeqVraVHIgbAGs9XD3yYjMtwugSvdXc3/SmOSpZwwL149Xc7mNJPo1z0l/1U+fOEnVnBQdEH2WeAGrTL6lfczKA+jlnX2yr9haNS61YnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enBMQK0dPx4KY+Ea7ZkAJcVaM7PbJR8pO6XB8EeJtmo=; b=9VTKfoeQcMPX63QprBQBBLfjL14HeQHTIgXoVk67CiN1e4ySvVCTdsH7n2huRG0I96KlDT1IFXUuTQRG3s//px5sJOQjvbS35492JofZIkzstrwFbd+7RVqVN0yf27RXW0tvTfiKtFqbNkyTBAZv3+KeTXvWk/HmuKBPfztoYzc= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Topic: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Index: AQHYX91LOZcKc9ovCE+M72ipF+LMFK0YFGsAgAGzp4A= Date: Wed, 11 May 2022 14:32:12 +0000 Message-ID: References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b29ff9e5-18fd-4184-c1b5-08da335b0ee2 x-ms-traffictypediagnostic: VI1PR08MB3024:EE_|DBAEUR03FT057:EE_|AM8PR08MB6514:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kA0axndYz37e5byyRAvhRYrQY9AULLoJRaVjgk+LELSRYtkOrQV4rBDpqjKPiVzYi4FK+6EMpRAoiJ15LD7KHYPr0aeRDG9IKw4cIYWluX9m53EJN46JuIsiKs9ok6+RbzSAuEgYFL9z6JPOnuHOQkjN9rKJW4o1WkqhOzbI+Ued+gyIQk25E9IqmdV2yTfz6UbCelFxpGMxE0d6J9VC3MJFbYf0Z+gqKw75wbcoHcuiYL7vswf0mmwDSketAaVdg8to3PNbkNu6Enn/EGHCC8hKFjFmIu+MQxLTQ9GMonFx2OSMdPd8UHp4ADVnAQZMEbYAb6AcdB+BPbKdp15srwoRHpmHFp8whShJROOj2U9TIFRxDlBgk/DJR5KyWUSFESNI8ElhqFJiBjPNncYntE9jEdiOZjsYC9QDkydCpX8PEozRJDMlK5wileAcxXIVnDLuqgd8jA/ycJbYnR/eJPFvwlVutL4puqomqucHK0M8/4NeusR+FqW4MkdtvnFxZ37k6FlZGT1eqCln991jtTzMUy7QjoT3lk73VUwasfOmq3JqM+wH6RMgOwS5cQ/nPxJ5NIwn28WwdEo8pEQiT5Dl2XfTvCEeji5jUd2xMSCcdjS6eRSSY0WmNY740jEwySykHMS3WoIVeX9odz5RPEG1TXbyqOyQtOr/m6i1bSCmi0J0S4F7w6N1w2IroyORqEDtfmlQJOF2WM6W+i36MqOcvMC/w4dwjCVZzl48SDhJlg1uCerw3H4zZJiHBMQ0/qxSlr0xhaaz28Rgorgv3v7bPN60h3hPp0Bv/fX5BezTPD+vkt8ZSUEBX0j1sXRdFtmnZd0CDO47bg3pBcL5ng== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(6512007)(26005)(2616005)(186003)(76116006)(66556008)(66446008)(66476007)(64756008)(66946007)(8676002)(4326008)(33656002)(5660300002)(36756003)(54906003)(316002)(6916009)(2906002)(8936002)(91956017)(38100700002)(38070700005)(6486002)(508600001)(6506007)(71200400001)(86362001)(53546011)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <41362E96463BA64E84CFE7150E809966@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3024 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0015b032-d96f-4623-2126-08da335b097d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TLEUYl9q95N8Fd4rgxMLJkWfjlxmjeRZgHJhwfNq5k0IBdU/MTYfBBMRfOFe7Q/rm4Xk+1VDjP19ul08ltRzlI1705EUo7KMfjQmmEZKaaoYzWOCya4E6U63Ag5ERTI9DBeipOWiXjKFITzFAlM317dMQRrMTrz3RtLtBlLg8dL6qZZfDvFSQv/PcIuwdvjHzfFUg4Z5bFTcpaeNZxv9zBZ//qva/CARUxFKzlAF3tvQNOz3lbJtPdByXv/4tBmhgqd1SAwUjGP7Y4M3GIk+BlbGkZa5Qh5zsrwxGlARGus3vxZIcoo9/CqyuA5dWiAmIrBOYLWBxgdOqt63aIHcNVfv7hLs54ox/jDxtUYdshztcPS3ywWyUhIfU7kJ0XOrh8N9Z3JF2AV7QiYTQ8gAik0WDjGmk7BVUGDAq7b/SADayeeYo3x9DD1A0vzD/0Ow2SOcEhCeCPF3/3mfThyddjrVFZXOgkSneVPgvE8K9oS9JnHEqYKEaCIKcfR4WyU2FGY7vJ921sVQZWcw+g+g3mAa4YDihT7cx9dIIa9isJM6jwhTI6vO3eB3izl2dAWXmcmqNPk3DzEfN8wpZmiIqPdJey7q7V8tQBu5gz0cT7NxC+Q9us01rqQAB1P5zbwglb1laqBBNuy4qnztAMuEpShcgX9IcO3mjzMYTTepwIDKT1n/a/utAYkymWdK0KNLHDzshTWYeurmZM6q8SwngVDYrIIzH0sY14X4o6b+s2sQO7PP/WCURTyE6ZzGKMuzKnyfCS9LUHXEFC36C26xuA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(508600001)(6512007)(26005)(70586007)(316002)(70206006)(6486002)(47076005)(2906002)(81166007)(40460700003)(36860700001)(186003)(6862004)(4326008)(54906003)(8676002)(336012)(356005)(82310400005)(33656002)(86362001)(2616005)(6506007)(83380400001)(8936002)(5660300002)(53546011)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:32:21.1128 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b29ff9e5-18fd-4184-c1b5-08da335b0ee2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6514 SGkgSnVsaWVuDQoNCj4gT24gMTAgTWF5IDIwMjIsIGF0IDE6MzIgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgUmFodWwsDQo+IA0KPiBPbiAwNC8wNS8y MDIyIDE4OjM0LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBh IG5ldyBmZWF0dXJlIHRvIHN1cHBvcnQgdGhlIHNpZ25hbGluZyBiZXR3ZWVuDQo+PiB0d28gZG9t YWlucyBpbiBkb20wbGVzcyBzeXN0ZW0uDQo+PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8 cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gdjIgY2hhbmdlczoNCj4+IC0gc3dpdGNo IHRvIHRoZSBvbmUtc3Vibm9kZS1wZXItZXZ0Y2huIHVuZGVyIHhlbixkb21haW4iIGNvbXBhdGli bGUgbm9kZS4NCj4+IC0gQWRkIG1vcmUgZGV0YWlsIGFib3V0IGV2ZW50LWNoYW5uZWwNCj4+IC0t LQ0KPj4gZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZCB8IDEyNiArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKw0KPiANCj4gQW5zd2VyaW5nIGhlcmUgdG8gYWxzbyBrZWVwIHRo ZSBoaXN0b3J5LiBPbiBJUkMsIEJlcnRyYW5kIHdhcyBhc2tpbmcgd2hldGhlciB3ZSBtZXJnZSBk ZXNpZ24gcHJvcG9zYWwuDQo+IA0KPiBXZSBoYXZlIG1lcmdlZCBwcm9wb3NhbCBpbiB0aGUgcGFz dCAoZS5nLiBub24tY29vcGVyYXRpdmUgbWlncmF0aW9uKSBhbmQgSSB3b3VsZCBiZSByZWFkeSB0 byBkbyBpdCBhZ2FpbiBhcyBpdCBpcyBlYXNpZXIgdG8gZmluZCB0aGVtIGFmdGVyd2FyZHMuDQo+ IA0KPiBIb3dldmVyLCBJIHdvbmRlciB3aGV0aGVyIGl0IHdvdWxkIGJlIGJldHRlciB0byB0dXJu IHRoaXMgcHJvcG9zYWwgdG8gYSBiaW5kaW5nIGNoYW5nZSBpbiBtaXNjL2FybS9kZXZpY2UtdHJl ZS8uIEFueSB0aG91Z2h0cz8NCg0KSSBhbSBva2F5IHdpdGggdGhhdC4gSSB0aGluayBhcmUgeW91 IHJlZmVycmluZyB0byAiZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS8g4oCcIA0KPiANCj4+IDEg ZmlsZSBjaGFuZ2VkLCAxMjYgaW5zZXJ0aW9ucygrKQ0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0IGRv Y3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4ubWQNCj4+IGRpZmYgLS1naXQgYS9kb2NzL2Rlc2ln bnMvZG9tMGxlc3MtZXZ0Y2huLm1kIGIvZG9jcy9kZXNpZ25zL2RvbTBsZXNzLWV2dGNobi5tZA0K Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4+IGluZGV4IDAwMDAwMDAwMDAuLjYyZWM4YTQwMDkN Cj4+IC0tLSAvZGV2L251bGwNCj4+ICsrKyBiL2RvY3MvZGVzaWducy9kb20wbGVzcy1ldnRjaG4u bWQNCj4+IEBAIC0wLDAgKzEsMTI2IEBADQo+PiArIyBTaWduYWxpbmcgc3VwcG9ydCBiZXR3ZWVu IHR3byBkb21VcyBvbiBkb20wbGVzcyBzeXN0ZW0NCj4+ICsNCj4+ICsjIyBDdXJyZW50IHN0YXRl OuKAr0RyYWZ0IHZlcnNpb24NCj4+ICsNCj4+ICsjIyBQcm9wb3NlcihzKTogUmFodWwgU2luZ2gs IEJlcnRyYW5kIE1hcnF1aXMNCj4+ICsNCj4+ICsjIyBQcm9ibGVtIFN0YXRlbWVudDoNCj4+ICsN Cj4+ICtEb20wbGVzcyBndWVzdHMgd291bGQgYmVuZWZpdCBmcm9tIGEgc3RhdGljYWxseS1kZWZp bmVkIG1lbW9yeSBzaGFyaW5nIGFuZA0KPj4gK3NpZ25hbGx5IHN5c3RlbSBmb3IgY29tbXVuaWNh dGlvbi4gT25lIHRoYXQgd291bGQgYmUgaW1tZWRpYXRlbHkgYXZhaWxhYmxlIGF0DQo+PiArYm9v dCB3aXRob3V0IGFueSBuZWVkIGZvciBkeW5hbWljIGNvbmZpZ3VyYXRpb25zLg0KPj4gKw0KPj4g K0luIGVtYmVkZGVkIGEgZ3JlYXQgdmFyaWV0eSBvZiBndWVzdCBvcGVyYXRpbmcgc3lzdGVtIGtl cm5lbHMgZXhpc3QsIG1hbnkgb2YNCj4+ICt3aGljaCBkb24ndCBoYXZlIHN1cHBvcnQgZm9yIHhl bnN0b3JlLCBncmFudCB0YWJsZSwgb3Igb3RoZXIgY29tcGxleCBkcml2ZXJzLg0KPiANCj4gSSBh bSBub3Qgc3VyZSBJIHdvdWxkIGNvbnNpZGVyIGV2ZW50IGNoYW5uZWwgRklGTyBhICJ0cml2YWwi IGRyaXZlcnMgOikuDQo+IA0KPj4gK1NvbWUgb2YgdGhlbSBhcmUgc21hbGwga2VybmVsLXNwYWNl IGFwcGxpY2F0aW9ucyAob2Z0ZW4gY2FsbGVkICJiYXJlbWV0YWwiLA0KPj4gK25vdCB0byBiZSBj b25mdXNlZCB3aXRoIHRoZSB0ZXJtICJiYXJlbWV0YWwiIHVzZWQgaW4gdGhlIGRhdGEgY2VudGVy IHdoaWNoDQo+PiArbWVhbnMgIndpdGhvdXQgaHlwZXJ2aXNvcnMiKSBvciBSVE9TZXMuIEFkZGl0 aW9uYWxseSwgZm9yIHNhZmV0eSByZWFzb25zLCB1c2Vycw0KPj4gK29mdGVuIG5lZWQgdG8gYmUg YWJsZSB0byBjb25maWd1cmUgdGhlIGZ1bGwgc3lzdGVtIHN0YXRpY2FsbHkgc28gdGhhdCBpdCBj YW4NCj4+ICtiZSB2ZXJpZmllZCBzdGF0aWNhbGx5Lg0KPj4gKw0KPj4gK0V2ZW50IGNoYW5uZWxz IGFyZSB2ZXJ5IHNpbXBsZSBhbmQgY2FuIGJlIGFkZGVkIGV2ZW4gdG8gYmFyZW1ldGFsIGFwcGxp Y2F0aW9ucy4NCj4+ICtUaGlzIHByb3Bvc2FsIGludHJvZHVjZXMgYSB3YXkgdG8gZGVmaW5lIHRo ZW0gc3RhdGljYWxseSB0byBtYWtlIHRoZW0gc3VpdGFibGUNCj4+ICtmb3IgZG9tMGxlc3MgZW1i ZWRkZWQgZGVwbG95bWVudHMuDQo+PiArDQo+PiArIyMgUHJvcG9zYWw6DQo+PiArDQo+PiArRXZl bnQgY2hhbm5lbHMgYXJlIHRoZSBiYXNpYyBwcmltaXRpdmUgcHJvdmlkZWQgYnkgWGVuIGZvciBl dmVudCBub3RpZmljYXRpb25zLg0KPj4gK0FuIGV2ZW50IGNoYW5uZWwgaXMgYSBsb2dpY2FsIGNv bm5lY3Rpb24gYmV0d2VlbiAyIGRvbWFpbnMgKG1vcmUgc3BlY2lmaWNhbGx5DQo+PiArYmV0d2Vl biBkb20xLHBvcnQxLCBhbmQgZG9tMixwb3J0MikuIEVhY2ggZXZlbnQgaGFzIGEgcGVuZGluZyBh bmQgYSBtYXNrZWQgYml0Lg0KPj4gK1RoZSBwZW5kaW5nIGJpdCBpbmRpY2F0ZXMgdGhlIGV2ZW50 IGhhcyBiZWVuIHJhaXNlZC4gVGhlIG1hc2tlZCBiaXQgaXMgdXNlZCBieQ0KPj4gK3RoZSBkb21h aW4gdG8gcHJldmVudCB0aGUgZGVsaXZlcnkgb2YgdGhhdCBzcGVjaWZpYyBldmVudC4gWGVuIG9u bHkgcGVyZm9ybXMgYQ0KPj4gKzAg4oaSIDEgdHJhbnNpdGlvbiBvbiB0aGUgcGVuZGluZyBiaXRz IGFuZCBkb2VzIG5vdCB0b3VjaCB0aGUgbWFzayBiaXQuIFRoZQ0KPiANCj4gTklUOiBJIHRoaW5r IOKGkiBpcyBub3QgYW4gYXNjaWkgY2hhcmFjdGVyLiBDYW4geW91IHVzZSAiLT7igJ0/DQpBY2su IA0KPiANCj4+ICtkb21haW4gbWF5IHRvZ2dsZSBtYXNrZWQgYml0cyBpbiB0aGUgbWFza2VkIGJp dCBmaWVsZCBhbmQgc2hvdWxkIGNsZWFyIHRoZQ0KPj4gK3BlbmRpbmcgYml0IHdoZW4gYW4gZXZl bnQgaGFzIGJlZW4gcHJvY2Vzc2VkDQo+PiArDQo+PiArRXZlbnRzIGFyZSByZWNlaXZlZCBieSBh IGRvbWFpbiB2aWEgYW4gaW50ZXJydXB0IGZyb20gWGVuIHRvIHRoZSBkb21haW4sDQo+PiAraW5k aWNhdGluZyB3aGVuIGFuIGV2ZW50IGFycml2ZXMgKHNldHRpbmcgdGhlIGJpdCkuIEZ1cnRoZXIg bm90aWZpY2F0aW9ucyBhcmUNCj4+ICtibG9ja2VkIHVudGlsIHRoZSBiaXQgaXMgY2xlYXJlZCBh Z2Fpbi4gRXZlbnRzIGFyZSBkZWxpdmVyZWQgYXN5bmNocm9ub3VzbHkgdG8NCj4+ICthIGRvbWFp biBhbmQgYXJlIGVucXVldWVkIHdoZW4gdGhlIGRvbWFpbiBpcyBub3QgcnVubmluZy4NCj4+ICtN b3JlIGluZm9ybWF0aW9uIGFib3V0IEZJRk8gYmFzZWQgZXZlbnQgY2hhbm5lbCBjYW4gYmUgZm91 bmQgYXQ6DQo+IA0KPiBJIHRoaW5rIHRoZSBleHBsYW5hdGlvbiBpcyBmaW5lIGZvciBhIGRlc2ln biBwcm9wb3NhbC4gSWYgeW91IHdhbnQgdG8gdXNlIGl0IGFzIGRvY3VtZW50YXRpb24sIHRoZW4g SSB3b3VsZCBzdWdnZXN0IHRvIGNsYXJpZnkgdGhlcmUgYXJlIHR3byBkaWZmZXJlbnQgQUJJIGZv ciBldmVudCBjaGFubmVsOiBGSUZPIGFuZCAyTC4NCj4gDQo+IDJMIGlzIHRoZSBlYXNpZXN0IG9u ZSB0byBpbXBsZW1lbnQgYW5kIGZvciBlbWJlZGRlZCB3ZSBtYXkgd2FudCB0byBzdGVlciB0aGUg dXNlcnMgdG93YXJkcyBpdC4NCg0KSSB3aWxsIHJlcGhyYXNlIHRoZSBzZW50ZW5jZSBhcyBiZWxv dzoNCg0KWGVuIHN1cHBvcnRzIHR3byBkaWZmZXJlbnQgQUJJIGZvciBldmVudCBjaGFubmVsIEZJ Rk8gYW5kIDJMLiBNb3JlIGluZm9ybWF0aW9uIGFib3V0IEZJRk8gYmFzZWQgZXZlbnQgY2hhbm5l bCBjYW4gYmUgZm91bmQgYXQ6DQoNCj4gDQo+PiAraHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvcGVv cGxlL2R2cmFiZWwvZXZlbnQtY2hhbm5lbHMtSC5wZGYNCj4gDQo+IEl0IGlzIHF1aXRlIHVuZm9y dHVuYXRlIHRoYXQgdGhpcyB3YXNuJ3QgbWVyZ2VkIGluIGRvY3MvLiBPaCB3ZWxsLCBubyBhY3Rp b24gZm9yIHlvdSBoZXJlLg0KPiANCj4+ICsNCj4+ICtUaGUgZXZlbnQgY2hhbm5lbCBjb21tdW5p Y2F0aW9uIHdpbGwgYmUgZXN0YWJsaXNoZWQgc3RhdGljYWxseSBiZXR3ZWVuIHR3bw0KPj4gK2Rv bWFpbnMgKGRvbTAgYW5kIGRvbVUgYWxzbykgYmVmb3JlIHVucGF1c2luZyB0aGUgZG9tYWlucyBh ZnRlciBkb21haW4gY3JlYXRpb24uDQo+PiArRXZlbnQgY2hhbm5lbCBjb25uZWN0aW9uIGluZm9y bWF0aW9uIGJldHdlZW4gZG9tYWlucyB3aWxsIGJlIHBhc3NlZCB0byBYRU4gdmlhDQo+IA0KPiBO SVQ6IGFib3ZlIHlvdSBhcmUgdXNpbmcgIlhlbiIuIFNvIHMvWEVOL1hlbi8gZm9yIGNvbnNpc3Rl bmN5Lg0KDQpBY2suIA0KPiANCj4+ICt0aGUgZGV2aWNlIHRyZWUgbm9kZS4gVGhlIGV2ZW50IGNo YW5uZWwgd2lsbCBiZSBjcmVhdGVkIGFuZCBlc3RhYmxpc2hlZA0KPj4gK2JlZm9yZWhhbmQgaW4g WEVOIGJlZm9yZSB0aGUgZG9tYWluIHN0YXJ0ZWQuIFRoZSBkb21haW4gZG9lc27igJl0IG5lZWQg dG8gZG8gYW55DQo+IA0KPiBTYW1lIGhlcmUuDQo+IA0KPiBOSVQ6IEkgdGhpbmsgImJlZm9yZWhh bmQiIGFuZCAiYmVmb3JlIiBpcyByZWR1bmRhbnQuDQoNCkFjay4gDQo+IA0KPj4gK29wZXJhdGlv biB0byBlc3RhYmxpc2ggYSBjb25uZWN0aW9uLiBEb21haW4gb25seSBuZWVkcyBoeXBlcmNhbGwN Cj4+ICtFVlRDSE5PUF9zZW5kKGxvY2FsIHBvcnQpIHRvIHNlbmQgbm90aWZpY2F0aW9ucyB0byB0 aGUgcmVtb3RlIGd1ZXN0Lg0KPj4gKw0KPj4gK1RoZXJlIGlzIG5vIG5lZWQgdG8gZGVzY3JpYmUg dGhlIHN0YXRpYyBldmVudCBjaGFubmVsIGluZm8gaW4gdGhlIGRvbVUgZGV2aWNlDQo+PiArdHJl ZS4gU3RhdGljIGV2ZW50IGNoYW5uZWxzIGFyZSBvbmx5IHVzZWZ1bCBpbiBmdWxseSBzdGF0aWMg Y29uZmlndXJhdGlvbnMsDQo+PiArYW5kIGluIHRob3NlIGNvbmZpZ3VyYXRpb25zIHRoZSBkb21V IGRldmljZSB0cmVlIGR5bmFtaWNhbGx5IGdlbmVyYXRlZCBieSBYZW4NCj4+ICtpcyBub3QgbmVl ZGVkLg0KPj4gKw0KPj4gK1VuZGVyIHRoZSAieGVuLGRvbWFpbiIgY29tcGF0aWJsZSBub2RlLCB0 aGVyZSBuZWVkIHRvIGJlIHN1Yi1ub2RlcyB3aXRoDQo+PiArY29tcGF0aWJsZSAieGVuLGV2dGNo biIgdGhhdCBkZXNjcmliZSB0aGUgZXZlbnQgY2hhbm5lbCBjb25uZWN0aW9uIGJldHdlZW4gdHdv DQo+PiArZG9tYWlucyhkb20wIGFuZCBkb21VIGFsc28pLg0KPiANCj4gQmVsb3cgeW91IHByb3Zp ZGVkIGFuIGV4YW1wbGUgYmV0d2VlbiB0d28gZG9tVXMuIENhbiB5b3UgcHJvdmlkZSBvbmUgYmV0 d2VlbiBkb20wIGFuZCBhIGRvbVU/DQpZZXMgSSB3aWxsIHByb3ZpZGUgYW4gZXhhbXBsZSBiL3cg ZG9tMCBhbmQgZG9tVSBpbiBuZXh0IHZlcnNpb24uDQo+IA0KPj4gKw0KPj4gK1RoZSBldmVudCBj aGFubmVsIHN1Yi1ub2RlIGhhcyB0aGUgZm9sbG93aW5nIHByb3BlcnRpZXM6DQo+PiArDQo+PiAr LSBjb21wYXRpYmxlDQo+PiArDQo+PiArICJ4ZW4sZXZ0Y2huIg0KPj4gKw0KPj4gKy0geGVuLGV2 dGNobg0KPj4gKw0KPj4gKyBUaGUgcHJvcGVydHkgaXMgdHVwbGVzIG9mIHR3byBudW1iZXJzDQo+ PiArIChsb2NhbC1ldnRjaG4gbGluay10by1mb3JlaWduLWV2dGNobikgd2hlcmU6DQo+PiArDQo+ PiArIGxvY2FsLWV2dGNobiBpcyBhbiBpbnRlZ2VyIHZhbHVlIHRoYXQgd2lsbCBiZSB1c2VkIHRv IGFsbG9jYXRlIGxvY2FsIHBvcnQNCj4+ICsgZm9yIGEgZG9tYWluIHRvIHNlbmQgYW5kIHJlY2Vp dmUgZXZlbnQgbm90aWZpY2F0aW9ucyB0by9mcm9tIHRoZSByZW1vdGUNCj4+ICsgZG9tYWluLg0K PiBQb3J0IDAgaXMgcmVzZXJ2ZWQgYW5kIGJvdGggRklGTy8yTCBoYXZlIGxpbWl0IG9uIHRoZSBw b3J0IG51bWJlcnMuDQo+IA0KPiBJIHRoaW5rIHdlIHNob3VsZCBsZXQga25vdyB0aGUgdXNlcnMg YWJvdXQgdGhvc2UgbGltaXRhdGlvbnMgYnV0IEkgYW0gbm90IHN1cmUgd2hldGhlciB0aGUgYmlu ZGluZyBpcyB0aGUgcmlnaHQgcGxhY2UgZm9yIHRoYXQuDQoNCklmIHlvdSBhcmUgb2theSBJIGNh biBhZGQgdGhpcyBsaW1pdGF0aW9uIGluIHRoaXMgZGVzaWduIGRvYy4NCg0KPj4gKw0KPj4gKyBs aW5rLXRvLWZvcmVpZ24tZXZ0Y2huIGlzIGEgc2luZ2xlIHBoYW5kbGUgdG8gYSByZW1vdGUgZXZ0 Y2huIHRvIHdoaWNoDQo+PiArIGxvY2FsLWV2dGNobiB3aWxsIGJlIGNvbm5lY3RlZC4NCj4gDQo+ IEkgd291bGQgY29uc2lkZXIgdG8gcmVsYXggdGhlIHdvcmRpbmcgc28gYSB1c2VyIGNhbiBjcmVh dGUgYW4gZXZlbnQgY2hhbm5lbCB3aXRoIHRoZSBib3RoIGVuZCBpbiB0aGUgc2FtZSBkb21haW4u DQo+IA0KPiBJbXBsZW1lbnRhdGlvbiB3aXNlLCBpdCBzaG91bGQgbWFrZSBubyBkaWZmZXJlbmNl IGFzIHlvdSBzdGlsbCBuZWVkIHRvIGxvb2t1cCB0aGUgZG9tYWluLg0KDQpJIHdpbGwgcmVwaHJh c2UgYXM6DQpsaW5rLXRvLWZvcmVpZ24tZXZ0Y2huIGlzIGEgc2luZ2xlIHBoYW5kbGUgdG8gYSBm b3JlaWduIGV2dGNobiB0byB3aGljaA0KICAgICAgIGxvY2FsLWV2dGNobiB3aWxsIGJlIGNvbm5l Y3RlZC4NCg0KDQpSZWdhcmRzLA0KUmFodWwNCg0K From xen-devel-bounces@lists.xenproject.org Wed May 11 14:35:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326983.549671 (Exim 4.92) (envelope-from ) id 1nonQp-000799-Ho; Wed, 11 May 2022 14:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326983.549671; Wed, 11 May 2022 14:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonQp-000792-F0; Wed, 11 May 2022 14:35:15 +0000 Received: by outflank-mailman (input) for mailman id 326983; Wed, 11 May 2022 14:35:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonQn-00078s-TL for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:35:14 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8fedbcfc-d137-11ec-a406-831a346695d4; Wed, 11 May 2022 16:35:12 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 10:35:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5762.namprd03.prod.outlook.com (2603:10b6:303:90::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 14:35:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:35:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fedbcfc-d137-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652279712; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=rJdxi7CrMvEhLOBOVcaSvEGwAoBAWypsoYAVt6Q+ipk=; b=AxTt8mLW1LSJJMYbBLInfNdBJj5Gh4YwShThH/I0SFgM6r80fXIj+Uzl FeskSPxt1VWltM/3N+3+oo/agzkaWZX6S0AMGhqWwN/8z7qFgIg+NxVPw yc71tiHxsoSc0cwHlmEQt4YPyGceGznJz1i6by3R2aAsRVc7gGfTTQc7I E=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 70946513 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:R1h7lKg7W9/wjMmkTQ1zyaADX161WhEKZh0ujC45NGQN5FlHY01je htvCmDUbKvYMWrwf9BxPY61o08BvcTSzdJmT1Q5qig0Fygb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrU4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YRkEAPPWlesRaQsbHjpaH7RG0bziB0Hq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWlh7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJouzmPklEoi9ABNvLZY9ikFdQOmH+pp 1zc8WOmWg0jOt+mnG/tHnWEw7WncTnAcIcbDrix7PNpqFyV2G0ICRcSWEe7oP+2kUq3UZRUL El80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/ l2Um9LkAxR/vbvTTmiSnp+Pti+7MyURKW4EZAcHQBED7t2lp5s85jrQSv5zHajzicf6cQwc2 BiPpSk6wr8V3cgC0vzi+Uid2mz94J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1WdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:De8HjKF3ysnM5DUXpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M= X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70946513" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oe1WjfQEyADumebeHtuUidJRUAQcJPLxPDkQai7OnqxVY/dKCcugOtayqIP6a25XDK3prL6M77PXr0l8+XRWbT6TOIM2jTkxKfAuAdQOSGu7/rAgUvDWhSMR1BONIh4gAuX0IPB25B5uL+dDpTTS+l0y79afXML3vzNFCfrxLcIvY+1IVzLC/ERvju6IZtCvKUQg/+AFB76yGkRfL21CBPmk/JP9BtpXix0Y7UHQAler+kUUNLe2R26NQsIOTqGVP1a01jrsrEt3vT+ddl8qVJOb0W3+SVft2HgaHKXYF+dfl4m/Q8qn7ww1fBsOC63HpL510ud3AQOBdrlANfVIZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJdxi7CrMvEhLOBOVcaSvEGwAoBAWypsoYAVt6Q+ipk=; b=B9Jf6xvwcjL8ub3SUnqyxQ3YBv3vfv9N4N+uXFZJNMt6ySAUAuG4gNe6QNhQdACgrKAXS3UtLfVuuDS00y2ELBiILQLEzrGG4DY81xJQOrHBUzhXzr31iut4sOu5gKmSx2H2DEI+3h04WUPBkEc7Gqj4PVC4WE9WOaYunNPAapr6qZ5VhyNHloQOpSjL9iaYGRtlAYQFYjR0aTZXH2OvnXAfvz3YLqARz6Y9T4lJToD7bPPjgHk3TJVef6BXcWSicnzV1lhM3f44Gff8GWJ7zWaP/8wY3xMP2XoLhN0uORY54cZcCrj8g6dwM0ClCmHUIvx+/Sidgm/O/h5KLXtWNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rJdxi7CrMvEhLOBOVcaSvEGwAoBAWypsoYAVt6Q+ipk=; b=rw1T+hcRJaGWTYp0PsB1M4gAKVJY/hjXA0CQJ6FR84HR1s439Y78PFMPwdG3k8c8MUIGVS0MGBz+5VwZB8ijCNcgGO31m8yAxYlBlH9rgu19N17zB0hzYFAd9MRDxWesLq9Q/54duh21jjE/0S71PiYGDC50OvGvNe5Ayky1bfY= From: Andrew Cooper To: Roger Pau Monne , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= CC: "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Thread-Topic: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Thread-Index: AQHYZT9h/psFFcQ9ZUSTli2D9MFhrq0ZuLuAgAAFYoA= Date: Wed, 11 May 2022 14:35:05 +0000 Message-ID: <9e087a55-8384-b25a-fb94-1ef421c7fcdf@citrix.com> References: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53d35e0d-eabb-484b-a9ae-08da335b70dd x-ms-traffictypediagnostic: CO1PR03MB5762:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0CpGsSDab/gvo38dNVwt1sewurDHSQAju0/ber8V+ecg4gTOvqma9qMUEECW109iItYMhAHhVzLGwqf3odpgNmWjVhxVlk2j+a8UXoVoNLQi1obZJSI6zRVBXb1le69DtLYcSuUAKHxpvUF7jt8u7nrwN6USsUdFWsDevw7duZSKxd0tDApBfa50YEVve0FC/WcBfaiTsm4x/qdI5UetVPUMPolAi5P3OtFhPDUjD+RsK30EwrgjtrgS24NCigeXLLhXvLcCPs2E6tSUzzSjZDBO8ATu5ceddzlWkj/+S+Ietkdp23SzbL9cEsm283aOB3IMhjxqxnK0R/My50+t6Zz85HecVaks5GvbQLnexuuGXrOTexAMGlaEvVrLWE/mNRSj0cMQDq/ALmpyii4izp0Adh3Axv3OcnIQ8tOqfwuxWnWN5ZdHZ3vkz0JOPpo0DfQ9ErqJrnTeUZeZE56Eq9tQpbgCDXZd8qxbA7Rfy7Z/RnOyFVVjqzEaHiszP6VjIkRGAHNDYM9mLs8Pg8lHlqmqGBnMeGbsOAze0OIWfIser01i5in7rCwlt3SRU0IlbrNLIPizXzYy/VcLTlC3XwUPLTz4T6KSXr4qN5rAlA6eHk+TnzCJtbJ84xPLdB57rjIyHv5TN2vEUDl36607TTArjodLxOJVigsP0QOn+GFNFBJGbeFX7DlyjZkjQ1EU2N43aEgpqcxP17tXd00bPwx0isCgtHNw8ovqyxPakyAAh01qxbW2NhA8ReD8qORdD1UMjPX1rhEizFyhB60J4g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(186003)(66574015)(38100700002)(110136005)(6506007)(53546011)(6486002)(508600001)(86362001)(31696002)(71200400001)(91956017)(54906003)(4326008)(8936002)(2616005)(66556008)(76116006)(66946007)(8676002)(66476007)(316002)(6512007)(64756008)(66446008)(26005)(31686004)(36756003)(82960400001)(83380400001)(122000001)(5660300002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZC90dElkMG1PeEdNWjVlTmhyZXlNQi9PekdwdFZnYTZlL2g4ZE9GVGI2NzdL?= =?utf-8?B?VnpOdXNjRTVSSGRDY2tCL2QvZUVncHE4S1dmU3g0alFlQW5PVzRKempTN3Bx?= =?utf-8?B?TWlBY3RYY21mbjdUUEhTWTJFdGtnWWVjZkMrVEJqb3V0S2M0eWFhV0YvOXNX?= =?utf-8?B?eFhmeExUV21zRytOcmFWR3ZFcFhoYTZMUU85Y01lcHMxNG1HVmxxQmhScEJk?= =?utf-8?B?c242N1RpRFM5Ti9GeDlzZC9FQmtUS08xVko3YzZIVEpvZnQwa1hqd2dWSnk3?= =?utf-8?B?T0EwVDNQUHBSTloxZDNRTVlpSGlRR0RlSGsreWdSUko4aXhnNW1wbkhScjVR?= =?utf-8?B?K000TjFxSXpnV3FEZzMwNENKSGJQQndwdCs4MG9lRHFKZHU1ZVZSTGdOV2Fp?= =?utf-8?B?aWlqUnlidGJEV3JXVWpzUjBjMXpYM2JjSTBEQ2tIcEc3QXBhQkU1VUxacnhn?= =?utf-8?B?QTI1N0FQU214ZGViVUYyVW85eEcrd2d1NW40UjJpTFYvckU4aHlpSGU5d2xk?= =?utf-8?B?eEk5UDdOY1FoRFF5RVV2b3JFeGJibDNhdU5GTyt4cVFORDFTamExZTZ3QmdY?= =?utf-8?B?b29FcldTOFhoUGxld3VqSGgxN3RWSmIxeDVLUjVHTkR6K2o4TG81N0ZQZVdC?= =?utf-8?B?N0FzY3poTW5MbDd3NXdCVEE1azRHR0E3b3M3bjNLUFowVzFkWDRHcDZLWWND?= =?utf-8?B?RlNPeXNTMDV6SC9HenJOZ3NGTUlZRUluc1RpaXBmUTdDazJnY1VTYVF4ZUFl?= =?utf-8?B?bVZSOWNQYmxGdUZFakxTNE5xUFgwdm5FOHhBUVJWQ3oyaEtTQURkZWwxRGEw?= =?utf-8?B?SWpEUThqWC9PWXU0dXJIWjBJR3ptNC9VNlFuTWdEeGcrYzBtQXpYd3AyWVpX?= =?utf-8?B?NCtYdUN6Y3BqNkJvZDRNVWdmV0RoV3ZPUjI2TGgvK3NObFk3eWJ2bFBIN0RL?= =?utf-8?B?bkU3TDBrQzZDdnhtK1k4S3plNmVWeEFmMjBIZUFsT3ZYMlI0NmpGZDJKaWto?= =?utf-8?B?bUliTWNUMUxLVmY3VTlwQWo2QnhVbGJjWnZ4aSsveWRzUlEzQUMrQkRQcy9z?= =?utf-8?B?Z25iejUvL2NXUUptemZtZW1xaGZ2Qk5QOU82MEx0YjRwMXFzdVhqZDZsWUZG?= =?utf-8?B?d29YMnlYdkdOU0djajEzalVPYWp1b3dVU2paK1JLLzFGNDhYWjhzYUVDTUh5?= =?utf-8?B?ZEh2Qi9vM2JDTFdOWGlXL2I3Z2FTaFJhbU43K2pDOGZybjFqaW5kOFZRRTQ0?= =?utf-8?B?WndtcVBIV2dmU0xoYWt4YnFWS0tlU1VyNXhrYXhUYWxwTFZnUlA2OW42bUx4?= =?utf-8?B?MGtYclhydHFRbGtkRWhQTzkwaTRYdUI4bHordHJ6NFk1bm83LzBJRzlpbVVr?= =?utf-8?B?a3JoQmIycUpDL3Q5U01CTzRvLzc0WE8zSkR5Y3gra1FFcmtldThRaHZxUC9J?= =?utf-8?B?empqK2RGSEEzWjNJNm9kYlJNUlRzenB4ZWQ2ZHE3eHBhQWkwbFlDbG5WdW03?= =?utf-8?B?Uk9qNDhoMXlsbDl3a1VxK1RsOVZOTkJqYWpFRHNBdUlpd25hNkprWVZwcjFz?= =?utf-8?B?UytWMHN4VnVKYy9HLzRrTnhoeVk1ZkNIU084UGdsM1Q3NHlMK2loWnA4OG9n?= =?utf-8?B?UFZHc3BYUWNJamo0dEZWT1BsdVArd0JMSEhXaXMwRUh4ZzZiYklBQjQxdTFR?= =?utf-8?B?azNvZEtqbUloc1hMWFhDdUxWSmtqMERWeSs0Mjd0V2duYXJhVU5mN1h0NEJv?= =?utf-8?B?NDJrd0VYSDVTQ0dUQjF6M1lkVzhLZjNSZkFWbE53dm1iVlVNby84RXBRV05x?= =?utf-8?B?b3prVHVHaU8yUlNFN1d1bXkyZGNPdDh0RTF3dmp2Yk15cldqdld1c3dzN0xm?= =?utf-8?B?TEE5ZlhMRE1EZG5RdnFZeUJyT1ZObzlYSjhKRDFqMjNmYzJGeGRyaDI2K1pK?= =?utf-8?B?c1lqakgwTTc1c3hGWngwc2d5VXpDVmhxUnRRVk1xUkJ5Z09ERDZISjhESVFw?= =?utf-8?B?bk1YZzBzYnAyWG1Kc1dQQUpmQkpPSFNPZlBDTTFCZmVhNWlUb292U3dkd3hq?= =?utf-8?B?RTQ3Wmg0WC9iOGx6MmxSU2N4bWFSelhVTzJhMFZDUUZFVzBRY0RITm43c1px?= =?utf-8?B?Vkw2MjNOVCt6ZnFuYTBQSFBkVFlxZlNPZjhlYkY4NFE2ZDZ3cjdnUGovQlds?= =?utf-8?B?MnIrSzVDQlJBNXY3dFAybXRIRTFSZlNUdW1IUjNvOUN6eWN0SnJubm8zams5?= =?utf-8?B?b3VGci9YbWtPM09aN3Z3NWdPWW1zWExUNDhBN2J6WHpCRDdUcTNKbUErN09O?= =?utf-8?B?SkNqd01SUzVXUlRUdENGODBFKzhLSUdkYzNGdVo5VnBxcUlaZVlaZz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53d35e0d-eabb-484b-a9ae-08da335b70dd X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 14:35:05.4805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPs1yqZydGhvv2pNJ1b45OMxkap7nkRzXZd+0I1qojpSCqwNfju1O4C7YjSzbSsZjZV9Z0C3oROdi8zAD16hfnZoDOXR5TEBlY5yBylTE1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5762 T24gMTEvMDUvMjAyMiAxNToxNSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gV2VkLCBN YXkgMTEsIDIwMjIgYXQgMDM6NTk6MjhQTSArMDIwMCwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3Jl Y2tpIHdyb3RlOg0KPj4gSW50ZWwgTFBTUyBoYXMgSU5URVJSVVBUX0xJTkUgc2V0IHRvIDB4ZmYg YnkgZGVmYXVsdCwgdGhhdCBpcyBkZWNsYXJlZA0KPj4gYnkgdGhlIFBDSSBMb2NhbCBCdXMgU3Bl Y2lmaWNhdGlvbiBSZXZpc2lvbiAzLjAgKGZyb20gMjAwNCkgYXMNCj4+ICJ1bmtub3duIi8ibm8g Y29ubmVjdGlvbiIuIEZhbGxiYWNrIHRvIHBvbGwgbW9kZSBpbiB0aGlzIGNhc2UuDQo+PiBUaGUg MHhmZiBoYW5kbGluZyBpcyB4ODYtc3BlY2lmaWMsIHRoZSBzdXJyb3VuZGluZyBjb2RlIGlzIGd1 YXJkZWQgd2l0aA0KPj4gQ09ORklHX1g4NiBhbnl3YXkuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2libGV0aGluZ3NsYWIu Y29tPg0KPj4gLS0tDQo+PiBDaGFuZ2VzIGluIHY0Og0KPj4gIC0gYWRqdXN0IGxvZyBtZXNzYWdl LCBjaGFuZ2UgaXQgZnJvbSBXQVJOSU5HIHRvIElORk8NCj4+ICAtIHJlLWFkZCB4ODYgcmVmZXJl bmNlIGluIHRoZSBjb21taXQgbWVzc2FnZQ0KPj4gQ2hhbmdlcyBpbiB2MzoNCj4+ICAtIGNoYW5n ZSBiYWNrIHRvIGNoZWNraW5nIDB4ZmYgZXhwbGljaXRseQ0KPj4gIC0gYWRqdXN0IGNvbW1pdCBt ZXNzYWdlLCBpbmNsdWRlIHNwZWMgcmVmZXJlbmNlDQo+PiAgLSBjaGFuZ2Ugd2FybmluZyB0byBt YXRjaCB0aGUgYWJvdmUNCj4+IENoYW5nZXMgaW4gdjI6DQo+PiAgLSBhZGQgbG9nIG1lc3NhZ2UN Cj4+ICAtIGV4dGVuZCBjb21taXQgbWVzc2FnZQ0KPj4gIC0gY29kZSBzdHlsZSBmaXgNCj4+IC0t LQ0KPj4gIHhlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jIHwgNyArKysrKysrDQo+PiAgMSBmaWxl IGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vZHJpdmVy cy9jaGFyL25zMTY1NTAuYyBiL3hlbi9kcml2ZXJzL2NoYXIvbnMxNjU1MC5jDQo+PiBpbmRleCBm Yjc1Y2VlNGExM2EuLmMwZDY1Y2ZmNjJmZSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9kcml2ZXJzL2No YXIvbnMxNjU1MC5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9jaGFyL25zMTY1NTAuYw0KPj4gQEAg LTEyMzgsNiArMTIzOCwxMyBAQCBwY2lfdWFydF9jb25maWcoc3RydWN0IG5zMTY1NTAgKnVhcnQs IGJvb2xfdCBza2lwX2FtdCwgdW5zaWduZWQgaW50IGlkeCkNCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcGNpX2NvbmZfcmVhZDgoUENJX1NCREYoMCwgYiwgZCwgZiksDQo+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9JTlRFUlJVUFRfTElO RSkgOiAwOw0KPj4gIA0KPj4gKyAgICAgICAgICAgICAgICBpZiAoIHVhcnQtPmlycSA9PSAweGZm ICkNCj4+ICsgICAgICAgICAgICAgICAgICAgIHVhcnQtPmlycSA9IDA7DQo+PiArICAgICAgICAg ICAgICAgIGlmICggIXVhcnQtPmlycSApDQo+PiArICAgICAgICAgICAgICAgICAgICBwcmludGso WEVOTE9HX0lORk8NCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAibnMxNjU1MDogJXBw IG5vIGxlZ2FjeSBJUlEgJWQsIHVzaW5nIHBvbGwgbW9kZVxuIiwNCj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAmUENJX1NCREYoMCwgYiwgZCwgZiksIHVhcnQtPmlycSk7DQo+IFRoZXJl J3Mgbm8gcG9pbnQgaW4gcHJpbnRpbmcgLT5pcnEgYXMgaXQgd2lsbCBiZSAwIG9yIGVsc2UgdGhl IG1lc3NhZ2UNCj4gd29uJ3QgYmUgcHJpbnRlZC4NCj4NCj4gV2l0aCB0aGF0IGZpeGVkOg0KPg0K PiBSZXZpZXdlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQoN ClRCSCwgY2FuIGJlIGZpeGVkIG9uIGNvbW1pdCwgc2F2ZSBhbm90aGVyIHJvdW5kIG9mIHBhdGNo aW5nLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed May 11 14:40:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.326995.549683 (Exim 4.92) (envelope-from ) id 1nonVs-0000Df-8n; Wed, 11 May 2022 14:40:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 326995.549683; Wed, 11 May 2022 14:40:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonVs-0000DY-5E; Wed, 11 May 2022 14:40:28 +0000 Received: by outflank-mailman (input) for mailman id 326995; Wed, 11 May 2022 14:40:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonVr-0000DS-Ig for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:40:27 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4aff4afd-d138-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:40:26 +0200 (CEST) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 May 2022 10:40:23 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB3661.namprd03.prod.outlook.com (2603:10b6:805:42::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 14:40:21 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:40:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4aff4afd-d138-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652280026; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=xR/LGYp7NH6Emk6fmDcrmMbdt7fueI2f/9Tt2hfoHHY=; b=Utkp3AnkRFzM68Tia6/7lNFeShAwkpotAg8gSKXsaFkc0OR+x3wfVEyt 0k/8TnFY6x7ap315dOARH3vc2fqWCv1xgA/9nSPDvk1RavIuNLDdrPu7Y zShuWkALSjRdpjC16go/aeCutndTvPC9OdQGCvyygftkowSDKW8Ew4zD4 k=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 70947052 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MyCFxauiM5/aGSaL18pPIn3Md+fnVGlfMUV32f8akzHdYApBsoF/q tZmKWzVOPuMYGr3KY92aY3i8xsPvZ+GzYViHFFrripgEHlB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8TOLDtoMQDXyNyTTtbO5Z03ODfAUGg5Jn7I03uKxMAwt1IJWRvZcg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5o1qiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N9PZouzWJpOB3+LbXAufKd8K3f4ZQgVzDo nKY8Vr7CB5PYbRzzhLAqBpAnNTnmCrhXYsIGb6Q9/h0gUaSzGgeFB0XU1SgpfCzzEW5Xrp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmPwKfJ5weSBkAfUyVMLtchsaceRyEu1 1KPt8PkA3poqrL9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiJ43pgLCSJBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQCBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:ArynpKt3NFnp3a7va5uuBaj07skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70947052" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvZEYYHybrv9L5DOkUDbldgVmrRIzYGGHMkMiovz36WZke5Uic30gqg07PoaSJV5cYhU4gh3fA9k3VagCp5miyY8RAcsXOyvyatklPHFsqFq3F8TYMIz2Aam2fZiBbPB1BLYmn7b3cfZ5aPLi5/ojHrx/A/r+Y2A/f7KT8i2TpKwywK8zL+rqy9RzS0vpaFbeoLs8+NHkjvvh8tTz38X/jEz0qzPKUapxvYoGLRmWc6l+7/cub5Gb2XBp3NuA0vHCb4pQYtyOnitp2p6stYIkw3M4BwMNBIlSIwWTjRzzY/qCdLc083SD6onxhdbaQvLYcm8OLoTjjUiHrz6uqzyCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yMXWt/M9Qsr7lS8ZgCrHGD4/arQ6gMgHS7x2uYjxOns=; b=BnVMSRT/otscfjntj0MwNB+NlfBd0UHcv4Be9XUxKFLmhEgbCzUkQgMvtJnekvDrRGNh/R7f3dQvyoDxrOPB67C/OSsPB/dgJ9k7B8ruG8K5I3qLP6uCDhyd2CnBr35nDNwjJaTGe0WiDECd0QON4fM3RAhfyNo6B3o6tzsza/Q2NyAzqN/k7tKVBgfWCOeg8GPiKyOWBqNp5BOSWSbko3AbOPJeE4Eb2hYF3LaVdtz3jEsZrtvq9SIOeQLHDZFsPhQfY70CE7wTSodXShg6jhvbi0x6rEuWgiTKse9IO7H717bq8XveNtNveMBxX5fN/+k7hKL5zBCvfHztxYJAMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yMXWt/M9Qsr7lS8ZgCrHGD4/arQ6gMgHS7x2uYjxOns=; b=VSDMlXOL6iTYneTg2gMpVop7z7rqMbCNTmuKPto38eyIkjo2nxnrWPX/aCd18makqkfcqNbycufmAqiSEwbLL3+7K/9m+Hp4+/MuIUj3Q/Nr5lGWOY05miuA6dbhtdPSPSnP+vyo2vgbezCgfoyEAFxfaOg41PLpVcnVR6bTGaA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 11 May 2022 16:40:15 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220511135929.1823116-1-marmarek@invisiblethingslab.com> <9e087a55-8384-b25a-fb94-1ef421c7fcdf@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9e087a55-8384-b25a-fb94-1ef421c7fcdf@citrix.com> X-ClientProxiedBy: LO2P265CA0478.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3aee42dd-1218-49df-f6fb-08da335c2cad X-MS-TrafficTypeDiagnostic: SN6PR03MB3661:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x/y2KKCzLmbjFjK/xtt1+LTeD5gyYaAegl/u/iS7UH5m1NGN0lKoOTNNvKlgU/KiNoJoBlrOaBiYpBZXcXQa5Cfa0E0vYHKuSSstNZYJHqACWjeabZeLoQn/vGnqX0ztoUVX36jgfXIi6ZnJnkmKEseXIkHFR/VOm9akqXuBv9xbwkwVaHUZjvz8u4M1biNfVGJvF8yfy2Tv42qMUlJ3YGd0dHjihwH9N0WC/OrQ28KNsMhSSp8cV3WnpsHrm49MPPg4bU7PQLHRzbVgniJZ7aVyPck+16aMGkyKoeugF9Be0jU3PKLLOtuCe5Wo4WkTj1O1+wXKX2GpEpJpbnEzz2nGl9rBiSvVIq2YYiIpujAYOGEr4PVPaTIAwLTVlzj+zp0p394+fogev/0BLh76Atl5aW6keJ9r+K9Psc7jZDZNzTlVWqaegkdUgv8WX0P77JAyDpqM4qMk62i0ordv5XWb+J0AhhGAKKev6/EqN9qjGF+rbr6tltLav/0iwh/c5YuYSkVh95o7qqy3EQORTQ3M5fzuvkVvNYkXdaaqsdw8gI91Zjc1NSb0CQOPqV4N2gIgfgHLS6CXuFj2FkK9y9RqriLzWy7oHB1H7IHbmPSoBcNshq47F/xF99cRA7KDTsz/WywWyxqZyi4HmQLGRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(86362001)(6666004)(53546011)(33716001)(38100700002)(508600001)(6486002)(83380400001)(66574015)(6512007)(26005)(186003)(9686003)(5660300002)(85182001)(54906003)(6636002)(316002)(2906002)(4326008)(66946007)(6862004)(66556008)(66476007)(8676002)(8936002)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2wxbkhLYUF5TzFBKy94Wm5TRnhVVEpKN2Y5MmJOSGM4TVc4NXVvTXYrNnY3?= =?utf-8?B?VkxCcmVWR1JJbitBRGxucHQwaEovbG1ZMFlKR3YrdGd6WFhDdmI3VE5haXhY?= =?utf-8?B?VlFoTEVwZUphWi9XNGNlbDl4enRpMTViL2NHR0pwVW52K1ZRRWtWUHVlaTZi?= =?utf-8?B?Zlk3VTIrODNmRG9QbFVZR2pvbjZhQ1ZYZm9rdEs2eHF0RGl4R0FHejY0OCtp?= =?utf-8?B?dS9vUnFibit2Y3I3NGdPR3BsbUZ3MHFuU3JidzhEL3Ywc0g3Sk1kenppM3Rl?= =?utf-8?B?RFdRK3Q3YitHZnYyRlE4Y1pXMFhiY3lid0Q4STAycGxkSkd0Wm9sbzlKaXU1?= =?utf-8?B?Q0xZbDcrRTRKMGZyVFpTS0tyYXV1OUVYcUpPK3M0SGcxUnZuTXdsOWo3eENB?= =?utf-8?B?SnBwMVFpbEFVaFpUUzA0THJNYVpOaXE0OHpxcEZLb2VIVThMdC9TK1BGMndp?= =?utf-8?B?UzBUVHVQckRRMmRQMjdhRDZRUE1XTTRyK2FFVGRscHFycjNURlRkcU9IOGo3?= =?utf-8?B?Qk96UmM4MFRXUHpqRDc2eEU2Tk9sb2lUQld0bUY5TFd0QTRCOWhybmRyUjh0?= =?utf-8?B?OUxSMUhQR2hkaWF1QkNzMldZWjBqbXRTMWlZSVhsS0h5OUFpek5lZW1RclRn?= =?utf-8?B?bHQ4cnZib0dKK0JDeWdoNmNESkJSRFBIcy9ta3hGeDBuZDhUd2dNdC8ya05E?= =?utf-8?B?dGhQWUdMSVJac2RDKzh5ZkZTeFlVOVAvYmZXYml2a3I5MGJFYXZuZ3hOZTB0?= =?utf-8?B?YSt1cHY1ZkRjL3M4bzgyUEVtK3lvVGpCUGl2VDdJTzhQNDYzVUlHUTBGbnYr?= =?utf-8?B?N2V1TDJmY0RvdHJaWE9NTUZFZVJ4clFONjhwL3FUMThrcXozS1U2c1NNWFFX?= =?utf-8?B?ZVRtdGRRTkFLNFBKTE1WaVY4YnVGdTladXlWd2xVSjdPUlNqdDBuQlhCUXcy?= =?utf-8?B?ZDJFN09XV2k1azJHb1NGL3JsZFhGdG1TU0UyeHpLSWVOMmVpVkMwWDZ1QVlU?= =?utf-8?B?WEVzQzEyaVAyVUtkKzNOMlc1Sm9GaHRDQ1JRbTRBaGh3K1Q3d1orWk0wMjU1?= =?utf-8?B?bzVjcS9pQnJncm5iV3ZYR1VZNEFsSEU4UUVha0hKNUZtL0hseXIzRmRPS2x5?= =?utf-8?B?UEd6Y3pSTDdya2xLazdNL0c2RHlJMWNHd3I4RHljSXdkeU9IeG9hMDRDYSsr?= =?utf-8?B?WGowbXROMG40WTcrZWJ2cm4xWGdJb2lsYkRlekVxdzhPQk5rVzRpWXVna2l2?= =?utf-8?B?VEt6cys2eDByUmZZWjlsdkUzbXhmOGpHYzlEVTlvaTZzQUdsOGZIdmg2dkh0?= =?utf-8?B?Ym8vS3Zyc3ljVEgwWGU2SFp6dGx6QksyeWU4M2hGZEtPWlBaYmxKMGtvWmU4?= =?utf-8?B?U3VwNkN6d0NpZkNEL0VUc1NGYTdvQmRtVHh4QWowVmJRZzJtTHFEOEhvT3c0?= =?utf-8?B?NTJzTlBmYTI4a2tUMzRrVFFuaEtMSFFCT0NTNHpCaVFmQzk4ZmdYTGN4Ym1v?= =?utf-8?B?d0RidnNmb2VPSUZtbHNKV3JwTENOZDE2VDA3b243T0FFUU83LzU4Uk5LM2ln?= =?utf-8?B?dWVEcHVXOUgxMUJHT0hxdk1SSTVxZnYyYkljcmRnU2xoM09najA2aEdSdjEx?= =?utf-8?B?UkxYUGs0Uy9tNWdSSkJDNHlmYW84cTh2anMzNjJHQVhEeU1mQTlsRlFReThQ?= =?utf-8?B?S3oybFNBL0djbmtYS3dQU3l6VW04cG0yNVVuMTZlMzFiVitLOGhjYVVIRmhv?= =?utf-8?B?YnZhOVV3SnpxT3NTdXIwcmdmbHQ1c2tGdXRKSVJvTDNia0JlMDEzczRJd3k2?= =?utf-8?B?K2Fmdm92VWtBdjIvQjd1cGRtbGVPRDNRbzN6RmdzbTVsb3Uza3hnWU52MFda?= =?utf-8?B?WVRsVHp2Z2x6NTZhUENkNVQxSFhWOS80QkJpTGxiTnMvS0ZGemZDdnE5aVA0?= =?utf-8?B?NlMrZ1U1cnZRcGIvRWNRRzdhQ0RtRVBOeEN5bDRVdGw4UHNHRmtwV0tXcjMw?= =?utf-8?B?M0RRTlVqdFB3Zlp0U0FqTS9Yb3VYM2VRN0xucFdFcGpJRVBMaFR2TEtpNUZZ?= =?utf-8?B?WlVlMnNLdkdtTjJZbXRvUC9qcmhtQWZNcitmS0YxOFZzVlluUmpSaHQwcnJ0?= =?utf-8?B?bWFNZDhBaWt4Vld4ODhlcjVVN2NDZFZLYXc5dW9wRklicGNKRllVUVdyVUM0?= =?utf-8?B?ODNrN2g2UlQ3UlVrRGFvdTBHSXYrUzM3SEVsQk8rWDdyellaNXF2T09sYk52?= =?utf-8?B?eisxbE1NOWpXcWJOMGV3OU5hN3hXUS9VclVSYXhVbzlpSEkrbVU3UHd0VnUr?= =?utf-8?B?SnlJcXc0QTRhamdzMDBNcjN1NVlBY05ScEY1NHdYWWg0U0tBSTR3RFVuVmZt?= =?utf-8?Q?E+2hdg5yyhXOWuF8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3aee42dd-1218-49df-f6fb-08da335c2cad X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:40:20.9041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bQZVW+jjuSWjiWPidI3TKfaMea6Agp/SDNSzBz2dDiU9iPsoYtOf44k/c4Hk3CeYVn1M1iYeXlv1hHyYrhYJAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3661 On Wed, May 11, 2022 at 02:35:05PM +0000, Andrew Cooper wrote: > On 11/05/2022 15:15, Roger Pau Monné wrote: > > On Wed, May 11, 2022 at 03:59:28PM +0200, Marek Marczykowski-Górecki wrote: > >> Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > >> by the PCI Local Bus Specification Revision 3.0 (from 2004) as > >> "unknown"/"no connection". Fallback to poll mode in this case. > >> The 0xff handling is x86-specific, the surrounding code is guarded with > >> CONFIG_X86 anyway. > >> > >> Signed-off-by: Marek Marczykowski-Górecki > >> --- > >> Changes in v4: > >> - adjust log message, change it from WARNING to INFO > >> - re-add x86 reference in the commit message > >> Changes in v3: > >> - change back to checking 0xff explicitly > >> - adjust commit message, include spec reference > >> - change warning to match the above > >> Changes in v2: > >> - add log message > >> - extend commit message > >> - code style fix > >> --- > >> xen/drivers/char/ns16550.c | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > >> index fb75cee4a13a..c0d65cff62fe 100644 > >> --- a/xen/drivers/char/ns16550.c > >> +++ b/xen/drivers/char/ns16550.c > >> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > >> pci_conf_read8(PCI_SBDF(0, b, d, f), > >> PCI_INTERRUPT_LINE) : 0; > >> > >> + if ( uart->irq == 0xff ) > >> + uart->irq = 0; > >> + if ( !uart->irq ) > >> + printk(XENLOG_INFO > >> + "ns16550: %pp no legacy IRQ %d, using poll mode\n", > >> + &PCI_SBDF(0, b, d, f), uart->irq); > > There's no point in printing ->irq as it will be 0 or else the message > > won't be printed. > > > > With that fixed: > > > > Reviewed-by: Roger Pau Monné > > TBH, can be fixed on commit, save another round of patching. Indeed, thanks for taking care of that. Roger. From xen-devel-bounces@lists.xenproject.org Wed May 11 14:41:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327001.549694 (Exim 4.92) (envelope-from ) id 1nonWe-0000jB-Ik; Wed, 11 May 2022 14:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327001.549694; Wed, 11 May 2022 14:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWe-0000j4-Ey; Wed, 11 May 2022 14:41:16 +0000 Received: by outflank-mailman (input) for mailman id 327001; Wed, 11 May 2022 14:41:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWd-0000iw-0l for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:41:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1b::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6823e8be-d138-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:41:14 +0200 (CEST) Received: from AS9PR06CA0543.eurprd06.prod.outlook.com (2603:10a6:20b:485::6) by AS8PR08MB7012.eurprd08.prod.outlook.com (2603:10a6:20b:34f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 14:41:12 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:485:cafe::3a) by AS9PR06CA0543.outlook.office365.com (2603:10a6:20b:485::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:11 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 11 May 2022 14:41:10 +0000 Received: from a1ebac394442.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CC68837E-7FDB-435F-B279-3D3844203F0B.1; Wed, 11 May 2022 14:41:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a1ebac394442.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:41:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4391.eurprd08.prod.outlook.com (2603:10a6:20b:73::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 14:41:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:41:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6823e8be-d138-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RwlnS9lZjTMdKRWW+lmIMCfpUGGa6crnU8toIjoToD3qFfGT5uoYUWUJopxOmuKYXwc1JDocihQYNLSNKA6hBBcgPxkGsOiKlyEblvQ95QozruUwNSS4Kf77DAz0Mn0vgENmhG7WOk6rOqvG8EHTMwh1PK5iUArT57s8smAXFlgnj1nXq65Rl463tFPeP5uw2rWAM5Ly44UJjNAnArHDsVG5tfPAoB1bk5B48vmQUj+etDG9i4TapLzgZh/pUrj2JyGJlEmqXDZc1JUFAeJLUoX6JdOMaqKhGsGO+hKEWJqck2+2QLXaRCW0ktpSgGH0xjEPQC0+boTl7u4B3I/5lw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=CBEyz1K5GbD+cSBLU04t0mkvK3qSnC6waOiQ7bnywhMlGkNMz02WziTY3P4n/QE6Vb8cLHfOSuWAPU3afGuBt5XmlKTbuVsemyNpE1Nzsp7rd1mh6Pm9MH6KabaCHKKHFEDn+7LEY51cKZQKThXAY4wDO8l4Cpnz+Apwq/3hDtSkWd4Ty6Sw2VL05hY26GaKcZlrE1MUS2XRfUUo0Fm046MUcginZZbnBN7RmMqHVw8On0ZJtqKUB2KWWNSMdJqHa3i1lmqSMyohpOLCvlnRI6aN7xi2SmOtKwfE3SzZi/3aZBfdulrj3iF8ro98IRnoBWkV++zB5KGMnE1jeE8sug== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=AYGo7gMfUeeQbv494TL9izexPczy+9WvFM7UvNTjU2J0rk4UBJQyeN7+qZfqIO/fKwknST55EyB3rf7twzhb3ZFPkAj/w+ZiyJ1SGJFVdTGlDo4kuDZOogNN7dI0ImYDLbzTBzPrgT7zBLy1H4PANrEM39q1RmpdhSDhX3ClL6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 9af7d9cd5fbeda94 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GGdcTJ0qha+Cawd2DGnqP3WOqsP3yMBzYxTDCZqUyWC21nM9R5r4OPo7uPBfaMVBKO0SgZXRPXNNq1zmDVguUCmcNXZrCxgqfAxRXL+fm4nOeoJuYe4vOiDshWT/DbNaSW6oEgE91nomxg/R/XBV8WTTSj/ZTGhcovtcKSKaGqRFJyo0GAl6cUaRVGCiR2GVL+TR0j86pNF2Uxj1NpUZFwErQGmTZvtKn0oPSZAlzytc64vTEovfbcVSHzyjDFq73irmr2hPL5N7TdVGO+Yvy3etjgOHyw3lTnYYZmvYneC0CRWs5EYBEcXsUsQs/ZhMjcUY8j9r8UgoocvrPAOFhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=bRz8CvWgDIsgCUBILbwygqqvkEzVQ1zVlHeTZTsGREk9HbNxB2u4MwyIiBM9KeE3qA5SQcd3UYRGO7prxR6zoZ1omkIKjtWrHc/9E2w8fM2pV1lnD9BkvR4xjc+4/FO323L1WBO4y7wNhCWc60LgBtvcGxswONQBPLVpFiF8Miujav/snwE21pRYBrV71H7Z6mChsAs8A7oJoAmGAkp3cZ7bItxGjJengsOGjrWL5+BHeDap0bSxmugo6uMEy/OIqVnvDX21yTY5QhlFPEt/yT1NT30/c9JshHeXijRg6LnYSm9PMkuHghp8RR8QcNaKvYJ+gjDZTz6IUcVP7EQEvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGYn6V8w3ykRx1tAB69Zoh4N/SGhHOkB+TaMiPAG4/4=; b=AYGo7gMfUeeQbv494TL9izexPczy+9WvFM7UvNTjU2J0rk4UBJQyeN7+qZfqIO/fKwknST55EyB3rf7twzhb3ZFPkAj/w+ZiyJ1SGJFVdTGlDo4kuDZOogNN7dI0ImYDLbzTBzPrgT7zBLy1H4PANrEM39q1RmpdhSDhX3ClL6c= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduA Date: Wed, 11 May 2022 14:41:02 +0000 Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 32cd3fa0-92e4-4d8a-99fb-08da335c4acc x-ms-traffictypediagnostic: AM6PR08MB4391:EE_|VE1EUR03FT022:EE_|AS8PR08MB7012:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rmyE8PgMG0rdiXZfZMgYs/zbHf3NrHkhoqEUfh/j9yagfU9TQsWNJ6YWcfukA3J6nr+9zp7PDx35O8IHCg6sMCckp2n/3pu38F2N9ydbpJkCfj6FrhunUJkuwVaB1FQ8+VEJd4HZ6QSbZZmVtBafC077pgOR10UOiO91Df0xvmBTQ2UGvmoEhh4B0uTJzxLJoeCvgwcVvKhsd9OXXbHeVTnGPdJFDlbteaLmAohqbb9TmfzN9UxxEgQCuLBy9MBW6wZh0igmt0l6qeoiTTImIT1YRIYWC7XWlYUNEP912X4GvIi6br8jKqaGk4uTj7NkLXzZW6gP+LEnxwxFa3kIau/XRRphI3IEiCGANwA0tVnO6V+UsUyPnZduH5fSwooje6PEp3a/f0vFfcPckNpm2LpL7Nz+Y/J++mw/fGqGLzqGwurjrL2oc0Ih6wKlRN81rVAY8bi+bz4QOxmahcDLcxA1oHh4MDcbsl0Yi79zw7ns0+zE6t+eJ59o3bHmhQgVE0sJoYkEqBTvL4aIchN0eooeEZOcXQABLt9F0Xuuf5q16RPl7pM5iECdlt/6FqVn8gfWZNB8m7wTn+kuHIRM9r7iNmi7RYzIHRZiWgQY+6XxgmqdDY3Z5buifOhon3neEo0L694CnT8ndrtujEVGhWgVTJlzW1i0b+hpM2+m9G7ITzpnjrs9UUjN1S4fFSZGQQu05iEU/yJZ3HGmjeBsIoVic3y1WpOLEsu/6E202Ireqre1r7xO+Eq7TtdMTMBh X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(36756003)(2906002)(38070700005)(38100700002)(8936002)(5660300002)(186003)(508600001)(33656002)(66946007)(8676002)(91956017)(2616005)(66556008)(64756008)(66446008)(66476007)(76116006)(83380400001)(316002)(54906003)(53546011)(6916009)(6506007)(6486002)(6512007)(26005)(71200400001)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <39DC5A6C76B87B4CBBD8DCF379A8692B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4391 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99ef6ae9-41a5-46ea-ff95-08da335c4570 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ba1//UXGNr1edcec/EexpLH+KonBJQdGghPQ0/BbvEf2yU4HsBg+gqNoEKxJ2g4HkksjRBdz3mELxUXg07i5RhY/GnVjKDxvCnaapfSmtNjhX5UvoS5+XLgomowh8MI/sex2V22UtREKVDl+f2yr0hDm9CwpAjgEotDn8CVO3XNrLVzQfylb+6dHhYEEmfO9UrCfDa3OLbiYEARS0o6vwapqLJ3CvxgAe/IMMAPNwmtzUpPOsHhA9j2cXiD/GZ7gfFEh5azorhFkaMzhkahn0OeuwehzqpBlwYkSeX1KbZB07W/nhPLw35Ws9Xj2MmZcz7dXM1jIyYnpNrIR22mD17L72oSjF2UutZFnWg5DLTE1gp1j6PrtOAoI31HXgWxIwKN5nKRA/RIb8LkXP9lY8TQli1JwLVgCPvrfKCVjo3MKpKCEbryXqmuiEM/XWuCPA6yH49W4AAZ7vi6CwRRygRraf5JSGJYm1c8lMUD81OeNqiG4UeHH3ywBLQqDGJmzEhsMPh13IZw3YpSbkGtaoUb2H+GglTZgFRwf8rcRbNi4kMm2U7XmwG1v0IfLg0N1Kqznn40Y1k2FruU4GQwXLlxbE/irdWd+WKuX17PxET3KFBS257Vg+MTrQQJFLGJTZkkgn1JEnGqVJaNNKk/3aQ+beyH7tAwFV2zzhFaJ9AeG8YH02k/ryvzDI5FxnIGT X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(336012)(186003)(81166007)(356005)(83380400001)(316002)(2906002)(47076005)(36860700001)(8936002)(36756003)(5660300002)(33656002)(6486002)(82310400005)(54906003)(70586007)(70206006)(6862004)(2616005)(53546011)(6506007)(26005)(6512007)(4326008)(8676002)(40460700003)(508600001)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:41:11.0183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32cd3fa0-92e4-4d8a-99fb-08da335c4acc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7012 > On 10 May 2022, at 03:03, Stefano Stabellini wro= te: >=20 > On Wed, 4 May 2022, Julien Grall wrote: >>> Do I understand right that it is ok for you if I push one patch mention= ing >>> all the commits done in Linux corresponding to the changes (instead of = one >>> patch per commit) ? >>=20 >> For this case yes. >=20 > I managed to do a review of the patch by doing a diff of the relevant > portion of Xen cpufeature.c with Linux cpufeature.c (from commit > b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux > sysregs.h (diff -E -b -u). >=20 > Everything checks out. >=20 > In my opinion, this patch should be split in 2 patches: the changes to > cpufeature.c and sysregs.c that come from the Linux sources; and the > updates to cpufeature.h that do not. If you do that you can add my > reviewed-by to the first patch with the changes from Linux. >=20 > The list of individual commit IDs would be nice, but thanksfully the two > source files are still "diffable" so in my opinion are not required. I agree with that. Julien: Do you agree if I just put the changes to cpufeature.h in a separat= e patch ? I started to list the commit IDs corresponding to the changes in Linux and = this would end up with 5 or more which I do not think would be that useful as the diff= can be easily done as Stefano mentioned. >=20 > I have a couple of comments on the changes to cpufeature.h (the ones not > from Linux) which I'll reply directly to the patch. I will answer to them. Cheers Bertrand= From xen-devel-bounces@lists.xenproject.org Wed May 11 14:41:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327002.549705 (Exim 4.92) (envelope-from ) id 1nonWl-00012u-Sc; Wed, 11 May 2022 14:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327002.549705; Wed, 11 May 2022 14:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWl-00012j-Oc; Wed, 11 May 2022 14:41:23 +0000 Received: by outflank-mailman (input) for mailman id 327002; Wed, 11 May 2022 14:41:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonWj-0000iw-Ss for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:41:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0604.outbound.protection.outlook.com [2a01:111:f400:fe0d::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c879c16-d138-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:41:21 +0200 (CEST) Received: from AS8PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:20b:311::13) by AM7PR08MB5511.eurprd08.prod.outlook.com (2603:10a6:20b:10d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 14:41:19 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::c5) by AS8PR05CA0008.outlook.office365.com (2603:10a6:20b:311::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:41:18 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Wed, 11 May 2022 14:41:17 +0000 Received: from 7d4d06cea99c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AB5EF05E-ADE7-45F1-A0D3-B1D45A3C92D5.1; Wed, 11 May 2022 14:41:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7d4d06cea99c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:41:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4391.eurprd08.prod.outlook.com (2603:10a6:20b:73::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 14:41:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c879c16-d138-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SKTcOsHhunRIv0CeZzTa9Hk6PpPJWQDg2oJiiQNhxhfeRjhsfXAIVY4vVy9pZ/PROIzWUZBGm2H24u1nwMjQ6T8Ncw+zzHQwxOaeo5qQ9r5hDHQHn2NWkd1xyjauEiJGlq9tD4Jkid5krjelzCXFdN6IF6irIpuHl86NUMBFX+Um+sgq0woOEGT6Ch1f4LAsH3nYqvIOwWR52E3ScA4lmERGGOJELYAVQyytIj8R3+HLLe0IDAyXlTLvB2NO1voZ+tsmKVoHBihCG/C99gdjBwhE0WTWck5XmTobR4xR4tJT3x0DgP+eNSyHlIe4fpnE9H5UaI6vN0La9sOk3FS/gQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jh0wc3nBi40lNGNt4U2dKuDBsSaiYWBhotMUpKSSRVs=; b=l479fw11cGHFLekwx/BnldMykGUmpyNk4kB9dbCeGs1MZWYIatTmk9ZOJP54ICOnPpk7VAyPQjawKwVA9BU9MAqX3X6HikNToA+cvA6dDY3cf8PXhxBeiKodVwGhN5+q2kIJzdi8gfk5wkXpNSN1Z9PZS4F4MqfCl1vXzv1LU/7dnGC0Gu9lttIt1dGehGnwkw4+fHosNqLjApt3EjcVkRe1/XofG2vgdyYivAxaOJBr3UpKSYov8WDJt3cHFQF5IirGsKtPiCNO1fZYrzofMEgRWMUThvC9gvxUCr04ehhm8lm81EvZ++J6oRkEXAFpS2sk/3tCjoIXDakurmsm5A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jh0wc3nBi40lNGNt4U2dKuDBsSaiYWBhotMUpKSSRVs=; b=AjbukX8HO1zP1kMFHpdDX6KkF2RpC87R8kVBpEga74K1HAoe4CEWQDhhErv5Uqgij56TOmzB5ErdBtnbJp0EZBkVFEE5XhWgMofy33u3o6qYosftrMwkBmjExfpdK62L56jfiiYFX8WUGrzpqpoKNadsqiIX7k0DqGzXmtMjD8g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0e38c0b7506d69c0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFnmGq0+acuTo85Vu09UDyD8EKzwp3Y5KcbQlDeJH5VEhrgXiRkEDMmy61REOJEUQ12K0uabfpWkpKg5Xrf1ldhBaf5ag6DhUWrV5gSoOz4vnDpXOqv1fe44NOvIURvnD0EhtRqWapVe5LFGI5a1MnIAoCPeNaHCEVgiyNHMu4xZsSbD0piCJU6AlJ43m6mOYDZhOK+bc/z3kiJHCsex3yNjzgmeQ0iN+CkCZJzzSnBSu6cM8PuHtXa+WHl7twltM54KP3jG+UUShaJiKTH+Cp74kPhwrKjycSzdLhg0jQ+5fOYDu/iNpSVUqYjjF0atCpvJtbPWSx1IU3+mQcfDQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jh0wc3nBi40lNGNt4U2dKuDBsSaiYWBhotMUpKSSRVs=; b=GAI6AKo4u3ASFU4dVWmhp6rn++50XQMa6hgUkQO4RvK50iwe8mm7y103XHwDuubCz029qLkVjoh5AMsnFrG7mtozIZQq9bhrXo937C73uyWFqVUJEh2DTLv0Z/fCdktB9gYs+Y8pdXxyEhoLc9dGzxX6BsYdgXzhgJONmFRx/KoUQVceR+msLN0CVjQ+QyXdJUg/+/PtILXOOax/Sm8KqMDFnEBIP+jg7zw66VseY/R5KFs3e3Ea7+QrzzikEBoDThnZO+GA1GnKW89Gh8CCeJhJyEvWFIIrIXgWn6R/FWsAYWse9KmMZ1+kJAEtKEfIvmFmTuWihDg6iD7/3kd61g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jh0wc3nBi40lNGNt4U2dKuDBsSaiYWBhotMUpKSSRVs=; b=AjbukX8HO1zP1kMFHpdDX6KkF2RpC87R8kVBpEga74K1HAoe4CEWQDhhErv5Uqgij56TOmzB5ErdBtnbJp0EZBkVFEE5XhWgMofy33u3o6qYosftrMwkBmjExfpdK62L56jfiiYFX8WUGrzpqpoKNadsqiIX7k0DqGzXmtMjD8g= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0XZv2AgAJlrAA= Date: Wed, 11 May 2022 14:41:08 +0000 Message-ID: <13F6ADF2-574F-4E80-91B4-F646E629B120@arm.com> References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f3217c24-52c5-40cc-c584-08da335c4f40 x-ms-traffictypediagnostic: AM6PR08MB4391:EE_|VE1EUR03FT049:EE_|AM7PR08MB5511:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: p4Bot5+MmIwtX0WOPpwOktVEjiRoaJc73gYr8W/ya3iZfb5sc3P64vBK9FY9sRN/Gg70xltLKWpA472wk+Oiy0CVJVNHBdfvYsI+BAFZGA83ZeLublVSknhnC4YYCILZfKiBut4f6H/Y43F6GPi8ttUC2z6xpPgRWfMjVwCeS+wp2qsJdBBAWoob7N48hKpZTPhUl3g8icpy2zQYpJcCfUPyPvZAtQIgbCj/TGbZ0HJgv8y0SWJWz9l6nazgJyMgBMOReliY3646rsQ4qZWCqWZDnXXzSYFwG35KSJBnx4wy4cPBllXekwZYH/wzi4uc8WlgOiWTc+6WZrw+KEGg6XXTZTMTfhV5/h/Ce/zNh0CbtyOEYfE2RiC0dy+3X0sHfWSooKzHdlH7EvCU8EuXxBLaMlVfVKoGcelq4AqvoOHwReC8NifD88GFe2UnW1oimGwnnrU1cq4fskXsz6FjnGysv0YLN+bK6Gkh07WzowDeDIXFix+gXyPrUgVbBSzWBkLnB1IUi169TE3j82ke3tiPrv+rI8nqChtyPaQyuYxd7S5L4/dpV+pRU7G4QlxW3Rg1thvmJNrbyNagpXo82+1TUf9oumLpr8n+1/wT3kiN3T6Hflhst2KdNKhxrGdNfvJbJH1qxdWdJpBM9tJf2e1Rr1c7oGdAmmt6g9O5PM80DT/0oP3v4faMKYdXiYNK7EbNSWMGarHhb0s1BlzJ1zuD8ji5NMDLpUQOwuQh+eETnVpEDBEnD5o93YCYOlRZ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(36756003)(30864003)(2906002)(38070700005)(38100700002)(8936002)(5660300002)(186003)(508600001)(33656002)(66946007)(8676002)(91956017)(2616005)(66556008)(64756008)(66446008)(66476007)(76116006)(83380400001)(316002)(54906003)(53546011)(6916009)(6506007)(6486002)(6512007)(26005)(71200400001)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7CD9CE4190080441BD22E0C59362C623@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4391 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0d964278-2930-45d8-5186-08da335c493b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jlwXEuQGF8to9Us+s+Y8AeQ26QxbTRshEhs5yRPvHO6g8HxYLC23aZCrjkMSBUHet7EMiYfOgGq9ILEVSQHDnWDN+KR86I6d2IHMTiZyKHGMBi6JfjuEmBXsoDTMURi4leJ0mC9wnrKzILQszE3D72VmYJNshlYMBQB6Pz2ZaD4Z9+PtO7NwRIbUiNjbW61plJ9NxAkgDHbzEM5eT0hZHOBBtgcEPA0M7Ir1LbnUlQcnYB5+HLJHx32Qsm0Wca72xQyZwNYJ35YgrvIJpN6rXBr4IgBerIODToEI8sJ8+wpuiRVMTFC/x43794JJGjwymoi9ogNOsYfYER3gb/mytLJO4clJ1Ja4AaV+/0QIE7TbVCs7dbZz1ILE8mbq6OXo8hedE4MwxWmfdaTy/zF07+82qUjHRJ0906EYOFh7GES+PNMi12amyR216GTVbYZiLzYyIj776W3LPNLEl6F7/gKEMbKWZHRj3sN9QXvOxKcZU4CQBOlzGbVef9AZPo/75+i/3uIMRjzthGcbaRWFnXyCiRVR/hY2WorV468pxn2D245//KJu0xu4/5C7v+aYBYwxivyubwfP4PtthsoQRJlPd4r/zI+F59TONmtrjKVZq2Fy80OKfqa+l+wSt3oPis5RdWbHziDLn9qvkkOGWaVBOGqMRXsewndD+RAbyHwz6ho5WTMODKeFvVybJii7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(82310400005)(33656002)(2616005)(26005)(356005)(53546011)(5660300002)(86362001)(36756003)(83380400001)(6506007)(8936002)(107886003)(316002)(6486002)(6512007)(508600001)(47076005)(70586007)(30864003)(70206006)(8676002)(54906003)(6862004)(4326008)(336012)(81166007)(40460700003)(186003)(2906002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:41:18.4491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3217c24-52c5-40cc-c584-08da335c4f40 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5511 Hi Stefano, > On 10 May 2022, at 03:04, Stefano Stabellini wro= te: >=20 > On Tue, 3 May 2022, Bertrand Marquis wrote: >> Sync arm64 sysreg bit shift definitions with status of Linux kernel as >> of 5.18-rc3 version (linux commit b2d229d4ddb1). >> Sync ID registers sanitization with the status of Linux 5.18-rc3 and add >> sanitization of ISAR2 registers. >> Complete AA64ISAR2 and AA64MMFR1 with more fields. >> While there add a comment for MMFR bitfields as for other registers in >> the cpuinfo structure definition. >>=20 >> Signed-off-by: Bertrand Marquis >> --- >> xen/arch/arm/arm64/cpufeature.c | 18 +++++- >> xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- >=20 > Linux cpufeature.c has a couple more structures compared to Xen. So I > would add the word "existing" in the commit message: >=20 > "Sync existing ID registers sanitization with the status of Linux > 5.18-rc3 and add sanitization of ISAR2 registers." Ok will do. >=20 > A couple of comments about the cpufeature.h changes below. >=20 >=20 >> xen/arch/arm/include/asm/cpufeature.h | 14 ++++- >> 3 files changed, 91 insertions(+), 17 deletions(-) >>=20 >> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufea= ture.c >> index 6e5d30dc7b..d9039d37b2 100644 >> --- a/xen/arch/arm/arm64/cpufeature.c >> +++ b/xen/arch/arm/arm64/cpufeature.c >> @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1= [] =3D { >> ARM64_FTR_END, >> }; >>=20 >> +static const struct arm64_ftr_bits ftr_id_aa64isar2[] =3D { >> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_C= LEARBHB_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >> + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), >> + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_GPA3_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64ISAR= 2_RPRES_SHIFT, 4, 0), >> + ARM64_FTR_END, >> +}; >> + >> static const struct arm64_ftr_bits ftr_id_aa64pfr0[] =3D { >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_C= SV3_SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_C= SV2_SHIFT, 4, 0), >> @@ -158,8 +168,8 @@ static const struct arm64_ftr_bits ftr_id_aa64pfr0[]= =3D { >> S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_F= P_SHIFT, 4, ID_AA64PFR0_FP_NI), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_E= L3_SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_E= L2_SHIFT, 4, 0), >> - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_= EL1_SHIFT, 4, ID_AA64PFR0_EL1_64BIT_ONLY), >> - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_= EL0_SHIFT, 4, ID_AA64PFR0_EL0_64BIT_ONLY), >> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_= EL1_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), >> + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_= EL0_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), >> ARM64_FTR_END, >> }; >>=20 >> @@ -197,7 +207,7 @@ static const struct arm64_ftr_bits ftr_id_aa64zfr0[]= =3D { >> }; >>=20 >> static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] =3D { >> - ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EC= V_SHIFT, 4, 0), >> + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_E= CV_SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_FGT= _SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EXS= _SHIFT, 4, 0), >> /* >> @@ -243,6 +253,7 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr0[= ] =3D { >> }; >>=20 >> static const struct arm64_ftr_bits ftr_id_aa64mmfr1[] =3D { >> + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_A= FP_SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_ETS= _SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_TWE= D_SHIFT, 4, 0), >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_XNX= _SHIFT, 4, 0), >> @@ -588,6 +599,7 @@ void update_system_features(const struct cpuinfo_arm= *new) >>=20 >> SANITIZE_ID_REG(isa64, 0, aa64isar0); >> SANITIZE_ID_REG(isa64, 1, aa64isar1); >> + SANITIZE_ID_REG(isa64, 2, aa64isar2); >>=20 >> SANITIZE_ID_REG(zfr64, 0, aa64zfr0); >>=20 >> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/inc= lude/asm/arm64/sysregs.h >> index eac08ed33f..54670084c3 100644 >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -144,6 +144,30 @@ >>=20 >> /* id_aa64isar2 */ >> #define ID_AA64ISAR2_CLEARBHB_SHIFT 28 >> +#define ID_AA64ISAR2_APA3_SHIFT 12 >> +#define ID_AA64ISAR2_GPA3_SHIFT 8 >> +#define ID_AA64ISAR2_RPRES_SHIFT 4 >> +#define ID_AA64ISAR2_WFXT_SHIFT 0 >> + >> +#define ID_AA64ISAR2_RPRES_8BIT 0x0 >> +#define ID_AA64ISAR2_RPRES_12BIT 0x1 >> +/* >> + * Value 0x1 has been removed from the architecture, and is >> + * reserved, but has not yet been removed from the ARM ARM >> + * as of ARM DDI 0487G.b. >> + */ >> +#define ID_AA64ISAR2_WFXT_NI 0x0 >> +#define ID_AA64ISAR2_WFXT_SUPPORTED 0x2 >> + >> +#define ID_AA64ISAR2_APA3_NI 0x0 >> +#define ID_AA64ISAR2_APA3_ARCHITECTED 0x1 >> +#define ID_AA64ISAR2_APA3_ARCH_EPAC 0x2 >> +#define ID_AA64ISAR2_APA3_ARCH_EPAC2 0x3 >> +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC 0x4 >> +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC_CMB 0x5 >> + >> +#define ID_AA64ISAR2_GPA3_NI 0x0 >> +#define ID_AA64ISAR2_GPA3_ARCHITECTED 0x1 >>=20 >> /* id_aa64pfr0 */ >> #define ID_AA64PFR0_CSV3_SHIFT 60 >> @@ -165,14 +189,13 @@ >> #define ID_AA64PFR0_AMU 0x1 >> #define ID_AA64PFR0_SVE 0x1 >> #define ID_AA64PFR0_RAS_V1 0x1 >> +#define ID_AA64PFR0_RAS_V1P1 0x2 >> #define ID_AA64PFR0_FP_NI 0xf >> #define ID_AA64PFR0_FP_SUPPORTED 0x0 >> #define ID_AA64PFR0_ASIMD_NI 0xf >> #define ID_AA64PFR0_ASIMD_SUPPORTED 0x0 >> -#define ID_AA64PFR0_EL1_64BIT_ONLY 0x1 >> -#define ID_AA64PFR0_EL1_32BIT_64BIT 0x2 >> -#define ID_AA64PFR0_EL0_64BIT_ONLY 0x1 >> -#define ID_AA64PFR0_EL0_32BIT_64BIT 0x2 >> +#define ID_AA64PFR0_ELx_64BIT_ONLY 0x1 >> +#define ID_AA64PFR0_ELx_32BIT_64BIT 0x2 >>=20 >> /* id_aa64pfr1 */ >> #define ID_AA64PFR1_MPAMFRAC_SHIFT 16 >> @@ -189,6 +212,7 @@ >> #define ID_AA64PFR1_MTE_NI 0x0 >> #define ID_AA64PFR1_MTE_EL0 0x1 >> #define ID_AA64PFR1_MTE 0x2 >> +#define ID_AA64PFR1_MTE_ASYMM 0x3 >>=20 >> /* id_aa64zfr0 */ >> #define ID_AA64ZFR0_F64MM_SHIFT 56 >> @@ -228,17 +252,37 @@ >> #define ID_AA64MMFR0_ASID_SHIFT 4 >> #define ID_AA64MMFR0_PARANGE_SHIFT 0 >>=20 >> -#define ID_AA64MMFR0_TGRAN4_NI 0xf >> -#define ID_AA64MMFR0_TGRAN4_SUPPORTED 0x0 >> -#define ID_AA64MMFR0_TGRAN64_NI 0xf >> -#define ID_AA64MMFR0_TGRAN64_SUPPORTED 0x0 >> -#define ID_AA64MMFR0_TGRAN16_NI 0x0 >> -#define ID_AA64MMFR0_TGRAN16_SUPPORTED 0x1 >> +#define ID_AA64MMFR0_ASID_8 0x0 >> +#define ID_AA64MMFR0_ASID_16 0x2 >> + >> +#define ID_AA64MMFR0_TGRAN4_NI 0xf >> +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0 >> +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MAX 0x7 >> +#define ID_AA64MMFR0_TGRAN64_NI 0xf >> +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0 >> +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MAX 0x7 >> +#define ID_AA64MMFR0_TGRAN16_NI 0x0 >> +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MIN 0x1 >> +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MAX 0xf >> + >> +#define ID_AA64MMFR0_PARANGE_32 0x0 >> +#define ID_AA64MMFR0_PARANGE_36 0x1 >> +#define ID_AA64MMFR0_PARANGE_40 0x2 >> +#define ID_AA64MMFR0_PARANGE_42 0x3 >> +#define ID_AA64MMFR0_PARANGE_44 0x4 >> #define ID_AA64MMFR0_PARANGE_48 0x5 >> #define ID_AA64MMFR0_PARANGE_52 0x6 >>=20 >> +#define ARM64_MIN_PARANGE_BITS 32 >> + >> +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_DEFAULT 0x0 >> +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_NONE 0x1 >> +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MIN 0x2 >> +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MAX 0x7 >> + >> /* id_aa64mmfr1 */ >> #define ID_AA64MMFR1_ECBHB_SHIFT 60 >> +#define ID_AA64MMFR1_AFP_SHIFT 44 >> #define ID_AA64MMFR1_ETS_SHIFT 36 >> #define ID_AA64MMFR1_TWED_SHIFT 32 >> #define ID_AA64MMFR1_XNX_SHIFT 28 >> @@ -271,6 +315,9 @@ >> #define ID_AA64MMFR2_CNP_SHIFT 0 >>=20 >> /* id_aa64dfr0 */ >> +#define ID_AA64DFR0_MTPMU_SHIFT 48 >> +#define ID_AA64DFR0_TRBE_SHIFT 44 >> +#define ID_AA64DFR0_TRACE_FILT_SHIFT 40 >> #define ID_AA64DFR0_DOUBLELOCK_SHIFT 36 >> #define ID_AA64DFR0_PMSVER_SHIFT 32 >> #define ID_AA64DFR0_CTX_CMPS_SHIFT 28 >> @@ -284,11 +331,18 @@ >> #define ID_AA64DFR0_PMUVER_8_1 0x4 >> #define ID_AA64DFR0_PMUVER_8_4 0x5 >> #define ID_AA64DFR0_PMUVER_8_5 0x6 >> +#define ID_AA64DFR0_PMUVER_8_7 0x7 >> #define ID_AA64DFR0_PMUVER_IMP_DEF 0xf >>=20 >> +#define ID_AA64DFR0_PMSVER_8_2 0x1 >> +#define ID_AA64DFR0_PMSVER_8_3 0x2 >> + >> #define ID_DFR0_PERFMON_SHIFT 24 >>=20 >> -#define ID_DFR0_PERFMON_8_1 0x4 >> +#define ID_DFR0_PERFMON_8_0 0x3 >> +#define ID_DFR0_PERFMON_8_1 0x4 >> +#define ID_DFR0_PERFMON_8_4 0x5 >> +#define ID_DFR0_PERFMON_8_5 0x6 >>=20 >> #define ID_ISAR4_SWP_FRAC_SHIFT 28 >> #define ID_ISAR4_PSR_M_SHIFT 24 >> diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/includ= e/asm/cpufeature.h >> index f7368766c0..4719de47f3 100644 >> --- a/xen/arch/arm/include/asm/cpufeature.h >> +++ b/xen/arch/arm/include/asm/cpufeature.h >> @@ -230,6 +230,7 @@ struct cpuinfo_arm { >> union { >> register_t bits[3]; >> struct { >> + /* MMFR0 */ >> unsigned long pa_range:4; >> unsigned long asid_bits:4; >> unsigned long bigend:4; >> @@ -240,16 +241,21 @@ struct cpuinfo_arm { >> unsigned long tgranule_4K:4; >> unsigned long __res0:32; >>=20 >> + /* MMFR1 */ >> unsigned long hafdbs:4; >> unsigned long vmid_bits:4; >> unsigned long vh:4; >> unsigned long hpds:4; >> unsigned long lo:4; >> unsigned long pan:4; >> - unsigned long __res1:8; >> - unsigned long __res2:28; >> + unsigned long specsei:4; >> + unsigned long xnx:4; >> + unsigned long twed:4; >> + unsigned long ets:4; >> + unsigned long __res1:20; >=20 > We might as well complete the fields by also adding hcx, afp, ntlbpa, > tidcp1, cmow. What do you think? Ok. >=20 >=20 >> unsigned long ecbhb:4; >>=20 >> + /* MMFR2 */ >> unsigned long __res3:64; >> }; >> } mm64; >> @@ -293,7 +299,9 @@ struct cpuinfo_arm { >> unsigned long __res2:8; >>=20 >> /* ISAR2 */ >> - unsigned long __res3:28; >> + unsigned long wfxt:4; >> + unsigned long rpres:4; >> + unsigned long __res3:20; >=20 > Also here we can add gpa3, apa3, mops, bc, and pac_frac? Ok. Cheers Bertrand >=20 >=20 >> unsigned long clearbhb:4; >>=20 >> unsigned long __res4:32; From xen-devel-bounces@lists.xenproject.org Wed May 11 14:58:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 14:58:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327022.549715 (Exim 4.92) (envelope-from ) id 1nonnB-0003D6-Dq; Wed, 11 May 2022 14:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327022.549715; Wed, 11 May 2022 14:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonnB-0003Cz-B4; Wed, 11 May 2022 14:58:21 +0000 Received: by outflank-mailman (input) for mailman id 327022; Wed, 11 May 2022 14:58:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonnA-0003Ct-0t for xen-devel@lists.xenproject.org; Wed, 11 May 2022 14:58:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0d::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca66f277-d13a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 16:58:18 +0200 (CEST) Received: from DB6PR0202CA0045.eurprd02.prod.outlook.com (2603:10a6:4:a5::31) by PA4PR08MB6078.eurprd08.prod.outlook.com (2603:10a6:102:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Wed, 11 May 2022 14:58:08 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::3c) by DB6PR0202CA0045.outlook.office365.com (2603:10a6:4:a5::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:58:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 14:58:08 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Wed, 11 May 2022 14:58:08 +0000 Received: from d521a7cde713.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ED9A6D0F-7AA2-4159-9937-109F8C9CF490.1; Wed, 11 May 2022 14:57:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d521a7cde713.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 14:57:57 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by DB6PR0802MB2200.eurprd08.prod.outlook.com (2603:10a6:4:83::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 14:57:56 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 14:57:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca66f277-d13a-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=juOP6K2fvmu3onDl7+QX5K+T0lbLN43Z/RTL+OMpBL3z8AsOS5/YZMZwARF7d/SJRBR7tcPrSq4bSrMqrz2KWO9l61O3TCnLF7UWjo6rfBdQmWEZVWde9Ahi9GqxJo6LeqFvVtLAkKe9bl95XL/5C1ywG5SKVOcpMlQ23pHuxOlm1U+/H4NlPw85xNETiECA0a1wbv/guOT9AUnMl6czREMB8w2ifTGZVBHzSSwl7clgsBozUvrTS1Mx6icQ63f5JdOWGhXNISaIShNFj0oO/PpYtmyAFLtCo+c977Llqi0Ihie5Z/2cSK8TgHU6Jbyx942Q4VnLl8OgmGinj0IEFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XLHtBLWkBOqd+gMLtMaMwYdsUIXaCyT1Ym12+p8w9Lc=; b=Aq/HQTq3k+JIKgNPtTQvMPzXKijk3XOMA+NkJCRZJnxhDOpytn2xD/8RFZkE95eUKnKIMZ7okXgfjcEbjk2NiZYCXDWhIUYbJROZ+5F4ondIIOJH3PcW6awyNW2LmS2KqaTfWgmLViFxL0EozspbxVujuMSc9b0B+cmm4TsZcYGtDjsD/2c1sAlvWHqx+TGkwHioISnJebU09RhHqIM0DqVWoAV8gm1Ztd22Ekh0AXMAG7tOEtyArufX1zv0Q19DvRC0QEQzS4vLaI1Gdut5zer082+nYZgPw5yRo4n858eqBg6FnfOxAjGJTPeqvvabN1qudzLFM8WLuFj+DNhmvw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XLHtBLWkBOqd+gMLtMaMwYdsUIXaCyT1Ym12+p8w9Lc=; b=W44cBJP3Qz6SZf3Pc2DemWGP8BX6nmTNRMzSgsgRlKZY6S9YrxwbJ/gyC6RzExHymANFtJNcu63sgCFWEds0UwLH03502uH5VH8TyUztZ6J81eAI7ewmKOvskUp2OId8c7U6qovYULLDUCTXC0FEnMfueDVaV089/uX76QhAmkw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 67e6f56e53907984 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+iwQ5UMjqzSMT27ngk+/Lx+RgIikTm0dfhEfWmPu/s13LNp9xDb9TBhJKOyXzjDb53q7cHy5QskCmHfOc4K5A94ZdALpnlfi7q5KN4kMNPC69vm/HWmWKrdSLr2ZAaweVMJh/anRxygoxtWTwyMK6X695cjb91SYKaijYEzPfwBeqYYaGAQW5VIdMBO6YGUCaIwQkf+39hbfHFgstbkX1VFIhRe09xu0nttD9RgSNxHnFAg9UcZiuliTiqb88/Utkbq431m9V1dTM3E+CLBeM4F2tbgttwmzOoK4EcxRjOo2xfW8+MvAtiYqdbQznLZIc55TlJN8GELMWVeYoW1JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XLHtBLWkBOqd+gMLtMaMwYdsUIXaCyT1Ym12+p8w9Lc=; b=OhChF3w6LHFLnj80rpsnUGFy4AclDmfSDjNgfreT4xg6m6qKS0UKsR9WWOVK2KI9GWEgUClTgZ6MlUhjdgt9bTiWuGKGuPFNVjZrkLs7DschFFKQEwZR01bIClhGRkVF0JtMLp76fDg14c3MMe1U0xTQFK73bAMC0eA+Bo7RONc4zynGhAM49mqXcCAtcydHJ97w5zyzvzLyGc7w4BEVqjkHygWEH3ICrViscDm6fdKed/mJRyCTR2L9MMexs+C3U2SzQDYdcFPIGLQkvODCxFhWQAZdwGnfmsx/GK8aOw4tkb/xfI4UP/iJoLqNckQ+F85Dkw8XmBnOUh2HQEtVkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XLHtBLWkBOqd+gMLtMaMwYdsUIXaCyT1Ym12+p8w9Lc=; b=W44cBJP3Qz6SZf3Pc2DemWGP8BX6nmTNRMzSgsgRlKZY6S9YrxwbJ/gyC6RzExHymANFtJNcu63sgCFWEds0UwLH03502uH5VH8TyUztZ6J81eAI7ewmKOvskUp2OId8c7U6qovYULLDUCTXC0FEnMfueDVaV089/uX76QhAmkw= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBWH2ZK8TL5ueU+mSOXui+uVga0YVmwAgAABRACAAP62gIAADosAgAACPoCAAAaAgIAAAkiAgAAaewCAACa3AIAAHamA Date: Wed, 11 May 2022 14:57:56 +0000 Message-ID: <3AC1200B-4F64-4828-8EAF-E6039E3613F1@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> <573e94c4-7de0-e442-c9d8-559b55ae3144@xen.org> In-Reply-To: <573e94c4-7de0-e442-c9d8-559b55ae3144@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9fc62071-adbc-4259-283b-08da335ea92c x-ms-traffictypediagnostic: DB6PR0802MB2200:EE_|DBAEUR03FT019:EE_|PA4PR08MB6078:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WWtjcqbVxfn/jrKNjHzCNscGVMlx5EpSCOLkqcQQt+T/FBOOItkFEVYVPZyJ+DLXpHbOAipLrLkJ/zjHDZO3dXuM1mXjUXandK3fSyyoXbxjs2PqlpQ2tl01t07gdPmoRr2UqcAvPYAY/Cst/bXJXUsFEOGTVG5tjxA5DD5DuOM35pcouYBKP/eVFZVK01TGPXTzacX/u+N1IXY01hDyxrrDyMhJjpJwqZarti4CNtGU7Y8W4c+hd90b+idoYvjN+JqbS3MyxR9D1sB8jR4Ja+iNPZyNRIUT85S/s9v04qc8A6zUFF2Xr4NC+h+it5VFTTt1aS+tOIIAZE6QUnll+5bxexKICc7Suj64u0+7rjrURqgSmCfj0qOcoylnChA6DtZu8h/zAfBZFtyiyugzBV9kO/sePhogQlOuZ0n7U1+vVGHKI8YrshwCzTuTOTHQ4pLMR5Woj9J1OY6JobDNmyQFOiunRi8f9vsRtoR4tbrYy/CG65sBhUorsqASai9oXM3TJAyojgiIpL1mELtCar0IJ+FYJedU0aMvNfk4VdTSQb5Xu6QI0yb/b5VAta+FponhoNLLb/Abj46WcjzDh7gPgaCp1M5DXL2adikhBRLGYpuGMF778BwkVqodM6cgEtujZpM8B/4KNFdce4/7tzaYpFTgbJCZVjwBeRXwlMzeN7WFLNpn2Gv+uB07c7QHIWyLTzwlY4vjhs2Sr9u0m88LhHk/yPo5akI0rZbGeGXz7Lb+7yb8TBXDQzonTR+sPdvPVcOUkz1aftkEcK12YA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(33656002)(53546011)(8936002)(71200400001)(6486002)(26005)(2616005)(5660300002)(66476007)(2906002)(186003)(54906003)(6916009)(38100700002)(66556008)(86362001)(316002)(36756003)(76116006)(122000001)(66946007)(91956017)(64756008)(83380400001)(508600001)(4326008)(66446008)(38070700005)(8676002)(6512007)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <4F9071E37D82D74A92BCB97B40214EB8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2200 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ebbb488f-bd42-4c0b-3030-08da335ea1d2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tbcbzJhPBaGOUl2a/KeF3NM9bzbVOgcU6m9Lfft3g0Hz2K2z7eKa/hPFKyXNw00JuUfQOisnZY4mQvkUN/beNjxC8p/w/gdXncnVKHdxq0J5JhxOukAsOeSyR8ZGhDnf28O3hLm6OfC+ofPOy6iOFOg2cHNo/ssg/Vta4VtqWS/eQSdFu6dhK2/nGydHvFbyIeo4KEon24FhOM6zUpwRHSWp2xJl6vq+AuMaD/O1ecWnK76gyCcWxXLKPvd1RdBbwY36A0quPHC5HHncYBwXwuehiovsnvouNXz51HDaFYzYn1m5okAsIawOzbtdla5P1TUI1b/n1M+T0IfQT5YWIlqIFuqopnF7TAIfaHlHM3NEi7LosMkLcNkSel0wyhJRPq4RKFsapMgPkqa8mkvxhXapgDyGebs9v3PyhlUcAP6KyXQQcCjF4cK7C/4K5gtslzLrXIfkxHIihaJUWopvQ29r0um38yEVl5YSLniSD4+rCpgc/2hFj6BpiCygTYBxtthBxfiDogiF2W0TsNmfj54ICk3rtSgSMKdpSR3GZ2CX9driSedxqt4G2f/Zcd7CPXGENOqcSj5HOU+mwb1odQXOppmcCAMZrzGRyMX9yilpnf7IoHGnH5I0anSE0/BofxSgO1LIooVQf7HiNLjFrUqALSu5uxe6kVOzcolCOVM/WphRXOEV/LXi6emPCWyu+xcjn75gj7ePGGA2eE5NsQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(2906002)(508600001)(356005)(36860700001)(6506007)(186003)(86362001)(8936002)(336012)(2616005)(107886003)(36756003)(6486002)(70206006)(54906003)(33656002)(26005)(70586007)(4326008)(8676002)(6512007)(316002)(40460700003)(6862004)(47076005)(53546011)(81166007)(82310400005)(83380400001)(5660300002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 14:58:08.4376 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc62071-adbc-4259-283b-08da335ea92c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6078 SGkgSnVsaWVuLA0KDQo+IE9uIDExIE1heSAyMDIyLCBhdCAyOjExIHBtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24gMTEvMDUv MjAyMiAxMTo1MywgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gT24gMTEgTWF5IDIwMjIsIGF0IDEw OjE4IGFtLCBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+IHdyb3Rl Og0KPj4+IA0KPj4+IEhpIEp1bGllbiwNCj4+PiANCj4+Pj4gT24gMTEgTWF5IDIwMjIsIGF0IDEw OjEwLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4gDQo+Pj4+IEhp IEJlcnRyYW5kLA0KPj4+PiANCj4+Pj4gT24gMTEvMDUvMjAyMiAwOTo0NiwgQmVydHJhbmQgTWFy cXVpcyB3cm90ZToNCj4+Pj4+PiBPbiAxMSBNYXkgMjAyMiwgYXQgMDk6MzgsIEp1bGllbiBHcmFs bCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+IA0KPj4+Pj4+IEhpIEJlcnRyYW5kLA0K Pj4+Pj4+IA0KPj4+Pj4+IE9uIDExLzA1LzIwMjIgMDg6NDYsIEJlcnRyYW5kIE1hcnF1aXMgd3Jv dGU6DQo+Pj4+Pj4+PiBPbiAxMCBNYXkgMjAyMiwgYXQgMTc6MzUsIEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBIaSBSYWh1bCwNCj4+Pj4+ Pj4+IA0KPj4+Pj4+Pj4gT24gMTAvMDUvMjAyMiAxNzozMCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+ Pj4+Pj4+Pj4+ICsgcmMgPSBldnRjaG5fYWxsb2NfdW5ib3VuZCgmYWxsb2MpOw0KPj4+Pj4+Pj4+ PiArIGlmICggcmMgKQ0KPj4+Pj4+Pj4+PiArIHsNCj4+Pj4+Pj4+Pj4gKyBwcmludGsoIkZhaWxl ZCBhbGxvY2F0aW5nIGV2ZW50IGNoYW5uZWwgZm9yIGRvbWFpblxuIik7DQo+Pj4+Pj4+Pj4+ICsg cmV0dXJuIHJjOw0KPj4+Pj4+Pj4+PiArIH0NCj4+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+PiArIGQt PmFyY2guaHZtLnBhcmFtc1tIVk1fUEFSQU1fU1RPUkVfRVZUQ0hOXSA9IGFsbG9jLnBvcnQ7DQo+ Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4gKyByZXR1cm4gMDsNCj4+Pj4+Pj4+Pj4gK30NCj4+Pj4+ Pj4+Pj4gKw0KPj4+Pj4+Pj4+PiBzdGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1 Y3QgZG9tYWluICpkLA0KPj4+Pj4+Pj4+PiBjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5v ZGUpDQo+Pj4+Pj4+Pj4+IHsNCj4+Pj4+Pj4+Pj4gQEAgLTMyMTQsNiArMzI0MywxNCBAQCBzdGF0 aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWluICpkLA0KPj4+Pj4+Pj4+ PiBpZiAoIHJjIDwgMCApDQo+Pj4+Pj4+Pj4+IHJldHVybiByYzsNCj4+Pj4+Pj4+Pj4gDQo+Pj4+ Pj4+Pj4+ICsgaWYgKCBraW5mby5kb20wbGVzc19lbmhhbmNlZCApDQo+Pj4+Pj4+Pj4gSSB0aGlu ayB3ZSBuZWVkIHRvIGRvIHNvbWV0aGluZyBsaWtlIHRoaXMgdG8gZml4IHRoZSBlcnJvci4NCj4+ Pj4+Pj4+PiBpZiAoIGhhcmR3YXJlX2RvbWFpbiAmJiBraW5mby5kb20wbGVzc19lbmhhbmNlZCAp DQo+Pj4+Pj4+Pj4gew0KPj4+Pj4+Pj4+IH0NCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gSXMgdGhlcmUg YW55IHVzZSBjYXNlIHRvIHVzZSAiZG9tMGxlc3NfZW5oYW5jZWQiIHdpdGhvdXQgZG9tMCAob3Ig YSBkb21haW4gc2VydmljaW5nIFhlbnN0b3JlZCk/DQo+Pj4+Pj4+PiANCj4+Pj4+Pj4gSnVzdCBi ZWluZyBjdXJpb3VzIGhlcmUgYnV0IHdvdWxkIGl0IGV2ZW4gYmUgcG9zc2libGUgdG8gaGF2ZSBu b24gZG9tMCBkb21haW4gc2VydmljaW5nIHhlbnN0b3JlZCA/DQo+Pj4+Pj4gDQo+Pj4+Pj4gWW91 IGNhbiBidWlsZCBYZW5zdG9yZWQgYWdhaW5zdCBtaW5pLW9zIGFuZCBjb25maWd1cmUgdGhlIGlu aXQgc2NyaXB0IHRvIGxhdW5jaCB4ZW5zdG9yZWQgYXMgYSBkb21haW4uDQo+Pj4+PiBTbyBkb20w IGlzIG5vdCBtYW5kYXRvcnkgb3Igc2hvdWxkIG1pbmktb3MgYmUgc3RhcnRlZCBhcyBEb20wIGZv ciB0aGlzIHRvIHdvcmsgPw0KPj4+PiANCj4+Pj4gSW4gb3JkZXIgdG8gYWxsb2NhdGUgdGhlIGV2 ZW50IGNoYW5uZWwsIHlvdSBuZWVkIHRvIGtub3cgdGhlIElEIG9mIHRoZSBkb21haW4gd2hlcmUg WGVuc3RvcmVkIHdpbGwgcnVuLiBTdGVmYW5vJ3MgcGF0Y2ggaXMgcmVseWluZyBvbiBYZW5zdG9y ZWQgdG8gYmUgcnVuIGluIERvbWFpbiAwLg0KPj4+PiANCj4+Pj4gVGhpcyB3b3VsZCBuZWVkIHRv IGJlIHVwZGF0ZWQgaWYgd2Ugd2FudCB0byBydW4gaXQgaW4gYSBzZXBhcmF0ZSBkb21haW4uDQo+ Pj4gDQo+Pj4gT2sgdGhlbiBEb20wIGlzIG1hbmRhdG9yeSBhdCB0aGUgbW9tZW50LCBJIGFtIG9r IHdpdGggdGhhdC4NCj4+PiANCj4+Pj4gDQo+Pj4+Pj4gDQo+Pj4+Pj4+PiBJZiBub3QsIHRoZW4g SSB3b3VsZCBjb25zaWRlciB0byBmb3JiaWQgdGhpcyBjYXNlIGFuZCByZXR1cm4gYW4gZXJyb3Iu DQo+Pj4+Pj4+IE9uZSB3YXkgb3IgYW4gb3RoZXIgd2UgbmVlZCB0byBzb2x2ZSB0aGUgY3Jhc2gg YnV0IGlmIGl0IGlzIGZvcmJpZGRlbiB3ZSBtdXN0IHByZXZlbnQgY29taW5nIHRvIHRoaXMgc3Rl cCBlYXJsaWVyIGFzIGl0IG1lYW5zIHRoZSBjb25maWd1cmF0aW9uIGlzIHdyb25nLg0KPj4+Pj4+ IA0KPj4+Pj4+IEkgdGhpbmsgdGhpcyBzaG91bGQgYmUgY2hlY2tlZCB3aGVuIHBhcnNpbmcgdGhl IGNvbmZpZ3VyYXRpb24uDQo+Pj4+PiBJZiBkb20wIGlzIG1hbmRhdG9yeSB5ZXMsIHdlIHNob3Vs ZCBzdGlsbCBtYWtlIHN1cmUgdGhhdCB0aGlzIGNvZGUgY2Fubm90IGJlIHJlYWNoZWQgc28gYW4g QVNTRVJUIHdvdWxkIGJlIG5pY2UgaGVyZSBhdCBsZWFzdCBpbiBjYXNlIHNvbWVvbmUgdHJpZXMg dG8gYWN0aXZhdGUgdGhpcyBjb2RlIHdpdGhvdXQgZG9tMCAod2hpY2ggbWlnaHQgaGFwcGVuIHdo ZW4gd2Ugd2lsbCBwdXNoIHRoZSBzZXJpZSBmb3Igc3RhdGljIGV2ZW50IGNoYW5uZWxzKS4NCj4+ Pj4gDQo+Pj4+IEkgYW0gZmluZSB3aXRoIGFuIEFTU0VSVCgpLg0KPj4+PiANCj4+Pj4gQXJlIHlv dSBzYXlpbmcgdGhhdCBkb20wbGVzc19lbmhhbmNlZCB3aWxsIGJlIHNldCB0byB0cnVlIGZvciB0 aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwgc2VyaWVzPw0KPj4+PiANCj4+Pj4gSWYgeWVzLCB0aGVu IEkgdGhpbmsgZG9tMGxlc3NfZW5oYW5jZWQgd2lsbCBuZWVkIHRvIGJlIGFuIGVudW0gc28gd2Ug a25vdyB3aGF0IHBhcnQgb2YgWGVuIGlzIGV4cG9zZWQuDQo+Pj4gDQo+Pj4gTm8gaXQgd29u4oCZ dCwgd2UganVzdCBuZWVkIHNvbWUgb2YgdGhlIGNoYW5nZXMgZG9uZSBidXQgd2l0aG91dCBzZXR0 aW5nIGRvbTBsZXNzX2VuaGFuY2VkLg0KPj4+IEBSYWh1bDogY2FuIHlvdSBjb25maXJtLg0KPj4+ IA0KPj4gV2UgbmVlZCB0byBzZXQgdGhlICJ4ZW4sZW5oYW5jZWTigJ0gZW5hYmxlZCBmb3IgZG9t MGxlc3MgZG9tVSB0byBlbmFibGUNCj4+IHRoZSBldmVudC1jaGFubmVsIGludGVyZmFjZSBpbiBk b20wbGVzcyBndWVzdC4gSWYgd2UgZGlkIG5vdCBzZXQgdGhpcyBwcm9wZXJ0eSB3ZSBjYW7igJl0 DQo+PiB1c2UgdGhlIGV2ZW50LWNoYW5uZWwgaW50ZXJmYWNlIGluIGRvbTBsZXNzIGRvbVVzIGd1 ZXN0cy4NCj4gDQo+IElzIHRoaXMgYmVjYXVzZSB0aGUgZG9tVSB3aWxsIG5vdCBrbm93IHdoaWNo IFBQSSB3aWxsIGJlIHVzZWQgZm9yIG5vdGlmaWNhdGlvbj8NCg0KWWVzIHlvdSBhcmUgcmlnaHQg aWYgd2UgZG9u4oCZdCB1c2UgInhlbixlbmhhbmNlZOKAnSBmb3IgZG9tVXMsIGRvbVVzIHdpbGwg bm90IGtub3cgd2hpY2ggUFBJIHdpbGwgYmUgdXNlZC4NCkFsc28gaWYgd2UgZG9u4oCZdCB1c2Ug InhlbixlbmhhbmNlZOKAnSAgdGhlcmUgaXMgbm8gaHlwZXJ2aXNvciBub2RlIGNyZWF0ZWQgZm9y IExpbnV4IGFuZCBpZiB0aGVyZSBpcw0Kbm8gaHlwZXJ2aXNvciBub2RlIHRoYXQgbWVhbnMgbm8g eGVuIHN1cHBvcnQgZGV0ZWN0ZWQuDQoNCj4gDQo+IFRoZSBwcm9wZXJ0eSAieGVuLGVuaGFuY2Vk IiB3aXRoIGFuIGVtcHR5IHN0cmluZyAob3Igd2l0aCB0aGUgdmFsdWUgImVuYWJsZWQiKSBpcyBt ZWFudCB0byBpbmRpY2F0ZSB0aGF0IFBWIGRyaXZlcnMgd2lsbCBiZSB1c2FibGUgaW4gdGhlIGRv bWFpbi4NCj4gDQo+IEFGQUlVLCB5b3UgYXJlIHN1Z2dlc3RpbmcgdG8gY2hhbmdlIHRoZSBtZWFu aW5nIGJhc2VkIG9uIGRvbTAgd2hldGhlciBoYXMgYmVlbiBjcmVhdGVkLiBJIGRvbid0IHBhcnRp Y3VsYXJseSBsaWtlIHRoYXQgYmVjYXVzZSBhIHVzZXIgbWF5IHNwZW50IGEgd2hpbGUgdG8gdW5k ZXJzdGFuZCB3aHkgWGVuc3RvcmVkIGRvZXNuJ3Qgd29yay4NCj4gDQo+IFRoZSBjdXJyZW50IHBy b3Bvc2FsIGZvciB4ZW4sZW5oYW5jZWQgYWxsb3dzIHVzIHRvIGRlZmluZSBuZXcgdmFsdWVzIGlm IHdlIHdhbnRlZCB0byBvbmx5IGVuYWJsZWQgc2VsZWN0ZWQgaW50ZXJmYWNlcy4gQUZBSVUsIGlu IHlvdXIgY2FzZSwgeW91IG9ubHkgd2FudCB0byBleHBvc2UgdGhlIGV2ZW50IGNoYW5uZWwgaW50 ZXJmYWNlLCBzbyBJIHdvdWxkIGNyZWF0ZSBhIG5ldyB2YWx1ZSB0byBpbmRpY2F0ZSB0aGF0IHRo ZSBldmVudCBjaGFubmVsIGludGVyZmFjZSBpcyBleHBvc2VkLiBYZW4gd291bGQgdGhlbiBjcmVh dGUgb25seSB0aGUgcGFydCBmb3IgdGhlIGV2ZW50IGNoYW5uZWwgKGkuZS4gbm8gZXh0ZW5kZWQg cmVnaW9ucywgZ3JhbnQgdGFibGVzLi4uKS4NCg0KT2suIEkgd2lsbCBjcmVhdGUgdGhlIG5ldyBw cm9wZXJ0eSBzb21ldGhpbmcgbGlrZSDigJx4ZW4sZXZ0Y2hu4oCdIHRvIGVuYWJsZSB0aGUgZXZl bnQtY2hhbm5lbCBmb3IgZG9tMGxlc3MgZ3Vlc3RzLiANCkJhc2VkIG9uIOKAnHhlbixldnRjaG7i gJ0gcHJvcGVydHkgSSB3aWxsIGNyZWF0ZSB0aGUgaHlwZXJ2aXNvciBub2RlIHdpdGggb25seSBQ UEkgaW50ZXJydXB0IHByb3BlcnR5Lg0KDQpSZWdhcmRzLA0KUmFodWwNCg0K From xen-devel-bounces@lists.xenproject.org Wed May 11 15:05:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:05:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327029.549727 (Exim 4.92) (envelope-from ) id 1nonuF-0004hZ-9i; Wed, 11 May 2022 15:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327029.549727; Wed, 11 May 2022 15:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonuF-0004hS-5o; Wed, 11 May 2022 15:05:39 +0000 Received: by outflank-mailman (input) for mailman id 327029; Wed, 11 May 2022 15:05:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nonuE-0004hM-6t for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:05:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0d::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cff36aa6-d13b-11ec-a406-831a346695d4; Wed, 11 May 2022 17:05:36 +0200 (CEST) Received: from DB8PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:100::35) by VI1PR0801MB1967.eurprd08.prod.outlook.com (2603:10a6:800:8c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 15:05:33 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::1a) by DB8PR06CA0022.outlook.office365.com (2603:10a6:10:100::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22 via Frontend Transport; Wed, 11 May 2022 15:05:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 15:05:33 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Wed, 11 May 2022 15:05:33 +0000 Received: from b0417f0c1586.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA740A1C-4BFB-4FE0-ADAE-C1D33EBB52A3.1; Wed, 11 May 2022 15:05:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0417f0c1586.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 15:05:23 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by DB6PR0802MB2584.eurprd08.prod.outlook.com (2603:10a6:4:98::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 15:05:18 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 15:05:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cff36aa6-d13b-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bDTU5/kPdju0f6fLOdVmvPLX4/95Vc9IH3CDdI1XpxoKBTXfqv2Ijudyaq++uAZyDfTPh7iBLHpUP7JyaXQIqotGO6GWUAz//mW8SmmIKtuD3BpjELtS79zds44OPd8DiOde8GYGo+AuPa7ACJGurEn7IvuA8rfm6zOv1PUl2StteJStSBOw45epxj+dIIhH8j+anOwwVg+szZHQvQ656hM03UEU7HDR0vEPJPJ1vGryWh88oi7djNQI+aBllzVfYof15aJXmaYPOKROaAusybYuj+hI2bPEmyt4RJDMtnu6aB5nOTRS5vCDuSrhu0JG89zaRYgkW8gd3VssERYjzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DiVtsKq0aqMUvBp7T3Ah9PZjuVixHInPTeLLx/d+cLI=; b=oOu4QMznXbLgpD7p9KWHu1CuKfUKcnV8HI6UGCdqtpwoHiNDtibTOJTF1bWI3/mxb1RKE3Y6WgvVVMtVWYzMNdKnCuI8duLMPu3rBOzigmpF2d/35XpsgGTvs8k6dErXUJm+c44WdSlUltgapUXII0LCms4DP6oLeDA8o3tBdClVQSJwyCe18FwmtpHWomhIBhQusCNHzg6v3JqorsUCOizni9qFH7AB+Ut2YdtmCdWA21SxhOx/OdN5IxrsMTyz0PCZ9gRAPPL+OeJLNP5llbgS73jUJSzbWpFBNhSy7LtT6HecAn2/w8T/bxRSAioWQQ8AbE7Wjih66Siv/3WKEw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DiVtsKq0aqMUvBp7T3Ah9PZjuVixHInPTeLLx/d+cLI=; b=7dURc6LjmVYbB1FMQFu4cYRP/z9H4l3T9iAmr6DhzSQXA9fVKbxdLYcY4U8DGqQgdhHhOVhIRXyUAGd0eHEAMQyfRSTaOvqR7jMyrQiHdaZ/3BGQl/8e18TCW6RrpYsp+faSq1936hDjubp0YUiXKgHUqt466XSHU/0k1WevMng= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a5bb1cb6f6a2461 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FyfXWSNEVvf+DS5CJ7VFxmjmVIUuDVTDcsDd8zoTcUunMjW/EB0P/kvtUvqE/dFweae+aTCX/4SP/JXr1OXDN7Vo4koVRk2bZWnx+pMDBMydVJ2B0Wmh/howpOAujMbPee4Fr+XifOKN51km82sNF5H/p4egiKEz77IIOYqkDGdxIg/EgIct18PKQDTZKQjsrW10JSCw/JzSlUDwckTOcLNiwnraBnDno/4NMoMhTMPx1c4cTM5cFZpKzCq89pcxQ/3Y5Ah2hQtccipn/eQLn40LC/dgFH2hADDR4dmwM31YdcmKAuh4Aupl8Z+0y+6oA0VkciD7YOG1IrCuJ0i8MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DiVtsKq0aqMUvBp7T3Ah9PZjuVixHInPTeLLx/d+cLI=; b=TKSCT1xl9F3Z0uGQeQnWQlIslnIPvrJV0KSz1sjkq8Q3+GM0BiQT9Np/Bfs3mUuDieDb+kmPuOUcLtPWPuSoQuYHsqiFzJikACY0mwtb53Scn0K4FSAOQ7NBT88NZ6t3/bvT4zJwA+md0GQvL1G8tLGF5B7QGl6pmA9gm8z4Q73t9F5RQAS5pMpjg2+dE8S5HcwTloO7mHhpQkc+KPQ9eYEfa3C22HcUVccQIioOrHFzoxCx8vRhmA3t6VFx7ZZUgVJg+kFv/tZXt24TuJQs6k2y6LafMULPYjPs6tXhBTZcfEryUPVqaWB9m2f5O2x77EMZVBgqLZBPV0DyiEng9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DiVtsKq0aqMUvBp7T3Ah9PZjuVixHInPTeLLx/d+cLI=; b=7dURc6LjmVYbB1FMQFu4cYRP/z9H4l3T9iAmr6DhzSQXA9fVKbxdLYcY4U8DGqQgdhHhOVhIRXyUAGd0eHEAMQyfRSTaOvqR7jMyrQiHdaZ/3BGQl/8e18TCW6RrpYsp+faSq1936hDjubp0YUiXKgHUqt466XSHU/0k1WevMng= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Topic: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Thread-Index: AQHYYBWH2ZK8TL5ueU+mSOXui+uVga0YVmwAgAABRACAAP62gIAADosAgAACPoCAAAaAgIAAAkiAgAAaewCAACa3AIAAHamAgAACD4A= Date: Wed, 11 May 2022 15:05:18 +0000 Message-ID: <4D04ACBD-014A-4A74-8B2C-6BCFB8D562A0@arm.com> References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> <573e94c4-7de0-e442-c9d8-559b55ae3144@xen.org> <3AC1200B-4F64-4828-8EAF-E6039E3613F1@arm.com> In-Reply-To: <3AC1200B-4F64-4828-8EAF-E6039E3613F1@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: af18c998-2d37-4ea4-75fe-08da335fb22e x-ms-traffictypediagnostic: DB6PR0802MB2584:EE_|DBAEUR03FT043:EE_|VI1PR0801MB1967:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dkoTFcR+YFbLsdVZC1LJbkH7jQQ9ZO88e6OnqBhScyWhS/nt4ZnJeHG3sSI+89yn3MpPhRmHZb+Xl7uV+vaiu0h5eqotUqtxl07Gr0KDg+NzhwpV6IgnDAwBQcwXAjPs4FoNAeLMOu6eZ4I+MZtDN4pxDf355grqAlZAre7Z0BboD83r9KOTQSpeYAfVpNANUcFXlwgl0L2XBjdY9v+W3uG2ZW3apIG86Q3gia+/XApqjowl0otkR9h/lNoQ+nRgj78yIRnxWuZ4GxmdYculg7BenTTjXsVobNYix5neTrzheU/JIWa5mplI6klHdGkVpGnEMlHbiRwXnMYBRZK6BjgddiBvD2Ugpd3yz9f2YUYK+Jo9ZzxairSrE0ZsfTwrfxMIlC1WYUg7R2tGx+qF7FwcW0WVy27dJZYIbvQrBpEeiGqII0DNEI9DEd8tc9R9YUYRATInpRx17dZ56f2JC3qkHRDs2kr6TEeS0nuSgQSTSlB2ZqKLQGpEor7NyP0iv1ZHkn62dzAbiTZ/dY0HUSKx9MUnlOQmcH8Cjp3jTpvPYt2UWyabkyXNNBHunUFGC9GjiMHoMrA8Qr5JjaTXCDW+h1NA2RJZCvrdr2TZSfCZU1oAaTp35wbZGnrf5IBnsQmu3D3wOSa38jKf35kzmP4DjW8pVn0qiz9Q2o0to1MetE9n2LBC5/nTKHlRV9yOuUHRBZy36nxEOPYA97FuRdi+ZBtjBsUdutwA6AveBUFwHYqN+z/vCH+mNJ7+9gkwWpYbQ8TJziuhM8U82o3qkw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(54906003)(38100700002)(8936002)(2906002)(33656002)(508600001)(6486002)(2616005)(5660300002)(6916009)(316002)(36756003)(186003)(122000001)(6506007)(86362001)(66556008)(4326008)(8676002)(76116006)(66446008)(66946007)(26005)(64756008)(66476007)(6512007)(91956017)(83380400001)(53546011)(71200400001)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <2E96C8BF2DB4DC449E93F402CBE901A2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2584 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 15f85347-aaf9-4576-e580-08da335fa961 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ab1CnpLAxGo/pn0QjuzDvDBmFcDYJ/mjPN9KGqommDkwyCb9eWWpRxlOxtHcO7oIaoYFpVSyzYubaGh8Iku0oEPBn4WY9853pvAwR2pEx9y4cmJpuBMKxpZXIT+wjg/myrZrwaKup+p2c8UCzLQfwXvwtWouffoxKcYTFdXPZWjNSh/30kgv5BMqnEeOTe+Ea41IP79ySWdd6lAody9mmxx/fwE358S/Ir6mgxNfO+z9OcsgwUeWybDoZBL1cbsKuozBVTVk/LJWJr7gYKtJllrWxBIEDg/fQbpt236vcjod/EKM85C8VgyQMm/M9kL0lWAXAEpKEO+eF7zTbCJ59tt6T2CpI5JvMNXrJbtvRuoeCB4dLbcIEpjEHl4ePdN9+rBAA+YYGUnnG96UEU4ES0/pZSYC9sYpa8aFKHXYYmkI5oM52BoqMGU1RVc2VEdQ8Bvtz4XgZKjS8m59scthj6h8ZMMKzG2niqhjay0Iw17noUWFHkD56Kx0BaSLPi1xNdJQaz46DpAbf3mz0kHYoqg/Sb6jQYgUGgBiMzbwKQwOq/zIeeZAc6O9xvtmY6PlfDvl5a2j4s5meKwwxDUHT7NmG1HqsoiB6Mqeat0HzUYxa3QIkj6rYvdW3Y1tmkqdFZaxUCLiPSNwJ2cDdqHck2+E3VObT6v341M60YWLDVgq8BL8+S7z+mMETSCJJ5ae7em4zkSAJpP/dVVfVkIfww== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(186003)(47076005)(70206006)(70586007)(36756003)(336012)(36860700001)(33656002)(82310400005)(6862004)(8936002)(26005)(83380400001)(5660300002)(2616005)(40460700003)(6512007)(4326008)(107886003)(8676002)(86362001)(508600001)(6506007)(54906003)(53546011)(6486002)(2906002)(81166007)(316002)(356005)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 15:05:33.0489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af18c998-2d37-4ea4-75fe-08da335fb22e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1967 SGkgSnVsaWVuLA0KDQo+IE9uIDExIE1heSAyMDIyLCBhdCAzOjU3IHBtLCBSYWh1bCBTaW5naCA8 UmFodWwuU2luZ2hAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBKdWxpZW4sDQo+IA0KPj4gT24g MTEgTWF5IDIwMjIsIGF0IDI6MTEgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdy b3RlOg0KPj4gDQo+PiBIaSBSYWh1bCwNCj4+IA0KPj4gT24gMTEvMDUvMjAyMiAxMTo1MywgUmFo dWwgU2luZ2ggd3JvdGU6DQo+Pj4+IE9uIDExIE1heSAyMDIyLCBhdCAxMDoxOCBhbSwgQmVydHJh bmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPiB3cm90ZToNCj4+Pj4gDQo+Pj4+ IEhpIEp1bGllbiwNCj4+Pj4gDQo+Pj4+PiBPbiAxMSBNYXkgMjAyMiwgYXQgMTA6MTAsIEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiBIaSBCZXJ0cmFu ZCwNCj4+Pj4+IA0KPj4+Pj4gT24gMTEvMDUvMjAyMiAwOTo0NiwgQmVydHJhbmQgTWFycXVpcyB3 cm90ZToNCj4+Pj4+Pj4gT24gMTEgTWF5IDIwMjIsIGF0IDA5OjM4LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IEhpIEJlcnRyYW5kLA0KPj4+ Pj4+PiANCj4+Pj4+Pj4gT24gMTEvMDUvMjAyMiAwODo0NiwgQmVydHJhbmQgTWFycXVpcyB3cm90 ZToNCj4+Pj4+Pj4+PiBPbiAxMCBNYXkgMjAyMiwgYXQgMTc6MzUsIEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+IEhpIFJhaHVsLA0KPj4+ Pj4+Pj4+IA0KPj4+Pj4+Pj4+IE9uIDEwLzA1LzIwMjIgMTc6MzAsIFJhaHVsIFNpbmdoIHdyb3Rl Og0KPj4+Pj4+Pj4+Pj4gKyByYyA9IGV2dGNobl9hbGxvY191bmJvdW5kKCZhbGxvYyk7DQo+Pj4+ Pj4+Pj4+PiArIGlmICggcmMgKQ0KPj4+Pj4+Pj4+Pj4gKyB7DQo+Pj4+Pj4+Pj4+PiArIHByaW50 aygiRmFpbGVkIGFsbG9jYXRpbmcgZXZlbnQgY2hhbm5lbCBmb3IgZG9tYWluXG4iKTsNCj4+Pj4+ Pj4+Pj4+ICsgcmV0dXJuIHJjOw0KPj4+Pj4+Pj4+Pj4gKyB9DQo+Pj4+Pj4+Pj4+PiArDQo+Pj4+ Pj4+Pj4+PiArIGQtPmFyY2guaHZtLnBhcmFtc1tIVk1fUEFSQU1fU1RPUkVfRVZUQ0hOXSA9IGFs bG9jLnBvcnQ7DQo+Pj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4+PiArIHJldHVybiAwOw0KPj4+Pj4+ Pj4+Pj4gK30NCj4+Pj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+Pj4+IHN0YXRpYyBpbnQgX19pbml0IGNv bnN0cnVjdF9kb21VKHN0cnVjdCBkb21haW4gKmQsDQo+Pj4+Pj4+Pj4+PiBjb25zdCBzdHJ1Y3Qg ZHRfZGV2aWNlX25vZGUgKm5vZGUpDQo+Pj4+Pj4+Pj4+PiB7DQo+Pj4+Pj4+Pj4+PiBAQCAtMzIx NCw2ICszMjQzLDE0IEBAIHN0YXRpYyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21VKHN0cnVjdCBk b21haW4gKmQsDQo+Pj4+Pj4+Pj4+PiBpZiAoIHJjIDwgMCApDQo+Pj4+Pj4+Pj4+PiByZXR1cm4g cmM7DQo+Pj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+Pj4+ICsgaWYgKCBraW5mby5kb20wbGVzc19lbmhh bmNlZCApDQo+Pj4+Pj4+Pj4+IEkgdGhpbmsgd2UgbmVlZCB0byBkbyBzb21ldGhpbmcgbGlrZSB0 aGlzIHRvIGZpeCB0aGUgZXJyb3IuDQo+Pj4+Pj4+Pj4+IGlmICggaGFyZHdhcmVfZG9tYWluICYm IGtpbmZvLmRvbTBsZXNzX2VuaGFuY2VkICkNCj4+Pj4+Pj4+Pj4gew0KPj4+Pj4+Pj4+PiB9DQo+ Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gSXMgdGhlcmUgYW55IHVzZSBjYXNlIHRvIHVzZSAiZG9tMGxl c3NfZW5oYW5jZWQiIHdpdGhvdXQgZG9tMCAob3IgYSBkb21haW4gc2VydmljaW5nIFhlbnN0b3Jl ZCk/DQo+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBKdXN0IGJlaW5nIGN1cmlvdXMgaGVyZSBidXQgd291 bGQgaXQgZXZlbiBiZSBwb3NzaWJsZSB0byBoYXZlIG5vbiBkb20wIGRvbWFpbiBzZXJ2aWNpbmcg eGVuc3RvcmVkID8NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IFlvdSBjYW4gYnVpbGQgWGVuc3RvcmVkIGFn YWluc3QgbWluaS1vcyBhbmQgY29uZmlndXJlIHRoZSBpbml0IHNjcmlwdCB0byBsYXVuY2ggeGVu c3RvcmVkIGFzIGEgZG9tYWluLg0KPj4+Pj4+IFNvIGRvbTAgaXMgbm90IG1hbmRhdG9yeSBvciBz aG91bGQgbWluaS1vcyBiZSBzdGFydGVkIGFzIERvbTAgZm9yIHRoaXMgdG8gd29yayA/DQo+Pj4+ PiANCj4+Pj4+IEluIG9yZGVyIHRvIGFsbG9jYXRlIHRoZSBldmVudCBjaGFubmVsLCB5b3UgbmVl ZCB0byBrbm93IHRoZSBJRCBvZiB0aGUgZG9tYWluIHdoZXJlIFhlbnN0b3JlZCB3aWxsIHJ1bi4g U3RlZmFubydzIHBhdGNoIGlzIHJlbHlpbmcgb24gWGVuc3RvcmVkIHRvIGJlIHJ1biBpbiBEb21h aW4gMC4NCj4+Pj4+IA0KPj4+Pj4gVGhpcyB3b3VsZCBuZWVkIHRvIGJlIHVwZGF0ZWQgaWYgd2Ug d2FudCB0byBydW4gaXQgaW4gYSBzZXBhcmF0ZSBkb21haW4uDQo+Pj4+IA0KPj4+PiBPayB0aGVu IERvbTAgaXMgbWFuZGF0b3J5IGF0IHRoZSBtb21lbnQsIEkgYW0gb2sgd2l0aCB0aGF0Lg0KPj4+ PiANCj4+Pj4+IA0KPj4+Pj4+PiANCj4+Pj4+Pj4+PiBJZiBub3QsIHRoZW4gSSB3b3VsZCBjb25z aWRlciB0byBmb3JiaWQgdGhpcyBjYXNlIGFuZCByZXR1cm4gYW4gZXJyb3IuDQo+Pj4+Pj4+PiBP bmUgd2F5IG9yIGFuIG90aGVyIHdlIG5lZWQgdG8gc29sdmUgdGhlIGNyYXNoIGJ1dCBpZiBpdCBp cyBmb3JiaWRkZW4gd2UgbXVzdCBwcmV2ZW50IGNvbWluZyB0byB0aGlzIHN0ZXAgZWFybGllciBh cyBpdCBtZWFucyB0aGUgY29uZmlndXJhdGlvbiBpcyB3cm9uZy4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+ IEkgdGhpbmsgdGhpcyBzaG91bGQgYmUgY2hlY2tlZCB3aGVuIHBhcnNpbmcgdGhlIGNvbmZpZ3Vy YXRpb24uDQo+Pj4+Pj4gSWYgZG9tMCBpcyBtYW5kYXRvcnkgeWVzLCB3ZSBzaG91bGQgc3RpbGwg bWFrZSBzdXJlIHRoYXQgdGhpcyBjb2RlIGNhbm5vdCBiZSByZWFjaGVkIHNvIGFuIEFTU0VSVCB3 b3VsZCBiZSBuaWNlIGhlcmUgYXQgbGVhc3QgaW4gY2FzZSBzb21lb25lIHRyaWVzIHRvIGFjdGl2 YXRlIHRoaXMgY29kZSB3aXRob3V0IGRvbTAgKHdoaWNoIG1pZ2h0IGhhcHBlbiB3aGVuIHdlIHdp bGwgcHVzaCB0aGUgc2VyaWUgZm9yIHN0YXRpYyBldmVudCBjaGFubmVscykuDQo+Pj4+PiANCj4+ Pj4+IEkgYW0gZmluZSB3aXRoIGFuIEFTU0VSVCgpLg0KPj4+Pj4gDQo+Pj4+PiBBcmUgeW91IHNh eWluZyB0aGF0IGRvbTBsZXNzX2VuaGFuY2VkIHdpbGwgYmUgc2V0IHRvIHRydWUgZm9yIHRoZSBz dGF0aWMgZXZlbnQgY2hhbm5lbCBzZXJpZXM/DQo+Pj4+PiANCj4+Pj4+IElmIHllcywgdGhlbiBJ IHRoaW5rIGRvbTBsZXNzX2VuaGFuY2VkIHdpbGwgbmVlZCB0byBiZSBhbiBlbnVtIHNvIHdlIGtu b3cgd2hhdCBwYXJ0IG9mIFhlbiBpcyBleHBvc2VkLg0KPj4+PiANCj4+Pj4gTm8gaXQgd29u4oCZ dCwgd2UganVzdCBuZWVkIHNvbWUgb2YgdGhlIGNoYW5nZXMgZG9uZSBidXQgd2l0aG91dCBzZXR0 aW5nIGRvbTBsZXNzX2VuaGFuY2VkLg0KPj4+PiBAUmFodWw6IGNhbiB5b3UgY29uZmlybS4NCj4+ Pj4gDQo+Pj4gV2UgbmVlZCB0byBzZXQgdGhlICJ4ZW4sZW5oYW5jZWTigJ0gZW5hYmxlZCBmb3Ig ZG9tMGxlc3MgZG9tVSB0byBlbmFibGUNCj4+PiB0aGUgZXZlbnQtY2hhbm5lbCBpbnRlcmZhY2Ug aW4gZG9tMGxlc3MgZ3Vlc3QuIElmIHdlIGRpZCBub3Qgc2V0IHRoaXMgcHJvcGVydHkgd2UgY2Fu 4oCZdA0KPj4+IHVzZSB0aGUgZXZlbnQtY2hhbm5lbCBpbnRlcmZhY2UgaW4gZG9tMGxlc3MgZG9t VXMgZ3Vlc3RzLg0KPj4gDQo+PiBJcyB0aGlzIGJlY2F1c2UgdGhlIGRvbVUgd2lsbCBub3Qga25v dyB3aGljaCBQUEkgd2lsbCBiZSB1c2VkIGZvciBub3RpZmljYXRpb24/DQo+IA0KPiBZZXMgeW91 IGFyZSByaWdodCBpZiB3ZSBkb27igJl0IHVzZSAieGVuLGVuaGFuY2Vk4oCdIGZvciBkb21Vcywg ZG9tVXMgd2lsbCBub3Qga25vdyB3aGljaCBQUEkgd2lsbCBiZSB1c2VkLg0KPiBBbHNvIGlmIHdl IGRvbuKAmXQgdXNlICJ4ZW4sZW5oYW5jZWTigJ0gdGhlcmUgaXMgbm8gaHlwZXJ2aXNvciBub2Rl IGNyZWF0ZWQgZm9yIExpbnV4IGFuZCBpZiB0aGVyZSBpcw0KPiBubyBoeXBlcnZpc29yIG5vZGUg dGhhdCBtZWFucyBubyB4ZW4gc3VwcG9ydCBkZXRlY3RlZC4NCj4gDQo+PiANCj4+IFRoZSBwcm9w ZXJ0eSAieGVuLGVuaGFuY2VkIiB3aXRoIGFuIGVtcHR5IHN0cmluZyAob3Igd2l0aCB0aGUgdmFs dWUgImVuYWJsZWQiKSBpcyBtZWFudCB0byBpbmRpY2F0ZSB0aGF0IFBWIGRyaXZlcnMgd2lsbCBi ZSB1c2FibGUgaW4gdGhlIGRvbWFpbi4NCj4+IA0KPj4gQUZBSVUsIHlvdSBhcmUgc3VnZ2VzdGlu ZyB0byBjaGFuZ2UgdGhlIG1lYW5pbmcgYmFzZWQgb24gZG9tMCB3aGV0aGVyIGhhcyBiZWVuIGNy ZWF0ZWQuIEkgZG9uJ3QgcGFydGljdWxhcmx5IGxpa2UgdGhhdCBiZWNhdXNlIGEgdXNlciBtYXkg c3BlbnQgYSB3aGlsZSB0byB1bmRlcnN0YW5kIHdoeSBYZW5zdG9yZWQgZG9lc24ndCB3b3JrLg0K Pj4gDQo+PiBUaGUgY3VycmVudCBwcm9wb3NhbCBmb3IgeGVuLGVuaGFuY2VkIGFsbG93cyB1cyB0 byBkZWZpbmUgbmV3IHZhbHVlcyBpZiB3ZSB3YW50ZWQgdG8gb25seSBlbmFibGVkIHNlbGVjdGVk IGludGVyZmFjZXMuIEFGQUlVLCBpbiB5b3VyIGNhc2UsIHlvdSBvbmx5IHdhbnQgdG8gZXhwb3Nl IHRoZSBldmVudCBjaGFubmVsIGludGVyZmFjZSwgc28gSSB3b3VsZCBjcmVhdGUgYSBuZXcgdmFs dWUgdG8gaW5kaWNhdGUgdGhhdCB0aGUgZXZlbnQgY2hhbm5lbCBpbnRlcmZhY2UgaXMgZXhwb3Nl ZC4gWGVuIHdvdWxkIHRoZW4gY3JlYXRlIG9ubHkgdGhlIHBhcnQgZm9yIHRoZSBldmVudCBjaGFu bmVsIChpLmUuIG5vIGV4dGVuZGVkIHJlZ2lvbnMsIGdyYW50IHRhYmxlcy4uLikuDQo+IA0KPiBP ay4gSSB3aWxsIGNyZWF0ZSB0aGUgbmV3IHByb3BlcnR5IHNvbWV0aGluZyBsaWtlIOKAnHhlbixl dnRjaG7igJ0gdG8gZW5hYmxlIHRoZSBldmVudC1jaGFubmVsIGZvciBkb20wbGVzcyBndWVzdHMu IA0KPiBCYXNlZCBvbiDigJx4ZW4sZXZ0Y2hu4oCdIHByb3BlcnR5IEkgd2lsbCBjcmVhdGUgdGhl IGh5cGVydmlzb3Igbm9kZSB3aXRoIG9ubHkgUFBJIGludGVycnVwdCBwcm9wZXJ0eS4NCg0KSWYg d2UgZG9u4oCZdCB3YW50IHRvIGNyZWF0ZSB0aGUgbmV3IHByb3BlcnR5IHdlIGNhbiB1c2UgInhl bixlbmhhbmNlZCA9IGV2dGNobuKAnSB0byANCmVuYWJsZSB0aGUgZXZlbnQtY2hhbm5lbCBpbnRl cmZhY2Vmb3IgZG9tMGxlc3MgZ3Vlc3RzLg0KDQpSZWdhcmRzLA0KUmFodWwNCg0K From xen-devel-bounces@lists.xenproject.org Wed May 11 15:15:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:15:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327037.549737 (Exim 4.92) (envelope-from ) id 1noo3U-0006Gw-Bi; Wed, 11 May 2022 15:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327037.549737; Wed, 11 May 2022 15:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo3U-0006Gp-8G; Wed, 11 May 2022 15:15:12 +0000 Received: by outflank-mailman (input) for mailman id 327037; Wed, 11 May 2022 15:15:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo3S-0006Gj-Sv for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:15:11 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23198c7b-d13d-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 17:15:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23198c7b-d13d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652282107; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0+WTyQ6WE3kGVK9uh25l57/PyAwZp1z/qpa8H5lsp7g=; b=MUsqOP445j2nY+4cL5nIvIlX1+Sxyq/QiQ6/x1ya1aeVUN+yNgb7JTDO 7WcwMH6AutlR5PTycNR1JSxvh5BR+JrvvVW7ckXGeFCaj2/zgw5qV3hk3 iROxTU08dYVWNASDHPyLw6tB8a7Roxte8byMnnKv+NETDxEgmiHacXo8l o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70950634 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:IkzVhq9Klyy2KtsOEEhjDrUD6H6TJUtcMsCJ2f8bNWPcYEJGY0x3n WcXUGqBa/eDNDOhLdsiOYiz804GvZOHy4NgSlE5/ng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbCVVzgvOo/vpNQ+CAJRSTEmM4kfx6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6BP 5tEMWQ0MHwsZTVFMX0mKKt9x93vi0nuSDEHqAqsgK0etj27IAtZj+G2bYu9lsaxbdpRtlaVo CTB5WuRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO8Ef9j6Lzoj33za6XXMNFC4ZZvh/i9BjEFTGy WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW 1BewqCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I90KumkhehozbpxeEdMMX KM0kVkKjKK/wVPwNfMnC25PI5pCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY M/BGe71VC5yIf0+kFKeGrZGuZd2l39W+I8mbc2ip/hR+eHGNCD9pHZsGAbmU93VG4ve/lqPr 4YEZ5viJtc2eLSWXxQ7OLU7dTgiRUXXz7ivwyCLXoZv+jZbJVw= IronPort-HdrOrdr: A9a23:xedE6a238L0FqAJM3/cZcwqjBL4kLtp133Aq2lEZdPRUGvb3qy nIpoV96faUskd0ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfREWndQ96U 4PScdD4aXLfDpHsfo= X-IronPort-AV: E=Sophos;i="5.91,217,1647316800"; d="scan'208";a="70950634" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Date: Wed, 11 May 2022 16:14:23 +0100 Message-ID: <20220511151423.20241-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for evtchn delivery set up on a per-vCPU basis via HVMOP_set_evtchn_upcall_vector. is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up physical IRQ to event channel mappings. Signed-off-by: Jane Malalane --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu --- xen/arch/x86/include/asm/domain.h | 8 +++++++- xen/arch/x86/traps.c | 3 +++ xen/include/public/arch-x86/cpuid.h | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index 35898d725f..f044e0a492 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -14,8 +14,14 @@ #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) +/* + * Set to true if either the global vector-type callback or per-vCPU + * LAPIC vectors are used. Assume all vCPUs will use + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. + */ #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) #define is_domain_direct_mapped(d) ((void)(d), 0) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 25bffe47d7..2c51faab2c 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1152,6 +1152,9 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, res->a |= XEN_HVM_CPUID_DOMID_PRESENT; res->c = d->domain_id; + /* Per-vCPU event channel upcalls are implemented. */ + res->a |= XEN_HVM_CPUID_UPCALL_VECTOR; + break; case 5: /* PV-specific parameters */ diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h index f2b2b3632c..1760e2c405 100644 --- a/xen/include/public/arch-x86/cpuid.h +++ b/xen/include/public/arch-x86/cpuid.h @@ -109,6 +109,8 @@ * field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* Per-vCPU event channel upcalls. */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed May 11 15:18:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:18:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327043.549749 (Exim 4.92) (envelope-from ) id 1noo6g-0006tC-Ri; Wed, 11 May 2022 15:18:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327043.549749; Wed, 11 May 2022 15:18:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo6g-0006t5-Oh; Wed, 11 May 2022 15:18:30 +0000 Received: by outflank-mailman (input) for mailman id 327043; Wed, 11 May 2022 15:18:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo6f-0006st-4V; Wed, 11 May 2022 15:18:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo6f-00012w-1U; Wed, 11 May 2022 15:18:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo6e-0004U2-Qf; Wed, 11 May 2022 15:18:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noo6e-0006YO-QB; Wed, 11 May 2022 15:18:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=43p5x6q7lA2GLrct0lRzBojZmaNOUc8dZAyl1fo3AlQ=; b=1GZIZIf5H3hQyKlfMldXbMsGOx l6gBLjjOdMU1wtGbECUD21S6XcrKuNK73K/Fz/M/eI4un176sN7svhyR+7A8L2gcPcVlp5VFwylrC J4ElOWOvwbAJbcBKv0JKRt1U4bGI8e8zqAJUd6Pxe7phvZlVyBD//vKUnTWlOYNSUKUU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170328: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 15:18:28 +0000 flight 170328 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 937 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 15:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327052.549759 (Exim 4.92) (envelope-from ) id 1noo8a-0008Eq-7x; Wed, 11 May 2022 15:20:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327052.549759; Wed, 11 May 2022 15:20:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo8a-0008Ei-59; Wed, 11 May 2022 15:20:28 +0000 Received: by outflank-mailman (input) for mailman id 327052; Wed, 11 May 2022 15:20:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo8Z-0008Ec-3F for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:20:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noo8X-00015G-BM; Wed, 11 May 2022 15:20:25 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1noo8X-0004gk-5D; Wed, 11 May 2022 15:20:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AoyzRwKRQDEYaL14LCRpgZDSJ6aVZI7D/QQ/aSpKcCQ=; b=JyO0tDnnmGqpVXV9fVeeu8zN4u OoHUnx37JEO1uL0T+vnwCoDU3WcEUqnbjiIBO7kDAQAj+NuJYRKk0CWqx0+a8SivA9okdj52q6BLp s0KEV3DlOIkkHtjtqxNA9B6RYA5Pr2SA/pjw/8j6bgcNjZLDnkkq1u373AeazFVMi6IY=; Message-ID: <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> Date: Wed, 11 May 2022 16:20:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Volodymyr Babchuk References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/05/2022 15:41, Bertrand Marquis wrote: > > >> On 10 May 2022, at 03:03, Stefano Stabellini wrote: >> >> On Wed, 4 May 2022, Julien Grall wrote: >>>> Do I understand right that it is ok for you if I push one patch mentioning >>>> all the commits done in Linux corresponding to the changes (instead of one >>>> patch per commit) ? >>> >>> For this case yes. >> >> I managed to do a review of the patch by doing a diff of the relevant >> portion of Xen cpufeature.c with Linux cpufeature.c (from commit >> b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux >> sysregs.h (diff -E -b -u). >> >> Everything checks out. >> >> In my opinion, this patch should be split in 2 patches: the changes to >> cpufeature.c and sysregs.c that come from the Linux sources; and the >> updates to cpufeature.h that do not. If you do that you can add my >> reviewed-by to the first patch with the changes from Linux. >> >> The list of individual commit IDs would be nice, but thanksfully the two >> source files are still "diffable" so in my opinion are not required. > > I agree with that. > > Julien: Do you agree if I just put the changes to cpufeature.h in a separate patch ? > > I started to list the commit IDs corresponding to the changes in Linux and this would > end up with 5 or more which I do not think would be that useful as the diff can be easily > done as Stefano mentioned. It looks like there are some confusion why I asked the list of commit. For this case, this is not about diffing the code (it is easy to do and I have already done that). It is more about authorship and where the patches come from. Technically, speaking you only copied the code from Linux and therefore you are not the author of some of the changes. For such case, our general process is: 1) Backport the commit as-is (i.e the Author is the original Author) 2) Add the tag Origin (recently introduced) 3) Add your signed-off-by I understand the patch is already written, so I was OK if you simply list of the commits with the authors/tags for this time. If both Stefano and you agree to not keep the authorships, then I will not stand against it. However, I will not get involved in committing and adding my ack. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 15:25:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:25:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327060.549771 (Exim 4.92) (envelope-from ) id 1nooDS-0000Ww-SR; Wed, 11 May 2022 15:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327060.549771; Wed, 11 May 2022 15:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooDS-0000Wp-Ox; Wed, 11 May 2022 15:25:30 +0000 Received: by outflank-mailman (input) for mailman id 327060; Wed, 11 May 2022 15:25:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooDS-0000Wj-1p for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:25:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooDQ-0001Ba-4T; Wed, 11 May 2022 15:25:28 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nooDP-00053R-U3; Wed, 11 May 2022 15:25:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MWdG8HWRQtdjm7hYRurT4+xl1Cfh1altkzMduDCvyM0=; b=lqpX5UQ9NvVx28OsWFagpcFQ7s hemggjeaUSY6YpLmidM8DsvEAZTbZMrjngdQyzhqWwAR+AQ2UrzsH1uHgrJLHLR21mz5+DcDjue1e YTMqSlzrhxiGwAJ36WYvCsSCft88rDVC7vLE0zwOqp1xmu4kWpgtzB8Z7JhfGGTpt7K4=; Message-ID: <9b6720d5-a4b1-3065-61ef-4341c2cd0933@xen.org> Date: Wed, 11 May 2022 16:25:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Rahul Singh Cc: Bertrand Marquis , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <9707ACA4-711A-4691-BA2A-FCDDAFFD9DE8@arm.com> <10151DF3-A3C9-49FB-8F2B-B36407E5CE82@arm.com> <573e94c4-7de0-e442-c9d8-559b55ae3144@xen.org> <3AC1200B-4F64-4828-8EAF-E6039E3613F1@arm.com> <4D04ACBD-014A-4A74-8B2C-6BCFB8D562A0@arm.com> From: Julien Grall In-Reply-To: <4D04ACBD-014A-4A74-8B2C-6BCFB8D562A0@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/05/2022 16:05, Rahul Singh wrote: >>> The property "xen,enhanced" with an empty string (or with the value "enabled") is meant to indicate that PV drivers will be usable in the domain. >>> >>> AFAIU, you are suggesting to change the meaning based on dom0 whether has been created. I don't particularly like that because a user may spent a while to understand why Xenstored doesn't work. >>> >>> The current proposal for xen,enhanced allows us to define new values if we wanted to only enabled selected interfaces. AFAIU, in your case, you only want to expose the event channel interface, so I would create a new value to indicate that the event channel interface is exposed. Xen would then create only the part for the event channel (i.e. no extended regions, grant tables...). >> >> Ok. I will create the new property something like “xen,evtchn” to enable the event-channel for dom0less guests. >> Based on “xen,evtchn” property I will create the hypervisor node with only PPI interrupt property. > > If we don’t want to create the new property we can use "xen,enhanced = evtchn” to > enable the event-channel interfacefor dom0less guests. I would prefer the "xen,enhanced = evtchn" because to avoid corner cases such as xen,enhanced without xen,evtchn Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 15:41:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327067.549781 (Exim 4.92) (envelope-from ) id 1nooSg-0002uX-7z; Wed, 11 May 2022 15:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327067.549781; Wed, 11 May 2022 15:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooSg-0002uQ-5J; Wed, 11 May 2022 15:41:14 +0000 Received: by outflank-mailman (input) for mailman id 327067; Wed, 11 May 2022 15:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooSe-0002uK-9o for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:41:12 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060a.outbound.protection.outlook.com [2a01:111:f400:fe0c::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7998b0c-d140-11ec-a406-831a346695d4; Wed, 11 May 2022 17:41:10 +0200 (CEST) Received: from AM6PR10CA0051.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::28) by PA4PR08MB5982.eurprd08.prod.outlook.com (2603:10a6:102:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Wed, 11 May 2022 15:41:08 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::e8) by AM6PR10CA0051.outlook.office365.com (2603:10a6:209:80::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 15:41:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 15:41:07 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Wed, 11 May 2022 15:41:07 +0000 Received: from 7abf8b291187.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9ED56F7-1A50-4CEC-9022-12CA5D634EDD.1; Wed, 11 May 2022 15:41:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7abf8b291187.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 15:41:00 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM5PR0801MB2017.eurprd08.prod.outlook.com (2603:10a6:203:42::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Wed, 11 May 2022 15:40:58 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 15:40:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7998b0c-d140-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L1I2RsbmcxBrZ3ELjoLibT1Ok2uV1+anMh+m4YzvM+TxbDMd1Vv3fTLA1dIoVqBg7xAmIDlTG4Wr9y9CZ7/hDZWFvrOq/LJ3Aj1poIfxX8LK+J4veK2qCJK4jVOQlq/fTvcYcGh8T4d8ykeSRF46kQOg78LfwxdY8rJv/hP8ycX82gBHx3YEGN6LOyzu9oIZg+RbofSId+sRUGIDBzoQkXP8A4bilBD9a/QAfiea5w4jcj77ACMDeTxxjPdtFsbolyrQ6k9IwR+gAgxLKYwzWWByUgFnuFFXyl1jQYBjHMsDgyB8WrUHyK6VoWBpkBFfakNWRWHf/Np9zp4OU2uMWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YD2Mg9oNyrBHl1zd8D6rVqji58pl4Mo+sxOO4WGdHn8=; b=Y5KU11NQ9Z0m68tSPmkxi+ZMEwyZiRfaYxRzQPZp0+koVVB2OD3wZBJiAM2PcXiwKUuS3Dzo3H0RKP7i77qWj1+6ck/4j9IzG+Sk49PEnz3uCoDzDC78aKVSD0/UNtrMip9OwqYsGZB6675KiGmESMZ2Ivrml4TUJLMOWETv6jN9XIzzMMEI8YDiWyRX2dtXuEdr3ppxsnsX4xsJgD+JHy/2oOrALwyvOKCED6a4OoSbaNfs1qYoOHw6oPlW9GC91XgibqkAz1oi8syF85lxnbfShZ3chVkQ0rXPJPQuVeiYlfDO/ATuyOw7+DmSvfjzUZSvJhtW9jNDEs1hg+0w/Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YD2Mg9oNyrBHl1zd8D6rVqji58pl4Mo+sxOO4WGdHn8=; b=G1ZWiCuNGzMdp55R9xzSHnDpktK80WJGrorseeKCkmOtq9gFini8mBNPXITfvokIqla4ksVMRr9R17PJ22Ts3K7v3x1wdX6gVXreS6bF54Q8oQ85dtzcoKTPZqqBrBvU67urolg6ngAYKhwxwnBW64NbQYxmmmXGYm871Qe6Wss= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7112e0c9eaa634a8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BZEac/waqvnbxOQ+psebciUyd/dIwzTnh3JjB3qgjEr+4X1KHD6/nlEo9rKuO96Kii1OllvYCugoJKv0eTuuyiBa9AUkueIHNb19FqCGeCLBmtc8CZUQzxjYneY8VP48rNzHiMKzZZZrFK3vs1rJ9nktkKGaLC0nbc9+nSVK8jYErkbOnjKKL8aQ6F2dRB3Yrt/bppxJrkEDr3ExU7aDCoATVD/CExSEQp0qC8KZQc3W1GFcpoFpXtmTnZr4B1QUcVstEuDTT82Eel0UlvvccbVn+86Tbw7GtkhToQRTQCyMIXAWwG4Nb37nbKbPMeXoEC1eUKFnOAzeYUjg0ut07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YD2Mg9oNyrBHl1zd8D6rVqji58pl4Mo+sxOO4WGdHn8=; b=A5XPLcZicSRfJ+gpDrBevUl7lgmpYPaQlShMqPvRZhont+9VopP0m7gaif/+Eaywlal2GPKeG/Ci8Y6KGrRqlswAxxDC5nvclsHSiPhcjEDeCWl4Kta1Il4dzmrRVeXXm1psKgftJkA9qMceI32oVhSs8NLstq6+Nj7cnHGKx0HVOe+a3ZZy2CR9sVSXDEAg2+fqZS7wkgIzl/KZPqpjuzfWltEUtOcL1cWd8zoaGjKYOKL4r0B+15TQlf/BGwW5DJUfGhXESSWN6RA6W8WbmdtzLt7ThDSNQLPEgSDHjxDHnh9KH/XmPQ//sqSOZRfniLdi1W/3cE5LgWvQfOQyAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YD2Mg9oNyrBHl1zd8D6rVqji58pl4Mo+sxOO4WGdHn8=; b=G1ZWiCuNGzMdp55R9xzSHnDpktK80WJGrorseeKCkmOtq9gFini8mBNPXITfvokIqla4ksVMRr9R17PJ22Ts3K7v3x1wdX6gVXreS6bF54Q8oQ85dtzcoKTPZqqBrBvU67urolg6ngAYKhwxwnBW64NbQYxmmmXGYm871Qe6Wss= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduAgAALAICAAAXAAA== Date: Wed, 11 May 2022 15:40:58 +0000 Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> In-Reply-To: <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d02c7a2c-3a89-4775-3a4f-08da3364aa62 x-ms-traffictypediagnostic: AM5PR0801MB2017:EE_|AM5EUR03FT013:EE_|PA4PR08MB5982:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vO7QZ9fundD/voyTEd/5QxuAwct0mVp6WWtZbYfsyamQXFte+tJS1m8nFtxgHE5ssny1rOffLFCT93GwgBXkaSc0ecCXoBSENATjy2VZD1l2nc1zuUIRjUvrD4xxKubOUxGmO/jk3r0d+lZLzHg3AvSGCb2Z3zh2L8HfKQoYLSHL1BR+KnBLMg6/czCzGnKfymA8F4EOpJ8ZZjFWz8kBTJiUI6uPOh100M77qMgezN8IrTh18W0Q42pH6Q1s+Z+p2xPDkwTqzPg5BEFho1osnSq7Q3xfam1DfYns84+oifVvhV4dji+fgaJz2IIb22bOsP26P26YT5Pt3TigHGMLF9AFSf6bDbjbHBEBR5deUME026D7/RvSlj8WJmYspL+wHV6tZHfcWUI60/NlIfxrmrCfmpOxyTk3+h6R6gsM7py4EeeSMpX3DfwunaeibGBNMvdB+pA3twsym21u7Wb02OfNLH4MKvv59wi3+ULfI6Zc1KyWgnOLE8I4N6KK7V6xVKtqxjApn8sxmCbtDLvaMLGkhqlUAv+h8pu0UNm9bRH4H2rQJH2ETmc9UpSKsaPeeyQWUJ1MgSI669SkjEeurvj3x99ls6HLAZ7jE/IzKo+QgCKEMoyWHEL7paoy0czDFDEadja/DzLYay2RWQQc/nFrplWCpsaWaJncXa9tQrJlG5qXyC0x8ixKQpoW7Y4DMWsnV6OxaoGATyalZCvc2vWkz6NnxlX96oG6vcQ9wCxenxAK01CstbjWkI5YAss4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(508600001)(26005)(2616005)(6512007)(316002)(71200400001)(33656002)(186003)(6506007)(86362001)(5660300002)(2906002)(53546011)(122000001)(83380400001)(36756003)(91956017)(6916009)(54906003)(8676002)(64756008)(66946007)(4326008)(66446008)(76116006)(66476007)(66556008)(38070700005)(38100700002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2017 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5d285424-cce0-494b-78ec-08da3364a523 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QEvp+oto1DiT6q+L5gDVay2JAAP6PjJ6V9L0cksgR4YZPJsS/+XS9cOUlGYA2dDx1jvV0jx/653IW222GRzd1ZrOS/77VjOT9jXO06LWmvxrjtlGn5LYTaDeyP7ZyGofM6XQatfZd9tOAbHM+w3c0itcfUNUybmoWMPBZu+KhK6NiQkQBr4SxDWMEHuJHzHOGIviuMmPP3AlI/8VSdtbo2hnNVHRbcUerL6L1tg0P3gS60uW8zCvMf3wVve9Xv0hUK62uJbLm5AhWSo+eVMHNtcddygoguiRaF2WaKjJkk/2BEzdXqqvC6zHSu/Tv/HcaJv40OKkLX7zgLIKfcfvf59NZuzKGe2kXjz7AzKdPbCpd+ntFhFlNsXnKo28jzt6QHvon3C42tjLgJyQR/BOf8F4l+LZ5Rwr/rHm02ogvBwchiLrapkjwcm9rX1HEUng054cyq9dcVZE+ZZojZNMyceL/jvWh2swHg/Pqtp78fc8eK1RO2x8j4ExTQpaT5q3tVBrbOV+DObtoNKDmhtgMeqNpw8WLsGQMF+AEim5jlTnIh4EihWx6hEwM6KFNKJ6bDochSBb0C+tJ8kufA+kU+3MjbJZTtltoLGpQDgvi/9X3vsUXy/99FE1MZWYaNN6LRAGogT4gGHcav0yJS+GYp5k0x7HC0RV2Rq4onUjRKiFXOvSwHgBltgjKMtgepcV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(4326008)(81166007)(36756003)(8936002)(36860700001)(508600001)(6862004)(8676002)(33656002)(2906002)(70206006)(70586007)(356005)(83380400001)(54906003)(336012)(86362001)(40460700003)(53546011)(6506007)(107886003)(2616005)(5660300002)(6486002)(316002)(82310400005)(47076005)(6512007)(186003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 15:41:07.3883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d02c7a2c-3a89-4775-3a4f-08da3364aa62 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5982 Hi Julien, > On 11 May 2022, at 16:20, Julien Grall wrote: >=20 > Hi, >=20 > On 11/05/2022 15:41, Bertrand Marquis wrote: >>> On 10 May 2022, at 03:03, Stefano Stabellini w= rote: >>>=20 >>> On Wed, 4 May 2022, Julien Grall wrote: >>>>> Do I understand right that it is ok for you if I push one patch menti= oning >>>>> all the commits done in Linux corresponding to the changes (instead o= f one >>>>> patch per commit) ? >>>>=20 >>>> For this case yes. >>>=20 >>> I managed to do a review of the patch by doing a diff of the relevant >>> portion of Xen cpufeature.c with Linux cpufeature.c (from commit >>> b2d229d4ddb1), and the relevant portion of Xen sysregs.h with Linux >>> sysregs.h (diff -E -b -u). >>>=20 >>> Everything checks out. >>>=20 >>> In my opinion, this patch should be split in 2 patches: the changes to >>> cpufeature.c and sysregs.c that come from the Linux sources; and the >>> updates to cpufeature.h that do not. If you do that you can add my >>> reviewed-by to the first patch with the changes from Linux. >>>=20 >>> The list of individual commit IDs would be nice, but thanksfully the tw= o >>> source files are still "diffable" so in my opinion are not required. >> I agree with that. >> Julien: Do you agree if I just put the changes to cpufeature.h in a sepa= rate patch ? >> I started to list the commit IDs corresponding to the changes in Linux a= nd this would >> end up with 5 or more which I do not think would be that useful as the d= iff can be easily >> done as Stefano mentioned. >=20 > It looks like there are some confusion why I asked the list of commit. Fo= r this case, this is not about diffing the code (it is easy to do and I hav= e already done that). It is more about authorship and where the patches com= e from. This is clear from the commit message as I give the commit in Linux used so= the history can be easily found from that. I am a bit lost on the authorship part ... >=20 > Technically, speaking you only copied the code from Linux and therefore y= ou are not the author of some of the changes. >=20 > For such case, our general process is: Could you tell me where this process is described ? > 1) Backport the commit as-is (i.e the Author is the original Author) > 2) Add the tag Origin (recently introduced) > 3) Add your signed-off-by So following this theory, if we import a file from Linux we should list all= the people who contributed to it since it was created ? >=20 > I understand the patch is already written, so I was OK if you simply list= of the commits with the authors/tags for this time. I would like to understand where this requirement is coming from. @George: is there some kind of legal reason for something like that ? >=20 > If both Stefano and you agree to not keep the authorships, then I will no= t stand against it. However, I will not get involved in committing and addi= ng my ack. I want first to clear up this process and understand why you are requesting= this to know how I should do anything like that in the future. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 15:47:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 15:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327075.549793 (Exim 4.92) (envelope-from ) id 1nooZ5-0003mU-4b; Wed, 11 May 2022 15:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327075.549793; Wed, 11 May 2022 15:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooZ5-0003mN-1a; Wed, 11 May 2022 15:47:51 +0000 Received: by outflank-mailman (input) for mailman id 327075; Wed, 11 May 2022 15:47:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooZ3-0003mH-4v for xen-devel@lists.xenproject.org; Wed, 11 May 2022 15:47:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooZ1-0001Zr-3C; Wed, 11 May 2022 15:47:47 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nooZ0-0006bM-TB; Wed, 11 May 2022 15:47:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2THmZUyjmC6IlAA2pF9TRgGDm6EvsibPfPBhRsc7Unk=; b=r5L/W8Ym94ktwU25SbqM7DnuYr uEnCcnWPeiZLd3VHW3Inyi/Of2R3xDZv0Jb+dWlws7D1DiubygeqsUhHC6FPr2p3sC+zC35sFyn0S E37jZfzf/mF1wmN4JcejSQqCnjzkuH0vKJFVjPgMMtLdfTWB4IJBJuVIqiXSFqo/7ysg=; Message-ID: <0a1faec6-b265-567e-0ad1-478dff6bc81d@xen.org> Date: Wed, 11 May 2022 16:47:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis Cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 11/05/2022 16:40, Bertrand Marquis wrote: >> On 11 May 2022, at 16:20, Julien Grall wrote: >> Technically, speaking you only copied the code from Linux and therefore you are not the author of some of the changes. >> >> For such case, our general process is: > > Could you tell me where this process is described ? The closest description I could find is: https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/process/sending-patches.pandoc;h=7ff7826c992b68804b41cc4a8605329f7a10e44c;hb=HEAD#l75 > >> 1) Backport the commit as-is (i.e the Author is the original Author) >> 2) Add the tag Origin (recently introduced) >> 3) Add your signed-off-by > > So following this theory, if we import a file from Linux we should list all the people who contributed to it since it was created ? Technically yes. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 16:00:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 16:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327082.549804 (Exim 4.92) (envelope-from ) id 1noolZ-0006dJ-Aw; Wed, 11 May 2022 16:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327082.549804; Wed, 11 May 2022 16:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noolZ-0006dC-7r; Wed, 11 May 2022 16:00:45 +0000 Received: by outflank-mailman (input) for mailman id 327082; Wed, 11 May 2022 16:00:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noolX-0006d2-P1; Wed, 11 May 2022 16:00:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noolX-0002LU-Km; Wed, 11 May 2022 16:00:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noolX-0005Ng-Ao; Wed, 11 May 2022 16:00:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noolX-00011B-AK; Wed, 11 May 2022 16:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=myos3T7ueUmW92f5XzOdkAP60K/vLehqwQ9ApsTgdrc=; b=cZDnxHJrxH5j/LCQUkiuYAQinP ZebnWuo5kMYGb9rgw28Mo8t/Y788JWLV2Tlu5DB1vq7xSuhPO4EWQlleygOnOayv2s42PVVl//vBa 9nrhh3KJugRQAFKslFnB/qNWG84ISJ/g0bZt0J5AC0PAbKYiPFx14/fE9z3eH2yk2wYk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170329: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 16:00:43 +0000 flight 170329 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170329/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 938 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 16:02:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 16:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327090.549815 (Exim 4.92) (envelope-from ) id 1noomm-0007C6-OK; Wed, 11 May 2022 16:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327090.549815; Wed, 11 May 2022 16:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noomm-0007Bz-Ko; Wed, 11 May 2022 16:02:00 +0000 Received: by outflank-mailman (input) for mailman id 327090; Wed, 11 May 2022 16:01:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nooml-0006z4-Fr for xen-devel@lists.xenproject.org; Wed, 11 May 2022 16:01:59 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0621.outbound.protection.outlook.com [2a01:111:f400:fe06::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aeffd61e-d143-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 18:01:58 +0200 (CEST) Received: from AS9PR04CA0094.eurprd04.prod.outlook.com (2603:10a6:20b:50e::23) by PAXPR08MB6686.eurprd08.prod.outlook.com (2603:10a6:102:13e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 16:01:55 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::c0) by AS9PR04CA0094.outlook.office365.com (2603:10a6:20b:50e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 16:01:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 11 May 2022 16:01:55 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Wed, 11 May 2022 16:01:54 +0000 Received: from 910a192f79d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22379CFA-E944-4AE4-B7F3-AA5C327787D4.1; Wed, 11 May 2022 16:01:48 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 910a192f79d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 May 2022 16:01:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB7PR08MB3708.eurprd08.prod.outlook.com (2603:10a6:10:7a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Wed, 11 May 2022 16:01:46 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Wed, 11 May 2022 16:01:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aeffd61e-d143-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dYIc/hy1v6mNepv+OvUAq4gc9LtuzH7Ex5Kxqee6PyetzLzNPzMvh6kf+i7y/5lj1/kpqs51goZ59dlR1IAba49UWAa/kOZHUg+C9VUekL4SK80nD5poG402HTY/caY4JlAAQ3ghOhtE8e+qvNXkzCCr0fURv+7Xo2m4w8jKS0BT4AuMjp0LGg+A0H64f+bZpq6FJ/fjK6rCwGEnodobdJCQ4axu9NMLE43GvoBRt/+HQ5cuO0Gr4sqVWHfJl1MxeAtWaC00e3VSTErThZG/cvMnzYsOZSWsal2yuLLvxB1bxp4Efv7QuD7T7dw65g+oIjdch88IrHCU53ujad44EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eUCm5lS68CvkA4ylVhubdNduPXcnxjvk5JZ/KlJXQng=; b=iKqSemJj+i5qCXczL/MF9CLyvleSHjgZhuARw8HO/EHSXjA4Rs/vgnkdq27ktImW662PUVhGZAn4sKuzsiWu54KWGLX9OEe47UWpceMAFYuc3JU6gJjgDbrfpYH7V+GhVwjfnOVyeFE4FGy6ue3147stWzhXSPWOt0CmsZKiOibRMy82HdvBR+19jSr7JA8fv0nPpPF8gv0FDLSgvzYP2NYdpi7jdtQ4BJtcL8phQjmM9i0rzw9j/yADk3URABDTMCwzMxjL65rqTw4lH+czCXdjX39xWPA3Vv2DuVoK/e1wAat+/N6mvrwPkQz2CrRck9PiQ0ByMiQx737owcq8TQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUCm5lS68CvkA4ylVhubdNduPXcnxjvk5JZ/KlJXQng=; b=cjDhUdBAFIGsJ9obiN1TiSuDl4ooZ7uZ/WnbSr1AR7QkNXfBNfTtBw6BsxhZ6WEWI2fdnadX1MDRH5cyMrlnF4uZBL0Ob00l4w40yKgHmAoYCsaSQDpeQ+XNXBi6WphmtFJ1eD8RfYNAt0WhAN1cjlrOMGB0dL5GnSggsbCdnhk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: eea01e9b5c9dd235 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RD+Gop+GXhFV/7u907Vt0/c/GVB8yf9aRT8Y/d2wbabUGRM5jD1msHqNQKRb3qGpFhil5Ielso7/eubFleS6/UCR9E1SppR1V9Hd/LgDnCl+RCVKSDbJAgzfC0aKttNe6TGLKb0yXxgyItSA9MLOIEUdymGldIRrdMm/pI4QZnVvwJX223NQ7ecGTtnKWU+6/8CIaOe3FdSNa+gdN9ooEzq/BAM7Sya8vw8r85TNaRdnwGE9TVQXLwK1+9ry6Gbv1i+E3BDk8NhSJ6J21QQPzp5ypNeDNZMBnTLR4GWPppOhhUFHkIYXfsbZqZ5OQErGxLwL0PjWmvLzy8tObMFZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eUCm5lS68CvkA4ylVhubdNduPXcnxjvk5JZ/KlJXQng=; b=LM4dm0dD9ul3wq78ts7fX++bmNZ1IhwpIOt3DYQCGf+yYDfPpSwP+RlpoygOibBHJmtW49uyf/TmrZQhEsXrAAnS2hlO8YBUpgqEIOfhPXDae4a4yZ/HPu1x2skhEUbBQahGF9EJaS21/yUhbds2RFsIuq6u3KYb1XbquLFvJ8d8xwSj6QBlEK3y3cPK8SPOsw5uifwht4iyZy/FNcSTQHdqaZduscBkMpA+mIayd2TJlL0vcS8ilhoF1VaNAfrXPLMXA14ypahiSXxwHEaRH7K+5NernLWeWmLdOUphpLhyKectND72ZnntAYR98tkYjJbi2ltlDuk00d5PMx6GQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUCm5lS68CvkA4ylVhubdNduPXcnxjvk5JZ/KlJXQng=; b=cjDhUdBAFIGsJ9obiN1TiSuDl4ooZ7uZ/WnbSr1AR7QkNXfBNfTtBw6BsxhZ6WEWI2fdnadX1MDRH5cyMrlnF4uZBL0Ob00l4w40yKgHmAoYCsaSQDpeQ+XNXBi6WphmtFJ1eD8RfYNAt0WhAN1cjlrOMGB0dL5GnSggsbCdnhk= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduAgAALAICAAAXAAIAAAeWAgAAD6wA= Date: Wed, 11 May 2022 16:01:46 +0000 Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> <0a1faec6-b265-567e-0ad1-478dff6bc81d@xen.org> In-Reply-To: <0a1faec6-b265-567e-0ad1-478dff6bc81d@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0afa3262-b9ba-4b3d-3124-08da33679209 x-ms-traffictypediagnostic: DB7PR08MB3708:EE_|AM5EUR03FT027:EE_|PAXPR08MB6686:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4h9GrFvXCUieCXsM/HPJOs2kIW2gzKlkEMLCdnGv3ZwDYHqVzeU3szppzLTILRltLcL9Bo72XtL2Paszd/jn1dFHS7iI3jFE8y3C5McQOpw2sB6z0dxJrvAP3QLZR1QB3H3/T56Ikl5eUQ7KtFu/XEw1sAkwGLMxYMdWLMjPFv0S+8pxKs/LqaQAAEB22rhFcn1Z8XEsBuvVNNKRJn3R0oD/kTfuV5DSur6JCqYHKiRGgNjkYgJw2n9G4IAeAXabW+zgBsR2n3XfZiUWLaBccHG02exYrxITrGDNydz6QWD80binFefzDGFyG9s/kD9QchoU9F1/vdZg+NrhoYG4XQ64+2B4avHw2by4Gir4j+gtCPwBlMWIyYCqKMP9K5WVoCwPigHdB8sGBzcEesBTthRDE9y88E7ZFnDP4naORnZGsDo72HoTyYP0RrpaT4eUVXhsX/U0AScjAA0geo3phK/rs8tIL4SOJWStD9Z4Qe6ixQCfJyU87z5dYcJeO/A9P57M6kBpgIvKJbf6DQUr0SBDzGC0gUZlDEEdutCKqVFrFSovrWBkX4aVEgPjp0XCUtR2dhEzks8g8qAQ9xvNj+KkNiA3rr4FTQ2k5h6bBdaDyIeJdja9OhhxyflT3iv0oIsqNkaFU0i1jbdRu8Nc2qa4jeIY8usFhIJe1WjBDo9KiCg0smCHfLCcEITZ2QJfw75Yy860wYLYVhnUBYVIOcNeqZzmSxH5jj/x3ndgxUwBGQma9Y2hfQbDg8xG7tfR/9A4DxK5Mc7L1G3gi+7G3ysVKnijvPNddF6zAzAc44U0xqUcElyCWX+HRRmOGPsxlFoI47m6cg2Aw+5uOOuXtQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(33656002)(2616005)(26005)(122000001)(38100700002)(91956017)(53546011)(5660300002)(36756003)(83380400001)(6506007)(8936002)(38070700005)(316002)(966005)(6486002)(6512007)(508600001)(66476007)(64756008)(66446008)(66556008)(66946007)(76116006)(54906003)(8676002)(4326008)(71200400001)(6916009)(186003)(2906002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3708 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e570fb3c-cc8b-475e-e6d6-08da33678d12 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nO3Jj9ed+yFxyIoMR3qsw3JEBjMY5UnuA9RO6Y5hmpcJnSG29fCJyWQxdxuKVAEekuFtTRiltnWmY1G8ysqfTDYDJC2lGL3G0Ffhb/D5r2ybYHV2EBQ6s/eq9ndvm9eqoj0goNcSXc8bu2Em6gDCFIVsQ7vNGOhvFpqqGYNgihudXiSCC2R5P07okQQjMyXJMfVLP6yczGikQmOIKBgJUk4f971oQE+sHI97TsV9pJEHEa2N68qYKXIR9julkiBYKYFgrfLjLDtUOFYRfGmc/sYAPMz1DUP3DlhQPbpD0l6tzUZ0ER4huTVTx2e4a3EF+DOq6cZsBdWCvxGXo/A+cvtsKOfqX5zrSXm8g0yLLLmyVCbpL7+yhvahvcAMEyyIC3RaNJ84dWZBAUWX935ctQWumSxwJf7kD5kCwhTowD7acyfwwPMuOtkDJ0/MQBgRWB74HYlJlzCS6juAArRWhcXgznRdK3eS/OsicWirwNR8EVgBzXIhv00hP8JaVuZ6TeB2FoLMp6ipDI5M4cq0Qxeapm7bAdNsMfad1Pn0e5I9qprJHCdXaD+LbvSLG715pdrfMtRNhtDCz0JqI1mvMLMUuTYGe71AGvIgKMiMT6nw6Hvs4PgHqc/aAENzBJEsrG0klRFCAAGeC882/uPqPOuxrfp+quRVbVy/avxcgKsWW6Z+JPjn52OuytMy7TVbAeZoywFGuk5pMxoOsw5XIl/62/vurdfa5rVZQ9yFoJ+WXPSjWSjqzKO4L7v9VY9CKrOmBa21ug3fyMyoCz7WDw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(70206006)(966005)(6512007)(26005)(316002)(6486002)(508600001)(47076005)(4326008)(40460700003)(36860700001)(186003)(2906002)(81166007)(6862004)(54906003)(8676002)(336012)(86362001)(356005)(70586007)(82310400005)(33656002)(2616005)(83380400001)(8936002)(6506007)(107886003)(53546011)(5660300002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 16:01:55.0301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0afa3262-b9ba-4b3d-3124-08da33679209 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6686 Hi, > On 11 May 2022, at 16:47, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > On 11/05/2022 16:40, Bertrand Marquis wrote: >>> On 11 May 2022, at 16:20, Julien Grall wrote: >>> Technically, speaking you only copied the code from Linux and therefore= you are not the author of some of the changes. >>>=20 >>> For such case, our general process is: >> Could you tell me where this process is described ? >=20 > The closest description I could find is: >=20 > https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Ddocs/process/sen= ding-patches.pandoc;h=3D7ff7826c992b68804b41cc4a8605329f7a10e44c;hb=3DHEAD#= l75 This state to give the origin which I can easily do for my patch. But it does not state that we need to list all the authors from all changes= in the origin. Are you only requesting to modify my patch to add one origin line with the = SHA or to actually list all authors of all patches for all changes between = the previous state in Xen and the state after my patch ? >=20 >>> 1) Backport the commit as-is (i.e the Author is the original Author) >>> 2) Add the tag Origin (recently introduced) >>> 3) Add your signed-off-by >> So following this theory, if we import a file from Linux we should list = all the people who contributed to it since it was created ? >=20 > Technically yes. But this does not apply here as I am not back porting a patch but syncing a= file. The origin as said upper should be enough to get this information. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 16:25:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 16:25:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327100.549826 (Exim 4.92) (envelope-from ) id 1nop9I-0001OU-Ns; Wed, 11 May 2022 16:25:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327100.549826; Wed, 11 May 2022 16:25:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nop9I-0001ON-JG; Wed, 11 May 2022 16:25:16 +0000 Received: by outflank-mailman (input) for mailman id 327100; Wed, 11 May 2022 16:25:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nop9G-0001OH-Nc for xen-devel@lists.xenproject.org; Wed, 11 May 2022 16:25:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nop9E-0002jG-Jl; Wed, 11 May 2022 16:25:12 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nop9E-0000VZ-DT; Wed, 11 May 2022 16:25:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dXupqShq+dtvCWywt1KvffqVJ1KKzm32vQnxTMmFV0Y=; b=sJ+gSsAfISfu6NdzcyME/a6NxP WGnCf3IN9Adyw7MbqGoZCw6rrKm5yqRkHr1tVXsZyZcY2ImVeXNzUCQ4Bt2+GefLSWuKosYtXYd2W OPs5r332xcP1WP93e+04EMf5gAPy91O6wUI+/T5WamUTCi/nDjKJ6UKMM4F4J2mZCEi8=; Message-ID: Date: Wed, 11 May 2022 17:25:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 To: Bertrand Marquis Cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> <0a1faec6-b265-567e-0ad1-478dff6bc81d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/05/2022 17:01, Bertrand Marquis wrote: > Hi, > >> On 11 May 2022, at 16:47, Julien Grall wrote: >> >> Hi Bertrand, >> >> On 11/05/2022 16:40, Bertrand Marquis wrote: >>>> On 11 May 2022, at 16:20, Julien Grall wrote: >>>> Technically, speaking you only copied the code from Linux and therefore you are not the author of some of the changes. >>>> >>>> For such case, our general process is: >>> Could you tell me where this process is described ? >> >> The closest description I could find is: >> >> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/process/sending-patches.pandoc;h=7ff7826c992b68804b41cc4a8605329f7a10e44c;hb=HEAD#l75 > > This state to give the origin which I can easily do for my patch. > But it does not state that we need to list all the authors from all changes in the origin. Hmmmm.... I guess we are reading the following statement differently: All tags **above** the `Origin:` tag are from the original patch (which should all be kept), while tags **after** `Origin:` are related to the normal Xen patch process as described here. > > Are you only requesting to modify my patch to add one origin line with the SHA or to actually list all authors of all patches for all changes between the previous state in Xen and the state after my patch ? > >> >>>> 1) Backport the commit as-is (i.e the Author is the original Author) >>>> 2) Add the tag Origin (recently introduced) >>>> 3) Add your signed-off-by >>> So following this theory, if we import a file from Linux we should list all the people who contributed to it since it was created ? >> >> Technically yes. > > But this does not apply here as I am not back porting a patch but syncing a file. I am not sure why you want to differentiate the two. In the latter it is actually easy to find the authors (you are syncing after all!): git log lastbaseline...newbaseline myfile.c The result could be pasted in the commit message. As the code is meant to follow Linux, then all the commits in the list should be valid for Xen. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 16:29:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 16:29:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327108.549837 (Exim 4.92) (envelope-from ) id 1nopDW-00025a-EX; Wed, 11 May 2022 16:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327108.549837; Wed, 11 May 2022 16:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopDW-00025T-Ad; Wed, 11 May 2022 16:29:38 +0000 Received: by outflank-mailman (input) for mailman id 327108; Wed, 11 May 2022 16:29:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopDV-00025J-UJ; Wed, 11 May 2022 16:29:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopDV-0002ns-TU; Wed, 11 May 2022 16:29:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopDV-00060y-HQ; Wed, 11 May 2022 16:29:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nopDV-0008Jg-Gx; Wed, 11 May 2022 16:29:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5FPI09iNJzJ1VEUx14Lmz5UMilaWTee8/3HUue5ReFc=; b=UxUEzDW7LANwRfG0pk2IUJ5uRN b2YXU59Blbek4KzTwE2YscG0jo6tFbY8qruL0k7u+hZnE1OQ7eJrV30DhmpA8KITPijl1kEyKDmS/ mP0M9c6a+TgUdobPvXP/Fp9rbckW7Ycvzvd/VBryxDGdEZu5mylKbLakumgvxyECXk74=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170330: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 16:29:37 +0000 flight 170330 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170330/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 939 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 16:47:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 16:47:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327117.549848 (Exim 4.92) (envelope-from ) id 1nopV2-0004Vm-UY; Wed, 11 May 2022 16:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327117.549848; Wed, 11 May 2022 16:47:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopV2-0004Vf-RJ; Wed, 11 May 2022 16:47:44 +0000 Received: by outflank-mailman (input) for mailman id 327117; Wed, 11 May 2022 16:47:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopV2-0004VZ-60 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 16:47:44 +0000 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 125ad827-d14a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 18:47:42 +0200 (CEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24BESoKr028080; Wed, 11 May 2022 16:46:00 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g0etx3406-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 16:46:00 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24BGebih023228; Wed, 11 May 2022 16:45:59 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g0etx33y1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 16:45:59 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24BGgY6p030999; Wed, 11 May 2022 16:45:56 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 3fwgd8wsc9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 May 2022 16:45:55 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24BGjqsM27197764 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 16:45:52 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA0B35204E; Wed, 11 May 2022 16:45:52 +0000 (GMT) Received: from osiris (unknown [9.145.80.86]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id B9FCE52050; Wed, 11 May 2022 16:45:50 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 125ad827-d14a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=tjIW4ViQYza/lnoDnWyOhboEO5kjiPdt7taCyynzKFw=; b=lxUbqAEO3GqUpU+Tuw2IWXF1fzXIGSDn1j9FVHjMmFIPrrH/+bQrVN9PaaYcbEJhBJIr 7d0t++ZFM6UKMdcnwcUF0YasHW2SP51KwmfPJnRgOou9+kRarIXLa3hIMjmu5cX5t3FO 6rItwaIor28IfP+e6c0HY1HIerMLLjGg06tg70umpoMhCUKjDu0piWYCrZz/VisJ+s0b 0DuyX+X+ttOZsVNhvwPdzqfPCbp/RA3MDqZWBEVZBj0PN/wvhGTqQYzQ4imgN+k8TjhU NC3v9IrNMZOoN56TSdKZo20ktYuMVwJV19grssXUZ/JxpGndCu9D0HmYa5fO310s9Ten QA== Date: Wed, 11 May 2022 18:45:49 +0200 From: Heiko Carstens To: "Guilherme G. Piccoli" Cc: Alexander Gordeev , Christian Borntraeger , "David S. Miller" , Sven Schnelle , Vasily Gorbik , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-23-gpiccoli@igalia.com> <7017c234-7c73-524a-11b6-fefdd5646f59@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7017c234-7c73-524a-11b6-fefdd5646f59@igalia.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: P8jYmW-Xe3lS0Lxn9LfjJuLQx8-pWyu5 X-Proofpoint-ORIG-GUID: 3EoVOe4XNkWaSjwGnBLNECSOqY142ccD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-11_07,2022-05-11_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=429 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205110076 On Mon, May 09, 2022 at 11:16:10AM -0300, Guilherme G. Piccoli wrote: > On 27/04/2022 19:49, Guilherme G. Piccoli wrote: > > Currently we have 3 notifier lists in the panic path, which will > > be wired in a way to allow the notifier callbacks to run in > > different moments at panic time, in a subsequent patch. > > > > But there is also an odd set of architecture calls hardcoded in > > the end of panic path, after the restart machinery. They're > > responsible for late time tunings / events, like enabling a stop > > button (Sparc) or effectively stopping the machine (s390). > > > > This patch introduces yet another notifier list to offer the > > architectures a way to add callbacks in such late moment on > > panic path without the need of ifdefs / hardcoded approaches. > > > > Cc: Alexander Gordeev > > Cc: Christian Borntraeger > > Cc: "David S. Miller" > > Cc: Heiko Carstens > > Cc: Sven Schnelle > > Cc: Vasily Gorbik > > Signed-off-by: Guilherme G. Piccoli > > Hey S390/SPARC folks, sorry for the ping! > > Any reviews on this V1 would be greatly appreciated, I'm working on V2 > and seeking feedback in the non-reviewed patches. Sorry, missed that this is quite s390 specific. So, yes, this looks good to me and nice to see that one of the remaining CONFIG_S390 in common code will be removed! For the s390 bits: Acked-by: Heiko Carstens From xen-devel-bounces@lists.xenproject.org Wed May 11 17:16:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 17:16:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327124.549858 (Exim 4.92) (envelope-from ) id 1nopwl-0007wY-6p; Wed, 11 May 2022 17:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327124.549858; Wed, 11 May 2022 17:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopwl-0007wR-3z; Wed, 11 May 2022 17:16:23 +0000 Received: by outflank-mailman (input) for mailman id 327124; Wed, 11 May 2022 17:16:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopwk-0007wH-Bp; Wed, 11 May 2022 17:16:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopwk-0003eL-7U; Wed, 11 May 2022 17:16:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nopwj-00070X-RV; Wed, 11 May 2022 17:16:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nopwj-0001LO-R1; Wed, 11 May 2022 17:16:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UJ8b/IuK2BR6s/R2MWvxdzS+0fX2UvYvIm22fYLNX8M=; b=mt0W/aCrgI0KCces/CZDsRauGV Yszw1EHWDSL/9KjT+oxjFz8Vp+a48VjXGq0qd0DOZt/HG5rhyV3vruhcLuwEfDYZWWBGiVIauLUo8 T5dlh0WunUfezG2Vls+07fpoeQhcsyCTXpGzrxt7dwp0fFsLHzoIOl8F099JdaUsZKqM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170331: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 17:16:21 +0000 flight 170331 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170331/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 940 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 18:00:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327140.549874 (Exim 4.92) (envelope-from ) id 1noqdP-0004qu-Lj; Wed, 11 May 2022 18:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327140.549874; Wed, 11 May 2022 18:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdP-0004qn-Hq; Wed, 11 May 2022 18:00:27 +0000 Received: by outflank-mailman (input) for mailman id 327140; Wed, 11 May 2022 18:00:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdO-0004qh-G7 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:00:26 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b4078dc-d154-11ec-a406-831a346695d4; Wed, 11 May 2022 20:00:24 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id 4so3582107ljw.11 for ; Wed, 11 May 2022 11:00:24 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s9-20020a19ad49000000b0047255d21131sm382089lfd.96.2022.05.11.11.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 11:00:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b4078dc-d154-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=E8mjJ6/ikRW6L571DVojfVrb9ZxPwMSvTMao2Z2WwQs=; b=CxXImu2j0+p3LHhyN50CJeB53M+2Hb3IcMtcPocNwHtOPLHymInaRXaqIkerIMFi7H 3AAk7OAUSRSMVl2kweGmfn7v1SUHYCFVml14xpbzHUO+LI0KCa8TC32claH6Tki5FmF9 PzVDHN5YibHIpuwYghdy4NwMdrtdetm177DeXhXLmsteu0ZBOJmPAlovXFCUdjJLUfX6 L2+5D8Ort7kY8A7FVQywUetv79hWfG9Vqc+nAhyefHOmAfaqZcxDdxNOreZExbSD7xgA OEG8Bp97wkINldw+lYKZ9J6zvn4Y7SQq8AtGS0ZZ3FBCHpJt5QfnhSruyWa1RMmeGNbL yRzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E8mjJ6/ikRW6L571DVojfVrb9ZxPwMSvTMao2Z2WwQs=; b=d6avRsegd5cIiuNoa0z9hotyz++4gzR54e3C4Y+7sWfS4oZnTyaPG3EKbbg/p70Tpa Vx0WbRd9SOerYNdbBRpHUuMbfaM+L7TTn4zmcCA5U7tiL1Sty3/7yaevwLtFw7LhcfmK 8ZNIU7vJbHf/r19V4UULsZ100CU06lrf61NKT9mZ7pOh89rRA255FMYB0ytOdgSKOBy2 J+NKQdWKMF7tu4GuHRost4//Te4JYZBokg2PMHev+2tXXdGNmmBGwKTjWZ2Cvm7apkv4 FCaMDQu+K61sGzkOZMzqLTVxJCawsqvkZ5SuYNR7r+hGzPhXMAo+FbwwhX08n5JXbOFk MBgg== X-Gm-Message-State: AOAM533QHSfGYwS6isd2xeqzntAyEE8B1FZZM4xedpV+d17AJIMeDVR4 +W5hKbJGrzOrnhGUnO9XfG0= X-Google-Smtp-Source: ABdhPJwEES/rkW+laUoE12K+xOg2R39+JFoCFELxlp3+devgkaiCx/4uXvllW3Tr1XtvaKaEyM0+YA== X-Received: by 2002:a05:651c:50a:b0:24f:50a2:beda with SMTP id o10-20020a05651c050a00b0024f50a2bedamr18420964ljp.189.1652292023783; Wed, 11 May 2022 11:00:23 -0700 (PDT) Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants From: Oleksandr To: Boris Ostrovsky , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juergen Gross , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> Message-ID: <8409e636-94e3-e231-f181-c76a849534a1@gmail.com> Date: Wed, 11 May 2022 21:00:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1651947548-4055-3-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 07.05.22 21:19, Oleksandr Tyshchenko wrote: Hello Boris, Stefano > From: Juergen Gross > > For support of virtio via grant mappings in rare cases larger mappings > using consecutive grants are needed. Support those by adding a bitmap > of free grants. > > As consecutive grants will be needed only in very rare cases (e.g. when > configuring a virtio device with a multi-page ring), optimize for the > normal case of non-consecutive allocations. > > Signed-off-by: Juergen Gross > --- > Changes RFC -> V1: > - no changes > > Changes V1 -> V2: > - no changes May I please ask for the review here? This patch has been tested in various scenarios: 1. Guest with Xen PV drivers only (gnttab_alloc(free)_grant_reference() usage only) 2. Guest with Virtio drivers only (gnttab_alloc(free)_grant_reference_seq() usage only) 3. Guest with Virtio and Xen PV drivers (combined gnttab_alloc(free)_grant_reference() and gnttab_alloc(free)_grant_reference_seq() usage) > --- > drivers/xen/grant-table.c | 238 +++++++++++++++++++++++++++++++++++++++------- > include/xen/grant_table.h | 4 + > 2 files changed, 210 insertions(+), 32 deletions(-) > > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > index 8ccccac..1b458c0 100644 > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -33,6 +33,7 @@ > > #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt > > +#include > #include > #include > #include > @@ -72,9 +73,32 @@ > > static grant_ref_t **gnttab_list; > static unsigned int nr_grant_frames; > + > +/* > + * Handling of free grants: > + * > + * Free grants are in a simple list anchored in gnttab_free_head. They are > + * linked by grant ref, the last element contains GNTTAB_LIST_END. The number > + * of free entries is stored in gnttab_free_count. > + * Additionally there is a bitmap of free entries anchored in > + * gnttab_free_bitmap. This is being used for simplifying allocation of > + * multiple consecutive grants, which is needed e.g. for support of virtio. > + * gnttab_last_free is used to add free entries of new frames at the end of > + * the free list. > + * gnttab_free_tail_ptr specifies the variable which references the start > + * of consecutive free grants ending with gnttab_last_free. This pointer is > + * updated in a rather defensive way, in order to avoid performance hits in > + * hot paths. > + * All those variables are protected by gnttab_list_lock. > + */ > static int gnttab_free_count; > -static grant_ref_t gnttab_free_head; > +static unsigned int gnttab_size; > +static grant_ref_t gnttab_free_head = GNTTAB_LIST_END; > +static grant_ref_t gnttab_last_free = GNTTAB_LIST_END; > +static grant_ref_t *gnttab_free_tail_ptr; > +static unsigned long *gnttab_free_bitmap; > static DEFINE_SPINLOCK(gnttab_list_lock); > + > struct grant_frames xen_auto_xlat_grant_frames; > static unsigned int xen_gnttab_version; > module_param_named(version, xen_gnttab_version, uint, 0); > @@ -170,16 +194,111 @@ static int get_free_entries(unsigned count) > > ref = head = gnttab_free_head; > gnttab_free_count -= count; > - while (count-- > 1) > - head = gnttab_entry(head); > + while (count--) { > + bitmap_clear(gnttab_free_bitmap, head, 1); > + if (gnttab_free_tail_ptr == __gnttab_entry(head)) > + gnttab_free_tail_ptr = &gnttab_free_head; > + if (count) > + head = gnttab_entry(head); > + } > gnttab_free_head = gnttab_entry(head); > gnttab_entry(head) = GNTTAB_LIST_END; > > + if (!gnttab_free_count) { > + gnttab_last_free = GNTTAB_LIST_END; > + gnttab_free_tail_ptr = NULL; > + } > + > spin_unlock_irqrestore(&gnttab_list_lock, flags); > > return ref; > } > > +static int get_seq_entry_count(void) > +{ > + if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr || > + *gnttab_free_tail_ptr == GNTTAB_LIST_END) > + return 0; > + > + return gnttab_last_free - *gnttab_free_tail_ptr + 1; > +} > + > +/* Rebuilds the free grant list and tries to find count consecutive entries. */ > +static int get_free_seq(unsigned int count) > +{ > + int ret = -ENOSPC; > + unsigned int from, to; > + grant_ref_t *last; > + > + gnttab_free_tail_ptr = &gnttab_free_head; > + last = &gnttab_free_head; > + > + for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); > + from < gnttab_size; > + from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { > + to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, > + from + 1); > + if (ret < 0 && to - from >= count) { > + ret = from; > + bitmap_clear(gnttab_free_bitmap, ret, count); > + from += count; > + gnttab_free_count -= count; > + if (from == to) > + continue; > + } > + > + while (from < to) { > + *last = from; > + last = __gnttab_entry(from); > + gnttab_last_free = from; > + from++; > + } > + if (to < gnttab_size) > + gnttab_free_tail_ptr = __gnttab_entry(to - 1); > + } > + > + *last = GNTTAB_LIST_END; > + if (gnttab_last_free != gnttab_size - 1) > + gnttab_free_tail_ptr = NULL; > + > + return ret; > +} > + > +static int get_free_entries_seq(unsigned int count) > +{ > + unsigned long flags; > + int ret = 0; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + > + if (gnttab_free_count < count) { > + ret = gnttab_expand(count - gnttab_free_count); > + if (ret < 0) > + goto out; > + } > + > + if (get_seq_entry_count() < count) { > + ret = get_free_seq(count); > + if (ret >= 0) > + goto out; > + ret = gnttab_expand(count - get_seq_entry_count()); > + if (ret < 0) > + goto out; > + } > + > + ret = *gnttab_free_tail_ptr; > + *gnttab_free_tail_ptr = gnttab_entry(ret + count - 1); > + gnttab_free_count -= count; > + if (!gnttab_free_count) > + gnttab_free_tail_ptr = NULL; > + bitmap_clear(gnttab_free_bitmap, ret, count); > + > + out: > + spin_unlock_irqrestore(&gnttab_list_lock, flags); > + > + return ret; > +} > + > static void do_free_callbacks(void) > { > struct gnttab_free_callback *callback, *next; > @@ -206,17 +325,48 @@ static inline void check_free_callbacks(void) > do_free_callbacks(); > } > > -static void put_free_entry(grant_ref_t ref) > +static void put_free_entry_locked(grant_ref_t ref) > { > - unsigned long flags; > - spin_lock_irqsave(&gnttab_list_lock, flags); > gnttab_entry(ref) = gnttab_free_head; > gnttab_free_head = ref; > + if (!gnttab_free_count) > + gnttab_last_free = ref; > + if (gnttab_free_tail_ptr == &gnttab_free_head) > + gnttab_free_tail_ptr = __gnttab_entry(ref); > gnttab_free_count++; > + bitmap_set(gnttab_free_bitmap, ref, 1); > +} > + > +static void put_free_entry(grant_ref_t ref) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + put_free_entry_locked(ref); > check_free_callbacks(); > spin_unlock_irqrestore(&gnttab_list_lock, flags); > } > > +static void gnttab_set_free(unsigned int start, unsigned int n) > +{ > + unsigned int i; > + > + for (i = start; i < start + n - 1; i++) > + gnttab_entry(i) = i + 1; > + > + gnttab_entry(i) = GNTTAB_LIST_END; > + if (!gnttab_free_count) { > + gnttab_free_head = start; > + gnttab_free_tail_ptr = &gnttab_free_head; > + } else { > + gnttab_entry(gnttab_last_free) = start; > + } > + gnttab_free_count += n; > + gnttab_last_free = i; > + > + bitmap_set(gnttab_free_bitmap, start, n); > +} > + > /* > * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2. > * Introducing a valid entry into the grant table: > @@ -448,23 +598,31 @@ void gnttab_free_grant_references(grant_ref_t head) > { > grant_ref_t ref; > unsigned long flags; > - int count = 1; > - if (head == GNTTAB_LIST_END) > - return; > + > spin_lock_irqsave(&gnttab_list_lock, flags); > - ref = head; > - while (gnttab_entry(ref) != GNTTAB_LIST_END) { > - ref = gnttab_entry(ref); > - count++; > + while (head != GNTTAB_LIST_END) { > + ref = gnttab_entry(head); > + put_free_entry_locked(head); > + head = ref; > } > - gnttab_entry(ref) = gnttab_free_head; > - gnttab_free_head = head; > - gnttab_free_count += count; > check_free_callbacks(); > spin_unlock_irqrestore(&gnttab_list_lock, flags); > } > EXPORT_SYMBOL_GPL(gnttab_free_grant_references); > > +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count) > +{ > + unsigned long flags; > + unsigned int i; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + for (i = count; i > 0; i--) > + put_free_entry_locked(head + i - 1); > + check_free_callbacks(); > + spin_unlock_irqrestore(&gnttab_list_lock, flags); > +} > +EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq); > + > int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) > { > int h = get_free_entries(count); > @@ -478,6 +636,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) > } > EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references); > > +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first) > +{ > + int h; > + > + if (count == 1) > + h = get_free_entries(1); > + else > + h = get_free_entries_seq(count); > + > + if (h < 0) > + return -ENOSPC; > + > + *first = h; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq); > + > int gnttab_empty_grant_references(const grant_ref_t *private_head) > { > return (*private_head == GNTTAB_LIST_END); > @@ -570,16 +746,13 @@ static int grow_gnttab_list(unsigned int more_frames) > goto grow_nomem; > } > > + gnttab_set_free(gnttab_size, extra_entries); > > - for (i = grefs_per_frame * nr_grant_frames; > - i < grefs_per_frame * new_nr_grant_frames - 1; i++) > - gnttab_entry(i) = i + 1; > - > - gnttab_entry(i) = gnttab_free_head; > - gnttab_free_head = grefs_per_frame * nr_grant_frames; > - gnttab_free_count += extra_entries; > + if (!gnttab_free_tail_ptr) > + gnttab_free_tail_ptr = __gnttab_entry(gnttab_size); > > nr_grant_frames = new_nr_grant_frames; > + gnttab_size += extra_entries; > > check_free_callbacks(); > > @@ -1424,7 +1597,6 @@ int gnttab_init(void) > int i; > unsigned long max_nr_grant_frames; > unsigned int max_nr_glist_frames, nr_glist_frames; > - unsigned int nr_init_grefs; > int ret; > > gnttab_request_version(); > @@ -1452,6 +1624,13 @@ int gnttab_init(void) > } > } > > + i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; > + gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); > + if (!gnttab_free_bitmap) { > + ret = -ENOMEM; > + goto ini_nomem; > + } > + > ret = arch_gnttab_init(max_nr_grant_frames, > nr_status_frames(max_nr_grant_frames)); > if (ret < 0) > @@ -1462,15 +1641,9 @@ int gnttab_init(void) > goto ini_nomem; > } > > - nr_init_grefs = nr_grant_frames * > - gnttab_interface->grefs_per_grant_frame; > - > - for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) > - gnttab_entry(i) = i + 1; > + gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame; > > - gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END; > - gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES; > - gnttab_free_head = NR_RESERVED_ENTRIES; > + gnttab_set_free(NR_RESERVED_ENTRIES, gnttab_size - NR_RESERVED_ENTRIES); > > printk("Grant table initialized\n"); > return 0; > @@ -1479,6 +1652,7 @@ int gnttab_init(void) > for (i--; i >= 0; i--) > free_page((unsigned long)gnttab_list[i]); > kfree(gnttab_list); > + bitmap_free(gnttab_free_bitmap); > return ret; > } > EXPORT_SYMBOL_GPL(gnttab_init); > diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h > index dfd5bf3..d815e1d 100644 > --- a/include/xen/grant_table.h > +++ b/include/xen/grant_table.h > @@ -129,10 +129,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref); > */ > int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head); > > +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first); > + > void gnttab_free_grant_reference(grant_ref_t ref); > > void gnttab_free_grant_references(grant_ref_t head); > > +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count); > + > int gnttab_empty_grant_references(const grant_ref_t *pprivate_head); > > int gnttab_claim_grant_reference(grant_ref_t *pprivate_head); -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 11 18:00:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327141.549885 (Exim 4.92) (envelope-from ) id 1noqdU-00057I-4L; Wed, 11 May 2022 18:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327141.549885; Wed, 11 May 2022 18:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdT-00057B-WA; Wed, 11 May 2022 18:00:31 +0000 Received: by outflank-mailman (input) for mailman id 327141; Wed, 11 May 2022 18:00:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdS-00056W-ER; Wed, 11 May 2022 18:00:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdS-0004UB-Ba; Wed, 11 May 2022 18:00:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqdR-0007yH-UF; Wed, 11 May 2022 18:00:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noqdR-0004HM-Tm; Wed, 11 May 2022 18:00:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gHraYhWrgmh5zDNB8BD2iNB5QeRHzBOihaByF9kYoQI=; b=TPB9HQr9sD62nUSzphX4ePKSOH OZH+8jm6oYus1x/bJGTdN+yYc5ftG5fO1R2e0bMQF+IIu41ncrCnooz7vLyrTYEbUd5y8H2475b6z xE1e/Ei1UdbJdPfAX7ZBwK9HVMZr/AoL2tv9mWDhcO/TxujIE5O2mMsw5kbOMPk3c/+Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170332: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 18:00:29 +0000 flight 170332 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170332/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 941 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 18:17:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327158.549896 (Exim 4.92) (envelope-from ) id 1noqtk-00078x-Hy; Wed, 11 May 2022 18:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327158.549896; Wed, 11 May 2022 18:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqtk-00078q-F1; Wed, 11 May 2022 18:17:20 +0000 Received: by outflank-mailman (input) for mailman id 327158; Wed, 11 May 2022 18:17:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noqtj-00078k-Kh for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:17:19 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9622f67b-d156-11ec-a406-831a346695d4; Wed, 11 May 2022 20:17:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 56E5F5C015E; Wed, 11 May 2022 14:17:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 11 May 2022 14:17:15 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 14:17:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9622f67b-d156-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652293035; x= 1652379435; bh=TO+GqyFnTI/pf072RiK9r3IdYfVARkWkwasT5MlalV8=; b=b QXauU/Z3bqqP7RZ/6wMnNif/hgb9dR/OWKx/CX+eP2gCYjfRQdLUJiU19Cz1q47d OW2L2pMWrGePPAVJBtcs5369x6WiesFQtp7IH0cVAQPMppkXnLLP4kCPq/pVA0Rc DmrSzI2QlBegVsFcMcYJ1ecyeyUNMzsNDtvRE8onm7xaT7acKnC1X9tyc1cu9Ibe bSPUEuo8+OOaSF1gzIsZqxXJ1azbXfqtLsmI9nMITlanH7UcxRa/k7iaNhtjUUu1 eNG+bfJwA7OD/wsuo/GYAnHmp5fhPTaESMqR95iB8EEjEUstjd03MnnsSajyTOXn duK5gz0u1UqIig8kp6WPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Date: Wed, 11 May 2022 14:17:07 -0400 From: Demi Marie Obenour To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Mariusz Zaborski Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="42BegwPzcK8eA5+l" Content-Disposition: inline In-Reply-To: --42BegwPzcK8eA5+l Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 11 May 2022 14:17:07 -0400 From: Demi Marie Obenour To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Xen developer discussion , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Mariusz Zaborski Subject: Re: Proposal: use disk sequence numbers to avoid races in blkback On Wed, May 11, 2022 at 09:37:54AM +0200, Roger Pau Monn=C3=A9 wrote: > On Tue, May 10, 2022 at 12:22:51PM -0400, Demi Marie Obenour wrote: > > On Tue, May 10, 2022 at 12:57:48PM +0200, Roger Pau Monn=C3=A9 wrote: > > > On Thu, May 05, 2022 at 08:30:17PM -0400, Demi Marie Obenour wrote: > > > > Proposal: Check disk sequence numbers in blkback > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > > > >=20 > > > > Currently, adding block devices to a domain is racy. libxl writes = the > > > > major and minor number of the device to XenStore, but it does not k= eep > > > > the block device open until blkback has opened it. This creates a = race > > > > condition, as it is possible for the device to be destroyed and ano= ther > > > > device allocated with the same major and minor numbers. Loop devic= es > > > > are the most obvious example, since /dev/loop0 can be reused again = and > > > > again, but the same problem can also happen with device-mapper devi= ces. > > > > If the major and minor numbers are reused before blkback has attach= ed to > > > > the device, blkback will pass the wrong device to the domain, with > > > > obvious security consequences. > > > >=20 > > > > Other programs on Linux have the same problem, and a solution was > > > > committed upstream in the form of disk sequence numbers. A disk > > > > sequence number, or diskseq, is a 64-bit unsigned monotonically > > > > increasing counter. The combination of a major and minor number an= d a > > > > disk sequence number uniquely identifies a block device for the ent= ire > > > > uptime of the system. > > >=20 > > > Seems fine to me, this is just an extra check to make sure the block > > > device opened by blkback is the one that user space intended. I would > > > see diskseq as a kind of checksum. > >=20 > > Ideally, diskseq would be the primary means of identifying a device, but > > that isn=E2=80=99t an option without more substantial changes, sadly. > >=20 > > > > I propose that blkback check for an unsigned 64-bit hexadecimal Xen= Store > > > > entry named =E2=80=9Cdiskseq=E2=80=9D. If the entry exists, blkbac= k checks that the > > > > number stored there matches the disk sequence number of the device.= If > > > > it does not exist, the check is skipped. If reading the entry fail= s for > > > > any other reason, the entry is malformed, or if the sequence number= is > > > > wrong, blkback refuses to export the device. > > > >=20 > > > > The toolstack changes are more involved for two reasons: > > > >=20 > > > > 1. To ensure that loop devices are not leaked if the toolstack cras= hes, > > > > they must be created with the delete-on-close flag set. This > > > > requires that the toolstack hold the device open until blkback h= as > > > > acquired a handle to it. > > >=20 > > > Does this work with loop devices? I would expect that you need to > > > issue a losetup call to detach the device. > >=20 > > That is what the autoclear flag is for. It will cause the device to be > > destroyed by the kernel as soon as the last handle to it has been > > closed. This is why the toolstack needs to hold a file descriptor to > > the device. >=20 > What would happen if the backend closes the device (because the > connection is torn down) and then try to open it again (because the > guest has triggered a reconnection)? The reconnect attempt will fail for loop devices, and may fail for device-mapper devices. Unless somebody holds the device open until it has been removed from the guest, reconnect is inherently racy. That somebody could be the toolstack, a daemon such as libvirtd, or the kernel. > > > Even more, the loop device is created by the block script, but there's > > > also a window between the block script execution and the toolstack > > > knowing about the device, which could also allow for a leak? > >=20 > > For this to work, either the toolstack or block script will need to open > > the file and perform loop(4) ioctls to assign the file descriptor to a > > loop device. This cannot be done by a shell script, so I plan on using > > a C program to perform these tasks. In Qubes OS, I expect this program > > to replace the block script entirely, as performance is critical and > > flexibility less so. For upstream, I recommend having the block script > > be a script that calls this C program. >=20 > block scripts can be plain binary executables, so I think it would be > fine for libxl to just call the executable directly. Marek had suggested that keeping the block script a script would be useful for admins, but I am fine with just using a binary. > > > > 2. For block devices that are opened by path, the toolstack needs to > > > > ensure that the device it has opened is actually the device it > > > > intended to open. This requires device-specific verification of= the > > > > open file descriptor. This is not needed for regular files, as = the > > > > LOOP_CONFIGURE ioctl is called on an existing loop device and se= ts > > > > its backing file. > > > >=20 > > > > The first is fairly easy in C. It can be accomplished by means of a > > > > XenStore watch on the =E2=80=9Cstatus=E2=80=9D entry. Once that wa= tch fires, blkback > > > > has opened the device, so the toolstack can safely close its file > > > > descriptor. > > >=20 > > > Does the toolstack really need to close the device? What harm does it > > > do to keep the handle open until the domain is destroyed? > >=20 > > This would cause no harm, but it also would not help either, so I do not > > see any advantages to doing it. >=20 > Well, seems more complex because you need more synchronization between > blkback and the toolstack in order to detect when blkback has opened > the device. If this is not strictly required I would rather avoid it: > more complexity just leads to more errors. All of this synchronization can be handled by the block script. > > > What about disk hotplug? Which entity will keep the device opened in > > > that case? Is xl block-attach going to block until the device > > > switches to the connected state? > >=20 > > Whichever program opens the file will need to do this. =20 >=20 > This is not trivial to implement with xl, as `xl block-attach` is a > short-lived command that just populates the xenstore entries for the > to be attached device, runs the hotplug script and exits after that. > I'm not sure we would want to change `xl block-attach` behavior to > wait until the backend has opened the device. Anything else is racy, unless there is some program that could keep the FD open in the background. Welcome to the ugly world of Linux block device semantics. The problem with not using autoclear is that there is no race-free way I am aware of to clean up the loop device. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --42BegwPzcK8eA5+l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ7/acACgkQsoi1X/+c IsEzpxAArNm7atQOA4S2MeLCdQb3L33jkKrQ/H64q+n0tTzhSKCVI54h0Xvoc/ZM YwofPukafUY2lca1JUPuz1wVMiO92Bv7/q3Eo001D6PhPaF3DRh4Yr8Bwz4aBe4i pFA80TU0i8P/82Rac2DJxEzlc+uKAXqJsxHl8DRX5a93GROYQXi1SeJM7YNxS09V HtuAIx4QUelMtnF70SSbFUNeZGYX2qL9bDHqJAauyAG+X9Mp3QB29soYhJGKH6PG QToSs2Hf0XbXKhwpr4oodj8AGHetaR2JrJ25bTw7U4l10mjjPBV7legJuL04dY+1 x8lKQT2d685zXCLNOQn/UWVfHUUVc6o08ZbOt+hI879mppimdJa2er492GJMvmzW 7BcJk0dcwxG3Pg6zzcTyick5F1vw7941lHBZgaAhNo6may/puYU7Vzzic0FiYKtl hg+k/Rpwd+hgFBkkBrotWpzqY1EGq3RzRdOkoBN+ZaS+X2Bh7kaA8Jw6o2cT8gv4 yB0vh/I7uWXsLz9x+lc7b93/jo9t2R/baztvt6r/M+kaL7oKxCPXOUws1Z091Da+ vSZyQmDtbirlPK8UxUqIz1T1gN7/aXm6YaKN7vb+EooxrEtg320Lkk1ItPglJEqk DLRBCTdxQLRNfYOOIlPGY/GRi9GoZqQMI1h8i/KNNhwioahBaBA= =uLOb -----END PGP SIGNATURE----- --42BegwPzcK8eA5+l-- From xen-devel-bounces@lists.xenproject.org Wed May 11 18:42:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:42:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327168.549906 (Exim 4.92) (envelope-from ) id 1norHj-0001uF-Iv; Wed, 11 May 2022 18:42:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327168.549906; Wed, 11 May 2022 18:42:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norHj-0001u8-Fz; Wed, 11 May 2022 18:42:07 +0000 Received: by outflank-mailman (input) for mailman id 327168; Wed, 11 May 2022 18:42:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norHh-0001u2-VX for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:42:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norHh-0005Ba-Hw; Wed, 11 May 2022 18:42:05 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1norHh-0006Xh-BM; Wed, 11 May 2022 18:42:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZLqvh76PLKj7yfBCN6+rXVKaK3glka02lw9c5VDjSqM=; b=J2n0HnP7cvzYe13NSOO5pwIaec AGDsuAfpeThx+GHE6xGfj8GFge1n4729JXE4BMPSJBk5JQbKDz20TrSC08YlspUWl8tPiA6vAUJEJ KFwbFOFElSTGa2P98GRCNHX7/6kWBkGMaWH/XM+VrLiBB6/L6EO8XdClHNA3lxilisAk=; Message-ID: <7ad3d3b0-a048-5a63-3755-ae45af34e096@xen.org> Date: Wed, 11 May 2022 19:42:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 2/7] xen/arm: implement domU extended regions To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu , olekstysh@gmail.com References: <20220505001656.395419-2-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220505001656.395419-2-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/05/2022 01:16, Stefano Stabellini wrote: > From: Stefano Stabellini > > Implement extended regions for dom0less domUs. The implementation is > based on the libxl implementation. > > Also update docs for the ext_regions command line option. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Luca Fancellu Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 18:46:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327175.549918 (Exim 4.92) (envelope-from ) id 1norMP-0002Xo-7G; Wed, 11 May 2022 18:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327175.549918; Wed, 11 May 2022 18:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norMP-0002Xh-34; Wed, 11 May 2022 18:46:57 +0000 Received: by outflank-mailman (input) for mailman id 327175; Wed, 11 May 2022 18:46:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norMN-0002XX-KJ; Wed, 11 May 2022 18:46:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norMN-0005ID-J6; Wed, 11 May 2022 18:46:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norMN-0000Xy-0z; Wed, 11 May 2022 18:46:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1norMN-0006Ki-0Y; Wed, 11 May 2022 18:46:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2rbzzGxJ81PSv0iq5AQB4YERRfq5F+qFNYlAgM4DiPM=; b=ZBG3xHqj5cj+2Ym79vjna9r22m xDTvQzM95u9HHmUHHK+5SXT9XAL8h/SN0Dv1+AzNPytbFau/Zbtte+XLnYXmjUEF98IRFoeEzqprQ wjanLkGlLM7B9ToBe8RoUbi25o3vpg35C1j2dRXq5pmYn8EPILWmIQ4Aszs6VvpgVIEE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170333: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 18:46:55 +0000 flight 170333 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 942 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 18:47:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327184.549929 (Exim 4.92) (envelope-from ) id 1norN3-00037R-Kv; Wed, 11 May 2022 18:47:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327184.549929; Wed, 11 May 2022 18:47:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norN3-00037I-Hk; Wed, 11 May 2022 18:47:37 +0000 Received: by outflank-mailman (input) for mailman id 327184; Wed, 11 May 2022 18:47:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norN1-0002v4-Dp for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:47:35 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1d55fe6-d15a-11ec-a406-831a346695d4; Wed, 11 May 2022 20:47:34 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id h29so5156791lfj.2 for ; Wed, 11 May 2022 11:47:34 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id w12-20020a05651234cc00b0047255d21189sm396230lfr.184.2022.05.11.11.47.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2022 11:47:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1d55fe6-d15a-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=rJrb1Y/MtEkpzi57I2Ufi6iXumQ+ncjF8Z0TJQkBgl0=; b=l4YUKTRket6kMysPRpCQI0gA2EpzSPp/TlcpO3DXfiOVBygdBjuYBl0xPbRhkFOOYX txWMwaOzLtv/yKW9jRbEc4gOohor1H5qcfUFP/cmpwoHx0bnBBRPYVxXWdst0O0lDY5T qhB/e7HHzHwcl6OQqRShHzvyH7nkJZ7GqPr61VydaH/HWQQZKTXbM3nidmDn2rjl0BOr rVjHe8yLiCWKuwBW8t+jwOj6icLG3CJbup1wxX48qGwRJNPjzrLmuVl0I3pPw6tmSXzR U/8roWAeIz9zBUCAFErdgOigHMAeh8C8joRGiigGOdMy+mHhPf/lEYelb3tw6QHtsmCw eebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rJrb1Y/MtEkpzi57I2Ufi6iXumQ+ncjF8Z0TJQkBgl0=; b=6yhCNpZRB1umhI/xJT9fgwlZHFLDKUYtRzU06Tm8u3yeZ24fLrJ61nCiiLpVBHbdnf 81qWjlPVRYuvJQfbxyoUJG/3MY7G3lEb4an7KqUcLBMaTDLQ/Dxw599vf64fCqlMpkkQ h+OQmZO4e+ECP27DjygvjQgzcd156txHiU+PhNR5Jfo22VOUPNQrKFDKUQkqzPlJalP6 YrQXoaTQEaRimaSZlrJmTVRcfGewkV/lW8dXVNAvV34dE+E9lSQLZ+YZ1y4xdrM/Z3jz yjzwVjGCvG3MyfM+rr6XOkXcOZ7+p2PE3hLfxiCn9C11DxR682iBWoSNBQgoA0VK1ixd m2cg== X-Gm-Message-State: AOAM5326FrxOScVi58D42tY+omiO/yYVqVja/jlT7BHpFm4K41eyTqRf m/yddox0B1Sdb32bx8QICSFvtLPJTPQ= X-Google-Smtp-Source: ABdhPJz1wzcIoxzKiXe5OeqMp4zHdgGvC8CRBV78zJS1OjRNdtrijXr2YgLJUSdymZfh5cZZoe+gNw== X-Received: by 2002:ac2:4c55:0:b0:473:a651:942a with SMTP id o21-20020ac24c55000000b00473a651942amr20474463lfk.678.1652294852524; Wed, 11 May 2022 11:47:32 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V6 1/2] xen/gnttab: Store frame GFN in struct page_info on Arm Date: Wed, 11 May 2022 21:47:24 +0300 Message-Id: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 From: Oleksandr Tyshchenko Rework Arm implementation to store grant table frame GFN in struct page_info directly instead of keeping it in standalone status/shared arrays. This patch is based on the assumption that a grant table page is a xenheap page. To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space to hold 52-bit/28-bit + extra bit value respectively. In order to not grow the size of struct page_info borrow the required amount of bits from type_info's count portion which current context won't suffer (currently only 1 bit is used on Arm). Please note, to minimize code changes and avoid introducing an extra #ifdef-s to the header, we keep the same amount of bits on both subarches, although the count portion on Arm64 could be wider, so we waste some bits here. Introduce corresponding PGT_* constructs and access macro page_get(set)_xenheap_gfn. Please note, all accesses to the GFN portion of type_info field should always be protected by the P2M lock. In case when it is not feasible to satisfy that requirement (risk of deadlock, lock inversion, etc) it is important to make sure that all non-protected updates to this field are atomic. As several non-protected read accesses still exist within current code (most calls to page_get_xenheap_gfn() are not protected by the P2M lock) the subsequent patch will introduce hardening code for p2m_remove_mapping() to be called with P2M lock held in order to check any difference between what is already mapped and what is requested to be ummapped. Update existing gnttab macros to deal with GFN value according to new location. Also update the use of count portion of type_info field on Arm in share_xen_page_with_guest(). While at it, extend this simplified M2P-like approach for any xenheap pages which are proccessed in xenmem_add_to_physmap_one() except foreign ones. Update the code to set GFN portion after establishing new mapping for the xenheap page in said function and to clean GFN portion when putting a reference on that page in p2m_put_l3_page(). And for everything to work correctly introduce arch-specific initialization pattern PGT_TYPE_INFO_INITIALIZER to be applied to type_info field during initialization at alloc_heap_pages() and acquire_staticmem_pages(). The pattern's purpose on Arm is to clear the GFN portion before use, on x86 it is just a stub. This patch is intended to fix the potential issue on Arm which might happen when remapping grant-table frame. A guest (or the toolstack) will unmap the grant-table frame using XENMEM_remove_physmap. This is a generic hypercall, so on x86, we are relying on the fact the M2P entry will be cleared on removal. For architecture without the M2P, the GFN would still be present in the grant frame/status array. So on the next call to map the page, we will end up to request the P2M to remove whatever mapping was the given GFN. This could well be another mapping. Besides that, this patch simplifies arch code on Arm by removing arrays and corresponding management code and as the result gnttab_init_arch/gnttab_destroy_arch helpers and struct grant_table_arch become useless and can be dropped globally. Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- Dear @RISC-V maintainers, please note in current patch I drop arch specific helpers gnttab_init(destroy)_arch helpers as unneeded for both Arm and x86. Please let me know if you are going to reuse them in the nearest future and I will retain them. You can find the related discussions at: https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-54412190171c@xen.org/ https://lore.kernel.org/xen-devel/1628890077-12545-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1631652245-30746-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1641424268-12968-1-git-send-email-olekstysh@gmail.com/ Changes RFC1 -> RFC2: - update patch description - add/update comments in code - clarify check in p2m_put_l3_page() - introduce arch_alloc_xenheap_page() and arch_free_xenheap_page() and drop page_arch_init() - add ASSERT to gnttab_shared_page() and gnttab_status_page() - rework changes to Arm's struct page_info: do not split type_info, allocate GFN portion by reducing count portion, create corresponding PGT_* construct, etc - update page_get_frame_gfn() and page_set_frame_gfn() - update the use of count portion on Arm - drop the leading underscore in the macro parameter names Changes RFC2 -> RFC3: - update patch description - drop PGT_count_base and MASK_INSR() in share_xen_page_with_guest() - update alloc_xenheap_page() and free_xenheap_page() for SEPARATE_XENHEAP case (Arm32) - provide an extra bit for GFN portion, to get PGT_INVALID_FRAME_GFN one bit more than the maximum number of physical address bits on Arm32 Changes RFC3 -> V4: - rebase on Jan's "gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()" - finally resolve locking question by recent Julien's suggestion, so drop the RFC tag - update comments in Arm's mm.h/p2m.c to not mention grant table - convert page_set(get)_frame_gfn to static inline func and rename them to page_set(get)_xenheap_gfn() - rename PGT_INVALID_FRAME_GFN to PGT_INVALID_XENHEAP_GFN - add ASSERT(is_xen_heap_page(...)) in page_set(get)_frame_gfn - remove BUG_ON() in arch_free_xenheap_page - remove local type_info in share_xen_page_with_guest() - remove an extra argument p2m in p2m_put_l3_page() - remove #ifdef CONFIG_GRANT_TABLE in p2m_put_l3_page() - also cover real-only pages by using p2m_is_ram instead of a check against p2m_ram_rw in p2m_put_l3_page() and use "else if" construct - call arch_free_xenheap_page() before clearing the PGC_xen_heap in free_xenheap_pages() - remove ASSERT() in gnttab_shared(status)_page and use simpler virt_to_page - remove local pg_ in gnttab_shared(status)_gfn - update patch description to reflect recent changes Changes V4 -> V5: - rebase on latest staging - update patch description - drop arch_alloc(free)_xenheap_page macro and use arch-specific initialization pattern to clear GFN portion before use - add const to struct page_info *p in page_get_xenheap_gfn - fix a breakage on Arm32 Changes V5 -> V6: - update patch description - add/update comments in code - s/PGT_TYPE_INFO_INIT_PATTERN/PGT_TYPE_INFO_INITIALIZER - define PGT_TYPE_INFO_INITIALIZER in page_alloc.c if arch doesn't define it - modify page_get_xenheap_gfn() to use ACCESS_ONCE() when reading type_info field - modify page_set_xenheap_gfn() to use cmpxchg() when changing type_info field - apply PGT_TYPE_INFO_INITIALIZER in alloc_heap_pages() and acquire_staticmem_pages() rather than altering both flavors of alloc_xenheap_pages() to make an extra assignment - simplify gnttab_shared(status)_page and gnttab_(shared)status_gfn macro - update a check in Arm's gnttab_set_frame_gfn() --- xen/arch/arm/include/asm/grant_table.h | 53 +++++++--------------------------- xen/arch/arm/include/asm/mm.h | 47 ++++++++++++++++++++++++++++-- xen/arch/arm/mm.c | 24 +++++++++++++-- xen/arch/arm/p2m.c | 7 +++-- xen/arch/x86/include/asm/grant_table.h | 5 ---- xen/common/grant_table.c | 9 ------ xen/common/page_alloc.c | 8 +++-- 7 files changed, 87 insertions(+), 66 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index d31a4d6..16f817b 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -11,11 +11,6 @@ #define INITIAL_NR_GRANT_FRAMES 1U #define GNTTAB_MAX_VERSION 1 -struct grant_table_arch { - gfn_t *shared_gfn; - gfn_t *status_gfn; -}; - static inline void gnttab_clear_flags(struct domain *d, unsigned int mask, uint16_t *addr) { @@ -46,53 +41,27 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, #define gnttab_dom0_frames() \ min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext)) -#define gnttab_init_arch(gt) \ -({ \ - unsigned int ngf_ = (gt)->max_grant_frames; \ - unsigned int nsf_ = grant_to_status_frames(ngf_); \ - \ - (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ - (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ - if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ - { \ - while ( ngf_-- ) \ - (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ - while ( nsf_-- ) \ - (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ - } \ - else \ - gnttab_destroy_arch(gt); \ - (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ -}) - -#define gnttab_destroy_arch(gt) \ - do { \ - XFREE((gt)->arch.shared_gfn); \ - XFREE((gt)->arch.status_gfn); \ - } while ( 0 ) - #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ - ({ \ - int rc_ = 0; \ - gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx); \ - if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) || \ - (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn, \ - 0)) == 0 ) \ - ((st) ? (gt)->arch.status_gfn \ - : (gt)->arch.shared_gfn)[idx] = (gfn); \ - rc_; \ - }) + (gfn_eq(gfn, INVALID_GFN) \ + ? guest_physmap_remove_page((gt)->domain, \ + gnttab_get_frame_gfn(gt, st, idx), \ + mfn, 0) \ + : 0) #define gnttab_get_frame_gfn(gt, st, idx) ({ \ (st) ? gnttab_status_gfn(NULL, gt, idx) \ : gnttab_shared_gfn(NULL, gt, idx); \ }) +#define gnttab_shared_page(t, i) virt_to_page((t)->shared_raw[i]) + +#define gnttab_status_page(t, i) virt_to_page((t)->status[i]) + #define gnttab_shared_gfn(d, t, i) \ - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + page_get_xenheap_gfn(gnttab_shared_page(t, i)) #define gnttab_status_gfn(d, t, i) \ - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + page_get_xenheap_gfn(gnttab_status_page(t, i)) #define gnttab_need_iommu_mapping(d) \ (is_domain_direct_mapped(d) && is_iommu_enabled(d)) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2..412200a 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -98,9 +98,22 @@ struct page_info #define PGT_writable_page PG_mask(1, 1) /* has writable mappings? */ #define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. */ - /* Count of uses of this frame as its current type. */ -#define PGT_count_width PG_shift(2) -#define PGT_count_mask ((1UL<u.inuse.type_info) & PGT_gfn_mask); + + ASSERT(is_xen_heap_page(p)); + + return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_; +} + +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn) +{ + gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn; + unsigned long x, nx, y = p->u.inuse.type_info; + + ASSERT(is_xen_heap_page(p)); + + do { + x = y; + nx = (x & ~PGT_gfn_mask) | gfn_x(gfn_); + } while ( (y = cmpxchg(&p->u.inuse.type_info, x, nx)) != x ); +} + #endif /* __ARCH_ARM_MM__ */ /* * Local variables: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4..c94bdaf 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1400,8 +1400,10 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, spin_lock(&d->page_alloc_lock); /* The incremented type count pins as writable or read-only. */ - page->u.inuse.type_info = - (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1; + page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask); + page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none + : PGT_writable_page) | + MASK_INSR(1, PGT_count_mask); page_set_owner(page, d); smp_wmb(); /* install valid domain ptr before updating refcnt. */ @@ -1505,7 +1507,23 @@ int xenmem_add_to_physmap_one( } /* Map at new location. */ - rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); + if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) + rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); + else + { + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_write_lock(p2m); + if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) ) + { + rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access); + if ( !rc ) + page_set_xenheap_gfn(mfn_to_page(mfn), gfn); + } + else + rc = -EBUSY; + p2m_write_unlock(p2m); + } /* * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index d00c2e4..f87b48e 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -716,6 +716,8 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, */ static void p2m_put_l3_page(const lpae_t pte) { + mfn_t mfn = lpae_get_mfn(pte); + ASSERT(p2m_is_valid(pte)); /* @@ -727,11 +729,12 @@ static void p2m_put_l3_page(const lpae_t pte) */ if ( p2m_is_foreign(pte.p2m.type) ) { - mfn_t mfn = lpae_get_mfn(pte); - ASSERT(mfn_valid(mfn)); put_page(mfn_to_page(mfn)); } + /* Detect the xenheap page and mark the stored GFN as invalid. */ + else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) + page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); } /* Free lpae sub-tree behind an entry */ diff --git a/xen/arch/x86/include/asm/grant_table.h b/xen/arch/x86/include/asm/grant_table.h index a8a2143..5c23cec 100644 --- a/xen/arch/x86/include/asm/grant_table.h +++ b/xen/arch/x86/include/asm/grant_table.h @@ -14,9 +14,6 @@ #define INITIAL_NR_GRANT_FRAMES 1U -struct grant_table_arch { -}; - static inline int create_grant_host_mapping(uint64_t addr, mfn_t frame, unsigned int flags, unsigned int cache_flags) @@ -35,8 +32,6 @@ static inline int replace_grant_host_mapping(uint64_t addr, mfn_t frame, return replace_grant_pv_mapping(addr, frame, new_addr, flags); } -#define gnttab_init_arch(gt) 0 -#define gnttab_destroy_arch(gt) do {} while ( 0 ) #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ (gfn_eq(gfn, INVALID_GFN) \ ? guest_physmap_remove_page((gt)->domain, \ diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index febbe12..4115da0 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -99,8 +99,6 @@ struct grant_table { /* Domain to which this struct grant_table belongs. */ struct domain *domain; - - struct grant_table_arch arch; }; unsigned int __read_mostly opt_max_grant_frames = 64; @@ -2018,14 +2016,9 @@ int grant_table_init(struct domain *d, int max_grant_frames, grant_write_lock(gt); - ret = gnttab_init_arch(gt); - if ( ret ) - goto unlock; - /* gnttab_grow_table() allocates a min number of frames, so 0 is okay. */ ret = gnttab_grow_table(d, 0); - unlock: grant_write_unlock(gt); out: @@ -3940,8 +3933,6 @@ grant_table_destroy( if ( t == NULL ) return; - gnttab_destroy_arch(t); - for ( i = 0; i < nr_grant_frames(t); i++ ) free_xenheap_page(t->shared_raw[i]); xfree(t->shared_raw); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 3190291..dbacee2 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -155,6 +155,10 @@ #define PGC_reserved 0 #endif +#ifndef PGT_TYPE_INFO_INITIALIZER +#define PGT_TYPE_INFO_INITIALIZER 0 +#endif + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -1024,7 +1028,7 @@ static struct page_info *alloc_heap_pages( &tlbflush_timestamp); /* Initialise fields which have other uses for free pages. */ - pg[i].u.inuse.type_info = 0; + pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; page_set_owner(&pg[i], NULL); } @@ -2702,7 +2706,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, */ pg[i].count_info = PGC_reserved | PGC_state_inuse; /* Initialise fields which have other uses for free pages. */ - pg[i].u.inuse.type_info = 0; + pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; page_set_owner(&pg[i], NULL); } -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Wed May 11 18:47:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327185.549936 (Exim 4.92) (envelope-from ) id 1norN4-0003Ao-2t; Wed, 11 May 2022 18:47:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327185.549936; Wed, 11 May 2022 18:47:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norN3-00039P-Pm; Wed, 11 May 2022 18:47:37 +0000 Received: by outflank-mailman (input) for mailman id 327185; Wed, 11 May 2022 18:47:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norN2-0002t5-DT for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:47:36 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d2ce5dda-d15a-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 20:47:35 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id t25so5114135lfg.7 for ; Wed, 11 May 2022 11:47:35 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id w12-20020a05651234cc00b0047255d21189sm396230lfr.184.2022.05.11.11.47.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2022 11:47:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2ce5dda-d15a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vctV/iLL9dxD/cFUite3RxHXN54TqR8bRkXbFjuYkMw=; b=Yek1mTVmaEi46z3QQJsz2e1Ta4uvlY1Tm4ODXeMoxGsTACb85Z01IF5V6/+PQFDE0q PQkeKb0w19D9rK18XngwqHdYlJ3bAraQi/ttv+ickXfwlgU8dcXLUZOvpLzewAQiifbL 08UiZFYKk5rpNunv0gW0buARJry3W0ogycyxx5FWK91fMF2q02T9KKHZfKj/oF3yhbH5 IOmYLcYFXriq67m3uvZVHy3NmjjH3NOG4UoZlf2dSdhOuwfc85LOoWOvVCEiqeGsDy/K zE0FNTx2WFR42Yyx+HqRGxPAeJxL1HPgITebPFCIz+kt55i56G+gNlHnYeWsXqijcA0/ N83w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vctV/iLL9dxD/cFUite3RxHXN54TqR8bRkXbFjuYkMw=; b=49prpnX2L54mstsrlAXWKjUJsJVrxQ52Pd1F/Z1fLOEqm4x0Dn8+d2Dg1/U8+uTNZA 0EjvjXNlgc5QvmQ/w1f83y62cBv3xzJj0CR8eZ4cJuTgNjFUS3HVgYb6Vc0XjBpywRup RhrzdMr4CpVwicRkb3uAZoY7sbYsU+hmGNT3R61O2gMDjoh2kmJx5YDg+yi1DNWfHzpA heFUx2zfEucP7TrLCAzC4lIlEQa3x0t0B/7qhaf1LiUsZ8IzzHnXwWZe4fmPMOiN+9cE rmZKLaulNf6Mkn0IsLRzdusV2W/Sbo7qASGhRubAMjmI7ECQduKv5dFqc2fW1bqvY7v5 +d0A== X-Gm-Message-State: AOAM530BGY3PDpfNZdlIYZuCYSnbDKX2+rkxqQXSCIyx+jKaV60PV3II 59HlBW9qlt6bbxoQSxN577V8IB0uxsI= X-Google-Smtp-Source: ABdhPJwNtbxDzwFgJ57XcIMT8iqJWTz51fLWvllpe43kx41E3ujr9FO+aMOq+lloUt41DdnKh1toSg== X-Received: by 2002:ac2:44cd:0:b0:471:eff9:d698 with SMTP id d13-20020ac244cd000000b00471eff9d698mr21496835lfm.251.1652294854659; Wed, 11 May 2022 11:47:34 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH V6 2/2] xen/arm: Harden the P2M code in p2m_remove_mapping() Date: Wed, 11 May 2022 21:47:25 +0300 Message-Id: <1652294845-13980-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> References: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Borrow the x86's check from p2m_remove_page() which was added by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e "x86/p2m: don't assert that the passed in MFN matches for a remove" and adjust it to the Arm code base. Basically, this check is strictly needed for the xenheap pages only since there are several non-protected read accesses to our simplified xenheap based M2P approach on Arm (most calls to page_get_xenheap_gfn() are not protected by the P2M lock). But, it will be a good opportunity to harden the P2M code for *every* RAM pages since it is possible to remove any GFN - MFN mapping currently on Arm (even with the wrong helpers). This can result in a few issues when mapping is overridden silently (in particular when building dom0). Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- You can find the corresponding discussion at: https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/ Changes V5 -> V6: - new patch --- xen/arch/arm/p2m.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index f87b48e..635e474 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1311,11 +1311,32 @@ static inline int p2m_remove_mapping(struct domain *d, mfn_t mfn) { struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long i; int rc; p2m_write_lock(p2m); + for ( i = 0; i < nr; ) + { + unsigned int cur_order; + p2m_type_t t; + mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i), &t, NULL, + &cur_order, NULL); + + if ( p2m_is_any_ram(t) && + (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) ) + { + rc = -EILSEQ; + goto out; + } + + i += (1UL << cur_order) - + ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1)); + } + rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN, p2m_invalid, p2m_access_rwx); + +out: p2m_write_unlock(p2m); return rc; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Wed May 11 18:52:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 18:52:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327199.549951 (Exim 4.92) (envelope-from ) id 1norRh-0005BF-GW; Wed, 11 May 2022 18:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327199.549951; Wed, 11 May 2022 18:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norRh-0005B8-DD; Wed, 11 May 2022 18:52:25 +0000 Received: by outflank-mailman (input) for mailman id 327199; Wed, 11 May 2022 18:52:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norRg-0005B2-9j for xen-devel@lists.xenproject.org; Wed, 11 May 2022 18:52:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norRf-0005O7-4U; Wed, 11 May 2022 18:52:23 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1norRe-0007Bn-U3; Wed, 11 May 2022 18:52:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xDJc54aGWs6VPC/aAYJYP9EWKMv/TbUIb1SicvFfR1Q=; b=lzas2N7VAy0lYtgEk/VhsiGpRT Witxyx+C1mxVxPyLtgwyQ2AHHNiDDbJwP+0k+J76qbQu+wpYDO9zOXGgKte5chwouvEa+PWu9evZf pN3lcU+iTcXyRaK9rEk2mxZWSVzXRCa7bxJOl7aoYEyhFUdTQ0F0Vz4s2Y/U6+LFAbmU=; Message-ID: Date: Wed, 11 May 2022 19:52:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , jbeulich@suse.com References: <20220505001656.395419-4-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220505001656.395419-4-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 05/05/2022 01:16, Stefano Stabellini wrote: > From: Luca Miccio > > Export evtchn_alloc_unbound and make it __must_check. > > If "xen,enhanced" is enabled, then add to dom0less domains: > > - the hypervisor node in device tree > - the xenstore event channel > > The xenstore event channel is also used for the first notification to > let the guest know that xenstore has become available. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > Reviewed-by: Bertrand Marquis > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: jbeulich@suse.com > > --- > Changes in v5: > - merge with "xen: export evtchn_alloc_unbound" > - __must_check > > Changes in v3: > - use evtchn_alloc_unbound > > Changes in v2: > - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation > - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound > > xen: export evtchn_alloc_unbound > > It will be used during dom0less domains construction. > > Signed-off-by: Stefano Stabellini > --- > xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++ > xen/common/event_channel.c | 2 +- > xen/include/xen/event.h | 3 +++ > 3 files changed, 41 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 016f56a99f..bb430f2189 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2810,6 +2811,8 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > int ret; > > kinfo->phandle_gic = GUEST_PHANDLE_GIC; > + kinfo->gnttab_start = GUEST_GNTTAB_BASE; > + kinfo->gnttab_size = GUEST_GNTTAB_SIZE; > > addrcells = GUEST_ROOT_ADDRESS_CELLS; > sizecells = GUEST_ROOT_SIZE_CELLS; > @@ -2884,6 +2887,13 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > goto err; > } > > + if ( kinfo->dom0less_enhanced ) > + { > + ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); > + if ( ret ) > + goto err; > + } > + > ret = fdt_end_node(kinfo->fdt); > if ( ret < 0 ) > goto err; > @@ -3150,6 +3160,25 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) > return 0; > } > > +static int __init alloc_xenstore_evtchn(struct domain *d) > +{ > + evtchn_alloc_unbound_t alloc; > + int rc; > + > + alloc.dom = d->domain_id; > + alloc.remote_dom = hardware_domain->domain_id; > + rc = evtchn_alloc_unbound(&alloc); > + if ( rc ) > + { > + printk("Failed allocating event channel for domain\n"); > + return rc; > + } > + > + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; > + > + return 0; > +} > + > static int __init construct_domU(struct domain *d, > const struct dt_device_node *node) > { > @@ -3214,6 +3243,14 @@ static int __init construct_domU(struct domain *d, > if ( rc < 0 ) > return rc; > > + if ( kinfo.dom0less_enhanced ) > + { > + rc = alloc_xenstore_evtchn(d); > + if ( rc < 0 ) > + return rc; > + d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; This sounds a little bit odd that we set the value to ~0ULL with dom0less_enhanced but keep it to 0 outside of dom0less. If there are any rationale for that, then I would suggest to add a comment. (Can be done on commit). For the common part: Acked-by: Julien Grall # common Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 19:01:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 19:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327207.549962 (Exim 4.92) (envelope-from ) id 1nora0-0006iX-Fg; Wed, 11 May 2022 19:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327207.549962; Wed, 11 May 2022 19:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nora0-0006iQ-Cg; Wed, 11 May 2022 19:01:00 +0000 Received: by outflank-mailman (input) for mailman id 327207; Wed, 11 May 2022 19:00:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norZz-0006iK-IV for xen-devel@lists.xenproject.org; Wed, 11 May 2022 19:00:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norZy-0005ZN-EA; Wed, 11 May 2022 19:00:58 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1norZy-0007rj-7H; Wed, 11 May 2022 19:00:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FY8W0brpfN+Q1rQaT8fXTSGJxBRp3nDmMa2AIYvXzpY=; b=6v+EItmRIZ8azjcSyhRprTRB5x nTUzcNgNbo4vAoSc49bMrwRsTtn670mBOexDdmpdAOfXIIrKq2O/PkwXPSxOZ6ongOYWhL0WZkDjE CRhN2MxC3k+mNA+rU+mK7As+5qGx6loY4JdU9TaKsfwoB/4u/WZaYOCv1944Yb1bY3h8=; Message-ID: <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> Date: Wed, 11 May 2022 20:00:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org References: <20220505001656.395419-5-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220505001656.395419-5-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 05/05/2022 01:16, Stefano Stabellini wrote: > From: Luca Miccio > > When xs_introduce_domain is called, send out a notification on the > xenstore event channel so that any (dom0less) domain waiting for the > xenstore interface to be ready can continue with the initialization. > Before sending the notification, clear XENSTORE_RECONNECTING. > > The extra notification is harmless for domains that don't require it. > > In xs_wire.h update the commment on top of XENSTORE_RECONNECTING to > generalize its meaning to suit the dom0less use-case better. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > CC: jgross@suse.com > CC: anthony.perard@citrix.com > CC: wl@xen.org > --- > If you have better suggestions for the wording in xs_wire.h please > suggest! > > > Changes in v6: > - use XENSTORE_CONNECTED instead of 0x0 > - update xs_wire.h > > Changes in v5: > - reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU > > Changes in v2: > - drop the new late_init parameter > --- > tools/xenstore/xenstored_domain.c | 4 ++++ > xen/include/public/io/xs_wire.h | 2 +- I am not entirely sure this is the right place to mention it. But I couldn't find a better one. The documentation (docs/misc/xenstore-misc.txt) states that the field is valid when the server advertised ``Connection State``. Is there any guarantee the field will be 0 for any previous {C, O}xenstored implementation? If not, then I think we need to set the feature flag so Linux knows the field can be used. If yes, then the documentation should be relaxed so an OS knows it can safely use the field without checking the feature flag. > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index ae065fcbee..6f34af225c 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -493,6 +493,10 @@ static struct domain *introduce_domain(const void *ctx, > /* Now domain belongs to its connection. */ > talloc_steal(domain->conn, domain); > > + /* Notify the domain that xenstore is available */ > + interface->connection = XENSTORE_CONNECTED; > + xenevtchn_notify(xce_handle, domain->port); > + > if (!is_master_domain && !restore) > fire_watches(NULL, ctx, "@introduceDomain", NULL, > false, NULL); > diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h > index 953a0050a3..c1ec7c73e3 100644 > --- a/xen/include/public/io/xs_wire.h > +++ b/xen/include/public/io/xs_wire.h > @@ -141,7 +141,7 @@ struct xenstore_domain_interface { > > /* Valid values for the connection field */ > #define XENSTORE_CONNECTED 0 /* the steady-state */ > -#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ > +#define XENSTORE_RECONNECT 1 /* reconnect in progress */ The definition in the docs needs to be updated. > > /* Valid values for the error field */ > #define XENSTORE_ERROR_NONE 0 /* No error */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 19:11:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 19:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327214.549973 (Exim 4.92) (envelope-from ) id 1nork3-0008C5-GM; Wed, 11 May 2022 19:11:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327214.549973; Wed, 11 May 2022 19:11:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nork3-0008By-DC; Wed, 11 May 2022 19:11:23 +0000 Received: by outflank-mailman (input) for mailman id 327214; Wed, 11 May 2022 19:11:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nork2-0008Bs-1y for xen-devel@lists.xenproject.org; Wed, 11 May 2022 19:11:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nork1-0005jR-0J; Wed, 11 May 2022 19:11:21 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nork0-0000D1-LS; Wed, 11 May 2022 19:11:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=04Q/AoO5d+dRR2uR5jQMdAo53AUpbXkcMlcA+4zr+EQ=; b=UeAo5kDxz03ayAU49H2STUezkn VEUPn21JgG9EsPLxNjMQ50137NDAzw1hEME8PE/5+x7U6n8t8lB73MXhMRk4Hff5x6pFjirAp8OVE Yx7Rq8xR2jJKPkVUcuAux5PbBIULkRn4Ir9JUlWfxLEiI4B7e83TFhMFqmpjH+yHchDc=; Message-ID: Date: Wed, 11 May 2022 20:11:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20220505001656.395419-6-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220505001656.395419-6-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 05/05/2022 01:16, Stefano Stabellini wrote: > From: Luca Miccio > > Add an example application that can be run in dom0 to complete the > dom0less domains initialization so that they can get access to xenstore > and use PV drivers. > > The application sets "connection" to XENSTORE_RECONNECT on the xenstore > page before calling xs_introduce_domain to signal that the connection is > not ready yet to be used. XENSTORE_RECONNECT is reset soon after by > xenstored. > > Signed-off-by: Luca Miccio > Signed-off-by: Stefano Stabellini > CC: Wei Liu > CC: Anthony PERARD > CC: Juergen Gross > --- > Changes in v6: > - include xs_wire.h and use its definitions > > Changes in v5: > - set XS_CONNECTION_STATE_RECONNECTING before xs_introduce_domain > > Changes in v4: > - only alloc xs page (no other magic pages) > - add xenstore permissions > - check all return values > - rename restore_xenstore to create_xenstore > - set target_memkb > - set start_time properly > - close xs transaction on error > - call xc_dom_gnttab_seed instead of xc_dom_gnttab_init > - xs_open instead of xs_daemon_open > > Changes in v3: > - handle xenstore errors > - add an in-code comment about xenstore entries > - less verbose output > - clean-up error path in main > > Changes in v2: > - do not set HVM_PARAM_STORE_EVTCHN twice > - rename restore_xenstore to create_xenstore > - increase maxmem > > connection reconnecting > --- > tools/helpers/Makefile | 13 ++ > tools/helpers/init-dom0less.c | 340 ++++++++++++++++++++++++++++++++++ > 2 files changed, 353 insertions(+) > create mode 100644 tools/helpers/init-dom0less.c > > diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile > index 7f6c422440..8d78ab1e90 100644 > --- a/tools/helpers/Makefile > +++ b/tools/helpers/Makefile > @@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y) > ifeq ($(CONFIG_X86),y) > PROGS += init-xenstore-domain > endif > +ifeq ($(CONFIG_ARM),y) > +PROGS += init-dom0less > +endif > endif > > XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o > @@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore) > $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight) > $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h > > +INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog) > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore) > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight) > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl) > +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn) > + > .PHONY: all > all: $(PROGS) > > @@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS) > init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) > $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) > > +init-dom0less: $(INIT_DOM0LESS_OBJS) > + $(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) > + > .PHONY: install > install: all > $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) > diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c > new file mode 100644 > index 0000000000..bfd5ff0761 > --- /dev/null > +++ b/tools/helpers/init-dom0less.c > @@ -0,0 +1,340 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "init-dom-json.h" > + > +#define XENSTORE_PFN_OFFSET 1 > +#define STR_MAX_LENGTH 64 > + > +static int alloc_xs_page(struct xc_interface_core *xch, > + libxl_dominfo *info, > + uint64_t *xenstore_pfn) > +{ > + int rc; > + const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT; > + xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET; > + > + rc = xc_domain_setmaxmem(xch, info->domid, > + info->max_memkb + (XC_PAGE_SIZE/1024)); > + if (rc < 0) > + return rc; > + > + rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m); > + if (rc < 0) > + return rc; > + > + *xenstore_pfn = base + XENSTORE_PFN_OFFSET; > + rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn); > + if (rc < 0) > + return rc; > + > + return 0; > +} > + > +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, > + domid_t domid, char *path, char *val) > +{ > + char full_path[STR_MAX_LENGTH]; > + struct xs_permissions perms[2]; > + > + perms[0].id = domid; > + perms[0].perms = XS_PERM_NONE; > + perms[1].id = 0; > + perms[1].perms = XS_PERM_READ; > + > + if (snprintf(full_path, STR_MAX_LENGTH, > + "/local/domain/%u/%s", domid, path) < 0) > + return false; > + if (!xs_write(xsh, t, full_path, val, strlen(val))) > + return false; > + return xs_set_permissions(xsh, t, full_path, perms, 2); > +} > + > +static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t, > + domid_t domid, char *path, char *val) > +{ > + char full_path[STR_MAX_LENGTH]; > + > + if (snprintf(full_path, STR_MAX_LENGTH, > + "/libxl/%u/%s", domid, path) < 0) > + return false; > + return xs_write(xsh, t, full_path, val, strlen(val)); > +} > + > +static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t, > + libxl_uuid uuid, char *path, char *val) > +{ > + char full_path[STR_MAX_LENGTH]; > + > + if (snprintf(full_path, STR_MAX_LENGTH, > + "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0) > + return false; > + return xs_write(xsh, t, full_path, val, strlen(val)); > +} > + > +/* > + * The xenstore nodes are the xenstore nodes libxl writes at domain > + * creation. > + * > + * The list was retrieved by running xenstore-ls on a corresponding > + * domain started by xl/libxl. > + */ > +static int create_xenstore(struct xs_handle *xsh, > + libxl_dominfo *info, libxl_uuid uuid, > + evtchn_port_t xenstore_port) > +{ > + domid_t domid; > + unsigned int i; > + char uuid_str[STR_MAX_LENGTH]; > + char dom_name_str[STR_MAX_LENGTH]; > + char vm_val_str[STR_MAX_LENGTH]; > + char id_str[STR_MAX_LENGTH]; > + char max_memkb_str[STR_MAX_LENGTH]; > + char target_memkb_str[STR_MAX_LENGTH]; > + char cpu_str[STR_MAX_LENGTH]; > + char xenstore_port_str[STR_MAX_LENGTH]; > + char ring_ref_str[STR_MAX_LENGTH]; > + xs_transaction_t t; > + struct timeval start_time; > + char start_time_str[STR_MAX_LENGTH]; > + int rc; > + > + if (gettimeofday(&start_time, NULL) < 0) > + return -errno; > + rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d", > + (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000); > + if (rc < 0) > + return rc; > + > + domid = info->domid; > + rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid); > + if (rc < 0) > + return rc; > + rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid); > + if (rc < 0) > + return rc; > + rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); > + if (rc < 0) > + return rc; > + rc = snprintf(vm_val_str, STR_MAX_LENGTH, > + "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); > + if (rc < 0) > + return rc; > + rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb); > + if (rc < 0) > + return rc; > + rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb); > + if (rc < 0) > + return rc; > + rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", > + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET); > + if (rc < 0) > + return rc; > + rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port); > + if (rc < 0) > + return rc; > + > +retry_transaction: > + t = xs_transaction_start(xsh); > + if (t == XBT_NULL) > + return -errno; > + > + rc = -EIO; > + /* /vm */ > + if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err; > + if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err; > + if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto err; > + > + /* /domain */ > + if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err; > + for (i = 0; i < info->vcpu_max_id; i++) { > + rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i); > + if (rc < 0) > + goto err; > + rc = -EIO; > + if (!do_xs_write_dom(xsh, t, domid, cpu_str, > + (info->cpupool & (1 << i)) ? "online" : "offline")) > + goto err; > + } > + > + if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", max_memkb_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err; > + > + if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", "")) goto err; > + > + if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-multiprocessor-suspend", "1")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-xs_reset_watches", "1")) goto err; > + > + if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err; > + > + if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) goto err; > + if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) goto err; > + > + if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err; > + if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto err; > + > + if (!xs_transaction_end(xsh, t, false)) { > + if (errno == EAGAIN) > + goto retry_transaction; > + else > + return -errno; > + } > + > + return 0; > + > +err: > + xs_transaction_end(xsh, t, true); > + return rc; > +} > + > +static int init_domain(struct xs_handle *xsh, > + struct xc_interface_core *xch, > + xenforeignmemory_handle *xfh, > + libxl_dominfo *info) > +{ > + libxl_uuid uuid; > + uint64_t xenstore_evtchn, xenstore_pfn; > + int rc; > + struct xenstore_domain_interface *intf; > + > + printf("Init dom0less domain: %u\n", info->domid); > + > + rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN, > + &xenstore_evtchn); > + if (rc != 0) { > + printf("Failed to get HVM_PARAM_STORE_EVTCHN\n"); > + return 1; > + } > + > + /* Alloc xenstore page */ > + if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) { > + printf("Error on alloc magic pages\n"); > + return 1; > + } > + > + intf = xenforeignmemory_map(xfh, info->domid, XS_READ | XS_WRITE, 1, > + &xenstore_pfn, NULL); > + if (!intf) { > + printf("Error mapping xenstore page\n"); > + return 1; > + } > + intf->connection = XENSTORE_RECONNECT; > + xenforeignmemory_unmap(xfh, intf, 1); > + > + rc = xc_dom_gnttab_seed(xch, info->domid, true, > + (xen_pfn_t)-1, xenstore_pfn, 0, 0); > + if (rc) > + err(1, "xc_dom_gnttab_seed"); > + > + libxl_uuid_generate(&uuid); > + xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); > + > + rc = gen_stub_json_config(info->domid, &uuid); > + if (rc) > + err(1, "gen_stub_json_config"); > + > + /* Now everything is ready: set HVM_PARAM_STORE_PFN */ > + rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN, > + xenstore_pfn); > + if (rc < 0) > + return rc; > + > + rc = create_xenstore(xsh, info, uuid, xenstore_evtchn); > + if (rc) > + err(1, "writing to xenstore"); > + > + rc = xs_introduce_domain(xsh, info->domid, > + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, > + xenstore_evtchn); I might be missing something here. In an ealier version, I pointed out that xs_introduce_domain() would fail in the case the dom0less domain doesn't have "xen,enhanced". AFAICT, you agreed that the (part?) of initialization should be skipped. But I don't see the change in the code. Regarding the placement, we could either fully skip init_domain() or just xs_introduce_domain(). The latter might be better so all the domains are listed using xenstore-ls. So something like below should work: if ( xenstore_evtchn ) { rc = xs_introduce...(); ... } Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 19:13:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 19:13:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327220.549984 (Exim 4.92) (envelope-from ) id 1norlo-0000Me-S3; Wed, 11 May 2022 19:13:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327220.549984; Wed, 11 May 2022 19:13:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norlo-0000MX-P6; Wed, 11 May 2022 19:13:12 +0000 Received: by outflank-mailman (input) for mailman id 327220; Wed, 11 May 2022 19:13:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norlo-0000MJ-1U for xen-devel@lists.xenproject.org; Wed, 11 May 2022 19:13:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norln-0005mW-Kg; Wed, 11 May 2022 19:13:11 +0000 Received: from [54.239.6.188] (helo=[192.168.11.111]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1norln-0000JP-ES; Wed, 11 May 2022 19:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gHvV+rB+gkIIGc4SPP/TSIng9jrBX5D9wBakibcGGlY=; b=sRZhJuq+YJa+cjjtGUeGDcOc1m 16omWND+xj5NdFdg23tgT/Kmip5S8++AuOCLLq1PVKpVJez6syd1lNPMLI6bZP1Kg8Y9/nMyiQzpa hyBtsGNVXwea0NG/SvH6qw3TSkzJ65lGinfIC52IOfKh93AOwPWUBJ9wJ0wKlf90f94s=; Message-ID: <1a814fab-3122-746a-80f8-e87bc70f3b57@xen.org> Date: Wed, 11 May 2022 20:13:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 7/7] docs: document dom0less + PV drivers To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu References: <20220505001656.395419-7-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220505001656.395419-7-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 05/05/2022 01:16, Stefano Stabellini wrote: > From: Stefano Stabellini > > Document how to use the feature and how the implementation works. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Luca Fancellu AFAICT, this match the code in Xen. So: Acked-by: Julien Grall > --- > docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++--- > 1 file changed, 40 insertions(+), 3 deletions(-) > > diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc > index c9edb529e1..725afa0558 100644 > --- a/docs/features/dom0less.pandoc > +++ b/docs/features/dom0less.pandoc > @@ -90,6 +90,46 @@ Otherwise, they may be unusable in Xen (for instance if they are compressed). > > See docs/misc/arm/device-tree/booting.txt for more information. > > +PV Drivers > +---------- > + > +It is possible to use PV drivers with dom0less guests with some > +restrictions: > + > +- dom0less domUs that want to use PV drivers support should have the > + "xen,enhanced" property set under their device tree nodes (see > + docs/misc/arm/device-tree/booting.txt) > +- a dom0 must be present (or another domain with enough privileges to > + run the toolstack) > +- after dom0 is booted, the utility "init-dom0less" must be run > +- do not run "init-dom0less" while creating other guests with xl > + > +After the execution of init-dom0less, it is possible to use "xl" to > +hotplug PV drivers to dom0less guests. E.g. xl network-attach domU. > + > +The implementation works as follows: > +- Xen allocates the xenstore event channel for each dom0less domU that > + has the "xen,enhanced" property, and sets HVM_PARAM_STORE_EVTCHN > +- Xen does *not* allocate the xenstore page and sets HVM_PARAM_STORE_PFN > + to ~0ULL (invalid) > +- Dom0less domU kernels check that HVM_PARAM_STORE_PFN is set to invalid > + - Old kernels will continue without xenstore support (Note: some old > + buggy kernels might crash because they don't check the validity of > + HVM_PARAM_STORE_PFN before using it! Disable "xen,enhanced" in > + those cases) > + - New kernels will wait for a notification on the xenstore event > + channel (HVM_PARAM_STORE_EVTCHN) before continuing with the > + initialization > +- Once dom0 is booted, init-dom0less is executed: > + - it allocates the xenstore shared page and sets HVM_PARAM_STORE_PFN > + - it calls xs_introduce_domain > +- Xenstored notices the new domain, initializes interfaces as usual, and > + sends an event channel notification to the domain using the xenstore > + event channel (HVM_PARAM_STORE_EVTCHN) > +- The Linux domU kernel receives the event channel notification, checks > + HVM_PARAM_STORE_PFN again and continue with the initialization > + > + > Limitations > ----------- > > @@ -107,9 +147,6 @@ limitations: > information, the GIC version exposed to the domains started by Xen at > boot is the same as the native GIC version. > > -- No PV drivers. There is no support for PV devices at the moment. All > - devices need to be statically assigned to guests. > - > - Pinning vCPUs of domains started by Xen at boot can be > done from the control domain, using `xl vcpu-pin` as usual. It is not > currently possible to configure vCPU pinning without a control domain. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 11 19:25:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 19:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327228.549995 (Exim 4.92) (envelope-from ) id 1norxR-0001uC-Uj; Wed, 11 May 2022 19:25:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327228.549995; Wed, 11 May 2022 19:25:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norxR-0001u5-Rg; Wed, 11 May 2022 19:25:13 +0000 Received: by outflank-mailman (input) for mailman id 327228; Wed, 11 May 2022 19:25:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1norxR-0001tz-7c for xen-devel@lists.xenproject.org; Wed, 11 May 2022 19:25:13 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 123b7d53-d160-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 21:25:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6C41F3200033 for ; Wed, 11 May 2022 15:25:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 May 2022 15:25:08 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 11 May 2022 15:25:07 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 123b7d53-d160-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652297107; x=1652383507; bh=V1yw90SJTCTbY oYc3HuR043djZK8xuxSRxAzr/fc/so=; b=EsuZjQK/8PXWbv8D1CCLhG30aG/do F4QUiPpp+LL6PVIp7on7cLe6UIcDDI8UovnHOxTHQJkSdH3jYFCKflSlp1POLp6B xS7ky3BCkT2I38h7Zrd1wmyU3CG2aSGdQb351CcbqETRmhc0fF/R+O4vgCsKIwys JAL2gMD6Ygaf8zluLvEpv3CFCFXbdXS/ZfUPrnO88WnxIHUxfB3/kB7gkPxtWtyR H0zx2tXUJoqUMtdbHCDEOT/lGtJK6SqhTNL1Jq/A/bF9hs5w3YYWyFI089+tIBFw pLch24n+m+YY9eSqgsaSCTGlvn+/abVc8Ywp5CfMcJu1BrS5n7ZlEKxOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtroertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnhepvdekhfefjedvvdfffeffgeeitdevhefhfeetteetffeigfei keelteeuffetjeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Date: Wed, 11 May 2022 21:25:02 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: xen-blkfront crash on xl block-detach of not fully attached device Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7J16D5oq46R8xLJ6" Content-Disposition: inline --7J16D5oq46R8xLJ6 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 11 May 2022 21:25:02 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: xen-blkfront crash on xl block-detach of not fully attached device Hi, The reproducer is trivial: [user@dom0 ~]$ sudo xl block-attach work backend=3Dsys-usb vdev=3Dxvdi targ= et=3D/dev/sdz [user@dom0 ~]$ xl block-list work Vdev BE handle state evt-ch ring-ref BE-path =20 51712 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51712 51728 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51728 51744 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51744 51760 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51760 51840 3 241 3 -1 -1 /local/domain/3/backend/vbd/241/51840 ^ note state, the /dev/sdz doesn't exist in the backend [user@dom0 ~]$ sudo xl block-detach work xvdi [user@dom0 ~]$ xl block-list work Vdev BE handle state evt-ch ring-ref BE-path =20 work is an invalid domain identifier And its console has: BUG: kernel NULL pointer dereference, address: 0000000000000050 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 80000000edebb067 P4D 80000000edebb067 PUD edec2067 PMD 0=20 Oops: 0000 [#1] PREEMPT SMP PTI CPU: 1 PID: 52 Comm: xenwatch Not tainted 5.16.18-2.43.fc32.qubes.x86_64 #1 RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5b = 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0 7= 4 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 Call Trace: blkback_changed+0x95/0x137 [xen_blkfront] ? read_reply+0x160/0x160 xenwatch_thread+0xc0/0x1a0 ? do_wait_intr_irq+0xa0/0xa0 kthread+0x16b/0x190 ? set_kthread_struct+0x40/0x40 ret_from_fork+0x22/0x30 Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_tim= er snd soundcore ipt_REJECT nf_reject_ipv4 xt_state xt_conntrack nft_counte= r nft_chain_nat xt_MASQUERADE nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_= ipv4 nft_compat nf_tables nfnetlink intel_rapl_msr intel_rapl_common crct10= dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel xen_netfront pcspk= r xen_scsiback target_core_mod xen_netback xen_privcmd xen_gntdev xen_gntal= loc xen_blkback xen_evtchn ipmi_devintf ipmi_msghandler fuse bpf_preload ip= _tables overlay xen_blkfront CR2: 0000000000000050 ---[ end trace 7bc9597fd06ae89d ]--- RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5b = 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0 7= 4 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 Kernel panic - not syncing: Fatal exception Kernel Offset: disabled --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --7J16D5oq46R8xLJ6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmJ8DY4ACgkQ24/THMrX 1yyA7gf+LUWcGFvGYVvjAeySGghi3Tvy8LGqpOtmEph+wjZwfIedzY5bISfRnbQC /G2dODwChn3HBU576P9AYJ95v0FoFn+RfyJqEc/Ykxdvjh9z7vSmbR6aPh/0YIsu NjxQnQPAgpMUERl33ccKw3hO6bEytaqdZKWAoUim//eVPc9AFUtknSXL+ODzm+FC SUNBXGFt5WLs5hrllfJZ2I93X90GvzSraO78luj0/Wj9pIAkuFta4d+r6MaFRfSF ErM18Ta+wNzF8+hP7PWgR9wTWyr3ayaD12ebqHtAv+byQVyBXq4sATef1tJKeFJd 1mzfRLnKBk9tr7IvumKsWlcWMONvFQ== =w6OM -----END PGP SIGNATURE----- --7J16D5oq46R8xLJ6-- From xen-devel-bounces@lists.xenproject.org Wed May 11 20:01:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:01:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327239.550005 (Exim 4.92) (envelope-from ) id 1nosW7-00067I-Uv; Wed, 11 May 2022 20:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327239.550005; Wed, 11 May 2022 20:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosW7-00067B-Rb; Wed, 11 May 2022 20:01:03 +0000 Received: by outflank-mailman (input) for mailman id 327239; Wed, 11 May 2022 20:01:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosW5-000675-08 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:01:02 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12b88735-d165-11ec-a406-831a346695d4; Wed, 11 May 2022 22:00:59 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nosV8-0008ee-V8; Wed, 11 May 2022 22:00:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12b88735-d165-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gDHQr/46Ll+YF5RXidB7bzodWcAOTgjTzZrI+em3L64=; b=g39PxeAmrsyeqF7oG7t83UmsmK q+jHGkHAbmWvohxv26/jw0X2fC5ZQGAB+1t+RR3Dc/QcY0t/UuqqV0Rw0e0vNKpR3Ghg3EjPFEyRu xmyuTU8VIa0JckQ1LnJMbsmPzyPVIePtyYzY2GC02et+W2URhxptR9GwDO/JS6MpbzrCHGb/n2EjF MPTZc218MFC/xIv1c3Q0VBsXMBQNsxYCCeLWiYkZzdC6cvR08qY5ppLv8+FOFZTVkTAZbUvYrBQWZ fyGL7frjV8v7tGHHjzO9nQTkj7crGcqaoQ0KxvgjDlDQp5VOe0vE/nPeGF7YvXLizE8zXvpcRYVIg fCPXiI+Q==; Message-ID: <1c7dfe73-6691-1ca5-7555-27e81dff4dcd@igalia.com> Date: Wed, 11 May 2022 16:58:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list Content-Language: en-US To: Heiko Carstens Cc: Alexander Gordeev , Christian Borntraeger , "David S. Miller" , Sven Schnelle , Vasily Gorbik , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-23-gpiccoli@igalia.com> <7017c234-7c73-524a-11b6-fefdd5646f59@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/05/2022 13:45, Heiko Carstens wrote: > [...] >> >> Hey S390/SPARC folks, sorry for the ping! >> >> Any reviews on this V1 would be greatly appreciated, I'm working on V2 >> and seeking feedback in the non-reviewed patches. > > Sorry, missed that this is quite s390 specific. So, yes, this looks > good to me and nice to see that one of the remaining CONFIG_S390 in > common code will be removed! > > For the s390 bits: > Acked-by: Heiko Carstens No need for apologies, I really appreciate your review! Will add your Ack for V2 =) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 11 20:05:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:05:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327248.550017 (Exim 4.92) (envelope-from ) id 1nosa5-0006mU-IR; Wed, 11 May 2022 20:05:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327248.550017; Wed, 11 May 2022 20:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosa5-0006mN-EU; Wed, 11 May 2022 20:05:09 +0000 Received: by outflank-mailman (input) for mailman id 327248; Wed, 11 May 2022 20:05:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosa3-0006mB-NQ; Wed, 11 May 2022 20:05:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosa3-0006iN-74; Wed, 11 May 2022 20:05:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosa2-0002rA-T0; Wed, 11 May 2022 20:05:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nosa2-0003ag-SX; Wed, 11 May 2022 20:05:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p1cD1887gHjwRCMnIGWBkFxTeNXhpKcLUkFRAbaANlU=; b=XgngyAIFBvIT6CIHZ56kmqb+oX 17Ak4/QPMNLdu70dn9nNNZKc9yA9WgM2KnG/ec245T+7ZJhhJVWz8Vo2LSDu6EUmR4xU5pMGI00gi awHANJOIfDvMx/3E8Ynfr0+70PRx5Mr8pkSnGoXHKBvjOLRAnhvhDGKl+PqDOHrEo3D8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170335: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 20:05:06 +0000 flight 170335 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170335/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 943 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 20:05:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:05:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327252.550028 (Exim 4.92) (envelope-from ) id 1nosaG-00077D-Q1; Wed, 11 May 2022 20:05:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327252.550028; Wed, 11 May 2022 20:05:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosaG-000776-N6; Wed, 11 May 2022 20:05:20 +0000 Received: by outflank-mailman (input) for mailman id 327252; Wed, 11 May 2022 20:05:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosaE-00075w-I5 for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:05:18 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad310eb4-d165-11ec-a406-831a346695d4; Wed, 11 May 2022 22:05:17 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nosZy-0009Kz-VC; Wed, 11 May 2022 22:05:03 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad310eb4-d165-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cfPMnwRmX7h9FC5zogrRSwPWC8hDFfBXdcAc10BCDXg=; b=PNZaBGeXFsuAaBpHuaMdvRY4/s 9D5MPz4xTVgTuRGWrB/KEfGG5tVa1JqSC/LT3Rso5sabWhCAduFdYhflwDt6bgTFq6qWGSH0+ncvk oTm6f/w8sOzZYRkq+1JkZmdb25beje8r1H2EX6HM4WVyQEo/2Q4CTK9pG4z28p8fSDjazKpN99+TQ EpXC0JAykc5ZUnUcVTqfleYx6Z4fPGlU4RkoA5IfJGN2tN+4XLZXjyd3oEcuP2YNdEgKXaQFpZZnR Vejz8nGO8jKYtblRG3YNO8+SxkagQsqAK3ZztXb4IgRQ6EnIjofQ7r4kch6g3mJv37QTO/U/Hn9jn eVwzVLtQ==; Message-ID: Date: Wed, 11 May 2022 17:03:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers Content-Language: en-US To: Steven Rostedt Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-24-gpiccoli@igalia.com> <20220510134014.3923ccba@gandalf.local.home> From: "Guilherme G. Piccoli" In-Reply-To: <20220510134014.3923ccba@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 14:40, Steven Rostedt wrote: > On Wed, 27 Apr 2022 19:49:17 -0300 > "Guilherme G. Piccoli" wrote: > >> Currently we don't have a way to check if there are dumpers set, >> except counting the list members maybe. This patch introduces a very >> simple helper to provide this information, by just keeping track of >> registered/unregistered kmsg dumpers. It's going to be used on the >> panic path in the subsequent patch. > > FYI, it is considered "bad form" to reference in the change log "this > patch". We know this is a patch. The change log should just talk about what > is being done. So can you reword your change logs (you do this is almost > every patch). Here's what I would reword the above to be: > > Currently we don't have a way to check if there are dumpers set, except > perhaps by counting the list members. Introduce a very simple helper to > provide this information, by just keeping track of registered/unregistered > kmsg dumpers. This will simplify the refactoring of the panic path. Thanks for the hint, you're right - it's almost in all of my patches. I'll reword all of them (except the ones already merged) to remove this "bad form". Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 11 20:11:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327268.550039 (Exim 4.92) (envelope-from ) id 1nosgI-0000N4-I6; Wed, 11 May 2022 20:11:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327268.550039; Wed, 11 May 2022 20:11:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosgI-0000Mx-FO; Wed, 11 May 2022 20:11:34 +0000 Received: by outflank-mailman (input) for mailman id 327268; Wed, 11 May 2022 20:11:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosb9-0006lp-RI for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:06:15 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cee9d81e-d165-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 22:06:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01C8061A14; Wed, 11 May 2022 20:06:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55959C340EE; Wed, 11 May 2022 20:06:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cee9d81e-d165-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652299572; bh=oeCZ0vTTOTH1KbY27j1I9n9AJlgXD9xSXE4rv86FJpY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ef6XfNTiqyQhJ6q02mxt7NwtbOVlgMMT30mxCxSyV4pgzHy4DddWm/ictGWuu4WtK xc4Lqu1+SQ8R7haPLzcwPhsQ6n5HVMDy1N5A//jgsS4UwDzK81IzgKFH8AHzxCm9aP rHFrqHO8u3UIjSw55ErjujYOlOBL1KcbQk34Pas2R0Ysg2P9ggDR+vs4yLxISIEhUj yVwGDBh2I2jONWQcoiELYoyOLhTt+BS5a3ri41WaLGmUVwKTsBXT0Ba3JoOhA2XZrY i3wXgNmQPGNmLw83TEMWYpEXr8hVg6pKP2cK5mh8AG378lG31GVyuUto01cyLsu23X pDeX40Bq7ojBw== Date: Wed, 11 May 2022 13:06:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 In-Reply-To: Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Bertrand Marquis wrote: > > I understand the patch is already written, so I was OK if you simply list of the commits with the authors/tags for this time. > > I would like to understand where this requirement is coming from. > > @George: is there some kind of legal reason for something like that ? I am not George but I'll answer the legal question. Our "legal" document is the DCO: https://developercertificate.org/ This falls under case (b): (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or So from the legal point of view only your Signed-off-by line is required. I remember this well because I was confused about this a few years ago in another case of taking code from Linux. > > If both Stefano and you agree to not keep the authorships, then I will > > not stand against it. However, I will not get involved in > > committing and adding my ack. I am fine either way. My only request is to mention the Linux commit-id that Bertrand used as a base and Bertrand has already done that. > I want first to clear up this process and understand why you are > requesting this to know how I should do anything like that in the > future. It looks like our process docs are not very good on this point and might benefit from a clarification. I hope you are volunteering :-) Origin is defined as "it specifies the source of the patch" but it doesn't say what actually is considered a "source". I suggest to distinguish between the case where commits are ported individually from the case where code is copied over (like when we introduced SMMUv3.) If commits are copied individually, I think we probably want an Origin tag for each of them and the source is the original commit-id. If the code is copied from Linux (like the SMMUv3 case) then we probably only want to request a single Origin tag (or a new tag?) with the base Linux version (5.18-rc3) rather than the commit-id being backported. In that case the source would be the repository baseline. Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Wed May 11 20:11:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327269.550050 (Exim 4.92) (envelope-from ) id 1nosgS-0000g8-RD; Wed, 11 May 2022 20:11:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327269.550050; Wed, 11 May 2022 20:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosgS-0000fz-OJ; Wed, 11 May 2022 20:11:44 +0000 Received: by outflank-mailman (input) for mailman id 327269; Wed, 11 May 2022 20:11:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosgR-0000fL-Gf for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:11:43 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 924c99e6-d166-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 22:11:42 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nosg4-0009ub-Ok; Wed, 11 May 2022 22:11:21 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 924c99e6-d166-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CJFn3sQ0AXqP082WliZpvB/FNlzjPtgRZLj1CZSBav8=; b=H0RwJ9q3twuN5LBJHRtfqxptfc +ZBTnXeu+L1QTWv6VeJ074IpruVUqgFdW2irvRDjWrUeZMfUmFqRter3RBPu9sBjZvDxvw8AhX4xB NGR1Fc+pyWr1+lwnwPjEPDyZEUU6BxtInHBrU2MsFuhkvRoiyT0qN7DKB5jSGNAhlNUyQGg7oS78I 1IGokeMYkc2KXY4h6njrMqutcn89GTgmPXm9L8Rca7UD8k1O9WKCSzu2tsWk1It1LXW6uhsh6pzXU eq99TNaaB0b0wsrDl7wLGrG68y5q49uL+rS1rPP4MnQKtWlwuuoA5/zs3LiCVa22Xsjm4CNZYglTD lORMiUaA==; Message-ID: <37190938-8133-aafa-ea4a-e50f574dd73b@igalia.com> Date: Wed, 11 May 2022 17:10:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 10/30] alpha: Clean-up the panic notifier code Content-Language: en-US To: Petr Mladek Cc: Ivan Kokshaysky , Matt Turner , rth@gcc.gnu.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, bhe@redhat.com, kexec@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-11-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 11:16, Petr Mladek wrote: > [...] > Yeah, it is pretty strange behavior. > > I looked into the history. This notifier was added into the alpha code > in 2.4.0-test2pre2. In this historic code, the default panic() code > either rebooted after a timeout or ended in a infinite loop. There > was not crasdump at that times. > > The notifier allowed to change the behavior. There were 3 notifiers: > > + mips and mips64 ended with blinking in panic() > + alpha did __halt() in this srm case > > They both still do this. I guess that it is some historic behavior > that people using these architectures are used to. > > Anyway, it makes sense to do this as the last notifier after > dumping other information. > > Reviewed-by: Petr Mladek > > Best Regards, > Petr Thanks a bunch for the review - added your tag for V2 =) From xen-devel-bounces@lists.xenproject.org Wed May 11 20:24:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:24:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327286.550060 (Exim 4.92) (envelope-from ) id 1nosst-0002YK-6w; Wed, 11 May 2022 20:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327286.550060; Wed, 11 May 2022 20:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nosst-0002YD-3v; Wed, 11 May 2022 20:24:35 +0000 Received: by outflank-mailman (input) for mailman id 327286; Wed, 11 May 2022 20:24:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nossr-0002Y7-0w for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:24:33 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d360711-d168-11ec-a406-831a346695d4; Wed, 11 May 2022 22:24:32 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1noss0-000Aod-US; Wed, 11 May 2022 22:23:41 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d360711-d168-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LCKlEcL/+gLbho7zoJo89g9MDYx2GFkg8N7n1nlW+0g=; b=MQpyMZ3nMM+SlSF0Ic+7AggIHS wWCWxLFJNdpcNC/qKw1wNJR3uSo8xMkfiJlq7d2aikSbZG9yuq1pfGOyawWDcFgWnRsla4fbF455Y 3RXCIUoMIO9o6uix81B+J++RZraHoxYIg5AFTEzg2KmNpXSrs7BEjvRicrp5TYhs6s3mYN27kkyAz njPDxaRSeQ75fkZPzqisnL9xIuav4szhmycF8VItK7avDyCoEE8U/Zs7xTZO8x+jizmxi0qGskMhG GsWdK7oyZ7kJDFhpPsgWAmAhF7aiE+T5aNpN2RQ5WYTzC7ql7jtRy3esjCfYNiJNCeB+2D6JHceeB Ayva3vzg==; Message-ID: <4b003501-f5c3-cd66-d222-88d98c93e141@igalia.com> Date: Wed, 11 May 2022 17:22:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 11/30] um: Improve panic notifiers consistency and ordering Content-Language: en-US To: Petr Mladek , Anton Ivanov , Johannes Berg , Richard Weinberger Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-12-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 11:28, Petr Mladek wrote: > [...] > It is not clear to me why user mode linux should not care about > the other notifiers. It might be because I do not know much > about the user mode linux. > > Is the because they always create core dump or are never running > in a hypervisor or ...? > > AFAIK, the notifiers do many different things. For example, there > is a notifier that disables RCU watchdog, print some extra > information. Why none of them make sense here? > Hi Petr, my understanding is that UML is a form of running Linux as a regular userspace process for testing purposes. With that said, as soon as we exit in the error path, less "pollution" would happen, so users can use GDB to debug the core dump for example. In later patches of this series (when we split the panic notifiers in 3 lists) these UML notifiers run in the pre-reboot list, so they run after the informational notifiers for example (in the default level). But without the list split we cannot order properly, so my gut feeling is that makes sense to run them rather earlier than later in the panic process... Maybe Anton / Johannes / Richard could give their opinions - appreciate that, I'm not attached to the priority here, it's more about users' common usage of UML I can think of... Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 11 20:28:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 20:28:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327296.550071 (Exim 4.92) (envelope-from ) id 1noswJ-00039j-Nq; Wed, 11 May 2022 20:28:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327296.550071; Wed, 11 May 2022 20:28:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noswJ-00039c-KX; Wed, 11 May 2022 20:28:07 +0000 Received: by outflank-mailman (input) for mailman id 327296; Wed, 11 May 2022 20:28:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noswI-00039W-Vv for xen-devel@lists.xenproject.org; Wed, 11 May 2022 20:28:06 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dcc7e116-d168-11ec-8fc4-03012f2f19d4; Wed, 11 May 2022 22:28:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9B3FB82622; Wed, 11 May 2022 20:28:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72760C340EE; Wed, 11 May 2022 20:28:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcc7e116-d168-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652300883; bh=aqsoCvtdR+zz0dA1DNGarTzDOHpfs5A6XpKMT8xqPOM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pMwK+ZNueI6AJjV7vbGATVbILl14UMy4p+hOg2BNOug+M6rvPrN8UL/yKJOIFKBOx 7iFJ/u+2UqawSTsNNa3EK+yZjholM2lT9aiLcR4CDkWYdRf4y60KavdKEuPtLwxyl9 uBmcugCkgu4GQ1qENN3t9bIFa+oGEXVlw+sKW6swGMIPUiW3Pv5EqOMKSnjMyl0rqi yAvxH/VvvXY0kptwTzwpHSQrBIM6vArAuow10lsvg8GbWdjq44dEvCgdI19/q3ZIu/ i14PdKWE8+jUQ5/nximFi10JHmsflSZBmypI1k/bZkjZplWA2IYwLxqVuFXZdNGNqK ngpYy/Bie6jvg== Date: Wed, 11 May 2022 13:28:01 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: Stefano Stabellini , Boris Ostrovsky , jgross@suse.com, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, Rahul Singh Subject: Re: [PATCH] swiotlb-xen: fix DMA_ATTR_NO_KERNEL_MAPPING on arm In-Reply-To: <20220511141328.GA31939@lst.de> Message-ID: References: <20220423171422.1831676-1-hch@lst.de> <20220428132737.GA13999@lst.de> <27d39d5a-3b79-bdda-b7e4-f4477667919f@oracle.com> <41c2483c-ab54-41be-7815-9d4a98e0249e@oracle.com> <20220511141328.GA31939@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Christoph Hellwig wrote: > On Fri, Apr 29, 2022 at 04:15:38PM -0700, Stefano Stabellini wrote: > > Great! Christoph you can go ahead and pick it up in your tree if you are > > up for it. > > The patch is in the dma-mapping for-next brancch now: > > http://git.infradead.org/users/hch/dma-mapping.git/commitdiff/62cb1ca1654b57589c582efae2748159c74ee356 > > There were a few smaller merge conflicts with the swiotlb refactoring. > I think everything is fine, but please take another look if possible. Looks good to me From xen-devel-bounces@lists.xenproject.org Wed May 11 21:10:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 21:10:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327303.550083 (Exim 4.92) (envelope-from ) id 1notar-0007Zi-Vv; Wed, 11 May 2022 21:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327303.550083; Wed, 11 May 2022 21:10:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notar-0007Yt-Qk; Wed, 11 May 2022 21:10:01 +0000 Received: by outflank-mailman (input) for mailman id 327303; Wed, 11 May 2022 21:10:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notaq-0007SU-Fq for xen-devel@lists.xenproject.org; Wed, 11 May 2022 21:10:00 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4e16cfc-d16e-11ec-a406-831a346695d4; Wed, 11 May 2022 23:09:56 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24BKFmbd010355; Wed, 11 May 2022 21:09:42 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fwf6cas4w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 21:09:41 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24BL1gZ8018519; Wed, 11 May 2022 21:09:41 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fwf74tv4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 May 2022 21:09:40 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MN2PR10MB3872.namprd10.prod.outlook.com (2603:10b6:208:1b8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 11 May 2022 21:09:39 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5227.023; Wed, 11 May 2022 21:09:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4e16cfc-d16e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=FASIeEUl1pX/XPtEFTSF4e42NLZ0OSScKjkvXRCXnGI=; b=Qr8U7S6Y2Y9NTq7iPZAHVdglo0ws/1AUAE+DRW3ZdCJtzRVFofRsfzGjFMcMJHwGK8Qv dUZrjqUuPVlBmDE0CCdf9jYgbpn5bo8l6tVBr2OvTiRXBQpC1sAAL/yHSKuXGNumhzN5 XA2ZBmW5HmwU7dpdWTsWTe7jDRqnVpYe9OFA9k7/mV/VwUW94H2lEtudNWrPLsYo4tjO /Mi2iAfUN4VEUbqBLQA6M9+SUAYZHp7ItFDsezIrvNEOmkfJ7EUAWIbcUwXTBdepG29u 58DCblDhhboBC0FjHnm+XeSioUZJEi8Q5FAQkHWr8LHNQoKpCT3oxy3rP2gdE4eqbzgs 1g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrzI2kbDIJu3Nw7mWh+Nw4x/BAVusUt75Lb7CLWKODm93YhoEj2aYTmhj2cZZuXq0MK9LpuQ/m0vDvSJWmCynQrBG9U96tcmu9NLmLdcrR4FeMvDPkDtK5iHxslDRfpJKdvScl31Y9r9pcOdVP4vQrqxW7adz2LBsFJvMgAOE+ghi3IJCvsntuR7hdPdjHadbIk6sE11NDdvh1TluGjC0gg+qQFcxpxZpRde3dnv01mjlqkQxxs/Yd13CE3Xj4+YZ8UIsWK4S8ziM5AwaF/o8WixWk9zkMxUTvq6jJ5EXqrzD7azU+2wDqYGf58b8/mRoh/QHbVN0TVthzg21pPBZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FASIeEUl1pX/XPtEFTSF4e42NLZ0OSScKjkvXRCXnGI=; b=YrPMgcCQp3e7Xw8cy4axVnUop3baYBFUhxglb12L1aAVH0VbpMRoNTN7kep+n1GFp54CJB1UfTHkJJeB2q+QsDrtWMNuKDYjgLGZMfmUe67K5owm6D6dh1DWgkd0SR6oDr2WlrJDtucPVttqMr89di4pReaDhLZU+wX1A5ouU38PjewIpXojM2stCHYDn3OxcLfxRa/WBcTxy5WvHz6K4/YEV+l4WWdF7DGy2qBadzXFc1sBJstfyCcAX0mc+oTwXqSOdEnyx8HoqvjHIPegFAUxzwWeax8aOM8TxexwEutCVb2KTOUVjrmpz/utcfvJ0TH+aiIeU+PnPZyvzqMO8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FASIeEUl1pX/XPtEFTSF4e42NLZ0OSScKjkvXRCXnGI=; b=wG0A6H9eBNOVekpQdbcjM12RCDHIZ+oGc74OHqc4FC0yFFff1QJ3wyodLPbFAjA68ELNuQ0U1u/igP1vNuRH3rEeTl1ef76TDBMYI+Kps4xtZz6M4ruJrwNte6qiF+U6FK45fvQ18VRRmU6XN4Oxi+egzL5eETfkAnEfwZl4/ys= Message-ID: <24748b59-e2ed-1d7d-801e-ab9dc12b0983@oracle.com> Date: Wed, 11 May 2022 17:09:33 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Oleksandr , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juergen Gross , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <8409e636-94e3-e231-f181-c76a849534a1@gmail.com> From: Boris Ostrovsky In-Reply-To: <8409e636-94e3-e231-f181-c76a849534a1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR03CA0276.namprd03.prod.outlook.com (2603:10b6:a03:39e::11) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00d2aae7-7c63-4434-e8ea-08da33928f25 X-MS-TrafficTypeDiagnostic: MN2PR10MB3872:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z1IEc00CSvy0hdctJzqvlCVoRMAfNuOsitnX5ByHJ5nMwLGs+pPuzHDl2w+3symHWzZvwkznr5us39Uyr1/XYURdccZOXDW4LISx7N2S1ThdYvuhcTX2R5AvwKtcor9I1JxJO4z2DGRhs351oWNh5AtNqZ/0zTVmTQdnfRgwvxLWeE81b5csRgyF/J0v/IDED+e6QeDbqS/nlbgwz5vaqvDzvNZmLqNvyweMhn/OrFFbnb5UHzIbDpAYuv/Oyr93z98XiG5Pls/61rjewKeNbM+c1r043CJnkbC4pJBbMeGWprIqRNRLQt3A5TQUF/EULP+YzlMjjmyGFOHZKNkhw4PGI1yXd+nKLpj+sc8pNFGlf6s+5UeWWfEDkU/HJ/iygdT9V7Kr4yDfLG68Cg8DDavVWPlip4wONkJGEf33SRGUlA1KFwRTAgbZgKkPSzFeLBLMK3J0h+yBo5HZODWMM82X7eCsMbr01FpLeyDo32YXwE/62dimxux0Yeq0Mt4IhY+qnCVp6q152/sALnPDHaurL8uw/UbMoLH4NhEndw62jzVsmT76NLnZaYqKv4xxfAz8J9cW/EXB0vrGC51ttBXk9jO3g+fNN5l16jriuMqPMh1t751YQhmRYzSxLcVVgbCmWOZoMd4ppUHMxXCplnh+ON0CMevaY58EqrQ2BRbyul1jj/F40utQwfGQu+UR/1211TguVWtKvnXWqPosIoyMICd8UcgMnB0QXmuqyRTfP//D4ropeqXWRo9bds5w X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(66476007)(66556008)(31696002)(36756003)(86362001)(4326008)(8676002)(508600001)(66946007)(2616005)(54906003)(83380400001)(2906002)(186003)(44832011)(6666004)(6512007)(26005)(7416002)(5660300002)(110136005)(6506007)(53546011)(316002)(38100700002)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWlBQnN3R2xYRnQzWjJuNWxhS2RTNGJ3NjJFYktDSEJka2hndWNHcnlqZWJF?= =?utf-8?B?S2hSOXBkQ1JNMWxoWVg3VFV3a3Mzd0g1cVJQUWZmUi90ZDRIYXhzWlBubUxp?= =?utf-8?B?RlBPeHNtWldYYzlUNkRtV0xyY2NnVWNXN1BKUTJESXFKbmFrNHdDZkZHYTVq?= =?utf-8?B?bzU1ZDRSRlp3Vkh5cFdwemFvanFEaVVyaGhOR0c5akdRWitueS9SMEJSVS96?= =?utf-8?B?TzJWZldOdTd1QnZQM3lCQ1RSaWZNWTFZTTkwbWNjOWFjRXk3VnZ3d1l3dFNZ?= =?utf-8?B?bmY2ckJLeGtPNW5LdEVBNlhybEpvQnJnSngzV3FqUnVUNWp5WVVkbDg2RGhs?= =?utf-8?B?ZENoNG0reW9oeGxndXVVQkNtN0ZOT00rWVVuS1c5TUJlK0JxcGdDYnJYUTlG?= =?utf-8?B?ZlNpOFIzSEl1ZjJuU3VZakE3b0pZVVhWNW13SVU0K3E5ZzNZanRJVVFqSEp1?= =?utf-8?B?eEhGUm1jbkRBWkJRLzFla0hnQU5VZ2lLaGZRNmdjS2x0K0h1T0MrcGZBb3dr?= =?utf-8?B?cTJ1ajJKOXhaam1qelE0NEU5VWtBYksydFJuS1NUVmk3UFRGb2xldEVhdTJL?= =?utf-8?B?d1E2VGN5SWlBeWFjWno4WG1VdXpnWEdqMHRqT2crMUdGMlpoRlZia2lsemF4?= =?utf-8?B?MUk0dEdEbUIza3RCZXg4ZzlDeW91RjdhQmxaMUUwU1JrSllrTjN4SHFDSWlt?= =?utf-8?B?V3l6TDc4dittTlpSZzkvZzMzMWwyN2lMRXNFZ2R3Vk5CUW1hV2o5T1FERUFr?= =?utf-8?B?VHFwQ2xST3AyMThLakMxdXRWZ0M1bW9yeUw2S2hDTUZNU3l2UUZzRU9VUGV6?= =?utf-8?B?TE9sdTN4RlZlbmVZdmVVaGdHZ1JYVFRWa2w5UHpmV1BLWGpXbUZoWE9FUGUz?= =?utf-8?B?cEs0elptVVJyemxDdUlJNFE2dy9KS2hoWncwemVqZ1FpRVVOckRmUCsyOTdo?= =?utf-8?B?MVJTdWV0Ui9zV3M5MENvZGY3RzE3NG9nanJoUUtVeGRXVVJGSHEvcGJrdzZp?= =?utf-8?B?QXFTVlIwV2JDYkJUQjM0VFlPUzlFcGN6YVhYTzE5aUcvVTZDMTJRU1QyT01j?= =?utf-8?B?dTlQOGRYZ1NNOVB0TXBKU000SVlyZjBxWXRMK001ZWk2WjhNbXJwdWp4WGxw?= =?utf-8?B?K1FNeXo1cmpURjRBcnhrY1MrcTY1eGtQdmkyWERGd04xNFdKWUl5NzFrOHAx?= =?utf-8?B?SlZWTFVndDRsaG5BWnAycDVIWWwxTjJXUXNyRmg0eHVNVjFScVE2dW9CeURB?= =?utf-8?B?MHVEZHd5eXEwSzJjQ05nUUNGVCtRREJjREJSck8xN1RtUlVjbi9VUmtvOXJz?= =?utf-8?B?dytIZjgxQkQ0NVFVK2IzcCtZaVpBS1ZXMjlLQk5LNWtpdVNPZi9YYmZpd25U?= =?utf-8?B?QysrYlE5amc2SkNvc3NoUnFxd2tSNjY3Z2N2LzhPSHN3eDlIVDRSenlEQlUz?= =?utf-8?B?by9wbWpxaTBKN3JoSlNwNkpLODZRemVWcHduR3lDd1hxU1BPNm9LbFN5WGh2?= =?utf-8?B?b2JlT3FHb1dLWTBsVkg0eWlKQTliRUQ3UGJwN3RoNm9yMmZBdjFERStkT2RH?= =?utf-8?B?SEwvaG9kLy9qK3RZODJIUWNZSURaNCtJSVBETUU4VFl2dmtKclh2MmNxVmlH?= =?utf-8?B?S1VWQVZKZkt5VkJlT2tPR3FHUzh0SVFEejNTMlJYQWdBdlhPNFNHcTVENEg1?= =?utf-8?B?SmlrdzRpamJ3UVQyY3pPcGsvU0VBbEpYcVN2MVhWUzdSTXlxa1NnSmZoMGhz?= =?utf-8?B?ck1NV0p2Q1pzVWJOY1Z0MlU0SXlWUlhOMEVvSlRYMlRxaXh1US96ZklrN2la?= =?utf-8?B?Z0I2Q0NjaS9oSEJZemR1dmZOTGlLMW1ZN1NCU2lGMEJBdDhtMWxhQWY3R1Yv?= =?utf-8?B?THVjdHRMRmx2Nm1GMnpDK3BVSUoxRW5LYkZDeVVIZGIzN0h6YkNwWWRsWTVa?= =?utf-8?B?bkphTkt6bDhNK3o3aWpUQWZ5dWJWUlo4VHN5SkdCMS8xRUdsU3BhbEJwQnA0?= =?utf-8?B?M3NFSVI2NVFDTlNBRk80SVNMTktYcytldVBOMmJqYjkrYUd1MzZ5Tll6L3A4?= =?utf-8?B?VU5sZjRKSWJXZUtOMWw0bUVrS0lQZUlCdnp4bEhaeHdwTlBDMDNweHpaVFNt?= =?utf-8?B?WnJBTDNCVzU3Z25FU3U4YVdrU2V0dXNKVUN5SDVLS2VDSXBORDZVSzlBTVFE?= =?utf-8?B?OTJOZzhFdndCZjdNQ1MyMnV3Nm42aWdSTEFmbWRIc1B3WWhFSVhJK0RiSjBs?= =?utf-8?B?M1phRitzdzVUQ1pUTDFQUEl0V01HdG13eStSOUMrQzJKU3BDYkRIeGwyU3NQ?= =?utf-8?B?TU5Jek8xWWZFYlNFWlZPTFltWmdFYnN3aHhDQUJoYTk0L2RxTURFVm0yT0p4?= =?utf-8?Q?W/rjUGlTk89hs0QM=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00d2aae7-7c63-4434-e8ea-08da33928f25 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 21:09:38.8726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SEif40vTMr5TYc2Qku+3LVVncd4ooM9Hco2gBDpcL2sshp1lcCWlldVBfsmFndQKCk1eij+UXJmKU8/yCUiGijFLmLDlszaBEDjsfC4fXkY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3872 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-11_07:2022-05-11,2022-05-11 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=804 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205110091 X-Proofpoint-ORIG-GUID: e3AavS7o_eFKu7AeDx8tI1DYYUovFplk X-Proofpoint-GUID: e3AavS7o_eFKu7AeDx8tI1DYYUovFplk On 5/11/22 2:00 PM, Oleksandr wrote: > > On 07.05.22 21:19, Oleksandr Tyshchenko wrote: > > Hello Boris, Stefano > > >> From: Juergen Gross >> >> For support of virtio via grant mappings in rare cases larger mappings >> using consecutive grants are needed. Support those by adding a bitmap >> of free grants. >> >> As consecutive grants will be needed only in very rare cases (e.g. when >> configuring a virtio device with a multi-page ring), optimize for the >> normal case of non-consecutive allocations. >> >> Signed-off-by: Juergen Gross >> --- >> Changes RFC -> V1: >>     - no changes >>     Changes V1 -> V2: >>     - no changes > > > May I please ask for the review here? I had a quick look but I am stuck on get_free_seq(), I need to stare at it some more. Unless someone else reviews this, I will try to get to this in the next couple of days. One thing I did notice is > >> @@ -1452,6 +1624,13 @@ int gnttab_init(void) >>           } >>       } >>   +    i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; >> +    gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); >> +    if (!gnttab_free_bitmap) { >> +        ret = -ENOMEM; >> +        goto ini_nomem; >> +    } This overwrites 'i' and will break error handling at ini_nomem. -boris From xen-devel-bounces@lists.xenproject.org Wed May 11 21:27:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 21:27:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327314.550094 (Exim 4.92) (envelope-from ) id 1notrW-0001NQ-EN; Wed, 11 May 2022 21:27:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327314.550094; Wed, 11 May 2022 21:27:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notrW-0001NJ-B1; Wed, 11 May 2022 21:27:14 +0000 Received: by outflank-mailman (input) for mailman id 327314; Wed, 11 May 2022 21:27:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notrV-0001N9-7u; Wed, 11 May 2022 21:27:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notrV-00089T-68; Wed, 11 May 2022 21:27:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1notrU-0007ua-Ms; Wed, 11 May 2022 21:27:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1notrU-0007dJ-MS; Wed, 11 May 2022 21:27:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X82Cf4D1SALcIX3vWzPmg/uLGUy3BmeeeY56al7lRIk=; b=mVu8FbujAsOprby8d3lynK9vSf WYGrBtocnTXYQRxsKUX2uont95UpR0eGWrD75QYiYdyfRrC8tlUCLJhvxJrPCo/8m2aJFFv4r/Lql UGPHTPbNUmUKHPvBtD1QvHxnwMuEpXSYpoGgc3bgih98Ezhoz6H55LasgYVjwx3E6YBs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170336: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 21:27:12 +0000 flight 170336 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170336/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 944 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 22:24:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 22:24:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327324.550104 (Exim 4.92) (envelope-from ) id 1noukH-0007mK-S1; Wed, 11 May 2022 22:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327324.550104; Wed, 11 May 2022 22:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noukH-0007mD-PL; Wed, 11 May 2022 22:23:49 +0000 Received: by outflank-mailman (input) for mailman id 327324; Wed, 11 May 2022 22:23:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noukG-0007m3-4B; Wed, 11 May 2022 22:23:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noukG-0000fp-1h; Wed, 11 May 2022 22:23:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noukF-0001z5-Iz; Wed, 11 May 2022 22:23:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noukF-0000sC-IX; Wed, 11 May 2022 22:23:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hALzxPLSM7hdgbUQyBdkrd95/IV4DVmzBeU8cznQzJI=; b=xEXT4mLl+LXc8eLrhq5n9/S+zU GO5FYxAbKJ+879ruhpW+18RgjSViIp4YAq3SEzClt9boJtaqyw4DHUAPLBX5cOV8ZaipgHVEwgeQl aOQ5+e8YlUg5rkiSgXkr7pBKNNu7uw9+rRfIJtYi0Az0fYm5gAbChgd5tCzQoL/IkId0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170337: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 22:23:47 +0000 flight 170337 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170337/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 945 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 23:01:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 23:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327333.550116 (Exim 4.92) (envelope-from ) id 1novKi-0003Qk-P4; Wed, 11 May 2022 23:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327333.550116; Wed, 11 May 2022 23:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novKi-0003Qd-Ky; Wed, 11 May 2022 23:01:28 +0000 Received: by outflank-mailman (input) for mailman id 327333; Wed, 11 May 2022 23:01:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novKg-0003QT-SO; Wed, 11 May 2022 23:01:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novKg-0001Kf-QU; Wed, 11 May 2022 23:01:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novKg-00032K-3B; Wed, 11 May 2022 23:01:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1novKg-0003yp-2j; Wed, 11 May 2022 23:01:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4RwNci7+3Tv/BvyDZo/f1mcupEedR4puMZtHekcnVSg=; b=32Vnj5DWMi5rv8PD+AadpxIkZf hU81yk2FDw0F/0cJf2A9r25XaQtF9CMJyJeF/dzgOvLcEgyeoWCyRLgIjdcZsj43Lxv0hp6E3wAH7 1LP4cCF70uWKKj2d9IOX+UQzFxyJaEvuO1SxT14RakuDNGROHiAG5BG5SUNP86/zDvFE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170338: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 23:01:26 +0000 flight 170338 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170338/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 946 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 11 23:20:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 23:20:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327342.550127 (Exim 4.92) (envelope-from ) id 1novd0-0005kz-CE; Wed, 11 May 2022 23:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327342.550127; Wed, 11 May 2022 23:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novd0-0005ks-8b; Wed, 11 May 2022 23:20:22 +0000 Received: by outflank-mailman (input) for mailman id 327342; Wed, 11 May 2022 23:20:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novcz-0005ki-Ev; Wed, 11 May 2022 23:20:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novcz-0001dU-Bg; Wed, 11 May 2022 23:20:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novcy-0003V6-Vx; Wed, 11 May 2022 23:20:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1novcy-0007Td-VU; Wed, 11 May 2022 23:20:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PA+VSjGGBvp8pMTiNPN5LamBlHsBuVrM8D47OejhZ+g=; b=ElbkWG7vopdyDSUbh0+528CA5c y6vBGj8GIdsIyt0FsIFK5B9oMJfVorvtHynyGWW/pSZWmSeFANIgh/iVbl1/dydY+rD3Hn/gfnrw6 hz7KaF8obRyOltGd0FpuRJO+y3D/XiRSU3it7116dejE7IijkqzGAoXkLNbRklgDZpsM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170334: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ec11dc41eec5142b4776db1296972c6323ba5847 X-Osstest-Versions-That: qemuu=178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab From: osstest service owner Date: Wed, 11 May 2022 23:20:20 +0000 flight 170334 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170334/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170286 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170286 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170286 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170286 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170286 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170286 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170286 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170286 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu ec11dc41eec5142b4776db1296972c6323ba5847 baseline version: qemuu 178bacb66d98d9ee7a702b9f2a4dfcd88b72a9ab Last test of basis 170286 2022-05-10 02:27:31 Z 1 days Testing same since 170334 2022-05-11 18:38:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Markus Armbruster Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 178bacb66d..ec11dc41ee ec11dc41eec5142b4776db1296972c6323ba5847 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed May 11 23:31:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 11 May 2022 23:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327352.550138 (Exim 4.92) (envelope-from ) id 1novnb-0007Ho-Jj; Wed, 11 May 2022 23:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327352.550138; Wed, 11 May 2022 23:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novnb-0007Hh-GP; Wed, 11 May 2022 23:31:19 +0000 Received: by outflank-mailman (input) for mailman id 327352; Wed, 11 May 2022 23:31:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novna-0007HX-2A; Wed, 11 May 2022 23:31:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novna-0001q9-16; Wed, 11 May 2022 23:31:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1novnZ-0003jE-Ms; Wed, 11 May 2022 23:31:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1novnZ-0003Fc-MO; Wed, 11 May 2022 23:31:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MS0gj3EjP3jIKMtR65uZqPnAjpX48VRXWlcm4bs5Ga4=; b=yt7JkLIgnl2Ou6GL6tmpdF16HE PebkSk74zDYd0NEMW2eHCCt8Flx2VzXELLEMYaRoppxOZ76U5e+7Ko/AZWjaNcWiU7tonJ7/Suh4e rLUsvQmrXDCn/7W0la3GxOmYPHG3ZsyQgKp/xsE0VAShXKLAoMLddzz9YXrj1jDSia8w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170339: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 11 May 2022 23:31:17 +0000 flight 170339 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170339/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 947 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 00:28:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 00:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327361.550149 (Exim 4.92) (envelope-from ) id 1nowgr-0004WS-Ry; Thu, 12 May 2022 00:28:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327361.550149; Thu, 12 May 2022 00:28:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nowgr-0004WL-NV; Thu, 12 May 2022 00:28:25 +0000 Received: by outflank-mailman (input) for mailman id 327361; Thu, 12 May 2022 00:28:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nowgq-0004WB-Ew; Thu, 12 May 2022 00:28:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nowgq-0003Oi-DH; Thu, 12 May 2022 00:28:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nowgq-0004yH-2C; Thu, 12 May 2022 00:28:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nowgq-00006x-1k; Thu, 12 May 2022 00:28:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EXEKaLfS4b4e7B21rIWl6yFPnZ/yxytEbQXYjOVOj6I=; b=JDQ8szEiMvMrEs6vLO6ZqRMR8z nY4uFf2/ksPTwkfWGrLcMslamJw9Ud7F/8/jvq80/11KJCaCkww/zMHxunDXarDOYw2+kyBOe8yEm vMg8c8lcisPqnBaaNevCkQi3+cxcVgEWc8s650VNslefkmLLCFsVpYY5VhHO3L5nD064=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170340: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 00:28:24 +0000 flight 170340 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170340/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 948 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 01:00:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 01:00:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327370.550160 (Exim 4.92) (envelope-from ) id 1noxBE-0007j1-8m; Thu, 12 May 2022 00:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327370.550160; Thu, 12 May 2022 00:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxBE-0007iu-4t; Thu, 12 May 2022 00:59:48 +0000 Received: by outflank-mailman (input) for mailman id 327370; Thu, 12 May 2022 00:59:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxBD-0007ik-4M; Thu, 12 May 2022 00:59:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxBD-0003ux-2a; Thu, 12 May 2022 00:59:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxBC-0005di-J0; Thu, 12 May 2022 00:59:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noxBC-0007RM-IX; Thu, 12 May 2022 00:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nIXOJHy0Vuc/bqnh+E49Z0VWXYBHh4ESI0+JfFWNbMI=; b=tG6J4S8S+7anVuwlKE0WcNklhJ wdqf8wqL2Br+1TmreQR2FXcOS47L5+vbrRlZnqZUcCxEcChWe1bHNgK3Hqpq5+nHK3BQ5WdcTC2Qi kk8HN1ljy4i/t686sCZE9SOqSEqM/6Ohr8kkt6wNVRpsgObV92QRqtKCgNIPDbvtaTgo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170341: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 00:59:46 +0000 flight 170341 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170341/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 949 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 01:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 01:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327379.550171 (Exim 4.92) (envelope-from ) id 1noxt1-0002Ta-SK; Thu, 12 May 2022 01:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327379.550171; Thu, 12 May 2022 01:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxt1-0002TS-MA; Thu, 12 May 2022 01:45:03 +0000 Received: by outflank-mailman (input) for mailman id 327379; Thu, 12 May 2022 01:45:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxt0-0002TI-DD; Thu, 12 May 2022 01:45:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxt0-0002Y1-8Q; Thu, 12 May 2022 01:45:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noxsz-0006ct-UE; Thu, 12 May 2022 01:45:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1noxsz-0000RO-Te; Thu, 12 May 2022 01:45:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uLDFujENqWc9Ba17z+f9iWQMTT9nge41BtOY8+jSZPg=; b=ZfX6jg5/k7DoB41BjCN77xxHuy uRfylFA/OsJGcRWExWxZSIDuJzqFVDdwUM/v0S7oeLuhx19C8yZu3hNpLS09yVEXQHxCwEFeOPSor P/nyaS40XrY/oTxACTa4yoeJAb68dZfmTRtkkKqCpMO2eui3d3mm+Zw1aQB5jD6OVAhs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170342: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 01:45:01 +0000 flight 170342 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170342/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 71 days 950 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 03:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 03:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327389.550182 (Exim 4.92) (envelope-from ) id 1nozJa-00031G-LK; Thu, 12 May 2022 03:16:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327389.550182; Thu, 12 May 2022 03:16:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nozJa-000319-Hy; Thu, 12 May 2022 03:16:34 +0000 Received: by outflank-mailman (input) for mailman id 327389; Thu, 12 May 2022 03:16:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nozJY-00030z-T1; Thu, 12 May 2022 03:16:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nozJY-0004a6-RC; Thu, 12 May 2022 03:16:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nozJY-0000TL-JL; Thu, 12 May 2022 03:16:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nozJY-0005sh-Iv; Thu, 12 May 2022 03:16:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r1kLXB+JPBuTvF1TEMfpPQAgzcGQkMVy/I/dW6evO8U=; b=nmKVF38QZR3dSshhNFgXEZXUlh Yfc/3i87YXIO0s9j2K0aHPQIqPcRy+4nemt4RLAvVCDh9/kp6k8dPnCdzS95cJuQc/07LoRyX9j+u LaWrR1OK++OmnLV2WzTNl6Yqh8xZXSKboPByhaw8Co7LhsM0vlFbZvPJ6P+CZgxNi0gM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170344: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 03:16:32 +0000 flight 170344 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170344/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 951 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 05:08:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 05:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327398.550193 (Exim 4.92) (envelope-from ) id 1np13w-0005Nz-Uj; Thu, 12 May 2022 05:08:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327398.550193; Thu, 12 May 2022 05:08:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np13w-0005Ns-Ro; Thu, 12 May 2022 05:08:32 +0000 Received: by outflank-mailman (input) for mailman id 327398; Thu, 12 May 2022 05:08:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np13u-0005Ni-SV; Thu, 12 May 2022 05:08:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np13u-00070W-RX; Thu, 12 May 2022 05:08:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np13u-0006oU-Gj; Thu, 12 May 2022 05:08:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np13u-0002DW-GE; Thu, 12 May 2022 05:08:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MQGKEYK4knmN5JjQthd5rzgH+gr2+IH+bl/XuKHE3zY=; b=PBQ77iwvk4IXSHe9OJpErXcSMX m4NQr6CzILzzhDfHIdobSn6qGUoA0vFEutprmLNG2MoZZaTv5L/WbQ4ZwZTpyYR5/rUlohFWk19Ud 0syeUU0FU3GAME8Hb0Jn9mxSBRqo+MEqThk2Og1H69fX+ubBL0FUccKovmgaOTZUE6TI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170345: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 05:08:30 +0000 flight 170345 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 952 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 06:00:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 06:00:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327407.550204 (Exim 4.92) (envelope-from ) id 1np1sa-0002ni-RT; Thu, 12 May 2022 06:00:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327407.550204; Thu, 12 May 2022 06:00:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np1sa-0002nb-O5; Thu, 12 May 2022 06:00:52 +0000 Received: by outflank-mailman (input) for mailman id 327407; Thu, 12 May 2022 06:00:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np1sY-0002nQ-SK; Thu, 12 May 2022 06:00:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np1sY-0007zx-P6; Thu, 12 May 2022 06:00:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np1sY-0001IV-9y; Thu, 12 May 2022 06:00:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np1sY-0003bk-9a; Thu, 12 May 2022 06:00:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NyNBkbsdYR/sxhAAXvNd6ZOknyorkv8oGAk6P9unMPI=; b=Pim9aCO1k+QPD/Zjsr3rT4lZRb e7rdd/6IAtN2RtHftcdSc48W3eaclZS9mCDkZ98fOvxGSbtPWsybMWf2Y0vgLF+xD+0IiBKvXfyKG 0dqiDxLa/LJxRxE6dd2rne1OAc3PUNYZos/UyVs1nB3jjspz/yyuJ4065nedHgjykQcU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170347: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 06:00:50 +0000 flight 170347 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170347/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 953 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 06:12:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 06:12:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327416.550215 (Exim 4.92) (envelope-from ) id 1np23G-0004Ga-Ot; Thu, 12 May 2022 06:11:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327416.550215; Thu, 12 May 2022 06:11:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np23G-0004GT-MB; Thu, 12 May 2022 06:11:54 +0000 Received: by outflank-mailman (input) for mailman id 327416; Thu, 12 May 2022 06:11:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np23E-0004GN-Mr for xen-devel@lists.xenproject.org; Thu, 12 May 2022 06:11:52 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69f8691c-d1ba-11ec-a406-831a346695d4; Thu, 12 May 2022 08:11:51 +0200 (CEST) Received: by mail-lj1-x236.google.com with SMTP id 16so5156598lju.13 for ; Wed, 11 May 2022 23:11:51 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id 17-20020ac24d51000000b0047255d2119asm617346lfp.201.2022.05.11.23.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 23:11:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69f8691c-d1ba-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=NEB+jrNm+Tn2FtofeaBVpeeoHMLJsewS6l3Qc041rsM=; b=NNEUu6kPZ1arfW4eHUTQDHxPZV/kgJ370ELIRRoRiXNWZ5JJi9ZCFJO/R344mtpCg0 vrL8s3NxqydBsjCxs5i3xi6bIjgpDLx/+cyNPZScHQ4l3rj85FQUP8NsYNUKGPyKHiwL HkLijvpLEQCy8RojLGQhtygKeI+z+sETXEpoy5R+qPsiQgVbcQokY51YeREWOqH2qspM rNibrz1iHC4ETdUPQBJutTzoVJlSAmvAjiiUAjOGdBaQMREZx2lZg9Gh0RHnQEd60wTq yXnEBA3TkTar00aJ1t5mx+OkH2e8EamaGMjyBereZye249/Hpp8mTJrGf2KQAlwKUCrS UFBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NEB+jrNm+Tn2FtofeaBVpeeoHMLJsewS6l3Qc041rsM=; b=dVPLk0sDjQ4g0WBECa8+2MFsxWFi9YqCgiMUZVWYCdIbIw7dYxhM+AdmAurPTQG/h7 PvCJOJw77myAPqjZDa+7a0FkWfgm/JxQuibY34UabAFSV6l/vIsm+hU2t2Yu2mSfbUYO rT3m3rwSSBd+mxMxKLIneWjWFiVnwl4oopVlizxH26JqWtRTsLrLP/SvSZ6pdgnYyMO6 2ku16JfNcBDbeJy0Ziev6Njxt3CQGZXesp8qFo3bhNZqKBHYTdH9DBZjS5819YwiQAeY yvlZ2KdwgzKgGZ7GZmg17GL0AzzjWJvWEIV4Uft86veBzIWWpvpqxGel22rmk5m8vhYD MTzA== X-Gm-Message-State: AOAM5323acOeEtc41EAJYnJRXisJyr+k3qmK1N5GRYnlzkR0FQYIGinS XGPBh0Y/CeIUm88I1Wk0T+g= X-Google-Smtp-Source: ABdhPJyMRNpNOP2eL5Vb3YEt2h7dyYcK52kqLFmo+atTAmUfpAkUnaLLPD4zU5Qj2p/8dIrpHs9V/Q== X-Received: by 2002:a05:651c:895:b0:250:c5ec:bc89 with SMTP id d21-20020a05651c089500b00250c5ecbc89mr13159344ljq.251.1652335910783; Wed, 11 May 2022 23:11:50 -0700 (PDT) Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants To: Boris Ostrovsky Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juergen Gross , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <8409e636-94e3-e231-f181-c76a849534a1@gmail.com> <24748b59-e2ed-1d7d-801e-ab9dc12b0983@oracle.com> From: Oleksandr Message-ID: <749e79d0-c920-adee-c145-edc4153a99f9@gmail.com> Date: Thu, 12 May 2022 09:11:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24748b59-e2ed-1d7d-801e-ab9dc12b0983@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 12.05.22 00:09, Boris Ostrovsky wrote: Hello Boris > > On 5/11/22 2:00 PM, Oleksandr wrote: >> >> On 07.05.22 21:19, Oleksandr Tyshchenko wrote: >> >> Hello Boris, Stefano >> >> >>> From: Juergen Gross >>> >>> For support of virtio via grant mappings in rare cases larger mappings >>> using consecutive grants are needed. Support those by adding a bitmap >>> of free grants. >>> >>> As consecutive grants will be needed only in very rare cases (e.g. when >>> configuring a virtio device with a multi-page ring), optimize for the >>> normal case of non-consecutive allocations. >>> >>> Signed-off-by: Juergen Gross >>> --- >>> Changes RFC -> V1: >>>     - no changes >>>     Changes V1 -> V2: >>>     - no changes >> >> >> May I please ask for the review here? > > > > I had a quick look but I am stuck on get_free_seq(), I need to stare > at it some more. Unless someone else reviews this, I will try to get > to this in the next couple of days. Thank you! > > > > One thing I did notice is > > >> >>> @@ -1452,6 +1624,13 @@ int gnttab_init(void) >>>           } >>>       } >>>   +    i = gnttab_interface->grefs_per_grant_frame * >>> max_nr_grant_frames; >>> +    gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); >>> +    if (!gnttab_free_bitmap) { >>> +        ret = -ENOMEM; >>> +        goto ini_nomem; >>> +    } > > > This overwrites 'i' and will break error handling at ini_nomem. Indeed, will fix. Thank you for pointing this out. > > > -boris > > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 12 07:37:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 07:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327424.550225 (Exim 4.92) (envelope-from ) id 1np3OD-0003dD-69; Thu, 12 May 2022 07:37:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327424.550225; Thu, 12 May 2022 07:37:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3OD-0003d6-3G; Thu, 12 May 2022 07:37:37 +0000 Received: by outflank-mailman (input) for mailman id 327424; Thu, 12 May 2022 07:37:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3OC-0003cv-Gg; Thu, 12 May 2022 07:37:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3OC-0001De-EF; Thu, 12 May 2022 07:37:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3OC-0005b1-0x; Thu, 12 May 2022 07:37:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np3OC-0001n0-0Y; Thu, 12 May 2022 07:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zwCGxOvry+oFiuShrd+is+VuIRZIgYR0ebS+s3RMgvc=; b=U1P6Uq/De0OLzM7NcB78Lrdt/C vcbeZ93LZKjMHuCAecAZyWPbZ/6ZL5wVwrvVc4jdQ+MpEzSyd9DiHo9bcny8Tcfc/H2yl/YNfhbIS sVEKGbAvsp3vMIAJzFyrY6YM7MtVV7C5dJbZ1x8WJAyy0byPCv8WSv2gfhE/9+KfLv0s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170346: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=2ba73a10fd79637888235cfee8110fe2a21a9f7e X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 12 May 2022 07:37:36 +0000 flight 170346 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170346/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 2ba73a10fd79637888235cfee8110fe2a21a9f7e baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 671 days Failing since 151818 2020-07-11 04:18:52 Z 670 days 652 attempts Testing same since 170317 2022-05-11 04:19:02 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 106995 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 07:40:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 07:40:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327432.550236 (Exim 4.92) (envelope-from ) id 1np3Qy-0004zm-Kr; Thu, 12 May 2022 07:40:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327432.550236; Thu, 12 May 2022 07:40:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3Qy-0004zf-Hy; Thu, 12 May 2022 07:40:28 +0000 Received: by outflank-mailman (input) for mailman id 327432; Thu, 12 May 2022 07:40:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3Qx-0004zV-PN; Thu, 12 May 2022 07:40:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3Qx-0001Hu-OY; Thu, 12 May 2022 07:40:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np3Qx-0005fy-HX; Thu, 12 May 2022 07:40:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np3Qx-0006HQ-H3; Thu, 12 May 2022 07:40:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=v1rDNaFOxyjIsZKhbtlMMXCUo1y+lFtxc/IM9Wz8DM8=; b=TICoC0n7+xNcKbLm+v1iXpKV2W eO74vps3CHwBWIGX90AVp9/oKEXJRT61PMkvcOl6su7J3ffkQoqmCIaN0XTGQ3SwJI1r4Boe0gqus 6B2QPqyK5Tik1wrrjL4Df/EFgVPSyzmlKeYpJXHEF2tlUoc5Fxjht/Q+ixJGIKZDoJBQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170348: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 07:40:27 +0000 flight 170348 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170348/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 954 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 08:31:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 08:31:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327445.550248 (Exim 4.92) (envelope-from ) id 1np4EN-00027D-Qr; Thu, 12 May 2022 08:31:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327445.550248; Thu, 12 May 2022 08:31:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4EN-000276-O0; Thu, 12 May 2022 08:31:31 +0000 Received: by outflank-mailman (input) for mailman id 327445; Thu, 12 May 2022 08:31:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4EM-00026w-Jc; Thu, 12 May 2022 08:31:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4EM-0002i2-EA; Thu, 12 May 2022 08:31:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4EM-0008Si-3Q; Thu, 12 May 2022 08:31:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np4EM-0003UP-2u; Thu, 12 May 2022 08:31:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oXdLDOaLFXsleFGu0JmkoxLVLOEyxgaBAyXrLlXN4xY=; b=ojHDA91cfloK7LWBF2RPJUUQ+j qYiGiI/I7dDoZ87okzxlDVbN97hE5dDFbs+V16iVIiB1YN9F4kmjRpoOZEtRZQ3ZHfEnApirAnL+M 3eqQ7vqzGScqqAqTetKifdDlSX/am3qTIimkFq5i575UcV1OF2Q5hLmO5BwZjbrGReqg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170349: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 08:31:30 +0000 flight 170349 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170349/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 955 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 08:54:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 08:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327455.550258 (Exim 4.92) (envelope-from ) id 1np4aT-0004ZZ-UA; Thu, 12 May 2022 08:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327455.550258; Thu, 12 May 2022 08:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4aT-0004ZS-R0; Thu, 12 May 2022 08:54:21 +0000 Received: by outflank-mailman (input) for mailman id 327455; Thu, 12 May 2022 08:50:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4WY-0004V4-Ie for xen-devel@lists.xenproject.org; Thu, 12 May 2022 08:50:19 +0000 Received: from mail3.wdc04.mandrillapp.com (mail3.wdc04.mandrillapp.com [205.201.139.3]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8adacf2d-d1d0-11ec-a406-831a346695d4; Thu, 12 May 2022 10:50:16 +0200 (CEST) Received: from pmta16.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail3.wdc04.mandrillapp.com (Mailchimp) with ESMTP id 4KzQTM0Q75zDRHyxq for ; Thu, 12 May 2022 08:50:15 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id bca19fc1dadd49118639a15c3c00fc8b; Thu, 12 May 2022 08:50:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8adacf2d-d1d0-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1652345415; x=1652647815; i=marc.ungeschikts@vates.fr; bh=gPIhKTLhm1hmpvmBH/sXBXH9XsvbRLPl6fZ1Bdhpoeo=; h=From:Subject:In-Reply-To:References:Message-Id:To:Cc:Feedback-ID: Date:MIME-Version:Content-Type:CC:Date:Subject:From; b=d2bkbsVBdwV5OcSqpMnZwdFlS3OR0QNUdfSv2o4KrrQHnJAqP29wkk+mEYQmsxngj 69lobGHinTbG5fvvBA5Sh9JyKow6Xcv8UfTtReCEk+NvonmqSig3bkeH8Pijm+Z5Ic OajkscFzgFEJW4WlfTCvZM44P662wIU6M7dvt6OM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1652345414; h=From : Subject : In-Reply-To : References : Message-Id : To : Cc : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=gPIhKTLhm1hmpvmBH/sXBXH9XsvbRLPl6fZ1Bdhpoeo=; b=UfPV2ywq0mukGagogar15Q3UCVMYKFCTbx0aqyfJdrPeZljfeR6dJT3J7t9BWRZK9mBrz6 hrVV5tpLD80Vkx9UW16A7YurLsVt5FI1jc6DGQNoQycP2Ue+kco6ZPpi/hQLrkwcQS+7tPrq n0a7uEE8QUvKNvStTkoZcp/6nxK5U= From: Marc Ungeschikts Subject: Re: Xen Project management working group X-Bm-Draft-Refresh-Date: 1652345412558 X-Bm-Draft-Info: {"type":"REPLY-ALL","messageInternalId":712905,"folderUid":"06b05917-1346-47a2-9230-c6774f30abc7"} X-Bm-Internal-Id: DE8B30B6-117C-4174-8780-9ABFF47FC58A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:756292 X-Bm-Previous-Body: a2e18f2b9d65fd90edbc48ee96b24652249ef712 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: cdab68bc-dc2f-400f-9b5c-ad5e091af192 X-Bm-Transport-Timestamp: 1652345412849 In-Reply-To: References: Message-Id: To: Olivier Lambert , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, george.dunlap@citrix.com, Marc Ungeschikts X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.bca19fc1dadd49118639a15c3c00fc8b X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220512:md Date: Thu, 12 May 2022 08:50:14 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-YbSA3yBFVFxKcqnRqb1Csg" --_av-YbSA3yBFVFxKcqnRqb1Csg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Following the meeting of the 14th April [https://cryptpad.fr/pad/#/3/pad/ed= it/c4fdcd12de9a85e303fa0fd4d787b7de/], here is a new Doodle link to schedul= e the next Xen Project Management Working Group meeting: https://doodle.com/meeting/organize/id/dyPg8MWb Agenda: - Jira demo - Feedback / discussion - Define the next step Let me know if you have any questions. Regards Le lundi 11/04/2022, 13:21, Olivier Lambert a =C3=A9crit : https://doodle.com/meeting/participate/id/b822G1ge I will probably leave the Doodle opened for few days (like up to Monday eve= ning) until we can decide the best schedule without waiting too long. When = I'll have the validated time slot, I'll communicate about it here. So, as planned, here is the selected date. I picked this Thursday, April th= e 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add t= his to your calendar :) Meeting place will be: https://meet.vates.fr/xenmgmt See you soon! Regards, Olivier Lambert | Vates CEO XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com --_av-YbSA3yBFVFxKcqnRqb1Csg Content-Type: multipart/related; boundary="_av-GkUlQwyi5O1oCZZmNTVAXw" --_av-GkUlQwyi5O1oCZZmNTVAXw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Hello,


Following the meet= ing of the 14th April, here is a new Doodle link to schedule the next X= en Project Management Working Group meeting:

https://doodle.com/meeting= /organize/id/dyPg8MWb

Agenda:

- Jira demo

- Feedback / discussion

- Define the next step


Let me know if you have an= y questions.

Regards

Le lundi 11/04/2022, 13:21, Olivier Lambert a =C3=A9crit :


https://doodle.com/me= eting/participate/id/b822G1ge


I will probably leave= the Doodle opened for few days (like up to Monday evening) until we can de= cide the best schedule without waiting too long. When I'll have the validat= ed time slot, I'll communicate about it here.



So, as planned, here i= s the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5P= M London time, 6PM Paris time). Don't forget to add this to your calendar := )


Meeting place will be:=

https://meet.vates.fr/= xenmgmt


See you soon!




Regards,

 
 

 
Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solut= ions
w: vates.fr | xcp-ng.org | xe= n-orchestra.com
">
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solution= s
w: vates.fr | xcp-ng.org | xen-or= chestra.com
--_av-GkUlQwyi5O1oCZZmNTVAXw Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline /9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/ 2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1 dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU 1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR 8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0 nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7 9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8 F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+ Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5 +GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/ 4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8 Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W 0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+ 7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4 S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+ JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3 aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8 M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/ j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/ hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8 HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI /wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r 7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3 hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia 2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9 /p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT 6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb 9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88 KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM 77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8 e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7 i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4 ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4 P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD 4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4 ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01 8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq /wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8 SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y +NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67 SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n /Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm 8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS 0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60 qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z 3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5 Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx 7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8 vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44 +IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v +/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3 uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0 Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340 fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4 Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn /BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38 KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/ jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2 mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm 3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF 43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt 4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7 G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP 2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94 uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+ J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21 OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3 /g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0 r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox 8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe 0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v 14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S 8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+ BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/ AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/ sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4 M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy /wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd +wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR 8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/ BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk 0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ 88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr 5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6 Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6 RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/ Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7 sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF 0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+ GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo 0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740 xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4 YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl 0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u 0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2 fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5 rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l /q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6 WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU 62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7 694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/ BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L +E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW 8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw 2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+ HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G 0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP 4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4 NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2 /wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0 1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI 8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+ Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy 3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy 2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8 RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74 meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0 nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1 W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs 8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0 H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p 1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx /tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/ 2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH /wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd 5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9 6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr 8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL /wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b +GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w 9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815 60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3 s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690 H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj 7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1 ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4 nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG 4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD 3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh 6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8 T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC 61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+ ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5 TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf 8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM 2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44 YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3 KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+ WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G /CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+ TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+ WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/ B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1 JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV 8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P 4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9 u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ 8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1 K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL 8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj 5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0 FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7 f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km 22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/ sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+ wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp 6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/ AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7 fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u 1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR 1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0 n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd 8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw 0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN 3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1 tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7 rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr 9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc /tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+ ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U 3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9 bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh 2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo 3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0 7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0 cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV 5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq 5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/ FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I 7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/ 4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8 PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K 3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6 nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs 1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej 7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+ D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs 6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z 1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP 2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3 HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7 u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp 08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2 R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+ P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP 82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgD//2Q== --_av-GkUlQwyi5O1oCZZmNTVAXw Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline /9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/ 2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1 dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU 1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR 8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0 nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7 9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8 F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+ Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5 +GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/ 4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8 Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W 0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+ 7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4 S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+ JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3 aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8 M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/ j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/ hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8 HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI /wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r 7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3 hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia 2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9 /p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT 6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb 9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88 KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM 77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8 e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7 i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4 ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4 P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD 4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4 ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01 8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq /wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8 SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y +NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67 SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n /Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm 8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS 0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60 qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z 3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5 Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx 7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8 vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44 +IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v +/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3 uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0 Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340 fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4 Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn /BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38 KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/ jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2 mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm 3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF 43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt 4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7 G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP 2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94 uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+ J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21 OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3 /g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0 r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox 8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe 0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v 14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S 8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+ BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/ AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/ sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4 M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy /wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd +wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR 8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/ BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk 0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ 88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr 5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6 Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6 RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/ Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7 sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF 0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+ GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo 0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740 xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4 YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl 0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u 0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2 fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5 rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l /q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6 WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU 62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7 694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/ BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L +E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW 8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw 2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+ HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G 0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP 4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4 NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2 /wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0 1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI 8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+ Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy 3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy 2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8 RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74 meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0 nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1 W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs 8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0 H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p 1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx /tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/ 2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH /wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd 5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9 6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr 8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL /wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b +GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w 9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815 60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3 s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690 H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj 7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1 ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4 nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG 4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD 3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh 6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8 T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC 61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+ ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5 TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf 8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM 2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44 YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3 KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+ WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G /CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+ TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+ WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/ B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1 JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV 8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P 4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9 u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ 8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1 K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL 8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj 5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0 FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7 f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km 22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/ sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+ wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp 6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/ AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7 fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u 1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR 1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0 n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd 8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw 0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN 3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1 tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7 rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr 9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc /tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+ ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U 3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9 bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh 2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo 3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0 7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0 cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV 5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq 5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/ FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I 7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/ 4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8 PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K 3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6 nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs 1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej 7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+ D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs 6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z 1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP 2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3 HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7 u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp 08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2 R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+ P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP 82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgD//2Q== --_av-GkUlQwyi5O1oCZZmNTVAXw-- --_av-YbSA3yBFVFxKcqnRqb1Csg-- From xen-devel-bounces@lists.xenproject.org Thu May 12 08:56:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 08:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327463.550270 (Exim 4.92) (envelope-from ) id 1np4cu-0005Cb-Fb; Thu, 12 May 2022 08:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327463.550270; Thu, 12 May 2022 08:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4cu-0005CU-CA; Thu, 12 May 2022 08:56:52 +0000 Received: by outflank-mailman (input) for mailman id 327463; Thu, 12 May 2022 08:56:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4cs-0005CM-S4 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 08:56:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4cs-00038x-CM; Thu, 12 May 2022 08:56:50 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1np4cs-00042r-6P; Thu, 12 May 2022 08:56:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2Mg1225RNDZ4nc3rt5o9Hrn+rbeNZBGAUoV6S+qswi8=; b=mZh5gHvZCR1QOThzQsZmdgF5N1 VZUBPF8Smb1QSdf5u6W6H6R+AwK98BA5avu7URtt9gudMbdCmALZsimfYp0V8n2u3ESJwZdyjJ6P5 EZAzWozeRn4VlsF9pkqhJffspHnhog338G5Hfmc/gXBcOVgD+51wfsgKImvSRMF6+J+Y=; Message-ID: Date: Thu, 12 May 2022 09:56:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 11/05/2022 15:32, Rahul Singh wrote: >> On 10 May 2022, at 1:32 pm, Julien Grall wrote: >>> +domain may toggle masked bits in the masked bit field and should clear the >>> +pending bit when an event has been processed >>> + >>> +Events are received by a domain via an interrupt from Xen to the domain, >>> +indicating when an event arrives (setting the bit). Further notifications are >>> +blocked until the bit is cleared again. Events are delivered asynchronously to >>> +a domain and are enqueued when the domain is not running. >>> +More information about FIFO based event channel can be found at: >> >> I think the explanation is fine for a design proposal. If you want to use it as documentation, then I would suggest to clarify there are two different ABI for event channel: FIFO and 2L. >> >> 2L is the easiest one to implement and for embedded we may want to steer the users towards it. > > I will rephrase the sentence as below: > > Xen supports two different ABI for event channel FIFO and 2L. More information about FIFO based event channel can be found at: I think it is a bit strange to point to the FIFO doc but not the 2L (the explanantion above is not really for 2L). If there are no doc for the latter, then I would possibly drop the link. >>> +The event channel sub-node has the following properties: >>> + >>> +- compatible >>> + >>> + "xen,evtchn" >>> + >>> +- xen,evtchn >>> + >>> + The property is tuples of two numbers >>> + (local-evtchn link-to-foreign-evtchn) where: >>> + >>> + local-evtchn is an integer value that will be used to allocate local port >>> + for a domain to send and receive event notifications to/from the remote >>> + domain. >> Port 0 is reserved and both FIFO/2L have limit on the port numbers. >> >> I think we should let know the users about those limitations but I am not sure whether the binding is the right place for that. > > If you are okay I can add this limitation in this design doc. Design docs are generally for developper of Xen rather than the end users. I am OK if you want to add the limitations in this design doc so long we have another easy way for the user to find out the limits. This could be end users documentation and/or message in Xen. Note that 2L has a lower limit and we don't know in advance what the guest will use. So we may have to assume the lower limit (4096) which should be plenty for embedded :). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 12 09:03:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:03:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327471.550281 (Exim 4.92) (envelope-from ) id 1np4ix-0006ex-7R; Thu, 12 May 2022 09:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327471.550281; Thu, 12 May 2022 09:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4ix-0006eq-2i; Thu, 12 May 2022 09:03:07 +0000 Received: by outflank-mailman (input) for mailman id 327471; Thu, 12 May 2022 09:03:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4iv-0006eg-UD; Thu, 12 May 2022 09:03:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4iv-0003HJ-Ox; Thu, 12 May 2022 09:03:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4iv-0001Zk-9W; Thu, 12 May 2022 09:03:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np4iv-0002fN-97; Thu, 12 May 2022 09:03:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dTORmnfePMO5+BtK+xJio/HSef9TsygEKhY6J/kHmmM=; b=Jgl1z1/AFijUo+A2QWWYJeAXEi prQnDbYJqvVZSAFOdvnDB9AOZTU8xGO+tOHhMPTs3kZlxCaoxBPF+e3HkMfAHJgx5grGbvLWGvnx8 gFVGZJJ8PSSpq27+1XgwYLcxylliDZbhjob4hYirexd2OU+4JTPLIrDtHaOU6qpwedN0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170343: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 X-Osstest-Versions-That: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 From: osstest service owner Date: Thu, 12 May 2022 09:03:05 +0000 flight 170343 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170343/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 170314 pass in 170343 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 170314 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 170314 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 170314 like 170307 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170314 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170314 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170314 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170314 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170314 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170314 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170314 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170314 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170314 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170314 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170314 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 baseline version: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 Last test of basis 170343 2022-05-12 01:51:50 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu May 12 09:03:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327477.550292 (Exim 4.92) (envelope-from ) id 1np4jL-00078W-GG; Thu, 12 May 2022 09:03:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327477.550292; Thu, 12 May 2022 09:03:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4jL-00078P-Cr; Thu, 12 May 2022 09:03:31 +0000 Received: by outflank-mailman (input) for mailman id 327477; Thu, 12 May 2022 09:03:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4jK-00078B-2R; Thu, 12 May 2022 09:03:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4jK-0003HW-1Z; Thu, 12 May 2022 09:03:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4jJ-0001aO-IR; Thu, 12 May 2022 09:03:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np4jJ-0002fs-Hz; Thu, 12 May 2022 09:03:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1C2r36hW65diVgjyZyC2QM0thBSdCueob7j1HLUDcbw=; b=5AePQhsaV6ImzC8j56PWVC7kwJ Crk3B1aiPl/Y0gj8wPpGR4X4CTfyEvtwtRZn0Qp9GA6MIyLJ0Td/+sLI97TzThXWsvs+9daxnxPgM IrHhbk7fX8Sc3/QPW/fOTuk9B+XQLdUhbgngIHYMLFMjlX2Eds1w9tlK+jOPbZRhv+8o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170350: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 09:03:29 +0000 flight 170350 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170350/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 956 attempts Testing same since 170321 2022-05-11 09:11:39 Z 0 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327491.550314 (Exim 4.92) (envelope-from ) id 1np4rm-0000Zx-T0; Thu, 12 May 2022 09:12:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327491.550314; Thu, 12 May 2022 09:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rm-0000Zq-PO; Thu, 12 May 2022 09:12:14 +0000 Received: by outflank-mailman (input) for mailman id 327491; Thu, 12 May 2022 09:12:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rl-0000Wp-Pu for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9ba00a5d-d1d3-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 11:12:12 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C70A8143D; Thu, 12 May 2022 02:12:11 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 404A13F73D; Thu, 12 May 2022 02:12:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ba00a5d-d1d3-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 1/8] xen/arm: introduce static shared memory Date: Thu, 12 May 2022 17:11:22 +0800 Message-Id: <20220512091129.2802997-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch serie introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 120 ++++++++++++++++++++++++++ xen/arch/arm/Kconfig | 6 ++ xen/arch/arm/bootfdt.c | 68 +++++++++++++++ xen/arch/arm/include/asm/setup.h | 3 + 4 files changed, 197 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index a94125394e..e63ce171fc 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -355,3 +355,123 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An u8 value represents the unique identifier of the shared memory region. + The maximum identifier shall be "xen,shm-id = <0xff>". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. The number of cells + for the host address (and size) is the same as the guest pseudo-physical + address and they are inherited from the parent node. + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + "dom_shared", a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as 0x0, host physical +address starting at 0x10000000 of 256MB will be reserved to be shared between +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest physical address +space, and at 0x50000000 in DomU1 guest physical address space. Dom0 is +explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as 0x1, host physical +address starting at 0x50000000 of 512MB will be reserved to be shared between +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical +address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 +and DomU2 are both the borrower domain, the owner domain is the default owner +domain dom_shared. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..5ee9921f56 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -106,6 +106,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 29671c8df0..c8e8747c3e 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -360,6 +360,70 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + u32 address_cells, u32 size_cells) +{ + const struct fdt_property *prop; + const __be32 *cell; + paddr_t paddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned long i; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + prop = fdt_get_property(fdt, node, "xen,shared-mem", NULL); + if ( !prop ) + return -ENOENT; + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * A static shared memory region could be shared between multiple + * domains. + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + break; + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of domains, which later may be used to + * calculate the number of the reference count. + */ + mem->bank[i].nr_shm_domain++; + + return 0; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -380,6 +444,10 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); +#ifdef CONFIG_STATIC_SHM + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); +#endif if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 7a1e1d6798..35449bd7d8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -27,6 +27,9 @@ struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + unsigned int nr_shm_domain; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327490.550303 (Exim 4.92) (envelope-from ) id 1np4rk-0000KH-Js; Thu, 12 May 2022 09:12:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327490.550303; Thu, 12 May 2022 09:12:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rk-0000KA-Gb; Thu, 12 May 2022 09:12:12 +0000 Received: by outflank-mailman (input) for mailman id 327490; Thu, 12 May 2022 09:12:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rk-0000K4-2M for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:12 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 99eafa16-d1d3-11ec-a406-831a346695d4; Thu, 12 May 2022 11:12:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C42B8106F; Thu, 12 May 2022 02:12:08 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 36F2A3F73D; Thu, 12 May 2022 02:12:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99eafa16-d1d3-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v3 0/8] static shared memory on dom0less system Date: Thu, 12 May 2022 17:11:21 +0800 Message-Id: <20220512091129.2802997-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (8): xen/arm: introduce static shared memory xen/arm: allocate static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 docs/misc/arm/device-tree/booting.txt | 120 ++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 68 +++++ xen/arch/arm/domain_build.c | 378 +++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 4 + xen/arch/arm/mm.c | 36 ++- xen/common/domain.c | 5 + 9 files changed, 612 insertions(+), 10 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327492.550325 (Exim 4.92) (envelope-from ) id 1np4rr-0000td-6q; Thu, 12 May 2022 09:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327492.550325; Thu, 12 May 2022 09:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rr-0000tW-1e; Thu, 12 May 2022 09:12:19 +0000 Received: by outflank-mailman (input) for mailman id 327492; Thu, 12 May 2022 09:12:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rp-0000Wp-IB for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:17 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9e12d817-d1d3-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 11:12:16 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CAA891474; Thu, 12 May 2022 02:12:15 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4A5853F73D; Thu, 12 May 2022 02:12:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e12d817-d1d3-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v3 2/8] xen/arm: allocate static shared memory to the default owner dom_io Date: Thu, 12 May 2022 17:11:23 +0800 Message-Id: <20220512091129.2802997-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng --- v3 change: - refine in-code comment --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 132 +++++++++++++++++++++++++++++++++++- xen/common/domain.c | 5 ++ 2 files changed, 136 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1472ca4972..5b41ec57f0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -519,6 +519,10 @@ static bool __init append_static_memory_to_bank(struct domain *d, return true; } +/* + * If cell is NULL, pbase and psize should hold valid values. + * Otherwise, cell will be populated together with pbase and psize. + */ static mfn_t __init acquire_static_memory_bank(struct domain *d, const __be32 **cell, u32 addr_cells, u32 size_cells, @@ -527,7 +531,8 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, mfn_t smfn; int res; - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); + if ( cell ) + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); if ( PFN_DOWN(*psize) > UINT_MAX ) { @@ -751,6 +756,125 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + + page = maddr_to_page(pbase); + ASSERT(page); + + if ( page_get_owner(page) == NULL ) + return false; + + ASSERT(page_get_owner(page) == dom_io); + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t *pbase, paddr_t *psize) +{ + /* + * Pages of statically shared memory shall be included + * in domain_tot_pages(). + */ + d->max_pages += PFN_DOWN(*psize); + + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, + pbase, psize); + +} + +/* + * Func allocate_shared_memory is supposed to be only called + * from the owner. + */ +static int __init allocate_shared_memory(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, addr_cells, size_cells, &pbase, + &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. + * It sees RAM 1:1 and we do not need to create P2M mapping for it + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + int ret = 0; + const struct dt_property *prop; + const __be32 *cells; + u32 shm_id; + u32 addr_cells, size_cells; + paddr_t gbase, pbase, psize; + + dt_for_each_child_node(node, shm_node) + { + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + if ( !dt_property_read_u32(shm_node, "xen,shm-id", &shm_id) ) + { + printk("Shared memory node does not provide \"xen,shm-id\" property.\n"); + return -ENOENT; + } + + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + if ( !prop ) + { + printk("Shared memory node does not provide \"xen,shared-mem\" property.\n"); + return -ENOENT; + } + cells = (const __be32 *)prop->value; + /* xen,shared-mem = ; */ + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); + gbase = dt_read_number(cells, addr_cells); + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * Per static shared memory region could be shared between multiple + * domains. + * In case re-allocating the same shared memory region, we check + * if it is already allocated to the default owner dom_io before + * the actual allocation. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* Allocate statically shared pages to the default owner dom_io. */ + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3149,6 +3273,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index 8d2c2a9897..43237c287a 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -780,6 +780,11 @@ void __init setup_system_domains(void) * This domain owns I/O pages that are within the range of the page_info * array. Mappings occur at the priv of the caller. * Quarantined PCI devices will be associated with this domain. + * + * DOMID_IO could also be used for mapping memory when no explicit + * domain is specified. + * For instance, DOMID_IO is the owner of memory pre-shared among + * multiple domains at boot time, when no explicit owner is specified. */ dom_io = domain_create(DOMID_IO, NULL, 0); if ( IS_ERR(dom_io) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327494.550336 (Exim 4.92) (envelope-from ) id 1np4rv-0001Eq-E4; Thu, 12 May 2022 09:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327494.550336; Thu, 12 May 2022 09:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rv-0001Ed-9q; Thu, 12 May 2022 09:12:23 +0000 Received: by outflank-mailman (input) for mailman id 327494; Thu, 12 May 2022 09:12:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rt-0000K4-EO for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a001d8d2-d1d3-11ec-a406-831a346695d4; Thu, 12 May 2022 11:12:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13020106F; Thu, 12 May 2022 02:12:19 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 530393F73D; Thu, 12 May 2022 02:12:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a001d8d2-d1d3-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 3/8] xen/arm: allocate static shared memory to a specific owner domain Date: Thu, 12 May 2022 17:11:24 +0800 Message-Id: <20220512091129.2802997-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng --- v3 change: - simplify the code since o_gbase is not used if the domain is dom_io --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 44 +++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 5b41ec57f0..9c53b9fa7b 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -797,9 +797,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, */ static int __init allocate_shared_memory(struct domain *d, u32 addr_cells, u32 size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -814,8 +816,18 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR + "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -828,6 +840,8 @@ static int __init process_shm(struct domain *d, u32 shm_id; u32 addr_cells, size_cells; paddr_t gbase, pbase, psize; + const char *role_str; + bool owner_dom_io = true; dt_for_each_child_node(node, shm_node) { @@ -854,19 +868,27 @@ static int __init process_shm(struct domain *d, ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); gbase = dt_read_number(cells, addr_cells); - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * Per static shared memory region could be shared between multiple * domains. - * In case re-allocating the same shared memory region, we check - * if it is already allocated to the default owner dom_io before - * the actual allocation. + * So when owner domain is the default dom_io, in case re-allocating + * the same shared memory region, we check if it is already allocated + * to the default owner dom_io before the actual allocation. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { - /* Allocate statically shared pages to the default owner dom_io. */ - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + /* Allocate statically shared pages to the owner domain. */ + ret = allocate_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327495.550347 (Exim 4.92) (envelope-from ) id 1np4rx-0001X8-1e; Thu, 12 May 2022 09:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327495.550347; Thu, 12 May 2022 09:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rw-0001Wz-Sr; Thu, 12 May 2022 09:12:24 +0000 Received: by outflank-mailman (input) for mailman id 327495; Thu, 12 May 2022 09:12:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rw-0000Wp-1r for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a1f9c86e-d1d3-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 11:12:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67EFE106F; Thu, 12 May 2022 02:12:22 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 89FF63F73D; Thu, 12 May 2022 02:12:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1f9c86e-d1d3-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr Date: Thu, 12 May 2022 17:11:25 +0800 Message-Id: <20220512091129.2802997-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng --- v3 changes: - check overflow with "n" - remove spurious change - bring back the check that we enter the loop only when count_info is greater than 0 --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 36 ++++++++++++++++++++++++++--------- 2 files changed, 31 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -347,6 +347,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4906..a9461e07aa 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; @@ -1548,10 +1549,10 @@ struct domain *page_get_owner_and_reference(struct page_info *page) * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + if ( unlikely(((x + nr) & PGC_count_mask) <= 1) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1559,14 +1560,20 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT(((y & PGC_count_mask) != 0) && + (((y - nr) & PGC_count_mask) >= 0)); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); @@ -1576,19 +1583,30 @@ void put_page(struct page_info *page) } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) { - const struct domain *owner = page_get_owner_and_reference(page); + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) +{ + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:12:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:12:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327502.550358 (Exim 4.92) (envelope-from ) id 1np4s1-00021j-Dy; Thu, 12 May 2022 09:12:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327502.550358; Thu, 12 May 2022 09:12:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4s1-00021R-87; Thu, 12 May 2022 09:12:29 +0000 Received: by outflank-mailman (input) for mailman id 327502; Thu, 12 May 2022 09:12:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4rz-0000K4-BM for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a3ed0d8a-d1d3-11ec-a406-831a346695d4; Thu, 12 May 2022 11:12:26 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98C16106F; Thu, 12 May 2022 02:12:25 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D95683F73D; Thu, 12 May 2022 02:12:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3ed0d8a-d1d3-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Thu, 12 May 2022 17:11:26 +0800 Message-Id: <20220512091129.2802997-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng --- v3 change: - printk rather than dprintk since it is a serious error --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 9c53b9fa7b..293e79e4e7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -791,6 +791,34 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, } +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned long bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( pbase == bank_start && psize == bank_size ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + if ( d == dom_io ) + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain; + else + /* Exclude the owner domain itself. */ + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain - 1; + + return 0; +} + /* * Func allocate_shared_memory is supposed to be only called * from the owner. @@ -802,6 +830,8 @@ static int __init allocate_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -816,6 +846,7 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); @@ -827,6 +858,37 @@ static int __init allocate_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrow domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of let borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:21:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:21:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327538.550369 (Exim 4.92) (envelope-from ) id 1np50y-0004kq-HN; Thu, 12 May 2022 09:21:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327538.550369; Thu, 12 May 2022 09:21:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np50y-0004kj-Ec; Thu, 12 May 2022 09:21:44 +0000 Received: by outflank-mailman (input) for mailman id 327538; Thu, 12 May 2022 09:21:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4s8-0000K4-BT for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a97b9672-d1d3-11ec-a406-831a346695d4; Thu, 12 May 2022 11:12:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F79D106F; Thu, 12 May 2022 02:12:35 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 79D313F73D; Thu, 12 May 2022 02:12:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a97b9672-d1d3-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 8/8] xen/arm: enable statically shared memory on Dom0 Date: Thu, 12 May 2022 17:11:29 +0800 Message-Id: <20220512091129.2802997-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v3 change: - no change --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fb9146b6e0..f4740f9085 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2611,6 +2611,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3622,6 +3627,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3656,6 +3664,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327553.550380 (Exim 4.92) (envelope-from ) id 1np51L-0005GI-R6; Thu, 12 May 2022 09:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327553.550380; Thu, 12 May 2022 09:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np51L-0005Fm-Nu; Thu, 12 May 2022 09:22:07 +0000 Received: by outflank-mailman (input) for mailman id 327553; Thu, 12 May 2022 09:22:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4s4-0000Wp-3A for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a5d10ba2-d1d3-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 11:12:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD0B2106F; Thu, 12 May 2022 02:12:28 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1767C3F73D; Thu, 12 May 2022 02:12:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5d10ba2-d1d3-11ec-8fc4-03012f2f19d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 6/8] xen/arm: set up shared memory foreign mapping for borrower domain Date: Thu, 12 May 2022 17:11:27 +0800 Message-Id: <20220512091129.2802997-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v3 change: - use map_regions_p2mt instead --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 293e79e4e7..aa7c264e23 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -954,6 +954,15 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:22:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327564.550391 (Exim 4.92) (envelope-from ) id 1np51Y-0005fC-4V; Thu, 12 May 2022 09:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327564.550391; Thu, 12 May 2022 09:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np51Y-0005f3-18; Thu, 12 May 2022 09:22:20 +0000 Received: by outflank-mailman (input) for mailman id 327564; Thu, 12 May 2022 09:22:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np4s6-0000K4-MR for xen-devel@lists.xenproject.org; Thu, 12 May 2022 09:12:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a7bdae07-d1d3-11ec-a406-831a346695d4; Thu, 12 May 2022 11:12:32 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F19BA106F; Thu, 12 May 2022 02:12:31 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4D5653F73D; Thu, 12 May 2022 02:12:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7bdae07-d1d3-11ec-a406-831a346695d4 From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v3 7/8] xen/arm: create shared memory nodes in guest device tree Date: Thu, 12 May 2022 17:11:28 +0800 Message-Id: <20220512091129.2802997-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220512091129.2802997-1-Penny.Zheng@arm.com> References: <20220512091129.2802997-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. Signed-off-by: Penny Zheng --- v3 change: - move field "shm_mem" to kernel_info --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 143 +++++++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/setup.h | 1 + 3 files changed, 143 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index aa7c264e23..fb9146b6e0 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -892,7 +892,22 @@ static int __init allocate_shared_memory(struct domain *d, return ret; } -static int __init process_shm(struct domain *d, +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + u32 shm_id) +{ + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id = shm_id; + kinfo->shm_mem.nr_banks++; + + return 0; +} + +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { struct dt_device_node *shm_node; @@ -963,6 +978,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1293,6 +1316,117 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + unsigned long i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + uint8_t shm_id = mem->bank[i].shm_id; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + __be32 reg[4]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_cell(fdt, "xen,id", shm_id); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + char resvbuf[16] = "reserved-memory"; + + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3029,6 +3163,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of @@ -3367,7 +3506,7 @@ static int __init construct_domU(struct domain *d, assign_static_memory_11(d, &kinfo, node); #ifdef CONFIG_STATIC_SHM - rc = process_shm(d, node); + rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; #endif diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 874aa108a7..e089980b87 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -19,6 +19,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; + struct meminfo shm_mem; /* kernel entry point */ paddr_t entry; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 35449bd7d8..6cd45b6212 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -29,6 +29,7 @@ struct membank { bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ #ifdef CONFIG_STATIC_SHM unsigned int nr_shm_domain; + uint8_t shm_id ; /* ID identifier of a static shared memory bank. */ #endif }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu May 12 09:47:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 09:47:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327586.550402 (Exim 4.92) (envelope-from ) id 1np5PR-0008OJ-80; Thu, 12 May 2022 09:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327586.550402; Thu, 12 May 2022 09:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5PR-0008OC-52; Thu, 12 May 2022 09:47:01 +0000 Received: by outflank-mailman (input) for mailman id 327586; Thu, 12 May 2022 09:46:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5PP-0008O2-7P; Thu, 12 May 2022 09:46:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5PP-00047C-5B; Thu, 12 May 2022 09:46:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5PO-0002WU-Mm; Thu, 12 May 2022 09:46:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np5PO-0003v1-MJ; Thu, 12 May 2022 09:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vQA6jyM1u+OfP/3s1PQHQ8jL8+OLie2jSzXgFuSuhwA=; b=zBw2lSol/5PVH9+BjzVIdv/Ln8 kM/4OEy1gJbUDXdXVKUSt40obIwAfjNw7XPgjwYdVqryT8JBultmBTZ7ka+7vcIKgEyRA/bGAbhCb xqHPwfWTxVXMKQghDZNg6cddQYuEsjpzgZn1BUHPtjVuFwOS/0Ve9FLUZ+SpGc6LPGXY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170351: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 09:46:58 +0000 flight 170351 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170351/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 957 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 10:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 10:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327599.550413 (Exim 4.92) (envelope-from ) id 1np5q5-0003Eu-9h; Thu, 12 May 2022 10:14:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327599.550413; Thu, 12 May 2022 10:14:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5q5-0003En-6q; Thu, 12 May 2022 10:14:33 +0000 Received: by outflank-mailman (input) for mailman id 327599; Thu, 12 May 2022 10:14:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5q3-0003Eg-8v for xen-devel@lists.xenproject.org; Thu, 12 May 2022 10:14:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np5q3-0004er-0B; Thu, 12 May 2022 10:14:31 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1np5q2-0000r6-Py; Thu, 12 May 2022 10:14:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jJdpB9u/5hdWvX7qfd/nRwdaeX5kUREiPmuKjzzM7iM=; b=xb/40Ry/moi4YSsZoLL/U9JtN2 +9O0i8plsqWjwOiRdGmRDlYAPnTa/JcRg9dax14/dHMvNEIlMwNMdueqg0hvhYDjRWJqqGTYaVW4D VnRadJTeazD21uwvetg5rgslR0R6dMK/ufZ0pJs117CXWy3CAKcRgrJXQ8gh+zh6gCgg=; Message-ID: <47b4d6c2-3bc7-02bc-be5a-a2b782541c3c@xen.org> Date: Thu, 12 May 2022 11:14:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-5-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220512091129.2802997-5-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/05/2022 10:11, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-consuming. > > To save the loop time, this commit introduces a set of new helpers > put_page_nr() and get_page_nr() to increment/drop the page reference by nr. > > Signed-off-by: Penny Zheng > --- > v3 changes: > - check overflow with "n" > - remove spurious change > - bring back the check that we enter the loop only when count_info is > greater than 0 > --- > v2 change: > - new commit > --- > xen/arch/arm/include/asm/mm.h | 4 ++++ > xen/arch/arm/mm.c | 36 ++++++++++++++++++++++++++--------- > 2 files changed, 31 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 424aaf2823..c737d51e4d 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -347,6 +347,10 @@ void free_init_memory(void); > int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, > unsigned int order); > > +extern bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr); > +extern void put_page_nr(struct page_info *page, unsigned long nr); > + > extern void put_page_type(struct page_info *page); > static inline void put_page_and_type(struct page_info *page) > { > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7b1f2f4906..a9461e07aa 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) > return 0; > } > > -struct domain *page_get_owner_and_reference(struct page_info *page) > +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, > + unsigned long nr) > { > unsigned long x, y = page->count_info; > struct domain *owner; > @@ -1548,10 +1549,10 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > * Count == 0: Page is not allocated, so we cannot take a reference. > * Count == -1: Reference count would wrap, which is invalid. > */ > - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) > + if ( unlikely(((x + nr) & PGC_count_mask) <= 1) ) This check looks wrong to me. You want to make sure that the right equation return is at least equal to n otherwise. Furthermore, I think we need to restrict 'nr' to PGC_count_mask to fully catch any overflow. Before the loop, the code would look like: /* Restrict nr to avoid "double" overflow */ if ( nr >= PGC_count_mask ) { ASSERT_UNREACHABLE(); return NULL; } The check in the loop would look like: if ( unlikely((x + nr) & PGC_count_mask) <= n ) That said, it might be easier to read the overflow check if we do: count = x & PGC_count_mask; if ( !count || ((PGC_count_mask - count) <= n) ) I haven't measured and check which of the two options would result to better code and performance (get_page() is often called). > return NULL; > } > - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); > + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); > > owner = page_get_owner(page); > ASSERT(owner); > @@ -1559,14 +1560,20 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > return owner; > } > > -void put_page(struct page_info *page) > +struct domain *page_get_owner_and_reference(struct page_info *page) > +{ > + return page_get_owner_and_nr_reference(page, 1); > +} > + > +void put_page_nr(struct page_info *page, unsigned long nr) > { > unsigned long nx, x, y = page->count_info; > > do { > - ASSERT((y & PGC_count_mask) != 0); > + ASSERT(((y & PGC_count_mask) != 0) && > + (((y - nr) & PGC_count_mask) >= 0)); I think there are a potential underflow here if 'y' is smaller than 'nr'. But on v2, Stefano suggest to use ASSERT((y & PGC_count_mask) >= nr); which I think is sufficient here. > x = y; > - nx = x - 1; > + nx = x - nr; > } > while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); > > @@ -1576,19 +1583,30 @@ void put_page(struct page_info *page) > } > } > > -bool get_page(struct page_info *page, const struct domain *domain) > +void put_page(struct page_info *page) > { > - const struct domain *owner = page_get_owner_and_reference(page); > + put_page_nr(page, 1); > +} > + > +bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr) > +{ > + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); > > if ( likely(owner == domain) ) > return true; > > if ( owner != NULL ) > - put_page(page); > + put_page_nr(page, nr); > > return false; > } > > +bool get_page(struct page_info *page, const struct domain *domain) > +{ > + return get_page_nr(page, domain, 1); > +} > + > /* Common code requires get_page_type and put_page_type. > * We don't care about typecounts so we just do the minimum to make it > * happy. */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 12 10:29:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 10:29:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327606.550424 (Exim 4.92) (envelope-from ) id 1np64g-0004kL-Kr; Thu, 12 May 2022 10:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327606.550424; Thu, 12 May 2022 10:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np64g-0004kE-Hn; Thu, 12 May 2022 10:29:38 +0000 Received: by outflank-mailman (input) for mailman id 327606; Thu, 12 May 2022 10:29:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np64f-0004k4-OF; Thu, 12 May 2022 10:29:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np64f-0004tw-Lp; Thu, 12 May 2022 10:29:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np64f-0003RL-7X; Thu, 12 May 2022 10:29:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np64f-0006os-73; Thu, 12 May 2022 10:29:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KFVFBAkkqE2Y8udhP1EtuSbDlz/8pofH34O935ozbk8=; b=mR6ynCQXNcILANN9dktP8txH16 IV2yqIBYpnNj2wMw9Mbujgqd/za0ttHX0s1ypUfp6eXR5E27+y2FGai3i3KLncM9IjHqBWcCEW8oF VZzs+w95mcsj9CJylmvn4WizNsVDIKVnPWCOwqd/ESgofTEz+fDjF40SgMutd59KoNT4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170352: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 10:29:37 +0000 flight 170352 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170352/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 72 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 958 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 10:54:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 10:54:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327616.550435 (Exim 4.92) (envelope-from ) id 1np6SX-0007wL-KA; Thu, 12 May 2022 10:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327616.550435; Thu, 12 May 2022 10:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np6SX-0007wE-Gv; Thu, 12 May 2022 10:54:17 +0000 Received: by outflank-mailman (input) for mailman id 327616; Thu, 12 May 2022 10:54:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np6SW-0007w2-BR for xen-devel@lists.xenproject.org; Thu, 12 May 2022 10:54:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np6SW-0005Ju-3K; Thu, 12 May 2022 10:54:16 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1np6SV-0002yY-T8; Thu, 12 May 2022 10:54:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kx3kPTfdWRPEzaBDmKa7YK3Q8JqgZjy2Mdn5f4+lTTo=; b=E2TobDW/pvK+0pj2K2GmudIQrW iljcTx84WDQMzarplVR3VTLkBmas2By+nqDm9VwEWJMe2I/wp7gsTsjiYWIaBHiZ+gQTNdvaKWQFg gTLV7X/rEQgUXkq9hRaxumnvhLTkeyHaSzG6ppxoblLognA7EpWakGGZZ4VasFBzPppI=; Message-ID: <32b425e9-2430-8525-913e-6626efbec415@xen.org> Date: Thu, 12 May 2022 11:54:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-6-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220512091129.2802997-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/05/2022 10:11, Penny Zheng wrote: > @@ -827,6 +858,37 @@ static int __init allocate_shared_memory(struct domain *d, > } > } > > + /* > + * Get the right amount of references per page, which is the number of > + * borrow domains. > + */ > + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); > + if ( ret ) > + return ret; > + > + /* > + * Instead of let borrower domain get a page ref, we add as many > + * additional reference as the number of borrowers when the owner > + * is allocated, since there is a chance that owner is created > + * after borrower. > + */ > + page = mfn_to_page(smfn); Where do you check that the range [smfn, smfn + nr_pages] is actual RAM? If there are none, then you should use mfn_valid() for each mfn to ensure there will be a struct page for it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 12 11:59:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 11:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327623.550445 (Exim 4.92) (envelope-from ) id 1np7Th-0007Gi-Fz; Thu, 12 May 2022 11:59:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327623.550445; Thu, 12 May 2022 11:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np7Th-0007Gb-DH; Thu, 12 May 2022 11:59:33 +0000 Received: by outflank-mailman (input) for mailman id 327623; Thu, 12 May 2022 11:59:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np7Tf-0007GR-Lf; Thu, 12 May 2022 11:59:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np7Tf-0006Py-JF; Thu, 12 May 2022 11:59:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np7Tf-0007mJ-7f; Thu, 12 May 2022 11:59:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np7Tf-0002i1-7E; Thu, 12 May 2022 11:59:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vYPodEcr3M8eWL3WHTo2hpKX8Fb5j1DSsylQKtqUABM=; b=6DrlmJH0pfWvzkBgZcfihDC/aa oQZc6NqSAHVK4IsRJGfljzysiztkbnG8jU20heNc1Lv4ACdDd9l1/GuxsyY+TlrqlkU4O97hF/AMg 6BDtzvff3/Q7HcrUWk3DFyOkJBowErcjw6LOBEyHx/IWnvTSv7v0aGuuQdVP0Tdvfw4E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170354: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 11:59:31 +0000 flight 170354 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170354/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 959 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 12:34:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 12:34:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327635.550457 (Exim 4.92) (envelope-from ) id 1np81X-0002yc-Cv; Thu, 12 May 2022 12:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327635.550457; Thu, 12 May 2022 12:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np81X-0002yV-9o; Thu, 12 May 2022 12:34:31 +0000 Received: by outflank-mailman (input) for mailman id 327635; Thu, 12 May 2022 12:34:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np81V-0002yP-Kg for xen-devel@lists.xenproject.org; Thu, 12 May 2022 12:34:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1b::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dcd94585-d1ef-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 14:34:27 +0200 (CEST) Received: from AM7PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:20b:130::28) by AM6PR08MB4135.eurprd08.prod.outlook.com (2603:10a6:20b:a9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Thu, 12 May 2022 12:34:25 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::1c) by AM7PR03CA0018.outlook.office365.com (2603:10a6:20b:130::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14 via Frontend Transport; Thu, 12 May 2022 12:34:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 12:34:24 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Thu, 12 May 2022 12:34:24 +0000 Received: from 20e722909153.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5DFB9C95-105D-43D8-A3C5-D9BDBD27C99F.1; Thu, 12 May 2022 12:34:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 20e722909153.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 May 2022 12:34:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM4PR0802MB2354.eurprd08.prod.outlook.com (2603:10a6:200:64::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 12 May 2022 12:34:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5227.023; Thu, 12 May 2022 12:34:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcd94585-d1ef-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZO+oHt/giriSoPGBPV9OP3ab+1Is/bKiIgOuiRC6FMaTXDwNP2SenyW+3VqRB5+AV11goM3FjTaR90zEXzOzf6KQDGyXIjYO7Jd7tql45XmvuYhx/c7AirrEmnOjwJrkSkl5XMvbGnyCc26DHnTyAnMK5Rh4ZnEy9xZ+XZ31pF94T7rDdiW+LOxpEd8FBDICypXQF0fOxcPxPMcm/BcvNe9/l3EaUlV1Qplxb9rUW10/kWLy+E3DXYDHVP9iRiTQGi+IB/Km+dvhthksltdDs8X4oJiYkPKC6FlvwwBhW/pwteTiR12um2s2vBB8fJY7tuV0Pk21deodVSBvGFHQJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F2Q/38xcpv8UQaVzBlDUMVAfUbm9EH+bnJFJB7hp5TQ=; b=l7HvUIHWNmaH4oa7Zh3tn6jloNUDO5VPUQQ7leyTpMHuPTj/19Q5cRARsjCxykA1SGwdPkl0Ni1DACmbANhOgSxXEOmo+vnRkBEEzp1WWa/jivvBp53BRbXdvBc7RTLe3DCZ0QLP9yvjU05uPeg49cmR854Lxso0UrE/FC5XCFMPGN0ym61atYPXMcXQ1WO97gsNEt/nHwprMDf7IRvkW49HIxVovBVvOwhNE5GqRCfDor6r1J2hh5BUdPTrnduzEPQLZOSEnAcEqh9Ft7RPTDJCL9ez46gODfwrxvj17d+gLh0QHP9ONF/SgVzBV0pRshLnyEwtoHbsHBJcHqowTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2Q/38xcpv8UQaVzBlDUMVAfUbm9EH+bnJFJB7hp5TQ=; b=MkYFTyHBBxQuQ69Z68E1NmXpUBLHat8JQ5hvAhrUsgCUANJfNZXf5GjrNSjrxokpCRM8SCpIlwAgI8KlJoPpe/H4VB7JnlPvcUDzwsr4TQ/rUGmoweYfUGZ0qzPpN63cUWS0cNDmiahxdyrrUW/USkFR/TijDRyEpnEhM5YC5zI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 7047d2a2adeb6d72 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JXwD+lfVHWF7nHPhyMcJd+739k6umkDmNvpWhkS3ZeFmtdxFd4eN6O39TnebyB6cRotnY/Y1jI6dNuK83Eau66nzqLQuEMpeHt1Ee9HZNNtSXG8A4f8ocU6uQFLatSoulJlMsEkeQRYnJcAqW6LEYryhY9cipkq1C6IJWRu+4O1jcbyYrM9Sdkev7LylPVmyAyzE3e/S5NvIeEmflzoNsTx0006hNNY2krX01e1xvSr40/n9Nqv9iNf0RHGrRub/t4bu1aV3qO/qJFzQMQrF6j0FvFsqowbU0Hq2yFrXSl+ofrX6ZzlrvqdMsai5LdcookUKM/FBr6C/r3JlZPU/Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F2Q/38xcpv8UQaVzBlDUMVAfUbm9EH+bnJFJB7hp5TQ=; b=hD9GVjwGOo7bNw0BMMnDDCq/9WuxQhbKBB8hwLGPSgvtAPzVx6vR106HbR2uHJqKe/CuJcH3vT9GTE7d41x8pqCnCE4DDElu4Lx58FkL0jTkSE6kRlaYEnlSq2FWuZBZhL7kr6PcnjtrYkrzq9feMdrrrTiAcbpdZwXstItIjIlXHKlK/nTuE9KzzHS2/bh6BY2MZL7QPELrYHbdjA4eUuHps3bV4ho8Tk9Q0racDs6cKB3lCchXgkCD78GVbXTVHgm3/ypbc729peHTGKAjMO/H1hc1vSoQC6tT+FtXdKw6CrPKrJ6s4DfgMCnnrZvMQbgRKY4Uy6UJ4KUpZ5RUOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2Q/38xcpv8UQaVzBlDUMVAfUbm9EH+bnJFJB7hp5TQ=; b=MkYFTyHBBxQuQ69Z68E1NmXpUBLHat8JQ5hvAhrUsgCUANJfNZXf5GjrNSjrxokpCRM8SCpIlwAgI8KlJoPpe/H4VB7JnlPvcUDzwsr4TQ/rUGmoweYfUGZ0qzPpN63cUWS0cNDmiahxdyrrUW/USkFR/TijDRyEpnEhM5YC5zI= From: Bertrand Marquis To: Stefano Stabellini CC: Julien Grall , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , George Dunlap Subject: Re: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Topic: [PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Thread-Index: AQHYXtGhqgeBKorGIE+S3ZHm07cmGK0Nc+GAgADisYCAAAtXAIAAGQ0AgAAhcYCACMpfgIACZduAgAALAICAAAXAAIAAShgAgAEUEoA= Date: Thu, 12 May 2022 12:34:16 +0000 Message-ID: References: <832955382caa4ced744ec7894282592b62e8cf61.1651570561.git.bertrand.marquis@arm.com> <2E66F8B4-4DDA-47E2-B93C-E36FEB70F552@arm.com> <31F40037-3A43-4F94-8C03-D9F939DAF8C6@arm.com> <139b3f6c-ebb9-6ed2-f173-a7dbd3c94a95@xen.org> <19a140a9-f8a3-79d6-54fa-a873dab6ff42@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fd830f96-dd38-4749-b85c-08da3413bf63 x-ms-traffictypediagnostic: AM4PR0802MB2354:EE_|AM5EUR03FT009:EE_|AM6PR08MB4135:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0boLfDxxaE/8Mn7ZClofKuRYIszBoMsLKXgA2sTONb9vK0iy2mutVs5o3qOb8Lp5H3uuDZthBd6E/HxBMpJBEScY0JN5BCiWbH/cPkym1yI3k9GWW4jVLsvDrzxRdpFuP/53/YxYPbmdwx47W9F5MRx5MbGLA1/AgT/+dN1AoT4+icom8ooGxkZFzKBl8ezbYd4kPlXnxmXgr+Xqz/A1kLZOdOWc9X7x2Imuo28Uuc+NNlMILkV+apupTun5ks7aTNtpOSmZfoomeHz1KjcT0S7C2E4xOMY/GcmQ2rnV5YrgYb0K1SDpXgr/fcC0MjDj+doQywMM+eEBFe6f0/6NtV98G44/+TBJL9hleh/a6AgmvDWXSj8cxLdPsvkaDkruvgBtwRBJpHdru8Ji577bySP3v86p7Nf1AyLZuD++WQyCugqKOyZVBoLq38FDMLYWPkgjKKZFTdLi776RZn3+t4/SaP98RYpXPBbeeIEPPKjQTwtbWesuYHxAwqHf06tuSPv52S6F1sN4s+9NX4Sk3MaeMkFU3+uVYh3BBvvxkPnXWsWFTlLVumhpen4gZ10QcFdoH3cteX9BYm2iwO6XRDvs9SdrPqXSDpgYedUzUNGcT1GVMb/4j1gkBk6bhOAn5VOtS1QoGYf4lzW3S9Xmf+D1znDxHD3t0rtTmJkcxEyAaWNBDqCevyNRQCoN97tWly8+fz9zAeKNBmKGwG4u/2xOm0nYdfGYHPfmo0D/mnMJ7rU4I2NhAZMKMiEybdC7NJD3hpSjQ30IVZduGo2etxDLau4KotM98b5yqZnTG74iDDq/EJsoYT1ojEp5JGno X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(6916009)(66446008)(64756008)(66476007)(83380400001)(2616005)(76116006)(66556008)(508600001)(53546011)(33656002)(6486002)(966005)(6506007)(26005)(186003)(5660300002)(8936002)(122000001)(86362001)(38100700002)(6512007)(91956017)(2906002)(316002)(54906003)(4326008)(36756003)(8676002)(38070700005)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <51F2F2A74BCB344E99D17DC8D00F59CA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2354 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 31e31b2f-47a2-4fe8-ee7d-08da3413ba55 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CqMc7fvQnokzcr6VfzdGdbMr+J9+GYPdLP2nNW9YutUIFtQg9VWlXsGUrOBEoqD0s7hodV9TbivcRx6t8ZJTzpECT1bohr+82uzoYxA4685KU7WyNVyqCZbLkwPVYe77B1P5DsoGo/wQyBGMRuiJuDZZWQ0DTyBZl02ThqcgFRJTCapWCeZ0BRveAkiKjm4NTuSnM81PW9OcMbz30lKngvoC6Tx9020TlewCoF7Gx2OhQ2/Z2s1Db+KkhlsReridOLApvvX4O9mm7bNOfcFGtTQXvXGlqXXNUXPyv4mINd+VZ8UZaje6YGXz8WBM6rx5ZhsnN4iEAH60ubbtqSxBtY4YljMCV51Xoa7NQMHcuKsiLrwoDPPxgikEdZITwVT0caTE1uzOk7JmU84FSHb+UJT9dxkqLZZzAh+8meTG9GHn1glF2MsVBt34vXjy7nz5XUFV8gQrGrMTWdFXbqrsPECzUaePDTzDiLzckPkiCvb+KhHEIb0/dkMiAJyuUQpvZ16j2/zF4gEsOiAO2Gqhqz5sw8JT1o0vWoOv1psrjSZcLkRyo9M2Mz20h9CpddJMNT5KVebaJMFAX7E8DEyEpJkBV40td3kVNq5/mesyGsy2rBGQkgp8C6Jq0LPZCvvgQ78Uqfq2TeqLgBSra+rP5aoRmy9aqjA1F20VEwjO5U12iVlbGikLBgrV1hpANEs5OgX1J8hwmklrfuZDTTcylbWt8r+XcvidFda7XN/WFjchdMqBrsIbw9fez6KaeBAw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(83380400001)(82310400005)(53546011)(6486002)(356005)(36756003)(81166007)(8936002)(33656002)(26005)(6512007)(2616005)(8676002)(70206006)(54906003)(70586007)(6862004)(4326008)(107886003)(316002)(336012)(966005)(36860700001)(47076005)(40460700003)(508600001)(2906002)(5660300002)(186003)(6506007)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 12:34:24.5728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd830f96-dd38-4749-b85c-08da3413bf63 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4135 SGkgU3RlZmFubywNCg0KPiBPbiAxMSBNYXkgMjAyMiwgYXQgMjE6MDYsIFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBXZWQsIDExIE1h eSAyMDIyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IEkgdW5kZXJzdGFuZCB0aGUgcGF0 Y2ggaXMgYWxyZWFkeSB3cml0dGVuLCBzbyBJIHdhcyBPSyBpZiB5b3Ugc2ltcGx5IGxpc3Qgb2Yg dGhlIGNvbW1pdHMgd2l0aCB0aGUgYXV0aG9ycy90YWdzIGZvciB0aGlzIHRpbWUuDQo+PiANCj4+ IEkgd291bGQgbGlrZSB0byB1bmRlcnN0YW5kIHdoZXJlIHRoaXMgcmVxdWlyZW1lbnQgaXMgY29t aW5nIGZyb20uDQo+PiANCj4+IEBHZW9yZ2U6IGlzIHRoZXJlIHNvbWUga2luZCBvZiBsZWdhbCBy ZWFzb24gZm9yIHNvbWV0aGluZyBsaWtlIHRoYXQgPw0KPiANCj4gSSBhbSBub3QgR2VvcmdlIGJ1 dCBJJ2xsIGFuc3dlciB0aGUgbGVnYWwgcXVlc3Rpb24uIE91ciAibGVnYWwiIGRvY3VtZW50DQo+ IGlzIHRoZSBEQ086DQoNCkkgYWdyZWUgd2l0aCB5b3VyIGFuYWx5c2lzIGJ1dCBJIHN0aWxsIHRo aW5rIHRoaXMgaXMgYW4gYXJlYSB3aGVyZSB3ZSB3b3VsZA0KbmVlZCB0aGUgY29uZmlybWF0aW9u IGZyb20gR2VvcmdlLg0KDQo+IA0KPiBodHRwczovL2RldmVsb3BlcmNlcnRpZmljYXRlLm9yZy8N Cj4gDQo+IFRoaXMgZmFsbHMgdW5kZXIgY2FzZSAoYik6DQo+IA0KPiAoYikgVGhlIGNvbnRyaWJ1 dGlvbiBpcyBiYXNlZCB1cG9uIHByZXZpb3VzIHdvcmsgdGhhdCwgdG8gdGhlIGJlc3QNCj4gICAg b2YgbXkga25vd2xlZGdlLCBpcyBjb3ZlcmVkIHVuZGVyIGFuIGFwcHJvcHJpYXRlIG9wZW4gc291 cmNlDQo+ICAgIGxpY2Vuc2UgYW5kIEkgaGF2ZSB0aGUgcmlnaHQgdW5kZXIgdGhhdCBsaWNlbnNl IHRvIHN1Ym1pdCB0aGF0DQo+ICAgIHdvcmsgd2l0aCBtb2RpZmljYXRpb25zLCB3aGV0aGVyIGNy ZWF0ZWQgaW4gd2hvbGUgb3IgaW4gcGFydA0KPiAgICBieSBtZSwgdW5kZXIgdGhlIHNhbWUgb3Bl biBzb3VyY2UgbGljZW5zZSAodW5sZXNzIEkgYW0NCj4gICAgcGVybWl0dGVkIHRvIHN1Ym1pdCB1 bmRlciBhIGRpZmZlcmVudCBsaWNlbnNlKSwgYXMgaW5kaWNhdGVkDQo+ICAgIGluIHRoZSBmaWxl OyBvcg0KPiANCj4gU28gZnJvbSB0aGUgbGVnYWwgcG9pbnQgb2YgdmlldyBvbmx5IHlvdXIgU2ln bmVkLW9mZi1ieSBsaW5lIGlzDQo+IHJlcXVpcmVkLg0KPiANCj4gSSByZW1lbWJlciB0aGlzIHdl bGwgYmVjYXVzZSBJIHdhcyBjb25mdXNlZCBhYm91dCB0aGlzIGEgZmV3IHllYXJzIGFnbw0KPiBp biBhbm90aGVyIGNhc2Ugb2YgdGFraW5nIGNvZGUgZnJvbSBMaW51eC4NCj4gDQo+IA0KPj4+IElm IGJvdGggU3RlZmFubyBhbmQgeW91IGFncmVlIHRvIG5vdCBrZWVwIHRoZSBhdXRob3JzaGlwcywg dGhlbiBJIHdpbGwNCj4+PiBub3Qgc3RhbmQgYWdhaW5zdCBpdC4gSG93ZXZlciwgSSB3aWxsIG5v dCBnZXQgaW52b2x2ZWQgaW4NCj4+PiBjb21taXR0aW5nIGFuZCBhZGRpbmcgbXkgYWNrLg0KPiAN Cj4gSSBhbSBmaW5lIGVpdGhlciB3YXkuIE15IG9ubHkgcmVxdWVzdCBpcyB0byBtZW50aW9uIHRo ZSBMaW51eCBjb21taXQtaWQNCj4gdGhhdCBCZXJ0cmFuZCB1c2VkIGFzIGEgYmFzZSBhbmQgQmVy dHJhbmQgaGFzIGFscmVhZHkgZG9uZSB0aGF0Lg0KDQpPaw0KDQo+IA0KPiANCj4+IEkgd2FudCBm aXJzdCB0byBjbGVhciB1cCB0aGlzIHByb2Nlc3MgYW5kIHVuZGVyc3RhbmQgd2h5IHlvdSBhcmUN Cj4+IHJlcXVlc3RpbmcgdGhpcyB0byBrbm93IGhvdyBJIHNob3VsZCBkbyBhbnl0aGluZyBsaWtl IHRoYXQgaW4gdGhlDQo+PiBmdXR1cmUuDQo+IA0KPiBJdCBsb29rcyBsaWtlIG91ciBwcm9jZXNz IGRvY3MgYXJlIG5vdCB2ZXJ5IGdvb2Qgb24gdGhpcyBwb2ludCBhbmQgbWlnaHQNCj4gYmVuZWZp dCBmcm9tIGEgY2xhcmlmaWNhdGlvbi4gSSBob3BlIHlvdSBhcmUgdm9sdW50ZWVyaW5nIDotKQ0K PiANCj4gT3JpZ2luIGlzIGRlZmluZWQgYXMgIml0IHNwZWNpZmllcyB0aGUgc291cmNlIG9mIHRo ZSBwYXRjaCIgYnV0IGl0DQo+IGRvZXNuJ3Qgc2F5IHdoYXQgYWN0dWFsbHkgaXMgY29uc2lkZXJl ZCBhICJzb3VyY2UiLg0KPiANCj4gSSBzdWdnZXN0IHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4gdGhl IGNhc2Ugd2hlcmUgY29tbWl0cyBhcmUgcG9ydGVkDQo+IGluZGl2aWR1YWxseSBmcm9tIHRoZSBj YXNlIHdoZXJlIGNvZGUgaXMgY29waWVkIG92ZXIgKGxpa2Ugd2hlbiB3ZQ0KPiBpbnRyb2R1Y2Vk IFNNTVV2My4pIElmIGNvbW1pdHMgYXJlIGNvcGllZCBpbmRpdmlkdWFsbHksIEkgdGhpbmsgd2UN Cj4gcHJvYmFibHkgd2FudCBhbiBPcmlnaW4gdGFnIGZvciBlYWNoIG9mIHRoZW0gYW5kIHRoZSBz b3VyY2UgaXMgdGhlDQo+IG9yaWdpbmFsIGNvbW1pdC1pZC4gSWYgdGhlIGNvZGUgaXMgY29waWVk IGZyb20gTGludXggKGxpa2UgdGhlIFNNTVV2Mw0KPiBjYXNlKSB0aGVuIHdlIHByb2JhYmx5IG9u bHkgd2FudCB0byByZXF1ZXN0IGEgc2luZ2xlIE9yaWdpbiB0YWcgKG9yIGENCj4gbmV3IHRhZz8p IHdpdGggdGhlIGJhc2UgTGludXggdmVyc2lvbiAoNS4xOC1yYzMpIHJhdGhlciB0aGFuIHRoZQ0K PiBjb21taXQtaWQgYmVpbmcgYmFja3BvcnRlZC4gSW4gdGhhdCBjYXNlIHRoZSBzb3VyY2Ugd291 bGQgYmUgdGhlDQo+IHJlcG9zaXRvcnkgYmFzZWxpbmUuDQoNCkJlZm9yZSBkZWZpbmluZyBvdXIg b3duIHdheSB0byBkbyB0aGF0IG1heWJlIHdlIHNob3VsZCBjaGVjayBob3cNCm90aGVycyBhcmUg aGFuZGxpbmcgdGhvc2UgY2FzZXMgdG8gbm90IHJlaW52ZW50IHRoZSB3aGVlbC4NCg0KQW55Ym9k eSBoYXMgYSBzdWdnZXN0aW9uIG9mIGFuIG90aGVyIG9wZW4gc291cmNlIHByb2plY3Qgd2UgY291 bGQNCmNoZWNrIHdoaWNoIGNvdWxkIGhhdmUgdGhlIHNhbWUga2luZCBvZiDigJxuZWVkc+KAnSA/ DQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gU3RlZmFubw0KDQo= From xen-devel-bounces@lists.xenproject.org Thu May 12 12:47:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 12:47:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327642.550468 (Exim 4.92) (envelope-from ) id 1np8Ds-0004SW-Kn; Thu, 12 May 2022 12:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327642.550468; Thu, 12 May 2022 12:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8Ds-0004SP-Gy; Thu, 12 May 2022 12:47:16 +0000 Received: by outflank-mailman (input) for mailman id 327642; Thu, 12 May 2022 12:47:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8Dr-0004SJ-JG for xen-devel@lists.xenproject.org; Thu, 12 May 2022 12:47:15 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a59e296c-d1f1-11ec-a406-831a346695d4; Thu, 12 May 2022 14:47:14 +0200 (CEST) Received: by mail-lj1-x22e.google.com with SMTP id 4so6320609ljw.11 for ; Thu, 12 May 2022 05:47:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a59e296c-d1f1-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/tJqOE6kIQEi+zf0nBOFhftnda4KhXXFhymTqP7PX/A=; b=ANg1dHlLXiscebbTBA27YCBP3/8bvN0Q1F9smzyveliXg1jpczAA47yuuPxLLd5+/j DotORAGJaiXV45KJaPf34b6rl27ToBX6Kkfu8vwRlqwDKVxJCdhWixHoqxOXhl15gxmd Mf0TQ3nois2yjgAwYpLfDuG4BVL+Oy7Yr85Wf9/+/Xsc+wcMPuxmf122gxSCiQG5P198 FnyD8Np6AxE1j2F5DLsHizDl/gK+msOv9cIzpwFsh2NubbhOS9bGNLdBHTsFKbT08z39 Dxr70DavysPntEwZAwm5xjtMGnG5MhzaUALNG/48/73IXC9TfltqUcwUoDeU7bLvHsXR xamQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/tJqOE6kIQEi+zf0nBOFhftnda4KhXXFhymTqP7PX/A=; b=8GHPZIjEEjR8mPVa14BF4d2OYYnJx0jRUKA3uLtM/2ScC0wh2as/Ap7Wp/w6JhaU0m gzzI8v/XmEu73FhqnWYUZo8u7Q/h1PF/BC1orSzdnMd8Fk62l0EE4WFsn7/+WwlMGdap 3XndlqsbmwhgyrhXNKXZRVq06Av8iygMifpr/EM1cjco37zdrGtImYuTyCsTgkyA1mr1 7k+uXiFpHIEATK7FGq4EiX1H0DUkrQKT3EsyWFUkSCDiwtpWZu0KDSA1v7DFlS8CoNr1 Hj/LED/G8fgegtsIveSsoJBmjvl1wRvm+ZaM9ejfcHtl4d1SDpPspxrnKS7rQVv+Hzl5 C4/Q== X-Gm-Message-State: AOAM530IkGhgYR+wNy2uN2bSFwA3zGuOa2A4E7iI1XNjGcX/VM/FYErF lbhrF2rCgAW2olvy0zO+NIVR5DIrvK3lZXh2y/4PUl5100s= X-Google-Smtp-Source: ABdhPJy8qUI9Ry+PFIGC+JQOoY3GG2BXMeVTfCuRyEbnQU7FK/YO97mirOuwUu0/qyNn3ohAKQjn+0oA9HrffontGX4= X-Received: by 2002:a2e:a7cd:0:b0:24f:505f:737d with SMTP id x13-20020a2ea7cd000000b0024f505f737dmr20798135ljp.168.1652359633099; Thu, 12 May 2022 05:47:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Thu, 12 May 2022 08:47:01 -0400 Message-ID: Subject: Re: xen-blkfront crash on xl block-detach of not fully attached device To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Cc: xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 11, 2022 at 3:25 PM Marek Marczykowski-G=C3=B3recki wrote: > > Hi, > > The reproducer is trivial: > > [user@dom0 ~]$ sudo xl block-attach work backend=3Dsys-usb vdev=3Dxvdi ta= rget=3D/dev/sdz > [user@dom0 ~]$ xl block-list work > Vdev BE handle state evt-ch ring-ref BE-path > 51712 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51= 712 > 51728 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51= 728 > 51744 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51= 744 > 51760 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51= 760 > 51840 3 241 3 -1 -1 /local/domain/3/backend/vbd/241/51= 840 > ^ note state, the /dev/sdz doesn't exist in the backend > > [user@dom0 ~]$ sudo xl block-detach work xvdi > [user@dom0 ~]$ xl block-list work > Vdev BE handle state evt-ch ring-ref BE-path > work is an invalid domain identifier > > And its console has: > > BUG: kernel NULL pointer dereference, address: 0000000000000050 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 80000000edebb067 P4D 80000000edebb067 PUD edec2067 PMD 0 > Oops: 0000 [#1] PREEMPT SMP PTI > CPU: 1 PID: 52 Comm: xenwatch Not tainted 5.16.18-2.43.fc32.qubes.x86_64 = #1 > RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 > Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5= b 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0= 74 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 > RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 > RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 > RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 > R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 > R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 > FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000= 000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 > Call Trace: > > blkback_changed+0x95/0x137 [xen_blkfront] > ? read_reply+0x160/0x160 > xenwatch_thread+0xc0/0x1a0 > ? do_wait_intr_irq+0xa0/0xa0 > kthread+0x16b/0x190 > ? set_kthread_struct+0x40/0x40 > ret_from_fork+0x22/0x30 > > Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_t= imer snd soundcore ipt_REJECT nf_reject_ipv4 xt_state xt_conntrack nft_coun= ter nft_chain_nat xt_MASQUERADE nf_nat nf_conntrack nf_defrag_ipv6 nf_defra= g_ipv4 nft_compat nf_tables nfnetlink intel_rapl_msr intel_rapl_common crct= 10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel xen_netfront pcs= pkr xen_scsiback target_core_mod xen_netback xen_privcmd xen_gntdev xen_gnt= alloc xen_blkback xen_evtchn ipmi_devintf ipmi_msghandler fuse bpf_preload = ip_tables overlay xen_blkfront > CR2: 0000000000000050 > ---[ end trace 7bc9597fd06ae89d ]--- > RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 > Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5= b 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0= 74 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 > RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 > RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 > RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 > R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 > R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 > FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000= 000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 > Kernel panic - not syncing: Fatal exception > Kernel Offset: disabled This looks like it may be blkfront_closing() calling blk_mq_stop_hw_queues() with info->rq =3D=3D NULL. info->rq is only assigned in blkfront_connect(), which is called for state 4, but your vbd never made it through there. It seems like blkfront_closing() should NULL check info->rq and info->gd before using them. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu May 12 13:07:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327649.550479 (Exim 4.92) (envelope-from ) id 1np8XM-0006r1-8X; Thu, 12 May 2022 13:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327649.550479; Thu, 12 May 2022 13:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8XM-0006qu-4m; Thu, 12 May 2022 13:07:24 +0000 Received: by outflank-mailman (input) for mailman id 327649; Thu, 12 May 2022 13:07:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8XL-0006qk-H8; Thu, 12 May 2022 13:07:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8XL-0007jR-FK; Thu, 12 May 2022 13:07:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8XL-0003Ye-39; Thu, 12 May 2022 13:07:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np8XL-0003fu-2g; Thu, 12 May 2022 13:07:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SqNjUSm+jdmn7ENGrM7MAlnVZVBu8A6aWx6J+NrF/LQ=; b=uTdjscQxFOtQAf8rI3IBpUW15b 94tGDIx9CaadztL6iOPFhEKihX0J1PUBrBeZpA7830r/Zo7wZsrdZOWcleO0/072mUduklVixzEzJ ISlDKKWRzdAWj5uTzWAb7NWJzc/d0PijoiZs4YZBLaljYzEpvD5OOpWX4DPXjmtsQHqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170355: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 13:07:23 +0000 flight 170355 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170355/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 960 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 13:36:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:36:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327659.550490 (Exim 4.92) (envelope-from ) id 1np8z7-0001hD-OD; Thu, 12 May 2022 13:36:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327659.550490; Thu, 12 May 2022 13:36:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8z7-0001h6-JI; Thu, 12 May 2022 13:36:05 +0000 Received: by outflank-mailman (input) for mailman id 327659; Thu, 12 May 2022 13:36:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8z5-0001gw-T5; Thu, 12 May 2022 13:36:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8z5-0008E2-RE; Thu, 12 May 2022 13:36:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np8z5-0005RT-G0; Thu, 12 May 2022 13:36:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np8z5-00011g-FX; Thu, 12 May 2022 13:36:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WwqueRnwJ4BIvyTeyKhX4l32Px+E192OUmFxoyaI10w=; b=dD/YzjB+rGCfcZOM7es9iyveaR NkUB2HCuKNpcSfE1Sh80h9d7rvOzEqVMlcb6yz6JDDbVltvBU1GPj3Tmr0tzlH0V2lvlgvVStbqE8 hY5q8T8fk9OxoeaAmYV/6Hn3HAImzMJGjPsExaw4uqfwgNfRmrAeGkWlkZMubmEYB+0E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170356: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 13:36:03 +0000 flight 170356 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170356/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 961 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 13:46:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:46:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327668.550500 (Exim 4.92) (envelope-from ) id 1np99U-0003BD-O6; Thu, 12 May 2022 13:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327668.550500; Thu, 12 May 2022 13:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np99U-0003B6-LR; Thu, 12 May 2022 13:46:48 +0000 Received: by outflank-mailman (input) for mailman id 327668; Thu, 12 May 2022 13:46:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np99T-0003B0-2Y for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:46:47 +0000 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [2001:4860:4864:20::34]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efc8706c-d1f9-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:46:35 +0200 (CEST) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-e2fa360f6dso6700675fac.2 for ; Thu, 12 May 2022 06:46:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc8706c-d1f9-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BObhUF4sbYVjHtDgr3XjfW9tIycHPCdCa3lUWOjiOh0=; b=kUUwf7kcHwy7WxPQ9OAADFyUnw9uI4EOnQjhxy7fpgGxzHTu/9oaWDopuyvEfLw+Mr ZqX8DcBXZ4tVx2nx18Y3ynAa/VysUodxlTow1TeckKVycZEBlTru4eCn4U0apRq2x9Ck 3NdRSjtWkzt6HbUqbtcQ28tUG5q0T6J06D+2IAb+qRMzMBrFPpSHpIr7kdCoOd1mmRA9 Fq2tSJEuN1PgWR92uOSdpDtZcsNZzUhoajVOslZSR0bkYf2qefgo2cHmdsAO40/hXOkV CeN6AsQAVuYcLJg3GQ7GfNE79kmSDJ7uKAE+rLvEDMC+kmJ2vUlXuszYyCFYZG5BXjX5 xEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BObhUF4sbYVjHtDgr3XjfW9tIycHPCdCa3lUWOjiOh0=; b=wHVLbQnI03OVLSzDgoYy0qBKy1S5/Afgkomkw7K5M5/ufiXSDl43iR37Uikerx0OIR GwikFzFhOSC001tU1i5t6APMX3x/may6YMIgIElTEXykaGT+7/FDuaJmXdPfanzzRyrm LKT8UYAavXTJAM8s/+8jLtfu5g+3eFD1A8zgeypTiOhRj1AzY87HKh4uWgxim5yESp8H Wg3prMMWLwwCn/hB6onUub7sfwneYGj7NVsgx9fRes4qu4HXa6UoJ7yw8jRXyeedLQTr WRqis4JsRwWfy2iDYfnatTxilrNu5Xk08gUSCTOMq+/w9sNV9M0zKrlh8yaUYl/7hU/9 eSVg== X-Gm-Message-State: AOAM532EEdnTbJHhnbL5xxDFuF5kqCxm+Qw2YCOmZTNT6nGL9FRTaQzL 9PFsmOmW/gL46tsuJv5UMK2jb6+b/6cMBPy+VRA= X-Google-Smtp-Source: ABdhPJztdCMCW3M77X0avIJWbQl1kLpCJUVxLMFXsmka+4WbPCyd3agKAYCwi7dTYvpcnDA6MLCOQjARa69YsU1tOD4= X-Received: by 2002:a05:6870:ea8d:b0:e6:135c:1a2e with SMTP id s13-20020a056870ea8d00b000e6135c1a2emr5484345oap.9.1652363204700; Thu, 12 May 2022 06:46:44 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Thu, 12 May 2022 09:46:09 -0400 Message-ID: Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Tamas K Lengyel , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 5, 2022 at 4:27 AM Roger Pau Monn=C3=A9 = wrote: > > On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: > > Need to separately specify if the reset is for the memory or for the VM= state, > > or both. > > > > Signed-off-by: Tamas K Lengyel > > Reviewed-by: Roger Pau Monn=C3=A9 Patch ping. Can this patch be merged please? Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Thu May 12 13:47:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327674.550512 (Exim 4.92) (envelope-from ) id 1np9AP-0003ib-1k; Thu, 12 May 2022 13:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327674.550512; Thu, 12 May 2022 13:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9AO-0003iU-V0; Thu, 12 May 2022 13:47:44 +0000 Received: by outflank-mailman (input) for mailman id 327674; Thu, 12 May 2022 13:47:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9AN-0003B0-8O for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:47:43 +0000 Received: from MTA-06-4.privateemail.com (mta-06-4.privateemail.com [198.54.122.146]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1076fb6d-d1fa-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:47:30 +0200 (CEST) Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 653CA1802967 for ; Thu, 12 May 2022 09:47:39 -0400 (EDT) Received: from mail-ot1-f47.google.com (unknown [10.20.151.147]) by mta-06.privateemail.com (Postfix) with ESMTPA id 3F365180295E for ; Thu, 12 May 2022 09:47:39 -0400 (EDT) Received: by mail-ot1-f47.google.com with SMTP id l9-20020a056830268900b006054381dd35so2715577otu.4 for ; Thu, 12 May 2022 06:47:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1076fb6d-d1fa-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1652363259; bh=rFDMYj2IlgGvJB/lwHo5lL4pB5ukzaALgOMe2/BY1nk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=x0TRRWzn8RHNrB6qesOY5mewb5Pp7cuLKw5Ik/s+FzbLImM1qEc0zrAr2m//gPq3X 4ZrUlnAIwoar1GHe6JHqVwROmA/tT5pgJGeXFBR5GACgtNHBpQYfO3OKVCmljc+lnc SbeN7HBoQt0z16ApOzDyu0dEiWt+a2ZZLZNAfBIzHyBhYS85QeikS5taqUIdEMyt+m HMojWg70x8JyO0rz2aKt4mP6/t/ed7EJgQicfSutyjg/eZY5b4GYQasgRQZsHQrvKm HlqOBt9bDYuDhFa5KFmEnTXlVFzogq/8ZcmVvoSQoV1+W3IsxiAPNvm15QmGqEt7vA /xeUq/Voiq2Rg== X-Gm-Message-State: AOAM532oyjxy7HW7z2fmfm+F2KgdOtrWZxAWISNCx9wdg9yFFpfPPtDj od/Z0PFb7HbHfaPIslLJDoGUD+WSUECo9jnTK5E= X-Google-Smtp-Source: ABdhPJwHpMCXstenmKKxWh6QuaYeIhHDwRMUI/7MYtEQPt8Lxt49dlSygTbIGUYLWA9g2aa4LPqUQVHNO454OQGn+/Q= X-Received: by 2002:a05:6830:1e86:b0:606:48b8:252c with SMTP id n6-20020a0568301e8600b0060648b8252cmr7603otr.204.1652363258562; Thu, 12 May 2022 06:47:38 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Thu, 12 May 2022 09:47:03 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits To: Tamas K Lengyel Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Alexandru Isaila , Petre Pircalabu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jun Nakajima , Kevin Tian Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 4, 2022 at 9:12 AM Tamas K Lengyel wrote: > > On Wed, Apr 27, 2022 at 11:51 AM Tamas K Lengyel > wrote: > > > > Add monitor event that hooks the vmexit handler allowing for both sync and > > async monitoring of events. With async monitoring an event is placed on the > > monitor ring for each exit and the rest of the vmexit handler resumes normally. > > If there are additional monitor events configured those will also place their > > respective events on the monitor ring. > > > > With the sync version an event is placed on the monitor ring but the handler > > does not get resumed, thus the sync version is only useful when the VM is not > > expected to resume normally after the vmexit. Our use-case is primarily with > > the sync version with VM forks where the fork gets reset after sync vmexit > > event, thus the rest of the vmexit handler can be safely skipped. This is > > very useful when we want to avoid Xen crashing the VM under any circumstance, > > for example during fuzzing. Collecting all vmexit information regardless of > > the root cause makes it easier to reason about the state of the VM on the > > monitor side, hence we opt to receive all events, even for external interrupt > > and NMI exits and let the monitor agent decide how to proceed. > > > > Signed-off-by: Tamas K Lengyel > > --- > > v5: wrap vmexit fields in arch.vmx structures in the public vm_event ABI > > Patch ping. Could a toolstack maintainer please take a look at this? > The hypervisor side already has a Reviewed-by. Patch ping. Tamas From xen-devel-bounces@lists.xenproject.org Thu May 12 13:58:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327683.550528 (Exim 4.92) (envelope-from ) id 1np9KV-0005Hb-Bu; Thu, 12 May 2022 13:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327683.550528; Thu, 12 May 2022 13:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KV-0005Gj-6p; Thu, 12 May 2022 13:58:11 +0000 Received: by outflank-mailman (input) for mailman id 327683; Thu, 12 May 2022 13:58:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KU-0005De-5V for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:58:10 +0000 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86e4e187-d1fb-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:57:57 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-pdx-2c-d9fba5dd.us-west-2.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 12 May 2022 13:57:52 +0000 Received: from EX13D08EUC001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2c-d9fba5dd.us-west-2.amazon.com (Postfix) with ESMTPS id 5307941DA5; Thu, 12 May 2022 13:57:50 +0000 (UTC) Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D08EUC001.ant.amazon.com (10.43.164.184) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 12 May 2022 13:57:48 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Thu, 12 May 2022 13:57:48 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 01C5341131; Thu, 12 May 2022 13:57:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 86e4e187-d1fb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652363889; x=1683899889; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TwU6CtF1V9/2Y57AY/B4As4rfmtIlL8LhHI2uYJkLIs=; b=hU1FQ2GESOUzT3kx9A0eSnDbmLrgdyNRIv2iYOGL90OR9SsSDPe/xajw Dslzd8Oj4ElADdqlKZFoY4WR0mRbRycA+lBvOQ4F9PWbx9QbYp3GKf08V 9U/ZDIVd7MzkFI6pcADarLQo8fLCjeq7Vsqb8xc6VvVMrTs3hAUscu8XV A=; X-IronPort-AV: E=Sophos;i="5.91,220,1647302400"; d="scan'208";a="201008279" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 1/4] x86/asm: Allow to pass macros to __ASM_FORM() Date: Thu, 12 May 2022 13:56:48 +0000 Message-ID: <20220512135654.119791-2-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220512135654.119791-1-mheyne@amazon.de> References: <20220512135654.119791-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit f7919fd943abf0c77aed4441ea9897a323d132f5 upstream Use __stringify() at __ASM_FORM() so that user can pass code including macros to __ASM_FORM(). Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/asm.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h index 3ff577c0b102..1b563f9167ea 100644 --- a/arch/x86/include/asm/asm.h +++ b/arch/x86/include/asm/asm.h @@ -7,9 +7,11 @@ # define __ASM_FORM_RAW(x) x # define __ASM_FORM_COMMA(x) x, #else -# define __ASM_FORM(x) " " #x " " -# define __ASM_FORM_RAW(x) #x -# define __ASM_FORM_COMMA(x) " " #x "," +#include + +# define __ASM_FORM(x) " " __stringify(x) " " +# define __ASM_FORM_RAW(x) __stringify(x) +# define __ASM_FORM_COMMA(x) " " __stringify(x) "," #endif #ifndef __x86_64__ -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Thu May 12 13:58:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327682.550523 (Exim 4.92) (envelope-from ) id 1np9KV-0005E5-2E; Thu, 12 May 2022 13:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327682.550523; Thu, 12 May 2022 13:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KU-0005Dy-UA; Thu, 12 May 2022 13:58:10 +0000 Received: by outflank-mailman (input) for mailman id 327682; Thu, 12 May 2022 13:58:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KS-0005De-S8 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:58:09 +0000 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85d179ce-d1fb-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:57:56 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-a31e1d63.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 12 May 2022 13:58:05 +0000 Received: from EX13D08EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-a31e1d63.us-east-1.amazon.com (Postfix) with ESMTPS id 446238942B; Thu, 12 May 2022 13:57:56 +0000 (UTC) Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D08EUB003.ant.amazon.com (10.43.166.117) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 12 May 2022 13:57:55 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Thu, 12 May 2022 13:57:54 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 250F041131; Thu, 12 May 2022 13:57:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 85d179ce-d1fb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652363888; x=1683899888; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/jlcjyqHJJuyQxaME83nVeMauiezhLHJNpjQ1y9lQkI=; b=TF2AGPnjU42jW8xOvYkUvfg3yk3oIW2ZdCGknCJ3yl2Ny0gbMh9R+hAp +7Lew7qFbm6JxQvlq9MmClFcB7N5ssQcvvFCWCxn0TCdlAS7CD1qQy3hD r5sgOnhfIn4SZA9C1RRzA0AP9NPoJC7I1L3EHXOhnhhSBwq975cg17ihx M=; X-IronPort-AV: E=Sophos;i="5.91,220,1647302400"; d="scan'208";a="201008348" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Ingo Molnar , Boris Ostrovsky , Andrew Cooper , Stefano Stabellini , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 2/4] x86: xen: kvm: Gather the definition of emulate prefixes Date: Thu, 12 May 2022 13:56:49 +0000 Message-ID: <20220512135654.119791-3-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220512135654.119791-1-mheyne@amazon.de> References: <20220512135654.119791-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 upstream Gather the emulate prefixes, which forcibly make the following instruction emulated on virtualization, in one place. Suggested-by: Peter Zijlstra Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Ingo Molnar Cc: Boris Ostrovsky Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777563917.25081.7286628561790289995.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/emulate_prefix.h | 14 ++++++++++++++ arch/x86/include/asm/xen/interface.h | 11 ++++------- arch/x86/kvm/x86.c | 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h diff --git a/arch/x86/include/asm/emulate_prefix.h b/arch/x86/include/asm/emulate_prefix.h new file mode 100644 index 000000000000..70f5b98a5286 --- /dev/null +++ b/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif diff --git a/arch/x86/include/asm/xen/interface.h b/arch/x86/include/asm/xen/interface.h index 62ca03ef5c65..9139b3e86316 100644 --- a/arch/x86/include/asm/xen/interface.h +++ b/arch/x86/include/asm/xen/interface.h @@ -379,12 +379,9 @@ struct xen_pmu_arch { * Prefix forces emulation of some non-trapping instructions. * Currently only CPUID. */ -#ifdef __ASSEMBLY__ -#define XEN_EMULATE_PREFIX .byte 0x0f,0x0b,0x78,0x65,0x6e ; -#define XEN_CPUID XEN_EMULATE_PREFIX cpuid -#else -#define XEN_EMULATE_PREFIX ".byte 0x0f,0x0b,0x78,0x65,0x6e ; " -#define XEN_CPUID XEN_EMULATE_PREFIX "cpuid" -#endif +#include + +#define XEN_EMULATE_PREFIX __ASM_FORM(.byte __XEN_EMULATE_PREFIX ;) +#define XEN_CPUID XEN_EMULATE_PREFIX __ASM_FORM(cpuid) #endif /* _ASM_X86_XEN_INTERFACE_H */ diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1f7dfa5aa42d..6dd77e426889 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #define CREATE_TRACE_POINTS @@ -5583,6 +5584,7 @@ EXPORT_SYMBOL_GPL(kvm_write_guest_virt_system); int handle_ud(struct kvm_vcpu *vcpu) { + static const char kvm_emulate_prefix[] = { __KVM_EMULATE_PREFIX }; int emul_type = EMULTYPE_TRAP_UD; char sig[5]; /* ud2; .ascii "kvm" */ struct x86_exception e; @@ -5590,7 +5592,7 @@ int handle_ud(struct kvm_vcpu *vcpu) if (force_emulation_prefix && kvm_read_guest_virt(vcpu, kvm_get_linear_rip(vcpu), sig, sizeof(sig), &e) == 0 && - memcmp(sig, "\xf\xbkvm", sizeof(sig)) == 0) { + memcmp(sig, kvm_emulate_prefix, sizeof(sig)) == 0) { kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(sig)); emul_type = EMULTYPE_TRAP_UD_FORCED; } -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Thu May 12 13:58:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327684.550535 (Exim 4.92) (envelope-from ) id 1np9KV-0005NQ-Pd; Thu, 12 May 2022 13:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327684.550535; Thu, 12 May 2022 13:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KV-0005MP-Ie; Thu, 12 May 2022 13:58:11 +0000 Received: by outflank-mailman (input) for mailman id 327684; Thu, 12 May 2022 13:58:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9KU-0005Dn-Gp for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:58:10 +0000 Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8bf77f1a-d1fb-11ec-a406-831a346695d4; Thu, 12 May 2022 15:58:07 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP; 12 May 2022 13:57:47 +0000 Received: from EX13D08EUC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com (Postfix) with ESMTPS id A107B41E0F; Thu, 12 May 2022 13:57:40 +0000 (UTC) Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D08EUC002.ant.amazon.com (10.43.164.124) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 12 May 2022 13:57:38 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Thu, 12 May 2022 13:57:37 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id 102D441131; Thu, 12 May 2022 13:57:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 8bf77f1a-d1fb-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652363887; x=1683899887; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ZcFtI8jvSLQdq7u3zXtig0/LPNcCJ80T1zsBtiZt0Y0=; b=Giqxwa994vrnt/1i9bqP2tgMvznLTVaX0sVNaUpj0yiAKXykv1Attmms fGY6YKGRu0smYG4Bi9oBCX1zBe1fQjRI3sNxKJxmjjkXq+aOne9/Q1R2y YMYd279pXKnaAhzoWdouUv5t1lpVb77WcpVHLLF54bFDJO0jyd5nGhQyZ E=; X-IronPort-AV: E=Sophos;i="5.91,220,1647302400"; d="scan'208";a="1015112248" From: Maximilian Heyne To: CC: Maximilian Heyne , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Josh Poimboeuf , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Masami Hiramatsu , Sasha Levin , , , Subject: [PATCH 0/4] x86: decode Xen/KVM emulate prefixes Date: Thu, 12 May 2022 13:56:47 +0000 Message-ID: <20220512135654.119791-1-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This is a backport of a patch series for 5.4.x. The patch series allows the x86 decoder to decode the Xen and KVM emulate prefixes. In particular this solves the following issue that appeared when commit db6c6a0df840 ("objtool: Fix noreturn detection for ignored functions") was backported to 5.4.69: arch/x86/xen/enlighten_pv.o: warning: objtool: xen_cpuid()+0x25: can't find jump dest instruction at .text+0x9c Also now that this decoding is possible, also backport the commit which prevents kprobes on probing such prefixed instructions. This was also part of the original series. The series applied mostly cleanly on 5.4.192 except for a contextual problem in the 3rd patch ("x86: xen: insn: Decode Xen and KVM emulate-prefix signature"). Masami Hiramatsu (4): x86/asm: Allow to pass macros to __ASM_FORM() x86: xen: kvm: Gather the definition of emulate prefixes x86: xen: insn: Decode Xen and KVM emulate-prefix signature x86: kprobes: Prohibit probing on instruction which has emulate prefix arch/x86/include/asm/asm.h | 8 +++-- arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ arch/x86/include/asm/insn.h | 6 ++++ arch/x86/include/asm/xen/interface.h | 11 +++---- arch/x86/kernel/kprobes/core.c | 4 +++ arch/x86/kvm/x86.c | 4 ++- arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 12 files changed, 128 insertions(+), 13 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h base-commit: 1d72b776f6dc973211f5d153453cf8955fb3d70a -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Thu May 12 13:58:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327695.550556 (Exim 4.92) (envelope-from ) id 1np9Kr-0006ZW-73; Thu, 12 May 2022 13:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327695.550556; Thu, 12 May 2022 13:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9Kr-0006ZP-3Z; Thu, 12 May 2022 13:58:33 +0000 Received: by outflank-mailman (input) for mailman id 327695; Thu, 12 May 2022 13:58:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9Kq-0005De-67 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:58:32 +0000 Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94166ddc-d1fb-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:58:20 +0200 (CEST) Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 12 May 2022 13:58:15 +0000 Received: from EX13D08EUC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com (Postfix) with ESMTPS id BF6FC41E0E; Thu, 12 May 2022 13:58:06 +0000 (UTC) Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D08EUC002.ant.amazon.com (10.43.164.124) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 12 May 2022 13:58:04 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Thu, 12 May 2022 13:58:04 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id E90A841131; Thu, 12 May 2022 13:58:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 94166ddc-d1fb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652363911; x=1683899911; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fXdsCza0w8qNDoFrKMYkMnUAwI+hskYjRxqBpTNbyyY=; b=T1LDzVLXLuacWaHxogaYGICrW1r2tquL/p/GrpOGRpHF89nGsI+Sg7fm RLytGpFR1FKfC2gxRe4WJLjMThdpnhQ1uLcN5Iu6p4aiN4h829IHUvpE7 PH7pkWUdw3729vE+kW8/XTp5VMDT3UDuQXOcl/9I82iXLS6cZJL0OjTu4 s=; X-IronPort-AV: E=Sophos;i="5.91,220,1647302400"; d="scan'208";a="202425735" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Josh Poimboeuf , Maximilian Heyne , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 4/4] x86: kprobes: Prohibit probing on instruction which has emulate prefix Date: Thu, 12 May 2022 13:56:51 +0000 Message-ID: <20220512135654.119791-5-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220512135654.119791-1-mheyne@amazon.de> References: <20220512135654.119791-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit 004e8dce9c5595697951f7cd0e9f66b35c92265e upstream Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/kernel/kprobes/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index c205d77d57da..3700dc94847c 100644 --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -358,6 +358,10 @@ int __copy_instruction(u8 *dest, u8 *src, u8 *real, struct insn *insn) kernel_insn_init(insn, dest, MAX_INSN_SIZE); insn_get_length(insn); + /* We can not probe force emulate prefixed instruction */ + if (insn_has_emulate_prefix(insn)) + return 0; + /* Another subsystem puts a breakpoint, failed to recover */ if (insn->opcode.bytes[0] == BREAKPOINT_INSTRUCTION) return 0; -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Thu May 12 13:58:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:58:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327696.550567 (Exim 4.92) (envelope-from ) id 1np9Ks-0006tL-Go; Thu, 12 May 2022 13:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327696.550567; Thu, 12 May 2022 13:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9Ks-0006sI-DD; Thu, 12 May 2022 13:58:34 +0000 Received: by outflank-mailman (input) for mailman id 327696; Thu, 12 May 2022 13:58:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9Kr-0005De-JA for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:58:33 +0000 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9455707d-d1fb-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:58:21 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP; 12 May 2022 13:58:10 +0000 Received: from EX13D08EUB002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-10222bbc.us-east-1.amazon.com (Postfix) with ESMTPS id 217C31A0AE3; Thu, 12 May 2022 13:58:01 +0000 (UTC) Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D08EUB002.ant.amazon.com (10.43.166.232) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 12 May 2022 13:58:00 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Thu, 12 May 2022 13:57:59 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id DDC9E41131; Thu, 12 May 2022 13:57:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 9455707d-d1fb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652363912; x=1683899912; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LcBCa7IjI6XtJDgdMuUyaVbxzp9zN8ViQS6A7OjaIjg=; b=cNap//AbOCjugIHYvG0sNGY8uL5V0o8/HhrlIUqfSHih0BVuc0i4v6it 7AvUuHIqd70PfmmbNBcLMmk4jHWP7W/zsGVzgGq40Vm0C1o/cfNLcMCu2 NPClaMaoi+3ykvvxXocrEOGZXDCfCJBYeh5i+xj54hjhdoa1FHDlsNWHo U=; X-IronPort-AV: E=Sophos;i="5.91,220,1647302400"; d="scan'208";a="218537903" From: Maximilian Heyne To: CC: Masami Hiramatsu , Peter Zijlstra , Josh Poimboeuf , Juergen Gross , , Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , , Randy Dunlap , Maximilian Heyne , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Sasha Levin , , Subject: [PATCH 3/4] x86: xen: insn: Decode Xen and KVM emulate-prefix signature Date: Thu, 12 May 2022 13:56:50 +0000 Message-ID: <20220512135654.119791-4-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220512135654.119791-1-mheyne@amazon.de> References: <20220512135654.119791-1-mheyne@amazon.de> MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Masami Hiramatsu commit 4d65adfcd1196818659d3bd9b42dccab291e1751 upstream Decode Xen and KVM's emulate-prefix signature by x86 insn decoder. It is called "prefix" but actually not x86 instruction prefix, so this adds insn.emulate_prefix_size field instead of reusing insn.prefixes. If x86 decoder finds a special sequence of instructions of XEN_EMULATE_PREFIX and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Acked-by: Josh Poimboeuf Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Cc: stable@vger.kernel.org # 5.4.x --- arch/x86/include/asm/insn.h | 6 ++++ arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 +++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 7 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h diff --git a/arch/x86/include/asm/insn.h b/arch/x86/include/asm/insn.h index a51ffeea6d87..a8c3d284fa46 100644 --- a/arch/x86/include/asm/insn.h +++ b/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct insn *insn) return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c index 0b5862ba6a75..404279563891 100644 --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include #include +#include + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64) insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn) if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); diff --git a/tools/arch/x86/include/asm/emulate_prefix.h b/tools/arch/x86/include/asm/emulate_prefix.h new file mode 100644 index 000000000000..70f5b98a5286 --- /dev/null +++ b/tools/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif diff --git a/tools/arch/x86/include/asm/insn.h b/tools/arch/x86/include/asm/insn.h index d7f0ae8f3c44..52c6262e6bfd 100644 --- a/tools/arch/x86/include/asm/insn.h +++ b/tools/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct insn *insn) return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c index 79e048f1d902..0151dfc6da61 100644 --- a/tools/arch/x86/lib/insn.c +++ b/tools/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include "../include/asm/inat.h" #include "../include/asm/insn.h" +#include "../include/asm/emulate_prefix.h" + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const void *kaddr, int buf_len, int x86_64) insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn) if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh index c3ae1e8ae119..2a1261bfbb62 100755 --- a/tools/objtool/sync-check.sh +++ b/tools/objtool/sync-check.sh @@ -4,6 +4,7 @@ FILES=' arch/x86/include/asm/inat_types.h arch/x86/include/asm/orc_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk ' @@ -46,4 +47,4 @@ done check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh index cea13cb987d0..499235a41162 100755 --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -28,6 +28,7 @@ arch/x86/include/asm/disabled-features.h arch/x86/include/asm/required-features.h arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/inat_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/include/uapi/asm/prctl.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk @@ -116,7 +117,7 @@ check lib/ctype.c '-I "^EXPORT_SYMBOL" -I "^#include " -B check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' # diff non-symmetric files check_2 tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Thu May 12 13:59:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 13:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327701.550578 (Exim 4.92) (envelope-from ) id 1np9MB-000867-QS; Thu, 12 May 2022 13:59:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327701.550578; Thu, 12 May 2022 13:59:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9MB-000860-Nh; Thu, 12 May 2022 13:59:55 +0000 Received: by outflank-mailman (input) for mailman id 327701; Thu, 12 May 2022 13:59:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9MA-00085h-FU for xen-devel@lists.xenproject.org; Thu, 12 May 2022 13:59:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3f05b78-d1fb-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 15:59:41 +0200 (CEST) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 May 2022 09:59:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL0PR03MB4097.namprd03.prod.outlook.com (2603:10b6:208:60::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Thu, 12 May 2022 13:59:46 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Thu, 12 May 2022 13:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3f05b78-d1fb-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652363992; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=o41mNaevaTxntnew+xI0OYxY9uRdpnNkt/vJLRIP5Q4=; b=IIVGXBJeQ0zHOUUuASYsMvmv13dxMZDoyuGw3bXV94F2AFqrhNw77iTN X8F2Le9+yJrZa/wOpZL5Tdl3xZ5+ZoJlgSg93x+xYOGQCQBGy19mbmZEV r89vWPey8Wtw79zwvqfyb/nR/XalHOYyR0CYFKG11kqi5xfF4yl/c9BVC 8=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 71036781 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:r02z2ajBZdmSlP4wCsU95zd9X161YhEKZh0ujC45NGQN5FlHY01je htvXGCEOq7cYjPwfd5zbd7j/U1QvZDdzdNlTwZprSxkFC4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrX4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTsGAqzdoeQBaAF/Dn5SN7155L/VI3fq5KR/z2WeG5ft69NHKRhueKc+paNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuocehW9o7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvN/vRoszG7IApZ3KrdKevvWYCzStR8l2S9h XOfz0brK0RPXDCY4X/fmp62vcfNlCX3QpMPF5W38/drhBuYwWl7IBgfT16yu/S6ok+4RdNEK kYQ9zYurK4970iiRJ/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6cLqScC0 1aIm5bjA2NpubjMEXaFrO7M9XW1JDQfKnIEaWkcVwwZ7tL/oYY1yBXSUtJkF63zhdrwcd3t/ w23QOEFr+17paY2O2+TpzgrXxrESkD1czMI IronPort-HdrOrdr: A9a23:+IgSCK48nUbP7MzXRgPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,220,1647316800"; d="scan'208";a="71036781" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wej1ryreZ6YrlH2+y+pjEcq5vhMETZo8BQ/YxJz3xPTMlpU/62GusYE5pNsMztUH+0IDV/m5nzVShgC/ClvRhkspoSyMe+Wn7Z+anZezPDZjzTPoHXXvMBKE4wkkECm5SpM+FxhsifRCnWiu7rBXatai2UMHMfm3gQkJ1Sh1xqGSgrqpuCYPdAQpiHVuCkS9l+PFAO2WVzsPKyxYKANA9+ITkM5XZSK88Wl39aEboxEKPj3brFEDryhJZkL0IyFNysu7NuB1pXvrv2AAAYv8SBUA9qJ7QirJjsE2oTHjBg7ZqYeIUXMlaMy2E0xLIXGtDWjzr/EVANe3M+yVCB3+6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iUVnq91lsYz9R+1UWwnN5ZQ+HeoMQMcVuT0iWoZwXNQ=; b=oV0YNhB8AOFT89Cc3TPwqXb+pFNEgt2kJTD2DSaMfnIC5nlO8HjSqL/V3Cd8W+WY4aJDw9yaKA9ZtO/4krvSOEE0WF+BS1jI8YB4+MMSJxyLV0EjSBvmqZhOf8uGlUaXImBfRCRdu8/vMcDKfVBPJHYc6Q7VLKq/LBOvK9gTs5YETW/OSeLEqZIDFEloWrCpuqyp4ujnDWAXx1aSdwjDNx/RYAm8AqBgguqGwjYpJg/cKm8jiaHhjViB/O7M5uCCBvf7V4tPo+f7q/HJ4SIO7RD6539dC41wO76baqxffUFlYRNr+/6bmbTGbjFqonie7/CYvvMLi/8cK9CGz1YY0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUVnq91lsYz9R+1UWwnN5ZQ+HeoMQMcVuT0iWoZwXNQ=; b=QyxCeCThrkaMYuYumCgoTWKYepqrpDNxe6MO4sQ6pp6n5AayEG6pZfeVLutGqV5v4cjP0L1q6SQjOYSLRzO3xD1dDM3EheCu9i4mM5zI09/KrBPHBTyx6gKnsEoboEYn9NC2MTf5Cr92He67lA4i8bQL7DseZ2k/NJ7nR6Gg/wU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 12 May 2022 15:59:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jason Andryuk Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel Subject: Re: xen-blkfront crash on xl block-detach of not fully attached device Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0089.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e8045dd-e166-4f03-0a2e-08da341fac49 X-MS-TrafficTypeDiagnostic: BL0PR03MB4097:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ISMlseaaoz8LkON1ePC7N+IA82Kz199JbwN2aVkBPAX9nTFiCtidWiz5w8s3oAuwC4JBMyMeBjYZ5Xe7TCvWRol5feLdqgjqtQto/y1JwERuih6v6g2ttQNbwSqzwsMZ9VUcF3fz+zn9cWCbrhsbwr+KNsuKnsmZp/5OpQdfmwHoQSlPZ/hsBpu171KE9hd2gZ5twInGwJUbs8QaESs5mX64Kw4VCsOFpPqNT1u339XKNKNcsk36HcJ+NTm/usTPHRS3lUZlFVl0ZjEH3Ksf4XmL4bNmKWrYwmnl3WNo4OpD6rRtHFnu/2zRmZ+iwHj8z2Ri2JiNALx1SsgjmGOrdDnhJIMiEfnImvnLhpvapabgxaEqBqljE9s1lLhlm+9mZVvUlTre1CYpoyj81kKApZ7tpTfjx0+wq0gnvlAX2KCF0avQoN/cBwIZur1dCZZt6HUQhCXcuqNaL6pv447cOCsGxvEBwhstWQZcAbjDSQVKjhTGsKtEZvk325XewDIsnh1cKds4ZrKoJ6tpGwVWqpCKkHTG5G2Oa//6cXcJWIRWPJ8o86IjMKYyJjqsYVbmKxJeBe2eGS2NPqUODCuksm0f07mEpFTHhD9J1nOfVMPK32vXZcxm93pFQb2YDUI/fhV40DDQQCH+Goox2uFpzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(2906002)(6512007)(66946007)(85182001)(86362001)(33716001)(6486002)(508600001)(316002)(9686003)(66556008)(66476007)(8676002)(4326008)(53546011)(45080400002)(38100700002)(6506007)(82960400001)(83380400001)(5660300002)(8936002)(26005)(54906003)(66574015)(186003)(6916009)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3I2Vk0xWkVyYlU0czg1b1dsNytnck5pQUxRdy9mWjV2M1JTVWlhVEhaWi93?= =?utf-8?B?MzhiQ0dvZ0txWWpKalJVSEVNdSs4V0UrbTlsc0tvREVrT1NpZDVXVmlKYUVU?= =?utf-8?B?K2t3TERLTk5PWVo5QVNrREswbGYrWUpJNkJIQVpXNUpvUnVxbW9qdmVkbk4r?= =?utf-8?B?SVdJTWlUZSsxWUZia0VyTksxRkRQZWxobjFQWlJTenZVckMxWlB1Y09LazNt?= =?utf-8?B?OGs3VlJJeWVXa2hrMXFXUktab1ZGZ0xvN2hLSzJ2cXNwTWQrVWlla3RWRHdN?= =?utf-8?B?MngwOS9ENkltZGI0U2QyL05Rdi9tdktLODREaTcvYUpsQlg0eDN1ZmZ2aHZ0?= =?utf-8?B?dEtCOUc2VkZvMnVrSWY4YXJJVWVSYlM3aVdRekVmMzJrR0RZbzBFVElTNXFp?= =?utf-8?B?dDQrNHNVUjNhZXNSSnMvQmdFcHdJQ2VmWWRNcXVIVmNHMzFuZHJxMUF4N1ZW?= =?utf-8?B?VVZ0bS9hMEFSQmVkS1F3UDFPQlBhYUh1QTBuOTRWWnhJanVENlhQRlJSTndj?= =?utf-8?B?WG5wYW1xSm8yTVR5Vk01VDViS2s2WkFwaFpxREdGWmdRQTF3RVQ1REwyOFFn?= =?utf-8?B?TXpJMTlvclphdlJSNEpsS0ZRYU90RjhZQlNaVUx0QjRtbGZQU0wyLzJXTmxW?= =?utf-8?B?ZGhHSGZrNGVub2hZaGxsbnJlME5ydFM2ZDFiakhiNmswZCtuV2ZmQkE0QUpV?= =?utf-8?B?Ynh1UFJwbndNSlI4Tlk5aVB3MXFSSldVYlVEV3N4dEUweUszdDFPRDk2ZCtJ?= =?utf-8?B?K0FqeVZUdTU0eWxPT0gxNklxTU0wOXdHdW1SY253TUxPdmY3dmxPN0k0ZWRa?= =?utf-8?B?eXgxWnk4V3JmYXpxUGJINjJBQ0dqTnVPcmlPbXVBaTE2TXg2bXBUaTlSTjFt?= =?utf-8?B?Tk0xeVZIV29vVGkweUdubjNkNUorZlhVbjZNNFltdEwxdGNzUjczRUxOdGtE?= =?utf-8?B?NjVTMEg1bFpZQzVZRGJ4Y0lwbDE5eU9QaVJ4bkN0Njd5b0JBQ3R6RWtXNWgr?= =?utf-8?B?ZmRLbmI1dVM5TERaL29Yb0xzQ3lGRXVVYzQ3OGl0dzE1VTVmaXc3K0VLaDNl?= =?utf-8?B?ODdud1JvTFR5cFBoNmdiZlRTSmVPY2xIMElYeGpRQXRLU3NLM1ZZTVdvbGhL?= =?utf-8?B?TlI2L3pYN3I1eVNwQ0F4Tm55MndVekZXTXhsaUZTa3d3dmhRWHYxdW1icE1R?= =?utf-8?B?eWJPanQ2WHBKbHJXZGR5STdlcE10b1BtWlFFUWRlamU2eVRGbHljMTM4dCtk?= =?utf-8?B?UTBSNFJZSHM2SFJhNXlYcVNWZGVZUGhpS0NaL1RwdG5xTkNNeEdlemJFcUtF?= =?utf-8?B?ejhBV2g2OG8yS2g3ZXBBams3dmc4TkhXcWk2ZG9pTEdQNno1cDdHUk9pc0Z2?= =?utf-8?B?T3Zpb2R1Y0RUenkxM3A3UU9sZDkxeW1vRDBxUC9rYjRRazVlM085TjFzVzM5?= =?utf-8?B?TURPc2t2elNXcGZIY2k0TmRqWFlNNjNqZDNRZSs0Y2RBYk9lRmlBNGZYWnE3?= =?utf-8?B?Q2dlRE9Ld0cxOGZMNHdlL2JCZ05Oa0s4bmN6VVdpd05wd01pNU1vY1V3VmhG?= =?utf-8?B?TE9uRko3SWc1RkcvdVJhckJteDZBZTRPaXhTZ3FINjBqU1loYUlQaW9ORWdE?= =?utf-8?B?QzNkNE9KRlU1TkVCd25PS1p0WmxLRmd6OFpjYlJmWjUvNHlYTCtFcWR0ZlRM?= =?utf-8?B?bzAzMG9IYXAvOHUwN1ZSYUh0UWRCK0dsRE5wVktGK0YxRXZ6ejVBa2xHUysr?= =?utf-8?B?SVVtdHV0U0tTdTBoYStnNzZ6VkdtbDdnQ0xLOXpDdFJDUzVOODNqak9SaGU5?= =?utf-8?B?QWorRnZDL2lqN3h3WWkyNkFZNDBIeFhnK1NWaHRlVGR5WHE4OEE1c3ZMbUFs?= =?utf-8?B?OVIwSER3SURqei9ORVRhWDV5SW9WMS9NSStZY1E0SW4vaGdMV1Q0MkNDS2RD?= =?utf-8?B?K3pVdVdNUkZIL0FXb1ppUTRnTHJIbmRZc3lwKzFRaTdZWithYXp4d1IrWDBn?= =?utf-8?B?ZEVRMkg5UDB2a1kva01SMVJGZi84WGdPSlpvbmU0YWp2ZG4zTERJaGZMNHp4?= =?utf-8?B?akl0aTI4clArVTNEemRNYlB5cFZXQnUySTFoMCtmb0FTMTk2SWlHYmpmNzFE?= =?utf-8?B?U1Z5NGxuaFhwVTBnTExpTjk0YytId2JJTWd2WG1TMXgyRmlGK1hrNWQ4Q3Vt?= =?utf-8?B?S016YlFjcnBUbzh1WEpqMmRucTRhWXZYcXBhMTYyT0JXa2EwZjdzZXEyK3FI?= =?utf-8?B?YjZhR3V2M0xhTTRJWTFDbEdTU1VYS0tDQWlWeUpPa204WThtUnlhNGJja0wr?= =?utf-8?B?SlVmQ2FrKzhLL2txNWNGajRxeDhuTTJzVlNGdElPOU5iU2xvN1VkSHcrQ1J6?= =?utf-8?Q?PGz1WMHk5WtXysPg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8045dd-e166-4f03-0a2e-08da341fac49 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 13:59:46.6850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aNqAJ7UErMS6oVsg7CfmXdmSrN/mPEBgoZ3kwj5KdMk7vAQPZst1GA3H8skOoy9ko06fnFRBhdqB3d6wFf8Y/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4097 On Thu, May 12, 2022 at 08:47:01AM -0400, Jason Andryuk wrote: > On Wed, May 11, 2022 at 3:25 PM Marek Marczykowski-Górecki > wrote: > > > > Hi, > > > > The reproducer is trivial: > > > > [user@dom0 ~]$ sudo xl block-attach work backend=sys-usb vdev=xvdi target=/dev/sdz > > [user@dom0 ~]$ xl block-list work > > Vdev BE handle state evt-ch ring-ref BE-path > > 51712 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51712 > > 51728 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51728 > > 51744 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51744 > > 51760 0 241 4 -1 -1 /local/domain/0/backend/vbd/241/51760 > > 51840 3 241 3 -1 -1 /local/domain/3/backend/vbd/241/51840 > > ^ note state, the /dev/sdz doesn't exist in the backend > > > > [user@dom0 ~]$ sudo xl block-detach work xvdi > > [user@dom0 ~]$ xl block-list work > > Vdev BE handle state evt-ch ring-ref BE-path > > work is an invalid domain identifier > > > > And its console has: > > > > BUG: kernel NULL pointer dereference, address: 0000000000000050 > > #PF: supervisor read access in kernel mode > > #PF: error_code(0x0000) - not-present page > > PGD 80000000edebb067 P4D 80000000edebb067 PUD edec2067 PMD 0 > > Oops: 0000 [#1] PREEMPT SMP PTI > > CPU: 1 PID: 52 Comm: xenwatch Not tainted 5.16.18-2.43.fc32.qubes.x86_64 #1 > > RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 > > Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5b 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0 74 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 > > RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 > > RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 > > RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 > > RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 > > R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 > > R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 > > FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 > > Call Trace: > > > > blkback_changed+0x95/0x137 [xen_blkfront] > > ? read_reply+0x160/0x160 > > xenwatch_thread+0xc0/0x1a0 > > ? do_wait_intr_irq+0xa0/0xa0 > > kthread+0x16b/0x190 > > ? set_kthread_struct+0x40/0x40 > > ret_from_fork+0x22/0x30 > > > > Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer snd soundcore ipt_REJECT nf_reject_ipv4 xt_state xt_conntrack nft_counter nft_chain_nat xt_MASQUERADE nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables nfnetlink intel_rapl_msr intel_rapl_common crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel xen_netfront pcspkr xen_scsiback target_core_mod xen_netback xen_privcmd xen_gntdev xen_gntalloc xen_blkback xen_evtchn ipmi_devintf ipmi_msghandler fuse bpf_preload ip_tables overlay xen_blkfront > > CR2: 0000000000000050 > > ---[ end trace 7bc9597fd06ae89d ]--- > > RIP: 0010:blk_mq_stop_hw_queues+0x5/0x40 > > Code: 00 48 83 e0 fd 83 c3 01 48 89 85 a8 00 00 00 41 39 5c 24 50 77 c0 5b 5d 41 5c 41 5d c3 c3 0f 1f 80 00 00 00 00 0f 1f 44 00 00 <8b> 47 50 85 c0 74 32 41 54 49 89 fc 55 53 31 db 49 8b 44 24 48 48 > > RSP: 0018:ffffc90000bcfe98 EFLAGS: 00010293 > > RAX: ffffffffc0008370 RBX: 0000000000000005 RCX: 0000000000000000 > > RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000000 > > RBP: ffff88800775f000 R08: 0000000000000001 R09: ffff888006e620b8 > > R10: ffff888006e620b0 R11: f000000000000000 R12: ffff8880bff39000 > > R13: ffff8880bff39000 R14: 0000000000000000 R15: ffff88800604be00 > > FS: 0000000000000000(0000) GS:ffff8880f3300000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000000000050 CR3: 00000000e932e002 CR4: 00000000003706e0 > > Kernel panic - not syncing: Fatal exception > > Kernel Offset: disabled > > This looks like it may be blkfront_closing() calling > blk_mq_stop_hw_queues() with info->rq == NULL. info->rq is only > assigned in blkfront_connect(), which is called for state 4, but your > vbd never made it through there. It seems like blkfront_closing() > should NULL check info->rq and info->gd before using them. Care to send a patch? :) Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 12 14:01:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327725.550589 (Exim 4.92) (envelope-from ) id 1np9O5-0001HE-Al; Thu, 12 May 2022 14:01:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327725.550589; Thu, 12 May 2022 14:01:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9O5-0001H7-82; Thu, 12 May 2022 14:01:53 +0000 Received: by outflank-mailman (input) for mailman id 327725; Thu, 12 May 2022 14:01:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9O4-0001Gk-0d for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:01:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 114d9b64-d1fc-11ec-a406-831a346695d4; Thu, 12 May 2022 16:01:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C41F961A39; Thu, 12 May 2022 14:01:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 921B6C385B8; Thu, 12 May 2022 14:01:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 114d9b64-d1fc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652364108; bh=Z/Ws/YqRZBPStcl75eglrGhJNELDeF5x+1KQttHEXBM=; h=Subject:To:Cc:From:Date:From; b=13VwfVIip4aeGa4GD3M92snk8Kd8iXwB9mXxu27b4EeUqOXF2AVIHjfHajYMV0/9B EOIMy/GmKDQp1HOR+QvshXwnONrHHxUcyQPz8kMeMkLpen33lorqKHKjbFTbFma5rl cl8a/Icq92V5aKJT6rlyZyEbQK0AbeBdP5D1Aa7A= Subject: Patch "x86/asm: Allow to pass macros to __ASM_FORM()" has been added to the 5.4-stable tree To: andrew.cooper3@citrix.com,boris.ostrovsky@oracle.com,bp@alien8.de,gregkh@linuxfoundation.org,jgross@suse.com,jpoimboe@redhat.com,mheyne@amazon.de,mhiramat@kernel.org,mingo@kernel.org,peterz@infradead.org,rdunlap@infradead.org,sstabellini@kernel.org,x86@kernel.org,xen-devel@lists.xenproject.org Cc: From: Date: Thu, 12 May 2022 16:01:37 +0200 Message-ID: <16523640972042@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled x86/asm: Allow to pass macros to __ASM_FORM() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-asm-allow-to-pass-macros-to-__asm_form.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From f7919fd943abf0c77aed4441ea9897a323d132f5 Mon Sep 17 00:00:00 2001 From: Masami Hiramatsu Date: Fri, 6 Sep 2019 22:13:48 +0900 Subject: x86/asm: Allow to pass macros to __ASM_FORM() From: Masami Hiramatsu commit f7919fd943abf0c77aed4441ea9897a323d132f5 upstream. Use __stringify() at __ASM_FORM() so that user can pass code including macros to __ASM_FORM(). Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/asm.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/arch/x86/include/asm/asm.h +++ b/arch/x86/include/asm/asm.h @@ -7,9 +7,11 @@ # define __ASM_FORM_RAW(x) x # define __ASM_FORM_COMMA(x) x, #else -# define __ASM_FORM(x) " " #x " " -# define __ASM_FORM_RAW(x) #x -# define __ASM_FORM_COMMA(x) " " #x "," +#include + +# define __ASM_FORM(x) " " __stringify(x) " " +# define __ASM_FORM_RAW(x) __stringify(x) +# define __ASM_FORM_COMMA(x) " " __stringify(x) "," #endif #ifndef __x86_64__ Patches currently in stable-queue which might be from mhiramat@kernel.org are queue-5.4/x86-xen-kvm-gather-the-definition-of-emulate-prefixes.patch queue-5.4/x86-xen-insn-decode-xen-and-kvm-emulate-prefix-signature.patch queue-5.4/x86-asm-allow-to-pass-macros-to-__asm_form.patch queue-5.4/x86-kprobes-prohibit-probing-on-instruction-which-has-emulate-prefix.patch From xen-devel-bounces@lists.xenproject.org Thu May 12 14:02:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:02:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327726.550600 (Exim 4.92) (envelope-from ) id 1np9OC-0001Zj-IK; Thu, 12 May 2022 14:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327726.550600; Thu, 12 May 2022 14:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OC-0001Za-FF; Thu, 12 May 2022 14:02:00 +0000 Received: by outflank-mailman (input) for mailman id 327726; Thu, 12 May 2022 14:01:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OB-0001Gk-1j for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:01:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15d8e904-d1fc-11ec-a406-831a346695d4; Thu, 12 May 2022 16:01:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D99FD61A4F; Thu, 12 May 2022 14:01:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E6AC385B8; Thu, 12 May 2022 14:01:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15d8e904-d1fc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652364116; bh=veazphcYW1xAUy40XJ7IGNsO6QwIdAH+107wflvfuDw=; h=Subject:To:Cc:From:Date:From; b=tAdlGNgjhrx4BOlJ8FZRkq3L8YGJVzUvXFHB4Dv5JY64czZe9cLD2bKuJ+jp4RLn4 RoHBtBx236snzAcL/Nhxlvk8xyFFiRhTP1hqbFbt2eegFfQBGfOYmKFUaZ01JLWhzq OHf3+HgcwdfYYjK3h9tW5bz926DPP/Uxw2koLeeA= Subject: Patch "x86: xen: kvm: Gather the definition of emulate prefixes" has been added to the 5.4-stable tree To: andrew.cooper3@citrix.com,boris.ostrovsky@oracle.com,bp@alien8.de,gregkh@linuxfoundation.org,jgross@suse.com,jpoimboe@redhat.com,mheyne@amazon.de,mhiramat@kernel.org,mingo@kernel.org,peterz@infradead.org,rdunlap@infradead.org,sstabellini@kernel.org,x86@kernel.org,xen-devel@lists.xenproject.org Cc: From: Date: Thu, 12 May 2022 16:01:38 +0200 Message-ID: <1652364098240167@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled x86: xen: kvm: Gather the definition of emulate prefixes to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-xen-kvm-gather-the-definition-of-emulate-prefixes.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 Mon Sep 17 00:00:00 2001 From: Masami Hiramatsu Date: Fri, 6 Sep 2019 22:13:59 +0900 Subject: x86: xen: kvm: Gather the definition of emulate prefixes From: Masami Hiramatsu commit b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 upstream. Gather the emulate prefixes, which forcibly make the following instruction emulated on virtualization, in one place. Suggested-by: Peter Zijlstra Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Ingo Molnar Cc: Boris Ostrovsky Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777563917.25081.7286628561790289995.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/emulate_prefix.h | 14 ++++++++++++++ arch/x86/include/asm/xen/interface.h | 11 ++++------- arch/x86/kvm/x86.c | 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h --- /dev/null +++ b/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif --- a/arch/x86/include/asm/xen/interface.h +++ b/arch/x86/include/asm/xen/interface.h @@ -379,12 +379,9 @@ struct xen_pmu_arch { * Prefix forces emulation of some non-trapping instructions. * Currently only CPUID. */ -#ifdef __ASSEMBLY__ -#define XEN_EMULATE_PREFIX .byte 0x0f,0x0b,0x78,0x65,0x6e ; -#define XEN_CPUID XEN_EMULATE_PREFIX cpuid -#else -#define XEN_EMULATE_PREFIX ".byte 0x0f,0x0b,0x78,0x65,0x6e ; " -#define XEN_CPUID XEN_EMULATE_PREFIX "cpuid" -#endif +#include + +#define XEN_EMULATE_PREFIX __ASM_FORM(.byte __XEN_EMULATE_PREFIX ;) +#define XEN_CPUID XEN_EMULATE_PREFIX __ASM_FORM(cpuid) #endif /* _ASM_X86_XEN_INTERFACE_H */ --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #define CREATE_TRACE_POINTS @@ -5583,6 +5584,7 @@ EXPORT_SYMBOL_GPL(kvm_write_guest_virt_s int handle_ud(struct kvm_vcpu *vcpu) { + static const char kvm_emulate_prefix[] = { __KVM_EMULATE_PREFIX }; int emul_type = EMULTYPE_TRAP_UD; char sig[5]; /* ud2; .ascii "kvm" */ struct x86_exception e; @@ -5590,7 +5592,7 @@ int handle_ud(struct kvm_vcpu *vcpu) if (force_emulation_prefix && kvm_read_guest_virt(vcpu, kvm_get_linear_rip(vcpu), sig, sizeof(sig), &e) == 0 && - memcmp(sig, "\xf\xbkvm", sizeof(sig)) == 0) { + memcmp(sig, kvm_emulate_prefix, sizeof(sig)) == 0) { kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(sig)); emul_type = EMULTYPE_TRAP_UD_FORCED; } Patches currently in stable-queue which might be from mhiramat@kernel.org are queue-5.4/x86-xen-kvm-gather-the-definition-of-emulate-prefixes.patch queue-5.4/x86-xen-insn-decode-xen-and-kvm-emulate-prefix-signature.patch queue-5.4/x86-asm-allow-to-pass-macros-to-__asm_form.patch queue-5.4/x86-kprobes-prohibit-probing-on-instruction-which-has-emulate-prefix.patch From xen-devel-bounces@lists.xenproject.org Thu May 12 14:02:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327727.550611 (Exim 4.92) (envelope-from ) id 1np9OE-0001re-Qs; Thu, 12 May 2022 14:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327727.550611; Thu, 12 May 2022 14:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OE-0001rV-N1; Thu, 12 May 2022 14:02:02 +0000 Received: by outflank-mailman (input) for mailman id 327727; Thu, 12 May 2022 14:02:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OD-0001Gk-PE for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:02:01 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16b2b2f5-d1fc-11ec-a406-831a346695d4; Thu, 12 May 2022 16:01:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 864ACCE2971; Thu, 12 May 2022 14:01:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93749C385B8; Thu, 12 May 2022 14:01:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16b2b2f5-d1fc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652364114; bh=HqZw/phFWBMSXNUzzcc94+rWdGbz6OaJg41vKpMTZr4=; h=Subject:To:Cc:From:Date:From; b=mHoigYKGb/v6DuPlqqMgJhm74LFOd7CnSpnAbH1b1jQ33WP3IHBbI+HsHNFIXLgvc aissvHDPonfKQTPBuJyxN3PLltUvw0qBmFwzK8GwzwahG0EWFezk4nEHDxNF6OcHJ+ lVh8+Ag2Q70ic7IyabW6vS74OnYKmmiWImuu5Tjc= Subject: Patch "x86: xen: insn: Decode Xen and KVM emulate-prefix signature" has been added to the 5.4-stable tree To: andrew.cooper3@citrix.com,boris.ostrovsky@oracle.com,bp@alien8.de,gregkh@linuxfoundation.org,jgross@suse.com,jpoimboe@redhat.com,mheyne@amazon.de,mhiramat@kernel.org,mingo@kernel.org,peterz@infradead.org,rdunlap@infradead.org,sstabellini@kernel.org,x86@kernel.org,xen-devel@lists.xenproject.org Cc: From: Date: Thu, 12 May 2022 16:01:38 +0200 Message-ID: <165236409818691@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled x86: xen: insn: Decode Xen and KVM emulate-prefix signature to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-xen-insn-decode-xen-and-kvm-emulate-prefix-signature.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 4d65adfcd1196818659d3bd9b42dccab291e1751 Mon Sep 17 00:00:00 2001 From: Masami Hiramatsu Date: Fri, 6 Sep 2019 22:14:10 +0900 Subject: x86: xen: insn: Decode Xen and KVM emulate-prefix signature From: Masami Hiramatsu commit 4d65adfcd1196818659d3bd9b42dccab291e1751 upstream. Decode Xen and KVM's emulate-prefix signature by x86 insn decoder. It is called "prefix" but actually not x86 instruction prefix, so this adds insn.emulate_prefix_size field instead of reusing insn.prefixes. If x86 decoder finds a special sequence of instructions of XEN_EMULATE_PREFIX and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Acked-by: Josh Poimboeuf Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/insn.h | 6 ++++ arch/x86/lib/insn.c | 34 ++++++++++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 ++++++++++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 7 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h --- a/arch/x86/include/asm/insn.h +++ b/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct in return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include #include +#include + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); --- /dev/null +++ b/tools/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif --- a/tools/arch/x86/include/asm/insn.h +++ b/tools/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct in return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { --- a/tools/arch/x86/lib/insn.c +++ b/tools/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include "../include/asm/inat.h" #include "../include/asm/insn.h" +#include "../include/asm/emulate_prefix.h" + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); --- a/tools/objtool/sync-check.sh +++ b/tools/objtool/sync-check.sh @@ -4,6 +4,7 @@ FILES=' arch/x86/include/asm/inat_types.h arch/x86/include/asm/orc_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk ' @@ -46,4 +47,4 @@ done check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -28,6 +28,7 @@ arch/x86/include/asm/disabled-features.h arch/x86/include/asm/required-features.h arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/inat_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/include/uapi/asm/prctl.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk @@ -116,7 +117,7 @@ check lib/ctype.c '-I "^EXPORT_SY check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' # diff non-symmetric files check_2 tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl Patches currently in stable-queue which might be from mhiramat@kernel.org are queue-5.4/x86-xen-kvm-gather-the-definition-of-emulate-prefixes.patch queue-5.4/x86-xen-insn-decode-xen-and-kvm-emulate-prefix-signature.patch queue-5.4/x86-asm-allow-to-pass-macros-to-__asm_form.patch queue-5.4/x86-kprobes-prohibit-probing-on-instruction-which-has-emulate-prefix.patch From xen-devel-bounces@lists.xenproject.org Thu May 12 14:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327728.550622 (Exim 4.92) (envelope-from ) id 1np9OG-00028q-61; Thu, 12 May 2022 14:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327728.550622; Thu, 12 May 2022 14:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OG-000288-1d; Thu, 12 May 2022 14:02:04 +0000 Received: by outflank-mailman (input) for mailman id 327728; Thu, 12 May 2022 14:02:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9OF-0001rh-7R for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:02:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11e0eeca-d1fc-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 16:01:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5CF4B8283A; Thu, 12 May 2022 14:02:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A014C34114; Thu, 12 May 2022 14:01:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11e0eeca-d1fc-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652364119; bh=r9ta6P7ZRths+9S/6LdjeCw30mXxnb+dFJ5Xg+4yH1s=; h=Subject:To:Cc:From:Date:From; b=mCd+vYC3ZkawcmV7o+Y+NM5UgkuRmcMu2m3QTfB9N70iVs8JumaNameETgECwhPVm Z8f5BU6iLUAar9tWAO44LfGDGqg7M+ezYG7aaTA3VTYOVuto3hv1RXWi7fGguUUpDK ONv4RQUITdd4TULXAP2O3c7LXGS//QfF/TTAnyI4= Subject: Patch "x86: kprobes: Prohibit probing on instruction which has emulate prefix" has been added to the 5.4-stable tree To: andrew.cooper3@citrix.com,boris.ostrovsky@oracle.com,bp@alien8.de,gregkh@linuxfoundation.org,jgross@suse.com,jpoimboe@redhat.com,mheyne@amazon.de,mhiramat@kernel.org,mingo@kernel.org,peterz@infradead.org,rdunlap@infradead.org,sstabellini@kernel.org,x86@kernel.org,xen-devel@lists.xenproject.org Cc: From: Date: Thu, 12 May 2022 16:01:38 +0200 Message-ID: <165236409813853@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled x86: kprobes: Prohibit probing on instruction which has emulate prefix to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-kprobes-prohibit-probing-on-instruction-which-has-emulate-prefix.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 004e8dce9c5595697951f7cd0e9f66b35c92265e Mon Sep 17 00:00:00 2001 From: Masami Hiramatsu Date: Fri, 6 Sep 2019 22:14:20 +0900 Subject: x86: kprobes: Prohibit probing on instruction which has emulate prefix From: Masami Hiramatsu commit 004e8dce9c5595697951f7cd0e9f66b35c92265e upstream. Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/kprobes/core.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -358,6 +358,10 @@ int __copy_instruction(u8 *dest, u8 *src kernel_insn_init(insn, dest, MAX_INSN_SIZE); insn_get_length(insn); + /* We can not probe force emulate prefixed instruction */ + if (insn_has_emulate_prefix(insn)) + return 0; + /* Another subsystem puts a breakpoint, failed to recover */ if (insn->opcode.bytes[0] == BREAKPOINT_INSTRUCTION) return 0; Patches currently in stable-queue which might be from mhiramat@kernel.org are queue-5.4/x86-xen-kvm-gather-the-definition-of-emulate-prefixes.patch queue-5.4/x86-xen-insn-decode-xen-and-kvm-emulate-prefix-signature.patch queue-5.4/x86-asm-allow-to-pass-macros-to-__asm_form.patch queue-5.4/x86-kprobes-prohibit-probing-on-instruction-which-has-emulate-prefix.patch From xen-devel-bounces@lists.xenproject.org Thu May 12 14:11:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327751.550633 (Exim 4.92) (envelope-from ) id 1np9XT-0004Y3-A1; Thu, 12 May 2022 14:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327751.550633; Thu, 12 May 2022 14:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9XT-0004Xw-7D; Thu, 12 May 2022 14:11:35 +0000 Received: by outflank-mailman (input) for mailman id 327751; Thu, 12 May 2022 14:11:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9PS-0001Gk-4P for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:03:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 453c3b72-d1fc-11ec-a406-831a346695d4; Thu, 12 May 2022 16:03:16 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 600DB21B2F; Thu, 12 May 2022 14:03:16 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5C2702C141; Thu, 12 May 2022 14:03:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 453c3b72-d1fc-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652364196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LqB96ySSQJ4ly+3J+rYGGuH/Fd7fkvILEbloF31pDTM=; b=q3SRuDuz1bsrtNT6AQbijhKvd/E1pyV5ISS04f4B5Eo/MpxJkThlvlpzsrdXZrusqFVq1r 7s+CTa1eDnSZSlcSzDLMEjhXIjmmjm5vpsFw4wJd/0EtFszB2sl8NlJGjykorM6dG2+lpF 5FiP1kelHffEWxoWnmRZqh37k1tv6Lg= Date: Thu, 12 May 2022 16:03:10 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-25-gpiccoli@igalia.com> Hello, first, I am sorry for stepping into the discussion so late. I was busy with some other stuff and this patchset is far from trivial. Second, thanks a lot for putting so much effort into it. Most of the changes look pretty good, especially all the fixes of particular notifiers and split into four lists. Though this patch will need some more love. See below for more details. On Wed 2022-04-27 19:49:18, Guilherme G. Piccoli wrote: > The panic() function is somewhat convoluted - a lot of changes were > made over the years, adding comments that might be misleading/outdated > now, it has a code structure that is a bit complex to follow, with > lots of conditionals, for example. The panic notifier list is something > else - a single list, with multiple callbacks of different purposes, > that run in a non-deterministic order and may affect hardly kdump > reliability - see the "crash_kexec_post_notifiers" workaround-ish flag. > > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -3784,6 +3791,33 @@ > timeout < 0: reboot immediately > Format: > > + panic_notifiers_level= > + [KNL] Set the panic notifiers execution order. > + Format: > + We currently have 4 lists of panic notifiers; based > + on the functionality and risk (for panic success) the > + callbacks are added in a given list. The lists are: > + - hypervisor/FW notification list (low risk); > + - informational list (low/medium risk); > + - pre_reboot list (higher risk); > + - post_reboot list (only run late in panic and after > + kdump, not configurable for now). > + This parameter defines the ordering of the first 3 > + lists with regards to kdump; the levels determine > + which set of notifiers execute before kdump. The > + accepted levels are: This talks only about kdump. The reality is much more complicated. The level affect the order of: + notifiers vs. kdump + notifiers vs. crash_dump + crash_dump vs. kdump There might theoretically many variants of the ordering of kdump, crash_dump, and the 4 notifier list. Some variants do not make much sense. You choose 5 variants and tried to select them by a level number. The question is if we really could easily describe the meaning this way. It is not only about a "level" of notifiers before kdump. It is also about the ordering of crash_dump vs. kdump. IMHO, "level" semantic does not fit there. Maybe more parameters might be easier to understand the effect. Anyway, we first need to agree on the chosen variants. I am going to discuss it more in the code, see below. > + 0: kdump is the first thing to run, NO list is > + executed before kdump. > + 1: only the hypervisor list is executed before kdump. > + 2 (default level): the hypervisor list and (*if* > + there's any kmsg_dumper defined) the informational > + list are executed before kdump. > + 3: both the hypervisor and the informational lists > + (always) execute before kdump. > + 4: the 3 lists (hypervisor, info and pre_reboot) > + execute before kdump - this behavior is analog to the > + deprecated parameter "crash_kexec_post_notifiers". > + > panic_print= Bitmask for printing system info when panic happens. > User can chose combination of the following bits: > bit 0: print all tasks info > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -183,6 +195,112 @@ static void panic_print_sys_info(bool console_flush) > ftrace_dump(DUMP_ALL); > } > > +/* > + * Helper that accumulates all console flushing routines executed on panic. > + */ > +static void console_flushing(void) > +{ > +#ifdef CONFIG_VT > + unblank_screen(); > +#endif > + console_unblank(); > + > + /* > + * In this point, we may have disabled other CPUs, hence stopping the > + * CPU holding the lock while still having some valuable data in the > + * console buffer. > + * > + * Try to acquire the lock then release it regardless of the result. > + * The release will also print the buffers out. Locks debug should > + * be disabled to avoid reporting bad unlock balance when panic() > + * is not being called from OOPS. > + */ > + debug_locks_off(); > + console_flush_on_panic(CONSOLE_FLUSH_PENDING); > + > + panic_print_sys_info(true); > +} > + > +#define PN_HYPERVISOR_BIT 0 > +#define PN_INFO_BIT 1 > +#define PN_PRE_REBOOT_BIT 2 > +#define PN_POST_REBOOT_BIT 3 > + > +/* > + * Determine the order of panic notifiers with regards to kdump. > + * > + * This function relies in the "panic_notifiers_level" kernel parameter > + * to determine how to order the notifiers with regards to kdump. We > + * have currently 5 levels. For details, please check the kernel docs for > + * "panic_notifiers_level" at Documentation/admin-guide/kernel-parameters.txt. > + * > + * Default level is 2, which means the panic hypervisor and informational > + * (unless we don't have any kmsg_dumper) lists will execute before kdump. > + */ > +static void order_panic_notifiers_and_kdump(void) > +{ > + /* > + * The parameter "crash_kexec_post_notifiers" is deprecated, but > + * valid. Users that set it want really all panic notifiers to > + * execute before kdump, so it's effectively the same as setting > + * the panic notifiers level to 4. > + */ > + if (panic_notifiers_level >= 4 || crash_kexec_post_notifiers) > + return; > + > + /* > + * Based on the level configured (smaller than 4), we clear the > + * proper bits in "panic_notifiers_bits". Notice that this bitfield > + * is initialized with all notifiers set. > + */ > + switch (panic_notifiers_level) { > + case 3: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + break; > + case 2: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + > + if (!kmsg_has_dumpers()) > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + break; > + case 1: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + break; > + case 0: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits); > + break; > + } > +} > > +/* > + * Set of helpers to execute the panic notifiers only once. > + * Just the informational notifier cares about the return. > + */ > +static inline bool notifier_run_once(struct atomic_notifier_head head, > + char *buf, long bit) > +{ > + if (test_and_change_bit(bit, &panic_notifiers_bits)) { > + atomic_notifier_call_chain(&head, PANIC_NOTIFIER, buf); > + return true; > + } > + return false; > +} Here is the code using the above functions. It helps to discuss the design and logic. order_panic_notifiers_and_kdump(); /* If no level, we should kdump ASAP. */ if (!panic_notifiers_level) __crash_kexec(NULL); crash_smp_send_stop(); panic_notifier_hypervisor_once(buf); if (panic_notifier_info_once(buf)) kmsg_dump(KMSG_DUMP_PANIC); panic_notifier_pre_reboot_once(buf); __crash_kexec(NULL); panic_notifier_hypervisor_once(buf); if (panic_notifier_info_once(buf)) kmsg_dump(KMSG_DUMP_PANIC); panic_notifier_pre_reboot_once(buf); I have to say that the logic is very unclear. Almost all functions are called twice: + __crash_kexec() + kmsg_dump() + panic_notifier_hypervisor_once() + panic_notifier_pre_reboot_once() + panic_notifier_info_once() It is pretty hard to find what functions are always called in the same order and where the order can be inverted. The really used code path is defined by order_panic_notifiers_and_kdump() that encodes "level" into "bits". The bits are then flipped in panic_notifier_*_once() calls that either do something or not. kmsg_dump() is called according to the bit flip. It is an interesting approach. I guess that you wanted to avoid too many if/then/else levels in panic(). But honestly, it looks like a black magic to me. IMHO, it is always easier to follow if/then/else logic than using a translation table that requires additional bit flips when a value is used more times. Also I guess that it is good proof that "level" abstraction does not fit here. Normal levels would not need this kind of magic. OK, the question is how to make it better. Let's start with a clear picture of the problem: 1. panic() has basically two funtions: + show/store debug information (optional ways and amount) + do something with the system (reboot, stay hanged) 2. There are 4 ways how to show/store the information: + tell hypervisor to store what it is interested about + crash_dump + kmsg_dump() + consoles , where crash_dump and consoles are special: + crash_dump does not return. Instead it ends up with reboot. + Consoles work transparently. They just need an extra flush before reboot or staying hanged. 3. The various notifiers do things like: + tell hypervisor about the crash + print more information (also stop watchdogs) + prepare system for reboot (touch some interfaces) + prepare system for staying hanged (blinking) Note that it pretty nicely matches the 4 notifier lists. Now, we need to decide about the ordering. The main area is how to store the debug information. Consoles are transparent so the quesition is about: + hypervisor + crash_dump + kmsg_dump Some people need none and some people want all. There is a risk that system might hung at any stage. This why people want to make the order configurable. But crash_dump() does not return when it succeeds. And kmsg_dump() users havn't complained about hypervisor problems yet. So, that two variants might be enough: + crash_dump (hypervisor, kmsg_dump as fallback) + hypervisor, kmsg_dump, crash_dump One option "panic_prefer_crash_dump" should be enough. And the code might look like: void panic() { [...] dump_stack(); kgdb_panic(buf); < --- here starts the reworked code --- > /* crash dump is enough when enabled and preferred. */ if (panic_prefer_crash_dump) __crash_kexec(NULL); /* Stop other CPUs and focus on handling the panic state. */ if (has_kexec_crash_image) crash_smp_send_stop(); else smp_send_stop() /* Notify hypervisor about the system panic. */ atomic_notifier_call_chain(&panic_hypervisor_list, 0, NULL); /* * No need to risk extra info when there is no kmsg dumper * registered. */ if (!has_kmsg_dumper()) __crash_kexec(NULL); /* Add extra info from different subsystems. */ atomic_notifier_call_chain(&panic_info_list, 0, NULL); kmsg_dump(KMSG_DUMP_PANIC); __crash_kexec(NULL); /* Flush console */ unblank_screen(); console_unblank(); debug_locks_off(); console_flush_on_panic(CONSOLE_FLUSH_PENDING); if (panic_timeout > 0) { delay() } /* * Prepare system for eventual reboot and allow custom * reboot handling. */ atomic_notifier_call_chain(&panic_reboot_list, 0, NULL); if (panic_timeout != 0) { reboot(); } /* * Prepare system for the infinite waiting, for example, * setup blinking. */ atomic_notifier_call_chain(&panic_loop_list, 0, NULL); infinite_loop(); } __crash_kexec() is there 3 times but otherwise the code looks quite straight forward. Note 1: I renamed the two last notifier list. The name 'post-reboot' did sound strange from the logical POV ;-) Note 2: We have to avoid the possibility to call "reboot" list before kmsg_dump(). All callbacks providing info have to be in the info list. It a callback combines info and reboot functionality then it should be split. There must be another way to calm down problematic info callbacks. And it has to be solved when such a problem is reported. Is there any known issue, please? It is possible that I have missed something important. But I would really like to make the logic as simple as possible. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Thu May 12 14:16:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:16:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327762.550644 (Exim 4.92) (envelope-from ) id 1np9bo-0005Bc-SC; Thu, 12 May 2022 14:16:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327762.550644; Thu, 12 May 2022 14:16:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9bo-0005BV-Ox; Thu, 12 May 2022 14:16:04 +0000 Received: by outflank-mailman (input) for mailman id 327762; Thu, 12 May 2022 14:16:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9bo-0005BL-96; Thu, 12 May 2022 14:16:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9bo-0000dn-72; Thu, 12 May 2022 14:16:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9bn-0006gA-I5; Thu, 12 May 2022 14:16:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1np9bn-00057j-Hd; Thu, 12 May 2022 14:16:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=G7C9OOlomdWh66ueXdLNyBq7S1C9g13/MGwdhRk/v6s=; b=ctNpzA0NEVA0KtVSJ+f9simfdp hbUSIgNVGGWmb1mw5ocu/wYmySDAWSdbpv8bMIjm3WXCpvJx5KCGPirP4KNMB6qgP1cDYlHw8cj5m YI9gvsxzjZ9NlA/80nH8La846qX3jSx6KJ8ni1ZUyg7ldyqOFyDkR7znfjUpT/AfKpYk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170357: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 14:16:03 +0000 flight 170357 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170357/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 962 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 14:31:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:31:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327779.550659 (Exim 4.92) (envelope-from ) id 1np9ql-0007Xg-Bf; Thu, 12 May 2022 14:31:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327779.550659; Thu, 12 May 2022 14:31:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9ql-0007XZ-8W; Thu, 12 May 2022 14:31:31 +0000 Received: by outflank-mailman (input) for mailman id 327779; Thu, 12 May 2022 14:31:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1np9qj-0007XT-Ue for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:31:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7e1a::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e972c0b-d200-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 16:31:16 +0200 (CEST) Received: from DB9PR06CA0023.eurprd06.prod.outlook.com (2603:10a6:10:1db::28) by DB7PR08MB3417.eurprd08.prod.outlook.com (2603:10a6:10:44::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Thu, 12 May 2022 14:31:25 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::2e) by DB9PR06CA0023.outlook.office365.com (2603:10a6:10:1db::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:31:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:31:25 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Thu, 12 May 2022 14:31:25 +0000 Received: from 29e502b8cef8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9E833AE8-286A-4953-B096-A85D6F103B24.1; Thu, 12 May 2022 14:31:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29e502b8cef8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 May 2022 14:31:17 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by VE1PR08MB4846.eurprd08.prod.outlook.com (2603:10a6:802:ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Thu, 12 May 2022 14:31:15 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Thu, 12 May 2022 14:31:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e972c0b-d200-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RlOdcCloSCOjoOou6THH8zoA1iFs9Di3n9xSllMk8j+UkV9WVcDOAoDouqdqnlaitJcPngtECXrQhaagThDdiDCXpJ2v5RHl6EAtboo9b4cvtvSRKKMwaxFHDC60Y7pr+0tuBK95W2nBzhglVAVwO1VJWZaghsXH+QCOFdLFcINMLo9JpeldygJzbm4486CP2T4Eqms5tdKx7nOqgJaYYXrnhp1r0ndKEr5vOgu5SfSVOvIQqMD6qZZTeRonVbHmHuDhqSyJJpS4zByHjwL1HXwYNdJPlzf8BPMUx2LYMrUANR/p+ETqV4Yj5LZGR5tjhoeEJkGpOSeKYilYvqnIgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m5ulshnAG3BFpvQEkE8QBtmECw2l2HwJEVbueGS9zg=; b=Hqy3N/J3pxQjHDn9qPaw4iwPyJN7MBU2BzkqS/aIUwgwdyZiqe9A8PBNpPV4YiXiozfd1sKraGbdSOCkve3CdivWZhPcTGR4bW+I6p5RXZZEJ4sx+VGlajX/E2Fw/1w77SzjfNQOTrWW5OaDoezcIUQLkb7V2i5vfYlCxuWXCx7S1QkVeUOm3DEB1lg5QX14/0Mq7iTeDFAG6lk+ATLfL/6XcywHEBUHJD7uKIyGx67iQ6zBYdpQF2OR+rFZ8tD1AhwDw8G2CBM6BsXHciQYPcawQqW2W2r55A6ZTb8TC358RqvY9ZK4qx+ivutiQ4p3y2fKBihasOOJ5W6i5k5z8g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m5ulshnAG3BFpvQEkE8QBtmECw2l2HwJEVbueGS9zg=; b=47LWurY/zdaUREBFIOzK349hy1h6gQj6PY19EKxj2fIX7sptx+z2AGlMrqBJltIlIkA3BYXuE+Zl86EwNBcW3zJp4HT8cHYG2URvWVeyTGi+DvO1LFUvsc/kfNlJokDefLgy41ExsguPcCjgPeXWLLXXWP25hpm1DaR2m/PAenE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 948d3076324b0f9b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHpZMFc4gim3KY3MJ7ANdd3MO4ayKCaxMfTNf0Afzt0uYURH4BLteqhR+Od/uPpYLtOhmbNDgOY2llxZhxCbDGGP8OfBAobwmY1byEl4ktYrO13xSaFqmfYZ38UVkaeMjB4XNykegrztPLjISpR9pTQGr2j7Iz7WjIHLIxkv74yzgjnHrk8R24MO5xstTs63uHrz/ILUA0Csu+a9mlKg/HPdPx/bkcsGuF0ZLy2ZlRWOEkI4WXZ/YMiGsXMKqSUF1NJwfi4ummM+UDcoNzhhFAOq9uuHh7QS+WEKsSEzXp2xbKT0wbZukZzhwH8r5jtQhzxdQ4ekl1dNvPjUhxPMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m5ulshnAG3BFpvQEkE8QBtmECw2l2HwJEVbueGS9zg=; b=GlyntnPpMfQfgD0qqWKRrzvC8kpNl4y06KZkSMNr/s1uo3oLBoeoTNQuwKbYoJBqdpYwUf3SHwRAXHKbwcyC0MGGpdNe4N4Q7f9yhVXxnhkmgB/Qhhx1sZldY5DDj8xpaGi05UrUhLyutCuO/zGRiss4klP3y3SH0NMIz6QGCWr3KIYmRqjKjSkRWkXp92mQdmKHjlR+grhnTnWk67wg5KGXRvaZDXqq4gkogpf3JJ1L/3hNGwim9ibwY7+pFkyavb0zpKmM5RcXY6YHU2iOKgYSsSO0OM5ObHujbICrstETzRlWFoguCKWgrtETDdbmuK3B276tsM3Z4PY1YXeLTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m5ulshnAG3BFpvQEkE8QBtmECw2l2HwJEVbueGS9zg=; b=47LWurY/zdaUREBFIOzK349hy1h6gQj6PY19EKxj2fIX7sptx+z2AGlMrqBJltIlIkA3BYXuE+Zl86EwNBcW3zJp4HT8cHYG2URvWVeyTGi+DvO1LFUvsc/kfNlJokDefLgy41ExsguPcCjgPeXWLLXXWP25hpm1DaR2m/PAenE= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Topic: [PATCH v2] xen/evtchn: Add design for static event channel signaling Thread-Index: AQHYX91LOZcKc9ovCE+M72ipF+LMFK0YFGsAgAGzp4CAATSfgIAAXXOA Date: Thu, 12 May 2022 14:31:15 +0000 Message-ID: References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1b48fa47-9862-4e47-7a33-08da34241801 x-ms-traffictypediagnostic: VE1PR08MB4846:EE_|DBAEUR03FT043:EE_|DB7PR08MB3417:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dWnOfJb7uTcRiPVZBl5P85on6NJKGVME7HaEFI0EM9Pw5DlQIQp3wjrIZx4Q6K9Clr+lA0oY1jlEM+1jIO16KnUShUcIqCvsVkFv+hAskopQh4hzQCiIB18RnACAcOFzXrhrQIcrOWF40BMLCXSuXCY3DURy3URe1p/xZ7DzPF6l9/G3eO7g3dYkvQM4DI6Thrk4F7x1QxlIjF9N0/xNXldrZi2NxIUWx+wYVUUfMXfuqp3gN2BC67C19/By0Tiw7EEP1asZvM6WPhYx5yvdJLUzqs3JfjYnPy6nFxPSMBuICMjI7O2CMYT4ZJ2YkFbqZ62S3CSqvu8cLszdLxgtWJ0EtiGpQqgUojYBi6VL+fA9aR5q8M5UDV7aqjGWZuCqY7nITdKSp0tgbJz/KII/q8Vkb9yS94SkzcwdpRUDJmSpBIWm7YFGsCo+jtGaVg9Y2/fa2t61QqgWjUEA7iHTTHbxt2tDtBCI7XZ20e3SN6lAyIfMUSpq4/1eRb0leCpFyNpjy8ulbuyyooh26/eYfIz8Mgr3W/yq2bnWV6qal8+wSr3dsWlATq+f544wpD1CvzpKO03yUFgPEkIvThTq0QTggxLVPHJLh1MDyRYUZaCAIVpHZe1NBMZ+2M7jzIDOnrr+AwopsxPjvnYQGRv7WI1PJlqaOpRNhv2bKV48Jr5f3cu6C/acV8bu6pmP3jCVPDsFOpjNWAykZ9/r47Vo8T9AsqydkmLw5H2uCDV9YnHG0S5Uiwk1kj+Tj3NhLT1YjophDOs7yqf/5wL6FhRbc22+P4MwTUAuyGusmAnnotlNH3qdN2wEgLKguD97ZhXngOZ1d9Zd+WQ9DO4gUYUCiQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(966005)(86362001)(6506007)(6486002)(8936002)(71200400001)(53546011)(33656002)(2906002)(5660300002)(508600001)(83380400001)(38100700002)(6512007)(26005)(2616005)(38070700005)(122000001)(186003)(316002)(66476007)(66946007)(76116006)(91956017)(54906003)(66556008)(36756003)(6916009)(66446008)(4326008)(8676002)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4846 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 061dc5d2-72bf-4ae5-42c1-08da34241236 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I9Ti/A/ZbIUXaqeFSULniu23jb4taUlwspgAXf4RtVeG2QdUqjFDHtOqOAV6bg+XV1b7Vj1uyOHp7/dNKSocBe/UL2supRo9JjP2EgHZnvkiFoFAvCyxDEDxLZIvCRAb4AbvL9dSLqNMJIdKrYwUMfqQ6rQwzMDL/+p+L+lRFRtwMozZZwxiPwk/t7Hd+01BcHVMjxMTh0RiV3M6/ai7Gzpqx/MORRR8K9veceSrSoFu38ZRMVl1yUWY1U9pSOU4GkOcbYr9F+7KQVgFAGfNlnjDXnK9UJ6OxUzGOf1eRdw+cofvxufS5sorDX5cQk5qnO3670DrFZfi4YUDfQuDfcyNuvNLKqpgLHveS2e961Fv32U3GYHFfCB1IufELlBuEHBEOGcX6NRHBJc//M6YUTGtjJOJuGB9O2tFNaN/gnxGe04838mJxIiUxxKz29VGWGBgCWLsGEmMFdN2ExgrpbKDdPqmRkj0XeG0sdrmxqzNoyVWYlUHXhd6V9rWlwnJ3obX6dISa/9rcFa5G/sKxJT5nA23XLrV/Ry/8J2zlysyUN6EjSVY9HkZHX8IYyR0qFc1xVyWrzUh3WjSUBTk0d9ZC9c974QGJlxXBBl21Z4n1MimVoZx2visKLSKnDx+GjAs/fWapQwRQWJTJvlELwjKK8oeTriOtOEMFg1esNMt3XRZApmZEhb5dYqFDxvqQ7SRIuAaJQZgMMBr/wM60+24u4HC9piFaMltLWxwsSvB8EgEXD2e6k5k2dEYLGgNa+e9MfDyJ6gRzKa5ae2KFw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6862004)(4326008)(8676002)(70586007)(70206006)(6512007)(53546011)(6506007)(26005)(81166007)(86362001)(356005)(54906003)(40460700003)(36860700001)(508600001)(316002)(6486002)(966005)(2616005)(336012)(83380400001)(82310400005)(2906002)(47076005)(33656002)(186003)(36756003)(8936002)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:31:25.2407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b48fa47-9862-4e47-7a33-08da34241801 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3417 SGkgSnVsaWVuLA0KDQo+IE9uIDEyIE1heSAyMDIyLCBhdCA5OjU2IGFtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24gMTEvMDUv MjAyMiAxNTozMiwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4gT24gMTAgTWF5IDIwMjIsIGF0IDE6 MzIgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+PiArZG9tYWlu IG1heSB0b2dnbGUgbWFza2VkIGJpdHMgaW4gdGhlIG1hc2tlZCBiaXQgZmllbGQgYW5kIHNob3Vs ZCBjbGVhciB0aGUNCj4+Pj4gK3BlbmRpbmcgYml0IHdoZW4gYW4gZXZlbnQgaGFzIGJlZW4gcHJv Y2Vzc2VkDQo+Pj4+ICsNCj4+Pj4gK0V2ZW50cyBhcmUgcmVjZWl2ZWQgYnkgYSBkb21haW4gdmlh IGFuIGludGVycnVwdCBmcm9tIFhlbiB0byB0aGUgZG9tYWluLA0KPj4+PiAraW5kaWNhdGluZyB3 aGVuIGFuIGV2ZW50IGFycml2ZXMgKHNldHRpbmcgdGhlIGJpdCkuIEZ1cnRoZXIgbm90aWZpY2F0 aW9ucyBhcmUNCj4+Pj4gK2Jsb2NrZWQgdW50aWwgdGhlIGJpdCBpcyBjbGVhcmVkIGFnYWluLiBF dmVudHMgYXJlIGRlbGl2ZXJlZCBhc3luY2hyb25vdXNseSB0bw0KPj4+PiArYSBkb21haW4gYW5k IGFyZSBlbnF1ZXVlZCB3aGVuIHRoZSBkb21haW4gaXMgbm90IHJ1bm5pbmcuDQo+Pj4+ICtNb3Jl IGluZm9ybWF0aW9uIGFib3V0IEZJRk8gYmFzZWQgZXZlbnQgY2hhbm5lbCBjYW4gYmUgZm91bmQg YXQ6DQo+Pj4gDQo+Pj4gSSB0aGluayB0aGUgZXhwbGFuYXRpb24gaXMgZmluZSBmb3IgYSBkZXNp Z24gcHJvcG9zYWwuIElmIHlvdSB3YW50IHRvIHVzZSBpdCBhcyBkb2N1bWVudGF0aW9uLCB0aGVu IEkgd291bGQgc3VnZ2VzdCB0byBjbGFyaWZ5IHRoZXJlIGFyZSB0d28gZGlmZmVyZW50IEFCSSBm b3IgZXZlbnQgY2hhbm5lbDogRklGTyBhbmQgMkwuDQo+Pj4gDQo+Pj4gMkwgaXMgdGhlIGVhc2ll c3Qgb25lIHRvIGltcGxlbWVudCBhbmQgZm9yIGVtYmVkZGVkIHdlIG1heSB3YW50IHRvIHN0ZWVy IHRoZSB1c2VycyB0b3dhcmRzIGl0Lg0KPj4gSSB3aWxsIHJlcGhyYXNlIHRoZSBzZW50ZW5jZSBh cyBiZWxvdzoNCj4+IFhlbiBzdXBwb3J0cyB0d28gZGlmZmVyZW50IEFCSSBmb3IgZXZlbnQgY2hh bm5lbCBGSUZPIGFuZCAyTC4gTW9yZSBpbmZvcm1hdGlvbiBhYm91dCBGSUZPIGJhc2VkIGV2ZW50 IGNoYW5uZWwgY2FuIGJlIGZvdW5kIGF0Og0KPiANCj4gSSB0aGluayBpdCBpcyBhIGJpdCBzdHJh bmdlIHRvIHBvaW50IHRvIHRoZSBGSUZPIGRvYyBidXQgbm90IHRoZSAyTCAodGhlIGV4cGxhbmFu dGlvbiBhYm92ZSBpcyBub3QgcmVhbGx5IGZvciAyTCkuIElmIHRoZXJlIGFyZSBubyBkb2MgZm9y IHRoZSBsYXR0ZXIsIHRoZW4gSSB3b3VsZCBwb3NzaWJseSBkcm9wIHRoZSBsaW5rLg0KDQpBY2su DQoNCj4gDQo+Pj4+ICtUaGUgZXZlbnQgY2hhbm5lbCBzdWItbm9kZSBoYXMgdGhlIGZvbGxvd2lu ZyBwcm9wZXJ0aWVzOg0KPj4+PiArDQo+Pj4+ICstIGNvbXBhdGlibGUNCj4+Pj4gKw0KPj4+PiAr ICJ4ZW4sZXZ0Y2huIg0KPj4+PiArDQo+Pj4+ICstIHhlbixldnRjaG4NCj4+Pj4gKw0KPj4+PiAr IFRoZSBwcm9wZXJ0eSBpcyB0dXBsZXMgb2YgdHdvIG51bWJlcnMNCj4+Pj4gKyAobG9jYWwtZXZ0 Y2huIGxpbmstdG8tZm9yZWlnbi1ldnRjaG4pIHdoZXJlOg0KPj4+PiArDQo+Pj4+ICsgbG9jYWwt ZXZ0Y2huIGlzIGFuIGludGVnZXIgdmFsdWUgdGhhdCB3aWxsIGJlIHVzZWQgdG8gYWxsb2NhdGUg bG9jYWwgcG9ydA0KPj4+PiArIGZvciBhIGRvbWFpbiB0byBzZW5kIGFuZCByZWNlaXZlIGV2ZW50 IG5vdGlmaWNhdGlvbnMgdG8vZnJvbSB0aGUgcmVtb3RlDQo+Pj4+ICsgZG9tYWluLg0KPj4+IFBv cnQgMCBpcyByZXNlcnZlZCBhbmQgYm90aCBGSUZPLzJMIGhhdmUgbGltaXQgb24gdGhlIHBvcnQg bnVtYmVycy4NCj4+PiANCj4+PiBJIHRoaW5rIHdlIHNob3VsZCBsZXQga25vdyB0aGUgdXNlcnMg YWJvdXQgdGhvc2UgbGltaXRhdGlvbnMgYnV0IEkgYW0gbm90IHN1cmUgd2hldGhlciB0aGUgYmlu ZGluZyBpcyB0aGUgcmlnaHQgcGxhY2UgZm9yIHRoYXQuDQo+PiBJZiB5b3UgYXJlIG9rYXkgSSBj YW4gYWRkIHRoaXMgbGltaXRhdGlvbiBpbiB0aGlzIGRlc2lnbiBkb2MuDQo+IA0KPiBEZXNpZ24g ZG9jcyBhcmUgZ2VuZXJhbGx5IGZvciBkZXZlbG9wcGVyIG9mIFhlbiByYXRoZXIgdGhhbiB0aGUg ZW5kIHVzZXJzLiBJIGFtIE9LIGlmIHlvdSB3YW50IHRvIGFkZCB0aGUgbGltaXRhdGlvbnMgaW4g dGhpcyBkZXNpZ24gZG9jIHNvIGxvbmcgd2UgaGF2ZSBhbm90aGVyIGVhc3kgd2F5IGZvciB0aGUg dXNlciB0byBmaW5kIG91dCB0aGUgbGltaXRzLg0KPiANCj4gVGhpcyBjb3VsZCBiZSBlbmQgdXNl cnMgZG9jdW1lbnRhdGlvbiBhbmQvb3IgbWVzc2FnZSBpbiBYZW4uIE5vdGUgdGhhdCAyTCBoYXMg YSBsb3dlciBsaW1pdCBhbmQgd2UgZG9uJ3Qga25vdyBpbiBhZHZhbmNlIHdoYXQgdGhlIGd1ZXN0 IHdpbGwgdXNlLiBTbyB3ZSBtYXkgaGF2ZSB0byBhc3N1bWUgdGhlIGxvd2VyIGxpbWl0ICg0MDk2 KSB3aGljaCBzaG91bGQgYmUgcGxlbnR5IGZvciBlbWJlZGRlZCA6KQ0KDQpJIGFtIHBsYW5uaW5n IHRvIGV4cGxhaW4gdGhlIHN0YXRpYyBldmVudC1jaGFubmVsIHN1Ym5vZGUgaW4gImRvY3MvbWlz Yy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHTigJ0gWzFdLiBJIHdpbGwgaW5jbHVkZSB0aGUg bGltaXRhdGlvbiBhbHNvIGF0IHRoZSBzYW1lIHRpbWUuDQoNCkBTdGVmYW5vOiAgSSBuZWVkIGNv bmZpcm1hdGlvbiBmcm9tIHlvdSBhbHNvLCBpcyB0aGF0IG9rYXkgdG8gYWRkIG5ldyBwcm9wZXJ0 eSB2YWx1ZSAgInhlbixlbmhhbmNlZCA9IGV2dGNobuKAnSB0byBvbmx5IA0KZW5hYmxlIGV2ZW50 LWNoYW5uZWwgaW50ZXJmYWNlIGZvciBkb20wbGVzcyBkb21Vcy4gbWFrZV9oeXBlcnZpc29yX25v ZGUoKSB3aWxsIHNldCB0aGUgZXZ0Y2huIFBQSSBpbnRlcnJ1cHRzICBwcm9wZXJ0eSBvbmx5IGlm ICJ4ZW4sZW5oYW5jZWQgPSBldnRjaG7igJ0gaXMgc2V0Lg0KDQpJZiAieGVuLGVuaGFuY2VkIiB3 aXRoIGFuIGVtcHR5IHN0cmluZyAob3Igd2l0aCB0aGUgdmFsdWUgImVuYWJsZWTigJ0pIGlzIHNl dCBtYWtlX2h5cGVydmlzb3Jfbm9kZSgpIHdpbGwgc2V0IHRoZSBncmFudCB0YWJsZSwgZXh0ZW5k ZWQgcmVnaW9uIGFuZCBQUEkgaW50ZXJydXB0IHByb3BlcnR5Lg0KIA0KWzFdIGh0dHA6Ly94ZW5i aXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1ibG9iO2Y9ZG9jcy9taXNjL2FybS9kZXZp Y2UtdHJlZS9ib290aW5nLnR4dDtoPTdiNGEyOWEyYzI5M2QxNmU5MjgwYTI0Nzg5YmMzYjUyNjJh MzY3ZjY7aGI9SEVBRCNsMjM4DQoNClJlZ2FyZHMsDQpSYWh1bA== From xen-devel-bounces@lists.xenproject.org Thu May 12 14:49:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327795.550673 (Exim 4.92) (envelope-from ) id 1npA7m-0000oq-0j; Thu, 12 May 2022 14:49:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327795.550673; Thu, 12 May 2022 14:49:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npA7l-0000oj-TZ; Thu, 12 May 2022 14:49:05 +0000 Received: by outflank-mailman (input) for mailman id 327795; Thu, 12 May 2022 14:49:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npA7k-0000od-Ff for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:49:04 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0628.outbound.protection.outlook.com [2a01:111:f400:fe08::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9c5f669-d202-11ec-a406-831a346695d4; Thu, 12 May 2022 16:49:02 +0200 (CEST) Received: from AS8PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:20b:311::27) by AM0PR08MB2961.eurprd08.prod.outlook.com (2603:10a6:208:66::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Thu, 12 May 2022 14:48:57 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::6a) by AS8PR05CA0022.outlook.office365.com (2603:10a6:20b:311::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14 via Frontend Transport; Thu, 12 May 2022 14:48:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:48:57 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Thu, 12 May 2022 14:48:56 +0000 Received: from b42b8cf05718.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 707039D1-6917-4FA7-928B-AD7E3D56504C.1; Thu, 12 May 2022 14:48:45 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b42b8cf05718.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 May 2022 14:48:45 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by AM6PR08MB5240.eurprd08.prod.outlook.com (2603:10a6:20b:ec::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Thu, 12 May 2022 14:48:43 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Thu, 12 May 2022 14:48:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9c5f669-d202-11ec-a406-831a346695d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=e5m2M3vV49fiUFktbenOP1Y9fMcBTUowhNs8n74Hg8gPqPsXTy1dI2xdwj3jlTEDwOXZDk3iU8HRjKhcuBKKTSzPQR1TuHLhPifxYQXBqgZoME1eP0gm+Q5vIUBxFPrnOGuvgav9Vgfeiukoekc5/1GIhhn5fGkbGQTPYmOLLQuM7upVQhTwUBBBReaSrKQ3XlChasSRbbVDBCGTw8/Vcf7doAIshIfPxNEWWWu5xazBVyEPhIvoqt/bYP5AvScqGlxgGTOEe/S/ZqwJOv5y34/7BSXqGSbSFbVNjB5BPEYk7wHjyhCzn9/Gt6y3r7r+/40ZP3iF+b2w3mfki5FfCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LSR3rnBL8vFfYhYJKLbnoHxmOx7dXFv75WGJ+ZozHiM=; b=OMzTGRrHN8Zm7071vU6E4+oJH1gkGRW1In9e5XIfpZOGGKqCTn3A8jSo4x0SqyjVNEmzEx6F4Ov2VF8oTINkMNjTxF0qSF5rC41DDdab9j+I2UzQPLCgfQJG+mcW3hVN22dE0vKkFhg2xWIp6NE+QObJe3fbjnpofLyA3DZeJpBc6hsj4u+FH07RNPtn/E2iHw6HIS4jhP2bhF6TfM2Zhty0imY0srEwvktcAwH1v/GWM9WzrstCzJ337f+nNf/1HNzuPV47MnMv6n/NRoSTY0Z26O61bWjEP5w+zZ/3Id1eKjt4Zv3SuhPJ7JiYyMqIcFXbxXCXlTH8qE+sy60n0g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSR3rnBL8vFfYhYJKLbnoHxmOx7dXFv75WGJ+ZozHiM=; b=rqjMdUmwkYhUB53JMTCWcLqLQG+ieHOnkK6htLvDLuwH80HBAsbsM7aoMLLMnfx6FRaKdoN/0Q+Hjh1QRWqmStRpf7qt0y4cSm0Q7aDcSjHqFR4sswS+FF+RB6DapBSYScqtYobpdzy7ZTTfAMEzI5hgTokT/v5fW7VcyXsH5Dc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 19c464296615fc3a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoZ4P/3s6diGzNn5nzon9LqWS9QJ3ie9h9kPq3lZOsJmbEtzEWKuVjxKOEioQqOp9ecscG5/0Ai9x44ovUkjKwYqF9Hmzz4F1gcsauz91CJ+U3clf0eas5j4HCSBLnt91Gg782oIYNRJkpgM23YY9fNNxGXEGBX6B0WkEyf3fxopZq7tSq+KYy0DhIvqDgGL9El28TZvtSy16txnHGwkAcz9scRRYic91Ph1hh08RxoWn6rXHtrguMX/5GQlJGh7ePLN/Sb7XAwIyCLpE+ys4Rv3x7Kkz3Xl/zmJXbnk0E4EXnTTUocBCyF5LudpJfOtPc6YXeJgNswNgOjfX9k9XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LSR3rnBL8vFfYhYJKLbnoHxmOx7dXFv75WGJ+ZozHiM=; b=aj64HKONegfNQBVRfBFOPfF9Ri0NsRejZntVSpQ3Wp1omVXiJ/FKkKXCjfBi6m6gRXvCahCce1xSIfCLb4sbFXCIt1MzYHRg2wXVq70tybn+/en/eTyGatsqjScQbLLPYvTmgrsXlw6c8zgg4dWukMDNIQ5gFolP0oqkDKpb6k19AHhgxdf5TyN0zFJk5k/Z1iyj7r/9fx4O8jWukUUgOKwogSX/gxS6CQJZ5isFFQi2qSISDl9VsCuYOZO694obhbh9do5lslKTlxRK2AVsBQaSrQ1WCsJIlLBgaL1+c4AoKvU6Nox3eA7OWht+o7gGurTcxwVu98ZjSuDQyMcYog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSR3rnBL8vFfYhYJKLbnoHxmOx7dXFv75WGJ+ZozHiM=; b=rqjMdUmwkYhUB53JMTCWcLqLQG+ieHOnkK6htLvDLuwH80HBAsbsM7aoMLLMnfx6FRaKdoN/0Q+Hjh1QRWqmStRpf7qt0y4cSm0Q7aDcSjHqFR4sswS+FF+RB6DapBSYScqtYobpdzy7ZTTfAMEzI5hgTokT/v5fW7VcyXsH5Dc= From: Rahul Singh To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v7 1/2] xsm: create idle domain privileged and demote after setup Thread-Topic: [PATCH v7 1/2] xsm: create idle domain privileged and demote after setup Thread-Index: AQHYZSqefRP9ouSNjU+f65pQpb3T1K0bVGqA Date: Thu, 12 May 2022 14:48:43 +0000 Message-ID: <10F86570-D9AC-48C2-B4A3-A4CE3FB0D064@arm.com> References: <20220511113035.27070-1-dpsmith@apertussolutions.com> <20220511113035.27070-2-dpsmith@apertussolutions.com> In-Reply-To: <20220511113035.27070-2-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5d4ea6d7-0183-49cc-7a70-08da34268af2 x-ms-traffictypediagnostic: AM6PR08MB5240:EE_|AM5EUR03FT024:EE_|AM0PR08MB2961:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zkyQQpJwXcrC2Bp7MbPMCoFsMT1nXpNCpMeRaSLcFCoy0Alq/jaezg93PkZoKKVfAKrvVvTDTjPdEBszMJySe7aOmMf1IeSQCm/dKlD5HA+jXuWk/5Ye767TuneTBoDgRtGPaywc3Wlk0/lgvF06KGfzXNGDCe7s/zwuc68uaPL2sDdmj/XM/eRuYyOEdeiAvYlOUiwRj/ZGFUJ+UxMCM7XFEUnJDwMcEpJegysmU/pwcVYFPYSNau+bK/pRlpb+Uq6Lc1fwVG4QMa+1TgjhNapfOMLOLIy3+ygiQS2687L8tEHT1XtGhRfkOPbsvkvKmsG6S2jmhW3uOVo2yBFkKBiz4yr7WzKuJMJ8G4l9sr0/PShZyjRSoi55Dmb1iu0CEdPDVCRyCoFO2LDZ4uEULZa67RVsEBlbK6+b8SbHWQPauHE/uj+0HJNOORWnBC8Fi5f/Qy0fz+yEMqR6ORqyxgLq70snj9tSVKt6kJhCmxYqWSd00RpmPjjvr+FOe/HFQk4YjJrdJIAVYJok+GZPm4ePto0rqUcYHlJy48LMpGzc8elUJLYDza6G2heVWiBTYqLbaXmj72amPRrcZ1WNGROSTx4UtKPZUPs7zRT7m2kp9rpXIruBNifTj0qefx6108/fJen8kk5rafPpOWZD8yhGiGCiUmEwFkZzxIub3i60N5v/Lscp9JvsID73GqLxz/8Hhc8fjew2dQHB2HbAVgc6dAdeGMlM5CI3cA6Dpx9HorcQtlIikDR8jQVHSdEY X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2906002)(71200400001)(316002)(186003)(76116006)(64756008)(66556008)(66476007)(66946007)(91956017)(66446008)(8676002)(6486002)(83380400001)(5660300002)(33656002)(508600001)(8936002)(2616005)(7416002)(6512007)(26005)(122000001)(6506007)(53546011)(38070700005)(54906003)(6916009)(38100700002)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5240 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f20de80-d33f-4f1b-a332-08da34268311 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AbMa0S26JFSEcd0gzv/cbbpYQgwtZs32NF4JMatzvAF5eJ1MJbkYAKRoGli9QaNoQCgkS5jVPD3FLnM2xiIg62vURToz/azzGn6hBbciJbAjk6LAwo0i9gSgeTYCF8k/mmIziTaW+Uu2emFgc0uJ3oKe21sjhyF2SLZloteBnNSMFGkMDuCatizZ/SON3jVg1URID0uR21tEUcndbeFJ07+bA7ivJGw+gibc0shmypjFvuHxN2xvo8LPCtfoFp1x3GbpkQyyppneeJMAmfc55AFoDHA6Hhz22jUMjZIAEewNINqthiRlM9ujB+CMcFlu91oa77OsFckBGlOV+EEznpJyrrj6Ryw19IdhcgE8XrrF+HGWbRd9Ig6TJqmSVx9ySqeV5R1f1qBoy+ikShNsSzqpRNKmhfj+bkBC1AUV553bzFa++ZFiCJ8yNOsxZTfQeVnX+tKIlY6IhuxksMaeNA5TZIlzsafl6lafR0O4L0rnkNmsJALSe/GZZfozcsBFD62a1K7x+6Voe2zGQ961NleMiIdnQBpkeiVjZGWzjSAyLocLIPT2nClEaYAIxIRntdTB9xp0gPqmClWReTWQWYhuBDPsuA8SMzU9vkODYhcdwDeq40cCVPNA+9frndG5fuaL9JIwgZZLuHj72fQUQoDQFTx62xjV6XyOduRS7GKyAcll4ZsfL57101udAvxX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(82310400005)(6512007)(8936002)(6506007)(86362001)(26005)(6862004)(53546011)(186003)(4326008)(47076005)(336012)(83380400001)(70206006)(70586007)(5660300002)(8676002)(33656002)(2616005)(36860700001)(36756003)(356005)(54906003)(81166007)(40460700003)(6486002)(2906002)(508600001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:48:57.0113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d4ea6d7-0183-49cc-7a70-08da34268af2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2961 Hi Daniel, > On 11 May 2022, at 12:30 pm, Daniel P. Smith wrote: >=20 > There are new capabilities, dom0less and hyperlaunch, that introduce inte= rnal > hypervisor logic which needs to make resource allocation calls that are > protected by XSM access checks. This creates an issue as a subset of the > hypervisor code is executed under a system domain, the idle domain, that = is > represented by a per-CPU non-privileged struct domain. To enable these ne= w > capabilities to function correctly but in a controlled manner, this commi= t > changes the idle system domain to be created as a privileged domain under= the > default policy and demoted before transitioning to running. A new XSM hoo= k, > xsm_set_system_active(), is introduced to allow each XSM policy type to d= emote > the idle domain appropriately for that policy type. In the case of SILO, = it > inherits the default policy's hook for xsm_set_system_active(). >=20 > For flask a stub is added to ensure that flask policy system will functio= n > correctly with this patch until flask is extended with support for starti= ng the > idle domain privileged and properly demoting it on the call to > xsm_set_system_active(). >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk > Reviewed-by: Luca Fancellu > Acked-by: Julien Grall # arm Reviewed-by: Rahul Singh Tested-by: Rahul Singh Regards, Rahul > --- > xen/arch/arm/setup.c | 3 +++ > xen/arch/x86/setup.c | 4 ++++ > xen/common/sched/core.c | 7 ++++++- > xen/include/xsm/dummy.h | 17 +++++++++++++++++ > xen/include/xsm/xsm.h | 6 ++++++ > xen/xsm/dummy.c | 1 + > xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ > 7 files changed, 60 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed4..7f3f00aa6a 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offse= t, > /* Hide UART from DOM0 if we're using it */ > serial_endboot(); >=20 > + if ( (rc =3D xsm_set_system_active()) !=3D 0 ) > + panic("xsm(err=3D%d): unable to set hypervisor to SYSTEM_ACTIVE = privilege\n", rc); > + > system_state =3D SYS_STATE_active; >=20 > for_each_domain( d ) > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 6f20e17892..57ee6cc407 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -620,6 +620,10 @@ static void noreturn init_done(void) > { > void *va; > unsigned long start, end; > + int err; > + > + if ( (err =3D xsm_set_system_active()) !=3D 0 ) > + panic("xsm(err=3D%d): unable to set hypervisor to SYSTEM_ACTIVE = privilege\n", err); >=20 > system_state =3D SYS_STATE_active; >=20 > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 19ab678181..7b1c03a0e1 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -3021,7 +3021,12 @@ void __init scheduler_init(void) > sched_ratelimit_us =3D SCHED_DEFAULT_RATELIMIT_US; > } >=20 > - idle_domain =3D domain_create(DOMID_IDLE, NULL, 0); > + /* > + * The idle dom is created privileged to ensure unrestricted access = during > + * setup and will be demoted by xsm_set_system_active() when setup i= s > + * complete. > + */ > + idle_domain =3D domain_create(DOMID_IDLE, NULL, CDF_privileged); > BUG_ON(IS_ERR(idle_domain)); > BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu)); > idle_domain->vcpu =3D idle_vcpu; > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 58afc1d589..77f27e7163 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -101,6 +101,23 @@ static always_inline int xsm_default_action( > } > } >=20 > +static XSM_INLINE int cf_check xsm_set_system_active(void) > +{ > + struct domain *d =3D current->domain; > + > + ASSERT(d->is_privileged); > + > + if ( d->domain_id !=3D DOMID_IDLE ) > + { > + printk("%s: should only be called by idle domain\n", __func__); > + return -EPERM; > + } > + > + d->is_privileged =3D false; > + > + return 0; > +} > + > static XSM_INLINE void cf_check xsm_security_domaininfo( > struct domain *d, struct xen_domctl_getdomaininfo *info) > { > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index 3e2b7fe3db..8dad03fd3d 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t; > * !!! WARNING !!! > */ > struct xsm_ops { > + int (*set_system_active)(void); > void (*security_domaininfo)(struct domain *d, > struct xen_domctl_getdomaininfo *info); > int (*domain_create)(struct domain *d, uint32_t ssidref); > @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops; >=20 > #ifndef XSM_NO_WRAPPERS >=20 > +static inline int xsm_set_system_active(void) > +{ > + return alternative_call(xsm_ops.set_system_active); > +} > + > static inline void xsm_security_domaininfo( > struct domain *d, struct xen_domctl_getdomaininfo *info) > { > diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c > index 8c044ef615..e6ffa948f7 100644 > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -14,6 +14,7 @@ > #include >=20 > static const struct xsm_ops __initconst_cf_clobber dummy_ops =3D { > + .set_system_active =3D xsm_set_system_active, > .security_domaininfo =3D xsm_security_domaininfo, > .domain_create =3D xsm_domain_create, > .getdomaininfo =3D xsm_getdomaininfo, > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 0bf63ffa84..54745e6c6a 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(stru= ct domain *d) > return 0; > } >=20 > +static int cf_check flask_set_system_active(void) > +{ > + struct domain *d =3D current->domain; > + > + ASSERT(d->is_privileged); > + > + if ( d->domain_id !=3D DOMID_IDLE ) > + { > + printk("%s: should only be called by idle domain\n", __func__); > + return -EPERM; > + } > + > + /* > + * While is_privileged has no significant meaning under flask, set t= o false > + * as is_privileged is not only used for a privilege check but also = as a type > + * of domain check, specifically if the domain is the control domain= . > + */ > + d->is_privileged =3D false; > + > + return 0; > +} > + > static void cf_check flask_domain_free_security(struct domain *d) > { > struct domain_security_struct *dsec =3D d->ssid; > @@ -1766,6 +1788,7 @@ static int cf_check flask_argo_send( > #endif >=20 > static const struct xsm_ops __initconst_cf_clobber flask_ops =3D { > + .set_system_active =3D flask_set_system_active, > .security_domaininfo =3D flask_security_domaininfo, > .domain_create =3D flask_domain_create, > .getdomaininfo =3D flask_getdomaininfo, > --=20 > 2.20.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Thu May 12 14:49:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:49:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327799.550685 (Exim 4.92) (envelope-from ) id 1npA8V-0001J3-AL; Thu, 12 May 2022 14:49:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327799.550685; Thu, 12 May 2022 14:49:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npA8V-0001Iw-7X; Thu, 12 May 2022 14:49:51 +0000 Received: by outflank-mailman (input) for mailman id 327799; Thu, 12 May 2022 14:49:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npA8T-0001Fg-Av for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:49:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1a::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be7a7efe-d202-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 16:49:37 +0200 (CEST) Received: from DB6P191CA0010.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::20) by VI1PR08MB5536.eurprd08.prod.outlook.com (2603:10a6:803:13b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 12 May 2022 14:49:45 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::b9) by DB6P191CA0010.outlook.office365.com (2603:10a6:6:28::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14 via Frontend Transport; Thu, 12 May 2022 14:49:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:49:44 +0000 Received: ("Tessian outbound 42cead292588:v119"); Thu, 12 May 2022 14:49:44 +0000 Received: from dfa43a87206a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 743E7938-89AC-428A-8762-2FA9EB33EE2D.1; Thu, 12 May 2022 14:49:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dfa43a87206a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 May 2022 14:49:38 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com (2603:10a6:5:1e::14) by AM6PR08MB5240.eurprd08.prod.outlook.com (2603:10a6:20b:ec::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.20; Thu, 12 May 2022 14:49:36 +0000 Received: from DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac]) by DB7PR08MB2986.eurprd08.prod.outlook.com ([fe80::c93a:3b90:5380:ddac%3]) with mapi id 15.20.5227.023; Thu, 12 May 2022 14:49:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be7a7efe-d202-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ps987oW8EXj3l6pY4huZe8VoZ2PUTyD2wr1r9V11rPahe6HvzTIicrwvxTujfPLffisfst3WqWLx+TMJKGXzRwyYmZntDhcMUVhGaoTnNxh8Ni0ZGEVHuusvngqR2av4PnY8jO6wY5rDpk3rS975+AAgT1zDouzq06Ll83lPkzEYR8ZtfWnfr+CRGKK+VwtyjGaWTzI0Y4Lg76Zl1+BUwDC2H8aNSvPzkFMXFzAYSTc2t9EnvXMh63yIHVtBp9Un/VTVzOyKURAGacuOYHHzdePwh9TTNRZsiCKJGHHVViV0nLD1ogKI/TnWUpG8vaX/D3ThuUZdNJaj2pBqIaYFlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R34zatSsJDgZlU2Csru8AdOxDWJ7Q+JOYSjBjoXRWW8=; b=NW5j5wXyP+FHzAyOYDsixgkqqhvtrhF5k7loJjE2xVzns4S90QAjJ01y3x2319qsdEKo8j93NakqFcRK1iat4I4SpsJa7awyb5DD8ZCSQ/RTrp4YUBQ+UkuCH9JlUvrPgqhu26nL0QUDmsLebzy4rjdivnfbLRQ6T827vr3MkHx3BlAjd4udJ2YNB3ibU0aPKTLtVrgG903utHL7yPoWMbaxvfXipA1B5UP3WhsQnJ2bhdm4dQZGzHopLvbBr75sBp0JGyN8tIJuFzV5FXDkv1uAgALl0P4UfS9gdkrpqjTBOQ/e4rMjlqV1b+0+IV6IC+ZPFtMHgnZD6BsqWwbo9A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R34zatSsJDgZlU2Csru8AdOxDWJ7Q+JOYSjBjoXRWW8=; b=CaumP5FhnLEpjdE57bIvSUBrgmEL60D+XFgmP+2FKATZnNEysh6QFdLu5LgowhLwmaEKLTjabCIVwkzMIAFea4yigTE/E570BYkF9y+F4lDnhXiOrxsISAQ3cX4fwH5QQscGMb0j8X+m0cCeMaGiLrsp5aGGgSt+TK8iu74RRHw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 083ef4c27f377e7b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEWBAAlyqb/lFn+xG/w8ILzj3etTzIjCT4bdDfDj60v8aikPSxlgJ1ZCFN/Vf27mrIIOjZOaFr0pjjk9ZAgnbT3ckPVAm/zQr2j7OVu2Sywq/xsuzGbZpds1+4B47HOXVA9Q4ndKFYHi/wTIhPbHMUiV5ZS9pUOSDqgw8LqONB6xtL9xevq0O3umTt2gefc7YmYtRZvsrXiradyO0hnsnNzb5XORRqln+BOuTLBp4nxug5B7iupOxgzMIgzivvaauEAu4O8QrOFJ8GWWNZdiLUfbfd/0/VMp463VafuGJQVx1Qqupo0pRhNYSezGPFDGk3i+p8ijzuLe0djsBSKzlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R34zatSsJDgZlU2Csru8AdOxDWJ7Q+JOYSjBjoXRWW8=; b=XXw4qZB+yCz38/evpZBp2Fj/CrPnBdxVd4chNXASm+L14H3qPv31W1m/gOyeD2ZUMgrLiGts9w/ZX8spN+YEmVVJXOSPac6h71b+UtojeruGF2yFBFhidNb63+811hB+12IPhtcpjjzTI1zBhxTlXkbAXg9/MeJXafWNkxGke8xcq547pqR8EEbYfpAoXCWF6EWzqXzNwLLt+0dBDe8QDoKtUkXCJBs5/NGTbN+IL1yK1ZLQwh0VmQkaW+cfdPGg/8KCjjFoI6EZr9U7TUChJeJz2NisK7IV6HpOEc14ZH/8yveGXlz4gbBljYLQaSJXOO/nD6TQXTB1+YKPv6aNyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R34zatSsJDgZlU2Csru8AdOxDWJ7Q+JOYSjBjoXRWW8=; b=CaumP5FhnLEpjdE57bIvSUBrgmEL60D+XFgmP+2FKATZnNEysh6QFdLu5LgowhLwmaEKLTjabCIVwkzMIAFea4yigTE/E570BYkF9y+F4lDnhXiOrxsISAQ3cX4fwH5QQscGMb0j8X+m0cCeMaGiLrsp5aGGgSt+TK8iu74RRHw= From: Rahul Singh To: "Daniel P. Smith" CC: xen-devel , "scott.davis@starlab.io" , "jandryuk@gmail.com" , "christopher.clark@starlab.io" , Luca Fancellu , Daniel De Graaf , Wei Liu , Anthony PERARD Subject: Re: [PATCH v7 2/2] flask: implement xsm_set_system_active Thread-Topic: [PATCH v7 2/2] flask: implement xsm_set_system_active Thread-Index: AQHYZSqr0Uc8/+XCjEWwTmvXksGA0K0bVKoA Date: Thu, 12 May 2022 14:49:36 +0000 Message-ID: <7565B32C-66DD-4820-8D5E-3A62FE87008C@arm.com> References: <20220511113035.27070-1-dpsmith@apertussolutions.com> <20220511113035.27070-3-dpsmith@apertussolutions.com> In-Reply-To: <20220511113035.27070-3-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 77299bcb-547d-4e95-0794-08da3426a752 x-ms-traffictypediagnostic: AM6PR08MB5240:EE_|DBAEUR03FT062:EE_|VI1PR08MB5536:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xv94xlHJiLPdl7yoNxe8GfGKvVO9HWgdFZx4wxIi0N2d4x+PYmvbOAAIzcCN3e+rDTSgP85aCMQXBNRSxfThdiNwcLpUp7L1/hzSDLyUPcjslWLElHpXXITA96VjznpiikCRvUhLPeN/B7Vx6sZMP5ZUkW/r5bzMOQlvIsxJEsFQJvDP/u04jBz/RGGUS0KaYwEmepLz/9Ipbp16cqIJuRorwZbZgL5gA7N5ta65MOI8dt5OQUyCBVZ96dJY00Vg68OVxvlI/4xgH96PLjjbLrCXRyWbdqLzB/S2uCLwwi8mUVtYoNA2yg3eWpxF5sfCESp0gnVntG4zrQIf+rXycHM1PJ4LTbxymygrM5U4DmFdVgcjAMjry1dWcHd+ds75N5MdTF5Jr4j5DC0mhD06Pt/pcoGsrVNHLtr903DmFRYcnjf78oWxiCx2cm+2xQTXZviTJBMfbR6YhXTsF7r3uhk7VeYpv2m6m0aVj+2PUJx+beqPQ6glOKIkID7cYxbKjmfSpP8aRHYrwxxlQYSoEZML07XIatgoHAIwxOgwV0whaaLmMFu1mxKAAGqcTEmB9o9ZHCm6asdgxz/6GKZ3EFVEbm8wzC8LSBWSAgMQLzkZa93y4We+I635Wcx2P7uGHqGjdCjP7qBoh9uDE+9jqR3ZpP3VrYL5QbD2phRTF4UYTyB4usS6C36uhwDEfPrqudSjP3Luhl6FLPljXKF3Rp299Rm2ydOgf/yOSk/eqQOH+NbJAmttQU2yLKKKvL5f X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB2986.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(2906002)(71200400001)(316002)(186003)(76116006)(64756008)(66556008)(66476007)(66946007)(91956017)(66446008)(8676002)(6486002)(83380400001)(5660300002)(33656002)(508600001)(8936002)(2616005)(6512007)(26005)(122000001)(6506007)(53546011)(38070700005)(54906003)(6916009)(38100700002)(86362001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5240 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3a1cc5cc-7263-4f1d-25b4-08da3426a26a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Vpt9YWS7wSxhV72tG4YyP7DRXrYwNJuIbcbKRF8VCnP5z0J/3JigmyyXz7DYOqZpw3DvG5R4eFgLCp6vWkQ3KcrnB9SDRGhgzSRHfHydfTJZml5YjQcSL4u+0pskwmeG0pSHFhKiyCa1hHKZPt0lbGyUZ6qEWUU23xVVvcqb5D/04RxzyK9joL+sY3Vh8HPJGCBmreMucL87HpqtgSpi7g+1VSwzwDpq6IhnmB7d/LtzrNR+ViZj4C+VzVnyb2KzO5QpkCChrDNBNxG3RCmPlzdyOqvj2kHRz61CWqzfbaw7vHv3OMFUR1CxkrIAXvg0O8fr12QFB5rdul67v0dV4zcULv1AToeUL3pQHt20NohJk9wXE8Y/yZWYSXv3XTovVfemvhNIWsB3ZES6gX6wpgAGy7lXbsjlXQe3GCLWiJ4S9oOgSML+R1F0fKodB/dRiC0jT0tvmczgx+/QQAExGlmi7iN3riknIwubT0OYCcxXpXYoeQJaQrgfarsPpWY5XQ1tLMVvkBx+M94ft9E3osvlWa+OsMLJvQmnd0nKowrlizRk0IuT2frqylxznGGs5MTnHbLZyjPLn/GmhgZrZGydxFJo7DUF82oC9u/Vd9SjNIPtgFo3iRp9icA3LCgS0X3LaMgp1rQm/PZVK9Y7+W4+AQ/g1wEoQBpKi3OjD/crDCBJAwSjZT3pKgiJtM8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(316002)(6486002)(2906002)(36860700001)(36756003)(6506007)(356005)(53546011)(81166007)(82310400005)(508600001)(47076005)(86362001)(2616005)(336012)(107886003)(6512007)(26005)(8936002)(70206006)(70586007)(40460700003)(5660300002)(33656002)(8676002)(83380400001)(186003)(54906003)(4326008)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:49:44.6762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77299bcb-547d-4e95-0794-08da3426a752 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5536 Hi Daniel, > On 11 May 2022, at 12:30 pm, Daniel P. Smith wrote: >=20 > This commit implements full support for starting the idle domain privileg= ed by > introducing a new flask label xenboot_t which the idle domain is labeled = with > at creation. It then provides the implementation for the XSM hook > xsm_set_system_active to relabel the idle domain to the existing xen_t fl= ask > label. >=20 > In the reference flask policy a new macro, xen_build_domain(target), is > introduced for creating policies for dom0less/hyperlaunch allowing the > hypervisor to create and assign the necessary resources for domain > construction. >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk > Reviewed-by: Luca Fancellu > Tested-by: Luca Fancellu Reviewed-by: Rahul Singh Tested-by: Rahul Singh Regards, Rahul > --- > tools/flask/policy/modules/xen.if | 6 ++++++ > tools/flask/policy/modules/xen.te | 1 + > tools/flask/policy/policy/initial_sids | 1 + > xen/xsm/flask/hooks.c | 9 ++++++++- > xen/xsm/flask/policy/initial_sids | 1 + > 5 files changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modul= es/xen.if > index 5e2aa472b6..4ec676fff1 100644 > --- a/tools/flask/policy/modules/xen.if > +++ b/tools/flask/policy/modules/xen.if > @@ -62,6 +62,12 @@ define(`create_domain_common', ` > setparam altp2mhvm altp2mhvm_op dm }; > ') >=20 > +# xen_build_domain(target) > +# Allow a domain to be created at boot by the hypervisor > +define(`xen_build_domain', ` > + allow xenboot_t $1_channel:event create; > +') > + > # create_domain(priv, target) > # Allow a domain to be created directly > define(`create_domain', ` > diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modul= es/xen.te > index 3dbf93d2b8..de98206fdd 100644 > --- a/tools/flask/policy/modules/xen.te > +++ b/tools/flask/policy/modules/xen.te > @@ -24,6 +24,7 @@ attribute mls_priv; > #########################################################################= ####### >=20 > # The hypervisor itself > +type xenboot_t, xen_type, mls_priv; > type xen_t, xen_type, mls_priv; >=20 > # Domain 0 > diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/= policy/initial_sids > index 6b7b7eff21..ec729d3ba3 100644 > --- a/tools/flask/policy/policy/initial_sids > +++ b/tools/flask/policy/policy/initial_sids > @@ -2,6 +2,7 @@ > # objects created before the policy is loaded or for objects that do not = have a > # label defined in some other manner. >=20 > +sid xenboot gen_context(system_u:system_r:xenboot_t,s0) > sid xen gen_context(system_u:system_r:xen_t,s0) > sid dom0 gen_context(system_u:system_r:dom0_t,s0) > sid domxen gen_context(system_u:system_r:domxen_t,s0) > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 54745e6c6a..80b36cc2d8 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struc= t domain *d) > switch ( d->domain_id ) > { > case DOMID_IDLE: > - dsec->sid =3D SECINITSID_XEN; > + dsec->sid =3D SECINITSID_XENBOOT; > break; > case DOMID_XEN: > dsec->sid =3D SECINITSID_DOMXEN; > @@ -188,9 +188,14 @@ static int cf_check flask_domain_alloc_security(stru= ct domain *d) >=20 > static int cf_check flask_set_system_active(void) > { > + struct domain_security_struct *dsec; > struct domain *d =3D current->domain; >=20 > + dsec =3D d->ssid; > + > ASSERT(d->is_privileged); > + ASSERT(dsec->sid =3D=3D SECINITSID_XENBOOT); > + ASSERT(dsec->self_sid =3D=3D SECINITSID_XENBOOT); >=20 > if ( d->domain_id !=3D DOMID_IDLE ) > { > @@ -205,6 +210,8 @@ static int cf_check flask_set_system_active(void) > */ > d->is_privileged =3D false; >=20 > + dsec->self_sid =3D dsec->sid =3D SECINITSID_XEN; > + > return 0; > } >=20 > diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/ini= tial_sids > index 7eca70d339..e8b55b8368 100644 > --- a/xen/xsm/flask/policy/initial_sids > +++ b/xen/xsm/flask/policy/initial_sids > @@ -3,6 +3,7 @@ > # > # Define initial security identifiers=20 > # > +sid xenboot > sid xen > sid dom0 > sid domio > --=20 > 2.20.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Thu May 12 14:52:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 14:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327808.550696 (Exim 4.92) (envelope-from ) id 1npAAb-0002o0-VD; Thu, 12 May 2022 14:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327808.550696; Thu, 12 May 2022 14:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAAb-0002nt-R0; Thu, 12 May 2022 14:52:01 +0000 Received: by outflank-mailman (input) for mailman id 327808; Thu, 12 May 2022 14:52:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAAa-0002nl-As for xen-devel@lists.xenproject.org; Thu, 12 May 2022 14:52:00 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b0ce3ff-d203-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 16:51:48 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local (return-path ijackson@chiark.greenend.org.uk) id 1npAAW-00033H-38; Thu, 12 May 2022 15:51:56 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b0ce3ff-d203-11ec-8fc4-03012f2f19d4 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <25213.7948.2636.838505@chiark.greenend.org.uk> Date: Thu, 12 May 2022 15:51:56 +0100 To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH] osstest: update Debian Buster install CD media to 10.12 In-Reply-To: <20220502151448.19578-1-roger.pau@citrix.com> References: <20220502151448.19578-1-roger.pau@citrix.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) Roger Pau Monne writes ("[PATCH] osstest: update Debian Buster install = CD media to 10.12"): > Signed-off-by: Roger Pau Monn=E9 Acked-by: Ian Jackson Is this just a routine update, OOI, or was this to fix something ? Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu May 12 15:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 15:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327821.550707 (Exim 4.92) (envelope-from ) id 1npAYT-0005FH-S2; Thu, 12 May 2022 15:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327821.550707; Thu, 12 May 2022 15:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAYT-0005FA-Od; Thu, 12 May 2022 15:16:41 +0000 Received: by outflank-mailman (input) for mailman id 327821; Thu, 12 May 2022 15:16:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAYS-0005F0-Pm; Thu, 12 May 2022 15:16:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAYS-0001gr-Lo; Thu, 12 May 2022 15:16:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAYS-0008N5-8g; Thu, 12 May 2022 15:16:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npAYS-0004tR-8J; Thu, 12 May 2022 15:16:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C4Ad2bx3Utn60dXuHbqe9q/6zdCuVcZUF1BdEx+Cft4=; b=vVPI6L0ZbyHI+yUCzYzC9jlgsI 4ahe8zYgUv3XL022W/iaJKwTfuLknkB1fudU+zF9uGTraHDRFSoJCdcACQ77PQ/tVDLXutJuwULqI Pjb3QDpT0Tu4H42pm37lkNb6KVae7z1f6xyTAnerYDuxg/kvB1rTA+7Q1FpWo/oWRQf4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170353: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=01565c91b789a1612051e735a65f11096a6f08e8 X-Osstest-Versions-That: linux=1d72b776f6dc973211f5d153453cf8955fb3d70a From: osstest service owner Date: Thu, 12 May 2022 15:16:40 +0000 flight 170353 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170353/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170264 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170264 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170264 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170264 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170264 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170264 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170264 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170264 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170264 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170264 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170264 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170264 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 01565c91b789a1612051e735a65f11096a6f08e8 baseline version: linux 1d72b776f6dc973211f5d153453cf8955fb3d70a Last test of basis 170264 2022-05-09 07:12:58 Z 3 days Testing same since 170353 2022-05-12 10:41:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Andreas Larsson Andrei Lalaev Andrew Morton Armin Wolf Bartosz Golaszewski Bob Moore Charles Keepax Cheng Xu Chengfeng Ye Christian Loehle Codrin Ciubotariu Daniel Hellstrom David S. Miller David Sterba Duoming Zhou Eric Dumazet Erik Kaneda Felix Kuehling Filipe Manana Florian Fainelli Francesco Ruggeri Greg Kroah-Hartman Guenter Roeck Haimin Zhang Helge Deller Hulk Robot Ido Schimmel Ivan Babrou j.nixdorf@avm.de Jakob Koschel Jakub Kicinski Jan Höppner Jason Gunthorpe Jens Axboe Jiazi Li Jiazi Li Johannes Nixdorf Jon Hunter Lee Jones Linus Torvalds Linux Kernel Functional Testing Lorenzo Pieralisi Maciej W. Rozycki Marc Kleine-Budde Marek Behún Mark Brown Michael Chan Mike Snitzer Mikulas Patocka Minchan Kim Niels Dossche Nobel Barakat Ovidiu Panait Pali Rohár Paolo Abeni Paolo Bonzini Radhey Shyam Pandey Rafael J. Wysocki Ricky Wu Sandipan Das Sasha Levin Sergey Shtylyov Shravya Kumbham Shuah Khan Somnath Kotur Stefan Haberland Sudip Mukherjee Takashi Iwai Takashi Sakamoto Thomas Bogendoerfer Thomas Gleixner Thomas Pfaff Trond Myklebust Ulf Hansson Vegard Nossum Wanpeng Li Yang Yingliang Zheyu Ma jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 1d72b776f6dc..01565c91b789 01565c91b789a1612051e735a65f11096a6f08e8 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu May 12 15:25:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 15:25:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327830.550718 (Exim 4.92) (envelope-from ) id 1npAhC-0006hG-PG; Thu, 12 May 2022 15:25:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327830.550718; Thu, 12 May 2022 15:25:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAhC-0006h9-MK; Thu, 12 May 2022 15:25:42 +0000 Received: by outflank-mailman (input) for mailman id 327830; Thu, 12 May 2022 15:25:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAhB-0006gy-DT; Thu, 12 May 2022 15:25:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAhB-0001q7-9H; Thu, 12 May 2022 15:25:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npAhA-00006m-W4; Thu, 12 May 2022 15:25:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npAhA-0007Ya-Vc; Thu, 12 May 2022 15:25:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rwAcldUfSp9hr0u5jgCRthWOPvkaWOJQCvjJZ/S3hlc=; b=b0qmyWI9wkM8VT8PlUxFHUl16P WePf7I4dQtMgRNN2IQYwTrVplsv5YrxnWfoMAx9+CxF9k/6GaApuyWD52voI2b5i77kCU6/JvMpgg 58ZveT3ipfeUKEGKV7zfJKyonuGRXiFLnNdtH3kJRzX4N9bQOv5f6+Ktz/+c+oLCRoDY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170358: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 15:25:40 +0000 flight 170358 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170358/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 963 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 15:55:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 15:55:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327852.550733 (Exim 4.92) (envelope-from ) id 1npB9T-0001cc-Ay; Thu, 12 May 2022 15:54:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327852.550733; Thu, 12 May 2022 15:54:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npB9T-0001cV-6u; Thu, 12 May 2022 15:54:55 +0000 Received: by outflank-mailman (input) for mailman id 327852; Thu, 12 May 2022 15:54:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npB9S-0001cK-6f for xen-devel@lists.xenproject.org; Thu, 12 May 2022 15:54:54 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db8ebf7b-d20b-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 17:54:52 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 May 2022 11:54:25 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by MN2PR03MB4781.namprd03.prod.outlook.com (2603:10b6:208:ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Thu, 12 May 2022 15:54:23 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.013; Thu, 12 May 2022 15:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db8ebf7b-d20b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652370892; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=M6DFv98rSUDslMM/jbjOuQqpHVNLgUf7Keu1HTAwI2o=; b=K0tkLPFZ61uMW/F+5fti87yWi6pdzMZchuIi1CyAQhY3W7U+39SAyEsN qt9/YGFWjwyL/npHFTUHGu5LqF65zodwUNVkd0LTxpQpFmMjfwyecVKYO eP8AUCesMwn3mxbtOV1srpBpT6Mp2evO6jo56rfBIeKLroKV9UKokQ5Ng s=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 71173517 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jWdECaMf1SVZBODvrR1mlsFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem TxOHSzEb+HbITHFz+oGOdyw9EoHvpLSzNNhTgVoqC42QnkXo5rJWI7DIh6pYXrPdMeeQU4+t shBY4edcpBlQHOMq071buTq93Qmiq/WS9IQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl6 I7585OONgD7gWMoOG4fsKzS8Egytq2r5GtJtQM3O/0a4FOGm3crV59OfqvZw1kU42V38kxWY 86ZkdlVK0uAp09F5uuNy+q9KgtQKlLrFVDmZkB+AsBOuTAf4H1rukoHHKBEMx0P1mzTx4oZJ Ohl7vRcdy94ZsUgp8xFO/VoO3kW0XpuoeKvzdCX6KR//mWeG5fe66wG4HIeZOX0zt1fE2BWn cH0HRhWBvy1a0Ba95rgIgVkrpxLwMAGp+rzsFk4pd3SJa5OrZwu38wmTDKXtds9rpkmIBrQW yYWQTlFXSTKaT9kBkYsFbwTpOOogVv+ahQN/Tp5pYJvi4TS5CpY9eG1dfbwJJmNT8gTmVuEr GXb+Wi/GgsdKNGU1TuC9DSrm/PLmiT4HokVEdVU9NYz2AHVmjNVVU1QDAPnyRW6ohfWt9Z3B EET4CUj64Qv8kiiVvH2XgGioW7CtRkZMzZVO7JjsV7Wl/OLi+qfLkkdUTNTZYUUjdIdHC5zz kWRmdPEOgU65dV5TlrYrN94twiaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cQwc2 BiPpSk6wrkW08gC0vzj+Uid2mrw4J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1TdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:SegidKxDtNrZVcVmf8sNKrPxmeskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTnyAtj6fZq8z+8+3WB1B9uftWbdyQ+Vxe1ZjLcKhgeQYhEWldQtmJ uIEZIOb+EYZGIS5amV3OD7KadH/DDtytHKuQ6q9QYJcegcUdAD0+4WMGamO3wzYDMDKYsyFZ Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWLiIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH53KO+qPu2oyWsmVM7rq4m2ecJ+OEzR/BkufJlaAkETTzYIbiJbofy/AzdZtvfrGrC3u O85CvIdP4DkU85NlvF3CcFnTOQnArGokWStmOwkD/tp9f0Syk9DNcEjYVFcgHB405lp91k1r lXtljp/qa+nXv77VjADvXzJmZXf3CP0AwfeC8o/g9ieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou W1bLp1jx9CR6u1M7zx4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT X-IronPort-AV: E=Sophos;i="5.91,220,1647316800"; d="asc'?scan'208";a="71173517" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KWCd5xUNUxU3N0Nm9NGGUSESX7/NKTr7AnujnaAm6GH4IDjDoJhBtwDmWm+sAvQFqnqSZZZ44ZGYgh2BWKdUDeCz2pbWC8Kn/2QWWHHbd8el2HU+dUq7Aabfo+CFTo2kc+3LrEnY7FNmlofn88HEjpVKz84vjHxNJhCVGvqCSeFl3xfhGDlld3CRDbbeB1HazCyGc2gzkdoq+VuBqHwOILuLzauN9ajKASy5K0OBq/OPLXBROjCHIokU29I/kNcWBdfc/0533TGbSb1nAi6YbjWVMJKjeKRuGJ6NHPQEfJgEBzBQhU23IVEr+1DKgk+kSjW5pFkHslSJwrrcP/fX9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ypHvH+wwF3GZMLF8U3YypIb5nOEeFBb8deuTjYQHWuo=; b=BhvUMny4i5VgnOtdMUcNyTwkiiSD+1QdBasYnSKWzOBWfkqyC7vBD7FBHB2Vq4CVMREJyhvY1w70nMzOAaRjLYhmwdY3Ccb/uGW61RR5P8ISxNXkjJAxACEdzp47eeoTXdFG8RbMfEDp/3WnWGu0ikI/YpokQUafe3D4zER0BABQZCTyyXlLsMGL2/46gRH6Sjjsdc28T8erGmNfoCUgZ09XHAt8Mf8MlqCEtTqCaGQwgMQ4swBgNFhpTTEP+3yeLPDRUDHGdJJCXSW1+vk2M26fmgl/HEnIkrSQEMCg4iutVn2drUlru9njbr2E2wo0zw2T/plkQgNoikjFcZWmJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ypHvH+wwF3GZMLF8U3YypIb5nOEeFBb8deuTjYQHWuo=; b=xjcB4TqMr4+/eLf4kNO6IJe5X0zU+wd7l55NT6qgxmPBCYOwFFpCsQiVnQ598nAiDKdwkZ9VeTheTEg1UITi9WUdQoUoo/Clq2lkHzN2iPPWw9mccXgu3ROKtwhSj/VPkRBiXf8jd3ABhJzBtTYwUrNHEW7ScrZWTp5at3aVPas= From: George Dunlap To: xen-devel Subject: Re: PROPOSAL: Delete www-archive.xenproject.org Thread-Topic: PROPOSAL: Delete www-archive.xenproject.org Thread-Index: AQHYUBdKGkaQLBb2wkOW+P2/BX0raa0bkOkA Date: Thu, 12 May 2022 15:54:23 +0000 Message-ID: <8DD705C9-2878-4F22-BEEC-82619857C702@citrix.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cce1187a-c83c-4adc-9bb7-08da342faf24 x-ms-traffictypediagnostic: MN2PR03MB4781:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ghGg5iMciN1lT0Dd1mMmSSvw8Q8nMaoOfXtdTa5L3LF7eoHhWjFsNukXmHlyQCOA8MvmRhs5xYkToeYtNGi4sRXDpyT0AK5VgQ0DTx8uKzrB3w5HZgbZ3GhxJ2OSepC8ZBiBFZ3Yi1xXFAX/opLc2geYIj3qLZ0Lu8Ekdrr6Wl7X4fZkTyh9gYGLw8J+78xcYXQfNE2ggO3DSFNtRa0G6FYC25SG5v8lUIW8guX+S7Hc0clW6YwkAvEWLuxgLz/XbjDkvCbmJT3CHh30ZexoE5FKifyZ1xxFwTm6RBB2BnXWspxvcJZZAawMHvIYT3xbJD7vHnXtK+FWSDC7La09SlJdGY8ml9cirgGhsCpLg89Cd7yGfNAq0CO0GM3aNb7bbqtjbZ7s1v9yNfjJk+q/5o8X/RqweLFmcod+LH4N1qZ5NSP4if6jhL9JRi5tunrTsdxL8boq/WGrMVtpDlNA0vZYC3jvSfaxUt8XtrdiVnGj9a3V/y+BczH3147yU7lSf2ugGUCadc9A8V2NK03i9RMKxVvokHsREol0lpexzERsx+26otzweYM8fiOtgid5oaHqC5iSh2jGm+tylxiyYunwZhgDslzxTaXxtFxtV5mWXzw0UhwCsy8kv0UOw0dQizUKn5GN1VZmAItu+6xtX3eO0EaSy9oHB0slqIQtcW4hwP5CszHYqLtuzA0cYHFNYF939sgr7dP5qxTUzt2sNc0jq3zZmMFYF5eSwl3cmAUOUymKsYpAwXQfIkmE0c7d6kiechYkXVlQaWItja2EFA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(83380400001)(186003)(36756003)(5660300002)(86362001)(66574015)(316002)(38070700005)(38100700002)(71200400001)(66946007)(2616005)(66556008)(66476007)(76116006)(82960400001)(8676002)(64756008)(91956017)(122000001)(66446008)(33656002)(99936003)(26005)(4744005)(2906002)(6512007)(53546011)(6506007)(6486002)(8936002)(508600001)(200143007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?akJ3UjZqSloybExJUUR2d2dObk9Nb0FybjQ2dXBuNmFPOUlYRXRjWXFoYUlC?= =?utf-8?B?TU9CL2tkbmdBVnpITFZDREJORktKQ1lsZXFmc05lR29rNmNLRi9GTWRVQzg0?= =?utf-8?B?T2s0OUI5eUhqbHNpRzdlZHFMbHQzaXBSOGdreHdSdnFubzFEUFIrUENPUTE2?= =?utf-8?B?Y3BzdSt0MXlRcFB1RVVzeVdMT1h6SDl5Z1c1Mlh5OXpIWEpnY29jcHB6bVhU?= =?utf-8?B?T2NoMTFTeXNoMUljV0V1cEN6aFRDa2lRVEhPS2ZOa1V5c24xWnZrb2NrR0E1?= =?utf-8?B?SC84d0NwRmtlaFczZEdXbzNEZEdVN01uV0tlKzNlRTNPUms5K3NrZUNoWk95?= =?utf-8?B?S3MyWDNZQjR3QkZpbU1VS0RoVjNneUZsV1loM0FxZXQvYVJIWnF2L0d5dlky?= =?utf-8?B?YmsvU2M1SnN5Y0plRDJlQTgrTkIzdXlVWmQ4QjE0eTJGbXNZOTFWWU1FeDhr?= =?utf-8?B?S1Yyc0FmMlBGU0hrd01reHVWUEc2SGl4cWpBSytMVVFLdk9OYXZYTWVFbG1l?= =?utf-8?B?Ykt5UktRU1AxeGdVcW13RitoRkgrQXpPNHFIWm9iNkk1QzFUd2RjYlhNTTZF?= =?utf-8?B?amtVS0lCMDY5TTVvTzQwZWVDa1o1RFZOSHhpZUlkVkUzeVpzUDJ5dkR0aVN4?= =?utf-8?B?ZlR3Mm9VUTFiYUtOK3NiWmM5QjlFbUYxcXVxdlR0ZmwvdHJ5cStaWTRTa3FC?= =?utf-8?B?Q21YaDUvV0szM3NoNDViKzIvTnhUOXM1NGJHOHpCaFJ6Vk1DYlBxc3J5azdq?= =?utf-8?B?d1pHeXBiQ0JkVlRzODVDU1V5eTU4OXJKZGxITlZ0SXNESEM4c3NhQ3piZ2hY?= =?utf-8?B?M2JERGx1NlNRcGJxSHZXM1ZXMlM1ak04c2dyWE10UXBKc0I5M0JJWEpjbUk0?= =?utf-8?B?ZGRsSldGMkpmMzFlT2svdlkxNkhZblorQkRra2FsblpVWEhUQjE2VUk3eUI0?= =?utf-8?B?NE9UOU5naC9BWm1rcW44QWs0V05aME56WXhaWDRyZlNEbVdOWnlrQ1ozYkJm?= =?utf-8?B?TU5CMHFOQ2pOaldIZ1dVczhnZjJPQ3Nieit2Ny9ZMjRzZ0FxdXRlbXV2anlv?= =?utf-8?B?c0Mybi9MbjdJZDZpOVJGRWZ0UnV1NnFNU21iREZhcUVDeHFYL2ZRQVRxYTA2?= =?utf-8?B?a0x0QnIrVlpmWFUzaUVkL2dZUmhpSEM0c0JaQktnVHZ3RFJwd0VhSGwxWEZJ?= =?utf-8?B?L2JJUUlGVXFtdk9qN1A5cDY5ZUxESHFuNmgyNWlVSWdaL2d1QjVXVE9nTXhW?= =?utf-8?B?d3NBSlF6c3dhZnR1NHptNDdjRGVCOGFUNFZCR29rSnVNSXJxbTYzSER6dG5V?= =?utf-8?B?NWFvTTJPN0x0bXZrVjAza08xc0FHaW5WN3g0NUFsd05uOVFjK1kwNTlHMWhF?= =?utf-8?B?Z2VBZlhYUU54RmkwVTVHM28vS28wU1MzU0hQdjczS3Nick9kUHFobUtXRWpP?= =?utf-8?B?Q1hQY0lBQXZhNGV2clNCanB4eUFkaXA4cmdDWDdjb3lQWnhkYVprZEwrVDJj?= =?utf-8?B?QzQ0MEpFdVJGSHJCWlpQSDQ0N3JoRFcyQVk0MlI3QTZKSnhXMGRPYW00VS9x?= =?utf-8?B?eGN4QUFHZEZOYjBHNlpPM01jbjNQelJPV1Bya0hoUTdhdHo0SGNhWGtEZXhL?= =?utf-8?B?eXhUN2FKTzVtSUNCUC9VVVFTOFBhY0ViVnZzdG9xaWUzWWl5dEhjQ2RGWWdW?= =?utf-8?B?M2t0WHJiNk1GZHRkNnVadkw2ei9aUjdOdStCWmwrRDg3bnFQcVdQMWd1TVU5?= =?utf-8?B?QzZQY3U2ditBYTNsbUVCQ20zRFNxQ3FEZUpzYUlxUUUzUmtpVlRsUjRsUjFS?= =?utf-8?B?VnZjWUdIckE5Q2pXM09UcTAxNzFGVGZNTGxadnNPMTZiMVhnSDlXM0dtRWV5?= =?utf-8?B?K3hRYmhwMEQvL2l1U0dxVEtudlAwS0ZLdmNSQ0Y2eit5L3hwSHc0VE94M1Bj?= =?utf-8?B?NWlWOXkrc09hY1FlZ3dzQjJKaWJkMDZIekJRRjYzTk13TVF3MlR3cy9udWpY?= =?utf-8?B?REVlQ2NZVm9RYVFjZ3ZvTUdZRmlKWTNJdjlDQlRURVRIbC9xNWJwUHA0dnhW?= =?utf-8?B?Wk1ERjJWdmJ4Y29XOVNFN1pqaFdhRkVBVmxnTjJFMGNERDFBZXkwQms2RTNt?= =?utf-8?B?ZmF1VzZFaTBwaWNRNEhwbDBHWDRrdTB2Y1R2Uk5UODVXWW14V3kxQlY2SzhN?= =?utf-8?B?R2lIVnhNcE9talJ0Uy9xUUdTeGRLTVJrZ05GZmRjUjhPbk9QMmNnbjI5WmY1?= =?utf-8?B?a1M0OEF3ZU5MSkQwdmlIdDd6d2VFbWE5RWU5U0RlRlJCL0hybmtrcXdhQm8y?= =?utf-8?B?aUpmWVNJeUxaZGNtcVQ2M2ZDYnl3NkwrM2pHV1JBNFhMQkcrVnVXQlVFdXZL?= =?utf-8?Q?vpoISsxwzUgHmn80=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_5659520F-1B28-41C3-9CC1-40EAEA2A6ED5"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cce1187a-c83c-4adc-9bb7-08da342faf24 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 15:54:23.2397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T+H/+xNAj/yAVt23nWTWFaE8dWNb8vWFuE7y2gKhvmJGJvwZ0hYjrQXu0JcFO6SQURTGkvtCPIyjOFYSZfYDWDxUaNvm7Z8/EOjnSKHvp14= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4781 --Apple-Mail=_5659520F-1B28-41C3-9CC1-40EAEA2A6ED5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2022, at 4:49 PM, George Dunlap = wrote: >=20 > I=E2=80=99m pretty sure www-archive.xenproject.org is at least N-2 for = websites; last updated nearly 9 years ago. As far as I can tell = there=E2=80=99s nothing terribly interesting stored on the site itself. = I=E2=80=99m going to pursue deleting it within 4 weeks unless someone = objects. I have instructed Credativ to take the site down, but keep it in a = tarball should we ever need to recover anything from it. Thanks, -George --Apple-Mail=_5659520F-1B28-41C3-9CC1-40EAEA2A6ED5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJ9La4ACgkQshXHp8eE G+1odwgAuhQbZ4VYkcIjLMYKg/6cqiDQd4On+GvZgRR/CwmI9g5N9g2inHlDSPlE DTrc+Y8KFSwpn5+8uKgc2XYWgIe8AA5/vkadtj6hxLqxd3dxY+qqgM710XBynuCj N+KOzVyys7pRtoJRaI4H/SOFYojEZ9nQl0ShFFr50nIEUg/vz/qiRlySLr7eNomm b9ayVzqV0RXBwHs7KIiuEeN6LNGiFdGlOC6DPO7ZTAPIPoDUoQvwgXTV9LbxT8c6 7Qj89eQYz9aRdrL36ShMlk7jzRVLPlTS9g8pAdgNRX3VKvElTZikKenNLKVyuoI7 cot+/wvjdh96ncKelbhm3mm0McBRig== =XaYR -----END PGP SIGNATURE----- --Apple-Mail=_5659520F-1B28-41C3-9CC1-40EAEA2A6ED5-- From xen-devel-bounces@lists.xenproject.org Thu May 12 16:18:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 16:18:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327867.550747 (Exim 4.92) (envelope-from ) id 1npBWG-0004b3-G5; Thu, 12 May 2022 16:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327867.550747; Thu, 12 May 2022 16:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBWG-0004aw-DD; Thu, 12 May 2022 16:18:28 +0000 Received: by outflank-mailman (input) for mailman id 327867; Thu, 12 May 2022 16:18:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBWE-0004am-T1; Thu, 12 May 2022 16:18:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBWE-0003I9-R8; Thu, 12 May 2022 16:18:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBWE-0001Gd-GU; Thu, 12 May 2022 16:18:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npBWE-0001qp-G1; Thu, 12 May 2022 16:18:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bCjp58QNuTUgGe+OO581bxcCLGIMgZ5AckebytHci+I=; b=zFhy+FP/tZhux8re1P5EfUCuf/ g8XZAqUlgAQtX7BLj2lKgwp3TTtvm5FZjyr5FW8oox0AyuoE8f0rc/40OX6NHZvzLhjhTCzBmFGQ8 9l2kLmXEN+Gj+0IwUMJJ9HT5H4xCL7/q6RU+rqRY8LaXyXgURhfBrXaCCxvGG4UBx6EM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170359: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 16:18:26 +0000 flight 170359 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170359/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 964 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 16:21:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 16:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327875.550757 (Exim 4.92) (envelope-from ) id 1npBZG-0005wB-Vr; Thu, 12 May 2022 16:21:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327875.550757; Thu, 12 May 2022 16:21:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBZG-0005w4-TB; Thu, 12 May 2022 16:21:34 +0000 Received: by outflank-mailman (input) for mailman id 327875; Thu, 12 May 2022 16:21:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npBZF-0005vw-Hs for xen-devel@lists.xenproject.org; Thu, 12 May 2022 16:21:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94c34276-d20f-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 18:21:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 90DA161F76; Thu, 12 May 2022 16:21:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73140C385B8; Thu, 12 May 2022 16:21:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c34276-d20f-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652372489; bh=NDeYtJoOTyZCZ7rH4NHOQS1V70YxoweEBSxhUWIM/zE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GEZzmykw70nosMdq2UT7qg8LKHXmRTyvKi2MNKMtZZ2CwyO6035MToY/A+CtoWVMY oeSXpYZuUcqissIoGJ61njBawHIw+QDkKvnMrIZZylSUEPuDQKvY08371yKuyZbajk RIXLkYKVZRAfckK8MXp2I3O8tCFEYOIRx+Ti6yrs= Date: Thu, 12 May 2022 18:21:26 +0200 From: Greg KH To: Maximilian Heyne Cc: stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Josh Poimboeuf , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Masami Hiramatsu , Sasha Levin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH 0/4] x86: decode Xen/KVM emulate prefixes Message-ID: References: <20220512135654.119791-1-mheyne@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512135654.119791-1-mheyne@amazon.de> On Thu, May 12, 2022 at 01:56:47PM +0000, Maximilian Heyne wrote: > This is a backport of a patch series for 5.4.x. > > The patch series allows the x86 decoder to decode the Xen and KVM emulate > prefixes. > > In particular this solves the following issue that appeared when commit > db6c6a0df840 ("objtool: Fix noreturn detection for ignored functions") was > backported to 5.4.69: > > arch/x86/xen/enlighten_pv.o: warning: objtool: xen_cpuid()+0x25: can't find jump dest instruction at .text+0x9c > > Also now that this decoding is possible, also backport the commit which prevents > kprobes on probing such prefixed instructions. This was also part of the > original series. > > The series applied mostly cleanly on 5.4.192 except for a contextual problem in > the 3rd patch ("x86: xen: insn: Decode Xen and KVM emulate-prefix signature"). > > Masami Hiramatsu (4): > x86/asm: Allow to pass macros to __ASM_FORM() > x86: xen: kvm: Gather the definition of emulate prefixes > x86: xen: insn: Decode Xen and KVM emulate-prefix signature > x86: kprobes: Prohibit probing on instruction which has emulate prefix > > arch/x86/include/asm/asm.h | 8 +++-- > arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ > arch/x86/include/asm/insn.h | 6 ++++ > arch/x86/include/asm/xen/interface.h | 11 +++---- > arch/x86/kernel/kprobes/core.c | 4 +++ > arch/x86/kvm/x86.c | 4 ++- > arch/x86/lib/insn.c | 34 +++++++++++++++++++++ > tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++ > tools/arch/x86/include/asm/insn.h | 6 ++++ > tools/arch/x86/lib/insn.c | 34 +++++++++++++++++++++ > tools/objtool/sync-check.sh | 3 +- > tools/perf/check-headers.sh | 3 +- > 12 files changed, 128 insertions(+), 13 deletions(-) > create mode 100644 arch/x86/include/asm/emulate_prefix.h > create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h > > > base-commit: 1d72b776f6dc973211f5d153453cf8955fb3d70a > -- > 2.32.0 > > > > > Amazon Development Center Germany GmbH > Krausenstr. 38 > 10117 Berlin > Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss > Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B > Sitz: Berlin > Ust-ID: DE 289 237 879 > > > All now queued up, thanks. greg k-h From xen-devel-bounces@lists.xenproject.org Thu May 12 17:27:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 17:27:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327914.550788 (Exim 4.92) (envelope-from ) id 1npCaM-0004Xn-CB; Thu, 12 May 2022 17:26:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327914.550788; Thu, 12 May 2022 17:26:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCaM-0004Xg-7a; Thu, 12 May 2022 17:26:46 +0000 Received: by outflank-mailman (input) for mailman id 327914; Thu, 12 May 2022 17:26:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCaL-0004XW-4p; Thu, 12 May 2022 17:26:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCaL-0004RT-1d; Thu, 12 May 2022 17:26:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCaK-0002kq-KE; Thu, 12 May 2022 17:26:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npCaK-0002mN-Ji; Thu, 12 May 2022 17:26:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T53+ERnhHulFnwhpa1bjG7RIYChmbBgQGXBeFOGvM8o=; b=0YfrVmFMnGAQ7iN194Br/byILw HxBUbbb65Q3BzALYd0Z6MCcMagQPT4BFz7Ay1P0dl1KxqccodwuBYzG985v/0zGyAg7HScZOwWvFs HtSmlOHUFhvVEcixdht1VKuXFeduv+RBw5vOiHfrP89JSni0A+PGiyZnVjLboAWQV1sI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170360: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 17:26:44 +0000 flight 170360 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170360/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 965 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 17:41:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 17:41:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327924.550797 (Exim 4.92) (envelope-from ) id 1npCol-0006vR-RU; Thu, 12 May 2022 17:41:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327924.550797; Thu, 12 May 2022 17:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCol-0006vK-Od; Thu, 12 May 2022 17:41:39 +0000 Received: by outflank-mailman (input) for mailman id 327924; Thu, 12 May 2022 17:41:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCok-0006vE-4j for xen-devel@lists.xenproject.org; Thu, 12 May 2022 17:41:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npCog-0004hH-5n; Thu, 12 May 2022 17:41:34 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.236.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npCof-0007Zq-Va; Thu, 12 May 2022 17:41:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XIFvdu2ShjSqZQqQoq+rvHX8pfWb1z3O4ODBvXh646M=; b=kIjfvUGnGiPL4R0UvkAMtRtmPL n+LnKOJtC5lc3YyGsohWQZ5bz4Ij7U6nOAoHT1crV+gTMv3sDL/NBnmorG+tANGKoePvXw3mIderx Xi0W7CJq+l4uRaOD0xyYTAH3apineumkP1veVOp1eZ6Ts26YWE5C7edYPgyOcsXHXVKw=; Message-ID: Date: Thu, 12 May 2022 18:41:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* To: Michal Orzel , Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-2-michal.orzel@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/05/2022 07:52, Michal Orzel wrote: > On 06.05.2022 12:03, Jan Beulich wrote: >> On 06.05.2022 11:42, Michal Orzel wrote: >>> Function unmap_common_complete (common/grant_table.c) defines and sets >>> a variable ld that is later on passed to a macro: >>> gnttab_host_mapping_get_page_type(). >>> On Arm this macro does not make use of any arguments causing a compiler >>> to warn about unused-but-set variable (when -Wunused-but-set-variable >>> is enabled). Fix it by converting this macro to a static inline >>> helper and using the boolean return type. >>> >>> While there, also convert macro gnttab_release_host_mappings. >>> >>> Signed-off-by: Michal Orzel >>> Reviewed-by: Jan Beulich Acked-by: Julien Grall >> >> This R-b applies only ... >> >>> --- a/xen/arch/arm/include/asm/grant_table.h >>> +++ b/xen/arch/arm/include/asm/grant_table.h >>> @@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >>> #endif >>> } >>> >>> +static inline bool gnttab_host_mapping_get_page_type(const bool ro, >> >> ... with this const dropped again. As said elsewhere, while not >> technically wrong we don't normally do so elsewhere, and this ends >> up inconsistent with ... >> >>> + const struct domain *ld, >>> + const struct domain *rd) >> >> ... there being just a single const here. >> >> Jan >> > > Do you have any remarks related to the second patch in this series? FYI, Jan is away this week. > If yes, I will handle removal of const in the next version. > If not, Julien said in v1 that this can be handled on commit. I have committed this patch with the change discussed. I need a bit more time to review the second patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 12 19:00:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 19:00:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327932.550812 (Exim 4.92) (envelope-from ) id 1npE2f-00061w-Is; Thu, 12 May 2022 19:00:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327932.550812; Thu, 12 May 2022 19:00:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npE2f-00061H-FG; Thu, 12 May 2022 19:00:05 +0000 Received: by outflank-mailman (input) for mailman id 327932; Thu, 12 May 2022 19:00:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npE2f-0005vf-1i; Thu, 12 May 2022 19:00:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npE2e-00067f-ND; Thu, 12 May 2022 19:00:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npE2e-0006AV-5v; Thu, 12 May 2022 19:00:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npE2e-0000Xx-5V; Thu, 12 May 2022 19:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nveeqTO3MWiw4pDq6onwHxBQu1TeAmfmu2fxuY1myGM=; b=bFwmX7GTul1HnVPKlcx8RlWpUk UHOvE6Lj179Iibga3ULz9xGocMuvIouzwR+LHJ1P9VDcLMEqPqdChiL0VU3nc+j870l7DznCVMrWk VWtGQPSwVwRH1PcSQd6LsNRaB5Z0ot9ODvupsFw5JQtT+Fm8yo2+mN+kgNi+LfSWRhgE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170363: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 19:00:04 +0000 flight 170363 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170363/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 966 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 19:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 19:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327941.550824 (Exim 4.92) (envelope-from ) id 1npEKK-0007qa-7s; Thu, 12 May 2022 19:18:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327941.550824; Thu, 12 May 2022 19:18:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npEKK-0007qT-3K; Thu, 12 May 2022 19:18:20 +0000 Received: by outflank-mailman (input) for mailman id 327941; Thu, 12 May 2022 19:18:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npEKJ-0007qN-0c for xen-devel@lists.xenproject.org; Thu, 12 May 2022 19:18:19 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 475d87a3-d228-11ec-a406-831a346695d4; Thu, 12 May 2022 21:18:18 +0200 (CEST) Received: by mail-lj1-x235.google.com with SMTP id g16so7733639lja.3 for ; Thu, 12 May 2022 12:18:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 475d87a3-d228-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=riqmD/kfk3ZGrDs8qmxhxE5Xqu6b7BXfSjbZUAFzPAo=; b=VLQIynJDxh/UuJkN0mk1Ik7JttoYDQOPA6Nw/QLts0X7A8GPmJz1NlYftPx8SaKmlU uTFxe3Y8bQPVxIaPu5XXkg3DEcI2t/lvpueqRWDQpEuwaWM08MKk8GKDOzZEsu7bnxNZ BV2BR8f5nfpOzEf2bKzdUhEezwiHdcYqv31KiYe5ICboAVYYKBj1+712S7HDdycQDkhi S+rvfqhKslQAC8vhUsLNVJJ0ufmMqvwqcTrPExf5cuUk7RDFLF8Pu99Uf2Byze0V0c3k 6Jtf2AUBq2UDOMHuq2KkWgI75C63uDVVFyz0LMhd884zDnANh2MT3O9VjwJDfzsBwyBG U5yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=riqmD/kfk3ZGrDs8qmxhxE5Xqu6b7BXfSjbZUAFzPAo=; b=zC4/LnuM4sTHV8vr8yT3y8+rgJChCZ/UXRPVj3+1W5T0awH8j/Ls9OwWWU5Bk5c+Ew rBPmpUmqigba5tYFAm6yvit/DE75EQ4iZIB+2h0qHxxsEZVoKIGb3Xi/hrqjmCnPX9lQ W/OCK0CyqqaVXbt+GItuiihFYs9qeMCGcJK+y95WsUlguiOSg+zOlSg9ewWAtrjGxkeP JiU3IhJljOx6SHIfKEEsK5jMLIz2Sc8pVfokF7z5kGLCsMUfD7zpwaK0ULcxImJQym8H JQHIlJyX4Gkq7/Xx7vUBpCRndxSRLjesr/eVrhEJI5NzzsZsz5vRksbP6k5VXNhN87+R MDxg== X-Gm-Message-State: AOAM531TLMq7y4iOpUhRBPMv/99FXi7MGiEVUY/GiBcJE6sen6zzr/TS QqcEzNWOMsE6t5RSxy0UCpKSTeCK21cmu5o/MoI= X-Google-Smtp-Source: ABdhPJxp93y5ap4XVRNsM/p/G2SfMmPRd3Y7VkOcfi8WtT2RX91XvuOyRZ82+ycXNaC3x1AcGfBKiKOMOTfaQqjI7ys= X-Received: by 2002:a05:651c:1548:b0:24f:4dec:7676 with SMTP id y8-20020a05651c154800b0024f4dec7676mr877628ljp.459.1652383097582; Thu, 12 May 2022 12:18:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Thu, 12 May 2022 15:18:05 -0400 Message-ID: Subject: Re: xen-blkfront crash on xl block-detach of not fully attached device To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 12, 2022 at 9:59 AM Roger Pau Monn=C3=A9 = wrote: > Care to send a patch? :) I will, but because of $reasons, it won't be out until next week. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu May 12 19:45:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 19:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327948.550835 (Exim 4.92) (envelope-from ) id 1npEk3-0002cw-Aq; Thu, 12 May 2022 19:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327948.550835; Thu, 12 May 2022 19:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npEk3-0002cp-7w; Thu, 12 May 2022 19:44:55 +0000 Received: by outflank-mailman (input) for mailman id 327948; Thu, 12 May 2022 19:44:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npEk1-0002cb-Ua for xen-devel@lists.xenproject.org; Thu, 12 May 2022 19:44:53 +0000 Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [2607:f8b0:4864:20::e2f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd8d3df4-d22b-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 21:44:52 +0200 (CEST) Received: by mail-vs1-xe2f.google.com with SMTP id v139so6345733vsv.0 for ; Thu, 12 May 2022 12:44:52 -0700 (PDT) Received: from smtpclient.apple ([2a0d:5600:6:44::b62e]) by smtp.gmail.com with ESMTPSA id l7-20020a677007000000b0032d275e6907sm69757vsc.7.2022.05.12.12.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 12:44:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd8d3df4-d22b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=3B8+9l+PMBtpQmuYQQK7mo5R5UmSQ0El1iYJojGekkY=; b=XfugUBwOwKZBFD3WLdD2O54UZx1xTkfldPMbwjBhDdZrgTN0wkcUMlK/wzcyd+2ndo QP9AHE/Nn4Ap84kvIT7Tx5vFo1QFEly1DdOLUc4fMBfzrYjin52TJADAdYXqUPJKt7MZ F+RAkAA5RQRGZJxs5Y/XvRUMX+NXEWzbNysxgpK78/o5bOS8CXcLNQAAC9TMTDXBS3jk ojdzwcP9kEy/mkNC1uUMVcvwK+NsCaRIJ0WO7VRlPWFLI3oG+MlNnXc990ulFLdFUrVg JHG/iufnTLWbe9IigT4mUKBLEWdbmziI5fhoiItcXcpKx2DrjdFu2Q953fGo/OhzDjhy loNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=3B8+9l+PMBtpQmuYQQK7mo5R5UmSQ0El1iYJojGekkY=; b=ODes1K5tZh638BQVn1tv4D6zEm8uiPjrMLgEb7z3H4FfUpJNBpdllwYVURUNZUhVPd bs0hj2x/Zf9iUsmVv51M0VFlkuK0uQtfaivLCrS3VkLEdOdeeYf664Bu7Zp33WQzrUbk /IEoFlm6zWTLmYD7Zcuust4CXK9OS9dSkirhdgbLYZLVs58r/Fv6MiuY8uMf1LV99IP8 CAyRTC9HAQV/QdHrwcBN3Qj3jUV5+Nvi62l9YMY8+rP+UAY9sIqlfQDyghEs1qhPZesD UQFAgkPlSCwkpiqxAEsPbYQmAZHWAoA7o8mzhruTdXU66JaoOiie5amVMy6b+cI9U99E KCmw== X-Gm-Message-State: AOAM5318nXnXQkPPn8z2k4uTNcVSIbt2wpJED2NbFDssA4eUvNgEphYB EqZCmgkWu8vRL1EEQlbTQw0= X-Google-Smtp-Source: ABdhPJyc3s7ZukVRWci6kRCKhMEBfksOHbrOp3jo2xrOCHERoo0JV0UrDMvZhqr10qGkFiUaCpSgAw== X-Received: by 2002:a05:6102:3d0d:b0:32d:6911:ae72 with SMTP id i13-20020a0561023d0d00b0032d6911ae72mr1130031vsv.60.1652384691572; Thu, 12 May 2022 12:44:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Rich Persaud Mime-Version: 1.0 (1.0) Subject: Re: PROPOSAL: Delete www-archive.xenproject.org Date: Thu, 12 May 2022 15:44:49 -0400 Message-Id: <915413E2-1E4C-46F5-8A23-F24967E78401@gmail.com> References: <8DD705C9-2878-4F22-BEEC-82619857C702@citrix.com> Cc: xen-devel In-Reply-To: <8DD705C9-2878-4F22-BEEC-82619857C702@citrix.com> To: George Dunlap X-Mailer: iPad Mail (19E241) On May 12, 2022, at 11:55 AM, George Dunlap wrote= : > =EF=BB=BF >> On Apr 14, 2022, at 4:49 PM, George Dunlap wro= te: >>=20 >> I=E2=80=99m pretty sure www-archive.xenproject.org is at least N-2 for we= bsites; last updated nearly 9 years ago. As far as I can tell there=E2=80=99= s nothing terribly interesting stored on the site itself. I=E2=80=99m going= to pursue deleting it within 4 weeks unless someone objects. >=20 > I have instructed Credativ to take the site down, but keep it in a tarball= should we ever need to recover anything from it. Is all of the historical content from www-archive replicated on the current s= ite? That content was indexed by search engines and linked from other parts o= f the web. Are the existing links going to break, or be redirected? Hosting static content is essentially free, e.g. the entire site could be ho= sted on GH Pages. Is there a cost to keeping the current site online? How la= rge are the uncompressed HTML files and images? We don't delete historical m= ailing list archives, why delete historical web site archives? While on the topic of historical content, do we have a self-hosted mirror of= slides/videos from from SlideShare, Vimeo and YouTube? More than one publis= her has found their content deleted due to policy changes. It would be prude= nt to have our own backups. Rich= From xen-devel-bounces@lists.xenproject.org Thu May 12 20:01:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 20:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327955.550845 (Exim 4.92) (envelope-from ) id 1npF0L-00052S-Py; Thu, 12 May 2022 20:01:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327955.550845; Thu, 12 May 2022 20:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npF0L-00052L-NA; Thu, 12 May 2022 20:01:45 +0000 Received: by outflank-mailman (input) for mailman id 327955; Thu, 12 May 2022 20:01:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npF0J-00052F-C7 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 20:01:44 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 561ae2fe-d22e-11ec-a406-831a346695d4; Thu, 12 May 2022 22:01:40 +0200 (CEST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24CHYY7b003183; Thu, 12 May 2022 20:01:18 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g0a04muj7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 May 2022 20:01:18 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24CJtZ5N040728; Thu, 12 May 2022 20:01:17 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fwf757pqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 May 2022 20:01:17 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by PH0PR10MB5451.namprd10.prod.outlook.com (2603:10b6:510:e5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Thu, 12 May 2022 20:01:14 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5250.014; Thu, 12 May 2022 20:01:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 561ae2fe-d22e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=zpp9cO1dtS12S8qMB5jEpg8zqTVQAGxELZJkSrEz1xs=; b=HsPisxMytkM0DEN01xJ6MDAZl1Y7XIYzz4wdnwiieY2B0QYUHFY3ELckQpf/myTUKBKs /Z27t5dZSLIqPAE7kBqG7GQgofpnmugRS5m2MNqVzN9inXxd5v9JmLXraGcXuy0EWr4e or89SiIBetA644qPE+HDYSh2s65l3Y7Str5TESeiCBEP6DPR4wtO3QubXW9KUAFLjVSr 6JvmwNrnhb12R22MecwKRFVs/AlOziZPMW0x6jEPJ5PMk++sMGIzY/XFcMry6pFVJofG 12cKxbZUIzPihPqAqE9m8FM24bNbjVJy964N2KlKU4X7Nt1en5WNlwJ1Abp3Xk2VHRU+ Yw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFxbaJ0E6jKKbHxaSqnxPxc6YvTovG/qBVuRYodTzR2IgyWk3iuG8FC7iuml8pL1BxPgwNShVhtAVzY4qnladUZjn2rMOktACl9D2FEaW0+E73qr1OyHQIFFtxlUY5Y3Hh3VYFaTIaePj8UBR1SdIUNJoW1Vqeessm3slREp0usYME107+lySHXQ/tXBpk3mC300em4ic3eNICvgclLCTdX/G9lEPmerSWy0htV3cO4KdBu0QOMbnZ8q1kzl4V4E3YoWc2K9IXgYQtRitYra2OlHoD2gP7asXpXIk3v0I64WW2YW/JfrZN7A7hqbxXZjWQ3M6iwRmNpUy8d3fIILrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpp9cO1dtS12S8qMB5jEpg8zqTVQAGxELZJkSrEz1xs=; b=bzOCf0middB0eckK82I1GsYNfAYJ6sr8f+kKZNSzUWP5eyQcwhU9PHeWsGH5KH3w6Utaf4F3ZhfW7sTV3q1EwqDCzNSQswTdxu5zhf/WgDr9f9hPYF2KLHbeReL4iw3Ak7+m+q6r2SOWxGE1nlX9TQzWqgQXrFD/bV6Mrv5jwQSNenWRSmXJGnLdldHNxsPUI/oU2fODML3B1gV8E8ZUVEsvBe5citGGLodFGDUZqbhAkztqJG0RMdOtYR3WAO+6ecJhDOXLBo7KIaqr10brM4pFOgNUMsFolwOSiGbHEID8QSWxHJR2kcf5R+FSku4NoDZqaBdrGXn8B6Jf+M8zIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpp9cO1dtS12S8qMB5jEpg8zqTVQAGxELZJkSrEz1xs=; b=ZHrFqf7D5fuAacvL4JLQUfnskoY7ACgSksq/0BbhqREZF3pFSYIsXDgMHpqeNirSlOvA/KtZpcPnitHbYdDArsjlW2elvbZazc3+IyiPH5P8yD2Ogc/D1fVV38R4J0B8MgAA3q1X1/QcRqO2ziMoEnSD7/hU7bpUmnMEW9m5mvM= Message-ID: <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> Date: Thu, 12 May 2022 16:01:09 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> From: Boris Ostrovsky In-Reply-To: <1651947548-4055-3-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR13CA0168.namprd13.prod.outlook.com (2603:10b6:a03:2c7::23) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb82885a-cd38-4cef-84fd-08da34522b57 X-MS-TrafficTypeDiagnostic: PH0PR10MB5451:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZlTxitYph1bsOSLMQOnLDanYJch9KNXrcYMJT6f2ac3EiydFrChMwz4M7ydetE49k2fzvudkf1Jyz2oFpQ0rUFTjwhBe/VXszcAWV+z89BKSEJd1UPIabW+FbhulkT+BqwdrOj/vziwHd1ZR3RZSAH3u8k0frTJ1aTLzn8zNxwJD9HBhCW3yvgOmXR8LKBL/1pQF3jJ2SZW6Wv075Qkd5A2aBZP+u6L1qsu1wIEN1EDLWbfxplmfjpuUBW/yw93Fw1oSiYEHg6CYfSvcuZtl5p6ZO8LYxAjmmXMXaeVyiYdibnCrBx++L6PdumYuIJU3ngsnXqdB0ZZ1+QCJYUvT5JfRlnudyU2GnlOit3mOHxRBdMCo6ReapC/0gOoC1CwXR7dO0kYF7lTxBIiq5/WHgU40mkiR97bPdBMoFgtNkyjb2PFDoTbDdxOpMX86ZZZa5cQr6J3b+Nlax0ehrOTG7ubYFLgLwYlTuh12ZBOnOjvTxnUpsdlwjzhyseV2YYZUrZaHYLmncD0RseeV3DtXJBbs330CM92Gh+WByFvudFkCFM/B77J5m8HmMYNEjRnPi546Va3kIBh5ORd5f+OLcc6Xd/bCP4YHytVWoHdNw6qGUqcZu2Chc4t4Ix1xOQhTmciu8vdkoi9cFFwTmmlqoOy9ZZj0DATSMkvnqNWjNEd5/MLUJYgn5bXfb+b7MUW29HF8CBCfs2txkWKQj0QnRf5Lsc1flSRd6hXpJ6F0RL+n3Rlq+de+J3V4jTHskR48 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(31696002)(26005)(6512007)(316002)(186003)(6666004)(2616005)(86362001)(6506007)(2906002)(7416002)(5660300002)(36756003)(83380400001)(53546011)(6486002)(54906003)(66476007)(8676002)(66946007)(4326008)(66556008)(38100700002)(31686004)(8936002)(30864003)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eENMcUhOM3FGejJNSXlxWW41WXBDQ3kyZ2hFNFIxZmd4WW4xL3lsWjhGeHBE?= =?utf-8?B?UGFQQmF6RlBXMk9GZFhaZGdyZXhCb1pRalFENlVSV0ZQdUNHYWcrbnFTb1RY?= =?utf-8?B?ZkhWR0hKc3BralRCWExNU0FJL1Z6dUoyM3pqamtiRG1ldHVBbDlYS211dkJD?= =?utf-8?B?aHVrMFJHY1RKMFVqWExpckttRk1jYmR4RU1SYW5mVll3RHlJK2xkanNNVTRU?= =?utf-8?B?K1BDaEsxTU9mOS96eVdRRnJiTi81dnlLMldKSm9ocjZUbGdMQU5UUXZrRHdW?= =?utf-8?B?Tlo4MGUxeE5icElpbW9MM0FPa0dPTElsVWRRbHhOd0Z3dlZOSm5JN0VsSzhH?= =?utf-8?B?bmRlbjBDS3ptdklTNU4zSXRDZ2x2K1ZuTkU2OGRrNkZudHJ1LzBMcVQrNmRj?= =?utf-8?B?NlZsQzJXR2xOUEo5c25KL01lTVRPWTRKQWpIdDlZbk5XTWc0VFlPcG5HMWpH?= =?utf-8?B?djFGaHo0cnljTXZpUDFGTzRYOWtzbHN4S1UwZUw1V1hydktOb0JtM09GSkNX?= =?utf-8?B?OWtxbzBjVXJtdFF0cUp4dDRZTG5ZeWJyMXp5OE1tRXVzSmx1ZjQyYU9YdlBL?= =?utf-8?B?UHZCVnhXRkJ0cmZveTBXQys1ZjZaU1FSRE9zZXBoQTlLeHpwYXRLamdYRm9y?= =?utf-8?B?QUJOWFZWaTFCNTIwV3hVNm11V2p4RjhqS0lOSC9HRE92cGJQb1lFcEFuWGxs?= =?utf-8?B?UXVHaWdzMjNYL0I4VnJIbnFnVFhySnh3UWN6S1R0L2xWV0ZoN0hvVWJNeTFK?= =?utf-8?B?TzJ2VzFycWxXVnQ2ZXFockFOSmhuVTkzTkNGMEhZY09BN3hTazRwOGpBbjZa?= =?utf-8?B?QktjdFhoQmF0V2VhUjh0Vk1ycW9VRU85RG5hNFIwVU9hVWR4ZFBQOHZWL0w0?= =?utf-8?B?SWswWEdRdHd4c0lOOW9yNXlnbUwyMEd0TVhoN2xWRHRjNmhDWUtpSTl6RnF3?= =?utf-8?B?ODViT1EyM2tKNVovcFBPL0VRTTJYN2pSWSs2YUpTQkdvYzVHdkhQSEppcnVQ?= =?utf-8?B?QVE0NWlwTmtIRFlrNmlRTE16YWhNeUl4UFpJNGRlaDFrOVZOUWRpYithMXdm?= =?utf-8?B?ZUtvdjNGVGprK0ROYWZqS3FERndCSTdjSWRPL1gvQ1J0OVdjMTFwVUZ5RkIy?= =?utf-8?B?OUp3WHNYZHZWcFgxQWlSdUlPZmxQVTZqdDRlYldFOUpaQ1dOVHJVejZkWHp5?= =?utf-8?B?YXZaaFEwNTE1UXJ5VEg2S08vZnJ5UTZRTXFVTmIrUW80S3g4anlYc0VrcFE5?= =?utf-8?B?eHNxZnBOdG93OHFxUHVSOFNWZWlQTVdMbXkyb211Qmt6MDhTcVlYSGgrNXVu?= =?utf-8?B?VC9tb3Rvd1lXTE84M1pWcFA3bWNpUUxadmJiZkJmOHJ1TCtleWVHVzdHeTgw?= =?utf-8?B?MlJBam9WWkRuRjA4Ykh2M3pMVUZEUGtRSTMwUG5TcGpaSzlnU1ZvT1diYkVu?= =?utf-8?B?N0JyVkZkM1RITjBORUhEclArZUw4Y2txR1lwL1NYVDNhWGFVVzFETldIRFU5?= =?utf-8?B?UDhYeFJBZHFseGorbDdmVXFNeDNTZTJLbVprU1pKbDN4TTQ3WnVRQkk0a0xW?= =?utf-8?B?SnFKWVIvR2dIQzE0Tk5ENWtiNEhpZ3RmSUc2clR6andzb2JRcGJaZXVSK1JZ?= =?utf-8?B?MHI0bTUxazMyWFVlMGVNeWxCbFlUbERMcU5MdDhvNkNQaG1yc01Wd1Y2R3VV?= =?utf-8?B?MzJRTjJ0amYwWDl1aTJHTDJhUFpZZnhCY0N2eXlnYVJOcDlMTTYrZ3NweUtQ?= =?utf-8?B?VDJEQXRJcnFLZ245YU01c0NlbTJvQng5V0dZb05aQy9ZVmJrVE93d2RrK3BU?= =?utf-8?B?dHZCQ3MwWjVqSDFiWTJnVG93cWlheEFCejdXQVFjL3U0aC94d1loQlc5b3Fh?= =?utf-8?B?TDJML2R5MlJBQ2ZBOHBqMjdlK3RnRUg5dmQ1VHZPUGlYTmx6Qkl0VjQzYitj?= =?utf-8?B?eUFkQnJCczJFYXhDdHYrejJ2WXp5R3Bjbm5MdTlNaFpiY2l2U2hHWDZibys1?= =?utf-8?B?elNsOGx6RUV4Q0J1VkI3VnR5WCtwV1VTT09JZGljejAzUVVtMkNFMEJnRUZs?= =?utf-8?B?cTVZWGNsS0M2VFZnelEyaUMvQ0VtZWpEVFRlNmpNdk1odStWRUtnMUpMeEVL?= =?utf-8?B?cG5jUlB5QWlyOEtLdkFpcGZkNkJSMkowei9Bb1kvL0hLK3RGS2dOME9KN3dD?= =?utf-8?B?MkZHQms3OXZLVjVrd1BhWWJJZmxmV0M5V2tqMFlRYkc3QlgzMDNyRmluTWQw?= =?utf-8?B?TTZSZFZMajNyclVhWHd4V2NnWnZWcENURXdHOU5OMzJaWlFVc1E1Wm5EVmxD?= =?utf-8?B?cDYvZEVhcWZUeTdTcEtJY0JYQm5qMzYvVHBSaVpTLzZHQlVSckZaSEhoa1Q2?= =?utf-8?Q?vBfj3Z1lggJOLvmQ=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb82885a-cd38-4cef-84fd-08da34522b57 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 20:01:14.6246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VCLVrw14NbLOzsL1Wp3gj34D9NVuuR4/obmYd28XJc2EFcwkGAtdEHzoMrmjy3b8OKiQ6C7ORRDWT8o2f3vk4D/wMcbItB+lj0a0t7xh/G4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5451 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-12_12:2022-05-12,2022-05-12 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205120085 X-Proofpoint-GUID: 8gftKrLTqWw2I3u1IC0AfH9DinRfUv0p X-Proofpoint-ORIG-GUID: 8gftKrLTqWw2I3u1IC0AfH9DinRfUv0p On 5/7/22 2:19 PM, Oleksandr Tyshchenko wrote: > + > +/* > + * Handling of free grants: > + * > + * Free grants are in a simple list anchored in gnttab_free_head. They are > + * linked by grant ref, the last element contains GNTTAB_LIST_END. The number > + * of free entries is stored in gnttab_free_count. > + * Additionally there is a bitmap of free entries anchored in > + * gnttab_free_bitmap. This is being used for simplifying allocation of > + * multiple consecutive grants, which is needed e.g. for support of virtio. > + * gnttab_last_free is used to add free entries of new frames at the end of > + * the free list. > + * gnttab_free_tail_ptr specifies the variable which references the start If this references the start of the free interval, why is it called gnttab_free_*tail*_ptr? > + * of consecutive free grants ending with gnttab_last_free. This pointer is > + * updated in a rather defensive way, in order to avoid performance hits in > + * hot paths. > + * All those variables are protected by gnttab_list_lock. > + */ > static int gnttab_free_count; > -static grant_ref_t gnttab_free_head; > +static unsigned int gnttab_size; > +static grant_ref_t gnttab_free_head = GNTTAB_LIST_END; > +static grant_ref_t gnttab_last_free = GNTTAB_LIST_END; > +static grant_ref_t *gnttab_free_tail_ptr; > +static unsigned long *gnttab_free_bitmap; > static DEFINE_SPINLOCK(gnttab_list_lock); > + > struct grant_frames xen_auto_xlat_grant_frames; > static unsigned int xen_gnttab_version; > module_param_named(version, xen_gnttab_version, uint, 0); > @@ -170,16 +194,111 @@ static int get_free_entries(unsigned count) > > ref = head = gnttab_free_head; > gnttab_free_count -= count; > - while (count-- > 1) > - head = gnttab_entry(head); > + while (count--) { > + bitmap_clear(gnttab_free_bitmap, head, 1); > + if (gnttab_free_tail_ptr == __gnttab_entry(head)) > + gnttab_free_tail_ptr = &gnttab_free_head; > + if (count) > + head = gnttab_entry(head); > + } > gnttab_free_head = gnttab_entry(head); > gnttab_entry(head) = GNTTAB_LIST_END; > > + if (!gnttab_free_count) { > + gnttab_last_free = GNTTAB_LIST_END; > + gnttab_free_tail_ptr = NULL; > + } > + > spin_unlock_irqrestore(&gnttab_list_lock, flags); > > return ref; > } > > +static int get_seq_entry_count(void) > +{ > + if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr || > + *gnttab_free_tail_ptr == GNTTAB_LIST_END) > + return 0; > + > + return gnttab_last_free - *gnttab_free_tail_ptr + 1; > +} > + > +/* Rebuilds the free grant list and tries to find count consecutive entries. */ > +static int get_free_seq(unsigned int count) > +{ > + int ret = -ENOSPC; > + unsigned int from, to; > + grant_ref_t *last; > + > + gnttab_free_tail_ptr = &gnttab_free_head; > + last = &gnttab_free_head; > + > + for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); > + from < gnttab_size; > + from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { > + to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, > + from + 1); > + if (ret < 0 && to - from >= count) { > + ret = from; > + bitmap_clear(gnttab_free_bitmap, ret, count); > + from += count; > + gnttab_free_count -= count; IIUIC we can have multiple passes over this, meaning that the gnttab_free_count may be decremented more than once. Is that intentional? > + if (from == to) > + continue; > + } > + > + while (from < to) { > + *last = from; > + last = __gnttab_entry(from); > + gnttab_last_free = from; > + from++; > + } I have been looking at this loop and I can't understand what it is doing ;-( Can you enlighten me? -boris > + if (to < gnttab_size) > + gnttab_free_tail_ptr = __gnttab_entry(to - 1); > + } > + > + *last = GNTTAB_LIST_END; > + if (gnttab_last_free != gnttab_size - 1) > + gnttab_free_tail_ptr = NULL; > + > + return ret; > +} > + > +static int get_free_entries_seq(unsigned int count) > +{ > + unsigned long flags; > + int ret = 0; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + > + if (gnttab_free_count < count) { > + ret = gnttab_expand(count - gnttab_free_count); > + if (ret < 0) > + goto out; > + } > + > + if (get_seq_entry_count() < count) { > + ret = get_free_seq(count); > + if (ret >= 0) > + goto out; > + ret = gnttab_expand(count - get_seq_entry_count()); > + if (ret < 0) > + goto out; > + } > + > + ret = *gnttab_free_tail_ptr; > + *gnttab_free_tail_ptr = gnttab_entry(ret + count - 1); > + gnttab_free_count -= count; > + if (!gnttab_free_count) > + gnttab_free_tail_ptr = NULL; > + bitmap_clear(gnttab_free_bitmap, ret, count); > + > + out: > + spin_unlock_irqrestore(&gnttab_list_lock, flags); > + > + return ret; > +} > + > static void do_free_callbacks(void) > { > struct gnttab_free_callback *callback, *next; > @@ -206,17 +325,48 @@ static inline void check_free_callbacks(void) > do_free_callbacks(); > } > > -static void put_free_entry(grant_ref_t ref) > +static void put_free_entry_locked(grant_ref_t ref) > { > - unsigned long flags; > - spin_lock_irqsave(&gnttab_list_lock, flags); > gnttab_entry(ref) = gnttab_free_head; > gnttab_free_head = ref; > + if (!gnttab_free_count) > + gnttab_last_free = ref; > + if (gnttab_free_tail_ptr == &gnttab_free_head) > + gnttab_free_tail_ptr = __gnttab_entry(ref); > gnttab_free_count++; > + bitmap_set(gnttab_free_bitmap, ref, 1); > +} > + > +static void put_free_entry(grant_ref_t ref) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + put_free_entry_locked(ref); > check_free_callbacks(); > spin_unlock_irqrestore(&gnttab_list_lock, flags); > } > > +static void gnttab_set_free(unsigned int start, unsigned int n) > +{ > + unsigned int i; > + > + for (i = start; i < start + n - 1; i++) > + gnttab_entry(i) = i + 1; > + > + gnttab_entry(i) = GNTTAB_LIST_END; > + if (!gnttab_free_count) { > + gnttab_free_head = start; > + gnttab_free_tail_ptr = &gnttab_free_head; > + } else { > + gnttab_entry(gnttab_last_free) = start; > + } > + gnttab_free_count += n; > + gnttab_last_free = i; > + > + bitmap_set(gnttab_free_bitmap, start, n); > +} > + > /* > * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2. > * Introducing a valid entry into the grant table: > @@ -448,23 +598,31 @@ void gnttab_free_grant_references(grant_ref_t head) > { > grant_ref_t ref; > unsigned long flags; > - int count = 1; > - if (head == GNTTAB_LIST_END) > - return; > + > spin_lock_irqsave(&gnttab_list_lock, flags); > - ref = head; > - while (gnttab_entry(ref) != GNTTAB_LIST_END) { > - ref = gnttab_entry(ref); > - count++; > + while (head != GNTTAB_LIST_END) { > + ref = gnttab_entry(head); > + put_free_entry_locked(head); > + head = ref; > } > - gnttab_entry(ref) = gnttab_free_head; > - gnttab_free_head = head; > - gnttab_free_count += count; > check_free_callbacks(); > spin_unlock_irqrestore(&gnttab_list_lock, flags); > } > EXPORT_SYMBOL_GPL(gnttab_free_grant_references); > > +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count) > +{ > + unsigned long flags; > + unsigned int i; > + > + spin_lock_irqsave(&gnttab_list_lock, flags); > + for (i = count; i > 0; i--) > + put_free_entry_locked(head + i - 1); > + check_free_callbacks(); > + spin_unlock_irqrestore(&gnttab_list_lock, flags); > +} > +EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq); > + > int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) > { > int h = get_free_entries(count); > @@ -478,6 +636,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) > } > EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references); > > +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first) > +{ > + int h; > + > + if (count == 1) > + h = get_free_entries(1); > + else > + h = get_free_entries_seq(count); > + > + if (h < 0) > + return -ENOSPC; > + > + *first = h; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq); > + > int gnttab_empty_grant_references(const grant_ref_t *private_head) > { > return (*private_head == GNTTAB_LIST_END); > @@ -570,16 +746,13 @@ static int grow_gnttab_list(unsigned int more_frames) > goto grow_nomem; > } > > + gnttab_set_free(gnttab_size, extra_entries); > > - for (i = grefs_per_frame * nr_grant_frames; > - i < grefs_per_frame * new_nr_grant_frames - 1; i++) > - gnttab_entry(i) = i + 1; > - > - gnttab_entry(i) = gnttab_free_head; > - gnttab_free_head = grefs_per_frame * nr_grant_frames; > - gnttab_free_count += extra_entries; > + if (!gnttab_free_tail_ptr) > + gnttab_free_tail_ptr = __gnttab_entry(gnttab_size); > > nr_grant_frames = new_nr_grant_frames; > + gnttab_size += extra_entries; > > check_free_callbacks(); > > @@ -1424,7 +1597,6 @@ int gnttab_init(void) > int i; > unsigned long max_nr_grant_frames; > unsigned int max_nr_glist_frames, nr_glist_frames; > - unsigned int nr_init_grefs; > int ret; > > gnttab_request_version(); > @@ -1452,6 +1624,13 @@ int gnttab_init(void) > } > } > > + i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; > + gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); > + if (!gnttab_free_bitmap) { > + ret = -ENOMEM; > + goto ini_nomem; > + } > + > ret = arch_gnttab_init(max_nr_grant_frames, > nr_status_frames(max_nr_grant_frames)); > if (ret < 0) > @@ -1462,15 +1641,9 @@ int gnttab_init(void) > goto ini_nomem; > } > > - nr_init_grefs = nr_grant_frames * > - gnttab_interface->grefs_per_grant_frame; > - > - for (i = NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) > - gnttab_entry(i) = i + 1; > + gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame; > > - gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END; > - gnttab_free_count = nr_init_grefs - NR_RESERVED_ENTRIES; > - gnttab_free_head = NR_RESERVED_ENTRIES; > + gnttab_set_free(NR_RESERVED_ENTRIES, gnttab_size - NR_RESERVED_ENTRIES); > > printk("Grant table initialized\n"); > return 0; > @@ -1479,6 +1652,7 @@ int gnttab_init(void) > for (i--; i >= 0; i--) > free_page((unsigned long)gnttab_list[i]); > kfree(gnttab_list); > + bitmap_free(gnttab_free_bitmap); > return ret; > } > EXPORT_SYMBOL_GPL(gnttab_init); > diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h > index dfd5bf3..d815e1d 100644 > --- a/include/xen/grant_table.h > +++ b/include/xen/grant_table.h > @@ -129,10 +129,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref); > */ > int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head); > > +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first); > + > void gnttab_free_grant_reference(grant_ref_t ref); > > void gnttab_free_grant_references(grant_ref_t head); > > +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count); > + > int gnttab_empty_grant_references(const grant_ref_t *pprivate_head); > > int gnttab_claim_grant_reference(grant_ref_t *pprivate_head); From xen-devel-bounces@lists.xenproject.org Thu May 12 20:19:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 20:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327964.550857 (Exim 4.92) (envelope-from ) id 1npFHs-0006fa-JA; Thu, 12 May 2022 20:19:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327964.550857; Thu, 12 May 2022 20:19:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npFHs-0006fT-FA; Thu, 12 May 2022 20:19:52 +0000 Received: by outflank-mailman (input) for mailman id 327964; Thu, 12 May 2022 20:19:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npFHr-0006fJ-Dw; Thu, 12 May 2022 20:19:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npFHr-0007XJ-BS; Thu, 12 May 2022 20:19:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npFHq-0001UC-Vq; Thu, 12 May 2022 20:19:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npFHq-0005iK-VL; Thu, 12 May 2022 20:19:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bUCED7Z+/D8X2Jps3yVX6jvyHyttSjGUfLUwIrrrEX0=; b=dnVp1Sut/3iWnT/JOmzkSRQQk5 3hFvKnpTx2a1JZiy0LDFR1+Acc6GY6ICBloZiO2qyB2gTc5Ge5Ged9I7Q/TJ/yyiZF+wW4y3i9u2O h2YdZoae1XdyLxVOapt5iVqlSvKhRB6BsL0sUC5UkHodH333IXVi3pk0YKjOeG4W9s+w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170366: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 20:19:50 +0000 flight 170366 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170366/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 967 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 21:38:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 21:38:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327975.550868 (Exim 4.92) (envelope-from ) id 1npGW8-0005we-Dn; Thu, 12 May 2022 21:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327975.550868; Thu, 12 May 2022 21:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGW8-0005wX-AM; Thu, 12 May 2022 21:38:40 +0000 Received: by outflank-mailman (input) for mailman id 327975; Thu, 12 May 2022 21:38:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGW6-0005wN-Qw; Thu, 12 May 2022 21:38:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGW6-0000Rf-Od; Thu, 12 May 2022 21:38:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGW6-0007Qn-8q; Thu, 12 May 2022 21:38:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npGW6-0005gH-8Q; Thu, 12 May 2022 21:38:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X9sKJm4t3PAcY5ZrVj6LdR880rpJVHUzYAc4llrM8Zg=; b=OdI5E08+VVx/1u16S7rk2kEBsH Jw3y2d9cdCsiz41Kh2Ekas19twSH6jeBPFh543RVblvJqKXx8VfF3Unw4pPNsCeASFp4IHBvHaYF5 m5JB5avcvSusvAVvfuwh/NFFFIaIJgWUPfK03PeMpzLfRFCjtxlCx7KJ6VNvPxgtVdL0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170367: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 21:38:38 +0000 flight 170367 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170367/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 968 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 22:08:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 22:08:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327988.550879 (Exim 4.92) (envelope-from ) id 1npGyT-0000y6-Tr; Thu, 12 May 2022 22:07:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327988.550879; Thu, 12 May 2022 22:07:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGyT-0000xz-Qx; Thu, 12 May 2022 22:07:57 +0000 Received: by outflank-mailman (input) for mailman id 327988; Thu, 12 May 2022 22:07:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGyS-0000xp-9f; Thu, 12 May 2022 22:07:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGyS-0000xt-7N; Thu, 12 May 2022 22:07:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGyR-0000PA-SG; Thu, 12 May 2022 22:07:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npGyR-0000SW-Rn; Thu, 12 May 2022 22:07:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JjYfnIDdkuEwuNzXzFtovcxi0IB2H3xql1/QNFzkcps=; b=WIYjNZUDjuhJEfrWvddtfMRuMs 5MZoq04g3C0au1OxQJ8ZChb/v3T4eDMTh7hPF9oYiWoUciUjxjND1ywBDXV4hP/rq7ecTi4peCshj sPbs9YMnStnrCze5wQ2aIUgCIROUhIlVflegBA0mLDJZd34pq5HnLG+d2jPtXWYTORIg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170368: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 22:07:55 +0000 flight 170368 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170368/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 969 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 22:26:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 22:26:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327997.550889 (Exim 4.92) (envelope-from ) id 1npHG1-0003JI-HV; Thu, 12 May 2022 22:26:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327997.550889; Thu, 12 May 2022 22:26:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHG1-0003JB-E8; Thu, 12 May 2022 22:26:05 +0000 Received: by outflank-mailman (input) for mailman id 327997; Thu, 12 May 2022 22:26:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHFz-0003J1-GF; Thu, 12 May 2022 22:26:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHFz-0001Hs-D0; Thu, 12 May 2022 22:26:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHFz-0000uN-0K; Thu, 12 May 2022 22:26:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npHFy-0002RG-WA; Thu, 12 May 2022 22:26:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rW0bnfjs5AWKz9+kkG/qx3f1TMSJp1xoyyJfNxfyjVk=; b=W2Bh7E0MpW6tajEqFKn+GaT7NZ RLImOZTgtWmEiJsAdzGGGl2GvicFPZatrjyeDnZybiXI7BHE0FQmFhh/tz5+MIw3bRxTSsk66xKCR 6Ab9iXUXOB3O+DZSPws1C5o+PmtdoiJkmg8zS2Rg0j7N7URvk56wUqeG8lSKN8PF/iRI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170364: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 From: osstest service owner Date: Thu, 12 May 2022 22:26:02 +0000 flight 170364 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170364/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 Last test of basis 170300 2022-05-10 15:03:18 Z 2 days Testing same since 170364 2022-05-12 18:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Michal Orzel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 407b13a71e..207abdb38e 207abdb38ee987e99385263e3e56b6c500d74cbc -> smoke From xen-devel-bounces@lists.xenproject.org Thu May 12 22:29:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 22:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328006.550901 (Exim 4.92) (envelope-from ) id 1npHIz-0003zl-68; Thu, 12 May 2022 22:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328006.550901; Thu, 12 May 2022 22:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHIz-0003ze-2d; Thu, 12 May 2022 22:29:09 +0000 Received: by outflank-mailman (input) for mailman id 328006; Thu, 12 May 2022 22:29:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHIx-0003zY-Cl for xen-devel@lists.xenproject.org; Thu, 12 May 2022 22:29:07 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed2f22b3-d242-11ec-a406-831a346695d4; Fri, 13 May 2022 00:29:05 +0200 (CEST) Received: from mail-dm6nam08lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 May 2022 18:29:02 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by CO3PR03MB6775.namprd03.prod.outlook.com (2603:10b6:303:175::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Thu, 12 May 2022 22:28:56 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.013; Thu, 12 May 2022 22:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed2f22b3-d242-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652394545; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xHv0F81zpuI/E7Fihu2/1vFvM/ZpcGPFFBSBKe4NX/4=; b=fISPncUdQ0KLdf9GTkV8euIIovwc1wjvtPKbvtq0a6PcOiTdJi28LyhU veM3Fzr2lJYvORB/QhtyeypCxykeh682uFodx6L52nxmK9m3cDHRNW1dI AOpivnz8MJ8tpuz83jGgS6F5oSQZ2RFNWopaq10bpzf/oGPnq2+08dJd2 U=; X-IronPort-RemoteIP: 104.47.73.42 X-IronPort-MID: 71201830 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4b/ucK2nWq5+GL4czPbD5b5wkn2cJEfYwER7XKvMYLTBsI5bpzIHy mccDGnXO6uDZGP9eNEnPYWypB5U78DSy9YyGwU4pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx24Dia++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0WvqK3WRsIMJHTs9Q5cTxlCCEnLIdZreqvzXiX6aR/zmXgWl60n7BCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfmQjTNb9G5YasRmMvvZf cUULxZyahDJezVEO0sNCYJ4l+Ct7pX6W2IB8grM9fFvi4TV5D4o1rPkbfaORvetFPgWjGi0/ z6cz2usV3n2M/Tak1Jp6EmEnuLVhirmQqodEbS58rhhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHAswaQpXeFulsQXoRWGuhiuAWVkPKIuUCeG3QOSSNHZJo+rsgqSDc21 1iP2dT0GThot77TQnWYnluJkQ6P1eEuBTdqTUc5ocEtuLEPfKlbYsrzc+te IronPort-HdrOrdr: A9a23:TGrOR6wzglDMIuaweOWSKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtrrQaC50YvLrf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71201830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWPOEisWjlP4JAGdsOIiTZS0c08FTOvupA3TdF2xmB7SbdVVdWcXntmvUCsMerNUYhapdB/tIWYmq7tCfJ4exosN/jvC1S/oJa9GL+O4v2tzRKasBkD81EFc0LULOY0JK+NZNWui2ex8ZrtiWsdyyWpe2CVxAu/9c1XOLVF6LXyMU7MOV9R5kmpVEG9ivzX76WVxrOt4A59x/7GBP4x8nhHdsQExb1hNly8Rfx3U18jXi0v0Ix5cWbO9/hC87YK38ixfG0AECYNvpxgqHZhhAtCXpo/oXO4m1xNm0uwXn1T1Eg1UzQdp/ECHpLz2EJHoz96ka+pmnB+8qw/rkuI/RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xHv0F81zpuI/E7Fihu2/1vFvM/ZpcGPFFBSBKe4NX/4=; b=TLC8vD41bFMiJWZdbLd83QgYn2d6cr06eOOC01IECWc6dWIOpxhNCKgRj/ujuPdG6EGXbExBUpDmhu+A2or3ryT9DDJvh++/x0fGy41hD1he+kwq78B2hM32giPQM3iVgbNWRCq/kLA/Z3A9k3OUS8+DSnBpTFILbxf22gwypW8SIl/RucQQattcA0pflikjqohMqzoGrHtW+O+HYXa85UMqb1O7tu/eDxpqh4sVyxcIOHiXyYVKMNVSosWbLzyFuyEdjZjRoI9O9g9VJgtdxE59AbmJQ8xSpQXP3kywTPNCfOaUoLXD2UHPtJ9omU7vZ4QrQzb5Vjl8pxdkEVozMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHv0F81zpuI/E7Fihu2/1vFvM/ZpcGPFFBSBKe4NX/4=; b=dK6dGDtXvUSGSPD1+wJ68WsrDgdSa92R9rIqqAbcEHdniEJbZ0pkBuR8yXUeSUBRuWVHuHmpi10w2EyWrX1fFPY29MugGZaKoFr9SqO4wMpEFQe60ZSHRDn4ED70edhm6BYl0ukwtjPqEZIcDwIA9jiCUnOQx9y8kZnEESlhPZI= From: George Dunlap To: Rich Persaud CC: xen-devel Subject: Re: PROPOSAL: Delete www-archive.xenproject.org Thread-Topic: PROPOSAL: Delete www-archive.xenproject.org Thread-Index: AQHYUBdKGkaQLBb2wkOW+P2/BX0raa0bkOkAgABAY4CAAC3TAA== Date: Thu, 12 May 2022 22:28:55 +0000 Message-ID: <40C36445-9161-4D2C-B613-D2ED150EFC32@citrix.com> References: <8DD705C9-2878-4F22-BEEC-82619857C702@citrix.com> <915413E2-1E4C-46F5-8A23-F24967E78401@gmail.com> In-Reply-To: <915413E2-1E4C-46F5-8A23-F24967E78401@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a79a51cd-b73f-4ece-3118-08da3466cd20 x-ms-traffictypediagnostic: CO3PR03MB6775:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tCSVlCQtDBTe8cjQHVlQcM4D1a/VhY2jPPMR+MVn2vQVQBd4GRPdgIT+yv5k21gtapzPFSFZKyAgvtchx1GnZywGZl8qzdW6CfKXI5AS75oqzCU0HvsOiY+4BiXdM6e9Rll2My1s27ylQ1OJVPmsZY6fD15dH6EqK/QTvw0JkRscyivzNimEYosM59kDbD+d9xiiQeTUnPhCJQgbt55kz0+L9mQLTYM4oWNgfVm+Utx5dmklBSqH83aSzXqH+e+lr3JndqgjvAK8caNxCmwxFk4ILtSdxBxNkJ9UbuWwpzQy+QqFpkv0CeBAjiKAv9yrgn6mLS0zRsPjfTwG7QCc3zHjFO/Xo4KzqYXNDnDWELyrcZXv0I9D9wYz3xkAquG+NQ1Y8LQuN1PHrj4x5GmQbZHgyWpwYhIYYhzrpUTjqMDVRaOi3Zp1n8IBNv+/o9vS+z46+s/pgayWATX4I58RMu+dU8+QN7tqb/mv3I9WGZGI2u72SK2v2l5QIKdKss67TNkHpLtHKO+xxH0ydltooDYEIscqvwpeICkiccZdOf4WeXmIkODmBy1/MzDC9YPThgMO9izXWYBN647bG6H2Xmx6ZaBrtWLT02SGgNg2BMHyEx5xYR0eXVO9sZmIRl29pd4FPyBOYBGYdzDlXGZNcrsN/FWPA4w+6I4MmfDW05YCz+PGX35IgPYsIB0oLg9vvxlOw5nPzfDWS/el4XEBHp3grq+nJoKlZtyQKO6mLhnAff36rMgGAZMG87qUpxEl1Kd6vs21bUTV5McUEYl01g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(91956017)(53546011)(122000001)(83380400001)(36756003)(8936002)(33656002)(6916009)(8676002)(64756008)(66556008)(66446008)(66946007)(66476007)(4326008)(76116006)(38070700005)(38100700002)(6512007)(6486002)(316002)(71200400001)(66574015)(508600001)(2906002)(5660300002)(186003)(86362001)(6506007)(2616005)(26005)(200143007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RXM1WWNkbzRyc2pMRUZJakNSVll1VW5FSzBoK0M5TGRGVktEYThheG95ZlEx?= =?utf-8?B?UE91cHp3bG81aDYxS0czbVJINEJzbXNQZkVOZGRXdkRVa3NZMFhzN2ROdHYr?= =?utf-8?B?UTJEeDFSVGhLNkJGSzRYTklnSkxmTXh2TGMxcGQyeU13RUJVYkM0czZBVWRn?= =?utf-8?B?VnJwZGRsTWIyNlNwSlczUXM0L092dGVnL1ppMlFNUm04L29GNVoxSmFTR1gw?= =?utf-8?B?RnFQeG41Q2ZmQkF0eVNCRlJZODRzb01IRXoyT290OVdOWlBmazI4NUV0d3Jh?= =?utf-8?B?cGg0WjVNU0lwM0ZoUnFYT1FkUlhjR1ptblozV1VFR0dvZzJEdURySGRZUmZj?= =?utf-8?B?NTN6cys1MHpFMnZNVEFibmlwbmxicE13eGtrRUZQQVVEUjFZNk82bmxMT05t?= =?utf-8?B?WDRtM1pyM3IzNlgzdTFHVG9FcFM2MnRXT2R4bS9ITyt5ZForZFVRZUJtTC85?= =?utf-8?B?eVcwUGpjK2p4VXQ0SDR1QmZxM2QwTndEMHY5azNQQ2t0SzJkdGhEdGE5U28x?= =?utf-8?B?bEVBamdTWDk2YjFlaUF6TmVVUFRTRmgzbHM2R1oxbEk3ZXZ6UEFBeFpPc2NV?= =?utf-8?B?QUpvUTNJc0VZVGtyT0QxWGpnN1hoZUhwZEdSSXVtNTZoYkVreDM2d041RXFO?= =?utf-8?B?ZnFFZ3oxOS9DL3lkeXFvN2YwRW1kTCtxdEZPdDdLTHQzOHRDaE1ia1doREpw?= =?utf-8?B?YmRKdXNmUWFNNjAyMHZaRVl0VUJINzgrTml1T08zTGxrMTZmcGdmUjZVemtV?= =?utf-8?B?MGxpOE5JbzdHYkp0eDRvV1VYQ3JWRW9NOFRBOFhEMWVMZU11bHU1ZUNTLzFK?= =?utf-8?B?a1pvQlc0cnZEeUo4MXkyNlB2RXRqMXdGNEIwaGFLRkhGYUgzZFE0cW5Ec2x5?= =?utf-8?B?OG8yRXpiUytEMVJoRGxFanhsaWlUYXlFTjVNeUNKd0ZBekpsWGVzVVNaVzdQ?= =?utf-8?B?S0FnZzEvYnVlVTVNcjhlTHBCeWtWeXFDeWdhTUFBaXVhNnZLcDJ4L2lsamp2?= =?utf-8?B?MURNazBHcmc0T3lyWEhGQUdwVG5vUmE5U0tvZHRpbEgxbmFaNlk0TVRzTXBv?= =?utf-8?B?NDVQcUExcG00WE43ZDVhbExUSTVJNlBxQXdlNWJmeFB5ZWtZRXk4WmREM2hr?= =?utf-8?B?N0JCekQ0R3Mxa2ZNUVFudDNpZFBYSVFOdDVidDJmMzlScmJlTDBRTUx0VThn?= =?utf-8?B?T05YM3NxYzJ5N3E3R2dvVlROMkx2VkllUElONFBndVNyclpYcGlGWXhuVmRJ?= =?utf-8?B?Nm9KaTV4UTJ1K0JqMjhYRkNRY3ZxR1p1cnZBN0lVdXNSYllqZ1hKZ0c3endP?= =?utf-8?B?MFl0U1Q3SkpPVzR6RzlrVktxeXFZWm5Bc2RrNFRxVG9leGczQ0tmcEg1YStw?= =?utf-8?B?aTljSVd0TUFjMlpGaTBmU1JFNklpM05ZRk5UVDlJN0FPdjlMNHc2dkhabUpr?= =?utf-8?B?bHdYd3NYZklMdHFnOUxtb01VcWQrS29NTXNJYkhQc0dTMkRsZzRuN3crWnAw?= =?utf-8?B?NVVnK3JkaC9OS0MyeCtzeDJkVm9CYUw3UHRLTjQzVXhaY0JyYmx6UlhrQ3BY?= =?utf-8?B?WnFPMlFLSU5FSW9aTDBOb3J4RXpoSEtYZWM4dXBrTXBOZElEZFBEVjhRcHdn?= =?utf-8?B?VzRuVEVLUnZhZUlmQVBkZGh1NWIxZHBnbmt0cjRHMjJ6OEtxRGZNYlJXUlEv?= =?utf-8?B?RmlsTlRzdDI2d1pKZDFQWUt2bGJmMWNYdnZvMmhkc3RtS0plTWxRbkNPRi9H?= =?utf-8?B?UVIxODFTZXdrWGZ4WDVSc0R0VmhacHk1d1dPTDd1TUFPa1l5K2FLMm04SGxs?= =?utf-8?B?eUc5Q3VwT0NrMURRN3R6WjZJMHhtemF4V2tJbFMvRGI1Wk9Zb0x5c0pZcDg4?= =?utf-8?B?b1BrVHRQQnkvT1BXeWlBL0ZLbTNJbko1SmF2Vm83OWhiOXpQdTUrTk5pQXFU?= =?utf-8?B?VS9EYTJjbmw4VExEUWg0TTVxVmpZS3paVkZDYkxUN2lqS216eEoreWVSeXNQ?= =?utf-8?B?ZURBUGN3VHZxTXVWM1Q5akp4OG5uOHp2M3RrblpvdU9zcnNnb3J5UUwxbEpX?= =?utf-8?B?NGcyam9iRzBVd3l0U2FqdUg3NjV0ZVVXVk1VYnl0eHlkY016N2dsdW9qMDdY?= =?utf-8?B?ZFhtcWUzSVNmdjlEYmJEOUNQNWJGRTBYQWhTbGMzcEFRM1hmRnNuZjV3SmJp?= =?utf-8?B?aVl4WUQ1cEhoZDRUYU5GUnVHZ2NxZE0rcnY0TWIxWE14RUpvOVdGRDJxKytT?= =?utf-8?B?a2VDWENaNm95RGk0NitNWHdLNkdHUW1LUytwZlJoY0w2bU9XU3Z4b2RCVGgr?= =?utf-8?B?NzRCTFVwbUNWdHg0cHhIM3hGdU1tTkJxaFl1TEY5d1VpNGpubzNLNSt1SDY1?= =?utf-8?Q?redW3T7+Giun8Y6U=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <12D2877663CFC54D8E9E6BB0C98F653B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a79a51cd-b73f-4ece-3118-08da3466cd20 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 22:28:55.8457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XVCekL1Fsw2lm54NDXAWxmx3PlCwFZI7KfG08MCfsW0wzOa98/jozTA/tq1N18ICuoP5+xe5oaHRs6wab/h/KdxS6U+nSVwCYc1BTMp7TuY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6775 DQoNCj4gT24gTWF5IDEyLCAyMDIyLCBhdCA4OjQ0IFBNLCBSaWNoIFBlcnNhdWQgPHBlcnNhdXJA Z21haWwuY29tPiB3cm90ZToNCj4gDQo+IE9uIE1heSAxMiwgMjAyMiwgYXQgMTE6NTUgQU0sIEdl b3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBAY2l0cml4LmNvbT4gd3JvdGU6DQo+PiDvu78NCj4+ PiBPbiBBcHIgMTQsIDIwMjIsIGF0IDQ6NDkgUE0sIEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5s YXBAY2l0cml4LmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gSeKAmW0gcHJldHR5IHN1cmUgd3d3LWFy Y2hpdmUueGVucHJvamVjdC5vcmcgaXMgYXQgbGVhc3QgTi0yIGZvciB3ZWJzaXRlczsgbGFzdCB1 cGRhdGVkIG5lYXJseSA5IHllYXJzIGFnby4gQXMgZmFyIGFzIEkgY2FuIHRlbGwgdGhlcmXigJlz IG5vdGhpbmcgdGVycmlibHkgaW50ZXJlc3Rpbmcgc3RvcmVkIG9uIHRoZSBzaXRlIGl0c2VsZi4g SeKAmW0gZ29pbmcgdG8gcHVyc3VlIGRlbGV0aW5nIGl0IHdpdGhpbiA0IHdlZWtzIHVubGVzcyBz b21lb25lIG9iamVjdHMuDQo+PiANCj4+IEkgaGF2ZSBpbnN0cnVjdGVkIENyZWRhdGl2IHRvIHRh a2UgdGhlIHNpdGUgZG93biwgYnV0IGtlZXAgaXQgaW4gYSB0YXJiYWxsIHNob3VsZCB3ZSBldmVy IG5lZWQgdG8gcmVjb3ZlciBhbnl0aGluZyBmcm9tIGl0Lg0KPiANCj4gSXMgYWxsIG9mIHRoZSBo aXN0b3JpY2FsIGNvbnRlbnQgZnJvbSB3d3ctYXJjaGl2ZSByZXBsaWNhdGVkIG9uIHRoZSBjdXJy ZW50IHNpdGU/IFRoYXQgY29udGVudCB3YXMgaW5kZXhlZCBieSBzZWFyY2ggZW5naW5lcyBhbmQg bGlua2VkIGZyb20gb3RoZXIgcGFydHMgb2YgdGhlIHdlYi4gQXJlIHRoZSBleGlzdGluZyBsaW5r cyBnb2luZyB0byBicmVhaywgb3IgYmUgcmVkaXJlY3RlZD8NCg0KVGhlIGJsb2cgY29udGVudCBo YXMgYWxsIGJlZW4gcG9ydGVkIG92ZXI7IHlvdSBjYW4gc3RpbGwgc2VlIHBvc3RzIGZyb20gMjAw OCBvbiB4ZW5wcm9qZWN0Lm9yZyBpZiB5b3UgaGF2ZSB0aGUgcmlnaHQgVVJMLg0KDQo+IEhvc3Rp bmcgc3RhdGljIGNvbnRlbnQgaXMgZXNzZW50aWFsbHkgZnJlZSwgZS5nLiB0aGUgZW50aXJlIHNp dGUgY291bGQgYmUgaG9zdGVkIG9uIEdIIFBhZ2VzLiBJcyB0aGVyZSBhIGNvc3QgdG8ga2VlcGlu ZyB0aGUgY3VycmVudCBzaXRlIG9ubGluZT8gSG93IGxhcmdlIGFyZSB0aGUgdW5jb21wcmVzc2Vk IEhUTUwgZmlsZXMgYW5kIGltYWdlcz8gV2UgZG9uJ3QgZGVsZXRlIGhpc3RvcmljYWwgbWFpbGlu ZyBsaXN0IGFyY2hpdmVzLCB3aHkgZGVsZXRlIGhpc3RvcmljYWwgd2ViIHNpdGUgYXJjaGl2ZXM/ DQoNClRoZSBtYWluIGNvc3QgaXMgdGhhdCB0aGVyZSB3YXMgY29udGVudCBvbiB0aGVyZSB0aGF0 IHdhcyBvYnNvbGV0ZTsgc3BlY2lmaWNhbGx5LCBvbmUgb2YgdGhlIHRvcCBoaXRzIGZvciDigJxY ZW4gUHJvamVjdCBUcmFkZW1hcmvigJ0gd2FzIGEgUERGIG9mIGEgdHJhZGVtYXJrIHBvbGljeSB0 aGF0IHdhcyBvYnNvbGV0ZWQgYnkgdGhlIDIwMTMgbW92ZSB0byB0aGUgTGludXggRm91bmRhdGlv bi4NCg0KPiBXaGlsZSBvbiB0aGUgdG9waWMgb2YgaGlzdG9yaWNhbCBjb250ZW50LCBkbyB3ZSBo YXZlIGEgc2VsZi1ob3N0ZWQgbWlycm9yIG9mIHNsaWRlcy92aWRlb3MgZnJvbSBmcm9tIFNsaWRl U2hhcmUsIFZpbWVvIGFuZCBZb3VUdWJlPyBNb3JlIHRoYW4gb25lIHB1Ymxpc2hlciBoYXMgZm91 bmQgdGhlaXIgY29udGVudCBkZWxldGVkIGR1ZSB0byBwb2xpY3kgY2hhbmdlcy4gSXQgd291bGQg YmUgcHJ1ZGVudCB0byBoYXZlIG91ciBvd24gYmFja3Vwcy4NCg0KV2UgY2VydGFpbmx5IGRvbuKA mXQgaGF2ZSBhICpzZWxmLWhvc3RlZCogb3B0aW9uLCBpbiB0aGUgc2Vuc2UgdGhhdCBhbnlvbmUg Y291bGQgZ28gYW5kIHZpZXcgdGhlbS4gIEhhdmluZyB0aGVtIGJhY2tlZCB1cCBzb21ld2hlcmUg d291bGQgaW5kZWVkIGJlIHBydWRlbnQ7IGl04oCZcyB3b3J0aCBjaGVja2luZyB0byBzZWUgaWYg d2UgaGF2ZSBhbnl0aGluZyBhbnl3aGVyZSwgYnV0IGlmIHdlIGRvLCBJ4oCZbSBub3QgYXdhcmUg b2YgaXQuDQoNCiAtR2Vvcmdl From xen-devel-bounces@lists.xenproject.org Thu May 12 22:39:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 22:39:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328014.550911 (Exim 4.92) (envelope-from ) id 1npHT7-0005Si-5J; Thu, 12 May 2022 22:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328014.550911; Thu, 12 May 2022 22:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHT7-0005Sb-23; Thu, 12 May 2022 22:39:37 +0000 Received: by outflank-mailman (input) for mailman id 328014; Thu, 12 May 2022 22:39:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHT6-0005SR-Eq; Thu, 12 May 2022 22:39:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHT6-0001UX-DC; Thu, 12 May 2022 22:39:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npHT4-0001Ly-WF; Thu, 12 May 2022 22:39:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npHT4-00054Z-Vk; Thu, 12 May 2022 22:39:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Lt43iUs187F3igS/12b5oY91Q422FO+G1J4AUOgK15E=; b=qp9pexWIhMWklF/pfUbOeHVJeR MPIHW5VpYiZTFJ5B3xmvDlsyLKt2aKr+fjzub8ZsRlRIAg9WIvyHU9ecsInRFTxdetmwzHpvsZBMw xZ6FOJjAKfMuvedDvBCM2n/cGoTyus7Q0g9O4QwXbLX1A84pkRQsVcoE7/LV8OMSI2Fo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170369: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 22:39:34 +0000 flight 170369 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170369/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 970 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 12 23:16:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328034.550922 (Exim 4.92) (envelope-from ) id 1npI31-00018R-1w; Thu, 12 May 2022 23:16:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328034.550922; Thu, 12 May 2022 23:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npI30-00018K-VQ; Thu, 12 May 2022 23:16:42 +0000 Received: by outflank-mailman (input) for mailman id 328034; Thu, 12 May 2022 23:16:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npI2z-00018E-MK for xen-devel@lists.xenproject.org; Thu, 12 May 2022 23:16:41 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9354a33c-d249-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 01:16:40 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41EF9610A5; Thu, 12 May 2022 23:16:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38379C34114; Thu, 12 May 2022 23:16:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9354a33c-d249-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652397397; bh=s/rzbW9qBEqEEnqhDUwKHh2amYGm06i9S6GEVd9VL84=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tm6wQQ4Hs6tGQ4j08oop8zlF1d0zfheVBBEuZ1n0M6ZNeRVbfFoPjTYbXKa30j5iT ikPhkjzole/ZHFBjyHzZkXp/zKYIORVE7VON3vT2nK83G4+K/3OMNuo8QJvhqdkyc/ ptCZ1Ava6Iu1m2he+YhK/RBcwcP27PgrNwPUIoitKiqv527W3uHhBUcN4yU8Cxdo+O FUbnQnzO4uyHN890gReGaoHI752dKA4x05FXVTEaZPhr1sF50YEzT2eN6pca4fi6oh RcyW/RHU7HkW5hCEAm2Ub2oPtEiu7YY+i3F664zD6NS9bh8l/ZoelyUOqnRQYsUNI2 TaTg2Y94YpVLA== Date: Thu, 12 May 2022 16:16:29 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Rahul Singh cc: Julien Grall , xen-devel , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] xen/evtchn: Add design for static event channel signaling In-Reply-To: Message-ID: References: <10d83478f116c923271a6c2f7d413f6ec117598d.1651685393.git.rahul.singh@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1003058993-1652397398=:3842" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1003058993-1652397398=:3842 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 12 May 2022, Rahul Singh wrote: > > On 12 May 2022, at 9:56 am, Julien Grall wrote: > > > > Hi Rahul, > > > > On 11/05/2022 15:32, Rahul Singh wrote: > >>> On 10 May 2022, at 1:32 pm, Julien Grall wrote: > >>>> +domain may toggle masked bits in the masked bit field and should clear the > >>>> +pending bit when an event has been processed > >>>> + > >>>> +Events are received by a domain via an interrupt from Xen to the domain, > >>>> +indicating when an event arrives (setting the bit). Further notifications are > >>>> +blocked until the bit is cleared again. Events are delivered asynchronously to > >>>> +a domain and are enqueued when the domain is not running. > >>>> +More information about FIFO based event channel can be found at: > >>> > >>> I think the explanation is fine for a design proposal. If you want to use it as documentation, then I would suggest to clarify there are two different ABI for event channel: FIFO and 2L. > >>> > >>> 2L is the easiest one to implement and for embedded we may want to steer the users towards it. > >> I will rephrase the sentence as below: > >> Xen supports two different ABI for event channel FIFO and 2L. More information about FIFO based event channel can be found at: > > > > I think it is a bit strange to point to the FIFO doc but not the 2L (the explanantion above is not really for 2L). If there are no doc for the latter, then I would possibly drop the link. > > Ack. > > > > >>>> +The event channel sub-node has the following properties: > >>>> + > >>>> +- compatible > >>>> + > >>>> + "xen,evtchn" > >>>> + > >>>> +- xen,evtchn > >>>> + > >>>> + The property is tuples of two numbers > >>>> + (local-evtchn link-to-foreign-evtchn) where: > >>>> + > >>>> + local-evtchn is an integer value that will be used to allocate local port > >>>> + for a domain to send and receive event notifications to/from the remote > >>>> + domain. > >>> Port 0 is reserved and both FIFO/2L have limit on the port numbers. > >>> > >>> I think we should let know the users about those limitations but I am not sure whether the binding is the right place for that. > >> If you are okay I can add this limitation in this design doc. > > > > Design docs are generally for developper of Xen rather than the end users. I am OK if you want to add the limitations in this design doc so long we have another easy way for the user to find out the limits. > > > > This could be end users documentation and/or message in Xen. Note that 2L has a lower limit and we don't know in advance what the guest will use. So we may have to assume the lower limit (4096) which should be plenty for embedded :) > > I am planning to explain the static event-channel subnode in "docs/misc/arm/device-tree/booting.txt” [1]. I will include the limitation also at the same time. > > @Stefano: I need confirmation from you also, is that okay to add new property value "xen,enhanced = evtchn” to only > enable event-channel interface for dom0less domUs. make_hypervisor_node() will set the evtchn PPI interrupts property only if "xen,enhanced = evtchn” is set. > > If "xen,enhanced" with an empty string (or with the value "enabled”) is set make_hypervisor_node() will set the grant table, extended region and PPI interrupt property. > > [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/arm/device-tree/booting.txt;h=7b4a29a2c293d16e9280a24789bc3b5262a367f6;hb=HEAD#l238 I think that's OK --8323329-1003058993-1652397398=:3842-- From xen-devel-bounces@lists.xenproject.org Thu May 12 23:48:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328042.550933 (Exim 4.92) (envelope-from ) id 1npIX6-0004Rn-IZ; Thu, 12 May 2022 23:47:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328042.550933; Thu, 12 May 2022 23:47:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIX6-0004Rg-Fe; Thu, 12 May 2022 23:47:48 +0000 Received: by outflank-mailman (input) for mailman id 328042; Thu, 12 May 2022 23:47:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIX4-0004Ra-S9 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 23:47:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eaa75f5b-d24d-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 01:47:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 926A162050; Thu, 12 May 2022 23:47:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99444C385B8; Thu, 12 May 2022 23:47:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaa75f5b-d24d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652399262; bh=0c7fCTeFbodpYdyxtQR8xBNPNTq71HcRx/Vlr3HbBaw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UWn2r6YrJrXioOtM2bGYRfQAhwHe1SSmzRZH0MhMhimyH+rPZ2vFTeBlydHmZR36t GTqN483gIJsxsp6Cv0Lr0j9+WOlB5ynLSkE08M3aXTp1bQvq8PcQ4WZ5cjS39TH5ee P59ikh/TaOipNltYJ5CHs+Is8dfzLrvMz0UdG670i9I8N9GdGUyYosTJArmUwvoe05 hBOq0ND3lwcQis4cBaSlAs1uiH7Fd7PcEodaFQXMNbGmxe4zdOfpp9gwAOzPm1Rd9U wcOwQUazq6trY5vrbTD7Mz7t49fSNZCxcpg7C9EeTc2Xfk9MUKdule56QpNzLj3mvj jr4v8mJB421jg== Date: Thu, 12 May 2022 16:47:41 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v3 1/8] xen/arm: introduce static shared memory In-Reply-To: <20220512091129.2802997-2-Penny.Zheng@arm.com> Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-2-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 12 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This patch serie introduces a new feature: setting up static > shared memory on a dom0less system, through device tree configuration. > > This commit parses shared memory node at boot-time, and reserve it in > bootinfo.reserved_mem to avoid other use. > > This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap > static-shm-related codes, and this option depends on static memory( > CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few > helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, > on static shared memory. > > Signed-off-by: Penny Zheng > --- > v3 change: > - make nr_shm_domain unsigned int > --- > v2 change: > - document refinement > - remove bitmap and use the iteration to check > - add a new field nr_shm_domain to keep the number of shared domain > --- > docs/misc/arm/device-tree/booting.txt | 120 ++++++++++++++++++++++++++ > xen/arch/arm/Kconfig | 6 ++ > xen/arch/arm/bootfdt.c | 68 +++++++++++++++ > xen/arch/arm/include/asm/setup.h | 3 + > 4 files changed, 197 insertions(+) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index a94125394e..e63ce171fc 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -355,3 +355,123 @@ device-tree: > > This will reserve a 512MB region starting at the host physical address > 0x30000000 to be exclusively used by DomU1. > + > +Static Shared Memory > +==================== > + > +The static shared memory device tree nodes allow users to statically set up > +shared memory on dom0less system, enabling domains to do shm-based > +communication. > + > +- compatible > + > + "xen,domain-shared-memory-v1" > + > +- xen,shm-id > + > + An u8 value represents the unique identifier of the shared memory region. > + The maximum identifier shall be "xen,shm-id = <0xff>". NIT: a 8-bit integer that represent... Can be fixed on commit. Reviewed-by: Stefano Stabellini > +- xen,shared-mem > + > + An array takes a physical address, which is the base address of the > + shared memory region in host physical address space, a size, and a guest > + physical address, as the target address of the mapping. The number of cells > + for the host address (and size) is the same as the guest pseudo-physical > + address and they are inherited from the parent node. > + > +- role (Optional) > + > + A string property specifying the ownership of a shared memory region, > + the value must be one of the following: "owner", or "borrower" > + A shared memory region could be explicitly backed by one domain, which is > + called "owner domain", and all the other domains who are also sharing > + this region are called "borrower domain". > + If not specified, the default value is "borrower" and owner is > + "dom_shared", a system domain. > + > +As an example: > + > +chosen { > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; > + > + ...... > + > + /* this is for Dom0 */ > + dom0-shared-mem@10000000 { > + compatible = "xen,domain-shared-memory-v1"; > + role = "owner"; > + xen,shm-id = <0x0>; > + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; > + } > + > + domU1 { > + compatible = "xen,domain"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + memory = <0 131072>; > + cpus = <2>; > + vpl011; > + > + /* > + * shared memory region identified as 0x0(xen,shm-id = <0x0>) > + * is shared between Dom0 and DomU1. > + */ > + domU1-shared-mem@10000000 { > + compatible = "xen,domain-shared-memory-v1"; > + role = "borrower"; > + xen,shm-id = <0x0>; > + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; > + } > + > + /* > + * shared memory region identified as 0x1(xen,shm-id = <0x1>) > + * is shared between DomU1 and DomU2. > + */ > + domU1-shared-mem@50000000 { > + compatible = "xen,domain-shared-memory-v1"; > + xen,shm-id = <0x1>; > + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; > + } > + > + ...... > + > + }; > + > + domU2 { > + compatible = "xen,domain"; > + #address-cells = <0x1>; > + #size-cells = <0x1>; > + memory = <0 65536>; > + cpus = <1>; > + > + /* > + * shared memory region identified as 0x1(xen,shm-id = <0x1>) > + * is shared between domU1 and domU2. > + */ > + domU2-shared-mem@50000000 { > + compatible = "xen,domain-shared-memory-v1"; > + xen,shm-id = <0x1>; > + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; > + } > + > + ...... > + }; > +}; > + > +This is an example with two static shared memory regions. > + > +For the static shared memory region identified as 0x0, host physical > +address starting at 0x10000000 of 256MB will be reserved to be shared between > +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest physical address > +space, and at 0x50000000 in DomU1 guest physical address space. Dom0 is > +explicitly defined as the owner domain, and DomU1 is the borrower domain. > + > +For the static shared memory region identified as 0x1, host physical > +address starting at 0x50000000 of 512MB will be reserved to be shared between > +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical > +address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 > +and DomU2 are both the borrower domain, the owner domain is the default owner > +domain dom_shared. > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ecfa6822e4..5ee9921f56 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -106,6 +106,12 @@ config TEE > > source "arch/arm/tee/Kconfig" > > +config STATIC_SHM > + bool "Statically shared memory on a dom0less system" if UNSUPPORTED > + depends on STATIC_MEMORY > + help > + This option enables statically shared memory on a dom0less system. > + > endmenu > > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 29671c8df0..c8e8747c3e 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -360,6 +360,70 @@ static int __init process_domain_node(const void *fdt, int node, > size_cells, &bootinfo.reserved_mem, true); > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init process_shm_node(const void *fdt, int node, > + u32 address_cells, u32 size_cells) > +{ > + const struct fdt_property *prop; > + const __be32 *cell; > + paddr_t paddr, size; > + struct meminfo *mem = &bootinfo.reserved_mem; > + unsigned long i; > + > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); > + return -EINVAL; > + } > + > + prop = fdt_get_property(fdt, node, "xen,shared-mem", NULL); > + if ( !prop ) > + return -ENOENT; > + > + /* > + * xen,shared-mem = ; > + * Memory region starting from physical address #paddr of #size shall > + * be mapped to guest physical address #gaddr as static shared memory > + * region. > + */ > + cell = (const __be32 *)prop->data; > + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); > + for ( i = 0; i < mem->nr_banks; i++ ) > + { > + /* > + * A static shared memory region could be shared between multiple > + * domains. > + */ > + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) > + break; > + } > + > + if ( i == mem->nr_banks ) > + { > + if ( i < NR_MEM_BANKS ) > + { > + /* Static shared memory shall be reserved from any other use. */ > + mem->bank[mem->nr_banks].start = paddr; > + mem->bank[mem->nr_banks].size = size; > + mem->bank[mem->nr_banks].xen_domain = true; > + mem->nr_banks++; > + } > + else > + { > + printk("Warning: Max number of supported memory regions reached.\n"); > + return -ENOSPC; > + } > + } > + /* > + * keep a count of the number of domains, which later may be used to > + * calculate the number of the reference count. > + */ > + mem->bank[i].nr_shm_domain++; > + > + return 0; > +} > +#endif > + > static int __init early_scan_node(const void *fdt, > int node, const char *name, int depth, > u32 address_cells, u32 size_cells, > @@ -380,6 +444,10 @@ static int __init early_scan_node(const void *fdt, > process_chosen_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) > rc = process_domain_node(fdt, node, name, address_cells, size_cells); > +#ifdef CONFIG_STATIC_SHM > + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) > + rc = process_shm_node(fdt, node, address_cells, size_cells); > +#endif > > if ( rc < 0 ) > printk("fdt: node `%s': parsing failed\n", name); > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 7a1e1d6798..35449bd7d8 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -27,6 +27,9 @@ struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > +#ifdef CONFIG_STATIC_SHM > + unsigned int nr_shm_domain; > +#endif > }; > > struct meminfo { > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu May 12 23:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328045.550967 (Exim 4.92) (envelope-from ) id 1npIXI-0005K4-GG; Thu, 12 May 2022 23:48:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328045.550967; Thu, 12 May 2022 23:48:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIXI-0005Jp-Bb; Thu, 12 May 2022 23:48:00 +0000 Received: by outflank-mailman (input) for mailman id 328045; Thu, 12 May 2022 23:47:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIXG-0004h7-Vm for xen-devel@lists.xenproject.org; Thu, 12 May 2022 23:47:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2d541d3-d24d-11ec-a406-831a346695d4; Fri, 13 May 2022 01:47:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5ECD6208B; Thu, 12 May 2022 23:47:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB987C34113; Thu, 12 May 2022 23:47:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2d541d3-d24d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652399276; bh=rvrOc/ErrHvLIse3NcZiFcDuRPjdm8Xu6Sf2V39Eqfw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rdlW3sFbvySgvNPlqBKSbG8R0O59QShexHIQMCl/1dD9BCCSljd0eLSp7Ci8t/kk7 7pp2zSrimSCJuxkFH6uS8yS38/KcAu+nGBvSD66/dwGh+GXAG3RFrWSwSrufg03FNg 3qw9Hbu2Xjs6fBhdq/i0yVVGYTXLej36bAAiGNxDZ4n1AMpKj7+P0bBjLu5WY9g9JU bUutWPYVosgBk1+PJAA+Mf3p7nHCoRaeKnTowcA6LojW7QiX93aL9TOASr12wRMczq tIguFLz2rlX9gebP+ijG4MLUuQP6cLHCCZy1Qhzq89iRt2vQKfxUGgTp9bRb5npqnv ObCEqaPUkY0wg== Date: Thu, 12 May 2022 16:47:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v3 7/8] xen/arm: create shared memory nodes in guest device tree In-Reply-To: <20220512091129.2802997-8-Penny.Zheng@arm.com> Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-8-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 12 May 2022, Penny Zheng wrote: > We expose the shared memory to the domU using the "xen,shared-memory-v1" > reserved-memory binding. See > Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt > in Linux for the corresponding device tree binding. > > To save the cost of re-parsing shared memory device tree configuration when > creating shared memory nodes in guest device tree, this commit adds new field > "shm_mem" to store shm-info per domain. > > For each shared memory region, a range is exposed under > the /reserved-memory node as a child node. Each range sub-node is > named xen-shmem@
and has the following properties: > - compatible: > compatible = "xen,shared-memory-v1" > - reg: > the base guest physical address and size of the shared memory region > - xen,id: > a string that identifies the shared memory region. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v3 change: > - move field "shm_mem" to kernel_info > --- > v2 change: > - using xzalloc > - shm_id should be uint8_t > - make reg a local variable > - add #address-cells and #size-cells properties > - fix alignment > --- > xen/arch/arm/domain_build.c | 143 +++++++++++++++++++++++++++++- > xen/arch/arm/include/asm/kernel.h | 1 + > xen/arch/arm/include/asm/setup.h | 1 + > 3 files changed, 143 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index aa7c264e23..fb9146b6e0 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -892,7 +892,22 @@ static int __init allocate_shared_memory(struct domain *d, > return ret; > } > > -static int __init process_shm(struct domain *d, > +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > + paddr_t start, paddr_t size, > + u32 shm_id) > +{ > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > + return -ENOMEM; > + > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id = shm_id; > + kinfo->shm_mem.nr_banks++; > + > + return 0; > +} > + > +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > struct dt_device_node *shm_node; > @@ -963,6 +978,14 @@ static int __init process_shm(struct domain *d, > if ( ret ) > return ret; > } > + > + /* > + * Record static shared memory region info for later setting > + * up shm-node in guest device tree. > + */ > + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); > + if ( ret ) > + return ret; > } > > return 0; > @@ -1293,6 +1316,117 @@ static int __init make_memory_node(const struct domain *d, > return res; > } > > +#ifdef CONFIG_STATIC_SHM > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + unsigned long i = 0; > + int res = 0; > + > + if ( mem->nr_banks == 0 ) > + return -ENOENT; > + > + /* > + * For each shared memory region, a range is exposed under > + * the /reserved-memory node as a child node. Each range sub-node is > + * named xen-shmem@
. > + */ > + dt_dprintk("Create xen-shmem node\n"); > + > + for ( ; i < mem->nr_banks; i++ ) > + { > + uint64_t start = mem->bank[i].start; > + uint64_t size = mem->bank[i].size; > + uint8_t shm_id = mem->bank[i].shm_id; > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > + char buf[27]; > + const char compat[] = "xen,shared-memory-v1"; > + __be32 reg[4]; > + __be32 *cells; > + unsigned int len = (addrcells + sizecells) * sizeof(__be32); > + > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); > + res = fdt_begin_node(fdt, buf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > + if ( res ) > + return res; > + > + cells = reg; > + dt_child_set_range(&cells, addrcells, sizecells, start, size); > + > + res = fdt_property(fdt, "reg", reg, len); > + if ( res ) > + return res; > + > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", > + i, start, start + size); > + > + res = fdt_property_cell(fdt, "xen,id", shm_id); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + if ( res ) > + return res; > + } > + > + return res; > +} > +#else > +static int __init make_shm_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + ASSERT_UNREACHABLE(); > +} > +#endif > + > +static int __init make_resv_memory_node(const struct domain *d, > + void *fdt, > + int addrcells, int sizecells, > + struct meminfo *mem) > +{ > + int res = 0; > + /* Placeholder for reserved-memory\0 */ > + char resvbuf[16] = "reserved-memory"; > + > + if ( mem->nr_banks == 0 ) > + /* No shared memory provided. */ > + return 0; > + > + dt_dprintk("Create reserved-memory node\n"); > + > + res = fdt_begin_node(fdt, resvbuf); > + if ( res ) > + return res; > + > + res = fdt_property(fdt, "ranges", NULL, 0); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#address-cells", addrcells); > + if ( res ) > + return res; > + > + res = fdt_property_cell(fdt, "#size-cells", sizecells); > + if ( res ) > + return res; > + > + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); > + if ( res ) > + return res; > + > + res = fdt_end_node(fdt); > + > + return res; > +} > + > static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) > { > struct meminfo *ext_regions = data; > @@ -3029,6 +3163,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) > if ( ret ) > goto err; > > + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, > + &kinfo->shm_mem); > + if ( ret ) > + goto err; > + > /* > * domain_handle_dtb_bootmodule has to be called before the rest of > * the device tree is generated because it depends on the value of > @@ -3367,7 +3506,7 @@ static int __init construct_domU(struct domain *d, > assign_static_memory_11(d, &kinfo, node); > > #ifdef CONFIG_STATIC_SHM > - rc = process_shm(d, node); > + rc = process_shm(d, &kinfo, node); > if ( rc < 0 ) > return rc; > #endif > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index 874aa108a7..e089980b87 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -19,6 +19,7 @@ struct kernel_info { > void *fdt; /* flat device tree */ > paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ > struct meminfo mem; > + struct meminfo shm_mem; > > /* kernel entry point */ > paddr_t entry; > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 35449bd7d8..6cd45b6212 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -29,6 +29,7 @@ struct membank { > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > #ifdef CONFIG_STATIC_SHM > unsigned int nr_shm_domain; > + uint8_t shm_id ; /* ID identifier of a static shared memory bank. */ > #endif > }; > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu May 12 23:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328043.550945 (Exim 4.92) (envelope-from ) id 1npIXA-0004hX-Qr; Thu, 12 May 2022 23:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328043.550945; Thu, 12 May 2022 23:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIXA-0004hQ-NH; Thu, 12 May 2022 23:47:52 +0000 Received: by outflank-mailman (input) for mailman id 328043; Thu, 12 May 2022 23:47:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIX8-0004h7-N5 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 23:47:50 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed80eddb-d24d-11ec-a406-831a346695d4; Fri, 13 May 2022 01:47:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7034662050; Thu, 12 May 2022 23:47:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CE0EC385B8; Thu, 12 May 2022 23:47:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed80eddb-d24d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652399266; bh=bpMUX5bxRCVGBW4bA+5o/RvoQkmqxB9En86sYJgzRcA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cFxjO4k8hyc1oRN//Nhd8wL++5io+4e5/yyyyyv0LPViakibdi+DstM0lZcI9Fq+0 kfVCe+WDbPcg34nG0Ikng30Gtl10+Sh6XG50qk9o5+VXEs5wtQbdW69Utu96K35iUJ E0QksLQft/jjpXQ+AshdaVew89cD3P12MZhP4cPvsmpxYh8nNmBviVqWUtl/YZAK/T 3/J2q33+K9UowKyXigj0JQx+Y44pnuBNuvLcUl2EWT0fSdcHm5G/DvOUTrqOV1pLrw G2aUXB5zCfH7g/djVbQiOLsYENVaSOZi/IPcQCxSAKpM/eXCRqw6XeldLup9Yb8AUt JQ67fp8Zb0KTg== Date: Thu, 12 May 2022 16:47:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 2/8] xen/arm: allocate static shared memory to the default owner dom_io In-Reply-To: <20220512091129.2802997-3-Penny.Zheng@arm.com> Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-3-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 12 May 2022, Penny Zheng wrote: > From: Penny Zheng > > This commit introduces process_shm to cope with static shared memory in > domain construction. > > DOMID_IO will be the default owner of memory pre-shared among multiple domains > at boot time, when no explicit owner is specified. > > This commit only considers allocating static shared memory to dom_io > when owner domain is not explicitly defined in device tree, all the left, > including the "borrower" code path, the "explicit owner" code path, shall > be introduced later in the following patches. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v3 change: > - refine in-code comment > --- > v2 change: > - instead of introducing a new system domain, reuse the existing dom_io > - make dom_io a non-auto-translated domain, then no need to create P2M > for it > - change dom_io definition and make it wider to support static shm here too > - introduce is_shm_allocated_to_domio to check whether static shm is > allocated yet, instead of using shm_mask bitmap > - add in-code comment > --- > xen/arch/arm/domain_build.c | 132 +++++++++++++++++++++++++++++++++++- > xen/common/domain.c | 5 ++ > 2 files changed, 136 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 1472ca4972..5b41ec57f0 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -519,6 +519,10 @@ static bool __init append_static_memory_to_bank(struct domain *d, > return true; > } > > +/* > + * If cell is NULL, pbase and psize should hold valid values. > + * Otherwise, cell will be populated together with pbase and psize. > + */ > static mfn_t __init acquire_static_memory_bank(struct domain *d, > const __be32 **cell, > u32 addr_cells, u32 size_cells, > @@ -527,7 +531,8 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, > mfn_t smfn; > int res; > > - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); > + if ( cell ) > + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); > ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); > if ( PFN_DOWN(*psize) > UINT_MAX ) > { > @@ -751,6 +756,125 @@ static void __init assign_static_memory_11(struct domain *d, > panic("Failed to assign requested static memory for direct-map domain %pd.", > d); > } > + > +#ifdef CONFIG_STATIC_SHM > +/* > + * This function checks whether the static shared memory region is > + * already allocated to dom_io. > + */ > +static bool __init is_shm_allocated_to_domio(paddr_t pbase) > +{ > + struct page_info *page; > + > + page = maddr_to_page(pbase); > + ASSERT(page); > + > + if ( page_get_owner(page) == NULL ) > + return false; > + > + ASSERT(page_get_owner(page) == dom_io); > + return true; > +} > + > +static mfn_t __init acquire_shared_memory_bank(struct domain *d, > + u32 addr_cells, u32 size_cells, > + paddr_t *pbase, paddr_t *psize) > +{ > + /* > + * Pages of statically shared memory shall be included > + * in domain_tot_pages(). > + */ > + d->max_pages += PFN_DOWN(*psize); > + > + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, > + pbase, psize); > + > +} > + > +/* > + * Func allocate_shared_memory is supposed to be only called > + * from the owner. > + */ > +static int __init allocate_shared_memory(struct domain *d, > + u32 addr_cells, u32 size_cells, > + paddr_t pbase, paddr_t psize) > +{ > + mfn_t smfn; > + > + dprintk(XENLOG_INFO, > + "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > + pbase, pbase + psize); > + > + smfn = acquire_shared_memory_bank(d, addr_cells, size_cells, &pbase, > + &psize); > + if ( mfn_eq(smfn, INVALID_MFN) ) > + return -EINVAL; > + > + /* > + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > + * It sees RAM 1:1 and we do not need to create P2M mapping for it > + */ > + ASSERT(d == dom_io); > + return 0; > +} > + > +static int __init process_shm(struct domain *d, > + const struct dt_device_node *node) > +{ > + struct dt_device_node *shm_node; > + int ret = 0; > + const struct dt_property *prop; > + const __be32 *cells; > + u32 shm_id; > + u32 addr_cells, size_cells; > + paddr_t gbase, pbase, psize; > + > + dt_for_each_child_node(node, shm_node) > + { > + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > + continue; > + > + if ( !dt_property_read_u32(shm_node, "xen,shm-id", &shm_id) ) > + { > + printk("Shared memory node does not provide \"xen,shm-id\" property.\n"); > + return -ENOENT; > + } > + > + addr_cells = dt_n_addr_cells(shm_node); > + size_cells = dt_n_size_cells(shm_node); > + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); > + if ( !prop ) > + { > + printk("Shared memory node does not provide \"xen,shared-mem\" property.\n"); > + return -ENOENT; > + } > + cells = (const __be32 *)prop->value; > + /* xen,shared-mem = ; */ > + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); > + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > + gbase = dt_read_number(cells, addr_cells); > + > + /* TODO: Consider owner domain is not the default dom_io. */ > + /* > + * Per static shared memory region could be shared between multiple > + * domains. > + * In case re-allocating the same shared memory region, we check > + * if it is already allocated to the default owner dom_io before > + * the actual allocation. > + */ > + if ( !is_shm_allocated_to_domio(pbase) ) > + { > + /* Allocate statically shared pages to the default owner dom_io. */ > + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, > + pbase, psize); > + if ( ret ) > + return ret; > + } > + } > + > + return 0; > +} > +#endif /* CONFIG_STATIC_SHM */ > #else > static void __init allocate_static_memory(struct domain *d, > struct kernel_info *kinfo, > @@ -3149,6 +3273,12 @@ static int __init construct_domU(struct domain *d, > else > assign_static_memory_11(d, &kinfo, node); > > +#ifdef CONFIG_STATIC_SHM > + rc = process_shm(d, node); > + if ( rc < 0 ) > + return rc; > +#endif > + > /* > * Base address and irq number are needed when creating vpl011 device > * tree node in prepare_dtb_domU, so initialization on related variables > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 8d2c2a9897..43237c287a 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -780,6 +780,11 @@ void __init setup_system_domains(void) > * This domain owns I/O pages that are within the range of the page_info > * array. Mappings occur at the priv of the caller. > * Quarantined PCI devices will be associated with this domain. > + * > + * DOMID_IO could also be used for mapping memory when no explicit > + * domain is specified. > + * For instance, DOMID_IO is the owner of memory pre-shared among > + * multiple domains at boot time, when no explicit owner is specified. > */ > dom_io = domain_create(DOMID_IO, NULL, 0); > if ( IS_ERR(dom_io) ) > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu May 12 23:48:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328044.550956 (Exim 4.92) (envelope-from ) id 1npIXE-0004yr-3y; Thu, 12 May 2022 23:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328044.550956; Thu, 12 May 2022 23:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIXD-0004yh-Va; Thu, 12 May 2022 23:47:55 +0000 Received: by outflank-mailman (input) for mailman id 328044; Thu, 12 May 2022 23:47:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIXC-0004h7-JJ for xen-devel@lists.xenproject.org; Thu, 12 May 2022 23:47:54 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f07ed6ac-d24d-11ec-a406-831a346695d4; Fri, 13 May 2022 01:47:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 913B4B82BCC; Thu, 12 May 2022 23:47:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB542C385B8; Thu, 12 May 2022 23:47:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f07ed6ac-d24d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652399271; bh=NXFxOp/Qrwd2viPanIbIngggvGhBsOgWSXzae41CLJI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=srGg3Gyx6aSv/preyE6WBA5JMAeKecV03H9HZ3AqcVc2gAPWyHqh6HwSh6OT1e898 DeyclPGz/oyjSy1QsZv17ZBQaKPF5KehIlL/RQxI9CxUSoJQzZlq25pkCYjWPgjUKS RgffI784WHVtDQhiw28qHgfW5tGtIHztvPApsWW+eDk+13/aLApVtTPz1mPSfaBPjs SzuLs1a9z0TjqZd1kLnp825yw0cpdM17sTtABoyE1RQksYxZ0AGW3usrMNv/VeT9pY i22pu3quNkC+ybyzwihF+fYryB+r1rcqFCiC6ALIsfBuD75S97OTn5GbqV0w0DTu1J jHzJWUbCLudZg== Date: Thu, 12 May 2022 16:47:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v3 3/8] xen/arm: allocate static shared memory to a specific owner domain In-Reply-To: <20220512091129.2802997-4-Penny.Zheng@arm.com> Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-4-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 12 May 2022, Penny Zheng wrote: > If owner property is defined, then owner domain of a static shared memory > region is not the default dom_io anymore, but a specific domain. > > This commit implements allocating static shared memory to a specific domain > when owner property is defined. > > Coding flow for dealing borrower domain will be introduced later in the > following commits. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v3 change: > - simplify the code since o_gbase is not used if the domain is dom_io > --- > v2 change: > - P2M mapping is restricted to normal domain > - in-code comment fix > --- > xen/arch/arm/domain_build.c | 44 +++++++++++++++++++++++++++---------- > 1 file changed, 33 insertions(+), 11 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 5b41ec57f0..9c53b9fa7b 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -797,9 +797,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > */ > static int __init allocate_shared_memory(struct domain *d, > u32 addr_cells, u32 size_cells, > - paddr_t pbase, paddr_t psize) > + paddr_t pbase, paddr_t psize, > + paddr_t gbase) > { > mfn_t smfn; > + int ret = 0; > > dprintk(XENLOG_INFO, > "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > @@ -814,8 +816,18 @@ static int __init allocate_shared_memory(struct domain *d, > * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > * It sees RAM 1:1 and we do not need to create P2M mapping for it > */ > - ASSERT(d == dom_io); > - return 0; > + if ( d != dom_io ) > + { > + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > + if ( ret ) > + { > + printk(XENLOG_ERR > + "Failed to map shared memory to %pd.\n", d); > + return ret; > + } > + } > + > + return ret; > } > > static int __init process_shm(struct domain *d, > @@ -828,6 +840,8 @@ static int __init process_shm(struct domain *d, > u32 shm_id; > u32 addr_cells, size_cells; > paddr_t gbase, pbase, psize; > + const char *role_str; > + bool owner_dom_io = true; > > dt_for_each_child_node(node, shm_node) > { > @@ -854,19 +868,27 @@ static int __init process_shm(struct domain *d, > ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > gbase = dt_read_number(cells, addr_cells); > > - /* TODO: Consider owner domain is not the default dom_io. */ > + /* > + * "role" property is optional and if it is defined explicitly, > + * then the owner domain is not the default "dom_io" domain. > + */ > + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) > + owner_dom_io = false; > + > /* > * Per static shared memory region could be shared between multiple > * domains. > - * In case re-allocating the same shared memory region, we check > - * if it is already allocated to the default owner dom_io before > - * the actual allocation. > + * So when owner domain is the default dom_io, in case re-allocating > + * the same shared memory region, we check if it is already allocated > + * to the default owner dom_io before the actual allocation. > */ > - if ( !is_shm_allocated_to_domio(pbase) ) > + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > - /* Allocate statically shared pages to the default owner dom_io. */ > - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, > - pbase, psize); > + /* Allocate statically shared pages to the owner domain. */ > + ret = allocate_shared_memory(owner_dom_io ? dom_io : d, > + addr_cells, size_cells, > + pbase, psize, gbase); > if ( ret ) > return ret; > } > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu May 12 23:55:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 12 May 2022 23:55:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328071.550978 (Exim 4.92) (envelope-from ) id 1npIe7-0007h2-8O; Thu, 12 May 2022 23:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328071.550978; Thu, 12 May 2022 23:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIe7-0007gv-53; Thu, 12 May 2022 23:55:03 +0000 Received: by outflank-mailman (input) for mailman id 328071; Thu, 12 May 2022 23:55:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIe5-0007gi-Nn; Thu, 12 May 2022 23:55:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIe5-0002oN-KM; Thu, 12 May 2022 23:55:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npIe5-0003T4-6v; Thu, 12 May 2022 23:55:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npIe5-00046M-6Q; Thu, 12 May 2022 23:55:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5N4sAxRKULoqUUDliOZR2K+szSY++zO5Oc7+CQ4sy0c=; b=trzQOCoTCH7GLj8NTtL2GKUSma eJOBSo+6bVgCCpYHw5nMqy0k1pjMk7tpRwcvJYAFzbyd6rAoLskhLGUFOh6dGKSXZ3MOHkSuwUA3W oBCbko2/wRYuJtxlse+T3eHQkzf9nA1NRNYFHAqWdZ9g8l8Qcf/FI2MN5wDDaR4GNr5g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170371: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 12 May 2022 23:55:01 +0000 flight 170371 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170371/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 971 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 00:33:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 00:33:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328080.550988 (Exim 4.92) (envelope-from ) id 1npJEt-0003wL-Pa; Fri, 13 May 2022 00:33:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328080.550988; Fri, 13 May 2022 00:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJEt-0003wE-Mn; Fri, 13 May 2022 00:33:03 +0000 Received: by outflank-mailman (input) for mailman id 328080; Fri, 13 May 2022 00:33:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJEr-0003w7-VK for xen-devel@lists.xenproject.org; Fri, 13 May 2022 00:33:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3dae0c5e-d254-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 02:33:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 294EA620A7; Fri, 13 May 2022 00:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF13AC34113; Fri, 13 May 2022 00:32:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dae0c5e-d254-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652401978; bh=mJEFxR3D2mwBmlg9euCPAxtD5PlfuLv6x1KLxUN9VxM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=i6iljFMfrwUq3koJL5gxLbiQ9E/xH0GqfQhxMsY58+8/GE93KOFUyIDBOo7L1ZmVo nTcE/ft4lx9eQhQo/ZQrz3sff5ParUJJpJpr1FUiexpYS8HCOjOmBsaiEkaAVjRTFu 52MjRH4Z4jdyRGqvEO9Udh22pq3hfn0mPE8H1Adva+LuTUHIbY+aMC9XN8XO4FT8AY m59e3qm5PzD/1l3r/QXUtyQBKhcVrk9WXgnmBlZ9hnYL/lmdbVphrZMvOok+mxvg/F okzOWRIm86Q0qSpVD3n7t7h/2yT1bJlk2xDucSRpRVp6j330c0PPdafej+FCSK9JGr 8sLIX6HUODNTg== Date: Thu, 12 May 2022 17:32:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: xen-devel@lists.xenproject.org, nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jiamei Xie Subject: Re: [PATCH v3 4/9] xen: introduce an arch helper for default dma zone status In-Reply-To: <20220511014639.197825-5-wei.chen@arm.com> Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-5-wei.chen@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Wei Chen wrote: > In current code, when Xen is running in a multiple nodes > NUMA system, it will set dma_bitsize in end_boot_allocator > to reserve some low address memory as DMA zone. > > There are some x86 implications in the implementation. > Because on x86, memory starts from 0. On a multiple-nodes > NUMA system, if a single node contains the majority or all > of the DMA memory, x86 prefers to give out memory from > non-local allocations rather than exhausting the DMA memory > ranges. Hence x86 uses dma_bitsize to set aside some largely > arbitrary amount of memory for DMA zone. The allocations > from DMA zone would happen only after exhausting all other > nodes' memory. > > But the implications are not shared across all architectures. > For example, Arm cannot guarantee the availability of memory > below a certain boundary for DMA limited-capability devices > either. But currently, Arm doesn't need a reserved DMA zone > in Xen. Because there is no DMA device in Xen. And for guests, > Xen Arm only allows Dom0 to have DMA operations without IOMMU. > Xen will try to allocate memory under 4GB or memory range that > is limited by dma_bitsize for Dom0 in boot time. For DomU, even > Xen can passthrough devices to DomU without IOMMU, but Xen Arm > doesn't guarantee their DMA operations. So, Xen Arm doesn't > need a reserved DMA zone to provide DMA memory for guests. > > In this patch, we introduce an arch_want_default_dmazone helper > for different architectures to determine whether they need to > set dma_bitsize for DMA zone reservation or not. > > At the same time, when x86 Xen is built with CONFIG_PV=n could > probably leverage this new helper to actually not trigger DMA > zone reservation. > > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie Reviewed-by: Stefano Stabellini > --- > v2 -> v3: > 1. Add Tb. > 2. Rename arch_have_default_dmazone to arch_want_default_dmazone. > v1 -> v2: > 1. Extend the description of Arm's workaround for reserve DMA > allocations to avoid the same discussion every time. > 2. Use a macro to define arch_have_default_dmazone, because > it's little hard to make x86 version to static inline. > Use a macro will also avoid add __init for this function. > 3. Change arch_have_default_dmazone return value from > unsigned int to bool. > 4. Un-addressed comment: make arch_have_default_dmazone > of x86 to be static inline. Because, if we move > arch_have_default_dmazone to x86/asm/numa.h, it depends > on nodemask.h to provide num_online_nodes. But nodemask.h > needs numa.h to provide MAX_NUMANODES. This will cause a > loop dependency. And this function can only be used in > end_boot_allocator, in Xen initialization. So I think, > compared to the changes introduced by inline, it doesn't > mean much. > --- > xen/arch/arm/include/asm/numa.h | 1 + > xen/arch/x86/include/asm/numa.h | 1 + > xen/common/page_alloc.c | 2 +- > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h > index 31a6de4e23..e4c4d89192 100644 > --- a/xen/arch/arm/include/asm/numa.h > +++ b/xen/arch/arm/include/asm/numa.h > @@ -24,6 +24,7 @@ extern mfn_t first_valid_mfn; > #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) > #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) > #define __node_distance(a, b) (20) > +#define arch_want_default_dmazone() (false) > > #endif /* __ARCH_ARM_NUMA_H */ > /* > diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h > index bada2c0bb9..5d8385f2e1 100644 > --- a/xen/arch/x86/include/asm/numa.h > +++ b/xen/arch/x86/include/asm/numa.h > @@ -74,6 +74,7 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) > #define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) > #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ > NODE_DATA(nid)->node_spanned_pages) > +#define arch_want_default_dmazone() (num_online_nodes() > 1) > > extern int valid_numa_range(u64 start, u64 end, nodeid_t node); > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 319029140f..b3bddc719b 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void) > } > nr_bootmem_regions = 0; > > - if ( !dma_bitsize && (num_online_nodes() > 1) ) > + if ( !dma_bitsize && arch_want_default_dmazone() ) > dma_bitsize = arch_get_dma_bitsize(); > > printk("Domain heap initialised"); > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri May 13 00:33:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 00:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328083.551000 (Exim 4.92) (envelope-from ) id 1npJFf-0004Ph-4F; Fri, 13 May 2022 00:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328083.551000; Fri, 13 May 2022 00:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJFf-0004Pa-1D; Fri, 13 May 2022 00:33:51 +0000 Received: by outflank-mailman (input) for mailman id 328083; Fri, 13 May 2022 00:33:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJFe-0004NS-5k for xen-devel@lists.xenproject.org; Fri, 13 May 2022 00:33:50 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5b28d3cd-d254-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 02:33:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6B10DB82910; Fri, 13 May 2022 00:33:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5EA6C385B8; Fri, 13 May 2022 00:33:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b28d3cd-d254-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652402027; bh=0a9RljrqdnoGvOyCZreIEw76Ve51f4TbMzy0QGHf4qY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aGM8gHmnZm8qcTel8TDv4cid04RpmQCQ7G7vunPLYljWsQ//vIQy/9DVumZObDCBr 2qIRzKqstHjKrIzCgeFk80wtZgkbWp9eSBa1KZ53iozKb55H9f6RenwCy6r0PKsXFh tWOy9yUS0pN7YkRlw9InaUYua1tAlbmIX4o8ylEWtFs60lUatviogHaI4fP8mxIF2r AZuovRXQwmvxVs/wnjw22zbCdL2u9pdafE8Pwwjpdl085ZjxtDT+C8U4Pys9jdMqFJ l4apYYNNqknrB4U/heJfEmQ3zRx9jq/2+UtgzI3+T/joWCG+iYPXOV8yaX73i7pI4/ ya3dyUU6Ilg3A== Date: Thu, 12 May 2022 17:33:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: xen-devel@lists.xenproject.org, nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm In-Reply-To: <20220511014639.197825-3-wei.chen@arm.com> Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Wei Chen wrote: > x86 is using compiler feature testing to decide EFI build > enable or not. When EFI build is disabled, x86 will use an > efi/stub.c file to replace efi/runtime.c for build objects. > Following this idea, we introduce a stub file for Arm, but > use CONFIG_ARM_EFI to decide EFI build enable or not. > > And the most functions in x86 EFI stub.c can be reused for > other architectures, like Arm. So we move them to common > and keep the x86 specific function in x86/efi/stub.c. > > To avoid the symbol link conflict error when linking common > stub files to x86/efi. We add a regular file check in efi > stub files' link script. Depends on this check we can bypass > the link behaviors for existed stub files in x86/efi. > > As there is no Arm specific EFI stub function for Arm in > current stage, Arm still can use the existed symbol link > method for EFI stub files. > > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie The ARM side looks OK to me, I'll let Jan comment on the x86 side. > --- > v2 -> v3: > 1. Add existed file check, if a regular stub files, > the common/stub files' link will be ignored. > 2. Keep stub.c in x86/efi to include common/efi/stub.c > 3. Restore efi_compat_xxx stub functions to x86/efi.c. > Other architectures will not use efi_compat_xxx. > 4. Remove ARM_EFI dependency from ARM_64. > 5. Add comment for adding stub.o to EFIOBJ-y. > 6. Merge patch#2 and patch#3 to one patch. > v1 -> v2: > 1. Drop the copy of stub.c from Arm EFI. > 2. Share common codes of x86 EFI stub for other architectures. > 3. Use CONFIG_ARM_EFI to replace CONFIG_EFI > 4. Remove help text and make CONFIG_ARM_EFI invisible. > 5. Merge one following patch: > xen/arm: introduce a stub file for non-EFI architectures > 6. Use the common stub.c instead of creating new one. > --- > xen/arch/arm/Kconfig | 4 ++++ > xen/arch/arm/Makefile | 2 +- > xen/arch/arm/efi/Makefile | 8 ++++++++ > xen/arch/x86/efi/stub.c | 32 +------------------------------- > xen/common/efi/efi-common.mk | 3 ++- > xen/common/efi/stub.c | 32 ++++++++++++++++++++++++++++++++ > 6 files changed, 48 insertions(+), 33 deletions(-) > create mode 100644 xen/common/efi/stub.c > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ecfa6822e4..8a16d43bd5 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -6,6 +6,7 @@ config ARM_64 > def_bool y > depends on !ARM_32 > select 64BIT > + select ARM_EFI > select HAS_FAST_MULTIPLY > > config ARM > @@ -33,6 +34,9 @@ config ACPI > Advanced Configuration and Power Interface (ACPI) support for Xen is > an alternative to device tree on ARM64. > > +config ARM_EFI > + bool > + > config GICV3 > bool "GICv3 driver" > depends on ARM_64 && !NEW_VGIC > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 1d862351d1..bb7a6151c1 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -1,6 +1,5 @@ > obj-$(CONFIG_ARM_32) += arm32/ > obj-$(CONFIG_ARM_64) += arm64/ > -obj-$(CONFIG_ARM_64) += efi/ > obj-$(CONFIG_ACPI) += acpi/ > obj-$(CONFIG_HAS_PCI) += pci/ > ifneq ($(CONFIG_NO_PLAT),y) > @@ -20,6 +19,7 @@ obj-y += domain.o > obj-y += domain_build.init.o > obj-y += domctl.o > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > +obj-y += efi/ > obj-y += gic.o > obj-y += gic-v2.o > obj-$(CONFIG_GICV3) += gic-v3.o > diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile > index 4313c39066..dffe72e589 100644 > --- a/xen/arch/arm/efi/Makefile > +++ b/xen/arch/arm/efi/Makefile > @@ -1,4 +1,12 @@ > include $(srctree)/common/efi/efi-common.mk > > +ifeq ($(CONFIG_ARM_EFI),y) > obj-y += $(EFIOBJ-y) > obj-$(CONFIG_ACPI) += efi-dom0.init.o > +else > +# Add stub.o to EFIOBJ-y to re-use the clean-files in > +# efi-common.mk. Otherwise the link of stub.c in arm/efi > +# will not be cleaned in "make clean". > +EFIOBJ-y += stub.o > +obj-y += stub.o > +endif > diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub.c > index 9984932626..f2365bc041 100644 > --- a/xen/arch/x86/efi/stub.c > +++ b/xen/arch/x86/efi/stub.c > @@ -1,7 +1,5 @@ > #include > -#include > #include > -#include > #include > #include > #include > @@ -10,6 +8,7 @@ > #include > #include > #include > +#include "../../../common/efi/stub.c" > > /* > * Here we are in EFI stub. EFI calls are not supported due to lack > @@ -45,11 +44,6 @@ void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle, > unreachable(); > } > > -bool efi_enabled(unsigned int feature) > -{ > - return false; > -} > - > void __init efi_init_memory(void) { } > > bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) > @@ -62,32 +56,8 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) > > void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { } > > -bool efi_rs_using_pgtables(void) > -{ > - return false; > -} > - > -unsigned long efi_get_time(void) > -{ > - BUG(); > - return 0; > -} > - > -void efi_halt_system(void) { } > -void efi_reset_system(bool warm) { } > - > -int efi_get_info(uint32_t idx, union xenpf_efi_info *info) > -{ > - return -ENOSYS; > -} > - > int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *) > __attribute__((__alias__("efi_get_info"))); > > -int efi_runtime_call(struct xenpf_efi_runtime_call *op) > -{ > - return -ENOSYS; > -} > - > int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *) > __attribute__((__alias__("efi_runtime_call"))); > diff --git a/xen/common/efi/efi-common.mk b/xen/common/efi/efi-common.mk > index 4298ceaee7..3a5b9958b3 100644 > --- a/xen/common/efi/efi-common.mk > +++ b/xen/common/efi/efi-common.mk > @@ -9,7 +9,8 @@ CFLAGS-y += -iquote $(srcdir) > # e.g.: It transforms "dir/foo/bar" into successively > # "dir foo bar", ".. .. ..", "../../.." > $(obj)/%.c: $(srctree)/common/efi/%.c FORCE > - $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( + $(Q)test -f $@ || \ > + ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( > clean-files += $(patsubst %.o, %.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-)) > > diff --git a/xen/common/efi/stub.c b/xen/common/efi/stub.c > new file mode 100644 > index 0000000000..15694632c2 > --- /dev/null > +++ b/xen/common/efi/stub.c > @@ -0,0 +1,32 @@ > +#include > +#include > +#include > + > +bool efi_enabled(unsigned int feature) > +{ > + return false; > +} > + > +bool efi_rs_using_pgtables(void) > +{ > + return false; > +} > + > +unsigned long efi_get_time(void) > +{ > + BUG(); > + return 0; > +} > + > +void efi_halt_system(void) { } > +void efi_reset_system(bool warm) { } > + > +int efi_get_info(uint32_t idx, union xenpf_efi_info *info) > +{ > + return -ENOSYS; > +} > + > +int efi_runtime_call(struct xenpf_efi_runtime_call *op) > +{ > + return -ENOSYS; > +} > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri May 13 00:43:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 00:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328095.551011 (Exim 4.92) (envelope-from ) id 1npJOc-00063B-4L; Fri, 13 May 2022 00:43:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328095.551011; Fri, 13 May 2022 00:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJOc-000634-1Q; Fri, 13 May 2022 00:43:06 +0000 Received: by outflank-mailman (input) for mailman id 328095; Fri, 13 May 2022 00:43:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJOa-00062y-OQ for xen-devel@lists.xenproject.org; Fri, 13 May 2022 00:43:04 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a59a58aa-d255-11ec-a406-831a346695d4; Fri, 13 May 2022 02:43:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7827B82BA8; Fri, 13 May 2022 00:43:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F606C385B8; Fri, 13 May 2022 00:43:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a59a58aa-d255-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652402580; bh=GftiBl3MxVgceXxWJkt1OZ96GW6H0KC6Xjrc58U0t5w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PJ6dtMx+uTKIhg1ihxrOFIu4WJQ9VLhwt9ZKJFvy3U0uVR0EJrMno/FlJz3sUruYf 0lNMZCEQbgQOiveV1RFXIXwlDYzfvx+t88mPBK/cuUExyI7heJWes61dDKgsSClzN8 vGobvVP19jQr/gkiQ3RElacW0T3n4xcZM8bYaIhdTQOclN6M0k7uduxZhQlHnjow+E EI/67BvDiD8EnwwMGIfgNWAlYC5SAOg/Rdp+0L8PPyqtfmc55FsqiGYZW79TjsTZHa YjUhQQw2Xv71juaGoN8y63C/XdukBL3SF/F7yamOs2LEjpyVCXrQ3CwY4cw2TGbaZX 2A1y9FdXNda9w== Date: Thu, 12 May 2022 17:43:00 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: Bertrand Marquis , Jan Beulich , "andrew.cooper3@citrix.com" , "julien@xen.org" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" Subject: Re: ECLAIR Xen x86 results and progress In-Reply-To: Message-ID: References: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 9 May 2022, Stefano Stabellini wrote: > On Mon, 9 May 2022, Bertrand Marquis wrote: > > > On 6 May 2022, at 17:31, Stefano Stabellini wrote: > > > > > > Hi all, > > > > > > Roberto kindly provided the ECLAIR x86 results: > > > > > > https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ > > > > > > Click on "See ECLAIR in action", then you can select "Show 100 entries" > > > and see all the results in one page. As an example MC3R1.R1.3 > > > corresponds to Rule 1.3 in the spreadsheet. > > > > > > > > > If you are OK with this, I would like to aim at a follow-up meeting on > > > Tue May 17 at the same time (8AM California / 4PM UK). If the date/time > > > doesn't work, I'll run another Doodle poll. > > > > Works for me. > > Actually, to make sure more people are able to attend, I would like to > suggest May 19 8AM California / 4PM UK / 5PM Europe (which is the same > slot typically used by the Xen Community Call). Please let me know if > that works or if it is a problem. Quick update: we are making excellent progress with the spreadsheet, 4 out of 6 people have already completed scoring the first set of 20 rules. I'll send a calendar invite for May 19 8AM California as it looks like we'll be able to make it. From xen-devel-bounces@lists.xenproject.org Fri May 13 01:03:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:03:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328104.551022 (Exim 4.92) (envelope-from ) id 1npJiW-0006hG-SW; Fri, 13 May 2022 01:03:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328104.551022; Fri, 13 May 2022 01:03:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJiW-0006h9-P4; Fri, 13 May 2022 01:03:40 +0000 Received: by outflank-mailman (input) for mailman id 328104; Fri, 13 May 2022 01:03:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJiV-0006gz-5Z; Fri, 13 May 2022 01:03:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJiV-0002Sq-2I; Fri, 13 May 2022 01:03:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJiU-0007jp-Jz; Fri, 13 May 2022 01:03:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npJiU-00025C-JX; Fri, 13 May 2022 01:03:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IrjrgieO1mI4Y9kAjue1BI+clbIv/ehRvx668HbbRHg=; b=jTpk6lx8IhagG2tb+DZXpRgEDT CbY3+gQsSaa8fCagEn8YYR6GPAsTc2FAkSXmdwFC+rAFV+zrZJfQrJVj67QvEi6WGjJ30mALIkqN4 zs9tLrZob39YRJangS7nSJVcVAOm8eaZ6mbM63DOZkc8URLLiNb9fWe90Fi7yR1qP1H4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170362: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b32b3897f8b8f2f17425c22ea229ea6ebcb7d552 X-Osstest-Versions-That: qemuu=ec11dc41eec5142b4776db1296972c6323ba5847 From: osstest service owner Date: Fri, 13 May 2022 01:03:38 +0000 flight 170362 qemu-mainline real [real] flight 170372 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170362/ http://logs.test-lab.xenproject.org/osstest/logs/170372/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 170372-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170334 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170334 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170334 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170334 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170334 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170334 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170334 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170334 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170334 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu b32b3897f8b8f2f17425c22ea229ea6ebcb7d552 baseline version: qemuu ec11dc41eec5142b4776db1296972c6323ba5847 Last test of basis 170334 2022-05-11 18:38:17 Z 1 days Testing same since 170362 2022-05-12 17:37:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Eric Blake Hanna Reitz Hiroki Narukawa Kevin Wolf Paolo Bonzini Philippe Mathieu-Daudé Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ec11dc41ee..b32b3897f8 b32b3897f8b8f2f17425c22ea229ea6ebcb7d552 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 13 01:07:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328112.551032 (Exim 4.92) (envelope-from ) id 1npJmb-0007Ir-EB; Fri, 13 May 2022 01:07:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328112.551032; Fri, 13 May 2022 01:07:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJmb-0007Ik-BP; Fri, 13 May 2022 01:07:53 +0000 Received: by outflank-mailman (input) for mailman id 328112; Fri, 13 May 2022 01:07:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJmZ-0007IW-Qf; Fri, 13 May 2022 01:07:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJmZ-0002XM-Pw; Fri, 13 May 2022 01:07:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJmZ-0007ve-Fu; Fri, 13 May 2022 01:07:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npJmZ-0000pH-FR; Fri, 13 May 2022 01:07:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RxVSiLcFth5nQ3FatRG041jzCb4xvmtpBTO5AJkj1vI=; b=Jnt2CyLMNEp3N6h6EvCoTmhySa w3siYwoMoQDcsf6A5uE+ok1owuM44Zl8/pBROH6ZsS58Ixi4roVgVB316XtDJahxfQBpz/COBIVKG RNVqcWBkj/9JLO+CJieEA+tvYPYEAfC3vq5n1gxzGKI2gKUqcUUlcBrJHz7VbxEHWIeY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170373: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=deee7a100b2539d8a302c6d37344b507f8312faa X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 01:07:51 +0000 flight 170373 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170373/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf deee7a100b2539d8a302c6d37344b507f8312faa baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 72 days 972 attempts Testing same since 170321 2022-05-11 09:11:39 Z 1 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6459 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 01:09:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328122.551044 (Exim 4.92) (envelope-from ) id 1npJnx-0007y2-08; Fri, 13 May 2022 01:09:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328122.551044; Fri, 13 May 2022 01:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJnw-0007xv-TQ; Fri, 13 May 2022 01:09:16 +0000 Received: by outflank-mailman (input) for mailman id 328122; Fri, 13 May 2022 01:09:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJnv-0007xl-JS for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:09:15 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4db30613-d259-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 03:09:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C480B82C27; Fri, 13 May 2022 01:09:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96BBBC385B8; Fri, 13 May 2022 01:09:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4db30613-d259-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652404152; bh=+O2eOVFk4fd6Wn2HurEWZ5sH1IZOh+m/T6lpcaNucBk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TmeYWuo38ecuCyD+Truh4k3iCsx/Qx0WJNj5MuQ9m18YEcYUfW3+DtT1tnrdUdas2 CN7IKlw9Zxa6AfS9a9iqR68pn6NEpwc9W9eF3sNL7x+ap0F3QlBuBtahevmbB1sD9O fC+cZ+vfc2G1MoI8EBkYoEJl0DbLSMaMVQHEoCHE2KebIvRd0yl9IX3VAirxWdhUzJ kYNol3id5bpuoFktE9Y+sE0/z/Lwq/TA+Zeb3JAkkwj40yN4iIgj3aKlKqmG8XECrJ lknfGocrbTtfO03AiKjVF8MYnuut8L8p1Vl3gmu11mJzujfORl9gjpAT+5BAnB/mPi 57SckEuYo1X1Q== Date: Thu, 12 May 2022 18:09:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: Message-ID: References: <20220505001656.395419-6-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Julien Grall wrote: > > + rc = xs_introduce_domain(xsh, info->domid, > > + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, > > + xenstore_evtchn); > > I might be missing something here. In an ealier version, I pointed out that > xs_introduce_domain() would fail in the case the dom0less domain doesn't have > "xen,enhanced". > > AFAICT, you agreed that the (part?) of initialization should be skipped. But I > don't see the change in the code. Regarding the placement, we could either > fully skip init_domain() or just xs_introduce_domain(). The latter might be > better so all the domains are listed using xenstore-ls. > > So something like below should work: > > if ( xenstore_evtchn ) > { > rc = xs_introduce...(); > ... > } Yes, good point. xenstore_evtchn could be zero validly (first evtchn is zero), so instead I'll check on xenstore_pfn to be zero (xenstore_pfn is 0 for non-enhanced domUs.) From xen-devel-bounces@lists.xenproject.org Fri May 13 01:17:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:17:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328130.551055 (Exim 4.92) (envelope-from ) id 1npJvN-0000za-PU; Fri, 13 May 2022 01:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328130.551055; Fri, 13 May 2022 01:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJvN-0000zT-MB; Fri, 13 May 2022 01:16:57 +0000 Received: by outflank-mailman (input) for mailman id 328130; Fri, 13 May 2022 01:16:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npJvM-0000zN-Je for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:16:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60c815b3-d25a-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 03:16:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C549FB82BCE; Fri, 13 May 2022 01:16:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21A83C34113; Fri, 13 May 2022 01:16:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c815b3-d25a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652404613; bh=sUi9zx5uAbIAkOAolBH/Xf63s1EcqIcLC1NiVzsqu5M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mOKCaTRYpGdPI4rSfftmlbu6cbGDJNXrqE+N2p5VITetqEeH9IqFLa84MLp1wG9TV kthMAJG+ykWJ2rqtUNN1B525CpQ869QMOUOVvWbreigdYOYu3LK8yVMx2wythxehcy WHVtnSjFaML/zSdRYOdgty8Y+XCMHNOLvDImpTrdYB7T5e+en5Uvd4NBRVAkEhnSP9 8UDSsHJ8Ezmrl0fql5ulX1/9+fG1pa45m6tPfxW22Ku1fjWPt3KVTNUWBpYHnXkxRh qy6u9oG9+6Bg+G1dHmajmfjGDvkkYtP1Sg4gVO/nNi7dOiMGuxgbJb5lSCWXiDakn5 PnLA0H3Vr48+A== Date: Thu, 12 May 2022 18:16:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain In-Reply-To: <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> Message-ID: References: <20220505001656.395419-5-sstabellini@kernel.org> <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Julien Grall wrote: > On 05/05/2022 01:16, Stefano Stabellini wrote: > > From: Luca Miccio > > > > When xs_introduce_domain is called, send out a notification on the > > xenstore event channel so that any (dom0less) domain waiting for the > > xenstore interface to be ready can continue with the initialization. > > Before sending the notification, clear XENSTORE_RECONNECTING. > > > > The extra notification is harmless for domains that don't require it. > > > > In xs_wire.h update the commment on top of XENSTORE_RECONNECTING to > > generalize its meaning to suit the dom0less use-case better. > > > > Signed-off-by: Luca Miccio > > Signed-off-by: Stefano Stabellini > > CC: jgross@suse.com > > CC: anthony.perard@citrix.com > > CC: wl@xen.org > > --- > > If you have better suggestions for the wording in xs_wire.h please > > suggest! > > > > > > Changes in v6: > > - use XENSTORE_CONNECTED instead of 0x0 > > - update xs_wire.h > > > > Changes in v5: > > - reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU > > > > Changes in v2: > > - drop the new late_init parameter > > --- > > tools/xenstore/xenstored_domain.c | 4 ++++ > > xen/include/public/io/xs_wire.h | 2 +- > > I am not entirely sure this is the right place to mention it. But I couldn't > find a better one. > > The documentation (docs/misc/xenstore-misc.txt) states that the field is valid > when the server advertised ``Connection State``. > > Is there any guarantee the field will be 0 for any previous {C, O}xenstored > implementation? If not, then I think we need to set the feature flag so Linux > knows the field can be used. > > If yes, then the documentation should be relaxed so an OS knows it can safely > use the field without checking the feature flag. The xenstore page is allocated by the toolstack which zeros the page, *xenstored wouldn't set it, so I think we can assume the field has always been zero. > > diff --git a/xen/include/public/io/xs_wire.h > > b/xen/include/public/io/xs_wire.h > > index 953a0050a3..c1ec7c73e3 100644 > > --- a/xen/include/public/io/xs_wire.h > > +++ b/xen/include/public/io/xs_wire.h > > @@ -141,7 +141,7 @@ struct xenstore_domain_interface { > > /* Valid values for the connection field */ > > #define XENSTORE_CONNECTED 0 /* the steady-state */ > > -#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ > > +#define XENSTORE_RECONNECT 1 /* reconnect in progress */ > > The definition in the docs needs to be updated. I wanted to do that but I am very unfamiliar with the xenstore docs. Can you point me to the place where I need to change the definition? I cannot find where XENSTORE_RECONNECT is defined... From xen-devel-bounces@lists.xenproject.org Fri May 13 01:24:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:24:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328137.551065 (Exim 4.92) (envelope-from ) id 1npK2D-0002Qj-HE; Fri, 13 May 2022 01:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328137.551065; Fri, 13 May 2022 01:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npK2D-0002Qc-EC; Fri, 13 May 2022 01:24:01 +0000 Received: by outflank-mailman (input) for mailman id 328137; Fri, 13 May 2022 01:24:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npK2B-0002QW-VV for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:23:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d1f687a-d25b-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 03:23:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43B63B82BCE; Fri, 13 May 2022 01:23:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 914CCC385B8; Fri, 13 May 2022 01:23:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d1f687a-d25b-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652405037; bh=3agA9T2JBD+/dcj6+92nZQD/HWnrJRjDcLpMYuEguvQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VPWxMMX1EE9x1QD3mKq95xS+OTwbDY/9cPRsHV48SnMwrfLqRCF0aijEX1tjNl/ln xEpyXVTa3JnUCpl4r+b4D9/BlEEba3doCy1yToxX9kI3xQctRmfMZVIq0w/koM0V77 yCnYiFfyRgYx3l67oYGV43dcbSHNtRNLvtIc4ceaOr35faAkdJdeO5neV9D4vvhE4y IMUmcQCSF5if9SOgnc7LMGro9FjggyhGy4aj7nDc2YYmhXt/q6/WJTmbfG8bT81d9q MXUCr/FiuunE14P42WZD9JNaQcyAZ7B3S1VVtsK9Xea5ta9/mbt6CdSd64CX8vBGwW 7cdGnyy+marKA== Date: Thu, 12 May 2022 18:23:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Bertrand Marquis , Rahul Singh , Stefano Stabellini , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot In-Reply-To: <34b790af-c56a-26c7-e218-7961023b8605@xen.org> Message-ID: References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Julien Grall wrote: > > If dom0 is mandatory yes, we should still make sure that this code cannot be > > reached so an ASSERT would be nice here at least in case someone tries to > > activate this code without dom0 (which might happen when we will push the > > serie for static event channels). > > I am fine with an ASSERT(). I added an ASSERT(hardware_domain). From xen-devel-bounces@lists.xenproject.org Fri May 13 01:32:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328144.551080 (Exim 4.92) (envelope-from ) id 1npK9z-0003sa-Id; Fri, 13 May 2022 01:32:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328144.551080; Fri, 13 May 2022 01:32:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npK9z-0003sT-CU; Fri, 13 May 2022 01:32:03 +0000 Received: by outflank-mailman (input) for mailman id 328144; Fri, 13 May 2022 01:32:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npK9y-0003sN-2n for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:32:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c0b32fa-d25c-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 03:32:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4BB962111; Fri, 13 May 2022 01:31:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD566C385B8; Fri, 13 May 2022 01:31:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c0b32fa-d25c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652405519; bh=qjctFxJKv3PzS7uzlW76cYZ2Kpe6i9eksyNQBmQzjxI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CltnUnZO6wz0jn//IYGNbjRZOzX7g3zIXYcWvlZqHxtthBJUAr+banq/01hYoijjp 7Ez0+AWThXRb3t92m7BfwU5Ow+FBw6wWo0Mw6gFP3Be0LvMc7l/EUY4uDWpkdO1Izp Fs7O6+3nf+NCvq1fFwc1MRjpViq2gA1wJRwid26sZguxblQQNWQbsOI0ZpEaKJ6Pet cFL03OxYL7kjcZwb3qDFHQG4D+nuu6Py4uNbHIZDK4ZqO31aPLmWylKY3/Aq6QBRID tkHYYjdRcLOXUuCe1eB4qBnluUWtfT+Cks87VyjJbnrJrlp899sYhntxr93v3aGNA6 Fa7do414QlbIg== Date: Thu, 12 May 2022 18:31:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: iommu@lists.linux-foundation.org, Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/3] swiotlb: don't panic when the swiotlb buffer can't be allocated In-Reply-To: <20220511125805.1377025-2-hch@lst.de> Message-ID: References: <20220511125805.1377025-1-hch@lst.de> <20220511125805.1377025-2-hch@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Christoph Hellwig wrote: > For historical reasons the switlb code paniced when the metadata could > not be allocated, but just printed a warning when the actual main > swiotlb buffer could not be allocated. Restore this somewhat unexpected > behavior as changing it caused a boot failure on the Microchip RISC-V > PolarFire SoC Icicle kit. > > Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") > Reported-by: Conor Dooley > Signed-off-by: Christoph Hellwig > Tested-by: Conor Dooley Reviewed-by: Stefano Stabellini > --- > kernel/dma/swiotlb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index e2ef0864eb1e5..3e992a308c8a1 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -254,8 +254,10 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > tlb = memblock_alloc(bytes, PAGE_SIZE); > else > tlb = memblock_alloc_low(bytes, PAGE_SIZE); > - if (!tlb) > - panic("%s: failed to allocate tlb structure\n", __func__); > + if (!tlb) { > + pr_warn("%s: failed to allocate tlb structure\n", __func__); > + return; > + } > > if (remap && remap(tlb, nslabs) < 0) { > memblock_free(tlb, PAGE_ALIGN(bytes)); > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Fri May 13 01:39:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:39:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328151.551091 (Exim 4.92) (envelope-from ) id 1npKHM-0004Yn-C2; Fri, 13 May 2022 01:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328151.551091; Fri, 13 May 2022 01:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKHM-0004Ye-6R; Fri, 13 May 2022 01:39:40 +0000 Received: by outflank-mailman (input) for mailman id 328151; Fri, 13 May 2022 01:39:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKHL-0004YY-GX for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:39:39 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c2a5e7b-d25d-11ec-a406-831a346695d4; Fri, 13 May 2022 03:39:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11DBE62107; Fri, 13 May 2022 01:39:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FE77C385B8; Fri, 13 May 2022 01:39:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c2a5e7b-d25d-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652405975; bh=W35uWjUG1O6fXtH+TbvlRcplXMfTEbaTeezWYwjpnhs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=KwdIFkm2hPKErCfdMH4zzYXGuY6RR5jAi7812KnaR64+duu+Ce0s4TnHr47O36AR6 Gyqmg3FhN1VegdSdqWGTjEnJ/4wK7qThd8rn84t9CgNr9XCOC2tpkfqNMdCal27YyX qf2mRxlkgXIIW1MeOE0aYtS1jbkeHoSlgGzMwNgQmlmA9n2Ohp5Bijmosmr6AJZy4Z fGMujrI1cf+U4SjFHP9IIGzypnnrqGCdXnh5Q5gGdYdIWb5LqkwlfcGMObWHJyEost bg7dWgaHij98vhwCua2itu4joEKubsQ7H1gumkfbcmi7OqT22eYgl2M+38h6VsbY9V KMHFAkS5roIJg== Date: Thu, 12 May 2022 18:39:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: iommu@lists.linux-foundation.org, Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/3] swiotlb: use the right nslabs value in swiotlb_init_remap In-Reply-To: <20220511125805.1377025-3-hch@lst.de> Message-ID: References: <20220511125805.1377025-1-hch@lst.de> <20220511125805.1377025-3-hch@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Christoph Hellwig wrote: > default_nslabs should only be used to initialize nslabs, after that we > need to use the local variable that can shrink when allocations or the > remap don't succeed. > > Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") > Signed-off-by: Christoph Hellwig Reviewed-by: Stefano Stabellini > --- > kernel/dma/swiotlb.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index 3e992a308c8a1..113e1e8aaca37 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -234,7 +234,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > { > struct io_tlb_mem *mem = &io_tlb_default_mem; > unsigned long nslabs = default_nslabs; > - size_t alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); > + size_t alloc_size; > size_t bytes; > void *tlb; > > @@ -249,7 +249,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > * memory encryption. > */ > retry: > - bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT); > + bytes = PAGE_ALIGN(nslabs << IO_TLB_SHIFT); > if (flags & SWIOTLB_ANY) > tlb = memblock_alloc(bytes, PAGE_SIZE); > else > @@ -269,12 +269,13 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, > goto retry; > } > > + alloc_size = PAGE_ALIGN(array_size(sizeof(*mem->slots), nslabs)); > mem->slots = memblock_alloc(alloc_size, PAGE_SIZE); > if (!mem->slots) > panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > __func__, alloc_size, PAGE_SIZE); > > - swiotlb_init_io_tlb_mem(mem, __pa(tlb), default_nslabs, false); > + swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, false); > mem->force_bounce = flags & SWIOTLB_FORCE; > > if (flags & SWIOTLB_VERBOSE) > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Fri May 13 01:44:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 01:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328158.551102 (Exim 4.92) (envelope-from ) id 1npKM7-0005xd-Td; Fri, 13 May 2022 01:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328158.551102; Fri, 13 May 2022 01:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKM7-0005xW-Py; Fri, 13 May 2022 01:44:35 +0000 Received: by outflank-mailman (input) for mailman id 328158; Fri, 13 May 2022 01:44:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKM6-0005xQ-VU for xen-devel@lists.xenproject.org; Fri, 13 May 2022 01:44:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ca5f138-d25e-11ec-a406-831a346695d4; Fri, 13 May 2022 03:44:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E50B620EA; Fri, 13 May 2022 01:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 910EBC385B8; Fri, 13 May 2022 01:44:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ca5f138-d25e-11ec-a406-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652406271; bh=ZS0DQzDVQRw+WyZX8h4DFNWCJCmiIgGiFZJt0lgwi0Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HfYksHVbntV+wgGN0VNX9EmrK8S41HUKC7cNTFH1O/07u0e3kTAlwTatr1+Gyv6M8 /GmqcFTbKgB07jBYxiSlJcnHbgLjdNgTTk1GZVrIxxt3SNHehw+QVRKVTdfRZP8J2F HEOm8R5uwSQI1EqLv1bT+NaX++rQJEIN3UrC8b3wpwMe29SUluH6LjfKTJzVMsQqUm awkKp/NwkHraiUJ5vPWk898WNy2Jiujt3gOJXnKBJSth9leZJdqiBgBX3nwQRmFerO nIGWazHqK0GsyQCdVwbhSGJgfRdK4ATT/erXQGSQDcKrJ1ZBKMAOCZ0YKGNe2Hv1z8 jsvo4HlZWqVDA== Date: Thu, 12 May 2022 18:44:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Christoph Hellwig cc: iommu@lists.linux-foundation.org, Stefano Stabellini , Boris Ostrovsky , Conor.Dooley@microchip.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/3] swiotlb: use the right nslabs-derived sizes in swiotlb_init_late In-Reply-To: <20220511125805.1377025-4-hch@lst.de> Message-ID: References: <20220511125805.1377025-1-hch@lst.de> <20220511125805.1377025-4-hch@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 11 May 2022, Christoph Hellwig wrote: > nslabs can shrink when allocations or the remap don't succeed, so make > sure to use it for all sizing. For that remove the bytes value that > can get stale and replace it with local calculations and a boolean to > indicate if the originally requested size could not be allocated. > > Fixes: 6424e31b1c05 ("swiotlb: remove swiotlb_init_with_tbl and swiotlb_init_late_with_tbl") > Signed-off-by: Christoph Hellwig Reviewed-by: Stefano Stabellini > --- > kernel/dma/swiotlb.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index 113e1e8aaca37..d6e62a6a42ceb 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -297,9 +297,9 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, > { > struct io_tlb_mem *mem = &io_tlb_default_mem; > unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); > - unsigned long bytes; > unsigned char *vstart = NULL; > unsigned int order; > + bool retried = false; > int rc = 0; > > if (swiotlb_force_disable) > @@ -308,7 +308,6 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, > retry: > order = get_order(nslabs << IO_TLB_SHIFT); > nslabs = SLABS_PER_PAGE << order; > - bytes = nslabs << IO_TLB_SHIFT; > > while ((SLABS_PER_PAGE << order) > IO_TLB_MIN_SLABS) { > vstart = (void *)__get_free_pages(gfp_mask | __GFP_NOWARN, > @@ -316,16 +315,13 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, > if (vstart) > break; > order--; > + nslabs = SLABS_PER_PAGE << order; > + retried = true; > } > > if (!vstart) > return -ENOMEM; > > - if (order != get_order(bytes)) { > - pr_warn("only able to allocate %ld MB\n", > - (PAGE_SIZE << order) >> 20); > - nslabs = SLABS_PER_PAGE << order; > - } > if (remap) > rc = remap(vstart, nslabs); > if (rc) { > @@ -334,9 +330,15 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, > nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE); > if (nslabs < IO_TLB_MIN_SLABS) > return rc; > + retried = true; > goto retry; > } > > + if (retried) { > + pr_warn("only able to allocate %ld MB\n", > + (PAGE_SIZE << order) >> 20); > + } > + > mem->slots = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, > get_order(array_size(sizeof(*mem->slots), nslabs))); > if (!mem->slots) { > @@ -344,7 +346,8 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, > return -ENOMEM; > } > > - set_memory_decrypted((unsigned long)vstart, bytes >> PAGE_SHIFT); > + set_memory_decrypted((unsigned long)vstart, > + (nslabs << IO_TLB_SHIFT) >> PAGE_SHIFT); > swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, true); > > swiotlb_print_info(); > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Fri May 13 02:17:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 02:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328165.551113 (Exim 4.92) (envelope-from ) id 1npKrQ-00019C-G3; Fri, 13 May 2022 02:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328165.551113; Fri, 13 May 2022 02:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKrQ-000195-CG; Fri, 13 May 2022 02:16:56 +0000 Received: by outflank-mailman (input) for mailman id 328165; Fri, 13 May 2022 02:16:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKrP-00018u-5Z; Fri, 13 May 2022 02:16:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKrP-0004Cd-39; Fri, 13 May 2022 02:16:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKrO-0003tp-Nr; Fri, 13 May 2022 02:16:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npKrO-0002Ie-N5; Fri, 13 May 2022 02:16:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c3BjtxypXMqeeyBQXZnSIicqftIdnEdjSMBKbsZ+P5Y=; b=tNo2kyvCFe6YUATXDtvSVncQTa Y0o2umwaQFbzbnmAM/dRPKVlEmQBcjwan4G/Dio7lpUuYUXX4BM8eF1sJqyOa2/VG2IizbRHnNwqX jWIW0YWCADV2d6f8/7rR9ahQ8WWLTi9c1VWNfSMP6LOlpScJXxvx47KkmIqacgnWMsHI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170375: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=17702186b56209842e002235c29ffec5ed69745a X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 02:16:54 +0000 flight 170375 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170375/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 17702186b56209842e002235c29ffec5ed69745a baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 973 attempts Testing same since 170375 2022-05-13 01:10:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6489 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 02:22:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 02:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328175.551124 (Exim 4.92) (envelope-from ) id 1npKwz-0002cL-AH; Fri, 13 May 2022 02:22:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328175.551124; Fri, 13 May 2022 02:22:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKwz-0002cE-78; Fri, 13 May 2022 02:22:41 +0000 Received: by outflank-mailman (input) for mailman id 328175; Fri, 13 May 2022 02:22:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npKwx-0002c8-Om for xen-devel@lists.xenproject.org; Fri, 13 May 2022 02:22:40 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on060e.outbound.protection.outlook.com [2a01:111:f400:fe09::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e9f7053-d263-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 04:22:38 +0200 (CEST) Received: from DB6PR07CA0057.eurprd07.prod.outlook.com (2603:10a6:6:2a::19) by AM6PR08MB4104.eurprd08.prod.outlook.com (2603:10a6:20b:a9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 02:22:34 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::2b) by DB6PR07CA0057.outlook.office365.com (2603:10a6:6:2a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.5 via Frontend Transport; Fri, 13 May 2022 02:22:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Fri, 13 May 2022 02:22:34 +0000 Received: ("Tessian outbound 6580ae46f51e:v119"); Fri, 13 May 2022 02:22:34 +0000 Received: from bc86b9393015.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3273E0BB-0946-4A6A-8071-46F5C27748B9.1; Fri, 13 May 2022 02:22:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc86b9393015.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 May 2022 02:22:29 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by HE1PR0802MB2265.eurprd08.prod.outlook.com (2603:10a6:3:c0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 02:22:27 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%4]) with mapi id 15.20.5227.023; Fri, 13 May 2022 02:22:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e9f7053-d263-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y2NNlq7JSzh1K88VpoBJTfiQw8Ryq/+TSACaFmcd0gQ2rfCqR5o/dE7Ib9jQ8jr+2Y2/so7bRXZKBj/u4EA1R5Ie4U1r0aYl6N3Z6vTKC5gaDpjJrcp+DphanWBOKylwwDoghyhXtjmxqb94vZaiJtd58GP0SQavmCKvcljDq+COy9Zy8ywafzK4Ds0GcCeVOYy12J6WUVDJcqyBTuKui5LyE/kgc19oxLwefPXC66KUznNKffQaVu0rh+xvZDQi05xbjFVsdDcqkxwTO8J6pNwUlfpqjLDIaN6Sw5yXHCGLxLVq2NNaxtVVq8b9bZAwmrW26m20CPI0s6LU6wuDCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqjTFTLDZfgvZpsKIEkXgtL0VXupn9ve/YITBfDtPW4=; b=DFw490veEaSUKKdS9zRcQSylJiqYJ49CZmBClDcsFqJOsWIxv9vfbjXU9PYt46SuQsVEcO/3btpverNTloCtLFILEOyxksT7jNcrhfq0jQnH1gnmnKZpI1XFSL1/dgNBn0kPvFG98Kq+Ufs8+VrhjTAO2WwwmOd0fg0ElbBvWPM/wLkfe/QKhABZysb5rzH+0YgX/HulzqkPd2hCmVLy/dlIoPWzeXgXTJGcMraF3eZqfNe1cd76hyjbi3OaNji8Ri1hMO6VsxMbhU+xRSRe6jocYv1YrY5xhZp1Cb483R9kGY+5JkPYstXvcgwyiLGivPR7nhHCIt7HKBAfB/BLTQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqjTFTLDZfgvZpsKIEkXgtL0VXupn9ve/YITBfDtPW4=; b=if+W3ovuzMJ0Twkc0YANFDwF0v6TFKaitqCorT3WyXh5w2qe0ojs0Qch/22LcTSeAyfT9QN9zTrwda0rqZ10DPQ7GRnRCVbBPUxldRdxuP8j7NFufBuwuWgG5Rhx8E84j5+O9StvZGwZ9OUdPoWQKUio77k0TwTibbIyQZlNmVo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQrVY6ZFWA72W4DnYKOP+C5NchALF8SavKjEWxu12DvIzQU0S7PpjFs92Vvr3/4ZBTMJ0vzJYQQw1QvE9wW4NCzkfuyLuZO+kuBcuyPcnSI37UHs/i2EBt1PhMgNtpTsQh4fvEQhpwSrhfq7eFL7w55ONOQBwZeW9w4ZUkI2NMxb1cgn6dKYVRZKiWIgbKQYgktq8nnpVI2W+q2SPtgf9xVJSiakyCVUq+jrRz00NSpCuFKc9h7baKw/ghZQvO0D6Z3QfqR8hZ85ACXcH7TohqJj8cSibCWJwYNoL/eZKeEyd65XJpJxQTADh82TnD16ShG1oOcaeT9/RfZQ98xUAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqjTFTLDZfgvZpsKIEkXgtL0VXupn9ve/YITBfDtPW4=; b=lC0j/O+5czcZXD5RwXEbWS26PQAoyK6CN1He1gy3ALrHJ+z3RR0Bsy1R2UxW9kyTX6VnvD00ZA/oLX2plcF8J/uLO82+8Bo0I+Mq5s+DiOraPfx438Jl+1BHo58rOlk4SYzXtBidyb2d55O+oZADnU00zaz/2zEyG3j7n3aH3Ho5AzbXgW5yRLGRVpeKGqi5h872GmWnA+SNczPIppqc/lidTncbRc3fayqEhX49mJ/WnI5S/lVGse8mq9lluhyytk+OASC9E/kfat+Q9ALK9u4KkWHNH0Z0xaAZFeGJO7l+7LlUsZyXV0uVvO0Ms4n8ONxSo3ydYQMN3FewxkKe9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqjTFTLDZfgvZpsKIEkXgtL0VXupn9ve/YITBfDtPW4=; b=if+W3ovuzMJ0Twkc0YANFDwF0v6TFKaitqCorT3WyXh5w2qe0ojs0Qch/22LcTSeAyfT9QN9zTrwda0rqZ10DPQ7GRnRCVbBPUxldRdxuP8j7NFufBuwuWgG5Rhx8E84j5+O9StvZGwZ9OUdPoWQKUio77k0TwTibbIyQZlNmVo= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr Thread-Topic: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr Thread-Index: AQHYZeBr4CimJnwnVk2FbRYk6hcYT60bBl8AgAECWqA= Date: Fri, 13 May 2022 02:22:26 +0000 Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-5-Penny.Zheng@arm.com> <47b4d6c2-3bc7-02bc-be5a-a2b782541c3c@xen.org> In-Reply-To: <47b4d6c2-3bc7-02bc-be5a-a2b782541c3c@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 88D7EB5539F8C240BD376BB82E245B0F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: cce5cc7b-4b0b-4125-f61b-08da348770bb x-ms-traffictypediagnostic: HE1PR0802MB2265:EE_|DBAEUR03FT061:EE_|AM6PR08MB4104:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FE/+cF13yFTYbAjv7Fd4SkwMgRrTTWDt1iXghdTg3lp8mzDr/n1DLr9KOSBp3REwrGYlkijWYV96J8PH9DR18uMD6shxg2e6GT01tSosLHx9OMlPLuQrJHo/o3as21hXwwPksq/HTT7BSCVnn46sBQphPXKNVATZRN024wHwnJNX8sOGf5rUdOxizMgPOwc0UbakE6p5nulZ+hqMlAKd8TgBhunKy2OO3nav6TovzwdT0Tlavoa/RUnyh+bN/wpNVN2ne/c9Xc27eCSNjPQuXi7SakdAS7EIZgp6+QaPJW+CToRdyWzoPg7fk2oDxAePCLghEwGh0vXgo2ot2ovhf1wxIsSqDJC00x7p8uVbKsFuHcae/Ew7aFL9KspWFL047wn2pL73edkP+V/ykRxKSbblf10pwWuSUCspdl8bBGIz4EqCmzEsA1StllEaDu96w5fgORoeR8/ehfpnbPqFTB5uuh4FNrtbJYvFbpkvRVirfDw9m4nVWpNFPMrTHKHRPh1JISSUYdFbzCLYpw3CGWnfF35OPYl/VSVtDkhSqBP9qU7M8uTW1Xd2tzvUqtPZr7ZhUXCsCkHWwEaKrDDOxHnKjYsMoPf+oc52Wl2muwJGcA6k113BmGT+J5BMeYP+87nT+MfZ7p4ToQcBOSKk2YORM4Z058WxdYxuQJPNhABV+7F6sdtGMoJaFg+hOz1Drsn0N5ScVCFdoxgBAtnBLw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(71200400001)(66446008)(66556008)(38070700005)(86362001)(8676002)(110136005)(66946007)(64756008)(76116006)(4326008)(38100700002)(122000001)(508600001)(316002)(55016003)(83380400001)(54906003)(186003)(7696005)(53546011)(6506007)(5660300002)(9686003)(26005)(52536014)(8936002)(33656002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2265 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 484b2714-2e0d-415c-240c-08da34876c40 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cCa6HqIeeXKULYmxRzKGhn5t/1uNh3x5EylAIuxir+UZY6R3ThIf4OQ3wDHLStZKMJ/gKCHTRiRvDxK5E63lhXxKZ9T9vf5G4k+T4l+QOCazMiln4KLCtzaN0+BEfWC4a1CL0WooACMqF50W3fKufDyAfBI4pqe3Zn9+OJfWFUp9J3k1RhchAnQZC/6NdGLVLmdyh+ZDeKdKjILzWQYPLiDDS6Z7tuZGFIkDq1Ii+Cq3tAhgCXOwFBAiOP9GwFmkpOan8GrkdOtC0ucjzN3Ug/hF/mfJhVzbTt3oE1KJ7eJGa0QFbDkS/xQ2gl8cVlQnOJCcibU4YNnfBO5sJmlUxZhoP0y3TbSg9/wyHD+l644iaiRecz4Xkp1sKCcPaeoezcjhE5tz3VyZws40FSGtbE+wGbOta5llT3zA+ztLx2UgZxLyoQHwc+v6u7xbCmgav8gWU++jlAA4FgxhJijLK3objU8f0sjqrq0MlNmN8QK2e06iJ6vYOOIluYrLO8YsZA5zwneAlAiBwijf8NUHDrqmB4vdnh+6ankELO/hc0l0ttNTvdjKwDXg5byPMhEIZNzJjlb4sJnTPjzxxRWvZs6Y9VOii7wqX2ldHv61WpTVE7USPH0Bzfo1qTvK5DR4iNb5erlTKIzqpt1XadXvvXfGq00H8jZBvwdb+9XY/Qxlipg3n1iGZdVhIsyChu+o X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70586007)(33656002)(316002)(110136005)(70206006)(356005)(54906003)(186003)(83380400001)(47076005)(9686003)(107886003)(26005)(336012)(2906002)(82310400005)(7696005)(55016003)(81166007)(36860700001)(86362001)(8676002)(40460700003)(8936002)(52536014)(5660300002)(508600001)(53546011)(4326008)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 02:22:34.2942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cce5cc7b-4b0b-4125-f61b-08da348770bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4104 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIE1heSAxMiwgMjAyMiA2 OjE0IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+ OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFu ZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1 ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMg NC84XSB4ZW4vYXJtOiBpbnRyb2R1Y2UgcHV0X3BhZ2VfbnIgYW5kIGdldF9wYWdlX25yDQo+IA0K PiANCj4gDQo+IE9uIDEyLzA1LzIwMjIgMTA6MTEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IExh dGVyLCB3ZSBuZWVkIHRvIGFkZCB0aGUgcmlnaHQgYW1vdW50IG9mIHJlZmVyZW5jZXMsIHdoaWNo IHNob3VsZCBiZQ0KPiA+IHRoZSBudW1iZXIgb2YgYm9ycm93ZXIgZG9tYWlucywgdG8gdGhlIG93 bmVyIGRvbWFpbi4gU2luY2Ugd2Ugb25seQ0KPiA+IGhhdmUNCj4gPiBnZXRfcGFnZSgpIHRvIGlu Y3JlbWVudCB0aGUgcGFnZSByZWZlcmVuY2UgYnkgMSwgYSBsb29wIGlzIG5lZWRlZCBwZXINCj4g PiBwYWdlLCB3aGljaCBpcyBpbmVmZmljaWVudCBhbmQgdGltZS1jb25zdW1pbmcuDQo+ID4NCj4g PiBUbyBzYXZlIHRoZSBsb29wIHRpbWUsIHRoaXMgY29tbWl0IGludHJvZHVjZXMgYSBzZXQgb2Yg bmV3IGhlbHBlcnMNCj4gPiBwdXRfcGFnZV9ucigpIGFuZCBnZXRfcGFnZV9ucigpIHRvIGluY3Jl bWVudC9kcm9wIHRoZSBwYWdlIHJlZmVyZW5jZSBieQ0KPiBuci4NCj4gPg0KPiA+IFNpZ25lZC1v ZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IHYz IGNoYW5nZXM6DQo+ID4gLSBjaGVjayBvdmVyZmxvdyB3aXRoICJuIg0KPiA+IC0gcmVtb3ZlIHNw dXJpb3VzIGNoYW5nZQ0KPiA+IC0gYnJpbmcgYmFjayB0aGUgY2hlY2sgdGhhdCB3ZSBlbnRlciB0 aGUgbG9vcCBvbmx5IHdoZW4gY291bnRfaW5mbyBpcw0KPiA+IGdyZWF0ZXIgdGhhbiAwDQo+ID4g LS0tDQo+ID4gdjIgY2hhbmdlOg0KPiA+IC0gbmV3IGNvbW1pdA0KPiA+IC0tLQ0KPiA+ICAgeGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmggfCAgNCArKysrDQo+ID4gICB4ZW4vYXJjaC9hcm0v bW0uYyAgICAgICAgICAgICB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t DQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p DQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmgNCj4g PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbS5oIGluZGV4IDQyNGFhZjI4MjMuLmM3Mzdk NTFlNGQgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL21tLmgNCj4g PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vbW0uaA0KPiA+IEBAIC0zNDcsNiArMzQ3 LDEwIEBAIHZvaWQgZnJlZV9pbml0X21lbW9yeSh2b2lkKTsNCj4gPiAgIGludCBndWVzdF9waHlz bWFwX21hcmtfcG9wdWxhdGVfb25fZGVtYW5kKHN0cnVjdCBkb21haW4gKmQsDQo+IHVuc2lnbmVk IGxvbmcgZ2ZuLA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IG9yZGVyKTsNCj4gPg0KPiA+ICtleHRlcm4gYm9vbCBnZXRfcGFnZV9u cihzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlLCBjb25zdCBzdHJ1Y3QgZG9tYWluDQo+ICpkb21haW4s DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnIpOyBleHRlcm4g dm9pZA0KPiA+ICtwdXRfcGFnZV9ucihzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlLCB1bnNpZ25lZCBs b25nIG5yKTsNCj4gPiArDQo+ID4gICBleHRlcm4gdm9pZCBwdXRfcGFnZV90eXBlKHN0cnVjdCBw YWdlX2luZm8gKnBhZ2UpOw0KPiA+ICAgc3RhdGljIGlubGluZSB2b2lkIHB1dF9wYWdlX2FuZF90 eXBlKHN0cnVjdCBwYWdlX2luZm8gKnBhZ2UpDQo+ID4gICB7DQo+ID4gZGlmZiAtLWdpdCBhL3hl bi9hcmNoL2FybS9tbS5jIGIveGVuL2FyY2gvYXJtL21tLmMgaW5kZXgNCj4gPiA3YjFmMmY0OTA2 Li5hOTQ2MWUwN2FhIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9tbS5jDQo+ID4gKysr IGIveGVuL2FyY2gvYXJtL21tLmMNCj4gPiBAQCAtMTUzNyw3ICsxNTM3LDggQEAgbG9uZyBhcmNo X21lbW9yeV9vcChpbnQgb3AsDQo+IFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkgYXJnKQ0K PiA+ICAgICAgIHJldHVybiAwOw0KPiA+ICAgfQ0KPiA+DQo+ID4gLXN0cnVjdCBkb21haW4gKnBh Z2VfZ2V0X293bmVyX2FuZF9yZWZlcmVuY2Uoc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSkNCj4gPiAr c3RhdGljIHN0cnVjdCBkb21haW4gKnBhZ2VfZ2V0X293bmVyX2FuZF9ucl9yZWZlcmVuY2Uoc3Ry dWN0IHBhZ2VfaW5mbw0KPiAqcGFnZSwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZw0KPiA+ICtucikNCj4gPiAg IHsNCj4gPiAgICAgICB1bnNpZ25lZCBsb25nIHgsIHkgPSBwYWdlLT5jb3VudF9pbmZvOw0KPiA+ ICAgICAgIHN0cnVjdCBkb21haW4gKm93bmVyOw0KPiA+IEBAIC0xNTQ4LDEwICsxNTQ5LDEwIEBA IHN0cnVjdCBkb21haW4NCj4gKnBhZ2VfZ2V0X293bmVyX2FuZF9yZWZlcmVuY2Uoc3RydWN0IHBh Z2VfaW5mbyAqcGFnZSkNCj4gPiAgICAgICAgICAgICogQ291bnQgPT0gIDA6IFBhZ2UgaXMgbm90 IGFsbG9jYXRlZCwgc28gd2UgY2Fubm90IHRha2UgYSByZWZlcmVuY2UuDQo+ID4gICAgICAgICAg ICAqIENvdW50ID09IC0xOiBSZWZlcmVuY2UgY291bnQgd291bGQgd3JhcCwgd2hpY2ggaXMgaW52 YWxpZC4NCj4gPiAgICAgICAgICAgICovDQo+ID4gLSAgICAgICAgaWYgKCB1bmxpa2VseSgoKHgg KyAxKSAmIFBHQ19jb3VudF9tYXNrKSA8PSAxKSApDQo+ID4gKyAgICAgICAgaWYgKCB1bmxpa2Vs eSgoKHggKyBucikgJiBQR0NfY291bnRfbWFzaykgPD0gMSkgKQ0KPiANCj4gVGhpcyBjaGVjayBs b29rcyB3cm9uZyB0byBtZS4gWW91IHdhbnQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIHJpZ2h0IGVx dWF0aW9uDQo+IHJldHVybiBpcyBhdCBsZWFzdCBlcXVhbCB0byBuIG90aGVyd2lzZS4NCj4gDQoN ClJpZ2h0LCByaWdodCwgSSBoYXZlbid0IGNvbnNpZGVyZWQgdGhvcm91Z2hseSEgQSB0aG91c2Fu ZCB0aGFua3MgZm9yIHRoZSBmb2xsb3dpbmcNCmRldGFpbGVkIGV4cGxhbmF0aW9ufg0KDQo+IEZ1 cnRoZXJtb3JlLCBJIHRoaW5rIHdlIG5lZWQgdG8gcmVzdHJpY3QgJ25yJyB0byBQR0NfY291bnRf bWFzayB0byBmdWxseSBjYXRjaA0KPiBhbnkgb3ZlcmZsb3cuDQo+IA0KPiBCZWZvcmUgdGhlIGxv b3AsIHRoZSBjb2RlIHdvdWxkIGxvb2sgbGlrZToNCj4gDQo+IC8qIFJlc3RyaWN0IG5yIHRvIGF2 b2lkICJkb3VibGUiIG92ZXJmbG93ICovIGlmICggbnIgPj0gUEdDX2NvdW50X21hc2sgKSB7DQo+ ICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+ICAgICAgcmV0dXJuIE5VTEw7DQo+IH0NCj4g DQo+IFRoZSBjaGVjayBpbiB0aGUgbG9vcCB3b3VsZCBsb29rIGxpa2U6DQo+IA0KPiBpZiAoIHVu bGlrZWx5KCh4ICsgbnIpICYgUEdDX2NvdW50X21hc2spIDw9IG4gKQ0KPiANCj4gVGhhdCBzYWlk LCBpdCBtaWdodCBiZSBlYXNpZXIgdG8gcmVhZCB0aGUgb3ZlcmZsb3cgY2hlY2sgaWYgd2UgZG86 DQo+IA0KPiBjb3VudCA9IHggJiBQR0NfY291bnRfbWFzazsNCj4gaWYgKCAhY291bnQgfHwgKChQ R0NfY291bnRfbWFzayAtIGNvdW50KSA8PSBuKSApDQo+IA0KPiBJIGhhdmVuJ3QgbWVhc3VyZWQg YW5kIGNoZWNrIHdoaWNoIG9mIHRoZSB0d28gb3B0aW9ucyB3b3VsZCByZXN1bHQgdG8gYmV0dGVy DQo+IGNvZGUgYW5kIHBlcmZvcm1hbmNlIChnZXRfcGFnZSgpIGlzIG9mdGVuIGNhbGxlZCkuDQo+ DQoNCkNvcnJlY3QgbWUgaWYgSSB1bmRlcnN0YW5kIHdyb25nbHk6DQpJTU8sIG9ubHkgb3B0aW9u IHR3byBpcyBhY3R1YWxseSBjYXRjaGluZyBhbnkgb3ZlcmZsb3c/IExldCAoUEdDX2NvdW50X21h c2sgLSBjb3VudCkgPD0gbnINCnN0YXkgaW4gdGhlIGxvb3AsIG5vdCBiZWZvcmUgdGhlIGxvb3Ag bGlrZSBvcHRpb24gMSwgdG8gY292ZXIgdGhlIGNoYW5nZWFibGUgcGFnZS0+Y291bnRfaW5mby4N Cg0KPiA+ICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gICAgICAgfQ0KPiA+IC0gICAg d2hpbGUgKCAoeSA9IGNtcHhjaGcoJnBhZ2UtPmNvdW50X2luZm8sIHgsIHggKyAxKSkgIT0geCAp Ow0KPiA+ICsgICAgd2hpbGUgKCAoeSA9IGNtcHhjaGcoJnBhZ2UtPmNvdW50X2luZm8sIHgsIHgg KyBucikpICE9IHggKTsNCj4gPg0KPiA+ICAgICAgIG93bmVyID0gcGFnZV9nZXRfb3duZXIocGFn ZSk7DQo+ID4gICAgICAgQVNTRVJUKG93bmVyKTsNCj4gPiBAQCAtMTU1OSwxNCArMTU2MCwyMCBA QCBzdHJ1Y3QgZG9tYWluDQo+ICpwYWdlX2dldF9vd25lcl9hbmRfcmVmZXJlbmNlKHN0cnVjdCBw YWdlX2luZm8gKnBhZ2UpDQo+ID4gICAgICAgcmV0dXJuIG93bmVyOw0KPiA+ICAgfQ0KPiA+DQo+ ID4gLXZvaWQgcHV0X3BhZ2Uoc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSkNCj4gPiArc3RydWN0IGRv bWFpbiAqcGFnZV9nZXRfb3duZXJfYW5kX3JlZmVyZW5jZShzdHJ1Y3QgcGFnZV9pbmZvICpwYWdl KSB7DQo+ID4gKyAgICByZXR1cm4gcGFnZV9nZXRfb3duZXJfYW5kX25yX3JlZmVyZW5jZShwYWdl LCAxKTsgfQ0KPiA+ICsNCj4gPiArdm9pZCBwdXRfcGFnZV9ucihzdHJ1Y3QgcGFnZV9pbmZvICpw YWdlLCB1bnNpZ25lZCBsb25nIG5yKQ0KPiA+ICAgew0KPiA+ICAgICAgIHVuc2lnbmVkIGxvbmcg bngsIHgsIHkgPSBwYWdlLT5jb3VudF9pbmZvOw0KPiA+DQo+ID4gICAgICAgZG8gew0KPiA+IC0g ICAgICAgIEFTU0VSVCgoeSAmIFBHQ19jb3VudF9tYXNrKSAhPSAwKTsNCj4gPiArICAgICAgICBB U1NFUlQoKCh5ICYgUEdDX2NvdW50X21hc2spICE9IDApICYmDQo+ID4gKyAgICAgICAgICAgICAg ICgoKHkgLSBucikgJiBQR0NfY291bnRfbWFzaykgPj0gMCkpOw0KPiANCj4gSSB0aGluayB0aGVy ZSBhcmUgYSBwb3RlbnRpYWwgdW5kZXJmbG93IGhlcmUgaWYgJ3knIGlzIHNtYWxsZXIgdGhhbiAn bnInLiBCdXQgb24gdjIsDQo+IFN0ZWZhbm8gc3VnZ2VzdCB0byB1c2UgQVNTRVJUKCh5ICYgUEdD X2NvdW50X21hc2spID49IG5yKTsgd2hpY2ggSSB0aGluayBpcw0KPiBzdWZmaWNpZW50IGhlcmUu DQo+IA0KDQpPaCwgdW5kZXJzdG9vZC4gdGhhbmtzIGZvciBjbGFyaWZpY2F0aW9ufg0KDQo+ID4g ICAgICAgICAgIHggID0geTsNCj4gPiAtICAgICAgICBueCA9IHggLSAxOw0KPiA+ICsgICAgICAg IG54ID0geCAtIG5yOw0KPiA+ICAgICAgIH0NCj4gPiAgICAgICB3aGlsZSAoIHVubGlrZWx5KCh5 ID0gY21weGNoZygmcGFnZS0+Y291bnRfaW5mbywgeCwgbngpKSAhPSB4KQ0KPiA+ICk7DQo+ID4N Cj4gPiBAQCAtMTU3NiwxOSArMTU4MywzMCBAQCB2b2lkIHB1dF9wYWdlKHN0cnVjdCBwYWdlX2lu Zm8gKnBhZ2UpDQo+ID4gICAgICAgfQ0KPiA+ICAgfQ0KPiA+DQo+ID4gLWJvb2wgZ2V0X3BhZ2Uo c3RydWN0IHBhZ2VfaW5mbyAqcGFnZSwgY29uc3Qgc3RydWN0IGRvbWFpbiAqZG9tYWluKQ0KPiA+ ICt2b2lkIHB1dF9wYWdlKHN0cnVjdCBwYWdlX2luZm8gKnBhZ2UpDQo+ID4gICB7DQo+ID4gLSAg ICBjb25zdCBzdHJ1Y3QgZG9tYWluICpvd25lciA9IHBhZ2VfZ2V0X293bmVyX2FuZF9yZWZlcmVu Y2UocGFnZSk7DQo+ID4gKyAgICBwdXRfcGFnZV9ucihwYWdlLCAxKTsNCj4gPiArfQ0KPiA+ICsN Cj4gPiArYm9vbCBnZXRfcGFnZV9ucihzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlLCBjb25zdCBzdHJ1 Y3QgZG9tYWluICpkb21haW4sDQo+ID4gKyAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBu cikNCj4gPiArew0KPiA+ICsgICAgY29uc3Qgc3RydWN0IGRvbWFpbiAqb3duZXIgPQ0KPiA+ICtw YWdlX2dldF9vd25lcl9hbmRfbnJfcmVmZXJlbmNlKHBhZ2UsIG5yKTsNCj4gPg0KPiA+ICAgICAg IGlmICggbGlrZWx5KG93bmVyID09IGRvbWFpbikgKQ0KPiA+ICAgICAgICAgICByZXR1cm4gdHJ1 ZTsNCj4gPg0KPiA+ICAgICAgIGlmICggb3duZXIgIT0gTlVMTCApDQo+ID4gLSAgICAgICAgcHV0 X3BhZ2UocGFnZSk7DQo+ID4gKyAgICAgICAgcHV0X3BhZ2VfbnIocGFnZSwgbnIpOw0KPiA+DQo+ ID4gICAgICAgcmV0dXJuIGZhbHNlOw0KPiA+ICAgfQ0KPiA+DQo+ID4gK2Jvb2wgZ2V0X3BhZ2Uo c3RydWN0IHBhZ2VfaW5mbyAqcGFnZSwgY29uc3Qgc3RydWN0IGRvbWFpbiAqZG9tYWluKSB7DQo+ ID4gKyAgICByZXR1cm4gZ2V0X3BhZ2VfbnIocGFnZSwgZG9tYWluLCAxKTsgfQ0KPiA+ICsNCj4g PiAgIC8qIENvbW1vbiBjb2RlIHJlcXVpcmVzIGdldF9wYWdlX3R5cGUgYW5kIHB1dF9wYWdlX3R5 cGUuDQo+ID4gICAgKiBXZSBkb24ndCBjYXJlIGFib3V0IHR5cGVjb3VudHMgc28gd2UganVzdCBk byB0aGUgbWluaW11bSB0byBtYWtlIGl0DQo+ID4gICAgKiBoYXBweS4gKi8NCj4gDQo+IENoZWVy cywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Fri May 13 02:42:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 02:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328182.551135 (Exim 4.92) (envelope-from ) id 1npLG4-0004wi-0M; Fri, 13 May 2022 02:42:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328182.551135; Fri, 13 May 2022 02:42:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npLG3-0004wb-SN; Fri, 13 May 2022 02:42:23 +0000 Received: by outflank-mailman (input) for mailman id 328182; Fri, 13 May 2022 02:42:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npLG3-0004wV-0J for xen-devel@lists.xenproject.org; Fri, 13 May 2022 02:42:23 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0622.outbound.protection.outlook.com [2a01:111:f400:fe05::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5010f069-d266-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 04:42:21 +0200 (CEST) Received: from DB6PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:6:42::11) by AM9PR08MB6273.eurprd08.prod.outlook.com (2603:10a6:20b:2d7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 02:42:18 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::b6) by DB6PR07CA0181.outlook.office365.com (2603:10a6:6:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.5 via Frontend Transport; Fri, 13 May 2022 02:42:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Fri, 13 May 2022 02:42:18 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Fri, 13 May 2022 02:42:18 +0000 Received: from 9eb195115555.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D537B42A-F7A2-4CA1-9F75-E91FC6876180.1; Fri, 13 May 2022 02:42:12 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9eb195115555.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 May 2022 02:42:12 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by GV2PR08MB8194.eurprd08.prod.outlook.com (2603:10a6:150:74::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Fri, 13 May 2022 02:42:10 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%4]) with mapi id 15.20.5227.023; Fri, 13 May 2022 02:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5010f069-d266-11ec-8fc4-03012f2f19d4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ex8yfYye9ucAgMOT+T9EsuC0YtV4k7kkrMrBCy0TCvCV+nvUINs7yKIazfOqtBegwrCnvwdiT7LRDzICJeSh+Nx86BQnAukY4CrWOG93bHtXEvb2onDQD3nbFwp59DFqYljS3uy6B9kD1uX0Qf9/Jfys+YlXepr1PvjzTlQymAwqjB6xUtvCLo0h7B+AOWTBbXprQiz5q/qI9w4bVLpDbTk8r3wTlxgnAbYirIbvdzKoMktgLhGoR0KXZ3+7Fe6h7uboocFP26KWS+DtfwdOpbvfwXq+ei0p1m6o+7c0+E7oORSI76D/8eDR0vB/EMmrfyyHq5jYD1AcjPwRra4xfw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+YhhWiMDlK172WESsK+wdy5yEx61PMBjjPC0aN5sFxI=; b=h9Z3Q3YyEsUd/oy0ltbXTmD+CYgCQuIzUQ55xtLL8gx9pPLZSxf91HXEcVKWc1fk9UudwNjKVD4nsK9BIYJLAimj2Oxs8IykBEFXUF9zzkNCQB0wPqR0EpSOggYgEB4jS4TnhhnRmGBGcSPus1yxackgf8R1AISyuLkD3I1lx8t4gpx5s1tMU/lkFuGutGSrb1yfnHX9sAU7z5B4HQLYx/Ab5JysZc34qbDOyevqpyGHahTnsNBBVYZsrPlzvWpyZfY1RN+J/nbn/Vq56G8fwV7cht4yB8IjheWsRRSI16Dn0iNT2FkQkCiCGb6cWmAxMTfbRRXHiuXrbIuMl7Wajw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YhhWiMDlK172WESsK+wdy5yEx61PMBjjPC0aN5sFxI=; b=biKndOkeNmy6SY9tumjSypT1SJ87fIugRGl4S839krLqaLQjEdznx/hhh5mOIYR5/3ILlPhk2xScWzci12FUs/6u13c9DCgtfq5191/VcM+6ZIPHtuSV+bQvir5Xr/bT3XCac41R0it5QqWGr3QM8Lv4bADeLr+9wlwI+OIMuDo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nEtryKVLgStzm1C8JkJ5sGn6OwHgneIt7r0raTqLCNZJax0PA+B7/ozPFvHmvfDYVRGXYKy3xdGwo/d/3FPwTtDOQhIEijROcAdICYauOuPCzMc714/1KW4f78vfTB39WVWrVDiNa/RSJkfgU4/o42+gMtDiv7KImXG8d3E9K0yP1Nc6s1ze2rgGidT1Dt4gb06etlpuYVBgEKiMtHl6/Uw7sJvxCzZDkS51cPO+T0x3qSORjBjY90ZcRqKILp61DH5TudAPOeg3zXpdeJmTSElsHZzylBoC5q+Ke6XOQmLia3653pquc8R+yhhxJQj5fqDmcY0BrdFCCiHKOKNVJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+YhhWiMDlK172WESsK+wdy5yEx61PMBjjPC0aN5sFxI=; b=lMh4BSd5knt5EaUeWDvWJ23GFixQ5JPUJ5/tJkHlCXIgEcmNWOh2q4HYRCAY7CSJ5mKZxR0UiTyXR/3iowDYkT0i4ra3TVI3/UOMBahG7RiFfFLAfDf3An3qoFLlxSDQZQ4OCMjHYamVuuS5zb9sYAZxKCdtoqcC/5nnfY6naiXELrt2wcNMWePE9JG446uK/coQ+r2UGahHTSpjqvNOw/TyQMs8AmmmFyPMI8+rzIHrS/9qxTw6NCrQNcucgU5mvrTrpLxvDdE5+Fzkz79W9sXvu0IFf1fYtlDT4Jylag7zxOj2VAwmqEhriW4JcAcJE8mAWTVKsttyUWrl89Smgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+YhhWiMDlK172WESsK+wdy5yEx61PMBjjPC0aN5sFxI=; b=biKndOkeNmy6SY9tumjSypT1SJ87fIugRGl4S839krLqaLQjEdznx/hhh5mOIYR5/3ILlPhk2xScWzci12FUs/6u13c9DCgtfq5191/VcM+6ZIPHtuSV+bQvir5Xr/bT3XCac41R0it5QqWGr3QM8Lv4bADeLr+9wlwI+OIMuDo= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v3 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated Thread-Topic: [PATCH v3 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated Thread-Index: AQHYZeBsChCHxU3E+kiLDNmMZ1+Ip60bEXqAgAD3CMA= Date: Fri, 13 May 2022 02:42:09 +0000 Message-ID: References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-6-Penny.Zheng@arm.com> <32b425e9-2430-8525-913e-6626efbec415@xen.org> In-Reply-To: <32b425e9-2430-8525-913e-6626efbec415@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5277031DC0D25847835A923FE708E5E1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 18f13235-6f90-4a11-21d2-08da348a3266 x-ms-traffictypediagnostic: GV2PR08MB8194:EE_|DBAEUR03FT033:EE_|AM9PR08MB6273:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cKaSaohGBo0xx1t2l7GkXFCJcBHnnhFeifpjeFvZsPyyesV3p7m++doD726Z9hLUSbHfzo/f7dKelmsOYPSIz4/fp6HUtnIZqIXuHxsRjr6ky6JGOZGQ7j8XY8LA7L0JYauuzqvGuOESI8WnAdnkupQrWaO8N1ta8Y5zqVa0jJPyoLnPcx0E0zR3juwvzJ1T7kbo9mGSHr7OTr8g4YgjWpB59KRYdEc0MEalYRcirjp8oj7IDYSle41Tqmnkael5Oo4wX22lDr6MJP1aN5I0AbUeLJ1uAHz++ToHkAbpbguJtzuS+Ip6AZ9cm4dp8L4dLGv1AYR4zdKpFNGRnX2Orh7pJSzjGQ3Z8FCdwkKgYbN6EQGLFuii3vPYdCs/oxt4YcG/B/eR+ut4lQbV7c0KZVDEe5zHHyUS0UA+k1MFOUD9IssAkOOwywelcGYKAVMavh8hokyGb6TbYAvEMqw6ya5bksa1HHdjW3C/ZtN4J0VcSw1T8c8W8UWrMoy/V21h9e2p4feK8uWHri1yUgcCQ4iXey3H9Rg8vrIqn256usiOuhE1aqWxMVTnlKpasnN8rFCpBGVUSmH4rpx8Gl3Q1XxpbdVB8nBckB2Edq6To+zkUIBnamhyitTUawvumTkZXQMoTcTwR68B5aejIUwj16KnpzNTgWpJN7vw79fE36DQbWj0HLskB/csWEzE/WCjAWhK+c8gkCPlujlmM1XqFw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(8936002)(55016003)(52536014)(33656002)(5660300002)(66476007)(64756008)(66556008)(66946007)(66446008)(8676002)(76116006)(4326008)(38100700002)(86362001)(38070700005)(54906003)(83380400001)(186003)(110136005)(9686003)(6506007)(26005)(7696005)(53546011)(316002)(122000001)(508600001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8194 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 935a15cc-d793-408c-ecda-08da348a2d88 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PzjmN4zG7LdRMVAk+n8f5Myp0BZ6bl49LXIUqs1QR2NhRB0+G5RlWjMBv+yVRZDQvKkSC9mJ4LAI+zrHcRidZiv2/8Vyg2zQdFjeCbf7AnQRgbfR27z/sIqcJdxsyRaDEo/IXGVRO1x96jS/QRraehiOtsTYATXmXt+Khjh2HnqVkL5ckSq26gLDv0qdpih/CdJlH+sbQxcfpgPnYfEB14JOBa2OMt8olJyWURgO09xqoazpg+a0B86j4adyfIbedYdjXW6kqrboE0h0EVAH/qJ8NYeJYEAsUAAdqPMgZ0F2v8pIZke2+05QaSQcnfxoMtODnLwH8PUbFvUdJh+YAX6R+zJKQb7pY0dZtXnRQiDKLLLj/Z/2dNql7SCCtpujypqT561DVSfY8RrhEuXadgX4zsyEzBZ+IptVRw/IxPQPd+OKM+JOXFH5ExSgEnZnkvv7JCMj6cOUbybGGx2xgK11aB7/7TpAByfDMZ2MmpdtrxfaHWRuJ0PST3jgS4EMdDeFQtzzrM1gxROzodvCFNElRIhlWe8WurxSEUrOPHrCX1Sd9LxXgJNQ5by2Z73qEUJMdhlj6Uuabi0NU+S3etRj6zbjiacG4tzFxnOg5vxS2wnQTmlUpNn+zbpyt9199QqwdjQHg8em4RT2KVVEkJCzByp4hQWdzLfGjqVkDwzV2Cki8eYvvCc3rLiSXX6R X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(83380400001)(336012)(53546011)(6506007)(26005)(9686003)(7696005)(107886003)(36860700001)(47076005)(2906002)(8936002)(52536014)(5660300002)(55016003)(82310400005)(40460700003)(54906003)(508600001)(70206006)(110136005)(70586007)(316002)(4326008)(8676002)(33656002)(356005)(81166007)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 02:42:18.1875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18f13235-6f90-4a11-21d2-08da348a3266 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6273 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVGh1cnNkYXksIE1heSAxMiwgMjAyMiA2 OjU0IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+ OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFu ZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1 ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMg NS84XSB4ZW4vYXJtOiBBZGQgYWRkaXRpb25hbCByZWZlcmVuY2UgdG8gb3duZXINCj4gZG9tYWlu IHdoZW4gdGhlIG93bmVyIGlzIGFsbG9jYXRlZA0KPiANCj4gDQo+IA0KPiBPbiAxMi8wNS8yMDIy IDEwOjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBAQCAtODI3LDYgKzg1OCwzNyBAQCBzdGF0 aWMgaW50IF9faW5pdCBhbGxvY2F0ZV9zaGFyZWRfbWVtb3J5KHN0cnVjdA0KPiBkb21haW4gKmQs DQo+ID4gICAgICAgICAgIH0NCj4gPiAgICAgICB9DQo+ID4NCj4gPiArICAgIC8qDQo+ID4gKyAg ICAgKiBHZXQgdGhlIHJpZ2h0IGFtb3VudCBvZiByZWZlcmVuY2VzIHBlciBwYWdlLCB3aGljaCBp cyB0aGUgbnVtYmVyIG9mDQo+ID4gKyAgICAgKiBib3Jyb3cgZG9tYWlucy4NCj4gPiArICAgICAq Lw0KPiA+ICsgICAgcmV0ID0gYWNxdWlyZV9ucl9ib3Jyb3dlcl9kb21haW4oZCwgcGJhc2UsIHBz aXplLCAmbnJfYm9ycm93ZXJzKTsNCj4gPiArICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICBy ZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBJbnN0ZWFkIG9mIGxl dCBib3Jyb3dlciBkb21haW4gZ2V0IGEgcGFnZSByZWYsIHdlIGFkZCBhcyBtYW55DQo+ID4gKyAg ICAgKiBhZGRpdGlvbmFsIHJlZmVyZW5jZSBhcyB0aGUgbnVtYmVyIG9mIGJvcnJvd2VycyB3aGVu IHRoZSBvd25lcg0KPiA+ICsgICAgICogaXMgYWxsb2NhdGVkLCBzaW5jZSB0aGVyZSBpcyBhIGNo YW5jZSB0aGF0IG93bmVyIGlzIGNyZWF0ZWQNCj4gPiArICAgICAqIGFmdGVyIGJvcnJvd2VyLg0K PiA+ICsgICAgICovDQo+ID4gKyAgICBwYWdlID0gbWZuX3RvX3BhZ2Uoc21mbik7DQo+IFdoZXJl IGRvIHlvdSBjaGVjayB0aGF0IHRoZSByYW5nZSBbc21mbiwgc21mbiArIG5yX3BhZ2VzXSBpcyBh Y3R1YWwgUkFNPw0KPiBJZiB0aGVyZSBhcmUgbm9uZSwgdGhlbiB5b3Ugc2hvdWxkIHVzZSBtZm5f dmFsaWQoKSBmb3IgZWFjaCBtZm4gdG8gZW5zdXJlDQo+IHRoZXJlIHdpbGwgYmUgYSBzdHJ1Y3Qg cGFnZSBmb3IgaXQuDQo+DQoNCkFjdHVhbGx5LCBiZWZvcmUgdGhpcywgaW4gYWNxdWlyZV9zaGFy ZWRfbWVtb3J5X2JhbmssIHdlIHdpbGwgZmluYWxseSBjYWxsIGludG8NCmFjcXVpcmVfc3RhdGlj bWVtX3BhZ2VzIHRvIGFjcXVpcmUgW3NtZm4sIHNtZm4gKyBucl9wYWdlc10sIGFuZCBpbiB0aGVy ZSwgd2UNCndpbGwgZG8gdGhlIGNoZWNrLiBTZWUgeGVuL2NvbW1vbi9wYWdlX2FsbG9jLmM6YWNx dWlyZV9zdGF0aWNtZW1fcGFnZXM6MjY3Ng0KIA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxp ZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Fri May 13 03:59:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 03:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328190.551146 (Exim 4.92) (envelope-from ) id 1npMSk-0003S2-T9; Fri, 13 May 2022 03:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328190.551146; Fri, 13 May 2022 03:59:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMSk-0003Rv-PZ; Fri, 13 May 2022 03:59:34 +0000 Received: by outflank-mailman (input) for mailman id 328190; Fri, 13 May 2022 03:59:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMSi-0003Rl-Ub; Fri, 13 May 2022 03:59:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMSi-0005vI-RK; Fri, 13 May 2022 03:59:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMSi-00017w-Dk; Fri, 13 May 2022 03:59:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npMSi-0006Gm-AS; Fri, 13 May 2022 03:59:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UvVANfmzGrtREumv3gSJBxLyyhZyxtEm/1hxpQRCfSU=; b=IyvyEk4IWGuYBC+ytikdsJnUtq xA/obimLVBFn69+G+r0Y/inkhlvkBLZgq5aFUYO8tlhGB1FkDJw119HeRMC+jqkxjhbxRe7BkjBsu opf4sQ4sEOX6LIuGSRxr+v24CtWiiW+j1YdFYe6lfIQfwfkLeJ8GFjYyixr+wYmCeK74=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170376: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 03:59:32 +0000 flight 170376 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170376/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 974 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 04:30:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 04:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328199.551157 (Exim 4.92) (envelope-from ) id 1npMwz-0007l0-E0; Fri, 13 May 2022 04:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328199.551157; Fri, 13 May 2022 04:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMwz-0007kt-9U; Fri, 13 May 2022 04:30:49 +0000 Received: by outflank-mailman (input) for mailman id 328199; Fri, 13 May 2022 04:30:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMwx-0007kj-Mu; Fri, 13 May 2022 04:30:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMwx-0006hr-IU; Fri, 13 May 2022 04:30:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npMwx-0003P8-3X; Fri, 13 May 2022 04:30:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npMwx-00067A-34; Fri, 13 May 2022 04:30:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s5xcW5UNZtTO+2OrkgpooCVr+6e8hqxoCG+itW6kMmc=; b=bjvS4W3yhnYgy98Sr3mFJfAswU RS5xer4kDvupS5pg54i+wfXbWEPd16Se4T5/RdzNnArCoVQgnM6Ybe5mSobeF2YdX3G5Bx5MralTa Tb3tDzXVPjPLpLV3MNZZ/8eldLTCbUPfP/+wYSBwhe8NRfGqx04sCltMGMgalC86183I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170365: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0ac824f379fba2c2b17b75fd5ada69cd68c66348 X-Osstest-Versions-That: linux=feb9c5e19e913b53cb536a7aa7c9f20107bb51ec From: osstest service owner Date: Fri, 13 May 2022 04:30:47 +0000 flight 170365 linux-linus real [real] flight 170377 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170365/ http://logs.test-lab.xenproject.org/osstest/logs/170377/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail pass in 170377-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170306 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170306 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170306 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170306 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170306 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170306 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170306 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170306 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 0ac824f379fba2c2b17b75fd5ada69cd68c66348 baseline version: linux feb9c5e19e913b53cb536a7aa7c9f20107bb51ec Last test of basis 170306 2022-05-10 18:39:54 Z 2 days Testing same since 170365 2022-05-12 18:09:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Amir Goldstein Feng Tang Jan Kara Jing Xia Linus Torvalds Tejun Heo Waiman Long jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git feb9c5e19e91..0ac824f379fb 0ac824f379fba2c2b17b75fd5ada69cd68c66348 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 13 05:34:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 05:34:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328208.551168 (Exim 4.92) (envelope-from ) id 1npNw3-0005Z9-4M; Fri, 13 May 2022 05:33:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328208.551168; Fri, 13 May 2022 05:33:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npNw3-0005Z2-1E; Fri, 13 May 2022 05:33:55 +0000 Received: by outflank-mailman (input) for mailman id 328208; Fri, 13 May 2022 05:33:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npNw1-0005Yw-Ke for xen-devel@lists.xenproject.org; Fri, 13 May 2022 05:33:53 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44e0583e-d27e-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 07:33:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D16421AE2; Fri, 13 May 2022 05:33:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CF59E13A84; Fri, 13 May 2022 05:33:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sZhGMb3tfWLIFgAAMHmgww (envelope-from ); Fri, 13 May 2022 05:33:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44e0583e-d27e-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652420030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AaNK9VI92CtlLRufqelHTuZqKOQA/3zBp3OZRQgQ4/A=; b=NGRd1kaTOR9gXF3g5ClJFREszBP4PQdh6s7fgHjNNMGjRtcluLQekZrKNbxw/xnDC3p+jq TuCBukRsHNhwWmix40crh+zQstPofhp/WEzn9EBQG5OwjTBZln9tLxYnQXzc3rTKh5I5ri YsFiMzYlJ/+Wj3ZY/LHzBJ7b/tMRzx0= Message-ID: Date: Fri, 13 May 2022 07:33:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Boris Ostrovsky , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> From: Juergen Gross Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants In-Reply-To: <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Sr9EeqdIb8iPoFhoY08CFv9r" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Sr9EeqdIb8iPoFhoY08CFv9r Content-Type: multipart/mixed; boundary="------------ss12YByrfgbibODZLOK0ywZB"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Message-ID: Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> In-Reply-To: <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> --------------ss12YByrfgbibODZLOK0ywZB Content-Type: multipart/mixed; boundary="------------FphEvG0f0pwtWW6kWmn04s0b" --------------FphEvG0f0pwtWW6kWmn04s0b Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDUuMjIgMjI6MDEsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDUv Ny8yMiAyOjE5IFBNLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+ICsNCj4+ICsv Kg0KPj4gKyAqIEhhbmRsaW5nIG9mIGZyZWUgZ3JhbnRzOg0KPj4gKyAqDQo+PiArICogRnJl ZSBncmFudHMgYXJlIGluIGEgc2ltcGxlIGxpc3QgYW5jaG9yZWQgaW4gZ250dGFiX2ZyZWVf aGVhZC4gVGhleSBhcmUNCj4+ICsgKiBsaW5rZWQgYnkgZ3JhbnQgcmVmLCB0aGUgbGFzdCBl bGVtZW50IGNvbnRhaW5zIEdOVFRBQl9MSVNUX0VORC4gVGhlIG51bWJlcg0KPj4gKyAqIG9m IGZyZWUgZW50cmllcyBpcyBzdG9yZWQgaW4gZ250dGFiX2ZyZWVfY291bnQuDQo+PiArICog QWRkaXRpb25hbGx5IHRoZXJlIGlzIGEgYml0bWFwIG9mIGZyZWUgZW50cmllcyBhbmNob3Jl ZCBpbg0KPj4gKyAqIGdudHRhYl9mcmVlX2JpdG1hcC4gVGhpcyBpcyBiZWluZyB1c2VkIGZv ciBzaW1wbGlmeWluZyBhbGxvY2F0aW9uIG9mDQo+PiArICogbXVsdGlwbGUgY29uc2VjdXRp dmUgZ3JhbnRzLCB3aGljaCBpcyBuZWVkZWQgZS5nLiBmb3Igc3VwcG9ydCBvZiB2aXJ0aW8u DQo+PiArICogZ250dGFiX2xhc3RfZnJlZSBpcyB1c2VkIHRvIGFkZCBmcmVlIGVudHJpZXMg b2YgbmV3IGZyYW1lcyBhdCB0aGUgZW5kIG9mDQo+PiArICogdGhlIGZyZWUgbGlzdC4NCj4+ ICsgKiBnbnR0YWJfZnJlZV90YWlsX3B0ciBzcGVjaWZpZXMgdGhlIHZhcmlhYmxlIHdoaWNo IHJlZmVyZW5jZXMgdGhlIHN0YXJ0DQo+IA0KPiANCj4gSWYgdGhpcyByZWZlcmVuY2VzIHRo ZSBzdGFydCBvZiB0aGUgZnJlZSBpbnRlcnZhbCwgd2h5IGlzIGl0IGNhbGxlZCANCj4gZ250 dGFiX2ZyZWVfKnRhaWwqX3B0cj8NCg0KQmVjYXVzZSB0aGlzIGlzIHRoZSB0YWlsIG9mIHRo ZSB3aG9sZSBhcmVhIHdoaWNoIGlzIGZyZWUuDQoNCkl0IGNvdWxkIGJlIHJlbmFtZWQgdG8g Z250dGFiX2ZyZWVfdGFpbF9zdGFydF9wdHIuIDotKQ0KDQo+IA0KPiANCj4+ICsgKiBvZiBj b25zZWN1dGl2ZSBmcmVlIGdyYW50cyBlbmRpbmcgd2l0aCBnbnR0YWJfbGFzdF9mcmVlLiBU aGlzIHBvaW50ZXIgaXMNCj4+ICsgKiB1cGRhdGVkIGluIGEgcmF0aGVyIGRlZmVuc2l2ZSB3 YXksIGluIG9yZGVyIHRvIGF2b2lkIHBlcmZvcm1hbmNlIGhpdHMgaW4NCj4+ICsgKiBob3Qg cGF0aHMuDQo+PiArICogQWxsIHRob3NlIHZhcmlhYmxlcyBhcmUgcHJvdGVjdGVkIGJ5IGdu dHRhYl9saXN0X2xvY2suDQo+PiArICovDQo+PiDCoCBzdGF0aWMgaW50IGdudHRhYl9mcmVl X2NvdW50Ow0KPj4gLXN0YXRpYyBncmFudF9yZWZfdCBnbnR0YWJfZnJlZV9oZWFkOw0KPj4g K3N0YXRpYyB1bnNpZ25lZCBpbnQgZ250dGFiX3NpemU7DQo+PiArc3RhdGljIGdyYW50X3Jl Zl90IGdudHRhYl9mcmVlX2hlYWQgPSBHTlRUQUJfTElTVF9FTkQ7DQo+PiArc3RhdGljIGdy YW50X3JlZl90IGdudHRhYl9sYXN0X2ZyZWUgPSBHTlRUQUJfTElTVF9FTkQ7DQo+PiArc3Rh dGljIGdyYW50X3JlZl90ICpnbnR0YWJfZnJlZV90YWlsX3B0cjsNCj4+ICtzdGF0aWMgdW5z aWduZWQgbG9uZyAqZ250dGFiX2ZyZWVfYml0bWFwOw0KPj4gwqAgc3RhdGljIERFRklORV9T UElOTE9DSyhnbnR0YWJfbGlzdF9sb2NrKTsNCj4+ICsNCj4+IMKgIHN0cnVjdCBncmFudF9m cmFtZXMgeGVuX2F1dG9feGxhdF9ncmFudF9mcmFtZXM7DQo+PiDCoCBzdGF0aWMgdW5zaWdu ZWQgaW50IHhlbl9nbnR0YWJfdmVyc2lvbjsNCj4+IMKgIG1vZHVsZV9wYXJhbV9uYW1lZCh2 ZXJzaW9uLCB4ZW5fZ250dGFiX3ZlcnNpb24sIHVpbnQsIDApOw0KPj4gQEAgLTE3MCwxNiAr MTk0LDExMSBAQCBzdGF0aWMgaW50IGdldF9mcmVlX2VudHJpZXModW5zaWduZWQgY291bnQp DQo+PiDCoMKgwqDCoMKgIHJlZiA9IGhlYWQgPSBnbnR0YWJfZnJlZV9oZWFkOw0KPj4gwqDC oMKgwqDCoCBnbnR0YWJfZnJlZV9jb3VudCAtPSBjb3VudDsNCj4+IC3CoMKgwqAgd2hpbGUg KGNvdW50LS0gPiAxKQ0KPj4gLcKgwqDCoMKgwqDCoMKgIGhlYWQgPSBnbnR0YWJfZW50cnko aGVhZCk7DQo+PiArwqDCoMKgIHdoaWxlIChjb3VudC0tKSB7DQo+PiArwqDCoMKgwqDCoMKg wqAgYml0bWFwX2NsZWFyKGdudHRhYl9mcmVlX2JpdG1hcCwgaGVhZCwgMSk7DQo+PiArwqDC oMKgwqDCoMKgwqAgaWYgKGdudHRhYl9mcmVlX3RhaWxfcHRyID09IF9fZ250dGFiX2VudHJ5 KGhlYWQpKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ250dGFiX2ZyZWVfdGFpbF9w dHIgPSAmZ250dGFiX2ZyZWVfaGVhZDsNCj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoY291bnQp DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBoZWFkID0gZ250dGFiX2VudHJ5KGhlYWQp Ow0KPj4gK8KgwqDCoCB9DQo+PiDCoMKgwqDCoMKgIGdudHRhYl9mcmVlX2hlYWQgPSBnbnR0 YWJfZW50cnkoaGVhZCk7DQo+PiDCoMKgwqDCoMKgIGdudHRhYl9lbnRyeShoZWFkKSA9IEdO VFRBQl9MSVNUX0VORDsNCj4+ICvCoMKgwqAgaWYgKCFnbnR0YWJfZnJlZV9jb3VudCkgew0K Pj4gK8KgwqDCoMKgwqDCoMKgIGdudHRhYl9sYXN0X2ZyZWUgPSBHTlRUQUJfTElTVF9FTkQ7 DQo+PiArwqDCoMKgwqDCoMKgwqAgZ250dGFiX2ZyZWVfdGFpbF9wdHIgPSBOVUxMOw0KPj4g K8KgwqDCoCB9DQo+PiArDQo+PiDCoMKgwqDCoMKgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUo JmdudHRhYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+IMKgwqDCoMKgwqAgcmV0dXJuIHJlZjsN Cj4+IMKgIH0NCj4+ICtzdGF0aWMgaW50IGdldF9zZXFfZW50cnlfY291bnQodm9pZCkNCj4+ ICt7DQo+PiArwqDCoMKgIGlmIChnbnR0YWJfbGFzdF9mcmVlID09IEdOVFRBQl9MSVNUX0VO RCB8fCAhZ250dGFiX2ZyZWVfdGFpbF9wdHIgfHwNCj4+ICvCoMKgwqDCoMKgwqDCoCAqZ250 dGFiX2ZyZWVfdGFpbF9wdHIgPT0gR05UVEFCX0xJU1RfRU5EKQ0KPj4gK8KgwqDCoMKgwqDC oMKgIHJldHVybiAwOw0KPj4gKw0KPj4gK8KgwqDCoCByZXR1cm4gZ250dGFiX2xhc3RfZnJl ZSAtICpnbnR0YWJfZnJlZV90YWlsX3B0ciArIDE7DQo+PiArfQ0KPj4gKw0KPj4gKy8qIFJl YnVpbGRzIHRoZSBmcmVlIGdyYW50IGxpc3QgYW5kIHRyaWVzIHRvIGZpbmQgY291bnQgY29u c2VjdXRpdmUgZW50cmllcy4gKi8NCj4+ICtzdGF0aWMgaW50IGdldF9mcmVlX3NlcSh1bnNp Z25lZCBpbnQgY291bnQpDQo+PiArew0KPj4gK8KgwqDCoCBpbnQgcmV0ID0gLUVOT1NQQzsN Cj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGZyb20sIHRvOw0KPj4gK8KgwqDCoCBncmFudF9y ZWZfdCAqbGFzdDsNCj4+ICsNCj4+ICvCoMKgwqAgZ250dGFiX2ZyZWVfdGFpbF9wdHIgPSAm Z250dGFiX2ZyZWVfaGVhZDsNCj4+ICvCoMKgwqAgbGFzdCA9ICZnbnR0YWJfZnJlZV9oZWFk Ow0KPj4gKw0KPj4gK8KgwqDCoCBmb3IgKGZyb20gPSBmaW5kX2ZpcnN0X2JpdChnbnR0YWJf ZnJlZV9iaXRtYXAsIGdudHRhYl9zaXplKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgIGZyb20g PCBnbnR0YWJfc2l6ZTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgIGZyb20gPSBmaW5kX25leHRf Yml0KGdudHRhYl9mcmVlX2JpdG1hcCwgZ250dGFiX3NpemUsIHRvICsgMSkpIHsNCj4+ICvC oMKgwqDCoMKgwqDCoCB0byA9IGZpbmRfbmV4dF96ZXJvX2JpdChnbnR0YWJfZnJlZV9iaXRt YXAsIGdudHRhYl9zaXplLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGZyb20gKyAxKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocmV0IDwgMCAmJiB0 byAtIGZyb20gPj0gY291bnQpIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9 IGZyb207DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBiaXRtYXBfY2xlYXIoZ250dGFi X2ZyZWVfYml0bWFwLCByZXQsIGNvdW50KTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGZyb20gKz0gY291bnQ7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnbnR0YWJfZnJl ZV9jb3VudCAtPSBjb3VudDsNCj4gDQo+IA0KPiBJSVVJQyB3ZSBjYW4gaGF2ZSBtdWx0aXBs ZSBwYXNzZXMgb3ZlciB0aGlzLCBtZWFuaW5nIHRoYXQgdGhlIGdudHRhYl9mcmVlX2NvdW50 IA0KPiBtYXkgYmUgZGVjcmVtZW50ZWQgbW9yZSB0aGFuIG9uY2UuIElzIHRoYXQgaW50ZW50 aW9uYWw/DQoNCkFmdGVyIHRoZSBmaXJzdCBwYXNzIGRlY3JlbWVudGluZyBnbnR0YWJfZnJl ZV9jbnQsIHJldCB3aWxsIG5vDQpsb25nZXIgYmUgbGVzcyB0aGFuIHplcm8sIHNvIHRoaXMg Y2FuIGJlIGhpdCBvbmx5IG9uY2UuDQoNCj4gDQo+IA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgaWYgKGZyb20gPT0gdG8pDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGNvbnRpbnVlOw0KPj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+ICsNCj4+ICvCoMKgwqDC oMKgwqDCoCB3aGlsZSAoZnJvbSA8IHRvKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAqbGFzdCA9IGZyb207DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsYXN0ID0gX19n bnR0YWJfZW50cnkoZnJvbSk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnbnR0YWJf bGFzdF9mcmVlID0gZnJvbTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZyb20rKzsN Cj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+IA0KPiANCj4gSSBoYXZlIGJlZW4gbG9va2luZyBh dCB0aGlzIGxvb3AgYW5kIEkgY2FuJ3QgdW5kZXJzdGFuZCB3aGF0IGl0IGlzIGRvaW5nIDst KCBDYW4gDQo+IHlvdSBlbmxpZ2h0ZW4gbWU/DQoNCkl0IGlzIHJlY3JlYXRpbmcgdGhlIGZy ZWUgbGlzdCBpbiBvcmRlciB0byBoYXZlIGl0IHByb3Blcmx5IHNvcnRlZC4NClRoaXMgaXMg bmVlZGVkIHRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBmcmVlIHRhaWwgaGFzIHRoZSBtYXhpbXVt DQpwb3NzaWJsZSBzaXplICh5b3UgY2FuIHRha2UgdGhlIHRhaWwgb2ZmIHRoZSBsaXN0IHdp dGhvdXQgaGF2aW5nDQp0byB3b3JyeSBhYm91dCBicmVha2luZyB0aGUgbGlua2VkIGxpc3Qg YmVjYXVzZSBvZiByZWZlcmVuY2VzIGludG8NCnRoZSB0YWlsKS4NCg0KDQpKdWVyZ2VuDQo= --------------FphEvG0f0pwtWW6kWmn04s0b Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------FphEvG0f0pwtWW6kWmn04s0b-- --------------ss12YByrfgbibODZLOK0ywZB-- --------------Sr9EeqdIb8iPoFhoY08CFv9r Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ97b0FAwAAAAAACgkQsN6d1ii/Ey/l FQf/WRYZFQzeL2rCU3Bru0qDZto4066JMU0804HHabSJhzePs20dNQpUSPrqiIPkCy3cFlcjs/uQ gh8ThS9wdbfxqmSpG6PDqiKVU3ggP9mcz7OUiGXVH5z3mv4Pxa7xRWc6t8NHm2DbfGi4q/nMHKcq 0CPLvRHfQXugz27DOZWxjx3SmvYQuoNsPyTK7qnuAl8Bq2KwGJEhipNX69aCDrlZLVsCxqWHtBkF te7agxLVIRoX/ify9yjnWmGeRo/3Zbbv1UDGCNCUlWzwg/9j92N9/y0PzAbn4219F1pxyDMV4BEV nY3AH1mPgUCiM4gUFkjgFAyZsH2F/W16iFMkSoSqEA== =Pt1N -----END PGP SIGNATURE----- --------------Sr9EeqdIb8iPoFhoY08CFv9r-- From xen-devel-bounces@lists.xenproject.org Fri May 13 05:34:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 05:34:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327983.551178 (Exim 4.92) (envelope-from ) id 1npNwT-0005zy-Gs; Fri, 13 May 2022 05:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327983.551178; Fri, 13 May 2022 05:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npNwT-0005zr-Dz; Fri, 13 May 2022 05:34:21 +0000 Received: by outflank-mailman (input) for mailman id 327983; Thu, 12 May 2022 21:41:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGYw-0007I3-Fj for xen-devel@lists.xenproject.org; Thu, 12 May 2022 21:41:34 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49adfa64-d23c-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 23:41:32 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-651-_lIP8Q0uMUaVvsz49D3spw-1; Thu, 12 May 2022 17:41:24 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E9268296A609; Thu, 12 May 2022 21:41:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E2C7416156; Thu, 12 May 2022 21:41:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49adfa64-d23c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652391691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YX4qZOz+9WbIDFanSGeueshT1smpwyQHiwCB0mvZIgg=; b=PJOaSv3WRC6mW8fZIEeGNINL8AFfYV/cmpyaj0b60jdo61YZtLWwHjI13lcxJUtguTiBd0 e7Viy8VZ2VtnUIXmveWCj7AsY5cedemQKGLnZmSszi8yF8q6vDw8yfxnbp4xaZVd5JbEgd tna+B+5FsaWBa4ZrgAYRX5bJ04PvTc4= X-MC-Unique: _lIP8Q0uMUaVvsz49D3spw-1 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220504014440.3697851-20-keescook@chromium.org> References: <20220504014440.3697851-20-keescook@chromium.org> <20220504014440.3697851-1-keescook@chromium.org> To: Kees Cook Cc: "Gustavo A . R . Silva" , David Howells , Marc Dionne , linux-afs@lists.infradead.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?utf-8?Q?G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?utf-8?Q?S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 19/32] afs: Use mem_to_flex_dup() with struct afs_acl MIME-Version: 1.0 Date: Thu, 12 May 2022 22:41:05 +0100 Message-ID: <898803.1652391665@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dhowells@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Kees Cook wrote: > struct afs_acl { > - u32 size; > - u8 data[]; > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, size); > + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); > }; Oof... That's really quite unpleasant syntax. Is it not possible to have mem_to_flex_dup() and friends work without that? You are telling them the fields they have to fill in. > + struct afs_acl *acl = NULL; > > - acl = kmalloc(sizeof(*acl) + size, GFP_KERNEL); > - if (!acl) { > + if (mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL)) { Please don't do that. Either do: acl = mem_to_flex_dup(buffer, size, GFP_KERNEL); if (!acl) or: acl = mem_to_flex_dup(buffer, size, GFP_KERNEL); if (IS_ERR(acl)) Please especially don't make it that an apparent 'true' return indicates an error. If you absolutely must return the acl pointer through the argument list (presumably because it's actually a macro), make it return false on failure: if (!mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL)) or return and explicitly check for an error code: if (mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL) < 0) or: ret = mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL); if (ret < 0) (or use != 0 rather than < 0) David From xen-devel-bounces@lists.xenproject.org Fri May 13 05:34:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 05:34:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.327986.551184 (Exim 4.92) (envelope-from ) id 1npNwT-000632-SK; Fri, 13 May 2022 05:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 327986.551184; Fri, 13 May 2022 05:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npNwT-00061r-NX; Fri, 13 May 2022 05:34:21 +0000 Received: by outflank-mailman (input) for mailman id 327986; Thu, 12 May 2022 21:47:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npGf4-0007OA-14 for xen-devel@lists.xenproject.org; Thu, 12 May 2022 21:47:54 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c48fae1-d23d-11ec-8fc4-03012f2f19d4; Thu, 12 May 2022 23:47:53 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-454-NFJuRb6GPNSx8zbxy-lQgA-1; Thu, 12 May 2022 17:47:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD4CF296A60E; Thu, 12 May 2022 21:47:45 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id A13B84010E23; Thu, 12 May 2022 21:47:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c48fae1-d23d-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652392071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YWzVrdFw3n8EH2Ce8k4daz33bBf83epcMdzHAJNT8tE=; b=PJ+AYPyj8pLd2Z53EbADYFV5StVYRn6S6jED85CI2KX0LlZFLoUwWpJgqxLVR1cCp1TA7w Ee+yFuIUie++p0yEbE/jlRz3u/BKcr+QXYIEz+i/gmydFs8giFyA8SPefd+tYPxjE25Y4f XVAG82zZg9XBaQNlBcyJxcIQAVNriuI= X-MC-Unique: NFJuRb6GPNSx8zbxy-lQgA-1 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220504014440.3697851-1-keescook@chromium.org> References: <20220504014440.3697851-1-keescook@chromium.org> To: Kees Cook Cc: Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?utf-8?Q?G=C3=B6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , David Howells , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marc Dionne , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?utf-8?Q?S=C3=A1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 00/32] Introduce flexible array struct memcpy() helpers MIME-Version: 1.0 Date: Thu, 12 May 2022 22:47:31 +0100 Message-ID: <899235.1652392051@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dhowells@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Kees Cook wrote: > I'm happy to also point out that the conversions (patches 5+) are actually > a net reduction in lines of code: > 49 files changed, 154 insertions(+), 244 deletions(-) That doesn't mean that it's actually code that's clearer to read. I would say that it's actually less clear. In a bunch of places, you've done something like: - e = kmalloc(...); - if (!e) + if (__mem_to_flex_dup(&e, ...)) The problem is that, to me at least, it looks like: - e = kmalloc(...); - if (kmalloc failed) + if (__mem_to_flex_dup(&e, ...) succeeded) David From xen-devel-bounces@lists.xenproject.org Fri May 13 05:53:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 05:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328228.551201 (Exim 4.92) (envelope-from ) id 1npOET-0000gW-DK; Fri, 13 May 2022 05:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328228.551201; Fri, 13 May 2022 05:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOET-0000gP-AT; Fri, 13 May 2022 05:52:57 +0000 Received: by outflank-mailman (input) for mailman id 328228; Fri, 13 May 2022 05:52:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOER-0000gC-4O; Fri, 13 May 2022 05:52:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOER-0008NR-1u; Fri, 13 May 2022 05:52:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOEQ-0007Uc-I0; Fri, 13 May 2022 05:52:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npOEQ-0005qa-HM; Fri, 13 May 2022 05:52:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6MKJ7r/sUBsmQlQbaZGfDqqPioSEjv0eSwRzmXqCdJU=; b=L3o6HuJzpDChxQ6E/D9S74KBdT op87aniFxnCZhLxVLk7uSdqlGWasQLueVudk3jpaP+rZaK7+LwB0/sL1+P9+99jYlvTTSOd+GKBYq 4HHClSXnkCTnJLRqKd9oTaYFi6ryM4Rnwl7cn1vgFSk1vHPXK8j2b6i8rClBomodaqN8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170378: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 05:52:54 +0000 flight 170378 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170378/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 975 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 06:23:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 06:23:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328237.551212 (Exim 4.92) (envelope-from ) id 1npOiM-0004Wl-TY; Fri, 13 May 2022 06:23:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328237.551212; Fri, 13 May 2022 06:23:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOiM-0004We-P5; Fri, 13 May 2022 06:23:50 +0000 Received: by outflank-mailman (input) for mailman id 328237; Fri, 13 May 2022 06:23:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npOiM-0004WY-9K for xen-devel@lists.xenproject.org; Fri, 13 May 2022 06:23:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fddd86f-d285-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 08:23:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AFFD21AA8; Fri, 13 May 2022 06:23:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0476813446; Fri, 13 May 2022 06:23:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7FUtO3P5fWLPKAAAMHmgww (envelope-from ); Fri, 13 May 2022 06:23:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fddd86f-d285-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652423028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A0cX0RgYtPBbtgtZRvjM6Se6dAAVliSC/A8Id0nvnX4=; b=FszHNnXn3w3nU5XF2bJt+yIsEtXqU9ym33+Qc2QAdqH0B9e1ej+6YmQeFfuidSLZO/OOnE VO4JxeOuABhkzCXl78s2OB19jkeT0Bh0CV+1WCWUagitmdi+iiGFZ6IS2HQRzp5cuSNh2S LRcV/UuyWJRyawHUqQv78RhxnwnN8i0= Message-ID: <49d77746-1aaf-5fdc-517f-6ffa761474ef@suse.com> Date: Fri, 13 May 2022 08:23:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain Content-Language: en-US To: Stefano Stabellini , Julien Grall Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org References: <20220505001656.395419-5-sstabellini@kernel.org> <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------jmwXDXAk90Ef0izgXojzNLDT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------jmwXDXAk90Ef0izgXojzNLDT Content-Type: multipart/mixed; boundary="------------UlvSfHvv2PHLFzr2XOTTIgp8"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , Julien Grall Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org Message-ID: <49d77746-1aaf-5fdc-517f-6ffa761474ef@suse.com> Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain References: <20220505001656.395419-5-sstabellini@kernel.org> <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> In-Reply-To: --------------UlvSfHvv2PHLFzr2XOTTIgp8 Content-Type: multipart/mixed; boundary="------------MULkMvT1GdHDFZngw0QPrfY1" --------------MULkMvT1GdHDFZngw0QPrfY1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDUuMjIgMDM6MTYsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gT24gV2Vk LCAxMSBNYXkgMjAyMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4gT24gMDUvMDUvMjAyMiAw MToxNiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+IEZyb206IEx1Y2EgTWljY2lv IDxsdWNtaWNjaW9AZ21haWwuY29tPg0KPj4+DQo+Pj4gV2hlbiB4c19pbnRyb2R1Y2VfZG9t YWluIGlzIGNhbGxlZCwgc2VuZCBvdXQgYSBub3RpZmljYXRpb24gb24gdGhlDQo+Pj4geGVu c3RvcmUgZXZlbnQgY2hhbm5lbCBzbyB0aGF0IGFueSAoZG9tMGxlc3MpIGRvbWFpbiB3YWl0 aW5nIGZvciB0aGUNCj4+PiB4ZW5zdG9yZSBpbnRlcmZhY2UgdG8gYmUgcmVhZHkgY2FuIGNv bnRpbnVlIHdpdGggdGhlIGluaXRpYWxpemF0aW9uLg0KPj4+IEJlZm9yZSBzZW5kaW5nIHRo ZSBub3RpZmljYXRpb24sIGNsZWFyIFhFTlNUT1JFX1JFQ09OTkVDVElORy4NCj4+Pg0KPj4+ IFRoZSBleHRyYSBub3RpZmljYXRpb24gaXMgaGFybWxlc3MgZm9yIGRvbWFpbnMgdGhhdCBk b24ndCByZXF1aXJlIGl0Lg0KPj4+DQo+Pj4gSW4geHNfd2lyZS5oIHVwZGF0ZSB0aGUgY29t bW1lbnQgb24gdG9wIG9mIFhFTlNUT1JFX1JFQ09OTkVDVElORyB0bw0KPj4+IGdlbmVyYWxp emUgaXRzIG1lYW5pbmcgdG8gc3VpdCB0aGUgZG9tMGxlc3MgdXNlLWNhc2UgYmV0dGVyLg0K Pj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogTHVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5j b20+DQo+Pj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0 YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4+PiBDQzogamdyb3NzQHN1c2UuY29tDQo+Pj4gQ0M6 IGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20NCj4+PiBDQzogd2xAeGVuLm9yZw0KPj4+IC0t LQ0KPj4+IElmIHlvdSBoYXZlIGJldHRlciBzdWdnZXN0aW9ucyBmb3IgdGhlIHdvcmRpbmcg aW4geHNfd2lyZS5oIHBsZWFzZQ0KPj4+IHN1Z2dlc3QhDQo+Pj4NCj4+Pg0KPj4+IENoYW5n ZXMgaW4gdjY6DQo+Pj4gLSB1c2UgWEVOU1RPUkVfQ09OTkVDVEVEIGluc3RlYWQgb2YgMHgw DQo+Pj4gLSB1cGRhdGUgeHNfd2lyZS5oDQo+Pj4NCj4+PiBDaGFuZ2VzIGluIHY1Og0KPj4+ IC0gcmVzZXQgWFNfQ09OTkVDVElPTl9TVEFURV9SRUNPTk5FQ1RJTkcgYmVmb3JlIG5vdGlm eWluZyB0aGUgZG9tVQ0KPj4+DQo+Pj4gQ2hhbmdlcyBpbiB2MjoNCj4+PiAtIGRyb3AgdGhl IG5ldyBsYXRlX2luaXQgcGFyYW1ldGVyDQo+Pj4gLS0tDQo+Pj4gICAgdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5jIHwgNCArKysrDQo+Pj4gICAgeGVuL2luY2x1ZGUvcHVi bGljL2lvL3hzX3dpcmUuaCAgIHwgMiArLQ0KPj4NCj4+IEkgYW0gbm90IGVudGlyZWx5IHN1 cmUgdGhpcyBpcyB0aGUgcmlnaHQgcGxhY2UgdG8gbWVudGlvbiBpdC4gQnV0IEkgY291bGRu J3QNCj4+IGZpbmQgYSBiZXR0ZXIgb25lLg0KPj4NCj4+IFRoZSBkb2N1bWVudGF0aW9uIChk b2NzL21pc2MveGVuc3RvcmUtbWlzYy50eHQpIHN0YXRlcyB0aGF0IHRoZSBmaWVsZCBpcyB2 YWxpZA0KPj4gd2hlbiB0aGUgc2VydmVyIGFkdmVydGlzZWQgYGBDb25uZWN0aW9uIFN0YXRl YGAuDQo+Pg0KPj4gSXMgdGhlcmUgYW55IGd1YXJhbnRlZSB0aGUgZmllbGQgd2lsbCBiZSAw IGZvciBhbnkgcHJldmlvdXMge0MsIE99eGVuc3RvcmVkDQo+PiBpbXBsZW1lbnRhdGlvbj8g SWYgbm90LCB0aGVuIEkgdGhpbmsgd2UgbmVlZCB0byBzZXQgdGhlIGZlYXR1cmUgZmxhZyBz byBMaW51eA0KPj4ga25vd3MgdGhlIGZpZWxkIGNhbiBiZSB1c2VkLg0KPj4NCj4+IElmIHll cywgdGhlbiB0aGUgZG9jdW1lbnRhdGlvbiBzaG91bGQgYmUgcmVsYXhlZCBzbyBhbiBPUyBr bm93cyBpdCBjYW4gc2FmZWx5DQo+PiB1c2UgdGhlIGZpZWxkIHdpdGhvdXQgY2hlY2tpbmcg dGhlIGZlYXR1cmUgZmxhZy4NCj4gDQo+IFRoZSB4ZW5zdG9yZSBwYWdlIGlzIGFsbG9jYXRl ZCBieSB0aGUgdG9vbHN0YWNrIHdoaWNoIHplcm9zIHRoZSBwYWdlLA0KPiAqeGVuc3RvcmVk IHdvdWxkbid0IHNldCBpdCwgc28gSSB0aGluayB3ZSBjYW4gYXNzdW1lIHRoZSBmaWVsZCBo YXMNCj4gYWx3YXlzIGJlZW4gemVyby4NCj4gDQo+IA0KPj4+IGRpZmYgLS1naXQgYS94ZW4v aW5jbHVkZS9wdWJsaWMvaW8veHNfd2lyZS5oDQo+Pj4gYi94ZW4vaW5jbHVkZS9wdWJsaWMv aW8veHNfd2lyZS5oDQo+Pj4gaW5kZXggOTUzYTAwNTBhMy4uYzFlYzdjNzNlMyAxMDA2NDQN Cj4+PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMvaW8veHNfd2lyZS5oDQo+Pj4gKysrIGIv eGVuL2luY2x1ZGUvcHVibGljL2lvL3hzX3dpcmUuaA0KPj4+IEBAIC0xNDEsNyArMTQxLDcg QEAgc3RydWN0IHhlbnN0b3JlX2RvbWFpbl9pbnRlcmZhY2Ugew0KPj4+ICAgICAgLyogVmFs aWQgdmFsdWVzIGZvciB0aGUgY29ubmVjdGlvbiBmaWVsZCAqLw0KPj4+ICAgICNkZWZpbmUg WEVOU1RPUkVfQ09OTkVDVEVEIDAgLyogdGhlIHN0ZWFkeS1zdGF0ZSAqLw0KPj4+IC0jZGVm aW5lIFhFTlNUT1JFX1JFQ09OTkVDVCAxIC8qIGd1ZXN0IGhhcyBpbml0aWF0ZWQgYSByZWNv bm5lY3QgKi8NCj4+PiArI2RlZmluZSBYRU5TVE9SRV9SRUNPTk5FQ1QgMSAvKiByZWNvbm5l Y3QgaW4gcHJvZ3Jlc3MgKi8NCj4+DQo+PiBUaGUgZGVmaW5pdGlvbiBpbiB0aGUgZG9jcyBu ZWVkcyB0byBiZSB1cGRhdGVkLg0KPiANCj4gSSB3YW50ZWQgdG8gZG8gdGhhdCBidXQgSSBh bSB2ZXJ5IHVuZmFtaWxpYXIgd2l0aCB0aGUgeGVuc3RvcmUgZG9jcy4NCj4gQ2FuIHlvdSBw b2ludCBtZSB0byB0aGUgcGxhY2Ugd2hlcmUgSSBuZWVkIHRvIGNoYW5nZSB0aGUgZGVmaW5p dGlvbj8gSQ0KPiBjYW5ub3QgZmluZCB3aGVyZSBYRU5TVE9SRV9SRUNPTk5FQ1QgaXMgZGVm aW5lZC4uLg0KPiANCg0KU2VlIGRvY3MvbWlzYy94ZW5zdG9yZS1yaW5nLnR4dA0KDQoNCkp1 ZXJnZW4NCg== --------------MULkMvT1GdHDFZngw0QPrfY1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------MULkMvT1GdHDFZngw0QPrfY1-- --------------UlvSfHvv2PHLFzr2XOTTIgp8-- --------------jmwXDXAk90Ef0izgXojzNLDT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ9+XMFAwAAAAAACgkQsN6d1ii/Ey/G vwf/c6O+aMn6dRCWjkd+mlgz9uap45W4g873jhbiDH2t97W0MDPQVuMSwmz9DDyJaEAL7HyvFFsu UBwHHktNzzCPVPHPuEiZX7PrhkLpzP4WjKLZtCX3UqsSdK/dNXP0CsXAwSMmutpZ9KipGZe3JzVz JbjC8ItPsL3cPNmh/6r272A4EEbdOunAOw1gu9EzKUEsFcPkL8vXufq7XDJyO7W/9MCYMp7P02Tb gamV9yzaq5Pgb2VCYJYBFisPabyA+NIO0dZJ3B7H6TgfGNYBwZrEEKTk538BtemYkK+Vp0khDXjg HhwAfLhryQvIwLLDgV2Sk3CWi35MbZ7nQk4WhlNmQg== =dyZy -----END PGP SIGNATURE----- --------------jmwXDXAk90Ef0izgXojzNLDT-- From xen-devel-bounces@lists.xenproject.org Fri May 13 06:55:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 06:55:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328245.551223 (Exim 4.92) (envelope-from ) id 1npPCO-0007oY-Cq; Fri, 13 May 2022 06:54:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328245.551223; Fri, 13 May 2022 06:54:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPCO-0007oR-9n; Fri, 13 May 2022 06:54:52 +0000 Received: by outflank-mailman (input) for mailman id 328245; Fri, 13 May 2022 06:54:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPCN-0007oH-Gn; Fri, 13 May 2022 06:54:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPCN-000159-EK; Fri, 13 May 2022 06:54:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPCM-00025y-Qn; Fri, 13 May 2022 06:54:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npPCM-0006Rt-QK; Fri, 13 May 2022 06:54:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xok7HpjPPEB7P/2xdDZW1SY7aUYVP2f+ZYUoWkBVmwE=; b=mlnk3e1FaJPG6Uq60zS5DwiI5i OOCBkIsET785p8EPM5QeTQWhnoXegZOzHWrI30cjnJGaJTMoSL+wO1zoNLa3AcbrAAn9u88WXRUQb rmsMOYX2frWnGWgPPtj1mqQN1tTB8pJUsFQtCY4LxwWyiP69BNVwtcXpeNaannmDlIO4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170381: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 06:54:50 +0000 flight 170381 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170381/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 976 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 07:04:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 07:04:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328255.551237 (Exim 4.92) (envelope-from ) id 1npPM3-0000xG-Db; Fri, 13 May 2022 07:04:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328255.551237; Fri, 13 May 2022 07:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPM3-0000x9-Au; Fri, 13 May 2022 07:04:51 +0000 Received: by outflank-mailman (input) for mailman id 328255; Fri, 13 May 2022 07:04:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPM1-0000x3-VM for xen-devel@lists.xenproject.org; Fri, 13 May 2022 07:04:49 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f901c16c-d28a-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 09:04:48 +0200 (CEST) Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 03:04:46 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB2492.namprd03.prod.outlook.com (2603:10b6:3:79::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 07:04:43 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 07:04:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f901c16c-d28a-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652425489; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=EQPNm6oizKUTl/Nk/M01c1cy7Kwjr+OT4Va+ySoxXe0=; b=V0LwpWpujYkrkjL15CHU3W9f9strJz3PLFSBcHtaWGf5hmM1T1a5lFZv f5D7qUC1OfZIO5CpXQ+eiiybnaf8oC0LfYxFnM1Wug+B0QuyrDasOnox0 wgCV1FhY6uK1sRjqdhTnBDm8LYKbVjkI1F9ftHp8ym+CqfNGyO0PZqOU3 A=; X-IronPort-RemoteIP: 104.47.58.174 X-IronPort-MID: 71241815 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5qa+U6OffJKMWPrvrR3TlsFynXyQoLVcMsEvi/4bfWQNrUpx3mMCy DEaX23SPfncYzPyctF/a4nk9B5VuMLQz9VqHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Uw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl 4pTk7a/ZyYVOYKXh6daVRVKIwBmFPgTkFPHCSDXXc276WTjKiKp6dM+SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7EdaaHPmiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33yOjKm0B9Tp5o4I1wlPKlj5K7YLpG8XJfeCOdJhep0iX8 zeuE2PRR0ty2Mak4TuH+3mvnejJtSj7WYsIF/u37PNnhlCVyioUEhJQSFjTiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4FuQ77ESHzPrS6gPAX2wcFGceNJohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:MSw4Hq8rC2bRbCJukD9uk+FKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81nOdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbkidzk7hdcAoqJ/lp X525RT5c9zp/AtHNJA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71241815" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQy8KcMnT5E8hPxFStSFRmYhB0L8edNKzxLJILb51QHCb/A6cLSqSKpqD07t1mmjPaY3kV0IR5ukyOQQI0PO6ZUakNBO151OS5BJSaz4aEI4ImoODLA9jSOyOwwZroW8drF09el8slERaC1GbsZC29UTUaIndvKRWt6TLwO1l8X1rtelhdOimNlrq51eSqXPUUgC09h95ws2vvDS4Fj3lyFCFQ6fhsR12L1w2zyaKb5wCmitkZtOoWHe9BKsZK4lhySj6pla8Eq8hVmvbIRwUcAiTZHA5en9OIxpXTX2BeXbG/7lBmK9aCrTY6Vbhit+zV7m6ig19saiUL4mW/rqeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tKEi1H2M7gd0WpbJ4Wgq1vXG/vUa0Ajvvk3f4N6sCw8=; b=Nb3jQmK03+7aVsTY/x3ZqIRqaLF654EKoHThvSDvx6aIX0gSmO92aBr9DCQQzBPYtb01ZTX99aUHT8fEZq5oa90sms5lTK49mnNynXC4tpOlRq+/Q/pK5HFFcUbPyHrhS8Wdf9ENE9rdbDnFzcfK92K/GfaW6nslIm1ZdlhSGQBU21YdPvOn8aIg5v/LT2Y2xePU0q2MnuKMfn+VOy1SXIpUOQsKeJcacsL59IeRqkKIx20IHrzdzQnTFu/zrbZLes1f5gn0NaQZrr4a0NjVXgjxcSNrNdQtdzh/gv9pxcLRaGxGYX4ih+nv6I1+JtcH87YZtRPcbYsnXNSFiLj0NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tKEi1H2M7gd0WpbJ4Wgq1vXG/vUa0Ajvvk3f4N6sCw8=; b=CnRy9yKzhUEGFOQvWqfX4YzlnPJYPsGjx5Uyl3KHizwlDdxXMtfZdeH4uYDyuffturaxiUcJVJGkSDyXzRfVmpYiZIizaWVSq0KuhmM2VvCEPZkk2XRuc/DP2ajG8EdFMheGCFTlmLkg+fUR2RJYEF9Av8iZOa/O80NBgFbHa0Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 09:04:38 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH] osstest: update Debian Buster install CD media to 10.12 Message-ID: References: <20220502151448.19578-1-roger.pau@citrix.com> <25213.7948.2636.838505@chiark.greenend.org.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25213.7948.2636.838505@chiark.greenend.org.uk> X-ClientProxiedBy: PR0P264CA0139.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0352c6a4-b1a8-4844-b3fc-08da34aedb44 X-MS-TrafficTypeDiagnostic: DM5PR03MB2492:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYfHX8jm0E3gIyb86bK8XLMcpUJG9CCnXo7rxyODKdTiU5eRhE0aJTmizE82zl0gyaR0wXkBvmCOiDYE5GhUm+RnUac8RZ8eQhooOf18TrF7w0yNQ9a2eRmR08uRDnu5H4ldnDgwcsCrpWqgI1MLt1zqq6/Vk5Navg7rKq4Wn+LqG9pSziEyBpX+oPGPhrCUD3QJ1ELY+2f5ru6+7o5dOktg6CxBQ92SeZYfcnh0FGWeF0hisOlpkGnO4JBeldIU1n67hxmXt9qZXjpWDlg75V7tMvRDi+WlfdRS9ZhGqy1WZDW1WWmMHw56ODxlXuOL8aFmC7Mch6KLfSmnsEXam0EHuXN1193JkhAH4EusSqLWt9q1qwaiMpPFv//eYVy/Yi2bD4JCBtgkkYYprdjU/XAFkFm4H1NC9Q6VymN7K5sLr8MBGEyA5ViVLE0JP3HRl3eWDx1crDtJ0uhFfmz459gw1byDD2OfKAIVmyPeK4SahSLC8HrgiZO+Bwwwh0aN7gxQcp9hbIilWPn3vCICMW5SK9iLo+b+xVEbJJkk9p7Zb5cQccWjG6ZvC2LrhPJMlx3CKU5CsSHKFB8VPkifcyFtrWF7GeUdPfbRYdFT1TIJ3HNJrLHaK4Lhp8XNn3ZNCC9h7yxNo1C5hAtNy5aG3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(6666004)(6506007)(83380400001)(6916009)(316002)(66946007)(9686003)(6512007)(26005)(66556008)(85182001)(4326008)(8676002)(66476007)(82960400001)(5660300002)(38100700002)(8936002)(186003)(33716001)(6486002)(15650500001)(508600001)(4744005)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anNRMytBTXB1OEFRMHZid3hKMlVYV0pyUUZiTENKWlordE1VMHdMdUNBZHNm?= =?utf-8?B?cmlaMTE0MXhoMlJrTnZBOUFiTXVBQzVoWXVkVVM2RUQyZGJNWHB4enVvY2Vt?= =?utf-8?B?WGJhNElMSGxJdlRmMy9VcGVyQ1NOdVhhUW1pNmROWGgwSys2QUh2TnJWUUNE?= =?utf-8?B?M2RZTVoyWmxFbm1WODVJMWpEaVBiS2o0RytNeXRIMWRYNzVZTWpaK0ttK0I2?= =?utf-8?B?a0RYOEl1WldPRW9kSVZoZzNQYlNselgvOGI3OUEvMDkvT3hhanVBOGRlZjZP?= =?utf-8?B?VUduMUN0MEFpU0VGRXdhWGUwNU5HWUtvU1NIVzFEREtNVWdHdlMxaVpSK2Ry?= =?utf-8?B?U2JqUXhMVlhzQzNwNW1qU2RLTllaVjdLWnZ6N0lHM09qL3J2aDlwQ0dRV0pB?= =?utf-8?B?T1h4TkgveHFjWlBFSk8yWnhIMnhPTGZ3RXVLR2NValROUmVrMXRua3A1QktQ?= =?utf-8?B?YVMwNnNZMnJHaHNDcEFKdGRlbkJhcGt0S01WL3BtN2svNk5XWFB3TzV5Ky8z?= =?utf-8?B?bS9senBLL0laWGJFYlJRblhXZktuVG9ZTzdSc05XcG9kaXdPZUduVUlXejl2?= =?utf-8?B?SGt6N0RiWXp5UlVOZUMxcWt2T0U1NHpRZVViTW9JcC9NblNRcHVzMVcydDhS?= =?utf-8?B?aVY2WTRXSDZTVVQwemc0WU9zcUdkOElTNGNmWmpaOXpRTm9rL2ljVDJtRG1L?= =?utf-8?B?WjBFZm41U0xaek1Sd1gzZVhmOTJHL1pSb3FMY3g2dm5OMlNXRTR4dEZVMXFP?= =?utf-8?B?cWtIRmt0Q0hQK0V4ZUdhNU5DNXN2TTYzOVV4N0lVMHNUWmpGcE1QWW1IOHlZ?= =?utf-8?B?SE1UUXZHUVFpdFM2V0dTUjk5MkR2V2ZmY0J4Ky96OVA2R3JoWGwwNHZCOVZH?= =?utf-8?B?WkVnd0FpbG9vNGFBVExBN1NneUFsZCtaUTBTMUowdGxZc3E3aGJXMExhSHAr?= =?utf-8?B?L1pkUVNIb001bW9RZkkycE9TSkMyYXRrYWdkNlhEVjJVZC9CSEJqeXdhRWtP?= =?utf-8?B?M1NsejlpQ2p1dFFqRGdkMnYzK3o1WStSMTB5ek1UakIxZm1HK0tDdXlYM2hh?= =?utf-8?B?NEJrUXAzNjJFek5HVzhMQkJycnhRaDJTMzZtMUZWSUdDVmpQNGlIRTk3dlYz?= =?utf-8?B?NkYyYTNLTW11dTVUdUo5WitXdVRrbDhhOXpXTzhEQlczZVgzcnpjTnV4SEE4?= =?utf-8?B?YTdwRDdtdGlUZTU1ZFN1VUd4dUFEOEdqKzY5QVYvVEE2MWEwU3JVc083WGRB?= =?utf-8?B?SnBPSVVRcHJDQ2lQN0pzUXk0UGJ3WDUxSDN1cnZTaHNzdGFKZ3RPS2F0ODdM?= =?utf-8?B?MHBIRVVaOThzRlM5c0F2Z2ZVSWJkbkZDeFZqQU1hM3ZidmxkSnhadFZacTdw?= =?utf-8?B?MkNhcTJsWStLT3ZUMTNnUXEwT3p0eGJHU085blB1cTBsY2ZqaWtOZVNXZWdK?= =?utf-8?B?WnM1M0dTNk0yTCs1V1ZQRWhTQ1poTDlrRk9pMXZnYUVib2w4dU03QXYzYkYw?= =?utf-8?B?dFZZcnhTZW9NbHozS00xc1pBK2hlYWtXMmd4S1I2Tmhsemw2TW5KT1pEeGlN?= =?utf-8?B?ZlZwSDM4emdjNk5wQkxpWFhDNG9vKzNucldtbEk2UFh6aGJ2UU83aE9GM3VD?= =?utf-8?B?Y2hsdmJEZXdQb2hQOG14ZW9YVWRhbnYvTmsyUEV4U1FjSEFZS3MyMFV2UnFx?= =?utf-8?B?TlJPL3A3Mm5jekUrdkNqUWptcUEvalgzTEpmcGpIdE1oakxJakRCbkkvbEI2?= =?utf-8?B?L0hsTVRjTDBScTRLYnc2ZFRGcFpCNDltczRqejJjT1ViKzluVWdtMStsVnl4?= =?utf-8?B?WmdhTCs3YkN5SXdTWXdocGVCa1U5S1J6aDZxUVovRVZEdkFYSkxtN0xyUmkx?= =?utf-8?B?dXJqYWRZdXRFNlZqeExkUTMzbVNDM0pqOG1sL2lhdkRERFFqVkozOFgwS1M0?= =?utf-8?B?enRZZVFRVzhYbDFkRkFxMVBKOVdLK0lTTGFTb1VlTFMrVUU5SVFSUmU5aDNK?= =?utf-8?B?SmtzNWt2NmlTL1RrbXJFSldpajd6cG90bVJZOStyWVowb2w3eW1JdlVkTE10?= =?utf-8?B?ZDhkZnNhWWMwa0VZbjNTbCsxNHhhNFBMTXo2bFpmMWxVNU5SaWo2dGRqTVZQ?= =?utf-8?B?aTltd1l4NkU3WjZhK0FZYXdNdG9DZDBqT2t3aXlGR3VhK2lQZ21YMUJGVDVu?= =?utf-8?B?dTRCb2c0cUNmV251TUV4SjVENk1CQmpkR2Vxc0JYNFUzam5tTDNBa0NKNnBa?= =?utf-8?B?TURRU2xIdDJYY011VXkwc0QyYk9YYU83Q1h0aDlKSU1tT2ROM3VnWXM3dUZR?= =?utf-8?B?cmFsMUJwSitOSVFEOTZ6ZDBZK0Y1R0NSNmdKTGxGMitCSzM4WlpRamtxdE9K?= =?utf-8?Q?rRhk812toNEXrDzc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0352c6a4-b1a8-4844-b3fc-08da34aedb44 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 07:04:43.5887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SYP0g1ulDkiXT/OTu6ilFyxKxIi4VuE2fLzNxqgF5OfxV6zHeujL/bhfTA9zMVYSPxlE5kg1haQSDKHAl2VaOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2492 On Thu, May 12, 2022 at 03:51:56PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH] osstest: update Debian Buster install CD media to 10.12"): > > Signed-off-by: Roger Pau Monné > > Acked-by: Ian Jackson > > Is this just a routine update, OOI, or was this to fix something ? Mostly an update. We have also noticed that in the i386 HVM installs sometimes a softlockup happens, so an update might help with that. It's a heisenbug so it's early to know whether the update did fix it (it didn't happen on my test run FWIW). Thanks. From xen-devel-bounces@lists.xenproject.org Fri May 13 07:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 07:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328262.551248 (Exim 4.92) (envelope-from ) id 1npPXh-0002QO-Ge; Fri, 13 May 2022 07:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328262.551248; Fri, 13 May 2022 07:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPXh-0002QH-De; Fri, 13 May 2022 07:16:53 +0000 Received: by outflank-mailman (input) for mailman id 328262; Fri, 13 May 2022 07:16:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npPXg-0002QB-7j for xen-devel@lists.xenproject.org; Fri, 13 May 2022 07:16:52 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a53f42db-d28c-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 09:16:46 +0200 (CEST) Received: from mail-dm3nam07lp2042.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 03:16:45 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3255.namprd03.prod.outlook.com (2603:10b6:910:52::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 07:16:42 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 07:16:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a53f42db-d28c-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652426207; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=HFBCv2S4qTFBxh/5Pr3a+8f1SLwkTrn1oEDpempuNMo=; b=heohL7ZsALNKXHI9CepJJnpll+yNl8lh9Op/YtAjwR/teNPST4OCCkiN weozarngpcrEtc7oNadt08hAt7EaZQZoYwT7p5q8j78Hfp8wyqTyRW2kX +ykjHObm9juF0Agu0S0IUbRE8QXyG0r7j7Yb9ydheoALcR3PNSlfcMMdo k=; X-IronPort-RemoteIP: 104.47.56.42 X-IronPort-MID: 71242393 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/W1VEa37lqrFBLySSPbD5dBwkn2cJEfYwER7XKvMYLTBsI5bp2EDn GAbC2qOb/uMNzake9EgbN+28BsDsZLWnIRqSQNkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx2oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1TqYeqGFguYZfuo8YwDxJUFi5QFolZreqvzXiX6aR/zmXgWl60mbBCKRpzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfmQjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SClL2cD+Qn9Sawf23X5xlYg6+PUbNvYJuC4S+MIwleku TeTl4j+KlRAXDCF8hKH+3SgnP7Sngv0XYsTEPuz8fsCqFia3GkaEhAVfVq9v/iii0S6Vs5fK kob4S4np+4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZ8hMcOscY3QXkm0 wSPltaxWjh36uXJEzSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa38716bnC43TEYj7vg+R IronPort-HdrOrdr: A9a23:KZghRaNpXdS5VcBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71242393" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QV1FLqJuzDoYwJYNKC/5Pb1ADFGvHzLsvdTvi5I/aCsru8gOkf2R64qZyDa6KF/aXYcL3U+qg1mxd+uyKm+bcSFelZy5DPzKNg0TpuDHG26FXAma2J9IKvR9jSqmN+M/35J+9fx3/Benn3/c+PjmQKa3aBZ2SaAgfzJ1wN+AYlaiFNtzIUXGSY5zxthWYJo2V8GDxE09VHCvyi8XJhAWq9jn/iGSpVTWUYafrVeul8LAug/zk+o3ugF7M+jKHaO6Y0IBg8O8uy3otZECt9cl3WHWiN7Fq2CUODT37RST3GPPcQdfBoOmTaKgMeOKf++UWvMxD0GRGiLfLhm7j2Sw9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hf3/xI4Pt3/c5egEe6YQeYzCjH5jxWKoUrzg3RsDyd0=; b=VSXmucSNr7s6RFQKau88XtSM1iNPe6K2Xca8DfUExavAnDMojvha55pyEDyQTf5fxpgLgutZ6Jx8HUoAw469Hw0uk4m+YYDfwg0YvA7wF2gEjHX35FE74DirRJbi///2JccUafq9t/uLrLZGh82B5O5rOxfvDpb6UsoVz+/1PuVayZjJazYjQJ46mCenszpxlVJ/eBYjA1yNw5l3Dy3mIFkTJTDQqD634FEywHHzQgJ/enHnhjkIXJ+2qiNNj3nSLrTxze7FEw0W2pZ9yLhKR+9ZpKnjGOi25yFc886H/YsENLPO0TQxgZd1+y29jb7VvSw4gVxNpRloEZEAMhzz7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hf3/xI4Pt3/c5egEe6YQeYzCjH5jxWKoUrzg3RsDyd0=; b=WUOkYAmIrCjd33hdgSqMhFsYwyD6+6ISGxoZ38hvxNrLpGADh6ewTKa07EMk8Km6V0oYxi5+u1+bUqNyf97I0SG2e1pXbcX6ejmg9zZ6gwUZvHgpCMPFwBh850PWutLlR/s3s0Q+ULICCH3JlYOX7Nnlbp+ZXM2XPwr8mIlGHdE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 09:16:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jason Andryuk Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel Subject: Re: xen-blkfront crash on xl block-detach of not fully attached device Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0153.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:54::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86bdfd31-a176-479b-fabd-08da34b087bc X-MS-TrafficTypeDiagnostic: CY4PR03MB3255:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SXbMh9Xeh7cm72CWQ2B5L+S0eMNMcNj4UMpuXp2emBukh8kfqhIXXMPKD/BW4REXUX9JIJAphvhPw52KbH5b/VZAf+IjArG2I6qjZkVOXHTXTHAALl06J9mom8oIAy9SrtN1rIgDVVsoJQMxg5uHGj0iE6a4fjTv1iDZ3JS+4A280C3xHI8PKjqVnLe+F+IivSdi3yB4+cu/9hCMwoBIhsXZuwcNTCDNoKlQL+Fx3T9vYHDJAfe182WDXvWSpBk4E2MDeBlzwtdofh19H/g5KKlhy5YQbJrKk2VUHab8Er5XlrGT6pxRN3Tsxgq48RTCB/OckfmIsSp9S23O/HJB4rNhRI+3cR6LQoEmIUvErj/LQKmEIvVc5TH7M/nXbsXeTMYiG1uZa/E/pGakgXw7w9YAAu3ehtgq3oUXYxvlYP9fkehEOInoMdoHWqhKcDOmQ3j+vpqN4W8gXos4X0f6dIdlAewLLlEzjFO+wahi+AFRk4qJ4b0x1Pz/YTnonCM5HO6PAB61p8iOdDOq0FBzcsFLMrEoqIv6QpxkMKr1+c4/ejWGR5/Tzaj3hXh8EQs66GkQlKfVqeIFDUmwEitHZRxvElzzKit8r2rmIaLc4JzREQenPiR3tPKmoFdqJ8/XYQqea/W+Wkroqj/Wtz7R+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(6666004)(186003)(6506007)(508600001)(5660300002)(66476007)(2906002)(4744005)(82960400001)(38100700002)(86362001)(85182001)(6916009)(66556008)(4326008)(8676002)(54906003)(33716001)(316002)(53546011)(66946007)(8936002)(26005)(9686003)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3lvVmhpckhQZm5FdVY2bTl4UmliSWtpNjdEL29MVHRxeHRuWUZmTG5sMzU4?= =?utf-8?B?eWdWb01sbEk2T2hiWENIc3k4eGdLSkZBN3EyTkhzSXlLQXRYcStWZ25Ed0Zx?= =?utf-8?B?M3ZlNURYRGlIL3VDdUQvOWhFalY0eU9KTjQ0RTREV1Z3UFoyckNmNGMwcGkw?= =?utf-8?B?NXNvTU9Qc1NRSFdSdHRmUzhaUWpWNUdtdmdFdGkxbmR1cmIvUk1STWs2VWds?= =?utf-8?B?dkV6MURwa1N0YXhWekNYQU51WnI5S3RpWHl5Rmc1MHE2aE5KY2xRc1h3T1kw?= =?utf-8?B?WXpvWDFTcmJMMXNib2JPZkVvcVF5R09TMTZxTXM4aUZzeUVDWGE4Y2hvS2tq?= =?utf-8?B?dkNuWjBUM0pnRXpNL3EyUVAzQzJMRTBEVHBqdVBxWmMxQit5QTVnYVQyRE1Z?= =?utf-8?B?Z2xjdzI3d2lsb0lYcE1ySy9JdStKNHUvenJXOFpXZm1QZnFuZERkSGIrMTkr?= =?utf-8?B?d05Gb0tmNXI4d0MzZnJmdHlBWmQrZmxTeU1sbmhjVUFVNzEzSGNRQ1BGNks2?= =?utf-8?B?RmdNQ1VSUk9PMjQxdjNqUlY0UTBMZjRKWHhJMW9FRW1QUEdwNDZQSkJKcnR1?= =?utf-8?B?aldERE5taGpxb0FYWUtyUjU5SXFra0VsZ293ODRuaWk3ekU0QnoyaUNpamVM?= =?utf-8?B?RGthbS9YQWh5OWc5SjJ0U1NMVkNzRXNMSTVZbkYzOUNRWERLZitwLy9QSTdW?= =?utf-8?B?UjJHR255M1JmRU5ydmZEMmloSUdJdjB0VE5tRFBoQjZVdjJnWkZQQkUzVFJl?= =?utf-8?B?WEhjM29qM0ZJWjJDUkRKaHJrTzBDb0NncENxbStLRjc4Sk1jQVMwUUVMQW8r?= =?utf-8?B?RCtiNXpiOW02citYMCs0Ym5oa3Y1RDRFWUpHOWZNZXN0MG5LdzRQWVFWYmJl?= =?utf-8?B?d1hpTlRjOGFnVS9lS1lVaDhsVkl2Z0xhVmw4aFdMNVFtVlVlQVFtUjlOYkV5?= =?utf-8?B?NTJWL0MxWGlzU1dNalEwOFZna2xsR2FDZmcza3BXelhMenFSZ0hvMEN4MTdu?= =?utf-8?B?VEVMUWFYeTAwaEVnMUl5dVBmZExnOVM2eUNUWUVlWkt1b294SFFmM3l1Z2ND?= =?utf-8?B?ekZ2U3RleWpCTHBsUFJtSFJUUzVDTHM5WEU0T29mUWNlNk84MTJ2WEI1VkJh?= =?utf-8?B?Y3JtOXN3OTJTeHowUC9sQ2p0VjJNa0ljamNQWXpmbUt6SVBUOE8yK09uSzJZ?= =?utf-8?B?Nno2eTE4ekwrSHc1MXQ4dG5XaUloYkhpcWd4OUVvTktNWVZiK04zajRJZU1W?= =?utf-8?B?TG1TS0xkOEszQXJSelF3aUlCblFrZXk3czVkR0xIVkNJT2h6MkYzVjdLdkZ6?= =?utf-8?B?V0toQlNKNFlDUjVyWmk2d1FjRk9xek0zMjJyZ2JFK2VaL0hncWRnVENxdjVQ?= =?utf-8?B?R0JhY3NSd3VqVURGSWY3V2czVTlSTmJBNEhIN1FFdXVEL0tneWNQZ25mZ2lu?= =?utf-8?B?NXpscEV0WXNIMzM3YnFYaDYwUXJCNWlsem9xZTJIc2g3Nnd6KzBmMG1lUVRD?= =?utf-8?B?aHFCaXRyQjVaUGNBWFpqQ0NOemtkWXNXbyt5SHRJYUNQbys1VzF6U3F5KzRr?= =?utf-8?B?bGs5ejB2OVhhRk1EYlNSRC9PZHpSS0cwR3JhTzJpTzQ2ZS9oc3RWaW5qU0xN?= =?utf-8?B?ZzFRbm5TVFdnM08yL2l0T0hwVHdHWE5LbThxK2dHY29BTnNTTk1Cd0RiM0Yw?= =?utf-8?B?Qm9HQUx2bmx1aUoyc0pUbk93ZEtuOTdXa1h4bWF2ZHFFTE9KSkdLYjJOc3Qx?= =?utf-8?B?Zk4wbGRnVnA3MkRSaDAvK2RaRkN1MG5CYXhBem14eW9KMFFWSFhiNFhkdkpn?= =?utf-8?B?ejd5YjFxRVNQL3ZGWDdORXE1eUE0SEdQVUx2Z3FzVVdzQ3FUUUxSc3h2M0Qr?= =?utf-8?B?QlB4R2NseVUvRzlncHd5QU1zY2hVU0hSZkpPVDA5UGxiT3VyeTVQNmwwYWxz?= =?utf-8?B?Mmc5TGlDWldKbFlmTE5oR3Q0bGlyN3g5TlZ2dWZmMDJENm5Cb0w3MmNhTXc0?= =?utf-8?B?SGtDUGZCK1FESzl5UFk5QTNwbmVYR05tYWFCOEt6SldOUWZSeXFySlE0MzB5?= =?utf-8?B?c0UvRy9iMzRBQjQzTmUzb1M1NnJYVDEzTFpobUZCY1pEcEQ0dHBBZjMralp4?= =?utf-8?B?Z1pXaWMxbFFZbHlQWTliMlMvZGJkcUZTb3Z1TXRMcHBKK3UvbkNZVDNIQWtv?= =?utf-8?B?YUN0cnRwSFJGd0ZKNUp4blBKS0pycFNYNHhaazVHZGFnNmZpQ3NreE5yRUd0?= =?utf-8?B?VjNGN2Z1L2ZTeURIQkNNSFNVTkV1RVU4eGJjM3R2d2Q3OER1aDQ0eGdCdlBa?= =?utf-8?B?NVd2b1dRc2tmNHYxbWZKTzJDSnlmTk5yVW1EOXh1am55MkVYbko3cnBUSTJQ?= =?utf-8?Q?8Hf8IaqiTloUylCA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86bdfd31-a176-479b-fabd-08da34b087bc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 07:16:42.3793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yb38XC1oTOUGFclMBW1T8DXZ6fQJ4NO4I3H+SKKvVBieg5LuGvZiUMiXx8o56o0xDlmGOPRUpwI8QWM8qru08g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3255 On Thu, May 12, 2022 at 03:18:05PM -0400, Jason Andryuk wrote: > On Thu, May 12, 2022 at 9:59 AM Roger Pau Monné wrote: > > Care to send a patch? :) > > I will, but because of $reasons, it won't be out until next week. That's fine, I don't think we are on a rush :). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 07:50:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 07:50:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328270.551259 (Exim 4.92) (envelope-from ) id 1npQ3n-00061O-CB; Fri, 13 May 2022 07:50:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328270.551259; Fri, 13 May 2022 07:50:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQ3n-00060b-6l; Fri, 13 May 2022 07:50:03 +0000 Received: by outflank-mailman (input) for mailman id 328270; Fri, 13 May 2022 07:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQ0z-0005hw-IM for xen-devel@lists.xenproject.org; Fri, 13 May 2022 07:47:09 +0000 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0b30c60-d290-11ec-8fc4-03012f2f19d4; Fri, 13 May 2022 09:46:37 +0200 (CEST) Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 May 2022 00:47:05 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 13 May 2022 00:47:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Fri, 13 May 2022 00:47:02 -0700 Received: from PH0PR11MB5160.namprd11.prod.outlook.com (2603:10b6:510:3e::8) by MWHPR11MB1504.namprd11.prod.outlook.com (2603:10b6:301:c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Fri, 13 May 2022 07:47:01 +0000 Received: from PH0PR11MB5160.namprd11.prod.outlook.com ([fe80::d10f:cc33:cfd8:365e]) by PH0PR11MB5160.namprd11.prod.outlook.com ([fe80::d10f:cc33:cfd8:365e%8]) with mapi id 15.20.5250.014; Fri, 13 May 2022 07:47:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0b30c60-d290-11ec-8fc4-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1652428028; x=1683964028; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Ha+S6QZVIMC4KSypJ/PoMugEFPcY4uAaecmyl3QehRE=; b=Mw9+j7Q3ecpebeXZRdw2OcZOPQ0hAvmL2Hdja9OrBdnP3WIudYUsbX7l 1xO1QRb0533pZHfFVBgRNeB3CE6dSzSXQLJHJfHdZcALA8QdYYuHIYmOX Ge/fjVkZF7n0JbnBcXu7fo+ypwAvFtchp63aenhVuRj7hm0F9IIVcGZGL cs8uQGIHfdERQk9lIXMkQaaA9RlPuu0qTs4YwVqz22+ZZwQYvh7DEvwC2 hmW3mwXo1GxQLWnc0DuhJ5wwCjMogmDbqlvuwdDwnSdb2elhdTJgXFHqI 3xGdR8uGH+BkbYBPsWBHP8kj3tDTUzPBTIeTZ7axzhfjtq0XvaSAM9Uq4 Q==; X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="163534454" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eCSjzpcS7HAsXPeUb9rGftPkxaxgATsJTcdPytMHEwDvJV+p8FgApLw7dvx6mHcznm63jaEyGbebgfj53NtI8lUPuhewxHPrs7206PXcS+Lrab6Ev/Z6MjAxORfjMFBA3ZycEfAd086Q19Mv8HZrYKyppycdmIx5roTjDsA2HK54TGX3HSM3chtGp9Xq3qgqdoDLrVDTd9nAnEGgZHNlsreaJSBFADKS3izSHS/8UOy+CWTNaAIOK9vy4Qb8bq430kBlOgqpzit/Shxv1SuIqRXorydl0PX9tzX2vOAScWE4sz/C1xqqFpvVX+9+gffPkk9huuy22KTmw/6GsgGszg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ha+S6QZVIMC4KSypJ/PoMugEFPcY4uAaecmyl3QehRE=; b=dihUw7QjXxmKxTt3HaIElDL9gmtBA60lo5HGdMv2eGOrw51mIEzZRMiMSmaX/AHK5YabqPUOnuu8vJEDOW/cDu4RTZo00HUmOQp/5zkaaJ99EZUMz/qPT8UGlKY523u8wFx6HoErR4BrkOVO7qhtnAPQWfT4sAVAWL8IdfeKzZChsnigaDs+lS1qYFn9q4ZrsQw75opf5yNPrExDiZAS0Ia6ylvsS+h21l2z617PMM4syhmH57zBgl/XPTeq1sWnbYw9oSJAfhMSIvajjayyGh7w0RGoUPIbfK09//xAR4jqsiTzgPqWAdbtnmHS/8rvtlyIdtG9E1Dc2iFSnchsWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ha+S6QZVIMC4KSypJ/PoMugEFPcY4uAaecmyl3QehRE=; b=n2ip1RhKOgPZlSSfev4XQh2g97AdywLdzsxr0lJ2xpdoXRO4p1Bs0ZKSMjs3kg+hmrtr3xh84eMJ2sYx/DMvJOMgZ0+3nLO1UBL8I06RHOc5O04WI/uJF6Q8/b6iL4ZRlwSSMaNyyb4uO/oLpAMQaehU065CYYAAVPP+DwDsC2E= From: To: , CC: , , Subject: Re: [PATCH 1/3] swiotlb: don't panic when the swiotlb buffer can't be allocated Thread-Topic: [PATCH 1/3] swiotlb: don't panic when the swiotlb buffer can't be allocated Thread-Index: AQHYZTbP/7RHBCbSm02P2TeeL38cb60ccGmA Date: Fri, 13 May 2022 07:47:01 +0000 Message-ID: <9ca9706e-7781-12a1-c4c7-ce3d27902ce2@microchip.com> References: <20220511125805.1377025-1-hch@lst.de> <20220511125805.1377025-2-hch@lst.de> In-Reply-To: <20220511125805.1377025-2-hch@lst.de> Accept-Language: en-IE, en-US Content-Language: en-IE X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13c3d6a7-e62a-4867-068d-08da34b4c3eb x-ms-traffictypediagnostic: MWHPR11MB1504:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LecszsyFTaId80FXtvUrykf6w9quKIjHzgsTVYOGvbfUpER40hQb9KlEpb0J3qv4fZgfBIDEn7iP82TnXv09Ayk82r9Cbp8eedTkIM/FpquneGJiFROquTRK0A70bbeCRyaRR++4SE36SXVxUxDn+jEhMTIdqo1pYn4cdGbAuELGskl1Ex2Rd6t9rHF+MgrAN76RbYmEUYVZWlws9RQKZzPBTo02MX3ZlEKUUXJykPT0/r07StdOiMkEqTzfykit85dpo5qs/HGBI460/v+dEgpAnJbvoIw18XqJoRILUzpWTBbOpzqOR9k7MXAl0BnosVdQqEWaQPRm6sijLQhaJIT1NGcS35B8xsCjyjkNk1FHav7v+KamRp7KPIVYCiUnZtaNg6ulv/ytAHL6YaxgnZ+6UrFgHLQguAkZ6APQDq48jmLscVQ50iR8ZwYZKjOZtDv2s3CiAHX1ZnoQQ1MxBEnDmvUKVmSBiRXKbx9VRwtDV75wC91YcnG/07Q0z0c394dCq0W0nYBfGxfuDg+sAzN4zM1fKQj9wjm+Tc8tWWYkH6QIV4k6fT4bj05Efsw8I3iF0xRXL0U2ywKii5AB4SZPjUvlSRaParVL1VJhAcuh6AYExQZL/f/pmmpzlBAkjOl1MPv+THYV+hRJVY7VElrrVkpFHIEGzNijGophuXWUPra6S2peejIMzqMXwuhVFT8JoYcg48duRV5Py24Ry0mEqtJMuczEmXO9s9j6b0ii9yfho/1+wlesm5HdFoIVbL5FRaUrkz0ZP9QYdAaDYg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5160.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(91956017)(54906003)(2616005)(71200400001)(36756003)(110136005)(6506007)(6486002)(316002)(26005)(6512007)(76116006)(83380400001)(8676002)(4326008)(66946007)(64756008)(31686004)(66556008)(186003)(66476007)(66446008)(508600001)(53546011)(86362001)(2906002)(122000001)(31696002)(38070700005)(5660300002)(8936002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Nm9xdm15UTQrU3ZLcFhkVkUrOVM0Sko0MG5EVEtGMlRJbHNhRXVWcWRud3FR?= =?utf-8?B?Mm9qcExHNTIyQjM3YVZqb0tvck9BNEpJMkpYUGtFMUI1K1RTcG5WMGZWSEwx?= =?utf-8?B?UTlkNm1iK1pKdnpubnpDdytNTFBvRVF1VGRNSmxLYlJWb0pKNmFSV1FxbjBl?= =?utf-8?B?bEhMQ25qOVN3QnpnNnNXN2E3RUUzdFFnZEpNR0lvWUhHKzRSWUhERTlZcHVq?= =?utf-8?B?dzNJMFcvMEFMSm5tWXhqVHR0bkhkWGp3N3Y1MkdESVZudkREeEVyOXMvT2pl?= =?utf-8?B?OHNQai9sT0dqMDFxdHgwMGhwT2RXR3JBNGV5UDluaWgycVlwNkt3NkVySEtk?= =?utf-8?B?aU9UbEFXbU9PcDJnUjgwek5ZVUxFQkNybXo1Zm8rajRCR28zYzVzNVV6UStP?= =?utf-8?B?L21mdS9ITHZUa2hXYVBiOHczN0kyUFNUVUVnRzB0MnVYQ2htTHE2cUlQdk1U?= =?utf-8?B?ZGpsaEgzSDFwVG92M1B5REF3dVhCZER1SitUakZHYmU2YXgzVThQWEtQOUlj?= =?utf-8?B?QW4rY1dVa0NMWUlZZ3N5SW5kU2Z2MjBZOTFnQnU0cHMydW9jWjYzVEFsSXZK?= =?utf-8?B?T2laamROL3VqandHa0U2VFR2WmxweHk2ZmNnQUVoelhoTy80VXE1RGJ3c2hX?= =?utf-8?B?Znd4SllYc1QvZTgvZEVZWXRjN0UyQkpabzFPTlpHaE81MlhpYkV2dklaTlZy?= =?utf-8?B?bmd0NktIWTdyZlpIU2ZuZGZLQmR6WkRTMGN5NEoyS2dOZWxJTXZBekNhK1dY?= =?utf-8?B?cjR0OFVsSkRCTCtnZGVSUU9zdWUza1c4a3hSeU5VVjJrSVdETnBsclBWeUFP?= =?utf-8?B?Rnl0SFRoaUNPZWZ4VW5lTENSeU1QQm9QR25hTmJKSjdLNVoxZGdoNitubVZ2?= =?utf-8?B?eDV2eHpPZnRSaWwrS3ZNRDJ4cHRWZUlTdUNCeThOWHBONUtyb0VpTE1iczFQ?= =?utf-8?B?WURXSGVBa3F0dlpaekd1d1JxSkwrYzVKWUhSUGY4Q2tCT3VxNkZySlp2dmta?= =?utf-8?B?RDNzYzBwZ1JDQWVXWmhNeGpWc21pNjVrN01oNSsyQzN2YW91Q0ViVjRmL3ZU?= =?utf-8?B?TUMwcmx6d2I5NFhudkxrWGZiUHRqZDQ5S1dLQU40Zi8zUmJaczNPck02aDhz?= =?utf-8?B?RFIzcG5GV0kyQW9mN3pieUE2R1JZb2pGOFlRSEh4RnY0OWVkcVZjU2xzTlNr?= =?utf-8?B?UGhhV2wvdkRtbGdVZzdxSjlwK3ZoaHRKbDg3UWV1OXkxemgySkZyb3VHUm9m?= =?utf-8?B?VEJsemNMZ05TUHVQSHpKTysxeTJkaVVwMTNkSTJQNWVEdmV5ZUE1NHNqMFQy?= =?utf-8?B?WkdxY2p0SVJtNmFzT3V3cGZ3bkNNZXJuRUR0SlBxc24yREVKYlBHRTJ3c0Rz?= =?utf-8?B?SDcxWWdaQ1FvUERIU2xZM2dGb25zaFRjMTdHMDMrcVYwcEI4R0RkY0x2anNh?= =?utf-8?B?R1NyQmJRVFpKL1FrOEQ4aTRDOVJwUXdqYjV4UDlwbnBiYmlHcE14Ym9vRmU3?= =?utf-8?B?NGNHSjFQR3pLdnZiWjJRMTdSeURQU21TUDMwV0JnNHVzclB2Z2JRemUxRnl4?= =?utf-8?B?RHdIbWI0N3dZQ3VBVlFNUkZDaS9oZWlVV21NWTJ2Z2JWWk83OTRaMjFYQUps?= =?utf-8?B?SDFhRURhdmZjeDdkU1lwTFFSZ0pPZGtEWCtZZHNYRGhFZG02ZjFCREZMQ1BF?= =?utf-8?B?VmJNdmowc0gyR1lTbkJXSkcrbXArbHh0Yks3QzExZGt4d3paQlArZnBqMWNV?= =?utf-8?B?TXBNTjk0MVg2Q0ZaMFB2cnVBNWhRWUh2WW1nMkI3YWcyZ3pDL3FYb01rb2lG?= =?utf-8?B?RTZLS0lLcHNBdVlnYUV6dGJKbTBmOGFmNUFmWkFzblE1ZGVlTHRqQWwrVmwz?= =?utf-8?B?NWN0Zm8xek9McXFQdmhQZlhhVlllaHNjeVJ6U0xNY0FOYVM0aXEvOFByK0py?= =?utf-8?B?T29pNmI4aHcrUGhNTEtERWltQjZoMzFRNW4wWFQvWi9hQTRhaVlLamd4c1c5?= =?utf-8?B?Tnl2b1FCcXRaV25jMkpDNm1iMGVZWHlJZEo4bmhQZ2pVdEpmQlVmNlV4b3Ev?= =?utf-8?B?RjFnUjZjQ2dMV0FDSWxjRi9kcFJULzY4SWhxbCtJcXAyZk1XSDl2SGxQMDZT?= =?utf-8?B?VWszQ3dXRGpPdnQ4dzBGc2ZiZmw5NUNoaWtydGYyazErYmtXZzdnSlpVOC8r?= =?utf-8?B?ekMwK3lSU3dUMEZiVm4zazcvNVZBajFIUHVBNDl3NE0rMi9ZU3ZKYnZUMUZF?= =?utf-8?B?Vk9pQWxkcTg1WDlCNzFJV1VaMkVFdWFOZWgxaVFCN2d3Z1hiS3Brbjd5K3Nw?= =?utf-8?B?bys3aFFNV1Z1OC83QjFRS2w4ZWlzc0VXZVVXaCs3VU5CTUZ2TkFYQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <21FF77F77B084A45A1819E282C33BEC5@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5160.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13c3d6a7-e62a-4867-068d-08da34b4c3eb X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 07:47:01.1751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7vMn8YS+NLYs6oJ34VwGCw9qth3U92k/zhjr/iNCedbz5AyxGJs3Rdxw9xfxUbvaL4YD+3gh7zXsxpXZKRO+uZK6gcxMZe/10tXZgbHNYJs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1504 T24gMTEvMDUvMjAyMiAxMzo1OCwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IEVYVEVSTkFM IEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91 IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQ0KPiANCj4gRm9yIGhpc3RvcmljYWwgcmVhc29ucyB0 aGUgc3dpdGxiIGNvZGUgcGFuaWNlZCB3aGVuIHRoZSBtZXRhZGF0YSBjb3VsZA0KPiBub3QgYmUg YWxsb2NhdGVkLCBidXQganVzdCBwcmludGVkIGEgd2FybmluZyB3aGVuIHRoZSBhY3R1YWwgbWFp bg0KPiBzd2lvdGxiIGJ1ZmZlciBjb3VsZCBub3QgYmUgYWxsb2NhdGVkLiAgUmVzdG9yZSB0aGlz IHNvbWV3aGF0IHVuZXhwZWN0ZWQNCj4gYmVoYXZpb3IgYXMgY2hhbmdpbmcgaXQgY2F1c2VkIGEg Ym9vdCBmYWlsdXJlIG9uIHRoZSBNaWNyb2NoaXAgUklTQy1WDQo+IFBvbGFyRmlyZSBTb0MgSWNp Y2xlIGtpdC4NCj4gDQo+IEZpeGVzOiA2NDI0ZTMxYjFjMDUgKCJzd2lvdGxiOiByZW1vdmUgc3dp b3RsYl9pbml0X3dpdGhfdGJsIGFuZCBzd2lvdGxiX2luaXRfbGF0ZV93aXRoX3RibCIpDQo+IFJl cG9ydGVkLWJ5OiBDb25vciBEb29sZXkgPENvbm9yLkRvb2xleUBtaWNyb2NoaXAuY29tPg0KPiBT aWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4NCj4gVGVzdGVkLWJ5 OiBDb25vciBEb29sZXkgPENvbm9yLkRvb2xleUBtaWNyb2NoaXAuY29tPg0KDQpGV0lXOg0KQWNr ZWQtYnk6IENvbm9yIERvb2xleSA8Y29ub3IuZG9vbGV5QG1pY3JvY2hpcC5jb20+DQoNCj4gLS0t DQo+ICAga2VybmVsL2RtYS9zd2lvdGxiLmMgfCA2ICsrKystLQ0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEva2Vy bmVsL2RtYS9zd2lvdGxiLmMgYi9rZXJuZWwvZG1hL3N3aW90bGIuYw0KPiBpbmRleCBlMmVmMDg2 NGViMWU1Li4zZTk5MmEzMDhjOGExIDEwMDY0NA0KPiAtLS0gYS9rZXJuZWwvZG1hL3N3aW90bGIu Yw0KPiArKysgYi9rZXJuZWwvZG1hL3N3aW90bGIuYw0KPiBAQCAtMjU0LDggKzI1NCwxMCBAQCB2 b2lkIF9faW5pdCBzd2lvdGxiX2luaXRfcmVtYXAoYm9vbCBhZGRyZXNzaW5nX2xpbWl0LCB1bnNp Z25lZCBpbnQgZmxhZ3MsDQo+ICAgICAgICAgICAgICAgICAgdGxiID0gbWVtYmxvY2tfYWxsb2Mo Ynl0ZXMsIFBBR0VfU0laRSk7DQo+ICAgICAgICAgIGVsc2UNCj4gICAgICAgICAgICAgICAgICB0 bGIgPSBtZW1ibG9ja19hbGxvY19sb3coYnl0ZXMsIFBBR0VfU0laRSk7DQo+IC0gICAgICAgaWYg KCF0bGIpDQo+IC0gICAgICAgICAgICAgICBwYW5pYygiJXM6IGZhaWxlZCB0byBhbGxvY2F0ZSB0 bGIgc3RydWN0dXJlXG4iLCBfX2Z1bmNfXyk7DQo+ICsgICAgICAgaWYgKCF0bGIpIHsNCj4gKyAg ICAgICAgICAgICAgIHByX3dhcm4oIiVzOiBmYWlsZWQgdG8gYWxsb2NhdGUgdGxiIHN0cnVjdHVy ZVxuIiwgX19mdW5jX18pOw0KPiArICAgICAgICAgICAgICAgcmV0dXJuOw0KPiArICAgICAgIH0N Cj4gDQo+ICAgICAgICAgIGlmIChyZW1hcCAmJiByZW1hcCh0bGIsIG5zbGFicykgPCAwKSB7DQo+ ICAgICAgICAgICAgICAgICAgbWVtYmxvY2tfZnJlZSh0bGIsIFBBR0VfQUxJR04oYnl0ZXMpKTsN Cj4gLS0NCj4gMi4zMC4yDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 13 08:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 08:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328282.551270 (Exim 4.92) (envelope-from ) id 1npQX2-0001tb-5b; Fri, 13 May 2022 08:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328282.551270; Fri, 13 May 2022 08:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQX2-0001tU-1L; Fri, 13 May 2022 08:20:16 +0000 Received: by outflank-mailman (input) for mailman id 328282; Fri, 13 May 2022 08:20:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQX0-0001tK-Nm; Fri, 13 May 2022 08:20:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQX0-00037C-Iq; Fri, 13 May 2022 08:20:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQWz-0006Ru-VT; Fri, 13 May 2022 08:20:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npQWz-0000ma-V2; Fri, 13 May 2022 08:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bKylklrftTJLBJZnYweSDEreDT8tUiZg/CvIiHG2UDU=; b=njzVLkBYwI2rK+MMmL+ONd+lRg ZuzOULxpJQh/ECkaNDNujABZKMRfdD8lmhscrpDSstbEMws4l0PuNRRKKStiEBQEvtGfwxHEwkwhR 4sWdsMDZkJQbcfAzS+KPmyP9nscvKlvuaW7VKjvcUKXZuoUXaoHsOtVPAcQ/q7Z/UOZo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170370: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=407b13a71e324aba76b11e5f66f59ce4a304a088 From: osstest service owner Date: Fri, 13 May 2022 08:20:13 +0000 flight 170370 xen-unstable real [real] flight 170382 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170370/ http://logs.test-lab.xenproject.org/osstest/logs/170382/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 170382-retest test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 170382-retest test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170382-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170314 test-amd64-i386-migrupgrade 10 xen-install/src_host fail like 170343 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170343 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170343 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170343 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170343 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170343 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170343 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170343 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170343 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170343 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170343 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170343 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 407b13a71e324aba76b11e5f66f59ce4a304a088 Last test of basis 170343 2022-05-12 01:51:50 Z 1 days Testing same since 170370 2022-05-12 22:38:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 407b13a71e..207abdb38e 207abdb38ee987e99385263e3e56b6c500d74cbc -> master From xen-devel-bounces@lists.xenproject.org Fri May 13 08:20:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 08:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328289.551281 (Exim 4.92) (envelope-from ) id 1npQXO-0002IW-Ib; Fri, 13 May 2022 08:20:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328289.551281; Fri, 13 May 2022 08:20:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQXO-0002IP-Fz; Fri, 13 May 2022 08:20:38 +0000 Received: by outflank-mailman (input) for mailman id 328289; Fri, 13 May 2022 08:20:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQXN-0002I2-CR; Fri, 13 May 2022 08:20:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQXN-000393-BS; Fri, 13 May 2022 08:20:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npQXM-0006Si-Tx; Fri, 13 May 2022 08:20:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npQXM-0001Ac-TU; Fri, 13 May 2022 08:20:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e7buopNIXGNu3FLkVymTIznmL87157mHgaSACavodT0=; b=kHe2t/H2Gz3d3Wk7xkb98SSb7b Ky75Md8ITMXRsxRYJKszV12nynt0QX80XTFEaPM4bYUk1M/mHrizIIztUcl+bCiHOhHJ5QV4D+fEf k8JM80dXuWIAR2IsV+1QHQSM3300s3KwQvwjfqoyiG4VyX0ITffbTohoCYI3K70k21PI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170383: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 08:20:36 +0000 flight 170383 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170383/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 977 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 09:18:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 09:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328302.551296 (Exim 4.92) (envelope-from ) id 1npRRK-0007ju-1C; Fri, 13 May 2022 09:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328302.551296; Fri, 13 May 2022 09:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRRJ-0007jn-U1; Fri, 13 May 2022 09:18:25 +0000 Received: by outflank-mailman (input) for mailman id 328302; Fri, 13 May 2022 09:18:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRRI-0007jd-Kj; Fri, 13 May 2022 09:18:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRRI-00048A-I7; Fri, 13 May 2022 09:18:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRRH-000199-US; Fri, 13 May 2022 09:18:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npRRH-0005s5-U1; Fri, 13 May 2022 09:18:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wtIJGDqeo9xvJUZUWNyx7FANTlZ5XlcV6l8342NXvvg=; b=5aGyEcqCToJjx82N3hJCjFXE5C 9HXRYu78youkV1SZg+q2LFin7wPJ4A0KsyuQ2XeZjVK0IQJticZ585byyP49m1lBgnSKfWWZSzYcX j6K33X1QIt/kLY/j8yXnTQXDX8nG7j1/kwPtYD0cDFIrlioGhW8Ia5Id6D79FsCBpkGE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170374: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9de5f2b40860c5f8295e73fea9922df6f0b8d89a X-Osstest-Versions-That: qemuu=b32b3897f8b8f2f17425c22ea229ea6ebcb7d552 From: osstest service owner Date: Fri, 13 May 2022 09:18:23 +0000 flight 170374 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170374/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170362 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170362 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170362 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170362 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170362 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170362 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170362 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170362 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 9de5f2b40860c5f8295e73fea9922df6f0b8d89a baseline version: qemuu b32b3897f8b8f2f17425c22ea229ea6ebcb7d552 Last test of basis 170362 2022-05-12 17:37:00 Z 0 days Testing same since 170374 2022-05-13 01:09:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Bernhard Beschow Eric Auger Juan Quintela Kshitij Suri Paolo Bonzini Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git b32b3897f8..9de5f2b408 9de5f2b40860c5f8295e73fea9922df6f0b8d89a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 13 09:20:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 09:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328310.551307 (Exim 4.92) (envelope-from ) id 1npRTF-0000eT-Dn; Fri, 13 May 2022 09:20:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328310.551307; Fri, 13 May 2022 09:20:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRTF-0000eM-Ar; Fri, 13 May 2022 09:20:25 +0000 Received: by outflank-mailman (input) for mailman id 328310; Fri, 13 May 2022 09:20:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRTE-0000eG-KY for xen-devel@lists.xenproject.org; Fri, 13 May 2022 09:20:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRTE-00049p-D1; Fri, 13 May 2022 09:20:24 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.8.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npRTE-0001bV-6s; Fri, 13 May 2022 09:20:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ogGkrUlV54a47cqNz5EA2FF+ojxeOuJth8TYpd9x6HY=; b=mC2nN19LVhvl5gAlEc+QYS0gm3 kUjKhJPGFUcsUntRt9b8S61098DbatsAF0Jao4NFqEt160S6mB/dVBaeBeqqJJ09ouEK6MpxLPwFE WZWtDAeHP/hyp3hXGC7XrqScUQ+GONgm2ng7eLl9VhL8VMak73z7zboznEeRnwiW4A6k=; Message-ID: <82da0dc0-c5e3-c480-0ec2-c5df269dbe3e@xen.org> Date: Fri, 13 May 2022 10:20:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220512091129.2802997-1-Penny.Zheng@arm.com> <20220512091129.2802997-5-Penny.Zheng@arm.com> <47b4d6c2-3bc7-02bc-be5a-a2b782541c3c@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/05/2022 03:22, Penny Zheng wrote: > Hi Julien Hi Penny, >> -----Original Message----- >> From: Julien Grall >> Sent: Thursday, May 12, 2022 6:14 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v3 4/8] xen/arm: introduce put_page_nr and get_page_nr >> >> >> >> On 12/05/2022 10:11, Penny Zheng wrote: >>> Later, we need to add the right amount of references, which should be >>> the number of borrower domains, to the owner domain. Since we only >>> have >>> get_page() to increment the page reference by 1, a loop is needed per >>> page, which is inefficient and time-consuming. >>> >>> To save the loop time, this commit introduces a set of new helpers >>> put_page_nr() and get_page_nr() to increment/drop the page reference by >> nr. >>> >>> Signed-off-by: Penny Zheng >>> --- >>> v3 changes: >>> - check overflow with "n" >>> - remove spurious change >>> - bring back the check that we enter the loop only when count_info is >>> greater than 0 >>> --- >>> v2 change: >>> - new commit >>> --- >>> xen/arch/arm/include/asm/mm.h | 4 ++++ >>> xen/arch/arm/mm.c | 36 ++++++++++++++++++++++++++--------- >>> 2 files changed, 31 insertions(+), 9 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/mm.h >>> b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 >>> --- a/xen/arch/arm/include/asm/mm.h >>> +++ b/xen/arch/arm/include/asm/mm.h >>> @@ -347,6 +347,10 @@ void free_init_memory(void); >>> int guest_physmap_mark_populate_on_demand(struct domain *d, >> unsigned long gfn, >>> unsigned int order); >>> >>> +extern bool get_page_nr(struct page_info *page, const struct domain >> *domain, >>> + unsigned long nr); extern void >>> +put_page_nr(struct page_info *page, unsigned long nr); >>> + >>> extern void put_page_type(struct page_info *page); >>> static inline void put_page_and_type(struct page_info *page) >>> { >>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index >>> 7b1f2f4906..a9461e07aa 100644 >>> --- a/xen/arch/arm/mm.c >>> +++ b/xen/arch/arm/mm.c >>> @@ -1537,7 +1537,8 @@ long arch_memory_op(int op, >> XEN_GUEST_HANDLE_PARAM(void) arg) >>> return 0; >>> } >>> >>> -struct domain *page_get_owner_and_reference(struct page_info *page) >>> +static struct domain *page_get_owner_and_nr_reference(struct page_info >> *page, >>> + unsigned long >>> +nr) >>> { >>> unsigned long x, y = page->count_info; >>> struct domain *owner; >>> @@ -1548,10 +1549,10 @@ struct domain >> *page_get_owner_and_reference(struct page_info *page) >>> * Count == 0: Page is not allocated, so we cannot take a reference. >>> * Count == -1: Reference count would wrap, which is invalid. >>> */ >>> - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) >>> + if ( unlikely(((x + nr) & PGC_count_mask) <= 1) ) >> >> This check looks wrong to me. You want to make sure that the right equation >> return is at least equal to n otherwise. >> > > Right, right, I haven't considered thoroughly! A thousand thanks for the following > detailed explanation~ > >> Furthermore, I think we need to restrict 'nr' to PGC_count_mask to fully catch >> any overflow. >> >> Before the loop, the code would look like: >> >> /* Restrict nr to avoid "double" overflow */ if ( nr >= PGC_count_mask ) { >> ASSERT_UNREACHABLE(); >> return NULL; >> } >> >> The check in the loop would look like: >> >> if ( unlikely((x + nr) & PGC_count_mask) <= n ) >> >> That said, it might be easier to read the overflow check if we do: >> >> count = x & PGC_count_mask; >> if ( !count || ((PGC_count_mask - count) <= n) ) >> >> I haven't measured and check which of the two options would result to better >> code and performance (get_page() is often called). >> > > Correct me if I understand wrongly: > IMO, only option two is actually catching any overflow? Let (PGC_count_mask - count) <= nr > stay in the loop, not before the loop like option 1, to cover the changeable page->count_info. Both option should catch the overflow. In option 1, this was 2 part check: if ( nr >= PGC_count_mask ) ... do { if ( unlikely((x + nr) & PGC_count_mask <= n ) return NULL; ... } while (...); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 13 09:24:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 09:24:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328320.551318 (Exim 4.92) (envelope-from ) id 1npRWv-0001O4-WC; Fri, 13 May 2022 09:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328320.551318; Fri, 13 May 2022 09:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRWv-0001Nx-TE; Fri, 13 May 2022 09:24:13 +0000 Received: by outflank-mailman (input) for mailman id 328320; Fri, 13 May 2022 09:24:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRWu-0001Nr-4T for xen-devel@lists.xenproject.org; Fri, 13 May 2022 09:24:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRWr-0004E9-Iz; Fri, 13 May 2022 09:24:09 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.8.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npRWr-0001wD-Cz; Fri, 13 May 2022 09:24:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=99W2h36Q0Kwvylfm3MqROP61WcB89pjN9hPAnx0yvDQ=; b=Apuqg4Fh/5ofrojk4SWb/kup6s sRI/xGhUFBGymSxA75hid3yuuhYm75hzVWojqXseteHPS5C+jQUPLNCbJ9oeh0EkAMpiSDBIkOLNy iESbSG9SnqOcyOGxyulxIs/g4iuyBGdHWL/lfDe3cySVtwmvwRbVMXisP1CpmnknzcQg=; Message-ID: <7f89af03-66d2-9c59-a761-4c8a188570d9@xen.org> Date: Fri, 13 May 2022 10:24:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Stefano Stabellini Cc: Bertrand Marquis , Rahul Singh , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 13/05/2022 02:23, Stefano Stabellini wrote: > On Wed, 11 May 2022, Julien Grall wrote: >>> If dom0 is mandatory yes, we should still make sure that this code cannot be >>> reached so an ASSERT would be nice here at least in case someone tries to >>> activate this code without dom0 (which might happen when we will push the >>> serie for static event channels). >> >> I am fine with an ASSERT(). > > I added an ASSERT(hardware_domain). Just to clarify and avoid a round trip. The ASSERT() is not sufficient here. We also need to forbid the user to set xen,enhanced when the HW domain is not NULL, at least until Rahul's pre-allocated event channel series. This check would have to be done when parsing the configuration. The ASSERT() would be here to ensure that if someone is reworking the parsing, it would get caught nicely rather than a NULL dereference. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 13 09:34:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 09:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328327.551329 (Exim 4.92) (envelope-from ) id 1npRga-0002qo-Vq; Fri, 13 May 2022 09:34:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328327.551329; Fri, 13 May 2022 09:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRga-0002qh-T7; Fri, 13 May 2022 09:34:12 +0000 Received: by outflank-mailman (input) for mailman id 328327; Fri, 13 May 2022 09:34:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRgZ-0002qb-2p for xen-devel@lists.xenproject.org; Fri, 13 May 2022 09:34:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRgY-0004Ol-9K; Fri, 13 May 2022 09:34:10 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.8.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npRgY-0002Vr-2b; Fri, 13 May 2022 09:34:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=I2i8LsrfMGeHrJpYk4FSI8SKulkmmDrNdryLjoJEWjY=; b=tYrHC7UwUg6QVPlNOGNWIe3Su6 snNA39IokHAMx251/YEebQjvZyoWKypMkMJeS6WYoEo1hFYHJgCI7vNgXD4eFI9pxctiZl8o7zWyc Wi0MKGMBUSgItbT6bHMlqnE6EmS8QUbgEVo/F8kOpPw8NGBISfLhtr5paVNma+gwBaCw=; Message-ID: <990efb92-e3b7-9487-2039-cf93ea1011af@xen.org> Date: Fri, 13 May 2022 10:34:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20220505001656.395419-6-sstabellini@kernel.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 13/05/2022 02:09, Stefano Stabellini wrote: > On Wed, 11 May 2022, Julien Grall wrote: >>> + rc = xs_introduce_domain(xsh, info->domid, >>> + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, >>> + xenstore_evtchn); >> >> I might be missing something here. In an ealier version, I pointed out that >> xs_introduce_domain() would fail in the case the dom0less domain doesn't have >> "xen,enhanced". >> >> AFAICT, you agreed that the (part?) of initialization should be skipped. But I >> don't see the change in the code. Regarding the placement, we could either >> fully skip init_domain() or just xs_introduce_domain(). The latter might be >> better so all the domains are listed using xenstore-ls. >> >> So something like below should work: >> >> if ( xenstore_evtchn ) >> { >> rc = xs_introduce...(); >> ... >> } > > Yes, good point. xenstore_evtchn could be zero validly (first evtchn is > zero), Event channel 0 is always reserved when initialization the event channel subsystem (evtchn_init()): evtchn_from_port(d, 0)->state = ECS_RESERVED; > so instead I'll check on xenstore_pfn to be zero (xenstore_pfn is > 0 for non-enhanced domUs.) I spotted that difference but decided to not comment on it as Linux is already considering the values 0 and ~0 as invalid. However, I am not in favor on any code to rely on 0 means Xenstore will never be available while ~0 means that it might be available. Anyway, as I wrote above, the event channel 0 is always reserved. So you can safely use this value to detect whether we allocated the event channel for Xenstore. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 13 09:44:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 09:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328334.551340 (Exim 4.92) (envelope-from ) id 1npRqQ-0004Me-TR; Fri, 13 May 2022 09:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328334.551340; Fri, 13 May 2022 09:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRqQ-0004MX-Pr; Fri, 13 May 2022 09:44:22 +0000 Received: by outflank-mailman (input) for mailman id 328334; Fri, 13 May 2022 09:44:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRqQ-0004MN-8o; Fri, 13 May 2022 09:44:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRqQ-0004aX-71; Fri, 13 May 2022 09:44:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npRqP-0002ln-Su; Fri, 13 May 2022 09:44:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npRqP-0006w5-SF; Fri, 13 May 2022 09:44:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RavaewB0Z5MaEBYbdRcDtMvkCrQsTlIwG6e68ZcmxJ0=; b=eliRVoJp7nvIAtsbyBS8A+s19H we9D2FvoZ9Xi4bAWxyIRK+P+YtpCogPmWtKrte5NRAqz/LRIvgZe35uPgb8zKQR0RV8OUILMB4Gbu tCZVt7jlbVQ7vpsVDRgkyKffGzsUnPCSV5OyN/PkymcR4mVi57FjwsQ1xPEdATfomrhQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170387: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 09:44:21 +0000 flight 170387 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170387/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 73 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 978 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 10:00:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328343.551350 (Exim 4.92) (envelope-from ) id 1npS5n-0006oL-8w; Fri, 13 May 2022 10:00:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328343.551350; Fri, 13 May 2022 10:00:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npS5n-0006oE-64; Fri, 13 May 2022 10:00:15 +0000 Received: by outflank-mailman (input) for mailman id 328343; Fri, 13 May 2022 10:00:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npS5l-0006o8-Ql for xen-devel@lists.xenproject.org; Fri, 13 May 2022 10:00:14 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78a37066-d2a3-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 12:00:12 +0200 (CEST) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 06:00:03 -0400 Received: from PH0PR03MB6382.namprd03.prod.outlook.com (2603:10b6:510:ab::9) by MW4PR03MB6393.namprd03.prod.outlook.com (2603:10b6:303:120::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 10:00:00 +0000 Received: from PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce]) by PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::b02b:3af6:daa0:30ce%8]) with mapi id 15.20.5250.014; Fri, 13 May 2022 10:00:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78a37066-d2a3-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652436011; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=55k7Zp2QAhQKOsgBKKOHb+MLwCmCtCVvp/GIe816wQg=; b=AhZrf1ODeR8n4L44cnNyFzuOhukwdwsp5+XH7IWmu0z36wtbbZzAgsNn UIxhAnRdCV21nWDbRyUMxbXXShE8qO2xgXkwczadS6d7zOQE1cQO3ZLS9 ic6hNdsLtptEorsGOUJOZn6V9MShP63nYtgprumslxyioUXFgBO6bFo+n o=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 73739510 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RDp8dqCWS9Cy0RVW/zjiw5YqxClBgxIJ4kV8jS/XYbTApGwr0TYBm DcfCG7VPvrYYGene4h+YN/j8x4GuMCBmoQyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhey 44cnq6UYj02FZTUiL1NAzYBSwFHaPguFL/veRBTsOS15mifKz7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mbHs0m5vcBtNs0rtpJBu2YY 8MWZCBwZRDESxZOJk0WGNQ1m+LAanzXLGYH8wPI/PJfD2779hxbz4fxa4vvZoaWHZUOk2SUj Tme4DGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRolWlR9tVJ kgQ+ywvhas/7kqmSp/6RRLQiGaNoxo0S9dWVeog52ml06fR/kOVC3YJShZHb9opstJwQiYlv mJlhPvsDD1r9bGQF3SU8+7MqSvoYHBIa2gfeSUDUA0JpcH5p50+hQ7OSdAlF7OpitryGnf7x DXiQDUCuoj/RPUjj82TlW0rSRr1znQVZmbZPjnqY18= IronPort-HdrOrdr: A9a23:s5vfvaGOC1xGZk4IpLqFSpHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdhrNhcYtKPTOW9VdASbsP0WKM+UyGJ8STzI9gPO JbAtBD4b7LfBdHZKTBkW+F+r8bqbHpnpxAx92utkuFJjsaCZ2Imj0JbjpzZXcGITWua6BYKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/HKVwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5t+7Y23+4sowwfX+0OVjbdaKvm/VfcO0aaSAWMR4Z vxStEbToJOAj3qDziISFDWqnTdOX4VmgPfIBmj8DXeSIXCNUwH48Ytv/MnTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv9nZMOq59ks5Vka/pWVFaRl/1swGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlJhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OGDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowlLau3ieffFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vd/HmZw == X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="73739510" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUa30CsaKa5vz2UbeyxPjnO7xVugvRNJijn2WEZKej5y/mkuATXQh5nRvOe+dyKZs0FWWtveGO4j6zAtcuFe9VysJaQh71JzSn4AuSnYzqcHK8/L5FuLpOELhM5r/XqIAp14M0R20/yEvKSMVVgvCjbOvb95HxxaovxbjozMieKQmnE0CqK1sEUkE6Kt8rHKZYg7+nLrPBCJOytlQRqc6Qo+YWQsDJILY9SD8Yr7vF0ko4xjN395aFTovwqjWNITGcEkvmXBGIGkKmwlH69x74xF0qUZvfoLt2iiUlZnMcS0dEK1JvEHwN7MO92ADi0EFUou4ZBxxPdEesHrQmXzKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fkCjiZO24llJScKgxNzCxomb9h7PP/a3xAvTwnw48Mg=; b=Sn2ymt0xOQXPCwSFFzUEz3oydEnAqCenSx0s/7bD1Y4r0vyDTejZMd88hhOt1CTc2fWfIJkN0XYguaub+OuXX+rA3g42XZ5g+c9ITD/SeeoVqJywMIzPTv6/LTJUKTAIYaxtak9msQ89tT67jstWmLRJLD90RzM7v4VTbuGd0FJeHjNcHrGy0dpREq3FTEC+2xxK5IoXC34u/Zn4fZOe8Nx5iuaTsan4sQHTlEE+8/ifCw1I7uTsEx1NHUrvI5+lBwdkSTRkS+aGRxRZVTPUjf0zetrURsf6Kk8YhcqLa5GBszYm/pgmpuvQ+115eXtTJPSFg22K29EpOY+Vn0XKVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkCjiZO24llJScKgxNzCxomb9h7PP/a3xAvTwnw48Mg=; b=jJA/hD5pSS4ffJHK9POkVBlLf0z+hqi5VcPNFfi7C4YKoIWFT7a2A8WuRq/v8YQ2/KVPOJhmG16gGBMq/eqzI30JQSPL6vzQXDZ/LVwbhAS+HXCObBjjJBsdTJLrqO30qX62AWZkSSy9Fqk9iag1MF2BG6fu/Fspqtvc/sZfHjM= From: Ross Lagerwall To: Roger Pau Monne CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Anthony Perard , Paul Durrant , "qemu-devel@nongnu.org" Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Topic: [PATCH] xen/pt: Avoid initializing BARs from the host ones Thread-Index: AQHYWlVI6k4vzeGas0CbAgtnJ0rrZq0WWb2AgAAQ5LWAAA8wAIAGL25V Date: Fri, 13 May 2022 10:00:00 +0000 Message-ID: References: <20220427163812.2461718-1-ross.lagerwall@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14115d4e-f67c-4504-141c-08da34c757bf x-ms-traffictypediagnostic: MW4PR03MB6393:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fS5gIxeLWqIlg/g7It5N72UCO1CEMouTjxUJN5H1fwAvS++A0uUrPsBg+mESQ3MVfOr/SGAOOFKq3BxRXe3c20M3iJ+oTpCvGB88skv4g4HYOeENMwCo0HCjpXE462vS+dKwmuwajcDpZ0y8W46nWg9tqfgyUidWrTfA0ycaiA7P71720pjJa/bQHJGyFih8s0a8f2KVJZyMUrXfD1SuOEW0krphtICPHJ0fXmdgtcPg9+BGWcqQhAz+dj9QYjkBMwB2YrKVJxUKQNZnez22t1dTVHzI3zOlvHnc0putpk1K0JNFq2GiQutkW5/eJYa8VHUV9MYEe3/FQL2gJ7eU45wUMXDMl5Wq//ChALjb0cWEcwRuEfcCsBejQvjAA6xKqrX0Bu13zOwXdBXgR7QqmeC3Eqqnct9OPOk3PoHeDeVlyjv+nmj0h8/fjnRGKqwbOZMJdltzSTDFTU2PZaBvFgIqROuZrXZz9MDg6CFrZELPzykf0WVbZIJPELvq8xHAY8qmSqMH7/3qxMMmhNLBxa/MGkIlrAZncmfuYFGR8uoNPhjE45kAZPqDA9RAVTy06AWqVEVzSTTrOYg1wshgNy5Yxko2rIWAMScdGtVhsHgt80WQGzL3ydanUL1ZGJkWZU8GzkT8MYg520yIBpwKRR859/0ob8xGUjP6QL8LATzSQEZ7o/+eAPniX9r6NZVsDxHk4sAx99cV8GAOcC8idQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6636002)(54906003)(316002)(2906002)(91956017)(38100700002)(52536014)(122000001)(82960400001)(8936002)(38070700005)(5660300002)(86362001)(55016003)(508600001)(7696005)(8676002)(64756008)(66446008)(66556008)(66946007)(76116006)(66476007)(44832011)(4326008)(6862004)(71200400001)(186003)(53546011)(33656002)(83380400001)(26005)(9686003)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?144h3xaGVLWvQZp5bVEys8ypCPS7xfShpbqe9MkVnoPmsBxHZgqCmNyQAB?= =?iso-8859-1?Q?CaXwCkuzLJgxOU71lSSMd3ILY43a6B5Awq2w8Cqhu+zcFpcNMkIbeEAOoI?= =?iso-8859-1?Q?tzDnrl2hSgDjoc8tfjz6tEtXrBPxvkIL8jutlsav+buSh6u6QobIA6g7m9?= =?iso-8859-1?Q?u1CNdQw85IrwKWr1SxCtAMF02k4SIjjTxpAORw33eG1uvE5+D8mDpgczha?= =?iso-8859-1?Q?VQU5emkqmon9E/ciAFQWkUieW0r6wwqE+Y1NKADEDxGclL0U2hpax331A/?= =?iso-8859-1?Q?HeqcIw4HA1QviAWRf3naCkvJ5wlrOsx3qaEz7hl6nbH9M+BWWZuqrfdbb8?= =?iso-8859-1?Q?LUEz4TsnQw6PcOeTRLELrHaovZhiUEhWSNE3QovXBzkRSpjhjsPf83oq/v?= =?iso-8859-1?Q?bj/Qya6VOhyA5AGwgWlWIKwE0Ou7ju085dMuHHeVcpdrGknYVdBsRDZmva?= =?iso-8859-1?Q?n/RY8lSL7X0jR9xd5p2zprIxpSc0d9bP6ruxCpkyQdbc4P/SpAUuPG7mb6?= =?iso-8859-1?Q?ixA0nfmmz3N1giStomitSETRjiMUiqzOtPQPHJBgVIhMnwNJTMzbFPE+Lh?= =?iso-8859-1?Q?EzAe4HHxBTfjO3yBBekzGpp1UDm19c2yImIkObiYEMyvm+4rNj5c6xvwAl?= =?iso-8859-1?Q?cQcsx5DM/HQYtgMsNSLnBNSYIUj+v8WKZDzJvb1dtzBNUb6gi7KEojT9SX?= =?iso-8859-1?Q?J17Azrkae7W5FaN75oIQsIjBs+aMtaZ3fGbHHAH4ySZQhQcuiuAJ9UEmTY?= =?iso-8859-1?Q?ESuw3mH41qYdwZaV5PjS7MfyW6ZUxBu8bQTMMIXVHsJW50Lo/k2zM+HSv7?= =?iso-8859-1?Q?kZhRT9erz2L78v6FgYAN9aNNnBHhaU6jVAIXAB49thbSV0UecSyl3GqUHx?= =?iso-8859-1?Q?KfCxGaESv8Qr8sgOpHq7tRjWzBx4sQsWr9tcxTcLf9UlvSWMukGaCiv193?= =?iso-8859-1?Q?ONmCmwcwj0HMeUDURs4NwhlR0uEHeHrgpcWcKWhgf/8o2YLa8+iZCTVCz7?= =?iso-8859-1?Q?QTYsqqvJ2pJTuJbocSMGC10E1dCYQvAYsOOkDylfwYydTxnyKOxzJjSYU/?= =?iso-8859-1?Q?p7rCRyDqtR0ojsfTQuMy1stARgCP2BmajbyEFipXD2urPjaZfos4SBJdGc?= =?iso-8859-1?Q?UIB+UypYqvNw3yrToxYXVQUcgjb2uAcU9YYkaesOkBYluleXDMu5Sm3u37?= =?iso-8859-1?Q?6io2a45mjhICZngh+PuoCroo56mvIkfK9et4MelHBV+0u8AqghDWNgye4Z?= =?iso-8859-1?Q?6TD6KSIgSlkYAqT+mhA2w4krX3rqe8HMEKnWO+bG2dftB7DsrRG2EPUPx4?= =?iso-8859-1?Q?7H2I34BgKK6GpqEYASluR/GHKytXg8r/F1zkFow8v/z+B8jFofy2jrOqPz?= =?iso-8859-1?Q?aUv9k/iqg3eawCzTooAN860gCOjzQAfdCCZSLdbbEjCzsB0RAAszFsLQCO?= =?iso-8859-1?Q?ukOlPMpQ1QDqKf9r8UlsrvATywIYzQX3Kzn3bZOUQGS/fzVSlwSmKHFNfx?= =?iso-8859-1?Q?X75LjYvZfGIhXz3uRf9efW8Ancbw3RDj59z8BT682/tBjagUVrm+Sdyk/7?= =?iso-8859-1?Q?rMc+UnnrOuSdj89yhN2NRFjEohXG3CLftIHFxNdToaJd4OnJU7Y7iIMd4W?= =?iso-8859-1?Q?CjoSwDoKjyGVaWZO+Zh5Po9q2363xLlwBKqYtTdVGik/kBv0G7Vqc3MIx7?= =?iso-8859-1?Q?/v11ZD7uAK8wDSvlkZMjDwxg8nmRfIj++77LNu7+7LkBuCy81Pwd/69LdW?= =?iso-8859-1?Q?bDuK8eizZhTI+lh3+wU51/rkuzpTIQ3AJz0aMoDGViEXTT1yiO3k8JnwW6?= =?iso-8859-1?Q?pzl+vkqrmTrZHYxQPhXIEA2rmpzMuAA=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14115d4e-f67c-4504-141c-08da34c757bf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 10:00:00.1310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s6xMrD494ypIQBms8kZes+7zJqcqsLJQsv+HFH8263EvbApHn+Fjpt3/iSlg6ftcV2ZnaQhQGXXbCo5FmOCOkB8r6S9IHzsP5vy9LLjAl4U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6393 > From: Roger Pau Monne =0A= > Sent: Monday, May 9, 2022 12:23 PM=0A= > To: Ross Lagerwall =0A= > Cc: xen-devel@lists.xenproject.org ; Stef= ano Stabellini ; Anthony Perard ; Paul Durrant ; qemu-devel@nongnu.org =0A= > Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host ones = =0A= > =0A= > On Mon, May 09, 2022 at 10:39:32AM +0000, Ross Lagerwall wrote:=0A= > > > From: Roger Pau Monne =0A= > > > Sent: Monday, May 9, 2022 10:28 AM=0A= > > > To: Ross Lagerwall =0A= > > > Cc: xen-devel@lists.xenproject.org ; = Stefano Stabellini ; Anthony Perard ; Paul Durrant ; qemu-devel@nongnu.org =0A= > > > Subject: Re: [PATCH] xen/pt: Avoid initializing BARs from the host on= es =0A= > > > =0A= > > > On Wed, Apr 27, 2022 at 05:38:12PM +0100, Ross Lagerwall via wrote:= =0A= > > > > The BAR emulated register definition does not set emu_mask because = it=0A= > > > > varies depending on bar_flag. If emu_mask is not set, then the BAR= is=0A= > > > > initialized based on the host value which causes the BAR to be init= ially=0A= > > > > mapped at whatever value the host device was using. Although it doe= s=0A= > > > > eventually get mapped at the correct location, it causes unnecessar= y=0A= > > > > mapping/unmappings.=0A= > > > =0A= > > > Would it be possible to just unset the memory decoding bit in the=0A= > > > command register if it's set?=0A= > > =0A= > > I don't think that would be sufficient since AFAICT qemu does not read = that=0A= > > bit so will still call into Xen to update memory mappings, etc.=0A= > =0A= > Hm, but this seems wrong? QEMU should not set memory mappings if the=0A= > memory decoding bit is unset. While the bit will be set for the=0A= > underlying physical device, it shouldn't be set in the emulated=0A= > command register provided to the guest, and hence no mappings should=0A= > be established until that bit is set by the guest.=0A= > =0A= > In the description you mention not using the host BAR positions, which=0A= > is fine, but you also need to prevent mappings from being created=0A= > until the guest has positioned the BARs and enabled the memory=0A= > decoding bit, or else you end up positioning the BARs wrongly has QEMU=0A= > has no knowledge of where should BARs reside.=0A= > =0A= =0A= I was wrong - I missed the point where QEMU checked the memory decoding bit= =0A= since it is in the core PCI code.=0A= =0A= This patch was originally for some older combination of Xen/QEMU. I=0A= rechecked now and I'm no longer able to reproduce the symptom in the=0A= description (unnecessary incorrect mapping/unmappings) so I guess=0A= something else changed in the meantime. The BAR register being=0A= temporarily populated with host values before being programmed=0A= is therefore not a big issue so I think this patch can just be=0A= dropped.=0A= =0A= Thanks,=0A= Ross= From xen-devel-bounces@lists.xenproject.org Fri May 13 10:35:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328385.551378 (Exim 4.92) (envelope-from ) id 1npSe4-00026B-Cb; Fri, 13 May 2022 10:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328385.551378; Fri, 13 May 2022 10:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe4-000264-9g; Fri, 13 May 2022 10:35:40 +0000 Received: by outflank-mailman (input) for mailman id 328385; Fri, 13 May 2022 10:35:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe3-00025y-38 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 10:35:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6c425a6e-d2a8-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 12:35:37 +0200 (CEST) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 06:35:34 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2819.namprd03.prod.outlook.com (2603:10b6:404:118::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 10:35:32 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 10:35:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c425a6e-d2a8-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652438137; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=kwxTFr5F6CSXIMRptM2BX/K/lUueF8Uj+EjtZEw9lYU=; b=VXpWvYNvLcK0ygZueI4RFMSEjEsshaWhWJBivsz0oSEQ7WujhREjj3vd P5x5EXhwZ0FWq0vHo0xCDPtXUNuhHNjte9GQETQhR7AZ0hX66vhXsXUx6 zYWpKuVrHOId+A9aMFVO9mBIEsToeyax6e2LwUxsii8ulZoqLD2Z1QswG k=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 71235105 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Sd86ZKmry27nKbyg2BmOWtLo5gyGJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJNWTvVM6vZYzP8e4okPdyypE4HusSGytcwHAo++S49EyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWljV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYYA4DZafpxuAhSEN9CjAlG5dP6qSXGC3q2SCT5xWun3rE5dxLVRtzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXtJkBg25YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8QjO+PNvvgA/yiRTj6bBAPaWQOCLbvsJhk2Im UOb4kPQV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWRNZ3O 0ESvC00osAa9kOxScLmdwalu3PCtRkZM/JSGeAn7ACGyoLP/h2UQGMDS1Z8hMcOscY3QXkm0 wGPltawXzh36uTKEDSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa3871qbnC43TEYj7vg+R IronPort-HdrOrdr: A9a23:CJQqDKhLHs5bqs0jEYU7OylHtnBQXzx13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMzVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xA+A2frfKVy1zx0eWzRAzfML9n XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXAnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MaM8F6+xrqDxOIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8e1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh57D3xHklX6voIRiKprzOSI JVfYDhDbdtABinhknizyVSKIfGZAVyIv+EKnJyyfB9nQIm30yR9HFou/D3rk1wiK7VdKM0md gsSp4Y8o2mbvVmGJ6VV91xNfdeNAT2MGPxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK g= X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71235105" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+sYFPn3o5VAt0W5dtUM1diPHcgKkep6sc5xrgrdyWBGfG7hs88XeY17hCXYJETwRnbJqlN0HZHAvM7lXNYSu7Ixiyf8CelN8QBNyuefkIYmDDWRQ8/NG9IarRXUS4DUYRSGmzpE/ThWvrB3T1nrjNqhbijwOLtnM4Dsu2dXOGZ94rOPVIIdPKWcrPr8vjdcrYIrlHdK2dKwGM9qgoSQpEjz2F8I9bVUpDQMR94vMMG/l6IvmW5y0DQAZ6SXvmRMNhVaKzcTnTwV2NLAoLj7cJKm3dxiLYKxzYI1c3ACqL26u3GqKNCP4h9aimoGv+aoWIz8Kl8YtgeSYwz2HrfwHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJVuBkdSGC+1p8QkOTN2jFLWWi099Q4WwQFh47ImKJU=; b=OsgR5hst0aQ8rtugPju+GLbnpHu7YxhzTwFTAliao8OILoz+FA6GABezfPdtEepTWKgfDYVf1DJoYr8veaB3uV9baSmubPvgj+4vsxtXftS/mK+n7fV1Qjm7qwA8pEeAQ/lU9183Mr+/GuW5W5NJEnsV/BbFqAA+eTJUpjBXmn/ed4pPQTTrh7FforlIzicH8ElDGa8JYPx9GCHUDk7fiCVqzdaZTFoE8ehW9D9Kz2Yb9BZRUyqDIRESLMtM6fFcEmc6MuXglaYUY7gbZxgjGfrZb57RKPoDOtfK8L5RzKXGcPa5Nr+iGGn7Kzp21AN9QvaArs3bNCHAHwyVIlDvdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJVuBkdSGC+1p8QkOTN2jFLWWi099Q4WwQFh47ImKJU=; b=Bhw3P5tjGWsgxZtkYZnc7TieINDrxKRB4txi638W1xKR4tHA+UypxRhcS2jb+oNSU6vRwiK7gbt+h2oFQ3TITaky9IdDg7KuKaPP/IkaJGxStl3nygDtXLnCmXpMw26qkHaFQ21KlDWzac8ZjOsFyWsT2eUQz4VrJZiZ9CXuISI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich , Andrew Cooper Subject: [PATCH 0/2] x86/cpuid: expose MCDT_NO Date: Fri, 13 May 2022 12:34:58 +0200 Message-Id: <20220513103500.3671-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0143.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 193b8be2-7013-4177-db5b-08da34cc4e61 X-MS-TrafficTypeDiagnostic: BN6PR03MB2819:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gZgqJet1bugkEzCQp+pdLoJG9najLDxXrD+7PvGtrRtLq6nhOrndMIjkzMh4DJj3sfetN9UBXhKAQuKn7Jiotbaek93o8M8d2MS0RT+8rznzpf9/pmtZrtuGtmkqUKnSEEvs742e5Ezt7oxWdmQmIGjogJyqt0LElSF8SZTXliG7pBdxXlqFR+R04zilfGChAroD3xH7xnQcKIoYe1QlmXqNMDQVkm/clb1caEA/SizEYRvAtow42xNieBNFDmHU2q98cKSHyhF7GVt2UZgp2qjNc6X1eiefgoxJAejkLYsY97z5VSoLZIVg8GhD3LavqTRoHDj7WrCa9RoBuHFUgOkqF1Ek751zSJTN79QOhi/bB2sr/t8ySH86pWyS3QFAZRnKUuon4wRJxbn0G1KRBKtyMFz8I3f4O4m5GRugTD6vHuYXt/C7j0FLrBEnlCo3/ZtGOt2v99T4SOnpAGVqOvwB0gj7SbJj9Qn5e5LGf4/bt3pJVa5hWZNPOtk29UA2kDONYvyy5eRkR48oq3XWEOo8goJ95USb0toV0PAbEmc34zFNrQYgwSqks/o3jQgTQT9i/RfHfG2cfoSLUuQ2mi5h45JXs/SRiEL/dgycuxpJANptrFutTU3jkx4PQcS+f3wOJFT/8fLEzA/RO8P27Vsxmwi1xOyxasRoVUl/SY2gZ2Fl/VFDdpPMz33Ple/qiDxECMxJPh9ysZYT8na6iH4yr9JTpkYxDup4d0dA1l0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(5660300002)(1076003)(186003)(107886003)(316002)(6512007)(66476007)(54906003)(82960400001)(4744005)(2616005)(6506007)(38100700002)(86362001)(66946007)(66556008)(6486002)(4326008)(6666004)(966005)(8676002)(36756003)(8936002)(508600001)(2906002)(83380400001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3NpbHd6V2pSWERvQStheGh3MXFSR1hmL0c4Nkl4a1kvMmpaL3pCZzJYQ0Zk?= =?utf-8?B?QXo4Z3FvSWNDS0IxcG8rQ0dlVWJPL3FFL1R0UFIrNWlNUEVqd2YreUlrSXRN?= =?utf-8?B?T3U0OEJBWitwZTRkblZFTjErQXNVVDUvWkNnUWs1TXJ5QURObGJIWUc1TEVm?= =?utf-8?B?OTRnaitQRFhsYzlnankwSDFPd2RxcHQ4QjlxWEE1WEJlSE9rR3JqRlFGWFdQ?= =?utf-8?B?ZlovL1gxVmpxMjZ2bjR3UmpGRTk3dXI0T3lWUEkxMkVTQjNDMi80WWs5b2Ez?= =?utf-8?B?SkNGMVBmZ0lxZmorN2I0Zkx0LzB5citPa2QxeU9mV1NoaXQ5VzgxZmZPSCsy?= =?utf-8?B?eUh5cm05eWs3SDJpVGFQV1RERlcrTmJQZm04dVQ5aVdwclBRN0VGZlBpMXg2?= =?utf-8?B?S1BvcWlSd2hBMEtuSFZQMTgrSVlwaVFHb0o2N3RkTTdRcnY5VEJSdjVhbTA0?= =?utf-8?B?NXVCVGh0YzVFWFkzUHRITHl1cmhGTlVaVVo0Y2ZtR2Q4VzlTUzZKVVJ2TWtt?= =?utf-8?B?L0dYSS94SDBLblBsUGZZTUR2aEd4QWIxMVUrcC9nZEhDRithMSt6L2JINzVC?= =?utf-8?B?V01YeUh4ajcrb2djeE96TEc5aFd2TVlvNWp1eXR3bkQ2VXlSUSsyWVdrUFN5?= =?utf-8?B?cFdYNU9WallSQTdmMFY5dDdZVXZVZDdsRnJHcWJNTEp3RWsxNkRzT0d2MFAz?= =?utf-8?B?eU42bUwwa080Y2NjYUZrcWRlR0NlSG44bUJIZFFrSTl2TjN3bVVCUngzME4r?= =?utf-8?B?ZHZwYVBoZjFiMEpGYjNnZzV2UVl3NkdiTHI5V1ljZHZ3YXFReGF5bmNCNHJI?= =?utf-8?B?VWFLUTBHNlI4bGNYQ25zQ3FHWU9Ea2VET0VSL1VIMUMyeS9aWjdGNlh4TmIy?= =?utf-8?B?Mlk3TkVEZW93OUFSZzZGaThtazhxUUNOK3NldGg0R2pXdUJPOGhyS2NRb3M5?= =?utf-8?B?anBuTnExQmRiWG0rRFFtRW5uRG5POWx5RU5nTWFxT2xkUS9QUEpVVWxZRHZT?= =?utf-8?B?UG1qNG94TmVyb0R3b1VTYVBmU2d1QlM5dXo4NEhIZkVCWjk0T1hmVkpIVS9S?= =?utf-8?B?NVVPMlFLSTlEZVVrMW9JZGJhemJodk9QSkFqRC9maHVTZ09CK3g1aGswTFpk?= =?utf-8?B?NkJFbUlIK2U4WWF0cWs5NDBRUGdXanhXTlZMUXczaTlzcFkyMFpCY2p2Zy9p?= =?utf-8?B?QjFoZ3oxTWxYVUZkOWRBVnNLREpSM2tURTlkVEZtZ1dhaTBaZzA1U3VzZ00x?= =?utf-8?B?SjNGOVJvZXRCT0VYdDl0SGlQV2RxVnpPTjhTUnBjakZYS2pMa2ZWMXBJLy9M?= =?utf-8?B?VFltSDdiSVhNeFRacjZzU2p1ZkxNUHZ3cmJKM29FTW1VcHNQV2Q0VUdGMFBa?= =?utf-8?B?VEo2OXdMMnpTZmJzKzBBVzVJbXgxYm1TV3JkbktDeUZDRktnVjVNVXpmMDZ5?= =?utf-8?B?aFk1akZ2QmkvamtDWjFrRlJQaU9pS3ZrMXNZRHVGRTNzVm80VktLWE90WHNV?= =?utf-8?B?YnRzaFhBSS82REU1N3hXTDlkUFYvR2RhNFRKNklvTVFTVjRFNGRsNSs2WXd1?= =?utf-8?B?OU52eFMrTW9rQmhuSk9UMm5HN0dhbEdBekZ5S0RydlRPY2hiNUFQYzVKTjd1?= =?utf-8?B?cVp1YTgzVjdFTHJUT3hRNVZTWjlVZXZFUi9PR2JTdFdhMzBtcUFBdlR4TGth?= =?utf-8?B?NmtGTFZKZVgrSytoSmRScFcvZnFYTURpQTYxUDNtVjY3K0hYRm53VzYzSmhr?= =?utf-8?B?ajEwQlVnR2RockxlRHlBbzdSS3hPSnRWMWkxVVpUa2trVEVwWTdGVU9Zbm13?= =?utf-8?B?R1lCWmMrNDhGYjBpS2ZYeitiaUdBOXZKZTdla09SUU1TcHBXOTBleXMrZ3Rp?= =?utf-8?B?UjFicForSXdVb3dIVE93R3FWSS9qVEJuVFFURDFBRTY0MGkvaVd4ZzZXampY?= =?utf-8?B?UHFHRC9GdVVvYzRUQ0RsL3o5Y2cvQStGVE1BZ3Q3THBaeS9iWDBLZmM5eWM1?= =?utf-8?B?M2tvVm1mQm1ONi92UlpxWjdzTXJ0RGpYMXFUWHErbDZFNlVsVDVYVWgyeWcv?= =?utf-8?B?MTJnTUkwYXYrWXk1SllJdjFZeXRnZ2VCODRHYSs4eHdOdWR3WnJQSlc2VzdI?= =?utf-8?B?Vm92R2s2QWFQSkNpc0NqeEpTTHY3dS9SbHB2VUVURmJXYkE1bFpSUGhNSHI0?= =?utf-8?B?a3ZwN0hpcVFhdXZaV3FFQytzU3NDNklCK2FaTWhjTkdMN3c2aHJLQTZsQTNt?= =?utf-8?B?Lzl0ZDJXNWU0elZCY0lPU0NVY2hqejlhRDVXcjkyM0VTb0c4VDJ2RmNDL2xn?= =?utf-8?B?TWlZSUI1V0E1L25uUmFLd1hkTGtqZG5FbXYxbmFOVS94R3g4TUlYQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 193b8be2-7013-4177-db5b-08da34cc4e61 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 10:35:32.0136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EAyssV9jbbiEJFcarWZypKSGeBlSnyQkZb07O5hLP4K44AnKI2dyAH//qsnLloRVTT3TZurLoIUvVp7D9R4Tog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2819 Hello, First patch is about exposing MCDT_NO when announced by the hardware. Second patch adds detection in Xen to expose the bit if the family/model/stepping doesn't expose MCDT behavior. Document about the feature can be found at: https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/best-practices/data-operand-independent-timing-isa-guidance.html Thanks, Roger. Roger Pau Monne (2): x86/cpuid: expose MCDT_NO to guests x86/cpuid: set MCDT_NO for non-affected models tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 1 + xen/arch/x86/cpu/intel.c | 70 +++++++++++++++++++++ xen/arch/x86/cpuid.c | 10 +++ xen/include/public/arch-x86/cpufeatureset.h | 1 + 5 files changed, 83 insertions(+) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 13 10:35:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328386.551389 (Exim 4.92) (envelope-from ) id 1npSe6-0002Lg-KJ; Fri, 13 May 2022 10:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328386.551389; Fri, 13 May 2022 10:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe6-0002LZ-Go; Fri, 13 May 2022 10:35:42 +0000 Received: by outflank-mailman (input) for mailman id 328386; Fri, 13 May 2022 10:35:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe4-00025y-Q2 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 10:35:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e77a825-d2a8-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 12:35:39 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 06:35:38 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2819.namprd03.prod.outlook.com (2603:10b6:404:118::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 10:35:36 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 10:35:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e77a825-d2a8-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652438139; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=lJHeyJnjG7fXjFDIkW1UNutW9lvhGW/YvwFdrkmBUao=; b=AyY0GSbqK2hgA0KOuYl5BxzltAn7Zxk21zaPyea8+zDVsOxOW6mYSNSZ K7Ye1nsaFWYAxR2Wwm3MoZElydezxf74vJE5R418aAoZY8UE0S7tJQmOj 3ATOyk5JYeDAsiVH1tT9gY+spiE/Ybhd9X0nA60RmRIiSH63he2I7JDv4 c=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 71235114 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bGf5QaDb/2zPwxVW/y7iw5YqxClBgxIJ4kV8jS/XYbTApGhzgmYEm DMcWjqOP/mMZWfyLox2bYy//BsOuJbQx95jQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhB2 dxdpZXrYjw5FbOWvssCbytFDiBHaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcHs0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx3CKiKmQEwL6TjZor5TX36hx964Xga4v1R92URN1vwm/N8 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXOkpdGph0j4XMhQQ 2QW9TAptrMa71GwQ5/2WBjQiHyOswMYWtFQO/Yn8wzLwa3Rizt1HUABRz9FLdAj6sk/QGVw0 kfTxoy0QztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjWxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:SpXkVqtrEpkJ4mCGFB4FvKF17skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71235114" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2rqloEC8xMjxoTXgJ3LItnZeDtyBBfOoJXFVIpmbG/CmoFCFIM5jj94PRMLATYnfBF/kmb4gGio3kT3giWUWv4CSCTQ+cAWEZnBMchFhAVsZOkjRDopGd8+BrDruqRmp2gERrM696OoIDk3oZYB/HVvlxAsaMEqdOWG1V2uPQJpz7ny61t8wIerQJQizBwsJXQgE7v8rv5PxzwjjBPRM2zNicaHpe7SeIsBoDU2ZrDR9VDQAB1F2hHbJ/dLxZ8Pli4Y8JpKMreglmW9Eusi6XoQ0ii4kRkw1/WKBjt25E1A3fi/TUs/iIqz1vpJ7I3nJ0kLc6XAgtwQ4gWeKXbj1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uk9f0N1rH3Yo6aS6T6eBxtTMatId3THh2C6wf3pFK8g=; b=eKzlHTaxWyAP5ZOyibeRyhDapj0jl2bSZmF46Q8I8ER2HX2W1j7scT4Osp/YAHXvKw2dwWwrP3gT4xay3lfGjQA8N/F3UB0cgWI7MTvOKy5Y+8GNhygIbijFxpXwk+hu1zJjdZtga9Bb756e5oqmj9Yh/dIRrQMr/wVCV4XBqNhxosWmJIs3apzsbOvR39R0L/87klLwGg2zJF0cywhwHPRydCVWxzqp3dIvDwFMhZfALFOqYPOX/iXqdT/6GDB7IYoueM06omgiDTWhVY22feKK5P5o4tXncaech6CwjCpDrlQg1sFa1sgRPISX1ioXlL74vW/dGySad5sDNXiKBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uk9f0N1rH3Yo6aS6T6eBxtTMatId3THh2C6wf3pFK8g=; b=wHwX09TbYlONBoMtTB3YKFbSnPeDmzC28bWRC6vtamuPaRPxZG/uPKeaHFppZa5hTgEMwGiqHIIimdp0l5/EJse0BHPQFI6w+CDi20r8W1h3QRx73MUIAnF3VAJyFbFx6au0tFO3JhpAWPcqmc2ykDJnvjb1/Uosz5uITLN8RE0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich , Andrew Cooper Subject: [PATCH 1/2] x86/cpuid: expose MCDT_NO to guests Date: Fri, 13 May 2022 12:34:59 +0200 Message-Id: <20220513103500.3671-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220513103500.3671-1-roger.pau@citrix.com> References: <20220513103500.3671-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0144.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eacc99a1-a451-4c66-bfb1-08da34cc50d9 X-MS-TrafficTypeDiagnostic: BN6PR03MB2819:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ShDtSAjVONfmVpeeMhO/56jnV0yv0iUA45z3eGAaVjiFP2AIH6ZRlgMi4KD7E33WfLVodx0hz0Wl+LGJFOB+FLT2jPk++/ioDdUsH1OGM6hd/woiMZ3W2yD+1MFUnWzQPQQr76IPeT18KC1tFWCoOp9pUsKvK8PF6lVmwUeS6F2jVGsTpexdBJlSLEZkO/RxbJ4+inYyfTxFfv6qJ56sp4TBU1YBMlHY1cl/Sdp7lnxwzXnFQmjeNYAN2mOb/48H6ofDZSyNkJTBgnPKBNN00FK9OytttNJ8yAzFsHIy3/quka565B1Y2gNrNju2iMcY447I+Camj5yzGoamPCeeFt+kF91xiOAsNDy/m20iP1GiLLVWhmauSM4VFMA774CqBbHLdu8PSIIyFmvcsXDS90I2fdemDGuFzmfCq/beLGcx7dZfECx6M9IAz/MYvtkUMCLQLsDZT43lpkNhb5G8c4DIiBxp1gpLFY2o/HTr38+Q7bB9EHUKXpFAbwlAOthWRAMrfuOqGvV+8kULGAEhd178IpAOHtvc/ILLeWUJpZvkngKD6g4eGQue6QfzyFFD41IhwUcZ+og7YL0oxGsCtIsa3Nnpu1dW7C+PTF6Unos0INW4HoBpb1IXJDLc9LOfjFXqJRvMg/RWIgLUiXZB8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(5660300002)(1076003)(186003)(107886003)(316002)(6512007)(66476007)(54906003)(82960400001)(2616005)(6506007)(38100700002)(86362001)(66946007)(66556008)(6486002)(4326008)(6666004)(8676002)(36756003)(8936002)(508600001)(2906002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHFjcjI1d2pMWG1WTGRQNEZTeVJSa3g1L0ZCTVdKN3o1czNiK3RXTUsxN2h2?= =?utf-8?B?elZsVTAwbDU3OW9yRk9zQVZGWTZJMUx6NVF3Rk1kZEN1cnJHQ09MazJXWmF0?= =?utf-8?B?MlNMbDlibldhbUh5Wlo2djBFOVo5eXJORGVnMnByZGx1M2E5aEtGOGxCZnNp?= =?utf-8?B?VHpsckp3aUpXanBnWFpxTThiR0twTkVhQ3Q0eDFCRy9xYm1sSHA1NXdkTzlL?= =?utf-8?B?aGF6TjJUTmE0UHdIS2RYT2ZJQTg3T1NUdWM1blJnUjd1L3JiUWZhWjE4cXFs?= =?utf-8?B?emRqV0NzRTlhMDF4TVdFaXh5Vi83N2FlS09aKyt2ZjgxM3ZINncweGp0Rkl5?= =?utf-8?B?VjllQ2ZWdDdpV1h3RWN2YmpRY2kwL0l5c0hwdVpSWklucDU2bnk0TGhob0Ft?= =?utf-8?B?clpqZEFPTTJrNEs5bi80b2JDcUREcmRwaEtBNGtsclQzaVRPKzdmTjVQbXZv?= =?utf-8?B?V2FmL2o1VmV4YkRqQWxpMnJHVlpQR1UyQ1VUSzE1VUxrY0pzZjlveXNnQ0JE?= =?utf-8?B?T3Q2MHNuWVRvRjBrdG9mZi9pdDZNOXhHRXV2cEhnT2pHWkc1d1RsT1F5cnRD?= =?utf-8?B?b3IwZGI2WitpZ2JESlA5TzFRa2pOTC90ZVdNTmJaSzdMOW1DQ0dTcGRiQ3Ix?= =?utf-8?B?MHhPekliL0c2bGUwRFd0a2lzeVF3OXEwZHJmR1kxejNEamhncFF3eDJnelpZ?= =?utf-8?B?Z1R4YXBEWVBhWWZBTTFBa2dNZHVQQ0Y4dG92Vk1GRUlCblBpTFJGdERnYW83?= =?utf-8?B?c2V1L24zY1Vadk5NUWxNdEI4TVdmNjd3bHBPaUVRRmVKZzBaTXVkNUp6aWlW?= =?utf-8?B?SUxZOFZuQTVja1I2a1hvejNpY0pNMFZ2OXVQSmZXUnpaNkRHaGZSa3BOd0lI?= =?utf-8?B?QUoyTi84R3JnUTk5blA2L1hGZDNpQVlHRExIUDVsVXZWK005NiszZWNRSmR0?= =?utf-8?B?UG0vdndsWjBEYlBoTXFEVVNMVVlzTkJOZzZYTlJpV1VnQVh0ZzhjamRhMXly?= =?utf-8?B?OWtGdlRnOGZXd3BXRDI2MDJYaFMyTExST0NWaEpROFFtSE9Zc3UvY2R1TGpV?= =?utf-8?B?Qkg1bmM4VlFuZm5PUDM4OVdma1JFQk9NeW5OYTA1cU8vK1ByTVlnTkhqYmtw?= =?utf-8?B?VCtOZzRXVjVXcFRualJxdzVwMk84VzZodVhyTW4xRUU5cCtkYXc5V3RVRWti?= =?utf-8?B?T0pGU0pwa1pTeStlcEwweTVTY3FMbitxUHNsT0NOOUhzdFI2dTFFRnF2L1Zr?= =?utf-8?B?cEpKb1B0VUQ1VnorUkRFT2toZUxkNk93YWdvalNFQ3AwcktDZ2tNcHRhS28y?= =?utf-8?B?L0lOTGM5UmtjVVhXYU5uYy82ajlESVg4SkVYVVROcGQwUDByQnZNRGlKa2U3?= =?utf-8?B?Y3dxMWN0M1hNdTU1SzZkai9Lb2c5NjdLZ0tSS3BIb2NYcnFZTlNwQmVTSGN2?= =?utf-8?B?cUZWbkdQZjI5b3B0MkpZLzkvWUdiQ1pBS2JVcEM2QUJyenRWVDZ4TFdXOCtQ?= =?utf-8?B?UFE3dmducE9lSjdTRFZ3ZTk5NkxMcmJvRjRJbzczMlZJY2dIWUJPd2MzSy9r?= =?utf-8?B?N1B1RnBHL1FndXZTSURoQzlOMGE0V09pdm5RdVpUNHRKRFlOUzdtY1RLSUVD?= =?utf-8?B?Y0Qrc2RMbFZmSFMxVVdVTkJMZ09CMVZnK2Jzd1ppTENUSlI1d3ZMY09FSmIy?= =?utf-8?B?TkM3VE51cDZwNE51SHl6U1BuUFF1RHI0MkJGbHlaRlJFdzQ3RHgrUlVacEwv?= =?utf-8?B?eWhHamc0MGFKQTI0UXpydnJhRlo3blZhUjJ2TlBNbkNXWHBvK0cycUNlSElO?= =?utf-8?B?UXdTZWIybFliUWFkckVmaG5lK0pzRWdrNE5UK0h1YWNjR08vY2VkTE9hZUZr?= =?utf-8?B?Ky8xV0FJS1RtWURDd3hhSVBSbXFnbkdDZmJKOVhlTys2cGl0SE5VL2J0R1RG?= =?utf-8?B?Y0c2UmlEemUvMThDMjdKcGNaVG8rdm5sOHdPVGhXRFNoNlJYN3pCWUI4VG45?= =?utf-8?B?Z2NPRmxxMTQ0ODRtNVluRFNXQURRdlRYSnl4dHZKcU9ZdW9XS0kyZWUvVjVM?= =?utf-8?B?UmVPV2hGb1I1cVNDYjBua1VIcFIra3hEeDFWdThURS9SYjM4aFEyOFcxN1hK?= =?utf-8?B?SkpETU1EWW5wdmhGSkdrcVN2Q1RsK3BuSDAwTkp0KzhMWnBIanAvYXk1VVhQ?= =?utf-8?B?ZlBqTVlzTENQRDNBQjRDckdtRjBRZlJaVWpjWEhoTU05OUtSU1plblY5L2J2?= =?utf-8?B?VHJqNk9wV1cvT0hoeGJRS1I3NWVMWWt4WXFaWThYYjdvUlpLNUtSRnFuMnJj?= =?utf-8?B?aXhjWDIvYTJBRW1RK2VGK0VENzVxM0tUV2tvRDYvQmpaRmVUc2Z2TzlJMjJu?= =?utf-8?Q?uADxPuKZpqeMqey0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eacc99a1-a451-4c66-bfb1-08da34cc50d9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 10:35:36.2641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XuvR7IBKilHOK7LSpsoWjE8DX9cxZjM/SYsm/RNj1ty3Sptpo6xU806bYz41/Td6PJEUuycwT8V4SPWQ1yiEug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2819 Expose the MCDT_NO CPUID flag to guests if available. The bit signals that the CPU does not exhibit MCDT behavior, and as such can be exposed without requiring any additional work. Signed-off-by: Roger Pau Monné --- tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 1 + xen/include/public/arch-x86/cpufeatureset.h | 1 + 3 files changed, 3 insertions(+) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index d462f9e421..697ee38270 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -235,6 +235,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, + {"mcdt_no", 0x00000007, 2, CPUID_REG_EDX, 5, 1}, {"lahfsahf", 0x80000001, NA, CPUID_REG_ECX, 0, 1}, {"cmplegacy", 0x80000001, NA, CPUID_REG_ECX, 1, 1}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index 0b1b3333fe..bc40aa06ca 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -203,6 +203,7 @@ static const char *const str_7b1[32] = static const char *const str_7d2[32] = { [ 0] = "intel-psfd", + [ 5] = "mcdt_no", }; static const struct { diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 5aa3c82fc6..aa12280f25 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -304,6 +304,7 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ +XEN_CPUFEATURE(MCDT_NO, 13*32+ 5) /*A MCDT_NO */ #endif /* XEN_CPUFEATURE */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 13 10:35:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328387.551400 (Exim 4.92) (envelope-from ) id 1npSe9-0002cv-TB; Fri, 13 May 2022 10:35:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328387.551400; Fri, 13 May 2022 10:35:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe9-0002co-Q4; Fri, 13 May 2022 10:35:45 +0000 Received: by outflank-mailman (input) for mailman id 328387; Fri, 13 May 2022 10:35:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSe9-00025y-3k for xen-devel@lists.xenproject.org; Fri, 13 May 2022 10:35:45 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70feef92-d2a8-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 12:35:43 +0200 (CEST) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 06:35:42 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2819.namprd03.prod.outlook.com (2603:10b6:404:118::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 10:35:40 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 10:35:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70feef92-d2a8-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652438143; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=EX8DjO3x+uES7GMB/ApBUCFKRspkwrUVu39cOAc3Ito=; b=dIBbWAEazl1gZHuOjK00O+yvokLm8zxVKj3S6JQW0SJllVS1fT6Svg8l 4b9ZSvlUZwqnswMLAxa+ENpYNl3707EXzb7nRqFVpDWURPqKqiXtoipm6 64gTUAuI9ngJVn+FyskvkimHHdvOkz8B/L+t7gECQGSnPRkBtQmXqA2J0 A=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 71235120 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kMtb1a5s7PuMHHtROlF3EgxRtEzGchMFZxGqfqrLsTDasY5as4F+v jQYXGHXPfaMZTD0eoxwat/g8h4OupfSnIM1TgppqyA9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSRW1wsNbCLyd8MSjt9SDhbOfFLwL3+dC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YGjF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IB8gnI/PBvi4TV5CV0j7LcG8LJQf6PfYZVjEuz/ 2D+rmusV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/Y5lifD21dFDpZMoV45IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:xxzw7qvzHZ/3HnGxNaIBl+RY7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71235120" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctqs3a4ifXq1KPAcbzNjOkFU7dx7UEAJGAN5MLhX/TwFFhGljgYFRqoxBZod1Y38vv1SMtHijxLBogHzVQGGMMicPKF74x+Ys0qyiu3r1/AVneG5PvTnZgKJv3w3Dh8SM9jo8XX1SEgXjrrbv21trTuLRy1D52iJHcINZkDtS2BMpQDXSFwTDCuoX3cf1q9ZNIIMVYmtsID5gxJVz+o0DQuEEKeABxBNen2lAP/SxxnQ6dTv1p8ESyuB3GeRDh/Cr2WsG0IWsLlJlhdRmqjEqeSorLGA6qOgcUlcwABpV0wRxJhZeMFXYCytZKbZbfgKF2EST6uTtLAiGX2tuE/Chw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnAVvmktKCaV9DrPCyu46JyVh4QfkUF3mikDDEyic9U=; b=l16zDjWeG9Cm0gMVAtrHUInUcOKnlo9axOI68UKB6yzmkPUJbvWJyBPYpBmfPNpoDZCwlPfjs7XyazGhJnQjCK3gtHUi1SzKkQ+gxpBeaz3I+EwXwYUeTY1WHuSzu4WrWnLrWEyHuZdyRzH51IcGomFVLeaH90iuvVhzS9qZmZgp6hYCUFURUluZkOuu6AtJ6PWZDYA1ho01ywTXaBZFjnU2qaL6GwUZ2V347WWREHH9Mlb/ZKQOAjVot7o0C1ClFsDktWpKlwyadWPDr7buh8hllGsg15lXK9usUTZLU88SI8o0hyZ+/YcGnzf270kqtRY7ED8tfU1l/Zq6E4sx3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnAVvmktKCaV9DrPCyu46JyVh4QfkUF3mikDDEyic9U=; b=T2KeTVIKMzU3wWmII1o2zdRcgAY4ZwMyT0/xby8YZtyoHb5fWfTzqx0rB+6fT9MTMGjVLaZ2AnZcrHR5IKi9LvhzU+n8UzFCuBSt9Q8Vt01zsyKOqKLX15oj79N2wrrXU5EaBjh69Te+oPkC0kS6knBo0MQnhJvz8MwcR1qDKxQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Date: Fri, 13 May 2022 12:35:00 +0200 Message-Id: <20220513103500.3671-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220513103500.3671-1-roger.pau@citrix.com> References: <20220513103500.3671-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MR2P264CA0129.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 219da0fc-074d-4881-6af1-08da34cc5394 X-MS-TrafficTypeDiagnostic: BN6PR03MB2819:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K99q5Wn4884eSMyR5rWfx1+tuOTCbfinK5gGYOMdn8DKqyhKZhk+XTAlmJiIiWL0VRO3sSp1aVLmGGMR4GhjgsniswIN42ExQhjuHT4nzyp+yzAjTW0zMLwmXrxKe8rR3ibwhOejGUe1QKbSSelKHoWO+3VTMm3/GQ2N6JkLasYexV3kmdXRSOlDBNOCz1l6GAxYZVVAgqqCgS8XnEqRHAzOXhmW4Cl+B80eaPM0Aw2LhBO7mJ58i047jPcD8RO7UT/ialVKDNbyQjY423NC74NI0rk4aTZKBKShpIizQ5BzPrpe7dM8MSCEGGNmBCPLvezVTJ1AxoRQUTYYD6oCUGXrdte2m6+q/IBnj90m9WzRaAJsJzRMBU99Mu3bKUkizj6F3FeiRSIoiRDXLs0H0p4Dor/caIsK2meJLZiMStNXJgwzU0ePbtJXlYweNraD0nNtcUpwysPel7kQysKfBnr8AyhkAO8zYiIIeTISZnz9VIxLJdDyYg33nv+H8ZBwAOG+7bw/hPfywp5GD/dcHtYUVH/7SURBM5zw7Z2EnxmCAHFKVKUGN6Uaeid+X7GoVQZaZNyAKty1RUeevpvtaxCp4sGiDvhFgiAZMSce8x92kMxPVYCb36M0t2YkcQa18m1GGhN2sYzZwuji3b5nAtOdM730rOz9CZYC9zzdeYYs9DSw+DHoFPpBj14Rq/QD5NRegk8O+wjvBnCLK6hB3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(5660300002)(1076003)(186003)(316002)(6512007)(66476007)(54906003)(82960400001)(2616005)(6506007)(38100700002)(86362001)(66946007)(66556008)(6486002)(4326008)(6666004)(8676002)(36756003)(8936002)(508600001)(2906002)(83380400001)(6916009)(170073001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGQ3SGE5dVZYc243SjYxZE9xay9VZEl4MlE3RVh5c0JkRFpHTnNDRytIMHF6?= =?utf-8?B?N0Jlb1FXRzQyTlZ4ZEhaTlRxayt4OXFCQlhtN1RkV0t0TFV0ZVU4dytUbzIw?= =?utf-8?B?OTFvbkJ1Q3RxWHpxTjhtbXlCQ00yQUJ0YzNYN2c2VUhaK0JDZTh5bzJuOEM0?= =?utf-8?B?RDRleFRUbzdqU2g1TUp0alI3T2JwRFpxU0s1VTFOWXFyaXFFZG1tMEhUeVpa?= =?utf-8?B?YjB4c0Vzb05lQnpLaWZoYVR6UXNKSDFWS1lha0llZWVmOHozZWJDOENScVlk?= =?utf-8?B?dUhDSUVmVzVXNzVnTHhoSHcwM0VWSElZdnlWdUhad1VWWDNBR2pSMGFicTcz?= =?utf-8?B?YmhaTUFGeTBEOFRraHMrTTJqbXpNMHJOUUZRS2JYZGJ6T1krUHFwNmZsdEFu?= =?utf-8?B?SVYwRWZ0R3grbVJiTzlBNlhFSmNQY2Q2dlpKbEg3K05zdUlNYVVxaUlQWGZH?= =?utf-8?B?VUt2OUpXRWg0U2twR0pqL29yREx6ZFpuamp5S0dzVjM2R0daRTRMcHJsTmRo?= =?utf-8?B?OEk1RWtaeXJOZHRSQjljR2d2R2NKemQwQVdpR3hBTDgzbm11VFo3aEZxQ0NZ?= =?utf-8?B?bk9KMkpwVGt5Vm9uanB1SVhVNTM2dFE1S3RpLzFNYzdRdnZUMXpHNWswenQ3?= =?utf-8?B?aVJwdnBDRy9ZUWo4Qk4wV3JCeDhudVhzTDZ6K1J1YSt3UGxTL241eTIxKzBW?= =?utf-8?B?bDR6aVZYTUxQN3k4bWJubTQxN3JNdEpFZVJ6OWRmS2RxdENJYTJsK3JTOXI0?= =?utf-8?B?cnVQS09xZW53dG5IaTF1YXpHekxuN3M1QUNDYVNPSnYxbmNKSjZPbVhyYWJ5?= =?utf-8?B?Q3BSdlhvWkRuUlE1ZEF1VmlPTis1SStEeVp5N3duTXE4ZGUwR2RtamxCTjk2?= =?utf-8?B?MDVYdFAyMGVXOUl1R1Iwcm96cUlzZXJYejNvWnB0MDdaMlhyWnhuUkR1UjlM?= =?utf-8?B?Yk9nSzc0SVdSWmtSQzhxVndJZ2JiN2ZueEM1V3lBdnVuMWk5M0NJZEN3WlZa?= =?utf-8?B?aFMyejBSY095TWZabFlzT0JyVVJjZDdXR25HYURLRFIxd1ozVEFRNTUvOWZW?= =?utf-8?B?bG5seGVBUmFMWXREbnhGVk4vS2h4akN3UGh3bmtkNlFwRGlkVTBKWDJpK1Zs?= =?utf-8?B?UFNaNHNFUkRia0hOeVRBMXFCQU15Q25VcmoxL2wvVU5aOVlCbGRXZldLMUdC?= =?utf-8?B?U2dvKzEveHhQWmU1TFhGQS9sc1cxTFVndnNBL0t4NitUR29xaU9YeUNiaEU3?= =?utf-8?B?NldHZXlIeWpVTmdTb2VzcEdMQTlhQ1B5ZGlyazBUWUQ4OW92Zm40TTh4OHRO?= =?utf-8?B?V3RiVjE4ZnV3SlFEMFdwVkZxWnFLZis4ODJLSStuZXZSbzdDcU9uaFNPWHJN?= =?utf-8?B?TWR3Z2FERHRxZjEwanM4MCtWZHRScXcvMWZXZEZ3dkxhVkovV0RxQldMVFN6?= =?utf-8?B?M05nWGNvWmQrOVcxTGR0Nng1OHpOVHlPdUZtbFlhNGRmUUVrbEVIZnk4RVc1?= =?utf-8?B?MGtpU0dqc29QLyttRDJlc1BkQkE5QlBielNlVVhnMW1UbG5jNDlrSzg0ZG9O?= =?utf-8?B?eUJYZEtYMDFIenNGcDFqNm9oWGxLRzhucmE2V0FKUlVvamMxU2lwS2s3MFNQ?= =?utf-8?B?c2NrbG85cWZmQWp1ci9CQWVJTXBtTWt5QXFIY0Fhc0JGb2dqK2RDajVWR0h1?= =?utf-8?B?cjRyV05JMWdabXdndHZYQmVFOSsxa3lnWWdVVjR5dThVQzY3N0FuRXNkZkU3?= =?utf-8?B?YVNVbUJMMnlsblZDVTl3Y1Q2M3hLa201aU5Ta3pWRkswMTNiN1ZTS0V2elpJ?= =?utf-8?B?RHpGdm9XRkR3REI2THdtbkU5WnNac1QyTXA0YnBzam1uNHpFNmNJMFNveFd1?= =?utf-8?B?YlphQWUwb2lWWkV4V0Z0Nkl5QmRXc2YxVEFMdWdKN2lDcGFuWDczejlBVzNG?= =?utf-8?B?Sk5SLzRRR0dvdnhQU3FkYkVHVHpkblA1OWJWaU5wMzArSVl3cDBnOXZwKzN3?= =?utf-8?B?SDN0UjE2VW13cU1oU0JiaWtDQmhHa2lUelh2UXNOeStZVktGNDE5cnNOT0dB?= =?utf-8?B?dW9vZGpWKzVIbUZpcDd0QmRkN08wWFVjS1BpaWFBVzRudXFsR01ZRURPdUVx?= =?utf-8?B?VTkrQ3V1eUh6TVRFUlYvUlhwTXRESGdIM0NRam5Zb2NjeW0wTVJTaFhUMy8w?= =?utf-8?B?dGRrekRQbGsxNktKYURUdVVBazBZblFubnptckhkbGhCSDZCVDJLM3h2Z3pL?= =?utf-8?B?K29YUkhBSFZHbzM4NnZoN0ljb2dKZjF2K016WWZLRnJiT2tTWHBLTzdMOE9x?= =?utf-8?B?QlkvN2ZXRk10bEZ0Z3F6a2FVWE1pa0RSV3Y0akFyREQ3R1JPUEtMWkxZbmJ5?= =?utf-8?Q?NvgQ5uRqOmBqACwQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 219da0fc-074d-4881-6af1-08da34cc5394 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 10:35:40.7179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ciPZTdK/kbBdDd8bPKZCn/W54S3eawlDeHP5uRQ1hRNoiGFTOqckFJMQ6Nr7JKIOfEI5kgs9R1kAzzcKMQ6H9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2819 Some CPU models don't exhibit MCDT behavior, but also don't expose MCDT_NO. Set the MCDT_NO bit for CPUs known to not exhibit the behavior, so guests can get this information, as using family/model/stepping detection when running virtualized is not to be relied. Signed-off-by: Roger Pau Monné --- xen/arch/x86/cpu/intel.c | 70 ++++++++++++++++++++++++++++++++++++++++ xen/arch/x86/cpuid.c | 10 ++++++ 2 files changed, 80 insertions(+) diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c index dc6a0c7807..d821f460ae 100644 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -518,6 +518,73 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) printk("%u MHz\n", (factor * max_ratio + 50) / 100); } +void update_mcdt_no(struct cpuinfo_x86 *c) +{ +#define FAM6_MODEL(m, s, c) { 6, m, s, c } + /* + * List of models that do not exhibit MCDT behavior, but might not + * advertise MCDT_NO on CPUID. + */ + static const struct { + uint8_t family; + uint8_t model; + uint8_t stepping; + bool check_stepping; + } mcdt_no[] = { + /* Haswell Server EP, EP4S. */ + FAM6_MODEL(0x3f, 2, true), + /* Elkhart Lake. */ + FAM6_MODEL(0x3f, 4, true), + /* Cherryview. */ + FAM6_MODEL(0x4c, 0, false), + /* Broadwell Server E, EP, EP4S, EX. */ + FAM6_MODEL(0x4f, 0, false), + /* Broadwell DE V2, V3. */ + FAM6_MODEL(0x56, 3, true), + /* Broadwell DE Y0. */ + FAM6_MODEL(0x56, 4, true), + /* Broadwell DE A1, Hewitt Lake. */ + FAM6_MODEL(0x56, 5, true), + /* Anniedale. */ + FAM6_MODEL(0x5a, 0, false), + /* Apollo Lake. */ + FAM6_MODEL(0x5c, 9, true), + FAM6_MODEL(0x5c, 0xa, true), + /* Denverton. */ + FAM6_MODEL(0x5f, 1, true), + /* XMM7272. */ + FAM6_MODEL(0x65, 0, false), + /* Cougar Mountain. */ + FAM6_MODEL(0x6e, 0, false), + /* Butter. */ + FAM6_MODEL(0x75, 0, false), + /* Gemini Lake. */ + FAM6_MODEL(0x7a, 1, true), + FAM6_MODEL(0x7a, 8, true), + /* Snowridge. */ + FAM6_MODEL(0x86, 4, true), + FAM6_MODEL(0x86, 5, true), + FAM6_MODEL(0x86, 7, true), + /* Lakefield B-step. */ + FAM6_MODEL(0x8a, 1, true), + /* Elkhart Lake. */ + FAM6_MODEL(0x96, 1, true), + /* Jasper Lake. */ + FAM6_MODEL(0x9c, 0, true), + { } + }; +#undef FAM6_MODEL + const typeof(mcdt_no[0]) *m; + + for (m = mcdt_no; m->family | m->model | m->stepping; m++) + if ( c->x86 == m->family && c->x86_model == m->model && + (!m->check_stepping || c->x86_mask == m->stepping) ) + { + __set_bit(X86_FEATURE_MCDT_NO, c->x86_capability); + break; + } +} + static void cf_check init_intel(struct cpuinfo_x86 *c) { /* Detect the extended topology information if available */ @@ -556,6 +623,9 @@ static void cf_check init_intel(struct cpuinfo_x86 *c) if ((opt_cpu_info && !(c->apicid & (c->x86_num_siblings - 1))) || c == &boot_cpu_data ) intel_log_freq(c); + + if (!cpu_has(c, X86_FEATURE_MCDT_NO)) + update_mcdt_no(c); } const struct cpu_dev intel_cpu_dev = { diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 66be1a8015..ca2ed44149 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -360,6 +360,16 @@ static void __init calculate_host_policy(void) p->basic.max_leaf = min_t(uint32_t, p->basic.max_leaf, ARRAY_SIZE(p->basic.raw) - 1); + + /* + * For Intel hardware MCDT_NO might be set by Xen for models that don't + * exhibit MCDT behavior but also don't have the MCDT_NO bit set in + * CPUID. Extend feat.max_subleaf beyond what hardware supports to include + * the feature leaf containing this information. + */ + if ( boot_cpu_has(X86_FEATURE_MCDT_NO) ) + p->feat.max_subleaf = max(p->feat.max_subleaf, 2u); + p->feat.max_subleaf = min_t(uint32_t, p->feat.max_subleaf, ARRAY_SIZE(p->feat.raw) - 1); -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 13 10:43:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:43:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328407.551411 (Exim 4.92) (envelope-from ) id 1npSlL-0004jw-R6; Fri, 13 May 2022 10:43:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328407.551411; Fri, 13 May 2022 10:43:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSlL-0004jp-Mr; Fri, 13 May 2022 10:43:11 +0000 Received: by outflank-mailman (input) for mailman id 328407; Fri, 13 May 2022 10:43:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSlK-0004jj-GG for xen-devel@lists.xenproject.org; Fri, 13 May 2022 10:43:10 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ac4db84-d2a9-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 12:43:09 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id t25so13772137lfg.7 for ; Fri, 13 May 2022 03:43:09 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id x4-20020a2e9c84000000b0024f3d1dae8esm388198lji.22.2022.05.13.03.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 03:43:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ac4db84-d2a9-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=6sXboJ1IWrFfaZL2CwvKWBto1jYzvNRlolwzbKkJnzI=; b=O7IrsLiI6m+XnVXL609wbEZd46wLeUQTt11dOyDyb0m3qmultIKmwLTgLEc8uZKPkz oRVFNrS9W09pQ4KsFgRpm6cOj+dvHzUx2y4L1n+jNSjeWv11Q73apCVW76PkYSzRKcks 82OTQqbzDdxYA1kDqW6s6/pgZLzyPA2pMKtsiLflLcsS26esBBbgzAebIQRHoB8q/XDa J8u+Y+xqBuigPblfPvo3H2DENlKFeofiTc2i+0wgT+8ntV0CsQaAthZlBnlIxWaDD4FU DdMIoAF7qJz3f6jtwmNN53zpMjgR/H5//deFyfs0IJU1yqMnax3Il/kEYWyNCMiTPnq4 0fnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6sXboJ1IWrFfaZL2CwvKWBto1jYzvNRlolwzbKkJnzI=; b=TC+ECCr+VzuLub/g4AYvt3wDmfgoS6EGskvUPE4YXG5UHSOXb85uCqB6ZHVtoU4a7j PGWizoasQk+k4PiaQx8DZliVtz8R3mg24QrgsjLlMsT6o3/Vuq5ejRQSJ+pRm429WQUh SMZ0IQQoRGKPDDucSsxo0CaIRGSWMk24Sw+mvpb3lWIJNHfvssZbGdqOZaThoO1jgEu3 e14Pw+t9L6oTXiNQWFedo06bAg0qOTGPIPKbcRhZu8Bd29wootEa/VxLNixRHqxH+Kgt mnjIIZ7B6WYLMHbTfteJ+g4b+QchJo+gFlxN9YZ1JaQKCiMUn08Z2J6J2ArmlSv/x914 mK4Q== X-Gm-Message-State: AOAM531Fo5FRXnsB0om9F4mPszw/Le6uircDc4LmyVgUz5M4t7TzotPh l2hfUZQbj1VR83LgKA+0g5U= X-Google-Smtp-Source: ABdhPJxvCY8n6V16nGeI843LAEA5SzPc7sIbEPwvo4gLBMAfPQogJJiWevnffE3lSSwYRwuInpsqWQ== X-Received: by 2002:a05:6512:3157:b0:474:2ac5:63d with SMTP id s23-20020a056512315700b004742ac5063dmr2934962lfi.367.1652438588735; Fri, 13 May 2022 03:43:08 -0700 (PDT) Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants To: Juergen Gross , Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> From: Oleksandr Message-ID: <263070e7-0043-1c5f-ba14-8ca7bb4ca6a0@gmail.com> Date: Fri, 13 May 2022 13:43:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 13.05.22 08:33, Juergen Gross wrote: > On 12.05.22 22:01, Boris Ostrovsky wrote: Hello Juergen, Boris [Juergen, thank you for your explanation] > >> >> On 5/7/22 2:19 PM, Oleksandr Tyshchenko wrote: >>> + >>> +/* >>> + * Handling of free grants: >>> + * >>> + * Free grants are in a simple list anchored in gnttab_free_head. >>> They are >>> + * linked by grant ref, the last element contains GNTTAB_LIST_END. >>> The number >>> + * of free entries is stored in gnttab_free_count. >>> + * Additionally there is a bitmap of free entries anchored in >>> + * gnttab_free_bitmap. This is being used for simplifying >>> allocation of >>> + * multiple consecutive grants, which is needed e.g. for support of >>> virtio. >>> + * gnttab_last_free is used to add free entries of new frames at >>> the end of >>> + * the free list. >>> + * gnttab_free_tail_ptr specifies the variable which references the >>> start >> >> >> If this references the start of the free interval, why is it called >> gnttab_free_*tail*_ptr? > > Because this is the tail of the whole area which is free. > > It could be renamed to gnttab_free_tail_start_ptr. :-) > >> >> >>> + * of consecutive free grants ending with gnttab_last_free. This >>> pointer is >>> + * updated in a rather defensive way, in order to avoid performance >>> hits in >>> + * hot paths. >>> + * All those variables are protected by gnttab_list_lock. >>> + */ >>>   static int gnttab_free_count; >>> -static grant_ref_t gnttab_free_head; >>> +static unsigned int gnttab_size; >>> +static grant_ref_t gnttab_free_head = GNTTAB_LIST_END; >>> +static grant_ref_t gnttab_last_free = GNTTAB_LIST_END; >>> +static grant_ref_t *gnttab_free_tail_ptr; >>> +static unsigned long *gnttab_free_bitmap; >>>   static DEFINE_SPINLOCK(gnttab_list_lock); >>> + >>>   struct grant_frames xen_auto_xlat_grant_frames; >>>   static unsigned int xen_gnttab_version; >>>   module_param_named(version, xen_gnttab_version, uint, 0); >>> @@ -170,16 +194,111 @@ static int get_free_entries(unsigned count) >>>       ref = head = gnttab_free_head; >>>       gnttab_free_count -= count; >>> -    while (count-- > 1) >>> -        head = gnttab_entry(head); >>> +    while (count--) { >>> +        bitmap_clear(gnttab_free_bitmap, head, 1); >>> +        if (gnttab_free_tail_ptr == __gnttab_entry(head)) >>> +            gnttab_free_tail_ptr = &gnttab_free_head; >>> +        if (count) >>> +            head = gnttab_entry(head); >>> +    } >>>       gnttab_free_head = gnttab_entry(head); >>>       gnttab_entry(head) = GNTTAB_LIST_END; >>> +    if (!gnttab_free_count) { >>> +        gnttab_last_free = GNTTAB_LIST_END; >>> +        gnttab_free_tail_ptr = NULL; >>> +    } >>> + >>>       spin_unlock_irqrestore(&gnttab_list_lock, flags); >>>       return ref; >>>   } >>> +static int get_seq_entry_count(void) >>> +{ >>> +    if (gnttab_last_free == GNTTAB_LIST_END || >>> !gnttab_free_tail_ptr || >>> +        *gnttab_free_tail_ptr == GNTTAB_LIST_END) >>> +        return 0; >>> + >>> +    return gnttab_last_free - *gnttab_free_tail_ptr + 1; >>> +} >>> + >>> +/* Rebuilds the free grant list and tries to find count consecutive >>> entries. */ >>> +static int get_free_seq(unsigned int count) >>> +{ >>> +    int ret = -ENOSPC; >>> +    unsigned int from, to; >>> +    grant_ref_t *last; >>> + >>> +    gnttab_free_tail_ptr = &gnttab_free_head; >>> +    last = &gnttab_free_head; >>> + >>> +    for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); >>> +         from < gnttab_size; >>> +         from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + >>> 1)) { >>> +        to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, >>> +                    from + 1); >>> +        if (ret < 0 && to - from >= count) { >>> +            ret = from; >>> +            bitmap_clear(gnttab_free_bitmap, ret, count); >>> +            from += count; >>> +            gnttab_free_count -= count; >> >> >> IIUIC we can have multiple passes over this, meaning that the >> gnttab_free_count may be decremented more than once. Is that >> intentional? > > After the first pass decrementing gnttab_free_cnt, ret will no > longer be less than zero, so this can be hit only once. > >> >> >>> +            if (from == to) >>> +                continue; >>> +        } >>> + >>> +        while (from < to) { >>> +            *last = from; >>> +            last = __gnttab_entry(from); >>> +            gnttab_last_free = from; >>> +            from++; >>> +        } >> >> >> I have been looking at this loop and I can't understand what it is >> doing ;-( Can you enlighten me? > > It is recreating the free list in order to have it properly sorted. > This is needed to make sure that the free tail has the maximum > possible size (you can take the tail off the list without having > to worry about breaking the linked list because of references into > the tail). I think the loop deserves a comment on top, I will add it. > > > > Juergen -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri May 13 10:53:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 10:53:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328414.551421 (Exim 4.92) (envelope-from ) id 1npSuz-0006Cf-O4; Fri, 13 May 2022 10:53:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328414.551421; Fri, 13 May 2022 10:53:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSuz-0006CY-Kt; Fri, 13 May 2022 10:53:09 +0000 Received: by outflank-mailman (input) for mailman id 328414; Fri, 13 May 2022 10:53:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSuy-0006CL-FX; Fri, 13 May 2022 10:53:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSuy-0005sd-9J; Fri, 13 May 2022 10:53:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npSux-0007UL-Ur; Fri, 13 May 2022 10:53:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npSux-0000ZU-UN; Fri, 13 May 2022 10:53:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rfYpTQ1gBtfXvutjPTvwt3wTdBpKEUdodUSkVMx0krg=; b=lSKrsCIuavllI09/WlmBPEQObN 5i0LbayCXHodsYu7tdKxbTCD8yOHbXXYYyq6nptyPUAWy4w/ZVBCF0sStmbbJ3/k9eoxVfG93TpnX +pztn/fDDrLZMidd1UG/xMeyxeMHOHaJ6o6q9i86/nutnmLW6M/VFSL0znvxBGnccKEI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170379: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=56ab5c3ae956d2bf7d2fe32d3703d5ac5f79a1d9 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 13 May 2022 10:53:07 +0000 flight 170379 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170379/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 56ab5c3ae956d2bf7d2fe32d3703d5ac5f79a1d9 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 672 days Failing since 151818 2020-07-11 04:18:52 Z 671 days 653 attempts Testing same since 170379 2022-05-13 04:19:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107278 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 11:06:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 11:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328423.551433 (Exim 4.92) (envelope-from ) id 1npT7e-0007kT-0L; Fri, 13 May 2022 11:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328423.551433; Fri, 13 May 2022 11:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npT7d-0007kM-TJ; Fri, 13 May 2022 11:06:13 +0000 Received: by outflank-mailman (input) for mailman id 328423; Fri, 13 May 2022 11:06:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npT7c-0007kG-0P for xen-devel@lists.xenproject.org; Fri, 13 May 2022 11:06:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afde5245-d2ac-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 13:06:08 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 07:06:05 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CY4PR03MB3174.namprd03.prod.outlook.com (2603:10b6:910:52::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 13 May 2022 11:06:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.016; Fri, 13 May 2022 11:06:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afde5245-d2ac-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652439968; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=TPE6nr08wsc/uc0khMah1jE/pV7ZxtFH9MiJM3wv5Hs=; b=RYiephJ7IA5MBffFiZv6diPEYCwvPX5a3lGO32a9ZU0j1mm88mlCVadu M0wErQKooeoMpmYQh9OK15nkYuDiMe4RvHSEibAotq3jdaWgsAEc4WZif JN5V8d1KzTXKKPV8s6Qx7cQ9VRkDI3DRJ7I9ZsBtCw22JL3yoIUNxupTV Q=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 71236744 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:k2vokqmEDKWzqIkTBJAd8Z7o5gyDJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIeX2DVOP7fMGf8eN1xOtvk/UwE7cfcm9Y1TAFtq3phRSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWljV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSkQgO/H+pb0ncBBYCzNTHLJCxJrWLi3q2SCT5xWun3rE5dxLVRhzFqpBv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kBg25YasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVuuTONk1AtuFTrGPnOI/WuRNQNp2aRl 0fU8mLVHA06bdPKnFJp9Vrp3IcjhxjTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ 2QL/gI+oK5081akJvH/UAe/u2WspQMHVpxbFOhSwAOHx7fQ4g2ZLnMZVTMHY9sj3PLaXhQv3 16N2tjuXDpmteTMTWrHr+jN6zSvJSISMGkOIzceShcI6MXip4d1iQ/TStFkE+i+idid9SzM/ g1mZRMW39075fPnHY3ilbwbq1pAfqT0czM= IronPort-HdrOrdr: A9a23:6SUs+6j41YSFVj7BPhBDFB4n6XBQX4N23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqaJbp0 X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71236744" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yi06OW1YhEN3eGzKxtr6VeDB3nHAnP37rg8eYZMb27hPsG+mYsYin20vgL56TxtoCRs6bEY1dLqX6JfnlBonc8zvw2skjYM/qk9ffJMpQt4gwvCmGPMKj5NV579O4KIpua8uULTg/MzRdKIkNPbTy/OgNbrMqV8xf/TelB6WXAifcAEidtlZUu8WebCs70xvQrfcKQtcSqV5g6PIGLYjBHZMKkMyHWmPiWOr16R2pp8RwQC5+AtuetIjBlKD5ITlGN/Mf0X8AB0fh09WNcCqRe9Sl8TJi+6rJCYSt/RDu6ryKdqcEY8/j1yBKTCeGzQ6Jxf52eYM3Yx/qWg7tKJk2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPE6nr08wsc/uc0khMah1jE/pV7ZxtFH9MiJM3wv5Hs=; b=UsdXOuQqQSkCGX5C2hpLsPH73s9JvpvoR1vCT6xK/nzZx4l3get/iKx1SQ50hu9Y70cFGlIzO0aR37L6oxQR/GUVa1HON8BLbokINL0KvaZsJjuEn005JZvChQ4oT8bvD5mOzTopwt+RztZGrQp3Ptka0bOUfMomQIos1/42pfk886UcGqQmkXgmDvfWoenXvZO1xexPwcUheaZMhCn4+K/coAtN+OeN0F1OwWiqwC0NfTjsh8veDFyKXtf8Z1MYgTHhZ1ZFDMjDoLiLXGBi3u2SIduJMyESdaqbWsYdqXMohJV+i9HZnDspysz4S8OPI3zdyI5FiaRDBhGvDTC/Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TPE6nr08wsc/uc0khMah1jE/pV7ZxtFH9MiJM3wv5Hs=; b=UEJES2T+Hq1P6gUCykDe0DtVanTxAjV6OS5rfQ7TGYWnodg8OejliPC7HQ4h56N7xbqVfykU5Whns8KqqTowDpKn4YEggj1Hb3av68ZvdXUihNaBJ2XjUyYcwrkU37Wei8lng+vSgW3miNQ2q2RnHrTudM9flumtf/smKfwXsRc= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony Perard , Juergen Gross , Jan Beulich Subject: Re: [PATCH 1/2] x86/cpuid: expose MCDT_NO to guests Thread-Topic: [PATCH 1/2] x86/cpuid: expose MCDT_NO to guests Thread-Index: AQHYZrUv4rDZrXUYNE2NF4UBHL3/X60cpXAA Date: Fri, 13 May 2022 11:06:01 +0000 Message-ID: <15d66a71-33d5-c866-e57b-be0f42d1ce5b@citrix.com> References: <20220513103500.3671-1-roger.pau@citrix.com> <20220513103500.3671-2-roger.pau@citrix.com> In-Reply-To: <20220513103500.3671-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 175cbe30-7d12-4158-3888-08da34d0912e x-ms-traffictypediagnostic: CY4PR03MB3174:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: se/2KeRulSxuf8HKrSlKX4iHLi5F9QmGiFNuPaoOic2kUCp3M9/KeIcHBzAgpyVcNvW4BsrRpSzR7OUFR8EApyjKi5/cgtI30HW7CgmcfqDM4X3jHdF62ZyDlGjzekwKE1VJV106/p/goE842rYnZfSozy7d2QGUq2iRr67et3+w0BwS6TL3w8CQPNIdkGSx7K3WyjE94kxY7AQq9s2pSz5kogTfsmV2LDjOS1A1CB0lKd33V4fYe8sZYLtkVn9h8p95T6PUis52a0IctXGrmzDeGtbT4RuvSUBZQc+rpMmWln1S71nub/siMXbEvwdfixbC4eVzawn8ZfFRPo2W/FNoACyx4tgviukIluiw0CN7z9hhJmAXkY+BGyj8w8iYO5cUybmITPZxL9BnwOKBtG6iVRL6CpROOtyuzebOQxxNvqs4vuZRxk7mJ3imXlz1uxJawKeBDVXV3nJomUC5gDmTIeJatjusOzsircmnw7a2vN1X9hDTYFP+09+te4CHAWOjPVky6xFmkWfmm8bZbkNWzgVJntd1Lex7ynRlppH0gRmltme6KuK0GovGRWcCoLzdg/dp0+oyKGVOssvtV2YCEJ4178eWC+O+5CVJUkdLGCGECAeKMIThxYuX4X+8lVl2fBHrmIHnlcZhhZqaER8oWcScgmYhdpNSWFr82jdGlLUVeDOiP3ZFB3NbE6VQkLrK3W5yOYk1a+wScmZhJln8ENoS60LVWZGVkOtCuqnTs0RB8OQsLCNoLWVM3MZlJAdZONtCTGgRhAmaWhCxYg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(2616005)(71200400001)(8676002)(4326008)(66556008)(66946007)(76116006)(91956017)(6512007)(64756008)(66446008)(66476007)(26005)(38070700005)(38100700002)(4744005)(53546011)(6506007)(2906002)(5660300002)(6486002)(508600001)(31696002)(122000001)(86362001)(8936002)(82960400001)(36756003)(110136005)(316002)(54906003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eXRlUjRWemJrc3RTMnpwakF0cnBIcEpoc25MbHQwYkdweHJkaFlsZVpsN1ZT?= =?utf-8?B?U3Y3dDNUUlVoTm1CZWQ4NXdBRENSTGpzbmg3Y1lLMWlJS0dNU0Z6bjhreWFq?= =?utf-8?B?RExTSzNtN044eFcvb2RjNTJtdVk0R0RTRkFWMkVjcURwVHA2QmEyVHQwR0xr?= =?utf-8?B?TWgzdjJXSGE3ZG5ZOGN5YTNDcGJYYlRsMkx1c0xLUGh6VnB4UGE2dHNaenB1?= =?utf-8?B?LzBpa3V2VjE2R0dkZnd2aFdxYlpsWjMxdXB1ZHVrdDkvbmhteDREakEzL21R?= =?utf-8?B?eDBJTm9pZnF5T1BIZXFTcUI0eGd3NkZQL2ZuTnFsbDk2WldlMlNqd2tnbGc5?= =?utf-8?B?S293QjZCMjNCcXhWMjduRkVhMGdxV1l4K0NPNDN2RXFkOHN5SVN5bHc0VG9x?= =?utf-8?B?ajRDYk8wY2V3bFVsRVc4S255UFBnNkVQeEM3MHJqZEdJVzJ0SlpIZnh4cnp3?= =?utf-8?B?elNyWlRkVWh5QzBPWTNGUWlIZC9sZFN6RkZVRnQ2TlpRQWpPNUlrRko2TlNO?= =?utf-8?B?T1pJSktDbFF2LzFtMGdPYlMxeHI1VXZKRHhTdHE0dWlrOHRuaHhwYkdqSlNy?= =?utf-8?B?Z2IzRWZWaUN3Z1RkZlI4MEFhemdOQkZ2T3F5VUhsZHRDdDBQQ2x5YllUYWhw?= =?utf-8?B?eTRybHZBM1BuZU1YU21TeDlHUFJkcHZLaVMwYlN4VWdoWHRIeHd5M05Ndy9L?= =?utf-8?B?NlRTN3U3VThlS21xSEpwRHd4czk4OGVIdzdKcTY4WjRVRlpFMkZXczJDU2NP?= =?utf-8?B?RGRzYTVOdFByRnJpMjlvTERJU0hBL1Yxb0dJdzJEeWNRUUJGRFpINWJTVnEr?= =?utf-8?B?NUlzOE00MFF1WDFXcTdnbG42ZEc3RlRSckhmNVRjdkt0ZGpESDlRbm56QVhD?= =?utf-8?B?bCtnSWM5NGZVOVNISktyQmNzZlRvRjZXZTZTTzJYdTNaaTJsYW04cmdNQklq?= =?utf-8?B?d3dkUnNXcThmMnNORHJUaXJmUFhGa2tBL2wzK0tBa0k1cUtsOFRkT3dLMC9K?= =?utf-8?B?QnF5SytxTm5QeEdEd2xXaGVkQVBsK0toKzJrd1lPWDJEaUxXeENuMm82Qktz?= =?utf-8?B?WitwVHZ6VUk0dGd5RlplMEg1MlRNMVZ3ZVVKTytFN2RsSEFiL0N2c1N0S3V2?= =?utf-8?B?VTJ4SldmcExLOFVUaTFiSjZxL1JqakZRSWRiVWhlL1FHUkdDMWlFOHI2YU1K?= =?utf-8?B?Nld3UnRYSTJWaGZwL0JVWS9xdkJEMkU2OUpTdy9OZHFTVGQrbklYU1M5L3RQ?= =?utf-8?B?d29rQmJxYTg0Um9LdGtiL3B2RVErdEtYWmZITUJ2ZVpVZDZCYU1md2xnTWU0?= =?utf-8?B?ZGQ5VVFyWW5lNXFrL2tjQUR1ZTY1Y2xFKzRvaFhwZXk0RVlxUXVUY041UW9N?= =?utf-8?B?TWZmNVlmS3FTUHU4ZjNSZnUwRWM4UzAxTXZLY0Q1eDQxK2dYM05NbnRKM1Zo?= =?utf-8?B?U1JPd1VQOE1rd2xielhNWkE0b2IvbER4dnJaY0x5USs1NE9OWFR5K2VjRU5C?= =?utf-8?B?NlI4TmI1b2htMC9EN3NhT28zMzdQR1E5QS9xYU1ET0J5YmN5MWZGd3dVMEZa?= =?utf-8?B?NnBsRzlpTjJ1T25LOHdKYmVtM3dlTTJERVVIUDlONXBSVG9pa3UrTGVQRHZG?= =?utf-8?B?NXdXRkNWSjZ0THA3OFloVlFRVWZ2L255NTVXTU9KZUxpcVl4WnllUjZRWUIw?= =?utf-8?B?YS81TC9qL0JGWTd2bTRFbDlLRUF5ZzhNUzRMUUhneGJ5eHBmRzBOaWNjNTR4?= =?utf-8?B?aVNzUVZ4elhjU0hVd2xadWltLzhiVEJQWkRVdU90RjNGUmhMblhCQ081VDFR?= =?utf-8?B?Y2t5MXN5aDQ1V2RZODkrOGhWdVA2QkN1dUhoTWlveml4dUNtL21vSjFNbzVl?= =?utf-8?B?NXRpdjZ3OE8zdFg0czNiaU5CUUNnVkJpNzBleEkzM3lDTlh0d3N4dzl2cnpR?= =?utf-8?B?a0NBWFRnL3pmTDVUTTFidVNsN0xHYTB4QmFrekpoYzlMTXlvWnB4cVpTODND?= =?utf-8?B?czdndmdETXdEYkxxNHBaWFNkZ0dKVzV4SFlTUmk2V3BNUHozalZ6RERLQm8z?= =?utf-8?B?TExTT1ZLbzVPQkR5T0o1OTBiU0hnT1dSTTdLQnM4ZDAzemRTUWk3K09Qa0hB?= =?utf-8?B?d0tMaWQyNTNLaHd5TXVuaDhONGdKTVN4bkk5dDNKVlVnejZ3d1MvOUxpS1gw?= =?utf-8?B?RmEzOXYwdDJGNlVzVUlUcldOa2EzYjUrWVRVTnExOGdxUjg3dzdHYUNUOVBG?= =?utf-8?B?ZmliNysySXZJaGs2MTRDTmI3ZnplTVFiNTlyUUt2YU94YlgxWU5aeXpKdUN4?= =?utf-8?B?RjFCYVM2Q2xFdDB5N1VKODkxK3YzU0pWREJ3WlcwTUlKNlVobUVEQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <14E2632C58DE6942950DAC4EC53D4DA6@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 175cbe30-7d12-4158-3888-08da34d0912e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 11:06:01.9757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b928MNUapzw0e02nctTLcVQZ3lpRTyMK30C0uQ2LQAiYf10mM6QX0U6QEGzb3VGb1Bkul4PogbvSInZhePmqqTyBOpG2dyqYkuoTsUHYwpk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3174 T24gMTMvMDUvMjAyMiAxMTozNCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcHVpZC5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4 bF9jcHVpZC5jDQo+IGluZGV4IGQ0NjJmOWU0MjEuLjY5N2VlMzgyNzAgMTAwNjQ0DQo+IC0tLSBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYw0KPiArKysgYi90b29scy9saWJzL2xpZ2h0 L2xpYnhsX2NwdWlkLmMNCj4gQEAgLTIzNSw2ICsyMzUsNyBAQCBpbnQgbGlieGxfY3B1aWRfcGFy c2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGljeV9saXN0ICpjcHVpZCwgY29uc3QgY2hhciogc3Ry KQ0KPiAgICAgICAgICB7ImZzcmNzIiwgICAgICAgIDB4MDAwMDAwMDcsICAxLCBDUFVJRF9SRUdf RUFYLCAxMiwgIDF9LA0KPiAgDQo+ICAgICAgICAgIHsiaW50ZWwtcHNmZCIsICAgMHgwMDAwMDAw NywgIDIsIENQVUlEX1JFR19FRFgsICAwLCAgMX0sDQo+ICsgICAgICAgIHsibWNkdF9ubyIsICAg ICAgMHgwMDAwMDAwNywgIDIsIENQVUlEX1JFR19FRFgsICA1LCAgMX0sDQoNCkkgdGhpbmsgd2Un cmUgd2FudGluZyB0byBwcmVmZXIgIm1jZHQtbm8iLsKgIENhbiBiZSBmaXhlZCBvbiBjb21taXQu DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pg0K From xen-devel-bounces@lists.xenproject.org Fri May 13 11:18:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 11:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328431.551443 (Exim 4.92) (envelope-from ) id 1npTJv-0000ur-8k; Fri, 13 May 2022 11:18:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328431.551443; Fri, 13 May 2022 11:18:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTJv-0000uk-62; Fri, 13 May 2022 11:18:55 +0000 Received: by outflank-mailman (input) for mailman id 328431; Fri, 13 May 2022 11:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTJt-0000ue-OZ for xen-devel@lists.xenproject.org; Fri, 13 May 2022 11:18:53 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7714899c-d2ae-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 13:18:52 +0200 (CEST) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 07:18:49 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BYAPR03MB4071.namprd03.prod.outlook.com (2603:10b6:a03:79::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Fri, 13 May 2022 11:18:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.016; Fri, 13 May 2022 11:18:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7714899c-d2ae-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652440731; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=On1+Yugy0e7XDuqPkB7HA1FEytdu/qaeXgWsOI6dlvo=; b=eeBacfsUzWl9F8lrcBeNhv+gOEK8x6eB+ppFzUNxCO1PMzSbLXL0xP1p YKEN3FCpJdtRNRe2Z+LoxKgGugV4mG2jYz28juk6Oxsc3MQWoc1QcaKgC xF3Z64c9G97O2rJy7oWtxRNz/rusBOcbJ3J69i3QYWI2rZhmzgboWvD1K c=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 71237437 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nLqUw6vbfaa+1cKFEDAcGIQLkufnVCVfMUV32f8akzHdYApBsoF/q tZmKWCFa/qKM2CgeIgjOojg9EwCu5HQz4VgT1M+qHw2QSlA+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U4 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi9xL4mcwN1AbiVXTQR8GfNZqLzEBl+W5Jn7I03uKxMAwt1IJWRvZ8g037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IJmm5v36iiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvDGJl1Mti+eF3Nz9ev+4aflwhkWhu 0Xc71/3BTImM+yD8G/Qmp6rrqqV9c/hY6oCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN80igkoLU29UerZsLgRBD+q3mB1jYDX/JAHut87xuCopc4+C6cD2kACzJENtovsZZsQSRwj wDQ2dT0GTZorbuZD2qH8auZpi+zPi5TKnIeYSgDTk0O5NyLTJwPsy8jh+1LSMad5uAZ0xmrq 9xWhEDSX4kusPM= IronPort-HdrOrdr: A9a23:xd4KGKyF6GMk3ReIlbovKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71237437" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYtqxuapzrtvkNg98Dpvp9snp5YmTlR+Q1DUKEaPxxw30bR0wIIPSz1SRNnTzLOfVMaNMUSrt3Vubmxlu69D5V4OzoB1UD9Z3oeezrkGoPFIEus+DLlD0HhbPex9+BlzH7rIJaq39eTAXNJeGbnDbRKqSGuHHJmKg2qUcB8d0y2i97hC33myO/gP+OrwSL94aXSVtWWxqA35D4WsN41WL/i4gxB4IM9oKHcnp2q4znWiktUmfY3Xz0ot7L8eNRFWJI5JVqDLhfSeMIm92mhvTKxeFUfpiSEfHB1nExhYw692SVyQKQks16tiBw3TY3QP16MSp5iUx/9WnC3RzI3UZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=On1+Yugy0e7XDuqPkB7HA1FEytdu/qaeXgWsOI6dlvo=; b=QSnAmXpIUkzl38ZxyB1zgvEjRFqkTgBDDsec8TA4AeAwY3Fqaw76ArCt1q6GwbC0Jf8Uv99qR4idr+e0iLtKM7/jsmi3lNeDQieYJzB5LOZBzF9tPcY59KguGISzk5iCeZwvjyyt8DDJ/3PQj7J0dHGyQiAeeZzz+MivzTRLuXttDCBWJmnXId6L+m788RvFsl6Jpdnl334CXoXjH85QqYFs1osmDVvHcE78tj7xaXAvE3klzSl60g+uGcHTlC9w6H0reHtBhUIZDeMc5YDpevszy+Lh7pPWe0bW+yFnczJt9CsvbEeT2QceczcI+OUFcVx6MD7b1pOs8u/wCweIoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=On1+Yugy0e7XDuqPkB7HA1FEytdu/qaeXgWsOI6dlvo=; b=RjYy9QU798tI/sd2uYPdFstQosyPlDzQ5OWB8Jog+eFqHW41ZMKFnpiN8jQSX9jYoc44HUuYEG5jAgvrsp/zAPkdZW/NpPlIQ0MIG5X7MvJ8ZPBed/Mb1eUTgxK2eQFNUUKBah8MZEOUCGcY0/V5j6WEhWqDiHqcun2UL3ZvfnQ= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Thread-Topic: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Thread-Index: AQHYZrUyMvxAwXZZoEuS2l9n2AZByq0cqQOA Date: Fri, 13 May 2022 11:18:47 +0000 Message-ID: References: <20220513103500.3671-1-roger.pau@citrix.com> <20220513103500.3671-3-roger.pau@citrix.com> In-Reply-To: <20220513103500.3671-3-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 060d9c4a-90c0-47db-d9d2-08da34d259a9 x-ms-traffictypediagnostic: BYAPR03MB4071:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p8x9SpODE9MKgJQQL3/FR7q+8S/fYNeUe29F06C/e4Ucl0B9GFQ9ll5ZfLYMK/5Fw3A/3B+8775RS4b2W5wGTA9KTMqL/Yk4OI7n4oPcJwEqbVAk8JwwFCibkkw0yiI8S52kMfbRqSXmPsKpObIkct+r3E8MV9Ia9M7Bdy1iHCXn63IMqYq73qRScHT3p7ml8u6Wfz/fRzesRs3JUZNqQ/tKgInmUCEvNmZNKg1BFhkV2NZHEcgWOdyJ09qM2UOrmQGe6+z1vXx1ExXNrR15GlWEh4GXZBBVta1H3eHizdjO45T/Gy36nDVX8Y6X7440iZ6O83M2BZ3dM30paGMHlYkL8pU1qBpDOCYkeh98qtyYwRQZvhlNp6u76Jl2HY4FlTbj9quoDIyLECj9YFz9fKa4CG8XSbdqG5i1so8pDOI13E2meFEZNhNWXh3GNpc/wlG8roIBjMs2nuXzOBssZpcHgRkQnExLTTiMZJLQyQ6r5CMT2DFoZLNjpjGH19Dta6hKUszHG674e8pwfXC76t2EPnr9pOJMBsFQNf9yTni00EKCAe1KF5RatpYSVyP6OKM7kPCFRmesfOsF/Ki0Ka1Bk9a7ssSFySn7JBPfjGZ2+Z778XCugV2xl+oB79N9TMwRNPsGfXORwSFIRnYNzvea1V8A2LvAgOeJQZqFxPprClXWCKiPdHiQctNFcTU09DASVXVI8k7F9a8KkdIIYQnRXLN2K6k6X7FkaqjboNZixcTazDU2OxaLLL54NkLiEXe6wVGWkV1TvB45P+gdwDFddN+aOozzu/wHwZG9D/E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(54906003)(6486002)(36756003)(8676002)(26005)(38100700002)(66946007)(66476007)(66446008)(64756008)(31686004)(53546011)(76116006)(91956017)(66556008)(5660300002)(186003)(316002)(2906002)(4326008)(83380400001)(6506007)(82960400001)(86362001)(38070700005)(8936002)(6512007)(122000001)(110136005)(71200400001)(2616005)(508600001)(170073001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cndTWnhtUkpWVzJScWwra25rUFZ5cmRTcHNpZTZhYnBXZXZtaVNhQjhaNU9o?= =?utf-8?B?ODROVXFZRDZ4eXBnRlNpUDlDTGlUZSszb29hZHFaMWROaEdjSmc2akJKeDFR?= =?utf-8?B?UHR2c3grNmtETTQ4dGtnRWdwUWRHRFkvOFdrZlp1UUxGRHZNaHNNYTU2RVlN?= =?utf-8?B?c1B3YlpaSFprUlNxOVQveW5WR0RmZXRiY0JLc3U4NXN2cmpjL2FmakxDWitW?= =?utf-8?B?Z3hGeEtTMXMwekpOQVQrT2tBUUtBZkdubDJQd1BXdEQ1bXN4em5qcG4zUVQ3?= =?utf-8?B?N2xJaXQvRkJFclduVDFhRVEvdm81Vmp6VXBhR1FCMUpxSGM0c1kwRWhNMlBm?= =?utf-8?B?OURoUHpkSlVWZ3hpT2RXU2J4ai9BOCtSbVAyMVkzdnVpSEhrbDh0YmF5dTlT?= =?utf-8?B?R2N6RXZjenZQWkFhblV4cWRCUWhRTEJWY2FoYTlmc3RGMUtJcFh1NE40RHE0?= =?utf-8?B?eWRHWXcxd1ZPZ0V0aVZUbm1jSGxVY0VNd1FVNDd5Wll2Z09ZQW1xdW5zYTNL?= =?utf-8?B?akZWY3UzTTFZMmZ0NmxuSk9ZckNwR0lFZjJrc1h2YXc3TnhuTUJmLzRGZytu?= =?utf-8?B?RVdFSGRBWXpNSHZGTTlCMHhqcHZNSFNTckNhUnBEOTh2L1ZrVi9IMUFVOGVV?= =?utf-8?B?MTFQOE45SHZXNElJMHRoKzNxRlU3Zmo1dXQrYW91M2tTV2hZNjlaU3dtbFlT?= =?utf-8?B?OUJtcTJwckZzRCsvTkY3S2FJNGtOL25oUUFtTXhZUDNXZHRtSzMvN0Q4aW5r?= =?utf-8?B?UmVSc2ZnektFbjRaUEZYQUF2V1FwWlFHTWNRYVRzYlRKQWR1VXdsV20rUUhr?= =?utf-8?B?WlhQaDR2L3ViNVRYSFFFZVFXak9SNXU3QWxEcjFoblNQMXVFeHhOSFRkclhi?= =?utf-8?B?eTlDbnRxeWtycVFDc2xJVnYybWNtZWdMaVVzQnFxU0QwNyt1M3RUTVdVNmlq?= =?utf-8?B?MVg4S0pSdUJ1WkZMQUJoYVV1VFdKclg5aWoxWnJvOUhNWDQ3a0tzVTBtVHVS?= =?utf-8?B?MzhUUnhuVWFOVU1aTE4vd0M2RlM0QkZLd3VPNEFSM3F3WEsvRXhvbDR4a1FG?= =?utf-8?B?ZCs2ZjNld1ZSS3lSR3lWa3VmMGgrU3lVanIycDQvMWo5ODVwbzZ3RUNhbHBp?= =?utf-8?B?Q2ZjRFd4Qkh3R25udVhpME5QYnlBbk5XVUNaclVRNWI1ODc5U2tIYjVaZjA2?= =?utf-8?B?SFlnY1UwTmZka1BHTEIwWi9EN2xQbTFlK1prUDR1VGRudGgxVUZTRGJMcmxp?= =?utf-8?B?TU1FMnBMSThveWxnQ3BqbkVEd1VYM1FlQzVsZHBCMy9WY0paWVpYSlkyRFdR?= =?utf-8?B?L0xyYmhMWWtYS2x4YStyTXo1T1RUajk2RlFhRnN3MlUzQVZFRFhHV0laWlc0?= =?utf-8?B?OHhHbThGOHpCK0dydFdrNVVZZHZiUzd3c2RiUCtlV09tcFpqVlZUY0FMSkY4?= =?utf-8?B?MnlXdGtFTUJwaDh3TDJTckhkcFMwUG55cjJaTmN4LzlaSC8wREV6Z0M5dWda?= =?utf-8?B?QnJQY0x6bDU1L241OTNsMXpWTStOeHIyT0hpNE9LL0pPZi9PUHMwZzNLVkhq?= =?utf-8?B?dWQxZ0RmRWlPdzVqVHdoT1FMamxNQXpmakdpOGlsNkFFOWwxSjJlM21qNmJx?= =?utf-8?B?NWtRdnJCcFZTazNIVjFHRkpkdmEvbWtsSXJ6bGNPdXhVME1pbVhDNHU3aXRj?= =?utf-8?B?Sk9IZFRnNU5DNktJS0tLR3Jhc1JJVll2bTljazgzWlcxNlQ4VjFuTFhlczcx?= =?utf-8?B?ajAvSTIydEE2T01ZTWtQTkZETGVjQkk4bjNQbWlnMnNBeS8yM3B0NmYwU3Nk?= =?utf-8?B?SzhLb0tld0J4QmpXK0N5K2p5bTYxT29PMVpRSjJ1S1ArTHVpaUNneENEeUgr?= =?utf-8?B?TlRBL1hkSkQ3UnlHT1BESXNEMWhoSTZvZzlFeGQ1Y3czYVR6SkJYbVRjeFNO?= =?utf-8?B?azkwL2lNSWYybnoxaWVxZE0xMms1bmNYdXlmbjBDNTFNL2JiU0RDcUdiQlFV?= =?utf-8?B?ODhoK1hUR095Uy9mc2dUTy9XT1VuTnhGOXk5bDBmRE1zWkV5SXZ5TmorWFNQ?= =?utf-8?B?ZVFOUjVCd1RpVGh2QlNTaUlMQW54ZzAzYlJuYmdBNEdyVWF1a294NjF2R2Zn?= =?utf-8?B?QW1SS2l4L1hwUlRUS2ttblU4a29WQjNFdXA5Y2ovemZVL2cxS3phdzJTR3Fs?= =?utf-8?B?NUZaMDE2SEROQURDdWJWWGlsZXhqeUFjMGRpNjQ3ZThWWG5yMkpJaUhSc1dm?= =?utf-8?B?Vis4K1RBNWdodU9vTXorWVh5YWdQRXJJaGZ2c00zTmpRVkRFdWZlbW4yWHFT?= =?utf-8?B?SXhtVEY2TmxHUHZOdGw1cUFLc0RTZVBEdEdHRGJCdXBxSVBZWDJzZz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 060d9c4a-90c0-47db-d9d2-08da34d259a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 11:18:47.7957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LcSL0/2z9FWFVKG/M2fi4/i1kO6jZ6vRUwvEVo39qXENa37yz0/5ohJNo85cq9j44yY6thjj+3UR2itLG0vp0NW2LQeNlXpVPfOoCH1RKvI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4071 T24gMTMvMDUvMjAyMiAxMTozNSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBTb21lIENQVSBt b2RlbHMgZG9uJ3QgZXhoaWJpdCBNQ0RUIGJlaGF2aW9yLCBidXQgYWxzbyBkb24ndCBleHBvc2UN Cj4gTUNEVF9OTy4gIFNldCB0aGUgTUNEVF9OTyBiaXQgZm9yIENQVXMga25vd24gdG8gbm90IGV4 aGliaXQgdGhlDQo+IGJlaGF2aW9yLCBzbyBndWVzdHMgY2FuIGdldCB0aGlzIGluZm9ybWF0aW9u LCBhcyB1c2luZw0KPiBmYW1pbHkvbW9kZWwvc3RlcHBpbmcgZGV0ZWN0aW9uIHdoZW4gcnVubmlu ZyB2aXJ0dWFsaXplZCBpcyBub3QgdG8gYmUNCj4gcmVsaWVkLg0KPg0KPiBTaWduZWQtb2ZmLWJ5 OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0tDQo+ICB4ZW4v YXJjaC94ODYvY3B1L2ludGVsLmMgfCA3MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrDQo+ICB4ZW4vYXJjaC94ODYvY3B1aWQuYyAgICAgfCAxMCArKysrKysNCj4gIDIg ZmlsZXMgY2hhbmdlZCwgODAgaW5zZXJ0aW9ucygrKQ0KPg0KPiBkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gveDg2L2NwdS9pbnRlbC5jIGIveGVuL2FyY2gveDg2L2NwdS9pbnRlbC5jDQo+IGluZGV4IGRj NmEwYzc4MDcuLmQ4MjFmNDYwYWUgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvaW50 ZWwuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L2ludGVsLmMNCj4gQEAgLTUxOCw2ICs1MTgs NzMgQEAgc3RhdGljIHZvaWQgaW50ZWxfbG9nX2ZyZXEoY29uc3Qgc3RydWN0IGNwdWluZm9feDg2 ICpjKQ0KPiAgICAgIHByaW50aygiJXUgTUh6XG4iLCAoZmFjdG9yICogbWF4X3JhdGlvICsgNTAp IC8gMTAwKTsNCj4gIH0NCj4gIA0KPiArdm9pZCB1cGRhdGVfbWNkdF9ubyhzdHJ1Y3QgY3B1aW5m b194ODYgKmMpDQo+ICt7DQo+ICsjZGVmaW5lIEZBTTZfTU9ERUwobSwgcywgYykgeyA2LCBtLCBz LCBjIH0NCj4gKyAgICAvKg0KPiArICAgICAqIExpc3Qgb2YgbW9kZWxzIHRoYXQgZG8gbm90IGV4 aGliaXQgTUNEVCBiZWhhdmlvciwgYnV0IG1pZ2h0IG5vdA0KPiArICAgICAqIGFkdmVydGlzZSBN Q0RUX05PIG9uIENQVUlELg0KPiArICAgICAqLw0KPiArICAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg ew0KPiArICAgICAgICB1aW50OF90IGZhbWlseTsNCj4gKyAgICAgICAgdWludDhfdCBtb2RlbDsN Cj4gKyAgICAgICAgdWludDhfdCBzdGVwcGluZzsNCj4gKyAgICAgICAgYm9vbCBjaGVja19zdGVw cGluZzsNCj4gKyAgICB9IG1jZHRfbm9bXSA9IHsNCj4gKyAgICAgICAgLyogSGFzd2VsbCBTZXJ2 ZXIgRVAsIEVQNFMuICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHgzZiwgMiwgdHJ1ZSksDQo+ ICsgICAgICAgIC8qIEVsa2hhcnQgTGFrZS4gKi8NCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDNm LCA0LCB0cnVlKSwNCj4gKyAgICAgICAgLyogQ2hlcnJ5dmlldy4gKi8NCj4gKyAgICAgICAgRkFN Nl9NT0RFTCgweDRjLCAwLCBmYWxzZSksDQo+ICsgICAgICAgIC8qIEJyb2Fkd2VsbCBTZXJ2ZXIg RSwgRVAsIEVQNFMsIEVYLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4NGYsIDAsIGZhbHNl KSwNCj4gKyAgICAgICAgLyogQnJvYWR3ZWxsIERFIFYyLCBWMy4gKi8NCj4gKyAgICAgICAgRkFN Nl9NT0RFTCgweDU2LCAzLCB0cnVlKSwNCj4gKyAgICAgICAgLyogQnJvYWR3ZWxsIERFIFkwLiAq Lw0KPiArICAgICAgICBGQU02X01PREVMKDB4NTYsIDQsIHRydWUpLA0KPiArICAgICAgICAvKiBC cm9hZHdlbGwgREUgQTEsIEhld2l0dCBMYWtlLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4 NTYsIDUsIHRydWUpLA0KPiArICAgICAgICAvKiBBbm5pZWRhbGUuICovDQo+ICsgICAgICAgIEZB TTZfTU9ERUwoMHg1YSwgMCwgZmFsc2UpLA0KPiArICAgICAgICAvKiBBcG9sbG8gTGFrZS4gKi8N Cj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDVjLCA5LCB0cnVlKSwNCj4gKyAgICAgICAgRkFNNl9N T0RFTCgweDVjLCAweGEsIHRydWUpLA0KPiArICAgICAgICAvKiBEZW52ZXJ0b24uICovDQo+ICsg ICAgICAgIEZBTTZfTU9ERUwoMHg1ZiwgMSwgdHJ1ZSksDQo+ICsgICAgICAgIC8qIFhNTTcyNzIu ICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHg2NSwgMCwgZmFsc2UpLA0KPiArICAgICAgICAv KiBDb3VnYXIgTW91bnRhaW4uICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHg2ZSwgMCwgZmFs c2UpLA0KPiArICAgICAgICAvKiBCdXR0ZXIuICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHg3 NSwgMCwgZmFsc2UpLA0KPiArICAgICAgICAvKiBHZW1pbmkgTGFrZS4gKi8NCj4gKyAgICAgICAg RkFNNl9NT0RFTCgweDdhLCAxLCB0cnVlKSwNCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDdhLCA4 LCB0cnVlKSwNCj4gKyAgICAgICAgLyogU25vd3JpZGdlLiAqLw0KPiArICAgICAgICBGQU02X01P REVMKDB4ODYsIDQsIHRydWUpLA0KPiArICAgICAgICBGQU02X01PREVMKDB4ODYsIDUsIHRydWUp LA0KPiArICAgICAgICBGQU02X01PREVMKDB4ODYsIDcsIHRydWUpLA0KPiArICAgICAgICAvKiBM YWtlZmllbGQgQi1zdGVwLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4OGEsIDEsIHRydWUp LA0KPiArICAgICAgICAvKiBFbGtoYXJ0IExha2UuICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwo MHg5NiwgMSwgdHJ1ZSksDQo+ICsgICAgICAgIC8qIEphc3BlciBMYWtlLiAqLw0KPiArICAgICAg ICBGQU02X01PREVMKDB4OWMsIDAsIHRydWUpLA0KPiArICAgICAgICB7IH0NCj4gKyAgICB9Ow0K PiArI3VuZGVmIEZBTTZfTU9ERUwNCj4gKyAgICBjb25zdCB0eXBlb2YobWNkdF9ub1swXSkgKm07 DQo+ICsNCj4gKyAgICBmb3IgKG0gPSBtY2R0X25vOyBtLT5mYW1pbHkgfCBtLT5tb2RlbCB8IG0t PnN0ZXBwaW5nOyBtKyspDQo+ICsgICAgICAgIGlmICggYy0+eDg2ID09IG0tPmZhbWlseSAmJiBj LT54ODZfbW9kZWwgPT0gbS0+bW9kZWwgJiYNCj4gKyAgICAgICAgICAgICAoIW0tPmNoZWNrX3N0 ZXBwaW5nIHx8IGMtPng4Nl9tYXNrID09IG0tPnN0ZXBwaW5nKSApDQo+ICsgICAgICAgIHsNCj4g KyAgICAgICAgICAgIF9fc2V0X2JpdChYODZfRkVBVFVSRV9NQ0RUX05PLCBjLT54ODZfY2FwYWJp bGl0eSk7DQo+ICsgICAgICAgICAgICBicmVhazsNCj4gKyAgICAgICAgfQ0KPiArfQ0KDQpQbGVh c2UgY291bGQgd2Ugc2VlIGFib3V0IHVzaW5nIHg4Nl9tYXRjaF9jcHUoKSByYXRoZXIgdGhhbiBi YXNpY2FsbHkNCm9wZW5jb2RpbmcgaXQ/wqAgTGludXgncyBidWcuYyBoYXMgc29tZSBmYWlybHkg Y29tcHJlaGVuc2l2ZSBleGFtcGxlcyBvZg0KaG93IHRvIGRvIHRhYmxlcyBsaWtlIHRoaXMgd2l0 aCBpdC4NCg0KQWxzbywgY2FuIHdlIHVzZSBvdXIgc2hpbnkgbmV3IGludGVsLWZhbWlseS5oIG5h bWVzPw0KDQpUaGUgc3RlcHBpbmcgY2hlY2tzIGd1aWRhbmNlIHNlZW1zIHN1c3BlY3QuwqAgTGVt bWUgcGluZyBzb21lIHBlb3BsZQ0KYWJvdXQgdGhhdC7CoCBJIHN1c3BlY3QgdGhhdCBtZWFucyAi d2UgY2hlY2tlZCB0aGUgcHJvZHVjdGlvbiBDUFVzIGJ1dA0KZGlkbid0IGxvb2sgYXQgdGhlIHBy ZS1wcm9kIGhhcmR3YXJlIiB3aGljaCBpbiBwcmFjdGljZSBtZWFucyB3ZSBkb24ndA0KY2FyZSBh Ym91dCBzdGVwcGluZ3MgbGlzdGVkLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri May 13 11:20:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 11:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328437.551455 (Exim 4.92) (envelope-from ) id 1npTLq-0002FG-M5; Fri, 13 May 2022 11:20:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328437.551455; Fri, 13 May 2022 11:20:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTLq-0002F9-IO; Fri, 13 May 2022 11:20:54 +0000 Received: by outflank-mailman (input) for mailman id 328437; Fri, 13 May 2022 11:20:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTLp-0002Ez-BF; Fri, 13 May 2022 11:20:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTLp-0006OP-9o; Fri, 13 May 2022 11:20:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npTLp-0000Z1-0i; Fri, 13 May 2022 11:20:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npTLp-0000O3-0I; Fri, 13 May 2022 11:20:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YRQZzeNMAwxgXVzAlBU5+R7tHyzQwwTah0ul3ONTbm8=; b=DaGH21PCbxhUSWj08PBZnNC63o U7FZ7cPhjlTWgwIsozgs5B8z9ys66QFx8xirsk7C6gGT6YrAYDgcawkHLGm8zt2GGT3+bxgS6NfMJ mvMkDxWn25Tf5QQX7XbYcPbF4zEVwDn5x/nSoMIfpR43DbuwYToGWZe7fHXbgy4GsXtI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170389: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 11:20:53 +0000 flight 170389 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170389/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 979 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 12:33:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 12:33:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328457.551466 (Exim 4.92) (envelope-from ) id 1npUTS-0000xh-Ez; Fri, 13 May 2022 12:32:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328457.551466; Fri, 13 May 2022 12:32:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npUTS-0000xa-BN; Fri, 13 May 2022 12:32:50 +0000 Received: by outflank-mailman (input) for mailman id 328457; Fri, 13 May 2022 12:32:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npUTQ-0000xU-2f for xen-devel@lists.xenproject.org; Fri, 13 May 2022 12:32:48 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c99cf52b-d2b8-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 14:32:45 +0200 (CEST) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 08:32:39 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA0PR03MB5404.namprd03.prod.outlook.com (2603:10b6:806:bb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 13 May 2022 12:32:36 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 12:32:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c99cf52b-d2b8-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652445165; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=LP4MQgq0b3+fAz17OG2p6sw+zH3PQHU0YZXiOEUL8/0=; b=A/egOAx2EWb8XWOdx7K82QHtDT4RbKyjmBy/EGT3Y2Brq9gAGRuA9B1e WmPzOH0NqIokE4p9g0inmNJhuNarUrJpxu7OMSNQ3Mxqrfk6UhGB0X1GA RfmXstU6pk8xtKjcy0CKlO9j/hp3Iva3+FOTkzVXfpvrVEeeTdqa1hfkx E=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 71117023 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OWrZHKPH9weE0zvvrR2ilsFynXyQoLVcMsEvi/4bfWQNrUongzMBz GtOWDqFOK7camHxfdsnad6+8kkG6pCHztAxGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Uw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5 9lun4yLcFkQY/fg288XUwVTFwRUBPgTkFPHCSDXXc276WTjKiKp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtaaHP6iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33yCmLGUC8zp5o4Ip+HP64gVy1YG8c9aEYMKQecFbk0qX8 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTvv2RmkO4HdVFJ CQ8+CU0qrMp3Fe2VdS7VBq9yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsSzdAbJkqsZEwTDlzj 1uRxYq2XnporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9kDSW517YRY36piG IronPort-HdrOrdr: A9a23:nGzb2a7p4VomdJL2IwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71117023" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUzfg1ka6kG8vmua+fb3uzdMKH5jB0qrdD+kBzuTzc87Je67zh+HcLbwQBB88Er/CKIixBBkugf8wL3ptzs5pHc0zlpW5Ae7vGf5zVwyQT4Q8MijcoYKvnsK/wfJBYwZQspXS/zsaqS7JT4uxGp267gI9RdmFNIxLGL8D0a/UrL9JgVOebPrfBvYxWQw3ZbVGNMeSbibrVI8ysEanjCAVsS9qlMQE8cle3rb1o4K+kiBODU7b3avfntDTc5iRiI+Fz8t00nrCgtkPdZXuYTafP8Dg4nfYSV5/NMMFHzZnzUDGTBCULALJunG139HSdazrVR4wUYN7mxOAMXei3QQjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0iEa3rG66BGk+Kc8prOOuBxOgEguZjAo0hFGK7M2byQ=; b=KyZoLum9oR/9ZUmNxNmObQrlbbEfOu0h4CNsvq0As4cFEZP03HevTuwue9b537sr2i/jIemcO5oWsvY7PQslfAxCwGl1ncND2R3hKstPtA3G5jjTBJd93Loo7PkTlHsLzcdQROhTtyySaQGUxCfyh0lQMDh32GwY9xGJLyf99enLmi6dvJTwHsNh7Ttfr2BSLTGxXiZTt2RymNYHaLNfmdv0jQMgvXYqaL9MlSjFZMMuTuMMDTAcqoXicK3Cm/AzUS9xXCGR4K8hbKJk9FXcAUJBejlILS5p533OORR/bFQCtiCRyTKLeqqblVnZi2nt9y/UsMl3Xb88Gl8gs3UAkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0iEa3rG66BGk+Kc8prOOuBxOgEguZjAo0hFGK7M2byQ=; b=VfBP14pBQiOeljTNBl0Hc6v3fsXWIcsvZTvT9pHp2XXs240ViSntUaA2fQ6nsUevj5AGC8/lLmpe/gTbBl5DBbS+JvQOs8lu7oLJlGBDflYbFAXK/kwYpA3Glutf3DJvEUOapZplX7GJUwPnKaVlJMbJEhSKsAB99D9YNpqIgps= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 14:32:32 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , Anthony Perard , Juergen Gross , Jan Beulich Subject: Re: [PATCH 1/2] x86/cpuid: expose MCDT_NO to guests Message-ID: References: <20220513103500.3671-1-roger.pau@citrix.com> <20220513103500.3671-2-roger.pau@citrix.com> <15d66a71-33d5-c866-e57b-be0f42d1ce5b@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15d66a71-33d5-c866-e57b-be0f42d1ce5b@citrix.com> X-ClientProxiedBy: PAZP264CA0039.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fc::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62b49e66-4454-4544-cca4-08da34dca944 X-MS-TrafficTypeDiagnostic: SA0PR03MB5404:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pVcBzbnGeED2kzooueYriMVavOvFzWi1f7aFAOeAI4IWA9JiJudd0E06tLJKzm4gRxAHfBLXD0nZjh3OBwe5c5QlTJ5dDvDM12nHz+9jEe0RBxVMjIUf0LY0jMA6Nhz23u4QGk22ecGngGKsr3sq4o/aGJ2e5GkM8m9fMbozL//T28AWYRcOnNUKbaPodA2ylV3Y9EZcvVStm1UlqWvolBoujVPOzjfaQJjca/TkNxOiI6c2tT3iA+39MgqcAGY5xPoPW0SVpoBzNetS0xt8Ogv+R+9vQrfTogqvPe3H1zTvWGeLBNRJg4yrrOy0LDt0/TcVPF1gYn3QiYKqs1Zp1P7/9YwM57oJ161e1nrZKoinaUmsrkYkBf7HUASlKgROpjEoQIGNLBhKAOGGd2al2jiFzXGECU2JpOrONeZ+3MAkBhCuKx+fH5hX1ufjhl/e7O/uwopDX5zb5YsVv107jIPIrJNjWNVhyjs7D14WYTG/fMgim3hDs0ecUX/MmhGov9Rc5NFr4rLNcjhnOSYaFe5XfELTEmNCMlOKq8p/QpX2ZqZs6v1xh5px+GhbAELVHmen3yE6juD0Z1EwU4hozdGaj+1v8gT+DxNe4dqcCEvTJCvmhNZQ/KX+avU7jP17VKUp2sTd4ssiFdzmNbWIDA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(316002)(4744005)(2906002)(6666004)(85182001)(33716001)(82960400001)(54906003)(6636002)(508600001)(6486002)(6862004)(66946007)(4326008)(8936002)(66556008)(8676002)(5660300002)(66476007)(186003)(9686003)(6512007)(26005)(53546011)(86362001)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1RvSGV1WHUvVXdPNWNmdzQ0cFZJNTNNYVg3V3RuTG40UW1XTTNoNTdFeFgr?= =?utf-8?B?a0EvUmpQMndOQURPekJZWi9wNFUrMjRQWS9makVQdHQ3TUdLUmtoVGlxbjFG?= =?utf-8?B?akg3aVEraHR1L1R3ZGFzN0hoakMydXoxVVlKV05NNTh5QzdxWlQ3ZVVqd3Q4?= =?utf-8?B?U25JMlhQZTFUdUplYzZuKy82MTVKYkdJRStQaXhpdWxUQXQ2djBSOFptSWNj?= =?utf-8?B?aGM3dFAvOUFQQ3JqVlBjTEZiT0tKaWVSbm1HVHNsN2NCU2pTMExXMWVZVjlH?= =?utf-8?B?RjhhemFkQ0lLVEtvWTlFaWZXN0pVMVdoVHpPWGZGcmh6aTR3L1phajMrS2Zk?= =?utf-8?B?RVl1Y1kwWUlFcCtJcUlHZm40a25XUVVFOUdPcHFOdzJXV0RYSHJtNm1FQXJI?= =?utf-8?B?RGsyNU53WUU4bUZHWk10MHd3dC9mVWVGbi9DN3RRZHExbjdEdDVPWkc3WEw1?= =?utf-8?B?MlFvVnZMUFd4N3JCMmZkOFlUcExGZ0tScTBFcUs3d1R4ejJjVlozcTBIaXpR?= =?utf-8?B?c2E1eEJzUndhWGdhYzhiOG5YWVg3UkV0TFVQK3doTVg3L0o5VlFvcDRTK2l5?= =?utf-8?B?L2ZNVDU4WXdWN0FKbUh6Nm5ZKzBpVUxzN3hQbysvVGR3WWJnM3BzUHd1d2FB?= =?utf-8?B?cDE4NC9xcnpaOW5RcGlzZ0pJMkhNSEt6U0hVOHhtZVZYNUdyMVdoUVFrdUJl?= =?utf-8?B?RldLeXlpdFdLK1RtU0t3aW5TZVNJeit3b2pvcmUzcnBHTGJrdGh6SHNKL1lX?= =?utf-8?B?MEI5VUd0VldjeEpEQzFlTUlpNnJyUjZodDVUQ0k0eXpsSVExemtPVGRSM01O?= =?utf-8?B?Q3Q4RWFaMUNRU3Zjd3lJRFpmbDlDK1pLS0NIY2pMMkh1L2xKVXRydU9TbENl?= =?utf-8?B?NEVaMDNYTUtEc1p5U09iOHpSK3FLMUdaeTlzMTlmWThVYlJ5OUlhbmtrM2FD?= =?utf-8?B?empDdXFqVzdhaG5MbWVPeDZlS0RmdmdaREtEMXFDUjF1QnFzdkpObEJiTjJm?= =?utf-8?B?a2h4cjJycW54cytsL3UrQndCd3UrdnljU1hnMm1aQTJWVlJZWmNLZGo0Umly?= =?utf-8?B?SEhxQkNPTXlDWHJXck4zVHBoS05RMHdlemZEM09scWQ5akN2VkpXMmc3NjJQ?= =?utf-8?B?OHJxZ0FsU1JqbmZ5Z2JpVXZOVE5SK1Q1OHFCMC9NZmJ2MkZhSDNCdG1hY0Zm?= =?utf-8?B?SVdsWEUvbTNPeHlxLzFDdk90Y2RYOG5ibEJhS01RU2xkd0FPeTI2RFhmMERn?= =?utf-8?B?Vjg2SEgyZW05OHlFSllIOFFXeTh3Mjl6U01LRWRiUkF0U3VwcDM5dzIwV0cy?= =?utf-8?B?Rk1KOGZzYTN6TFRGQkl3WFBCUzBGY29YR3VUSHZGYzNhMmtIMjZ5UHVvZW5p?= =?utf-8?B?RDZTYWR6dGNuRk1FTkx0MlZ1czF6bHl1MHRYcnkzTUZxSEk4SzJpOFhwY3Nq?= =?utf-8?B?L0J4Z0FGUXdVcjBXeVA2L1F4QWhZa2c2c1R1RXdYdkJZR1U5eVBzRHhsbWVj?= =?utf-8?B?TlNISTUxU2xveDBPY3BqbnMrQmNiT2FmSkJqK1VFbFl0OE8ra1JOUVZWTks5?= =?utf-8?B?Mm9nRUUrR2ZnRDB4NGpWaHg0OG5YQnZ3NE1YUG5RaHhjVjQ4WExsQ2NvcjR5?= =?utf-8?B?ZWp4NFFZajZLNi9xVzhFY0p5ZkRrVjBGOW1oSDNZSEZqaTRaUG82Rjg5WkhW?= =?utf-8?B?NE9UcmVGc1dxR3A2TVFqMGp6eXEzQkxYZ3ErSUVzUU5FdG42aGZKYmRtbWdP?= =?utf-8?B?WW00UytsdUNkRk9RZjFnbEZCZUx6RlBTbkZ3N3VKd29PS0hVZnh4Y25GcjJ6?= =?utf-8?B?RFliWDRUUWhOK0RheVFoMlYwOGlqSWVFTWFuQVNlWTVXVkwxTlUyYm41aDBK?= =?utf-8?B?TEZJUHB3TU5nZGttT0l2anBINkVzczlCUGJERTRtQWhoTHd0b2lxdUx4b2xL?= =?utf-8?B?ZFliTThSVCtqRzVndndqU1ZOa3FseGdhTlpwTlFYTG5Nck92MEtKMnhrUi91?= =?utf-8?B?bzdHRWRQLzlvWlBWRnFxeUxMWW15OG1HQjZoWkNEVDVKbUxyNHRXNWdGTHAv?= =?utf-8?B?VUMySUJyU0xwemY1ZVpVZWFQUTl4WUhZdDFmZHprVEgrRFl6R2NrU0xTZlhv?= =?utf-8?B?Lzh2Um9QSloydFVGQjlFSHJZcFZ3ZHFVWnlOalBiWVFJcHdmZlNIendpRDRM?= =?utf-8?B?NiszNUtWbkNIV2NsV3pWSWp2NGVCR0RZNnBsUmZ2b0FRZXlpU2hnaHhXV01X?= =?utf-8?B?YWtoM2VydzVRM3BPSFNnOENxTWtBZWhIU1VrU3Z6V0Y1KzJFaXNIbWpHUjU3?= =?utf-8?B?RVVDWFg1WURZbVlYcWRXNktzRGJJTFAzRXdleGUvN0RXbnJjOUdsaHQwN1lQ?= =?utf-8?Q?XET8IiH5VVucDYKI=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62b49e66-4454-4544-cca4-08da34dca944 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 12:32:36.4747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RQZxO5wIcN/mFVohwBbWDzbtvu54nWtzTL+EMMNOfB0tR52kxzUBe4knBrqifqozRSnu58tlNFGsC0IVeek3RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5404 On Fri, May 13, 2022 at 11:06:01AM +0000, Andrew Cooper wrote: > On 13/05/2022 11:34, Roger Pau Monne wrote: > > diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c > > index d462f9e421..697ee38270 100644 > > --- a/tools/libs/light/libxl_cpuid.c > > +++ b/tools/libs/light/libxl_cpuid.c > > @@ -235,6 +235,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) > > {"fsrcs", 0x00000007, 1, CPUID_REG_EAX, 12, 1}, > > > > {"intel-psfd", 0x00000007, 2, CPUID_REG_EDX, 0, 1}, > > + {"mcdt_no", 0x00000007, 2, CPUID_REG_EDX, 5, 1}, > > I think we're wanting to prefer "mcdt-no".  Can be fixed on commit. I've asked myself whether to use - or _, went with _ because that's the exact name on the manuals (minus the lowercase). > Reviewed-by: Andrew Cooper I'm fine if you want to adjust to - on commit. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 12:37:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 12:37:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328464.551477 (Exim 4.92) (envelope-from ) id 1npUYC-0001b5-2q; Fri, 13 May 2022 12:37:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328464.551477; Fri, 13 May 2022 12:37:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npUYB-0001ay-VI; Fri, 13 May 2022 12:37:43 +0000 Received: by outflank-mailman (input) for mailman id 328464; Fri, 13 May 2022 12:37:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npUYB-0001as-BP for xen-devel@lists.xenproject.org; Fri, 13 May 2022 12:37:43 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a0a60ad-d2b9-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 14:37:41 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 08:37:38 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Fri, 13 May 2022 12:37:35 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.014; Fri, 13 May 2022 12:37:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a0a60ad-d2b9-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652445461; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=/vr0CM3E/sL7whYDZuhpjQAluNGSZR01lKLZcB64nqM=; b=aFtkW9MIIlE/EjACu8GSrykl/8DQcSLgC2ASSBYWqC/mk9KmKYRuowHl zSoGdCe6YbCzSPoo64ZGEA4jTD79OBcTdltEwH1mvnJgj11v1I1Z78RUd 8MwX85UJjtKW5620h0waA55EOnPXDFtj79L3Pcu5KrqhI96zP/xeQHdFG k=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 71260576 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cwrTIa6O2uefei954Hk+tAxRtEzGchMFZxGqfqrLsTDasY5as4F+v moXX2jQOK3ea2ujLtxwbIux9ksC78eHytFqHFZurH02Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSfciIvLqHL39hCEAVWCCpmJIQBoZ7udC3XXcy7lyUqclPK6tA3VAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiao4YAgF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IB8gzN+PVpi4TV5AhV6fv0GujyQcCTdc4ItGiWp FDLxmusV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/Y5lifD21dFjpZMoV+6IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:DAfpiqhLxLn/jbc2jrlvzC2WH3BQX5R23DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3IwerwRJVpQRvnhPpICPoqTMiftWjdySSVxeRZjLcKrAeQYxEWmtQtt5 uINpIOdeEYbmIKw/oSgjPIaOrIqePvmMvD6IeurEuFDzsaEZ2IhD0JbTpzZ3cGPTWucqBJcq Z0iPA3wgaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6d9bbRuwqTnSW+fkNjNyKE7rgpKCcwLCEbzYpBOe twrhKknosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfRsRKEkjQpo+a07bWrHAUEcYZ 1TJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYEit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJaAupUBjaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CEVF9Dr2Y9d0/nFMXL1pxW9RLGRnm7QF3Wu4tjzok8vqe5SKvgMCWFRlxrm8y8o+8HCsmeQP q3MII+OY6UEYIvI/c/4+TTYeghFZBFarxnhj8SYSP6nv72 X-IronPort-AV: E=Sophos;i="5.91,221,1647316800"; d="scan'208";a="71260576" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekAvpseGNtStvbcOa9xT+aUrziPCUc4XQ38BL2CoxA3ivalXSygCGr85gBpoV93waLLnFxhSaADjTLtl4ouPgF9w+SX9L9s30N7a5VTJeusjnho6AXFd2Pmi7hDo8wLDjzGLV97X7piOxaekbd+u1DKESRiLJfWkRrzguacvpjWf7PqN0DIDy8XXMr/BIK3n4gx0qbndQyYKzYvsxImFYQBEg2bNE9+uSxXVKc5tV0yKCmT9wXh3hFd8Z6y1tuEvLxP1Pp75viqQD55HuxOYvvp/Wz44EByQmayZnCl7pm5huxEh7Rfa0/zvbhgL5aJAereSGJYgpiLG6BMIQ/MNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iCfx29mOBuSVuS8/K9JiopkQUCRSD+KNA3QEAlApLYY=; b=EPe0pTLSFMlUbFltH1tTuPhZg24jnA/e9EaUG6EHyDmeJERO+uMHsOliHLwD2TWSy/DkN3r1FcyQuMvWF9hhIH1jOc/4SuUfdYGGn3LfMPZtPU8dU24wGkeh3+TeiIsU1PjF/5p5d+y5cb5Vj9POSuNQkYgf6hkizMjGb1pKZozQR/jWVgkW5iFvJyfo6wFcAXXkZTDztKhEb7b3XzSEvBNaKjpwG/9O0ZNtz7YGUOg2Ni3P93+XE5g8Cy6MZ0WXL6xbCGI4l+1SOpfhYT2VdZNCGPmvodRqsOcqXo/Ony5uIM4tUXfhTKZ+zbHbmKI3UkBv1ARRrUr8CXjcbrwq+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iCfx29mOBuSVuS8/K9JiopkQUCRSD+KNA3QEAlApLYY=; b=HLTTYD9I/7xV7hDi4Y4CCGc9x9vKzDfJjjcUIP2Zjkh0dlPlRj9kCxdAXNIlosMX2249HRnYpURymS0ToJjCgJvDFVuYUlY/w1cqbB0Rlfx8/3Jw8sw0q/FAJEkYk4ONmA20GrBQRDqDGz9BeOKnb1Mhvom+zr/k4SYarvaGGfo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 14:37:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Wei Liu Subject: Re: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Message-ID: References: <20220513103500.3671-1-roger.pau@citrix.com> <20220513103500.3671-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR3P195CA0011.EURP195.PROD.OUTLOOK.COM (2603:10a6:102:b6::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb57bbeb-090e-4a87-4222-08da34dd5b7e X-MS-TrafficTypeDiagnostic: PH0PR03MB6707:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fydebJKZDejiFSW2NxAokIo1MslMKmmCGpI4p9QDNg7Y6Kse0Xg+2MY2xOjsRwo39ykCQeCTGzdz9dv5I7kGSeCNVlDB7SKPXFO/XtMZL99P8BrTyRIrG4KHGQpBgooh9uR5saPOPPLRtSYT/QEvxeT4GMaIaupFYT6KJSBIzQMXHQaJuSWcmrs+jcmsNQHxuXvWbGZYFDUNOAsUgNcIrj4W8eiy2FmKsiDeCBadIsZtNMiKH33z1wREabMG5g1wcRuw7SDUWzQX+x1AO1KppcmZQa3an9sdmNrQh8/o7W7NU625ILzY8ElRH5q13R1u3BKwETLQufDyIoQvZ43YqWpfEjpTS6ip8UpHG4cktOQa2IO7Di5fdFZQ2r/Eqglqs49+c5MfAC8DR017FZxzUjn06bsL93hnTBlvGi/HdJu+sELJdnZMfSU8wgFuoHBr3VSHwE3VS0Nv44HnCMKimI573TKCLJsiBkorwHujfHrrMwE16ojcb18U3EmFcHxqQgBmEYTylVz22uUDrOiX/Lw497EzLsfEDaa6aqpBqbJ3HQFWKb7bQ7+azPZjdDtbcQxilT51JfeqUg49X+yZ6E9Fe/jnhthFBL3IpWGk0hXZBgxbCPy58kZYqNnT4i5AiZLYhXjkXJm4Nx9OvymgkU3xIQ8DqtH5qdyFjqrTXf0rZBBgZQe2Xw82KpmZpQmT5bcoqxJNI3y2/f63fRBNxZVt0oxRrWZK9QQJgjrb86c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66556008)(54906003)(2906002)(85182001)(82960400001)(6636002)(86362001)(9686003)(6512007)(316002)(33716001)(186003)(26005)(508600001)(66946007)(66476007)(4326008)(38100700002)(53546011)(8676002)(6862004)(6506007)(6666004)(6486002)(8936002)(5660300002)(83380400001)(170073001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGN2Z2Z3YmNOWWp5VGNsQWt4NDR0NGN5Q0FEcU5vRWVwdnFuS3JnYXllUHNR?= =?utf-8?B?TzRxWnBjYkdtVFFJVll3Z1owOFN6a3EzcExEZmNtNVIyanRnZUhsSHQ5RlBt?= =?utf-8?B?enFiTDllbk1zMTFORGZvTGxVdm00b1BHL2JRVUFrbEhaLzVxc1hCOXdCUUlC?= =?utf-8?B?RVEwRk55bjF3bWNqUUN6TDNoTjJzT1o3U0EzUjFmRTBPcWRzcjhIVnhwZGUr?= =?utf-8?B?eFhzQVg4N3puZCtRZ3NLdWVaNTdqb09uM3p1VmQxVlRPa0FzbDg5QlJEaEFO?= =?utf-8?B?NDRETjBrNXVZY3hHcktGb1Vwd041TGF4WTJUMHBZbmFLa3ZxVCtxdmVqTHYy?= =?utf-8?B?UkMvT083NDMvM0dVL0dldlJXZ0s1RkFzSWZkMkZJQlFJVjNmYUJ1ZXJRSXZH?= =?utf-8?B?VVhMOS9yVmxGZ2VrdVBwOVBkSmFtb3IwdVVpYzI1azYvQlo4WDZKNE5vQi9i?= =?utf-8?B?RHBTK29sbS9SUG5hUWphNlQyYU9HNE1lZWd6OVRkRVpJMHJhejVub0lEMTdy?= =?utf-8?B?aGR3SlB5dGNLc1p0ZTErQTUvcGdkTEhPak1RaU8ra0dCWlBxdVB3b0xtQWY0?= =?utf-8?B?M0kyOHoyUVVITFdXN1hiNUo2biswb0NmQ1NsU0NXRUZiekc1ZWFDV2VHN1JP?= =?utf-8?B?VWxwVW5nUlRTTVM3RHA0akJrQ0U0ZitMbVUxdGFQWEJEaXBvaXBWT0dnd21s?= =?utf-8?B?OC9MbVZua0RvNlRWVy9LZ2ZRZVdXeVNvUUZ0azRPSXlsSm9Ed05YY1ZWWUJ4?= =?utf-8?B?Q0R3cHBlejA4Vkh5a3JMUWUxblkvU2kxWUhJVnNSVTZWNGNTTXNuVUhxUEMx?= =?utf-8?B?VjIwalJaYmdFQ1VCcE9uTW1ia1hYUGxHSTVpUVFKKzdOWlNiNzB4eC8wR3hp?= =?utf-8?B?WWRDUVJSeG4vbE5VQlBrcnF0MmJuU01CRFB1Q0YrRS80UXhyM0doUkFuSERL?= =?utf-8?B?eWw5UVV4QzBWRG5jcmZUUVlvcGJJQWRBSTRGRlBwQkl0a1c1eW8raHV0R20r?= =?utf-8?B?RWt3M1BJSGVpSU1kbitiN0dKOC92dzV0Q3FzclhkeEJGREhOVzVPK3hsaHlE?= =?utf-8?B?T2Y0TWJTd0tscWFhK25WTXVvd240MlR2c0s3WDhsNStEYlpxdmZoYkJQZFpT?= =?utf-8?B?TG5qNWZDTW5IQ0RYUGYydjE0d3Ivd3p2UFdaelR0RXdpdVZHOWcxR0E3WHhN?= =?utf-8?B?b212Wk5XOWdtOUg1WXQ1THpaYm5mbDhKWTRPNXdLclYzMU14enBwTS9hMkkr?= =?utf-8?B?Y2d6THFHN3dkS0tZNEdnTCs4WnBhZEZvZ1FIdXFpWlNwaEN3YzZabUNOdXow?= =?utf-8?B?YVRtZVFNdWtwbU9SdkZRZGMxdXlOVVVwZ0oyV2kxZDh0TzQ3eFdxWnFlVS9w?= =?utf-8?B?R0VYR2hxek5CaUczb1FYZVhhOVN0TU02TFp2azNSSVE0c3lkZEZndk5XWjJY?= =?utf-8?B?bFhzV0g1YU1NZUwwOU4xWDJ5STJsYVNrZjRHRVlSdXRSUlZVeWF6SVJ5Q2Ew?= =?utf-8?B?b1JWZzlCQVUrZ1ZsL3dzVXJ5aW1wTUtSV2hXQW50cWRFUGVmVGV5SU1MdUxw?= =?utf-8?B?Snc1Y0JZLzVjZlVUMnlNTjgveW5TT1RaditzRkN5eGZ0ZnlNdnJUY0hsVW0y?= =?utf-8?B?dVNKcUl1V2dCd1V3L0NlcGVocmkxUThsbm1IZFNwZHY0WU5wWXlHd3FObmpW?= =?utf-8?B?VzBCK0pyRlE4OTE4d0VwQWFEa1JWVTNjUUIvcHdDUWtGdEFlb0tyQVpNNmRr?= =?utf-8?B?QXJ4ZDFOYUs1cVZtRGxFLzhtWE5LeUpvY3N0SWo0eEUwM3FPaUhhWk9RS0Rs?= =?utf-8?B?NGNxSWxIRWtqdFJ6N0V2czFLUTlsejFDR0tnd3F5THgvb2Z6U3QwRW5nRzE1?= =?utf-8?B?VWNBeUV6bFR5MTdyMyttZzJERXMwS1B0MVdhaWlzclZQRE83bVlNT0VOOG40?= =?utf-8?B?S3dlWFBwR1IxZDU2RGxJQm1hVXd1d0xFblBqLzJXUGxnVWZ0ZWRsT3pRRVE0?= =?utf-8?B?SHFYTUFNZEpWODYxYms4b3dnTncxM0pwMlN1Tms0NW16SmwzeitKaEtCWmV6?= =?utf-8?B?cFZ0V3pSOGpmUEVCYnhBc3V2MWJmemtaNXQ5WkJ2SEFjRHZ1T29NblhmR1RQ?= =?utf-8?B?K0NqdjAzUis2cGlMRFpsSVpudXpSc2tSeEloQ2hZZDZhMXhXQThmZDZMNmRD?= =?utf-8?B?RjNRNFRhdEJtditvN0FwYmVpTk15SUloTy8wT3M0TTNrM2UwOGY3aFJmbzhl?= =?utf-8?B?YVVobklmUU84L043QTNIL04xZFA0YWJWZ2h3Yjd1WG1WVVV4aGk3dm1JekJ5?= =?utf-8?B?Y0V0U2Y0Wmp4TVoxZjA4ejZha2JEYi9WVVh1YWhHL1BXQm1pM1RqVEJQaFV2?= =?utf-8?Q?dfYBEl2R9hJwZHcM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb57bbeb-090e-4a87-4222-08da34dd5b7e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 12:37:35.4857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fS1zQt0/v+20IDN5oaJkxfFoAqWha9xJB0rqcbrhN2gsrcNRNVmSUOZq7OHMFipHQs8upJJx/prtxXKprLzSxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707 On Fri, May 13, 2022 at 11:18:47AM +0000, Andrew Cooper wrote: > On 13/05/2022 11:35, Roger Pau Monne wrote: > > Some CPU models don't exhibit MCDT behavior, but also don't expose > > MCDT_NO. Set the MCDT_NO bit for CPUs known to not exhibit the > > behavior, so guests can get this information, as using > > family/model/stepping detection when running virtualized is not to be > > relied. > > > > Signed-off-by: Roger Pau Monné > > --- > > xen/arch/x86/cpu/intel.c | 70 ++++++++++++++++++++++++++++++++++++++++ > > xen/arch/x86/cpuid.c | 10 ++++++ > > 2 files changed, 80 insertions(+) > > > > diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c > > index dc6a0c7807..d821f460ae 100644 > > --- a/xen/arch/x86/cpu/intel.c > > +++ b/xen/arch/x86/cpu/intel.c > > @@ -518,6 +518,73 @@ static void intel_log_freq(const struct cpuinfo_x86 *c) > > printk("%u MHz\n", (factor * max_ratio + 50) / 100); > > } > > > > +void update_mcdt_no(struct cpuinfo_x86 *c) > > +{ > > +#define FAM6_MODEL(m, s, c) { 6, m, s, c } > > + /* > > + * List of models that do not exhibit MCDT behavior, but might not > > + * advertise MCDT_NO on CPUID. > > + */ > > + static const struct { > > + uint8_t family; > > + uint8_t model; > > + uint8_t stepping; > > + bool check_stepping; > > + } mcdt_no[] = { > > + /* Haswell Server EP, EP4S. */ > > + FAM6_MODEL(0x3f, 2, true), > > + /* Elkhart Lake. */ > > + FAM6_MODEL(0x3f, 4, true), > > + /* Cherryview. */ > > + FAM6_MODEL(0x4c, 0, false), > > + /* Broadwell Server E, EP, EP4S, EX. */ > > + FAM6_MODEL(0x4f, 0, false), > > + /* Broadwell DE V2, V3. */ > > + FAM6_MODEL(0x56, 3, true), > > + /* Broadwell DE Y0. */ > > + FAM6_MODEL(0x56, 4, true), > > + /* Broadwell DE A1, Hewitt Lake. */ > > + FAM6_MODEL(0x56, 5, true), > > + /* Anniedale. */ > > + FAM6_MODEL(0x5a, 0, false), > > + /* Apollo Lake. */ > > + FAM6_MODEL(0x5c, 9, true), > > + FAM6_MODEL(0x5c, 0xa, true), > > + /* Denverton. */ > > + FAM6_MODEL(0x5f, 1, true), > > + /* XMM7272. */ > > + FAM6_MODEL(0x65, 0, false), > > + /* Cougar Mountain. */ > > + FAM6_MODEL(0x6e, 0, false), > > + /* Butter. */ > > + FAM6_MODEL(0x75, 0, false), > > + /* Gemini Lake. */ > > + FAM6_MODEL(0x7a, 1, true), > > + FAM6_MODEL(0x7a, 8, true), > > + /* Snowridge. */ > > + FAM6_MODEL(0x86, 4, true), > > + FAM6_MODEL(0x86, 5, true), > > + FAM6_MODEL(0x86, 7, true), > > + /* Lakefield B-step. */ > > + FAM6_MODEL(0x8a, 1, true), > > + /* Elkhart Lake. */ > > + FAM6_MODEL(0x96, 1, true), > > + /* Jasper Lake. */ > > + FAM6_MODEL(0x9c, 0, true), > > + { } > > + }; > > +#undef FAM6_MODEL > > + const typeof(mcdt_no[0]) *m; > > + > > + for (m = mcdt_no; m->family | m->model | m->stepping; m++) > > + if ( c->x86 == m->family && c->x86_model == m->model && > > + (!m->check_stepping || c->x86_mask == m->stepping) ) > > + { > > + __set_bit(X86_FEATURE_MCDT_NO, c->x86_capability); > > + break; > > + } > > +} > > Please could we see about using x86_match_cpu() rather than basically > opencoding it?  Linux's bug.c has some fairly comprehensive examples of > how to do tables like this with it. Yes, I know about x86_match_cpu(). I've used this open-coded form because of the conditional extra checking of the stepping which is not handled by x86_match_cpu(). I didn't feel like extending struct x86_cpu_id and x86_match_cpu() just for this use-case, but I could do it. > Also, can we use our shiny new intel-family.h names? > > The stepping checks guidance seems suspect.  Lemme ping some people > about that.  I suspect that means "we checked the production CPUs but > didn't look at the pre-prod hardware" which in practice means we don't > care about steppings listed. OK, that would help quite a lot, as then I could just use plain x86_match_cpu(). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 13:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 13:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328471.551488 (Exim 4.92) (envelope-from ) id 1npVSW-0007Wr-IS; Fri, 13 May 2022 13:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328471.551488; Fri, 13 May 2022 13:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npVSW-0007Wk-Dq; Fri, 13 May 2022 13:35:56 +0000 Received: by outflank-mailman (input) for mailman id 328471; Fri, 13 May 2022 13:35:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npVSV-0007We-K0 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 13:35:55 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b6eef33-d2c1-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 15:35:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b6eef33-d2c1-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652448953; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WRWK83Ad0gqdtXIb6eH1JRxvjxjGgMLq2Q+ZHpZWiwI=; b=aQQRI8JMCdCTj0A20leV4EFR1iyZSVgrx3Xvzq7PSHZsBezEXS5kc/3o F7BC2/rpDY3nyRoatMseZx6Xw0Ng0EN4OQ1dbAeSZmXPYakT5epw3Lmvl 8yH8xENWDEOpAu+8VxHigURprx7qdfHy1zFuFwJdVUVqii6eHRds2JGt1 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71265582 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:4Bkv2qC1Myr8FhVW/0/jw5YqxClBgxIJ4kV8jS/XYbTApDpz3zMEy WIYXWrQM/7bM2Pxeth2aong9x4Gu5fQydZgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng2dYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhAw oRU6s2xTDsAGaPigcQHfhpzDi9HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8XR6iDO ppDAdZpRDL6eAxhOhQ1MosVuMiJpUTwQxNo92vA8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co WDL9Hi/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc hFKvHp1xUQvyKC1Zuj3DgTn8X+Bgjc7VfRJM/cX6yqQxJOBtm51GVM4ZjJGbdUnsuo/Sjory kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG5+OkOYgTzosGP+UJfpvn8AnnOz j+Dt0DSbJ1D3JdQh81XEb0q6g9AR6QlrCZovm07vUr/t2uVgbJJgKTysTDmAQ5odtrxc7V4l CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmCG2g43Q8Z5r271k5JGQWy3yGskTHqFz+5eIWO5C KMtkV05CGBv0IuCMvYsPtPZ5zUCxqn8D9X1Ps04nfIVCqWdgDSvpXk0DWbJhjiFuBF1wckXZ MbAGe7xXClyNEiS5GfvLwvr+eRzln5WKKK6bc2T8ilLJpLEOiHPFedeYAvmgyJQxPrsnTg5O u13b6OioyizmsWnCsUL2eb/9Ww3EEU= IronPort-HdrOrdr: A9a23:3HJ+b6MtrLTlk8BcTsujsMiBIKoaSvp037Eqv3ofdfUzSL38qy nOpoV96faaslcssR0b9OxoW5PwI080l6QU3WB5B97LN2PbUQOTXeVfBODZrQEIdReTygck79 YCT5RD X-IronPort-AV: E=Sophos;i="5.91,223,1647316800"; d="scan'208";a="71265582" From: Anthony PERARD To: CC: Anthony PERARD , Roger Pau Monne , Ian Jackson Subject: [OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF Date: Fri, 13 May 2022 14:35:34 +0100 Message-ID: <20220513133534.88564-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Recent versions of OVMF now need a version of NASM that is newer than the one available on Debian oldstable/buster. They want to use NASM 2.15.05 [1], which is available in Debian stable/bullseye. The need to use a newer version started with d3febfd9ade3 ("MdePkg: Replace Opcode with the corresponding instructions."). There is no backport package available but the nasm package from Debian Bullseye can easily be installed on Buster as it has few dependencies and are already satisfied. [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 ("BaseTools: Upgrade the version of NASM tool") Signed-off-by: Anthony PERARD --- ts-xen-build-prep | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ts-xen-build-prep b/ts-xen-build-prep index 67b3eae62155..38d4a8e79451 100755 --- a/ts-xen-build-prep +++ b/ts-xen-build-prep @@ -250,6 +250,15 @@ END if ($ho->{Arch} eq 'amd64' && $ho->{Suite} !~ m/squeeze|lenny/) { target_install_packages($ho, 'libc6-dev-i386'); } + + # Use newer version of NASM, for OVMF + if ($ho->{Suite} =~ m/buster/) { + my $nasm_pkg = "nasm_2.15.05-1_$ho->{Arch}.deb"; + my $nasm_url = debian_mirror_url_suite_arch("bullseye", $ho->{Arch}) + ."/pool/main/n/nasm/$nasm_pkg"; + target_fetchurl($ho, $nasm_url, "/tmp/$nasm_pkg"); + target_install_packages($ho, "/tmp/$nasm_pkg"); + } } sub ccache_setup () { -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 13 13:44:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 13:44:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328479.551499 (Exim 4.92) (envelope-from ) id 1npVaJ-0000dW-GI; Fri, 13 May 2022 13:43:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328479.551499; Fri, 13 May 2022 13:43:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npVaJ-0000dP-Co; Fri, 13 May 2022 13:43:59 +0000 Received: by outflank-mailman (input) for mailman id 328479; Fri, 13 May 2022 13:43:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npVaH-0000dJ-O9 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 13:43:57 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb11cea7-d2c2-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 15:43:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb11cea7-d2c2-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652449435; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rQC07PpQMF9xJzVeoTFgYv9nHEd76NhVdm5OojvYYRk=; b=EJ2ALCsbPOjScQKSds/p96WEsKlwNiVdXQyhh4Oi1DEvfmpg6s0tSmSS q9BBHClsHL0JQRz4vMjBJvm9YLkZA2/oyslicfEKQRnHTC7c2BEcFMIt3 eqln/bjuRnaEfJhjs+Je2aRzCDmJEmI+xkyPfv+jlMJFp767tHvGAFDRO g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70639408 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5Hueh6z6LqTcGtcI0sx6t+dRxirEfRIJ4+MujC+fZmUNrF6WrkUGz jAWDW2AO6uKN2P1Loh3bd+y80pTvZeEnNE3S1Y6+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IPhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplj5jgFRY4Mob3ns8DDiVRCCtDDadk9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6BP 5RCOGY3PHwsZTUQBUgaJJM/gt7z2FTYaTh7t1aLqfootj27IAtZj+G2bYu9lsaxbcRKnG6Iq 2Te5WP7DxoGctuFxlKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ycRVkWbnBYgZc RZNvHNz8+5iryRHU+URQTWCpC7Yrw8QcOFWOPNn1AiWwJfk6SSWUz1soiF6VPQqs8o/RDoP3 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb1Eqnczp1LEKiYjQZ8xnUy ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AzrNAuBRPtfNi2mUBb/zt64oEWphZgPd1 EXoYuDHhAz0MbmDlTaWXMIGF6yz6vCOPVX02AAyRcJxr2jyoyb5Jei8BQ2Sw28zaK45lcLBO heP6Wu9GrcNVJdVUUOHS93oUJl7pUQRPd/kSurVfrJzjmtZL2e6ENVVTRfIhQjFyRF0+YlmY MfzWZv9Vh4yVPU4pAdass9AiNfHMAhlnTONLX06pjz6uYejiIm9E+laagfeNbBphE5GyS2Mm +ti2wKx4003eIXDjuP/qub/8XhiwaAHOK3L IronPort-HdrOrdr: A9a23:k38+baGgrS5znY7kpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.91,223,1647316800"; d="scan'208";a="70639408" Date: Fri, 13 May 2022 14:43:38 +0100 From: Anthony PERARD To: CC: Roger Pau Monne , Ian Jackson Subject: Re: [OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF Message-ID: References: <20220513133534.88564-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220513133534.88564-1-anthony.perard@citrix.com> On Fri, May 13, 2022 at 02:35:34PM +0100, Anthony PERARD wrote: > Recent versions of OVMF now need a version of NASM that is newer > than the one available on Debian oldstable/buster. They want to use > NASM 2.15.05 [1], which is available in Debian stable/bullseye. The > need to use a newer version started with d3febfd9ade3 ("MdePkg: > Replace Opcode with the corresponding instructions."). > > There is no backport package available but the nasm package from > Debian Bullseye can easily be installed on Buster as it has few > dependencies and are already satisfied. > > [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 > ("BaseTools: Upgrade the version of NASM tool") > > Signed-off-by: Anthony PERARD A flight with my change: http://logs.test-lab.xenproject.org/osstest/logs/170388/ (ignore the failing "libvirt-build" jobs which shouldn't be part of the flight ;-) ) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 13 14:26:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:26:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328488.551510 (Exim 4.92) (envelope-from ) id 1npWFR-0004sp-RM; Fri, 13 May 2022 14:26:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328488.551510; Fri, 13 May 2022 14:26:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFR-0004si-Og; Fri, 13 May 2022 14:26:29 +0000 Received: by outflank-mailman (input) for mailman id 328488; Fri, 13 May 2022 14:26:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFQ-0004sc-UP for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:26:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abf708a6-d2c8-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 16:26:27 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B51AE62154; Fri, 13 May 2022 14:26:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E49D0C34115; Fri, 13 May 2022 14:26:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abf708a6-d2c8-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652451985; bh=LAW3oRY7WSoDZ6V/paLZpl/L6DCV49O7Hv7830ybxPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXyDhOiiJRccrS99PCIsAaKHP9Sfl/W3GtF8OHGZsFeNJgYw2vkdj9lmReCuZSkNW 25YoqfN66gr42evUIl7QNmeNuCH8IypHBLMZpk/+Qzxuxtc4VAsZSMj+3y3daylWvL POShwnNedeIhzgznHSIRDIqrnyaAvDkMlZKy4y9k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masami Hiramatsu , "Peter Zijlstra (Intel)" , Juergen Gross , x86@kernel.org, Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , xen-devel@lists.xenproject.org, Randy Dunlap , Josh Poimboeuf , Maximilian Heyne Subject: [PATCH 5.4 10/18] x86/asm: Allow to pass macros to __ASM_FORM() Date: Fri, 13 May 2022 16:23:36 +0200 Message-Id: <20220513142229.456082257@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513142229.153291230@linuxfoundation.org> References: <20220513142229.153291230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Masami Hiramatsu commit f7919fd943abf0c77aed4441ea9897a323d132f5 upstream. Use __stringify() at __ASM_FORM() so that user can pass code including macros to __ASM_FORM(). Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777562873.25081.2288083344657460959.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/asm.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/arch/x86/include/asm/asm.h +++ b/arch/x86/include/asm/asm.h @@ -7,9 +7,11 @@ # define __ASM_FORM_RAW(x) x # define __ASM_FORM_COMMA(x) x, #else -# define __ASM_FORM(x) " " #x " " -# define __ASM_FORM_RAW(x) #x -# define __ASM_FORM_COMMA(x) " " #x "," +#include + +# define __ASM_FORM(x) " " __stringify(x) " " +# define __ASM_FORM_RAW(x) __stringify(x) +# define __ASM_FORM_COMMA(x) " " __stringify(x) "," #endif #ifndef __x86_64__ From xen-devel-bounces@lists.xenproject.org Fri May 13 14:26:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:26:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328489.551521 (Exim 4.92) (envelope-from ) id 1npWFU-00058R-56; Fri, 13 May 2022 14:26:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328489.551521; Fri, 13 May 2022 14:26:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFU-00058I-17; Fri, 13 May 2022 14:26:32 +0000 Received: by outflank-mailman (input) for mailman id 328489; Fri, 13 May 2022 14:26:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFS-0004sc-UI for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:26:31 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id adbd4c15-d2c8-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 16:26:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF5BB62155; Fri, 13 May 2022 14:26:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B8DAC36AEC; Fri, 13 May 2022 14:26:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adbd4c15-d2c8-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652451988; bh=85U1WWVkHeMQrJWMsxOyN59skP9tpj5MeWFM5A12uXE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z69z3oDXPD21rNW9i5pU2xdBQSPQGAePhxjHL1MhlizvNubIkg2KtoA/5NPLc35nb WRkITwqgnicSG/5sBtZg7Vm2LyEr3KCNf86g+8MC7GZbp5HhpQMlVmZixtDqTet+1D sspSucBEntU5Btet39kQCTflWgfYlUUZ4zmPy+Vg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Zijlstra , Masami Hiramatsu , Juergen Gross , x86@kernel.org, Ingo Molnar , Boris Ostrovsky , Andrew Cooper , Stefano Stabellini , Borislav Petkov , xen-devel@lists.xenproject.org, Randy Dunlap , Josh Poimboeuf , Maximilian Heyne Subject: [PATCH 5.4 11/18] x86: xen: kvm: Gather the definition of emulate prefixes Date: Fri, 13 May 2022 16:23:37 +0200 Message-Id: <20220513142229.483992618@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513142229.153291230@linuxfoundation.org> References: <20220513142229.153291230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Masami Hiramatsu commit b3dc0695fa40c3b280230fb6fb7fb7a94ce28bf4 upstream. Gather the emulate prefixes, which forcibly make the following instruction emulated on virtualization, in one place. Suggested-by: Peter Zijlstra Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Ingo Molnar Cc: Boris Ostrovsky Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777563917.25081.7286628561790289995.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/emulate_prefix.h | 14 ++++++++++++++ arch/x86/include/asm/xen/interface.h | 11 ++++------- arch/x86/kvm/x86.c | 4 +++- 3 files changed, 21 insertions(+), 8 deletions(-) create mode 100644 arch/x86/include/asm/emulate_prefix.h --- /dev/null +++ b/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif --- a/arch/x86/include/asm/xen/interface.h +++ b/arch/x86/include/asm/xen/interface.h @@ -379,12 +379,9 @@ struct xen_pmu_arch { * Prefix forces emulation of some non-trapping instructions. * Currently only CPUID. */ -#ifdef __ASSEMBLY__ -#define XEN_EMULATE_PREFIX .byte 0x0f,0x0b,0x78,0x65,0x6e ; -#define XEN_CPUID XEN_EMULATE_PREFIX cpuid -#else -#define XEN_EMULATE_PREFIX ".byte 0x0f,0x0b,0x78,0x65,0x6e ; " -#define XEN_CPUID XEN_EMULATE_PREFIX "cpuid" -#endif +#include + +#define XEN_EMULATE_PREFIX __ASM_FORM(.byte __XEN_EMULATE_PREFIX ;) +#define XEN_CPUID XEN_EMULATE_PREFIX __ASM_FORM(cpuid) #endif /* _ASM_X86_XEN_INTERFACE_H */ --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #define CREATE_TRACE_POINTS @@ -5583,6 +5584,7 @@ EXPORT_SYMBOL_GPL(kvm_write_guest_virt_s int handle_ud(struct kvm_vcpu *vcpu) { + static const char kvm_emulate_prefix[] = { __KVM_EMULATE_PREFIX }; int emul_type = EMULTYPE_TRAP_UD; char sig[5]; /* ud2; .ascii "kvm" */ struct x86_exception e; @@ -5590,7 +5592,7 @@ int handle_ud(struct kvm_vcpu *vcpu) if (force_emulation_prefix && kvm_read_guest_virt(vcpu, kvm_get_linear_rip(vcpu), sig, sizeof(sig), &e) == 0 && - memcmp(sig, "\xf\xbkvm", sizeof(sig)) == 0) { + memcmp(sig, kvm_emulate_prefix, sizeof(sig)) == 0) { kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(sig)); emul_type = EMULTYPE_TRAP_UD_FORCED; } From xen-devel-bounces@lists.xenproject.org Fri May 13 14:26:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:26:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328490.551532 (Exim 4.92) (envelope-from ) id 1npWFY-0005RG-Bs; Fri, 13 May 2022 14:26:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328490.551532; Fri, 13 May 2022 14:26:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFY-0005R5-8K; Fri, 13 May 2022 14:26:36 +0000 Received: by outflank-mailman (input) for mailman id 328490; Fri, 13 May 2022 14:26:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFW-0005P5-M4 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:26:34 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afef8fa8-d2c8-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:26:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 370F9B83073; Fri, 13 May 2022 14:26:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51036C34100; Fri, 13 May 2022 14:26:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afef8fa8-d2c8-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652451991; bh=0C1cmO61Qt6CWllfe71gI5XVVBFSNf2m2kyZRF4iiWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q/gOHPrsmHmQ9IgCarEV10qPdGKt3nqPlxqY04cerC2lHLbfz4DTNT6Q9HT1yYIMI DcEQ9LlYAQYhA4E2pu9IKB4z/SeNVOCI1Wt36jtljXQEYmjpy8qdVCQ2q19vrFziyS dnLt1VwR8GS5DFrWi8aC1pgrkZ1tREdTYCk/k1S8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masami Hiramatsu , "Peter Zijlstra (Intel)" , Josh Poimboeuf , Juergen Gross , x86@kernel.org, Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , xen-devel@lists.xenproject.org, Randy Dunlap , Maximilian Heyne Subject: [PATCH 5.4 12/18] x86: xen: insn: Decode Xen and KVM emulate-prefix signature Date: Fri, 13 May 2022 16:23:38 +0200 Message-Id: <20220513142229.512910493@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513142229.153291230@linuxfoundation.org> References: <20220513142229.153291230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Masami Hiramatsu commit 4d65adfcd1196818659d3bd9b42dccab291e1751 upstream. Decode Xen and KVM's emulate-prefix signature by x86 insn decoder. It is called "prefix" but actually not x86 instruction prefix, so this adds insn.emulate_prefix_size field instead of reusing insn.prefixes. If x86 decoder finds a special sequence of instructions of XEN_EMULATE_PREFIX and 'ud2a; .ascii "kvm"', it just counts the length, set insn.emulate_prefix_size and fold it with the next instruction. In other words, the signature and the next instruction is treated as a single instruction. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Acked-by: Josh Poimboeuf Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Link: https://lkml.kernel.org/r/156777564986.25081.4964537658500952557.stgit@devnote2 [mheyne: resolved contextual conflict in tools/objtools/sync-check.sh] Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/insn.h | 6 ++++ arch/x86/lib/insn.c | 34 ++++++++++++++++++++++++++++ tools/arch/x86/include/asm/emulate_prefix.h | 14 +++++++++++ tools/arch/x86/include/asm/insn.h | 6 ++++ tools/arch/x86/lib/insn.c | 34 ++++++++++++++++++++++++++++ tools/objtool/sync-check.sh | 3 +- tools/perf/check-headers.sh | 3 +- 7 files changed, 98 insertions(+), 2 deletions(-) create mode 100644 tools/arch/x86/include/asm/emulate_prefix.h --- a/arch/x86/include/asm/insn.h +++ b/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct in return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { --- a/arch/x86/lib/insn.c +++ b/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include #include +#include + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); --- /dev/null +++ b/tools/arch/x86/include/asm/emulate_prefix.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_EMULATE_PREFIX_H +#define _ASM_X86_EMULATE_PREFIX_H + +/* + * Virt escape sequences to trigger instruction emulation; + * ideally these would decode to 'whole' instruction and not destroy + * the instruction stream; sadly this is not true for the 'kvm' one :/ + */ + +#define __XEN_EMULATE_PREFIX 0x0f,0x0b,0x78,0x65,0x6e /* ud2 ; .ascii "xen" */ +#define __KVM_EMULATE_PREFIX 0x0f,0x0b,0x6b,0x76,0x6d /* ud2 ; .ascii "kvm" */ + +#endif --- a/tools/arch/x86/include/asm/insn.h +++ b/tools/arch/x86/include/asm/insn.h @@ -45,6 +45,7 @@ struct insn { struct insn_field immediate2; /* for 64bit imm or seg16 */ }; + int emulate_prefix_size; insn_attr_t attr; unsigned char opnd_bytes; unsigned char addr_bytes; @@ -128,6 +129,11 @@ static inline int insn_is_evex(struct in return (insn->vex_prefix.nbytes == 4); } +static inline int insn_has_emulate_prefix(struct insn *insn) +{ + return !!insn->emulate_prefix_size; +} + /* Ensure this instruction is decoded completely */ static inline int insn_complete(struct insn *insn) { --- a/tools/arch/x86/lib/insn.c +++ b/tools/arch/x86/lib/insn.c @@ -13,6 +13,8 @@ #include "../include/asm/inat.h" #include "../include/asm/insn.h" +#include "../include/asm/emulate_prefix.h" + /* Verify next sizeof(t) bytes can be on the same instruction */ #define validate_next(t, insn, n) \ ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) @@ -58,6 +60,36 @@ void insn_init(struct insn *insn, const insn->addr_bytes = 4; } +static const insn_byte_t xen_prefix[] = { __XEN_EMULATE_PREFIX }; +static const insn_byte_t kvm_prefix[] = { __KVM_EMULATE_PREFIX }; + +static int __insn_get_emulate_prefix(struct insn *insn, + const insn_byte_t *prefix, size_t len) +{ + size_t i; + + for (i = 0; i < len; i++) { + if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i]) + goto err_out; + } + + insn->emulate_prefix_size = len; + insn->next_byte += len; + + return 1; + +err_out: + return 0; +} + +static void insn_get_emulate_prefix(struct insn *insn) +{ + if (__insn_get_emulate_prefix(insn, xen_prefix, sizeof(xen_prefix))) + return; + + __insn_get_emulate_prefix(insn, kvm_prefix, sizeof(kvm_prefix)); +} + /** * insn_get_prefixes - scan x86 instruction prefix bytes * @insn: &struct insn containing instruction @@ -76,6 +108,8 @@ void insn_get_prefixes(struct insn *insn if (prefixes->got) return; + insn_get_emulate_prefix(insn); + nb = 0; lb = 0; b = peek_next(insn_byte_t, insn); --- a/tools/objtool/sync-check.sh +++ b/tools/objtool/sync-check.sh @@ -4,6 +4,7 @@ FILES=' arch/x86/include/asm/inat_types.h arch/x86/include/asm/orc_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk ' @@ -46,4 +47,4 @@ done check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -28,6 +28,7 @@ arch/x86/include/asm/disabled-features.h arch/x86/include/asm/required-features.h arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/inat_types.h +arch/x86/include/asm/emulate_prefix.h arch/x86/include/uapi/asm/prctl.h arch/x86/lib/x86-opcode-map.txt arch/x86/tools/gen-insn-attr-x86.awk @@ -116,7 +117,7 @@ check lib/ctype.c '-I "^EXPORT_SY check arch/x86/include/asm/inat.h '-I "^#include [\"<]\(asm/\)*inat_types.h[\">]"' check arch/x86/include/asm/insn.h '-I "^#include [\"<]\(asm/\)*inat.h[\">]"' check arch/x86/lib/inat.c '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"' -check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]"' +check arch/x86/lib/insn.c '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"' # diff non-symmetric files check_2 tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl From xen-devel-bounces@lists.xenproject.org Fri May 13 14:26:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328491.551543 (Exim 4.92) (envelope-from ) id 1npWFa-0005kB-MM; Fri, 13 May 2022 14:26:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328491.551543; Fri, 13 May 2022 14:26:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFa-0005k0-II; Fri, 13 May 2022 14:26:38 +0000 Received: by outflank-mailman (input) for mailman id 328491; Fri, 13 May 2022 14:26:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWFZ-0005P5-3Q for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:26:37 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b20125d0-d2c8-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:26:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 242DBB8306B; Fri, 13 May 2022 14:26:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 432FDC34100; Fri, 13 May 2022 14:26:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b20125d0-d2c8-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652451994; bh=arJTKN6Rb4CHGdT1xDXtM3SZJ76Ck5SXwxLc4XVG6h0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lkj2UAFs1vyUgNw/OznDpD3UdBVqNE8K6RAGjcXiZQCZEK2nLckNHvZ2JSX7w9XQR 2zCCsajBmD87WM3JZKnp+P4hwCHqObdQNspqV1ZZhhbcwPjJchztmAo7B1qVwi83FN 5d/y+2eEEMXvBV1OgINjBSgL470b4SpjEs26yluY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masami Hiramatsu , "Peter Zijlstra (Intel)" , Juergen Gross , x86@kernel.org, Boris Ostrovsky , Ingo Molnar , Stefano Stabellini , Andrew Cooper , Borislav Petkov , xen-devel@lists.xenproject.org, Randy Dunlap , Josh Poimboeuf , Maximilian Heyne Subject: [PATCH 5.4 13/18] x86: kprobes: Prohibit probing on instruction which has emulate prefix Date: Fri, 13 May 2022 16:23:39 +0200 Message-Id: <20220513142229.541060503@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513142229.153291230@linuxfoundation.org> References: <20220513142229.153291230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Masami Hiramatsu commit 004e8dce9c5595697951f7cd0e9f66b35c92265e upstream. Prohibit probing on instruction which has XEN_EMULATE_PREFIX or KVM's emulate prefix. Since that prefix is a marker for Xen and KVM, if we modify the marker by kprobe's int3, that doesn't work as expected. Signed-off-by: Masami Hiramatsu Signed-off-by: Peter Zijlstra (Intel) Cc: Juergen Gross Cc: x86@kernel.org Cc: Boris Ostrovsky Cc: Ingo Molnar Cc: Stefano Stabellini Cc: Andrew Cooper Cc: Borislav Petkov Cc: xen-devel@lists.xenproject.org Cc: Randy Dunlap Cc: Josh Poimboeuf Link: https://lkml.kernel.org/r/156777566048.25081.6296162369492175325.stgit@devnote2 Signed-off-by: Maximilian Heyne Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/kprobes/core.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/arch/x86/kernel/kprobes/core.c +++ b/arch/x86/kernel/kprobes/core.c @@ -358,6 +358,10 @@ int __copy_instruction(u8 *dest, u8 *src kernel_insn_init(insn, dest, MAX_INSN_SIZE); insn_get_length(insn); + /* We can not probe force emulate prefixed instruction */ + if (insn_has_emulate_prefix(insn)) + return 0; + /* Another subsystem puts a breakpoint, failed to recover */ if (insn->opcode.bytes[0] == BREAKPOINT_INSTRUCTION) return 0; From xen-devel-bounces@lists.xenproject.org Fri May 13 14:33:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:33:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328486.551554 (Exim 4.92) (envelope-from ) id 1npWLx-00086g-Ko; Fri, 13 May 2022 14:33:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328486.551554; Fri, 13 May 2022 14:33:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWLx-00086Z-Gj; Fri, 13 May 2022 14:33:13 +0000 Received: by outflank-mailman (input) for mailman id 328486; Fri, 13 May 2022 14:22:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWBj-0004p3-Cv for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:22:39 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 236260f1-d2c8-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:22:37 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id w4so11626782wrg.12 for ; Fri, 13 May 2022 07:22:37 -0700 (PDT) Received: from [192.168.0.194] (hipert-gw1.mat.unimo.it. [155.185.5.1]) by smtp.gmail.com with ESMTPSA id n14-20020a05600c500e00b00394708a3d7dsm5660714wmr.15.2022.05.13.07.22.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 07:22:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 236260f1-d2c8-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=kyrS36o/jWnUwfrq0CADzTAZFrVRLPWZX0OrC8tFl+M=; b=Rj2BWwN34D0wilE28GH+0shlMocKZtGVsy0IBmwkNSsMNCIaCMp181H4k3RYv8PNil 0vWxCvdOWWLqJRjIsQjSsqfHu8JkPkqsPOJwZO6t0GM0eh5o8eGP2x9p7J+8hT0/mQdO HeLdFnUXYsi+YYTIrkn+jZrZlRVFe1Mte9efzY5Ln8TPYCzSMW70kfqvRVPKNF16Zz4n C7XOL1VqId6MQ38BJWocOHBR70aC6FEKFon+jP0ULVXKpz1qxOugEb19JY8gIRSJOY3h jz+yahPc8C3oT4ndek+6OuIpjHkzofEA0OK2yq8ch1Du9FR45NnkjeM69rkuUAH5q3Mf imbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=kyrS36o/jWnUwfrq0CADzTAZFrVRLPWZX0OrC8tFl+M=; b=YyJHda1wyse+jWmA4TtrULLkQTzv7Rmfcw4SefgWPSfqoFWPBLOU4WC4IEhRVThqpo iqaW9Sot6ZuHURpnC9A6LADHVDR08Vo/Q4Bk+iS61qblIx+gRqzyzmn1Hgl1g1W+ooNj wP1ldCSj+A6SrtOyjYk2gvR1kZX1O4GjXfa5t8I5u6+WVcrl1ZXXdOeMwbecqd33eTVl HHFNhpqxIaf0xUiat6nA3Hca99TDwVJefBMto5y/PmQglG3tpFmaWbOCbKWrgUOm2Fsk kY0AkHbZaXo9dUNAvBEFVcluV/ldScQ10XU6GJgrsYNgpLGpcMj0Wz6Jgll3c20fxCu5 UlyQ== X-Gm-Message-State: AOAM5309+z2WEf0T4OOkBVBOevniYuqPfLgnGJoeXoiJelFJj+44nQOC JsBrx3dooy4GJ8SQc+Jq6WPZ7g== X-Google-Smtp-Source: ABdhPJxFyhcZAm06ayS+ue/NVo9BHkth/1yAwOPuYUq3ZH9FU3ybnEFpKYElXF7SQdmZBwc86GSS2A== X-Received: by 2002:a5d:6112:0:b0:20c:f4a5:cd28 with SMTP id v18-20020a5d6112000000b0020cf4a5cd28mr1398859wrt.299.1652451756763; Fri, 13 May 2022 07:22:36 -0700 (PDT) Message-ID: <7acb1709-344d-6995-ee9d-df6652d505b5@minervasys.tech> Date: Fri, 13 May 2022 16:22:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 From: Carlo Nonato Subject: Re: [PATCH 04/36] xen/arm: add parsing function for cache coloring configuration To: Julien Grall , Marco Solieri , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Marco Solieri , Andrea Bastoni , Stefano Stabellini References: <20220304174701.1453977-1-marco.solieri@minervasys.tech> <20220304174701.1453977-5-marco.solieri@minervasys.tech> <2f357e1a-df8e-6326-267e-4d12e82e1a5f@xen.org> Content-Language: en-US In-Reply-To: <2f357e1a-df8e-6326-267e-4d12e82e1a5f@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, I'm Carlo, the new developer that will work on this patch set and on the review. Thanks for all the comments. I'll try to answer to all the open points and also ask for feedback. On 09/03/22 20:09, Julien Grall wrote: >> - way_size: The size of a LLC way in bytes. This value is mainly used >>    to calculate the maximum available colors on the platform. > > We should only add command line option when they are a strong use > case. In documentation, you wrote that someone may want to overwrite > the way size for "specific needs". > > Can you explain what would be those needs? This parameter is here mainly to support QEMU on which the automatic probing of the LLC size doesn't work properly. Also, since from this value we compute the maximum number of colors the architecture supports, you may want to fix the way size so as to simulate a different use case for debugging purposes. Should I add those notes somewhere (doc, commit messages, etc.)? >> A cache coloring configuration consists of a selection of colors to be >> assigned to a VM or to the hypervisor. It is represented by a set of >> ranges. Add a common function that parses a string with a >> comma-separated set of hyphen-separated ranges like "0-7,15-16" and >> returns both: the number of chosen colors, and an array containing their >> ids. >> Currently we support platforms with up to 128 colors. > > Is there any reason this value is hardcoded in Xen rather than part of > the Kconfig? Having another parameter to configure can complicate things from the user perspective. Also 128 is more than enough for the current ARM processors we tested. >> Signed-off-by: Luca Miccio >> Signed-off-by: Marco Solieri >> Signed-off-by: Stefano Stabellini >> --- >>   xen/arch/arm/Kconfig                |   5 ++ >>   xen/arch/arm/Makefile               |   2 +- >>   xen/arch/arm/coloring.c             | 131 ++++++++++++++++++++++++++++ >>   xen/arch/arm/include/asm/coloring.h |  28 ++++++ >>   4 files changed, 165 insertions(+), 1 deletion(-) >>   create mode 100644 xen/arch/arm/coloring.c >>   create mode 100644 xen/arch/arm/include/asm/coloring.h >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index ecfa6822e4..f0f999d172 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -97,6 +97,11 @@ config HARDEN_BRANCH_PREDICTOR >>           If unsure, say Y. >>   +config COLORING >> +    bool "L2 cache coloring" >> +    default n > > This wants to be gated with EXPERT for time-being. SUPPORT.MD woudl > Furthermore, I think this wants to be gated with EXPERT for the > time-being. > >> +    depends on ARM_64 > > Why is this limited to arm64? Because arm32 isn't an "interesting" architecture where to have coloring since there are locking primitives that provides sufficient isolation and so the problem is not common. On x86 instead, the functions that map memory into caches are not so easy to exploit to achieve isolation. Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Fri May 13 14:33:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:33:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328521.551565 (Exim 4.92) (envelope-from ) id 1npWMd-0000EH-TO; Fri, 13 May 2022 14:33:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328521.551565; Fri, 13 May 2022 14:33:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWMd-0000EA-QY; Fri, 13 May 2022 14:33:55 +0000 Received: by outflank-mailman (input) for mailman id 328521; Fri, 13 May 2022 14:33:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWMc-0008Tw-Ic for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:33:54 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b50829b5-d2c9-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:33:52 +0200 (CEST) Received: from mail-bn1nam07lp2040.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 10:33:46 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by MW4PR03MB6524.namprd03.prod.outlook.com (2603:10b6:303:127::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 14:33:41 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.014; Fri, 13 May 2022 14:33:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b50829b5-d2c9-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652452432; h=from:to:cc:subject:date:message-id:mime-version; bh=+jpNM+czW8A7/uCgkLM+7pl+hrs0Gr/18GnPnKfQtLo=; b=bx08c81FBcdoE6tihnk6iEXubT31YFfArh5mulVCSAhZmCLU9lvcNdYK xj+xJZ8mSmHeawZtQVJoYYmAzTn0xkL1fjMCu2Sb6ww1g1taF7F3NP1vX AE7d5AgDzsBI0RPI3UALPbGqxt+UwzEZ6HArutH/1TZc/ipLsppsF+ttZ w=; X-IronPort-RemoteIP: 104.47.51.40 X-IronPort-MID: 73759418 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zONEmajpU4P8NIjDmhJdtx/RX161zhEKZh0ujC45NGQN5FlGYwSy9 lOraxnFY6jUMyawOYxoOc7lxf41yZHXzII3TlQ6/H1jFS0T9cCbCdrFdkmpY3/OdJOcRhJrv 59HN9Kccc5tHi/R+E/3Y7G/oXNy2fGFTOWlWeSZNnEZqWOIMMsEoUsLd7kR3t446TTAPz6wh D/SnyH+EFb0g2YtPjoZtPnZ9Blm7az/5j1JtAA0PfsS4AWAnCNJXc4Tfa2/ESD1E9JedgKYq 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1DI0BK6YoD66vR4jnVaPp0TabxNMC+7tx3Tx4ork IgU7sTqIesUFvakdNo1AkEw/x5WZcWqyJefSZRomZXOp6FuWyKEL8RGVCnaD6VBkgpEKTgmG cgjACIMdni+a9eem9pXfAXOavMLd6EHNKtH0p1pIKqw4fwOGfgvSI2SjTNUMatZammj0p8ya uJAAQeDYigsbDV9I24qJ9EEo96Kl3/PaS9Zl1HWt7Motj27IAxZiNABMfLzU/nSH4B/uB/do WjLuWPkHhsdKdqTjyKf9W6hjfPOmiW9X58OELq/9bhhh1j7Km47UUVKEwfk56TgzBLmMz5cA xV8Fi4GgqU17kOmCPXgWRmxuFaPvwIGWsoWGOo/gO2I4vWPvFvIWjFUJtJHQIIqjslmYxcr7 1uQ3NiqACZ3gp2JClvIo994qhv3Y0D5N1QqZyUJUA8E6NnLu5wog1TESdMLOIS4lMHvEDf8h RWDtjEjhq47hNQOka68+DjvgS+op5XPZh444EPQRG3NxhhieIevaois6F7axfVNNoCUSh+Gp ndss9iT6qUCAI+AkASJQf4RB/e56vCdKjrejFVzWZ47+FyF+XG5eptLyCpjP0ovOcEBEQIFe 2fWsAJVoZVVZX2jaPcoZ5rrU5hyi6/9Cd7iS/bYKMJUZYR8fxOG+ycoYlOM22fqkw4nlqRX1 YqnTPtAxE0yUcxPpAdajc9GuVP37kjSHV/ueK0= IronPort-HdrOrdr: A9a23:Vbhqo6yjaW8cs1QYEeduKrPxnOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBYpTiBUJPwIk80hqQFmbX5XI3SFzUO3VHFEGgM1/qE/9SNIUzDH41mpO 1dmspFebvN5DFB5K6UjjVQeOxQouVvhZrY4ds2uE0dKD2CBZsB0y5JTiKgVmFmTghPApQ0UL CG4NBcmjamcXMLKuymG3gsRYH41pH2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8F LCjxfy6syYwr6GI17npiHuBqZt6ZvcI+h4dY+xYw8uW3fRYzOTFcVcsnu5zXUISa+UmRIXeZ L30mwd1oxImgnslyeO0FbQMkDboUoTwm6nxlmCjXT5p8vlADo8FspanIpcNgDU8kw6obhHod R2N/LwjesrMfrsplWI2zHzbWAcqqN0mwtTrccDy3hEFYcOYr5YqoISuEtTDZcbBSr/rIQqCv NnAs3Q7OtfNQryVQGQgkB/hNi3GngjFBaPRUYP/sSTzjhNhXh8i08V3tYWkHsM/I80D5NE++ PHOKJ1k6wmdL5eUYttQOMaBcenAG3ERhzBdGqUPFT8DakCf2nArpbmiY9Fkd1CuKZ4vqfatK 6xLm+w71RCBH4GIff+raFj41TKXHi3Wyjrx4VX+4V504eMN4bWDQ== X-IronPort-AV: E=Sophos;i="5.91,223,1647316800"; d="asc'?scan'208";a="73759418" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kTVIYA7mo6je4cyS7pa8amrds1Tq214VQbF+jJH3KgoFVAIZtYx3ToBqUYA8JfqGHZNHkZEP0W5Tn1d3AWSXcuH6EEYoiEs08TFrOg40CPgpRPW5HLH0moSjcBEyyAwFYVb7oevPk4gjlanV8neMJH2WUGnin6NnQQJhJUp2s+0AL4WhdksqKB0OL+SJizH2HwNPiTEoTNQ5Sx/oePnjOC/MvuOrnsXTf4IipnzjX/IkSJkzbcgf1woswOQl4TprkgPdk0UNsDsG6OQL0RPSDjvdbSTNsFHU7iFRH1V2KCqOa0QgfM0Diknm4tQVG8aliXL6HF15Dw2/N15uaxFGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfWjeWJ5F6b0q4cP6BoEx2st6elkpyS+axL6JKzqyZc=; b=QLstdDi4pqW0qvYGUrQzTXFFG1YXQoh00p3IwTk35uKMWV4xbLoCtAMHv1I8KUnygKXR55AMhi0DIwwLDxvCmjitnIAvuVDQsNj7AvKqjx7xRn2mnbLKOUdUNOVFrGzbNFDhso3zZ0lTeApcg+jI4apKBxbpe3kqEYYWJHYk2PESmmomfMo0NAqcbLekisWI9cmiQuRGBxyzKP4/3T5QEhdi0bECgoTuLJ9KiPaAlKZDXFgN1+RWkkAQigb3Yh911QxvAWjNM4bFSLAfT3a77dPLKe9OMUhe8Wl4R1/qybO3uV1zY0mzdc4oIntrQFySze6qxwZ+N5o1LDphoPmlfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfWjeWJ5F6b0q4cP6BoEx2st6elkpyS+axL6JKzqyZc=; b=anV4NfoPdkQcvnX05fRzdsRjBEHlXVI9eDePwK9fuXtLwY820n0H5Wbjw4IH2V2KpUXnjUGMSPTxbF7HsiXi40s8FEtqxplwB85PiiZodjyfB+s8g+ZMhdHQck5OO/IkjvPZSc2rqI7FTStLGF4BePcTzGQTevBtFuApFcLxViE= From: George Dunlap To: Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini CC: xen-devel , Juergen Gross , Roger Pau Monne Subject: Process for cherry-picking patches from other projects Thread-Topic: Process for cherry-picking patches from other projects Thread-Index: AQHYZtZwibZ3DwtT5Ea5wKgBtO2ACA== Date: Fri, 13 May 2022 14:33:40 +0000 Message-ID: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5abaee09-931a-45d6-249e-08da34ed933b x-ms-traffictypediagnostic: MW4PR03MB6524:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xb+xFYRX5wIPmXwDDZQ+uO9OaaNYfMQxNwAP39DDToTp/Y1zEOg51vyA6FZCCi4hMeX2OnmXrnFATzSoRaCyZTSxbu/5NnoJyrTVpgCMMH4OYwK0WdsSUl540Et6mvEsX7W27xotCZrSOHz7uWsELvgKBVrd4/B8EOvWAEjXJ8BADoulCNUlefBliFoumNwcB5tvwkd4ES+KObnlJ+qguhXzGZ2kDPtfPcs0Iz5jDqhtzLRFuzKuPYflwwjn37SZj2HHV5OMAzP5PiBTb5ebPHjGMp2K6W6rz6D5rit/v7JDPzsRRbFIVv+a83JUlY6CZk9WG00eLqJmnSlCrdV0yigEDc5CbC9du6jlWKHYDas6JN4EceLWk6yWBnFohE5+jPNMlayeO7nQf2PTtoWZxOslVAohnoploOLxxW9gjWtAE3J0fP18Z4gZd2NnO6H3hsJlFE8Iq8ApQj1HEsTcMVN5uS77KrqZgi2UeHts9wP2yCgxjNV58QYhxMoAswpHOLkzzLylA1DY+NiQs2b56NSR3fFeE1WmZ3VGzEZzBuTrmRXZh6el71t9PjPW3qSSlrzwFxRwHPxX5u3Tvh3aG/WEup3K2Mfpgoy6/L7F5TpZ9CIeanSxpkcCpc5qbNB0AGCUbB3ENr49ulgStjM6Yr1rTipsb1S4ZvSO/41Ax+FF0vafGyYTNLSYql5/5wl9/2qFMt0HzFlmOFiMtXQRrOkTsrtH9hKcUd9xnXTUFIpl0yk31Vpl9S8i232JPte4VVDhBl2tFcqXjf9xqg2A03dQsUP2OFkaN3Xxj0ISKC4oSbkSytn6PF2zGfWxWRajj6ybpyZILYDQypFgwNPrwg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(2616005)(26005)(6512007)(186003)(2906002)(6506007)(83380400001)(71200400001)(5660300002)(6486002)(508600001)(91956017)(33656002)(8936002)(64756008)(76116006)(84970400001)(66446008)(66946007)(66476007)(66556008)(86362001)(8676002)(4326008)(316002)(38100700002)(38070700005)(36756003)(122000001)(110136005)(54906003)(82960400001)(99936003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V0dQRkEwUklrYWJLUTFoUU9pY3BJbzJJbExpclhOZjNHVkExRTAyOVNDNXJ4?= =?utf-8?B?aHVEellSWmczZm82UWprTGVlZnJ2UnFMWVJwa1BQamZYeDJEa1l5WEJpbmU2?= =?utf-8?B?bnRnOVpZaFVrVjVOUHlyQW9XeGlYTThYSnNwYm9iV3dLNncwemU4V1NKSVlw?= =?utf-8?B?VXlNRCtzUm5SWXFBeCs4cUtBNmhTZ21BN0pHN1dYWnNKdE5DMWVPeEVHaHBH?= =?utf-8?B?SzhGa0xEbXRpZkdYUDhscFdxdWJWcWlsbnp5eXpUb0xReTV0RGgybHQxYVNm?= =?utf-8?B?N0VQWXZOUWFsVzltZEUxTDZZb3NXZ2lpcVFvQ1E5QzlpOGx4U1pPQ205c2pw?= =?utf-8?B?TWZITHJEdTB2MDBlaGxZTENZeGkvWXlKbzIya3VoTXNJejRmaURXR3RYdkNU?= =?utf-8?B?bmkyRnRkSDZtTWhDemVRTGJXUDRPMlUxWUFjZVVHWDhuZzMwR2MzYkpjNHk4?= =?utf-8?B?Y3k2UVhVN0wzMFdPdG9GZEc2b3hDeFdCd25hZStUYVRkY1hkUGF0cXRhdDh1?= =?utf-8?B?OU9mUEF0bW0zUitqc3BiQmhpZTI0dXhhbS9SWUI2Nnh6QlhWUVk2THAzNGRr?= =?utf-8?B?UkwrbTVaK2NIMmJDTUlFbUJCd3ExUHlkZ2k3RHFub1hBKzJCQngvWXZsRWdj?= =?utf-8?B?N2MxdWdNczVNZzloNE5FV3I3TGFBelh0aGx3d050SDk1SGxSeEFjbFBydkE4?= =?utf-8?B?MXZkZ2hPVzc5Y3pvWU4wd1p4NFJDWTZ0WGVEcGxIQ2paTmFrZUsxcXoyWE1H?= =?utf-8?B?Ynp3UCtOcnJHWVNxR2dGclVCUVJOd2ZMQnloem9qT1IvRkp2U0llVW9lNWRL?= =?utf-8?B?Mlo1QUFXR3NLY1ltWUdyTElHQ0wydFF5RzJueHY4SWpORUdDRjJnbWppY1p6?= =?utf-8?B?ZlhXN3pLOFdkSTYxZHo0d0tjNDV1N0VuV3RlU3ptTU1uTDdWR0hMUlY0WXR1?= =?utf-8?B?SHE2ZExYekhJQm5EdWF0R0tvS3dxZ0JCYkJwbFByOE1LOHZXQnV5STg3NER5?= =?utf-8?B?cWtqdUNrM01JMks3bjVxUGErTkcrajVkM3NEVHl3OFZBMURyQ0IxVXNHbEUy?= =?utf-8?B?alV4cHRkTXNyeWo5ZHNHRzZGZkR5c0RmM05rdEg5SG5FQzV4OFFheWdhSy9X?= =?utf-8?B?b3BkUyt6Z3c4cXlCeDJ6MUwyTk9tQ0VXL3h4QlpuZU5paElHV09xZ0g4eHJY?= =?utf-8?B?YzlYNGZaN0RocWJRSjhtS3NoWE9VK2pDMWptUWV1TTlrellFNy9ZNzVleW5F?= =?utf-8?B?cTZYcmRHT1JYem9QY0lVMjZjT3AxQlBPOUw1ZklrNGVPVVpDYk1lOWhNckQx?= =?utf-8?B?alAvVDBPT3hYV1J3WUNSQlJPWVlTT3NlTzQ2QjRrN3IxSTVJVWthRTQ0VDl0?= =?utf-8?B?QWpEY2gzb0M5dUhteTltcTJrZ1FneHQ4MkNmakpudUFlVEVPVG1jTlF5bTZM?= =?utf-8?B?c3hBMU45SlN2UUhFUlhxcllLdkJONXVYbEh0YzJvYTZNaVdTaUdDczUwTnBR?= =?utf-8?B?d0VoOThXSzV2YWlESW11c1owaStHcnV5eVkzajltaHEwbWt0QUk1L01KcWZG?= =?utf-8?B?dk1SQjdHWHdqb29VOGRaWllyNko2Qk5yUWN5RmpXb2V0UnQ3LzdpeVozOFE3?= =?utf-8?B?RE9PVDR3c08reUZkc3R3K0M4OGYzanQvL2dPWHBzZ0JWSnJFK2F6amtBZTBX?= =?utf-8?B?WjBPblppVXZpNHZlTTlrbGVGcXgwaXBKeXI2eVFtTUJrMmx6QlFaQWg4Ukk5?= =?utf-8?B?ekVIYWhnaVJ1VjIyQ2Q0Y1RmaDVLaG9rQW9YNHp6VHVyWXhVWWFwc01SSjZh?= =?utf-8?B?QVA4cHpRMkZmMUk5dkxjRU1HWkdVL3pBOXJVRXc5V00xZXpGSXNmMkFBcVlt?= =?utf-8?B?OUZvR0dHL0lENE12VnNTZnFqS3J2Rm9za25YcURPeWcwd2xaNE9ZV3FvSGhV?= =?utf-8?B?YzE5ZDlXUkh3M003NVByTXpsdm04WElxOE4rZ0J4eVhZbnBPUC9CSWM0ek9D?= =?utf-8?B?SW81L1JDeVdndjZCWm9jYUduUmhhcGNnRlpNSnRJYklQSWdmZk9tYzMvRzRn?= =?utf-8?B?TUt4UmxOZFBhWFZTNFJMbnlkNWN2ZldSeVpaVzlIbmVnTGNjbGVOSDZ5a3pp?= =?utf-8?B?ZThPb2NGMlFRMXBKVExGZk0zNDJVZlhHMzd2MHlFNVFXeXR2b2pnSmhDZEMv?= =?utf-8?B?V0tCT1hXbjRjMmZGVWM4M1RFamNWQVUwS3loU2VCK3hRcGxJdVIrZFJyUC9l?= =?utf-8?B?WmtvUXozNnN6cFZJcHIvb1hFSFkrc2tvTStjSkl2NVV2UU1oc2FCdXRLTDlp?= =?utf-8?B?VHFBekNCY21rczk5V1dmZlBXWXM4T3BoWE4rQk91M1Bla0x5MERuZTNrc1Jn?= =?utf-8?Q?PN1tWsmaLZw57oicY48Ik7WKMvGlZcvpOPB7H?= Content-Type: multipart/signed; boundary="Apple-Mail=_C16ADF53-A71B-4FC0-A324-0E1A88C143BE"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5abaee09-931a-45d6-249e-08da34ed933b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 14:33:40.8054 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fn7il093ChM+sUz/Me2qzNveBSSQIXIGxCCIdCffTK8DUTsszjVFQKOMj+BLsnl4argdnCvBUDij2ECn005Bzy+kyZipJXrlWOc5tz1Wtz4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6524 --Apple-Mail=_C16ADF53-A71B-4FC0-A324-0E1A88C143BE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Starting a new thread to make it clear that we=E2=80=99re discussing a = wider policy here. This question is aimed at Jan and Andy in particular, as I think = they=E2=80=99ve probably done the most of this; so I=E2=80=99m looking = to them to find out what our =E2=80=9Cstandard practice=E2=80=9D is. There have recently been some patches that Bertrand has submitted which = pull in code from Linux ("[PATCH 1/3] xen/arm: Sync sysregs and cpuinfo = with Linux 5.18-rc3=E2=80=9D), which has caused a discussion between = him, Julien, and Stefano about the proper way to do such patches. The =E2=80=9COrigin:=E2=80=9D tag section of = xen.git/docs/process/sending-patches.pandoc suggests that there are some = standards, but doesn=E2=80=99t spell them out. The questions seem to be: 1) When doing this kind of update, is it permissible to send a single = patch which =E2=80=9Cbatches=E2=80=9D several upstream commits together, = or should each patch be backported individually? 2) If =E2=80=9Cbatches=E2=80=9D are permissible, when? When would = individual patches be preferred? 3) For =E2=80=9Cbatch updates=E2=80=9D, what tags are necessary? Do we = need to note the changesets of all the commits, and if so, do we need = multiple =E2=80=9COrigin=E2=80=9D tags? Do we need to include anything = from the original commits =E2=80=94 commit messages? Signed-off-by=E2=80=99= s? And a related question: 4) When importing an entire file from an upstream like Linux, what tags = do we need? My recollection is that we often to a =E2=80=9Caccumulated patch=E2=80=9D = to update, say, the Kconfig tooling; so it seems like the answer to this = is sometimes =E2=80=9Cyes=E2=80=9D. It seems to me that in a case where you=E2=80=99re importing a handful = of patches =E2=80=94 say 5-10 =E2=80=94 that importing them one-by-one = might be preferred; but in this case, since the submission was already = made as a batch, I=E2=80=99d accept having it as a batch. I think if I were writing this patch, I=E2=80=99d make a separate = =E2=80=9COrigin=E2=80=9D tag for each commit. I wouldn=E2=80=99t include the upstream commit messages or S-o-b=E2=80=99s= ; I would write my own commit message summarizing why I=E2=80=99m = importing the commits, then have the =E2=80=98origin=E2=80=99 tags, then = my own S-o-b to indicate that I am attesting that it comes from an = open-source project (and for whatever copyright can be asserted on the = commit message and the patch as a collection). And for #4, I would do something similar: I would write my own commit = message describing what the file is for and why we=E2=80=99re importing = it; have the Origin tag point to the commit at the point I took the = file; and my own S-o-b. Andy and Jan, what do you guys normally do? Thanks, -George --Apple-Mail=_C16ADF53-A71B-4FC0-A324-0E1A88C143BE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmJ+bDcACgkQshXHp8eE G+3nqwgAgMS7tPezKnY3//XGoMPhvh5Ejk50r7AxbveMwyAHhWmhnaGkslRhvXhl HqUeXUVkkacsN5wjyDBWDyboVTa4xslQlm2uzkgdDKYYCRXK7ZcDBsvR4tBX13F7 FiElHpi7a0EaiKMKIRDC7dlADa64lfedUwovNr5mxDIVe5i9Q0/JEima+KMwTpWE 9zefsjV3vZOl+Sx9aRQQm2a3uDUGcfFxLxf7lcNBeuVZ77xJ/+SWjZfquZrdbpuI 15A2E60L09h3VsypA7h5445no1NvwEKkdJ9LjQjE4BcDQA26mlWKsjM6nJtp9/ZR xDwQ4T0ntCVWLog8iGCI4ZIH6M1Umg== =PvfJ -----END PGP SIGNATURE----- --Apple-Mail=_C16ADF53-A71B-4FC0-A324-0E1A88C143BE-- From xen-devel-bounces@lists.xenproject.org Fri May 13 14:34:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:34:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328528.551575 (Exim 4.92) (envelope-from ) id 1npWNX-0000pF-6U; Fri, 13 May 2022 14:34:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328528.551575; Fri, 13 May 2022 14:34:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWNX-0000p8-3d; Fri, 13 May 2022 14:34:51 +0000 Received: by outflank-mailman (input) for mailman id 328528; Fri, 13 May 2022 14:34:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWNV-0000ox-P5 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:34:49 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d75215f6-d2c9-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:34:48 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id m1so11699913wrb.8 for ; Fri, 13 May 2022 07:34:48 -0700 (PDT) Received: from [192.168.0.194] (hipert-gw1.mat.unimo.it. [155.185.5.1]) by smtp.gmail.com with ESMTPSA id n27-20020adf8b1b000000b0020c5253d900sm2383523wra.76.2022.05.13.07.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 07:34:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d75215f6-d2c9-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minervasys-tech.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=b0bdCsiXuc25La2RdnHt8t3/RjJymyZdSIqScGL3aOY=; b=kPeg737SrsJXzljeml7OqNCU+M+5kc83qpI8JJzQdu9GA+d9BOogSpa+Fc3qxr35R6 nTVhNFtYwnlN6EprVlfkJRxOMwJUn23YqKT5uNswNyvKIFx9ezJ+XHgYgxvI+kztmSML qVx4VHVmK1NGmAU85TSpSwVZngtvTl1rLVLCMIPu72/id5+mKOBWda220AWbFnWB9Ii8 f4lDPCUsJav8eVuU9sjZOQ0uPT422lBF78q5U6XWsAFXFBBODxV6rs/E3gHoA5BZT3m3 i4Xje+WLhe1mg3UzvdmCryu/QLpOhsyUmWyVlNeCWYbj40GuFnFGzX33Eu5Z02lh19E2 HpQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=b0bdCsiXuc25La2RdnHt8t3/RjJymyZdSIqScGL3aOY=; b=JiV2xOukRVQgBk0nJaRUX3tmyYzO1G5p7u6x338BaRYcva8t+IU0UnzxRdmsnBNGR0 SxUAmgD3ubgS/fiY9aOZ552RE5Zcynv9Vv62asH+pbbDL2yQAEc6CWJWLspnOMUEH0Ts glzBSLXmWowLbXA36HvDDy7TLycyPrM6ZSUrUKkCBb4iS4EiV9d4YU1Xkf7Ep+ODVhmx cA0lNIbXmHCYZcH6m87mDqOeHQ2GzKslNVN6cBUcXaLqts/S7cdVHPfYsAWlRL88RvlH 2M8eHuTG+dGad6CVz98OhCFjKnVaRq1YVG8gtkkgv7MloLFz/VTMb6POzdcbO9BeoWHt 88Dg== X-Gm-Message-State: AOAM531PyEK2agu7KigfuW0dtqIxmCoVHdRjK48P7x+bpIYkNzde/0iu FUnft98KqA53lBMkvBvztpGgoQ== X-Google-Smtp-Source: ABdhPJxemVK2oIeMwHFpdnfa7pxOZ4eNap/1vKiG4mS2+sayiv9bp+sSzx1W1uz3PQggZMvzfD6fWQ== X-Received: by 2002:adf:9dcc:0:b0:20a:ed44:fd48 with SMTP id q12-20020adf9dcc000000b0020aed44fd48mr4278768wre.120.1652452488083; Fri, 13 May 2022 07:34:48 -0700 (PDT) Message-ID: <9b10c3d3-05d4-c08b-efd6-2cb106f58dea@minervasys.tech> Date: Fri, 13 May 2022 16:34:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 05/36] xen/arm: compute LLC way size by hardware inspection Content-Language: en-US To: Julien Grall , Marco Solieri , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Marco Solieri , Andrea Bastoni , Luca Miccio , Stefano Stabellini References: <20220304174701.1453977-1-marco.solieri@minervasys.tech> <20220304174701.1453977-6-marco.solieri@minervasys.tech> <0509b0eb-0f3b-8a26-4202-0011201c3fac@xen.org> From: Carlo Nonato In-Reply-To: <0509b0eb-0f3b-8a26-4202-0011201c3fac@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien On 09/03/22 21:12, Julien Grall wrote: >> Signed-off-by: Luca Miccio >> Signed-off-by: Marco Solieri >> Signed-off-by: Stefano Stabellini >> --- >>   xen/arch/arm/coloring.c | 76 +++++++++++++++++++++++++++++++++++++++++ >>   1 file changed, 76 insertions(+) >> >> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c >> index 8f1cff6efb..e3d490b453 100644 >> --- a/xen/arch/arm/coloring.c >> +++ b/xen/arch/arm/coloring.c >> @@ -25,7 +25,10 @@ >>   #include >>   #include >>   #include >> + > > > NIT: I think this belongs to patch #4. > >> +#include > > Please order the include alphabetically. > >>   #include > +#include > > You don't seem to use read*/write* helper. So why do you need this? >>     /* Number of color(s) assigned to Xen */ >>   static uint32_t xen_col_num; >> @@ -39,6 +42,79 @@ static uint32_t dom0_col_mask[MAX_COLORS_CELLS]; >>     static uint64_t way_size; >>   +#define CTR_LINESIZE_MASK 0x7 >> +#define CTR_SIZE_SHIFT 13 >> +#define CTR_SIZE_MASK 0x3FFF >> +#define CTR_SELECT_L2 1 << 1 >> +#define CTR_SELECT_L3 1 << 2 >> +#define CTR_CTYPEn_MASK 0x7 >> +#define CTR_CTYPE2_SHIFT 3 >> +#define CTR_CTYPE3_SHIFT 6 >> +#define CTR_LLC_ON 1 << 2 >> +#define CTR_LOC_SHIFT 24 >> +#define CTR_LOC_MASK 0x7 >> +#define CTR_LOC_L2 1 << 1 >> +#define CTR_LOC_NOT_IMPLEMENTED 1 << 0 > > We already define some CTR_* in processor.h. Please any extra one there. > >> + >> + >> +/* Return the way size of last level cache by asking the hardware */ >> +static uint64_t get_llc_way_size(void) > > This will break compilation as you are introducing get_llc_way_size() > but not using it. > > I would suggest to fold this patch in the next one. > >> +{ >> +    uint32_t cache_sel = READ_SYSREG64(CSSELR_EL1); > > The return type for READ_SYSREG64() is uint64_t. That said, the > equivalent register on 32bit is CSSELR which is 32-bit. So this should > be READ_SYSREG() and the matching type is register_t. Since we don't want to support arm32, should I stick with READ_SYSREG64() or switch to the generic one you pointed me out? >> +    uint32_t cache_global_info = READ_SYSREG64(CLIDR_EL1); > > Same remark here. Except the matching register is CLIDR. > >> +    uint32_t cache_info; >> +    uint32_t cache_line_size; >> +    uint32_t cache_set_num; >> +    uint32_t cache_sel_tmp; >> + >> +    printk(XENLOG_INFO "Get information on LLC\n"); >> +    printk(XENLOG_INFO "Cache CLIDR_EL1: 0x%"PRIx32"\n", >> cache_global_info); >> + >> +    /* Check if at least L2 is implemented */ >> +    if ( ((cache_global_info >> CTR_LOC_SHIFT) & CTR_LOC_MASK) > > This is a bit confusing. cache_global_info is storing CLIDR_* but you > are using macro starting with CTR_*. > > Did you intend to name the macros CLIDR_*? > > The same remark goes for the other use of CTR_ below. The name of the > macros should match the register they are meant to be used on. You are right for the naming mistakes. Should I add those defines in some specific file or can they stay here? >> +        == CTR_LOC_NOT_IMPLEMENTED ) > > I am a bit confused this the check here. Shouln't you check that > Ctype2 is notn 0 instead? I should check a little bit better how this automatic probing thing actually works and we also have to clarify better what is the LLC for us, so that I know what we should really test for in this function. Probably you're right though. >> +    { >> +        printk(XENLOG_ERR "ERROR: L2 Cache not implemented\n"); >> +        return 0; >> +    } >> + >> +    /* Save old value of CSSELR_EL1 */ >> +    cache_sel_tmp = cache_sel; >> + >> +    /* Get LLC index */ >> +    if ( ((cache_global_info >> CTR_CTYPE2_SHIFT) & CTR_CTYPEn_MASK) >> +        == CTR_LLC_ON ) > > I don't understand this check. You define CTR_LLC_ON to 1 << 2. So it > would be 0b10. From the field you checked, this value mean "Data Cache > Only". How is this indicating the which level to chose? > > But then in patch #4 you wrote we will do cache coloring on L2. So why > are we selecting L3? 1 << 2 is actually 0b100 which stands for "Unified cache". Still I don't know if this is the best way to test what we want. >> +        cache_sel = CTR_SELECT_L2; >> +    else >> +        cache_sel = CTR_SELECT_L3; >> + >> +    printk(XENLOG_INFO "LLC selection: %u\n", cache_sel); >> +    /* Select the correct LLC in CSSELR_EL1 */ >> +    WRITE_SYSREG64(cache_sel, CSSELR_EL1); > > This should be WRITE_SYSREG(). > >> + >> +    /* Ensure write */ >> +    isb(); >> + >> +    /* Get info about the LLC */ >> +    cache_info = READ_SYSREG64(CCSIDR_EL1); >> + >> +    /* ARM TRM: (Log2(Number of bytes in cache line)) - 4. */ > > From my understanding "TRM" in the Arm world refers to a specific > processor. In this case we want to quote the spec. So we usually say > "Arm Arm". > >> +    cache_line_size = 1 << ((cache_info & CTR_LINESIZE_MASK) + 4); >> +    /* ARM TRM: (Number of sets in cache) - 1 */ >> +    cache_set_num = ((cache_info >> CTR_SIZE_SHIFT) & CTR_SIZE_MASK) >> + 1; > > The shifts here are assuming that FEAT_CCIDX is not implemented. I > would be OK if we decide to not support cache coloring on such > platform. However, we need to return an error if a user tries to use > cache coloring on such platform. > In my understanding, if FEAT_CCIDX is implemented then CCSIDR_EL1 is a 64-bit register. So it's just a matter of probing for FEAT_CCIDX and in that case changing the way we access that register (since the layout changes too). Thanks. - Carlo Nonato From xen-devel-bounces@lists.xenproject.org Fri May 13 14:37:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328539.551587 (Exim 4.92) (envelope-from ) id 1npWPe-0001XV-Oi; Fri, 13 May 2022 14:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328539.551587; Fri, 13 May 2022 14:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWPe-0001XO-KG; Fri, 13 May 2022 14:37:02 +0000 Received: by outflank-mailman (input) for mailman id 328539; Fri, 13 May 2022 14:37:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWPd-0001XE-JP; Fri, 13 May 2022 14:37:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWPd-0001T0-Hi; Fri, 13 May 2022 14:37:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWPd-00049P-1F; Fri, 13 May 2022 14:37:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npWPd-0001Jy-0j; Fri, 13 May 2022 14:37:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I7AG/TaUHT3oo8KfUR/LVGqrm0O2LS3jGtZ616FThOw=; b=z+/0m6e78yl1ch3c3FfL7RE/+e upJNeiCRt56IFgH57YobyAZJNgcbYSzTWZ1FiX/sFDAS1LLhM3L6mhnNobXH0bi9NzivtgDXAUXWx rU8Y5GRXqo/4aaUllRPyjECHdA/1Po+MlV6TLBnKU3yxhXNR2FqKhdlA2aNK8NeFFX3o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170390: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 14:37:01 +0000 flight 170390 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170390/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 980 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 14:39:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:39:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328548.551598 (Exim 4.92) (envelope-from ) id 1npWRp-00029s-5N; Fri, 13 May 2022 14:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328548.551598; Fri, 13 May 2022 14:39:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWRp-00029l-29; Fri, 13 May 2022 14:39:17 +0000 Received: by outflank-mailman (input) for mailman id 328548; Fri, 13 May 2022 14:39:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWRn-00029d-UO for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:39:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 755d8d63-d2ca-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:39:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23E88113E; Fri, 13 May 2022 07:39:13 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D85F93F5A1; Fri, 13 May 2022 07:39:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 755d8d63-d2ca-11ec-aa76-f101dd46aeb6 From: Rahul Singh To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, rahul.singh@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3] xen/evtchn: Add design for static event channel signaling Date: Fri, 13 May 2022 15:38:57 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch introduces a new feature to support the signaling between two domains in dom0less system. Signed-off-by: Rahul Singh --- v3 changes: - add dt node example for dom0 and domU. - add info about "xen,enhanced" property to enable the event-channel interface for domU guests. v2 changes: - switch to the one-subnode-per-evtchn under xen,domain" compatible node. - Add more detail about event-channel. --- docs/designs/dom0less-evtchn.md | 144 ++++++++++++++++++++++++++++++++ 1 file changed, 144 insertions(+) create mode 100644 docs/designs/dom0less-evtchn.md diff --git a/docs/designs/dom0less-evtchn.md b/docs/designs/dom0less-evtchn.md new file mode 100644 index 0000000000..3c89a9fb7d --- /dev/null +++ b/docs/designs/dom0less-evtchn.md @@ -0,0 +1,144 @@ +# Signaling support between two domUs on dom0less system + +## Current state: Draft version + +## Proposer(s): Rahul Singh, Bertrand Marquis + +## Problem Statement: + +Dom0less guests would benefit from a statically-defined memory sharing and +signally system for communication. One that would be immediately available at +boot without any need for dynamic configurations. + +In embedded a great variety of guest operating system kernels exist, many of +which don't have support for xenstore, grant table, or other complex drivers. +Some of them are small kernel-space applications (often called "baremetal", +not to be confused with the term "baremetal" used in the data center which +means "without hypervisors") or RTOSes. Additionally, for safety reasons, users +often need to be able to configure the full system statically so that it can +be verified statically. + +Event channels are very simple and can be added even to baremetal applications. +This proposal introduces a way to define them statically to make them suitable +for dom0less embedded deployments. + +## Proposal: + +Event channels are the basic primitive provided by Xen for event notifications. +An event channel is a logical connection between 2 domains (more specifically +between dom1,port1, and dom2,port2). Each event has a pending and a masked bit. +The pending bit indicates the event has been raised. The masked bit is used by +the domain to prevent the delivery of that specific event. Xen only performs a +0 -> 1 transition on the pending bits and does not touch the mask bit. The +domain may toggle masked bits in the masked bit field and should clear the +pending bit when an event has been processed + +Events are received by a domain via an interrupt from Xen to the domain, +indicating when an event arrives (setting the bit). Further notifications are +blocked until the bit is cleared again. Events are delivered asynchronously to +a domain and are enqueued when the domain is not running. Xen supports two +different ABIs for event channel: FIFO and 2L. + +The event channel communication will be established statically between two +domains (dom0 and domU also) before unpausing the domains after domain creation. +Event channel connection information between domains will be passed to Xen via +the device tree node. The event channel will be created and established +in Xen before the domain started. The domain doesn’t need to do any operation +to establish a connection. Domain only needs hypercall +EVTCHNOP_send(local port) to send notifications to the remote guest. + +There is no need to describe the static event channel info in the domU device +tree. Static event channels are only useful in fully static configurations, +and in those configurations the domU device tree dynamically generated by Xen +is not needed. + +To enable the event-channel interface for domU guests include the +"xen,enhanced" property with an empty string ( or with the value +"enabled” or "evtchn") in domU Xen device tree node. + +Under the "xen,domain" compatible node, there need to be sub-nodes with +compatible "xen,evtchn" that describe the event channel connection between two +domains(dom0 and domU also). + +The event channel sub-node has the following properties: + +- compatible + + "xen,evtchn" + +- xen,evtchn + + The property is tuples of two numbers + (local-evtchn link-to-foreign-evtchn) where: + + local-evtchn is an integer value that will be used to allocate local port + for a domain to send and receive event notifications to/from the remote + domain. Maximum supported value is 2^17 for FIFO ABI and 4096 for 2L ABI. + + link-to-foreign-evtchn is a single phandle to a foreign evtchn to which + local-evtchn will be connected. + + +Example: + + chosen { + .... + + module@0 { + compatible = "multiboot,kernel", "multiboot,module"; + xen,uefi-binary = "..."; + bootargs = "..."; + + /* one sub-node per local event channel */ + ec1: evtchn@1 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec2>; + }; + }; + + domU1: domU1 { + compatible = "xen,domain"; + + /* one sub-node per local event channel */ + ec2: evtchn@2 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec1>; + }; + + ec3: evtchn@3 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xb &ec5>; + }; + + ec4: evtchn@4 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xc &ec6>; + }; + .... + }; + + domU2: domU2 { + compatible = "xen,domain"; + + /* one sub-node per local event channel */ + ec5: evtchn@5 { + compatible = "xen,evtchn-v1"; + /* local-evtchn link-to-foreign-evtchn */ + xen,evtchn = <0xa &ec3>; + }; + + ec6: evtchn@6 { + compatible = "xen,evtchn-v1"; + xen,evtchn = <0xb &ec4>; + }; + .... + }; + }; + +In above example three event channel comunications will be established: + + dom0 (port 0xa) <-----------------> domU1 (port 0xa) + domU1 (port 0xb) <-----------------> domU2 (port 0xa) + domU1 (port 0xc) <-----------------> domU2 (port 0xb) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 14:40:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328557.551608 (Exim 4.92) (envelope-from ) id 1npWSi-0003Sz-ES; Fri, 13 May 2022 14:40:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328557.551608; Fri, 13 May 2022 14:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWSi-0003Ss-Bb; Fri, 13 May 2022 14:40:12 +0000 Received: by outflank-mailman (input) for mailman id 328557; Fri, 13 May 2022 14:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWSh-0002St-Fi for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:40:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95d73fe9-d2ca-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 16:40:10 +0200 (CEST) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 10:40:07 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2448.namprd03.prod.outlook.com (2603:10b6:300:9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Fri, 13 May 2022 14:40:05 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.016; Fri, 13 May 2022 14:40:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d73fe9-d2ca-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652452809; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ZJIhEbKwC0snLP0Fbb2ih5ZHCzihUeyvRQ0BGHT2gy8=; b=ie0Dry3vWl5DdxOa+qhjH0+1Bv2w9ma5/S93mmTrR0ylOkhdqZPsKlRD YLegK8sWzGuc1Bv9z4LGgcln4SMSJthqekDQqTxfu9elKvlh/kRGzJmfq QIg4Eor6Ay4XNZgOLkzoL8g9rTU4c4xZVIhC3ZSNO0ftKVCKXot1NE7JV 4=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 71270941 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vz6CLa614cic1detBhRvGAxRtFvGchMFZxGqfqrLsTDasY5as4F+v mUZXW6APfmLYWbzKt0jbIu0pkxT6pDUmtJhSlNqqis8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgWFvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSTDis3eaL8ld8EaF4FCAR3Op9bo5HYdC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAgF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IB8g3N9PZui4TV5DxNk4r0Gf3pRvK1eP1ExHaio yHfpmusV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma/RNB3O 0ES4jApr6U56AqsVNaVYvGjiHuNvxpZXsUKFeQ/sVmJ0vCNu1rfAXUYRDlcbtBgrNUxWTEhy l6OmZXuGCBrt7qWD3ma8994sA+PBMTcFkdaDQdscOfPy4CLTF0b5v4XcuteLQ== IronPort-HdrOrdr: A9a23:fi67Va3SAEzlonbLJf2MRAqjBS5yeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNNaWs19 60TZiAq4s+P/P+TZgNcNvpEvHHfVAkf3r3QRKvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d /8bG8= X-IronPort-AV: E=Sophos;i="5.91,223,1647316800"; d="scan'208";a="71270941" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8AzFF4VDpnzzvZ5xctK+c8MrPDalgqk16bm4d4bxvHFtEEbRRmtoEVJiJM2jIdHsclfyY9AOA1jNIh1gk4krhGZogYiNaDw4ipbu0x6nWtMTBjjATH5w6xo5o8Hr1KhGe8GIl/pmWAVQg70Msce0auKopjx0HaZtLc8Ji3zpSOmBeVAiSrp9YIDFYmib2QHsKXHjuF2VdFOrSfJZu8VgNEUtLu4dBy4IlFK+9Obo03k+C+RZGGxpfmt4hVCAy7A2pc7X7ZK6d8Kinfrrrk3e4C4sVy2siUpzObaM3pyY08YjE0HI1EN75LCrmcGsOk17PIZdRmjrtZxALiyc7yWGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oWgBO5xpKQai5Se+hdg6PjkOYmQz29aCA/m7AfbHJ6w=; b=oEfEPxVuXMANHkBy3uTyZjmU/aKr7UsXNUvIGfZclVhqN6Yb1EWk2IKJCsYw/TjCg7XDZvA0Z09wGv7I4OrPwgnlCkILh4sQlDJKVTet7Ciwwne0MQkVAod9dudOWWUvAUA8mLl+Jcp/spjdKnHeGzHMwptDh6r76w0w7s3s76O3JEM3qo+ovI6ZgnHrmmOO7gjpBiAGKpd6JhKpaonqMEEyxJJ5r0RZ2cV7AqkwtwIWW5qznzW9pClpFUxo9fvR+atPtiTpIV8d6lT3ygvEl5Pw+nj4EnfJ2QAUpv7lQi8iWmNuZgiYqOphbqIWNMSxjibUkfziDclDKUBjnGDvJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWgBO5xpKQai5Se+hdg6PjkOYmQz29aCA/m7AfbHJ6w=; b=it95/28VMLzvoRiyZ3Q6TGAn1OtnAWByFh8r+PRFd8GUAajKd13miM6rm8XuG1wX/N8LFWBLGHiBSWJMSx1PobyE8CqU7nCM+N8h5E0TRUtADQGzT7XBssbMl2koh5TatUwhsj8WT17OAYixLrT8IOhOVAjkmO1oJntzw5JHdIE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 16:39:57 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Ian Jackson Subject: Re: [OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF Message-ID: References: <20220513133534.88564-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220513133534.88564-1-anthony.perard@citrix.com> X-ClientProxiedBy: PR1PR01CA0004.eurprd01.prod.exchangelabs.com (2603:10a6:102::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bcbff28-aedd-4253-ea4c-08da34ee771b X-MS-TrafficTypeDiagnostic: MWHPR03MB2448:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZaY3UH79EibfQyHvHi1RGJESJZsRktfD6XN0wxPLAF4vlehHb2sHyGf2z73rhXE2O7kaHCo8MjXxt/g/IJTvIdx5+IS2mhMhcfeZ0Hr5TShbKONpE8FNG41QIQPXg36TBim0Xt9hj1jCFO+YnOAn7LeqNr/VtLJd3aquOa7fjDe8A8oF0umAQMCgRbym2I/Sh5oTKLni/NOHDep09f2D7Pn0xBKYvd5DWiqvV4omcBBY99uKuyFivyuKvSNw9g6Fg//o2WEWBSsEiu3JEI7uHCQw49J7GARYTPQEFfKug8vjibLz56Geokr+AiVat+Lg5G5G0xvkc95jdF6/DTbkPcZM+9BG4wFHnl8/VLcl07QQ/PRVnUugHq2k7re9vjJyxvy8sYUYG34KR1l9znxCp3XEHlxYJ9hjXKwvX4A3MFVxV4whTDO3vAhSYWD+6CjZn/yqFLQ8obusOBUB/2Cu9zI1yljwtS711wCchYH0zmTKNSFMVMBGL4eQ6fSyLe7smoxxuaszNp6Wfo0EtMBbuwB73SdZp3s0oAfBhaP5DtaOiR6sgcAO+bEjpsPUI8mA3sxdvMmk7i95c2t6ZdqSxrf9fJgaPfSrse46Ez3Z9AMJ2cu5u2NJx1CWvN3IzVW6qZGFgZ3fKZC1BAXMwWZF/FP47IR4mzX0nu3gDFZ06ZNhJ2V8BgDF9GyvDGtOzNDpLTGrGmi1mVo0c0HPWMwfzQMHiYqwBZZAsgpF6yhcsbg6Cs0sdjR2jAjYR679YsqnW3rwpZsCbZ9h0uDVOtw9Sw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(33716001)(85182001)(8676002)(6862004)(508600001)(2906002)(66556008)(66476007)(66946007)(6666004)(82960400001)(6636002)(83380400001)(4326008)(6506007)(26005)(186003)(9686003)(6512007)(5660300002)(6486002)(966005)(316002)(38100700002)(86362001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0VjRFYzWkhocHhHV1IrcHFDblZROWgxdlRzOTdmd0dMbFhZZ2c5SzAvdFFw?= =?utf-8?B?ZTNlUjV1TlYvRkdDTGhZcnFWY2lHa0VqOVVId1JUaHdsRno2SUtLN1JGSmRy?= =?utf-8?B?RWhNbEpiOENiaEw0WXZLYmJPeWFNL0wvRkxoS2N1eTkxTTd5VStTMldHVEV2?= =?utf-8?B?SWRuam1MMkVUc1F5TTUzWXc3dGorWmVEQUpmRnVtVmtNU2p4WG9JbzFFcWY2?= =?utf-8?B?cFNjV0VOeHppYlI5SzNlTUROTlZWMkVFZFJDWXQxd0ptWlFPUThjdGI1Ni9y?= =?utf-8?B?VmNXY0JvbXVMT2tWY3ppSWVpUHdYdGVPdDVmVEVLZ1h0c2hYczZacnYxajJN?= =?utf-8?B?a2Y5L0lma2JJa3l2a2VIU3YvazhiN05HeWlUZnBLN3pmTm42VVlGR3ZoTTh0?= =?utf-8?B?T1JBWEJzbDJMR2FjajJKWFk2aE9NaFRLc2lmMmxuRHYxUndMOHQxVWM1MGZG?= =?utf-8?B?MmEzb0I5N3VHcTdRK1VmMzlrc2xYMGxJaVNaSHJXNUxIaHgvN05vaW9JVWZ6?= =?utf-8?B?Y3NtRDlyV1pGVTU2akRpcDlKcCs0UmFRbFJtQnBUaEp2a3BhQm51WUFGNXBy?= =?utf-8?B?VlJMNk91V2U2K0V0cTVoc0NnNjU3QnhKMUoySnFodHBNUnAxajM2LzRhT0NC?= =?utf-8?B?WU0vL3hOa2lET0xpMHk2Qm5qckNZSXFJWVl5dmkvelNnbTJRTmUwK085Z3VZ?= =?utf-8?B?V0JZenRIWEFSM2JIdFNseExYNmI0RW9wUXFxay92Mnl6QzQzSHkxbDRUSXdM?= =?utf-8?B?Z0pVeDloQUI5WVp6UkQrcytsUkdTQlJSY01KQmZnbnNwcjdrZTlVbjVORGRN?= =?utf-8?B?WTJYS1EwZ2x4V2FVTTNURVM5QmZ1cFArNUZ5ekQ3NkJ3emFSSjJlKzRkbkw4?= =?utf-8?B?QWx6ek5Xc0lhdExmUmFCS2lMNWJmQ2hCYk5SWjUwVmNWZithWTFUYS9iZEdW?= =?utf-8?B?MWE2L2VFZ1diNnNFU2tPUEtnUkdZckhRYzhlQ0ZHRzJjZGZxSXJZakY4aDlw?= =?utf-8?B?N2RhaEUvZXl4OU1TMHhwTlo3M09ETk04MUU1OGVSYndBaDdONnYrV0tLK2l2?= =?utf-8?B?ZENqZ2kzdHJCUkJvZEtncGJqVHhpdDB3eXoxQnBPZlRLNmtRL1RhUTFSejE1?= =?utf-8?B?cURjUGtUWlBwSWprY28wYjBOcENha2M1Y2U5STU5SnlrbDVua25hZERIWm9r?= =?utf-8?B?MGZyUEFLOTlMVTZKTUN6RGlSQVgxeUZtaDVXdlN6SUFnL1NFcjZiVDNNUzBk?= =?utf-8?B?WHJ5bFd0TEdRSGEvSFdBWTRzMFpJTnkySVpya2FmQkFLQzJkOStXVnhuSG5a?= =?utf-8?B?eGFYV0tBTWpvQ051blJqNjRjVkM3RmcwK1cyMDh2NS9BOGVkaXpwcUtJNGl4?= =?utf-8?B?bnBYNjFjQUdlNkxuMlp5NjRvdnFRNmFkcWxZWVpFbVYrYW82S05kTVpNTzlm?= =?utf-8?B?VmYxcU1MSm9ndkJrd1lFWmhBOUxDTnd4YWJzaGJkeWVpSUs0YnFFaDVwZHB0?= =?utf-8?B?U2RQZC9XN0VMMVhCVHZxT0JJdE0vVnFJTEFJa0c3Mmw4RXFIZDVmbm84cGJD?= =?utf-8?B?b3dNR1FkOUN5OFV5QjJFS01WUFBqMHFNcEdsQmwzZ0FRdEdpRTNIaEpOaWN6?= =?utf-8?B?Zm1aMU9SdW5YcysxV2xvY1dOYmNCUytJTlJic0swclRPVzhHc0NNbHd4ZUla?= =?utf-8?B?KzNNSGdPQUpkUUNreFpnK20ydlpoS1RiYVhoNnhsSTVUYWt6ZE8rVnBkakt2?= =?utf-8?B?ZVYzdHlIUnFKZW9uN2tjUlNWWXV6ZDFFaDdrWlF5U3hKK0FVN1o0RjY1akFp?= =?utf-8?B?Q2t4aEpzTFovQ3NGczE4T2NIZ0d1Z3R4NlBmbTRDVy9ZUzgzTHhScGNZNGpm?= =?utf-8?B?LzJicTNVTVhJamN5Zko2cUN0QjFQNEV0QjFPVzZ0Y2FIV3Jzb3VkQ2FxbXV6?= =?utf-8?B?UGVxNFN5ZDZqZEE2YnVuN0hTRzh4Zkd3Y0VkRnlEZGpVS0MzVjArbVhwUjdQ?= =?utf-8?B?djlVOUkxSGM4UGJBM1U0R1Q5b3UvUjJ6MjVmQ09nUWY5N1NrYXlwSkdjN2JS?= =?utf-8?B?bk1lUG5FWk9xU05ja3VRK2k3SDF6cXVzWm9oU3Z6YVdXcDA1YkRqcTBVajAv?= =?utf-8?B?SEV4dWUxYjJ4Snh4d3QrdHp3TjdJTFRtcktGWDVqUmtnY29lZDM5Sy9WV2Jn?= =?utf-8?B?ckZvZTRhYURteXBiRHNhTVRSZ3lObWYyWEI0UmhDejdRdXJtc3JSdTR2MzZr?= =?utf-8?B?Z2NBTmZ1U3dPQ1NrVlBKQjBkaFkwOXRSRmNPL3BlSnBxeDBoNnYyNjc3WWdO?= =?utf-8?B?eHNZeWhSc3Ayek04VnJyK0ZUV08yZG1iYUlRVWw5anFTVm5IQXFkZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bcbff28-aedd-4253-ea4c-08da34ee771b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 14:40:05.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b7tj61wZYWCCCvYiTxYDYgGIgACugAIVQRh+wtexXROCU/D4R9wwNGJlSxyCEips7mzzYhCcMCTdY/b/PWuyEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2448 On Fri, May 13, 2022 at 02:35:34PM +0100, Anthony PERARD wrote: > Recent versions of OVMF now need a version of NASM that is newer > than the one available on Debian oldstable/buster. They want to use > NASM 2.15.05 [1], which is available in Debian stable/bullseye. The > need to use a newer version started with d3febfd9ade3 ("MdePkg: > Replace Opcode with the corresponding instructions."). > > There is no backport package available but the nasm package from > Debian Bullseye can easily be installed on Buster as it has few > dependencies and are already satisfied. > > [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 > ("BaseTools: Upgrade the version of NASM tool") > > Signed-off-by: Anthony PERARD > --- > ts-xen-build-prep | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/ts-xen-build-prep b/ts-xen-build-prep > index 67b3eae62155..38d4a8e79451 100755 > --- a/ts-xen-build-prep > +++ b/ts-xen-build-prep > @@ -250,6 +250,15 @@ END > if ($ho->{Arch} eq 'amd64' && $ho->{Suite} !~ m/squeeze|lenny/) { > target_install_packages($ho, 'libc6-dev-i386'); > } > + > + # Use newer version of NASM, for OVMF > + if ($ho->{Suite} =~ m/buster/) { > + my $nasm_pkg = "nasm_2.15.05-1_$ho->{Arch}.deb"; > + my $nasm_url = debian_mirror_url_suite_arch("bullseye", $ho->{Arch}) > + ."/pool/main/n/nasm/$nasm_pkg"; > + target_fetchurl($ho, $nasm_url, "/tmp/$nasm_pkg"); I think this is likely too fragile, what will happen when the package gets bumped to a newer version? I think we need to store a local copy in osstest and install from there instead of trying to fetch from the upstream Debian mirror. I guess we could use something similar to DebianExtraPackages? DebianExtraPackages_build_$arch_$suite nasm_2.15.05-1_$ho->{Arch}.deb And fetch those using the some_extradebs method. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 14:45:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:45:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328568.551620 (Exim 4.92) (envelope-from ) id 1npWXg-0004Fa-60; Fri, 13 May 2022 14:45:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328568.551620; Fri, 13 May 2022 14:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWXg-0004FT-2T; Fri, 13 May 2022 14:45:20 +0000 Received: by outflank-mailman (input) for mailman id 328568; Fri, 13 May 2022 14:45:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWXd-0004FN-V6 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:45:18 +0000 Received: from sipsolutions.net (s3.sipsolutions.net [2a01:4f8:191:4433::2]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cfe4e37-d2cb-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:45:16 +0200 (CEST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1npWX2-00AdYm-Tp; Fri, 13 May 2022 16:44:41 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cfe4e37-d2cb-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=A7LCydQD5IYNzaoDGyfG1KKM7tCxGhr7TuWULSo03X0=; t=1652453115; x=1653662715; b=d6dFBGxhA+etxcUF2VEIga8eMqjhBSJupzgMJmt/foKc2Pc kt5aDud7HLL5H6aSbDMeDMNiWTwxy2xY3uc/dB3IgjkOOMsPepA9WwNVZvZI2ThhVzYJjviqtADHa ADTKnjlfKrkb52v2oOuID/onVsG+IYw0qr25T02ttvfUDuqmMHcjb9eRlrDS8LhDAIu3/phkwQl40 LdmkcbE1RS/mzc1/DrWKTp94HtkNKoI5Ma0OGHGsX2EZ4p8/opAPtP/e0HCrk668C2D1dTR6/OIvw SDXD9aS3vu1oWZQYjJh/BNc4FcMgm1eOGVLBa/ilqXGorgou5TkSZG4Kt88CUsSw==; Message-ID: <1760d499824f9ef053af7a8dac04b48ab7d7fd3d.camel@sipsolutions.net> Subject: Re: [PATCH 11/30] um: Improve panic notifiers consistency and ordering From: Johannes Berg To: "Guilherme G. Piccoli" , Petr Mladek , Anton Ivanov , Richard Weinberger Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Date: Fri, 13 May 2022 16:44:36 +0200 In-Reply-To: <4b003501-f5c3-cd66-d222-88d98c93e141@igalia.com> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-12-gpiccoli@igalia.com> <4b003501-f5c3-cd66-d222-88d98c93e141@igalia.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned On Wed, 2022-05-11 at 17:22 -0300, Guilherme G. Piccoli wrote: > On 10/05/2022 11:28, Petr Mladek wrote: > > [...] > > It is not clear to me why user mode linux should not care about > > the other notifiers. It might be because I do not know much > > about the user mode linux. > > > > Is the because they always create core dump or are never running > > in a hypervisor or ...? > > > > AFAIK, the notifiers do many different things. For example, there > > is a notifier that disables RCU watchdog, print some extra > > information. Why none of them make sense here? > > > > Hi Petr, my understanding is that UML is a form of running Linux as a > regular userspace process for testing purposes. Correct. > With that said, as soon > as we exit in the error path, less "pollution" would happen, so users > can use GDB to debug the core dump for example. > > In later patches of this series (when we split the panic notifiers in 3 > lists) these UML notifiers run in the pre-reboot list, so they run after > the informational notifiers for example (in the default level). > But without the list split we cannot order properly, so my gut feeling > is that makes sense to run them rather earlier than later in the panic > process... > > Maybe Anton / Johannes / Richard could give their opinions - appreciate > that, I'm not attached to the priority here, it's more about users' > common usage of UML I can think of... It's hard to say ... In a sense I'm not sure it matters? OTOH something like the ftrace dump notifier (kernel/trace/trace.c) might still be useful to run before the mconsole and coredump ones, even if you could probably use gdb to figure out the information. Personally, I don't have a scenario where I'd care about the trace buffers though, and most of the others I found would seem irrelevant (drivers that aren't even compiled, hung tasks won't really happen since we exit immediately, and similar.) johannes From xen-devel-bounces@lists.xenproject.org Fri May 13 14:52:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 14:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328579.551631 (Exim 4.92) (envelope-from ) id 1npWej-0005ft-Vp; Fri, 13 May 2022 14:52:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328579.551631; Fri, 13 May 2022 14:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWej-0005fm-SC; Fri, 13 May 2022 14:52:37 +0000 Received: by outflank-mailman (input) for mailman id 328579; Fri, 13 May 2022 14:52:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npWei-0005ff-HM for xen-devel@lists.xenproject.org; Fri, 13 May 2022 14:52:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52d7e891-d2cc-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 16:52:35 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6990D1F934; Fri, 13 May 2022 14:52:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 25B9513446; Fri, 13 May 2022 14:52:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2IODB7JwfmI8FgAAMHmgww (envelope-from ); Fri, 13 May 2022 14:52:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52d7e891-d2cc-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652453554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=koEOM3h7/R3NDqH0fHkFJ1NW9T6GdDGxJk/oyNP0TXk=; b=HBU87oYtKofNUuejg2toY7PWM97P+UP5EOBScLkOdiQ2rInqrX2PUruAIzWOm5BuygRQt3 RfyatPiw1TeqANtfE5wUNwCvhO55+oJJO18qLUMGLUD/jrYpvrgs/QfCozYzqwWc5Vm+CL dVoPG9eVpWWZnXh671Sl3ZVt7XmSb6k= Message-ID: <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> Date: Fri, 13 May 2022 16:52:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: George Dunlap , Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini Cc: xen-devel , Roger Pau Monne References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> From: Juergen Gross Subject: Re: Process for cherry-picking patches from other projects In-Reply-To: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------DTYvJ1VvoSduojKAKcTwKUyf" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------DTYvJ1VvoSduojKAKcTwKUyf Content-Type: multipart/mixed; boundary="------------hRDkSaG02XbLQ0AEQt8wIkbn"; protected-headers="v1" From: Juergen Gross To: George Dunlap , Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini Cc: xen-devel , Roger Pau Monne Message-ID: <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> Subject: Re: Process for cherry-picking patches from other projects References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> In-Reply-To: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> --------------hRDkSaG02XbLQ0AEQt8wIkbn Content-Type: multipart/mixed; boundary="------------JBVR0CAezDxEU1RICpqItuu2" --------------JBVR0CAezDxEU1RICpqItuu2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDUuMjIgMTY6MzMsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+IFN0YXJ0aW5nIGEg bmV3IHRocmVhZCB0byBtYWtlIGl0IGNsZWFyIHRoYXQgd2XigJlyZSBkaXNjdXNzaW5nIGEg d2lkZXIgcG9saWN5IGhlcmUuDQo+IA0KPiBUaGlzIHF1ZXN0aW9uIGlzIGFpbWVkIGF0IEph biBhbmQgQW5keSBpbiBwYXJ0aWN1bGFyLCBhcyBJIHRoaW5rIHRoZXnigJl2ZSBwcm9iYWJs eSBkb25lIHRoZSBtb3N0IG9mIHRoaXM7IHNvIEnigJltIGxvb2tpbmcgdG8gdGhlbSB0byBm aW5kIG91dCB3aGF0IG91ciDigJxzdGFuZGFyZCBwcmFjdGljZeKAnSBpcy4NCj4gDQo+IFRo ZXJlIGhhdmUgcmVjZW50bHkgYmVlbiBzb21lIHBhdGNoZXMgdGhhdCBCZXJ0cmFuZCBoYXMg c3VibWl0dGVkIHdoaWNoIHB1bGwgaW4gY29kZSBmcm9tIExpbnV4ICgiW1BBVENIIDEvM10g eGVuL2FybTogU3luYyBzeXNyZWdzIGFuZCBjcHVpbmZvIHdpdGggTGludXggNS4xOC1yYzPi gJ0pLCB3aGljaCBoYXMgY2F1c2VkIGEgZGlzY3Vzc2lvbiBiZXR3ZWVuIGhpbSwgSnVsaWVu LCBhbmQgU3RlZmFubyBhYm91dCB0aGUgcHJvcGVyIHdheSB0byBkbyBzdWNoIHBhdGNoZXMu DQo+IA0KPiBUaGUg4oCcT3JpZ2luOuKAnSB0YWcgc2VjdGlvbiBvZiB4ZW4uZ2l0L2RvY3Mv cHJvY2Vzcy9zZW5kaW5nLXBhdGNoZXMucGFuZG9jIHN1Z2dlc3RzIHRoYXQgdGhlcmUgYXJl IHNvbWUgc3RhbmRhcmRzLCBidXQgZG9lc27igJl0IHNwZWxsIHRoZW0gb3V0Lg0KPiANCj4g VGhlIHF1ZXN0aW9ucyBzZWVtIHRvIGJlOg0KPiANCj4gMSkgV2hlbiBkb2luZyB0aGlzIGtp bmQgb2YgdXBkYXRlLCBpcyBpdCBwZXJtaXNzaWJsZSB0byBzZW5kIGEgc2luZ2xlIHBhdGNo IHdoaWNoIOKAnGJhdGNoZXPigJ0gc2V2ZXJhbCB1cHN0cmVhbSBjb21taXRzIHRvZ2V0aGVy LCBvciBzaG91bGQgZWFjaCBwYXRjaCBiZSBiYWNrcG9ydGVkIGluZGl2aWR1YWxseT8NCj4g DQo+IDIpIElmIOKAnGJhdGNoZXPigJ0gYXJlIHBlcm1pc3NpYmxlLCB3aGVuPyAgV2hlbiB3 b3VsZCBpbmRpdmlkdWFsIHBhdGNoZXMgYmUgcHJlZmVycmVkPw0KPiANCj4gMykgRm9yIOKA nGJhdGNoIHVwZGF0ZXPigJ0sIHdoYXQgdGFncyBhcmUgbmVjZXNzYXJ5PyAgRG8gd2UgbmVl ZCB0byBub3RlIHRoZSBjaGFuZ2VzZXRzIG9mIGFsbCB0aGUgY29tbWl0cywgYW5kIGlmIHNv LCBkbyB3ZSBuZWVkIG11bHRpcGxlIOKAnE9yaWdpbuKAnSB0YWdzPyAgRG8gd2UgbmVlZCB0 byBpbmNsdWRlIGFueXRoaW5nIGZyb20gdGhlIG9yaWdpbmFsIGNvbW1pdHMg4oCUIGNvbW1p dCBtZXNzYWdlcz8gIFNpZ25lZC1vZmYtYnnigJlzPw0KPiANCj4gQW5kIGEgcmVsYXRlZCBx dWVzdGlvbjoNCj4gDQo+IDQpIFdoZW4gaW1wb3J0aW5nIGFuIGVudGlyZSBmaWxlIGZyb20g YW4gdXBzdHJlYW0gbGlrZSBMaW51eCwgd2hhdCB0YWdzIGRvIHdlIG5lZWQ/DQo+IA0KPiBN eSByZWNvbGxlY3Rpb24gaXMgdGhhdCB3ZSBvZnRlbiB0byBhIOKAnGFjY3VtdWxhdGVkIHBh dGNo4oCdIHRvIHVwZGF0ZSwgc2F5LCB0aGUgS2NvbmZpZyB0b29saW5nOyBzbyBpdCBzZWVt cyBsaWtlIHRoZSBhbnN3ZXIgdG8gdGhpcyBpcyBzb21ldGltZXMg4oCceWVz4oCdLg0KPiAN Cj4gSXQgc2VlbXMgdG8gbWUgdGhhdCBpbiBhIGNhc2Ugd2hlcmUgeW914oCZcmUgaW1wb3J0 aW5nIGEgaGFuZGZ1bCBvZiBwYXRjaGVzIOKAlCBzYXkgNS0xMCDigJQgdGhhdCBpbXBvcnRp bmcgdGhlbSBvbmUtYnktb25lIG1pZ2h0IGJlIHByZWZlcnJlZDsgYnV0IGluIHRoaXMgY2Fz ZSwgc2luY2UgdGhlIHN1Ym1pc3Npb24gd2FzIGFscmVhZHkgbWFkZSBhcyBhIGJhdGNoLCBJ 4oCZZCBhY2NlcHQgaGF2aW5nIGl0IGFzIGEgYmF0Y2guDQo+IA0KPiBJIHRoaW5rIGlmIEkg d2VyZSB3cml0aW5nIHRoaXMgcGF0Y2gsIEnigJlkIG1ha2UgYSBzZXBhcmF0ZSDigJxPcmln aW7igJ0gdGFnIGZvciBlYWNoIGNvbW1pdC4NCj4gDQo+IEkgd291bGRu4oCZdCBpbmNsdWRl IHRoZSB1cHN0cmVhbSBjb21taXQgbWVzc2FnZXMgb3IgUy1vLWLigJlzOyBJIHdvdWxkIHdy aXRlIG15IG93biBjb21taXQgbWVzc2FnZSBzdW1tYXJpemluZyB3aHkgSeKAmW0gaW1wb3J0 aW5nIHRoZSBjb21taXRzLCB0aGVuIGhhdmUgdGhlIOKAmG9yaWdpbuKAmSB0YWdzLCB0aGVu IG15IG93biBTLW8tYiB0byBpbmRpY2F0ZSB0aGF0IEkgYW0gYXR0ZXN0aW5nIHRoYXQgaXQg Y29tZXMgZnJvbSBhbiBvcGVuLXNvdXJjZSBwcm9qZWN0IChhbmQgZm9yIHdoYXRldmVyIGNv cHlyaWdodCBjYW4gYmUgYXNzZXJ0ZWQgb24gdGhlIGNvbW1pdCBtZXNzYWdlIGFuZCB0aGUg cGF0Y2ggYXMgYSBjb2xsZWN0aW9uKS4NCj4gDQo+IEFuZCBmb3IgIzQsIEkgd291bGQgZG8g c29tZXRoaW5nIHNpbWlsYXI6IEkgd291bGQgd3JpdGUgbXkgb3duIGNvbW1pdCBtZXNzYWdl IGRlc2NyaWJpbmcgd2hhdCB0aGUgZmlsZSBpcyBmb3IgYW5kIHdoeSB3ZeKAmXJlIGltcG9y dGluZyBpdDsgaGF2ZSB0aGUgT3JpZ2luIHRhZyBwb2ludCB0byB0aGUgY29tbWl0IGF0IHRo ZSBwb2ludCBJIHRvb2sgdGhlIGZpbGU7IGFuZCBteSBvd24gUy1vLWIuDQoNCklNTyB3ZSBz aG91bGQgYWRkIGFub3RoZXIgdGFnIGZvciB0aGF0IHB1cnBvc2UsIGUuZy46DQoNCkZpbGUt b3JpZ2luOiA8cmVwb3NpdG9yeT4gPHRhZz4gPHBhdGg+IFsjIDxsb2NhbC1wYXRoPl0NCg0K U3BlY2lmeWluZyB0aGUgcmVwb3NpdG9yeSB0aGUgZmlsZShzKSBhcmUgY29taW5nIGZyb20s IHRoZSB0YWcgKGUuZy4gYQ0KdGFnZ2VkIHZlcnNpb24sIG9yIHRoZSB0b3AgZ2l0IGNvbW1p dCksIGFuZCB0aGUgcGF0aCBvZiB0aGUgb3JpZ2luYWwNCmZpbGUocykgaW4gdGhhdCByZXBv c2l0b3J5ICg8cGF0aD4gY291bGQgZWl0aGVyIGJlIGEgY29tbW9uIGRpcmVjdG9yeQ0Kb2Yg bXVsdGlwbGUgZmlsZXMsIG9yIGEgc2luZ2xlIGZpbGU7IG11bHRpcGxlICJGaWxlLW9yaWdp bjoiIHRhZ3Mgc2hvdWxkDQpiZSBwb3NzaWJsZSkuIEluIGNhc2UgdGhlIGZpbGUgaXMgYmVp bmcgcmVuYW1lZCBsb2NhbGx5LCBpdHMgbmV3IG5hbWUNCmNhbiBiZSBhZGRlZCBhcyA8bG9j YWwtcGF0aD4uDQoNClRoaXMgdmFyaWFudCBzaG91bGQgYmUgdXNlZCB0byBhZGQgX25ld18g ZmlsZXMgdG8gWGVuLiBJbiBjYXNlIG9mDQp1cGRhdGluZyBhIGZpbGUgd2hpY2ggaGFzIHNl ZW0gbG90cyBvZiBjb21taXRzIHNpbmNlIGl0cyBsYXN0IHVwZGF0ZSBvcg0KaW50cm9kdWN0 aW9uLCBpdCBtaWdodCBiZSBlYXNpZXIgdG8ganVzdCB1c2UgdGhlICJGaWxlLW9yaWdpbjoi IHRhZywNCnByb2JhYmx5IHdpdGggYSBub3RlIGJlbG93IHRoZSAiLS0tIiBtYXJrZXIgdGhh dCBsaXN0aW5nIG1vcmUgdGhhbiA8eD4NCnBhdGNoZXMgKHggPiAxMD8pIG9yIHNwbGl0dGlu ZyBpbnRvIG1vcmUgdGhhbiA8eD4gcGF0Y2hlcyB3b3VsZCBiZQ0KanVzdCB1c2VsZXNzIHdv cmsgKGNvbW1vbiBzZW5zZSBzaG91bGQgYXBwbHkgaGVyZSwgZXNwZWNpYWxseSByZWdhcmRp bmcNCnRoZSByZWFkYWJpbGl0eSBvZiB0aGUgcGF0Y2ggYW5kIHRoZSByZWxhdGVkIHJldmll dyBlZmZvcnQpLg0KDQoNCkp1ZXJnZW4NCg== --------------JBVR0CAezDxEU1RICpqItuu2 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JBVR0CAezDxEU1RICpqItuu2-- --------------hRDkSaG02XbLQ0AEQt8wIkbn-- --------------DTYvJ1VvoSduojKAKcTwKUyf Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmJ+cLEFAwAAAAAACgkQsN6d1ii/Ey/O 0gf8CK/+vdH9ZYfytddVTsv+63q62uFziYj8z6V3xb+W/3ZZ9mvPtezxaOf/jYGLK0AM8gW8/z0n /bls7+mRcBnAUox+u9avCxIVFU1NXAt7lOgKRwPEM+kwm//HVMuTNaCQWhnrn5iuaTj69owG5B8Y WmQTxqEIv6cqXzKfmskRSBhFh+3/xGmeZWlC80dIOZLE3/ymA6OPFSYcFLqBvDiYv3K96ynbNuoS e6xvdM1QhFax2yBID/LuMNpgfOEkkw+AqOFqwmMSw48Ca2Hm6x5RQ6Ar0Xd8NMNV4W6DkduOejkV deP8N62GdtmAwC7ZzhCYRWY0CtUVe5yiL9QTMjXGXQ== =ELhI -----END PGP SIGNATURE----- --------------DTYvJ1VvoSduojKAKcTwKUyf-- From xen-devel-bounces@lists.xenproject.org Fri May 13 15:31:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 15:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328588.551642 (Exim 4.92) (envelope-from ) id 1npXFv-0001Sq-2Z; Fri, 13 May 2022 15:31:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328588.551642; Fri, 13 May 2022 15:31:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXFu-0001Sj-Up; Fri, 13 May 2022 15:31:02 +0000 Received: by outflank-mailman (input) for mailman id 328588; Fri, 13 May 2022 15:31:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXFu-0001SZ-3B; Fri, 13 May 2022 15:31:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXFt-0002g2-Ob; Fri, 13 May 2022 15:31:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXFt-0006MX-BC; Fri, 13 May 2022 15:31:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npXFt-00023t-Ai; Fri, 13 May 2022 15:31:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3QKrzDw0iXoA+IA9xEPu0EJy4YWEgWiFJLOFWbLM61c=; b=hvO9WrRZLrx+4bIO3/rvhpZ1Fq d4n3//9sy1L5QDXqCXReWTfE3Y7gjdXMHFJX+IA26ErWfArJhgQx6mQdAAt7wQZMO+5qfc9MrvBaX drgGIZrIr+g59Anbzh3dzl/DL1aKjlLnjFW1rEDGe7saN78B5YyK5IMzBJMqFaKPdN2M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170391: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 15:31:01 +0000 flight 170391 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170391/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf ef01d63ef3c9d2e7f39755b9c2b6bf40f6076ef3 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 981 attempts Testing same since 170376 2022-05-13 02:20:08 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6542 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 15:40:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 15:40:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328597.551653 (Exim 4.92) (envelope-from ) id 1npXOo-0002wV-0e; Fri, 13 May 2022 15:40:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328597.551653; Fri, 13 May 2022 15:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXOn-0002wO-Ti; Fri, 13 May 2022 15:40:13 +0000 Received: by outflank-mailman (input) for mailman id 328597; Fri, 13 May 2022 15:40:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXOm-0002wI-Oe for xen-devel@lists.xenproject.org; Fri, 13 May 2022 15:40:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7c39fb7-d2d2-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 17:40:10 +0200 (CEST) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 May 2022 11:40:07 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB3584.namprd03.prod.outlook.com (2603:10b6:805:42::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Fri, 13 May 2022 15:40:03 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.016; Fri, 13 May 2022 15:40:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7c39fb7-d2d2-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652456410; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=qyX5QQ1dlZwnJT6EKaQ0Vs0xLPXfzV4ortBuXyg3zXU=; b=LakAEEsJ2WpCcKYbTtpZNuoIUHeKfb93ofQOO6tHKYZs+0vAQ3tRykCk VBM9Z4GkSK3CbwRTXzpcgY/jvkH6Mj0V9MF7bCXCav7+ZhRZlkuAUpIi4 cSqFB70oc1ldDJiqdPNlsG0L3G+5SPvh8U4XmR6OpUeq6p/z2dDnehggi Q=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 71666640 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sXnuDK2cLaFwMpM06/bD5aZwkn2cJEfYwER7XKvMYLTBsI5bp2MCy WIdDTyCOa3cYmSgKNEjaNzno0hSsMfWmoA2GwBtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /11uoyAaR0THJTAxvsYVzBqUAZeF7xJreqvzXiX6aR/zmXgWl61mbBLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B86dBfmWjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SChLWMG9Ar9Sawf53fL009ciJbUHOWFcISpTpRFoUe4q TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQSSkKzd5l/DAnBeFmIdLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:6LipdaOZeviyM8BcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,223,1647316800"; d="scan'208";a="71666640" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0KtStMaymITWg7PoJLpjP3iicMRmRVrBI/KNOCE9I0PSi4goaaG/tZE55BZXG6IncaGfKMq1xtavdnW6wUBqzOBMt0Hzy4dXavZRg2LzTqi9nJDO42zK4OYnWOquh/EVH9Gk43jHZ97CgyitEEqYdMMpmsez3dK8zjkTJjgZCFoR+nJIIP0OXgzfIhTziZS9AV6A7nXS3kW+ilQIa4jifx9N3X+2CETwPFV15r3wfBQAZf4a9GYWfCzsVe+PJXluUrOSOs1nthMAtVzq3abVy2RYYxM7GLgV4XF00iUwI8HcRiuiBFjzViGUBS+y9HIO2J2Q7aCin9p6HK4ZE9Pnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fwyRRLHFwC9ItfPVSVYVGnUiB7/gbhJ57y1bXrCevHk=; b=JIfsOmcOHiqifTaKRv9S4+M75e3bdmobiCWJ4Q0r9uov8dWrKkoKyom86LRyy8qQKjRPAvsNTvD5Hu7L0t1iHkWSjI+6rMsN0qmwH8dq1g5HGv4tcsQc05ETwH5YEQH9IYTuWYD6E8Sy2LOd/iqoMYz2Urv017gXAn8KDl+7oKAOXtyoDlZWNxec+nbJ/qhcs5eAPTySbHYVA1Lr5er5mv/aUy7tmErTM6/37zRWvgRS2chLAf1iQJM3WmVHJY4cX2uwDbjYObtxp+N+IVzxMT6gmMQI3z9UlxeM/ykMuvzkkNwEFqddM27/CnQ68K60win6GIkPXp3Dcmxjhhhkig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fwyRRLHFwC9ItfPVSVYVGnUiB7/gbhJ57y1bXrCevHk=; b=ddhz0k1s8u4pRR6T2t4iehaopDYJmjz2Xh+ALWKYpofFpnk7ovpOea7YAFiOcsllNMqPIukdh4nduPZK8JIzPyXdtosFb3J4oQjzsOEvxq3oHOlEwl81nr9K046WXGFa5E76dQLMhSWcbPy9EcKP2ebzr18z2eYQSO2ufidtO30= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 13 May 2022 17:39:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jane Malalane Cc: Xen-devel , Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Message-ID: References: <20220511151423.20241-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220511151423.20241-1-jane.malalane@citrix.com> X-ClientProxiedBy: MR1P264CA0072.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7092ee2b-4555-4d58-5d05-08da34f6d8a3 X-MS-TrafficTypeDiagnostic: SN6PR03MB3584:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nsQo2eIoHtZft0nEImXDP87VP3Q6OB0vysVNsUPRy1gHWAXDEnL8P4IXljpg81bXhkd5tnTcml1A6Qm0fqvZAOMoN5RdP6VcFsV8FLVQChavpMVVo+x9P17BjxvJfb+qwKPBB1rAiSY7EA8k2DObo2B8ZjEj+8+MMUatMkptPLkVxvgy3yJH+WUurhJWQz/uvk2CSP73ys1qZjs6wBLHHyu1y4vWo9Xxi9cuy1azfLKt/C1wddhJbnKkJQK1BAeVQphZKvn2jK/P6FufB2Dg5H7TcYB2CofdNdAdBZn5FQN06lQSsEJQ6pHqVxYdKC2jNPXqHdPckyv4QA4yLrKKBghIVks1I886eu/iqWXwj7iUHN44He2SfZnKD5vWOY05VMcvzF7lhPG2V9lnOd3f+oIHm/qHqNTgQ3adbXn4i1eveXU+eBuySlOQ16qD8xdHtzoBGPYO+kzFu/Hs8NbCUKUbPXVf4hpXZEki3UKaQbEDgG62CErF7aw9rTt9/QdWH1N2KS8y4M/7lzF7PB1EC5ynlf+ezlfbtchnvKqESZhLjVCgahPtR0jUXYZ82rGZIvN+eCHwLe3Iq5WkxUy7Y8f0Mc8g1mXrytoKXaynDS7EQmhzxvwcFHyoXbq5gLmj29FJ7HNEh/DgJiFnAIP2rw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(38100700002)(66476007)(6486002)(508600001)(85182001)(186003)(33716001)(5660300002)(2906002)(6636002)(9686003)(26005)(8676002)(6862004)(316002)(4326008)(8936002)(66556008)(66946007)(86362001)(6512007)(6666004)(82960400001)(54906003)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDhUQ3hpQ2JPcGFZYVNxL0dtczg4UHJmRFNIYWg3OWJ2bVdrOVRwRlFPUVZP?= =?utf-8?B?Y0xHNlZqR2c0YjFUb2szVHhObEhOUnBOQW9Ed0NXeUYvOUFjeVNzNDFVL3M5?= =?utf-8?B?T1FQTzdsSjNOVmNFMExuV0lEWENzSGpBZlVBZzdqYTUxUi9BM1Y0Ny9QK3Qz?= =?utf-8?B?VklPVS9YT21aZ0VZU3RIL2d1UzB4V29zYmFBNDBtTnZYTjlGWUFmM3F2Zmls?= =?utf-8?B?cTJRWG1WWDBRK2hDWmh3TUZZZksrMWJ0SkpHOFdxM0dDektHRnVMVHU0TW1n?= =?utf-8?B?NlFlMHRLVVNPbzhSaDFKV3EvbnFqZVVyMTc2UmVLcy9IdExCbGdoRjdNVnR1?= =?utf-8?B?dldJRTRQVnhPa3RqQlNPcXFNSjlPdjRWenR5L1dQZmJzVHRoR1lNWEIwTVI1?= =?utf-8?B?Qm5NOERRcXc0NUF1T3JkTVhRRldiMmpTZ1VqVGpMeTBlcCthV2JCdEZvRDZC?= =?utf-8?B?VEcwNERLUENIamw0VGRWU0hOS0pmUHJabUU2dlRNMEJtRmc0VkgwMmxvSStN?= =?utf-8?B?dlN1ZWFvVHlOanZQRFNyUHg1OXFDOVMrREhqMTB1Q1R4MnVSR2pkTldWd2VH?= =?utf-8?B?Zkd1YWdLZ3RKWVpRZXBVUkdRNlpNMEhKUlhPdnUxSzZHN21OVXUya2FkMmc5?= =?utf-8?B?T3d3WGl2Tk5EeTh2S3ViM2lVMUN5SW9NdUQ2TWlOcmt3ano2YVU2RExiY2k4?= =?utf-8?B?Rkd3WVVia0xIS2dGSGljTUdoM1NaaEs0SUJEcVNBdUdNbEZoOUFwcUdTa2gy?= =?utf-8?B?UGZWV0ltbGlBZ1JJSEk3QkhoWlZoN3ExQjlzdW81UmJ5bHU5YWFSa2ZOWHY3?= =?utf-8?B?K05WL01DbkJQaCtsNm1FWW1pTVd0K1k1aElZMUY1TXhIS29GVkxKcWNZeFlo?= =?utf-8?B?UTRJK3ZjRUN3RFlFc1NPY1NhTFg1RlM1cEFBV3FqTnllSEhna01wMG5hSXdn?= =?utf-8?B?bDF2dUxwWG9BbmdycHQ4M09SeHFrVEp3RWZ2WC9pMzZEOWNPUVA5ZFJnSzBU?= =?utf-8?B?NDBTS2NuNEdDbjNKanlhUk56T3NOR0w1bmVGN0hXbStuUVBVQ0NUbGkwdGxY?= =?utf-8?B?L3A1WXlmT3NJS2ZaVVg3Ym1uQlpUZzByNVEzOEYrdm5UaW9lYWxteGVOazFR?= =?utf-8?B?Qm94QWY5TWRLNyszM1BiZDBYbEhrUHNScytoVVNJa1RLVWRldkpzYVVwNTJN?= =?utf-8?B?N2ROY1M4cnNLaWRVeHd5RVIvK3I4R3J1aTl3d0VubTdSUWZISisvNklKd2pn?= =?utf-8?B?aDEzM0xqNmtuczM5RS9MM2gyQTFDNHlVQUxSckZrakpuUnNZZldSTUh3UG1W?= =?utf-8?B?TVBQeXVzYjlzVVYrUW1JOXowcFE2blg1RVNycDJRS0laZTBPWC92UGVaRUVD?= =?utf-8?B?TVBjSUFCeTJRd1E4YmxlT0lqdXloLytPOFdOTTl6QU0xVU92aGphU2owWExK?= =?utf-8?B?SXVGKzRlRkh3MjFOTFVwN0RKSG42aDVpeTdyRjZJWHB4RjBQQVpZWllhWXY4?= =?utf-8?B?a1kzTjRaMU5KOFNkbUd6SDRNRXZzY3dtankrWjVSNUs2Z2ZQdSt1UW9xQ2pB?= =?utf-8?B?bGpNbERtWG1ENmRsUGR4UDdselNGVE5yUzZPaWkwUWFRZUx3d0JHZXg1eE45?= =?utf-8?B?VVRRRmFpUnZlRW9BWXBDTFJ1Q0pGVVdIWldzcmxjbzZ1RXJ5NFN0TysreVF4?= =?utf-8?B?QzR6TjY1S2tZWlBqU2FLcGszZDk3eDRQWnM5MGk0U2I2RjFhcThUeS9MUllO?= =?utf-8?B?ZysvYUZ4U3JzektjU0V3VC9xZ2tySEhjWllVc1YrY1ZDdjd6enVpUkZ0eDV2?= =?utf-8?B?K0pheGpRZFZvK2JwNkNWRzM2Y0NlNzcwM0lQM2pZWjJ3SVRPYmdwK3lYcFNQ?= =?utf-8?B?VkpKdmI4aVlGUHhnRkI2V0NlRkpyeldFaWVDaC9hQTN6aGNxaXNTVFZPMEF1?= =?utf-8?B?Yzd3TU1MRjB4dEpIWDdVTE1CR1pkZlpWYTcyaHpRTlhQQklDMUtOKzdBY0Ux?= =?utf-8?B?T05IVGJFUmpSaDdGMHMwaTFqMUxrL3h4b2VtOXUrYzV2dXlEZ2VTUmVXZDN3?= =?utf-8?B?ZXc1R2FwNDBGQmRObld2STBSYXFzY0hDWDcySFJKUDJVYXdmd3JQQVFlZE5T?= =?utf-8?B?RUJkZXY3VmkwK0JHdlFrYnZqM3VZSGh0U3hIR2kwUStyZXBIdE83bDliQTls?= =?utf-8?B?L0tsN0xKRUV6UkhvcHJENmJKNmtFZk95YXQwNmZ1aHdZSUU3SStVK1FhNzI4?= =?utf-8?B?QzgvaFpKV2h4bXQyWDBkNkdONFE4emdUZ3BwWi94aW1VeU9UaDlsVDdib1dy?= =?utf-8?B?bnQzaGVaVTBQcEtzeE5lUkV1aVBoZUZWZ0Rndml1b2ZHUFNYalhmZi9JT3pJ?= =?utf-8?Q?TXSFrWv26B5fzIbc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7092ee2b-4555-4d58-5d05-08da34f6d8a3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 15:40:02.9405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3TxiGytqfXKKGTAd61srRl3SQJ++EuA3BH2Sm9wjbw7mseR/4IjoYjOtW0R4zMKU/DkNATCBeqSpto/Zo9r2/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3584 On Wed, May 11, 2022 at 04:14:23PM +0100, Jane Malalane wrote: > Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for > evtchn delivery set up on a per-vCPU basis via > HVMOP_set_evtchn_upcall_vector. > > is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up > physical IRQ to event channel mappings. I would add something like: The naming of the CPUID bit is a bit generic about upcall support being available. That's done so that the define name doesn't get overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some such. Guests that don't care about physical interrupts routed over event channels can just test for the availability of the hypercall directly (HVMOP_set_evtchn_upcall_vector) without checking the CPUID bit. > > Signed-off-by: Jane Malalane > --- > CC: Jan Beulich > CC: Andrew Cooper > CC: "Roger Pau Monné" > CC: Wei Liu > --- > xen/arch/x86/include/asm/domain.h | 8 +++++++- > xen/arch/x86/traps.c | 3 +++ > xen/include/public/arch-x86/cpuid.h | 2 ++ > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h > index 35898d725f..f044e0a492 100644 > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x86/include/asm/domain.h > @@ -14,8 +14,14 @@ > > #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) > > +/* > + * Set to true if either the global vector-type callback or per-vCPU > + * LAPIC vectors are used. Assume all vCPUs will use I think you should remove LAPIC here. There's no such thing as 'LAPIC vectors', it's just that the old mechanism was bypassing the lapic EOI. > + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. > + */ > #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ > - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) > + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ > + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) > #define is_domain_direct_mapped(d) ((void)(d), 0) > > diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c > index 25bffe47d7..2c51faab2c 100644 > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -1152,6 +1152,9 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, > res->a |= XEN_HVM_CPUID_DOMID_PRESENT; > res->c = d->domain_id; > > + /* Per-vCPU event channel upcalls are implemented. */ ... are implemented and work correctly with PIRQs routed over event channels. > + res->a |= XEN_HVM_CPUID_UPCALL_VECTOR; > + > break; > > case 5: /* PV-specific parameters */ > diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h > index f2b2b3632c..1760e2c405 100644 > --- a/xen/include/public/arch-x86/cpuid.h > +++ b/xen/include/public/arch-x86/cpuid.h > @@ -109,6 +109,8 @@ > * field from 8 to 15 bits, allowing to target APIC IDs up 32768. > */ > #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) > +/* Per-vCPU event channel upcalls. */ I would maybe expand the message to: "Per-vCPU event channel upcalls work correctly with physical IRQs bound to event channels." Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 15:50:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 15:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328605.551664 (Exim 4.92) (envelope-from ) id 1npXYz-0004Uv-6V; Fri, 13 May 2022 15:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328605.551664; Fri, 13 May 2022 15:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXYz-0004Uo-3V; Fri, 13 May 2022 15:50:45 +0000 Received: by outflank-mailman (input) for mailman id 328605; Fri, 13 May 2022 15:44:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXT6-0003fC-Ja for xen-devel@lists.xenproject.org; Fri, 13 May 2022 15:44:40 +0000 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [2607:f8b0:4864:20::1035]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98b7e3db-d2d3-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 17:44:39 +0200 (CEST) Received: by mail-pj1-x1035.google.com with SMTP id e24so8415481pjt.2 for ; Fri, 13 May 2022 08:44:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w2-20020a62c702000000b0050dc762815fsm1962911pfg.57.2022.05.13.08.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 08:44:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98b7e3db-d2d3-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ptf+f5eGDE5JGEu9b++jcke6m+bu7vV+b5hUvmlYQQo=; b=SjhK1c9Qotr1qDOqwKlBj3Rw1mlIdcXMiMnONLsDWXIlWQego7JtnDd+2u8lNhcb5o VntS/+cGhwP5NiXqFa0xo4Eurcd+QW1c6ntV0GvlsEyq5axRcQY1ctFnycyCWVGns4We RoLfLtxqMSNKYzeck8DbrFFmqTXggtzGcj49k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ptf+f5eGDE5JGEu9b++jcke6m+bu7vV+b5hUvmlYQQo=; b=HoYvLbw0+g8e7kC5GruStGpbPxWkNXqopwN6LqI2SCQ/YzGGv1GWJ5juJWV5R81Rnj eudEOLlufhwbNUqEhtIWUcB1jgQNs5+NqcGF7A6P36FmP/oTmwioofz7VevLzwV05ASu wPywCwiPXdnuP3vLJUIbWOnghpX8FW+VQZPTLbTNqD+a097Ps0yPAzLSyD1sIHuSdPZm b6S8T/rjHcYH69n9e0TDdJQGP7PGsfFiNmDDARpb6jY2Ds/NnES4/jEYKCeoIlDSvk8r 1NfojlMfOSMTbagUKoGDVMgdOQzF9GWAUYEsv3kFWuk5hkNq34YaP7BrWl2q/J3eskgw W+fQ== X-Gm-Message-State: AOAM533EPXZpvnh9KLhZPm8yzXtoNx8c8yzSL+ht66yXZRpdB0ekpglR QEDbHpA5Yz9Ch6gEfTYx2KHhZA== X-Google-Smtp-Source: ABdhPJwqAuPQuzMa7Nw48HvMFa1XRY2nR8VILarc4i/slU4gICU2Jf1z21nHPUdwsTyzLFkYEaFwYQ== X-Received: by 2002:a17:902:e393:b0:15c:f1c1:c527 with SMTP id g19-20020a170902e39300b0015cf1c1c527mr5389721ple.22.1652456677768; Fri, 13 May 2022 08:44:37 -0700 (PDT) Date: Fri, 13 May 2022 08:44:33 -0700 From: Kees Cook To: David Howells Cc: "Gustavo A . R . Silva" , Marc Dionne , linux-afs@lists.infradead.org, Alexei Starovoitov , alsa-devel@alsa-project.org, Al Viro , Andrew Gabbasov , Andrew Morton , Andy Gross , Andy Lavr , Arend van Spriel , Baowen Zheng , Bjorn Andersson , Boris Ostrovsky , Bradley Grove , brcm80211-dev-list.pdl@broadcom.com, Christian Brauner , Christian =?iso-8859-1?Q?G=F6ttsche?= , Christian Lamparter , Chris Zankel , Cong Wang , Daniel Axtens , Daniel Vetter , Dan Williams , David Gow , "David S. Miller" , Dennis Dalessandro , devicetree@vger.kernel.org, Dexuan Cui , Dmitry Kasatkin , Eli Cohen , Eric Dumazet , Eric Paris , Eugeniu Rosca , Felipe Balbi , Francis Laniel , Frank Rowand , Franky Lin , Greg Kroah-Hartman , Gregory Greenman , Guenter Roeck , Haiyang Zhang , Hante Meuleman , Herbert Xu , Hulk Robot , Jakub Kicinski , "James E.J. Bottomley" , James Morris , Jarkko Sakkinen , Jaroslav Kysela , Jason Gunthorpe , Jens Axboe , Johan Hedberg , Johannes Berg , Johannes Berg , John Keeping , Juergen Gross , Kalle Valo , Keith Packard , keyrings@vger.kernel.org, kunit-dev@googlegroups.com, Kuniyuki Iwashima , "K. Y. Srinivasan" , Lars-Peter Clausen , Lee Jones , Leon Romanovsky , Liam Girdwood , linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-hardening@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-integrity@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, linux-xtensa@linux-xtensa.org, llvm@lists.linux.dev, Loic Poulain , Louis Peens , Luca Coelho , Luiz Augusto von Dentz , Marcel Holtmann , Mark Brown , "Martin K. Petersen" , Max Filippov , Mimi Zohar , Muchun Song , Nathan Chancellor , netdev@vger.kernel.org, Nick Desaulniers , Nuno =?iso-8859-1?Q?S=E1?= , Paolo Abeni , Paul Moore , Rich Felker , Rob Herring , Russell King , selinux@vger.kernel.org, "Serge E. Hallyn" , SHA-cyfmac-dev-list@infineon.com, Simon Horman , Stefano Stabellini , Stefan Richter , Steffen Klassert , Stephen Hemminger , Stephen Smalley , Tadeusz Struk , Takashi Iwai , Tom Rix , Udipto Goswami , Vincenzo Frascino , wcn36xx@lists.infradead.org, Wei Liu , xen-devel@lists.xenproject.org, Xiu Jianfeng , Yang Yingliang Subject: Re: [PATCH 19/32] afs: Use mem_to_flex_dup() with struct afs_acl Message-ID: <202205130841.686F21B64@keescook> References: <20220504014440.3697851-20-keescook@chromium.org> <20220504014440.3697851-1-keescook@chromium.org> <898803.1652391665@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <898803.1652391665@warthog.procyon.org.uk> On Thu, May 12, 2022 at 10:41:05PM +0100, David Howells wrote: > > Kees Cook wrote: > > > struct afs_acl { > > - u32 size; > > - u8 data[]; > > + DECLARE_FLEX_ARRAY_ELEMENTS_COUNT(u32, size); > > + DECLARE_FLEX_ARRAY_ELEMENTS(u8, data); > > }; > > Oof... That's really quite unpleasant syntax. Is it not possible to have > mem_to_flex_dup() and friends work without that? You are telling them the > fields they have to fill in. Other threads discussed this too. I'm hoping to have something more flexible (pardon the pun) in v2. > [...] > or: > > ret = mem_to_flex_dup(&acl, buffer, size, GFP_KERNEL); > if (ret < 0) > > (or use != 0 rather than < 0) Sure, I can make the tests more explicit. The kerndoc, etc all shows it's using < 0 for errors. -- Kees Cook From xen-devel-bounces@lists.xenproject.org Fri May 13 15:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 15:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328613.551675 (Exim 4.92) (envelope-from ) id 1npXhq-0005EC-3l; Fri, 13 May 2022 15:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328613.551675; Fri, 13 May 2022 15:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXhq-0005E5-0y; Fri, 13 May 2022 15:59:54 +0000 Received: by outflank-mailman (input) for mailman id 328613; Fri, 13 May 2022 15:59:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXho-0005Dv-73; Fri, 13 May 2022 15:59:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXho-0003Ct-5w; Fri, 13 May 2022 15:59:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npXhn-0007Eb-N1; Fri, 13 May 2022 15:59:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npXhn-0002fo-Mb; Fri, 13 May 2022 15:59:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rBma/mwy0JEopABp4but6+E0a9/Z0+SVlGvmgXiIdq0=; b=LRv8GFjhB2v9SlZ9Il+1hC58Ko kSQt0H12bahO2+xURtCErLQLlmf/yOrVIWNOaH2ub35CClxbHOS6QYYkwRXAPBahycLtkv+iRINCx mhylOg/3TISYgl7Qb3k7Ki5WacXWdzLf7NFUVbrDG+o0CzwXcIlr/6St8T9hxP7OJWBE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170392: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 15:59:51 +0000 flight 170392 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170392/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 982 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 16:30:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 16:30:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328623.551686 (Exim 4.92) (envelope-from ) id 1npYBA-0001Ob-Fd; Fri, 13 May 2022 16:30:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328623.551686; Fri, 13 May 2022 16:30:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYBA-0001OU-Bb; Fri, 13 May 2022 16:30:12 +0000 Received: by outflank-mailman (input) for mailman id 328623; Fri, 13 May 2022 16:30:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYB8-0001OK-Ft; Fri, 13 May 2022 16:30:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYB8-0004Jr-89; Fri, 13 May 2022 16:30:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYB7-000862-Qy; Fri, 13 May 2022 16:30:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npYB7-0003Wb-QV; Fri, 13 May 2022 16:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IXKKitBZPJBoaCVNKdbrWtxG5JErE1vpmqQRbaJUL70=; b=6gMRy7LxkjL6QvHhmW1ImC3Z1D B3h2a2D8ItPPkspBxl265CdkhpnYVrz+QzzGcJu0KppYIMlMvf5Ia61ynbxzsTKX4ziK0s4fwKNwr qbpBRELkRZRrVeIj+Bh7Dw0QKTo8ORwyCY4e2EOenvPYU+FU0crrZZWHaEE24SRS1l7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170380: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f3f19f939c11925dadd3f4776f99f8c278a7017b X-Osstest-Versions-That: linux=0ac824f379fba2c2b17b75fd5ada69cd68c66348 From: osstest service owner Date: Fri, 13 May 2022 16:30:09 +0000 flight 170380 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170380/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170365 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170365 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170365 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170365 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170365 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170365 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170365 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170365 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux f3f19f939c11925dadd3f4776f99f8c278a7017b baseline version: linux 0ac824f379fba2c2b17b75fd5ada69cd68c66348 Last test of basis 170365 2022-05-12 18:09:47 Z 0 days Testing same since 170380 2022-05-13 04:33:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandra Winter Amit Cohen Anatolii Gerasymenko Bassem Dawood Chris Packham David S. Miller Dmitry V. Levin Eric Dumazet Fabio Estevam Felix Fietkau Felix Kaechele Florian Fainelli Francesco Dolcini Geliang Tang Gleb Fotengauer-Malinovskiy Grant Grundler Gregory Greenman Guangguan Wang Guenter Roeck Gurucharan (A Contingent worker at Intel) Holger Hoffstaette Ido Schimmel Itay Iellin Ivan Vecera Jacob Keller Jakub Kicinski Jamal Hadi Salim Jesse Brandeburg Johannes Berg Jonathan Lemon Jonathan Toppins Jordan Leppert Kalle Valo Kalle Valo Karsten Graul Kees Cook Kieran Frewen Konrad Jankowski Lina Wang Linus Torvalds Lokesh Dhoundiyal Luca Coelho Luiz Augusto von Dentz Maciej enczykowski Manikanta Pubbisetty Manuel Ullmann Martin Habets Mat Martineau Maxim Mikityanskiy Michal Michalik Nicolas Dichtel Paolo Abeni Sedat Dilek # Linux v5.17.3-rc1 and Debian LLVM-14 Simon Wunderlich Sven Eckelmann Taehee Yoo Tariq Toukan Tetsuo Handa Toke Høiland-Jørgensen Tony Nguyen Vladimir Oltean Wan Jiabing Wen Gong Xiaomeng Tong Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0ac824f379fb..f3f19f939c11 f3f19f939c11925dadd3f4776f99f8c278a7017b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 13 16:30:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 16:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328629.551697 (Exim 4.92) (envelope-from ) id 1npYBa-0001pp-08; Fri, 13 May 2022 16:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328629.551697; Fri, 13 May 2022 16:30:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYBZ-0001pi-TQ; Fri, 13 May 2022 16:30:37 +0000 Received: by outflank-mailman (input) for mailman id 328629; Fri, 13 May 2022 16:30:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYBZ-0001pW-6n; Fri, 13 May 2022 16:30:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYBZ-0004M4-5r; Fri, 13 May 2022 16:30:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYBY-00086Y-Rj; Fri, 13 May 2022 16:30:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npYBY-0003X8-RD; Fri, 13 May 2022 16:30:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+HCFGrnLfKMi9+ezEmisrF2pvb6qR/fowra1uKUPWD0=; b=sWj/aE57SSgagWeMO6foK2egEb 6PsN52qh1gthp+av4uqkzXcP1uJhIzI3TZdLZF1ea/mwuAQrStq43V38GKcJxv6SfWjardx2trhbj rsNPMTHrPcLYOyvV32Bcv7K8qljJzMiWZGAc+8TpWZ4lI8K+X/10MKlOKgUf6lKDMi+c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170394: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 16:30:36 +0000 flight 170394 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170394/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 983 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 16:59:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 16:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328642.551708 (Exim 4.92) (envelope-from ) id 1npYdf-0004bA-CO; Fri, 13 May 2022 16:59:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328642.551708; Fri, 13 May 2022 16:59:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYdf-0004b3-8q; Fri, 13 May 2022 16:59:39 +0000 Received: by outflank-mailman (input) for mailman id 328642; Fri, 13 May 2022 16:59:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYdd-0004at-LZ; Fri, 13 May 2022 16:59:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYdd-0004r4-Ja; Fri, 13 May 2022 16:59:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYdd-0000O4-8v; Fri, 13 May 2022 16:59:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npYdd-000386-8U; Fri, 13 May 2022 16:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R3kxbnANPtmsSaZbnAczKhMyLNWEfX9JO5M6khIGoE8=; b=oFY/JE3jIvMpQXOzdfCxahoSjK wlsmOg5x8sq+EzsDo1l4CN6WqOqoi33C+cKY17s8h2nI+LI5+LLkuvWNiC0IssD0ifHwxsSDYM0Y3 lliafji7Us8jhUFe5wH1J3SBFFK0pVg3f9xMs/jx6vLZUiJPUVR49a1kAYpke0LoYw04=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170395: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 16:59:37 +0000 flight 170395 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 984 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 17:05:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 17:05:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328650.551719 (Exim 4.92) (envelope-from ) id 1npYj6-00063e-3h; Fri, 13 May 2022 17:05:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328650.551719; Fri, 13 May 2022 17:05:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYj5-00063X-Va; Fri, 13 May 2022 17:05:15 +0000 Received: by outflank-mailman (input) for mailman id 328650; Fri, 13 May 2022 17:05:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npYj4-00063R-EG for xen-devel@lists.xenproject.org; Fri, 13 May 2022 17:05:14 +0000 Received: from mail186-17.suw21.mandrillapp.com (mail186-17.suw21.mandrillapp.com [198.2.186.17]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9aa9993-d2de-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 19:05:12 +0200 (CEST) Received: from pmta10.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail186-17.suw21.mandrillapp.com (Mailchimp) with ESMTP id 4L0FPz2k0YzRKMQ7N for ; Fri, 13 May 2022 17:05:11 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 5c0e25287e7b4a26b4548689c60e1592; Fri, 13 May 2022 17:05:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9aa9993-d2de-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1652461511; x=1652763911; i=marc.ungeschikts@vates.fr; bh=6VMa82fFehYGCBPtqUU3FSCjEnY5hGlTULuPFGsugSA=; h=From:Subject:In-Reply-To:References:Message-Id:To:Cc:Feedback-ID: Date:MIME-Version:Content-Type:CC:Date:Subject:From; b=EsOFnrgAAIngmQUn83c2cpFWLg0/ridGft5l1XTzfkXchLIXgKqUhoPqf6gwzTNkM g3JrjbLvSrADAJVbCR70KqolYS/thPnWbpbI6VZCvDKxV9RKQYh8HVDSdQNKncN6sP m00mnRMXkCHpct58JjWNZy+VYztrCFHXew8e3/Lw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1652461511; h=From : Subject : In-Reply-To : References : Message-Id : To : Cc : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=6VMa82fFehYGCBPtqUU3FSCjEnY5hGlTULuPFGsugSA=; b=U14DuLuF4A63yB7RmiXPmkGTdTpu0NEErVc42/XBBtcyq2zqKZz3Y5bmNyekF2oHmvzFNp Z9ovTP4SnldgVGS6gNLrS80S2Xs27zCw9PlXvXiL7KEm8KhjbxW6VbydansUJ4BX80PJA9IS NhtRlSWBAfvHa2f1p8GKYWPd1cfKE= From: Marc Ungeschikts Subject: Re: Xen Project management working group X-Bm-Draft-Refresh-Date: 1652461507157 X-Bm-Draft-Info: {"type":"REPLY-ALL","messageInternalId":712905,"folderUid":"06b05917-1346-47a2-9230-c6774f30abc7"} X-Bm-Internal-Id: DE8B30B6-117C-4174-8780-9ABFF47FC58A#bluemind-4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2:758590 X-Bm-Previous-Body: 3e0593170f2af59bb6cdf96d99f1f2135a203db7 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 3523b2ae-1a6d-426e-b33d-cb0b1be20df1 X-Bm-Transport-Timestamp: 1652461508714 In-Reply-To: References: Message-Id: To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, george.dunlap@citrix.com, Marc Ungeschikts , Olivier Lambert , christopher.clark@starlab.io X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.5c0e25287e7b4a26b4548689c60e1592 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220513:md Date: Fri, 13 May 2022 17:05:11 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-ittsCsXjlDZIBXZJZc0A-A" --_av-ittsCsXjlDZIBXZJZc0A-A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Conclusion of the Doodle https://doodle.com/meeting/organize/id/dyPg8MWb : The next working group meeting will take place Wednesday 18th May at 3PM UTC (4PM London time, 5PM Paris time) Meeting place will be: https://meet.vates.fr/xenmgmt See you soon! On Monday, 04/11/2022, 01:21 PM, Olivier Lambert wrote: https://doodle.com/meeting/participate/id/b822G1ge I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here. So, as planned, here is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add this to your calendar :) Meeting place will be: https://meet.vates.fr/xenmgmt See you soon! Regards, Olivier Lambert | Vates CEO XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com --_av-ittsCsXjlDZIBXZJZc0A-A Content-Type: multipart/related; boundary="_av-aWSw1zcNBL2ZS69yceVHQQ" --_av-aWSw1zcNBL2ZS69yceVHQQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Conclusion of the Doodle https://doodle.com/meeting/organize/id/dyPg8MWb :
The next working group meeting will take place Wednesday 18th May at 3PM UTC (4PM London time, 5PM Paris time)


Meeting place will be: https://meet.vates.fr/xenmgmt

See you soon!

On Monday, 04/11/2022, 01:21 PM, Olivier Lambert wrote:


https://doodle.com/meeting/participate/id/b822G1ge


I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here.



So, as planned, here is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add this to your calendar :)


Meeting place will be:

https://meet.vates.fr/xenmgmt


See you soon!




Regards,

 
 

 
Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solutions
w: vates.fr | xcp-ng.org | xen-orchestra.com
--_av-aWSw1zcNBL2ZS69yceVHQQ Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline /9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/ 2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1 dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU 1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR 8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0 nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7 9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8 F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+ Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5 +GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/ 4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8 Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W 0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+ 7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4 S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+ JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3 aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8 M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/ j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/ hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8 HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI /wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r 7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3 hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia 2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9 /p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT 6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb 9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88 KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM 77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8 e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7 i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4 ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4 P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD 4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4 ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01 8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq /wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8 SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y +NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67 SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n /Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm 8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS 0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60 qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z 3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5 Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx 7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8 vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44 +IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v +/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3 uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0 Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340 fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4 Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn /BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38 KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/ jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2 mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm 3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF 43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt 4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7 G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP 2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94 uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+ J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21 OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3 /g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0 r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox 8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe 0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v 14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S 8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+ BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/ AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/ sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4 M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy /wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd +wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR 8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/ BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk 0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ 88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr 5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6 Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6 RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/ Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7 sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF 0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+ GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo 0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740 xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4 YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl 0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u 0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2 fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5 rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l /q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6 WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU 62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7 694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/ BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L +E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW 8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw 2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+ HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G 0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP 4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4 NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2 /wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0 1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI 8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+ Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy 3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy 2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8 RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74 meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0 nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1 W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs 8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0 H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p 1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx /tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/ 2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH /wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd 5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9 6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr 8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL /wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b +GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w 9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815 60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3 s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690 H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj 7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1 ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4 nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG 4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD 3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh 6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8 T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC 61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+ ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5 TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf 8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM 2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44 YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3 KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+ WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G /CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+ TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+ WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/ B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1 JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV 8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P 4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9 u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ 8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1 K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL 8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj 5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0 FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7 f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km 22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/ sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+ wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp 6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/ AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7 fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u 1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR 1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0 n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd 8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw 0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN 3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1 tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7 rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr 9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc /tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+ ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U 3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9 bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh 2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo 3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0 7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0 cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV 5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq 5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/ FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I 7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/ 4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8 PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K 3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6 nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs 1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej 7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+ D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs 6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z 1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP 2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3 HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7 u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp 08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2 R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+ P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP 82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgD//2Q== --_av-aWSw1zcNBL2ZS69yceVHQQ Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline /9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/ 2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1 dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU 1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR 8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0 nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7 9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8 F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+ Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5 +GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/ 4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8 Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W 0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+ 7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4 S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+ JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3 aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8 M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/ j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/ hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8 HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI /wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r 7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3 hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia 2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9 /p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT 6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb 9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88 KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM 77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8 e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7 i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4 ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4 P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD 4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4 ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01 8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq /wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8 SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y +NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67 SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n /Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm 8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS 0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60 qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z 3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5 Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx 7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8 vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44 +IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v +/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3 uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0 Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340 fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4 Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn /BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38 KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/ jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2 mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm 3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF 43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt 4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7 G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP 2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94 uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+ J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21 OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3 /g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0 r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox 8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe 0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v 14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S 8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+ BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/ AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/ sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4 M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy /wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd +wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR 8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/ BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk 0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ 88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr 5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6 Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6 RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/ Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7 sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF 0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+ GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo 0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740 xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4 YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl 0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u 0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2 fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5 rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l /q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6 WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU 62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7 694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/ BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L +E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW 8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw 2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+ HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G 0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP 4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4 NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2 /wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0 1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI 8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+ Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy 3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy 2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8 RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74 meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0 nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1 W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs 8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0 H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p 1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx /tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/ 2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH /wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd 5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9 6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr 8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL /wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b +GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w 9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815 60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3 s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690 H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj 7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1 ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4 nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG 4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD 3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh 6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8 T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC 61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+ ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5 TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf 8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM 2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44 YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3 KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+ WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G /CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+ TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+ WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/ B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1 JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV 8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P 4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9 u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ 8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1 K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL 8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj 5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0 FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7 f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km 22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/ sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+ wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp 6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/ AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7 fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u 1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR 1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0 n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd 8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw 0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN 3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1 tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7 rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr 9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc /tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+ ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U 3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9 bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh 2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo 3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0 7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0 cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV 5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq 5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/ FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I 7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/ 4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8 PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K 3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6 nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs 1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej 7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+ D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs 6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z 1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP 2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3 HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7 u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp 08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2 R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+ P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP 82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgD//2Q== --_av-aWSw1zcNBL2ZS69yceVHQQ-- --_av-ittsCsXjlDZIBXZJZc0A-A-- From xen-devel-bounces@lists.xenproject.org Fri May 13 17:41:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 17:41:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328660.551733 (Exim 4.92) (envelope-from ) id 1npZHy-0001ok-48; Fri, 13 May 2022 17:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328660.551733; Fri, 13 May 2022 17:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZHy-0001od-1A; Fri, 13 May 2022 17:41:18 +0000 Received: by outflank-mailman (input) for mailman id 328660; Fri, 13 May 2022 17:41:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZHw-0001oX-QZ for xen-devel@lists.xenproject.org; Fri, 13 May 2022 17:41:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZHw-0005ek-68; Fri, 13 May 2022 17:41:16 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.8.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npZHv-0005vq-Va; Fri, 13 May 2022 17:41:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8fOpbeIsstYvBhgFsEZL6GowsKX0Tmj2mfCTkzGSJEU=; b=1aVAUmYQoR+blZC+fD5+aEZ94Y h6iNF8l8oVcPKJCZ6gYqYAOv6YPCOLeevDB6AsBLA1uW3989FhOPymYOUejWf3hHX05MJqXME/nfR sfy13Zr9lUCIsrYIq2wvAz8R2L72zv/6BYCFFGtgFg4nk0XiODeh5TDjwquiBqBU7+Uw=; Message-ID: Date: Fri, 13 May 2022 18:41:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 04/36] xen/arm: add parsing function for cache coloring configuration To: Carlo Nonato , Marco Solieri , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Marco Solieri , Andrea Bastoni , Stefano Stabellini References: <20220304174701.1453977-1-marco.solieri@minervasys.tech> <20220304174701.1453977-5-marco.solieri@minervasys.tech> <2f357e1a-df8e-6326-267e-4d12e82e1a5f@xen.org> <7acb1709-344d-6995-ee9d-df6652d505b5@minervasys.tech> From: Julien Grall In-Reply-To: <7acb1709-344d-6995-ee9d-df6652d505b5@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/05/2022 15:22, Carlo Nonato wrote: > Hi Julien, Hi Carlo, > I'm Carlo, the new developer that will work on this patch set and on the > review. > > Thanks for all the comments. I'll try to answer to all the open points > and also > ask for feedback. > > On 09/03/22 20:09, Julien Grall wrote: >>> - way_size: The size of a LLC way in bytes. This value is mainly used >>>    to calculate the maximum available colors on the platform. >> >> We should only add command line option when they are a strong use >> case. In documentation, you wrote that someone may want to overwrite >> the way size for "specific needs". >> >> Can you explain what would be those needs? > This parameter is here mainly to support QEMU on which the automatic > probing > of the LLC size doesn't work properly. I am not in favor of adding command line option just for QEMU. But... > > Also, since from this value we compute the maximum number of colors > the architecture supports, you may want to fix the way size so as to > simulate > a different use case for debugging purposes. ... this reason is more compelling to me. > > Should I add those notes somewhere (doc, commit messages, etc.)? So I would mention it in the commit message and also the doc description the options. > >>> A cache coloring configuration consists of a selection of colors to be >>> assigned to a VM or to the hypervisor. It is represented by a set of >>> ranges. Add a common function that parses a string with a >>> comma-separated set of hyphen-separated ranges like "0-7,15-16" and >>> returns both: the number of chosen colors, and an array containing their >>> ids. >>> Currently we support platforms with up to 128 colors. >> >> Is there any reason this value is hardcoded in Xen rather than part of >> the Kconfig? > Having another parameter to configure can complicate things from > the user perspective. I don't think it would be more complicated. The default would still be 128 and would help the user to easily modify the value if... > Also 128 is more than enough for the current ARM > processors we tested. ... they are using a processor you didn't tested on. >>> Signed-off-by: Luca Miccio >>> Signed-off-by: Marco Solieri >>> Signed-off-by: Stefano Stabellini >>> --- >>>   xen/arch/arm/Kconfig                |   5 ++ >>>   xen/arch/arm/Makefile               |   2 +- >>>   xen/arch/arm/coloring.c             | 131 ++++++++++++++++++++++++++++ >>>   xen/arch/arm/include/asm/coloring.h |  28 ++++++ >>>   4 files changed, 165 insertions(+), 1 deletion(-) >>>   create mode 100644 xen/arch/arm/coloring.c >>>   create mode 100644 xen/arch/arm/include/asm/coloring.h >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index ecfa6822e4..f0f999d172 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -97,6 +97,11 @@ config HARDEN_BRANCH_PREDICTOR >>>           If unsure, say Y. >>>   +config COLORING >>> +    bool "L2 cache coloring" >>> +    default n >> >> This wants to be gated with EXPERT for time-being. SUPPORT.MD woudl >> Furthermore, I think this wants to be gated with EXPERT for the >> time-being. >> >>> +    depends on ARM_64 >> >> Why is this limited to arm64? > Because arm32 isn't an "interesting" architecture where to have coloring > since there are locking primitives that provides sufficient isolation > and so > the problem is not common. I am afraid I don't understand this rationale. What sort of locking are you talking about? That said,I am not asking to implement the 32-bit side. I am more interested to know what's the effort required here. IOW, is it disabled because you haven't tested? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 13 17:47:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 17:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328667.551744 (Exim 4.92) (envelope-from ) id 1npZO8-0002VD-Qi; Fri, 13 May 2022 17:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328667.551744; Fri, 13 May 2022 17:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZO8-0002V6-N0; Fri, 13 May 2022 17:47:40 +0000 Received: by outflank-mailman (input) for mailman id 328667; Fri, 13 May 2022 17:47:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZO8-0002Ug-2S; Fri, 13 May 2022 17:47:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZO7-0005oQ-Vn; Fri, 13 May 2022 17:47:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZO7-0001SN-KE; Fri, 13 May 2022 17:47:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npZO7-00075l-Jn; Fri, 13 May 2022 17:47:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eaWytT/K7jOrCDIyL3UYozRjPMD48O/EsI3pHjK601M=; b=GrI5hs8UnQ1XhDxI/VNnORs5um qqVqD72S4FNZIPfbAfXdf1PThDIUH6wrr/T8oXzIZyhGY7v9fKyZfzaYxqI3zUu6Na3r5r6JZzfTJ CzlGxXGs/C4pYcyAK/dgjMpteRTp94nT4ykULsrRNMmz1mMLnIbfo+K3I0mGlqSL4Cao=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170396: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 17:47:39 +0000 flight 170396 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170396/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 985 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 18:10:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 18:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328679.551783 (Exim 4.92) (envelope-from ) id 1npZjw-0006MU-Mz; Fri, 13 May 2022 18:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328679.551783; Fri, 13 May 2022 18:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZjw-0006Kl-GP; Fri, 13 May 2022 18:10:12 +0000 Received: by outflank-mailman (input) for mailman id 328679; Fri, 13 May 2022 18:10:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZjv-0005kx-Me for xen-devel@lists.xenproject.org; Fri, 13 May 2022 18:10:11 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed969dc2-d2e7-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 20:10:10 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id ks9so17763395ejb.2 for ; Fri, 13 May 2022 11:10:10 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-014-181-123.89.14.pool.telefonica.de. [89.14.181.123]) by smtp.gmail.com with ESMTPSA id e11-20020a170906648b00b006fa84a0af2asm1040008ejm.16.2022.05.13.11.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:10:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed969dc2-d2e7-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CBXAkFrCGs28BI30AzYWmYh3sIrQDSjFAmvH5xdAdFk=; b=Bgcy7jIh1t61wlZnBAq+JZld3nOesqYuWWAdJJQ0sl5bxUB9nsHbDiHngRu1OutYbW OG4VHmgNSqmhme8qgcCXmbEvIbIkbJDxxYz0+LuY/SJhWJjQ3/CYEQ9XFbgPX1dsLuxf XIGJ53kceKKUz2qVjgUC/cWmwF3HbLDV5msbnHnu8HPlavKmPUxicAXfXl2G0GqjwW32 mYHwZUV1bTyn8D8pLeBFHjF+NFVyzw1boC9HcP8y/EX8ZZ4I4r3zhkHORo6RIDVJjr/l ESmOonSf3nBPpEBH/WkgN4DFFIGJVy2vYJJOgtj8wUkMscuLJRjrQ4/xw3nRhil/1CJL xNKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CBXAkFrCGs28BI30AzYWmYh3sIrQDSjFAmvH5xdAdFk=; b=BxpW4U0cJuvwGLVQgedT6caloKpfusMQgV0qSBCMjsYi5uGjg8x6WnZeVQUA31ID2j X+t7kGPSenj4fQTykkKVjL6f7JCt3fF3Kaszr5ToudqfjLXN7+oF69FRfTr4VZLxBiuk /nlp3+hSsm7NiluzD+JF/rfictZlc1EfOPxNYh2QoPtCBwYKIwqN98nHkekSI5q+ZQeD QiH8JKx9dpLzrQYrp2Sbh96+EEHkkYgmjX1xllDWwMecYDrqCry3sB1XOdeNtWvmrjXz xIE830UMbzMGTKS/e7JfTbC5xKypzg+kmskqff7o4mVeqkbdMabtm8RF+KwI68EtIgAY HTVA== X-Gm-Message-State: AOAM530G4mfcCJWICuqfTrpse97scmoYudE1KVtiNVRtNEksrWZmc/iB taiH2YgkiW4odyx+KojasNM= X-Google-Smtp-Source: ABdhPJzd1ozMHGZZFnRvVPDcf7J6MJFx90w5pAiPDrPJQobwuWQ40761pwClkT/3oeGExjerubnvSw== X-Received: by 2002:a17:907:97c4:b0:6f8:5ec5:61e2 with SMTP id js4-20020a17090797c400b006f85ec561e2mr5456098ejc.559.1652465410414; Fri, 13 May 2022 11:10:10 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org, Bernhard Beschow , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Date: Fri, 13 May 2022 20:09:57 +0200 Message-Id: <20220513180957.90514-4-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513180957.90514-1-shentey@gmail.com> References: <20220513180957.90514-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This function was declared in a generic and public header, implemented in a device-specific source file but only used in xen_platform. Given its 'aux' parameter, this function is more xen-specific than piix-specific. Also, the hardcoded magic constants seem to be generic and related to PCIIDEState and IDEBus rather than piix. Therefore, move this function to xen_platform, unexport it, and drop the "piix3" in the function name as well. Signed-off-by: Bernhard Beschow Reviewed-by: Paul Durrant --- hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++- hw/ide/piix.c | 46 ------------------------------------ include/hw/ide.h | 3 --- 3 files changed, 47 insertions(+), 50 deletions(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 72028449ba..a64265cca0 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -26,6 +26,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "hw/ide.h" +#include "hw/ide/pci.h" #include "hw/pci/pci.h" #include "hw/xen/xen_common.h" #include "migration/vmstate.h" @@ -134,6 +135,51 @@ static void pci_unplug_nics(PCIBus *bus) pci_for_each_device(bus, 0, unplug_nic, NULL); } +/* + * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to + * request unplug of 'aux' disks (which is stated to mean all IDE disks, + * except the primary master). + * + * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks + * is simultaneously requested is not clear. The implementation assumes + * that an 'all' request overrides an 'aux' request. + * + * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc + */ +static void pci_xen_ide_unplug(DeviceState *dev, bool aux) +{ + PCIIDEState *pci_ide; + int i; + IDEDevice *idedev; + IDEBus *idebus; + BlockBackend *blk; + + pci_ide = PCI_IDE(dev); + + for (i = aux ? 1 : 0; i < 4; i++) { + idebus = &pci_ide->bus[i / 2]; + blk = idebus->ifs[i % 2].blk; + + if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { + if (!(i % 2)) { + idedev = idebus->master; + } else { + idedev = idebus->slave; + } + + blk_drain(blk); + blk_flush(blk); + + blk_detach_dev(blk, DEVICE(idedev)); + idebus->ifs[i % 2].blk = NULL; + idedev->conf.blk = NULL; + monitor_remove_blk(blk); + blk_unref(blk); + } + } + qdev_reset_all(dev); +} + static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) { uint32_t flags = *(uint32_t *)opaque; @@ -147,7 +193,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) { case PCI_CLASS_STORAGE_IDE: - pci_piix3_xen_ide_unplug(DEVICE(d), aux); + pci_xen_ide_unplug(DEVICE(d), aux); break; case PCI_CLASS_STORAGE_SCSI: diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bc1b37512a..9a9b28078e 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -173,52 +173,6 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) } } -/* - * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to - * request unplug of 'aux' disks (which is stated to mean all IDE disks, - * except the primary master). - * - * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks - * is simultaneously requested is not clear. The implementation assumes - * that an 'all' request overrides an 'aux' request. - * - * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc - */ -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) -{ - PCIIDEState *pci_ide; - int i; - IDEDevice *idedev; - IDEBus *idebus; - BlockBackend *blk; - - pci_ide = PCI_IDE(dev); - - for (i = aux ? 1 : 0; i < 4; i++) { - idebus = &pci_ide->bus[i / 2]; - blk = idebus->ifs[i % 2].blk; - - if (blk && idebus->ifs[i % 2].drive_kind != IDE_CD) { - if (!(i % 2)) { - idedev = idebus->master; - } else { - idedev = idebus->slave; - } - - blk_drain(blk); - blk_flush(blk); - - blk_detach_dev(blk, DEVICE(idedev)); - idebus->ifs[i % 2].blk = NULL; - idedev->conf.blk = NULL; - monitor_remove_blk(blk); - blk_unref(blk); - } - } - qdev_reset_all(dev); - return 0; -} - static void pci_piix_ide_exitfn(PCIDevice *dev) { PCIIDEState *d = PCI_IDE(dev); diff --git a/include/hw/ide.h b/include/hw/ide.h index c5ce5da4f4..60f1f4f714 100644 --- a/include/hw/ide.h +++ b/include/hw/ide.h @@ -8,9 +8,6 @@ ISADevice *isa_ide_init(ISABus *bus, int iobase, int iobase2, int isairq, DriveInfo *hd0, DriveInfo *hd1); -/* ide-pci.c */ -int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux); - /* ide-mmio.c */ void mmio_ide_init_drives(DeviceState *dev, DriveInfo *hd0, DriveInfo *hd1); -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 18:10:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 18:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328677.551759 (Exim 4.92) (envelope-from ) id 1npZju-0005oT-Uk; Fri, 13 May 2022 18:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328677.551759; Fri, 13 May 2022 18:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZju-0005nz-RE; Fri, 13 May 2022 18:10:10 +0000 Received: by outflank-mailman (input) for mailman id 328677; Fri, 13 May 2022 18:10:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZjt-0005kx-Su for xen-devel@lists.xenproject.org; Fri, 13 May 2022 18:10:09 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec4ee4e2-d2e7-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 20:10:08 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id j6so17685722ejc.13 for ; Fri, 13 May 2022 11:10:08 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-014-181-123.89.14.pool.telefonica.de. [89.14.181.123]) by smtp.gmail.com with ESMTPSA id e11-20020a170906648b00b006fa84a0af2asm1040008ejm.16.2022.05.13.11.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:10:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec4ee4e2-d2e7-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x/cQH/1Zw9GFUPtTbC8zhxsJeeQwE0nxDRipyyaTmMk=; b=nJbHxWaET9J2XSZE+M5dxA8DbQG9coK769SMpj9GQeA6B5MYfqK0lpTZcTTjHsEoB2 YsduPUN8KjpCjR1DlXYGnacXqjJvn7IpxP4QJwwabsXwlB2JehTlehcQWwm8++WmkHfw zMKKJEq7lkxDz9bynvEtBKYjR8DZFnZ0q1rIZLCNHjl5MEiaHmg2/Pua8eTz0e5i/K0s O35/MwMsvzGnN1SNER3JYxYIq1A0gTWG/4Mf4U0UOVAfyKazUT1wcSm0RnH/KlFTIpPO ezpSVliTQlXlbntvSNatMSPlv39fsevETfJV20FcGkLi7qNZ1UwkQcUejQEj+ufSI0cT RTuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x/cQH/1Zw9GFUPtTbC8zhxsJeeQwE0nxDRipyyaTmMk=; b=FTVttHFuUlvijRcgSuVuUeCt1nZAe9YhyxuQyNNIZv7CN3Bgq7ag/0ASzAqtz5IWbN rkG6XVkQOAJRqyjwYvgBb1Z/JjG07qGtTDtRDLNsPt77fGLAXKgd/9IPHi/pn65BwNAq gL9EmvLd/4r/W+e31UpLCxUT6hBVQa2UgbtuJIq065VhpwXCXNnFSGJlcRxDhq/O85Ir UV6OdN1TnYAOwXlRhZ0+vsy9lc4Y6tofK7+tokmB3hXWu5+1BUCwsoz9kUQa8yXLqNCi vW+p2l3RB1reGhKdAr1cCCXjENXHP36mcGpahvfHVMTnL/IL2sykWnN0+AQH26VqKDEN C0UA== X-Gm-Message-State: AOAM531gVxEFe7t8Q6SKE6MyydRHOPROG8SylFeFOpby1k39DbXXjxiR pdvF++Gwk1jsSZKvOJMx8k4= X-Google-Smtp-Source: ABdhPJzCkBRWOB3k5QAtg0VncyWPkLbOceUIGxvuo0vGktR8YMH06iLzsWamhF0MqDhovZ65RgZoVQ== X-Received: by 2002:a17:907:2064:b0:6f4:3f07:c76e with SMTP id qp4-20020a170907206400b006f43f07c76emr5383734ejb.462.1652465408332; Fri, 13 May 2022 11:10:08 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org, Bernhard Beschow , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH v2 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class Date: Fri, 13 May 2022 20:09:55 +0200 Message-Id: <20220513180957.90514-2-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513180957.90514-1-shentey@gmail.com> References: <20220513180957.90514-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci generic class init function' already resolved redundant code which in turn rendered piix3-ide-xen redundant. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 3 +-- hw/ide/piix.c | 7 ------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f843dd906f..c2bf33d2f1 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -244,8 +244,7 @@ static void pc_init1(MachineState *machine, if (pcmc->pci_enabled) { PCIDevice *dev; - dev = pci_create_simple(pci_bus, piix3_devfn + 1, - xen_enabled() ? "piix3-ide-xen" : "piix3-ide"); + dev = pci_create_simple(pci_bus, piix3_devfn + 1, "piix3-ide"); pci_ide_create_devs(dev); idebus[0] = qdev_get_child_bus(&dev->qdev, "ide.0"); idebus[1] = qdev_get_child_bus(&dev->qdev, "ide.1"); diff --git a/hw/ide/piix.c b/hw/ide/piix.c index ce89fd0aa3..2345fe9e1d 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -241,12 +241,6 @@ static const TypeInfo piix3_ide_info = { .class_init = piix3_ide_class_init, }; -static const TypeInfo piix3_ide_xen_info = { - .name = "piix3-ide-xen", - .parent = TYPE_PCI_IDE, - .class_init = piix3_ide_class_init, -}; - /* NOTE: for the PIIX4, the IRQs and IOports are hardcoded */ static void piix4_ide_class_init(ObjectClass *klass, void *data) { @@ -272,7 +266,6 @@ static const TypeInfo piix4_ide_info = { static void piix_ide_register_types(void) { type_register_static(&piix3_ide_info); - type_register_static(&piix3_ide_xen_info); type_register_static(&piix4_ide_info); } -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 18:10:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 18:10:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328678.551777 (Exim 4.92) (envelope-from ) id 1npZjw-0006GB-6H; Fri, 13 May 2022 18:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328678.551777; Fri, 13 May 2022 18:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZjw-0006FN-2B; Fri, 13 May 2022 18:10:12 +0000 Received: by outflank-mailman (input) for mailman id 328678; Fri, 13 May 2022 18:10:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZju-0005kx-Ga for xen-devel@lists.xenproject.org; Fri, 13 May 2022 18:10:10 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ecdeada5-d2e7-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 20:10:09 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id bv19so17737346ejb.6 for ; Fri, 13 May 2022 11:10:09 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-014-181-123.89.14.pool.telefonica.de. [89.14.181.123]) by smtp.gmail.com with ESMTPSA id e11-20020a170906648b00b006fa84a0af2asm1040008ejm.16.2022.05.13.11.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:10:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecdeada5-d2e7-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hp6j9E0komHwkQmjVaaJwGXlUmBw15qUD+2uycCxKRo=; b=F6ECj1KowlkuN7ndNLG4RXVONt3ugmk+q9Hi/xtsP3eiZ8ZL0nuSrxMOKrM5piAaMn oZVcacYQpx5jhTeQ451SnkGgZgcC+2FArUYvOOba7IXnLkpiLCmSjrJfH4140JrGfdaA DDKaBGot+x4QfZLJkUdcSRyMZy0355YA3JjyVQvKWKDVe9Oc+c0902kRxqJK47A9Owbz Wo23wbWOu/V3dS/MJkCO1+CxAj1a90WzQguDmjmui18vahU9ZuOVJyd1wrOW8CmmC5TW z1SN7HYd8RGG1I4E7qL0Om7lIq4IW5FH2ooK04osvFfWLUC7kJYdyWSiUU5whYG7aJw1 CYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hp6j9E0komHwkQmjVaaJwGXlUmBw15qUD+2uycCxKRo=; b=lWmjbLbtcbbxGsdl9GhC27MTosBekpPrlKM2Wsujhej/Dw2vWgz1EziYR7t8zMwKNN mG9VRupgkFl64VdqHYk4ma9PDmG6SmCntzAXOvQwU/UTHT5DoATPvcj50Vllft7zBDyp Jn7y3ifVZFpxN3YmbX9eyYxRTzHgVqN5mpT9vWS1X+6B0KwZEKZcXlA01atNO4+TCNbZ QX/tlIQm0uPxQKQWmEowHRCtTUtqA1VPJh7DzLxClQMrHXj5unjHzNz0EQrulw38Cv87 d4DF84Fw5s1pADpC6cdElFvrwwZAz7DPebbXJyx3kAr5TT/cdJd8YYJfahglH6XmLkPJ /s0g== X-Gm-Message-State: AOAM530JZ5pE9FyDPKd0PHQ9Dnx6V6VsQiTGhp5+avfKk7VoSok5EziA bCfdukTidbKnFsy/K2jPDzc= X-Google-Smtp-Source: ABdhPJwgEkBcZJqTIki5Kg8REFF/cfX7eSZw1juY5Lx09Lc2VuiwHYjI+5INyzSwkKmlGUFfLJt8Rw== X-Received: by 2002:a17:906:4fd5:b0:6f8:5784:fddb with SMTP id i21-20020a1709064fd500b006f85784fddbmr5572529ejw.161.1652465409259; Fri, 13 May 2022 11:10:09 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org, Bernhard Beschow , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH v2 2/3] hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() Date: Fri, 13 May 2022 20:09:56 +0200 Message-Id: <20220513180957.90514-3-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220513180957.90514-1-shentey@gmail.com> References: <20220513180957.90514-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The comment is based on commit message ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk unplug option'. Since it seems to describe design decisions and limitations that still apply it seems worth having. Signed-off-by: Bernhard Beschow --- hw/ide/piix.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 2345fe9e1d..bc1b37512a 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -173,6 +173,17 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) } } +/* + * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to + * request unplug of 'aux' disks (which is stated to mean all IDE disks, + * except the primary master). + * + * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks + * is simultaneously requested is not clear. The implementation assumes + * that an 'all' request overrides an 'aux' request. + * + * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc + */ int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) { PCIIDEState *pci_ide; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 18:10:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 18:10:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328676.551755 (Exim 4.92) (envelope-from ) id 1npZju-0005lJ-Lx; Fri, 13 May 2022 18:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328676.551755; Fri, 13 May 2022 18:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZju-0005lC-J0; Fri, 13 May 2022 18:10:10 +0000 Received: by outflank-mailman (input) for mailman id 328676; Fri, 13 May 2022 18:10:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npZjt-0005kx-Cb for xen-devel@lists.xenproject.org; Fri, 13 May 2022 18:10:09 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebb2818a-d2e7-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 20:10:07 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id j6so17685722ejc.13 for ; Fri, 13 May 2022 11:10:07 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-014-181-123.89.14.pool.telefonica.de. [89.14.181.123]) by smtp.gmail.com with ESMTPSA id e11-20020a170906648b00b006fa84a0af2asm1040008ejm.16.2022.05.13.11.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 11:10:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebb2818a-d2e7-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B+mnGzoN8dF8kZBDeMa+h7r+FYrqSgMHMidhuCTWTwI=; b=KQyMk8bzCjy0W1OsgrA0q4WybcDGmASfNSaP4NhbF5LFNZ0A2hOdi8gP/DomS8+9dO LOtlncXxSgCWY/yVRwqKmITN6LDQQHN4lDTe2BEwVzeS2Bo5DqdyfggEHTGDOKhnxoDx UWWqWoAaGdd0Hf+R50zigPdk255eeYJeETMTLpLprPojkA6nTPQhppqWkLirQ9mOECCu JnNA3pumn8jQ+zzVk9jEQpA6aMwE58GROOErTICDOHsi8QdTug0tQuTRamAQPOpwhE3t 9YagHd8XqrwxN4bQN02sWW9uOU4i/zG/Yhv2qINbJzmYkJj9N/00IYn/RQrsgbng6wsn jc7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B+mnGzoN8dF8kZBDeMa+h7r+FYrqSgMHMidhuCTWTwI=; b=d/1hIXj9INurgaTtA63D9FAWRBSjyomDzTlMnrpvHRNHtEOVKzhn4cfe23M/TdRVdT dGF/WIH/Gyi0m8MxsW49wbJ41cW2a/p6kSizEI58RabBf87WD+UYmdx5nvNYFVicD9Qf QP6RvTQ2m4i9kh4pdsufZUopnHlA73sY6fh9Lz0XylRk8NLtTVk9vcedwEkX2P7eSRo8 YY3y7rBIoWfK2PLdxbkKbtccpr8IIJHwNeJ8AbU7cDGFQlwDRL5CMTwHpqkrf7pfqxH1 fXYPvZ9Yyxh65NvIvo0I6v3iGrjredXq8mobDh3WrfEylf1XmrDrhh6VmUrKBBSG3f5K MkjQ== X-Gm-Message-State: AOAM530rXW0eCQ1/dqF+wkNzUA8jXxokMFQphP7msYW0mYggxe9/DgZ3 95vUlVppih/JW0Yiyjr00Bk= X-Google-Smtp-Source: ABdhPJxLNDiGt6mu8g/iIcRbxj5+FP6Ssv6g2I5vuL2XAJ6cqEhKgpSgehK74/8lZ6EnnQbrcXlRVA== X-Received: by 2002:a17:907:1b19:b0:6f0:1022:1430 with SMTP id mp25-20020a1709071b1900b006f010221430mr5361497ejc.13.1652465407328; Fri, 13 May 2022 11:10:07 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org, Bernhard Beschow Subject: [PATCH v2 0/3] PIIX3-IDE XEN cleanup Date: Fri, 13 May 2022 20:09:54 +0200 Message-Id: <20220513180957.90514-1-shentey@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit v2: * Have pci_xen_ide_unplug() return void (Paul Durrant) * CC Xen maintainers (Michael S. Tsirkin) v1: This patch series first removes the redundant "piix3-ide-xen" device class and then moves a XEN-specific helper function from PIIX3 code to XEN code. The idea is to decouple PIIX3-IDE and XEN and to compile XEN-specific bits only if XEN support is enabled. Testing done: 'qemu-system-x86_64 -M pc -m 1G -cdrom archlinux-2022.05.01-x86_64.iso" boots successfully and a 'poweroff' inside the VM also shuts it down correctly. XEN mode wasn't tested for the time being since its setup procedure seems quite sophisticated. Please let me know in case this is an obstacle. Bernhard Beschow (3): hw/ide/piix: Remove redundant "piix3-ide-xen" device class hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() include/hw/ide: Unexport pci_piix3_xen_ide_unplug() hw/i386/pc_piix.c | 3 +-- hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++- hw/ide/piix.c | 42 --------------------------------- include/hw/ide.h | 3 --- 4 files changed, 48 insertions(+), 48 deletions(-) -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 19:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 19:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328705.551799 (Exim 4.92) (envelope-from ) id 1npaaH-0004OS-OV; Fri, 13 May 2022 19:04:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328705.551799; Fri, 13 May 2022 19:04:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaaH-0004OL-KB; Fri, 13 May 2022 19:04:17 +0000 Received: by outflank-mailman (input) for mailman id 328705; Fri, 13 May 2022 19:04:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaaG-0004OB-VL; Fri, 13 May 2022 19:04:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaaG-0007KK-Ow; Fri, 13 May 2022 19:04:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaaG-0004Ff-Cx; Fri, 13 May 2022 19:04:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npaaG-0006Ps-CU; Fri, 13 May 2022 19:04:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NmoTx1BRxujlHh8UvG6IRNHYvTw7qi77hbnhLaOI6fY=; b=Jab3PqQ6yOi7b9fXkz6d4H7qCA wfF+xAfITPOGaS6MIdPUuD7b9fWBa2hUc0bdSw85pzBtA6KGWHZEAUaeOwbQg5hACtdP8YI0LK+kO Hm2gCm/MQpS5I3urknFKP5AdrkVlf9SW9mlvshU/oTT1ufM0CI6KB83ZCK6MIxMsytZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170399: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 19:04:16 +0000 flight 170399 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170399/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 986 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 19:08:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 19:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328714.551810 (Exim 4.92) (envelope-from ) id 1npaeY-000529-Ax; Fri, 13 May 2022 19:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328714.551810; Fri, 13 May 2022 19:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaeY-000522-6U; Fri, 13 May 2022 19:08:42 +0000 Received: by outflank-mailman (input) for mailman id 328714; Fri, 13 May 2022 19:08:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaeX-00051w-48 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 19:08:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npaeW-0007PP-NM; Fri, 13 May 2022 19:08:40 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.8.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npaeW-0003PX-GB; Fri, 13 May 2022 19:08:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KRvdFx+56ki4UiDRETogg2OiT5rQP+VKEI7RLMa58kE=; b=mvmCGSxCAsYE4B6e6mnBukQm3t W1/3PwD32KhR8acz8OwY/Nm2rDvLwjiqKkDxPk/NU/ZbeMewcmfEC5Jl2Ua7y9dhVglZSlNRr5/M5 T0bpday+dvr0gFORgn/mBdRtc179aiqOHQD9jf7I8+Cv98tKLAngbQ3IhUXcWpfs/N5Q=; Message-ID: <27c7c9cb-af5a-22fa-80b8-a2fe383412bf@xen.org> Date: Fri, 13 May 2022 20:08:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 05/36] xen/arm: compute LLC way size by hardware inspection To: Carlo Nonato , Marco Solieri , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Marco Solieri , Andrea Bastoni , Luca Miccio , Stefano Stabellini References: <20220304174701.1453977-1-marco.solieri@minervasys.tech> <20220304174701.1453977-6-marco.solieri@minervasys.tech> <0509b0eb-0f3b-8a26-4202-0011201c3fac@xen.org> <9b10c3d3-05d4-c08b-efd6-2cb106f58dea@minervasys.tech> From: Julien Grall In-Reply-To: <9b10c3d3-05d4-c08b-efd6-2cb106f58dea@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/05/2022 15:34, Carlo Nonato wrote: > Hi Julien Hi, > On 09/03/22 21:12, Julien Grall wrote: >>> + >>> + >>> +/* Return the way size of last level cache by asking the hardware */ >>> +static uint64_t get_llc_way_size(void) >> >> This will break compilation as you are introducing get_llc_way_size() >> but not using it. >> >> I would suggest to fold this patch in the next one. >> >>> +{ >>> +    uint32_t cache_sel = READ_SYSREG64(CSSELR_EL1); >> >> The return type for READ_SYSREG64() is uint64_t. That said, the >> equivalent register on 32bit is CSSELR which is 32-bit. So this should >> be READ_SYSREG() and the matching type is register_t. > Since we don't want to support arm32, should I stick with > READ_SYSREG64() or switch to the generic one you > pointed me out? If this code is meant to only work on 64-bit, then I would prefer if we use READ_SYSREG() and register_t (see more below about READ_SYSREG64 vs READ_SYSREG()). >>> +    uint32_t cache_global_info = READ_SYSREG64(CLIDR_EL1); >> >> Same remark here. Except the matching register is CLIDR. >> >>> +    uint32_t cache_info; >>> +    uint32_t cache_line_size; >>> +    uint32_t cache_set_num; >>> +    uint32_t cache_sel_tmp; >>> + >>> +    printk(XENLOG_INFO "Get information on LLC\n"); >>> +    printk(XENLOG_INFO "Cache CLIDR_EL1: 0x%"PRIx32"\n", >>> cache_global_info); >>> + >>> +    /* Check if at least L2 is implemented */ >>> +    if ( ((cache_global_info >> CTR_LOC_SHIFT) & CTR_LOC_MASK) >> >> This is a bit confusing. cache_global_info is storing CLIDR_* but you >> are using macro starting with CTR_*. >> >> Did you intend to name the macros CLIDR_*? >> >> The same remark goes for the other use of CTR_ below. The name of the >> macros should match the register they are meant to be used on. > You are right for the naming mistakes. Should I add those defines in > some specific file or > can they stay here? I would define them in arch/arm/include/asm/processor.h where we already define all the mask for system registers. >>> +        == CTR_LOC_NOT_IMPLEMENTED ) >> >> I am a bit confused this the check here. Shouln't you check that >> Ctype2 is notn 0 instead? > I should check a little bit better how this automatic probing thing > actually works > and we also have to clarify better what is the LLC for us, so that I > know what we > should really test for in this function. Probably you're right though. >>> +    { >>> +        printk(XENLOG_ERR "ERROR: L2 Cache not implemented\n"); >>> +        return 0; >>> +    } >>> + >>> +    /* Save old value of CSSELR_EL1 */ >>> +    cache_sel_tmp = cache_sel; >>> + >>> +    /* Get LLC index */ >>> +    if ( ((cache_global_info >> CTR_CTYPE2_SHIFT) & CTR_CTYPEn_MASK) >>> +        == CTR_LLC_ON ) >> >> I don't understand this check. You define CTR_LLC_ON to 1 << 2. So it >> would be 0b10. From the field you checked, this value mean "Data Cache >> Only". How is this indicating the which level to chose? >> >> But then in patch #4 you wrote we will do cache coloring on L2. So why >> are we selecting L3? > 1 << 2 is actually 0b100 which stands for "Unified cache". Oh yes. Sorry, I miscalculated the field. > Still I don't > know if this is > the best way to test what we want. Would you be able to explain what you want to test? >>> +        cache_sel = CTR_SELECT_L2; >>> +    else >>> +        cache_sel = CTR_SELECT_L3; >>> + >>> +    printk(XENLOG_INFO "LLC selection: %u\n", cache_sel); >>> +    /* Select the correct LLC in CSSELR_EL1 */ >>> +    WRITE_SYSREG64(cache_sel, CSSELR_EL1); >> >> This should be WRITE_SYSREG(). >> >>> + >>> +    /* Ensure write */ >>> +    isb(); >>> + >>> +    /* Get info about the LLC */ >>> +    cache_info = READ_SYSREG64(CCSIDR_EL1); >>> + >>> +    /* ARM TRM: (Log2(Number of bytes in cache line)) - 4. */ >> >> From my understanding "TRM" in the Arm world refers to a specific >> processor. In this case we want to quote the spec. So we usually say >> "Arm Arm". >> >>> +    cache_line_size = 1 << ((cache_info & CTR_LINESIZE_MASK) + 4); >>> +    /* ARM TRM: (Number of sets in cache) - 1 */ >>> +    cache_set_num = ((cache_info >> CTR_SIZE_SHIFT) & CTR_SIZE_MASK) >>> + 1; >> >> The shifts here are assuming that FEAT_CCIDX is not implemented. I >> would be OK if we decide to not support cache coloring on such >> platform. However, we need to return an error if a user tries to use >> cache coloring on such platform. >> > In my understanding, if FEAT_CCIDX is implemented then CCSIDR_EL1 is a > 64-bit register. Technically all the system registers on arm64 are 64-bit registers. That said, earlier version of the Arm Arm suggested that some where 32-bit when in fact the top bits were RES0. In Xen, we should try to use register_t and READ_SYSREG() when using system register so we don't end up to mask the top by mistake (a future revision of the spec may define them). If the co-processor register is also 64-bit on 32-bit, then we should use register_t and READ_SYSREG64(). > So it's just a matter of probing for FEAT_CCIDX and in that case > changing the way we access > that register (since the layout changes too). Yes. I will review it if you want to implement it. But I am equally fine if you just want to add a check and return an error if FEAT_CCIDX is implemented. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 13 19:49:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 19:49:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328721.551821 (Exim 4.92) (envelope-from ) id 1npbHQ-0000p3-Br; Fri, 13 May 2022 19:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328721.551821; Fri, 13 May 2022 19:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbHQ-0000ow-97; Fri, 13 May 2022 19:48:52 +0000 Received: by outflank-mailman (input) for mailman id 328721; Fri, 13 May 2022 19:48:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbHO-0000oq-E5 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 19:48:50 +0000 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [2607:f8b0:4864:20::112e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b462504d-d2f5-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 21:48:48 +0200 (CEST) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-2ebf4b91212so100854967b3.8 for ; Fri, 13 May 2022 12:48:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b462504d-d2f5-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+8spOjZA4NY0YGn23DOFXT8YympyMRk58+kwRnpI6rA=; b=RSDCo5w1kBotXYyiggcXdJdDa5BWoMq/e/5Nv3Q0Z0gHdeQfOuZkBpTTWOf+YmMLhG 6ThmeiYGTu6PF/+3kGtZDGfxOYvL03VRXOCwwz6u6LsallJHKZc0Y09+WYv2TEPHFDtS EgA39gMQJVOjH0SioN2vAOBG7IVApKo8F3R6lAiQ67kzynlZWmisFu+idKhkTlhWHSI0 hIXHnSgx5EgiYcpKmTWHKEC2VXMGeIARS1h+kYD+hRS/PYKLmCw6CElttjro+10UasKf T1AoQ/pcPy4keWja2XtOtQtMaBeHVQLiMWpOkQwnnSJb2CRfgVUhQyuwzmp0AmAjvNDD BAIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+8spOjZA4NY0YGn23DOFXT8YympyMRk58+kwRnpI6rA=; b=1Vj2V2sh/1IGLeyA4YnaFsqc01TM2+gPNmKLcOaL6P2JpPa/g2fTjn0pZN5RRS99CD H38EYgWuVG3UI1fmiJi3+M/Qv+uBoPQXpT2ofXyICLutlIytchgWc0HpfMgenv7404JX sReU3u0YWYe3bvhsLQ1Z8K8XnEDdF26PRaxaFNzMNroCyIqtjxZMYQMxM1TOHaL3Q+FZ 9vTaT8hvJLtsMtv7AjHdNDTHBuPUpNCHHGO1fYtj9iTn5/YlkVxl2uxQsixcR58WfB71 qJU3PtqV80iZIZTjp1ZuZfk9hFOHAD9rJtmOrDMS5YcPz+9RhLy0t/aBuHfUwD+q39Cq qD6g== X-Gm-Message-State: AOAM53081+8dTiPuWHjYFmmiSxEZbrmE33hQYOHzArYInFlK94wP84ZC 8afM10C+Sjc6wqgrpNBtoPX02ov3Kex1jMvdk6U= X-Google-Smtp-Source: ABdhPJyou25gEAV0ud5WxO6bkP84FteocSKtoESAitv8VDqKphBPHi/1BxPpk02OZgFijl1ODxEXEL/fT7MVaLpOaww= X-Received: by 2002:a81:6a41:0:b0:2f8:5459:353e with SMTP id f62-20020a816a41000000b002f85459353emr7886565ywc.218.1652471327188; Fri, 13 May 2022 12:48:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Colton Reeder Date: Fri, 13 May 2022 12:49:31 -0700 Message-ID: Subject: Re: OPNSense running in domU has no network connectivity on 5.15.29+ To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel@lists.xenproject.org, Juergen Gross , Anthony PERARD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://pastebin.com/uqME2J8W Theres the configuration from both VMs. You are correct, Ive never had any issues with the Linux PV guest "Services= " I will work on getting the other information you requested as soon as I can= . On Tue, May 10, 2022 at 4:18 AM Roger Pau Monn=C3=A9 = wrote: > > On Tue, May 03, 2022 at 12:36:43PM -0700, Colton Reeder wrote: > > Hello, > > > > I am running the FreeBSD-based router OS OPNSense in a domU. I > > recently upgraded my dom0 kernel from 5.15.26 to 5.15.32 and with the > > new kernel, OPNSense had no connectivity. I downloaded from kernel.org > > 5.15.26-32, built and installed each version and booted them > > consecutively until I found the version that no longer worked. It > > turned out to be 5.15.29. > > > > I looked through the change log of 5.15.29 and found two commits for xe= n-netback > > > > commit 2708ceb4e5cc84ef179bad25a2d7890573ef78be commit > > fe39ab30dcc204e321c2670cc1cf55904af35d01 > > > > I reverted these changes (a revert of a revert, yes) in 5.15.32, > > built and installed. Now the network works. Now I dont know enough to > > know thats for sure the right fix. > > Could you try if reverting only one of those fixes your issue? > > > Maybe I have a config issue, I dont > > know, but reverting that change fixes the problem. What should I do? > > I was asked to provide xenstore -ls https://pastebin.com/hHPWgrEy > > It's better to post the output of `xenstore-ls -fp`, as that's way > easier to read. > > So it's only OPNSense that's affected, other VMs run fine? > > Do you get any output from Linux dmesg? > > From the output of xenstore that you pasted, you do have another > guests that seems to be running fine regarding network, are there any > differences in the configuration file? > > FWIW, it seems like the netback instances are stuck in state 2. > > I think we need the guest config file, plus the output from `xl > -vvv create config_file.cfg` > > Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 13 20:14:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:14:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328728.551832 (Exim 4.92) (envelope-from ) id 1npbgT-0004Cx-Jv; Fri, 13 May 2022 20:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328728.551832; Fri, 13 May 2022 20:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbgT-0004Cq-GU; Fri, 13 May 2022 20:14:45 +0000 Received: by outflank-mailman (input) for mailman id 328728; Fri, 13 May 2022 20:14:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbgS-0004Cg-Mw; Fri, 13 May 2022 20:14:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbgS-0000LD-Ih; Fri, 13 May 2022 20:14:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbgS-0000vT-3o; Fri, 13 May 2022 20:14:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npbgS-0001zh-2M; Fri, 13 May 2022 20:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bJO08fNIouklLaLG8G4DgCAHIrYYAR4phr5twcJfVcA=; b=MFp5NF6tweCwlDEpz8UqrpavZz 4RzDSVpnfXw7VFAjhFP6mBkUbQfLXTsZjVvDX+AOAkT8eWGhqrkmYL7JoWoKtQsseibWuuGqM/sWk 2we3qFmxXUNPuo37kJqCXVN0DL5+r68INaiiRAspZpBpdFj6N5XsJoTj8Yh76WJpfZ4I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170385: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-coresched-i386-xl:debian-fixup:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Fri, 13 May 2022 20:14:44 +0000 flight 170385 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170385/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 170370 pass in 170385 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 170370 pass in 170385 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 170370 pass in 170385 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 170370 test-amd64-coresched-i386-xl 13 debian-fixup fail pass in 170370 Tests which did not succeed, but are not blocking: test-amd64-i386-migrupgrade 10 xen-install/src_host fail like 170370 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170370 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170370 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170370 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170370 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170370 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170370 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170370 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170370 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170370 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170370 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170370 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170370 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170385 2022-05-13 08:23:49 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 13 20:15:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:15:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328736.551843 (Exim 4.92) (envelope-from ) id 1npbh6-0004h7-To; Fri, 13 May 2022 20:15:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328736.551843; Fri, 13 May 2022 20:15:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbh6-0004h0-Qa; Fri, 13 May 2022 20:15:24 +0000 Received: by outflank-mailman (input) for mailman id 328736; Fri, 13 May 2022 20:15:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npbh5-0004Xg-EN for xen-devel@lists.xenproject.org; Fri, 13 May 2022 20:15:23 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69b878dc-d2f9-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 22:15:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 42F9ECE331C; Fri, 13 May 2022 20:15:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E86C34100; Fri, 13 May 2022 20:15:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69b878dc-d2f9-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652472917; bh=f1j7cRvxmL94XaapZHsZZHRdtmgKggG/sdVKX2TsjPk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kxEvOdMBJgN+k4n22CoQ6kgX3ayKOaRu2D6OR/jylKOSB7JIaZTFVElPPM2CptOiE 97EgwPM2ZhdbJL+zOqgpuOAYCZh+BQzwMX6SaWkDtiMJkp43P302Xi5QGzQVmjpuB+ 5r8DN81/Zjg7MkFHrgZSQEZS1i6Tz1crIMY9gU4EEsPJ44PRDjI1Vp0l4IEAEMC1cb E6Fr3tN/gDxhM+JhszRkGK/6O6JX/etQq/jXWFc53b878UlBSGoNc93MzLqvxGB3nd Xcs750rq8G4uCyBuzzP4i7MJk47Bcs5+x7ErMiLFcnwXCFVI3qoMCN3QdEdOvrpJD0 SqeZxOZZ7MBQQ== Date: Fri, 13 May 2022 13:15:16 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: George Dunlap , Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini , xen-devel , Roger Pau Monne Subject: Re: Process for cherry-picking patches from other projects In-Reply-To: <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> Message-ID: References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-862716976-1652472917=:3842" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-862716976-1652472917=:3842 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 13 May 2022, Juergen Gross wrote: > On 13.05.22 16:33, George Dunlap wrote: > > Starting a new thread to make it clear that we’re discussing a wider policy > > here. > > > > This question is aimed at Jan and Andy in particular, as I think they’ve > > probably done the most of this; so I’m looking to them to find out what our > > “standard practice” is. > > > > There have recently been some patches that Bertrand has submitted which pull > > in code from Linux ("[PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with > > Linux 5.18-rc3”), which has caused a discussion between him, Julien, and > > Stefano about the proper way to do such patches. > > > > The “Origin:” tag section of xen.git/docs/process/sending-patches.pandoc > > suggests that there are some standards, but doesn’t spell them out. > > > > The questions seem to be: > > > > 1) When doing this kind of update, is it permissible to send a single patch > > which “batches” several upstream commits together, or should each patch be > > backported individually? > > > > 2) If “batches” are permissible, when? When would individual patches be > > preferred? > > > > 3) For “batch updates”, what tags are necessary? Do we need to note the > > changesets of all the commits, and if so, do we need multiple “Origin” tags? > > Do we need to include anything from the original commits — commit messages? > > Signed-off-by’s? > > > > And a related question: > > > > 4) When importing an entire file from an upstream like Linux, what tags do > > we need? > > > > My recollection is that we often to a “accumulated patch” to update, say, > > the Kconfig tooling; so it seems like the answer to this is sometimes “yes”. > > > > It seems to me that in a case where you’re importing a handful of patches — > > say 5-10 — that importing them one-by-one might be preferred; but in this > > case, since the submission was already made as a batch, I’d accept having it > > as a batch. > > > > I think if I were writing this patch, I’d make a separate “Origin” tag for > > each commit. > > > > I wouldn’t include the upstream commit messages or S-o-b’s; I would write my > > own commit message summarizing why I’m importing the commits, then have the > > ‘origin’ tags, then my own S-o-b to indicate that I am attesting that it > > comes from an open-source project (and for whatever copyright can be > > asserted on the commit message and the patch as a collection). > > > > And for #4, I would do something similar: I would write my own commit > > message describing what the file is for and why we’re importing it; have the > > Origin tag point to the commit at the point I took the file; and my own > > S-o-b. > > IMO we should add another tag for that purpose, e.g.: > > File-origin: [# ] > > Specifying the repository the file(s) are coming from, the tag (e.g. a > tagged version, or the top git commit), and the path of the original > file(s) in that repository ( could either be a common directory > of multiple files, or a single file; multiple "File-origin:" tags should > be possible). In case the file is being renamed locally, its new name > can be added as . +1 > This variant should be used to add _new_ files to Xen. In case of > updating a file which has seem lots of commits since its last update or > introduction, it might be easier to just use the "File-origin:" tag, > probably with a note below the "---" marker that listing more than > patches (x > 10?) or splitting into more than patches would be > just useless work (common sense should apply here, especially regarding > the readability of the patch and the related review effort). +1 --8323329-862716976-1652472917=:3842-- From xen-devel-bounces@lists.xenproject.org Fri May 13 20:36:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328744.551854 (Exim 4.92) (envelope-from ) id 1npc1M-0007Ux-Mi; Fri, 13 May 2022 20:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328744.551854; Fri, 13 May 2022 20:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npc1M-0007Uq-Ii; Fri, 13 May 2022 20:36:20 +0000 Received: by outflank-mailman (input) for mailman id 328744; Fri, 13 May 2022 20:36:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npc1L-0007Uj-3F for xen-devel@lists.xenproject.org; Fri, 13 May 2022 20:36:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55da46e7-d2fc-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 22:36:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BAE1F622E3; Fri, 13 May 2022 20:36:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3431C34113; Fri, 13 May 2022 20:36:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55da46e7-d2fc-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652474174; bh=w4A332u3lgN6DwrS8dVt5IAs1YSdOMUooN/y4WSioiQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=p1eyJTJGCl60oH+hDVAVMc+BUHkyuXt3SlMYKAYgmxwJZ68C1o2hVMuIDetHQN3MB zwkLQI7QLk0CUsFx5mMZgVi/tRzIm2+hQV52tUeNgYNp7e+Ax//ULeLin3saFiHGYn C6QQdGUycmscG73HXWGWnCkEs2PbjcTDHCRaK8bKigQrZ+RATi6LDq0zyRLX67A4cp TLrMNuXiBKSWZhA6RgQfZoZyJQW3rh9069j6YcsxVTzf0cPyI/rYjlv3agkoP9FYZN AmHTdo5mS6Egn8rfJO2YdHdVWFiqd+gMPhQ7m+AiEWYyGWyI0oSd1NDRw95uTQrYMT MKGxMMl0tzKCA== Date: Fri, 13 May 2022 13:36:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: Re: [PATCH v6 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <990efb92-e3b7-9487-2039-cf93ea1011af@xen.org> Message-ID: References: <20220505001656.395419-6-sstabellini@kernel.org> <990efb92-e3b7-9487-2039-cf93ea1011af@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 13 May 2022, Julien Grall wrote: > On 13/05/2022 02:09, Stefano Stabellini wrote: > > On Wed, 11 May 2022, Julien Grall wrote: > > > > + rc = xs_introduce_domain(xsh, info->domid, > > > > + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, > > > > + xenstore_evtchn); > > > > > > I might be missing something here. In an ealier version, I pointed out > > > that > > > xs_introduce_domain() would fail in the case the dom0less domain doesn't > > > have > > > "xen,enhanced". > > > > > > AFAICT, you agreed that the (part?) of initialization should be skipped. > > > But I > > > don't see the change in the code. Regarding the placement, we could either > > > fully skip init_domain() or just xs_introduce_domain(). The latter might > > > be > > > better so all the domains are listed using xenstore-ls. > > > > > > So something like below should work: > > > > > > if ( xenstore_evtchn ) > > > { > > > rc = xs_introduce...(); > > > ... > > > } > > > > Yes, good point. xenstore_evtchn could be zero validly (first evtchn is > > zero), > > Event channel 0 is always reserved when initialization the event channel > subsystem (evtchn_init()): > > evtchn_from_port(d, 0)->state = ECS_RESERVED; > > > so instead I'll check on xenstore_pfn to be zero (xenstore_pfn is > > 0 for non-enhanced domUs.) > > I spotted that difference but decided to not comment on it as Linux is already > considering the values 0 and ~0 as invalid. However, I am not in favor on any > code to rely on 0 means Xenstore will never be available while ~0 means that > it might be available. > > Anyway, as I wrote above, the event channel 0 is always reserved. So you can > safely use this value to detect whether we allocated the event channel for > Xenstore. Thanks I didn't know that. In that case, using xenstore_evtchn is better, I'll do that. From xen-devel-bounces@lists.xenproject.org Fri May 13 20:42:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:42:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328752.551864 (Exim 4.92) (envelope-from ) id 1npc7e-0000ZW-HR; Fri, 13 May 2022 20:42:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328752.551864; Fri, 13 May 2022 20:42:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npc7e-0000ZP-Eb; Fri, 13 May 2022 20:42:50 +0000 Received: by outflank-mailman (input) for mailman id 328752; Fri, 13 May 2022 20:42:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npc7c-0000ZI-Mn for xen-devel@lists.xenproject.org; Fri, 13 May 2022 20:42:48 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f595f05-d2fd-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 22:42:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C95AAB831D4; Fri, 13 May 2022 20:42:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 250C7C34100; Fri, 13 May 2022 20:42:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f595f05-d2fd-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652474565; bh=8A07oBnxdkNkuXVyFVnrGizVDvsVydf0G+nR6brgT5c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=opVQZCDCSSCMSHwVKISN7oItOQa0yGdULhgfWJKjt8/8huksOrDjrAK65XRfTb8xX t0FNW2LvfPEtZzqMgOuuQMeAzMCr/D+btpPUCOO54cDqjzCDz73XVXnIYlt9mr/om8 YyanIusVMoxEQyW9BLJMQbUelxmC/QyOaNutSeQOH/Y/koTHY6+Rl3twTe9e49eu4i /AMmpUy4iG4G7U9IALzer813qyUCcdDAQRD7gCv8l13TLF4YiQON7DDvypibpi37F8 LSNYKye77bTJ+NjogciQVGboYXOnxnuwWSYKoWH1r+rFobyj4wEOmrHCwepaDlXMRV 9u5rz9B0GT89w== Date: Fri, 13 May 2022 13:42:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , anthony.perard@citrix.com, wl@xen.org Subject: Re: [PATCH v6 5/7] xenstored: send an evtchn notification on introduce_domain In-Reply-To: <49d77746-1aaf-5fdc-517f-6ffa761474ef@suse.com> Message-ID: References: <20220505001656.395419-5-sstabellini@kernel.org> <0f4ef9bc-4089-6419-5373-13b0abdf5fd3@xen.org> <49d77746-1aaf-5fdc-517f-6ffa761474ef@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 13 May 2022, Juergen Gross wrote: > On 13.05.22 03:16, Stefano Stabellini wrote: > > On Wed, 11 May 2022, Julien Grall wrote: > > > On 05/05/2022 01:16, Stefano Stabellini wrote: > > > > From: Luca Miccio > > > > > > > > When xs_introduce_domain is called, send out a notification on the > > > > xenstore event channel so that any (dom0less) domain waiting for the > > > > xenstore interface to be ready can continue with the initialization. > > > > Before sending the notification, clear XENSTORE_RECONNECTING. > > > > > > > > The extra notification is harmless for domains that don't require it. > > > > > > > > In xs_wire.h update the commment on top of XENSTORE_RECONNECTING to > > > > generalize its meaning to suit the dom0less use-case better. > > > > > > > > Signed-off-by: Luca Miccio > > > > Signed-off-by: Stefano Stabellini > > > > CC: jgross@suse.com > > > > CC: anthony.perard@citrix.com > > > > CC: wl@xen.org > > > > --- > > > > If you have better suggestions for the wording in xs_wire.h please > > > > suggest! > > > > > > > > > > > > Changes in v6: > > > > - use XENSTORE_CONNECTED instead of 0x0 > > > > - update xs_wire.h > > > > > > > > Changes in v5: > > > > - reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU > > > > > > > > Changes in v2: > > > > - drop the new late_init parameter > > > > --- > > > > tools/xenstore/xenstored_domain.c | 4 ++++ > > > > xen/include/public/io/xs_wire.h | 2 +- > > > > > > I am not entirely sure this is the right place to mention it. But I > > > couldn't > > > find a better one. > > > > > > The documentation (docs/misc/xenstore-misc.txt) states that the field is > > > valid > > > when the server advertised ``Connection State``. > > > > > > Is there any guarantee the field will be 0 for any previous {C, > > > O}xenstored > > > implementation? If not, then I think we need to set the feature flag so > > > Linux > > > knows the field can be used. > > > > > > If yes, then the documentation should be relaxed so an OS knows it can > > > safely > > > use the field without checking the feature flag. > > > > The xenstore page is allocated by the toolstack which zeros the page, > > *xenstored wouldn't set it, so I think we can assume the field has > > always been zero. > > > > > > > > diff --git a/xen/include/public/io/xs_wire.h > > > > b/xen/include/public/io/xs_wire.h > > > > index 953a0050a3..c1ec7c73e3 100644 > > > > --- a/xen/include/public/io/xs_wire.h > > > > +++ b/xen/include/public/io/xs_wire.h > > > > @@ -141,7 +141,7 @@ struct xenstore_domain_interface { > > > > /* Valid values for the connection field */ > > > > #define XENSTORE_CONNECTED 0 /* the steady-state */ > > > > -#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ > > > > +#define XENSTORE_RECONNECT 1 /* reconnect in progress */ > > > > > > The definition in the docs needs to be updated. > > > > I wanted to do that but I am very unfamiliar with the xenstore docs. > > Can you point me to the place where I need to change the definition? I > > cannot find where XENSTORE_RECONNECT is defined... > > > > See docs/misc/xenstore-ring.txt Found it, thanks! I'll add: In certain circumstances (e.g. dom0less guests with PV drivers support) it is possible for the guest to find the Connection state already set to 1 by someone else during xenstore initialization. In that case, like in the previous case, the guest must ignore all fields except the Connection state and wait for it to be set to 0 before proceeding. From xen-devel-bounces@lists.xenproject.org Fri May 13 20:45:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:45:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328758.551876 (Exim 4.92) (envelope-from ) id 1npcAG-0001CS-Vn; Fri, 13 May 2022 20:45:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328758.551876; Fri, 13 May 2022 20:45:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcAG-0001CL-SI; Fri, 13 May 2022 20:45:32 +0000 Received: by outflank-mailman (input) for mailman id 328758; Fri, 13 May 2022 20:45:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcAG-0001CB-0V; Fri, 13 May 2022 20:45:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcAF-0000zJ-UR; Fri, 13 May 2022 20:45:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcAF-0002XB-Ih; Fri, 13 May 2022 20:45:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npcAF-0005nW-Hj; Fri, 13 May 2022 20:45:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vmZ2s5+cLHnOyBQAkcKuPw+DXSfGrthtzCVG5mb4RzM=; b=EoSXaRWnROaSnxdfcd4i4ybS+n jCbaWZTm4t11FP4icNJeZurDlU2FfON/SFFhWikX8wBtCrH6gY+/m+QVuX6YDI43Y/0g0APXMpVXC oQJRSH81SRHX6rGOpwaMQA7/6v16XVxczrKlvnfWqH91XNV9mAO+wA287BzwYUKrMxr4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170401: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 20:45:31 +0000 flight 170401 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 987 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 13 20:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 20:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328768.551887 (Exim 4.92) (envelope-from ) id 1npcGp-0002eQ-Nh; Fri, 13 May 2022 20:52:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328768.551887; Fri, 13 May 2022 20:52:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcGp-0002eJ-Jc; Fri, 13 May 2022 20:52:19 +0000 Received: by outflank-mailman (input) for mailman id 328768; Fri, 13 May 2022 20:52:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcGo-0002eD-KQ for xen-devel@lists.xenproject.org; Fri, 13 May 2022 20:52:18 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 91a5242e-d2fe-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 22:52:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A8A862295; Fri, 13 May 2022 20:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E3E5C34100; Fri, 13 May 2022 20:52:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91a5242e-d2fe-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652475133; bh=zRHAu7LCFRODUtcqX4+HFakRv9d7XZ2sb1MkVOe9szM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FSSSve1swaqURhgjCGktQjzyo4oVu/fSGEEvefHowMzoX1Hfxs5lxN3ChTTilj8KF qwYix8kB3XyT+QA8OORQzfFqLx+c2+oXQgzvXNn1QLC94ef6egFREFXPXGoh0hmwmL jF51S84IVUuy7doAfGcQx683jV+/c+gsLpaKPTGAfk5Lj8nRoaokin7k71b/rPuq+E 5eoOMeFPB0h11WX4Fj8QIAZ2cgQcZXNv5KpGtrm3JshdIjEdvbdhKQkYXJPrLaa5jJ U3nC9RjBnETlbGh2TyndnD4Kp4u13xZISUPSktO5XwbTWT3TBWjwalhR8i83ck91RB EU91WvvEbwSAg== Date: Fri, 13 May 2022 13:52:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Bertrand Marquis , Rahul Singh , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot In-Reply-To: <7f89af03-66d2-9c59-a761-4c8a188570d9@xen.org> Message-ID: References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <7f89af03-66d2-9c59-a761-4c8a188570d9@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 13 May 2022, Julien Grall wrote: > On 13/05/2022 02:23, Stefano Stabellini wrote: > > On Wed, 11 May 2022, Julien Grall wrote: > > > > If dom0 is mandatory yes, we should still make sure that this code > > > > cannot be > > > > reached so an ASSERT would be nice here at least in case someone tries > > > > to > > > > activate this code without dom0 (which might happen when we will push > > > > the > > > > serie for static event channels). > > > > > > I am fine with an ASSERT(). > > > > I added an ASSERT(hardware_domain). > > Just to clarify and avoid a round trip. The ASSERT() is not sufficient here. > We also need to forbid the user to set xen,enhanced when the HW domain is not > NULL, at least until Rahul's pre-allocated event channel series. > > This check would have to be done when parsing the configuration. The ASSERT() > would be here to ensure that if someone is reworking the parsing, it would get > caught nicely rather than a NULL dereference. Thanks for avoiding a roundtrip. I added a check when parsing device tree if xen,enhanced is specified but dom0 is missing. Initially I wrote it as a "panic" but then I changed it as a regular printk. I am OK either way in case you prefer otherwise. From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328775.551898 (Exim 4.92) (envelope-from ) id 1npcVQ-0004E6-29; Fri, 13 May 2022 21:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328775.551898; Fri, 13 May 2022 21:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVP-0004Dy-UN; Fri, 13 May 2022 21:07:23 +0000 Received: by outflank-mailman (input) for mailman id 328775; Fri, 13 May 2022 21:07:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVO-0004Ds-Ox for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:22 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adaaebd8-d300-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:07:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54764B8305C; Fri, 13 May 2022 21:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2162C34100; Fri, 13 May 2022 21:07:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adaaebd8-d300-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476039; bh=qfqRjOxBrBzZ9xcoP9s3kxenb6x/9Sib0sXYo5ZEbt8=; h=Date:From:To:cc:Subject:From; b=UWAkujzzO8vewaQtF4ZB2RHPyK/8jobcoPsN4aF5lT3CRqJ72aZWsxnRqI9ffPf6a 7vRoXhdtNluutTiM90a3kksiTYOFa0A+gSZTHZewnMp38Gh3eNlhjK1ucqqtyIWvZW o5Zvx8pHBmPj755URtwqdGY+cUYngigQbmzoLHbXb/sPFKDf0Z6ab70AHK3RXqupys 4KjMCGmhOZx6i0JT0IbXIzJEMbCTg+SUIvMIgLmevx5xk7kqjcc1RVpnhHutl/B7EK +cXHC4+JHnfZQ814vgMB+3E6YcDmIBsDdMf9jwJcoW5p+KeU8F4pi3Bi2xOg73789O 9IaZXlp3cV3JA== Date: Fri, 13 May 2022 14:07:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com Subject: [PATCH v7 0/7] dom0less PV drivers Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, Currently dom0less guests cannot use PV drivers because they don't have access to xenstore. Also, the hypervisor node in device tree is missing so they don't detect that they are running on Xen (thus, they don't try to enable PV interfaces.) This patch series enables dom0less guests (on ARM) to use PV drivers. Instead of initializing xenstore immediately at boot, dom0less guests get access to xenstore later. They delay the initialization until they receive a notification via the xenstore event channel (which is available at boot.) An example workflow is as follows: - all domains start in parallel, dom0less guests are immediately running - when dom0 is up and running, the init-dom0less application is called - dom0less guests receive the notification and initialize xenstore - now xl network-attach/disk-attach works as expected for dom0less domUs The patch series introduces a new dom0less device tree option "xen,enhanced" (in the Xen device tree) to specify whether PV interfaces should be enabled/disabled for the dom0less guest. This patch series is based on Daniel P. Smith's "Adds starting the idle domain privileged". A important change in v5 is the usage of XS_CONNECTION_STATE_RECONNECTING to signal that the xenstore interface is not ready. Cheers, Stefano Luca Miccio (3): xen/arm: configure dom0less domain for enabling xenstore after boot xenstored: send an evtchn notification on introduce_domain tools: add example application to initialize dom0less PV drivers Stefano Stabellini (4): xen/dt: of_property_read_string return -ENODATA when !length xen/arm: implement domU extended regions xen: introduce xen,enhanced dom0less property docs: document dom0less + PV drivers docs/features/dom0less.pandoc | 43 ++++- docs/misc/arm/device-tree/booting.txt | 18 ++ docs/misc/xen-command-line.pandoc | 9 +- docs/misc/xenstore-ring.txt | 8 +- tools/helpers/Makefile | 13 ++ tools/helpers/init-dom0less.c | 345 ++++++++++++++++++++++++++++++++++ tools/xenstore/xenstored_domain.c | 4 + xen/arch/arm/domain_build.c | 110 ++++++++++- xen/arch/arm/include/asm/kernel.h | 3 + xen/common/device_tree.c | 2 +- xen/common/event_channel.c | 2 +- xen/include/public/io/xs_wire.h | 2 +- xen/include/xen/device_tree.h | 3 + xen/include/xen/event.h | 3 + 14 files changed, 545 insertions(+), 20 deletions(-) create mode 100644 tools/helpers/init-dom0less.c From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328776.551909 (Exim 4.92) (envelope-from ) id 1npcVc-0004XF-B1; Fri, 13 May 2022 21:07:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328776.551909; Fri, 13 May 2022 21:07:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVc-0004X8-6z; Fri, 13 May 2022 21:07:36 +0000 Received: by outflank-mailman (input) for mailman id 328776; Fri, 13 May 2022 21:07:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVb-0004Ds-72 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:35 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5b83506-d300-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:07:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04C47B83132; Fri, 13 May 2022 21:07:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5388DC34100; Fri, 13 May 2022 21:07:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5b83506-d300-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476052; bh=xMPekEl/+TKjYbBcl6Wf3vqDYVIUg969PFQ3M8T2yk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C+NhbuYsko/M1WS+4kF+1ImUVlPXAWyNnN6ApEm3pObIcqlTy6k26mfMW2mCd+2rW rBAPK1rmJVWyjlNl93KtRk7tP0aPkD5DYBZ7wt4oOhjQtHmK8ZjD/JzO7hw5uCMV3l 2B2KEdqo5qvCDp8MkJ19Pq3RcqOzmeyzVs5LeMTufojBeZNkCZEiXTVCyzQ1xQ/OHP SxLGP4nH3RI5QM5OFUkmFTNlS8tDwGOaUd2EyO3oLBCLOJKA4G2snjsvoEL4YruDzy Gs+vZKAf+UdsSH6WXGcsfeIFRutVq87DU3roSxZkgZx4FSxNtiYGVYAVOYPLekhzQw O0yy1IiYQ5DsA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Bertrand Marquis , Luca Fancellu Subject: [PATCH v7 1/7] xen/dt: of_property_read_string return -ENODATA when !length Date: Fri, 13 May 2022 14:07:24 -0700 Message-Id: <20220513210730.679871-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini When the length of the string is zero of_property_read_string should return -ENODATA according to the description of the function. However, of_property_read_string doesn't check prop->length. If prop->length is zero, return -ENODATA. Without this patch the following command in u-boot: fdt set /chosen/node property-name results in of_property_read_string returning -EILSEQ when attempting to read property-name. With this patch, it returns -ENODATA as expected. This commit is a backport of: https://lore.kernel.org/xen-devel/20220416003028.1315268-1-sstabellini@kernel.org/ Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Reviewed-by: Luca Fancellu --- Changes in v5: - backport from Linux --- xen/common/device_tree.c | 2 +- xen/include/xen/device_tree.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) --- xen/common/device_tree.c | 2 +- xen/include/xen/device_tree.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..0e8798bd24 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -198,7 +198,7 @@ int dt_property_read_string(const struct dt_device_node *np, if ( !pp ) return -EINVAL; - if ( !pp->value ) + if ( !pp->length ) return -ENODATA; if ( strnlen(pp->value, pp->length) >= pp->length ) return -EILSEQ; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index fd6cd00b43..430a1ef445 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -451,6 +451,9 @@ static inline bool_t dt_property_read_bool(const struct dt_device_node *np, * doest not have value, and -EILSEQ if the string is not * null-terminated with the length of the property data. * + * Note that the empty string "" has length of 1, thus -ENODATA cannot + * be interpreted as an empty string. + * * The out_string pointer is modified only if a valid string can be decoded. */ int dt_property_read_string(const struct dt_device_node *np, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328777.551920 (Exim 4.92) (envelope-from ) id 1npcVd-0004oP-Qf; Fri, 13 May 2022 21:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328777.551920; Fri, 13 May 2022 21:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVd-0004oI-NS; Fri, 13 May 2022 21:07:37 +0000 Received: by outflank-mailman (input) for mailman id 328777; Fri, 13 May 2022 21:07:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVc-0004Ds-86 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5c76f88-d300-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:07:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F35D061B8C; Fri, 13 May 2022 21:07:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E93E9C34113; Fri, 13 May 2022 21:07:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5c76f88-d300-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476053; bh=GuU6qA8FErbNr89RInOmtwTYqYZQ6Wfj7rcBSkqDOLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=joTOzbHXgitRICE7cgCv5LKuhQy8XgxEVzOzpgQByljObJ7UL1PrxkQ1d/GGmJZM3 UuuxhP4TbQa7cR9D+DwzVqd6X+F7GYDXH4CZs/CQFVHpMuVKSfKvMAplr828YgrKPt YSa8DIrV9WiqWPQBcs3R6KAaRp/wvjq1JJjnfwBDFsNj3KjUW1gVny9+Tyn/xG/2s2 t2X0Tn9kIvu3+L9ORb5o0466zbq1DPis+OwjKfm3ish36YGd+O9FbY47Mzu3mScV1g LoS+mS8DfKQvPdzMOdsZ3DDi2WchhQ8q231PMpccAEB4n7PwOFKA3V/e3n/sRhod/l eLJzOfUTyNzIw== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu , Oleksandr Tyshchenko , Julien Grall Subject: [PATCH v7 2/7] xen/arm: implement domU extended regions Date: Fri, 13 May 2022 14:07:25 -0700 Message-Id: <20220513210730.679871-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Implement extended regions for dom0less domUs. The implementation is based on the libxl implementation. Also update docs for the ext_regions command line option. Signed-off-by: Stefano Stabellini Reviewed-by: Luca Fancellu Reviewed-by: Oleksandr Tyshchenko Acked-by: Julien Grall --- Changes in v6: - add reviewed-by - address 2 NITs - update docs Changes in v5: - print the domain - coding style - simplify the code in find_domU_holes - return error if no regions allocated in find_domU_holes - use ROUNDUP - uint64_t/paddr_t --- docs/misc/xen-command-line.pandoc | 9 ++--- xen/arch/arm/domain_build.c | 60 ++++++++++++++++++++++++++----- 2 files changed, 56 insertions(+), 13 deletions(-) --- docs/misc/xen-command-line.pandoc | 9 ++--- xen/arch/arm/domain_build.c | 60 ++++++++++++++++++++++++++----- 2 files changed, 56 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1dc7e1ca07..881fe409ac 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1110,11 +1110,12 @@ to use the default. > Default : `true` -Flag to enable or disable support for extended regions for Dom0. +Flag to enable or disable support for extended regions for Dom0 and +Dom0less DomUs. -Extended regions are ranges of unused address space exposed to Dom0 as -"safe to use" for special memory mappings. Disable if your board device -tree is incomplete. +Extended regions are ranges of unused address space exposed to the guest +as "safe to use" for special memory mappings. Disable if your board +device tree is incomplete. ### flask > `= permissive | enforcing | late | disabled` diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index aa777741bd..c4dd211b91 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -35,7 +35,10 @@ static unsigned int __initdata opt_dom0_max_vcpus; integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); -/* If true, the extended regions support is enabled for dom0 */ +/* + * If true, the extended regions support is enabled for dom0 and + * dom0less domUs. + */ static bool __initdata opt_ext_regions = true; boolean_param("ext_regions", opt_ext_regions); @@ -1327,6 +1330,36 @@ out: return res; } +static int __init find_domU_holes(const struct kernel_info *kinfo, + struct meminfo *ext_regions) +{ + unsigned int i; + paddr_t bankend; + const paddr_t bankbase[] = GUEST_RAM_BANK_BASES; + const paddr_t banksize[] = GUEST_RAM_BANK_SIZES; + int res = -ENOENT; + + for ( i = 0; i < GUEST_RAM_BANKS; i++ ) + { + struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]); + + ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, SZ_2M); + + bankend = ~0ULL >> (64 - p2m_ipa_bits); + bankend = min(bankend, bankbase[i] + banksize[i] - 1); + if ( bankend > ext_bank->start ) + ext_bank->size = bankend - ext_bank->start + 1; + + /* 64MB is the minimum size of an extended region */ + if ( ext_bank->size < MB(64) ) + continue; + ext_regions->nr_banks++; + res = 0; + } + + return res; +} + static int __init make_hypervisor_node(struct domain *d, const struct kernel_info *kinfo, int addrcells, int sizecells) @@ -1363,12 +1396,13 @@ static int __init make_hypervisor_node(struct domain *d, if ( !opt_ext_regions ) { - printk(XENLOG_INFO "The extended regions support is disabled\n"); + printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d); nr_ext_regions = 0; } else if ( is_32bit_domain(d) ) { - printk(XENLOG_WARNING "The extended regions are only supported for 64-bit guest currently\n"); + printk(XENLOG_WARNING + "%pd: extended regions not supported for 32-bit guests\n", d); nr_ext_regions = 0; } else @@ -1377,13 +1411,21 @@ static int __init make_hypervisor_node(struct domain *d, if ( !ext_regions ) return -ENOMEM; - if ( !is_iommu_enabled(d) ) - res = find_unallocated_memory(kinfo, ext_regions); + if ( is_domain_direct_mapped(d) ) + { + if ( !is_iommu_enabled(d) ) + res = find_unallocated_memory(kinfo, ext_regions); + else + res = find_memory_holes(kinfo, ext_regions); + } else - res = find_memory_holes(kinfo, ext_regions); + { + res = find_domU_holes(kinfo, ext_regions); + } if ( res ) - printk(XENLOG_WARNING "Failed to allocate extended regions\n"); + printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n", + d); nr_ext_regions = ext_regions->nr_banks; } @@ -1404,8 +1446,8 @@ static int __init make_hypervisor_node(struct domain *d, u64 start = ext_regions->bank[i].start; u64 size = ext_regions->bank[i].size; - printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", - i, start, start + size); + printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", + d, i, start, start + size); dt_child_set_range(&cells, addrcells, sizecells, start, size); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328778.551925 (Exim 4.92) (envelope-from ) id 1npcVe-0004r1-5J; Fri, 13 May 2022 21:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328778.551925; Fri, 13 May 2022 21:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVe-0004qb-0g; Fri, 13 May 2022 21:07:38 +0000 Received: by outflank-mailman (input) for mailman id 328778; Fri, 13 May 2022 21:07:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVd-0004Ds-76 for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:37 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b65a4bf4-d300-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:07:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 312F0B831E2; Fri, 13 May 2022 21:07:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89E1FC34118; Fri, 13 May 2022 21:07:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b65a4bf4-d300-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476053; bh=sl1hbeFkH4WN0bbZ/wxmpn+D3pl0OgZL21wS4PaGxQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9cPPBtkA/LZhGum/x+AFW+4w3kU9mgs3jshltQa37DYHjVAxTXUuUuZyMpPKVj1z HlqnquIiYyhTOTqjW9rZLoJMsxqOMfxpI1DOoeLORnxLIimFRBLYLYYsNLOc4VVdI2 V4J44zFV3nn52rzXUCsKapO8VfC/Yrbh6b36mYZMnamPOLQZV2S5E99Jxk6mccx9HW pdH0w0GDczTfGemutZzgrZwW7k6kOHqmvyPkpY2zbrrkc75ACOmTx+1sTwBmhvEOZx EQEzAKDJR0CJmWV1RZGFboOxKbV9s1ebNssmTkD90CQXVVeTDMqSYjKlgeVrb3+ydm EEs22t5JoWeVw== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Bertrand Marquis Subject: [PATCH v7 3/7] xen: introduce xen,enhanced dom0less property Date: Fri, 13 May 2022 14:07:26 -0700 Message-Id: <20220513210730.679871-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Introduce a new "xen,enhanced" dom0less property to enable/disable PV driver interfaces for dom0less guests. Currently only "enabled" and "disabled" are supported property values (and empty). Leave the option open to implement further possible values in the future (e.g. "xenstore" to enable only xenstore.) Dom0 presence is required for now to use "xen,enhanced" on a domU. The configurable option is for domUs only. For dom0 we always set the corresponding property in the Xen code to true (PV interfaces enabled.) This patch only parses the property. Next patches will make use of it. Signed-off-by: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- Changes in v7: - add a check if dom0 is missing and xen,enhanced was specified - Bertrand gave his reviewed-by but I removed it due to the new check Changes in v4: - move xen,enhanced to the bottom of the list - do not set kinfo.dom0less_enhanced for dom0 Changes in v3: - improve commit message Changes in v2: - rename kinfo.enhanced to kinfo.dom0less_enhanced - set kinfo.dom0less_enhanced to true for dom0 - handle -ENODATA in addition to -EILSEQ --- docs/misc/arm/device-tree/booting.txt | 18 ++++++++++++++++++ xen/arch/arm/domain_build.c | 7 +++++++ xen/arch/arm/include/asm/kernel.h | 3 +++ 3 files changed, 28 insertions(+) --- docs/misc/arm/device-tree/booting.txt | 18 ++++++++++++++++++ xen/arch/arm/domain_build.c | 12 ++++++++++++ xen/arch/arm/include/asm/kernel.h | 3 +++ 3 files changed, 33 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 7b4a29a2c2..98253414b8 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -193,6 +193,24 @@ with the following properties: Optional. Handle to a xen,cpupool device tree node that identifies the cpupool where the guest will be started at boot. +- xen,enhanced + + A string property. Possible property values are: + + - "enabled" (or missing property value) + Xen PV interfaces, including grant-table and xenstore, will be + enabled for the VM. + + - "disabled" + Xen PV interfaces are disabled. + + If the xen,enhanced property is present with no value, it defaults + to "enabled". If the xen,enhanced property is not present, PV + interfaces are disabled. + + In the future other possible property values might be added to + enable only selected interfaces. + Under the "xen,domain" compatible node, one or more sub-nodes are present for the DomU kernel and ramdisk. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c4dd211b91..8d148b209d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3157,6 +3157,7 @@ static int __init construct_domU(struct domain *d, const struct dt_device_node *node) { struct kernel_info kinfo = {}; + const char *dom0less_enhanced; int rc; u64 mem; @@ -3172,6 +3173,17 @@ static int __init construct_domU(struct domain *d, kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); + rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced); + if ( rc == -EILSEQ || + rc == -ENODATA || + (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) + { + if ( hardware_domain ) + kinfo.dom0less_enhanced = true; + else + printk("Error: tried to use xen,enhanced without dom0\n"); + } + if ( vcpu_create(d, 0) == NULL ) return -ENOMEM; diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 874aa108a7..c4dc039b54 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -36,6 +36,9 @@ struct kernel_info { /* Enable pl011 emulation */ bool vpl011; + /* Enable PV drivers */ + bool dom0less_enhanced; + /* GIC phandle */ uint32_t phandle_gic; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328779.551929 (Exim 4.92) (envelope-from ) id 1npcVe-0004wo-GZ; Fri, 13 May 2022 21:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328779.551929; Fri, 13 May 2022 21:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVe-0004uS-9u; Fri, 13 May 2022 21:07:38 +0000 Received: by outflank-mailman (input) for mailman id 328779; Fri, 13 May 2022 21:07:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVd-0004iU-DJ for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:37 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b617fc19-d300-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:07:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACE056230D; Fri, 13 May 2022 21:07:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1601BC3411A; Fri, 13 May 2022 21:07:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b617fc19-d300-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476054; bh=Ao43GnpqxHR84y8XoXXvJ3ZaIgOqQ7vWofKWca/Apio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=idr/0x5CANAdy1Tko83H1Sr454IZKUWXeevc40M/F42wODgi8syHoElKjhiPQsvs6 ZIOnJuggDpo46gPl8qqhK+G4UdItwis/bCY7G+wNWXtHu6eKfPG0qBOw9Qs6pkRxOA 9G9tMe2cGS92hBOEebaLoUFzuceNPnVplSV8/fvJ1A6b7vNRfVV/SO+aaV4vM3Gw1g 8iXDW3KDQXYLN04jpZdmG4pyAtNYLl12MXy8vIoU79bfDL+ARZfI4+R2bVBadRjb3e j0zoYxbvuocoz5QOW/DEIVEYQtjrEDSwad1ysgiUEI12x95wSI6p1Niu2/78aAVRgG GN3/Em7cKdKhQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Bertrand Marquis , Jan Beulich Subject: [PATCH v7 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot Date: Fri, 13 May 2022 14:07:27 -0700 Message-Id: <20220513210730.679871-4-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio Export evtchn_alloc_unbound and make it __must_check. If "xen,enhanced" is enabled, then add to dom0less domains: - the hypervisor node in device tree - the xenstore event channel The xenstore event channel is also used for the first notification to let the guest know that xenstore has become available. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Acked-by: Jan Beulich CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis --- Changes in v7: - add an ASSERT, hardware_domain is required Changes in v5: - merge with "xen: export evtchn_alloc_unbound" - __must_check Changes in v3: - use evtchn_alloc_unbound Changes in v2: - set HVM_PARAM_STORE_PFN to ~0ULL at domain creation - in alloc_xenstore_evtchn do not call _evtchn_alloc_unbound xen: export evtchn_alloc_unbound It will be used during dom0less domains construction. --- xen/arch/arm/domain_build.c | 37 +++++++++++++++++++++++++++++++++++++ xen/common/event_channel.c | 2 +- xen/include/xen/event.h | 3 +++ 3 files changed, 41 insertions(+), 1 deletion(-) --- xen/arch/arm/domain_build.c | 38 +++++++++++++++++++++++++++++++++++++ xen/common/event_channel.c | 2 +- xen/include/xen/event.h | 3 +++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 8d148b209d..27b2c7ec3f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include @@ -2813,6 +2814,8 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) int ret; kinfo->phandle_gic = GUEST_PHANDLE_GIC; + kinfo->gnttab_start = GUEST_GNTTAB_BASE; + kinfo->gnttab_size = GUEST_GNTTAB_SIZE; addrcells = GUEST_ROOT_ADDRESS_CELLS; sizecells = GUEST_ROOT_SIZE_CELLS; @@ -2887,6 +2890,13 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) goto err; } + if ( kinfo->dom0less_enhanced ) + { + ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); + if ( ret ) + goto err; + } + ret = fdt_end_node(kinfo->fdt); if ( ret < 0 ) goto err; @@ -3153,6 +3163,25 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) return 0; } +static int __init alloc_xenstore_evtchn(struct domain *d) +{ + evtchn_alloc_unbound_t alloc; + int rc; + + alloc.dom = d->domain_id; + alloc.remote_dom = hardware_domain->domain_id; + rc = evtchn_alloc_unbound(&alloc); + if ( rc ) + { + printk("Failed allocating event channel for domain\n"); + return rc; + } + + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; + + return 0; +} + static int __init construct_domU(struct domain *d, const struct dt_device_node *node) { @@ -3222,6 +3251,15 @@ static int __init construct_domU(struct domain *d, if ( rc < 0 ) return rc; + if ( kinfo.dom0less_enhanced ) + { + ASSERT(hardware_domain); + rc = alloc_xenstore_evtchn(d); + if ( rc < 0 ) + return rc; + d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; + } + return rc; } diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 0a82eb3ac2..e60cd98d75 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -290,7 +290,7 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } -static int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; struct domain *d; diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h index 21c95e14fd..f3021fe304 100644 --- a/xen/include/xen/event.h +++ b/xen/include/xen/event.h @@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn); /* Allocate a specific event channel port. */ int evtchn_allocate_port(struct domain *d, unsigned int port); +/* Allocate a new event channel */ +int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc); + /* Unmask a local event-channel port. */ int evtchn_unmask(unsigned int port); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328780.551946 (Exim 4.92) (envelope-from ) id 1npcVg-0005Qx-0B; Fri, 13 May 2022 21:07:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328780.551946; Fri, 13 May 2022 21:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVf-0005ON-Rd; Fri, 13 May 2022 21:07:39 +0000 Received: by outflank-mailman (input) for mailman id 328780; Fri, 13 May 2022 21:07:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVe-0004iU-6T for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b669674b-d300-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:07:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 328166230C; Fri, 13 May 2022 21:07:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6EB1C34114; Fri, 13 May 2022 21:07:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b669674b-d300-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476055; bh=OcQ376zqgJ7yxyRMcJ28nIn26b0HBAsjUw2l6jWzJxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YWjUTBH6PD5UdqsXQu8y2PqyRNQtQT0CGKFCx9Lu2T0fW+l8hHOLgAZYZ2/wB9L6R SnsuFw7dwGoYSC1Zewtk7ee034pOX+tJaJ1z8A2VTyWrhg6lNEpQrZC+6fpISuHcJq YWfhKo+ezolQ5FeVJux8TT187883OC1oyz/BcCeD5CJiLiTpjSIGXDcvHZL2BbSVsh fSKNmv5DcGHnoV6+OAD1q5EMuThDx4a2RjVLZzKDrhqaMfy7yj3xdL1vX/TALZp9oM x/LMCgo3Ru7D4EXibrwTeCF76rVmUK1fFVSrfWeQ0tKH3CtRnxsVy3b1XoDgK2iQfs zPSuH4X16dMYA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini Subject: [PATCH v7 5/7] xenstored: send an evtchn notification on introduce_domain Date: Fri, 13 May 2022 14:07:28 -0700 Message-Id: <20220513210730.679871-5-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio When xs_introduce_domain is called, send out a notification on the xenstore event channel so that any (dom0less) domain waiting for the xenstore interface to be ready can continue with the initialization. Before sending the notification, clear XENSTORE_RECONNECTING. The extra notification is harmless for domains that don't require it. In xs_wire.h update the commment on top of XENSTORE_RECONNECTING to generalize its meaning to suit the dom0less use-case better. Also improve docs/misc/xenstore-ring.txt. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini --- Changes in v7: - add documentation to xenstore-ring.txt - Juergen already gave his reviewed-by, I dropped it due to the change to xenstore-ring.txt, but everything else is still the same Changes in v6: - use XENSTORE_CONNECTED instead of 0x0 - update xs_wire.h Changes in v5: - reset XS_CONNECTION_STATE_RECONNECTING before notifying the domU Changes in v2: - drop the new late_init parameter --- tools/xenstore/xenstored_domain.c | 4 ++++ xen/include/public/io/xs_wire.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) --- docs/misc/xenstore-ring.txt | 8 +++++++- tools/xenstore/xenstored_domain.c | 4 ++++ xen/include/public/io/xs_wire.h | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt index b338b21b19..f3d6ca4264 100644 --- a/docs/misc/xenstore-ring.txt +++ b/docs/misc/xenstore-ring.txt @@ -111,7 +111,13 @@ Assuming the server has advertised the feature, the guest can initiate a reconnection by setting the the Connection state to 1 ("Ring close and reconnect is in progress") and signalling the event channel. The guest must now ignore all fields except the Connection state and -wait for it to be set to 0 ("Ring is connected") +wait for it to be set to 0 ("Ring is connected"). + +In certain circumstances (e.g. dom0less guests with PV drivers support) +it is possible for the guest to find the Connection state already set to +1 by someone else during xenstore initialization. In that case, like in +the previous case, the guest must ignore all fields except the +Connection state and wait for it to be set to 0 before proceeding. The server will guarantee to diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 80ba1d627b..de88bf2a68 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -493,6 +493,10 @@ static struct domain *introduce_domain(const void *ctx, /* Now domain belongs to its connection. */ talloc_steal(domain->conn, domain); + /* Notify the domain that xenstore is available */ + interface->connection = XENSTORE_CONNECTED; + xenevtchn_notify(xce_handle, domain->port); + if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL, true, NULL); diff --git a/xen/include/public/io/xs_wire.h b/xen/include/public/io/xs_wire.h index 953a0050a3..c1ec7c73e3 100644 --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -141,7 +141,7 @@ struct xenstore_domain_interface { /* Valid values for the connection field */ #define XENSTORE_CONNECTED 0 /* the steady-state */ -#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ +#define XENSTORE_RECONNECT 1 /* reconnect in progress */ /* Valid values for the error field */ #define XENSTORE_ERROR_NONE 0 /* No error */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328783.551962 (Exim 4.92) (envelope-from ) id 1npcVh-0005pQ-Dd; Fri, 13 May 2022 21:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328783.551962; Fri, 13 May 2022 21:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVh-0005oT-5Y; Fri, 13 May 2022 21:07:41 +0000 Received: by outflank-mailman (input) for mailman id 328783; Fri, 13 May 2022 21:07:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVg-0004iU-6i for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6fe1e4d-d300-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:07:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31B446230E; Fri, 13 May 2022 21:07:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D9EAC34100; Fri, 13 May 2022 21:07:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6fe1e4d-d300-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476055; bh=np7FZDzo1soVXzJPDCUCWYC3dzjUNzPqexG/fuvJoXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a0F5TVJqdJlvd12iFnhVbUUbrKysjbMl9FP1nRE/mwvz/AZv9JcQaCRCp0KVf9ZWC DxuH9iXE3cvAXhRmpHNLT105CaKypw5CxlvRDWFSGqoFGe/9t4euCPKcStH53zrPM4 Lq5LYXKoMJTR+6dF6CxVSRDK2qVrrtDhriZJjX0yRnW2QFtLC5vXkkRdYVq1zC17Vx F9cl0eXyptQZEsOfgP8STK4Q9gr3O5T1EpIRrF0B0QS073DW0sHD97xE51nMoVxDxg QsnhRzQa/99Xth3UACGaYL5JKOz1zoDcSJS7pyQ1kUEPBw7q3+Q1yMnxFI1WjFcscp GVPTObcyX+haQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH v7 6/7] tools: add example application to initialize dom0less PV drivers Date: Fri, 13 May 2022 14:07:29 -0700 Message-Id: <20220513210730.679871-6-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio Add an example application that can be run in dom0 to complete the dom0less domains initialization so that they can get access to xenstore and use PV drivers. The application sets "connection" to XENSTORE_RECONNECT on the xenstore page before calling xs_introduce_domain to signal that the connection is not ready yet to be used. XENSTORE_RECONNECT is reset soon after by xenstored. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini CC: Wei Liu CC: Anthony PERARD CC: Juergen Gross --- Changes in v8: - check on HVM_PARAM_STORE_EVTCHN to see if the domain is xen,enhanced - fix ubuntu native build, #include for PROT_* definitions Changes in v7: - use PROT_READ | PROT_WRITE instead XS_READ | XS_WRITE Changes in v6: - include xs_wire.h and use its definitions Changes in v5: - set XS_CONNECTION_STATE_RECONNECTING before xs_introduce_domain Changes in v4: - only alloc xs page (no other magic pages) - add xenstore permissions - check all return values - rename restore_xenstore to create_xenstore - set target_memkb - set start_time properly - close xs transaction on error - call xc_dom_gnttab_seed instead of xc_dom_gnttab_init - xs_open instead of xs_daemon_open Changes in v3: - handle xenstore errors - add an in-code comment about xenstore entries - less verbose output - clean-up error path in main Changes in v2: - do not set HVM_PARAM_STORE_EVTCHN twice - rename restore_xenstore to create_xenstore - increase maxmem connection reconnecting --- tools/helpers/Makefile | 13 ++ tools/helpers/init-dom0less.c | 340 ++++++++++++++++++++++++++++++++++ 2 files changed, 353 insertions(+) create mode 100644 tools/helpers/init-dom0less.c --- tools/helpers/Makefile | 13 ++ tools/helpers/init-dom0less.c | 345 ++++++++++++++++++++++++++++++++++ 2 files changed, 358 insertions(+) create mode 100644 tools/helpers/init-dom0less.c diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 7f6c422440..8d78ab1e90 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -10,6 +10,9 @@ ifeq ($(CONFIG_Linux),y) ifeq ($(CONFIG_X86),y) PROGS += init-xenstore-domain endif +ifeq ($(CONFIG_ARM),y) +PROGS += init-dom0less +endif endif XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o @@ -26,6 +29,13 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h +INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenstore) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl) +$(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn) + .PHONY: all all: $(PROGS) @@ -35,6 +45,9 @@ xen-init-dom0: $(XEN_INIT_DOM0_OBJS) init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) +init-dom0less: $(INIT_DOM0LESS_OBJS) + $(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) + .PHONY: install install: all $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c new file mode 100644 index 0000000000..3e7ad54da7 --- /dev/null +++ b/tools/helpers/init-dom0less.c @@ -0,0 +1,345 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "init-dom-json.h" + +#define XENSTORE_PFN_OFFSET 1 +#define STR_MAX_LENGTH 64 + +static int alloc_xs_page(struct xc_interface_core *xch, + libxl_dominfo *info, + uint64_t *xenstore_pfn) +{ + int rc; + const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT; + xen_pfn_t p2m = (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET; + + rc = xc_domain_setmaxmem(xch, info->domid, + info->max_memkb + (XC_PAGE_SIZE/1024)); + if (rc < 0) + return rc; + + rc = xc_domain_populate_physmap_exact(xch, info->domid, 1, 0, 0, &p2m); + if (rc < 0) + return rc; + + *xenstore_pfn = base + XENSTORE_PFN_OFFSET; + rc = xc_clear_domain_page(xch, info->domid, *xenstore_pfn); + if (rc < 0) + return rc; + + return 0; +} + +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, + domid_t domid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + struct xs_permissions perms[2]; + + perms[0].id = domid; + perms[0].perms = XS_PERM_NONE; + perms[1].id = 0; + perms[1].perms = XS_PERM_READ; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/local/domain/%u/%s", domid, path) < 0) + return false; + if (!xs_write(xsh, t, full_path, val, strlen(val))) + return false; + return xs_set_permissions(xsh, t, full_path, perms, 2); +} + +static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t, + domid_t domid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/libxl/%u/%s", domid, path) < 0) + return false; + return xs_write(xsh, t, full_path, val, strlen(val)); +} + +static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t, + libxl_uuid uuid, char *path, char *val) +{ + char full_path[STR_MAX_LENGTH]; + + if (snprintf(full_path, STR_MAX_LENGTH, + "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0) + return false; + return xs_write(xsh, t, full_path, val, strlen(val)); +} + +/* + * The xenstore nodes are the xenstore nodes libxl writes at domain + * creation. + * + * The list was retrieved by running xenstore-ls on a corresponding + * domain started by xl/libxl. + */ +static int create_xenstore(struct xs_handle *xsh, + libxl_dominfo *info, libxl_uuid uuid, + evtchn_port_t xenstore_port) +{ + domid_t domid; + unsigned int i; + char uuid_str[STR_MAX_LENGTH]; + char dom_name_str[STR_MAX_LENGTH]; + char vm_val_str[STR_MAX_LENGTH]; + char id_str[STR_MAX_LENGTH]; + char max_memkb_str[STR_MAX_LENGTH]; + char target_memkb_str[STR_MAX_LENGTH]; + char cpu_str[STR_MAX_LENGTH]; + char xenstore_port_str[STR_MAX_LENGTH]; + char ring_ref_str[STR_MAX_LENGTH]; + xs_transaction_t t; + struct timeval start_time; + char start_time_str[STR_MAX_LENGTH]; + int rc; + + if (gettimeofday(&start_time, NULL) < 0) + return -errno; + rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d", + (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000); + if (rc < 0) + return rc; + + domid = info->domid; + rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid); + if (rc < 0) + return rc; + rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid); + if (rc < 0) + return rc; + rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); + if (rc < 0) + return rc; + rc = snprintf(vm_val_str, STR_MAX_LENGTH, + "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); + if (rc < 0) + return rc; + rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb); + if (rc < 0) + return rc; + rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb); + if (rc < 0) + return rc; + rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET); + if (rc < 0) + return rc; + rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port); + if (rc < 0) + return rc; + +retry_transaction: + t = xs_transaction_start(xsh); + if (t == XBT_NULL) + return -errno; + + rc = -EIO; + /* /vm */ + if (!do_xs_write_vm(xsh, t, uuid, "name", dom_name_str)) goto err; + if (!do_xs_write_vm(xsh, t, uuid, "uuid", uuid_str)) goto err; + if (!do_xs_write_vm(xsh, t, uuid, "start_time", start_time_str)) goto err; + + /* /domain */ + if (!do_xs_write_dom(xsh, t, domid, "vm", vm_val_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "name", dom_name_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err; + for (i = 0; i < info->vcpu_max_id; i++) { + rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i); + if (rc < 0) + goto err; + rc = -EIO; + if (!do_xs_write_dom(xsh, t, domid, cpu_str, + (info->cpupool & (1 << i)) ? "online" : "offline")) + goto err; + } + + if (!do_xs_write_dom(xsh, t, domid, "memory", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/static-max", max_memkb_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/target", target_memkb_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "memory/videoram", "-1")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "device", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "device/suspend", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "device/suspend/event-channel", "")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "control", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/shutdown", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-poweroff", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-reboot", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/feature-suspend", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/sysrq", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-multiprocessor-suspend", "1")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "control/platform-feature-xs_reset_watches", "1")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "domid", id_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "data", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "drivers", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "feature", "")) goto err; + if (!do_xs_write_dom(xsh, t, domid, "attr", "")) goto err; + + if (!do_xs_write_dom(xsh, t, domid, "store/port", xenstore_port_str)) goto err; + if (!do_xs_write_dom(xsh, t, domid, "store/ring-ref", ring_ref_str)) goto err; + + if (!do_xs_write_libxl(xsh, t, domid, "type", "pvh")) goto err; + if (!do_xs_write_libxl(xsh, t, domid, "dm-version", "qemu_xen")) goto err; + + if (!xs_transaction_end(xsh, t, false)) { + if (errno == EAGAIN) + goto retry_transaction; + else + return -errno; + } + + return 0; + +err: + xs_transaction_end(xsh, t, true); + return rc; +} + +static int init_domain(struct xs_handle *xsh, + struct xc_interface_core *xch, + xenforeignmemory_handle *xfh, + libxl_dominfo *info) +{ + libxl_uuid uuid; + uint64_t xenstore_evtchn, xenstore_pfn; + int rc; + struct xenstore_domain_interface *intf; + + printf("Init dom0less domain: %u\n", info->domid); + + rc = xc_hvm_param_get(xch, info->domid, HVM_PARAM_STORE_EVTCHN, + &xenstore_evtchn); + if (rc != 0) { + printf("Failed to get HVM_PARAM_STORE_EVTCHN\n"); + return 1; + } + + /* no xen,enhanced; nothing to do */ + if (!xenstore_evtchn) + return 0; + + /* Alloc xenstore page */ + if (alloc_xs_page(xch, info, &xenstore_pfn) != 0) { + printf("Error on alloc magic pages\n"); + return 1; + } + + intf = xenforeignmemory_map(xfh, info->domid, PROT_READ | PROT_WRITE, 1, + &xenstore_pfn, NULL); + if (!intf) { + printf("Error mapping xenstore page\n"); + return 1; + } + intf->connection = XENSTORE_RECONNECT; + xenforeignmemory_unmap(xfh, intf, 1); + + rc = xc_dom_gnttab_seed(xch, info->domid, true, + (xen_pfn_t)-1, xenstore_pfn, 0, 0); + if (rc) + err(1, "xc_dom_gnttab_seed"); + + libxl_uuid_generate(&uuid); + xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); + + rc = gen_stub_json_config(info->domid, &uuid); + if (rc) + err(1, "gen_stub_json_config"); + + /* Now everything is ready: set HVM_PARAM_STORE_PFN */ + rc = xc_hvm_param_set(xch, info->domid, HVM_PARAM_STORE_PFN, + xenstore_pfn); + if (rc < 0) + return rc; + + rc = create_xenstore(xsh, info, uuid, xenstore_evtchn); + if (rc) + err(1, "writing to xenstore"); + + rc = xs_introduce_domain(xsh, info->domid, + (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET, + xenstore_evtchn); + if (!rc) + err(1, "xs_introduce_domain"); + return 0; +} + +/* Check if domain has been configured in XS */ +static bool domain_exists(struct xs_handle *xsh, int domid) +{ + return xs_is_domain_introduced(xsh, domid); +} + +int main(int argc, char **argv) +{ + libxl_dominfo *info = NULL; + libxl_ctx *ctx; + int nb_vm = 0, rc = 0, i; + struct xs_handle *xsh = NULL; + struct xc_interface_core *xch = NULL; + xenforeignmemory_handle *xfh = NULL; + + /* TODO reuse libxl xsh connection */ + xsh = xs_open(0); + xch = xc_interface_open(0, 0, 0); + xfh = xenforeignmemory_open(0, 0); + if (xsh == NULL || xch == NULL || xfh == NULL) { + fprintf(stderr, "Cannot open xc/xs/xenforeignmemory interfaces"); + rc = -errno; + goto out; + } + + rc = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, NULL); + if (rc) { + fprintf(stderr, "cannot init xl context\n"); + goto out; + } + + info = libxl_list_domain(ctx, &nb_vm); + if (!info) { + fprintf(stderr, "libxl_list_vm failed.\n"); + rc = -1; + goto out; + } + + for (i = 0; i < nb_vm; i++) { + domid_t domid = info[i].domid; + + /* Don't need to check for Dom0 */ + if (!domid) + continue; + + printf("Checking domid: %u\n", domid); + if (!domain_exists(xsh, domid)) { + rc = init_domain(xsh, xch, xfh, &info[i]); + if (rc < 0) { + fprintf(stderr, "init_domain failed.\n"); + goto out; + } + } else { + printf("Domain %u has already been initialized\n", domid); + } + } +out: + libxl_dominfo_list_free(info, nb_vm); + return rc; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:07:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328785.551975 (Exim 4.92) (envelope-from ) id 1npcVj-0006GN-Du; Fri, 13 May 2022 21:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328785.551975; Fri, 13 May 2022 21:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVj-0006Ey-4A; Fri, 13 May 2022 21:07:43 +0000 Received: by outflank-mailman (input) for mailman id 328785; Fri, 13 May 2022 21:07:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcVh-0004iU-6e for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:07:41 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7a56bbe-d300-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:07:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6BE4CB831E3; Fri, 13 May 2022 21:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C332BC34114; Fri, 13 May 2022 21:07:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7a56bbe-d300-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476056; bh=vBoz7dmTWhlc7PPw4Rw0ri1k93jgoLdc1Q6ZpNpIcJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UaoUy68K5A3ytuyZMpEiPm5yV1Q8+4dPhgymDyOtga9Ou6ALz1CPdTkRStQ0rkvBb WkkTLNDrmPbdhO6WC8rYsgvNb9LZTq6A/2X7dHOKksVzPfktSawTJ50ADW0lelRjtG KgEjW8Db+ZvQw45bX+yPaPqbXqd3quWtibbpdeQ3zcFmgHO1OTBFv5qFu83nuINfGv zpfmDO03XvdmpbxM3It5/e4z3PiMwbc8AxlD/PjWaO0qruJrh5O1f87wNIpDsQOzYC 7rXhEwcGib5zYR5RZy64RxQ+kfs99AIwJRjUFtM4jvN/vx+rxPHjUmdn+RUE7kHYKv v5gjNZNkCGB6A== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, jgross@suse.com, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Stefano Stabellini , Luca Fancellu , Julien Grall Subject: [PATCH v7 7/7] docs: document dom0less + PV drivers Date: Fri, 13 May 2022 14:07:30 -0700 Message-Id: <20220513210730.679871-7-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Document how to use the feature and how the implementation works. Signed-off-by: Stefano Stabellini Reviewed-by: Luca Fancellu Acked-by: Julien Grall --- docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) --- docs/features/dom0less.pandoc | 43 ++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc index c9edb529e1..725afa0558 100644 --- a/docs/features/dom0less.pandoc +++ b/docs/features/dom0less.pandoc @@ -90,6 +90,46 @@ Otherwise, they may be unusable in Xen (for instance if they are compressed). See docs/misc/arm/device-tree/booting.txt for more information. +PV Drivers +---------- + +It is possible to use PV drivers with dom0less guests with some +restrictions: + +- dom0less domUs that want to use PV drivers support should have the + "xen,enhanced" property set under their device tree nodes (see + docs/misc/arm/device-tree/booting.txt) +- a dom0 must be present (or another domain with enough privileges to + run the toolstack) +- after dom0 is booted, the utility "init-dom0less" must be run +- do not run "init-dom0less" while creating other guests with xl + +After the execution of init-dom0less, it is possible to use "xl" to +hotplug PV drivers to dom0less guests. E.g. xl network-attach domU. + +The implementation works as follows: +- Xen allocates the xenstore event channel for each dom0less domU that + has the "xen,enhanced" property, and sets HVM_PARAM_STORE_EVTCHN +- Xen does *not* allocate the xenstore page and sets HVM_PARAM_STORE_PFN + to ~0ULL (invalid) +- Dom0less domU kernels check that HVM_PARAM_STORE_PFN is set to invalid + - Old kernels will continue without xenstore support (Note: some old + buggy kernels might crash because they don't check the validity of + HVM_PARAM_STORE_PFN before using it! Disable "xen,enhanced" in + those cases) + - New kernels will wait for a notification on the xenstore event + channel (HVM_PARAM_STORE_EVTCHN) before continuing with the + initialization +- Once dom0 is booted, init-dom0less is executed: + - it allocates the xenstore shared page and sets HVM_PARAM_STORE_PFN + - it calls xs_introduce_domain +- Xenstored notices the new domain, initializes interfaces as usual, and + sends an event channel notification to the domain using the xenstore + event channel (HVM_PARAM_STORE_EVTCHN) +- The Linux domU kernel receives the event channel notification, checks + HVM_PARAM_STORE_PFN again and continue with the initialization + + Limitations ----------- @@ -107,9 +147,6 @@ limitations: information, the GIC version exposed to the domains started by Xen at boot is the same as the native GIC version. -- No PV drivers. There is no support for PV devices at the moment. All - devices need to be statically assigned to guests. - - Pinning vCPUs of domains started by Xen at boot can be done from the control domain, using `xl vcpu-pin` as usual. It is not currently possible to configure vCPU pinning without a control domain. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328833.551985 (Exim 4.92) (envelope-from ) id 1npcdC-0001U9-5L; Fri, 13 May 2022 21:15:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328833.551985; Fri, 13 May 2022 21:15:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcdC-0001U2-2N; Fri, 13 May 2022 21:15:26 +0000 Received: by outflank-mailman (input) for mailman id 328833; Fri, 13 May 2022 21:15:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcdA-0001Tw-Mi for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:15:24 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbf0a80d-d301-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:15:23 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local (return-path ijackson@chiark.greenend.org.uk) id 1npcd5-0004Nq-SA; Fri, 13 May 2022 22:15:19 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbf0a80d-d301-11ec-aa76-f101dd46aeb6 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <25214.51815.786560.367850@chiark.greenend.org.uk> Date: Fri, 13 May 2022 22:15:19 +0100 To: Anthony PERARD Cc: , Roger Pau Monne Subject: Re: [OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF In-Reply-To: <20220513133534.88564-1-anthony.perard@citrix.com> References: <20220513133534.88564-1-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) Anthony PERARD writes ("[OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF"): > Recent versions of OVMF now need a version of NASM that is newer > than the one available on Debian oldstable/buster. They want to use > NASM 2.15.05 [1], which is available in Debian stable/bullseye. The > need to use a newer version started with d3febfd9ade3 ("MdePkg: > Replace Opcode with the corresponding instructions."). > > There is no backport package available but the nasm package from > Debian Bullseye can easily be installed on Buster as it has few > dependencies and are already satisfied. I think this is a quite fine bodge. > + target_fetchurl($ho, $nasm_url, "/tmp/$nasm_pkg"); > + target_install_packages($ho, "/tmp/$nasm_pkg"); I don't think this use of /tmp is very nice. ts-xen-build-prep runs with the host all to itself, so I think you can use /root ? Ian. -- Ian Jackson These opinions are my own. Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Fri May 13 21:16:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328841.551997 (Exim 4.92) (envelope-from ) id 1npcdw-00021A-Ff; Fri, 13 May 2022 21:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328841.551997; Fri, 13 May 2022 21:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcdw-000213-CE; Fri, 13 May 2022 21:16:12 +0000 Received: by outflank-mailman (input) for mailman id 328841; Fri, 13 May 2022 21:16:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcdv-0001mI-2w for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:16:11 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7e44d70-d301-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:16:09 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local (return-path ijackson@chiark.greenend.org.uk) id 1npcdp-0004ZV-PT; Fri, 13 May 2022 22:16:05 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7e44d70-d301-11ec-b8b8-f95467ff1ed0 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <25214.51861.297010.695414@chiark.greenend.org.uk> Date: Fri, 13 May 2022 22:16:05 +0100 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [OSSTEST PATCH] ts-xen-build-prep: Grab newer NASM version, to build OVMF In-Reply-To: References: <20220513133534.88564-1-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) Roger Pau Monn=E9 writes ("Re: [OSSTEST PATCH] ts-xen-build-prep: Grab = newer NASM version, to build OVMF"): > I guess we could use something similar to DebianExtraPackages? >=20 > DebianExtraPackages_build_$arch_$suite nasm_2.15.05-1_$ho->{Arch}.deb= >=20 > And fetch those using the some_extradebs method. Yes, I think this is better. --=20 Ian Jackson These opinions are my o= wn. =20 Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Fri May 13 21:19:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:19:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328852.552007 (Exim 4.92) (envelope-from ) id 1npcgm-0002hN-Vs; Fri, 13 May 2022 21:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328852.552007; Fri, 13 May 2022 21:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcgm-0002hG-SQ; Fri, 13 May 2022 21:19:08 +0000 Received: by outflank-mailman (input) for mailman id 328852; Fri, 13 May 2022 21:19:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npcgl-0002hA-Lr for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:19:07 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 521fdb24-d302-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:19:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D04DAB83132; Fri, 13 May 2022 21:19:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D350C34113; Fri, 13 May 2022 21:19:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 521fdb24-d302-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476744; bh=7YTs/zuZbfJI3WWts99XEzjKJSNx8kLEj6VW19kCNqw=; h=Date:From:To:cc:Subject:From; b=Ut7MeEQTFp76bWMEt1AKGVHzWMvqjvm+8LY4NnMb9oMod94C5+9d564t2tqCPNp4Y H4M/EwyrgScTbKZzaXXF1pBpKOoWOlHAMJaiA+IrEnAN8T15blx9l+gF9B+jxGov4S afl6yjP92ULbuJDCJ7boFMH4VnFNwM/FJplBS6ACLHbAxsWiNj5mTPBf2Zd5bNcady 7HxnJfzg8ZXaKqex6QNMRI8aWuhbFT8xLRE5qrkYBzhn2dat9YBuVh30EsTMFhHiA1 MXR0IvBjxCq98VUve/45CU9UEozpJ4GohWDRxmxR2E7PxjS3CKpQQmH8hrnCfBe4e6 e2SbcTvHB9mKA== Date: Fri, 13 May 2022 14:19:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: boris.ostrovsky@oracle.com, jgross@suse.com cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH LINUX v5 0/2] dom0less + PV drivers Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This small Linux patch series implements support for initializing xenstore later, if not immediately available at boot time. It enables dom0less + PV drivers support. Luca Miccio (1): xen: add support for initializing xenstore later as HVM domain Stefano Stabellini (1): xen: sync xs_wire.h header with upstream xen drivers/xen/xenbus/xenbus_probe.c | 91 +++++++++++++++++++++++++++++--------- include/xen/interface/io/xs_wire.h | 37 ++++++++++++++-- 2 files changed, 104 insertions(+), 24 deletions(-) From xen-devel-bounces@lists.xenproject.org Fri May 13 21:19:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:19:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328857.552019 (Exim 4.92) (envelope-from ) id 1npchM-0003EC-9Z; Fri, 13 May 2022 21:19:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328857.552019; Fri, 13 May 2022 21:19:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npchM-0003E5-6F; Fri, 13 May 2022 21:19:44 +0000 Received: by outflank-mailman (input) for mailman id 328857; Fri, 13 May 2022 21:19:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npchK-0002hA-VF for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:19:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66e8a839-d302-11ec-b8b8-f95467ff1ed0; Fri, 13 May 2022 23:19:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA6A061F5C; Fri, 13 May 2022 21:19:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCFE4C34100; Fri, 13 May 2022 21:19:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66e8a839-d302-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476780; bh=1seN4daKntnM5guSKJ74plZIHGGLz1D4C2nyHZd8PjU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PyX6D3o+LcpMEojSPU6QoJvVWNdFER/RInuyzYrME0iuwcfoHomkF4rgUh39/EBz0 yh35ljGKyg8E+PRKhsBjMTCKaEMiIy+f7Yaq690OMbJlEbYiJ7tIiAYPxwWbd1CGow zwbPXMY1k6z+8zZ7Q1hqwUoZP0wpXdKJr8g7lhFj1DzpJp4eKYcN+1GzHskwmOJm1a dUF+l73LJRxF9IbjSs2yCsvNFhlWjMArLq0fpuqKxxzA6KiWaCtT0J5soYIvVuIB8h q29xlpsEKKuRGNIgSaODizJ0kxB1EKd4IVVYcJPvajUmxZKzojjuf9NxTiOn1hKJ1g /06N/9EaxYvew== From: Stefano Stabellini To: boris.ostrovsky@oracle.com, jgross@suse.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: [PATCH LINUX v5 1/2] xen: sync xs_wire.h header with upstream xen Date: Fri, 13 May 2022 14:19:37 -0700 Message-Id: <20220513211938.719341-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Sync the xs_wire.h header file in Linux with the one in Xen. Signed-off-by: Stefano Stabellini --- Changes in v5: - add XSD_ERROR(E2BIG) - Boris gave his reviewed-by but due to this change I removed it --- include/xen/interface/io/xs_wire.h | 37 ++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/include/xen/interface/io/xs_wire.h b/include/xen/interface/io/xs_wire.h index d40a44f09b16..b62365478ac0 100644 --- a/include/xen/interface/io/xs_wire.h +++ b/include/xen/interface/io/xs_wire.h @@ -10,7 +10,8 @@ enum xsd_sockmsg_type { - XS_DEBUG, + XS_CONTROL, +#define XS_DEBUG XS_CONTROL XS_DIRECTORY, XS_READ, XS_GET_PERMS, @@ -30,8 +31,13 @@ enum xsd_sockmsg_type XS_IS_DOMAIN_INTRODUCED, XS_RESUME, XS_SET_TARGET, - XS_RESTRICT, - XS_RESET_WATCHES, + /* XS_RESTRICT has been removed */ + XS_RESET_WATCHES = XS_SET_TARGET + 2, + XS_DIRECTORY_PART, + + XS_TYPE_COUNT, /* Number of valid types. */ + + XS_INVALID = 0xffff /* Guaranteed to remain an invalid type */ }; #define XS_WRITE_NONE "NONE" @@ -59,7 +65,8 @@ static struct xsd_errors xsd_errors[] __attribute__((unused)) = { XSD_ERROR(EROFS), XSD_ERROR(EBUSY), XSD_ERROR(EAGAIN), - XSD_ERROR(EISCONN) + XSD_ERROR(EISCONN), + XSD_ERROR(E2BIG) }; struct xsd_sockmsg @@ -87,9 +94,31 @@ struct xenstore_domain_interface { char rsp[XENSTORE_RING_SIZE]; /* Replies and async watch events. */ XENSTORE_RING_IDX req_cons, req_prod; XENSTORE_RING_IDX rsp_cons, rsp_prod; + uint32_t server_features; /* Bitmap of features supported by the server */ + uint32_t connection; + uint32_t error; }; /* Violating this is very bad. See docs/misc/xenstore.txt. */ #define XENSTORE_PAYLOAD_MAX 4096 +/* Violating these just gets you an error back */ +#define XENSTORE_ABS_PATH_MAX 3072 +#define XENSTORE_REL_PATH_MAX 2048 + +/* The ability to reconnect a ring */ +#define XENSTORE_SERVER_FEATURE_RECONNECTION 1 +/* The presence of the "error" field in the ring page */ +#define XENSTORE_SERVER_FEATURE_ERROR 2 + +/* Valid values for the connection field */ +#define XENSTORE_CONNECTED 0 /* the steady-state */ +#define XENSTORE_RECONNECT 1 /* guest has initiated a reconnect */ + +/* Valid values for the error field */ +#define XENSTORE_ERROR_NONE 0 /* No error */ +#define XENSTORE_ERROR_COMM 1 /* Communication problem */ +#define XENSTORE_ERROR_RINGIDX 2 /* Invalid ring index */ +#define XENSTORE_ERROR_PROTO 3 /* Protocol violation (payload too long) */ + #endif /* _XS_WIRE_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 21:19:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 21:19:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328859.552029 (Exim 4.92) (envelope-from ) id 1npchN-0003UL-HR; Fri, 13 May 2022 21:19:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328859.552029; Fri, 13 May 2022 21:19:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npchN-0003UA-EZ; Fri, 13 May 2022 21:19:45 +0000 Received: by outflank-mailman (input) for mailman id 328859; Fri, 13 May 2022 21:19:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npchL-0003Bg-Vn for xen-devel@lists.xenproject.org; Fri, 13 May 2022 21:19:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 672742ff-d302-11ec-aa76-f101dd46aeb6; Fri, 13 May 2022 23:19:42 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A4EB62314; Fri, 13 May 2022 21:19:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 550F0C34113; Fri, 13 May 2022 21:19:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 672742ff-d302-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652476780; bh=bilc60kub9Jt+89+0VvQBOq5M0jsXFwdI/d4eFUURIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pOPTONZ+xevYYDUIfEq7+1V70ZmDaYD/GR9gzPL4FkPDqMRkApP6Q6SkT3QdynkkB RpbNK5vj5xzQ8WtEyPbg07QzEphRck+zhn1+SZRN9Ugc6DSLDQ5Jj+0GrG4BxvSBev lEgxidEInASsP7rqrzxBc3gC21thVD6AFgxW9PuK46YwQx1iG4tYgNCGte/s7w7LF2 +5LJcUC27u+kKJ4wZUUQzQKYX94eiFVulFxDN/uv9nArsTv3eNVYOnuf49VRZsehtI Gp2+UizmCUX7XESzjLCSPpV4WNCYcGBgZWVwCDgyAaE8QobybmJkeP7vaWqYEsjTQT c4k+I7h/ct/Og== From: Stefano Stabellini To: boris.ostrovsky@oracle.com, jgross@suse.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, Luca Miccio , Stefano Stabellini Subject: [PATCH LINUX v5 2/2] xen: add support for initializing xenstore later as HVM domain Date: Fri, 13 May 2022 14:19:38 -0700 Message-Id: <20220513211938.719341-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luca Miccio When running as dom0less guest (HVM domain on ARM) the xenstore event channel is available at domain creation but the shared xenstore interface page only becomes available later on. In that case, wait for a notification on the xenstore event channel, then complete the xenstore initialization later, when the shared page is actually available. The xenstore page has few extra field. Add them to the shared struct. One of the field is "connection", when the connection is ready, it is zero. If the connection is not-zero, wait for a notification. Signed-off-by: Luca Miccio Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky --- Changes in v5: - no need to initialize local variable err - code alignment Changes in v4: - improve in-code comments - move header sync to separate patch - use XENSTORE_CONNECTED Changes in v3: - check for the connection field, if it is not zero, wait for event Changes in v2: - remove XENFEAT_xenstore_late_init --- drivers/xen/xenbus/xenbus_probe.c | 91 ++++++++++++++++++++++++------- 1 file changed, 71 insertions(+), 20 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index fe360c33ce71..d367f2bd2b93 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -65,6 +65,7 @@ #include "xenbus.h" +static int xs_init_irq; int xen_store_evtchn; EXPORT_SYMBOL_GPL(xen_store_evtchn); @@ -750,6 +751,20 @@ static void xenbus_probe(void) { xenstored_ready = 1; + if (!xen_store_interface) { + xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE); + /* + * Now it is safe to free the IRQ used for xenstore late + * initialization. No need to unbind: it is about to be + * bound again from xb_init_comms. Note that calling + * unbind_from_irqhandler now would result in xen_evtchn_close() + * being called and the event channel not being enabled again + * afterwards, resulting in missed event notifications. + */ + free_irq(xs_init_irq, &xb_waitq); + } + /* * In the HVM case, xenbus_init() deferred its call to * xs_init() in case callbacks were not operational yet. @@ -798,20 +813,22 @@ static int __init xenbus_probe_initcall(void) { /* * Probe XenBus here in the XS_PV case, and also XS_HVM unless we - * need to wait for the platform PCI device to come up. + * need to wait for the platform PCI device to come up or + * xen_store_interface is not ready. */ if (xen_store_domain_type == XS_PV || (xen_store_domain_type == XS_HVM && - !xs_hvm_defer_init_for_callback())) + !xs_hvm_defer_init_for_callback() && + xen_store_interface != NULL)) xenbus_probe(); /* - * For XS_LOCAL, spawn a thread which will wait for xenstored - * or a xenstore-stubdom to be started, then probe. It will be - * triggered when communication starts happening, by waiting - * on xb_waitq. + * For XS_LOCAL or when xen_store_interface is not ready, spawn a + * thread which will wait for xenstored or a xenstore-stubdom to be + * started, then probe. It will be triggered when communication + * starts happening, by waiting on xb_waitq. */ - if (xen_store_domain_type == XS_LOCAL) { + if (xen_store_domain_type == XS_LOCAL || xen_store_interface == NULL) { struct task_struct *probe_task; probe_task = kthread_run(xenbus_probe_thread, NULL, @@ -907,10 +924,25 @@ static struct notifier_block xenbus_resume_nb = { .notifier_call = xenbus_resume_cb, }; +static irqreturn_t xenbus_late_init(int irq, void *unused) +{ + int err; + uint64_t v = 0; + + err = hvm_get_parameter(HVM_PARAM_STORE_PFN, &v); + if (err || !v || !~v) + return IRQ_HANDLED; + xen_store_gfn = (unsigned long)v; + + wake_up(&xb_waitq); + return IRQ_HANDLED; +} + static int __init xenbus_init(void) { int err; uint64_t v = 0; + bool wait = false; xen_store_domain_type = XS_UNKNOWN; if (!xen_domain()) @@ -957,25 +989,44 @@ static int __init xenbus_init(void) * been properly initialized. Instead of attempting to map a * wrong guest physical address return error. * - * Also recognize all bits set as an invalid value. + * Also recognize all bits set as an invalid/uninitialized value. */ - if (!v || !~v) { + if (!v) { err = -ENOENT; goto out_error; } - /* Avoid truncation on 32-bit. */ + if (v == ~0ULL) { + wait = true; + } else { + /* Avoid truncation on 32-bit. */ #if BITS_PER_LONG == 32 - if (v > ULONG_MAX) { - pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", - __func__, v); - err = -EINVAL; - goto out_error; - } + if (v > ULONG_MAX) { + pr_err("%s: cannot handle HVM_PARAM_STORE_PFN=%llx > ULONG_MAX\n", + __func__, v); + err = -EINVAL; + goto out_error; + } #endif - xen_store_gfn = (unsigned long)v; - xen_store_interface = - xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, - XEN_PAGE_SIZE); + xen_store_gfn = (unsigned long)v; + xen_store_interface = + xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE); + if (xen_store_interface->connection != XENSTORE_CONNECTED) + wait = true; + } + if (wait) { + err = bind_evtchn_to_irqhandler(xen_store_evtchn, + xenbus_late_init, + 0, "xenstore_late_init", + &xb_waitq); + if (err < 0) { + pr_err("xenstore_late_init couldn't bind irq err=%d\n", + err); + return err; + } + + xs_init_irq = err; + } break; default: pr_warn("Xenstore state unknown\n"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 13 22:28:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 13 May 2022 22:28:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328876.552041 (Exim 4.92) (envelope-from ) id 1npdln-0002dm-MZ; Fri, 13 May 2022 22:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328876.552041; Fri, 13 May 2022 22:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npdln-0002df-JX; Fri, 13 May 2022 22:28:23 +0000 Received: by outflank-mailman (input) for mailman id 328876; Fri, 13 May 2022 22:28:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npdlm-0002dV-0C; Fri, 13 May 2022 22:28:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npdll-0002vp-Rt; Fri, 13 May 2022 22:28:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npdll-00016q-Dd; Fri, 13 May 2022 22:28:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npdll-00072Z-D9; Fri, 13 May 2022 22:28:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=G74E2/VOBx9V4ndtWzUooGWtKALBl3jRYwQn0azLp7Y=; b=IihpvXSCm8NgeUBOmg23ZOyxkm g5r35iukWEo75d1VQ37O3SlqS+PwIJJt7DaesyPqUfGGhbAVc0TDRHIbJQdOYZzTWO8ZAvhGow+Os HYiUbMSbDEyu4Y2MTdxVwcMCRoiCDLmfibiGPdt4h506pvgMmKwM0vqLD5vJ5A+nT+VI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170402: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 13 May 2022 22:28:21 +0000 flight 170402 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170402/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 73 days 988 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 02:14:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 02:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328917.552055 (Exim 4.92) (envelope-from ) id 1nphIH-0007V3-8O; Sat, 14 May 2022 02:14:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328917.552055; Sat, 14 May 2022 02:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphIH-0007Uw-5H; Sat, 14 May 2022 02:14:09 +0000 Received: by outflank-mailman (input) for mailman id 328917; Sat, 14 May 2022 02:14:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphIF-0007Um-MN; Sat, 14 May 2022 02:14:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphIF-0006Kb-KS; Sat, 14 May 2022 02:14:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphIF-0004Eg-AK; Sat, 14 May 2022 02:14:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nphIF-000689-9c; Sat, 14 May 2022 02:14:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RygzBI+wum6F1h0tn5cx3eaTXbL1axhHmFc/xLd1vSg=; b=3S7GE2hYcxnviDn8YOKDyqDYz5 T8QDkVSuAlJvbrQP1rCcrVa4vIkhqIetNYGnoRq/3FKtFrWBCeFEX19O48RC3Kg0NO+XX0coKWFyn 0+HjXLQDH/I8BRT7vP7klRMf41L1POLwafv4b2pZ77dj8axwYiYigUpL0L3jD1xR5wN0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170403: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 02:14:07 +0000 flight 170403 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170403/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 989 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 02:34:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 02:34:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328926.552066 (Exim 4.92) (envelope-from ) id 1nphcJ-0003HG-0C; Sat, 14 May 2022 02:34:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328926.552066; Sat, 14 May 2022 02:34:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphcI-0003H8-TG; Sat, 14 May 2022 02:34:50 +0000 Received: by outflank-mailman (input) for mailman id 328926; Sat, 14 May 2022 02:34:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nphcH-0003Ga-Hx for xen-devel@lists.xenproject.org; Sat, 14 May 2022 02:34:50 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 698c59e9-d32e-11ec-b8b8-f95467ff1ed0; Sat, 14 May 2022 04:34:45 +0200 (CEST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24E1uPkG014158; Sat, 14 May 2022 02:34:24 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g2371r0mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 14 May 2022 02:34:24 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24E2LXSd022121; Sat, 14 May 2022 02:34:23 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2044.outbound.protection.outlook.com [104.47.51.44]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3g22uyraq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 14 May 2022 02:34:23 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CH0PR10MB4825.namprd10.prod.outlook.com (2603:10b6:610:da::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Sat, 14 May 2022 02:34:21 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5250.016; Sat, 14 May 2022 02:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 698c59e9-d32e-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=cgqPCP3tT+Zuaez1zVSdaesB5qCjT220JkLszKaXsrw=; b=tbfk0WKz8YwIi7aH+o0q2BEyO3XB6No6r1ENjO5uZzl7X64y4rIO2CR7rSsYUFI+PbZH 4BsHm1TYLXQQIHgs2WGH6F7CYQa1NZ7A5zIN+NO33PXatP2LCSdit4kv1umkAP21RcFd A+3eDVN9mVkTLW7vKNpwn0LlqauSsa7sIS/DZVJiM2w7xjrQoN8s3U1RUirdY65Ur8rF pstnwPeqzwr4tCiaS8rFc6vSxrA+dcwQl5nZgO20BtRXqh3RfPCg0TTsu8EOTBStUUrl wHu1Bpd5s5M10Cp+AO5Xp+0zNHr5D8N52Mq5UuliepFxuAgS3KDwVuXfKCbAFzkZnHoi VQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YD1jdNOgTF9aDfyye/5LoMp9bwaC0Vz5sMwBs0UO6P4rbiBWRSaP3AAXwljkjq0ruw65tXYRaV4uTpFT0Y+LgLC298qdCPCxPtNr9ZrrQHx7FbKK+bRbpBjlgW630DUjE8BpKSsn8w8iPFTBVmTQoChOWYqjA9MUDAQXbUEN+P8JdcmSK3GaPXtRqZ2KJO8xVqxqOAU+UPOq0VIRmXnXWCKoPTDqKg5+7hyQ5Vp5yGEKaLEJLwacNJzCQ9iLMOaOFnDYI58i7pyVulWegGG60d517pqHq96K4LBXJbvgirD3ZSf/RNYILHF5HtB7pHjMr73NetPyBhZtofchO2VVuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgqPCP3tT+Zuaez1zVSdaesB5qCjT220JkLszKaXsrw=; b=BSmwJO4imFqjAx1CpEAsXGifiXE280wOpIdNu88Nqhsiw9BJQVq4+07WO4rveZC1XT3e27zVDdxlqztzvJzuPEcNAIv8i1xepw0fiB47qYba3iHfSgXNCM/VObgP3gQuxlOpkVZlCa0Wmntt0j0Ak8eAI+ZDItyalZDQ3CFOXbhKxTC6b6CIGCpk3heQq2hv+qUWHDTG9arlbVf6laiD5SE6Q0H61Kv1ZXDf2/M67V9j6jgLG430Xd+cIfvMb7oAOlha2eYw9/U/uSNINmACBOkyx4jC7xVt0Kj0FWaaJQndy44bX8qHGwN1yh2uduRgdxxgpn+PW4NbpDneI5k1Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cgqPCP3tT+Zuaez1zVSdaesB5qCjT220JkLszKaXsrw=; b=Sc3YciztoofzciW3PbZQWdt+EgumncWg+NNSyX6luhNum1KZmQmrMPyTYt8eCmOgIdiqtLQTd8B9P7dyjPJAT3w5sS/c4vOPqipdhr9Tj9qOseILq/r60M7KxeWoHFfLJ8/5Pmb//99uVx/basOMLzi4yMJ3x6idZ8cFJWlkyO0= Message-ID: <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> Date: Fri, 13 May 2022 22:34:19 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Juergen Gross , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0302.namprd13.prod.outlook.com (2603:10b6:208:2c1::7) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: efe6e20d-1489-4578-90fd-08da3552407c X-MS-TrafficTypeDiagnostic: CH0PR10MB4825:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: muemePyPhjhrXLdKT8hLrb1nyr+LnSMaFeqotA1Sot5Els5DH4InlLPPTzA5E0ykXBKwvlle9QXLzP4DgLLS9a1+qD1oUg8v0uudliITmwLkI6yXb94bMv06y9hGXuJt/YIsBPKDNpyr/AWJaIK8wLEhCA3oxqZlmWBozw562PA6CERcnWtZR0zqQZp8uD5GBrRU6kw83M9IdUFiBW6/6ga/KcQ4obbb/Sbs5XgirBMZAoIgB9N6+5XlSD2giz/V0fPOVbuFtzZGJ9Bj/G5p0yCQaqXoPknrxnkawZW26QsN9wcMzdFe2pnLWtE5qT8GTa9DzBrn3J0EpAGKu9cWOEe+02ecVasfX3r284kZX+MGKtJwQAqDkSlXQCTU8KUXfkc+tUBw3v61ZrzmI56elRzd1aS4FnQhysYJj2UJivNO45xXViSeOP57zRFv6hfcKpzwApdTsa9Ha9s/b+/b2u6BWosRv42rXfPNyvCZXGiVIbYoCI3dW2SmkCO7Ox9wnXF5mUoFVLGdCaEnCwjN36R0z83s8zL5CVreA+dXrk1EwM70H7HYP/w+m4b3lyPaGMmDKT6Mc/vOCQXFkMIjE0nAopWm3VjmSiM/txXxMHadEdwBqTgkU36rJMMWdJ2nnYzVkgGZphkHtdQbl03vkQLiVkHWcZ5da0wxzfuCF6YX6aamwadr1u+Iz1/IhR+4s+yRosLH1z85McKEEhjYj0rigoNQR3ykbAwwxoSUnWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(31686004)(83380400001)(110136005)(54906003)(4326008)(66946007)(2906002)(66556008)(8676002)(66476007)(44832011)(6486002)(316002)(508600001)(5660300002)(7416002)(36756003)(2616005)(6512007)(26005)(53546011)(186003)(38100700002)(86362001)(31696002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGRET0NDNHVBcDJqWm52WElxeDVzTHVnTzNTRDZ3aFpIbHY1NGFHZ3pjOGJv?= =?utf-8?B?KzBFVUs1elVoTkpqdllrM1dNbDdZU1R3blBRWFJLREpGbk1nZm1sblUxa2pI?= =?utf-8?B?Z3FkQXBwT09La2M0QTlaRHIvdUtnVmd6VnJTZ2x3MnlmZ092NGM1THU0dlZO?= =?utf-8?B?WEVoSUk2TTNPaW1QeGZiVzh6RmEvZ2QxSS9JVHRIUUd5Y2xhR3JkWkJzZUZC?= =?utf-8?B?OEN3MTZWRG52VmhwWGdZalFlamY5TkhHMnlPTzBSY1ZOb0dWVmp1YXdFYVJu?= =?utf-8?B?dVBackY2VmpIcE5telVpa0FycDF5b1RDZ0ZaTS9IN2c0MGw2Mm5rL0d4L1Qv?= =?utf-8?B?bmYvbVpTR3BzSVEyWjl0WEc3QnkxTHU5djZib1BOemRqNVNydU1Yb0dJaXNQ?= =?utf-8?B?UDlVOGpWSTh5Y1dpS0F2clJ3ZWtWQmZ6SXlVcGJVR0N6SDdDWVlOVWlGOXZv?= =?utf-8?B?WStjYmxCVkV1RkFPcjVCTm52K0I5QXBHZkwxZm90MEEyRmJ0UmcvMDBsZEta?= =?utf-8?B?d2phQ2E0bGVDTUE2dGNhcTlZbm50cGw1M2FGOGJ6Skhkb1llZmNTMHo4czVo?= =?utf-8?B?ODYzU3VNQ1dFS2RYcmltUTVqTDUxM1FzcHZLSzJoc1ZETUdIT1E0SGhrMDhj?= =?utf-8?B?ZXRFN1Zyc2RoNjJBTnNHdjk2cEpISm9NOXpMT2VVa1l5K1hlYmE2VlM5SndK?= =?utf-8?B?bWFOYnd3OCtWbFZzSUFSQ1JXN1FEdGwwVDNxSHN2TFVDTlJMZjlQSXAxWjYr?= =?utf-8?B?SWFTWDdnMG5haFBGdHExczA0cjg5aFBnMmVnazF5S2V2Y2xWOTMwRjZHMERV?= =?utf-8?B?bjZzQncxUmF3RDJuUFFoNjYzVHJtVWwxbjNZVG50TFN4Y3NFeWJSNWFHeWZi?= =?utf-8?B?eUQ0dU9qWVNiTjAxdWwyM2ovb0g4TWlMN1FCVnNPcFJ4TCtBTVRMblh5VjZS?= =?utf-8?B?U1pMS1Q5WGRrTndSTWdPUk8xcWdRRVNpRUhENERNQzN2bndEdmhYK3MyQ05h?= =?utf-8?B?d1hKdWN2emVJRkpRT2xhaHM1SnJXMjdpUHBNY0xodmlkc0hHazgzQzA0MmJO?= =?utf-8?B?dk9BTzh3NGtNSTZibnR3VERHN3diQXgwOTVJNnBteG9NRElpeTd1TjFaUTVo?= =?utf-8?B?bE1mOWZOWm9od1RaWUZQY2h1UTZSUE15MzVBVVRmQkpzclV5Qk1INUlVN3JZ?= =?utf-8?B?RmVCV1dwckNIVUkrTTRrOTJLNE1hWUlTbFNCcXBJWnBVb3FteDFzbXlpS1ZB?= =?utf-8?B?MDdCempoS2VrZThScHVqV1FZYjUxU2IxTWNHMkFvaFQzbDNHNCtQMTFOZllj?= =?utf-8?B?NVRWQ3hXTDR0KzBQOVZmNEJZR0EwVkJOdTBuTGJ6K0lEYjRWU0tYb01JU0xZ?= =?utf-8?B?TzZKSWdmWDhMR3BkSVhReFp4dFZSay9MYTcrb2Q2WG5OU3RaSC9aeUpLRGNQ?= =?utf-8?B?WXZsRzVDSXJLTVpsZjMwR1ZtckU5cHZlMERJb1VKc0I4cGREa0ZoQ1NiUkdW?= =?utf-8?B?TENHZFMvSUNpdjUvU2VnaXR6MFZ3L2VmUzAwZHg5VC80eGRucUE2QzhibnFt?= =?utf-8?B?MUV5SjV2RkZKSWZEdzQwdUdTczZFemNMRTkvLzN4ZDZZQWF2djJ3Mkk4Rzdq?= =?utf-8?B?VUt2ZzZRMVVEbGxESENUZXVMcERJejh5SGVsck80VlcvYVo3MC9ZVXpaY3Nq?= =?utf-8?B?ZmFKbWNWMkxWSnAvWmRYNDZOUEVmL0c0cndxQ0F2cXdROVU4ZmlUT3BLN1Vk?= =?utf-8?B?eFovL3hQU1BINTd4dXdUbW1PdFo2SCs3eVFLcE93TlY3WDFlQ1lScWo1L2VC?= =?utf-8?B?Y3c2dExtRFNBUHMva0RKQ1hvZ1BUM0VFTnVUaUEyeWVyVXl2WEsyeFkyck1P?= =?utf-8?B?aERRczVkVXFZSi8xYWZTMEd0Y3lFSzdEam5IS0ExaGVDTVhadURtOHhlRGtt?= =?utf-8?B?NEh1dGp4Mmo0Mk1YdVBJZFJ5cGVTaE5ZR045V0t2TWVrRHhuYVRLNGt0UVpL?= =?utf-8?B?T3pvL0lZb3VqNTJuUjl3WWQrS01tUWtZZ2dYQUxMT3lVcjFia0tIUHd3dWtT?= =?utf-8?B?Ynl4ZkxPdWVGWXIrMUJHazNIamd4Nk5rVWlGWU15cXZ5d0F4bms5R0p3Y3NO?= =?utf-8?B?b1RnOHJnZnVGc3E0UVBMbHV4Qy9RaFEwb3BHRmN4QU4rZXV2NGYwUWowNEoz?= =?utf-8?B?ZFg0K3VCV29rVDNhcitkVkV0V2hOSnovNUJIVHBkUGZCbWRlTVYwMnZjYmZr?= =?utf-8?B?VWV6clpyQTJaUnBDendpbE5RTllpMVBqNTBteEkreTdiR2J5OXUzVTNZK3BQ?= =?utf-8?B?UE80dFdYTUR1MmcrZHpsd3Y3aGZnZ29EMzYxRXZxbW1DQWk0WDI2dzFOSzFI?= =?utf-8?Q?kMiEBFpvaS8qa+bU=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: efe6e20d-1489-4578-90fd-08da3552407c X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2022 02:34:21.3731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gU7pW8pRwHFuCXIBuUG3P1X1VIGpe3DICoh+sj/CmsPvmqsR8A01nCObhV65O2U5dDCvVU+f3s1VN2u5NgjPKZhW8WDJo56cirkEp5YB4o8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4825 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-13_08:2022-05-13,2022-05-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205140012 X-Proofpoint-GUID: GN7K3KiDBj9kiXHe3DJ6yk4_YdSpBSqj X-Proofpoint-ORIG-GUID: GN7K3KiDBj9kiXHe3DJ6yk4_YdSpBSqj On 5/13/22 1:33 AM, Juergen Gross wrote: > On 12.05.22 22:01, Boris Ostrovsky wrote: >> >> On 5/7/22 2:19 PM, Oleksandr Tyshchenko wrote: >>> +/* Rebuilds the free grant list and tries to find count consecutive entries. */ >>> +static int get_free_seq(unsigned int count) >>> +{ >>> +    int ret = -ENOSPC; >>> +    unsigned int from, to; >>> +    grant_ref_t *last; >>> + >>> +    gnttab_free_tail_ptr = &gnttab_free_head; >>> +    last = &gnttab_free_head; >>> + >>> +    for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); >>> +         from < gnttab_size; >>> +         from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { >>> +        to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, >>> +                    from + 1); >>> +        if (ret < 0 && to - from >= count) { >>> +            ret = from; >>> +            bitmap_clear(gnttab_free_bitmap, ret, count); >>> +            from += count; >>> +            gnttab_free_count -= count; >> >> >> IIUIC we can have multiple passes over this, meaning that the gnttab_free_count may be decremented more than once. Is that intentional? > > After the first pass decrementing gnttab_free_cnt, ret will no > longer be less than zero, so this can be hit only once. Oh, yes, of course. > >> >> >>> +            if (from == to) >>> +                continue; >>> +        } >>> + >>> +        while (from < to) { >>> +            *last = from; >>> +            last = __gnttab_entry(from); >>> +            gnttab_last_free = from; >>> +            from++; >>> +        } >> >> >> I have been looking at this loop and I can't understand what it is doing ;-( Can you enlighten me? > > It is recreating the free list in order to have it properly sorted. > This is needed to make sure that the free tail has the maximum > possible size (you can take the tail off the list without having > to worry about breaking the linked list because of references into > the tail). So let's say we have the (one-dimensional) table of length 13 idx .. 2 3 ... 10 11 12 grant 12 11 2 -1 3 and gnttab_free_head is 10. I.e. the free list is 2, 12, 3, 11. What will this look like after the 2 iterations of the outer loop? (I am really having a mental block on this). -boris From xen-devel-bounces@lists.xenproject.org Sat May 14 03:15:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 03:15:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328933.552077 (Exim 4.92) (envelope-from ) id 1npiFh-0007pG-72; Sat, 14 May 2022 03:15:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328933.552077; Sat, 14 May 2022 03:15:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiFh-0007p9-4M; Sat, 14 May 2022 03:15:33 +0000 Received: by outflank-mailman (input) for mailman id 328933; Sat, 14 May 2022 03:15:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiFg-0007oz-45; Sat, 14 May 2022 03:15:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiFg-0007UA-2O; Sat, 14 May 2022 03:15:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiFf-00089L-Ml; Sat, 14 May 2022 03:15:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npiFf-0005p0-MJ; Sat, 14 May 2022 03:15:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uME6gNqwtC7tNsXAe4akvjU3+Q1sjzDUhZcMfYOx1S8=; b=SA9R042N4gttU1pFTF+OyhHYxu yBNpF+SrJBso41AKLOvoBqGAk4TITClhBQe9ukVtIrQCTY5Skdqqa8+fDMIERwEdb0VoIJMbgGblz SDa3Jj+noEkI2ADPJTggJuKO6JQn5F0g0mUniwHjukQPpiadFUYsWSCQITlL4HlqylKI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170405: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 03:15:31 +0000 flight 170405 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 990 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 03:36:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 03:36:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328943.552088 (Exim 4.92) (envelope-from ) id 1npiaK-0002AF-2j; Sat, 14 May 2022 03:36:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328943.552088; Sat, 14 May 2022 03:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiaJ-0002A7-VK; Sat, 14 May 2022 03:36:51 +0000 Received: by outflank-mailman (input) for mailman id 328943; Sat, 14 May 2022 03:36:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiaI-00029V-CB; Sat, 14 May 2022 03:36:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiaI-0007pr-8q; Sat, 14 May 2022 03:36:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npiaH-0000sk-Pp; Sat, 14 May 2022 03:36:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npiaH-0003o7-PM; Sat, 14 May 2022 03:36:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nrTsXgb+cQr/2plAaKfxMRsGi0LXOP5F4UgbY2Jz4tQ=; b=PRym6g4HEN1GBUlCzZn83PqWGe w43hH4/wNp0byIm7HowM3NIF5u0ElgA0uUrkiD+jIkRv6XjAl9lY56wDmvRI7i0bcRHwfe04QcTVZ f71ZlanNSas2hO3TlLCSLWX0RIrJ0N6GWLzhNMstrDvyYvqhCM+/tpz2Z/Nna9k0Tdio=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170398: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=364a453ab9123f493edfa246798ce9eeda452bdb X-Osstest-Versions-That: linux=f3f19f939c11925dadd3f4776f99f8c278a7017b From: osstest service owner Date: Sat, 14 May 2022 03:36:49 +0000 flight 170398 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170398/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170380 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170380 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170380 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170380 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170380 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170380 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170380 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170380 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 364a453ab9123f493edfa246798ce9eeda452bdb baseline version: linux f3f19f939c11925dadd3f4776f99f8c278a7017b Last test of basis 170380 2022-05-13 04:33:38 Z 0 days Testing same since 170398 2022-05-13 17:40:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Andrew Morton Camel Guo Catalin Marinas Dave Airlie Eric Yang Guenter Roeck Hyeonggon Yoo <42.hyeyoo@gmail.com> Joel Savitz Joey Gouly Joonas Lahtinen Kalesh Singh Karol Herbst Kristina Martsenko Linus Torvalds Mark Brown Martyna Szapar-Mudlaw Mike Rapoport Naoya Horiguchi Nico Pache Niels Dossche Pavle Kotarac Randy Dunlap Richard Gong SeongJae Park Shreyas K K Tvrtko Ursulin Will Deacon Xu Yu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f3f19f939c11..364a453ab912 364a453ab9123f493edfa246798ce9eeda452bdb -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat May 14 04:58:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 04:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328952.552098 (Exim 4.92) (envelope-from ) id 1npjrI-0003Lk-37; Sat, 14 May 2022 04:58:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328952.552098; Sat, 14 May 2022 04:58:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npjrI-0003Ld-0A; Sat, 14 May 2022 04:58:28 +0000 Received: by outflank-mailman (input) for mailman id 328952; Sat, 14 May 2022 04:58:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npjrF-0003LN-R9; Sat, 14 May 2022 04:58:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npjrF-00016S-Mq; Sat, 14 May 2022 04:58:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npjrF-0005HZ-Ab; Sat, 14 May 2022 04:58:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npjrF-0003jS-A9; Sat, 14 May 2022 04:58:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/l1QXWyonHIGcSrH2xvsuvtjxG35tTKOvYF3qJwxid0=; b=WzaaIXNKk0K2n0k+3FAOkrEmSQ s5YkyCJVm9YHCNJ9qfWaRqZ+JqtL8giOU0jpBp+6K5A3rVhV1obvximCkuFasB7UG8SLTNl2my13i 9ChjYX34SiIdGofBDVf0Moo3hd834mbg+huciHlI0xF+fBtrQRvwryrKLQtrvjLGuS4c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170407: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 04:58:25 +0000 flight 170407 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170407/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 991 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 06:16:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 06:16:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328961.552110 (Exim 4.92) (envelope-from ) id 1npl4A-0003F8-Ny; Sat, 14 May 2022 06:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328961.552110; Sat, 14 May 2022 06:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npl4A-0003F1-Kw; Sat, 14 May 2022 06:15:50 +0000 Received: by outflank-mailman (input) for mailman id 328961; Sat, 14 May 2022 06:15:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npl48-0003Ec-FY; Sat, 14 May 2022 06:15:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npl48-0002pc-Df; Sat, 14 May 2022 06:15:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npl47-0001d4-VT; Sat, 14 May 2022 06:15:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npl47-0004gp-V3; Sat, 14 May 2022 06:15:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p8l6r1FLKIpnaLVES3rfvWNQvInidhwbnTD0D9iYJAI=; b=pZ6XXHkd9vQy3b5i0xhNeIZdM3 nRr7UpDWZRFpvzlUsxD9SpVtpo42Q7cAaNYri2Tm0gtgCWM2+x/UXI1Ua6HO0PsnHUJaOZOUdFnD2 z0yfNxQGFLvjWTEycImTRqj0bHcqkn60wyBoV0mjo4VNThVCpG5M9BbnDgZ+FJ+NAT14=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170409: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 06:15:47 +0000 flight 170409 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170409/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 992 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 06:52:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 06:52:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328971.552121 (Exim 4.92) (envelope-from ) id 1npldf-0007Xt-S5; Sat, 14 May 2022 06:52:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328971.552121; Sat, 14 May 2022 06:52:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npldf-0007Xm-OR; Sat, 14 May 2022 06:52:31 +0000 Received: by outflank-mailman (input) for mailman id 328971; Sat, 14 May 2022 06:52:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npldf-0007Xc-0E; Sat, 14 May 2022 06:52:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nplde-0003Sg-Tp; Sat, 14 May 2022 06:52:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nplde-0004RT-BP; Sat, 14 May 2022 06:52:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nplde-0006SZ-B4; Sat, 14 May 2022 06:52:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Us7ubNHSMMYjMcwYEVwqC7EIk6Vhhw0MMsQELDbqifA=; b=v/RkkGKDwP2Obvh3WWIwtMcT6B rU+bJyBJytrFSKcuNE8mU2clDoV2ngkNn10QP5O2D4FvOaZI+fazB8jWawwzq+avHtk90V5CXQxw1 s2Wn3JsfVbYGVvY71+6Exe/TztEQzKe247NM05rYhcnn2EpYx/L7AinGtz76DaUW2cUM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170400: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt:xen-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=48de9b0916ef60d5a6bd6ca9288832deff8ee1ee X-Osstest-Versions-That: qemuu=9de5f2b40860c5f8295e73fea9922df6f0b8d89a From: osstest service owner Date: Sat, 14 May 2022 06:52:30 +0000 flight 170400 qemu-mainline real [real] flight 170410 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170400/ http://logs.test-lab.xenproject.org/osstest/logs/170410/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 170374 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170374 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170374 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170374 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170374 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170374 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170374 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170374 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170374 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee baseline version: qemuu 9de5f2b40860c5f8295e73fea9922df6f0b8d89a Last test of basis 170374 2022-05-13 01:09:17 Z 1 days Testing same since 170400 2022-05-13 19:08:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Williamson Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee Merge: 9de5f2b408 e4082063e4 Author: Richard Henderson Date: Fri May 13 09:45:17 2022 -0700 Merge tag 'linux-headers-v5.18-rc6' of https://gitlab.com/alex.williamson/qemu into staging * Linux header update to v5.18-rc6 and vfio file massaging (Alex Williamson) # -----BEGIN PGP SIGNATURE----- # # iQJPBAABCAA5FiEEQvbATlQL0amee4qQI5ubbjuwiyIFAmJ+ajgbHGFsZXgud2ls # bGlhbXNvbkByZWRoYXQuY29tAAoJECObm247sIsiqVUQAJV8iZ7UrgX9LpCo/kBg # VuPdzv8NVoaxe33FkkMlJYIcm1wCIC+lc/nKczkJg5rdfD4/E0oNyv8DER+2q2jC # Q94nq3CoSwnbNeRaAc6dcA/Hg9VL5VAwE8S/raDt+DbCBndR0o7zejm2CHZIYPxF # GZXgexNThYcSjNsfkP2Sju/SwjWSFRHXFeTg5P6BOm2qWVGMNmvlnarPTffWOC0Y # 6sT2VUykzahVSro5WxyuLdH114KI8QRZzSybMkLMpt3uaxZsFoAhO4FYZX4owiUn # rSoHS0am86KCRG3msD8UjKKy/R4dP0hXW41xAr4HwRZWouNtwGJVtd1mA6kF5euL # 23dQwSQeHvgFx0gY0FiFih/shZ24qvTDZDz8hNqgi3q42Tv8upghAyWL7v/aPpsy # 94RH3eNSBkNEvWdK/e40LpuN14voRMLov4XcVirP2kbBFWoU4SSIZmASSLG/OeQn # tQLatE53SMiXBabMRKeVCiyMxnoUtOd8fe97XFEONFIEU0NOABt5Zoldtbq4kwoQ # tcUydKB66df3uWccb6Tpl3V7h6b8sBL8trfBUD1qANjcDbEzQVUVBTmg+DRwzs8d # HQ4f6YQaJoyZlVDgC8GVA268ubAam8FEz1piro4gz8MaZJCeCdx5Teec0yCwjBL+ # IlNS08zjV5fHFZuMPd/qswjk # =gegh # -----END PGP SIGNATURE----- # gpg: Signature made Fri 13 May 2022 07:24:56 AM PDT # gpg: using RSA key 42F6C04E540BD1A99E7B8A90239B9B6E3BB08B22 # gpg: issuer "alex.williamson@redhat.com" # gpg: Good signature from "Alex Williamson " [undefined] # gpg: aka "Alex Williamson " [undefined] # gpg: aka "Alex Williamson " [undefined] # gpg: aka "Alex Williamson " [undefined] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B 8A90 239B 9B6E 3BB0 8B22 * tag 'linux-headers-v5.18-rc6' of https://gitlab.com/alex.williamson/qemu: linux-headers: Update to v5.18-rc6 Signed-off-by: Richard Henderson commit e4082063e47e9731dbeb1c26174c17f6038f577f Author: Alex Williamson Date: Fri May 13 08:20:08 2022 -0600 linux-headers: Update to v5.18-rc6 Update to c5eb0a61238d ("Linux 5.18-rc6"). Mechanical search and replace of vfio defines with white space massaging. Signed-off-by: Alex Williamson From xen-devel-bounces@lists.xenproject.org Sat May 14 08:32:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 08:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328986.552140 (Exim 4.92) (envelope-from ) id 1npnBr-0001AL-MI; Sat, 14 May 2022 08:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328986.552140; Sat, 14 May 2022 08:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npnBr-0001AE-Jh; Sat, 14 May 2022 08:31:55 +0000 Received: by outflank-mailman (input) for mailman id 328986; Sat, 14 May 2022 08:31:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npnBq-0001A4-PK; Sat, 14 May 2022 08:31:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npnBq-0005hi-OR; Sat, 14 May 2022 08:31:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npnBq-0008DV-7D; Sat, 14 May 2022 08:31:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npnBq-0006Mu-6q; Sat, 14 May 2022 08:31:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sPCtjLB6M730F9gJ5UzU/7BtSNmUCemU/YmS0gdTmWQ=; b=Y1qzXWjNgI0nQ7N6/2eRTZ9V+C 91FSKsZ/kiAfSQOVHkK8+nja9juKxqKmtS6cumh5OP4xOpFUesb2hIFRCiMFOc1fafBnxUUW4TBch YXwu1o2cm+6Bc7DG5ISRIEgweMF500ZN2S7XR+rhQoH08IaT59CguHYacAGuZn8rnvHk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170411: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 08:31:54 +0000 flight 170411 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 993 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 09:33:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 09:33:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.328997.552152 (Exim 4.92) (envelope-from ) id 1npo91-0007QH-JB; Sat, 14 May 2022 09:33:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 328997.552152; Sat, 14 May 2022 09:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npo91-0007QA-EM; Sat, 14 May 2022 09:33:03 +0000 Received: by outflank-mailman (input) for mailman id 328997; Sat, 14 May 2022 09:33:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npo8z-0007Q0-Ff; Sat, 14 May 2022 09:33:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npo8z-0006ih-Be; Sat, 14 May 2022 09:33:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npo8y-00045x-UP; Sat, 14 May 2022 09:33:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npo8y-0007Pa-U1; Sat, 14 May 2022 09:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=22XxWPFLLKOR8f94Lh/GVt9QAfboURzHchHkVOzqH6M=; b=du85tHE8J1f/6gTJq+Ct1ZgFLg zRXbqOBrdZYl1gD2BOE2DflnrqSiY7JG2IGIJMOVyTHSoqVFhbg0FAGjV7078drjcpJTm79dLqvXm Q06LGDuCwlEsfTZEJWH+ESHKR1OaGeB4kPvX4/ImwrsQYWK2xbaQwFDXQKTJKlPMpljU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170415: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 09:33:00 +0000 flight 170415 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170415/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 994 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 09:43:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 09:43:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329006.552162 (Exim 4.92) (envelope-from ) id 1npoIb-0000V3-IJ; Sat, 14 May 2022 09:42:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329006.552162; Sat, 14 May 2022 09:42:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoIb-0000Uw-FO; Sat, 14 May 2022 09:42:57 +0000 Received: by outflank-mailman (input) for mailman id 329006; Sat, 14 May 2022 09:42:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoIZ-0000Un-P4 for xen-devel@lists.xenproject.org; Sat, 14 May 2022 09:42:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoIZ-0006tj-F8; Sat, 14 May 2022 09:42:55 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npoIZ-0006sy-95; Sat, 14 May 2022 09:42:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=oIDlj52g1MF3vOuZyycDBzSjmrx0tFAuuA+z+XxJFlE=; b=HS2M+EhB80QprHnAgRKZNpJCzI cxDUQtQRvzE3j0s38/7OvP8Algn0e00N/2WFNBByxZ1CMnf20KMyQAEzM8uzso4FuM4jHhKALv/5i mkzt02qIftxDkht3FZBeWMzL91oaRZcmOzTq9kxQLg3FdZT0QHzW0+m+/6dvqZNoQNRw=; Message-ID: <67fc612a-136a-bc20-6725-ff2c5c1917e2@xen.org> Date: Sat, 14 May 2022 10:42:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 10/19] xen/arm32: mm: Re-implement setup_xenheap_mappings() using map_pages_to_xen() To: xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-11-julien@xen.org> From: Julien Grall In-Reply-To: <20220221102218.33785-11-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/02/2022 10:22, Julien Grall wrote: > From: Julien Grall > > Now that map_pages_to_xen() has been extended to support 2MB mappings, > we can replace the create_mappings() call by map_pages_to_xen() call. > > Signed-off-by: Julien Grall > > --- > Changes in v3: > - Fix build when CONFIG_DEBUG=y > > Changes in v2: > - New patch > > TODOs: > - add support for contiguous mapping This todo was a left-over because _PAGE_BLOCK will try to use the contiguous bit (see patch #5). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 09:52:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 09:52:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329013.552174 (Exim 4.92) (envelope-from ) id 1npoRs-0001zj-IQ; Sat, 14 May 2022 09:52:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329013.552174; Sat, 14 May 2022 09:52:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoRs-0001zc-DS; Sat, 14 May 2022 09:52:32 +0000 Received: by outflank-mailman (input) for mailman id 329013; Sat, 14 May 2022 09:52:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoRr-0001zS-Nz; Sat, 14 May 2022 09:52:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoRr-000749-KU; Sat, 14 May 2022 09:52:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npoRr-0004yc-2L; Sat, 14 May 2022 09:52:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npoRr-0000HF-1u; Sat, 14 May 2022 09:52:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GnWcxYrMwYLzFGLieyHRn6jpObW6XZ7493gD8mIjBsA=; b=apGRS+Snjdhpko8Dw9JJKBynaO 8hUxM2w+QwsbwDYPHhK32YpqN/SFAKZNdaBjiRoDTvjKHU/0LTXYq1fCTSHGrSy7LZvFN32q1oEdF j4ZYPMN3zTBtrycTYgXWSVtctVBB9Z85YHPINR+Yp72KfTq5Joaipe5EIAR1H55tLTAQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170404: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-coresched-i386-xl:debian-fixup:fail:heisenbug xen-unstable:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Sat, 14 May 2022 09:52:31 +0000 flight 170404 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170404/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 170385 pass in 170404 test-amd64-coresched-i386-xl 13 debian-fixup fail in 170385 pass in 170404 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail pass in 170385 Tests which did not succeed, but are not blocking: test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 170385 like 170370 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170385 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170385 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170385 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170385 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170385 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170385 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170385 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170385 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170385 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170385 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170385 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170385 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170404 2022-05-14 01:54:42 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat May 14 10:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 10:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329023.552185 (Exim 4.92) (envelope-from ) id 1npobJ-0003do-Kq; Sat, 14 May 2022 10:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329023.552185; Sat, 14 May 2022 10:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npobJ-0003dh-Hp; Sat, 14 May 2022 10:02:17 +0000 Received: by outflank-mailman (input) for mailman id 329023; Sat, 14 May 2022 10:02:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npobI-0003db-NX for xen-devel@lists.xenproject.org; Sat, 14 May 2022 10:02:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npobI-0007Jk-DA; Sat, 14 May 2022 10:02:16 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npobI-000874-7c; Sat, 14 May 2022 10:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lDYAh5SHq6K31T6rUjOD31ohrVwQITpLtMsYZeN/f7w=; b=ApT1Kque4oHkPT5UQfVFvn3lQT l1h0in7bxnBicNfxUFBTBcbqcbRmWgUAqB8wJ7hqvVfcF15KSfecpPPZZafUXLF+d/ydiizutyhFq oKVAtL5XQEL3uP6u/4VpdduToIqOte4TKZHCYMaJ7MCuDW0l72QrVra9shBUF90V6nGg=; Message-ID: Date: Sat, 14 May 2022 11:02:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 19/19] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen() To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-20-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 06/04/2022 01:01, Stefano Stabellini wrote: > On Mon, 21 Feb 2022, Julien Grall wrote: >> frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); >> /* Round up to 2M or 32M boundary, as appropriate. */ >> frametable_size = ROUNDUP(frametable_size, mapping_size); >> base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); >> >> -#ifdef CONFIG_ARM_64 >> - /* Compute the number of second level pages. */ >> - nr_second = ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT; >> - second_base = alloc_boot_pages(nr_second, 1); >> - second = mfn_to_virt(second_base); >> - for ( i = 0; i < nr_second; i++ ) >> - { >> - clear_page(mfn_to_virt(mfn_add(second_base, i))); >> - pte = mfn_to_xen_entry(mfn_add(second_base, i), MT_NORMAL); >> - pte.pt.table = 1; >> - write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte); >> - } >> - create_mappings(second, 0, mfn_x(base_mfn), frametable_size >> PAGE_SHIFT, >> - mapping_size); >> -#else >> - create_mappings(xen_second, FRAMETABLE_VIRT_START, mfn_x(base_mfn), >> - frametable_size >> PAGE_SHIFT, mapping_size); >> -#endif >> + rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, >> + frametable_size >> PAGE_SHIFT, PAGE_HYPERVISOR_RW); > > Doesn't it need to be PAGE_HYPERVISOR_RW | _PAGE_BLOCK ? You are right. Otherwise, it would only use small pages. I will fix it in the next version. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 10:17:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 10:17:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329030.552195 (Exim 4.92) (envelope-from ) id 1npopj-0005Ga-Vj; Sat, 14 May 2022 10:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329030.552195; Sat, 14 May 2022 10:17:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npopj-0005GT-Sn; Sat, 14 May 2022 10:17:11 +0000 Received: by outflank-mailman (input) for mailman id 329030; Sat, 14 May 2022 10:17:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npopi-0005GN-2Z for xen-devel@lists.xenproject.org; Sat, 14 May 2022 10:17:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npopg-0007Zx-UF; Sat, 14 May 2022 10:17:08 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npopg-0000al-NT; Sat, 14 May 2022 10:17:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=RzxzoxRqkI3amrqgxzwZsVJofbqkBwiBCm0zGv46f6c=; b=0MFgZEgobD+W7djbQopj50+CL3 tO/sPtDCfiy2ZQf2L2DZs6+Pdp9seMWmxl/VVe4MK9ThFH3ONRgWvhTCNgA/RojvU1xWkOlMtJe7h k7i/rRN7aps9Oa6DClnCy5Znrhy65XS/CWMFmLsYKErcXwElNpXXGJDpcFm+VwMoR1/o=; Message-ID: Date: Sat, 14 May 2022 11:17:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Wei Liu , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220221102218.33785-1-julien@xen.org> <20220221102218.33785-15-julien@xen.org> From: Julien Grall Subject: Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/04/2022 22:27, Stefano Stabellini wrote: > On Mon, 21 Feb 2022, Julien Grall wrote: >> diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h >> new file mode 100644 >> index 000000000000..70eafe2891d7 >> --- /dev/null >> +++ b/xen/arch/arm/include/asm/pmap.h >> @@ -0,0 +1,33 @@ >> +#ifndef __ASM_PMAP_H__ >> +#define __ASM_PMAP_H__ >> + >> +#include >> + >> +/* XXX: Find an header to declare it */ >> +extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES]; > > Why not fixmap.h? I wanted to find a helper that would only get included by pmap.c and mm.c, this would help to prevent someone to use xen_fixmap[] directly. Anyway, I am OK with fixmap.h and we will rely on review to catch any new user of xen_fixmap. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 10:29:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 10:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329038.552210 (Exim 4.92) (envelope-from ) id 1npp18-0006rF-46; Sat, 14 May 2022 10:28:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329038.552210; Sat, 14 May 2022 10:28:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npp17-0006r8-Vt; Sat, 14 May 2022 10:28:57 +0000 Received: by outflank-mailman (input) for mailman id 329038; Sat, 14 May 2022 10:28:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npp16-0006qy-2Y; Sat, 14 May 2022 10:28:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npp16-0007lD-1j; Sat, 14 May 2022 10:28:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npp15-0006sb-NT; Sat, 14 May 2022 10:28:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npp15-0000WF-N1; Sat, 14 May 2022 10:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lL1vPGpCZV79wv4FoHJv15b4hM51Vo+QVQyzBrTpkps=; b=Nu/uk4lQLGiE18pueOeambSYIP +rAAoZB+0uqc3Dlt8ixGfB8t1fEWbSdhbFfY7kDtN0rvW8tDWKo0VQSiwnLpllJyRPBggIKPafvzC GUtF4I/zjFRMsz5d2rcdAtu2yGJUIzAJCorriSIl8itUfzTFL0PncHlfenbVELr24K1A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170416: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 10:28:55 +0000 flight 170416 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 74 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 995 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 11:37:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 11:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329047.552220 (Exim 4.92) (envelope-from ) id 1npq4y-00062E-5T; Sat, 14 May 2022 11:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329047.552220; Sat, 14 May 2022 11:37:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npq4y-000627-2C; Sat, 14 May 2022 11:37:00 +0000 Received: by outflank-mailman (input) for mailman id 329047; Sat, 14 May 2022 11:36:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npq4v-00061x-TF; Sat, 14 May 2022 11:36:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npq4v-0000TA-RV; Sat, 14 May 2022 11:36:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npq4v-0000SJ-Gm; Sat, 14 May 2022 11:36:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npq4v-0007V4-GH; Sat, 14 May 2022 11:36:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FJJOyYPfqQgdxy84LlgmUbmXRQ+UzdfyhtusEbXA8LE=; b=gtTfFc456Zbw5t2GOow5Q5/j4c /cJ5jjad8VulSE1Y8jgILvS8gsdv9lmHEMdaxk6A0kOR6QF0jchCV9+HWvnh52CHjXABedsiEhX3t uA+Qh8j8K8RgOZJcCo+DT4are5Fp+eay6WG7/nPJfIfrcVWQo+xOiJJVQe2qbZ/3ihjM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170417: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 11:36:57 +0000 flight 170417 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170417/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 996 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 11:49:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 11:49:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329056.552232 (Exim 4.92) (envelope-from ) id 1npqHR-0007aj-A1; Sat, 14 May 2022 11:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329056.552232; Sat, 14 May 2022 11:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqHR-0007ac-7P; Sat, 14 May 2022 11:49:53 +0000 Received: by outflank-mailman (input) for mailman id 329056; Sat, 14 May 2022 11:49:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqHQ-0007aC-8E; Sat, 14 May 2022 11:49:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqHQ-0000gT-0q; Sat, 14 May 2022 11:49:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqHP-0000s0-Mo; Sat, 14 May 2022 11:49:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npqHP-0007Oh-MK; Sat, 14 May 2022 11:49:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NaAg/2Hw0houOi2z2n+D6rwW3hDyG30LsVzjWrDHgB4=; b=cqWz0cl2Q/7jOFi5aizAqy46+r KX8q4v2K9fLnAFXvG/rdH3LpLtESWSsHmTRQbkta+/D2zwEdcEaxy8RaP15OlIQP0eGw+Mi61DtU5 qswMNuMRIMRjpSLtSDrNYrcTlb4JriFnhbvhxjasUVPXLjwDy+Gh0taN36sIQh6VFbgA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170408: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 14 May 2022 11:49:51 +0000 flight 170408 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170408/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 673 days Failing since 151818 2020-07-11 04:18:52 Z 672 days 654 attempts Testing same since 170408 2022-05-14 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107373 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 12:13:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 12:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329066.552242 (Exim 4.92) (envelope-from ) id 1npqeH-0002ZH-Cg; Sat, 14 May 2022 12:13:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329066.552242; Sat, 14 May 2022 12:13:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqeH-0002ZA-9z; Sat, 14 May 2022 12:13:29 +0000 Received: by outflank-mailman (input) for mailman id 329066; Sat, 14 May 2022 12:13:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqeF-0002Z0-RT; Sat, 14 May 2022 12:13:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqeF-00015X-OW; Sat, 14 May 2022 12:13:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npqeF-0001UZ-6r; Sat, 14 May 2022 12:13:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npqeF-000744-6N; Sat, 14 May 2022 12:13:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=txcln70Nq/D8+pwtgOSPHM7WUSlASc8TGgcTlov2mDc=; b=qtoKeo1OAKGwbRL5+abKGLdaPI hQaRsJBmBw6Zr/N5GXB2EdtVAol1g6ue9OhmGbw7lLeVrSJ2cBDS/ofPjs9H/z/aaJ4jnnr+7thhY nbU4qw44HWqID8O2MHn6tsyw8KnqontlXbZhru4qzdMkzPo82dva/uAx+ExB6jczuup8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170418: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 12:13:27 +0000 flight 170418 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 997 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 13:06:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 13:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329075.552254 (Exim 4.92) (envelope-from ) id 1nprTj-0007wV-Bn; Sat, 14 May 2022 13:06:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329075.552254; Sat, 14 May 2022 13:06:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprTj-0007wO-8V; Sat, 14 May 2022 13:06:39 +0000 Received: by outflank-mailman (input) for mailman id 329075; Sat, 14 May 2022 13:06:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprTi-0007wI-AC for xen-devel@lists.xenproject.org; Sat, 14 May 2022 13:06:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprTg-00020m-9i; Sat, 14 May 2022 13:06:36 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nprTg-0002Rb-2x; Sat, 14 May 2022 13:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bhn4celzkp1QwZWv5cHzokUF7d7iePo2sJ0e2lfx9eA=; b=aMRx/gAcz8vazslbwVL7dkX2qh Z7/NnKlenILg9RuH1r36EGacNtOJBqZ08CJOmmtpib+rEFJMhMtfHn77cQimCNTkfiWJ/vx38bI6O f9ouO3SWf9crUwBKVvJWL4MammJZ2zBbxBfevO7+sMr29yr9foCEa8TkV1CGVUEPTOVY=; Message-ID: Date: Sat, 14 May 2022 14:06:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v6 4/7] xen/arm: configure dom0less domain for enabling xenstore after boot To: Stefano Stabellini Cc: Bertrand Marquis , Rahul Singh , xen-devel , Juergen Gross , "Volodymyr_Babchuk@epam.com" , Luca Miccio , Stefano Stabellini , "jbeulich@suse.com" References: <20220505001656.395419-4-sstabellini@kernel.org> <8011EAE7-7DF6-4342-B0BF-F64190099BA0@arm.com> <37C437B0-BF87-41C0-8FF1-0BF193C667C4@arm.com> <0f39d464-5a2c-a8f6-04c8-f96da7340003@xen.org> <4BEDB555-12F4-4A91-8D16-D83DBB1BE3CC@arm.com> <34b790af-c56a-26c7-e218-7961023b8605@xen.org> <7f89af03-66d2-9c59-a761-4c8a188570d9@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 13/05/2022 21:52, Stefano Stabellini wrote: > On Fri, 13 May 2022, Julien Grall wrote: >> On 13/05/2022 02:23, Stefano Stabellini wrote: >>> On Wed, 11 May 2022, Julien Grall wrote: >>>>> If dom0 is mandatory yes, we should still make sure that this code >>>>> cannot be >>>>> reached so an ASSERT would be nice here at least in case someone tries >>>>> to >>>>> activate this code without dom0 (which might happen when we will push >>>>> the >>>>> serie for static event channels). >>>> >>>> I am fine with an ASSERT(). >>> >>> I added an ASSERT(hardware_domain). >> >> Just to clarify and avoid a round trip. The ASSERT() is not sufficient here. >> We also need to forbid the user to set xen,enhanced when the HW domain is not >> NULL, at least until Rahul's pre-allocated event channel series. >> >> This check would have to be done when parsing the configuration. The ASSERT() >> would be here to ensure that if someone is reworking the parsing, it would get >> caught nicely rather than a NULL dereference. > > Thanks for avoiding a roundtrip. I added a check when parsing device > tree if xen,enhanced is specified but dom0 is missing. Initially I wrote > it as a "panic" but then I changed it as a regular printk. I am OK > either way in case you prefer otherwise. This is a configuration issue from the user. So I think we shouldn't continue (i.e panic()) if we can't honor what the user requested. This make the problem a lot more obvious to the user (printk() can be easily overlooked). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 13:23:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 13:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329082.552264 (Exim 4.92) (envelope-from ) id 1nprjg-0001xU-Or; Sat, 14 May 2022 13:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329082.552264; Sat, 14 May 2022 13:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprjg-0001xN-Ln; Sat, 14 May 2022 13:23:08 +0000 Received: by outflank-mailman (input) for mailman id 329082; Sat, 14 May 2022 13:23:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprje-0001xH-Qd for xen-devel@lists.xenproject.org; Sat, 14 May 2022 13:23:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprje-0002I1-CW; Sat, 14 May 2022 13:23:06 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nprje-0003Qk-5k; Sat, 14 May 2022 13:23:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=rAaL0YyQ50BFIgh8ZTQTnXJacUlZgAiT4TvkfreFlmw=; b=vc0JQ3gUZJITDWgFI7fXopj5LK 3TatdKXETqkjq/Tjy9liObQyrgG6cEZHgshCce7msL6L0Z8sgzx4A+GithzuMlpEavTs9V9vB7n4W SzbinkgZJbBgqZmqw5qcI28e8DmNN/gNkLLB/2arWOseu58gOmweVsnlSmwZGRf6UsH8=; Message-ID: <898455df-f076-46ac-0c86-d11b3e9e5905@xen.org> Date: Sat, 14 May 2022 14:23:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Stefano Stabellini References: <20220513210730.679871-3-sstabellini@kernel.org> From: Julien Grall Subject: Re: [PATCH v7 3/7] xen: introduce xen,enhanced dom0less property In-Reply-To: <20220513210730.679871-3-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 13/05/2022 22:07, Stefano Stabellini wrote: > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c4dd211b91..8d148b209d 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3157,6 +3157,7 @@ static int __init construct_domU(struct domain *d, > const struct dt_device_node *node) > { > struct kernel_info kinfo = {}; > + const char *dom0less_enhanced; > int rc; > u64 mem; > > @@ -3172,6 +3173,17 @@ static int __init construct_domU(struct domain *d, > > kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); > > + rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced); > + if ( rc == -EILSEQ || > + rc == -ENODATA || > + (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) > + { > + if ( hardware_domain ) > + kinfo.dom0less_enhanced = true; > + else > + printk("Error: tried to use xen,enhanced without dom0\n"); In general, I prefer if we fail early for configuration error because this makes a lot more obvious what the issue is. So I would switch to panic() and drop "Error:". This can be done on commit: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 13:30:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 13:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329089.552275 (Exim 4.92) (envelope-from ) id 1nprqk-0003Oi-F9; Sat, 14 May 2022 13:30:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329089.552275; Sat, 14 May 2022 13:30:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprqk-0003Ob-CI; Sat, 14 May 2022 13:30:26 +0000 Received: by outflank-mailman (input) for mailman id 329089; Sat, 14 May 2022 13:30:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprqj-0003OR-4w; Sat, 14 May 2022 13:30:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprqj-0002Op-2G; Sat, 14 May 2022 13:30:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nprqi-0003KD-Ni; Sat, 14 May 2022 13:30:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nprqi-000237-NI; Sat, 14 May 2022 13:30:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PzI8gaPQBxNGLvwXE2yloeQr4YFBetY3WfCmT/ZB+9A=; b=lyK8T2HmWptpuwlzAAbYWu0S+o iiYevDAZj9GutfyU43WhpWT7a4TM6Nx/ZGykxSY3DFJ9mXo4Lq6Gnulqkn01BQIGhLFVOeJwPaUxr v0NVRB0HFlWFkZ3T55NhTNNSuXTufg4VNqSLHgIKWFi7f1+KaD7WCTr7QYCmOUXltIYI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170420: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 13:30:24 +0000 flight 170420 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170420/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 998 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 14:17:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 14:17:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329098.552287 (Exim 4.92) (envelope-from ) id 1npsZr-00089q-4M; Sat, 14 May 2022 14:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329098.552287; Sat, 14 May 2022 14:17:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsZr-00089j-0T; Sat, 14 May 2022 14:17:03 +0000 Received: by outflank-mailman (input) for mailman id 329098; Sat, 14 May 2022 14:17:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsZp-00089Z-37; Sat, 14 May 2022 14:17:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsZo-0003HV-V3; Sat, 14 May 2022 14:17:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsZo-0004be-Cr; Sat, 14 May 2022 14:17:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npsZo-0005iZ-CN; Sat, 14 May 2022 14:17:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WahaZ73zyhq9pEnttM63QKvFl0L3f3+5dJV2LoEOgJs=; b=kXIQJ9QmNRva9fIhnlI8J7nUd8 AJ4mgkn/2LYxrrYqXgdq2WYoN5STL2EUmkugtBF7rcdKpDQjnK3S8DtyKaVR7GDlsmBAT3TtQCRZN zW7EOU1EQOYC276YfDqmQfXoM+YILY27HtRDtWo87efIc0lu8/8Td50h1xbnbUuZEGOw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170406: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ec7f49619d8ee13e108740c82f942cd401b989e9 X-Osstest-Versions-That: linux=364a453ab9123f493edfa246798ce9eeda452bdb From: osstest service owner Date: Sat, 14 May 2022 14:17:00 +0000 flight 170406 linux-linus real [real] flight 170419 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170406/ http://logs.test-lab.xenproject.org/osstest/logs/170419/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 8 xen-boot fail pass in 170419-retest test-armhf-armhf-xl 8 xen-boot fail pass in 170419-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 19 guest-start.2 fail REGR. vs. 170398 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 170419 like 170398 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 170419 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 170419 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 170419 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170398 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170398 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170398 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170398 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170398 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170398 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170398 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux ec7f49619d8ee13e108740c82f942cd401b989e9 baseline version: linux 364a453ab9123f493edfa246798ce9eeda452bdb Last test of basis 170398 2022-05-13 17:40:57 Z 0 days Testing same since 170406 2022-05-14 03:40:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andreas Gruenbacher Brian Bunker Charan Teja Reddy Christian König Christophe JAILLET Dan Aloni Daniel Vetter Daniel Vetter Dave Airlie Dick Kennedy Gleb Chesnokov Hui Tang Ilya Dryomov James Smart Javier Martinez Canillas Jeff Layton Justin Tee Krishna Kant Linus Torvalds Lucas De Marchi Lyude Paul Maarten Lankhorst Martin K. Petersen Maxime Ripard Robin Murphy Seamus Connor T.J. Mercier Trond Myklebust Xiubo Li Zack Rusin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 364a453ab912..ec7f49619d8e ec7f49619d8ee13e108740c82f942cd401b989e9 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat May 14 14:17:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 14:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329102.552298 (Exim 4.92) (envelope-from ) id 1npsaD-0008WH-Kd; Sat, 14 May 2022 14:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329102.552298; Sat, 14 May 2022 14:17:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsaD-0008WA-HC; Sat, 14 May 2022 14:17:25 +0000 Received: by outflank-mailman (input) for mailman id 329102; Sat, 14 May 2022 14:17:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsaC-0008VL-E1; Sat, 14 May 2022 14:17:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsaC-0003Hs-DF; Sat, 14 May 2022 14:17:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npsaB-0004c3-UK; Sat, 14 May 2022 14:17:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npsaB-0005kf-Tw; Sat, 14 May 2022 14:17:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mwLU89lkSeNWdi3ahziyPn4DjjzGEQwtQ17+M6K3pL8=; b=6E3pWOGN7fP0qo1QhjvFinmVbD DnivmgdIZ26kf0vvXYCdCyZpAfoBIDb+lL7VhgEeIcQfeAFm1vBqG6USAm44HJIevGTxdIHyCz3R8 Yh3SmEf7lA5xceHpmRyww/tkA1+Iz4cDBcoUM58dHOg07setdOUVqZq1V3E3Jy2jqdVM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170421: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 14:17:23 +0000 flight 170421 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170421/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 999 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 15:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 15:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329117.552309 (Exim 4.92) (envelope-from ) id 1nptmz-0008RT-7K; Sat, 14 May 2022 15:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329117.552309; Sat, 14 May 2022 15:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nptmz-0008RM-3r; Sat, 14 May 2022 15:34:41 +0000 Received: by outflank-mailman (input) for mailman id 329117; Sat, 14 May 2022 15:34:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nptmy-0008RC-JO; Sat, 14 May 2022 15:34:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nptmy-0004YX-Gv; Sat, 14 May 2022 15:34:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nptmx-0006WS-Rw; Sat, 14 May 2022 15:34:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nptmx-0001bf-RU; Sat, 14 May 2022 15:34:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nvp67LnQkJwXbS4sNb2QhyNIPlQZAL1NDQjFDZYUjHA=; b=kFFCLyHg/K2jH5+JJ7Kknht6zX /bWELpK9+zTgQhoNFAwVhj6PEq+B+h3tccUx6+5HRpKLnPL449a1Z+bcuv75Mv4RNCo+iwEOBsOv/ C3PMdM+z7Co8djF5btxiNWm1Kw+1io7tmQB+tkjfPHzDsbSZ1MVzvlXwtBoQu2s1spa4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170422: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 15:34:39 +0000 flight 170422 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170422/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1000 attempts Testing same since 170392 2022-05-13 15:40:22 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 16:06:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 16:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329126.552320 (Exim 4.92) (envelope-from ) id 1npuHr-0003vh-Ov; Sat, 14 May 2022 16:06:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329126.552320; Sat, 14 May 2022 16:06:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuHr-0003va-LR; Sat, 14 May 2022 16:06:35 +0000 Received: by outflank-mailman (input) for mailman id 329126; Sat, 14 May 2022 16:06:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuHq-0003vU-42 for xen-devel@lists.xenproject.org; Sat, 14 May 2022 16:06:34 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d118f0f3-d39f-11ec-b8b8-f95467ff1ed0; Sat, 14 May 2022 18:06:31 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CF39E5C00E7; Sat, 14 May 2022 12:06:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 14 May 2022 12:06:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 14 May 2022 12:06:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d118f0f3-d39f-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1652544389; x=1652630789; bh=dl1KQYoQor 7dFAFhpdtNa+47JnMIBmQHVAoY4PnaKqo=; b=WnlthM3QMFEj+Xq1OpWQEBjXhn Zt9iXKJXoLPTs78znRUeUZuvpieT3yiMv+PxzvZm51zjeFyuFH3+ddcMkaRKXttE keBOGVqhJDhH/jkpT9dWyOL5/B+PVdXYL065XT/xW/QzXYkPNFceXa6YoBqLn+UU /NjBicpatJFwFsd22aozATMNCbRiIdzNXfR2joBb2sz+E8HAMC0AuYaDcKIdws5b 8m4Xj4cLXwJYEBjQPcr6W2T8eqWeapQx6YK+w1mvcAWLzLdOMgqAC4blFmobjTuo HLQsEbfKHObprXjc8XoHqIegtoZt32Tq4gM9svo6Hx3DMqYBlro4I/bYtZZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652544389; x=1652630789; bh=dl1KQYoQor7dF AFhpdtNa+47JnMIBmQHVAoY4PnaKqo=; b=JFVIQTw60eGO61Ai9EOiGrGqPkes0 WzDU0eDlZK2DRQGqt/UZJg+hHrpIW59ZPU2XqAgKEyK4z3mOxfLTiovRQ5TLmiQW 1DD4LdLtSA4ki09d2uBqkBJxLhbb+lXrpr7IYdnRxtJcjTM+QNcvJDn2bwT+atkL Kb39ege6Ta0USh0tZkSqPaB1YHIpG7QAWxrlirYrp0OJ/Z6iTgvhMLF22Djc1OrH PO3pa67ygpqtdBzzE9blGGJ19ajMUfYOS161NGrxUEiJFuMdtink6SVUIc+1+zbb /XBH5EnQF1pMigQnDb5CSC5GCBTWj98raQeSgqDiHItYoc1xpr/ZIxeUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrhedugdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggusehgtderredttdejnecuhfhrohhmpeffvghmihcuofgr rhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhmqeenucggtffrrghtthgvrhhnpeevieefgeeuhefhjedutdejuefhudetveeg geeitddujeelteekgeeigedtteekgeenucffohhmrghinhepghhithhhuhgsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhi sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Sat, 14 May 2022 11:55:39 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Juergen Gross , Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Subject: Hang in 5.17.4+ that appears to be due to Xen Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TNAwTdkDEjbbq6M1" Content-Disposition: inline --TNAwTdkDEjbbq6M1 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 14 May 2022 11:55:39 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Juergen Gross , Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org Subject: Hang in 5.17.4+ that appears to be due to Xen In https://github.com/QubesOS/qubes-issues/issues/7481, a user reported that Xorg locked up when resizing a VM window. While I do not have the same hardware the user does and thus cannot reproduce the bug, the stack trace seems to indicate a deadlock between xen_gntdev and i915. It appears that gnttab_unmap_refs_sync() is waiting for i915 to free the pages, while i915 is waiting for the MMU notifier that called gnttab_unmap_refs_sync() to return. Result: deadlock. The problem appears to be that a mapped grant in PV mode will stay in the =E2=80=9Cinvalidating=E2=80=9D state until it is freed. While MMU noti= fiers are allowed to sleep, it appears that they cannot wait for the page to be freed, as is happening here. That said, I am not very familiar with this code, so my diagnosis might be incorrect. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --TNAwTdkDEjbbq6M1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJ/04MACgkQsoi1X/+c IsGi2hAArO7G1fAnno/7xTzDfqxcNnOEuHFwZcn55O1E0JJ6qjGj9Uc98Td3TAcw M2i9U0fDpAB3L9naiD86fZHTgbKhEHAJ3d8D7RzA8wLOCdYD5Swh2rib2smYgZHP 7Lsl9IhcMhc0JkgwJ0Acr7qnA/2bar8uz3q4hX/aEiHJo+nD/PvrLnhXYNrfSUHK zP4ceuHJ2DYMBMEE66kdcolWYB2md5oOJXf1ff8MIiGAfxlaAqfBpCTInD6Fx060 SM8JBnDkoDkp8lyMpoklyN0wwtParAdYpQ4au70NctQ0ImQtcEtx8YKQI1qkyCUy oXDX8LwVb4YNpu1/wtfKwM4M2q4zKqvPLRjGA2TVKPOv4fPBw2+3GyhmOPwQDn19 LSbwnBo0mFb05bjQFKHf7sEhFmKZ63Gr2RlU+91tjVaquRQILd5CFW/0wCaNvDhq 6+t28vOl/loFBoQo0OCXL1KMgKQjtPcj+Kd8OflFuOceuD+4L7KzZ2EpUHOTD+V5 q+qchLFuJ9ic0Ohy+m4J1aU0t2Hjk5iyD//lrlA1iWhSM15F0PEPzRbeO02DT0Js bTKbIx62lTo5NHrB6AcHWYUsX9wN51+Kb7/ca/vNVD1gQJPgFaooNnNv2fK0z0ND jGcmREAkW9MAGOovIwBHEU68Ibr0bvwgf5jrcJWERKtOPQXVHs4= =i937 -----END PGP SIGNATURE----- --TNAwTdkDEjbbq6M1-- From xen-devel-bounces@lists.xenproject.org Sat May 14 16:10:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 16:10:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329136.552330 (Exim 4.92) (envelope-from ) id 1npuLf-0005Kv-98; Sat, 14 May 2022 16:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329136.552330; Sat, 14 May 2022 16:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuLf-0005Ko-6S; Sat, 14 May 2022 16:10:31 +0000 Received: by outflank-mailman (input) for mailman id 329136; Sat, 14 May 2022 16:10:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuLd-0005Ke-Rl; Sat, 14 May 2022 16:10:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuLd-0005iU-Ns; Sat, 14 May 2022 16:10:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuLd-0007NB-Cp; Sat, 14 May 2022 16:10:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npuLd-0000th-CL; Sat, 14 May 2022 16:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dmyJaAGKXjNdIybdeQW3bHXPFvGzghM74xl2gqWUvOw=; b=HUpXAKxmFvwT0oLrRG24/OAz3B kbLbUwSuWdMROZMSsj/Qgkfiw4S4iw1b+mjswn88uYHzXIJWRCkRVPEuLxvFtaafs41+mkxe7oTzR lgJk7CTg+q/Lfn+K5uvSAhkg8yIdr3MqucgpMYi6O2KAc4U0BXdJ4O19I/RwZnG86OAM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170423: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 16:10:29 +0000 flight 170423 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170423/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1001 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 16:19:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 16:19:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329147.552342 (Exim 4.92) (envelope-from ) id 1npuUF-00069M-Bt; Sat, 14 May 2022 16:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329147.552342; Sat, 14 May 2022 16:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuUF-00069F-7B; Sat, 14 May 2022 16:19:23 +0000 Received: by outflank-mailman (input) for mailman id 329147; Sat, 14 May 2022 16:19:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuUD-000699-4g for xen-devel@lists.xenproject.org; Sat, 14 May 2022 16:19:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npuUC-0005rl-0k; Sat, 14 May 2022 16:19:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1npuUB-0005X2-QN; Sat, 14 May 2022 16:19:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=xPgNX10W2vScqjWZLnhk/hXk/4aLAbV/mVirWkKODBU=; b=0YsvglZJH8yFSFD5FM7YmZVOGF 8btVI9gMliO/6JK8i7yTDG7ShRyU2xKHONTa2Eq2z+6sE/Zf+YszwyAuz/eiHHM5SRHhlBe8Zy62c qRU8RwksQhnWK4+75P2+AGBA1CPp9hI25jH0AsSTn+4helAf8KJZqAmMm+OXM03Ela+k=; Message-ID: <6ef42026-8b14-c16f-175c-5b3d9ca55f99@xen.org> Date: Sat, 14 May 2022 17:19:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20220513210730.679871-6-sstabellini@kernel.org> From: Julien Grall Subject: Re: [PATCH v7 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <20220513210730.679871-6-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 13/05/2022 22:07, Stefano Stabellini wrote: > diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c > new file mode 100644 > index 0000000000..3e7ad54da7 > --- /dev/null > +++ b/tools/helpers/init-dom0less.c > @@ -0,0 +1,345 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "init-dom-json.h" > + > +#define XENSTORE_PFN_OFFSET 1 > +#define STR_MAX_LENGTH 64 Sorry, I should have spotted this earlier. Looking at the nodes below, the node control/platform-feature-multiprocessor-suspend would result to 63 characters without even the domid: 42sh> echo -n '/local/domain//control/platform-feature-multiprocessor-suspend' | wc -c 62 So I think it would be wiser to bump the value to 128 here. > +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, > + domid_t domid, char *path, char *val) > +{ > + char full_path[STR_MAX_LENGTH]; > + struct xs_permissions perms[2]; > + > + perms[0].id = domid; > + perms[0].perms = XS_PERM_NONE; > + perms[1].id = 0; > + perms[1].perms = XS_PERM_READ; > + > + if (snprintf(full_path, STR_MAX_LENGTH, > + "/local/domain/%u/%s", domid, path) < 0) The issue I mentionned above would not have been spotted because you only check the value is negative. From glibc version 2.1, snprintf() returns the number of character (excluding the NUL bytes) it would have written if the buffer is big enough. So to avoid writing a truncated node, you will want to check the return value is > 0 && < (STR_MAX_LENGTH - 1). Looking at the code below, there are a few wrong use of snprintf(). To avoid another round (we are at v7 already), I would be OK if they are dealt after so long we bump the size of the buffer. The rest of the code looks ok: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 14 16:28:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 16:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329165.552353 (Exim 4.92) (envelope-from ) id 1npudJ-0000uD-DD; Sat, 14 May 2022 16:28:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329165.552353; Sat, 14 May 2022 16:28:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npudJ-0000u6-9S; Sat, 14 May 2022 16:28:45 +0000 Received: by outflank-mailman (input) for mailman id 329165; Sat, 14 May 2022 16:28:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npudH-0000tw-Ro; Sat, 14 May 2022 16:28:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npudH-00062c-PH; Sat, 14 May 2022 16:28:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npudH-0007nk-Ah; Sat, 14 May 2022 16:28:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npudH-0006RF-AD; Sat, 14 May 2022 16:28:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lJsJblt7TXq7CWkgyuNFsqWy1ZTn8k3z0rZ7AbfWL9Y=; b=mqeHqfimF82pIDUZQd+wUKIV3P la+HXQHfls1ZPl9NqurvwQ6fH2m0atbFZ5gfCb+wXa7eH+j6qvM+8F2DqXmmJjQdb1jfyZKOUFytY 5mXsm57MdIii4pkFXTeP0ir0nVYQb85rpK8Sp4OM+mr/rRHZDMRvpoH8HDkTzcN2ZqmE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170412: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=48de9b0916ef60d5a6bd6ca9288832deff8ee1ee X-Osstest-Versions-That: qemuu=9de5f2b40860c5f8295e73fea9922df6f0b8d89a From: osstest service owner Date: Sat, 14 May 2022 16:28:43 +0000 flight 170412 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170412/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail in 170400 pass in 170412 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 170400 test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 170400 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170374 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170374 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170374 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170374 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170374 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170374 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170374 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170374 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee baseline version: qemuu 9de5f2b40860c5f8295e73fea9922df6f0b8d89a Last test of basis 170374 2022-05-13 01:09:17 Z 1 days Testing same since 170400 2022-05-13 19:08:35 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Williamson Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9de5f2b408..48de9b0916 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 14 17:16:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 17:16:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329176.552364 (Exim 4.92) (envelope-from ) id 1npvNP-0006A2-3s; Sat, 14 May 2022 17:16:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329176.552364; Sat, 14 May 2022 17:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npvNP-00069v-0M; Sat, 14 May 2022 17:16:23 +0000 Received: by outflank-mailman (input) for mailman id 329176; Sat, 14 May 2022 17:16:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npvNN-00069l-Cx; Sat, 14 May 2022 17:16:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npvNN-0006rt-Bq; Sat, 14 May 2022 17:16:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npvNN-0000Mv-1Y; Sat, 14 May 2022 17:16:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npvNN-0007tE-15; Sat, 14 May 2022 17:16:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2OsxTEMbfOLJVopyIjkX/w/7ohdTmmbChOk9ZVKJnAY=; b=w9V7zwfagHb3buWUZB4no0VUUR akVDeCIMOtk07Q9SApG7qj4QjrBhA2xeTiAxF/1tZxtVi0QoLryZxDqFQ5gPr7/I9vQXudXDwWhXD +h31Qcp8cEm9h7WMXwZEW/W8jYXXv1Xq9JJTch+M2z+ZUkErSA89OcU4nMRd+xmOwkeU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170424: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 17:16:21 +0000 flight 170424 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170424/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1002 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 18:22:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 18:22:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329186.552374 (Exim 4.92) (envelope-from ) id 1npwPV-0004vy-5Y; Sat, 14 May 2022 18:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329186.552374; Sat, 14 May 2022 18:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwPV-0004vr-2n; Sat, 14 May 2022 18:22:37 +0000 Received: by outflank-mailman (input) for mailman id 329186; Sat, 14 May 2022 18:22:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwPU-0004vg-4M; Sat, 14 May 2022 18:22:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwPU-00081O-1m; Sat, 14 May 2022 18:22:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwPT-0001qI-Lj; Sat, 14 May 2022 18:22:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npwPT-0005lB-LI; Sat, 14 May 2022 18:22:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GWuPS2rHkFWEPv3RQ4VowP3OpuJKIWXl1BZ3r5dpPEo=; b=kWtcA8rnIKaEv4JL+WQZQavgYD 2fREOmBMW0AFK/WsJ+7RWZKGyDROQPpDI/uwEQMEKgrzIYaYNyAphElmRU+D1wjRsMlakXGXWZaxX oQbqrFQ8/EcmoUTRv9fTRN+J0sz4tsPScSRo6AUUbvwrs/bWq56LipsPA4aVd+tWpmc4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170425: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 18:22:35 +0000 flight 170425 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170425/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1003 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 18:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 18:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329196.552385 (Exim 4.92) (envelope-from ) id 1npwyv-0008Py-1m; Sat, 14 May 2022 18:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329196.552385; Sat, 14 May 2022 18:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwyu-0008Pr-V2; Sat, 14 May 2022 18:59:12 +0000 Received: by outflank-mailman (input) for mailman id 329196; Sat, 14 May 2022 18:59:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwyt-0008Ph-1X; Sat, 14 May 2022 18:59:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwys-0000A5-VJ; Sat, 14 May 2022 18:59:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npwys-0002ch-JZ; Sat, 14 May 2022 18:59:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npwys-0007YS-J8; Sat, 14 May 2022 18:59:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zEinm+hr5WtNyEjj17/CF9Kc+uvUPkhU9UoXRNoLomM=; b=O+8GYZEQEgd1vpJnPvEMCaa2y/ loncruBx7AgF1yoD35vTPvDUFOF5ErfO/H0lBrSgZzbEi3sxmdLOmP7gGgdd3KL8iX+0fy2MgkE0i UDAwacnDmGQAVxec8RVRnfkPwHgx/nfBMgZQ65CP1iXz/1bqePCJ9oKx5+HFvYwK4MJA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170426: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 18:59:10 +0000 flight 170426 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170426/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1004 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 20:34:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 20:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329205.552397 (Exim 4.92) (envelope-from ) id 1npySv-0001Yn-2K; Sat, 14 May 2022 20:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329205.552397; Sat, 14 May 2022 20:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npySu-0001Yg-VS; Sat, 14 May 2022 20:34:16 +0000 Received: by outflank-mailman (input) for mailman id 329205; Sat, 14 May 2022 20:34:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npySt-0001YW-1N; Sat, 14 May 2022 20:34:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npySs-0001tG-Vm; Sat, 14 May 2022 20:34:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npySs-0005Su-FC; Sat, 14 May 2022 20:34:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npySs-0004tC-Ei; Sat, 14 May 2022 20:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pv9XlGXHJfug5SUSqviSt3NJu4EL2wF1I6HjWqlDTiA=; b=Oc9cHrlxPxXR9kd4H1GtVie4Hj 9CPJdsHvE2NFtnPkE/Qn/LVOhXFjl1tHFBeIrS/OTw+tAdctVE22iwjyavJIJ31i3eKXqtOKOz9Gr 7VAiC5wBzHy8kSkk9TxmhthlyNreG5IbRiAKn1qVey1OMJE5tjSajfTXo50InoUm2PZc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170428: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 20:34:14 +0000 flight 170428 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170428/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1005 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 21:37:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 21:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329214.552407 (Exim 4.92) (envelope-from ) id 1npzRo-0008KO-Jj; Sat, 14 May 2022 21:37:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329214.552407; Sat, 14 May 2022 21:37:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npzRo-0008KH-Gs; Sat, 14 May 2022 21:37:12 +0000 Received: by outflank-mailman (input) for mailman id 329214; Sat, 14 May 2022 21:37:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npzRm-0008K7-NG; Sat, 14 May 2022 21:37:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npzRm-0002xS-LS; Sat, 14 May 2022 21:37:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1npzRm-0008T7-Ay; Sat, 14 May 2022 21:37:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1npzRm-0002HX-AV; Sat, 14 May 2022 21:37:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e4ZkNWMAvnU6k0PEUAM99t7Q24U+RU/VCuEw8tzP46E=; b=r3tPkkuYY+YPWeSUtIllLVl80W xsdllc3TOsjBaRbOJKoGsCeVnAgKtKM0vT5LLyhdi+CnoLd2j6QEsGsoOosbjrYB3qiVl9bbGCfKS y1reERK0c6187l64Irjfsx9NeVquqGIkHXUxtLTTN8yODg1t4DPOZ5kNU6LOz65kp23Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170429: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 21:37:10 +0000 flight 170429 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1006 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 22:14:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 22:14:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329224.552419 (Exim 4.92) (envelope-from ) id 1nq025-0004Ju-K0; Sat, 14 May 2022 22:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329224.552419; Sat, 14 May 2022 22:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq025-0004Jm-Fj; Sat, 14 May 2022 22:14:41 +0000 Received: by outflank-mailman (input) for mailman id 329224; Sat, 14 May 2022 22:14:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq024-0004Jc-Gk; Sat, 14 May 2022 22:14:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq024-0003bQ-Cv; Sat, 14 May 2022 22:14:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq023-0001i6-UC; Sat, 14 May 2022 22:14:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq023-0004yA-Tj; Sat, 14 May 2022 22:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uwWMhSSNEMn8H0Vrk2eSxx7pL5ZCUcnOK9Up8CwsJhU=; b=SWJLCxVnt+7Q8wrx5fQab6mEt8 tXFx2ljRVuCiAzWAqGkbp6Ih2O7+9aIvLtXri6Zi5eTtXf4AIvr3ZOFt2xMKNFWUZbUqbs8WYp3Uc v5mGvtiLkJ0xrWZR0PlXmS4p0XNVKprUsrDhIw6OhkZ4TMED3cSQciXrxUcCPh7oZENE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170430: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 22:14:39 +0000 flight 170430 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170430/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1007 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 14 23:13:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 14 May 2022 23:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329233.552430 (Exim 4.92) (envelope-from ) id 1nq0wr-00026o-0u; Sat, 14 May 2022 23:13:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329233.552430; Sat, 14 May 2022 23:13:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq0wq-00026h-U5; Sat, 14 May 2022 23:13:20 +0000 Received: by outflank-mailman (input) for mailman id 329233; Sat, 14 May 2022 23:13:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq0wq-00026X-9D; Sat, 14 May 2022 23:13:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq0wq-0004a3-2E; Sat, 14 May 2022 23:13:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq0wp-0003Rz-Qm; Sat, 14 May 2022 23:13:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq0wp-0007Nf-QJ; Sat, 14 May 2022 23:13:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NLk2edXeftaNtO5SNtOXpAbFiY8xvzHi02lY3i+XlYw=; b=nE1WCM9MNu/6R8qKtTJR+9GVZz mDB9jNAMlji/bdbJdOn5kGoAHjU8JNakNbfHqS86+iIm/Bff2EPRE0rOp2B7vPBb5fuqdCyzqX8Gf KVCwKJt/R1KTXOXxM5rubkqn14k/UBsl7hAdnA+hME30vOWs2A3PG+Kcfcafk60ro+t4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170431: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 14 May 2022 23:13:19 +0000 flight 170431 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170431/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1008 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 00:41:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 00:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329243.552440 (Exim 4.92) (envelope-from ) id 1nq2K0-0003EX-9J; Sun, 15 May 2022 00:41:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329243.552440; Sun, 15 May 2022 00:41:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2K0-0003EQ-6C; Sun, 15 May 2022 00:41:20 +0000 Received: by outflank-mailman (input) for mailman id 329243; Sun, 15 May 2022 00:41:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2Jy-0003EG-PD; Sun, 15 May 2022 00:41:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2Jy-0006hI-O3; Sun, 15 May 2022 00:41:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2Jy-0005cZ-FK; Sun, 15 May 2022 00:41:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq2Jy-0003lG-Er; Sun, 15 May 2022 00:41:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zqDCoe5MVMd2slqK9xGMWnmZu0CTsPrW96NykhE5ltE=; b=Lnqn2NwPgQcywTNzoVIVvKPUsa E0z3y+qCS3vS9RyZDcNxcCKUDTlcXeg8n+SoWCchmtKvjv4j/i757/1ftasClOciLtzglyskwgetY GucnuY+TGLiOLBTutnSM6N2MKXmVxKjZOBedmdpAsT6yW/OfIP97NgeycOy43iSF07m4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170432: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 00:41:18 +0000 flight 170432 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170432/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 74 days 1009 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 01:22:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 01:22:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329252.552451 (Exim 4.92) (envelope-from ) id 1nq2xP-0005xX-EZ; Sun, 15 May 2022 01:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329252.552451; Sun, 15 May 2022 01:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2xP-0005xQ-BY; Sun, 15 May 2022 01:22:03 +0000 Received: by outflank-mailman (input) for mailman id 329252; Sun, 15 May 2022 01:22:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2xO-0005xG-2z; Sun, 15 May 2022 01:22:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2xN-0005FA-Ln; Sun, 15 May 2022 01:22:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq2xN-0006gD-8I; Sun, 15 May 2022 01:22:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq2xN-0004id-7o; Sun, 15 May 2022 01:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HoMoMYuWKn7Et2LLTxYZH4SB5kkooC0e7wPDrdKDjlw=; b=nOS2lJPs5PE+5SpfF8IDevRbBy 7KqMzFzkTTer6ty7XeBPuXJyIAP0whH7CqsJAmd3kk4iKC0yVMG8NYXL5pI8v15Jq8RJEmSm51rjt 34bQ6pwGYhh1Qx4Xd0xsUkhkNWP90Tfl4Lj8/Cg+/KeofMAS05UZy2SM0wAajl01lkjs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170427: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2fe1020d73ca0467b5383b0a3e459a1d29902762 X-Osstest-Versions-That: linux=ec7f49619d8ee13e108740c82f942cd401b989e9 From: osstest service owner Date: Sun, 15 May 2022 01:22:01 +0000 flight 170427 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170427/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 170406 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170406 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170406 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170406 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170406 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170406 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170406 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170406 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 2fe1020d73ca0467b5383b0a3e459a1d29902762 baseline version: linux ec7f49619d8ee13e108740c82f942cd401b989e9 Last test of basis 170406 2022-05-14 03:40:10 Z 0 days Testing same since 170427 2022-05-14 19:09:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arnaldo Carvalho de Melo Ian Rogers Jeremy Linton Linus Torvalds Mathieu Poirier jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ec7f49619d8e..2fe1020d73ca 2fe1020d73ca0467b5383b0a3e459a1d29902762 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 15 02:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 02:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329262.552463 (Exim 4.92) (envelope-from ) id 1nq3YA-0001KK-KK; Sun, 15 May 2022 02:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329262.552463; Sun, 15 May 2022 02:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq3YA-0001JZ-Fq; Sun, 15 May 2022 02:00:02 +0000 Received: by outflank-mailman (input) for mailman id 329262; Sun, 15 May 2022 02:00:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq3Y8-00017s-TT; Sun, 15 May 2022 02:00:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq3Y8-0005qR-Lo; Sun, 15 May 2022 02:00:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq3Y8-0007Ua-Av; Sun, 15 May 2022 02:00:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq3Y8-0005og-AP; Sun, 15 May 2022 02:00:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/1wYdhzmyfsQvWTtJQ2PDMovIy4yHa7GDTiRWmiA2Og=; b=Pdh9sac1WKS4p/fcMy6bePL8O6 a3muswCAoSeIKJ42Pull+Ddf6fee3I+3fuQ0Cy/UTMsStagfpAiUZoWAZ05MSIzsAvLkr+7u8s22t Ca+dESqBSGXqRSGbEEMuVKO2GeLgHZs4py1lYPoUaOWcp7EK1ycVq487Mi8dW+ULl1zk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170433: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 02:00:00 +0000 flight 170433 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170433/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1010 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 04:04:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 04:04:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329271.552474 (Exim 4.92) (envelope-from ) id 1nq5Uo-0005sC-Kf; Sun, 15 May 2022 04:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329271.552474; Sun, 15 May 2022 04:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq5Uo-0005s5-Hc; Sun, 15 May 2022 04:04:42 +0000 Received: by outflank-mailman (input) for mailman id 329271; Sun, 15 May 2022 04:04:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq5Un-0005rv-5V; Sun, 15 May 2022 04:04:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq5Um-0008Ua-TC; Sun, 15 May 2022 04:04:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq5Um-0004ru-Jw; Sun, 15 May 2022 04:04:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq5Um-00075g-JT; Sun, 15 May 2022 04:04:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PzXYnODa8p07DERbLY1iDlMKK4YYFDiMEwCj2QRHvO4=; b=CGHN0b3I+zbOUQj968MRgcG6ca RUPgIF3Z5XgCVP2CBSaY8nlx22JAJqQPuSbf6YfV/L19iEy6XxC+PD+9//vID1Md0gg32QXmwwdCZ 3Xx7MWN5xX774y4J/3e7DE74w16SmH0wzqH1CeFsvEU0rCnLfcSVJHiZZRbDDBadzwnE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170435: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 04:04:40 +0000 flight 170435 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1011 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 05:37:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 05:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329280.552485 (Exim 4.92) (envelope-from ) id 1nq6w3-0006x5-HI; Sun, 15 May 2022 05:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329280.552485; Sun, 15 May 2022 05:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq6w3-0006wy-EG; Sun, 15 May 2022 05:36:55 +0000 Received: by outflank-mailman (input) for mailman id 329280; Sun, 15 May 2022 05:36:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq6w2-0006wo-MD; Sun, 15 May 2022 05:36:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq6w2-00022I-Jj; Sun, 15 May 2022 05:36:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq6w2-0000Ye-4P; Sun, 15 May 2022 05:36:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq6w2-0006Y7-3u; Sun, 15 May 2022 05:36:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5yNsMUBbCDxR/1ZlUUL1CXfhNvOnVPEOB/Jb7yI/E3s=; b=zUol67XBp8RKYJbYqy9udhfXDd NZfAX13Ln8OPGfEWKpbQ0WkyPXR7JhWa3WSjeZ3n8fnJVxlI6D+acDwlBU8UADIsZ1HTJfP8/8XT6 j3ki5ttSJE0kWcFHV5HtcwnM8Gn+qCw8tOCXGxtlNEDVQU70sYQJUkvs3POxCaVcQPYY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170436: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 05:36:54 +0000 flight 170436 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170436/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1012 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 06:29:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 06:29:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329289.552496 (Exim 4.92) (envelope-from ) id 1nq7kb-0003um-Cj; Sun, 15 May 2022 06:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329289.552496; Sun, 15 May 2022 06:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq7kb-0003uf-9X; Sun, 15 May 2022 06:29:09 +0000 Received: by outflank-mailman (input) for mailman id 329289; Sun, 15 May 2022 06:29:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq7ka-0003uV-Ei; Sun, 15 May 2022 06:29:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq7ka-0002ym-CK; Sun, 15 May 2022 06:29:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq7ka-00042a-2E; Sun, 15 May 2022 06:29:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq7ka-0006po-1m; Sun, 15 May 2022 06:29:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cWpHWAH4vrP4dssUj54Gf42W39F4gqy419sLiQl65VU=; b=j237wv0b2W2NiwD8y1sppekYsl bYG/tnynnEUitO4AhpGk88CmtYe6GlxKjVopOhrGN5saXDKsH77HMRbZws9mAZ0lPit+4Z7e5315p ZJ8kDhKFfyK2h36nPLZ5psYAguWBayGeBGCJ8C3nX8/6dhjMEk7gcrwwuWB86DGEuvfU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170438: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 06:29:08 +0000 flight 170438 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170438/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1013 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 07:22:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 07:22:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329299.552507 (Exim 4.92) (envelope-from ) id 1nq8ZX-0001mA-J0; Sun, 15 May 2022 07:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329299.552507; Sun, 15 May 2022 07:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8ZX-0001m3-GD; Sun, 15 May 2022 07:21:47 +0000 Received: by outflank-mailman (input) for mailman id 329299; Sun, 15 May 2022 07:21:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8ZW-0001lt-3D; Sun, 15 May 2022 07:21:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8ZV-0003t5-Tf; Sun, 15 May 2022 07:21:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8ZV-0005dK-EG; Sun, 15 May 2022 07:21:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq8ZV-0003pQ-Do; Sun, 15 May 2022 07:21:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oXpT9D5XfSoKHWRdBnEOuOzZELEfRE9izVa6eBJROjc=; b=rAXjSNINchFG0xBpPMR880m07b rlQ8oh+Z4hOd43UoI2p786w19xptzWzsk/acmojlA1dbe4Xac+P+MUArR4V09s5v+ZSCF9uyWjc9J klCvuKfYRF6JAf5urRZoRAj/NgIIdCvI3ooXK5BjyAtzcyesyXhh+5ImeNflcxewaYOk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170434: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Sun, 15 May 2022 07:21:45 +0000 flight 170434 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170434/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail in 170404 pass in 170434 test-armhf-armhf-libvirt 8 xen-boot fail pass in 170404 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 170404 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 170404 like 170385 test-armhf-armhf-libvirt 15 migrate-support-check fail in 170404 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170404 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170404 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170404 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170404 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170404 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170404 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170404 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170404 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170404 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170404 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170404 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170434 2022-05-15 01:52:59 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 15 07:22:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 07:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329303.552517 (Exim 4.92) (envelope-from ) id 1nq8Zu-00028R-TM; Sun, 15 May 2022 07:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329303.552517; Sun, 15 May 2022 07:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8Zu-00028K-QL; Sun, 15 May 2022 07:22:10 +0000 Received: by outflank-mailman (input) for mailman id 329303; Sun, 15 May 2022 07:22:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8Zt-00026y-Qd; Sun, 15 May 2022 07:22:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8Zt-0003tN-Ny; Sun, 15 May 2022 07:22:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8Zt-0005db-AY; Sun, 15 May 2022 07:22:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq8Zt-00041m-A2; Sun, 15 May 2022 07:22:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+V8QsaWLPO0X0iQLE8finkyZ2K8KgbsZL4lBrebli+g=; b=4oUGNMGxL7PvFYDsKPeeIwdKmr iGeRMN4siOF8hvbJH8RE5G8t+tq6bsfZFyGordH6sFTPWUQ5jVlF1v/nTFQ+mJ5AhAMs26uis949X 5vNI1tKTaMhK0DvxxZ6jgydhdhvbC50QEl9O10+zBfB71cYT7bloFAINElUTFS314VCo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170439: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 07:22:09 +0000 flight 170439 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170439/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1014 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 07:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 07:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329318.552529 (Exim 4.92) (envelope-from ) id 1nq8o7-0003zt-BK; Sun, 15 May 2022 07:36:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329318.552529; Sun, 15 May 2022 07:36:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8o7-0003zm-8I; Sun, 15 May 2022 07:36:51 +0000 Received: by outflank-mailman (input) for mailman id 329318; Sun, 15 May 2022 07:36:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8o6-0003zc-4U; Sun, 15 May 2022 07:36:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8o5-000485-UB; Sun, 15 May 2022 07:36:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq8o5-0005xS-HG; Sun, 15 May 2022 07:36:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq8o5-0002mn-Gl; Sun, 15 May 2022 07:36:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IV4/TtWa6OOjRhJeGFTPnzlbzOG4mr2whSBQmenHhac=; b=vTTwVR6DCZ6YJk7JMqKfjeQkHz pNr74KKjy+lafduOCHiKsD45goP13Ftif0UmBbq+ZvFJrtBZxxUlhRaWhaXnffn9bkpM6iBwV+KAT W60zg5evA1BRuo6cVvyI/foLSlySSCjiJKhDBrOnVrrKOUabTMDFjbIVLTh+kvA02rjw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170437: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 15 May 2022 07:36:49 +0000 flight 170437 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170437/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 674 days Failing since 151818 2020-07-11 04:18:52 Z 673 days 655 attempts Testing same since 170408 2022-05-14 04:18:58 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107373 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 08:03:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 08:03:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329330.552540 (Exim 4.92) (envelope-from ) id 1nq9DU-0007uC-RE; Sun, 15 May 2022 08:03:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329330.552540; Sun, 15 May 2022 08:03:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq9DU-0007u5-Na; Sun, 15 May 2022 08:03:04 +0000 Received: by outflank-mailman (input) for mailman id 329330; Sun, 15 May 2022 08:03:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq9DT-0007tv-GU; Sun, 15 May 2022 08:03:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq9DT-00056E-Dv; Sun, 15 May 2022 08:03:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nq9DT-0006Vz-4N; Sun, 15 May 2022 08:03:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nq9DT-0006Vh-3s; Sun, 15 May 2022 08:03:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5UXYJtSMO3uQHMI6B6Ij2EdZ+9z/bAFexka5ntiYjfE=; b=EdjHpX14y2AByEoLtky6N5s9nm 8gcDE7jtGWJeWPKUaLSzs2kWWpHhxg5KGFwhMkGQa+9HIa+q2m06GIKsRZ5cn1RccATC0ULzJl+iG 4t5qPmCv/wEAWuFoKgSK8aN68s+NGBsdYR59bct34bNjhY+z7hSij5RwieDLZceYq1sM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170440: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 08:03:03 +0000 flight 170440 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1015 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 08:57:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 08:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329339.552551 (Exim 4.92) (envelope-from ) id 1nqA3w-0004oP-1g; Sun, 15 May 2022 08:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329339.552551; Sun, 15 May 2022 08:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqA3v-0004oI-Tf; Sun, 15 May 2022 08:57:15 +0000 Received: by outflank-mailman (input) for mailman id 329339; Sun, 15 May 2022 08:57:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqA3u-0004o8-IK; Sun, 15 May 2022 08:57:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqA3u-00060K-ED; Sun, 15 May 2022 08:57:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqA3u-0007gs-76; Sun, 15 May 2022 08:57:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqA3u-0003ab-6g; Sun, 15 May 2022 08:57:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OWCc5YLPr2yEg0QXZYDtN43ad0cyiC+GV/7v3mneJzw=; b=KuPvmN40kiJLy4wf3JP5/L0qEo sxhEzFZopUgiBXZI8FRDLQlqS9qNpGSBWwZBxTogYATAEm8Wwp4I4UhcChJ7nhKFItKHpzqb3cP2b 61cN31Y2eH86vYdDuB+aW+XLO6c10wib9ti3jDp+PleyP+Le4ks3fkCy/8jtBScpgpg4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170441: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 08:57:14 +0000 flight 170441 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170441/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1016 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 09:31:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 09:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329349.552561 (Exim 4.92) (envelope-from ) id 1nqAaX-0000hL-RR; Sun, 15 May 2022 09:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329349.552561; Sun, 15 May 2022 09:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqAaX-0000hE-Oh; Sun, 15 May 2022 09:30:57 +0000 Received: by outflank-mailman (input) for mailman id 329349; Sun, 15 May 2022 09:30:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqAaW-0000h4-9m; Sun, 15 May 2022 09:30:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqAaW-0006ag-7u; Sun, 15 May 2022 09:30:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqAaV-0008PF-QC; Sun, 15 May 2022 09:30:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqAaV-0002wy-Pl; Sun, 15 May 2022 09:30:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uU657usJGO/eJDAqgILHkafRTsxd8bUYtRCUxbuVdTc=; b=fgTARM3XJMBECKzsiiOBVJPWB0 sAa9WgisFPYzvr8u91vTuJPb9Z9+WOdjYcUP0gvBgKcaeoIB6P/yox/Vles57shuR4cyiWYOsqoPF OSchF7Htxqi+3jCMWNwP+ay8HJXWF7/Cr7Yl2JOO7CiY43nS/FhodphxrtvcLV7zsf7Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170442: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 09:30:55 +0000 flight 170442 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170442/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1017 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 10:00:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 10:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329358.552572 (Exim 4.92) (envelope-from ) id 1nqB2U-0003Kl-4T; Sun, 15 May 2022 09:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329358.552572; Sun, 15 May 2022 09:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqB2U-0003Ke-1l; Sun, 15 May 2022 09:59:50 +0000 Received: by outflank-mailman (input) for mailman id 329358; Sun, 15 May 2022 09:59:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqB2T-0003KU-6A; Sun, 15 May 2022 09:59:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqB2T-00072o-58; Sun, 15 May 2022 09:59:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqB2S-0000b4-Nk; Sun, 15 May 2022 09:59:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqB2S-0001p2-NH; Sun, 15 May 2022 09:59:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cuJ45qlo4FgyE+G5sEEo/L39TO4YokqyN/xfomvD1zA=; b=eCc2/+jeY5XwF2y/xzQFOKkaAm e5pMz9H7dyWarp0YWmOcXu8dtATEW/fyEO6Z69m9XP0RuTytbssppFMVNKqPoGLCybmHTyBOA4i50 bu7cxkMXWptJbszj/jExe17KIDdcThrDuPdKFyb8eB5TDR67zhjz0oWuPWXe8oyKPPnU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170443: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 09:59:48 +0000 flight 170443 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170443/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 75 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1018 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 10:58:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 10:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329368.552584 (Exim 4.92) (envelope-from ) id 1nqBws-0001EB-J7; Sun, 15 May 2022 10:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329368.552584; Sun, 15 May 2022 10:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBws-0001E4-Fa; Sun, 15 May 2022 10:58:06 +0000 Received: by outflank-mailman (input) for mailman id 329368; Sun, 15 May 2022 10:58:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBwr-0001Dy-DR for xen-devel@lists.xenproject.org; Sun, 15 May 2022 10:58:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBwq-00085v-Li; Sun, 15 May 2022 10:58:04 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqBwq-0004lJ-FU; Sun, 15 May 2022 10:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=sijXoezdeLPhwSVDSsO8yT8FIeH1G73CLFXpmSXpA/M=; b=PEQKaRK/uLwz2BqeyKW+75R6rk /xy04l5U31BkrCJftDrRUr6vxd/OC9xn7NFeC0G6OQwz//WjM0HQu3zlcUGg13w9v5N02qQDcbq2Z dc/+lFw8hOvABsOanlUVgLS1knoT/XZxOHeW7k/DvWAsdeALV6gbXaOgBuDo5BIuojXk=; Message-ID: Date: Sun, 15 May 2022 11:58:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Julien Grall References: <20220507025434.1063710-1-Henry.Wang@arm.com> <20220507025434.1063710-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220507025434.1063710-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 07/05/2022 03:54, Henry Wang wrote: > With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before > local_irq_enable on secondary cores will lead to > > (XEN) Xen call trace: > (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) > (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) > (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 > (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 > (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 > (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 > (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc > (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 > (XEN) [<0000000084000200>] 0000000084000200 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 4: > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || > num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 > (XEN) **************************************** > > on systems without a big enough pool for xmalloc() to cater the > requested size. > > Moving the call of request_irq() past local_irq_enable() on > secondary cores will make sure the assertion condition in > alloc_xenheap_pages(), i.e. !in_irq && local_irq_enabled() is > satisfied. It is also safe because the timer and GIC maintenance > interrupt will not be used until the CPU is fully online. > > Reported-by: Wei Chen > Suggested-by: Julien Grall > Signed-off-by: Henry Wang Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun May 15 10:58:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 10:58:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329369.552595 (Exim 4.92) (envelope-from ) id 1nqBx3-0001YM-Rj; Sun, 15 May 2022 10:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329369.552595; Sun, 15 May 2022 10:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBx3-0001Xp-OK; Sun, 15 May 2022 10:58:17 +0000 Received: by outflank-mailman (input) for mailman id 329369; Sun, 15 May 2022 10:58:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBx2-0001X9-Sv; Sun, 15 May 2022 10:58:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBx2-00086N-S8; Sun, 15 May 2022 10:58:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqBx2-0001s3-DP; Sun, 15 May 2022 10:58:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqBx2-0007B5-D1; Sun, 15 May 2022 10:58:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dtb0gl0IJ5woAEnUaBmrvzumSGLJc2vERCXX3/t8VOw=; b=mLbAk5LLJYdRWSAhI9emgU4jDZ 1H1A+kW3xPGYFsVNzprGByKXMVl2DtOJEMbO+oH0bXEkqZJOqFM5UWpfiENUc8pfBL4QGLBYyILtk ZOizTFmji7A9KJ4xT0rV7BPDYZp089++qoeg8quqhkXmkmhU57RD63jqC2SDF5D9dZ+0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170444: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 10:58:16 +0000 flight 170444 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170444/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1019 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 11:29:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 11:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329385.552606 (Exim 4.92) (envelope-from ) id 1nqCR4-0005Nm-HM; Sun, 15 May 2022 11:29:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329385.552606; Sun, 15 May 2022 11:29:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCR4-0005Nf-DI; Sun, 15 May 2022 11:29:18 +0000 Received: by outflank-mailman (input) for mailman id 329385; Sun, 15 May 2022 11:29:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCR2-0005NV-Pk; Sun, 15 May 2022 11:29:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCR2-0000Ba-Oi; Sun, 15 May 2022 11:29:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCR2-0002XL-Cb; Sun, 15 May 2022 11:29:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqCR2-0006FH-C8; Sun, 15 May 2022 11:29:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XzdfkJxknFRk5ieRU5z3dWsuQ8Ik3km5VogpU1EjfNI=; b=YUzRG80axH6+kMaT9MaXlOdKuX Ag9ARAcaePFjQfesJZB+ik7/LANCz1PEgyH5Yg7UFNJjw4XYrGhT3SRuH3QbKKqpPztWZmXV83dRb nR/oJ13eTwB7Bz7UIeDGRW+ICekWL9S9krH1L/7h2BMEcVbJW2R0M1EJvdSPOrKH+f5M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170445: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 11:29:16 +0000 flight 170445 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170445/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1020 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 11:40:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 11:40:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329394.552617 (Exim 4.92) (envelope-from ) id 1nqCcE-0007gN-Gs; Sun, 15 May 2022 11:40:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329394.552617; Sun, 15 May 2022 11:40:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCcE-0007gG-Dm; Sun, 15 May 2022 11:40:50 +0000 Received: by outflank-mailman (input) for mailman id 329394; Sun, 15 May 2022 11:40:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCcC-0007g9-Em for xen-devel@lists.xenproject.org; Sun, 15 May 2022 11:40:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCcB-0000Oe-Ru; Sun, 15 May 2022 11:40:47 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.16.228]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqCcB-0007iU-LH; Sun, 15 May 2022 11:40:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=sV+DZPXXisuF8dQ1tTKpfkJq0MivOExFO3DKcQGBh38=; b=zw0qlaQfhtooJaX1NRDnEQ4gwL xLZyUWz3H/R0ks16RkrVw9q5mraVGKzpZmFKiidTh5iQU1kvH6mLmK8lcyRomI0KvPchaSEgS0hCk /QBaQYAigYqBMB4BKIWPurJm7QAoDQA5Xuh6Tw+VEL3UuHUsqJiGYYVHO7Tg/c35FdTY=; Message-ID: <5c0e81f1-fac4-f14f-f4a1-2a00f6d16f47@xen.org> Date: Sun, 15 May 2022 12:40:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Julien Grall References: <20220507025434.1063710-1-Henry.Wang@arm.com> <20220507025434.1063710-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20220507025434.1063710-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/05/2022 03:54, Henry Wang wrote: > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index e866e0d864..ea59cd1a4a 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -162,13 +162,6 @@ > static char __initdata opt_badpage[100] = ""; > string_param("badpage", opt_badpage); > > -/* > - * Heap allocations may need TLB flushes which may require IRQs to be > - * enabled (except when only 1 PCPU is online). > - */ > -#define ASSERT_ALLOC_CONTEXT() \ > - ASSERT(!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)) > - FYI, the patch introducing ASSERT_ALLOC_CONTEXT() has been reverted. I intend to re-introduce it once your previous patch and the one fixing the ITS (not yet formally sent) have been committed. I have also checked that none of the ASSERTs() would be triggered on my x86 setup. So: Tested-by: Julien Grall Acked-by: Julien Grall On a side note (no action expected for you), I noticed that the ASSERT()s would only trigger from CPU2 and onwards at least for Arm. This is because num_online_cpus() would still be 1 when bringing-up CPU1. I went through the original discussion and I am not sure why we switched from < SYS_STATE_smp_boot to num_online_cpus() (aside that Arm doesn't set it). Aynway, this is not a major issue here as this is an ASSERT(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun May 15 11:59:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 11:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329401.552627 (Exim 4.92) (envelope-from ) id 1nqCuS-0000xK-31; Sun, 15 May 2022 11:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329401.552627; Sun, 15 May 2022 11:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCuS-0000xD-0J; Sun, 15 May 2022 11:59:40 +0000 Received: by outflank-mailman (input) for mailman id 329401; Sun, 15 May 2022 11:59:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCuQ-0000x3-RK; Sun, 15 May 2022 11:59:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCuQ-0000ge-Kp; Sun, 15 May 2022 11:59:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqCuQ-0003Bt-3p; Sun, 15 May 2022 11:59:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqCuQ-00057b-3N; Sun, 15 May 2022 11:59:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y+5wAc3Bja8excVlQ6SJR7WsWCMLU9aao/eKGOA8IGo=; b=ggOygn10ic90ILjmeiDzU0Bveu cnam3p5FVmOI4KU5HaH6ripM0yiaEzYRUQv+ajKPH22pUQlwUkGfAIk/V5nRqipaC1+ANn2B2zg3X XCV+UYgd4YVxrZo8YlAkrCu8NMDWjBpTg6v5nfqPaQBE7P/47wv3VHsLF1khdzphl+nU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170446: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 11:59:38 +0000 flight 170446 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170446/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1021 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 12:29:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 12:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329411.552638 (Exim 4.92) (envelope-from ) id 1nqDNX-0004Sb-IO; Sun, 15 May 2022 12:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329411.552638; Sun, 15 May 2022 12:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqDNX-0004SU-Ff; Sun, 15 May 2022 12:29:43 +0000 Received: by outflank-mailman (input) for mailman id 329411; Sun, 15 May 2022 12:29:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqDNW-0004SK-8O; Sun, 15 May 2022 12:29:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqDNW-0001CE-6Z; Sun, 15 May 2022 12:29:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqDNV-0003q6-TW; Sun, 15 May 2022 12:29:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqDNV-0004Bb-T5; Sun, 15 May 2022 12:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qJ/k1ONpt8G89xFfkDBJ3m2oNZ6BWi3K4sfc2yavRqg=; b=jXd+dtifEwBo2gSaG2lJpCt7RP SnM6MFEO+ik/1yh7RBe66ceWPYFUEX+rnCDWwvhOwL8zmWjyN0NbYvc3v/e0rZhkwz/OJyHzvAuzm c0UafaiQ3zPc4TeyEmNIFnA2V3lW7K3GnnaNxPBRgRmjQON/gredgCQGDof61H2n2jdU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170447: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 12:29:41 +0000 flight 170447 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170447/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1022 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 13:14:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 13:14:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329420.552650 (Exim 4.92) (envelope-from ) id 1nqE5D-0001Kg-0J; Sun, 15 May 2022 13:14:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329420.552650; Sun, 15 May 2022 13:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqE5C-0001KY-TW; Sun, 15 May 2022 13:14:50 +0000 Received: by outflank-mailman (input) for mailman id 329420; Sun, 15 May 2022 13:14:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqE5B-0001KO-9b; Sun, 15 May 2022 13:14:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqE5B-0001x9-71; Sun, 15 May 2022 13:14:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqE5A-0004oN-UF; Sun, 15 May 2022 13:14:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqE5A-0005cs-Tm; Sun, 15 May 2022 13:14:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0iCtS9LWG32HAasQXODpaWQmdVevUTb7SN8jNjCnhxM=; b=tcTw7+al5ogEY8kWiufx2IDznc w4QkWuODWcubHPssKtpMCulsFkkZTMCiarlOCJBnQt/o3FK7aKdAqRcfaN4cpe0pvNnB0Q0cIOCCD 40aQlDBvbeW+6TH+v3LPNdN/qlqkUjbLraKHOyQl3GBL4kba6IsjHYSmc6l2fvWEjDak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170448: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 13:14:48 +0000 flight 170448 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170448/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1023 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 14:47:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 14:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329430.552661 (Exim 4.92) (envelope-from ) id 1nqFWn-0002fu-P4; Sun, 15 May 2022 14:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329430.552661; Sun, 15 May 2022 14:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFWn-0002fn-L6; Sun, 15 May 2022 14:47:25 +0000 Received: by outflank-mailman (input) for mailman id 329430; Sun, 15 May 2022 14:47:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFWm-0002fd-9J; Sun, 15 May 2022 14:47:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFWm-0003Wr-7Z; Sun, 15 May 2022 14:47:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFWl-0006pE-SB; Sun, 15 May 2022 14:47:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqFWl-000371-Rj; Sun, 15 May 2022 14:47:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=h+IYR94UeDzP8A04ohofxNcyWgS3nrRedR/H4N23Rio=; b=6janCwH9sWSlKvCl5m5jxG/UMG xpXk8BDswGyuoOds7ft2J5kOGCktiUWthVJW3bY8q+DBLHJV8jOcn/XdbHffZSa/oNTeaCNrGGoIa qOP7AwPlRm02rMG1vsErqZ9ZKiPJ95ZP7FgrnIGx4eX8LKASxnXNAhSVrecVmfx4OdjA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170449: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 14:47:23 +0000 flight 170449 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170449/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1024 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 15:00:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 15:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329440.552672 (Exim 4.92) (envelope-from ) id 1nqFjI-000534-VS; Sun, 15 May 2022 15:00:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329440.552672; Sun, 15 May 2022 15:00:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFjI-00052x-SP; Sun, 15 May 2022 15:00:20 +0000 Received: by outflank-mailman (input) for mailman id 329440; Sun, 15 May 2022 15:00:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqFjH-00052p-FE for xen-devel@lists.xenproject.org; Sun, 15 May 2022 15:00:19 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbb0133f-d45f-11ec-aa76-f101dd46aeb6; Sun, 15 May 2022 17:00:18 +0200 (CEST) Received: from [192.168.1.137] (host-87-18-194-234.retail.telecomitalia.it [87.18.194.234]) by support.bugseng.com (Postfix) with ESMTPSA id D8BD44EE0779; Sun, 15 May 2022 17:00:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbb0133f-d45f-11ec-aa76-f101dd46aeb6 Message-ID: Date: Sun, 15 May 2022 17:00:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050929 Thunderbird/1.0.7 Fedora/1.0.7-1.1.fc4 Mnenhy/0.7.3.0 Subject: Re: ECLAIR Xen x86 results and progress Content-Language: en-US To: Stefano Stabellini , Bertrand Marquis Cc: Jan Beulich , "andrew.cooper3@citrix.com" , "julien@xen.org" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "Artem_Mygaiev@epam.com" , "xen-devel@lists.xenproject.org" References: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> From: Roberto Bagnara In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/05/22 21:55, Stefano Stabellini wrote: > On Mon, 9 May 2022, Bertrand Marquis wrote: >>> On 6 May 2022, at 17:31, Stefano Stabellini wrote: >>> >>> Hi all, >>> >>> Roberto kindly provided the ECLAIR x86 results: >>> >>> https://eclairit.com:8443/job/XEN/Target=X86_64,agent=public/lastSuccessfulBuild/eclair/ >>> >>> Click on "See ECLAIR in action", then you can select "Show 100 entries" >>> and see all the results in one page. As an example MC3R1.R1.3 >>> corresponds to Rule 1.3 in the spreadsheet. >>> >>> >>> If you are OK with this, I would like to aim at a follow-up meeting on >>> Tue May 17 at the same time (8AM California / 4PM UK). If the date/time >>> doesn't work, I'll run another Doodle poll. >> >> Works for me. > > Actually, to make sure more people are able to attend, I would like to > suggest May 19 8AM California / 4PM UK / 5PM Europe (which is the same > slot typically used by the Xen Community Call). Please let me know if > that works or if it is a problem. > > >>> By then, I am hoping that the group has already gone through the first >>> 20 rules in the list, up until Rule 8.10. Is that reasonable for all of >>> you? >> >> I completed that part of the table this morning (up to 8.14), it took me 30 minutes. > > Thank you! I did so as well in about the same amount of time. > > I think I should provide a clarification on a couple of rules that are > not clear from the examples. > > > # Rule 5.4 "Macro identifiers shall be distinct" > > This one is about the length of the Macro itself. C90 requires the first > 31 characters to be different, while C99 requires the first 63 > characteres to be different. > > So the problem is the following: > > #define this_macro_is_way_way_way_too_long > #define this_macro_is_way_way_way_too_loooong > > I don't think we have any violations. > > > # Rule 8.6 " An identifier with external linkage shall have exactly one external definition" > > This one is meant to catch cases where there are 2 definitions for 1 > declaration: > > header.h: > extern int hello; > > file1.c: > int hello; > > file2: > int hello; > > There was a question on whether having 1 declaration with no definitions > would be OK, so only the following: > > header.h: > extern int hello; > > for instance because file1.c has been removed from the build due to a > kconfig. Reading MISRA, I don't think it is a violation of Rule 8.6. > Roberto please correct me if I am wrong. Hi there. As I am not 100% sure I will be able to attend the meeting on the 19th, I am providing some input here: # Rule 5.4 "Macro identifiers shall be distinct" The point here is that every standard-conformant C/C++ compiler has the right of ignoring the characters in an identifier that are outside the "significant part." Different kind of identifiers have different minimum lengths for the significant part. For macros and non-external identifiers, we have: - for C90 and C95: 31 characters; - for C99, C11 and C18: 63 characters; - for C++: 1024 characters. So, for example, a C90 compiler (or, and it is the same, any compiler in C90 mode) can freely ignore all characters in the name of macros beyond the 31st. And if two macro identifiers differ only in the non-significant part, the behavior is undefined (for the simple reason that the preprocessor can choose any of the conflicting macros). Now, the builds of XEN that are analized at https://eclairit.com are built with (versions of) GCC and GCC goes well beyond the standard minimal requirements by stipulating that "For internal names, all characters are significant. For external names, the number of significant characters are defined by the linker; for almost all targets, all characters are significant." (https://gcc.gnu.org/onlinedocs/gcc/Identifiers-implementation.html#Identifiers-implementation). Now, given that ECLAIR takes into account (completely automatically) all the implementation-defined behaviors of the actually used toolchain (including how those are influenced by the command-line options), why do we have a violation report when macro names only differ after the 31st character in C90 mode? For example, 12345678901234567890123456789012345678901 XEN_NETIF_CTRL_TYPE_SET_HASH_MAPPING_SIZE XEN_NETIF_CTRL_TYPE_SET_HASH_MAPPING ? The reason is pragmatic: yes, there is no undefined behavior with GCC, but do you really want to admit macro names that are different only in characters coming hundreds or thousands positions from the beginning of the identifier? I guess not: then choose your threshold, add a one-liner to the ECLAIR configuration, and let ECLAIR warn you if and when the rule is violated with *that* threshold. This brings us to a related topic: why is part of XEN compiled in C90 mode while part of it is compiled in C99 mode? This is a very important violation of MISRA C Rule 1.1, which is not in your coding standard, but it really should be included. C90 and C99 are not 100% compatible, and mixing them is asking for trouble. My advice is choosing one version of the language (C90, C99, C11 or C18) and stick to it, enabling Rule 1.1 to make sure the source code complies to the chosen language standard version. My advice is: if at all possible, exclude C90; then use the most modern version of the language that is compatible with *all* toolchains you need to support. # Rule 8.6 " An identifier with external linkage shall have exactly one external definition" Exactly one means: - 2 or more is bad, as you may violate the "one definition rule" and incur undefined behavior; - 0 is bad, as this means you have redundant (useless) declarations. Of course, the first case is the most dangerous one. The second case is just one aspect of a more general MISRA principle saying "unused stuff should not reach the compilation phases past preprocessing," that is, you should #if-, #ifdef- or #ifndef-out everything that is not required by the project configuration you are building. Again, the actual hazard depends on several factors. Unused function definitions are clearly more dangerous than unused function declarations: if the linker is unable to filter out the unused code, then the device will contain code that is unreachable in normal executions but that code can be exploited during a cyber-attack. It is a matter of a one-line ECLAIR configuration to adapt to the case where you might say "unused declarations are OK and we do not want to exclude them with preprocessor conditionals." I hope it helps, Roberto From xen-devel-bounces@lists.xenproject.org Sun May 15 15:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 15:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329453.552683 (Exim 4.92) (envelope-from ) id 1nqGJo-0000GC-1D; Sun, 15 May 2022 15:38:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329453.552683; Sun, 15 May 2022 15:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqGJn-0000G5-UE; Sun, 15 May 2022 15:38:03 +0000 Received: by outflank-mailman (input) for mailman id 329453; Sun, 15 May 2022 15:38:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqGJm-0000Fv-Li; Sun, 15 May 2022 15:38:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqGJm-0004M5-Jr; Sun, 15 May 2022 15:38:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqGJm-0000kX-7T; Sun, 15 May 2022 15:38:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqGJm-0006Jl-70; Sun, 15 May 2022 15:38:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GlloEVmoNa5cWdVoIZYkRMEbOLPsU9AyikKSiJq4zxM=; b=uTn6y1Dc1XrtQfltYJms3vP98V 4rgtVtDCJ0eyA8UJznhqQfPKMh6XwyxTLNxWxqAgK5se4cz4uZDXMhtUn5V6m7M31mf5iAT26Ao5t ENxT0JwSr3XsFEcjyLwua4HAXbGTbrhbdKPhP4pI/z2RzkI2+xKsps0jvaanoqJlSV3s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170451: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 15:38:02 +0000 flight 170451 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170451/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1025 attempts Testing same since 170392 2022-05-13 15:40:22 Z 1 days 44 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 16:48:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 16:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329463.552693 (Exim 4.92) (envelope-from ) id 1nqHPn-00086j-9n; Sun, 15 May 2022 16:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329463.552693; Sun, 15 May 2022 16:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqHPn-00086c-79; Sun, 15 May 2022 16:48:19 +0000 Received: by outflank-mailman (input) for mailman id 329463; Sun, 15 May 2022 16:48:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqHPm-00086S-DS; Sun, 15 May 2022 16:48:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqHPm-00062O-Be; Sun, 15 May 2022 16:48:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqHPl-00043S-T0; Sun, 15 May 2022 16:48:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqHPl-0007JR-Sa; Sun, 15 May 2022 16:48:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6CSN6Qe2kzeBwl2wccxmfQg4yTQduFVkB3VO0hhySTg=; b=JASNY4ibUhvlAnZpdFPjy76qEX qqyDDheuEpj/g7yeqChjOYcvDBjRNTACR4DQHHmhtERl3483iviUg6Pqre/VU4Lu3iHXeChH2FEiA IBaBWZD9ZVx8m73nz42k2sPIc4UbvcXVovsbhQrA3fRmSdVv8w9jl0UbMxQB6rESD8Ms=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170452: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 16:48:17 +0000 flight 170452 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170452/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1026 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 45 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 18:04:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 18:04:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329473.552705 (Exim 4.92) (envelope-from ) id 1nqIbE-000800-Qu; Sun, 15 May 2022 18:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329473.552705; Sun, 15 May 2022 18:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqIbE-0007zt-Ns; Sun, 15 May 2022 18:04:12 +0000 Received: by outflank-mailman (input) for mailman id 329473; Sun, 15 May 2022 18:04:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqIbD-0007zj-F9; Sun, 15 May 2022 18:04:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqIbD-0007M7-A8; Sun, 15 May 2022 18:04:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqIbC-0006hn-Ra; Sun, 15 May 2022 18:04:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqIbC-0007VZ-R6; Sun, 15 May 2022 18:04:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=At/s97bmZHUSm2jC2lTix3sVzOcDh0ThHWCG0OTTWis=; b=fSu6ZCOkICgaO3kUUWX6ZFZtNz TpqIW4vZlbW1L3YofqSUjJcTHmviLYnqP+SCRHNF0eKIo7cA/jjvCNmDg0z0xBbv5+7BU90x1Kv9t zyZq+18mHFQNhVdINatsM1aPSZc8KHKFtc3SQ2Thw2rxvxVzVx57RnSv9R1fXi1nMYK0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170453: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 18:04:10 +0000 flight 170453 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1027 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 46 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 19:28:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 19:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329483.552716 (Exim 4.92) (envelope-from ) id 1nqJuN-0007ut-SY; Sun, 15 May 2022 19:28:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329483.552716; Sun, 15 May 2022 19:28:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqJuN-0007um-Oy; Sun, 15 May 2022 19:28:03 +0000 Received: by outflank-mailman (input) for mailman id 329483; Sun, 15 May 2022 19:28:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqJuM-0007uc-M4; Sun, 15 May 2022 19:28:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqJuM-0000KT-Hp; Sun, 15 May 2022 19:28:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqJuM-0001hP-5U; Sun, 15 May 2022 19:28:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqJuM-0007As-51; Sun, 15 May 2022 19:28:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aAY6LuzImnP2OxLLeKpdHF5QzftTu8WrEcg6AZnCDzc=; b=WusAUGbHMMPDCvOek5nl8h2mty onSQhHWaAZeYruVMmHfdLrTmCnOVBrUONnG72RCOOsDXh3t6lutuRTv7UeAOPzjxAyoj/uqgi7tpA n/b3jqIlt8Tyz4S68mrbXTld8vUogAYCbjCH6lyPOiFTHELvDWFh7rEJG11+9+INcXZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170455: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 19:28:02 +0000 flight 170455 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1028 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 47 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 20:52:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 20:52:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329495.552727 (Exim 4.92) (envelope-from ) id 1nqLDl-0000FV-7S; Sun, 15 May 2022 20:52:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329495.552727; Sun, 15 May 2022 20:52:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLDl-0000FO-4P; Sun, 15 May 2022 20:52:09 +0000 Received: by outflank-mailman (input) for mailman id 329495; Sun, 15 May 2022 20:52:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLDi-0000FD-VK; Sun, 15 May 2022 20:52:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLDi-0001nU-Sk; Sun, 15 May 2022 20:52:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLDi-0006lu-Cc; Sun, 15 May 2022 20:52:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqLDi-00025H-CB; Sun, 15 May 2022 20:52:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=12vZ0ODwrL7uns0wEYvRbyNN9Znfe8K1gKYpNFfem6o=; b=AzTKW6bS6ket8MhiYKhp011yt5 zUeMQEyO5cMrVvLvCkEQLg9BY9V4ECyimWFRIr0Nz+emgytMRKdlDkfFteHLYvGjhOSuusgLXndgi ir/P41abMb6TzW8Fklx0WDhX0llpnmOirhI0sqTPRyiefRbNboIzCIthvgBQJuD7Ktyg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170456: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 20:52:06 +0000 flight 170456 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170456/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1029 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 48 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 21:17:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 21:17:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329505.552738 (Exim 4.92) (envelope-from ) id 1nqLc5-0002pC-A5; Sun, 15 May 2022 21:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329505.552738; Sun, 15 May 2022 21:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLc5-0002p5-5c; Sun, 15 May 2022 21:17:17 +0000 Received: by outflank-mailman (input) for mailman id 329505; Sun, 15 May 2022 21:17:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLc4-0002ov-C7; Sun, 15 May 2022 21:17:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLc4-0002E2-9Y; Sun, 15 May 2022 21:17:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLc3-000070-SD; Sun, 15 May 2022 21:17:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqLc3-0007d2-Ri; Sun, 15 May 2022 21:17:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U9r3+VkNjPurwmWWxRfP+3qMh1BfSK1SUTDfMedRiMI=; b=405OdX+IKyglBbWNLH4RUw2xxU EcQHzI4pdRlu3Y2KQ4DvsGgO4+ka6SFIGcjrMHDLwvaEUTmqa0HphlwiJxyj5jlttFy6dobSX+QEA w7AfCu8NPoOD3JKLCaxbKWqO9bhr7FsIQpyjwaxX0cbpMDn+yanTaFTppiU4vdzBFoJo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170450: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit2:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=bc403203d65a874df2f3156046468052e4109cb0 X-Osstest-Versions-That: linux=2fe1020d73ca0467b5383b0a3e459a1d29902762 From: osstest service owner Date: Sun, 15 May 2022 21:17:15 +0000 flight 170450 linux-linus real [real] flight 170457 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170450/ http://logs.test-lab.xenproject.org/osstest/logs/170457/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 20 guest-localmigrate/x10 fail pass in 170457-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170427 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170427 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170427 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170427 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170427 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170427 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170427 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170427 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux bc403203d65a874df2f3156046468052e4109cb0 baseline version: linux 2fe1020d73ca0467b5383b0a3e459a1d29902762 Last test of basis 170427 2022-05-14 19:09:48 Z 1 days Testing same since 170450 2022-05-15 14:09:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian-Ken Rueegsegger Alexander Graf Delyan Kratunov Linus Torvalds Lukas Wunner Michael Ellerman Peter Zijlstra (Intel) Steven Rostedt (Google) Thomas Gleixner jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 2fe1020d73ca..bc403203d65a bc403203d65a874df2f3156046468052e4109cb0 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 15 21:39:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 21:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329515.552749 (Exim 4.92) (envelope-from ) id 1nqLxb-0006N9-5k; Sun, 15 May 2022 21:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329515.552749; Sun, 15 May 2022 21:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLxb-0006N2-1o; Sun, 15 May 2022 21:39:31 +0000 Received: by outflank-mailman (input) for mailman id 329515; Sun, 15 May 2022 21:39:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLxZ-0006Ms-MK; Sun, 15 May 2022 21:39:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLxZ-0002Yr-KY; Sun, 15 May 2022 21:39:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqLxZ-0001Gt-84; Sun, 15 May 2022 21:39:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqLxZ-0007ZD-7a; Sun, 15 May 2022 21:39:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0RJPnisAKPQfshz/gSzDPgzQuD79bAQeKVIOfgYxLrk=; b=GDHtJ7Z5nE+0oprXbzP7HV5Fgr gs+SWgJKn2BZEj1GFiA+vElFHUxIWTrQgFZVpmk3ot8hK0gHNY3L75CNyYCBXVQHZnH/N5ZcbQOGI ee532U4JZQbOkZwiM4R/vvgScHIC59EE1v/aB5qleYUM2WR8KYWRa1XKrw6JzkRhKXYA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170458: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 21:39:29 +0000 flight 170458 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170458/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1030 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 49 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 22:14:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 22:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329526.552760 (Exim 4.92) (envelope-from ) id 1nqMVh-0002NM-Vx; Sun, 15 May 2022 22:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329526.552760; Sun, 15 May 2022 22:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMVh-0002NF-SV; Sun, 15 May 2022 22:14:45 +0000 Received: by outflank-mailman (input) for mailman id 329526; Sun, 15 May 2022 22:14:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMVh-0002N5-0d; Sun, 15 May 2022 22:14:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMVg-0003Ct-Vr; Sun, 15 May 2022 22:14:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMVg-0002Hu-La; Sun, 15 May 2022 22:14:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqMVg-0004t4-L8; Sun, 15 May 2022 22:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LHz5lXv90XzSiQ58gg0f7h2C/d3v/uJUSWrrYLjSCx0=; b=ikwB5Nqu3y7DV1KyDcHnIci3pE dx8Nw/xpjbhLZpyQfg1hMJ0HWwjk2O8unYrXK+tHP8lCNDGxfkNvBK1vEwqcnpxmPukrmM32Dg4bC lrZx9p/Nu067aoxD023HFQVfl84c5twr+Xndjsw1oFQE4sK3w64IsBROUpjgnaeLRqGU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170460: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 22:14:44 +0000 flight 170460 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170460/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1031 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 50 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 22:15:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 22:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329534.552771 (Exim 4.92) (envelope-from ) id 1nqMWP-0002sU-Az; Sun, 15 May 2022 22:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329534.552771; Sun, 15 May 2022 22:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMWP-0002sN-6o; Sun, 15 May 2022 22:15:29 +0000 Received: by outflank-mailman (input) for mailman id 329534; Sun, 15 May 2022 22:15:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqMWL-0002gX-05 for xen-devel@lists.xenproject.org; Sun, 15 May 2022 22:15:27 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82922368-d49c-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 00:15:23 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqMUS-005ij1-QV; Mon, 16 May 2022 00:13:29 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82922368-d49c-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YHVcpMpwO8nyb8k3/FdyFSCMjS4nrs3MtFW4fah9gBU=; b=or/Fp90JrKe5WlMtL6cMgrtDTd KlQ8Vj1tprmMn4SD+c397HC1ukULCsTvCB4iLkFWE/e5eO3HFfAEwKhrKkKAtUd9klk2EZdbn6mIN Qd+4SALGR19YAeq7zzTYslQNi14hCF7XYTbP7jST+WF88j+/yFKclHfwZStwWLlezXivWrxaH8IdO FFInQai4LoqHg4Is254olZSUcp3WbX0NojyrclkAFtXk81MOkLDyQLJPvTXx/jJ5o9GkRAlJzHqhs Xl4VBJVpr4ONcW/qU5LapKJAeqGhxtirFucuu9tYQZm2MIj3QsWcao7mjJyCDthsv8RdX0nMP6hLP SN2gr77A==; Message-ID: <178a456d-3961-9bc2-83d2-2b9457d45fbd@igalia.com> Date: Sun, 15 May 2022 19:12:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 11/30] um: Improve panic notifiers consistency and ordering Content-Language: en-US To: Johannes Berg , Petr Mladek , Anton Ivanov , Richard Weinberger Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-12-gpiccoli@igalia.com> <4b003501-f5c3-cd66-d222-88d98c93e141@igalia.com> <1760d499824f9ef053af7a8dac04b48ab7d7fd3d.camel@sipsolutions.net> From: "Guilherme G. Piccoli" In-Reply-To: <1760d499824f9ef053af7a8dac04b48ab7d7fd3d.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/05/2022 11:44, Johannes Berg wrote: > [...] >> Maybe Anton / Johannes / Richard could give their opinions - appreciate >> that, I'm not attached to the priority here, it's more about users' >> common usage of UML I can think of... > > It's hard to say ... In a sense I'm not sure it matters? > > OTOH something like the ftrace dump notifier (kernel/trace/trace.c) > might still be useful to run before the mconsole and coredump ones, even > if you could probably use gdb to figure out the information. > > Personally, I don't have a scenario where I'd care about the trace > buffers though, and most of the others I found would seem irrelevant > (drivers that aren't even compiled, hung tasks won't really happen since > we exit immediately, and similar.) > > johannes Thanks Johannes, I agree with you. We don't have great ordering now, one thing we need to enforce is the order between the 2 UML notifiers, and this patch is doing that..trying to order against other callbacks like the ftrace dumper is messy in the current code. OTOH if this patch set is accepted at some point, we'll likely have 3 lists, and with that we can improve ordering a lot - this notifier for instance would run in the pre-reboot list, *after* the ftrace dumper (if a kmsg dumper is set). So, my intention is to keep this patch as is for V2 (with some changes Johannes suggested before), unless Petr or the other maintainers want something different. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Sun May 15 22:49:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 22:49:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329542.552782 (Exim 4.92) (envelope-from ) id 1nqN2k-0006RM-Uu; Sun, 15 May 2022 22:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329542.552782; Sun, 15 May 2022 22:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqN2k-0006RF-S9; Sun, 15 May 2022 22:48:54 +0000 Received: by outflank-mailman (input) for mailman id 329542; Sun, 15 May 2022 22:48:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqN2h-0006R9-SJ for xen-devel@lists.xenproject.org; Sun, 15 May 2022 22:48:53 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2dcfdbfa-d4a1-11ec-aa76-f101dd46aeb6; Mon, 16 May 2022 00:48:49 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqN22-005kj2-70; Mon, 16 May 2022 00:48:10 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dcfdbfa-d4a1-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=93lwEQzS5IXDyIA/NgwVVg/rNYgBX/Ekc2xpjleQYUs=; b=kTFBpmweCVBGzCiXcny/Ei9sEB uLvI0D7aJyCY9gW4MGXg7URDXPxUenVwWXA89vT+j9BRtrs1EQfNeJ4qB6gH1x3WL3JnCBSUAhoXN 1INIRQN5V3AcrCr4dPVHFH/5EtxkbxYQW14SNMurRWenslQKNiT8uXf6mSEvQOr2XsmvD7L3cVekK G4ucrnvqt1/qzfQAz5Rre/uP6rIw96QRGg/Ntwc578rmZP+ob6saFKUKA0qaw+P9NiH2QNSqjbmfS xeJNCdUwDvi5QchOtqGvFJPXe/AnKHhlIFK8hoqIAjFEroOQ6KccSYTKVhehD92Fv+lP928LorOpQ iXFJTFmg==; Message-ID: Date: Sun, 15 May 2022 19:47:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: Petr Mladek , "michael Kelley (LINUX)" , Baoquan He , Dave Young , d.hatayama@jp.fujitsu.com Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/05/2022 11:03, Petr Mladek wrote: > Hello, > > first, I am sorry for stepping into the discussion so late. > I was busy with some other stuff and this patchset is far > from trivial. > > Second, thanks a lot for putting so much effort into it. > Most of the changes look pretty good, especially all > the fixes of particular notifiers and split into > four lists. > > Though this patch will need some more love. See below > for more details. Thanks a lot for your review Petr, it is much appreciated! No need for apologies, there is no urgency here =) > [...] > This talks only about kdump. The reality is much more complicated. > The level affect the order of: > > + notifiers vs. kdump > + notifiers vs. crash_dump > + crash_dump vs. kdump First of all, I'd like to ask you please to clarify to me *exactly* what are the differences between "crash_dump" and "kdump". I'm sorry if that's a silly question, I need to be 100% sure I understand the concepts the same way you do. > There might theoretically many variants of the ordering of kdump, > crash_dump, and the 4 notifier list. Some variants do not make > much sense. You choose 5 variants and tried to select them by > a level number. > > The question is if we really could easily describe the meaning this > way. It is not only about a "level" of notifiers before kdump. It is > also about the ordering of crash_dump vs. kdump. IMHO, "level" > semantic does not fit there. > > Maybe more parameters might be easier to understand the effect. > Anyway, we first need to agree on the chosen variants. > I am going to discuss it more in the code, see below. > > > [...] > Here is the code using the above functions. It helps to discuss > the design and logic. > > > order_panic_notifiers_and_kdump(); > > /* If no level, we should kdump ASAP. */ > if (!panic_notifiers_level) > __crash_kexec(NULL); > > crash_smp_send_stop(); > panic_notifier_hypervisor_once(buf); > > if (panic_notifier_info_once(buf)) > kmsg_dump(KMSG_DUMP_PANIC); > > panic_notifier_pre_reboot_once(buf); > > __crash_kexec(NULL); > > panic_notifier_hypervisor_once(buf); > > if (panic_notifier_info_once(buf)) > kmsg_dump(KMSG_DUMP_PANIC); > > panic_notifier_pre_reboot_once(buf); > > > I have to say that the logic is very unclear. Almost all > functions are called twice: > > + __crash_kexec() > + kmsg_dump() > + panic_notifier_hypervisor_once() > + panic_notifier_pre_reboot_once() > + panic_notifier_info_once() > > It is pretty hard to find what functions are always called in the same > order and where the order can be inverted. > > The really used code path is defined by order_panic_notifiers_and_kdump() > that encodes "level" into "bits". The bits are then flipped in > panic_notifier_*_once() calls that either do something or not. > kmsg_dump() is called according to the bit flip. > > It is an interesting approach. I guess that you wanted to avoid too > many if/then/else levels in panic(). But honestly, it looks like > a black magic to me. > > IMHO, it is always easier to follow if/then/else logic than using > a translation table that requires additional bit flips when > a value is used more times. > > Also I guess that it is good proof that "level" abstraction does > not fit here. Normal levels would not need this kind of magic. Heheh OK, I appreciate your opinion, but I guess we'll need to agree in disagree here - I'm much more fond to this kind of code than a bunch of if/else blocks that almost give headaches. Encoding such "level" logic in the if/else scheme is very convoluted, generates a very big code. And the functions aren't so black magic - they map a level in bits, and the functions _once() are called...once! Although we switch the position in the code, so there are 2 calls, one of them is called and the other not. But that's totally fine to change - especially if we're moving away from the "level" logic. I see below you propose a much simpler approach - if we follow that, definitely we won't need the "black magic" approach heheh > > OK, the question is how to make it better. Let's start with > a clear picture of the problem: > > 1. panic() has basically two funtions: > > + show/store debug information (optional ways and amount) > + do something with the system (reboot, stay hanged) > > > 2. There are 4 ways how to show/store the information: > > + tell hypervisor to store what it is interested about > + crash_dump > + kmsg_dump() > + consoles > > , where crash_dump and consoles are special: > > + crash_dump does not return. Instead it ends up with reboot. > > + Consoles work transparently. They just need an extra flush > before reboot or staying hanged. > > > 3. The various notifiers do things like: > > + tell hypervisor about the crash > + print more information (also stop watchdogs) > + prepare system for reboot (touch some interfaces) > + prepare system for staying hanged (blinking) > > Note that it pretty nicely matches the 4 notifier lists. > I really appreciate the summary skill you have, to convert complex problems in very clear and concise ideas. Thanks for that, very useful! I agree with what was summarized above. > Now, we need to decide about the ordering. The main area is how > to store the debug information. Consoles are transparent so > the quesition is about: > > + hypervisor > + crash_dump > + kmsg_dump > > Some people need none and some people want all. There is a > risk that system might hung at any stage. This why people want to > make the order configurable. > > But crash_dump() does not return when it succeeds. And kmsg_dump() > users havn't complained about hypervisor problems yet. So, that > two variants might be enough: > > + crash_dump (hypervisor, kmsg_dump as fallback) > + hypervisor, kmsg_dump, crash_dump > > One option "panic_prefer_crash_dump" should be enough. > And the code might look like: > > void panic() > { > [...] > dump_stack(); > kgdb_panic(buf); > > < --- here starts the reworked code --- > > > /* crash dump is enough when enabled and preferred. */ > if (panic_prefer_crash_dump) > __crash_kexec(NULL); > > /* Stop other CPUs and focus on handling the panic state. */ > if (has_kexec_crash_image) > crash_smp_send_stop(); > else > smp_send_stop() > Here we have a very important point. Why do we need 2 variants of SMP CPU stopping functions? I disagree with that - my understanding of this after some study in architectures is that the crash_() variant is "stronger", should work in all cases and if not, we should fix that - that'd be a bug. Such variant either maps to smp_send_stop() (in various architectures, including XEN/x86) or overrides the basic function with more proper handling for panic() case...I don't see why we still need such distinction, if you / others have some insight about that, I'd like to hear =) > /* Notify hypervisor about the system panic. */ > atomic_notifier_call_chain(&panic_hypervisor_list, 0, NULL); > > /* > * No need to risk extra info when there is no kmsg dumper > * registered. > */ > if (!has_kmsg_dumper()) > __crash_kexec(NULL); > > /* Add extra info from different subsystems. */ > atomic_notifier_call_chain(&panic_info_list, 0, NULL); > > kmsg_dump(KMSG_DUMP_PANIC); > __crash_kexec(NULL); > > /* Flush console */ > unblank_screen(); > console_unblank(); > debug_locks_off(); > console_flush_on_panic(CONSOLE_FLUSH_PENDING); > > if (panic_timeout > 0) { > delay() > } > > /* > * Prepare system for eventual reboot and allow custom > * reboot handling. > */ > atomic_notifier_call_chain(&panic_reboot_list, 0, NULL); You had the order of panic_reboot_list VS. consoles flushing inverted. It might make sense, although I didn't do that in V1... Are you OK in having a helper for console flushing, as I did in V1? It makes code of panic() a bit less polluted / more focused I feel. > > if (panic_timeout != 0) { > reboot(); > } > > /* > * Prepare system for the infinite waiting, for example, > * setup blinking. > */ > atomic_notifier_call_chain(&panic_loop_list, 0, NULL); > > infinite_loop(); > } > > > __crash_kexec() is there 3 times but otherwise the code looks > quite straight forward. > > Note 1: I renamed the two last notifier list. The name 'post-reboot' > did sound strange from the logical POV ;-) > > Note 2: We have to avoid the possibility to call "reboot" list > before kmsg_dump(). All callbacks providing info > have to be in the info list. It a callback combines > info and reboot functionality then it should be split. > > There must be another way to calm down problematic > info callbacks. And it has to be solved when such > a problem is reported. Is there any known issue, please? > > It is possible that I have missed something important. > But I would really like to make the logic as simple as possible. OK, I agree with you! It's indeed simpler and if others agree, I can happily change the logic to what you proposed. Although...currently the "crash_kexec_post_notifiers" allows to call _all_ panic_reboot_list callbacks _before kdump_. We need to mention this change in the commit messages, but I really would like to hear the opinions of heavy users of notifiers (as Michael/Hyper-V) and the kdump interested parties (like Baoquan / Dave Young / Hayatama). If we all agree on such approach, will change that for V2 =) Thanks again Petr, for the time spent in such detailed review! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Sun May 15 23:20:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 23:20:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329554.552792 (Exim 4.92) (envelope-from ) id 1nqNXN-0002GI-FZ; Sun, 15 May 2022 23:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329554.552792; Sun, 15 May 2022 23:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqNXN-0002GB-Cb; Sun, 15 May 2022 23:20:33 +0000 Received: by outflank-mailman (input) for mailman id 329554; Sun, 15 May 2022 23:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqNXM-0002G1-M1; Sun, 15 May 2022 23:20:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqNXM-0004YV-KB; Sun, 15 May 2022 23:20:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqNXM-0005A0-2x; Sun, 15 May 2022 23:20:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqNXM-00057c-2R; Sun, 15 May 2022 23:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YH8TS1CHj4/4DtoNB+2qlbbbP9qX1ZbQNcP9MVIAtiY=; b=6AVOBoRhWpmNB3RkKFOPA2MqPc GRkL4HJSAmpufLfwYKEatknEAUfO7fvJah9Dt+mhPe2PQmJotekXB5BK7nRBXyv8lOgF7AKXQpCNU CKdcJXYSUEIOAkrVHFHfMTb+F2gjcue03b9OmNtpYebSacaH5gWMrYZgydE/3Xm1zitI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170461: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 15 May 2022 23:20:32 +0000 flight 170461 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1032 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 51 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 15 23:56:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 15 May 2022 23:56:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329565.552804 (Exim 4.92) (envelope-from ) id 1nqO6A-0005uY-C3; Sun, 15 May 2022 23:56:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329565.552804; Sun, 15 May 2022 23:56:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqO6A-0005uR-9D; Sun, 15 May 2022 23:56:30 +0000 Received: by outflank-mailman (input) for mailman id 329565; Sun, 15 May 2022 23:56:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqO68-0005uH-TH; Sun, 15 May 2022 23:56:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqO68-00059k-OU; Sun, 15 May 2022 23:56:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqO68-0006h9-7n; Sun, 15 May 2022 23:56:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqO68-0007lM-7G; Sun, 15 May 2022 23:56:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ctgaF8VtC55kd0sYc3M1A9XAbiArHYo47LZU4V+UTW4=; b=Cc4ho9+HEpBClB3rUvumvToo61 odeZ/l4Z0mFgENmaXbxCDefFLkmRRSYSxmaPNGczFD3aCz2z14bas+uj/8SkNAXZqGQYAvp/I5FCV Nak8Eqcv5+fjx+8L2pp8PU6pxjTr8C0UIJkyfm2HUB/ZpLYlZnd0UvJondQpDJ/Yt1dw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170454: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=90659487578cd8a46636b4c507609af44c60a132 X-Osstest-Versions-That: linux=01565c91b789a1612051e735a65f11096a6f08e8 From: osstest service owner Date: Sun, 15 May 2022 23:56:28 +0000 flight 170454 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170454/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170353 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170353 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170353 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170353 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170353 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170353 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170353 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170353 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170353 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170353 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170353 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170353 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 90659487578cd8a46636b4c507609af44c60a132 baseline version: linux 01565c91b789a1612051e735a65f11096a6f08e8 Last test of basis 170353 2022-05-12 10:41:33 Z 3 days Testing same since 170454 2022-05-15 18:11:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Andreas Larsson Andrew Morton Florian Fainelli Greg Kroah-Hartman Guenter Roeck Itay Iellin Jakub Kicinski Jani Nikula Jens Axboe Jon Hunter Josh Poimboeuf Kyle Huey Kyle Huey ] Lee Jones Like Xu Linus Torvalds Linux Kernel Functional Testing Luiz Augusto von Dentz Marc Kleine-Budde Masami Hiramatsu Maximilian Heyne Mike Rapoport Muchun Song Nathan Chancellor Nathan Chancellor Paolo Bonzini Peter Zijlstra (Intel) Shuah Khan Sudip Mukherjee Thomas Bogendoerfer jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 01565c91b789..90659487578c 90659487578cd8a46636b4c507609af44c60a132 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Mon May 16 00:09:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 00:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329575.552815 (Exim 4.92) (envelope-from ) id 1nqOIY-00086T-Hc; Mon, 16 May 2022 00:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329575.552815; Mon, 16 May 2022 00:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOIY-00086M-EU; Mon, 16 May 2022 00:09:18 +0000 Received: by outflank-mailman (input) for mailman id 329575; Mon, 16 May 2022 00:09:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOIW-00085t-SI; Mon, 16 May 2022 00:09:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOIW-0005yw-LO; Mon, 16 May 2022 00:09:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOIW-0007O4-8k; Mon, 16 May 2022 00:09:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqOIW-0002dR-8I; Mon, 16 May 2022 00:09:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LzyKzZJmwTPSsF95JJHbk+hPZYw1fFY9dwj+9x/D9D8=; b=SFDAp9Q6/fdRPdHSg5tOBcEm/k AQ7RVmyBTIwwpWeGxGCmQWNkURHJeADyn3bnXv8/WEE/mbSTD4oEtLq/18EcliFYRReUOWKTlO/Cp T5IIipHPi/Tb3J4SqWm62vuKDsZ71l6arqo6k+2vzJDG5Q/g/foj6QjTaGi3GEpcKNQs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170462: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 00:09:16 +0000 flight 170462 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170462/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1033 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 52 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 00:48:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 00:48:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329586.552825 (Exim 4.92) (envelope-from ) id 1nqOu4-000476-Mq; Mon, 16 May 2022 00:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329586.552825; Mon, 16 May 2022 00:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOu4-00046z-Jb; Mon, 16 May 2022 00:48:04 +0000 Received: by outflank-mailman (input) for mailman id 329586; Mon, 16 May 2022 00:48:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOu3-00046p-5F; Mon, 16 May 2022 00:48:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOu3-0006cK-3H; Mon, 16 May 2022 00:48:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqOu2-0000Ix-NE; Mon, 16 May 2022 00:48:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqOu2-0002yx-Mo; Mon, 16 May 2022 00:48:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VpnJzbkH5EHR2BO95iRAiGPkeaTwNg62U/T6KI+8cYc=; b=pfq9X0wCJ7HgTOPdPr+K7+EjaU PkVe9KLzO0lXty6xR5cpoSI7DI/dTw1XKut5JJP9DxW7ItPI0BN5mNKaPVGwKOC1J80TMzCFauJQI Lj2FeM7655xrJwXD/5s4vF3lHvyUWu+qvroClB6vBovR9dXjqkHlY4F2DJwB2DrgB9qM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170463: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 00:48:02 +0000 flight 170463 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170463/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1034 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 53 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 01:55:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 01:55:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329596.552837 (Exim 4.92) (envelope-from ) id 1nqPx2-0001yb-K7; Mon, 16 May 2022 01:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329596.552837; Mon, 16 May 2022 01:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqPx2-0001yU-Gx; Mon, 16 May 2022 01:55:12 +0000 Received: by outflank-mailman (input) for mailman id 329596; Mon, 16 May 2022 01:55:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqPx1-0001yK-Dk; Mon, 16 May 2022 01:55:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqPx1-0005YR-8l; Mon, 16 May 2022 01:55:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqPx0-0002oz-UM; Mon, 16 May 2022 01:55:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqPx0-0000Gi-Ts; Mon, 16 May 2022 01:55:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7grKRbYpePOtss2Rv0ICbm6SgV0fPAbj4maV7/CXuhE=; b=jns+E0qvCvQFnPZLu9ELCfMPUL DKdUXkfRXoaJWPsMYM52+eA9bin+HvhwBi5oXI0bi4DKYHkQ9WU5v2uIyLelw4VbRAVvQF8+L70FU pl1A7GyAxrvKuO/JH1IPho6Pg4zCmdIBHqSFXZ19Y0e4PX9ksT4yHlcnznqmxOhRmShY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170464: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 01:55:10 +0000 flight 170464 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170464/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 75 days 1035 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 54 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 03:09:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 03:09:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329606.552848 (Exim 4.92) (envelope-from ) id 1nqR75-0001zW-4R; Mon, 16 May 2022 03:09:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329606.552848; Mon, 16 May 2022 03:09:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqR75-0001zP-0n; Mon, 16 May 2022 03:09:39 +0000 Received: by outflank-mailman (input) for mailman id 329606; Mon, 16 May 2022 03:09:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqR73-0001zE-UV; Mon, 16 May 2022 03:09:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqR73-0007iG-PF; Mon, 16 May 2022 03:09:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqR73-0006Bv-Am; Mon, 16 May 2022 03:09:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqR73-0006jZ-A7; Mon, 16 May 2022 03:09:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T2OCncGSQo33jRzDRVawQi64cL8eqYlRisdhueAc+/I=; b=jS1fzgpXAOIqiZfdS/b31X7mSG Lj0WLo7F63mz3LG8QewX63yTKFsvYEsmYIMY9eUjoO/G0J8jKKsm8j1SZnk2nAEo7iIC0B1shH+zR fcx+j2pJweUxrFRYN5EcY2RCyal3I/tynk/Z+uUAItfXdbfoPwPuimrY5aZR0C8Cqgjs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170466: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 03:09:37 +0000 flight 170466 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170466/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1036 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 55 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 04:54:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 04:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329617.552859 (Exim 4.92) (envelope-from ) id 1nqSjy-0004xk-T4; Mon, 16 May 2022 04:53:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329617.552859; Mon, 16 May 2022 04:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqSjy-0004xd-QK; Mon, 16 May 2022 04:53:54 +0000 Received: by outflank-mailman (input) for mailman id 329617; Mon, 16 May 2022 04:53:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqSjx-0004xT-LX; Mon, 16 May 2022 04:53:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqSjx-0001CJ-Hi; Mon, 16 May 2022 04:53:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqSjx-0003Lq-2R; Mon, 16 May 2022 04:53:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqSjw-0003kb-W8; Mon, 16 May 2022 04:53:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wk0vKy7T8FkNS0YyH6/8pYH/0cOAyqylXgXVzbWBFwI=; b=POss45WKpkT0IuYW/pu+GC16+z HHBe16armHtn/8QXLOx0UB1WzpR9naNvoC+pFX+deEvJMR6Vp5AIunHO4tCHrEKvnxhTCBJp9aGXl 0x5Xt5OsHPsVMc55YP2VLA8D53HZKS9WNuRr8VRx5g+H53qbznir+LnOYqcHDc0NT9l4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170467: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 04:53:52 +0000 flight 170467 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170467/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1037 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 56 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 05:16:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 05:16:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329628.552870 (Exim 4.92) (envelope-from ) id 1nqT5p-0007sl-Tv; Mon, 16 May 2022 05:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329628.552870; Mon, 16 May 2022 05:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqT5p-0007se-P0; Mon, 16 May 2022 05:16:29 +0000 Received: by outflank-mailman (input) for mailman id 329628; Mon, 16 May 2022 05:16:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqT5p-0007sU-65; Mon, 16 May 2022 05:16:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqT5p-0001ti-1v; Mon, 16 May 2022 05:16:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqT5o-00057l-LV; Mon, 16 May 2022 05:16:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqT5o-00014b-L6; Mon, 16 May 2022 05:16:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oIGk+PKMMbfgN3dtuXF/Wpxe/GGlYPwzRKiXEhOmZ6s=; b=Yv8pC/OQpgBMD8G1cAWtFTrba8 3elt6blFalIQaJCSctFlfLSDTpW6wpKjJpYyUtWn6oiTVW9z5a21zzB8yVylElb/Zpn7rsmgUQZZy xkqW5Fd9bt32H3Ho35xad+zv+4p1XMowNH/smKuFNO4vgeNeTWu9nbQXBy+KB26JBQYE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170459: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-thunderx:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0cdd776ec92c0fec768c7079331804d3e52d4b27 X-Osstest-Versions-That: linux=bc403203d65a874df2f3156046468052e4109cb0 From: osstest service owner Date: Mon, 16 May 2022 05:16:28 +0000 flight 170459 linux-linus real [real] flight 170469 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170459/ http://logs.test-lab.xenproject.org/osstest/logs/170469/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-thunderx 8 xen-boot fail pass in 170469-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 170469 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 170469 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170450 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170450 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170450 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170450 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170450 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170450 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170450 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170450 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 0cdd776ec92c0fec768c7079331804d3e52d4b27 baseline version: linux bc403203d65a874df2f3156046468052e4109cb0 Last test of basis 170450 2022-05-15 14:09:40 Z 0 days Testing same since 170459 2022-05-15 21:42:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: AngeloGioacchino Del Regno Catalin Marinas ChiYuan Huang Chunfeng Yun Dan Vacura Daniel Starke Darren Hart Ethan Yang Fabien Parent Georgi Djakov Greg Kroah-Hartman Heikki Krogerus Indan Zupancic Johan Hovold Jonathan Corbet Linus Torvalds Luis Chamberlain Macpaul Lin Miaoqian Lin Oliver Neukum Schspa Shi Scott Chen Sergey Ryazanov Srinivas Kandagatla Stephen Boyd Sven Schwermer Thiébaud Weksteen Uwe Kleine-König Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git bc403203d65a..0cdd776ec92c 0cdd776ec92c0fec768c7079331804d3e52d4b27 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 16 06:00:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 06:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329638.552881 (Exim 4.92) (envelope-from ) id 1nqTln-0003vr-47; Mon, 16 May 2022 05:59:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329638.552881; Mon, 16 May 2022 05:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqTln-0003vk-1F; Mon, 16 May 2022 05:59:51 +0000 Received: by outflank-mailman (input) for mailman id 329638; Mon, 16 May 2022 05:59:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqTll-0003ve-Qo for xen-devel@lists.xenproject.org; Mon, 16 May 2022 05:59:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 634ed178-d4dd-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 07:59:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 01E1C1FB11; Mon, 16 May 2022 05:59:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9AD9A13ADC; Mon, 16 May 2022 05:59:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KPiWI1HogWKZKQAAMHmgww (envelope-from ); Mon, 16 May 2022 05:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 634ed178-d4dd-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652680786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zsD+46oUPuW0iPz0GLsFUXWAhM91AFgIGDek/lB5qYU=; b=jMA7VDav2WLpRn4hMNcnLjbBCX016a90Ibh9ib2bqJK4sJd4FERHYDGkjF08ABP7tq4rpS AylMDkrFH0PYYGWP7DcEW0ksmkvkweEFA9LPGcx+fHanQf4tYiFGSE8mJb4uBzNyP6+gCC nmxTNJb5g6UFnUrh92KT8TsIxr2rOsE= Message-ID: Date: Mon, 16 May 2022 07:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Boris Ostrovsky , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> From: Juergen Gross In-Reply-To: <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------izYTztBjmky4hprP0vEByjQ4" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------izYTztBjmky4hprP0vEByjQ4 Content-Type: multipart/mixed; boundary="------------QqNa6f4NuYZAGd14Kzq0ennD"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Message-ID: Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> In-Reply-To: <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> --------------QqNa6f4NuYZAGd14Kzq0ennD Content-Type: multipart/mixed; boundary="------------Kc08gidKELCxlELvXF0EJn76" --------------Kc08gidKELCxlELvXF0EJn76 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTQuMDUuMjIgMDQ6MzQsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IA0KPiBP biA1LzEzLzIyIDE6MzMgQU0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAxMi4wNS4y MiAyMjowMSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPj4+DQo+Pj4gT24gNS83LzIyIDI6 MTkgUE0sIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4+Pj4gKy8qIFJlYnVp bGRzIHRoZSBmcmVlIGdyYW50IGxpc3QgYW5kIHRyaWVzIHRvIGZpbmQgY291bnQgY29uc2Vj dXRpdmUgDQo+Pj4+IGVudHJpZXMuICovDQo+Pj4+ICtzdGF0aWMgaW50IGdldF9mcmVlX3Nl cSh1bnNpZ25lZCBpbnQgY291bnQpDQo+Pj4+ICt7DQo+Pj4+ICvCoMKgwqAgaW50IHJldCA9 IC1FTk9TUEM7DQo+Pj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGZyb20sIHRvOw0KPj4+PiAr wqDCoMKgIGdyYW50X3JlZl90ICpsYXN0Ow0KPj4+PiArDQo+Pj4+ICvCoMKgwqAgZ250dGFi X2ZyZWVfdGFpbF9wdHIgPSAmZ250dGFiX2ZyZWVfaGVhZDsNCj4+Pj4gK8KgwqDCoCBsYXN0 ID0gJmdudHRhYl9mcmVlX2hlYWQ7DQo+Pj4+ICsNCj4+Pj4gK8KgwqDCoCBmb3IgKGZyb20g PSBmaW5kX2ZpcnN0X2JpdChnbnR0YWJfZnJlZV9iaXRtYXAsIGdudHRhYl9zaXplKTsNCj4+ Pj4gK8KgwqDCoMKgwqDCoMKgwqAgZnJvbSA8IGdudHRhYl9zaXplOw0KPj4+PiArwqDCoMKg wqDCoMKgwqDCoCBmcm9tID0gZmluZF9uZXh0X2JpdChnbnR0YWJfZnJlZV9iaXRtYXAsIGdu dHRhYl9zaXplLCB0byArIDEpKSB7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCB0byA9IGZpbmRf bmV4dF96ZXJvX2JpdChnbnR0YWJfZnJlZV9iaXRtYXAsIGdudHRhYl9zaXplLA0KPj4+PiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJvbSArIDEpOw0KPj4+ PiArwqDCoMKgwqDCoMKgwqAgaWYgKHJldCA8IDAgJiYgdG8gLSBmcm9tID49IGNvdW50KSB7 DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IGZyb207DQo+Pj4+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGJpdG1hcF9jbGVhcihnbnR0YWJfZnJlZV9iaXRtYXAsIHJl dCwgY291bnQpOw0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmcm9tICs9IGNvdW50 Ow0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnbnR0YWJfZnJlZV9jb3VudCAtPSBj b3VudDsNCj4+Pg0KPj4+DQo+Pj4gSUlVSUMgd2UgY2FuIGhhdmUgbXVsdGlwbGUgcGFzc2Vz IG92ZXIgdGhpcywgbWVhbmluZyB0aGF0IHRoZSANCj4+PiBnbnR0YWJfZnJlZV9jb3VudCBt YXkgYmUgZGVjcmVtZW50ZWQgbW9yZSB0aGFuIG9uY2UuIElzIHRoYXQgaW50ZW50aW9uYWw/ DQo+Pg0KPj4gQWZ0ZXIgdGhlIGZpcnN0IHBhc3MgZGVjcmVtZW50aW5nIGdudHRhYl9mcmVl X2NudCwgcmV0IHdpbGwgbm8NCj4+IGxvbmdlciBiZSBsZXNzIHRoYW4gemVybywgc28gdGhp cyBjYW4gYmUgaGl0IG9ubHkgb25jZS4NCj4gDQo+IE9oLCB5ZXMsIG9mIGNvdXJzZS4NCj4g DQo+Pg0KPj4+DQo+Pj4NCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGZyb20g PT0gdG8pDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29udGludWU7 DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+Pj4+ICsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKg IHdoaWxlIChmcm9tIDwgdG8pIHsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKmxh c3QgPSBmcm9tOw0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsYXN0ID0gX19nbnR0 YWJfZW50cnkoZnJvbSk7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdudHRhYl9s YXN0X2ZyZWUgPSBmcm9tOw0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmcm9tKys7 DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+Pj4NCj4+Pg0KPj4+IEkgaGF2ZSBiZWVuIGxv b2tpbmcgYXQgdGhpcyBsb29wIGFuZCBJIGNhbid0IHVuZGVyc3RhbmQgd2hhdCBpdCBpcyBk b2luZyA7LSggDQo+Pj4gQ2FuIHlvdSBlbmxpZ2h0ZW4gbWU/DQo+Pg0KPj4gSXQgaXMgcmVj cmVhdGluZyB0aGUgZnJlZSBsaXN0IGluIG9yZGVyIHRvIGhhdmUgaXQgcHJvcGVybHkgc29y dGVkLg0KPj4gVGhpcyBpcyBuZWVkZWQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIGZyZWUgdGFp bCBoYXMgdGhlIG1heGltdW0NCj4+IHBvc3NpYmxlIHNpemUgKHlvdSBjYW4gdGFrZSB0aGUg dGFpbCBvZmYgdGhlIGxpc3Qgd2l0aG91dCBoYXZpbmcNCj4+IHRvIHdvcnJ5IGFib3V0IGJy ZWFraW5nIHRoZSBsaW5rZWQgbGlzdCBiZWNhdXNlIG9mIHJlZmVyZW5jZXMgaW50bw0KPj4g dGhlIHRhaWwpLg0KPiANCj4gDQo+IFNvIGxldCdzIHNheSB3ZSBoYXZlIHRoZSAob25lLWRp bWVuc2lvbmFsKSB0YWJsZSBvZiBsZW5ndGggMTMNCj4gDQo+IGlkeMKgwqDCoCAuLsKgwqDC oCAywqDCoMKgIDPCoCAuLi7CoCAxMMKgIDExwqAgMTINCj4gDQo+IGdyYW50wqDCoMKgwqDC oMKgIDEywqDCoCAxMcKgwqDCoMKgwqDCoMKgIDLCoCAtMcKgwqAgMw0KPiANCj4gDQo+IGFu ZCBnbnR0YWJfZnJlZV9oZWFkIGlzIDEwLiBJLmUuIHRoZSBmcmVlIGxpc3QgaXMgMiwgMTIs IDMsIDExLg0KDQpZb3UgbWVhbnQgMTAsIDIsIDEyLCAzLCAxMSwgSSBndWVzcz8NCg0KPiAN Cj4gV2hhdCB3aWxsIHRoaXMgbG9vayBsaWtlIGFmdGVyIHRoZSAyIGl0ZXJhdGlvbnMgb2Yg dGhlIG91dGVyIGxvb3A/DQoNCmlkeCAgICAuLiAgICAyICAgIDMgIC4uLiAgMTAgIDExICAx Mg0KDQpncmFudCAgICAgICAgMyAgIDEwICAgICAgIDExICAxMiAgLTENCg0Kd2l0aCBnbnR0 YWJfZnJlZV9oZWFkIGJlaW5nIDIsIGkuZSB0aGUgZnJlZSBsaXN0IGlzIG5vdyAyLCAzLCAx MCwgMTEsIDEyLg0KDQoNCkp1ZXJnZW4NCg== --------------Kc08gidKELCxlELvXF0EJn76 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Kc08gidKELCxlELvXF0EJn76-- --------------QqNa6f4NuYZAGd14Kzq0ennD-- --------------izYTztBjmky4hprP0vEByjQ4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKB6FEFAwAAAAAACgkQsN6d1ii/Ey/d EQgAiKCBU/TDtz6MajOwcYCi/wUu4GKy6pG13fgmx30aWBd2dm7HxTJaDmS0VS/h5kJDtRtYZpxD btng409Ev/OZ82h0vvZocXNI5KSVUHOBUVfNda7UfUDbf/S9Z19GkRAd4TcpnvK7rt7FODLP1S7a GO3kjy2SMYtqtqZxoxuxzim730M/9rPCVDM7nXhEw3bha1b0wMQ5l8rVxDfd1oLuY1xgvV8gDYxW 3s2fa4vDj3t7u3L6mKSvQbofqd+fRu01fUtBH5VC1bOsWmSdbSRbzl5qjTk4Y/IRag3k0NzkPT4r //GM8ltxQYcISIIWeSG5VkuTjl/fNlEfKPRqiGkIBw== =mcgR -----END PGP SIGNATURE----- --------------izYTztBjmky4hprP0vEByjQ4-- From xen-devel-bounces@lists.xenproject.org Mon May 16 06:35:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 06:35:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329647.552892 (Exim 4.92) (envelope-from ) id 1nqUKM-0000Vz-2h; Mon, 16 May 2022 06:35:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329647.552892; Mon, 16 May 2022 06:35:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUKL-0000Vs-UO; Mon, 16 May 2022 06:35:33 +0000 Received: by outflank-mailman (input) for mailman id 329647; Mon, 16 May 2022 06:35:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUKK-0000Vi-JY; Mon, 16 May 2022 06:35:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUKK-0003Fo-H0; Mon, 16 May 2022 06:35:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUKJ-0003yA-VJ; Mon, 16 May 2022 06:35:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqUKJ-0004wx-Un; Mon, 16 May 2022 06:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s6rEIkhLQoV2EQ2qjVwyUdZs6tyystUjbhLcg1nK1eU=; b=xu3QCEwlD+JfKMIUam56RbSZkj GCMwXtxYLCF9N2WrYtR4RLOszEviouzIOhyE4tpF/++rEHYsRgmb39y96k7qIo6J+M9R7AcTzOrxP T7XD6UjadRLYG4qSro6EPC0kZSC+a7OT+995qse4cgvDWyYu0HSV4IY0/gZp3taDAnGE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170471: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 06:35:31 +0000 flight 170471 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170471/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1038 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 57 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 06:48:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 06:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329657.552902 (Exim 4.92) (envelope-from ) id 1nqUWj-0002C0-7B; Mon, 16 May 2022 06:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329657.552902; Mon, 16 May 2022 06:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUWj-0002Bt-4O; Mon, 16 May 2022 06:48:21 +0000 Received: by outflank-mailman (input) for mailman id 329657; Mon, 16 May 2022 06:48:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqUWh-0002Bn-Rx for xen-devel@lists.xenproject.org; Mon, 16 May 2022 06:48:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b415d93-d4e4-11ec-aa76-f101dd46aeb6; Mon, 16 May 2022 08:48:18 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2CA6D1F8FE; Mon, 16 May 2022 06:48:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B64FA13ADC; Mon, 16 May 2022 06:48:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eNy9KrHzgWK3PAAAMHmgww (envelope-from ); Mon, 16 May 2022 06:48:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b415d93-d4e4-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652683698; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VxwhfMGZJ/R43Jur0qAAkcbyv2KGM6CayzfM3eb9a8=; b=RcnRSwyIGPt8PoOuYWjSpDBz2UdEitRp5Aw2hFzHEIBgAmZlt+AcinzUsD55eyGVw3zftf EMJGT5arOKRs2/lEVOZDk6XYviFicQOusz+6bewbpQUCbo+0cmabdfTTtaiJCvjRusH2Xf AM6lbbp1htGMA2UJjys8sUxR7RQDI98= Message-ID: <55436ae1-8255-1898-00df-51261080cd41@suse.com> Date: Mon, 16 May 2022 08:48:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Demi Marie Obenour , Xen developer discussion Cc: Boris Ostrovski , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development References: From: Juergen Gross Subject: Re: Hang in 5.17.4+ that appears to be due to Xen In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E3p00huEUrrTJ9brwKFwwior" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------E3p00huEUrrTJ9brwKFwwior Content-Type: multipart/mixed; boundary="------------oH2iaJ0jTX0y0uRnsowBQVfz"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Xen developer discussion Cc: Boris Ostrovski , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development Message-ID: <55436ae1-8255-1898-00df-51261080cd41@suse.com> Subject: Re: Hang in 5.17.4+ that appears to be due to Xen References: In-Reply-To: --------------oH2iaJ0jTX0y0uRnsowBQVfz Content-Type: multipart/mixed; boundary="------------WKi2f0oZMCLjThKhlF63EhgJ" --------------WKi2f0oZMCLjThKhlF63EhgJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTQuMDUuMjIgMTc6NTUsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gSW4gaHR0 cHM6Ly9naXRodWIuY29tL1F1YmVzT1MvcXViZXMtaXNzdWVzL2lzc3Vlcy83NDgxLCBhIHVz ZXIgcmVwb3J0ZWQNCj4gdGhhdCBYb3JnIGxvY2tlZCB1cCB3aGVuIHJlc2l6aW5nIGEgVk0g d2luZG93LiAgV2hpbGUgSSBkbyBub3QgaGF2ZSB0aGUNCj4gc2FtZSBoYXJkd2FyZSB0aGUg dXNlciBkb2VzIGFuZCB0aHVzIGNhbm5vdCByZXByb2R1Y2UgdGhlIGJ1ZywgdGhlIHN0YWNr DQo+IHRyYWNlIHNlZW1zIHRvIGluZGljYXRlIGEgZGVhZGxvY2sgYmV0d2VlbiB4ZW5fZ250 ZGV2IGFuZCBpOTE1LiAgSXQNCj4gYXBwZWFycyB0aGF0IGdudHRhYl91bm1hcF9yZWZzX3N5 bmMoKSBpcyB3YWl0aW5nIGZvciBpOTE1IHRvIGZyZWUgdGhlDQo+IHBhZ2VzLCB3aGlsZSBp OTE1IGlzIHdhaXRpbmcgZm9yIHRoZSBNTVUgbm90aWZpZXIgdGhhdCBjYWxsZWQNCj4gZ250 dGFiX3VubWFwX3JlZnNfc3luYygpIHRvIHJldHVybi4gIFJlc3VsdDogZGVhZGxvY2suDQo+ IA0KPiBUaGUgcHJvYmxlbSBhcHBlYXJzIHRvIGJlIHRoYXQgYSBtYXBwZWQgZ3JhbnQgaW4g UFYgbW9kZSB3aWxsIHN0YXkgaW4NCj4gdGhlIOKAnGludmFsaWRhdGluZ+KAnSBzdGF0ZSB1 bnRpbCBpdCBpcyBmcmVlZC4gIFdoaWxlIE1NVSBub3RpZmllcnMgYXJlDQo+IGFsbG93ZWQg dG8gc2xlZXAsIGl0IGFwcGVhcnMgdGhhdCB0aGV5IGNhbm5vdCB3YWl0IGZvciB0aGUgcGFn ZSB0byBiZQ0KPiBmcmVlZCwgYXMgaXMgaGFwcGVuaW5nIGhlcmUuICBUaGF0IHNhaWQsIEkg YW0gbm90IHZlcnkgZmFtaWxpYXIgd2l0aA0KPiB0aGlzIGNvZGUsIHNvIG15IGRpYWdub3Np cyBtaWdodCBiZSBpbmNvcnJlY3QuDQoNCkFsbCBJIGNhbiBzYXkgZm9yIG5vdyBpcyB0aGF0 IHlvdXIgcGF0Y2ggc2VlbXMgdG8gYmUgaW50cm9kdWNpbmcgYSB1c2UgYWZ0ZXINCmZyZWUg aXNzdWUsIGFzIHRoZSBwYXJhbWV0ZXJzIG9mIHRoZSBkZWxheWVkIHdvcmsgbWlnaHQgZ2V0 IGZyZWVkIG5vdyBiZWZvcmUNCnRoZSBkZWxheWVkIHdvcmsgaXMgYmVpbmcgZXhlY3V0ZWQu DQoNCkkgZG9uJ3Qga25vdyB3aHkgdGhpcyBpcyBoYXBwZW5pbmcgb25seSB3aXRoIHJhdGhl ciByZWNlbnQga2VybmVscywgYXMgdGhlDQpsYXN0IGdudGRldiBjaGFuZ2VzIGluIHRoaXMg YXJlYSBoYXZlIGJlZW4gbWFkZSBpbiBrZXJuZWwgNC4xMy4NCg0KSSdkIHN1Z2dlc3QgdG8g bG9vayBhdCBpOTE1LCBhcyBxdWl0ZSBzb21lIHdvcmsgaGFzIGhhcHBlbmVkIGluIHRoZSBj b2RlDQp2aXNpYmxlIGluIHlvdXIgc3RhY2sgYmFja3RyYWNlcyByYXRoZXIgcmVjZW50bHku IE1heWJlIGl0IHdvdWxkIGJlIHBvc3NpYmxlDQp0byBmcmVlIHRoZSBwYWdlcyBpbiBpOTE1 IGJlZm9yZSBjYWxsaW5nIHRoZSBNTVUgbm90aWZpZXI/DQoNCkFkZGluZyB0aGUgaTkxNSBt YWludGFpbmVycy4NCg0KDQpKdWVyZ2VuDQo= --------------WKi2f0oZMCLjThKhlF63EhgJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WKi2f0oZMCLjThKhlF63EhgJ-- --------------oH2iaJ0jTX0y0uRnsowBQVfz-- --------------E3p00huEUrrTJ9brwKFwwior Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKB87EFAwAAAAAACgkQsN6d1ii/Ey+C tQf/SGMmi/nRrYjUWG8qfocSmDp74/8ZPIwH5Mm3EjGlPbv7Rclq+7DwpgDWkFfXp2XDVqP1liWC jkC1jfmAWXVyREfrgLwM2FpuS3Lr+tnpXhds3f9oBthWrW92gbVFNzyZ2tQBmWFw99DJDcJ+gXtq 3XVcspqAIwCz3RWF2v65HnPbQd3fHA9vHp7wtJP1syO25ZyNiAj7HZmWdISZ6EgAhYOtVeZN2Ux8 mUMlalT18ACunsolrLIa6UV0JqYVrkvTAy0Tqas31mnMEBIMPrFmkmxL/iHNwnVR3ooVelddSsn5 xcRc6SUsZ22X9Fdqh+n2a2USnJdh7BAWWchlymJmDg== =kaAe -----END PGP SIGNATURE----- --------------E3p00huEUrrTJ9brwKFwwior-- From xen-devel-bounces@lists.xenproject.org Mon May 16 08:01:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 08:01:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329668.552913 (Exim 4.92) (envelope-from ) id 1nqVfe-0002fz-08; Mon, 16 May 2022 08:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329668.552913; Mon, 16 May 2022 08:01:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqVfd-0002fs-Tb; Mon, 16 May 2022 08:01:37 +0000 Received: by outflank-mailman (input) for mailman id 329668; Mon, 16 May 2022 08:01:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqVfc-0002fj-Mc for xen-devel@lists.xenproject.org; Mon, 16 May 2022 08:01:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 656e320e-d4ee-11ec-aa76-f101dd46aeb6; Mon, 16 May 2022 10:01:34 +0200 (CEST) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 04:01:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4562.namprd03.prod.outlook.com (2603:10b6:408:c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 08:01:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.018; Mon, 16 May 2022 08:01:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 656e320e-d4ee-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652688093; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QuJUObv6EO2DGUUORLVUsY6Cio9YAWLre9+7S/B2InE=; b=XD9GJtOohch2xModnO93VxgK46Mqbcs/yy1KHK0podD9AN1Uhcm60HaZ 4SYFeUoPGkTRWpZ73L16nQGlHe3oGofM1r1RqBG7ipK6q4Laep4gvohaa eGX2r0vLOxVyZE/8OB1Y8JNHAtAgyA/LkzgoweRwoxFld4nRVW5cuDv8G I=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 71367930 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:O9AEUq1RXM9KHupSH/bD5c9wkn2cJEfYwER7XKvMYLTBsI5bp2NTy GMcWT3Vb6uDYmrwctF+OY+zpkNUupfWzINmGgZqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx3IDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0OkJuZZBU3D5fVgcc3dDxzGS9sI5NvreqvzXiX6aR/zmXgWl61m7BCKR9zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyStbe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamKGMH+QnNzUYxy1btkR549bv0DNvIfY2uHcd7l2Ofu H2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqF+Owm0eDjUGWF39puO24malQM5WI UEQ/isorIAx+VatQ927WAe3yFabujYMVtwWFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHjVGOYXeU97PRoTbsPyEQdDcGfXVdFVtD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zlm/sr6Nhu+hWLOYWg== IronPort-HdrOrdr: A9a23:MrgIb6H4pJdKoVx0pLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="scan'208";a="71367930" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKZTd+O0cVsP/DuBofYaui54oNSuAkVEYND+1YpAsdAxaXud6ci6yvlFi7rSaz/vRP/wcWTqPCKK9P5kwFTHzByFUGdEacihTI1V8PPQx0I+Mz7NpXOnl6i+HRbRTew2A7FEtzOialAKOPuZVgoe+FXkb5lnxq8PZOzC6o0NxMvOfbVoI1Xe3sIfJjNOopl/AH2WmS/SZxochha9PQibgtokz33Wr9jCjjXuwcweLGWuFwUTsgohQnkpjp9ToHLyiDzhXHPb7FdJiGa/DrmSUzgfbSNedBKlFLawgapBGhDdR4yXNiW6KromSA1jDASd/zejHbdavC8NxUaS2WLL1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3v/XY/s4YhK9eCx7T5dR+Sa7+2kz9kcTtexHu8OqOzs=; b=RrDq1UaG7pbvFdCfQ5IqR74NX/90MBAu2HXxNRSUHa8fqXB7MIoWTVa92+V8gwP1bNbS9LUESst3vlqDWh9tJyXO8TB6dEJnUG4643nvQUIOXR19NKi1XbmKuy9dM4fdQt4Cc39iXhpKT9sDaQN4yUc+ifpe+lIx5o+0y18z/klBl+RfMBzZcbWA+Q3+TvJgAdlAlT4a6RmKdDsCbcBe/iP3rpYPY1QdNseRIKyIh0uj3gD7USnFAmXaK1yF8oJgMnpxSxNViujpspabqNo+5FWMYkLg+9F0p9w5WrZC3ybfKyZ9nvfAYRXBiuzEvqCnx08zOrI8OQIGgmi3jiJFow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3v/XY/s4YhK9eCx7T5dR+Sa7+2kz9kcTtexHu8OqOzs=; b=tndwhVd4e+NC1LJs2GPL9CpRVfNjf9gTtIpWUciU2mLFuTNd9Ta5Z9njCPjosg6hdctpCR0xClPq7ua1EcwQRzMs+SbW9yk0O5RGI1M7dDwCbeOScYxIFl/vNLrL7paO8IWPfLinusZn7eWJs0gLR23haUBHkOpk6DqpRPmz7gU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 16 May 2022 10:01:21 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Message-ID: References: <20220505142137.51306-1-roger.pau@citrix.com> <5cb23441-d8c1-5640-d630-30881841db0c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cb23441-d8c1-5640-d630-30881841db0c@suse.com> X-ClientProxiedBy: BL1PR13CA0026.namprd13.prod.outlook.com (2603:10b6:208:256::31) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f665eb09-cafb-42f1-8921-08da37124611 X-MS-TrafficTypeDiagnostic: BN7PR03MB4562:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BDj2A3BS0VH6S3kHvXupFnX/SoUhKn7CyldDDPDaMot17kgVxe7TFu3MncQk6qaiotx6Q0u6Eifl08EdBj/50p/Zb/wGR1xh7MeI/BjE00sBbCzwg7oexq02hkDKQq5vW18d0n343ADfJ2EE7WlwTOQAa5/d19b3znbAfHrxsZC6pgetYixgdxJVY6niT253D+x2KHGVbhpjmtMHxbpflVDydaqsG+gGXK247p7bpvuO67h+eA4H7p5QT8R8yfIgracZPsxLyUsVhOWmqspClNnh+6R17oCma7BRWiL6veW7zwZGhqBJMNo7/1xyABvESARDD5b86IpuIKhdR2ce+jdJe0EA+zlonn4m2Ed7SunExFnobW4ymSuoTqovuiBCN//nsVyp+QjUaaEZsV9j5R+wfkBiKytgppabCkFfHcQ/2kj6hwzMmEYITuRseD/udRORkYnYCBqjFAY+EVy8nvvu+/iRdSb8AsRGtxEb8EfmwejD5SOAUM9LvJUvbebUYGML2nBZkA0CdBOEZFcIJlAv9AKj12ALqaufyU91W6NNiFQZmJYWyVlM/EJG0Sv+BUxA02maj98zXarPjnR2TW3kIZcMmscsu3ptkiMslzj+ucnM70Rt+tsyDOc3jHfhaVUsq98htpihLYkDA2Jh0ettbJhebx09TQ2N2ulv296NWSox0tatLu9TL1kIIX+e8HNTzAXiRH8R7yVaiqNAD7KkQikr7wDDI56NUdlfGmw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66556008)(508600001)(316002)(82960400001)(66476007)(6512007)(86362001)(5660300002)(66946007)(9686003)(6916009)(85182001)(54906003)(33716001)(26005)(38100700002)(966005)(8676002)(6486002)(4326008)(6666004)(2906002)(8936002)(83380400001)(53546011)(6506007)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHdOazd4MzZoQ2lXT1dVTUxhM2RPenR0MmZyQUxZWmNnL2Z4dEdGUEsrL2NB?= =?utf-8?B?WmlIK3ZqNzNWK3BleUMrMEZtcndOY1g1am9OOVlHSHB3TlUyelJuOGxFV2ts?= =?utf-8?B?T09DSlROd24wNnNRNFRHcEJ6S0U5b2NMWmQwa1pLVXdoZWJyak00OW9QUlJU?= =?utf-8?B?Ny9HdmdiNEQxejdSK1o0MENKOWowa2trM3VRTHFxa0JkL3VLVlRnYkNIeUJH?= =?utf-8?B?aWc2dUp0UkJDaU96ZXpKaHBIQnVEMHJFYTI2Z1BEaG50VG5nUlpETnNYU0pH?= =?utf-8?B?WmhUUExLdVF1VTYrMG5jalZSSjREaThRU3JFRk9UdzNJV20vc2NqQVhvVUQx?= =?utf-8?B?Wlk4cnZRdytQakJqN3J2c0dKY1VXaUZqQ0owcDY2WDBTV29SRWFBTWZ2bzlh?= =?utf-8?B?eUVVRDI0MUlMek0xdlE5ZUVtRTUvdzFjNzh0S094UEVnT0pIVC9kTW50SDZN?= =?utf-8?B?Sno3dkhIZXgxaFc1ZGtnU1lmaTYrRXBLYmRna0d6M2phTmNCd3RKeXhvbzRN?= =?utf-8?B?U3dudWtxTU5ob0RiakZRdStBeFV4NEd4TGtrQ3dTVldkRmxVYXFNTWQ4WERu?= =?utf-8?B?eE1UeDRiVno0eFZoZFRHZytlV0tDcng0NW9vWG5jVXVxZ3FVSFp1OGtVK2FQ?= =?utf-8?B?cE4vL1RTd3htRityaW0wQmk2RlJic2t5eFBMWm9wVkxTOTZFVWxSYUlzR1RD?= =?utf-8?B?Y0pDTEdVZjMrcDJqSTRHU1crWGErZmRpVEk3TmY2bnVmZzZQKzdWdHBwQVdV?= =?utf-8?B?dDM4aS82Z2hOcm5MWVd0Y0dpZ3Vmb0RGbnFUTlZxcFZPd2dwNDI5QmNnZ1Y1?= =?utf-8?B?UnZlTGZQK3V3c29lT0o2eVdXT3JTbkcrOXgzY2MxVmIxVmoyTHBOV2dOcS9r?= =?utf-8?B?bXQxZUlvc2NKc3BBbllWMmR3ZUhEWWxJR1k0bkFjMlB0YlhVMWw2SHQ3MENG?= =?utf-8?B?K3FybmF1dTZDS1NQWGhOeHRBbGlHT09mTXdLYXFZNUp4V2p5dGZUNGhJdE1n?= =?utf-8?B?b1dRcDg0TlRURTdXNmhNdUtLS3dBUDF6T3RzazBOdmVhK3A2TkZxaEFidnJD?= =?utf-8?B?dnJNdkNkaS9DOENCbXFVOG1BSUw2andLZlIya0xRbjFNTnptSXYyYTl6eVVr?= =?utf-8?B?aktYNXNDWWNmRFdpM2M1UXgzNVZEUUg3WXRLaVlZVUhESnRvc0U0QUx1T1dV?= =?utf-8?B?eTlCZnR3Mjhua0hPcjFuVUNOVzRQcUxkREhNL0JVSFgxYml5T1hZZi85QUFH?= =?utf-8?B?R0JnZ3o2bklVMDduV1YxVkdRS0FZZXJkcEo0V2NhT0hDSGFxNTdmM0tmdVdW?= =?utf-8?B?WU9xR205cDhwNy9lMzd3dnRQREpUUHV5SGNTYklHQjFXYm5uMUdiM21QK2tm?= =?utf-8?B?L2FBQUk5TDhQanRiblV2SFpkMGV0LzEwOWN1Z3B6Rm5QZXpCSmdDTGNyempn?= =?utf-8?B?V2tKK01makV6MDBWOW5Famo2U0d4K1FPNk1UQ1lwaHljN3BKT3NvZEE1TEZD?= =?utf-8?B?QS9kSVRsdUZQWXQ0bEdGM2xqdTRrWjZyN3F2VVMxcW9Dc1Jpc3U1UTBDeUZZ?= =?utf-8?B?QXlLNzc1SWVMdGVsc3FQNFFxaUF3L08rUWNyOGpMTjdRTzVrUzV2K3QvZ0JE?= =?utf-8?B?YzQwY003Z2RCeG5Dbzg5SUYvODN2dkpKTUgyS1QzWUsvUkFiRjUrR3FGcmxt?= =?utf-8?B?Z2JjWTNlcWl1TnlWdUtuZXZUYUtpRGJwOGM2U0x6dkdISkhsZHdybWRrWkFJ?= =?utf-8?B?dEdyMUJxbUV4N3UzV0ZkME5GbFo1T2tNMmFsUUJmSTRnOXZNU0N0TmRObjlw?= =?utf-8?B?NmxZZldvUDMrM04zM0VWWUNydzJoaU9zWHdHWFJWMkY5OENWTG81L3NJWmZk?= =?utf-8?B?Q2NVU2Z0QytoR3V3bk9LNkgwYkhFditPbVNRdjlXeGQ2N0VvMEYxQllmci9K?= =?utf-8?B?TlhjSURDSUFhZEtiLytnaHlvQUNYTEdneW9pRFNaL2l5dmhjMWFSL2xSWGp0?= =?utf-8?B?T2JPRVdqbWZYMXVLd09WL0dnZlBuK1MzL1hSd08vYVd2UTlxZzJUbG9zaXJm?= =?utf-8?B?dENJUU84cE9lWlA5cTRTZnpTaVJad3orRkpGdVdPeDJKRWY4ZWNCaTBZb1lC?= =?utf-8?B?Unh3K0NvdFlNNFdGcW9CK3c2V3JzWlhGV0tuYk9yREtXcE9pcStUeWRTTzhO?= =?utf-8?B?dlZUQkt4TEdwN3A1SlZ0ZktGRXJXaDM0YVNvcWZqUXpOVHhLWERWQ3l1WTl5?= =?utf-8?B?Vy9zVWRvaDBZb1dKaXA3bENiTmtEVldtZURPVGhnT3R0VFI0QkozUUk3M2hI?= =?utf-8?B?c0Ezc3d3eFFocnYvaUZCNHpnTFo4S1B4RHRhOUxHRUFmSlRnQmp2Zz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f665eb09-cafb-42f1-8921-08da37124611 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 08:01:25.3991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m5Jwkgd7jrlXxjZOmMdY+mxZdUFN3lUmqKXgm/rIrow1BZjum5HKL3mGg8W/Q2lMNBIEPprqFrnJAJd7T2jBFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4562 On Sun, May 08, 2022 at 10:34:43AM +0200, Jan Beulich wrote: > On 06.05.2022 17:35, Roger Pau Monné wrote: > > On Fri, May 06, 2022 at 03:31:12PM +0200, Roger Pau Monné wrote: > >> On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: > >>> On 05.05.2022 16:21, Roger Pau Monne wrote: > >>>> --- a/xen/include/xen/compiler.h > >>>> +++ b/xen/include/xen/compiler.h > >>>> @@ -125,10 +125,11 @@ > >>>> #define __must_be_array(a) \ > >>>> BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0]))) > >>>> > >>>> -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE > >>>> -/* Results in more efficient PIC code (no indirections through GOT or PLT). */ > >>>> -#pragma GCC visibility push(hidden) > >>>> -#endif > >>>> +/* > >>>> + * Results in more efficient PIC code (no indirections through GOT or PLT) > >>>> + * and is also required by some of the assembly constructs. > >>>> + */ > >>>> +#pragma GCC visibility push(protected) > >>>> > >>>> /* Make the optimizer believe the variable can be manipulated arbitrarily. */ > >>>> #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) > >>> > >>> This has failed my pre-push build test, with massive amounts of errors > >>> about asm() constraints in the alternative call infrastructure. This > >>> was with gcc 11.3.0. > >> > >> Hm, great. I guess I will have to use protected with clang and hidden > >> with gcc then, for lack of a better solution. > >> > >> I'm slightly confused as to why my godbolt example: > >> > >> https://godbolt.org/z/chTnMWxeP > >> > >> Seems to work with gcc 11 then. I will have to investigate a bit I > >> think. > > > > So it seems the problem is explicitly with constructs like: > > > > void (*foo)(void); > > > > void test(void) > > { > > asm volatile (".long [addr]" :: [addr] "i" (&(foo))); > > } > > > > See: > > > > https://godbolt.org/z/TYqeGdWsn > > > > AFAICT gcc will consider the function pointer foo to go through the > > GOT/PLT redirection table, while clang will not. I think gcc behavior > > is correct because in theory foo could be set from a different module? > > protect only guarantees that references to local functions cannot be > > overwritten, but not external ones. > > Right, since there's no way to tell the compiler that the symbol will > be resolved in the same "module". > > > I don't really see a good way to fix this, rather that setting > > different visibilities based on the compiler. clang would use > > protected and gcc would use hidden. > > If gcc's behavior is indeed correct, then moving to protected with > clang would set us up for going through GOT/PLT there - either right > away (if the implement this like gcc), or once they correct their > behavior. I don't think we want that. Therefore I think we want to > alter visibility between compilation and linking (i.e. presumably > right in prelink.o), going from compile-time hidden to link-time > protected. That would likely be closer to what your original patch > did (sadly there's no "convert to option > to objcopy, and making it have one wouldn't really help us here; > it's also not clear to me whether llvm comes with its own objcopy, > or whether they re-use GNU's). So I've raised the difference in protected behavior between gcc and clang: https://discourse.llvm.org/t/gcc-vs-clang-differences-in-protected-visibility-implementation It's no clear to me whether clang would switch it's implementation, but it also seems fragile to rely on global protected function pointers not going through the GOT. Do you have any recommendation as to how to change symbol visibility? I've been looking at objcopy, but I don't seem to find a way to do it. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 16 08:42:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 08:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329688.552929 (Exim 4.92) (envelope-from ) id 1nqWIc-0007UX-Bs; Mon, 16 May 2022 08:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329688.552929; Mon, 16 May 2022 08:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWIc-0007UQ-8X; Mon, 16 May 2022 08:41:54 +0000 Received: by outflank-mailman (input) for mailman id 329688; Mon, 16 May 2022 08:41:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWIa-0007UG-UH; Mon, 16 May 2022 08:41:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWIa-0005sV-LY; Mon, 16 May 2022 08:41:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWIa-0004G9-AA; Mon, 16 May 2022 08:41:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqWIa-00037X-6K; Mon, 16 May 2022 08:41:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CUZwL99tVN1APjD+Tv9NczjXSAiIPD3OuiBAmsPy954=; b=6M5N5pihxnp7mHgHwotqhlEkR+ /kWrrtWgDCCUr0KvYx9xLBXXypZ0WFt8SdmTVsCbIIG07MXs72ezg9n1UVTgD0ijpCgfc3ZHZmwgi jQ+LYYobJnR3X1/1oFQOnNUmwe9EpbvhU9/TIi0pNSwr0YF7Qh3e31pXg3np9LaiTimI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170465: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=207abdb38ee987e99385263e3e56b6c500d74cbc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Mon, 16 May 2022 08:41:52 +0000 flight 170465 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170465/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail in 170404 pass in 170465 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 170434 pass in 170404 test-armhf-armhf-libvirt 8 xen-boot fail in 170434 pass in 170465 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 170434 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 170434 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 170434 like 170404 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 170434 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 170434 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170404 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170434 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170434 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170434 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170434 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170434 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170434 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170434 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170434 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170434 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170434 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 207abdb38ee987e99385263e3e56b6c500d74cbc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170465 2022-05-16 01:53:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 16 08:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 08:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329698.552940 (Exim 4.92) (envelope-from ) id 1nqWM1-000892-SP; Mon, 16 May 2022 08:45:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329698.552940; Mon, 16 May 2022 08:45:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWM1-00088v-PA; Mon, 16 May 2022 08:45:25 +0000 Received: by outflank-mailman (input) for mailman id 329698; Mon, 16 May 2022 08:45:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWM0-00088p-RY for xen-devel@lists.xenproject.org; Mon, 16 May 2022 08:45:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWM0-0005wA-K5; Mon, 16 May 2022 08:45:24 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqWM0-0000XC-9y; Mon, 16 May 2022 08:45:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=1CV16hGeZg1OrGXXR/t9tHl3v8YD0IUdu/nnlIhlGkA=; b=mjzuBP t/Bez6tTqCMquEAub9WVx3/Kg6RIDRLzGjIcApiKWnOfaSHO9C18ff+MYQo9JN+NBzsCSQpiTS+2G IGnlNiINWdHFPJbQWrCOX1G7uswM2BR/VlRA7aip8Gi5QKbpdYsWoQcQrxYJH28mt1L5lY72gXQn3 ZMIrHDes+qo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Date: Mon, 16 May 2022 09:45:17 +0100 Message-Id: <20220516084517.76071-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap alloc/free" extended the checks in the buddy allocator to catch any use of the helpers from context with interrupts disabled. Unfortunately, the rule is not followed in the LPI code when allocating the pending table: (XEN) Xen call trace: (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50 (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 (XEN) [<0000010722aa4200>] 0000010722aa4200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 2: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** For now the patch extending the checks has been reverted, but it would be good to re-introduce it (allocation with interrupt is not desirable). The logic is reworked to allocate the pending table when preparing the CPU. Signed-off-by: Julien Grall --- xen/arch/arm/gic-v3-lpi.c | 81 ++++++++++++++++++++++++++++----------- 1 file changed, 59 insertions(+), 22 deletions(-) diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c index e1594dd20e4c..77d9d05c35a6 100644 --- a/xen/arch/arm/gic-v3-lpi.c +++ b/xen/arch/arm/gic-v3-lpi.c @@ -18,6 +18,7 @@ * along with this program; If not, see . */ +#include #include #include #include @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi, int domain_id, write_u64_atomic(&hlpip->data, hlpi.data); } -static int gicv3_lpi_allocate_pendtable(uint64_t *reg) +static int gicv3_lpi_allocate_pendtable(unsigned int cpu) { - uint64_t val; void *pendtable; - if ( this_cpu(lpi_redist).pending_table ) + if ( per_cpu(lpi_redist, cpu).pending_table ) return -EBUSY; - val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; - val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; - val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT; - /* * The pending table holds one bit per LPI and even covers bits for * interrupt IDs below 8192, so we allocate the full range. @@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *reg) clean_and_invalidate_dcache_va_range(pendtable, lpi_data.max_host_lpi_ids / 8); - this_cpu(lpi_redist).pending_table = pendtable; + per_cpu(lpi_redist, cpu).pending_table = pendtable; - val |= GICR_PENDBASER_PTZ; + return 0; +} + +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) +{ + const void *pendtable = this_cpu(lpi_redist).pending_table; + uint64_t val; + + if ( !pendtable ) + return -ENOMEM; + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); + + val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; + val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT; + val |= GICR_PENDBASER_PTZ; val |= virt_to_maddr(pendtable); - *reg = val; + writeq_relaxed(val, rdist_base + GICR_PENDBASER); + val = readq_relaxed(rdist_base + GICR_PENDBASER); + + /* If the hardware reports non-shareable, drop cacheability as well. */ + if ( !(val & GICR_PENDBASER_SHAREABILITY_MASK) ) + { + val &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; + val |= GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + + writeq_relaxed(val, rdist_base + GICR_PENDBASER); + } return 0; } @@ -340,7 +361,6 @@ static int gicv3_lpi_set_proptable(void __iomem * rdist_base) int gicv3_lpi_init_rdist(void __iomem * rdist_base) { uint32_t reg; - uint64_t table_reg; int ret; /* We don't support LPIs without an ITS. */ @@ -352,24 +372,33 @@ int gicv3_lpi_init_rdist(void __iomem * rdist_base) if ( reg & GICR_CTLR_ENABLE_LPIS ) return -EBUSY; - ret = gicv3_lpi_allocate_pendtable(&table_reg); + ret = gicv3_lpi_set_pendtable(rdist_base); if ( ret ) return ret; - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); - table_reg = readq_relaxed(rdist_base + GICR_PENDBASER); - /* If the hardware reports non-shareable, drop cacheability as well. */ - if ( !(table_reg & GICR_PENDBASER_SHAREABILITY_MASK) ) - { - table_reg &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; - table_reg |= GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + return gicv3_lpi_set_proptable(rdist_base); +} + +static int cpu_callback(struct notifier_block *nfb, unsigned long action, + void *hcpu) +{ + unsigned long cpu = (unsigned long)hcpu; + int rc = 0; - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); + switch ( action ) + { + case CPU_UP_PREPARE: + rc = gicv3_lpi_allocate_pendtable(cpu); + break; } - return gicv3_lpi_set_proptable(rdist_base); + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); } +static struct notifier_block cpu_nfb = { + .notifier_call = cpu_callback, +}; + static unsigned int max_lpi_bits = 20; integer_param("max_lpi_bits", max_lpi_bits); @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits); int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) { unsigned int nr_lpi_ptrs; + int rc; /* We rely on the data structure being atomically accessible. */ BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LPIS); - return 0; + /* Register the CPU notifier and allocate memory for the boot CPU */ + register_cpu_notifier(&cpu_nfb); + rc = gicv3_lpi_allocate_pendtable(smp_processor_id()); + if ( rc ) + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", + smp_processor_id()); + + return rc; } static int find_unused_host_lpi(uint32_t start, uint32_t *index) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Mon May 16 09:24:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 09:24:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329708.552951 (Exim 4.92) (envelope-from ) id 1nqWxg-0004Gz-1s; Mon, 16 May 2022 09:24:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329708.552951; Mon, 16 May 2022 09:24:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWxf-0004Gs-Uy; Mon, 16 May 2022 09:24:19 +0000 Received: by outflank-mailman (input) for mailman id 329708; Mon, 16 May 2022 09:24:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqWxe-0004Gm-5H for xen-devel@lists.xenproject.org; Mon, 16 May 2022 09:24:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0602.outbound.protection.outlook.com [2a01:111:f400:fe0e::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3eabf91-d4f9-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 11:24:15 +0200 (CEST) Received: from DU2PR04CA0318.eurprd04.prod.outlook.com (2603:10a6:10:2b5::23) by DB9PR08MB6908.eurprd08.prod.outlook.com (2603:10a6:10:2a0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 09:24:13 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::ae) by DU2PR04CA0318.outlook.office365.com (2603:10a6:10:2b5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Mon, 16 May 2022 09:24:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Mon, 16 May 2022 09:24:12 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Mon, 16 May 2022 09:24:12 +0000 Received: from a0fbfcca318b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 706B2764-BA99-4C9A-90B9-E084859705E3.1; Mon, 16 May 2022 09:24:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a0fbfcca318b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 16 May 2022 09:24:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB3265.eurprd08.prod.outlook.com (2603:10a6:208:56::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 09:24:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5250.018; Mon, 16 May 2022 09:24:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3eabf91-d4f9-11ec-b8b8-f95467ff1ed0 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iQ3rRUPezfVlEiNcnr3THAW9fmgpX+srOmwaN4SY/ZUc11yVGd0BxVo3s0gCxRtQaHLgsloY0xYCEgxfMBOYfKo1tFXN3Tae2Y01AM/yWTrPEefCdktdqPehNcIpGsf70pLjuaI46ZsTpBnid8yzTRbyocgLDpCgMxJPB8/AHpdfagfldYMU3Sz7EeoNPi6j5oIdLXoIwOklSNA1F35LuxEymzdkMNh6tvcHuBNg2SESNZ69cWMpozQY12cW4KhDy4nHfNbNfLZ+qClshGsHhqNkyizezbF+TqeJRoKwhjVAYGCFkta1sHVld78s5thmme6A20op6bWKVSP1vi1q+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sVbPCDFxyAP+r+z3b6GliUc8MmqU/UawYx8E3bV3zJ0=; b=X6pqZW8Vpeunmcpts1gCsRmlPDeCzkYOQX4CjJ8ELOpipCti9j78Lh2o5Q9MSaUfXSNe20JwI7oC5v0N/pgRP9ETQzLc7R09a/+QSQM/KYUpYWuPiq8yt92CWtZlkGsz76J4ellDjHT1Ias7IlVOiCLvnixfg30W07llnx5VHop5lf7hH5ECprv2ucnGRrTxH4l6zPF1wFbu+f0k3I+WHdGrrhKvHw1ixVNfypjT1XlyifsQje0vxS8R4PTOexjs+JkQNzLvIFd2xZHS/ft826oLpXTpYIwB3Bemf8Jg4Tu6Wvvv3+zHD6JMhKdzSw6oMZWkh44fsStiu8p2hrPI1w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sVbPCDFxyAP+r+z3b6GliUc8MmqU/UawYx8E3bV3zJ0=; b=rlMTzuCXOOxvlzxMxp3xgmgnM5V4fSmqlJvwwdB2wF0gt0TwAP7ZA424ljFqIC7KNYDgNvDIuX0txggsL2Wl7rBJ+9yuVPqOjCkc8ZTrfVNFqcEwJezaVa9u137R5/kPQX9Vva/4wGr9Gk7X+WyBBufTOvSwIsnxJxYQtvw/tUQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 22f16e89858802dd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNGMkSRgjljT0lFFqToGVGKaRiMcyLbCKkPhP1lwGV3eIvtnmp8ZBlL90er8eK7CTF6Znherwzl1XuXjbu8ohF2ysAY2X9PO1eht85R3Jc73ewzNuvOgCAoMJRCh+q4KF8AXqke1LHduhtEy0AzXPeN9AskuPn0JoaExe75tpv3PVjYcKFaKvmPzkKcX/Yz253Rz511p0VXvfmdGoU47y3WaVSBpKcpfvPjwptvOJuwVfT6wrNt4Cf+VG7LSBESjkDBO6rvS+eT3klY3TBt+C7AU4+4Q1+g/+tyD8h34Zom4LZwmufRi2XhHKo+P96Bvbh3WnepkgaNp2Mj52YeZXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sVbPCDFxyAP+r+z3b6GliUc8MmqU/UawYx8E3bV3zJ0=; b=Dyhf2TLGd6tziysi0vG86QNpyEUGtDTXZLn4sa846KEqd3ccwOgtd9AGHOUU0kShoS22ts2rHhQzByvNy744mYXHJflOMHXKZGhm1PNMPS97ld+2y1U0HjqKBpyWAKlopsb4kSXxTiU0vLkDYgdGQgUTApca393C1Grh5iC9Nr9Q+hRnOYpXx3P85rdxLH1SJFl37+KPE7FJAafgRMcRU/G6lXyhL21Cjv1M0YNi+sx5+yBcdX/oTTKWAuPLfhtas/kEAIR79dXhLtKO3VeLVTiivNIq+QDEM6Gmg13vBfBB9q/950kFXd03Eh2N9kqIhd+Vbx4t7O+3PtXXCAFQ5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sVbPCDFxyAP+r+z3b6GliUc8MmqU/UawYx8E3bV3zJ0=; b=rlMTzuCXOOxvlzxMxp3xgmgnM5V4fSmqlJvwwdB2wF0gt0TwAP7ZA424ljFqIC7KNYDgNvDIuX0txggsL2Wl7rBJ+9yuVPqOjCkc8ZTrfVNFqcEwJezaVa9u137R5/kPQX9Vva/4wGr9Gk7X+WyBBufTOvSwIsnxJxYQtvw/tUQ= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Topic: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Index: AQHYaQFPaa+cmN6NyUGhGvdTzOfzhq0hO1kA Date: Mon, 16 May 2022 09:24:02 +0000 Message-ID: <2E233152-FF46-42CF-B2CD-62E0BBE793C3@arm.com> References: <20220516084517.76071-1-julien@xen.org> In-Reply-To: <20220516084517.76071-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 73a406f6-9958-4a36-f4d8-08da371dd6e1 x-ms-traffictypediagnostic: AM0PR08MB3265:EE_|DBAEUR03FT045:EE_|DB9PR08MB6908:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: quk/fo7ndgy3WgPKmy1mq0FjU+DoL/uO24L6bLsZ9SKaMFZW4kpYAtXGmTTJdKzeJJJRAUIJoubGd8Ppol1jO+oFknhzvyvRQ9AAsJK3dEf6qX0gEsnCtEndeboazCW6uNTH6OdAAooGcKAXrfZBWZAh0i4EbW5gOmcaO9fUVgh9gYw84aLO4IV57G+vuNMD0NRZFZ6D6liKdpRJgkazW0Y268mx4vGm8zPNUYGztUgMtD9U1yPEygCN/jR2dmpbXRosPAM71oQoUi3iKPjD0SWf5OG91Q+A34h0wtX2u7iIyNfa/Qo2OVg4cY3EV68ZsLmOxuoYk5Qw8iBnf4mxwc8oiNGj1Dw+hNo1GkcAkYSGtmo2xu9uL23l4Mkim/ROxmn4fsFZ3t5BDTl234jiWnnlsRsnqWDkehu6GFehnuiBDuPRFbA/MW4EFF+9Tuja0+K6JbvTGyxRRR3CA2L7IANOs1GEqxiiAjKlCyFhsv7cqdahf/i0N+P+XHD4d1l7R0ZBm/OSckWYPDYoO9tN32L+bDcRQTvA9bt2G+uw463tTNnEkGNKSmx7v1lKmQgVN69idkHfivQmTORLhg/KCD2HIBsCAdlRsjP4iHUPn36TM3RJadKjRWdIGz772rfqkISGbMcznRNnM+N4zCEC/HmPaNPaekVPye+lty5egOMQybjiyUp7uYEsCBDMUQ6wVXeT2mit9DweX6sTQ64ThP7gNp6XgzZvpxC2F/vu7Ic10tbMUrVBI2KFGzrku0DP86tDhgMX73rs3tu8P1tFgoCbOv1RWU0S/1KDvPH/B1bPa0/7Q1Pp6yjEjDjW55Vc X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(66476007)(122000001)(33656002)(4326008)(38100700002)(38070700005)(64756008)(2906002)(66446008)(86362001)(66946007)(76116006)(5660300002)(8936002)(508600001)(71200400001)(6486002)(91956017)(53546011)(83380400001)(316002)(186003)(36756003)(26005)(6512007)(6506007)(54906003)(2616005)(66556008)(6916009)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <90D17E66D5CB8F4584199E0DDD861D82@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3265 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6b9ed01a-f71b-4bb6-6e0c-08da371dd118 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0yAB7UWgodgLSiGJk2kipB4T6uBICombjP7FWXNqcE1+hlwGi819+kR/J8T+I0QLXQngsjR2ZdYg8XPgTIiJJDWcL3+6g3SeEu6Hrv4Yc9y/P18wqfmAznaUTQfyLyI2uRAGN1/4Nuv2Lj861R/ZGuX/evb8zWYMZv9xtoGVOmNc3s7xtbUA/sUoPoy3LOaMi2xUsRCga3JZtXYCDpz2RigylMiORaDeg2amYJwSSKICDU10NMNi1yViUijTnmFs4fUMzidC7YcGbW+hsx+uKmvQRfB4AtHLQC9BnkKYFnUQ32rCmLTRyXGnXsl3MbAcF3KsT4fl5fMrlzk6qMC04hsrE8turAqrVM+Eo+ufJglb1u3lSstnUt7ApMZBWtZrVYAxn4GTiH5jGE+uMqD1npz79w2q5Il9EzwC8OoorxQXVa8DhmBqZjJBngCQTC8/j4zbDODqSaeP3JXS91oDZMY7dwFMKyUHLZ4eRgoDriFagMWCkETMzGNlrGk+3noMw5RPor29zB3E7VLZmiKtoLma0LMyJ4qNLUDA7/GyyG29ExKUYUltFOYgFqUXgC938pFGYlUCIRLCoWpLXccDWK3bl4+HDE5Q04Qpud2meCww1R4inRRKKVkcstM5J+N32puO8fmOQj2MInwuzm9gyNoARb8sHBfs2kC0us78Do++pQQSaiu8O1Tn73EYWKGTZhGQ1pEXL0r6rFlCbxY2IOTftz1RvZ5DlCnwiNzwPXXdcMKSlzL7EHsSGGBx6eHT X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(6486002)(316002)(70586007)(2906002)(8676002)(8936002)(53546011)(54906003)(86362001)(33656002)(36756003)(5660300002)(26005)(2616005)(107886003)(6512007)(82310400005)(6506007)(356005)(81166007)(83380400001)(336012)(40460700003)(47076005)(186003)(70206006)(6862004)(4326008)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 09:24:12.5058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73a406f6-9958-4a36-f4d8-08da371dd6e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6908 Hi Julien, > On 16 May 2022, at 09:45, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap > alloc/free" extended the checks in the buddy allocator to catch any > use of the helpers from context with interrupts disabled. >=20 > Unfortunately, the rule is not followed in the LPI code when allocating > the pending table: >=20 > (XEN) Xen call trace: > (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) > (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) > (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 > (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 > (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 > (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 > (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+= 0x20/0x50 > (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 > (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 > (XEN) [<0000010722aa4200>] 0000010722aa4200 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 2: > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus(= ) <=3D 1)' failed at common/page_alloc.c:2212 > (XEN) **************************************** >=20 > For now the patch extending the checks has been reverted, but it would > be good to re-introduce it (allocation with interrupt is not desirable). >=20 > The logic is reworked to allocate the pending table when preparing the > CPU. >=20 > Signed-off-by: Julien Grall > --- > xen/arch/arm/gic-v3-lpi.c | 81 ++++++++++++++++++++++++++++----------- > 1 file changed, 59 insertions(+), 22 deletions(-) >=20 > diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c > index e1594dd20e4c..77d9d05c35a6 100644 > --- a/xen/arch/arm/gic-v3-lpi.c > +++ b/xen/arch/arm/gic-v3-lpi.c > @@ -18,6 +18,7 @@ > * along with this program; If not, see . > */ >=20 > +#include > #include > #include > #include > @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi,= int domain_id, > write_u64_atomic(&hlpip->data, hlpi.data); > } >=20 > -static int gicv3_lpi_allocate_pendtable(uint64_t *reg) > +static int gicv3_lpi_allocate_pendtable(unsigned int cpu) > { > - uint64_t val; > void *pendtable; >=20 > - if ( this_cpu(lpi_redist).pending_table ) > + if ( per_cpu(lpi_redist, cpu).pending_table ) > return -EBUSY; >=20 > - val =3D GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY= _SHIFT; > - val |=3D GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEAB= ILITY_SHIFT; > - val |=3D GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHI= FT; > - > /* > * The pending table holds one bit per LPI and even covers bits for > * interrupt IDs below 8192, so we allocate the full range. > @@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *r= eg) > clean_and_invalidate_dcache_va_range(pendtable, > lpi_data.max_host_lpi_ids / 8); >=20 > - this_cpu(lpi_redist).pending_table =3D pendtable; > + per_cpu(lpi_redist, cpu).pending_table =3D pendtable; >=20 > - val |=3D GICR_PENDBASER_PTZ; > + return 0; > +} > + > +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) > +{ > + const void *pendtable =3D this_cpu(lpi_redist).pending_table; > + uint64_t val; > + Should we add an assert here to check if we are to early in boot ? That would also implicitly explain that allocation is done during CPU_PREPA= RE so this should not be called before. > + if ( !pendtable ) > + return -ENOMEM; >=20 > + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); This ASSERT is already done in gicv3_lpi_allocate_pendtable but it makes se= nse to have it closer to the place where we actually set the register. Otherwise this assert can never be triggered. Can you remove the one in the allocation function and also copy the comment= that was on top of it here ? > + > + val =3D GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY= _SHIFT; > + val |=3D GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEAB= ILITY_SHIFT; > + val |=3D GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHI= FT; > + val |=3D GICR_PENDBASER_PTZ; > val |=3D virt_to_maddr(pendtable); >=20 > - *reg =3D val; > + writeq_relaxed(val, rdist_base + GICR_PENDBASER); > + val =3D readq_relaxed(rdist_base + GICR_PENDBASER); > + > + /* If the hardware reports non-shareable, drop cacheability as well.= */ > + if ( !(val & GICR_PENDBASER_SHAREABILITY_MASK) ) > + { > + val &=3D ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; > + val |=3D GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY= _SHIFT; > + > + writeq_relaxed(val, rdist_base + GICR_PENDBASER); > + } >=20 > return 0; > } > @@ -340,7 +361,6 @@ static int gicv3_lpi_set_proptable(void __iomem * rdi= st_base) > int gicv3_lpi_init_rdist(void __iomem * rdist_base) > { > uint32_t reg; > - uint64_t table_reg; > int ret; >=20 > /* We don't support LPIs without an ITS. */ > @@ -352,24 +372,33 @@ int gicv3_lpi_init_rdist(void __iomem * rdist_base) > if ( reg & GICR_CTLR_ENABLE_LPIS ) > return -EBUSY; >=20 > - ret =3D gicv3_lpi_allocate_pendtable(&table_reg); > + ret =3D gicv3_lpi_set_pendtable(rdist_base); > if ( ret ) > return ret; > - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); > - table_reg =3D readq_relaxed(rdist_base + GICR_PENDBASER); >=20 > - /* If the hardware reports non-shareable, drop cacheability as well.= */ > - if ( !(table_reg & GICR_PENDBASER_SHAREABILITY_MASK) ) > - { > - table_reg &=3D ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; > - table_reg |=3D GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEA= BILITY_SHIFT; > + return gicv3_lpi_set_proptable(rdist_base); > +} > + > +static int cpu_callback(struct notifier_block *nfb, unsigned long action= , > + void *hcpu) > +{ > + unsigned long cpu =3D (unsigned long)hcpu; > + int rc =3D 0; >=20 > - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); > + switch ( action ) > + { > + case CPU_UP_PREPARE: > + rc =3D gicv3_lpi_allocate_pendtable(cpu); > + break; > } >=20 > - return gicv3_lpi_set_proptable(rdist_base); > + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); > } >=20 > +static struct notifier_block cpu_nfb =3D { > + .notifier_call =3D cpu_callback, > +}; > + > static unsigned int max_lpi_bits =3D 20; > integer_param("max_lpi_bits", max_lpi_bits); >=20 > @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits); > int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) > { > unsigned int nr_lpi_ptrs; > + int rc; >=20 > /* We rely on the data structure being atomically accessible. */ > BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); > @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_b= its) >=20 > printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LP= IS); >=20 > - return 0; > + /* Register the CPU notifier and allocate memory for the boot CPU */ > + register_cpu_notifier(&cpu_nfb); > + rc =3D gicv3_lpi_allocate_pendtable(smp_processor_id()); > + if ( rc ) > + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n"= , > + smp_processor_id()); On secondary cores nothing equivalent will be printed and in the cal path t= here will be nothing printed at all which could make debugging complex. Can you move this print into gicv3_lpi_allocate_pendtable ? > + > + return rc; > } >=20 > static int find_unused_host_lpi(uint32_t start, uint32_t *index) > --=20 > 2.32.0 >=20 Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon May 16 09:50:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 09:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329716.552963 (Exim 4.92) (envelope-from ) id 1nqXNA-0007cG-6b; Mon, 16 May 2022 09:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329716.552963; Mon, 16 May 2022 09:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXNA-0007c9-3v; Mon, 16 May 2022 09:50:40 +0000 Received: by outflank-mailman (input) for mailman id 329716; Mon, 16 May 2022 09:50:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXN8-0007c3-SW for xen-devel@lists.xenproject.org; Mon, 16 May 2022 09:50:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXN8-00075F-KO; Mon, 16 May 2022 09:50:38 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqXN8-0004fD-Dk; Mon, 16 May 2022 09:50:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JGiBT55wN7BpDZsXrzl+DX9CIM0lBBSWzHedA+YIRKk=; b=CwlhQ9xjiqoq5Cv2v15eGxZXYW 8zU82RGrfDweRRqIgt3C6GCvg5/MvwykLAcQKuwowdNP0zokYpyb6sLngTbRlJGmacI5KBhWH74eO dXTpMfRkurIQonferVbgvLOuWfsm1IFWYtrHrKoUPs95DSNWGpHaUCn26j0vFQfstSwg=; Message-ID: Date: Mon, 16 May 2022 10:50:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20220516084517.76071-1-julien@xen.org> <2E233152-FF46-42CF-B2CD-62E0BBE793C3@arm.com> From: Julien Grall In-Reply-To: <2E233152-FF46-42CF-B2CD-62E0BBE793C3@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/05/2022 10:24, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 16 May 2022, at 09:45, Julien Grall wrote: >> >> From: Julien Grall >> >> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap >> alloc/free" extended the checks in the buddy allocator to catch any >> use of the helpers from context with interrupts disabled. >> >> Unfortunately, the rule is not followed in the LPI code when allocating >> the pending table: >> >> (XEN) Xen call trace: >> (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) >> (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) >> (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 >> (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 >> (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 >> (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 >> (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50 >> (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 >> (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 >> (XEN) [<0000010722aa4200>] 0000010722aa4200 >> (XEN) >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 2: >> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 >> (XEN) **************************************** >> >> For now the patch extending the checks has been reverted, but it would >> be good to re-introduce it (allocation with interrupt is not desirable). >> >> The logic is reworked to allocate the pending table when preparing the >> CPU. >> >> Signed-off-by: Julien Grall >> --- >> xen/arch/arm/gic-v3-lpi.c | 81 ++++++++++++++++++++++++++++----------- >> 1 file changed, 59 insertions(+), 22 deletions(-) >> >> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c >> index e1594dd20e4c..77d9d05c35a6 100644 >> --- a/xen/arch/arm/gic-v3-lpi.c >> +++ b/xen/arch/arm/gic-v3-lpi.c >> @@ -18,6 +18,7 @@ >> * along with this program; If not, see . >> */ >> >> +#include >> #include >> #include >> #include >> @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi, int domain_id, >> write_u64_atomic(&hlpip->data, hlpi.data); >> } >> >> -static int gicv3_lpi_allocate_pendtable(uint64_t *reg) >> +static int gicv3_lpi_allocate_pendtable(unsigned int cpu) >> { >> - uint64_t val; >> void *pendtable; >> >> - if ( this_cpu(lpi_redist).pending_table ) >> + if ( per_cpu(lpi_redist, cpu).pending_table ) >> return -EBUSY; >> >> - val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; >> - val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; >> - val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT; >> - >> /* >> * The pending table holds one bit per LPI and even covers bits for >> * interrupt IDs below 8192, so we allocate the full range. >> @@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *reg) >> clean_and_invalidate_dcache_va_range(pendtable, >> lpi_data.max_host_lpi_ids / 8); >> >> - this_cpu(lpi_redist).pending_table = pendtable; >> + per_cpu(lpi_redist, cpu).pending_table = pendtable; >> >> - val |= GICR_PENDBASER_PTZ; >> + return 0; >> +} >> + >> +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) >> +{ >> + const void *pendtable = this_cpu(lpi_redist).pending_table; >> + uint64_t val; >> + > > Should we add an assert here to check if we are to early in boot ? > That would also implicitly explain that allocation is done during CPU_PREPARE so this should not be called before. Do you mean something like: if ( !pendtable ) { ASSERT_UNREACHABLE(); return -ENOMEM; } > >> + if ( !pendtable ) >> + return -ENOMEM; >> >> + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); > > This ASSERT is already done in gicv3_lpi_allocate_pendtable but it makes sense to have it closer to the place where we actually set the register. > Otherwise this assert can never be triggered. So the ASSERT() would end up to be triggered if the code in gicv3_allocate_pendtable() is incorrect. > Can you remove the one in the allocation function and also copy the comment that was on top of it here ? I would like to the keep as it is. The check in gicv3_allocate_pendtable() happens also in debug build and would allow to catch any problem before the CPU is even running. In general, I would like to move to most of the checks when preparing the CPU so there are less chance for failures when the CPU is booting. The ASSERT is here only to catch any misuse of the function. >> @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits); >> int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) >> { >> unsigned int nr_lpi_ptrs; >> + int rc; >> >> /* We rely on the data structure being atomically accessible. */ >> BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); >> @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) >> >> printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LPIS); >> >> - return 0; >> + /* Register the CPU notifier and allocate memory for the boot CPU */ >> + register_cpu_notifier(&cpu_nfb); >> + rc = gicv3_lpi_allocate_pendtable(smp_processor_id()); >> + if ( rc ) >> + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", >> + smp_processor_id()); > > On secondary cores nothing equivalent will be printed and in the cal path there > will be nothing printed at all which could make debugging complex. > Can you move this print into gicv3_lpi_allocate_pendtable ? Good point. I will do that in the next version. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 09:50:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 09:50:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329717.552974 (Exim 4.92) (envelope-from ) id 1nqXNH-0007tw-F2; Mon, 16 May 2022 09:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329717.552974; Mon, 16 May 2022 09:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXNH-0007tp-Bt; Mon, 16 May 2022 09:50:47 +0000 Received: by outflank-mailman (input) for mailman id 329717; Mon, 16 May 2022 09:50:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXNG-0007sh-1q; Mon, 16 May 2022 09:50:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXNG-00075Q-16; Mon, 16 May 2022 09:50:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXNF-0007pi-JM; Mon, 16 May 2022 09:50:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqXNF-0005ZY-It; Mon, 16 May 2022 09:50:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wc7IsMuL4UvbfvbRbCOCMxCnYLHU04ZbQGqpsUbFdzE=; b=F7DHVkVEYVNeRMGbopOZsEGYxY MVlkwzjSsJJhLG6KOkLSYgNqpRCvDNhd6VVdXY7t0aq574xADA6tqB5DCjXOEzRaVLvCxdaw66L8D LEF8dkCf7A4bXm05f8UeiY8qLahK0O3OGI/rRZ2N56PRBob7aik/Zs7IOKMFdlTfKjuE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170473: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 09:50:45 +0000 flight 170473 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170473/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 76 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1039 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 58 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 10:08:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:08:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329735.552985 (Exim 4.92) (envelope-from ) id 1nqXdl-0001cJ-3h; Mon, 16 May 2022 10:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329735.552985; Mon, 16 May 2022 10:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXdl-0001cC-0K; Mon, 16 May 2022 10:07:49 +0000 Received: by outflank-mailman (input) for mailman id 329735; Mon, 16 May 2022 10:07:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXdk-0001c2-A0; Mon, 16 May 2022 10:07:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXdk-0007Rc-61; Mon, 16 May 2022 10:07:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXdj-0008IF-P0; Mon, 16 May 2022 10:07:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqXdj-0000Pw-OX; Mon, 16 May 2022 10:07:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pf77U0h/0MboaDE6OS2SGdoJmGjS6tEq4STTLsKRBqE=; b=h5270xOqBn9D3IYnA7HBJkxKR4 Ic86QkKpIX+rFrlbJ9L4vMu7cXaYdxvxuReJ02QmufcqfANFyrJa+24lDAiRxYCSyjfo8unzWU0xF 74m/YzhrNktgdytDr1MVADOHK7hc2mCaVtdfe3yZN8mstL99KUs5j7De3fBLXH2wFdE8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170470: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 16 May 2022 10:07:47 +0000 flight 170470 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 7b0e2e4a558da6ea7e450d5a1a30d1557abc5aae baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 675 days Failing since 151818 2020-07-11 04:18:52 Z 674 days 656 attempts Testing same since 170408 2022-05-14 04:18:58 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107373 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 10:19:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329745.552996 (Exim 4.92) (envelope-from ) id 1nqXpO-0003Er-6k; Mon, 16 May 2022 10:19:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329745.552996; Mon, 16 May 2022 10:19:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXpO-0003Ek-3S; Mon, 16 May 2022 10:19:50 +0000 Received: by outflank-mailman (input) for mailman id 329745; Mon, 16 May 2022 10:19:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXpM-0003Ee-LZ for xen-devel@lists.xenproject.org; Mon, 16 May 2022 10:19:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXpM-0007dE-AA; Mon, 16 May 2022 10:19:48 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqXpM-0006KH-3j; Mon, 16 May 2022 10:19:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=LW1Uy44cWeC43GMwBsY2AIcFSPQday21mLwPMx971P4=; b=14U9uwp0VPT4Xr/zyn7dy45KO3 MLg6ID47ewR21xzazCeiE0jOi8YJlE5kb2SHkAJiRgP6ImC1u1eeU0oT48dlqZjC2W0Vb9usfL4P4 eKalGpz/n0/3qmTPtbd22a7RSBWVzraKh3UD5okur8ST/rKCLjj+DcJUvjIPtbr8+/TI=; Message-ID: Date: Mon, 16 May 2022 11:19:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-3-michal.orzel@arm.com> From: Julien Grall In-Reply-To: <20220506094225.181815-3-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 06/05/2022 10:42, Michal Orzel wrote: > Modify macros to evaluate all the arguments and make sure the arguments > are evaluated only once. Introduce following intermediate macros: > gnttab_status_gfn_, gnttab_shared_gfn_ that do not take domain as a > parameter. These are to be used locally and allow us to avoid passing > NULL from gnttab_get_frame_gfn to the respective macros (without _ suffix). > Make use of a domain parameter from gnttab_shared_gfn and gnttab_status_gfn > by adding an ASSERT. > > Signed-off-by: Michal Orzel Most of the helpers below are going to disappear with Oleksandr latest work (see [1]). Looking at Oleksandr's patch, I think only gnttab_set_frame_gfn() would end up to use one of the macro parameters twice. So I would like to suggest to chat with Oleksandr if we can tweak his patch (can be done on commit) or we rebase this patch on top of his work. Cheers, [1] https://lore.kernel.org/xen-devel/1652294845-13980-1-git-send-email-olekstysh@gmail.com/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 10:21:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:21:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329753.553007 (Exim 4.92) (envelope-from ) id 1nqXrO-0004fN-J4; Mon, 16 May 2022 10:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329753.553007; Mon, 16 May 2022 10:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXrO-0004fG-G5; Mon, 16 May 2022 10:21:54 +0000 Received: by outflank-mailman (input) for mailman id 329753; Mon, 16 May 2022 10:21:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqXrM-0004fA-RV for xen-devel@lists.xenproject.org; Mon, 16 May 2022 10:21:52 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 003a0dab-d502-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 12:21:51 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 02AF51F930; Mon, 16 May 2022 10:21:51 +0000 (UTC) Received: from suse.cz (unknown [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 89FB92C141; Mon, 16 May 2022 10:21:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 003a0dab-d502-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652696511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SKwT5B95E5YN9xa81VvHUpO+QGR+zcfCsbhuV2Jgp4=; b=LWTnDo04g2ZIMR91v0c2MAsYmxaUOl80sz+tTo9fRyqmuLzfAZ1jmcmhBu1F/2SwEKbidr AAgP6W9p9YHXuK9IdMK0VKJ5T49DYuwEAzjkXZlkWl2knT/MPCmRsL91fAF4WZ26S0Lq+5 GaIq0ymGLcl5C1bryaGKOpn3k9Ph6bU= Date: Mon, 16 May 2022 12:21:48 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: "michael Kelley (LINUX)" , Baoquan He , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun 2022-05-15 19:47:39, Guilherme G. Piccoli wrote: > On 12/05/2022 11:03, Petr Mladek wrote: > > This talks only about kdump. The reality is much more complicated. > > The level affect the order of: > > > > + notifiers vs. kdump > > + notifiers vs. crash_dump > > + crash_dump vs. kdump > > First of all, I'd like to ask you please to clarify to me *exactly* what > are the differences between "crash_dump" and "kdump". I'm sorry if > that's a silly question, I need to be 100% sure I understand the > concepts the same way you do. Ah, it should have been: + notifiers vs. kmsg_dump + notifiers vs. crash_dump + crash_dump vs. kmsg_dump I am sorry for the confusion. Even "crash_dump" is slightly misleading because there is no function with this name. But it seems to be easier to understand than __crash_kexec(). > > There might theoretically many variants of the ordering of kdump, > > crash_dump, and the 4 notifier list. Some variants do not make > > much sense. You choose 5 variants and tried to select them by > > a level number. > > > > The question is if we really could easily describe the meaning this > > way. It is not only about a "level" of notifiers before kdump. It is > > also about the ordering of crash_dump vs. kdump. IMHO, "level" > > semantic does not fit there. > > > > Maybe more parameters might be easier to understand the effect. > > Anyway, we first need to agree on the chosen variants. > > I am going to discuss it more in the code, see below. > > > > > > [...] > > Here is the code using the above functions. It helps to discuss > > the design and logic. > > > > I have to say that the logic is very unclear. Almost all > > functions are called twice: > > > > The really used code path is defined by order_panic_notifiers_and_kdump() > > that encodes "level" into "bits". The bits are then flipped in > > panic_notifier_*_once() calls that either do something or not. > > kmsg_dump() is called according to the bit flip. > > > > Also I guess that it is good proof that "level" abstraction does > > not fit here. Normal levels would not need this kind of magic. > > Heheh OK, I appreciate your opinion, but I guess we'll need to agree in > disagree here - I'm much more fond to this kind of code than a bunch of > if/else blocks that almost give headaches. Encoding such "level" logic > in the if/else scheme is very convoluted, generates a very big code. And > the functions aren't so black magic - they map a level in bits, and the > functions _once() are called...once! Although we switch the position in > the code, so there are 2 calls, one of them is called and the other not. I see. Well, I would consider this as a warning that the approach is too complex. If the code, using if/then/else, would cause headaches then also understanding of the behavior would cause headaches for both users and programmers. > But that's totally fine to change - especially if we're moving away from > the "level" logic. I see below you propose a much simpler approach - if > we follow that, definitely we won't need the "black magic" approach heheh I do not say that my proposal is fully correct. But we really need this kind of simpler approach. > > OK, the question is how to make it better. > > One option "panic_prefer_crash_dump" should be enough. > > And the code might look like: > > > > void panic() > > { > > [...] > > dump_stack(); > > kgdb_panic(buf); > > > > < --- here starts the reworked code --- > > > > > /* crash dump is enough when enabled and preferred. */ > > if (panic_prefer_crash_dump) > > __crash_kexec(NULL); > > > > /* Stop other CPUs and focus on handling the panic state. */ > > if (has_kexec_crash_image) > > crash_smp_send_stop(); > > else > > smp_send_stop() > > > > Here we have a very important point. Why do we need 2 variants of SMP > CPU stopping functions? I disagree with that - my understanding of this > after some study in architectures is that the crash_() variant is > "stronger", should work in all cases and if not, we should fix that - > that'd be a bug. > > Such variant either maps to smp_send_stop() (in various architectures, > including XEN/x86) or overrides the basic function with more proper > handling for panic() case...I don't see why we still need such > distinction, if you / others have some insight about that, I'd like to > hear =) The two variants were introduced by the commit 0ee59413c967c35a6dd ("x86/panic: replace smp_send_stop() with kdump friendly version in panic path") It points to https://lkml.org/lkml/2015/6/24/44 that talks about still running watchdogs. It is possible that the problem could be fixed another way. It is even possible that it has already been fixed by the notifiers that disable the watchdogs. Anyway, any change of the smp_send_stop() behavior should be done in a separate patch. It will help with bisection of possible regression. Also it would require a good explanation in the commit message. I would personally do it in a separate patch(set). > > /* Notify hypervisor about the system panic. */ > > atomic_notifier_call_chain(&panic_hypervisor_list, 0, NULL); > > > > /* > > * No need to risk extra info when there is no kmsg dumper > > * registered. > > */ > > if (!has_kmsg_dumper()) > > __crash_kexec(NULL); > > > > /* Add extra info from different subsystems. */ > > atomic_notifier_call_chain(&panic_info_list, 0, NULL); > > > > kmsg_dump(KMSG_DUMP_PANIC); > > __crash_kexec(NULL); > > > > /* Flush console */ > > unblank_screen(); > > console_unblank(); > > debug_locks_off(); > > console_flush_on_panic(CONSOLE_FLUSH_PENDING); > > > > if (panic_timeout > 0) { > > delay() > > } > > > > /* > > * Prepare system for eventual reboot and allow custom > > * reboot handling. > > */ > > atomic_notifier_call_chain(&panic_reboot_list, 0, NULL); > > You had the order of panic_reboot_list VS. consoles flushing inverted. > It might make sense, although I didn't do that in V1... IMHO, it makes sense: 1. panic_reboot_list contains notifiers that do the reboot immediately, for example, xen_panic_event, alpha_panic_event. The consoles have to be flushed earlier. 2. console_flush_on_panic() ignores the result of console_trylock() and always calls console_unlock(). As a result the lock should be unlocked at the end. And any further printk() should be able to printk the messages to the console immediately. It means that any messages printed by the reboot notifiers should appear on the console as well. > Are you OK in having a helper for console flushing, as I did in V1? It > makes code of panic() a bit less polluted / more focused I feel. Yes, it makes sense. Well, it would better to do it in a separate patch. The patch patch reworking the logic should be as small as possible. It will simplify the review. > > if (panic_timeout != 0) { > > reboot(); > > } > > > > /* > > * Prepare system for the infinite waiting, for example, > > * setup blinking. > > */ > > atomic_notifier_call_chain(&panic_loop_list, 0, NULL); > > > > infinite_loop(); > > } > > > > > > __crash_kexec() is there 3 times but otherwise the code looks > > quite straight forward. > > > > Note 1: I renamed the two last notifier list. The name 'post-reboot' > > did sound strange from the logical POV ;-) > > > > Note 2: We have to avoid the possibility to call "reboot" list > > before kmsg_dump(). All callbacks providing info > > have to be in the info list. It a callback combines > > info and reboot functionality then it should be split. > > > > There must be another way to calm down problematic > > info callbacks. And it has to be solved when such > > a problem is reported. Is there any known issue, please? > > > > It is possible that I have missed something important. > > But I would really like to make the logic as simple as possible. > > OK, I agree with you! It's indeed simpler and if others agree, I can > happily change the logic to what you proposed. Although...currently the > "crash_kexec_post_notifiers" allows to call _all_ panic_reboot_list > callbacks _before kdump_. > > We need to mention this change in the commit messages, but I really > would like to hear the opinions of heavy users of notifiers (as > Michael/Hyper-V) and the kdump interested parties (like Baoquan / Dave > Young / Hayatama). If we all agree on such approach, will change that > for V2 =) Sure, we need to make sure that we call everything that is needed. And it should be documented. I believe that this is the right way because: + It was actually the motivation for this patchset. We split the notifiers into separate lists because we want to call only the really needed ones before kmsg_dump and crash_dump. + If anything is needed for crash_dump that it should be called even when crash_dump is called first. It should be either hardcoded into crash_dump() or we would need another notifier list that will be always called before crash_dump. Thanks a lot for working on this. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 10:36:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:36:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329762.553017 (Exim 4.92) (envelope-from ) id 1nqY5I-0006H6-0R; Mon, 16 May 2022 10:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329762.553017; Mon, 16 May 2022 10:36:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqY5H-0006Gz-Th; Mon, 16 May 2022 10:36:15 +0000 Received: by outflank-mailman (input) for mailman id 329762; Mon, 16 May 2022 10:36:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqY5F-0006Gt-Vr for xen-devel@lists.xenproject.org; Mon, 16 May 2022 10:36:14 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 007c667e-d504-11ec-aa76-f101dd46aeb6; Mon, 16 May 2022 12:36:12 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 06:36:09 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4615.namprd03.prod.outlook.com (2603:10b6:a03:12d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 10:36:07 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.018; Mon, 16 May 2022 10:36:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 007c667e-d504-11ec-aa76-f101dd46aeb6 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652697371; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=Hvyd0ozVM0yEezdsN/R+DWEWq1PoRLMAJ/WLQB11LfA=; b=OHqMxTea1mvzbac+bfhHt/HCqaOEutf7xfuov0fsOzzSbDIxShos2Q8a lw+JeSLwDlgrUqU8wzYpOnqpVqVhts3a6qCFQxn9ZMnsWHX1sFuopbxYh M8sv2mPIyE3oYixYzouNlByCbbu1hFYVTmrm8JY0Leiuz4eocUFLF+POs E=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 71785816 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:bYeDXaiEH3SJXXQ0xobObHP+X161FBEKZh0ujC45NGQN5FlHY01je htvWDrVOf+NZmP0f9p0Po2zoEIFsJXUyIcyQFE/qS8wEC8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrQ4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQsNIq3TivgmaElBSjkkArFk9If/fGfq5KR/z2WeG5ft69NHKRhueKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehW9q7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvK9fdnuja7IApZ9b7jAuT/W5uwGsxSwWaWv kft/nn6DURPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe9DW8ymIw6vQpgOGXG4NS2cZbMR87ZdsAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obv5jEpMVkcG wy3kRU= IronPort-HdrOrdr: A9a23:NUVRXq3XYUmZQFIMu4sTkAqjBVRyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZXFedU1jP94UBZ Cc7s1Iq36JfmkWVN2yAj0gU/LYr9PGuZr6aVpebiRXoTWmvHeN0vrXAhKY1hARX3dmxqojy3 HMl0jc6r+4u/+25xfA3yv47ohQmvHm1txfbfb8/PQ9G3HJsEKFdY5hU7qNsHQcp/yu0k8jlJ 32rxIpL61ImgHsV1DwhSGo9xjr0T4o5XOn40Sfm2HfrcvwQy9/I9ZdhKpCGyGppnYIjZVZ6u ZmzmiZv51YAVfrhyLm/eXFUBlsiw6dvWciq+gOlHZSOLFuIoO5lbZvs3+9La1wUh4TsOscYa hT5YDnlb1rmGqhHjzkVjIF+q3tYpwxdi32MXTq9PblkAS+p0oJsHfw9PZv4kvoy6hNNaWsn9 60VJiAtIs+O/P+PpgNcNvof6OMex3waCOJFl6uCnLaM4xCE07xivfMkcUIDaeRCdQ18Kc= X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="scan'208";a="71785816" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHb5D2FgwTrHXrPIbRAON1+6q29QF9PgGHkgUVfeyxibH/lIgpP5SmqP+4zB3I6JFiPdJ/wEq6Yqt1B98MiQ0zGY9jpBo1bhZc9YqMsvXHO3pKRp4kFvadnQP40mVU/RiaKCwCHF2XdmDaEjpJk2MIn7yYkG+MzD4orvvu20/YLTYmBPaVkYWPEMzj3MuqczIGjJ7lWlmkTpfD5l5nxEE5Wr3WIEaO++JcvGTDko3ZBs6lFFyTNszi9OKHm7FS1mO1aUyqC1iP0RC8X07myQTSuGRR3abAx6iALD7yRauZG/4mtzR9c8f5boN2AhefhKeurKPsbJguFmhujTy4GKoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6VRuSEWcJyBV3jT/k3E6n1bWGDSbjz/MtUh+1H03Jg=; b=SHqtGnm+h4GFyLTCFR9IF+TO+W1jObOhLtGXpgAuq93W4NscAaxS7Tmvbd/jmdDAhvm3zRNkD+o2k8QIrqRv4zSrCJN6PmjlV343gGFAGbmT8X8k80Q/zJaqrvZELAkKICpvd4arabdqPfVQCCAi5CpWnN9lQFQ39dJGtrvPuDvtowZDYVOdLB4nSD+in2/31vUg86TBx+hK8F3zChuhHtO9MlimVZUwdRQ1/utEQIjOkomdXk/CGQ9iOWNFAVYSi9W6n3cYAjkLuudipqqmpBlnxb3rFBDwojeDfDhXaqadGMh8iOJIXmxEH2kxB6dcvt8ftTzA/6zhRZwjvVr0mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j6VRuSEWcJyBV3jT/k3E6n1bWGDSbjz/MtUh+1H03Jg=; b=gPLFvN3FEuhG3sgI029uq8yEWv1buqUoD7iqw68VwSN20jw/mybqe4HeXYcbVPi1QIPIjC/aELU58BGy62uE9B6693sHOqXBLTnadixZMcgo+lMh6+Vix9XHtnewsbmF72qVfoyFyiQ9hC85QsU9lGUSG4YbMDkiM+XDtssZT7g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] x86/mwait-idle: add missing newline Date: Mon, 16 May 2022 12:36:01 +0200 Message-Id: <20220516103601.25671-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0085.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5ddcba2-f619-4abe-dffe-08da3727e2da X-MS-TrafficTypeDiagnostic: BYAPR03MB4615:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LkQOV+cig1/xsWA74vO9yb+aQN0TzSfYN3S5sSyU3bp5wojDeIfeUQ2uUZS7yVpFs03UgUUjYKmgxjbrSLlzhmD6j1AGo1a8t+qCzOSEi9dEbjJXTMNOWKlzWI5l2U+dMk4rVci4kWPHNAAuTN18sC2FeMKHCzdIdykZ6IkjhyEKyfWUPvg8RrhapevSmffCQyjAAVfuB+30kUafkxWNocyhBJRyQ3cO6GHXWKPwYZ7DvDPXoUIwzjwb9InyJDoaVg1pT7+QNadqVCn0LUBtIeZ7sIZyrJpGm10y1GdCwIhhB6wB9iQNLSUGH2+0X3y3ihYmW4tWwAEUUoVY/M/MPmiRXCsyAc8y4J2L8qwZy6c37X4Zavv/iFHG2VOnJ+HtDC9SYwxtHmDXP/SHxqan6lK9+IlKYzDMlMmVck+7Pxtb8oD4WPscTknez460xTnrPiYTfdsPB933PBKwiF8nYAdgOHfd5Zmw8q5CkFyuaHoO0bmc1QPH5Yn/aSJL607avvcDnhrgMVEwfwf2zKbQ4ysGMDG7BuM65Hu6BdroID1Ns2cVi4JJ5+jTCuH9eTXqZCg7tDWwnEjY7uXh43cTkVqjaPFQ0btnV0FzZXLxjOzGWXUqnVqJu67F86ngjqS+5vvKj2Cn0j6AcAvFQXekjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(82960400001)(36756003)(8936002)(6916009)(508600001)(186003)(1076003)(6486002)(316002)(38100700002)(54906003)(2616005)(4744005)(86362001)(2906002)(66946007)(66556008)(26005)(4326008)(66476007)(5660300002)(6512007)(6506007)(6666004)(83380400001)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0dZT0ZnMGFQRXZiQlIrcmIrTUczVmc0WDdlM3dmMFN5ZVVLdVVUNHRwOWti?= =?utf-8?B?MDJoaTE0UXVLMml6Z29EWlRWdEljUnNmMTFld0pjVUNNY05ydGRDQmxlY1B2?= =?utf-8?B?T3ZTampWcCtNekcvc2U1OEp6dThYOVhXeEt3UUJRQjZVRUlRSzIwcmJSYi9O?= =?utf-8?B?bUFHUktaa1NMZ3k2ZEhKSHNLeWJraWd4VW5oV2JidlpJK2JpU2x1dVFWeXg4?= =?utf-8?B?NnhZNkRXeVY1TXk2L05SeFdvSmZveW5pUHlXdzVkSWdVZHBlOVZoWmsrQUF4?= =?utf-8?B?OUduVUcwQVFqbEJEbkxkYUYvVmVrVFV3dmFhZEhMajlHOWVwdGt0cXAxVDhr?= =?utf-8?B?dThxNzgvM2FENWxHOWVaRHRMMEdIMFc0RTUxS1dneUlCRHZJU2N1V0N6SUtn?= =?utf-8?B?SXFEeDFvQnJYMnB3Y09jV1dRazVBVVBOV2RwN2JNR1o1YzBKSjlmZFR4L1NR?= =?utf-8?B?Zm5HbnNXYTVLZ085dWx0a2ZQZlUwRW9HNy9BNndUZEZUTERrb3BLSFFVMGNZ?= =?utf-8?B?NTZwdWVmVDh1LzNQSXQ3aXh1dGp2cU9Xc2c5WVJZV0ovVjF4NkpGaGVvOWZz?= =?utf-8?B?Q01heXdSb0xlNnlDYkRXZDR4czJrUTNrdFdxenFHK2VXcmJFa0xybVROWXd4?= =?utf-8?B?anlQOTNrR3diMFlUUmZieTRVUFY5ZTRlSUkrcitlSmRpSWRORjlPOCtaVzhr?= =?utf-8?B?eGZpaXV4dkRRUVpEVFhUb2h6bXBSbmZURjQwa09CZ3hTOTIrR0cwV0hMWFZm?= =?utf-8?B?Zi94VmkvQzRrUVVLRmJid3JaNlczMW0zY3pkeUM3WUhmNXhuRGI1VE9zVEFI?= =?utf-8?B?UWVMQTNBUjdqcURSdEM1MGJWM25VOEtZTDcyVzdTRG14bG82bnNHcGtBTUov?= =?utf-8?B?R1UydTk0NTBQMEcxTytWamI1N2RIWTVYYjFtN09ocFZGaTFDM0RvYmlTeXBP?= =?utf-8?B?K0dCeEVXbUs1L1V2S3VGM3ZpY1ZKZ2dqKzlubjl2d1lyczlxMU1FWVlNMUxi?= =?utf-8?B?VzNtNThCMkFDV1A5SklkR0RLMmU2bXFsVUFKYUgwR0xzenFOaXB5VDhIclE0?= =?utf-8?B?SkxCMjJ5TEh3Q3dQVmlCN3pyZ2lRaWlSc3lwU2d0d3NacXI2cC8rZTBndWgx?= =?utf-8?B?VEx0T1RFbUlJTlM1R1dDL3h4YXZqbEY3ZmpmZ0NEL1hjbzBEVkYxRTJ1MlFq?= =?utf-8?B?anpSSkNFZzE5NHJJOC9CN0Fld0FnZ3hpVzhlU1pXY0FtNU1aWXRMNTlJNytZ?= =?utf-8?B?ZzE1Z1I0WU1tdTc3VEE3N2tzZ3Y0QzlOWi9oOUt5K0JpcGNBRWZRaEREbTVF?= =?utf-8?B?SkJLbEZDTnpLbFVZTkJieTJlQ3h4RDUydm5PbFhKQWNUWnJXYXo3OXhxQVNw?= =?utf-8?B?NjNWVjhVbWRmRjZ3c2g4NlFUWUZGYmpEMjJPWDZUckFZN2JDTnlvSDZRTmZq?= =?utf-8?B?elRQelg1MjhRTWJXOUxET1hjMHRQL3Z5SVY1UEFsczdiWFRaZWFlazNUY1VJ?= =?utf-8?B?c2h5MlowYlBoSUJ2bkRBUkF0OGVyWmVRRXZpQUE4SEQxZWtMZHFoSUd5T0pk?= =?utf-8?B?dUVOZWw1djVYU2ZWaW8vVzUwdTdtejlJcmkxdlBidHg4ZXQ5am1mWWxDN1FL?= =?utf-8?B?SFprdjEwWCtaMGZrQ0FoV1dNUHFxZjcvWnE4KytWLzR6c05kRXdOc1RlN1Mv?= =?utf-8?B?bEtEZFJtK01saU05K3ozSnkvbzdQdDZwUkVkOW8vdTBJUUU2WFpwWEg1R3VQ?= =?utf-8?B?clU2MUpvNUMySzM0Rk1oQjg4TnFwSE9kMGtxbXlpdC9wSzJYdVA1b05wMUFm?= =?utf-8?B?RUcxVEp4RHRnbndXc3JmenJ3V0c3QXZFZGlYSUJzbUkyQmVEWmp4UmRSdU1U?= =?utf-8?B?aFc5aTJqeTVwODdLVEFOSThLbkhIb1NXQUJZQzU1VEpvR1lFckNFVHhFQmY4?= =?utf-8?B?empDZ0ZDcm1lTlJPVFZwMlZxditBYU5Ta1VJK0xQVDNNaTVuRXNYZ1g4WVBu?= =?utf-8?B?Z21XeU5XTUdTSXhqVi8vc2xyYW01bVlaeFlDZUwyR2YxQlNzSUNWWGUzNGw0?= =?utf-8?B?RkF0ZVlVWWdGOVpZUHRDczBrSWJhL2tNR1V4S08vbFZBTlpScHNMSmM4OGc4?= =?utf-8?B?UTJORmdWdFFOeG4yN2pLaUJkNHpIMnNvTTMvMDh2Ukt5YmFOdTlFbGllWkdq?= =?utf-8?B?eDRkcXNiTC9nQ043VDJFTmdyQTFNUWY1V0NwRWZpNjlFcUMxTkFvYmtyRUcz?= =?utf-8?B?YU4vWG1SMXZIUGRsRnVlQ3lYbitac1FKN0tEZ29ZR3dTMHdVM3dnUG1zUUtG?= =?utf-8?B?TFloNklFN1FyZTRjWVhDZi9zcXVoTDdsbTJ5QzJ6R2ltM2JSeVIvZz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5ddcba2-f619-4abe-dffe-08da3727e2da X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 10:36:07.6687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7YxGfJzI/P85nHS+P3irJVWKSq1ctYmzer7CJ5NxVTLXdjxy3X76vS4aOoelMLZ1c01K49SvHPFDbRzmeXHRPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4615 Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 enabled') Signed-off-by: Roger Pau Monné --- xen/arch/x86/cpu/mwait-idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c index 6add64dc5f..5d77672f6b 100644 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init( /* if state marked as disabled, skip it */ if (cpuidle_state_table[cstate].flags & CPUIDLE_FLAG_DISABLED) { - printk(XENLOG_DEBUG PREFIX "state %s is disabled", + printk(XENLOG_DEBUG PREFIX "state %s is disabled\n", cpuidle_state_table[cstate].name); continue; } -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Mon May 16 10:51:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329771.553029 (Exim 4.92) (envelope-from ) id 1nqYJp-0000Iy-9w; Mon, 16 May 2022 10:51:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329771.553029; Mon, 16 May 2022 10:51:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYJp-0000Ir-6i; Mon, 16 May 2022 10:51:17 +0000 Received: by outflank-mailman (input) for mailman id 329771; Mon, 16 May 2022 10:51:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYJo-0000Ih-OQ; Mon, 16 May 2022 10:51:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYJo-0008Bd-Mc; Mon, 16 May 2022 10:51:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYJo-00011e-Co; Mon, 16 May 2022 10:51:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqYJo-0007VX-CM; Mon, 16 May 2022 10:51:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pb1PMIB0th4JCH+ZGOQ4iwRboHYC7Bci0KHqsrqk7fA=; b=z9ngFPylAI+eroICO8xgWQcEA/ pchGB5BCOrZKz45o0/JYaTisiOWGM44U+tLtnhNTVsXzxBQyzAuKqKsqcv7qLP1KEp3itY/5Gcz8A QCT+H8Lf4RQb2pAn5koPXRfsKMhB1rCAertuZdC4NvI2mA5iUVTB0cgwGLP/BCJW+x0w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170474: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 10:51:16 +0000 flight 170474 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170474/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1040 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 59 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 10:55:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 10:55:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329781.553040 (Exim 4.92) (envelope-from ) id 1nqYNO-00012e-TC; Mon, 16 May 2022 10:54:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329781.553040; Mon, 16 May 2022 10:54:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYNO-00012X-Ou; Mon, 16 May 2022 10:54:58 +0000 Received: by outflank-mailman (input) for mailman id 329781; Mon, 16 May 2022 10:54:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYNN-00012R-Pa for xen-devel@lists.xenproject.org; Mon, 16 May 2022 10:54:57 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e6ca8ae-d506-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 12:54:56 +0200 (CEST) Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 06:54:53 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CY1PR03MB2330.namprd03.prod.outlook.com (2a01:111:e400:c615::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 10:54:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 10:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e6ca8ae-d506-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652698496; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BRWcQV2OE8rpcwvZZzfT3j8Wjzpj6qxsNnZV21lWxBI=; b=GCsS6nvajn56pYOj3kOZYwiXlqE7MnnIpZf6besAdkaluZ9RQqTwyAn9 /wnMBHLnGTa/MRkrTpSm84S2SxSAmqwvjx08MBO7WTkM96b0qbU9cUBBV zPIdFie8tzaht0u9srgZTSkBukkVNvaggn1BNDI3tgtVxkCRDOGWnjkUb c=; X-IronPort-RemoteIP: 104.47.58.170 X-IronPort-MID: 71786867 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZLKl46uD1tqQpYlwxQ9Z47Q5V+fnVCVfMUV32f8akzHdYApBsoF/q tZmKW+PPP7ZYDD2eYgjbNvn8UlQuJLSmINlSQBo+CowRioW+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U5 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8IMa2PscMESCJYNAJjDY9X1OSWJVeg5Jn7I03uKxMAwt1IJWRvZMgy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5v3qiiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvDGMnFIhjueF3Nz9cMDVa4J7wE+iu Embpz3FBR8Vatin1m/Qmp6rrqqV9c/hY6oCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN80igkoLU29UerZsLgRBD+q3mB1jYDX/JAHut87xuCopc4+C6cD2kACzRHONovsZZvQSRwj wDR2dT0GTZorbuZD2qH8auZpi+zPi5TKnIeYSgDTk0O5NyLTJwPsy8jh+1LSMad5uAZ0xmpq 9xWhEDSX4kusPM= IronPort-HdrOrdr: A9a23:tKheeK9tQzAjbeSFNEpuk+GBdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrbX5To3SJjUO31HYY72KjLGSjgEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpgdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1cjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3bRY0eTFcZcso+5zXQISdKUmREXeR 730lEd1vFImjbsl6eO0ELQMkfboW4TAjTZuCKlaDPY0LDErXQBeot8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0WbWIyUs4mkWUkxjIdLH7AJlOJ1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEy82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBNB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+q6GjMiq9NFlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmdsPeEQ== X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="scan'208";a="71786867" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PT2ZxZWWU1ZdZ7B4kYeu7LbhhGczglp7T3xoLukstQ0ziob2LKe0HUPZvoDsFVPwBiz5Hjc2WpkSAKbe23WaY7cwHEq7rk044DpCSHhARzTOnLEUA1nUTgUBB5OlJTfhSbQilRMLlCcGuYvVQVLddrYHXBtcxKSEJ/lxy+ITnZRB5TWBMHs1HoRpOcQ+lRuZ0Jq18EESh3is58EtMXoe1jNuhCZxXQFhwsqJ5cRW6eSfgEV6xr3KG1Ai6whxs97vUTyppRl7lb+Xd3joxVu/zvqW6r+430cdl4hnsZdC4zXdAboDd+r149o8+S5IDHeuE3sEdA/1mKC6EXL6P0MdSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BRWcQV2OE8rpcwvZZzfT3j8Wjzpj6qxsNnZV21lWxBI=; b=jnyMPesza2SgTlKXTv5X9a1SXdzs+YNF/RJtS64luWZuDa4JTKBk5nkgTDc81VwLOXmHJ82NObY4vQrEJ1kLuja4IOEELemIe3IiTXlrnSYSyDz/yhQU8rL9FmCBuWjUlKVtQeQV9usYQnwEonyuhtwZZ9Ef+riIawuIdmSLKtdZ7DVI/MuFO34+wG4qgqgA27fzrczKWoG+e+EWn4gM3JeZTdQjsekFjRavjJbe3GWxhwiNt4y4rrBKIqrxDnHPVhle9cNc7R5s3jwpgxLp0XrTqZmv6q4oZ53Fohoe7VMhlmSsv6/JBw+f9Rw9S0mIZjYvJpU7vygoja0yXMwXbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BRWcQV2OE8rpcwvZZzfT3j8Wjzpj6qxsNnZV21lWxBI=; b=Bm1+wkuSPqvszLn5Xk/Zt3fAkNWvcoMMbSD1QgMOhh4BGlt3pG4xHboUgta/7s6fhDiVRXlC8dH42AVUZ5p0as9x59hKpNr70JCmEgxLKXZO0BLCLRVcCCFNrryTu36TKuV079PAuWhiTazKHFq52pL0QgSPx2zxPdg3Numls40= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/mwait-idle: add missing newline Thread-Topic: [PATCH] x86/mwait-idle: add missing newline Thread-Index: AQHYaRDBCor8/aQVu06DdNE3tX3kVa0hVJYA Date: Mon, 16 May 2022 10:54:49 +0000 Message-ID: <508501ef-ccbc-f218-8c6f-9e9556cd3b26@citrix.com> References: <20220516103601.25671-1-roger.pau@citrix.com> In-Reply-To: <20220516103601.25671-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bdaa419f-117c-43f9-8f78-08da372a7f79 x-ms-traffictypediagnostic: CY1PR03MB2330:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xCTbLbUoU0yNjMgmtwVYU/wdayw/i3ypqN5FWNGeH5cVj/oZDy2CL1/r3jjzlL0z5rTa82QtRvigHV5LJweBvFMc17aYD+40lxwd5xxJArhu1Rr7PPea4kclP/JiZjHqizmexnYBJx0xjLccC5j+kHkKkiIFDvUPCGP1YUG2sgu1wejZnUBz9h7aOMrrr9WouC2d4wwMGt7fiC3k0nYFeebgjQrp2MuxHErnAPgQmyPKW46vqo4tGdmoAGY8MymRdS6ocxSRoRn0hp873zvz4fpEWF403UqmirQsTSA0ebMonJmxJ//cVzRhfDOGnrYMSg+Q7asGFoHE7NyRo8ofqISGmSRpF4WpWwehx6AgT3iKC8V+WDJJSyHyJ1jS9cWNFjOfoeMp8AvdeO7B/x2fJ2tQqWltc1D5eAbeWL5No5LvLSVjUycCTsoZXhM2Tm5YZPQxigcJI8XTPN3I/erKFUFCQBGTbtza1rw07x/eCKgWkXY4RN2Ivh2u2P4oWRnMqh/qUiB59M0iqfc2/v7L9BGUkwCUZgPSmobJEKnU5r8b2tl8JIrhJhn/0Qno4I/bEYQJwr3rhVgfCBxNJWn0/VB6+k5ifqb0UtNIsZF79w8s8/HSYxT2DHR9VrHyj+3pQ8FjfbI2bRknuHCyJgZDWiENEFtQ4jRFBAfC9r6c41b9OXmQ3GWTfoXtOoUb4RPem0VEf+CB099upxPsWAatZNPS9go4nouRFdLkW/CXSvUeHEZsimdrX0RrGUUNxyY4Izi5a1D1HHEAbqowH+2Vrg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(71200400001)(2616005)(316002)(91956017)(82960400001)(2906002)(558084003)(38100700002)(31686004)(66946007)(76116006)(8676002)(4326008)(66556008)(66446008)(66476007)(186003)(6486002)(83380400001)(54906003)(122000001)(64756008)(86362001)(5660300002)(8936002)(31696002)(26005)(6512007)(508600001)(36756003)(38070700005)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YU05aEZqbzVqYXBxVzh3Y0Y2MkxpeXNNeHdOMldHYlBMaS8rTFpqNVBRZmI3?= =?utf-8?B?YWxHMkZicG12Rm1oeXhWdFp6ZWZyRjJSbCtzN0gwd0dVbWNyUWdKYUNuWmRY?= =?utf-8?B?RlZaSnk4QUljTzhrTHNKMXZVVTV3TUErR29IejlOd2pyamovT0tNaDVVRWYw?= =?utf-8?B?aFM4bUh1VUlwZWgrcXBNVEhpYVBYakNYTzNLazQzWnRreWpBSjI4SDhmYjlU?= =?utf-8?B?d2hZZ2F4bFRqcFdBTkZjTnRlVjltUHQzdlp3cjk4dUx6VERrNmd5ZHREclB6?= =?utf-8?B?b3c1RVhYd01sK1BJQlo4RFR6c0QyUjJTeC9WUkhibVNxbmN2bGE3TlVtQS9F?= =?utf-8?B?b0lzY0w2MFBVbXF4ME8yOHljM0dZS0h3R2RHK0EvWWo0M0VZNUxqR2FESmN2?= =?utf-8?B?bEhMRTBTeXcrdUd2aFRmLzR0aTBha0dieitOQ0F2K3RmRGtnVzExcm4vSmpq?= =?utf-8?B?SWc4Y1lZMThvdk55V2lMbnpEcTBtYm96dlFHaWhKVktQZ0dWS0ZKWm5BSDBN?= =?utf-8?B?NnFLZmRGUThBdmFYWUJWQ2xpd2xaZTRuN3loTy82TGovVFZGRnZ2SXdnTzJl?= =?utf-8?B?VzBpNTNHUDN5a1BESFhsb2svTWF1YnV0akxVSzdxWVk0LzM4YkJHcUJtUE5N?= =?utf-8?B?dXRvbHdidktDQ3BHei9vTDhoQURISzlzZ3FUOGFLZmUwWHphTlg0ek16dDZP?= =?utf-8?B?NTBFbHg2YS92K28zRHFVNHJVcDlVVFR6Q29iWU9aTjBiUi9RYnBNRjlrVDlv?= =?utf-8?B?YWNWY0x6V2ZqK0JDMnZlL0hVcnhJdG1aZVJoekVobXQxTlB2dytsd25nVXJq?= =?utf-8?B?WFAvNWxPbVE0VjY2NGxFYzFYYUVOZWpDMG45dERKcFVIeWtzcVdSSEhNYnQ1?= =?utf-8?B?TkxUT0IzMFQ3VG1YN2pENSs2V1kvNmQ5Vms3eXlOaitzb0Z5cGwvRGJkWUV1?= =?utf-8?B?RXRqemZPelBMNk1iQ2hDclNWUU9aRFI0dEs2VWZYSW8ydVJNSFEwSlJiYmlq?= =?utf-8?B?UVdwS2tJRDZHc01hWmdqNUlHdVJ5elc2eENYcFpyVWFYMVhhNTJtUUZuM3pN?= =?utf-8?B?TWlUS1FyakNYTjU2V2JFMTE0VEN4bWh1ZUVseXpPdFVFdHFsVStudFUrNjZL?= =?utf-8?B?ZmhNaFIrRytmdnh6cTFCV2xpMzllSlBxT29rOWZmTG9rTFVyTnMwYjBMeGZl?= =?utf-8?B?bTNCcFRCWEtydWxRMW12cE9pdUxSWGVJQ0EzOExEQ2Njakt6MjE4WFNkcURX?= =?utf-8?B?SkVSaTNmYWV0Mk9OQVNQZ3JyMFZjT2hsaEhXN2FqNlU2eVJOTUFNR3BSaW8x?= =?utf-8?B?OW9FQmdEZ3BaZGhsbFRPbERpRUt0MFY3WXN5emVxZEwyMzhKdTNwcm81NkNM?= =?utf-8?B?S29FZ1V6eVI1dlVtUHhsbWFFZUlpR0ttUis1akFSVlFZNEg4TGhiQUdQSXkx?= =?utf-8?B?NEY3V0k5R1hKOWw5UWZqRndndStFZWovQWQvb01WOCtPQ29ZYVFCZFhZbDZs?= =?utf-8?B?WFlWK0YvWGI2ZVVSdFYxUUdDaXlwKzFRM3daMm5aT013dFNuZExsTDVOVXpP?= =?utf-8?B?MjF5YnpwU1FJenVOS1V6ZFZrUURXdlVCOEZ6dXRZbENXTmMyWDZUU1d4c2pX?= =?utf-8?B?bzBLTmJqMmxSd0hBVnVjdWQ1UmZMUk1ic1VtbFBNMkhhRUlCR2JEWmVwd2ti?= =?utf-8?B?bDQ3a2RXN1o1eFBPdW1KMlNTcDZiT2d6K0grYnVqOTJBeWxmaTlySnk2cWtJ?= =?utf-8?B?UnV6VTQ0MGtGcTVkZVBlcXkyb0REQ2Q3NDBEUFNVRlYvQ0Q2Z01qdXoycUR2?= =?utf-8?B?bTk4QllFQ3dWT2tpNEhUWlNHclM1VXdYYlBmWFIrSmlEU1NEUFdGTSthTVhk?= =?utf-8?B?THJicHlUSGJpWWx5S3ZJWVZKVCtQYWFFVGd4UnlFKzB1WU1UMEVXZzFqZFBk?= =?utf-8?B?d2tLdjZmV3FwSVU2VkNVcGlZTDE2R2N5WnU2TXlRbVhiTkFpUSs3MGJHT3pw?= =?utf-8?B?MVRIVTNjTWtZK2RoMG54K2liV2tqUVJqUE1RdEhaQlhSNmNnOVlCaFZHd1Nt?= =?utf-8?B?MG95V2lDdXJOOENWQmNNendVazN5OXpTZzhSV1gyTWJ1NDNvNVg3ekhPOWsv?= =?utf-8?B?RVlpUFJQdzJaM3JCTGlWRFZVOURzTGNBcVgxVHRMNkh3Vk1HdnBURE1OcFJS?= =?utf-8?B?dlNyVFAzdHUrSUJRUlRMcWdYMEJ6ZGhmc1NjOHhRSGVQWlZmZW9FMnJCbmcv?= =?utf-8?B?UkhsN2VVOW1vcWVrM3pMU21XZG9vWW44b3NGNk01SDFSTnZsTmRBbEtLZmVN?= =?utf-8?B?RHFMcEtLY0Z3UDFRZDgwL2tYbHFKbC8zWXBiTXJ0TzgwQWhvZXpDekJ1NkJ6?= =?utf-8?Q?zFcPYQ0nru4AkOW4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdaa419f-117c-43f9-8f78-08da372a7f79 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 10:54:49.2548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dsDRTQWZewfG5tJ71mnszpOORcxtFdAVo+ax0cBkRnV7IZ75Ihdk8ykU3fDdBFWFn3GQWI5qeZ8M4s+tl5LdsnsYd8Szxoy8QjdxuHEJR2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2330 T24gMTYvMDUvMjAyMiAxMTozNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBGaXhlczogNWEy MTE3MDRlOCAoJ213YWl0LWlkbGU6IHByZXZlbnQgU0tMLUggYm9vdCBmYWlsdXJlIHdoZW4gQzgr QzkrQzEwIGVuYWJsZWQnKQ0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dl ci5wYXVAY2l0cml4LmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Mon May 16 11:12:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 11:12:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329791.553051 (Exim 4.92) (envelope-from ) id 1nqYeF-0003bb-E1; Mon, 16 May 2022 11:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329791.553051; Mon, 16 May 2022 11:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYeF-0003bU-BA; Mon, 16 May 2022 11:12:23 +0000 Received: by outflank-mailman (input) for mailman id 329791; Mon, 16 May 2022 11:12:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYeE-0003bO-CI for xen-devel@lists.xenproject.org; Mon, 16 May 2022 11:12:22 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d2a79a8-d509-11ec-b8b8-f95467ff1ed0; Mon, 16 May 2022 13:12:20 +0200 (CEST) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 07:12:10 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DS7PR03MB5560.namprd03.prod.outlook.com (2603:10b6:5:2d0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 11:12:08 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.018; Mon, 16 May 2022 11:12:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d2a79a8-d509-11ec-b8b8-f95467ff1ed0 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652699540; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=qJZGoQtMUosnahodJXNGxNsVTEubzDhvaXimcToqeNY=; b=JmoN0/IIYVltE/mJTYl3Xnl8/4rzXJ8PZdciQUKVXWus2W63DSfOeVm7 yXS5JQ8bWq1ThwnZ7ZcC9WbFf4uk/Y4c8W28SC93dJ3Ic4gv+J7KsHcGI saisptqMQ6w5xrsR2jujFms+khvV052xSaXVoYxFQrVWqO5EoiM9iiYpk I=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 71788102 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MjpUrKvq3Wo+yeAahq8cI7p3gefnVCFfMUV32f8akzHdYApBsoF/q tZmKT2EPqreYmb0eoojbou0phlSvZWHnYBiSFFs/ihkQitE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U5 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8XHoDrt7g4YyB5UBwlN6ZMwrLuC0iW5Jn7I03uKxMAwt1IJWRvZ8gy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IFmm5v2qiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3M+vpnujCJpOB3+L/sAfTbWNnQee9yg3uDg 2ns7mnhUw5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUHBBqlz6PV50OTADgCRzsYMtg+7pZpGXoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd14Cd9e3Yq 9xSkBUDug== IronPort-HdrOrdr: A9a23:CUnlHah3ToZWKsFK2SKBOqRErXBQXzx13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMzVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP+xA+A2frfKVy1zx0eWzRAzfML9n XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXAnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MaM8F6+xrqDxOIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8e1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh57D3xHklX6voIRiKprzOSI JVfYDhDbdtABinhknizyVSKIfGZAVyIv+EKnJyyfB9nQIm30yR9HFou/D3rk1wiK7VdKM0md gsSp4Y8o2mbvVmGJ6VV91xNfdeNAT2MGPxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK g= X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="scan'208";a="71788102" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ty21+rlkdHzwrhvrYoW0pZl3NPk7vUcRBCx2k1pcbcDquVZ8ScVsP5Uh4VZEZqDTEBBVQf3koEqkMz9u+w1xI1B4nXXvnzTCUQX4CUQ3cFpja+p2PE1shGIj2XvEa9hIcuNKab0VFuL3j1UzGPPtP97r/63e77rcNVUeHf7Aiedbzg4t2NUspkKjsAcx9UJA1LE4HdI+k/ZqWOlUhjaGpSjWr2xyWnAXBV1ehSf3pTRrJ8hdmSQVWpEHalJ3L5BPbPO5kAkDLSE731BDFQ5V7llVTVS6VYLfqCiMytB/8e4/YF/A179sgZ9NFNKEG37wmGTgFivThqpyu/4T9dGpGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nhCkh1FZ1F5zJ5J/ndjap8DJe5PWS3yWzz3ngommb2g=; b=UUyelrA/DpS2Yd4+vanonIdwaE60/fBd0NESMSsIF2tlGcrwbN5dX7BpIDvGxk/vCCQWk9TqjQV1CXknaljZXVpDuRB6pPMifY21FEqXt2//R0qIEsIRbd4fIZDxVbcEvCSnXaI6GHtb/72gIbbg7yxeOy+axRxss8lCggIfVRhekMBt5xeRUX9jbkopXtY929CWQvhwh6M8lcpghbD31C00RJYMymW6hUriop/11g6yVveaFLDw5FPkv1iG49CtHHnX1KkeZawVEfY3cJIpulok6zMezW7ghr8Tf6gUaRKyEZRBc3pdnBZSYTvOJOE0K16Q/n+7tn3jpRAc7tIgMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nhCkh1FZ1F5zJ5J/ndjap8DJe5PWS3yWzz3ngommb2g=; b=gGLjRKM470+dY3a95HbVfnrgoOpkIY4EjN9pZg3PrCv6iwCi10ay0Hp8yoqXJ04VpYq2Oc8Ud/6j2n2XmerMc1BywxB9VfpdNxX+hf6E4zD7e4Eg+4LADANInahXkO5dkMbNINb9jFUJhP/q2zrMBGzwdEpcswRiHGeEoVLj7C4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] x86/setup: delay setting SYS_STATE_smp_boot Date: Mon, 16 May 2022 13:12:03 +0200 Message-Id: <20220516111203.26463-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0070.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c6ecf28-500e-4804-6eda-08da372ceaa9 X-MS-TrafficTypeDiagnostic: DS7PR03MB5560:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y2N1RrSsZ/t7ZXwmH/naG/j2vMb9S1qZJFLXLNpGChCjVaTPkTKKb0caZzJ8aRe82ecgcKqNIfcX4uviSp9iiUgpHV9FPub5RcA0/3C5pR5ZR6PkMyz7u7+DWPzUyo/9wPBEOhbDC/GEp7I2YSgDWaNNjHKRmMEY9XNAsN3xT6XGQAsnevZEi801HrocQVYtgaa2yw/1mFEZ35o5cHbuYcybZTMHa9yOEX0nNywnNldsmqRyWlWdOiR0RvCBN4yaLasN1D8y8CYU6RSnGBHR/RTtSD8hZtbPAc5WYgE4tzoYnw0SRbrPdNwxkBzdYXxDVwelTyLnkAGgtEFz1K/HwWeuKxDS6+p33Gu16TkQlOAf6fazz1xx8vAWogvCgXMHkTO7XJllMgRIhKd6eQb8ykqnWP72bZz/aKEwhAGcj2EEzwVVJOkWShrMUhouX7rV2i6nIzxI+6FDk4cpNVDY4NX2kv3/PR/aHDyE5K+YEFH+YNguYOQe+sLEmCzSt5We5jSJ5Dm1wdgBtVyGmX3YRu0uANr/oJYXz5FVxImYh0Lnk9Esvbqk3pK+WqbCYZVn/8JLBpbM3vQMfCWnLkL7gLXq6o6w3nFqNe/Z67sHiNSK8fYYm+KjzWND2n9cFvzn0ozDb+vWCUqVem0XAbZqOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(66476007)(8676002)(4326008)(66556008)(2616005)(6666004)(1076003)(86362001)(83380400001)(8936002)(5660300002)(38100700002)(316002)(186003)(6506007)(36756003)(6486002)(26005)(6512007)(82960400001)(508600001)(2906002)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHVLMmpLd3BlYmo5MXM0VHBwZVlkdmZqMlhYRHBQTEx3TGtORWViQm9zdDlk?= =?utf-8?B?VUNGMUNoUVhsZjJ0Mk1odXhINUp5VHBDTjQweTBVZ0Njd3FweG9raGI4UmtE?= =?utf-8?B?ckpNWGFXVnJBNGlUM3U4NC9oSVBlbFltT1liMmdFQ3VhVDZhc3l0RmtoMmhH?= =?utf-8?B?YmFiUHdVUkYvNmZlT1VUNFU3VVFCaTlSRkRBKyt1bk5XU2xzUmIwOUdaRk5k?= =?utf-8?B?dmZJdndrd1FHblVoNnNLK1VCUTB0SGZyUVdheXl5bnpBci9vR25pbUJPcDVz?= =?utf-8?B?eHRZc2IrejBGYjQ2UFVNMFAwZEJ1YVhkc09ESTZLSkJEL3BqNHpmUmN3SjdE?= =?utf-8?B?bzR6eEk2Y0o2MXh1YzNNYzZkZnpqRnpNdjdaeHJYbGhxYzhWQ3QzNm9KY1Vm?= =?utf-8?B?V3QxTlh4cEtocjI0WUF4bDZVeGJBMmx6bExJZ0l4dHhobzlPRE5OVFJEVElK?= =?utf-8?B?a0VueXgzcUsxUi9rOWJCVDhSTmVnZWlrQndLdzVqNnVLVW9RanpCUUplZTJy?= =?utf-8?B?c0VpR21RN1N4djFwa2tMWXBUZ1BVN004d3ErUWs5bzVzQ2E3alhvUGF2eis0?= =?utf-8?B?Q3FGNDVUNElBZk05bUd3OEtzMXppUWJFSUFmWkNwSHNiZ3pKL2puM0lWMzN2?= =?utf-8?B?WjdGdkM2U2xMTVZ6VVZIMENKalloRnViRittQ2pmTlZiVUw5UDJxdzlxa3NT?= =?utf-8?B?QjV3WUt4TW0zTllWYXBoc1FoOVY4eVAxNytyZVVUZVZmMmo5MWNQZzFFZGFE?= =?utf-8?B?OUNMOU83SE81a2tGcEZsT1JZeW1lUE5oUkc4ZDRES0NORkJqYkxtWm1mYi82?= =?utf-8?B?ZXg1MUFyMytzRWhCZkdRZitKUys2UFlKdmsxU2NuYkkvL0orUE9Mdm03Qk5B?= =?utf-8?B?cnZ2TFFsZXMxVG1aK0dJUUR4MGV4OXpuOE5qa0FpemJkWGhDUlFDbkl1NGtn?= =?utf-8?B?TTJXVm9ZckpUTkxGTSt1SXVqOFFORGZxT0JLY0ZJakRJK2UraGlDOXRqMklu?= =?utf-8?B?UFB0bURENnZ5YlpuUlZqSE5FUXNia0xNVGZuQnhQUEVxNU05WlU2ZW95NVkr?= =?utf-8?B?UGJXMk1uN2h2WXp3bnJSTnBmNnF1ZWI1SERsd2xMNk5SaWxwV3lYdjZpdXl4?= =?utf-8?B?cldwSWdWUi9jVC9jU1JnV0F0T1NtZHA1WmtNYjdYcllhTTNIMlB0V2RDdnVP?= =?utf-8?B?QkJ5N3VyOTRZYlJzcGg3SlB6cUlncC9hYU1nTUwzaGRPdUZDd0lNeEhKcDla?= =?utf-8?B?Y21jaExTQy9ydnVyR3FROWR6aXJGckFUcHN2eXExck4vQmtRUVZBWERxdlVE?= =?utf-8?B?YlJ0M2U5c3p5bXY3a1Nqd0QrMnJXQjNkZTJ5ZnFlR3FBd0NYeTNMNXZyM0NI?= =?utf-8?B?VnhUNTQ1YUV2dGRTWDVOcDhvSDM1UjdsUHAreU9kQmkzTWlkbE5IaGh6OENy?= =?utf-8?B?MXIrS3VweHNoRW9XbFF2ZFNnQnpKaFBnUi9VVGlKWWx4ajZDZDhvb1ZMa3pK?= =?utf-8?B?anl4UVA2NHIvcHh3U3FPOTIzTndvbit3ZDluYi8wTTRvZEdONkpnSG1xcEJl?= =?utf-8?B?elhJUVZMWmFUajBxaFd0ekU3NC84U1FuY0ZUOWludHBzVkd6QzlIMi9hUjFz?= =?utf-8?B?TlhCOVFmMWVzRmlFYzBBbWEzMXVVV1dFWnNKOUR5ai81Qk5tZnZmV0RGa0JP?= =?utf-8?B?eUM4aTRaRkZSS1VLazllT0FqZjhlQkJoS3VPMkRoRDVwa3ZWMWw5K3BiN1FK?= =?utf-8?B?dGlFaitIYVpvaXZWeC9GdWczd05GUWQvTTdpZ3pBTFBDMFowQzZZekRUQm5p?= =?utf-8?B?aUtPNCsvYUtDSkJmdXRhR1RnWDU2N0NJcEN1TmJRcnhtazkwbUtEMUJkQTEr?= =?utf-8?B?KzB2ME9xcWhTQ1hTN2thWkxJVXdoUWxwb2o1WUxTNEhXZlBsRlVVeUpjalhI?= =?utf-8?B?WkxIVjA1VVBDTEp5RzJZRjBmVGMxd3MyZkp0dHZoVWFIUVEzWi9ibGhwYWc1?= =?utf-8?B?dzlsSERzdWp1U3lVam4wOG9FQ3J6dnBidERpTFZYNnltaGR4bW1STHRyWHFO?= =?utf-8?B?NnYwQnNxYkRiQWR2cmFzUzRZNkJTUHZsVWc4M1FHY2dYOUJ3VVU4SjhMdGlU?= =?utf-8?B?UDZjU3dWYk9NY1RTUlE1Z3owOHlzUk5ZTFZCd055aGZTUzRLQ1c1eUN3OFJJ?= =?utf-8?B?dDY1QU52U1hKMGlBTmVGVE1uS2k1M051Q1IyMjk2MUp3N1cxS2lPN2NqcEhp?= =?utf-8?B?clhZR3JUUzN3WTBBYnp2dm9rQ0hwMFB1T2NhRFd3LytQNzZ3SEUwMm9CRHNG?= =?utf-8?B?cVRnaWF0VldZRW1oU2l4aU5YcnJOMkFucnRDeWZBSWZMRzU0YVE5OWVzNFhu?= =?utf-8?Q?arYzayVzLQTPkRMQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6ecf28-500e-4804-6eda-08da372ceaa9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 11:12:08.3594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DRCiBdXwyoFr1uFBF8uXUJHVLMoV8X2lrhU1e/+GXvu8ESiLe1Rzuyo7fzTj31vHDPBiJ67HHN7EHguxzqWQSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5560 Booting with Shadow Stacks leads to the following assert on a debug hypervisor: (XEN) [ 11.625166] Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 (XEN) [ 11.629410] ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- (XEN) [ 11.633679] CPU: 0 (XEN) [ 11.637834] RIP: e008:[] flush_area_mask+0x40/0x13e [...] (XEN) [ 11.806158] Xen call trace: (XEN) [ 11.811255] [] R flush_area_mask+0x40/0x13e (XEN) [ 11.816459] [] F modify_xen_mappings+0xc5/0x958 (XEN) [ 11.821689] [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 (XEN) [ 11.827053] [] F alternative_branches+0xf/0x12 (XEN) [ 11.832416] [] F __start_xen+0x1ef4/0x2776 (XEN) [ 11.837809] [] F __high_start+0x94/0xa0 Fix this by switching to state SYS_STATE_smp_boot after alternatives have been applied. Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to local only') Signed-off-by: Roger Pau Monné --- xen/arch/x86/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 53a73010e0..318f02f6ae 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1853,12 +1853,12 @@ void __init noreturn __start_xen(unsigned long mbi_p) console_init_postirq(); - system_state = SYS_STATE_smp_boot; - do_presmp_initcalls(); alternative_branches(); + system_state = SYS_STATE_smp_boot; + /* * NB: when running as a PV shim VCPUOP_up/down is wired to the shim * physical cpu_add/remove functions, so launch the guest with only -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Mon May 16 11:30:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 11:30:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329800.553062 (Exim 4.92) (envelope-from ) id 1nqYvF-0005Iz-Rr; Mon, 16 May 2022 11:29:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329800.553062; Mon, 16 May 2022 11:29:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYvF-0005Is-P4; Mon, 16 May 2022 11:29:57 +0000 Received: by outflank-mailman (input) for mailman id 329800; Mon, 16 May 2022 11:29:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYvE-0005Ih-3f; Mon, 16 May 2022 11:29:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYvD-0000OK-Rt; Mon, 16 May 2022 11:29:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqYvD-0001zh-9p; Mon, 16 May 2022 11:29:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqYvD-0003ms-9N; Mon, 16 May 2022 11:29:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nqNOshzwNMWqWfR7n17cTIOxnZg/geoRH+woDXBHCDY=; b=nXXYrBfphpTwCe0CafTkpg5G7u xlpfRRbE868iGkagjhJecUUdC5xxghD1djtgMvuBw4m0IYES38UrjrPswITT6IWCoBg2f/PklEaol KTkVbw2eauHF36IpbKvIzE9x3mRByvYULcyS1ExThZ1rarxkqJFowILSFR8JHNejrmZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170476: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 11:29:55 +0000 flight 170476 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170476/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1041 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 60 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 12:07:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 12:07:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329814.553072 (Exim 4.92) (envelope-from ) id 1nqZV5-0001UN-1T; Mon, 16 May 2022 12:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329814.553072; Mon, 16 May 2022 12:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZV4-0001UG-Uc; Mon, 16 May 2022 12:06:58 +0000 Received: by outflank-mailman (input) for mailman id 329814; Mon, 16 May 2022 12:06:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZV4-0001UA-23 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 12:06:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0d::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae0c8991-d510-11ec-837e-e5687231ffcc; Mon, 16 May 2022 14:06:56 +0200 (CEST) Received: from AM7PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:20b:100::16) by AM0PR08MB3828.eurprd08.prod.outlook.com (2603:10a6:208:108::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 12:06:53 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::4) by AM7PR02CA0006.outlook.office365.com (2603:10a6:20b:100::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Mon, 16 May 2022 12:06:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Mon, 16 May 2022 12:06:52 +0000 Received: ("Tessian outbound 42cead292588:v119"); Mon, 16 May 2022 12:06:51 +0000 Received: from e147d98fd594.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C0AF5F89-0F3F-4477-BE0F-2B5F5DFBE8B5.1; Mon, 16 May 2022 12:06:44 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e147d98fd594.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 16 May 2022 12:06:44 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB5154.eurprd08.prod.outlook.com (2603:10a6:208:15d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 12:06:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5250.018; Mon, 16 May 2022 12:06:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae0c8991-d510-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RGYWiZPqgmdvDUhUFoiXp9Ye5ItdLAoh2doSQ0eATwZ6sDUhRQpY1c4D3usXU5P4wHEy5im0btpZzWi2JXTDMfQ04fYtMQzAj3SHBcjIyIEUZevjTtmkojYNl6MnlZI68I1SqUjWIHwiBK+BFV8e0+celXG+kKil4lbgVe83mEEn3Kv446F7DtpgU7dzKkkpS2w3vr+kl9ioQYBCENI6MzgczSIVAIneho5guMbAr+A/VGQ+jqKaUvk2vdPplJ5dF0tGtHNR27PDDdkmON0armND5oCbJS2Nj4HdcqjMvRi/e0pD6TVfioIZQp33d/ELv5vCxNgbJaJpR3vXLUHiCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hbzq96OHyB86eOvTJasK8OYjYHkVSJJ2op2IQBdMr6Y=; b=DW3V2HzAJpw6MujIZndbEKRHnkS10m2HRW/JSHTgZTqHheNY2xmE0R+2Zmpd+w8MfAdNa+zGFhOXR1XNUPc0v5QCYqKEZ09JSDURz42+75F9c8yf62oeYgbDy0bxCdd5LuzRqRDJVBN9zZ6TMXfA9Z5D4tJiM3LLAY0F22llDpfEjI3Y+xgVKGQFMo0qPYcPY1F3TehAdUcVThDwPL6egMUyhpkfOohCssVwSeeTGm8e179b+4BJsAQPbeJMcdjXOUpJLxat3OzfRuMWJOvAkxJq1D2TcmIZzBIwUvtsZnwgcV+Zkh9WKHEvtIvda/psQQ1+kPeQXPyp2N0MGhZI4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hbzq96OHyB86eOvTJasK8OYjYHkVSJJ2op2IQBdMr6Y=; b=vjRhInMQtR7SXYSyyx/gutC40xQC4JyuiLbR59S/0wAPjM9DD6EbtEE5ZZjHfBjC3025GAbnQ4z3LCR25cr4yu0MUYv6vMbRgqr2akTZH8/e7iSVIpvfdQEvkuDQyNP4ZyJc5o9EaJaw18V8Wx2XhX9rN1Pu0lLwqAU9uwB/JgI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0b04134b4ea7585d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNWHG10NbMCZwZn7SylC4+6xZ32YIK+/vo9AIvDBQ5ofbmNU4/wZzdlppzrnRXn5cbECxbIzy0P/ysAgkh2y+135xDiMuUWnI535v1Nw5rforUD4A5y7NVU5h2TKAR01t0PJh1dgJB4kmA43LV1s589rhsb2pWYe4aUC3t8AVRpAfMiYkLF1PR6j1N7GkIvigjliqK8rR3RxBNQzr21TkWTJvCWzAQ3pS6nfcYdOKjDPL5t8NDoaPkcDacipQjpNoZGfWfY1rJGhwOynD6i0FyhUiXx4y0ZAMVbefo1fQSaxcRNvlJgy279MGkX9ZpueT+SL89Jt5WvfPtrDrtp0GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hbzq96OHyB86eOvTJasK8OYjYHkVSJJ2op2IQBdMr6Y=; b=NbUF4zg1NLJgUk/CHZXBFcQysLxvDBe6kRCzTu4I0m1BVV/6pYedMTLyra+H62Sk8nvn5kwhFZRc85iJzOeLQAXENUTaoXTY5fmJyipKh16OHDt0n3Hl/6hUO9LIOJplEXq0b1uNu8Frzv+1llm8psPogdbwiSn4A2KlpJVeI8YMEMZ5W6LWJ+vZTPM3bxnjMH5bVj+ag0KMB4whxjjj+tbkgnRkLNbiSlfDwvyEgr4Ox/TfBGPibz8asHfVGW3eNiyCluBWSNS1k6+dRiaUprY9mmsDTGAS1EkUWR5VQN8poDFAGImvunUq01YHOcFUolqiJREtOhRUd6hZyucrbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hbzq96OHyB86eOvTJasK8OYjYHkVSJJ2op2IQBdMr6Y=; b=vjRhInMQtR7SXYSyyx/gutC40xQC4JyuiLbR59S/0wAPjM9DD6EbtEE5ZZjHfBjC3025GAbnQ4z3LCR25cr4yu0MUYv6vMbRgqr2akTZH8/e7iSVIpvfdQEvkuDQyNP4ZyJc5o9EaJaw18V8Wx2XhX9rN1Pu0lLwqAU9uwB/JgI= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Topic: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Index: AQHYaQFPaa+cmN6NyUGhGvdTzOfzhq0hO1kAgAAHagCAACYIgA== Date: Mon, 16 May 2022 12:06:42 +0000 Message-ID: References: <20220516084517.76071-1-julien@xen.org> <2E233152-FF46-42CF-B2CD-62E0BBE793C3@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d6ae4164-1613-4f64-b876-08da37349025 x-ms-traffictypediagnostic: AM0PR08MB5154:EE_|AM5EUR03FT011:EE_|AM0PR08MB3828:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ep9wSPGBEGC2JB65KO68v6GG1C5T1tE9pTFDsrY6qreUtkaY9SmCtKhEnOC3EoFK4nH7rrbTOJ7cy7RIqjshThFiOr0hyYq0mC2lGgx2QdLmuwGb+8wFY7d0jb4H3Ph7PZbwETgsFA43JwKD/4FD8PY9pWnVIu3/1L8JFTjwNeBPfJLHlQL81sFxroZVmtizYHkvMrGnH4xoX21PvslwRcIUGULXMh4wjnuyCEKPSD+pCX0Y8E84yioKPVMDac1PZZf22dxMj81J7kDw9tODrHH7Y7z0EbHjY1Hihq/kosMmYiZeYsyDOpIOtQeuK9Nq7i6r+POCZr/DwiunSwPeuJcaJ4Aif6UIYJTYL8YIiSN7TIFAQSW3M7kcNjSkAwNwgFeCdcq9cDdp9mUVMMAKJRMEUo0thO4Ww5q5xyrFh29JQFcni6s+QwbYSzmvqta+d2QDxxIvV+ObuSJlsgfrfHNdtP1l4mLIYkhfRwb3bl6mo/F6Fot/0k3FELjt2T1UzssQBXMn9eHgrcXXdawPSqf2Xt3uWIgjuB1jaZlxiaoikmEr3IGc2Mpm1G0kEiaaU8T9+l/PAA6GPXscivmWU4ZFMw1lno8Ab9BBQa80/fSp7cJWa3G+bRQbX6LZe54lEtfjiclDti++oQiTajQsNPL17gmxGJrPm67c8QZgKIrFBZQgzYy1pzD0tpaxX8XRtmaZuq1X6/+pazI3eDmmTFt15C1AkaHdHpnjlbR1rUwgGIkSDS6TaCAtT2CapbQjAPhHYryq+VDwq/UczQfM2qxMcAWvLuaFvJ91zc4T4UIUd9T4bMpujQXjgblZPgot X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(186003)(508600001)(316002)(38100700002)(5660300002)(38070700005)(83380400001)(26005)(8936002)(6486002)(6506007)(66946007)(66476007)(66446008)(66556008)(64756008)(76116006)(54906003)(71200400001)(53546011)(6916009)(33656002)(91956017)(36756003)(8676002)(2906002)(122000001)(2616005)(4326008)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6487FC367F4BA94CBB8464F6589025A6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5154 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d178d08d-b0e2-42bc-08c3-08da37348a26 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ha/6ziVZr2Hauh+OkYqJoKAKDXIhsRIhbjOpimxxpnY7tpsNFGkeFr28CW6D+o9IMxE+F5JuEPbnlN2HZU8rky3NxNbcK4Were9PAM9Dfc2qluTMSrYKy36AL+QBOl5bXREVmefTqM/Ixy/1cZCoz1hpuKPnMOsmI+ORlEomrTU1hx+5mhH4Hfa7xP24Nl4nnxToYfXr58DWuR3sRkG6fGoVwIlml5SBbyh8mKGSIr7eARAvyweH4hIcBC4JI+NFykY74hb5vlWYM5EmuVohlnAf10wiD02PgMArxqZO9t6USe2da7g8z/MSVcQ22VyDgzMMSM8gxThO9UBRCJPPWzXGkCeIgrWg8McZvZ2LJYnLXe9h8sFzjiJFQqNtqd3LeswYxWNeZf2OFoozbvKhRkjUr5W7akrdQZXP6YAwabIPbjf9wKvhkIsqS9wrc6fnuRRbR8lK3SXgZTRqOxsD7VcpohPJQPODQ5YyZmTZ434g9n/cLLlys4AgcFvihSitg69sEoKMW10GhmKxG49m1zAwD+LLSc0nRy+ZcJck/tcyfe9eNmI7WMetU9rHfgc0u1iCc/7uX/hKiQ18IT89ViG4wL9MJGwt4+oUSPxcexZNApv987O50ggtInBuRw3kz/DqloOULW8sf8yAb2vlExsNYowOPD5ILKX3nFHSVzeoCilACUNNgczpFP3M/EL7RrheH8TA+WUrBbICkZ5nHNPu+JEHF96g7iA3FcYg2/wOqx+B1VeQ2jeVYas953Po X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(6486002)(6512007)(6506007)(53546011)(47076005)(83380400001)(54906003)(36860700001)(26005)(8936002)(316002)(86362001)(356005)(40460700003)(36756003)(82310400005)(81166007)(6862004)(4326008)(8676002)(107886003)(2616005)(5660300002)(70206006)(70586007)(33656002)(2906002)(336012)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 12:06:52.1671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6ae4164-1613-4f64-b876-08da37349025 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3828 Hi Julien, > On 16 May 2022, at 10:50, Julien Grall wrote: >=20 >=20 >=20 > On 16/05/2022 10:24, Bertrand Marquis wrote: >> Hi Julien, >=20 > Hi Bertrand, >=20 >>> On 16 May 2022, at 09:45, Julien Grall wrote: >>>=20 >>> From: Julien Grall >>>=20 >>> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap >>> alloc/free" extended the checks in the buddy allocator to catch any >>> use of the helpers from context with interrupts disabled. >>>=20 >>> Unfortunately, the rule is not followed in the LPI code when allocating >>> the pending table: >>>=20 >>> (XEN) Xen call trace: >>> (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) >>> (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) >>> (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 >>> (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 >>> (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 >>> (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 >>> (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0= x20/0x50 >>> (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 >>> (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 >>> (XEN) [<0000010722aa4200>] 0000010722aa4200 >>> (XEN) >>> (XEN) >>> (XEN) **************************************** >>> (XEN) Panic on CPU 2: >>> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpu= s() <=3D 1)' failed at common/page_alloc.c:2212 >>> (XEN) **************************************** >>>=20 >>> For now the patch extending the checks has been reverted, but it would >>> be good to re-introduce it (allocation with interrupt is not desirable)= . >>>=20 >>> The logic is reworked to allocate the pending table when preparing the >>> CPU. >>>=20 >>> Signed-off-by: Julien Grall >>> --- >>> xen/arch/arm/gic-v3-lpi.c | 81 ++++++++++++++++++++++++++++----------- >>> 1 file changed, 59 insertions(+), 22 deletions(-) >>>=20 >>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c >>> index e1594dd20e4c..77d9d05c35a6 100644 >>> --- a/xen/arch/arm/gic-v3-lpi.c >>> +++ b/xen/arch/arm/gic-v3-lpi.c >>> @@ -18,6 +18,7 @@ >>> * along with this program; If not, see . >>> */ >>>=20 >>> +#include >>> #include >>> #include >>> #include >>> @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lp= i, int domain_id, >>> write_u64_atomic(&hlpip->data, hlpi.data); >>> } >>>=20 >>> -static int gicv3_lpi_allocate_pendtable(uint64_t *reg) >>> +static int gicv3_lpi_allocate_pendtable(unsigned int cpu) >>> { >>> - uint64_t val; >>> void *pendtable; >>>=20 >>> - if ( this_cpu(lpi_redist).pending_table ) >>> + if ( per_cpu(lpi_redist, cpu).pending_table ) >>> return -EBUSY; >>>=20 >>> - val =3D GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_S= HIFT; >>> - val |=3D GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABI= LITY_SHIFT; >>> - val |=3D GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIF= T; >>> - >>> /* >>> * The pending table holds one bit per LPI and even covers bits for >>> * interrupt IDs below 8192, so we allocate the full range. >>> @@ -265,13 +261,38 @@ static int gicv3_lpi_allocate_pendtable(uint64_t = *reg) >>> clean_and_invalidate_dcache_va_range(pendtable, >>> lpi_data.max_host_lpi_ids / 8); >>>=20 >>> - this_cpu(lpi_redist).pending_table =3D pendtable; >>> + per_cpu(lpi_redist, cpu).pending_table =3D pendtable; >>>=20 >>> - val |=3D GICR_PENDBASER_PTZ; >>> + return 0; >>> +} >>> + >>> +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) >>> +{ >>> + const void *pendtable =3D this_cpu(lpi_redist).pending_table; >>> + uint64_t val; >>> + >> Should we add an assert here to check if we are to early in boot ? >> That would also implicitly explain that allocation is done during CPU_PR= EPARE so this should not be called before. >=20 > Do you mean something like: >=20 > if ( !pendtable ) > { > ASSERT_UNREACHABLE(); > return -ENOMEM; > } Yes that would work so that we could at least identify the origin. >=20 >>> + if ( !pendtable ) >>> + return -ENOMEM; >>>=20 >>> + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); >> This ASSERT is already done in gicv3_lpi_allocate_pendtable but it makes= sense to have it closer to the place where we actually set the register. >> Otherwise this assert can never be triggered. >=20 > So the ASSERT() would end up to be triggered if the code in gicv3_allocat= e_pendtable() is incorrect. >=20 >> Can you remove the one in the allocation function and also copy the comm= ent that was on top of it here ? >=20 > I would like to the keep as it is. The check in gicv3_allocate_pendtable(= ) happens also in debug build and would allow to catch any problem before t= he CPU is even running. >=20 > In general, I would like to move to most of the checks when preparing the= CPU so there are less chance for failures when the CPU is booting. >=20 > The ASSERT is here only to catch any misuse of the function. Ok make sense, I am ok with it. >=20 >>> @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits); >>> int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) >>> { >>> unsigned int nr_lpi_ptrs; >>> + int rc; >>>=20 >>> /* We rely on the data structure being atomically accessible. */ >>> BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); >>> @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi= _bits) >>>=20 >>> printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LPIS= ); >>>=20 >>> - return 0; >>> + /* Register the CPU notifier and allocate memory for the boot CPU */ >>> + register_cpu_notifier(&cpu_nfb); >>> + rc =3D gicv3_lpi_allocate_pendtable(smp_processor_id()); >>> + if ( rc ) >>> + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", >>> + smp_processor_id()); >> On secondary cores nothing equivalent will be printed and in the cal pat= h there >> will be nothing printed at all which could make debugging complex. >> Can you move this print into gicv3_lpi_allocate_pendtable ? >=20 > Good point. I will do that in the next version. Thanks Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 12:23:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 12:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329822.553084 (Exim 4.92) (envelope-from ) id 1nqZko-0003x6-DY; Mon, 16 May 2022 12:23:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329822.553084; Mon, 16 May 2022 12:23:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZko-0003wz-A9; Mon, 16 May 2022 12:23:14 +0000 Received: by outflank-mailman (input) for mailman id 329822; Mon, 16 May 2022 12:23:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZkm-0003wt-TM for xen-devel@lists.xenproject.org; Mon, 16 May 2022 12:23:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1cf7065-d512-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 14:23:10 +0200 (CEST) Received: from mail-mw2nam08lp2171.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 08:22:46 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by CY4PR03MB2533.namprd03.prod.outlook.com (2603:10b6:903:43::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 12:22:45 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7%7]) with mapi id 15.20.5250.018; Mon, 16 May 2022 12:22:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1cf7065-d512-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652703790; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wIAnczFkxUvcdgGB2qZTtqomp2OnmE37nOteaSXjqzQ=; b=f/IzkoNmkVDfYHgkDmcDBIDLJfzVS1hKlKgF05pH8UNVjonWASY5rCVT EanHPGvHnTZnUeLYa1NdB6qn71kzzxiBiAaDRoH08l+JRnBOTBMTJ+EVj 4qv+/vHW50ktt3BYQxLjd/HWkWFzyYUCeOn4GGar+VX/qq+McSFy90Lzg Y=; X-IronPort-RemoteIP: 104.47.73.171 X-IronPort-MID: 71794054 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UEYSqKDC4o66khVW/1riw5YqxClBgxIJ4kV8jS/XYbTApDwk1GcDy mJJUG2BP/aNa2T1Koskb4q+8k5XsZDUmtNlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng39Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhe2 pZP9sHvRzx3Affzo78bXDJFHA1XaPguFL/veRBTsOS15mieLz7J/K8rC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l9B8mcGs0m5vcBtNs0ruJHG/uYQ sMdYD5mahnoaBxTIFYHTpk5mY9Eg1GgKmIJ9ArI+cLb5UDJkClg3+bvM+GNa9+WdcNvtECAq jrZqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZsb5dw21pjiDpBF0ZjZLO+gz6QXIz7WO5Q+cXjgAVmQYN4Vgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo0yeEJpprUZwQ3N/ g0= IronPort-HdrOrdr: A9a23:kohQ2qhCBMTZnMH6NDyRRDLWbXBQX3h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin+90a1wbx7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEXQI5tlluZEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="scan'208";a="71794054" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JlbBPoH3vgymmT/cdeUmshMZ7PS/bkOu00vt4AeJ+hgkvxFJOi2WtYSWikunOf7bs24HZ4LicHlyigaGc2euJIHeBVhbVdYDTXqSMtyVEso0HN36BrX2hyvqK96h0CJlb5u5pAaH4rLKKgUWA7Rt1qEVYP+AejYX86eBOEqcgnE96vA6qghI2Ds8sl7d4fnapZCF4TW6uqeRe72HzZ3N9UR1v6L49G43CSu78UyX0k4IPtSTwwSoFlItKciJbTvZPilT0cDyF+rbVA9lzu3IxevtHdU4ASKfAo7+YUHDhcUE0j8YohIw0c89bCefn5ZeT9d8nd3iZnAIc0Nh/apfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wIAnczFkxUvcdgGB2qZTtqomp2OnmE37nOteaSXjqzQ=; b=OgTpYseozli+ZFkFz5g9ZBn28L3aH2x1fDtWYsIkJ1YlJHICyqR5qGUpnVKIDhPWh7MBPxhTd+zdpVD3JYOahmZCzfJzOlj9Db4UxBFLP2zWsrLeQ6FdMCNVAPo5x717bITD6zRAPPtmX0Sf96N1EYYmqt8iWcg55HGVjfYGW3JgpTlrhlmdfuhENXcesKJMPZNg4sdZ5i7CiXGcLotH2ZHHcyX35Dm85p96jUBs4MuRwHFvfrRZdIIqfN47P6luBMN4FveA7pVPLzfl2U6WQa5CLCV763a920nABag7KYFhEzdANKee6IUNuSCeyxm3ppFDEAGCDFtgibev91rzQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wIAnczFkxUvcdgGB2qZTtqomp2OnmE37nOteaSXjqzQ=; b=e15KQ2wtoO8XGzJtmQt3II3+6ZvzV3A58K5erNYcTiXOVPEuM4tUqOmmDACqF5d4pxUghtzaPv5KskWbWh13qvhGRQOekcPgg6UtILfNjZLyisG13BA6QA4uDUBgwArbUVMXzp4gCgrtBrJjy5LLq58wrDOmIf5ugV0J86v24iQ= From: Jane Malalane To: Roger Pau Monne CC: Xen-devel , Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Topic: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Index: AQHYZUnyc7oF7QLoj0+gbrrX4WFU9K0c9NIAgAR/4IA= Date: Mon, 16 May 2022 12:22:44 +0000 Message-ID: References: <20220511151423.20241-1-jane.malalane@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bee6229f-a7c9-4c59-b8a1-08da3736c7f4 x-ms-traffictypediagnostic: CY4PR03MB2533:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6iigZyJ54ntNrWt/0d+w1ZDhZFlrdzQlEOQiVpKdKixzZlEDsBcEHtZ9aj8aNIKEv+M3gaqP8xVzIqBMwfqosqqz9f5ahiUoVn1tZMN+d6XI7lM+0TN4b8lXbW4Fa91IP7YaH8t0Te686NQAdEQYozPGs6d4WxxuDuzLrRKSzoJULbtqRH6njV20QPL0EySSRM49pnutIcVmBfg7+E2DJXCy3jEazCkFXWRCoF/a25+OOy10GHxgmeTgw/o08wfri9r1LmuwVEMcfz0MrK3g2EPu5fl+icb4KgqGFhHrYO0RpiAmaha3zMGaIZOPTVur5TJsggx0ia0jb8E426FUzxkMqwkc1FlFLKCUL65GP3Sv3EHarbCQQrdPUcOg2E5Pbuf1Z3qGoyR2XBHZzqhR8kN9Br6ZV8p8xyCW+GZAnu21KS8UAivtioIEv17qDvdADEwWognwLm3xCLYTriY7xfMTYaCdh44E2Oh8VxAo8g1DAhCdX/cD/dGV/6Kb7iGek0bAxmuScFwVpTPsx7imuszHGJbN+LZfO+K837vP8gtwTQuR1vIveCfqFmFJNbTSDBKCFadNcxo4DAQDAQqHNpfGz1Jb66HKzCZOe0377jFaZmGs2hdBKx0Vc/+4pyXqOpXFVrLy+QpS77kQIFYcYnaF3M4yvSuFo0KaUaCfqJdczXUvhh5t/+ua/zoa72MPvFJ6dcpkghQwwGULYhIWQVbtDjvlO0PtQCEsQbRlSkmXj2R2HALbYM3IHV/1wXPt x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(91956017)(2616005)(316002)(82960400001)(6636002)(55236004)(2906002)(38100700002)(31686004)(66946007)(76116006)(8676002)(4326008)(6862004)(66556008)(66446008)(37006003)(64756008)(6486002)(83380400001)(186003)(54906003)(122000001)(66476007)(6512007)(86362001)(5660300002)(38070700005)(8936002)(31696002)(26005)(508600001)(36756003)(6506007)(53546011)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?amdOWEhyYmlLbDdRV0xTeFBzblBhdDVmblU1RVdYWU5JVkRPZVBUY3VqNGhJ?= =?utf-8?B?Umc5Ui9aVWNIeTFpMEV1TDhVZVZ2RVVnV0taWlBCeEhKTlFyS3lFL2EyTjVu?= =?utf-8?B?MkhkeGlON1g5aTNhVFBXRXhGdlNuTVRHaEw0TjNaK01TRk5ZRmlMZUhTTzN6?= =?utf-8?B?cDZVdFNYeDNBT0E3Rkt4QlJjYkxHZ2E2dzQvaUdVM0RrLzRnS0RVNGxEcytX?= =?utf-8?B?TFNzZXZUZlZVZWcwQnZlYmhXalltZ1UwWHBhMURoeDd4eUZrV2l4bGhvNWxG?= =?utf-8?B?WTdTR3BlNzdsUVBQdmkxalE3REU3ZkRheG0xNENDZU5ZNGQrMTBacGNieXhI?= =?utf-8?B?STM3K1VyWEVadG4rMUc4Unl3MzNGcXJWUFdDbVd0ZlFKdGg1aWZpa1VZUXg2?= =?utf-8?B?MFJWR2RJemE3TnN4WC9tMU1iR29XK0VpRm9WcWJrdFMzMU1Vb0crNTYxRE5L?= =?utf-8?B?MFBLYU5LV2NzR0ZWbk5BV0Q3OWQ0ZVlmVmNRaE1rVzlhUVRoMU1lbEF6RGpT?= =?utf-8?B?aGhYWnJFYWNLLytJUlIxUjB4TjNWRThKNEJaSG55LzVQSUsvaEJmb2RHZGU2?= =?utf-8?B?djl0elFPTWpNRnBtZU0yQ3U4QlZ0KzhnVlVZNnpkaXorN2RFVkI3OWJBemRS?= =?utf-8?B?OXA0YVJxaUdxZlBYUmxiUHJhR1E3ZmhRYXIzNHhEakVtRFYxdnNEVmZzSkhV?= =?utf-8?B?OG9IZ0J4d3VVckMzSlJibzNVOUxCWGkreGQvOUZJdFVId3VUWWx6cjFoN2tU?= =?utf-8?B?YVJxNSs3bEhOcUZwNFo0SXpsU0g2cmNyeldzYUVXUjMvWkI1RHZHcmJFeGxw?= =?utf-8?B?UHhWYlZmVHFoM29heXJwVU9PSGE5K1JvRThiVDM5cTkyVmFpeHNxTnRhbU5R?= =?utf-8?B?Vmk2amRXdXFzSkNDaGRkbnp6QlJiQkdYcFhqTVByTDdvWlZNMzFNaXZBNkJa?= =?utf-8?B?ZlFKTWpCN1Y0WkE2K09RM2hEc1dFdUN0N3BKZ3pEVEhRSzNKSU55ZGlRdW1s?= =?utf-8?B?VXFwaklWd252Nm9SWXJNVStyWHpmT3dBK1g0d3RtamNaZlZCRklaRGUxTUM1?= =?utf-8?B?RXFiMkFMYXdhKy9ucnU2TjNRUEg5YnpYU0RWekc1WitxeHUyZTBGNkIreStE?= =?utf-8?B?RzZvL1pkVmg4dVkwZFhPdUhCOS9PSFBDY015MWxBTlZiSXZ2MmNoQXhZVUF4?= =?utf-8?B?MVUrMGhTSGpQbUtPSVpzVi9NK2JtMlFFWnpQN0FoU2JoQmxiOWFqUjFDbENU?= =?utf-8?B?aWUrVGlaWFhWakdCS045R2VYTytJM2tYa1JIZ1NkZWlqNGNnRTR0akErNmdu?= =?utf-8?B?czNnazVwN2tndkUxenVCakNjb0hPOXZVdmhUdzdiSUJuNHIzTXBYbEF3dFEy?= =?utf-8?B?NCtjdkNjaEpWa3FObjFEMDAwRXNhZkdmOEFwWWdGRVJoMXFDTXVodEh2KzRE?= =?utf-8?B?TjVxMnN6VitIZm5hWHVzUEp0b0tjZ1V1N2J1MXJMNkN2RXpPQ05OVUpGYlZS?= =?utf-8?B?b1EvOXd2cVJ2RzExUDYwZUVqbSs4cmZhMENaTjZrNXk4WWhxNWNQUldzNysw?= =?utf-8?B?dVIzRFJ6TVFKN1l4MFp3KytrRUpiK0c5bklpaVIrY3NDbC8vZ241Umlmdity?= =?utf-8?B?by9DdFN1K0x0OE9ZMDJaSVAyVWI5NE1pcU4zSUY4N3UyR2o2ck8rbkNKQXlV?= =?utf-8?B?eTBiTmdYVDU5YmdIQWIzTWhYazJiN3BSOEhUL0pNd2NuYmQyMkg3cmd5akxv?= =?utf-8?B?WEZMcVB6ZnNnc1VjbHM5UWorRnJQTmRHVGJaclcycFlhV2JENWVHRWU3c3hu?= =?utf-8?B?ZEdLdkFGUWVvd3FUTVBMaFI0T3AvS0FXdWF4YmZUVGl4bjZmZ2xkNER6alhC?= =?utf-8?B?R0xMVE1EZTVjS3c4SjRGakZKc042b0F3dzlxbTgxa3RsYmozZW1xQmMrZzc5?= =?utf-8?B?N2VsWVB5SjJDZS8wZUxFRUlnWkZBbEtmNnEyYVlRY2Q4b0dINFZESUQxZ21P?= =?utf-8?B?OUg5YU9KMmw5OGNnZjRlTlNHM2F3ZXBQQ1NPYVY2ckxSQzcvVTQ2R1R2YWR2?= =?utf-8?B?VHJLekkzRzFwNFB3S1E0aDYyU3BqemZqVnpzZFdDUW1zc2Jna2xhdW9SaDVU?= =?utf-8?B?WFExbGYwajZETjRYRVNuanN4ZldUSEkwYWlTTVN1UjBScUpIZUZpTndFdEJ4?= =?utf-8?B?TUczM3I5dXZJVXppWjR4K2o2M3RtYnZtMmxLV0oyaTV4S0JrLzBsbnFLSElZ?= =?utf-8?B?Ujd4YkhqSUhqa3hiOGMwZkg5WWdvNzhWQnNFSkF1cTZSNDlYNG5zVG5RbGtE?= =?utf-8?B?eHVySG0waEZCSGFvK3dLNXkvMlRJbXRISWtHSFJKdWwyS1pSTGZkQi9lVVVs?= =?utf-8?Q?OMonyP9fdU6i9c68=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <4F21009156BAB24697E1FE35D642389B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bee6229f-a7c9-4c59-b8a1-08da3736c7f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 12:22:44.8655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yo62I7eL3pTWkfeS6/p5qY201+ASUYaHHHD2sGWmydBif9+y2LECMmLHnHtsHHDgsBfzhk3DmGJHdFRlgyf9dmw5SY7XEWuxGc7oAxgNfzk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2533 T24gMTMvMDUvMjAyMiAxNjozOSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gV2VkLCBN YXkgMTEsIDIwMjIgYXQgMDQ6MTQ6MjNQTSArMDEwMCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4+ IEhhdmUgaXNfaHZtX3B2X2V2dGNobl92Y3B1KCkgcmV0dXJuIHRydWUgZm9yIHZlY3RvciBjYWxs YmFja3MgZm9yDQo+PiBldnRjaG4gZGVsaXZlcnkgc2V0IHVwIG9uIGEgcGVyLXZDUFUgYmFzaXMg dmlhDQo+PiBIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IuDQo+Pg0KPj4gaXNfaHZtX3B2 X2V2dGNobl92Y3B1KCkgcmV0dXJuaW5nIHRydWUgaXMgYSBjb25kaXRpb24gZm9yIHNldHRpbmcg dXANCj4+IHBoeXNpY2FsIElSUSB0byBldmVudCBjaGFubmVsIG1hcHBpbmdzLg0KPiANCj4gSSB3 b3VsZCBhZGQgc29tZXRoaW5nIGxpa2U6DQo+IA0KPiBUaGUgbmFtaW5nIG9mIHRoZSBDUFVJRCBi aXQgaXMgYSBiaXQgZ2VuZXJpYyBhYm91dCB1cGNhbGwgc3VwcG9ydA0KPiBiZWluZyBhdmFpbGFi bGUuICBUaGF0J3MgZG9uZSBzbyB0aGF0IHRoZSBkZWZpbmUgbmFtZSBkb2Vzbid0IGdldA0KPiBv dmVybHkgbG9uZyBsaWtlIFhFTl9IVk1fQ1BVSURfVVBDQUxMX1ZFQ1RPUl9TVVBQT1JUU19QSVJR IG9yIHNvbWUNCj4gc3VjaC4NCj4gDQo+IEd1ZXN0cyB0aGF0IGRvbid0IGNhcmUgYWJvdXQgcGh5 c2ljYWwgaW50ZXJydXB0cyByb3V0ZWQgb3ZlciBldmVudA0KPiBjaGFubmVscyBjYW4ganVzdCB0 ZXN0IGZvciB0aGUgYXZhaWxhYmlsaXR5IG9mIHRoZSBoeXBlcmNhbGwgZGlyZWN0bHkNCj4gKEhW TU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3Rvcikgd2l0aG91dCBjaGVja2luZyB0aGUgQ1BVSUQg Yml0Lg0KPiANCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFs YW5lQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IENDOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+DQo+PiBDQzogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4N Cj4+IENDOiAiUm9nZXIgUGF1IE1vbm7DqSIgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4gQ0M6 IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+PiAtLS0NCj4+ICAgeGVuL2FyY2gveDg2L2luY2x1ZGUv YXNtL2RvbWFpbi5oICAgfCA4ICsrKysrKystDQo+PiAgIHhlbi9hcmNoL3g4Ni90cmFwcy5jICAg ICAgICAgICAgICAgIHwgMyArKysNCj4+ICAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2Nw dWlkLmggfCAyICsrDQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20v ZG9tYWluLmggYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vZG9tYWluLmgNCj4+IGluZGV4IDM1 ODk4ZDcyNWYuLmYwNDRlMGE0OTIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVk ZS9hc20vZG9tYWluLmgNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9kb21haW4u aA0KPj4gQEAgLTE0LDggKzE0LDE0IEBADQo+PiAgIA0KPj4gICAjZGVmaW5lIGhhc18zMmJpdF9z aGluZm8oZCkgICAgKChkKS0+YXJjaC5oYXNfMzJiaXRfc2hpbmZvKQ0KPj4gICANCj4+ICsvKg0K Pj4gKyAqIFNldCB0byB0cnVlIGlmIGVpdGhlciB0aGUgZ2xvYmFsIHZlY3Rvci10eXBlIGNhbGxi YWNrIG9yIHBlci12Q1BVDQo+PiArICogTEFQSUMgdmVjdG9ycyBhcmUgdXNlZC4gQXNzdW1lIGFs bCB2Q1BVcyB3aWxsIHVzZQ0KPiANCj4gSSB0aGluayB5b3Ugc2hvdWxkIHJlbW92ZSBMQVBJQyBo ZXJlLiAgVGhlcmUncyBubyBzdWNoIHRoaW5nIGFzICdMQVBJQw0KPiB2ZWN0b3JzJywgaXQncyBq dXN0IHRoYXQgdGhlIG9sZCBtZWNoYW5pc20gd2FzIGJ5cGFzc2luZyB0aGUgbGFwaWMNCj4gRU9J Lg0KPiANCj4+ICsgKiBIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IgYXMgbG9uZyBhcyB0 aGUgaW5pdGlhbCB2Q1BVIGRvZXMuDQo+PiArICovDQo+PiAgICNkZWZpbmUgaXNfaHZtX3B2X2V2 dGNobl9kb21haW4oZCkgKGlzX2h2bV9kb21haW4oZCkgJiYgXA0KPj4gLSAgICAgICAgKGQpLT5h cmNoLmh2bS5pcnEtPmNhbGxiYWNrX3ZpYV90eXBlID09IEhWTUlSUV9jYWxsYmFja192ZWN0b3Ip DQo+PiArICAgICAgICAoKGQpLT5hcmNoLmh2bS5pcnEtPmNhbGxiYWNrX3ZpYV90eXBlID09IEhW TUlSUV9jYWxsYmFja192ZWN0b3IgfHwgXA0KPj4gKyAgICAgICAgIChkKS0+dmNwdVswXS0+YXJj aC5odm0uZXZ0Y2huX3VwY2FsbF92ZWN0b3IpKQ0KPj4gICAjZGVmaW5lIGlzX2h2bV9wdl9ldnRj aG5fdmNwdSh2KSAoaXNfaHZtX3B2X2V2dGNobl9kb21haW4odi0+ZG9tYWluKSkNCj4+ICAgI2Rl ZmluZSBpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSAoKHZvaWQpKGQpLCAwKQ0KPj4gICANCj4+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvdHJhcHMuYyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5j DQo+PiBpbmRleCAyNWJmZmU0N2Q3Li4yYzUxZmFhYjJjIDEwMDY0NA0KPj4gLS0tIGEveGVuL2Fy Y2gveDg2L3RyYXBzLmMNCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jDQo+PiBAQCAtMTE1 Miw2ICsxMTUyLDkgQEAgdm9pZCBjcHVpZF9oeXBlcnZpc29yX2xlYXZlcyhjb25zdCBzdHJ1Y3Qg dmNwdSAqdiwgdWludDMyX3QgbGVhZiwNCj4+ICAgICAgICAgICByZXMtPmEgfD0gWEVOX0hWTV9D UFVJRF9ET01JRF9QUkVTRU5UOw0KPj4gICAgICAgICAgIHJlcy0+YyA9IGQtPmRvbWFpbl9pZDsN Cj4+ICAgDQo+PiArICAgICAgICAvKiBQZXItdkNQVSBldmVudCBjaGFubmVsIHVwY2FsbHMgYXJl IGltcGxlbWVudGVkLiAqLw0KPiANCj4gLi4uIGFyZSBpbXBsZW1lbnRlZCBhbmQgd29yayBjb3Jy ZWN0bHkgd2l0aCBQSVJRcyByb3V0ZWQgb3ZlciBldmVudA0KPiBjaGFubmVscy4NCj4gDQo+PiAr ICAgICAgICByZXMtPmEgfD0gWEVOX0hWTV9DUFVJRF9VUENBTExfVkVDVE9SOw0KPj4gKw0KPj4g ICAgICAgICAgIGJyZWFrOw0KPj4gICANCj4+ICAgICAgIGNhc2UgNTogLyogUFYtc3BlY2lmaWMg cGFyYW1ldGVycyAqLw0KPj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4 Ni9jcHVpZC5oIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWlkLmgNCj4+IGluZGV4 IGYyYjJiMzYzMmMuLjE3NjBlMmM0MDUgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJs aWMvYXJjaC14ODYvY3B1aWQuaA0KPj4gKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2 L2NwdWlkLmgNCj4+IEBAIC0xMDksNiArMTA5LDggQEANCj4+ICAgICogZmllbGQgZnJvbSA4IHRv IDE1IGJpdHMsIGFsbG93aW5nIHRvIHRhcmdldCBBUElDIElEcyB1cCAzMjc2OC4NCj4+ICAgICov DQo+PiAgICNkZWZpbmUgWEVOX0hWTV9DUFVJRF9FWFRfREVTVF9JRCAgICAgICgxdSA8PCA1KQ0K Pj4gKy8qIFBlci12Q1BVIGV2ZW50IGNoYW5uZWwgdXBjYWxscy4gKi8NCj4gDQo+IEkgd291bGQg bWF5YmUgZXhwYW5kIHRoZSBtZXNzYWdlIHRvOg0KPiANCj4gIlBlci12Q1BVIGV2ZW50IGNoYW5u ZWwgdXBjYWxscyB3b3JrIGNvcnJlY3RseSB3aXRoIHBoeXNpY2FsIElSUXMgYm91bmQNCj4gdG8g ZXZlbnQgY2hhbm5lbHMuIg0KDQpUaGFua3MuIFllcywgaWYgb3RoZXJzIGFncmVlIHRoYXQgdGhl IENQVUlEIGJpdCBjYW4gc3RpbGwgdGFrZSB0aGlzIG5hbWUgDQppZiBiZXR0ZXIgZXhwbGFpbmVk LCBkZXNwaXRlIGl0IGJlaW5nLCBhcyB5b3Ugc2F5LCBxdWl0ZSBnZW5lcmljLCBJIHdpbGwgDQph ZGQgdGhlc2UgY29tbWVudHMgaW4gYSB2Mi4NCg0KVGhhbmtzLA0KDQpKYW5lLg== From xen-devel-bounces@lists.xenproject.org Mon May 16 12:29:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 12:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329832.553094 (Exim 4.92) (envelope-from ) id 1nqZrI-0004hw-85; Mon, 16 May 2022 12:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329832.553094; Mon, 16 May 2022 12:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrI-0004hp-51; Mon, 16 May 2022 12:29:56 +0000 Received: by outflank-mailman (input) for mailman id 329832; Mon, 16 May 2022 12:29:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrG-0004ha-J8; Mon, 16 May 2022 12:29:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrG-0001OD-F0; Mon, 16 May 2022 12:29:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrG-0003TP-0I; Mon, 16 May 2022 12:29:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqZrF-0003YZ-W7; Mon, 16 May 2022 12:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ho6SH40ZNLRrkksW7rta1iDIp/0afoELIFy5ROR9jyg=; b=BNYk6KSBZHWlPz5+rmiT+izcZl sz6jceU/xLBHbzaWneZ617eRoIc4gVAknz5zDiMQvXx/YiCP7x+wioWv6g0PHMjoygEJrOtUVJcPD t6sY3EoSBi2Mxp2gUsQKedSs/UPvWQ0gU634EYyQzMiTCd56UPBiUv3HnWBYHOycA2vc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170468: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-xsm:xen-install:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c X-Osstest-Versions-That: qemuu=48de9b0916ef60d5a6bd6ca9288832deff8ee1ee From: osstest service owner Date: Mon, 16 May 2022 12:29:53 +0000 flight 170468 qemu-mainline real [real] flight 170475 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170468/ http://logs.test-lab.xenproject.org/osstest/logs/170475/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 170412 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 170475-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170412 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170412 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170412 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170412 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170412 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170412 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170412 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170412 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c baseline version: qemuu 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee Last test of basis 170412 2022-05-14 06:55:42 Z 2 days Testing same since 170468 2022-05-16 03:38:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jason A. Donenfeld Richard Henderson Stafford Horne jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c Merge: 48de9b0916 e8f0ab0cd6 Author: Richard Henderson Date: Sun May 15 16:56:27 2022 -0700 Merge tag 'or1k-pull-request-20220515' of https://github.com/stffrdhrn/qemu into staging OpenRISC Fixes for 7.0 - A few or1ksim fixes and enhancements - A fix for OpenRISC tcg backend around delay slot handling # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEE2cRzVK74bBA6Je/xw7McLV5mJ+QFAmKAWKsACgkQw7McLV5m # J+SoFg/8Dlrc2BqjjXw9gpaQ18+3BRI6dMVPqHA22VJks88gykH7UWLUbrCxtKnS # SBcIcpzu17nKDdfwYWndqCr0UBM/zM3JzFrTv4QEhTEg6Np7lSM2KVNEhjBPVGoW # A7QOjPFrwItWOfAx6hrcczpj+L50iKuWeMW0XnEfqSeDYisxZcSp2yMoe5h3y7bF # tlpo+ha/ir/fd2kMlFrQlPWYiWkWM05RLJJOlXhdRMF7hrW5qlHqEB/SVykUTf7V # 6fqOFvY6r3vE5OFm0Scgf/k2AJIxwV8qXkBJ5/egv+ZqUidZBQ9nXtOw++vF2AWp # eKoU2/c2XIxiF1Xdpgdi6a/CxlLqrr9jraQROB3GpaL9zGQvd//wUCg0F+QLicLv # avq4lvNmnat89aXj1DQ+DWpLy0zaZFGmxsPR+KeBJ2wkuEJ3Vd4+uiuAyXnm9M8D # wEE8mgFQYsTL1WlgHF4uNTDIx8OLS+4gYlBE3tffRksxyLLwzKHHgAfLdNZvhfx8 # QZBuPy+yyO8zjr3RUVUArBs/ukZHP1QwDE6uxmPKV34tvVEbFVeSFY3a1LmYV3w5 # mZNALNqf+h5Dq5Qo7f7cGNMrzhL53GTWPNX0MK5+SBDZF3/fpPZyvCr4Zd69Z5tD # +YClfWBv8HPjdUf+IFHqyE8rURw/sgNvgB76GpalwcUYXRr7zTM= # =tmP4 # -----END PGP SIGNATURE----- # gpg: Signature made Sat 14 May 2022 06:34:35 PM PDT # gpg: using RSA key D9C47354AEF86C103A25EFF1C3B31C2D5E6627E4 # gpg: Good signature from "Stafford Horne " [unknown] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: D9C4 7354 AEF8 6C10 3A25 EFF1 C3B3 1C2D 5E66 27E4 * tag 'or1k-pull-request-20220515' of https://github.com/stffrdhrn/qemu: target/openrisc: Do not reset delay slot flag on early tb exit hw/openrisc: use right OMPIC size variable hw/openrisc: support 4 serial ports in or1ksim hw/openrisc: page-align FDT address Signed-off-by: Richard Henderson commit e8f0ab0cd674241cbab7231ce05ac1bfa0b4f5ed Author: Stafford Horne Date: Wed May 11 20:47:50 2022 +0900 target/openrisc: Do not reset delay slot flag on early tb exit This was found when running linux crypto algorithm selftests used by wireguard. We found that randomly the tests would fail. We found through investigation that a combination of a tick timer interrupt, raised when executing a delay slot instruction at a page boundary caused the issue. This was caused when handling the TB_EXIT_REQUESTED case in cpu_tb_exec. On OpenRISC, which doesn't implement synchronize_from_tb, set_pc was being used as a fallback. The OpenRISC set_pc implementation clears dflag, which caused the exception handling logic to not account for the delay slot. This was the bug, because it meant when execution resumed after the interrupt was handling it resumed in the wrong place. Fix this by implementing synchronize_from_tb which simply updates pc, and not clear the delay slot flag. Reported-by: Jason A. Donenfeld Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne commit a92162f4f1dfc2daf1bc8f2bbc3cad3c9d1ea729 Author: Jason A. Donenfeld Date: Tue May 3 11:45:33 2022 +0200 hw/openrisc: use right OMPIC size variable This appears to be a copy and paste error. The UART size was used instead of the much smaller OMPIC size. But actually that smaller OMPIC size is wrong too and doesn't allow the IPI to work in Linux. So set it to the old value. Signed-off-by: Jason A. Donenfeld [smh:Updated OR1KSIM_OMPIC size to use OR1KSIM_CPUS_MAX] Signed-off-by: Stafford Horne commit 777784bda46847fc0587d711c3aacff8fff3c3f9 Author: Jason A. Donenfeld Date: Tue May 3 01:20:56 2022 +0200 hw/openrisc: support 4 serial ports in or1ksim The 8250 serial controller supports 4 serial ports, so wire them all up, so that we can have more than one basic I/O channel. Cc: Stafford Horne Signed-off-by: Jason A. Donenfeld [smh:Fixup indentation and lines over 80 chars] Signed-off-by: Stafford Horne commit 0a923be2f6427fdf2a5769b4b8a08e26c758dfab Author: Jason A. Donenfeld Date: Thu Apr 28 12:35:16 2022 +0200 hw/openrisc: page-align FDT address The QEMU-provided FDT was only being recognized by the kernel when it was used in conjunction with -initrd. Without it, the magic bytes wouldn't be there and the kernel couldn't load it. This patch fixes the issue by page aligning the provided FDT. Cc: Stafford Horne Cc: Peter Maydell Signed-off-by: Jason A. Donenfeld Signed-off-by: Stafford Horne From xen-devel-bounces@lists.xenproject.org Mon May 16 12:30:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 12:30:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329839.553106 (Exim 4.92) (envelope-from ) id 1nqZre-0005st-HP; Mon, 16 May 2022 12:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329839.553106; Mon, 16 May 2022 12:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZre-0005sm-ER; Mon, 16 May 2022 12:30:18 +0000 Received: by outflank-mailman (input) for mailman id 329839; Mon, 16 May 2022 12:30:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrc-0005rT-E8; Mon, 16 May 2022 12:30:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrc-0001PA-DI; Mon, 16 May 2022 12:30:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqZrc-0003U4-7S; Mon, 16 May 2022 12:30:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqZrc-0003aZ-72; Mon, 16 May 2022 12:30:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sKwdrvzMfq5uD61xOhjKyaiHFTv8+t3HrWeVVpJAgwQ=; b=xBiEgB1WogfSqNQOfCebDsRWup hQqlkLQRcWn9fOt9kT8a/ZwE2FsPSxs3gG9NT+anuVFR2mOE5ykJEaOJ26A1Fj5gNwnkXJG/HcD7e w4Kh3Mrt+pFgyxVctzxrxvizCNXBQkmFzFeCDjHzwMKTrL0NrQSCxC69A6Q8MH0tVnmA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170477: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 12:30:16 +0000 flight 170477 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170477/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1042 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 61 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 13:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 13:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329854.553120 (Exim 4.92) (envelope-from ) id 1nqaWl-0002PB-Um; Mon, 16 May 2022 13:12:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329854.553120; Mon, 16 May 2022 13:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqaWl-0002P4-RS; Mon, 16 May 2022 13:12:47 +0000 Received: by outflank-mailman (input) for mailman id 329854; Mon, 16 May 2022 13:12:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqaWk-0002Oy-8S for xen-devel@lists.xenproject.org; Mon, 16 May 2022 13:12:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd74a941-d519-11ec-837e-e5687231ffcc; Mon, 16 May 2022 15:12:42 +0200 (CEST) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 09:12:34 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by SJ0PR03MB6566.namprd03.prod.outlook.com (2603:10b6:a03:38a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Mon, 16 May 2022 13:12:28 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 13:12:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd74a941-d519-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652706762; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=LwCAE6ZtINNuQJhbxTZl9B9CXEjmmWn/dfADWQjpWtw=; b=eqOwSLh1g9bHi8nqjqVMaicxYKv6St56Pp0WkQ3h8a754D7AMmjOPxnQ Imv4Q0hl+G9mqig30H2xyoXhTSuZRkw7d0SkZEIbgXiA5qgEPaRMBb9BK GowQzMN+UDwiaIVMJlL7n/v+yy8DSvfFWXEz7pb0kfq/q6dBQ9qLAcQWP M=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 71261993 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qlvQsK3cqisx3fqNCPbD5Xpwkn2cJEfYwER7XKvMYbSIYQITYwd3j TtIBzjCf73ffDO2KOnCW/228UgPucSBndJmSQU6qHhgFCMV+JWUXY3DdEz5NC2fcZObFEs+t 5lONdTKJ5s4QyCA9k3ybeOwpnV3j/mGSuKtYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm PuurcOBaAD0h2B9aDhMtvPepkk35ayi6GJB4AZgbvkXsQ6CmyEZAqxEKPDqJRMUYGX18s1W5 Qrn5Ovklo8M1051UrtJqp6iLgtSBOS60TGm0hK6YYD76vR5jnF0g/9T2MY0Mx8N0W3Uxo0pk r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji 8QlhTVHXDvwRAVxHlotNZ8dsuD431rQKGNTkQfAzUY3yzC7IA1Z9pHIaYCQVvnUAMJfkwCfu 37M+Hn/DlcCLtuDxDGZ83WqwOjSgSf8X4FUH7q9nhJoqATLmipPV1tLBB3i/qTRZk2WArqzL 2Q79y00oqV02FGtStDldxa5vGSFrlgXXN84/+gSt1jXlPOFsl3x6m4sdR0Cadd3m8gMGTEI3 F6x2P35WWNEv+jAIZ6a3vLOxd+oAgA3AnUFfjQsVhYe7p/op4RbphDFQ8tnEaW1psboAjy2y DePxAAUiq8Pl8cN2+Oe9ErenjO3jpHTS0g+4QC/dmC46gJ0Yqa1aoru7kLUhd5bN5qQRFSFu HkCmuCd4foIAJXLkzaCKM0dEbfs6/ubPTn0hV90A4Jn5zmr42Skf41b/Hd5PkgBDyofUTrgY UuWtQYP4pZWZSGudfUuPN/3DNk2x6/9E9ijTurTctdFfpl2ckmA4T1qYkmTmWvqlSDAjJ0CB HtSSu70ZV5yNEit5GPeqzs1uVPz+h0D+A== IronPort-HdrOrdr: A9a23:8lDvY6iswfb1rE7TmvQJSXvz+3BQX3Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySaVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNyk3sS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Ln1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoDOCXMsLlUFtzfsHfrWG1TYczGgNnzmpDq1L8eqq iOn/7nBbU115qeRBDynfKn4Xic7N9n0Q6f9bbfuwqtnSWxfkNFN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3amBa/n7/nDE3kbKvNRj+UC3a7FuIYO5bLZvjn99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8PC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8e166MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBkPkoLVeLmzNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7jmZ8 o= X-IronPort-AV: E=Sophos;i="5.91,229,1647316800"; d="asc'?scan'208";a="71261993" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bc1NYI+VQNdr5rF8KtGIajotkrn9Jht9UF2xUKB0WCI91EKurTFRqHmUaBwqFZG11j84jBH/R79VlniuIpWoohKggPb46GjMEwEWUNbK86qCo1vTady/mAvW0f0RxVlo2B8sT+rsLtFAlj/UgIoEalfEu6243ITAgte3DSEKowSkXxSEh9sT3IRqQUBVuOEFd0+mVetF5ZKttMeqlTHrzV/pYi3m+zX7uD4QHAPxAljTaCsy5qpw/qqd8/ABh7Qz3S18Hog1K0JiveI5eeTef3FZY+PK0Gb33GqC6dpKBpQmZpq8058sYQAzksNvmxKnBLKEwrCsEuQJ3erGN399rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mKXxXWjlAnBX6O9S2wmMAnhdNCGKvYLYpa8g8VZ/jIg=; b=fC9FO9aXcLJgmYEkIlr2eXdu70rggOmezAJdB1uo1H8vwzBeEWZUK3yzPVuGJfu1A24h5plZBa0mJQg9wbm8tZZSSJVirMVXEND/rEM8rrZuQIgGGeY3QaNfpTXCArWe1U3eURF5zhbFsRnKEZCNBKpLfH4cJ5tdS7210DH95xnmEaSJIu5UpXTOllKUAhKYWOPvDe4ZAbZYTPA9JTgwFObd/rPviCSzHq4Gx4aKRMrGMHTdXKVq0QoLjTqxUWXAOw6RSfCLZkJpjHSJKILkjOhfzITl0l2KJM25980SgNfPeNxndSQDxVxn0YTZ/mmZAZJKnh+14RaaMibuYO4LEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mKXxXWjlAnBX6O9S2wmMAnhdNCGKvYLYpa8g8VZ/jIg=; b=JWt3ZHSZerYHeBcWilTAucVpdFc7ZzOG9+NmGC6k5swzuMb+WLPk+lXV5ujYI7BJg+jt95RV5MSU7E7nY0r0HETLxYcHI8Z38fV5uCzHG0t4iEilXqK/RU0CSvkDnnd3KWnBgzhlh1iV57rfd+Sd+Qtwb8fvNkk0U5f3S8dXKxk= From: George Dunlap To: Juergen Gross CC: Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini , xen-devel , Roger Pau Monne Subject: Re: Process for cherry-picking patches from other projects Thread-Topic: Process for cherry-picking patches from other projects Thread-Index: AQHYZtZ1suK3TAKIFU2tuY9R7u+Tcq0c5HqAgASbAoA= Date: Mon, 16 May 2022 13:12:28 +0000 Message-ID: References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> In-Reply-To: <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb368670-05a5-4b8d-b6c8-08da373dba6c x-ms-traffictypediagnostic: SJ0PR03MB6566:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FdLaTVTZqBgIHqa1coxqEKkWX6dgTgrqciPurnOkB+agoipz5Pz8ML4TesXoDwOdRd1rN2EOINjq1s3i+uc/ypXDIHlBX+GDvUSZt8yVAf+l3HE21GG2n+YuDwEzi4ix9GBpZ20ddeFuhokXZ3Gf3vuoJj0puz5ccybQ6sav6rvxFAHeGLlysicbBhfOl2LunAKdptRYUJk1N2delcLPIH4YWuSPCS6Fs/4s3zY0So9rFmCEG+x3BOtZt4I6hnYPfOYXQVQiiIdKvaSvlKicsT4zcR8SsQT36YVjbs/CNOlSzQ2kLKLVF1aIkVhL8SaUxPys69KgdgYwdqgLq7LxsdAAEcoPPsRk5LER2bcoNxfmN1oqcuG0qMnaYXST2jKOtxKR1xD7cR2RUTallJAC4rW3sfyaSCFyKCvDdXJH3KWZIDzxjLCRj8nmB54ef7zkj3IoZm5rpMCABwQR0HVN0vPskmqnsnW1X/emmtOl4gPP1U8zLWGstW7bltbpbsvrBpxNV9tNPVGX4uFhjhN+2fZk/4vS9cQRyAv8WMaeO3a77h7vObR1Mr3tw+ZMfbx2pVuUjhP+38us7YL8So4HnTvhY2iLnDzfIfAqZjGPkBsgl2cIf1EPDRW8eCgh/K9Eug6KsSdlXDsyRN9qZvNJOUKavfuzcWCL+VaMVVAoRNdCzo5+LNbYYltvdfVfqe/2E8nuMM96L+qt1SFgl8sqorbDgvlXYDduhNJRi8OXx8g2oXP/JdlK6N8xdVXkNsxhI5lr58/70Eizyb6wPQEM0SQ/jkMK6TAieNl4o7RKQ1kobqsAvzAWaKQ//4cDuT6TJoyadRe8IAq1CBJqz48tnw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(99936003)(122000001)(2906002)(38100700002)(38070700005)(54906003)(82960400001)(316002)(6916009)(6512007)(83380400001)(84970400001)(186003)(5660300002)(508600001)(86362001)(6486002)(71200400001)(8676002)(64756008)(66476007)(66556008)(66946007)(76116006)(4326008)(66446008)(91956017)(8936002)(6506007)(53546011)(26005)(36756003)(2616005)(107886003)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VWc1L3AxRlp6R3N0cVFmeUltMHBhNnIzU1NTNUVqQmU4Sk5IUi9OS2ZYRW55?= =?utf-8?B?TGZmWkdkdXZzbDdhekxrSFEwQ3ZCdDdRMDN5UHc0UkQzWUVEYnZrMTFOaTEz?= =?utf-8?B?WGhjQ0VQNElQR05ZNFoySHRaRWpYUFd0Ly9PRURVNmN3eFkxZktmR0t0MWhI?= =?utf-8?B?bW1iMFA0THFQcnFubzMyNDNPSmlDU3B6T2VLWFlabEx4VnBsOWowSm9XbGlu?= =?utf-8?B?WVo4bEtSSXlXck1ZcVJaK25GdmE5Z3doMi91UnV5ZTk3VFlYcG1COXdIakpS?= =?utf-8?B?UzcwNGhYVnVGVldHZHVURldkT2FWaU4wRm5JeFRUZUVaSWg2b1BVR1ptVkpI?= =?utf-8?B?ZVdRTDJaeTNtblhJSENHbE9MZSs4MW9oNG54dSs5NTdoaWw1clB0WHhyRlY5?= =?utf-8?B?TFViM241b1l3V0gzMlpLSXlBRlVkQ3pJT2xLZ1YrRjFyZ3VHYWNrdTJvVTFr?= =?utf-8?B?Q29RV1J2MTd0NThsZ1gyV0ZDclNwRml3d21ONHR2U3JZMUplN3FMS3N3KzRr?= =?utf-8?B?b1NuSVZyd29HcTAvbks1MCtyVGtBL3Y4Q1ErQlh5WHZWUjBPQ3B2aTU2Z0c4?= =?utf-8?B?VTMzeEZhbTRVSFVTRlVPVklJQVB2dXBDZE42VmhWdGNuUWNobW9jRFV3aVJo?= =?utf-8?B?SW1zZnhmc0Q3QWIzM3RCNk1EdDNzTUVaWTlNcDFHUlp6T25CNWFrRWZaaElP?= =?utf-8?B?M0drSDU2OXdmSHI2Y2JWMTB0MmFYYWF1azR5ZGJlNFpnVkRJeUdjYWYzSU5Z?= =?utf-8?B?VDhUclIrQWhBN0JKY2N6SlhrbUtZNGx6NnUvbjZ3VW01KzJjUTIxem0yQ0py?= =?utf-8?B?eDJCVlRvOWlEb09lN0VqMk5wM1o0UFR1cTlOb0NLTGZ6eVJacnZrbjdlZDRV?= =?utf-8?B?ZkoweWdBei9sRjUrL2JaSFlmVnhGU0szS3JYdVZDeFFFYzBoT0p4R09sTlpi?= =?utf-8?B?ZEZjWmUxSFcwTXZtT2RncGNLRmlEMm5iTXJDbDJ6N2xUUFFwQzMxc2Z1ODRK?= =?utf-8?B?SG5yZXBCak95UEpaOW01d2hGMk5yQmxtOHpYa0ZZdlhDdzV5SlZ1OWplUWdL?= =?utf-8?B?SDhqMHFsMlpXNXBMNEo1KzdIWlU3a2ZraWt2aTlYMk5jMkVMamJ3MnVMS1lQ?= =?utf-8?B?bFp1MWd6SXNJY0xQNFZ5VHZmRFJIemkzeXNpRUE1QzY0ZUFNL21IbE5BN2E0?= =?utf-8?B?UGRrcXBLTzZkRnV3S212SmFaaWNaaVRiQXhEdE0reDIvQnBDRFZIaC9WYlJW?= =?utf-8?B?ZXJHak8vNkRSdzJ3Q3diR0lFeWE3Sko4cmRPYWJBYmVVRHI2czV3aFBTVVRn?= =?utf-8?B?UUNDcXN2REFzZS9XSHErMm1YZkVIVGdKY09lNjJTMlJHM1NjbTRYTjN2cmsv?= =?utf-8?B?TEkrc2dhSE43V3orN0ltbExXVzhZN001aHpMVUo1ZGFQUTdYWEdQRzA5UXFQ?= =?utf-8?B?dFU2N0oyaUp1NXlmeFViZzczclFLL09oVEkzc3NyUVZLWmdSRUNxcCt0amtB?= =?utf-8?B?N0NyMktzVGVEbGpzNVFuZHFkek45elZCNEt5Yi8rWVRFNkIwRFFGWTg4VDM0?= =?utf-8?B?ZjQ0emIyZVNPNERGLzI0QWlISjhwY3FOQjdRcFpFSUE1R1NTekJmT2k2K2wr?= =?utf-8?B?T2dncjNoOUtXaHF5S3JqdWs0ZXFkdjlVZk9uV3RzdmZXdVVtMEdvSWZua1J0?= =?utf-8?B?R3RWYzZsZkJlL083d3o2d0g3djNjakRzbE1ONW01bU9YbGw2UjBVbHhxN3BF?= =?utf-8?B?cEh2OFA5Y0Y3dVNIbnpDZk9IazRCR213TitQbkV2U3VnYlZJbWNGMVQ1ZEMy?= =?utf-8?B?aGtqWWFpK3F3K3BDUFJ5Zyt2YkU0cEhUTGxrTVFJYTVGajVQVEg2NGxWQ2tE?= =?utf-8?B?eDZKa3hnZHpCYWhFTldtQUFPaXRsU2Zrc1oxL2k5ZVltNi9heUpxcUpuTTZm?= =?utf-8?B?aWNHMkdzbWgraGVIaFk2ZCsrL1poYmJHZE5oYldjbVc1Q0VEc3o1SlhaTHp2?= =?utf-8?B?MXhuYmlENXYxKzZWQWhTM1dVWExHK0xzK2tNdTBiUUhNMlE2YWx5MGlJbktG?= =?utf-8?B?WFdBcHF0THM2OXFsNmwwWE9HZU1memtlY3ZmSDkvOThQUXNRdlJHWWVWYUFp?= =?utf-8?B?N1VGaXk1dDRwVnUreXBscis1QUx5SU9UMjJCbGhwTDZFUUR0TGtteXNFRXlH?= =?utf-8?B?T283Q0N1UUxVdlBWZEo1Tkx6UU0ybWtzVkRXMExqckQ5eTd4cmtVdE9VL3c4?= =?utf-8?B?b0thYTdCcFNIRFh5bElOOWZPRlV3TWdGSllzdHpyR2xGa0xJT3B4MGtMT3l0?= =?utf-8?B?ODZsdTQzSG82NXIvdGVKMHJ3QWtBbng2bnllbklac21oZzdkRUZ6MUxwT040?= =?utf-8?Q?PImktMdx5Ob5jGes=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_02A39AAB-CDBB-4487-ABF6-0DFCE6BA5628"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb368670-05a5-4b8d-b6c8-08da373dba6c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 13:12:28.6253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C4KaD5IYqMgYXSuJIbsb2e6D082Kj7cSoi/RTPWNnp6ACRSFFYaZHBNdZ3hHD997rCdeKsjMu39zb+qN2c8zho9RfPVx3VERdUKhqCpEuyg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6566 --Apple-Mail=_02A39AAB-CDBB-4487-ABF6-0DFCE6BA5628 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 13, 2022, at 3:52 PM, Juergen Gross wrote: >=20 > On 13.05.22 16:33, George Dunlap wrote: >> Starting a new thread to make it clear that we=E2=80=99re discussing = a wider policy here. >> This question is aimed at Jan and Andy in particular, as I think = they=E2=80=99ve probably done the most of this; so I=E2=80=99m looking = to them to find out what our =E2=80=9Cstandard practice=E2=80=9D is. >> There have recently been some patches that Bertrand has submitted = which pull in code from Linux ("[PATCH 1/3] xen/arm: Sync sysregs and = cpuinfo with Linux 5.18-rc3=E2=80=9D), which has caused a discussion = between him, Julien, and Stefano about the proper way to do such = patches. >> The =E2=80=9COrigin:=E2=80=9D tag section of = xen.git/docs/process/sending-patches.pandoc suggests that there are some = standards, but doesn=E2=80=99t spell them out. >> The questions seem to be: >> 1) When doing this kind of update, is it permissible to send a single = patch which =E2=80=9Cbatches=E2=80=9D several upstream commits together, = or should each patch be backported individually? >> 2) If =E2=80=9Cbatches=E2=80=9D are permissible, when? When would = individual patches be preferred? >> 3) For =E2=80=9Cbatch updates=E2=80=9D, what tags are necessary? Do = we need to note the changesets of all the commits, and if so, do we need = multiple =E2=80=9COrigin=E2=80=9D tags? Do we need to include anything = from the original commits =E2=80=94 commit messages? Signed-off-by=E2=80=99= s? >> And a related question: >> 4) When importing an entire file from an upstream like Linux, what = tags do we need? >> My recollection is that we often to a =E2=80=9Caccumulated patch=E2=80=9D= to update, say, the Kconfig tooling; so it seems like the answer to = this is sometimes =E2=80=9Cyes=E2=80=9D. >> It seems to me that in a case where you=E2=80=99re importing a = handful of patches =E2=80=94 say 5-10 =E2=80=94 that importing them = one-by-one might be preferred; but in this case, since the submission = was already made as a batch, I=E2=80=99d accept having it as a batch. >> I think if I were writing this patch, I=E2=80=99d make a separate = =E2=80=9COrigin=E2=80=9D tag for each commit. >> I wouldn=E2=80=99t include the upstream commit messages or S-o-b=E2=80=99= s; I would write my own commit message summarizing why I=E2=80=99m = importing the commits, then have the =E2=80=98origin=E2=80=99 tags, then = my own S-o-b to indicate that I am attesting that it comes from an = open-source project (and for whatever copyright can be asserted on the = commit message and the patch as a collection). >> And for #4, I would do something similar: I would write my own commit = message describing what the file is for and why we=E2=80=99re importing = it; have the Origin tag point to the commit at the point I took the = file; and my own S-o-b. >=20 > IMO we should add another tag for that purpose, e.g.: >=20 > File-origin: [# ] >=20 > Specifying the repository the file(s) are coming from, the tag (e.g. a > tagged version, or the top git commit), and the path of the original > file(s) in that repository ( could either be a common directory > of multiple files, or a single file; multiple "File-origin:" tags = should > be possible). In case the file is being renamed locally, its new name > can be added as . >=20 > This variant should be used to add _new_ files to Xen. In case of > updating a file which has seem lots of commits since its last update = or > introduction, it might be easier to just use the "File-origin:" tag, > probably with a note below the "---" marker that listing more than > patches (x > 10?) or splitting into more than patches would be > just useless work (common sense should apply here, especially = regarding > the readability of the patch and the related review effort). You don=E2=80=99t mention what to do about SoB=E2=80=99s =E2=80=94 I = assume you agree with my assessment above, that a single SoB from the = submitter of the patch to Xen, asserting that they=E2=80=99re satisfied = that all of the code has been asserted by other people as having a = suitable license, is sufficient. In which case, barring a contradiction from Andy or Jan as to our = standard practice, I think that we don=E2=80=99t need to collect SoBs = from the original commits; a single SoB by Bertrand (or whomever) that = it all comes from Linux and that suitable SoBs can be tracked down = should it become necessary, will be sufficient. That should be enough to get the specific patch currently under = discussion from the ARM maintainers un-stuck. -George --Apple-Mail=_02A39AAB-CDBB-4487-ABF6-0DFCE6BA5628 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmKCTbcACgkQshXHp8eE G+313gf/Q6EK6H6hzG+C6gu1rBzgDa9NNdB39v9XoE6EWKkmSEB+WRoYvRb1jmHT xo1VxJgn9QoiyCawQx5DR+8ys9j1guzrjMjn36W7kvrgSEBFks7waM05NTIVfFO7 XXFagf6ka8w8pSzV96qFyNaGElwDb5YN8vchMK0wXlygpjZuflQm2GkNRhm78jc4 01uD/a6nmpUIDRSWnHWh6y/iJ/3sCbUQg/aRBYPugThy4aVzdQXcb9AWOLciR68P 1FbvXNSv4N1ul6syUmuoae62avBIgS5oZsnzNE1tIpvW6fm3DIf6R24aPR/IuyGH 8KWc2HLCGm0UJM9LqI1jxeWGT90NSQ== =fbtN -----END PGP SIGNATURE----- --Apple-Mail=_02A39AAB-CDBB-4487-ABF6-0DFCE6BA5628-- From xen-devel-bounces@lists.xenproject.org Mon May 16 13:53:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 13:53:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329863.553131 (Exim 4.92) (envelope-from ) id 1nqb9l-0006qP-5H; Mon, 16 May 2022 13:53:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329863.553131; Mon, 16 May 2022 13:53:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqb9l-0006qI-1X; Mon, 16 May 2022 13:53:05 +0000 Received: by outflank-mailman (input) for mailman id 329863; Mon, 16 May 2022 13:53:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqb9j-0006qC-KN for xen-devel@lists.xenproject.org; Mon, 16 May 2022 13:53:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80589b98-d51f-11ec-837e-e5687231ffcc; Mon, 16 May 2022 15:53:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 407151FB39; Mon, 16 May 2022 13:53:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E414713ADC; Mon, 16 May 2022 13:53:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +uINNjxXgmLKCQAAMHmgww (envelope-from ); Mon, 16 May 2022 13:53:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80589b98-d51f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652709181; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KtzkKyIkNI9xN3OvQlYgRNvsxQ9mM14sOJjAy6XKkhs=; b=GY9m6gl4lWZWSBUUm+bJQHj9elBNq0WkH4DQHYiaiJb229Ur/ogMxucufTVjwNMuABxSI8 tnCSoUbA2eB55Us7GUCKqVY6eBByNc4RhVEgcGiIGn+X4rm4WiSSmaCntB4jfzT2h2a/Lb aGaC0sD/jUS2g3ak/DWHx4Pu7XHkH8Q= Message-ID: <612415ce-bc24-52b1-e5a0-2860d36f2c01@suse.com> Date: Mon, 16 May 2022 15:53:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: Process for cherry-picking patches from other projects Content-Language: en-US To: George Dunlap Cc: Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini , xen-devel , Roger Pau Monne References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------NMHdFOqR37IMccSdMrsHS50L" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------NMHdFOqR37IMccSdMrsHS50L Content-Type: multipart/mixed; boundary="------------VUtASp0q2WImv0CMSrHqzwyh"; protected-headers="v1" From: Juergen Gross To: George Dunlap Cc: Andrew Cooper , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini , xen-devel , Roger Pau Monne Message-ID: <612415ce-bc24-52b1-e5a0-2860d36f2c01@suse.com> Subject: Re: Process for cherry-picking patches from other projects References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <2f2f10c1-e0cb-7274-1879-6f88c2517c47@suse.com> In-Reply-To: --------------VUtASp0q2WImv0CMSrHqzwyh Content-Type: multipart/mixed; boundary="------------4Qa3fUmXvTK2VupZqP56KNRM" --------------4Qa3fUmXvTK2VupZqP56KNRM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTYuMDUuMjIgMTU6MTIsIEdlb3JnZSBEdW5sYXAgd3JvdGU6DQo+IA0KPiANCj4+IE9u IE1heSAxMywgMjAyMiwgYXQgMzo1MiBQTSwgSnVlcmdlbiBHcm9zcyA8Skdyb3NzQHN1c2Uu Y29tPiB3cm90ZToNCj4+DQo+PiBPbiAxMy4wNS4yMiAxNjozMywgR2VvcmdlIER1bmxhcCB3 cm90ZToNCj4+PiBTdGFydGluZyBhIG5ldyB0aHJlYWQgdG8gbWFrZSBpdCBjbGVhciB0aGF0 IHdl4oCZcmUgZGlzY3Vzc2luZyBhIHdpZGVyIHBvbGljeSBoZXJlLg0KPj4+IFRoaXMgcXVl c3Rpb24gaXMgYWltZWQgYXQgSmFuIGFuZCBBbmR5IGluIHBhcnRpY3VsYXIsIGFzIEkgdGhp bmsgdGhleeKAmXZlIHByb2JhYmx5IGRvbmUgdGhlIG1vc3Qgb2YgdGhpczsgc28gSeKAmW0g bG9va2luZyB0byB0aGVtIHRvIGZpbmQgb3V0IHdoYXQgb3VyIOKAnHN0YW5kYXJkIHByYWN0 aWNl4oCdIGlzLg0KPj4+IFRoZXJlIGhhdmUgcmVjZW50bHkgYmVlbiBzb21lIHBhdGNoZXMg dGhhdCBCZXJ0cmFuZCBoYXMgc3VibWl0dGVkIHdoaWNoIHB1bGwgaW4gY29kZSBmcm9tIExp bnV4ICgiW1BBVENIIDEvM10geGVuL2FybTogU3luYyBzeXNyZWdzIGFuZCBjcHVpbmZvIHdp dGggTGludXggNS4xOC1yYzPigJ0pLCB3aGljaCBoYXMgY2F1c2VkIGEgZGlzY3Vzc2lvbiBi ZXR3ZWVuIGhpbSwgSnVsaWVuLCBhbmQgU3RlZmFubyBhYm91dCB0aGUgcHJvcGVyIHdheSB0 byBkbyBzdWNoIHBhdGNoZXMuDQo+Pj4gVGhlIOKAnE9yaWdpbjrigJ0gdGFnIHNlY3Rpb24g b2YgeGVuLmdpdC9kb2NzL3Byb2Nlc3Mvc2VuZGluZy1wYXRjaGVzLnBhbmRvYyBzdWdnZXN0 cyB0aGF0IHRoZXJlIGFyZSBzb21lIHN0YW5kYXJkcywgYnV0IGRvZXNu4oCZdCBzcGVsbCB0 aGVtIG91dC4NCj4+PiBUaGUgcXVlc3Rpb25zIHNlZW0gdG8gYmU6DQo+Pj4gMSkgV2hlbiBk b2luZyB0aGlzIGtpbmQgb2YgdXBkYXRlLCBpcyBpdCBwZXJtaXNzaWJsZSB0byBzZW5kIGEg c2luZ2xlIHBhdGNoIHdoaWNoIOKAnGJhdGNoZXPigJ0gc2V2ZXJhbCB1cHN0cmVhbSBjb21t aXRzIHRvZ2V0aGVyLCBvciBzaG91bGQgZWFjaCBwYXRjaCBiZSBiYWNrcG9ydGVkIGluZGl2 aWR1YWxseT8NCj4+PiAyKSBJZiDigJxiYXRjaGVz4oCdIGFyZSBwZXJtaXNzaWJsZSwgd2hl bj8gV2hlbiB3b3VsZCBpbmRpdmlkdWFsIHBhdGNoZXMgYmUgcHJlZmVycmVkPw0KPj4+IDMp IEZvciDigJxiYXRjaCB1cGRhdGVz4oCdLCB3aGF0IHRhZ3MgYXJlIG5lY2Vzc2FyeT8gRG8g d2UgbmVlZCB0byBub3RlIHRoZSBjaGFuZ2VzZXRzIG9mIGFsbCB0aGUgY29tbWl0cywgYW5k IGlmIHNvLCBkbyB3ZSBuZWVkIG11bHRpcGxlIOKAnE9yaWdpbuKAnSB0YWdzPyBEbyB3ZSBu ZWVkIHRvIGluY2x1ZGUgYW55dGhpbmcgZnJvbSB0aGUgb3JpZ2luYWwgY29tbWl0cyDigJQg Y29tbWl0IG1lc3NhZ2VzPyBTaWduZWQtb2ZmLWJ54oCZcz8NCj4+PiBBbmQgYSByZWxhdGVk IHF1ZXN0aW9uOg0KPj4+IDQpIFdoZW4gaW1wb3J0aW5nIGFuIGVudGlyZSBmaWxlIGZyb20g YW4gdXBzdHJlYW0gbGlrZSBMaW51eCwgd2hhdCB0YWdzIGRvIHdlIG5lZWQ/DQo+Pj4gTXkg cmVjb2xsZWN0aW9uIGlzIHRoYXQgd2Ugb2Z0ZW4gdG8gYSDigJxhY2N1bXVsYXRlZCBwYXRj aOKAnSB0byB1cGRhdGUsIHNheSwgdGhlIEtjb25maWcgdG9vbGluZzsgc28gaXQgc2VlbXMg bGlrZSB0aGUgYW5zd2VyIHRvIHRoaXMgaXMgc29tZXRpbWVzIOKAnHllc+KAnS4NCj4+PiBJ dCBzZWVtcyB0byBtZSB0aGF0IGluIGEgY2FzZSB3aGVyZSB5b3XigJlyZSBpbXBvcnRpbmcg YSBoYW5kZnVsIG9mIHBhdGNoZXMg4oCUIHNheSA1LTEwIOKAlCB0aGF0IGltcG9ydGluZyB0 aGVtIG9uZS1ieS1vbmUgbWlnaHQgYmUgcHJlZmVycmVkOyBidXQgaW4gdGhpcyBjYXNlLCBz aW5jZSB0aGUgc3VibWlzc2lvbiB3YXMgYWxyZWFkeSBtYWRlIGFzIGEgYmF0Y2gsIEnigJlk IGFjY2VwdCBoYXZpbmcgaXQgYXMgYSBiYXRjaC4NCj4+PiBJIHRoaW5rIGlmIEkgd2VyZSB3 cml0aW5nIHRoaXMgcGF0Y2gsIEnigJlkIG1ha2UgYSBzZXBhcmF0ZSDigJxPcmlnaW7igJ0g dGFnIGZvciBlYWNoIGNvbW1pdC4NCj4+PiBJIHdvdWxkbuKAmXQgaW5jbHVkZSB0aGUgdXBz dHJlYW0gY29tbWl0IG1lc3NhZ2VzIG9yIFMtby1i4oCZczsgSSB3b3VsZCB3cml0ZSBteSBv d24gY29tbWl0IG1lc3NhZ2Ugc3VtbWFyaXppbmcgd2h5IEnigJltIGltcG9ydGluZyB0aGUg Y29tbWl0cywgdGhlbiBoYXZlIHRoZSDigJhvcmlnaW7igJkgdGFncywgdGhlbiBteSBvd24g Uy1vLWIgdG8gaW5kaWNhdGUgdGhhdCBJIGFtIGF0dGVzdGluZyB0aGF0IGl0IGNvbWVzIGZy b20gYW4gb3Blbi1zb3VyY2UgcHJvamVjdCAoYW5kIGZvciB3aGF0ZXZlciBjb3B5cmlnaHQg Y2FuIGJlIGFzc2VydGVkIG9uIHRoZSBjb21taXQgbWVzc2FnZSBhbmQgdGhlIHBhdGNoIGFz IGEgY29sbGVjdGlvbikuDQo+Pj4gQW5kIGZvciAjNCwgSSB3b3VsZCBkbyBzb21ldGhpbmcg c2ltaWxhcjogSSB3b3VsZCB3cml0ZSBteSBvd24gY29tbWl0IG1lc3NhZ2UgZGVzY3JpYmlu ZyB3aGF0IHRoZSBmaWxlIGlzIGZvciBhbmQgd2h5IHdl4oCZcmUgaW1wb3J0aW5nIGl0OyBo YXZlIHRoZSBPcmlnaW4gdGFnIHBvaW50IHRvIHRoZSBjb21taXQgYXQgdGhlIHBvaW50IEkg dG9vayB0aGUgZmlsZTsgYW5kIG15IG93biBTLW8tYi4NCj4+DQo+PiBJTU8gd2Ugc2hvdWxk IGFkZCBhbm90aGVyIHRhZyBmb3IgdGhhdCBwdXJwb3NlLCBlLmcuOg0KPj4NCj4+IEZpbGUt b3JpZ2luOiA8cmVwb3NpdG9yeT4gPHRhZz4gPHBhdGg+IFsjIDxsb2NhbC1wYXRoPl0NCj4+ DQo+PiBTcGVjaWZ5aW5nIHRoZSByZXBvc2l0b3J5IHRoZSBmaWxlKHMpIGFyZSBjb21pbmcg ZnJvbSwgdGhlIHRhZyAoZS5nLiBhDQo+PiB0YWdnZWQgdmVyc2lvbiwgb3IgdGhlIHRvcCBn aXQgY29tbWl0KSwgYW5kIHRoZSBwYXRoIG9mIHRoZSBvcmlnaW5hbA0KPj4gZmlsZShzKSBp biB0aGF0IHJlcG9zaXRvcnkgKDxwYXRoPiBjb3VsZCBlaXRoZXIgYmUgYSBjb21tb24gZGly ZWN0b3J5DQo+PiBvZiBtdWx0aXBsZSBmaWxlcywgb3IgYSBzaW5nbGUgZmlsZTsgbXVsdGlw bGUgIkZpbGUtb3JpZ2luOiIgdGFncyBzaG91bGQNCj4+IGJlIHBvc3NpYmxlKS4gSW4gY2Fz ZSB0aGUgZmlsZSBpcyBiZWluZyByZW5hbWVkIGxvY2FsbHksIGl0cyBuZXcgbmFtZQ0KPj4g Y2FuIGJlIGFkZGVkIGFzIDxsb2NhbC1wYXRoPi4NCj4+DQo+PiBUaGlzIHZhcmlhbnQgc2hv dWxkIGJlIHVzZWQgdG8gYWRkIF9uZXdfIGZpbGVzIHRvIFhlbi4gSW4gY2FzZSBvZg0KPj4g dXBkYXRpbmcgYSBmaWxlIHdoaWNoIGhhcyBzZWVtIGxvdHMgb2YgY29tbWl0cyBzaW5jZSBp dHMgbGFzdCB1cGRhdGUgb3INCj4+IGludHJvZHVjdGlvbiwgaXQgbWlnaHQgYmUgZWFzaWVy IHRvIGp1c3QgdXNlIHRoZSAiRmlsZS1vcmlnaW46IiB0YWcsDQo+PiBwcm9iYWJseSB3aXRo IGEgbm90ZSBiZWxvdyB0aGUgIi0tLSIgbWFya2VyIHRoYXQgbGlzdGluZyBtb3JlIHRoYW4g PHg+DQo+PiBwYXRjaGVzICh4ID4gMTA/KSBvciBzcGxpdHRpbmcgaW50byBtb3JlIHRoYW4g PHg+IHBhdGNoZXMgd291bGQgYmUNCj4+IGp1c3QgdXNlbGVzcyB3b3JrIChjb21tb24gc2Vu c2Ugc2hvdWxkIGFwcGx5IGhlcmUsIGVzcGVjaWFsbHkgcmVnYXJkaW5nDQo+PiB0aGUgcmVh ZGFiaWxpdHkgb2YgdGhlIHBhdGNoIGFuZCB0aGUgcmVsYXRlZCByZXZpZXcgZWZmb3J0KS4N Cj4gDQo+IFlvdSBkb27igJl0IG1lbnRpb24gd2hhdCB0byBkbyBhYm91dCBTb0LigJlzIOKA lCBJIGFzc3VtZSB5b3UgYWdyZWUgd2l0aCBteSBhc3Nlc3NtZW50IGFib3ZlLCB0aGF0IGEg c2luZ2xlICBTb0IgZnJvbSB0aGUgc3VibWl0dGVyIG9mIHRoZSBwYXRjaCB0byBYZW4sIGFz c2VydGluZyB0aGF0IHRoZXnigJlyZSBzYXRpc2ZpZWQgdGhhdCBhbGwgb2YgdGhlIGNvZGUg aGFzIGJlZW4gYXNzZXJ0ZWQgYnkgb3RoZXIgcGVvcGxlIGFzIGhhdmluZyBhIHN1aXRhYmxl IGxpY2Vuc2UsIGlzIHN1ZmZpY2llbnQuDQoNClllcy4NCg0KPiBJbiB3aGljaCBjYXNlLCBi YXJyaW5nIGEgY29udHJhZGljdGlvbiBmcm9tIEFuZHkgb3IgSmFuIGFzIHRvIG91ciBzdGFu ZGFyZCBwcmFjdGljZSwgSSB0aGluayB0aGF0IHdlIGRvbuKAmXQgbmVlZCB0byBjb2xsZWN0 IFNvQnMgZnJvbSB0aGUgb3JpZ2luYWwgY29tbWl0czsgYSBzaW5nbGUgU29CIGJ5IEJlcnRy YW5kIChvciB3aG9tZXZlcikgdGhhdCBpdCBhbGwgY29tZXMgZnJvbSBMaW51eCBhbmQgdGhh dCBzdWl0YWJsZSBTb0JzIGNhbiBiZSB0cmFja2VkIGRvd24gc2hvdWxkIGl0IGJlY29tZSBu ZWNlc3NhcnksIHdpbGwgYmUgc3VmZmljaWVudC4NCg0KWWVzLCB0aGlzIGlzIHRoZSBpZGVh IGJ5IHNwZWNpZnlpbmcgYSB0YWcgb2YgdGhlIHNvdXJjZSByZXBvc2l0b3J5Lg0KVXNpbmcg dGhlIGNvcnJlY3QgZ2l0IGNvbW1hbmRzIGl0IHNob3VsZCBhbHdheXMgYmUgcG9zc2libGUg dG8gZ2V0DQp0aGUgY29tcGxldGUgbGlzdCBvZiBTb0JzIGZvciBhbiBpbXBvcnRlZCBmaWxl Lg0KDQoNCkp1ZXJnZW4NCg== --------------4Qa3fUmXvTK2VupZqP56KNRM Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4Qa3fUmXvTK2VupZqP56KNRM-- --------------VUtASp0q2WImv0CMSrHqzwyh-- --------------NMHdFOqR37IMccSdMrsHS50L Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKCVzwFAwAAAAAACgkQsN6d1ii/Ey9m AAf+KxaZQHZatGli+8NkOfyJ8A8Y4EeU/fpaFKyP9BhAleJ057cm9n1DEIsDM/pLD+D3SyajVeAb VqMfaUWX3ehmaN3kbsz7rDhdiEVej0Ci2sXUZdLEemc31bU9jSUbgttHnko4ryl1hhlSkjvvKMnj lXk/bBwnowItoojdKSeldqTpMJ0eMXUJeDkbX5Oiye5CngqZ/7DFXrkSYkY+wbceJ+K0yNmuSc8A tcSpB7gm6iwQlURqHpLxZ3vfiRc6QquBRhZgSu7/lNO0Tpclw7PRgTHY1mXRmxGJ7iLSmEao25I9 INmZn7+brcBYW7/0cSccS1vgp7Qgx16xk70Wx0Mvhw== =YAIJ -----END PGP SIGNATURE----- --------------NMHdFOqR37IMccSdMrsHS50L-- From xen-devel-bounces@lists.xenproject.org Mon May 16 14:02:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329872.553142 (Exim 4.92) (envelope-from ) id 1nqbIM-00006R-71; Mon, 16 May 2022 14:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329872.553142; Mon, 16 May 2022 14:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIM-00006K-3h; Mon, 16 May 2022 14:01:58 +0000 Received: by outflank-mailman (input) for mailman id 329872; Mon, 16 May 2022 14:01:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIK-00006A-8U; Mon, 16 May 2022 14:01:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIK-00031H-6S; Mon, 16 May 2022 14:01:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIJ-0006r3-Mh; Mon, 16 May 2022 14:01:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqbIJ-00040t-MH; Mon, 16 May 2022 14:01:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PsWDfALIopVZx6UnuPyoqZxv57Muy9d/jQSK+cFc7V0=; b=Ewred9x0vg5tQkYojIRaSXYoS4 mAsXkftz+MYjlN08tZKcru68xoOhWYUoqegidjVCQt3mpBIVwkYRRRptqAKP0aoOPPgAeYCw95sUi fCXLvKIBnXOIbEeW2i5+lkQDZyy0xaYmJRNs6z79Nvg8fL0b3qhkj+BPhbj9K7hPaUrM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170480: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 14:01:55 +0000 flight 170480 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1043 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 62 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 14:02:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329875.553153 (Exim 4.92) (envelope-from ) id 1nqbIR-0000O8-Ge; Mon, 16 May 2022 14:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329875.553153; Mon, 16 May 2022 14:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIR-0000O1-D6; Mon, 16 May 2022 14:02:03 +0000 Received: by outflank-mailman (input) for mailman id 329875; Mon, 16 May 2022 14:02:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIP-0000NS-Qa for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:02:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c17eeaa8-d520-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:02:00 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2362F21F5C; Mon, 16 May 2022 14:02:00 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D43112C141; Mon, 16 May 2022 14:01:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c17eeaa8-d520-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652709720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6xX/Xo1YcyoxhDGVtD+3aF7M9NKMVvtDcsL11SFSAQU=; b=UAEfoymfYf+QAbCzE3oYFS/LnW9rFBs924Unv93LKXY9GoxfXpJbDSZbNYQc1AwPujLxjA jmh7TvIJcQUwFXF0iE9L66PiKtfkKtU88t+hUCpM3m0czPO3TM37NQr+8KouKC5lf5Okex k2McswvfGUIvb+tozWKmApBRPL9ucl0= Date: Mon, 16 May 2022 16:01:57 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , David Gow , "David S. Miller" , Dexuan Cui , Doug Berger , Evan Green , Florian Fainelli , Haiyang Zhang , Hari Bathini , Heiko Carstens , Julius Werner , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Scott Branden , Sebastian Reichel , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-20-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:13, Guilherme G. Piccoli wrote: > The goal of this new panic notifier is to allow its users to register > callbacks to run very early in the panic path. This aims hypervisor/FW > notification mechanisms as well as simple LED functions, and any other > simple and safe mechanism that should run early in the panic path; more > dangerous callbacks should execute later. > > For now, the patch is almost a no-op (although it changes a bit the > ordering in which some panic notifiers are executed). In a subsequent > patch, the panic path will be refactored, then the panic hypervisor > notifiers will effectively run very early in the panic path. > > We also defer documenting it all properly in the subsequent refactor > patch. While at it, we removed some useless header inclusions and > fixed some notifiers return too (by using the standard NOTIFY_DONE). > --- a/arch/mips/sgi-ip22/ip22-reset.c > +++ b/arch/mips/sgi-ip22/ip22-reset.c > @@ -195,7 +195,7 @@ static int __init reboot_setup(void) > } > > timer_setup(&blink_timer, blink_timeout, 0); > - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); This notifier enables blinking. It is not much safe. It calls mod_timer() that takes a lock internally. This kind of functionality should go into the last list called before panic() enters the infinite loop. IMHO, all the blinking stuff should go there. > > return 0; > } > diff --git a/arch/mips/sgi-ip32/ip32-reset.c b/arch/mips/sgi-ip32/ip32-reset.c > index 18d1c115cd53..9ee1302c9d13 100644 > --- a/arch/mips/sgi-ip32/ip32-reset.c > +++ b/arch/mips/sgi-ip32/ip32-reset.c > @@ -145,7 +144,7 @@ static __init int ip32_reboot_setup(void) > pm_power_off = ip32_machine_halt; > > timer_setup(&blink_timer, blink_timeout, 0); > - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); Same here. Should be done only before the "loop". > > return 0; > } > --- a/drivers/firmware/google/gsmi.c > +++ b/drivers/firmware/google/gsmi.c > @@ -1034,7 +1034,7 @@ static __init int gsmi_init(void) > > register_reboot_notifier(&gsmi_reboot_notifier); > register_die_notifier(&gsmi_die_notifier); > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_hypervisor_list, > &gsmi_panic_notifier); I am not sure about this one. It looks like some logging or pre_reboot stuff. > > printk(KERN_INFO "gsmi version " DRIVER_VERSION " loaded\n"); > --- a/drivers/leds/trigger/ledtrig-activity.c > +++ b/drivers/leds/trigger/ledtrig-activity.c > @@ -247,7 +247,7 @@ static int __init activity_init(void) > int rc = led_trigger_register(&activity_led_trigger); > > if (!rc) { > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_hypervisor_list, > &activity_panic_nb); The notifier is trivial. It just sets a variable. But still, it is about blinking and should be done in the last "loop" list. > register_reboot_notifier(&activity_reboot_nb); > } > --- a/drivers/leds/trigger/ledtrig-heartbeat.c > +++ b/drivers/leds/trigger/ledtrig-heartbeat.c > @@ -190,7 +190,7 @@ static int __init heartbeat_trig_init(void) > int rc = led_trigger_register(&heartbeat_led_trigger); > > if (!rc) { > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_hypervisor_list, > &heartbeat_panic_nb); Same here. Blinking => loop list. > register_reboot_notifier(&heartbeat_reboot_nb); > } > diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c > index a16b99bdaa13..d9d5199cdb2b 100644 > --- a/drivers/misc/bcm-vk/bcm_vk_dev.c > +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c > @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > /* register for panic notifier */ > vk->panic_nb.notifier_call = bcm_vk_on_panic; > - err = atomic_notifier_chain_register(&panic_notifier_list, > + err = atomic_notifier_chain_register(&panic_hypervisor_list, > &vk->panic_nb); It seems to reset some hardware or so. IMHO, it should go into the pre-reboot list. > if (err) { > dev_err(dev, "Fail to register panic notifier\n"); > --- a/drivers/power/reset/ltc2952-poweroff.c > +++ b/drivers/power/reset/ltc2952-poweroff.c > @@ -279,7 +279,7 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev) > pm_power_off = ltc2952_poweroff_kill; > > data->panic_notifier.notifier_call = ltc2952_poweroff_notify_panic; > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_hypervisor_list, > &data->panic_notifier); I looks like this somehow triggers the reboot. IMHO, it should go into the pre_reboot list. > dev_info(&pdev->dev, "probe successful\n"); > > --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c > +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c > @@ -814,7 +814,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) > goto out; > } > > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_hypervisor_list, > &brcmstb_pm_panic_nb); I am not sure about this one. It instruct some HW to preserve DRAM. IMHO, it better fits into pre_reboot category but I do not have strong opinion. > > pm_power_off = brcmstb_pm_poweroff; Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 14:02:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:02:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329886.553164 (Exim 4.92) (envelope-from ) id 1nqbIw-00010A-RG; Mon, 16 May 2022 14:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329886.553164; Mon, 16 May 2022 14:02:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIw-000103-O4; Mon, 16 May 2022 14:02:34 +0000 Received: by outflank-mailman (input) for mailman id 329886; Mon, 16 May 2022 14:02:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbIv-0000nQ-8O for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:02:33 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d22d13a8-d520-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 16:02:30 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0412C5C0187; Mon, 16 May 2022 10:02:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 16 May 2022 10:02:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 May 2022 10:02:26 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d22d13a8-d520-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652709747; x= 1652796147; bh=5+yjKYHPE1yoR5qIVYd0h7SQNO3dMIP7wshVKU2tLos=; b=k saUMyBATJHiD5hcBAlk1cIyhS1lpNsncGh0Ap4ZUTf/TWtLo6hce5e/Jb2UGcVPK nL6NcXTFYOzPQZ5/mnYsjoB/jgPhJDJ624lQQA2wE7c5xPoMdMSqAr8HI0/3+CkW eZr8gTDbC9l7Q/yiTwIIlFA8EtlwUY/FtcsgzZpZrQ+Lvbk+qXVtr/R1jQj34tpa 73t3PsRbsODttyToRASv9OjnPMFINxj5L443EkpRW/2I1UYw1u47sT2IiTp075os 6sRX0y6E/WPgQLABilj2gjj3SILxTVQv8bpt2FHNFCidB6Kldt9aS1JsYIBsGgb1 Uwh0zqORhAMD6ZPNF695A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652709747; x= 1652796147; bh=5+yjKYHPE1yoR5qIVYd0h7SQNO3dMIP7wshVKU2tLos=; b=d i4A6NuCbon46rmfCdiNtEeyRKml5bH1dEYMsdrOArpkzpHB+MJR47Ls7B9vh4ikQ L0aZHA5SGNFR6RzZzTK/yPaqSXqe61DsdkXph2VK/JZqRJoMrFFGVUTe+6KpXr3n U5NJ9Y+CVNpTeiFvSz8Y127Q/Mn29hbE1sG+CNoB/13dr7grorrV0DgkkEBF4e1X koCzziX43Kr+9IwKHsgAW/iLx6qQiR6ohgzRNNhDTDXj0kDlDwIRvxeabG9U82jI 1KK3mSRMogtw6D5MsVbD8cJgLY8bJH98nJ1VZ7YdHXetoAzvUCFjbTs8DiHuCU8e ibgZKTkheqrujPBH6PEDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheehgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeutdehhfdtvdfffeejjedvhedvjeei heffheekkeehgeelueelveeludetheetteenucffohhmrghinhepghhithhhuhgsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Mon, 16 May 2022 10:00:07 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion , Andrew Morton Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Linux Memory Management Subject: Re: Hang in 5.17.4+ that appears to be due to Xen Message-ID: References: <55436ae1-8255-1898-00df-51261080cd41@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YnCoB7CFMTtqXZKs" Content-Disposition: inline In-Reply-To: <55436ae1-8255-1898-00df-51261080cd41@suse.com> --YnCoB7CFMTtqXZKs Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 16 May 2022 10:00:07 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion , Andrew Morton Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Linux Memory Management Subject: Re: Hang in 5.17.4+ that appears to be due to Xen On Mon, May 16, 2022 at 08:48:17AM +0200, Juergen Gross wrote: > On 14.05.22 17:55, Demi Marie Obenour wrote: > > In https://github.com/QubesOS/qubes-issues/issues/7481, a user reported > > that Xorg locked up when resizing a VM window. While I do not have the > > same hardware the user does and thus cannot reproduce the bug, the stack > > trace seems to indicate a deadlock between xen_gntdev and i915. It > > appears that gnttab_unmap_refs_sync() is waiting for i915 to free the > > pages, while i915 is waiting for the MMU notifier that called > > gnttab_unmap_refs_sync() to return. Result: deadlock. > >=20 > > The problem appears to be that a mapped grant in PV mode will stay in > > the =E2=80=9Cinvalidating=E2=80=9D state until it is freed. While MMU = notifiers are > > allowed to sleep, it appears that they cannot wait for the page to be > > freed, as is happening here. That said, I am not very familiar with > > this code, so my diagnosis might be incorrect. >=20 > All I can say for now is that your patch seems to be introducing a use af= ter > free issue, as the parameters of the delayed work might get freed now bef= ore > the delayed work is being executed. I figured it was wrong, not least because I don=E2=80=99t think it compiles (invalid use of void value). That said, the current behavior is quite suspicious to me. For one, it appears that munmap() on a grant in a PV domain will not return until nobody else is using the page. This is not what I would expect, and I can easily imagine it causing deadlocks in userspace. Instead, I would expect for gntdev to automatically release the grant when the reference count hits zero. This would also allow for the same grant to be mapped in multiple processes, and might even unlock DMA-BUF support. > I don't know why this is happening only with rather recent kernels, as the > last gntdev changes in this area have been made in kernel 4.13. >=20 > I'd suggest to look at i915, as quite some work has happened in the code > visible in your stack backtraces rather recently. Maybe it would be possi= ble > to free the pages in i915 before calling the MMU notifier? While I agree that the actual problem is almost certainly in i915, the gntdev code does appear rather fragile. Since so few people use i915 + Xen, problems with the combination generally don=E2=80=99t show up until so= me Qubes user makes a bug report, which isn=E2=80=99t great. It would be bett= er if Xen didn=E2=80=99t introduce requirements on other kernel code that did not= hold when not running on Xen. In this case, if it is actually an invariant that one must not call MMU notifiers for pages that are still in use, it would be better if this was caught by a WARN_ON() or BUG_ON() in the core memory management code. That would have found the bug instantly and deterministically on all platforms, whereas the current failure is nondeterministic and only happens under Xen. I also wonder if this is a bug in the core MMU notifier infrastructure. My reading of the mmu_interval_notifier_remove() documentation is that it should only wait for the specific notifier being removed to finish, not for all notifiers to finish. Adding the memory management maintainers. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --YnCoB7CFMTtqXZKs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKCWXEACgkQsoi1X/+c IsEjNBAAz3hf+qemY+7SSkjIjwueaAyZFhnYLKo7R0cNfYPKD12S5Rt0z0iQbVNN PSXBm7/9WS5C9a3x4poKuE5k+HUbpBiu/xrUHSvWQgoCpJCT7ZIruIKQYYj7Ok9C BRf3ZjB47o9ZYkRjanMjNeCYJpx8JpAU4Kq1DtLtZW9vtibKdk/Yhn4bl54rqBtQ 8UGtYK85sfxTnBegkR3/T2bXAuymx3tbi6+VF1NjzH1SYSNp0kUX7FJGfQrNaXXO jzNW7rCsA9AEeitHavIsRgBMSMGbeq+QLdGhx5I8TKS9fplT99b6ZvnEg3qMDDKe Y6l7SM765IqeByc+oi1cmZ25djJiRUKM7OVgDLvkC73F3auBKEzA+H56JOvMJDHu rrKdUt4Mbo5eOBxRJn1l9C/C/2Gxuu2UW8KOAXVoLk+yjWjzqUYrpO8lm/T1o/m7 0lwBFi5KV2iEPuGcfS9cMNPmjNtkFSgKpSSmAatwH0D7nQCPPoN6Xf1WzQN/mAyz XP8VvvKkzB+QLyu+/niOIWHWNED2EwOiR1rhJ8ElESpDTz03qBGrSpIoffmwVngB nojEVAMrgCyzwmfB90myQAZ2MUvdfgOUj5Cy6qAZYctv2RXAwBvZOmZdgWMLYJvl IoWWk34NY57aVwFxvWnDQls/YRqzO8DZUimCHIt1CxqK64u35yk= =bUCk -----END PGP SIGNATURE----- --YnCoB7CFMTtqXZKs-- From xen-devel-bounces@lists.xenproject.org Mon May 16 14:11:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329898.553174 (Exim 4.92) (envelope-from ) id 1nqbRI-0002nw-RG; Mon, 16 May 2022 14:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329898.553174; Mon, 16 May 2022 14:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbRI-0002np-OG; Mon, 16 May 2022 14:11:12 +0000 Received: by outflank-mailman (input) for mailman id 329898; Mon, 16 May 2022 14:11:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbRH-0002nj-Ku for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:11:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0873b420-d522-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:11:09 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8469521F6D; Mon, 16 May 2022 14:11:08 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C9CB72C141; Mon, 16 May 2022 14:11:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0873b420-d522-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652710268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dmHPB9vjv1LBmNrF4zaonBMXasUoClA4XRHwK4fdG3Q=; b=uHHoYScC3vOzAq1rF/GezErIJTTCAnG26YueVBaMYGI4KIiBuE4CJEi5I5FkSHuHNJvOhi jBbeahpPdNTqQb9qWzy8wQwtiwj/B2njZ1Svs0P1iMsaZXkpVlpc6Bgj/6IAHlnD6RNRY+ 7obFqakfVm+qw0H2R1BXYJwwfwabCHA= Date: Mon, 16 May 2022 16:11:06 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Catalin Marinas , Florian Fainelli , Frederic Weisbecker , "H. Peter Anvin" , Hari Bathini , Joel Fernandes , Jonathan Hunter , Josh Triplett , Lai Jiangshan , Leo Yan , Mathieu Desnoyers , Mathieu Poirier , Michael Ellerman , Mike Leach , Mikko Perttunen , Neeraj Upadhyay , Nicholas Piggin , Paul Mackerras , Suzuki K Poulose , Thierry Reding , Thomas Bogendoerfer Subject: Re: [PATCH 20/30] panic: Add the panic informational notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-21-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-21-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:14, Guilherme G. Piccoli wrote: > The goal of this new panic notifier is to allow its users to > register callbacks to run earlier in the panic path than they > currently do. This aims at informational mechanisms, like dumping > kernel offsets and showing device error data (in case it's simple > registers reading, for example) as well as mechanisms to disable > log flooding (like hung_task detector / RCU warnings) and the > tracing dump_on_oops (when enabled). > > Any (non-invasive) information that should be provided before > kmsg_dump() as well as log flooding preventing code should fit > here, as long it offers relatively low risk for kdump. > > For now, the patch is almost a no-op, although it changes a bit > the ordering in which some panic notifiers are executed - specially > affected by this are the notifiers responsible for disabling the > hung_task detector / RCU warnings, which now run first. In a > subsequent patch, the panic path will be refactored, then the > panic informational notifiers will effectively run earlier, > before ksmg_dump() (and usually before kdump as well). > > We also defer documenting it all properly in the subsequent > refactor patch. Finally, while at it, we removed some useless > header inclusions too. > > Signed-off-by: Guilherme G. Piccoli All notifiers moved in this patch seems to fit well the "info" notifier list. The patch looks good from this POV. I still have to review the rest of the patches to see if it is complete. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 14:29:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329908.553189 (Exim 4.92) (envelope-from ) id 1nqbjD-0004ZW-Fi; Mon, 16 May 2022 14:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329908.553189; Mon, 16 May 2022 14:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbjD-0004ZP-BW; Mon, 16 May 2022 14:29:43 +0000 Received: by outflank-mailman (input) for mailman id 329908; Mon, 16 May 2022 14:29:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbjA-0004ZJ-T5 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:29:41 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d6078a0-d524-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 16:29:38 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqbiH-006jqF-NN; Mon, 16 May 2022 16:28:45 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d6078a0-d524-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dr1+fxlRa10p1m+vrzAuj1y5TNI2rJf4d/f63MyjB+M=; b=fYzY4ecO4EXD3ATClVXmZ0bJur Dv8wK0czHKvUOBFU8VuldwMBw90SyqpgmdhMVGQ8nXO736KAANyIsoQXQP33B+3yyoD0JCNk+aqdE wV4BChThAKeGVlTD0SJGL4Vxo4e8WEaw/u07Aef0GJ4zliM2Txb1MiVoO17nGrOaES7KtCdKD9gb0 sGHl/FYmvmjU5t6Sh9/lpO3xyoHOnkZh2Wlu5eWU81axQTiGRY/vWICGCkOGZAWHyJcpjaIpuAOez xXU+abi85zQz75A1GTgWOD+LFSEreERO76kWgkEOfnkbC3cJ3TOsglz2ZOZKp2XuFNlT0F2Yx1p5e +2fZkv1A==; Message-ID: Date: Mon, 16 May 2022 11:28:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 20/30] panic: Add the panic informational notifier list Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Benjamin Herrenschmidt , Catalin Marinas , Florian Fainelli , Frederic Weisbecker , "H. Peter Anvin" , Hari Bathini , Joel Fernandes , Jonathan Hunter , Josh Triplett , Lai Jiangshan , Leo Yan , Mathieu Desnoyers , Mathieu Poirier , Michael Ellerman , Mike Leach , Mikko Perttunen , Neeraj Upadhyay , Nicholas Piggin , Paul Mackerras , Suzuki K Poulose , Thierry Reding , Thomas Bogendoerfer References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-21-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 11:11, Petr Mladek wrote: > [...] > > All notifiers moved in this patch seems to fit well the "info" > notifier list. The patch looks good from this POV. > > I still have to review the rest of the patches to see if it > is complete. > > Best Regards, > Petr Thanks a bunch for the review =) From xen-devel-bounces@lists.xenproject.org Mon May 16 14:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329915.553200 (Exim 4.92) (envelope-from ) id 1nqbms-00065l-Uy; Mon, 16 May 2022 14:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329915.553200; Mon, 16 May 2022 14:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbms-00065e-S2; Mon, 16 May 2022 14:33:30 +0000 Received: by outflank-mailman (input) for mailman id 329915; Mon, 16 May 2022 14:33:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbmq-00065Y-JH for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:33:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20a7bb78-d525-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 16:33:24 +0200 (CEST) Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 10:31:32 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB3868.namprd03.prod.outlook.com (2603:10b6:5:4f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 14:31:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.018; Mon, 16 May 2022 14:31:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20a7bb78-d525-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652711606; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=91Wmal1CB8VlFN59BIsW0tjoIPUoHQ43Tm7bH/2l90Q=; b=ONFj/fby7RSCqeBhnctomREXZzxtEyOSmuFUh3VGi42LOdruiVGnl4VY pYQtl1Uoxf2Be96gSwooEXIbTmBFsAS9mzSTAWjXD05v6YF+M2PZFv1Zz fhSXGsBqeDd3Jp2M1mSEdh4BY78SZesjcNGdx6oaVtVVGYZV4y+0Kk42O 4=; X-IronPort-RemoteIP: 104.47.55.104 X-IronPort-MID: 70785565 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ON5eO67x15flxBiQOBUC4QxRtE7GchMFZxGqfqrLsTDasY5as4F+v mROD2GPPveJa2DyeNxzb9/i/EsHvMXWxoRqGVFkrH8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgXVvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS7TxskMvfyk9hCUhtAOn9PZbxXxq/+dC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAgF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IA9wLI+PRqi4TV5E9owr7jL4PzQ5+1e9wPlBy6v Vv4znusV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL 00f+gI1sLM/skesS7HVQBmQsHOC+BkGVLJt//YS7QiMzu/R/FyfD21dFjpZMoV+6IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSfLs5jEpMVkcG wy3kRU= IronPort-HdrOrdr: A9a23:GIW2G66T+KC4Ym9F6APXwAzXdLJyesId70hD6qm+c3Nom7+j5q eTdZUgpH3JYVMqM03I9urgBEDtex7hHP1OkOos1NWZPDUO0VHAROtfBODZrQEIbheOktK1u5 0NT0BaYOeAdCkD/L2KmnjELz4CqOP3j5xBvo/lvgtQpHlRGsRdBzUQMHfkLqVBLDM2dKbQI/ Knl7p6jivlcm8QasSmAj0ARebCqrTw5fTbXSI= X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="scan'208";a="70785565" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5R/AhEzvjGD/pTTvXqv1fufEiOpUxny6N1jPjbbdec1fTWeaFNwN//ePBIaGU8pnwWqkzNGC9yjK20iVzqawsfULJ642JEHf/0boxNa4boVTZiXbnzd2kN8gUnjkOvsW8sfEAjH5b/mjnuA1QqutMw8B3QTl2cu4IIjGudP3zxXoJh4ly3x3WYSmfMuszau0bUJ3N9zivJ3470U+81fCTWpb0MdRfaRcWuCOknZPs0w0P+pL8x3MgIzir9q7KiYE+6gZLM+VThvVB3QIKIdi1dn5LkVvkPhJsQDQBHLmj+N2/ypzpkuexf0y1SLfBEvO0ly8GbZEOz8By4WRnrkeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3z7cp0g1R/YVtPHI0JJ7+lHogu2k/5+yi01WV1RPyZY=; b=FuneRbeUOnSlYZWxS5wl4JzPTLRuB8OclW03jS+OqDQv3qRSOC1aMk7k80QduKv6zpdFwRgOEeD7iweUigfHPcYEK2PjfvZvDaTUNBIge1hPdCbn60mE81JgICZ83FUOQx6xIMQuoGcSZg7pG3WF/G3TySoB4tsm0WTxW0pTgEPFNtShvuMm5G9x5VtuLWyevXeBTgWwC0JfMdBPA6CECWhnUwZw0oAMex27hYhYKIohPUZopw/PafNTZx2vQEsSzHEhh9d9eywHJKj7mMtj1I1yHp9Rb3zc0M70r6NHWfTFY/1U6Kn5LP06D6nLVz+L2taDUtqmVbDltIFsiW5Pgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3z7cp0g1R/YVtPHI0JJ7+lHogu2k/5+yi01WV1RPyZY=; b=ux4x925LjiR/Gu8EnXMw6IANXcfmxCrTdVOpwjv9FcxQbSx/KZJfY7CgXaFijWjUyeMPxuKswPnp6RbJoKnBqRVe/CAcMrQ/Q59BzRRfGscWaNIDqJ0vx6QJAlOGUhKjwGRydCZMDIfMZg2iyyOIu2xsZM9r3mVAy7d1gvk7q4g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH] x86/flushtlb: remove flush_area check on system state Date: Mon, 16 May 2022 16:31:16 +0200 Message-Id: <20220516143116.28602-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4f3ca8f-63ed-4120-9538-08da3748c1b9 X-MS-TrafficTypeDiagnostic: DM6PR03MB3868:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qGvMby7Bo8/lZApCzXmqY1xse4TDCumV7lwWZyE3KFqhTqE3f+/HKjEQbEi+5RXezKa4vK86/lhH39MLBPF9CnbK5rvEvRzAIE3NKq19/ibgxTXwZ0Fn4zy+MTT0zedQYtBzafYqvU30y1DY0o7ImSL1N5PGhR42kw6opfw9cRGp6D7DT2qIX/ntG84Fc2XFnLx4mh1+0MX+eaOVZkoSrCOvg8x5/YvVGUZoU5jxzR8HXw7WzhhlQl45LIEC7BeNdpx+2PV2A7wzcOs6qdy6qcHBixqyeqUqRxqGeaQGvrnrNLHMk4JJuqWbq2b4p/qeYyXEmvGxXwhhfMiv9QdIyr2V1J61iFl0+CAJ1w5/2BfolB9xybxPkmhgG4nw80QuecZpLnoz9+GFuIfly5hSMyshsDsYrwnKmqAqT/e8oO+ZYnN7doijhC+tdv++DdagOG0LjJrlA8FwT5b0oxZmi1L1V4W2GcnJ+7YogRmCENGkvgQGUkUYJ5y3mVv0tEYR1YgJuWcnxPavqdXc1mpAijQplIW565a8ZztYYvFqGTpHsZ086g846DmpFNSFsRqXy+uFyYY/8O/mWDGTHsmS0fRRTqFlTuegfLE4VRt4L7ESdP/abTbQVMYj/jpxIhPp0fxdl3owwTSggPYeGGJjTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6512007)(26005)(6506007)(1076003)(186003)(2616005)(82960400001)(508600001)(6486002)(86362001)(83380400001)(2906002)(66556008)(54906003)(66476007)(316002)(66946007)(6666004)(6916009)(4326008)(5660300002)(8676002)(8936002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2RTQmJWSG5EOFpZUjErM1Ivek4za1pBTDIxUEQrQU9PRmFiR04yQ2JEenRK?= =?utf-8?B?SUhxUk5aWW9wVmdVbmlGdGpoWFQzdjIyZnAvbjBGSjlkdzJvRHUwQjlBZndy?= =?utf-8?B?dnlzWlViRUtGS0VTZzFvbDBSTS8wVExEVDdCbWlPcmtibS9Na2Nud0ZEQUdn?= =?utf-8?B?V3dkWlU0RDMyaHExVGpHbHpvS0lhTGRuTjBRL1B0UisxTk5hWUlHM1hqS1F6?= =?utf-8?B?eEIyQWhOWUU0Sld2UlFTaUdGZUt6Y3dGUlMvRXBUbkErS1I0UUtmYlZ5TVN0?= =?utf-8?B?L0pRQ2JpOXNjbW1HcVl3ek9rcGZ6d3FMUXYxbWZwMkpuUll3WWFydFdlSWxl?= =?utf-8?B?WGJOakVWenpheTBJamdLOE5uOTdqWEhVNFVyWFp5U1ZCSXZVRjRRTm1QZ2xs?= =?utf-8?B?YlVESEsrL21wSmtMajZuS0tIeWExajlSSVVEd3dFRDVpRnh2SWpNUFVUT0Nq?= =?utf-8?B?aTRoU0F3WlBFcm80UmhEcHcvZVpybWFJOEp5UFVnMXN1OXUwSTVvcGlCT3Bl?= =?utf-8?B?WmNMQTM2czNCQ0lEWVZiWlNqY1Qrb1R1WHFucExSOE1OUjJzcVE4aUxodGFI?= =?utf-8?B?aklRNzJ4elhtNStVMnMwanNyRlROdnljUWRCZHNCa0FZYTYvWHVudmxxazJu?= =?utf-8?B?eXZ0b2JxelRIbU52cDM1M21WWEM2cCsveVdIY1dYRjFIYUFiRFFQbW9qTXUz?= =?utf-8?B?Z083NWg1ZWVWYzJ2ZTRLOFkrRWFxZWtQMHVXYm9NbzJ5OFRVTmlHVnRYU2d0?= =?utf-8?B?L3FtK0pnOUc0Q3lzZWtwUEI4bWJqOC9pTGJsMElRbDJ6Wmt6OUwyRVpYbTdy?= =?utf-8?B?bW9LdkZKWXltZmYwV0VmWGZReUVOblU2cVM5cHlNODVkQmxCdWlVQk15dUVE?= =?utf-8?B?Wk9HTG5uZDFveTdlLytOZlk0SXZvdzVKWTZYZFErdDBRMW9tUytoTGNOUVBt?= =?utf-8?B?cGpTZDJWSlN1dzIvSDNpTkxMMGhDVmhYMDJBRnRnZnE5M0lZaG5mNHlobEth?= =?utf-8?B?ZXFmZnByM3lDeDB2aUFxZzBJUjh6YWRFNVhaSVBMVGJYeEg1cG5jZG1sNHVt?= =?utf-8?B?TldwQXlDWWRzcTZIWHJreWhYNXhiK3VId29HQ3YzOUFIWXgrT3RBSU40YW5H?= =?utf-8?B?dEFoem1FWFBRbnh3YTQ3NGx2eHB5WkVCNHFaUHRDVlJQQy9ORCtjNGZaaEFm?= =?utf-8?B?dU0yRjYxUkVtTC81bHpNTVRVVElUWWxzVkJTZXdIbndIS0hmYUhJN3FCOENi?= =?utf-8?B?V0hWazdpZjFpdVEvbDJSR1E5bG9pM0N5c0crVlVIcnlheDFoSXRZNzhTdmNU?= =?utf-8?B?RWtGOWFtYmd4b0RXclhnV2pldElQV2U0Mnh5N09KZktiUHdFaUdycDJGeDZn?= =?utf-8?B?MzY1Y1JoMnpwRnM4cGVvQVVFVFFqY2ZucXhTZ0x4Q3orT2tnT2h5VG12NGtM?= =?utf-8?B?cHo4d3FIUWU1NkQ4eThqQmRpYk44b2Z6MlJVQlExMjlwWjFVTTVFSU80UHBv?= =?utf-8?B?MUJMa1ZkWEEvdWoyVVc4OWVSSzA5RnNacGh2OHV5MmtpM003SEJ4dzhsSklK?= =?utf-8?B?aWgrL25wc05kWFdMN2g3dFpmQnZDc3QrTXdyMTFETE1EdmJjZTFSRW9TUzJJ?= =?utf-8?B?ZEg2VUFQMXRVc0JPN29HZ1MvNk0rZ1VyaXVGTDVrSnhvMFZySUdaS0JQZ3pi?= =?utf-8?B?dGt1VmhXeGEreEsxR0xUVWNCZDdZb2dHY3FhdlhxS2JHMXMrcmZwOVBFVjY3?= =?utf-8?B?b3A1WlpqMkVNYmY0TnFaVTJEM2FzOGNFTVcydS9PUzA4YnRqUEoxbEpoazN5?= =?utf-8?B?Q2E0SFVpR0hFeUJNUWN1bmphWENOejA5dHgxQ01XZEtoNXVsWXladjlISGdJ?= =?utf-8?B?cUVRV01ISDhaUENzcXdNUjBmQ012VWRDNTR4aGV6dCt0ZHdrOTdsOUVoeFcv?= =?utf-8?B?L3luVUcrTnZuQXQ0Ri94aCsyRW5DUUpSWkNyVG5pVU93MmR3NCtTVy9NUU1C?= =?utf-8?B?dDNDa0dtZGpuT0dFaE1QQmFBOTBUMmhTK1dmbHZvRmVEOVZZTnppR2I3VGlk?= =?utf-8?B?aSsyakhWbEZBamcrVWZBSllOblN1ZWJicStDbnJCUW9hb2JvYndwYUxVbkU1?= =?utf-8?B?YTVncjF6ZG1tcWRSaWFHMmNNcXNxYzRBbk1yZXVpMTRLbEFtd25YMXd5UHVh?= =?utf-8?B?Z25tM0NUUnFqQldYd2ZJcUFuRlU4UHp1QXpHT1d4SXczMkxkNGlITnN4VnFM?= =?utf-8?B?bGQ0bUJjdmlUWm5EVzB1TGxseE12cXgwcVZhUlhKSm5RcU84MloydGlERFhM?= =?utf-8?B?Q0ZzcEd3NmpKaHRXbThsL0MrSTBjdXg3ODdZWWRwMlN0SURxdnRVdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4f3ca8f-63ed-4120-9538-08da3748c1b9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 14:31:25.4947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tzQjbX8J6/IRuKYu5YGDZ2rdf1mdEQu6e+JtUYGqf7VfuuCqQT59Z8ccF2/uwb7iWIzr1fO5dQekSrdmpaPa+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3868 Booting with Shadow Stacks leads to the following assert on a debug hypervisor: (XEN) [ 11.625166] Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 (XEN) [ 11.629410] ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- (XEN) [ 11.633679] CPU: 0 (XEN) [ 11.637834] RIP: e008:[] flush_area_mask+0x40/0x13e [...] (XEN) [ 11.806158] Xen call trace: (XEN) [ 11.811255] [] R flush_area_mask+0x40/0x13e (XEN) [ 11.816459] [] F modify_xen_mappings+0xc5/0x958 (XEN) [ 11.821689] [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 (XEN) [ 11.827053] [] F alternative_branches+0xf/0x12 (XEN) [ 11.832416] [] F __start_xen+0x1ef4/0x2776 (XEN) [ 11.837809] [] F __high_start+0x94/0xa0 This is due to SYS_STATE_smp_boot being set before calling alternative_branches(), and the flush in modify_xen_mappings() then using flush_area_all() with interrupts disabled. Note that alternative_branches() is called before APs are started, so the flush must be a local one (and indeed the cpumask passed to flush_area_mask() just contains one CPU). Take the opportunity to simplify a bit the logic and make flush_area() an alias for flush_area_mask(&cpu_online_map...), taking into account that cpu_online_map just contains the BSP before APs are started. This requires widening the assert in flush_area_mask() to allow being called with interrupts disabled as long as it's strictly a local only flush. The overall result is that a conditional can be removed from flush_area(). Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to local only') Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- xen/arch/x86/include/asm/flushtlb.h | 3 ++- xen/arch/x86/mm.c | 8 -------- xen/arch/x86/smp.c | 3 ++- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/include/asm/flushtlb.h b/xen/arch/x86/include/asm/flushtlb.h index 18777f1d4c..a97b3a2327 100644 --- a/xen/arch/x86/include/asm/flushtlb.h +++ b/xen/arch/x86/include/asm/flushtlb.h @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) /* Flush all CPUs' TLBs/caches */ -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) +#define flush_area(va, flags) \ + flush_area_mask(&cpu_online_map, (const void *)(va), flags) #define flush_all(flags) flush_mask(&cpu_online_map, flags) /* Flush local TLBs */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 67c0427963..45235c5aa6 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5066,14 +5066,6 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) #define l1f_to_lNf(f) (((f) & _PAGE_PRESENT) ? ((f) | _PAGE_PSE) : (f)) #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f)) -/* - * map_pages_to_xen() can be called early in boot before any other - * CPUs are online. Use flush_area_local() in this case. - */ -#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ? \ - flush_area_local((const void *)v, f) : \ - flush_area_all((const void *)v, f)) - #define L3T_INIT(page) (page) = ZERO_BLOCK_PTR #define L3T_LOCK(page) \ diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c index 0a02086966..2f4e98cec9 100644 --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) { unsigned int cpu = smp_processor_id(); - ASSERT(local_irq_is_enabled()); + /* Local flushes can be performed with interrupts disabled. */ + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && cpumask_test_cpu(cpu, mask) ) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Mon May 16 14:33:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329916.553211 (Exim 4.92) (envelope-from ) id 1nqbn6-0006PO-8G; Mon, 16 May 2022 14:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329916.553211; Mon, 16 May 2022 14:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbn6-0006PF-44; Mon, 16 May 2022 14:33:44 +0000 Received: by outflank-mailman (input) for mailman id 329916; Mon, 16 May 2022 14:33:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbn5-00065Y-5H for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:33:43 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ef8ab06-d525-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 16:33:42 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C33171F9F3; Mon, 16 May 2022 14:33:41 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5E6F32C141; Mon, 16 May 2022 14:33:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ef8ab06-d525-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652711621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fVjlG4/dfH2RJ8QOIc+qrGCmgCcjOpZB+KPjtLQbhUo=; b=g7zXCdiW66+ZORh6/+b42qlwXs71YIm78eBo2DkB+6yci0VblhfjN32vYqq5tvyFP+a35V 4IQbZk+eZ8m4N7dIzfRZvRcjGflhdk2pzgpwxTPHHTNBIE+W9GZV3Zj3ggNIRkQibkb0ZX yDFspItfCnZ03JfIlqNkkDR8LZU/GbA= Date: Mon, 16 May 2022 16:33:41 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Tony Luck , Vasily Gorbik , Wei Liu Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-22-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:15, Guilherme G. Piccoli wrote: > This patch renames the panic_notifier_list to panic_pre_reboot_list; > the idea is that a subsequent patch will refactor the panic path > in order to better split the notifiers, running some of them very > early, some of them not so early [but still before kmsg_dump()] and > finally, the rest should execute late, after kdump. The latter ones > are now in the panic pre-reboot list - the name comes from the idea > that these notifiers execute before panic() attempts rebooting the > machine (if that option is set). > > We also took the opportunity to clean-up useless header inclusions, > improve some notifier block declarations (e.g. in ibmasm/heartbeat.c) > and more important, change some priorities - we hereby set 2 notifiers > to run late in the list [iss_panic_event() and the IPMI panic_event()] > due to the risks they offer (may not return, for example). > Proper documentation is going to be provided in a subsequent patch, > that effectively refactors the panic path. > > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -2163,7 +2162,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev) > int dberror, err_addr; > > edac->panic_notifier.notifier_call = s10_edac_dberr_handler; > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_pre_reboot_list, My understanding is that this notifier first prints info about ECC errors and then triggers reboot. It might make sense to split it into two notifiers. > &edac->panic_notifier); > > /* Printout a message if uncorrectable error previously. */ > --- a/drivers/leds/trigger/ledtrig-panic.c > +++ b/drivers/leds/trigger/ledtrig-panic.c > @@ -64,7 +63,7 @@ static long led_panic_blink(int state) > > static int __init ledtrig_panic_init(void) > { > - atomic_notifier_chain_register(&panic_notifier_list, > + atomic_notifier_chain_register(&panic_pre_reboot_list, > &led_trigger_panic_nb); Blinking => should go to the last "post_reboot/loop" list. > > led_trigger_register_simple("panic", &trigger); > --- a/drivers/misc/ibmasm/heartbeat.c > +++ b/drivers/misc/ibmasm/heartbeat.c > @@ -32,20 +31,23 @@ static int suspend_heartbeats = 0; > static int panic_happened(struct notifier_block *n, unsigned long val, void *v) > { > suspend_heartbeats = 1; > - return 0; > + return NOTIFY_DONE; > } > > -static struct notifier_block panic_notifier = { panic_happened, NULL, 1 }; > +static struct notifier_block panic_notifier = { > + .notifier_call = panic_happened, > +}; > > void ibmasm_register_panic_notifier(void) > { > - atomic_notifier_chain_register(&panic_notifier_list, &panic_notifier); > + atomic_notifier_chain_register(&panic_pre_reboot_list, > + &panic_notifier); Same here. Blinking => should go to the last "post_reboot/loop" list. > } > > void ibmasm_unregister_panic_notifier(void) > { > - atomic_notifier_chain_unregister(&panic_notifier_list, > - &panic_notifier); > + atomic_notifier_chain_unregister(&panic_pre_reboot_list, > + &panic_notifier); > } The rest of the moved notifiers seem to fit well this "pre_reboot" list. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 14:36:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:36:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329932.553222 (Exim 4.92) (envelope-from ) id 1nqbpO-0007Kk-OX; Mon, 16 May 2022 14:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329932.553222; Mon, 16 May 2022 14:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbpO-0007Kd-LR; Mon, 16 May 2022 14:36:06 +0000 Received: by outflank-mailman (input) for mailman id 329932; Mon, 16 May 2022 14:36:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbpN-0007KV-9P for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:36:05 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 823f94a1-d525-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:36:03 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 10:36:00 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB3276.namprd03.prod.outlook.com (2603:10b6:4:3d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 16 May 2022 14:35:55 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5250.018; Mon, 16 May 2022 14:35:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 823f94a1-d525-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652711763; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VelAr16gQkdS2h7+lXd/Jx3r+OjUQ+LTIR0LUrSWmnY=; b=TTZa4nzkDdbbluqtMVF/pLMrXIbq/rCBmDqbFWqzgBdhmsIUZt0fuqTf 2zWgoWAL8d7QyA/NVQyvMlx1yG2M5xL55GdekUhbff6+YM/WymR/RfNEq 398PR7xLYAhQ2c2G9uXKt+hlMopCTZGra5JJri9UpWOIofC/9EZGdYOen w=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 71416133 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tKzvF6qUxJwwKNuZinketUPhH1xeBmJsZBIvgKrLsJaIsI4StFCzt garIBnQP67fYGDyKo91ao/n8kJUuZLXy4A3GlA5+So3QywW9puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 I2q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHpDXt+48SgtiNzxYYvZh2qebPHOmiJnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2Z0m8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/PZuvTGIl2Sd1pDwasfRfIe3SPlK3WeAt 3Li4GrCCEwzYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K UYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJS1e2W4q/d4gLcDG5USDdEMYUirJVvGmFs0 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poad9e3Yq 9xSkBUDug== IronPort-HdrOrdr: A9a23:RmSecq/fpsK+7Yi9quhuk+AoI+orL9Y04lQ7vn2ZKSY5TiX4rb HIoB1/73XJYVkqN03I9ervBEDEewK+yXcX2/h0AV7BZmnbUQKTRekP0WKh+UyDJ8SXzIVgPM xbAs1D4bPLbGSTjazBkXWF+9RL+qj5zEh/792usUuETmtRGtBdBx8SMHf8LqXvLjM2f6bQEv Cnl7N6jgvlQ1s7ROKhCEIIWuDSzue76a4PMXY9dmYaABDlt0LS1ILH X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="scan'208";a="71416133" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3dsy33Fp1G96kQyxL68JdnIDyFnvnkg0W7uIieKplZg83x9wtyGs4PK3MqOMzBfPUoIO9W/tVRQHFFU+HSaP34lvqdfWTOn1vU7fwzgtK5XnYhj4AClhoXr06/8JvscrXptw4ChvC5BJPvG2B99b0t/avK+iaPfeRuux3zjpEL8EeciYF6s/CE40399EVrUknTE/LHa/bt+62uPyXnChwmHO/8yPKilUNPerm1xPa2Nczq9plUro3LhNl5bObFxvmw2HKJSQiW+iqazvBXg/1TbsUPW3GpAG57MBHgqIuSfbjvJvuKjpZqQ9N7kDWl/98QRaGrDDV+Wo78OxrqJNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wYwSixQBsJZHpMQPn0fIJRbLojA7zqoX+KlqNPLdMAc=; b=cPlqcVRkLlWRnqsInv+eyqW9veegDUiFpLEVH5BGk0OMyfshNsIBeTrOMMx3zNrh1lovv4iaLumv41AVS6KSA78ff3H37kMQTJdoMybpfl4M0nUGGLvHjcXidVW2v0ybJUvydlpnHuuUIFqeTPRJ10xbWYq1+C11ZVOMqDtWJMQ1n5RosZh/yS8u31LrZx6fVeusUA5FwQOrCaBKyY0p3iECfJg3H2f508kHDCA87pX468ls5XpXliyjuwmqWMMG5uPWrnlfKRGrjA8C3Yd5hxlJ1G0ukWkOb/0NsFVrCKV7sjettX12COUKDT59Q+ld9iW4h3u0nxxIEx5nd2uduA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wYwSixQBsJZHpMQPn0fIJRbLojA7zqoX+KlqNPLdMAc=; b=vPtbJtrC2pIUf+DPFCFrhQxs+E2lL63sHeAnAkhJDdKKBl4Lu53h6l8vcbAQvn481DtoYbXNGiJBujcdXt6++ifovOYn2xqzBQrqLrFz00wYvPaEBhfcC6FSuETk3w83qx0wvJVoRqERbYyBnnISOGA1KyzWArEHPV1Q1r+jR5Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 16 May 2022 16:35:51 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/setup: delay setting SYS_STATE_smp_boot Message-ID: References: <20220516111203.26463-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220516111203.26463-1-roger.pau@citrix.com> X-ClientProxiedBy: LO4P123CA0114.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::11) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3d9a54a-4932-47d7-7d11-08da37496254 X-MS-TrafficTypeDiagnostic: DM5PR03MB3276:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k/2xpPMZDyk41PlErEX2/s5vASeUyeu4E5NI3r4ZiLzYsCFYZcjI8fTRsJ7PUKuljbdyP0nDirUyIypt6pjuYjSiDmJCBUAv+UbcAcXzlJhwq6QagGQs7xL76ETf+loekD5few2CIGYzIBsQRABeTFv0yFM35LgoKiDmXdVeBizjWCSnXxkELgbh+RQtijDoceqJteJaHJFlq/3ospNAm8h4NB7fw/LnZK67TZEHJLahHXRT83RQt7edp8k4xxsOSjFyabFD4vZPX7Va9fUIiSpVC5ZwyNCyG6XOQ19f/IMXxnGPlB+qoIDDUdCvQY0lEGafBNqeOYJ8wuMgugxxgWJcuIO5RJlj2b/Wc5HdnjfTr0fXSozmzqfIA6RIyb8ES6cau5jN7PMyAMyojTHBXNwxTOcwlRGxLBMamqtOCdivEwnwf5hOpBPG/Tt/Hk5HF2gU5ObLpvuWwEG3lqFx+f7tv05z/YXvu8sJG1u1U+jOfnMOULj2HD4Bno58qcGG2LiFhidbOG5gXOnAS4MvyhSVpCixG4NMY0TMsoMXCheZvpo/eth9piSGdVZ046ZS3dURSi4QSIqG813D1q1EFWXxGQUxpLj6eBTYZ7SNBMgTAf6vME4upW3kBRBDAnhT3Qxu93EnB7b1S0KEpT8IxyQ9vZSmM78e9Sdjt+bThaV+Yg98RVlfplL1yP74MtDoHWc1bymtTJMFTG+JMDKqTRrleNs+F7yTTJ9eaH5JQPE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(85182001)(6506007)(6512007)(38100700002)(2906002)(82960400001)(9686003)(33716001)(26005)(66556008)(6862004)(66946007)(6486002)(966005)(508600001)(6666004)(5660300002)(54906003)(8936002)(316002)(6200100001)(186003)(86362001)(66476007)(4326008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0lPSkcvVkhBYmVVM0RJbWxBWDhCZU1kdnVMUHN1TFBGRnZKc0NuMVBJcWVt?= =?utf-8?B?blJEQ0R5dFlyMmx1ODlLV29RYmlVb1ZBVElWOVlrY1I4Q0crc3BiYUE1RFVH?= =?utf-8?B?eE8rQ0hKVWtRR2svZkx3ZVMzSmI5ZlFKbVIxdDRCcEtHbHQ2Q0ZGSVh4cnAv?= =?utf-8?B?N2ZDakZlZHpKZ2h2cStKZWdZNVJvUmJmcTlxQjJESzdzbWRQMnBXZzFkVDBw?= =?utf-8?B?OVNSS1VLdDJTdVFVNzYxTXNvQXdNbktxZ3IwYTc0Tklqa0tDUDU5aVdFZVE0?= =?utf-8?B?dmVYcko3anlSVzFndVJHWVhmMVhKNjJxOEkzL2hnWWRxNHRWUEpXUGdUR1hr?= =?utf-8?B?YlNCMHI0eHNZZ1l3T0hBOVZxRmpuSHBVSVZjY3RKQTNvS1FmakwrVzhSUlB6?= =?utf-8?B?Q01rQ3JrT1BHTlBlcU1yNDJSOE1wZm52aGNFeEZXb2FFZUh1Mk0rODdMOUVK?= =?utf-8?B?L1BFUVZKU05VWmFTQ3Ayd0Z5Zm1QS1BWRmROaWY3eTRLZkU1Y0dOWjRtN240?= =?utf-8?B?ZTFhVFlnWHovZ000a0wvb1hZU0JoNnpPTzhNMlNFVW9yd1pLbXJ4WjZSd05o?= =?utf-8?B?cUF3by8xclBQL2U1Sk9GaE9BamVwTjRyVTlCOWtkWGxVSWFVcU91TkEwN1ps?= =?utf-8?B?RnBka1FnL3JLczI1Q1Z0N2wwSEtzWE1KM0dBS3Z4YWMzWTRtYitlUEM4MTNW?= =?utf-8?B?QXRmcXNOWWtUV0l3Yk83elVaWm5OVXBxbVNWKzBPWjlmODAvN0VmQnBLOGpq?= =?utf-8?B?UjNmZG1rSVJsWXY1SnJJNmtmcjBTd3dBODd4U09za2lyUnphUTlyZHZIKzR3?= =?utf-8?B?SDltU1JmQll3L1M5MDk2ektRMGsyMVZnS21hQWc3YTYzMlhzS0RxWXdQQjZJ?= =?utf-8?B?ZVNzakZSQi92N0tpSmh5UjRia2h4K29PcmNQc0k0dkduSnVMYVJHN0l4MExZ?= =?utf-8?B?RHdHREQrRjJvaE9zRG1HNHJ2MjRPQnVHYTVwRXhTZVUxRXpmNC9LdzBwTFVZ?= =?utf-8?B?WTJJSHMxWUVBWWJFWkpTS0dPcWN1YlN2ZGFBWnAxVE1KaVM5Q0ZWZ0tESmwr?= =?utf-8?B?eVkrdFRjakZYTTN5REplU1BkQWdnbWpyTHJGT21oQzF5T2IzdXI5blBCRTNB?= =?utf-8?B?RmgyL0xtZUtKeHZqNFk0Qnd6NS9aMnNyQTRyVTVMQ3lCQWl0MmE5K29WVytm?= =?utf-8?B?b1o4UkJOYWJqYkFteHhjY1MrcnhocHhJcFdtbjVlcmlDN2lEQ2VnaXNQYVYw?= =?utf-8?B?aWpEL0lURHVjeHhLY0hqQWhENDh5N3F4T3VXc2Q0ZGRPUEUyb0NrQXVDVVl4?= =?utf-8?B?SVJxUGc4TUhxcHVSVVlZMjhlVlNmamhLRG1paUtJM3ZKSE9TTkVnTnRLMHZW?= =?utf-8?B?dWwxT2NZbkJLZU54SjR4RXVkNlFGUUh4NElkaVAxZnljdWkvcEhramMvREtv?= =?utf-8?B?Y0p5Y2gxQ0FYTjI3Qi9POXl1Z1laV2tyOG1td0VGdkR4UDN1WGZSRWkvczZk?= =?utf-8?B?bWtJNWNjTVhTeTNld2dXS3FuUlphRjlXMkF0VEZxUldlSmVDd2dzMXQzZWNH?= =?utf-8?B?eUNzTWN2a0dSSXNUV2I4YnJIUU1HTGNOUkZUTnIzWXhGQnlkbFZVUGR2UjZ3?= =?utf-8?B?WWFadndocGhBSHUvbEdNQmRoenV0dWF3cUlqOFFjcFN3Wmo2RWpyVkowdHpk?= =?utf-8?B?Rm51dVo0L0NPUkkyN3hrajRwQlhPanY4MWNvNnk4S0JWOUJ2SVU5V2Q1V2FJ?= =?utf-8?B?SmEwUXI1VjV5a011ZFBQd2hwMThjenFuNi9BZ3k5S3hieEk4eUYyU2NQYzRD?= =?utf-8?B?bzFmdm5LTGlaTlRiY0tIZHB3aGp1RlhMMmp5aGw0Rjd3ay9WYnBldVVCdXpw?= =?utf-8?B?WUUzQjF1TW81Y1p6UHZTSDFuWW5vbmNxWWtsdUtPZXZOQXdrbTBiMUJwQjJw?= =?utf-8?B?dTZLb1ZGWEFIcnp3KzhZTTl1SWlhbkJxanBqbC9WOURlVUhIeTlpemVGV0du?= =?utf-8?B?L21pdTF4eEY0cTdkZWVyODNTTEZjMkVJS2szNUo1RUhHTGRYMWo3ZzVMWGZo?= =?utf-8?B?Y2x2SWp5ZlNxTGhVK3N1LzhHTFA3blFrM2VGbjFNUEVKMHpDY0t5czNXRERh?= =?utf-8?B?UTdKcjFFdHpZVWxpajRkUkcyRVV0ZExDbE1kcmxsT1pYWUc4T1IvUHVUbXFj?= =?utf-8?B?d3lSTE5aYXpiUEJkMTBRdENhYS85NEZQaFBUWlJRNk5pQk0yTnJreDd1ZXo4?= =?utf-8?B?WE5lcElVRnhnUTliT3ZuSkhJU1d6SmpiMWFZRmlOc3Fxby9IejlwYlhmTmZG?= =?utf-8?B?N2M3L1JaVEhNbHdBODJwa1NYc295TW9ERU5nZ2xGaTNESHVOdHIrcldlVGVC?= =?utf-8?Q?GfouBF0dSecSpXYU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3d9a54a-4932-47d7-7d11-08da37496254 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 14:35:55.4608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U7VWn2dTdKJuIVNuFj4glrZhrLn6+DSpGPL7wT3HvRwaWTq9XOzmM4wkE078mJjJQ1KyxnVu5jOjNknZHaw6mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3276 On Mon, May 16, 2022 at 01:12:03PM +0200, Roger Pau Monne wrote: > Booting with Shadow Stacks leads to the following assert on a debug > hypervisor: > > (XEN) [ 11.625166] Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > (XEN) [ 11.629410] ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- > (XEN) [ 11.633679] CPU: 0 > (XEN) [ 11.637834] RIP: e008:[] flush_area_mask+0x40/0x13e > [...] > (XEN) [ 11.806158] Xen call trace: > (XEN) [ 11.811255] [] R flush_area_mask+0x40/0x13e > (XEN) [ 11.816459] [] F modify_xen_mappings+0xc5/0x958 > (XEN) [ 11.821689] [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 > (XEN) [ 11.827053] [] F alternative_branches+0xf/0x12 > (XEN) [ 11.832416] [] F __start_xen+0x1ef4/0x2776 > (XEN) [ 11.837809] [] F __high_start+0x94/0xa0 > > Fix this by switching to state SYS_STATE_smp_boot after alternatives > have been applied. Consider this patch superseded by: https://lore.kernel.org/xen-devel/20220516143116.28602-1-roger.pau@citrix.com Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 16 14:46:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:46:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329943.553232 (Exim 4.92) (envelope-from ) id 1nqbyy-0000O1-Ow; Mon, 16 May 2022 14:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329943.553232; Mon, 16 May 2022 14:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbyy-0000Nu-M0; Mon, 16 May 2022 14:46:00 +0000 Received: by outflank-mailman (input) for mailman id 329943; Mon, 16 May 2022 14:45:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqbyx-0000No-AQ for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:45:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5a9afe3-d526-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:45:58 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5CE0A1FB39; Mon, 16 May 2022 14:45:57 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5A0982C141; Mon, 16 May 2022 14:45:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5a9afe3-d526-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652712357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tG6HOQkoWV3PTxPtSaDR17RqhX4V9rIOdD2egRcz4EQ=; b=gFEwFsAV3UIKYYLVyI3mrLhX3TiIMpl9yPWRGPgk48WclnmFw5gYn5O+dNvzDdNjqF+pxI IMKpGcGZV7FxvMc95tVdofmJAGyq2tRsWSZoEHDpo+UshHGwcUByHkHpUxr0BHmW9i2Opl sUtunVb+gn6OV1DjkoM9JYfMJE7YMOM= Date: Mon, 16 May 2022 16:45:56 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Christian Borntraeger , "David S. Miller" , Heiko Carstens , Sven Schnelle , Vasily Gorbik Subject: Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-23-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-23-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:16, Guilherme G. Piccoli wrote: > Currently we have 3 notifier lists in the panic path, which will > be wired in a way to allow the notifier callbacks to run in > different moments at panic time, in a subsequent patch. > > But there is also an odd set of architecture calls hardcoded in > the end of panic path, after the restart machinery. They're > responsible for late time tunings / events, like enabling a stop > button (Sparc) or effectively stopping the machine (s390). > > This patch introduces yet another notifier list to offer the > architectures a way to add callbacks in such late moment on > panic path without the need of ifdefs / hardcoded approaches. The patch looks good to me. I would just suggest two changes. 1. I would rename the list to "panic_loop_list" instead of "panic_post_reboot_list". It will be more clear that it includes things that are needed before panic() enters the infinite loop. 2. I would move all the notifiers that enable blinking here. The blinking should be done only during the infinite loop when there is nothing else to do. If we enable earlier then it might disturb/break more important functionality (dumping information, reboot). Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 14:48:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:48:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329951.553244 (Exim 4.92) (envelope-from ) id 1nqc15-0000y3-5P; Mon, 16 May 2022 14:48:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329951.553244; Mon, 16 May 2022 14:48:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc15-0000xw-1c; Mon, 16 May 2022 14:48:11 +0000 Received: by outflank-mailman (input) for mailman id 329951; Mon, 16 May 2022 14:48:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc13-0000xS-5Y for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:48:09 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30ab11fa-d527-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 16:48:07 +0200 (CEST) Received: from mail-sn1anam02lp2044.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 10:47:24 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB4596.namprd03.prod.outlook.com (2603:10b6:408:6c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Mon, 16 May 2022 14:47:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 14:47:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30ab11fa-d527-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652712487; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GrZuouA6oEommE4sLjASyksaMTj+J+pY0ygEu41Tl/E=; b=e7LzdMoVp6ZzIEVMCILuKiO0aq69ErqRZqjXMsLDgE1pqQevB7Bq1FoI 9v21qvWk2DfItGzpJKgs854IVBg9/2eSKLecwRlXbAO6Swu9mLBeYJJKd AWCtmsUYgziKXXF76gq15I0+7vnmsWYzppl8YVJcrcYFXeX6ED/FKTuGW c=; X-IronPort-RemoteIP: 104.47.57.44 X-IronPort-MID: 71271839 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:75ZUU6/t9RWB+W36Q5DBDrUD8n+TJUtcMsCJ2f8bNWPcYEJGY0x3n 2BLDWyDP/7YYjShedpxOo3noRwGu5fTxtNrTQdpryw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHnW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnayTRkR2Oq3oo90AWBRWPDsmAq5+xZaSdBBTseTLp6HHW13F5q00SXoQZMgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvqMuYMwMDQY36iiGd73Y cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgA3M//VuszOCpOB3+JWzb8uWXfuPfNtIv0GAu GzdpWrdPQ5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUHBBqlz6PV50OCADENSDdEMIYirJVuGWBs0 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poOlcd0s6 1hmdBQDuog= IronPort-HdrOrdr: A9a23:gyv/D6HLTBONcVojpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M= X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="scan'208";a="71271839" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gY9fGxznmxu2pna5gMyicrakYkbeOEdWer/kJTds3Xe0Cz3qph1TSxQmScXfsmZGaVr6OvFoiKtEXivjlDrJ68MNidQ9DCgWUjSn71icAxAES7oGIOGe/+yJWYGxouHonzmLOGvEkbWBLqkjiLlek3YP8YuIrfp32xLtLH0+DiL5HOMPbmy14Xghi6Gyk8ivqzyT7XoS4/mn8LpPgUPuFeHFdpQ099uX2SdMX3+SYCGdMhTc3ggZ6IIatWOSXnqkxvz5oZ4dPOvtg4D2GeM/C4OOfFxYNXXCIxbYgw/EOSw5vAl9TpLJwTYl+1hanG6XIOzjdeBE45OEIXJQD4w5Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GrZuouA6oEommE4sLjASyksaMTj+J+pY0ygEu41Tl/E=; b=CcXgpDZIjiJ7cizXcs5xDrJgqukYMld70DE7kHa1R7nqLgN2hEbNW32uaMR6FXwdBa0ERWaIVOxhYhEyEVe15w3f5T6TwTXBf5Vg4jxz11BfeAIQPHIdxzzJrJgAsmkAtAVRn7DZd1M5lGvPAdBEYLEWTfZoFhMsZonlqZO2Yfluz3KDqTkgb9FvrCVK2WBa7zpg3x2Yjf7WNmEZOb+Lq1/1CdTM0H6oLGINLElsMj+bpAru+TcUATemWB4aAV0Krl1o0h1sm5tAgCRavIiPk2c4qpn83OD4s5vUrq0xRLQyKHZXjHr78vnvioW87QlguE6LEPJ972Kgr/E9I1fSYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GrZuouA6oEommE4sLjASyksaMTj+J+pY0ygEu41Tl/E=; b=UQwRk4DeqIPocIyL3XK8b4I2Zi8NmgOUPR1XNqwZSXofAgtcApSdy3rTSgDDKdrKGPcQudYJU+nQStEdbruKVj9XIfwiqQ6+swk4wD/wICBVGv/PvTsglGjG3ZJqCCgAC0wwv0ThfRuvJqQB3YTAOwCuB8CS916Setrn77d0500= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Thread-Topic: [PATCH] x86/flushtlb: remove flush_area check on system state Thread-Index: AQHYaTGgFt663HYNJUGkqeLNHlrlz60hlU0A Date: Mon, 16 May 2022 14:47:20 +0000 Message-ID: References: <20220516143116.28602-1-roger.pau@citrix.com> In-Reply-To: <20220516143116.28602-1-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f8107ad-7e73-404b-2785-08da374afb10 x-ms-traffictypediagnostic: BN8PR03MB4596:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ji3ercK24xTy/+meEpLfzaDqZvzT1e8n92hCrZySTK9jnYQ0d4r6C6/Liil6Rn3XXnriuq2LqSs/V5ZxVqPO0vHRZBJikAqk8lCIFiK0L0snCen8UC6Tyvkyw0HYhkhIMWAViPZTG7mChEP/Zg+T1sQPO3HzY8A3qPnm+mIWAwFPpiuB25Bzugy9eoZFZ8gSC3tWSgzym9JnxvKtSsTvOppFuitok75KzPGuOMDp7FrpVmrSvhNllCiRPzIoUWvdbG+CX8/1Gr/oomOLEAfJQpBdyoBAwWe2AJpsZEg/KsiVXtmVGo58D5RDIs56bJT26O59ZvdoTsqC48Cj/7zMY8c/d/nGOC6OtXopWrsOyExgjDQMfgKnX9a3IBCeOfi4Rwao87DIc7lQ6zoYOdK6/73QCz3vZDwOHAj+FSONI71okgC+MsNoD16nOlyq99y8AMm7uc965a05g+rBb8VevSi8pSyMKQDlYA0fhciqeH8cXY2nWzBXMv+AXqIvWTME68YYMpekFFXqGL42P1Tjv1eeezXKE02O1sOKR3ZXSgdSmbX6pVZUGfEVzEjUIsJc7a2WtxCWHqIEErq8+KFwjp7+Ta1vWrkiKc/Q7jwq/0h2Uzo0ieG86/r8gFkrbjrLqyGxGG6DgQY0McQ4FNNXWsUe2AEbAjng5KJU+v/lF/+NnwVHbIEV8EaBh9jyDLLJeEkguvkxh86qXVshLw7cU3e/71ylurrbqE21CYXL9XabrP6K38RfWGwHWsjKzMYQajwv0kgllP7htDLVK3eFmQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(110136005)(316002)(38100700002)(83380400001)(26005)(8936002)(2906002)(66946007)(66556008)(66446008)(4326008)(82960400001)(8676002)(91956017)(54906003)(38070700005)(53546011)(64756008)(76116006)(122000001)(66476007)(6506007)(5660300002)(186003)(6512007)(71200400001)(508600001)(6486002)(31696002)(31686004)(86362001)(36756003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Mk15YUtUN2RDRmJKS3hMbStCT3VUeWo4Z0pWaUNLcWtDYmU3cXM3WUxGQVdH?= =?utf-8?B?allna1RtNkJWbDROSGVSTWN4S2NXTUJYN1VKZGdBbEk2R1VHMjRHTTdnZlBP?= =?utf-8?B?Zk0wbk5FdzhFUmRhVm5yeXBEdFZyTlowMVFQaVhXTWRkdHBhKyt6UjMxYlhu?= =?utf-8?B?WDIrczc4eVVCK1cxd09OYTZNdTl6MFZFNFAwV2UydVk1N1o2NTREY3lJaVF6?= =?utf-8?B?eTE4bFVQUWdnT0NMUjQ4bVpxWENMOWVBV3JrZVVOYjdrRDVUa2p6SmFLblJ0?= =?utf-8?B?TWJ2MHpFSnh1ZHRnMEhSUWROZG9TZ3EwNjhTNXdaUFVHaVQ3K2dra2t1aHYy?= =?utf-8?B?Mnp0T3JuRVJTZmtXY1loYTZ6Zkk4bGkyeUs3RXl5NDJzcUt0V0p0RVdUdGVE?= =?utf-8?B?bUVSUU1ZdkdVQjlNUXREYSs3R2xjenhpeTFBWXFBQmFScWFIcUdkMXIxb2p5?= =?utf-8?B?c0wzTUo4cENwejErV3BtTms5VmFuNjVNem96WUdvQXM4MElpWHhTR3BuakU1?= =?utf-8?B?M0E4QXMyUkdEN2NEQTNqdVpNQVE4cllCVDlJeEVCblV5K3RQQW43d2h2RVdu?= =?utf-8?B?YW81dmpWc281aHdQbW9Zc2N3dXlTUXk0b3oxMzJIem1QcHJzaEVBTTJ4dGp0?= =?utf-8?B?Z3hTaXNIV2NEQlVIZ1k1aDBBVyt3OEVaL0VmcEk1ekVEc1ZEaC9SWlVGUFZs?= =?utf-8?B?Z0dYaHVRME1nN1J6LzZGSS9raVVPdCtPKzAvTFFRa3hmZ3hHNDRyQzRKZ1g1?= =?utf-8?B?dUdyT1NDZUVXUTdKbTBEU3pMQ2RXYzF6cm5sMUxuUStXWHllRkVJMTV0QjJi?= =?utf-8?B?b2NqWGwyelhIWFl3M1lVajZ6NUtyTHVlS285czAzZ0NtY1dRZy8rblN4RWYy?= =?utf-8?B?RHRwM1NPYmFrbjM1RzJCWi9NTTE4N0ROWEtBaTZ2WHJXMnloaVYvdnpTUVBi?= =?utf-8?B?NUNsL2txS1ZWaXVXcGU4a0hWVk1WWVk5eGY4aU1RV3lYMDJGYXFva05tTUgw?= =?utf-8?B?RUdjVHU0YklXMGNvNm5OeGdDRW96UUlDK1pOazg1M1NQUnZWYUVUQnp6MkNx?= =?utf-8?B?Rk5NQ1ZuckVOOXQ4dkYvU2FzVm5HWFVMeWpqb3N5dWFKNTZmSmcyQ1c0b0ZI?= =?utf-8?B?andYUG9VeHRHSCtXZHI5bWxjU3VxV2dqaHVqNmVQeFp3TkJuc1YzMlF4Zlhz?= =?utf-8?B?cGZKRVdyRVAvKy9PTThNbEhnQVc0M2VoYXBjRVc2OWJ4aUZReGdtMWtGY1VM?= =?utf-8?B?bDJQZ3B5MGxFZTlua1RySmpKM05idVIxZWNOZEp0S1lmcmlLVVduSlRrUFZM?= =?utf-8?B?djI2Zm03b3FpanRGVmpOMnhINklHbFRJKzdoeWJ0aGFKVjZvdFlWam12amZX?= =?utf-8?B?LzdlNzBCY0U5eGg4QXRDNHhYNWFocEVDNlRpVXlKQjJMcHM1cCthT3E1R3lm?= =?utf-8?B?b2hSaGIrd01JYmxGWThRMXU2aDJvOXJFRElkcEhwb2RzTkF6RzMrVUNtSTcw?= =?utf-8?B?YnJlNEpyT3RZZEdLM2tzUWVSVkYxSFduUGJRaDVFcDlmdWVnNHU2bVRQbkRj?= =?utf-8?B?b2k2d3RYVG1CU3Npb05WQzR4L2tXRkNkS1kwUWVCQ1RVYTRjY0ltRVE5ZlNm?= =?utf-8?B?bnJDS0FNNjRZQ2dqZUR1MFlyTEpPU1JrZFMxb1RMbTdJSEljcXE2cU9Ydi9s?= =?utf-8?B?UlBVWjVuU3lTektvREZ6aVhMY1lxcVhWYTRXOGZNTGdDV1dqdTg4dHFRL1pw?= =?utf-8?B?L1VQMlNmN3B1ZmZZT2p2Q2ZpUEY3MFBXdGxtclpxQW15U2JBVkhPRW42Z3N1?= =?utf-8?B?V0dBV3VocEw3NHNWN0RwYUxwWmt5Z3JYQ2kxVmQ4NFhnd3VoVlQraXlVNkZh?= =?utf-8?B?VGdIdU9CK2ovSUMvMjl4S3VUNEZEUFU5Qm8xVWwrbkJZejNYMHhmWE50d1hU?= =?utf-8?B?dGhwYnBGcmFSTE1ONWllMzJROVVyblM0NUtMZ3BLU2VLQ1RwT3p3SEhEREpj?= =?utf-8?B?SndrTDdIa2tKS0paNUIwamJKRlM5QlJkR0E1V2NZYkgyR1RxVk5UeDg2UitI?= =?utf-8?B?S0RTWng2SjgyUHJCbWp0b2tEMHhTR1lMbzlRRGYyYW5DakxGTUFRNzlGL0x1?= =?utf-8?B?d2ZPZjEzZkRNbzZhNjVoLzNWZWVza29sK2p2N1hUZ2xvWXUxQlhaZUtIQ0d2?= =?utf-8?B?VGFMZ0RSMWRaMmpFWExaWEhMcWtqcHdiQWx6TXhJR2pZblVDc3ROSXo0cWFL?= =?utf-8?B?LzllWnZSOC9IWDZmbTJpRW5pakZ1aHlaZUpKZDdrT01Vb1FNU05OVG1LUzFs?= =?utf-8?B?MWRaWTFMM1ZiUUIvM3pHQmV3WnZweVBWMkl3dWc3aUhSVXN6ZEtnR1FIWU9l?= =?utf-8?Q?0e1HLKytJWalDE5s=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8107ad-7e73-404b-2785-08da374afb10 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 14:47:20.4969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NN0njhalxBridqhUhJ/AzhobVjaTMykt476QD5f929seUNIlkU/JfDqq2ZEo7FLSSILpp1e8YkVUcuPRTXrMfDcYeTMPuh6DmB7MVOkr9B8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4596 T24gMTYvMDUvMjAyMiAxNTozMSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBCb290aW5nIHdp dGggU2hhZG93IFN0YWNrcyBsZWFkcyB0byB0aGUgZm9sbG93aW5nIGFzc2VydCBvbiBhIGRlYnVn DQo+IGh5cGVydmlzb3I6DQo+DQo+IChYRU4pIFsgICAxMS42MjUxNjZdIEFzc2VydGlvbiAnbG9j YWxfaXJxX2lzX2VuYWJsZWQoKScgZmFpbGVkIGF0IGFyY2gveDg2L3NtcC5jOjI2NQ0KPiAoWEVO KSBbICAgMTEuNjI5NDEwXSAtLS0tWyBYZW4tNC4xNy4wLTEwLjI0LWQgIHg4Nl82NCAgZGVidWc9 eSAgTm90IHRhaW50ZWQgXS0tLS0NCj4gKFhFTikgWyAgIDExLjYzMzY3OV0gQ1BVOiAgICAwDQo+ IChYRU4pIFsgICAxMS42Mzc4MzRdIFJJUDogICAgZTAwODpbPGZmZmY4MmQwNDAzNDUzMDA+XSBm bHVzaF9hcmVhX21hc2srMHg0MC8weDEzZQ0KPiBbLi4uXQ0KPiAoWEVOKSBbICAgMTEuODA2MTU4 XSBYZW4gY2FsbCB0cmFjZToNCj4gKFhFTikgWyAgIDExLjgxMTI1NV0gICAgWzxmZmZmODJkMDQw MzQ1MzAwPl0gUiBmbHVzaF9hcmVhX21hc2srMHg0MC8weDEzZQ0KPiAoWEVOKSBbICAgMTEuODE2 NDU5XSAgICBbPGZmZmY4MmQwNDAzMzhhNDA+XSBGIG1vZGlmeV94ZW5fbWFwcGluZ3MrMHhjNS8w eDk1OA0KPiAoWEVOKSBbICAgMTEuODIxNjg5XSAgICBbPGZmZmY4MmQwNDA0NDc0Zjk+XSBGIGFy Y2gveDg2L2FsdGVybmF0aXZlLmMjX2FsdGVybmF0aXZlX2luc3RydWN0aW9ucysweGI3LzB4YjkN Cj4gKFhFTikgWyAgIDExLjgyNzA1M10gICAgWzxmZmZmODJkMDQwNDQ3NmNjPl0gRiBhbHRlcm5h dGl2ZV9icmFuY2hlcysweGYvMHgxMg0KPiAoWEVOKSBbICAgMTEuODMyNDE2XSAgICBbPGZmZmY4 MmQwNDA0NGUzN2Q+XSBGIF9fc3RhcnRfeGVuKzB4MWVmNC8weDI3NzYNCj4gKFhFTikgWyAgIDEx LjgzNzgwOV0gICAgWzxmZmZmODJkMDQwMjAzMzQ0Pl0gRiBfX2hpZ2hfc3RhcnQrMHg5NC8weGEw DQo+DQo+DQo+IFRoaXMgaXMgZHVlIHRvIFNZU19TVEFURV9zbXBfYm9vdCBiZWluZyBzZXQgYmVm b3JlIGNhbGxpbmcNCj4gYWx0ZXJuYXRpdmVfYnJhbmNoZXMoKSwgYW5kIHRoZSBmbHVzaCBpbiBt b2RpZnlfeGVuX21hcHBpbmdzKCkgdGhlbg0KPiB1c2luZyBmbHVzaF9hcmVhX2FsbCgpIHdpdGgg aW50ZXJydXB0cyBkaXNhYmxlZC4gIE5vdGUgdGhhdA0KPiBhbHRlcm5hdGl2ZV9icmFuY2hlcygp IGlzIGNhbGxlZCBiZWZvcmUgQVBzIGFyZSBzdGFydGVkLCBzbyB0aGUgZmx1c2gNCj4gbXVzdCBi ZSBhIGxvY2FsIG9uZSAoYW5kIGluZGVlZCB0aGUgY3B1bWFzayBwYXNzZWQgdG8NCj4gZmx1c2hf YXJlYV9tYXNrKCkganVzdCBjb250YWlucyBvbmUgQ1BVKS4NCj4NCj4gVGFrZSB0aGUgb3Bwb3J0 dW5pdHkgdG8gc2ltcGxpZnkgYSBiaXQgdGhlIGxvZ2ljIGFuZCBtYWtlIGZsdXNoX2FyZWEoKQ0K PiBhbiBhbGlhcyBmb3IgZmx1c2hfYXJlYV9tYXNrKCZjcHVfb25saW5lX21hcC4uLiksIHRha2lu ZyBpbnRvIGFjY291bnQNCj4gdGhhdCBjcHVfb25saW5lX21hcCBqdXN0IGNvbnRhaW5zIHRoZSBC U1AgYmVmb3JlIEFQcyBhcmUgc3RhcnRlZC4NCj4gVGhpcyByZXF1aXJlcyB3aWRlbmluZyB0aGUg YXNzZXJ0IGluIGZsdXNoX2FyZWFfbWFzaygpIHRvIGFsbG93DQo+IGJlaW5nIGNhbGxlZCB3aXRo IGludGVycnVwdHMgZGlzYWJsZWQgYXMgbG9uZyBhcyBpdCdzIHN0cmljdGx5IGEgbG9jYWwNCj4g b25seSBmbHVzaC4NCj4NCj4gVGhlIG92ZXJhbGwgcmVzdWx0IGlzIHRoYXQgYSBjb25kaXRpb25h bCBjYW4gYmUgcmVtb3ZlZCBmcm9tDQo+IGZsdXNoX2FyZWEoKS4NCj4NCj4gRml4ZXM6ICg3OGUw NzJiYzM3ICd4ODYvbW06IGF2b2lkIGluYWR2ZXJ0ZW50bHkgZGVncmFkaW5nIGEgVExCIGZsdXNo IHRvIGxvY2FsIG9ubHknKQ0KPiBTdWdnZXN0ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJv Z2VyLnBhdUBjaXRyaXguY29tPg0KDQpUZW50YXRpdmVseSBBY2tlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0KVGhpcyBzZWVtcyBsaWtlIHRoZSBsZWFz dCBiYWQgb3B0aW9uIG9mIGEgbG90IG9mIGJhZCBvcHRpb25zLsKgIEknZCBzYXkNCml0J3MgbW9y ZSB0aGFuIGp1c3QgcmVtb3ZpbmcgYSBjb25kaXRpb25hbCBmcm9tIGZsdXNoX2FyZWEoKTsgaXQn cw0KcmVtb3ZpbmcgYSBydW50aW1lIHNwZWNpYWwgY2FzZSBmb3IgaW5pdC10aW1lIGNvZGUuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon May 16 14:50:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:50:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329959.553255 (Exim 4.92) (envelope-from ) id 1nqc35-0002PI-L2; Mon, 16 May 2022 14:50:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329959.553255; Mon, 16 May 2022 14:50:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc35-0002PB-HS; Mon, 16 May 2022 14:50:15 +0000 Received: by outflank-mailman (input) for mailman id 329959; Mon, 16 May 2022 14:50:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc34-0002P5-Ru for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:50:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e1b5b16-d527-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:50:13 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8A0901FB39; Mon, 16 May 2022 14:50:13 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0B9D32C142; Mon, 16 May 2022 14:50:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e1b5b16-d527-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652712613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KQiIlBeAtlsgCeLOjjHzTpkuGh7+XAuIIUDB14idFd4=; b=S4QT9bHIulh2DX7+Td1E1eHZ8ylXqLGd87dgOU5qON7f0TC2viT1I31ABT9u1YFo+zVF7s CRf1jIcOXQaAUTOOLTnLyfyBeX0en2TY7mgyp7gvJnFWNhPu01YU8FRcK1p4/UGj8Io8lk XM2tY8ZdnQQ59J0fQXUB5igw6KG7gMQ= Date: Mon, 16 May 2022 16:50:12 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Steven Rostedt , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-24-gpiccoli@igalia.com> <20220510134014.3923ccba@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 2022-05-11 17:03:51, Guilherme G. Piccoli wrote: > On 10/05/2022 14:40, Steven Rostedt wrote: > > On Wed, 27 Apr 2022 19:49:17 -0300 > > "Guilherme G. Piccoli" wrote: > > > >> Currently we don't have a way to check if there are dumpers set, > >> except counting the list members maybe. This patch introduces a very > >> simple helper to provide this information, by just keeping track of > >> registered/unregistered kmsg dumpers. It's going to be used on the > >> panic path in the subsequent patch. > > > > FYI, it is considered "bad form" to reference in the change log "this > > patch". We know this is a patch. The change log should just talk about what > > is being done. So can you reword your change logs (you do this is almost > > every patch). Here's what I would reword the above to be: > > > > Currently we don't have a way to check if there are dumpers set, except > > perhaps by counting the list members. Introduce a very simple helper to > > provide this information, by just keeping track of registered/unregistered > > kmsg dumpers. This will simplify the refactoring of the panic path. > > Thanks for the hint, you're right - it's almost in all of my patches. > I'll reword all of them (except the ones already merged) to remove this > "bad form". Shame on me that I do not care that much about the style of the commit message :-) Anyway, the code looks good to me. With the better commit message: Reviewed-by: Petr Mladek Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 14:54:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:54:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329968.553265 (Exim 4.92) (envelope-from ) id 1nqc6h-00033g-41; Mon, 16 May 2022 14:53:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329968.553265; Mon, 16 May 2022 14:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc6h-00033Z-1D; Mon, 16 May 2022 14:53:59 +0000 Received: by outflank-mailman (input) for mailman id 329968; Mon, 16 May 2022 14:53:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc6f-00033P-Uo; Mon, 16 May 2022 14:53:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc6f-0004Ab-RY; Mon, 16 May 2022 14:53:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc6f-0001o7-E5; Mon, 16 May 2022 14:53:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqc6f-0003K5-Dg; Mon, 16 May 2022 14:53:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1cUj4252NfThwBNausFIaNZx1eVocUP+BkgTPzqLy4U=; b=xSP3+hPi973syCGpBrwjLrUUzD X4koxvx5/4PfCMfIt54ipeY+cMUQ9hYpGH25UT4+Xyst7AhUNZefw95sIo1AlQE1ad2rVgqz7uPnN 9jtc73ttiDOcb3Fpv04jx50oG/hNPbVDSb4DC8XohA042DLs+680XXaM6nycAxEcFF4k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170481: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 14:53:57 +0000 flight 170481 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170481/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1044 attempts Testing same since 170392 2022-05-13 15:40:22 Z 2 days 63 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 14:56:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 14:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329978.553277 (Exim 4.92) (envelope-from ) id 1nqc9U-0003eU-IF; Mon, 16 May 2022 14:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329978.553277; Mon, 16 May 2022 14:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc9U-0003eN-FA; Mon, 16 May 2022 14:56:52 +0000 Received: by outflank-mailman (input) for mailman id 329978; Mon, 16 May 2022 14:56:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqc9T-0003eF-8h for xen-devel@lists.xenproject.org; Mon, 16 May 2022 14:56:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a40332d-d528-11ec-837e-e5687231ffcc; Mon, 16 May 2022 16:56:50 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8A94B21FE9; Mon, 16 May 2022 14:56:49 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 028062C141; Mon, 16 May 2022 14:56:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a40332d-d528-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652713009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oTDrZeo/UdLI29Tuaw8mlcdG/RkPgJLQM7cePAnlqRg=; b=qMST7ia3BcKl3UtC1W2uQ0qkLBJP5Q7YC0oT0Qsb2KbEzU3Or4Q8r5PYsshuphM/GEHsx/ 3TbgfR0/0E5XpsXnd9OyJN2pbUs6sglf0Hs/rZTi2wLDZTO2OOnHvkd7qA4fAmNZA1vdry 3XHA87WfjJ2L5kh4VZznBS1IZ/1m/S0= Date: Mon, 16 May 2022 16:56:41 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 25/30] panic, printk: Add console flush parameter and convert panic_print to a notifier Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-26-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427224924.592546-26-gpiccoli@igalia.com> On Wed 2022-04-27 19:49:19, Guilherme G. Piccoli wrote: > Currently the parameter "panic_print" relies in a function called > directly on panic path; one of the flags the users can set for > panic_print triggers a console replay mechanism, to show the > entire kernel log buffer (from the beginning) in a panic event. > > Two problems with that: the dual nature of the panic_print > isn't really appropriate, the function was originally meant > to allow users dumping system information on panic events, > and was "overridden" to also force a console flush of the full > kernel log buffer. It also turns the code a bit more complex > and duplicate than it needs to be. > > This patch proposes 2 changes: first, we decouple panic_print > from the console flushing mechanism, in the form of a new kernel > core parameter (panic_console_replay); we kept the functionality > on panic_print to avoid userspace breakage, although we comment > in both code and documentation that this panic_print usage is > deprecated. > > We converted panic_print function to a panic notifier too, adding > it on the panic informational notifier list, executed as the final > callback. This allows a more clear code and makes sense, as > panic_print_sys_info() is really a panic-time only function. > We also moved its code to kernel/printk.c, it seems to make more > sense given it's related to printing stuff. I really like both changes. Just please split it them into two patchset. I mean one patch for the new "panic_console_replay" parameter and 2nd that moves "printk_info" into the notifier. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Mon May 16 15:04:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:04:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329986.553288 (Exim 4.92) (envelope-from ) id 1nqcHB-00058n-EV; Mon, 16 May 2022 15:04:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329986.553288; Mon, 16 May 2022 15:04:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcHB-00058g-9l; Mon, 16 May 2022 15:04:49 +0000 Received: by outflank-mailman (input) for mailman id 329986; Mon, 16 May 2022 15:04:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcHA-00058a-0F for xen-devel@lists.xenproject.org; Mon, 16 May 2022 15:04:48 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 857808f2-d529-11ec-837e-e5687231ffcc; Mon, 16 May 2022 17:04:46 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 11:04:15 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN6PR03MB2644.namprd03.prod.outlook.com (2603:10b6:404:58::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 15:04:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 15:04:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 857808f2-d529-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652713486; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nmbswEJSrEKjqoojLoE4xTqWQwbrMQURlD61oj53w3Q=; b=Z/m0vkKOgVKVYNPOcj/QlyEdCKc0yfLbQk7xc0GCMnQQ8+jyY+tqKzW5 xSfFpOaoD7vNfs+xk944SOLJN5gw1Q3Gk/YgFa4DiF+HONXLS7blfWrc9 Rb57+lTdVEUYJBfCHzfWilasmLUsqsWc+X90EN7FVH+cyNqKBD78zDPIa U=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 70788836 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:64kGF6m8j80mWnlRnPqDlcfo5gy5J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWD2uBMv+JZ2P2Kt1zO4y39xkE6J7VyYRgSlZlqCozRCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWl3V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYRzkwIoPPidYkUQRlLixcYql66ICAGC3q2SCT5xWun3rE5dxLVRlzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXtZkBhGtYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvvDiDnFcvuFTrGNz7WOabYOtaomenr XL42DziBhI3b8PKnFJp9Vrp3IcjhxjTWogfCbm5/f5Cm0CIyyoYDxh+fXG2u+Wjg0iyHfdWM VUJ+zEGpLI3skesS7HVXQC8oXOClg4RXZxXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMt4db5p5oopgnSVdslG6mw5uAZAhn1y jGO6SQ72bMaiJdT073hpAibxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTWKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:2Xj9y6pWdiy3gPdDfw/Hx/IaV5tyLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFZ9l/1owKpuKuZIIMs60vFULM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsul6SR4IeMNYYDGRfzO2wGgo+nv+gVBNHdVr K6JI9WasWTWFfTJQ== X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="scan'208";a="70788836" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CEjWwVfJcCIBUTLsdRTR/42R3LhfNIT7PqFMbpYwYB+tNI3i8QQsII9Z24p1cirW49O86zqFMAp8X5/YQ6l7TY4DTO7/Q2oTeKzCJOyq9CJ/Xb4UvmFCcSspbpaWDk6WB6yi6sBYoFkYEuUWcIKr8HxcWWrlE173xn8zBFDDOOfkT57HEcByVU+KRO0reuwhvy27AI/xEbdaLellSeADLc/cSy6PLqk1oomhKruMgNIVFixxmw2HQvhTEwTYBrH0g73sO4zLpmOBc3k3y+kZ8VjoZLzKtW2YTnaZd+03rwmb3AK5b1i+tut75rmzdIUYe+GmvFwjyzmELzth8tH8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nmbswEJSrEKjqoojLoE4xTqWQwbrMQURlD61oj53w3Q=; b=UKOD59oC88GejafjFkP/clBkyeBgg2tlyZfhgRylM4BhkYijEOevGd3mOPgOj56zy41dMXmBp81Vzr6SLmjf+fC4cCnqJzBLFnRFebxArtXbxNLjDRBR3xjj/JEtiPciRjVuL9ogBe1y71XxC+Wk37gRXaQ4QMsrely8BCLlxCt0NtHm+qKZ6Q1RkMSrY8K77wY2m6mAqdEA/WwqWXsCL3ny6ce8VIaCEi1926Ht7Au3nW+L5hZ6652NssnMhbOTNZvYTBjLrhmOo71ilIgl3S9AgfF6nxiPG4JXDznPV7eq6P4BGRDB6NzzryrByFi8CU3VNnUiZhzbbrn5Da/OSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmbswEJSrEKjqoojLoE4xTqWQwbrMQURlD61oj53w3Q=; b=Pw+0wxb4JDB4reTCFJB60lexdxKjaWzgb0YFUQ1s7pr6ux2RZ/WHO5Yd1S25d83RpE87vSuq09ZVKiwr6bj4Q3tXaVyBrvs5VEC4fwz9/Np9Y72tpVcyFlJpPwEUAcvQrfTaZQdbvwwH3RQ2KRugLbeXtmUNgKYZSry8Fp38kBI= From: Andrew Cooper To: George Dunlap , Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini CC: xen-devel , Juergen Gross , Roger Pau Monne Subject: Re: Process for cherry-picking patches from other projects Thread-Topic: Process for cherry-picking patches from other projects Thread-Index: AQHYZtZwibZ3DwtT5Ea5wKgBtO2ACK0hnruA Date: Mon, 16 May 2022 15:04:13 +0000 Message-ID: References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> In-Reply-To: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5177a9bd-b658-4f0d-dcb8-08da374d56fd x-ms-traffictypediagnostic: BN6PR03MB2644:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QiUdwMSf6xp4QwGNNUFqZR0fDTuLrjh68KGth0Ny4ihYAnt5pcNbESum+C5vyBWf6XfwwGDEyvYb0yxzldHmbOaQzP2aQMayurl1smQR9EaPXzCPKTJyk2JZBAIQayzOxMG9Zw3WTWJOyupBotYrGHtDieclfagtMnPQCBBy65wH4yFMV9gCbZZeuWUWcH3WLKIwTKPUt/4O7/Ot50OoOCSFSMtD6YJj51/yDwAXsi4fxA62f2MRN0wBS20sNRWYWi3wElYNTIh15QB1aykDaU+tZHY9BQFOJjQwxaqLlMk8AMGhduapPK9bHrHi0s3/43WxaTnCKP7NI1rylBqnNqOET6rj4KqHnZRM3zXVD3x2FDZLAFveF7nMOeifbkvbn2+pbgxtVN5njAGBKu8w23zLn6ER+BUrwrngYMpvpESnmMdEL/gtvXZ3GPbMKWMXvzxt8PNcBrfZv50xo+5rs6tVDSVwTRAetZ76DWROdXCuQSgxppmC2cSJ5FV306paV8Ja11hodNWg+fJ3C5/BjR7o9ziQWUyXenSgJ5B8aRXq4IZWux2bYX3x6WO9iwcXPU9jaNg4S1F4ryt6+2pnkg5QA4bh3LPaKqgmptzb9WccKajY5en4/9TmiK4CzjzDTFsqIAWryXc6OwPsXDrivOSCCmdTDyUdQt3KMmHq9f2bHEwGvnzA7YuukiltiKL+5vx30dth+xcYAkxHd77zVmgV6YC4WTyXD2MPk7TSUIril3w+xhJB2u4evQc9LKmHYYsRRHcb4Yxuh2gw3o3gZg0LIa3dmoFj+sOx7O4zpktmrvxfeIm7acoMWeS2vJtUttJi1deiYw83efqRdSeRdzFPqCWLZ/ln2cm+6G+/47Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(2906002)(71200400001)(38070700005)(508600001)(316002)(6512007)(4326008)(36756003)(31686004)(6506007)(76116006)(91956017)(82960400001)(8676002)(53546011)(66556008)(66446008)(26005)(64756008)(8936002)(86362001)(84970400001)(5660300002)(31696002)(107886003)(110136005)(83380400001)(66476007)(54906003)(6486002)(38100700002)(122000001)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q1pmU24rV0RoRTlQYWJveVJSNlJGUmtycDQvdGhEU2FpZWFMTnVCMnFLQ0J4?= =?utf-8?B?eURyc3N5c0FsK0FGbXU0aVhTYmk2NHhJS0N6bkRUTmdqanp6TzhSQVBiQWY1?= =?utf-8?B?bC9yVytmRDR4Ni8reE5HTml2RzNxVWZXMlp3YlpYK1dscWdEWUYrRGZ0QVY5?= =?utf-8?B?MUI0NHdRekphUHYwQkRCcmEvU3JVTmlKeGZDOTNqd093UG1ESEZQb0FUTGpL?= =?utf-8?B?OXJDVUNvTWtlazNleUhhS0doQ3ZkVFp5aTZOVkNPYjNyTHMrcS9rQTJNcWRt?= =?utf-8?B?TmRYK0doZFVxQ1I4TDVJTk84MTJUZnJwVWYxQmlIVUFBNEZVVlNQMlFHOG5W?= =?utf-8?B?S3ozNkoxYmlkSVRjR0RwajhlclRGbUYxRGJVNFZSRVpQQ3NwTG1nV2xna2dQ?= =?utf-8?B?THpjTHE3MldvdzNmTjhuQUUrSFBWWDV0OElmR2Mxdkw0eHRiRlNMcGNjQ0dn?= =?utf-8?B?MU10QzgxME1XV3hiYU1Vc2h5ZWFOczltU2g0SHVXZyt6UUNoSDlFT2hmVnhy?= =?utf-8?B?YVJoMWxDWjJMZ1BadU12WUduWWpjRUtVNHhZWkZhOUhCZEpXN2xtSGZ6Vy9v?= =?utf-8?B?aEtFT2ZoUnJVWG9vZGVSTVYzUWhNVjZtUnJ1WkExRWl6azNiU2RONUFpVXVi?= =?utf-8?B?cHlzUWxyY2JpMGpLRDN1dDhpRWFJckNzQldEMlgvSUlWa3E0bGZxVkxydDdD?= =?utf-8?B?RERncis0dERiN1V0RlUzZ1lBR3ZoNmxhc2c5K0pqcVFNRjhEekYxaDBDMWds?= =?utf-8?B?dG9idXkxTUViQWJtdGFkbjdNNGxudG02aHlkaHpRVE81bUxZb0pQc3U2bVdO?= =?utf-8?B?YTU2cVNRTGJFZXpLZTkvZTZEMmxsMmg5S09JdUcyQjJTUUR4eDBma1dZTnNG?= =?utf-8?B?RGVMN0E2SkxxOE9uNE0zVE5WbUFIWUtoU3liS0NUQjMvdDV2OWpuNy9oWnlH?= =?utf-8?B?UURjdFljUmlHSG9ZeTgxNFgyV0lSdFlMQ2tZaFYwNExSUGtrTjVUdlFCTUt0?= =?utf-8?B?YysyRGIwQlZqa2NaWWJsT0gzTUQ1ZFRMWVptYlovUHVjcTJGYTVtV2JzWHZY?= =?utf-8?B?ODd6d215aXdnVTUyV29vZ3BjT2ZIek9YQnl5KzRwbkJxWXNKMXlyYUtKa3h4?= =?utf-8?B?ZzhiZHNBRE4vS3Y2cGk1WUJOY0JyY284aWFlUGRROFBOdjRVMDZzOExGcUlC?= =?utf-8?B?S2pvekEyeTVJUkYxS3c5a0JzSHB0aDFZVVZ0WEVQVXJqYzR6L3IySHU4aGFR?= =?utf-8?B?REVUK1lOVzdpSWtIMjBPaFVZKzB3Z1A1VEJQdEYwMDdhR05Ua3orS0laMFRU?= =?utf-8?B?OFdtUWo2bG1ueE0xWDUvcmJndHd6VnpSK1hoVGZMZ0l0SDNqazRaM2JIUlRV?= =?utf-8?B?R3B0ZUhGSjNvellaL0ZleVpCaVRLN0htS0lxbVNwekozdzlDc1JMMTgvSWVj?= =?utf-8?B?djBvTnlYYUVFdnZXUitzQTAybnV4alFuN2FJeUd3QnprK2s5c2JJeHBIYVpT?= =?utf-8?B?K04wQUFYZDBJSGJDSHJMZm5yNDlGNjlQWDkrWUtGOVFRK3Q5bXl0bmVYL2x5?= =?utf-8?B?TmN1Q0JTWFUrSFkrbVNaMnZHaG94MzllSXViY0dxSlFSaWVVTnkzeXpUcmd3?= =?utf-8?B?eitmenRTVHpIRE5VMXl2b3h1U2ZtNlh3MU5kZkcvcENnTkorTnkwWGtSRDBl?= =?utf-8?B?VlowMGR6WitiVzI5OWpUVVF2REl2UE1KSDlhazNGaFE1NXVKRXdDMEh3VVNq?= =?utf-8?B?ai9ab280RDVkcGxyZnNoaW84bmRjS0VFSTh3ajFIaC8xNEVwVEdNT09Jdlg5?= =?utf-8?B?aVo2TnZEQnF1TytOb3B3QWtCTG5IMkZFaUFPamQwVGpYN1RFODdweGhxN3Nw?= =?utf-8?B?ZGMvVTUwUDhkdEJjb3pGaHdOZXlNTjh4ZEZMc3JNUjlobDJ0NW82SVpUd3cy?= =?utf-8?B?a0Z3Y1JoVEVFaEZsTUhTTE9TcElhZmQ2MWZKYzRDZUlyUWRXUjFLZnJvMG82?= =?utf-8?B?cUpJMDBMRXFrc1I3all3SlowU3dJOFpRUWxaSTBaUGo1YVU1WjVkSHl3OXRr?= =?utf-8?B?c01hOG42MXZsYWNNZ1RyTkNpc0p3cUlmTGt2QVl5aWhVMWQ1amhOTkUvOTMz?= =?utf-8?B?bFpORDd4TDdvcitkeUVWOStNUWZSWlp3aXQrbmxTZ0VLdXd3YzdyY1Zjd2Yx?= =?utf-8?B?YnNLekNlUS9OazAyQ0llcGtxaWtRa0JRTWlJek9KNGxkaCtZSmpQV1ljaFBS?= =?utf-8?B?REc3SytNemZZbHdCUzc3OGs2a0UyRU9ldE5XNS9kdjhCVnhjNm4veE1zRXQy?= =?utf-8?B?aWpBSlUzV1dCMDVDbnBCTllvdU1lSlAzeER1eUtOejNWZElFMDZhQnJvUGgw?= =?utf-8?Q?Wagg0I8fW3mMVs+c=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <38019F762AF5C64E8E3471522DA10EC0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5177a9bd-b658-4f0d-dcb8-08da374d56fd X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 15:04:13.7208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rTUF0T5jSBsn1bkwX6dhEzIOc66nz+mJDD1SjAOGtVUL4YedOqavo2Km65prs20yxw3XjyZLcCerF5Bb0aMVc9oDtFfPvWkSJWL736lzpiM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2644 T24gMTMvMDUvMjAyMiAxNTozMywgR2VvcmdlIER1bmxhcCB3cm90ZToNCj4gU3RhcnRpbmcgYSBu ZXcgdGhyZWFkIHRvIG1ha2UgaXQgY2xlYXIgdGhhdCB3ZeKAmXJlIGRpc2N1c3NpbmcgYSB3aWRl ciBwb2xpY3kgaGVyZS4NCj4NCj4gVGhpcyBxdWVzdGlvbiBpcyBhaW1lZCBhdCBKYW4gYW5kIEFu ZHkgaW4gcGFydGljdWxhciwgYXMgSSB0aGluayB0aGV54oCZdmUgcHJvYmFibHkgZG9uZSB0aGUg bW9zdCBvZiB0aGlzOyBzbyBJ4oCZbSBsb29raW5nIHRvIHRoZW0gdG8gZmluZCBvdXQgd2hhdCBv dXIg4oCcc3RhbmRhcmQgcHJhY3RpY2XigJ0gaXMuDQo+DQo+IFRoZXJlIGhhdmUgcmVjZW50bHkg YmVlbiBzb21lIHBhdGNoZXMgdGhhdCBCZXJ0cmFuZCBoYXMgc3VibWl0dGVkIHdoaWNoIHB1bGwg aW4gY29kZSBmcm9tIExpbnV4ICgiW1BBVENIIDEvM10geGVuL2FybTogU3luYyBzeXNyZWdzIGFu ZCBjcHVpbmZvIHdpdGggTGludXggNS4xOC1yYzPigJ0pLCB3aGljaCBoYXMgY2F1c2VkIGEgZGlz Y3Vzc2lvbiBiZXR3ZWVuIGhpbSwgSnVsaWVuLCBhbmQgU3RlZmFubyBhYm91dCB0aGUgcHJvcGVy IHdheSB0byBkbyBzdWNoIHBhdGNoZXMuDQo+DQo+IFRoZSDigJxPcmlnaW464oCdIHRhZyBzZWN0 aW9uIG9mIHhlbi5naXQvZG9jcy9wcm9jZXNzL3NlbmRpbmctcGF0Y2hlcy5wYW5kb2Mgc3VnZ2Vz dHMgdGhhdCB0aGVyZSBhcmUgc29tZSBzdGFuZGFyZHMsIGJ1dCBkb2VzbuKAmXQgc3BlbGwgdGhl bSBvdXQuDQo+DQo+IFRoZSBxdWVzdGlvbnMgc2VlbSB0byBiZToNCj4NCj4gMSkgV2hlbiBkb2lu ZyB0aGlzIGtpbmQgb2YgdXBkYXRlLCBpcyBpdCBwZXJtaXNzaWJsZSB0byBzZW5kIGEgc2luZ2xl IHBhdGNoIHdoaWNoIOKAnGJhdGNoZXPigJ0gc2V2ZXJhbCB1cHN0cmVhbSBjb21taXRzIHRvZ2V0 aGVyLA0KDQpZZXMsIGFic29sdXRlbHkuDQoNCldlIGRvIHRoaXMgYWxsIG92ZXIgdGhlIHBsYWNl Lg0KDQo+ICBvciBzaG91bGQgZWFjaCBwYXRjaCBiZSBiYWNrcG9ydGVkIGluZGl2aWR1YWxseT8N Cj4NCj4gMikgSWYg4oCcYmF0Y2hlc+KAnSBhcmUgcGVybWlzc2libGUsIHdoZW4/ICBXaGVuIHdv dWxkIGluZGl2aWR1YWwgcGF0Y2hlcyBiZSBwcmVmZXJyZWQ/DQoNClRoYXQncyBhIG1hdHRlciBv ZiB0YXN0ZS7CoCBJZiBpdCdzIHNldmVyYWwgcGF0Y2hlcyBvZiBhIGNvbXBsaWNhdGVkDQpidWdm aXgsIHRoZW4gaXQgcHJvYmFibHkgd2FudHMgc3BsaXR0aW5nIHVwIGluIHRoZSBzYW1lIHdheS4N Cg0KSWYgaXQncyBhIGJ1bmNoIG9mIG1pc2MgY2hhbmdlcywgdGhlbiBiYXRjaGluZyBpcyBmaW5l Lg0KDQoNCj4gMykgRm9yIOKAnGJhdGNoIHVwZGF0ZXPigJ0sIHdoYXQgdGFncyBhcmUgbmVjZXNz YXJ5PyAgRG8gd2UgbmVlZCB0byBub3RlIHRoZSBjaGFuZ2VzZXRzIG9mIGFsbCB0aGUgY29tbWl0 cywgYW5kIGlmIHNvLCBkbyB3ZSBuZWVkIG11bHRpcGxlIOKAnE9yaWdpbuKAnSB0YWdzPyAgRG8g d2UgbmVlZCB0byBpbmNsdWRlIGFueXRoaW5nIGZyb20gdGhlIG9yaWdpbmFsIGNvbW1pdHMg4oCU IGNvbW1pdCBtZXNzYWdlcz8gIFNpZ25lZC1vZmYtYnnigJlzPw0KDQoiVXBkYXRlICRGT08gdG8g c29tZXRoaW5nIHJlc2VtYmxpbmcgJFBST0pFQ1QsICRWRVJTSU9OIiBpcyBwZXJmZWN0bHkgZ29v ZC4NCg0KPg0KPiBBbmQgYSByZWxhdGVkIHF1ZXN0aW9uOg0KPg0KPiA0KSBXaGVuIGltcG9ydGlu ZyBhbiBlbnRpcmUgZmlsZSBmcm9tIGFuIHVwc3RyZWFtIGxpa2UgTGludXgsIHdoYXQgdGFncyBk byB3ZSBuZWVkPw0KDQpBbnkgY2xlYXIgcmVmZXJlbmNlIHRvIHdoZXJlIGl0IGNhbWUgZnJvbS4N Cg0KTm90aGluZyBpcyBldmVyIGltcG9ydGVkIHZlcmJhdGltLsKgIElmIG5vdGhpbmcgZWxzZSwg cGF0aHMgaGF2ZSB0byBiZQ0KY2hhbmdlZCwgYW5kIHVzdWFsbHkgbW9yZSB0aGFuIHRoYXQuDQoN CkdpdmVuIHRoYXQsIEkgZG8gcXVlc3Rpb24gd2hldGhlciBpdCBpcyBhcHByb3ByaWF0ZSB0byBy ZXRhaW4gb3JpZ2luYWwNCmF1dGhvcnNoaXAuwqAgVGhlIG9yaWdpbmFsIGF1dGhvciBkaWQgbm90 IHdyaXRlIGEgcGF0Y2ggZm9yIFhlbiwgYW5kIHdoYXQNCmdldHMgY29tbWl0dGVkIHdhc24ndCB0 aGUgcGF0Y2ggdGhleSB3cm90ZS4NCg0KQW55IGlzc3VlcyB3aXRoIHRoZSBwb3J0IGludG8gWGVu IHNob3VsZCBiZSBzZW50IHRvIHRoZSBwZXJzb24gd2hvIGRpZA0KdGhlIHBvcnQgaW50byBYZW4s IG5vdCB0aGUgb3JpZ2luYWwgYXV0aG9yIHdobyBtb3N0IGxpa2VseSBoYXMgbm8gaWRlYQ0KdGhh dCB0aGVpciBwYXRjaCBoYXMgYmVlbiBib3Jyb3dlZCBieSBYZW4uDQoNCklNTywgYSBjb21taXQg bWVzc2FnZSBzYXlpbmcgInBvcnQgJFggZnJvbSBwcm9qZWN0ICRZIiBtYWtlcyBpdCBjcnlzdGFs DQpjbGVhciB0aGF0IHRoZSBvcmlnaW5hbCBjb2RlIGNoYW5nZSBpc24ndCBtaW5lLCBidXQgdGhl IHBvcnRpbmcgZWZmb3J0DQppcy7CoCBBbW9uZ3N0IG90aGVyIHRoaW5ncywgcG9ydGluZyBpbnZh bGlkYXRlcyBhbnkgcmV2aWV3L2Fjay90ZXN0IGNoYWluDQpiZWNhdXNlIHRob3NlIHRhZ3Mgd2Vy ZSBnaXZlbiBpbiB0aGUgY29udGV4dCBvZiB0aGUgb3JpZ2luYWwgcHJvamVjdCwNCm5vdCBYZW4u DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon May 16 15:07:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.329996.553299 (Exim 4.92) (envelope-from ) id 1nqcK4-0005oH-0d; Mon, 16 May 2022 15:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 329996.553299; Mon, 16 May 2022 15:07:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcK3-0005oA-TR; Mon, 16 May 2022 15:07:47 +0000 Received: by outflank-mailman (input) for mailman id 329996; Mon, 16 May 2022 15:07:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcK2-0005o4-R4 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 15:07:47 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f01ec46c-d529-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 17:07:44 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqcJI-006nIW-Cg; Mon, 16 May 2022 17:07:00 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f01ec46c-d529-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x8rylV2fo2RhFyw7lXZ7iRi1TUSl/qSAgQ1QFQa6Swk=; b=feXctn9xVfAtMOxpqtYyQ3CA85 BjdcLwwe8TiMsRw2fUykvtPuvzY6hmKnTuAYE+A0XsmmVYSLQ/kcthiUMBKg0mNjJ1yc4l+lLSsmf USmCbBkmQnOZm2iGOSrx6Rl0cCpZ73ILK767ZxXmwm6a3QHv/+OS7mfra0PYCo9fNU1O9VQyfm4pw 6HrCZSPKvKswSfp/Eu6sagLk3Urn9HpvONKk/wFmV32LKFF9WaILoOgpFS5qfU8S7XCa8c/aUXIoQ 86eaCmPOCcjnQf8OfgMGzWfOoSFt/jwGca1nP55u94yjF/tPVCKn3Ik3vagLqYanseWDcV4ZXGkRO T9pShFkw==; Message-ID: Date: Mon, 16 May 2022 12:06:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek , David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks for the review! I agree with the blinking stuff, I can rework and add all LED/blinking stuff into the loop list, it does make sense. I'll comment a bit in the others below... On 16/05/2022 11:01, Petr Mladek wrote: > [...] >> --- a/arch/mips/sgi-ip22/ip22-reset.c >> +++ b/arch/mips/sgi-ip22/ip22-reset.c >> @@ -195,7 +195,7 @@ static int __init reboot_setup(void) >> } >> >> timer_setup(&blink_timer, blink_timeout, 0); >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > This notifier enables blinking. It is not much safe. It calls > mod_timer() that takes a lock internally. > > This kind of functionality should go into the last list called > before panic() enters the infinite loop. IMHO, all the blinking > stuff should go there. > [...] >> --- a/arch/mips/sgi-ip32/ip32-reset.c >> +++ b/arch/mips/sgi-ip32/ip32-reset.c >> @@ -145,7 +144,7 @@ static __init int ip32_reboot_setup(void) >> pm_power_off = ip32_machine_halt; >> >> timer_setup(&blink_timer, blink_timeout, 0); >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > Same here. Should be done only before the "loop". > [...] Ack. >> --- a/drivers/firmware/google/gsmi.c >> +++ b/drivers/firmware/google/gsmi.c >> @@ -1034,7 +1034,7 @@ static __init int gsmi_init(void) >> >> register_reboot_notifier(&gsmi_reboot_notifier); >> register_die_notifier(&gsmi_die_notifier); >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_hypervisor_list, >> &gsmi_panic_notifier); > > I am not sure about this one. It looks like some logging or > pre_reboot stuff. > Disagree here. I'm looping Google maintainers, so they can comment. (CCed Evan, David, Julius) This notifier is clearly a hypervisor notification mechanism. I've fixed a locking stuff there (in previous patch), I feel it's low-risk but even if it's mid-risk, the class of such callback remains a perfect fit with the hypervisor list IMHO. > [...] >> --- a/drivers/leds/trigger/ledtrig-activity.c >> +++ b/drivers/leds/trigger/ledtrig-activity.c >> @@ -247,7 +247,7 @@ static int __init activity_init(void) >> int rc = led_trigger_register(&activity_led_trigger); >> >> if (!rc) { >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_hypervisor_list, >> &activity_panic_nb); > > The notifier is trivial. It just sets a variable. > > But still, it is about blinking and should be done > in the last "loop" list. > > >> register_reboot_notifier(&activity_reboot_nb); >> } >> --- a/drivers/leds/trigger/ledtrig-heartbeat.c >> +++ b/drivers/leds/trigger/ledtrig-heartbeat.c >> @@ -190,7 +190,7 @@ static int __init heartbeat_trig_init(void) >> int rc = led_trigger_register(&heartbeat_led_trigger); >> >> if (!rc) { >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_hypervisor_list, >> &heartbeat_panic_nb); > > Same here. Blinking => loop list. Ack. >> [...] >> diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c >> index a16b99bdaa13..d9d5199cdb2b 100644 >> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c >> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c >> @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >> >> /* register for panic notifier */ >> vk->panic_nb.notifier_call = bcm_vk_on_panic; >> - err = atomic_notifier_chain_register(&panic_notifier_list, >> + err = atomic_notifier_chain_register(&panic_hypervisor_list, >> &vk->panic_nb); > > It seems to reset some hardware or so. IMHO, it should go into the > pre-reboot list. Mixed feelings here, I'm looping Broadcom maintainers to comment. (CC Scott and Broadcom list) I'm afraid it breaks kdump if this device is not reset beforehand - it's a doorbell write, so not high risk I think... But in case the not-reset device can be probed normally in kdump kernel, then I'm fine in moving this to the reboot list! I don't have the HW to test myself. > [...] >> --- a/drivers/power/reset/ltc2952-poweroff.c >> +++ b/drivers/power/reset/ltc2952-poweroff.c >> @@ -279,7 +279,7 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev) >> pm_power_off = ltc2952_poweroff_kill; >> >> data->panic_notifier.notifier_call = ltc2952_poweroff_notify_panic; >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_hypervisor_list, >> &data->panic_notifier); > > I looks like this somehow triggers the reboot. IMHO, it should go > into the pre_reboot list. Mixed feeling again here - CCing the maintainers for comments (Sebastian / PM folks). This is setting a variable only, and once it's set (data->kernel_panic is the bool's name), it just bails out the IRQ handler and a timer setting - this timer seems kinda tricky, so bailing out ASAP makes sense IMHO. But my mixed feeling comes from the fact this notifier really is not a fit to any list - it's just a "watchdog"/device quiesce in some form. Since it's very low-risk (IIUC), I've put it here. > [...] >> --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c >> +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c >> @@ -814,7 +814,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) >> goto out; >> } >> >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_hypervisor_list, >> &brcmstb_pm_panic_nb); > > I am not sure about this one. It instruct some HW to preserve DRAM. > IMHO, it better fits into pre_reboot category but I do not have > strong opinion. Disagree here, I'm CCing Florian for information. This notifier preserves RAM so it's *very interesting* if we have kmsg_dump() for example, but maybe might be also relevant in case kdump kernel is configured to store something in a persistent RAM (then, without this notifier, after kdump reboots the system data would be lost). Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 15:20:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:20:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330008.553310 (Exim 4.92) (envelope-from ) id 1nqcVn-0007Ky-3R; Mon, 16 May 2022 15:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330008.553310; Mon, 16 May 2022 15:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcVn-0007Kr-0V; Mon, 16 May 2022 15:19:55 +0000 Received: by outflank-mailman (input) for mailman id 330008; Mon, 16 May 2022 15:19:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcVl-0007Kg-Fk for xen-devel@lists.xenproject.org; Mon, 16 May 2022 15:19:53 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a168ebd4-d52b-11ec-837e-e5687231ffcc; Mon, 16 May 2022 17:19:52 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 11:19:42 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by MWHPR03MB2830.namprd03.prod.outlook.com (2603:10b6:300:11a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 15:19:39 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 15:19:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a168ebd4-d52b-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652714392; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=pOieCbQ6d/A2vhvVJG6TRkZN1L3vzsDi/nMUGCH5Mdc=; b=UYYgh7xDHsGCIU3YCv1uS+PpA9ItqSEpkTFJWCpP0GeJXZdo8AQOVS+o GYEKe9r7gcjq/uCIuPzgn5NecwiBeQkRRt+zSoiAA2b180dkbepZm+ST5 SLs0qASsU5abDmE9LnAhr1ujCcBY4+t/Yi6Qa57Uisx7GIDetqOMol7JG I=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 73911093 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:L/oVjqKV7S3u0ryfFE+ReJQlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl zVBCC3DeKqUMyGmS21FGN+3pxsG68XUyYVgQANoripnFn9A9ZGZVYXHf037MynJdZScFUxts sxFNNCecc4+Hi+H90ynY7W4/SYt3qqDTOKU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk Yr7rZ2FNg+s12Z4PjhJsv3Z8x4w5amosj9B71FhOa0S7QPSz3UbMskSdPq7R5farii4PQIYq 8LrluzRErbxpk91Yj+duu+nNBVMGNY+BCDW4pZsc/HKbiNq+2pji87XCNJGMR0N02jQwYgoo DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya fb1ZhJVXB7ePzsROmslBZw7jP2p3yGlfjJh/Qf9SaofuwA/zSRX+Z20aJ/5X4LPQs9Y2EGFu mjB4mL1RAkAM8CSwiaE9XTqgfLTmST8W8QZE7jQGvxC2QXPgDBMTkBGEwLj+pFViWbnMz5bA 2MZ/TAhoO4e6UqvR8HVVBykun+U+BUbXrK8FsVls1DUk/KFuG51AEAmTBdRS/IerfMMRGMY1 AOUr+7bPTVw5ej9pXW1s+38QSmJESofIHIGZCQEZRAY+NSlq4Y25jrlQ8x/CqezgpvQECvp3 jGRhCEkgvMYistj/6em+VHKhRq8q56PSRQ6ji3MRX6s5A59YI+jZqSr5ELd4PIGK5yWJnGRs X5Bl8WA4eQmCZCWiDfLUOgLBKuu5fuOLHvbm1EHN5su7TO24Fa4YJtdpjp5IS9U3t0sfDboZ ArfvF1X7ZoKZH+yN/YvOMS2FtggyrXmGZL9TPfIY9FSY593Mgia4CVpYk3W1Gfo+KQxrZwC1 V6gWZ7EJR4n5W5PlVJam891PWcX+x0D IronPort-HdrOrdr: A9a23:kXS0PahlxW1TL25AjP4bTQmRxHBQX3Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftWjdySaVxeRZgbcKrAeQfBEWmtQ96U 4kSdkHNDSSNyk3sS+Z2njfLz9I+rDun86VbKXlvg5QpGpRGsNdBnJCe2Km+zpNNWx77PQCdK a0145inX6NaH4XZsO0Cj0uRO7YveDGk5rgfFovGwMnwBPmt0Ln1JfKVzyjmjsOWTJGxrkvtU LflRbi26mlu/anjjfBym7o6YhMkteJ8KoDOCXMsLlUFtzfsHfrWG1TYczGgNnzmpDq1L8eqq iOn/7nBbU115qeRBDynfKn4Xic7N9n0Q6f9bbfuwqtnSWxfkNFN+NRwY1eaRfX8EwmoZV117 9KxXuQs95NAQrHhzmV3amBa/n7/nDE3kbKvNRj+UC3a7FuIYO5bLZvjn99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8PC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8e166MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBkPkoLVeLmzNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7jmZ8 o= X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="asc'?scan'208";a="73911093" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5FeZg/ZHWePfE+MqIqAVFL0PpYiWBvYNa87L6ydr8zJF+Pf/wheKxAIOLnsV5qh0boZPt520Bjg+uCOv5eu667AeN2v5NmCgpDc6S5X5Xr1SnJT48FpKaGi1otX3kwtShO0ZA0+feIP4woSi22BSip9+Ue76twswvehK4ojNYGXLZImcOLyzETuUSa9iQiYvF136lHFCQcJybrJojok+wty7fbs/Kv/E1hoP1FpaPa9dPPu/US6LeV2TksqFo0H1QZKQZVsnK+IfHlJPA9kQRe8kwuCbTl0Qbpn3CaojWiI/HGNyqTDYdPjueqBsE54wDBvagvpyAbUAyynez3WqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x4isfwTrks12DCtibuSTfKJRdDTgVQxraYV00JzWvOo=; b=b+Usbf/nij5VxsNHNd8oXA+nj89tHj8Zo30JZr4SX3Ns++NIVCZQZ2Dhr70kcZWjsdaSthrUOWpbnmpaNOdOHVYVIgjhDghkbkNmaQmfIvDvmgk4Moy8gL3eu3vtRb0WoBsVNYc5bzXLKEuW3qOBOlxtOL2Yu7itMqQPZStSTJlsHFVUQ4ze94MFt8pffQeRlt1/8o4ogZXpndk90IifFN2WQ0h2Clci0T56spkGxpjM93aZYMBmUh6r85Q+em44acmXMrqn6Y7ykJb7DmxpQvm2y46B3EYZec8hIrAj44TLcm+oXV0Wy+xF/cdtGRcZqklCiJVXna7AjViQ0QVxSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x4isfwTrks12DCtibuSTfKJRdDTgVQxraYV00JzWvOo=; b=VVwXi2DZt+1+NzUquH7W/zJuh+iAmrObP8uPYZIQ6K+8K9mPVuoCwoQI1/+EGqWvpkT2lhWyWhAT/KexH+lBsKdwC2kntrQh2WvhJRVo+V2cuiabj3uyqQ9OU77FVJgqXIHs/8FG5Lv45hZM3KGSsb5bU1iezY3MkAyk1VYHzWg= From: George Dunlap To: Andrew Cooper CC: Jan Beulich , Bertrand Marquis , Julien Grall , Stefano Stabellini , xen-devel , Juergen Gross , Roger Pau Monne Subject: Re: Process for cherry-picking patches from other projects Thread-Topic: Process for cherry-picking patches from other projects Thread-Index: AQHYZtZ1suK3TAKIFU2tuY9R7u+Tcq0hnruAgAAES4A= Date: Mon, 16 May 2022 15:19:39 +0000 Message-ID: <25097F0A-9EE9-4E74-960A-9EE9F34BDE54@citrix.com> References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 315488b4-97b6-4c6b-145a-08da374f7eee x-ms-traffictypediagnostic: MWHPR03MB2830:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y869hgEI0DXRLB3kKCHt26RZrkZ2DpXNlb2IgQTdjcT1IdBPVplOthn5uVNyc1abazKAX1Op+bUwWKVDhbWPdrbAE1AlSHoe5yb+xZDSc2rUb2BooHvqA+GMb8cj1WFEAK7/DyvPNMi/RKZsmYroLh8l2nl2QbiQxUzYp8Ff9BebjwzlBt8H7af0S0EWyf6syGdsEBsozZOzmi1pNJlDLV0ineHNn6rryU6vxwIGtLuP+/tgDYhhhXiEWSE7fv1cqvNDNlMDdPzsEWtB8qD638MUYJWlIqfYfH6a/dzhD7rIaGvv2XWnxqK05neTXctvAIMef0mj3hOxuVZsiM1JEvax/BCJI7wMD7Y9CdqJJycVNK/BSbThKoViR8uvdGsaSyIPVldpDf38z3LU90GGQ3ZFecFrTe4iHZMcLqsVynPQ7QPUct3mY+ffkcU4kn1GeBCxja6ead51QepNglwRcJW80wetIgJo3w2l8QBtWIVrjH/Yy1v3kqEdFRGuVX2d4Lb2JG3meIJy5Zvsw2uoxl2NJZndpqh9NjY69B5f8RNwH358IR1MJ+YT3wp15RkfpTkfm9OKzwF3eS41IqztuJurjC0aLguq+UzSo0YquPWjHXB4h+uFFSL34htXSviMUaR0tj/f901DCgxdCafHoCFhRHV5VL77hjOs190yOLTez5MSW4KExV/7jEvtgUWK75MbHGyFUevQMvrJVH+0zWZHWTfzjS9ucJ4HxzK5zypCU/ms5Yl4KeBpEC92Tt6e x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(71200400001)(186003)(316002)(2906002)(508600001)(54906003)(37006003)(6486002)(26005)(6512007)(99936003)(53546011)(82960400001)(38070700005)(91956017)(122000001)(64756008)(76116006)(66946007)(66446008)(8676002)(6862004)(4326008)(66556008)(66476007)(33656002)(2616005)(38100700002)(8936002)(5660300002)(6636002)(83380400001)(107886003)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VTRrV1VhT0w1a3FqYTB6QnFVbDVJNDVRNklrMk9nRFhVcm1mQmpwRUlrRDFp?= =?utf-8?B?S1V3WGlLellRM2swZ2FpekJZWllTdk1HQXVERENlbmkxZlJ4VEwybG5RK211?= =?utf-8?B?eTJmTjRsZytrbWVjZEhBR21jeUdKQXI2S2hMSDY5UHc1VktaMzdTTWUweVd2?= =?utf-8?B?dGtTa3kxZHBoME1EMjRWQ3NZTmNvWjJVYkhqZGRyUnVlNGVCV2hGWmdIbVdh?= =?utf-8?B?cDVuUzJHOVFYdUVKTllIYVZwdkwxTm9lamdSaFlhN1duYjVTU2xpeVBZRXR0?= =?utf-8?B?MnRjVjVtSFdPczNIMVlOUFUvem1RczBKd1l6QWpaK2ZpYW5HTmRMSVBmNVAx?= =?utf-8?B?OGRxVnZtVVJibXBYWnQvSU5SODVSYTlDZ2Ryc1pxblhoNGlrM1R5QzZnYitj?= =?utf-8?B?OSt1aTdsamZmbUswZi8wdmJzbEFwU3BPRTBtNGFVeDdrNU5tUlhnZ016MVoy?= =?utf-8?B?bkdrSVhtUmFKQXUyakNCc3RNWWF4dU1HNlUrV3ZmVW1XRnBzUjJzMWlpSHZw?= =?utf-8?B?MlAyNEJ4OVlFb1hiWnFrbnhBendGNUc0MkNXMFJWYUdyREM4dTRUbEpXQkhJ?= =?utf-8?B?TEViQ28rOVRVRlgxNHFIU3YwYUFBK2dOU0dhNTBYZ3RrYTZDbnByY003OUYw?= =?utf-8?B?NGVPMTk5YVlERzNWSUFwcHhKZ2ErTUdpMzk5b3lQYlV3M09hNnIzbVFLQnAw?= =?utf-8?B?SGtJZ0VYVGY5eHJ1Vlc3a3Q3eXpBZ2dGdGZiQTR6K0xQcnNlRzBLelQwZjdt?= =?utf-8?B?M2dlUFpNeXJMcDF0OW9TT0VMZ0lrWjZFdTZadnNqRzE4cmFkR0FuQmJvZVZk?= =?utf-8?B?YlFPS0VTcVJRVXkyUERYalVBaVhJVEFUSnBYcVl5M3QrYW5WeFNwbzhjeitY?= =?utf-8?B?OVBhSkJoeDMxVWY3cUVWcFNvakhtcHRjOXZiallnT203b2hUdGZ5TzZ0QUdy?= =?utf-8?B?eVRZMWpvWkkwa0hRTWpSdnVVd0ZINU1tUm4wMDV2Y1k4dnFycDJqYWtNdzlr?= =?utf-8?B?NFB4V3BXc093TllvamJWcTM0WTVMRzFsTUIyaE93dGZzWm5Xa3ZlNlBhK2xt?= =?utf-8?B?VFIzQnQ1OUpJZy9BS1pwZ1Bzdzl4dkY2RWl1aGlwRkc0WHVsOThRLzRmTEh3?= =?utf-8?B?MHduQ093b0JVOXJOS2RtaTVBU2NrWHdYZ0dDcGNibGRvQXZlTkYyZGdPYVlI?= =?utf-8?B?Y2dTNVpvNE5VVGprWDhKVDdHOGhVNEFzejRDWGVaQWRkSHhJN1I3NmJLeUZF?= =?utf-8?B?S25CMDBhaE5HejRuTGlpME5oOU9SckFoSGIwODd3ODRUOEw3dHZJQWNKMUVF?= =?utf-8?B?elVLMEF0WW92R2tQQ3Z4VHZKdWxEUVYyNFdUNVhhNU12NFh2WmZHUktKRHlR?= =?utf-8?B?bFIzUWhDNmxYa1ZqcXNYR0lKQ1JYSWs4MWJISjF2K1RaaE9teHhFQmZBcGlH?= =?utf-8?B?eTREWFJpL2o0cFNVL0ZPcjEyL3VSUjF1cStGbUtWdGdHRUJidzFXTXFPRWE5?= =?utf-8?B?SFMvbDNqM1R3VEQvY3g5ZWw3eGRKSHl4RDNxWWhtdEVoRFA0OUxhTFVzVkNH?= =?utf-8?B?N1FDMVA4SXd1SjIvRWl4NG9lb0RzN2hzTmN6NkYwOFV4UTRRelJQWTJ5RUxn?= =?utf-8?B?UVpZanB6SWxWemdmdUszdEp1eWxFQmRRQllLQnVUMmp4aDZBaWExYjM5d1hs?= =?utf-8?B?TEowQS9lbnFsTG9SVCtZdWg0ckVmbTJISmVqUmIwWGVoSXQ1NWlSQkorR3RS?= =?utf-8?B?WjRJSDRWNWRodkZGSnlWVVdzZEpHd2Q5UG4wZlZiV1pYcVZ1NkVPcnptakk1?= =?utf-8?B?ZEI3RmxpSC84Zzk5c1NwRHBlbnZYeVV0TnA5YytKbVJOc0ZYeW84RVk4VE9T?= =?utf-8?B?M1NlTCtyUnRQQkN6OFRVR0IrRzJFak52dCsyOGt3YWhqUmVwSXN6UUg2Q2Uv?= =?utf-8?B?K0FlNXI5TDNEMFdFY282M3R6SWUwTnIwZ3M4K2xPVE42Y1BEMWRkNXpPdnhy?= =?utf-8?B?em96aSsxS0xhYnlUSlN5KzlJY1VLb0QwTDUrZkFJYnZhS2hiU2QxQWpwQmpn?= =?utf-8?B?VGRXYkh5WW93RG5kQWQxVmc4WGxtdmpsalNhZ2IzWUhqSVFjZklYK245WVBE?= =?utf-8?B?aEp2VWFjRmZJdHlHTmxZb2dvNHZUMGJDcWl2enR2TjVLMitJdHFxVEgxVktL?= =?utf-8?B?Ry91bi9EMVRHOU5EN0FXeWgvaUFDZVRTWktxcFZrQ0taMkV6VlFqS3hsRXZQ?= =?utf-8?B?TUJoVUVPd1pnc1k5OEVqa3FLREpBNDd3VnFjNTd0ODVQbklIUlQxeUhkUmkz?= =?utf-8?B?ZHRBRUdaUzFwMkVaZXU1ZzIrL25LY0hpV1VpYlpLNmdhNytiNEtnalVpZ0Fp?= =?utf-8?Q?ppJtIvNxQlPvV3fg=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_C76ACA2F-537C-435B-94A6-AF8F78115E50"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 315488b4-97b6-4c6b-145a-08da374f7eee X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 15:19:39.7510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kGY9UDSZKKB0I/vOlnxr2IP6htLfDyZP6eE7pWw2PytkuVnE8HpzdmERoXHZsCrzuAB+1x7HziHs1DuIIhKmg7nrisevYlUSxpOE3+wDXbc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2830 --Apple-Mail=_C76ACA2F-537C-435B-94A6-AF8F78115E50 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 16, 2022, at 4:04 PM, Andrew Cooper = wrote: >=20 >>=20 >> 4) When importing an entire file from an upstream like Linux, what = tags do we need? >=20 > Any clear reference to where it came from. >=20 > Nothing is ever imported verbatim. If nothing else, paths have to be > changed, and usually more than that. >=20 > Given that, I do question whether it is appropriate to retain original > authorship. The original author did not write a patch for Xen, and = what > gets committed wasn't the patch they wrote. Not sure what you meant by authorship here =E2=80=94 do you mean in the = git commit? In the GPL header of the file? The original author (or the company they work for) may own a copyright = on the code; if the owner of the copyright comes around and accuses us = of infringement, we need to be able to a) demonstrate that we are = generally trying to respect copyright (by requiring people to assert = that the copyright question is all in order for the handled code) b) be = able to track back to find where the infringement happened so that we = can take appropriate remedial action (either education or sanction as = appropriate). I think if the GPL header of the file contains =E2=80=9CCopyright YYYY = by ${AUTHOR}=E2=80=9D, that copyright notice should be retained when = importing the file. -George --Apple-Mail=_C76ACA2F-537C-435B-94A6-AF8F78115E50 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmKCa4cACgkQshXHp8eE G+1eagf+IbEnEZv94wIm7CFtc6fJ3t6pa4QGwRP/WAGztZ1oK1Mfe90djMN18YIb bW4nkoMxdOI/1N0Zf1WfU77gbd9BQz/7aDaElz/F/2N8FPFvaBN3qugWHTibaUK7 luGgAm2gliCGjbwlmf20cm4sPRNGE3V0KTcSlXZ47oaZxaOjws4qAFSUb4RKmDDF UVFTLdLI+LzOMkZF6Cu8Pa12BzUzFS+F+DBca17YAYG5Ia3tVLKKEPH6IeBUv6JW Wj39L3l8tHL18iU2ZIzwLcVhOj1JgX+10ZTRTDW6QkAqOqpXqCsXX1+e/sdWncuH npjG3cw/MNTNRruP+DFQwWBN2Vw/qg== =Q8Lk -----END PGP SIGNATURE----- --Apple-Mail=_C76ACA2F-537C-435B-94A6-AF8F78115E50-- From xen-devel-bounces@lists.xenproject.org Mon May 16 15:20:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:20:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330015.553321 (Exim 4.92) (envelope-from ) id 1nqcWn-0000CA-FG; Mon, 16 May 2022 15:20:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330015.553321; Mon, 16 May 2022 15:20:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcWn-0000C3-A2; Mon, 16 May 2022 15:20:57 +0000 Received: by outflank-mailman (input) for mailman id 330015; Mon, 16 May 2022 15:20:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcWm-0000AU-Ag for xen-devel@lists.xenproject.org; Mon, 16 May 2022 15:20:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcWk-0004fC-Ah; Mon, 16 May 2022 15:20:54 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqcWk-0002Cf-4H; Mon, 16 May 2022 15:20:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XopcBKqLeTmo9dkuZElcVOR1lHoBUGqlYZjHzqwCY0Q=; b=bd0VygL/WoLZ/X2UnVgP8tsinO uHUWxVx4EXntxEJnXc51BraaK8P2FnngykO4mlARGoPiTV2UTq6anLsOIGE/11Nfn/VbzQd68S+nV 8XogBiuRUu5D+3Kf7fgdKpz/+R1rlc4mmvlRXDKJXQczTFyPJsPlsdqDZN5Q6LaDudjw=; Message-ID: <7903619c-4a6e-802d-289c-03aefbede967@xen.org> Date: Mon, 16 May 2022 16:20:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Process for cherry-picking patches from other projects To: Andrew Cooper , George Dunlap , Jan Beulich , Bertrand Marquis , Stefano Stabellini Cc: xen-devel , Juergen Gross , Roger Pau Monne References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/05/2022 16:04, Andrew Cooper wrote: > On 13/05/2022 15:33, George Dunlap wrote: >> Starting a new thread to make it clear that we’re discussing a wider policy here. >> >> This question is aimed at Jan and Andy in particular, as I think they’ve probably done the most of this; so I’m looking to them to find out what our “standard practice” is. >> >> There have recently been some patches that Bertrand has submitted which pull in code from Linux ("[PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3”), which has caused a discussion between him, Julien, and Stefano about the proper way to do such patches. >> >> The “Origin:” tag section of xen.git/docs/process/sending-patches.pandoc suggests that there are some standards, but doesn’t spell them out. >> >> The questions seem to be: >> >> 1) When doing this kind of update, is it permissible to send a single patch which “batches” several upstream commits together, > > Yes, absolutely. > > We do this all over the place. > >> or should each patch be backported individually? >> >> 2) If “batches” are permissible, when? When would individual patches be preferred? > > That's a matter of taste.  If it's several patches of a complicated > bugfix, then it probably wants splitting up in the same way. > > If it's a bunch of misc changes, then batching is fine. > > >> 3) For “batch updates”, what tags are necessary? Do we need to note the changesets of all the commits, and if so, do we need multiple “Origin” tags? Do we need to include anything from the original commits — commit messages? Signed-off-by’s? > > "Update $FOO to something resembling $PROJECT, $VERSION" is perfectly good. > >> >> And a related question: >> >> 4) When importing an entire file from an upstream like Linux, what tags do we need? > > Any clear reference to where it came from. > > Nothing is ever imported verbatim.  If nothing else, paths have to be > changed, and usually more than that. > > Given that, I do question whether it is appropriate to retain original > authorship.  The original author did not write a patch for Xen, and what > gets committed wasn't the patch they wrote. > > Any issues with the port into Xen should be sent to the person who did > the port into Xen, not the original author who most likely has no idea > that their patch has been borrowed by Xen. I agree with that. But I don't view the "Author" line as a way to achieve it. Even for Xen, it is possible that the patch was written by A but then fully upstreamed by B (they may be different company). In which case, the practice so far has been to use A as the author and add a 2nd Signed-off-by for B. I view porting a patch from Linux the same. If the changes are minor, the original author should be credited. > > IMO, a commit message saying "port $X from project $Y" makes it crystal > clear that the original code change isn't mine, but the porting effort > is.  Amongst other things, porting invalidates any review/ack/test chain > because those tags were given in the context of the original project, > not Xen. This seems to contradict our documentation: "All tags **above** the `Origin:` tag are from the original patch (which should all be kept), while tags **after** `Origin:` are related to the normal Xen patch process as described here." Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 15:27:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:27:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330026.553332 (Exim 4.92) (envelope-from ) id 1nqcch-0000yL-7d; Mon, 16 May 2022 15:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330026.553332; Mon, 16 May 2022 15:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqcch-0000yE-4e; Mon, 16 May 2022 15:27:03 +0000 Received: by outflank-mailman (input) for mailman id 330026; Mon, 16 May 2022 15:27:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqccf-0000y8-PW for xen-devel@lists.xenproject.org; Mon, 16 May 2022 15:27:01 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a057a6b4-d52c-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 17:27:00 +0200 (CEST) Received: from mail-dm3nam07lp2042.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2022 11:26:57 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BL0PR03MB4004.namprd03.prod.outlook.com (2603:10b6:208:65::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 15:26:55 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 15:26:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a057a6b4-d52c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652714820; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=d/V2acFVS7vzd2Gr0vRi+9dQfQBC0UTxPxQsp/pELb4=; b=IRIsQF0pIa0hbK5jYWDhhQ8ZBGlnJ7/2EiFIp1Ec2T2emJH0OgOUy1a0 XrS/gWbXsHqm7q/1hELN2/2+E3u/gfRJaLfSHv4v8WZBoTFAmvI3lQILi impJvf+eHUFAML6lyvIZgBv8CZT+PLK29ov1dMBcVrc3hxlpaLkTLx2H6 s=; X-IronPort-RemoteIP: 104.47.56.42 X-IronPort-MID: 70791172 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rD8hP6n906Cq1W5TnaTAz+jo5gwvJ0RdPkR7XQ2eYbSJt16W5oA// 9YtKSrfbaHbJie3LscnK96GQXl2ucfSyNQyHlZrpCpjF3xE9ZLJD43GdRuqMynIf5adHRw84 5lBZ4nKd5w+QCSF+RmjaLK79HJ23PmGH+ejV7DOYkidKeMcpAIJ0HqPzMZl0t4AbaGFPj6wV fPOT+z3ZVP5hW4vbzNIsv7e+Rkx7Pmq4W5D7lZuO6wb7Q+Cx3VEUJ5HKa+PdHapGYM88sxW5 grgIBNV2kuDon/B3/v8yu6TnnUiG+KUZU7U4pZvc/DKbiJq/0Te6Y5mcqtFAatro2/RxYopl YwT7cXYpToBZcUgpsxMC3G0LAkmVUF20Oevza+X6JH7I+XuKhMA8t02ZK0EFdRwFtVfWAmiw ccwOjEVBi1vssrtqF6NpkuAsex4RCXjFNt3VniNVlg1B95+KXzIa/2iCdO1QF7cLy2BdBrTT 5NxVNZhUPjPSx5MYG4VCoo1p/ep2EijdzZXp2u7hINitgA/zCQpuFTsGPz8X4TQAOlwxQOfr G+A+HnlCBYHMtDZ0SCC7n+nmu7Im2X8RZ4WE7q7sPVthTV/xERKUEFQCQT9/Kf/1hTWt9F3c iT4/gIBoK8o+0HtYsT7WxSgiHWFogQdS5xbFOhSBASllfKLsl/AWTJsojhpbtYBlsQZfgAT2 xyOn9XvHB5js4XKVifInluThXboUcQPFkcAeCsFQA0t89Tl5oYpgXrnTNxuDaq0hd3dAizrz naBqy1Wr58el9IR3qO3u3XOmSuxp4PhRxQwoA7QWwqN9RhlbYSoY4ip71nz7vtaKoudCF6bs xAsi8WYqewDE5yJvCiMW/kWWqGk4e6fNz/RikIpGIMunxyv9GSkZpt4+yxlKQFiNcNsRNPyS ErauAcU6JoIOnKvNfBze9jpV55syrX8H9P4UPySdsBJfpV6aA6A+mdpeFKU2Gfu1kMrlMnTJ KumTCplNl5CYYwP8dZ8b711PWMDrszm+V7ueA== IronPort-HdrOrdr: A9a23:Wj3Su6yrztsT4z+isi96KrPxgOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SETUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZHN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUezpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZrcI5p4dYyxY/ouW3fRYzWTFcFcsnq5zXQISdSUmRUXeR /30lAd1opImjXslyqO0GbQMkHboUoTAjnZuBClaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77WzAD0ihbWAUqqOYmwtVrQcotQ0XbWLeUs4ikaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPIcFyZMj8a 6xJ2+wdVRCD34GJff+rKGjqCq9MVlVdQ6duf129tx+pqD2QqbtPGmKVE0u+vHQ1skiPg== X-IronPort-AV: E=Sophos;i="5.91,230,1647316800"; d="asc'?scan'208";a="70791172" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlVKw9hzAVy4lxLQ573sW/sw6BCUDmwECDrDHb1cp1LdpTdeccGoWfn++oy7Fujb1g5y/MgXSPalQPVNBdjgvhaRuUKJVGOT+aucxntxXbTPdfVO5U2sfVmi9bOBhyE+baotGwjC1+RroRBOFDJngggkF1xaMuMo5R9iK27u1QbvbS49SxoNIL3pLiWi6nIlwH/FhRej+mo3K6sHfpi0XPmlEJ9pfliKOcgDavMexSs01OEVusP3N0mpCziDHK4A3jGnYAHojJIXqyBu7NQj9XmaKBQ9WnihaqAgnlcf11BoIBUDrQKVtuCERcY21YtVIQDUPxJBTs7zAGHLcfwhXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U5ioPv1ZSZK2Cx2QMXhFiXo5oWDmtWmFZAFjma3ja4s=; b=mQ+xbfksmcMqWGBT41Xpll8GlI+MMyHDxpA+kfjzvQQvgKjGXy5BccSZ+AolWbLe67c4ZypFa1LDpYHMqsbwWZ4PhyI9STWcVICbfgi28gwGiq6Rw3HCee8QG6WYL6099MAb/nxjmrmEfjjM5ec5VjWLh7slVx0xWzRP/esQhNDXIpuMAI+3dMby0WezFjYdghOXJTZrQv6UxdU3/4+LvtYG48il6CYHcmVF1Iq8BMUq3J9jSV4VTugtC75w6qJPKcF0YBkPP0rq+1nrRetW2NOn2PU1GWkcHkav1WLE2nYhZiZVVjKVB+jm5dky/V6qWQDZHk2gpg3vf+UcQRZCYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U5ioPv1ZSZK2Cx2QMXhFiXo5oWDmtWmFZAFjma3ja4s=; b=riWaVgUbr6MPoINn70oIvg5QiR+XRztXkvMFoInMBbBp4XaaaCmNYPMtZ12f0nRIEl1xr83jPmm/mc4w1IT3quZ64HAGCk8LRCacirBfUohI+yrAeQn63e4hwQDfiD3nbwNhwK4RNWdtOITZgufcXcoSsh0jl8wAKH6TQxIB22M= From: George Dunlap To: Julien Grall CC: Andrew Cooper , Jan Beulich , Bertrand Marquis , Stefano Stabellini , xen-devel , Juergen Gross , Roger Pau Monne Subject: Re: Process for cherry-picking patches from other projects Thread-Topic: Process for cherry-picking patches from other projects Thread-Index: AQHYZtZ1suK3TAKIFU2tuY9R7u+Tcq0hnruAgAAEpYCAAAGxAA== Date: Mon, 16 May 2022 15:26:54 +0000 Message-ID: <52224003-C93D-4136-866C-2958A28D2A52@citrix.com> References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <7903619c-4a6e-802d-289c-03aefbede967@xen.org> In-Reply-To: <7903619c-4a6e-802d-289c-03aefbede967@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8bf7f9e0-82ba-4ac7-f1d3-08da37508254 x-ms-traffictypediagnostic: BL0PR03MB4004:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vTECly1M7fr4xrUjrBjtTt3il6rEDK4sVCWIpzpyKfXJ/BQbyo2mGz9mWaXtAzL+l/hfYb6bpKMM/asfpCX1qWUXe8LscB48abVIskhaDW2OyAUUl6fEtCiIIeBcbB7fTRt3OILu/Q/n24KwXIXxF0brYpHGAMBnk6rJIBGxpsV0kG7E8Liu0zC98RcWDSubCKPDr4yru8PSkZLQu9qDKTKr8/UVjkC5FFysW+W3+K0GwC4q2zo+qNMYfUWoOaMhyC5WTnXFJRLdOLN4/MtaJZng2M2TtueVj9+FenyraDbk0kTFlkD7HLlog6irmM2QDJWVJjICu8kZzWP5F9vAme6v7srG+hThqCPeolHlarbnyjlHYFP8qxVzGoCvpFokGgu0uydgs3IrGFIqbvOQvOElYx9sFIfhD4tO/pe91nt5v1I32ftbW/TNBYVyfEWQYMa6g9mU/PDb9Nga9x/wSaBeeMVR/OXnaNV9KffudcjAtRJmJgw4ezZWSUb8E5n+1t/KBGJ+Alc0DydqbHi3zu0CU9DuFIZpTWhLIMS1uoMIe+Xje+vqlqrhYXk0SW28H9RCtQTWpt5LNrdKint2WYywwH/STizbg5R9FkcJKQXTd4iWDLh6a6SNJ5o45hlpXp/oyjGIXhz7wmXjm4QRKDKYL2/4hKjqkZDc2VmyCSclvWJvNaKK+g7/D8m4g/BVUhoivx+eigzlvujb78ivJ2br1lVqXOzOt2DuadZ4NrPunnCyDmVENIS6+jULAYoB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(8676002)(4326008)(6506007)(66946007)(66556008)(107886003)(2616005)(64756008)(82960400001)(33656002)(91956017)(53546011)(66476007)(66446008)(8936002)(2906002)(26005)(6512007)(71200400001)(6486002)(316002)(54906003)(6916009)(508600001)(86362001)(83380400001)(38070700005)(38100700002)(36756003)(186003)(5660300002)(99936003)(76116006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UXhmMWRobmdZM0x3bFE0Q0VYQ2o5Qi9USlJpcUpnbTQzRkRHb3A0UTU5YnM2?= =?utf-8?B?ZXA1c2NsTGl5eWFEVmdjbWFROEI3TjFYZUZrVXdVZG5nQ0E4ZmZuenhKQU9D?= =?utf-8?B?UllVWCtSUU9mZGlTc3VyaStBNHNuOGFMSXU1ZTBEVU1uSXN4UXVlVTcreW9r?= =?utf-8?B?NytJQ1hTTEduRjc3OHBxK1ZYaFR3Um5RekxCeXVieGRBbkdFQ1JGZ1JqazhS?= =?utf-8?B?RytkVVYwZXp2citoQlNqYmpoajI2M3VOOUNZRXFmM2VIVFYzWjUwRGZTT2U4?= =?utf-8?B?Zkw4UTdPdFh2djI5aDViSFhYMkJRTDdyNXJnQjBLUzcwOHQxVDRGczc5Ym5L?= =?utf-8?B?a0VzMlVNMUgwcmppcnhlSUJUMmZIZUFpZzNIcnJlUkcxRFQ5UmE0MG5vYU9T?= =?utf-8?B?ODc4L1d1a2U2bFVsTUEzTTJZZzRDWkh2WnBiaWtZWHdKZFRJK2xNcFZrUEdW?= =?utf-8?B?SWNFejV0eStzam91cW1sUTRXNnAxalU4elpIUkhBR0xsL1RXTDVrNDdoM3BK?= =?utf-8?B?WmErKzl0TmE0bkxTYUdVYVVBZGE1OTBodnRRU3dHOHQyWi84dks4b0JZL045?= =?utf-8?B?Q1FScG1EUk1xT0ZqeWVWUm0wdytUcnJwQWhXU0U2YkpOdlJUVUE4aHJzbzdh?= =?utf-8?B?UUd4akxQNzUzaG9TU3BDbHczVURkRnYxZzVPb3FweTkwejFsTndlZ2MvaDlV?= =?utf-8?B?UlVneS9aNmhpb2NKZS8rKzUxOTNDNGdLZTNyc1hIcm1IaHduanNQWW8rVTdR?= =?utf-8?B?elp5WVFNZm9IRk1mU0UvUnZ6MXRYZkJsRExaZnR2NFFiM1RncE5CR09jOGFQ?= =?utf-8?B?SHNsUGlKTWI3cEVmZEdhL0I3WlZEb3pmL1hRRmFRVlhaYVM4eWozdmVhdXly?= =?utf-8?B?bTk3M0FSdTVpRkNsSVZsTmtnZTdhd2Q1SjlFbFVvS2Uva2RxdVowanVETzdB?= =?utf-8?B?V3R3djJXOWhnYndZdEJxdXBxWk53YUFiQlJZVDN1Y3czRzZyTHNoMVp1dEpJ?= =?utf-8?B?S2U1M0ZybzljMG5RQWdaVWFVUXluN1ZYYmtOYVd5L2ppRXdtUDRuaGxCcFpO?= =?utf-8?B?emtmMU9jSW9KS0c0VU5XSjNGdkFvdFpDcDc5RGxrREpDdjNJcG1BZGtHdVU4?= =?utf-8?B?emZhZUNQWGZMTXVyUXFCQXI1UG5SRXgwTHZtZS80KytDU2diQi9jT0pCK0JB?= =?utf-8?B?am5Pa0crYTVBeENNcWYzdm5ObEQ5MEROWmt1Q3BSODBjbnNIRlBDQzJSMlJh?= =?utf-8?B?ZUN2bzhTZ3FlelltNXIrU1BWN3ZvQjY3aWVNbGwzZXROWnp6dVJJTWJkRmkv?= =?utf-8?B?c3FsM1JUajc2VXh4QnpDU2dwYSsvS2pGQm1LZGM0NlNHc2ZzN0pEZkZ0R1Yy?= =?utf-8?B?anhjT3VVM2tIYTV4enZabXRBMHY0NHNmNERodzFUWDB1UndQUGtEbGNnQkVH?= =?utf-8?B?ZjFzLzNXL3o5NUZVWDJKa3lUWm5pUWhxV2FtTG1Nc2czYzhYZDdIY0hBMzJS?= =?utf-8?B?SHdOZGlzNCtEa09RSDRRNE1XMDFGdUxUcHZBZlR5ai9TV1lsTHZXbWxqMndL?= =?utf-8?B?OHJJYmxYT1NFWHdsekczS3VsVmMzRHl6bXJqZVRVNjhCS1cwdEVQQzQ1OC9i?= =?utf-8?B?RXVBOVNNZlN5VllkY25PakduSFVNdGprd0xXYUhoK0R5aDJBY2IrRXR3TVJw?= =?utf-8?B?dXlEeThIT0ZRekJ4NmZUUmlCZ0k0WnR2dmRRV2RUTXRMSTF2c21UWWN6Rmk2?= =?utf-8?B?RUVNMDZJSmx3d0FMcWJENkdyd2xpSS85bm1DUDZaUFQ1UCtzS21zNkhlVzdC?= =?utf-8?B?N2lzdzREeGRranRtNWFiUVBiRHVZQmUrYUMwQmpma3MvMnZnV3pTZjJyMFlu?= =?utf-8?B?K1ZPWWdpcDNZQkVhU3ZCVEUxaTNha0llQWhINUd0Uzl5aVd0eGYrL0hTTzJa?= =?utf-8?B?RVlPSS83WEJpTmpVOUVjRkNYTnE5c1NNRkVKK2Y1TkxQUUFsZjNQVTJKR21u?= =?utf-8?B?enJaeldZUlgzY3pwTElNNWZkTm5NTU92SC9hNEQ2cDVrTDFQcTRVV0JyLytS?= =?utf-8?B?RHk3VUgwN0NaWnFncmxqT09mc0ZmSUNBWXhDVUV2bWd4Zi9UbWQ2RGJNdHhl?= =?utf-8?B?YkFMWG1DejJCTmxwZTBzNlJlTUd2VXhaZmVpelhqeXlwMTBsZW01NGo0dEVj?= =?utf-8?B?enlYK3RrZ3RDaW1SYzRlVGdjZDN4a29ZVml3WWw0RWN6VHQxTi9ZaElVTjUr?= =?utf-8?B?ZjM5ZkZ6TEM3Rklkc2Y2ekZUemtvRFdiT25iSlp0SXJpMHRQdjMvUkduM3dO?= =?utf-8?B?REtHZGY5Wk9GOEdYTFhyZ1UwQk40QnZkL0tqcVJtQWl6Qm5ENTZHTS9kMTFu?= =?utf-8?Q?pO1l3W4G1EtZveNA=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_68762BA6-6632-48DB-8580-962503A3258E"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bf7f9e0-82ba-4ac7-f1d3-08da37508254 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 15:26:54.8300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uRimrJHP87ga+xCeAcXRGUGzUdzHuEEt/Z0uB4SbfU92+cPVaFA6k5OWttrxU7GMMao7lMxNuPK3NAs4A/uB4OonjAw04qzOKL37fe/QjzQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR03MB4004 --Apple-Mail=_68762BA6-6632-48DB-8580-962503A3258E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 16, 2022, at 4:20 PM, Julien Grall wrote: >=20 >=20 >=20 > On 16/05/2022 16:04, Andrew Cooper wrote: >> On 13/05/2022 15:33, George Dunlap wrote: >=20 >> IMO, a commit message saying "port $X from project $Y" makes it = crystal >> clear that the original code change isn't mine, but the porting = effort >> is. Amongst other things, porting invalidates any review/ack/test = chain >> because those tags were given in the context of the original project, >> not Xen. >=20 > This seems to contradict our documentation: >=20 > "All tags **above** the `Origin:` tag are from the original patch = (which > should all be kept), while tags **after** `Origin:` are related to the > normal Xen patch process as described here." And indeed, part of the the point of that paragraph is almost certainly = to clue you in that the =E2=80=9CTested-by:=E2=80=9D is for the original = commit, not the Xen commit. That paragraph is clearly expecting the case where individual commits = are cherry-picked, not batched or done with an entire file. In large = part we seem to be in agreement, so we just need someone to do some = wordsmithing of some text to update that file for the =E2=80=9Cbatch = update=E2=80=9D and =E2=80=9Cimport a full file=E2=80=9D cases. -George --Apple-Mail=_68762BA6-6632-48DB-8580-962503A3258E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmKCbT4ACgkQshXHp8eE G+1aRwgAm7+QHDGJD2IZeA0mQ93AsYYbkeL1ZwK6/Qtfni1J5zLXffEq0R5Lsjew iaTof5QHX5kPA4URifyaathJyhs/7oigSo+TNshZqhsXfPWLDMy6BYmRcz5WKoz6 Vnai8trq87u6F4jp7Lg7VKaVFyyCdl94PGKZTyQWykfyQLYrq4fdTSe0hUxPxeal SIBKs2yCsMjrTxLjk6pvdmMVH76BuKCjMeizByJRAa6Zf8E/QnHQbZ/oBQIFttDc b4oEwvOqQjq7MKchVDIgJA0ru1/SXVGAeBTIeCfy975Fk9X+AB++do2NfTwrmeYy Wtmtym0HbFmoJEINZKUDZRr1skWfBA== =Bnp8 -----END PGP SIGNATURE----- --Apple-Mail=_68762BA6-6632-48DB-8580-962503A3258E-- From xen-devel-bounces@lists.xenproject.org Mon May 16 15:56:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 15:56:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330035.553342 (Exim 4.92) (envelope-from ) id 1nqd4w-0004ax-HO; Mon, 16 May 2022 15:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330035.553342; Mon, 16 May 2022 15:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqd4w-0004aq-Ee; Mon, 16 May 2022 15:56:14 +0000 Received: by outflank-mailman (input) for mailman id 330035; Mon, 16 May 2022 15:56:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqd4v-0004ag-WA; Mon, 16 May 2022 15:56:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqd4v-0005GU-Tf; Mon, 16 May 2022 15:56:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqd4v-0004Zh-Ik; Mon, 16 May 2022 15:56:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqd4v-0001tt-IH; Mon, 16 May 2022 15:56:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MDW8VOvFS/GwF44ca7y1cwMwo8lVXKuf/YEUhDCunz8=; b=3DcfSvrdad5CiYAaYOeBQeUR3W S0nGVy204p0Gj3q/Yl2BgVhAHra+Lj1XAMewrmIdmmBO65lJwK3+ckcAb6xwmQruR0o4RUXilocWj TaIaSDqQE2alQAmGhzSin0rJ1gTOmYd5C0rIfU9dzzHBxEnHj4hDo7oBiw0bE6fA/8wk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170483: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 15:56:13 +0000 flight 170483 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170483/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1045 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 64 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 16:04:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:04:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330045.553354 (Exim 4.92) (envelope-from ) id 1nqdCY-0006cJ-DX; Mon, 16 May 2022 16:04:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330045.553354; Mon, 16 May 2022 16:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdCY-0006cC-A7; Mon, 16 May 2022 16:04:06 +0000 Received: by outflank-mailman (input) for mailman id 330045; Mon, 16 May 2022 16:04:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdCW-0006c2-Ux; Mon, 16 May 2022 16:04:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdCW-0005wF-RO; Mon, 16 May 2022 16:04:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdCW-0004ry-AB; Mon, 16 May 2022 16:04:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqdCW-0004eR-9h; Mon, 16 May 2022 16:04:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5WFDFEG7l6ms01dGgA6sGCKF2Jct8IEPnfmI6hqxHTs=; b=v/+y+s/SePEjRXy2On2Uur8KnZ unG3o8DqnZvPG3r51sroezFSiLJSWztliJKJE0L7Wov/R0U8UIQd8S15CfQddLBgLR6bPr1+vHoUu TOhU29Uyccg+De9ZEVOxDVGmGh5vRZxUf87bGVNZ7IuABcnd8Ke4aUfxPFfZ41vpZLNE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170472: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug linux-linus:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=42226c989789d8da4af1de0c31070c96726d990c X-Osstest-Versions-That: linux=0cdd776ec92c0fec768c7079331804d3e52d4b27 From: osstest service owner Date: Mon, 16 May 2022 16:04:04 +0000 flight 170472 linux-linus real [real] flight 170482 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170472/ http://logs.test-lab.xenproject.org/osstest/logs/170482/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-examine 8 reboot fail pass in 170482-retest test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 170482-retest test-armhf-armhf-xl 8 xen-boot fail pass in 170482-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 15 migrate-support-check fail in 170482 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 170482 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170459 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170459 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170459 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170459 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170459 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170459 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170459 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170459 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 42226c989789d8da4af1de0c31070c96726d990c baseline version: linux 0cdd776ec92c0fec768c7079331804d3e52d4b27 Last test of basis 170459 2022-05-15 21:42:30 Z 0 days Testing same since 170472 2022-05-16 05:17:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0cdd776ec92c..42226c989789 42226c989789d8da4af1de0c31070c96726d990c -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 16 16:07:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:07:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330056.553365 (Exim 4.92) (envelope-from ) id 1nqdFY-0007Hz-41; Mon, 16 May 2022 16:07:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330056.553365; Mon, 16 May 2022 16:07:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdFY-0007Hs-0I; Mon, 16 May 2022 16:07:12 +0000 Received: by outflank-mailman (input) for mailman id 330056; Mon, 16 May 2022 16:07:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdFW-0007Hk-I1 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:07:10 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c92025b-d532-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:07:09 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdEm-006s2D-Fy; Mon, 16 May 2022 18:06:24 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c92025b-d532-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hkxxY/QtEmLaEz91h3ZbibgaO5mIVJpTDxNjCMnCCRs=; b=QJKb57mFKwMFscTO5WFY4RSj23 KQ6n8H9l2g2SttLbeQWPGo2evZPJbMnkbERgI1GrlJbCyaovBQ7YNgsYgYWZV4AUB43bBYpAdAI4t tSUTgJhvOvNj6CgwWpUnZT0VvP1nPFnrhSTYeteC8TI+m63sh71ROWTeeLMsXDtJw57P/+L4voDEA fAA2sLoZLSjWU8escrCVSpKI49cJB+42jd6GXOMXbMkFbQNvfMy7UNTlghfu62nr5uAdPO/Hn/wFd nMAbmXIqsuv6JnFGW2A+NmrSU+Aj1YnRvsm6Le3RHEDyDM6bMieEJqNdqhsYzjUU2qgiLiCJOh07u ze5flEbQ==; Message-ID: <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> Date: Mon, 16 May 2022 13:05:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Content-Language: en-US To: Petr Mladek , Tony Luck , Dinh Nguyen Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks again for the review! Comments inline below: On 16/05/2022 11:33, Petr Mladek wrote: > [...] >> --- a/drivers/edac/altera_edac.c >> +++ b/drivers/edac/altera_edac.c >> @@ -2163,7 +2162,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev) >> int dberror, err_addr; >> >> edac->panic_notifier.notifier_call = s10_edac_dberr_handler; >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_pre_reboot_list, > > My understanding is that this notifier first prints info about ECC > errors and then triggers reboot. It might make sense to split it > into two notifiers. I disagree here - looping the maintainers for comments (CCing Dinh / Tony). BTW, sorry for not having you on CC already Dinh, it was my mistake. So, my reasoning here is: this notifier should fit the info list, definitely! But...it's very high risk for kdump. It deep dives into the regmap API (there are locks in such code) plus there is an (MM)IO write to the device and an ARM firmware call. So, despite the nature of this notifier _fits the informational list_, the _code is risky_ so we should avoid running it before a kdump. Now, we indeed have a chicken/egg problem: want to avoid it before kdump, BUT in case kdump is not set, kmsg_dump() (and console flushing, after your suggestion Petr) will run before it and not save collected information from EDAC PoV. My idea: I could call a second kmsg_dump() or at least a panic console flush for within such notifier. Let me know what you think Petr (also Dinh / Tony and all interested parties). > [...] >> --- a/drivers/leds/trigger/ledtrig-panic.c >> +++ b/drivers/leds/trigger/ledtrig-panic.c >> @@ -64,7 +63,7 @@ static long led_panic_blink(int state) >> >> static int __init ledtrig_panic_init(void) >> { >> - atomic_notifier_chain_register(&panic_notifier_list, >> + atomic_notifier_chain_register(&panic_pre_reboot_list, >> &led_trigger_panic_nb); > > Blinking => should go to the last "post_reboot/loop" list. > [...] >> --- a/drivers/misc/ibmasm/heartbeat.c >> +++ b/drivers/misc/ibmasm/heartbeat.c >> @@ -32,20 +31,23 @@ static int suspend_heartbeats = 0; >> static int panic_happened(struct notifier_block *n, unsigned long val, void *v) >> { >> suspend_heartbeats = 1; >> - return 0; >> + return NOTIFY_DONE; >> } >> >> -static struct notifier_block panic_notifier = { panic_happened, NULL, 1 }; >> +static struct notifier_block panic_notifier = { >> + .notifier_call = panic_happened, >> +}; >> >> void ibmasm_register_panic_notifier(void) >> { >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_notifier); >> + atomic_notifier_chain_register(&panic_pre_reboot_list, >> + &panic_notifier); > > Same here. Blinking => should go to the last "post_reboot/loop" list. Ack on both. IBMasm is not blinking IIUC, but still fits properly the loop list. This notifier would make a heartbeat mechanism stop, and once it's stopped, service processor is allowed to reboot - that's my understanding. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 16:07:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330066.553376 (Exim 4.92) (envelope-from ) id 1nqdGE-0007mJ-Cz; Mon, 16 May 2022 16:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330066.553376; Mon, 16 May 2022 16:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdGE-0007mC-A1; Mon, 16 May 2022 16:07:54 +0000 Received: by outflank-mailman (input) for mailman id 330066; Mon, 16 May 2022 16:07:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdGC-0007Hk-Bn for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:07:53 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54bb03d7-d532-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:07:50 +0200 (CEST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GF72JR009397; Mon, 16 May 2022 16:00:14 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g24ytkqbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 16:00:13 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24GFt9hE010944; Mon, 16 May 2022 16:00:12 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3g22v22q73-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 16:00:12 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SN6PR10MB2464.namprd10.prod.outlook.com (2603:10b6:805:4d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 16:00:10 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5250.018; Mon, 16 May 2022 16:00:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54bb03d7-d532-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=MTc5lijZIFw35MDgY6cEo9JOLpZH94xs+SwgosuOXDg=; b=PRkC4Yvc1ye8/nQI+Pv90ItVaPtAwY2bPFBZpzkFaNNstDDKOR8uHtUQx6jh/0tJAdRZ T7JXxVHQpWpyh+AuJIEKY3iS7OgfxHwtY8+fLOhMtfeR2ioaM83E4uE1A1fhUB4K2Lde iCl7F30m99w4alh2bL5j9IRUHdxxMHPKZuGQXbJQPwpHWgT9WEhTczgMM+aHQXChgCLn Kwcn1HVCJSaD75QwWlKH03Lv4/PKWqZ++W2w/YlJWN/kI4t5ksyDVYw8IIqRkEmXOtwY 4xaDvnbP7xMkhMnbgfWss1Rmg9lVx2nijnrVv4GgrD9dnc0WDvl29Mw5wG+yyJK1CKul nA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gA16/x2Um1L13JnoNroZT7RXOWRgZVvEnUqXRtouSTfwv4nGp69HY2vdqW/iRULYI1U99mj1v+mJNqtpeGrEim5oQ4UEjQjCV9uem6zujqQCYWXlHgnqLZ7Nq/OKEwdy7Lxd+nxxEpmaflIUyx3wZo1JQITM1CGn5noWS/weEEohVZoeRqGHOB0xAGebyY9ddTRo30/IfGMFL5yTI6wEFyv9FYvgCf3u/VVF/nZqaN/BnsFgYeHRVXhhU/aXDeJcpKyE+d4ugh3tTNFgRCI5YZcMhy1pp4+qUsHcF1jVy0/sVg4SX9yVNiW/lRPYiOlhrYUHQfZVxai1b1DPrI5eSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTc5lijZIFw35MDgY6cEo9JOLpZH94xs+SwgosuOXDg=; b=KmC2r2fgadE5G8Q47bRznEVtdQocxVGM9CMZY2NI7aMEpuI5mw24N1Vj/yKWWahlq1fhRQggo49hrL/Aw16GE10iU0ZI1gg6yYrAFGaNtefFZvYw6x7TBtpVz4O8FOKm8IZWEwYuC7bqQgwzC8fZoJoF1Ls0Hre3JeCKO8wjZnsUZTGRjdn66nCloyOKx7RyRYKR70QYzSmSKfofp034sj/7UBDKJhGNYqUTUxW3MXLRGfPRyilUn48kPvr2yRAlSqxTzxSNH9p4JhUQXKjUb5yUb0zFe5go798IS9yClEttoppBTXJ9dEd27CeDT4+AI55qsFTMJHL+yhg/ZDCEwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MTc5lijZIFw35MDgY6cEo9JOLpZH94xs+SwgosuOXDg=; b=hzYE2MylG/khSa2QcCuFtsvRjbNZe3azyzKw9+sKlfXyT8IjEoyfSngyyKb/1WQUsS/Fp5GwleSxfAGW101k7NbT/cO2IJhMhaAZwHvpcQ+qPHNCr/S//Irhw00J74CZLF7qCOys+LrkI7gJnzvXdF2bKlZChLoCiJOBA/xL6fY= Message-ID: <80286144-cca4-ef07-3aca-2c2374881738@oracle.com> Date: Mon, 16 May 2022 12:00:05 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Juergen Gross , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DS7PR03CA0344.namprd03.prod.outlook.com (2603:10b6:8:55::28) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce285bab-33b9-445c-29f6-08da37552758 X-MS-TrafficTypeDiagnostic: SN6PR10MB2464:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ssye4ycntRwYHP93ngFZHHwlpKu5Kxy3Y0CALkUs7Oo/MrT7dYnhHlYq5nNry8q+nXqrporb9P0B5SBXAUbtY5e6tUxgVssu63yqV5xYbe1pjg2Kzll6cE7tMCiXTt5B8dw478EUxmo7OE6AZi3KfsRpFvLmTJ2X7Hd3Ue5SE2hWPxvRiH8AkaQS4WwdQ7zLIUfzPucilPP/JJtht9uo/NVyYBVeCHiNILy/MGfs5bZq+2+4PEC7M21a0FG+yhj9KDKb0KN1fH+Mfi+3WwswUeQIs9tJ3fVjT3OkmurKK/eYSunyoXhr+fEI8hTTkJNGT87Hhyz3T8gxx9Ou2ge6RYu6PIfzSozljd/TFsmm2EPmM5Mp1GBRMYZLt1Wv1MvBj8qvnjO+XeyIBTg+fbKNCGeo77ltBbS811AGrBdj/X0iWsU1fcXvhPcdqrD0S5i7J+ClfEirkuA1SkrxkMJ1caXX9yFWnv6wfOJwsNzo+vi8vWxmIBQUD4CNUaR++myF7q9oIepOro9iDwm9Nj2pP1yQEd8BPluGpnHcewgP8GybyjwJE9FWW1WoTin0zTveNNf6btIc0/F5JN8GHsE950wtoS5+eWPG1p+U79g0Jg9PpVhtdP8F6al3NFRXghLrF77IxzHEk/4KMl6/0nlpVrpFM2teN5LlQsXA82BK8GiS/EynK9VpQ05NaqYaB/1uTM3Q4Zf9+q9e89DKamQCEk49BGIl4OYKfotALsi/2oQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(44832011)(83380400001)(5660300002)(8936002)(31686004)(36756003)(6486002)(508600001)(2906002)(6506007)(4326008)(38100700002)(8676002)(66476007)(66946007)(66556008)(31696002)(86362001)(26005)(6512007)(6666004)(54906003)(316002)(186003)(7416002)(53546011)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFhadkJpdEZBY0JnVXNNZUt2bjF6a2dubjNMTVNoSFovdWxrYmhSV0dEc1Mr?= =?utf-8?B?TTVrWWJ4Z2s1d0FaQjNNNVM3eURpb2RCbE56S2hQeUNpelozNk5kNnM4TFVR?= =?utf-8?B?VUN1TjlKakFHYU9ncDJrZ1JTWk5lb2pOU2w5bEMrVGtPTjcvM3ZQZXJmd29V?= =?utf-8?B?Y0JyNklPTUdZS1JJZi9jK2p3bEFjQ2s5ekpSL1FmMnZTM2tKUklmcmpCTkJy?= =?utf-8?B?SVJsREFXcXBjcHZ5WnhoVnpXcCtWTzVUS1J1Rnl5Vnc3Tmc4dDdWaXVFbHpV?= =?utf-8?B?WERaQ095YmdTRjZXTGYxTmptTWlzRGNiRi84Y0t3QU5vODJQMWI4RU94K1Ru?= =?utf-8?B?M1hGdmkzMWc2S3JMSTVqTEZ0T0tBVStKOVg3M1p0QWwyQ1RZSzhvTHBSTi9B?= =?utf-8?B?ZXpmT3BDcmRsRUw4WjFuZ09kMXN1OFlGZGdXbXpDZ2FtKzZsb2E1VmZEcTg4?= =?utf-8?B?dWxNTnNxVVh0N3BxUitlc0E4bkJSN01YQXp1Um14Z20xMy91TURMdytOYVAx?= =?utf-8?B?SVZ5NDBqQm5KUlRtMjlZQ0d5NGhlT1RYdDlYUWNHOFJ6T1hUMC9GNWZyY29k?= =?utf-8?B?Ym50Z3dObGM5YWFtbitzcG1xdWdvczMzUjI3YUpEZU8xbEIxcWZIRm1DOFRH?= =?utf-8?B?bmZkMTRSejFFVkhOTXVBNXJpUjlrQUE0bmNia0t5QzFIODFlNVV6ckoxbWlL?= =?utf-8?B?bEZ5WC9BTG41ZjlLVHZoT3RHU1dDTzg0ZHZSRk15NWpMYUF4cStJRDQ0VFhN?= =?utf-8?B?RkVxNWlNRkIwcTBvbUloY3BkbUh2c0t3YTN4OHV3bGh4RmQ0QWpJczMzWkZJ?= =?utf-8?B?ZTU3Y00ydzhJc3FTNmx5dXhsSDlYQkxzaXpvTS9Ta2MvL2U3aW02N2UxdVZm?= =?utf-8?B?dVM3ZTFpeUpZZHRzTTdaTnpNdkNUb1lsdHBCdm1GUDFWN0JDa0xjcWlsNUtZ?= =?utf-8?B?ancvOGhzMm50bmswYUJ1MmQ3dkt6T3pDQkRXcnlBVDNMSUtEM3oxU3dvc3pV?= =?utf-8?B?eVBpbkJTbmVHM0ZWVGRleHlIZjBmdHJ5MjVDY3AxTFZqNlc3MW5BL1ozTWg2?= =?utf-8?B?VGFmanRqMjNFR2NLNkVOTFpVUm9hVkNZaEdIQkZ0Q2pReTZzcTR3MTVZVUda?= =?utf-8?B?RjdnMG1HaTlqV2dUcWJKd2Ruam1pTXBXenQ5aHdCK3djUmRndEVsc0tLSkg1?= =?utf-8?B?ZENLc1o0S1lsdWpyanRFT3ErOCtSa2s2Um9tcFdLY0p3NTVIdTdtQWdnZnhh?= =?utf-8?B?enFyNnpOWmZrd25GbSt3M0Zkd2ZZY1pTL2VWYkZ1aTE0Z29nOWlpbUR1ejFr?= =?utf-8?B?MnNqZm4rZmZQV2FQczBPd0RsL25mWWRIOE5EandDT3hoRGRSS1d2d2RFQ2hv?= =?utf-8?B?VFYwTnBOczhwYjNxdlF2QnJpSnE3NTQ0aHpYeng5bzFrZXBWODQzandpeisw?= =?utf-8?B?emhJV1V1Qmt2SHcxeElCWWVORnoxdlJFVzd1N1l6VlgvNDBoUzZZOTczTGlK?= =?utf-8?B?Y21hN0N2bnhCSkgrclB1Q09TM0tQYXhpczBDcDZtZGk2Y1QxUk9na3J0NUxD?= =?utf-8?B?NlUzOG1HY3lURzNaQkNIbHZGbTlCUGxNQklCdG5hVVVReWc4c0JNSFd3M1lM?= =?utf-8?B?aldGTDZ3ZmN6aE5MK0ozWlNEWCtFRkY5QkRxQUpOZGg2Z0pFd2ljL2hlZkk0?= =?utf-8?B?ekhMa05tTkNtdFJpLzZpUy9zaUx0U1F3ak5YNXQ3Z2NBcUpLTkkrNjk2S0ps?= =?utf-8?B?b1FhcG9EQlFNczlJZ1BSbTJhYkJYSHQxRmk0RHhjdVE1S1Q5NXlqUWRjNmVX?= =?utf-8?B?b0Y3VkJ4KzhydEJObWZQa2d0WTRxL1ROUlNVVDRIbytjcjcrajBFcFBPUkF5?= =?utf-8?B?MVVEb2Q4RTJncXdlVmtCZi9jcGpkbFZoMElpVTduYXBFNmZRRHNDV09qS2FT?= =?utf-8?B?R1dnQXcrYzZ3WmtJSTM0eDM1N3k1UHpPNGJ3di9uUUQrUEdORXMzZUxtSHp0?= =?utf-8?B?c1FrRml5ZlVucGNvbldrVzVON3JteFhxcjFCckVrZExLekFDTExUSC95NmZR?= =?utf-8?B?TDExN1BvNndRQ3VjbStjODBXYUFlYzArUzUrclI1WTYyd0F6TzlOMGMvZ3VJ?= =?utf-8?B?cnZlVTl0bHhxUjJaeEp2dVVNb2RnRmMyNXk4RXJsU1gwdnRjZEJLd1FucGpD?= =?utf-8?B?WjRhVFUrVlZwQy9sUTRLYVVlNXF4cFdKM2t1MXRIRms5Zmo1YzNodXdyMWRk?= =?utf-8?B?LzBhRnF6T1JFOEsxM3JCcjJKRVAvQWNzdnl1a2J5UVM1Q2k5eUJ1VUtMRzhz?= =?utf-8?B?SlRrK05JUWt0VjFIbnYzbW5IQ0pxUnV0c2FWTldzUG1mOWZBVUlYRmxXWG5t?= =?utf-8?Q?8WclvEQ+diXTdGNY=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce285bab-33b9-445c-29f6-08da37552758 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 16:00:09.9902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FmoHxtbIvZsHsufZhRIcehYjAnhh14jgM+LxPJqnGqh2rfYvKOaKhp5mqABijLixWttSzvLNnMI1Akir23/yy25LmmKEBaW03RaN14oJdY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2464 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-16_14:2022-05-16,2022-05-16 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205160091 X-Proofpoint-GUID: yQg_XaNzmgEyh--YBNbdb2uxZkJd1LLY X-Proofpoint-ORIG-GUID: yQg_XaNzmgEyh--YBNbdb2uxZkJd1LLY On 5/16/22 1:59 AM, Juergen Gross wrote: > On 14.05.22 04:34, Boris Ostrovsky wrote: >> >> >> On 5/13/22 1:33 AM, Juergen Gross wrote: >>> On 12.05.22 22:01, Boris Ostrovsky wrote: >>>> >>>> On 5/7/22 2:19 PM, Oleksandr Tyshchenko wrote: >> >>>>> +/* Rebuilds the free grant list and tries to find count consecutive entries. */ >>>>> +static int get_free_seq(unsigned int count) >>>>> +{ >>>>> +    int ret = -ENOSPC; >>>>> +    unsigned int from, to; >>>>> +    grant_ref_t *last; >>>>> + >>>>> +    gnttab_free_tail_ptr = &gnttab_free_head; >>>>> +    last = &gnttab_free_head; >>>>> + >>>>> +    for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); >>>>> +         from < gnttab_size; >>>>> +         from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { >>>>> +        to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, >>>>> +                    from + 1); >>>>> +        if (ret < 0 && to - from >= count) { >>>>> +            ret = from; >>>>> +            bitmap_clear(gnttab_free_bitmap, ret, count); >>>>> +            from += count; >>>>> +            gnttab_free_count -= count; >>>> >>>> >>>> IIUIC we can have multiple passes over this, meaning that the gnttab_free_count may be decremented more than once. Is that intentional? >>> >>> After the first pass decrementing gnttab_free_cnt, ret will no >>> longer be less than zero, so this can be hit only once. >> >> Oh, yes, of course. >> >>> >>>> >>>> >>>>> +            if (from == to) >>>>> +                continue; >>>>> +        } >>>>> + >>>>> +        while (from < to) { >>>>> +            *last = from; >>>>> +            last = __gnttab_entry(from); >>>>> +            gnttab_last_free = from; >>>>> +            from++; >>>>> +        } >>>> >>>> >>>> I have been looking at this loop and I can't understand what it is doing ;-( Can you enlighten me? >>> >>> It is recreating the free list in order to have it properly sorted. >>> This is needed to make sure that the free tail has the maximum >>> possible size (you can take the tail off the list without having >>> to worry about breaking the linked list because of references into >>> the tail). >> >> >> So let's say we have the (one-dimensional) table of length 13 >> >> idx    ..    2    3  ...  10  11  12 >> >> grant       12   11        2  -1   3 >> >> >> and gnttab_free_head is 10. I.e. the free list is 2, 12, 3, 11. > > You meant 10, 2, 12, 3, 11, I guess? > >> >> What will this look like after the 2 iterations of the outer loop? > > idx    ..    2    3  ...  10  11  12 > > grant        3   10       11  12  -1 > > with gnttab_free_head being 2, i.e the free list is now 2, 3, 10, 11, 12. OK, thanks, that helped. I couldn't link the free chunks in my head With the error handling in gnttab_init() fixed Reviewed-by: Boris Ostrovsky -boris From xen-devel-bounces@lists.xenproject.org Mon May 16 16:09:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:09:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330075.553387 (Exim 4.92) (envelope-from ) id 1nqdHU-0008SY-MF; Mon, 16 May 2022 16:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330075.553387; Mon, 16 May 2022 16:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdHU-0008SR-JH; Mon, 16 May 2022 16:09:12 +0000 Received: by outflank-mailman (input) for mailman id 330075; Mon, 16 May 2022 16:09:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdHS-0008SA-R2 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:09:10 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 845c204f-d532-11ec-837e-e5687231ffcc; Mon, 16 May 2022 18:09:09 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdH5-006sEZ-4a; Mon, 16 May 2022 18:08:47 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 845c204f-d532-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GMtpV7L0kGUwGya4swBOPC8ZOVfItfrxYDvgMpAmkJQ=; b=mu0bEGyUCfuWuU1+3MGwpfSVuq s6/6eTwkcMLsn+hqh74arIfl7IvjJUFkkA8WCdLFr55WWGsb4tEiMy/+3c9yyNaTe26kJ467c7Aa+ OVcjrOHxswFanqY90Yd7eenIDB3EwcpTVl3dOD010KynXuUWSiabOa/xgPRFmboMRGQYor+jwG1Cv mj7+eVkhBj2Q43ts9jeuWbjXw4tm3Jz5FqLPOTC5pNe5ykFg2VnMrebedEuX2X8Dc6Z0wdLCGwMFU 8xiaC4NGK1X9iOa8nP8hSMfwLdqMEw0xpnZedCTljeij+zSzzN7p5ST6lBhkCoAPIOrm2lBlmeS/R fNRTCdfQ==; Message-ID: Date: Mon, 16 May 2022 13:08:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Christian Borntraeger , "David S. Miller" , Heiko Carstens , Sven Schnelle , Vasily Gorbik References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-23-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 11:45, Petr Mladek wrote: > [...] > > The patch looks good to me. I would just suggest two changes. > > 1. I would rename the list to "panic_loop_list" instead of > "panic_post_reboot_list". > > It will be more clear that it includes things that are > needed before panic() enters the infinite loop. > > > 2. I would move all the notifiers that enable blinking here. > > The blinking should be done only during the infinite > loop when there is nothing else to do. If we enable > earlier then it might disturb/break more important > functionality (dumping information, reboot). > Perfect, I agree with you. I'll change both points in V2 =) From xen-devel-bounces@lists.xenproject.org Mon May 16 16:09:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:09:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330085.553399 (Exim 4.92) (envelope-from ) id 1nqdI3-0000aC-1u; Mon, 16 May 2022 16:09:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330085.553399; Mon, 16 May 2022 16:09:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdI2-0000a5-Sp; Mon, 16 May 2022 16:09:46 +0000 Received: by outflank-mailman (input) for mailman id 330085; Mon, 16 May 2022 16:09:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdI1-0008SA-Os for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:09:45 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99af21c9-d532-11ec-837e-e5687231ffcc; Mon, 16 May 2022 18:09:45 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdHp-006sJN-Dt; Mon, 16 May 2022 18:09:33 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99af21c9-d532-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZFn50ampduPG9oGRQUX2BMS6rY0kjBJ3j8a67GHebAM=; b=FcOPep8ePTWgqhN9kkuewdcNEP c+0DcuW1jGVdOvrXyeFbQQqAUYMA09npC4Byr3YGEoB/g2NkzWTt5Pixw+6iQWFOoxmTbFxaaHkCP GYMvVe3H+uOm3cet8cNwDTa56BrpIyiq1AnVWz2iVREpdKhDi1ibK7mTGwEsf+7L1BvRA0jP/ip7K 3Wv2lFsKQ8u4mnZSuMW4kfL4laBmHOrAwA4a8EfUlxz4QT/0au4zO1sGM8rm2FSym85ndF4P4dT3N BwBBCS9eObHRceuash+pnFltB0GDgdDLOd7W2xfGhQiSAKVeJrd4klCmODWnoEukEx3MhnUQk8Saq p8THRBQA==; Message-ID: <9f20619a-b405-2dc6-9771-b574b6f5058b@igalia.com> Date: Mon, 16 May 2022 13:09:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers Content-Language: en-US To: Petr Mladek Cc: Steven Rostedt , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-24-gpiccoli@igalia.com> <20220510134014.3923ccba@gandalf.local.home> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 11:50, Petr Mladek wrote: > [...] > Shame on me that I do not care that much about the style of the commit > message :-) > > Anyway, the code looks good to me. With the better commit message: > > Reviewed-by: Petr Mladek > Heheh, cool - I'll add your tag and improve the message in V2. Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 16:11:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330095.553409 (Exim 4.92) (envelope-from ) id 1nqdJq-00023K-Gh; Mon, 16 May 2022 16:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330095.553409; Mon, 16 May 2022 16:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdJq-00023D-Du; Mon, 16 May 2022 16:11:38 +0000 Received: by outflank-mailman (input) for mailman id 330095; Mon, 16 May 2022 16:11:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdGz-0007Hk-Dt for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:08:41 +0000 Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [2607:f8b0:4864:20::c2c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7303ed2b-d532-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:08:40 +0200 (CEST) Received: by mail-oo1-xc2c.google.com with SMTP id y22-20020a4acb96000000b0035eb01f5b65so4114409ooq.5 for ; Mon, 16 May 2022 09:08:40 -0700 (PDT) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com. [209.85.167.177]) by smtp.gmail.com with ESMTPSA id z18-20020a544592000000b00325cda1ffb2sm3939484oib.49.2022.05.16.09.08.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 09:08:38 -0700 (PDT) Received: by mail-oi1-f177.google.com with SMTP id r1so19168257oie.4 for ; Mon, 16 May 2022 09:08:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7303ed2b-d532-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ScgtWm2uFkOxfulqs7520gHM/my4MYIe3yq/VcV3Ozw=; b=Ui6BaQ6lQ9IwPfOUL4TJm7cJvfYf8UFV8wI0yIE/ecSwLqobvQf4rTIikXPC8Ksnp/ JRSTr3Fgwya3hm14X44WgUx1HJGuc9H1MoeHAN4VBzxuhJEnypxN8+xF6HAWoKiAVAs3 mxYrKvjtDKZ5Z0eJvjVSmqSHIwF8R/De7GbNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ScgtWm2uFkOxfulqs7520gHM/my4MYIe3yq/VcV3Ozw=; b=QZnwgMZMOrsXeRc08sX2stoIFge4m7tmCmkJdXnEc+yx2/palU8zIhLXs9rMS5xWN5 zAYTe2hxHm9wXv1fCJwD+EXtp/diB5LZFayGU9gk+LSjMPqaPGahSTA5oldEIEOZ4Fw2 yvAkpmB4Y3EOMjH8h+RsUUV0uueWMnSJRWbrIfD+XIDC+B3AFr7dHVosPBpuJ/oEnpZ8 ZTKUIFFGhaEZtyhTXYvbADnOzBp8AZwecGIecE7uLomyzqAMeosEpQgeLYlmJFAyp2L4 9wSSy4Oosh8KpCFhdirPkPhUsg/KRoI9E8Y4kr2REkV2v6ZhpppBUoFoFndjHbvc5LLR VDIw== X-Gm-Message-State: AOAM533yyjNNtFFLnGhe55Tq6eUtlgpSVxWeJ5CAWaoeWbq4/yvFPc0s 2aatjFf+IfoEemWMw120x/qavdZB32UqnlKq X-Google-Smtp-Source: ABdhPJy6AK/zzdhjJHMFZDmy6PViELZ12c6N9gJJ06FZt0q6/kr9w+KO5t3tGH/t+8DMNm+C0IZmlw== X-Received: by 2002:a4a:9805:0:b0:35e:e501:41fd with SMTP id y5-20020a4a9805000000b0035ee50141fdmr6318052ooi.34.1652717318895; Mon, 16 May 2022 09:08:38 -0700 (PDT) X-Received: by 2002:a05:6870:63a0:b0:f1:8bca:8459 with SMTP id t32-20020a05687063a000b000f18bca8459mr4861359oap.174.1652716966894; Mon, 16 May 2022 09:02:46 -0700 (PDT) MIME-Version: 1.0 References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> In-Reply-To: From: Evan Green Date: Mon, 16 May 2022 09:02:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list To: "Guilherme G. Piccoli" Cc: Petr Mladek , David Gow , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , Linux PM , Florian Fainelli , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi , Stephen Boyd Content-Type: text/plain; charset="UTF-8" On Mon, May 16, 2022 at 8:07 AM Guilherme G. Piccoli wrote: > > Thanks for the review! > > I agree with the blinking stuff, I can rework and add all LED/blinking > stuff into the loop list, it does make sense. I'll comment a bit in the > others below... > > On 16/05/2022 11:01, Petr Mladek wrote: > > [...] > >> --- a/arch/mips/sgi-ip22/ip22-reset.c > >> +++ b/arch/mips/sgi-ip22/ip22-reset.c > >> @@ -195,7 +195,7 @@ static int __init reboot_setup(void) > >> } > >> > >> timer_setup(&blink_timer, blink_timeout, 0); > >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > > > This notifier enables blinking. It is not much safe. It calls > > mod_timer() that takes a lock internally. > > > > This kind of functionality should go into the last list called > > before panic() enters the infinite loop. IMHO, all the blinking > > stuff should go there. > > [...] > >> --- a/arch/mips/sgi-ip32/ip32-reset.c > >> +++ b/arch/mips/sgi-ip32/ip32-reset.c > >> @@ -145,7 +144,7 @@ static __init int ip32_reboot_setup(void) > >> pm_power_off = ip32_machine_halt; > >> > >> timer_setup(&blink_timer, blink_timeout, 0); > >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > > > Same here. Should be done only before the "loop". > > [...] > > Ack. > > > >> --- a/drivers/firmware/google/gsmi.c > >> +++ b/drivers/firmware/google/gsmi.c > >> @@ -1034,7 +1034,7 @@ static __init int gsmi_init(void) > >> > >> register_reboot_notifier(&gsmi_reboot_notifier); > >> register_die_notifier(&gsmi_die_notifier); > >> - atomic_notifier_chain_register(&panic_notifier_list, > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > >> &gsmi_panic_notifier); > > > > I am not sure about this one. It looks like some logging or > > pre_reboot stuff. > > > > Disagree here. I'm looping Google maintainers, so they can comment. > (CCed Evan, David, Julius) > > This notifier is clearly a hypervisor notification mechanism. I've fixed > a locking stuff there (in previous patch), I feel it's low-risk but even > if it's mid-risk, the class of such callback remains a perfect fit with > the hypervisor list IMHO. This logs a panic to our "eventlog", a tiny logging area in SPI flash for critical and power-related events. In some cases this ends up being the only clue we get in a Chromebook feedback report that a panic occurred, so from my perspective moving it to the front of the line seems like a good idea. -Evan From xen-devel-bounces@lists.xenproject.org Mon May 16 16:12:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:12:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330102.553420 (Exim 4.92) (envelope-from ) id 1nqdKN-0002Yd-RV; Mon, 16 May 2022 16:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330102.553420; Mon, 16 May 2022 16:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdKN-0002YW-NZ; Mon, 16 May 2022 16:12:11 +0000 Received: by outflank-mailman (input) for mailman id 330102; Mon, 16 May 2022 16:12:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdKM-0002QS-3U for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:12:10 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efb8e662-d532-11ec-837e-e5687231ffcc; Mon, 16 May 2022 18:12:09 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdK8-006sYA-BV; Mon, 16 May 2022 18:11:56 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efb8e662-d532-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OZBRCsaeLLQD9CguIhK5Gsbv+Do9lNI4dRKnX3DnTVs=; b=cTAo65jHTM3B0ITLRt2mTe+qMi Mgnedog4ec+puSbe0nyROSa19Q4JMc3jLrINzY75lEJgN4ZnZLbXRnbU9VgE7MZjNWhyf408I+eF0 UZsTZ4wldMCBZxElXn52I0DKJCfHcNJLOcsxnTRMPLlShL9EHMOqzRahK2vVGGFXB6RnGo8XEEJPO gpyhtwCxU0EgZFBR09A8u7wGxD5xH5ep8p3kCFTe8PlGSgTOkVsHijQweIsXqaGaP95QgkavUlo4N GY9l6sOGeJeiAc+wGG54Szh2/VK5I4c73G47OXj82SsENDkfCXLscQrlJiBmPFlo290c84ZDH/amA F9S82K0A==; Message-ID: <41bede24-2bc4-a85b-9ba0-0f2562f8d0ca@igalia.com> Date: Mon, 16 May 2022 13:11:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 25/30] panic, printk: Add console flush parameter and convert panic_print to a notifier Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-26-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 11:56, Petr Mladek wrote: > [...] > I really like both changes. Just please split it them into two > patchset. I mean one patch for the new "panic_console_replay" > parameter and 2nd that moves "printk_info" into the notifier. > OK sure, will do that in V2. Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 16:15:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:15:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330113.553430 (Exim 4.92) (envelope-from ) id 1nqdNH-0003Ih-A4; Mon, 16 May 2022 16:15:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330113.553430; Mon, 16 May 2022 16:15:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdNH-0003Ia-71; Mon, 16 May 2022 16:15:11 +0000 Received: by outflank-mailman (input) for mailman id 330113; Mon, 16 May 2022 16:15:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdNF-0003IU-UF for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:15:09 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a4c678d-d533-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:15:09 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdMt-006sm6-Mg; Mon, 16 May 2022 18:14:47 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a4c678d-d533-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PIv49Au7mWUtjtiXxMXTyggVGnciDRRtT7um8nVDYk4=; b=W9A8UVl73mnQpa2JfREz1/RjUD zYyRgDERy8oLTucF5f6T3XYTYFxiYllr5CQxIlx/2/XHDyXsh2W9hjY4uVe+74TxD7M98QISaac+a M7XywdJvFk3YG6Om4dgtt5ZeREfbqmya73Q1q8sGS0PyxTmdYWxoXovpo5Reb9GHmn6GX3kYePtt9 IQtccx7PFkV6oeWvXiWxYIASmBN1PSkHoG23EqfeJ4/9AnnlTg/3Cg5Gj6/V0JoJ4G9Oz6SNv0UpO oX86uCQ+LAaAZQRMJjQodINX8vAHrHrxg8rbSrTF+qNyz++8FSDvG3i4nZYWzKQgJVfsg8L/5DYyI pIoBjijQ==; Message-ID: <90133fbb-2b5e-e7cd-e1fc-1f74e8bcd388@igalia.com> Date: Mon, 16 May 2022 13:14:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 18/30] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set Content-Language: en-US To: Steven Rostedt , Xiaoming Ni Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Arjan van de Ven , Cong Wang , Sebastian Andrzej Siewior , Valentin Schneider References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-19-gpiccoli@igalia.com> <9f44aae6-ec00-7ede-ec19-6e67ceb74510@huawei.com> <20220510132922.61883db0@gandalf.local.home> From: "Guilherme G. Piccoli" In-Reply-To: <20220510132922.61883db0@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 14:29, Steven Rostedt wrote: > [...] > Also, don't sprinkle #ifdef in C code. Instead: > > if (IS_ENABLED(CONFIG_DEBUG_NOTIFIERS)) > pr_info("notifers: regsiter %ps()\n", > n->notifer_call); > > > Or define a print macro at the start of the C file that is a nop if it is > not defined, and use the macro. Thanks, I'll go with the IS_ENABLED() idea in V2 - appreciate the hint. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 16:18:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:18:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330121.553442 (Exim 4.92) (envelope-from ) id 1nqdQH-0003ul-OW; Mon, 16 May 2022 16:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330121.553442; Mon, 16 May 2022 16:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdQH-0003uX-LD; Mon, 16 May 2022 16:18:17 +0000 Received: by outflank-mailman (input) for mailman id 330121; Mon, 16 May 2022 16:18:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdQG-0003tb-7E for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:18:16 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c63fbe78-d533-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:18:11 +0200 (CEST) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 09:18:08 -0700 Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 16 May 2022 09:18:05 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 09:18:05 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 09:18:04 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2308.027; Mon, 16 May 2022 09:18:04 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63fbe78-d533-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652717892; x=1684253892; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+l+W5AAGJYF9POu96DFeN42Yp1wDBbNs2cT6ebzm1Q4=; b=QdPVnh+idtMThKRNwa/dq0Cn0wshb1yL/J5gV02kbpMmc6oh+S5W5LFF ZVuY1oqh9bsF6izz/+CIoCQbikE/DRtfmDNd1cYDEfBkLvHArEtGKIglz TamqELhY2kYi/fssRaEhnCNomdxcesGygmi8ngeMS1MIn7OKKyhYpThfS IuKDbT6JPco52t+JejNhXZN0hgMnUmzwWYq0/jMCfHhEX56cLsIFcNi80 SK9TXI7luCoX/ifdXqhBZkv98DbeoNQaUqPRISnC3dZDB4YhRE3H/rjYM nMx/Q8sgYjNf8X67otNPBViuixv8Jnuo+qe3+QtcX6il2TcGp6NQA2NV8 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="270576250" X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="270576250" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="596591798" From: "Luck, Tony" To: "Guilherme G. Piccoli" , Petr Mladek , Dinh Nguyen CC: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , "Corey Minyard" , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , "Heiko Carstens" , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , "Matt Turner" , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , "Richard Weinberger" , Robert Richter , "Stefano Stabellini" , Stephen Hemminger , Sven Schnelle , "Vasily Gorbik" , Wei Liu Subject: RE: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Topic: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Index: AQHYWooLnXaT7guJw0OCpuGv/IkEoK0iJCSAgAAZuAD//40QkA== Date: Mon, 16 May 2022 16:18:04 +0000 Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> In-Reply-To: <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiBTbywgbXkgcmVhc29uaW5nIGhlcmUgaXM6IHRoaXMgbm90aWZpZXIgc2hvdWxkIGZpdCB0aGUg aW5mbyBsaXN0LA0KPiBkZWZpbml0ZWx5ISBCdXQuLi5pdCdzIHZlcnkgaGlnaCByaXNrIGZvciBr ZHVtcC4gSXQgZGVlcCBkaXZlcyBpbnRvIHRoZQ0KPiByZWdtYXAgQVBJICh0aGVyZSBhcmUgbG9j a3MgaW4gc3VjaCBjb2RlKSBwbHVzIHRoZXJlIGlzIGFuIChNTSlJTyB3cml0ZQ0KPiB0byB0aGUg ZGV2aWNlIGFuZCBhbiBBUk0gZmlybXdhcmUgY2FsbC4gU28sIGRlc3BpdGUgdGhlIG5hdHVyZSBv ZiB0aGlzDQo+IG5vdGlmaWVyIF9maXRzIHRoZSBpbmZvcm1hdGlvbmFsIGxpc3RfLCB0aGUgX2Nv ZGUgaXMgcmlza3lfIHNvIHdlIHNob3VsZA0KPiBhdm9pZCBydW5uaW5nIGl0IGJlZm9yZSBhIGtk dW1wLg0KPg0KPiBOb3csIHdlIGluZGVlZCBoYXZlIGEgY2hpY2tlbi9lZ2cgcHJvYmxlbTogd2Fu dCB0byBhdm9pZCBpdCBiZWZvcmUNCj4ga2R1bXAsIEJVVCBpbiBjYXNlIGtkdW1wIGlzIG5vdCBz ZXQsIGttc2dfZHVtcCgpIChhbmQgY29uc29sZSBmbHVzaGluZywNCj4gYWZ0ZXIgeW91ciBzdWdn ZXN0aW9uIFBldHIpIHdpbGwgcnVuIGJlZm9yZSBpdCBhbmQgbm90IHNhdmUgY29sbGVjdGVkDQo+ IGluZm9ybWF0aW9uIGZyb20gRURBQyBQb1YuDQoNCldvdWxkIGl0IGJlIHBvc3NpYmxlIHRvIGhh dmUgc29tZSBnbG9iYWwgImtkdW1wIGlzIGNvbmZpZ3VyZWQgKyBlbmFibGVkIiBmbGFnPw0KDQpU aGVuIG5vdGlmaWVycyBjb3VsZCBtYWtlIGFuIGluZm9ybWVkIGNob2ljZSBvbiB3aGV0aGVyIHRv IGRlZXAgZGl2ZSB0bw0KZ2V0IGFsbCB0aGUgcG9zc2libGUgZGV0YWlscyAod2hlbiB0aGVyZSBp cyBubyBrZHVtcCkgb3IganVzdCBza2ltIHRoZSBoaWdoDQpsZXZlbCBzdHVmZiAodG8gbWF4aW1p emUgY2hhbmNlIG9mIGdldHRpbmcgYSBzdWNjZXNzZnVsIGtkdW1wKS4NCg0KLVRvbnkNCg== From xen-devel-bounces@lists.xenproject.org Mon May 16 16:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330129.553453 (Exim 4.92) (envelope-from ) id 1nqdeo-0006EP-4a; Mon, 16 May 2022 16:33:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330129.553453; Mon, 16 May 2022 16:33:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqden-0006EI-VA; Mon, 16 May 2022 16:33:17 +0000 Received: by outflank-mailman (input) for mailman id 330129; Mon, 16 May 2022 16:33:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqden-0006Ct-80 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:33:17 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e26a0885-d535-11ec-837e-e5687231ffcc; Mon, 16 May 2022 18:33:15 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdeI-006uBd-EQ; Mon, 16 May 2022 18:32:46 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e26a0885-d535-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=snNEotF/NnF6oRsYP9tQxjPI6hsRS2uTTzGW3F44uFU=; b=IrCfuw38CFBNzUUmwO4z/x0ude e9PSigrpJmmkANb9hFO8MYFTYKFJ+f2pDfg9ZWd+jWh0me4IY2UjT4bBJdJuG6aHpan97hS9RvfOH pKOQ4g3CadR7oxkIRI3RkZhas481ugQtknW2dOyn8WDu4fqTLFzYzJFnX5BjK36hBguKTcosLNdPK XLSo/vQGgUIYFydsMQwjF4Cl6fcPC+lWayRTRUcaC/1DW89DyT+5i4PUQlvBei/VhxE3uCiNyFXXu //FxcgwLDGTfxmReP4BgKaOgOZfz1x9KSbEjS92ORoxS5FR3YrIsPaoJlMSUKXKS/BK4yktUJz/OW jzuoL6kQ==; Message-ID: <0a9ba385-84b2-4137-ced1-f7044efff562@igalia.com> Date: Mon, 16 May 2022 13:32:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: Petr Mladek Cc: "michael Kelley (LINUX)" , Baoquan He , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Marc Zyngier , Mark Rutland , "linux-arm-kernel@lists.infradead.org" References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 07:21, Petr Mladek wrote: > [...] > Ah, it should have been: > > + notifiers vs. kmsg_dump > + notifiers vs. crash_dump > + crash_dump vs. kmsg_dump > > I am sorry for the confusion. Even "crash_dump" is slightly > misleading because there is no function with this name. > But it seems to be easier to understand than __crash_kexec(). Cool, thanks! Now it's totally clear for me =) I feel crash dump is the proper term, but I personally prefer kdump to avoid mess-up with user space "core dump" concept heheh Also, KDUMP is an entry on MAINTAINERS file. > [...] >> Heheh OK, I appreciate your opinion, but I guess we'll need to agree in >> disagree here - I'm much more fond to this kind of code than a bunch of >> if/else blocks that almost give headaches. Encoding such "level" logic >> in the if/else scheme is very convoluted, generates a very big code. And >> the functions aren't so black magic - they map a level in bits, and the >> functions _once() are called...once! Although we switch the position in >> the code, so there are 2 calls, one of them is called and the other not. > > I see. Well, I would consider this as a warning that the approach is > too complex. If the code, using if/then/else, would cause headaches > then also understanding of the behavior would cause headaches for > both users and programmers. > > >> But that's totally fine to change - especially if we're moving away from >> the "level" logic. I see below you propose a much simpler approach - if >> we follow that, definitely we won't need the "black magic" approach heheh > > I do not say that my proposal is fully correct. But we really need > this kind of simpler approach. It's cool, I agree that your idea is much simpler and makes sense - mine seems to be an over-engineering effort. Let's see the opinions of the interested parties, I'm curious to see if everybody agrees here, that'd would be ideal (and kind of "wishful thinking" I guess heheh - panic path is polemic). > [...] >> Here we have a very important point. Why do we need 2 variants of SMP >> CPU stopping functions? I disagree with that - my understanding of this >> after some study in architectures is that the crash_() variant is >> "stronger", should work in all cases and if not, we should fix that - >> that'd be a bug. >> >> Such variant either maps to smp_send_stop() (in various architectures, >> including XEN/x86) or overrides the basic function with more proper >> handling for panic() case...I don't see why we still need such >> distinction, if you / others have some insight about that, I'd like to >> hear =) > > The two variants were introduced by the commit 0ee59413c967c35a6dd > ("x86/panic: replace smp_send_stop() with kdump friendly version in > panic path") > > It points to https://lkml.org/lkml/2015/6/24/44 that talks about > still running watchdogs. > > It is possible that the problem could be fixed another way. It is > even possible that it has already been fixed by the notifiers > that disable the watchdogs. > > Anyway, any change of the smp_send_stop() behavior should be done > in a separate patch. It will help with bisection of possible > regression. Also it would require a good explanation in > the commit message. I would personally do it in a separate > patch(set). Thanks for the archeology and interesting findings. I agree that is better to split in smaller patches. I'm planning a split in 3 patches for V2: clean-up (comment, console flushing idea, useless header), the refactor itself and finally, this SMP change. > [...] >> You had the order of panic_reboot_list VS. consoles flushing inverted. >> It might make sense, although I didn't do that in V1... > > IMHO, it makes sense: > > 1. panic_reboot_list contains notifiers that do the reboot > immediately, for example, xen_panic_event, alpha_panic_event. > The consoles have to be flushed earlier. > > 2. console_flush_on_panic() ignores the result of console_trylock() > and always calls console_unlock(). As a result the lock should > be unlocked at the end. And any further printk() should be able > to printk the messages to the console immediately. It means > that any messages printed by the reboot notifiers should appear > on the console as well. > [...] >> OK, I agree with you! It's indeed simpler and if others agree, I can >> happily change the logic to what you proposed. Although...currently the >> "crash_kexec_post_notifiers" allows to call _all_ panic_reboot_list >> callbacks _before kdump_. >> >> We need to mention this change in the commit messages, but I really >> would like to hear the opinions of heavy users of notifiers (as >> Michael/Hyper-V) and the kdump interested parties (like Baoquan / Dave >> Young / Hayatama). If we all agree on such approach, will change that >> for V2 =) > > Sure, we need to make sure that we call everything that is needed. > And it should be documented. > > I believe that this is the right way because: > > + It was actually the motivation for this patchset. We split > the notifiers into separate lists because we want to call > only the really needed ones before kmsg_dump and crash_dump. > > + If anything is needed for crash_dump that it should be called > even when crash_dump is called first. It should be either > hardcoded into crash_dump() or we would need another notifier > list that will be always called before crash_dump. Ack, makes sense! Will do that in V2 =) For the "hardcoded" part, we have the custom machine_crash_kexec() in some archs (like x86), unfortunately not in all of them - this path is ideally for mandatory code that is required for a successful crash_kexec(). The problem is the "same old, same old" - architecture folks push that to panic notifiers; notifiers folks push it to the arch custom shutdown handler (see [0] heheh). (CCed Marc / Mark in case they want to chime-in here...) >[...] > Thanks a lot for working on this. > > Best Regards, > Petr You're welcome, _thank you_ for the great and detailed reviews! Cheers, Guilherme [0] https://lore.kernel.org/lkml/427a8277-49f0-4317-d6c3-4a15d7070e55@igalia.com/ From xen-devel-bounces@lists.xenproject.org Mon May 16 16:34:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:34:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330138.553464 (Exim 4.92) (envelope-from ) id 1nqdgQ-0006rr-J8; Mon, 16 May 2022 16:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330138.553464; Mon, 16 May 2022 16:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdgQ-0006rk-FZ; Mon, 16 May 2022 16:34:58 +0000 Received: by outflank-mailman (input) for mailman id 330138; Mon, 16 May 2022 16:34:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdgP-0006rW-30 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:34:57 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e328526-d536-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 18:34:56 +0200 (CEST) Received: from [177.183.162.244] (helo=[192.168.0.5]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqdg0-006uIN-Pp; Mon, 16 May 2022 18:34:32 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e328526-d536-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XzoH5iutkh5O9t0pH+ypA1lIfMmiHtlRHdYp+UCsrGU=; b=WepOMKgEKhpR+t0vOgpE/YwZDW g57IfgGh3nzpJ2ZtHEZUcsTnwsDP6I2/FDZ4vnLGZ0Qw7F/Mn84yHkJf4BXJ/OpxzJ1p70t/N3EaQ 3PmdLprDUfYS48zPyb3blZ6UPVVkXH0bl8D3dn+A0vPKMKqgzgV2PkJylwkbN3xzE2jIxJLk5t9Xh Ean6ag10EMxBmLMIVJGXD8wgUW7usVSQYiFjIPvG61RcLN+veFIRifMeScPdiuTNjKo2kRxG2B83U 8p8XJXLR0CD8m0oqdI8PKIctIPo5el7u/X3BJM63/kcmCM4vsP6tEoNCn+7qkwfuh6KJplRNa4LRS 5jGHUhPQ==; Message-ID: Date: Mon, 16 May 2022 13:33:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Content-Language: en-US To: "Luck, Tony" , Petr Mladek , Dinh Nguyen Cc: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/05/2022 13:18, Luck, Tony wrote: >> [...] > Would it be possible to have some global "kdump is configured + enabled" flag? > > Then notifiers could make an informed choice on whether to deep dive to > get all the possible details (when there is no kdump) or just skim the high > level stuff (to maximize chance of getting a successful kdump). > > -Tony Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier? With that, are you/Petr/Dinh OK in moving it for the info list? Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 16 16:48:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330150.553475 (Exim 4.92) (envelope-from ) id 1nqdtU-0008QL-Qd; Mon, 16 May 2022 16:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330150.553475; Mon, 16 May 2022 16:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdtU-0008QE-M3; Mon, 16 May 2022 16:48:28 +0000 Received: by outflank-mailman (input) for mailman id 330150; Mon, 16 May 2022 16:48:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdtS-0008Pi-I6; Mon, 16 May 2022 16:48:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdtS-0006hI-BV; Mon, 16 May 2022 16:48:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqdtR-00067Z-Vy; Mon, 16 May 2022 16:48:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqdtR-0002Di-VW; Mon, 16 May 2022 16:48:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TgJp30IcLcM2mCQqGUBFFmYuXcmXfid3MRlxa5fQMks=; b=QapXz/cwsRJcrg0cY04szzxZ/z 60CpUZ/hpmhh4AIzwZzmIXxpsXb6QPhYphclaAujnr5Cc4s6T0PIe2HKFQeoFKqiT0UHWZvOtR3Ic ojQr6CQg2Fg3aOwltxbTkN4Fhe7zEW13+Ng3SBwWblPjrVVhRwUELMPZ8zkGlJZ2jWRc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170484: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 16:48:25 +0000 flight 170484 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170484/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1046 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 65 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 16:56:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 16:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330162.553486 (Exim 4.92) (envelope-from ) id 1nqe1S-0001Q9-Lj; Mon, 16 May 2022 16:56:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330162.553486; Mon, 16 May 2022 16:56:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe1S-0001Q2-Ib; Mon, 16 May 2022 16:56:42 +0000 Received: by outflank-mailman (input) for mailman id 330162; Mon, 16 May 2022 16:56:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe1R-0001Pw-L8 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 16:56:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe1R-0006px-Dv; Mon, 16 May 2022 16:56:41 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqe1R-000585-7Y; Mon, 16 May 2022 16:56:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=u2QP62T1xpkDX3PrIFZc6oYC8SvERz6aJBQLz3/IAKg=; b=gyngPXFy/WZIIy32WQUAI0FBYV o2MUSTPnE9Th8a20PjdqA+iggYCYWhduSobFW02voR0BK+Zq6jXfyC7V6YiFc/4f19F6vAWCeYRjW +4FojADzqh4Dnt7MhSJDpZ+qLze10yLpG4Lsx5xKVSskD7bSZMrRbbe8Qhh0dO9TM5iI=; Message-ID: Date: Mon, 16 May 2022 17:56:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU From: Julien Grall To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20220516084517.76071-1-julien@xen.org> <2E233152-FF46-42CF-B2CD-62E0BBE793C3@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/05/2022 10:50, Julien Grall wrote: >>> @@ -381,6 +410,7 @@ integer_param("max_lpi_bits", max_lpi_bits); >>> int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) >>> { >>>      unsigned int nr_lpi_ptrs; >>> +    int rc; >>> >>>      /* We rely on the data structure being atomically accessible. */ >>>      BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); >>> @@ -413,7 +443,14 @@ int gicv3_lpi_init_host_lpis(unsigned int >>> host_lpi_bits) >>> >>>      printk("GICv3: using at most %lu LPIs on the host.\n", >>> MAX_NR_HOST_LPIS); >>> >>> -    return 0; >>> +    /* Register the CPU notifier and allocate memory for the boot >>> CPU */ >>> +    register_cpu_notifier(&cpu_nfb); >>> +    rc = gicv3_lpi_allocate_pendtable(smp_processor_id()); >>> +    if ( rc ) >>> +        printk(XENLOG_ERR "Unable to allocate the pendtable for >>> CPU%u\n", >>> +               smp_processor_id()); >> >> On secondary cores nothing equivalent will be printed and in the cal >> path there >> will be nothing printed at all which could make debugging complex. >> Can you move this print into gicv3_lpi_allocate_pendtable ? > > Good point. I will do that in the next version. I decided to duplicate the error message in the notifier instead. I felt it was better over adding goto in gicv3_lpi_allocate_pendtable(). I am fine to use goto if that's preferred. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:02:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330170.553497 (Exim 4.92) (envelope-from ) id 1nqe7Q-0002qq-Ar; Mon, 16 May 2022 17:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330170.553497; Mon, 16 May 2022 17:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe7Q-0002qj-7k; Mon, 16 May 2022 17:02:52 +0000 Received: by outflank-mailman (input) for mailman id 330170; Mon, 16 May 2022 17:02:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe7P-0002qd-NP for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:02:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqe7P-0006xf-BG; Mon, 16 May 2022 17:02:51 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqe7P-0005YY-22; Mon, 16 May 2022 17:02:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=cq8sllYbdnsvMJxc54TQHqA9ko2N/yUSE4bVjrkEMLI=; b=FOYI/g zsKHayTl9XoqCuZ7zP2JVpnNB/Fy4BO1dFMtQXGmWdmSsh80yJqws39Indn6XPV89fPVqmUV11Cni VJ1UcBC5PcQagehrQY/HkUZj6cCBgQurkMIBEx2feJif4SByNp20BmlOiVKCnUNctcSllGmgc89Q1 Ql6DxsRiG10=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Date: Mon, 16 May 2022 18:02:46 +0100 Message-Id: <20220516170246.19908-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap alloc/free" extended the checks in the buddy allocator to catch any use of the helpers from context with interrupts disabled. Unfortunately, the rule is not followed in the LPI code when allocating the pending table: (XEN) Xen call trace: (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50 (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 (XEN) [<0000010722aa4200>] 0000010722aa4200 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 2: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 (XEN) **************************************** For now the patch extending the checks has been reverted, but it would be good to re-introduce it (allocation with interrupt is not desirable). The logic is reworked to allocate the pending table when preparing the CPU. Signed-off-by: Julien Grall --- Changes in v2: - Print an error message if we fail to allocate memory for secondary CPUs - The memory should always be allocated before gicv3_lpi_set_pendtable() is called. Add an ASSERT_UNREACHABLE() to make it clearer the check is just for sanity. --- xen/arch/arm/gic-v3-lpi.c | 91 +++++++++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 22 deletions(-) diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c index e1594dd20e4c..a656b531f41f 100644 --- a/xen/arch/arm/gic-v3-lpi.c +++ b/xen/arch/arm/gic-v3-lpi.c @@ -18,6 +18,7 @@ * along with this program; If not, see . */ +#include #include #include #include @@ -234,18 +235,13 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi, int domain_id, write_u64_atomic(&hlpip->data, hlpi.data); } -static int gicv3_lpi_allocate_pendtable(uint64_t *reg) +static int gicv3_lpi_allocate_pendtable(unsigned int cpu) { - uint64_t val; void *pendtable; - if ( this_cpu(lpi_redist).pending_table ) + if ( per_cpu(lpi_redist, cpu).pending_table ) return -EBUSY; - val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; - val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; - val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT; - /* * The pending table holds one bit per LPI and even covers bits for * interrupt IDs below 8192, so we allocate the full range. @@ -265,13 +261,45 @@ static int gicv3_lpi_allocate_pendtable(uint64_t *reg) clean_and_invalidate_dcache_va_range(pendtable, lpi_data.max_host_lpi_ids / 8); - this_cpu(lpi_redist).pending_table = pendtable; + per_cpu(lpi_redist, cpu).pending_table = pendtable; - val |= GICR_PENDBASER_PTZ; + return 0; +} + +static int gicv3_lpi_set_pendtable(void __iomem *rdist_base) +{ + const void *pendtable = this_cpu(lpi_redist).pending_table; + uint64_t val; + + /* + * The memory should have been allocated while preparing the CPU (or + * before calling this function for the boot CPU). + */ + if ( !pendtable ) + { + ASSERT_UNREACHABLE(); + return -ENOMEM; + } + ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16))); + + val = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT; + val |= GIC_BASER_InnerShareable << GICR_PENDBASER_SHAREABILITY_SHIFT; + val |= GICR_PENDBASER_PTZ; val |= virt_to_maddr(pendtable); - *reg = val; + writeq_relaxed(val, rdist_base + GICR_PENDBASER); + val = readq_relaxed(rdist_base + GICR_PENDBASER); + + /* If the hardware reports non-shareable, drop cacheability as well. */ + if ( !(val & GICR_PENDBASER_SHAREABILITY_MASK) ) + { + val &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; + val |= GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + + writeq_relaxed(val, rdist_base + GICR_PENDBASER); + } return 0; } @@ -340,7 +368,6 @@ static int gicv3_lpi_set_proptable(void __iomem * rdist_base) int gicv3_lpi_init_rdist(void __iomem * rdist_base) { uint32_t reg; - uint64_t table_reg; int ret; /* We don't support LPIs without an ITS. */ @@ -352,24 +379,36 @@ int gicv3_lpi_init_rdist(void __iomem * rdist_base) if ( reg & GICR_CTLR_ENABLE_LPIS ) return -EBUSY; - ret = gicv3_lpi_allocate_pendtable(&table_reg); + ret = gicv3_lpi_set_pendtable(rdist_base); if ( ret ) return ret; - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); - table_reg = readq_relaxed(rdist_base + GICR_PENDBASER); - /* If the hardware reports non-shareable, drop cacheability as well. */ - if ( !(table_reg & GICR_PENDBASER_SHAREABILITY_MASK) ) - { - table_reg &= ~GICR_PENDBASER_INNER_CACHEABILITY_MASK; - table_reg |= GIC_BASER_CACHE_nC << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT; + return gicv3_lpi_set_proptable(rdist_base); +} - writeq_relaxed(table_reg, rdist_base + GICR_PENDBASER); +static int cpu_callback(struct notifier_block *nfb, unsigned long action, + void *hcpu) +{ + unsigned long cpu = (unsigned long)hcpu; + int rc = 0; + + switch ( action ) + { + case CPU_UP_PREPARE: + rc = gicv3_lpi_allocate_pendtable(cpu); + if ( rc ) + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", + cpu); + break; } - return gicv3_lpi_set_proptable(rdist_base); + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); } +static struct notifier_block cpu_nfb = { + .notifier_call = cpu_callback, +}; + static unsigned int max_lpi_bits = 20; integer_param("max_lpi_bits", max_lpi_bits); @@ -381,6 +420,7 @@ integer_param("max_lpi_bits", max_lpi_bits); int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) { unsigned int nr_lpi_ptrs; + int rc; /* We rely on the data structure being atomically accessible. */ BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); @@ -413,7 +453,14 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits) printk("GICv3: using at most %lu LPIs on the host.\n", MAX_NR_HOST_LPIS); - return 0; + /* Register the CPU notifier and allocate memory for the boot CPU */ + register_cpu_notifier(&cpu_nfb); + rc = gicv3_lpi_allocate_pendtable(smp_processor_id()); + if ( rc ) + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", + smp_processor_id()); + + return rc; } static int find_unused_host_lpi(uint32_t start, uint32_t *index) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Mon May 16 17:07:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:07:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330179.553508 (Exim 4.92) (envelope-from ) id 1nqeBs-0003Y3-1n; Mon, 16 May 2022 17:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330179.553508; Mon, 16 May 2022 17:07:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeBr-0003Xw-Uz; Mon, 16 May 2022 17:07:27 +0000 Received: by outflank-mailman (input) for mailman id 330179; Mon, 16 May 2022 17:07:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeBq-0003Xq-JB for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:07:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeBq-000732-9I; Mon, 16 May 2022 17:07:26 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqeBq-0005r0-32; Mon, 16 May 2022 17:07:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=smCz381YoP4G/jcPz/Z9kIdFmj+MdEYStfJJGERDoFQ=; b=sKH0gaPFoTSWKZKUfk5FrETqJ7 nQUbtNdfNUdMHuJhVANfr/bRtkBQJouLPrWWfB6fTAgjU3a79rMZiZnrvRxHS4zquLHrMac0d9ClN GQPTWhtv6gCUAkQIvgf1ZzBAKfN777ggXwZe+3EPd2RFbH3mWXQCqeFCGt7M9G5zSNXM=; Message-ID: Date: Mon, 16 May 2022 18:07:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable From: Julien Grall To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Julien Grall References: <20220507025434.1063710-1-Henry.Wang@arm.com> <20220507025434.1063710-2-Henry.Wang@arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/05/2022 11:58, Julien Grall wrote: > On 07/05/2022 03:54, Henry Wang wrote: >> With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before >> local_irq_enable on secondary cores will lead to >> >> (XEN) Xen call trace: >> (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC) >> (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR) >> (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28 >> (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448 >> (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290 >> (XEN) [<000000000026b57c>] request_irq+0x40/0xb8 >> (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc >> (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238 >> (XEN) [<0000000084000200>] 0000000084000200 >> (XEN) >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 4: >> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || >> num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 >> (XEN) **************************************** >> >> on systems without a big enough pool for xmalloc() to cater the >> requested size. >> >> Moving the call of request_irq() past local_irq_enable() on >> secondary cores will make sure the assertion condition in >> alloc_xenheap_pages(), i.e. !in_irq && local_irq_enabled() is >> satisfied. It is also safe because the timer and GIC maintenance >> interrupt will not be used until the CPU is fully online. >> >> Reported-by: Wei Chen >> Suggested-by: Julien Grall >> Signed-off-by: Henry Wang > > Reviewed-by: Julien Grall I have committed this patch. The second patch will go in once "page_alloc: assert IRQs are enabled in heap alloc/free" has been re-committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:14:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330188.553523 (Exim 4.92) (envelope-from ) id 1nqeJ4-00052y-SU; Mon, 16 May 2022 17:14:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330188.553523; Mon, 16 May 2022 17:14:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeJ4-00052n-PJ; Mon, 16 May 2022 17:14:54 +0000 Received: by outflank-mailman (input) for mailman id 330188; Mon, 16 May 2022 17:14:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeJ2-00052h-UV for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:14:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeJ2-0007AG-K4; Mon, 16 May 2022 17:14:52 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqeJ2-0006Qu-Dv; Mon, 16 May 2022 17:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BLYdd3UlK2MHTVfzjIBq7vkIKbRwswle7whaiLHurbo=; b=S5YezEfycKLvAsLc6KUkM97s8C RpjNG/AwB6Dh7FOhevyCHal8gqX02DZnweMiDkperE5Qa/R8DAWMrOJmHTFwmCz0iaKlL+9mg091S PMz60hnoORnk0nYbXlBgzEWkSxJ1A5htEs5UMmq+8lFoXG7H3V1HtEGQ3yNfeL54g//o=; Message-ID: <46f6a909-2f77-021c-a069-6a8f827e53fc@xen.org> Date: Mon, 16 May 2022 18:14:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart To: Wei Chen , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie , Julien Grall References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-2-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20220511014639.197825-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/05/2022 02:46, Wei Chen wrote: > Current putn function that is using for early print > only can print low 32-bit of AArch64 register. This > will lose some important messages while debugging > with early console. For example: > (XEN) Bringing up CPU5 > - CPU 0000000100000100 booting - > Will be truncated to > (XEN) Bringing up CPU5 > - CPU 00000100 booting - > > In this patch, we increased the print loops and shift > bits to make putn print 64-bit number. > > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie > Acked-by: Julien Grall I have committed this patch. Patch #3 looks to be suitably acked but I am not sure whether it can be committed before #2. So I didn't commit it. Please let me know if it can be. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:17:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:17:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330196.553533 (Exim 4.92) (envelope-from ) id 1nqeLs-0005dy-Aw; Mon, 16 May 2022 17:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330196.553533; Mon, 16 May 2022 17:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeLs-0005dr-84; Mon, 16 May 2022 17:17:48 +0000 Received: by outflank-mailman (input) for mailman id 330196; Mon, 16 May 2022 17:17:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeLr-0005dl-5Z for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:17:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeLq-0007EN-VR; Mon, 16 May 2022 17:17:46 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqeLq-0006Ys-PC; Mon, 16 May 2022 17:17:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BTwCt3h58bptRAu2KOKnhYLeDlVlkELneOhsSbW5fww=; b=eq6xvZ/nZ4rz6vhj+e/juJjJz+ KTHmhVZyBR34sL/61R9liTkKvALtlR0ncBGypsj6GjehTr3jDltQAeN0oTJ/oviFAIjPjXfV4x1zp XPYeBcjfZBA+B5rKkUTDNAfIXTbtmGwLC8q3r9iqK+rGmccQu2eA2F5Z+RuBcjg50nlg=; Message-ID: <73077f8d-d1e9-aec2-3cc1-38b2487c1d9d@xen.org> Date: Mon, 16 May 2022 18:17:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN PATCH] docs: fix path to code in migration doc To: Andrew Cooper , Anthony Perard , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220510140506.64930-1-anthony.perard@citrix.com> <8c92b56a-bd7b-b91a-5a18-1865ab5b5e98@citrix.com> From: Julien Grall In-Reply-To: <8c92b56a-bd7b-b91a-5a18-1865ab5b5e98@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/05/2022 15:21, Andrew Cooper wrote: > On 10/05/2022 15:05, Anthony PERARD wrote: >> Signed-off-by: Anthony PERARD > > Acked-by: Andrew Cooper Committed. Thanks, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:20:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:20:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330204.553545 (Exim 4.92) (envelope-from ) id 1nqeOr-00071g-PE; Mon, 16 May 2022 17:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330204.553545; Mon, 16 May 2022 17:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeOr-00071Z-MJ; Mon, 16 May 2022 17:20:53 +0000 Received: by outflank-mailman (input) for mailman id 330204; Mon, 16 May 2022 17:20:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeOq-00071T-9s for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:20:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeOp-0007IP-Vh; Mon, 16 May 2022 17:20:51 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqeOp-0006hK-Ps; Mon, 16 May 2022 17:20:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=P3CVErx1CBYC12HZ5XyQN2UokAuMQKARiPsAhfrma0w=; b=Ab3csFuN3QDGD7LY9Dx5o7sVVa Hm7cHbIv4kpabapMDM/VswTCSOaToXJVN1culh2Nn155kNYoedolc2PMt/I6WY9eNpAVIb1AtKHYm DizDn1Z4N5tg3wdsfD4fWk8dF1XPA1xj5EH1DDm9Rbz6sbAQzTtnitfEtheSY02uypkQ=; Message-ID: <51ad75c6-2de3-1602-d2ac-b0193ed922f6@xen.org> Date: Mon, 16 May 2022 18:20:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK To: Catalin Marinas Cc: Michal Orzel , xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220505115906.380416-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Catalin, On 10/05/2022 09:55, Catalin Marinas wrote: > On Tue, May 10, 2022 at 09:27:29AM +0100, Julien Grall wrote: >> Hi, >> >> On 10/05/2022 07:49, Michal Orzel wrote: >>> On 05.05.2022 14:13, Catalin Marinas wrote: >>>> On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: >>>>> Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer >>>>> and can lead to overflow. Currently there is no issue as it is used >>>>> in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. >>>>> To avoid possible problems, fix the macro. >>>>> >>>>> Signed-off-by: Michal Orzel >>>>> Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com >>>>> Signed-off-by: Catalin Marinas >>>>> Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) >>>>> --- >>>>> Changes since v1: >>>>> - add Origin tag as the patch was merged in upstream arm64 linux tree >>>> >>>> Note that there's always a risk that the commit Id will be changed >>>> before it hits mainline (Linus' tree). >>>> >>> >>> This commit is now in linux-next: >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48e6f22e25a44e43952db5fbb767dea0c9319cb2 >>> so we can be sure that the SHA will stay unmodified there (and will be the same in Linus' tree). >> >> AFAIK, linux-next branch is just a merge of all the maintainers branch and >> often rewritten. So there are no guarantee a commit id is valid until it >> reached Linus' tree. > > Indeed. While I try not to rebase it, it may happen occasionally. > >>> Question to maintainers: >>> Do you want me to update Origin to point to linux-next? >> >> So we have a link to the patch and a name. This should be sufficient to find >> the commit. >> >> Therefore, I would simply on top of Origin: > > Yeah, just keep the link to the mailing list. I guess you can drop my > Singed-off-by as well if it appears to be picked from the list rather > than the kernel repo. If you want an ack: > > Acked-by: Catalin Marinas I have done what you suggested and committed. Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:24:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:24:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330215.553568 (Exim 4.92) (envelope-from ) id 1nqeS5-0007nr-Cp; Mon, 16 May 2022 17:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330215.553568; Mon, 16 May 2022 17:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeS5-0007nj-9g; Mon, 16 May 2022 17:24:13 +0000 Received: by outflank-mailman (input) for mailman id 330215; Mon, 16 May 2022 17:24:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeS3-0007nd-RJ for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:24:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqeS1-0007Lf-F3; Mon, 16 May 2022 17:24:09 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqeS1-00073j-9O; Mon, 16 May 2022 17:24:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5GPArWc91QslXIcim7uCyt8M5j4wEGr6RznXZCGNtyc=; b=uJA6YCLhJVVYnYUdV5kouHOixH UYrNh3DKHlpGa+MZeiIxmsSBIuw4wctgateZFig98KdUjwdLkHEvUb1/1XazpkLda4Z1NRYn8LS4A ak3yf9Xeq6uB3lTho8ZFZQykUULP8P98A98f+a37db1QPzoPD09Gnn7Efc+n5c34ZKqw=; Message-ID: Date: Mon, 16 May 2022 18:24:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/2] build: suppress future GNU ld warning about RWX load segments To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <15350fcc-86ad-d42a-27a9-c0cbab091559@suse.com> <93722fdc-550b-bc08-3115-e92a299973a3@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 06/05/2022 14:46, Jan Beulich wrote: > On 06.05.2022 15:43, Julien Grall wrote: >> You say future, has this option been merged or still in discussion on >> the ML? > > "future" as in "no released version yet". The change is present on the > binutils master branch. Thanks for the clarification. In which case, can you update the commit message like Andrew suggested. For both: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:36:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:36:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330224.553579 (Exim 4.92) (envelope-from ) id 1nqee6-0000qa-H7; Mon, 16 May 2022 17:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330224.553579; Mon, 16 May 2022 17:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqee6-0000qT-EM; Mon, 16 May 2022 17:36:38 +0000 Received: by outflank-mailman (input) for mailman id 330224; Mon, 16 May 2022 17:36:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqee5-0000qK-7z for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:36:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqee4-0007Yt-Nf; Mon, 16 May 2022 17:36:36 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqee4-0007qa-Gs; Mon, 16 May 2022 17:36:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Xa010WFhC/qkh4UR99SDa7p8TEt9jZCsyEm2xJiim1M=; b=P9c2Fbzu8UZA40i4KCQSm/LImp eSxHOiVYyNTl+BGuPh0zJbdR9+Pyq8IMijQtY2AYpMYT2LKrgl35MTx1K27he6ERBragsVIkepKtF 8MSGLO2lU3ZEJyuDA+gjUz+/23jEFU2x8+GxoWx5X4io42qcLIM7MDmpUf+Cx8/yAnc4=; Message-ID: <19de9898-59ca-5ccc-42cb-ae6f355ae24e@xen.org> Date: Mon, 16 May 2022 18:36:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 2/6] xen: do not merge reserved pages in free_heap_pages() To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-3-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220510022733.2422581-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 10/05/2022 03:27, Penny Zheng wrote: > The code in free_heap_pages() will try to merge pages with the > successor/predecessor if pages are suitably aligned. So if the pages > reserved are right next to the pages given to the heap allocator, > free_heap_pages() will merge them, and give the reserved pages to heap > allocator accidently as a result. > > So in order to avoid the above scenario, this commit updates free_heap_pages() > to check whether the predecessor and/or successor has PGC_reserved set, > when trying to merge the about-to-be-freed chunk with the predecessor > and/or successor. > > Signed-off-by: Penny Zheng > Suggested-by: Julien Grall NIT: In general, the tags are historically ordered. I.e I first sugested and then you wrote the patch. So the two tags should be inverted. This can be done on commit: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 17:39:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330232.553590 (Exim 4.92) (envelope-from ) id 1nqegi-0001Sa-Ud; Mon, 16 May 2022 17:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330232.553590; Mon, 16 May 2022 17:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqegi-0001ST-Rv; Mon, 16 May 2022 17:39:20 +0000 Received: by outflank-mailman (input) for mailman id 330232; Mon, 16 May 2022 17:39:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqegh-0001SN-KU for xen-devel@lists.xenproject.org; Mon, 16 May 2022 17:39:19 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c189eb4-d53f-11ec-837e-e5687231ffcc; Mon, 16 May 2022 19:39:18 +0200 (CEST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GHXLme019520; Mon, 16 May 2022 17:39:08 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g241s4195-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 17:39:08 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24GHZcqY005434; Mon, 16 May 2022 17:39:07 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3g37cnwjj1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 17:39:06 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DM6PR10MB2554.namprd10.prod.outlook.com (2603:10b6:5:b3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Mon, 16 May 2022 17:39:05 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5250.018; Mon, 16 May 2022 17:39:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c189eb4-d53f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=hNy9d6PYaYBd8YZrX6TQ7fwsF64yJdIXLXKJZErnogI=; b=mu0NBtu7Hn4cLlchgfxDRQqYBP3pwRwF20XQqMJ7/jWsC51Ng/XJXldI4315v1sCJcTL 6jP1wGWjIvlXXtIo6K5TOvSrddvU/YWnZ1MB3/oXiSdEh01+AxLfOcknz3Rc/EWzjvFH DZN2m+Of2TyZelKFaL1/Xryq+XrNEVzKP18Obt7zfY8YwW5gsxFp/6aD0gapX49OAI0O RUaG11hYfKuK3jz/bHYEwX9e0aPzP43GWM3w9MuCXi8rTjdZ8+rU18+pozU9y6IrYZTq 9ys8LdaQ2Ti2HdvizwWlNo3nalFu4/CNXoTFre0FXVqtf/x6wxe+LkqXuS+vo+Sr4dyC Kw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pg0lfYklU87fjcUZKCBKAuky4qL9E0iRId/t/4Y4GnhVpbO/DgjerJ8WdkIGEj1c2WiRdsFdTO6ZDWjdOsRfTudC7Rw7Fq0Lm7jP8HIHZ9cD9zNMbk54wmyz6N54NxyMEyXIwDavEtXe9wiruXobhBWOUPsqx1Z9h10hyVRfiFXng+01ZWgJjcd99Kqfypf0wAr4G9UpchJ9Ov7SfuSHPLRqfehhbQeE90o8NOzCeB4I9NDyhTunm5/gbYlKgoJMK3y+KeLb3gj5j98ZhdW6q6F0fKtDEe3hJPgx+/JprLVSHL2bCBrR42DMR025ym1GuSfBBc0fYkt2rl9U1GXjJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hNy9d6PYaYBd8YZrX6TQ7fwsF64yJdIXLXKJZErnogI=; b=e0AfUbWcCksHd7yPsXCz2qgXtjvCWgEbXTVciy0wKwByYFLAJI3QcIGY74/cixHjz8lCBOCKChvWXlqn5PDvcYKbdibAJL0UXrktYcMj6spPeWsMiPnga8OTbQTxEVgWDYo8CN3q2kkum7aXqfIiwqgFAcWwoeYSIAG89wiK6FypxJDZTxBUVcH11pKEuMOU/r5CCUOdFBBBB2N2kVl1DOciMDGfv3kr8LKat5V6ZsKPsiZ5Lg0N/NRqwkotKKJ8liazdz3sA0lLdqjC9NTX/4JTfjd4VXmUtY/8MCurkDBjqqwhL+zWwzJ44i1wJtWmdod6rlI9IRnxtQ9KtyxiDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNy9d6PYaYBd8YZrX6TQ7fwsF64yJdIXLXKJZErnogI=; b=B37khgUksddnABLe+y1vkQTbpohuLJF7ypyk407BWqjBRZJX6XkTesxuQV/fULY72bJntW21nXv9XP+rqIpWnWk4Yyj56ZlCuYusqr3CbGz6Lxm6TPafid+rlVzCsyQ9d+lxz+DTSdaAEf32hHlg2uJ1HqXgrgwt1OF3JNxfwew= Message-ID: <545549ee-ac0d-0fdf-7c57-6fa895e91293@oracle.com> Date: Mon, 16 May 2022 13:38:59 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH LINUX v5 1/2] xen: sync xs_wire.h header with upstream xen Content-Language: en-US To: Stefano Stabellini , jgross@suse.com Cc: xen-devel@lists.xenproject.org, Stefano Stabellini References: <20220513211938.719341-1-sstabellini@kernel.org> From: Boris Ostrovsky In-Reply-To: <20220513211938.719341-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN7PR04CA0187.namprd04.prod.outlook.com (2603:10b6:806:126::12) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cacbfc9f-b9ee-41fd-495f-08da3762f8ea X-MS-TrafficTypeDiagnostic: DM6PR10MB2554:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G5JFJV/Q1ylFeArULFLmWhkMYaGjQENC3QlWEIVRJ/vk3BiFe2ST23IX+c6KFiDU/9trMxTZ55Kheb1Tya2nUM6Vk08bBPpTZ0yUie9iXQO5uOPIDKv/kO3NEprPdc8LatMjcNrRjI/3OWJuDI4vOoeVtIyzJCtAWFTaqdc9crSlBG1tvonDOGW1ddg0A2X1GAaCUSwNg5Ta7sN8ljJTTZkNRvYZmB0Vw0cE/ms7P+q5sQlYXFHmc2Wm4ovYvAyKde/xZrzBFUI8BIpxhOMo8ffQrXmRkTpQu+Ephu6ZRmHATJkItHGQRgyy1U2lVumMWgpIoMLXx/sIicg+n+FCj38i3jYLWuHFO3+huY9oWEDNkY+bQHl8oq5qSAe9WOvp5kDTg4qN7Q24HdnQdc7gZEUhZdAFUzKYaq7stoiDjXFHI3Phf6rDgpoGpqeghP1ANf9ko5oy2oNfV2cPZEWbzOz4I1BPubLpxZjiPBk/eD1BFwm0FeoTNic323fxX0dvpQ4W7X5dVGH5/GFGjx7V6mmr+1RcfU9FKTAVl4bo/LhSo3jKVjM7L1uMPQBGFK7LHLFzc3GAtRQpOS8oeuBx3mikMGqsjbo5DNBOKy980SacDQ4i/RaQuvX4FZ5iLA6a27PlDvHUh7YcA0KKOFMyj71kn1lSK6yR3mURO520b2toDKClARwbef0p/kAeJbkBq7dIfHKa7DMmjaQbNDlNdebBIM3h4GlT/WHUeOSQbCCdpkAumIlJxCh3ijGXxlA4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(508600001)(6506007)(38100700002)(44832011)(4744005)(2906002)(6666004)(53546011)(26005)(66946007)(8936002)(2616005)(5660300002)(316002)(186003)(4326008)(31696002)(66476007)(66556008)(8676002)(86362001)(6486002)(6512007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2xVSGc2d1l1TlhPeXZKUlVoMWorVmloaDBPSlhNNU8xb1ZZSjB4WC9OWk14?= =?utf-8?B?MGtzYW9BQ0N6aXlDRC9JeW0rbTZQZlJUcTE0eHlTZi9RV3YvazZTQ3lZMmoy?= =?utf-8?B?dlQ3a3JmSG9OL2IvY016ekcvcndwczllWi9DMDAvQllrVjQwVFEySGIrTnEr?= =?utf-8?B?eHFJSGR6V3VQc2w5eGgrTCtlSm1vZ3RCK0IxVE1kN2V2NHZHWm0zT1VTSWFp?= =?utf-8?B?TXNXc3k5Rm9CNDh5anBjbUROMHliVS9hWUhwKy9IZjVwUzBSL3V0QWd0QXgr?= =?utf-8?B?V29lZlF6M2RwMWpsVmd5VUlla1FuUExWVGsyd2pqaUlrZ0p3NjVsM2VrMFJ6?= =?utf-8?B?MDlxdnpSeGxyVnRoV1hIWTBuRHJrR05JWU9vYTdyd3pFc2l5eXR0cEpNaFhO?= =?utf-8?B?UGVRcTNGRVQweEZDRTZUZHdZU0U2M21EUXZZNStUSWVkdDF2MkRDb2pHdVZo?= =?utf-8?B?U1prcG0xSittK2lkazBndzlMaG5SQ1FqS3FidEt0bjZZeXQwdUYycFBIY2Zp?= =?utf-8?B?NnRpbTM1SVhORnZGN0thR3E5ejRqWjFvNVRVNFBtU3BYUkQ3OWlWbExCSVVS?= =?utf-8?B?dTZWeFc0K0I4blhiU1FZRFliRUVQWkFLZGF2aUFmalJmSlczdVZzaVJsRWQy?= =?utf-8?B?T25YSUVEMmpSdWROMFhnWE9QRDRTTE54YW5vS2k1eThNMTd5b3hCMDBqZjNB?= =?utf-8?B?bFdQNzE4dkN5eFZFQkNmeUpYY3RUM3U2czU4MEluVFc3UWJPcEdzWWZ6Z0tp?= =?utf-8?B?dlpEempSQXpzdXRpRVU1RzV6VklKWGxUMGFUaFY2djFUOTRNQmVsMkMvYitn?= =?utf-8?B?OFhtMElMSy81YUFTQnBITVJWb0VHb1dPbUMvVnJjSnZBZ3NiQ1ZwTTVxMDZi?= =?utf-8?B?VnJ1UFZUWTBOa2ZXRnhVQktBNXg0SFlESjVtTWh2bmg0UkdOOFN6cmRrNkNO?= =?utf-8?B?K0VoZ3R0S1F6OUQ1aUYzNEZld21MYmhPcVc0TktDVGxJVjN3cDlIQWxEb2FO?= =?utf-8?B?eE1xR1ZNUUhxSFpmbzNrSGJKQ2J6cUpRZ1JjS25uRDdaNzlxRG0xS0FQUE1j?= =?utf-8?B?YmRMQm14eHE5NVdmdkJ4WGZFN3EzVUNERVQ2bFJWN2xyWDFlbXF2a3FIdG1q?= =?utf-8?B?OEkydHVYVCtJaFFKNXpMc2FIL3F0NjVRMktFSXdwelQrUnVhSXJWUnp6N1RM?= =?utf-8?B?cFh3LzdocEJHM2FrbDAzdDI0N0gvWXcyQnUrSlJ0cGNKYVRONm84RktjMzNQ?= =?utf-8?B?cS9ORXVOaTI1dGVZOXVvcXVZWnpaN2dpbDIrZTA2L1V1RkxmMCtkSnhnMVdm?= =?utf-8?B?aEdZUmRiVUR5YmNMMjJPaGhDT2JNQ2RXNUdNczVIVm9aYTRUZk9UeXJyV0g4?= =?utf-8?B?b0FSdUwwVzN4MTVwenJ1MEJFRHJtRkNCWUhVY09LdllkNG9JeU10dUdOaU9i?= =?utf-8?B?SUxzSnlqRFhzTmlwRFFSaFRscFEyMWN2NStRcWhaZ1RXSWtsOTZSZXgvYkh1?= =?utf-8?B?NkRVQ0E2S003Z3Y5ajd4Y3U2d3lYUEVmMEhXVWVnVVFaZ05YelE5cGNZbVRQ?= =?utf-8?B?Q002N2xrK1VrczFXS0FvaVBrWHRNSlFIZjRLY2NLc0pHVXV4ZWZ2TWtPZWt2?= =?utf-8?B?bEp0N1RzYW5lMDVOZEZYZXFXSkJhdk5Dem0vV2l1VDJicFNHcFlBMDA2Yzgy?= =?utf-8?B?amR6UWl3ZVI1Z3hIbkxqMGg0aEEyU20yT004M0ZhN0FEREkrOEhrc2ozYjhI?= =?utf-8?B?UVU4Nk1kNk14Y0xTeTRpLzl4WWYrUGQ4WkxObjRBcEN5UUE5bERBRkdTalBs?= =?utf-8?B?eEZiTHVmTWJCcDZ2b1prN2FlbUtKWS9EaVNYNXFYRHdXV1V2RWMvVUNZMlps?= =?utf-8?B?NmxjdGJGZE4vU1hsVFlhMHFLVnNYbFBnZnc3aDVuZU41V0pBaWRwRFF0TGZx?= =?utf-8?B?SkxiZFZRN005cDkzS0lvOEF1VXRqVERiQ1h2YTUwbGRLOVRSNFM0bHQ0WmxF?= =?utf-8?B?U3BhYzVZSjR1UGNmSGZVTEtCSlE1d21rWHAxWnBNL2VjY0JVYzRQVGZOQnYx?= =?utf-8?B?UVYwT2VJdmtaaUt4NE1NT1ZmZWRKYW05T1FocmRuYURaTUlqZXJRdGUvZ1BX?= =?utf-8?B?VnhVdmlwaml0Q21hNU00TWZGRi9kTVNZZHhpRm9tUWUvREtRQ3d2SlU0TERQ?= =?utf-8?B?M0JoaE5ra2JmdVQ0MVRuQzZ2ZGJIcFNZTHMzanBtazU5VFJnQ2M0R2pXdk5o?= =?utf-8?B?RHhFTjczbFJGMlZ1aGVCL3NVL0ZtekZlaVRwTCt1YjZpVStQTGtxYkVDQytC?= =?utf-8?B?Q3liVTJoZ01FaHBWa0h5S0ZxNVhVVlVOTTRFcUkrNjdpbDNsK1RVbndnRTgy?= =?utf-8?Q?s/vQVVrxklllzcfw=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cacbfc9f-b9ee-41fd-495f-08da3762f8ea X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 17:39:05.0335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eZkmD/uRKpFb+eispC4FfVdYfmUDNgEAfMVdS5zKzYtuNdZCkEP5ok42v2qysYgdwSkxW8DIhle4RaIi+PcXfk6omokIIRhOKIYfmMx0pqk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2554 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-16_15:2022-05-16,2022-05-16 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205160096 X-Proofpoint-GUID: QucM697BXxBM8RShIpoO5kDsJLHQbrZB X-Proofpoint-ORIG-GUID: QucM697BXxBM8RShIpoO5kDsJLHQbrZB On 5/13/22 5:19 PM, Stefano Stabellini wrote: > From: Stefano Stabellini > > Sync the xs_wire.h header file in Linux with the one in Xen. > > Signed-off-by: Stefano Stabellini > > --- > Changes in v5: > - add XSD_ERROR(E2BIG) > - Boris gave his reviewed-by but due to this change I removed it Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Mon May 16 17:46:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 17:46:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330241.553601 (Exim 4.92) (envelope-from ) id 1nqenf-0002xa-R1; Mon, 16 May 2022 17:46:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330241.553601; Mon, 16 May 2022 17:46:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqenf-0002xT-NY; Mon, 16 May 2022 17:46:31 +0000 Received: by outflank-mailman (input) for mailman id 330241; Mon, 16 May 2022 17:46:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqene-0002xJ-Mi; Mon, 16 May 2022 17:46:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqene-0007jm-Ko; Mon, 16 May 2022 17:46:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqene-0007iW-Cs; Mon, 16 May 2022 17:46:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqene-0002ig-CS; Mon, 16 May 2022 17:46:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bmP6bX3PHlcYF6T3q4Yi+R5fzILfyGkGwzRHzZzyXNo=; b=KkCFuElAQM63dla3HweTTZ1XHy bqyK6jrqGcUM4vkaT2b/ZJiVnp3tb2NVcsOlo4cCqTl4lrTPDSlmp6RNLLk2Hyt4fxwPE0WvHBLYw sijvYz2TWu6UZeddVaPRheUswGiOUk8X6vnxdORyt+r9x3L4KjO260vVufTrmqnVO2Ws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170485: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 17:46:30 +0000 flight 170485 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1047 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 66 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 18:01:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 18:01:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330251.553612 (Exim 4.92) (envelope-from ) id 1nqf1z-0005JE-3J; Mon, 16 May 2022 18:01:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330251.553612; Mon, 16 May 2022 18:01:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqf1y-0005J7-Vx; Mon, 16 May 2022 18:01:18 +0000 Received: by outflank-mailman (input) for mailman id 330251; Mon, 16 May 2022 18:01:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqf1x-0005J1-T5 for xen-devel@lists.xenproject.org; Mon, 16 May 2022 18:01:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqf1x-00084k-DP; Mon, 16 May 2022 18:01:17 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqf1x-00012P-5s; Mon, 16 May 2022 18:01:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BFVqC6gJWelypNLb8jsRmm/X66gu0Uiod+rPrLVyjP8=; b=VWzLoqvReOZZeij0hbMCXH9r5s zWwqJcHNZ1HcbThmxJi816qj45Ly+YepIs2e+xOInmvyaXlkL0cyZ+sPy4uflEiPVCezsO6FyQpbN bFc36bfHdJVmXojhVBSnwtpH7lPPlfVPtpdtTYE+8C8EJyAogSt64or5Z8s7iHKjFCtM=; Message-ID: <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> Date: Mon, 16 May 2022 19:01:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220510022733.2422581-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 10/05/2022 03:27, Penny Zheng wrote: > Pages used as guest RAM for static domain, shall be reserved to this > domain only. > So in case reserved pages being used for other purpose, users > shall not free them back to heap, even when last ref gets dropped. > > free_staticmem_pages will be called by free_heap_pages in runtime > for static domain freeing memory resource, so let's drop the __init > flag. > > Signed-off-by: Penny Zheng > --- > v4 changes: > - no changes > --- > v3 changes: > - fix possible racy issue in free_staticmem_pages() > - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case > - move the change to free_heap_pages() to cover other potential call sites > - fix the indentation > --- > v2 changes: > - new commit > --- > xen/common/page_alloc.c | 17 ++++++++++++++--- > xen/include/xen/mm.h | 2 +- > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 319029140f..5e569a48a2 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1443,6 +1443,10 @@ static void free_heap_pages( > > ASSERT(order <= MAX_ORDER); > > + if ( pg->count_info & PGC_reserved ) NIT: I would suggest to use "unlikely()" here. > + /* Reserved page shall not go back to the heap. */ > + return free_staticmem_pages(pg, 1UL << order, need_scrub); > + > spin_lock(&heap_lock); > > for ( i = 0; i < (1 << order); i++ ) > @@ -2636,8 +2640,8 @@ struct domain *get_pg_owner(domid_t domid) > > #ifdef CONFIG_STATIC_MEMORY > /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ > -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > - bool need_scrub) > +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > + bool need_scrub) Looking at the implementation of free_staticmem_pages(), the page will be scrubbed synchronously. If I am not mistaken, static memory is not yet supported so I would be OK to continue with synchronous scrubbing. However, this will need to be asynchronous before we even consider to security support it. BTW, SUPPORT.md doesn't seem to explicitely say whether static memory is supported. Would you be able to send a patch to update it? I think this should be tech preview for now. > { > mfn_t mfn = page_to_mfn(pg); > unsigned long i; > @@ -2653,7 +2657,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > } > > /* In case initializing page of static memory, mark it PGC_reserved. */ > - pg[i].count_info |= PGC_reserved; > + if ( !(pg[i].count_info & PGC_reserved) ) NIT: I understand the flag may have already been set, but I am not convinced if it is worth checking it and then set. > + pg[i].count_info |= PGC_reserved; > } > } > > @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > +#else > +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > + bool need_scrub) > +{ > + ASSERT_UNREACHABLE(); > +} > #endif > > /* > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > index 3be754da92..9fd95deaec 100644 > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -85,10 +85,10 @@ bool scrub_free_pages(void); > } while ( false ) > #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) > > -#ifdef CONFIG_STATIC_MEMORY > /* These functions are for static memory */ > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub); > +#ifdef CONFIG_STATIC_MEMORY > int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > unsigned int memflags); > #endif Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 18:29:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 18:29:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330259.553623 (Exim 4.92) (envelope-from ) id 1nqfT3-0007oD-8i; Mon, 16 May 2022 18:29:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330259.553623; Mon, 16 May 2022 18:29:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfT3-0007o6-5q; Mon, 16 May 2022 18:29:17 +0000 Received: by outflank-mailman (input) for mailman id 330259; Mon, 16 May 2022 18:29:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfT1-0007o0-Ta for xen-devel@lists.xenproject.org; Mon, 16 May 2022 18:29:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfT1-0008VH-FL; Mon, 16 May 2022 18:29:15 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[192.168.22.38]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqfT1-0002lY-93; Mon, 16 May 2022 18:29:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IL70NZxb6zoseb6l/HUHk2CGlwdjbX+D3he4HKunysU=; b=EGsjSvhU0cgahK08fXHdj7T49n ESTfv3sLcLigqoePctEWdLY9txbxeK7296bQ3M75Sif4I9ZO6/U1Xj5UdS7mUkh+thyMx+VZ23XkC VZBz5C9kBenujgp/BnvMySt1+n5r1C2ImMDu4wLUlypb3WrIsRA8zeHtAv3Ba/d989KE=; Message-ID: <7af0d53c-6fdc-33a4-a09b-93831b4ee2c0@xen.org> Date: Mon, 16 May 2022 19:29:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-7-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220510022733.2422581-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 10/05/2022 03:27, Penny Zheng wrote: > When static domain populates memory through populate_physmap on runtime, Typo: s/when static/when a static/ or "when static domains populate" s/on runtime/at runtime/ > other than allocating from heap, it shall retrieve reserved pages from I am not sure to understand the part before the comma. But it doens't sound necessary so maybe drop it? > resv_page_list to make sure that guest RAM is still restricted in statically > configured memory regions. And this commit introduces a new helper > acquire_reserved_page to make it work. > > Signed-off-by: Penny Zheng [...] > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 290526adaf..06e7037a28 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2740,8 +2740,8 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, > * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, > * then assign them to one specific domain #d. > */ > -int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > - unsigned int nr_mfns, unsigned int memflags) > +int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > + unsigned int memflags) > { > struct page_info *pg; > > @@ -2769,12 +2769,43 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > + > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + mfn_t smfn; > + > + /* Acquire a page from reserved page list(resv_page_list). */ > + page = page_list_remove_head(&d->resv_page_list); Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock (mostly like d->page_alloc_lock). > + if ( unlikely(!page) ) > + return INVALID_MFN; > + > + smfn = page_to_mfn(page); > + > + if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) I am OK if we call acquire_domstatic_pages() for now. But long term, I think we should consider to optimize it because we know the page is valid and belong to the guest. So there are a lot of pointless work (checking mfn_valid(), scrubbing in the free part, cleaning the cache...). > + { > + page_list_add_tail(page, &d->resv_page_list); > + return INVALID_MFN; > + } > + > + return smfn; > +} > #else > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub) > { > ASSERT_UNREACHABLE(); > } > + > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + ASSERT_UNREACHABLE(); > + return INVALID_MFN; > +} > #endif > > /* > diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h > index 35dc7143a4..c613afa57e 100644 > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -38,6 +38,10 @@ void arch_get_domain_info(const struct domain *d, > #define CDF_staticmem (1U << 2) > #endif > > +#ifndef is_domain_using_staticmem > +#define is_domain_using_staticmem(d) ((void)(d), false) > +#endif > + > /* > * Arch-specifics. > */ > diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > index 9fd95deaec..74810e1f54 100644 > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -92,6 +92,7 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > unsigned int memflags); > #endif > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); > > /* Map machine page range in Xen virtual address space. */ > int map_pages_to_xen( Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 16 18:30:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 18:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330267.553635 (Exim 4.92) (envelope-from ) id 1nqfUB-0000gN-Lj; Mon, 16 May 2022 18:30:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330267.553635; Mon, 16 May 2022 18:30:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfUB-0000gG-GI; Mon, 16 May 2022 18:30:27 +0000 Received: by outflank-mailman (input) for mailman id 330267; Mon, 16 May 2022 18:30:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfU9-0000g0-CH for xen-devel@lists.xenproject.org; Mon, 16 May 2022 18:30:25 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 400d48cf-d546-11ec-bd2c-47488cf2e6aa; Mon, 16 May 2022 20:30:24 +0200 (CEST) Received: by mail-wr1-x430.google.com with SMTP id h14so2007320wrc.6 for ; Mon, 16 May 2022 11:30:24 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id r3-20020a1c2b03000000b003942a244ebfsm53364wmr.4.2022.05.16.11.30.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 11:30:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 400d48cf-d546-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=3jGcBrcY/jLsXzsLfKk32I2R7rTzaPyklhz34IxOo3M=; b=m5I2ZkMmcbKDY1hCG8XD6CqFcYFPbQD/X48DcL+yaGg2MRUIoHPiYjZyZXvczTg3f0 O42qyLDg3uH3jpFseje/GdEYwI6XqfzNWRDfbARQ7yAuK2GUv2IIWd0UBCgCKNdOrown nupUjuPyB+J3pLa9Qh+2TxolJUJuPEZGMFwb3MdceoelzEnkGSNIU3YWYK7RodEZxc+P AY+5ZggJhDjgwbUE+6UqcmH7GIocMLY5jfow5QD80IV4B/2GP0wVRb035u82DltR8qjm 9Lj5+BAiQRq7Oj8qiMFwb+zr+hMRBHr8E+PL1ysaE7HfZbof+ztIlgYOM8yMqS8yOxj4 3BiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=3jGcBrcY/jLsXzsLfKk32I2R7rTzaPyklhz34IxOo3M=; b=CRzE1g6J8l8VRtkc+zP2JHE2rWSRcIKOJ1CMKYfmmfZTP7xgXEabdP80U9+RApzz5U STsGK/E71p3/js93Yc0EktCn1JVc5hMZPiMuEehxJJWdvy+UcoRdF3qkroTIYtFyQ/F6 XaAdv28POZVmMWGLlkDyz/L3WwbSBXQj0PDaRY2bD1lMK+5Srl8MpF/AIwDejitIdMUr FGzzQpbzMKDxU4u7J7utPrB07nQqZN+3dY4/155MgRQzGM0Z2ER/097xGi7W1jfwi2qo 521cUwNxzw5IH1dWFsdEjK12wDukcoohGEOPkknDslaqmU9ffDZzgGQHhOY0pKmAJaxm 1jug== X-Gm-Message-State: AOAM5309Mo9VZKZT1KYWP7M2vNCFBZv8s+FcmUxouZkcaO1Ht95PMOrL iHffmHfUrzor8kdksZIEf6k= X-Google-Smtp-Source: ABdhPJzIVgHVeOibJu0TIAo+Vy7dy8YkqIjCpy35I/2hFdACnClISv6EqWdfGQx1H6PbR5d19wGJog== X-Received: by 2002:a05:6000:1e16:b0:20c:d56a:6025 with SMTP id bj22-20020a0560001e1600b0020cd56a6025mr14995584wrb.74.1652725823548; Mon, 16 May 2022 11:30:23 -0700 (PDT) Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants To: Boris Ostrovsky Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> <80286144-cca4-ef07-3aca-2c2374881738@oracle.com> From: Oleksandr Message-ID: Date: Mon, 16 May 2022 21:30:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <80286144-cca4-ef07-3aca-2c2374881738@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 16.05.22 19:00, Boris Ostrovsky wrote: Hello Boris > > > On 5/16/22 1:59 AM, Juergen Gross wrote: >> On 14.05.22 04:34, Boris Ostrovsky wrote: >>> >>> >>> On 5/13/22 1:33 AM, Juergen Gross wrote: >>>> On 12.05.22 22:01, Boris Ostrovsky wrote: >>>>> >>>>> On 5/7/22 2:19 PM, Oleksandr Tyshchenko wrote: >>> >>>>>> +/* Rebuilds the free grant list and tries to find count >>>>>> consecutive entries. */ >>>>>> +static int get_free_seq(unsigned int count) >>>>>> +{ >>>>>> +    int ret = -ENOSPC; >>>>>> +    unsigned int from, to; >>>>>> +    grant_ref_t *last; >>>>>> + >>>>>> +    gnttab_free_tail_ptr = &gnttab_free_head; >>>>>> +    last = &gnttab_free_head; >>>>>> + >>>>>> +    for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); >>>>>> +         from < gnttab_size; >>>>>> +         from = find_next_bit(gnttab_free_bitmap, gnttab_size, >>>>>> to + 1)) { >>>>>> +        to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, >>>>>> +                    from + 1); >>>>>> +        if (ret < 0 && to - from >= count) { >>>>>> +            ret = from; >>>>>> +            bitmap_clear(gnttab_free_bitmap, ret, count); >>>>>> +            from += count; >>>>>> +            gnttab_free_count -= count; >>>>> >>>>> >>>>> IIUIC we can have multiple passes over this, meaning that the >>>>> gnttab_free_count may be decremented more than once. Is that >>>>> intentional? >>>> >>>> After the first pass decrementing gnttab_free_cnt, ret will no >>>> longer be less than zero, so this can be hit only once. >>> >>> Oh, yes, of course. >>> >>>> >>>>> >>>>> >>>>>> +            if (from == to) >>>>>> +                continue; >>>>>> +        } >>>>>> + >>>>>> +        while (from < to) { >>>>>> +            *last = from; >>>>>> +            last = __gnttab_entry(from); >>>>>> +            gnttab_last_free = from; >>>>>> +            from++; >>>>>> +        } >>>>> >>>>> >>>>> I have been looking at this loop and I can't understand what it is >>>>> doing ;-( Can you enlighten me? >>>> >>>> It is recreating the free list in order to have it properly sorted. >>>> This is needed to make sure that the free tail has the maximum >>>> possible size (you can take the tail off the list without having >>>> to worry about breaking the linked list because of references into >>>> the tail). >>> >>> >>> So let's say we have the (one-dimensional) table of length 13 >>> >>> idx    ..    2    3  ...  10  11  12 >>> >>> grant       12   11        2  -1   3 >>> >>> >>> and gnttab_free_head is 10. I.e. the free list is 2, 12, 3, 11. >> >> You meant 10, 2, 12, 3, 11, I guess? >> >>> >>> What will this look like after the 2 iterations of the outer loop? >> >> idx    ..    2    3  ...  10  11  12 >> >> grant        3   10       11  12  -1 >> >> with gnttab_free_head being 2, i.e the free list is now 2, 3, 10, 11, >> 12. > > > > OK, thanks, that helped. I couldn't link the free chunks in my head > > > With the error handling in gnttab_init() fixed yes, this is a diff that I am going to apply for the next version: [snip] @@ -1596,19 +1601,20 @@ static int gnttab_expand(unsigned int req_entries)  int gnttab_init(void)  {         int i; -       unsigned long max_nr_grant_frames; +       unsigned long max_nr_grant_frames, max_nr_grefs;         unsigned int max_nr_glist_frames, nr_glist_frames;         int ret;         gnttab_request_version();         max_nr_grant_frames = gnttab_max_grant_frames(); +       max_nr_grefs = max_nr_grant_frames * + gnttab_interface->grefs_per_grant_frame;         nr_grant_frames = 1;         /* Determine the maximum number of frames required for the          * grant reference free list on the current hypervisor.          */ -       max_nr_glist_frames = (max_nr_grant_frames * - gnttab_interface->grefs_per_grant_frame / RPP); +       max_nr_glist_frames = max_nr_grefs / RPP;         gnttab_list = kmalloc_array(max_nr_glist_frames,                                     sizeof(grant_ref_t *), @@ -1625,8 +1631,7 @@ int gnttab_init(void)                 }         } -       i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; -       gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); +       gnttab_free_bitmap = bitmap_zalloc(max_nr_grefs, GFP_KERNEL);         if (!gnttab_free_bitmap) {                 ret = -ENOMEM;                 goto ini_nomem; > > > Reviewed-by: Boris Ostrovsky Thanks! > > > > -boris -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 16 18:41:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 18:41:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330277.553645 (Exim 4.92) (envelope-from ) id 1nqff1-0002G8-Pk; Mon, 16 May 2022 18:41:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330277.553645; Mon, 16 May 2022 18:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqff1-0002G1-Lr; Mon, 16 May 2022 18:41:39 +0000 Received: by outflank-mailman (input) for mailman id 330277; Mon, 16 May 2022 18:41:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqff1-0002Fr-4Q; Mon, 16 May 2022 18:41:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqff1-0000Id-2f; Mon, 16 May 2022 18:41:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqff0-0000c9-NK; Mon, 16 May 2022 18:41:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqff0-0000ai-Mu; Mon, 16 May 2022 18:41:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uUJs1I5m8tKSPynvcyf49JA0njgR1BmHydceJRfBeVA=; b=NLFVDu6KVBXmrJc6G56+xIItYw Y/6gCrc9T29bjkZiL0fIgiWonOpoG7W96YKH3emoRUp2o7X8Jlq6OshkGIkq/5QmOjSPie0r+gyun oyroVE5ZA35CbORw6CczjzEaJUbc07NQ7irFN2VQMiL+/UckvugJnKd+0ld1Vg5QSwsU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170487: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 18:41:38 +0000 flight 170487 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170487/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1048 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 67 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 18:58:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 18:58:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330288.553656 (Exim 4.92) (envelope-from ) id 1nqfvA-0003oA-7D; Mon, 16 May 2022 18:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330288.553656; Mon, 16 May 2022 18:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfvA-0003o3-3q; Mon, 16 May 2022 18:58:20 +0000 Received: by outflank-mailman (input) for mailman id 330288; Mon, 16 May 2022 18:58:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqfv9-0003nx-8F for xen-devel@lists.xenproject.org; Mon, 16 May 2022 18:58:19 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24a02a30-d54a-11ec-837e-e5687231ffcc; Mon, 16 May 2022 20:58:17 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GHVvd6017443; Mon, 16 May 2022 18:58:04 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g24aac69w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 18:58:04 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24GIpugt005200; Mon, 16 May 2022 18:58:02 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3g22v7rh83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 May 2022 18:58:02 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CY5PR10MB6168.namprd10.prod.outlook.com (2603:10b6:930:30::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 18:58:00 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::125:f19d:8eaf:b8e4%3]) with mapi id 15.20.5250.018; Mon, 16 May 2022 18:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24a02a30-d54a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=4olkkxipV5iBgWH0NsT2vT3vMCEIkKfDcstu9Ms0s38=; b=tM4iSyOmfXcX6pUQVZg3+aau3IV8Wvfp0UYUpqq4HV1oqM09BHbyB4IbSstXW64X5BKj Gc06OQHkFHssAVEWnAMNaSfwgzBS04yZPyYrC3eJl5cg3ydoC99ubslXWD8yUUefHwHT VTz4km6PtTyd9m+Yy6O4sabG+a43Hy2rsAo4pyzqQ/oU281OAI01UnJ0xqMhBzODrkxO mBy9t/IeUIn8aKUd+7oj2kUtZlDTEMTFVYHPUR6dCJ8EkWal4kD1Ui8wKom4tuqSAkPu lZIG+EqeHXszkszqf8BcogzOHRjftLPDKMETUXLzVYk6xvXdsB279nF4UlbzI5zPDlti Ew== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9HGbFi1yJdlYpDw0w/tX3MCuN9Co/v2HQ5KeK11Gk5h1nEJK4qfrvgXWhZTO0CtRYN8QPnRmG5vKLLF9N/O0MAbe0FEWfPwLy1NyhD49euKPUNuSM9mS6dgpfhCz01xksSMg+gtpBEWIIuJtWyYBTRmn5jliszJvbu7n3EwpvTS9PRdvX0Bj6wF5l4xoZG92Ewch7pJXkd5/8e8lKBC55z7EOEAEzySdR4LadgMhrroSxZBpEtwLTdv74/PPSdCa4sFUtPTSFvKEFXS+y/l7lYB7LqnVSjucH3BG7KaOcwwPzfnqt+nlA8hoQCaRhxqWaiHkvVMOhLCro7HNU8aWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4olkkxipV5iBgWH0NsT2vT3vMCEIkKfDcstu9Ms0s38=; b=Qx/qfb5FvD5QZ5rENDsfGmylPwMIo4Se54qSHXZS9ZJrJtBc7HkkpoRN0muMwxMKiTw++hOZnlsgKOOV6lY+XOves7ID0wNUtCkh8tL87oZL8sg1vADLkST6yXpET4ZERLACFPUNhPsP71rVfV8v+cIHlGfR2OwZ5vDhacJrpGwpUAGB1eE/eyiyK8p0htjgkrgK7SzrTnlGBJbg7j6sqcRZku/jZHPipzCpwi4orLs1O+C8dEualHMu2b2whmPytP6nnGqmX5LSdwi/WKGI21KO05GL15oQ5y1Ak5bO1qZJL6TWQM93a71zq4Dx82mzDB9/j/aZygh+dY3ROPhofQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4olkkxipV5iBgWH0NsT2vT3vMCEIkKfDcstu9Ms0s38=; b=y7qgOSgBL2SayOkSSlptZQfkNhqVExcPzNDvuxcXoDkjiYzHOh/2G/w6moVfnI0BayUSOje8tQiO9YHB69EFdgIq82+fugMO6KDBeus67JImtaAIwkEjXo3XLrLPyjwuYX7S4MtrtY5EXUPFp1HC4eTA/yIX8OTb52qSaJBf86A= Message-ID: Date: Mon, 16 May 2022 14:57:56 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V2 2/7] xen/grants: support allocating consecutive grants Content-Language: en-US To: Oleksandr Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-3-git-send-email-olekstysh@gmail.com> <597125fd-4c85-fde0-9d5b-a9cc13a81ccc@oracle.com> <91f95228-215c-b817-8bb6-8e24c0caf925@oracle.com> <80286144-cca4-ef07-3aca-2c2374881738@oracle.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA0PR11CA0070.namprd11.prod.outlook.com (2603:10b6:806:d2::15) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52f6e2c9-3ca4-423d-ce56-08da376dff90 X-MS-TrafficTypeDiagnostic: CY5PR10MB6168:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pKQVf2RN/HilF7pYNTYsfG7F+Yrh64+NHbBZ2sBPhbbPwRSR5fLU7tmgtTT6DFGLViKCxGGhFAH57r2NwQU3kzwhYPUvUz4JG6JEiZHJ53sYO9n/J80K2s9VSVL54cI0ptOs8cBNnJtzE9M6EyxvYUYemLlIy4qQCryIqW0q1NXQS0doqV7BVatyPM/ulCJAyOT2+qRTTy1Ve0rXiq2bgYWXsm0ZEzaI4q41Y+HLFLpdfebXMk0WOeQOyAPi7EU3tgPiazYbEAx1E+MSriS9vz5IGPxrrtmHBGPmjiUukylbk5RuarXqqEa2EQy5AtM01/jdwWGUzvToygrdkc9synEBIGwf5OzjHKyJrETsOiVzJFFWEY8xGu7F7jkUy133VtN/jYDs9nkCEn17+J3IQqg/qKOeYwlUfA2VHUA/iS5ykEtQsfCzijypo0BcwyFpqqQ4WGtqYl26guSZSgqHBGOFcFi6S4ZZqqzYyd68R2IwMzSofLgPJXlIKWozcHNDymSXiX683VuB3rC/dKOfqXE0/LK2Wkz40eRZ+PT2BNK2iah77/6Bp1ShNmH7swI2m3qEr8le74HFg9p8KCS1IOL4ZqKmv1IntPSVzp0RWhLx6VE2n1EaAMUNno3U/4NE3hBGt5CcRHfsEi5TRLu+Cn+kjQ1NX1VO1NEYjaMx4gAT3TRWM/CJhTfEj6YsD5RuPv5hYyVrL/YGIS5T81uJa1cNvpebI5w812xT3Suvt6ZYwc1G+DppkiiJ/FqvQ7yaF7OcL4CEmu6eOYNIDrhot6a7sis0zk43qPJRhtBaVZw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(53546011)(8676002)(66556008)(6506007)(66476007)(8936002)(508600001)(44832011)(2616005)(5660300002)(83380400001)(6666004)(2906002)(316002)(6486002)(36756003)(6512007)(26005)(54906003)(31696002)(6916009)(7416002)(66946007)(31686004)(4326008)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlNCTmJMYm1kN3UvNVVwWk1wQ0JSVm1PNDVNazJWY3V0Z0xMeVE0VFdsbk9p?= =?utf-8?B?QmxWM0c1QUlMV0FUSU5CaGNNQUhhblZTSjBiWmYyWVZKbW00WURqTTBPYVBN?= =?utf-8?B?STZjQnU3TEJMMFl4VVpxVlgwZCtyTjlHSjlDcWo5cEJ2Q3BKTk04eU9hUTRi?= =?utf-8?B?dnpoNDVReTZQS1MzMVMydXJxaXRVTXdXVW9uLzZ3QS81cWZmcHVac28zZDRB?= =?utf-8?B?MGw3VUowK0dzVVJ5UncycnZhbmlzWng2ekRBeklpN3psVDlXRjZRVkJFYkYv?= =?utf-8?B?QmtMQnNOSHhkazV3K3dnVHJBSWd1Zk04b2wwZkJBdVpJc1ZhdElQYlRUUXFi?= =?utf-8?B?YzRsamp2cWJsM0wrT1Q2czdVR0ExN0NvUHZqK3RjUFdsbXJTZTYzOWRveUsv?= =?utf-8?B?YSs0OVVoSUZmSWJZVUNsdGFEOUVBVFFWSGdyUmdieFRuR2tSN0VPdDhoQytY?= =?utf-8?B?WTMwcTNpMzAzQjdTNEd3cWNBWTBjZTZia09OS2EyaG5BUktmb0JYbitFWlpp?= =?utf-8?B?SzdObm84Y3AwdWQ1eThrTjZsUjRuaUxWc2g4YktnTGUwaCtxQkhzWmtwSllt?= =?utf-8?B?UDlLS0RiRTRTWE5LaDNQdFJQK3gxY3VFRHd6VU9uRExaZU5iZ0FscXJRSDV3?= =?utf-8?B?WUtERzZCZHVTTWpyUUdDNXBGK05tbzZGTkpPRVh6WTZFOExoWXhMSkxkdDIr?= =?utf-8?B?YWZmelVQYmQ4REVta0t2YlVYSksyb2ZqRk0xT05wcGd4TGs3T08xekJyY3Va?= =?utf-8?B?SkVabDV3TWcwNUhVREVtN3MrMXhwVWsremJTWEtpRzhkeSt1dDM2RTBCMmdO?= =?utf-8?B?ZnF2c3RPYmpkZ05MNXVUajFYdXhOblRQQVNKSVFNMHh6S1RBNTlDMGJLTVlt?= =?utf-8?B?NmZZOEdxQjBEN0duSVgzQ0k3dlA4eldzaFZGZUpBaEo3Wm1Vd09VMURiYW82?= =?utf-8?B?NHN1SGxSTTl6UHZmM1VySnYyOEd0dGhLTUEvQ0JPM1EwblMrUWMxVmRDU0NK?= =?utf-8?B?N0gxTlZISlVMZ0dHdEtCWWNjWWdwbzRXTEswbUZ1UmR3dnBUK2FNZFRHNjJk?= =?utf-8?B?SnhxdjVnWUNUVVhxSTNXMldjWEVoVlMwVExIKzhXMDRGNHpueDMwd2J4Nnhn?= =?utf-8?B?MUlmNXFBUUZUT3pvSzl5bWUvZ1VjT2x1VWZLUkczb0phYlBKbmZ4VlhBRmZE?= =?utf-8?B?dmhjUkhvZmhEMnVzUlluZzVrTU1STFJpd0J5WHAzdHA3Zm05cVR4SDJ1MEJ6?= =?utf-8?B?QitTNDFNaTE0YkFKb2p4ZWRnMFVWUXVsdXVSV1ROU3JKTXNTS3NrK0JjYTBQ?= =?utf-8?B?UGN0a0Exb2RrSHlRc21WSUtCTDlNN0o0bERvanNrN2M2aHVyU2J0aHNDWWlq?= =?utf-8?B?NndZSGFEdTdvU2dVUjcvZE4vdWFLVWlDVVdXaU9OL0x0Znc5cGVRRVVDdXFt?= =?utf-8?B?S1JONDdxK0g5OERsYWxjdWIwbVZkZEkzUEYwM0ZKSDVPc2RZQTQzejVhU3VD?= =?utf-8?B?UnFqL0dBbXNXVm9sUGFDeVlRUTNOUy8xTWkremEzVHRwTFV4dmZGUnJONzVv?= =?utf-8?B?YmVJWjdudmsxblBNYUplQmVnN2p5NllVYXVPVHAwc00rY0lsTDlTV09uTHBJ?= =?utf-8?B?OGhnMkpqMW5XTVF3RGZ2b1crdTkyRTZEOUxQejA1am1BS3MwblBhcWczRnVO?= =?utf-8?B?NkpWTEF1Q0RjMExQZndJNVJwR2Y5QzZ6eDFadm1neWlTeWprR0l5Yzk4MEFE?= =?utf-8?B?UXBNREhNVnZMV1Q5Nkd6aXZJZmVFQWE1QVNuWW1lM1NkdlBvd3l1S2VZOXhy?= =?utf-8?B?M2crVHpGa2RzZHRMOTg5NGJYZmNvUmdYSWR3Zm95T2JETG5GRjRoNDk2TEdq?= =?utf-8?B?MUpHa3lxL3V0UzZqdzlYbVRkY1NkZG5aZy80ZCtpYTdkUWw0b0pUSlk2c2tL?= =?utf-8?B?d3VOOCtBbDlvelAzdkhKRHF3bEYrNGNNbkppRGFOK2ZTelBlbnZVVlQrOStN?= =?utf-8?B?ZytjdS9mdWpHSXRxWHJSQXptNmRjUlBCc05yeGxzWXk2bmtCZ2JyNzlKV2Nk?= =?utf-8?B?QTBHL2F4TFVQUDNGajRtOXRVQTdmVk9SNU51cTVIZWFUUUhDZ3NvNDZMdXJw?= =?utf-8?B?NkdtN1BtN3IzakM4cVJlSGlOeXJtdU5pbkdUZG53MUZ6bzVzYmJoTllVN3M1?= =?utf-8?B?NWkvQk00TE91QzVPTTlEMWZ3azdFT05YZkVBNEdaZVAzTElBajFMYUVCU1Ex?= =?utf-8?B?eUU5NkhndG1JUWJEaHRpRDUxamhjN2pFOUtGcGY4eG1ucjVHd1lOdXhMaEwv?= =?utf-8?B?S2ZHOFI1Y3FEbnkwVGlEeUZLZnM1dTFCb05XbjY0U0pOLytlQzI0Zjd4QVE1?= =?utf-8?Q?rshZmBN0oLqZD1fU=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52f6e2c9-3ca4-423d-ce56-08da376dff90 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 18:58:00.5926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2dw+h4EABxt/ZbbQEwR8jBqR9RNbnvQHWSXvqwT/y/UvJkIqTQBLhRgil9QQkZ3vb6YMITTA4Uy9PW0nKpAXt63OrV+LhTsBxfMYEiKunJ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6168 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-16_15:2022-05-16,2022-05-16 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205160103 X-Proofpoint-ORIG-GUID: Kl333BW_d_mlEtLHU0944bhEAHihCsug X-Proofpoint-GUID: Kl333BW_d_mlEtLHU0944bhEAHihCsug On 5/16/22 2:30 PM, Oleksandr wrote: > > On 16.05.22 19:00, Boris Ostrovsky wrote: > > >> >> >> With the error handling in gnttab_init() fixed > > yes, this is a diff that I am going to apply for the next version: > > > [snip] > > @@ -1596,19 +1601,20 @@ static int gnttab_expand(unsigned int req_entries) >  int gnttab_init(void) >  { >         int i; > -       unsigned long max_nr_grant_frames; > +       unsigned long max_nr_grant_frames, max_nr_grefs; >         unsigned int max_nr_glist_frames, nr_glist_frames; >         int ret; > >         gnttab_request_version(); >         max_nr_grant_frames = gnttab_max_grant_frames(); > +       max_nr_grefs = max_nr_grant_frames * > + gnttab_interface->grefs_per_grant_frame; >         nr_grant_frames = 1; > >         /* Determine the maximum number of frames required for the >          * grant reference free list on the current hypervisor. >          */ > -       max_nr_glist_frames = (max_nr_grant_frames * > - gnttab_interface->grefs_per_grant_frame / RPP); > +       max_nr_glist_frames = max_nr_grefs / RPP; > >         gnttab_list = kmalloc_array(max_nr_glist_frames, >                                     sizeof(grant_ref_t *), > @@ -1625,8 +1631,7 @@ int gnttab_init(void) >                 } >         } > > -       i = gnttab_interface->grefs_per_grant_frame * max_nr_grant_frames; > -       gnttab_free_bitmap = bitmap_zalloc(i, GFP_KERNEL); > +       gnttab_free_bitmap = bitmap_zalloc(max_nr_grefs, GFP_KERNEL); >         if (!gnttab_free_bitmap) { >                 ret = -ENOMEM; >                 goto ini_nomem; > Looks good, thanks. -boris From xen-devel-bounces@lists.xenproject.org Mon May 16 19:53:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 19:53:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330296.553666 (Exim 4.92) (envelope-from ) id 1nqgm4-0001Ao-Cc; Mon, 16 May 2022 19:53:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330296.553666; Mon, 16 May 2022 19:53:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgm4-0001Ah-9h; Mon, 16 May 2022 19:53:00 +0000 Received: by outflank-mailman (input) for mailman id 330296; Mon, 16 May 2022 19:52:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgm3-0001AX-6S; Mon, 16 May 2022 19:52:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgm2-0001We-QQ; Mon, 16 May 2022 19:52:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgm2-0002MC-Ao; Mon, 16 May 2022 19:52:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqgm2-00013d-AN; Mon, 16 May 2022 19:52:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hfZS1qJLf2V7MXFfhHp7uA400wf9tnFnp/y5NnY+mz0=; b=l+t+5TF9/MMRHabrVI4FrXci0a lXWy9MCnfyWqdnF4VzqkXJX5rvoGai2xqEh79VMftRD9uhRzv+ha1yhvOiINWmILOlAoYcqhWrt0s g6DrRY9greVVWkfa2VYnYfHiQ3aT1lYtR/Gb+gtkGJxNmaPsreONVZuuTraE6RdrKKn8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170478: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c X-Osstest-Versions-That: qemuu=48de9b0916ef60d5a6bd6ca9288832deff8ee1ee From: osstest service owner Date: Mon, 16 May 2022 19:52:58 +0000 flight 170478 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170478/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail in 170468 pass in 170478 test-amd64-i386-xl-xsm 7 xen-install fail in 170468 pass in 170478 test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 170468 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170412 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170412 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170412 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170412 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170412 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170412 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170412 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170412 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c baseline version: qemuu 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee Last test of basis 170412 2022-05-14 06:55:42 Z 2 days Testing same since 170468 2022-05-16 03:38:42 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jason A. Donenfeld Richard Henderson Stafford Horne jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 48de9b0916..10c2a0c5e7 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon May 16 19:59:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 19:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330307.553678 (Exim 4.92) (envelope-from ) id 1nqgsb-0001uu-7j; Mon, 16 May 2022 19:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330307.553678; Mon, 16 May 2022 19:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgsb-0001un-4Q; Mon, 16 May 2022 19:59:45 +0000 Received: by outflank-mailman (input) for mailman id 330307; Mon, 16 May 2022 19:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgsZ-0001ud-Ob; Mon, 16 May 2022 19:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgsZ-0001cn-KN; Mon, 16 May 2022 19:59:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqgsZ-0002VP-5z; Mon, 16 May 2022 19:59:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqgsZ-0003tG-5U; Mon, 16 May 2022 19:59:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YvRte/HGGPWFIS83sU9jo21Zl/N0TuM+v3OfdrmOgMc=; b=RiVVp304o7W7nV/dD+/Ll+En7B fAZvRZNcghpI2czQ9zCA7KLUX5SmxvmdXdG7wBMNgyoArn0y0epqw1rmDpKKK0kSVwDfDf4/flMgx HYE+sPzuiUlElzqQRPFAQS33ebA7DT2jWuvwcv+NNmRh6xl4GUPMfjwCO+n7XdCSbjaY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170488: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 19:59:43 +0000 flight 170488 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170488/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1049 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 68 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 21:11:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 21:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330317.553689 (Exim 4.92) (envelope-from ) id 1nqhzZ-0001hC-9d; Mon, 16 May 2022 21:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330317.553689; Mon, 16 May 2022 21:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqhzZ-0001h5-6E; Mon, 16 May 2022 21:11:01 +0000 Received: by outflank-mailman (input) for mailman id 330317; Mon, 16 May 2022 21:10:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqhzX-0001gv-Di; Mon, 16 May 2022 21:10:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqhzX-0002wS-A6; Mon, 16 May 2022 21:10:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqhzW-0004cf-UY; Mon, 16 May 2022 21:10:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqhzW-0005Fr-U6; Mon, 16 May 2022 21:10:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QSwnopqc7dY1KiTVF33z6RXK4dAufFSSRzK1DiyY8pk=; b=2xdPnWFcOKEfFdAIBxX09UrhZm tIRGlTGh0gFVPbS2ZLkT3udqxVowuoTCLQ79+7DyHF3uX2Mk+vTAzpSk3XIYHBqoLbSHltIAOPN6g bymuGgf1nxG4adwTCtmF3POAw+R7Y+cgbIdxlP//wrrs2glEiBiHW2RjhBdrqXDGy4kY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170490: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 21:10:58 +0000 flight 170490 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170490/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1050 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 69 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 16 22:02:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 22:02:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330327.553699 (Exim 4.92) (envelope-from ) id 1nqinU-0006hQ-9L; Mon, 16 May 2022 22:02:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330327.553699; Mon, 16 May 2022 22:02:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqinU-0006hJ-6H; Mon, 16 May 2022 22:02:36 +0000 Received: by outflank-mailman (input) for mailman id 330327; Mon, 16 May 2022 22:02:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqinT-0006h9-J3; Mon, 16 May 2022 22:02:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqinT-0003mk-Fs; Mon, 16 May 2022 22:02:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqinT-0007bq-6u; Mon, 16 May 2022 22:02:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqinT-0008RL-6T; Mon, 16 May 2022 22:02:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Oorf5YuTAQ8l0oJ1xQOgLJkiXrLb4H6X0ED4bLN6buI=; b=L4Lc9w+EtsfGXcRv6apjU6R2Ck GVKyufjpl1R9Ry04s5kDGphb8ecO3Y34vNaHyXbqrguPhovPJRus2jMy/OY8qsTKb2xlPg1WsFjnU ZkhWP/Uh3Q45hA/ZwiDX0kQPckcEC4PdsIWo1sb9zlmqwQvfnP4DJAegbsv/4nPzDVuo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170486: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Mon, 16 May 2022 22:02:35 +0000 flight 170486 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170486/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170364 2022-05-12 18:00:28 Z 4 days Testing same since 170486 2022-05-16 18:01:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Catalin Marinas Henry Wang Jiamei Xie Julien Grall Michal Orzel Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 207abdb38e..aa1cba100b aa1cba100bff84b211f27639bd6efeaf7e701bcc -> smoke From xen-devel-bounces@lists.xenproject.org Mon May 16 23:02:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 16 May 2022 23:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330362.553728 (Exim 4.92) (envelope-from ) id 1nqjiw-0005A9-AR; Mon, 16 May 2022 23:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330362.553728; Mon, 16 May 2022 23:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqjiw-0005A2-72; Mon, 16 May 2022 23:01:58 +0000 Received: by outflank-mailman (input) for mailman id 330362; Mon, 16 May 2022 23:01:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqjiu-00059i-4J; Mon, 16 May 2022 23:01:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqjiu-0004mE-2S; Mon, 16 May 2022 23:01:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqjit-0001Ya-Me; Mon, 16 May 2022 23:01:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqjit-00031a-MC; Mon, 16 May 2022 23:01:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sp0u5FIOQYW7496R2SYAObNCO81YVvO/CbCnvZ6E+80=; b=4eAFbI+uXVG8y6dqLY5bWwYiH+ HSl0AEdj7m9CKNBwFa9FK30sTG0Cbg0heTtCZKPcW+i0hD5Jlz0RzFubZP02DdWpVmAjBRkxoqW4Z qunRou5KdASW5eFExAQErUFWLYKE3UkBljkQKqzi3n46lhyDajIcg4gARp5mdKKDiQ44=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170491: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 16 May 2022 23:01:55 +0000 flight 170491 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170491/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1051 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 70 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 00:28:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 00:28:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330381.553740 (Exim 4.92) (envelope-from ) id 1nql49-0005A9-8y; Tue, 17 May 2022 00:27:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330381.553740; Tue, 17 May 2022 00:27:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql49-0005A2-4Z; Tue, 17 May 2022 00:27:57 +0000 Received: by outflank-mailman (input) for mailman id 330381; Tue, 17 May 2022 00:27:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql47-00059t-5w for xen-devel@lists.xenproject.org; Tue, 17 May 2022 00:27:55 +0000 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 306c9416-d578-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 02:27:53 +0200 (CEST) Received: by mail-oi1-f170.google.com with SMTP id r1so20631102oie.4 for ; Mon, 16 May 2022 17:27:53 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id t129-20020aca5f87000000b00328a1be5c3asm4429079oib.25.2022.05.16.17.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 17:27:51 -0700 (PDT) Received: (nullmailer pid 3649667 invoked by uid 1000); Tue, 17 May 2022 00:27:50 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 306c9416-d578-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AjIgoIzuU0qN1OneU4nydD9785iHKfz2mgfXgmyiwBA=; b=qaKOn0iA/kASTeiB0sky27ryW23xV0uhNiqCVy4inMw2NyRsmOd2qAsd+Vi8+eerjz Ll+pvf9ihWjP5lgVEH2zD0aaxWV/9kf+lSQSMqwkIuHN9tNZAK9KpMY7E9JKoCzOLIiV vDqp1hrs/PUkKZaDFXGeX1xxxTNBFh+P9S04+jIKcdnZjyAAEKhH1k9v+5hD8X8emMZe YeWx2CQpQ3wQWaUtihr+RsZ21uAZOrjqUYZd8IEMOXjNdci2bA0cMiJzpIZb1QqCKJXU KRvG3YtgrnNFEBQzvhVw1Ag06EpsUT8bXa/hkfJkgejo9KsJ7mbRw/zXInMDl+qWMYL2 A/WA== X-Gm-Message-State: AOAM532s6dhUG8LC1qc6kHFgG0zHAJ8Y3ak8lO8o1YVj7SbY3Ip5YUw3 PTSdhabjAtaPcYtAwgmmxw== X-Google-Smtp-Source: ABdhPJxT0vsAGu7gI2XEFSb7VXPXh7GjkIgGl9JGJgCiHApDSgmjmwIdM+VP2LsLjTK10XA7StATnw== X-Received: by 2002:a05:6808:1496:b0:326:e2de:63ec with SMTP id e22-20020a056808149600b00326e2de63ecmr9397520oiw.271.1652747272138; Mon, 16 May 2022 17:27:52 -0700 (PDT) Date: Mon, 16 May 2022 19:27:50 -0500 From: Rob Herring To: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220517002750.GA3638680-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1651947548-4055-6-git-send-email-olekstysh@gmail.com> On Sat, May 07, 2022 at 09:19:06PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Introduce Xen specific binding for the virtualized device (e.g. virtio) > to be used by Xen grant DMA-mapping layer in the subsequent commit. > > This binding indicates that Xen grant mappings scheme needs to be > enabled for the device which DT node contains that property and specifies > the ID of Xen domain where the corresponding backend resides. The ID > (domid) is used as an argument to the grant mapping APIs. > > This is needed for the option to restrict memory access using Xen grant > mappings to work which primary goal is to enable using virtio devices > in Xen guests. > > Signed-off-by: Oleksandr Tyshchenko > --- > Changes RFC -> V1: > - update commit subject/description and text in description > - move to devicetree/bindings/arm/ > > Changes V1 -> V2: > - update text in description > - change the maintainer of the binding > - fix validation issue > - reference xen,dev-domid.yaml schema from virtio/mmio.yaml > --- > .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ > Documentation/devicetree/bindings/virtio/mmio.yaml | 7 ++++ > 2 files changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > > diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > new file mode 100644 > index 00000000..750e89e > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xen specific binding for virtualized devices (e.g. virtio) > + > +maintainers: > + - Stefano Stabellini > + > +select: true Omit. No need to apply this on every single node. > + > +description: > + This binding indicates that Xen grant mappings need to be enabled for > + the device, and it specifies the ID of the domain where the corresponding > + device (backend) resides. The property is required to restrict memory > + access using Xen grant mappings. > + > +properties: > + xen,dev-domid: I kind of think 'dev' is redundant. Is there another kind of domid possible? Maybe xen,backend-domid or just xen,domid? I don't know Xen too well, so ultimately up to you all. > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The domid (domain ID) of the domain where the device (backend) is running. > + > +additionalProperties: true > + > +examples: > + - | > + virtio@3000 { > + compatible = "virtio,mmio"; > + reg = <0x3000 0x100>; > + interrupts = <41>; > + > + /* The device is located in Xen domain with ID 1 */ > + xen,dev-domid = <1>; > + }; > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > index 10c22b5..29a0932 100644 > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > @@ -13,6 +13,9 @@ description: > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > more details. > > +allOf: > + - $ref: /schemas/arm/xen,dev-domid.yaml# > + > properties: > compatible: > const: virtio,mmio > @@ -33,6 +36,10 @@ properties: > description: Required for devices making accesses thru an IOMMU. > maxItems: 1 > > + xen,dev-domid: > + description: Required when Xen grant mappings need to be enabled for device. > + $ref: /schemas/types.yaml#/definitions/uint32 No need to define the type again nor describe it again. Instead, just change additionalProperties to unevaluateProperties in this doc. The diff is the latter takes $ref's into account. > + > required: > - compatible > - reg > -- > 2.7.4 > > From xen-devel-bounces@lists.xenproject.org Tue May 17 00:31:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 00:31:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330389.553751 (Exim 4.92) (envelope-from ) id 1nql7o-0006bf-Ps; Tue, 17 May 2022 00:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330389.553751; Tue, 17 May 2022 00:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql7o-0006bX-Lo; Tue, 17 May 2022 00:31:44 +0000 Received: by outflank-mailman (input) for mailman id 330389; Tue, 17 May 2022 00:31:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql7n-0006bG-Bu; Tue, 17 May 2022 00:31:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql7n-00075j-9H; Tue, 17 May 2022 00:31:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nql7m-0006gb-TW; Tue, 17 May 2022 00:31:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nql7m-0005uI-T3; Tue, 17 May 2022 00:31:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=a54fRVquvXyvydCawwGxtEK9/ehvwBgDFfr3KC+jRrI=; b=6xPvKrkOIjdrR1dwh27f+UBtv+ O0+29gLSwqlqCINNPo0O4R4Hp39YDX+Z0hQx0192IEqhsFOedGbf+77znzsJHj0/6L6h0v5MS1x5d EDAjmtWyJ2C3x+EtgLKv7izNd7+VL2LOK4cdF7phFgvab20R3A/bHTBUBhGtpJJfgZ8A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170493: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 00:31:42 +0000 flight 170493 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170493/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1052 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 71 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 01:21:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 01:21:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330399.553762 (Exim 4.92) (envelope-from ) id 1nqluI-0001nY-Jk; Tue, 17 May 2022 01:21:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330399.553762; Tue, 17 May 2022 01:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqluI-0001nR-Ge; Tue, 17 May 2022 01:21:50 +0000 Received: by outflank-mailman (input) for mailman id 330399; Tue, 17 May 2022 01:21:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqluH-0001nL-65 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 01:21:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0d::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7fe3dd3-d57f-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 03:21:48 +0200 (CEST) Received: from AS8PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:20b:310::8) by PAXPR08MB6782.eurprd08.prod.outlook.com (2603:10a6:102:13a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 01:21:35 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::fc) by AS8PR04CA0003.outlook.office365.com (2603:10a6:20b:310::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Tue, 17 May 2022 01:21:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 01:21:34 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 17 May 2022 01:21:34 +0000 Received: from f0386a441de7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 587AA467-B163-43A3-99A6-46B48A56FC56.1; Tue, 17 May 2022 01:21:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f0386a441de7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 01:21:24 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM8PR08MB5604.eurprd08.prod.outlook.com (2603:10a6:20b:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 01:21:13 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5250.018; Tue, 17 May 2022 01:21:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7fe3dd3-d57f-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UU8zH8pGgToQMOhmcnHEXFXXdio1CRPxxpQnvL5PL59q03EUJ20VKP6AyV6j9ho1kRxVAcbrbS8BrX1Ohpes4sVtx+TdLYqwOk0beaC/23TBd1k8bn9U55IVRsJhSq8t/42ALz+/pqLWPGgvXO5i+5URdpINCGTpFPIsF/lMMB9IQamKq2gk53dsQkdqj/TTnw5Ctc5bMPMGo9h+fDMKiW3p4h4vK+WNf7KWSfAJ1RPfZCtQfYXpm3OvS9BW3jViiKRfwIb+odBfnV5Li6WhnG36Ghmlq8H+awfeJe2Yok0CtZDMmbYabUiYc3ynHxtYnUh2am4bnW3YXgB8ZiRNaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=d0LVoNNRmyefhdsqfQtTUju5Yl3V0YeJp2B+EeqRmDY36iBITNYpoQTA4h/kL+fptlsfWdHyO4hUk82Cy+nPKC1cwLrH7MtXfLbUlgJ4R3HK07ON3TX9k+vCzf/5eb7VC49nStBtoT6oKx5R41j+d51hvPeKkA5LkC8mCU14Wyadzj2UPlwe0NKTlvEFeaLVCTS4rlTCx+R7GJ6WLRAc1DOTvdd1sonEg/uYFOLG+XaskM6Ja4PGzeJ6Sgsf5nCl2JMCKrKlB9rbhpMp9J+pWgeOn4PwDgICQq14rqrksOxtAo6ny9kYKWArwKoqtYRnmBEp1xyPPb2vCooDTsFj2g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=6ncljqBS4xtxNrlpq0C/Em5TPeVhLmgDB/QZcH3hWsZfkw4Yjz92/8fDAXsH3QyEQHHjXzsgw+KbD09wDoovFO9kfl+pEDFPFxJZVcJIGsSzZXpGhQ4ro+WWjPL64/IvEDyAuZZz0nLUVe6wVO3GEcqs5D4/2OBhEOxsbMKSAzE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ery3EZ+yqjioBFdvvDrEAvORyyBEm2yrWqA9c6lMJRorjSSa7rr9gcs2V4okkB/6f43hnz/xu4tx3sO0xbNrqW5eaq4rtIkB+HGWFc6TfVrkMm8KAg6iYBw6GE2lRojM/XrEEUxdUHEza/jXuG7J8JX3hTHjgOPHKIxgmBeFhdMVqkrkv6sgPHprpcYsbpxGkNYq/Vl17Wd5e3SciKVELndejg1S2Y2q5xAJPrcC//iFLmLPFnipTmCAqzSsuZ4aBqL+PzDT6zYPc034aoB8SRXucI4pVnupcRK6mX6bcI4zMMlDymZtfZRisWk+8vpdiPMz9alZytH6qCx0QgKcJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=OnLvKox8vBvG6cBZ8AxTgoCczDMuqhnXXHmmIQwy4bRjNm8L4a4+zwJCppTrnGcYPqlQIhZqQ2aWcwu3CawlfGFmiUZNF+zC/CVAfDL1PLggrQAsRMNotk5A3NJZZEz1YnL8NTivlIS+YGgGMaOWtjdk5tti7adT00YRV56jTnFME6vIBUHUwWHjIrDdAp0ZZtDq/uJ9OPzryuYwFeYCZ+EfAydrH6sqE3gr0z624WagK4lbn6iq5r65iSNp0c+ZAEukEBBkBMg4D4mMBXpdgGjwTHCz3RdW29EzkOrDmqZJHppJhoxsAm17fRCbvaSnoDrQUMjPDUxjk7mNhA2VRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYAa+r5kvkSNTBeuANzUQ4D6YWZIXz9KN2uFTzia8hw=; b=6ncljqBS4xtxNrlpq0C/Em5TPeVhLmgDB/QZcH3hWsZfkw4Yjz92/8fDAXsH3QyEQHHjXzsgw+KbD09wDoovFO9kfl+pEDFPFxJZVcJIGsSzZXpGhQ4ro+WWjPL64/IvEDyAuZZz0nLUVe6wVO3GEcqs5D4/2OBhEOxsbMKSAzE= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie , Julien Grall Subject: RE: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart Thread-Topic: [PATCH v3 1/9] xen/arm: Print a 64-bit number in hex from early uart Thread-Index: AQHYZNkH8NyJIpE/PUu9tm96KkUvVa0hxzQAgACHh7A= Date: Tue, 17 May 2022 01:21:13 +0000 Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-2-wei.chen@arm.com> <46f6a909-2f77-021c-a069-6a8f827e53fc@xen.org> In-Reply-To: <46f6a909-2f77-021c-a069-6a8f827e53fc@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C3E6F517A834AF4DA8ED90DDBEE92748.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 42319104-0f55-4432-008b-08da37a39530 x-ms-traffictypediagnostic: AM8PR08MB5604:EE_|VE1EUR03FT045:EE_|PAXPR08MB6782:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4HIPGw9+Op3i8XaRtl5B3sdal1o6RbrY9TvzMg2JDikeAytOsa0L7562njkGUkJY0w89ko1o4Txnsgnv+Tkz/Hza0ojumtbxeMKoyoWXGQc1PwmWJc+kDLKkYmZZcQ8zWb4fD1ChjNGNw2arzLVS2qDe/+8Zi4YSqRWOKE58bbseFhWjAmT3dz7hHjcYtgihhzOgyZkD5PSHeF2+qn3nIisUSniHNVGLj4lc0Ak0beiQEgVaTpLdDlDEyfD8fOgj1+P/ANqOZjjKSeGU0xsh6HY94MaDDkZw5qlhZ7Kse3BkeEN1d7QCvdiN8PP9raGJJVWeAjvalo0Hma89RIQAvXgoN8uvagTfQbkpqwlyXymSTTY7xrSyuAAFGqVGFHVA0zb+eXZEVO6YmGL9PwBvEZFwXzerIkyKTpCUFxdCxPU2Yn7Ockfo/Bt8RE4Xyb3xjV4Lbg8Ycmm0D5aDoRq1q1HLPfFHf0RlsL4TD1UFQjMWJfzaq4fMvW8uuHsMZsRNUoIRbKuSmdC3jTzbsbp4vKcIgpuLvVJnB7+XcvGlgTmYrYWoOnLQnFCda9r/sP+kVDrb5qEifh+KpuzLZjghywWC5sjpnWttEeg1XuTVF/szNhoMHeUOznOn+mpxhfRxviD777VsNSAylRmtK1kSEFyT8T2szB+sKrP3Bd1gzWwp0mIdvgksdOkybIDKU7P4VVmt5aZi0DwA3T7F1kySWQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(33656002)(508600001)(110136005)(55016003)(71200400001)(4326008)(76116006)(64756008)(66556008)(66446008)(66946007)(54906003)(66476007)(2906002)(7696005)(6506007)(9686003)(8676002)(122000001)(86362001)(186003)(316002)(26005)(8936002)(83380400001)(5660300002)(38070700005)(38100700002)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5604 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 760de866-5b70-4e68-42b2-08da37a3887b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xrjH83oiEZ4KyUhhbMoyKs2Dw1WCBKC/a9Cl9dY/x9vvnL4SqtspojIIp+sVw+ge5JQgP2eZSenRoIzS55LoRD9COqVZi4oMC7C7fkvzo2XwQ24ZAbNFG5fVlAz3uhiHB4ypMdndX8UxOgv3Z70HXQdnuyJaFof2xBay1YUYYRNrfgUAe8C3xr7i7jCCsVUSk3OoNDffHdAl5iIzCHrm4cyakMG7LFQmjewPagXnewmODVKZOOwnLHg4zCab36mZdEwbvlUeZ7XUHmExzCxtNE91byz6M3tHsnUMRFog7LJ9pflrxU1SZIEzuv4a6SPWx6ZXeH0lBdyy+062es2ChtixxYlkxnThhIXxf34yempfg/9mSkpYKDDrth9LoLUVcqGXGU8Qg+EX/GSXyb2uOL18hjRZZdKOQt3GoHFHkApSNpVXTdlS1LinzdjYkCi2/gHPvSbZnPBmaKUn5raiDtEP5N3hOOXY4kVuN8aGHLfInSdNiDxvIrp0XZXP48z6mRkkbN+ZFZ/Ms106y9ZFzlvQ8K32jFqPoI2HIm7M6MyedbdjlxHggmA+F7tFV223WYzgG72B1qmqrRJ86Obw+Ew7bd7KftUSX4TVQwZGb8EIN4t4Ncb8Yb9zkG/pZDj7hGU103ol05L3WBBwoma4IbQMJ68AOPtP0nS5szn6MWh6t9ZeHZmoQdF9f2XhxYjk X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(110136005)(81166007)(8676002)(54906003)(186003)(4326008)(316002)(5660300002)(40460700003)(6506007)(33656002)(107886003)(53546011)(55016003)(26005)(70586007)(70206006)(2906002)(9686003)(52536014)(7696005)(8936002)(36860700001)(82310400005)(336012)(356005)(86362001)(83380400001)(47076005)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 01:21:34.7556 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42319104-0f55-4432-008b-08da37a39530 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6782 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQ15pyIMTfml6UgMToxNQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4gTWFycXVpcyA8QmVydHJhbmQuTWFycXVp c0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0u Y29tPjsgSmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPjsgSnVsaWVuDQo+IEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAxLzldIHhlbi9hcm06 IFByaW50IGEgNjQtYml0IG51bWJlciBpbiBoZXggZnJvbQ0KPiBlYXJseSB1YXJ0DQo+IA0KPiBI aSwNCj4gDQo+IE9uIDExLzA1LzIwMjIgMDI6NDYsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IEN1cnJl bnQgcHV0biBmdW5jdGlvbiB0aGF0IGlzIHVzaW5nIGZvciBlYXJseSBwcmludA0KPiA+IG9ubHkg Y2FuIHByaW50IGxvdyAzMi1iaXQgb2YgQUFyY2g2NCByZWdpc3Rlci4gVGhpcw0KPiA+IHdpbGwg bG9zZSBzb21lIGltcG9ydGFudCBtZXNzYWdlcyB3aGlsZSBkZWJ1Z2dpbmcNCj4gPiB3aXRoIGVh cmx5IGNvbnNvbGUuIEZvciBleGFtcGxlOg0KPiA+IChYRU4pIEJyaW5naW5nIHVwIENQVTUNCj4g PiAtIENQVSAwMDAwMDAwMTAwMDAwMTAwIGJvb3RpbmcgLQ0KPiA+IFdpbGwgYmUgdHJ1bmNhdGVk IHRvDQo+ID4gKFhFTikgQnJpbmdpbmcgdXAgQ1BVNQ0KPiA+IC0gQ1BVIDAwMDAwMTAwIGJvb3Rp bmcgLQ0KPiA+DQo+ID4gSW4gdGhpcyBwYXRjaCwgd2UgaW5jcmVhc2VkIHRoZSBwcmludCBsb29w cyBhbmQgc2hpZnQNCj4gPiBiaXRzIHRvIG1ha2UgcHV0biBwcmludCA2NC1iaXQgbnVtYmVyLg0K PiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVuQGFybS5jb20+DQo+ID4g VGVzdGVkLWJ5OiBKaWFtZWkgWGllIDxqaWFtZWkueGllQGFybS5jb20+DQo+ID4gQWNrZWQtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IA0KPiBJIGhhdmUgY29tbWl0dGVk IHRoaXMgcGF0Y2guDQo+IA0KPiBQYXRjaCAjMyBsb29rcyB0byBiZSBzdWl0YWJseSBhY2tlZCBi dXQgSSBhbSBub3Qgc3VyZSB3aGV0aGVyIGl0IGNhbiBiZQ0KPiBjb21taXR0ZWQgYmVmb3JlICMy LiBTbyBJIGRpZG4ndCBjb21taXQgaXQuDQo+IA0KDQpObywgaXQgZGVwZW5kcyBvbiBwYXRjaCMy IHRvIHByb3ZpZGUgRUZJIHN0dWJzIGZvciBBcm0zMiwgb3RoZXJ3aXNlDQpBcm0zMiB3aWxsIGJl IGZhaWxlZCBvbiBidWlsZGluZy4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiBQbGVhc2UgbGV0 IG1lIGtub3cgaWYgaXQgY2FuIGJlLg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVu IEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue May 17 01:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 01:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330408.553772 (Exim 4.92) (envelope-from ) id 1nqmGs-0004Hz-It; Tue, 17 May 2022 01:45:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330408.553772; Tue, 17 May 2022 01:45:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmGs-0004Hs-Ft; Tue, 17 May 2022 01:45:10 +0000 Received: by outflank-mailman (input) for mailman id 330408; Tue, 17 May 2022 01:45:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmGq-0004Hi-NO; Tue, 17 May 2022 01:45:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmGq-0006LR-Kq; Tue, 17 May 2022 01:45:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmGq-0003EC-9v; Tue, 17 May 2022 01:45:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqmGq-0003gB-9T; Tue, 17 May 2022 01:45:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kZEB5BmsGqaxZv6gLHsFk2uKoDLnZUhJ9fB0K5tRF+g=; b=N+GW4qsuUEKFwGgvMhvtJm3kBc rDAxEYnTLrVm8uZKhncGf52aLbflouKtfuzzThYaVvMiunVcd3BUC0WlAeFD3l/1uAu6m2Id1vh+4 gkJSML+R1Rn1H5op0BwhzPYVqH/NLwIy2NCPpxE/7FaXIChG84+hXDCAfHRnz3qVYXnk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170494: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 01:45:08 +0000 flight 170494 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170494/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 76 days 1053 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 72 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 02:27:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 02:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330418.553784 (Exim 4.92) (envelope-from ) id 1nqmvS-0000NP-Nw; Tue, 17 May 2022 02:27:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330418.553784; Tue, 17 May 2022 02:27:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmvS-0000NI-Kq; Tue, 17 May 2022 02:27:06 +0000 Received: by outflank-mailman (input) for mailman id 330418; Tue, 17 May 2022 02:27:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmvR-0000N8-CK; Tue, 17 May 2022 02:27:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmvR-0007W9-AR; Tue, 17 May 2022 02:27:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqmvQ-0005jv-UY; Tue, 17 May 2022 02:27:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqmvQ-0003wZ-U5; Tue, 17 May 2022 02:27:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=py3VjZu5InoFWxlbEPIfzlE9Vo1XgGBpQoiSsRSDcnc=; b=tCNhpFzcYV86b5ICYjglk9PrjM gTRP7ZsHKHtof9yxtSVRapqHFUnm2fzaLWIIKZHKHvtUt1iT8ALz8bfK0JdhS8zURQ8iYJdzsd7d8 CZ0fcdgrUYjDyxZ/3x+vINrSZI9KlfAnpLnJoGDUMnEsUv3A4Xl9LkBkGnBRiJMCo5fE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170495: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 02:27:04 +0000 flight 170495 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170495/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1054 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 73 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 03:29:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 03:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330428.553795 (Exim 4.92) (envelope-from ) id 1nqntc-0006MX-DY; Tue, 17 May 2022 03:29:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330428.553795; Tue, 17 May 2022 03:29:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqntc-0006MQ-AE; Tue, 17 May 2022 03:29:16 +0000 Received: by outflank-mailman (input) for mailman id 330428; Tue, 17 May 2022 03:29:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqnta-0006MG-7L; Tue, 17 May 2022 03:29:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqnta-00008O-2A; Tue, 17 May 2022 03:29:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqntZ-0000Kp-J7; Tue, 17 May 2022 03:29:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqntZ-00005y-Ic; Tue, 17 May 2022 03:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZMRDShy/4WqgvEGE3JzZUErEBjKFChG1T/6cnhl9r/w=; b=lHNUQBY9gqJepZ/fult3RwOFKQ qI3K6YTblXXwD7SCZuV0Io5CBA+8GWYa7IiF+H47KIZReWy/CAiUG8s1jGOSvfc0SqAb8lrqZ/JbX DLodzQ58Kb//MOpCYGdN98XrstwN+ttClLNEf4VYuv9OGpHcjx+o3xe/rNlnDQL6iBok=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170497: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 03:29:13 +0000 flight 170497 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170497/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1055 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 74 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 03:44:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 03:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330438.553806 (Exim 4.92) (envelope-from ) id 1nqo8A-0000Df-PV; Tue, 17 May 2022 03:44:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330438.553806; Tue, 17 May 2022 03:44:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqo8A-0000DY-ML; Tue, 17 May 2022 03:44:18 +0000 Received: by outflank-mailman (input) for mailman id 330438; Tue, 17 May 2022 03:44:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqo89-0000DO-Nv; Tue, 17 May 2022 03:44:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqo89-0000OU-I9; Tue, 17 May 2022 03:44:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqo89-0000yL-3B; Tue, 17 May 2022 03:44:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqo89-0003sq-2j; Tue, 17 May 2022 03:44:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gk0Vh52+72Rd1rDh0CJixL6AvJKpSZIZx3IjO6CFs30=; b=IfX3RaNp8EcadpQwRghpmncR2J m8Nlk8hWS3c6amQ9fn/40TN+SrJuG8Y7zGUSbpFkdsiZapCHDlUp+1NBICFnRKZ2XQ0w476pEHapb 518BB7nsQ3Dc7ZrsyX5YzmcKlz0eiBLIqab+RGQ2t9uuylzCI0jheG8x3sR7WphgGvJE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170489: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b935385c351d624993c4accd712cef8510658ecd X-Osstest-Versions-That: qemuu=10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c From: osstest service owner Date: Tue, 17 May 2022 03:44:17 +0000 flight 170489 qemu-mainline real [real] flight 170496 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170489/ http://logs.test-lab.xenproject.org/osstest/logs/170496/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 7 xen-install fail pass in 170496-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170478 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 170496 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170478 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170478 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170478 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170478 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170478 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170478 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170478 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170478 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu b935385c351d624993c4accd712cef8510658ecd baseline version: qemuu 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c Last test of basis 170478 2022-05-16 12:38:34 Z 0 days Testing same since 170489 2022-05-16 20:08:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Markus Armbruster Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 10c2a0c5e7..b935385c35 b935385c351d624993c4accd712cef8510658ecd -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 17 04:49:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 04:49:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330449.553816 (Exim 4.92) (envelope-from ) id 1nqp93-0006d0-SQ; Tue, 17 May 2022 04:49:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330449.553816; Tue, 17 May 2022 04:49:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqp93-0006ct-PK; Tue, 17 May 2022 04:49:17 +0000 Received: by outflank-mailman (input) for mailman id 330449; Tue, 17 May 2022 04:49:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqp92-0006cj-UR; Tue, 17 May 2022 04:49:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqp92-0001ed-Rw; Tue, 17 May 2022 04:49:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqp92-00038M-Cs; Tue, 17 May 2022 04:49:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqp92-0008Lu-CP; Tue, 17 May 2022 04:49:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LRGMr5F0w47Eul7yuJbeqFh5uLxjEy4I01LkLERnmfk=; b=MoR9AvoS3bn9JWrw7yRRRrQ0aZ 2+2xuILrjnWXAIbaUCt1YziIO0X3xxfgO+6Pm95J0MpTRnJfyusRWJZziv7rai1QWtjbUIPeRKLDn VI5X8YU3HH9yxV3IgqBgGTjTV67WNTkoovB+x+umJinPD6Fz3i0M2paQ2xpQsfuSt09U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170498: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 04:49:16 +0000 flight 170498 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170498/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1056 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 75 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 05:51:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 05:51:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330461.553828 (Exim 4.92) (envelope-from ) id 1nqq75-0005Ah-Ih; Tue, 17 May 2022 05:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330461.553828; Tue, 17 May 2022 05:51:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqq75-0005Aa-Fi; Tue, 17 May 2022 05:51:19 +0000 Received: by outflank-mailman (input) for mailman id 330461; Tue, 17 May 2022 05:51:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqq74-0005AU-1O for xen-devel@lists.xenproject.org; Tue, 17 May 2022 05:51:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060c.outbound.protection.outlook.com [2a01:111:f400:fe02::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cf1f39b-d5a5-11ec-837e-e5687231ffcc; Tue, 17 May 2022 07:51:15 +0200 (CEST) Received: from AS8PR04CA0178.eurprd04.prod.outlook.com (2603:10a6:20b:331::33) by DB8PR08MB5402.eurprd08.prod.outlook.com (2603:10a6:10:11b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 05:51:12 +0000 Received: from AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::ed) by AS8PR04CA0178.outlook.office365.com (2603:10a6:20b:331::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Tue, 17 May 2022 05:51:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT038.mail.protection.outlook.com (10.152.17.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 05:51:11 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 17 May 2022 05:51:10 +0000 Received: from 386d6afb0574.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6BC2BD0D-9782-4C3B-8CE7-24D863167F10.1; Tue, 17 May 2022 05:51:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 386d6afb0574.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 05:51:05 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5758.eurprd08.prod.outlook.com (2603:10a6:800:1a0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 05:51:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 05:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cf1f39b-d5a5-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jaLS7WgQZVLJOGrdb43ln/PIoCjxp7KkXAD9fJbMgg8Im6nJj3nzWDCLDubQr+MhNCcMuFiTwuPdrWv6c7NPlWPh7oj04OUV4NDtZV0RVWCI7pByBuf7Jvd+/mF+CQrSM22BD39nyP8GGDjqPvJQZRLfbO723nUiKRZ8oo4We1viOq7LPis1v1xawzsISKHOn6bkw+f2RBvhUm3TcdjGPQ20pMOVvJJ82gX9ukm98MZ1oT3tUG80KdL52mRVpAZ4axOiRVRsYdR5EWmm0K1IUV4HCFOK1RlNLqhsTEZJagVkvF+0pmN36un6SS2RqXECJ/6zqs1Z7SDU8XSR86hLFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rt3O8kinsp+nND0P0kmSdThiPFlBty7J0TAjOJJT5iA=; b=UfJo/5x2fZpTP8hNYHTrNnC+CmlZBudK3zCeK2T7uvItLQwmAGTCbp7QCI+IQROHhaqFeffBjZ2zsho8nkOuzNSfhB3s9bt2ZfBLlqtiWbmof6GMjsoNWgtw8PmFwo3/th6eNSeNNKIXosvSprkPQLZGTT0xL3m/bFFVDAUGefgF3hOyvSdbHBw3eSys7xyPBQ/8j5Fzd/nxmVpGyvb7stQGYQke09+fZlyUxxe8QK8ZCI4SUtn5NDPjMMxYF97BtGqfgT7QlrTihZkVAsxHzP41sGXy/ZwXalUFojIg5hi3eN94KRWizHk4i/zNwL1iu3bM6E646rpnidL93V4RTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rt3O8kinsp+nND0P0kmSdThiPFlBty7J0TAjOJJT5iA=; b=S+FSzx8uCOoVOyVWkd9fwtHhwOMbbbmU0FsAuKAXcgA1IP2fT5fZ/gfjNkHbW1L+N/OYqkbxSyagWI3TVbaSsauuSDLfpu32U1PburX6M7YvbasC9PnjQGnuZDs/L7xeLmknZ1HYdZl941C/JVBrTqorM1k0l9e+nR9oNf9+VuU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bKO7FAQWYWT5TAAbMxEj80hCImvXIKLIwPdF7DHcEn/j2NLerW3ukDWoJQ5QqwZd7Ely/g5Ox8gbsGOqm2M8GOlSmIE6KT+E4JVQvVeepP5ZT/1bhNz81gXNiBdLQQft8Zy0BExdpskdABah7NwKRLmZ8WLo/vhICrxZ3qfe4yMi1HzMsnJn8UuzNbHBCZFj9VOzmkELtz1pVwg5hVYaUio7YrG1+TPg9tUHjSNqIdqZ2OpDxxQ943z1alr7GgaJx2AXzv91GBYSOYiJ/Gjhw8I4mTWDEvwQs0ViJmjMOXcQO7RR+b6eM3gWXENAnkbghcd53ma9xTP2VvhJruaw8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rt3O8kinsp+nND0P0kmSdThiPFlBty7J0TAjOJJT5iA=; b=NN1MI8YWhzGNcLhATQIBFymT3XzwnRmMmBBCl5tySeynhELslqCGDKVDiSsHjLRAfwNAkIZ9LptbpCY9Pc+hLIfC5rXEw71s3lb+KGjYVbT6KmP+6qAXakG9g4sWlicvgA7aF98AHsBuBc5NcEpsQo6TAEjZrvB1kKk5MGiZ8iH2j1JuDnmNhaNWrj7X0cWJG6vESFwozAiiSXiSaluRn4GDHrfPIo3FZyor4PSFLUghL254YwTz7LnZUOMSKprbSNa3hJvDlmMNhlxCGhCZtdeYujucFL1BXtGlTJSoQUv3dytbKwbr7rgrdTc8oYqUgpB39vkv/rEWGG16nN+Qeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rt3O8kinsp+nND0P0kmSdThiPFlBty7J0TAjOJJT5iA=; b=S+FSzx8uCOoVOyVWkd9fwtHhwOMbbbmU0FsAuKAXcgA1IP2fT5fZ/gfjNkHbW1L+N/OYqkbxSyagWI3TVbaSsauuSDLfpu32U1PburX6M7YvbasC9PnjQGnuZDs/L7xeLmknZ1HYdZl941C/JVBrTqorM1k0l9e+nR9oNf9+VuU= From: Henry Wang To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" CC: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Kaly Xin , Jiamei Xie , =?utf-8?B?QWxleCBCZW5uw6ll?= Subject: RE: [PATCH V1] libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node Thread-Topic: [PATCH V1] libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node Thread-Index: AQHYZIMZsdRVC7TfqkSWxMHQ36uuy60ime0A Date: Tue, 17 May 2022 05:51:00 +0000 Message-ID: References: <1652196676-14745-1-git-send-email-olekstysh@gmail.com> In-Reply-To: <1652196676-14745-1-git-send-email-olekstysh@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: ADE2F1BC16BD9340B58BBE32E330CCA6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ef252c0c-929b-4451-82c9-08da37c93ef6 x-ms-traffictypediagnostic: VE1PR08MB5758:EE_|AM5EUR03FT038:EE_|DB8PR08MB5402:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vdxs4qOzVWAa37bYtEdnqDI8Zrkcuu5rGEzLqF3Rhtk/T+DWFmGaoKvwKo7vdrZ1b3aaZYrOSULn/emTfrb5cDrp24N30Jx1DjZ63Dn5USFcMKKt1G8avIwdPeF3aXd1u0M2qlr/n3ejltA8EF89t9DEB77bogdMDQsL8KO+5Af+HBc7lnPQ5xXwuv8Wnz1v5SAaTsXbLZqCpS/ZDUkHU5nzKmbUhJYKkHMEtlDFfEJ3CZ0Zru/WrZA+Z+pNKBRj8xeoAGNRj/+8BaysZr9Wa2rmiYmxnho4Dfzzzar6xJILj2yUL/y0qRNL5GbRBgNNyQw1v9O1ZiX07nuWHKa0wb5bObMLrDL527tXiMQvbFgWwvrFvh5l5e85y44dljBzdQDhv77HBdeVcDCLWQnXMWPDx88Sg6kDsclAair9qdcF2wVm1W/r/DtaqMBT/ciqGxhqx8oO+glSgDQsoKsSOh0SBO+O4gli/8m2jKFYW2emHVL9TZgyo9Ntb500MmaUaCyN7HGxtBdGRMtFwggLH7H/dPV7Kx1D2LROjVR+nP/rppT00nwiUa6gdwb4jBIRxQPHTpiYBUpszdB2ZLaNVcdIX6u/+CABxedRh6T5VIw31zzRhgMjmXTHop1xa4XZTDly9XUjidm1imD3V9gWlCDqLqt7YdAGTHYOnb4CkqCrtAFFNIDFcN75ap2bg1BG2HaAtD0APK1zdo5Ovfsdgg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(26005)(9686003)(71200400001)(64756008)(508600001)(52536014)(66476007)(54906003)(6506007)(86362001)(33656002)(38100700002)(4744005)(83380400001)(2906002)(7696005)(316002)(5660300002)(186003)(38070700005)(8936002)(66556008)(66946007)(66446008)(76116006)(110136005)(55016003)(8676002)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5758 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 50e575a5-ca08-4a2d-22ea-08da37c938c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rCTq2FoowktUgNzg66gn4hrawGLVIV8WtwClG3pJq7ieEjgfZSG2FaJfDo+W3aiQO9h2KMQY4V5Xzu+1dgLnV9hB7yDhp31hdYjlEW8yUAAltmSX9luedzqdag00X8FKrkMlFrKPhyV8cPqjsnTvu5IVvQHoNWXlVtfwonesHrZcOY/t95tidpImySCz/Cwitd6BfTiOAvWhedaQPKOhB/R+m8DEezrQV1QKlGG9noJLf7j1V+DV3at9gl/VING3p2KRGBe9XeDrX5XRVpSolAy4JmmHq6JWuQr+Wa2UkgtRaJTArIboRCAY+zjMsRhORDtfeSzJD4k2yq41sD3r9ZPfrnXvK49c9QleGSrc4hJZrem2xi0d4pa9jVTDznvum6whMH4Cbn4cG5h/r6NXa1Wn9988k5aGI7+KZM6mLTELdRJptl1b//lPMNteyhruPUtS6OK19Tv2O9qvwU8j+ctZKVcLJHcg+JcwoP2ygUjEu6bfxEJpjHUUVARc6LjGgDg/Qso7GpHaUFaXHufIhatHzYWCyjLyrc3Sn0aouf9SknEng033RfaflrZgcVf2scLYRZtyLBolInePLH1wpcUIr4HrbC9NoqWqHza5SqNKHt2s068h2t5UXXkvSXyG9mj3TtqiCzIzlVRejy9z13JwzbGcNjfTPN3nHW4t330O2bFxQVyYxwjZ10tR6uTB X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36860700001)(7696005)(26005)(107886003)(40460700003)(33656002)(6506007)(81166007)(47076005)(336012)(55016003)(4744005)(52536014)(8936002)(9686003)(82310400005)(54906003)(508600001)(86362001)(4326008)(70586007)(70206006)(8676002)(356005)(5660300002)(186003)(83380400001)(2906002)(316002)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 05:51:11.0174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef252c0c-929b-4451-82c9-08da37c93ef6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5402 SGkgT2xla3NhbmRyLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE9s ZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPg0KPiBTdWJqZWN0OiBbUEFU Q0ggVjFdIGxpYnhsL2FybTogSW5zZXJ0ICJ4ZW4sZGV2LWRvbWlkIiBwcm9wZXJ0eSB0byB2aXJ0 aW8tDQo+IG1taW8gZGV2aWNlIG5vZGUNCj4gDQo+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtv IDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4gDQo+IFVzZSBzcGVjaWZpYyBiaW5k aW5nIGZvciB0aGUgdmlydGlvIGRldmljZXMgZm9yIHdoaWNoIHRoZSByZXN0cmljdGVkDQo+IG1l bW9yeSBhY2Nlc3MgdXNpbmcgWGVuIGdyYW50IG1hcHBpbmdzIG5lZWQgdG8gYmUgZW5hYmxlZC4N Cj4gDQo+IEJhc2VkIG9uIGRldmljZS10cmVlIGJpbmRpbmcgZnJvbSBMaW51eDoNCj4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS94ZW4sZGV2LWRvbWlkLnlhbWwNCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5r b0BlcGFtLmNvbT4NCg0KVGhpcyBwYXRjaCBsb29rcyBnb29kIHRvIG1lLiBTbw0KUmV2aWV3ZWQt Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVu cnkNCg== From xen-devel-bounces@lists.xenproject.org Tue May 17 06:24:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 06:24:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330469.553839 (Exim 4.92) (envelope-from ) id 1nqqdL-0000Bq-5R; Tue, 17 May 2022 06:24:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330469.553839; Tue, 17 May 2022 06:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqdL-0000Bj-2W; Tue, 17 May 2022 06:24:39 +0000 Received: by outflank-mailman (input) for mailman id 330469; Tue, 17 May 2022 06:24:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqdJ-0000Bd-RG for xen-devel@lists.xenproject.org; Tue, 17 May 2022 06:24:37 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on062c.outbound.protection.outlook.com [2a01:111:f400:fe09::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 054602bf-d5aa-11ec-837e-e5687231ffcc; Tue, 17 May 2022 08:24:36 +0200 (CEST) Received: from DB6PR0202CA0007.eurprd02.prod.outlook.com (2603:10a6:4:29::17) by DB7PR08MB3692.eurprd08.prod.outlook.com (2603:10a6:10:30::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.15; Tue, 17 May 2022 06:24:31 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::c9) by DB6PR0202CA0007.outlook.office365.com (2603:10a6:4:29::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 17 May 2022 06:24:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 06:24:31 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Tue, 17 May 2022 06:24:31 +0000 Received: from 26aea624e4e9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E1847C6-51CB-4F24-81FB-5666D074887A.1; Tue, 17 May 2022 06:24:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26aea624e4e9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 06:24:20 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AS8PR08MB7250.eurprd08.prod.outlook.com (2603:10a6:20b:341::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 06:24:18 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5250.018; Tue, 17 May 2022 06:24:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 054602bf-d5aa-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d9xwTPFzPSjBozLaD4wfcBI1aCKqRm6YHvORToI11oxKv90OCgGUv6rawfO6oYG80xhfieGCpvWC2JPMT+4mwS1Cb+k7gqKrtIc4RehJgD8E9QtUFzQorKlMPxinUhJ4ZQ1x759oEBEo7iUmKgLuAi23JopiOdTevWtbe14lyqnOmeICywp0pKLwOB3FAdymN5+XQycXInqh85SCeB6SJ+b0GitJyf8EKGyXMV02QMIvyc5GSU3vtpE/C/enqrN2xxW2kZOdvg3bZJyBufyTsJbYykqhVONcD6r1k+yrFOchXwPvRHoJasBDONGU6/ORrHDicThniS/UVi75CdbJWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P+WogaoU5NMk4VzfTmoz6DN+xqWel39r/u7WQhU1jlc=; b=XaFj2WvtuWjBzdkeuh8yVkrjP8vmVd3uNs4LiUZZCmDwhLapL7lWgSFQVxr+4CXmcGQX4eMns7GZbjmxSNbG+zysIRWXBVR1o90qdTm0AzQV8Cfa3Ke5NkPvk6C5Vh8fseufhYfHytrNa1a2XlcItRtnb/k97GiZ7ZH3FYCskNEVhNhkdsA5ZIUDXNfep6QYkwkAIqpt7a9Uu4VPS8IkiM1QzkOBE0sULtE+tXDv32zIU3J9OhCX528VrfDcPPQ2wEsK/WcCBJWsRULw12T9tRw+m0a3jlfzKwKyQRPydX3Ohu35o+27yR1b2d/vhUB/dnzFRkfE53YMCQX3UQLwFg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+WogaoU5NMk4VzfTmoz6DN+xqWel39r/u7WQhU1jlc=; b=p2roUT8OG2gJQiIAuDqjAZBokxhqlZAWT11TURAbnOnvLZ6j8AEGBT+ojGTyLPthP2nojp/e43I/L2ZcZugdICakyFS734dn6/FYpN04aA06fPgXGASOocEMK+ynYAz1MA4TdbHtZjFEcDjKrV0efGvqvVAs7ore7kEaMq7wNqw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/V5LQuDz+VHz3va2wcq5Ua91tNkssFUmJdsCuF8gSOptxuRDQxQ2fBPxH/0FlZz4/ZnwDsEbnlSDt//iGhetot55MA9TfnlqkWLx6RLx/fSLkcUPBRxcT45mTttPrae6D4J+f2MppOCh2l+y6ncFpRIoTAtJjrXz23KzXlHdFVxroGVhqofu7rG4eHjIK4qxNW1cfI1tLNgim9/kX9e4ROmFD9u6uKcB0aMCS8DI7ftBJzcngQagn1cStCMPgNu7NqPmXBzKJNzT8RGHmp7jTDyjHKrk6RsKJe8egRDYtmNZ7xN/iouSOy91PpbLwRQAYnH01x/nGGT+cKxFa0gGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P+WogaoU5NMk4VzfTmoz6DN+xqWel39r/u7WQhU1jlc=; b=U/L5JieMDXyd/K5D9FMeeXj3MqBp1rlRA5sl5Xo2xf/e7y29yJdVVQMnfyWWL0WGKUtfx1ea85/kDJCgvzzVW9tzxmgT6DgATMc7Xry7yeVdX2GoHilj66ChFodiCOxs6z+pInjU6R4wW+C/Zepi5NV7pkVXt/4eDwJFjlfeq0BVxGZ8/eBzyEMhMEc5cJZ/mosW+DJIvhVR4J5IbPamVtFUg9cX3u85/uMLv3wx0/sH82uozSGWwSdOK/ApT2Mt3DX7HPI+wL4AyrBco5tCUqFxwcOjEdmnwOlJus4+sSz4ySVdu/G/q6THSvsu+MijGqnaBzqsmUAbKBW88MfukA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+WogaoU5NMk4VzfTmoz6DN+xqWel39r/u7WQhU1jlc=; b=p2roUT8OG2gJQiIAuDqjAZBokxhqlZAWT11TURAbnOnvLZ6j8AEGBT+ojGTyLPthP2nojp/e43I/L2ZcZugdICakyFS734dn6/FYpN04aA06fPgXGASOocEMK+ynYAz1MA4TdbHtZjFEcDjKrV0efGvqvVAs7ore7kEaMq7wNqw= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYZBWotDDYRSpFwES4i4qLUHUim60h3YOAgAC/qjA= Date: Tue, 17 May 2022 06:24:18 +0000 Message-ID: References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-7-Penny.Zheng@arm.com> <7af0d53c-6fdc-33a4-a09b-93831b4ee2c0@xen.org> In-Reply-To: <7af0d53c-6fdc-33a4-a09b-93831b4ee2c0@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 457513F8EB8C81489C2258EBBA384912.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: cbcf8663-1c99-44f7-fad7-08da37cde73d x-ms-traffictypediagnostic: AS8PR08MB7250:EE_|DBAEUR03FT053:EE_|DB7PR08MB3692:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3QEQ5Zm2s5UyPPqEko5RpNdwEuT4sP/34rcWA6l2P0TtUwh/tN1NDfg6wx+P+kOWPJ15exLEZobdnAQFUgzXGJ7ypas+IoBH8abBUdu0NXkrTBXC/V1GpWCrR8nEmmMiST0XSlBtaukUHjPnVdqVNa04bgfrOaTh6brLS5ThYqxb0YhX1Ir799gs8qlACegbVJeOxoNEepZZTpHqlPTmfCjZ0lpAswTsdcxfR54SsDUVill1rX+72YXXvx8sRemlMq0HpeDqV3XLBPXu6HxRoedR1dbvsf9GG5JiMjY1rDknk3hKY3ygLhojwcw28wXEaM0OSWfqPeBMaA1dKHPNYkFed7DwaTDZXfg2D0HEBSsBlazPjWYjYymkvyJijcqbcI6UdvGVxoM1Ka2Pc47/jihr1Ah6E72brpWqI6VkfOTN0Z1bf3VTt7gQV8jS0lSTYjnr7R/JOaJAt2D7Tgw3mYVRUp5OCuIuysLsO5MiR7cZjADqMmUOYxBsVTjvihUhkHYBq88Cjc6R3Cj+WEROjBXvz6Zgf0wW10w4yXSDUKCYso9V9WVpxsODXEujhf0Mf0djR62C00PeV/aL+3LZsYCgk5fN/5Y8ad7wEwJHD1JWaoLymS8dgPtJu0mGjyd07BRqbFuvuP92qPQ4vme2+qj/XgpEQzvkOOV99CUDzGTAWE8QVwQm5VyOde80nZ99ppeFpHmaGFQog/vMcxWcPsKKKiBtJCCq7PKZ+pQflzQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(7696005)(38070700005)(2906002)(33656002)(9686003)(26005)(71200400001)(52536014)(8936002)(508600001)(122000001)(316002)(66476007)(8676002)(83380400001)(64756008)(66556008)(55016003)(4326008)(86362001)(54906003)(66946007)(76116006)(38100700002)(66446008)(6506007)(53546011)(5660300002)(110136005)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7250 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d44094f-05fb-4343-6b68-08da37cddf6b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2zwj0bekRq3wI+LtpztxcC5tTVFL8vLiWSA0sQ13PPZM8ycv8KrEhVSpYVOTBhOSkL9ZxxkSYrl0ajtsunnbcCMg0DW/1dCH4KQfjsAEhjC1BdOO9gTwYKfvOR1hjrtxcG51pNdUGBBTTKIjlid18jKx4iXs824ldntleBrxxpCd3T0X00kuRifHgSBsdJDv1MfqAckfQntpxjQ54WsgeV6h+a8Yu1IT/uAvKV0zcf0b+mR8gJONXKcH939RDTeD7GHCGAU9U3LPZpFxAJZdfg5UssGZEWV5sYHVDokihGu4jv0PnH9FCcaWqlVlkmO47Cx3Z6uBpwPzBpkP4dKnVirLMqXJ3vAw7Ml9Vc0n+4AoLqjotYGGfOeNXkur9VcWBbhgtjy3UyjRmUZQpajRpjB55On2z9b79MiFILqArCsJrF3jW/aDyEPT7d0cLhD1IEcshjfcw75GGu8ORCNVq7T8S9q2VCTfeiBm+br17dOhJq6lTzjq7+52dbfXiMaXgg2aOYuWTvwtTy6YC3c8r+wYG3RW7mBqfyur/JNHH+efMMkHJZAhQN+IbSc/WnAGCuhnNjySk/RryGEiXWLCfYWyuflleeWwZFmcj1pU0ZthyIri6mj2bwrnBJqBi5BPkYVjqqVyBupqo88WqZ2UNIIbRYNGwMCzgALYEYvuKKApZQBVZ1WtbjA+qhnaJ7MmEThdPp5sOibI8gysdeY+dQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(8936002)(33656002)(316002)(186003)(5660300002)(86362001)(40460700003)(55016003)(9686003)(53546011)(508600001)(54906003)(2906002)(47076005)(336012)(83380400001)(8676002)(4326008)(70586007)(70206006)(356005)(82310400005)(26005)(110136005)(6506007)(52536014)(7696005)(81166007)(36860700001)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 06:24:31.3768 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbcf8663-1c99-44f7-fad7-08da37cde73d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3692 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVHVlc2RheSwgTWF5IDE3LCAyMDIyIDI6 MjkgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47 IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Ow0KPiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ow0K PiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0IDYvNl0geGVu OiByZXRyaWV2ZSByZXNlcnZlZCBwYWdlcyBvbiBwb3B1bGF0ZV9waHlzbWFwDQo+IA0KPiBIaSBQ ZW5ueSwNCj4gDQo+IE9uIDEwLzA1LzIwMjIgMDM6MjcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+ IFdoZW4gc3RhdGljIGRvbWFpbiBwb3B1bGF0ZXMgbWVtb3J5IHRocm91Z2ggcG9wdWxhdGVfcGh5 c21hcCBvbg0KPiA+IHJ1bnRpbWUsDQo+IA0KPiBUeXBvOiBzL3doZW4gc3RhdGljL3doZW4gYSBz dGF0aWMvIG9yICJ3aGVuIHN0YXRpYyBkb21haW5zIHBvcHVsYXRlIg0KPiANCj4gcy9vbiBydW50 aW1lL2F0IHJ1bnRpbWUvDQo+IA0KDQpTdXJlLCANCg0KPiA+IG90aGVyIHRoYW4gYWxsb2NhdGlu ZyBmcm9tIGhlYXAsIGl0IHNoYWxsIHJldHJpZXZlIHJlc2VydmVkIHBhZ2VzIGZyb20NCj4gDQo+ IEkgYW0gbm90IHN1cmUgdG8gdW5kZXJzdGFuZCB0aGUgcGFydCBiZWZvcmUgdGhlIGNvbW1hLiBC dXQgaXQgZG9lbnMndCBzb3VuZA0KPiBuZWNlc3Nhcnkgc28gbWF5YmUgZHJvcCBpdD8NCj4gIA0K DQpTdXJlLA0KDQo+ID4gcmVzdl9wYWdlX2xpc3QgdG8gbWFrZSBzdXJlIHRoYXQgZ3Vlc3QgUkFN IGlzIHN0aWxsIHJlc3RyaWN0ZWQgaW4NCj4gPiBzdGF0aWNhbGx5IGNvbmZpZ3VyZWQgbWVtb3J5 IHJlZ2lvbnMuIEFuZCB0aGlzIGNvbW1pdCBpbnRyb2R1Y2VzIGEgbmV3DQo+ID4gaGVscGVyIGFj cXVpcmVfcmVzZXJ2ZWRfcGFnZSB0byBtYWtlIGl0IHdvcmsuDQo+ID4NCj4gPiBTaWduZWQtb2Zm LWJ5OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gDQo+IFsuLi5dDQo+IA0K PiA+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYyBiL3hlbi9jb21tb24vcGFn ZV9hbGxvYy5jIGluZGV4DQo+ID4gMjkwNTI2YWRhZi4uMDZlNzAzN2EyOCAxMDA2NDQNCj4gPiAt LS0gYS94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+ICsrKyBiL3hlbi9jb21tb24vcGFnZV9h bGxvYy5jDQo+ID4gQEAgLTI3NDAsOCArMjc0MCw4IEBAIHN0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZv ICogX19pbml0DQo+IGFjcXVpcmVfc3RhdGljbWVtX3BhZ2VzKG1mbl90IHNtZm4sDQo+ID4gICAg KiBBY3F1aXJlIG5yX21mbnMgY29udGlndW91cyBwYWdlcywgc3RhcnRpbmcgYXQgI3NtZm4sIG9m IHN0YXRpYyBtZW1vcnksDQo+ID4gICAgKiB0aGVuIGFzc2lnbiB0aGVtIHRvIG9uZSBzcGVjaWZp YyBkb21haW4gI2QuDQo+ID4gICAgKi8NCj4gPiAtaW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRp Y19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBzbWZuLA0KPiA+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBucl9tZm5zLCB1bnNpZ25lZCBpbnQg bWVtZmxhZ3MpDQo+ID4gK2ludCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWlu ICpkLCBtZm5fdCBzbWZuLCB1bnNpZ25lZCBpbnQNCj4gbnJfbWZucywNCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBtZW1mbGFncykNCj4gPiAgIHsNCj4gPiAg ICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsNCj4gPg0KPiA+IEBAIC0yNzY5LDEyICsyNzY5LDQz IEBAIGludCBfX2luaXQgYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoc3RydWN0DQo+ID4gZG9tYWlu ICpkLCBtZm5fdCBzbWZuLA0KPiA+DQo+ID4gICAgICAgcmV0dXJuIDA7DQo+ID4gICB9DQo+ID4g Kw0KPiA+ICsvKg0KPiA+ICsgKiBBY3F1aXJlIGEgcGFnZSBmcm9tIHJlc2VydmVkIHBhZ2UgbGlz dChyZXN2X3BhZ2VfbGlzdCksIHdoZW4NCj4gPiArcG9wdWxhdGluZw0KPiA+ICsgKiBtZW1vcnkg Zm9yIHN0YXRpYyBkb21haW4gb24gcnVudGltZS4NCj4gPiArICovDQo+ID4gK21mbl90IGFjcXVp cmVfcmVzZXJ2ZWRfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbWVtZmxhZ3Mp DQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBwYWdlX2luZm8gKnBhZ2U7DQo+ID4gKyAgICBtZm5f dCBzbWZuOw0KPiA+ICsNCj4gPiArICAgIC8qIEFjcXVpcmUgYSBwYWdlIGZyb20gcmVzZXJ2ZWQg cGFnZSBsaXN0KHJlc3ZfcGFnZV9saXN0KS4gKi8NCj4gPiArICAgIHBhZ2UgPSBwYWdlX2xpc3Rf cmVtb3ZlX2hlYWQoJmQtPnJlc3ZfcGFnZV9saXN0KTsNCj4gQWxsb2MvZnJlZSBvZiBtZW1vcnkg Y2FuIGhhcHBlbiBjb25jdXJyZW50bHkuIFNvIGFjY2VzcyB0byByc3ZfcGFnZV9saXN0DQo+IG5l ZWRzIHRvIGJlIHByb3RlY3RlZCB3aXRoIGEgc3BpbmxvY2sgKG1vc3RseSBsaWtlIGQtPnBhZ2Vf YWxsb2NfbG9jaykuDQo+DQoNCk9oLCB1bmRlcnN0b29kLCB3aWxsIGZpeC4NCiANCj4gPiArICAg IGlmICggdW5saWtlbHkoIXBhZ2UpICkNCj4gPiArICAgICAgICByZXR1cm4gSU5WQUxJRF9NRk47 DQo+ID4gKw0KPiA+ICsgICAgc21mbiA9IHBhZ2VfdG9fbWZuKHBhZ2UpOw0KPiA+ICsNCj4gPiAr ICAgIGlmICggYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoZCwgc21mbiwgMSwgbWVtZmxhZ3MpICkN Cj4gDQo+IEkgYW0gT0sgaWYgd2UgY2FsbCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcygpIGZvciBu b3cuIEJ1dCBsb25nIHRlcm0sIEkgdGhpbmsgd2UNCj4gc2hvdWxkIGNvbnNpZGVyIHRvIG9wdGlt aXplIGl0IGJlY2F1c2Ugd2Uga25vdyB0aGUgcGFnZSBpcyB2YWxpZCBhbmQgYmVsb25nDQo+IHRv IHRoZSBndWVzdC4gU28gdGhlcmUgYXJlIGEgbG90IG9mIHBvaW50bGVzcyB3b3JrIChjaGVja2lu ZyBtZm5fdmFsaWQoKSwNCj4gc2NydWJiaW5nIGluIHRoZSBmcmVlIHBhcnQsIGNsZWFuaW5nIHRo ZSBjYWNoZS4uLikuDQo+IA0KDQpJJ20gd2lsbGluZyB0byBmaXggaXQgaGVyZSBzaW5jZSB0aGlz IGZpeCBpcyBub3QgYmxvY2tpbmcgYW55IG90aGVyIHBhdGNoIHNlcmllfn4NCkknbSBjb25zaWRl cmluZyB0aGF0IG1heWJlIHdlIGNvdWxkIGFkZCBhIG5ldyBtZW1mbGFnIE1FTUZfeHh4LCAob2gs DQpOYW1pbmcgc29tZXRoaW5nIGlzIHJlYWxseSAia2lsbGluZyIgbWUpLCB0aGVuIGFsbCB0aGVz ZSBwb2ludGxlc3Mgd29yaywgY2hlY2tpbmcNCm1mbl92YWxpZCwgZmx1c2hpbmcgVExCIGFuZCBj YWNoZSwgd2UgY291bGQgZXhjbHVkZSB0aGVtIGJ5IGNoZWNraW5nDQptZW1mbGFncyAmIE1FTUZf eHh4eC4NCldkeXQ/DQoNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwYWdlX2xpc3RfYWRkX3Rh aWwocGFnZSwgJmQtPnJlc3ZfcGFnZV9saXN0KTsNCj4gPiArICAgICAgICByZXR1cm4gSU5WQUxJ RF9NRk47DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIHNtZm47DQo+ID4gK30N Cj4gPiAgICNlbHNlDQo+ID4gICB2b2lkIGZyZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdl X2luZm8gKnBnLCB1bnNpZ25lZCBsb25nIG5yX21mbnMsDQo+ID4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgbmVlZF9zY3J1YikNCj4gPiAgIHsNCj4gPiAgICAgICBBU1NFUlRfVU5S RUFDSEFCTEUoKTsNCj4gPiAgIH0NCj4gPiArDQo+ID4gK21mbl90IGFjcXVpcmVfcmVzZXJ2ZWRf cGFnZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbWVtZmxhZ3MpDQo+ID4gK3sNCj4g PiArICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPiA+ICsgICAgcmV0dXJuIElOVkFMSURfTUZO Ow0KPiA+ICt9DQo+ID4gICAjZW5kaWYNCj4gPg0KPiA+ICAgLyoNCj4gPiBkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oIGIveGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oIGluZGV4 DQo+ID4gMzVkYzcxNDNhNC4uYzYxM2FmYTU3ZSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vaW5jbHVk ZS94ZW4vZG9tYWluLmgNCj4gPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vZG9tYWluLmgNCj4gPiBA QCAtMzgsNiArMzgsMTAgQEAgdm9pZCBhcmNoX2dldF9kb21haW5faW5mbyhjb25zdCBzdHJ1Y3Qg ZG9tYWluICpkLA0KPiA+ICAgI2RlZmluZSBDREZfc3RhdGljbWVtICAgICAgICAgICAgKDFVIDw8 IDIpDQo+ID4gICAjZW5kaWYNCj4gPg0KPiA+ICsjaWZuZGVmIGlzX2RvbWFpbl91c2luZ19zdGF0 aWNtZW0NCj4gPiArI2RlZmluZSBpc19kb21haW5fdXNpbmdfc3RhdGljbWVtKGQpICgodm9pZCko ZCksIGZhbHNlKSAjZW5kaWYNCj4gPiArDQo+ID4gICAvKg0KPiA+ICAgICogQXJjaC1zcGVjaWZp Y3MuDQo+ID4gICAgKi8NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL21tLmggYi94 ZW4vaW5jbHVkZS94ZW4vbW0uaCBpbmRleA0KPiA+IDlmZDk1ZGVhZWMuLjc0ODEwZTFmNTQgMTAw NjQ0DQo+ID4gLS0tIGEveGVuL2luY2x1ZGUveGVuL21tLmgNCj4gPiArKysgYi94ZW4vaW5jbHVk ZS94ZW4vbW0uaA0KPiA+IEBAIC05Miw2ICs5Miw3IEBAIHZvaWQgZnJlZV9zdGF0aWNtZW1fcGFn ZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsDQo+IHVuc2lnbmVkIGxvbmcgbnJfbWZucywNCj4gPiAg IGludCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBzbWZu LCB1bnNpZ25lZCBpbnQNCj4gbnJfbWZucywNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgbWVtZmxhZ3MpOw0KPiA+ICAgI2VuZGlmDQo+ID4gK21mbl90IGFj cXVpcmVfcmVzZXJ2ZWRfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgbWVtZmxh Z3MpOw0KPiA+DQo+ID4gICAvKiBNYXAgbWFjaGluZSBwYWdlIHJhbmdlIGluIFhlbiB2aXJ0dWFs IGFkZHJlc3Mgc3BhY2UuICovDQo+ID4gICBpbnQgbWFwX3BhZ2VzX3RvX3hlbigNCj4gDQo+IENo ZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue May 17 06:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 06:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330478.553850 (Exim 4.92) (envelope-from ) id 1nqqu9-0002as-PH; Tue, 17 May 2022 06:42:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330478.553850; Tue, 17 May 2022 06:42:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqu9-0002al-LH; Tue, 17 May 2022 06:42:01 +0000 Received: by outflank-mailman (input) for mailman id 330478; Tue, 17 May 2022 06:42:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqu8-0002ab-N8; Tue, 17 May 2022 06:42:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqu8-0003tz-J0; Tue, 17 May 2022 06:42:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqu8-0000iw-2G; Tue, 17 May 2022 06:42:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqqu8-0005jL-1n; Tue, 17 May 2022 06:42:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jLBmT+UeQhWYrq/b/CJvqxCFlcxEoBIQEUlxgTfVNI0=; b=XKLAR6f/IQRJ8aBfwiR6nLUrLS /4TZ2ieGZxYU/MESn6kMDN9C7nylNfmN7Sa+iiuEMUebxtD5lrrC1Du+ZbJw5PuKLrvmxGSgfo2+0 agtNM26hLsju8FfCrW6Zz6KocJ9nQJf66ygii/cdbF8UNQ+p9QlKWh7YlC8GcdnMq7/Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170492: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc X-Osstest-Versions-That: xen=207abdb38ee987e99385263e3e56b6c500d74cbc From: osstest service owner Date: Tue, 17 May 2022 06:42:00 +0000 flight 170492 xen-unstable real [real] flight 170502 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170492/ http://logs.test-lab.xenproject.org/osstest/logs/170502/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 170502-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170434 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170465 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170465 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170465 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170465 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170465 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170465 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170465 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170465 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170465 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170465 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170465 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail like 170465 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc baseline version: xen 207abdb38ee987e99385263e3e56b6c500d74cbc Last test of basis 170465 2022-05-16 01:53:04 Z 1 days Testing same since 170492 2022-05-16 22:08:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Catalin Marinas Henry Wang Jiamei Xie Julien Grall Michal Orzel Wei Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 207abdb38e..aa1cba100b aa1cba100bff84b211f27639bd6efeaf7e701bcc -> master From xen-devel-bounces@lists.xenproject.org Tue May 17 06:47:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 06:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330492.553877 (Exim 4.92) (envelope-from ) id 1nqqzT-0003TS-Jp; Tue, 17 May 2022 06:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330492.553877; Tue, 17 May 2022 06:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqzT-0003TL-GY; Tue, 17 May 2022 06:47:31 +0000 Received: by outflank-mailman (input) for mailman id 330492; Tue, 17 May 2022 06:47:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqqzS-0003TF-2B for xen-devel@lists.xenproject.org; Tue, 17 May 2022 06:47:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 37bebdff-d5ad-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 08:47:28 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6AD61063; Mon, 16 May 2022 23:47:27 -0700 (PDT) Received: from [10.57.3.238] (unknown [10.57.3.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EE7E3F718; Mon, 16 May 2022 23:47:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37bebdff-d5ad-11ec-bd2c-47488cf2e6aa Message-ID: <789c1899-7444-2e29-dfea-58c9fa446a8e@arm.com> Date: Tue, 17 May 2022 08:47:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220516170246.19908-1-julien@xen.org> From: Michal Orzel In-Reply-To: <20220516170246.19908-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 16.05.2022 19:02, Julien Grall wrote: > +static int cpu_callback(struct notifier_block *nfb, unsigned long action, > + void *hcpu) > +{ > + unsigned long cpu = (unsigned long)hcpu; As cpu does not change in this function, shouldn't we mark it as const? > + int rc = 0; > + > + switch ( action ) > + { > + case CPU_UP_PREPARE: > + rc = gicv3_lpi_allocate_pendtable(cpu); > + if ( rc ) > + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", %u requires unsigned int but cpu is unsigned long. FWICS this will cause a compilation error, so you should change to %lu. > + cpu); > + break; > } > > - return gicv3_lpi_set_proptable(rdist_base); > + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); > } > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 17 07:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 07:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330504.553888 (Exim 4.92) (envelope-from ) id 1nqrFa-0005xh-4e; Tue, 17 May 2022 07:04:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330504.553888; Tue, 17 May 2022 07:04:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrFa-0005xa-0m; Tue, 17 May 2022 07:04:10 +0000 Received: by outflank-mailman (input) for mailman id 330504; Tue, 17 May 2022 07:04:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrFX-0005xQ-Rx; Tue, 17 May 2022 07:04:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrFX-0004Ic-QA; Tue, 17 May 2022 07:04:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrFX-0001pK-DV; Tue, 17 May 2022 07:04:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqrFX-0000gI-D2; Tue, 17 May 2022 07:04:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4pt1PRJaHZlwbdc8h47mGees3Qo8ufC3Of0PGrDFOSA=; b=xfvhj4Hpzrwxw/0WURKGZz8/Lh vsq5jtwbItlIh4WlOGbfYabTYcZCKHBIu2dnCJ77C/uvFotirtPb+pbJbusnNhhHsPp/1eZx0q/fp hE0DUK0JkHDwigbAQbA3RE6ikaKpufwox7EjEpBRJbMGFnH4MgLRkbHcmu3etxFKdOI4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170501: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 07:04:07 +0000 flight 170501 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170501/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1057 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 76 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 07:14:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 07:14:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330515.553899 (Exim 4.92) (envelope-from ) id 1nqrPY-0007Us-89; Tue, 17 May 2022 07:14:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330515.553899; Tue, 17 May 2022 07:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrPY-0007Ul-5G; Tue, 17 May 2022 07:14:28 +0000 Received: by outflank-mailman (input) for mailman id 330515; Tue, 17 May 2022 07:14:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqrPX-0007Uf-0Z for xen-devel@lists.xenproject.org; Tue, 17 May 2022 07:14:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id fb0ed061-d5b0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 09:14:25 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1FF241063; Tue, 17 May 2022 00:14:24 -0700 (PDT) Received: from [10.57.3.238] (unknown [10.57.3.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 988D23F718; Tue, 17 May 2022 00:14:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb0ed061-d5b0-11ec-837e-e5687231ffcc Message-ID: <9eb95e25-1a19-4048-259f-dc2dbee6cac7@arm.com> Date: Tue, 17 May 2022 09:14:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-3-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 16.05.2022 12:19, Julien Grall wrote: > Hi Michal, > > On 06/05/2022 10:42, Michal Orzel wrote: >> Modify macros to evaluate all the arguments and make sure the arguments >> are evaluated only once. Introduce following intermediate macros: >> gnttab_status_gfn_, gnttab_shared_gfn_ that do not take domain as a >> parameter. These are to be used locally and allow us to avoid passing >> NULL from gnttab_get_frame_gfn to the respective macros (without _ suffix). >> Make use of a domain parameter from gnttab_shared_gfn and gnttab_status_gfn >> by adding an ASSERT. >> >> Signed-off-by: Michal Orzel > > Most of the helpers below are going to disappear with Oleksandr latest work (see [1]). > > Looking at Oleksandr's patch, I think only gnttab_set_frame_gfn() would end up to use one of the macro parameters twice. So I would like to suggest to chat with Oleksandr if we can tweak his patch (can be done on commit) or we rebase this patch on top of his work. > > Cheers, > > [1] https://lore.kernel.org/xen-devel/1652294845-13980-1-git-send-email-olekstysh@gmail.com/ > By looking at Oleksandr patch: 1. there are 2 macros: gnttab_set_frame_gfn, gnttab_need_iommu_mapping that use one of the macro parameters twice. 2. gnttab_get_frame_gfn still passes NULL as a domain parameter to gnttab_shared_gfn/gnttab_status_gfn that do not evaluate domain parameter I agree that point 1 could be fixed on commit but point 2 requires in my opinion adding intermediate macros to avoid passing NULL (just like I did). As this would require more work from Oleksandr, I'm ok to rebase my patch on top of his work once merged. Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 17 08:22:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:22:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330532.553909 (Exim 4.92) (envelope-from ) id 1nqsSg-0006P3-KC; Tue, 17 May 2022 08:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330532.553909; Tue, 17 May 2022 08:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsSg-0006Ow-HW; Tue, 17 May 2022 08:21:46 +0000 Received: by outflank-mailman (input) for mailman id 330532; Tue, 17 May 2022 08:21:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsSe-0006Oq-PF for xen-devel@lists.xenproject.org; Tue, 17 May 2022 08:21:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0c::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62331ff0-d5ba-11ec-837e-e5687231ffcc; Tue, 17 May 2022 10:21:43 +0200 (CEST) Received: from AS9PR06CA0508.eurprd06.prod.outlook.com (2603:10a6:20b:49b::32) by VI1PR0801MB1853.eurprd08.prod.outlook.com (2603:10a6:800:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Tue, 17 May 2022 08:21:40 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::fe) by AS9PR06CA0508.outlook.office365.com (2603:10a6:20b:49b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 17 May 2022 08:21:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 08:21:39 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 17 May 2022 08:21:38 +0000 Received: from 0dc7c8015edf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3A555B08-BF10-4E2D-B9F3-30DD2C8C5CA9.1; Tue, 17 May 2022 08:21:33 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0dc7c8015edf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 08:21:33 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by DB9PR08MB6475.eurprd08.prod.outlook.com (2603:10a6:10:253::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 08:21:31 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5250.018; Tue, 17 May 2022 08:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62331ff0-d5ba-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KhiIiRC9JdgKClaYd0Fvy1r+0PeJgwpa4Vc9h3aQo1GuS/6AhxAPekM8P4IvnfcdpsxyL6EBzrtCVaS+Ku+82EiATrRE4tXH5NSVsLH16VftKUh94Bzs1cEMMgiW0IhL6R56poDPpCqg1n4mVKgUcDXq05OpG/3hlECrSNV0u7Tykz9Eqa++g07uTaECx/TFYME/4zyqIJ6491S/gkJruAWvfD8MVAd80N2uFKJhYIDdJ+AxxBd9tyG2GGcVAOjIKGiHTkz0f8bG2i0vo25K/IEPwJ8QhCMx+fJVe0/gGF4ff8rp+g9looAFlf1sLB6f1OeWlyd3aVKNWBEUMISZKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38WAE1NxB8vuKcm9HzSrl5k1VF7Kujxlni79VItedlU=; b=Vbp22UUBcsSiaS0qw+SM4ygGOVQA3TQfTj89JoJizohNZDwRidq7p9Ro4a7nbuv3tz9uxj7+S3oWolE8QbSd0zqRnrPTbqXKFjNrNTaF4SFTOjCMYNiBceZyLYrfxPUerSdQjgy3VMhPsnC1HIp/lHCpgyDN2ysGxDxKnFLUTdyht2+vZV18tGw95rbNxRaeXqCQfOUqsfFcJDvCPln8tK7l7+ItII4lfT/+fMKRnpUcbAVUel3mI/369fCMmhtBRj9+6tAIsZdocwnoEWQNtRHlyTLRROqgd9Xbe11Kkcb2n4wYkkiUxDu1DpUjaLuSmOAD8STE4kVoVoCREtO7IA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38WAE1NxB8vuKcm9HzSrl5k1VF7Kujxlni79VItedlU=; b=uLZELQCnTXQN+XaTnDBDTNrI6K2hD+PfIPnVnuzHBy5mvqIRHET/gJFm2GgNfwNf7F3qXaYb8lD3HztNtQBGhf6HclmdWfTwv9cYiyEZbdCMjTSyxfxPoUhUaTbnqMFJ77SJOlYvkGstx5kXk2poyLwik1Teo5HKABmS4poCs/U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7ZytOr2YLHaD3P0Oe1lQZcS5ShpvfVDmECp8meKra6qzYCqikFXT2uX628CbN5G6E2NGUsJBXHbsrJutf6gBNMD9VBIf1s4H1Dqi+4f+2esK9ULfE9bxEOhN9pJBF4T430Y/nWHvQUwKHeLjrOrbBvRpaMRUC9xQu9uTUQbZYWjG74+xW4HceBoXm1qFklJAvz7Ks/LcURTjJlkUF57oIgYRdg5qrL28FWxXz/68v0S1MwNHzXUqTG4e2luA6a9V639bvw8VNwWaq0KlQiJqTLtt6qBEOdv/PoKqhZjHHyH+RCI+4lADVH9TXsia5Z/xgqYqocOh+0NDcZufhIkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38WAE1NxB8vuKcm9HzSrl5k1VF7Kujxlni79VItedlU=; b=c33fpYNfHMrH2jHkQaCNXD03amlnz3iuXXIq25rgl79zFS/HknRkvgQHzTv4yURxudU7PRFyjAYn+ugFZaCW7uVJguiaUpH4hc7ngOy/r717PYV/tQHGh0n6LxliaGHnC+L2Qr6CzTMn4xplSBc7FCebIdCqp5mGwfvGrfIsBKAC7hBVEf6T+KnOc7TZLEFJNUG1RUse6ysO2APpIirSUp0vOde6+Ph30SALQM10g09G0Ln7PANZTWCyO4RAPtdNJzF065uSt5ldOEBteH45pUKDBXWpez71i1zTlXJXZMxnjzjBkAiDH2m8PuIwnaTzNrEjrScZeDl8PoiU/J/aow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38WAE1NxB8vuKcm9HzSrl5k1VF7Kujxlni79VItedlU=; b=uLZELQCnTXQN+XaTnDBDTNrI6K2hD+PfIPnVnuzHBy5mvqIRHET/gJFm2GgNfwNf7F3qXaYb8lD3HztNtQBGhf6HclmdWfTwv9cYiyEZbdCMjTSyxfxPoUhUaTbnqMFJ77SJOlYvkGstx5kXk2poyLwik1Teo5HKABmS4poCs/U= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Topic: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Index: AQHYZBWe/uxRZBdW10mDRgQaF95/K60h1bOAgADQseA= Date: Tue, 17 May 2022 08:21:31 +0000 Message-ID: References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> In-Reply-To: <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9460D098992C4641A3D2CFAD21C1E0F0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7528e968-aa41-4e7f-8672-08da37de4454 x-ms-traffictypediagnostic: DB9PR08MB6475:EE_|VE1EUR03FT023:EE_|VI1PR0801MB1853:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KPBDVWSc+4wkTwGtQMSCP5DiBx5dLK/mNMOtVGoThVFAap6NJblBOIZUgeWRHyhUjIRtufm7du/FNuVIw0eLGZjnjZJ/36Ms7LJllBCXPPDIUkcggS/XSnbhEo0Wp5AHTS3DLmdAaQXNO7Mbjod3mFuywuYrpeqIe3mNcx+zKQefTzFCYpM313/EC8EiUxjTFJD2adURw5+yzrByof2XV6R/+8AUfKRY9vqN0khMZ5wk0qYCCgcDPOeS88QutKAz5E7qREyGptM2ftJa5LXEY6706gEGB9bmz1pQ3SWrXGOUL/Wly0b6QaLfUrvGO8DdsCh0JLHjxFWMmGVvidQcXhc7LgJdbJwxP8Wnl46JG5phkT5tl61hqtzC4wf3VKr1Y2Vw3bEXomrUfO30KFD95V26Aj4lajdZUkdz9Oj0fCydsWqdliO1y4pEGnK6dqdQNEyDM1wIR/crfzJ9U75O+IiTiBKGaarePUEEKn35VBk9v0ayLUzhDUo0ONw7nhvfuFQJLxKIW1OqOXtEZKeeRDK3Q1O0XxKCC8U5UFwAWWH0yycVwWnIgOBPTGY5OGehWhKt9OrVnAip7eqHmodV/O69kR1UUNbTpw58QGfpeGAgpaL9vswDFa2G3R42SECCP2I9qhbMBI/gY96sQgQB7+4TmNVgWZJyC7gdFOX6joO7gf2tDCftHx2+i6xwcXSpjx1lfK9mnrRTLtlhNVQ7hQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(83380400001)(316002)(6506007)(9686003)(54906003)(2906002)(38070700005)(52536014)(71200400001)(8936002)(53546011)(508600001)(64756008)(66476007)(66946007)(86362001)(66556008)(66446008)(26005)(76116006)(8676002)(4326008)(7696005)(110136005)(186003)(38100700002)(33656002)(5660300002)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6475 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 090dbf70-b997-4fc4-932f-08da37de3f63 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IoZ3OTAb4E32+We8g/VJY/1Hjjg4nG1m9Vhv/lx4jZLLT095d48Ju63ww5I2Lv5H3SF3sMA9HitOUTB4SAwgw9nurSRQT4HKB/N5Y/TOr4PC8QhDXaqB1qW2VcdydDMtYRUb554Raga+iP/q1kIWHSh1cwJR1FfbJSrvDD7rj5krzYV+MTfs7wUnlddhzdbWxvxcd6RPXtW+X32KAHvVexmGOsw97diFrz2Ky/Rk0xl4031DCBkVGXH9WDHFg/MR+YtzmKdixXECUMZLh7qnV1kkBuW/glSFN9oOCP+OBqyql7wwIY5h9RzAL4Qe0SSuTlg74ovRgcH0Nm9mnTerCtbjyF6Gm8s+BsC8BinC+Dg5CtUhxsme5ZHsMDYaxfo9+a0mIqydNO7X2SdR8WQ2XvOsZWhn5aJyCBuTMKUAZYQ3S4AGOMY4Ss7GVRhpwNDNe6qaNsT/XFayf5b3IhzE/+xCrSW5D6GkAe+Y0wTIWvwguzTbIveVnuDlVrPxSUkHfNJ/ImGh4Gb++VN3tcnUHwH2s4jbN51thWhF3jfP2ayop1OEPGUv6iKmqii351SvX7sq4fhzGGD1FwwH276x7ww556hQNRQMUyCqyPEOVpxvoj2awLQYJXApULMLA2WJnLjnUlfMapulJhgzdWilH0RfZk1gE6GGCfzI2DeH95h1buChdLl/kwupBYaQU9HF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8936002)(33656002)(186003)(82310400005)(2906002)(40460700003)(47076005)(26005)(7696005)(356005)(83380400001)(5660300002)(52536014)(4326008)(54906003)(86362001)(53546011)(81166007)(70586007)(508600001)(6506007)(36860700001)(70206006)(110136005)(9686003)(55016003)(336012)(316002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 08:21:39.3597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7528e968-aa41-4e7f-8672-08da37de4454 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1853 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVHVlc2RheSwgTWF5IDE3LCAyMDIyIDI6 MDEgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47 IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Ow0KPiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ow0K PiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0IDEvNl0geGVu OiBkbyBub3QgZnJlZSByZXNlcnZlZCBtZW1vcnkgaW50byBoZWFwDQo+IA0KPiBIaSBQZW5ueSwN Cj4gDQo+IE9uIDEwLzA1LzIwMjIgMDM6MjcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IFBhZ2Vz IHVzZWQgYXMgZ3Vlc3QgUkFNIGZvciBzdGF0aWMgZG9tYWluLCBzaGFsbCBiZSByZXNlcnZlZCB0 byB0aGlzDQo+ID4gZG9tYWluIG9ubHkuDQo+ID4gU28gaW4gY2FzZSByZXNlcnZlZCBwYWdlcyBi ZWluZyB1c2VkIGZvciBvdGhlciBwdXJwb3NlLCB1c2VycyBzaGFsbA0KPiA+IG5vdCBmcmVlIHRo ZW0gYmFjayB0byBoZWFwLCBldmVuIHdoZW4gbGFzdCByZWYgZ2V0cyBkcm9wcGVkLg0KPiA+DQo+ ID4gZnJlZV9zdGF0aWNtZW1fcGFnZXMgd2lsbCBiZSBjYWxsZWQgYnkgZnJlZV9oZWFwX3BhZ2Vz IGluIHJ1bnRpbWUgZm9yDQo+ID4gc3RhdGljIGRvbWFpbiBmcmVlaW5nIG1lbW9yeSByZXNvdXJj ZSwgc28gbGV0J3MgZHJvcCB0aGUgX19pbml0IGZsYWcuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5 OiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiB2NCBjaGFu Z2VzOg0KPiA+IC0gbm8gY2hhbmdlcw0KPiA+IC0tLQ0KPiA+IHYzIGNoYW5nZXM6DQo+ID4gLSBm aXggcG9zc2libGUgcmFjeSBpc3N1ZSBpbiBmcmVlX3N0YXRpY21lbV9wYWdlcygpDQo+ID4gLSBp bnRyb2R1Y2UgYSBzdHViIGZyZWVfc3RhdGljbWVtX3BhZ2VzKCkgZm9yIHRoZQ0KPiA+ICFDT05G SUdfU1RBVElDX01FTU9SWSBjYXNlDQo+ID4gLSBtb3ZlIHRoZSBjaGFuZ2UgdG8gZnJlZV9oZWFw X3BhZ2VzKCkgdG8gY292ZXIgb3RoZXIgcG90ZW50aWFsIGNhbGwNCj4gPiBzaXRlcw0KPiA+IC0g Zml4IHRoZSBpbmRlbnRhdGlvbg0KPiA+IC0tLQ0KPiA+IHYyIGNoYW5nZXM6DQo+ID4gLSBuZXcg Y29tbWl0DQo+ID4gLS0tDQo+ID4gICB4ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYyB8IDE3ICsrKysr KysrKysrKysrLS0tDQo+ID4gICB4ZW4vaW5jbHVkZS94ZW4vbW0uaCAgICB8ICAyICstDQo+ID4g ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pDQo+ID4N Cj4gPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMgYi94ZW4vY29tbW9uL3Bh Z2VfYWxsb2MuYyBpbmRleA0KPiA+IDMxOTAyOTE0MGYuLjVlNTY5YTQ4YTIgMTAwNjQ0DQo+ID4g LS0tIGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiArKysgYi94ZW4vY29tbW9uL3BhZ2Vf YWxsb2MuYw0KPiA+IEBAIC0xNDQzLDYgKzE0NDMsMTAgQEAgc3RhdGljIHZvaWQgZnJlZV9oZWFw X3BhZ2VzKA0KPiA+DQo+ID4gICAgICAgQVNTRVJUKG9yZGVyIDw9IE1BWF9PUkRFUik7DQo+ID4N Cj4gPiArICAgIGlmICggcGctPmNvdW50X2luZm8gJiBQR0NfcmVzZXJ2ZWQgKQ0KPiANCj4gTklU OiBJIHdvdWxkIHN1Z2dlc3QgdG8gdXNlICJ1bmxpa2VseSgpIiBoZXJlLg0KPiANCj4gPiArICAg ICAgICAvKiBSZXNlcnZlZCBwYWdlIHNoYWxsIG5vdCBnbyBiYWNrIHRvIHRoZSBoZWFwLiAqLw0K PiA+ICsgICAgICAgIHJldHVybiBmcmVlX3N0YXRpY21lbV9wYWdlcyhwZywgMVVMIDw8IG9yZGVy LCBuZWVkX3NjcnViKTsNCj4gPiArDQo+ID4gICAgICAgc3Bpbl9sb2NrKCZoZWFwX2xvY2spOw0K PiA+DQo+ID4gICAgICAgZm9yICggaSA9IDA7IGkgPCAoMSA8PCBvcmRlcik7IGkrKyApIEBAIC0y NjM2LDggKzI2NDAsOCBAQA0KPiA+IHN0cnVjdCBkb21haW4gKmdldF9wZ19vd25lcihkb21pZF90 IGRvbWlkKQ0KPiA+DQo+ID4gICAjaWZkZWYgQ09ORklHX1NUQVRJQ19NRU1PUlkNCj4gPiAgIC8q IEVxdWl2YWxlbnQgb2YgZnJlZV9oZWFwX3BhZ2VzIHRvIGZyZWUgbnJfbWZucyBwYWdlcyBvZiBz dGF0aWMNCj4gPiBtZW1vcnkuICovIC12b2lkIF9faW5pdCBmcmVlX3N0YXRpY21lbV9wYWdlcyhz dHJ1Y3QgcGFnZV9pbmZvICpwZywNCj4gdW5zaWduZWQgbG9uZyBucl9tZm5zLA0KPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIpDQo+ID4gK3ZvaWQg ZnJlZV9zdGF0aWNtZW1fcGFnZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsIHVuc2lnbmVkIGxvbmcg bnJfbWZucywNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIp DQo+IA0KPiBMb29raW5nIGF0IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBmcmVlX3N0YXRpY21lbV9w YWdlcygpLCB0aGUgcGFnZSB3aWxsIGJlDQo+IHNjcnViYmVkIHN5bmNocm9ub3VzbHkuDQo+IA0K PiBJZiBJIGFtIG5vdCBtaXN0YWtlbiwgc3RhdGljIG1lbW9yeSBpcyBub3QgeWV0IHN1cHBvcnRl ZCBzbyBJIHdvdWxkIGJlIE9LIHRvDQo+IGNvbnRpbnVlIHdpdGggc3luY2hyb25vdXMgc2NydWJi aW5nLiBIb3dldmVyLCB0aGlzIHdpbGwgbmVlZCB0byBiZQ0KPiBhc3luY2hyb25vdXMgYmVmb3Jl IHdlIGV2ZW4gY29uc2lkZXIgdG8gc2VjdXJpdHkgc3VwcG9ydCBpdC4NCj4gDQoNClllcywgIEkg cmVtZW1iZXJlZCB0aGF0IGFzeW5jaHJvbm91cyBpcyBzdGlsbCBvbiB0aGUgdG8tZG8gbGlzdCBm b3Igc3RhdGljIG1lbW9yeS4NCg0KSWYgaXQgZG9lc24ndCBib3RoZXIgdG9vIG11Y2ggdG8geW91 LCBJIHdvdWxkIGxpa2UgdG8gYXNrIHNvbWUgaGVscCBvbiB0aGlzIGlzc3VlLCA7KS4NCkkgb25s eSBrbmV3IGJhc2ljIGtub3dsZWRnZSBvbiB0aGUgc2NydWJiaW5nLCBJIGtuZXcgdGhhdCBkaXJ0 eSBwYWdlcyBpcyBwbGFjZWQgYXQgdGhlDQplbmQgb2YgbGlzdCBoZWFwKG5vZGUsIHpvbmUsIG9y ZGVyKSBmb3Igc2NydWJiaW5nIGFuZCAiZmlyc3RfZGlydHkiIGlzIHVzZWQgdG8gdHJhY2sgZG93 bg0KdGhlIGRpcnR5IHBhZ2VzLiBJTU8sIEJvdGggdHdvIHBhcnRzIGFyZSByZXN0cmljdGVkIHRv IHRoZSBoZWFwIHRoaW5neSwgIG5vdCByZXVzYWJsZSBmb3INCnN0YXRpYyBtZW1vcnksIHNvIG1h eWJlIEkgbmVlZCB0byByZS13cml0ZSBzY3J1Yl9mcmVlX3BhZ2UgZm9yIHN0YXRpYyBtZW1vcnks IGFuZCBhbHNvDQpsaW5rIHRoZSBuZWVkLXRvLXNjcnViIHJlc2VydmVkIHBhZ2VzIHRvIGEgbmV3 IGdsb2JhbCBsaXN0IGUuZy4gIGRpcnR5X3Jlc3ZfbGlzdCBmb3IgYXluYw0Kc2NydWJiaW5nPw0K IEFueSBzdWdnZXN0aW9ucz8NCg0KPiBCVFcsIFNVUFBPUlQubWQgZG9lc24ndCBzZWVtIHRvIGV4 cGxpY2l0ZWx5IHNheSB3aGV0aGVyIHN0YXRpYyBtZW1vcnkgaXMNCj4gc3VwcG9ydGVkLiBXb3Vs ZCB5b3UgYmUgYWJsZSB0byBzZW5kIGEgcGF0Y2ggdG8gdXBkYXRlIGl0PyBJIHRoaW5rIHRoaXMg c2hvdWxkDQo+IGJlIHRlY2ggcHJldmlldyBmb3Igbm93Lg0KPiANCg0KU3VyZSwgd2lsbCBkby4N Cg0KPiA+ICAgew0KPiA+ICAgICAgIG1mbl90IG1mbiA9IHBhZ2VfdG9fbWZuKHBnKTsNCj4gPiAg ICAgICB1bnNpZ25lZCBsb25nIGk7DQo+ID4gQEAgLTI2NTMsNyArMjY1Nyw4IEBAIHZvaWQgX19p bml0IGZyZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2luZm8NCj4gKnBnLCB1bnNpZ25l ZCBsb25nIG5yX21mbnMsDQo+ID4gICAgICAgICAgIH0NCj4gPg0KPiA+ICAgICAgICAgICAvKiBJ biBjYXNlIGluaXRpYWxpemluZyBwYWdlIG9mIHN0YXRpYyBtZW1vcnksIG1hcmsgaXQgUEdDX3Jl c2VydmVkLiAqLw0KPiA+IC0gICAgICAgIHBnW2ldLmNvdW50X2luZm8gfD0gUEdDX3Jlc2VydmVk Ow0KPiA+ICsgICAgICAgIGlmICggIShwZ1tpXS5jb3VudF9pbmZvICYgUEdDX3Jlc2VydmVkKSAp DQo+IA0KPiBOSVQ6IEkgdW5kZXJzdGFuZCB0aGUgZmxhZyBtYXkgaGF2ZSBhbHJlYWR5IGJlZW4g c2V0LCBidXQgSSBhbSBub3QgY29udmluY2VkIGlmDQo+IGl0IGlzIHdvcnRoIGNoZWNraW5nIGl0 IGFuZCB0aGVuIHNldC4NCj4gDQoNCkphbiBzdWdnZXN0ZWQgdGhhdCBzaW5jZSB3ZSByZW1vdmUg dGhlIF9faW5pdCBmcm9tIGZyZWVfc3RhdGljbWVtX3BhZ2VzLCBpdCdzIG5vdyBpbiBwcmVlbXB0 YWJsZQ0Kc3RhdGUgYXQgcnVudGltZSwgc28gYmV0dGVyIGJlIGFkZGluZyB0aGlzIGNoZWNrIGhl cmUuIA0KDQo+ID4gKyAgICAgICAgICAgIHBnW2ldLmNvdW50X2luZm8gfD0gUEdDX3Jlc2VydmVk Ow0KPiANCj4gDQo+ID4gICAgICAgfQ0KPiA+ICAgfQ0KPiA+DQo+ID4gQEAgLTI3NjIsNiArMjc2 NywxMiBAQCBpbnQgX19pbml0IGFjcXVpcmVfZG9tc3RhdGljX3BhZ2VzKHN0cnVjdA0KPiA+IGRv bWFpbiAqZCwgbWZuX3Qgc21mbiwNCj4gPg0KPiA+ICAgICAgIHJldHVybiAwOw0KPiA+ICAgfQ0K PiA+ICsjZWxzZQ0KPiA+ICt2b2lkIGZyZWVfc3RhdGljbWVtX3BhZ2VzKHN0cnVjdCBwYWdlX2lu Zm8gKnBnLCB1bnNpZ25lZCBsb25nIG5yX21mbnMsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgYm9vbCBuZWVkX3NjcnViKSB7DQo+ID4gKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsN Cj4gPiArfQ0KPiA+ICAgI2VuZGlmDQo+ID4NCj4gPiAgIC8qDQo+ID4gZGlmZiAtLWdpdCBhL3hl bi9pbmNsdWRlL3hlbi9tbS5oIGIveGVuL2luY2x1ZGUveGVuL21tLmggaW5kZXgNCj4gPiAzYmU3 NTRkYTkyLi45ZmQ5NWRlYWVjIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9tbS5o DQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL21tLmgNCj4gPiBAQCAtODUsMTAgKzg1LDEwIEBA IGJvb2wgc2NydWJfZnJlZV9wYWdlcyh2b2lkKTsNCj4gPiAgIH0gd2hpbGUgKCBmYWxzZSApDQo+ ID4gICAjZGVmaW5lIEZSRUVfWEVOSEVBUF9QQUdFKHApIEZSRUVfWEVOSEVBUF9QQUdFUyhwLCAw KQ0KPiA+DQo+ID4gLSNpZmRlZiBDT05GSUdfU1RBVElDX01FTU9SWQ0KPiA+ICAgLyogVGhlc2Ug ZnVuY3Rpb25zIGFyZSBmb3Igc3RhdGljIG1lbW9yeSAqLw0KPiA+ICAgdm9pZCBmcmVlX3N0YXRp Y21lbV9wYWdlcyhzdHJ1Y3QgcGFnZV9pbmZvICpwZywgdW5zaWduZWQgbG9uZyBucl9tZm5zLA0K PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIpOw0KPiA+ICsj aWZkZWYgQ09ORklHX1NUQVRJQ19NRU1PUlkNCj4gPiAgIGludCBhY3F1aXJlX2RvbXN0YXRpY19w YWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBzbWZuLCB1bnNpZ25lZCBpbnQNCj4gbnJfbWZu cywNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbWVtZmxh Z3MpOw0KPiA+ICAgI2VuZGlmDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3Jh bGwNCg== From xen-devel-bounces@lists.xenproject.org Tue May 17 08:34:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330540.553920 (Exim 4.92) (envelope-from ) id 1nqsem-0007uG-MR; Tue, 17 May 2022 08:34:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330540.553920; Tue, 17 May 2022 08:34:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsem-0007u9-Jm; Tue, 17 May 2022 08:34:16 +0000 Received: by outflank-mailman (input) for mailman id 330540; Tue, 17 May 2022 08:34:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsek-0007u3-Pd for xen-devel@lists.xenproject.org; Tue, 17 May 2022 08:34:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsek-0006OF-FM; Tue, 17 May 2022 08:34:14 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqsek-0001Ro-9Q; Tue, 17 May 2022 08:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uQ6QiIxKnyW0SrngqjoDXbmMgJjM1BC8Y1PBNDbCIAU=; b=VQkcyNFL3bPKi6MoIKsNntu54z +w6u6cmD13vppV1+cpX1if3W6Qi9WJW+gAbylU9HMOvoPxtJaj2Nb+VaVkVZhQeJdepQI/avy1y/d V670oAB7oidy78wBJsH7IJFQIXYY94fYR9MS+Kq4nCzfICiiF24rsi3P22HK0NS33Pt0=; Message-ID: <09550023-320a-2d51-f3c6-f5b7a999bf33@xen.org> Date: Tue, 17 May 2022 09:34:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220516170246.19908-1-julien@xen.org> <789c1899-7444-2e29-dfea-58c9fa446a8e@arm.com> From: Julien Grall In-Reply-To: <789c1899-7444-2e29-dfea-58c9fa446a8e@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/05/2022 07:47, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 16.05.2022 19:02, Julien Grall wrote: >> +static int cpu_callback(struct notifier_block *nfb, unsigned long action, >> + void *hcpu) >> +{ >> + unsigned long cpu = (unsigned long)hcpu; > As cpu does not change in this function, shouldn't we mark it as const? As discussed in [1], this is not a common practice to use const for variable that just hold integer. I would personally only used it if I think there is a security issue risk (e.g. the variable is used to flush the TLB like in [2]). Would you be able to explain why you want to use const? Is it a requirement for some certification? > >> + int rc = 0; >> + >> + switch ( action ) >> + { >> + case CPU_UP_PREPARE: >> + rc = gicv3_lpi_allocate_pendtable(cpu); >> + if ( rc ) >> + printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", > %u requires unsigned int but cpu is unsigned long. > FWICS this will cause a compilation error, so you should change to %lu. Whoops. I will fix it on the next version. > >> + cpu); >> + break; >> } >> >> - return gicv3_lpi_set_proptable(rdist_base); >> + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); >> } >> Cheers, [1] https://lore.kernel.org/xen-devel/20220505103601.322110-2-michal.orzel@arm.com/ [2] https://lore.kernel.org/xen-devel/20220221102218.33785-5-julien@xen.org/ > > Cheers, > Michal -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 08:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330548.553932 (Exim 4.92) (envelope-from ) id 1nqsiX-0008W1-6Y; Tue, 17 May 2022 08:38:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330548.553932; Tue, 17 May 2022 08:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsiX-0008Vu-33; Tue, 17 May 2022 08:38:09 +0000 Received: by outflank-mailman (input) for mailman id 330548; Tue, 17 May 2022 08:38:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsiW-0008Vh-9H; Tue, 17 May 2022 08:38:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsiW-0006SR-8V; Tue, 17 May 2022 08:38:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqsiV-0006Iu-Td; Tue, 17 May 2022 08:38:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqsiV-00077z-Sr; Tue, 17 May 2022 08:38:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=J4v357isN8i62AvfmIPJBDHJK5nfdHamPT7xrUgy3VE=; b=06nXpC6iumOAlKZOZ7N9sqn4KL AV5z1D7f6c48n1hf4jWdAvern7UQYrKl+CPeFqqA5Scdjnk3ytjC9cB4diCWQJV7TeRw3PtV6/ixO lmw4j5H3RMbovDgFpuo+fPhOmX21TePcSjgVeGxGt3ozavVRP9zq5IZQ59myb5xeRd0M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170504: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 08:38:07 +0000 flight 170504 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170504/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1058 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 77 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 08:48:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330559.553942 (Exim 4.92) (envelope-from ) id 1nqssk-0001pm-B9; Tue, 17 May 2022 08:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330559.553942; Tue, 17 May 2022 08:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqssk-0001pf-82; Tue, 17 May 2022 08:48:42 +0000 Received: by outflank-mailman (input) for mailman id 330559; Tue, 17 May 2022 08:48:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqssi-0001pZ-O7 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 08:48:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqssi-0006dp-7D; Tue, 17 May 2022 08:48:40 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqssi-0002Sa-0N; Tue, 17 May 2022 08:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/oxCCLjXpsxCCxXdx+fwFTU7t5ucB9jagH+YNt5XMV4=; b=RvMIq7YDwvl1mXwijbECrnRlFc eC1f3ZKc++/Mmwsj8t1ne44RF6O7OwHNlUt+lvcqrnsQSDHqZjit5/xCfLuDxqoGwx4hD0Vl1RozG u+4thbK/j9fp4OxYLgIvoFZgEDldie+xwpW8haSXY8kCk1GOzbM5WZ5oqFk0h+4uWOmU=; Message-ID: <277cd64d-f3eb-d2ad-d1d4-e293883ca7ef@xen.org> Date: Tue, 17 May 2022 09:48:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-7-Penny.Zheng@arm.com> <7af0d53c-6fdc-33a4-a09b-93831b4ee2c0@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/05/2022 07:24, Penny Zheng wrote: > Hi Julien Hi Penny, >>> + if ( unlikely(!page) ) >>> + return INVALID_MFN; >>> + >>> + smfn = page_to_mfn(page); >>> + >>> + if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) >> >> I am OK if we call acquire_domstatic_pages() for now. But long term, I think we >> should consider to optimize it because we know the page is valid and belong >> to the guest. So there are a lot of pointless work (checking mfn_valid(), >> scrubbing in the free part, cleaning the cache...). >> > > I'm willing to fix it here since this fix is not blocking any other patch serie~~ > I'm considering that maybe we could add a new memflag MEMF_xxx, (oh, > Naming something is really "killing" me), then all these pointless work, checking > mfn_valid, flushing TLB and cache, we could exclude them by checking > memflags & MEMF_xxxx. > Wdyt? I don't think we need a new flag because the decision is internal to the page allocator. Instead, acquire_staticmem_pages() could be split in two parts. Something like (function names are random): static bool foo(struct page_info *pg, unsigned long nr, unsigned long memflags) { spin_lock(&heap_lock); for ( i = 0; i < nr; i++ ) ... spin_unlock(&heap_lock); if ( need_tlbflush ) filtered... return true; out_err: for ( ... ) ... return false; } static struct page_info *bar(mfn_t smfn, unsigned long mfn, unsigned int memflags) { ASSERT(nr_mfns); for ( i = 0; i < nr_mfns; i++ ) if ( !mfn_valid(mfn_add(smfn, i)) ) return NULL; pg = mfn_to_page(mfn); if ( !foo(...) ) return NULL; for ( i = 0; i < nr_mfns; i++ ) flush_page_to_ram(...); } acquire_reserved_page() would then only call foo() and assign_pages(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 08:52:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330567.553954 (Exim 4.92) (envelope-from ) id 1nqswk-0003DZ-TB; Tue, 17 May 2022 08:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330567.553954; Tue, 17 May 2022 08:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqswk-0003DS-Q9; Tue, 17 May 2022 08:52:50 +0000 Received: by outflank-mailman (input) for mailman id 330567; Tue, 17 May 2022 08:52:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqswj-0003DM-98 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 08:52:49 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b9949a2a-d5be-11ec-837e-e5687231ffcc; Tue, 17 May 2022 10:52:48 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2615B1042; Tue, 17 May 2022 01:52:47 -0700 (PDT) Received: from [10.57.3.238] (unknown [10.57.3.238]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6EAB3F73D; Tue, 17 May 2022 01:52:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9949a2a-d5be-11ec-837e-e5687231ffcc Message-ID: <981d9872-266a-d03d-d6e4-80960971a00b@arm.com> Date: Tue, 17 May 2022 10:52:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220516170246.19908-1-julien@xen.org> <789c1899-7444-2e29-dfea-58c9fa446a8e@arm.com> <09550023-320a-2d51-f3c6-f5b7a999bf33@xen.org> From: Michal Orzel In-Reply-To: <09550023-320a-2d51-f3c6-f5b7a999bf33@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 17.05.2022 10:34, Julien Grall wrote: > > > On 17/05/2022 07:47, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> >> On 16.05.2022 19:02, Julien Grall wrote: >>> +static int cpu_callback(struct notifier_block *nfb, unsigned long action, >>> +                        void *hcpu) >>> +{ >>> +    unsigned long cpu = (unsigned long)hcpu; >> As cpu does not change in this function, shouldn't we mark it as const? > > As discussed in [1], this is not a common practice to use const for variable that just hold integer. > > I would personally only used it if I think there is a security issue risk (e.g. the variable is used to flush the TLB like in [2]). > > Would you be able to explain why you want to use const? Is it a requirement for some certification? > It is not a subject of any requirement. It was my personal thought. As it is not a common practice in Xen, I will keep that in mind for the future. >> >>> +    int rc = 0; >>> + >>> +    switch ( action ) >>> +    { >>> +    case CPU_UP_PREPARE: >>> +        rc = gicv3_lpi_allocate_pendtable(cpu); >>> +        if ( rc ) >>> +            printk(XENLOG_ERR "Unable to allocate the pendtable for CPU%u\n", >> %u requires unsigned int but cpu is unsigned long. >> FWICS this will cause a compilation error, so you should change to %lu. > > Whoops. I will fix it on the next version. > >> >>> +                   cpu); >>> +        break; >>>       } >>>   -    return gicv3_lpi_set_proptable(rdist_base); >>> +    return !rc ? NOTIFY_DONE : notifier_from_errno(rc); >>>   } >>>   > > Cheers, > > [1] https://lore.kernel.org/xen-devel/20220505103601.322110-2-michal.orzel@arm.com/ > [2] https://lore.kernel.org/xen-devel/20220221102218.33785-5-julien@xen.org/ > >> >> Cheers, >> Michal > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 17 08:58:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330579.553965 (Exim 4.92) (envelope-from ) id 1nqt2I-0003tN-JH; Tue, 17 May 2022 08:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330579.553965; Tue, 17 May 2022 08:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2I-0003tG-Fm; Tue, 17 May 2022 08:58:34 +0000 Received: by outflank-mailman (input) for mailman id 330579; Tue, 17 May 2022 08:58:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2G-0003tA-Gx for xen-devel@lists.xenproject.org; Tue, 17 May 2022 08:58:32 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8680a760-d5bf-11ec-837e-e5687231ffcc; Tue, 17 May 2022 10:58:31 +0200 (CEST) Received: from AS9PR06CA0062.eurprd06.prod.outlook.com (2603:10a6:20b:464::12) by AM4PR0802MB2305.eurprd08.prod.outlook.com (2603:10a6:200:5f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 08:58:30 +0000 Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::12) by AS9PR06CA0062.outlook.office365.com (2603:10a6:20b:464::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 17 May 2022 08:58:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 08:58:29 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Tue, 17 May 2022 08:58:29 +0000 Received: from d9ed81a8533a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 032A63CD-6677-4009-8F69-16BED9174C6E.1; Tue, 17 May 2022 08:58:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9ed81a8533a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 08:58:23 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3207.eurprd08.prod.outlook.com (2603:10a6:209:42::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 08:58:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::4de:59d7:ae91:54a1%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 08:58:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8680a760-d5bf-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RzW0xefCA/3Q4+zSD9/mSD0BBrLnkmOt3CthRmsXfYIF0ncnTU6aBGdLpjd3F2RF3ryPyDGZ/3NcjLVRQWtbEtfZ7vCEiQYquFv25Mf/FVsbK4WkYT+DM1p3UIim568myG6J5ICqih9rh7HSeS1DM905y1X5+OQiQM4jdeA2hIY9RpqVABnyzOPV0moWSOrK5GBL429J/z0zaM8xs7qb8MtleTBknBk32bQMIpSDNFaCTUXKH3M8NglsvYvc2kjYqkGvX/khgQkZhtfjY3zL4DoG3m5DEn86jkLbHSYR4MvpyzIFKXyjs7rRuysIb2qLPvDMyT8fnGOwCEoAw72U5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10wHUjDuDNEQyWZqwt7Dfjx5Ae5tYxjzFLMn4L83xOM=; b=d1mX+VcwuHIqoWSGiSnO2XdvL3m3gt52SVORXtYx8MJ03EAbheks9qo7Gz8RwoziGYlHBuZ8NUxoKjRW8EyaPUePrelT/NUq0PiUjenuxcurenL1jPFGceNw7DL6N8AG2ketv+OHRdEDbUMKRFMblfW9XypeB3oK2sU3LpMbPuSPPUq/nCpGgQt5XjDettv5R1EFSw1+asJCGXQaZFeGpRuaRjIPLb+2o7CPUcOzsDsUMxJpMdtGLxTQpHmBN1WX/KINuCgykTtIS7heFWDeJhmgJaRvjRarf/wI7Ew//HHq+oQ8TXwpGu7K58elczTMUk5nANb2cxNwFUDOac/sDA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10wHUjDuDNEQyWZqwt7Dfjx5Ae5tYxjzFLMn4L83xOM=; b=GbAQJG10z2P3M9Ij45cvf6FnjYdaT/fSnLpUBCC8a92xkpGmmCsIYLAZLlYn9HbvELjlvPGa/+8+aMARZQwyjb8oOlFuecpOsptCh0m1gwvP4IfCXUkdTL27qIHoDopnrwMLDkKoKTaNVH9Q8K24FIvEpYA6HVqhbDU89dB+m4A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6a8972e2e24b43b5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5J6ImnobAJpgl0G7dqxKsT+h0OXCYPZ1rFR1W+Fix2MRCJbcoqcFtjl96hUq/KtIQIR8NX2DZcgPT35dV3ecvGdp2tY6zidvFdpOEo0kATU7jdMHVZjWPpa9+tNapFDcANPgMkvfkXeOcCy4mspCvw+PXpyerRxSaR9mMsC2lTL53n/hVSvRIEQ3T47GpubgvcI0+tdCHIag5deea5wY8s7KGEvBMN4lYg5BBiLARa5YH+N5V+32FCWgxSqIYh4ebocIV9XSyZ/7lDsW4RcFLeg6VuoBQW7JhTxcME0xjBP/nIW7TDocwUIKxAJiqfqaWciJWW0T0DN9X32cjQw1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10wHUjDuDNEQyWZqwt7Dfjx5Ae5tYxjzFLMn4L83xOM=; b=j8J/c2gWwizZDpYydTQZ72uQ0PIDaUSF9pNb9Chsx/nNIMscY2sud/HZdMeYgDxtYe7TfhhLLjhJHuD44EdSOEw7ASbr/kB0pyAGwO153IC446cFPgT6hqqqGK2IcCyf+QcdN3rHczZKzDrbq26Dvq4kH9Jbt9t2LodX7TiNJdXHa/Fl5vi0iRyCi6DzSqZRdVXWKXBYckHYIUciELqDXw+MxngT/gkgnT37tHMBcOKs019Pz/1zxwcDQY5SpxZky4/vlqPTUwFyq8SD/YyrQiuBgwNAb8bGy0toKOQumikZ0sHnBXRqdOD1TanhFX90v12kICy8yqpaY+gk052e1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10wHUjDuDNEQyWZqwt7Dfjx5Ae5tYxjzFLMn4L83xOM=; b=GbAQJG10z2P3M9Ij45cvf6FnjYdaT/fSnLpUBCC8a92xkpGmmCsIYLAZLlYn9HbvELjlvPGa/+8+aMARZQwyjb8oOlFuecpOsptCh0m1gwvP4IfCXUkdTL27qIHoDopnrwMLDkKoKTaNVH9Q8K24FIvEpYA6HVqhbDU89dB+m4A= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Topic: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU Thread-Index: AQHYaUbNn/1ZVAYT+kGgDN69tRiyPq0ixfIA Date: Tue, 17 May 2022 08:58:18 +0000 Message-ID: <89313424-EB15-4A9B-B215-178460F035C4@arm.com> References: <20220516170246.19908-1-julien@xen.org> In-Reply-To: <20220516170246.19908-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c15483d5-d2ad-4fb4-9abc-08da37e369ce x-ms-traffictypediagnostic: AM6PR08MB3207:EE_|AM5EUR03FT046:EE_|AM4PR0802MB2305:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9VloGLj6p8EUpCTWmeDlRwifLYmA9QzPqzQqmetU5xmOkIK0a9BXJscVWjTNIt6gpaZr1DHrRnIdy6XFjRAVZJ1dsNUhucCwmMCvWaPL4dtGXV8woYqM9Cyy64IDb+dEOdo7wVqlipqYg3mx5kAZtFvvq48eGzK54TLCGObJQL099rUvd4awEVyXutfhXUUsfcUldFgk/WqvI3o+JFk3syZh+8bWw+01jRuPAWSTCIFrsGbpaCrCGAiuhDTfDBAgKJCdRdnr6XcSYcqO0Erad9UC5GhGHUaaXiHVcqL4b6vzQ+ebyRxfoMXyC3xNPTSlyKy/yL2lM72NjUneCVyYeMBJoVMkc3o9xfOMwUYO9K/lDcgHVf04HESf3IMAR9iO47Ujw3ccmjNkOqs7DuSPTQIrgVOnCqRtEK+wlKsWGIfTQiRVVo/ytqeny4uQJm0SoyyvWkLTsnmuJgN4kWLZZBFVud99RXY32yH82DDwApy4tH/uW2DK6l7xE7duIL974zxfh13+XQ5+R3Kq3vqo2Ci/aBbcrSy7kMOcAydfP7RERVZeb+WaGYaOMibiYA8eowFv5aMK92BOT8oN1bPxF8GhnCEcngnkkHZWwTB9bCDirYfgyyKHIhGPS9seDw76zNPnrHmO4YVkD9+4SBELWu4X7maVzvSKuG3N3PHi45IuqP3OM9JxtaZvKrhnjjiTI8dvzkwdUT66jWZP898lCyPA+SHmKT2sEO3UIiFys0/GYfIXYJZvMf6zxZpLsiNw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(5660300002)(26005)(6512007)(186003)(316002)(38070700005)(66476007)(8676002)(54906003)(86362001)(2906002)(53546011)(122000001)(66946007)(6506007)(76116006)(4326008)(64756008)(66446008)(66556008)(2616005)(91956017)(71200400001)(508600001)(6486002)(8936002)(6916009)(83380400001)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6B27061753E3E8408987B13464685770@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3207 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a52de86-e9dc-41bc-52e9-08da37e36320 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4HO0798Gu9/glgs3tZDCTziiJgLILFyL1c064tq8WzUZCZL7vsZw4oZB02SiRG2GkvT8n8mSma4KEYVljiidOQ4CZ9JaYqKi+fx8GhvqMgOuQl7SLWVwjpCPkkh4mmif3oehCsxfj/cv24oAbY7Q6VBsXqGiEXrNFYALKW7R1reZgNaj44dz5UOVopfK1PEEue8nOzepnsQTkio+cc2sr6p0zUkh3TXUREFF2FMBvcAiQVCS46qtBqP0S9tStj2Kv/56CK5OnCQNDKMr6bulagqVY/GMNFkDZcsYU2b/EW6VqaYfpl4oeNTx5ZPehN9yiewDO6U69J3H6w5f2mB2huNiuH57DUwWjszqAaV5Av6xUOa7+9NdOCDSPODkSRWNGHSXtoc7DsIf/UBBHdvE6T2MPUS3RevGeC41Q3ZhlXYMUdpeTcUrSQghVFN7hLICbylSCxuqyik5XKChDB5PAROCzFZGx8UTAE/Z7SCZOYxJTdCCAXx06DtIeJ/fXthsCc2d2gSS1zjwZrSxafzcAVYqaScAAedx3COAH3LOhn8MnvYTaqShuezCjEvoEeluCAfWNLz0Ec0lJ8pfAFLZ5gProDVtYxGssOIKxuWV19FstpyJwQCwAJ0O3cwzVepeh+/pqH3Ft+K6+e40ffu2RJwnCC2IVADGI5fyGnBdmvMjzieMjweV12cVJp+RDy5S X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36756003)(6486002)(83380400001)(316002)(2616005)(107886003)(6512007)(40460700003)(47076005)(82310400005)(6506007)(2906002)(6862004)(508600001)(8936002)(53546011)(26005)(81166007)(86362001)(70586007)(70206006)(4326008)(8676002)(356005)(186003)(336012)(36860700001)(54906003)(33656002)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 08:58:29.7973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c15483d5-d2ad-4fb4-9abc-08da37e369ce X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2305 Hi Julien, > On 16 May 2022, at 18:02, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap > alloc/free" extended the checks in the buddy allocator to catch any > use of the helpers from context with interrupts disabled. >=20 > Unfortunately, the rule is not followed in the LPI code when allocating > the pending table: >=20 > (XEN) Xen call trace: > (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) > (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) > (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 > (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 > (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 > (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 > (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+= 0x20/0x50 > (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 > (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 > (XEN) [<0000010722aa4200>] 0000010722aa4200 > (XEN) > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 2: > (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus(= ) <=3D 1)' failed at common/page_alloc.c:2212 > (XEN) **************************************** >=20 > For now the patch extending the checks has been reverted, but it would > be good to re-introduce it (allocation with interrupt is not desirable). >=20 > The logic is reworked to allocate the pending table when preparing the > CPU. >=20 > Signed-off-by: Julien Grall With the print fixed as pointed by Michal you can add my: Reviewed-by: Bertrand Marquis (Fix could be done on commit but that is up to you). Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 17 08:59:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 08:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330587.553975 (Exim 4.92) (envelope-from ) id 1nqt2p-0004PC-TK; Tue, 17 May 2022 08:59:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330587.553975; Tue, 17 May 2022 08:59:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2p-0004P5-QR; Tue, 17 May 2022 08:59:07 +0000 Received: by outflank-mailman (input) for mailman id 330587; Tue, 17 May 2022 08:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2p-0004Os-5L; Tue, 17 May 2022 08:59:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2p-0006oX-1T; Tue, 17 May 2022 08:59:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt2o-0007Mp-M4; Tue, 17 May 2022 08:59:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqt2o-0007iT-Lf; Tue, 17 May 2022 08:59:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7wlVMF7pA4+ZAvysTyt98uPZ6joYoXQJ352iGwJ3NYA=; b=0YNGKmBt0auaR73djoK11OiY7k py5/bdi9x1+8+EWYTsJXZht8MnY78pMEMsDM7onxGrrBatzgzC9r9Jg2Yl0+DtDwcBRsQF9HBTT2z qBu/9+LGCvj5JPEiXUHczlX/+hpKLEljyTM310JpxeG6cyec2kk704nOvQ1IPOxdxVE0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170500: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=43aa510c194b56d97c49d5f8fad5a12647bc0a1a X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 17 May 2022 08:59:06 +0000 flight 170500 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170500/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 43aa510c194b56d97c49d5f8fad5a12647bc0a1a baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 676 days Failing since 151818 2020-07-11 04:18:52 Z 675 days 657 attempts Testing same since 170500 2022-05-17 04:20:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107942 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330598.553987 (Exim 4.92) (envelope-from ) id 1nqt9a-0005zl-Q2; Tue, 17 May 2022 09:06:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330598.553987; Tue, 17 May 2022 09:06:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9a-0005ze-Mb; Tue, 17 May 2022 09:06:06 +0000 Received: by outflank-mailman (input) for mailman id 330598; Tue, 17 May 2022 09:06:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9Z-0005zY-Rp for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 94524c93-d5c0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 11:06:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6A621042; Tue, 17 May 2022 02:06:03 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BD4F73F73D; Tue, 17 May 2022 02:05:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94524c93-d5c0-11ec-837e-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v4 0/8] static shared memory on dom0less system Date: Tue, 17 May 2022 17:05:21 +0800 Message-Id: <20220517090529.3140417-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (8): xen/arm: introduce static shared memory xen/arm: allocate static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 docs/misc/arm/device-tree/booting.txt | 120 ++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 68 +++++ xen/arch/arm/domain_build.c | 378 +++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 4 + xen/arch/arm/mm.c | 42 ++- xen/common/domain.c | 5 + 9 files changed, 618 insertions(+), 10 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330599.553998 (Exim 4.92) (envelope-from ) id 1nqt9f-0006Ga-2v; Tue, 17 May 2022 09:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330599.553998; Tue, 17 May 2022 09:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9e-0006GP-WC; Tue, 17 May 2022 09:06:11 +0000 Received: by outflank-mailman (input) for mailman id 330599; Tue, 17 May 2022 09:06:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9d-0006FZ-LB for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:09 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 95d99d24-d5c0-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 11:06:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2AF41063; Tue, 17 May 2022 02:06:06 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3A8AF3F73D; Tue, 17 May 2022 02:06:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d99d24-d5c0-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 1/8] xen/arm: introduce static shared memory Date: Tue, 17 May 2022 17:05:22 +0800 Message-Id: <20220517090529.3140417-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch serie introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 change: - nit fix on doc --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 120 ++++++++++++++++++++++++++ xen/arch/arm/Kconfig | 6 ++ xen/arch/arm/bootfdt.c | 68 +++++++++++++++ xen/arch/arm/include/asm/setup.h | 3 + 4 files changed, 197 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 7b4a29a2c2..b2a7f3f590 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -360,3 +360,123 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An 8-bit integer that represents the unique identifier of the shared memory + region. The maximum identifier shall be "xen,shm-id = <0xff>". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. The number of cells + for the host address (and size) is the same as the guest pseudo-physical + address and they are inherited from the parent node. + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + "dom_shared", a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = <0x0>; + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = <0x1>; + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as 0x0, host physical +address starting at 0x10000000 of 256MB will be reserved to be shared between +Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest physical address +space, and at 0x50000000 in DomU1 guest physical address space. Dom0 is +explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as 0x1, host physical +address starting at 0x50000000 of 512MB will be reserved to be shared between +DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical +address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 +and DomU2 are both the borrower domain, the owner domain is the default owner +domain dom_shared. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..5ee9921f56 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -106,6 +106,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 29671c8df0..c8e8747c3e 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -360,6 +360,70 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + u32 address_cells, u32 size_cells) +{ + const struct fdt_property *prop; + const __be32 *cell; + paddr_t paddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned long i; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + prop = fdt_get_property(fdt, node, "xen,shared-mem", NULL); + if ( !prop ) + return -ENOENT; + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * A static shared memory region could be shared between multiple + * domains. + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + break; + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of domains, which later may be used to + * calculate the number of the reference count. + */ + mem->bank[i].nr_shm_domain++; + + return 0; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -380,6 +444,10 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); +#ifdef CONFIG_STATIC_SHM + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); +#endif if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 7a1e1d6798..35449bd7d8 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -27,6 +27,9 @@ struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + unsigned int nr_shm_domain; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330600.554009 (Exim 4.92) (envelope-from ) id 1nqt9i-0006ZP-FQ; Tue, 17 May 2022 09:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330600.554009; Tue, 17 May 2022 09:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9i-0006ZC-AW; Tue, 17 May 2022 09:06:14 +0000 Received: by outflank-mailman (input) for mailman id 330600; Tue, 17 May 2022 09:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9g-0006FZ-N6 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:12 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 984ad627-d5c0-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 11:06:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4EDB1063; Tue, 17 May 2022 02:06:10 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3EEA53F73D; Tue, 17 May 2022 02:06:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 984ad627-d5c0-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io Date: Tue, 17 May 2022 17:05:23 +0800 Message-Id: <20220517090529.3140417-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 change: - no changes --- v3 change: - refine in-code comment --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 132 +++++++++++++++++++++++++++++++++++- xen/common/domain.c | 5 ++ 2 files changed, 136 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index aa777741bd..1746c15b7c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -522,6 +522,10 @@ static bool __init append_static_memory_to_bank(struct domain *d, return true; } +/* + * If cell is NULL, pbase and psize should hold valid values. + * Otherwise, cell will be populated together with pbase and psize. + */ static mfn_t __init acquire_static_memory_bank(struct domain *d, const __be32 **cell, u32 addr_cells, u32 size_cells, @@ -530,7 +534,8 @@ static mfn_t __init acquire_static_memory_bank(struct domain *d, mfn_t smfn; int res; - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); + if ( cell ) + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); if ( PFN_DOWN(*psize) > UINT_MAX ) { @@ -754,6 +759,125 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + + page = maddr_to_page(pbase); + ASSERT(page); + + if ( page_get_owner(page) == NULL ) + return false; + + ASSERT(page_get_owner(page) == dom_io); + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t *pbase, paddr_t *psize) +{ + /* + * Pages of statically shared memory shall be included + * in domain_tot_pages(). + */ + d->max_pages += PFN_DOWN(*psize); + + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, + pbase, psize); + +} + +/* + * Func allocate_shared_memory is supposed to be only called + * from the owner. + */ +static int __init allocate_shared_memory(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, addr_cells, size_cells, &pbase, + &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. + * It sees RAM 1:1 and we do not need to create P2M mapping for it + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + int ret = 0; + const struct dt_property *prop; + const __be32 *cells; + u32 shm_id; + u32 addr_cells, size_cells; + paddr_t gbase, pbase, psize; + + dt_for_each_child_node(node, shm_node) + { + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + if ( !dt_property_read_u32(shm_node, "xen,shm-id", &shm_id) ) + { + printk("Shared memory node does not provide \"xen,shm-id\" property.\n"); + return -ENOENT; + } + + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + if ( !prop ) + { + printk("Shared memory node does not provide \"xen,shared-mem\" property.\n"); + return -ENOENT; + } + cells = (const __be32 *)prop->value; + /* xen,shared-mem = ; */ + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); + gbase = dt_read_number(cells, addr_cells); + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * Per static shared memory region could be shared between multiple + * domains. + * In case re-allocating the same shared memory region, we check + * if it is already allocated to the default owner dom_io before + * the actual allocation. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* Allocate statically shared pages to the default owner dom_io. */ + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3152,6 +3276,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index 7570eae91a..833ace7641 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -780,6 +780,11 @@ void __init setup_system_domains(void) * This domain owns I/O pages that are within the range of the page_info * array. Mappings occur at the priv of the caller. * Quarantined PCI devices will be associated with this domain. + * + * DOMID_IO could also be used for mapping memory when no explicit + * domain is specified. + * For instance, DOMID_IO is the owner of memory pre-shared among + * multiple domains at boot time, when no explicit owner is specified. */ dom_io = domain_create(DOMID_IO, NULL, 0); if ( IS_ERR(dom_io) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330602.554021 (Exim 4.92) (envelope-from ) id 1nqt9k-0006sD-Rt; Tue, 17 May 2022 09:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330602.554021; Tue, 17 May 2022 09:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9k-0006s5-L8; Tue, 17 May 2022 09:06:16 +0000 Received: by outflank-mailman (input) for mailman id 330602; Tue, 17 May 2022 09:06:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9j-0005zY-Hd for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9a73bbfd-d5c0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 11:06:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED6D51042; Tue, 17 May 2022 02:06:13 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4DD643F73D; Tue, 17 May 2022 02:06:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a73bbfd-d5c0-11ec-837e-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 3/8] xen/arm: allocate static shared memory to a specific owner domain Date: Tue, 17 May 2022 17:05:24 +0800 Message-Id: <20220517090529.3140417-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 change: - no changes --- v3 change: - simplify the code since o_gbase is not used if the domain is dom_io --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 44 +++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 1746c15b7c..59591e3c6e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -800,9 +800,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, */ static int __init allocate_shared_memory(struct domain *d, u32 addr_cells, u32 size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -817,8 +819,18 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR + "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -831,6 +843,8 @@ static int __init process_shm(struct domain *d, u32 shm_id; u32 addr_cells, size_cells; paddr_t gbase, pbase, psize; + const char *role_str; + bool owner_dom_io = true; dt_for_each_child_node(node, shm_node) { @@ -857,19 +871,27 @@ static int __init process_shm(struct domain *d, ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); gbase = dt_read_number(cells, addr_cells); - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * Per static shared memory region could be shared between multiple * domains. - * In case re-allocating the same shared memory region, we check - * if it is already allocated to the default owner dom_io before - * the actual allocation. + * So when owner domain is the default dom_io, in case re-allocating + * the same shared memory region, we check if it is already allocated + * to the default owner dom_io before the actual allocation. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { - /* Allocate statically shared pages to the default owner dom_io. */ - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + /* Allocate statically shared pages to the owner domain. */ + ret = allocate_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330609.554030 (Exim 4.92) (envelope-from ) id 1nqt9p-0007I8-9N; Tue, 17 May 2022 09:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330609.554030; Tue, 17 May 2022 09:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9p-0007Hx-5h; Tue, 17 May 2022 09:06:21 +0000 Received: by outflank-mailman (input) for mailman id 330609; Tue, 17 May 2022 09:06:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9n-0005zY-IH for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9c69672d-d5c0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 11:06:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DBD61042; Tue, 17 May 2022 02:06:17 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 744B63F73D; Tue, 17 May 2022 02:06:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c69672d-d5c0-11ec-837e-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 4/8] xen/arm: introduce put_page_nr and get_page_nr Date: Tue, 17 May 2022 17:05:25 +0800 Message-Id: <20220517090529.3140417-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng --- v4 changes: - make sure that the right equation return is at least equal to n - simplify the underflow --- v3 changes: - check overflow with "n" - remove spurious change - bring back the check that we enter the loop only when count_info is greater than 0 --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 42 +++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2823..c737d51e4d 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -347,6 +347,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f4906..8c8a8f6378 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1537,21 +1537,29 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; + /* Restrict nr to avoid "double" overflow */ + if ( nr >= PGC_count_mask ) + { + ASSERT_UNREACHABLE(); + return NULL; + } + do { x = y; /* * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + if ( unlikely(((x + nr) & PGC_count_mask) <= nr) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1559,14 +1567,19 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT((y & PGC_count_mask) >= nr); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); @@ -1576,19 +1589,30 @@ void put_page(struct page_info *page) } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) +{ + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) { - const struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330611.554042 (Exim 4.92) (envelope-from ) id 1nqt9r-0007el-Jk; Tue, 17 May 2022 09:06:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330611.554042; Tue, 17 May 2022 09:06:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9r-0007ee-Fd; Tue, 17 May 2022 09:06:23 +0000 Received: by outflank-mailman (input) for mailman id 330611; Tue, 17 May 2022 09:06:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9p-0006FZ-Up for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9dedc3ff-d5c0-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 11:06:20 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 466D41063; Tue, 17 May 2022 02:06:20 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9B4D33F73D; Tue, 17 May 2022 02:06:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dedc3ff-d5c0-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Tue, 17 May 2022 17:05:26 +0800 Message-Id: <20220517090529.3140417-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng --- v4 changes: - no change --- v3 change: - printk rather than dprintk since it is a serious error --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 62 +++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 59591e3c6e..3a20247836 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -794,6 +794,34 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, } +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned long bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( pbase == bank_start && psize == bank_size ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + if ( d == dom_io ) + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain; + else + /* Exclude the owner domain itself. */ + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain - 1; + + return 0; +} + /* * Func allocate_shared_memory is supposed to be only called * from the owner. @@ -805,6 +833,8 @@ static int __init allocate_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -819,6 +849,7 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); @@ -830,6 +861,37 @@ static int __init allocate_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrow domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of let borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:06:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330617.554053 (Exim 4.92) (envelope-from ) id 1nqt9y-0008Ok-3j; Tue, 17 May 2022 09:06:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330617.554053; Tue, 17 May 2022 09:06:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9x-0008OV-TE; Tue, 17 May 2022 09:06:29 +0000 Received: by outflank-mailman (input) for mailman id 330617; Tue, 17 May 2022 09:06:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9w-0005zY-FF for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a212001f-d5c0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 11:06:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C17A11063; Tue, 17 May 2022 02:06:26 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EF2203F73D; Tue, 17 May 2022 02:06:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a212001f-d5c0-11ec-837e-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 7/8] xen/arm: create shared memory nodes in guest device tree Date: Tue, 17 May 2022 17:05:28 +0800 Message-Id: <20220517090529.3140417-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 change: - no change --- v3 change: - move field "shm_mem" to kernel_info --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 143 +++++++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/setup.h | 1 + 3 files changed, 143 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fcdd87468d..ba044cab60 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -895,7 +895,22 @@ static int __init allocate_shared_memory(struct domain *d, return ret; } -static int __init process_shm(struct domain *d, +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + u32 shm_id) +{ + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id = shm_id; + kinfo->shm_mem.nr_banks++; + + return 0; +} + +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { struct dt_device_node *shm_node; @@ -966,6 +981,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1296,6 +1319,117 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + unsigned long i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + uint8_t shm_id = mem->bank[i].shm_id; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + __be32 reg[4]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_cell(fdt, "xen,id", shm_id); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + char resvbuf[16] = "reserved-memory"; + + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3032,6 +3166,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of @@ -3370,7 +3509,7 @@ static int __init construct_domU(struct domain *d, assign_static_memory_11(d, &kinfo, node); #ifdef CONFIG_STATIC_SHM - rc = process_shm(d, node); + rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; #endif diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 874aa108a7..e089980b87 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -19,6 +19,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; + struct meminfo shm_mem; /* kernel entry point */ paddr_t entry; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 35449bd7d8..6cd45b6212 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -29,6 +29,7 @@ struct membank { bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ #ifdef CONFIG_STATIC_SHM unsigned int nr_shm_domain; + uint8_t shm_id ; /* ID identifier of a static shared memory bank. */ #endif }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:12:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:12:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330662.554074 (Exim 4.92) (envelope-from ) id 1nqtFT-0002oW-0Q; Tue, 17 May 2022 09:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330662.554074; Tue, 17 May 2022 09:12:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtFS-0002oP-Tz; Tue, 17 May 2022 09:12:10 +0000 Received: by outflank-mailman (input) for mailman id 330662; Tue, 17 May 2022 09:12:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqt9t-0006FZ-1N for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9fbd5e63-d5c0-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 11:06:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74FB31063; Tue, 17 May 2022 02:06:23 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C41173F73D; Tue, 17 May 2022 02:06:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fbd5e63-d5c0-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v4 6/8] xen/arm: set up shared memory foreign mapping for borrower domain Date: Tue, 17 May 2022 17:05:27 +0800 Message-Id: <20220517090529.3140417-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 changes: - no change --- v3 change: - use map_regions_p2mt instead --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3a20247836..fcdd87468d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -957,6 +957,15 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:12:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:12:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330660.554064 (Exim 4.92) (envelope-from ) id 1nqtFR-0002Y0-Ml; Tue, 17 May 2022 09:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330660.554064; Tue, 17 May 2022 09:12:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtFR-0002Xr-JW; Tue, 17 May 2022 09:12:09 +0000 Received: by outflank-mailman (input) for mailman id 330660; Tue, 17 May 2022 09:12:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtA1-0005zY-GQ for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:06:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a3f188d9-d5c0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 11:06:30 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2EF21063; Tue, 17 May 2022 02:06:29 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4EDF13F73D; Tue, 17 May 2022 02:06:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3f188d9-d5c0-11ec-837e-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 8/8] xen/arm: enable statically shared memory on Dom0 Date: Tue, 17 May 2022 17:05:29 +0800 Message-Id: <20220517090529.3140417-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220517090529.3140417-1-Penny.Zheng@arm.com> References: <20220517090529.3140417-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v4 change: - no change --- v3 change: - no change --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index ba044cab60..bbf5461595 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2614,6 +2614,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3637,6 +3642,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3671,6 +3679,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 09:29:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:29:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330705.554086 (Exim 4.92) (envelope-from ) id 1nqtVe-0004o8-JR; Tue, 17 May 2022 09:28:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330705.554086; Tue, 17 May 2022 09:28:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtVe-0004o1-Gp; Tue, 17 May 2022 09:28:54 +0000 Received: by outflank-mailman (input) for mailman id 330705; Tue, 17 May 2022 09:28:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtVd-0004nv-3B for xen-devel@lists.xenproject.org; Tue, 17 May 2022 09:28:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtVc-0007Pw-KF; Tue, 17 May 2022 09:28:52 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nqtVc-0004of-Dz; Tue, 17 May 2022 09:28:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ISx1RozKUre99XMm5HKBkqDpV3Tc2zcGV/k2qw3prZY=; b=euRuilHGevu4j/FDLZcgzaZpC3 zoShuLLMag/s2t8sqoYmQtqiuq7XWTVzclgO34O/9G9g0cyV/HpTGi7/+ck+q1g1CbC85z27CQXcn UFVW9Xt92LLIJG0Gt/wW4mrvoyIF26sG56xYzR6vvWY/cEVE+mw6kcxrfLfPKLDfCchM=; Message-ID: <511fd0cb-348f-b65d-cb7b-effd822c7f20@xen.org> Date: Tue, 17 May 2022 10:28:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 17/05/2022 09:21, Penny Zheng wrote: > Yes, I remembered that asynchronous is still on the to-do list for static memory. > > If it doesn't bother too much to you, I would like to ask some help on this issue, ;). > I only knew basic knowledge on the scrubbing, My kwnoledge on the scrubbing code is not much better than yours :). > I knew that dirty pages is placed at the > end of list heap(node, zone, order) for scrubbing and "first_dirty" is used to track down > the dirty pages. IMO, Both two parts are restricted to the heap thingy, not reusable for > static memory, That's correct. > so maybe I need to re-write scrub_free_page for static memory, and also > link the need-to-scrub reserved pages to a new global list e.g. dirty_resv_list for aync > scrubbing? So I can foresee two problems with scrubbing static memory: 1) Once the page is scrubbed, we need to know which domain it belongs so we can link the page again 2) A page may still wait for scrubbing when the domain allocate memory (IOW the reserved list may be empty). So we need to find a page belonging to the domain and then scrubbed. The two problems above would indicate that a per-domain scrub list would be the best here. We would need to deal with initial scrubbing differently (maybe a global list as you suggested). I expect it will take some times to implement it properly. While writing this, I was wondering if there is actually any point to scrub pages when the domain is releasing them. Even if they are free they are still belonging to the domain, so scrubbing them is technically not necessary. Any thoughts? >>> { >>> mfn_t mfn = page_to_mfn(pg); >>> unsigned long i; >>> @@ -2653,7 +2657,8 @@ void __init free_staticmem_pages(struct page_info >> *pg, unsigned long nr_mfns, >>> } >>> >>> /* In case initializing page of static memory, mark it PGC_reserved. */ >>> - pg[i].count_info |= PGC_reserved; >>> + if ( !(pg[i].count_info & PGC_reserved) ) >> >> NIT: I understand the flag may have already been set, but I am not convinced if >> it is worth checking it and then set. >> > > Jan suggested that since we remove the __init from free_staticmem_pages, it's now in preemptable > state at runtime, so better be adding this check here. Well, count_info is already modified within that loop (see mark_page_free()). So I think the impact of setting PGC_reserved is going to be meaningless. However... mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_reserved. Theferore, in the current implementation we always need to re-set PGC_reserved. So effectively, the "if" is pointless here. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 09:53:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:53:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330716.554097 (Exim 4.92) (envelope-from ) id 1nqtt5-0007wC-Hi; Tue, 17 May 2022 09:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330716.554097; Tue, 17 May 2022 09:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtt5-0007w5-Em; Tue, 17 May 2022 09:53:07 +0000 Received: by outflank-mailman (input) for mailman id 330716; Tue, 17 May 2022 09:53:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtt4-0007vv-2l; Tue, 17 May 2022 09:53:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtt4-0007r9-0q; Tue, 17 May 2022 09:53:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqtt3-0001w1-HU; Tue, 17 May 2022 09:53:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqtt3-0008QY-H0; Tue, 17 May 2022 09:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uoTET6JKyd87dBL4SVHzg1S5cpBgIDa7cLWy01nt02E=; b=e+PaqCYneWOuCypm2uDO0zrKQM gahebmHgbiyz/eBVkghV8hVfnUPZF6SyVTFw9fJJZ+T1llZtCks6j8/v/CxeYPKi/UjzLb8HzqyyS PhCCFh6myakS0u0JmvWCf2tnYkN92/fIXd6vynbGxxLYc/rdnqZcxrySuM8shjbWrjLI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170499: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=eec398119fc6911d99412c37af06a6bc27871f85 X-Osstest-Versions-That: qemuu=b935385c351d624993c4accd712cef8510658ecd From: osstest service owner Date: Tue, 17 May 2022 09:53:05 +0000 flight 170499 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170499/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170489 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170489 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170489 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170489 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170489 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170489 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170489 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170489 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu eec398119fc6911d99412c37af06a6bc27871f85 baseline version: qemuu b935385c351d624993c4accd712cef8510658ecd Last test of basis 170489 2022-05-16 20:08:17 Z 0 days Testing same since 170499 2022-05-17 03:46:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Ben Widawsky Claudio Fontana Daniel P. Berrangé David Woodhouse David Woodhouse Dr. David Alan Gilbert Eugenio Pérez Francisco Iglesias Halil Pasic Ilya Maximets Ivan Shcherbakov Jason Wang Jonah Palmer Jonathan Cameron Jonathan.Cameron Kevin Wolf Konstantin Kostiuk Leonardo Bras Like Xu Markus Armbruster Markus Armbruster # QAPI Schema Michael S. Tsirkin Paolo Bonzini Philippe Mathieu-Daudé Richard Henderson Robert Hoo Si-Wei Liu Stefan Hajnoczi Wei Huang Xiaoyao Li Yang Weijiang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git b935385c35..eec398119f eec398119fc6911d99412c37af06a6bc27871f85 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 17 09:53:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 09:53:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330722.554108 (Exim 4.92) (envelope-from ) id 1nqttR-0008Mw-Su; Tue, 17 May 2022 09:53:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330722.554108; Tue, 17 May 2022 09:53:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqttR-0008Mp-Ni; Tue, 17 May 2022 09:53:29 +0000 Received: by outflank-mailman (input) for mailman id 330722; Tue, 17 May 2022 09:53:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqttQ-0008LF-1O; Tue, 17 May 2022 09:53:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqttQ-0007rc-0X; Tue, 17 May 2022 09:53:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqttP-0001wm-Kf; Tue, 17 May 2022 09:53:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqttP-0000HL-KI; Tue, 17 May 2022 09:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c+e76Sx3YgCpwUYvpmZPlGx3BKjml3/G8DFPXUDb5XE=; b=GvYlG8yCRXMa057EmSKwlc5CM1 60iPAeaIhiYgta7bZs87smUR8TCCbU9OTiTH1g0NnmabGmyP0Q6c9F4/X+GwBoCquhE0FYM4BMTyZ Tg6sGzLdyd8J/I1t1hYfCd8QDZCkZcrz3rW3ibrMHKCXV1MI/nlulfhZFu5lFeBccykU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170505: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 09:53:27 +0000 flight 170505 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170505/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 77 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1059 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 78 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 10:58:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 10:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330737.554119 (Exim 4.92) (envelope-from ) id 1nquuC-0006EG-UG; Tue, 17 May 2022 10:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330737.554119; Tue, 17 May 2022 10:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nquuC-0006E9-R5; Tue, 17 May 2022 10:58:20 +0000 Received: by outflank-mailman (input) for mailman id 330737; Tue, 17 May 2022 10:58:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nquuC-0006E3-6u for xen-devel@lists.xenproject.org; Tue, 17 May 2022 10:58:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 420179e6-d5d0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 12:58:18 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 97ABB21CB1; Tue, 17 May 2022 10:58:17 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5CD572C141; Tue, 17 May 2022 10:58:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 420179e6-d5d0-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652785097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UpU3PwW0+vEopHT6mwlEtKZnt5vjcj6K5z6p2RvwFDI=; b=A62HHwy96rt3Peh/2oQoJb/W5OQ8Z85j1RGtcSopCMAn7XlytDk/24zuEW9Tpga7/Yq/ue yQKQnkJYG61eGpGqLTfCCGX/srVGllxHF23XScgduJU8Byym34HyS4Bk1MWh3Z8Rwo0Y9Q s5hDkQjh35sYKTX8Zcjp7xwrzg3RpvU= Date: Tue, 17 May 2022 12:58:15 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Christophe JAILLET , Mihai Carabas , Shile Zhang , Wang ShaoBo , zhenwei pi Subject: Re: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-6-gpiccoli@igalia.com> <0a20dd06-f459-638e-cb4d-8255ab1a1f23@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a20dd06-f459-638e-cb4d-8255ab1a1f23@igalia.com> On Tue 2022-05-10 10:00:58, Guilherme G. Piccoli wrote: > On 10/05/2022 09:14, Petr Mladek wrote: > > [...] > >> With that said, it's dangerous to use regular spinlocks in such path, > >> as introduced by commit b3c0f8774668 ("misc/pvpanic: probe multiple instances"). > >> This patch fixes that by replacing regular spinlocks with the trylock > >> safer approach. > > > > It seems that the lock is used just to manipulating a list. A super > > safe solution would be to use the rcu API: rcu_add_rcu() and > > list_del_rcu() under rcu_read_lock(). The spin lock will not be > > needed and the list will always be valid. > > > > The advantage would be that it will always call members that > > were successfully added earlier. That said, I am not familiar > > with pvpanic and am not sure if it is worth it. > > > >> It also fixes an old comment (about a long gone framebuffer code) and > >> the notifier priority - we should execute hypervisor notifiers early, > >> deferring this way the panic action to the hypervisor, as expected by > >> the users that are setting up pvpanic. > > > > This should be done in a separate patch. It changes the behavior. > > Also there might be a discussion whether it really should be > > the maximal priority. > > > > Best Regards, > > Petr > > Thanks for the review Petr. Patch was already merged - my goal was to be > concise, i.e., a patch per driver / module, so the patch kinda fixes > whatever I think is wrong with the driver with regards panic handling. > > Do you think it worth to remove this patch from Greg's branch just to > split it in 2? Personally I think it's not worth, but opinions are welcome. No problem. It is not worth the effort. > About the RCU part, this one really could be a new patch, a good > improvement patch - it makes sense to me, we can think about that after > the fixes I guess. Yup. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 17 12:10:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 12:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330753.554130 (Exim 4.92) (envelope-from ) id 1nqw22-0006dy-NE; Tue, 17 May 2022 12:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330753.554130; Tue, 17 May 2022 12:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqw22-0006dr-JY; Tue, 17 May 2022 12:10:30 +0000 Received: by outflank-mailman (input) for mailman id 330753; Tue, 17 May 2022 12:10:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqw21-0006dl-7t for xen-devel@lists.xenproject.org; Tue, 17 May 2022 12:10:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56d902d4-d5da-11ec-837e-e5687231ffcc; Tue, 17 May 2022 14:10:28 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-YGrzqFWMNq6E67D25y4CgA-1; Tue, 17 May 2022 14:10:24 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6212.eurprd04.prod.outlook.com (2603:10a6:208:148::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 12:10:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 12:10:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56d902d4-d5da-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652789427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KyFlXyeZj0w1d0ytb3pft9xzbQ622Z4wOUPFhMFNN4=; b=FDYhtBsWGrccFPrqYaSC+2vwEgFas0VkvPSLP8gPgZsUgSeDBHTiTs7arOekMLQ0XeMajz Fi5PmSGWF/P5/EOPXEVKI5do0XTtOxGZexts52KKp/84e+S96QcA8CZLSxlgxRZjpq9kW2 K9gbbnDOZNh0Eznm+/4RljuuiMTsDx4= X-MC-Unique: YGrzqFWMNq6E67D25y4CgA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZMnvXYm8nt92Uo8CprFw4LTmGvBc1A8i6IZ8LYMkoiEB2eHoBmt4pBAUAIjKA0lvU3jpiUzMBNQ/8VVpf2ympDTnFcnWqRS2eWG+vg8TUDM1DcY5dJ/d05nt5xodg/ml+nYhCA9qRVYYVTo1z008orn1hKibhYrtjt+R0QUSiXOECwvHp2TSTqpgSUF+VwLnufI85wgmJSDpYKBQESFjJPl36CLsA+cwRJ3eD6aypSqLBe8UJYk16XryzNwZC4nfclStVlFjUns7OFIL40onLMYNd6vd7nr2BawORRUKl5bF3EC+Tfzj0oCvz9EHOEhoI+z6V/yOOY9RwpjeeCEAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wdqr8pGuGQEeW07KJbDB3s74JnBbr6SzGo6vipH58jk=; b=iqrjb3Op8nmYcnvo3PpSmSzqln71yXirANA6us/U/WevC3par85vYbZMeBTtZYgJIjNNYfM5PI6s+EgsQn7KCUhjzKz+YQf61hHcK6EZs9JVmz6oLSxtyIfGb3mF2umAjIaBRKVxZ4kh/JwMpOYL0emf5JT4VWD9SYvakUa1hGiZjA+rj+vGOYIsqsDyE2qmUkhyky7m6U9T61sXaBE/Hm6iT0Xke/DHYw3tAxdJiGPAboBrzAeiO3vDysMW4aArTX5wD7+oaO/aiwzeXq/cqsNjAVpaOG4i6SL7PS4HswCoF5jGR9dy95Seg937PtBLKzwkKPjNRJD9uX2cFUyzmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ba9bc92-6cb3-7d7e-150f-077c709acc3a@suse.com> Date: Tue, 17 May 2022 14:10:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-3-roger.pau@citrix.com> <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:20b:313::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9d77907-96b6-4f58-080f-08da37fe37e6 X-MS-TrafficTypeDiagnostic: AM0PR04MB6212:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A2U7Gp4iJ494LqSeHSQZj1X63ATk6L1DYeC+kAJsDIEeFzqZrOQguJFTdhSkTf9D4wOkrsSPbzSXLemzD8wFULcDz56gnnZNLnNa9ypQAvQA1rNmahbIng65oFSNjxHAXNQeNNn2RJ6G3FRpAkbyNwS/qQXOOoaBC3baLmXmVyfwgR/WZ7M/VckgMAgRMF+yz2NSHdLcgMro9WYa4EhHFJ9Kfe1iriCC121vZI/iwdrP5xIdJ0PXE9hpR+mEfgd19X+hC3h2UFPdawgjwnxAgFaaLagrz9H/HMWGRMVnH77nMe0catx2vDFF9PSDf+InIieVdGkcElri7SoNZuJ3wI/da5VIeyiyvn7YXfLmf3Id37QJCWvN7P9mgNZvFMOLU6dYfbJju0yATM9B2O2bOLdzWOaG96WOEVAeULnmb1ez6Q5DGFML9kZuHr/KRzrpJj4FY9D9fmpchqtba5xmq6PMAW2hRPq9lA+ei++QykECn3oTXTcODf2xLP7+DeT4bRepGsZMcVN2AQzurxft+u9P3tOXpCA9URfaaJ2uP/Kc8PB231RKxnxju/d/oDhUtSz3czysjGMelFxSbfrcMRTxNFUeeokAJl9wJ+tPou9UWq+ydP+OdXYbO3yYNNr4JPk5CS4lC+sBjG0OM2pTdMBLzGGGQdibA7CJcZerEH000Zn2nlLL1GTW5dEPJ9Y4Uh3lVi7qHY5S4qUUzJQlyvP67pqniuY8ZdQDzJurkvY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6486002)(508600001)(36756003)(2906002)(316002)(6916009)(31686004)(54906003)(31696002)(66476007)(53546011)(6512007)(26005)(2616005)(186003)(6506007)(66556008)(86362001)(8936002)(5660300002)(66946007)(8676002)(4326008)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7bowWNZSqd8YUUArFaNh63Mf2h5U1mYTJnqWk5PcW9jzp3B4pyOTXL/BSzeq?= =?us-ascii?Q?1dv49KQbwBwuPDIYaFMAThu7qGJlVQYvQQ+Cz7ddcZ3L6hm/jlpwd892mvSy?= =?us-ascii?Q?3xb7p6SlKdLTzJQQqKEZp4Uqw4caGPkLkt/t9i3qP8jRHcpreWpCTT/FbDHj?= =?us-ascii?Q?15wzlgbzm335oiX24Z9R9uGC6LL7XY9QEwim8XD2q/Bqtu5xiMUuw3a4Z/c7?= =?us-ascii?Q?ABVbDjF92G9ccl4888XjR4uTeAbfk+MaHPepDObUa4sXqxt+jRmdsLW9N+YA?= =?us-ascii?Q?7WelFk9wfsyKC3jsV0PS3tH8m/MjMjUTSEcm9sG/HhNZSnG+jUH2ClZZtuw8?= =?us-ascii?Q?Yf/QbXyQQFooLQgy8kleEcBU7mjD+hounZuCCeh6SCwwYHVLgYuHmcN1rtuc?= =?us-ascii?Q?OC6DdfhuX3S1D59lNY+nOffAu7xra5P/FefgRAVRSEczrZYvhokpk9mhfaRS?= =?us-ascii?Q?hUGFKV/kYjt3YUust8LidRSW64XmekaeY3ieMqq4lWRdGPTQ1ARQ/MKK0dqd?= =?us-ascii?Q?FlX24BFCDjj0zPRlALInM02jDK5BLihz4GaVvRYCC2UErPcbmKPr/oZzs3II?= =?us-ascii?Q?eZWvnAVP0xFebQ9L3uq41SI78i9IT8/Tu+xEzB4QmGfvOVdhwXmjjNOUtwdT?= =?us-ascii?Q?BNi90pf03L9BKWyqsHsTtpFIAesxcnn4EMs+pkWaAdRwHv7BxGHGpMZSZ3Jl?= =?us-ascii?Q?rik0uirpsR03d0Wfjh7NT4+p7bbGGl9LEZ/gLEodA9dzLmvQgq1mcdly13dF?= =?us-ascii?Q?YAIzV2ZfRIlVj5DbV7aPMO50i3OrZCxUIoR/LoX3xoID/CyDQdhNSXZrt5MM?= =?us-ascii?Q?K9eTpYLSdjgmQjiEjcIirorTYrmg7APhiqcruA5qDW/3TLpPANEln97cOkfF?= =?us-ascii?Q?gdH0rwWfJNL8Hyi1AK5O9zkv+e39R8Z4ak4nUKOhUau0548t7iR0wImePrO8?= =?us-ascii?Q?PMMwDQAqm/AHHdr605jiRyz4Z8WCFAgMHrJZGOc60/OusVFuMifGIgYUGkzH?= =?us-ascii?Q?yGq6GA2V2dPuWQ2xsL7DATUqAXITALbVSBpTvFNgpfxUd1BgnqsoEU/jQc8+?= =?us-ascii?Q?+7x6/K8dHBigdCZMkXhvGUQtKvmqanj8SncAIEBuPxaMCAQYHDxztpcayRF9?= =?us-ascii?Q?IHrraj5UtGpk3GoZ25QEntUm/+pm+9nYCavyhdLltEbqZliTSsCsNjAkW1cS?= =?us-ascii?Q?ielSPLvBCSLbD2RwXkS6HbVTWXTu+doS1/JfGX1NIQJgxW1nXtuG4xlobZY8?= =?us-ascii?Q?8IafH5YkHWeixLbFt76rJ3oI81RHlAnuCsYI5J7gP9uh6lJJHmb3vTAS+9iJ?= =?us-ascii?Q?zLIDBvSSk9RO7w3Zjg8p1XjZ2SNBK4Mm+3RtiqVARtGjM4X1ifM4xaMakITH?= =?us-ascii?Q?GZhJysGxAvZPolfUyv4U9/0VdarH1p6TcCcCfoCcQFMcgvRLzAvyfomO0VwC?= =?us-ascii?Q?luU0QfvSKvDe9iVtt66bpI8XpQUYzAzJg7zMQ3eDTuW/yRaFzj998rNqZqBs?= =?us-ascii?Q?gQoAVEWW7aKwxw0y9oeQHMZgJboNy4LrRmo6nwkuTK5UxtiFetOyJeBJ8WdD?= =?us-ascii?Q?DV//XyNSW7Dg2/dHCb+lQSV9jYn9gBd/mWQSBox6tagD83k33E8aXsjo/ZN8?= =?us-ascii?Q?xgrGEBqb4ZjIn8AX189is8ukrc8qeYzZyohNNBRIvckeddDXVNSJLi0SZhHd?= =?us-ascii?Q?ylOgMeK0COHx7KnOFz4hAs05xF8fmSAhGXoJE8KmfRwYaPruukOnMqmiTKzr?= =?us-ascii?Q?L+0KwJu2UA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9d77907-96b6-4f58-080f-08da37fe37e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 12:10:22.6639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9XWEmxH9yjl6MSVAs+gKRvuPregv07v0TKypSfFSg6rtJW/3IFuOYKMNPlodEIgTc418QkW75xcjmyrzyyN8EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6212 On 09.05.2022 12:23, Roger Pau Monn=C3=A9 wrote: > On Fri, May 06, 2022 at 02:15:47PM +0200, Jan Beulich wrote: >> On 03.05.2022 10:26, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/cpuid.c >>> +++ b/xen/arch/x86/cpuid.c >>> @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) >>> raw_cpuid_policy.basic.sep ) >>> __set_bit(X86_FEATURE_SEP, hvm_featureset); >>> =20 >>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) >>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); >>> + >>> /* >>> * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functio= nal >>> * availability, or admin choice), hide the feature. >> >> Especially with the setting of VIRT_SSBD below here (from patch 1) I >> don't think this can go without comment. The more that the other >> instance ... >> >>> @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void) >>> guest_common_feature_adjustments(hvm_featureset); >>> guest_common_default_feature_adjustments(hvm_featureset); >>> =20 >>> + /* >>> + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus >>> + * VIRT_SC_MSR_HVM is set. >>> + */ >>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) >>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); >>> + >>> sanitise_featureset(hvm_featureset); >>> cpuid_featureset_to_policy(hvm_featureset, p); >>> recalculate_xstate(p); >> >> ... here is about default exposure, so cannot really be extended to >> the condition under which this is put in "max" (except that of course >> "max" needs to include everything "def" has). >=20 > Would you be OK with adding: >=20 > /* > * VIRT_SC_MSR_HVM ensures the selection of SSBD is context > * switched between the hypervisor and guest selected values for > * HVM when the platform doesn't expose AMD_SSBD support. > */ I'm afraid this doesn't explain what I'm after. In calculate_hvm_def_policy() the comment explains why / when the feature is exposed by _default_. Taking into account patch 1 (where another maximum exposure of the feature was introduced), I'd like the comment in calculate_hvm_max_policy() to focus on the difference between default and maximum exposure (which could be as simple as "if exposed by default, also needs exposing in max, irrespective of the further max exposure below(?)"). Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 12:26:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 12:26:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330761.554140 (Exim 4.92) (envelope-from ) id 1nqwHq-0008Aj-2o; Tue, 17 May 2022 12:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330761.554140; Tue, 17 May 2022 12:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwHq-0008Ac-05; Tue, 17 May 2022 12:26:50 +0000 Received: by outflank-mailman (input) for mailman id 330761; Tue, 17 May 2022 12:26:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwHo-0008AW-2y for xen-devel@lists.xenproject.org; Tue, 17 May 2022 12:26:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9dae5524-d5dc-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 14:26:46 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-3dcvZGLeMMCn5MUllOHytg-1; Tue, 17 May 2022 14:26:44 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3551.eurprd04.prod.outlook.com (2603:10a6:803:a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 12:26:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 12:26:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dae5524-d5dc-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652790405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RigtmVJAaj7LtgR2N5DASSS8x7PC3xBRyj1auGWA05I=; b=ac8MzmpoDweZJ82ZzUtaFhxousq9t2XWIXyl7kp25ndLZCW+h1Wq10TQVhNcX2J7r6R9ru /g3Ne/jvDzN+Z5+zfIV5QYQ8pnWkezQsWC4bHV7IngA4KTO4kqH7YudR9U7WzjSs7XO/0K 1EvE0vxahPSs/ixnoZysz5f8VfBsFoY= X-MC-Unique: 3dcvZGLeMMCn5MUllOHytg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m42NSX0aThIhXtgKlEJPJIxMI0sIJoBeW9MSccWBAUpWPXwTBUbuPzCV5ObwbTnn/ewDYSLWerZcAS9Ynj/eyXdSoTuxmCc3u1+2eCsQFxFEmuWvbCDUSY72GriOIJuCmy1x28k7HLhevJLLGdhOgfrufo5bi4DhVxb5smOP3+pv0K6Vegfa11npgbybymmQ6sptXEsc7oKibuJOh6zW6Lud6A5BIZOeuj/GUBlT4LknweNZ0qyP63oDmerkN1AeJ1Vhh91NQePH/o9NBX2S+rLGSqWea93IQYONeKkZoaQCXU/kPDXxUbjcp7JEsGOv9MmUXu8pLI4pK4ioTPeGrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pvCzcvsTO1Q780HB0rcV6T6FU8XbCKVcE6SdRiW7EG8=; b=HkhGSVxvATQtNTVzfcX5A1hLBXW8TJatBuT6zwpyOV+Fxw2wa3ZTubJSxtDX4E7YBezxUzEbSz+023ofSW5LWJuKKSVYgi5WbNZYjMxSciMyJ/hX9/SN15+XlOSLZa3T5x9KwgQKsnhq2SIDSsyN3/NjrINmDGAAdQVUZfvZ/hhARpzehAG2hHS0XlsYV1W1gDFAAQ2WYisAxGyMv2fBeqn1eVyY4nhhvA+OMvsTnWcRT9rT0dCdUn/HII9Mqo+FUDJnkQs/BEPXnj3x4Sxyr6MlcdHufOJsCZ86ads5Yc+LqiK+vFQmDvVvRRSzwBszLroGua/GtTdpZuTqrFPrYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 14:26:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] build/xen: fix symbol generation with LLVM LD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220505142137.51306-1-roger.pau@citrix.com> <5cb23441-d8c1-5640-d630-30881841db0c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0049.eurprd04.prod.outlook.com (2603:10a6:20b:46a::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ca22ac5-f86e-4720-a7b5-08da38007f61 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3551:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XVOZk3on0+IISkOvaVRj/YXbrAknVy9kRyVLlCw0N0r+7ZHU0ctGtWTTywK2FCJCfDbLpBSxwpa/u2scbFF0f66M25AnxPxjLAJelRLw74Os4iVeTdMJEJDDRooHoF5T8H4iK4D8RSryToPharpO/Biw38eif+yaF5o+3SyRa0xhUSSzePWb+deL/StSh7xvtZukv3PxS0CXKS4rxOXylD9WE8G4eIBwVQo7XAgg/qxwzZSJn+5lu9vujRnbT7FWBkHcY14478UFK2emdY3sU4iTQNF1Gci1Bk1EyGPHISL8o6aSHRdpN87cSHYYeZ+CHYq00qW65TeZ+n3NdeJiOglM1pkuDX3UhhKBvObFEe3gG9ySQoNYSmPPP1kMtt6ftQdgMAiU83UY1TSzOKO5mCKtwMI3A+RsweTQjDgS7uLSiOdcQmOjxJAkoeolTmbIlJEenyOPVv/Dp4WFBeuODCU+cW+KZln45IlxQrAebvMNeCBNN3fzDmzLbZIC1xw3/l2WTMh9hV7oTJZlFoyvZlurP1JLF/DI3Cu/SrnJIMDabCQem05Jhdm5K+F84XEj0fHIuHsrVSfyK7lK+LAphBCIxEeQz3WGlj17FzieveDUaI7aHqrkVtoT1J3EXg6OegvuGUGmsyLvROrAvPVpzZcwyhJZNwzTZuAtk51Iz86rz0Y95N2uEE3PiJBgVYBiHiHGzVnBWpzk9B0etB31AazP1uKd1MDopRdJMvLOjnJs086t2Kq4cBI6KHqNRV9O+OA3xV0LTN3ANs+KVLuaf1cjLzcXlO2Bra9MfiyFaSlstHCbf47UUM9EkDVlDZdgM+twO6GhzR/1klRPLv78Gw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(66556008)(4326008)(36756003)(2906002)(186003)(2616005)(66946007)(54906003)(31686004)(86362001)(53546011)(966005)(508600001)(83380400001)(26005)(8936002)(6486002)(5660300002)(316002)(8676002)(31696002)(66476007)(6916009)(38100700002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YrFBAkwRYf1ltqh7Ra/Rntxf+fYLq9bhXzGWGOjKrQbUwYrtS5k/C7d9itnj?= =?us-ascii?Q?1i94mafvmGCCw9xqrdmQC5FJclz8r08OYiiqK3dcHaK1bjpFsE3QoIUEr45W?= =?us-ascii?Q?guTIS+0VsdyJrBHefkY76IxnSDO20BY3jiucYuGVpHGAMmvBcciDy+lotQol?= =?us-ascii?Q?04xZr+jgl+KDymxBHmqMC6UN2S9x1sc9/L9ysV4YLmVkOoPastf0nPIqlT7y?= =?us-ascii?Q?6rA1qgGMZLmYQvzKuTaWZYFO+PzfUTZoHn8mHU9EXSiAafrmeW319p/+Qslh?= =?us-ascii?Q?veL7EN3dBpaUB8VDULU8fRxhAdUUajwq6dTYp4ROkIzLGzI1js6BHMor0GEl?= =?us-ascii?Q?nEgTRTM4czUJ3BdP5QGBy/pp8JiclWSjrTq7Y2LXBezU3gSA+Oa8afhcOHh/?= =?us-ascii?Q?bg+1NUC+cp89lx97xPQjuEa03OyGUHckbffApEGYpzB30BR2u0qbICDCD/Pt?= =?us-ascii?Q?uNsbkjMzg/HYnA2UN6WXfJrRrE46MzlTmcQCCp/49oWDJB1ukydzd+lTLqV8?= =?us-ascii?Q?lADrqES/EUdxcONf80VN5k6mT+Lrq/IbvB/o+BLIcWecYT57Fp1OVaCusaHK?= =?us-ascii?Q?cuOZ+w5p4x7ZvH2cPBE21QFgsMFNnfSx+ev//sZlZI3RWZBTMM6TsPIfGZCj?= =?us-ascii?Q?vSzzrSA1ibQlolCSQ9AyhC1NuJP2Z18j47AbTtbiEv2XhzmcQdHrMNAlC6tT?= =?us-ascii?Q?siDsdBBTuix1ww4x3GTP6oMILRd02LD5bBco3WTl/9zF6BUB84FJZo/5saIg?= =?us-ascii?Q?EBCxjcdmiLPDcQVBbxUM/xHs/w06z8tT75aYLyVyd3no/cl/+UGLJO/9q+S7?= =?us-ascii?Q?ms6Yjm3GGZHpLsa9UZKNTJN+jhDMfJpHZkneZzsohoI4B+9hbNekQpImmu6U?= =?us-ascii?Q?rW5kepY7SvEx1NhdV6EJdYdm7nOJjk/68xxZFQ5/3kU5y29S+cJp6Bbf6/Vi?= =?us-ascii?Q?PA2aho/k3Nfw9Cwet5tKP+LVoO95JndGgD6Qg8pV4ILb52nOXpPsaOd6CLW9?= =?us-ascii?Q?e7QdGpWKwrD3PYKVibmFHcwvZB9fa6EGZ9yESjKIVbUwMmSV7WlwM/RgxAiB?= =?us-ascii?Q?J1D//NwTMH7Cmleje8YMRMFqbCZPHK1G3fiRBzTOh9nlqudC3xND75Cg82FF?= =?us-ascii?Q?bitevwgP/vxiFlw3X9Fe5d+dQLEmzloYkWSd1q2UNWVEGteNK87ffMyhVJbt?= =?us-ascii?Q?rJT9mxWVMok01MFr5e6Tl+hlZIDQotO7etENuQlj/P3Y3P3ZAcF/2HJp+YKR?= =?us-ascii?Q?1PxegYfod8I6LWwNZNzAa2j+r68karXkokHlggcO3a+vqCrawW/kFkCK7e0Z?= =?us-ascii?Q?0E0DIM6rFan8SHzh/cfPdjlt+VidyENN61anbU2W8eQ9pLJ5F/+kZOPWPOmU?= =?us-ascii?Q?rmagE7q7MqU9fnZfie1zmYvBC839dgsFIaxLD+nCbNJBb2oataCnK/tF3U9X?= =?us-ascii?Q?xzSlbuIyFFZx1X2LzSvVob8FC3IxJ31Cy6NdPEq3cOzhQq1AvJRRXvWEAqGa?= =?us-ascii?Q?TVng4/nEksfT/A00fRWH9mroYhHOCxSeOZzPAyGhcncX1qiOkMgms0ztX/aj?= =?us-ascii?Q?sFluPVWcrPXh9ks/puG6tCqsqSfitrmEz+tE3tE2aVjvz20A4iEY/bDk+fvN?= =?us-ascii?Q?M/y6z2Zpw+fW7s7ywsV7cZc+7gg7+Lybr38ahjK5owNngErlV+DuNrFYkYCL?= =?us-ascii?Q?hOrQAwAANBnejfyCXLP9V9V9MT2kYGeuJQkGUmnKUSE91rcIKlkympH2cDwa?= =?us-ascii?Q?fX9tJw9WNQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca22ac5-f86e-4720-a7b5-08da38007f61 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 12:26:42.1170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CjhOfH4M+rdRVzqFQ8/jGmuw7ytOVnjzfm4iy43amt2ThzUuLYGZUs6LeNS4O6ew0K0J9heit1j7Aa/1AG32Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3551 On 16.05.2022 10:01, Roger Pau Monn=C3=A9 wrote: > On Sun, May 08, 2022 at 10:34:43AM +0200, Jan Beulich wrote: >> On 06.05.2022 17:35, Roger Pau Monn=C3=A9 wrote: >>> On Fri, May 06, 2022 at 03:31:12PM +0200, Roger Pau Monn=C3=A9 wrote: >>>> On Fri, May 06, 2022 at 02:56:56PM +0200, Jan Beulich wrote: >>>>> On 05.05.2022 16:21, Roger Pau Monne wrote: >>>>>> --- a/xen/include/xen/compiler.h >>>>>> +++ b/xen/include/xen/compiler.h >>>>>> @@ -125,10 +125,11 @@ >>>>>> #define __must_be_array(a) \ >>>>>> BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(= &a[0]))) >>>>>> =20 >>>>>> -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE >>>>>> -/* Results in more efficient PIC code (no indirections through GOT = or PLT). */ >>>>>> -#pragma GCC visibility push(hidden) >>>>>> -#endif >>>>>> +/* >>>>>> + * Results in more efficient PIC code (no indirections through GOT = or PLT) >>>>>> + * and is also required by some of the assembly constructs. >>>>>> + */ >>>>>> +#pragma GCC visibility push(protected) >>>>>> =20 >>>>>> /* Make the optimizer believe the variable can be manipulated arbit= rarily. */ >>>>>> #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) ) >>>>> >>>>> This has failed my pre-push build test, with massive amounts of error= s >>>>> about asm() constraints in the alternative call infrastructure. This >>>>> was with gcc 11.3.0. >>>> >>>> Hm, great. I guess I will have to use protected with clang and hidden >>>> with gcc then, for lack of a better solution. >>>> >>>> I'm slightly confused as to why my godbolt example: >>>> >>>> https://godbolt.org/z/chTnMWxeP >>>> >>>> Seems to work with gcc 11 then. I will have to investigate a bit I >>>> think. >>> >>> So it seems the problem is explicitly with constructs like: >>> >>> void (*foo)(void); >>> >>> void test(void) >>> { >>> asm volatile (".long [addr]" :: [addr] "i" (&(foo))); >>> } >>> >>> See: >>> >>> https://godbolt.org/z/TYqeGdWsn >>> >>> AFAICT gcc will consider the function pointer foo to go through the >>> GOT/PLT redirection table, while clang will not. I think gcc behavior >>> is correct because in theory foo could be set from a different module? >>> protect only guarantees that references to local functions cannot be >>> overwritten, but not external ones. >> >> Right, since there's no way to tell the compiler that the symbol will >> be resolved in the same "module". >> >>> I don't really see a good way to fix this, rather that setting >>> different visibilities based on the compiler. clang would use >>> protected and gcc would use hidden. >> >> If gcc's behavior is indeed correct, then moving to protected with >> clang would set us up for going through GOT/PLT there - either right >> away (if the implement this like gcc), or once they correct their >> behavior. I don't think we want that. Therefore I think we want to >> alter visibility between compilation and linking (i.e. presumably >> right in prelink.o), going from compile-time hidden to link-time >> protected. That would likely be closer to what your original patch >> did (sadly there's no "convert to option >> to objcopy, and making it have one wouldn't really help us here; >> it's also not clear to me whether llvm comes with its own objcopy, >> or whether they re-use GNU's). >=20 > So I've raised the difference in protected behavior between gcc and > clang: >=20 > https://discourse.llvm.org/t/gcc-vs-clang-differences-in-protected-visibi= lity-implementation >=20 > It's no clear to me whether clang would switch it's implementation, > but it also seems fragile to rely on global protected function > pointers not going through the GOT. I agree, and I don't view it as likely that they would change their code. GNU objcopy offers a separate step for that conversion (--localize-hidden), but .. > Do you have any recommendation as to how to change symbol visibility? > I've been looking at objcopy, but I don't seem to find a way to do > it. ... kind of unexpectedly doesn't offer means to alter visibility. So I guess you/we need to turn back to your original RFC approach, no matter that it wasn't really pretty. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 12:27:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 12:27:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330768.554152 (Exim 4.92) (envelope-from ) id 1nqwIM-0000EM-CS; Tue, 17 May 2022 12:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330768.554152; Tue, 17 May 2022 12:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwIM-0000EF-9J; Tue, 17 May 2022 12:27:22 +0000 Received: by outflank-mailman (input) for mailman id 330768; Tue, 17 May 2022 12:27:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwIL-0000E1-3c; Tue, 17 May 2022 12:27:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwIL-0002Ml-1C; Tue, 17 May 2022 12:27:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwIK-0001AD-L1; Tue, 17 May 2022 12:27:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqwIK-0000sm-KZ; Tue, 17 May 2022 12:27:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dbyVNNRSh6lmIWj1YtMSTjmO7NjAnHoGOFkb3pRhkrs=; b=Y2cLLkNgWXspEHadagaWx2YxxS CjXxSYQeiE8p5gDGkCFKKHeAvEVp2hI7l8ASUsJiJ6xamFXebWXXNTJlTPy3F18BcjYW9WxH54x8g snbXR70zP+AzeNRrDCKPUWgvQzyu4w9BKq+wn3KPsFb83G7xL3ywXVIyirPAlnP/s6D0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170506: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 12:27:20 +0000 flight 170506 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170506/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1060 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 79 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 13:02:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330780.554162 (Exim 4.92) (envelope-from ) id 1nqwpy-0004TD-8V; Tue, 17 May 2022 13:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330780.554162; Tue, 17 May 2022 13:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwpy-0004T6-57; Tue, 17 May 2022 13:02:06 +0000 Received: by outflank-mailman (input) for mailman id 330780; Tue, 17 May 2022 13:02:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwpw-0004T0-T7 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:02:05 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89434b6b-d5e1-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 15:02:01 +0200 (CEST) Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:01:30 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB3868.namprd03.prod.outlook.com (2603:10b6:5:4f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 13:01:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:01:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89434b6b-d5e1-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652792522; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=PmGAu3To+r0VqrZy/1vSLw336a2IvCKZaoKzqd0KYnM=; b=VWOPFnm13Zc8gDk2gFulJtPbPlbtW6AddvI4T7L3mm2y91QI44qopn0p Q9NvJGzzHpbobQrO35S1gDM7obQtLYpqmrgXnzk9r6Hxmxh4g3Tr/5HVQ h1xSrhluw1idkHmdUiZxfwnb+HCwmT7MVCyZmJxEZLDFxPGT7EhopzhdK c=; X-IronPort-RemoteIP: 104.47.55.107 X-IronPort-MID: 70865611 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:J3OTe6k/Cpw3+0SZkyYjthno5gwnJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJXT2Aa/mJZWDyKYxxbYSw8UgE78eEm9UwSFM+ritnHiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWlzV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYZDoHDvfpgLghbhxUSx9kG4hKx+DYGC3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhGhYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVvszaOklUouFTrGIDnJd7RZplcp3yzv 0Hh7XjaBQkqMsPKnFJp9Vrp3IcjhxjTXJ8ZHfu2//hhjVmX20QaEhhQXly+ydGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9BdCfEg4QeBjK/d+R+EB3MsRyRELtchsaceWjErk FSJktXBDCZq9raSTBq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbjA/LT9tlOL64iJvyAz6Y6 w6NqC8ylrACl/kh3q+w/U3Eqz+0r52PRQkwji3VVG+46gJyZKa+epelr1Pc6J5oM4KxXlSH+ n8elKC27u8UCoqWvDeQW+hLF7asj96JPjTTjl9oG5gJ7Cm29jioeoU43d1lDEJgM8JBfCCzZ kbW4FtV/MUKZCTsarJraYWsDchs1bLnCdnuSvHTaJxJf4R1cwiEuippYCZ8wlzQraTlqolnU b/zTCpmJS9EYUi75FJan9sg7II= IronPort-HdrOrdr: A9a23:LD+2nKH6fHQ8PoUnpLqFsZLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNJICPoqTM2ftW7dySSVxeBZnMbfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj3Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnZ4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlXFtyssHfrWG1SYczHgNkHmpDp1L/sqq iLn/4UBbU315oWRBDtnfKi4Xi57N9k0Q6e9bbRuwqenSW+fkN6NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjx0C3fLFuHoO5l7ZvtX+90a1wbh7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm1kxR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XX50vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLqzNV1wg2TwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISedrP8M= X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="70865611" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=II68kr5dxV2hNeY4myBJ5pwZelRvbOozwEdowV/tJ5EHqcbBaBw+Y9XVFxbLNomaKHKmrstLv45E12k5QUQoTmnoKD6rZn5YOYUzkHdi4R0J0a1hT3kikhHNRNLMlk3MlQ4je8FNQ67B7fguAbjwMDJ5Ye+jtzDtjgiAbX0RD81YKnRE+Yva8RW16PQSJtVYPvy0lhXT2qk6AJeVbjdz3V1cvc+odWeBiRWy5JAtA++Up2VyMQdFpqQqwEYJt1nFCnwqMpcBcqAGwmjMyqc8cMUnzoiK1PmCe+HmTmvLpRdjP0TNcwJ/KcVw1y4xU/bu1/WVLGoLpgG7T1ZcN7Zezw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PmGAu3To+r0VqrZy/1vSLw336a2IvCKZaoKzqd0KYnM=; b=Bx9ydMzx+E33C+4rxKSo5d04QfjgGzf40LU83QBigUxTQEWCQI8ynbHmUMMHzu0cd8eWSTet+Ht9eH8go9BPstonuDcXsRpreUOpKHic+lWicCDBh0x7hyJJDdmlHuoRn7ItMsxtFvE79LrnLhTUX/nb+T5Wr4+i4QQ1A9x85HoRgtxMkYeZv2M1pCYywFRMYxuvrFkHKC/pixOdFnhCXFbc+SA6ThUZ6mNrUoAlfRFpJHksUZLr4nhQ6+saTM9pviL520fWhlrGC/laX+Adw4Tx312xK4n1PEjnEtSJBodDagVllee/f8W/S4V/4KVfS8RhRAzUUs/HWvEUvgBwTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmGAu3To+r0VqrZy/1vSLw336a2IvCKZaoKzqd0KYnM=; b=b68yC/eyZJl5koiCu2mPwfejJq6gNCnAQSfneulwmFEUX6zHZwQfr3gPAX5nbKAVzYV/qEBQ3PvosqT5UC7csC/HWSWdeAVCwUet7STQFoEHPczTzjhkE5Iaeu8EVQSK//NOaIQDXPk3cIOChUriOWQJRNUCbnSKwohaLnq6Z5o= From: Andrew Cooper To: Luca Fancellu , "xen-devel@lists.xenproject.org" CC: "bertrand.marquis@arm.com" , "wei.chen@arm.com" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Juergen Gross , Dario Faggioli Subject: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Topic: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Index: AQHYYUDliIUtXuVlFEquWiHjLJV14a0jGe8A Date: Tue, 17 May 2022 13:01:28 +0000 Message-ID: References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> In-Reply-To: <20220506120012.32326-7-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 588663b3-cdf8-40e4-088c-08da38055b74 x-ms-traffictypediagnostic: DM6PR03MB3868:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 93Pi6CEkhhzWA5TIPdE4HkuE/xVFHiCkN/vT/flIcG5s4g4iy+EplgmwdbtTjapindXincYOTOUI8q9VV4sAn0LZbAE4AN/XS6RGpOBR44yMSSkaYXw6N/uabl12X0PiUhbQ5QbuIcV6KEng0BzzRSajqpRHW8KQgNSb2ZFH60wXwPC21TpLPi7vBYiq2rUKo87EEZ9xdjsDfZN5ePF4oZH54PkA8WqwfVjCc6Ti85YYgXIwRkihD7MQyMyy3m79jr+QLrzzbz2+F8gBWyBuqIVx7xqvFzqrg2ocHwNqo/RviS/X0vGpbQ6lf5WIhBFrEQQfzYMsWDcl6nWovkqnoCQ1/TxJ9nKO9S8BsVI/4iB2oOGNGqYIkHDXoe1goB5IJrZGzbL+1CGNADtZ4YvmAdZh8O0DveRm5CkXr59UnRsnGSi2+PVo2PkVmj6y014RK8DRQvdnUQuRYFVfkKlqFHwy4wO4xY09QpMRx+Nw/3K3g5HzgMXmqoQH49K3jw7G0TYYMnaCE1kx16inaVWGOWtcqMf4Zm3iLPHHu1iS/EUt6OKOg3DuK83fbkPDPIIZYjGdnxexs/WG7KG8J84njtXWEPq6hdbspQofpvwjdkkt+7QrsfT4gxCJgqj6Mio+rwFGa7ZifktAaU4uEXtj3PJUC7LW67UXHGUyCO296qNGmChQ2pFsYZkbKCOHCXZgb0f3EDzotd0fPyMdUqsCefjQPX1fCD1YAlIpnIwN5fRhdebAH0lk9WelG4hyn3iT7L+DKnd+PLiTHaWo8k/BqIRP0qW98sFFU9wcTQEmPKM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(64756008)(66946007)(316002)(66476007)(66556008)(8936002)(8676002)(122000001)(86362001)(6486002)(36756003)(4326008)(4744005)(91956017)(76116006)(31686004)(5660300002)(7416002)(2906002)(2616005)(186003)(82960400001)(26005)(38100700002)(38070700005)(71200400001)(6512007)(31696002)(6506007)(83380400001)(508600001)(53546011)(54906003)(110136005)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NW1xK0sveHdCMGd4bFIrR0tHT0lXSkdUQ1R2VGgwMUszNnVYOWltMUtpbHA2?= =?utf-8?B?dnNBYThsYnVEQmdOTmZncllUL2R5ZHgrYmQxSDM1NGdoOHNsK0RTQWN5K3Jz?= =?utf-8?B?WU5kS0pUTXJja3hOQlhtK2YvRlIzRzc1K0Q2N0tBOW9IOHkxTWt1ODVCWXNP?= =?utf-8?B?c1VKZy9sTnB1dm5ZN3NQSGpseVdVWEwzZldwV3hLV1hPV0RpRlF1S1pQNTcy?= =?utf-8?B?MENnNENyVVlsdHI0WmM4WGk3QVdia0ZnbE5DSVdvLzV1WVFIa1VzWjFXdStx?= =?utf-8?B?QVc0Zm5VcHZtM2kzZTdIanQwYkxhLysxZkttbWZyTlltWVV0TUpnR1RDOVBu?= =?utf-8?B?QS94QWFXN0ozWjZBSERHakFFeSs3RnFxakpuSUhVMnM0cGdhM2NIRmpQZDda?= =?utf-8?B?MlZMR1hTdEkrdTBlajBMRlNlS3FYZHl2UGxHa3hCVHloRzJKWUNBWkhNbkxF?= =?utf-8?B?aWhCUlFWMWxYSld5Y3h4eVlNeHpZT08zakFRMUlKTVF1OGJvWUU3SGFMVC9K?= =?utf-8?B?K25tUmNzdWkweUxRSWQ2a0pObkdHYlc3NW9FOGxUOW5lNVoybEJVSGxUcjBI?= =?utf-8?B?R3BJNU1LdjdhTmttUEo4UEh5eEVwK1kvNWlia1lEc05CTFM1N1hpWHhOQVlC?= =?utf-8?B?RGhIb0V3MlN2V0V4Vjk4NFcyWC9CdXA5eVZlTlpyMjlibVlzMUhma1NVVnRE?= =?utf-8?B?S3F3dHB6cXJhZWtDMEtycXZXaXlGenJkVHZqTXlmd0sxZ2tqZjIvaGMxUGhw?= =?utf-8?B?bllnU25CbHhmRFVEWGVqNTdBM0lCdk5rWWtXcG1tVnc4WkZ6SmJybDk3bkhk?= =?utf-8?B?bkppZGE4dUJRWTZjRjdzOFQxZVpFaXJ1djQwTFJXUE5CSHRteVZuTkllcU1H?= =?utf-8?B?T29Pb1JSRWxVckY1M1B4TCtPbHhkN1F6VkxmUnIrMFozR0NVYW9ENWFsVU1h?= =?utf-8?B?ZTREK1YyMkJKNWs5MUMrczZHZHNMV3orWDRid1k3dEI1UVFpbFpDaFFtMk0w?= =?utf-8?B?NGttM1h5Vmx6djFxSm9EOXp1TlVyS3YwL1Fsb3dhcHI5cjJueG50SVFhb2lp?= =?utf-8?B?UXR5MW9ndG9rWnVXck1ZeXBNQWJYZWFoaHhtdUhROEw0aVd2T2JVVWlzNW5C?= =?utf-8?B?ZHRmSmhOd2YvVWVDZmRwTElzRVJ3TFdXZHFLRHRrS2FIOGptM3JHNEhoOGMy?= =?utf-8?B?aCtSYW5EQjFiMkJEVjcyU3h6eU5wM1NlL3hpNGNPaVlSUm1ZNmVWdmRINEsy?= =?utf-8?B?R1IvZlJoMnp5bXlCcEo1WS9xMDI1WHFRUDZRYXk5a0hzbnZFZlNiaVdheXNo?= =?utf-8?B?SElLSDdzdmJlWXVHTmw0MFZXclNZVG9sbEFmcEpQZEVTdVY5RG5sQ284ZGc4?= =?utf-8?B?Mi9Wempsb1gvUlFyUWtYV2Y2OUV3OGJsb0dPckM2dDNHU3pTL0NESUJuTWlU?= =?utf-8?B?Z2lLaUVSSkgvd3piVC94WWhHbkRFWnNSRGtkZGtSdnY3M0c3MFNsRDJSbUR2?= =?utf-8?B?aWZONUh0eTBnaEw0WUFmZUF6b1IwQ1FKTFM0OHdtdHdlN2o3VWhJb0YwbUxj?= =?utf-8?B?OVBBbys0amtpUEwxVjcvNXZsd3VIM2JXc0ZZUWV1Vk5UVUVvellJcE04WDVP?= =?utf-8?B?SGtHbS84aVlHMkx5eEdaMWdUSjJ6VHZvN2F4L0RHWGZTc0xYRnJTUDNVMjUw?= =?utf-8?B?cVJYb0lxTE1JSG5oVzRuRVNrVWVQdEVHK0Q4dzEwcTdPWHpZMTJqRTFReHYz?= =?utf-8?B?QVJWMjlNOW85L1BuYjZUWUZpc1RYS3lCQnBrOFBDUWZiSkthNUlSYmtlelZN?= =?utf-8?B?M0xGU1VjUTl5NUIwakFtL1phTUxrZndBb01mMEIzUE42YW5DdDRyNDR2VjBO?= =?utf-8?B?MldyU3lxRUhFdFZpTW9UU21kaGx2bExYQ0toWDdmWWxVdjllZGtwUnIxVGlI?= =?utf-8?B?cDlDUSttWjFMeVBYTWdTeFYvUjlreFJXOERGeGlMQWtoK3BIRUxublQyYjc3?= =?utf-8?B?M01PcVA3OVdJTUpnMzJzTS9kT2t4dktaUjdtQjNoa01OS1lnc0JaVTlzbk9Q?= =?utf-8?B?U1F6bkdzWkhBR2xzNnVPaHMwcldiWkVWWWNMQVJGYUE0dnNJaC84U21FOW1j?= =?utf-8?B?T3JCME9SNzRWcFQrQzdDSEZuRW5vaUlXK1lrMG9SWTFsbVYvNndzWHBReFpR?= =?utf-8?B?QThDaDVPQnRlUHQwaUZPQmxSTEt0S0REaWhuV0txSjhldHBuTGVtVVR4Yzd2?= =?utf-8?B?dENJZTV3VXBZS0diSTR1RGEyN2NnMmRHN1BJUlBLejZNRDVtYTVQaExGN25N?= =?utf-8?B?WHF3N0JCSHJsQWpPZk9hcGtSM3JEU201QUxOaFdPS2txRmlUVkhWWjBSZHRq?= =?utf-8?Q?FgDrw+rSzcSTgZOk=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <921372DD79D082439B630053451849DF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 588663b3-cdf8-40e4-088c-08da38055b74 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 13:01:28.6200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lITLACIeqBIJEEg1YOEEEQrqMfF1yO9xU64zeYBd6P73lhC84cP56xDKURApa1+j6SB2bVinRO4qHep1cospv78vBr8AEoJ3QsWs+h4MRt0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3868 T24gMDYvMDUvMjAyMiAxMzowMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4gSW50cm9kdWNlIGRv bWFpbi1jcHVwb29sIHByb3BlcnR5IG9mIGEgeGVuLGRvbWFpbiBkZXZpY2UgdHJlZSBub2RlLA0K PiB0aGF0IHNwZWNpZmllcyB0aGUgY3B1cG9vbCBkZXZpY2UgdHJlZSBoYW5kbGUgb2YgYSB4ZW4s Y3B1cG9vbCBub2RlDQo+IHRoYXQgaWRlbnRpZmllcyBhIGNwdXBvb2wgY3JlYXRlZCBhdCBib290 IHRpbWUgd2hlcmUgdGhlIGd1ZXN0IHdpbGwNCj4gYmUgYXNzaWduZWQgb24gY3JlYXRpb24uDQo+ DQo+IEFkZCBtZW1iZXIgdG8gdGhlIHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIHB1YmxpYyBpbnRl cmZhY2Ugc28gdGhlDQo+IFhFTl9ET01DVExfSU5URVJGQUNFX1ZFUlNJT04gdmVyc2lvbiBpcyBi dW1wZWQuDQo+DQo+IEFkZCBwdWJsaWMgZnVuY3Rpb24gdG8gcmV0cmlldmUgYSBwb29sIGlkIGZy b20gdGhlIGRldmljZSB0cmVlDQo+IGNwdXBvb2wgbm9kZS4NCj4NCj4gVXBkYXRlIGRvY3VtZW50 YXRpb24gYWJvdXQgdGhlIHByb3BlcnR5Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNl bGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQo+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQoNClRoaXMgaGFzIGJyb2tlbiB0aGUgT2Nh bWwgYmluZGluZ3MsIGFuZCBpcyBjb25jZXB0dWFsbHkgd3JvbmcuDQoNClRoZSBjcHVwb29sIHRv IHVzZSBpcyBhIHByb3BlcnR5IG9mIHRoZSB2Y3B1LCBub3QgdGhlIGRvbWFpbi7CoCBJdCBpc24n dA0KbGVnaXRpbWF0ZWx5IHBhcnQgb2YgY3JlYXRlZG9tYWluLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue May 17 13:04:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330788.554173 (Exim 4.92) (envelope-from ) id 1nqwsK-00054Y-Oa; Tue, 17 May 2022 13:04:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330788.554173; Tue, 17 May 2022 13:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwsK-00054R-La; Tue, 17 May 2022 13:04:32 +0000 Received: by outflank-mailman (input) for mailman id 330788; Tue, 17 May 2022 13:04:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwsI-00054L-F4 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:04:31 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e20633ec-d5e1-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 15:04:28 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqwrY-008RNM-0M; Tue, 17 May 2022 15:03:44 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e20633ec-d5e1-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7k65fdRTQg/wflBs9f0TJRvKoWTammEy4iwKmtzcPs4=; b=OpLRZBE1TUxWd4SJevol7qmbWp 7cf/63XEfW1McNr9yfxJ/wNA5PzTA6GfEDtrBWeHePG4UP9vT004IKq/Y2n1Wdo9PCU8d40cNtPr7 evvA1G/GsHzDMrD3kL1RWnjHzehDzDywj5u53TN0tmnpdWb3jYfL8mY4Uh+43rmflK1PctID/9pFc ZvUCbSUysCdoW+hfAZNQhZbT4OFisfS/H/quOUTTDHZ+I5zaEEC4729JtousRNxBxXebYRI1Dcqzp PvSzoHit05E/cq1DK95qfXV5U60l7efTEeM0sV+06rVod3szWCADFSxvFodt56BQEE6VcTzDLc2Bf FOG6Wfyw==; Message-ID: <53ceb2c7-f2d7-3b92-4efa-a063487585bc@igalia.com> Date: Tue, 17 May 2022 10:03:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 05/30] misc/pvpanic: Convert regular spinlock into trylock on panic path Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Christophe JAILLET , Mihai Carabas , Shile Zhang , Wang ShaoBo , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-6-gpiccoli@igalia.com> <0a20dd06-f459-638e-cb4d-8255ab1a1f23@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 07:58, Petr Mladek wrote: > [...] >> Thanks for the review Petr. Patch was already merged - my goal was to be >> concise, i.e., a patch per driver / module, so the patch kinda fixes >> whatever I think is wrong with the driver with regards panic handling. >> >> Do you think it worth to remove this patch from Greg's branch just to >> split it in 2? Personally I think it's not worth, but opinions are welcome. > > No problem. It is not worth the effort. > OK, perfect! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 13:08:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330797.554184 (Exim 4.92) (envelope-from ) id 1nqww0-0005iu-8X; Tue, 17 May 2022 13:08:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330797.554184; Tue, 17 May 2022 13:08:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqww0-0005in-5N; Tue, 17 May 2022 13:08:20 +0000 Received: by outflank-mailman (input) for mailman id 330797; Tue, 17 May 2022 13:08:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwvy-0005ih-TZ for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:08:18 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b090e1d-d5e2-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 15:08:17 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 623321F88E; Tue, 17 May 2022 13:08:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D75C13AA2; Tue, 17 May 2022 13:08:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4eHzAUGeg2IqKgAAMHmgww (envelope-from ); Tue, 17 May 2022 13:08:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b090e1d-d5e2-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652792897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z2X+dWmW4qKk1Omh9IGkzJeCFLP+bmUHDbneLtJzaIM=; b=MNXYKYMrj7OjU2uaHxXw4zzElf+6m9LS0giVYc2sDErtL7RwbtRiQZisR3yBX2U2g+ipy6 voZuM7Juaj9eQO9TxGLEvfDPqqf7svOcJztUbFSqJZIMl9s0ORcXTDLHiyT8XCm0gTNlCq j6k/XTYZXR4q9QBWUFVhBXAJzzWRrqc= Message-ID: Date: Tue, 17 May 2022 15:08:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Content-Language: en-US To: Andrew Cooper , Luca Fancellu , "xen-devel@lists.xenproject.org" Cc: "bertrand.marquis@arm.com" , "wei.chen@arm.com" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Dario Faggioli References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HZCuOs24YbxrBd6jU7GCSObh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HZCuOs24YbxrBd6jU7GCSObh Content-Type: multipart/mixed; boundary="------------xG1vAtTagHOH00IiOvW02PHg"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Luca Fancellu , "xen-devel@lists.xenproject.org" Cc: "bertrand.marquis@arm.com" , "wei.chen@arm.com" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Dario Faggioli Message-ID: Subject: Re: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> In-Reply-To: --------------xG1vAtTagHOH00IiOvW02PHg Content-Type: multipart/mixed; boundary="------------ueL1SpFutTJM6oQ2rISvCl16" --------------ueL1SpFutTJM6oQ2rISvCl16 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDUuMjIgMTU6MDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA2LzA1LzIw MjIgMTM6MDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiBJbnRyb2R1Y2UgZG9tYWluLWNw dXBvb2wgcHJvcGVydHkgb2YgYSB4ZW4sZG9tYWluIGRldmljZSB0cmVlIG5vZGUsDQo+PiB0 aGF0IHNwZWNpZmllcyB0aGUgY3B1cG9vbCBkZXZpY2UgdHJlZSBoYW5kbGUgb2YgYSB4ZW4s Y3B1cG9vbCBub2RlDQo+PiB0aGF0IGlkZW50aWZpZXMgYSBjcHVwb29sIGNyZWF0ZWQgYXQg Ym9vdCB0aW1lIHdoZXJlIHRoZSBndWVzdCB3aWxsDQo+PiBiZSBhc3NpZ25lZCBvbiBjcmVh dGlvbi4NCj4+DQo+PiBBZGQgbWVtYmVyIHRvIHRoZSB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFp biBwdWJsaWMgaW50ZXJmYWNlIHNvIHRoZQ0KPj4gWEVOX0RPTUNUTF9JTlRFUkZBQ0VfVkVS U0lPTiB2ZXJzaW9uIGlzIGJ1bXBlZC4NCj4+DQo+PiBBZGQgcHVibGljIGZ1bmN0aW9uIHRv IHJldHJpZXZlIGEgcG9vbCBpZCBmcm9tIHRoZSBkZXZpY2UgdHJlZQ0KPj4gY3B1cG9vbCBu b2RlLg0KPj4NCj4+IFVwZGF0ZSBkb2N1bWVudGF0aW9uIGFib3V0IHRoZSBwcm9wZXJ0eS4N Cj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFy bS5jb20+DQo+PiBSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGlu aUBrZXJuZWwub3JnPg0KPiANCj4gVGhpcyBoYXMgYnJva2VuIHRoZSBPY2FtbCBiaW5kaW5n cywgYW5kIGlzIGNvbmNlcHR1YWxseSB3cm9uZy4NCj4gDQo+IFRoZSBjcHVwb29sIHRvIHVz ZSBpcyBhIHByb3BlcnR5IG9mIHRoZSB2Y3B1LCBub3QgdGhlIGRvbWFpbi7CoCBJdCBpc24n dA0KPiBsZWdpdGltYXRlbHkgcGFydCBvZiBjcmVhdGVkb21haW4uDQoNCldoYXQ/DQoNCkFs bCB2Y3B1cyBvZiBhIGRvbWFpbiBhcmUgYWx3YXlzIGluIHRoZSBzYW1lIGNwdXBvb2wuIFRo ZXJlIGlzIG5vIG9wZXJhdGlvbg0KIm1vdmUgdmNwdSB0byBjcHVwb29sIiwgYnV0ICJtb3Zl IGRvbWFpbiB0byBjcHVwb29sIi4gU28geW91ciBjbGFpbSB0aGF0DQp0aGUgY3B1cG9vbCB3 b3VsZG4ndCBiZSBhIHByb3BlcnR5IG9mIHRoZSBkb21haW4gIGlzIElNTyB3cm9uZy4NCg0K DQpKdWVyZ2VuDQo= --------------ueL1SpFutTJM6oQ2rISvCl16 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ueL1SpFutTJM6oQ2rISvCl16-- --------------xG1vAtTagHOH00IiOvW02PHg-- --------------HZCuOs24YbxrBd6jU7GCSObh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKDnkAFAwAAAAAACgkQsN6d1ii/Ey+H uwf/aM1GkyiHdEWN1tCwD+0Jon//DOTvXHgVNnyy68YaQP6pnQMOqgIr4D8bjHMiN6e9siazTvtf VYE/0aBwasKXsFJRDBj5/YEQR+gpSrutMFjQ/ERHqPSW+bHgQz7a4/lJyzO2mZeLw+Ki8xmx3GdT qsqyKSTU1iQu3kiGGNv31UMB31Ay9i2MtAevl1Io1Z2etE8U2ldwWVmGc6neb6y1bbOpq30unWs6 KvowsXKP2PJEdniLiKUZkfIX9D1NHS+oZpv+yr87hN3lH9rEM0F3vyJQ5MOJw9KJ7hPkjKCQsH0Q piwypKY8m7tx22pDTnzJR1l3kH6j3kPNlOwlFAPLMg== =qjif -----END PGP SIGNATURE----- --------------HZCuOs24YbxrBd6jU7GCSObh-- From xen-devel-bounces@lists.xenproject.org Tue May 17 13:10:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:10:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330806.554196 (Exim 4.92) (envelope-from ) id 1nqwyE-00077z-QA; Tue, 17 May 2022 13:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330806.554196; Tue, 17 May 2022 13:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwyE-00077s-N9; Tue, 17 May 2022 13:10:38 +0000 Received: by outflank-mailman (input) for mailman id 330806; Tue, 17 May 2022 13:10:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwyD-00077k-Fr for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:10:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb89a2c0-d5e2-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:10:35 +0200 (CEST) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:10:30 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5639.namprd03.prod.outlook.com (2603:10b6:5:2c6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 13:10:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb89a2c0-d5e2-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652793035; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eCxM8VEeRLSTlOrps4UsKuiPVOCRAxFgQJr/oYzyezM=; b=PHDQOiPRMdnhXxSQ8kWzn56lCE3RR+aBKb8fpIq/1iVbEXMSGZLpNEYd phBQpEvb1OhyCRYfR645/xxHEZDyw6GwLgtP4BtfOxuT3Rq0+A3/Db2fG B3IPSBl4DYkAEX89geDcoGJ8IppVFGo83+wvHmuWVB0sVHhuo5ecWeWr7 8=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 71483780 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cyBQjaqxNSLe3NxHto0YHqPUxf5eBmK/ZBIvgKrLsJaIsI4StFCzt garIBnVb/6JYWrzcot+aY6xpkwF7ZHTy9cyHVdpry1gESMb9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 Iyq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBP5/0v802XwBhPX9FPIhM+q6YLFqmrpnGp6HGWyOEL/RGKmgTZNdd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgXFp2Zgm8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeKkFwqj+i1WDbTUsKWdMlStRa4n FnHxn/iWR0QOcaY+wPQpxpAgceKx0sXQrk6EKCz/7hkiVuYy2gXFTUfT179qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+c38h2Xw6zYpQOQHHEZTyVpYcYj8sQxQFQCy VKI2djpCDpHuaeQD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXrnTMtnEaOzps34H3f32 T/ihBY5g7IfnMsazZKR9FrMgy+vjpXRRwtz7QLSNkqn5A5kYI+uZ6Sz9EPWq/1HKe6xUV2pr HUC3c+E44gmD56XkzeWaP4QB7zv7PGAWBXQj1dgEJgm8zWF4GO4cMZb5zQWGatyGsMNeDusa kmDvwpUvcVXJCHzMvcxZJ+tAcM3y6SmDc7iSv3fcttJZN52aROD+yZtI0WX2ggBjXQRrE32A r/DGe7EMJrQIf4PIOaeLwvF7YIW+w== IronPort-HdrOrdr: A9a23:kHOjnqlFd6HdVMb5w5HXU+MrFdPpDfIL3DAbv31ZSRFFG/Fw9v re5sjzsCWetN9/YhwdcO67Scy9qAznhPhICOUqTNSftXDdyQyVxeJZnPDfKl/balDDH4dmvM 9dmpRFeb/N5DBB7foSizPWLz9P+rW6GYmT9J/jJx8Ed3ASV0jP1W1E4m/yKDwTeOA/P/sE/e GniPZ6mw== X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="71483780" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUbLTlOWPniCMavA9s+R37I4KUQGtsLSmRauEmLn0JREZIXjh7jPHSIy6DsCl3cYXML6fUAx1+vI+450TWHP0s9iUoEIzMqZdJ4FtX4Tao/n7A9lQFZZetZYQfWZRBLMSWdTgpM4EBBL4odFrxIiV23RjWp4ChtX4N4ZuQknb6AQs44+3B3RtVzSjMVXEwSw/LLazRVTco68aoTrOaMoZttNUX6Eh1+u1RLYQnd0WQRkHMjbVgWo4C4DQmQBatPuTzQCL7NaklccYYEakBd7dc+ADCyDeRAHa7loKAFgSr61MvRpgiETznEtgk9kplG22Aaqe+2RDUgP2DOgtppFBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eCxM8VEeRLSTlOrps4UsKuiPVOCRAxFgQJr/oYzyezM=; b=Ms/Wzb01BkEIxzBk8Msyh93u3YGlzmXbuKNFS+ZLMbRzbIf0y03+FC43HTtUtCdJvjd3H02LqrR5sX0Ze31KtQl3G9EQRwN3PYEzsP/SMrl5wAAoYSukvUrBSmwkDrvOIXgtz7sFYIVmYYMbH63RZ0xEMwOnjgXqrNzMo4MByHkWggefWyde2lnq6nmjQM6w21lvYiqa7OLn6ql0BYlifFfwGpmNZNBhWMi9Q/+7MXoQK87JyHve8GCezPgZ7OlOiPZIJ3YuyeDMxQ3gR4Qgvao3SpLrsIsjTMHShaosRXFwbiVNI2HOPn52yCfL1tpF8YmDHyy+CCCaZaFBJZ8NBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCxM8VEeRLSTlOrps4UsKuiPVOCRAxFgQJr/oYzyezM=; b=bfjgqQzkWztrIwAhKexxTZRwt7thhkEK8UL0m06udUba6R9Tvp9Zj8AV7b510UmRPW8mHbyquD9vQtMGOVBTWn+0Jdt6OmUBH4Bwz/T3rEba1IWlBs3q0YZ4371g2FhjBpkWMxbnQ23HgftlQYc9AmHR6VELp5SUmIKAeT1slrk= From: Andrew Cooper To: Luca Fancellu , "xen-devel@lists.xenproject.org" CC: "bertrand.marquis@arm.com" , "wei.chen@arm.com" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Juergen Gross , Dario Faggioli Subject: Re: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Topic: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Index: AQHYYUDliIUtXuVlFEquWiHjLJV14a0jGe8AgAACgQA= Date: Tue, 17 May 2022 13:10:27 +0000 Message-ID: <55a2bb89-da5b-27d0-2f7d-bcdacb19300a@citrix.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 302cf00c-fad2-4946-c5dd-08da38069c6d x-ms-traffictypediagnostic: DS7PR03MB5639:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5mzvENElwISGSQA6ZbGz79ZslxYsEqBTnahkCdqGdwbDGds5GLeO4cOAFeP8mKJk+JDYUpKE+5KCh/luCv3wXqFJU5N+W9p0eO4rQXvepUNGnkcqFpgFSIcfDVo1lLlkILUHcbRAB+6+lBozKN398W6lx/b8PR1VJS+3rGrA7MkEfocQI3/84kBfg+/5Uw59a33O/IL3rITYvlCMPjgJsklhvqemz0QznqnVScDrPH8fG0AX2Xojpkxy4LkGrtCSjT9xKXZval52KlfHVRA7KigW4MQNuQr3sFNLkHhsCOCjGWUtLsvVCNAvuoskaUxZin8/lyXSnb3VRM/KcSJYGHJSa2SuENobYOa3ljoeBsm+TsPhM9XZn0Vn1weCyENKurobF76mgQus48RCczRCoD/beDPdAU8bE/0P+rjbk4K6xtU70I6wZa+zlYWtjm/UpF0L1dDWYcypRFMpv2NQcJk8BGdHnjMht9mB64DdabcRdNkK7jIQQfLrt8qUCzU8c8atLmejRWDWyjtnq4xQltaDxUS/g3Dl0W+dNqaImaSo/0UpVVqndFkaMoUSLDKiWJtwXReFjCMiR4DyrmUU8Er6yWLR+G4TFshb1aatmVOCHX27HHqunz5XYuDkMToTi9cxkuDj9GOy5TfIMsy7IIrdQCzTrsW/V4Nl8BiXYVdQbchiVwfoyweN89fYQ9lqzt6pBejfRvD5RZiNgO0Gk7lA1vv7mAja/upeo3SF/Q9ql4BvKWe13mlPI31YKZQnO5v+iMw3uZOuLWJR7nneTqYqLDVhI3FwIGirqxdhyt0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(38100700002)(2906002)(122000001)(86362001)(6512007)(83380400001)(82960400001)(186003)(31686004)(316002)(110136005)(54906003)(36756003)(71200400001)(6486002)(91956017)(4744005)(4326008)(7416002)(5660300002)(508600001)(76116006)(8676002)(64756008)(66446008)(66476007)(66556008)(8936002)(66946007)(26005)(53546011)(6506007)(2616005)(31696002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R2NOOVlPajJ3UEJaNklWNGJKaHNSNHlneURsVUJrN1VCOGVCS2xhK2JQQ05J?= =?utf-8?B?WVo4bFkrZEJuQnhWVlhRYzhEYUZUY1I5Z3Z5Q1BUTjNSaW96ZVQ4cTVacUds?= =?utf-8?B?MkdxZkE5Vm9kQmtORnF5eHRTS1hWRDZXKzhKYytzS21SL0VOdTZib25aaXIw?= =?utf-8?B?QTVrTVZCRTF2R3ZaWXp4VnRWS1A1UlRNNTAzNTJFNVBxcm9zK3pveVZ3a2x5?= =?utf-8?B?MElHZ2hyQVVMYmxHVFlpVk5sKzZOWTJHaW13bUd1ZFhFeCt3Ymsyck5ncThr?= =?utf-8?B?RDhJbk5DOEtuYTJpbWpzYStFQUlvOEpzcngzYTJaTUFGQllDMmVqeVVTTTJm?= =?utf-8?B?N0xKYXpuQURzRVFBbkF0U2tpelBWUWF1ekJDVEdKMHhtMG1pckROTmZ6Z1Bn?= =?utf-8?B?ek1LTFFSTk9sZzhhT0ZDbkZLOGovT1JTL0w4RFhPbXN4TkUvY1BSSDErNnRi?= =?utf-8?B?TkE1cHRMdUQ3YUFEZ215TElQK2RRM1hzT2c5VmtHdWRHV2hyeXlPeTV3Tk9h?= =?utf-8?B?cjRkN2NEcU5CT2d6K3VOUlh5eW1ZTnBVNkQrallvMllEbkp0bnJpOElMa25q?= =?utf-8?B?bGxWc1FqK0pDMFN1dmpRcEtVV1pMa2RtcjQzRWNJY0VtWUx3Y2NmUnBQZnFO?= =?utf-8?B?eXd3V3dQV3k1MjR5bkxpeHBTQk4wUmFSWTQrbWhpUDJrOWlIUStncmpSYmY5?= =?utf-8?B?MVFtSjJrWTFqbzlxWm1sYm1oTCtRcll3VFNmZ0M1R0lLaDFQZW9NMHo2YjNQ?= =?utf-8?B?S2VnVGxDZGNiUXJzaWpwZWpPOXpwOExVWWVKRHFsbjZVdmJFdDc4YWx2QTU3?= =?utf-8?B?bEVmbE5nWFdYTHBiMXR1VGFCdTUvWFBNRG5wVG0wTkZwRm51WU9RdG5HM0Iz?= =?utf-8?B?SDNENGlOMXFMTG9rbUNCL2hIbXgrc3VkWlhZdUlTYnlvckJVWERFeERCSzVw?= =?utf-8?B?d0xpSHRwY3B5bStMbjBCaUJ0ZldxRm0yeGVpY0NIWmUrYWVPeVJjWkpnejIw?= =?utf-8?B?dkNUQXJGbFU4TkVyWm5Fb1U1ak1PYURpQ24xTVRvUW5Fd3lxWlJOTFpmLzQv?= =?utf-8?B?VjY2YW1MRXZSMldsVnU4RTZUN1BDcDUyVG5QNnZWRm5FbEpVejJTSTdQaWlY?= =?utf-8?B?NDdNamUvNk5jVmtkeTZtOGtCWm50Z0Jkd2J0dnhGS2FVTTJLblgzT1ptNTFF?= =?utf-8?B?bXVKSXVrMTVsV1d6V2xqNVczVVgyM2ZiRWs0bUVOZS8xcjBlWGVrYTZ3ZTRR?= =?utf-8?B?N1IwRWs1TDcyS0tDTFlhUS9DckJ5U001Tzl5V0dsYmUzNTc0SjVaNnlrU1p1?= =?utf-8?B?Y2VWaDRMYzlsdWZwb053Y1k5UlBQeDNCVlgrcmFQczRNS3lhdFpER2ZYSzQv?= =?utf-8?B?b0pNWDlncjE3Z1poTkdUMzV3ZjlNNFVDVU9HQ2l1Zko0NHhzWXBjT2wvL2pZ?= =?utf-8?B?NXpqNHk2RmVoZW93MElBcXFqUGZwcXQyS0FlVFpXMlEzc1RETmwxUTdjdHlt?= =?utf-8?B?YkV6Q0o5V3Znc1BvemJOU3pjdkNFQjdvdVA0RGdVWkttcTJKTDFYeFovRTcw?= =?utf-8?B?eGZGRUp1Qnd6RzJHejFnZDF4VXYvS2lFbXl4UjJpOUx1TGxDdlI3OEMxQ2Zr?= =?utf-8?B?S2FzMXdHaWJDcDEyWVpqakZ0SjY5VFF2YTNXaUhnNDhOT0N6WTVVYjltVlNF?= =?utf-8?B?Z2ZpTXpCaGVUQlhhTkZ6bCs5TCtKaDZGdjlZcjU5cjVGRDVkSEFxbUtrcWx1?= =?utf-8?B?YUxNMTc1V1FhK3VUbjNZVlBRZWxmaFc5MTdremNzczRRMk9kT282Z1p1aUV3?= =?utf-8?B?eGxDK29MdXNnODY0T1pEZmYrRTcyK2d6WXk2THc0cUhwUTRNcDUxVHFQYWEx?= =?utf-8?B?VGt6Y2d2NWw3VjlQeERHMHZESVE3cmdjQ1ZEeXMzK3BVa1pUSlBqOG96dHpX?= =?utf-8?B?UDl1OU1qb2poVDY0d2N1ZkRVTlVYVG1IUGE3TlU1MWE4MDZwc2JtOGRaMm9r?= =?utf-8?B?c2NQamRvRlZBS0FTemxsR1FpZ0FLS0ZxSmVjR2JQem43TW9jSGRBSGczS0lJ?= =?utf-8?B?cm5FNGYvc2srd21vV1lITzYycW5XTlYxQUlSTmJxazVEME0vcEtEVDZ0ZEFJ?= =?utf-8?B?eGtjbDZHUkxWRktpenFKU1NMcjBJYmF2RE5adTJ2TSsvZWx2Y0kySWdSVHJk?= =?utf-8?B?dUd5amZUTEx1b3pIUThrM1g0cW1RcjdpaFZrMWh2UHlnR2dyT2VJMDFySjky?= =?utf-8?B?VzdETUpsa1dQa3BVZ1FTdDhVOXdhdG5zam16b0I4UW5BU3Y5MzN3TUlIUm9X?= =?utf-8?B?U2srNUxZeFZ5a1dhKytzMFkyY0NCL0xHQTVpajFBUTV2c21sZktEcmdPazRW?= =?utf-8?Q?J2Bj1umKLEwoiU0Q=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <5A83569E050253468B227906A17F7F1F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 302cf00c-fad2-4946-c5dd-08da38069c6d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 13:10:27.1589 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LxaoMIvHTUfQ5ueKlE4seH/GIGJpphxBgn5EWU3OQdydX8C1kwH0wvuktH3yZ+oVPj5CognXyYd77na7SI0MnMZHKzPElo3jPVF4duZYKqA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5639 T24gMTcvMDUvMjAyMiAxNDowMSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMDYvMDUvMjAy MiAxMzowMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+IEludHJvZHVjZSBkb21haW4tY3B1cG9v bCBwcm9wZXJ0eSBvZiBhIHhlbixkb21haW4gZGV2aWNlIHRyZWUgbm9kZSwNCj4+IHRoYXQgc3Bl Y2lmaWVzIHRoZSBjcHVwb29sIGRldmljZSB0cmVlIGhhbmRsZSBvZiBhIHhlbixjcHVwb29sIG5v ZGUNCj4+IHRoYXQgaWRlbnRpZmllcyBhIGNwdXBvb2wgY3JlYXRlZCBhdCBib290IHRpbWUgd2hl cmUgdGhlIGd1ZXN0IHdpbGwNCj4+IGJlIGFzc2lnbmVkIG9uIGNyZWF0aW9uLg0KPj4NCj4+IEFk ZCBtZW1iZXIgdG8gdGhlIHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIHB1YmxpYyBpbnRlcmZhY2Ug c28gdGhlDQo+PiBYRU5fRE9NQ1RMX0lOVEVSRkFDRV9WRVJTSU9OIHZlcnNpb24gaXMgYnVtcGVk Lg0KPj4NCj4+IEFkZCBwdWJsaWMgZnVuY3Rpb24gdG8gcmV0cmlldmUgYSBwb29sIGlkIGZyb20g dGhlIGRldmljZSB0cmVlDQo+PiBjcHVwb29sIG5vZGUuDQo+Pg0KPj4gVXBkYXRlIGRvY3VtZW50 YXRpb24gYWJvdXQgdGhlIHByb3BlcnR5Lg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFu Y2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+IFJldmlld2VkLWJ5OiBTdGVmYW5vIFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFRoaXMgaGFzIGJyb2tlbiB0aGUg T2NhbWwgYmluZGluZ3MsIGFuZCBpcyBjb25jZXB0dWFsbHkgd3JvbmcuDQoNCkFuZCBpdCBsZXRz IHRoZSB0b29sc3RhY2sgcGFzcyBpbiBDUFVQT09MSURfTk9ORSBhdCB3aGljaCBwb2ludCBYZW4g d2lsbA0KZmFsbCBvdmVyIGEgTlVMTCBwb2ludGVyLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue May 17 13:11:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:11:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330814.554207 (Exim 4.92) (envelope-from ) id 1nqwyw-0007fL-3z; Tue, 17 May 2022 13:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330814.554207; Tue, 17 May 2022 13:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwyw-0007fE-0x; Tue, 17 May 2022 13:11:22 +0000 Received: by outflank-mailman (input) for mailman id 330814; Tue, 17 May 2022 13:11:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqwyv-0007TB-0x for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:11:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7c65ce9-d5e2-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 15:11:20 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0C7941F88E; Tue, 17 May 2022 13:11:20 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id D75DF2C141; Tue, 17 May 2022 13:11:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7c65ce9-d5e2-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652793080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R3V2DPM1jjc4jD8tVw3U8Rq3S0Maoan+sJ+xup8d8sI=; b=FE8yzrStcygQwANxOmZrJZbOrCy87Ou5DJ3FGcXlGzv/8KcD1Q9vQAYohnpV6O9yl65Qfm zyx0GaYk63CmAg8xlzK3VRV5wlBb3dplZbLwFVDWl++Ff8DNSFdVejZHiQCHUg6G6gVRgz J3YUEPeJCts4dfmVUl5hnzLG7sbV2vU= Date: Tue, 17 May 2022 15:11:10 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-15-gpiccoli@igalia.com> <244a412c-4589-28d1-bb77-d3648d4f0b12@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <244a412c-4589-28d1-bb77-d3648d4f0b12@igalia.com> On Tue 2022-05-10 13:16:54, Guilherme G. Piccoli wrote: > On 10/05/2022 12:16, Petr Mladek wrote: > > [...] > > Hmm, this looks like a hack. PANIC_UNUSED will never be used. > > All notifiers will be always called with PANIC_NOTIFIER. > > > > The @val parameter is normally used when the same notifier_list > > is used in different situations. > > > > But you are going to use it when the same notifier is used > > in more lists. This is normally distinguished by the @nh > > (atomic_notifier_head) parameter. > > > > IMHO, it is a bad idea. First, it would confuse people because > > it does not follow the original design of the parameters. > > Second, the related code must be touched anyway when > > the notifier is moved into another list so it does not > > help much. > > > > Or do I miss anything, please? > > > > Best Regards, > > Petr > > Hi Petr, thanks for the review. > > I'm not strong attached to this patch, so we could drop it and refactor > the code of next patches to use the @nh as identification - but > personally, I feel this parameter could be used to identify the list > that called such function, in other words, what is the event that > triggered the callback. Some notifiers are even declared with this > parameter called "ev", like the event that triggers the notifier. > > > You mentioned 2 cases: > > (a) Same notifier_list used in different situations; > > (b) Same *notifier callback* used in different lists; > > Mine is case (b), right? Can you show me an example of case (a)? There are many examples of case (a): + module_notify_list: MODULE_STATE_LIVE, /* Normal state. */ MODULE_STATE_COMING, /* Full formed, running module_init. */ MODULE_STATE_GOING, /* Going away. */ MODULE_STATE_UNFORMED, /* Still setting it up. */ + netdev_chain: NETDEV_UP = 1, /* For now you can't veto a device up/down */ NETDEV_DOWN, NETDEV_REBOOT, /* Tell a protocol stack a network interface detected a hardware crash and restarted - we can use this eg to kick tcp sessions once done */ NETDEV_CHANGE, /* Notify device state change */ NETDEV_REGISTER, NETDEV_UNREGISTER, NETDEV_CHANGEMTU, /* notify after mtu change happened */ NETDEV_CHANGEADDR, /* notify after the address change */ NETDEV_PRE_CHANGEADDR, /* notify before the address change */ NETDEV_GOING_DOWN, ... + vt_notifier_list: #define VT_ALLOCATE 0x0001 /* Console got allocated */ #define VT_DEALLOCATE 0x0002 /* Console will be deallocated */ #define VT_WRITE 0x0003 /* A char got output */ #define VT_UPDATE 0x0004 /* A bigger update occurred */ #define VT_PREWRITE 0x0005 /* A char is about to be written to the console */ + die_chain: DIE_OOPS = 1, DIE_INT3, DIE_DEBUG, DIE_PANIC, DIE_NMI, DIE_DIE, DIE_KERNELDEBUG, ... These all call the same list/chain in different situations. The situation is distinguished by @val. > You can see in the following patches (or grep the kernel) that people are using > this identification parameter to determine which kind of OOPS trigger > the callback to condition the execution of the function to specific > cases. Could you please show me some existing code for case (b)? I am not able to find any except in your patches. Anyway, the solution in 16th patch is bad, definitely. hv_die_panic_notify_crash() uses "val" to disinguish both: + "panic_notifier_list" vs "die_chain" + die_val when callen via "die_chain" The API around "die_chain" API is not aware of enum panic_notifier_val and the API using "panic_notifier_list" is not aware of enum die_val. As I said, it is mixing apples and oranges and it is error prone. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 17 13:12:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:12:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330822.554218 (Exim 4.92) (envelope-from ) id 1nqx0I-0008I8-Gd; Tue, 17 May 2022 13:12:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330822.554218; Tue, 17 May 2022 13:12:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx0I-0008I1-CM; Tue, 17 May 2022 13:12:46 +0000 Received: by outflank-mailman (input) for mailman id 330822; Tue, 17 May 2022 13:12:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx0G-0008Ht-VX for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:12:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1a::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08eea5a8-d5e3-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:12:43 +0200 (CEST) Received: from AS9P251CA0014.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::18) by AM0PR08MB3554.eurprd08.prod.outlook.com (2603:10a6:208:e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Tue, 17 May 2022 13:12:39 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::f2) by AS9P251CA0014.outlook.office365.com (2603:10a6:20b:50f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 17 May 2022 13:12:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Tue, 17 May 2022 13:12:38 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Tue, 17 May 2022 13:12:38 +0000 Received: from c49673a1986a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 501EA794-B914-4CD1-8741-00BC55B7A6F7.1; Tue, 17 May 2022 13:12:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c49673a1986a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 May 2022 13:12:26 +0000 Received: from VI1PR08MB3824.eurprd08.prod.outlook.com (2603:10a6:803:bf::27) by AM0PR08MB4147.eurprd08.prod.outlook.com (2603:10a6:208:12c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 13:12:24 +0000 Received: from VI1PR08MB3824.eurprd08.prod.outlook.com ([fe80::f865:ef06:e407:238a]) by VI1PR08MB3824.eurprd08.prod.outlook.com ([fe80::f865:ef06:e407:238a%4]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:12:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08eea5a8-d5e3-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DVD/wOf9R3Jo1UACD6pLb0i4LtRrBtNyrw0qtg/L5olBaKy1Ri2waWvcI6rZW7xkV7x8+ncMD8JL8aiGI3jZ2Jw1l3FGaS8e5QjV5aD5QIuiQR1yCYvyRzHFG5G272VFkzcLrdH4btkXq7PX6bxLCYTTS0NEKF6BYDrm6A8z0/ERAr7RdUnba1sNSxrUmOzcIkV+INwSobEiyz+y41WLStNxQ26Mm0tSHFjyYcHMCQ18/bS84wOExxtRWWff+FhTElZpV7AXgZP6X6FMSVHMjtzISbMqVxWlTLCqKoVOLMxvnEgLwKSvmqqSmcX6fYzndr7qGjfQDuTpM2I34bKO1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KT3qqzCM1rytj1S/U2ZJuxGW5T0wuNP59LeExPBQcZ8=; b=NXQo6ss/S9icFwLdf8r7K6jlGwOsI2SJoRQYvwWw8Ly1tfpXn7wmcL2LLlpekmV0c2v74MrRwUkoiuWnUK9/pzXaCXWf4U8wyzFMERavkq5XpBL57dcS7KvXmbnNvbk0pTlBnB67W3NEfZ8ktpAFOx+p29YWGxfFWuyQjBld+uKnbc5P2EQmc4XtQa1ufSvpfhm/1oScIrvmlGaSQAa4XzV3zS+87NWd/11a3u9hcoMDZOctwa1UzGDppQHhY1XtQm0OJPlN4PrrRU399ekMAVGrmhgyqh4hZW5EldbG4Gs15AlQZbrOz7EtKmxltEZ86AAYHe47nNvw4iTXrZchzA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KT3qqzCM1rytj1S/U2ZJuxGW5T0wuNP59LeExPBQcZ8=; b=ex2qDT0ApPEhcO0ddMjLlOjxCxWinxY5NaFUMEctkjpyW/2II8nDkzALjogsnAFfasigH//qp/iCFdu0ADBEuep7s5I2C7/bE/+3ThcR5/5m2PGIitWW96rjxhSeDGyHPg3WWG5qqXEqOpCAL3BBSP296zOcOS5GPnbM6ABWC2o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8276c37d8f64fb63 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awSsS9IqAxsvJcuwXdglMnHcqcidB9f6LRJiZHBoRUjzC+DN8ArokLjmJZH9nEa0jZrmD/XNVce42/iVl0W3ahHu/5/Gck8RLRFEyrpLLtR8uO5Le6TFCg1+JbxYkPZhHlLXxJJ1WH50fX28Iw0vjq5VFE+C4CbE9DaOhYaz6bo/EBwYJYpZvG+ymeChbIiCzWYpw0fE/7hTTG5JNFApLC5+mPZxJ09Wma88styAaI61U7SUD7knMEtfJpL3SnDILurgQ5vEPjI0bIDax0Nmg69AZ5cx7W52r337Cc6QI/+KtyIOPiIZK4W9iXShmlPaAMjaXP3H6mOVUgqpm/Ma1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KT3qqzCM1rytj1S/U2ZJuxGW5T0wuNP59LeExPBQcZ8=; b=F0J0f9ES08NZW5nFWsl3/ssaaOwRYgRdt56LRL6SIV68PtmDnf1mPOTmgg4W7QO9UBKk+e+N+AaoPiBJ4U+umURcbNTNTaK+M3rIF8jNS4UvnGQetHxsTfl0ayGVbqpo+F383b95Bv9QPYADkeq1gukP2zW6grXmOLHrzoOLSZnOdj5TlBwEown4qb8ywsSWYG1qj/QyqD2SMRUd42zk+szZvpPMgpyc0Jz417ukXRyCxkoJDd/CO5zVoa3vrqmmkOvSVAu11qKVAMY8iwq4410ieMw1Ejgi3omURrMV13DFdGyE1NdREAzg0TRkR4W2Xx7vwE18uu4vwykSmj+nJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KT3qqzCM1rytj1S/U2ZJuxGW5T0wuNP59LeExPBQcZ8=; b=ex2qDT0ApPEhcO0ddMjLlOjxCxWinxY5NaFUMEctkjpyW/2II8nDkzALjogsnAFfasigH//qp/iCFdu0ADBEuep7s5I2C7/bE/+3ThcR5/5m2PGIitWW96rjxhSeDGyHPg3WWG5qqXEqOpCAL3BBSP296zOcOS5GPnbM6ABWC2o= From: Luca Fancellu To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , Juergen Gross , Dario Faggioli Subject: Re: [REGRESSION] [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Topic: [REGRESSION] [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools Thread-Index: AQHYae+/wTiZ8QXf0kGBx86KT+V7ZA== Date: Tue, 17 May 2022 13:12:24 +0000 Message-ID: <60E49E06-BFFE-47BD-81F1-CEE26E471359@arm.com> References: <20220506120012.32326-1-luca.fancellu@arm.com> <20220506120012.32326-7-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 90a7ee9b-62a1-4c23-26b7-08da3806eb0d x-ms-traffictypediagnostic: AM0PR08MB4147:EE_|VE1EUR03FT049:EE_|AM0PR08MB3554:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jOoxAY1qOH2QyAwnPgzaKGlc8pQaaGXBe8WlLg/fRTIrmtJ+gCfpRpZKGDiHGFR0u6Wi+RBZSOr0EV8TOOER/J1eA72/OmqeMmJ0zd6kiOtn72g63d09SZLx7IWAKaYW+461N48814Wuszf61KVKiCMZdGjUA4/jysDZ7lnIgKrldoNUI6Pn7HflveBueHjW/QFSO4aYUD5MO9i2OxC8qvPyp8axblBvZUKm577Q4/PEuF0KoCx46woFs0ssdHmj0hLk744+kHVmp4t6LIhdLdEH0rNQ5dj9uY2QPrkmoOhH7Fqx1Jg8EUKIzsLC4t2N6rDEomtimgJpCKIq3BufSLjG7YE+G+yuGvAgp/u1ucTa+mFURak+Pedn66zNakwQLFcJcybqdQkp36PImPpuiYvVnizWjSwfiJ3kYxpL+2cC3CwYoRHOAOOVQGuYo324P0DpeFHDEx5DWtqanwPxwVBiUIia93kC3YUqmbuVu/77cFERcRTM5WFqoNA2G37gMk0fIaTzqI6nUbJGwClf9yJ/hCFDrsLzITC2g2QuOy8wR++/bDOOA4hCUnE1J3iBDDdw2NHbMhEjHPzHxFyrpVw6jKLmOsf52dd1+13XTBjdIirPXJqUYIbIrlvJWVdlHoI0VA2/ekJ8jYcq872VQOrl7AqQxxVuBv7aBrAwdhqvBu43bCD6KiJWiiJWMX6GA8JWxdt/2tZKECThY91uDJAzOJmLgQi7h4gbqYryjoDzYJuQaDddZTYLrVzvODbTmG9FtNClOEsrZK5gKkGSsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3824.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(53546011)(2616005)(38100700002)(122000001)(38070700005)(83380400001)(86362001)(5660300002)(66446008)(66476007)(4326008)(8676002)(66556008)(64756008)(91956017)(8936002)(66946007)(36756003)(76116006)(2906002)(6506007)(33656002)(6486002)(71200400001)(26005)(7416002)(54906003)(6512007)(508600001)(6916009)(316002)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4147 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 842bbbfa-aef0-4fb0-00b5-08da3806e254 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WYaKCgddR5NZqmKKVqjb2KHnmPZSmeMXXNwEgd6Cy+DnCgjxUl916biLg4f4JCVjbkPjun3yZcBcm4NZ3tJBIMn4hshtGD/Lu8lkY+WrIpIliKHqnABRSUEaprjKXJpbSOjpdh04E/4UtwJAzX938phd4+/6KXacD3a24JXlswm4SBREOU0Mg0uitqTFaAsoFFeFIAVRxbknC5qt8zRh7cSA93eByX9lDsVzrVQR3J2Oc1WTPzOULNYvCx+QYnnOZWIz43pEa+zl/nl4Dr9GadVia/n7vHjqmPYge/6c7uKzfXmhMsIrHC36SBMZdsusHsA/qO2S27Ur6PQPqFdMEGdk0NH1oBfRU87TtSPpOEU8u/yLf2kljc4vmyU5HMXHL/R3lU7emVqAj7IH74pCezYNbTGiK93U14UYNi+qlxBWQ3QJcudyPY8KM1h8rEsKtIaGj4hac+IIano00h/rCCbqo6Hh4XdT11xgvUQ8BVAeWqm9cwLrdwmNXtWApvwJkf0sUrYp0/Qa3sS4sQsa3L5Mficg2RlufFGhPSb2JNZjXtKmk+9FEBcAnA4NrKdROI1KtURcN8miygLJkCQSfwT8jcY7vuRD/AEZ0EcktF62ijER4INQgS8TRNjiy2/zoGrxSwr0elUOK3u8DYNCKFWB6oTQqMjXyXghPc4z8NrYBKrmwGR54JxgzLb4v7BljiWMvihA+mJ1sVWMqUzDmg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(40460700003)(6486002)(26005)(36756003)(4326008)(508600001)(6862004)(81166007)(8936002)(6512007)(70206006)(54906003)(356005)(86362001)(6506007)(82310400005)(316002)(47076005)(107886003)(36860700001)(33656002)(186003)(336012)(2616005)(8676002)(83380400001)(53546011)(70586007)(5660300002)(2906002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:12:38.9675 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90a7ee9b-62a1-4c23-26b7-08da3806eb0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3554 Hi Andrew, > On 17 May 2022, at 14:01, Andrew Cooper wrote= : >=20 > On 06/05/2022 13:00, Luca Fancellu wrote: >> Introduce domain-cpupool property of a xen,domain device tree node, >> that specifies the cpupool device tree handle of a xen,cpupool node >> that identifies a cpupool created at boot time where the guest will >> be assigned on creation. >>=20 >> Add member to the xen_domctl_createdomain public interface so the >> XEN_DOMCTL_INTERFACE_VERSION version is bumped. >>=20 >> Add public function to retrieve a pool id from the device tree >> cpupool node. >>=20 >> Update documentation about the property. >>=20 >> Signed-off-by: Luca Fancellu >> Reviewed-by: Stefano Stabellini >=20 > This has broken the Ocaml bindings, and is conceptually wrong. Ok, can you tell me what to do to update the Ocaml bindings? Do we have som= e resources somewhere? >=20 > The cpupool to use is a property of the vcpu, not the domain. It isn't > legitimately part of createdomain. I agree with Juergen on that, could you explain it better for me to underst= and your point? >=20 > ~Andrew From xen-devel-bounces@lists.xenproject.org Tue May 17 13:14:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:14:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330832.554229 (Exim 4.92) (envelope-from ) id 1nqx1e-0000Wm-07; Tue, 17 May 2022 13:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330832.554229; Tue, 17 May 2022 13:14:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx1d-0000Wd-SW; Tue, 17 May 2022 13:14:09 +0000 Received: by outflank-mailman (input) for mailman id 330832; Tue, 17 May 2022 13:14:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx1b-0000WP-PY; Tue, 17 May 2022 13:14:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx1b-0003L8-Ns; Tue, 17 May 2022 13:14:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx1b-0002nA-8c; Tue, 17 May 2022 13:14:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqx1b-0004dY-87; Tue, 17 May 2022 13:14:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3zYlAJpMrDcPECcDwFOaLO64U4VD9yZJojezJVR5GPI=; b=mYPcG3H4NQjtN1rOLXgRHUaMtM g4ZmvBHlfGvUAIVpp9YU8bbW/kmISHmEq/3PWXpBH/71yHh814ek5c4MkYGFQxoO4ms4l5iDtE9iN ePWcHepwOeFTDtYexU1Fx4VkLdHIr2JZSwsiYxDSK4NtWWKzcETHkPXOU7udQW7PxVeg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170507: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 13:14:07 +0000 flight 170507 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170507/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1061 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 80 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 13:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330842.554239 (Exim 4.92) (envelope-from ) id 1nqx4H-0001A9-Er; Tue, 17 May 2022 13:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330842.554239; Tue, 17 May 2022 13:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx4H-0001A2-Bs; Tue, 17 May 2022 13:16:53 +0000 Received: by outflank-mailman (input) for mailman id 330842; Tue, 17 May 2022 13:16:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx4G-00019w-SC for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:16:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d529705-d5e3-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 15:16:51 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-lEG5yN8YPsq7iN166P-AQA-1; Tue, 17 May 2022 15:16:50 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4953.eurprd04.prod.outlook.com (2603:10a6:10:13::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 13:16:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d529705-d5e3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652793411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v0UZ/OLygyxf38LEAdm98Ux14EuOFQE+8OC+NMGCUQI=; b=IOtnoFrl5l/k1XshdlhxlGjKeUGE/Fkn5zoh/gYtfvHZJ8ck5eBsaOqF2Cwk54x5fwulIp rNc+2kCkoxGMpSFlmm6+ZXxI8mqiOhYhktTuAO/2XIVoPbOKKP8NwHLr1x7lzUUwsAVIeI GlJcDTGQDulxbfiyGDIw81hT/HVURc8= X-MC-Unique: lEG5yN8YPsq7iN166P-AQA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5+BvwRAbB6ybPNfHiHWH2Ol+d6m1qBbDtG6MzPG7q4+xIZoFD8PiWlc6W1TkF1zqkcMvmwvWtl3KEjWPwOWUZRS+A2Ad5Bdf9niJ+17McaoUTcOa/5rSwN5H3uwcv5VLSmiVmh1IfJGCPp8el0iZz6XOVhtf/FSkeNzR99mt+ZlmqgLzks0vQPom0NxBObu7eC5UQJ4oduYSj7S4idhTbV+16bZ6X8iIfMNj58w4hQeF44O/yur7ARGaPajHJEGdbbFkCEstzt7O/Bm8+JCwUGaCPF7lsl0KQX+fWDlNzgv7OhpTRhaxFoj6+982PZJQS21hQtBfKUDzk6IuuhzWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v0UZ/OLygyxf38LEAdm98Ux14EuOFQE+8OC+NMGCUQI=; b=Qhrt6K0xjV6G8UcsZKsWQqaEagcRb9oKUxArllvu4EmKu2M7a3wIhnIz/H1EyO1DBp/LWNOMn06o0BvHjgWFJ5RkK2/Lk4UXTA95pTru7YqQWIgUeHvgS05C/OSKZnzsVqLuWxIXinAPxPWrSydQzdvFOApk43xKcG0tMTRtzE7u9CbKot7/69hkX78BFflqePsLbmQ6jwXVDG6EY/bY/FFMmw67MedrHz7fgs+Y72KdLoKRZItQebORO202zHCHxlvC3XUJgA1JLnDLUB2rDNyBTLI8/hI0qTC+niuO8mPA4aIfxdZPQEWux9diZ/plt0u1K3gmRBv7fCvRVf8dQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 15:16:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P250CA0025.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a5aa943-e0eb-49cb-c446-08da38077fdb X-MS-TrafficTypeDiagnostic: DB7PR04MB4953:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I4x8/psxZyMCmtku2mZerIodmYqKgrH6zhhk+DF9ireYujVnWMV0J5enOU81kxtA8nVDzeNPVJfE/rwHe7zUFKH/8hGNC5d/vUjCTOtSLdQmi9KsCh9Y8deC/34Wcf5ip1NgcQphrdzO65tvIOB24+nP+arSfYMpPmD+zMylIB4pd2fa6az+TAuKwgEYS9Q/WpV4dAlv+xQ8QRM7ETOfNqs/Kl6STex4IxP0LoFdG2F7CXdee6c3beWbYAgZg+jQLjDC9KeUunlKU3LTgt3C35j2/BByWd9Duputg2HDVlgx4icdDZVomxbDgcYbzenF+LsjU7LhugQ6xGVfS7C98tYUdUw8o2Xpy14Wgimc73QXgMqQIn9D0sCuvMs3RC+vvwTntdwo747M6+4sEooP/L7EXhJfBj7AVvXlo8btrj8NeV5hJrqOBhimr8GfcfFun9NPkSLr3sXggSVd83yclpUtVd66JY2g3k2lyt3VGB6e9Lp4BKlV/YSNiU/uL63Zx9m10Ewv9yGU75cD61uwAdannKelKwYh3QUzKoqmhSevRRpDNrWpYg7A0dZ102axF/7hT8+lCzjt6mVa4dhmqrSLaA79oroVwIAikY/P21UGgRKm/3f7750x7j1aPRSyW6/JZWXASMGY/w0fYblWzBrOJXBww1PEK20Q6nqnlsYNg3fQ/MGEPHk0TapwJbn7yJ5FCnd5NZ9XKKp5D/XYwk0HMXZSYgw/9qsJwrbvbPk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(6486002)(5660300002)(508600001)(31686004)(38100700002)(316002)(66556008)(8936002)(4326008)(8676002)(66946007)(6666004)(31696002)(6916009)(86362001)(83380400001)(26005)(2616005)(6512007)(186003)(53546011)(6506007)(66476007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0NxMVp4N09kdWRWU2NTSzJ1UDlmK0ZQNXdIbmNLYXo1NVpvL0FkcVNrV1d0?= =?utf-8?B?WmVUbHV2UEVVRDZPVndXZDRxdFY4ZEpORlZicXVUd21GQTRmWm5TSWNYUGJX?= =?utf-8?B?dmRBY2k0Um0wS045T1V6MHJ3OTNGYWtjek1lOTdXOXVBQklFK1E1RmdpQXgv?= =?utf-8?B?RFJ5WFdhR0tjM3hXc1krZ0Nrb3phZUlkUUNPRXFmcnlZYURrRWdvZEtjcCtC?= =?utf-8?B?RlB0cE1Nc0JQQ2NGM3BJUFo2aFZnQTRVZlhqNTVIamcyTWtiN0UvOG10VmV2?= =?utf-8?B?RldKRGNNVS9CZnNvSjIwbnVSUHVoSmxPaVZha3Y3N1ZPaUo3NlJMNTVWV09k?= =?utf-8?B?TmhMVUs5UW04REVYbUxNK25xMjhiZjcraWJlZkpFaGNPbDdqR2NMZ2xaUzZ3?= =?utf-8?B?eVQrRitKOFJRcE5nZFl4dGJHbWszTE9wUDRaYnUyeWoxNTY0cXhua3Fta0JL?= =?utf-8?B?M3cxdE9taktnTmRxWVNUa041RzR1cmpVK3ZnY1dEY084S2hSbnhBdDQ4SldJ?= =?utf-8?B?UlRGdmIvRDhKdTF0QnprS2hlTFRkRFZsc1NmTXVUNDZrZGVWTUc2RGFreHJS?= =?utf-8?B?U2VjMmZZQVllajFFWHRXcG1vM0N6bC9rQTZmT0RPb1pQMEE1US9oaTN0SkdW?= =?utf-8?B?T3Q5OWVDQTBwWkhsbmRyejFWNks1bFUzaGliNUtHYWlwb1V2czMyNFlzOTlP?= =?utf-8?B?TVBpVjJId3lxQTVBbEFTV3RyU3cyQjlldVdKZFpNOUM1TFAvK2M2QUxGQ05U?= =?utf-8?B?YnFQdVBTaWZ0MlJ4NWFyemlKSXZPSDYxeWJTMWxPdjFjZVhkVWYweW8rVThp?= =?utf-8?B?MkFUZjVJOWdhOXNlbVVNbjE1N1IxOUt5ejltb1hMdUVQRnIxZi96a3JjR2Zq?= =?utf-8?B?UVV5ak5MZFdaRFJ3cXRxS1F2T3NSZis2WW5BZGxhTWNsRHVaUjZpY2w1N3VJ?= =?utf-8?B?ZGpYZjlwdjdIS2tHNHdXY3BQc2VCSGpjTVVlUjRveVFuWTQvMUpxNDVBa3VU?= =?utf-8?B?VjVDV1RrVEcwTXBEZEdpTVFHRVlrWStURWtqNVAyUGNxWmFYUlFmUFVGQUVt?= =?utf-8?B?N2dxQmNUZW9YeGFjN25GV2NzeTE3c1RpbzdaQ25rMDBtcmZpUFFSTDFhOS9L?= =?utf-8?B?bjdLcXRmbFJqOExsVWVyZWxOa25ncWFTOFdoN3oyRHBBVHRwMitUbGw0RW5S?= =?utf-8?B?MTA4S0F1bnlpNFdrM1Q3SjVybElZb2FRZXdDdE9zQ3Y1UWwxeDB5YTA0eGFP?= =?utf-8?B?TFhXZ3RmRmljSXd1cnByL1JPZkp5WlQ2dVdYNHJ1dTN6WlZCeS90djVNZHJj?= =?utf-8?B?Q2YrNXU0YkZCK1FsanpNeDk2R3dXemNBRmVqbU5jM3NVOGd5bzlVdDkvMENk?= =?utf-8?B?TWxIMnVwTU1uNzl5UStCMkZHemJkRUh3S1ppamI4WkwzMVJYQ2JLV2l4eldW?= =?utf-8?B?cGJkSDNmVmVUM29KQitrVDZ1MGw5OXozMTBKTFdLdllLSWV0bWpTbjFIbldp?= =?utf-8?B?V0tNRmZSemFudzBVSGFCei80eStuTFh4Y2liVTZkNzVQa0I3M1MzOEJPeFRh?= =?utf-8?B?TFJwcEJadFpQaTVhQ0h6MnFBYU9kK2EvZE1RdC95dnhGL3pMdTVUaW5JTXMv?= =?utf-8?B?SnUyUkNhdnBsS1dWaS9QdkgzaVRYQWZIRlNMUk03aitBd1BMQTVkNlBIMG5o?= =?utf-8?B?bDA0dmZDalRuVStEbkg1dnhJT0hlVEtzME5ZU1RuQ21oanF5ZXVsaEpwWFB6?= =?utf-8?B?NkVwVXJoWW1LKzBzeTYxaW9pWXd2clNzR1B6NHR1Vm9BdnR3UTk5L244R2Rk?= =?utf-8?B?dUFQT0ZUckp3ZVFITFVydmdBTWtvVjBrNTdJbTEvL2hzLzNUb1BMWTdaMnJ5?= =?utf-8?B?SmZnZmw2U3RYYklUYThBQmtkNE1jUnYrenllRmE0ZWZ0ZU1aQVpLcjBScGFB?= =?utf-8?B?UkVUTEZhekl3cXFBUzRka1JiTEdhSGRkNExsRkRCRlZZdzZZY3lac2pUcXdj?= =?utf-8?B?amJCQ2ZTQ1kyMUtmYjdqUngyaVN2aVZqMmlNYXprcHpZUHlRWDFIUmZYMi8w?= =?utf-8?B?T1BidC9MVU92RHdRU09BOWxHM0ZIU2tJMk0rMWN3S0Q5Mkx1dTFlckhTTlpJ?= =?utf-8?B?TkVIR0pMRHAxeVRvd2RzS2FBaGRUVGxKUEYyTng4MDB5VnQwWUFwaCtlQkYw?= =?utf-8?B?S3dTWUVrMUdLN0dyMUhoZkVJYUNBRnplZUFoN0t3NHFuUTZPN25TOEdDMllr?= =?utf-8?B?cS9ES21zV2Fzc0xnOVZHK3h0OEduYUJ4QWpUaWdTbE5IYUhOcUNwRHlGeU12?= =?utf-8?B?YWtaNWdMOGx0Z0VYTUhsbFZNUTB1MlN2dC9FaGEvVlNRT2oyTnNpQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5aa943-e0eb-49cb-c446-08da38077fdb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:16:48.8632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wyGsG6Mr4/HSEq9cif/yw8T5elTEr1+GLLT5rLeeTVSL0LBUMdyxvnzWr/UhyqV3zR9W20Pl13tDoQF33qqMPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4953 On 07.05.2022 06:26, Demi Marie Obenour wrote: > On Fri, May 06, 2022 at 12:59:05PM +0200, Jan Beulich wrote: >> On 05.05.2022 07:38, Demi Marie Obenour wrote: >>> @@ -1077,6 +1110,35 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste >>> if ( EFI_ERROR(status) ) >>> PrintErrMesg(L"Cannot obtain memory map", status); >>> >>> + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) >>> + { >>> + if ( !is_esrt_valid(efi_memmap + i) ) >>> + continue; >> >> Instead of repeating the size calculation below, could you make the >> function (with an altered name) simply return the size (and zero if >> not [valid] ESRT), simplifying things below? > > Will fix in v5. > >>> + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type != >>> + EfiRuntimeServicesData ) >>> + { >>> + /* ESRT needs to be moved to memory of type EfiRuntimeServicesData >>> + * so that the memory it is in will not be used for other purposes */ >> >> Nit: Comment style. > > Will fix in v5. > >>> + size_t esrt_size = offsetof(ESRT, Entries) + >>> + ((ESRT *)esrt)->Count * sizeof(ESRT_ENTRY); >>> + void *new_esrt = NULL; >>> + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, &new_esrt); >> >> Nit: Please have a blank line between declaration(s) and statement(s). > > Will fix in v5. > >>> + if ( status != EFI_SUCCESS ) >>> + { >>> + PrintErrMesg(L"Cannot allocate memory for ESRT", status); >> >> Neither this nor ... >> >>> + break; >>> + } >>> + memcpy(new_esrt, (void *)esrt, esrt_size); >>> + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); >>> + if ( status != EFI_SUCCESS ) >>> + { >>> + PrintErrMesg(L"Cannot install new ESRT", status); >>> + efi_bs->FreePool(new_esrt); >> >> ... this ought to be fatal to the booting of Xen. Yet PrintErrMesg() >> ends in blexit(). > > Whoops! I did not realized PrintErrMsg() was fatal. > >>> + } >>> + } >>> + break; >>> + } >>> + >>> efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_size, >>> efi_mdesc_size, mdesc_ver); >> >> The allocation may have altered the memory map and hence invalidated what >> was retrieved just before. You'd need to "continue;" without setting >> "retry" to true, but then the question is why you make this allocation >> after retrieving the memory map in the first place. It's not entirely >> clear to me if it can be done _much_ earlier (if it can, doing it earlier >> would of course be better), but since you need to do it before >> ExitBootServices() anyway, and since you will need to call GetMemoryMap() >> afterwards again, you could as well do it before calling GetMemoryMap(). > > This would mean the allocation would need to be unconditional. Right > now, I avoid the allocation if it is not necessary. Hmm, I guess I don't see (taking into account also my own reply to that comment of mine) why it would need to become unconditional then. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 13:20:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:20:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330850.554251 (Exim 4.92) (envelope-from ) id 1nqx7S-0002ZB-Ua; Tue, 17 May 2022 13:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330850.554251; Tue, 17 May 2022 13:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx7S-0002Z4-RT; Tue, 17 May 2022 13:20:10 +0000 Received: by outflank-mailman (input) for mailman id 330850; Tue, 17 May 2022 13:20:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx7R-0002Yy-UH for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:20:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12c3228a-d5e4-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:20:08 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-dRoJaMrPOiSuXjrw0jTiSw-1; Tue, 17 May 2022 15:20:06 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5227.eurprd04.prod.outlook.com (2603:10a6:10:17::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 13:20:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 13:20:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12c3228a-d5e4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652793608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hBJI6c/5rUG5eJm2EAjii2sjsrogCPgZuNGKlo4sUOA=; b=aUZqlOISOAC2KPlqpZIhoR5VPTqwsskpzPSAKJRQ2rtFfqP599QMwiXI8bovWedHB3FLwk zL20Kt8+pYg0JUqoO7H/FEL/ZxKMvTVgHRP9UrNBZkdeyJVd7qSiLBOIAkVNE7rWbN2EqC ldKePVRreS3BrepRUbWMnW9/IaDuQW4= X-MC-Unique: dRoJaMrPOiSuXjrw0jTiSw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9EBYH1gRi+jcvfKLbp1Pe3g19cSrRre7YnZOmAfUwD8uqQzHniWsUl+65WoGPSdYGk3b4qIKq2Cc0pzrvAVvpZzk+fS+16JFZq6fMkghESVWa+Owjr3q5Jtx6in3WsDFSMeEG7djIjeuqcluBGtxpF+0J2A36zjC55QA4X8FGNb3ePmEwSFosb7H1sFo4v/qEw4EVJiFSzXIN7oEDis/SKFewxRSzllHkJgevgma13QdmwVlDKGHA3FnDMBtY3dAD7BemM7zAT26Ks+UJzpyuTYDR8HIqFO8HBDC+u5WWZQK3TFkwzHjlvcUcfgejlj9gEVkkHAh2T0fSpkaMY3ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBJI6c/5rUG5eJm2EAjii2sjsrogCPgZuNGKlo4sUOA=; b=Vdwd3xm8uPjETBFWdMZRqiZtrd9PCV0ukrBDUlsKcD28onlI5bA4LO9CDD/XhOPue/Luamcmnu8lyN+tegEyZs0HaoI8PLMs8fcmq2/YAhDiWt/s8vBp7r9ZASJHL/5Xdl5PvIZiI2mVPVqWxLIXvtf9BXzaj7xHJtIHfdYq5zp/P82MpiDY5q+sxV15h1X3ipPplfjasF9E8hbYLhUu6YT7X/ZKykU2px7KRb6TBuAiwanwza0WA4DQuJ/eHsDl3OYj0cV5LFVBU8Nqf7aPa25Vyu7btHa7ci/+36O/9Iv9eWBkAfY0HXAFPZUjNNnpvZbRftLuW4cdCIfiw8Bt0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 15:20:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Michal Orzel Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-2-michal.orzel@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea8c1dea-d65f-449b-96b5-08da3807f4a3 X-MS-TrafficTypeDiagnostic: DB7PR04MB5227:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 16XvUtJ08O8WCIw0tvD5BY7WlT+73KVD7xTtSUouu6eJMpNDxWtfS7Z9OllGeDnztJQC7LO8CRuQeZFGvChC5K4zWZRPIZuFf/DAZrA5vimDw0n72Z9NbVHu9uyPADJY4lSYE0ObVC8QNQVA2ipBfxah28i+YFNNJaAEu7cFSeoU+a8DirriPqDK3Bq5FBFff+FzPrpW0cCB36YkJ9AG4TKyktC5ijXf3hKmRRrZLjDXA0eLAhD3yEaW5BaFdO0PInuwyb6jKYT+KC3O7dTKommJ25zcqwQfKVj2k4gn1ROZOHjpTBgIdm4p2pjsCAAvbIiOtyu9K7Gimwdnr6ep8UsnE5szij9D04C39gxAciAlmFOEdOxCV+lzYZpi1EOenfxw0dIQNh0HGtbhswro9MPEDhykkBIFtiALBU37LtzfyoR0oStwND3+8LWBzmeilUE0PzKkkah5NTtVi2lQms70UBUhDeJhUdOKVa1sy5DV/7H2k0yKQVgo8CPzZiNai2JNzNnR/hY16SlS6gI6jmTE8iyc1ojYtCFj9PUck0DQ8iF1rQJLrQpxmzB8OMtKIPtvkATtk4lb5e0y9Xpdxopkwyw/ixQwhu5689jxNbqjhbK6RMayyOXMjNP86k+rtSvW76qFM/1bUdO+oBjeZQ7fVDxmYC3Pb5ivXK/b6ESz8QzrSWuM4JJq8EKuYG9LfoZSKlyFj3YAb/QUS7xrudK5LrnnaAaq4AD8PE5O0R36ctMKArnKTSN0BYwOlBcO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(6506007)(186003)(53546011)(508600001)(54906003)(6916009)(6486002)(26005)(6512007)(2906002)(558084003)(31696002)(66946007)(66476007)(8676002)(4326008)(66556008)(6666004)(2616005)(5660300002)(8936002)(83380400001)(316002)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3pFVjFWNk1RN1pOZnlwc3VQMjY5M004QWg0M1UxWlUvblJkRDc5R1VWOFFu?= =?utf-8?B?TExnaUhEWnQxaXluMkF2VkhIeHlFcUI2ZU9tRm5UcFRpTmxEdUY5cHlIYk94?= =?utf-8?B?NTJaQWtJSVdZUHI0SmtrLzdpN1VXSUliR2F4aWFDRXV3QU9XR0p1ZENqMXVP?= =?utf-8?B?MWRyTHBjd1NSYlNOUThZT05GVmtPNS94WnZ4MFlQZXVkeDhqNVVzeE1hWnRO?= =?utf-8?B?OWRoQ1U3KzZXVGV6eW40Q2ptN29sVWxtWVJRZllvZVlkRldRbTQ2bm1QTDMx?= =?utf-8?B?bXh2czN4RjdnNEc3YmpiSnBFb0RsOGJGcDZCNFZ2bDZLSWtzSS8waUgwd05o?= =?utf-8?B?NUlKcjhnVC9SMWpoUm9LQnplVlREU2tHRHVkbUJxTkNtc1krbzFKbjMxU0N1?= =?utf-8?B?clFVR05paWdTU3dCS05kc0pPaWJkMDFVMEwzd0VkeVBaOStWbFJJaTQ5S2RT?= =?utf-8?B?TlQ3MG8yQUZXNlRlVXJ5eXFrTXNRSWRqS0MzSEhGRFZnSy9UZjJzQ2dWTUZz?= =?utf-8?B?U0d1THJZL2IxOWJvVTRmWHhnaVZTVzFZTFNFVVhGTVNybFJxNTc4VUNzN1dJ?= =?utf-8?B?akJMN2Vibk9UZU94T2JndmVETHNLcGJmUjJ5VnIrMWN2K3pDVzRpY1NJYUNw?= =?utf-8?B?TXFYbWdNT2lIT1djbHpZYXhNei90STFWb0crei96ejZBeEtybXF5bzRlQlpI?= =?utf-8?B?anFieUc5VHJnRkhYTnAzbk5MblF0b21aMWo3cHpYMUhKQ3ZTUGJQb1lER0N5?= =?utf-8?B?cWlqdEZaeFpKU1kxNXRVbGEyVGM2WGN2MTlEWDk5L3AyNFd1WVh3ZERuNnBq?= =?utf-8?B?V014VW52YWwxb1ZTUG02YkE5a3dCTVNPWGVDdDJxT2ZvRDc5cVVxaGh3SHk1?= =?utf-8?B?QzFZelRUbFdDSnowNDVuNFMrdy9xYjVtMG40OElDL0tlQzBaMHNYT1Zrak12?= =?utf-8?B?aWx6L0dTVEFDMXhEYm95clNmaXErQUJUK2cxeU53dUQrcWtVdWxsY2d5ek1t?= =?utf-8?B?UWt5ZUdUMDY3bHcyMk8yVnZlSlUzSitVbVlkaVg2NUYwVWJYdUlEb0lTWGxo?= =?utf-8?B?bzFGeVI1dWc5b2pGS0pmNENUb1BmTjQxZnlJMmlMTlJsQ29oNXlITS9GQnNx?= =?utf-8?B?UFllczRsUklZbTdKaVpDZCttM1lPQjR5N3FhYmt5dGFON2pTYi81am5XQ0do?= =?utf-8?B?aWVDbHdENlV1eHJxNHk0S2lOazVsVTNIbEI0SFEwNHRqMG4ra00wQktvZUp5?= =?utf-8?B?OU14L0FvWTRqdFZZelFFdWVBYVRlY2JsS0o2LzhyQjlVdHlPbldmZ2puNnFV?= =?utf-8?B?MEE1ZDFMUEFyeGdUMzBnS3h5NVFoY29taTVDaWdYV0duYkxDMTJSaElJVUZ1?= =?utf-8?B?YzA4ZmR3WG5jbThqRkdZUWttSUJFWmVQeDlrTmVxVit0NFFhTVJqVFNQc3Np?= =?utf-8?B?UW5iSnkzQkpuL09VdEJ5QlFCd2RsUy8vdVVCLzBYWGgzc2w5Y1k5elFub2lC?= =?utf-8?B?TDZka1NSV3gvbXFOYWVRWW9IWURCdzN3KzVmNTRJam4zdW90cTJkQTdFdGJz?= =?utf-8?B?dmNLaW5FNnVSR2orNm1kYUZNNnRWSnBKd1ZBakQwVHdicjVvTzdxSE4vazZZ?= =?utf-8?B?NU9ZalYyaVVTYW1jekk4VnJ6TmREUzAzNDhLUUZoZytIbC8wVlVwSkhDUk5n?= =?utf-8?B?ZlNNTFQ3ak9nak9oVXYyYSt2LzJqSzd0UkNxNmROcjVzVFFtUStaMm5Sb1Bm?= =?utf-8?B?bys3bmRKZENpMGI2b0tVQ2pXZVFEZFhjNDNCVy9MQmxIckFRVTNULzQ3VVQ5?= =?utf-8?B?cmU1YnBERjlhbFYrdzZPUmFMQjZyM2FmWnM1WXFUazZianlCOCsvcjZKU2hS?= =?utf-8?B?QkNmOGltcXBZRWNna0ZKZktCVlhzbk9FckJHTEhpVXdNNWpxNHFRNlNNWG4y?= =?utf-8?B?c0dQbUFKS05CLzRXZFFUbE41Q0FwT1VTWE5UaWMzSWFNc0x6Rm9YMk5FR25R?= =?utf-8?B?YS9RdWovM1NMZExTcXhjY0M4cm44cFYzMm4xN0kyK2daL0JaeUZZRHhEd24x?= =?utf-8?B?Q3hSMlN1SXZISWZqNmp6VjlXdng3SEVEdGxpRENoa1N6Njc2ZXExMFdXVTVi?= =?utf-8?B?YUliNFF1ZEp2TC9TdTdtcUFxc2ZKQUNBbU9wb3pZRjM3ZmhERnhUSlBTRjhy?= =?utf-8?B?TUVPR1gxaWNSMUtLbUpROHVBMGVhZ3dqUHhlL3JCS29PV3EwdVp5Ni90R3Aw?= =?utf-8?B?TUQ3aVMxMGZUeXJaYnJvM1k2d1RmbWdxMlZWM0l6SDdHSjdIZW1LQUVKYVBZ?= =?utf-8?B?bzE2L0t6YkE5azY4NUdSVFBrSlQ5YWJGNzFodmtuaHhUdUpXNy9Udz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea8c1dea-d65f-449b-96b5-08da3807f4a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:20:04.8509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lImLzNDlI0ZSFLzrobbXbIwenNOyfuBI3TnR15RffTSGuB9WhET04ddXy2GILXagjGFyKv7USWoFCHDrhQ42sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5227 On 10.05.2022 08:52, Michal Orzel wrote: > Do you have any remarks related to the second patch in this series? No, I have no further comments there. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 13:22:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:22:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330859.554262 (Exim 4.92) (envelope-from ) id 1nqx9V-0003Ec-F0; Tue, 17 May 2022 13:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330859.554262; Tue, 17 May 2022 13:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9V-0003EV-Bq; Tue, 17 May 2022 13:22:17 +0000 Received: by outflank-mailman (input) for mailman id 330859; Tue, 17 May 2022 13:22:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9U-0003EP-4r for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:22:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cf0d629-d5e4-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:22:14 +0200 (CEST) Received: from mail-sn1anam02lp2047.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:22:04 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2863.namprd03.prod.outlook.com (2603:10b6:300:122::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 13:22:02 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 13:22:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cf0d629-d5e4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652793734; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=lrbKR/eASyOKoQqAK4lVjmym1N/PKpOb0FZaPhSCNN8=; b=e5tsgXsj6xRuGpgDsUMRTlsAiTKdU+vHtrzMPoP3o6UMG/7uWy68eWyx yJhP2wzYWbj6Wd30sCcZYpDDIc/tmq9uv7q0VHZ4Q7Vh2ru+l5uz6KHNM CNCqJuGW0ylO+7yu6NW4uNZvrvox1UQOJxP6YPCDbdv6/d/Jid7elQy/8 M=; X-IronPort-RemoteIP: 104.47.57.47 X-IronPort-MID: 73990232 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A8tBQq+Juc9VBQYD2Ww/DrUDQn+TJUtcMsCJ2f8bNWPcYEJGY0x3n WEeUWmFPqqMZGH1fN12YNy/pksO7JLQmtdgQQE+/Cg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHmW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnZ28eAouEIDupMcmcTsHIgI9NvddpoaSdBBTseTLp6HHW13F5q00SXoQZMgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvqMuYAwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKGwJ8AjO/8Lb5UDRlzdw1/vqL+HEf/fSHc8Op0vEp mT/qjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiFO4HdRWK EUW+y8nhak06EGvCNL6WnWQo3OavxhaR9tZFcU77h2Azuzf5APxLmoOQyNFadcmnNQrXjFs3 ViM9/v2ARR/vbvTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz Fi3QDMWgrwSiYsQ0fyy+1nC22iovsKRElFz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6zt3OH06bK3I6Qcyg== IronPort-HdrOrdr: A9a23:FHl8na1KG4B4vHT81TMkDwqjBR1yeYIsimQD101hICG9Lfb1qy n+ppkmPEHP4gr5AEtQ4exoS5PwOk80lKQFqbX5Uo3SODUO1FHIEGgm1/qa/9SCIVy0ygc+79 YGT0EWMrSZZjcVsS+52njfLz9J+qjDzEnCv5a8854Zd3AOV0gW1XYaNu/0KC1LbTgDKYshD5 aH/OdGvTCkcXQSYt/TPAhCY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC L4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKvC/VXEO0a2SAWQR4Z fxSiQbToVOArTqDyGISC7WqkbdOfAVmjzfIBGj8DneSIfCNUgH4oJ69P9km13img4dleA56o hvtljp8Ka/RCmw4BjV9pzGUQpnmVGzpmdnmekPj2ZHWY9bc7NJq5cDlXklZ6voMRiKnbzPKt MeeP00JcwmAW+yfjTcpC1i0dasVnM8ElOPRVUDoNWc13xTkGpix0UVycQDljNYnahNAqVs9q DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOUMOm7LqZTw/LIpjdvaDqAg3d83gt DMQVlYvWk9dwbnDtCPxoRC9lTXTGC0TV3Wu7NjDlhCy87BrZbQQFO+oQoV4rSdSt0kc7zmZ8 o= X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="73990232" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVBxQ85Gj2rvfLA6i8A42jQruUOSiGbEwM/+aHqzxdGnlJD9Zl/ns9qbTizhWHBtBOJ/yWEaaOY6tZkpx0sIRu2wQ1EpLBU8t3aMTaTmItGvoTd1bhobDeWR+CJYFsOjMQRPTcAg+cD2E+7lcZgNNpApbeXPMOKcKpTHJAH3kuM39FY1JbDismpS3r2ivd+f07hCkx8oF9cf0tRH9i88wn5vg7FItCv2Exe/eXnfK9NFM10PQc6l8kFV7o9Jg7DzmzLrcPpQoE8vglN8PdoS+hnOxX2KvLEsJYyYnUm82EptxNkNN/TjatrYeQZ57JSZEJCUMLubMjvRMRTYseTRGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aK06sWeBw8v0FMu6ocWdptyMHWl4Fc/+SrQ/l2E6g4=; b=d26kdOUaYWFDcC6h7XvccyRkX6w7jea3Ii8lhxf9zvhNwMYIBmCTDrHwc5Lz2wGD1fJalTHGR04LWcNPGwzI9kz6dh0OejKs/227niKjt7UuPh0FjSN5GRwOvswEmDpede6q8z6AJ0coOfs/Jdn6OV3Hc/fgu1wmdtJ1nPwrwd/A0EdiMpWKYrwoW1toCTw0oCNxLI8ZBWTv704UleH0NKDnKWiPuI8SP2SW6Vn5KcNE+M+lSrmSweuaGjt3XsIG1smFn3JvaZCgd5pPYPh17StDcD4Y1GwIwF6reMH6KZWckF4HFcVuBfiK9t5HdLqW1f8VjLJSZKTwf9SQ9xAz+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aK06sWeBw8v0FMu6ocWdptyMHWl4Fc/+SrQ/l2E6g4=; b=evU7x4wKU/E1pkX3T9H4D1ObUh4P9XAhxIprAUnWWrpxs7S8f3624p64/0F+HfWPxtZAqTclhOgbrLUvEOliYzNNw/5rGErJpYHO6YrZRjOJChVlm//AYJxQVzsTKQ6Jgtn6nuRY1fbDsmc9fM7KNMZ42dlpceD5+xMYs9tow1U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH 0/2] x86/vmx: implement Bus Lock and VM Notify Date: Tue, 17 May 2022 15:21:28 +0200 Message-Id: <20220517132130.38185-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0446.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7489a23b-6ad5-44d3-5608-08da38083aa8 X-MS-TrafficTypeDiagnostic: MWHPR03MB2863:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jO48oE39nH0Yn8LsLYOVznbOiZE0TjAvghTOIYKRyaoCLoHHORsvnYsc6mWInAFDkVhALtW4sEqSBioiIA1tbWCSEaVS9JwEMi/eIpeGi9uho+GYBaZJdK6VKaJj0GkW2GirxYuat/Os1SXrJC8ziqsQnoF+xTr+f/OAuoggX9D5LxcCrPgZLk2EXIfTK6tj5har9a0SVrxxJd5pIXQx2GG1nlfAOLG6GLlcOSoW7egs1Ugk9jZ0+X8qSJRZAMXWWgbS7ox04IUMjoPx5dBKXjoOhUaAQZ0GLBXFnq7jWx3vUGrFd5O5pEX7TdZv15MLAaiRDzoczjmO72oi6i8mzpcBU0SOynlBxlJijJbvT6NZTWyHXFnPJzjmzBH3LIbPkehrg3iP87OTRQMFceyd67UTrhbdivYyDn4o7s9+oO4JjHoUNsxg1SM+BGBFmfAzPKy/IVqCJ4MCVcoT9AzOVrSOI7bunopj4DUIAh06uP8Lh+gPgKPNQ5Y+bpgfH7wGimfWMRJ6wGxz2+jME+jfcaCeiHOdYnTfvyLB8WvbtP5uxqCxc349xLt9cqXqhn7NgSgGmzi8Df+4D+9RPLHVfcdHqz0diQmUi6R+mIFHs2c6AZ3cXZ/e4rUC4YxI5wvcloSQIo72B41SKSStESBb1A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(6512007)(82960400001)(36756003)(66476007)(508600001)(54906003)(6486002)(6916009)(6506007)(86362001)(4744005)(38100700002)(83380400001)(2906002)(316002)(5660300002)(6666004)(8936002)(2616005)(186003)(66946007)(66556008)(1076003)(4326008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejljdFZvZE9PcTJPYjVhTmVkNmZoVlRFeFROT09NK1dJMjBrZXA1YjI0aC8x?= =?utf-8?B?Q1FkcDRCa3hIanZKbDFpcmVsL0FOY3BrYXo0dEw4emFYWW5IUVFvazFqVnpJ?= =?utf-8?B?VUFjQXZ4TmU3MFdoQ1FCamE4SUwyeHJSbE5KbnJiVkpXMldqMEFRaGVkd05Q?= =?utf-8?B?NjJoT05vUStmVWZIVTdvTnRPMkpMNHczOVFhNVJLWmNyLzVVZ1lCSFZ2UWpS?= =?utf-8?B?RHJtSW1WcVkzbzVMaE5rekduQi9VUzJRS0xHSVlPUkEzVGcvNEVBVmhnTjNl?= =?utf-8?B?K0FjbmNDcjV4dmxaSUR0YzA0eEZ4QWIzd3I2TzZDVVhOMmVsRXQ1aTVJdHli?= =?utf-8?B?NGtFRkxMNU5Uc3Q2NVBJS0dQZ3dFNUFSaFlhRkJsL25xWGViODJMdmphdWdL?= =?utf-8?B?NTUxdkRNZlF4M011V3JxeWN5UitodHZNY3o4WWdsVkZuZ0VEamtvQ29LZVpq?= =?utf-8?B?bXlQV2ovTjY5dTdtNVZMRlU2bVNVeVF2MlZYa1dONnVLc3NGR2dvUEpRaTU2?= =?utf-8?B?T1JRUnRxYVpERWFKSXoxa2IzTVZqSHJJVEl3UWJaQ0tNdW9OOURXRmp4VVRF?= =?utf-8?B?UXhVNDk5VDdOUy9QU1lBejFhMzVJQkMzaFM2SmxCWUNXUXFwNTJpUlpGTlBu?= =?utf-8?B?U2RyM3k4UjR3S0lGT01Sd3FPSThwbGREeFdIYmlZUEFVVjlsWkYxSWxqMUFS?= =?utf-8?B?bmRUcTlKQWtMSUVVbU5tcVRxVmwwNzVneWpaYVhqdWNUTFpWcHhvaHRwNjNW?= =?utf-8?B?U3RYQXkxWXdzZFdtaU5YenZWY3JBV0wzSDUwTlhZMTBSdkdNK3J1czV4Zis2?= =?utf-8?B?bW9QUkNJd0hTN25aTUJGeEU3bHYrdU5aYWQ4UGxJKzErVHdzaXZxMTJGTzZS?= =?utf-8?B?WXIyR0pjR0x6ZVg2ZlptUjhPNFhMcFhtT1pZQmxFV25oVVlPQVJRNXJzTCtn?= =?utf-8?B?elZuZllaVkRhMGdHbTdYVTFzNUpVUENxUCtIMW5nTm1vcEpHZk12S0pTcm1s?= =?utf-8?B?QWM4am9JVW8yNmtyaUl2YTNTc0FVV3c2eC9KY0pYQWZmTkc0MzJTU1p0Q0pQ?= =?utf-8?B?VUl0K0N2WktPZHB3VTBZRU5MQXg2bjh3WTZxNHo1ekZlbzljQ1E3QkFJTjBY?= =?utf-8?B?aFJMSGZpaFljQVE3Y0xuQWxQanlrVXZ0b0tZMlZsazJodU9ZdGEzQWVXc0E0?= =?utf-8?B?bzFBb0JXSW14U2ZZMWJsd1hlVlIzTVkxKzhQZEVETDFDN1ltSVBrQUpiUExp?= =?utf-8?B?dFk2VFFHOUQ5TVk4NnNDL3A0UWJ3b2czQmE2YkFBWCsxaHdGR1FaSkFYaHl6?= =?utf-8?B?d0dBL3hkOUg1dm1KajIxMGZIWGFsbkluSW9UejNVdmxXSVVUQVRIdDBHaW9t?= =?utf-8?B?NFJVUWVyYTJ1S25HUDJOTDBkTlVKc2ppYVJ6R1JTaHBzNHhHc01LazM1ZnJu?= =?utf-8?B?ZXRKREloQW5VUFRHK04wb3BYRTN4bVR5VEFWRWFmRmljOEtUSVgzZU82WlNi?= =?utf-8?B?SXBkZzErNzJPOEg0Y2ZjNm41dFJQaFlkUlhSR2h5ZFFtR2I5WVFXNUNQV1BZ?= =?utf-8?B?V0Q1SWprczRPak5XTUVBUEVENjB2ZmU1anhGcU9LSEcvd3BDZk9jZGZKT2Jn?= =?utf-8?B?QlNEbXRxV0Fpa0F3eXFVZ3Yyd21iTEVQNVZETUV3cmdRenBsQ0lMSnRxY0JW?= =?utf-8?B?d3dCVE5WRWtnK0JESFhza05jQWEvNVppODAvQitsWFBvaWNEbkE1ZGRQL3gy?= =?utf-8?B?UkRUMzlzVEZTL3YzWURQK3JRekpMaHBCZkYrZlJxT3k3ZW9ieVVoSmllYnpC?= =?utf-8?B?aGM1bmNFc1ZFTTJERUFoOHdtcjNEMmJ0emQ2NFZ0QkR2dDQ3MENIWHZvQzE0?= =?utf-8?B?MCtrdlluOXJpdVBpeERDVVBlb2krVmZhSmtkQnBRamZSTHlnMWtyYmNCdzBS?= =?utf-8?B?NVhjNjJGWTFSSkFIbnBhYU90WVVXZzZuTVhRL0E3dFZpbTdoRlo0NitQVHRp?= =?utf-8?B?aFRLbTh6ZXJhU3pZTjBETHZtczZCUUxDblB0R1RSRGNtVVVnYU5HSVZVYjZU?= =?utf-8?B?ZmtjWG8zQ29STmpHdVRaRldXLzBBbWlLTUFRRDdIMDZaZEp1TE5NKy9XcDJK?= =?utf-8?B?S0NkcDNxU3VMVjRBa3FPT0dVZTB4NHR4Slc0bktlTWZWd0FsenBPVERnN1Jh?= =?utf-8?B?T2ZDTkNuRTEzRStIeGlDaUMvS29LME5HZWJEMDd1bmJleHRJRWhuNmJFY05m?= =?utf-8?B?Uy9mVmtPU3JmZjFPOVA5RWRWM3UrYXZkallLUSszdUUycmtOaGp2RURUa2J4?= =?utf-8?B?VzFsK1BnU3pjVkx1eXNVU3UrV2pEOXNSSEp1U3h5ZlBQWjIwRkRxQmRMS2x6?= =?utf-8?Q?Ch4xgO/JFwclUr2Y=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7489a23b-6ad5-44d3-5608-08da38083aa8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:22:02.2756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2qTPvQw9MYAeZl4BfHWlJQrrGvg0d6YiLOltWJgHI5giV4P8ps/SnDToGJXSk56AJ4BOkZKOoKpM4jPwiboyLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2863 Hello, Following series implements support for bus lock and VM notify. Patches are not really dependent, but I've developed them together by virtue of both features being in Intel Instructions Set Extensions PR Chapter 9. Thanks, Roger. Roger Pau Monne (2): x86/vmx: implement Bus Lock detection x86/vmx: implement Notify VM Exit docs/misc/xen-command-line.pandoc | 11 +++++++ xen/arch/x86/hvm/vmx/vmcs.c | 22 ++++++++++++- xen/arch/x86/hvm/vmx/vmx.c | 42 +++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 7 +++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 8 +++++ xen/arch/x86/include/asm/perfc_defn.h | 5 ++- 6 files changed, 93 insertions(+), 2 deletions(-) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 13:22:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330860.554273 (Exim 4.92) (envelope-from ) id 1nqx9X-0003Uu-Ng; Tue, 17 May 2022 13:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330860.554273; Tue, 17 May 2022 13:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9X-0003Uj-Kd; Tue, 17 May 2022 13:22:19 +0000 Received: by outflank-mailman (input) for mailman id 330860; Tue, 17 May 2022 13:22:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9V-0003EP-AX for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:22:17 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e74159f-d5e4-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:22:15 +0200 (CEST) Received: from mail-sn1anam02lp2045.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:22:09 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2863.namprd03.prod.outlook.com (2603:10b6:300:122::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 13:22:07 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 13:22:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e74159f-d5e4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652793735; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=pOm+i5JAdWUwAraVuKUnIlBtJtehOQzbFezAfJ3DcqU=; b=VSCxBbsSo+290RWouU6uyHmZIu68TWkyckZ2DqbiuKECv3I/16NsCxCc wR9qCnjgyeRpoJCO5NqvIA9Y/3YlV8GArU9hGDRh7L1jZCRqDxJTWqHGO D1oeCyf7G87r+gJLoEuRByc+0LyT2FsF7XvyjOUPLSc9bH54MSBrTzvpW w=; X-IronPort-RemoteIP: 104.47.57.45 X-IronPort-MID: 73990242 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kbz7naCqvIj1+RVW/zPiw5YqxClBgxIJ4kV8jS/XYbTApD920zIBy GAYUGjXMqqDMGGkfdxxYN628UwBup/SnNIxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng3dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPha8 cdxpaLhcD4pN7zom/83UyFUGjBXaPguFL/veRBTsOS15mieKT7X5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8yeK0nJzYYwMDMYnMdBEOyYf 8MEQTFucA7Bc1tEPVJ/5JcWw7z51yGlL2cwRFS9j6Fo4kjellRN8rHEHurpf5+VGZpnpxPNz o7B1yGjav0AD/SPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fVmmp7+/g023WdNaI mQV/DYjqe4580nDZtrwQRy+5mKFtxg0WtxMHul84waIooLW6QuEAmkPThZadccr8sQxQFQCy Vuhj97vQzt1v9WopWm1876VqXapP3EcK2YHPXUAVVFdv4Slp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjnNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:8CStJ6HRHcEu6KgwpLqFYZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+twKH LajfA31AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGQ9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9wwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgjf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3FosPD30E1wsK7VcKM0lt gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ny4kY1jiaGgOKsk8SgDwgq+yxokJz8eXX7FN5KcOuf 36ISZlXCgJCg/TNfE= X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="73990242" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5ajGRf6YBpofDg1cIx18I74HKi88Vy1rj7Tsvko/I8ZNn5B9w0cFPDdnRylIKkTbiK7Pyn1jAVS3hA4SMBnKVYmdG0AeryQUZA6UCE6vl3HoIasupC2rTKi4YN34YqxP/NRLFQg16BK3J6ZbN8zMx9d35DWSD34FmIgrlx4Ygj68zEgCW88Eb/50SRPNtsbmWDbsgH40WYPgZyYtF2eeEnrP89cdrSMxrmus5UzUdv2RHHaLXCDN67i5+qta/lpHJc2gv7w5HA/ekAlBwJ9fRa6vITNESubBYUeVVOJufJSCLylRDbeKD36PbGOlJV+6AGEu7zEeA67N/Y5Uip7Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iNfREiG9nWIHx3lpEV4C+Dr+1tG6YO5Ms4iOxJIfvy8=; b=gv7wXWNg9agDtPZ+9JrpjmSJWzF8CdY07rtvFuV5bGl/Ab2NMIL623LXW0YWweEQzcTqbkkA/juhPxYw3KUVEy+EA5WEluuhF963Cz0sLnriAV4bbt8/oyW4ZUJ45kmzJtnyZR7OJGRCRqWGX9J7uwKJ8GIhqyivHx5h3vIDL8G8pfTbc5VuOgtzNG3x7KTwCZVnwAp1kuA9nuJpsYaz9Diyas4rcm7eCph5SpXQMGsW+a113430/JwvL8TZ/zZVk94nx39M/Z9d2vj8B3YfV7Q8Tw1aVBE9bayfGaZBoPZqBplk8HRoMCZC3XKhHzrQpb8x/II3RhopqImLErBcjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iNfREiG9nWIHx3lpEV4C+Dr+1tG6YO5Ms4iOxJIfvy8=; b=OFWPSUJjN3ciTejzcN/Q36Nzlc8W8fa81vVdytsYH1HSkdcR1RZ45A008YCQMCfKmE0UMbeDsZh28K69gpAndj/uf/qth9Lv12eQUhRPJ1BhABjAARtZqiQqHpBUxO/bWS8spKMCUwQu2/3GdpVW8N3QGmi24K2u+F4aYLkZfsI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 1/2] x86/vmx: implement Bus Lock detection Date: Tue, 17 May 2022 15:21:29 +0200 Message-Id: <20220517132130.38185-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220517132130.38185-1-roger.pau@citrix.com> References: <20220517132130.38185-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0038.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76cce606-8dca-47b6-1ae6-08da38083db2 X-MS-TrafficTypeDiagnostic: MWHPR03MB2863:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g0Kdrzu4qWA6vk4bAXEttEqS4V4JlrCW+3DzNy9hOrYkqfp+z4sU7HUz2w7Hqz1ghPzZ0LOoWNDntM3nwWDTCNZkUtAx03YHGMNjN3QgZo1yee19jyH49Zqf/sUB81KB3YLUDpmh+t72fN3LBVgZhZ6YTgdeWj93ItAG/v05uSq49UONvwl16MzPhzAvoJz9GzxzBZizmfGn9kH9X0/9aFx2OSSJSrF/lwc8+uffZ1KQruIRNyRGIVh4dAlGePcxTElgGCLUu59N3SCx3Ov5IQCz3d8sZm3FE1wSzmOUEPLYV6T1oOLJsaA5cdE4SHbV1xA0bt3WPdKPXu5MnvnsuefR7qfLsDnXj2HTvvyUyb44zyqa5N6oGlL0UdrHJhkNzX9M0+PJXP5GEf/eIKO5sI6mtsstgDCnbpyf/yC+zCbo0Kwhg1zzfaKhmo9R2olgnYHwWyx+zDsOcpIh/VR0Vw1qYeHRRvhtf8E7bpdnsR2Ui/jPMvgnP/Rr6CmWN+UHJPVKw9yxg178Isf/pFucYzBU/quKNGkf0KlfdXEdFh2FGj4ekc6a0LGOigQjZxUE4xyiX31EW7RSDM1RyocIJnHkbybsUDtm7TFQDaDfIQaErRPV4ePRRnkE3nt1YIlcScTJ6IO2gjS0ujRRbdpRkA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(6512007)(82960400001)(36756003)(66476007)(508600001)(54906003)(6486002)(6916009)(6506007)(86362001)(38100700002)(83380400001)(2906002)(316002)(5660300002)(6666004)(8936002)(2616005)(186003)(66946007)(66556008)(1076003)(4326008)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUFES0xYcDYvMklhM3o5MHh2VjFMditBaERmcTRualREY09PNVpNc0dicWtU?= =?utf-8?B?M2g2bXFLenY3SElQR3lFWjZYdzZaOC8wRGdnUGxTeFpPd2RpUExrYU0xU0Vo?= =?utf-8?B?NHR6QUdoSTZvRjNER0QxRXlLWi90ZytGbER6TWFPVjM1bHU4MmVXcUdEa3NN?= =?utf-8?B?d1h1RGw5Um1LbGNrZytwWUFPVk5pbStTeERianE2M0tRN0JtWUZDb05YUlpo?= =?utf-8?B?WXlkREhuZ3hPUnB1aDZoYTc0V2dER0ZtSyttYXhFdG9ZT21JbHF6aC81SE1M?= =?utf-8?B?Z01NMUViRGIzdzVsaHI1SVg4UzRGOHJNbGZWWlc0SVB6emxHT1J6dEFoVWxP?= =?utf-8?B?bjg0S3lWeXNSaHpwQUxYTzB0VUYvMjU2dWFHMjFBc0ZSWkwvY25JcEgyQW95?= =?utf-8?B?UUV6UkxNT21EYUNOejlLWUxvOFhwL21oQVlsb1VkSVdRMjRyRitDcWQ2WERi?= =?utf-8?B?UFovL0lHcGZaRVJQUVFMTGFvZDZibkx1dEZzdlNCajIrc3VmSXV3bTRXamJt?= =?utf-8?B?UEpQRjVNTktkR1dzby9KZmN0SnQzY09qMEVFTlBEeGt0ZGVoNGNnODA0RXNE?= =?utf-8?B?QWp3S3c2STBDZDBYVTAvOGJBVGRxZDdKclJlWTBNVnc3SVRja05sTkU2cmVQ?= =?utf-8?B?SFlTdGpzRmFIcHBNRlFVWDAwaW1heG9wZFUyN0gzRnN5ekpoSXlpRnUxSHhn?= =?utf-8?B?aTMyQmllU2RvVWo2MXBMSTQwRmc3d2p6dnZpdEdNU3dWZWs0TktndDhWbmhm?= =?utf-8?B?bGZMTnNUY0ZNVXNnaFF5VHZvZVJzbGIzSENiWmpKMDZUelVXRHF5bmgyVDBv?= =?utf-8?B?bDViaCt4KzEzQjRpYmdyYVNpUE16dkNUamwzYUlkVVFSYUxmM25GU0tXV3VK?= =?utf-8?B?UU91bFFpbWtaektCUXpCV3BRWVdnK2tPbWhxY1dEM3FmODJrOHBDU2x4TEIr?= =?utf-8?B?ZGs0ZGM5YTZDQ0k3bFk4anVjZGl1dGZ1bkF0OW0zWS9wQnZvSzdjeml6S0dq?= =?utf-8?B?R2pQS2hDSStGNVBiOE80QUNTUnhlWVdlQlpLUU5jeWpQam9GR1R3TnhuRmM1?= =?utf-8?B?VTRMdksrV1BTMlZ5V0VqK0txaExuUkJwR0NNUUlJY3hZQ0dNdm1XVHFoUnZo?= =?utf-8?B?ZEY1VnFUSXBiU3Y4Qm1VaHo3L0RGeVBWZnhheGxIZ0t2cUlZTHdQZ0ZsZDR0?= =?utf-8?B?c1ZHYU9DTG0xOG5DOE9TSXJuc1ppOUJpaGRSMjh0MklveDdMU3hzazI4QkMr?= =?utf-8?B?V0tSbTdXV0c2S3FLQjU2N3REUFdrVjBBdW5wNDZwQW1YeGNqSFg3ejlBNG1o?= =?utf-8?B?akkvcU5wMFdpMFFIa2NTTTNINnd2OUkxL1gwMmZERU03eW9sL0JWS2RVUFRP?= =?utf-8?B?SGZDSlphZFhEay9rY1lrT0pJSXU2T3g4Vll4ZmVRQmlCbDBnN3J5RHlEb2JQ?= =?utf-8?B?MTRvVm1RV0NEQ0lGdHFQN2JleVdjRHhEYVYzYWMzVWNPcms0U1NHT1ZKdS9h?= =?utf-8?B?ak14cXZjYSsxdHRHVmVZRTdTZjE4MjdLYXhSVGkxY0xHeDlpNnd6aGh0c3Bp?= =?utf-8?B?SlgzY1lIWlFOVkdzQUtWMmpjcWtFUFZNK0dxYUNnL0x1dGh1TlVmSll1ZVFa?= =?utf-8?B?WlFmaDhiTEpxUmNnNjdBSVRhZC9ZNlFVV2dPQy9EbU5OMStmWWwxWVNwdXBF?= =?utf-8?B?L3JSaEJRRVUrb3A0TWw0M0JMK0VBY1RiVFZqY1V2YjVyLytTMnIrdi9rSFFr?= =?utf-8?B?dmFwY3ZZK0hhYTdIeFFGdjhDbko3K1p3WmJ1RFErVU9RaGs4WEUyTVNMV2R4?= =?utf-8?B?cGQ3WUY2MlJkdUQybHFnaEVHS3NtL2RBV05hSkxWSnlHNHRZWmczUWI3ZlJ3?= =?utf-8?B?OUdCSHhTSk40dEFidnJ0WnB1Z1kxMXZNL1lEUnkxOG9QSER6aXJjSFNnM1Nx?= =?utf-8?B?cU5nOGdHZXlwWFY2VlJUV0pvTFBkakZZT0VBRHl4dENWck0vZTZ4QkVLU29H?= =?utf-8?B?ZVkyNkVlZVM2bm1rQ3pwdjd5dnpvZjd5NXVDMi9KUE1iSUphQUdWdEw5ZTNZ?= =?utf-8?B?ZGZqaFdDNnhJYVpKbFhPWGFCNzlVaTdJTFVrNDhXTzRBaVdIRnlOTHliN093?= =?utf-8?B?R1JOQnJJRlVrbTNWV0R3QVhSYXR6OHV1NHlFT01jdXV0TW04K2dDQlJRTldu?= =?utf-8?B?Mi9WVkJxMzdRUkE0K2ZGZ2tUell2Y3BjU0lrYnBDWWthT0hldnBNTE41TGRP?= =?utf-8?B?eExNZVExY0N6MWVlZXZJNzRveGUxQU1HRExBYnZkRVI2MnlCdHRsQ29TeWJT?= =?utf-8?B?dFNnZHVLeWV1Z2czeGFmZ2c5d0ZPZS81T1ozRGZXS04xaUYvcllwVnNmZWw0?= =?utf-8?Q?Ok9RjNCMbIouIDYo=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76cce606-8dca-47b6-1ae6-08da38083db2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:22:07.3728 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MWCrYiWnZ4duClhIWxy9bL9IW7zE3Hn5gfFaTzU7huYX457uKmNSfZPCRTYX/FfNXPv0rMJFxyekBWrnFMrD2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2863 Add support for enabling Bus Lock Detection on Intel systems. Such detection works by triggering a vmexit, which is enough of a pause to prevent a guest from abusing of the Bus Lock. Add an extra perf counter to track the number of Bus Locks detected. This is done because Bus Locks can also be reported by setting the bit 26 in the exit reason field, so also account for those. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- xen/arch/x86/hvm/vmx/vmcs.c | 4 +++- xen/arch/x86/hvm/vmx/vmx.c | 18 ++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 3 +++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 ++ xen/arch/x86/include/asm/perfc_defn.h | 4 +++- 5 files changed, 29 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 56fed2db03..d388e6729c 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -209,6 +209,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_virt_exceptions, "Virtualisation Exceptions"); P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); + P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); #undef P if ( !printed ) @@ -318,7 +319,8 @@ static int vmx_init_vmcs_config(bool bsp) SECONDARY_EXEC_ENABLE_VM_FUNCTIONS | SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES | - SECONDARY_EXEC_TSC_SCALING); + SECONDARY_EXEC_TSC_SCALING | + SECONDARY_EXEC_BUS_LOCK_DETECTION); if ( _vmx_misc_cap & VMX_MISC_VMWRITE_ALL ) opt |= SECONDARY_EXEC_ENABLE_VMCS_SHADOWING; if ( opt_vpid_enabled ) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index d03e78bf0d..02cc7a2023 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4053,6 +4053,16 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) return vmx_failed_vmentry(exit_reason, regs); + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) + { + /* + * Delivery of Bus Lock VM exit was pre-empted by a higher priority VM + * exit. + */ + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; + if ( exit_reason != EXIT_REASON_BUS_LOCK ) + perfc_incr(buslock); + } if ( v->arch.hvm.vmx.vmx_realmode ) { @@ -4549,6 +4559,14 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) vmx_handle_descriptor_access(exit_reason); break; + case EXIT_REASON_BUS_LOCK: + perfc_incr(buslock); + /* + * Nothing to do: just taking a vmexit should be enough of a pause to + * prevent a VM from crippling the host with bus locks. + */ + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 9119aa8536..5d3edc1642 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -266,6 +266,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS 0x00040000 #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 +#define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -345,6 +346,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_XSAVES) #define cpu_has_vmx_tsc_scaling \ (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) +#define cpu_has_vmx_bus_lock_detection \ + (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) #define VMCS_RID_TYPE_MASK 0x80000000 diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 8eedf59155..03995701a1 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -159,6 +159,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) * Exit Reasons */ #define VMX_EXIT_REASONS_FAILED_VMENTRY 0x80000000 +#define VMX_EXIT_REASONS_BUS_LOCK (1u << 26) #define EXIT_REASON_EXCEPTION_NMI 0 #define EXIT_REASON_EXTERNAL_INTERRUPT 1 @@ -219,6 +220,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_PML_FULL 62 #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 +#define EXIT_REASON_BUS_LOCK 74 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index b07063b7d8..d6eb661940 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 65 +#define VMX_PERF_EXIT_REASON_SIZE 75 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -125,4 +125,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") +PERFCOUNTER(buslock, "Bus Locks Detected") + /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 13:22:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:22:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330861.554284 (Exim 4.92) (envelope-from ) id 1nqx9c-0003pL-5p; Tue, 17 May 2022 13:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330861.554284; Tue, 17 May 2022 13:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9c-0003p8-1d; Tue, 17 May 2022 13:22:24 +0000 Received: by outflank-mailman (input) for mailman id 330861; Tue, 17 May 2022 13:22:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9b-0003EP-7Q for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:22:23 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 610414a6-d5e4-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:22:21 +0200 (CEST) Received: from mail-sn1anam02lp2044.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:22:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2863.namprd03.prod.outlook.com (2603:10b6:300:122::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 13:22:12 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 13:22:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 610414a6-d5e4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652793741; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=1NnK6uV3ib0UW4lXjhVSINBMuSLjKvS6LIHru8qbsbQ=; b=NUx6Pm1m1XdbL/ZG4gDpjv3J+j9AlhFdwoHyxq0fyKM2X9w665jttv7x n/4nAJV48dx7EcbgokF+j85yYiw5Z++96Zt3KU8NPeXLceDzLP1fuA8lD Yl1hRvMcXmU22IoJJnY7fvWSna5TskINt26hMONqTvtCjLSIzvw9t+pbb Y=; X-IronPort-RemoteIP: 104.47.57.44 X-IronPort-MID: 71351309 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Xbo3AKosqwNwJw5TV2xCvxJJwBheBmLaZBIvgKrLsJaIsI4StFCzt garIBmHM/nbamPzftgkbo209kpT65KBm9NlTAdk+ypkRXsV9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 Iyq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBMIjSlvkDdz1iSx5cYIp3yuHtGVORmJnGp6HGWyOEL/RGKmgTZdddwcAuRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFg3Fs2qiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3M/vduuDCCpOB3+P/2EtP+VNCAfpl+mF67p HnX70/TUg5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz FDht8ztLSxitvuSU3313rWJq3W0MCscL24HbAcFSxcI55/op4RbphHCUNdlVrK0h9vdGDfsz jTMpy8774j/luYO3qS/uEvB2juqr52RFAotvF2LAiSi8x9zY5Oja8qw81/H4P1cLYGfCF6co HwDnMvY5+cLZX2QqBGwrCw2NOnBz5643Pf02DaDw7FJG+yRxkOe IronPort-HdrOrdr: A9a23:pNRCiaEPexpi2s2tpLqFYZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+twKH LajfA31AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGQ9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9wwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgjf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3FosPD30E1wsK7VcKM0lt gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ny4kY1jiaGgOKsk8SgDwgq+yxokJz8eXX7FN5KcOuf 36ISZlXCgJCg/TNfE= X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="71351309" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxux9H1nQubDTLutIuUjwg5hCM8WRZt14A5g+wZYjup0XF1IVPcO3Fihms9KQyokBcoVqD+CuZs/U0tMd5hG5utpiUxGMGFni/JyAG/j6hPfQjk4NmWiasd9HvR+yw3PMfk2aVraf117UYB4KMG2gDPtkbySvR5E/0kRJd844BlbBdiq2VtAvQxu9zve7K5widcXGI0jYZKGR5GZtrPaEkteLOBwsxw8ddzyqJlegZu6d1S8AZsjXKRINpQAPRmgpCy+kiLTTkZeLgv4T+AFgYmQci4xT4BRaRCGQjngmFPIWiuuEqgT4SlCHvyhQKRlhLq7ny6/Au88TXxqwNZAgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8wL5+yQNrse2PhUfI4MIRngtSyTQoDYLPTdJvdUZMQQ=; b=hx1Nrj3S/f2/fh0qwQPFd7yfEFqZ1L/WWOdSy2vyiuYe4Y2WeJjVXN/bMBVkQ4SGWkvb7NFsB7eY8I+2S0m1NSTkcH8UkgBdEgIw2+TdIoajAL6QpbUXwu3xvXOpwk7t8ytNPgFua/g0bxdXFuvzyk2n8V0vPoMZNUqtsLJPrCeMLW0hrKamC0eKz7ltUB6XPsJ/EzEQb4ErLEEOl3Y+JWbkmPwagMmh5UIUHsKHVvZLsT8W/Aewh98K2Am8zlK6k/w7wdxkin4cR3EsKgVnQuJi2o+NYEXnxPvX9D/r+bJo0NQLLGG3Al7A9tIZkZAn0OLqz6pghqI67kr1dtPb9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8wL5+yQNrse2PhUfI4MIRngtSyTQoDYLPTdJvdUZMQQ=; b=ir0FHIrjGgGnV/fSk8mSEWmFz/i/+w/jKe9/lKTJ4y2638X09bLgoGrAt6HlSde+TDLbXiWS7gGcqTlBhJg+shggcHFBbOcUiuvVGXTuIbbee0BKBFWGhpvvKtlsHIpCzt5fBtqJUF6qGxpG5Jn7ikq1H766YW5kZOg3E1NEdzw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 2/2] x86/vmx: implement Notify VM Exit Date: Tue, 17 May 2022 15:21:30 +0200 Message-Id: <20220517132130.38185-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220517132130.38185-1-roger.pau@citrix.com> References: <20220517132130.38185-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0469.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94656900-73bb-4d6d-50e7-08da38084095 X-MS-TrafficTypeDiagnostic: MWHPR03MB2863:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVdmDcHfjBkjzmOLC4u2KjkZc3lHOD0N5NjQVbybF2RhdZOTonk+eYneRCsdjrj3DgZuZUrbe0wzXukLn8ubgMZGIFNtgdRI8EBeL07AIvDp4K5p9KcdBXttniu/5PcAzHsUlCk++I/1yqjrjv1Ax8GDieUH+FteLhB3Xp9wfQiFY1GHadMl2TPkfNkNNAmi4m7RBAQJ8qOcsqAz8URZNiV3dDQLmb8MrWiqquZqFVBBN1lRJj8u6cBAI5XA+RMePHSs+fdKvF6WOklW0+0WCB9t3oIZ1XWvLFfHdHHBcVJjA+2TgFFursUtF8HkBAbnOSjtLjA371bJP9N10HXKdkYx/pM53gA3Md1cPqQJ8gnxhqx4oQyAHLO7hTOjoqiYHPdw5oEv7el0EDC4he+UnpAF5AziON5sH/Vtd7REjfmd3Eo019Dn2xpJbvRjjiIPKdl05IT/bEPhhvZQ0znq83vD5fEl+eNaxfpErm0jGqryp9YNP9bxOZ4WUYEDsIdFpx3civZjUUC9wnmZN7+2L6hQqveWcEv/vNPPdVMNHXKbaj37dsFSNTBn6WrPSJ5J1ELVs2wJMPeTrBN1bxwyY/rzaKLPFJtklIzkx2nSQAHeZ4SWDV/stIoTaI3Yi2pufWQfKKNx7ceCE2DPjcC+Fg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(5660300002)(6666004)(83380400001)(2906002)(8936002)(1076003)(4326008)(8676002)(186003)(2616005)(66556008)(66946007)(26005)(6512007)(82960400001)(36756003)(86362001)(6506007)(38100700002)(508600001)(66476007)(6486002)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REp6YkdZQTIrbFc3S283UXRISE5hem9WTjcrdzJsQ1RwMzEvZnVtcHVzMUd1?= =?utf-8?B?UWhYOUQ1T2tKYkJPMEZXclRkN2FGd0xVaWtTbVdlamkrOTlNai9udS9UN2g2?= =?utf-8?B?ZElYUXU2UzZ1QzZDaUszL1pTSmRld0R4Q09EVUdaQ3p3MmlJdzlxYnB2MWlF?= =?utf-8?B?VW9NL1J4dDdiYmw5M0w5bTh5c0ZLa1hrblBGTU90Mk8zQ1o3SUM3MXF0UUpI?= =?utf-8?B?S2xsNVpYTUxGOEszZHBNNnF0SC9TcWg2SVJVT3lHc1craW8xdlZEdEM4WHoz?= =?utf-8?B?NjcvM2NpRFhNcGhMc1FJcTE2SVRFeVY0WWJvQUtqK3JUR2QwUDFwcjZxS2lo?= =?utf-8?B?UkpxL3dqdXNQR0RtNWl0Si8yVnEvMW9JVjNxbzlLZzZ3WWdMbkx1VExHZE9N?= =?utf-8?B?Q1JORlFIS3hPOGhtL0xUUmNiOVFtT0NKQzdHVS81YmtBdU1ORzE3cUlGdGZj?= =?utf-8?B?KzRrY0hJeUIvTkRTTnlQdFRITmNyd1hXbWZ1WHNQSlBsTmpUeEpEVE01dEI4?= =?utf-8?B?aVBOclNZYklDOUhNZC9GSXp6VUhnTjNONTd3OEhTcFpQdUpZRFVaZ2hqWkpn?= =?utf-8?B?Z29Ba3greGRNN0Z1bjVreHB2ZjFRV2I2N0NuZUE0Sjc4UGNxYm83cWx6WGhL?= =?utf-8?B?S3I3alZaUFNEaXdMaWlmWjcrRGcwc3FqZUZQS095YnUrN3RQY1J6anFGbTg4?= =?utf-8?B?K2dNRmxTa3g5L3dYRmcyRkN0ei9vbXB5ckExbkJVeUNLSlhoOGNRLzJyRHpi?= =?utf-8?B?OEh1TXZWNldYWlR0Qk1VNXl4ZUJTanl2N2VRV1NTeFp2U1ZraExpemJuLzNJ?= =?utf-8?B?Rm1HSU0wUnBPQlk1MnFIcTlWUUZhNXhJbkF2SmU0TTE4SGR4MkxaYStGZjRG?= =?utf-8?B?N0VJYm0ycC93THVVdkhqQXlMaGJzN3BzL1p4VVc2TGlid1pYQU0wQWZTbWNI?= =?utf-8?B?S2xOMEcrYTlMaWUzVC9wLytZUEpwVUxES1JXRDNkZGtpMVo2YytrZUYyVVlz?= =?utf-8?B?QUxNZzQ1R3hCWU5sWVRCeEhOSnh6aW5xamJnbVFtbWovN21RY0Y3VFRBUzRM?= =?utf-8?B?S2s4SlBRVTE3VjVya09nbUI5ZFpkV21qTlJBRUYwUUZMS3hSekt2V0U3OWcw?= =?utf-8?B?bWJBZmFrTDZyUXcyUEtEVFpNblRjaGJaZVNCNC9LUnJKdUxwUS90YjZFSnJ4?= =?utf-8?B?UE02NVlzS1ZPdU9iTGhpNUVDWE93ditCUUpVVHQ2dkRNMUhYZ2tlcnVrQURR?= =?utf-8?B?SmxqY0NDSWJOK2dPRk5xRWFhTFFNNW04bGpReTUzU25wMWw4Q2FjcDAvOGpu?= =?utf-8?B?Y3ZHRkNnbDdFeXVLamdzZWJBMTRHWEhMK0tVbyt3SmR0NUt6c3UxU1czUWNK?= =?utf-8?B?NE50VWhUa1ZzOHQzeS96aWVFU01LRTJUZWRvbWtqT09LWXd4MzVUKzBKTVdQ?= =?utf-8?B?TElrUXIvelBQaFdrM3VaUTlmYnN4ZGdSWEQyYndiR1hLbUF3QUZiR3U1YS9K?= =?utf-8?B?dFlTY1ZlcXhnQkNSTjFnSkxweGNidVc0ekhYVExHZTlDc1dmcEpoa3NVekxI?= =?utf-8?B?YjVIN1A1T0pVQWRDdUpoWDNueVhkUmt0VVZMcXUxQTJNK3JuUjJJQWdlTU84?= =?utf-8?B?OUJ0cVZ1SFdYS21LRkJSQk5DRzlSL2NJYU1vbHNldmRrdVhiY1pvVXFiMHpK?= =?utf-8?B?c3R4K29iQ2d1ckZSbys4OXNNMUJWVzhJN1NZaUFieVNwUFZ6d2pOcVFRRUFM?= =?utf-8?B?V0JabGNHVGNYK0NObVZOS3hnVlIxbEdTY0lPRGNCTFZNNDZVVE5EMmpneHNa?= =?utf-8?B?K1JPTzV3VTJEVHk0M28yUW5KMll3bVpSUDZqN2JKdVI2RjlwNU9vb29BTnZ6?= =?utf-8?B?Vk05cVlPRkxwUHZsT1FxYlM5eVdVdWsvK2djNW45YmQyYVV4SC9LMlROT3V6?= =?utf-8?B?NkJvUHhITjlhNEJUVFZzUVZFa3U4d2FvN3hGa0JYZkpSOW1VVWREYXd0aTFK?= =?utf-8?B?UFpBck4zZ2xwYXEzZkxzSjI1UUF2cDNIMXZ5SWZBQkJuY3VjcmoxMExTOWRq?= =?utf-8?B?c0wzbEZOeEJIMDAwNlQ5Z0pPSUFZaWpzTkF5ZkRPdU9ZYUpXU2pPZURtNi9R?= =?utf-8?B?a2hwdmJSdmJVV1pFWk9lNmpMK1dFelMycVBTL2ZXQjFjOTluQ2E2ZHV6N0wr?= =?utf-8?B?OStCS2RvUmFyYmsrVmlIenMwRGFQM2xlYzdNM0x4QzYxQTJhS1kzUUJHdHFr?= =?utf-8?B?ZWdnVHBram1DZzRWWm5xK3IrUUt5T0M3Vll2NlI4bHhZTDJ6UTdITGNuSUd5?= =?utf-8?B?OGx0RmhML0laMVU3bHBEQlZRNUIxTFlDVjI1UFIwWGo2S2V6aC83ZFB6L08r?= =?utf-8?Q?uR/YbXFJW4bOVxFA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94656900-73bb-4d6d-50e7-08da38084095 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:22:12.2486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kXzJF0Q2zAk2tywkFmvc6Pt6tHm6Zcj/zHkNDrpbHuyAKrZdyBvV+3f0SMAZ+D6+ZjMU+gIlACXW816vB4sp9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2863 Under certain conditions guests can get the CPU stuck in an infinite loop without the possibility of an interrupt window to occur. This was the case with the scenarios described in XSA-156. Make use of the Notify VM Exit mechanism, that will trigger a VM Exit if no interrupt window occurs for a specified amount of time. Note that using the Notify VM Exit avoids having to trap #AC and #DB exceptions, as Xen is guaranteed to get a VM Exit even if the guest puts the CPU in a loop without an interrupt window, as such disable the intercepts if the feature is available and enabled. Setting the notify VM exit window to 0 is safe because there's a threshold added by the hardware in order to have a sane window value. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- This change enables the notify VM exit by default, KVM however doesn't seem to enable it by default, and there's the following note in the commit message: "- There's a possibility, however small, that a notify VM exit happens with VM_CONTEXT_INVALID set in exit qualification. In this case, the vcpu can no longer run. To avoid killing a well-behaved guest, set notify window as -1 to disable this feature by default." It's not obviously clear to me whether the comment was meant to be: "There's a possibility, however small, that a notify VM exit _wrongly_ happens with VM_CONTEXT_INVALID". It's also not clear whether such wrong hardware behavior only affects a specific set of hardware, in a way that we could avoid enabling notify VM exit there. There's a discussion in one of the Linux patches that 128K might be the safer value in order to prevent false positives, but I have no formal confirmation about this. Maybe our Intel maintainers can provide some more feedback on a suitable notify VM exit window value. I've tested with 0 (the proposed default in the patch) and I don't seem to be able to trigger notify VM exits under normal guest operation. Note that even in that case the guest won't be destroyed unless the context is corrupt. --- docs/misc/xen-command-line.pandoc | 11 +++++++++++ xen/arch/x86/hvm/vmx/vmcs.c | 20 +++++++++++++++++++- xen/arch/x86/hvm/vmx/vmx.c | 24 ++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 6 ++++++ xen/arch/x86/include/asm/perfc_defn.h | 3 ++- 6 files changed, 66 insertions(+), 2 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1dc7e1ca07..ccf8bf5806 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2544,6 +2544,17 @@ guest will notify Xen that it has failed to acquire a spinlock. , and must be integers. The values will be encoded in guest CPUID 0x40000002 if viridian enlightenments are enabled. +### vm-notify-window (Intel) +> `= ` + +> Default: `0` + +Specify the value of the VM Notify window used to detect locked VMs. Set to -1 +to disable the feature. Value is in units of crystal clock cycles. + +Note the hardware might add a threshold to the provided value in order to make +it safe, and hence using 0 is fine. + ### vpid (Intel) > `= ` diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index d388e6729c..5685a5523e 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); static unsigned int __read_mostly ple_window = 4096; integer_param("ple_window", ple_window); +static int __read_mostly vm_notify_window; +integer_param("vm-notify-window", vm_notify_window); + static bool __read_mostly opt_ept_pml = true; static s8 __read_mostly opt_ept_ad = -1; int8_t __read_mostly opt_ept_exec_sp = -1; @@ -210,6 +213,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); + P(cpu_has_vmx_notify_vm_exiting, "Notify VM Exit"); #undef P if ( !printed ) @@ -320,7 +324,8 @@ static int vmx_init_vmcs_config(bool bsp) SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES | SECONDARY_EXEC_TSC_SCALING | - SECONDARY_EXEC_BUS_LOCK_DETECTION); + SECONDARY_EXEC_BUS_LOCK_DETECTION | + SECONDARY_EXEC_NOTIFY_VM_EXITING); if ( _vmx_misc_cap & VMX_MISC_VMWRITE_ALL ) opt |= SECONDARY_EXEC_ENABLE_VMCS_SHADOWING; if ( opt_vpid_enabled ) @@ -1333,6 +1338,19 @@ static int construct_vmcs(struct vcpu *v) rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, VMX_MSR_GUEST_LOADONLY); + if ( cpu_has_vmx_notify_vm_exiting && vm_notify_window >= 0 ) + { + __vmwrite(NOTIFY_WINDOW, vm_notify_window); + /* + * Disable #AC and #DB interception: by using VM Notify Xen is + * guaranteed to get a VM exit even if the guest manages to lock the + * CPU. + */ + v->arch.hvm.vmx.exception_bitmap &= ~((1U << TRAP_debug) | + (1U << TRAP_alignment_check)); + vmx_update_exception_bitmap(v); + } + out: vmx_vmcs_exit(v); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 02cc7a2023..9c37790c36 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) */ break; + case EXIT_REASON_NOTIFY: + __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) + { + perfc_incr(vmnotify_crash); + gprintk(XENLOG_ERR, "invalid VM context after notify vmexit\n"); + domain_crash(v->domain); + break; + } + + if ( cpu_has_vmx_vnmi && + (exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) ) + { + unsigned long guest_info; + + /* Exit was incident to an execution of IRET that unblocked NMIs. */ + __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, + guest_info | VMX_INTR_SHADOW_NMI); + } + + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 5d3edc1642..0961eabf3f 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -267,6 +267,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 #define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 +#define SECONDARY_EXEC_NOTIFY_VM_EXITING 0x80000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -348,6 +349,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) #define cpu_has_vmx_bus_lock_detection \ (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) +#define cpu_has_vmx_notify_vm_exiting \ + (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) #define VMCS_RID_TYPE_MASK 0x80000000 @@ -455,6 +458,7 @@ enum vmcs_field { SECONDARY_VM_EXEC_CONTROL = 0x0000401e, PLE_GAP = 0x00004020, PLE_WINDOW = 0x00004022, + NOTIFY_WINDOW = 0x00004024, VM_INSTRUCTION_ERROR = 0x00004400, VM_EXIT_REASON = 0x00004402, VM_EXIT_INTR_INFO = 0x00004404, diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 03995701a1..a16055643b 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -221,6 +221,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 +#define EXIT_REASON_NOTIFY 75 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* @@ -233,6 +234,11 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ #define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 +/* + * Exit Qualifications for NOTIFY VM EXIT + */ +#define NOTIFY_VM_CONTEXT_INVALID 1u + /* * Exit Qualifications for MOV for Control Register Access */ diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index d6eb661940..c6b601b729 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 75 +#define VMX_PERF_EXIT_REASON_SIZE 76 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -126,5 +126,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") PERFCOUNTER(buslock, "Bus Locks Detected") +PERFCOUNTER(vmnotify_crash, "domains crashed by Notify VM Exit") /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 13:22:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:22:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330869.554295 (Exim 4.92) (envelope-from ) id 1nqx9n-0004RV-F2; Tue, 17 May 2022 13:22:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330869.554295; Tue, 17 May 2022 13:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9n-0004RM-BW; Tue, 17 May 2022 13:22:35 +0000 Received: by outflank-mailman (input) for mailman id 330869; Tue, 17 May 2022 13:22:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqx9l-0003EP-UH for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:22:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67c812f1-d5e4-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:22:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67c812f1-d5e4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652793752; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=v+uvZ0yEjHIALOda2RJFXPU8SCQqSDv+lgj0prZ4Lck=; b=XJ8CTaNdECiMa+SJHwDLoR+xNMMGDD1r0eoF8ttCyZFmMttHeJZzsTTd LoWlk0V28vvHqdlJvICBEhivlL3uVKgr6fdCHgZCgzGowIslfv8t06Ok6 SZXuHTVL8WCBWRyCyA1e4U0gAnLig23RhCPYn7AFCeX0Pn9fcKd+3zhB2 g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71351364 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:X+BUJq+rHJWkA+AsGcJ6DrUD636TJUtcMsCJ2f8bNWPcYEJGY0x3m GccXzyFPv6IZTfyfN0lO9y39EwE75KBzIdmSgc9/3s8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHmW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaDgdw4zFYrpotpDeUVFOSpzGIF5pZaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6BP pFEMGExMHwsZTVNM20XIZRnnd2oj3ThTH5biGq/qaU4tj27IAtZj+G2bYu9lsaxbdpRtlaVo CTB5WuRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO9Fq1giX4Y3x2TjHLDQZZDVMTfAZ6eZjEFTGy WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WvQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sTA3Dt4ade51q2VtW 1Bdx6CjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I90Kv2sgfBs5bJ1dEdMMX KM0kVoBjKK/wVPwNfMnC25PI5pCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY M/BGe71VC5yIf0+kFKeGrZGuZd2l39W+I8mbc2ip/hR+eHGNCD9pHZsGAbmU93VG4ve+1WIr 4cGbpbVo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:le7ldqG21WEiP+orpLqFYZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+twKH LajfA31AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGQ9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9wwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgjf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQy/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKp7zPKN MeTP002cwmMm9zNxvizytSKZ2XLzgO9y69Mwk/Upf/6UkSoJh7p3FosPD30E1wsK7VcKM0lt gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ny4kY1jiaGgOKsk8SgDwgq+yxokJz8eXX7FN5KcOuf 36ISZlXCgJCg/TNfE= X-IronPort-AV: E=Sophos;i="5.91,232,1647316800"; d="scan'208";a="71351364" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Date: Tue, 17 May 2022 14:21:56 +0100 Message-ID: <20220517132156.7078-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for evtchn delivery set up on a per-vCPU basis via HVMOP_set_evtchn_upcall_vector. is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up physical IRQ to event channel mappings. The naming of the CPUID bit is quite generic about upcall support being available. That's done so that the define name doesn't become overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some such. A guest that doesn't care about physical interrupts routed over event channels can just test for the availability of the hypercall directly (HVMOP_set_evtchn_upcall_vector) without checking the CPUID bit. Signed-off-by: Jane Malalane --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu v2: * Since the naming of the CPUID bit is quite generic, better explain when it should be checked for, in code comments and commit message. --- xen/arch/x86/include/asm/domain.h | 8 +++++++- xen/arch/x86/traps.c | 6 ++++++ xen/include/public/arch-x86/cpuid.h | 5 +++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index 35898d725f..f044e0a492 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -14,8 +14,14 @@ #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) +/* + * Set to true if either the global vector-type callback or per-vCPU + * LAPIC vectors are used. Assume all vCPUs will use + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. + */ #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) #define is_domain_direct_mapped(d) ((void)(d), 0) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 25bffe47d7..1a7f9df067 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1152,6 +1152,12 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, res->a |= XEN_HVM_CPUID_DOMID_PRESENT; res->c = d->domain_id; + /* + * Per-vCPU event channel upcalls are implemented and work + * correctly with PIRQs routed over event channels. + */ + res->a |= XEN_HVM_CPUID_UPCALL_VECTOR; + break; case 5: /* PV-specific parameters */ diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h index f2b2b3632c..c49eefeaf8 100644 --- a/xen/include/public/arch-x86/cpuid.h +++ b/xen/include/public/arch-x86/cpuid.h @@ -109,6 +109,11 @@ * field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* + * Per-vCPU event channel upcalls work correctly with physical IRQs + * bound to event channels. + */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 13:28:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330890.554306 (Exim 4.92) (envelope-from ) id 1nqxFS-0005kE-8L; Tue, 17 May 2022 13:28:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330890.554306; Tue, 17 May 2022 13:28:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxFS-0005k7-5O; Tue, 17 May 2022 13:28:26 +0000 Received: by outflank-mailman (input) for mailman id 330890; Tue, 17 May 2022 13:28:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxFQ-0005k0-Qg for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:28:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 396cd6f1-d5e5-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:28:23 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4DBA821CC7; Tue, 17 May 2022 13:28:23 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DE9622C141; Tue, 17 May 2022 13:28:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 396cd6f1-d5e5-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652794103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m8eH28qbE+2Xy0DKW3X9feLJxxFiFeYxt7IWdkwBacU=; b=D3nbGBAQ9bCKnB1WwjJRY0SPMWZeGE7s6okektsDFoMjSCg4MWkDlGu0CaIrnv72L2dSjB TH4hbCd7WNPBQBo5APMhOgzqiXxMfJKdv72h+T8GhDipQ36bscz5ULSJq0aGA9QxAaz7ZE 2DHOtfp4NZ3vqG8gLdmAnQza/SAFmg4= Date: Tue, 17 May 2022 15:28:20 +0200 From: Petr Mladek To: Evan Green Cc: "Guilherme G. Piccoli" , David Gow , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , Linux PM , Florian Fainelli , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi , Stephen Boyd Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 2022-05-16 09:02:10, Evan Green wrote: > On Mon, May 16, 2022 at 8:07 AM Guilherme G. Piccoli > wrote: > > > > Thanks for the review! > > > > I agree with the blinking stuff, I can rework and add all LED/blinking > > stuff into the loop list, it does make sense. I'll comment a bit in the > > others below... > > > > On 16/05/2022 11:01, Petr Mladek wrote: > > > [...] > > >> --- a/arch/mips/sgi-ip22/ip22-reset.c > > >> +++ b/arch/mips/sgi-ip22/ip22-reset.c > > >> @@ -195,7 +195,7 @@ static int __init reboot_setup(void) > > >> } > > >> > > >> timer_setup(&blink_timer, blink_timeout, 0); > > >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > > >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > > > > > This notifier enables blinking. It is not much safe. It calls > > > mod_timer() that takes a lock internally. > > > > > > This kind of functionality should go into the last list called > > > before panic() enters the infinite loop. IMHO, all the blinking > > > stuff should go there. > > > [...] > > >> --- a/arch/mips/sgi-ip32/ip32-reset.c > > >> +++ b/arch/mips/sgi-ip32/ip32-reset.c > > >> @@ -145,7 +144,7 @@ static __init int ip32_reboot_setup(void) > > >> pm_power_off = ip32_machine_halt; > > >> > > >> timer_setup(&blink_timer, blink_timeout, 0); > > >> - atomic_notifier_chain_register(&panic_notifier_list, &panic_block); > > >> + atomic_notifier_chain_register(&panic_hypervisor_list, &panic_block); > > > > > > Same here. Should be done only before the "loop". > > > [...] > > > > Ack. > > > > > > >> --- a/drivers/firmware/google/gsmi.c > > >> +++ b/drivers/firmware/google/gsmi.c > > >> @@ -1034,7 +1034,7 @@ static __init int gsmi_init(void) > > >> > > >> register_reboot_notifier(&gsmi_reboot_notifier); > > >> register_die_notifier(&gsmi_die_notifier); > > >> - atomic_notifier_chain_register(&panic_notifier_list, > > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > > >> &gsmi_panic_notifier); > > > > > > I am not sure about this one. It looks like some logging or > > > pre_reboot stuff. > > > > > > > Disagree here. I'm looping Google maintainers, so they can comment. > > (CCed Evan, David, Julius) > > > > This notifier is clearly a hypervisor notification mechanism. I've fixed > > a locking stuff there (in previous patch), I feel it's low-risk but even > > if it's mid-risk, the class of such callback remains a perfect fit with > > the hypervisor list IMHO. > > This logs a panic to our "eventlog", a tiny logging area in SPI flash > for critical and power-related events. In some cases this ends up > being the only clue we get in a Chromebook feedback report that a > panic occurred, so from my perspective moving it to the front of the > line seems like a good idea. IMHO, this would really better fit into the pre-reboot notifier list: + the callback stores the log so it is similar to kmsg_dump() or console_flush_on_panic() + the callback should be proceed after "info" notifiers that might add some other useful information. Honestly, I am not sure what exactly hypervisor callbacks do. But I think that they do not try to extract the kernel log because they would need to handle the internal format. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 17 13:45:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330908.554317 (Exim 4.92) (envelope-from ) id 1nqxVl-000893-Uf; Tue, 17 May 2022 13:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330908.554317; Tue, 17 May 2022 13:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxVl-00088w-QM; Tue, 17 May 2022 13:45:17 +0000 Received: by outflank-mailman (input) for mailman id 330908; Tue, 17 May 2022 13:45:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxVk-00088q-VE for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:45:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93af27d2-d5e7-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:45:14 +0200 (CEST) Received: from mail-bn8nam08lp2045.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 09:45:12 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM4PR03MB6910.namprd03.prod.outlook.com (2603:10b6:8:45::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 17 May 2022 13:45:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 13:45:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93af27d2-d5e7-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652795114; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=jU7c4ZqUIfMVP2JbQuSMyIPZXMy9TlbwXes7ZeAEAk0=; b=bxCGhJ1Vw+Tchg96/bh9qiy74gVPMbq9knYA39BOjJyUGyqn8UmebrAh qLz5isCTiuVqVKTp+se6iypci4PatgzAItKatT3j5LrAuJgPYbIO7niZO QJmh+mP2+OKzmwyQW4Xuwi3NwRtvK6g7GN+F4GiahvRcXlctGdx9hl+5p 0=; X-IronPort-RemoteIP: 104.47.74.45 X-IronPort-MID: 71354686 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b0xV06M0d1U9PB7vrR3QlsFynXyQoLVcMsEvi/4bfWQNrUoggjUPx 2MXDDvQbv6MNmT0eYx/bou+oB8PvZ6Hx99kSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Ew27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7 /xNk4ONWCoSN7TKn/g9WT94MT4uMvgTkFPHCSDXXc276WTjKyep6dM+SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5HdafHs0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx3SSjLW0GwL6TjatvzXL89i8o65LCYcrOPdOnStRvnEnN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3uFuqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxa5UgU0XtNRF6gw7lGLw6+MswKBXDBYE3hGdcAss9IwSXoyz FiVktj1BDtp9rqIVXaa8bTSpjS3UcQIEVI/ieY/ZVNty7HeTEsb13ojkv4L/HaJs+DI IronPort-HdrOrdr: A9a23:LYJCq6r0ESOun9Fk4NVNjBYaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71354686" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dj2dXEr7NIe56KBRywqMKNA0gSm72DycRPoxpowYT7TBw7f+QsZgt0sWBSDqnqJZNdJsi7ZufIX6efH6lBAb3AUauB/usjB/AqbX7YwPeDfDb0U3pEyUCq91DZX/8AcXRBbOxwZPRvTbjnGngggiVoBslh0tWftWnDPvvByL8buNiHpVGDitw+xbap2bC9JwjL48FhoStiYe7I/llWp2FwUDSu31ZVs9YZHU5tmgZ2g0TMOCmCYZJgM5yNZX812xY2YBGxb9eKwPilOYKutgII7iJrelagctv1+KP9/DuhGnly0O1OMvgKSWYbcdjGYUUXqaFl11VFLKuKNg3VHLyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FCgELYNiii5OflNmNdqvnabfzbEXNHklRCa1gE+H6NM=; b=e7kqv/0k4G8+hBAqnKrUQgYbhCx14Vw9OGmB23C7eC/1UHpIyxeuB8USV6zBJS79TX5cUGF3gzgIKu9NIwX0142SdNIzw8H/1uon4CpvfMuvozArjyqS/QpSzDrBU9qZrK9Qsut6g7TSK0Qo8VhPixOzOHM9jOg+z8UzFaIfwFs5zDd+S61WaUGEEaxdk6j2blJ75j8AOBDSm5/UIzuTPUG46qZDb7SAYY0MHKUas/fwC1fx3Xo7rkXkjJMG6FIa/fuNMcjDyW3PSpQfKyDk96TjpAIzq6JLQi6wDG7izjhaR+ddFQGLvUKCjNOG8nBIfK//1Kem3UdsKbHHzsadaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCgELYNiii5OflNmNdqvnabfzbEXNHklRCa1gE+H6NM=; b=VxR/s8+dgz0xliIyF3+vkSEl94QqcRZ5cWmP0eaIBs3OjX/R5LiDWYcs8QXnf/ToMyZVIG6UisOEiHo+wK3iKd6CQDJGz0yeNrx9x6I+yQpNwz6XX1Be1OGusup3vAOwD9ryz4LsGnaY8plCXttnW8IE/1Oh4vGGTy2e4MLTO6M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 17 May 2022 15:45:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Message-ID: References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-3-roger.pau@citrix.com> <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> <5ba9bc92-6cb3-7d7e-150f-077c709acc3a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5ba9bc92-6cb3-7d7e-150f-077c709acc3a@suse.com> X-ClientProxiedBy: LO4P265CA0005.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e099987d-fcb6-4288-b254-08da380b7638 X-MS-TrafficTypeDiagnostic: DM4PR03MB6910:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1DZNCU2PcsKN/3sytyCRm/vWZanlfSQ7IFnxQioSt8hq8tf0c59GOp7HK4nhAzLE7TrlfEAlYBv/iJwvlIbd/3xcXnoY2wIp5Z+YPbaEHVSMo9sidpq2HGXUOnc/nk+t5uWTnn0IKxR66ySO1RVpSkvGNRvdBHBgxqW56md8SCzcovwaU6FNrxJ8N51GLl43ekAIp73q0QXYWJiNoHaGL+0w8xo7emt974qVmGkOv0FIg7GTsyLy+6kYrh9WcC9HcQYRNN2evimfO2Uy7H8LrekkHLb1v9cDIGs7pY43Xgi0f6BhIfV3NO/znuP8yDMUz58l/iej4+eiuG0vuITL7u41eTbasObwfyR9Y/v1yKms6T81mVXdE3jNJ+DYEIMNT7eiTtVEPtZI28nQ//ySPZK+O5xQ3426c1+AFC+a8PFQGJoNuLtqRabJvOtnNo1hd0sGpfNIPjOfgOq6kVPQ6SdnHNJhx3IgqY9fyd4bF3aDCBS0u3L3n13caY3fCHX7djHpF2FZ28+F5CwRalniaM8qh6CrG9wAv7dK5oO77fjUrGolz4dOmuK8Isg9aq2STgQXb6g+JQVWnrfUu0YsYQyfOR04D7OyGfMq2RywSvIl1HJ3vANWcT1v9ZnLq3hBAPOWHZX/KvITye6HvS1pQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6666004)(85182001)(82960400001)(186003)(508600001)(6916009)(316002)(54906003)(5660300002)(8936002)(6486002)(33716001)(66556008)(66476007)(38100700002)(86362001)(83380400001)(6506007)(53546011)(2906002)(9686003)(6512007)(26005)(4326008)(8676002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1paZ1lPcTFCaktaOFpzbEQwcENEQ2xpL3NMRmgxMVZQbXhrK3Nwd3hYQXpH?= =?utf-8?B?V3R0ci9MbnVYcnpKYWJvYWtVWUxxYzJ0a2VHbUFJdnlmTzEvQUJ5aDNrb0VV?= =?utf-8?B?blFLbHlmcnk1cWRyWTZjNFRLSVlEd3FpVDl2eEVWeHFFRGQ2b0Z6MzdudzV1?= =?utf-8?B?dmpwb0o0VVpPUmtDNWRYaTNoUTJtWnJtTUh6MDUrQkNJSDJPTmhxWEVoaWdW?= =?utf-8?B?Y3UxNE9KNDc1NlU1MXU5YjVhTGVvMkVnWHpob25GMDdQSVZEY0grU3RjWFRW?= =?utf-8?B?bXg4Ym9paEkwK3FBeUxVNkVkT2tYQzN2U0hKTkFOcGRJRTdmbWJQRWszUnVq?= =?utf-8?B?TjZLTVlaRzNJMzRWa3JOZlNWNjliRjBhcjRXM1hzT0U3L290M1E3Vzk0czR2?= =?utf-8?B?eFBVRUlMTVA5UFphbGIwTFJoU3JoZzNkUGtQaEczeXFYT1BRYkF4VGFNK0Zj?= =?utf-8?B?L3lPbzZYaTBLbzVaKzhtUC9lL0JQTFdVeXhIV05CZGMzaE5mNjlaNUc3TUFQ?= =?utf-8?B?R2JHWjFacVg2c1FvWG9yYW1GVHNlUWFPYmtlYWwwZk5PNm5kTDNqcGhFbEdz?= =?utf-8?B?a0ZkaFFMd2RkRXQwTTluaDZCNDFKeWI3bWJEQVo5QjVCSHZudjlFOExPajNa?= =?utf-8?B?bFBJREk4Vm1NRkFIbXc5cE9ZV1oxL2VrYnc2V1NkV0IybFRVYWJ4ZVBua0hN?= =?utf-8?B?YlZHWFFXSTBRclFYN1VNZSswSkxVQThNckQvdk9qVGdZb0xDWWJFL2Fwa092?= =?utf-8?B?aVM3dDhvdGh0SEd4Szh1NmoxeWE5amIrZnNqREVjbkZLVFVXRXR1V2VicFR3?= =?utf-8?B?UkU0TEhjQzZxYnpMdUFYZUptLzQ1WGhtNmVvbmpEQ1luTHN1d0JsT0pEZ29U?= =?utf-8?B?VVpKVU1IcXBWOHhDdGxvVm84TzNzdUVSUEhQZmoxT3V4c0orVUFheXVWT3Y2?= =?utf-8?B?d3MvQVYvT1lLbDZZVDhSNE1DdnYxSTRybitqaVFRMGdFQlQ1czFvUUV5Qk9H?= =?utf-8?B?ZDVzOGQ4dHNVczBidzVzUWU2TlBLaEZ6VzlnVlFXZDBYNzJmUXpHY09mWTEw?= =?utf-8?B?alhyeTlwZWpJNlBIM1FnNnJsb3AyRWlpcWtSanVGbVlxZ3hPay9IQkVzV2RJ?= =?utf-8?B?YWIwRnVNcVJJUmh5bzMyR1RneHpMb3JRNjFTaE9JTjhQdm12MnduOFRzUURN?= =?utf-8?B?eWNNSDNuZmcwWHYrbzl5aDVkd2hSRDZBcFliek04dkZ1OXcrMEpNRCtwRUdx?= =?utf-8?B?WDFyTVNYbDZmVXFwRHlwOTNDTlNHd2J3R0orbURaTy9qQkxkWUtQdHdhUk9N?= =?utf-8?B?Mm1SdkxLd1ZqQ3dYZFAvWHRESkZWMWxETjNYd0M3Y2Y3SjVnZXUyWGhsc2tS?= =?utf-8?B?YVBjdUpVemdlaXh6WUkxTm9BbU9PNi84SUdMZTc4alNjQ0VUaTMrMFBXblBI?= =?utf-8?B?WEpqWE03aFhHMXpNNGhjYmpYdlFCMnNiU2drU0xLeUNHVUJWazFQcFg1WDJS?= =?utf-8?B?dEZNaG1ESjdrZEJDOFR0RDIrTGZsYXlpRHNvck5vNlNoMTFFRzBLNE9mOGF2?= =?utf-8?B?ZWU2U0hoa0lFWVU3ZWdKWUlKdmRVV2hXazBJeGpNcUVpY1k5VithangwU3Y5?= =?utf-8?B?THFudmlub3dEWlNTUmI0aXlPcDI5WG1DY2hYNHNJYjRxVUR4TGYrdk5IYWZw?= =?utf-8?B?UjN0eUxnS0pSaVJXZ3hkOFVNTVRUT2U2QStXRWVONWxMTnNQS3FrMFptL1Rj?= =?utf-8?B?T0l3S1NGMWM3TTNxb2d0SEM1eDdzWFErS2FFQ3Y5YUNmRkNPZXpKSFJOeGFm?= =?utf-8?B?U01LaFlqT3JMVUhPY2VoZ0JYWUowdVpERXRzY1NMY2MvR1ozL09Lb3IrNnBW?= =?utf-8?B?YzI0dnNoMGRYNWJRWm56YXdBNDlJcHdMbnFWbUFBWVMyTkhjRmh0QkJud2tZ?= =?utf-8?B?RlV0cUxVc2RvMlFxcG1URG5BL3EzSWVtWkRmNFc1U09OOVlkbmU1RjBhZkwy?= =?utf-8?B?NTJDNGpRYURGRWJWU3NCUnFaTHlqSmdBYjFYaVBxUUlZWUlRSDZjSmJieXhO?= =?utf-8?B?VVd6UW11MGpNUGwyb1ZjOW44elhIaHJrZFc4bUd4OVN1bzBDeE9ReE9RbGw2?= =?utf-8?B?S3k1bXZiWm5ZalRPb2txaWY1NzZDYjdSWnhYaXJkelBwb0pBQldQUCtYcGtx?= =?utf-8?B?MnZjQ25rL1BHWHFVYWdnNzFpQjJCT2didXJPamdMU1FYMnRBbCtzb0xuM29a?= =?utf-8?B?QmV2a3duMHpOYlR5STlyaU96ck44TGFEellzRjdRdTE3NVg1R2IzSWI1WE1a?= =?utf-8?B?U2doV3UwVldEeE5mYXlQazl2dEhIV0cvOGcrOEcvMXEwZGtSSTJWMFNFSi9W?= =?utf-8?Q?mZlZRIGXQDv1UaqY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e099987d-fcb6-4288-b254-08da380b7638 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 13:45:10.8069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JxlW+jYqVROrQFytdK+TaPhgItorqlb4iy7v4NSG546taFqfWqef0Fg1Lww48P5u1ZRCYFAAB+aA9/dGg7bx7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6910 On Tue, May 17, 2022 at 02:10:29PM +0200, Jan Beulich wrote: > On 09.05.2022 12:23, Roger Pau Monné wrote: > > On Fri, May 06, 2022 at 02:15:47PM +0200, Jan Beulich wrote: > >> On 03.05.2022 10:26, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/cpuid.c > >>> +++ b/xen/arch/x86/cpuid.c > >>> @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) > >>> raw_cpuid_policy.basic.sep ) > >>> __set_bit(X86_FEATURE_SEP, hvm_featureset); > >>> > >>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > >>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > >>> + > >>> /* > >>> * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional > >>> * availability, or admin choice), hide the feature. > >> > >> Especially with the setting of VIRT_SSBD below here (from patch 1) I > >> don't think this can go without comment. The more that the other > >> instance ... > >> > >>> @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void) > >>> guest_common_feature_adjustments(hvm_featureset); > >>> guest_common_default_feature_adjustments(hvm_featureset); > >>> > >>> + /* > >>> + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus > >>> + * VIRT_SC_MSR_HVM is set. > >>> + */ > >>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) > >>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); > >>> + > >>> sanitise_featureset(hvm_featureset); > >>> cpuid_featureset_to_policy(hvm_featureset, p); > >>> recalculate_xstate(p); > >> > >> ... here is about default exposure, so cannot really be extended to > >> the condition under which this is put in "max" (except that of course > >> "max" needs to include everything "def" has). > > > > Would you be OK with adding: > > > > /* > > * VIRT_SC_MSR_HVM ensures the selection of SSBD is context > > * switched between the hypervisor and guest selected values for > > * HVM when the platform doesn't expose AMD_SSBD support. > > */ > > I'm afraid this doesn't explain what I'm after. In > calculate_hvm_def_policy() the comment explains why / when the feature > is exposed by _default_. Taking into account patch 1 (where another > maximum exposure of the feature was introduced), I'd like the > comment in calculate_hvm_max_policy() to focus on the difference > between default and maximum exposure (which could be as simple as "if > exposed by default, also needs exposing in max, irrespective of the > further max exposure below(?)"). So something like: /* * When VIRT_SSBD is exposed in the default policy as a result of * VIRT_SC_MSR_HVM being set also needs exposing in the max policy. */ Would address your concerns? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 17 13:57:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 13:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330917.554328 (Exim 4.92) (envelope-from ) id 1nqxhh-0001CN-1c; Tue, 17 May 2022 13:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330917.554328; Tue, 17 May 2022 13:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxhg-0001CG-Uo; Tue, 17 May 2022 13:57:36 +0000 Received: by outflank-mailman (input) for mailman id 330917; Tue, 17 May 2022 13:57:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxhg-0001C9-8J for xen-devel@lists.xenproject.org; Tue, 17 May 2022 13:57:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d87c59e-d5e9-11ec-837e-e5687231ffcc; Tue, 17 May 2022 15:57:34 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5FD4E1F8CA; Tue, 17 May 2022 13:57:34 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 47D802C141; Tue, 17 May 2022 13:57:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d87c59e-d5e9-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652795854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F/28g65NUYRrE0kqo9hb+aIMt4lDnxj7qFXJPB2SFKQ=; b=La0hw1fimyOXZWGy7NhUralYCHdeUAgxZ7Jx2l4teL3ZObgxCoYN3MJlutKivdf7Tw8ScF Jcou2BEeZy+SMDvZr2KkytW34i2oUnUQq/Rvj3HIt6rmBgE0M6mmkljwufeUEZWWTXnkMR l7FZzEHlQDvQ7gIrbLVQoj/qRxAknBE= Date: Tue, 17 May 2022 15:57:29 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 2022-05-16 12:06:17, Guilherme G. Piccoli wrote: > Thanks for the review! > > I agree with the blinking stuff, I can rework and add all LED/blinking > stuff into the loop list, it does make sense. I'll comment a bit in the > others below... > > On 16/05/2022 11:01, Petr Mladek wrote: > >> --- a/drivers/firmware/google/gsmi.c > >> +++ b/drivers/firmware/google/gsmi.c > >> @@ -1034,7 +1034,7 @@ static __init int gsmi_init(void) > >> > >> register_reboot_notifier(&gsmi_reboot_notifier); > >> register_die_notifier(&gsmi_die_notifier); > >> - atomic_notifier_chain_register(&panic_notifier_list, > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > >> &gsmi_panic_notifier); > > > > I am not sure about this one. It looks like some logging or > > pre_reboot stuff. > > > > Disagree here. I'm looping Google maintainers, so they can comment. > (CCed Evan, David, Julius) > > This notifier is clearly a hypervisor notification mechanism. I've fixed > a locking stuff there (in previous patch), I feel it's low-risk but even > if it's mid-risk, the class of such callback remains a perfect fit with > the hypervisor list IMHO. It is similar to drivers/soc/bcm/brcmstb/pm/pm-arm.c. See below for another idea. > >> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c > >> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c > >> @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > >> > >> /* register for panic notifier */ > >> vk->panic_nb.notifier_call = bcm_vk_on_panic; > >> - err = atomic_notifier_chain_register(&panic_notifier_list, > >> + err = atomic_notifier_chain_register(&panic_hypervisor_list, > >> &vk->panic_nb); > > > > It seems to reset some hardware or so. IMHO, it should go into the > > pre-reboot list. > > Mixed feelings here, I'm looping Broadcom maintainers to comment. > (CC Scott and Broadcom list) > > I'm afraid it breaks kdump if this device is not reset beforehand - it's > a doorbell write, so not high risk I think... > > But in case the not-reset device can be probed normally in kdump kernel, > then I'm fine in moving this to the reboot list! I don't have the HW to > test myself. Good question. Well, it if has to be called before kdump then even "hypervisor" list is a wrong place because is not always called before kdump. > >> --- a/drivers/power/reset/ltc2952-poweroff.c > >> +++ b/drivers/power/reset/ltc2952-poweroff.c > >> @@ -279,7 +279,7 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev) > >> pm_power_off = ltc2952_poweroff_kill; > >> > >> data->panic_notifier.notifier_call = ltc2952_poweroff_notify_panic; > >> - atomic_notifier_chain_register(&panic_notifier_list, > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > >> &data->panic_notifier); > > > > I looks like this somehow triggers the reboot. IMHO, it should go > > into the pre_reboot list. > > Mixed feeling again here - CCing the maintainers for comments (Sebastian > / PM folks). > > This is setting a variable only, and once it's set (data->kernel_panic > is the bool's name), it just bails out the IRQ handler and a timer > setting - this timer seems kinda tricky, so bailing out ASAP makes sense > IMHO. IMHO, the timer informs the hardware that the system is still alive in the middle of panic(). If the timer is not working then the hardware (chip) will think that the system frozen in panic() and will power off the system. See the comments in drivers/power/reset/ltc2952-poweroff.c: * The following GPIOs are used: * - trigger (input) * A level change indicates the shut-down trigger. If it's state reverts * within the time-out defined by trigger_delay, the shut down is not * executed. If no pin is assigned to this input, the driver will start the * watchdog toggle immediately. The chip will only power off the system if * it is requested to do so through the kill line. * * - watchdog (output) * Once a shut down is triggered, the driver will toggle this signal, * with an internal (wde_interval) to stall the hardware shut down. IMHO, we really have to keep it alive until we reach the reboot stage. Another question is how it actually works when the interrupts are disabled during panic() and the timer callbacks are not handled. > > [...] > >> --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c > >> +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c > >> @@ -814,7 +814,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) > >> goto out; > >> } > >> > >> - atomic_notifier_chain_register(&panic_notifier_list, > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > >> &brcmstb_pm_panic_nb); > > > > I am not sure about this one. It instruct some HW to preserve DRAM. > > IMHO, it better fits into pre_reboot category but I do not have > > strong opinion. > > Disagree here, I'm CCing Florian for information. > > This notifier preserves RAM so it's *very interesting* if we have > kmsg_dump() for example, but maybe might be also relevant in case kdump > kernel is configured to store something in a persistent RAM (then, > without this notifier, after kdump reboots the system data would be lost). I see. It is actually similar problem as with drivers/firmware/google/gsmi.c. I does similar things like kmsg_dump() so it should be called in the same location (after info notifier list and before kdump). A solution might be to put it at these notifiers at the very end of the "info" list or make extra "dump" notifier list. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 17 14:11:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:11:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330925.554339 (Exim 4.92) (envelope-from ) id 1nqxun-0003ZC-8Y; Tue, 17 May 2022 14:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330925.554339; Tue, 17 May 2022 14:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxun-0003Z5-5P; Tue, 17 May 2022 14:11:09 +0000 Received: by outflank-mailman (input) for mailman id 330925; Tue, 17 May 2022 14:11:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxum-0003Yy-89 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:11:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30f69073-d5eb-11ec-837e-e5687231ffcc; Tue, 17 May 2022 16:11:05 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 67D211F8CA; Tue, 17 May 2022 14:11:05 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 10D772C141; Tue, 17 May 2022 14:11:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30f69073-d5eb-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652796665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UazRNADyyJz2HI+RS6R0a4/dm7+XkEeyBn9yGoLISk0=; b=BKp7+FEVfq6NcVwdI04E/j1IXhL8fav2W9wQb6/2V+MLS4zVCpGBL04+5kiZPUHpPEWWSJ UCuw6cy5UFA5oDKAHRw0jxrGspZnMX7jbttS2tX8QWMEWQryA8mHzjbrpe5MfzzbeKkAE+ HL6pRS/de3kEkB9TyLHSW9ZDBKYUAwA= Date: Tue, 17 May 2022 16:11:00 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: "Luck, Tony" , Dinh Nguyen , "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 2022-05-16 13:33:51, Guilherme G. Piccoli wrote: > On 16/05/2022 13:18, Luck, Tony wrote: > >> [...] > > Would it be possible to have some global "kdump is configured + enabled" flag? > > > > Then notifiers could make an informed choice on whether to deep dive to > > get all the possible details (when there is no kdump) or just skim the high > > level stuff (to maximize chance of getting a successful kdump). > > > > -Tony > > Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier? I like this idea. One small problem is that kexec_crash_loaded() has valid result only under kexec_mutex. On the other hand, it should stay true once loaded so that the small race window should be innocent. > With that, are you/Petr/Dinh OK in moving it for the info list? Sounds good to me. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 17 14:12:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:12:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330933.554349 (Exim 4.92) (envelope-from ) id 1nqxvZ-0004AZ-L2; Tue, 17 May 2022 14:11:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330933.554349; Tue, 17 May 2022 14:11:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxvZ-0004AS-IJ; Tue, 17 May 2022 14:11:57 +0000 Received: by outflank-mailman (input) for mailman id 330933; Tue, 17 May 2022 14:11:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxvY-0004AG-3h; Tue, 17 May 2022 14:11:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxvX-0004hB-Vd; Tue, 17 May 2022 14:11:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxvX-0004FH-E4; Tue, 17 May 2022 14:11:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqxvX-0002g2-Dd; Tue, 17 May 2022 14:11:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0bhopRpKgycMCx6G+KfPk/W9zxaMXvKQTfsHvb/oZ1M=; b=5skt11rTOCVZzUYI3H9tR5NIBa 1hFPOFj7eqmsjjYdlLS7Knsi/Z28557agWsPK7MTq1UnUiJ13ICQCw3KsfmHVoIwVnhDUGO80YHGJ ByPnyQwq8WutBPsDAEvIHiTI5Q92Eha3wPa49mlK77O8Oq8qknge9fvisQHwHCr1+Pso=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170503: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc X-Osstest-Versions-That: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc From: osstest service owner Date: Tue, 17 May 2022 14:11:55 +0000 flight 170503 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170503/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 170492 pass in 170503 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 170492 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 170492 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 170492 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170492 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170492 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170492 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170492 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170492 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170492 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170492 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170492 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170492 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170492 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170492 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170492 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc baseline version: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc Last test of basis 170503 2022-05-17 06:45:33 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue May 17 14:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330944.554361 (Exim 4.92) (envelope-from ) id 1nqxx2-0004oz-15; Tue, 17 May 2022 14:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330944.554361; Tue, 17 May 2022 14:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxx1-0004os-U7; Tue, 17 May 2022 14:13:27 +0000 Received: by outflank-mailman (input) for mailman id 330944; Tue, 17 May 2022 14:13:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxwz-0004oZ-QX; Tue, 17 May 2022 14:13:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxwz-0004jj-Pn; Tue, 17 May 2022 14:13:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqxwz-0004Gj-Bt; Tue, 17 May 2022 14:13:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqxwz-0003By-BT; Tue, 17 May 2022 14:13:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gtky07LTLH9tXRYQ4SnOYwwNXAvl/M7YDhOGYYY67Gc=; b=bQfYysgjaZ5zGoKxwLDJ0nPze4 kRuGL87NZGUq6fZOO/2GxwOy84HuqeJEEw/vS8rBWilLZGq00hXXAMB/9tJMtV6a2lcnBQgNnWnlz hPCS/lvveYVU1mDygigLhOHEovUO9xfXDgw3/fakci3Y1zsOutHI3ADPT/5yRw2genwQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170508: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 14:13:25 +0000 flight 170508 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170508/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1062 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 81 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 14:29:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:29:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330955.554372 (Exim 4.92) (envelope-from ) id 1nqyCL-0006TI-HY; Tue, 17 May 2022 14:29:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330955.554372; Tue, 17 May 2022 14:29:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyCL-0006TB-ED; Tue, 17 May 2022 14:29:17 +0000 Received: by outflank-mailman (input) for mailman id 330955; Tue, 17 May 2022 14:29:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyCK-0006T5-3I for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:29:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9d71401-d5ed-11ec-837e-e5687231ffcc; Tue, 17 May 2022 16:29:14 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-Sm7HkiJWMSCnHT8lyxe1ow-1; Tue, 17 May 2022 16:29:10 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3823.eurprd04.prod.outlook.com (2603:10a6:803:19::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 14:29:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 14:29:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9d71401-d5ed-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652797754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W/LuzXEtKu4iw1secfUP71mrwWuG+LY75uzglzpgIGA=; b=hapEkK4FGuK3F+Bz2zFlqgS36eRlcf23dOPMGISoNW2V5sd698q7tzfaeDyPQZpOfbAH0l dFnguhGu++MyCm50/pL4uOOSbxePVQKFKO1GJ9+2d5G8JMMcSMFm61zEJZ+6Jpafq4Ztzl 5g5yUuebeJY+9OlCSR4dny6V8+IDmes= X-MC-Unique: Sm7HkiJWMSCnHT8lyxe1ow-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dM95Dxu3EwwSsM8tF7P72UsPkKfh5LxIqiTQqYBh4n/Es7B94YEH2EMOedk8GL2Rtk1+73WYWag0W8guhiztjfWPPRqkd+Vxcygb/tpbjoJnadi5rmPlQkdtZWn90J98GZJG+dkCIJA4RtJW3Or+t6j2gXahLFxzVoMUlV5CBuvQmmdLwJ5kWXeFfWXAPyB7eDqKC7Hcv+ICkcB2tCv7gi+teI5LfycU1f4MHEu1bTI37CXFZRwBaYWdoFHWcu0FaUh1e0gq+PzLJk27XB0Yeaior4+8psoIQeHg4pkjHDrWYJjoOOwhUla0no1fpMGyohTJT+YcKziVPp0y5G8EyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bVi3TvLbsnmSudnG95FiDbbbRq9+n3Wg/cRuoNp7Y7w=; b=fvuQJPCtkZS++BnvYLl9kywOrr/AlPfd9VBYqOQCE7Si4R47unqGGYoitZD1Wp7aJcMjq6KxKLBZAGuxQJXq03cf7qFL1AwOn3h3/3nczb3GmU3HjjFx7aB7Dj3gCT8fVOZ6YHZDRQmwxsysOnQ11tMlAJuppvuQd9i14RIZ998Te+iYT2cXJHtavG69asuJP/VDjvQ3Xlv4APbuM59dPLS19oIbV4THdOBTahKQEozB/ZZa+Mx4hDXKSQ0x5hs+XU7iLwp7hgvkjvcy24Yopc273P9QPavC+U7IXQ43QSdKU4NDr45Wa1BWIw4Eo82BWb8gfChcgrgvs7dlZtxFfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 16:29:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/mwait-idle: add missing newline Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220516103601.25671-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220516103601.25671-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0767.eurprd06.prod.outlook.com (2603:10a6:20b:484::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa50b56e-9da3-4807-5149-08da38119ad5 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3823:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XChnKmYUTnVf2B2DmeOgJYeye1W3arrjN58IZQ8AmBEU+p70YewXNSaVzPVBv9nNyzkF0GPrqbPIxHb6nq0hz4hlljjXUN5AG0N5+mnnnbM/WkRdXMDaAs+7Qxxpjp39ICZm3xwuloe2Lm0o3rT+tBVTWEqjG2z5BZKUL76KUQogyGjx3HBgRUb6w1krEJ32oVjDWxhUa5t+/XvlPXMZbPBQUzz2DVbBSLn4QfPaNmwMDvo2N0mKPUaccltiz6MB+S40oBEOMKuit0HaF3fPotdoujq/v4W/FTq8/GErqlDzqaRBpbpNc7JS8hqQ4EE9vm/819gbWGfRCCWmFfJBKgm5s6YxIBH8Rfgd2jLgxjs3cmZR109slagqLeDF4kaZb1h6jkfos2KgHqp0tbcAeodkJ/1OLb4wOfaHfL22CycAjKKlq/J30iAxowdHjAZ0VcZ1vnwUAaQhwXSmjxxOMih8wjoDS0HZeG7Kitx8F4gayZANFH9xcWRIsrKxhoTcWx0IUiudc1sSvPJ0F55IxLE6aXgQQP8YNMoRRK/BldyCk4Z++gvrkDWoxs9/ubQJ9a86cEDIX7WbTbviUU72JGc/bQxcaLCmzNJd+QDAAocH/eRXxxVcc+fzM0MyYcFGgvye9Qo0P63Tw8ufhfo2/VlpPr0dLDSLhPV1cEHhbNQbNX4/8lmR2eGxVlNwJWHzBnGIODFnKr8Q7zfHz5b404KM8YqrZnFw3HNA2ph6tx/kGLkQnFc2XHyFU6+4+iewvgoz17/9bWjGYqTve3f8vBzK28LEM0JdqtqNJofuRfU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(31686004)(54906003)(6916009)(26005)(38100700002)(36756003)(186003)(4326008)(66476007)(66946007)(31696002)(66556008)(6666004)(6512007)(53546011)(6506007)(8936002)(4744005)(6486002)(5660300002)(508600001)(86362001)(83380400001)(2616005)(2906002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bGJEpZR75bk0MzyWohxeptvzRHF+EryIkS7mztZRrJXqBXOmePX/RUmSXGLx?= =?us-ascii?Q?7vxBfuXzO4G8kFiFYdgbELJ49l6ZLoRPhYUh4hIlDv4vk3YAUW93qt1QRi7C?= =?us-ascii?Q?Q0QA5uJYqz5fUKYC2pF7Gx/85I87mJaMEdqSPiy56/uSJxT15Lr5ZjHRSNGC?= =?us-ascii?Q?yO6biwLaOX0QoTIywxnic8r6AxEwL6NvSK7M5CUZvkKXMlJn2xgR+6Na8aU5?= =?us-ascii?Q?ZIaHVdLFzP5zwhPqfP1LfozBS1IdIE203h4uyVFrjGP//RSuWj1GzVRG6Yu0?= =?us-ascii?Q?roH9qF5FYtuSzX1dzRtl2KEjFsUMeLaj0iNhcgADX8hn4yyoEYcX5D4W9E5z?= =?us-ascii?Q?t26NEUrfVKYh/JJyp4kx+P1fWmHaKNMIofU8GByRCwtsKZbMwT/+66K7N9fO?= =?us-ascii?Q?v+7BWy+QNEc2Z377JcLaND+vvjlbDevN18226TXwI8XUtN3HNvGm5DPi5MFu?= =?us-ascii?Q?t63bhesmUrYEz0NeaMDm/FmTljWXFMDLQg1KFASyHxtcuTg1fcLR7yt61Sw9?= =?us-ascii?Q?Wy/hhTgg5UxgfK3EoRhMA4Y7n/hqNs6LMI3a3f5UdxrN1ocJKp6LFngqBTXh?= =?us-ascii?Q?fR/MVwxlqgaC2vnos1z1C/TpZAIuwf/Vef3Lcijpa6Z03JoaVcH2kCUwcfYh?= =?us-ascii?Q?E7oKq8MlatHa7KyIPLkXwWKOsYTxGRn1Q3meY9fJy0vVWLuCdor3dwgN/6Aj?= =?us-ascii?Q?jL9H/dwshid5giw6t8xJODqViAVYzrQcWerlJwXn3icuy4Z/TFMqn1+eBp2a?= =?us-ascii?Q?qRPFEeLyaPUg7pLQC/k/wI6iVfoeHMr6AiqljjVlnR+XXlsUYSnKsZDoBQhn?= =?us-ascii?Q?52a/u3+c+BFTFfI7hytQ1YwRh+2m46heZbjKR5NRRA6wPtf3yVjFkPdX4hs7?= =?us-ascii?Q?dCPQhi8HueF8P4Un0Miki8z9gFlw5Q1V8zmRFz9v2j8H7BmxxChh7K9qrMgE?= =?us-ascii?Q?nwlLLjEXxnHhqaMH/hnximKqgHWbzoTlg3AH+Q2JaT07KMqVmx3M8qMgi0U5?= =?us-ascii?Q?Zu1LdXyi7dd2RpYeOsN6Cs2ZuMgLobRS63Nf7OoKiLgqUUg+WCSx7+c23kXA?= =?us-ascii?Q?vw3LJkyYM+N36Bdmwb+/n9x7qNTY0cAnf6Mr38xkgrBGVQgjAFg2zJycm+3F?= =?us-ascii?Q?R/x28uHgO7seFyNvaYBt+WSHdOkKS7rl0jBLs4LnWBiCWsh8v3vMuAGMb4Ob?= =?us-ascii?Q?iHq/ObwQTw6MEOTZe5o7r2bEl4162VsgSoFPWnlrqoMZEAf4NSRMj3cHvbyr?= =?us-ascii?Q?GSf/2pet73F2lTsCweeKjiG19RiQ6Fj6okDZ4JPLWqrIjdshxKR5FmzcnkFk?= =?us-ascii?Q?BHWrleLX4AMeL/R514MZ78QJ8vMpPsE/tegJyvV1pmlI+HQ4XGtTmWscfB6a?= =?us-ascii?Q?0GkA53uEugrfZMhG6DNfeuK+w+tpBzvHHtflxK1vtZTgbALnAQOQxq53BDPk?= =?us-ascii?Q?p3hQykXAIDwjB4DylnJXES0bed5Ds0Fd3TvgMSvaSZ1QonNGbxJca0l6vSKA?= =?us-ascii?Q?ASaAKmMfMZV4clyY6da+ejtsJQiNpOpquQs8E9V+WKWRlKyaGjIU14Ca87AF?= =?us-ascii?Q?RKb42qcmJTRXhiHd7b/044EDhvrlg6y/7373Eqsr3jIGXuc6+bvtPRE8ll1E?= =?us-ascii?Q?VuC9vkeiQCI5dXEkxWWSfkSWdBemq9A2MAdYeQ5JK8j6mnHu/oj9Zr+GgN7Z?= =?us-ascii?Q?UsplQOncuKG48MnW8/FvhNWdk5E5JQhhJexOJTVUHISB3NOd12tpHCa6ydAx?= =?us-ascii?Q?mfQdilF/MQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa50b56e-9da3-4807-5149-08da38119ad5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:29:09.1492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JWaOrxnOEVPk2dFo7jTp1oswjfLPXyyWfNTiQ7lm7IbvUCfIbgYnSW9N+P+hkyahCyNqxvxac7Wp60cpuQwHMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3823 On 16.05.2022 12:36, Roger Pau Monne wrote: > Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10= enabled') > Signed-off-by: Roger Pau Monn=C3=A9 Thanks for spotting. I wonder whether we shouldn't mention the Linux commit (654d08a42a56) which did this as a "side effect". Obviously the fix here isn't really a port thereof. Jan > --- a/xen/arch/x86/cpu/mwait-idle.c > +++ b/xen/arch/x86/cpu/mwait-idle.c > @@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init( > /* if state marked as disabled, skip it */ > if (cpuidle_state_table[cstate].flags & > CPUIDLE_FLAG_DISABLED) { > - printk(XENLOG_DEBUG PREFIX "state %s is disabled", > + printk(XENLOG_DEBUG PREFIX "state %s is disabled\n", > cpuidle_state_table[cstate].name); > continue; > } From xen-devel-bounces@lists.xenproject.org Tue May 17 14:33:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330963.554383 (Exim 4.92) (envelope-from ) id 1nqyGV-0007si-2r; Tue, 17 May 2022 14:33:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330963.554383; Tue, 17 May 2022 14:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGV-0007sb-00; Tue, 17 May 2022 14:33:35 +0000 Received: by outflank-mailman (input) for mailman id 330963; Tue, 17 May 2022 14:33:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGT-0007sV-UE for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:33:33 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53e9b9a6-d5ee-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:33:33 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id p5-20020a1c2905000000b003970dd5404dso1390199wmp.0 for ; Tue, 17 May 2022 07:33:32 -0700 (PDT) Received: from horizon.home (amontsouris-681-1-37-131.w90-87.abo.wanadoo.fr. [90.87.156.131]) by smtp.gmail.com with ESMTPSA id f21-20020a7bcd15000000b003942a244f30sm2544884wmj.9.2022.05.17.07.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 07:33:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53e9b9a6-d5ee-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+9HG/dVfNJyu74bNMj0VTJFNoJxjlcEa2s8utBre5yc=; b=EsoYUsgrzUA7JVzblfHrb6MVajGlv1hB8CqNt0AJeWL70d5C5vsPQxlqhKLoFf+zZb p4cOU4siA7nudo6jXLjrN8RwAzujnVIF5fiCIs07bKNigSuJ59tyK4gZti3MHtBZkGvk hEYHq3w+FBdD7miA6BCVIlk/cKZsRVhzQQYIcAnnPKVsblCRAoyqMImXjqDSV+mcL+8G 7GwygC8YM2m+8SXrrjDFNM1q+7OBzzDtmPbkYvqbzLmyucbbDNQsekL/iWR9uOtn6Y3g rxTy7gFz+fv8G4QliIqfDqIUn7wRLOlPl/gVB0QWXQV9atLQLBCcGezRom35O8i+ZhgU XrsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+9HG/dVfNJyu74bNMj0VTJFNoJxjlcEa2s8utBre5yc=; b=EH2T7xqAM76MHo8QEynzfSKirNekQcH8e/WzIjvnFNyZvxO1xLHljio2bM5rQcuuol 63JrfAu73XS/1Gj0Da4uu5QcqRZSTomkmIz5Eque5XbTppvzTYwkBBf5iTRcF8TG/413 IrafLuyYQxZ/HAd5JxakH9Z3JQz8c0qsyUgrB7xrhJXjsft41CPNJvP76hT1iofh8wDz izTlb9DeZGZB2pPT68tX9MJrO9W+uVFWI5rEFcCY4KOsNFYV93toE2FB+HZ+eeue6CjM UFkuMj8CyXWGUciqbCCp+ypKVTIOMgNOR22m0su1pwKbk8KlMs34Z063EmIYDbfvTMVI RO8Q== X-Gm-Message-State: AOAM533kD5Un8/nFwQ6uJqJgoDixttCidikUzQDLgWHJSIxCyJ0mgoLp lj0zRwEMAQFm3OVsq3dpAEkjP+linNzbAw== X-Google-Smtp-Source: ABdhPJxoGG1bevkrKQ/7AlhU14PD8kSacM//BFpo2rZxIkUvoNwA3f/nLYVxCg4Hsyu1qzwUzQoAfA== X-Received: by 2002:a05:600c:214c:b0:394:2dfe:2754 with SMTP id v12-20020a05600c214c00b003942dfe2754mr21812005wml.135.1652798012140; Tue, 17 May 2022 07:33:32 -0700 (PDT) From: Matias Ezequiel Vara Larsen X-Google-Original-From: Matias Ezequiel Vara Larsen To: xen-devel@lists.xenproject.org Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli , Anthony PERARD Subject: [RFC PATCH 0/2] Add a new acquire resource to query vcpu statistics Date: Tue, 17 May 2022 16:33:13 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello all, The purpose of this RFC is to get feedback about a new acquire resource that exposes vcpu statistics for a given domain. The current mechanism to get those statistics is by querying the hypervisor. This mechanism relies on a hypercall and holds the domctl spinlock during its execution. When a pv tool like xcp-rrdd periodically samples these counters, it ends up affecting other paths that share that spinlock. By using acquire resources, the pv tool only requires a few hypercalls to set the shared memory region and samples are got without issuing any other hypercall. The original idea has been suggested by Andrew Cooper to which I have been discussing about how to implement the current PoC. You can find the RFC patch series at [1]. The series is rebased on top of stable-4.15. I am currently a bit blocked on 1) what to expose and 2) how to expose it. For 1), I decided to expose what xcp-rrdd is querying, e.g., XEN_DOMCTL_getvcpuinfo. More precisely, xcp-rrd gets runstate.time[RUNSTATE_running]. This is a uint64_t counter. However, the time spent in other states may be interesting too. Regarding 2), I am not sure if simply using an array of uint64_t is enough or if a different interface should be exposed. The remaining question is when to get new values. For the moment, I am updating this counter during vcpu_runstate_change(). The current series includes a simple pv tool that shows how this new interface is used. This tool maps the counter and periodically samples it. Any feedback/help would be appreciated. Thanks, Matias. [1] https://github.com/MatiasVara/xen/tree/feature_stats Matias Ezequiel Vara Larsen (2): xen/memory : Add stats_table resource type tools/misc: Add xen-stats tool tools/misc/Makefile | 5 +++ tools/misc/xen-stats.c | 83 +++++++++++++++++++++++++++++++++++++ xen/common/domain.c | 42 +++++++++++++++++++ xen/common/memory.c | 29 +++++++++++++ xen/common/sched/core.c | 5 +++ xen/include/public/memory.h | 1 + xen/include/xen/sched.h | 5 +++ 7 files changed, 170 insertions(+) create mode 100644 tools/misc/xen-stats.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 14:33:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330964.554393 (Exim 4.92) (envelope-from ) id 1nqyGX-00088x-Bk; Tue, 17 May 2022 14:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330964.554393; Tue, 17 May 2022 14:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGX-00088q-7n; Tue, 17 May 2022 14:33:37 +0000 Received: by outflank-mailman (input) for mailman id 330964; Tue, 17 May 2022 14:33:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGV-0007sV-VR for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:33:36 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5534f158-d5ee-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:33:35 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id w4so25008058wrg.12 for ; Tue, 17 May 2022 07:33:35 -0700 (PDT) Received: from horizon.home (amontsouris-681-1-37-131.w90-87.abo.wanadoo.fr. [90.87.156.131]) by smtp.gmail.com with ESMTPSA id f21-20020a7bcd15000000b003942a244f30sm2544884wmj.9.2022.05.17.07.33.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 07:33:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5534f158-d5ee-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l4FmmyqLRGvXYMIUa3VVLSfEZOS+ge14yndz9u2uerk=; b=IS5MuXI3qTk9KdMKhqyLjBHPVSrMbj2lq9dkP7aZ7vmpTjwpb4NUhLpNSF8eRl93Z3 4VsNwupqYxWgD1qgDty7nfcR8H3aa9YObZHBMUxD7cqth+cuHw6pKvt+xBM/MAza3NCD B06IQKBD2wLhxAf/tH9ZSPYOYBGYW0xaHk6Fe5Syt40hRzsxIDqYQ616sqKvMSWhDUGV tSrKmDbAkBNLgSxR/gHY/Ay1AltSJMXB+uASi5oaR6YCYPsUuL6qIs+BBDgZoUd1h6Qr kjjRKc7Mi+reUNFQvBhyIrJVCjVe0jIDP6CvwEz6IeIaHximoQo+FouFMdZ5latBaZnw uzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l4FmmyqLRGvXYMIUa3VVLSfEZOS+ge14yndz9u2uerk=; b=t2YpfVOhjpJ83qbzhlsu1FmRfFv7INA57MVEX+Dn/Ug0iDzoKUC9Sm6aLHNpaFR1vh 4OnwZlBFSVff13D/M3OWIm4EgevnhVRqO9mtelvkffh/XQYh/nTsQ3+8w2LK4lBazE27 sl35Oh9ERHFZXKIkxduNEP+AkcmSVWfLJDFHiuwdrtbc17LZelE6tldq5hZV5wFMc0ot +rmUSCURzss1hnwxXZDCWhMFHsq/Vy9rN31dTRvqLJZ38y6ymL109cFbc88SmEfDz9oZ kT0X46t7PzxmkJpokBxywUCI8XV+HIVEcmuyBojrDMJNt/BI66GfHgx+BzmpcdKv1eRp vaFQ== X-Gm-Message-State: AOAM531vblwQx7TDPThcagZXNUArxFBQbr/ZsVII0uT1kQu2gExMqj4k mfmjkBeW5bixlCucvqf8BmstcRTonSf+rA== X-Google-Smtp-Source: ABdhPJw/qHReIodTGVvX1U8v9An9YMCdZfTdwsfD+29R58e1Kpell1NJ2y3X1Szyh4jZjUdVVzEZzQ== X-Received: by 2002:adf:f152:0:b0:20d:740:beba with SMTP id y18-20020adff152000000b0020d0740bebamr10075439wro.512.1652798014404; Tue, 17 May 2022 07:33:34 -0700 (PDT) From: Matias Ezequiel Vara Larsen X-Google-Original-From: Matias Ezequiel Vara Larsen To: xen-devel@lists.xenproject.org Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli Subject: [RFC PATCH 1/2] xen/memory : Add stats_table resource type Date: Tue, 17 May 2022 16:33:14 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow to map vcpu stats using acquire_resource(). Signed-off-by: Matias Ezequiel Vara Larsen --- xen/common/domain.c | 42 +++++++++++++++++++++++++++++++++++++ xen/common/memory.c | 29 +++++++++++++++++++++++++ xen/common/sched/core.c | 5 +++++ xen/include/public/memory.h | 1 + xen/include/xen/sched.h | 5 +++++ 5 files changed, 82 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index 17cc32fde3..ddd9f88874 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -132,6 +132,42 @@ static void vcpu_info_reset(struct vcpu *v) v->vcpu_info_mfn = INVALID_MFN; } +static void stats_free_buffer(struct vcpu * v) +{ + struct page_info *pg = v->stats.pg; + + if ( !pg ) + return; + + v->stats.va = NULL; + + if ( v->stats.va ) + unmap_domain_page_global(v->stats.va); + + v->stats.va = NULL; + + free_domheap_page(pg); +} + +static int stats_alloc_buffer(struct vcpu *v) +{ + struct domain *d = v->domain; + struct page_info *pg; + + pg = alloc_domheap_page(d, MEMF_no_refcount); + + if ( !pg ) + return -ENOMEM; + + v->stats.va = __map_domain_page_global(pg); + if ( !v->stats.va ) + return -ENOMEM; + + v->stats.pg = pg; + clear_page(v->stats.va); + return 0; +} + static void vmtrace_free_buffer(struct vcpu *v) { const struct domain *d = v->domain; @@ -203,6 +239,9 @@ static int vmtrace_alloc_buffer(struct vcpu *v) */ static int vcpu_teardown(struct vcpu *v) { + + stats_free_buffer(v); + vmtrace_free_buffer(v); return 0; @@ -269,6 +308,9 @@ struct vcpu *vcpu_create(struct domain *d, unsigned int vcpu_id) if ( vmtrace_alloc_buffer(v) != 0 ) goto fail_wq; + if ( stats_alloc_buffer(v) != 0 ) + goto fail_wq; + if ( arch_vcpu_create(v) != 0 ) goto fail_sched; diff --git a/xen/common/memory.c b/xen/common/memory.c index 297b98a562..39de6d9d05 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1099,6 +1099,10 @@ static unsigned int resource_max_frames(const struct domain *d, case XENMEM_resource_vmtrace_buf: return d->vmtrace_size >> PAGE_SHIFT; + // WIP: to figure out the correct size of the resource + case XENMEM_resource_stats_table: + return 1; + default: return -EOPNOTSUPP; } @@ -1162,6 +1166,28 @@ static int acquire_vmtrace_buf( return nr_frames; } +static int acquire_stats_table(struct domain *d, + unsigned int id, + unsigned int frame, + unsigned int nr_frames, + xen_pfn_t mfn_list[]) +{ + const struct vcpu *v = domain_vcpu(d, id); + mfn_t mfn; + + if ( !v ) + return -ENOENT; + + if ( !v->stats.pg ) + return -EINVAL; + + mfn = page_to_mfn(v->stats.pg); + mfn_list[0] = mfn_x(mfn); + + printk("acquire_perf_table: id: %d, nr_frames: %d, %p, domainid: %d\n", id, nr_frames, v->stats.pg, d->domain_id); + return 1; +} + /* * Returns -errno on error, or positive in the range [1, nr_frames] on * success. Returning less than nr_frames contitutes a request for a @@ -1182,6 +1208,9 @@ static int _acquire_resource( case XENMEM_resource_vmtrace_buf: return acquire_vmtrace_buf(d, id, frame, nr_frames, mfn_list); + case XENMEM_resource_stats_table: + return acquire_stats_table(d, id, frame, nr_frames, mfn_list); + default: return -EOPNOTSUPP; } diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 8f4b1ca10d..2a8b534977 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -264,6 +264,7 @@ static inline void vcpu_runstate_change( { s_time_t delta; struct sched_unit *unit = v->sched_unit; + uint64_t * runstate; ASSERT(spin_is_locked(get_sched_res(v->processor)->schedule_lock)); if ( v->runstate.state == new_state ) @@ -287,6 +288,10 @@ static inline void vcpu_runstate_change( } v->runstate.state = new_state; + + // WIP: use a different interface + runstate = (uint64_t*)v->stats.va; + memcpy(runstate, &v->runstate.time[0], sizeof(v->runstate.time[0])); } void sched_guest_idle(void (*idle) (void), unsigned int cpu) diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index 50e73eef98..752fd0be0f 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -626,6 +626,7 @@ struct xen_mem_acquire_resource { #define XENMEM_resource_ioreq_server 0 #define XENMEM_resource_grant_table 1 #define XENMEM_resource_vmtrace_buf 2 +#define XENMEM_resource_stats_table 3 /* * IN - a type-specific resource identifier, which must be zero diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 5485d08afb..bc99adea7e 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -284,6 +284,11 @@ struct vcpu struct page_info *pg; /* One contiguous allocation of d->vmtrace_size */ } vmtrace; + struct { + struct page_info *pg; + void * va; + } stats; + struct arch_vcpu arch; #ifdef CONFIG_IOREQ_SERVER -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 14:33:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:33:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330965.554405 (Exim 4.92) (envelope-from ) id 1nqyGZ-0008Qs-Lj; Tue, 17 May 2022 14:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330965.554405; Tue, 17 May 2022 14:33:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGZ-0008Qg-H9; Tue, 17 May 2022 14:33:39 +0000 Received: by outflank-mailman (input) for mailman id 330965; Tue, 17 May 2022 14:33:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyGY-0007sV-1O for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:33:38 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5676ab00-d5ee-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:33:37 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id j24so9790354wrb.1 for ; Tue, 17 May 2022 07:33:37 -0700 (PDT) Received: from horizon.home (amontsouris-681-1-37-131.w90-87.abo.wanadoo.fr. [90.87.156.131]) by smtp.gmail.com with ESMTPSA id f21-20020a7bcd15000000b003942a244f30sm2544884wmj.9.2022.05.17.07.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 07:33:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5676ab00-d5ee-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gpzhC736ZCcknGHWj7xlGwQP3KKn5gNkOz0b71J0xEk=; b=b/jhAljctA8SSJZRjApK/ajrQuLJdVc/6RBDV3owMBNa3Fc4Dr/YNdXXQ5DHjl3mzB LhA9T7p3TNvdWiUkRXIAdRoyNJhSpy4NZMF4X4gqJTFzUXv2aVsKLGP+Bp1/l5/5Fw+e fNTtR1ZoESUJh2P/c3cvB0JRgnQK3rcdjqaqkcPhtRFARx4gHr4L8Vb9xGIGhsquH80B 4vfnuvkyREGSdNGEOMLbbw70a0OriT1kYOLF5jzN88SGc+V0hegLx34nd1rXHqaAkzIm zlBpUVUmD8z11TlWSKMDQpvft8iLx7K3GGnb/XRZEWk6arT3eTd5pgeBfskfddhXWZr4 gtmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gpzhC736ZCcknGHWj7xlGwQP3KKn5gNkOz0b71J0xEk=; b=ks8kzvpm/hURk9rZdT03A020FbRyNtFQukNsIQXbsMdwG53za2FxarIOKuudbre4BN d3qrK5F5A/MqtcxomSnCkdCPPy2vldDnvIEn0DUKKqlOqbrEds1BcsnfmxwA1tRyHile +fNKH3Il2+vgD6hI0cbJ/u906ejJHBNQh9cJVC8weoRakTKRV0RP6QkdsYTxv6QqZ4PU xqW4JbKXMGSXxLY+gSfXmZdyi/yl2/FWalt6Sau+NbuWRj8LTBhJYFIUyhumFt4z25n/ e1q+bCdOLmKLq8kB27B+QMmsbwJcdV8UkhpqsBX8e6cUNUf5Y9ytiQ1PNCM8ThC9JIeC 01yA== X-Gm-Message-State: AOAM533zn53bRo7hm3kpPoQgyxnnEloXLgQwoqHU2AtUa8J1qAyx5AMW mf3pOXsbhmZvT7tVQAx+pdX7RcTcWIUjGQ== X-Google-Smtp-Source: ABdhPJy00iSU9MGY4ElHHizz5q64eggXdUyF8ugDubELNhWZeMFlJKgjswaZAjB2s8FXFaicvsp6kQ== X-Received: by 2002:adf:eb4b:0:b0:20c:dfe2:bed7 with SMTP id u11-20020adfeb4b000000b0020cdfe2bed7mr18409036wrn.672.1652798016532; Tue, 17 May 2022 07:33:36 -0700 (PDT) From: Matias Ezequiel Vara Larsen X-Google-Original-From: Matias Ezequiel Vara Larsen To: xen-devel@lists.xenproject.org Cc: Matias Ezequiel Vara Larsen , Wei Liu , Anthony PERARD Subject: [RFC PATCH 2/2] tools/misc: Add xen-stats tool Date: Tue, 17 May 2022 16:33:15 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a demostration tool that uses the stats_table resource to query vcpu time for a DomU. Signed-off-by: Matias Ezequiel Vara Larsen --- tools/misc/Makefile | 5 +++ tools/misc/xen-stats.c | 83 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 88 insertions(+) create mode 100644 tools/misc/xen-stats.c diff --git a/tools/misc/Makefile b/tools/misc/Makefile index 2b683819d4..b510e3aceb 100644 --- a/tools/misc/Makefile +++ b/tools/misc/Makefile @@ -135,4 +135,9 @@ xencov: xencov.o xen-ucode: xen-ucode.o $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS) +xen-stats.o: CFLAGS += $(CFLAGS_libxenforeginmemory) + +xen-stats: xen-stats.o + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) + -include $(DEPS_INCLUDE) diff --git a/tools/misc/xen-stats.c b/tools/misc/xen-stats.c new file mode 100644 index 0000000000..5d4a3239cc --- /dev/null +++ b/tools/misc/xen-stats.c @@ -0,0 +1,83 @@ +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +static sig_atomic_t interrupted; +static void close_handler(int signum) +{ + interrupted = 1; +} + +int main(int argc, char **argv) +{ + xenforeignmemory_handle *fh; + xenforeignmemory_resource_handle *res; + size_t size; + int rc, nr_frames, domid, frec, vcpu; + uint64_t * info; + struct sigaction act; + + if (argc != 4 ) { + fprintf(stderr, "Usage: %s \n", argv[0]); + return 1; + } + + // TODO: this depends on the resource + nr_frames = 1; + + domid = atoi(argv[1]); + frec = atoi(argv[3]); + vcpu = atoi(argv[2]); + + act.sa_handler = close_handler; + act.sa_flags = 0; + sigemptyset(&act.sa_mask); + sigaction(SIGHUP, &act, NULL); + sigaction(SIGTERM, &act, NULL); + sigaction(SIGINT, &act, NULL); + sigaction(SIGALRM, &act, NULL); + + fh = xenforeignmemory_open(NULL, 0); + + if ( !fh ) + err(1, "xenforeignmemory_open"); + + rc = xenforeignmemory_resource_size( + fh, domid, XENMEM_resource_stats_table, + vcpu, &size); + + if ( rc ) + err(1, " Fail: Get size: %d - %s\n", errno, strerror(errno)); + + if ( (size >> XC_PAGE_SHIFT) != nr_frames ) + err(1, " Fail: Get size: expected %u frames, got %zu\n", + nr_frames, size >> XC_PAGE_SHIFT); + + res = xenforeignmemory_map_resource( + fh, domid, XENMEM_resource_stats_table, + vcpu, 0, size >> XC_PAGE_SHIFT, + (void **)&info, PROT_READ, 0); + + if ( !res ) + err(1, " Fail: Map %d - %s\n", errno, strerror(errno)); + + while ( !interrupted ) { + sleep(frec); + printf("running cpu_time: %ld\n", *info); + } + + rc = xenforeignmemory_unmap_resource(fh, res); + if ( rc ) + err(1, " Fail: Unmap %d - %s\n", errno, strerror(errno)); + + return 0; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 17 14:41:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:41:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330985.554416 (Exim 4.92) (envelope-from ) id 1nqyOG-00025g-NF; Tue, 17 May 2022 14:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330985.554416; Tue, 17 May 2022 14:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyOG-00025Z-Jb; Tue, 17 May 2022 14:41:36 +0000 Received: by outflank-mailman (input) for mailman id 330985; Tue, 17 May 2022 14:41:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyOF-00025T-Ll for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:41:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72fc8adb-d5ef-11ec-837e-e5687231ffcc; Tue, 17 May 2022 16:41:34 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-o638PF8RM4Og78aA8V2a6g-1; Tue, 17 May 2022 16:41:30 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3383.eurprd04.prod.outlook.com (2603:10a6:209:a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 14:41:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 14:41:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72fc8adb-d5ef-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652798494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoaY0c3KiOG1bK7Bl+GvYErM0YQiZPMEGgXlFFUoapQ=; b=S/dMMUhml8I8+pJSynzrjPLC/DkAy3WXFZVIM+9UCPhc8KgVp3bmxHXjmFZhA7KoeizWsc WnTy2Be050IqjAx7IsDsVZWWQ4AdxxeIt2pMgTCY+up78tDXcfyDrfXj67h5m9J0Ss53HG gx9qVav/4pRFdniBQztazJASA53C8p0= X-MC-Unique: o638PF8RM4Og78aA8V2a6g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kV7f+xqXeJ8Wp43TK5PmOkKHJyR/UE1VGQ/+wpzyZ2Yehftf8XdZ4mXDKelblWY7xdJmnc8C79XNkPhd+3r6Yo4CygYpYZbr6qUv2f5ddsA184sGxyGKNZ5cZDpUqwbxQdmQzE2l9RP+KKSwPjDjg4CGGC5wV6E3R3l1ZPiOa4Rb6dTzy8Bm3JsTIiYdyHnYWcQnCdllSeQpZKT8GMohO1RBiElysm7ItwqWL5vJDEVnAfMpOl42WcW1q0i1fWsA7oJHcwaPQIAjHLFPmhJiHffYBECyBZsAL5egKvetizcZ3A471PIGAQURepxkTwgOgbbNvE4UHrSuoVVIAMKHvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CjuqExjHmiiQyXdM22MReiWUF1qDVgY1XrCkTbHvGk8=; b=J3crcJBcAndy3iT+Ns4wdQ580f5GWUEfUuYdV8LX8OahqGlc7WqkzbYzHdoebwQwojuPdQ0cbXkDxJD1n66F6364G31yPnNVr7RxbDXfe3pxgjT79bK0v02RaBio7p4yjLAIEiMjd+qOqfYJPEL9Xekt+bsCJDvv+FcI0L9KkPFbhQ1vc+PxX3mcRkFJwiPY/NSNaln4qfRS7JFPXTnhUaBeDcL4F0vat379kYzMrNZBTic1eDbNWt0YijZ6FsMgGMUT2AoJ21KqzPFgY2Ev2SGuVhrcDv0a/le4ClpUH3AC2y1fAB9GMdfXlVx9m9z89hiZ8zdfJzpePp3p6cIbZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 16:41:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2083843e-7e5a-47f8-f5a8-08da381351a4 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3383:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0bEMtJxK7S4uSJGbGDZLuX9vbNPlzj+/w+xrG9RmJqQHjQ65jLASd+smKCdr4zfeQUA7bDyEEu+Qaa/6qZ6YohhjLR+j1JZw+9+CSK05q+pYuclwhpb/m5ETWiIypxv9P+xEXC1tX9wI29rFWyOh8AMzzlHYYf2IXwm3ZSRPL8coRX56DkXu7EA4AebuprZkQbZ2mXUise5/F964Jq3bCGiBD2JzDpBIrZSC1y7sgNGdXptC0um0yvFsKibDar8OwE6ELVD8PqmmFnPX2DAqa5HERLc1xlUWzNCxuGajsW6NTcw6/yYm53Rt2mAfdOW+QfPyKPoNztsqV4vX+nV655NxFpOG/yiYzz+CKhDlYFni+He4npIi0/A38EtfnaQ37Yn0OyAj7MEyTA1lGxw6S8kQFTkLNzWJKBVzBYP+axZhpf7wQviarOr+35au7bN6dV+zbXoQFNiigfyKpjPXCN9yXn1xkgvcO7ki7+hxGPG/GhvgwpJnoc8q7MuSUS9x4UNf+isu4JyScCCkLq6/VUQuhXULsGOiJ1tUHebq7Ckobr/iiZq2+tcSKObnOKRn6VltZLylOFY9RZ3dSFCf8WMj3B8Qp7c6pwE72GW531LBe1Eno7/mwmsivyp3b9uL5KTGVPaCKsz/cmXoXBosdw3up5mdIStJxo+SzkRGUDuyYKCCKIVCoCTKV4Bu58ZQsjzWaKNcTA+WdVmZVZ16WdPvop69gIxDfcchspCmorHjFDAzk1IGV2hvfaMNUiU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(26005)(2616005)(6916009)(4326008)(8676002)(31686004)(36756003)(54906003)(186003)(66946007)(316002)(5660300002)(2906002)(6666004)(6486002)(53546011)(86362001)(31696002)(6506007)(508600001)(8936002)(38100700002)(66476007)(66556008)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+jqF1CN80mlvf0YOuBg4F3pJvyG3GpwWQmnVBSFfljxrq6kCCKO8+LvcP4bu?= =?us-ascii?Q?R+MStvkgFlDLMTkOI8ZRPQ2UVG0kvxVDyxHf1cFn+hjwEc21AaQJvdqRu2M+?= =?us-ascii?Q?ZaQAbGbTTNqS+63fy0ciMvsPiZllpl6DNLW/z+c9k9V+OazK1rdSIJQH76e+?= =?us-ascii?Q?SdEOkE8nP+K/m0ZKReT1nbWXH6m0ZxZ62hPyFg1TeCyqk8Bk0M+DB+OJEG1b?= =?us-ascii?Q?CvBph4ISGECNDy+u8cFzeR+Gg5prGX0pwRlqeG5XWQ+uY/pK/pCAAWUaSVfw?= =?us-ascii?Q?CeKnK9V4DFdsmDODab49MKvfrbfZP2nQR/ml6O8Pvl9zt1iI91duvBPUFR7w?= =?us-ascii?Q?lvW5USFkV9nV/sj6V+D8lkcLY7YvN2rqgdvmvrln0dQ9FpzRmzi4IiIoJfEX?= =?us-ascii?Q?qgfaWvMxPkUJFnqTm8zzZ7k3oyaxrkUScnKWR+XbWmKzo+JWZU5xioDhd3je?= =?us-ascii?Q?rU6sJ3wajIGWsn24/zJ1ZV0U8El+WEfpNIZVR9+H+DqZSZZ12VlbqaKwPgX/?= =?us-ascii?Q?SLir8chz0hiqc/p6lQEVzMcDYiFBpBCZRTdkVzS+lc0Mb/YDnYahowGPS0wd?= =?us-ascii?Q?d8keYuJ+gtSbO+bqwZBvrlB1ztzHpZvEqOIJrlQdSsOqVhWESCrBpNtRDs8u?= =?us-ascii?Q?2PsTnCKs+gM/cPlPTMx+KDGQ5CT3mC8tzNI+whciJrLf9VaknDXRhHa0klF6?= =?us-ascii?Q?sxCD+GvNUUnsI1V1+/JRaE7EFZJJfxCjnBozpO9022Ekns4y+OJxLkH/Wzo+?= =?us-ascii?Q?IV8DzGFaQkXLfHNgXTnz9qaAyMDE6hI31jIUiJHO67QlDG4Vs+6kfCGWXxMQ?= =?us-ascii?Q?DOltQQ1ogD3IsLUsxDQ9XyLM0zoqIH7UZl/cGvAl+3vBizpPNnIG3dP++Azn?= =?us-ascii?Q?oQ/Jm6j70oJI89wQetUQ7eIjJHQH7g60jlJkXirxr6u2XZVHFSkRXE4O2cE/?= =?us-ascii?Q?U7XMaTN6/n6G5ZbpMuwuGoiLi8TqQOWh9XGKmzD+WJO5+fcViFDDtjp+rpLp?= =?us-ascii?Q?3QpstcxwNn8vqU0hn9PDbOMdqH9n3nDChAXD8VwKbPUcAl7qrf0dpLpOWedg?= =?us-ascii?Q?Ia+eT9pue+52XeYUy1DgKGRt7uuO/8EdCxJwFMvVDfT9gvBTnMLidk4axuWR?= =?us-ascii?Q?AXluEx4X0bSSou9kYdSPxZiKgGUGgyIM0xRc0l4ZV++2rl9BsUhcjlNMV3Zz?= =?us-ascii?Q?Zhktz3O8Ejw/1WkyiIsIMHxdZjUd7O7+IDHJUNrbhlETHqNBv0pN+0VaNin9?= =?us-ascii?Q?cp5YpRrv6x7lHa1zrYjmxgWTGZx/28Mw0MXHBUtCHULKSy/3H41jHDaHk2vI?= =?us-ascii?Q?vCEphchhMjTT+C2f+2O/D2o1UCdcWeSyVQXlqIkhUkPDfjhBSpbotR6oQldY?= =?us-ascii?Q?z8pjHPZtyNNPCnbUR1rza1qftDZVw6jV/XOAs1E2Ajzc9G+M4Gj7q+hkx2td?= =?us-ascii?Q?SzdKSulJFIvegRxY4WrW4atAOc2gbJb8YDzpDtj9NT1cbXJ+wjRxrgxDtUDi?= =?us-ascii?Q?nyQvKkGa/Hvqv/nNLT4sb2MlP9pZErPnCYeV15hHFpbr8exvC9jCKt71bq8r?= =?us-ascii?Q?IKc9jFD9Pu8kwflK/UbR8kBh+NIF4tI62QLZYg76t2oTrW4/HGN1VPotBC14?= =?us-ascii?Q?J6wcwshWRe8YjnktothYgx2paqSCU/LdL8G+pSTErnzF4+XThRSFt1zJvFMY?= =?us-ascii?Q?ml/G5uZW411Cmmy/7PEmDtZIUm99gd8+QJQ+OGwtohbrYqLnPgRVcxHQ6UTi?= =?us-ascii?Q?JlFY49ehXg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2083843e-7e5a-47f8-f5a8-08da381351a4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:41:25.3364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i8A4GJslIuX/bVMebaiKpd1kCvEwlIDLiMRJyLLxkDfe7+WcddcxCLnPaUdG8kXBZ7j/d9OpHgXOgqAtycP/mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3383 On 11.05.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_= amt, unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), > PCI_INTERRUPT_LINE) : 0; > =20 > + if ( uart->irq =3D=3D 0xff ) > + uart->irq =3D 0; > + if ( !uart->irq ) > + printk(XENLOG_INFO > + "ns16550: %pp no legacy IRQ, using poll mode\= n", > + &PCI_SBDF(0, b, d, f)); > + > return 0; > } > } While this code is inside a CONFIG_HAS_PCI conditional, I still think - as was previously suggested - that the 1st if() should be inside a CONFIG_X86 conditional, to not leave a trap for other architectures to fall into. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 14:46:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.330996.554427 (Exim 4.92) (envelope-from ) id 1nqyTE-0002ly-AI; Tue, 17 May 2022 14:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 330996.554427; Tue, 17 May 2022 14:46:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyTE-0002lr-7L; Tue, 17 May 2022 14:46:44 +0000 Received: by outflank-mailman (input) for mailman id 330996; Tue, 17 May 2022 14:46:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyTD-0002ll-Bm for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:46:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2a4b7cbd-d5f0-11ec-837e-e5687231ffcc; Tue, 17 May 2022 16:46:42 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-NGZHOApKNxmfoC3Omza_Hw-1; Tue, 17 May 2022 16:46:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8152.eurprd04.prod.outlook.com (2603:10a6:20b:3fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 14:46:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 14:46:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a4b7cbd-d5f0-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652798802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O476b6RKUYGNB0++/9szmd5u5BrzgkRxrIunygRHuYE=; b=O4l9qrCPqCFaiNReQzUF8NYA7KH53A+Gvwr8w6jycQ32EZwjW+O3vfc0mTJke5EIeQ5yLx vyFwEkSDPZToWHb2mbn7pqot6qIGbsFvjUH8p/9OxxHruW747/Qc1unyTVpmsNTww67s3s S3tvRi76DYSAxP4vpI4Ob2CITUDdXII= X-MC-Unique: NGZHOApKNxmfoC3Omza_Hw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izhzs9cVpYjnbec1LisRX9RUKSCLf+BUttRkJYudzuNbwCxcGVbRytk98OfxvTNPveZW/CP45+HNSwB8QRJZB7jjS6dZaFj3DeH3K4V+hgZif/3JoMtLvV7mG4QxGpcTlheOC39iNq6RTZvfcWzM8XK9MiCSBw1kUNOqlGAjKGAcuaeopr5WfqjUDsQPzhlsihtFOHygoNatEC+ZV8/jiYjsKVeWul9NVPsLw0pTm2Yd9yuzeBOJqkBPuApGv7KlI4kfhByp6zuVxEJ77OBgpvGfAdG3P2I+6/fFjTAUNbjLYjV9dHS9BhT2QLV3erYjTH4Xha8PM7z/CY/sfDXgQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SZ4StM5I8P4/Hrtr+HHrySuBxmRpRNklggJ8ZNj6KKY=; b=lJPYgb7WqCXPcekwz0CGsk0TtWjD3R+uI5i5Kktz/REk3bcBD6GJdYMe0bqCASuJtS98hz0MU26FD1pUt09u66EvTlc1hyfHWDqTAq+W9IjD5IrSNUiSnOQZGGjvnAKHV2mueXsan1GRW0tmgYZQsXJROanQ6d/Wq838Nu1idOCvNT+mhzVoMOYU3YJgxlWw96JDTkbeCBlQYpm2aMNrAhrH5nGidREHK+o8bwvgx/gDfHsenjoBjspm9O5NqHnT/IQJGMtmNjhLMEVFM5YVNbtAzlrsU9ivQtuhi7etG7EF7KOEdUgpwCxa7ItIvrMAdC35pL3wmhqNXHciDJVPqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <95d9658b-dda2-0c05-297c-a75959f7653d@suse.com> Date: Tue, 17 May 2022 16:46:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220503082650.23049-1-roger.pau@citrix.com> <20220503082650.23049-3-roger.pau@citrix.com> <7525a9e0-2334-7b6d-5d42-fb68fc6ef0c1@suse.com> <5ba9bc92-6cb3-7d7e-150f-077c709acc3a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0410.eurprd06.prod.outlook.com (2603:10a6:20b:461::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8911a564-ea80-4755-1769-08da38140b9e X-MS-TrafficTypeDiagnostic: AS8PR04MB8152:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wlNmCZMBbpc1ALwxZ481bNSJwdmxELs6bk7ksRIFAIDfzHjgRSw4DNkPFBRqXvowOiuTU98pZrbMg+nuZVe07RlPLRg1wZ4chLs312bQnlfZJDcdy5c9Uzx4ZOmp8Sn0kXxMGD7bggozKiT/qyd5KcjRXyRVVpcJFr9miHpbZMn8Jb6j9fK8NBkkEI22pVFIE3JnU/iaNk0MaQmmraU6fZHJLit6+ehNOrfoqLK/8URfzl7PJXX7Ki7g+/26ok89ATYSbm9nlCOSpwgNaAqbXL3O8zlV9QiiN62Fs0MSzk7UcI+98CFKXAj41t1kxYd0PVwVaHEcHr/LAcFlrP1f3ujgXyAEusJcRoiXN7igfmd1iiMRHiF7roTKl89FGgePe65bg7eNTXLhdxDJ+Mr4XgnVDIOlRm7spo8rCSsn0lx5/B/KSAevjKfkU1w/mpxcrt/1KeQa3DEDTVAfvsdzHu791QzEKmM214yaqHcszL75Ha7/debzwf3AnlK3U4u/di9txA4oe0JGARY+uoDy1ndmPvlCjKmUEheKjFyl48DbCzpZThJlOQZ/mhatsveogZleOLSWX9iS3Vra0ceVnfsAecm5HUHKvw9KPbwVuEWlGFK8eePxQmM+36arP8svLIsKfWj3/43QkYqBazIlvfGxCmWXlnW8r34E4G+QwPUJkUpnMITMxMJcpXtLU4d3+1K4AznMkEDHTZdSr0WWTJCokm34Prz9gMg5AZNeH3E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6666004)(2906002)(6512007)(26005)(6486002)(8936002)(508600001)(316002)(66476007)(8676002)(6916009)(31696002)(83380400001)(31686004)(2616005)(36756003)(66556008)(4326008)(86362001)(54906003)(66946007)(6506007)(38100700002)(53546011)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mHMWhPZl+Bm8utpIzcV+Gx78tVeUO+sNhrs0AC4GzxqdS40ett+SmWtb3oWg?= =?us-ascii?Q?jwsFQtT9l9/N0t6EGBo5g8da0zoJVoC/Jgb04lUajSJrO2U1jHDtfUhJO4VX?= =?us-ascii?Q?7nv0iOHBX+gpVTQv3SeG6ks+R368Ip8b59NtiIiGN6IpM9GcijoE8s/gpNgb?= =?us-ascii?Q?aDNu8FNQJ3ZVED0/NuVqk80GbxTNmuJ9xXami98jfc+TI434U/wjtD5dpbYQ?= =?us-ascii?Q?MIkSg5Eu3Ow/IL6R8EalG9aQbVOG6luZJLCU7/opymn1TOgWXMdk79ffQOpU?= =?us-ascii?Q?QNWXeI3aol7pdks07kb1eXrrO2oCrv+VIPayNqdG88o9VjMIOIoSh8haXWDL?= =?us-ascii?Q?QuL8avrP9cOM8eeIEJAlkbdTS6IG8A58RnqD4UFX57L2mN572cgplx4ShP2S?= =?us-ascii?Q?OG+Lw63NGoUiq4uFXgvaS9s7adaVo6DfWuPACzq3qOvIAtK3nLVjbVktpKDk?= =?us-ascii?Q?L42sUjFnhgx7hD0RU+sNq8IOqsyyp3hOyvQSLC7EDHwPUglzOO8LvQQVtns8?= =?us-ascii?Q?zUhvmf74UMyj8NNAYFUUqh1MY2a74iUnh+bMSqwLYMCf8ofbQrrsnaYOIZgq?= =?us-ascii?Q?GdkHbiHQMTDfGaOid07jPyYShrSwHFqKk6Gld8IWKitARIs+RMxaClo2gn4k?= =?us-ascii?Q?ytlQhmDNaloq/mup8gNzVq3gKk/6G/jiIKBk4/d2XRI+ktSOc02y/1nfvdRs?= =?us-ascii?Q?wm9+tnijk2qus11FSaZVa5u/qi4CSebKZihrhlRDghUtnqJA1VDi3lQBaora?= =?us-ascii?Q?4zyd+yRGnnVUaPTL4mwGJvxo9mCYCq8FYDWUO6FcRFi1NkhV/0InOPJJQOTh?= =?us-ascii?Q?2lwEcGAuCMpRiAOC0JvY/8ZpkzlhiI9HP8rz0jSyytexolqPxyOhCKgxnMXK?= =?us-ascii?Q?eC4nyopAMRhFipL7CFEn4+uWGTPJeUvbwErvn0prYZGVBYSGu1ij34F+Q9DC?= =?us-ascii?Q?WNuPUgRlWvi+jMPXi6F0BdwzWHJomIzUWbeRWY6TLuBafqSMEJfpVZjZvxKA?= =?us-ascii?Q?uKoBFs1jQ5Q/pye4lL0I6uK9Q5g6YYFCfH4KRn3Ir3ewYfgLelt0AHfG+Ozt?= =?us-ascii?Q?dYb8gSJbGRURrxMdj6fxgPPF+sM8AWgkQfS4jcI8tYojdVNxiAZF7M/1QvW8?= =?us-ascii?Q?hCW6sFVlvaKNlrP2Fgwg5j9D0/vbhHyMoZaP8IbDhyD2vhMi+cjbThpxXkGZ?= =?us-ascii?Q?6PTNZwq1/YEBmhX3iFgmtNvzHgFChRfG5xg+LCIfiHLLib9PI6ctBDR2XsTJ?= =?us-ascii?Q?SE5JsI7q0MW0tfatZzycnYo5/q3x0aYYvimi/pbypg0ZnikDF+d3IEqjYBEW?= =?us-ascii?Q?EcYy8cdeo57+v6svMAHZrYkrnHpTF48VCKtAr7zfhY13koo30kbzvQCPr+dc?= =?us-ascii?Q?QScUtin7JaqsUMCnV8T1T4HrwOZkEUkhJqRbKoRXpekAxZ54cnrFfPkkafMP?= =?us-ascii?Q?GVlAxd+5g7RNlVji6zPnRADMZV5z2QZnvZbZEnn95x7gTw6cEleiiTl2MllM?= =?us-ascii?Q?7yHMmdcufhgHPNlS4UILkbKAIeZWSTMjvIKzom9pF5NakqVho8bGrWApsMWY?= =?us-ascii?Q?F/JWNdLwffwmWvWw5lfmTATviRuXu1FkwpFrNLTGAucB8NCysJpaZOT4/bCZ?= =?us-ascii?Q?fYZwIbFH5LnSLnkyr6BiYqmS1n4100XFUba/jHCM8GMbwRPaG57E0HY2Gi+P?= =?us-ascii?Q?+xQz8hNWnpAHnNQbwlJc3de57u+QzHM2KD87dU3D/frVcLiaWK8Cs0aAp+He?= =?us-ascii?Q?GyVC+g00Cg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8911a564-ea80-4755-1769-08da38140b9e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:46:37.3164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M88KFCdhteGu8Wl9a8M/vgy2pwb0rH/anCzKL5k+D6HbHN5UX3LzqMY5axFjIJn+6aFEH68n8vxGP4B5P58+Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8152 On 17.05.2022 15:45, Roger Pau Monn=C3=A9 wrote: > On Tue, May 17, 2022 at 02:10:29PM +0200, Jan Beulich wrote: >> On 09.05.2022 12:23, Roger Pau Monn=C3=A9 wrote: >>> On Fri, May 06, 2022 at 02:15:47PM +0200, Jan Beulich wrote: >>>> On 03.05.2022 10:26, Roger Pau Monne wrote: >>>>> --- a/xen/arch/x86/cpuid.c >>>>> +++ b/xen/arch/x86/cpuid.c >>>>> @@ -541,6 +541,9 @@ static void __init calculate_hvm_max_policy(void) >>>>> raw_cpuid_policy.basic.sep ) >>>>> __set_bit(X86_FEATURE_SEP, hvm_featureset); >>>>> =20 >>>>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) >>>>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); >>>>> + >>>>> /* >>>>> * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (funct= ional >>>>> * availability, or admin choice), hide the feature. >>>> >>>> Especially with the setting of VIRT_SSBD below here (from patch 1) I >>>> don't think this can go without comment. The more that the other >>>> instance ... >>>> >>>>> @@ -597,6 +600,13 @@ static void __init calculate_hvm_def_policy(void= ) >>>>> guest_common_feature_adjustments(hvm_featureset); >>>>> guest_common_default_feature_adjustments(hvm_featureset); >>>>> =20 >>>>> + /* >>>>> + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus >>>>> + * VIRT_SC_MSR_HVM is set. >>>>> + */ >>>>> + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) >>>>> + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); >>>>> + >>>>> sanitise_featureset(hvm_featureset); >>>>> cpuid_featureset_to_policy(hvm_featureset, p); >>>>> recalculate_xstate(p); >>>> >>>> ... here is about default exposure, so cannot really be extended to >>>> the condition under which this is put in "max" (except that of course >>>> "max" needs to include everything "def" has). >>> >>> Would you be OK with adding: >>> >>> /* >>> * VIRT_SC_MSR_HVM ensures the selection of SSBD is context >>> * switched between the hypervisor and guest selected values for >>> * HVM when the platform doesn't expose AMD_SSBD support. >>> */ >> >> I'm afraid this doesn't explain what I'm after. In >> calculate_hvm_def_policy() the comment explains why / when the feature >> is exposed by _default_. Taking into account patch 1 (where another >> maximum exposure of the feature was introduced), I'd like the >> comment in calculate_hvm_max_policy() to focus on the difference >> between default and maximum exposure (which could be as simple as "if >> exposed by default, also needs exposing in max, irrespective of the >> further max exposure below(?)"). >=20 > So something like: >=20 > /* > * When VIRT_SSBD is exposed in the default policy as a result of > * VIRT_SC_MSR_HVM being set also needs exposing in the max policy. > */ >=20 > Would address your concerns? Yes (with - nit - the double blank dealt with, perhaps by inserting "it" and maybe a comma). Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 14:48:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331004.554438 (Exim 4.92) (envelope-from ) id 1nqyVE-0003Na-NA; Tue, 17 May 2022 14:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331004.554438; Tue, 17 May 2022 14:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyVE-0003NT-JR; Tue, 17 May 2022 14:48:48 +0000 Received: by outflank-mailman (input) for mailman id 331004; Tue, 17 May 2022 14:48:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyVD-0003NN-Ew for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:48:47 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72bd9ac9-d5f0-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:48:45 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 10:48:41 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3716.namprd03.prod.outlook.com (2603:10b6:406:cd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Tue, 17 May 2022 14:48:40 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 14:48:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72bd9ac9-d5f0-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652798925; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2LVmP6s5oJ07jJ7mBGBP68hqIjT2sLGIakNfiM/QSn0=; b=RV/JWU0LXqbZSZU3zJYfk7yhWLxq/q7ZOOL7N3bPOzdFFU6GkQTb98TG vOGIQnuTVoVtVsGGt4xq1pFyPLHfrnHb0yzggaYoqJAPAz8dhKzyqdgAK asftQ5Y++3eYrCKXpEXYVyXFL6mKj0S4xweEJtlmzsWsE00wZj4XYoFgY 8=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 71510971 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zSb2VaMiAiO77HbvrR2alsFynXyQoLVcMsEvi/4bfWQNrUoh02RRm msYCmvUafuJYDOjfN4ka4i18EhUupfRyt9jSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Ew27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zw 4hdlJzpZAATHKiSmO5adUBXFzt+MvgTkFPHCSDXXc276WTjKiOp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaG/+iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33ySmK2wH8Tp5o4IL42L3lwUv+oPzPfqPYtbXdMkWwQGH8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZviUeWz3YeCzUXU0W6uvizjkOiW9NZJ FcQ8yBopq83nGSpU938UhuQsHOC+BkGVLJ4CPYm4QuAzq7V5QexBWUeSDNFLts8u6ceWjgCx lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9jqQzf5x mnSqDBk3u1Jy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDDhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:E+Dy6KzcKlSOt1/uUTqaKrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu vg2iMLnUvoRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIF/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF8nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvWOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1rop5PzuN5d3B+3Z W0Dk1ZrsAxciYoV9MMOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71510971" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=No3w5fdbz+aQ0SgcVJ43SgMuSBmw4wpJcagCNWE2GqkASduBpjCUT1DSrzW+Jzl0VDWMORpA4y3dAK+lDpVCbonGKmKqH+fHLrgYULn34mrZ4/N/+xNR3YBthyHAb4eQRXQ+ZeDH1LSsFc8GL7VGIwtK02vW+DCeDpKtGPeYH7km6NtaVeLgcf9XxX6EN+Sj5CxJzpfKGTbhTLax8Vo0TCoTbpGH+qlhvoseH/knk3E7wMY9/qvstCiTx3/DVjhj83EltPB06f07YyHOsaREm71iQaCc0gb5cxVnS/dg6ksLqgGIbXCeW/9hjwtIz0kOt2GQyTb5GhmVs6dvN/9bFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BU1iE8uiEduxFiLngPWmZPLIrI3cSdCmzeRl/3TB6Vw=; b=fTdfCq9pM7by95YU+71qR2MERbiu0aIwXOSOlWOjgkFsDrnD7fm2V8Hp+GtycHHPB3HrYvamGK56ygJfdaa+n/z+wreqbVvtCT+lIO29+VToGiDq9vK4sDf6POS8h7OK16HJ0EcTWkAkftWOOjo+0fMzVliZbufQBppkDAaFGsePb1vBZLiSdlWEFKz9j6ttFK99JCt++iuf+Ly9netMSqa68MtcfrCe1/F4HpltCQX6WDsuKPgymA+9uusOkk8dQ41ilVMhYDilUDD2C9SOtv+W31ZyzLzsHlLGJvnq/rgqWkgUz1DgNUYL32W4mubQ/xX4+huu4UvleWvvT+H/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BU1iE8uiEduxFiLngPWmZPLIrI3cSdCmzeRl/3TB6Vw=; b=IVpcK+j6wqHa9P/TWqzo+8vwqRU7F3pkV3x7+QIjz9Jtbh7RdZXEe7gR1MnfmTkzIYdWRdEi1XYNQurBSP3wBwx6z1Wk+oMzeYK+ZxW4T53wzvDZ96zue8oz5xl7S4R+sbS7K8mtROT4IMFnbaoZfUflzwMyvBr6K7mIP8az8TA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 17 May 2022 16:48:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0231.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54f7e386-d58b-4a48-130f-08da381454cf X-MS-TrafficTypeDiagnostic: BN7PR03MB3716:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S9Mcspw5zImvgpU2jfTJOl7MgfivRMimrisMkWfdjF4ij2QsMHNa6Uy/Et7utYiumc/wPJUopotYG9s2iDmXsoCOsR7uSe6GBgl4gVeVJ2C8jfirebryhZBWLGe7xeef25yYFb2jawgOOfVybaObXDwj6VLQiy92OjYtYAq6+K4e1j6RB4uEoVJ/j2dCErtCSyeAr4c/mYZNUQWS/7836mnMInSAdDATzz2Ba22GMT7M6voNy4oBkOgat7YJLZqveRIivLB73sd/TxvblLXd9UduuL7QjLZxVwFFAtee/UtDN9gL6gtI6mTGYwDl5n8VacJSwpbY31WZlJRDQYv98VWU1LwjHhLwwf0f+/fXjQIEuT0itk1U5hDOPfwNOYHpz9ORRmMmXviW1XoWG8WlgjXU1DFLL3zEfJoDXAat8wR7lW1moBvKlaQRvlUHvRBhru7mx53HSabY2tqm5gLe7+rPQ3ggJI/MF8Kmrt4s/827YAEr9420yNZvbuPRkXuBB+EC26v9JqsicCwhIyy55oFA1drlZOOXKkyxyaZNJUcJGoH7FA54NXWEeM6yu8+ML5Uf/PVqcFyjNzuBpVUnG+odJtAV7ENmBgiWDAi9EZo3BIovACKk/VeVT3ixd2NFRwhyFdSQ3be3Di0ggA5vrDl0NkyBI5SIgZB+KYqGEhuRpMiwuQN+sPSvzgvfuY1LrBoGuhAbNWrWOXDYuyRwNw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(316002)(85182001)(66476007)(2906002)(4744005)(6486002)(4326008)(8676002)(6666004)(38100700002)(86362001)(82960400001)(5660300002)(33716001)(54906003)(6916009)(6506007)(186003)(6512007)(9686003)(53546011)(8936002)(508600001)(66946007)(26005)(66556008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzQyR0VtUzJjWEpKTVUrNEFGdHM5QXBQc3lRT3h4QVdOZFFGSVp5cUh0MEpN?= =?utf-8?B?UGprNHdHYXFlVk9QODdvWUVienh1QnI3NTNBU3JVUy96Q0ZpUTBDdGhtYTB2?= =?utf-8?B?MlZsckUvK2FFMmE1bHphSVRNbzlXeWp5UVNMU0pxMDM0bmp3a21hSlE4K0F4?= =?utf-8?B?U2JmSk1SNXc5OUdtdjUrNnRvR1lzSy9lYWUvZ3dvYnd4dXVSUGFBTmh2TG5R?= =?utf-8?B?NkJWUFhHa2VnOTVqeWRGc2J0SlhUV0wvVXJDQk5odmJ0VlExbzFKTmhGVHFX?= =?utf-8?B?c0plN2lKQ0ZTUnk3NllaM3Y2clBxMmxnNWNsVFVFajg1dExXSGxtWFVTMU5u?= =?utf-8?B?QThxSUYxTUxkbWcrckhOaXlMc2xkNFdqUEJPMWs0eDZ4eGQ5d0JvNTVFSCtO?= =?utf-8?B?VmtnUkEra2p6N1NGVnhKZWs3MDB4M0FWbkZvS1NxYXYydDVzS0NkOEtOV1pB?= =?utf-8?B?SnZNT1FiUm9nTUNGTmJvdGhFMUFXbUZDaEdaZTZWY0VoQVByNVRydldGenJV?= =?utf-8?B?bXZQVVE3WHRuemR2ditPYWU4enhLbGVhcGtEMTNLMms0N1A4YVNmQTFDRmlr?= =?utf-8?B?WmRDemVmZ0d5UWdLbDZseEVaMVRjZXNQbmQ3Z3RjS1JQQUpwcVJTZXNmcHdr?= =?utf-8?B?QjZ0QmpucjJlcXN5UVphajV1SWJRdmtENWdEeXNLYkhuNU5NdHdraVV6QmlS?= =?utf-8?B?UnYxY2hQU2VxY3d0N1Q5TkljWHZHeC94eXNaOWF4R2ZqZXlsd0RWQjhZRmNo?= =?utf-8?B?RG1MZkJGNm1TY0UwODVsQkREWHhHUm1xN085NTE4SVNhOWZVZUg4VjU0bVl1?= =?utf-8?B?Z0VaeTFpOWlpS3hoaVd2S0ZGWTVibGJQb2Zxd2Y1Wnc1QWpHT1Rkbm1uU1R5?= =?utf-8?B?ZXd2UWN5aEVpUy9mY2lCbnZWUldpbkxjWm9mNHZlOGxRa0tYcGNjWEZYeEhL?= =?utf-8?B?UmJyQ0l6MzIxZjJZSDdWQlhBNDFzWVJXa0FPZElLcVh0VWtLcWdLbXVaYnBy?= =?utf-8?B?QWtLaGJMbzVpd2VLdkh3bFp4MVV3WVd3ZXlHdGVHMWFyYlFWeG9lRVNQQ1Iy?= =?utf-8?B?b1RWM3MwZzZvbWU1S2hPNWdVNW1EQ0IyL1FTRk9HRmJaM0dkUTFKQit1NVVq?= =?utf-8?B?R3EwMVBEUG1KYXNPOUtRa0J6S3p4M1RwdWtMV0c5cE5FVE01Zkg4WC9NQVdu?= =?utf-8?B?VEpJVG5FOHJrSHdqK2pKZmR2Q2dqdk9ieHI3Vm5BK1YxSnZtUmtCTDByQjcx?= =?utf-8?B?VWg1WFVQVXA2aUFscVY3ZXBNUmwwT1VlL256ME4zeHhFVE5TM1NkdDMrL2Ro?= =?utf-8?B?SkRCYjVhV21yZDNTd3hXWWZkbkpWTEpLa1ZlTnk3NGFuSlFaaVVjTEtmY1Bx?= =?utf-8?B?bFJwdU9TczJkRXh5SUI5SHNFN0tkNFgweHFVT1pMcTJTSW9iQW9IL1lIeVNS?= =?utf-8?B?NWViTVpNbDNFeEl4TkFLYW5nU3dZZ0prWi9vTzJvczRjdnBZdFdIREhsWUls?= =?utf-8?B?N3pIQTQyM0g4QVFFVGhUcnZzejRmZFBUK1Fvb3FMWFA3T01lQmdxRC9Rc2pa?= =?utf-8?B?bFZoNUxVR3ZJRnFVVXJlZ3VyaEJibXExTWdGcndMTWZ3TGxDS0pLWHpRWWN4?= =?utf-8?B?WEJVOVJmb24vRUFDV294NlNENmx4a0xqZkU3bW52S0pteWFJQW5hSWRpUXlp?= =?utf-8?B?b1hMVkYwUloySVM4OXpkNUxRM21QZmVCQmRpZENqd0l0NEtLSWl2L3kzZXoy?= =?utf-8?B?Wm5pS1pQb25RNFpmdlc1eUkraVc5UDgwWjY5SityazRCZlRlZmZmZkt4aWcz?= =?utf-8?B?eGtpdkh2Z1VuSGF1Y214SEtKbnNXNFpucGswQmRvVUZIZFlGMXdnbUlVTVpR?= =?utf-8?B?OUFsbnl2dmN2SjJWSHAreGpvOWNITDVUUVVxNnR2MXR0WTZ2L3Z6bEczTDh0?= =?utf-8?B?Z0dydlBHR2RSVEIzVm1XRjhid1JxM3dSTmtETEVBRmdZK3Rsb3FzckkwMHBu?= =?utf-8?B?d3JEQ0NTV1VoQ0dpc0tBQ1dLRHhZeCtPM2w0SjFMbmZPMTltVFpTN2EwN1Fh?= =?utf-8?B?UDVZNXZkZWVuNUp5RWRNQjJ0ZkMxWkZCMENBRVFuOUorZ01vd2ZITGIvRnN1?= =?utf-8?B?VnBRb1Bac1AxMkMyYXFTWm9CTWpteVBCMkE4aFpnMEJ6b2Z2MDIyNmdRd3U1?= =?utf-8?B?Wk5HZTJNdlNqTWI4NGsxRjQvK294TEx2K3pLTFZXcHlMbXNNSlFzZnVVclpU?= =?utf-8?B?anR5L1Z3bjkwTjlYcWZUTlNDRTZYaktwVWRZNVR1N3R4K2JBazNxaTVDRyt5?= =?utf-8?B?Ly92cFRGRjF4VXlaS2J2UUxmVGxzeWFBRCthY1N2NGp0NUVBOFR3N3BEVkFx?= =?utf-8?Q?WAwGFcJhPLN0IwkE=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54f7e386-d58b-4a48-130f-08da381454cf X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:48:40.2048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nb5unCIewAKY+nO0cb4yWquaMU1VeiiFKJ7Fq7Fxs+AHczzc8SnELrBSrU/eieiquQD5I9k9EYN++AoUSANTQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3716 On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > > pci_conf_read8(PCI_SBDF(0, b, d, f), > > PCI_INTERRUPT_LINE) : 0; > > > > + if ( uart->irq == 0xff ) > > + uart->irq = 0; > > + if ( !uart->irq ) > > + printk(XENLOG_INFO > > + "ns16550: %pp no legacy IRQ, using poll mode\n", > > + &PCI_SBDF(0, b, d, f)); > > + > > return 0; > > } > > } > > While this code is inside a CONFIG_HAS_PCI conditional, I still > think - as was previously suggested - that the 1st if() should be > inside a CONFIG_X86 conditional, to not leave a trap for other > architectures to fall into. The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86 region already. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 17 14:55:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:55:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331014.554449 (Exim 4.92) (envelope-from ) id 1nqybr-0004tL-H4; Tue, 17 May 2022 14:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331014.554449; Tue, 17 May 2022 14:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqybr-0004tE-EK; Tue, 17 May 2022 14:55:39 +0000 Received: by outflank-mailman (input) for mailman id 331014; Tue, 17 May 2022 14:55:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqybq-0004t8-Px for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:55:38 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6848e191-d5f1-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:55:37 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 10:55:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO2PR03MB2182.namprd03.prod.outlook.com (2603:10b6:102:12::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.15; Tue, 17 May 2022 14:55:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 14:55:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6848e191-d5f1-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652799337; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9KL4ADFVASUeC+gatxZ4Mg/BqVyU+h/20m9SPG+GFMM=; b=I4zKKfeGS8Ltve8r9K8HikaIUQfs7xjuKtFt6v0IyOSBBt1/QP/wNSsE sJCqwsjUeqdqPylObXQj9RNRkTiw+Xt3rTQbRADQ+STICNwIQUG8bJrJn 9S3uBc+g457Gyae03hq6IvNoMcdGe6iHH7Z4Y8fXQUkLCb+h+BuXhqIA8 k=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 71901776 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gqHx3ayvSPFzAp/E9H96t+f1xyrEfRIJ4+MujC+fZmUNrF6WrkVWy WYcCGyOOPnbNGT3eYx1YYm0/UgHvcSBzIUwQQE9pCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IfhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl6LCIay54BIz1x6cEDToEOTNPGPF89+qSSZS/mZT7I0zuVVLJmq8rKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtadHeOWvLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamImUB9w3LzUYxy0LLwy9xzofJC/3EVc2kXcoMhB2Gt n2TqgwVBTlfbrRz0wGt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7gEOjX9NUK 2QP5zEj66M18SSDTMT5XhC+iG6JuFgbQdU4O/Yh9AiHx67Q4gCYLmsJVDhMbJohrsBebSMu/ k+EmZXuHzMHmL+ITzSb/7SdrzK3MAAUK3MPYWkPSg5ty9ruvoA1yA7OR9BLEaipg9mzEjb1q w1mtwA7jrQXyMsUjaOy+Amdhyr2/sSQCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnzu55p7BW0bYZTIqQc IronPort-HdrOrdr: A9a23:Le6mW6hIVi5JRdaJTfB/YfKSNnBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJvhSQRI+Lpv+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lwdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNMN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp D52+pT5fVzp/QtHNNA7dc6MLWK41P2MGLx2UKpUCLa/fI8SjvwQ6Ce2sRG2MiaPLo18bAVpL PtFHtliE9aQTOaNSTJ5uwHzizw X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71901776" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3IJsTn6nHapuws2uqXuqRv1ZU/8CcdUKuKRjorfRBNSZm7Ci8LoReL1rdVmDQWIR4OMPrY3vYvgTRWyU0SStVhXdFkGVaPnrbFBmDvz0LPjzJleGTluX1E1Vnnlf4ArK6X2UF5Bs3H5zkWHnml3RkyanqMc791d3Y0nnUrujvr0T/vJRWhNlpaagtXdR+pkZ0l/cUOXqNxYBKEUh2VaWKrUiKDawHc+dRYkdiz1l/hEj337iBPm4HTgCr6Zo3s9WZsHXi34UlswQWoe1uOumoizrPRXZQhup/bYd1vMdFHER/cLZryh4RFnsUf0oZzwNz1vm5xdj6F7pT6rIN80Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iDZnyFFx/un2sZYeX0Dlyxo3VWrtVg/a60ehaCFG/gA=; b=R1YJi5+euPmm+uRIY+fS9qYYPoDFTvey8g4TeUvHQcVxWrxxRQgrfigTLfkaFiIiTUd0aieyMEFQRXWSEoC2KquETWYxcemoIKeSEoxfiZ+VfDjX6QPNzgXXIPVwmQsxPWmQlFK+OGpCU5Y73ZDwZsgw94jluxxaIjyP54phSpB2Dq/RM0CzQpN/3N7bWox77Uv9RSec3W0nzW5k3dojnJFw/6cDTeF+beuMsa0F9wpC3HONYZ8jgcMZHryl4qS6/HBC0tnLg+5In21l/0THQGHEF+OMT8lHduX8q10WzsJxW6F4Jf4N0pVY3b3CX9o2F537HwvdvjkIdWVJTijeBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDZnyFFx/un2sZYeX0Dlyxo3VWrtVg/a60ehaCFG/gA=; b=JJsKybOHH2pchMmFXYV+84mTRc8YzXdS+gxxIK1WkvmY+UqL/SwutpyUUTps3vC+csbHZ3v9B8VlGox3HLd/d4aI+i2KJXYZJjHQqnCsNrSg1dneA1Lz7ZJZyOwRFT+dhqYQLNHQH+uuju+I9+BNXLXzRxQajkxml37HqeavPdU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 17 May 2022 16:55:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220517132130.38185-3-roger.pau@citrix.com> X-ClientProxiedBy: LO4P265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 764e6f67-7f13-4e95-9b5e-08da3815458d X-MS-TrafficTypeDiagnostic: CO2PR03MB2182:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sYASMFv9gf/uNwv70E1ebbICG2S2AgAeST8TIjZUHWbokeGuzjvPuhpe7IzewafuqmrzSXCRmKnL6DHZKRCg2hj/9UCsQmx8T1GnoHAcssbPo6n+HAVHSHGdzahi7GDb5OG+O7o1KC8u4z2Q8e5HdQ8NSanIsvQgqKGOMQCM3ZYirJkqoJUSjJlpLxaV/HU2yg7R8fD5DtP1j1fmzB4tfz82jdvfGjSvDDvqNrY2Ebp3plD4+IQzUG6DUrowQl8ns4jwoICchRPkJqf21r7/jo5COBxE/IfyQjMt4bvD4zisB8Mbmw0YP6oO45puwzx6pL45PEVv5CuxcODxJCjRJH54WPkgILT33mRZC3ovcppSUoS74R/gll+RxJYU9cgbuEUit35TsmqArDkAxQYmzfU1OrFbQ5jYgCcPAr16XhZSE3EkwZPaCuPG0w0NNJ0H1fPa4ijsIbLrcH3jF1q3aM4wpIWS5mjrdLJphH3FxbjU6Aqd9l5m4j1tESPj2DXUGTJLK9bkL9r8ZIBDRUENKfERi+MQkPtIfxQQImfRBI5zo3oIkg7ByiafzOSo9qVWHMp/FruCm6G9cZd1gE4YL8FnY4hwDxm5ZpT8hqhNuRMGqCMVwzEiuyr+iiSQDUd8SiwMRL4IuezxNuxwIXGMPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(4326008)(66556008)(66946007)(8676002)(66476007)(85182001)(6512007)(6506007)(33716001)(26005)(82960400001)(54906003)(6916009)(2906002)(316002)(9686003)(6486002)(186003)(8936002)(83380400001)(5660300002)(38100700002)(6666004)(86362001)(508600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1FQbjdOUGhFRGM5VEk1NFQ5aVRPQmV6NkwvYVBVNXdKazJJRmNRZ1ZjbDlo?= =?utf-8?B?QU1HNHF0Z2tPNXBZS0Y3V0JvSVprbjk4WWxZeXJkTVJtUGdTNmNZcTg1UUQ4?= =?utf-8?B?TmdWTnIwcms0K3ZMazhhWWNrN25TYWNFaUlHVklvcU15a2UwNGNHdFdINkpy?= =?utf-8?B?UEl2R0JOdjVzbnlsalVJSDNFU0JoWXhUK1kzd3hoWXM2M29XM0Q0Z09xMzdz?= =?utf-8?B?TzRJd1NhN21WRkQ1UFNEWDZLVlR4L2FjZncxNkJJMld6b3dMcTd3cmI1a1Fy?= =?utf-8?B?ZVVnWityY0F3bHM4dWsyNlZhd2haMjRjdUFYNXBhdXI1ZjVhS0l0dm4wSUt6?= =?utf-8?B?b0VOSDRXUk1JUDgrR0w4aTBMSHU1MUNZM0YxV0E4dDREcXNrM1NRN0Z0bDdL?= =?utf-8?B?MHJCU000M25iV2E1ay85RU9HODBTek4wSWNLb2kreVc2Zlo5VDJ5YXdFdnpw?= =?utf-8?B?ZzkwalRVNVV0ZXdMYlR4VThSR1ZlcFdMeXFSbG5wZTN0allRTDZSc0VhMy9K?= =?utf-8?B?THdtMUs1Mk9sTEZkWWtyWTNhclBlNEVLa0Nua1NNYk5kV1pSVzRMcld3eWV3?= =?utf-8?B?WjIwUTJ4MG5VelVZUXMvKzRjK0d0USswRksxcS9FUldFZmcvR1d2SHc2V21I?= =?utf-8?B?TnpuamNmeHhoN3UwL2ZqclVRbkJGTVZDdWVvRFc0Q0xwNGVSd09Fa3YwUU1n?= =?utf-8?B?L3MxUUhER2tlN3I3cGt2WHBrcXlxMWdYVWlGZ0MvMnZnb2hjc2JMZDR0R2l5?= =?utf-8?B?WkFxOWRaYytxVnZZZ2o0b1hPUXRDSmJveGowK2VFYWNjc2xXSGxKQkdkeGk3?= =?utf-8?B?ais5eUNHbXdVazBuYUdKRThkMjBqNjRLTm9iZTBhcTFDMGZhMGlZcEc1czJQ?= =?utf-8?B?UHlKVTlXck43QjFJV3AzcnozMDR4OVhRWFUrVzMxM01SbXpTNGlTaTQ0SG9W?= =?utf-8?B?RUh5c2ZuQU5qUWRWdzlBaDJ0czZDK2MrOWRhdml3NVh0dkw3dnZPWmhtN0F4?= =?utf-8?B?RWRQeVI5RzlEVEZNTXNMeFQvbVgrSmdIRlgxWWcyZWdRM2syVDFYWGEvakJ3?= =?utf-8?B?UXZWWGgwZWkrOWFPWG9SOGZCQno4RGlDNTE3TzI2eTNKZWx4bGxkU1RBUHFa?= =?utf-8?B?aVFqcU9EN1pmeFpFNjFDUkhLNE4wMnU3dkVneW5qbmZId0ZNR29FbW85aFlW?= =?utf-8?B?d1JVcHVKRzAyNjFUTkViWDlIWXdGenNKV0FsbkY3QjJCeURqRS8yNlVwM0R6?= =?utf-8?B?bzR2SDBWWW5samJwS2Y4TTZLcHc3M0QxeHZxa1dIWG5lTnM3UVd0S3lSSEx1?= =?utf-8?B?OE9sai9YNExXTzNBT3Y2VHFRcjMvcHRxOHlLMWp3aU9LNjA3OWUyUUpYcDEy?= =?utf-8?B?S1ZpS1NTVTdibTYxSDRFRVUybVdlZlVZQU5xYjkreVROZGJSeXo4VWRGaVFC?= =?utf-8?B?VVV3TGtrd1lLL1JYbjVVK1c5S0ZvMHZDNkFOUFNMS0lTSFUyK2NJdDVSZm1T?= =?utf-8?B?aDlXanJtTVdrbVgrNEZxdHRrZHZ0ektVdW9ocnJtZFQ3TEpONlBOeW9iMEFo?= =?utf-8?B?Z1UyWE4vbkFvd0t4bVJtODZGTGF0aFcxNnJyOTNQcnVidnc1dXpSK2h1Ty9H?= =?utf-8?B?M0xSYm05cEUwWnZralh4dmxaLzRNNDRsU0VvYlRRc3NPL2tsQzBTRHdHeEFK?= =?utf-8?B?MmlkalBYd1pNbmc4dWVUYVFhcVRjYXZNcW5YaFRDQWNJM0ZIQXJxZ3g1WUg2?= =?utf-8?B?TWlNd2ViNHFBdzJ4cUludWtsVURyenJHaTdaUDBvS0k3Wnh2MlBGTU9KamxV?= =?utf-8?B?eTV0T2ppa0NqOEU0NGozc2I5bVZFQjIzcWJ1OVcwNlNwbjVpRDRxa1pRbFVQ?= =?utf-8?B?aVpLUDhKTi9ielppcmltaVE3eU02d29TbW54WXZaVW9sN3dLUzQ3Q3lkbFJM?= =?utf-8?B?M0V4SHJlNGpOYUZXNDBucEF3dWF6WUdTRU1BRXlVL1hQRnA2dUlWRlg4YWFs?= =?utf-8?B?M3MyajZqZ2xZUUlZN1lGU2dId1pTaWJWOFQzRk0wMTJraGVFdFZsdFp1OE9m?= =?utf-8?B?K3VGRlZ6ZmRZSGs4SWY4MXNpcWZHNTZrMTRKQnJrWDFnMlc3Q1FkcHRpdjFv?= =?utf-8?B?c1NSWGtwSDUyWWVIL3VTVHZCS2c0NWtxSjMrSG51TzhoeS9jakpnSmJGVXcw?= =?utf-8?B?a0w5Y3ZsUjhKQW9rK0V6QmpvOStTNjlYbWtXcUtXQmJoeUFUNmRGYXlBNmpN?= =?utf-8?B?R3VaZW1lWlp0TzBiYlJhVGxGZzlBOVdMdVltNXEwTGkzTk96aUVSajNqUTR5?= =?utf-8?B?aDRZR3lVQkNnTys4QnQ1d1VoQ0lSeHNMSmd6TkltRkNJQnZLZU5OWFFlZ0RW?= =?utf-8?Q?/TvlPcyC7vosxKD8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 764e6f67-7f13-4e95-9b5e-08da3815458d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:55:24.1379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l39f5XMRNbt0FEIorBdEWtLx2Ph8NhjGTiYDHz9Tj0xJhTcRTeY+Jna8+1Fj08axpAOZBvaqlHKDgc63LdcrjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2182 On Tue, May 17, 2022 at 03:21:30PM +0200, Roger Pau Monne wrote: > Under certain conditions guests can get the CPU stuck in an infinite > loop without the possibility of an interrupt window to occur. This > was the case with the scenarios described in XSA-156. > > Make use of the Notify VM Exit mechanism, that will trigger a VM Exit > if no interrupt window occurs for a specified amount of time. Note > that using the Notify VM Exit avoids having to trap #AC and #DB > exceptions, as Xen is guaranteed to get a VM Exit even if the guest > puts the CPU in a loop without an interrupt window, as such disable > the intercepts if the feature is available and enabled. > > Setting the notify VM exit window to 0 is safe because there's a > threshold added by the hardware in order to have a sane window value. > > Suggested-by: Andrew Cooper > Signed-off-by: Roger Pau Monné > --- > This change enables the notify VM exit by default, KVM however doesn't > seem to enable it by default, and there's the following note in the > commit message: > > "- There's a possibility, however small, that a notify VM exit happens > with VM_CONTEXT_INVALID set in exit qualification. In this case, the > vcpu can no longer run. To avoid killing a well-behaved guest, set > notify window as -1 to disable this feature by default." > > It's not obviously clear to me whether the comment was meant to be: > "There's a possibility, however small, that a notify VM exit _wrongly_ > happens with VM_CONTEXT_INVALID". > > It's also not clear whether such wrong hardware behavior only affects > a specific set of hardware, in a way that we could avoid enabling > notify VM exit there. > > There's a discussion in one of the Linux patches that 128K might be > the safer value in order to prevent false positives, but I have no > formal confirmation about this. Maybe our Intel maintainers can > provide some more feedback on a suitable notify VM exit window > value. > > I've tested with 0 (the proposed default in the patch) and I don't > seem to be able to trigger notify VM exits under normal guest > operation. Note that even in that case the guest won't be destroyed > unless the context is corrupt. > --- > docs/misc/xen-command-line.pandoc | 11 +++++++++++ > xen/arch/x86/hvm/vmx/vmcs.c | 20 +++++++++++++++++++- > xen/arch/x86/hvm/vmx/vmx.c | 24 ++++++++++++++++++++++++ > xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++++ > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 6 ++++++ > xen/arch/x86/include/asm/perfc_defn.h | 3 ++- > 6 files changed, 66 insertions(+), 2 deletions(-) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index 1dc7e1ca07..ccf8bf5806 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -2544,6 +2544,17 @@ guest will notify Xen that it has failed to acquire a spinlock. > , and must be integers. The values will be > encoded in guest CPUID 0x40000002 if viridian enlightenments are enabled. > > +### vm-notify-window (Intel) > +> `= ` > + > +> Default: `0` > + > +Specify the value of the VM Notify window used to detect locked VMs. Set to -1 > +to disable the feature. Value is in units of crystal clock cycles. The following chunk is missing in order for -1 to disable the feature: diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 5685a5523e..817e644d09 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1110,6 +1110,10 @@ static int construct_vmcs(struct vcpu *v) SECONDARY_EXEC_ENABLE_VM_FUNCTIONS | SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS); + if ( vm_notify_window < 0 ) + v->arch.hvm.vmx.secondary_exec_control &= + ~SECONDARY_EXEC_NOTIFY_VM_EXITING; + if ( paging_mode_hap(d) ) { v->arch.hvm.vmx.exec_control &= ~(CPU_BASED_INVLPG_EXITING | Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 17 14:59:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 14:59:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331022.554460 (Exim 4.92) (envelope-from ) id 1nqyfT-0005WI-2W; Tue, 17 May 2022 14:59:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331022.554460; Tue, 17 May 2022 14:59:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyfS-0005WB-Ud; Tue, 17 May 2022 14:59:22 +0000 Received: by outflank-mailman (input) for mailman id 331022; Tue, 17 May 2022 14:59:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyfR-0005W5-O8 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 14:59:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee3e059a-d5f1-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 16:59:20 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-28-MmDFn1EqNkKklTLRyA8vKg-1; Tue, 17 May 2022 16:59:18 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9628.eurprd04.prod.outlook.com (2603:10a6:10:30b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 14:59:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 14:59:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee3e059a-d5f1-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652799560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0838jxKDP6JPhBuqgm1n8k9OoTHvy63J17jafCGNNU=; b=FiR4SSYhFQKbfZAxrFMdAt535T4VWlQiDLlzvkkm0yq60zYxiqShrRKNy7cHZQFxWuuGoI r8tpBSH1tlwXC4Vpd1ECm0DyxpVHrK+IVFIuSpWlbwnjt2BmuAxMRz7ztKUpIrx9VDQNyh lwYDbQBHdBE3BzII1ZFDokD4Y/+PdQc= X-MC-Unique: MmDFn1EqNkKklTLRyA8vKg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ODg/3Ej9C5sUBs49/wQs4tb+66WWVuu0MkpcvzxT4+qGIiCdlRu5TJUDQE+KRKgb3pjNk/c7N0cAI7MVzncneT07tJCKRG9gENyQuHGwlV9e6XtnqZe6m8yBO9j46mr/7kyz+w687OsNa2tGfDKSoEJpoT+74oDxzxqTHZJXmhm6oCnNVn1cZX4ZocyafRA+FEZDZlPbFYe2mgML/4j3wTI8h0Zovbs85Ljr8RynnO5dlj6Xe9YOLlDc37VvwG5hsgPVRZrn8n12O7KSuSZ5pUoNxHXiE1GUuHxjhcmM3bIRR1YEs9TRo5HZLlo5vysgK/XalBDilf4rx7jh1NPbkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uyenm/uJg5Mvz9eegPGcCmFUkYK6jbI7OTfX9pAB8tQ=; b=JyJxsk9Jn1OuBK3UMW3Rr58HmVQcf5ha65qC1+mGcoQOyfyhOgAGAbIvLIJj13VIjQV3SOW/zySTF6SQAMBHLCEAQWDmZyfe34ngtTMxV+cb4UWUpXdjJbnbrFMJfD8DoMNYejc54U9phygdKT6JKOcOKksbUL5INTI90wFuZ3kS48PwoanuikwGf2fUcM9f93t4Jhg8Z7tN9e7NNjmTcpwFsKXD53PQxC6QSnOd801vgJ+iG1uu3E7pDXIbWxKggTLZEgtqV2iBxNhZeJRF4IQIeva2rnZ4VyxpYKbRkgDn2XMF1treTfMzZzlcd6FzXxwGi/1/6Dm6/p9NZh7AKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 16:59:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/6] xen: Switch to byteswap Content-Language: en-US To: Bertrand Marquis , George Dunlap CC: Julien Grall , =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Wei Liu References: <76c9bed5-6643-4fa6-eaf5-c865f942193c@xen.org> <82e54293-926e-b7ee-7091-a85a9db8f6c5@xen.org> <6F5998A0-636F-4AFC-847D-F0CFAC5B624E@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0601CA0067.eurprd06.prod.outlook.com (2603:10a6:206::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e4c1152-6cf5-4c75-4d36-08da3815d0cc X-MS-TrafficTypeDiagnostic: DB9PR04MB9628:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Yhv6x56vUmRzrW6TstiZDQbXsunwhtpE1eW+nkR0aoySsHWW7nDHUCOGRe71x1pA9VF4uMpVHWoK7q+x4kRbKczhlIMBX5gqQ/UFTfBo5SUcp2zd95ure0CpAijuwouMyAQPdlup3J22JtKlQP3sCe3FfY35IJx83qgg1hAStbbC38VXow/6kvrji0fxJpT4LEQObGXiDBzJ0pHoYoahGUW0DWOlResT2txK0tUDZsoh17Kl7G5JXXHMHnb9Qw5lq/AFg3BsYgh8afRrF/zZYuiJSyxyhXL1GtVOm1PzfTg7efmmKn5aq7Yc4R1AW98mv+wVNepCRluuLeBf8RU697dj4kaLinZZM5vtyOxJ+QljK5InZaYZGETvcOA00hDplZmIesAdNQ6CQfLZu9MimvA6STBhALXAYptI/VPDtT6j9JMnjMi7Ac+SKMHH4emQN7nyw9tr0ncWjgTxTpncblnK9HKf1hsSiVGYl2sRjfU8CJkbaAotjcSNFrOG6PXrT5mKHq86H40f41FZG8nusMvLScCqi+HcRO6vO70ZTMjVmCLBLDacyT7aWg35A7zgxAwxDXR6F6sftRqaqtyCokyxk0Uf5QknVZYWjaeoQONeFTUNFX1DGDiZfvlNY4GDhcw4h5rpzl/3SShkMzOg1PuuMLNP2e8lj0JarRusE54O9TbRsMA6ZwYIXn6l33OrW7BcA/H3V3VytOjOox+UAKoS+LIw9s5mg0gH29k4b6BzvtQ2cps+E9V9UVg10ZOB4PeTT+dn2tyJP17tQTGfxW+3HEpHa0iznqEAeQOJkTUNCW6ak0GmOhRGQYjRa2OGXOfN2rLHPGXFQosg8GjXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(36756003)(66556008)(4326008)(86362001)(66476007)(8676002)(31696002)(316002)(110136005)(31686004)(54906003)(6486002)(966005)(508600001)(38100700002)(5660300002)(8936002)(6512007)(26005)(186003)(2906002)(83380400001)(6666004)(6506007)(2616005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1NHbQB/1DYwWG/YyhLgjHH0saqnRk3zkL63PxoZ31GKuDFYtqtFPv6mzLzEz?= =?us-ascii?Q?x5N+lq1nWE8bACy8DlzvXHFwk+LDwnO9IKQFerBVpyElxqO9rMe0NaYah/jW?= =?us-ascii?Q?k5YAL6ihjtpn09W/dl6qFKUIjHxJf86m9nlwcB+11W5fRUGvaCLmIj5ZdqKQ?= =?us-ascii?Q?b6Gvan9z+BopDQUdMRs27L+ovywAZEmnGPTeSk+m37hDhsTnjuvSnv7+dJ6Q?= =?us-ascii?Q?J/D9xkUgq4GLAf1TA2cv7AAqUGvvoCtLf/gI2RLMuPbx5E7H7gjSpPFsgXY0?= =?us-ascii?Q?qywQY2sAgRyLzzAD8wgciiEDBg6xsY9WKhDYDZCkrOlNuOaJtBdHMlxNuTi0?= =?us-ascii?Q?yjgMsnDn7ukd8DYSLAHH8onYXIy1W3f0UJuwG1KSoVdfF3QC0dX0k9yy62SO?= =?us-ascii?Q?LUiDTto/zzJdtzuTE0r1m3tZ6OfPN8FDzEkRb85tluWmsBJcHJAmn/VEXVM0?= =?us-ascii?Q?TVFU9e2W6pwJo/I4eMfGn5wmmvhcGPBfkG7YfInMXZbXJYl9a8nGePBQjTfv?= =?us-ascii?Q?s2z51dcs4rzgd4I3dneiR1a+p22jrLNaAxrJVAWQeJD+E6dfveirIgvzK9mM?= =?us-ascii?Q?j6V0PBSd70vtODX66/JTQxKHMgKsUpFtK1MvXrLpJVsstM1zpSlYpqDFYFRp?= =?us-ascii?Q?6QqypRKy/zg22Qa4oKdXOFlm2xIuJ/rk5LD4E5zR1+PjXHZ12hutdUGn3pPv?= =?us-ascii?Q?6kHp/p7lOEBfkEZ4bX/YzwRh6FBZD8zi9ydkV4Sn3qghyyzwSaZ6VFif2dW4?= =?us-ascii?Q?O22+96e6mKs8BzVCS58Xoob9KrLszHdS/DIN9Uv0C4kfRiv3o13OwnxMIhVY?= =?us-ascii?Q?Jt0Ul0hKi3HChg2DrEGrdfR3St+suGZ1nSFxrk70z8GcCq/t6yLHrOzJVbJv?= =?us-ascii?Q?Lu5I9rz49V7hiWPJMWZy+EwBAbO/nPRPZ6pXn7OJenoT1gi1ckpMpJEkvw1Y?= =?us-ascii?Q?Yznum5t08gUY8SYINA+NZyzS0fdbUkb5p207MuW6ri5g51Wk4U9wf0DR8Qt9?= =?us-ascii?Q?UFMAkL18X6KKKChtPo/dbd3p8k/11svfoLZDCPJecXkFqvUr10EvZrYjedN9?= =?us-ascii?Q?v1qj6ScRSGqyqcsUFJ/DRiN8h60r0BMA5Yev9m0zBDsdfqSnpLhVRdVERDul?= =?us-ascii?Q?mqNmYPA2bkYBImhbXmLEUh+F4+/hROrAVTFmpoCCYxFI1eswe5G3YjOk4uo6?= =?us-ascii?Q?zcAGwVUWmsijpWdHj+ztFuQiYHgcnISuKLztaj302e8RamERrc65MTQKxH33?= =?us-ascii?Q?aqPBWgrEEHuX83OxigQCBarwTSsSjFKgBp4CNudlDG1506CwQGc7B1c28Ywv?= =?us-ascii?Q?BFy6RV4PmODnRIpmoY7LcGpjViGWrR3mtimeqyibhWwzrp3vD4XGyvKJmpPg?= =?us-ascii?Q?V0hXFG3aj2WhHl/ZsYC2oWniVPSc9kgotxzc4yEuhexdyBwqsv8EQ+d1zKwF?= =?us-ascii?Q?Jt91HRIaDCNHGfvPsgide6QsrmfN6jcWRD/nD0QEBivIph0DsMbroKYcyDY7?= =?us-ascii?Q?10W3asldHSmRZzz13Y224VQzBrznufYx4x/UwTyUVi2XIaWpfvr+9MUSyErj?= =?us-ascii?Q?6uCKirBf31TLDPgy6CTbTMhk8KunK/W+Wfj8I4VOE95borvcvOexVUVR7frf?= =?us-ascii?Q?FfOZEueiLbyvxKbm8dJWspoTIeC+R4lnGY6N8ykqH0iEQAwGt41t5cx25D9p?= =?us-ascii?Q?jUf06kxhyO+qQnGCm7pxfrinmrwRvagYpGjVuHUUfMxwJQS2tH2j2siNdEJV?= =?us-ascii?Q?r1+IO164Mg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e4c1152-6cf5-4c75-4d36-08da3815d0cc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 14:59:17.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bpf9GdyMePhiX7wa2ZFoyLDtjY+UKcH4RjRII2eSTDaSjozne6HhgklMFo5FGMiZnO4sbTW0XiW+qvCvOb7ocw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9628 On 11.05.2022 16:21, Bertrand Marquis wrote: >> On 11 May 2022, at 13:11, George Dunlap wrote= : >>> On May 11, 2022, at 9:34 AM, Julien Grall wrote: >>> On 11/05/2022 07:30, Lin Liu =EF=BC=88=E5=88=98=E6=9E=97=EF=BC=89 wrote= : >>>> On 10/05/2022 11:15, Lin Liu wrote: >>>>> static inline void put_unaligned_be16(uint16_t val, void *p) >>>>> { >>>>> - *(__force __be16*)p =3D cpu_to_be16(val); >>>>> + *(__be16 *)p =3D cpu_to_be16(val); >>>>>> Why did you drop the __force? >>>> Google told me __force is used in linux kernel to suppress warning in = sparse, >>>> https://stackoverflow.com/questions/53120610/what-does-the-attribute-f= orce-do >>>> Is sparse also used in xen? >>> >>> I am not aware of any use of Sparse in Xen, but it would technically be= possible. >>> >>> However, my point here is more that this change seems to be unrelated t= o what the patch is meant to do (i.e. switching to byteswap). So if it is u= nnecessary, then it should be dropped from this patch. >> >> I think making people pull little changes like this out into separate pa= tches is asking too much. It=E2=80=99s a lot of extra effort on the part of= the submitter for basically no value. We commonly do little clean-ups like= this in patches, and just require a comment at the bottom, like this: >> >> 8<=E2=80=94 >> >> While here: >> - Drop =E2=80=98_force=E2=80=99 keyword, which is only needed when runni= ng the Sparse analysis tool >> >> =E2=80=94>8 >> >> I do agree that minor changes like this need to be described, so that pe= ople 5 years from now have some hope of figuring out what=E2=80=99s going o= n. >=20 > I fully agree here. The effort involved by splitting a patch in several o= nes (both for the > contributor and the maintainers) means it should be prevented unless the = original patch > could not be reviewed as is (patch to long or to complex to test for exam= ple but there > might be other valid cases). This is fine for uncontroversial changes, but not in cases like this one. Like Julien, I think we should rather strive towards completing the Linux-inherited annotations like __force. Even without the actual use of sparse they serve a documentation purpose. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:01:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:01:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331030.554471 (Exim 4.92) (envelope-from ) id 1nqyhM-0006sq-Dy; Tue, 17 May 2022 15:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331030.554471; Tue, 17 May 2022 15:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyhM-0006sj-9g; Tue, 17 May 2022 15:01:20 +0000 Received: by outflank-mailman (input) for mailman id 331030; Tue, 17 May 2022 15:01:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyhL-0006sc-Aw for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:01:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 340fffa1-d5f2-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:01:17 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-5lqg2WL3MOKmKqHI3EKodA-1; Tue, 17 May 2022 17:01:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6692.eurprd04.prod.outlook.com (2603:10a6:208:178::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 15:01:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 340fffa1-d5f2-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652799678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C2DTYz5hUvQByfZpdcN9casv6oRXTn2TDhQKNQ/Rzhg=; b=fPs8P9Dr6rGc43qcXp+lgflGHsweOHSIj6EaLuB5otDwRpBsWwNRJTxvRIVpLmW0CgdFHK djPyT5XUVlZ8pdgILwDtqNP83KKMWhJhrVE3Iwkzg/vENjww0iAFCLzSiLZOnevntwzN1H aRNEnrttd1MvJ58Wugu/b8Rpnq/SE4Y= X-MC-Unique: 5lqg2WL3MOKmKqHI3EKodA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OplQsgA5Jc+7EL2mv3VvDBbhiZ956/2ldrGBVJm9t3tpdhLQxHgWtWmvBCAb4aOHe9fco+TkQnLmCpAk7NvCVEM+Kg0M/lwpVOwSoShqTfzR/DAnKXyoCbmYyuOCj4kr6zyBrkggA9IvaxE6dQShlTnXPDsMUnAHgqLrZwJCdwqHgi9UBbaT12yj1urkUV3uvDKUfGh9CkLUlG1VFbLxDDR+3eIZBA272I1jz5+ICieZM7Ox67YJXTEG5MNBXLmGF6s4/4yDAd6qJK/7wFB7F+//Jil6R1/JiJt/GYKLoK1WJZq3UGzVtEcckh7T0Y+nyBcgSXH2vNhvgf5mJha+eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C2DTYz5hUvQByfZpdcN9casv6oRXTn2TDhQKNQ/Rzhg=; b=TfT4KpVUDu/H1yMtMAoW2/QJu/k9vTv7LrCicaT8tC6UV9oT800862PISwn01nluHykfzfIDu9BzKWAG+8xESKAs80lyayDp76+CExQhBKcVs1xl187e/4fLlNDwLkKi1EhzaRb+7j0SuKfT6qszw0yqvxeN73YMOPrdQTfqjlnoSM0f+BoXUCfle/DMLqWjdWmWJf6Ra3btYNi29LiUernT6ed5o9YEscnw5uP1QWX6l93mZaCOMsEytn+vlVQVMNkVNOUpZ3WQ+kvk4SxQobEpGXOcCafSy8lSwF2EfoMG4P9oLgodMqaa9HcyxQZbewzHZdoEFuFrRq8PqL4rJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8430c91b-edd0-76b8-6a14-7268649103f3@suse.com> Date: Tue, 17 May 2022 17:01:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 6/6] tools: Remove unnecessary header Content-Language: en-US To: Lin Liu Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0301CA0015.eurprd03.prod.outlook.com (2603:10a6:206:14::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e38351b6-6a79-400f-844b-08da381615f6 X-MS-TrafficTypeDiagnostic: AM0PR04MB6692:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yK7G8166lzs9MEttA3THFvOwVuCtZeIuoIHqNLL8D+R8poiEfmnswzuCeqSwXa50tJXSTKxo097BaqNf35XKMPNZC0OxzmvZWvyTCIJsyy2EAhtESI85DrjOHypYizcHzI1hCtRfMiEdgRtZXS1p33lt1eTGdJbjnysMDiup4/oa6cQrmcGL8Z8G25g6NXsyCtXE8mW3yBXpBCrVmTT9oGSzL//T0vrX+BtMNt8Oks4+5H1r5oUZkVDl3+bWC9GYn6pw+cuX7gJ4BAm4mvWCAcPQZ3M/ya1s36zLmblnxRchKk7hb7T6eWO3sPehd0iLNt3AAOQURgR3AUtseRr1R2zuQqult5px4lR0FgLim2BBV/Ez1H8vkYo0zO0vnztO1D8XxH7dLw4auo2fNmF7luSMr3687jnXpq50Wi9L7b1DR7NiiQ5dtz3L5aLhotrhNnPeO1wHE5LyrST8CAXmEgT6dtnl+5L30DZNYkI1hKiSuM01VLtGs/jd2RLlR2oAeo1u4dGGgVLrsc8hzAQGQj4GhlbAT0WPslfTs+PhsHLAmZM19E4cQw86ZrY0JVXDdIX9y1iFwLOI3Mf+N96gd4IFUuMJi7T0kS9H1/cZpemiplXLNiZJd3dXZsTJP877Iw/OcJ/xZAY3cShd7ZAHXdIFK8X4H9ykDxZqqFkYMc3Q2VGWlYwcYQAy77aRjvkVM4HtFRYbvALr5D7NcIPMXCtt6C1M+geeMkholCxajV27/CFBznthiINVcccHdwZj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(66946007)(8936002)(4744005)(5660300002)(8676002)(66556008)(66476007)(4326008)(54906003)(6512007)(508600001)(6916009)(316002)(6506007)(2906002)(26005)(31686004)(6486002)(6666004)(38100700002)(31696002)(2616005)(186003)(53546011)(86362001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHg1WEJPTkpaVElZbGpJa0lxQVRpeWtPd0dWSDVFanBGTy80SFBBTDFjemdY?= =?utf-8?B?aWR0eVNKbUVCNmdnNDJVK1VueUxsVzhSb0o2MEhXMTJqR2VUcjlmMDRYYlEz?= =?utf-8?B?S0h4MW52YU1vSGJMRmpMcjREZEVMeFNyd0pLdWx5NGFsTmYxcUVHZkdUNHZP?= =?utf-8?B?RGlzVTZXNk5RNFRHUE0xOVVUM0xlejQvaW9OUzZCcUxoK1V3VmF1YXgxMHcy?= =?utf-8?B?cldhdFRFUEgxLzZTSGNTR0g5MjJQSlBSc05aMXdVUlh1RDJvUXk1QVlEL3J4?= =?utf-8?B?TkU1cW95RVBSUnpnaS8zcUd4anF0S3JXK0JFTVdvNUdRMHpxR0t3NDczd0JI?= =?utf-8?B?R0JBL2tCVUdpenE2S0JXd1lWSFZta1UwM1Zyc2lyMFVlMUNmR2E4TEJUK3Er?= =?utf-8?B?T1NoQmlOTEtIRTBNVzZVbVVrQ3BpNmRtZGFqYUtsMmc5V0ViN0o5TnRZYjd2?= =?utf-8?B?L3dRR2JQSVJoNnJIdzAyN0pnTDVNdnRZWXViREZ4cjJweE5ZZnIxYVlXVWE4?= =?utf-8?B?WCtRbjI1Q1lPcWlERjdwSytIR3dENHZyZ09XZ3pNdzlmbVZyV3g5NVFUeFp3?= =?utf-8?B?bE41UUw3dDN4MVprczVyMFJwSzdwdTc0czBYazREK0xRaDFxM21DY3J5cHVW?= =?utf-8?B?Z1VqaUwrQWQvbFVDSDBxOWU3OVFEdjdaY2E5NEZVQnM1aGhmUlQ2UFhZb0lB?= =?utf-8?B?Nkk4dVJ0UGI2MHBqQzI2N3ZRbkJrYkV1dUl1ZnBweXhIT0J6TGJRZWVSaWJ0?= =?utf-8?B?VnZ5bkhhbGpLdmZpdERpTkxyV2dSL2RHMDYzSHR0aWZrQWhqZ3FNU1NFR1ZE?= =?utf-8?B?ejlROVFNR21oeVNZVTBnMitqY2kvTFNUSldkRU1UaXE5cThuSEFCRi9yclFr?= =?utf-8?B?VitqV1dueGNtMTF2SmJ4NTUzWWJxVmcwZFByYVA1dGx4TUthQUVWMkdIQnNV?= =?utf-8?B?TzRucEpwbFpuRm8xbU5uRHRoSG5OcGxVVjd6OW1CKzAyWnZhTHNFK2tCS3hr?= =?utf-8?B?cXNOQi84OEpMMjBsbSsxT2hzRTFjVGFJaWhwK1duTnhlZjNTK2YzbWtFSEZ6?= =?utf-8?B?cmtRTmxXcG1QRU1IRkRwdlM5RXBRZjFHNXJxQ2NvclY2YzQ0UGVLRWZibjJO?= =?utf-8?B?aGJyZE1LY3JFMWZjZzR0QnVjTVVRdFpZaDdGV1pZSWNiR3VPYkNmRHE2bkNk?= =?utf-8?B?b1BveXV1QkdWUlhzYW1CSGwxNU9YdjA0UER3UDI2ZWhSRjdmVEJiVzh0S3R2?= =?utf-8?B?T21DdGJjSGZMbzVQV0RSaml5R3lUS1JjeUJGZFF2eTNuRU1OQldzczNLNEdz?= =?utf-8?B?ZTkycWtQWlVJSWFCNEZ2ZjRzVXM0RFFSQWV1aUNVNW1ZNjUxbmxtaE5meGlJ?= =?utf-8?B?UUMzVUlPV3JDbGJiTUt0KzA3K2xRenVvWEl1bVNEM2tXdm9jZE8xQVRvWk1C?= =?utf-8?B?UEsyZy9NL0ZDUmMxMFRXNExuaVFmT2t2MVh2UVhwa3JLeEsrWXlTS0hxSGJs?= =?utf-8?B?Uzk3dkFlci9NVUhhb01oUW5XQjFvUzZnR29uV09xUVlWeE84bHBiVHlCUnl4?= =?utf-8?B?WjR3cnZrR2ZZRjBSZVY5c1pKVkxwa0F1d3JhY3lXRTdPdlZ3aWMwNk5OOE5m?= =?utf-8?B?ajI3KzZoVTNEV1Q4ajF2ZnM5RmFXYW1hSEVNRVRFWmR4ZVgrNXdzOUJYK3Zj?= =?utf-8?B?a2xlQWdaWHJydnpsWTJmQmJ6U0hzcE5xZW1RL1Y4QUF0MU5hYThpaDBMNEpY?= =?utf-8?B?Mm5uUi9WSlZaWENFOVQ5b3Y2OUI1ZTRqVFpHQXRPT0Q5am5SNTN1VTZvZWdM?= =?utf-8?B?ZFlldS9TS0haWkk4THN1NXRkMXNkZEdQZDFoZm5sb2V6YVBoTVpEOTFsSS9s?= =?utf-8?B?UDhWRFppbitrenBsRXdOTEYrTzkxdWFzcUQ5OHV6aGQ5Qmdlb1BKOG9vM0FI?= =?utf-8?B?S3FCV2p3VmlISTFweHBXVk54dkttSkJ4Si9Xd281QUVMUm1WeS9yeG1yd2xZ?= =?utf-8?B?Vk1IQTZZUTh2UFdMcU1NMHcrZDdZK29LWVh5dU5DYkdVQ2JaMnVIeG9rT0Z6?= =?utf-8?B?MkQ2cWJCQStMTXVwSVpRYk9NaG9HR3RENVBScy90bEhSV3lIM3libDEvME1w?= =?utf-8?B?UjF4Vk02eHI1OE1KTlY0MVdoblpTUDRENlRYa3pVZHYxOXFyamZ5aWhFSC9w?= =?utf-8?B?YkFQWkhtUHRlWm9kU1U4MXJQZnlwNFRTS285MmYrdGpMUFExbFlSbVUrVUxP?= =?utf-8?B?TWpoUEppL1lDZHRrZGV1ZmIyaUpWbVFFQnhSYm5PRGdPelcwNlNncTM0TExa?= =?utf-8?B?aktwQjVKRnNWd2JLc2MwOEhDa1NzeUZrQ0R0eWQ0SVpBOE1jaG5oQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38351b6-6a79-400f-844b-08da381615f6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:01:13.8072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tx3mIOBvCF8gu008GefPtIif2Zt292H7gFMO06zDaNU9Mn30sWcJ3rmlOiyK/vGs4G2+8YQsIdZFO8sC6I/iZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6692 On 10.05.2022 12:15, Lin Liu wrote: > --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c > +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c > @@ -31,7 +31,6 @@ typedef uint64_t __be64; > > #define __BYTEORDER_HAS_U64__ > #define __TYPES_H__ /* xen/types.h guard */ > -#include "../../xen/include/xen/byteorder/little_endian.h" > #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ > #include "../../xen/include/xen/unaligned.h" > #include "../../xen/include/xen/xxhash.h" Doesn't this need to come ahead of what is now patch 5? Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:08:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331040.554482 (Exim 4.92) (envelope-from ) id 1nqyoL-0007g2-91; Tue, 17 May 2022 15:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331040.554482; Tue, 17 May 2022 15:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyoL-0007fv-5z; Tue, 17 May 2022 15:08:33 +0000 Received: by outflank-mailman (input) for mailman id 331040; Tue, 17 May 2022 15:08:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyoJ-0007fp-Gq for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:08:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 361445d1-d5f3-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:08:30 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-acxp4xaUMG6AZvV19aEdog-1; Tue, 17 May 2022 17:08:26 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5402.eurprd04.prod.outlook.com (2603:10a6:10:8f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:08:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:08:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 361445d1-d5f3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652800110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MjGBrCKCZBFFxIz0cjPIUlhGrfR5k3++i99IhLXcat4=; b=bFkLNhtcT2Eh+3hShUsqOAV4D/dZoC6wUDbf/c2anseBO9grUG58nxGlhrAriXG2KKOdfk pXeIThwDwK6yWBhVr7jq4Et3SCBwF9nZwgPO1zn/hwMRCzFY6yoryvNpd2IZVc7M7OXKI0 g1HkwursNVAb9Rk3BaH4h/VqpbElPm0= X-MC-Unique: acxp4xaUMG6AZvV19aEdog-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqMBSSh8Cxf/CS8UeFBs9UTHvhmnpsQOaV0TsmQytvCYdDDjSWIZIA4N8UyR0JEryKA7oLi3+m6KuUg7H1GMN1xRItIVJX88qCljA5pvdwHW5YTdyKmeTnE+DrGsZw8M6zpZIn4TUZn/GduSJi4G2XYtaCPlbUxyCAJ8JyIRKPrVDHwxN5WBp19ion/mGE0q6QzFIkfwCNLVR2V7kcYTtzc3LFOsD+fMDHhpJ4BiY5bc5JqXlwwgH1qmyJRlHdzqgS3HzVLxLPaggI3G/0DEfZ1hE4cmq0ekkbA4pWSs96D4zydVlBlcCunKtD3peY5M0fBxWckJgggSWJlHJ1IT+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MjGBrCKCZBFFxIz0cjPIUlhGrfR5k3++i99IhLXcat4=; b=n8TF9i8OGxiBBjMTVAv/0tNsO2Nuk+GvfUmj8mewoO0hm+GtExdgjgexaUC+fzKgR6P96FZAOiQVN4SEtUFAWFm5IGCB1IELlQwOg7krDJAfERRNNVDgEkKaHHUe7ph2sZLlx4BBPFvstXVmXBZ4SSbtAkwLtHMFv4I5X45SNmlu22ssoNDdCKqBjgBg6yyCvWC4J95VW/ELY0ZLeZVNUAUbxRAlMY6kB2anoSWAhNKoivaDbmVG/bfTKXl9HuhTAg/wN7KKbz3QxNkKZEd5rwAPZ/dDLAvDvv4E+mj8LtbXxb+VM3XiI84tft6ezY984cu2YjJRwNIsWCGxv2OS4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3d3a35db-d2fa-0893-e3fb-d1edd58cb95a@suse.com> Date: Tue, 17 May 2022 17:08:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: ECLAIR Xen x86 results and progress Content-Language: en-US To: Stefano Stabellini Cc: "andrew.cooper3@citrix.com" , "julien@xen.org" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "Artem_Mygaiev@epam.com" , "roberto.bagnara@bugseng.com" , "xen-devel@lists.xenproject.org" , Bertrand Marquis References: <3F6B0F2E-0CF6-4C60-A803-DD8A5EAF0DFB@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0149.eurprd04.prod.outlook.com (2603:10a6:20b:127::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7344df8a-c037-4b29-9b0b-08da38171702 X-MS-TrafficTypeDiagnostic: DB7PR04MB5402:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Ids+0TszYD6H8w047OuvhqCyEgzC9dOwV70+BfsoKrPaL7fOzi5x4111YLiJ5O4HeatDxQFnguUXlBJ7bZoLB3fNYLccp7HRyKshuMBawLnL95+3HugCffnz/ttnhKGIA4itqtwpKrQyjUc8Jg2p+Y4smACmR3L5XzjTWjk1VSi3JknVR9o1Tk9I/G5cYh1cwx9TpZCRem8ATPvfY5dce7BgL2Mhe0nVTLTu4Zx1U0XMSdH+Zfyhj7MqfEJGe4FVDy5H7OdDh3PeuQ+c7zDXVSGlCkDnSMX3GwbyaUA+dJna6lgOGq5tlSWYjlT2dKCV94VxA4cSsspBnnFcZ2Bc5ijZeubvD88143EK4LN01P7CpbBJMQoIr051UHThGsRQGXLT0L2i5LOuK40qqI/Eb2MeJ+VHf6uUeenOuFixdQGYQcYKnGznChgF60fX99f1gJZAX5M02nu7PdICT4X5eVMfoPX03ELv6LvdwQdoZEIgmIQeHm/2TCnEkESqCCpaLnLNW0KyEk5PLB9QHqX6ORfNO8gQmcVypHn/CNgLSvw3glkx+gmMzirbRPx15IoCvLooJ5AFYosxsDTJ7dOojgWAmImk1HCwXUTUIWXrTJU6/sXOAiHCz5MAIeK/BJFFECLThf0UnFP4wMDuHtz3BDul0xtl0ZTix9RjdejhmZLa1v65wDbyILgGDqvGRg1JFeN/5I0F3kmb6iXWH8dGrzztl8IcUXY8l2H/MhFOslfy9Rwr2JrX1qufEz2I1g9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(316002)(36756003)(2906002)(6486002)(6666004)(5660300002)(26005)(6506007)(86362001)(6512007)(4326008)(66946007)(38100700002)(66476007)(508600001)(66556008)(8676002)(8936002)(6916009)(186003)(4744005)(2616005)(31696002)(31686004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWhUQ201dm12bCtLdFJIV0krZW9rN1NYNDBsMFFRMDhndFN2bCsxVEZGcEYv?= =?utf-8?B?MFJvQzY2ZnNHWFZBWUdlZEQ4d1U0dmViTStjMnh4MnZKZ0crN253OHE0TXhu?= =?utf-8?B?bVJKV1huQnJHQTF0SWozLzN5OTdoY0tQQ2lpbjE2Uzl4N0tNTUx2cXpQZU81?= =?utf-8?B?WXZDWkZyT2U5U0FNR3p6QnpQNUtTQmJrSWkvaTVqRHJ4VHR4alJISHh6S1VO?= =?utf-8?B?SEZXQ1dSaFBEOXVic2xHVWo1SEdqeWlKTTc1ZWoxa0U3WjZZUm9lNHlycmE5?= =?utf-8?B?QWtFdFlNdmlHY3dlNVpyaTBMMFJCN2FFWm8xNityZnU1Ymw1d3owcUNGVFNn?= =?utf-8?B?MWo4WTRQdFpDK2tKL3FRamhTdER0bThpam9HbjExNCtSYUVTMXlkRE5wRTlL?= =?utf-8?B?bHdJM3paYzRGZmt6WmxBc2VMYUgyVTRVU2hNcDVDMVVVK3QraS9UbUk3Mk9W?= =?utf-8?B?T3Z0K3NQRCtSeWdSeUhJeUFPd3Q0cmxTQ1J2NFp6dTFJdUlmcThoNVBGUHhr?= =?utf-8?B?TEZ6UC90MjNzRUw5SjBxY3RDRnQ5dCtJUHZ5KzBraGVZOEV1ejdYKytkYm9K?= =?utf-8?B?OWVWK29zVS9iY1dvUTB3ZlFhaTdTbk82RkM3MjlwQkFyTWZ3NENJSDJld2hY?= =?utf-8?B?Y2l1N3A3YytXWTZTVi84blc4cGlWWGVaWVBIYmJ0bUZjRStvekp3YlJscGdC?= =?utf-8?B?bVFYK0JlNlRlc3JiUzQ5T09XRGlXSWx2bnQreGtkdExrVkxFRnlJUHkyWnR2?= =?utf-8?B?VnE3VmxIMk5WNnhSNzdCSEk4RnVTOVJORyswcEVSM1NiUmlOOG10M3JZN1Z3?= =?utf-8?B?MmVodDBZTEZsSFBTa1VxUTRYSjhqcDYwZ3M2RTlDRGxxcWYyYjlPVmo1V1dX?= =?utf-8?B?bFNuK2lSblRhMExlTXFocnBpWjVLMTNESWRxVDR1NnhNT1RPOXBtdGlYOTlp?= =?utf-8?B?N0R1VStHL2lWT0I2Tms0aFRRak10eVlvbWJmRjdQMW1kVm0wNVpHWDMrYldD?= =?utf-8?B?b3dvRlpleFdHbmtnelY2Skc3YmErMEg4R1l3NlJhUjkwQ05jV3Z2Q0t2d0RD?= =?utf-8?B?dnlQMElSTkU5aW42czdHeng3VjZ4MmJYbzNlRXRPUVl5dDcwSi82b21lbW9n?= =?utf-8?B?QWVRQkJqVDRNaXJrSHdkQzlLK09NUzliQU1XRnV1a2pXbWVkVFNBL2Njc2pV?= =?utf-8?B?NUhCTkFwaEFQdVRUYkpQakEwR0I0OXJFZ2JoYU1oZ00zeHNMOUszYW8xOFZx?= =?utf-8?B?WlN4WDZoVWJkOFpyRlVPUnR6M0loZXNQSlBpdGg4ekhjQ1p4SnJCRDVSN3FU?= =?utf-8?B?TzV4d0Z4bjNlbXlsUFR6VW9zOHYzZjkxODg5MVpkL2gvKzVCN2xJSU9FN3NQ?= =?utf-8?B?RktJTXJuUWhENkwvNlBiQ3FIMUo0LzN6QUtKMVNEdFZ1THBJdGZ5SSsyTUhT?= =?utf-8?B?ZTd5ekRpTmIyK3poRGNYaXJXa3dlUGkzU25GTDdvWFUyamRUaHF3TFFtK1R2?= =?utf-8?B?bENmVHBnOTJhenZIamRLMkxPNkRoMFFkRXhXMUdxY0RqZ0l5RGwzVlhTUUhD?= =?utf-8?B?bEN4UmNuYitBWEcrNExiaHpheDZXR3FsLzdtV2lqZ1oxb0VpdUhBQ3c4dHFj?= =?utf-8?B?Uzc5aS9kL0F6ZnhXM05BalozUzhENnFCT3RiVDRoT3VhQ0w4c0NKMFVPVXZ1?= =?utf-8?B?cXlFNXduejlrVUpSS01RbzRud2FNWHExdWZ5QzFhUDRkUVVNQ2VwckdyTjA1?= =?utf-8?B?ZW8raWNMcUlTTnJjSzZxbG5VVlNHdWNjN3lLK3lob1Jpay8xaGQrNUNGUFlo?= =?utf-8?B?dGl2RDAzdTdoTzZWclhKdEpwSVBhSVJRcGhuQjJvUjJpZzRNaElmM3RnZnZG?= =?utf-8?B?cGltWWxXY1kzWlVDeDQ5M0ZUejVBSjR0M2c2YkFGeWdPbVhNUTB4cmNWNlVl?= =?utf-8?B?KzlHSkFiTTdSdTBGeXRxaEZJaXVSY2FSclpZL0lodFN4SzNYeUxydVhaOG1i?= =?utf-8?B?ZFl3WTYxNGtvQmttcWNCWndRTVpnS2EwMGVzcEp3VjhKZ0RpdHViSmMrVHY2?= =?utf-8?B?VVlYUVNsbUYrbGFJZTRzZ0x2bHRMcmxlVDNDYm0vSWNzaGJaNzd5bis2NXlu?= =?utf-8?B?bmdQYXM1WnZrbk5PWnpiVWtyeUlaUUdjOVkyU0N4OWU4ZEJHcnpRam40NHd2?= =?utf-8?B?WDR1eVZmV2xJYkVuN2QvUHp4a0dubVlHT1ozZ0JjRzJQdmFIUkhucWlCRmdE?= =?utf-8?B?Sjd4RUFseTZNVFBVaEVkMGpNZGhNTEFlSHVFdWRxZTZUYzFpbkhOV0RERGRo?= =?utf-8?B?NU1GTmNDQ2E5cGdRNDcvUFI5dUtKZ1VnV1YwMHRudituSWc4UW9KZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7344df8a-c037-4b29-9b0b-08da38171702 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:08:24.9515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gk1Y8F7nZxNmFY7A9FPx3dpiaa9ON4K8WcmGJ+oVa4KfUzdpkZa9x5x4a27wT9+/ijzQF5kDC2clgLVm6POhCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5402 On 09.05.2022 21:55, Stefano Stabellini wrote: > # Rule 8.6 " An identifier with external linkage shall have exactly one external definition" > > This one is meant to catch cases where there are 2 definitions for 1 > declaration: > > header.h: > extern int hello; > > file1.c: > int hello; > > file2: > int hello; Which won't build (link) anyway with our use of -fno-common. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:14:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:14:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331048.554493 (Exim 4.92) (envelope-from ) id 1nqytU-0000gB-Uf; Tue, 17 May 2022 15:13:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331048.554493; Tue, 17 May 2022 15:13:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqytU-0000g4-RV; Tue, 17 May 2022 15:13:52 +0000 Received: by outflank-mailman (input) for mailman id 331048; Tue, 17 May 2022 15:13:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqytU-0000fy-BQ for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:13:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4ac4720-d5f3-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:13:50 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-jINpRsnqMF2RmHCjKjHhmw-2; Tue, 17 May 2022 17:13:47 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7548.eurprd04.prod.outlook.com (2603:10a6:10:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:13:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:13:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4ac4720-d5f3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652800430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3SRD3vVzy5DO0x/6e29KtE9hHSxC9escK5bpjTqaaL4=; b=R3E+WYNzCfdaBqEJDvQs2ss1KQ4HYF147IX4pufF5y8PjMSf4VoWn3JooubFJyDZ8KW/KD HnkQtamn8EOTqobccbn8NjQWwOyM6XPXpPIgx2re9SMOfGessDWLBhqOGDeMI96OESIah5 2FnJlpVe4WdrBwRF8GaA7DEEKgP40JY= X-MC-Unique: jINpRsnqMF2RmHCjKjHhmw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VebXLeGJNDDajadR3QjmJib3Daa+ay3U1PwMj+mttzKrqf44Gd7gh+UevvbEXClbasrdYsyCeyOYC5G2mHjaL0tKRpWb2NLct1k/hVDzcj44sfE1jKr+n/q0EMNecYyeGTx4bFIwejGZI6vD9dq+vSWAquAi0jeSAI1T6Xhq2DylLZp0LqRsUrVyT9q+I21iSE2UPdcWzEqqPr4gD5SvQ/nultgWvCKLEb6YMb7/axg8WPMQOvu5LcFsZOFz6kct08FbPBV1J8zZ4dBIMo5heWR4OsALlMCxOLbvN3BF/ntIyPq4lFh0rAbwI9lQ1LFRrtDz8Aja+hJwzCyAd5D8fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/LPmWU8cNPJ02nq5CuvfOIZKx5d6armEq33dNkYfaM=; b=isIZyR139l1aPVe7XnAuW8CF5AAi7H9FqVP5xr4jxVUmnAkhVyP7TJ1x8ZfT7TUvib+JadT4KeLPcP3BQdzVvqco1IQU/FX9NbdZwExoBxzj/UIFhRaOv53yUcZy1mUpgyWWH++07UYCHLwehfG3Yj7BxtNzsoLZwNbPED5tYLLFzwg+SfRUyX/J8FMM2l2aGLMxC8Nlz83Hgr+xD7Cmtd8Sg70FwXF3hSJzOPFCMNhOE5M8kbcGZnTZ1FOjGEyoGi7mLZZ7M8oKIUqgc44AKeWqJvSOQ0fN7nDuMw4I3G5HZT2uzV9Sea9mpfKxTxuQPWaD4L7JsNo/tTkeRosLPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9ad924ae-1a40-6ac4-55ec-a468dadf5dcf@suse.com> Date: Tue, 17 May 2022 17:13:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:20b:462::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec1d2062-029a-4c3c-8e6a-08da3817d694 X-MS-TrafficTypeDiagnostic: DBBPR04MB7548:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HzDIM7P9wyOMW1bW6plkQjn11W/w6plUdxOoMofjWh7KmHW2tfTeYnXx1ScvJBaTelKXRKuYL7Oh2C3AdDi3N6GpMudL7sR0nWkLQVtDIy6IrlWYpecplz0mbqCj9pZ5zJXYiGgcajgW/lZtSjBxR5/HeIuxf+doTP3MVyGQp7unaMNwLW8ZNnEDZCdvcE+/l0SVmqlh7/rbYgHCUqV4/0iz/frjdEsEs4/jF0UThBzDWg2iQGUN1UJJ/RMaL5Q2jEGoOLQVK3lfOm62XFd4/zKLfDJv8KOiinH+ODDVynVvcjYAC02oO5egofDX/pWFII1obn/6NXnUE7AgXcU+MdwOjY2KLs79P5z8xQ9IKiy4ZWz4LdEZ2uKxqthy5Nc3n8uKTOTjbWtQEPyBP8av2e+MG9AZ6iANoo3j7pDg1Llsfx9De+tL2GGUJukpIqx02X3J0Ak/I9blzrZLRWyCyoa/IQlXV9aZKcf3ICZesX8RHZ5jJ10MeFsPYDKXNWT/j1WzKzQR2Czk6LQg8hH4N0fuPLv27NpvzcA67z5qOVDDdXLNkcWlckvah7QIcJRHWzpvcNbILSFuIW/HjaTTIBNpmKPoYQoiGClyKlS0l25KspW7laayyWo3oofvu4K9D4zDNEpcccYSaJ0OY7L9rvTGSA4f3jh5o+7ZvZeMXUdeDNGOqBiCy3xur/fAqqTNs6iGD73QBNY6BQnMHYvTRL0wT5ElqE34pYiqc7FQQ2o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(8936002)(26005)(2616005)(8676002)(86362001)(5660300002)(54906003)(38100700002)(316002)(31696002)(66476007)(4326008)(508600001)(53546011)(6916009)(2906002)(36756003)(6486002)(6506007)(31686004)(66556008)(83380400001)(66946007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0T57d/BupXTzU1dMH+bWO9Ii9lCEGAtkFd2FvcQVG2ZD/j3VGEjbUE6ZTio1?= =?us-ascii?Q?/4/yieGNu06wdfl21mpZRLT7PhmGx7zLeKZ3GnrFGKSEW46KDQlUYkH/Eei2?= =?us-ascii?Q?wYdbS34AYgWhgQMhKjSTM0byAOGaKdMo/jTlPTzS9fIcT3BNmbmkCQ7ceoGq?= =?us-ascii?Q?tJXFx+ND6AXIS0t+JHLkJbVRAuqhuPnGLj3CFNzCJwvuyipUG5PgumClGpyk?= =?us-ascii?Q?OQ8qtveSy13sUC73qJ5KUCFsAbwYauD57aTG5ypTqBo3ymgIh77UlAlEa/iJ?= =?us-ascii?Q?p2VTwmnnyk/VgjtouEChbw5EfHsiyP2ynGtnDyhZG0eOBdBkCx1zn2W+tX0P?= =?us-ascii?Q?oFLSf/dWbnftMOWo4HTya3X8C+04uVymJOa/4kPpe6WYDVszbxsLxA3kfarm?= =?us-ascii?Q?b91AVtx7z/mPfxnL/HBZWaWTzT38IQs3pZuQXUuYQzOpMQqyZPolR0nvPdqQ?= =?us-ascii?Q?98oU7amvjgmkV4f/XrOY2m4U9wWyoQT5d0XeMbj2nnSlX9W/L4qiYky9VOUt?= =?us-ascii?Q?e6yq2nNErqyyL9CkM5bOwuXa9MIMMzepJ0b0OiciF7Q9cF16D53bxo8DH04d?= =?us-ascii?Q?plXA3e2C9qYNc7ijIKamjJNcsIzziSIImvPIx4PNSVHhVLzEb3Sg03mrKZfw?= =?us-ascii?Q?CKNLZTkU2jz+VlYRq9iA2FbkWPC0DtjSl3A/fol76g6mm+X9wIm/YkItFnjN?= =?us-ascii?Q?BgpPziCdxetANOPNCJbfV3WWxUqhJ46N0YlKuyRIPlhQ56GwvL1IGWia4xwp?= =?us-ascii?Q?31JSG24UVgW0BmX8q50Lt85bhQ9iEwCTLAcdXQRCkRfcFENvG1LlLA9YyiY3?= =?us-ascii?Q?Ai8cAZsmJy1hEowA7vmmyDKgJvZ+G8zHdr+5CRwrV5oEvDPTXoJjq05REOqX?= =?us-ascii?Q?+VLH+pVn2MuQNyH/As7EE+B+ILouyxoFHCyic4zngiEoOC0wIVDFzwLFzLXP?= =?us-ascii?Q?BnezuvhrY5QbUNX2HRmPNFAknt5iBaXAv3h5YX7gFAIXcucAya7Uv99AA7jx?= =?us-ascii?Q?GQMnlgBOTDiIHEkNJVh/M8w6ObdIqbgf7NonjU1DtOaKx/6Pn9SBuJTTJxNq?= =?us-ascii?Q?QqZix/Aob0Dko8Mnu9Gsm/yo9AfC+n42f0d7wPWBXuYn7uza8+JymhUFf+1J?= =?us-ascii?Q?IUeCP+AVEL/xfKU91/TKHpODaUm/knrdzqCeAGCapyCiwgw5XYoqf/SNOb4t?= =?us-ascii?Q?Xl7dw6D5yA3ufdPOuksDPfdZeWzxAEv/5DaIW4HqEmR594nIyYTTkjWRiTIb?= =?us-ascii?Q?uU9k2ZPuUCC1i5BV+fpuo/8kx5Ab20Nl918+sF14WV88O6LOxr4+EdkI+xqU?= =?us-ascii?Q?3AprUgeuFLHrWIbgCFNjNiyo5a1GMUDNFANpzjeZo5M4GGd1SLWuY+SnM92n?= =?us-ascii?Q?6lk65CaQzaOlxFFpp5AyC1zHgrOP2V3Qwj8tVSEC5cpa4KEnXYpufxT7INO8?= =?us-ascii?Q?AMyrwDngbDmbHIDa16nQG6T0zwAYO+qYHB3tLhspNHT/OcDBk4rONMVMAPv9?= =?us-ascii?Q?t1kNufaWj17hh9jC3DpdEW1FpNdMkRj24d4T9wJyGe5NONR0gI4G4xb2yTcg?= =?us-ascii?Q?ROTKj/ocY2Q8AtuXnSmXFnUJj8eSJASB6DHmsFqMatomPX4hntJ0XMmEPgAz?= =?us-ascii?Q?Yb9HoBt2p4wCuTRBNgrDRNoG8wVCwi9fEtwa4GLUVTVYPaXb5PICqnuhvput?= =?us-ascii?Q?JSA4uxIHdPSucR3ogvMKqzOwIK0xfVoVNda/lyS7kZYmpCjjgPQlaE0jDcjS?= =?us-ascii?Q?KidVZs/66Q=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec1d2062-029a-4c3c-8e6a-08da3817d694 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:13:46.3215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ijJ0eVHYUb8QQ88LprZHkC53LajXyZt3QieCQuqT6pTFZJ96WC9zVJksDQIlsx3XAscTS9IWs2GNM+7D57Impg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7548 On 17.05.2022 16:48, Roger Pau Monn=C3=A9 wrote: > On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: >> On 11.05.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: >>> --- a/xen/drivers/char/ns16550.c >>> +++ b/xen/drivers/char/ns16550.c >>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t ski= p_amt, unsigned int idx) >>> pci_conf_read8(PCI_SBDF(0, b, d, f), >>> PCI_INTERRUPT_LINE) : 0; >>> =20 >>> + if ( uart->irq =3D=3D 0xff ) >>> + uart->irq =3D 0; >>> + if ( !uart->irq ) >>> + printk(XENLOG_INFO >>> + "ns16550: %pp no legacy IRQ, using poll mod= e\n", >>> + &PCI_SBDF(0, b, d, f)); >>> + >>> return 0; >>> } >>> } >> >> While this code is inside a CONFIG_HAS_PCI conditional, I still >> think - as was previously suggested - that the 1st if() should be >> inside a CONFIG_X86 conditional, to not leave a trap for other >> architectures to fall into. >=20 > The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86 > region already. But that's likely to change sooner or later, I expect. I'd rather see the surrounding region be shrunk in scope. Already when that CONFIG_X86 was introduced I had reservations, as I don't think all of the enclosed code really is x86-specific. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:18:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331056.554503 (Exim 4.92) (envelope-from ) id 1nqyy9-0001JW-Ho; Tue, 17 May 2022 15:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331056.554503; Tue, 17 May 2022 15:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyy9-0001JP-Ex; Tue, 17 May 2022 15:18:41 +0000 Received: by outflank-mailman (input) for mailman id 331056; Tue, 17 May 2022 15:18:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyy7-0001JJ-Vg for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:18:39 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e44fcc9-d5f4-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:18:36 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:18:34 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by DM5PR03MB3162.namprd03.prod.outlook.com (2603:10b6:4:3c::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 15:18:31 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:18:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e44fcc9-d5f4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652800716; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5+b3cbkFIsX9pHHhrCj6++1b2O0LbYv5gutHvFyAAqc=; b=aNkp9vB4IRN/Lop7ZOD8SdBuQe57Dgk5VlZZVp6i8VABrUBGCOR+qrZ/ ZHNdegcfibLvVsgswhnsKk9FDs/D9utRHb5F1s85JGyGwBKAh1/6cdYmR ig2SZc7t+mkxlf4T/iVhsO5GkxmtyM2ZaGWhvTTuOtGB9U3gN94tsq5FT 4=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 71517865 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XMixZKIqhhZLiudxFE+R1JQlxSXFcZb7ZxGr2PjKsXjdYENS1TRTm mseUWCCb/eONGSmLtsgat/l9E1V7cSGzNIySwVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39c32YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Ih2msaKGFkgBbHrn/YkSgtxCjgmA6ITrdcrIVDn2SCS52vvViK1ht5JVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM6FGvqTjTNb9G5YasRmGffYI c4YdBJkbQjaYg0JMVASYH47tLjx2yCgI2MFwL6TjZY42Gv93AV967fSbtDXd8SsX+pxwknN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3uFuqE2ewCoUEhJ+fVm0u/6ikWalRslSb UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbizt1HUABRz9FLdch7ck/QGVz0 kfTxoywQztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:HtLokKgOQqDCmPRBJWk38PxR8nBQX3F13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICPoqTM2ftW7dySaVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj1Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnX4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlVFtyssHfpWG1SYczBgNkHmpDr1L/sqq iJn/4UBbUx15oWRBDznfKi4Xin7N9k0Q6e9bbRuwqenSW+fkN0NyMJv/MnTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZMOq59ls5Vka/ppVFaRl/1twGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7gywlGl/NIwgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71517865" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VK4oiddWrhTvzD59EFitlHwikF6wb2SlrlEKvB71PPNRKm5yNzF7hLih2R0uNfVag9UnNvKMUHeQLTYQ4dIRXvGSUmpaGPVrHZKcMg1q0I27wuEMNQWUVi/ixzsydV96ASGL5TTzwnOYK1+OPlp2rF0j+dYzrWufGwqZJCfeiiW0S+zo+PGk50ZXHcETyGJbJCUtRqrvoGm4UJGGk7IriPlwNcHCp/cam3AiJBFurYnDLtEJjIokayWtb6KHa1Di4v893KdIiy0vcmkDcBorDaP4t1m6wunSAUPqF6QfEVIV5V71gYWquE/sODWe2KaPs4MpM5U4145BQ39WHfp6fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+b3cbkFIsX9pHHhrCj6++1b2O0LbYv5gutHvFyAAqc=; b=BHhhmCbounDXqVQEUuqWvaWXwa61JXvCFzTcYkDAcdGRt1azM/RAayGftsvQR4KELRDGkTDV0TFXK7wjOAUTKS89gvWfIK6D01e6cAne34yrgQHI0QPyjn9z6L+V5LyP70NGC9lEMdSuULcCKdqxUQwyV2rq6bjb/JFFsmmSpoE4ar1z+5Q47p5C/CJOO3caxWsWnXVoyF9cPUgw99nSYJguXQQsMVdYikZdbBc8F/YqcFYr/qq2DH9l2pD3fjmhuRYh6rvM1QFq+K685ItFDfJi6gobievnGmyWlRf3A0KQhYKTIPI4oL0/gfSaj1YTj1piwWgro8e2HwMOgJoAQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+b3cbkFIsX9pHHhrCj6++1b2O0LbYv5gutHvFyAAqc=; b=bA8e2aPyr80uyHXidJkWksgrzy1znfA+JHfqj5o8Hhq6QXlCWsJyQXZGXGaCbXMbk/Vsr02/ovlHyinFtdY08Fxey1eFT4xH4GUNMg4fptZTwSRrQENBAJ89xmvVg2/pp0PcLfEwMqVIAkdXer9HhVRpqKSHpNHhnHY3BG4ygqc= From: =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= To: Jan Beulich CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" Subject: =?utf-8?B?5Zue5aSNOiBbUEFUQ0ggdjMgNi82XSB0b29sczogUmVtb3ZlIHVubmVjZXNz?= =?utf-8?Q?ary_header?= Thread-Topic: [PATCH v3 6/6] tools: Remove unnecessary header Thread-Index: AQHYZFbt2pFGuRmHsk6KyzsZcEmKTK0jNUAAgAACdjA= Date: Tue, 17 May 2022 15:18:31 +0000 Message-ID: References: <8430c91b-edd0-76b8-6a14-7268649103f3@suse.com> In-Reply-To: <8430c91b-edd0-76b8-6a14-7268649103f3@suse.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10551915-220b-4a76-69a3-08da38188082 x-ms-traffictypediagnostic: DM5PR03MB3162:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +gXjm9UXQTRClpmHV1Ym3O3Wshvx7eV87dwnaxlC/N9Ciut4KfEglJhAq3EFlziXU/F+cpcvIN4ZZ7AQasnUBORxqGp1z2pPJoaw0Foc36ZXCDob2a0OJkMq/Y9qPdj4sL/txO9WQFH0RrDUWU0OPOP59aROM4/hHQAlPDCmOVXMWLS9AEXXAFp+xMc2+g2RZ+7/cFYwqbIXaNu+kjmtwM1tZm+18cTuOVyAEsuvWpG1u0IazUicVF5iEy54IT9yEkvrs7pfacODGhTDfjSk9lAAmeXJCBcMShYlKahPezGxMivYbyAJFbLjfyPE6rt4u+gKewSnnZChcXhV4/3Mgf7qK0551L0kaEbkDTXDDv8UzcP6ckCOlCLVOKpvXW+Sh4Yveg104GeRu2fghIGQQ9v2IOIZr1mXiXGCBtwMKivopIqyIh5xwz94hAm4Lq3BprSOpfubs+afDx1ZxvSVMJAVy0OfiBRfdfMOlAIYjma8RWe64psG94fgi3EJmRxPNJCT6kVZQqRgVTZ7xGee/HWPArc18t75MMe8I+Vsr3NuAet6vpGShX50pJXkzxBZBFPfOfI0+iZEIOWR3PJJnRPhsCX58/EekxngBnLjfpsXfQU7irxdDYq/5MaWW1JqWNvIXAx2GEAqJOv4T9NZWyGzUcuq1FVKT3f1OMNSM8h9jztz4NUIkMZmFNgioKRZ27shxxhLWFPx+O0zJ4cSMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(52536014)(2906002)(186003)(85182001)(508600001)(5660300002)(4744005)(224303003)(7696005)(8936002)(83380400001)(316002)(76116006)(6916009)(122000001)(26005)(6506007)(9686003)(54906003)(86362001)(4326008)(71200400001)(33656002)(66946007)(38100700002)(82960400001)(38070700005)(55016003)(53546011)(66556008)(66446008)(64756008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RUtBWkFCeTRuN1hpdWdxcGc4R1cyQVBTcXBUOWU4NGduTUZ1aDFFV3BsTzNV?= =?utf-8?B?OEhiZUdMc0pDV1NDRDc2dHhrUWpQSGxKcjBSQlZMY2FuUW5QK1dNQ2VQT1lv?= =?utf-8?B?anBzOGorenI3TEVtMDY2eUVHRFBMN2RWOHFJMFBUR2xyTzBlNXBleE9kck9s?= =?utf-8?B?YzFCZkNVb3NRWXhtM0ZBRmZqWVUrdWdrbTBUam9FckcwYUpiK3luenkycG5H?= =?utf-8?B?S3V2eFFjLzk3cXJXdWpLM3B4MEMvRWQvQ3Z2NkdoUUo1dVU3UkRkRzZrR3ZN?= =?utf-8?B?SExEd2FqTFIxNzFkVGsrb2NWOUxWZjhYaDFTR1c3Vm1vYWoveHREd0U4T3Rt?= =?utf-8?B?ZTVyTmhuU1lLLzNrUXdrMVdNeEttT3BwSEI3aWRYT1V5OVBOeUI2YU40elp0?= =?utf-8?B?T0xYWWZpRUUyUW5UdEViamZGNHNib3pTRWYvU2ZrUjUwclpKbXdZWEJnQkYz?= =?utf-8?B?K2ZRUzUyRXNHQ0tacXNEQlZiZ3dTZStFS2hxTmZzUEZENzNIbzNtc2E3SSt3?= =?utf-8?B?UC95VzRvL2dRaVFZaUNBeVJFV0tacHpWNitrRXhkN0V3anBBczZCL1lhcGtX?= =?utf-8?B?em5iaDV2ZlNtdVYwclQyR3dlRk1xS1NYdzFzWlZGTzRFb3IzZXRnaEU2YjVq?= =?utf-8?B?SFFwV09XbXdydXN6b3pHMXdVS1M2YjJLV05wL2ZuYVYxc3ZvdG92MFM4VTI0?= =?utf-8?B?aXZJMzk4dk41WVN2NTYzMitwaENEYmZ0cG1vRU1ERGdXUUxlU3E0TVdQa21C?= =?utf-8?B?VFhTY2lkUTlJalZkV0VMNkJicWx4WU9CVFhNT1ZaTHpZd0hqdG9sd1BxaURq?= =?utf-8?B?c1BQS3lqazlSVm9SbkhhWUdrVldodWlXSW1SUzZldDRIOG1vUHVibUVhc2hV?= =?utf-8?B?dFMyRmtGYmt2UWpqbUMwTndhcW5BSGdBaG8xdzBueTBrZVd1VTlJVk9IK3hm?= =?utf-8?B?WCtRNnFUK095OU4vN2JGdXVXRk1nYm9ObFp0dmV5UVRQWk5DcHJmTWhNd2Zk?= =?utf-8?B?YThUdzZWODBBRVhqTXMyRitFZFVlckE1R0JQWEpGclhUT1hYeWsrQWZteFkw?= =?utf-8?B?ZUQ0cXdnc0pRL29aNzI3YUlKOU9IbEtEbmVxRVI0clNGQ0RsM3UydXJpRnZX?= =?utf-8?B?ZVZvS2xxOHUxOG56VXVST1Q0TDJIZGZhaEQ3amp6dTlNamcwZUdDcmQvT2Ni?= =?utf-8?B?SHdEUFNNOENUUlJWcWQyc0ZQWlFRNUV0eHo3ZGVqeHlMQjhnd1RRR25BbkdD?= =?utf-8?B?RGFiZXp3VWc1MjZBUmgvdEpHeHo5czJKOFpKT2dlQ2poYjFqSHFVWTdxdEtt?= =?utf-8?B?cU0zZitrODNMTnNsZmNVNkhZYXFrQVVXcFJVOGNEOHZ3RmFwWDUyR1FUZHR5?= =?utf-8?B?bE93c21NK3VjT1EwZFo3WCsyQWVwdzlyWjF4RDVnMkRZK1VxVzBSc0lxYkdw?= =?utf-8?B?ek0rWGFlRjFoWXJGblNjN3JsWUhLYURZTk5Qd3JFeklCN3FIOTVRTjBDSllE?= =?utf-8?B?RkZEbUo4UkFDNXdoSDVGS0NDSWxlV0NxbHdOaEVBdVJwWHFsenZvSVZWcFpw?= =?utf-8?B?b29xWmV0dnEzV3NDaXNHNE00SFliZ2dWazJJY3p4TmlFSis2VjlmcnhGR01K?= =?utf-8?B?bXEwUEVmOVJ5cCs2MFZNU0xMT01mdXA1M2dhV3Z0Qm9KaXJjL2dZTWRpM0o4?= =?utf-8?B?RG0vWTlKcHNtbVpDS1NjdW8rTVozTEFubXQ0bUlnUHRqV3o5cC9xNE9rZ1Qy?= =?utf-8?B?SzdHcmJpM3pDUkx6bEJHYkMxY2FBejl4MUpKL2l2dlBRZ1FQTkVmSkZkTm14?= =?utf-8?B?aTcxalFJVlUxczhsdXhaZzQ3bGlNcFovbUk5cnpDSmlncmJMWEZQTGlCeWdE?= =?utf-8?B?YTF3OEp4Ym9EQzlKVnVwS1YzbnZvUE9YZnJQclpMTEtWMTIyWUoxaHY1TXlM?= =?utf-8?B?emFmcWtyV2VadHlPQjQ5cnB4K0xLNHlHOWZwWlpTNVRpcDFaWktUZ0cyVmtZ?= =?utf-8?B?NGF1Slhtemd3V1FJN25PU2JLZmFGY0JvOE41UUtxNkdsNEVva1BsUTRaQkRl?= =?utf-8?B?ZmFhL1hhbk12UlZmZWd0aXlmVmQySHVQRW9nUmgyMC9LSXF6NUU2UjhHUzlr?= =?utf-8?B?RjBoamZObzdyZEhCRDJWNVhkRllOUUtiQmdDVkNjMkY4dllIVjhDVzU3QzlQ?= =?utf-8?B?cnMvR3kyUVdhVkI2MHd0bDBFaGpXS3ZFajJ0ekpRYzd1aUZwTnYydWkyRlpZ?= =?utf-8?B?LytyN0pVbkFJQ3ZYSXhycnhqd1QxNHI0ZDRYeEE3N3pBTWdWZTBDWDBxTk1X?= =?utf-8?B?dThQMzFvVEJzcERpS0hPSDlJS2tpb1JiYnZ1eGcweVhON1pDenZaQT09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10551915-220b-4a76-69a3-08da38188082 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 15:18:31.2122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VV66+oJhzHKl+qmOhuQwISkbMrWnCZU2gPpNvPi2H0O30YqTvie9cpI0XvotrzQWbUneFU/MD426R8xBkGfNHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3162 T24gMTAuMDUuMjAyMiAxMjoxNSwgTGluIExpdSB3cm90ZToNCj4+IC0tLSBhL3Rvb2xzL2xpYnMv Z3Vlc3QveGdfZG9tX2RlY29tcHJlc3NfdW5zYWZlX3pzdGQuYw0KPj4gKysrIGIvdG9vbHMvbGli cy9ndWVzdC94Z19kb21fZGVjb21wcmVzc191bnNhZmVfenN0ZC5jDQo+PiBAQCAtMzEsNyArMzEs NiBAQCB0eXBlZGVmIHVpbnQ2NF90IF9fYmU2NDsNCj4+ICANCj4+ICNkZWZpbmUgX19CWVRFT1JE RVJfSEFTX1U2NF9fDQo+PiAgI2RlZmluZSBfX1RZUEVTX0hfXyAvKiB4ZW4vdHlwZXMuaCBndWFy ZCAqLyAtI2luY2x1ZGUgDQo+PiAiLi4vLi4veGVuL2luY2x1ZGUveGVuL2J5dGVvcmRlci9saXR0 bGVfZW5kaWFuLmgiDQo+PiAgI2RlZmluZSBfX0FTTV9VTkFMSUdORURfSF9fIC8qIGFzbS91bmFs aWduZWQuaCBndWFyZCAqLyAgI2luY2x1ZGUgDQo+PiAiLi4vLi4veGVuL2luY2x1ZGUveGVuL3Vu YWxpZ25lZC5oIg0KPj4gICNpbmNsdWRlICIuLi8uLi94ZW4vaW5jbHVkZS94ZW4veHhoYXNoLmgi DQoNCj4gRG9lc24ndCB0aGlzIG5lZWQgdG8gY29tZSBhaGVhZCBvZiB3aGF0IGlzIG5vdyBwYXRj aCA1Pw0KDQo+IEphbg0KVGhhbmtzIGZvciB0aGUgZmVlZGJhY2ssDQpJIGFtIHByZXBhcmluZyBh IG5ldyBwYXRjaCBzZXJpZXMgZm9yIHRoaXMuIA0K From xen-devel-bounces@lists.xenproject.org Tue May 17 15:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331065.554514 (Exim 4.92) (envelope-from ) id 1nqyzf-0002i2-35; Tue, 17 May 2022 15:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331065.554514; Tue, 17 May 2022 15:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyze-0002hv-WD; Tue, 17 May 2022 15:20:15 +0000 Received: by outflank-mailman (input) for mailman id 331065; Tue, 17 May 2022 15:20:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqyzc-0002hl-QB for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:20:13 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d5b88e2b-d5f4-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:20:08 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqyyz-008b70-84; Tue, 17 May 2022 17:19:33 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5b88e2b-d5f4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wF3LghB7qFMkIN+RAhS0nW2784Fxel03VlqG6SoZfk8=; b=giQ6MXmBG17+JbZaHvCpLgBjCU FwsDXgX/b02O0QP8I+vkUwgy5+Lo+D5E+EJOGL5/JJvM2lmeYDRT6QF5s/JgDpbjXa08hzTZAOCcp H5UDG57PmVcXgDQ83UJ5J0cHOAPIvQgCaZLx9/QPzE06aTWYPlZURlCiNkAkSPoI1FmBlizReQXpJ dIElRXTKibRc33b/9HZXXl+Wf0mzN1goXhA+a9ZGenrB/fdH27xO8ledb2joDR0cLh2vGAmqvotM+ JR0bWUJ+tmRYLx16LGJtXMspUiQTF3daEYzd/24Q2VypEyjqgtCV1aoMRt2LQ9YZpXkratOMOe37t 53QKNYiQ==; Message-ID: Date: Tue, 17 May 2022 12:19:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 14/30] panic: Properly identify the panic event to the notifiers' callbacks Content-Language: en-US To: Petr Mladek Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-15-gpiccoli@igalia.com> <244a412c-4589-28d1-bb77-d3648d4f0b12@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 10:11, Petr Mladek wrote: > [...] >> You mentioned 2 cases: >> >> (a) Same notifier_list used in different situations; >> >> (b) Same *notifier callback* used in different lists; >> >> Mine is case (b), right? Can you show me an example of case (a)? > > There are many examples of case (a): > > [... snip ...] > These all call the same list/chain in different situations. > The situation is distinguished by @val. > > >> You can see in the following patches (or grep the kernel) that people are using >> this identification parameter to determine which kind of OOPS trigger >> the callback to condition the execution of the function to specific >> cases. > > Could you please show me some existing code for case (b)? > I am not able to find any except in your patches. > Hi Petr, thanks for the examples - I agree with you. In the end, seems I'm kind of abusing the API. This id is used to distinguish different situations in which the callback is called, but in the same "realm"/notifier list. In my case I have different list calling the same callback and (ab-)using the id to make distinction. I can rework the patches using pointer comparison, it's fine =) So, I'll drop this patch in V2. > Anyway, the solution in 16th patch is bad, definitely. > hv_die_panic_notify_crash() uses "val" to disinguish > both: > > + "panic_notifier_list" vs "die_chain" > + die_val when callen via "die_chain" > > The API around "die_chain" API is not aware of enum panic_notifier_val > and the API using "panic_notifier_list" is not aware of enum die_val. > As I said, it is mixing apples and oranges and it is error prone. > OK, I'll re-work that patch - there's more there to be changed, that one is complex heheh Cheers! From xen-devel-bounces@lists.xenproject.org Tue May 17 15:26:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331074.554526 (Exim 4.92) (envelope-from ) id 1nqz5w-0003QR-Pr; Tue, 17 May 2022 15:26:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331074.554526; Tue, 17 May 2022 15:26:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz5w-0003QK-Mp; Tue, 17 May 2022 15:26:44 +0000 Received: by outflank-mailman (input) for mailman id 331074; Tue, 17 May 2022 15:26:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz5u-0003Py-VL for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:26:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c002d3fe-d5f5-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:26:40 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-xoXyJbO0PkOGVsHxV7P8xw-1; Tue, 17 May 2022 17:26:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5718.eurprd04.prod.outlook.com (2603:10a6:20b:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 15:26:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c002d3fe-d5f5-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652801201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aH52qvXXN5YTGjIwtY744UTRvU9n6hEBE1IzHDvgSFo=; b=GyLDtU1A4XZWIi7BSa050HTP1+DzY0nlpcl32fOkqgZCSz/s/XP6PPbR1vdGKZewkOWhXK cqyBoH064cLAkDdLWvAuNBKYnsoe+0PJFCJtr1ymOHyW7k1Q9Y8gr/fQ7K8rQxJKnS+gf0 ROxDMDDdJK5SlhTjT7y/xtRWRulTgXA= X-MC-Unique: xoXyJbO0PkOGVsHxV7P8xw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XU5bxTFUAVpwTrZai3+Jysv6PMM7da6bnkGbEOB1Kj0yq6tj8cgpDPkMuhOYjinkdq6zOZLFFu0oAnIpwmU12I/FxHtY0lOTBie+wvgic+dyXBuLVMuSVWAhBuLdP4prixl4OLDnoh0pKOqPi/G+2LwPHmR1vK1gitjnv97mrfGg1p5ez/gSzdS5z9r/mQ7LFViCWwDIHbZUYfx6qIhY1P6rxfcpbxAcFb7FqOcMtA+oIrVqG2NTxiaq0EjmCV6X/a1I0LVIqCbgJj1Xw3DxqbYdvndGTVOv5YTCNTDyo/+Dav6ZYj3U0vB6VkKmAqLrWtFmBe8XT//4C4yCKgSdpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FQPxw2X8clt9ZJcUCXuYBwQnUkn9l4P8LBShBTotZY=; b=KLyXXtEQCiUrKfG4deL/fdoUWg1dCibDxyIpcdqukXosW08pAbA0r6ouLRa2wV5rrHvx+Lxj9gvWQu/aHQyqgVJV2inSgsVce36e3oEfWZWk0ipExFZEvWSjEgCgc72yuxj7jvkHl0WSs4IqfSs4efa5/7N4dfJR1HyjnRGLnXmES6YGODnNe1mPnBxOqaKv+bVZpmMWbBBXpsfuU8n4TPbzUw5IzFskjPW/yE4BI9evFMStQzwuX9Nphp81VWdV6PD/gA3HUOKD5MBIb06SkTsLT21zStxG0b/a43WLyhoFbmxE8PtKp7+yZiEUEeKkbU2o2NcMFn7RKrThlmpFTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5e4d505c-a02c-eb54-8299-b1078943a8a5@suse.com> Date: Tue, 17 May 2022 17:26:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Process for cherry-picking patches from other projects Content-Language: en-US To: George Dunlap CC: xen-devel , Juergen Gross , Roger Pau Monne , Andrew Cooper , Bertrand Marquis , Julien Grall , Stefano Stabellini References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> From: Jan Beulich In-Reply-To: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f0e7607-9ee6-40a1-c894-08da3819a1b3 X-MS-TrafficTypeDiagnostic: AM6PR04MB5718:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fw1Ux59YbupVs5FOlQJV+pTup2TOOWzuP6j0Mx2lWMo3WW2jfllH5Pk/76QSestcQnujac/5jGNWwDQhJy/xuSqj21HNuzsOvikFNDjYOHJO0CCwR2pU8nZR7Nt2GAP7QkrfIAcheio8vMAdCUK/E41UGt6YSSK1qVmeVX5Smc+QJ2iOIpWCEdCa1Z18RRdxPJZL+1OjpTPYyLGIlppNisDoEe/y6g1bU378OkHSwEWsTNeAQ+hlHudn6ejyXR3jow96wPUA4VnXT3yKO+7yi+281AVX5nxnWiI2w8GMfcSblcvM5Ke3RRRGzS7AGGpuVHbxrmhD/OR8n+clMVY9sXn+YGyXBTybF4AvhS7GRpYPbBlM7MW8uf2O/P3ajq62d3GcSGm4BCPiRhWru0HMSzA1oxPM3BCO16QQ8Bdj+/bW16RjUHEca9XrDoJX5c1innvEbP0c6Ag8w5ZEW6m8lqiLQe0E0+m+LaiN48RZFpvUwRVvrHaVGsgeHotL8yPJDMYbdN+MvRD2ay7M6M7c+X4TrwC2t7ap3OL0y7f61jyQ4fGpKvcgIS1mhn7kM8Vq2DcnGp5tJYIs8PRnnIPwsgxDx8zFx9XVGlcS06r2Jic2URX2stWRmtSCfsM37D/GDOrZGMLpPJ+8H1e9OcCeiGTEo9aYZlf90++8HDzWCKwPnW6h54MLcBwPRxvr8O7LH0Lqheg1rItmoXqG6pfzDCQwm1G2g63hKVw2WWqayjwKEqb/qF+5Rk+naBbs9caP7ToBVVQMSFXKIhxJDCS2xnHfP2Ad+2syYaGoK/umG830xCzIrDiMWJVPdhX/2srhnT+a2l3p6lYVdh8Vfnt5cA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(66476007)(2616005)(66556008)(66946007)(84970400001)(2906002)(36756003)(38100700002)(508600001)(6666004)(83380400001)(54906003)(86362001)(4326008)(8676002)(31696002)(6486002)(6506007)(26005)(5660300002)(6512007)(53546011)(316002)(8936002)(6916009)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6orexGbEfpi/spN0E7a6ZOJEeEhqcO1IZ64AsxXZrJK/s4JSDhh5TzDQj0f7?= =?us-ascii?Q?N7W2meFtmxH9czrb3Ni5vCepwwnU14UA+JXL+33d0hXV4tQ3OzIpNfur/Iz4?= =?us-ascii?Q?86/UFti9naK8E5GO2ptvfe6z+o8BEyZtOD/+Ld8QYUaAxdDyP/2uXOXos7hy?= =?us-ascii?Q?aH+BgWMTIAwYKe5QZh52iMNsqJj8soVKNlx/7JWgLkgnW5umBaIeDkA+zVP5?= =?us-ascii?Q?eclEJ1qGGHCgllKpa+bGm+WaGHs3wWJm3X+qVBEB2Oq8UW0wqEm0q2dUhAFZ?= =?us-ascii?Q?wD/j6qXSG6ORNvKxx1eAsnmlepfTl64cqwQTPoLshhVj/AF3CzVwEQ6WIlC1?= =?us-ascii?Q?b/j0DZzC/V8DMF+SKDx2eWIKNoijqZlJyABnSKKFenTfDG1hgVCfxZj8eliB?= =?us-ascii?Q?G8u0QM7M6HbAf0TkLb2mm0n23VrcF3q6W1ZaUioAn1LhxCjB86bFA9VTFbU1?= =?us-ascii?Q?aEUJRF1kUpJLJq32J+OJIvMphI+dI7EkvIAuvtDITsipA47ohk4T6JLn+udA?= =?us-ascii?Q?tMtifg0ObL0/A0JcYGepS9PxNzT5842/MYAAhwmV1ujE9X+gG/JczSBPvQal?= =?us-ascii?Q?AZl2ox+2oACsZRyPxYkJMmfyKKfPGQdkXiKFzE9IRBuefv8Xj3C+fyxr9FWV?= =?us-ascii?Q?CM/4PsTPBkq009WIu/iZberHSVR7ofyCvZeg4iVctHXlEwvsoTfay4HyR610?= =?us-ascii?Q?rgd5PD2n7dMQ3J40JJrGVxLguRx7y2lIed1nTojuzcJuw/TJWd0UiyXBrKZG?= =?us-ascii?Q?ss+mpDwKrhNcxwRvyV9OnC+b1H/fJ1hxljdp0gFz8+uUvxxBCKZX0sIjiefl?= =?us-ascii?Q?7khlD/SU9dLmO04r0MOyemB2loNuxRHbpE3pB/Z/Caxh2qgr9dX7AoqzxQeG?= =?us-ascii?Q?n7kIMlpjfC2ci5ZNiMrHao5jtEackQT067rGuc1ISgvMzPWbNPYMPYwm2WiC?= =?us-ascii?Q?+WprUjWOMBgMTRND0CTGoGE/yRQYZ4QxxvpoCT5BRWvQuwZI/qbag4G3/0UR?= =?us-ascii?Q?IqQAupjVu157TUMuigFZR9eTeb3CmB2e5Y9gSc5hRT8dHxXC9ouz1zrsKv5K?= =?us-ascii?Q?qX9ahFD35fPt63Lk6sMAZtmb5fWE4Xv027VQEwj7LgPpTJECoOapmY8wEFPw?= =?us-ascii?Q?mYK/JJhjGuKRKXBIVwULpD8AM+q/8HXaS4OhAKEk1OCXbrIuVgBhPCAc4Tni?= =?us-ascii?Q?IAR1pI42gV0wN0sdLwK4iOEQgTGhhi0sGAdnSlipOlJgrvNuVQ+cygl+xYlN?= =?us-ascii?Q?bTvvPoXKyyQ7HIFr+zIxMF+KH4VLA6JgOj5d9mUR5S3xHw+3nDnS4zd3nv9U?= =?us-ascii?Q?+onE+gGyQQ7QPZpZ2RopuRul5cn8/4kSliixEqLusOhIENkkba+Myo7PXZcY?= =?us-ascii?Q?Sx6nr+0Y6z1BsoK5lQxNIAPEf9kLxZ79KuzCo2sRYTcJq7sNyikCINaQ4d5K?= =?us-ascii?Q?NZDhKZE2AsfDqmZARRYqh+SSPRq6FT3aNNxQ8PlebGBdtPgwJUzeUwsEMx1v?= =?us-ascii?Q?pg3SbpGL8UfowOBn50UAGzTo/4+AL/NaSiF/My6WzePCPpMu4vJ83wi8RWj4?= =?us-ascii?Q?UO6dqbeu1rttqGMZTWvQujnuOTvXdMaTSICknPfN5UDJqHaHPG/2i1DNqQhY?= =?us-ascii?Q?dQCRFzfkxA7hBJAqD+/VxZduh8bqdDZM5dEPl7M+zsJ5Jd6bKwIgyNEIMk5Q?= =?us-ascii?Q?i3LBhp+wLTh6xOmy4bypTe1UHvPLu6Abnjz1Jwe9wX4zJWMi9vhZ5S5A1Ybs?= =?us-ascii?Q?1ryE5buaQg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f0e7607-9ee6-40a1-c894-08da3819a1b3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:26:36.6004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rw+GxM171bc54o/Rka3mR77LlP/P3vE1QJCYMBWJj/vRElwPuTEvzgoS5dPcj6eBJZwuuMiHPlT9N5d1mvP2vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5718 On 13.05.2022 16:33, George Dunlap wrote: > Starting a new thread to make it clear that we=E2=80=99re discussing a wi= der policy here. >=20 > This question is aimed at Jan and Andy in particular, as I think they=E2= =80=99ve probably done the most of this; so I=E2=80=99m looking to them to = find out what our =E2=80=9Cstandard practice=E2=80=9D is. >=20 > There have recently been some patches that Bertrand has submitted which p= ull in code from Linux ("[PATCH 1/3] xen/arm: Sync sysregs and cpuinfo with= Linux 5.18-rc3=E2=80=9D), which has caused a discussion between him, Julie= n, and Stefano about the proper way to do such patches. >=20 > The =E2=80=9COrigin:=E2=80=9D tag section of xen.git/docs/process/sending= -patches.pandoc suggests that there are some standards, but doesn=E2=80=99t= spell them out. >=20 > The questions seem to be: >=20 > 1) When doing this kind of update, is it permissible to send a single pat= ch which =E2=80=9Cbatches=E2=80=9D several upstream commits together, or sh= ould each patch be backported individually? >=20 > 2) If =E2=80=9Cbatches=E2=80=9D are permissible, when? When would indivi= dual patches be preferred? >=20 > 3) For =E2=80=9Cbatch updates=E2=80=9D, what tags are necessary? Do we n= eed to note the changesets of all the commits, and if so, do we need multip= le =E2=80=9COrigin=E2=80=9D tags? Do we need to include anything from the = original commits =E2=80=94 commit messages? Signed-off-by=E2=80=99s? Having seen the various other replies, I'd like to support all views along the lines of "it depends". I don't think we have formal rules applicable all over our code base. One model might be used in one place (and then preferably that model would be followed there), while another model might make more sense in a 2nd case. > And a related question: >=20 > 4) When importing an entire file from an upstream like Linux, what tags d= o we need? >=20 > My recollection is that we often to a =E2=80=9Caccumulated patch=E2=80=9D= to update, say, the Kconfig tooling; so it seems like the answer to this i= s sometimes =E2=80=9Cyes=E2=80=9D. >=20 > It seems to me that in a case where you=E2=80=99re importing a handful of= patches =E2=80=94 say 5-10 =E2=80=94 that importing them one-by-one might = be preferred; but in this case, since the submission was already made as a = batch, I=E2=80=99d accept having it as a batch. >=20 > I think if I were writing this patch, I=E2=80=99d make a separate =E2=80= =9COrigin=E2=80=9D tag for each commit. >=20 > I wouldn=E2=80=99t include the upstream commit messages or S-o-b=E2=80=99= s; I would write my own commit message summarizing why I=E2=80=99m importin= g the commits, then have the =E2=80=98origin=E2=80=99 tags, then my own S-o= -b to indicate that I am attesting that it comes from an open-source projec= t (and for whatever copyright can be asserted on the commit message and the= patch as a collection). >=20 > And for #4, I would do something similar: I would write my own commit mes= sage describing what the file is for and why we=E2=80=99re importing it; ha= ve the Origin tag point to the commit at the point I took the file; and my = own S-o-b. Hmm. The present rules written down in docs/process/sending-patches.pandoc are a result of me having been accused of unduly stripping S-o-b (and maybe a few other) tags. If that was for a real reason (and not just because of someone's taste), how could it ever be okay to remove S-o-b? (Personally I agree with what you propose, it just doesn't line up with that discussion we had not all that long ago.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:27:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331082.554537 (Exim 4.92) (envelope-from ) id 1nqz6q-0003xd-3l; Tue, 17 May 2022 15:27:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331082.554537; Tue, 17 May 2022 15:27:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz6q-0003xW-13; Tue, 17 May 2022 15:27:40 +0000 Received: by outflank-mailman (input) for mailman id 331082; Tue, 17 May 2022 15:27:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz6p-0003xF-2c; Tue, 17 May 2022 15:27:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz6p-0006SP-0r; Tue, 17 May 2022 15:27:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqz6o-0005sN-MJ; Tue, 17 May 2022 15:27:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqz6o-0003yq-Lq; Tue, 17 May 2022 15:27:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9r4NoW0nAAV45J9ARsqZ1uqABNIgSkurkW8WHFa1cpM=; b=hguc0MmnaRL+E6Yzg+FhwhT20R BxNcFOkA4ZOZW4nurDwc0sT4s1OMTNKwrkWkT9S+g9tzu3JrieaX2m5ER5v0MdjgH+mEmX3tZmcUX /y3u4WTOJhkByarjGgxd6qzOQQb4PQLiel09QNWLDzhae2fbNXVo/MdgLHawjlI4KsmI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170509: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 15:27:38 +0000 flight 170509 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170509/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1063 attempts Testing same since 170392 2022-05-13 15:40:22 Z 3 days 82 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 15:31:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:31:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331092.554548 (Exim 4.92) (envelope-from ) id 1nqzAl-0005Pv-Mp; Tue, 17 May 2022 15:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331092.554548; Tue, 17 May 2022 15:31:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAl-0005Po-Ia; Tue, 17 May 2022 15:31:43 +0000 Received: by outflank-mailman (input) for mailman id 331092; Tue, 17 May 2022 15:31:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAk-0005PP-BB for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:31:42 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 714a1909-d5f6-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:31:40 +0200 (CEST) Received: from mail-dm6nam08lp2049.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:31:37 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4662.namprd03.prod.outlook.com (2603:10b6:a03:138::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:31:33 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:31:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 714a1909-d5f6-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652801500; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=2CyyoyhSD+yVidyX9h0T5vWbSWRgRP0appvq5+iBRBg=; b=f0G6XxX2IJ9mgU4TEUBvH+7WFnp3VlpRDUhoGqbuIQ6IAlEQ/V262q+r pAkEXqE4MbvZZH+Tyv83m5ogfNVgwuAVdPsuhnW6fF02iR4uel/e1mlqQ lMrJ/wafWKVxkEaQKxQHdYQNcxQnibKeAPbAwClR/d4VFzYPoUDp+/1/u w=; X-IronPort-RemoteIP: 104.47.73.49 X-IronPort-MID: 71507169 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yjPMCaxqkBqjpDV414x6t+cUxyrEfRIJ4+MujC+fZmUNrF6WrkVSz mQcCjrQOq3bY2D1Kdx0PNi/9ENXuZGDm4RlS1dprCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12IfhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npljq7rV0QiGp/2pssabAZIMwFDHpN09+qSSZS/mZT7I0zuVVLJm6krIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtacGOOWtLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamLmUH8QzEzUYxy2X4nC5fgInpDMv2X8WOa8pux2Xbh G2TqgwVBTlfbrRz0wGt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7gEOjX9NUK 2QP5zEj66M18SSDUd3VTxC+5nmesXY0e9dWCfx81wiLxYLd+QPfDW8BJhZKb9kjqck3WS1s0 1aPltzkHxR/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRr3hbXFI4/Qeiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAtTA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:UKBclqhmB/d0izJVHGsfSpKlKHBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVoMkmsjqKdgLNhdYtKOTOLhILGFvAH0WKP+Vzd8mjFh5dgPM RbAuND4b/LfD9HZK/BiWHWferIguP3lpxA7t2urEuFODsaDp2ImD0JaDpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlMawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbonthrcZrau5R+7f63+4kowwbX+0aVjUNaKv6/VQUO0a+SAZAR4Z vxSlkbToFOAjjqDxuISFPWqnTdOXAVmjXfIBaj8AfeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGT9dQnGlq31vitR5z6JSLsZ4J4upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyBS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHNRALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDZRHXJ9upApH 3saiIniYdpQTOQNSSn5uw7zizw X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71507169" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXecJZR8Snp21bqLVmZ/cAE3Iya0fbseCCkTH0jlsQ4XdFQL6gceg5HFtI4V3saq6bS2GJptf/ZTgCjGDzmZs72Hut93IIRCQIO2aRoAguwcXqscLrbdWRLsg6Z6orYItX5tQNSjnYa87eS0lKmMK3QUvpdo2gWZy7/xdoOgew8oamyr12cCwICs+eiAB2IabofYyIR+ND/UZ0dyvo+DXGagBQ6YkCXrBYIICWuNmCzdEsvyt8KYsE3u4o6h1pOGpozWn57I5MpXuJIxdpg8D/Le8hvcpG3OJvRbORiJn3d2lM6PVY2GqV369GqJjlLqZgv/VS9S2SWBxDbMiAjiMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RE8NR3CZplIH9Ch+tl7XBiIwHDlPpz9VsoHnquiTqD8=; b=QvCMtlpj7oLF04ibalXHO9+hk7zHwg2x2PZ5gs3+uApUp5bclJBjRWr2gzzmK2l1+332/cQplWrMvKupa6fynXcvOj6n/Y2+ewOG3/2CWVf0Tp/DRArwtVQR4n44Tkm0f4A/R+vmBEiaNUaX7TeDZEVnvvvifYvW4PVAM/yswd7w0sAz5Rri0J73FXRAw/tpxVxwLXp8TIlfTodTCe30j1/dOvr/gikIv6xOnhrBTDrJ1zRJNGQLFd8UrZlbdhqn+OJtl5w/dFGf1y85O7SarrDJHvntpVMbUR4nvxn263MCgPimqFwR4rQyXFl0AztoZj/05Kb4EZJ23lIUCkYWeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RE8NR3CZplIH9Ch+tl7XBiIwHDlPpz9VsoHnquiTqD8=; b=BGkRtxGuTHjuZlcGnHLLs2PowEC6Fzm4wKqkU5kS0B5Vup+45AFUDKZHobDnKnztFHm8tij4/KyUko/Oa4abXZXPgC1Qdj1TdDdG9uw4uPS5XH2BYPj8pQt4XGhteQU0sApkm8Cn9s2+TXy+S1rx1IjqzxuYRou8ocYb9e1kNgs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Henry Wang , Community Manager Subject: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Date: Tue, 17 May 2022 17:31:24 +0200 Message-Id: <20220517153127.40276-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0031.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f273945-1aff-4d72-7903-08da381a5292 X-MS-TrafficTypeDiagnostic: BYAPR03MB4662:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEz5QK8WFDm1orXtyFl07QQvhnechFwUzcw1BYWB6eNEBSyj8wZ3t9Xgy4P6s45Xcu93c3bg2YT4zMMbzvcqXWIb773XHFnDyhYovT6MUAquu6n2CU4yL1UVmrcz41xswwFAse+2EHBoXSSmDMGF8HxaBNaS6nwd5JkRBmJ98iCTW3ImNR2ZEC5wdIZ2/SDfPpCO6f0y62yukCsuQVkC9b/uAsUbUT6kzQmdyqRJ/bpc5ubepyTtqrRFE7FMI/4K5u6cBcQr467xhErhlf3EyUjVBSYgw21H1js+issIeAX4Skkq7vL3ReJKRTaRVqapEgJh5q2akD/n5ERFcoJfFPhvknFZuGrvUKy9wxBKodnk2Aw2qqhLEcZ+2R6fOE1s/Qvt3xaD0WGJTBQfdXbZf8BJCI5K/fzv3UTtS3B7NFQhAe9R3YI7hmEbpSIu2TGO0uboRPlQ4XC/SI4VQfQWXxPBBzqTanXsPPKLNUdcQo9DgGkMQNMaggZMUlwWXXrz7nRlTYhRWcpP5kXxvqxdhNGeHmTjdV1dN6X+qxhUwoUdJHvkIWyB8fnbb3ZzxWnVKomR7xtxssBByb3lHPHbiu9BXTaVJQAN+WgxIR0XfJgSmSPSlhUSKP9xzn2YqWRtMxMwensHTlK3olRBLCZdsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(186003)(82960400001)(1076003)(508600001)(54906003)(6916009)(6486002)(26005)(6512007)(2906002)(66946007)(66476007)(8676002)(4326008)(66556008)(6666004)(2616005)(5660300002)(8936002)(83380400001)(316002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1I0K3JnZjFOdUMvUUk2S1Yyb040UUt2c2tRTXM3OWJaS2JZODVIeDBSRHdI?= =?utf-8?B?K3RjM2ptT0lSMGl4eWFURzdPTFhOYVNDSkFpMDhYaGZ2cC9NZU10am0ydGlT?= =?utf-8?B?M3hkeDFBczM1RUlUbnAzdndsc1FwNndScUhVbnZSMVVPdGtPeXJlbVdTQ3Jm?= =?utf-8?B?bEFIUkJrc1ZHdjMzVk9La3dMOE9rR2VEVTlkd2lILzhkMm9vSkc1bEF1bUpx?= =?utf-8?B?Y3h5eVBiNUhhVDA2dTJ0aEFYSXY4TkRWamFZd0dKWDRYQy90cnZTUkFQaU1n?= =?utf-8?B?OTNaVE9hcHRpc1ptdFpJMmVqa2ErOXFGZStremNkRTl3cmJEcE5Sa1B2UUVG?= =?utf-8?B?L2pIeXQvUjR6MUR4a1loTEM1dnBaZ1VWZklWak03RUg0ZjR6UnZLUWdIKzlz?= =?utf-8?B?WDFOdkNhZCtrS1BkVkJnRTJWSmh5bkt3d3hOVXNkb1VUdklaODlCZ0hRU25S?= =?utf-8?B?K3lXaGNpdjVVVk1iU0taQ3p5djNXZmJCS1h5cDRNTC9BMTVUc3hDSmZwelov?= =?utf-8?B?WGV3c1NTaTV4c2tyUFVmTG9lNXhXSzN1aTYvZk9tRisyRURnRC9hNEdqeHN3?= =?utf-8?B?dzRuQUkxUWQ0U3doMFRhaG1Bdk1mVzlrL1VHQXBOOG0ySFhuV0FuNENncTF6?= =?utf-8?B?SG9aS1htTnJJbGkrY3VNWWxkcUtpdE1EME0rVGxqYk5qVUV6cXZlSGJ2QW9Q?= =?utf-8?B?K2RuQUJZSXBrTGE5bUYxYkdxRFhEZytlS01LNXdNUEtOcjMyRE5STWtvNnox?= =?utf-8?B?UnV1TnlKV1FBVm14MWY0cXJkT0RTSzI2bWpJRGVCclE5Vy9jcStIdDNKY3lo?= =?utf-8?B?ME5qREZ3UTJub1JKSEZGVUtkNFVPdVJ5QU9vTzBNOUdIOU1aVHBqQWd5QlBy?= =?utf-8?B?ckRkenZDQUdIN29RSjZzK1ZSSU0waG4rbjRrTW9uQ1dJanBXTDZpZWlQa1A3?= =?utf-8?B?czdLbGY2TE4xU0dzaHUvK01rU1lnalRoeU1GZStXbjVkOTdLQU1GNXZ0c20w?= =?utf-8?B?a3BkSDNacWJhNTFma1dVbDBid1lTaWJZbWZYZ2JBZVp6K2NscG9DdWpmMURR?= =?utf-8?B?THlOMDBRNzdpZGhBdzJkV1FjbXFrV1VHaHF4QTJSOW9yZ29sNEhwVjFaaVBI?= =?utf-8?B?K1MvNDhQeC8weTlDLzliM2llOHhnbjd1eU1Lb3NoZ0V4QnJodFdTdldtSTBE?= =?utf-8?B?MVJXNG9NUjQ0Z0tQV2xGdEJiNkxlMTMxQmJXNzdGRjhibGRWOTZzcmhJNkVD?= =?utf-8?B?c01ORThwdUFmTU9vcWFFNWNReXY5ZXVSbVZOVDlGZGEwWWx5T2hGWHhQcHlr?= =?utf-8?B?N2F6SHRkUTJUREhCQ1ZTTXIyZHlCRWdMRVd5UUlMMkZNUzlqams5OEJ0TlFi?= =?utf-8?B?WVdGSmZza2p2ZEFOL0wwT09XdmJHT2VHaFdmemJtc2tPVDNTTVhyL3J1ell0?= =?utf-8?B?M044cGRUN1RvQzhObS9lbDJnOHB6TlRkOGU4Q2VZQk5pajU2eWIvK0lMNEdu?= =?utf-8?B?RHhTWlNXU1RUcS9LUzlpWnFBUEZvL3lNbnJIVlg4QTRqNmpBS3RmeHJZMGZY?= =?utf-8?B?elB1N1hNb292WjBrM0R0cXIzdGxjYmxRc1FIS0lYTkNjS2x1MExIcTJBVlRa?= =?utf-8?B?VkRTOGtqTVMvYkcwZFArL0FrVWs5WlgwRHFGUHo4dXVDOExPbTd1dVhJL2NG?= =?utf-8?B?ZVlmZG4wRkt5My9iYjdxQjhXRlBqQVVlSmY2Sk9IOEpBQXVJUUhQV1ovdWNy?= =?utf-8?B?YXlTdDZNb2J0RlJOSkFtN25EL0dLeE5RanJ5eDRNMHBablJOaUNpM2EyQ0h6?= =?utf-8?B?eEVPdWR5cXRENGlxSmNSSm5EYWNZY3BHZWM3Y2RKdVJxdm5LWlVaVlJJRG1P?= =?utf-8?B?aHYzWEpRSVc5T0xnRndObDN6ZFJXR2RocUx2V1FoSkZsU0daMHZMVkFKTW00?= =?utf-8?B?SGwwS05jdWlSR0F3cEpUQU1RY1N0eUVjTHgxNitXcTBYRHh3TGF3ZjNoQzdH?= =?utf-8?B?SGJXNWg1OWF0cVprQXljenVTZXpxTlFMS0pvc3R4SStITjhHdlJjL2dmTSt4?= =?utf-8?B?M1UyMGtWOEhCQzBFZmEzNmtiMHlnN1pZalBQeHNCcXpBZXNzU2lacmF4YmYv?= =?utf-8?B?bWZFamtkQVBmV044S3dhcERYdmszVTBhNkRSSmZJUmFzNzZtY0c0ckZodENw?= =?utf-8?B?d0xwNVZmT1dHODQxOFdJS3l6TFpBUmRoaUs2Z0VnanA0RWpPdHR4RTI5bkVD?= =?utf-8?B?ZFNlY0tZSkdQNGVXdStoc0xxZDNvcUFsVFpVSHBYQzMvWXY3VEtKQThGaU0z?= =?utf-8?B?ZzJkR0lINkxETVFWQ1dOK2lPT0VrTU5GNGh5TXJZUWtGc3BWSHhJWUkyRERt?= =?utf-8?Q?y6jup8X5LgrkrUHY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f273945-1aff-4d72-7903-08da381a5292 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:31:33.4170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8iMGimg8I/q8do793OVuppJKR6HrAq45xC5vf7CnEPP5lG4hu0pXfFg7YMu/+l9IfiWmLpceqxjEhuCAfyo/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4662 Hello, The following series implements support for MSR_VIRT_SPEC_CTRL (VIRT_SSBD) on different AMD CPU families. Note that the support is added backwards, starting with the newer CPUs that support MSR_SPEC_CTRL and moving to the older ones either using MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG. Xen is still free to use it's own SSBD setting, as the selection is context switched on vm{entry,exit}. On Zen2 and later, SPEC_CTRL.SSBD should exist and should be used in preference to VIRT_SPEC_CTRL.SSBD. However, for migration compatibility, Xen offers VIRT_SSBD to guests (in the max cpuid policy, not default) implemented in terms of SPEC_CTRL.SSBD. On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to abstract away the model and/or hypervisor specific differences in MSR_LS_CFG/MSR_VIRT_SPEC_CTRL. So the implementation of VIRT_SSBD exposed to HVM guests will use one of the following underlying mechanisms, in the preference order listed below: * SPEC_CTRL.SSBD: patch 1 * VIRT_SPEC_CTRL.SSBD: patch 2. * Non-architectural way using LS_CFG: patch 3. NB: patch 3 introduces some logic in GIF=0 context, such logic has been kept to a minimum due to the special context it's running on. Roger Pau Monne (3): amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD CHANGELOG.md | 3 + xen/arch/x86/cpu/amd.c | 121 +++++++++++++++++--- xen/arch/x86/cpuid.c | 21 ++++ xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/hvm/svm/entry.S | 8 ++ xen/arch/x86/hvm/svm/svm.c | 39 +++++++ xen/arch/x86/include/asm/amd.h | 4 + xen/arch/x86/include/asm/cpufeatures.h | 1 + xen/arch/x86/include/asm/msr.h | 14 +++ xen/arch/x86/msr.c | 26 +++++ xen/arch/x86/spec_ctrl.c | 12 +- xen/include/public/arch-x86/cpufeatureset.h | 2 +- 12 files changed, 233 insertions(+), 19 deletions(-) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 15:31:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331093.554559 (Exim 4.92) (envelope-from ) id 1nqzAp-0005go-5P; Tue, 17 May 2022 15:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331093.554559; Tue, 17 May 2022 15:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAp-0005gh-0z; Tue, 17 May 2022 15:31:47 +0000 Received: by outflank-mailman (input) for mailman id 331093; Tue, 17 May 2022 15:31:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAn-0005fb-AO for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:31:45 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 73b8a127-d5f6-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:31:43 +0200 (CEST) Received: from mail-dm6nam08lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:31:40 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4662.namprd03.prod.outlook.com (2603:10b6:a03:138::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:31:37 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:31:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73b8a127-d5f6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652801503; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=E0WrwYD300/uBgj9TRjUZK4gWeZhaQHIkA6kYkkRO7U=; b=ONNpPHEh+F+1VHnMXr6wHMMkxhyvCMIABXRbeB8ZWmSUe0vcbnUQXzGA 5+Y4YeUXwqCYELZazhEM4vcu2Tyxib/7tDeRq6+qzXl41C/c7/rstbS62 YqJGDnV9lOyS+DSxttcf6VIq8Z7+DSN7exrwjR/fOKFYcbr6clSC2VZ6c o=; X-IronPort-RemoteIP: 104.47.73.42 X-IronPort-MID: 71519856 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0ucnKK74BMT2PetWZHoDAAxRtEzGchMFZxGqfqrLsTDasY5as4F+v jNJCmjSa66JN2rwe4t2ao3g8k8O657cytU2QQpo/i8xHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgXFvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSIdw4wJ6KRvNhaeD8GDw98Z4AfoKLIdC3XXcy7lyUqclPK6tA2UAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfqRo4MCtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGQF8QPF+PRfD2776F1a77z/F+jpJueWROt8zhqHr E3U1jGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRoky0Vs9bK kcU0jEztqV0/0uuJvHiWzWorXjCuQQTM+e8CMU/4QCJj6bRvQCQAzBUSiYbMIB88sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46TsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:rBtvN6+bdvYuyV0kstBuk+FKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsj6KdgLNhRotKOTOLhILGFvAH0WKP+V3d8mjFh5dgPM RbAtdD4aPLfD9HZK/BiWHXcurIguP3iJxA7d2us0uFJjsaDp2IgT0JaTpyRSZNNXR77NcCZd Ohz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlOl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFcxccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiV7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri2knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYds99RrBmcEa+d RVfYHhDK48SyLYU5mZhBgj/DWUZAV8Iv/cKXJy+PB80FBt7QVEJgUjtYkid0w7heMAoql/lp r525tT5cFzp7ctHMRA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71519856" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7HUTINmUzRI39zzwUwcOCfy52++HaaJ+r17RQytoc78NkmlHosH8miHH2RjyKXizDUqTJgVUxYkl9OUn2dvQtA1c+pEzgvqZu3OU1gPWMM0v77fBbhO9AV3FQhr+olDExd3QYQKRue2bo02utswZCgaZal+uTw06bQ6QynTFp/gCv3sneB6zfXTOrNxTdmz6mfgfApTKs+097b2tEebEzx5eJuwlrBqReZ9UxJS3Pq9dpPMuEZXdOdSm4SgptiHxgqu4Pr6HvrUfydBkVhYTrnKEtQvW8UjbOMA5kuJNdb/vo05vvDB7ngRb4CirKLM6nYM68xW4ALU8xq88Za2ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q1YXIq3wwhUERf7uVRHsHYT1E5p+r61LTwXkwzyRWfU=; b=B+NK8Z8YvBGG6x4hYLVJIq0hyTkO+evUDvOcICcWUZzeldzv0hvWKPiJhHe2C7NtwxZ+kplkcoICeKRLwHT/TldbRD4wRCx1wZbzkdWETTAQjyoPEY1tr9XcmwBBUTjCjtvE8LWxH/lZGJxVWv7/lFPi7Iivprl3rN39U2RjCbpRSZnJYiegV/yx4bCVdIVO/AV8YomY3I/g/3DzF785s/lPGVN4rzR0GFdIT/7ZngZzKmqJkkYg7EMepsmINHrWA+1GvMzwear2nIOz9zGO5sLR+FEyEobEOfKVLzcXcKJFTqCb35pQi7qFOzXsZvWac+rwfl/LgWS/t/O2uv+aSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q1YXIq3wwhUERf7uVRHsHYT1E5p+r61LTwXkwzyRWfU=; b=dC6VOu4PIg1vzdLAcegH7nWdDQWNzrnmqAab3EgN5OjdT3LyGzWfq00xjTLHMdUDVuzU6Npb8uLGTKgnHFagn4i8TE9liDKBAlvDcMfwtBmVNNh826EayyU6ls5N3Es9t0TN1N/JCWhuTbLIundWFTfhCDyVxjLxajjq71EBB3M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v6 1/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL Date: Tue, 17 May 2022 17:31:25 +0200 Message-Id: <20220517153127.40276-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220517153127.40276-1-roger.pau@citrix.com> References: <20220517153127.40276-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0077.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31f322d8-2972-4ce7-f783-08da381a5535 X-MS-TrafficTypeDiagnostic: BYAPR03MB4662:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cxrbkII93kiVd3/tnbHXGscxtmm2PpmB0GFSeGVVxyUAnnMLjdDFUQz40TrmjDfCoUCCdiT0et9lzpcnAJwg7nbE79msKyoNKn+wHDwWu/X3aWzQfWK/jHT0yBiKdi7DeC68saB1UTAqHti8p0SUvsMK6nNBziG3e+5ThvSN3OApuuBBP+mtKbhfHHmyQO+WNETJ28D3z1zvrn+25jH1LKN5oeE+u+xpbfceFUnYpnhijCrnhzuvv5BHXsveSdkOoAEo2fgFPppUOET/UqlslPiPVwg3HzUSlBBH6uF1Qsg3fswrz2QcbNlCXCtefv7T/WYLIIv8Mizb2DBF+fpVawmjU4GvHNk94Jc7Wg9qFHc6qFUjd4NoEhT80EkTnIk45ycW1ggA1uLG68bxYxpcrp95CciEuHLCBO6vAfjxqG5wrhJ8PhJKQezwl00F5bZPAzmLHEi2vMc5MncB/1naxtMiQaFTPkWhiunuzln4N9WSqVJ5vkrBDdBkhnFK0Gsc+UgmpF4R3LotMkf2B/4z9GOKSptN/wO+B6nBOW1pUfh0RZq7zT+WZqve/8pO9Som3YxDuVw16M8KfpADo4taXa8+J35nZA0IxlVND/KaVv9j/Myni2JBZ86du9vY3PN0p+hglxQ6hwj4StYOsYGgtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(186003)(82960400001)(1076003)(508600001)(54906003)(6916009)(6486002)(26005)(6512007)(2906002)(66946007)(66476007)(8676002)(4326008)(66556008)(6666004)(2616005)(5660300002)(8936002)(83380400001)(316002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnRhUXNGTmRrN29vWlNpV2h4RUI5TERHQlkyL2FNcFB6L1RiV0ZEd1VaTndo?= =?utf-8?B?R0VLa1RZMzRhYzFsMmlHRVhFRWFQT0NvMFlNMlFBZE9ncXQvcitYUHYrM1ZY?= =?utf-8?B?Mk9Rb2xCalQvM1BDeUlieGJUMkNqR3BzdXhoK3l6M2M2MExaQ1ZlbFpyYURm?= =?utf-8?B?RDMzWDdXUlNKN2o0emVmRW55bWlUMklyQnZlRFR3MHRTQ1l2azhZVEQzM09n?= =?utf-8?B?a05Da3Q5c3AzZG9kL1g5R2FTRmozb0k4Z29DbVlQRDV2d1NjZHh3STZpOGZi?= =?utf-8?B?UTZ3c25vMnlEVzJoRHpzLzkxZWpLNUpibm9BSzZwaVpLQkJ0aFdIb2hpQjBj?= =?utf-8?B?L29NVEZ2Y1VQTzZab2FLWGVDRm5xazhRYlY0OFNNRWRXNVkxZWFWMTA4T3RY?= =?utf-8?B?blhVaFFwTG5lb0FOeTNaUk1BZWwvZzE0WTBaZ2d4Mk9pUjFIbjV6cjNsZTQ4?= =?utf-8?B?VVNFRzdDdUVyNUFYODN6aGFwSGYybXRrczRmSkI0dG9WL1VML0R4WThtQkMr?= =?utf-8?B?RFBDTlJvS0V5WjIvT3psVHNwZkU3UzRITTdWQ1hzY0lKcFA1M3hOTTRzZzI1?= =?utf-8?B?Y0F6MFRlZlpXKzRpem03Nk1XWnlMWlgzS3ZtM0JvQ2RlSW5rWlRoRFBQOEJO?= =?utf-8?B?OUlWNFVoTC9pZFFrdVlWU1RtQUVaaGdVd2lWQk44L0x5OVBuQ0pycEJhY1dj?= =?utf-8?B?UzU1c2sySUtFY3oxdmRlRkp5OEJkMzhKdFFRalp6WVZtcEhlRUJ6c2h4Um9Y?= =?utf-8?B?L3hkSkQ1ZS9mbFcwa2JRL3NFYktQeGpTaTNVanNLWENBVFN3SWtwU085bUk1?= =?utf-8?B?MUNqb3BHNFpiR0dBNkxNNythc2l2dCt0Z25EdmJxUkRJaDNhd05iOGNWd3hi?= =?utf-8?B?c0tlaW4yeTZXZVVlaHJOSHpuNUpBMHR0MkI1dlRQNUlQT1FyTEZKN3pRVmFW?= =?utf-8?B?VkFPemd4cWpKVDRYRUhrUUJiWmxoQnJuVjlqL3VDRHhqdkpFZnFzWVNaV1lZ?= =?utf-8?B?ZDNrVkdsNm5WRlZlWFpNeFRHZE43OHN0cTRWOXQybnlzUDNrZWp6T0VLNzM5?= =?utf-8?B?L0V6bHFXZmlQdkxUOC9yMWh0OXFLV3dBRmVGb0pKdUUzRTZDR1FtelcrN2w4?= =?utf-8?B?N3hzUk9iR1FMQytYMkdkZkI5K3hCOTkvaEhnUnk0Mnh3Njg1c0wrU3pYTVVy?= =?utf-8?B?LzJudmFKR1E3aGt5WG9ybUdRbTdBNU1vTG5kQmtMMGduMVI3bGxuUnh2MVp2?= =?utf-8?B?VVVXc1lRTndwOWZkWHhpTVlwREd6MWk0OFYza1ZPUVFJMDNMZEVvYUtJM0Jr?= =?utf-8?B?NVRrUGFQc0lwR0dOdkJNWXNuUkxQWEp2R1lkMlZwMVM1WStLc0pjUHluRzdD?= =?utf-8?B?dzlQRlZSMUttVjBwSkV4aGg1L0VjNm5wUUUxSWZLMFJjRWoySzllL0JxNmtt?= =?utf-8?B?cWRnMXAyZ210aDdjVlNPK1IwalFPaVRiWjZtOEJ4KzlwWDY2OHJZazl2NGxy?= =?utf-8?B?RG5JT2YrNUt5dFcxRTdxMVVYMkFqQTgwd2wxQnNLaVlNTHdYTzlPaHc3RGw0?= =?utf-8?B?MmRibzIrdkV1YndCN0RQOWVMUXNUQStzNWlrSVdTdmdEK1hwQStzbldmMDFQ?= =?utf-8?B?U2JnSmJxd3diWFF3Tys3ZUdqMElJb0NFWjk3QkhLRC9HZHBFVUdRRjBCUDU2?= =?utf-8?B?cDVXdTVQQzJ5VEVzVW1idlNObTlYTVoyVXdCZThHM1hKbHlWcjl0ZDV1SjRC?= =?utf-8?B?U3d3dWNqUFZ5NGR2QjVyM2FGKzJncEZYN0VmZzBNdURnc0RPM0Zoc2M5cXJV?= =?utf-8?B?L1JOK2FCU0JOTzBBaW1DbzFTS2Q2enh6VGkzWm81ZW9VcWhRT1R5QWRtb2R5?= =?utf-8?B?S3BPZGE4OWZUQzRrSGdmdlorZVoyaGZycnhXMC91WGtIRXJpMkNObTNiekpB?= =?utf-8?B?c3BsVCt0OCthWWxldS9WMzJ1V0pRL2ZXWmhGRXgrdCtkZ3hxOE5Sdi94Q01Z?= =?utf-8?B?WEx2MSt4bndyanBGSkVTR0U2VE15OVY4VW9BUzhqOGhjdm5hZklhZ3FOV3pT?= =?utf-8?B?aUtldFFJQTJjLzFLWStqZDJOMXZJTjJuWG9LT3d5WXhaamNud1M3dWRRbWov?= =?utf-8?B?aE9GbElQTi9LR0l0WlVlYk5iZzNzWWd4MjgwTm9UZk9SK2ZFT0lzdXlKT3l4?= =?utf-8?B?K29Pem9vQVNIQjl3NFFNbXo0NHZqVlpSQmo2bVU1aDBWeEpEYWlrZ0dlYng4?= =?utf-8?B?ZUdrWjQwOWErU041Qk9yVUo5aTN3MW93MUhDNlQwQTFnV1pnWHE1TUdWNkNY?= =?utf-8?B?NDluOStLNE5JSmVtdERxT3JGcllJU1NHaE4zZVRsY2VWbkwyWEszRmpiN1Y3?= =?utf-8?Q?5vHBSxsBnm+PP8CU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31f322d8-2972-4ce7-f783-08da381a5535 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:31:37.7657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTEborTCrfivrne5mPF34Uj1knyvI/bAjsSP7zMZ0c620xWqRth7ZDoKt30ZRKiytGcd0EWHQP+Jkq+rkRyjNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4662 Use the logic to set shadow SPEC_CTRL values in order to implement support for VIRT_SPEC_CTRL (signaled by VIRT_SSBD CPUID flag) for HVM guests. This includes using the spec_ctrl vCPU MSR variable to store the guest set value of VIRT_SPEC_CTRL.SSBD, which will be OR'ed with any SPEC_CTRL values being set by the guest. On hardware having SPEC_CTRL VIRT_SPEC_CTRL will not be offered by default to guests. VIRT_SPEC_CTRL will only be part of the max CPUID policy so it can be enabled for compatibility purposes. Use '!' to annotate the feature in order to express that the presence of the bit is not directly tied to its value in the host policy. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v3: - Use '!' to annotate the feature. Changes since v2: - Reword reasoning for using '!s'. - Trim comment about only setting SSBD bit in spec_ctrl.raw. Changes since v1: - Only expose VIRT_SSBD if AMD_SSBD is available on the host. - Revert change to msr-sc= command line option documentation. - Only set or clear the SSBD bit of spec_ctrl. --- xen/arch/x86/cpuid.c | 7 +++++++ xen/arch/x86/hvm/hvm.c | 1 + xen/arch/x86/include/asm/msr.h | 4 ++++ xen/arch/x86/msr.c | 18 ++++++++++++++++++ xen/arch/x86/spec_ctrl.c | 3 ++- xen/include/public/arch-x86/cpufeatureset.h | 2 +- 6 files changed, 33 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 7e0b395698..979dcf8164 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -550,6 +550,13 @@ static void __init calculate_hvm_max_policy(void) __clear_bit(X86_FEATURE_IBRSB, hvm_featureset); __clear_bit(X86_FEATURE_IBRS, hvm_featureset); } + else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ) + /* + * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed + * and implemented using the former. Expose in the max policy only as + * the preference is for guests to use SPEC_CTRL.SSBD if available. + */ + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); /* * With VT-x, some features are only supported by Xen if dedicated diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5b16fb4cd8..db8f95ef7c 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1334,6 +1334,7 @@ static const uint32_t msrs_to_send[] = { MSR_INTEL_MISC_FEATURES_ENABLES, MSR_IA32_BNDCFGS, MSR_IA32_XSS, + MSR_VIRT_SPEC_CTRL, MSR_AMD64_DR0_ADDRESS_MASK, MSR_AMD64_DR1_ADDRESS_MASK, MSR_AMD64_DR2_ADDRESS_MASK, diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index ce4fe51afe..ab6fbb5051 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -291,6 +291,7 @@ struct vcpu_msrs { /* * 0x00000048 - MSR_SPEC_CTRL + * 0xc001011f - MSR_VIRT_SPEC_CTRL (if X86_FEATURE_AMD_SSBD) * * For PV guests, this holds the guest kernel value. It is accessed on * every entry/exit path. @@ -306,6 +307,9 @@ struct vcpu_msrs * We must clear/restore Xen's value before/after VMRUN to avoid unduly * influencing the guest. In order to support "behind the guest's back" * protections, we load this value (commonly 0) before VMRUN. + * + * Once of such "behind the guest's back" usages is setting SPEC_CTRL.SSBD + * if the guest sets VIRT_SPEC_CTRL.SSBD. */ struct { uint32_t raw; diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 01a15857b7..72c175fd8b 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -381,6 +381,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) ? K8_HWCR_TSC_FREQ_SEL : 0; break; + case MSR_VIRT_SPEC_CTRL: + if ( !cp->extd.virt_ssbd ) + goto gp_fault; + + *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + break; + case MSR_AMD64_DE_CFG: if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ) goto gp_fault; @@ -666,6 +673,17 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) wrmsr_tsc_aux(val); break; + case MSR_VIRT_SPEC_CTRL: + if ( !cp->extd.virt_ssbd ) + goto gp_fault; + + /* Only supports SSBD bit, the rest are ignored. */ + if ( val & SPEC_CTRL_SSBD ) + msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + else + msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + break; + case MSR_AMD64_DE_CFG: /* * OpenBSD 6.7 will panic if writing to DE_CFG triggers a #GP: diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 1408e4c7ab..f338bfe292 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -402,12 +402,13 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) * mitigation support for guests. */ #ifdef CONFIG_HVM - printk(" Support for HVM VMs:%s%s%s%s%s\n", + printk(" Support for HVM VMs:%s%s%s%s%s%s\n", (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_MD_CLEAR) || opt_eager_fpu) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", + boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_VIRT_SPEC_CTRL" : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : ""); diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 9cee4b439e..5aa3c82fc6 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -265,7 +265,7 @@ XEN_CPUFEATURE(IBRS_SAME_MODE, 8*32+19) /*S IBRS provides same-mode protection XEN_CPUFEATURE(NO_LMSL, 8*32+20) /*S EFER.LMSLE no longer supported. */ XEN_CPUFEATURE(AMD_PPIN, 8*32+23) /* Protected Processor Inventory Number */ XEN_CPUFEATURE(AMD_SSBD, 8*32+24) /*S MSR_SPEC_CTRL.SSBD available */ -XEN_CPUFEATURE(VIRT_SSBD, 8*32+25) /* MSR_VIRT_SPEC_CTRL.SSBD */ +XEN_CPUFEATURE(VIRT_SSBD, 8*32+25) /*! MSR_VIRT_SPEC_CTRL.SSBD */ XEN_CPUFEATURE(SSB_NO, 8*32+26) /*A Hardware not vulnerable to SSB */ XEN_CPUFEATURE(PSFD, 8*32+28) /*S MSR_SPEC_CTRL.PSFD */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 15:31:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331094.554570 (Exim 4.92) (envelope-from ) id 1nqzAr-0005yI-Er; Tue, 17 May 2022 15:31:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331094.554570; Tue, 17 May 2022 15:31:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAr-0005yB-B7; Tue, 17 May 2022 15:31:49 +0000 Received: by outflank-mailman (input) for mailman id 331094; Tue, 17 May 2022 15:31:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAp-0005fb-K5 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:31:47 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75c812ec-d5f6-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:31:45 +0200 (CEST) Received: from mail-dm6nam08lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:31:44 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4662.namprd03.prod.outlook.com (2603:10b6:a03:138::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:31:42 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:31:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75c812ec-d5f6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652801505; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=/Pb4PtMbn80iE/cJjzQcmJPSFXHeH+Bckcrs+eHVMPg=; b=MLi1E5fjmFjZC3WWYVs0TY89eLM29YFYxcEzsBuVnCjYdxYt38Wtnl0D lqXucVzEYuvOsImIJs7gfqTdaptQplu5Bd7u7I2MNsPrUvyrz3So92MAC TuYPZqzgDQpg5xfORT+LD3Adlrooza6LwCpnhbCqUEpJEJrhv4XNCKb85 8=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 71519888 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eAaCYq7/m/PZdAMnZ3VTugxRtE3GchMFZxGqfqrLsTDasY5as4F+v mccX2iHPvqKNjP2KdBxOYq+8hgPsMTXyYBnSgJv+y88Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgXFvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSdRjYJY7/Ok9gMSjdzAiB/Ybx86a3IdC3XXcy7lyUqclPK6tA2UAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfqRo4MBtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGQF8QPF9fpfD277kBwr2uTjCefvXIKqXsxJvkWIl 0z+1jGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRoky0Vs9bK kcU0jEztqV0/0uuJvHiWzWorXjCuQQTM+e8CMU/4QCJj6bRvQCQAzBUSiYbMIB/8sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP46eEJpprUZwQ3N/ g0= IronPort-HdrOrdr: A9a23:oK1+jqHE/eUXviSXpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+txKL Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+wLzGomjMlFx9fy7Yr9m bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfhWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdrzXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MF40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIYLH45JlO61GkbKp gvMCmFj8wmMm9yLkqp81WH+ebcEEjaRXy9Mwo/Us/86UkioJk29Tpc+CUlpAZwyHsMceg72w 36CNUZqFg3dL5xUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71519888" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R7/ZcZR3ZZg02XHwTDOJVLVufYN84HYhWhZb7wIbHKec9ZwlWfURDl0YLujOoPdDdUMfR4kGSVAifR+st3QIXTx9KuO7V6krDtuPDLbcwOSrZiUcoZAZxWaagAHk4pGWHZdRnCBZxNQLeJhG6BC8o2LNMeolXasD+QaEwy/vWCN10xc2uRTUXZ/iLpSGCXwPp8Rb3vJs+AB38h3mSnRp2gngQtREIN7CCiGdw5fuHGZIQC43glmGER07beatM3buaHQIDHuH7rK0OMF1g3+JFjKst/Lk/KOCkaVATTaqTMKnH/VjbKk4xY9CgIXfh6ZhZ+BpJKNJUusr7O9ZU+9s5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XxGtLGB+qBMQmowNUxyabNIKT+0uN2seU/MaxvqgRh0=; b=imoxos4EN7rOUJb9BiUkwIkXdZUTRAWTXPWHztwGRzWOV3fDnSJ7guPTk9Qv2TX3c78Z7mbBB3gv/HkGebB4ok6m/E6A2d+6WhQqk30HIcibRONKUid51zT8LVP3qthMIy+42rSoYV86vcJCs9dS0OeSem1lYcizhfyR3RZcf2oTrwaeLjuBFMG9e0YCQXmY1RuRHYkpCaxQMNCh3N1qslYZEGV2FOfsann3rmxNTIUBKfnNfzRrV95cgl6pSemvlK9PgOaHUecel2ODO38x+wpTxVbzsmWnS4PfZY+3wnNuQXA0z+s/eA8HpEIwAadvrvhFH4mDaqNaPF5p8ywagQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XxGtLGB+qBMQmowNUxyabNIKT+0uN2seU/MaxvqgRh0=; b=MbrnFGfTk7Kvxi53z7tsegmrXGRAITRaesh3R0O7SEdLOPUOUBJ50D41neYTt1HUxoPxXXa89nloRz/KEh5i8DQ0stYuidM2iiA1Pqu84vtdjXzKmPYO0hv6GDC0XCdl+Z8Js3tMbd29fEQbVHgtygPO2Cfklqy1dVyREJZp/EI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v6 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Date: Tue, 17 May 2022 17:31:26 +0200 Message-Id: <20220517153127.40276-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220517153127.40276-1-roger.pau@citrix.com> References: <20220517153127.40276-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0374.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 148d567b-bcd2-4a17-4eb4-08da381a582f X-MS-TrafficTypeDiagnostic: BYAPR03MB4662:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UF3XLor2UABqBubKjKbAyhsTKBJe3N+ZvHwPleFbrv034dHicPsMqki7ifKj5ulwczTyQeijvHPiEDey2N11RoJkpQ3IhR3KUw883wj41ZprwINbWo5elVkh4xCVQDxaaWQEuX75jzKYAM7DFw0VJAYq0CInyEOYGNfCPjGdT9HYN/qxirLwJk/EXoALZsTJvRcUCJpnKNugPwb5ECH8zFSVv8M6SFLrf2XrEPoLuSsQKfaTp2MuxuHbRv3c0i5Tl2awv+sWQStzV1AkenN3c1WLerDITlTxFh367LMcaNa9gVVd8bQnD8z6pkhdejAJJvSZaAJSQ6ynDzSS16oCfqoBiXgGUvKWvkxY9CX+jyYG2hP2lJUGyfYmz89NEWHYsUbRdILSjRvp+iwxwuXS6XeVbuzg+2LCwM9EGR3x6JB29cqwuIBqR6kX/0dOGucPRF4sO/0hDQIujunAnTnLzQjCqtGweDHFTBAEEzhSH0EXz9ilfa2ZPHbjNouJU5hHOH/1hQIkypR/mCpeG+zp3vR/EIhQKsnVHe+VtvUV8p8bDvW2EadHrnEQ1t9vn1UZBcv80Q5JaYbV1cwUep9uEeZ40B8gNpnabWTIMzyofKDbzg3SQiFmDmYYJSj2OO7i8EBJmw4sD1aySuUMI+WwJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6506007)(186003)(82960400001)(1076003)(508600001)(54906003)(6916009)(6486002)(26005)(6512007)(2906002)(66946007)(66476007)(8676002)(4326008)(66556008)(6666004)(2616005)(5660300002)(8936002)(83380400001)(316002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGtHbWtFOXA3NHhvRmpwRmlEVGlhcTVUSUZoSm5jdjViMVNhazdaa1M0TGVk?= =?utf-8?B?TlNGUjBVOVVSalJOeGhveWRBRHN0T284VEtkdFNqb0s0czMrd0QreXFkTGNB?= =?utf-8?B?bWtQUE5WSzdoaTB3R2JIZEVxMVZQUXdFNmYwWDVXRG8zaDd4bk5QRUlPTjl0?= =?utf-8?B?RUo4czNtaW1jd0YvWTVjdmpIanRiMFhMbitzTlVLcGJOWTNCS1hBY2w0UGt0?= =?utf-8?B?dkhsWCtWSVpoMXV1b2FHTFBmVzA4cGNjUzkzaERZY3g1VjlhTVVRZ3pKU2pp?= =?utf-8?B?OWhvNlJvOEtvcVd1SnZyYXQwQkJPeXpCOTdBVGJwZFo1UGVpNnozRVE4Q2dh?= =?utf-8?B?OU0zWEsyUHVKWWxUVDcxNGd4UTdVYjV0N2VtckFnRXZsVVRlNzNxVURQN2VS?= =?utf-8?B?akxjQ2FZbXNHMFZpMFduUFpkZ202b3g4UlJNQWhPZWJsRjVQZExVNm96OWJp?= =?utf-8?B?RzJQSUx0MTdRMldqQ1BhQW1FVDc4LzQwZUNUY2UxNzFSbE5IaFNUQzgwVGtu?= =?utf-8?B?dkRxcHJHYWRDRFJqM0k2Y1RnMWhWOWxBZGhDbWhzcmk4Vm9KWGdQMUVpL0pK?= =?utf-8?B?cmhacTFadndmKzdmVDdYS0Y5M2VGM0RXTC9HUWlMSmljRlowM2h4T05DUmxT?= =?utf-8?B?SEdMcjNUbHJZd1Z4dVUraWtVNHFLdFg4M3lnSzZ6b3N6eWZZakVCdDBpQXBV?= =?utf-8?B?NE1KWjNFN2IxcUMxcHNhTzArVCs0bzFWd2RpdGVnVk1Gank5aFd2UC9JczJm?= =?utf-8?B?T2dONzRHRTBzZStIWVNseENuWTJtc3QrcDE3bk9jd3Z1YTl6S1o3eVMxdnhw?= =?utf-8?B?NHBrVE1ZUGp5QU80S1RENFVrOC9ZcTR2UkF2dTVnZ09IRnZ4MEVEMmFTRDZz?= =?utf-8?B?ZUNJUHdGYXEweUZNVzNDYmRoTFN5bkdXeURXUXNLNjJKZS9aeVFaOW9FakZp?= =?utf-8?B?ZFZ4K2dHVUJYT1lFeWxxWWk0c0JvQzBMWlFYU1dNZXo5MEJWTUU0ODFxZ3hX?= =?utf-8?B?N0Y0NEEvTDZXRitDTTVHbWlXZ1p6TnhrcUpMWnpxM29XS1MraWRWQlRUWkNw?= =?utf-8?B?bTNnTzBGSUczcC9HNHA5Qm5yQWl1aTBzWFZGTWUrWEo5Qi9Wdm9PYnNzclF6?= =?utf-8?B?dUhEUW5mYmVUYW5wRmMwekRzdWJ6WWorWjJsM1VJSGtsM2p1cThxQmRrT3Ir?= =?utf-8?B?TkI1ckFUN0hSTERQb1F6Yy9CR1Z2U0xYWHlXUDJPTUlTYnFxL21MbjMyMnB5?= =?utf-8?B?L0Q2SkRKT3I0cVFKOFA1bWVpajlLTWhBbVFRQnpFc2tMK0xialdLYWtoQjgr?= =?utf-8?B?cWYzY1BXRlQ0ZWRlbjJuM0ZFUkJDWk95L2hoRnV5d0t3Q3Bsdmh0NzJydDg0?= =?utf-8?B?NFBXS1J6RUl4NUZoSEYvUXRoVnRoWGxzanFqNWtwdVVuVnZVbmlwMGtKUU5O?= =?utf-8?B?WXJmK0N1SnVxMmRNY1RWOTNRV3gvck01QU5SdE9EUTl3S2c2aTRWRmxrUUx0?= =?utf-8?B?ZnhpTWRBQ1kvYVFZQkV0WS9hSEI5dWdxQUM5YTh2NmtsNk13TnpNbGhBVHFi?= =?utf-8?B?Q3FSclIvVDRmVWhBSERtUzRhUjVTeDhNYVNpMmVFUkRPSlBadEFFYUhFUkQy?= =?utf-8?B?MnVlbFJqQXNVZng2cE0vOW50Yk9GR3BZQXA0UFVWWUtMSDJTSU93RnB2TEZh?= =?utf-8?B?ZlhBR0tXUTBGemJOUDJEZFJQM3FqVmxzV216Tk1iQWFBWFhZMWpTQ2xMRkRO?= =?utf-8?B?aXM5ZmdmdUhYZGxCUkIrUmhkbjRSYTUwc3VFYzRTM0tveDc2ZU5wRWtXQ2Rw?= =?utf-8?B?WnNVa0J3NkdMVjFvT1p1NUk4eUZpNWxvR014M2YvRHZGUzBpbEo2OVQ1ZDdT?= =?utf-8?B?SjhGN2JMeVN3RTkyRTF0R0h0cDZkMU1OQWVnN2IybGZtZjB5TmNoYUhsM2J0?= =?utf-8?B?QjB1QUFhWHlRcEJ1M0RiSzBQZjI3emVSdkcxUmJLMjd0TjM5WkxWemJWeEFM?= =?utf-8?B?QUhqRE0xbzNLc1A2akR3TnI1RzlWOW9QTUlmU3hKMDlxYlpFeTFqMTk3ektL?= =?utf-8?B?OS9mZUF5UEJaNFp2NHhZdW9URFl1aG0xd1pJOUE5dHRyM01YaFl4M1JWRzl0?= =?utf-8?B?dVd1aENGSHR6WEJ4dU92MzJ2WjVZcllHSUhvRXFhendxME9maFZlZ1N3QS9L?= =?utf-8?B?QWFGazJIeWViRStLZGFTL1pjS1FKb0E3a2RSMzN3MmV5U0VwcTMxemphU1ZW?= =?utf-8?B?VmJNUlRsZk5UUDFSNy9Henc4WFpxY3NxT0ozQmFHUmZQZzlOZmpsZFZDS3Ez?= =?utf-8?B?MWNyWmZpc1ovekRSR2dhVi8wS0s5YXhUTzFvaXBsTGVJY2F3Vllla2Z5bUJj?= =?utf-8?Q?mhgfeJVvOVgRfG84=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 148d567b-bcd2-4a17-4eb4-08da381a582f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:31:42.7865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JsK8HTOPgYuuLkwSnSdGvvmYlDCmhgDJrVkF+3RfwTKqmZQONgH7AzrhpPq+ymBogEPzYCTahhz5Tks/7oGqkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4662 Allow HVM guests access to MSR_VIRT_SPEC_CTRL if the platform Xen is running on has support for it. This requires adding logic in the vm{entry,exit} paths for SVM in order to context switch between the hypervisor value and the guest one. The added handlers for context switch will also be used for the legacy SSBD support. Introduce a new synthetic feature leaf (X86_FEATURE_VIRT_SC_MSR_HVM) to signal whether VIRT_SPEC_CTRL needs to be handled on guest vm{entry,exit}. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v5: - Add comment regarding VIRT_SSBD exposure. - Store guest value in 'val' local variable in vmentry_virt_spec_ctrl. Changes since v4: - Fix exposing in the max policy. Changes since v3: - Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest setting. - Do not use the 'S' annotation for the VIRT_SSBD feature. Changes since v2: - Reword part of the commit message regarding annotation change. - Fix MSR intercept. - Add handling of VIRT_SPEC_CTRL to guest_{rd,wr}msr when using VIRT_SSBD also. Changes since v1: - Introduce virt_spec_ctrl vCPU field. - Context switch VIRT_SPEC_CTRL on vmentry/vmexit separately from SPEC_CTRL. --- xen/arch/x86/cpuid.c | 14 +++++++++++ xen/arch/x86/hvm/svm/entry.S | 8 ++++++ xen/arch/x86/hvm/svm/svm.c | 35 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeatures.h | 1 + xen/arch/x86/include/asm/msr.h | 10 ++++++++ xen/arch/x86/msr.c | 16 +++++++++--- xen/arch/x86/spec_ctrl.c | 9 ++++++- 7 files changed, 88 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 979dcf8164..a4a366ad84 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -541,6 +541,13 @@ static void __init calculate_hvm_max_policy(void) raw_cpuid_policy.basic.sep ) __set_bit(X86_FEATURE_SEP, hvm_featureset); + /* + * VIRT_SSBD is exposed in the default policy as a result of + * VIRT_SC_MSR_HVM being set, it also needs exposing in the max policy. + */ + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); + /* * If Xen isn't virtualising MSR_SPEC_CTRL for HVM guests (functional * availability, or admin choice), hide the feature. @@ -597,6 +604,13 @@ static void __init calculate_hvm_def_policy(void) guest_common_feature_adjustments(hvm_featureset); guest_common_default_feature_adjustments(hvm_featureset); + /* + * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus + * VIRT_SC_MSR_HVM is set. + */ + if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ) + __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset); + sanitise_featureset(hvm_featureset); cpuid_featureset_to_policy(hvm_featureset, p); recalculate_xstate(p); diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 4ae55a2ef6..2f63a2e3c6 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -19,6 +19,8 @@ .file "svm/entry.S" +#include + #include #include @@ -57,6 +59,9 @@ __UNLIKELY_END(nsvm_hap) clgi + ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \ + X86_FEATURE_VIRT_SC_MSR_HVM + /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ /* SPEC_CTRL_EXIT_TO_SVM Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ .macro svm_vmentry_spec_ctrl @@ -114,6 +119,9 @@ __UNLIKELY_END(nsvm_hap) ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ + ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \ + X86_FEATURE_VIRT_SC_MSR_HVM + stgi GLOBAL(svm_stgi_label) mov %rsp,%rdi diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 2455835eda..c4bdeaff52 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -610,6 +611,16 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) svm_intercept_msr(v, MSR_SPEC_CTRL, cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); + /* + * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest + * setting and avoid having to perform a rdmsr on vmexit to get the guest + * setting even if VIRT_SSBD is offered to Xen itself. + */ + svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL, + cp->extd.virt_ssbd && cpu_has_virt_ssbd && + !cpu_has_amd_ssbd ? + MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW); + /* Give access to MSR_PRED_CMD if the guest has been told about it. */ svm_intercept_msr(v, MSR_PRED_CMD, cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); @@ -3105,6 +3116,30 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) vmcb_set_vintr(vmcb, intr); } +/* Called with GIF=0. */ +void vmexit_virt_spec_ctrl(void) +{ + unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0; + + if ( val == current->arch.msrs->virt_spec_ctrl.raw ) + return; + + if ( cpu_has_virt_ssbd ) + wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); +} + +/* Called with GIF=0. */ +void vmentry_virt_spec_ctrl(void) +{ + unsigned int val = current->arch.msrs->virt_spec_ctrl.raw; + + if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) ) + return; + + if ( cpu_has_virt_ssbd ) + wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); +} + /* * Local variables: * mode: C diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h index 7413febd7a..2240547b64 100644 --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -40,6 +40,7 @@ XEN_CPUFEATURE(SC_VERW_HVM, X86_SYNTH(24)) /* VERW used by Xen for HVM */ XEN_CPUFEATURE(SC_VERW_IDLE, X86_SYNTH(25)) /* VERW used by Xen for idle */ XEN_CPUFEATURE(XEN_SHSTK, X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */ XEN_CPUFEATURE(XEN_IBT, X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */ +XEN_CPUFEATURE(VIRT_SC_MSR_HVM, X86_SYNTH(28)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */ /* Bug words follow the synthetic words. */ #define X86_NR_BUG 1 diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h index ab6fbb5051..de18e90b2e 100644 --- a/xen/arch/x86/include/asm/msr.h +++ b/xen/arch/x86/include/asm/msr.h @@ -375,6 +375,16 @@ struct vcpu_msrs */ uint32_t tsc_aux; + /* + * 0xc001011f - MSR_VIRT_SPEC_CTRL (if !X86_FEATURE_AMD_SSBD) + * + * AMD only. Guest selected value, context switched on guest VM + * entry/exit. + */ + struct { + uint32_t raw; + } virt_spec_ctrl; + /* * 0xc00110{27,19-1b} MSR_AMD64_DR{0-3}_ADDRESS_MASK * diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 72c175fd8b..a1e268eea9 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -385,7 +385,10 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) if ( !cp->extd.virt_ssbd ) goto gp_fault; - *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + if ( cpu_has_amd_ssbd ) + *val = msrs->spec_ctrl.raw & SPEC_CTRL_SSBD; + else + *val = msrs->virt_spec_ctrl.raw; break; case MSR_AMD64_DE_CFG: @@ -678,10 +681,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) goto gp_fault; /* Only supports SSBD bit, the rest are ignored. */ - if ( val & SPEC_CTRL_SSBD ) - msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + if ( cpu_has_amd_ssbd ) + { + if ( val & SPEC_CTRL_SSBD ) + msrs->spec_ctrl.raw |= SPEC_CTRL_SSBD; + else + msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + } else - msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD; + msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD; break; case MSR_AMD64_DE_CFG: diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index f338bfe292..0d5ec877d1 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -406,9 +406,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || boot_cpu_has(X86_FEATURE_MD_CLEAR) || + boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) || opt_eager_fpu) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", - boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_VIRT_SPEC_CTRL" : "", + (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || + boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL" + : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : ""); @@ -1069,6 +1072,10 @@ void __init init_speculation_mitigations(void) setup_force_cpu_cap(X86_FEATURE_SC_MSR_HVM); } + /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ + if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd ) + setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); + /* If we have IBRS available, see whether we should use it. */ if ( has_spec_ctrl && ibrs ) default_xen_spec_ctrl |= SPEC_CTRL_IBRS; -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 15:31:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:31:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331095.554581 (Exim 4.92) (envelope-from ) id 1nqzAx-0006Mq-VA; Tue, 17 May 2022 15:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331095.554581; Tue, 17 May 2022 15:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAx-0006Me-Rb; Tue, 17 May 2022 15:31:55 +0000 Received: by outflank-mailman (input) for mailman id 331095; Tue, 17 May 2022 15:31:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzAw-0005fb-EW for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:31:54 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78f11c72-d5f6-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:31:52 +0200 (CEST) Received: from mail-dm3nam07lp2040.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:31:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB4617.namprd03.prod.outlook.com (2603:10b6:5:15e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:31:47 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:31:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78f11c72-d5f6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652801512; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=00JQhhZ8kYD+yNYOJkhm3v0AevYhxWIvLZIvUqoZXkk=; b=VxvVtsWdDbudukOq07nh/9IVYOFeXCq9IW/aBnKl4TkeStZoUh9b+GhV hy7NVxAcVvEQFv6bKkKga18YKwyF9pJYOYZQLMSixUFEBCwXWsFLjqk5o ZzAAz4EbpFz1dtUWiiw6xzuZl48SuE0yqh5bEPmh75Cj0YdIQfFC6V34h k=; X-IronPort-RemoteIP: 104.47.56.40 X-IronPort-MID: 71507225 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yNwSnKMfn9mCM63vrR2GlsFynXyQoLVcMsEvi/4bfWQNrUol0mZWz DROC2jQOaneYzOhfI9yPYy28EJUvsPdx9FiSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Ew27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz c18uZaQaS0VMbDnyMA3eFpFNDtnMvgTkFPHCSDXXc276WTjKyGp79A1SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7H9afG80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx2yGgKWcFwL6TjfQs3TnO0x5N67iuDPjwSPeMb+QOoUnN8 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXObrP+jmwiBUtRQA 0UO/2wlqq1a3EesS9zgWRyksTiBtxgVVNdKO/037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoISFAD6ty7/4Ur1EqTFpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:twXZsK9c9012LkxurRFuk+FRdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBLnhNZICOwqUYtKMzOW3FdAQLsC0WKm+UyYJ8SczJ8X6U 4DSdkYNDSYNzET4qjHCUuDYrAdKbK8gcOVbJLlvhJQpHZRGsNdBmlCajqzIwlTfk1rFJA5HJ 2T6o5svDy7Y0kaacy9Gz0sQ/XDj8ejruOqXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU DYjg3C4Lm5uf3T8G6R64aT1eUYpDLS8KoDOCW+sLlUFtwqsHfqWG1VYczNgNnympDs1L9lqq iIn/5qBbUI15qYRBDJnfKq4Xir7N9m0Q6f9XaIxXTkusD3XzQ8Fo5Igp9YaALQ7w46sMh7y7 8j5RPvi3N7N2K0oM3G3am9a/iqrDvFnVMy1eoIy3BPW4oXb7Fc6YQZ4UNOCZ8FWCb38pouHu ViBNzVoK8+SyLSU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsJg9V55H7e LZNbkArsA5cuYGKaZmQOsRS8q+DWLABRrKLWKJOFziULoKPnrcwqSHkondJNvaC6Dg4KFC5q gpCmkoylLaU3ieePGz4A== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71507225" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhM7r9n6DueQZITqxA6LGl6DF/ywayMDJ930+5NfBmCtq9wnPttY2gE2AtJFRfsXBNWoF5nBYi2eo3J3MMLLMUpqGHItCzELeCKiNcjLM3JDXRFjP9Ylh7MpccDa/0sjqR/gG286r26NyPgugXdYFPyw4w2h5xsgphCebwW0K30RllSKs93fwApYPo/JUoO9WUKQGkTpo6HYw6ovbSXXL4WCdiHDmI5JwzdbOvCrixgHwCONJ8rrhlNh4N9svIyqhLMTnGoKEPzowvcn9bmqvnjmWm0+Pm2Nwt7H/aGdqeuUb00x0KcFuigFe0hKbgmdJbyoireCqI92wgXvdk3CRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=soyEvu+ROxQR6hPSOZ3YsH4mdXeUwWBiN8q89AyTdo8=; b=jhlSAewZpRC3DFcOBVccQaIz0p+ZwWyPEznxoghnKA8HwMSx/u8wyT1qoxdBFhIko84UqrJI+lBU/dxBWg58V85pUivgRtrzWNeBwKuLsaz5SULipzO5+BFYgkW/4jH5hfjNJr86qKi19S5heSs5Be6jrfji7BUNoa6TB1P1SzJEAQ89MvTPd2fo5R3SWsKdpdXDT7iYekI2v3YEczIosDKrqvfkG08z9aYLyT6iyh5zMqfnxuIit5+K+Nn/2+MJgkKvrUIsuvRL8d5f5hdeNC0zKO7GBWUkwyIZmoYlSbJKFxWyWqeVQbpjkgm3iUCStBu1E+mOqt+MDv0UOON0AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=soyEvu+ROxQR6hPSOZ3YsH4mdXeUwWBiN8q89AyTdo8=; b=wfyQVX65A/KmR7h1+g1aOTOtGD6JK2vCwXRXaxXQ2OCOkDwNCIrArgCkqA7sElXFWBOe0SHLILHSPjtnNx9E4p3TcDnQQthEfa6MsnUFfTqRsLcliV23KGJC+jFXk5f14TtgOehcnxcVT3Fuc1JDBHcVLnvCJvEzWhscc/hKCJE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Henry Wang , Community Manager , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v6 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD Date: Tue, 17 May 2022 17:31:27 +0200 Message-Id: <20220517153127.40276-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220517153127.40276-1-roger.pau@citrix.com> References: <20220517153127.40276-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0410.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed0661ea-dadb-4440-8266-08da381a5b2f X-MS-TrafficTypeDiagnostic: DM6PR03MB4617:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4R9Jb6It8dM1LQvggvhwKDniMPQJflxVCsqy0mkGDO3HbqV3OEglsVHT+4MeFamaLfyaKHDpwxQNNKzASINe1SquRDOMpeO2TLpotkBwW0kAxuo2M/1vNXBEqMtISzRD1W9hRkrMQzJW0gKMZjhQWQWv5jOKMqsPvSqBflYGIUg1RwN1MbvQx8fWFUijSfg496kBIFP5vARYIKVlsaIPG7A1/qZEjFDnP3B3QxXMoaqd656AnnDDHVLgTs0FK6Lku8fV0ImAE7EAreFtGU6V9ONFW2UR359K1uSqFy8vVMT1ZqHTCy0jr6SDQ4o/zAgW+danJvdd+iA9G2ava7mUXPttPOQEZlIi5ostZyZ7qUvQvqMUlDyEPWDhtZv7F+8quQAHAf1aPWyTdxoiXmNNpRlgDPKyi1zitL0GkUtKYhY7y0IeVtLyW7t4GckcEpWptn4ChVolcPD89g4y1kYCL5dYfQL7x/L9Zl7KkSKrdg7oNLv5FnKXQH6weTraIia0Vq7k7C4mS3zQV44FdKPp3wLhQff67Raz0VP7vG9EO4mRREWgmOkwZeAhsjrjJ/S0VTfzWDJbLYVpgYu23QdqQ7g8KYk3n2VpQ6xbN3mhQGCoX9Bf5ESzN8KXe7oPvanr0laguCR6T8fplCaj1WCviMIetyTPI5InlyTfUchdKqmluEZfZcQg11JnNk5aWWHoiQ9xnZYVoM144XJ60aYSXZ6Zh4oaXFTb7r/nYwZPvw0BajIZqmgbOg6VgqbUgWFaS4q9xls/4uji8MxRs4X+Ow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(2616005)(8676002)(82960400001)(186003)(6916009)(66946007)(66556008)(1076003)(66476007)(2906002)(5660300002)(36756003)(38100700002)(6506007)(6512007)(508600001)(966005)(6486002)(86362001)(316002)(54906003)(83380400001)(6666004)(8936002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVMxQmxMOUpwSTlJZjZaZUFFWXZpR3RsQzJ2bHdrdDZaaXBMT3Iydk1DZGlI?= =?utf-8?B?YWtHdW9JNVg0TWpFNFdjZTVSZ3dianBVQTN0dzdCNFl1dFJhN1l6OWwwd3Bk?= =?utf-8?B?RzZYN041cjdGS0s2T2cxcG9oNVdlWGZqQ3hCOWpmVVZ2RXBzbnpRWVpaZitD?= =?utf-8?B?a1Jod2Vubm9PbC9WUjh0NnhxQkYwVE9KZklqaEJxZkR6cVpEenpEVGNEK1Fu?= =?utf-8?B?SlFBMEU3TDUzbE4rN0xKUG96VGFBMnhrS0grV09aVnZ1QlhXcmorS2tkY1Va?= =?utf-8?B?YnI1d29BWGxpeXdGTzZGSHgycEtpMjZxVi9lcSt6SjMrMUt0RXFvUW9JT28v?= =?utf-8?B?OHEvWmc4TlEyZzkzWHpIK1h5ZkdpclVkbWEvaWR5VXFWMVBEd1NWcm5Ha1hH?= =?utf-8?B?dlArRHN3Y0JjWnpnMUVCWWh6QzJXdFlDc0puQ0lOQ0JGNkRVNTN4c2xaV3VS?= =?utf-8?B?UGwrZTVITHlkNE14RHdNV09OelREUG5EM2xINjlLR1hGZlRMTjhoZnRqQTJ3?= =?utf-8?B?UERCQzFWNWhCZ2F4NWhOUDZxU0ZMeUJGOU4xZjZrMWlvZnlnaXRVOXlxUnlq?= =?utf-8?B?WXRxTUsvQ2xrVGVPM1ZsYkdiN3ord0FyejJQcWRRUlo4WnhlQS84cWRFc1RQ?= =?utf-8?B?YWtNNUdDWk9xT1FkT0tqd2RkUlJ1VDJUQUNDRzE0WW8vaDNmd0pjVStLbFQz?= =?utf-8?B?bmdoY3QrNnlXNDI1VEwrU05qanZ4cVVYUElTWkU2U0tZZHBVeEFCVG1rZklz?= =?utf-8?B?MVRsL3o3bldzWlNrQTVVZW9JQm9QY21tb2p0WVU5T3NQWlZzT3ZOZ1FxOXor?= =?utf-8?B?M0FleDNoTG5RN0FWZG9ydU56ZG5jWE1ob283V3NodDd2bytTTHlVeDdJUmJD?= =?utf-8?B?elAwWm9WdFZHREZKN0QvbmVXRmIzRis4cEYxeDdySWMrb0NFaXBmNFBVZXI3?= =?utf-8?B?TkZaT3k0TW1EdFBuNjhQZFkvdTRvUENpdGdtZkN6RlBtaTkyd2gyRlI3cElW?= =?utf-8?B?aXNzcFYwM1QzTUhPTnBzSm1qUEJIRE5ldmlxeGxOdFUrMDhEM0N4cjl6S3hy?= =?utf-8?B?aHpsMGZocll5eGt0ZDA4MVphZmRndGlzaDVuMUZQaTJaVklSdDdSK1BmeHA2?= =?utf-8?B?ZWZleisweDVTMXd0TDJvTURJSmI4VDIrSFh2cXAva21xQXlwd2xsK2phZElr?= =?utf-8?B?dk9wTEx5ekxkZTAyQmRLMVd4YjBjWEJiNE0wMzlyMnBJc1VzTTY1dW1odmlx?= =?utf-8?B?MFZ3eElXNldaOTR5NEZnWXhTcnAxWEcybGpzNHVST3RiVHRDS2VEb3kvRTdK?= =?utf-8?B?M0psdVhtVzNUMEExQXdOZ2dHbTBvRkxWcnZJaENpNkxCVXFhdmJHUG1DS2c3?= =?utf-8?B?K0dDejF6WmtaU1NxN2dCeUh2czdDai9uOTBhTSsyOE5NN1VSYTMzazdJSnhZ?= =?utf-8?B?RVk3djl3TjJxaWZIVTNrcmlXcnBTaWZEb21zL2VWbkNzcENzRXEvWC92N0hy?= =?utf-8?B?czF1dzkvdkZZWXY2Z0xiUEtJR3R5dCtHVjJZcHU5QmN2NEovOVVRSnJHYklS?= =?utf-8?B?QWtDMjd5WjZCU0toSDBrVEVKb3JUaFVMQldwZjlyclhpS1Y2a3VVMEcrS3M4?= =?utf-8?B?OUlXalV1UXVEZGlFUkg2SmJjYytDVE92dFlydDZiSU0rYjgyOVkraFFnZXht?= =?utf-8?B?WHhiTHIyMDB6bktNMEdsRS9vVFM1NVNrQm5kT3BYT0dxd3dXMkNsQW9jQ0Vz?= =?utf-8?B?dVFYM1JrcGhHQ3FiWWZjdEN0K3B0dEtkaUNZemV4cUExR3lWcUhmRWNaNUpN?= =?utf-8?B?ZlRIck1KbExkb3cvcktadG8wQ1Qwb0oyUnp4NzduWjNhMHVuMDh5cUlWQk1P?= =?utf-8?B?RnJBY0hYY2RmVjdrNW1lZXQ1VWJuRDNlOEd4RVNXV3RjNGhMZWZpTlhrbUds?= =?utf-8?B?SnJ4NkcrRjhsY3JjaDRrM05JM0hYVkNRbHErd3p0ZllEdkVNOEJyaEh3cnl1?= =?utf-8?B?ODBWd2JqMUtPdHhaZW9yRS9uQ3N6M0xlNUJRNldkTmlUY2JWN2hTWFRoZXJ2?= =?utf-8?B?eW5PQkQ0QmFTWm8yb0syWGpLenBlTFV1S1FtWnpMTUFXL3JmMTJFRU41c0VN?= =?utf-8?B?S2FVSytud3ZqVjJoRnVUM3lDUkVDQ0JwMXVKY3hJMGxCOXVaM2dXalZXbEhM?= =?utf-8?B?Q2lza3EvZ0JxSFM1bkorZFl5Qmt1Y1U5NW9TcG0xQXpBZlJQZ0hlMGg0WDY0?= =?utf-8?B?NmN1NVNqT2tMM0NERzlUaHJFTlVzTHVqZGk0N05rMlRWWVZXSlFBeXp0bjRn?= =?utf-8?B?cUZxM0FPZVM4NlFiNnRKUy9QZjVVNVJGQ284ekIyYlF3ZmNueU5EeTNiZGJN?= =?utf-8?Q?HO2x6yFqQNxxINt4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed0661ea-dadb-4440-8266-08da381a5b2f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:31:47.8679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y4T/DzqXGLGOjtrQ066aC2jw0oIHfRqgWFygLrOxHck265sEQvwgLEHId5rWcWe7lMrJUJG0jThxuZkwmy/v9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4617 Expose VIRT_SSBD to guests if the hardware supports setting SSBD in the LS_CFG MSR (a.k.a. non-architectural way). Different AMD CPU families use different bits in LS_CFG, so exposing VIRT_SPEC_CTRL.SSBD allows for an unified way of exposing SSBD support to guests on AMD hardware that's compatible migration wise, regardless of what underlying mechanism is used to set SSBD. Note that on AMD Family 17h and Hygon Family 18h processors the value of SSBD in LS_CFG is shared between threads on the same core, so there's extra logic in order to synchronize the value and have SSBD set as long as one of the threads in the core requires it to be set. Such logic also requires extra storage for each thread state, which is allocated at initialization time. Do the context switching of the SSBD selection in LS_CFG between hypervisor and guest in the same handler that's already used to switch the value of VIRT_SPEC_CTRL. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v5: - Fix one codding style issue. Changes since v4: - Slightly change usage of val/opt_ssbd in vm{exit,entry}_virt_spec_ctrl. - Pull opt_ssbd outside of the for loop in amd_setup_legacy_ssbd(). - Fix indentation. - Remove ASSERTs/BUG_ONs from GIF=0 context. Changes since v3: - Align ssbd per-core struct to a cache line. - Open code a simple spinlock to avoid playing tricks with the lock detector. - s/ssbd_core/ssbd_ls_cfg/. - Fix log message wording. - Fix define name and remove comment. - Also handle Hygon processors (Fam18h). - Add changelog entry. Changes since v2: - Fix codding style issues. - Use AMD_ZEN1_MAX_SOCKETS to define the max number of possible sockets in Zen1 systems. Changes since v1: - Report legacy SSBD support using a global variable. - Use ro_after_init for ssbd_max_cores. - Handle boot_cpu_data.x86_num_siblings < 1. - Add comment regarding _irqsave usage in amd_set_legacy_ssbd. --- CHANGELOG.md | 3 + xen/arch/x86/cpu/amd.c | 121 ++++++++++++++++++++++++++++----- xen/arch/x86/hvm/svm/svm.c | 4 ++ xen/arch/x86/include/asm/amd.h | 4 ++ xen/arch/x86/spec_ctrl.c | 4 +- 5 files changed, 118 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a7755d7b0..9a007e2513 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Removed / support downgraded - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options +### Added + - Support VIRT_SSBD feature for HVM guests on AMD. + ## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02 ### Removed diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 4999f8be2b..5f9e734e84 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -48,6 +48,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe); /* Signal whether the ACPI C1E quirk is required. */ bool __read_mostly amd_acpi_c1e_quirk; +bool __ro_after_init amd_legacy_ssbd; static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo, unsigned int *hi) @@ -685,23 +686,10 @@ void amd_init_lfence(struct cpuinfo_x86 *c) * Refer to the AMD Speculative Store Bypass whitepaper: * https://developer.amd.com/wp-content/resources/124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf */ -void amd_init_ssbd(const struct cpuinfo_x86 *c) +static bool set_legacy_ssbd(const struct cpuinfo_x86 *c, bool enable) { int bit = -1; - if (cpu_has_ssb_no) - return; - - if (cpu_has_amd_ssbd) { - /* Handled by common MSR_SPEC_CTRL logic */ - return; - } - - if (cpu_has_virt_ssbd) { - wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); - return; - } - switch (c->x86) { case 0x15: bit = 54; break; case 0x16: bit = 33; break; @@ -715,20 +703,119 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c) if (rdmsr_safe(MSR_AMD64_LS_CFG, val) || ({ val &= ~mask; - if (opt_ssbd) + if (enable) val |= mask; false; }) || wrmsr_safe(MSR_AMD64_LS_CFG, val) || ({ rdmsrl(MSR_AMD64_LS_CFG, val); - (val & mask) != (opt_ssbd * mask); + (val & mask) != (enable * mask); })) bit = -1; } - if (bit < 0) + return bit >= 0; +} + +void amd_init_ssbd(const struct cpuinfo_x86 *c) +{ + if (cpu_has_ssb_no) + return; + + if (cpu_has_amd_ssbd) { + /* Handled by common MSR_SPEC_CTRL logic */ + return; + } + + if (cpu_has_virt_ssbd) { + wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); + return; + } + + if (!set_legacy_ssbd(c, opt_ssbd)) { printk_once(XENLOG_ERR "No SSBD controls available\n"); + if (amd_legacy_ssbd) + panic("CPU feature mismatch: no legacy SSBD\n"); + } else if (c == &boot_cpu_data) + amd_legacy_ssbd = true; +} + +static struct ssbd_ls_cfg { + bool locked; + unsigned int count; +} __cacheline_aligned *ssbd_ls_cfg; +static unsigned int __ro_after_init ssbd_max_cores; +#define AMD_FAM17H_MAX_SOCKETS 2 + +bool __init amd_setup_legacy_ssbd(void) +{ + unsigned int i; + + if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) || + boot_cpu_data.x86_num_siblings <= 1) + return true; + + /* + * One could be forgiven for thinking that c->x86_max_cores is the + * correct value to use here. + * + * However, that value is derived from the current configuration, and + * c->cpu_core_id is sparse on all but the top end CPUs. Derive + * max_cpus from ApicIdCoreIdSize which will cover any sparseness. + */ + if (boot_cpu_data.extended_cpuid_level >= 0x80000008) { + ssbd_max_cores = 1u << MASK_EXTR(cpuid_ecx(0x80000008), 0xf000); + ssbd_max_cores /= boot_cpu_data.x86_num_siblings; + } + if (!ssbd_max_cores) + return false; + + ssbd_ls_cfg = xzalloc_array(struct ssbd_ls_cfg, + ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS); + if (!ssbd_ls_cfg) + return false; + + if (opt_ssbd) + for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) + /* Set initial state, applies to any (hotplug) CPU. */ + ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings; + + return true; +} + +/* + * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality + * that relies on exceptions as those are not expected to run in GIF==0 + * context. + */ +void amd_set_legacy_ssbd(bool enable) +{ + const struct cpuinfo_x86 *c = ¤t_cpu_data; + struct ssbd_ls_cfg *status; + + if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) { + set_legacy_ssbd(c, enable); + return; + } + + status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores + + c->cpu_core_id]; + + /* + * Open code a very simple spinlock: this function is used with GIF==0 + * and different IF values, so would trigger the checklock detector. + * Instead of trying to workaround the detector, use a very simple lock + * implementation: it's better to reduce the amount of code executed + * with GIF==0. + */ + while (test_and_set_bool(status->locked)) + cpu_relax(); + status->count += enable ? 1 : -1; + if (enable ? status->count == 1 : !status->count) + set_legacy_ssbd(c, enable); + barrier(); + write_atomic(&status->locked, false); } void __init detect_zen2_null_seg_behaviour(void) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index c4bdeaff52..3cc5fcdc44 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -3126,6 +3126,8 @@ void vmexit_virt_spec_ctrl(void) if ( cpu_has_virt_ssbd ) wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); + else + amd_set_legacy_ssbd(val); } /* Called with GIF=0. */ @@ -3138,6 +3140,8 @@ void vmentry_virt_spec_ctrl(void) if ( cpu_has_virt_ssbd ) wrmsr(MSR_VIRT_SPEC_CTRL, val, 0); + else + amd_set_legacy_ssbd(val); } /* diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h index a82382e6bf..6a42f68542 100644 --- a/xen/arch/x86/include/asm/amd.h +++ b/xen/arch/x86/include/asm/amd.h @@ -151,4 +151,8 @@ void check_enable_amd_mmconf_dmi(void); extern bool amd_acpi_c1e_quirk; void amd_check_disable_c1e(unsigned int port, u8 value); +extern bool amd_legacy_ssbd; +bool amd_setup_legacy_ssbd(void); +void amd_set_legacy_ssbd(bool enable); + #endif /* __AMD_H__ */ diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 0d5ec877d1..495e6f9405 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -22,6 +22,7 @@ #include #include +#include #include #include #include @@ -1073,7 +1074,8 @@ void __init init_speculation_mitigations(void) } /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */ - if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && cpu_has_virt_ssbd ) + if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd && + (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) ) setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM); /* If we have IBRS available, see whether we should use it. */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 15:33:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331117.554592 (Exim 4.92) (envelope-from ) id 1nqzCF-0007nv-BU; Tue, 17 May 2022 15:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331117.554592; Tue, 17 May 2022 15:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzCF-0007nn-8X; Tue, 17 May 2022 15:33:15 +0000 Received: by outflank-mailman (input) for mailman id 331117; Tue, 17 May 2022 15:33:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzCE-0007nG-1I for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:33:14 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9e21860-d5f6-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:33:13 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-ucPLCAi4M0u76HfVOC1xbQ-1; Tue, 17 May 2022 17:33:11 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6920.eurprd04.prod.outlook.com (2603:10a6:20b:101::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:33:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:33:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e21860-d5f6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652801592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z8O3mSKBETLXGP54dCXlFDK0kcF/XfGq7uXQKJ5JjKo=; b=K7L6M268JQWIOQHo1/JNO2Lx0FD+FUPgUsr9YRwhnjuOPQTVfEJ4xakKtMwgvz886mNR6b wQivFsT+8OeRaVSRyaIPf2TQhLp1S81gs3AVzl/PMvBDtaNtZAW5SB7nBTNgPbKCateWqD Cqkivh7l92njWEu26qxyduWK6ZoD1VQ= X-MC-Unique: ucPLCAi4M0u76HfVOC1xbQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZJXoAVaQueZYV/9dBG26zlrwmEZ1lGxphL/YOW65ILQT3IXe+DWxQXxBAf4a5kOGBKon2dRmc5IVM7Ps1Lf8wKABkCT6rOkXFB+LPdr/hRjURBDiOoCeniWibKjRBNixHZNwb4cZLEcefZQZBw9GNv/RB5uc10sV/ri/syEEpw9WQoS4p+wka4kuuJrJO6XwmzfHpDYaPSEcFhk4VuGBRk9wBwJuS/g83euaooVsmj66Fzy4VHxCNwwyFrKDtgGsf/ixepZgf94Ins1d3ZINTgSqwus7bJm3XMDYvLhsOhgoPCMqgt9asz1P8OpgVuVUHiFs9sKU84K1IoTR+MAUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YPomcrMHyVS4yEhzFuY5BqzsedvZHUZKTmP9f5LQiEA=; b=jJ3PjPf+ps5Zn4SXmIWgq099hxObnqJue65uOA3yISoK0j6+rqIGGxY6C4TsjRtsdKe57/oTKSmW183n0Yu+UP8otRbAbOdM9vnaVW7rkMvQkKrA/NmFvtxzERbWknk+8B8nXwM24ycyNvGjXVMoDPpUSSNUqdFWDqhHN/ARmSpJtodc9jKUS/sesKl21zWoKhzKK9Z0NH6hqc8ysrwJz/DwYMSOg9o6KFhEZGbJ5ZBGOfuc9+Qa1j2X/5bYUWK3+jwmneO70I+i7hflMiP/pKAA66EDR4H3PV0CL3OvQ/0VdfNgHsyrqQIDufS7Xr0YsmGB7/UogDcGPo9R3STuSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6a08cea0-741f-c60e-02b6-71dbf0c8b0da@suse.com> Date: Tue, 17 May 2022 17:33:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 2/3] amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220517153127.40276-1-roger.pau@citrix.com> <20220517153127.40276-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220517153127.40276-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P193CA0134.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::39) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d722526-a086-4bac-cb09-08da381a8ca1 X-MS-TrafficTypeDiagnostic: AM7PR04MB6920:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqQ1/7n46cDu0lHWGWBkm8F2SNiLUdKSwyWClQcRmZGL7Jr4qEIOUlIO455Z1tCQ4XDSbVHX6ze1E3uTB3rimEc9ynT0oxwIErGasCskLMIXfJw6pO0Z15uWmVoTDBEhpN5trvaWyP899EWaKF411z+TTU1WbyKmuivLxDYCgNbvXs8ka65BpQorFAmbTKtpapJEKPu7dkDPuRuuJTQ+Gs93Lw9egftfgcyNUgmx9CgeByuJ/G1dqKwLgOLzgVcCajPR2epeU/pHCqqeP24dSYsh0roc2vXCsEucMrNP08e0fbns+L68rxRu45KPjGufmqEjRpZsMI7CHAtuNkLNbXxZmfCV3gfSPZJaY+e86CxjoMefQ4YiDpRhlCIuMao0tPJ6jA//mNsCeNhmXPEBXE41us13qbwBwLhLZxfEHO76eZqQsw7/guZNSCXvtZhhWs2iBEX7HMCwV5I03Sp5feXc8iIuBBP1sggbDZyQFvoMngQqSs2yuvHTtNvG7PeuFWNdLnF8hgInfW/EWAfoqghJxpHZ86BRq9D62HYmbE3ob1VG+Ddsm3175/w6AuMb8A78v82yxPuECePX9iLW3ca4uPUHwlYzzB0Z1/Ipc/bxDJ2isA2ffm2caGB0JwfMGiZb87cgOkjM8IWgxtbsuoYTQNFC1b/BswvYOyapOnBmdUNgUXUfTXNAtEdy4b8hhuJLLFrukvy8T55Nwn1Wn13N0J+wzBhamEucSHLP2kIBUJVOCQOqLbltinMeHSlu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(4326008)(66556008)(66476007)(2616005)(31696002)(316002)(86362001)(4744005)(83380400001)(8936002)(5660300002)(53546011)(38100700002)(186003)(36756003)(31686004)(6506007)(6486002)(26005)(6512007)(2906002)(508600001)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5I7ueWxFtPw7QswKQ7+2F2E7xiPGxHXeQ7Z0KGWl4qdutQE0E54B3jjVefS8?= =?us-ascii?Q?Br9uMn3vny3oe4T2uJAGYh17JAnHIQuvt73MZ+THZHHj5FyCtXM09C25UxmL?= =?us-ascii?Q?ufAIE8IberNS3v0g8oKLTrF2g9d/s/+F4eaRco6AMB0T96Xmon4gq6AJSDNp?= =?us-ascii?Q?dx2L5kEYjilokukVHGLJrPuM7nrn//734hCSVNW+1sBw+WPbZg+Vq2lZEXtk?= =?us-ascii?Q?ceRziXRx8dlT6KfWh19C9VRzGbm9nW6lclCBJRQhTjC79vJPefqRFP9c5q1d?= =?us-ascii?Q?U27EPT0LknDlrqtw4hEN42iHziOZmvkwTNViqXl2i0rFvpsSpJO1SFjNvRNx?= =?us-ascii?Q?AtkbFoZi9/SleVHA2+/vZ6RLJydZmg+In38PyU5Ib7t+KgVU++GtpIakk8hh?= =?us-ascii?Q?p8J1s3dspOQpYIMx87dfHYvWe58JQR6yzdkcdcTHk351FwG6keOI+3wFo027?= =?us-ascii?Q?UHqx7BKKepMdZG7GrFjIbYCd0keQrF8ucUnfdhRo5q9yENW5Tdow6JpryWQP?= =?us-ascii?Q?L2x/t+trLpyLVMilytbu8WX8ITMOW2RUVkdu7NypAfdbBxX6KrGGwNioRZBa?= =?us-ascii?Q?xbi9xPB+YRLjQTkjLapQXrc0DFT0IGelv8SJcG/e78MGS1ERIz5BIBvYVOoR?= =?us-ascii?Q?jSYTk5GTh9JI2NZhxK6r9w5XW+KF07ng++shnXu++np8jqd7jpDu60oOA2Gj?= =?us-ascii?Q?KPi1a0rkGL//mZkV64yZuQrD9noqDzSAH9Gjog+c3X1U8tWILcL/DyjIZLpw?= =?us-ascii?Q?WeZgdSI1CuY+hrNssG7o/E1lSFrTUPeM6R5ot7OC1qB3uVFphvhkRuQfP9x9?= =?us-ascii?Q?p2rDvlDZNjqXDYCAectiRXX0no/q0g4wGnuq6MescKmwDo5+TgC9HM8wh93o?= =?us-ascii?Q?/eE/A3s71/HOZzWQWIV7BMfWw/6jOWpa9f5uslOWGcklw0bkZRVKqFKEESiD?= =?us-ascii?Q?cad5znmleRRF++7ENMpdwiYO/h0WworMbyJEPeiM9TQL4bw/bjPuu8Vg4r1L?= =?us-ascii?Q?OahkA6Ir/n3hEiqT2UDPt4lG5grt4+0xTLbM56nhUW5RYZ7ZivPxuXh8SEIw?= =?us-ascii?Q?QAj+fXFVYm3I0iOrApJBNxMj3DiiUfxe9KJxOfED43X+B1bK4m4S9cPCiyaC?= =?us-ascii?Q?tZgaJL2mahv2tCpDwbZIe5o8aBB4O3hiyevf0X2q54n0YTge6VSfAve1tUon?= =?us-ascii?Q?Epgc/a9FMFs30ldJXC5IbSLN7AsSOUOo03v5uKvRfm32fRVvuNcVT252uLUQ?= =?us-ascii?Q?eUzy9JhKIw2wyXIYNNRSBnO/kZYGAihMteD+pI52ahN7Hftq9vKRTcENJRHJ?= =?us-ascii?Q?WlhOpuaoEdo0iXLjsM7Mi+HPxXQP2DoCIRhdwHo4+FmrziG/ZCREmBKfYi+q?= =?us-ascii?Q?518lg60IEsDKeh2C7zoDG4/Bygk0pshI1wzXPkXLYvU9xwaOo85lEuYqs/iT?= =?us-ascii?Q?Dd8RT4EsAlAh0bL7pBXtiueqU9q7YHPleuV0ZxNiwIr475rkPRnJkOLlFKxY?= =?us-ascii?Q?Er/8uSQHj8F3Ori2oux9vxWw3vQzTKt7a6TjD7qppD8ZODGmyGxSMEaxST4R?= =?us-ascii?Q?NUlgV3yWmsakvHMXhu8fN7/ycf/yxCO63fImLscaHGatC6pF99uO3KpFSnU5?= =?us-ascii?Q?rXUysHirSX3MPy3FpnTG6WP+qG7zIQsZfB/pNU+0vRdmj6Vq0pjBNJa/3+s8?= =?us-ascii?Q?qaKcfjTw/Cg5x0IxEBC/H2HxeoTM0ywf52iHCkaEDw3LzgkKRSQCn+rvnjVm?= =?us-ascii?Q?PKVvGNcEfw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d722526-a086-4bac-cb09-08da381a8ca1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:33:10.7783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 75Iczx3iJazL97ZphXMvivn7LQEIBUyZdBbvhsvK0OhPD6oYnJ9G9D9wFJWWmt7G5n9HcYu6FJbqXCmG2desyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6920 On 17.05.2022 17:31, Roger Pau Monne wrote: > Allow HVM guests access to MSR_VIRT_SPEC_CTRL if the platform Xen is > running on has support for it. This requires adding logic in the > vm{entry,exit} paths for SVM in order to context switch between the > hypervisor value and the guest one. The added handlers for context > switch will also be used for the legacy SSBD support. >=20 > Introduce a new synthetic feature leaf (X86_FEATURE_VIRT_SC_MSR_HVM) > to signal whether VIRT_SPEC_CTRL needs to be handled on guest > vm{entry,exit}. >=20 > Suggested-by: Andrew Cooper > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue May 17 15:33:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331124.554603 (Exim 4.92) (envelope-from ) id 1nqzCg-0008P4-OR; Tue, 17 May 2022 15:33:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331124.554603; Tue, 17 May 2022 15:33:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzCg-0008Ox-KQ; Tue, 17 May 2022 15:33:42 +0000 Received: by outflank-mailman (input) for mailman id 331124; Tue, 17 May 2022 15:33:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzCe-0008NM-O1 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:33:40 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b8b2801c-d5f6-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:33:38 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqzCM-008c9O-8K; Tue, 17 May 2022 17:33:22 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8b2801c-d5f6-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sBxOdf5zzlugJkhZHabZzTAtpXD19gBRD4MewoqTr3w=; b=NsQp7JvDHeiG0InrgCzgj6qEMn +0HDDirskWRJUwtuX9QZNgVpRKlGO/3aNrbmen6tXlKUhuV0+BbQy2aMCyUUGcetLiuWPChDYhZG2 uActfFtkCGU4c6w7jw5eo3KbRLxEWlPGvaIXcW9KuVcgcDuIdvQJ7CUukGXL9th36+kW270UNj6cp KwfiG//V+ceMXkXz56bGppHfbEL7x2Yf8p2OfzRzA+P3gciDRGzrJlW3tYAmf8L72SPmNmKgXgiQH oN/Ktah8yVYeK7YuYx/7jPfAZeKiiCyehjDs7pB9vGbI0WRx7KI28Glco3R/cH3PEM9mA0rVYqkMG 3w57FnRw==; Message-ID: <007af382-dcf5-b06d-acad-08f8d6ec7f8b@igalia.com> Date: Tue, 17 May 2022 12:32:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers Content-Language: en-US To: Petr Mladek , Florian Fainelli Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Brian Norris References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-16-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/05/2022 12:28, Petr Mladek wrote: > [...] > IMHO, the check of the @self parameter was the proper solution. > > "gisb_die_notifier" list uses @val from enum die_val. > "gisb_panic_notifier" list uses @val from enum panic_notifier_val. > > These are unrelated types. It might easily break when > someone defines the same constant also in enum die_val. > > Best Regards, > Petr OK Petr, I'll drop this idea for V2 - will just remove the useless header / prototype then. (CC Florian) Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 15:34:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:34:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331134.554614 (Exim 4.92) (envelope-from ) id 1nqzDY-0000dj-0c; Tue, 17 May 2022 15:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331134.554614; Tue, 17 May 2022 15:34:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzDX-0000dc-Tw; Tue, 17 May 2022 15:34:35 +0000 Received: by outflank-mailman (input) for mailman id 331134; Tue, 17 May 2022 15:34:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzDX-0008NM-De for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:34:35 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9b7a344-d5f6-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:34:34 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nqzDK-008cDX-EE; Tue, 17 May 2022 17:34:22 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9b7a344-d5f6-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=H3qrTQv7Tt4PXBVt8796c6Ly9chEP2DhR9UJaIWJhqo=; b=Kd/s+xrChiBK9NaSmFnFXM3RYc UbvPwTdgYlS5Qa0rscW/rbtbKNYmUFJYz6cuBPp5A2fzucoID0yV96EUGF05FAOiWz8RXWusO+AHA 8G50ebt3m708xrBW8WQ3edVZ8TFa1h54Wb9WFcR4fr7CEuRFULxnhNWBP/+YYHyvucLESFjbnRE2j n9qbZb3QL+2yKsrt97dJ6Amu5IZoY/oVzVzN5MU2xEsTlE/L+2AbQmiktH83j3MJhKZ0jI46IVrKr LNwCY2ghNt9ogJWj8KzB1ejgALFJxydhnjupRBVywOgqfhSwQwo7FdrzyqWruEBFvoxYw8EKWcKt2 QJUgWtTw==; Message-ID: <31f96f73-46b5-aa6f-a5db-5052c6f3fc92@igalia.com> Date: Tue, 17 May 2022 12:33:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers Content-Language: en-US To: Petr Mladek , rostedt@goodmis.org Cc: akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-18-gpiccoli@igalia.com> <20220511114541.GC26047@pathway.suse.cz> From: "Guilherme G. Piccoli" In-Reply-To: <20220511114541.GC26047@pathway.suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/05/2022 08:45, Petr Mladek wrote: > [...] > DIE_OOPS and PANIC_NOTIFIER are from different enum. > It feels like comparing apples with oranges here. > > IMHO, the proper way to unify the two notifiers is > a check of the @self parameter. Something like: > > static int trace_die_panic_handler(struct notifier_block *self, > unsigned long ev, void *unused) > { > if (self == trace_die_notifier && val != DIE_OOPS) > goto out; > > ftrace_dump(ftrace_dump_on_oops); > out: > return NOTIFY_DONE; > } > > Best Regards, > Petr OK Petr, thanks - will implement your suggestion in V2 (CC Steven) Cheers! From xen-devel-bounces@lists.xenproject.org Tue May 17 15:38:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331149.554624 (Exim 4.92) (envelope-from ) id 1nqzHV-0001MP-IR; Tue, 17 May 2022 15:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331149.554624; Tue, 17 May 2022 15:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzHV-0001MI-Fi; Tue, 17 May 2022 15:38:41 +0000 Received: by outflank-mailman (input) for mailman id 331149; Tue, 17 May 2022 15:38:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzHU-0001MC-T4 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:38:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c750167-d5f7-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:38:39 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-XO5zcPlqO06LxzxBYAsfsw-1; Tue, 17 May 2022 17:38:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6920.eurprd04.prod.outlook.com (2603:10a6:20b:101::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:38:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:38:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c750167-d5f7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652801919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=avMjyL6waKTXUjMCXu6p+BDuwirFXMqx+T+cx6+YXLA=; b=mMMUbX2Og+fFQyeNczGJmxSRAhs1XA/96q/XOoTU2FwbAEVOD1yCX/EihFQk940SKd6KZp Gy5wOGz0u5QuFXt2v98h2jrKtgoWgZoJBk25oYMqy1NcYnxN8/dGUwyFHJFh/WaPN3KIBF k9S8Trl1xVQk8+XGHzZCmyIONKw/pOQ= X-MC-Unique: XO5zcPlqO06LxzxBYAsfsw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EbawRrsH71MIZ9c79r3vPuAyxpZUu7sJLqqUHMjDUdk300yu1eFQv6/AQrLln4hDthdJRXAKWdOVlYYgxZ094HJu/arVWc4SvXhU9X2vmG6X5p4hpr32TdgfeFtEoNrubQWs6KdkXYgWQF0JfuDQmcIe0n7wGO96s8F9A8jOADdeKvNPBc7em+Y9A5a9IPZ1+WaIrnm53WkqrPUzHLO4c14C6Yo3vMH5DjODOQ2kCvtBIvTXDjfBD5D/YcskROlN3n8EsG87RBtsZswdWohz+BQOFO8Ma1MBYQuTN9y/nF+JVbYelUBK5h+KVNTeAe3QXUo3fq0y1Bi+4phEsDJvwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2xj5h4ued3T/BrsnWxIuy2EZy8/aYVoChYZR3tKstO8=; b=d5viUImJjFGfvBtZFKFYmeHv0c/eBbiiLQL2Ighc8tcb3R4L6C2SLxW5qizdFoXjFFU7b/7nY2fCZXxmnd5ywx/fo5RyEoODfa0/tq/8jINc/wvvvVMze52scaRFhA/miPH930FjoXhfG9oOVJiCq6qKNe0O0m0HLYIFE8WT1s9W9imIK5dpO8Fh/DGH8PolwTDZEfG72No18AS9urlq7eDwk6Lh+l6mG4LOzqkMBWE1rPMwps83vSnPn3vYH284wbLsB8G3QqIcp+MWBsxTqw7xWkv+Fsow9dJd88eG5YcR/fW65BSCsEZvbnT7UWwFgu/NOk0ELRe8RuczHFOJ1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <000745e7-0b0e-386e-861e-901319defde3@suse.com> Date: Tue, 17 May 2022 17:38:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Content-Language: en-US To: Andrew Cooper CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Xen-devel References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220509122409.14184-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P191CA0080.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7706950d-ff70-43aa-df18-08da381b4f0a X-MS-TrafficTypeDiagnostic: AM7PR04MB6920:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: geSmrkMMAx6qePTckAbW4fn1APLJtk4nAT21bOfJGPUV8VFuaXwl2IkliDS9yQ2+JpVIZ5fsmdDod1izBNwA+LziUCseif6TvuMJbyi5wI11waovVqomz4AP7C1Rhg4Ee2aQjA20MCBi8VGH2EJlpLUuPeq0yqkMyVoo7Hyz81xu20n9oBb9qgH4EKvLui/S4Xgf7R6dVIHEUf4MMIvkL6OI2XXlJ2kNwwzc7P0cz6w4xoK7eFXIjmU7KC4KTYtFFP37j8XCjTv7RNEid60A45VorlkqAVKbZ8zdK8i68kfeSb7S17btod49vnHlA9V+rls/Ok4oapt29HpJKu6DURT+6kxSmPZhP70KBPVyX7VAu6xdca6zF0HeRay+OANgAUDIGt5KUJpxPIVmxoVSsbqU1NhLBFnPXTLivH12uwZznqaUl5ef1nWkv702esD2v5nT0sUfyztqb0u/MlLWtqk9OW17xGF1KshQi/Df0wTj4GnRsFGJyWkfhhpcEdlicFh5f9HJL3hUWUQb44V9iNAHRz0YT4WBhthx91ij/UC6MdhzWRxfByQWGXnFMJIM1JOYCIhb0sNJZJZk2xcsAy4obFzd5jS8MDJVSHA7ZjER4WG9kcTLWblalbM+s/+Uu/e4c1uJriYe9Ii0+E5rSwnRIcwYIwrRMFVlmzFYR8Y8vW+r1EN+N+yK8jY3a1c+/sEvHZAgly7rzbFExOUIDY9r6TjJXTEBFjb24zwsMO279gA6a6J4VeuxtUrGTACgIBeU2wP387WAv5PjgXVDHWkynDZBsMJcvMsNaFhWp4KmEuFhpCgoUVTYfQKUAxsi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(4326008)(66556008)(66476007)(2616005)(6666004)(31696002)(316002)(86362001)(83380400001)(8936002)(5660300002)(53546011)(38100700002)(186003)(36756003)(31686004)(6506007)(6486002)(26005)(6512007)(2906002)(508600001)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M3RsfEAZ9yHGVlyUWWdRNmCenOfWQ9gqatPmodphUaxwKipf3T5lIzJ7DDWe?= =?us-ascii?Q?qbUXfQGCHeb2SAF3t+3nZRZm1awm6mbsJzpGK4cAvWJMvHO2VtokW6aXAKHK?= =?us-ascii?Q?5MuOUnGfjHcNZ3u4m22vmMr0tDVmyT4s82gWh49DiSL51yXrQbMvd+7717DV?= =?us-ascii?Q?AXz09HIvIEmSFmFn1fDaC7QhJdJUOFteYAh0Q7IEkpdIyr7o2b5nrpllsryI?= =?us-ascii?Q?Vjj/LrUdLIeoVfhfQ6USEYmTGIV8Z+vdE3gcnpJJjy3/UGywrpA0hneQ0E37?= =?us-ascii?Q?cQJ0pRb+GreoYZ9iAYkxWMS187j3QAfoZGbWFDuXZBFR7gaaoXniKXbBFJXc?= =?us-ascii?Q?IwmqKFqznfe5I32GTRLjnnhIPfN1hW0k+Tex1EvsnKHqM9ybYQnejeX8uJHv?= =?us-ascii?Q?poZQeLdcGyuIOkaUVz5Q4enO+YyP1WFkJt/9jH5sDloSSwImAWup2y/dXOxH?= =?us-ascii?Q?t9ddumEnCo9SqbbVHgpcgSlBkf+pEbHDvZ3yKhjG+kp7R5t4nzLVVixOsU5K?= =?us-ascii?Q?VPXBmJoEz6PBl2Dc1QY90nC28GTIUgSM5gE5m3Vhhqo7YmpmwDQLu1upHavE?= =?us-ascii?Q?XbsLNLaW3XBPaaX2TcZXDi4QtkxfxrCTlnM6/vqWonpt4YaHkSDZTW91fRbK?= =?us-ascii?Q?k/Z+qe1T4xHkKRvsIwLBS4o3EXlnxoABUeadp6m9S4AC/QEOnoSDCNMeEqyt?= =?us-ascii?Q?F0cvqWrkY0eJMJbeDCAon0ykdkW5K63AIepItE5cAYhn8EXqf5EAq0zwTukd?= =?us-ascii?Q?bvM60QJOtdYrBWOwmhQoi3iHrwN+Y8ByHEjWmwakD2MlmFFddFvsDgyGYGDW?= =?us-ascii?Q?wQ6avY3Rbc4mbKc1auNDhOn+Fu4J8TWoe7nkdtmtU2Plk9c/L++hSdezIAFh?= =?us-ascii?Q?utmZUmeHeC9M7T32RyOU/g2E1zvzlISATionwo2YdHg+1Pe59vBZJoW23gUa?= =?us-ascii?Q?umFEGK7ES6CYPoXyp2XZeMs2Vrq2rbY6JbwAoJ7yAz6BtYxce6wNi5AytwhH?= =?us-ascii?Q?tT+C5i1esdfQVnCDKBKs37GYEbDArIj9YqZsweVjGWKrzwrYkGypglKd8ml8?= =?us-ascii?Q?+O/0ShSuFnSjmH885sE1yN+tF3WTDw+RFXCeWlhusFeQd+318QC/1y/iJtMX?= =?us-ascii?Q?osdj0TU7IL/MpPcmZtiiEGOBuT5Iz4UG1isomLUc+cmUZxZBm+GGcZB+lvLt?= =?us-ascii?Q?xINQxHRfDd7X0J6pjOEZV6KKl0H3ndnu25qN5/xc99jl4eDKdpSg8XlDuy9A?= =?us-ascii?Q?Q1hthtrioSTPqBlNC4VwHFUcgM1YeNNbl/Pl5vOJJDmjMvl4mvsUIrO7S1BG?= =?us-ascii?Q?WuOzoMOZvI11KmfV8Un6AkRXBjZsx6tCfNaZBbIK0oY+Hgxp3vrtjtWrEYJV?= =?us-ascii?Q?4v7VVAy+ir3NsGhBo6u8FdZ4CWh6xha7/iKvko7ZmukYh2blFB+j1BsVp2ov?= =?us-ascii?Q?axafY+68fRUJ5mOz8x8xzGbwuGviXhnkrhZJQ1ffrOkdUMTypIJmcTy1fVMq?= =?us-ascii?Q?6rHhlogSiLYzggTl4lJ5W1n3b1Txj5/53jqugWT30OKSq4qzbH4Cx9pMWKpa?= =?us-ascii?Q?kVg8cWoEkq+5ra5AX0vxQ0nb+7ET/d2wy+3jsIHW8ps8e6H+dBPbcJs8aXcO?= =?us-ascii?Q?N3A2RY9EjEmrW+5Ko8n9TOBdiCeibhgVZCHMh7PrEfAa2ip+ILUu1uG8X9i+?= =?us-ascii?Q?Rj8pX4POVneFHgnk/qhqwAsbQWDfCMkn8nXdKDyqrCC7X9uQxKV0ibQA/ox1?= =?us-ascii?Q?Smnscyuipg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7706950d-ff70-43aa-df18-08da381b4f0a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:38:36.9137 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N4QEgAqN84VSJnm0/KNdMrH1k6XEvrnZPG7WVUz8vF7SXKxdYwiA7kq5sxxZ6owPqsIAPbjtgfFGtha0W2ClDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6920 On 09.05.2022 14:24, Andrew Cooper wrote: > Spotted by Eclair MISRA scanner. I'm sorry, but what exactly was it that the scanner spotted? It was actually deliberate to introduce this file without guards. I'm of the general opinion that (private) headers not to be included by other headers (but only by .c files) are not in need of guards. If it is project-wide consensus that _all_ header files should have guards, then I'll try to keep this in mind (in "x86emul: a few small steps towards disintegration" for example I introduce another such instance), but then it should also be put down in ./CODING_STYLE. Jan > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monn=C3=A9 > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > --- > xen/arch/x86/mm/p2m.h | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h > index cc0f6766e4df..dc706b8e4799 100644 > --- a/xen/arch/x86/mm/p2m.h > +++ b/xen/arch/x86/mm/p2m.h > @@ -15,6 +15,9 @@ > * along with this program; If not, see . > */ > =20 > +#ifndef __ARCH_MM_P2M_H__ > +#define __ARCH_MM_P2M_H__ > + > struct p2m_domain *p2m_init_one(struct domain *d); > void p2m_free_one(struct p2m_domain *p2m); > =20 > @@ -39,6 +42,8 @@ int ept_p2m_init(struct p2m_domain *p2m); > void ept_p2m_uninit(struct p2m_domain *p2m); > void p2m_init_altp2m_ept(struct domain *d, unsigned int i); > =20 > +#endif /* __ARCH_MM_P2M_H__ */ > + > /* > * Local variables: > * mode: C From xen-devel-bounces@lists.xenproject.org Tue May 17 15:42:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:42:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331164.554636 (Exim 4.92) (envelope-from ) id 1nqzKt-0002l8-4f; Tue, 17 May 2022 15:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331164.554636; Tue, 17 May 2022 15:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzKt-0002kI-0L; Tue, 17 May 2022 15:42:11 +0000 Received: by outflank-mailman (input) for mailman id 331164; Tue, 17 May 2022 15:42:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzKr-0002k3-7P for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:42:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8cb4a8b-d5f7-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:42:08 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-XDsYJjxnM86ahUr7rPEXnA-1; Tue, 17 May 2022 17:42:04 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:42:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:42:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8cb4a8b-d5f7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652802128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7gcuJQCz1RB40wov1I8iEjE3i26sf/KauDhMpafyhOk=; b=BlOt/EhW2ZzWYoehYIiElRHfovmrtO+zYUeSTKUtG71GdzT6ESJ0f/Mf/yC1mq20E6cHLE Bi19FEnT1shL44FQhxLpNKEi2T6grGmtWGABqxikcOK1XiXksvU9zD28kQQx3x5ktoYXhL BGf5Bum63aqUzPOAZnyX2EpmpDIuzGg= X-MC-Unique: XDsYJjxnM86ahUr7rPEXnA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fhh06njR9ZAktDJ8zrJ6D1dTfPpVTMlgy9h3eIsc19mltPafBXWomewwKYD6xe/3TqYddrEIwdxSB0gH989axBrzNWhR6fojQZXa2Utk3vVejS2qK3eA7UYHaZwMC74kNvmUyF6W+Ac011WYKTFVxVMEuiWB3cBNPVx/hf4E7w8UJSIKR5ik2DDzzet+lh+QT+pxit+rIBRtopVUN+GS3H0+86qrEoTls0yRIByRBZZ4mg1ucVbBQSAjQ5GguPoh7p/RCfvXbKYRcqCWkTyen9Nwk4tg/nenC0M4RqL9ikWGECu7LYYsI3tfhMTCRJ6Wb3SRx74YckKqYzmIBOCDnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DNPrV+DyDhbr8Yj+oOTfeiRm3xfDfHFhqrhSn29H4xI=; b=bz5gU3gsjNvNeTGuRnzCqwqApdaLsOrTH4CvmROXZrBsJqzxzIUVyNNBg2eIGq0MQn3A3SGDfVeMzwLuywGsO61JYdCt9z9pA0IgdcqynWucRKODa9mBLB1Iclg/3z7RO7rgQHDkRkVOPU4em90VhEeDE4wUG9+4KtG/rCYkBa/YmvbwoW3iP0jUbjJawf/0di4tTxP/sg8C13iGrmAyKp02ysXTECUy5qF1mMwmw7jPcfWPyleLfaFPZye4ijW9SSFWG5iMzpmm2mJ3gw+77b8hgQs4rx2/2Zrkc83myuGqZLBoGrnoj61Q8OQpUc/5oCrAKg9sMhiuPTnQmRZ7yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 17:42:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/3] common/spinlock: Drop inline from _spin_lock_cb() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Xen-devel , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P195CA0093.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70f9695e-56f9-4d87-df4d-08da381bca1b X-MS-TrafficTypeDiagnostic: DB8PR04MB7036:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l9dnuZtsTTg536jVElzb+aqCUrk7c7dZRETedk2vgQnlcekzwQT3p2E4Pwfs+vF8SGhHW3IpOVsaBY1qXfeaTEkQzCwO2ccCqsoT5SQ7Ik7W9v07ssnl8vJC94gL5bOz/SjltUwEKFzdKosDgFBnSsHpvV1OmuxAQk+rlgDCtwrVTWqDYbzMTnKXtdq/GKPz4hZ7sQEIREpkUfHe3YBjIdyTUelqmeaOxTS4VQaWLFKegBbmym4OR5xjrgA7Adwr3gw1nhh4rsGfcXg8HKuaazxCizKZrZsQCecoYCa5zIhIqfODz7YAm/U5UBAorGqmJSnhQ9LRE8hOa5UfPuv2e6qD7POdQBKFG2FSXZP0VMw2phnDWLBwZGDR0QYU4XCUeZhz+tJZKLRb834Bj+v0j1oNAb8b3iaYiNHEbqdZcmcPHVmUfu8BUhW70amFTIN5oOTDtErRuZGOjcCDp/DCxkEdSdB9O1bCWpExYQHwApPQ87A8DfemelIepCVqhe6X8ZDdpczu63BiIdgxWOlfJN8g5+GhwNhI+v7sNIvSOeXHMYRe891mvPIEg1bIsuOVX7A+I+F52DeXBvWtW9PG9w9OEoDLugIH8Swe0GTTkogxE1U91DN4FYkigJfPEcQNHX4msZd0QwQL7viznYAiFmQQAgXyCpCdI7doQhLRJBbUuC0pExRtrCzw4jSkcOVmrVHGLmvk/8fdLSgPeCetvvrYYayIJqyyDVbo38HwxlXKmlTHoYtHTE9XbRHRYCVP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(6506007)(186003)(53546011)(508600001)(54906003)(6916009)(6486002)(26005)(6512007)(2906002)(31696002)(66946007)(8676002)(4326008)(66556008)(66476007)(6666004)(2616005)(5660300002)(8936002)(83380400001)(316002)(4744005)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VyO9rnh3jxUIWjVTig6ozPAkaXZ2awio7kO+v0k22gknpR8UU/pJEuEydr7c?= =?us-ascii?Q?W2D3untblsMcH+ug51FhTW2YHJzdjyBfYXg+K1hHMafpq2ULvDY/d6jejz73?= =?us-ascii?Q?O2z5a/ZLkGS2dpwiThlPMZDfTVm2OT/Oc40mAtgjJPvKpqZNYJEET+iHlrZ9?= =?us-ascii?Q?n14uaYPEV1TxP5Iv2hsF9E2qDLRGC4rDdq0/LfcdxjFuY8FPgP+on4tkl0i+?= =?us-ascii?Q?qOLWqMIWz98zJkmzGjgdT69yhtTJfFcQ6pHT7ev04d0TaJdajI63pnQQhxg+?= =?us-ascii?Q?l/zodmxZWDFVNbQiMVKfBErUPYu7Q/Zep6NLUQS2tNlBx+RkvKO79jJFs2+X?= =?us-ascii?Q?Ta8YasQ8XWQtWP/23SiQs2rOZGc6X8ujsEeLRNHA+S55E4yNhVPRPqIqz19q?= =?us-ascii?Q?y1flK+PKKM7DVvYfRwdCXMw7yPaqGUFiPwu2FBmCWbyl4x3dFGneE+3mpVFx?= =?us-ascii?Q?/vlQ2TAVdZLDEyP+eufjAPXJk89qI43hFTP5Hvz12scgMvfEDiqP21vu6BbI?= =?us-ascii?Q?A24327RTS3LexHSlyKG+ZcgixZpnklens2N8xp22RR9j0S88ogYzfnKh2k0v?= =?us-ascii?Q?5Z6oiwLMycwCIjy/pTYZPc1weLDwSaIpxV3Y9vVm268ud+pwJHmx0waI9cf7?= =?us-ascii?Q?SeyxP843aPGRdeOpsOc+oyxfFsMaDXsg45U9I9c9nJ8JMh1kK2junqyJ58Y7?= =?us-ascii?Q?ejbi8Fz/NbnWN5vLkfPFcAmNqE1+ZojqLNLj+oNV2UdUKNkImcZZ+bH4IhaN?= =?us-ascii?Q?hYgg1tzJhrbNNwLTS6ILuYNWE7ry8LaYvOf/OXJquN+ngEq0kqJ/ZPZpaKtT?= =?us-ascii?Q?fXkw/Ocly+IweymSo5pqFJD3zBNrG57SqnYrex/fClDbQrelakiVlYajJqRt?= =?us-ascii?Q?JkVq3JVS74GeZss3Z2O1H12+eu9OAD3KX7dzxkct60OBwdeQgCfu6bM2+LGu?= =?us-ascii?Q?X10SpZKPZ3mv18DDwOUyYQRKsUOqGRkFVDQZNrIaWkdVtTvhSTX/28vIbH89?= =?us-ascii?Q?GYGNXXh7tYkDBi+9XV3w3/mcRdj/YkRzGltOr9YZuIAr7Gy9ToG6f2Ar89eM?= =?us-ascii?Q?pps/6ZZ6Pb7PR8JquQIMw8rLvUgDp4WcRdLrDZQGIeLJ/+AiLbxXS4SWMJcu?= =?us-ascii?Q?hyLBHLHfZsy+Sr37DLxdIQfJ8+vgNk8L6FdDsLZZKG+MG6L6t37meg3YjMIs?= =?us-ascii?Q?/WjbeKaLkNH3Ges3P39OJTpz1WWkfmhCI5MUWnJ5gsakONkEu6ImCdEMhkzM?= =?us-ascii?Q?GYcdE2A7q68De6rvmUYajEcGa1Lxghx/FluIfDIMFfdMWJrgHgvQdnqZGBNy?= =?us-ascii?Q?M0NToGsXXuQ4zBFCCjr4FqpXxayhqYfhqMOxh6L3kJ3GLiQmbbOfuqDp8Ode?= =?us-ascii?Q?P7Pe+yKfS4ESjPAN5tIVPDAsEINW1hXjFhGUyctciPgstXDlZ4g6AMsDXobr?= =?us-ascii?Q?KLK2wpd3HTJxsYhn6NZnUPEqz2bFWkKORP2TFWAVrGb2c4kYdnwMJBDzIEwY?= =?us-ascii?Q?jN4OyYjrLNuoq8qPb8zBgRtoA/j34xfd4ZB/qBNfxj4nMVVCV37Rx9f7fard?= =?us-ascii?Q?pBSLDc0mhMACN5S5+KXPZbMHBq1KvM4/B8yf/ghNh0FPndii/f8JXJYH8cEm?= =?us-ascii?Q?Nj8Q0+5hDJr7V+nsUSvx3HNkRuCobddFBBp/fLfMUexzecsJK9U+PgFmSXZ3?= =?us-ascii?Q?egJ44R97mXAXZyUdUca4qRpab+B33gWwz/08TkhylD8S5wfDyi4kFqrlbly2?= =?us-ascii?Q?g74tFFVUYA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70f9695e-56f9-4d87-df4d-08da381bca1b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:42:03.4318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XAWDbUiQVhQN8xc9OQrsgrVSmMzppxkXnRTPrKeRAAZo/FM7xtSysk3s3ohvcIjVUrjTzIB8R5yA3zeX3RgyGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 On 09.05.2022 15:53, Roger Pau Monn=C3=A9 wrote: > On Mon, May 09, 2022 at 01:24:09PM +0100, Andrew Cooper wrote: >> This is undefined behaviour, because there is no _spin_lock_cb() in a se= parate >> translation unit (C11 6.7.4.11). >> >> Moreover, MISRA prohibits this construct because, in the case where it i= s well >> defined, the compiler is free to use either implementation and nothing >> prevents the two from being different. >=20 > From my reading of the spec, using inline defined function with an > extern declaration could allow the function to be (re)defined in the > scope of a different compilation unit, kind of similar to the usage of > the weak attribute? Which would then result in a linking error due to duplicate symbols, wouldn't it? Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 15:42:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:42:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331170.554647 (Exim 4.92) (envelope-from ) id 1nqzLD-0003Fb-HO; Tue, 17 May 2022 15:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331170.554647; Tue, 17 May 2022 15:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzLD-0003FS-ER; Tue, 17 May 2022 15:42:31 +0000 Received: by outflank-mailman (input) for mailman id 331170; Tue, 17 May 2022 15:42:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzBI-0005PP-NT for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:32:17 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85dfc82a-d5f6-11ec-837e-e5687231ffcc; Tue, 17 May 2022 17:32:14 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 102CE5C02DC; Tue, 17 May 2022 11:32:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 17 May 2022 11:32:13 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 May 2022 11:32:12 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85dfc82a-d5f6-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652801533; x= 1652887933; bh=qTn5m99hIK9GFmefzE3hWCqBEzDHwVdBYbuI3u0RnGo=; b=B 2Qx5rwEYjMvVmryVph4J/HSBFzAiNcrU3A+uWYBKOTjAIqiScbFoPM4AF0QGciE0 RNuI4D2vr6t+UKp3xmLOxn/3xzr0ftpBJ0+dNohxIBjuM+tplEqAcHP/CU4AiTpY vtz43NxBP8H+SyCfRX4qpUvXrnyLOhpPJRuMvPparyiD9zMY61sVjoI0gAZ50cfV 0XFdGztRIBlfbAFCXkkc4rcBqPUuMtG/mdaGjIZWwEjAS+UL81SYKU2AnyVV5Brw BD6mJ+6IISIvAwo410u6bNRNkFtCpoHOJwYrO/kBM2++Upnjih2CzATiouPWxXQX poV2AId5vboTTe/+VMj+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652801533; x=1652887933; bh=qTn5m99hIK9GFmefzE3hWCqBEzDH wVdBYbuI3u0RnGo=; b=myQf7/nrUPx6hwzai7TmJ7kSYBE3o3HK7MSEf/E3M+eU HA9lFSo+teY+tXB3DQrQ2gyzhiJKs3gil4SDeL/csgClAjyrbEe7OT5XDHuv18It sgTY2OZ2x4gJ01osfcXd/mwk2bN1jHioE9J4ynBsQOMhRH/VrGqp9u1YqSzZh1lP RZpV2Q8CTl0msQlBFl090IkMVSqELB98AZbdesKaONc5vcH6xESo5F330aiuImUX CN8AtItfn4bQO8ZoymPDk9Y0pF4QfSLg9+juLCaugPLZgXobKEtR9oi8juNfc+EF gMyDUXEM7MRIYHgTMAtzlTJTRNdEyMWtAit1vJwErw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheejgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffejgeej geffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 17 May 2022 11:32:09 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uYERJ34LyrAQINuu" Content-Disposition: inline In-Reply-To: --uYERJ34LyrAQINuu Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 17 May 2022 11:32:09 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] Preserve the EFI System Resource Table for dom0 On Tue, May 17, 2022 at 03:16:55PM +0200, Jan Beulich wrote: > On 07.05.2022 06:26, Demi Marie Obenour wrote: > > This would mean the allocation would need to be unconditional. Right > > now, I avoid the allocation if it is not necessary. >=20 > Hmm, I guess I don't see (taking into account also my own reply to that > comment of mine) why it would need to become unconditional then. It did not need to become unconditional. See v5. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --uYERJ34LyrAQINuu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKDv/oACgkQsoi1X/+c IsEE4xAAku5xJJSX/pYFW2LphHDqtCSwp5S9k189Fb/wXEmLV1L8OAn5ZztnoK0T JBx/JYr2ajtnpOTsM9/kEpJEjSHypMaFzUVC/wTFyhMyFufqUROVzyRPHUh2hxjo szNwz6eKDFt/gYdvrXEY8emm6TZ4WQOoyTE50wi7EKGVmKYszdM8KTaukh4MWid/ 97MGcyJN5+jLd7xXo8QnXFZGZWzy4+hQekH3Kl4JjJbKr+4XIpJ8K+c39GdwemiY pJsRCDqTjYdBo63QVDV+wCIufjoh7sdn/ncgkbcmbuLjaHNjhgoKElLtamAGQ+qD Z8/kaLIs3ykG0rJ2W6xfotrltF4DmEUDwwvMo0nX1wTIrpD3t7p/kB/atm08quzu B1ml9NGnnWZN1ugCig+BeV97ZyCPiQNiN/dCmKN0rj+AcfPNZh4sE3KswLEkbSOZ ZOqu+qenI/71zeK/WV9YydpNZmiEo4i/9Xn2EJQLUnTVKerdGIbUjvJ+QUhSnXXd 6MhfdnukA5ibVM5HXzo+zXpqeNVERsT6hpdSwOSMc9SEACfNMdNo5VsVRjOr7A6Y t8dwYIM8sBPRYdQZLZwJmPmsIRAzcd1pPDoVJKiyj51b57bPAwdrsZ/bVfOwSTX5 V7jFD2wH5xkz6xUifUyln17ugCOLcZW0/ki5HY3+RsCJd9AR/Tk= =Dji8 -----END PGP SIGNATURE----- --uYERJ34LyrAQINuu-- From xen-devel-bounces@lists.xenproject.org Tue May 17 15:43:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331186.554658 (Exim 4.92) (envelope-from ) id 1nqzM5-0003yx-SA; Tue, 17 May 2022 15:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331186.554658; Tue, 17 May 2022 15:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzM5-0003yq-Ok; Tue, 17 May 2022 15:43:25 +0000 Received: by outflank-mailman (input) for mailman id 331186; Tue, 17 May 2022 15:43:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzM5-0002k3-0R for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:43:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14ffca68-d5f8-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:43:23 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 May 2022 11:43:20 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB2765.namprd03.prod.outlook.com (2603:10b6:300:41::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 15:43:17 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.014; Tue, 17 May 2022 15:43:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14ffca68-d5f8-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652802203; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=k6u3Q7tptojcXvdfl/2tQg7TVrPUhQ/12u0NRNEMigY=; b=ZLVov6fyNvUxoBwDAY5RZTWC9ARGaAX11rcxbhosqL6XkLZLl5LawOz6 7L0a7eq0t1bKIkalcEBLXA6shn2UGkeD1GUb36FkE9osdlhSD/W2SsVdg COVIm0iR1WWc151OaB8s+vS08WMyzv4srXzBvASaLxZ+E1KsSuJH67u3o 0=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 71522030 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kKyMPqs8gu1QE4+MeI/X3dCMkefnVGlfMUV32f8akzHdYApBsoF/q tZmKWyFMqqOYTOgKNBwO4+3/BlUuZ/dmt9jSVc//is9E3sQ+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U5 ouoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi94EZb3w+kHciNdTR8iEZUW1ZPMeyag5Jn7I03uKxMAwt1IJWRvZ8g037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IJmm5v3aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3M+PBtuzOLpOB3+KeqDMv2Yf+tf+dyrEeot 3PA+UrmJg5PYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IBgfT16yu/S6ok+4RdNEK kYQ9zYurK4970iiRJ/2WBjQiHyZuh8RXfJAHut87xuCooLP+BqQDGUASj9HafQludUwSDhs0 UWG9/v2ARR/vbvTTmiSnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPoC1ggbwW1JQPz//ioguBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHflrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:UvEIeavRn4JlTkSUFEadB9eO7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71522030" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=POC56FAXBUKJjjIEB4Eiqu0KqC50W6lJSpp/ihBG7sz3l+vmvhjPAUnDBRaBNUckauuxhCJGoH4RB1B8JMuIVgHZsY67+rd/fKKRAqo5TrEkGF/GqsDdZs7BoPoTS38AMEU9D4IrNb+GUuB1iMVeh/JuhMcwAlBel/rFxwkwUX9BcjvPdu+LdgecO7XbSW6G9Ru5472V5bTFnjbuMW2txYAb8N1wQHbyh0pmi9jnmB4IRP35xVV066jItcDR0UqTSgy9xpoJAsG/ztzrDm01P4+uAdc0TKfCGv2A20Pdw43Qu/FkuDyaDAr2GHazlOFxkIYePOSfCvoiLG0hquWzlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oxSlUfvN6JeUVHl1k+RSb6917evB1uk3oZs7PfOeJ4A=; b=KpNUYgXQDc3clrbA+63U4QY5LRQfwMQOk5S+hh079njHr5PvBjbWXkLD5A8kSdDXSTO+Wn9nQsQMoHBrrpTUv2ztH4CbN7xWcarU1Pnm/0mpIDvODBgnRnikvGtI9b14b+gQlFC6VE/feO3jF8BS1S7Khsv8QkAWNHISsFqXbZYz64C9EZv0aJ4WVAiieim7BCmMhZvar7FJoegg7M+hi83v20wTlvnuuAC+LXJaiahysHBDKe877DNe9WUJuSlT0xxbMCZvWvk7x1iuYZmqMn2oQfeOuZqhSH0jg2lZZc/bJWY2TDNG457VyupJnqJUu40Ga9coVY+Dl/pEr1aWoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oxSlUfvN6JeUVHl1k+RSb6917evB1uk3oZs7PfOeJ4A=; b=rvy27KlawbnW7He6fr7eeVqmvJB2AZfefL/39+mvm8qx66Y+MmDc9G0yM5Cq04MvC3TF+OA42hIXLIr4a66JJFolXwi1ik7R+pbw1CR0udtYjLrlrdgWrneQ0oak5jVWnX+6EKGUisiU5K5yUVRaLrN6eYvjzH9kDcN3CjPWcLQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 17 May 2022 17:43:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> <9ad924ae-1a40-6ac4-55ec-a468dadf5dcf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9ad924ae-1a40-6ac4-55ec-a468dadf5dcf@suse.com> X-ClientProxiedBy: LO4P123CA0511.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1e369dc-f309-4097-e8b3-08da381bf61a X-MS-TrafficTypeDiagnostic: MWHPR03MB2765:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JZYnr4BGkLfvYp/8Gk2wwJK09fPXhWBY/2r8QrpKSemm4l/QYkxqZHyUYjcs3Wk+FTyv93hxcTdeU2BGnyoUnW4u96LKfghtKy+voegrc2xZ/MDMY1VmcHqUh9iJcKrsa6FhSgTpww6aU/61VPXb+TuGR04JkuO5iq1RXT/8xawqnrDX2P71AuGWBKxguxrX3W0i+yYtc+rLs4GrsllmTwq6rpln7k8rB0Tn+sz54akHOx2VYzQGqvSM1GueXn0UV/9qLZN+2wgiA8YOvFnRvJp1autDOcKlvaQ/S8pSLUZryIo9C75RBnz9FGD2uAfcsjhVnELaDTYElFOX/9xSSHmqQ84vU+BfFNeht29aXur+vnYSUu6KrV9GVCC/vNa5S6PHz10756GI8d2nMExyEaOI0pjABcCwJauWFGWfHXjnMmAB4dVOse8rjHvfzY2qVMNJmbMsFncTrdfwUrGQ65EJcVA2WcAXmE+R+n2ABikhCXARS3bIePjM0aI1rJIj8UkJ0D4+yT1efNcrFWzUYBiOqxCkumaaoHhyje3FVbFqFYjPTQ1yZ+rhpTvLqK2XfdjWxFPYfGDppJliUMWamlPFs333TQuUnY+FlvaCMeJ8HWb3+0v+ckIBlaYNP3pD/WeJ5soP7HxyJDc25Gvxag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(85182001)(82960400001)(6916009)(2906002)(4326008)(66556008)(54906003)(66946007)(66476007)(6666004)(508600001)(6512007)(9686003)(8676002)(186003)(6506007)(33716001)(86362001)(6486002)(316002)(8936002)(26005)(83380400001)(5660300002)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1NPVDBoRDRhWUxLK0RIbURQcUlJd3FXRTNYQzFncEp1Z2Y4Sk1FdkdyeXdQ?= =?utf-8?B?RFdHNUYralRWRFpBUHZTR0w5bGl1aGlIbW5lMWQ3TFZ5VGNKVE5VQkh5T1pU?= =?utf-8?B?MVpydm05VUNidXpwK0t5TGU2TFVNUWtaR2xBTnd3V3pYV0ZYOGI5RllBd0NZ?= =?utf-8?B?aFk2aHA3NUpOMTZNcmNOK2FnSXc3UmRXRkJ3Vmo3Q2d1eHJLd0lNNWo3Y1Vz?= =?utf-8?B?RE1VZUJ4enBOSGg5SGpMNnlqK0FOUnB2VktvMkhQWG5FVjZSTkFpM3R1VXFG?= =?utf-8?B?WHZnZy93amNyTnVCc1p2MCtEWjRNcTNmV0ZoSUpIdENidzk0WGhNWVlseUhj?= =?utf-8?B?K0R3TnUxYXpZR29Kd3NYOTdNa3kybXNaT2RGdHR1WXNnY1FZV1FraSs3Kys4?= =?utf-8?B?bTl5YUJ4OVh5c0prUmNSUnM2amdYdFFadFVQcHl1RU5EVFNlU08yaW5lcWZw?= =?utf-8?B?RU1KTVBUbVk2TTR0QXd0a2h3ZExJQU1nenQ4Q1VEN2Jwd1dkWDVRZFlpaWFD?= =?utf-8?B?OHJOU2xoSzkxY0JiZEY5NWI2dUxJZHJ5bERJSUNMcTdTR1VocEVGanVUenF3?= =?utf-8?B?ZU1DK0kxb2VxNndzOVN3Q3hPOUU2NU1kTzdYVWlrQzVmc090RG5zbjY1YXBp?= =?utf-8?B?NkxQNENlbDAveWlvRndvajl3MlhYWkFqSml6a2ZqNU5HTEJFMWZ5aXVMTHdJ?= =?utf-8?B?Yld2Y0NWUHJTOUJkbDFmYTI3U25kZmlGWkxFUE1xTGk3ZWdyR0Z0eFBRNkE5?= =?utf-8?B?OFZZNGpvWHZYWFRManFQVjhDdmVBeGN0QjY3QTNGN1E1NTNldHFDWkhXVDF4?= =?utf-8?B?bDY0SjFQOEZwbjVpQXhMVDNmUzh2dWdibHVsZjByTVVRRTJsVjNwaDFEZjhO?= =?utf-8?B?VHFCeTBhZTR1MGRDeDFneERuTXhCMm5wdVcrTVAzdlJjelhDYk02T0pMaHpn?= =?utf-8?B?UGE3MHkwdS9uYUN4K2htZWlvMUNtVjFZVDJwSC9TRmtvQTZRSHJIWXV2enlr?= =?utf-8?B?L2NxaEdZN3JGTytTVTRGUnhWMjR4bzJIWFNYd0k3aWJiNENEeGF6ay9BR1Mx?= =?utf-8?B?YTlEd2dNK2VMNGdmT2hLb0VPbUM2djJVcUFyZUNGaHQ5Qy9TUHQ4bVF4cjRZ?= =?utf-8?B?MjlLUEZPVjJEQkR3dDJybmV0enl4MTlkNEhUQnVYaUJQVTdSaUlmaGttQU5l?= =?utf-8?B?cFBuWFNkcE8wbFdoL0ZIWlYweTJMT09GZTFPM1pjejNqaGhZWnVZbGp3RS9Z?= =?utf-8?B?cGRpU05tc3RlcmVlaW13TnF3SVkrWEVuZTh1TkxXaFBkNU0rT0F3YkhKUFZm?= =?utf-8?B?UlRrTGdieEp1bEI0M2x1OTNoSVdnbzgxZVQ4c0RXaHVkY3ZqcUN2L1czRGJT?= =?utf-8?B?RXVsNXFUMHZtaHd6M09jSHBTemdLaTkzOUlGVHVZYmxIOHJ1STdOMEdPOUlu?= =?utf-8?B?NUJpcmR5N1orZlhPQUpBb0NZZXhtbmYwblQ4alpZSTZHTkdvM2xDdDdGTHM4?= =?utf-8?B?ekp5UWxzTFRGUWlsbWZEVWNQNllEUnI4cXVaQ3VsNnlwVHVQWW1vTHBUV3R3?= =?utf-8?B?eUNlVEVZbDlLLzRmUTJ3OE9kbnNBVXdEZ3RGc3hCWmtaRmFmb3p6UkdMa3R3?= =?utf-8?B?NmIrY1RWZWw4aU1Ldi9TeExrNEN3ajkwZDIwQzI2SEVrcThUT1Jzb05WclYy?= =?utf-8?B?bjFlMnhQOHFoZFNMU1h0cmZvN0Yzakc2Q1RGYmxMTXFQV2tkcjZmTjFqMG1a?= =?utf-8?B?cUFNbkErQldObHRSSFpmelFYaXhkNW9sSDVxaHY1cGlSQythQ2ovV2xZV0Zu?= =?utf-8?B?YnF3ZnZDYXJmU0xxbUpDMCswcER3dTRKaitBTXpLai9wVmZ2Uk04djVqb2N2?= =?utf-8?B?cDRZM2p5QjJXVGN4OW45djZjdkx1OTZkTElsYmIwWCtwaG01cEVuS2VGL0lN?= =?utf-8?B?V2tkZVhQVXRiQk5SU01jYk9MNlFpWVp2YXM2Sy92Y1FpeEpRMXJBVlpzcFpZ?= =?utf-8?B?UDR5Rnh6K3MyNUtmM3hzSklkYjUzeHpxbkRNU3BOVXZrY0lpOG5DczNhejJo?= =?utf-8?B?K1ppS1Vzbm45dEJuczZXMjNQU2ZsM05uMThKMXhLMUd4NmVnUUNvYnpGa1Ji?= =?utf-8?B?THkrZXJyZkovMnkrT1ZSOUh5K3F2c1JVVG4wMnJ3cE94U243VFg3TXpqOVZn?= =?utf-8?B?aC9uWjUvNXpCcVlOUXlvVmEzUG8rbG1YUjdQWFFvZkRBVGJvbDA0SUtiOWJx?= =?utf-8?B?WkJlOEJocmpoSVZabkhLNHJRMlMzcjFaTnJoNWFHMi9PZThCS1cvcHdIWGJr?= =?utf-8?B?WEo1c1o3UE5yUyt3Nmh4cDVDVjdPcTYvT3BxanN1UlpQT2w5V3ZvYXorSG9Z?= =?utf-8?Q?dkeaFslNSaaStkv4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1e369dc-f309-4097-e8b3-08da381bf61a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:43:17.3090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aCvHo/hrwjVeGlM2f59mVTtH/Mp4U4RDlQ3sbi2cebFLfoKF6UvYKlon4PT+3MMLLkhfIkW6HKmKvqiVVjOtYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2765 On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: > On 17.05.2022 16:48, Roger Pau Monné wrote: > > On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > >> On 11.05.2022 16:30, Marek Marczykowski-Górecki wrote: > >>> --- a/xen/drivers/char/ns16550.c > >>> +++ b/xen/drivers/char/ns16550.c > >>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > >>> pci_conf_read8(PCI_SBDF(0, b, d, f), > >>> PCI_INTERRUPT_LINE) : 0; > >>> > >>> + if ( uart->irq == 0xff ) > >>> + uart->irq = 0; > >>> + if ( !uart->irq ) > >>> + printk(XENLOG_INFO > >>> + "ns16550: %pp no legacy IRQ, using poll mode\n", > >>> + &PCI_SBDF(0, b, d, f)); > >>> + > >>> return 0; > >>> } > >>> } > >> > >> While this code is inside a CONFIG_HAS_PCI conditional, I still > >> think - as was previously suggested - that the 1st if() should be > >> inside a CONFIG_X86 conditional, to not leave a trap for other > >> architectures to fall into. > > > > The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86 > > region already. > > But that's likely to change sooner or later, I expect. I'd rather see > the surrounding region be shrunk in scope. Already when that > CONFIG_X86 was introduced I had reservations, as I don't think all of > the enclosed code really is x86-specific. My though was that anyone removing the CONFIG_X86 guard will already have to deal with setting ->irq properly, as I expect this will differ between arches, at which point the check are likely to diverge anyway. In any case, I don't see an issue with adding an extra guard, albeit a comment would also be acceptable IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 17 15:46:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 15:46:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331192.554669 (Exim 4.92) (envelope-from ) id 1nqzOh-0004eC-9L; Tue, 17 May 2022 15:46:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331192.554669; Tue, 17 May 2022 15:46:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzOh-0004e5-62; Tue, 17 May 2022 15:46:07 +0000 Received: by outflank-mailman (input) for mailman id 331192; Tue, 17 May 2022 15:46:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzOf-0004dx-Ou for xen-devel@lists.xenproject.org; Tue, 17 May 2022 15:46:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75b167c6-d5f8-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 17:46:04 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-C864V_8sMnGumE97sr-BCA-1; Tue, 17 May 2022 17:46:03 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 15:46:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 15:46:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75b167c6-d5f8-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652802364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CsmQSkKbLh+KEol/VAm90uxvVIsKuGgi/wDazmntGNw=; b=G6ndxgpbNFYtBDA7c1MPT7hCB/iNRCnBoOqmJiLsWjGK56IK26DOkCLphKbxz1miqz6HAp 8NTFg4KhaZTDnJdQlRXhi6p72oK1EFfdrkaWVuDp/cFSLK/smEU132d9UW4w8XTy0PFGE5 bN1D/F2ZY2SemufOA5R5qFsVpLzXYdA= X-MC-Unique: C864V_8sMnGumE97sr-BCA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXsWAgJa0wHI517yM66Yc+GHZ28ooorWpnCsFBqwswqnQcdDTsAkCAMEjA8nbmqgI3phmE5hiV1UBJ27M5RM1TYEUG129Bdxb8sIZOKqBWaDizLfsW67qWNrg9beyahIcgVZ/o+wC32Byl4r/7J8CJThBVKSZJ3ljsBWa3aepBh+w2/yFzOoarHBaLCKlojENZirHp7UaJFPz6t32J9ZQe2mEo8XFYCe6MlZmfqpW+XTdh7cdT7PCs5a6+soIAiOeotKiuA039PEA9NSkpmbjIxZ73axqUCKZPFz+dvuqXpzc4ctdUuYOjLqFAXgQ5L0/id0pE9wt+rl3jFhQsMeSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OxU+XQIN+20RPe0OAAG0AXWfFvbd33EKNiuLv7QbyXQ=; b=AOBeI2br7DC4+AuuDKbEz5j2fNPELVPEqsLT00MXZ/9CvZR3qvPErZX/gDzGxOTkPGPrNaSHPMhrKQqzJR6TLhQ4sVEGxiiBnh5q/xS6sStMAzBWMjOzh2DbnLCiL7Eu6hAruyhJSgQvWivb+TIeZdC6wiMVjAwkIDLqUtA81NlKbgE3nOGqPTMDUeiOxmFdidhoPxRuH36MKQKWS31M/eOxT8kTp6U+mWFf5Pexin6x2e7qkgfJ8OuBBBPQBQT8go6VJQEiWxRtov9u/FlBsh9dVHKJJVtZo/npzpovOdlih0vOJUvygQd8D6659gKi2wwNYgt2DSTF8EtlLW90Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <12c5e743-0d7a-4866-ec92-03081b127619@suse.com> Date: Tue, 17 May 2022 17:46:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> <9ad924ae-1a40-6ac4-55ec-a468dadf5dcf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0750.eurprd06.prod.outlook.com (2603:10a6:20b:487::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc42cc66-6fc4-4a98-c7dd-08da381c57e4 X-MS-TrafficTypeDiagnostic: DB8PR04MB7036:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Me0RQ0NODhGXULfQOPMEHy2byrVaVMIGB9kNJxsb/0H0fKiiRoNDFvnZWQM9WfC21gPdArvRjCIVOWfaxf5W+/s/AFN6s7vCNpFSi6x9YOjRDhNoUAQPvub0HzEgZbw6p3G1pR2NDg3pnzIFRSpvWcTguieaGw03CRtuDKMtnQYxHhF9yJBGxVpeYTbmnjrj9QfVHYKzOhHAs+9mua1EifU9N/52exN3Hi7wQ9CX+dhFFxcDwpzudCQ3Ft4YCKBRuVnaQttGOmSpOdzRb5j5jIL2cRVvUfAOHO4hr0+sDnaP1LKgFZouBayBOSlstv5DS4+Q1zxVNDWyNSc8mW3Pamf79UwV76+TRmQcXz6bI2RHsmB9Dv8+6ytr1KIvygjhg7+uZ1Mgk9XOmd1a6+T+NjR9KokYjIBpb8Wo9CkBxVekdvi78kJ4bg6QUdx+LMtFS6gHCm9hct6i3lKw8+Xz/wHLq6FJMBNMnE4Jz0SWnaFmFPktNzq5M8smFpOC9/1oZqWtNJzqb9FtzS4UebB3RlMUMHuQyRYV4Z52yL3u5ax6odN2muQDZC8cZ8rQXzP6ic+D8VWqPjuxKYFkwnQJ5EP6cE3D1p2fmOavRSiRKmRzIxcRhR5mi9XQ+jYcvYDFQ/N2obVRjv6klCETy/lAOEP3kuZzqOc181F/HSIQP6meAyudHtyloISNUibgrD+U7nwmR77KVSXEj+Y0V6FoHIGyALhf1bHVvPJIG8dqw30bJSK6il1pPzEnMUvXPTZZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(8676002)(4326008)(66556008)(2616005)(31696002)(316002)(86362001)(38100700002)(83380400001)(8936002)(5660300002)(53546011)(186003)(36756003)(31686004)(6506007)(6486002)(26005)(6512007)(2906002)(508600001)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u9DtHFl+nmtLNncjKQzyulMyWTpLDQSHekiQCPzNgDffnOY21PTVqkh3png6?= =?us-ascii?Q?EoAkwD3uqZFOpJOuJs5UZrZz6WY7pvKVAJxeNrqXgaVOES3DnqmDH2rnxMis?= =?us-ascii?Q?lmCqHpkjcvWQ4UNWNZ6SMs3KclpzpoDz+RVjkVlSzDCmzRKh6ldjipWHqUgL?= =?us-ascii?Q?/QTioXLMoe1AU7grNyfARIYpEYKvenP8KotbdsJB7tz2FEw4vjPLLkwfJzk4?= =?us-ascii?Q?5GtQQi3U/fBo1Vt5RRsK8zT8goyb4L5/B4cLoyxW02jF4GaldrFyliuSqjcL?= =?us-ascii?Q?aL5avZjglKGayGSNaxxIYSepuCB0s3S1XoeREffe6lbq1ZYgkD47UAeVydTK?= =?us-ascii?Q?Ot7zPacVb+o+WVQ1tbbupQxTMjs9t2gmwT4VstTJDRUcoNit2xvSWomRbZjh?= =?us-ascii?Q?ResMdQ3Gr96MD5k6/cR4FmiDSgcmGmlis1Jj431SUJ9ziof5PLEb4m21RxO4?= =?us-ascii?Q?BpDs2i3fNjU5jbvKeR6bJVZGGW2YRENd8lNK4qC35BEV7tf+0YQYLBYGo+jv?= =?us-ascii?Q?ePkcbjyoOR9pKXabM8WTh1ptlr2MA+C+nwzl3zL2uyaJbq4eBr0pEJxh+w2+?= =?us-ascii?Q?gQrrqka0Qub5co7aLPSW1MSSC+h+cr8TJ3sftcFR4PTaiGlwrVQcB4OcApow?= =?us-ascii?Q?HlqL47tEXH1vwyIaCsrkjeI8j7AtCNGGAJGqVubq7Xb56YbP/f4MakEZy6Du?= =?us-ascii?Q?i6nckvDRlSLp+8SHBUwdky/j2P8Zlphrw6V8Rsmgqeldn+Dyo6/PQ7+bopQ6?= =?us-ascii?Q?GUvjSf4Mv/aFSpFklysyzo1CK1g4pvkwlo6II2c7LjXyodaj0HPjNDL89W+W?= =?us-ascii?Q?7sCoZA4Kz2dgfTARiRlNuQJXMtfXPbA0AfDHAyADtzGJRYbJZIsASEuPUOuM?= =?us-ascii?Q?aR5RAhgLK4LuJThZIndWsQK8I70VjIy69CuGDh3X5EHg4+tdg/zNdRGmUKgm?= =?us-ascii?Q?OtRtNtvbE5MwzS5K2DmVwMN9FmQVWA99nFw6p7NqFswnt48lR1WtWxmKxEbN?= =?us-ascii?Q?fC6mEb+XkFDwG1a+lG5GnhifoMVJvA/11s523i1UYrQN2wXjvNkB8fBFl/am?= =?us-ascii?Q?Pxw0xHL6cwzxebPihAXLcdJTzPloWNb716Drz1QStfHMr6+/nMeRcHXy3q+p?= =?us-ascii?Q?L4mFjb711vV6/7C7uMuWwMqGw0o7uInqcyfgl7n0gx4Xkj8QdC5RxOsngfnu?= =?us-ascii?Q?Pji+WWBCWb9nCOBy6z/o0ognhQIg7/8WxtN5zmMZeVzSIzvnUFVpzyY3gkm7?= =?us-ascii?Q?6RSKlhEHmbw7Q3neVZvyuTl1RwhRQ3Hb4Q/WkV2ZcE7b0kuzwyxuj4BeoRZ0?= =?us-ascii?Q?Skm1enV/tERxOXMI7/aaBJJcouAq2u8vClKV8slaL7PQC4V7uVbOH3m7/Maz?= =?us-ascii?Q?sOa/WiZZk+wSoUW9/CU98tmk+Mxr1WSOdMPxWfVWIATU9zFVv2wumFuEmClM?= =?us-ascii?Q?geA4wji5rj9SmxcCep3rt/ABCeXdS5P0D1sPab8mB5xVPYB1iVBM9KicDLOx?= =?us-ascii?Q?QJ1++0xECHZsVb9HVomCw2KfZ+M8KMu36Qbq4LcipFxJmQCdfvRMuaOYs74g?= =?us-ascii?Q?F4B0JaNFsgVWwwcwbswEvlCnHZJVqVAUaKiW0r9d4xVnGtp+GSHRJLtS7e0O?= =?us-ascii?Q?BSxluBYSHBTBdhmuEDe6Ruwls66jc6mq5wo+Tu9wT1Pn62ta7PM4yr3KlNos?= =?us-ascii?Q?GC18/hFqmFjAy73mr3a9uTTElyYN4/CEMvH47GljMeecLc1uL3DPyG3562WO?= =?us-ascii?Q?xGuYmCrLLQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc42cc66-6fc4-4a98-c7dd-08da381c57e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 15:46:01.8071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TyV81MfUqRnUOl5LOrsWldq7+n5XwPqacx6vW5xWiXxNH5CX39nvsQk9BkFgm7WgiWiIqAI9nK4yPN3uKlWPlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 On 17.05.2022 17:43, Roger Pau Monn=C3=A9 wrote: > On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: >> On 17.05.2022 16:48, Roger Pau Monn=C3=A9 wrote: >>> On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: >>>> On 11.05.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: >>>>> --- a/xen/drivers/char/ns16550.c >>>>> +++ b/xen/drivers/char/ns16550.c >>>>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t s= kip_amt, unsigned int idx) >>>>> pci_conf_read8(PCI_SBDF(0, b, d, f), >>>>> PCI_INTERRUPT_LINE) : 0; >>>>> =20 >>>>> + if ( uart->irq =3D=3D 0xff ) >>>>> + uart->irq =3D 0; >>>>> + if ( !uart->irq ) >>>>> + printk(XENLOG_INFO >>>>> + "ns16550: %pp no legacy IRQ, using poll m= ode\n", >>>>> + &PCI_SBDF(0, b, d, f)); >>>>> + >>>>> return 0; >>>>> } >>>>> } >>>> >>>> While this code is inside a CONFIG_HAS_PCI conditional, I still >>>> think - as was previously suggested - that the 1st if() should be >>>> inside a CONFIG_X86 conditional, to not leave a trap for other >>>> architectures to fall into. >>> >>> The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86 >>> region already. >> >> But that's likely to change sooner or later, I expect. I'd rather see >> the surrounding region be shrunk in scope. Already when that >> CONFIG_X86 was introduced I had reservations, as I don't think all of >> the enclosed code really is x86-specific. >=20 > My though was that anyone removing the CONFIG_X86 guard will already > have to deal with setting ->irq properly, as I expect this will differ > between arches, at which point the check are likely to diverge anyway. Hmm, true. What I would really like (and what I should have spelled out) is that the build would fail if this code was enabled for no-x86, such that it ends up very obvious that something needs doing there. Hence ... > In any case, I don't see an issue with adding an extra guard, albeit a > comment would also be acceptable IMO. ... maybe #ifdef CONFIG_X86 ... #else # error #endif ? Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 16:01:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331207.554680 (Exim 4.92) (envelope-from ) id 1nqzdA-0007Zj-OV; Tue, 17 May 2022 16:01:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331207.554680; Tue, 17 May 2022 16:01:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzdA-0007Zc-Jt; Tue, 17 May 2022 16:01:04 +0000 Received: by outflank-mailman (input) for mailman id 331207; Tue, 17 May 2022 16:01:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzd9-0007ZS-CX; Tue, 17 May 2022 16:01:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzd9-0007dk-Ae; Tue, 17 May 2022 16:01:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzd8-0006aO-Q7; Tue, 17 May 2022 16:01:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nqzd8-000398-Pg; Tue, 17 May 2022 16:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tYDIC3GgDxCGFgjHD3AHACnDmPhfcct2iRWSbXA40SA=; b=YZOvrjint8KGMn3a0g+hj87KRM HLIO8/uvjjExg7edO7phdmUU2j7bdJzpsLHaQhZsAFvAcW+vA3UroJGZkNanPZzQ40CRgGKGPy4ts qu9zVpJl/NanoJV4tvCIQj0NuobHug8L6wNeS50DV0Kc385Ne/KClmLV2nobrxWiow54=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170510: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 16:01:02 +0000 flight 170510 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170510/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1064 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 83 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 16:01:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331212.554691 (Exim 4.92) (envelope-from ) id 1nqzdY-0007vP-2w; Tue, 17 May 2022 16:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331212.554691; Tue, 17 May 2022 16:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzdX-0007vG-Va; Tue, 17 May 2022 16:01:27 +0000 Received: by outflank-mailman (input) for mailman id 331212; Tue, 17 May 2022 16:01:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzdW-0007tL-CV for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:01:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a7e5821-d5fa-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:01:25 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-6-W4kNW47LPYKs4VP0Es4TBw-1; Tue, 17 May 2022 18:01:22 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6143.eurprd04.prod.outlook.com (2603:10a6:803:fc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 16:01:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 16:01:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a7e5821-d5fa-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652803285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d5v3G3+BraA82fxzDjxTDmF9Gk+PZLfgeFYLnG4c6WE=; b=jX7abhvrsDsKYAoKxPB1qbWih+zRySorqcPXSK+w3ysKWlpU7LZOOnM7DgoEHOTImt/s7z mBMFKOdTy84v2o/YsHINiMaKKpDZDldWxNArRF7Vel1y9cMcHgLesO4QkNAJqKuVHmiEye hyowsbgF7DoANBPVCDpytOmKUgK9rjs= X-MC-Unique: W4kNW47LPYKs4VP0Es4TBw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB70hOWRanEIeNYo0ESI1xQVxyzPMqCLZhSghlckgaKnt5uFmxM6MRIpvAUPMJ1kybWtS03CMwAsNiltyjI8irYx/c1UhCMvkUlHbER1/0ageHBwJfncabXLawz5fau1PVsPgeQTC93e/ZjQRhzoJz8QwmnZ459IjrrVhxBWozBApCIgpCOPV2POtInMUsZ/WXd0YyJe863hQ5i3nIcu055rIKRP655HMrdqZchNDTA5rWvMF/bbjdALTqmSEErA/YEfc+nbtwwtu2i6InpdmBLmJx0xNagn0tef84PwuO1PXPIpXKakyCvX+QhGfkDDipBaJgwVmfZxhrFMzKbVuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5v3G3+BraA82fxzDjxTDmF9Gk+PZLfgeFYLnG4c6WE=; b=YY2lMyyQf+dEq7lNdDZMxSzBHmwX/rO2sslFIU2O5u5oLBJNkGcaaFFDgfMHMRNNsobs+G0d6R703ExmDevvjNHdjhqTOnOxc0x7Ok68Y8rVZWxmFqZFxYO8TWoNjCU80BLGxRbwv8w9fLZRIe3lRLyYOnYBcJ8euh2NwDJSpH18s31EpDO+8bT97Bj3d5gels0Fk6RmuO872XHebbKDXy164fhQlr7K7c41fAnIcDDVw2NlCqyGTbQ6+dZT2rCA2x417c4vP5UttG4zvXdU/gu+5QTw2R69pCQ7+MYyZQ9bcEmdL3TZowWS8c7JL9S0F1qM7t/fSUtUsf2g2FJC2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 17 May 2022 18:01:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220517090529.3140417-1-Penny.Zheng@arm.com> <20220517090529.3140417-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220517090529.3140417-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0566.eurprd06.prod.outlook.com (2603:10a6:20b:485::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: debae675-64a5-4d34-0949-08da381e7c5a X-MS-TrafficTypeDiagnostic: VI1PR04MB6143:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +N4KJaQW/h5sY4CMYhmy8ncSzSxvEdNFLQWW7e0VZj6htA5k7Wvjqk/7Pv3JkRsbKk6UOWSrqQbWDYc1HKw9wWXylx9mFXEAxKuwAbI85Bwwj/ShZN3SO3JcBw0LvWSv9UUkQ9fBu0fq4WyZMBEtROXDxaZwSdDRe0JD4m/9kwC4YhZ1AsoH+39J0HwJ1POIKjAr9Uk8ILmSZiMFpfkusjbQNr+GPV328lfqNs6B9LA8LYTFpyFxm9/nG7V7JvZ0YryvWEo3jIosDsi+SEH8GoHveZjpvHaKW/o4vYIU9FbINDMfsrLqVrxAWl3D7169AyYQu4dS82Ihi3wHE0fcQod6cf15OE1VzYMW6hbCwotuAUAk804qgqKQgHadm6c2v/wlCbuSNTZtfAtvVPaDEXYePGivhA57HdlPyozHzemPL4zs5JPfKTwys+5UM7gmSSssxmC3Lzw1Y1vqLjqbe5NwR+B09fcyqEGtkXEm6za54tcQqg1TYevnzLcXCcWPGhJ5/u9JWQ8FiFyH9pA6a9GcQfJ6thjYx+AMOeHxvGBxwH2ux4jaqKuLxMQluTLD1QmE9esZQEZchvf7Z7I7r/I8DiUUYJqSXd025YUhQNu9hvggmyO3b+MFMTQOVxUJGdPQKFC4mjAvHiJZ5DERYMY5Rk3hOxR1luuhw0uP+TunxgGwDlEIwDlRbojcxe8pLoH/L4KKXYM3F6jABEeUOMIm4gKm+umGuBTlgv1/GbLyIpis1rluxRJ7jO3WMQxr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(5660300002)(8936002)(2906002)(4326008)(8676002)(186003)(2616005)(66946007)(66556008)(53546011)(36756003)(26005)(6512007)(86362001)(31696002)(6506007)(7416002)(38100700002)(508600001)(31686004)(66476007)(6486002)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEVkajZFbUQyY1JnM0hXWnRkczlNSEJjQjBaVzJ5clVjYm5DTndiVVF5dzV1?= =?utf-8?B?MXZkMG1BWkt5TVhjdExRNEdJdzJxYXk1ZlJQZkJDbExnMmtJZjhXQksyTUVv?= =?utf-8?B?ZWIycmdZTXN5KzJtTnNLdjhmRGV1Z2pUd3l5b29KL3dyeUJuZjdYemx4RE5D?= =?utf-8?B?M0x3aHpad1FsL2sySGlwbElIWkZzSjdWbGU2NjVUQSs5YWZCM2FuZytuTUhn?= =?utf-8?B?ZkkvNVZuUkliN0c3dXF4OUlBQUhGc3kveDJwMkJlckhIMURKaHNKbVRPbGxI?= =?utf-8?B?dUwyd3pGcUFiTmNxOURNZXlleUJLV21ZazdTM09vTklYVE5tMDhLYis1V1Az?= =?utf-8?B?NHBKMkViNndLbG9XYVNReE40OWFvcVVEVE1IbHkrOGNjY2dqd0ZwN1RYMmlS?= =?utf-8?B?Uklsa3B2dncwQmhMTkVFUlBSN2FsSlFPUEpJWHJJM3R5Mm9TMTVkMUZURzhF?= =?utf-8?B?QVFOVHE5Z1dGazJkd25IQnF5NTFpK2RMNHd1MkNwcjFBM2ZDQlllQU9vemU5?= =?utf-8?B?ZlZqRnkxNlkrTlV0bTBvc21uZ3N1UDZWRElvWFQ0ZjcrQ2F6VUFCRE01TW9O?= =?utf-8?B?dGswQzU2THdZZ2RUOWhjZ3RrMHBQY0ZYVlRTT3dYUk9FNG0xaVBBY3YxUEFF?= =?utf-8?B?TDl1WmJ6Qm1tWk90Qm1ZTFNWSFJkc0V1UTVPdWE4V2lMR2h0SnFjODNpV0lq?= =?utf-8?B?YWlTRHlrVXJTV01MalNoa3pkOVNiUllqaHFnQU1BcTB1RDFFcHcra1VoMDgx?= =?utf-8?B?UUhNbTM3T2d1c3hkVlNrZWxsUGFpamJkNEg1RW5hUXIzMGw5R21HbmVGbWRN?= =?utf-8?B?RGpnZG9LWEhCbWVqNEljTVIvSzhvTnBjT0dOZStvU0RQa3A3bE9rUFhBbHBU?= =?utf-8?B?L3l0VHJDQWZkQkkxT050ZTVxMEl0MWpSckR6elN4UFdvV0VmekNaUVFCcXRh?= =?utf-8?B?MERSOEsvd09RVEYwekRTYXF3cEJRbW4zcjRTNG5NTVo2VzVZK3dlcWs5U0lG?= =?utf-8?B?cGYvNjR3OUFtOGwwUXVlOW9VQk0vZDEyeEFBOHR1VUhmNGJ1SVduK2RObXJj?= =?utf-8?B?ZllGNTd6OUxxbGpVdzVKZ010dGJQdk42ZEJQMHhVQ1pGMkRTYkxPclA1OVQz?= =?utf-8?B?UmhwaStORXV6Y211cDgyaVFqS3FoRjZDekI1c1N6Vk9zU2o1SW1FWlBiak1q?= =?utf-8?B?TlZMSTdRUFVZN3luVThibnF1M2VPOW1MV3RqVGlSZGpRbWpHRzU4R080aUxv?= =?utf-8?B?RHVHVTF6U2xIbk1HTXlFTlZaZE8yWFRIZFllTjc2b25rQ2pIQXk5NWJjcGUw?= =?utf-8?B?cHk3WVU0MjVvc2NQWlJuaFZPWGkvcjNxb1VGQXhCaThDSEgzZjJkQU5NSWl2?= =?utf-8?B?cmh3ZkJyNGNQMlBPeWFlTmtLTGNOQzhtVktPU0xRbGM5K29QR1huN1lsUk1F?= =?utf-8?B?YkluVVdENzFGM3hmcW1Pd3QxOExDNUVYYThTREQ2eFJNL0FrTysxcmhYYkwr?= =?utf-8?B?UDRleng0U2lZZ2cwSGFMS1JueG4xVlp2aTRmQWtML2tsbWJPR3hpcmlLM1FV?= =?utf-8?B?TjVnYUYyM0hPZm0zY2xYQXNBMmVaM3hsU3lKSG52R05XOGJZMktRNEpndlNy?= =?utf-8?B?WjhnL255aGd5dnNPN3ZkY2JZUkwzZU1wUFN0bnRlcDJvZ0RuTXpwbVRlYmM5?= =?utf-8?B?NGxJVkpBODE0Z1NVWlVVRW5sTi9LSGpWRjFBdXVWNU5Mb2pDVVE0QjJ1QkdP?= =?utf-8?B?UWRnVndncVphSmxmMWNkTWN4UFZiZlFqOTh0dGdCcjFFa0JKTE9EeWxtZEh1?= =?utf-8?B?M0tFZDNudDJLc0tpbVRUQllRNDRPcmoyV2RyUG43MEhOb0tqaHJmVGFiZGR2?= =?utf-8?B?Uzg4cUhUMkJYZkM0VldPdmtSbzB4UDBOOE9mY24wMlVtTkExK2FUVTAyblJu?= =?utf-8?B?Rlc3dVNNdm1waXpOcmR5b0g1VEpzSFRvZUJQN1FTNjFMUU82MWxXSndTNlJi?= =?utf-8?B?NXlvM2ZRNWJkaVNnZjU5TGlkQVZ1bk8yclFsVGE2ZTZ5STZXNXlwczJsbDFS?= =?utf-8?B?T1h6dGVUZTdXWHhaWm5McFBBODZHdXdyQjBvOG03UEJUODBEb3ZZbzU1T3JD?= =?utf-8?B?d29vdmRTWFZtV1poQmdoUjB1M0dzUmxNV0p6YSt6UHlJZUxicmxSakprRXU2?= =?utf-8?B?VnJoKzlmdjFMWWNZN2FnUmNWM2Uxem4zbEVhYVlPZUtJYUVMc0l2M01TL04z?= =?utf-8?B?eWJ2UUVaRmtMem44ZWZVWWFhZktLbHRydVVGb3lISXRrQ2RFdmZaV3FrUHpH?= =?utf-8?B?bExMbys4UFI5TURXTlJnblh6UWl1clI5dHpyclRRQmFnVzBFaytCUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: debae675-64a5-4d34-0949-08da381e7c5a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 16:01:21.4358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s1yUEZ4bW9Nf8EcIBk11UAyLZ+d5BveFDN3Dw9CmKPLm1emQhGVeQegAjoITLVuLh0wqM2vUX5X26oMyOTby+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6143 On 17.05.2022 11:05, Penny Zheng wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -780,6 +780,11 @@ void __init setup_system_domains(void) > * This domain owns I/O pages that are within the range of the page_info > * array. Mappings occur at the priv of the caller. > * Quarantined PCI devices will be associated with this domain. > + * > + * DOMID_IO could also be used for mapping memory when no explicit > + * domain is specified. > + * For instance, DOMID_IO is the owner of memory pre-shared among > + * multiple domains at boot time, when no explicit owner is specified. > */ > dom_io = domain_create(DOMID_IO, NULL, 0); > if ( IS_ERR(dom_io) ) I'm sorry: The comment change is definitely better now than it was, but it is still written in a way requiring further knowledge to understand what it talks about. Without further context, "when no explicit domain is specified" only raises questions. I would have tried to make a suggestion, but I can't really figure what it is that you want to get across here. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 16:07:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:07:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331225.554702 (Exim 4.92) (envelope-from ) id 1nqzjV-0000Qo-QE; Tue, 17 May 2022 16:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331225.554702; Tue, 17 May 2022 16:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzjV-0000Qh-NL; Tue, 17 May 2022 16:07:37 +0000 Received: by outflank-mailman (input) for mailman id 331225; Tue, 17 May 2022 16:07:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzjV-0000Qb-9x for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:07:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7783111c-d5fb-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:07:36 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-e_fG5dLXMdWsmvaezydskA-1; Tue, 17 May 2022 18:07:33 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6143.eurprd04.prod.outlook.com (2603:10a6:803:fc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 16:07:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 16:07:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7783111c-d5fb-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652803655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BEP/oERyYYK8Ui+6e0nWabj/WNxIr1Uz8aYLVSV9mZA=; b=YuN1TW6CqEU+fzcIU+erpm4QU//8/+UWQyx343mK6Wie78aFKu3FtRU7+vKYsdq1MdmCPU PnjQY1pXqZ1f4Olt5R4wwKAmXrHfYX7DQURgdJosoviR5/P5P+lspKT+E9DQMh7UEH3Je0 +0qCcU7OaOL7pMWgXRQfVUlBInCEZb0= X-MC-Unique: e_fG5dLXMdWsmvaezydskA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WvYxbijBYqyPKO6NaR9X1RRyncHsu9KbClcBIOIPD8tgCQWdQWarzUutFyviyg6wMQzeguSzd2ARO25kJWZ6qFRVF8z4BAtLe+btlyjYR8znjNvgdd063mYypU0EHIh810ADaYSeUd/dmvBFTiRAZ28wz7FWdj+U8SpL+Gh/wolTPUq4hcxKSsW+XgPSXz6w5RI0FRS0f16LJZZrTrSKTHesPrXBoXqpRDbYYh+414gHUEIl2jFYzWwcjr95iiRuY3OQI01QgK5YaxpcGPDh8PZMF7u1ZUQPqohM4czYbQQg1chCEo94ZBivV2LZzRGlChMWarfiD2riX/5IXqJiew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BEP/oERyYYK8Ui+6e0nWabj/WNxIr1Uz8aYLVSV9mZA=; b=LDrXGakaoqm4zjItv3niadO++sIpLSnqFUNQts1XrE5mKZkjxcpFT/dmsxqI9aD7S5Dn60RePwXkB6PzbmnEAZGbS6eF5HeIOdLC5j71Mk1xd89jJSpMxkGT1CAaLOBIAF6JRPWAcB90/hDXPBlmOAL8bU8lr3K1tXHrCCLKqTG8RkLsI356RawWzwPqOKU1wzuNotIXhD9L9G1bMYGte8sS5yDj5CyPAz3qn9TLwZGZBI+Rxct16R4vuxnrYfSggCt4+WmhGv5+CL2FyzIfF0Hp25K7rdES78gJrZIryUBWvFHqXCIE0KHDlLosw80DsNMyWMlxZhlcWZmYhd/iWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <70d936c4-966a-391a-4d12-33b58b502aa6@suse.com> Date: Tue, 17 May 2022 18:07:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap Content-Language: en-US To: Julien Grall Cc: Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Penny Zheng References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> <511fd0cb-348f-b65d-cb7b-effd822c7f20@xen.org> From: Jan Beulich In-Reply-To: <511fd0cb-348f-b65d-cb7b-effd822c7f20@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0328.eurprd06.prod.outlook.com (2603:10a6:20b:45b::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3de536ec-a079-435c-386b-08da381f596a X-MS-TrafficTypeDiagnostic: VI1PR04MB6143:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +iPD2AEWwRARzMMw9Zbw9jPkjkVePX/ariYKHEea4fK1moJ7ICZqsVY7MVh1QMfDXXanYCKc9I+NeDPCqsPg3aw1rik7cowRpf3l0LAfYMGou0t0OgwLY6Dg3eBcdf68MLA1lMBmy4SusAOxgcAIogjI84bOBGnjiyBizcY+pz9+rV93SYjfJBRDAaiNo1JUekvrX2s8q7LkI9otJWjOpaK6MK2g0OaOmE4DEgqhC5daCZP85+DocFRSDClV2A6uUJrC2z/Qxfsr3F6OWfvLLgHRG7lnlPT+p1bxIfwuPl/Zo7eZjvCUKqy/TWTlr6N/LcnhRVronsvvbZocBYfWi/jSbMqzmFninOaNyUNHwzbtnxs0dZqgTJTJaqOMP0koXgNvOfCmFoGev/Yl7ECQehJ3mt05oS2dh6N7oUtbzWajmjHfZx5MjsjFaIgmhvyNf0+cAYcOzQgp5E9qavAqNA1nF/5LX6oHDy/xJ13IwhIw5xtTQoSsCWEQMBm/0AcxEjNhvLC7fxXRV8xnX532rSq5LcHcS7VX/YSXr3ZH13PhS4sZNsDuaqLnXEhZS25qS01dpeBxj1BrcrvPBSTvPiAfaCcN2Mkzm5R8GSoOh9ailZ2sq4h4TUHe17AViAml2GGYt+DSxONpn4J7ykTuAKOjqHQ50Mz3BSEQ8jiy7ln0+No3QdqtD6ZTM9T3/uPINDQbVqJTAGCoS00eSlQsFBavjF9kJlzRPUVBYWaLUub8MQ8asOCQR3oDauXDQAdY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(26005)(53546011)(36756003)(31686004)(66476007)(508600001)(6486002)(6916009)(54906003)(31696002)(6506007)(86362001)(38100700002)(8936002)(2906002)(316002)(5660300002)(2616005)(186003)(66946007)(66556008)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGh0NlpTVTRXM0doeXFIRWQ1Z1hxalZxN2ZOT0lRajQydzZ0UzZuVkF2a21p?= =?utf-8?B?Sld5UjNxM2FsNmN0bzVwdE9kYncwWUdzM0NQRm9HR3kyZjUxWmljWTEyQWo4?= =?utf-8?B?cEFITW9lVE1ydyt6aWx2UjVMUUI3VUN0TFhzKzZ5cE9rUVlTbTNMQkhHN3lO?= =?utf-8?B?Sis0Wkw0TmY1ZUN5OVpKaFBXWCtKT0ZYRzJieUsrSUx2ZDhNbVRKY09DVU5i?= =?utf-8?B?Z1lodHRwMDRQUGVXekNFclhKZDRmTmRnM0RSRnZucFFuYXE0dVlhUmNQd0lE?= =?utf-8?B?YUlnNlgrK25nM09mOW9JamxRTWJFL25QTUhyUHlpYVRsZVVNSWM3dFlzNG0w?= =?utf-8?B?ZHdPVEJRTExsTXZ0dFhtUnNuT2FkNnBHZ2NDdWFTT3BXbEZMMEExT2R1bDlQ?= =?utf-8?B?WUorZDk2T1RnTFRtbEZKaW9XMWEzeVEvNlpSSXFlSFYzLzdqR1NtOUM1UjFa?= =?utf-8?B?Q0lsalpVMkRtVWE5ZGRtR1BTL282OEFjcjR0VlgyUTJ3aXRVb1djZGJ0YjJC?= =?utf-8?B?cm1TOHU4NkNKNzFyWWd5VzNTdXRDSG40VnB6OXk4SmhIbytxZDFCSG1GNkdN?= =?utf-8?B?S0xjUDFIMHNLdmkwdEtyQmVDYnNTR2RqVFY0eEo0aFdnaFF5My9hWWF2VnFT?= =?utf-8?B?UTFXeFY1MW1GZ01BK1JjMUxUdFB1eGJGdkxRM3JzRzdGOTVpNDdnT3pMS0k4?= =?utf-8?B?TXJaNStTbmxyc0xseGVwNisyUGVaSFNKMDZWbmxtWFlrb2xzR01HSTBDMDVF?= =?utf-8?B?WUpNckdZYlgwejNtT3FMandaZkpGZDJZMkdiY0F5TCtFbXhhYUczQU82bEl2?= =?utf-8?B?TkFxaTB2dXJibnpWMG5RbkxQaVNWYmdBUmhVWXhGOEJURyttKzZ0RUlSdnNG?= =?utf-8?B?cjlLa0kwN0w4ODRFU2p0TEFsek8yWEpybThsUXdpMG1NSXlPc2JKSTltb2Nn?= =?utf-8?B?Yis3Q1dMUW5ua0hQWXl6RUVSZGFTTGFIV2xXam9WeWV6QStSdmpCZTFYaGQv?= =?utf-8?B?Nyt5TW5pUzdTOUxqczZSUGVMN1R0cit1VWgyVkVRYWhDVC93Qks3b2NzYXNT?= =?utf-8?B?Vnkzak9JTVJtT25PdngwZ0dSdXhWbS9qblpueG9MTEcvUmhGVTlac0h1UVlH?= =?utf-8?B?WFA1cVhSU21KQW1aM0R3d01jZ3F1QlNsbXBteGZrcnYyb01jenRaeHVvVXhq?= =?utf-8?B?NzZCZ3ZhV0FjS1RSMURTQnJUcGU4UElIN1YyZGtJMHlxS2lzZmw3MDFXaUxJ?= =?utf-8?B?V2NrbG1PRHNWV1p1QXRoQWN1cHROYktOZFUrbDE4TTdlQ0VCNUN4TjNxeUwr?= =?utf-8?B?alk4VldMd0dJV0ZCMTJ5bVp2TmU5TlpzT09oZHNGckR5dGtFVFRlL2Y2aGJw?= =?utf-8?B?dlpydUxGcHlncnN2aXIwb1JaUjhGaTNVZ2E5cURBVkVjVTh6bFBuK1lqZ3hS?= =?utf-8?B?OStEMlBWZWdCMHpzS0UwK0xYRDQyU0pEQ2RFWDlLQ3BxRDZOMEFuaEVRWDlE?= =?utf-8?B?b2hqUC9EL25vak5NRHVzL0dqZWRuVmxSelMyek5FNi9TRE9LUmJ3TG9oaXdT?= =?utf-8?B?ekF0Q1N2QnQxSm9WbUloUG9TTXhYWGRJRmtaVHpSNEorckxBRVVPTk52SWdG?= =?utf-8?B?YmUxL1B4TzJBMnV0T1EwcUhBWEtmQUZmdFUwZFNCZW1RYWY2ZUhnQXFNRnBV?= =?utf-8?B?U2JVamp6RGtSNE9mbndZamNsdzhySUZMWHpRcmUxbnRQeTVHRUZuT3Vtbkp3?= =?utf-8?B?Sy9vdVFXRnlURkhiM1M3WHErMU1lc1hiWERNM3BVTFhTUVRCUCt1Ynlod1Rn?= =?utf-8?B?aTYxeXVPSEhqT0tPcEdJdnBHZEVEaEVKbWNTYWVDNTRVY0lUWFpnK0FOcjhW?= =?utf-8?B?dXppaEFjTm9ZN2dDNzEzSmtrNjdicVU4SVlsNnZCbHhXc1BYdzVNMDFSYUd3?= =?utf-8?B?eS9SYjZPSExKUVBzYVA1WVpmVDZUajBaY0FjYW53aXZQbldSUFVIMlV2Z2c3?= =?utf-8?B?bHE3cDRmV044eStSaUhkUnYyblZJUDhJNzd0b05nVW9xdERuRVovYWJGbXVu?= =?utf-8?B?cjJtcFBRVDhsemxLVWg5aS9EUnZPcDJkYnRhc3lMYTRTS1lsN1IxL1pKR1ZG?= =?utf-8?B?VlZaZ0VpRS9uNDExNEN2T3ZFdjgyZjdWWTdmUnhZMU9VYVNrSVcrcXBkWEdk?= =?utf-8?B?citNeGk3OGNIbUsycGptTzBqK0E0U3hqN1g3blBXNk1DeDZCWkNnMDZMQWFU?= =?utf-8?B?NDQyNmZDSWIvR1JZZTcxK0xMVjRtK0tGb1c4RVJMelpKaVI1S25WazVTT3ZR?= =?utf-8?B?ZHFRWE9tdFJYbksyNWk3K2hBVVJ4TDU5OWxTRzlHNDlYUUJpeFc5QT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3de536ec-a079-435c-386b-08da381f596a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 16:07:32.3027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 40slzJwL1wZz9twml84Uy1utkjKXwZRDB7r95H3sH7G+Q2i+tgllZ/3jplUqZpf9lGO5n7Scp20dBm+mQ6bGhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6143 On 17.05.2022 11:28, Julien Grall wrote: > On 17/05/2022 09:21, Penny Zheng wrote: >>>> @@ -2653,7 +2657,8 @@ void __init free_staticmem_pages(struct page_info >>> *pg, unsigned long nr_mfns, >>>> } >>>> >>>> /* In case initializing page of static memory, mark it PGC_reserved. */ >>>> - pg[i].count_info |= PGC_reserved; >>>> + if ( !(pg[i].count_info & PGC_reserved) ) >>> >>> NIT: I understand the flag may have already been set, but I am not convinced if >>> it is worth checking it and then set. >>> >> >> Jan suggested that since we remove the __init from free_staticmem_pages, it's now in preemptable >> state at runtime, so better be adding this check here. > > Well, count_info is already modified within that loop (see > mark_page_free()). So I think the impact of setting PGC_reserved is > going to be meaningless. > > However... mark_page_free() is going to set count_info to PGC_state_free > and by consequence clear PGC_reserved. Theferore, in the current > implementation we always need to re-set PGC_reserved. Oh, indeed - I didn't pay attention to that aspect. Which then, however, means that the comment also wants adjusting. Jan > So effectively, the "if" is pointless here. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue May 17 16:11:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331234.554713 (Exim 4.92) (envelope-from ) id 1nqznC-0001t1-Dw; Tue, 17 May 2022 16:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331234.554713; Tue, 17 May 2022 16:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqznC-0001su-B5; Tue, 17 May 2022 16:11:26 +0000 Received: by outflank-mailman (input) for mailman id 331234; Tue, 17 May 2022 16:11:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqznB-0001so-Fu for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:11:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff9edd14-d5fb-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:11:24 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-bTpgSBWuNpCpTXvwrq0TIQ-1; Tue, 17 May 2022 18:11:22 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7554.eurprd04.prod.outlook.com (2603:10a6:20b:2da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 17 May 2022 16:11:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 16:11:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff9edd14-d5fb-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652803884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YZzeCh0pPrXtu0rUV3W/FXa8ThGf/mCGGbhst6Ctq+0=; b=ZE937RgjAKRX5AouLuWIH3YZfz7pcfd0fXnoyT/g/WICpq2AbeHsgPgYIzsN1cbyJZCnqI pMP32mVgVMwDEfIMQn4icLTJoNB5A3O5SQ+w6JmZOVooaMofYIFlxdqspA8Sh5S+FC3PRQ X4fRUsm7NLVanLEdhpwpGMO8wROqIAQ= X-MC-Unique: bTpgSBWuNpCpTXvwrq0TIQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OL0D+ttCdbixlF6c0YHMUUlteUXI98/KWX81IW7LoT+3joheLbLRbOXKYfRPfIIhNVcrPCDPl1c/O352tJOMPPjGAWLfdJTB1cTa5Gh7jYD7m0cBoeyYh9N1fQxpSDnjGqXMy1pdw1TXMTHdalhGkyVZGIFZTJQo6wPJpXU9rdLNwE4eqFv+jKivNqLcSHR+C2klWuoswjD/XcNXePco6aBbrVc3ES0IF6Hp1sxw2XK26A9ywf3gBWERDQcOrKDwzsavlvYIpCq2gAOdDj0Ig8xM/69P/Jl3KhKwWjjtKI1s+HSt3+PhnRw6OlCzzJIsBKhReQpE/cL9HTuLbuI8Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZzeCh0pPrXtu0rUV3W/FXa8ThGf/mCGGbhst6Ctq+0=; b=LeOSfk+vmpqfbXgQrGPQdxM3c6HrpXejeM0tV37IUNht+KP5qhxsIamOlZkrcl0BPXwXjxuSd4JTQ6R95FLXkFu9cBVm3tiaxrt/7RG7jgFv8Ci/2f/AKn+Aq2wmoXremwyXQdMj0X2lCK1Y4NHZlMHG22INRZV/a5weACcdkP2OTih3zepeKVjMaYbsOZD0IHx1spa/HbVYcEwbAR9y1m+sEjCl5vS+4rdFvglSawURwZOfLP4v/iNyn670SO7T7Cx4tC/wjPAHzbvEioRgqv1OnreTtT+kDMga8wifm/lqH3y8yP4ERv40Md8RUYJPJCtBW0jpHq0yMkqrATtvBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20dd9308-3cdc-4ebb-61b2-e0a71e808697@suse.com> Date: Tue, 17 May 2022 18:11:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220510022733.2422581-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 69389720-60ce-4841-622c-08da381fe1ad X-MS-TrafficTypeDiagnostic: AM9PR04MB7554:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WIM4u/KPhY39XRrnlb8S9FI+GGyFJMPlAmAK5NrmEbMvN2FlCtq7bLMEgoW2Xwz47KTZQ2AI7myJ2ebdnewrdiC08EX4/+Gxxi8OEDvS7oBcoQTtTBaKE9jqKLnNMTa8qI6zw85/joKQM+Vuit4PQkqVtTUPGFntinWDggovxbPvjJWOFw0nizf9c8K5QZsTQWeMWnW+N7WiQxwG0xIaEV7lKY4elVVjfnD9OnfGGAssCrkBYhVHLe/b6DqzkeeDz0I0b19oaLSERw2TSFXfm8d/C5PLAKUG0ezFkQN+6ZqdfRc1NWocxNVCFfAsJO2m5crAHT2seK0Sec41rUEXohxwxnsiiTQvah5ABfKgfbKxrtnSNmPf+nH1uWOPOH/vWp3pziPATwXmiFJx/s/MmvooA0aj4Clxb5nOIHUSHLDDvzjNzxpQd91e7tPfdxaNpNNSiVlwCth5j27VCkq3Fn53Wz9XRJzfdl/INdUnj157QUbrQ8F0bCpKCgjmkhGlXm9+rozXsa1EhHnEtk+8ZMCQiR1ejXJZkjn+0+6ewkDPEHB4gVg9tOEEWn8Ln4zTvcev1NPS/YqVqzjeu3ogFxqUwtkJubXy7N3LLtF+coqEGr68hxf7TAyNvKSTPxortRNKUfIX4iW/Ox0iaEJ4sFzINTRpKt9ZO5+z/7I4TT5/3NsPAH20J+493bwJYqxdZQ540cLTWBNQ3Hfj9Lzub6xJ8EKI1brv3uL3xoGnS+E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(4744005)(6506007)(38100700002)(2906002)(26005)(54906003)(6916009)(8676002)(316002)(86362001)(31696002)(5660300002)(6512007)(6486002)(36756003)(2616005)(8936002)(31686004)(186003)(66556008)(66946007)(508600001)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXdMODdLQVg3TjN1U3BLNEFPKzl3U2FIWDZhdGFWY1FuWDRuVTJpSnI5NlhN?= =?utf-8?B?VXFuQk5Ec3JaNTNPVnVvS2VvSk52YnFsNWRlM3p1TXB0THlQeFBYdW5jTHRO?= =?utf-8?B?WDlMa3dvT0VNQjFrUGoycHhQaGlNa1VBeTdTaGc5WldTd3grd3haTThWTGE4?= =?utf-8?B?a1UvQkV3K3QrWXMrc2UzTHVtMy9IcEZXNjlITDVma3hqMUlQZVZPRi9GRkZH?= =?utf-8?B?WVpzbkNxR1lTT2QvZzBaU0VqS1hiQ01kU2d2ZURsMG5Cei90Z2s1V0hvb1d6?= =?utf-8?B?TjUyRW8vQUlmek9DNEJBa3BwNU5Bc3UxSSsyQWdSTGU4ZlZ5S3hsdjNvOVN1?= =?utf-8?B?Nitnbkppd0ovZi9pWE84aW9uZE9GZ1ZxRmJ4OWxNUUw5UWh1eFBXUzJMTTBz?= =?utf-8?B?K3N1bi9CU1A4Yks4blh4WVloR3RkUVVmWFNEME5nU1poeEU3Z0lJVzR5Yllz?= =?utf-8?B?UW5RZ2RUczNDUmFNVk1OOGdZMFQraUpQTi9mSkJEQ1g2amtTdlhGOThocVlW?= =?utf-8?B?NDN0MUdDYUwwMTVuakRaT1owLzRvMDY0VWxpQjBBaVJhdWVFK1lzYmgrMEVs?= =?utf-8?B?QjBPZUVGWk5aM0xxQ1VDZi9pMmlVT1BIdWJmYW9jak44ai8rVnJMRWMxL3Jk?= =?utf-8?B?K3NzajVVMXNDanU3V2ZiOXAwWWxzRWtwV1ZEWjN5UHh4WjlaWWFVbE40MWRr?= =?utf-8?B?OU16OXZxNFBFRExhVTVCWjZxSU15QTA0TEpqWnpYS0FmMTJpcFpnT2FqMllV?= =?utf-8?B?TE1BUUNiRzdaZ1o5dUZ2NDF0SG1TcWZBcDZNT3J5aFgxMGNZYzVNL3ZRbmsy?= =?utf-8?B?YUtSWUg4amZTOGx1eFlwUjZKdDRkNUVreUFxTW1rY1NHSFVnNFAzSnF2TUtu?= =?utf-8?B?QUhwWU1lQXBBQlErWDYwOUNrdWxhU3AvZlloaXdwSUttTGpRaGhOOTRZemtW?= =?utf-8?B?TW1RTWM3a3JjZU5LRGdhYzVhYWJwcDFJTzNVSHhvMjhUWndBd05VeStkaElE?= =?utf-8?B?OHcvS0pLbHE0OTlYY3dnSDJlbmlCMkdwSjJnMHE2cXZVeUtsd2JYMksrcVRI?= =?utf-8?B?U0VraTJPRzNBdTk2TUpxelllbE4rMDQ2Vm0zUXN4ZWRsSWp4ODRZSjVjVEdX?= =?utf-8?B?eGVlay81TDhEcDZDaDRIbkFIdkNWZXkyZ2haZlZzS1E1UXdDK3hkK0ZxMFVP?= =?utf-8?B?QjF0L1RRUXZWbEtOVkFWejVzT053a1dsd2NhWWlOZmVPY1VoaG8xR0ZsTVhO?= =?utf-8?B?Ry93emY1cnBRMmlsVWJJckxlSEp6OG5qbXplQzBxeERsa2IyNkFJQWN5djBF?= =?utf-8?B?U1hOWjkyWDlMRTY0VEdrMGRvZzVtcW1JRjkrOWVxcm1wRzdkOXJ0bVNxaGxw?= =?utf-8?B?NEtBbEViYzQwMWFndHNlNmhWN0pwYUFyaVJiTkJscmRZQ2pCYjc5WThMbEhZ?= =?utf-8?B?UjdKWW5VQ05mY3d5bkNxZkdITHNzdUhyK3Jua1lrMzFPZHlhRWQxNjNmdldT?= =?utf-8?B?MTg1YnAwVEIyeDI3TjlIRDlNbVozTithWkYxdE4xVk1pNXRNUkZMYktscGVY?= =?utf-8?B?U3dYWWRTakxKSlBBV3ZVVksvdHp6UzdsT3E3Y0xoMExkMVhMRlNJL2dMVDZI?= =?utf-8?B?QWVQajIvRGtsVkQxU0FBbWhyWWQyTEE5QkxzQW40ODd4K0p5UTlFdCtxbDFk?= =?utf-8?B?OEdLN3ViZW9KM1JvQ2kyc2ttLzIvN0hFK3J1eDArY0VycXV4VXE3NjFPcDJL?= =?utf-8?B?S09BcXlad0YvRU0vVGpYMFlzS0xLRHEySVJ5eFd5UlVSeVJTU2Y2d3dQMjU5?= =?utf-8?B?YWpvNlA4NHdPRnlmTUFQV3ppYXA4Wllyc091aFdDUmdqQURJbC84WTlSVU9J?= =?utf-8?B?NjJkTG9ZMFgva2g1cXhQOW9rVC9RWHZWa3FJMDJVRFg4cmtSRTBjeC9MaW1V?= =?utf-8?B?SHFKYzJpNkRlWDAxVVVmN0l6ZVFoeW1ObzE1N3FHZkdHcC9Cd1Y3Unp5b2c0?= =?utf-8?B?ci9oSlorTHY1QlI1RUVKbHpNVnVFU3VETEhiZDVxbUkvT2ljMW85TTNhV3oz?= =?utf-8?B?OHVTS2xsUmh3eHQ0TjloL3lJWGNQd0phWXBjOW16Uml2eWZYdGVWSDdMTktn?= =?utf-8?B?bXc4UU9hNi9POGZQaTZTOGdqNkNMYS9QV1hzVUppVkFtb1JCQ1JCQU9jaUlm?= =?utf-8?B?cDRxbGZLYUhjdVUxN091VC9pV0lqZDFTV0xHL0czN0RFd3NsQkZ3RGtxZWVE?= =?utf-8?B?WmFWNmZiUXJ3dTY4UFpBazlzVGZyc0ZaYkcrUFJnOXhLaHlzZDEvcmk5bWhZ?= =?utf-8?B?U3h0VWthVWdTU2YySmpYTGppTWVoWGdNYVllcUxQWTkzZVhQQWJ2Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69389720-60ce-4841-622c-08da381fe1ad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 16:11:20.8662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rTZTyshDRihO4FeRd05UEcu54vrHKUUvNRoweY8yBrWA3Ba9MIqUX/tqlrznhTvggdPrW5nsfBlPAVESjGKwog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7554 On 10.05.2022 04:27, Penny Zheng wrote: > @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > +#else > +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > + bool need_scrub) > +{ > + ASSERT_UNREACHABLE(); > +} > #endif As before I do not agree that we need this (or similar) stub functions. As already suggested I think that instead Arm wants to #define PGC_reserved (to non-zero) only when !CONFIG_STATIC_MEMORY, just like is already the case on x86. Jan From xen-devel-bounces@lists.xenproject.org Tue May 17 16:17:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331242.554724 (Exim 4.92) (envelope-from ) id 1nqzsa-0002aC-3S; Tue, 17 May 2022 16:17:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331242.554724; Tue, 17 May 2022 16:17:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzsa-0002a5-0E; Tue, 17 May 2022 16:17:00 +0000 Received: by outflank-mailman (input) for mailman id 331242; Tue, 17 May 2022 16:16:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nqzsY-0002Zx-Mn for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:16:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c52f60f3-d5fc-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:16:56 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-uIE3w4ZqNyq13vbe5KGkGw-2; Tue, 17 May 2022 18:16:54 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6794.eurprd04.prod.outlook.com (2603:10a6:10:11b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 16:16:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 16:16:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c52f60f3-d5fc-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652804215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+SLWDNDM900chpyBUlVFtLC/KqH7c87vTOavH25HHc=; b=RYskU5EjTV7bQ8dPI3HuiSK2Uk30Ui3g45QFevCxZkPp4YBkDqLbDkaaczr5r9xilCVkc5 fuDwMrSjEmS2WPzd3vScG8JSiKI66gKFYPKJOzrXmT4oghzWF17DzynrCPrUzBg9LXAPqd a/2X7mywKU9yHctIY1SKYum5C7ZZQyo= X-MC-Unique: uIE3w4ZqNyq13vbe5KGkGw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SqxgMzSkhGfR6zzlFAPEpwVUazsRFrDrbZLIt7bXGrOcNYmjS2jho7fR2cGyPegkBMnlE7j4HFJFjU1yZQtH/ly2gK6r0S3utt5apKEhKoR2GIEp9GIF8QoODHjVfEJuEdTTswWcIbul8V6GiM2I1wt1/cXYSIeoCsVilxiDttXukPg/PHSqpNaGIsgpvdci0+tb+uM/bMD2O836v5oN4wg/g3NvLKaAcdOpyP3rQNLlItp6+XG497qyvwfz05+EbwLXmw3OJLnidSgbwLFHg4nEmUkMbpZWmh3wDl83s7siZd9EjnFspe1O2eJIEHpDe6Wp4Qxb1wtSWDtSVjK6DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+SLWDNDM900chpyBUlVFtLC/KqH7c87vTOavH25HHc=; b=JuDxTOySUe/RtLqeQOX9EpwA0m1ZwflK+ThHo/KajoYJTAkX5hYUZbTv0LuwHgx96oPQM4Fp8K38ezI2hnI2gdtiAIYcTVbmVzW+U2WW/ZC9PQZ+RWVlirmQHCdoNXoY+5b5KaBwqvNuGoDzGZnvPtdAkNV5hLniT21n5RmN4v+SRQqNIj9Yb83EUsGfNwB635n4FYDeJdFsrN3OdyPLJgePslo4xLGvlF+kK6WnH1AQ0aSVyFufGIJswRu5NF+qpept3GbS1N3LMUr8aexWJeyp/174TASieY6Xome5wG81H/jkNS1IsUc/0luqmcwhbIhwUbi3rQHLtuDM+ot+jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ef3b2dc-ab14-d48e-6590-b35efbab863e@suse.com> Date: Tue, 17 May 2022 18:16:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 6/6] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220510022733.2422581-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0502CA0051.eurprd05.prod.outlook.com (2603:10a6:20b:56::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9eb676b-d3a6-462f-3aad-08da3820a7b8 X-MS-TrafficTypeDiagnostic: DB8PR04MB6794:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P70Zq/uFtwhZphtDSVKaL4rop1rymO34t8GiinPLqg+VIKMhT6p1SHdM/JD5nYgZ8HJLm0y2UguErsgG6CDF3HmwOut/FdR2XUbLP6lk0hnhF0cht5ptXqsKQXW2ps/mVH7iR/vqAQaSZO2qbpkaZz8Ne79PgPs4oHCdIUCndbmUfiMY2XgQoULBF1yWUgwamHgqGf3SrxycOOuNi0Qe9ZqCnKQG9hCxvFbIWl6X9dc28OKSzBw1Z8pVduNoQGXp4HmUNlPrX5xWFpPi/VGe/6mfPr7Wngp942/0s6V5ALhvvbECom9nWTpZBnA9cR/4eHp6Sbyl0gyFjQmvnCynI7pPsNZ96M8yaIUBQZLcY7u3t3rigbURp4RPVN+RprAnnsL0BI7bTI8P5BfuF+GnSkv65Ci0abeQsSfslzahLRczkUyvs/tvRKhzTQZ/XXa+oT1YJs4CfUCve5mLRwP9KrbUp8ZT0U8sbjYQcScPb3VFp2yhMin8ZqtdgXydpS9kd6XZe9yAJu+HzBGTasdKkkvYbtiQi7Le+DGW1U5kTwCLWPa0uMObaR17wcmh3RLjyfEmF+j9mNz7UJklKrooW4k9lGAriMxHgsPNETkMGWu3s875PBr51B99bx8TN2rrrb+GZL9VV/2Nv2xoP2ctOiBjAGKjHhy6gLTH++dcB2YcNyArk+BTfzpIJTcWVIu5ZW28Db1xlYOyo94e/1ySnEXtFULFBGK//wiPv2MA9QA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(316002)(26005)(6512007)(8676002)(36756003)(2616005)(6506007)(53546011)(66476007)(4326008)(86362001)(31686004)(5660300002)(8936002)(2906002)(508600001)(6486002)(38100700002)(186003)(66556008)(66946007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjVtczBEUG9mSlVhcUZ3ZmE2dVdFOHBDSlBpMFgrT0hkMm1iZlAvYVM2bzJJ?= =?utf-8?B?TGNXZytmbjlMeHFXZS9PS05jWDh1T0t3M0dKU1VaZFUyc3dyb1FVV2kzZUVP?= =?utf-8?B?UzFiU251TlRFTExmNmplRldoZ3BhYjl1VmwwUnFCNXJ0VjE3OXg0RkxuRHNx?= =?utf-8?B?ZGt5ejNsUDFVTkI1eXBTaE0zVFdhendBY0NNZmhrNi9YenNiQ2VyMWFDd3hF?= =?utf-8?B?a1ozYTVocytyZFUreEs0RnlSdVppci9oUzVKbEdRa2VyaG1uZTlSVFhmdkEy?= =?utf-8?B?L1ZQdzc2YXlVTk5xSU5aOVZvR1lRUk8relZMNm1RS2krUmpoU0FLWXhtY2lI?= =?utf-8?B?YS9xdW85N1IwYzNZTlMxa0d4OVQ1VUc0SjEyd2diN0tYQ2tNcmpUZ2w3bG91?= =?utf-8?B?Ymx0b3U3b3MwSEV4STVoMy9ycjRlaXNyZ2ZpZ2c5UTRlYW9mWlgzYS9TcENp?= =?utf-8?B?RXhtU2lWck5VRDR5Z29FYWZlYUdVeDl3ZEZ1dkJob3Bxc3hCMk84Sm5tZFRn?= =?utf-8?B?cVFZRU5rc1AzUHlpc3Z1M05GODY2bi9aNi94U1ZnTlAzQzIvY2daaUNEaCtj?= =?utf-8?B?VFkzUXJtZndNZ1V4b0w2WDFkaG4vUHc0b0Uwbkp0aG9IcnBtZVpZYmdyVmxK?= =?utf-8?B?N21wR1lUS0tjdkZZN1FobzdzbGQ1LzVnTHRQdkNGSzBSOS92VTh2cU8vbUdq?= =?utf-8?B?VEhNMGRLbUhVeENVTWR1TWx1TXpxTWhMSzRCU0x3WVFEb3NTVDE3MkNJRTN2?= =?utf-8?B?OFNKam1CWE1qeDNkejNVejFTL1BQRjN6OUZ6M0J0aVNWZmhmcUZSTjBaWG40?= =?utf-8?B?Y012RWJMUHp0cVNBNFB6N2pLaCsyUUd4cmNMV2JENWh6VDMwblNtZFA2WVRW?= =?utf-8?B?NFlmWTM2OWU3MkNKcm5xaksyRVl5dS9uQ2lLTExMZ1dsWGFQa3huc2VQQU8r?= =?utf-8?B?cXJuTmVtOFkvRytYK1BmU1RlY0RVVVlKSm5NNGN3SU0yNzg2aWpHcGJsT1Vt?= =?utf-8?B?S3dNbVVSWkF3YmNOVzlVRWlueTRvS3IxWEZ5U3JWVVJ1eTl1RTM5eVFVVkov?= =?utf-8?B?NG1Fc0gzQ1JEeUpDWW0rc1UxKzd3MFN0TE9yb0NIYjFvLzNvTDFTamxENzcv?= =?utf-8?B?am5SOUNJUlErZnhHRDI3REozQzFhdUwrczVzVmwxeFdRV2I1ckhTbzVXN3d3?= =?utf-8?B?bXk3YnU4bHN0c2s5MVpKU1ljSlA1Zjh3RkQydGlzbmsvRE5jYWdQVjBpOGxB?= =?utf-8?B?aGJiL3BHcExzNTdSTnovUGFSU2lxTldKQnRvY3prUHRoencvOWZ0NzVkc1hq?= =?utf-8?B?cGh2WDhaTEdUeVFYbkkyWjR1NkZ0aStCMndaRWRLS2VKWEtQTFY0T1Jqa3M1?= =?utf-8?B?UTJuSnF1SE9xUjErNHNuVk0yOGxtbDZlL2ZrWm10OFd6bFUwajc4aWQrdDJi?= =?utf-8?B?TnNTcklsK3NoTFZYcXRVMGkxelpoSVJNZWRsVW9LSy9JQ0wzemwwYTE5a0JN?= =?utf-8?B?VEREc3Ria1JPazZrQkJUKy9yR3h5ckl0RGUybXZjem1NV2toOGs2MFBpY0kz?= =?utf-8?B?UFBWZXVCamh4czMvTmNSY21WdEJOc0c1bUJEODZPMzE3S3hkZGd3MjN4UERY?= =?utf-8?B?c2FPWnNmd2U2S3lkUnJhUGUwb3AzUXArZFZPYXZ6N3IxK3ZFMStQNEVxclVX?= =?utf-8?B?dDZDUGhpWm1zZ0x2VC8rSld2ZllXUkdGMVdCdzc2VEdDdVJmbEFrQ1RpU2hY?= =?utf-8?B?MW01c1RpeVBJdTdKeFpIMmo0bGlwSkxsRzNwandiWUMzQm84cGIxRG9aRm50?= =?utf-8?B?ZTE5cFFrK3dUaDJiSVIxK2M0Z25yMjRYamc5eXpCSU5jVXoyMjVZRkdJWUdT?= =?utf-8?B?bHNQS2x0TEFpTFd3emxuQ2RjckhTVUp5M0F0Y1FtT3RVSGQ0RTJCcjUvR0hM?= =?utf-8?B?aFlGa0FhMGZFVENJK045bnFLTTVoZjQ4eW5Jb0cvSGhzNmQvK2FvNmVDbFQ1?= =?utf-8?B?dElwUDVEVS95SnYyRjlsY1FOdzBsTEd0YXJPRWNtV3VZUmpDNzhIdDFkYlRn?= =?utf-8?B?d3RMblRtNDhYcTdUVzFGQjd0ODlEN3RseERYWE9rTVFqTlZaclBqaXRpdU1Q?= =?utf-8?B?ZlRRcUY4Z1NHY3Vkeld6VjNwMTB2YU1IQ0tSSUNUSmtqTlQ5dDB0SnZQUVps?= =?utf-8?B?aXpqWWZyYndxTDFVVko3WS94KzBnY0ZsQWViRHVhdGZNcXl3RkRRVXJ3YStQ?= =?utf-8?B?S1J0TFRUODNNVUlNYkVIZUUzMUV0TW1qdG4xNldlaGZ4a3pFdGl3cXhlSTl6?= =?utf-8?B?Z1k4VEdSN1B3d1BMdTlpdFJOOVh4SkxHSVRqNmVoclZUc3FjZ3RrUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9eb676b-d3a6-462f-3aad-08da3820a7b8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 16:16:53.1574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MYiOTglClbuLxT7v8yF4X28hSLAtJuxpvIbpef6NPZQacC8PdW3r3R3zgdENLEgQIMCTaRPQM2tJE5Y8YVqqBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6794 On 10.05.2022 04:27, Penny Zheng wrote: > @@ -2769,12 +2769,43 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > + > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + mfn_t smfn; > + > + /* Acquire a page from reserved page list(resv_page_list). */ > + page = page_list_remove_head(&d->resv_page_list); > + if ( unlikely(!page) ) > + return INVALID_MFN; > + > + smfn = page_to_mfn(page); > + > + if ( acquire_domstatic_pages(d, smfn, 1, memflags) ) > + { > + page_list_add_tail(page, &d->resv_page_list); > + return INVALID_MFN; > + } > + > + return smfn; > +} > #else > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub) > { > ASSERT_UNREACHABLE(); > } > + > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + ASSERT_UNREACHABLE(); > + return INVALID_MFN; > +} > #endif Much like for the other stub function added in the earlier patch: If is_domain_using_staticmem() was compile time constant "false" when !CONFIG_STATIC_MEM, there would be no need for this one since the compiler would DCE the only call site. From xen-devel-bounces@lists.xenproject.org Tue May 17 16:31:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:31:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331250.554734 (Exim 4.92) (envelope-from ) id 1nr06B-0004ty-Bi; Tue, 17 May 2022 16:31:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331250.554734; Tue, 17 May 2022 16:31:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr06B-0004tr-8U; Tue, 17 May 2022 16:31:03 +0000 Received: by outflank-mailman (input) for mailman id 331250; Tue, 17 May 2022 16:31:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr069-0004th-3R; Tue, 17 May 2022 16:31:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr068-0008AF-VL; Tue, 17 May 2022 16:31:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr068-0007Ea-Ka; Tue, 17 May 2022 16:31:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr068-00020M-K9; Tue, 17 May 2022 16:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IFBAiunVqzLVYsa84oMJzLXhg8NpeUJN6UwlqqcVrtE=; b=08C/nb+Pm0kvMSG4QjFn+cQ8SJ 2sXCgaaMxWgdVs7G9PyCHfeFtoPZYHLpMRA/osOEcVliItCr1VllaY0FyXgQParTA7Phwpdn6nDO/ 9X3uc4ZqbuQXPIAzJH/Q7a624LVYN6AWvpdJpYR3kr5at60/Z56IEXGEWkT/+1fl36OA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170511: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 16:31:00 +0000 flight 170511 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170511/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1065 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 84 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 16:31:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:31:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331261.554746 (Exim 4.92) (envelope-from ) id 1nr073-0005WM-T8; Tue, 17 May 2022 16:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331261.554746; Tue, 17 May 2022 16:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr073-0005WF-Pf; Tue, 17 May 2022 16:31:57 +0000 Received: by outflank-mailman (input) for mailman id 331261; Tue, 17 May 2022 16:31:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr071-0005Ee-Tp for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:31:56 +0000 Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com [99.78.197.218]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dbe3f5b8-d5fe-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:31:54 +0200 (CEST) Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO email-inbound-relay-pdx-2b-718d0906.us-west-2.amazon.com) ([10.25.36.210]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP; 17 May 2022 16:24:43 +0000 Received: from EX13D08EUC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2b-718d0906.us-west-2.amazon.com (Postfix) with ESMTPS id 2584E3E00E4; Tue, 17 May 2022 16:24:43 +0000 (UTC) Received: from EX13MTAUEA002.ant.amazon.com (10.43.61.77) by EX13D08EUC002.ant.amazon.com (10.43.164.124) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 17 May 2022 16:24:41 +0000 Received: from dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (10.15.60.66) by mail-relay.amazon.com (10.43.61.169) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Tue, 17 May 2022 16:24:40 +0000 Received: by dev-dsk-mheyne-1b-c1524648.eu-west-1.amazon.com (Postfix, from userid 5466572) id DC06A41146; Tue, 17 May 2022 16:24:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: dbe3f5b8-d5fe-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1652805114; x=1684341114; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IteN9ICL3vHHQMXeE78rzjKCW/+s+R1bzkPHD4BhrHE=; b=r0j9UaflDNMhTAhfz6UReLXYA9FR/Ts003RsaUOrJ2fyLmzyuyWkd54Y Ql2+hqQ5CxaLBZnXsja/J4mAk6bhRHYcvJLoirb6IO+tWYB8GosO6ZkLe wPR176wVQ77zwodsmaqyD4lZdK+iEOgUW58orEZ6O8xfycAQieUC88CqY k=; X-IronPort-AV: E=Sophos;i="5.91,233,1647302400"; d="scan'208";a="89313648" From: Maximilian Heyne To: CC: Maximilian Heyne , Josh Poimboeuf , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , Subject: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid Date: Tue, 17 May 2022 16:24:25 +0000 Message-ID: <20220517162425.100567-1-mheyne@amazon.de> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: Bulk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM emulate-prefix signature"), objtool is able to correctly parse the prefixed instruction in xen_cpuid and emit correct orc unwind information. Hence, marking the function as STACKFRAME_NON_STANDARD is no longer needed. This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark xen_cpuid() stack frame as non-standard"). Signed-off-by: Maximilian Heyne CC: Josh Poimboeuf cr: https://code.amazon.com/reviews/CR-69645080 --- arch/x86/xen/enlighten_pv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5038edb79ad5..ca85d1409917 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include @@ -165,7 +164,6 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx, *bx &= maskebx; } -STACK_FRAME_NON_STANDARD(xen_cpuid); /* XEN_EMULATE_PREFIX */ static bool __init xen_check_mwait(void) { -- 2.32.0 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 From xen-devel-bounces@lists.xenproject.org Tue May 17 16:39:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:39:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331272.554757 (Exim 4.92) (envelope-from ) id 1nr0Ei-0006IW-Ny; Tue, 17 May 2022 16:39:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331272.554757; Tue, 17 May 2022 16:39:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0Ei-0006IP-KW; Tue, 17 May 2022 16:39:52 +0000 Received: by outflank-mailman (input) for mailman id 331272; Tue, 17 May 2022 16:39:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0Eg-0006IJ-Ln for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:39:51 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5f5b521-d5ff-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 18:39:46 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nr0Da-008gju-GJ; Tue, 17 May 2022 18:38:42 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5f5b521-d5ff-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nkckcEBnQlRsFTpASqSz6WprnZRaV0YhYSvPtBA0AVg=; b=GXitEwhCwUT4w9+D5pmH2zeSKa 60OoBts2cxKaTjkNlztKOiPg7JmJSxA8Nf6Mc3GM9eoyPx0kgrCnR1AZ6EjsP0NE4+IxyqcasC5FH Bzs6mPDD2Ojz26SlVHGGSFKa4MS4PaKNy9b4ykBdp04iHw75Gq64zjSE08zAzR/RUXjez/E1PIcPr w9iTODel9NpjUtjDaWlc8Esr0zkZKONhALq9dFCmuDS5Nj18Wn3hMj4H1VTlzFy6uMc+YdCA3ReKq k/CxfFfQpOp3w1u8K+s1/QjiYVlCZZRZYeOFoWStjActxBApHl98rSBUYLtUajOsHPvmBlqZChf2A VEU39bjw==; Message-ID: Date: Tue, 17 May 2022 13:37:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek , Evan Green , David Gow , Julius Werner Cc: Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , Linux PM , Florian Fainelli , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi , Stephen Boyd References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 10:28, Petr Mladek wrote: > [...] >>> Disagree here. I'm looping Google maintainers, so they can comment. >>> (CCed Evan, David, Julius) >>> >>> This notifier is clearly a hypervisor notification mechanism. I've fixed >>> a locking stuff there (in previous patch), I feel it's low-risk but even >>> if it's mid-risk, the class of such callback remains a perfect fit with >>> the hypervisor list IMHO. >> >> This logs a panic to our "eventlog", a tiny logging area in SPI flash >> for critical and power-related events. In some cases this ends up >> being the only clue we get in a Chromebook feedback report that a >> panic occurred, so from my perspective moving it to the front of the >> line seems like a good idea. > > IMHO, this would really better fit into the pre-reboot notifier list: > > + the callback stores the log so it is similar to kmsg_dump() > or console_flush_on_panic() > > + the callback should be proceed after "info" notifiers > that might add some other useful information. > > Honestly, I am not sure what exactly hypervisor callbacks do. But I > think that they do not try to extract the kernel log because they > would need to handle the internal format. > I guess the main point in your response is : "I am not sure what exactly hypervisor callbacks do". We need to be sure about the semantics of such list, and agree on that. So, my opinion about this first list, that we call "hypervisor list", is: it contains callbacks that (1) should run early, preferably before kdump (or even if kdump isn't set, should run ASAP); (2) these callbacks perform some communication with an abstraction that runs "below" the kernel, like a firmware or hypervisor. Classic example: pvpanic, that communicates with VMM (usually qemu) and allow such VMM to snapshot the full guest memory, for example. (3) Should be low-risk. What defines risk is the level of reliability of subsequent operations - if the callback have 50% of chance of "bricking" the system totally and prevent kdump / kmsg_dump() / reboot , this is high risk one for example. Some good fits IMO: pvpanic, sstate_panic_event() [sparc], fadump in powerpc, etc. So, this is a good case for the Google notifier as well - it's not collecting data like the dmesg (hence your second bullet seems to not apply here, info notifiers won't add info to be collected by gsmi). It is a firmware/hypervisor/whatever-gsmi-is notification mechanism, that tells such "lower" abstraction a panic occurred. It seems low risk and we want it to run ASAP, if possible. So, I'd like to keep it here, unless gsmi maintainers disagree or I'm perhaps misunderstanding the meaning of this first list. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 16:43:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:43:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331286.554767 (Exim 4.92) (envelope-from ) id 1nr0Hy-0007iO-8e; Tue, 17 May 2022 16:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331286.554767; Tue, 17 May 2022 16:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0Hy-0007iH-5a; Tue, 17 May 2022 16:43:14 +0000 Received: by outflank-mailman (input) for mailman id 331286; Tue, 17 May 2022 16:43:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0Hx-0007iB-5B for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:43:13 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6fa9684a-d600-11ec-837e-e5687231ffcc; Tue, 17 May 2022 18:43:11 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nr0Hb-008gzd-4h; Tue, 17 May 2022 18:42:51 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fa9684a-d600-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=scD/9Z9PP3JtS/QbR0S82HRrb/qzzKD7mmsgRlJKv48=; b=A0Wed33QPDatmI/wU05BORZ9n1 0hhJk6U25fx6bbbZAsMcq0PkUqYkw6doFXVO3lE2gRlx4mNP2Gg+o2qX5D1iIed/eOGnpU07MiS7v johrL8ZXBr9bRs4m6YspjNjUrp3CRZWOwFXObkbK34aTXOqWVxjbnj+S21xz3SW3iyyzLS8il/lBE YgblTLXs216LyG4XvwA74bc/PHj8Q4o7WtYFZIjzCamKnOfAXbs0CZLburXLM75F/4BH78OE9Feno 1CTSSOT/QCKGLXFRsMSKXpMjqSuNKxrbhetupOiCZ9xDYHRTskdd6CLiaYJY53xEUzZgCM24bzp0B WqYqJCVA==; Message-ID: Date: Tue, 17 May 2022 13:42:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek , Scott Branden , Sebastian Reichel , Florian Fainelli Cc: David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 10:57, Petr Mladek wrote: > [...] >>>> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c >>>> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c >>>> @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >>> [... snip ...] >>> It seems to reset some hardware or so. IMHO, it should go into the >>> pre-reboot list. >> >> Mixed feelings here, I'm looping Broadcom maintainers to comment. >> (CC Scott and Broadcom list) >> >> I'm afraid it breaks kdump if this device is not reset beforehand - it's >> a doorbell write, so not high risk I think... >> >> But in case the not-reset device can be probed normally in kdump kernel, >> then I'm fine in moving this to the reboot list! I don't have the HW to >> test myself. > > Good question. Well, it if has to be called before kdump then > even "hypervisor" list is a wrong place because is not always > called before kdump. Agreed! I'll defer that to Scott and Broadcom folks to comment. If it's not strictly necessary, I'll happily move it to the reboot list. If necessary, we could use the machine_crash_kexec() approach, but we'll fall into the case arm64 doesn't support it and I'm not sure if this device is available for arm - again a question for the maintainers. > [...] >>>> --- a/drivers/power/reset/ltc2952-poweroff.c >>>> +++ b/drivers/power/reset/ltc2952-poweroff.c >> [...] >> This is setting a variable only, and once it's set (data->kernel_panic >> is the bool's name), it just bails out the IRQ handler and a timer >> setting - this timer seems kinda tricky, so bailing out ASAP makes sense >> IMHO. > > IMHO, the timer informs the hardware that the system is still alive > in the middle of panic(). If the timer is not working then the > hardware (chip) will think that the system frozen in panic() > and will power off the system. See the comments in > drivers/power/reset/ltc2952-poweroff.c: > [.... snip ...] > IMHO, we really have to keep it alive until we reach the reboot stage. > > Another question is how it actually works when the interrupts are > disabled during panic() and the timer callbacks are not handled. Agreed here! Guess I can move this one the reboot list, fine by me. Unless PM folks think otherwise. > [...] >> Disagree here, I'm CCing Florian for information. >> >> This notifier preserves RAM so it's *very interesting* if we have >> kmsg_dump() for example, but maybe might be also relevant in case kdump >> kernel is configured to store something in a persistent RAM (then, >> without this notifier, after kdump reboots the system data would be lost). > > I see. It is actually similar problem as with > drivers/firmware/google/gsmi.c. > > I does similar things like kmsg_dump() so it should be called in > the same location (after info notifier list and before kdump). > > A solution might be to put it at these notifiers at the very > end of the "info" list or make extra "dump" notifier list. Here I still disagree. I've commented in the other response thread (about Google gsmi) about the semantics of the hypervisor list, but again: this list should contain callbacks that (a) Should run early, _by default_ before a kdump; (b) Communicate with the firmware/hypervisor in a "low-risk" way; Imagine a scenario where users configure kdump kernel to save something in a persistent form in DRAM - it'd be like a late pstore, in the next kernel. This callback enables that, it's meant to inform FW "hey, panic happened, please from now on don't clear the RAM in the next FW-reboot". I don't see a reason to postpone that - let's see if the maintainers have an opinion. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 16:47:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 16:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331294.554779 (Exim 4.92) (envelope-from ) id 1nr0LZ-0008Lz-P3; Tue, 17 May 2022 16:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331294.554779; Tue, 17 May 2022 16:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0LZ-0008Ls-ME; Tue, 17 May 2022 16:46:57 +0000 Received: by outflank-mailman (input) for mailman id 331294; Tue, 17 May 2022 16:46:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0LX-0008Lm-Qj for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:46:55 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f50859c6-d600-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 18:46:54 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nr0L8-008hJL-On; Tue, 17 May 2022 18:46:30 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f50859c6-d600-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SayoV/bDRPXgJ3Ch+E1XrP+3ZKBsDTlU6fUN8lp8tUA=; b=NFkpBbcNKXWz56FUYb1Bkzyxr7 6pY/CyDxLh4gcyoAU547/3Tabh/NOqK7gz3NyBwq82xJqiEBF4takjF5Ea4MxM1+r5wku8pOVYUcB ywM/ZaJlNeBGlkQDKAAkvdKcd6hk5MAb9a5XNcjDCG3MlNSgk+v7vfXWUOesl/qG/NSZ4K/pjk0dM SubvLJBNURMO5WMoXdrxUQfhd0uSTHup7fDjOSHoKefOTjSKlQG/UGn8QEvdGVnYTtMgbwm4d3/K8 B+J9kKyINLLhiDLqbwoDlrvd49iM915Hk5YhXi74qG93lapXX9eWm/gnnOawNxBPCH4bdsTvQIyr9 Yagr/AQw==; Message-ID: <599b72f6-76a4-8e6d-5432-56fb1ffd7e0b@igalia.com> Date: Tue, 17 May 2022 13:45:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Content-Language: en-US To: Petr Mladek , "Luck, Tony" , Dinh Nguyen Cc: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 11:11, Petr Mladek wrote: > [...] >>> Then notifiers could make an informed choice on whether to deep dive to >>> get all the possible details (when there is no kdump) or just skim the high >>> level stuff (to maximize chance of getting a successful kdump). >>> >>> -Tony >> >> Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier? > > I like this idea. > > One small problem is that kexec_crash_loaded() has valid result > only under kexec_mutex. On the other hand, it should stay true > once loaded so that the small race window should be innocent. > >> With that, are you/Petr/Dinh OK in moving it for the info list? > > Sounds good to me. > > Best Regards, > Petr Perfect, I'll do that for V2 then =) Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else we run the code as-is? Does that make sense to you? I'll postpone it to run almost in the end of info list (last position is for panic_print). Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 17:02:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331307.554790 (Exim 4.92) (envelope-from ) id 1nr0aq-0002Ob-8r; Tue, 17 May 2022 17:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331307.554790; Tue, 17 May 2022 17:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0aq-0002OU-5z; Tue, 17 May 2022 17:02:44 +0000 Received: by outflank-mailman (input) for mailman id 331307; Tue, 17 May 2022 17:02:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0ao-0002O8-L1 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:02:43 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26235fc1-d603-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 19:02:38 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 10:02:34 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 17 May 2022 10:02:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 10:02:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 10:02:31 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2308.027; Tue, 17 May 2022 10:02:31 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26235fc1-d603-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652806958; x=1684342958; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wPndYlW5xEVdpcc0zA72NXu9ypQzfs4FPZzk6VJMkkY=; b=E7Pcez5DgdPL62RMz9czjYHtIWNHfSbSPAi6maTscPRNtXygBe1fFzXb MVe86PUkudZ87qt7RMGUr9lXJ2vxYv2w/Z3wPc1XN9EX9k4g1ejPQfjxW oRLBNwJjeaC6TAkUOMusi1Bo0yAzmkkwPmJE011o8TPNS4iCfOHzcVd9J NSXEX1T6vXte1GMp3jOFoCuqCN3stoeJXCwt6K5gA4+e7lbXfRFKeEgSq KWsQFMuQm74+5/Mkzl5ChuGhUq31nyRxTUChV7mcU4JQeAgc15CCGdssM Zu5VmZiY1vlC6XNaZtJQ4KpKYy+WpWIV4cWR7sd/+ue803iKp+Sf67T7y g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270942691" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="270942691" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="700144313" From: "Luck, Tony" To: "Guilherme G. Piccoli" , Petr Mladek , Dinh Nguyen CC: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , "Corey Minyard" , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , "Heiko Carstens" , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , "Matt Turner" , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , "Richard Weinberger" , Robert Richter , "Stefano Stabellini" , Stephen Hemminger , Sven Schnelle , "Vasily Gorbik" , Wei Liu Subject: RE: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Topic: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Index: AQHYWooLnXaT7guJw0OCpuGv/IkEoK0iJCSAgAAZuAD//40QkIAAesuAgAFqbACAACtDgP//jcxA Date: Tue, 17 May 2022 17:02:31 +0000 Message-ID: <06d85642fef24bc482642d669242654b@intel.com> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> <599b72f6-76a4-8e6d-5432-56fb1ffd7e0b@igalia.com> In-Reply-To: <599b72f6-76a4-8e6d-5432-56fb1ffd7e0b@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiBUb255IC8gRGluaCAtIGNhbiBJIGp1c3QgKnNraXAqIHRoaXMgbm90aWZpZXIgKmlmIGtkdW1w KiBpcyBzZXQgb3IgZWxzZQ0KPiB3ZSBydW4gdGhlIGNvZGUgYXMtaXM/IERvZXMgdGhhdCBtYWtl IHNlbnNlIHRvIHlvdT8NCg0KVGhlICJza2lwIiBvcHRpb24gc291bmRzIGxpa2UgaXQgbmVlZHMg c29tZSBzcGVjaWFsIGZsYWcgYXNzb2NpYXRlZCB3aXRoDQphbiBlbnRyeSBvbiB0aGUgbm90aWZp ZXIgY2hhaW4uIEJ1dCB0aGVyZSBhcmUgb3RoZXIgbm90aWZpZXIgY2hhaW5zIC4uLiBzbyB0aGF0 DQpzb3VuZHMgbWVzc3kgdG8gbWUuDQoNCkp1c3QgYWxsIHRoZSBub3RpZmllcnMgaW4gcHJpb3Jp dHkgb3JkZXIuIElmIGFueSB3YW50IHRvIHRha2UgZGlmZmVyZW50IGFjdGlvbnMNCmJhc2VkIG9u IGtkdW1wIHN0YXR1cywgY2hhbmdlIHRoZSBjb2RlLiBUaGF0IHNlZW1zIG1vcmUgZmxleGlibGUg dGhhbg0KYW4gImFsbCBvciBub3RoaW5nIiBhcHByb2FjaCBieSBza2lwcGluZy4NCg0KLVRvbnkN Cg== From xen-devel-bounces@lists.xenproject.org Tue May 17 17:07:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331315.554801 (Exim 4.92) (envelope-from ) id 1nr0fm-00032j-U0; Tue, 17 May 2022 17:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331315.554801; Tue, 17 May 2022 17:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0fm-00032c-QD; Tue, 17 May 2022 17:07:50 +0000 Received: by outflank-mailman (input) for mailman id 331315; Tue, 17 May 2022 17:07:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0fl-00032W-IO for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:07:49 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df76c42a-d603-11ec-837e-e5687231ffcc; Tue, 17 May 2022 19:07:47 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 261545C006E; Tue, 17 May 2022 13:07:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 17 May 2022 13:07:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 May 2022 13:07:45 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df76c42a-d603-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1652807266; x=1652893666; bh=4tDoSEQhdS 9niDMV646Qebgz6622yWtjkDpobgZ8Kz8=; b=neUUe1VFphEnnyeh0pDnAnw7f6 Qb2NJ8nUtnxQnNqvz0rVaknvTqFK/JNG16lqCx/ox0y/R+msCbtZ/+vBfZOXLaNA oe8DK8FvqG0qvf1BPRLipZj5/pn30Dng5qyyia80CkGEJYxaRetvj4FAn5VCDrxY Ah6aONZHj3woEuzEivyNtpGx9yBMkfBlBJtKdRRJZ8KGndEkvv7DYGUu3VrbFkSJ oqj4ZXtXTUPqp6bcLu8GFl/NFH40sw0ppXINrR1fuwctLCyx56RkcrDKat0WAVEJ VkBtAlrPh9Ay48/1KzRbuHclXG3ohtQMOaO8wvluu+nqh34ukTbJ3tLwVTBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652807266; x= 1652893666; bh=4tDoSEQhdS9niDMV646Qebgz6622yWtjkDpobgZ8Kz8=; b=x RaJOcSCE6xWOZeoMjQ2/q26awUqOMYz0YY00zzgYDglx/wtvbT0Zo8rYAEPCufL9 gB95SoMeLAVokiU5K1CYRvknxakDdiI8e9MiJbGUQ2yS6mJBHAJJXAHlPohY/nTM JSZS3Zpv3i3n2lbulY+ncdfL11OZGq2PyZXGpMcJjvkv2TCG6xXslv7teE6t2w7X 51+G2O03tlDVqsdmzMiNvkkPAVkq9JK3no+ohnJzwONUwUcrjcve4LA0s/KpwnuS KVCXl0PnpsDX8YHlPNuc39GdZE4lic1yuHnzX9tWT1CTb91s6Pc7b6R42EpeRUOW 27FZ/8XkhaDd9GXCmqJvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheejgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugesghdtreertddtjeenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepudekteekkeekkedvteegtdektefftdfh tddtgfeifffhkeehhfejhfevgefgieehnecuffhomhgrihhnpehkvghrnhgvlhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 17 May 2022 13:07:42 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v5] Preserve the EFI System Resource Table for dom0 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HLK4XKn2pm9LO02N" Content-Disposition: inline --HLK4XKn2pm9LO02N Content-Type: text/plain; charset=utf-8; protected-headers=v1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 17 May 2022 13:07:42 -0400 From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Jan Beulich Subject: [PATCH v5] Preserve the EFI System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification =C2=A723.= 4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour --- xen/common/efi/boot.c | 106 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..3d56422dfa 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -39,6 +39,25 @@ { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b,= 0x23} } #define APPLE_PROPERTIES_PROTOCOL_GUID \ { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a= , 0xe0} } +#define ESRT_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21,= 0x80} } + +typedef struct _ESRT_ENTRY { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 FwLowestSupportedVersion; + UINT32 FwCapsuleFlags; + UINT32 FwLastAttemptVersion; + UINT32 FwLastAttemptStatus; +} ESRT_ENTRY; + +typedef struct _ESRT { + UINT32 Count; + UINT32 Max; + UINT64 Version; + ESRT_ENTRY Entries[]; +} ESRT; =20 typedef EFI_STATUS (/* _not_ EFIAPI */ *EFI_SHIM_LOCK_VERIFY) ( @@ -567,6 +586,38 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I= MAGE *loaded_image) } #endif =20 +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; + +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start =3D desc->PhysicalStart; + const ESRT *esrt_ptr; + + len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR ) + return 0; + if ( physical_start > esrt || esrt - physical_start >=3D len ) + return 0; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type !=3D EfiRuntimeServicesData) && + (desc->Type !=3D EfiBootServicesData) ) + return 0; + available_len =3D len - (esrt - physical_start); + if ( available_len <=3D offsetof(ESRT, Entries) ) + return 0; + available_len -=3D offsetof(ESRT, Entries); + esrt_ptr =3D (const ESRT *)esrt; + if ( esrt_ptr->Version !=3D 1 || !esrt_ptr->Count ) + return 0; + if ( esrt_ptr->Count > available_len / sizeof(esrt_ptr->Entries[0]) ) + return 0; + return esrt_ptr->Count * sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +896,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTP= UT_PROTOCOL *gop, return gop_mode; } =20 +static EFI_GUID __initdata esrt_guid =3D ESRT_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +921,8 @@ static void __init efi_tables(void) efi.smbios =3D (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt =3D (UINTN)efi_ct[i].VendorTable; } =20 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1056,9 +1111,7 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHand= le, EFI_SYSTEM_TABLE *Syste EFI_STATUS status; UINTN info_size =3D 0, map_key; bool retry; -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP unsigned int i; -#endif =20 efi_bs->GetMemoryMap(&info_size, NULL, &map_key, &efi_mdesc_size, &mdesc_ver); @@ -1067,6 +1120,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan= dle, EFI_SYSTEM_TABLE *Syste if ( !efi_memmap ) blexit(L"Unable to allocate memory for EFI memory map"); =20 + efi_memmap_size =3D info_size; + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, + efi_memmap, &map_key, + &efi_mdesc_size, + &mdesc_ver); + if ( EFI_ERROR(status) ) + PrintErrMesg(L"Cannot obtain memory map", status); + + /* Try to obtain the ESRT. Errors are not fatal. */ + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) + { + /* + * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * so that the memory it is in will not be used for other purposes. + */ + void *new_esrt =3D NULL; + size_t esrt_size =3D get_esrt_size(efi_memmap + i); + + if ( !esrt_size ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D=3D + EfiRuntimeServicesData ) + break; /* ESRT already safe from reuse */ + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + &new_esrt); + if ( status =3D=3D EFI_SUCCESS && new_esrt ) + { + memcpy(new_esrt, (void *)esrt, esrt_size); + status =3D efi_bs->InstallConfigurationTable(&esrt_guid, new_e= srt); + if ( status !=3D EFI_SUCCESS ) + { + PrintStr(L"Cannot install new ESRT\r\n"); + efi_bs->FreePool(new_esrt); + } + } + else + PrintStr(L"Cannot allocate memory for ESRT\r\n"); + break; + } + for ( retry =3D false; ; retry =3D true ) { efi_memmap_size =3D info_size; @@ -1753,3 +1846,12 @@ void __init efi_init_memory(void) unmap_domain_page(efi_l4t); } #endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --HLK4XKn2pm9LO02N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKD1l8ACgkQsoi1X/+c IsFMAg/+J4XX6XmX6cfctCFRxzcyXyncJv7yxiD+hqPL0R8JnfzEuHBWRPJmC5Vg gGf+9GouSyYnFgo9y7TIZEYpXOq5XInflpxv8VHEEvYbJbOuvrirddl9tVRkaZsK o79BvJj/rqM1ZwzAVhA6tcSF37jmhwYONcUsXFDcinudp1dM2pHuU0267ro9gtum P6EEMyFdFmbgMwad05rgx7Tc8gerwyIf5kgipT4P4lrZXhV9gZ/D2SGwD3uSjhtC tWFSrBIF3ayUWoXiRIx2M7JJRspcVDOfqykW2dZ4ngUapnKPyJNC9wVovWax9U/E qFcAiz09Zt8HoJ5cP4qSfBoO7/OSUXdrz9PSCacnjd9kThX/d5lvBXKWMTBgQ4IP /wkyK5CLLhgl3exfoBLiC1OCuK0PuHJwFxHNbb6gar2xslbe5S8tNKvzer1jEQiv r37wpw79s7gDBSnI8k4vlPqDf8788WOH5X45xXOPQjs/D/FgcoLTstzpQwNBI8K+ 9umbFY2myaLhNw0ZtUALnAmB+pNlExs894byv4JWe2mii7FPiXAZC/CDInnyH4pi 0jiL1LYUq/4Av39+D7w1h30kmULbybMUjP6D3lUdRJTpsYOxriry5agE7iSlgjLl jGsiY0SqL7U6Fdn0y4WO3YXJXyiXkUMloLCtfDH9TE4e2KbV3d0= =345A -----END PGP SIGNATURE----- --HLK4XKn2pm9LO02N-- From xen-devel-bounces@lists.xenproject.org Tue May 17 17:21:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331327.554812 (Exim 4.92) (envelope-from ) id 1nr0sM-0005Mo-2q; Tue, 17 May 2022 17:20:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331327.554812; Tue, 17 May 2022 17:20:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0sL-0005Mh-W1; Tue, 17 May 2022 17:20:49 +0000 Received: by outflank-mailman (input) for mailman id 331327; Tue, 17 May 2022 17:20:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0sK-0005Mb-8I for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:20:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0sJ-0000aT-Ug; Tue, 17 May 2022 17:20:47 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nr0sJ-000701-OV; Tue, 17 May 2022 17:20:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tdxgFkAJbWMcqzAdfW43MICaHgB+iXP1p8ozzhZ5qAE=; b=jdoOIShvTsIIQPVFz6j722wu0e N6wYF8G+Ji3Z2PFocb9YK5Uo8waiK5ysq1084xxiNOrQPtbR6roqh7UwVcxRAWRDPPqKIzR11BXFo oAOVbhzVUwdZNNjttp1oH+b1hkBmkZ1Yc2paLOcA78GDioLPW+OIh/j3UA8JRcYxQqnU=; Message-ID: Date: Tue, 17 May 2022 18:20:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] xen/arm: gic-v3-lpi: Allocate the pending table while preparing the CPU To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20220516170246.19908-1-julien@xen.org> <89313424-EB15-4A9B-B215-178460F035C4@arm.com> From: Julien Grall In-Reply-To: <89313424-EB15-4A9B-B215-178460F035C4@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 17/05/2022 09:58, Bertrand Marquis wrote: >> On 16 May 2022, at 18:02, Julien Grall wrote: >> >> From: Julien Grall >> >> Commit 88a037e2cfe1 "page_alloc: assert IRQs are enabled in heap >> alloc/free" extended the checks in the buddy allocator to catch any >> use of the helpers from context with interrupts disabled. >> >> Unfortunately, the rule is not followed in the LPI code when allocating >> the pending table: >> >> (XEN) Xen call trace: >> (XEN) [<000000000022a678>] alloc_xenheap_pages+0x178/0x194 (PC) >> (XEN) [<000000000022a670>] alloc_xenheap_pages+0x170/0x194 (LR) >> (XEN) [<0000000000237770>] _xmalloc+0x144/0x294 >> (XEN) [<00000000002378d4>] _xzalloc+0x14/0x30 >> (XEN) [<000000000027b4e4>] gicv3_lpi_init_rdist+0x54/0x324 >> (XEN) [<0000000000279898>] arch/arm/gic-v3.c#gicv3_cpu_init+0x128/0x46 >> (XEN) [<0000000000279bfc>] arch/arm/gic-v3.c#gicv3_secondary_cpu_init+0x20/0x50 >> (XEN) [<0000000000277054>] gic_init_secondary_cpu+0x18/0x30 >> (XEN) [<0000000000284518>] start_secondary+0x1a8/0x234 >> (XEN) [<0000010722aa4200>] 0000010722aa4200 >> (XEN) >> (XEN) >> (XEN) **************************************** >> (XEN) Panic on CPU 2: >> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/page_alloc.c:2212 >> (XEN) **************************************** >> >> For now the patch extending the checks has been reverted, but it would >> be good to re-introduce it (allocation with interrupt is not desirable). >> >> The logic is reworked to allocate the pending table when preparing the >> CPU. >> >> Signed-off-by: Julien Grall > > With the print fixed as pointed by Michal you can add my: > Reviewed-by: Bertrand Marquis Thanks! > > (Fix could be done on commit but that is up to you). I have fixed it and committed it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 17:27:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331336.554827 (Exim 4.92) (envelope-from ) id 1nr0yk-00067G-R5; Tue, 17 May 2022 17:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331336.554827; Tue, 17 May 2022 17:27:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yk-000679-OF; Tue, 17 May 2022 17:27:26 +0000 Received: by outflank-mailman (input) for mailman id 331336; Tue, 17 May 2022 17:27:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yj-00066d-AW for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:27:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yi-0000gq-OE; Tue, 17 May 2022 17:27:24 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nr0yi-0007RP-HR; Tue, 17 May 2022 17:27:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fYi3NWjuka35MAaoV5e/tnGC9ARvdDvrniUl3iBUnqQ=; b=7Da8LkxyDIdWq8H4gyElSCvCfA q0qmvnTzlQYsmo0RgHBn3EWlvBRQyBOdENonSUl74DKqXhxMWK0n+FAD1+d5EkmiHPL3cLE8ty0OZ 04ytv2GlZQRTweiXnn8bm49ine6nJ/0mtzQY0XPwfEFnzgill7b4RluPQO/0j/9N5rpI=; Message-ID: Date: Tue, 17 May 2022 18:27:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 2/2] xen/arm: gnttab: modify macros to evaluate all arguments and only once To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-3-michal.orzel@arm.com> <9eb95e25-1a19-4048-259f-dc2dbee6cac7@arm.com> From: Julien Grall In-Reply-To: <9eb95e25-1a19-4048-259f-dc2dbee6cac7@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 17/05/2022 08:14, Michal Orzel wrote: > On 16.05.2022 12:19, Julien Grall wrote: >> Hi Michal, >> >> On 06/05/2022 10:42, Michal Orzel wrote: >>> Modify macros to evaluate all the arguments and make sure the arguments >>> are evaluated only once. Introduce following intermediate macros: >>> gnttab_status_gfn_, gnttab_shared_gfn_ that do not take domain as a >>> parameter. These are to be used locally and allow us to avoid passing >>> NULL from gnttab_get_frame_gfn to the respective macros (without _ suffix). >>> Make use of a domain parameter from gnttab_shared_gfn and gnttab_status_gfn >>> by adding an ASSERT. >>> >>> Signed-off-by: Michal Orzel >> >> Most of the helpers below are going to disappear with Oleksandr latest work (see [1]). >> >> Looking at Oleksandr's patch, I think only gnttab_set_frame_gfn() would end up to use one of the macro parameters twice. So I would like to suggest to chat with Oleksandr if we can tweak his patch (can be done on commit) or we rebase this patch on top of his work. >> >> Cheers, >> >> [1] https://lore.kernel.org/xen-devel/1652294845-13980-1-git-send-email-olekstysh@gmail.com/ >> > > By looking at Oleksandr patch: > 1. there are 2 macros: gnttab_set_frame_gfn, gnttab_need_iommu_mapping that use one of the macro parameters twice. > 2. gnttab_get_frame_gfn still passes NULL as a domain parameter to gnttab_shared_gfn/gnttab_status_gfn that do not evaluate domain parameter > > I agree that point 1 could be fixed on commit but point 2 requires in my opinion adding intermediate macros to avoid passing NULL (just like I did). Ok. I think we could avoid the intermediate macros by implementing the helpers the other way around. I.e gnttab_{status}_gfn() call gnttab_get_frame_gfn(). > > As this would require more work from Oleksandr, I'm ok to rebase my patch on top of his work once merged. Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 17:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331338.554838 (Exim 4.92) (envelope-from ) id 1nr0z0-0006VL-8W; Tue, 17 May 2022 17:27:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331338.554838; Tue, 17 May 2022 17:27:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0z0-0006VE-3z; Tue, 17 May 2022 17:27:42 +0000 Received: by outflank-mailman (input) for mailman id 331338; Tue, 17 May 2022 17:27:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yy-0006UX-VG; Tue, 17 May 2022 17:27:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yy-0000h9-UR; Tue, 17 May 2022 17:27:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0yy-0008T9-JF; Tue, 17 May 2022 17:27:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr0yy-0007D9-In; Tue, 17 May 2022 17:27:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6e8pJgH+BXsUHMJ2fkgp5G/hXNm+NDLmKiXU06lipYk=; b=MHysAVkyh2b6snvqPzjmqssAli FRBX7CxkfW2dGzEqpQvlvgcs1LULXCAt4o7GkMkTGwj7q/ci4U/Mpu1X6ZNJC73eU1cMNW7yPHtke JVusN3E2Sh8DfYuiGRQc2zdJpDzWsH9NfFrWLxO8EWeOUFXX/faqEksaqQ60wC32DOlg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170512: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 17:27:40 +0000 flight 170512 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170512/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1066 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 85 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 17:36:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:36:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331355.554849 (Exim 4.92) (envelope-from ) id 1nr17Q-0008Gh-6J; Tue, 17 May 2022 17:36:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331355.554849; Tue, 17 May 2022 17:36:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr17Q-0008Ga-2L; Tue, 17 May 2022 17:36:24 +0000 Received: by outflank-mailman (input) for mailman id 331355; Tue, 17 May 2022 17:36:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr17O-0008GU-HA for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:36:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr17O-0000ql-93; Tue, 17 May 2022 17:36:22 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nr17O-00081g-35; Tue, 17 May 2022 17:36:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3B0YNS3PO+dtYpj8Bp26EOPM7Kfk5wGjr5am+RBP9BE=; b=BHOGaR3FRZhnF+R0eLvSpiarGS q70MNiUIuya1vYKsaJ65CBNg/OLtm1QT3QU9db6tHpq++aHfRC2UWfqRSHV2Jv1XyFVF8pni/fVpb uaIFNNlFcjxiHqwT0PeELcEh7BcYCXv0h2EgfC3XWYy2OvD3+KWJjrrxurZ7zipzmlOk=; Message-ID: <949cdc03-608e-2d9c-1e00-86d7cddc67eb@xen.org> Date: Tue, 17 May 2022 18:36:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 03/14] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-4-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-4-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vikram, On 08/03/2022 19:46, Vikram Garhwal wrote: > This is done to access fdt library function which are required for adding device > tree overlay nodes for dynamic programming of nodes. > > Acked-by: Julien Grall > Signed-off-by: Vikram Garhwal The tags usually are usually ordered chronogically. You first wrote the patch and then I provided a review. So your Signed-off-by should come first and then my Acked-by. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 17:51:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 17:51:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331363.554860 (Exim 4.92) (envelope-from ) id 1nr1Lr-00029u-Fe; Tue, 17 May 2022 17:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331363.554860; Tue, 17 May 2022 17:51:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Lr-00029n-Cl; Tue, 17 May 2022 17:51:19 +0000 Received: by outflank-mailman (input) for mailman id 331363; Tue, 17 May 2022 17:51:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Lp-00029h-Mf for xen-devel@lists.xenproject.org; Tue, 17 May 2022 17:51:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Lp-00015e-9D; Tue, 17 May 2022 17:51:17 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nr1Lp-0000P6-2t; Tue, 17 May 2022 17:51:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uiHi4V+i15cuTqOokjchtGZX18UqSzhLGnwSdDAe9eI=; b=dgYb8PREkzHWYXkVRmlH2I+ki+ jzrK9J9kR5OHC1VFZmgeA+yEzdSxDFpoFwG7lUjnjp0RdOOyakt1bySczFKEB4XJVJEjhbcWzmQdH Q4JdQLPWwLNpLpGWjJVHnXUA/ESS6YR1Ub/CeDV+W4VIiUq63vVuO9rFqNp95UkfhjVw=; Message-ID: <6a741494-bab9-3679-8bfa-155d2b591ae1@xen.org> Date: Tue, 17 May 2022 18:51:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 04/14] libfdt: overlay: change overlay_get_target() To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-5-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-5-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vikram, On 08/03/2022 19:46, Vikram Garhwal wrote: > Rename overlay_get_target() to fdt_overlay_target_offset() and remove static > function type. > > This is done to get the target path for the overlay nodes which is very useful > in many cases. For example, Xen hypervisor needs it when applying overlays > because Xen needs to do further processing of the overlay nodes, e.g. mapping of > resources(IRQs and IOMMUs) to other VMs, creation of SMMU pagetables, etc. > > This commit is also applied to git://github.com/dgibson/dtc: NIT: I have tried to use this URL and git clone got stuck. Looking at github, they don't seem to list the git:// version. So maybe use https:// > commit: ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7. We have introduced a tag Origin to help tracking commit from other project. The tag looks like: Origin: The commit-id is first the 12-characters of the commit ID. Please also retain the tags: Message-Id: <1637204036-382159-2-git-send-email-fnu.vikram@xilinx.com> Signed-off-by: David Gibson Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 18:01:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:01:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331371.554871 (Exim 4.92) (envelope-from ) id 1nr1VR-0003kg-EY; Tue, 17 May 2022 18:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331371.554871; Tue, 17 May 2022 18:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1VR-0003kZ-BR; Tue, 17 May 2022 18:01:13 +0000 Received: by outflank-mailman (input) for mailman id 331371; Tue, 17 May 2022 18:01:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1VP-0003kP-M3; Tue, 17 May 2022 18:01:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1VP-0001Le-H3; Tue, 17 May 2022 18:01:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1VP-0000kn-3u; Tue, 17 May 2022 18:01:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr1VP-0006cl-3S; Tue, 17 May 2022 18:01:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pLaORf+SvLdW6uioY3KhPk8+OW+h8cE34iISAM6PBq0=; b=zqS30o5kw5vof2t0t7CrFWDWfZ vTnb1ynJ3zsorpUWqHOCXodEwKJfoO7Bes+OxrClTnRuM49Z97Y6TgEhaT/0Vjz2zkdMar97TH7vo IY+uLHC2FpWzZAEmKHsfpEHU/f8T4KKxMMJmjsWu+XxXYYoeNz45P3BojkCNdEpXPZ9Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170513: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 18:01:11 +0000 flight 170513 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170513/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1067 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 86 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 18:04:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:04:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331381.554881 (Exim 4.92) (envelope-from ) id 1nr1Ye-0004RW-Ui; Tue, 17 May 2022 18:04:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331381.554881; Tue, 17 May 2022 18:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Ye-0004RP-Ri; Tue, 17 May 2022 18:04:32 +0000 Received: by outflank-mailman (input) for mailman id 331381; Tue, 17 May 2022 18:04:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Ye-0004RH-0W for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:04:32 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccb2a982-d60b-11ec-837e-e5687231ffcc; Tue, 17 May 2022 20:04:31 +0200 (CEST) Received: by mail-wm1-x32d.google.com with SMTP id k126so10879291wme.2 for ; Tue, 17 May 2022 11:04:31 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id c3-20020adfc6c3000000b0020c5253d8dasm12978625wrh.38.2022.05.17.11.04.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2022 11:04:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccb2a982-d60b-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=EKSmnvJVRKuNiorxmh6RKpW9+C+oBWZuirhwngUpiFA=; b=d8XJLJsZpEXABv6ZORuvVlkZV/eZ0n5QWvVfV1Il8MFmUInxoYkMl3Kmq2wMRGnu/Y tGbJqIujPWUGCNgZ/tqGy1+5cJlA7oXSk+0oDV1jG1oZ7o9gkyVG9ATGIB0RjMTRhhL3 OB76y7+GsffV/CyOU75jAwBwYjMFeWYOacizhtdmid6sisM4pzfceqYcyTq1aNYQkZ42 XcUOTZerZ4FvdaSvcQx0+uErEOW1VaA0Js5mUP10jFw0gcH5pu2DuTZ4HlBZo/OWP7lq bUhyWznZSNRpzW/t/T6xXZf95iBXy/9wwFuCzKZcv/KtEhRZzwvHKypq/MhU7fck63m3 Gdxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EKSmnvJVRKuNiorxmh6RKpW9+C+oBWZuirhwngUpiFA=; b=SYrOVzX9fR3vDBYJYFNh4uaDJracxOckABfwEmrgaQCBkbqigQxVor027PlY8DCfoO 3h/nk6IAgttXiOfujdesLCH79C39xijsMbSNBY2WyB7j8DUwU5qLL5CHQSxXr7OVL9GO wPDo8IV0J2iCXlBqvhBzejECmbwCtxeCmmVPEtJCKnkuOFsROZSjizHUpFrba2mz3Lmn 17JUKblGMDG7LzwPVjnKDClmrq9ywWybUB17tp4lYY3AO5JUijFMu9IV0lqhWdseRH6L lIjW7nUh4w6Wr6p+8E/u7KMio6GDWN12btE8qpq3jpzDP0ulR6ivcSfBZOM9r4PX0J5K w/cw== X-Gm-Message-State: AOAM532o25i5m5otmyl5iSbkrZCwLiAb9Foo5Vf9+al7GwvT4KpZT7SO Ep/xw7wUtEi3alW2cPsV72G4yc4f9qQ= X-Google-Smtp-Source: ABdhPJxvO8aJltdNydOcbp7B8L4owevPlqnxSW+KqTPFcqROlQBAyvV0Gb48z5sSt/DmKwKj8j4PqQ== X-Received: by 2002:a05:600c:3caa:b0:394:8fb8:716 with SMTP id bg42-20020a05600c3caa00b003948fb80716mr32758904wmb.105.1652810670151; Tue, 17 May 2022 11:04:30 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall Subject: [RFC PATCH 0/2] Ability to allocate DMAable pages using unpopulated-alloc Date: Tue, 17 May 2022 21:04:16 +0300 Message-Id: <1652810658-27810-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 From: Oleksandr Tyshchenko Hello all. The purpose of this RFC patch series is to get feedback about supporting the allocation of DMAable pages by Linux's unpopulated-alloc. The unpopulated-alloc feature has been enabled on Arm since the extended-regions support reached upstream. With that (if, of course, we run new Xen version and Xen was able to allocate extended regions), we don't allocate the real RAM pages from host memory and balloon them out (in order to obtain physical memory space to map the guest pages into) anymore, we use the unpopulated pages instead. And it seems that all users I have played with on Arm (I mean, Xen PV and virtio backends) are happy with the pages provided by xen_alloc_unpopulated_pages(). It is worth mentioning that these pages are not contiguous, but this wasn't an issue so far. There is one place, where we still steal RAM pages if user-space Xen PV backend tries to establish grant mapping with a need to be backed by a DMA buffer for the sake of zero-copy (see dma_alloc*() usage in gnttab_dma_alloc_pages()). And, if I am not mistaken (there might be pitfalls which I am not aware of), we could avoid wasting real RAM pages in that particular case also by adding an ability to allocate unpopulated DMAable pages (which are guaranteed to be contiguous in IPA). The benefit is quite clear here: 1. Avoid wasting real RAM pages (reducing the amount of CMA memory usable) for allocating physical memory space to map the granted buffer into (which can be big enough if we deal with Xen PV Display driver using multiple Full HD buffers) 2. Avoid superpage shattering in Xen P2M when establishing stage-2 mapping for that granted buffer 3. Avoid extra operations needed for the granted buffer to be properly mapped and unmapped such as ballooning in/out real RAM pages Please note, there are several TODOs (described in corresponding commit subjects), which I will try to eliminate in next versions if we find a common ground regarding the approach. Any feedback/help would be highly appreciated. Oleksandr Tyshchenko (2): xen/unpopulated-alloc: Introduce helpers for DMA allocations xen/grant-table: Use unpopulated DMAable pages instead of real RAM ones drivers/xen/grant-table.c | 27 +++++++ drivers/xen/unpopulated-alloc.c | 167 ++++++++++++++++++++++++++++++++++++++++ include/xen/xen.h | 15 ++++ 3 files changed, 209 insertions(+) -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 17 18:04:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331382.554893 (Exim 4.92) (envelope-from ) id 1nr1Yh-0004i4-Ck; Tue, 17 May 2022 18:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331382.554893; Tue, 17 May 2022 18:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Yh-0004hx-7t; Tue, 17 May 2022 18:04:35 +0000 Received: by outflank-mailman (input) for mailman id 331382; Tue, 17 May 2022 18:04:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Yf-0004Vy-M8 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:04:33 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd7906a0-d60b-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 20:04:32 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id p5-20020a1c2905000000b003970dd5404dso1694971wmp.0 for ; Tue, 17 May 2022 11:04:32 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id c3-20020adfc6c3000000b0020c5253d8dasm12978625wrh.38.2022.05.17.11.04.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2022 11:04:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd7906a0-d60b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=feA34fPwxNphtEeiKXjdqUR+G6zWJkwwZL1pSvCtX0M=; b=R9tybJsPD2LXpfmErzHoPXBX5wnEtfuDO/IJAB6QCSqRFyn0tmpyLs+kAw80+IaSbH pjiCvnnNRDCffcM9mu3d1ood+LURdpWIFg78PL2VKrwl9A2+kkifa3UGVHKprWGRSwfX aJuwVKVPiDt2NhFn2R/zUgVFXVPxPu4aYOjQvc7E2AUAJqRj+Rs9KT9EU49neFZttysM 434/nYP+gHYgcCFdpQy9EGyZuPKMjwt5uUgjwQHcsN+Xtuwf7j0WR+K35KIBX1GDPKNH QtuU5Tp2Hk/cePtJTq5KyBfyFVkEn7SMd5tpbIGwcJuVggfFrSFTTvHd6Oa2KpyhqP4k erTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=feA34fPwxNphtEeiKXjdqUR+G6zWJkwwZL1pSvCtX0M=; b=XKHENItP3pTvFq5JTg+BtK44LJVPW/PWdHfXwUrGsVryr/4lNjUnyzLgFjwJftPHOj bLfPDruWmkX+xtJM2BrBFd6yhr1flCJdzzqENQUYXGaBZMVAjaiJe7Us6/ggsxz/VXe5 kmnhNBezpFB8bXh4aSSsElWEBlaGIixecTbE+5GIEl7uUXgJpkj9Iv8V9qvvmMORiBSr lMOC8P0BUtCsAdp0/GyW+jP0HPpHPcx0LUASyLxBvBr+pGJ4onrBPS8Khoz9tVXZALf0 urZgFnVP5qDY3eht5FvIqh6ANjJj9773prWO+Lc98pqqEQLv2rahQYryZSgpGDd/bp62 AMww== X-Gm-Message-State: AOAM533xYGTVWCdQ119T1nIxD9RSJewXHQYyrSTYWEydz65AjwMFcILJ Uw8kkW3BHb/JXl71uyLzkpUPSfgfLkw= X-Google-Smtp-Source: ABdhPJz7TB36wEMhYWeFrz4ToySZ+jaRfOo1ZPZFJbivzuABi6OYRgg8cTziB7YMzVs5jZu3iWnS7Q== X-Received: by 2002:a1c:4c06:0:b0:394:65c4:bd03 with SMTP id z6-20020a1c4c06000000b0039465c4bd03mr22488549wmf.8.1652810671355; Tue, 17 May 2022 11:04:31 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall Subject: [RFC PATCH 1/2] xen/unpopulated-alloc: Introduce helpers for DMA allocations Date: Tue, 17 May 2022 21:04:17 +0300 Message-Id: <1652810658-27810-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1652810658-27810-1-git-send-email-olekstysh@gmail.com> References: <1652810658-27810-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Add ability to allocate unpopulated DMAable (contiguous) pages suitable for grant mapping into. This is going to be used by gnttab code (see gnttab_dma_alloc_pages()). TODO: There is a code duplication in fill_dma_pool(). Also pool oparations likely need to be protected by the lock. Signed-off-by: Oleksandr Tyshchenko --- drivers/xen/unpopulated-alloc.c | 167 ++++++++++++++++++++++++++++++++++++++++ include/xen/xen.h | 15 ++++ 2 files changed, 182 insertions(+) diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c index a39f2d3..bca0198 100644 --- a/drivers/xen/unpopulated-alloc.c +++ b/drivers/xen/unpopulated-alloc.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include #include #include @@ -16,6 +17,8 @@ static DEFINE_MUTEX(list_lock); static struct page *page_list; static unsigned int list_count; +static struct gen_pool *dma_pool; + static struct resource *target_resource; /* @@ -230,6 +233,161 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages) } EXPORT_SYMBOL(xen_free_unpopulated_pages); +static int fill_dma_pool(unsigned int nr_pages) +{ + struct dev_pagemap *pgmap; + struct resource *res, *tmp_res = NULL; + void *vaddr; + unsigned int alloc_pages = round_up(nr_pages, PAGES_PER_SECTION); + struct range mhp_range; + int ret; + + res = kzalloc(sizeof(*res), GFP_KERNEL); + if (!res) + return -ENOMEM; + + res->name = "Xen DMA pool"; + res->flags = IORESOURCE_MEM | IORESOURCE_BUSY; + + mhp_range = mhp_get_pluggable_range(true); + + ret = allocate_resource(target_resource, res, + alloc_pages * PAGE_SIZE, mhp_range.start, mhp_range.end, + PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL); + if (ret < 0) { + pr_err("Cannot allocate new IOMEM resource\n"); + goto err_resource; + } + + /* + * Reserve the region previously allocated from Xen resource to avoid + * re-using it by someone else. + */ + if (target_resource != &iomem_resource) { + tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL); + if (!res) { + ret = -ENOMEM; + goto err_insert; + } + + tmp_res->name = res->name; + tmp_res->start = res->start; + tmp_res->end = res->end; + tmp_res->flags = res->flags; + + ret = request_resource(&iomem_resource, tmp_res); + if (ret < 0) { + pr_err("Cannot request resource %pR (%d)\n", tmp_res, ret); + kfree(tmp_res); + goto err_insert; + } + } + + pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL); + if (!pgmap) { + ret = -ENOMEM; + goto err_pgmap; + } + + pgmap->type = MEMORY_DEVICE_GENERIC; + pgmap->range = (struct range) { + .start = res->start, + .end = res->end, + }; + pgmap->nr_range = 1; + pgmap->owner = res; + + vaddr = memremap_pages(pgmap, NUMA_NO_NODE); + if (IS_ERR(vaddr)) { + pr_err("Cannot remap memory range\n"); + ret = PTR_ERR(vaddr); + goto err_memremap; + } + + ret = gen_pool_add_virt(dma_pool, (unsigned long)vaddr, res->start, + alloc_pages * PAGE_SIZE, NUMA_NO_NODE); + if (ret) + goto err_pool; + + return 0; + +err_pool: + memunmap_pages(pgmap); +err_memremap: + kfree(pgmap); +err_pgmap: + if (tmp_res) { + release_resource(tmp_res); + kfree(tmp_res); + } +err_insert: + release_resource(res); +err_resource: + kfree(res); + return ret; +} + +/** + * xen_alloc_unpopulated_dma_pages - alloc unpopulated DMAable pages + * @dev: valid struct device pointer + * @nr_pages: Number of pages + * @pages: pages returned + * @return 0 on success, error otherwise + */ +int xen_alloc_unpopulated_dma_pages(struct device *dev, unsigned int nr_pages, + struct page **pages) +{ + void *vaddr; + bool filled = false; + unsigned int i; + int ret; + + if (!dma_pool) + return -ENODEV; + + /* XXX Handle devices which support 64-bit DMA address only for now */ + if (dma_get_mask(dev) != DMA_BIT_MASK(64)) + return -EINVAL; + + while (!(vaddr = (void *)gen_pool_alloc(dma_pool, nr_pages * PAGE_SIZE))) { + if (filled) + return -ENOMEM; + else { + ret = fill_dma_pool(nr_pages); + if (ret) + return ret; + + filled = true; + } + } + + for (i = 0; i < nr_pages; i++) + pages[i] = virt_to_page(vaddr + PAGE_SIZE * i); + + return 0; +} +EXPORT_SYMBOL(xen_alloc_unpopulated_dma_pages); + +/** + * xen_free_unpopulated_dma_pages - return unpopulated DMAable pages + * @dev: valid struct device pointer + * @nr_pages: Number of pages + * @pages: pages to return + */ +void xen_free_unpopulated_dma_pages(struct device *dev, unsigned int nr_pages, + struct page **pages) +{ + void *vaddr; + + if (!dma_pool) + return; + + vaddr = page_to_virt(pages[0]); + + gen_pool_free(dma_pool, (unsigned long)vaddr, nr_pages * PAGE_SIZE); +} +EXPORT_SYMBOL(xen_free_unpopulated_dma_pages); + static int __init unpopulated_init(void) { int ret; @@ -241,8 +399,17 @@ static int __init unpopulated_init(void) if (ret) { pr_err("xen:unpopulated: Cannot initialize target resource\n"); target_resource = NULL; + return ret; } + dma_pool = gen_pool_create(PAGE_SHIFT, NUMA_NO_NODE); + if (!dma_pool) { + pr_err("xen:unpopulated: Cannot create DMA pool\n"); + return -ENOMEM; + } + + gen_pool_set_algo(dma_pool, gen_pool_best_fit, NULL); + return ret; } early_initcall(unpopulated_init); diff --git a/include/xen/xen.h b/include/xen/xen.h index a99bab8..a6a7a59 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -52,9 +52,15 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, extern u64 xen_saved_max_mem_size; #endif +struct device; + #ifdef CONFIG_XEN_UNPOPULATED_ALLOC int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages); void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages); +int xen_alloc_unpopulated_dma_pages(struct device *dev, unsigned int nr_pages, + struct page **pages); +void xen_free_unpopulated_dma_pages(struct device *dev, unsigned int nr_pages, + struct page **pages); #include int arch_xen_unpopulated_init(struct resource **res); #else @@ -69,6 +75,15 @@ static inline void xen_free_unpopulated_pages(unsigned int nr_pages, { xen_free_ballooned_pages(nr_pages, pages); } +static inline int xen_alloc_unpopulated_dma_pages(struct device *dev, + unsigned int nr_pages, struct page **pages) +{ + return -1; +} +static inline void xen_free_unpopulated_dma_pages(struct device *dev, + unsigned int nr_pages, struct page **pages) +{ +} #endif #endif /* _XEN_XEN_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 17 18:04:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331383.554897 (Exim 4.92) (envelope-from ) id 1nr1Yh-0004kq-Mq; Tue, 17 May 2022 18:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331383.554897; Tue, 17 May 2022 18:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Yh-0004kR-H3; Tue, 17 May 2022 18:04:35 +0000 Received: by outflank-mailman (input) for mailman id 331383; Tue, 17 May 2022 18:04:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1Yg-0004Vy-FR for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:04:34 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cdef61e8-d60b-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 20:04:33 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso1895125wma.0 for ; Tue, 17 May 2022 11:04:33 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id c3-20020adfc6c3000000b0020c5253d8dasm12978625wrh.38.2022.05.17.11.04.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 May 2022 11:04:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdef61e8-d60b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xUxnvY0wWYvQFwVkkKnZ0hYzB77/1hWqL1wilzE489c=; b=kb8ddVNGcr5cVeafnyHPeYNXQERd/qF31HFkfUdq2R0uWdYsIrV5qJc5rqOLz8AJ2R LeqlzPakVREbISyj+rzFqGHtWdSCexiQvfb3BzQZY4Gb6WIGH1gnWvSpBsaSAoOAgJPw Y2gQVbghkdgpguWD5R6ZUeT1mykXPwp1lsXvUamDbQaFqmfp7ZJs19gwZMPPJzKo2yI5 qsxQdCIXfE44XW+Ui9ZV8j0XprUOYnEv+bHcF2+ibhH3I9NCtjxHxMwKRYDXdrArzigQ AkB6D1SgJLfFBjy+aEuoy/qrUgNvZwQus2tAbvnVgDGakrkC9Xvt3cWzsnYci380bHt5 MjFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xUxnvY0wWYvQFwVkkKnZ0hYzB77/1hWqL1wilzE489c=; b=babiyVOFuR1fChbdaLJ8r5mJB91tqUFB4syB6bKZ6SV1whYpKNMCWpwvPa83PWsLJR 79J4xD+xceunW/JkYDA4JEG08VvZHKpUQBLRleDYFsJgrbmrLjFK7MSHPsNiM+j+yhge 3n6//6kYpqm0nE2fy+x47dRviFrH+Wj4uZJVzWp3wTQwioZVx2HxPpI81dJj2kD1ZroE hXDZLew0T2vxnG6ocebFhfOrCgc+w12PwrdmlVzCYhtT2GbilnCBVrfC/TX6QTLG3zBZ 7ALIO4/84l8BcOfjliALjEjtlrzDby3Z0TbBBJR2x5xgmu+LDlx8OMcDgkC+5JV8eL8k zx9Q== X-Gm-Message-State: AOAM531Ek7ITc86+RLsWC/ss/PMyO1WPRNXjCMhAtW8EQ0o1SDLas1mL 9hHw3ZMn5p+3mbNcWS0i/x1WpnFyju8= X-Google-Smtp-Source: ABdhPJzy8So6LUCbbqsaVyGqZpkGWh1nIJifHTvsH6tXSl1Cxhg/tQhSmkYmww8KULDXmX3Xv/O7fQ== X-Received: by 2002:a05:600c:1989:b0:394:8dc0:b57f with SMTP id t9-20020a05600c198900b003948dc0b57fmr33101152wmq.110.1652810672320; Tue, 17 May 2022 11:04:32 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall Subject: [RFC PATCH 2/2] xen/grant-table: Use unpopulated DMAable pages instead of real RAM ones Date: Tue, 17 May 2022 21:04:18 +0300 Message-Id: <1652810658-27810-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1652810658-27810-1-git-send-email-olekstysh@gmail.com> References: <1652810658-27810-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Depends on CONFIG_XEN_UNPOPULATED_ALLOC. If enabled then unpopulated DMAable (contiguous) pages will be allocated for grant mapping into instead of ballooning out real RAM pages. TODO: Fallback to real RAM pages if xen_alloc_unpopulated_dma_pages() fails. Signed-off-by: Oleksandr Tyshchenko --- drivers/xen/grant-table.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 8ccccac..2bb4392 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -864,6 +864,25 @@ EXPORT_SYMBOL_GPL(gnttab_free_pages); */ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args) { +#ifdef CONFIG_XEN_UNPOPULATED_ALLOC + int ret; + + ret = xen_alloc_unpopulated_dma_pages(args->dev, args->nr_pages, + args->pages); + if (ret < 0) + return ret; + + ret = gnttab_pages_set_private(args->nr_pages, args->pages); + if (ret < 0) { + gnttab_dma_free_pages(args); + return ret; + } + + args->vaddr = page_to_virt(args->pages[0]); + args->dev_bus_addr = page_to_phys(args->pages[0]); + + return ret; +#else unsigned long pfn, start_pfn; size_t size; int i, ret; @@ -910,6 +929,7 @@ int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args) fail: gnttab_dma_free_pages(args); return ret; +#endif } EXPORT_SYMBOL_GPL(gnttab_dma_alloc_pages); @@ -919,6 +939,12 @@ EXPORT_SYMBOL_GPL(gnttab_dma_alloc_pages); */ int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args) { +#ifdef CONFIG_XEN_UNPOPULATED_ALLOC + gnttab_pages_clear_private(args->nr_pages, args->pages); + xen_free_unpopulated_dma_pages(args->dev, args->nr_pages, args->pages); + + return 0; +#else size_t size; int i, ret; @@ -946,6 +972,7 @@ int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args) dma_free_wc(args->dev, size, args->vaddr, args->dev_bus_addr); return ret; +#endif } EXPORT_SYMBOL_GPL(gnttab_dma_free_pages); #endif -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue May 17 18:13:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331406.554915 (Exim 4.92) (envelope-from ) id 1nr1hh-0007Be-KK; Tue, 17 May 2022 18:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331406.554915; Tue, 17 May 2022 18:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1hh-0007BX-Ge; Tue, 17 May 2022 18:13:53 +0000 Received: by outflank-mailman (input) for mailman id 331406; Tue, 17 May 2022 18:13:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1hf-0007BO-8g for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:13:51 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17ff14da-d60d-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 20:13:47 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nr1gv-008nSU-6m; Tue, 17 May 2022 20:13:05 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17ff14da-d60d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6MSK1Z4Nv/e1GFKFinCP8P3dIYao0CoLyUe3quXpDhY=; b=cRMrVSVTR+3cn6FVG65SC4Au0y UkLE3SVfqGk36g/jG1E9IomGRvED5Awi+eOSCTntuGE0jPXl5+kfHlbKsvhvVjaCNf8y4mBWXGPlT 8r/o/CMKhbUaIdrKhLkt446cgXa07HTSiorku/w0xJvIn3aE4uqi2qj8QGi7eb4Kmsg0/Wh5BR8Vi YCGb8f9djqv6fWXVwjRpFQtg+9b6W6H4TQisr9ZwQKSIB4SsmfEWL196/jrcNQFL2lm66S4LfYE8s uZ+fz2jSIIuBy2Np//l8BP/gbXHu+JyZVeJsb8IAXoZSlvi3RYMR9sSIMXj8sSzR7kYxeP4KKKokk nGGtp5Zg==; Message-ID: <62a63fc2-346f-f375-043a-fa21385279df@igalia.com> Date: Tue, 17 May 2022 15:12:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Content-Language: en-US To: "Luck, Tony" , Petr Mladek , Dinh Nguyen Cc: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , Corey Minyard , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , Heiko Carstens , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , Matt Turner , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Weinberger , Robert Richter , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Vasily Gorbik , Wei Liu References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> <599b72f6-76a4-8e6d-5432-56fb1ffd7e0b@igalia.com> <06d85642fef24bc482642d669242654b@intel.com> From: "Guilherme G. Piccoli" In-Reply-To: <06d85642fef24bc482642d669242654b@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/05/2022 14:02, Luck, Tony wrote: >> Tony / Dinh - can I just *skip* this notifier *if kdump* is set or else >> we run the code as-is? Does that make sense to you? > > The "skip" option sounds like it needs some special flag associated with > an entry on the notifier chain. But there are other notifier chains ... so that > sounds messy to me. > > Just all the notifiers in priority order. If any want to take different actions > based on kdump status, change the code. That seems more flexible than > an "all or nothing" approach by skipping. > > -Tony I guess I've expressed myself in a poor way - sorry! What I'm planning to do in the altera_edac notifier is: if (kdump_is_set) return; /* regular code */ In other words: if the kdump is set, this notifier will be effectively a nop (although it's gonna be called). Lemme know your thoughts Tony, if that makes sense. Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 17 18:19:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:19:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331418.554925 (Exim 4.92) (envelope-from ) id 1nr1nA-0007pj-7S; Tue, 17 May 2022 18:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331418.554925; Tue, 17 May 2022 18:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1nA-0007pc-4X; Tue, 17 May 2022 18:19:32 +0000 Received: by outflank-mailman (input) for mailman id 331418; Tue, 17 May 2022 18:19:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1n9-0007pW-BS for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:19:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr1n8-0001hd-4v; Tue, 17 May 2022 18:19:30 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.147.55]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nr1n7-0002O0-Tk; Tue, 17 May 2022 18:19:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TqLslw6Jw+aq1LB6AjK4iMjV9CAMB5hPzOKylZ6obik=; b=amaQoJtiYiLTUm4JbTTDNRF/Ic 7qiR2Sr1oL2ULouIUdrIC7u6X08/wAe/jPiWiqrm0QIcUroarbJWmSytITBJNdD7bsUrZU1giqOMq yABbpyXDIQbe2MUrVVv6JplCyt0IJtVE8YoI+iA9F4U8aJCrmlTgrAZUmmwVaxEgTvnQ=; Message-ID: <2cfaf0c9-a9c5-1ada-cd78-900b7497519c@xen.org> Date: Tue, 17 May 2022 19:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 07/14] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-8-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-8-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/03/2022 19:46, Vikram Garhwal wrote: > Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_lock(). > > Moving spin_lock to caller was done to prevent the concurrent access to > iommu_dt_device_is_assigned while doing add/remove/assign/deassign. > > Signed-off-by: Vikram Garhwal > --- > xen/drivers/passthrough/device_tree.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c > index 98f2aa0dad..b3b04f8e03 100644 > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -83,16 +83,14 @@ fail: > return rc; > } > > -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) > +static bool_t iommu_dt_device_is_assigned_lock(const struct dt_device_node *dev) NIT: We tend to use "_locked" when a function should be called with the lock taken. > { > bool_t assigned = 0; > > if ( !dt_device_is_protected(dev) ) > return 0; > > - spin_lock(&dtdevs_lock); > assigned = !list_empty(&dev->domain_list); > - spin_unlock(&dtdevs_lock); > > return assigned; > } > @@ -225,12 +223,17 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, > > if ( domctl->cmd == XEN_DOMCTL_test_assign_device ) > { > - if ( iommu_dt_device_is_assigned(dev) ) > + spin_lock(&dtdevs_lock); Is this actually sufficient? IOW what will ensure that the "dev" doesn't disappear between the time we look it up (see dt_find_node_by_gpath()) and we check the assignment? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 17 18:42:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:42:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331426.554937 (Exim 4.92) (envelope-from ) id 1nr29B-0002fw-2s; Tue, 17 May 2022 18:42:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331426.554937; Tue, 17 May 2022 18:42:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr29A-0002fp-Vv; Tue, 17 May 2022 18:42:16 +0000 Received: by outflank-mailman (input) for mailman id 331426; Tue, 17 May 2022 18:42:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr299-0002fU-Pc for xen-devel@lists.xenproject.org; Tue, 17 May 2022 18:42:15 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 115fda80-d611-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 20:42:13 +0200 (CEST) Received: from [192.168.1.39] (unknown [81.93.39.129]) by support.bugseng.com (Postfix) with ESMTPSA id D41284EE077A; Tue, 17 May 2022 20:42:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 115fda80-d611-11ec-bd2c-47488cf2e6aa Message-ID: Date: Tue, 17 May 2022 20:42:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050929 Thunderbird/1.0.7 Fedora/1.0.7-1.1.fc4 Mnenhy/0.7.3.0 Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Xen-devel References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> <000745e7-0b0e-386e-861e-901319defde3@suse.com> From: Roberto Bagnara In-Reply-To: <000745e7-0b0e-386e-861e-901319defde3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 17/05/22 17:38, Jan Beulich wrote: > On 09.05.2022 14:24, Andrew Cooper wrote: >> Spotted by Eclair MISRA scanner. > > I'm sorry, but what exactly was it that the scanner spotted? It was > actually deliberate to introduce this file without guards. I'm of > the general opinion that (private) headers not to be included by > other headers (but only by .c files) are not in need of guards. If > it is project-wide consensus that _all_ header files should have > guards, then I'll try to keep this in mind (in "x86emul: a few > small steps towards disintegration" for example I introduce > another such instance), but then it should also be put down in > ./CODING_STYLE. The rationale of this rule is as follows: - With a complex hierarchy of nested header files, it is possible for a header file to be included more than once. - This can bring to circular references of header files, which can result in undefined behavior and/or be difficult to debug. - If multiple inclusion leads to multiple or conflicting definitions, then this can result in undefined or erroneous behavior. - Compilation and analysis time is needlessly increased. There has been a period (which lasted until the end of the '70s or the beginning of the '80s, I would have to dig up to be more precise) when the solution was thought to be "headers shall not to be included by other headers but only by .c files." Experience then showed that, in medium to large projects, each .c file had to begin with a long list of #include directives; such lists needed to be ordered to accommodate the dependencies between header files; in some cases the lists were so long that: a) it was a kind of black magic to find out the right inclusion order, one that would work in any of possibly many project configurations; b) the lists of #include directives often contained duplicates, possibly because the desperate programmers where trying to find the right order. In the end, the software engineering community converged on the idea that guards against multiple inclusion are a much better alternative. Of course there are valid reasons to deviate the rule: some header files might be conceived to be included multiple times. A one-line configuration for ECLAIR will do the trick to make sure such header files are not reported. Kind regards, Roberto >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> CC: Stefano Stabellini >> CC: Julien Grall >> CC: Volodymyr Babchuk >> CC: Bertrand Marquis >> --- >> xen/arch/x86/mm/p2m.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h >> index cc0f6766e4df..dc706b8e4799 100644 >> --- a/xen/arch/x86/mm/p2m.h >> +++ b/xen/arch/x86/mm/p2m.h >> @@ -15,6 +15,9 @@ >> * along with this program; If not, see . >> */ >> >> +#ifndef __ARCH_MM_P2M_H__ >> +#define __ARCH_MM_P2M_H__ >> + >> struct p2m_domain *p2m_init_one(struct domain *d); >> void p2m_free_one(struct p2m_domain *p2m); >> >> @@ -39,6 +42,8 @@ int ept_p2m_init(struct p2m_domain *p2m); >> void ept_p2m_uninit(struct p2m_domain *p2m); >> void p2m_init_altp2m_ept(struct domain *d, unsigned int i); >> >> +#endif /* __ARCH_MM_P2M_H__ */ >> + >> /* >> * Local variables: >> * mode: C > > From xen-devel-bounces@lists.xenproject.org Tue May 17 18:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 18:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331439.554948 (Exim 4.92) (envelope-from ) id 1nr2FE-0003RU-Si; Tue, 17 May 2022 18:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331439.554948; Tue, 17 May 2022 18:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2FE-0003RN-Pu; Tue, 17 May 2022 18:48:32 +0000 Received: by outflank-mailman (input) for mailman id 331439; Tue, 17 May 2022 18:48:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2FD-0003RD-7m; Tue, 17 May 2022 18:48:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2FD-0002As-6L; Tue, 17 May 2022 18:48:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2FC-0001oQ-My; Tue, 17 May 2022 18:48:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr2FC-0000Ua-MX; Tue, 17 May 2022 18:48:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hNC8g7SkP4G6u2cj0QUtgXaPxzfq1TF4AM0nDXPerso=; b=XpkuLavS5aLrH+M0Mx6mU+wIYz DYLb6hHjcHGhAWCBJSBM8w93u9pyjMOC1cE3idbKGfMg201AHl7tdREvt46+k/zfk9P+/8Vq+04bJ Afpx/gh3RpN5cX50rwE3KUgGubxhwNNn3+ZQMXgNN8hbNEGIjTgzeIyuopcDoXHdACKA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170515: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 18:48:30 +0000 flight 170515 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170515/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1068 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 87 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 19:08:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 19:08:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331449.554959 (Exim 4.92) (envelope-from ) id 1nr2YB-0005ua-HJ; Tue, 17 May 2022 19:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331449.554959; Tue, 17 May 2022 19:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2YB-0005uT-EM; Tue, 17 May 2022 19:08:07 +0000 Received: by outflank-mailman (input) for mailman id 331449; Tue, 17 May 2022 19:08:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr2Y9-0005uN-4k for xen-devel@lists.xenproject.org; Tue, 17 May 2022 19:08:05 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa9c5dc5-d614-11ec-837e-e5687231ffcc; Tue, 17 May 2022 21:08:01 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 12:07:58 -0700 Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 17 May 2022 12:07:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 12:07:55 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 12:07:55 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2308.027; Tue, 17 May 2022 12:07:55 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa9c5dc5-d614-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652814481; x=1684350481; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dMu3qmaQOzDmPfmmDPn/58HAfnv205GwUCrX1kk3ZHk=; b=UstW7IB9SExFC4y2nGop6Pb5l/DA//aaFkJro4864uBwZnKpokFle51Z uFqyKOCxkua4bkscIXaF3kmdQ4LztoHh9SQRNMat5HYyn/ipAI7RMSuwm Q2/EHofL0PhwjXSUghb83D2jPCijQf2uMPl2tZ0uR1MgynB65CVwNwDnp r90h8/eF5o/lEN2Q7pYtWGL4kWoAbWXwb/7UKZCN5WmUceLHeED4XiNY1 Dv1SzQYbOXwgm8tzDnhseHrS8R3EsR1qb+DdHIJzXTtEUAcLm3SwLFfT+ rJi0ZpcUKee8Qs2LU0WJ+p9MvD3MIVSI2JuLO6zesfoNErXdLIGMiJisc A==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270985081" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="270985081" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="605497608" From: "Luck, Tony" To: "Guilherme G. Piccoli" , Petr Mladek , Dinh Nguyen CC: "akpm@linux-foundation.org" , "bhe@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-alpha@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-leds@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-remoteproc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-um@lists.infradead.org" , "linux-xtensa@linux-xtensa.org" , "netdev@vger.kernel.org" , "openipmi-developer@lists.sourceforge.net" , "rcu@vger.kernel.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "x86@kernel.org" , "kernel-dev@igalia.com" , "kernel@gpiccoli.net" , "halves@canonical.com" , "fabiomirmar@gmail.com" , "alejandro.j.jimenez@oracle.com" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "bp@alien8.de" , "corbet@lwn.net" , "d.hatayama@jp.fujitsu.com" , "dave.hansen@linux.intel.com" , "dyoung@redhat.com" , "Tang, Feng" , "gregkh@linuxfoundation.org" , "mikelley@microsoft.com" , "hidehiro.kawai.ez@hitachi.com" , "jgross@suse.com" , "john.ogness@linutronix.de" , "keescook@chromium.org" , "luto@kernel.org" , "mhiramat@kernel.org" , "mingo@redhat.com" , "paulmck@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "senozhatsky@chromium.org" , "stern@rowland.harvard.edu" , "tglx@linutronix.de" , "vgoyal@redhat.com" , "vkuznets@redhat.com" , "will@kernel.org" , Alex Elder , Alexander Gordeev , Anton Ivanov , Benjamin Herrenschmidt , Bjorn Andersson , Boris Ostrovsky , Chris Zankel , Christian Borntraeger , "Corey Minyard" , Dexuan Cui , "H. Peter Anvin" , Haiyang Zhang , "Heiko Carstens" , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , James Morse , Johannes Berg , "K. Y. Srinivasan" , Mathieu Poirier , "Matt Turner" , Mauro Carvalho Chehab , Max Filippov , Michael Ellerman , Paul Mackerras , Pavel Machek , "Richard Weinberger" , Robert Richter , "Stefano Stabellini" , Stephen Hemminger , Sven Schnelle , "Vasily Gorbik" , Wei Liu Subject: RE: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Topic: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list Thread-Index: AQHYWooLnXaT7guJw0OCpuGv/IkEoK0iJCSAgAAZuAD//40QkIAAesuAgAFqbACAACtDgP//jcxAgACKZID//5nyAA== Date: Tue, 17 May 2022 19:07:54 +0000 Message-ID: <7f9f6feb9f494b0288deab718807172d@intel.com> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-22-gpiccoli@igalia.com> <63a74b56-89ef-8d1f-d487-cdb986aab798@igalia.com> <599b72f6-76a4-8e6d-5432-56fb1ffd7e0b@igalia.com> <06d85642fef24bc482642d669242654b@intel.com> <62a63fc2-346f-f375-043a-fa21385279df@igalia.com> In-Reply-To: <62a63fc2-346f-f375-043a-fa21385279df@igalia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 PiBXaGF0IEknbSBwbGFubmluZyB0byBkbyBpbiB0aGUgYWx0ZXJhX2VkYWMgbm90aWZpZXIgaXM6 DQo+DQo+IGlmIChrZHVtcF9pc19zZXQpDQo+ICAgcmV0dXJuOw0KDQpZZXMuIFRoYXQncyB3aGF0 IEkgdGhpbmsgc2hvdWxkIGhhcHBlbi4NCg0KLVRvbnkNCg== From xen-devel-bounces@lists.xenproject.org Tue May 17 19:41:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 19:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331457.554969 (Exim 4.92) (envelope-from ) id 1nr34d-0001gc-4K; Tue, 17 May 2022 19:41:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331457.554969; Tue, 17 May 2022 19:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34d-0001gV-1M; Tue, 17 May 2022 19:41:39 +0000 Received: by outflank-mailman (input) for mailman id 331457; Tue, 17 May 2022 19:41:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34c-0001gP-La for xen-devel@lists.xenproject.org; Tue, 17 May 2022 19:41:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5be0e18d-d619-11ec-837e-e5687231ffcc; Tue, 17 May 2022 21:41:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5be0e18d-d619-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652816496; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aBugvKDimbdDHpVRY9poQsYTk8AfjAaSmNls4jiErmU=; b=G6RbNV2L6ofpWqbQ4BF5EtrLZAjxaKv+4/02f5halT9S2DB7LiaXeFmn HgKt3SDWFyQKU088hdhC2wXR9KP/5tDlgZjDYPnONosBE5vqpUDhAb73F FJ+H1YHij8opS4U9wus+W4fDwFRqEwoVWW6fjk2RE4EXrXIT7elH7aS3S k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71543646 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jZw2kq7coxSGItJ8P3WKiAxRtFrHchMFZxGqfqrLsTDasY5as4F+v jAfC2qDPfqPZTb1eNlyb9y3pBsAuMfSz9I3Swtp/CE0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgXFvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSZUyx1YKvpqt8DDTQBSRAnPaZh4YLYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT 5VANGY0MkieC/FJEmo9Fq4xrOWPvVX+Uj97jnyZmooovFGGmWSd15CyaYGIK7RmX/59mluTr yTI9mLyDxUeKfSW0z/D+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA xVKoGx09/F0rRH1CImmN/GlnJKaljcGcIYOFcgI0x/T5/OO0l+ZDU8dcyEUPbTKq/QKbTAt0 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/45SMaIYsvJ9SYcK txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCskPeZJhKTysDA3CMqsy67AFzG8U IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWn3qyf5Id0JvmomTKuMDirjUWa5C HI/RCsLvMMDVJdURfEfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY M/zWZ/1UR4yVPU8pBLrFrh17FPe7n1nrY8lbcujn0rPPHv3TCP9dIrpx3PVMLxotP7e8VyMm zudXuPToyhivCTFSnG/2eYuwZoidxDX2bieRxRrS9O+ IronPort-HdrOrdr: A9a23:4/aJ8qNHgQ/9j8BcTvujsMiBIKoaSvp037Eqv3oRdfUzSL3hqy nOpoVj6faaskdzZJhNo7+90ey7MBfhHP1OkO8s1NWZLWvbUQKTRekIh+aP/9SjIVyYygc079 YaT0EUMr3N5DZB4/oSmDPIduod/A== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71543646" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Luca Fancellu Subject: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Date: Tue, 17 May 2022 20:41:13 +0100 Message-ID: <20220517194113.2574-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220517194113.2574-1-andrew.cooper3@citrix.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sadly, cpupool IDs are chosen by the caller, not assigned sequentially, so this does need to have a full 32 bits of range. Also leave a BUILD_BUG_ON() to catch more obvious ABI changes in the future. Fixes: 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: Edwin Török CC: Luca Fancellu --- tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/ocaml/libs/xc/xenctrl_stubs.c | 8 +++++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 7503031d8f61..8eab6f60eb14 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -85,6 +85,7 @@ type domctl_create_config = max_grant_frames: int; max_maptrack_frames: int; max_grant_version: int; + cpupool_id: int32; arch: arch_domainconfig; } diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d1d9c9247afc..d3014a2708d8 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -77,6 +77,7 @@ type domctl_create_config = { max_grant_frames: int; max_maptrack_frames: int; max_grant_version: int; + cpupool_id: int32; arch: arch_domainconfig; } diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 5b4fe72c8dec..513ee142d2a0 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -189,7 +189,8 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config #define VAL_MAX_GRANT_FRAMES Field(config, 6) #define VAL_MAX_MAPTRACK_FRAMES Field(config, 7) #define VAL_MAX_GRANT_VERSION Field(config, 8) -#define VAL_ARCH Field(config, 9) +#define VAL_CPUPOOL_ID Field(config, 9) +#define VAL_ARCH Field(config, 10) uint32_t domid = Int_val(wanted_domid); int result; @@ -201,6 +202,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config .max_maptrack_frames = Int_val(VAL_MAX_MAPTRACK_FRAMES), .grant_opts = XEN_DOMCTL_GRANT_version(Int_val(VAL_MAX_GRANT_VERSION)), + .cpupool_id = Int32_val(VAL_CPUPOOL_ID), }; domain_handle_of_uuid_string(cfg.handle, String_val(VAL_HANDLE)); @@ -225,6 +227,9 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config case 1: /* X86 - emulation flags in the block */ #if defined(__i386__) || defined(__x86_64__) + /* Quick & dirty check for ABI changes. */ + BUILD_BUG_ON(sizeof(cfg) != 64); + /* Mnemonics for the named fields inside xen_x86_arch_domainconfig */ #define VAL_EMUL_FLAGS Field(arch_domconfig, 0) @@ -254,6 +259,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config } #undef VAL_ARCH +#undef VAL_CPUPOOL_ID #undef VAL_MAX_GRANT_VERSION #undef VAL_MAX_MAPTRACK_FRAMES #undef VAL_MAX_GRANT_FRAMES -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 19:41:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 19:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331458.554981 (Exim 4.92) (envelope-from ) id 1nr34h-0001wx-Aw; Tue, 17 May 2022 19:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331458.554981; Tue, 17 May 2022 19:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34h-0001wo-8K; Tue, 17 May 2022 19:41:43 +0000 Received: by outflank-mailman (input) for mailman id 331458; Tue, 17 May 2022 19:41:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34g-0001wE-D0 for xen-devel@lists.xenproject.org; Tue, 17 May 2022 19:41:42 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e4c22c5-d619-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 21:41:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e4c22c5-d619-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652816500; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=vnkTDze3G4oFOaHVWufMPnc4Xim+l6INdmwqKwzAzBc=; b=IopsoZYcgWM3VmNXwNExevkOpDvh6dVLO+j8hs72glae7McHlF/Hd0WA UeoVDyLZswu4K1PYr2O2xc5pPfj2nfJtn/7D7q5Y/fp8EXsom2z/j29Wh NRWsvM6rVMKvZ773Jam6DyXE96BQ0PNyApsj8jf34/SCnbSfSiVN3RR6p k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71530633 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QB/tyajVZOaFHuG4PLaS3DGYX161aRAKZh0ujC45NGQN5FlHY01je htvXmzSa/iNZDb8eNFxO46//BsCsZ/TyNU1HlA9qS03Fnkb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrS4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YUAyP/L9v89AaUJFNihsZZ8Y34LGBXfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i 88xNmMyN0yeOEYn1lE/LpQ8l8ywjGvEcWdosgKE+u0nxmjew1kkuFTqGIWMIYHbLSlPpW6Uq GvJ8GX+BhAyL8GExHyO9XfEruvSliq9VosUH7C88uNCiUeWgGcUDXU+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaGsQQbQMF4CPAh5UeGza+83uqCLjFaFHgbMoVg7ZJoA2xxv rOUoz/3LXt0seKkblnAzOyJiDqgYRpLClIDQSBRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/ tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/pn0vp5p0xWG2DaD+qXNEBz0ohaekXh4um0WGauQGp9slcXVS EHSoxhNw5RYIWGna6R6C6roVZlwnfG6SYm8CKuMBjarXnSWXFbXlByCmGbKhzy9+KTSuf9X1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfLfyC2Io ok3Cid/40gGOAEISnKPodB7wJFjBSVTOK0aXOQMKLLSelc8STh4YxITqJt4E7FYc21uvr+g1 hmAtoVwkTITWVWvxd22V01e IronPort-HdrOrdr: A9a23:d5IKDqrWHMe8to6ujUaAKlgaV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="71530633" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Juergen Gross , Dario Faggioli , Luca Fancellu Subject: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Date: Tue, 17 May 2022 20:41:12 +0100 Message-ID: <20220517194113.2574-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220517194113.2574-1-andrew.cooper3@citrix.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain c/s cfc52148444f ("xen/domain: Reduce the quantity of initialisation for system domains") removed the path in domain_create() which called sched_init_domain() with CPUPOOLID_NONE for system domains. Arguably, that changeset should have cleaned up this path too. However, c/s 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") changed domain_create() from using a hardcoded poolid of 0, to using a value passed by the toolstack. While CPUPOOLID_NONE is an internal constant, userspace can pass -1 for the cpupool_id parameter and attempt to construct a real domain using default ops, which at a minimum will fail the assertion in dom_scheduler(). Fixes: 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") Signed-off-by: Andrew Cooper --- CC: Juergen Gross CC: Dario Faggioli CC: Luca Fancellu --- xen/common/sched/cpupool.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index f6e3d97e5288..f1aa2db5f463 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -619,8 +619,6 @@ int cpupool_add_domain(struct domain *d, unsigned int poolid) int rc; int n_dom = 0; - if ( poolid == CPUPOOLID_NONE ) - return 0; spin_lock(&cpupool_lock); c = cpupool_find_by_id(poolid); if ( c == NULL ) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 19:41:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 19:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331463.554992 (Exim 4.92) (envelope-from ) id 1nr34t-0002OW-NE; Tue, 17 May 2022 19:41:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331463.554992; Tue, 17 May 2022 19:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34t-0002OP-Jz; Tue, 17 May 2022 19:41:55 +0000 Received: by outflank-mailman (input) for mailman id 331463; Tue, 17 May 2022 19:41:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr34r-0001wE-Oi for xen-devel@lists.xenproject.org; Tue, 17 May 2022 19:41:53 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 656cda25-d619-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 21:41:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 656cda25-d619-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652816512; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7CmCVRbGWxxf/cZI+wx0QRydisRwi8JPYEo/uVFZczw=; b=K6R2IkHAtauYhqcaGXvI90Vt8aru+k9q0fVVCqM6v9XpAaJygDi22BXZ q+1S65a7e6Ous8jRlMjznGanxVO2GavCa0kGwR/l2geX3qCTKMxMCKJxl VSZlxs2uFVkz8F0EAd54tFypBpXQxvGe/D5EN52+FGlVKcilEg2+ZaSKS I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70912451 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:nsfEzKDcqSVC0BVW/77jw5YqxClBgxIJ4kV8jS/XYbTApD530GMAm GtLCmDSaKreZjHyfYxzYI2+8kIG78KDzIRhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng3dYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhKx MpIsduXFzsHAYDNkeFMQQRhGQxhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp8WTK+EO 5dAAdZpRAv9XD5NeWtKNMgnlcv410TgYgd7hmvA8MLb5ECMlVcsgdABKuH9fsGBTINbl0CTq 2bC4kzwGBRcP9uaoRK79Xariv7KjDnMcosYH72l9dZnmFSWgGcUDXU+X1ahveOwjEL4XttFM lEV4QInt610/0uuJvH2Vge0p3OstRcGV91dVeY97Wml0K3P6RyeAWsCZjFEYd0i8sQxQFQC1 FCTmMjyLSdyq7DTQnWYnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdptH7ED7/w jeOrQAlmq4ey8UM0s2T/03Dgj+qjojESEgy/Aq/dnm+8gpzaYqhZoqpwVvW9/BNKMCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGAbQnltrWL5/yxqS1n+qeNFC/Qh0CVg8Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbIEN/p03PUN4jVCZ9oRy2Mq r5i2zOikUk3bQEHSnC/HXQvBV4LN2MnIpv9ttZacOWOSiI/Rjx7W6aLne54Jdc990iwqgsv1 ijtMnK0NXKl3SGXQel0Qi4LhEzTsWZX8itgYH1E0aeA0Hk/e4e/hJrzhLNsFYTLANdLlKYuJ 9FcIp3oKq0WFlzvpmVGBbGg/dMKSfherV/XV8ZTSGNnL8AIqs2g0oKMQzYDAwFVUHbm7ZZk8 uT5vu4ZKLJaLzlf4A/tQKrH5zuMUbI1wYqeg2OgzgFvRXjR IronPort-HdrOrdr: A9a23:q0xgdqz8OFwG9K9/EiYcKrPwIL1zdoMgy1knxilNoRw8SKKlfq eV7ZMmPH7P+VIssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyHJ8SUzI9gPM lbHJSWcOeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.91,233,1647316800"; d="scan'208";a="70912451" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Juergen Gross , Dario Faggioli , Christian Lindig , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Luca Fancellu , "Stefano Stabellini" , Julien Grall , "Volodymyr Babchuk" , Bertrand Marquis , George Dunlap , "Nick Rosbrook" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Doug Goldstein Subject: [PATCH 0/2] Fix some problems with "arm/dom0less: assign dom0less guests to cpupools" Date: Tue, 17 May 2022 20:41:11 +0100 Message-ID: <20220517194113.2574-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ARM folks: Please be rather more careful when exposing hypervisor internals to arbitrary user input. Being domain_create, the fallout is unlikely to be an security issue if it had gotten into a release, but Xen will definitely have an unhappy time with unexpected scheduler state. George/Nick: The Golang bindings seem pre-existingly broken. I get the following spew which is unrelated to this change: ./helpers.gen.go:800[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:1320]: cannot use _Ctype_ulong(numVcpus) * _Cconst_sizeof_libxl_sched_params (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:1292[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:1960]: cannot use _Ctype_ulong(numVcpuHardAffinity) * _Cconst_sizeof_libxl_bitmap (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:1302[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:1970]: cannot use _Ctype_ulong(numVcpuSoftAffinity) * _Cconst_sizeof_libxl_bitmap (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:1336[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:2008]: cannot use _Ctype_ulong(numVnumaNodes) * _Cconst_sizeof_libxl_vnode_info (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:1379[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:2063]: cannot use _Ctype_ulong(numIoports) * _Cconst_sizeof_libxl_ioport_range (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:1397[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:2081]: cannot use _Ctype_ulong(numIomem) * _Cconst_sizeof_libxl_iomem_range (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:2518[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:3919]: cannot use _Ctype_ulong(numConnectors) * _Cconst_sizeof_libxl_connector_param (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:2676[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:4182]: cannot use _Ctype_ulong(numVsndStreams) * _Cconst_sizeof_libxl_vsnd_stream (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:2741[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:4288]: cannot use _Ctype_ulong(numVsndPcms) * _Cconst_sizeof_libxl_vsnd_pcm (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:2930[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:4540]: cannot use _Ctype_ulong(numDisks) * _Cconst_sizeof_libxl_device_disk (type _Ctype_ulong) as type _Ctype_size_t in argument to _Cfunc__CMalloc ./helpers.gen.go:2930[/tmp/go-build762104750/_/local/xen.git/tools/golang/xenlight/_obj/helpers.gen.cgo1.go:4540]: too many errors but this is where my knowledge ends. Needless to say, the golang bindings haven't been regenerated with this change in place. Roger/Stefano/Doug: Given the golang breakage, we are presuamably lacking golang from any of the CI containers. Andrew Cooper (2): xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id tools/ocaml/libs/xc/xenctrl.ml | 1 + tools/ocaml/libs/xc/xenctrl.mli | 1 + tools/ocaml/libs/xc/xenctrl_stubs.c | 8 +++++++- xen/common/sched/cpupool.c | 2 -- 4 files changed, 9 insertions(+), 3 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue May 17 19:58:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 19:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331485.555003 (Exim 4.92) (envelope-from ) id 1nr3KD-0004Zg-4l; Tue, 17 May 2022 19:57:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331485.555003; Tue, 17 May 2022 19:57:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3KD-0004ZZ-0Z; Tue, 17 May 2022 19:57:45 +0000 Received: by outflank-mailman (input) for mailman id 331485; Tue, 17 May 2022 19:57:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3KB-0004ZP-FS; Tue, 17 May 2022 19:57:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3KB-0003oc-57; Tue, 17 May 2022 19:57:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3KA-0003PX-Pc; Tue, 17 May 2022 19:57:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr3KA-0002HT-PB; Tue, 17 May 2022 19:57:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zwBFhSb+v2dk9TwCBfXvm4/pm87W97HXJvH0PaMcmTY=; b=zvgMqxQ0R61bTL1UAEIi/7uqMz 8Tl18mAABlSrgXqRfvGQ6adjxU8fnIbqYKAksL79Sm3S1ZPhs4q4JR1UAh2YDzsMEp+P6QHnaI4ed cZDtst9o+aQ0QH9+FWK+sKHolb0D/NAoDumVzlELcjmydQXWyQWGjTHdznvyIKnbViMQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170516: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 19:57:42 +0000 flight 170516 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1069 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 88 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 20:31:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 20:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331495.555014 (Exim 4.92) (envelope-from ) id 1nr3qT-0000RB-OH; Tue, 17 May 2022 20:31:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331495.555014; Tue, 17 May 2022 20:31:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3qT-0000R4-KL; Tue, 17 May 2022 20:31:05 +0000 Received: by outflank-mailman (input) for mailman id 331495; Tue, 17 May 2022 20:31:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3qR-0000Qu-MY; Tue, 17 May 2022 20:31:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3qR-0004Tt-KB; Tue, 17 May 2022 20:31:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr3qR-00047R-56; Tue, 17 May 2022 20:31:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr3qR-0001B1-4d; Tue, 17 May 2022 20:31:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rGrz1uzacjbL271B0ywLuosBXpPDjD2b0w2PSJ20ttw=; b=ojeY0whBnkJQMrXh9NxRq2YeVi ixSvRcxAXfN1CHcFNMgEKI1lYnWiks8KdSBIbSQeI0JH6EF8SiNSGo5X8cL1fP0KNz1v4oedYstaY jmmP1lMwSlYn4z3WhTMFRRspXXVfJhTbXGolD6fVG0R3UN8FXeibsFgX8qSllJFftD3M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170517: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 20:31:03 +0000 flight 170517 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170517/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1070 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 89 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 21:01:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 21:01:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331505.555025 (Exim 4.92) (envelope-from ) id 1nr4JV-0003tL-6Q; Tue, 17 May 2022 21:01:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331505.555025; Tue, 17 May 2022 21:01:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4JV-0003tE-1E; Tue, 17 May 2022 21:01:05 +0000 Received: by outflank-mailman (input) for mailman id 331505; Tue, 17 May 2022 21:01:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4JU-0003t4-Gc; Tue, 17 May 2022 21:01:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4JU-0004z7-BE; Tue, 17 May 2022 21:01:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4JT-0004li-QK; Tue, 17 May 2022 21:01:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr4JT-00009i-Ps; Tue, 17 May 2022 21:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9DxGvYgwaeJAxAABkGJXVuc5Wo+Q37ZSuAf340omf1s=; b=fd9uSG9Qomuj3aMd9Z6dXI3wPr YvO+So/nC+9reKECSQciTdroyAoteTdsIlZDHTth/ic5bC9bIOMf/5+ZHQUvJzr4g6LWhXowGdoKd qQYBR+csQgN4b/Ayq9EIiB2pq7gzlXxM9DbTVNnGcGcS6S+qhUKsJUvWzgP0STuzuq00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170518: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 21:01:03 +0000 flight 170518 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170518/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1071 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 90 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 21:41:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 21:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331516.555035 (Exim 4.92) (envelope-from ) id 1nr4wi-0008JL-Hs; Tue, 17 May 2022 21:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331516.555035; Tue, 17 May 2022 21:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4wi-0008JE-EH; Tue, 17 May 2022 21:41:36 +0000 Received: by outflank-mailman (input) for mailman id 331516; Tue, 17 May 2022 21:41:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4wh-0008J4-Fw; Tue, 17 May 2022 21:41:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4wh-0005bv-Da; Tue, 17 May 2022 21:41:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr4wh-0005gg-35; Tue, 17 May 2022 21:41:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr4wh-000111-2c; Tue, 17 May 2022 21:41:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pkhVpcEzH7q6Xr+IUHDewfaA2Fkv48hQpBRTnu+Y+jE=; b=EJfSD8Grpfpw0EQwaV0CaJKkRL XFPl20kINQCHGlWTQNRT7wrcTi8ZE4/UhF6H5YaNWoxYGXfotSy5i0cB3baPWkOY2BGrK29B2BNSE dNuEY3UyW1iR7pIl2ypv+URH1kG/gwRc1mb5vU+qyeK7tbskzCKRMTUedZDM6KwXtSlc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170514: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=69589c374a92d1b4f97db24623e5f760990eaf82 X-Osstest-Versions-That: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc From: osstest service owner Date: Tue, 17 May 2022 21:41:35 +0000 flight 170514 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170514/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 69589c374a92d1b4f97db24623e5f760990eaf82 baseline version: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc Last test of basis 170486 2022-05-16 18:01:38 Z 1 days Testing same since 170514 2022-05-17 18:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git aa1cba100b..69589c374a 69589c374a92d1b4f97db24623e5f760990eaf82 -> smoke From xen-devel-bounces@lists.xenproject.org Tue May 17 22:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 22:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331526.555047 (Exim 4.92) (envelope-from ) id 1nr5Eg-0002Mw-4a; Tue, 17 May 2022 22:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331526.555047; Tue, 17 May 2022 22:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr5Eg-0002Mp-0k; Tue, 17 May 2022 22:00:10 +0000 Received: by outflank-mailman (input) for mailman id 331526; Tue, 17 May 2022 22:00:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr5Ef-0002Mf-3B; Tue, 17 May 2022 22:00:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr5Ef-0005vA-0N; Tue, 17 May 2022 22:00:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr5Ee-00065k-Kg; Tue, 17 May 2022 22:00:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr5Ee-0005vj-KC; Tue, 17 May 2022 22:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+UqWbzcGK5O9kpv05Z1Sbhh7Jv04nHyq/c8s78ZQXAY=; b=ZK7dTDuI9wmJPqh2HCZpr6+8MB MKjPq/gnFkpWxLZy4hGPgT3L3ZFsi5PKCA7DhJ84H8IHSEKSqyFKvRGvy9EOmcyMvXN/BupcZlEFo JRrDnQz70i7TydMnjy/8FTXs+lhzDn1JXcIKM9eNdR08OTursj5WgiV/+Fc3Bfy/GJ7U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170519: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 22:00:08 +0000 flight 170519 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1072 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 91 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 17 23:33:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 17 May 2022 23:33:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331536.555057 (Exim 4.92) (envelope-from ) id 1nr6h0-00039I-5H; Tue, 17 May 2022 23:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331536.555057; Tue, 17 May 2022 23:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr6h0-00039B-2F; Tue, 17 May 2022 23:33:30 +0000 Received: by outflank-mailman (input) for mailman id 331536; Tue, 17 May 2022 23:33:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr6gy-000391-FP; Tue, 17 May 2022 23:33:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr6gy-0007QL-Cy; Tue, 17 May 2022 23:33:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr6gy-0001UY-2D; Tue, 17 May 2022 23:33:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr6gy-00084m-1d; Tue, 17 May 2022 23:33:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dtNqrO3q6kG/vBoDA01D4aywW2VxTHpFL8kM//PQ8a4=; b=eNmxQQHxITbLSMDXbZP+fYfy+g qGNEi4mMqhlM9bLffhpS3K8b1ah6CRKe54BAmKMEFCVYoLkTVvasoksVkH9VXYC3mgXoxKSFEDbmU HcIBCFqzjk+ZKpWpUiuimX9mPfQiUWN2ef+aK0/nT2hBpi1I864wqpG0M4sCiZkSZKxY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170521: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Tue, 17 May 2022 23:33:28 +0000 flight 170521 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170521/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1073 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 92 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 00:51:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 00:51:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331546.555069 (Exim 4.92) (envelope-from ) id 1nr7uJ-0003Pm-Si; Wed, 18 May 2022 00:51:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331546.555069; Wed, 18 May 2022 00:51:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr7uJ-0003Pf-Ox; Wed, 18 May 2022 00:51:19 +0000 Received: by outflank-mailman (input) for mailman id 331546; Wed, 18 May 2022 00:51:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr7uH-0003PV-K5; Wed, 18 May 2022 00:51:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr7uH-0000uI-EK; Wed, 18 May 2022 00:51:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr7uH-0004ft-27; Wed, 18 May 2022 00:51:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr7uH-0006KL-1k; Wed, 18 May 2022 00:51:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XPDAc6v1/bIHfWdbCG3kAMq39xJFvUJERruYsxvwfEk=; b=q6qUxlDzPZj4FJG016aa3kwaEx SG6HTI07d29Z3ey8vtwNcZEOTzgpwJgrDa0ZeQVkFaVAkmzQ3qzL4ctQ3URiR68T4bc0TYS0ftgwg ir9jIqs2We1DwcpiIXLUjO6L+uVjL3OhW39QX0rmEwSyVR8R+ytXUOKC55qwgLrUZhaY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170522: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 00:51:17 +0000 flight 170522 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170522/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 77 days 1074 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 93 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 02:29:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 02:29:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331557.555080 (Exim 4.92) (envelope-from ) id 1nr9RW-00032S-8L; Wed, 18 May 2022 02:29:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331557.555080; Wed, 18 May 2022 02:29:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9RW-00032L-4D; Wed, 18 May 2022 02:29:42 +0000 Received: by outflank-mailman (input) for mailman id 331557; Wed, 18 May 2022 02:29:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9RU-00032F-TT for xen-devel@lists.xenproject.org; Wed, 18 May 2022 02:29:41 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0601.outbound.protection.outlook.com [2a01:111:f400:fe08::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ce16f55-d652-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 04:29:38 +0200 (CEST) Received: from DB6PR07CA0191.eurprd07.prod.outlook.com (2603:10a6:6:42::21) by AS8PR08MB7234.eurprd08.prod.outlook.com (2603:10a6:20b:341::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 18 May 2022 02:29:35 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::2d) by DB6PR07CA0191.outlook.office365.com (2603:10a6:6:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.5 via Frontend Transport; Wed, 18 May 2022 02:29:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 02:29:35 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 18 May 2022 02:29:35 +0000 Received: from 3c222ef6331b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 522640E2-A226-40D7-9C69-0BA3D63376D7.1; Wed, 18 May 2022 02:29:28 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3c222ef6331b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 02:29:28 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM9PR08MB6306.eurprd08.prod.outlook.com (2603:10a6:20b:2d6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 02:29:25 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5250.018; Wed, 18 May 2022 02:29:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ce16f55-d652-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AKbZCYTN5Yz3nTzwuQ4j4DpgVpPUPVe8Tg5WX5dipIJ1jzW/zdSFY2GWOZ5krTFNTI+/sPPDMG61Ov8fJ/S4iR0YUf+txqsBbIn3b/XTH/1PVW5LpzgNpTkzi/5gbBnCDRnq+5TuMa6fJgo3rwI9L8R+3LD23TGIPSDstACy5uwhDI43P7ZqczFfecH3oo65ZlJ5bnOE/P4wLt25/+2wRBDVX8Mst1RlkCpQlkzE7IE6UTOB09K6Ept/UBXwBgweOqwpt/2i+S+OIQLnWFEC0eNqYmm8wQpPmsHIc1pMYdgUTZVBuPDV9/DUjhuu2aE66NaN4MFyjFHtUomy6Kj5ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0cLZcfcsapKxpJ/nIooyjnkFCSdNKz2n/GKOE6cMTEU=; b=BFdOtFJzZHpr987p97o6vcdDShMcSJRPXF8d3a2IyPGCKf2/HGHzTSfGNGCb8st5qDb0bZ7Lj/ZCtlIMA6rAKHiFQbfotIFmfD5+Bb2NxO5J52M3UyOeTZAJShqz2ciX8avtvS2igFKROv/zK90aTvHZYFM0KUvwORcblh0eoeTq3ayyDy0dfNdAD7sHkU8pxvYSLL4QOFRHPLBzN9A/Eke15fZvBJsjAF+Fv+LjOTgYiKlYd60831ixICTEYjf6oDVYCuvIoUeEBEhn6HwryLLgI8ZZWZowv805eyqQygMSoz2RBhXktqhkt5Eb1JtsUPkUO3G9b1ULmIs8AIsj+g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0cLZcfcsapKxpJ/nIooyjnkFCSdNKz2n/GKOE6cMTEU=; b=B6ox1DGlfJdEFp0D687y5Wl1g/lWWFuQVeo7MJcvP6p8mkHfCcYo4T9ciTMctWwB/HVQJvMsn56fSX/l6+HZRvSXA+wgZSqoYx+h8NEfCvLyPuRX6A6c9XkynnbkblFm46ZI+JCkAhMLp4ghZGpMoY3LCtbCB3cq/OSRqPTDGOI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ng9lLEs2aysmTnixiV5xp/lB6owdcrleYb08APvFkPV/Li+ygy8xQ6yb2JAJYZQrjVkyu9GqTUGmkELuKgrrRD+uU6VXc36I/+acodzt2F6dNYSbMyDOVmXe+AMn5eFtamVMQfAGzK1YXqI9XDZ66q+xF64NDXWwZpnsEk1IPrQ7AeRZwSKgKOxqRYwDpjhgDVYgB/t8MS9B1CjBxvoF6yrkx0cdze8eP/1RRxtk0jmBh8e0t5nIaSSi4ndbq9bKc0ZVpjfBH536ChhUMValpENLkbQp0bwtPPMDPPoKQeygeSzcBJMq65l0X6KhW+JXy5YggiZAiCYF2w597cD43A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0cLZcfcsapKxpJ/nIooyjnkFCSdNKz2n/GKOE6cMTEU=; b=bl1EtYMxD+DmBuY6vKGjK3NKUHh6bmD3M1VqbC9kuTlhoeMv+U9GROkiKcArJofAXvuwWU4ymTtcSvQtZIVR/Q1BVol5V9P56rJ5GvcHWea3xN6Bl99jbYIz4mDolKihJJPJ4RttH2PXf/bCzPYIpcRpE07uYNZdGFSwVoo8mRhFnSELZdd+BlS5En7zPZ9aPLm+pCzTOmOf914hS8K5jBM5LGFKwh+kz6xnUfuooX/y6NtRfcm9IZK3FSeMRz57jQ2tTXlDlemjC3GcQlRDvzsTL+/zyqBbItUbTWTDGLwpGR7+q8sWoYaam/+3VcP3eJji1/K8eJMbC9tADBRibA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0cLZcfcsapKxpJ/nIooyjnkFCSdNKz2n/GKOE6cMTEU=; b=B6ox1DGlfJdEFp0D687y5Wl1g/lWWFuQVeo7MJcvP6p8mkHfCcYo4T9ciTMctWwB/HVQJvMsn56fSX/l6+HZRvSXA+wgZSqoYx+h8NEfCvLyPuRX6A6c9XkynnbkblFm46ZI+JCkAhMLp4ghZGpMoY3LCtbCB3cq/OSRqPTDGOI= From: Penny Zheng To: Jan Beulich , "julien@xen.org" CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Topic: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Index: AQHYZBWe/uxRZBdW10mDRgQaF95/K60jSVqAgACnZgA= Date: Wed, 18 May 2022 02:29:24 +0000 Message-ID: References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <20dd9308-3cdc-4ebb-61b2-e0a71e808697@suse.com> In-Reply-To: <20dd9308-3cdc-4ebb-61b2-e0a71e808697@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D69583AF583F6D4185C5DFC81323147C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a61dc321-88a6-49cc-d67f-08da38763f9b x-ms-traffictypediagnostic: AM9PR08MB6306:EE_|DBAEUR03FT024:EE_|AS8PR08MB7234:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jndSgcoj3CSQ1nJi6kdWrv5GyvYHEyYDX2RmKfbjxKMmi1m0+1sR3fngk07NuRyvW/YGCcjXSKCaNQb89bM1qzIdslk46O67TPX+NjiyQqjfW3kDOCHWLedfnnO5n5qJWlfoMEXmC1ggSzfnpxQlpYYWm3vBqaH6eoPtDdBcrQRtQpEFEWLcNCEBG5MCMTlnjKZe7S43tc524FTsqzV8523Aeem4d0Cx40FnwvJVtYSYR+sRNkYwJ/JhRULutFgL7Rk+NRdaUJMTnZms3di7gEe/TmtnSHxzJgrW10hyLGExJ3cCYsnr3sIk9FcysWIs+EtM4h07i6xjKylTK7wG2yx5iwVLRtQjEARxFawrbKdW+B65M+b8TU81HyaMt7ZOgPwbh37Aqjq6IDmgaFJXnUXCHaBppm5j8zVYcl7uCbo1xN/F4FyTMlGnxbcvM61dLoJg0YPZfrTKd1uVeOq4dzKXPYTzJqrqF8SFOS0n1GMu2dbx9S1YgoG++IeQhmiQzm56Jiu3wmSZTb3vQ4IxiybR07a9cCNmmBEgZE/1Ynfdjx+F7hr3SfFLeBKRez76emDzUjVoPDpHI6Mirovh1aWnvqmHYEmh5k2cO8cTq7j/cWduypR5/oJ3B+pvfOXWr1m0Sr+VT7vfpduBudeP4LTMIaahuez5FkIo4ivmzXILh1PQnY24phvAlIjVQVm8j+78cZ5Xc6j1P4Rznevr8A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(38070700005)(76116006)(66946007)(83380400001)(66476007)(4326008)(9686003)(66446008)(64756008)(66556008)(6506007)(8676002)(7696005)(71200400001)(316002)(26005)(122000001)(110136005)(38100700002)(55016003)(54906003)(8936002)(2906002)(33656002)(52536014)(508600001)(5660300002)(186003)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6306 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2452dd0b-180c-4179-8f4a-08da38763998 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23iQIzvig7gFbsQ8m9r7/+hNYonHzZ5I1LgpQi/YcwBygAuVQWfQEmuuk7VDLr6hC8XTjwZWD1BFswh2Z0qhp+5a/hXQ47H6KE1z/TXUNhh5jLpxDUjoogRfzqHdzocDf9deoD5a+xqDAjwykYyaPWIrpmxrgGu/kIN6T4r0UPlCZvFcyRrgn/+xAn/jyUv3o8aA2vD2RebxXHI7w+iEEiT7RKLNUyR0zYDGeHGfNpXuVHill3uH61r5t0rU7RHdI6TupHWfdQa3F5Y+1utG5EhEC+IwbT9ekFaXPm7iIkZ02bfksTyDXKX3lgtTgMwT+FJPRPd++hormr8uL8skqda5m3FoeB3bgWl+lymE66ZCL3fJnnyrPF7KaoZN/+i9Y6tVs48DjTSAb72HHmGg26NR5DT5BnWfqclujufSBhFUfeT4UKCRf8P6JPcsgI9S8/xfy9N6FGeqdhNXGTcguij7EDkUXDAs8Pj2sDViyMHcfdAhLrvOd0WINaIf3Em2Tts1TmAKSq4LwZprjLWTmLosFASZ9mcTbqwJ6ue3EHK6Cs2rENrQbMelHGPmFxLqyqaDjgX8K7/EW99RxfrsN30Q7JRzTwcGwJ51D2Tv61+uHXSWmKW9obTi6KodEVT7PKOXnCLxnIhTSJu/cpFxw5WwfvsUZT5jYPoAASTFN3o1pxnm763/VBJXNbNsLaMa X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(53546011)(82310400005)(36860700001)(26005)(356005)(83380400001)(33656002)(9686003)(70586007)(70206006)(52536014)(508600001)(81166007)(54906003)(86362001)(6506007)(110136005)(2906002)(47076005)(316002)(5660300002)(7696005)(186003)(336012)(40460700003)(4326008)(55016003)(8676002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 02:29:35.0820 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a61dc321-88a6-49cc-d67f-08da38763f9b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7234 SGkgSmFuIGFuZCBKdWxpZW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFdlZG5lc2RheSwgTWF5 IDE4LCAyMDIyIDEyOjExIEFNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNv bT4NCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBA Y2l0cml4LmNvbT47DQo+IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vIFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3Jn PjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djQgMS82XSB4ZW46IGRvIG5vdCBmcmVlIHJlc2VydmVkIG1lbW9yeSBpbnRvIGhlYXANCj4gDQo+ IE9uIDEwLjA1LjIwMjIgMDQ6MjcsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEBAIC0yNzYyLDYg KzI3NjcsMTIgQEAgaW50IF9faW5pdCBhY3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QNCj4g PiBkb21haW4gKmQsIG1mbl90IHNtZm4sDQo+ID4NCj4gPiAgICAgIHJldHVybiAwOw0KPiA+ICB9 DQo+ID4gKyNlbHNlDQo+ID4gK3ZvaWQgZnJlZV9zdGF0aWNtZW1fcGFnZXMoc3RydWN0IHBhZ2Vf aW5mbyAqcGcsIHVuc2lnbmVkIGxvbmcgbnJfbWZucywNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICBib29sIG5lZWRfc2NydWIpIHsNCj4gPiArICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgp Ow0KPiA+ICt9DQo+ID4gICNlbmRpZg0KPiANCj4gQXMgYmVmb3JlIEkgZG8gbm90IGFncmVlIHRo YXQgd2UgbmVlZCB0aGlzIChvciBzaW1pbGFyKSBzdHViIGZ1bmN0aW9ucy4gQXMNCj4gYWxyZWFk eSBzdWdnZXN0ZWQgSSB0aGluayB0aGF0IGluc3RlYWQgQXJtIHdhbnRzIHRvICNkZWZpbmUgUEdD X3Jlc2VydmVkICh0bw0KPiBub24temVybykgb25seSB3aGVuICFDT05GSUdfU1RBVElDX01FTU9S WSwganVzdCBsaWtlIGlzIGFscmVhZHkgdGhlIGNhc2UNCj4gb24geDg2Lg0KPiANCg0KT2ssIGlm IHlvdSBkbyBub3QgbGlrZSB0aGUgc3R1YiBmdW5jdGlvbiwgdGhlbiB3aGF0IGFib3V0IEkgcHV0 dGluZyB0aGUgI2lmZGVmLWFycmF5IGJhY2sNCnRvIHRoZSBjb21tb24gd2hlcmUgZnJlZV9zdGF0 aWNtZW1fcGFnZXMgaXMgdXNlZDoNCiNpZmRlZiBDT05GSUdfU1RBVElDX01FTU9SWQ0KCWlmICgg cGctPmNvdW50X2luZm8gJiBQR0NfcmVzZXJ2ZWQgKQ0KCSAgICAvKiBSZXNlcnZlZCBwYWdlIHNo YWxsIG5vdCBnbyBiYWNrIHRvIHRoZSBoZWFwLiAqLw0KCSAgICByZXR1cm4gZnJlZV9zdGF0aWNt ZW1fcGFnZXMocGcsIDFVTCA8PCBvcmRlciwgbmVlZF9zY3J1Yik7DQojZW5kaWYNCklmIHRoaXMg aXMgbm90IHRoZSBvcHRpb24gaGVyZSB0b28sIGJlZm9yZSBJIG1ha2UgdGhlIGNoYW5nZSBhYm91 dCBndWFyZGluZyB0aGUNClBHQ19yZXNlcnZlZCB3aXRoIENPTkZJR19TVEFUSUNfTUVNT1JZIG9u IEFSTSwgSSdkIGxpa2UgdG8gY2MgSnVsaWVuIGhlcmUsDQpTaW5jZSBpbiB0aGUgdmVyeSBiZWdp bm5pbmcgd2hlbiB3ZSBpbnRyb2R1Y2VkIFBHQ19yZXNlcnZlZCBmbGFnLCBoZSBtaWdodCBoYXZl DQpjb25jZXJucyBhYm91dCBsaW1pdGluZyB0aGUgdXNhZ2Ugb2YgUEdDX3Jlc2VydmVkIHRvIHN0 YXRpYyBtZW1vcnksIGlmIGhlIGlzDQpva2F5IG5vdywgSSdtIGZpbmUgdG9vLiA7KQ0KDQo+IEph bg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 02:49:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 02:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331565.555091 (Exim 4.92) (envelope-from ) id 1nr9kz-0005V9-UB; Wed, 18 May 2022 02:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331565.555091; Wed, 18 May 2022 02:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9kz-0005V2-Qz; Wed, 18 May 2022 02:49:49 +0000 Received: by outflank-mailman (input) for mailman id 331565; Wed, 18 May 2022 02:49:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9ky-0005Us-Sz; Wed, 18 May 2022 02:49:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9ky-0001CU-QY; Wed, 18 May 2022 02:49:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr9ky-0004Mr-CG; Wed, 18 May 2022 02:49:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nr9ky-0006ck-Bq; Wed, 18 May 2022 02:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tKWZcS4rMRrI753tOwkstpbnPXwttbNKoYEj0wsTwmY=; b=Nj+CzM2nskiCuV/IHNtfAxerwz tje/l+SzJYdG+v9tlVvBK5oDfe3b2Jl3gRYmkOPMcOUN5ZDkS/wtZ2+/XdGIqNMT7Gw7Lf+y1h7PR dF2NbwBBCWh8EDmEuKCWXoiw1rLRsH6xIxxQfm8SJEjPygHhUXmdbOz4TuluZPffvwjQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170524: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 02:49:48 +0000 flight 170524 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170524/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1075 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 94 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 03:12:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 03:12:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331575.555102 (Exim 4.92) (envelope-from ) id 1nrA6p-0000Qk-PW; Wed, 18 May 2022 03:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331575.555102; Wed, 18 May 2022 03:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrA6p-0000Qd-Md; Wed, 18 May 2022 03:12:23 +0000 Received: by outflank-mailman (input) for mailman id 331575; Wed, 18 May 2022 03:12:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrA6o-0000QX-Jr for xen-devel@lists.xenproject.org; Wed, 18 May 2022 03:12:22 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54b22b7a-d658-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 05:12:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DDE86B81E5E; Wed, 18 May 2022 03:12:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F85DC385B8; Wed, 18 May 2022 03:12:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54b22b7a-d658-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652843538; bh=/bXNAQ83vbS03juk3paZ340au3reFClkFeg3WeBW+yI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kh5yAZngV1xwN2uye96+w02/IDBjmLwOSpXivNoafstjWeNShfXVZockJlBMrAZm1 ybcIO0SyiGa8yt4OsYED7imcAAqUaV5dBLETEvGQdb2lHXVwbIr5d8WXzB3lGPF6sH adTDf5e7TCO1rEUFtPmS0WtVlON5PS9mLWugM5Go+aeN8S42HCUeCIWWkTJeBTpL0n FQLL6UXtZ95og/0hmxLj6fH7JeGqd0eQDfsmhIcGRry9q1AwOnuSmfQfe5IJpmu4pl U/iVmv9yCGkCSwBxr6UypGex6vfsUrkMwaCvPlt4zZc2dWA8g1n9DyiE31F1l8xPze rk0v1EA9rXvAw== Date: Tue, 17 May 2022 20:12:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: George Dunlap , xen-devel , Juergen Gross , Roger Pau Monne , Andrew Cooper , Bertrand Marquis , Julien Grall , Stefano Stabellini Subject: Re: Process for cherry-picking patches from other projects In-Reply-To: <5e4d505c-a02c-eb54-8299-b1078943a8a5@suse.com> Message-ID: References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <5e4d505c-a02c-eb54-8299-b1078943a8a5@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 17 May 2022, Jan Beulich wrote: > Hmm. The present rules written down in docs/process/sending-patches.pandoc > are a result of me having been accused of unduly stripping S-o-b (and maybe > a few other) tags. If that was for a real reason (and not just because of > someone's taste), how could it ever be okay to remove S-o-b? (Personally I > agree with what you propose, it just doesn't line up with that discussion > we had not all that long ago.) This is the meaning of the DCO: https://developercertificate.org The relevant case is: (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or IANAL but I read this as to mean that only the submitter Signed-off-by is required. Also consider that the code could come from a place where Signed-off-by is not used. As long as the copyright checks out, then we are OK. From xen-devel-bounces@lists.xenproject.org Wed May 18 03:15:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 03:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331583.555113 (Exim 4.92) (envelope-from ) id 1nrA9Y-00013Z-7D; Wed, 18 May 2022 03:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331583.555113; Wed, 18 May 2022 03:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrA9Y-00013S-3z; Wed, 18 May 2022 03:15:12 +0000 Received: by outflank-mailman (input) for mailman id 331583; Wed, 18 May 2022 03:15:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrA9W-00013K-0n for xen-devel@lists.xenproject.org; Wed, 18 May 2022 03:15:10 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0617.outbound.protection.outlook.com [2a01:111:f400:fe09::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b828e8c0-d658-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 05:15:08 +0200 (CEST) Received: from AS9PR06CA0340.eurprd06.prod.outlook.com (2603:10a6:20b:466::35) by AM6PR08MB4390.eurprd08.prod.outlook.com (2603:10a6:20b:be::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 03:14:49 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::8f) by AS9PR06CA0340.outlook.office365.com (2603:10a6:20b:466::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Wed, 18 May 2022 03:14:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Wed, 18 May 2022 03:14:48 +0000 Received: ("Tessian outbound 42cead292588:v119"); Wed, 18 May 2022 03:14:48 +0000 Received: from abf7c8cd6b19.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6EC7DBD-4C43-4BF4-B562-ADC66058223C.1; Wed, 18 May 2022 03:14:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id abf7c8cd6b19.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 03:14:41 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM0PR08MB4499.eurprd08.prod.outlook.com (2603:10a6:208:140::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Wed, 18 May 2022 03:14:40 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5250.018; Wed, 18 May 2022 03:14:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b828e8c0-d658-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gG1xP9Jot7bB0NesIBCHiebkYf7fOn5vD21XZzf4d0JPzjLvDKDlbhrRqjWiJT6UgEoJH+dN6OvYTiEc+pGMxkOFW4Ls05eg3FULe92iaOTSKPvGzHP1Z7LBrSGbVmhvN1YCd6vT5BrKxbuS/4wnFgCSp1KsHOkmTMm2cK4jbjnRHWS61vmfuM7zYU40MAx7DwRDwqMN1jta73IbpsrK0o6PVafFVkDuU6yPHTkUn5cHNiDs5IN8ihhtsRhEg02QTi71u/RlmUifd47SgtfVI1VdW1zyFjkv2s3nToYhsD2v6/k/aI1VOS7afNSwDkk0AT33HtZPoyWOSaIeBTW9Qw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=GCDl5vFTUDb+qfozLbFnjStvW6imMMjBr8niNdrFlTJKvt+We1/VriDnmdf2o5N7glvmQlKIGNppwE+R3HTcTmXOp+P5BCKtmHcYVdX8MCoXYR5e8thaI4mtHvQglRpdMImkXjWBjTVB0+/OfGmHjiCta613xI68G1DTtPgABTGcNU3zBWujjmZVifrveZrVn2M6yWz+yj5zD0bY2srvjvVUy/krrvezRvW/tQmZq11QReCfEAB238SUDRWCSnyUepgCPp/WH6B8yzwEBH2D1Kdz5hgd7sab0vLY1hN4kS4py4y6kKDqMeqjPJO/xL7GQ+PkPOKEQNV4ZdKLC5vd1w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=cZ7V69ATWOQd5/QxGjNlp+SWnIMkyXokHHnuqoTUNo/krDQeweg+Jg3O89kEESSZU9W5buhv3/oSVtO/RobYcLT5WfhONzLhxF+RkqkKLVcOVrwbtOcP7oMXHvT5bE35Nj9DhOG9/dJtR/qserTWJ34mo9yXEoQcqtA4+aTUAA4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldeBN9w7MHV3xS4PXwD01jfnWJChXBGhfhr97wEedTa5S+pm8fBn0J+bQ8AReyU6DVc7i1AnSjbqeOllM9CZWwV76reHNjkjWJMBWn1hP8rRwOV9meL7VolCtrBHszjJrtPbQuBaF0O3QWUljkL4bW8E2X7aRn1+mRIUTrlGk2E0DH49t4cS6S7uaIOIA/xJAuZzwKAvRZihomdrUVMQav10fp9V3cxyJ0j6aoxSaesCdR3HcHVPvn0SHzWTKbynBgsFF0D3VMRJNgnJPvZfQzbfs/jX+tHpqcYqIwKmdR/KoTG/U7qPVfMXmlA16ueIZMivnvmGBKpChNZCfJDYiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=Y5jyPCkTObr/sve/TFt81ibuykeH7J7y50PbXlQ5u8RrRTawOzdOkJu0HNcF72NazZ+38O4vL2snqsaGXnr2cjdobp0l2k4JzwjBsbJDjUozD03LS49c9hMaYqQL7/7yUhGK+Hchi04MFDC0PO7vxK9izbc45ww6eZx7WX1AZ422AtNCoEBZzoAJFyQICQwZL0OpNI2K7R2pxJoFQDUSCwB9pstZr3SJFujfo45VIGuJJ+aRUpkQ/lPjmEBUnm9RHJb2kkIcYp7YnjKP3p59x0lFrCfcf4Yi9T1wG2DPzGEkBDMLOrB6sekGrHKAIKt1FC8wr8bwgZlvwvGC0kZWIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=cZ7V69ATWOQd5/QxGjNlp+SWnIMkyXokHHnuqoTUNo/krDQeweg+Jg3O89kEESSZU9W5buhv3/oSVtO/RobYcLT5WfhONzLhxF+RkqkKLVcOVrwbtOcP7oMXHvT5bE35Nj9DhOG9/dJtR/qserTWJ34mo9yXEoQcqtA4+aTUAA4= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io Thread-Topic: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io Thread-Index: AQHYac1fSwyDVJqZLUSNuimuDmM9e60jOyEAgACwTiA= Date: Wed, 18 May 2022 03:14:40 +0000 Message-ID: References: <20220517090529.3140417-1-Penny.Zheng@arm.com> <20220517090529.3140417-3-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B8A2DC5DB9E28A4DAFCE65AF32C1AA77.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c1aab616-3836-48a9-345d-08da387c90fc x-ms-traffictypediagnostic: AM0PR08MB4499:EE_|AM5EUR03FT064:EE_|AM6PR08MB4390:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: abLBaiwsp2irU4F9TlDBj+ijGCl+L5RIvi1qLqzdjvUv3VfzAhUsuAbCJSUPBKA/nSM2Mh1R574YZPpZjuFfFQ4q2geB2p+00LfBEgMxhycjLnuOGSEOIxq+kTQxLamGulaA2jBXNOHxP2T7tqAll6v5aS1YQgrBJ8fOwd2rF2DiuAeB9OIf9lxkZEX5FN5HZjY9/tGsjxh2VcF3O9XswDbPzBiWsHcwg8fzgWIVb0DuMjrGA62c/X/7irUoPsDm/pr87xrLpzqqpT3p0DIzoybUkElV+A5AIa55hFqLP8WUj45Sp0cZRfBYlKSmTMh8N0Jjj++8NYf6M7EwOo8IwecSA/cv1NZaDNXvL+ofvnER3GeLt7G0CSvVL6m7kdNJwNUiK/sVKvYyrBoCEOPSbNFjQbo4yEeKZFkgzBdvKnM0YWV8ngRagoDwV21SJSce9xDHbTlxKMojrLdlDtW94CLBfUwSEfwa05VYksZfQ6EE2Dx0HJ9g8FCm3/IIjxwcE7/QKaNm11E5cymHfitoKtAZJK/4oGtaI0ac8htwmVGPXytmR5bAqsi46K7gMSIFNuXaeEi9nXGFTGPkKl5SIDQ3Ug6+4c0pZnhVPESNdl7jV1IOsscdghzexIRhxRxlzFxtXyuu9dUaeIs6Ev1BQXGAy16DvLdIHANVw0tyrLTed7vD+4v0Wm8fQ0CxqU6qzTYlyeZugyifD0lXzhZ/lDnPApIK33MyIsTudJkxwMc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(122000001)(2906002)(54906003)(38100700002)(38070700005)(6916009)(7696005)(5660300002)(186003)(8936002)(52536014)(33656002)(508600001)(55016003)(83380400001)(71200400001)(9686003)(6506007)(53546011)(66446008)(4326008)(66946007)(66556008)(66476007)(8676002)(26005)(64756008)(86362001)(76116006)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4499 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ca97d7bb-53d0-4e11-32ab-08da387c8bf5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qdom2hlm8b2yqil4Ghy2VXjhD1S9FlWW5DvQtvPLsW0O0np9Nk7egxD48ZUpY5Q7gKs2P8eNvh1YrtdXcDARG5hdhS5gmJpMVtBwYTDyfNB+4X1W/GVANDBe4wH1lGs/fLXjJB7vtLwPXfhg2bVkaiuwvsEeB5UkKs+aeymBhp45Uygt1sSJHnwIopL7qwsmVKj/8G9Vo5XzZjVWlSqOTHAuY44Kbwgr/Xaq01DuMu2PlsNWQyMdweqpQV41ebeW0pJXn9UE5ap31GswCgVT+T2XhGJ6xucuWxMdqMCWhp5bRn2sHPDOy65/mgmBaK8PefW8UdFSxmgKXXm1sscUb2kbFhhnfR0W07qgsjpa7AklH9LGdr7WxUWOsD/eiOESKSEcqRLJTfhFCDWTTphirIbmlLCBiM5UuSzznKa4t6Nq/mKcyK4sbJrSi8BLNuLTtTvyKMoMWYfQ1S2KVOeKDGSIE88Mrx3Dz4dEPUrSZmK6z6bKHbeqFWQUlZKs4x6IXj/iPU091U1sGIwT5ir79VQo11NVTsFpzG+xAxLXA9wDOSxtJPE5uSD0+YPUHTcegq+b7RpqeLplli/FMrXrCl2voActFqdCKSZnHvpSnJbcR6lnknWKsQIsLoSicm9ReziyHdEtATlWSc0AQWfWBX5mjsrAYdxrDeqYvBce4qv9m3if3HkkaVsfm7ffdYwslcJCDwQshGZPJzDhHl+B8Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(2906002)(83380400001)(47076005)(336012)(356005)(186003)(9686003)(82310400005)(316002)(36860700001)(33656002)(7696005)(4326008)(40460700003)(70206006)(8676002)(6862004)(52536014)(5660300002)(508600001)(70586007)(8936002)(55016003)(53546011)(6506007)(26005)(54906003)(86362001)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 03:14:48.5269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1aab616-3836-48a9-345d-08da387c90fc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4390 SGkgSmFuIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogV2VkbmVzZGF5LCBNYXkgMTgsIDIwMjIg MTI6MDEgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzog V2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgQmVydHJh bmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNo dWsNCj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5k cmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0 cml4LmNvbT47DQo+IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJv amVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NCAyLzhdIHhlbi9hcm06IGFsbG9jYXRl IHN0YXRpYyBzaGFyZWQgbWVtb3J5IHRvIHRoZQ0KPiBkZWZhdWx0IG93bmVyIGRvbV9pbw0KPiAN Cj4gT24gMTcuMDUuMjAyMiAxMTowNSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gLS0tIGEveGVu L2NvbW1vbi9kb21haW4uYw0KPiA+ICsrKyBiL3hlbi9jb21tb24vZG9tYWluLmMNCj4gPiBAQCAt NzgwLDYgKzc4MCwxMSBAQCB2b2lkIF9faW5pdCBzZXR1cF9zeXN0ZW1fZG9tYWlucyh2b2lkKQ0K PiA+ICAgICAgICogVGhpcyBkb21haW4gb3ducyBJL08gcGFnZXMgdGhhdCBhcmUgd2l0aGluIHRo ZSByYW5nZSBvZiB0aGUgcGFnZV9pbmZvDQo+ID4gICAgICAgKiBhcnJheS4gTWFwcGluZ3Mgb2Nj dXIgYXQgdGhlIHByaXYgb2YgdGhlIGNhbGxlci4NCj4gPiAgICAgICAqIFF1YXJhbnRpbmVkIFBD SSBkZXZpY2VzIHdpbGwgYmUgYXNzb2NpYXRlZCB3aXRoIHRoaXMgZG9tYWluLg0KPiA+ICsgICAg ICoNCj4gPiArICAgICAqIERPTUlEX0lPIGNvdWxkIGFsc28gYmUgdXNlZCBmb3IgbWFwcGluZyBt ZW1vcnkgd2hlbiBubyBleHBsaWNpdA0KPiA+ICsgICAgICogZG9tYWluIGlzIHNwZWNpZmllZC4N Cj4gPiArICAgICAqIEZvciBpbnN0YW5jZSwgRE9NSURfSU8gaXMgdGhlIG93bmVyIG9mIG1lbW9y eSBwcmUtc2hhcmVkIGFtb25nDQo+ID4gKyAgICAgKiBtdWx0aXBsZSBkb21haW5zIGF0IGJvb3Qg dGltZSwgd2hlbiBubyBleHBsaWNpdCBvd25lciBpcyBzcGVjaWZpZWQuDQo+ID4gICAgICAgKi8N Cj4gPiAgICAgIGRvbV9pbyA9IGRvbWFpbl9jcmVhdGUoRE9NSURfSU8sIE5VTEwsIDApOw0KPiA+ ICAgICAgaWYgKCBJU19FUlIoZG9tX2lvKSApDQo+IA0KPiBJJ20gc29ycnk6IFRoZSBjb21tZW50 IGNoYW5nZSBpcyBkZWZpbml0ZWx5IGJldHRlciBub3cgdGhhbiBpdCB3YXMsIGJ1dCBpdCBpcw0K PiBzdGlsbCB3cml0dGVuIGluIGEgd2F5IHJlcXVpcmluZyBmdXJ0aGVyIGtub3dsZWRnZSB0byB1 bmRlcnN0YW5kIHdoYXQgaXQgdGFsa3MNCj4gYWJvdXQuIFdpdGhvdXQgZnVydGhlciBjb250ZXh0 LCAid2hlbiBubyBleHBsaWNpdCBkb21haW4gaXMgc3BlY2lmaWVkIiBvbmx5DQo+IHJhaXNlcyBx dWVzdGlvbnMuIEkgd291bGQgaGF2ZSB0cmllZCB0byBtYWtlIGEgc3VnZ2VzdGlvbiwgYnV0IEkg Y2FuJ3QgcmVhbGx5DQo+IGZpZ3VyZSB3aGF0IGl0IGlzIHRoYXQgeW91IHdhbnQgdG8gZ2V0IGFj cm9zcyBoZXJlLg0KDQpIb3cgYWJvdXQgSSBvbmx5IHJldGFpbiB0aGUgIkZvciBpbnN0YW5jZSwg eHh4IiBhbmQgbWFrZSBpdCBtb3JlIGluIGRldGFpbHMuDQoiDQpET01JRF9JTyBpcyBhbHNvIHRo ZSBkZWZhdWx0IG93bmVyIG9mIG1lbW9yeSBwcmUtc2hhcmVkIGFtb25nIG11bHRpcGxlIGRvbWFp bnMgYXQNCmJvb3QgdGltZSwgd2hlbiBubyBleHBsaWNpdCBvd25lciBpcyBzcGVjaWZpZWQgd2l0 aCAib3duZXIiIHByb3BlcnR5IGluIHN0YXRpYyBzaGFyZWQNCm1lbW9yeSBkZXZpY2Ugbm9kZS4g U2VlIHNlY3Rpb24gZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dDogU3RhdGlj IFNoYXJlZCBNZW1vcnkNCmZvciBtb3JlIGRldGFpbHMuIA0KIg0KDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Wed May 18 04:08:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 04:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331592.555124 (Exim 4.92) (envelope-from ) id 1nrAzB-0006ZJ-Bz; Wed, 18 May 2022 04:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331592.555124; Wed, 18 May 2022 04:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrAzB-0006ZC-9F; Wed, 18 May 2022 04:08:33 +0000 Received: by outflank-mailman (input) for mailman id 331592; Wed, 18 May 2022 04:08:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrAzA-0006Z2-EM; Wed, 18 May 2022 04:08:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrAzA-0002aV-Ap; Wed, 18 May 2022 04:08:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrAzA-0008TR-0J; Wed, 18 May 2022 04:08:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrAz9-0005rF-W0; Wed, 18 May 2022 04:08:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DPAD3jdw0rr6tcPrXL4gVMjnn3WITD61n1xYuInopzk=; b=jHIy+6uI1mtgqNBd98KKtRU8D1 HglpJJkbKPpc+qv6AS6K6webjzwdyv/vZkTw62pJOJCxZNn4laT8razfmwl8Oj8yimiADcwqtidof afUl4R5RpIfudZbxxO/ThxnEN8V+a/663rSIqqu7GbmjQPCTA5s0+7CpajhwYovWeAgs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170525: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 04:08:31 +0000 flight 170525 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170525/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1076 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 95 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 05:06:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 05:06:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331602.555135 (Exim 4.92) (envelope-from ) id 1nrBtP-0005ms-Jo; Wed, 18 May 2022 05:06:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331602.555135; Wed, 18 May 2022 05:06:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrBtP-0005ml-Gu; Wed, 18 May 2022 05:06:39 +0000 Received: by outflank-mailman (input) for mailman id 331602; Wed, 18 May 2022 05:06:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrBtO-0005mb-Na; Wed, 18 May 2022 05:06:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrBtO-0004Hc-JT; Wed, 18 May 2022 05:06:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrBtO-0002IP-7Q; Wed, 18 May 2022 05:06:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrBtO-0005H1-6x; Wed, 18 May 2022 05:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F7hD7porOpXeIk0Mx7LLlcev63oL2Unjr1fPd3KVMIs=; b=HYtlexxqgKnr7rlKH68VcVI3o2 MV+vsTfYtXMh+41vQtsUeunF6vBiPMIpVtX1oL8YuQFKx5/ehfywsNBk1QA9K5m1s88yiELFZaDKe llLDq61+ZDJzX+6NBe5snlbOJiC6IORHWRP0bDaxHJA6yUhAyTd1ECns4oL44o0Xn4Uc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170526: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 05:06:38 +0000 flight 170526 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170526/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1077 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 96 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 05:21:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 05:21:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331284.555146 (Exim 4.92) (envelope-from ) id 1nrC7Y-00089T-T3; Wed, 18 May 2022 05:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331284.555146; Wed, 18 May 2022 05:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrC7Y-00089M-QI; Wed, 18 May 2022 05:21:16 +0000 Received: by outflank-mailman (input) for mailman id 331284; Tue, 17 May 2022 16:42:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nr0HL-0007gm-EH for xen-devel@lists.xenproject.org; Tue, 17 May 2022 16:42:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59855c5e-d600-11ec-bd2c-47488cf2e6aa; Tue, 17 May 2022 18:42:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9390661311; Tue, 17 May 2022 16:42:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A4DAC385B8; Tue, 17 May 2022 16:42:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59855c5e-d600-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652805751; bh=40QgoKo6FsbvUbi5QdZQ8LuhD5fRy9TTvAullSg1NJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IwWIlS2PIiYyBVnn4Mwh5gpkaGvjZ9XXs6xAfg/B47Nwbmbxt1jD4gbBJqWNjqdMQ 9HsczaMvfd1/rGWYbOOfRQQ8ljqODK0+cJuySkUlONzKGxTAf8vwfrIVpXgVVx8uEs 2wEIDbBj2r6oEJ8Bg+f36Z7hiv1BLcfQOKNiXlvcmlPA51l29SkqrSaHJPFlCkSIOv ZO+9XIU4/ifqWs5xRjRbqYPsENsylbITKTx1dz0Y7FgDcqk5osLy4ZTnejsI+dxtEZ bmhi2bch/bLTXyegzpR1TlkIA84eFyb3Od9vzJccH13ypTlfBkZZJB3euhFYap4q4G St6J2fKtLWqSA== Date: Tue, 17 May 2022 09:42:29 -0700 From: Josh Poimboeuf To: Maximilian Heyne Cc: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid Message-ID: <20220517164229.ixz7fqxwrxwmiizn@treble> References: <20220517162425.100567-1-mheyne@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220517162425.100567-1-mheyne@amazon.de> On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote: > Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM > emulate-prefix signature"), objtool is able to correctly parse the > prefixed instruction in xen_cpuid and emit correct orc unwind > information. Hence, marking the function as STACKFRAME_NON_STANDARD is > no longer needed. > > This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark > xen_cpuid() stack frame as non-standard"). > > Signed-off-by: Maximilian Heyne > CC: Josh Poimboeuf > > cr: https://code.amazon.com/reviews/CR-69645080 ^^^^^ This looks like an internal amazon link and should be removed. Otherwise, looks good to me. Acked-by: Josh Poimboeuf -- Josh From xen-devel-bounces@lists.xenproject.org Wed May 18 05:27:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 05:27:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331619.555157 (Exim 4.92) (envelope-from ) id 1nrCDk-0000SC-IV; Wed, 18 May 2022 05:27:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331619.555157; Wed, 18 May 2022 05:27:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCDk-0000S5-Fr; Wed, 18 May 2022 05:27:40 +0000 Received: by outflank-mailman (input) for mailman id 331619; Wed, 18 May 2022 05:27:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCDj-0000Rv-Aq; Wed, 18 May 2022 05:27:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCDj-0004d9-61; Wed, 18 May 2022 05:27:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCDi-0002p3-Sb; Wed, 18 May 2022 05:27:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrCDi-0001eM-S7; Wed, 18 May 2022 05:27:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sICUC5kU7hQjf6N4j52tyE1bwq73D0RhYCpIEQfHNFg=; b=ZeT24pYN8XO/+GoBZfyqSXnxh9 f7g9AEsKa30oqMl5aixvWDE/0YhMHDP/IaEo1QelWMLLQyFEkAD+Jb6BN0OMIqCkD/Kr0J3y+pN86 Xk3td30hTSjEtPBdSTw073OULLRWX6ZbU+iYdoniF6ZyMa4YVlAquOb4L6av+OQIesW0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170520: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=69589c374a92d1b4f97db24623e5f760990eaf82 X-Osstest-Versions-That: xen=aa1cba100bff84b211f27639bd6efeaf7e701bcc From: osstest service owner Date: Wed, 18 May 2022 05:27:38 +0000 flight 170520 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170520/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 170503 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170503 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170503 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170503 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170503 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170503 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170503 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170503 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170503 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170503 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170503 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170503 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170503 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170503 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 69589c374a92d1b4f97db24623e5f760990eaf82 baseline version: xen aa1cba100bff84b211f27639bd6efeaf7e701bcc Last test of basis 170503 2022-05-17 06:45:33 Z 0 days Testing same since 170520 2022-05-17 22:08:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git aa1cba100b..69589c374a 69589c374a92d1b4f97db24623e5f760990eaf82 -> master From xen-devel-bounces@lists.xenproject.org Wed May 18 06:06:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:06:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331631.555171 (Exim 4.92) (envelope-from ) id 1nrCpc-00057c-PB; Wed, 18 May 2022 06:06:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331631.555171; Wed, 18 May 2022 06:06:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCpc-00057V-MU; Wed, 18 May 2022 06:06:48 +0000 Received: by outflank-mailman (input) for mailman id 331631; Wed, 18 May 2022 06:06:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCpb-00057P-Ba for xen-devel@lists.xenproject.org; Wed, 18 May 2022 06:06:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7e1b::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1c43cd2-d670-11ec-837e-e5687231ffcc; Wed, 18 May 2022 08:06:45 +0200 (CEST) Received: from AM5PR0701CA0008.eurprd07.prod.outlook.com (2603:10a6:203:51::18) by AS8PR08MB6405.eurprd08.prod.outlook.com (2603:10a6:20b:332::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 06:06:42 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::b6) by AM5PR0701CA0008.outlook.office365.com (2603:10a6:203:51::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Wed, 18 May 2022 06:06:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 06:06:42 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Wed, 18 May 2022 06:06:42 +0000 Received: from 97b7c91d07c8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E42F4739-0116-4141-9ABC-01EFF7DB4ACC.1; Wed, 18 May 2022 06:06:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97b7c91d07c8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 06:06:31 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM5PR0802MB2515.eurprd08.prod.outlook.com (2603:10a6:203:9f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 06:06:28 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::a4bc:d09e:df69:27a9%3]) with mapi id 15.20.5250.018; Wed, 18 May 2022 06:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1c43cd2-d670-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gbHlm5I0XToWNaE/UuOLOMG8dW8eL7p2siNWiJh/XaZWJj5O706hrt2Dyc06kVU0mntf3J5UWDBK8mrdg+h0F6Pu4PvXjRYwOjaYQJOHcnuYInb4C7dur0nDtZnlR66oBpN2ngwxrZwwJMAoAi4VATDnR8v3EqdgtrISUxPTCz7ejifLHtdgCh/mGVxikZwvCbdBdJ5u13E2dD6NSgcw1PzK+OAuKhXjOO1DJnyKh4TNIcTSr+3JjRFDNLenDXlYIt6WfkIxRH8LAtwTHDk+rMGb32/Bn44/as6vSK4xVD+Rprag4rugvxGUon8Dr0pcyNaP6HOx1kfnsykGvpV2EQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uOwbzjpRJ+EbpJgJypJC8xojlw87UhBhAXL0xI1+Dpg=; b=fs2qMuqm4A6fhTarXCBfLnz0JuWUxSc/HAHDt5mT+7aa5GYku3cV9M2l0ws+7VOKYgfQuTuGPPkW37Y/s52meCSI8VibTSksvrEh6luJSd0UlPk/3YPJGMX8BIKW7GNkSQkPvIf6iBBdNe3wQXdiDO1Uy9QyRJ5aX1aQxpvOdZpxYdoh+o37pP/9dsoH/YL3kmOy+ZxGKRSN9rRbP8e6fIt/fEUTAere+9zdMCDNLzkFWkS0x4vGICzIQgpOsUKXS6m9mOHMDVeTb/EhenrlgZYbdAQVUSSjjo9vYK8JRL8ampMogIfak84ZJ3lazgYDofBhQhaPN0XuwcLZqwu1Uw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOwbzjpRJ+EbpJgJypJC8xojlw87UhBhAXL0xI1+Dpg=; b=QGBCu4vYxckcYPNgVPOjdIYoD0ydVSQel0KhFLcRCOwJjCUQcdqLrzbPyL6LKf32MhedAqebYWCxKzDHH4pKkmslnhkYCaycwDIvcdj659Byz+2olTJazHI8GA6faVMFVV8Q1/c1bKNh3OeCzCWxQZP+JBH5AnoMffsgy++pccE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JbBI9XjxDVEb6OQcY77PuX8mhyr4m53ympX5XPRuZyyr1/3d2yzwqPryWeIj2+ubPYm0bKS+V93WK69GErsGnsUvBVXbzF/KkiRbnfV/q/45BWIsMZrNC0NKwUbNKHxXfnAgAehi9Y/C8fnbkk7/fzsXWLXH2cE5z49wGvwzQAOgbYkmIKfXlvULVjqftnbRt6a5/smQj19JYTqMewqwYXuS+V83J5e4T9j5eSbGyMjPGWDyu1+FxoO1ja92ulR4CkVU/1j+r1/7ukVj5ywMTcOvjl0e3xQJsC6Z+KIMi0q7c/P8H/GHJWCgoFSePg7GXLRNpB7m7Z6BIypLUeeMTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uOwbzjpRJ+EbpJgJypJC8xojlw87UhBhAXL0xI1+Dpg=; b=IhB+mFo3sFG54Tn+rocQT9ekM1s4mSVdgzRTXi2DpKD1s4vgoszC4FUiLMUaMHQWfSvJF5TsiSttTREVyieJrQXl5NWR2qaf7raia36pkUUO4cEkwU9RoMFqHPgNltkd92YIaWAE18mzaq/3w42gCVC/EyiI6ruGVTeEv/lX9XzBCKV1PoHp8HBH8g3z/e+/c0emesJJxtGOK/dqkFvNepC9sAfthckkFnLtARO7S5RIyobD5HBQFDV9KVzzLUwPrY1rdoL+ATZgzu5pYxEkRtjx+noQCqolLKLbyys8Upx3whMuyoaicH/xyAZ5FqL+WhDX+kNtFwx+9YncXbR2cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOwbzjpRJ+EbpJgJypJC8xojlw87UhBhAXL0xI1+Dpg=; b=QGBCu4vYxckcYPNgVPOjdIYoD0ydVSQel0KhFLcRCOwJjCUQcdqLrzbPyL6LKf32MhedAqebYWCxKzDHH4pKkmslnhkYCaycwDIvcdj659Byz+2olTJazHI8GA6faVMFVV8Q1/c1bKNh3OeCzCWxQZP+JBH5AnoMffsgy++pccE= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Topic: [PATCH v4 1/6] xen: do not free reserved memory into heap Thread-Index: AQHYZBWe/uxRZBdW10mDRgQaF95/K60h1bOAgADQseCAADJ5AIABLJMQ Date: Wed, 18 May 2022 06:06:28 +0000 Message-ID: References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <2ebda9bb-8045-56ec-619b-d0178d57ee17@xen.org> <511fd0cb-348f-b65d-cb7b-effd822c7f20@xen.org> In-Reply-To: <511fd0cb-348f-b65d-cb7b-effd822c7f20@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 05ECB4BA4377E446928B14A74170E918.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 990d89fa-2336-4888-eefc-08da38949492 x-ms-traffictypediagnostic: AM5PR0802MB2515:EE_|AM5EUR03FT049:EE_|AS8PR08MB6405:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uAmjOYVrt2VguVbQQ2Fvk4nfI7Ecb+iLyqW9Kw78ZBEZ9d9NBcLHGMQFN93qn4erexNKHuyJGp1cedD767+XysY3xFWaNMvKJudwDAO5+p94ZMKfNXegxJ9Y7IoOvN77QTj4E9RHMdhtNX3SPJ9NxFy2GXL++HKg2Ay6FHRyJSFBIOg4PINRuz6/1jnxkpBOAMHxBdlNZOJnYEuK3kA7ou46fxuPq50e4Q5AknXtzyZAxPh8ZouFGyYpdI+mWeXGwKyu5yIaQ0iUaSSAd21BlpvZqeG2f0wE5mVA1Frk/VRqPHjWtH6dz3dhkiG0KKtNSrMd3T2xGimXQl/DHmfFmzY+8xg22xElm4OuDC2h/RDeIkFxM5vpM+8A7eO1ezMYwkh5T2epxuEOcZFem7rb8x3DJJSIMUKXOceJFeZykPOmPta9oK8aqX3UH7yly9i4AylPaLj58QRNg95Kw3c3M9iaeFiAeVqKyy1EB7DB0+0+8O18IW5if79K+N9SaClhJz68gpc0Za1mioTvWqEMqT8+Cdgo0ZaY1KedZ5Vg4x9I5L2485HzajoYQCMZFQnIBxdIZvv+B30rgO3Q1mvN3wAYfJ0IDCdHOB14w4N9nuZXwmgGMeZ3OmFqxOMAr+bjc0qJ991OOU2N6pt7yTWzJA1l5w8a7VAnAGX0TxPFuraZfRHfRP3LolyURSvvMjnniIy5tirm1rgtt31mXzNBFA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(66946007)(83380400001)(122000001)(38070700005)(38100700002)(5660300002)(66556008)(66446008)(52536014)(66476007)(8936002)(71200400001)(508600001)(54906003)(76116006)(55016003)(2906002)(8676002)(26005)(6506007)(53546011)(110136005)(316002)(9686003)(4326008)(7696005)(86362001)(33656002)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2515 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 52f6014a-0abc-4eb3-1000-08da38948c46 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /SIY9J7RhRj8ZT/3Vtd01fFX5kQyLKn9CH6UA3PW0mUxSGtaaDNUm7w/4CMAox4k21G4XAS90fRgs1U76wjepqwecJltoTs9zI3QhcFZgMvH3Cn8FqODhIKUC47j/FFnkKrUp4eWPpIjBOZDZrj6Sp7Dtmjd53eQRMAPVxY0lQiyjr13EGby0ynWXpmWxJrZWgNQlOTbr90cE+IaGE23uzkKRb5/qhaDWYfeeFZp5G88JiJmVISbS776jNA994Wu7agm5JpvjWqeEXE89XqHLY5izqW6hDNDK6hCq8dKIC3PxxErE8O7yONk+ZQunud8B+SCpH1MKBBEV4laxSpmNWBB8lxMHNpQsviGeYTXzlGfBp82YJLdTKXP1k6encYUMn+/uSjCPWD05t8FJptSe1z14OClCE+kbHBzyW6iWfbA+K6nXFmRlmOAvK9pwR18AYkjOwGQr3j3MEIjL45YEGJsXUfc2zv7N+dvy9pSmXDuXAm6xXDgN87u+028tb8hfJZDFSIvo4vea1tDXzeSJx+JvgEcAlWGtsIIKUf6yK5svFgtHD+lL87ZLggpvgc6uKM4kKCDCJyyCdDTtV6RaYhkZ/zw54b+2/6eAa2IgSD5LQwWt9Cs/pcWpbp9g5/ilhWBPGVfQVhM1S5MiXXTupawdeprmV7/qOtjAdJETDe5Bbj0+D2hyPe/kBTaK397 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(9686003)(2906002)(356005)(47076005)(336012)(82310400005)(186003)(83380400001)(86362001)(316002)(36860700001)(110136005)(33656002)(40460700003)(70586007)(8676002)(52536014)(508600001)(5660300002)(8936002)(70206006)(6506007)(53546011)(55016003)(26005)(7696005)(54906003)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 06:06:42.4693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 990d89fa-2336-4888-eefc-08da38949492 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6405 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVHVlc2RheSwgTWF5IDE3LCAyMDIyIDU6 MjkgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47 IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+Ow0KPiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ow0K PiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0IDEvNl0geGVu OiBkbyBub3QgZnJlZSByZXNlcnZlZCBtZW1vcnkgaW50byBoZWFwDQo+IA0KPiBIaSwNCj4gDQo+ IE9uIDE3LzA1LzIwMjIgMDk6MjEsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IFllcywgIEkgcmVt ZW1iZXJlZCB0aGF0IGFzeW5jaHJvbm91cyBpcyBzdGlsbCBvbiB0aGUgdG8tZG8gbGlzdCBmb3Ig c3RhdGljDQo+IG1lbW9yeS4NCj4gPg0KPiA+IElmIGl0IGRvZXNuJ3QgYm90aGVyIHRvbyBtdWNo IHRvIHlvdSwgSSB3b3VsZCBsaWtlIHRvIGFzayBzb21lIGhlbHAgb24gdGhpcw0KPiBpc3N1ZSwg OykuDQo+ID4gSSBvbmx5IGtuZXcgYmFzaWMga25vd2xlZGdlIG9uIHRoZSBzY3J1YmJpbmcsDQo+ IE15IGt3bm9sZWRnZSBvbiB0aGUgc2NydWJiaW5nIGNvZGUgaXMgbm90IG11Y2ggYmV0dGVyIHRo YW4geW91cnMgOikuDQo+IA0KPiA+IEkga25ldyB0aGF0IGRpcnR5IHBhZ2VzIGlzIHBsYWNlZCBh dCB0aGUNCj4gPiBlbmQgb2YgbGlzdCBoZWFwKG5vZGUsIHpvbmUsIG9yZGVyKSBmb3Igc2NydWJi aW5nIGFuZCAiZmlyc3RfZGlydHkiIGlzIHVzZWQgdG8NCj4gdHJhY2sgZG93bg0KPiA+IHRoZSBk aXJ0eSBwYWdlcy4gSU1PLCBCb3RoIHR3byBwYXJ0cyBhcmUgcmVzdHJpY3RlZCB0byB0aGUgaGVh cCB0aGluZ3ksICBub3QNCj4gcmV1c2FibGUgZm9yDQo+ID4gc3RhdGljIG1lbW9yeSwNCj4gDQo+ IFRoYXQncyBjb3JyZWN0Lg0KPiANCj4gPiBzbyBtYXliZSBJIG5lZWQgdG8gcmUtd3JpdGUgc2Ny dWJfZnJlZV9wYWdlIGZvciBzdGF0aWMgbWVtb3J5LCBhbmQgYWxzbw0KPiA+IGxpbmsgdGhlIG5l ZWQtdG8tc2NydWIgcmVzZXJ2ZWQgcGFnZXMgdG8gYSBuZXcgZ2xvYmFsIGxpc3QgZS5nLiAgZGly dHlfcmVzdl9saXN0DQo+IGZvciBheW5jDQo+ID4gc2NydWJiaW5nPw0KPiANCj4gU28gSSBjYW4g Zm9yZXNlZSB0d28gcHJvYmxlbXMgd2l0aCBzY3J1YmJpbmcgc3RhdGljIG1lbW9yeToNCj4gICAg MSkgT25jZSB0aGUgcGFnZSBpcyBzY3J1YmJlZCwgd2UgbmVlZCB0byBrbm93IHdoaWNoIGRvbWFp biBpdCBiZWxvbmdzDQo+IHNvIHdlIGNhbiBsaW5rIHRoZSBwYWdlIGFnYWluDQo+ICAgIDIpIEEg cGFnZSBtYXkgc3RpbGwgd2FpdCBmb3Igc2NydWJiaW5nIHdoZW4gdGhlIGRvbWFpbiBhbGxvY2F0 ZQ0KPiBtZW1vcnkgKElPVyB0aGUgcmVzZXJ2ZWQgbGlzdCBtYXkgYmUgZW1wdHkpLiBTbyB3ZSBu ZWVkIHRvIGZpbmQgYSBwYWdlDQo+IGJlbG9uZ2luZyB0byB0aGUgZG9tYWluIGFuZCB0aGVuIHNj cnViYmVkLg0KPg0KDQpVbmRlcnN0b29kLCB0aGFua3MgZm9yIHRoZSB0by10aGUtcG9pbnQgaW5z dHJ1Y3Rpb24hIDspDQpGb3Igc2NydWJiaW5nIG9uIHJ1bnRpbWUsIHVuLXBvcHVsYXRpbmcgbWVt b3J5IHdpbGwgZnJlZSByZXNlcnZlZCBwYWdlcw0KdG8gcmVzZXJ2ZWQgbGlzdCwgdGhlbiBhc3lu YyBzY3J1YmJpbmcgd2lsbCBtb3ZlIHRoZW0gdG8gYSBwZXItZG9tYWluIGxpc3QuIExhdGVyDQp3 aGVuIHNjcnViYmluZyBpcyBmaW5pc2hlZCwgd2UgbmVlZCB0byBhZ2FpbiBtb3ZlIGl0IGJhY2sg dG8gdGhlIHJlc2VydmVkDQpsaXN0Lg0KQW5kIGlmIHdlIGZhaWxlZCBvbiBhY3F1aXJpbmcgYSBw YWdlIGZyb20gcmVzZXJ2ZWQgbGlzdCwgdGhlbiB0cnlpbmcgdG8gZ2V0IGEgcGFnZQ0KZnJvbSB0 aGUgcGVyLWRvbWFpbiBsaXN0IGFuZCBzY3J1YiBpdC4gDQoNCkFuZCB3aXRoIGluaXRpYWwgc2Ny dWJiaW5nLCBzaW5jZSB0aGUgY29uY2VwdCBvZiBkb21haW4gaXMgbm90IGNvbnN0cnVjdGVkLCBh DQpnbG9iYWwgbGlzdCBpcyBiZXR0ZXIuDQpSaWdodCBub3csIHdlIGFsd2F5cyBhbGxvY2F0ZSBz dGF0aWMgbWVtb3J5IGZyb20gc3BlY2lmaWVkIHN0YXJ0aW5nIGFkZHJlc3MsDQpzbyBqdXN0IG1h a2Ugc3VyZSB0aGF0IHBhZ2UgaXMgc2NydWJiZWQgYmVmb3JlIGFsbG9jYXRpb24uDQoNCj4gVGhl IHR3byBwcm9ibGVtcyBhYm92ZSB3b3VsZCBpbmRpY2F0ZSB0aGF0IGEgcGVyLWRvbWFpbiBzY3J1 YiBsaXN0IHdvdWxkDQo+IGJlIHRoZSBiZXN0IGhlcmUuIFdlIHdvdWxkIG5lZWQgdG8gZGVhbCB3 aXRoIGluaXRpYWwgc2NydWJiaW5nDQo+IGRpZmZlcmVudGx5IChtYXliZSBhIGdsb2JhbCBsaXN0 IGFzIHlvdSBzdWdnZXN0ZWQpLg0KPiANCj4gSSBleHBlY3QgaXQgd2lsbCB0YWtlIHNvbWUgdGlt ZXMgdG8gaW1wbGVtZW50IGl0IHByb3Blcmx5LiBXaGlsZSB3cml0aW5nDQo+IHRoaXMsIEkgd2Fz IHdvbmRlcmluZyBpZiB0aGVyZSBpcyBhY3R1YWxseSBhbnkgcG9pbnQgdG8gc2NydWIgcGFnZXMg d2hlbg0KPiB0aGUgZG9tYWluIGlzIHJlbGVhc2luZyB0aGVtLiBFdmVuIGlmIHRoZXkgYXJlIGZy ZWUgdGhleSBhcmUgc3RpbGwNCj4gYmVsb25naW5nIHRvIHRoZSBkb21haW4sIHNvIHNjcnViYmlu ZyB0aGVtIGlzIHRlY2huaWNhbGx5IG5vdCBuZWNlc3NhcnkuDQo+IA0KDQpUcnVlLCB0cnVlLCBp ZiBzdGF0aWMgbWVtb3J5IHVzZWQgYXMgZ3Vlc3QgbWVtb3J5LCBldmVuIGlmIHRoZXkgYXJlIGZy ZWUsIHRoZXkgYXJlIHN0aWxsDQpiZWxvbmdpbmcgdG8gdGhlIGRvbWFpbi4gRXZlbiBhcyBzdGF0 aWMgc2hhcmVkIG1lbW9yeSwgaXQgaXMgcHJlLWNvbmZpZ3VyZWQgaW4gYm9vdC10aW1lDQphbmQg Y291bGQgbm90IGJlIHVzZWQgZm9yIGFueSBvdGhlciBwdXJwb3NlLg0KSG1tbSwgbWF5IEkgYXNr IHRoYXQgaWYgd2UgcmVib290IHRoZSBkb21haW4gYW5kIGRpZG4ndCBzY3J1YiB0aGUgcGFnZXMg YmVmb3JlLCB0aGUNCm9sZCBzdGFsZSBjb250ZW50cyB3aWxsIG5vdCBhZmZlY3QgdGhlIHJlYm9v dGluZyBtYWNoaW5lPw0KT3IgaXQgc2hvdWxkIGJlIHRoZSBndWVzdCdzIHJlc3BvbnNpYmlsaXR5 IHRvIGRvIHRoZSBjbGVhbmluZyB1cCBiZWZvcmUgdXNpbmcgaXQ/DQoNCklmIGl0IGlzIHRoZSBn dWVzdCdzIHJlc3BvbnNpYmlsaXR5LCB5ZWFoLCBtYXliZSBzY3J1YmJpbmcgdGhlbSBpcyB0ZWNo bmljYWxseSBub3QNCm5lY2Vzc2FyeSwgZmx1c2hpbmcgVExCIGFuZCBjbGVhbmluZyBjYWNoZSBp cyBlbm91Z2h+IFNvIHNob3VsZCBJIHJlbW92ZSB0aGUgc2NydWJiaW5nDQp0b3RhbGx5IGZvciBz dGF0aWMgbWVtb3J5Pw0KDQo+IEFueSB0aG91Z2h0cz8NCj4gDQo+ID4+PiAgICB7DQo+ID4+PiAg ICAgICAgbWZuX3QgbWZuID0gcGFnZV90b19tZm4ocGcpOw0KPiA+Pj4gICAgICAgIHVuc2lnbmVk IGxvbmcgaTsNCj4gPj4+IEBAIC0yNjUzLDcgKzI2NTcsOCBAQCB2b2lkIF9faW5pdCBmcmVlX3N0 YXRpY21lbV9wYWdlcyhzdHJ1Y3QNCj4gcGFnZV9pbmZvDQo+ID4+ICpwZywgdW5zaWduZWQgbG9u ZyBucl9tZm5zLA0KPiA+Pj4gICAgICAgICAgICB9DQo+ID4+Pg0KPiA+Pj4gICAgICAgICAgICAv KiBJbiBjYXNlIGluaXRpYWxpemluZyBwYWdlIG9mIHN0YXRpYyBtZW1vcnksIG1hcmsgaXQgUEdD X3Jlc2VydmVkLiAqLw0KPiA+Pj4gLSAgICAgICAgcGdbaV0uY291bnRfaW5mbyB8PSBQR0NfcmVz ZXJ2ZWQ7DQo+ID4+PiArICAgICAgICBpZiAoICEocGdbaV0uY291bnRfaW5mbyAmIFBHQ19yZXNl cnZlZCkgKQ0KPiA+Pg0KPiA+PiBOSVQ6IEkgdW5kZXJzdGFuZCB0aGUgZmxhZyBtYXkgaGF2ZSBh bHJlYWR5IGJlZW4gc2V0LCBidXQgSSBhbSBub3QNCj4gY29udmluY2VkIGlmDQo+ID4+IGl0IGlz IHdvcnRoIGNoZWNraW5nIGl0IGFuZCB0aGVuIHNldC4NCj4gPj4NCj4gPg0KPiA+IEphbiBzdWdn ZXN0ZWQgdGhhdCBzaW5jZSB3ZSByZW1vdmUgdGhlIF9faW5pdCBmcm9tIGZyZWVfc3RhdGljbWVt X3BhZ2VzLA0KPiBpdCdzIG5vdyBpbiBwcmVlbXB0YWJsZQ0KPiA+IHN0YXRlIGF0IHJ1bnRpbWUs IHNvIGJldHRlciBiZSBhZGRpbmcgdGhpcyBjaGVjayBoZXJlLg0KPiANCj4gV2VsbCwgY291bnRf aW5mbyBpcyBhbHJlYWR5IG1vZGlmaWVkIHdpdGhpbiB0aGF0IGxvb3AgKHNlZQ0KPiBtYXJrX3Bh Z2VfZnJlZSgpKS4gU28gSSB0aGluayB0aGUgaW1wYWN0IG9mIHNldHRpbmcgUEdDX3Jlc2VydmVk IGlzDQo+IGdvaW5nIHRvIGJlIG1lYW5pbmdsZXNzLg0KPiANCj4gSG93ZXZlci4uLiBtYXJrX3Bh Z2VfZnJlZSgpIGlzIGdvaW5nIHRvIHNldCBjb3VudF9pbmZvIHRvIFBHQ19zdGF0ZV9mcmVlDQo+ IGFuZCBieSBjb25zZXF1ZW5jZSBjbGVhciBQR0NfcmVzZXJ2ZWQuIFRoZWZlcm9yZSwgaW4gdGhl IGN1cnJlbnQNCj4gaW1wbGVtZW50YXRpb24gd2UgYWx3YXlzIG5lZWQgdG8gcmUtc2V0IFBHQ19y ZXNlcnZlZC4NCj4gDQo+IFNvIGVmZmVjdGl2ZWx5LCB0aGUgImlmIiBpcyBwb2ludGxlc3MgaGVy ZS4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed May 18 06:12:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:12:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331639.555183 (Exim 4.92) (envelope-from ) id 1nrCvN-0006cS-Gk; Wed, 18 May 2022 06:12:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331639.555183; Wed, 18 May 2022 06:12:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCvN-0006cL-Ce; Wed, 18 May 2022 06:12:45 +0000 Received: by outflank-mailman (input) for mailman id 331639; Wed, 18 May 2022 06:12:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCvM-0006cB-TI; Wed, 18 May 2022 06:12:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCvM-0005Rt-Pn; Wed, 18 May 2022 06:12:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrCvM-0003vf-F1; Wed, 18 May 2022 06:12:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrCvM-0004zn-Ea; Wed, 18 May 2022 06:12:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dn1RNEUVUGD0kr6PLp5+0XV/7T/4k6i1nw+Y9AlRYA8=; b=64psylkTeaKxYTQuLTfqLzB7Zs kEFGhJ4bVSrlx97/PJsXctaUqP1YR1KO3o4qATyOktBUxL/nqJVPJc/aBI/tEEkFxEsDfq8UWcwUL N3ptslmUceWMoK+RIiBcdaF2K+Rlggor+m7Z/V8yZXJhaksMhaeLwVr5zeQaDEQ/RZtk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170528: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 06:12:44 +0000 flight 170528 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170528/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1078 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 97 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 06:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331649.555193 (Exim 4.92) (envelope-from ) id 1nrD8P-0008Cm-Mk; Wed, 18 May 2022 06:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331649.555193; Wed, 18 May 2022 06:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrD8P-0008Cf-K1; Wed, 18 May 2022 06:26:13 +0000 Received: by outflank-mailman (input) for mailman id 331649; Wed, 18 May 2022 06:26:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrD8O-0008CZ-D1 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 06:26:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 680c70c4-d673-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 08:26:10 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-QdaMWq4UMVikErmKxS3qgA-1; Wed, 18 May 2022 08:26:08 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7812.eurprd04.prod.outlook.com (2603:10a6:20b:245::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 06:26:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 06:26:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 680c70c4-d673-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652855169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=udtt9DZaHliwyybm45+TNCq+fZwZ5FXpsEEgrQuDyuc=; b=glz0lsvjPzEV6keGfs78k5AfMXvLh6M4G0pRQk42QcXmoHUepEJgz+9X8BEGJr1vo3enFd Gieiu0RxMUtQas3jk97RSAX8qHauft5Ci75A7S7rjUR6bDAiqehFLQeFV6zQmKJX/5UOlr 1IqaCh6Qx+K6vIgV24YowZITpSz03Mc= X-MC-Unique: QdaMWq4UMVikErmKxS3qgA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PzZnXAfwYteEGdGsk+MHOv/Lh5RBtzxYn66BWSi2sW20ID7OMmzGMH18PaauAuy+6g8r5vY9jHSig7uVmmCxKBjfqhpzm4bnX4n0hOC69sZ6GeeBIAqaATizHJk+48aWA1wtIiMQ2kYrQxEN7oY+oCdiHFNrKhhMUObUy2svakNuGu1F3XFxFe3Yf4azPfgsOUIljL7kPZpsKKPXV1LK5aMfpaTEfKY8By+cwIR6ujyfUTBaiOQmfRdArOv4g9kcGCH0FH283QP2H6ndxovDtnwVp5bCZFdjvcwrNpe702617zzGxw6jxHA81hYqfNlW4/CG4/QzxDr6baxLuQIM2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6DU8D9HB3drtRuuSaHOegBjamoMEXyE7bavKOxLjNM=; b=ZhjvuW1p76mcCJkvhlV8fVoLrJutgvfszFihGWHNNdPGiDzmWoMbL8k9C3WyXdASjP9ZXWI76e9VZaRdSsNQx32Z2CuDBp5b6aoOo1IkIfrMHZb3dIqfISaW+Wo4lYJSp5QVlYRMfz9HPhgPM3D6pxBsABlwB2trtfBSIdREdysd/IWdR3fJc8Rv2/x7YfFC+lHzV6EXYxXZO7IwAhhY0L2nTpu6dQvKCAdIQQ6+2VWGYeNDWQNrUYqgtK2mLPVtlkFmacog+EvFLApyF7JIPTn1EDBaWG8NlYOY1S6dsc1rhfuaU1V0W7qab3lmwMIc8FkBg6oVmguxgMDEZhFjEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 08:26:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] x86/p2m.h: Add include guards Content-Language: en-US To: Roberto Bagnara CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Xen-devel , Andrew Cooper References: <20220509122409.14184-1-andrew.cooper3@citrix.com> <20220509122409.14184-2-andrew.cooper3@citrix.com> <000745e7-0b0e-386e-861e-901319defde3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR0301CA0033.eurprd03.prod.outlook.com (2603:10a6:20b:469::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12c1ca5f-a9c2-4d89-84ff-08da38974a3f X-MS-TrafficTypeDiagnostic: AM8PR04MB7812:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yOkOWqGTAycltA2qPeBNBdPrPZ4B81AK1V/5v4IXF1kxEzRzRUt6z2jN6vc+H7JpPDFoJucpJg+6729AYAW2ItgTqZXeDVn9A6rbJ9iNnGlm0WSYarecadHn4/Ljh0M3iyCGWsB58MRb1LroMYOkvwuOxIgvOWEl+F92KnQp2AlEYMYxMp8+2yiFJP1Z4CA6NIIPM381SuOY/umS02KGWChem1maGEv0H5nu+7x7DKZ84iJ/K0pwOvpfbnXIijG55HTY6xLlab3lnyfyTengbZ04y0/vj8tWWBVu+XgbxuAhW8ipY6Fk2V3R/7rYipHxRce0lpq+EJ+OzkPkp00hThsLR+gFiS24R/bz8wzeyl17JkU5poAFgld4vaXv90wBb9970iI4N4QKQju4WqaTonhiVZKFVxQugeE8RZ2YHdxS5reydUufsyPY7er3kGN5/Zh06o97NPz+ov7YQyxpXTBkLS/M04ABjWHkI2IztZAV3EIc7UzKEnOsALwCOZA5w76XTLzqy06axK4YhjcKLoUehGy7Z7s3tWrcGlWgBr+RfsK4v3jhN/or2JCUTqlxzbJXHDk2vLdkYW9zQWDNrqZ2zmCVsZvHb3aKEx6rPBnjf7oY+vIBsnVhpPRuE2xL0BW1/Qj+LMhO+rzKBUmX1QKhCm2gzUecrei20JAxJE1vWhs4zUA8lcF3pvPioAv+HY+Wz7nYMdIG6VDGDE5W1vQC66Hx0n+B42vYCvz1H6ag7zHdcloa78tqCNkO9zbZi82STv2mduJWqpyVS3eEjy0KWNu38fKoxWHX615dwPM9HBiOoKAhYMqof9XUAyk9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(83380400001)(508600001)(8936002)(54906003)(316002)(6916009)(38100700002)(186003)(2616005)(53546011)(86362001)(4326008)(66476007)(8676002)(66556008)(31696002)(66946007)(6506007)(5660300002)(6512007)(36756003)(2906002)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bngt/BHii0u+9VsPybepiUBNDNX+h/6klP0SBVg1CnANecp0vW6ukudoiQrs?= =?us-ascii?Q?cAfb9yh8EWWHOl6MspAm9TNLZn4rVXaleQ+wpWNFbq0+A0aGj5c7obL+tirr?= =?us-ascii?Q?jr28W8U0LQZ31akKJFOJVxnztdDJwIBPl+KirFfAqmzJ8el+T+/FPIBAOcwV?= =?us-ascii?Q?vXBsBnYg7L5Ss3bIiAAEmbLZVAGQs3kVfhKpVeomi+gDJuDc//io6RJwWIPT?= =?us-ascii?Q?2mnBsXTqjUpBl0N0zoWdGrfM57BGTfs/LCxsvXmq8b3fRuQM7bitbU1uqdhw?= =?us-ascii?Q?D0+X+wRY5GnL3ycJQKb8NdSv1o2K+U68Pc2DJrC9jZr0JKMRlCPo5yz0O/0e?= =?us-ascii?Q?puuTY6Yt0v6oNlw412xnvMgb9nAbVBDGdvX1Z8Ti5cZ58nJjzuE39FtFQQDh?= =?us-ascii?Q?kbpKYC5qbQ/WBLLmDJAniD5bq1obw/EW5pUTQJ3VCOzfjFIM8wdxYjKW4yH4?= =?us-ascii?Q?7b4+XboRuGeYWriYl31HYrDhS5cLkBTN1AZ4mnccqeuQAlx0i8I4r6uzTskM?= =?us-ascii?Q?VItqSnLo4+PYooXGsdcTjR2gUCoEY7FyzkYQwRt9SSdmv/b+E5u92ao46Cl/?= =?us-ascii?Q?Hai8ebpJRrE75K6VzJ5K1PSUgIctdb95XuKKwME8UEKMcU4Ni2zvk7K33Lsz?= =?us-ascii?Q?/R36hQkO3VCF83crPoADX/KiC6o1CpgzsbW/XpUAq/eh7S2DlG2hCL9a/xuQ?= =?us-ascii?Q?LKk6DfDU+9eKzyhqkfPQiXLJg2MTxWH1YcZzDTnZChi7T8yUo6ZK51Trf7i5?= =?us-ascii?Q?oWOWSobrwwf9FR3hH0UUo0moYHQoACdBDKdC8BTvsX9MJTSkBqqsJ3eTEL4A?= =?us-ascii?Q?md1B/AntxQsTqI6X5zjPOq2C1oh5xmBGlFwM55WsD7AOnirxu5eu6+ugPuDB?= =?us-ascii?Q?uprYeew8EOdCdQgav3wTADse2cK1qzwxvZOuvbKlP6gDewycFPZolVKrOeeT?= =?us-ascii?Q?md9L81Du7WxRWO1JkgPjKakL7Mf9WNhzMUTXs15raKYvRtj3a0FjVAyjdkwN?= =?us-ascii?Q?JboeE6yoKmbz5vzbLS5bQUhFbkE+a6P7HGxEiEVt3lSYAEci80/xqD0OK09A?= =?us-ascii?Q?vRoEmxfml4d9q6xwHxZPIVDR6aMa950zwcXtjFCoHyApVoDYHn2zs/CqYL6C?= =?us-ascii?Q?rjAJtsPL37FMN5fY/Yl3Wyt5nm5cYv1cwkCcqsANbCNqb4NGaaia+mNrbilN?= =?us-ascii?Q?I9B2bHCQimCoFotTpq2zEEpzkY6yhs7vsNiUDmWy0RYHOAaZz1joI/ZZ9HdV?= =?us-ascii?Q?wCvQDkJluu/vmt/mEFvtZm2PN1OzjZ4DnFmI8AP3RB7a33G0nIcpRZMq/CtI?= =?us-ascii?Q?c2Qt384A5Yqcny1Tz9dwWTakWmVe+9fwXIeVWmj1Hgn8Sq+uBQr7+eKEPVz1?= =?us-ascii?Q?A28EEV2SQxJ8FohOqFS+tV0Ki1WdxUv1USJ7HFuR0dOAOWwfZvW1dqRb1CFC?= =?us-ascii?Q?5mxzB2tS4Reo0IwvcbWnqoO/r2X0ov54bX9cfzVFfuqREsX0Jl1X+e29asqD?= =?us-ascii?Q?Y9WDCVx61cOH0qCQFWrW4EzzRoLCyD5N8yvl8B6u7NFA29EHHH6gZPMxzFrC?= =?us-ascii?Q?5pd5pysQE0gr2kT3VtG8vUZiAqjULXYYUVtp+REUdvdGH9xynM5+HR4UIOP6?= =?us-ascii?Q?+vinyIMott+7wc2kftjRCB3UJ08ZxFPjt7IkdKqHeeXNw2hAhTeTrbgC3SB0?= =?us-ascii?Q?Fok3M/O8IsmVJOYKVxnbHs5abK1b6xAJrWfCK+R9J7ts+Wl2ALaEN0gPgDRH?= =?us-ascii?Q?p0Z3CC8AAA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12c1ca5f-a9c2-4d89-84ff-08da38974a3f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 06:26:06.4802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bZt5MUOnbTdom+AJawMK60Tah6vbninG64r2b9KfkcueynhZOwCEFRTlkRiw5z9+b8B/unyIsO9GyZ3M+dn1pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7812 On 17.05.2022 20:42, Roberto Bagnara wrote: > On 17/05/22 17:38, Jan Beulich wrote: >> On 09.05.2022 14:24, Andrew Cooper wrote: >>> Spotted by Eclair MISRA scanner. >> >> I'm sorry, but what exactly was it that the scanner spotted? It was >> actually deliberate to introduce this file without guards. I'm of >> the general opinion that (private) headers not to be included by >> other headers (but only by .c files) are not in need of guards. If >> it is project-wide consensus that _all_ header files should have >> guards, then I'll try to keep this in mind (in "x86emul: a few >> small steps towards disintegration" for example I introduce >> another such instance), but then it should also be put down in >> ./CODING_STYLE. >=20 > The rationale of this rule is as follows: >=20 > - With a complex hierarchy of nested header files, it is possible > for a header file to be included more than once. >=20 > - This can bring to circular references of header files, which > can result in undefined behavior and/or be difficult to debug. This, in particular, is known to happen in our and other source bases despite the use of guards, hence I view this point as at best partly related. Nevertheless I agree with and understand the reasons for using guards _where they are needed_. I do not agree that guards need to be there for no specific reason. Jan > - If multiple inclusion leads to multiple or conflicting definitions, > then this can result in undefined or erroneous behavior. >=20 > - Compilation and analysis time is needlessly increased. >=20 > There has been a period (which lasted until the end of the '70s > or the beginning of the '80s, I would have to dig up to be > more precise) when the solution was thought to be "headers > shall not to be included by other headers but only by .c files." > Experience then showed that, in medium to large projects, > each .c file had to begin with a long list of #include > directives; such lists needed to be ordered to accommodate > the dependencies between header files; in some cases the > lists were so long that: >=20 > a) it was a kind of black magic to find out the right > inclusion order, one that would work in any of > possibly many project configurations; > b) the lists of #include directives often contained duplicates, > possibly because the desperate programmers where trying > to find the right order. >=20 > In the end, the software engineering community converged > on the idea that guards against multiple inclusion are > a much better alternative. >=20 > Of course there are valid reasons to deviate the rule: > some header files might be conceived to be included > multiple times. A one-line configuration for ECLAIR > will do the trick to make sure such header files are > not reported. >=20 > Kind regards, >=20 > Roberto >=20 >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: Roger Pau Monn=C3=A9 >>> CC: Wei Liu >>> CC: Stefano Stabellini >>> CC: Julien Grall >>> CC: Volodymyr Babchuk >>> CC: Bertrand Marquis >>> --- >>> xen/arch/x86/mm/p2m.h | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h >>> index cc0f6766e4df..dc706b8e4799 100644 >>> --- a/xen/arch/x86/mm/p2m.h >>> +++ b/xen/arch/x86/mm/p2m.h >>> @@ -15,6 +15,9 @@ >>> * along with this program; If not, see . >>> */ >>> =20 >>> +#ifndef __ARCH_MM_P2M_H__ >>> +#define __ARCH_MM_P2M_H__ >>> + >>> struct p2m_domain *p2m_init_one(struct domain *d); >>> void p2m_free_one(struct p2m_domain *p2m); >>> =20 >>> @@ -39,6 +42,8 @@ int ept_p2m_init(struct p2m_domain *p2m); >>> void ept_p2m_uninit(struct p2m_domain *p2m); >>> void p2m_init_altp2m_ept(struct domain *d, unsigned int i); >>> =20 >>> +#endif /* __ARCH_MM_P2M_H__ */ >>> + >>> /* >>> * Local variables: >>> * mode: C >> >> >=20 From xen-devel-bounces@lists.xenproject.org Wed May 18 06:30:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:30:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331658.555205 (Exim 4.92) (envelope-from ) id 1nrDCh-0001Ei-Co; Wed, 18 May 2022 06:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331658.555205; Wed, 18 May 2022 06:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDCh-0001Eb-8w; Wed, 18 May 2022 06:30:39 +0000 Received: by outflank-mailman (input) for mailman id 331658; Wed, 18 May 2022 06:30:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDCg-0001EV-2n for xen-devel@lists.xenproject.org; Wed, 18 May 2022 06:30:38 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07429427-d674-11ec-837e-e5687231ffcc; Wed, 18 May 2022 08:30:37 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-Aq_EgDsIPLCNu43gCEn_KQ-1; Wed, 18 May 2022 08:30:35 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7812.eurprd04.prod.outlook.com (2603:10a6:20b:245::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 06:30:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 06:30:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07429427-d674-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652855436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yRha0q94rdBud0ylljLnX/WSz4bAkEUpYGAp5fitZfQ=; b=Wjc8NVwuhL+4sYdJ4PFXyszAfcrA4FRy9NyLcb4TvqeAIfLiL9Qzg0XX1VZdu1DlWwOZUu rqPzTcqIz/ET/nVx5MwNQHZNHCWEP+lQvaUi1nrqTxTO8UXjDqqo+mbL94mLyRWgPAgLRT Hnk/LR6lRl1Pm388oJU2i7FkFyV0KVk= X-MC-Unique: Aq_EgDsIPLCNu43gCEn_KQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtqDS5ax9FQ0f5Qjoy8GNWjYhmjWYrU0ah6R7C7wELArNAONklMNSFWXxYDrtTbFm3VfEH/6JUJdrSJ6wf+LGL6chn8yDkTzHk3UdXDP/3jv96lFyUkr77+zw0HkgpQ3A4w6BssSr15SYi57WXEb+7Kncgjz/iiFyZbFLRmsov6Hbk6vmU6Yizfgd1IwNpdJdkb1pEbhRFNVNO0MiLLY+LNm1mMXpab2/TpRHsvcO4rExjaegyY5qfYaTLwrv4aampHxi87/5ejUPf9jBbL/YSnnYmtRcJiWJKuFtahK+vrtzSQdqT2rkeVckkfPRgaYmm4XOWzyOyUOmNAslhs7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yRha0q94rdBud0ylljLnX/WSz4bAkEUpYGAp5fitZfQ=; b=jZLb0e8Iye1SLLhqagH7mSd/fujKUPiyhmg7rlF5n0kHJ1YMCq4mtzHsFLibHvQPuA8xT1Np9okV2ojeVfwN5sKNq0MSX8uY3c0lXYkIZNv947Obcq0elFXffv5JLf9SoYCqwuojx0nyY4UqujsWVP96ApUKetBSLQktYHV8Nvt5oooECZ2FsfwBoWeLK28aTA33vdZBW3YOAFkk/mHM8z0MzGInmLPBVAntF+ln21aOMuh0mBedSc4V7AUW/s2ctLLy+EebnTujUxccE2Mw1YvhQRw5/TzQKDYS4yDbtDXsZCgtl5Wtc5LNvIefTqH2FMTghB9lYqKtcTUDDtpqZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2b46cd18-8ef7-f0e8-c58f-a0332f07d921@suse.com> Date: Wed, 18 May 2022 08:30:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , "julien@xen.org" References: <20220510022733.2422581-1-Penny.Zheng@arm.com> <20220510022733.2422581-2-Penny.Zheng@arm.com> <20dd9308-3cdc-4ebb-61b2-e0a71e808697@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0125.eurprd04.prod.outlook.com (2603:10a6:20b:531::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4fe62c0-d52e-4daa-484c-08da3897e9e7 X-MS-TrafficTypeDiagnostic: AM8PR04MB7812:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qC23hf4f+dvnozN9e8l+7i+vQtKwMGscU8QraocxCF0SMOSpylQ55fQGklOnugQS7QXJfm53s3NPaaPRfUlJQpG9vdetl4tMBKcsN2dWRABxlq6WCLYP9Wwg+RjrR3Z3MuEljN4A7cl4GLhTRocuuvemK61J/9uiOTuGPeKHApQOdCMvPM4BgSTpMAzF9IoeUQ3N1nXmopK57J5M4BGsewbv8K5k1hQfWR7JECwRccsNxVewFlIs0aXbuNX+AzOLNaBX84ol4RpuxIed4caAYjB/2WuBZD8wut4A4I32RpXK4L5v07Bu8wfe/ncZOApSg5uEDw5Ygav9YWPy/fe9DTIPb5wJrnXAs/XdEas/Zf4fWAAa7kZazuHZGXckvXzx6H1LSqcuPPXScwYYWpfgbOHawTmtKlNaSBM8eQveTt/zjVM6s1Uws677X1E7OsPFIRRtQsGg6LQnrsvcfji95mwpyQUbVTTi4ScV1F8UeoIiicu/VOqcIExWuVpNvrZa9TtY6QJSZUhLaHct2Z/aniLV1QdtTXrInvBNEvlrYmUdoiGvdLQlvyDvOXNE/4N+pIuowI52YxWGB9HjIBIp8UbE1yZdsdYn1Alpp0i0DkSJIrGCmK1PP+LMhcCbf0lGLXZBJt5KLEcYrwgjk/kXJQVoA6WPQJuiVhk6nuLU8z+oLMxecuI5ArAPIXEKGcLuIYGnCf0SKPI9EoSis8YFK+lUITmuOIvhr5SHjM8YU6I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(83380400001)(508600001)(8936002)(54906003)(316002)(6916009)(38100700002)(186003)(2616005)(53546011)(86362001)(4326008)(66476007)(8676002)(66556008)(31696002)(66946007)(6506007)(5660300002)(6512007)(36756003)(2906002)(26005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHJDSTBsWTk0Q2YyUkpDZXNOclNWdFJRTHRtWTVsQUVuaTRuSmFWcFg4SG5Y?= =?utf-8?B?TXdkZ0hqR3Y0TTNtU1FMZ0grSXpWS2Rjc0VOWnlBMmFweXluK1c2alJXNm5Q?= =?utf-8?B?YzhFSWg5c25Iemk2WWZLTGVPdHZEODlCbWxmNGhURHM3TXBDbS9aMUl0NGxa?= =?utf-8?B?b2N1emI1L0lKZmpvSjlHVmVRWmFCaWlRUWpHeGkxNWZxQ0EzYU1tN2h4V0h5?= =?utf-8?B?cnVJMmhsZ2JqT1BRRjlVMDNRb0ozVGxOWGV5RFhDdFk5UllmRnY3cThyNzFo?= =?utf-8?B?enhvajNiTEhlTUR1bzE2U3BOTUcwdHRHcmtDcjluZjlTWCs0QnBHRHlBMzRW?= =?utf-8?B?ellPYlIxdjg2TWVNRGRQb2ZLRnlsY3liZEtJY054WkxkY2J5V3BMbGZQN3cz?= =?utf-8?B?WTdETGlPbDJqTkhRclhkZ0tnK2hTZDdmU3RpNEpRS2JiVytBT21oMytsSkNK?= =?utf-8?B?RzkzVC9rMENONWZDa2tSWENQc0piMGZvOUI4MUR0bmlTa3Z5OGZUM0RBS1da?= =?utf-8?B?ZGw3eHZJaTdzQTlNTGxTRVlXclFJV2pyQ0xHcnpWMDdBYnZQMTZxS2ozb1Fx?= =?utf-8?B?TGpWSW1Dd1I4NjZ0aStlYkJwVGN4RzE2T2dGOWM1RFhWUXc1dEJZM0lYNHFY?= =?utf-8?B?YTBvU3ZjS2VJL0RnZTdSSHFOZW56MkswbGI3TlF5bW9HZFFOWFR1YjNnd0c4?= =?utf-8?B?R3RVYkFjOVh6aHBwU1hCUEE0RElXcGF4L1RvQzRtd2pKR3FrRHdrTDlPVTFM?= =?utf-8?B?Nnp5V1Znckx6QVJBeWFvMURONmVyVUttOFBGaDdMeFAvRFo2ZFozb2xpYVhG?= =?utf-8?B?dkZaVXBUV1AvT0JpdTZlVUM0QUlQaHVWUlRSMExMZWwzTU5zdW1GNDJWUkNV?= =?utf-8?B?Mk9Nak5PbUdtMHhOTlp2NmtVazBCbEFJcDRlN3ZuRmlyWjRSSlhxTGpsa0dh?= =?utf-8?B?RDFUYTVsWGxyN0dwcDRZdEFpTHdrR2ZLdUdKWkcySlJxV09JZXV5OTJCODRl?= =?utf-8?B?Qm5NcmdlOVF4V0RIbnlKYVpVc0s4RmZKY2RFZ2NSb0xQSUVCVEtldW1VbmNH?= =?utf-8?B?QXg0ZXluQUVQSkxCWXZya1BOYzg5OFB4b3d4dTQ4QVl3Vlo2K29ubFp1Z1Z0?= =?utf-8?B?cS8vQU1XM1RKcytHSGJjZkJ0Q0ljdlBGdkFRVWhGbHhENUlLK2haZDhLNlhN?= =?utf-8?B?UjU3QzRNVWtIV3dTeXhJOGNQQStUZWxpQUJUVmp0OGQxV04vZWZNTTN1R0h4?= =?utf-8?B?cmJsSnlWRndpaEk3U2JNVmdiRjNSR29yR2s1ZjdpZU1CWjZrVkdBUU5PSytl?= =?utf-8?B?dVhudkhWUCtKL3A1bnJPMEtJTzExenQ4Q3dxNTJaZ3RHVndwQkRuMGcwdkJG?= =?utf-8?B?ZGFvUGZzd1c4YUVTSHE5RVc0RkkwSkJKUXc3ZFdpeG9yRnJZTmNhaUk2V2lK?= =?utf-8?B?RUZ4cFl4RkdPYW5YOWtyVXBTNkE0Y1lTYWVaNnlGaWwyMXU0VlJDNHAzVXcw?= =?utf-8?B?eXJOdzkrVFN4NWFUVUozK0RIdTJmK0lDRmpsNHMyVmFhZWdGcHVRWk4vZVU5?= =?utf-8?B?U1V3YnJTdTZDSU91TFZvTnBKNUlFOXljbnJSdGZ0MS9BeCtjTkROd2NNY1Zs?= =?utf-8?B?RU4reFRGVGh5MzJPVjhGbzUwOEQxbERiOFdxTUMxN1NlNGpBSktEQkhSZzRr?= =?utf-8?B?aDFaTnZYRUZ2c2ZSd0Y3SWplcks5YldkSy9Gdm9sSDZUenVocGFvOWdOcFIr?= =?utf-8?B?cnh0NVltNHhuekp1M1lSdVdVSEowTmxsZ3ROU1cyOWx5VWNmT3dNMnZxUXcr?= =?utf-8?B?am9La3VPQkhZWExrV2dzNm1zUVFIc1BqOWs0M0wxNllaeG5RalRHZHVQd0lV?= =?utf-8?B?Z2xheThFWnU2Y2RQZUdpTk5IU2VHMmlOZWh1T0NnMFIxeG5lSnhOcGZlRjlG?= =?utf-8?B?aHBQZ0NtdWRNSm9nM0pJSDBmMWNaRHROTVJkb29zZGlCY1VQWVUybWZIK3Bw?= =?utf-8?B?V2ZmVVJVYzRXRGtJWkJ5UERRNXdTTTViRzNqRGJtZTVobElMaDJzUnRmRDJn?= =?utf-8?B?Q2M0ZFVhQ3NHc3ViSjg3MzBjanJkQWJTMXRjY3NWZDdURnFybjJDdEJHaEd6?= =?utf-8?B?WFhhRXNPNThLRjAvYmZ4dldCS0VzTXBNWEdQQWJiOGxsYmdmOUNqTGhoQVE0?= =?utf-8?B?QmRaeUh3cWxuakxSUW1SR245ZU9YWVpYSWQ5NkY1dDZPejdvZWw2R3NmeXI5?= =?utf-8?B?Qmdqak1lY3dhdUN4b1dHY2dPVCtHNFlRTm9Semd3RmhmSTRGd20zMmdaN29l?= =?utf-8?B?ZjMvS3Eya3Y0KzJxeFZFVlRzaDlnVnMwV0tnZFZLRWpwa0FxWFZxdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4fe62c0-d52e-4daa-484c-08da3897e9e7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 06:30:34.3218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5n/gV5PPAIwZYkdTL/N9FFeSs7nXGb4r4biPHZShQXYdE1rnmVVeE5vZGJg3FOUtyiW29Q5PjCNRE7CU9zsRJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7812 On 18.05.2022 04:29, Penny Zheng wrote: > Hi Jan and Julien > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, May 18, 2022 12:11 AM >> To: Penny Zheng >> Cc: Wei Chen ; Andrew Cooper >> ; George Dunlap ; >> Julien Grall ; Stefano Stabellini ; Wei >> Liu ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v4 1/6] xen: do not free reserved memory into heap >> >> On 10.05.2022 04:27, Penny Zheng wrote: >>> @@ -2762,6 +2767,12 @@ int __init acquire_domstatic_pages(struct >>> domain *d, mfn_t smfn, >>> >>> return 0; >>> } >>> +#else >>> +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, >>> + bool need_scrub) { >>> + ASSERT_UNREACHABLE(); >>> +} >>> #endif >> >> As before I do not agree that we need this (or similar) stub functions. As >> already suggested I think that instead Arm wants to #define PGC_reserved (to >> non-zero) only when !CONFIG_STATIC_MEMORY, just like is already the case >> on x86. >> > > Ok, if you do not like the stub function, then what about I putting the #ifdef-array back > to the common where free_staticmem_pages is used: > #ifdef CONFIG_STATIC_MEMORY > if ( pg->count_info & PGC_reserved ) > /* Reserved page shall not go back to the heap. */ > return free_staticmem_pages(pg, 1UL << order, need_scrub); > #endif No. Stub functions, when they are really needed, are generally preferable over #ifdef-ary inside functions (for readability reasons at least). Yet even better is if stub functions can be avoided altogether. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 06:36:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:36:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331666.555216 (Exim 4.92) (envelope-from ) id 1nrDHx-0001xw-2K; Wed, 18 May 2022 06:36:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331666.555216; Wed, 18 May 2022 06:36:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDHw-0001xp-Tw; Wed, 18 May 2022 06:36:04 +0000 Received: by outflank-mailman (input) for mailman id 331666; Wed, 18 May 2022 06:36:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDHv-0001xj-7m for xen-devel@lists.xenproject.org; Wed, 18 May 2022 06:36:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c917de64-d674-11ec-837e-e5687231ffcc; Wed, 18 May 2022 08:36:02 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-w0mG4C5cOU2OYJmnypHH4A-1; Wed, 18 May 2022 08:36:00 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4471.eurprd04.prod.outlook.com (2603:10a6:20b:1f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 06:35:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 06:35:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c917de64-d674-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652855761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUnxJlf70ABxdlGX1Cvqac8nk0xl2eQ6Y7R03gLXchY=; b=O7odZGd4SPuXEcxdmWwmDkZ6RBA77GGd9oFV8vjg10MNojdewDmpbCdoPlmpulCOghGzmw YTZSk+TIGTzhhIJ+5dhKa7OCaAOK9w3AVzDfsPErhtasynjO7msIr6jdzs94YCBQdvlhjk l8ATQJHQpgZxvTrA6ra76u8HUCaCc38= X-MC-Unique: w0mG4C5cOU2OYJmnypHH4A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/nppf4wkvN+pCPLsWF+BIBYZ06K8XBksDNPruCVEUF+W8IP0X1RBZW3x46DVZ4oLrE5/j8VivMWapzm8Xwrz8mVaXm8J5xhDW80RSfOjBKFxu8lE/Hlnam943APukOQ9ffcVQT6Brme/wPUrjOyxHhMvikIa5VSEDzT1QF0vCNecWYTGUBxOELgDaHCQGKgtlMT8jpU6Nq94Y6idcMJ0pK3/TvZUIZghuvVK7fGeIdIgugbTdYOY0FeMPIv6tcZNvuaDycl5vJWVvBcTOsgWIHbKCUT38dGBGbr/SCxPsNwbwFHGQ8vFN3htZUy+fxbH/sWgQ+yCzcqMe2WvFXjVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MUnxJlf70ABxdlGX1Cvqac8nk0xl2eQ6Y7R03gLXchY=; b=iZCSB28Cluddu/sBK9npjYwJksmHGSlwOMRSN7XxmM1FbF0mNuLb8U66EGqrEGNMzKYiMD4Ufosst2VhY2+Tn/VzMHCJkIjxlUZ28CA4iLYSzj8xNDJyZxFEDBgMI2ObYwSAZmszNdV2X30x1ouzajsMX1dp4pVv7iVmZrwAYlFmOt0XWT3vjXgkj/a960afpykrGCfJBlza8wyQziRCis/DvcZl8mo7RyULH5EbBxGFEkFbBgFpYbNtr+n3SsLiHU1bRLyLtNislX6/priFt5pXzdGX7aZrAyNEm/afQExmXTdKJrgV+ttcHnkqYE9CULdOwQXW/4Q+misrwIfQMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <385c964d-0d25-3967-5683-3731dc1eb0c2@suse.com> Date: Wed, 18 May 2022 08:35:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220517090529.3140417-1-Penny.Zheng@arm.com> <20220517090529.3140417-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0028.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fca0b8b9-da77-4cca-1531-08da3898ab64 X-MS-TrafficTypeDiagnostic: AM6PR04MB4471:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NycHPkO7ZEN4qxSYqJpt3CQQ27ogwdoAyw/Bhp14UH7NDSn/+wHrnLRx83+A5MU6PtldQ7NqgQe9WgATPL7ZFXCYVeSjJpLfTQILC4rzzhNMlpBrMBrrZWJnwj4Qnrr1abYqRkuHxUTP31M4y7+hQZ/Z46IoTdNYNGpqoZWTmUmYWXY+LAXSA3WVANUtGDLXmRJrM6v2BNWQ5nZL68fLLrmacYXLnSXfhozjnPjnEfo0TRXIIkHdtvHl3RxeNiNezwNwDL2GilOqg3cc6fN8RyamSP+mOqmcglvj+U4eAnXGvnokaWj1b9/5VzhCzwqw/ZOdk2W3mEO3zD1cMpwnBF82/TQuZoKcOnFKm+0W2p8U0Q0BCN6TuBpSsrKE9VXT0UWP53d53g3rg2yl6lK15GvnL+ODqa0GPCXHo8lTyqMs+Y7tjcff1GSLt/NsA7tuo+xVk6GqAVG0L1fwOiSm12EdMvVZJbNavouROCKWNikIS0zBVhzBX1FFZUzzhqMfDYiTGLs8ARYnG0FHme5+40f1vRj1mi5rcd1+LX8JKW6FOii2Der8a5Lo1WDd4k+RFS4GCxflN7jgCF9g9yoPy+E5XjKlZoHwN5m3Mw3RB8JQ48//nNEQTeXnOR0nfS6aj4qAstzQec4GWcHDOATb0+wxq2RB6rffIY9DwGvyfDbMY9L+mR9MhXyJaQNgBWWQ090r3yrS+rJyabIwwuOCPDR2nugTvpRwRWcdixIAEothPftMTlTIGfELHRZ4aY8Xs6bdZEC7ZB12S+4XSX1szg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(6486002)(508600001)(66556008)(6506007)(53546011)(6512007)(6666004)(7416002)(8936002)(2616005)(8676002)(2906002)(86362001)(83380400001)(31686004)(4326008)(54906003)(66476007)(316002)(6916009)(66946007)(36756003)(186003)(31696002)(26005)(38100700002)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmxMWWVvcTNMYW0rempEek5Ick1wNXVvbzd4TUw2eHh2ZXc1M05hYUFXYjc0?= =?utf-8?B?V2p0am41WHF2MzYySFhUbWpkNWwybC9FYWhvODlZK0FuUml3a3U0OWQ5emNT?= =?utf-8?B?YzJzZFE4SWZnaE9XV0RXd0NuN1BseXJpcGJENGdMMFpxM3JFSzRaSnJoNElH?= =?utf-8?B?RDRscDNNNGpQWHROSlpLNnloWEJIOXpSb29lVEJuNlMvU0t6TTYreW9jY3NU?= =?utf-8?B?R2ZWNHZ3MHFmTEJWWDQzcEV2Vk9JcDRKOUh6K3VDLzE2Mzczb1BwYTBYUDdF?= =?utf-8?B?UzN2MHFtaDVlUFhtWk5PYmRGNThPZG42eUllSVpNa2Q3QWgvT1o3a0JFeCtn?= =?utf-8?B?aEp4MkttSkpBUE1hT1ZPOHNuZXl5bnFlYVV4V0IvL0l2U05ySVVqUXNVSSts?= =?utf-8?B?ZENwNUxWRS9yQ2NwamRIUE5DdHkxUC9QcHRTSjBxdzZEZktPY3k2YnJhMVFN?= =?utf-8?B?bkRQUU5RdUNHRWxpMnUweG5nMzdWUDVjS3hNSGp5THBDRTRpMyt1cjFwb2RP?= =?utf-8?B?MU5SckZ6R05sdFFzR05rUHdvTHExNmp2WS9TV05WMEpuaE01Tm14YTZIZ05j?= =?utf-8?B?aERpS1ZHWTM3QzVDOGNmTkVDQlZ0bm9RQlMwVWhRU05mcGdqYk9IaE9Gb3ha?= =?utf-8?B?TzU5WFNJaEdaNGFoc09YYjNNSDBRdUhRejZQeEpRNHNzSDBIZzBJNHF4MGdG?= =?utf-8?B?K3VKWG1RamEyK1Q5V0dveFBVOFlTQXBwckhHTDlpR25lR0xjTU02Nmk1RTYv?= =?utf-8?B?emlxciswdHZ0RVJMRGRRNFhRRzFtYzNNUmJrcjllMk56WXAzMGlac01FMFJk?= =?utf-8?B?ZmwrVUxpTHpJeUFnUWNJMDYyMFFSb3RUNzQ4T05zWFhMUjlxNzNncXpxNy9Y?= =?utf-8?B?Y2Z0emoyWHBBUmZvZUMvNXFBZEErZld6VmV2Q3h0ZG9RNlFxanFRRzIyRTVL?= =?utf-8?B?dU1NVXQ2NzZuamZDTGZaUEg2ajBLbW12RDI3U0dFdTlkQWV0VGFDY0MrZUpo?= =?utf-8?B?VDQ2US9zSlc2K3RldERHYUlmUGpVUFloZVA3SWtFd2hvQ29VNHAyUHJDUFRS?= =?utf-8?B?Y09ES0JSeHZQTWRmUUhqOHNRanhSRW04UXhoeUI3b2VyeXI0Y1ViWmhmRzRz?= =?utf-8?B?OW9aL0dmZ3AzWEw2cDYzdS9tV1pHYm1lOXpXOHpjMjZRUWdNa0ZCb3BCM1J5?= =?utf-8?B?SDBpVzZTNU9mNmJXbXhnU0ZEaU9SU0tlMWtSOHh3L1VGS0sxOGEyRE5BWDhU?= =?utf-8?B?SHN2aXlwSjhqeHV0clNqN0hpQkZOVGd4Y09zY1pLMHpZZ1ovL08vM1VnZmQ3?= =?utf-8?B?R0FJZ0pZSTlBZ1RwQkEzZlhnY21lc2VPVDAwbkd5RHQyZjFCaHdOdldwbHJQ?= =?utf-8?B?bDFpQ1dNWDRXU1RjR0pMby9HOU14ayt2T0pqaGljODJjUkFJMG1JSUJMZlN5?= =?utf-8?B?TytjbDVpY3Arb293MWVCVDAzNHI4VmR1cFpKWThJQkVJNW0ybDdzTjcvUEhq?= =?utf-8?B?cTdYbzZCbm1FK2VwSWo5dUJON09FbUNxNDNab1VuQW11T0QydjdpcU5hTklR?= =?utf-8?B?WmNjZnpPSW9tdlIyMDRGWWdjblpKMnRQQmhGNGxnakVhUHFGOGZ5TlZhQ2Zz?= =?utf-8?B?NEZUT0x5VXdtTlpWaDdJdXYvNEZpTzRGOUNjaDJrOXFCQU4xcnpmdW9OSkVp?= =?utf-8?B?UjVoT0w4ZzFjWkZDQU42WlJ6djlNa3MrckhWaFFXcFZKKzlhbHhTVlJKS092?= =?utf-8?B?NTE3YkN3dVhvR2tUeVdUU0NOdTh6RGxHR1dlazFkcHQvZjlDa3htLzRabytC?= =?utf-8?B?VjNUd1ZBU2dqRnJNRTEwS3dxWjB4c3c0akRWUXJSdkdXVm9WWGxLaktQRWVI?= =?utf-8?B?ei9kaDgvSnpDQVR4aHpkdVZGa3ZDTTBLaE1XT0FKZ3R6cWdQUlBhbnR6RjZW?= =?utf-8?B?MFlvM0ZxQkxTbU9rTjVwOVVKTUZzR1ZtMlRQc0RVYkFrTUViVjZTeGNMaE5X?= =?utf-8?B?RmpvRlVGRUpKaDZkb0ViVCtINnNQc1lLQ3VmRjdiVXZUZ05seGxnT3ZkcWkr?= =?utf-8?B?L3pYYWRadFV3aXhhMm9GM1VpSGREc3NZMWptcjR3VUdock9jVEp0bkdGZERG?= =?utf-8?B?S1c0ODVBZEVad2drSVBhMk5MYVlzajJOMWc4aTVwdVZJakl0b2RCWWJmOFhO?= =?utf-8?B?dy9yYzhBUlphaTU4d3d6NEZPVEllNlhaT09JOEJqSTN0bFFETHk0aGZWZE9J?= =?utf-8?B?TjJsR08wUitQQXczaURwUjhVRGVEL0VqRXhCQ21Sdk9KS2JldkJXSEU1RGNS?= =?utf-8?B?c3hLWmkrdTJ1TXAxL0ZLdkRXRVBWNGt3c1BvYmJ1U20vMGZhbFZhdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fca0b8b9-da77-4cca-1531-08da3898ab64 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 06:35:58.9400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pphn9Al22jo1yrirv1jp4HK+QaI81vB77ac1fsqIeyWg7u5tsYLHqzLg0CpklKJCJ0FSvWNfb9Zy1cYZfvsW8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4471 On 18.05.2022 05:14, Penny Zheng wrote: > Hi Jan > >> -----Original Message----- >> From: Jan Beulich >> Sent: Wednesday, May 18, 2022 12:01 AM >> To: Penny Zheng >> Cc: Wei Chen ; Stefano Stabellini >> ; Julien Grall ; Bertrand Marquis >> ; Volodymyr Babchuk >> ; Andrew Cooper >> ; George Dunlap ; >> Wei Liu ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v4 2/8] xen/arm: allocate static shared memory to the >> default owner dom_io >> >> On 17.05.2022 11:05, Penny Zheng wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -780,6 +780,11 @@ void __init setup_system_domains(void) >>> * This domain owns I/O pages that are within the range of the page_info >>> * array. Mappings occur at the priv of the caller. >>> * Quarantined PCI devices will be associated with this domain. >>> + * >>> + * DOMID_IO could also be used for mapping memory when no explicit >>> + * domain is specified. >>> + * For instance, DOMID_IO is the owner of memory pre-shared among >>> + * multiple domains at boot time, when no explicit owner is specified. >>> */ >>> dom_io = domain_create(DOMID_IO, NULL, 0); >>> if ( IS_ERR(dom_io) ) >> >> I'm sorry: The comment change is definitely better now than it was, but it is >> still written in a way requiring further knowledge to understand what it talks >> about. Without further context, "when no explicit domain is specified" only >> raises questions. I would have tried to make a suggestion, but I can't really >> figure what it is that you want to get across here. > > How about I only retain the "For instance, xxx" and make it more in details. > " > DOMID_IO is also the default owner of memory pre-shared among multiple domains at > boot time, when no explicit owner is specified with "owner" property in static shared > memory device node. See section docs/misc/arm/device-tree/booting.txt: Static Shared Memory > for more details. > " This reads quite a bit better. Yet I continue to be puzzled about the apparent conflict of "pre-shared" and "no explicit owner": How can memory be (pre-)shared when the owner isn't known? Shouldn't all memory have an owner? Or alternatively if this sharing model doesn't require ownership, shouldn't all shared memory be owned by DomIO? In any event, to leave such details out of here, perhaps the comment could consist of just the first part of what you wrote, ending at where the first comma is? Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 06:51:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 06:51:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331674.555227 (Exim 4.92) (envelope-from ) id 1nrDWp-0004Kt-E8; Wed, 18 May 2022 06:51:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331674.555227; Wed, 18 May 2022 06:51:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDWp-0004Km-BW; Wed, 18 May 2022 06:51:27 +0000 Received: by outflank-mailman (input) for mailman id 331674; Wed, 18 May 2022 06:51:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDWo-0004Kg-1F for xen-devel@lists.xenproject.org; Wed, 18 May 2022 06:51:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eee61468-d676-11ec-837e-e5687231ffcc; Wed, 18 May 2022 08:51:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1EBC821B95; Wed, 18 May 2022 06:51:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC30513A6D; Wed, 18 May 2022 06:51:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Iq0AKGuXhGKTPgAAMHmgww (envelope-from ); Wed, 18 May 2022 06:51:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eee61468-d676-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652856684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QZ3xSzAbpENpHAyFUOE8ygTqPn5djDgy0iBJKdjMqII=; b=NilKRIim5KBXGg2kwSJPHd8hVvDi2Nb6kBJh4CjXVJLsfc9J7IhMJn8zL4mO6FMrDI1cgY ZoBSbTNT9Ii9EIaJ/lovkIln3jcpF1Sa4GyCJE77e/mF0P4ATgmGat5hh0P8F/s12U4oST aKfH6aaL++D8pEtZS9UqDJpa4XLJ9o0= Message-ID: Date: Wed, 18 May 2022 08:51:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid Content-Language: en-US To: Josh Poimboeuf , Maximilian Heyne Cc: Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220517162425.100567-1-mheyne@amazon.de> <20220517164229.ixz7fqxwrxwmiizn@treble> From: Juergen Gross In-Reply-To: <20220517164229.ixz7fqxwrxwmiizn@treble> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------74x0OnXh0yd7AIWTKDFPGdV2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------74x0OnXh0yd7AIWTKDFPGdV2 Content-Type: multipart/mixed; boundary="------------CCXoDBa40f5JJDFmJ1SLT0DL"; protected-headers="v1" From: Juergen Gross To: Josh Poimboeuf , Maximilian Heyne Cc: Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid References: <20220517162425.100567-1-mheyne@amazon.de> <20220517164229.ixz7fqxwrxwmiizn@treble> In-Reply-To: <20220517164229.ixz7fqxwrxwmiizn@treble> --------------CCXoDBa40f5JJDFmJ1SLT0DL Content-Type: multipart/mixed; boundary="------------JZLfEJinIuvVgpen3Kze5FMZ" --------------JZLfEJinIuvVgpen3Kze5FMZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDUuMjIgMTg6NDIsIEpvc2ggUG9pbWJvZXVmIHdyb3RlOg0KPiBPbiBUdWUsIE1h eSAxNywgMjAyMiBhdCAwNDoyNDoyNVBNICswMDAwLCBNYXhpbWlsaWFuIEhleW5lIHdyb3Rl Og0KPj4gU2luY2UgY29tbWl0IDRkNjVhZGZjZDExOSAoIng4NjogeGVuOiBpbnNuOiBEZWNv ZGUgWGVuIGFuZCBLVk0NCj4+IGVtdWxhdGUtcHJlZml4IHNpZ25hdHVyZSIpLCBvYmp0b29s IGlzIGFibGUgdG8gY29ycmVjdGx5IHBhcnNlIHRoZQ0KPj4gcHJlZml4ZWQgaW5zdHJ1Y3Rp b24gaW4geGVuX2NwdWlkIGFuZCBlbWl0IGNvcnJlY3Qgb3JjIHVud2luZA0KPj4gaW5mb3Jt YXRpb24uIEhlbmNlLCBtYXJraW5nIHRoZSBmdW5jdGlvbiBhcyBTVEFDS0ZSQU1FX05PTl9T VEFOREFSRCBpcw0KPj4gbm8gbG9uZ2VyIG5lZWRlZC4NCj4+DQo+PiBUaGlzIGNvbW1pdCBp cyBiYXNpY2FsbHkgYSByZXZlcnQgb2YgY29tbWl0IDk4M2JiNmQyNTRjNyAoIng4Ni94ZW46 IE1hcmsNCj4+IHhlbl9jcHVpZCgpIHN0YWNrIGZyYW1lIGFzIG5vbi1zdGFuZGFyZCIpLg0K Pj4NCj4+IFNpZ25lZC1vZmYtYnk6IE1heGltaWxpYW4gSGV5bmUgPG1oZXluZUBhbWF6b24u ZGU+DQo+PiBDQzogSm9zaCBQb2ltYm9ldWYgPGpwb2ltYm9lQGtlcm5lbC5vcmc+DQo+Pg0K Pj4gY3I6IGh0dHBzOi8vY29kZS5hbWF6b24uY29tL3Jldmlld3MvQ1ItNjk2NDUwODANCj4g ICAgICAgIF5eXl5eDQo+IA0KPiBUaGlzIGxvb2tzIGxpa2UgYW4gaW50ZXJuYWwgYW1hem9u IGxpbmsgYW5kIHNob3VsZCBiZSByZW1vdmVkLg0KPiBPdGhlcndpc2UsIGxvb2tzIGdvb2Qg dG8gbWUuDQoNCkNhbiBiZSBkb25lIHdoaWxlIGNvbW1pdHRpbmcuDQoNClJldmlld2VkLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------JZLfEJinIuvVgpen3Kze5FMZ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JZLfEJinIuvVgpen3Kze5FMZ-- --------------CCXoDBa40f5JJDFmJ1SLT0DL-- --------------74x0OnXh0yd7AIWTKDFPGdV2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKEl2sFAwAAAAAACgkQsN6d1ii/Ey/A 7wf2KDlTnSiyyI8o5vega9yByUIpmzyC52POyc67sYCwjK5eGs3q8izbF2JgTZotA2STLQniX9R/ KxHE8Jhfo4tTLiUnDpljoPzEn6VVuJkgeGAYDWJqOhYlr7OteqJZIOhD/Z07jI9MatbKjRqe+aRj TD9BOJg6W/r0uAWdGBc9B0HFPTKxi7+P6LMgCvbPzeRlDl/H9bjX1kCHvnXlIjvrd59UQ76S1eRg rrsxUapIDsQ0Kcj+Ei/TB5qcGeZuAoGUr1Lq3/y+BdocxdMMYD+pJ2dPKfj6t2VpIvSztgyrQ0gl +3EUwPWeeNis6ODa+H4GU/IvXYeX6yq23FjGfyMS =mleQ -----END PGP SIGNATURE----- --------------74x0OnXh0yd7AIWTKDFPGdV2-- From xen-devel-bounces@lists.xenproject.org Wed May 18 07:20:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331683.555238 (Exim 4.92) (envelope-from ) id 1nrDyy-0007vm-QU; Wed, 18 May 2022 07:20:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331683.555238; Wed, 18 May 2022 07:20:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDyy-0007vf-Ni; Wed, 18 May 2022 07:20:32 +0000 Received: by outflank-mailman (input) for mailman id 331683; Wed, 18 May 2022 07:20:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDyx-0007vV-TI; Wed, 18 May 2022 07:20:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDyx-0006n8-QD; Wed, 18 May 2022 07:20:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrDyx-0007LY-CU; Wed, 18 May 2022 07:20:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrDyx-0007HT-C2; Wed, 18 May 2022 07:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eI39KHnuNgzs9Mx59x1Yrqy+cYLiAxwU0e8UCwnEVW4=; b=EuCgmDSYxyx3mpdiXJTiFcduwA UeGhsKrjE3hhmvtTs5FDVaBlB8vHYXBmw8bxxBIr8b1rT6TjrlXvMbbDIjHUhUJNSbgQOUA4T8zjS SFHcVRuNGwsFV/cBFplgdW+Hy8XfoHxlZKhit63qaRECl5K2Gw8+/xJICQJM8Of68xhk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170527: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=9cd2c5257afc9ca985b9b713922c5c68f524f44a X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 18 May 2022 07:20:31 +0000 flight 170527 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170527/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 9cd2c5257afc9ca985b9b713922c5c68f524f44a baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 677 days Failing since 151818 2020-07-11 04:18:52 Z 676 days 658 attempts Testing same since 170527 2022-05-18 04:18:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 107956 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 07:34:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331693.555249 (Exim 4.92) (envelope-from ) id 1nrEC8-0001CB-2H; Wed, 18 May 2022 07:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331693.555249; Wed, 18 May 2022 07:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEC7-0001C4-V9; Wed, 18 May 2022 07:34:07 +0000 Received: by outflank-mailman (input) for mailman id 331693; Wed, 18 May 2022 07:34:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEC6-0001By-IX for xen-devel@lists.xenproject.org; Wed, 18 May 2022 07:34:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e47471bd-d67c-11ec-837e-e5687231ffcc; Wed, 18 May 2022 09:34:04 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8990E1F9A4; Wed, 18 May 2022 07:34:03 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id AA6042C142; Wed, 18 May 2022 07:33:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e47471bd-d67c-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652859243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YR5rOhmSURb4d/IKXy5VZg8z1ImD01Us4xBpVFtyoqU=; b=apiSUoAwUbqeAccPNQ19K+RPeAfjpiC+Kw09kP9gYD08Bjqn9sy6l8W4iwyq6IQeI6Aplp +YIfJeRJqbcdQptzveOcUb8Q0R7nuJcbMiyUrGxQWxZdDf/W1Ubmr612J8Zmj7lPwrkx5l wG1cTFsW35nAwzkY9hs+1GgrMVmINpw= Date: Wed, 18 May 2022 09:33:57 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Evan Green , David Gow , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , Linux PM , Florian Fainelli , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi , Stephen Boyd Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2022-05-17 13:37:58, Guilherme G. Piccoli wrote: > On 17/05/2022 10:28, Petr Mladek wrote: > > [...] > >>> Disagree here. I'm looping Google maintainers, so they can comment. > >>> (CCed Evan, David, Julius) > >>> > >>> This notifier is clearly a hypervisor notification mechanism. I've fixed > >>> a locking stuff there (in previous patch), I feel it's low-risk but even > >>> if it's mid-risk, the class of such callback remains a perfect fit with > >>> the hypervisor list IMHO. > >> > >> This logs a panic to our "eventlog", a tiny logging area in SPI flash > >> for critical and power-related events. In some cases this ends up > >> being the only clue we get in a Chromebook feedback report that a > >> panic occurred, so from my perspective moving it to the front of the > >> line seems like a good idea. > > > > IMHO, this would really better fit into the pre-reboot notifier list: > > > > + the callback stores the log so it is similar to kmsg_dump() > > or console_flush_on_panic() > > > > + the callback should be proceed after "info" notifiers > > that might add some other useful information. > > > > Honestly, I am not sure what exactly hypervisor callbacks do. But I > > think that they do not try to extract the kernel log because they > > would need to handle the internal format. > > > > I guess the main point in your response is : "I am not sure what exactly > hypervisor callbacks do". We need to be sure about the semantics of such > list, and agree on that. > > So, my opinion about this first list, that we call "hypervisor list", > is: it contains callbacks that > > (1) should run early, preferably before kdump (or even if kdump isn't > set, should run ASAP); > > (2) these callbacks perform some communication with an abstraction that > runs "below" the kernel, like a firmware or hypervisor. Classic example: > pvpanic, that communicates with VMM (usually qemu) and allow such VMM to > snapshot the full guest memory, for example. > > (3) Should be low-risk. What defines risk is the level of reliability of > subsequent operations - if the callback have 50% of chance of "bricking" > the system totally and prevent kdump / kmsg_dump() / reboot , this is > high risk one for example. > > Some good fits IMO: pvpanic, sstate_panic_event() [sparc], fadump in > powerpc, etc. > > So, this is a good case for the Google notifier as well - it's not > collecting data like the dmesg (hence your second bullet seems to not > apply here, info notifiers won't add info to be collected by gsmi). It > is a firmware/hypervisor/whatever-gsmi-is notification mechanism, that > tells such "lower" abstraction a panic occurred. It seems low risk and > we want it to run ASAP, if possible. " > >> This logs a panic to our "eventlog", a tiny logging area in SPI flash > >> for critical and power-related events. In some cases this ends up I see. I somehow assumed that it was about the kernel log because Evans wrote: "This logs a panic to our "eventlog", a tiny logging area in SPI flash for critical and power-related events. In some cases this ends up" Anyway, I would distinguish it the following way. + If the notifier is preserving kernel log then it should be ideally treated as kmsg_dump(). + It the notifier is saving another debugging data then it better fits into the "hypervisor" notifier list. Regarding the reliability. From my POV, any panic notifier enabled in a generic kernel should be reliable with more than 99,9%. Otherwise, they should not be in the notifier list at all. An exception would be a platform-specific notifier that is called only on some specific platform and developers maintaining this platform agree on this. The value "99,9%" is arbitrary. I am not sure if it is realistic even in the other code, for example, console_flush_on_panic() or emergency_restart(). I just want to point out that the border should be rather high. Otherwise we would back in the situation where people would want to disable particular notifiers. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Wed May 18 07:38:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:38:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331701.555259 (Exim 4.92) (envelope-from ) id 1nrEFy-0001nj-Ka; Wed, 18 May 2022 07:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331701.555259; Wed, 18 May 2022 07:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEFy-0001nc-HW; Wed, 18 May 2022 07:38:06 +0000 Received: by outflank-mailman (input) for mailman id 331701; Wed, 18 May 2022 07:38:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEFx-0001nU-GL for xen-devel@lists.xenproject.org; Wed, 18 May 2022 07:38:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEFx-00073y-9W; Wed, 18 May 2022 07:38:05 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrEFx-0002xc-3W; Wed, 18 May 2022 07:38:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=ZbxWDhfGztVxsCqINZPoROVpBMzUzF+YX3ntdkvMdks=; b=Y7Bb5H9jXNxK4KQzo+Nb9W8uYX yptvhkdKzL1CUmiy8yE5kGqTVvwPcpvUDvAjgPrPIfvrCgYtkWMMgBOAO+k2IIsR3iGSSmlwaigg0 PQyvZYkj5P09+vnhV+K4NfAZSbAxhz/LFfARnYqI/u5stFsV9B80AB+YixdIpDm9J5IY=; Message-ID: <9bb6855e-ee93-691b-877e-b187db91dbd7@xen.org> Date: Wed, 18 May 2022 08:38:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Stefano Stabellini , Jan Beulich Cc: George Dunlap , xen-devel , Juergen Gross , Roger Pau Monne , Andrew Cooper , Bertrand Marquis References: <396325A0-7EE6-4EAC-9BB9-BA67D878E6AE@citrix.com> <5e4d505c-a02c-eb54-8299-b1078943a8a5@suse.com> From: Julien Grall Subject: Re: Process for cherry-picking patches from other projects In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 18/05/2022 04:12, Stefano Stabellini wrote: > On Tue, 17 May 2022, Jan Beulich wrote: >> Hmm. The present rules written down in docs/process/sending-patches.pandoc >> are a result of me having been accused of unduly stripping S-o-b (and maybe >> a few other) tags. If that was for a real reason (and not just because of >> someone's taste), how could it ever be okay to remove S-o-b? (Personally I >> agree with what you propose, it just doesn't line up with that discussion >> we had not all that long ago.) > > This is the meaning of the DCO: https://developercertificate.org > > The relevant case is: > > (b) The contribution is based upon previous work that, to the best > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit that > work with modifications, whether created in whole or in part > by me, under the same open source license (unless I am > permitted to submit under a different license), as indicated > in the file; or > > IANAL but I read this as to mean that only the submitter Signed-off-by > is required. Also consider that the code could come from a place where > Signed-off-by is not used. As long as the copyright checks out, then we > are OK. I don't think I can write better than what Ian wrote back then: " Please can we keep the Linux S-o-b. Note that S-o-b is not a chain of *approval* (whose relevance to us is debateable) but but a chain of *custody and transmission* for copyright/licence/gdpr purposes. That latter chain is hightly relevant to us. All such S-o-b should be retained. Of course if you got the patch somewhere other than the Linux commit, then the chain of custody doesn't pass through the Linux commit. But in that case I expect you to be able to say where you got it. " Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 18 07:38:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:38:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331709.555271 (Exim 4.92) (envelope-from ) id 1nrEGl-0002Qi-3A; Wed, 18 May 2022 07:38:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331709.555271; Wed, 18 May 2022 07:38:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEGl-0002Qb-0K; Wed, 18 May 2022 07:38:55 +0000 Received: by outflank-mailman (input) for mailman id 331709; Wed, 18 May 2022 07:38:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEGj-0002EE-VN for xen-devel@lists.xenproject.org; Wed, 18 May 2022 07:38:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90ddcc17-d67d-11ec-837e-e5687231ffcc; Wed, 18 May 2022 09:38:53 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id F09A21F9A4; Wed, 18 May 2022 07:38:52 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5D79B2C142; Wed, 18 May 2022 07:38:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90ddcc17-d67d-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652859533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+lyyDjAjgyfEhWEBfN0EDdR6Jmx4pHSl+tBKIhX1g7c=; b=j0w4/FD8BT6n50PoBFWZ2B9hxn1McNizrLx3lcvWYTHgmFBxhdJUV3RAv4Ssdii4QSileV Dl88LCOs7NY6Zlry9hleanS5GY4TpOEfeqkhXf/HNSrx5fV+jFGy5YS3+L30Mt6n4dNsLm vyO1S4F65bAw7AbpuXo9HU2OHf85ddo= Date: Wed, 18 May 2022 09:38:52 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Scott Branden , Sebastian Reichel , Florian Fainelli , David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2022-05-17 13:42:06, Guilherme G. Piccoli wrote: > On 17/05/2022 10:57, Petr Mladek wrote: > >> Disagree here, I'm CCing Florian for information. > >> > >> This notifier preserves RAM so it's *very interesting* if we have > >> kmsg_dump() for example, but maybe might be also relevant in case kdump > >> kernel is configured to store something in a persistent RAM (then, > >> without this notifier, after kdump reboots the system data would be lost). > > > > I see. It is actually similar problem as with > > drivers/firmware/google/gsmi.c. > > > > I does similar things like kmsg_dump() so it should be called in > > the same location (after info notifier list and before kdump). > > > > A solution might be to put it at these notifiers at the very > > end of the "info" list or make extra "dump" notifier list. > > Here I still disagree. I've commented in the other response thread > (about Google gsmi) about the semantics of the hypervisor list, but > again: this list should contain callbacks that > > (a) Should run early, _by default_ before a kdump; > (b) Communicate with the firmware/hypervisor in a "low-risk" way; > > Imagine a scenario where users configure kdump kernel to save something > in a persistent form in DRAM - it'd be like a late pstore, in the next > kernel. This callback enables that, it's meant to inform FW "hey, panic > happened, please from now on don't clear the RAM in the next FW-reboot". > I don't see a reason to postpone that - let's see if the maintainers > have an opinion. I have answered this in more detail in the other reply, see https://lore.kernel.org/r/YoShZVYNAdvvjb7z@alley I agree that both notifiers in drivers/soc/bcm/brcmstb/pm/pm-arm.c drivers/firmware/google/gsmi.c better fit into the hypervisor list after all. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Wed May 18 07:54:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331718.555281 (Exim 4.92) (envelope-from ) id 1nrEVw-0004wP-FH; Wed, 18 May 2022 07:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331718.555281; Wed, 18 May 2022 07:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEVw-0004wI-C8; Wed, 18 May 2022 07:54:36 +0000 Received: by outflank-mailman (input) for mailman id 331718; Wed, 18 May 2022 07:54:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEVv-0004w8-MB; Wed, 18 May 2022 07:54:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEVv-0007Kc-Ji; Wed, 18 May 2022 07:54:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEVu-0000VE-V0; Wed, 18 May 2022 07:54:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrEVu-0002l0-UX; Wed, 18 May 2022 07:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YTlc3Yzwt/5jnhNwp0Rm14JvAf5QjkIbt9NTzdWbtVE=; b=6JuUeyzzzjg+7H+Z3h0WUxgjpP xDR/3izMNaHZv1odSf85O9w3NvtXZp4GYSD9sPLMQwY40nez2PO4UucM8G0bUvFYj6utmafKlHTQS EBsA9kyTTF2n4F5ydn4TU/CtTsGq5CGoDRxRtAKBOqgnUKzpQywOaliW8CwV1nMCNWOc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170531: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 07:54:34 +0000 flight 170531 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170531/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1079 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 98 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 07:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 07:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331728.555293 (Exim 4.92) (envelope-from ) id 1nrEZc-0005Zo-1I; Wed, 18 May 2022 07:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331728.555293; Wed, 18 May 2022 07:58:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEZb-0005Zh-Tl; Wed, 18 May 2022 07:58:23 +0000 Received: by outflank-mailman (input) for mailman id 331728; Wed, 18 May 2022 07:58:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEZa-0005Zb-MO for xen-devel@lists.xenproject.org; Wed, 18 May 2022 07:58:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49344183-d680-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 09:58:21 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1B35021B9A; Wed, 18 May 2022 07:58:21 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 0683D2C142; Wed, 18 May 2022 07:58:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49344183-d680-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652860701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QH8rZRpDaB1rKzYBSvbHTkuJfXIZgq5PPOEyov0S61g=; b=T0gGp12c0pU5b8b1i3GTuIGm3SeP3EhRpXPECQNn/enftlsKdapz4VZkfCcS2uIPqM17q+ /PBA3AVHUNLBKEckN04LlFAw1RfXD18Ad2wMfhhColdg9InPjS0Cl4zZnO5bfZL0Ln9Soj 5NqvLRJqL5BZI+4DmlPHTXzoYIVJS4o= Date: Wed, 18 May 2022 09:58:18 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2022-05-17 15:57:34, Petr Mladek wrote: > On Mon 2022-05-16 12:06:17, Guilherme G. Piccoli wrote: > > >> --- a/drivers/soc/bcm/brcmstb/pm/pm-arm.c > > >> +++ b/drivers/soc/bcm/brcmstb/pm/pm-arm.c > > >> @@ -814,7 +814,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev) > > >> goto out; > > >> } > > >> > > >> - atomic_notifier_chain_register(&panic_notifier_list, > > >> + atomic_notifier_chain_register(&panic_hypervisor_list, > > >> &brcmstb_pm_panic_nb); > > > > > > I am not sure about this one. It instruct some HW to preserve DRAM. > > > IMHO, it better fits into pre_reboot category but I do not have > > > strong opinion. > > > > Disagree here, I'm CCing Florian for information. > > > > This notifier preserves RAM so it's *very interesting* if we have > > kmsg_dump() for example, but maybe might be also relevant in case kdump > > kernel is configured to store something in a persistent RAM (then, > > without this notifier, after kdump reboots the system data would be lost). > > I see. It is actually similar problem as with > drivers/firmware/google/gsmi.c. As discussed in the other other reply, it seems that both affected notifiers do not store kernel logs and should stay in the "hypervisor". > I does similar things like kmsg_dump() so it should be called in > the same location (after info notifier list and before kdump). > > A solution might be to put it at these notifiers at the very > end of the "info" list or make extra "dump" notifier list. I just want to point out that the above idea has problems. Notifiers storing kernel log need to be treated as kmsg_dump(). In particular, we would need to know if there are any. We do not need to call "info" notifier list before kdump when there is no kernel log dumper registered. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Wed May 18 08:04:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 08:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331739.555304 (Exim 4.92) (envelope-from ) id 1nrEfV-0007dj-WD; Wed, 18 May 2022 08:04:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331739.555304; Wed, 18 May 2022 08:04:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEfV-0007dc-ST; Wed, 18 May 2022 08:04:29 +0000 Received: by outflank-mailman (input) for mailman id 331739; Wed, 18 May 2022 08:04:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrEfU-0007dW-1u for xen-devel@lists.xenproject.org; Wed, 18 May 2022 08:04:28 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e2f2f70-d681-11ec-837e-e5687231ffcc; Wed, 18 May 2022 10:04:24 +0200 (CEST) Received: from mail-bn8nam11lp2173.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 04:04:17 -0400 Received: from MW4PR03MB6539.namprd03.prod.outlook.com (2603:10b6:303:126::9) by BN8PR03MB4849.namprd03.prod.outlook.com (2603:10b6:408:6d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 08:04:15 +0000 Received: from MW4PR03MB6539.namprd03.prod.outlook.com ([fe80::35ce:524c:ca7:b931]) by MW4PR03MB6539.namprd03.prod.outlook.com ([fe80::35ce:524c:ca7:b931%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 08:04:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e2f2f70-d681-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652861064; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=4oSTSSN+GOIBgwObdDIz7B0+vFewCtfzJ5tZT7MRp+8=; b=eiJjqHqpq1xIfEe2K0G8mg46Quc3gNwezIojdruVJz6Zwq1F6HIqnHTN aiA+ZPrnMKGtkkrXsJmjrmTVH6OGd2GwxJ1JX16fOqC+USYwgP7wa9gOq +slxF3lwursNwy3fvnzodxGcCWyna8VTA07Myl29nJfDxi6lqVcFzYtzp s=; X-IronPort-RemoteIP: 104.47.58.173 X-IronPort-MID: 71967777 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cFE+VqJTtk/mmbtjFE+RpJQlxSXFcZb7ZxGr2PjKsXjdYENS1TdVx 2dOC22CO/yJazP8c491aI/i9h8CvZXdytVgQFRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39c42YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 O9U67fsRRcABPLvl6dedEV5NSxOZZQTrdcrIVDn2SCS52vvViK1ht9IXAQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGvqRjTNb9G5YasRmFvbEZ tEFaDNpKhDBZRFONX8cCY4knffujX76G9FdgA3M9PRovDeMpOB3+P+3HubJZo2Nf8dqx17A+ F/jwDzWLihPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pbN kcdvCQnq6M/8Ei2ZtDnWluzp3vsg/IHc99ZEul/4gfdzKPRul+dHjJdEWUHb8E6vsgrQzBsz kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkinogpLeEJtsuDIJA== IronPort-HdrOrdr: A9a23:VrFF8KyMVsq/CTVKi/4WKrPxgOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SETUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZHN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUezpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZrcI5p4dYyxY/ouW3fRYzWTFcFcsnq5zXQISdSUmRUXeR /30lAd1opImjXslyqO0GbQMkHboUoTAjnZuBClaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77WzAD0ihbWAUqqOYmwtVrQcotQ0XbWLeUs4ikaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HfTvcdGaJZVj3HqAOPHzA75bx/bUu/emvPIcFyZMj8a 6xJ2+wdVRCD34GJff+rKGjqCq9MVlVdQ6duf129tx+pqD2QqbtPGmKVE0u+vHQ1skiPg== X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208,217";a="71967777" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VeUnfyplWwiYoIVGTAUMu/XPXLjD+goPUBqOJmno1KP/alqA6EXrG7AGMr++YvKDG3EtL3fscveW83d4nbCVFnNc+tcQRz6hyqUMI3KyhtopMKUXIXjBdL03G+ajdL8DFnquU3tCyUztVggRg0auFSLTRW/EpdzaVC2bsWySSq70FZL/iI/t+O1lFTm+NqQyz2dJHOFCvB+UYsY0vUMS6kd0yEEeocnI1vDf5ovglRk4NLnTE77tNG5Jsyjf9CyUKDouCvpExDZbzNNrrWezp5vptrVpkGJWvzOghFU6gdDh+RRtgLEqveRxLGCloy8HxepJzaCabSO86pXYhErfog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4oSTSSN+GOIBgwObdDIz7B0+vFewCtfzJ5tZT7MRp+8=; b=eWqbySmCIoEcoRpy3aE85UjIqqHwx0bs56o+RqzU6N4E9Hy8H3LLsUhvdwEAefCNZ+elpwMe6EtadXbqdO9srVAcoCNOzNbYG1SNTUl9NtVOSJPiyMTAgQ55ttGkGytbsWEkVID/px0VQUr8bHAaSicnivVGLUmhYzIZVvsTuwOseAjPawKZ7+HSpzvpkpkG3h7d3A+Qg5om/kUavmpPnXlDwOaZFTmoMbJHx5Y/NL+4EEuPh0+oMexPf2kXIuj6ZgtYmIJyRKMU1MzJiXl7qVVfZtT0Kc1BF5xQ23+B3NfNdDcraEimMFBCweVcCcsNFgNKJ54mxy43s72trb6h1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4oSTSSN+GOIBgwObdDIz7B0+vFewCtfzJ5tZT7MRp+8=; b=Y9orI12RB+NACRsxetIumkBLZDhGCiSJI3s+f6VDokyHE2D7Wp/c4jM7RGRuS8ExkpkZj8PuCx58hJhrG+ac3HGVsVYWhQeBQ6VIn5EwbvhtnyItMB54V8UxqMQX8l+SYwHl5HXoyFnZ3z8Ep6L1rk3QkiXXLzzUVYA5HQYM1gc= From: Christian Lindig To: Andrew Cooper CC: Xen-devel , Edwin Torok , Luca Fancellu Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYnpjIiUm2KvEKQoGhCQE/L260kR20A Date: Wed, 18 May 2022 08:04:15 +0000 Message-ID: <26C2A079-E373-4C42-88B0-1375F7CAB9BE@citrix.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> In-Reply-To: <20220517194113.2574-3-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3608.120.23.2.7) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db3e0112-f0a6-41d8-2ede-08da38a50064 x-ms-traffictypediagnostic: BN8PR03MB4849:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dPYA3ODv5yuA6aNQkdQSBDgQhjocCwDAYnVaMw5KvDq8ESj42+UUz/4wyQfAAqaXqtW2wzLcUkbbpPHYbJKdju3d0w6NwHuTLn4V9T5se2Z9O22V0KqrV/sy8/zra5B2MN4jaEY2LoawaYu91LCq/gIocXn/QzBah1AY6/z7O8uZvMEVXZIABOGAATlsPWqtP32kxQAL9CiJaSdpr9ODW1UWxMUOb5AUbvWqROhJ/006+OFN8C1VG1DgQfgwfQVT3g4xZrgfXxb2TC23FhFVDQetmwBVDEOq982DJ6wq9MNCSU0IqEt6NMHmCVS7Izee/XUJqVaSEgHEsCm/aEGZ8Sehb/cgxuAO5GVk7/qjnu2DztY1p5MyfAZEtp94g22+FPi2u89BTxx5y9qvHulf8j1rHGLnK0hEZp7t3H+3sYa1ZkkvBT1AhU7qWUyaXX7X2xmFDc8jNQZTvm1tM1bTwXTblnmLk62dpEObAZ5V2Y16ctXxH4LkM5bE6GK7D/EtB2nRf8vmFZ/t8wQzS+1kD+gf0BXxktxMF8lUluoBOFR+I8bW41aJ/WcnW++Eyfczt1kh+JRP7QuwJmXfp0vzvrdo2y1LzzCiS82dpvNW9Z3wnR+Be6guL2tRrqmNbSLwX2suaE6E4URgIndvg/vKWzDDMr5mbfbEvMxV23UEYZGxqP//faR5R/tOjU655PNn3ZVoMe6K28mdyorr7x7N6umzJpzZTKrvpopCpM42lOo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6539.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(8676002)(6862004)(4326008)(64756008)(76116006)(66946007)(66556008)(66446008)(316002)(38070700005)(66476007)(6636002)(66574015)(71200400001)(53546011)(54906003)(186003)(508600001)(6512007)(26005)(6486002)(6506007)(82960400001)(91956017)(44832011)(2616005)(36756003)(37006003)(2906002)(33656002)(86362001)(5660300002)(8936002)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZU1XUFJ3ekhJamJyODBreFNYYnhhSzB0b3FrSHdVbkUrbStERFpuUFk2dnVs?= =?utf-8?B?UGtySytDTnI0cFhldXRzNXlEQVFZcEt1Y3ZYM0RJV2w0ckNuQ3ZtM2dEN0Nz?= =?utf-8?B?WWJRMENzRkE4SHZkUS9tayszd205Qlk0VnB1QmJtb0tWYXhyOEhRY3RSZlFJ?= =?utf-8?B?b0dGTkdjbnJ0N3FsUmx4YWRXVS9LVlJib3JVNXNhOXp1TjZwY3dXS01iSTBC?= =?utf-8?B?UlJTOVBIT0p6Q1RFanQvMEZ1WU14WVZQejlhNGdRNGJwOUNIaEQ0MWNZV0dZ?= =?utf-8?B?M0hkbWc0Uk5ybW01M1d4MUdzZzlxbEFxeHlGZ0k0WjFnOUxsaEpQcCtMU1Bs?= =?utf-8?B?UU1YNUJ3eFVYOHBOaVdhZ053akphKzBDWEtST3AzdENXcG1TUHFyak94TzBX?= =?utf-8?B?ZU4xTXBwQjZQbjB0T056aGVPQzV3WDRqVlFHdi9VQnJma3pEOVhDazJBeVJj?= =?utf-8?B?cm1oc0Q3cVRSSk5oZ3hoR041eHZQdmxRU0VOK3NCYTRSMmE4MHdPNGNORklT?= =?utf-8?B?R0x5YjBKVnlTbkJIekVKY28wc2wzamlJbWp0SFFQVWRVcVpuajczQWNyNGIw?= =?utf-8?B?ZDZTNFJ4b1Y3YWdxenplaHNIWnZadEJGY3VzUjY1UG00azRxQWUrWXFVeWE3?= =?utf-8?B?dWUwY0xhcjJHdjIyVDJVV3Y4OU11eVYwbWtuRjI0UWhMYlpwY3daN0llUldh?= =?utf-8?B?YWRFaEpSaFdvMm9TemIyeHBSeVBBTWxwOGl1NkFOZVBQSmdJUG02RmY1YzJs?= =?utf-8?B?YkVKZStsRWNYdkRrSE1UakVxelR5N2FJVGhTR3F6VmZXWEdSQmRBTGNPa0x6?= =?utf-8?B?WW5lQWpkaHZhcjd2a21zdnFDWmdMY2NqT2NmOUtkZXcvRlhHdU8wcmpXcmhy?= =?utf-8?B?bXhtTGVQd3J2YVVRQnArem1WQVk3cmdTTEJicWR6cHdxOGk1OVpSVFdHc3NC?= =?utf-8?B?TDZGdVVzVUlsS3FjdFlHUWpMUEtyQ3RMdjBUOExIUkZ4MjJJT0FSRkRPWmpS?= =?utf-8?B?YWQwNERTaE9lNnJVTkdVelVlcmhFVEZ0ODNva1haVzNBWjgvaVVkR1c2SVE1?= =?utf-8?B?Y3g5eFhJVE55c0dTNktZNHp5cTl5RGdhL3VzR095eGdmTjNQNkhvVittcEZl?= =?utf-8?B?OFdZL0RreTQrY0tLK254ZzlrL2xwU1cyQXNEVVZUU29XRi9zZUVNdHRtMGFG?= =?utf-8?B?ZHY5QUprMlBOVnBZSjJxM3FrbkVOMk9VTGNIUXBqOXRySnNxc3hKcjhIb2sx?= =?utf-8?B?ZXptdWpsV3BVcmhETm5FNmFqbHlGS2hRMSt5QzBaVnd6T00vd2h4TlFyQllI?= =?utf-8?B?R1VIa3lNeHBvUDMzOVBaa1ZQM29mbU1EZWtjTnZ0UFI3TExTbUdzVit3Zk1M?= =?utf-8?B?R1NSMkhIV2h6VXgveURBL2N4YWh4UldueXNCTHdPWStjR0ZKUDJObWZwYWZG?= =?utf-8?B?bkhuNWc2NDN2NFQrTXU5Q3RHYXJ4U1NZQTM4NEtJVTNBc1duNEhhZ2R5SFpF?= =?utf-8?B?aUhGVXFaTjBKWThlQ1JQUUk0VWtiL2tyUzVjUFQvU2tzQldLOGs1ZmVuL0Y0?= =?utf-8?B?RS8zK05WVWdpUE5CcUhyYnhJTXM0VUwvYi9obHFoMmwxQlYwL3NhSVdNQmQy?= =?utf-8?B?Z3Y2NVV0UEZZREFPUCtJbytGNnByYnRuY1J5SUNWUUt1ZXdsaWJGNXJXM2Fq?= =?utf-8?B?QzhOWHNoWGJaa1prQWgzb2RmbDJhaEFLcElqTmRUeCtWSy91WnRjeFJMai9K?= =?utf-8?B?cU9JaEpiWXQ0QitreFVCc3pScng2SElOTEQ1YXJJSWwrNkRsSURFMDZ5V3BK?= =?utf-8?B?cnY2VDdkbjFEV3pIMFlmNUo3WHhyam1NSGIxRG9HQXA2MDczVXludnRUMmVa?= =?utf-8?B?QlhxK2wzZ3Y2ZDBKNTlwRkNtbVk5Wmtxd3F6SUtVOHpQYmtXWERBcHZBTEg5?= =?utf-8?B?d1EraHNVeVZ6SURtNlRQQS9pUS9tRGdwcGxROEIyNWhOLzFYU0lEUk5OR1BY?= =?utf-8?B?Qk5vRFd0UG5rSkFrRStjSzJkMEd2ajNlZ3NyS21sY3o0MFlUWGg0RExMSFZ6?= =?utf-8?B?SWd4ZW1HNzh2OVY3RGl4b3UybjZhKzdXZEhxZ28zQW5lb3JIR0dKTmpYVmRX?= =?utf-8?B?ZEYxQ2gzY3lvOW9tNEF5MkFMcSs0RFVpRm1CWlRncm1PZHg3TmJVZkNCUFFp?= =?utf-8?B?UW5VR1ZwaTJ5ZTk5a1BnMzlxczk4ZWJsZGhEcERsdHg1Q3JYMWk1M1RxSjFp?= =?utf-8?B?L1VkSktrdHpKOGppYlFERXo2VDNwVzRrL21SVFFoa1JKTElReFFrWHRrVVJW?= =?utf-8?B?eENubmMwZ1JLaUVLRG9LcWxwbXdlWFZYK3o5MlRiQVhjUUpFYWZFTDl4dmlC?= =?utf-8?Q?bnWdO4WLLqOMYTVCh4l9tk8yfxSa/VITxHaCQ?= Content-Type: multipart/alternative; boundary="_000_26C2A079E3734C4288B01375F7CAB9BEcitrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6539.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db3e0112-f0a6-41d8-2ede-08da38a50064 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 08:04:15.3515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 88dgKGxP6kyRpu/VmyaJVUrUIuenxeqk89iQGkQe8NH+96ODCJpNRbIqyKQuNVaEPdQQB9MwYaLdUIxQzNKksc16UzZdbM8q/INzN+e4Ud0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4849 --_000_26C2A079E3734C4288B01375F7CAB9BEcitrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 QWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbTxt YWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPj4NCg0KDQpPbiAxNyBNYXkgMjAyMiwg YXQgMjA6NDEsIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb208bWFpbHRv OmFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+PiB3cm90ZToNCg0KU2FkbHksIGNwdXBvb2wgSURz IGFyZSBjaG9zZW4gYnkgdGhlIGNhbGxlciwgbm90IGFzc2lnbmVkIHNlcXVlbnRpYWxseSwgc28N CnRoaXMgZG9lcyBuZWVkIHRvIGhhdmUgYSBmdWxsIDMyIGJpdHMgb2YgcmFuZ2UuDQoNCkFsc28g bGVhdmUgYSBCVUlMRF9CVUdfT04oKSB0byBjYXRjaCBtb3JlIG9idmlvdXMgQUJJIGNoYW5nZXMg aW4gdGhlIGZ1dHVyZS4NCg0KRml4ZXM6IDkyZWE5YzU0ZmM4MSAoImFybS9kb20wbGVzczogYXNz aWduIGRvbTBsZXNzIGd1ZXN0cyB0byBjcHVwb29scyIpDQpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPG1haWx0bzphbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPj4NCi0tLQ0KQ0M6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdA Y2l0cml4LmNvbTxtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPj4NCkNDOiBFZHdp biBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPG1haWx0bzplZHZpbi50b3Jva0BjaXRy aXguY29tPj4NCkNDOiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb208bWFpbHRv Omx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4+DQotLS0NCnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3Ry bC5tbCAgICAgIHwgMSArDQp0b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpICAgICB8IDEg Kw0KdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMgfCA4ICsrKysrKystDQozIGZp bGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0 IGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94 ZW5jdHJsLm1sDQppbmRleCA3NTAzMDMxZDhmNjEuLjhlYWI2ZjYwZWIxNCAxMDA2NDQNCi0tLSBh L3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KKysrIGIvdG9vbHMvb2NhbWwvbGlicy94 Yy94ZW5jdHJsLm1sDQpAQCAtODUsNiArODUsNyBAQCB0eXBlIGRvbWN0bF9jcmVhdGVfY29uZmln ID0NCm1heF9ncmFudF9mcmFtZXM6IGludDsNCm1heF9tYXB0cmFja19mcmFtZXM6IGludDsNCm1h eF9ncmFudF92ZXJzaW9uOiBpbnQ7DQorIGNwdXBvb2xfaWQ6IGludDMyOw0KYXJjaDogYXJjaF9k b21haW5jb25maWc7DQp9DQoNCmRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0 cmwubWxpIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saQ0KaW5kZXggZDFkOWM5MjQ3 YWZjLi5kMzAxNGEyNzA4ZDggMTAwNjQ0DQotLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0 cmwubWxpDQorKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQpAQCAtNzcsNiAr NzcsNyBAQCB0eXBlIGRvbWN0bF9jcmVhdGVfY29uZmlnID0gew0KICBtYXhfZ3JhbnRfZnJhbWVz OiBpbnQ7DQogIG1heF9tYXB0cmFja19mcmFtZXM6IGludDsNCiAgbWF4X2dyYW50X3ZlcnNpb246 IGludDsNCisgIGNwdXBvb2xfaWQ6IGludDMyOw0KICBhcmNoOiBhcmNoX2RvbWFpbmNvbmZpZzsN Cn0NCg0KZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jIGIv dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCmluZGV4IDViNGZlNzJjOGRlYy4u NTEzZWUxNDJkMmEwIDEwMDY0NA0KLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0 dWJzLmMNCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQpAQCAtMTg5 LDcgKzE4OSw4IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfZG9tYWluX2NyZWF0ZSh2YWx1ZSB4 Y2gsIHZhbHVlIHdhbnRlZF9kb21pZCwgdmFsdWUgY29uZmlnDQojZGVmaW5lIFZBTF9NQVhfR1JB TlRfRlJBTUVTICAgIEZpZWxkKGNvbmZpZywgNikNCiNkZWZpbmUgVkFMX01BWF9NQVBUUkFDS19G UkFNRVMgRmllbGQoY29uZmlnLCA3KQ0KI2RlZmluZSBWQUxfTUFYX0dSQU5UX1ZFUlNJT04gICBG aWVsZChjb25maWcsIDgpDQotI2RlZmluZSBWQUxfQVJDSCAgICAgICAgICAgICAgICBGaWVsZChj b25maWcsIDkpDQorI2RlZmluZSBWQUxfQ1BVUE9PTF9JRCAgICAgICAgICBGaWVsZChjb25maWcs IDkpDQorI2RlZmluZSBWQUxfQVJDSCAgICAgICAgICAgICAgICBGaWVsZChjb25maWcsIDEwKQ0K DQp1aW50MzJfdCBkb21pZCA9IEludF92YWwod2FudGVkX2RvbWlkKTsNCmludCByZXN1bHQ7DQpA QCAtMjAxLDYgKzIwMiw3IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfZG9tYWluX2NyZWF0ZSh2 YWx1ZSB4Y2gsIHZhbHVlIHdhbnRlZF9kb21pZCwgdmFsdWUgY29uZmlnDQoubWF4X21hcHRyYWNr X2ZyYW1lcyA9IEludF92YWwoVkFMX01BWF9NQVBUUkFDS19GUkFNRVMpLA0KLmdyYW50X29wdHMg PQ0KICAgWEVOX0RPTUNUTF9HUkFOVF92ZXJzaW9uKEludF92YWwoVkFMX01BWF9HUkFOVF9WRVJT SU9OKSksDQorIC5jcHVwb29sX2lkID0gSW50MzJfdmFsKFZBTF9DUFVQT09MX0lEKSwNCn07DQoN CmRvbWFpbl9oYW5kbGVfb2ZfdXVpZF9zdHJpbmcoY2ZnLmhhbmRsZSwgU3RyaW5nX3ZhbChWQUxf SEFORExFKSk7DQpAQCAtMjI1LDYgKzIyNyw5IEBAIENBTUxwcmltIHZhbHVlIHN0dWJfeGNfZG9t YWluX2NyZWF0ZSh2YWx1ZSB4Y2gsIHZhbHVlIHdhbnRlZF9kb21pZCwgdmFsdWUgY29uZmlnDQpj YXNlIDE6IC8qIFg4NiAtIGVtdWxhdGlvbiBmbGFncyBpbiB0aGUgYmxvY2sgKi8NCiNpZiBkZWZp bmVkKF9faTM4Nl9fKSB8fCBkZWZpbmVkKF9feDg2XzY0X18pDQoNCisgLyogUXVpY2sgJiBkaXJ0 eSBjaGVjayBmb3IgQUJJIGNoYW5nZXMuICovDQorIEJVSUxEX0JVR19PTihzaXplb2YoY2ZnKSAh PSA2NCk7DQorDQogICAgICAgIC8qIE1uZW1vbmljcyBmb3IgdGhlIG5hbWVkIGZpZWxkcyBpbnNp ZGUgeGVuX3g4Nl9hcmNoX2RvbWFpbmNvbmZpZyAqLw0KI2RlZmluZSBWQUxfRU1VTF9GTEFHUyAg ICAgICAgICBGaWVsZChhcmNoX2RvbWNvbmZpZywgMCkNCg0KQEAgLTI1NCw2ICsyNTksNyBAQCBD QU1McHJpbSB2YWx1ZSBzdHViX3hjX2RvbWFpbl9jcmVhdGUodmFsdWUgeGNoLCB2YWx1ZSB3YW50 ZWRfZG9taWQsIHZhbHVlIGNvbmZpZw0KfQ0KDQojdW5kZWYgVkFMX0FSQ0gNCisjdW5kZWYgVkFM X0NQVVBPT0xfSUQNCiN1bmRlZiBWQUxfTUFYX0dSQU5UX1ZFUlNJT04NCiN1bmRlZiBWQUxfTUFY X01BUFRSQUNLX0ZSQU1FUw0KI3VuZGVmIFZBTF9NQVhfR1JBTlRfRlJBTUVTDQotLQ0KMi4xMS4w DQoNCg0K --_000_26C2A079E3734C4288B01375F7CAB9BEcitrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <33A84D7BC7827941B915D0728105B21C@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxkaXYgc3R5bGU9Im1hcmdpbjogMHB4OyBmb250 LXN0cmV0Y2g6IG5vcm1hbDsgZm9udC1zaXplOiAxMXB4OyBsaW5lLWhlaWdodDogbm9ybWFsOyBm b250LWZhbWlseTogTWVubG87IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQt bGlnYXR1cmVzOiBuby1jb21tb24tbGlnYXR1cmVzIiBjbGFzcz0iIj5BY2tlZC1ieTogQ2hyaXN0 aWFuIExpbmRpZyAmbHQ7PGEgaHJlZj0ibWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNv bSIgY2xhc3M9IiI+Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPC9hPiZndDs8L3NwYW4+PC9k aXY+DQo8ZGl2IGNsYXNzPSIiPjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBu by1jb21tb24tbGlnYXR1cmVzIiBjbGFzcz0iIj48YnIgY2xhc3M9IiI+DQo8L3NwYW4+PC9kaXY+ DQo8ZGl2PjxiciBjbGFzcz0iIj4NCjxibG9ja3F1b3RlIHR5cGU9ImNpdGUiIGNsYXNzPSIiPg0K PGRpdiBjbGFzcz0iIj5PbiAxNyBNYXkgMjAyMiwgYXQgMjA6NDEsIEFuZHJldyBDb29wZXIgJmx0 OzxhIGhyZWY9Im1haWx0bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tIiBjbGFzcz0iIj5hbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPC9hPiZndDsgd3JvdGU6PC9kaXY+DQo8YnIgY2xhc3M9IkFw cGxlLWludGVyY2hhbmdlLW5ld2xpbmUiPg0KPGRpdiBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+ U2FkbHksIGNwdXBvb2wgSURzIGFyZSBjaG9zZW4gYnkgdGhlIGNhbGxlciwgbm90IGFzc2lnbmVk IHNlcXVlbnRpYWxseSwgc288YnIgY2xhc3M9IiI+DQp0aGlzIGRvZXMgbmVlZCB0byBoYXZlIGEg ZnVsbCAzMiBiaXRzIG9mIHJhbmdlLjxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCkFsc28g bGVhdmUgYSBCVUlMRF9CVUdfT04oKSB0byBjYXRjaCBtb3JlIG9idmlvdXMgQUJJIGNoYW5nZXMg aW4gdGhlIGZ1dHVyZS48YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQpGaXhlczogOTJlYTlj NTRmYzgxICgmcXVvdDthcm0vZG9tMGxlc3M6IGFzc2lnbiBkb20wbGVzcyBndWVzdHMgdG8gY3B1 cG9vbHMmcXVvdDspPGJyIGNsYXNzPSIiPg0KU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciAm bHQ7PGEgaHJlZj0ibWFpbHRvOmFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20iIGNsYXNzPSIiPmFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb208L2E+Jmd0OzxiciBjbGFzcz0iIj4NCi0tLTxiciBjbGFz cz0iIj4NCkNDOiBDaHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFu LmxpbmRpZ0BjaXRyaXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208 L2E+Jmd0OzxiciBjbGFzcz0iIj4NCkNDOiBFZHdpbiBUw7Zyw7ZrICZsdDs8YSBocmVmPSJtYWls dG86ZWR2aW4udG9yb2tAY2l0cml4LmNvbSIgY2xhc3M9IiI+ZWR2aW4udG9yb2tAY2l0cml4LmNv bTwvYT4mZ3Q7PGJyIGNsYXNzPSIiPg0KQ0M6IEx1Y2EgRmFuY2VsbHUgJmx0OzxhIGhyZWY9Im1h aWx0bzpsdWNhLmZhbmNlbGx1QGFybS5jb20iIGNsYXNzPSIiPmx1Y2EuZmFuY2VsbHVAYXJtLmNv bTwvYT4mZ3Q7PGJyIGNsYXNzPSIiPg0KLS0tPGJyIGNsYXNzPSIiPg0KdG9vbHMvb2NhbWwvbGli cy94Yy94ZW5jdHJsLm1sICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3wgMSArPGJyIGNs YXNzPSIiPg0KdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDt8IDEgKzxiciBjbGFzcz0iIj4NCnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9z dHVicy5jIHwgOCArKysrKysrLTxiciBjbGFzcz0iIj4NCjMgZmlsZXMgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pPGJyIGNsYXNzPSIiPg0KPGJyIGNsYXNzPSIiPg0KZGlm ZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbCBiL3Rvb2xzL29jYW1sL2xp YnMveGMveGVuY3RybC5tbDxiciBjbGFzcz0iIj4NCmluZGV4IDc1MDMwMzFkOGY2MS4uOGVhYjZm NjBlYjE0IDEwMDY0NDxiciBjbGFzcz0iIj4NCi0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVu Y3RybC5tbDxiciBjbGFzcz0iIj4NCisrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5t bDxiciBjbGFzcz0iIj4NCkBAIC04NSw2ICs4NSw3IEBAIHR5cGUgZG9tY3RsX2NyZWF0ZV9jb25m aWcgPTxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9Indo aXRlLXNwYWNlOnByZSI+PC9zcGFuPm1heF9ncmFudF9mcmFtZXM6IGludDs8YnIgY2xhc3M9IiI+ DQo8c3BhbiBjbGFzcz0iQXBwbGUtdGFiLXNwYW4iIHN0eWxlPSJ3aGl0ZS1zcGFjZTpwcmUiPjwv c3Bhbj5tYXhfbWFwdHJhY2tfZnJhbWVzOiBpbnQ7PGJyIGNsYXNzPSIiPg0KPHNwYW4gY2xhc3M9 IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIj48L3NwYW4+bWF4X2dyYW50 X3ZlcnNpb246IGludDs8YnIgY2xhc3M9IiI+DQorPHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFu IiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIj4gPC9zcGFuPmNwdXBvb2xfaWQ6IGludDMyOzxiciBj bGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNl OnByZSI+PC9zcGFuPmFyY2g6IGFyY2hfZG9tYWluY29uZmlnOzxiciBjbGFzcz0iIj4NCn08YnIg Y2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQpkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94 Yy94ZW5jdHJsLm1saSBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGk8YnIgY2xhc3M9 IiI+DQppbmRleCBkMWQ5YzkyNDdhZmMuLmQzMDE0YTI3MDhkOCAxMDA2NDQ8YnIgY2xhc3M9IiI+ DQotLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpPGJyIGNsYXNzPSIiPg0KKysr IGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saTxiciBjbGFzcz0iIj4NCkBAIC03Nyw2 ICs3Nyw3IEBAIHR5cGUgZG9tY3RsX2NyZWF0ZV9jb25maWcgPSB7PGJyIGNsYXNzPSIiPg0KJm5i c3A7Jm5ic3A7bWF4X2dyYW50X2ZyYW1lczogaW50OzxiciBjbGFzcz0iIj4NCiZuYnNwOyZuYnNw O21heF9tYXB0cmFja19mcmFtZXM6IGludDs8YnIgY2xhc3M9IiI+DQombmJzcDsmbmJzcDttYXhf Z3JhbnRfdmVyc2lvbjogaW50OzxiciBjbGFzcz0iIj4NCisgJm5ic3A7Y3B1cG9vbF9pZDogaW50 MzI7PGJyIGNsYXNzPSIiPg0KJm5ic3A7Jm5ic3A7YXJjaDogYXJjaF9kb21haW5jb25maWc7PGJy IGNsYXNzPSIiPg0KfTxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCmRpZmYgLS1naXQgYS90 b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyBiL3Rvb2xzL29jYW1sL2xpYnMveGMv eGVuY3RybF9zdHVicy5jPGJyIGNsYXNzPSIiPg0KaW5kZXggNWI0ZmU3MmM4ZGVjLi41MTNlZTE0 MmQyYTAgMTAwNjQ0PGJyIGNsYXNzPSIiPg0KLS0tIGEvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j dHJsX3N0dWJzLmM8YnIgY2xhc3M9IiI+DQorKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0 cmxfc3R1YnMuYzxiciBjbGFzcz0iIj4NCkBAIC0xODksNyArMTg5LDggQEAgQ0FNTHByaW0gdmFs dWUgc3R1Yl94Y19kb21haW5fY3JlYXRlKHZhbHVlIHhjaCwgdmFsdWUgd2FudGVkX2RvbWlkLCB2 YWx1ZSBjb25maWc8YnIgY2xhc3M9IiI+DQojZGVmaW5lIFZBTF9NQVhfR1JBTlRfRlJBTUVTICZu YnNwOyZuYnNwOyZuYnNwO0ZpZWxkKGNvbmZpZywgNik8YnIgY2xhc3M9IiI+DQojZGVmaW5lIFZB TF9NQVhfTUFQVFJBQ0tfRlJBTUVTIEZpZWxkKGNvbmZpZywgNyk8YnIgY2xhc3M9IiI+DQojZGVm aW5lIFZBTF9NQVhfR1JBTlRfVkVSU0lPTiAmbmJzcDsmbmJzcDtGaWVsZChjb25maWcsIDgpPGJy IGNsYXNzPSIiPg0KLSNkZWZpbmUgVkFMX0FSQ0ggJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7RmllbGQoY29uZmlnLCA5KTxiciBjbGFzcz0iIj4NCisjZGVmaW5lIFZBTF9DUFVQT09M X0lEICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw O0ZpZWxkKGNvbmZpZywgOSk8YnIgY2xhc3M9IiI+DQorI2RlZmluZSBWQUxfQVJDSCAmbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtGaWVsZChjb25maWcsIDEwKTxiciBjbGFzcz0iIj4N CjxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRl LXNwYWNlOnByZSI+PC9zcGFuPnVpbnQzMl90IGRvbWlkID0gSW50X3ZhbCh3YW50ZWRfZG9taWQp OzxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRl LXNwYWNlOnByZSI+PC9zcGFuPmludCByZXN1bHQ7PGJyIGNsYXNzPSIiPg0KQEAgLTIwMSw2ICsy MDIsNyBAQCBDQU1McHJpbSB2YWx1ZSBzdHViX3hjX2RvbWFpbl9jcmVhdGUodmFsdWUgeGNoLCB2 YWx1ZSB3YW50ZWRfZG9taWQsIHZhbHVlIGNvbmZpZzxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNz PSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPjxzcGFuIGNs YXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPi5tYXhf bWFwdHJhY2tfZnJhbWVzID0gSW50X3ZhbChWQUxfTUFYX01BUFRSQUNLX0ZSQU1FUyksPGJyIGNs YXNzPSIiPg0KPHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6 cHJlIj48L3NwYW4+PHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3Bh Y2U6cHJlIj48L3NwYW4+LmdyYW50X29wdHMgPTxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJB cHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPjxzcGFuIGNsYXNz PSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPiZuYnNwOyZu YnNwOyZuYnNwO1hFTl9ET01DVExfR1JBTlRfdmVyc2lvbihJbnRfdmFsKFZBTF9NQVhfR1JBTlRf VkVSU0lPTikpLDxiciBjbGFzcz0iIj4NCis8c3BhbiBjbGFzcz0iQXBwbGUtdGFiLXNwYW4iIHN0 eWxlPSJ3aGl0ZS1zcGFjZTpwcmUiPiA8L3NwYW4+PHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFu IiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIj48L3NwYW4+LmNwdXBvb2xfaWQgPSBJbnQzMl92YWwo VkFMX0NQVVBPT0xfSUQpLDxiciBjbGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3Bh biIgc3R5bGU9IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPn07PGJyIGNsYXNzPSIiPg0KPGJyIGNs YXNzPSIiPg0KPHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6 cHJlIj48L3NwYW4+ZG9tYWluX2hhbmRsZV9vZl91dWlkX3N0cmluZyhjZmcuaGFuZGxlLCBTdHJp bmdfdmFsKFZBTF9IQU5ETEUpKTs8YnIgY2xhc3M9IiI+DQpAQCAtMjI1LDYgKzIyNyw5IEBAIENB TUxwcmltIHZhbHVlIHN0dWJfeGNfZG9tYWluX2NyZWF0ZSh2YWx1ZSB4Y2gsIHZhbHVlIHdhbnRl ZF9kb21pZCwgdmFsdWUgY29uZmlnPGJyIGNsYXNzPSIiPg0KPHNwYW4gY2xhc3M9IkFwcGxlLXRh Yi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlIj48L3NwYW4+Y2FzZSAxOiAvKiBYODYgLSBl bXVsYXRpb24gZmxhZ3MgaW4gdGhlIGJsb2NrICovPGJyIGNsYXNzPSIiPg0KI2lmIGRlZmluZWQo X19pMzg2X18pIHx8IGRlZmluZWQoX194ODZfNjRfXyk8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9 IiI+DQorPHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hpdGUtc3BhY2U6cHJl Ij4gPC9zcGFuPjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNl OnByZSI+PC9zcGFuPi8qIFF1aWNrICZhbXA7IGRpcnR5IGNoZWNrIGZvciBBQkkgY2hhbmdlcy4g Ki88YnIgY2xhc3M9IiI+DQorPHNwYW4gY2xhc3M9IkFwcGxlLXRhYi1zcGFuIiBzdHlsZT0id2hp dGUtc3BhY2U6cHJlIj4gPC9zcGFuPjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9 IndoaXRlLXNwYWNlOnByZSI+PC9zcGFuPkJVSUxEX0JVR19PTihzaXplb2YoY2ZnKSAhPSA2NCk7 PGJyIGNsYXNzPSIiPg0KKzxiciBjbGFzcz0iIj4NCiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOy8qIE1uZW1vbmljcyBmb3IgdGhlIG5hbWVkIGZpZWxkcyBp bnNpZGUgeGVuX3g4Nl9hcmNoX2RvbWFpbmNvbmZpZyAqLzxiciBjbGFzcz0iIj4NCiNkZWZpbmUg VkFMX0VNVUxfRkxBR1MgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7RmllbGQoYXJjaF9kb21jb25maWcsIDApPGJyIGNsYXNzPSIiPg0KPGJyIGNs YXNzPSIiPg0KQEAgLTI1NCw2ICsyNTksNyBAQCBDQU1McHJpbSB2YWx1ZSBzdHViX3hjX2RvbWFp bl9jcmVhdGUodmFsdWUgeGNoLCB2YWx1ZSB3YW50ZWRfZG9taWQsIHZhbHVlIGNvbmZpZzxiciBj bGFzcz0iIj4NCjxzcGFuIGNsYXNzPSJBcHBsZS10YWItc3BhbiIgc3R5bGU9IndoaXRlLXNwYWNl OnByZSI+PC9zcGFuPn08YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQojdW5kZWYgVkFMX0FS Q0g8YnIgY2xhc3M9IiI+DQorI3VuZGVmIFZBTF9DUFVQT09MX0lEPGJyIGNsYXNzPSIiPg0KI3Vu ZGVmIFZBTF9NQVhfR1JBTlRfVkVSU0lPTjxiciBjbGFzcz0iIj4NCiN1bmRlZiBWQUxfTUFYX01B UFRSQUNLX0ZSQU1FUzxiciBjbGFzcz0iIj4NCiN1bmRlZiBWQUxfTUFYX0dSQU5UX0ZSQU1FUzxi ciBjbGFzcz0iIj4NCi0tIDxiciBjbGFzcz0iIj4NCjIuMTEuMDxiciBjbGFzcz0iIj4NCjxiciBj bGFzcz0iIj4NCjwvZGl2Pg0KPC9kaXY+DQo8L2Jsb2NrcXVvdGU+DQo8L2Rpdj4NCjxiciBjbGFz cz0iIj4NCjwvYm9keT4NCjwvaHRtbD4NCg== --_000_26C2A079E3734C4288B01375F7CAB9BEcitrixcom_-- From xen-devel-bounces@lists.xenproject.org Wed May 18 08:32:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 08:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331749.555315 (Exim 4.92) (envelope-from ) id 1nrF6e-0002g7-An; Wed, 18 May 2022 08:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331749.555315; Wed, 18 May 2022 08:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrF6e-0002g0-7H; Wed, 18 May 2022 08:32:32 +0000 Received: by outflank-mailman (input) for mailman id 331749; Wed, 18 May 2022 08:32:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrF6c-0002fq-VN; Wed, 18 May 2022 08:32:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrF6c-000067-LZ; Wed, 18 May 2022 08:32:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrF6c-0003Fn-5H; Wed, 18 May 2022 08:32:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrF6c-0007KN-4o; Wed, 18 May 2022 08:32:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vxirhLNotP6VQpWxy2PZRv8U6Y/2aBtfCYH91bXHTqk=; b=In/1BYg91vSXc6NJuS0X8xxEAM zYbTt8GsBHK2cdSRg7wXJoNfBhv075zJ2EGqsGuMFqa+d9Q0j7ADzbfpuvwrTCpFtWZ5XcEHdGw1s hesUvgJricVZs0Oy8X2xyEL2Ygmi6ER/yyrzNAiRrsuElDS3X3XvSRjz2/aAx6wX/VqQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170523: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=210e04ff768142b96452030c4c2627512b30ad95 X-Osstest-Versions-That: linux=42226c989789d8da4af1de0c31070c96726d990c From: osstest service owner Date: Wed, 18 May 2022 08:32:30 +0000 flight 170523 linux-linus real [real] flight 170530 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170523/ http://logs.test-lab.xenproject.org/osstest/logs/170530/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 170530-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 170530 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 170530 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170472 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170472 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170472 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170472 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170472 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170472 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170472 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170472 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 210e04ff768142b96452030c4c2627512b30ad95 baseline version: linux 42226c989789d8da4af1de0c31070c96726d990c Last test of basis 170472 2022-05-16 05:17:50 Z 2 days Testing same since 170523 2022-05-18 00:11:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bjorn Andersson Bjorn Helgaas Linus Torvalds Pali Rohár Rafael J. Wysocki Srinivas Pandruvada Stanimir Varbanov Steev Klimaszewski jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 42226c989789..210e04ff7681 210e04ff768142b96452030c4c2627512b30ad95 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed May 18 08:49:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 08:49:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331759.555326 (Exim 4.92) (envelope-from ) id 1nrFN6-0004QN-Q1; Wed, 18 May 2022 08:49:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331759.555326; Wed, 18 May 2022 08:49:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFN6-0004QG-Mg; Wed, 18 May 2022 08:49:32 +0000 Received: by outflank-mailman (input) for mailman id 331759; Wed, 18 May 2022 08:49:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFN5-0004QA-5k for xen-devel@lists.xenproject.org; Wed, 18 May 2022 08:49:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6dc4ac87-d687-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 10:49:29 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-pL_iVOqPNTuFGjDRDw9GvQ-1; Wed, 18 May 2022 10:49:25 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3144.eurprd04.prod.outlook.com (2603:10a6:6:f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 08:49:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 08:49:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dc4ac87-d687-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652863769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZuqxjQFW6dzwz5YDCHXMLasPk9MsOfkJ0ZHTIOeRjk=; b=E0zuryUlyryRGG5IlEl/+8gEnbV9mMe3cZoHDwkpUw/iJjtnWlS0L09hTb1wZQNfDVsklh Jq5FoPwMd9u76Y0GhJGSEEUzenmR337XZK1YrMUCvjSImcOgl/5wSNUvdL1cRHB5x1QLCn cjVWqRY+9kK2gEkfT8Y6VfJRRTxRI9o= X-MC-Unique: pL_iVOqPNTuFGjDRDw9GvQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTDZARfsCtNf/ZiuTNkw0I83VIFC8hi00Hx7t2qSURSYe/lJPykRIwKg5gqb7qdUCdLaHxo2rewLvYl4vuZX+RISPiGJhU7BS2NQ+trrw0bgAOIUq3wyK229M/GOZ/Mc//Rc1oZxBdVzJwSD9RpDB0yJdBl2KGj/KkdnJYivlK4W4CcZcRuhUVnTII+n+3fjjTkUPD6TKn/oYQzri5Pv9NFb8a5TSYoYMiDdDV0cgqXiKW8rxcRDPKIRpwOpEauORCnSmpcSFkcogiu8mEId69fWJ1VBLNOrzBad1r73uXxflg0Xl2Wj7S9M3TLnBN2W06Vv5xAnJJPBqMGXTclUXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZuqxjQFW6dzwz5YDCHXMLasPk9MsOfkJ0ZHTIOeRjk=; b=Eqxta5624khUXXv+6Dass3sxlktLQAN7HSOlwhDNnWX8CP0BE+DrZgfsfxdZVOKXQf5bntUuCZsw9en9SDd10V1ubMo/LQMVmWntSif7mBfKB8ZZEOYYEbUjIEKb7N/CPrjpJqYDJ3VfhJ5p+AYdkzt4BFA2B0hzYmh1fwUmCb7JiUY9qrhLP0x9UaShoeZ0E35v+ZFBonqKTKmqTMGNPhG4TVatkiF2/MJCBlXORcRlWD3wRGEFYCrAgwYylNkRK1oWMiAXa31u8VH0YD2Tf/Oa807BUiuocz6ZCe49XZkkmsozf0le20D75IBIPYaNv8f9IoQ9noieFY0JFc9kAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 10:49:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220516143116.28602-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220516143116.28602-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:20b:6e::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f469ccc5-cd3e-4601-6b9f-08da38ab4ed9 X-MS-TrafficTypeDiagnostic: DB6PR04MB3144:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GUxoI5Xn0ut1wsDpCpkT0eY5xz1iZ3XGtePqd/iNQD9WZZA6OyHDnOFGUWMuNpMIITiqmgfh1zfjdPA+ZD8Ix6pKdkPSdAXMjDMeU0eBYTMlQ8D4Mmz7Lv7NJtjNWozq0UYy+pjVlFQrHSUtU3V4ersuYPQv3qINSa6flg1uxlyfRXaVnqA4H4tA+sxlK9Y5g51vCVFvMR8wGMR16DIPNwA+JgSA19wyRpY7/4W+huJxkj1MfMeJgqYScB1Uk3pjkGTJZXQtu/xOBtRp5kmXZ0juqA/Pcsud9QShgbOnlu5uNWChKjNfMrbd24wFwHIZ4qQqtoY4zxD3+A9VVkiUWsQ24ahYhVGX7rJ21tHeHp8ALDfxO8DMPUz3r4xJRCUw8HqVoU8Rdy2DKJJxYraIIYisBq0jpMc2pEsYzLVMoNrGXrOYWjJHpRvVLpDJje3nycHUaOi2OOuNDq9pBG7YXRWVu3YfqHW7G9OzvreeLXZyjqIDrakhYL+8m6NiHGSqOXoN6RTPq1Qi8tr7/eGo1yhNqdvb7TCzlqGlLhl0V0lWalkSqNZVt3ghwWJvKcYTkO+SbbDCbEswujy/0dUjWlMcYcPuGmfcTUpOG5Ocg8PcWAlAxF+NRSuhNRCk42lJuBLQURMiLL7nr/Vjf6VlgjeY6Ml/qrE2skw4oq7EPw6WyNOo6AgwPn3djRdn7yM7klT7qeuZZnyjR6fKV+KNBOgASRsX+OLAlxV5RTGFDNw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(186003)(2616005)(5660300002)(26005)(6512007)(86362001)(66476007)(66556008)(66946007)(83380400001)(6486002)(54906003)(6916009)(4326008)(508600001)(6506007)(53546011)(8676002)(316002)(38100700002)(36756003)(31686004)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlZoRU1DWmd1WnZ0aXpydTJlV0pLcU55ZEdmRmFvVjFIbTBDcUppTlJ3NjRo?= =?utf-8?B?Vm9Zei9Mc1JkdG9sTWJZY3AxaDFMU2VIZHloNHkvNkM1bUp0UXNsa2hNclhI?= =?utf-8?B?cjZDbWM4VUhsdVdoazJJUDZQa085TE1XMnBaYm9IaFRVeXJMQlpMSms5aUVY?= =?utf-8?B?VTUveElpQTBrN2NucTdzVHdxU3dGdTdaZC84MHdRZjd3REMydGt4emQvMGs2?= =?utf-8?B?TnZFd0UrNWU4akVwbW1jUS9oRGhVcDRxNEI3cEQ2WVZ4VHl2Z3BkNmRiUHNW?= =?utf-8?B?bkdjRHB4VzN1RzgzL1JTQ1RUM05pQVh0b1o1NEhVUzhKczBIbkUwZFBtNzRV?= =?utf-8?B?Z3B5ZW00TEJuVXVXYnpxODJCS2pyVXVUK3U3N21NUUFUbWZmTVg3aGMwNnNn?= =?utf-8?B?N3BtTmVaNlpYM2xnckc2S0VDa0tqY0o5SGhXd3NMS2VmMmZEeU9ucXBaUExs?= =?utf-8?B?cGFzaU14cldKR0xFQm40b2hoZ1Y1Y3FML29Mc0U1WW1hdGZJdFNKV0Z2eVRR?= =?utf-8?B?U1N2a1hDWG5xTHIrRVJsbDg0cmo5TGxvcldTQTBHTXJEQVZQbHJHZW1tR3hM?= =?utf-8?B?Mks3ZTlzUXNEQWlBRmE5VEJTWStOWEkwSEROUWYyTklvVzVWZTdPb2ZMdStQ?= =?utf-8?B?eEJ5WGtDOHhqbWRqR3RYUVpmOGg3VEEwcCtGTnBQLzB4SWlRTFhhM2VCbllB?= =?utf-8?B?N1p5UE1LMVFYbzNZT2VEQ3I1cWt1TzRDUHlzK3RYS3U4RTI1Skx2NnRxejlF?= =?utf-8?B?Y1pLa0tjUExPbE54OU5KUXFZMHNpL2xyb2pXMEVWZkIrQUwvVDVqeDJZZHRo?= =?utf-8?B?RzdWb09nY21jK2FCQ1MrWUY4aVNERGhPcFp1L3grRFJqY0luWVU0b3I1NThn?= =?utf-8?B?aFBEaGVZaWVFWGxLN2pYUVRtM3hXblRkWEYvUUNHOTVBRERELzhobFVCK1hX?= =?utf-8?B?QVdMYjhFelB3VzVyZExKVUFoaHpaR05vODl5c1Bsajdod25HOUNHRXFyNGJL?= =?utf-8?B?SkJ1RGRZRi9RZmUxMVdHZ2hLUDhpQ0w5UUhEeCtkL2FqTTYxUzNWZU43dm9R?= =?utf-8?B?VSs4UkJnclphUjRQRjdKeFlQS0RQdXJSU2Y3V21aTytUQkNEUFFCYmk0T3FD?= =?utf-8?B?VjNnZGdQbHpPTXVaNWRmd05lQmdhZGdEenNUOGFNcVBpTmFPOHFUTTJvdVNQ?= =?utf-8?B?aFBpMmM0azV1NzF4U1pPcklMY3ZPTU9venhiaEs2aVdpcFVkRjNPUXpGVnpy?= =?utf-8?B?UDNHcVN3T0JOWjBIMWFaTk90b094dnRrODYrZlNRTllrKzVaVlZiSnhqbmk1?= =?utf-8?B?QTAzL2txUDh2NVE2YzhWVk1STWtDVmtqUGV5TWFFV2tlOEJPTUlXRml4ZHdn?= =?utf-8?B?RitYbzk0d0VoTEE3SloxRFRxRW42a3RORUVUZHk2NnhGQm1zNlJvbUY1K2ov?= =?utf-8?B?cXpKUytPWElkV1I1YzZQWlo3b2FncUVzdksvM0xIbUsxRFB1Z0lQRzh1cGFn?= =?utf-8?B?NFhaMi84Y1BpZjBHZHpoZjFnalErZkFRUlVsRmZ5QkNIdUk2ZkZhSmNRRk5k?= =?utf-8?B?dVdCTW9mL0RTYldDL1Q0djZyQW5QZUhYMk1YVHFPWmJWK0loNHVzaVdJRm5o?= =?utf-8?B?SGkxbTNveWZ3TXpPMUJ5RDRYRTNlU0oydDV4bDhWek5DdkVFczEvNi9SMGRY?= =?utf-8?B?cDhnUVdkUTNCRytIcFFDZ0RPa2Nma1NxSWNTZjNBU3dCVkxGQ2dMTG82cWVF?= =?utf-8?B?aWQ4aHFtUThMSldvRjhTU0p4Sy8vaTFvMFlwMGRFdml2TC9reE5PeU8ycGR4?= =?utf-8?B?OWN6aHZqTTdoS0UvMWJodjJLdU9hSnBnNzlNdlRvOGNXZmNLQnFiVlBtVFNi?= =?utf-8?B?dTc1cW5wTzdwbHpBVWVTOVlaUWU4QlVMUWdaYTVpVG9ESHRyalJ2T21ZOXdi?= =?utf-8?B?VkEycy9FS1Z5SDNNMFdCOXJrdk9WU1UrQ21MZmZJUEVScnhmRWZBdzE5L0Rk?= =?utf-8?B?aGdIUUZ0c0NNTVdZdlJzYTV0dTNaWTZQTzVGeStobmxNRXpjblE3T3hzR1Bx?= =?utf-8?B?MGJDbFQvOFMrV1FVMXlXdFdrMVhRYnRnQnliTnJxekxyNjBVNFFtRGQwR2xh?= =?utf-8?B?Qnk5Q3JvRDBTVVRYU1dtOE91aVVhU1NXMVBpRzQvU3pGQkRPL3JvdWkxQWhz?= =?utf-8?B?RE45RFphU213ajJ5bWJWRHhSbnpRVlJqdUZHbGtDZHpPWk92OUNVcUo0TXJv?= =?utf-8?B?blRKKy8weDBjOGNqL0oyNjZBcGE2ZVdzSUNxdUZ0TGYxSE9pc2gySGg0ajRk?= =?utf-8?B?RFlSUm1Ia2tKVUdnVnViZUpzUlJhRTQ0NmFaV1lqUUpQd2N4NG00dz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f469ccc5-cd3e-4601-6b9f-08da38ab4ed9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 08:49:24.0874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pQ9rctCllJIOVj5yeZotREOWB8c96N8wz1R7ElKvQiVt7RX7M1uZzR319+30Z/14JYtxzZN9vF1y8AtW2rsDhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3144 On 16.05.2022 16:31, Roger Pau Monne wrote: > --- a/xen/arch/x86/include/asm/flushtlb.h > +++ b/xen/arch/x86/include/asm/flushtlb.h > @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); > #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) > > /* Flush all CPUs' TLBs/caches */ > -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) > +#define flush_area(va, flags) \ > + flush_area_mask(&cpu_online_map, (const void *)(va), flags) I have to admit that I would prefer if we kept the "_all" name suffix, to continue to clearly express the scope of the flush. I'm also not really happy to see the cast being added globally now. > --- a/xen/arch/x86/smp.c > +++ b/xen/arch/x86/smp.c > @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > { > unsigned int cpu = smp_processor_id(); > > - ASSERT(local_irq_is_enabled()); > + /* Local flushes can be performed with interrupts disabled. */ > + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); Further down we use cpumask_subset(mask, cpumask_of(cpu)), apparently to also cover the case where mask is empty. I think you want to do so here as well. > if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && > cpumask_test_cpu(cpu, mask) ) I suppose we want a further precaution here: Despite the !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to extend what c64bf2d2a625 ("x86: make CPU state flush requests explicit") and later changes (isolating uses of FLUSH_VCPU_STATE from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE for the local CPU altogether. That's because if such somehow made it into the conditional below here, it would still involve an IPI. E.g. ASSERT(local_irq_is_enabled() || (cpumask_subset(mask, cpumask_of(cpu)) && !(flags & FLUSH_VCPU_STATE))); Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:07:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331768.555336 (Exim 4.92) (envelope-from ) id 1nrFeY-00071Y-HU; Wed, 18 May 2022 09:07:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331768.555336; Wed, 18 May 2022 09:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFeY-00071Q-DB; Wed, 18 May 2022 09:07:34 +0000 Received: by outflank-mailman (input) for mailman id 331768; Wed, 18 May 2022 09:07:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFeW-00071K-9r for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:07:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f26891a5-d689-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 11:07:31 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-HKP8ZZlFPRaZPO0ZXBZXLQ-1; Wed, 18 May 2022 11:07:29 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6068.eurprd04.prod.outlook.com (2603:10a6:208:140::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 09:07:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:07:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f26891a5-d689-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652864850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6V79cr+/wNigRiUFictH26zhYiRXPF0TuxzZLJBHB6k=; b=bH7LstWjcLmU83p9Qo1wV9YVTVGE6Y7KA52qbLKtFNv1lNBWGEbWMZHN4BvBVBNWud9nNM UspEn12Srd+5gS2U1QtkQZiy0cW1D0GE8qhb+e/Vi9GGsyJPBkG18a1IOsq0CED5cFwyu1 hIzlVV/HpfHhOFomDWuywnt1vMKZgxM= X-MC-Unique: HKP8ZZlFPRaZPO0ZXBZXLQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeCCOgvqIU+o+TDhWbxuaphM1XDHG/TLestUivApHsBCLXWIFUfgjlhns9GGZhgQAESyscpQpQgY1NHsNIFaL18OjePONVGP6/UtX8YWFyUwl2XCLqM+nf5OQ4nFga5Hyzj3ns/t5w4vIeLkLubqPWIOunG5BEf9GgIp5WAPDipQpF53BvqaWPeGtd8w2RlO2r+bSL6GOSdNDiVX23nNsxRgUrenws/dfGUf5ILONCBB1865UM4YCwN4TLBI/FMf2ibhFgykbuvrrX9oLP8A+Z8apKddVIrgpnOMP5+pYnNWtt2Q8/0UpPMq0evxo5oip0sZlXF48nVxp7LaEud6dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6V79cr+/wNigRiUFictH26zhYiRXPF0TuxzZLJBHB6k=; b=H8oAnl9mQMgmL5+C6aOZKWTdGJ3vTDgSlsUcZ1tZLj7Bhp/NOzjNFGXc/rXGNImbGq78HY9OjBW0M2k92pmE0XRxXGP01o+NM4ALJhgKwwY61HBRtctk8ZJSO00acGgRoDQIOrPHagy9/G2YCE/zpmPNJmD/1H8AeuY9NaABldLj6fS1t2xkDA5h62mcdKi1PDnXjci4KczyiNn1DTBXipu+KeFLRUyKDzr495nvueTpcEIZFokXMWnHdJoqVwbwF2CCs5A4jwutXxErNazz2/p5/OyNlqdjNqqgBemJfg4p2S33r1dzz1mSp/D3JBJjDl7ftR3udbHl9ATt1hApEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <241a38af-65cb-a44b-4910-c1c310b7bfb0@suse.com> Date: Wed, 18 May 2022 11:07:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Content-Language: en-US To: Jane Malalane Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220511151423.20241-1-jane.malalane@citrix.com> From: Jan Beulich In-Reply-To: <20220511151423.20241-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0101.eurprd06.prod.outlook.com (2603:10a6:20b:465::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4025cf40-9384-48f0-5e5d-08da38add4a9 X-MS-TrafficTypeDiagnostic: AM0PR04MB6068:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ebbJOxuhIiabGBKt8vc/yxxRNIWSdNWENnLDLwYxr8JhFEC+L2L89JYf5QthGCoFuUt6MCl2U1I2qvpFxURZ5mi30il/hlgCBoIuDjT/7zohhf5khnWaGx7lsuw6yu1a7U6jucTm33uEaUgTPo/OwVmJksPtqqQRmBg6ojV+hQo0VCfKTn1Q7oyDHh+wKVm0SCSEbgVzPHgvGdNmo/1yxvt0yy4VvBzbfxnthvYP1NhZi8+0GGOVX96i5DfavxUyG0eaHFkbY53p6lXpqfYPhyun7fErlECguU2dVfUx10JtsuVbLfhj5r6a6kepAEbgC/ekQ796luBoDshuHX6TQEOII1KHIGO5zrdr3z9L+5lMuAOISuDB71kiRqYyiI00qYjBAf8/aWTQO3CHIsIRB23WX/87Wk7MovmPpJ8lFEmZk0W2Bfqz07D+4/y/SYN4yZozANBhFvfWdkpQplIK0DzLRYc7n0CWMlh7jyYxNoHcPHyTVdcOmP7lsFANOcFRerhHYUVumEU+jbVLP0slkGqp+0nUzaqQ0nnFjgoP9e3hmy1rs8fBZxrSHtmAVGFKkyWsddM89XJ71HoqC2ggyIdRZ6Sc5/nK3iqalAWcef1Yj9oxBCoqk8P8nYIL8RYQufYzikZrTTGWEPCIbQc3+OgVhbA28VbbM1jucPxnqztV/a34SnHusIejw5cmpJo9TQK4IK4Qlrakkwlfyhsdv5YAYADxa6hjIRKz6PIZIZvDPqfgP4oG319DOVS0NZL9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(4326008)(83380400001)(66556008)(66476007)(186003)(5660300002)(31686004)(6506007)(66946007)(36756003)(2906002)(53546011)(8936002)(6486002)(26005)(508600001)(2616005)(38100700002)(31696002)(86362001)(54906003)(6916009)(6512007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aW4yeENyQzBsSCt5QlF4Zzc0WHhXd2tnVWpNTHkwWEFGSG1RNnRYVUpQb2JH?= =?utf-8?B?eGR0WFlhQUFtdGRPNXZMYkFWVDhDZkVoditQQlQ0UEoyZm5obTRSUGcyWTUx?= =?utf-8?B?S0FXSis4blZEeUo0OVBDN0EvNlUwKzBQaUpCNmlmczRXbXYwc0tuRzFLOFFv?= =?utf-8?B?R3JCUXh0UnYyclRXVnIrQldGWk82WE9HNjljTk9EN1Qzb0NSMGZUN2FFalhO?= =?utf-8?B?V0g3QmxWV0NxRnF5SjlrdisrblBHTEkxUWNnRllGSVVRWDhXWFZxellodmMw?= =?utf-8?B?R1Iyb3R3SUZlbDUzb3Y4UWV0MTJmWVFDYSt5MG8rNTRUaStXeDRHck1xKzZW?= =?utf-8?B?OVd1dXoraVlKcVFZdmF2dW9jVW1tN3JPNTllY3hRWUh1TDBjcXZHL2VWOUk3?= =?utf-8?B?MCtvOHFrZmFmWUdIcC9ac290b253TnRjWDY0LzA3VEpza2htL2dhMmVaMmpm?= =?utf-8?B?ekpVK3Ztd21GUU1yQXl1dU9tUHF3SkpBbXhVb1Bzbi83dzJuanVPM3I3cGZ3?= =?utf-8?B?Q0ZxamN2c2ZMVFJTQXF0dEczWlFGeG4wMjdRU1k3d3ZlbHJpNU10NXhzTXFm?= =?utf-8?B?QjhtSmlNTmZPOXROdGZoZWl1b04zajBlRmlMWm1RaWwyNDhOcXdCVDJDWThN?= =?utf-8?B?SDdUZ2d2OHFSZVNHZ2JaUU1pNmVYeHBnYnMvTUZxMWVmZStTQjVNZlVWNC9y?= =?utf-8?B?a3NHQUpWR2tsOFRZU3lUNnFFN2tvVW5TSDhGcXFZVEFMTUp0TDcyRHp3U0Zy?= =?utf-8?B?cDlCMzRjekpwS2FzU0tNWkV0NFcyOFBvTGtSM3AzNmVjQVdxQkNMc3pGMFlF?= =?utf-8?B?cnZ5dlRmdE1JNTMwTnZwTDVaNngvYnQrc3JTQnZIem12aCtjQ1l0STFNU2x4?= =?utf-8?B?eVEvcUFPZVV0V2dkZ2NNZ2V2SmR3bWdoRFhSdndNU2FwNjBvSEJTMUQzY1RZ?= =?utf-8?B?NGR2SWo1UWRTQkxtbERDcmVuUEs0N3Z0Vk1OMEZYYTA2S2N3anNiUTVrdTFn?= =?utf-8?B?M282WHRZWFp6aTBQQVlLOFg4S3hwZjN3MjJ5TEJqSldnR3REeWE1OWRqRVVk?= =?utf-8?B?bkVyZ1o0T1g5dUpYcHhKSnpubTdCb1RMUDcwM3VWenFDM2NRNy8xY0VNaXVo?= =?utf-8?B?ZnlzWU1vMFRRZ01DUStFdklxeHpqUzB3d2NUanlXa2ZZUGtXY2RoK3dNSmtR?= =?utf-8?B?WTZMdlNMU1lwQk9ETE9UbXRRNUxXbjlJMXltVGN0MkRyM1kyY0hSaWs1VDRj?= =?utf-8?B?VXlTd3NxaHVBTFl2TzF6OGV6ZWN2MmEveHh1Y1YrUTA5RFo5dzFaVnhqbGJU?= =?utf-8?B?SERrTHV5cElQWlpmald2aEdSZmdtTmV3MGI3RlFuejBPT2loV0FZMW83cGNQ?= =?utf-8?B?OURtcUs3d1RFVXZ6Q0JoTGd4dVhiYlVzYzd5UVo3Q1hES0ZQTkdkc3VRa0JV?= =?utf-8?B?ZDZnSWxGS3RiWVV2QTNtMWE1dk5CTmtscENCVlhwUzZ5ZmFFVFRTRHZmL2Zw?= =?utf-8?B?bEV1dnMyZ1VzTmhGSjhqYzduZzVtemQ5ekMwNS9hS2t2QW9ScWgzaFRXL2JR?= =?utf-8?B?YzUvZFF3WkxpWWlGRlRIZHhTYnRpR3FpS1pSK3BhekFKM0ZLMnFJeHNVMjhG?= =?utf-8?B?Q1BIYlhOcnZZMDZERmxjVWZiOFdMeXVVdmIzVExrZkNLVXlLMktEYnNpQTd1?= =?utf-8?B?RXJEYis3YlZFQ3YyZ0p3NEMrT1ArWlNwYkc4Q0ZEMnJmYlRaOVB6N3VQTjJB?= =?utf-8?B?dnAvUXl1RERjQjUzNFAwOHppdURuL1l6STdmTXBoM1pZcU1hcUk0TWxBT2V3?= =?utf-8?B?YmlneVZNYmZkRWlUdmRkS20rL25ING1BUHJzVGZQSC8rRkhmemZLNXFGbVdJ?= =?utf-8?B?UHFLK1h1c0xmcW5HZTlPWWJBVmprK1ZoSTk4OU5RSzdzNk94NkRQSCtyVHpk?= =?utf-8?B?WSt5cTJBRmNxNEpodVUzYmJRWE9pbkdPaVJ6U0tHVGNoQnp5Mm1wK09TUFph?= =?utf-8?B?ekx5cWN4cVhzOTFac2NybkM5MWFTTEpWSS9CdFNRdkpEMWgvL1hpRnZLMk0v?= =?utf-8?B?RnlsRGFWY2ExSTVCL1lWb0JlT1pSZ3E0Y0RmK0dsYnNwd2NzTXc5S1FQZ1hQ?= =?utf-8?B?OE40RVJrbWJYWm9EMG5oa0dKdE54MjFJclhHM1lwYmNLMDJnOTh6U2Z5YURa?= =?utf-8?B?by9ZNjUyejhiZEVjSUw2RkhnSWZHNWkvdzJxV20wamRjR3VEcEJGREgxcThM?= =?utf-8?B?MlRYQ25qS0loQ09LSS9VTVpINERsWkYxTzVGdnBHM3pmbW4zTmpKNndiRk16?= =?utf-8?B?endhOFpJQ09wQzJodnBXVGpndWhZZDkzZlV4OTZCZjNBVCtkY3orUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4025cf40-9384-48f0-5e5d-08da38add4a9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:07:27.6119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BFRc8PMCpf4DcdnZ/wdt3f4Y5CLMvDOyo6DE2tCY4CHp/Jv4Po0Jt6i2OOraIk4OHeOzCWVSjdL/Lo2vVAsHUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6068 On 11.05.2022 17:14, Jane Malalane wrote: > Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for > evtchn delivery set up on a per-vCPU basis via > HVMOP_set_evtchn_upcall_vector. I'm confused: You say "per-vCPU" here, but ... > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x86/include/asm/domain.h > @@ -14,8 +14,14 @@ > > #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) > > +/* > + * Set to true if either the global vector-type callback or per-vCPU > + * LAPIC vectors are used. Assume all vCPUs will use > + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. > + */ > #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ > - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) > + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ > + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) ... you use (d)->vcpu[0] here (and, yes, you say so in the comment) and ... > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) ... you don't alter this at all. Also (re-ordering context) this ... > is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up > physical IRQ to event channel mappings. ... isn't really true - it's is_hvm_pv_evtchn_domain() which controls this (which in turn is why above you need to make the assumption I've put under question). With that assumption I think is_hvm_pv_evtchn_vcpu() would better go away. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:09:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331776.555347 (Exim 4.92) (envelope-from ) id 1nrFgY-0007fF-TC; Wed, 18 May 2022 09:09:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331776.555347; Wed, 18 May 2022 09:09:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFgY-0007f8-Pm; Wed, 18 May 2022 09:09:38 +0000 Received: by outflank-mailman (input) for mailman id 331776; Wed, 18 May 2022 09:09:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrFgX-0007ey-Ju for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:09:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d482888-d68a-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:09:36 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-eumYAFjxMH-00Oj0Yd_mnQ-2; Wed, 18 May 2022 11:09:33 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9091.eurprd04.prod.outlook.com (2603:10a6:102:229::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Wed, 18 May 2022 09:09:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d482888-d68a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652864976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FB9f0WhqnceNrPFuwC8L4UdZx9UdQr4LPEJl3+KCLcM=; b=XHIGmZxF25jcwMYJEHkol1LyFra+c5Q269StbdKq9IaANXTnPNYs0u69qtynrS0/h8uNWV H8dyoXGXLPBBoaBILn7bg+XD/0fkGM7Coul1PqmRN6rWnP4nMSEZdHZy4MC3llwOewc+st dS/0fEEK1BGCd5KCxrlby6LgYzJ3oa4= X-MC-Unique: eumYAFjxMH-00Oj0Yd_mnQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ata4159CSmWLSQGEDITJsdZgeVOkT+NfJw5N2LTLyFf9klnwXfT5cAxytCk762cTThWuevKMZmSJM/x3e86rkUx2GTGOj1xW8Z033b0AA55UAI6t+AO5RPwxK2X3eVSGgglzJha5bylDf6PJGNr1PHmaAZsJ0NJqVg6awiP0z9YpIZQZLZqv9mNj51PbYINHX5rx5PnVOOdIREL53vBUqLxcQaPe3JadUb4ai09sXljoRnFrH6vIhWNjay8wYrHADsuAlYgEeaxLwvkkRamBWRQhyhGg3tVmDd3E12hYS4QnsLYt6bU0QwdV7fF7sBuQSUSR/gHABXauaLLfwiGZeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9Y17SRlcm1fE43VCjzb+soUeKe5kX3r0qi0eDJF/jU=; b=mKdWzqdOxQWORg1K4VD+WS7PyGj5iivuWQGi7B2aQ/M1YYjo/2xeaRuMK5p2lZ9ZAPRygIpbTyr+xBZhXoNrHvgoXrFnMDKnZ7DzNuqrXhsfYMhnN/26UYhaXlY1MJ8pP+Sb+5sfiSzjAXvTh/Q+MRdTdFrNCSlwlAHkEvkyzaioOWSZzRTg1PRVfK/VPPUIFU+7/LfLa9naU4XNuNYY6X/l7STksqvuRqrghh60uO/Kpzk0DPBSMIX3hvq8kDfO6Ed1KO5yy6T2QlBXnNmG6XfcqDiqevGjP3TwHijNFFhCpKNFo/s1Nns6h30g1rddyGS++mupPG5itAFcy5bPoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3db124b9-6ab7-f9e7-3c2c-13d82894bdbf@suse.com> Date: Wed, 18 May 2022 11:09:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jane Malalane CC: Xen-devel , Andrew Cooper , Wei Liu References: <20220511151423.20241-1-jane.malalane@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR0301CA0025.eurprd03.prod.outlook.com (2603:10a6:20b:468::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb60ee41-4a09-4f7c-9603-08da38ae1e6f X-MS-TrafficTypeDiagnostic: PAXPR04MB9091:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5KYIp76Eiyo0wpAfuW9cl9kg5CsoaCPy0hRdhROMdRSFpFWzByhW8vquCYEx5PN0Ei1cAXXNNA0EDNrZs++drkf19TzOPFmrDw9kMQzqqkGD4XrPjnmBE0Vt3uvSUX1llkmN8az37Zdjggep3t/lM61gMc8eyJHsjwfWG8a63L25+Fx346ylKazgZlxgFt6agIILGeyxZJU+0lQxtyW7cO2DptEErgMaC5DxZdoCfirXMwm4UAAdk7xT29sn1mupsuFjGFXMKSaNxpmbW3Ewpm04uzlIip1n3A+eB08EKQ4ZpZpEst9YibKRYBZckZINQ8u18LhlXRsX1IJXFq1lY+CVJZhrDaunfvCJoIWHhGYfFuiyVy1P1cHenwSaTLIjCKxJ2PyLPBwPVkA+Al5kToYaI7VxgyA7NwXTQLnoXPxinBRNJMBfDbctPZBPBwhrL5gtLYQbaFhOaRq4T/xc3GZWXFtoOY0jW3/IuTXfsqDSTTH9BiSfgdyw00zr2kZtcuR/Yz0vUENv1/hggYwwFagMKd5UiKMDyoDJqOhfKzkzCHb3tcB1HG7WeUQrl4OYux/uiYS7cJsNWDKZ2XzIaLDXd56I3Z0/Xn4oDHGVxzu4Rkm68bdviBq8Lb5FhjRRVNyvu633F5y2h5pV0Dbk/hHUZpiN8XvShPq6miOXEOApp9JHC/hnjWvqsNffJ96KdXRJjwzWOC2qA8VpHkTUlKSwmsFy0IGjvpM9ss61V94= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6486002)(2906002)(4744005)(6512007)(2616005)(26005)(36756003)(8676002)(4326008)(110136005)(8936002)(38100700002)(5660300002)(31696002)(508600001)(86362001)(31686004)(66946007)(66476007)(66556008)(54906003)(6506007)(316002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1JZgVfTfou9/lyHvhQKieL2Xl5JhKpziCE+TylmyK95/fkzxGIFmKJearbFt?= =?us-ascii?Q?cIRRDwzMOAauwtTQZ+xHS0YX4rxJIRLH1Mty1tR9kyQ+xM3hlkS1dNMvH8zN?= =?us-ascii?Q?lCQWlkvEwdQvb35FidygO39cl9ng3W7evAGv590AX4eMYqMMGCbxs8wcYKAb?= =?us-ascii?Q?lIhW1qDqSZkSjKB1x7UFrFhdCynWblLb06hFsV4vg1KFoisDN2iv7u1L5DKw?= =?us-ascii?Q?ftwHgkjqcr2aGrbuGvHxV4f8puvZ8Xkhs87J3Y6DdvDygnZtiltrq4U61G9C?= =?us-ascii?Q?FT894rkRkmmCG7Izqpf3Vu699VohQ+i3snM/RU4hFtgXx9/43IYOkd1LzHR6?= =?us-ascii?Q?h70rma9ptEHkbz4mK9pQs3RdghE9ritKQ8j9nkwzIZZ/bZmdTfdfL1vAKK7C?= =?us-ascii?Q?cSudD4MLYq6vh6eSrPo3JF7ADx++CufEFQ8o9O+1Y0qbIZdIODY0UgYiW6+p?= =?us-ascii?Q?2BGTnNQQYHKol+htg8iW/IruNNQXHPIapUzq+K07o2kyW1iL8NPcovkvrmEv?= =?us-ascii?Q?EMv9PyYLAoqbOTWRGa/mYptwebif0dQTskGoYEyZJ2IkPT8MGjtALuCfsmON?= =?us-ascii?Q?Ypq2HY+fBQzimaMHoZ/y6BA+9KTk+lpRLDdcmQYjeZ0l/Im+ylLwZjKEn9nz?= =?us-ascii?Q?X3XgJ0A670dpe0BpSUeh9zNYv+l2jxegjRqMY3HUA4+TdhgBPwkCOuPwZj0/?= =?us-ascii?Q?FM+fWKJkNgI9l4doDECPibCqid8bjQx+HzGWw+2AqKaFUUUGEDxf7Av1+uY6?= =?us-ascii?Q?iya8GUvcss8n8yLO+39iL33W9B2Pf6wLSAGzGO4OdTEmFQOZVEhbcMG8I7EP?= =?us-ascii?Q?WpMfuBuMXSViNB2n9OYU9minzN6LiIczl1NNJ/uISXyyHV86QdcH1vOCgLtd?= =?us-ascii?Q?ZtPdJYZyC+SZLiCgdqVUb6KpqZErT5STKrdaAnn3i7QXLSNc+QHeh8NHblGg?= =?us-ascii?Q?ybgKbdhH7zrTG9YtqrY/F4UUNn++D+iSEER0vPMmMNqyawK4GKkqD+lXgoW7?= =?us-ascii?Q?8ebau5UvJcijbMx2hW0pW/wkgz5moub8/KAissu93rdvTLQiIFwACT3nJooN?= =?us-ascii?Q?TIIEDTEfXKSY/QKhOXely+nzvBVodEJrtSvsYzdksSuoqJ/RbwrzvVcPvWQZ?= =?us-ascii?Q?6OT7plb1fx5RS3hXYGNLqGfggk2VhCUTpGcUK9sGBzTZFbo0L4ztRQXMkZSu?= =?us-ascii?Q?V1hgzQOQzZHOdO0CjOnR5ClZ1vZBmGcEc6pFbV96i6yCxqHVaMMPQLo5jUL6?= =?us-ascii?Q?d7mYsaNrv6PXyRoPfWvUSxv8A6o4d6vVk1lR7Tv+yerVLBOcxF9YM647JeMn?= =?us-ascii?Q?PlLyiAhfMfmvb4QzpW+RYSAUHQMejV3TucfAKc8VdSs0Na8WkJA+49nd0Fdd?= =?us-ascii?Q?jB6ki+XLaQYbafkllHtBjZvtKA8mh88K4++H9SdO+H7eQieROjFRR9Q3BWrR?= =?us-ascii?Q?AKk3RjFiLXKqbr4AWDt38Qeva5tPwRTXvn/XCwoAQrefA1HI6vT0+v5iEjv9?= =?us-ascii?Q?oFJ6geXiIQnpGQQTiE394/9s3MSQxB2rRiEKgok79ZpI7VDxD5wKnZFrkqRr?= =?us-ascii?Q?yjZqJDImzGKWXeaBxiCTVbfguleG3QFWHVgCKXIjIf+YeglheNbmFng6IV3W?= =?us-ascii?Q?9AaawxTpmg5vWqG4osPOuG2C+YkyIgUbvCPhfa3TFgjMJHdz+NbnBMSpBRd4?= =?us-ascii?Q?wOisTL7V6mtbt8Dln0gpzGCezdWJal5jU/8SfKo1Wn0bNuq+qsNsWnPai4wH?= =?us-ascii?Q?RlbNy2Fcow=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb60ee41-4a09-4f7c-9603-08da38ae1e6f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:09:31.3690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mm0NieMskMF3efX1ZbkWJycfWB1NYLyJINObu9cOoi71UqpQY0kc9zTbAxlwZj/rjTB0XVh84fvcJ9aWtgt/3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9091 On 13.05.2022 17:39, Roger Pau Monn=C3=A9 wrote: > On Wed, May 11, 2022 at 04:14:23PM +0100, Jane Malalane wrote: >> Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for >> evtchn delivery set up on a per-vCPU basis via >> HVMOP_set_evtchn_upcall_vector. >> >> is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up >> physical IRQ to event channel mappings. >=20 > I would add something like: >=20 > The naming of the CPUID bit is a bit generic about upcall support > being available. That's done so that the define name doesn't get > overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some > such. On top of this at least half a sentence wants saying on why a new CPUID bit is introduced in the first place. This doesn't derive in any way from title or description. It would be only then when it is additionally explained why the name was chosen like this. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:29:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331784.555359 (Exim 4.92) (envelope-from ) id 1nrG08-0001rs-KG; Wed, 18 May 2022 09:29:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331784.555359; Wed, 18 May 2022 09:29:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrG08-0001rl-Fy; Wed, 18 May 2022 09:29:52 +0000 Received: by outflank-mailman (input) for mailman id 331784; Wed, 18 May 2022 09:29:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrG06-0001rb-Vm; Wed, 18 May 2022 09:29:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrG06-000150-TK; Wed, 18 May 2022 09:29:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrG06-0005XA-H7; Wed, 18 May 2022 09:29:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrG06-0004bR-Gg; Wed, 18 May 2022 09:29:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CmmODfAcbJliMUP2N8SDxvjvNhIwNygL1uU5TqS5xIo=; b=bBCMSNvh/xAvEU62TTX4WKsM4L 8PfHnRp9IR9QqE9Yw3gl4rbhFadW3D0SxtPf4G27+Z1ryKguZi8AO4QjZyKDgUge9Wa1w7ArWkKJ2 OlHtyo1r0t2zkQqnD3SW+lkcs6ZF0ErKMNqYbb77ElFqx2FgbGv0ININUooGFAMLO9Eg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170533: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 09:29:50 +0000 flight 170533 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 78 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1080 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 99 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 09:40:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:40:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331801.555390 (Exim 4.92) (envelope-from ) id 1nrGAd-0004Ti-15; Wed, 18 May 2022 09:40:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331801.555390; Wed, 18 May 2022 09:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGAc-0004Tb-UM; Wed, 18 May 2022 09:40:42 +0000 Received: by outflank-mailman (input) for mailman id 331801; Wed, 18 May 2022 09:40:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGAa-0004TV-Rh for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:40:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 939953df-d68e-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:40:39 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-BFha0umgO7u1dMpyPEGIlg-1; Wed, 18 May 2022 11:40:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3122.eurprd04.prod.outlook.com (2603:10a6:206:e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 09:40:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:40:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 939953df-d68e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652866839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kR4aguezniYjyWzhm8D0nCH6aT54bM3D5HpG3FdurXY=; b=j0pl1HmPt0DpUVHmtj6rG4E20nwslkQdmE4SY/gmmirH7C4Gl7jWl+veK1radZCp1B2I4j Yvkb4ZqoLozwVekddcGA07y7Wcegy1KMk2JFLBqtpwYFzOBB9ZV8mPawLqhr9kMExrZxJH rJ4I2ZdHJtH+o3szHD7kfKRzrd5tnAw= X-MC-Unique: BFha0umgO7u1dMpyPEGIlg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgvUvGTkCw8+kiCpiOR1J4SVauYWlXF7uGjls26VTAtVOl7DO9PiL4XWQmxoCekkxmStI4LezMIMUWSSApYiAKUUrwiRtS9CgIatkAA69gO6hji80+wxtl65GcbcueYO0iIqxXfVTePoydLSocLNhDJ0zuVqbaSYBK1IFm6C2GIY0Ay+/+nDkkvTWRFLru3zH8gHnOkoSFGz/9gT3+wx3QsKupBocvsFgbM+mGbHFXO4niRkSOzvn7N6iYzPM7wZ8oVv96iXz9d0f/WsUQcY1quH2SsSMH2QcroM6SwAXb4iwa+OODzXv26XpnCRpoJG8JCSJ51dR8An0h14h4jIDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kR4aguezniYjyWzhm8D0nCH6aT54bM3D5HpG3FdurXY=; b=oSHgl8BINd/a1gay5J6w2WwGmRVtJMXZI0OZQM/xCozSGooxQGQ0IskIYs0uGUJfUfjYpFsYP8UmMpFFvtbqdV9McK111NJhBvensdxXFbbmMV+YQ0hnXGmlrXDqYiYWrblezl3uVlbLMvP52lohY6yiD/ayOf0WboGHE7n59jI7SAPDqyu/SDRe897K5qFYC7cdJaGUQpoGiMFAs3t82vWcYXtwGKRigQNrCDM2/nW+99lWA60YuZBKpVUodAHDVapU185FtYxBzFK1dONlahoEZjxWBXDYdH2EfLZRNkqcxpRtAOh4p2mo5tQO99YW4qKzI9UUZD4dTXmGF4DIiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 11:40:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0137.eurprd06.prod.outlook.com (2603:10a6:20b:467::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5c70342-474a-4d08-bb15-08da38b27640 X-MS-TrafficTypeDiagnostic: AM5PR04MB3122:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UNeQIN6ceotfuvOGWdHGuCM+BAHbd0j+43EA0F8VTz+JnCoDZ/PPwUShsNfpmGPbit1ezYkgrZ9HebQJ1NKej2HPXcKf5jZyjRBkfQNr1XDLjHyaLeeE3bC394cgxEbtEvprdJqyRVwY4iD/CjJ2xsjryaH8tSInsD3ZFceJP6uRJOpKZBE9d/XwJZPnqVUWNk4oaFFmYKVODhYtOYyT/MMa+s+37tmIlEEBGZGf4t0Z2endkWcEb7VM/4FBJV07pqpitJH1BJ23/TXrGCSBFB7sXe7551RdrbbO5Fx3dmvPWh+eWNHNDcuBikfuqv/WwIXc6yXZyyLiOaB+BDEixF5NJ9yoyt1aKuMDabssgRPfkVwB6AkoOKFDE80OdEOyAslpD69qBON310x/abPvufLZvO5XcWfeOx9u52kV0tfi4S5hqVMMUOpixStepSc7sqyUmycwbEeGCzzokc4KOBs4ae5HBcXt+J8Df/RXietSJbKDuFkWw8ZTOeWAS56zEopvWLAe/xJELkvIPAmKvod8eCbNIDT/v8Wa2PgoReEs9hu2xJRMAB9/ESVWGmeER3Evip98kbOZKvZ7sm8cu4GDieDDzyIIDaf2n5bu8qZsoYO3w55MIuf76ym0wh67hBMdc22cKUChClsXYOhEsxy/vWQb5/jQY/J0fPAtmrf8pc/si7lCSpb+72nEhuyAprR9Gdv5UI1B1XfUo3/qVk/ePo/aIp3PmvrpXnTAshM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(53546011)(6512007)(6506007)(186003)(5660300002)(8936002)(66556008)(86362001)(8676002)(4326008)(66476007)(66946007)(2906002)(26005)(36756003)(38100700002)(31696002)(31686004)(316002)(6916009)(508600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmZvQTF3dXd0NkFHMzBZV2JHQ01LcEplSnRVaDZqSUpvNFQ1cE5GVVgxVFcw?= =?utf-8?B?YW85UXlFVDl5NW9sOWVhYlpjZGxMWlRMZkZFR1JmK2orUnVjV01lNnJTbzd1?= =?utf-8?B?YzJva2JkMERGYlVqRUJrd3lTNDlxWVpYTkpreC9RZmZrZWNPNVVrSUFYMkIr?= =?utf-8?B?WE0yUmVxZkw1cTNJaU14K1FRb2U1MWVaeHBwWUtDOTNMa1ZubXc2OWRUUmVW?= =?utf-8?B?SS80QmFSdFFvTVFOcnJkenBDd2RGWDFUN3VyMWZmaVZBQnR3N2hWVytRWlQy?= =?utf-8?B?TlRONzhGRUQ5TlkyU2duNXVvcHJRK0VoRUVyaGxnMnVPK0RwcGdnZWNZNm5X?= =?utf-8?B?WnNBZ3hJWm5hNlRtMFJQSTRiVTJLaVBRWWRXOEppemVTQTdPYm9vMlhTUUlS?= =?utf-8?B?RnB6Z1ZuMFRwS24vbjBaQUhNUE9ycjROc2oyRkYyR2hKT0lRWVk2MTVCRmZN?= =?utf-8?B?WjFOOEFDaEJzSFV4VHRRODJneHpYY2V5YXB6VUhDUndBNXczQks2ajB2dXpm?= =?utf-8?B?Y0JiNU5GcjQ2ZlY5V3IxUW5uNTMzTTg2RktZUGdkcFdZZFZES1UrYUlUcFlt?= =?utf-8?B?Tm9RZEsvZHFtYjU3d1RiQWlHSW9hbXphMVQyN3E4NkNHczFXejgxMGxybExN?= =?utf-8?B?ajgxUitUeG4wR1JGcmtVNzR1Mkk5WFd2aHFtV0Y3WXowTHRscmQ3SWRlaVpz?= =?utf-8?B?blpwZWNqblE5WElvQzlIa1JJYUh0V0VuMUtXOVMrYXJBdzJURmpxSTBqWlpy?= =?utf-8?B?Z1JJUG01RndLZDR2T1BiUSthSzJGQkt3ZlhTV2pVSkg2QkZZNC9ydWErdXZW?= =?utf-8?B?TmxGZ1pqNHlnK2JscjFIdnZtYlNwWXY0REs2UUZXZHk1YWhtYzFIYzhkdTVS?= =?utf-8?B?QTJmbEUzZ1Fnb1IvS2p3MVpSNEJ2YUJyMmhTMkwyekpWc21MU1BVYitCTnpj?= =?utf-8?B?VGROYWw4OTN5dWRIdmtMOXl0eCtCQ05GR1RncGNLWjMyNFdVY21jTGFNZklH?= =?utf-8?B?cWlZeGlQWHdaNXdQYTloYUNVWExYM0dkWjI0Z3Y0Zlg3a3RYelB5YjFDZDBL?= =?utf-8?B?SFFjd2V4NHZ2SFpwMGt2S1dTVk04cUlXMFYwQUNHb3JzQ0NObUhpU0pVekZT?= =?utf-8?B?bDRQZldNaDhXQmM1S2Z3dFdQNEx1UEoyYi9qR29FNy95VjVBUnNxazE2N3FS?= =?utf-8?B?eklqT1RyTUlGMHFOUXRwNXNxNDBjYU5kUFJ6NVpuMXVNUC9sLzJDaDdrYVd1?= =?utf-8?B?MksrbGh1bHR2TWM2SHNYaEJydmxHdkRGT2R5ZkxNcEhXMlluSEg5bzFrdkFV?= =?utf-8?B?cHduRE1TM3owcDY3M0xzMlM2a29pODFxNDVOSHVTQlV4eGdJSnM3Ky9sRTJs?= =?utf-8?B?L09DWU5BdDZ4NHBoamd6cEZSR05rUlhUUFBNN00rVWhxWlkyYVhVVnRyMW01?= =?utf-8?B?UlZQRGR1cVVxbUFtb29qRHV6M1NUT1J4Rm4raXIyWTJqVjEyVkhLOU5pekVL?= =?utf-8?B?YmRLOUdLVDhYWGJRM1VMK2dCN2cxdWVYUDgxYStiS3I0S3d5MVZaZHFoUkJi?= =?utf-8?B?NEVTVy9RQVZiYlJmV2x3aHZyOEZsU1c3Q0p4UEFGa2NjV2J0VlJjNXFMdXJm?= =?utf-8?B?Uk5nQ21INUl6bTE0STVQS1ZxQWhFQ0xUcUZhSm8xUmVQakpsSkRGejdDSUVy?= =?utf-8?B?OEdUbjZzd0oyWndDeTBqYy9QNTlKZThrZWZNM3F5Vkg1VEZpekg3WStJSUkr?= =?utf-8?B?dld2ZW42TUM1ZWVnOThRZzVId2NaS0h2Y1dVWDYrNmNISTVIbmkyb0dHVWlE?= =?utf-8?B?QlFvV1kxZzJoaXIwNXlFNGo0QzdSOHNmMXk3dThoMlg4ZytnS2tQbDE1UjQ5?= =?utf-8?B?SDNmc2lUU2o4ZGo3M094Vms2N1A5a0JUQ3ZiMTF6TFd4L25qUzhaMzdCdnB0?= =?utf-8?B?UFRHdWJobkxIZGZyZXk0cUpRc25yOEZyaUsxRHFGNUNmYzhSUEpSMDh2NGhU?= =?utf-8?B?VmRBRS9wWVlqakRUSE5hWmFOS3c2SWdtbGZEdjF4d0h4aGJBT3dOMXFVWXg2?= =?utf-8?B?M2pwZXdZSFlHUHlXRFRCaXZTa0h1Z0s4dHdjYjlpT1NCRlVuMXpSdDBxRjBr?= =?utf-8?B?RzFQK1RZd0tRYmZ3Qm03Qmo1c3lWUWpwcS9WbllWUHBwNk8wbDVraDBMYXdm?= =?utf-8?B?VDhRSWt2UUlxRHVaaDRxSElyUjkxbk84bmVRa0JmRkQwc05hRWNiRlU3Mit4?= =?utf-8?B?Z3gyQWorc1JwTjk2ZHZXdXhNVkVoQzU5TTcrQVl5S3hOa1UwZWN3THEwSUJ6?= =?utf-8?B?a2FaSERSY1JKdldoVXZDWFhIMWJzQjdpcm1XNzBDeVRJN1pGdkpOZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5c70342-474a-4d08-bb15-08da38b27640 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:40:36.7196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qRF1p2ml1D/PqBS6ZrGXYzyGec6oTdn3/jEh+c4ULjky/kQPmCQ98as+SF/aS87vpkQpYPhYZVhx16WWlteJ+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3122 On 17.05.2022 19:07, Demi Marie Obenour wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -39,6 +39,25 @@ > { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b, 0x23} } > #define APPLE_PROPERTIES_PROTOCOL_GUID \ > { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a, 0xe0} } > +#define ESRT_GUID \ > + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} } I'm sorry, but it looks like my earlier comments still weren't clear enough: The spec calls this EFI_SYSTEM_RESOURCE_TABLE_GUID, ... > +typedef struct _ESRT_ENTRY { ... has no tag here, ... > + EFI_GUID FwClass; > + UINT32 FwType; > + UINT32 FwVersion; > + UINT32 FwLowestSupportedVersion; > + UINT32 FwCapsuleFlags; > + UINT32 FwLastAttemptVersion; > + UINT32 FwLastAttemptStatus; > +} ESRT_ENTRY; ... calls this EFI_SYSTEM_RESOURCE_ENTRY, ... > +typedef struct _ESRT { ... again has no tag here, and ... > + UINT32 Count; > + UINT32 Max; > + UINT64 Version; > + ESRT_ENTRY Entries[]; > +} ESRT; ... calls this EFI_SYSTEM_RESOURCE_TABLE. Also some of the field names still aren't matching the spec. > @@ -1067,6 +1120,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > if ( !efi_memmap ) > blexit(L"Unable to allocate memory for EFI memory map"); > > + efi_memmap_size = info_size; > + status = SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, > + efi_memmap, &map_key, > + &efi_mdesc_size, > + &mdesc_ver); > + if ( EFI_ERROR(status) ) > + PrintErrMesg(L"Cannot obtain memory map", status); > + > + /* Try to obtain the ESRT. Errors are not fatal. */ > + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) > + { > + /* > + * ESRT needs to be moved to memory of type EfiRuntimeServicesData > + * so that the memory it is in will not be used for other purposes. > + */ > + void *new_esrt = NULL; > + size_t esrt_size = get_esrt_size(efi_memmap + i); > + > + if ( !esrt_size ) > + continue; > + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type == > + EfiRuntimeServicesData ) > + break; /* ESRT already safe from reuse */ > + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, > + &new_esrt); > + if ( status == EFI_SUCCESS && new_esrt ) > + { > + memcpy(new_esrt, (void *)esrt, esrt_size); > + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); > + if ( status != EFI_SUCCESS ) > + { > + PrintStr(L"Cannot install new ESRT\r\n"); Perhaps better PrintErr() here and ... > + efi_bs->FreePool(new_esrt); > + } > + } > + else > + PrintStr(L"Cannot allocate memory for ESRT\r\n"); ... here? Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:41:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331809.555401 (Exim 4.92) (envelope-from ) id 1nrGBm-00057N-Bf; Wed, 18 May 2022 09:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331809.555401; Wed, 18 May 2022 09:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGBm-00057E-8r; Wed, 18 May 2022 09:41:54 +0000 Received: by outflank-mailman (input) for mailman id 331809; Wed, 18 May 2022 09:41:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGBl-000574-JN for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:41:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf4b5aa4-d68e-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:41:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3CEE21FB1D; Wed, 18 May 2022 09:41:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F03E9133F5; Wed, 18 May 2022 09:41:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qcvsOF+/hGLGFAAAMHmgww (envelope-from ); Wed, 18 May 2022 09:41:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf4b5aa4-d68e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652866912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gvqmwd32pWfeTd+pQbb+XvmLC36shUm4oEYSUHUH/4s=; b=VmbfWJ8JScNoKhmKbR4C9ZO64MZdKjOsfSFQ9u0TxeoN8yIcQbA8bSGDJAJiyjMeuWQkFm bVjYMG/RGdqHikQV42UWgAuICyP0T1Rvn2DdLgPgwfWZKBN0A2esT9qSwLHxeZg+cP6ZSj yhMwCwkyLfABT42xMpYxYSNy3CUExGA= Message-ID: <642471c7-f717-2ef4-1d6d-6fabf57db08f@suse.com> Date: Wed, 18 May 2022 11:41:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() Content-Language: en-US To: Jarkko Sakkinen Cc: xen-devel@lists.xenproject.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-16-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------40zZX2QheKufpfo6R9R2UDWP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------40zZX2QheKufpfo6R9R2UDWP Content-Type: multipart/mixed; boundary="------------TgxGHQPVJJUkPuHCpNDyxMvE"; protected-headers="v1" From: Juergen Gross To: Jarkko Sakkinen Cc: xen-devel@lists.xenproject.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe Message-ID: <642471c7-f717-2ef4-1d6d-6fabf57db08f@suse.com> Subject: Re: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-16-jgross@suse.com> In-Reply-To: --------------TgxGHQPVJJUkPuHCpNDyxMvE Content-Type: multipart/mixed; boundary="------------GyGKEkcibCyskU997scHLe0C" --------------GyGKEkcibCyskU997scHLe0C Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDUuMjIgMDA6MzIsIEphcmtrbyBTYWtraW5lbiB3cm90ZToNCj4gT24gVGh1LCBN YXkgMDUsIDIwMjIgYXQgMTA6MTY6MzRBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN Cj4+IFNpbXBsaWZ5IHRwbWZyb250J3MgcmluZyBjcmVhdGlvbiBhbmQgcmVtb3ZhbCB2aWEg eGVuYnVzX3NldHVwX3JpbmcoKQ0KPj4gYW5kIHhlbmJ1c190ZWFyZG93bl9yaW5nKCkuDQo+ Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0K PiANCj4gUGxlYXNlIGFkZCB0byB0aGUgY29tbWl0IG1lc3NhZ2Ugd2h5IHRoZXNlIHByb3Zp ZGUgYW4gZXF1aXZhbGVudA0KPiBmdW5jdGlvbmFsaXR5Lg0KDQpXb3VsZCB5b3UgYmUgZmlu ZSB3aXRoOg0KDQogICBTaW1wbGlmeSB0cG1mcm9udCdzIHJpbmcgY3JlYXRpb24gYW5kIHJl bW92YWwgdmlhIHhlbmJ1c19zZXR1cF9yaW5nKCkNCiAgIGFuZCB4ZW5idXNfdGVhcmRvd25f cmluZygpLCB3aGljaCBhcmUgcHJvdmlkZWQgZXhhY3RseSBmb3IgdGhlIHVzZQ0KICAgcGF0 dGVybiBhcyBzZWVuIGluIHRoaXMgZHJpdmVyLg0KDQoNCkp1ZXJnZW4NCg== --------------GyGKEkcibCyskU997scHLe0C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------GyGKEkcibCyskU997scHLe0C-- --------------TgxGHQPVJJUkPuHCpNDyxMvE-- --------------40zZX2QheKufpfo6R9R2UDWP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKEv18FAwAAAAAACgkQsN6d1ii/Ey+Q Gwf/ehwm6jUVpEx0+yC4NILAFBiMMpghweN7oXV0/HJir7zTTMMijxvTV8f7AbuBIcmB8vARGnsl WuftbUX84JXnTdadLZBDwu1GlMoopubDJdB7Y5Q3XVPEovNvsQYh/ImQ3Jlyj9UYz2mcFTTZ0sUk BJZeDn+vzF8sOnlLGcGwHPVCuBLLZlKqngtEoEHMpbpR0JKGR4+TzVnxrftnG9w8PYKuhgV/5X/v cKGD4Na6ulAuKU73AdUaaf21oxr0ptm9ZU66c1bA29Ttg9j01pBsc3u5qLldjrDXmViT0KwvVkVQ WbqyphGjTYqwCTcGorFhmvnbqGc3RLvoNYDA3vr8bg== =vI4g -----END PGP SIGNATURE----- --------------40zZX2QheKufpfo6R9R2UDWP-- From xen-devel-bounces@lists.xenproject.org Wed May 18 09:45:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331817.555412 (Exim 4.92) (envelope-from ) id 1nrGF8-0005n6-RQ; Wed, 18 May 2022 09:45:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331817.555412; Wed, 18 May 2022 09:45:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGF8-0005mz-OM; Wed, 18 May 2022 09:45:22 +0000 Received: by outflank-mailman (input) for mailman id 331817; Wed, 18 May 2022 09:45:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGF7-0005mt-IW for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:45:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b4822fd-d68f-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:45:20 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-lnT8HsoSOx2ijB0FugBCZQ-1; Wed, 18 May 2022 11:45:19 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6548.eurprd04.prod.outlook.com (2603:10a6:208:175::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 09:45:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:45:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b4822fd-d68f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652867120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2+3GW+NV/jl0TI3GhY/ByAP3xZ/qhv9bAjbjPBi1Ckc=; b=NUhugN0FWZwEvW/EN+11sNoqQYoUysJn8RJ2oWuURkBx80tuKhO1KFMnITaALqnY9vzimn Fxe9R0U4Z/HkTSHXtOksjL9B7C2LRSQ1UQv3YEjkPmtHd9j3mMUFAJwH8FdDbQbIa4dxSe xlsodMVXUxtNKbZcIB14ePUv/eO+ras= X-MC-Unique: lnT8HsoSOx2ijB0FugBCZQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mw5TF/qSRKmh+YZJ8D4S5P/HAeXgxQU/kbB4RGbJShcLsmfNnKgFeeVxnuhI3uiQGRL8K4+YQejEdnhjw+B4zDKrKuCpUbSslfbzrDdU03HqwH21g3cZMnDlD1Vl8lsLE2MdRniJCOUMvbSQiXetfqTP00BbrYqsp4xaBZoKDILINwS8ug9muNcKs16Ndpj7cgFdvywO1GNNJrD0a+NbCANvNdfBKfPKXSBjKVwjCikZo0HL5/m6wlc6TFOtmc8qm3nRrOgI15tbb9vr2DQNRAEA/q6e6aUfuirR8YmA7cGZ379/7pVZgEn2LbxuEuUXiiBLP0DHH9Py8pUoWIwUDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2+3GW+NV/jl0TI3GhY/ByAP3xZ/qhv9bAjbjPBi1Ckc=; b=YlNqapNiSbxSVNcTpRBroPTzZNVphqn9BQL2qmiAiwyTDKjCJ5apa7hv86OKUaJw8ykH7vxDfmsazAVT58WtPg5vYFkHYLtIs0ipglcRvhG7VfyesYABqUMdBk1VnHougMvjhvakn1LST75krsRdRNpaic4KGxnkhWAMQiX3O6dzPU2FBeIjKVdsJbe/f7dpou/rhEUxjDHE8FfLUYdlEvhW03oQ8PCLieM9DMxEBZUxLMY1mIaPNPikkm+Ng6jCx94XO8SM0OiGSmQHN16MKjAsXkvNPycDixvgYhRpK9kSWvPmYPhvGFjFEoJNC2AlY00zkvrY+oapZwt5j5SuSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6b5362c8-2a41-d2c8-b25e-2e9c421d6da2@suse.com> Date: Wed, 18 May 2022 11:45:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: Roger Pau Monne , Andrew Cooper Cc: Wei Liu , Henry Wang , Community Manager , xen-devel@lists.xenproject.org References: <20220517153127.40276-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220517153127.40276-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0039.eurprd03.prod.outlook.com (2603:10a6:20b:469::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 764359bf-54a5-4d00-9356-08da38b31db1 X-MS-TrafficTypeDiagnostic: AM0PR04MB6548:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z8Wk5MyZjPLXzBFwFHEAfmWtjWdRHxRTBbY7N+7JBZIqr07Rcqp76jq43C9xu2LuirOp20M5E9MqAZDOiyZhrUDfWG9fU9HTqInoMGvR5ReuBzdkwAab9y6tgZsYMaKce8RU670WsfCkhTf+h1G2ZdxjlEhi1t9BdWyNH5pZl9kS0uqsnoD0bpyQ9B03XRjwYBeByKyWWdkxTOsUdP2wY/jepyHO1To6YoiMOd82Nxik9qYzZtqZjPhGuvHb96vBk59QaNym6BcFCx4CDbyvg3QePmOy1Xqh7W0SdTWOmj2mBSxE+EUu6dUjVN2Zgt2UoVrHl/9p1blQbELU7XaLpnVJkSoQVyfwgio7wkKJlRrbPBVtN1tVU7nuXj36HJ1Im63QmHIDth/KSC8cUFhRpYT8r7paZtxJrCBDQ96tvDe1mYN5lKIw8GWMQhrV8wLQESLvBGAg/B08Vi8AT70suabvrYhqxf9SM5uVuY5qPZ11rMHk817UQqa/XVR7LLD1lK7LiqDu6SfN0lfCzB96VztkCaPTRCNPzr8m/ZnTqPGa2LesOsgYXxMTL0evV1Cme06sSq95IMikjr+AzgQZSX3mlp872N1SyXqUSxNoFJZygp2MXAG/fA4q/S/X/25NwFEgKRnsU0HpW39io85BzX/GrE3eNE1UrRtQjdmYzVcawS2UkjbW31ksdHB6cDYr8LBy5xeWnnud/hj+QV7eb61Xkq07PnLEhWaAl9i/qyk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(38100700002)(186003)(5660300002)(2616005)(508600001)(6486002)(8676002)(6512007)(86362001)(83380400001)(36756003)(2906002)(53546011)(6506007)(31696002)(66946007)(66556008)(66476007)(110136005)(316002)(54906003)(26005)(4326008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3ErTloxZkhqVWhsMTBPbmtaTjhIY3pCMHZHM3J0M1lyQzhYQytuY0huVlNr?= =?utf-8?B?M2tWR283Q1cycUk0eEVjOG94OW1SMkQ0OHd1U1pBSnI5L1dmaGhZeFpwUzV4?= =?utf-8?B?a3YwWEdiVzBNS0RGbjM1cUlkb0hveHJGWW1mcVJsb3BBbkJjSm5wSnpnOU1j?= =?utf-8?B?cDRPZFFsQnJpMXVZb1BQa3l0UCtZUzVNNHhTc0F2QXZHclZ3TnBIbHlTT0hy?= =?utf-8?B?aU94TGpyRHZpK2RvQjF2dVk4RjJsb3k5MjNtN25nRXZVVHFKaVZZZlB6L0Jm?= =?utf-8?B?SUEySzBSNjY0ekYvTWhwQlllOXp6V2txUmh6WDFpWkVPOE15QStmZTArOG5i?= =?utf-8?B?QWh3ZkZuWXhMekFpeEx2cXZkRnhVVWhxUXhDeFl0Tnd4QWRacHVPVXpvNUFo?= =?utf-8?B?RVJ3ekNPZ081Z0RrSkExb2NuTUx5cjhyOEl3OWFnZmhzV1V4Szhmdmt5Q0Nq?= =?utf-8?B?azBiQXg5bzRHRlBaaUIrV0dIeHh3aEpTRE5vTGJtd0ZBb251dmZSOElKeTda?= =?utf-8?B?bjdZWXF2U0M3Z3I3bVZvRW4vMjdkWllSTi9OVWFxNktEeFFRbjJ1UGZ4dzZ0?= =?utf-8?B?VVlOUjFVN2JlTnF2d3lNZTNBc2pmZVc2azBZcnZhMkRnMUtjZ3ZGbUVKNkE4?= =?utf-8?B?U0E5d2pFbVZDY0oydG9CNWxmV3pnUUdTb2VuYkRHVkhoaU5ZLytiTFZORjRj?= =?utf-8?B?ZWExdFBxclpMNkR5RFllQXRYUjRUR2EvcVp5SVhEYmNBWm1ycjVpTjVubVdL?= =?utf-8?B?VEhZZWZTd0ZpMVR0TzFNVHgrVWVhS1Zubm1YYUh3SFAxWGtmaEdVMUM0clZ6?= =?utf-8?B?bFQrbXBlZEkzZGxEeG5BWlNmbDFERFdhNDZXMVE0Nk1yb1FDdDVFYllKZGZU?= =?utf-8?B?bzgxbjJnUEdRTzltU05Ub0RaaDEvM1dMV1hhSElyTkUrZXl2TEliUEtidHhn?= =?utf-8?B?OFlJazA0QWdTOFZwT3JIYkxlL0xUVStpRWRtNkhhTWkrZVVQaTM0SDNKTkwr?= =?utf-8?B?aVk2dWxjTHBXL3d3L2FJdjlGMmQwWWZxK3VxdDNoVk84ck12TVZJbkIrQmRO?= =?utf-8?B?dlV2dThreW9Pc3N2bXVCWUIvaVJxaC9XcVZhcGsvVXdTMVJGWUpjdEJpVmtH?= =?utf-8?B?cHBzZCt2WkdYemphYzBnTDFxQUp1M2FrUUgrZVpaVHlxbnZ2bjgxYmJYb0dP?= =?utf-8?B?TzNvbmYzQ0N5cVBzOGkvbWZWVms3TE9jRWgzV2pZbmdVNDZtMncyZlA3UXk2?= =?utf-8?B?bmRqQmF0R3FTMVY4a2QvR25VY3BrRW9kMWExVk0vMzYwNHNMcGdZTzBabGQ3?= =?utf-8?B?VFRtOXZGUE9iY05YMWwzUFY0empoV0V5N0ZoN0NrOUx2dzFmZi9QVFJBaVJv?= =?utf-8?B?R0xZUThkL29pbGZmME1HM2l0eUJlQllzS051SzY0RUg4OTlyazArcWxlVmlk?= =?utf-8?B?YjBiYjVrYlk2cmwvNGVPaEl3OTROaGpuVWhKdlNXemN4L0JDVG1FRmZyTEZS?= =?utf-8?B?VmtTMjd5NmkxY3VBRnByMUNYSk9xVTZFcWgwZ2ZJbFVxQ01ZNWZRYXc1OGFx?= =?utf-8?B?eE04QTQ3VGpVZzlNZnd0UnBJeHZjN2dPQW5KblZOOUdqTldMZjdQTEhKWDd6?= =?utf-8?B?UXNqNS9QdnhMbTFSS0N1R1lidXRYSS9GTklUczd2RU4yNkc3N0k3emJXRXd4?= =?utf-8?B?bXhhV1BxcHYxajhUMWZNZktiVjMyalFneGlmbkFPNWRZYThPS1RSTEJlM1Zx?= =?utf-8?B?Q1d1cnc1MjRrbHhwTkNaUTBDWmJJNm9JU1lHTDVjZkdaYXNoRkU5VTRGNE9i?= =?utf-8?B?MU9wMmVuMUxaMHIwelQrSTdtcFk1bkc2ZEVIRXF2eXlDRnlsN29SSmV5bjRM?= =?utf-8?B?TzFtZHZjTWdWRXkxYktHb1FDUjhERG00RWRhVFlid1pYaWh2YThnYVpGM0tw?= =?utf-8?B?YnUrVDRCZ1hTNVBjTVlLem9pZkViSjkxNlFQVkZpdHVBc2c0ZmRNT1Z6RWJ4?= =?utf-8?B?WFdEUjJxcTVsaDROUjdSaElIYUhCNkVocEZhcVdCOXAvUGF2NUhTSm1scTkv?= =?utf-8?B?NFhYRW5sbDhTejd1Qlh6Q2FDVHNvai9TaG5XQkU3MWJQYmwwRDNIaVpqWERk?= =?utf-8?B?K2UrN2tUc2JrbGFSYlpaaXBkVkFFTFhrRnRnZDhvMzViOGpuTUY4Wit3bmQ4?= =?utf-8?B?b0hlVUh6b1dtWGNGcEdFTlFxOE15VEkrbkRBaXZGZnlFc0t5N25UZUw0SEgw?= =?utf-8?B?ZkErYnNyTndMR1I5NVl3bktQYll6S0gwaittR3hJV2dZN1UyYXNVQnUvNmZw?= =?utf-8?B?SGZFbGNybG11YXBKcEZHa2VaSm1RYVVoQVBKUFFXcHhMTmtYUzhvZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 764359bf-54a5-4d00-9356-08da38b31db1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:45:17.6543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JBUnuyjMkWgjU0DUmALmMtTbaC0CUMtgOJuNht8vnm7qmsG/XNHh/+npvIh6b47d5Aam6oCHcx35r9Bo1ZH3Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6548 On 17.05.2022 17:31, Roger Pau Monne wrote: > Hello, > > The following series implements support for MSR_VIRT_SPEC_CTRL > (VIRT_SSBD) on different AMD CPU families. > > Note that the support is added backwards, starting with the newer CPUs > that support MSR_SPEC_CTRL and moving to the older ones either using > MSR_VIRT_SPEC_CTRL or the SSBD bit in LS_CFG. > > Xen is still free to use it's own SSBD setting, as the selection is > context switched on vm{entry,exit}. > > On Zen2 and later, SPEC_CTRL.SSBD should exist and should be used in > preference to VIRT_SPEC_CTRL.SSBD. However, for migration > compatibility, Xen offers VIRT_SSBD to guests (in the max cpuid policy, > not default) implemented in terms of SPEC_CTRL.SSBD. > > On Fam15h thru Zen1, Xen exposes VIRT_SSBD to guests by default to > abstract away the model and/or hypervisor specific differences in > MSR_LS_CFG/MSR_VIRT_SPEC_CTRL. > > So the implementation of VIRT_SSBD exposed to HVM guests will use one of > the following underlying mechanisms, in the preference order listed > below: > > * SPEC_CTRL.SSBD: patch 1 > * VIRT_SPEC_CTRL.SSBD: patch 2. > * Non-architectural way using LS_CFG: patch 3. > > NB: patch 3 introduces some logic in GIF=0 context, such logic has been > kept to a minimum due to the special context it's running on. > > Roger Pau Monne (3): > amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL > amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests > amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD FTAOD, while besides a missing ack for ... > CHANGELOG.md | 3 + ... this addition the series would now look to be ready to go in, I'd like to have some form of confirmation by you, Andrew, that you now view this as meeting the comments you gave on an earlier version. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:45:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:45:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331818.555423 (Exim 4.92) (envelope-from ) id 1nrGFJ-00067B-7o; Wed, 18 May 2022 09:45:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331818.555423; Wed, 18 May 2022 09:45:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGFJ-00066w-4w; Wed, 18 May 2022 09:45:33 +0000 Received: by outflank-mailman (input) for mailman id 331818; Wed, 18 May 2022 09:45:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGFH-00065t-Ez for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:45:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 410ea23d-d68f-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 11:45:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 28E5E21878; Wed, 18 May 2022 09:45:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A5EC7133F5; Wed, 18 May 2022 09:45:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sIgpJznAhGL/FgAAMHmgww (envelope-from ); Wed, 18 May 2022 09:45:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 410ea23d-d68f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652867130; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vgh2DJ2U6GGAabUnXtzA3pqoeQ6tzdrlj8IUMiOVaC0=; b=MPeHqxPN39ru+c2m2fBxTrsooSx7ryDQNBBfRRKaPUXWLZGgcx2Ev80j3tbuRtjfNlNp0H KtmtWiCwu4kBHVW13rvYrzyLgBOEc6eTfC/5wMFsJcf4w1YaQ8nkj3iP48m6MSJc7BpdV7 NtIREBFK20tvek34Y8M1Z6SnDggLdN4= Message-ID: Date: Wed, 18 May 2022 11:45:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables Content-Language: en-US From: Juergen Gross To: xen-devel@lists.xenproject.org, Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" References: <20220324140139.5899-1-jgross@suse.com> <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> In-Reply-To: <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------G0qgR06KuFB2qBY0T0ObdUAh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------G0qgR06KuFB2qBY0T0ObdUAh Content-Type: multipart/mixed; boundary="------------cnGKimcGzxMJGLHsV0PlSzxz"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org, Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" Message-ID: Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables References: <20220324140139.5899-1-jgross@suse.com> <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> In-Reply-To: <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> --------------cnGKimcGzxMJGLHsV0PlSzxz Content-Type: multipart/mixed; boundary="------------HqcUWNgB0A7sZ9zWfrVXDoRW" --------------HqcUWNgB0A7sZ9zWfrVXDoRW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDUuMjIgMDk6NTMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDE5LjA0LjIy IDEwOjAxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjQuMDMuMjIgMTU6MDEsIEp1 ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4gSW4gb3JkZXIgdG8gYXZvaWQgaW5kaXJlY3QgZnVu Y3Rpb24gY2FsbHMgb24gdGhlIGh5cGVyY2FsbCBwYXRoIGFzDQo+Pj4gbXVjaCBhcyBwb3Nz aWJsZSB0aGlzIHNlcmllcyBpcyByZW1vdmluZyB0aGUgaHlwZXJjYWxsIGZ1bmN0aW9uIHRh Ymxlcw0KPj4+IGFuZCBpcyByZXBsYWNpbmcgdGhlIGh5cGVyY2FsbCBoYW5kbGVyIGNhbGxz IHZpYSB0aGUgZnVuY3Rpb24gYXJyYXkNCj4+PiBieSBhdXRvbWF0aWNhbGx5IGdlbmVyYXRl ZCBjYWxsIG1hY3Jvcy4NCj4+Pg0KPj4+IEFub3RoZXIgYnktcHJvZHVjdCBvZiBnZW5lcmF0 aW5nIHRoZSBjYWxsIG1hY3JvcyBpcyB0aGUgYXV0b21hdGljDQo+Pj4gZ2VuZXJhdGluZyBv ZiB0aGUgaHlwZXJjYWxsIGhhbmRsZXIgcHJvdG90eXBlcyBmcm9tIHRoZSBzYW1lIGRhdGEg YmFzZQ0KPj4+IHdoaWNoIGlzIHVzZWQgdG8gZ2VuZXJhdGUgdGhlIG1hY3Jvcy4NCj4+Pg0K Pj4+IFRoaXMgaGFzIHRoZSBhZGRpdGlvbmFsIGFkdmFudGFnZSBvZiB1c2luZyB0eXBlIHNh ZmUgY2FsbHMgb2YgdGhlDQo+Pj4gaGFuZGxlcnMgYW5kIHRvIGVuc3VyZSByZWxhdGVkIGhh bmRsZXIgKGUuZy4gUFYgYW5kIEhWTSBvbmVzKSBzaGFyZQ0KPj4+IHRoZSBzYW1lIHByb3Rv dHlwZXMuDQo+Pj4NCj4+PiBBIHZlcnkgYnJpZWYgcGVyZm9ybWFuY2UgdGVzdCAocGFyYWxs ZWwgYnVpbGQgb2YgdGhlIFhlbiBoeXBlcnZpc29yDQo+Pj4gaW4gYSA2IHZjcHUgZ3Vlc3Qp IHNob3dlZCBhIHZlcnkgc2xpbSBpbXByb3ZlbWVudCAobGVzcyB0aGFuIDElKSBvZg0KPj4+ IHRoZSBwZXJmb3JtYW5jZSB3aXRoIHRoZSBwYXRjaGVzIGFwcGxpZWQuIFRoZSB0ZXN0IHdh cyBwZXJmb3JtZWQgdXNpbmcNCj4+PiBhIFBWIGFuZCBhIFBWSCBndWVzdC4NCj4+DQo+PiBB IGdlbnRsZSBwaW5nIHJlZ2FyZGluZyB0aGlzIHNlcmllcy4NCj4+DQo+PiBJIHRoaW5rIHBh dGNoIDEgc3RpbGwgbGFja3MgYW4gQWNrIGZyb20geDg2IHNpZGUuIE90aGVyIHRoYW4gdGhh dA0KPj4gcGF0Y2hlcyAxLCAyIGFuZCA0IHNob3VsZCBiZSBmaW5lIHRvIGdvIGluLCBhcyB0 aGV5IGFyZSBjbGVhbnVwcyB3aGljaA0KPj4gYXJlIGZpbmUgb24gdGhlaXIgb3duIElNSE8u DQo+Pg0KPj4gQW5kcmV3LCB5b3Ugd2FudGVkIHRvIGdldCBzb21lIHBlcmZvcm1hbmNlIG51 bWJlcnMgb2YgdGhlIHNlcmllcyB1c2luZw0KPj4gdGhlIENpdHJpeCB0ZXN0IGVudmlyb25t ZW50LiBBbnkgbmV3cyBvbiB0aGUgcHJvZ3Jlc3MgaGVyZT8NCj4gDQo+IEFuZCBhbm90aGVy IHBpbmcuDQo+IA0KPiBBbmRyZXcsIGNvdWxkIHlvdSBwbGVhc2UgZ2l2ZSBzb21lIGZlZWRi YWNrIHJlZ2FyZGluZyBwZXJmb3JtYW5jZQ0KPiB0ZXN0aW5nIHByb2dyZXNzPw0KDQpUaGlz IGlzIGJlY29taW5nIHJpZGljdWxvdXMuIEFuZHJldywgSSBrbm93IHlvdSBhcmUgYnVzeSwg YnV0IG5vdCByZWFjdGluZw0KYXQgYWxsIHRvIGV4cGxpY2l0IHF1ZXN0aW9ucyBpcyBraW5k IG9mIGFubm95aW5nLg0KDQpCVFcsIHRoZSBxdWVzdGlvbiByZWdhcmRpbmcgcGF0Y2hlcyAx LCAyIGFuZCA0IHRvIGdvIGluIGFzIGJlaW5nIGNsZWFudXBzDQpzdGlsbCBzdGFuZHMuDQoN Cg0KSnVlcmdlbg0K --------------HqcUWNgB0A7sZ9zWfrVXDoRW Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------HqcUWNgB0A7sZ9zWfrVXDoRW-- --------------cnGKimcGzxMJGLHsV0PlSzxz-- --------------G0qgR06KuFB2qBY0T0ObdUAh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKEwDkFAwAAAAAACgkQsN6d1ii/Ey9r Owf/cp4MHflNhWUdeLg9tP8B1EaucYVRezqaE7yUiQst6B4G6w1hHnTaewZCgol0Xz7eHGFmg/wq 6mBbV0ER3bK5rvt2e3UyqqKnBKEbWHS32pvssqKDYRSNgOSbgD3gV+aR2x87+wNPRJUncgMzzPZK F44PEnOz400KToMbOov9FT/qiTupjX37Y723Wu+iLr8AfyakNRWxAsfpXRqIOvUL6gaFEiI4PZgo VTPIm87znAS1gNYoa8D5d5ZFcFHsSWquvkd2X0ANma3B1b3nkYj90Q4JYXnI5jU1ZNEKht+4mWXh fyZJZZQyV5VNuOKUrdO0u/tjHU+Rzo1bu3hlZV3/yw== =CWAS -----END PGP SIGNATURE----- --------------G0qgR06KuFB2qBY0T0ObdUAh-- From xen-devel-bounces@lists.xenproject.org Wed May 18 09:51:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331834.555433 (Exim 4.92) (envelope-from ) id 1nrGKa-0007qo-Tt; Wed, 18 May 2022 09:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331834.555433; Wed, 18 May 2022 09:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGKa-0007qh-R1; Wed, 18 May 2022 09:51:00 +0000 Received: by outflank-mailman (input) for mailman id 331834; Wed, 18 May 2022 09:50:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGKY-0007qb-Mw for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:50:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03dff376-d690-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 11:50:57 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-nEJoR7bJOgmbtVTRDEU3Ug-1; Wed, 18 May 2022 11:50:55 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4167.eurprd04.prod.outlook.com (2603:10a6:209:4e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 09:50:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:50:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03dff376-d690-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652867457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TiBq3rSKFwFoChy+0aeR/S4A4vPjUy3GMdBcTlrBRkQ=; b=NZfzgQRgH5z1W4//+rfjolxL9/P7sjhvA5oGzGGaWm3pELAwFAoR9LjF8CPjbszcnF/GXm 5ME2an6/lHQwixY6Kb2FfGDb38Q9lcfGuB8vUfkrQ+BjGEhlGcsCYOJzkTiuqK5R28rbpu V/P+Fl2k2pTAya5K7UUH/dRRp9HuAIY= X-MC-Unique: nEJoR7bJOgmbtVTRDEU3Ug-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W1ZSNsLS7bUNv7Q2lUMNIG4DmMOZfC4j+96PKA9ISgCB72IUgEidQyHALffaUeld37MbmmE0+bt4V/Z8lILjqKr1q6gX9Cf1LYho6i0wbcBb7ASCjXRMeHndhTjiTus7lRZwo7jI0DlieNHz3X1ckBgxLHH7xKB+saVmvqeufUpqxcjUrz1Wi6j47kutIuQAJE9mwTa9IPGuMItPBZ93hfqL6GXCKGqHuM1oltMJQ3zIaKlzG7f7Au6Eq/lE9YoTixfUOiA/CE+Kjo84WvtkFz6tCCrGDNdC5dijLeXzG/ao+ZVg5khcV/WtZ0fSkxAUI3BCMYwPzPEDUNriBpI9Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TiBq3rSKFwFoChy+0aeR/S4A4vPjUy3GMdBcTlrBRkQ=; b=hKL+EpCXz3XAJbSj5BI+Gx1ye/7qLH8YDHsE8Za7yjDPT66F81DhNqvyRc/1R6AB9Q1NSb6xa7W164k7X3zGN7yGwammp0uK2KTcs/onJW7K5VCx3dgj3T5TY7tmlWafS3CMX18a5EuENNKrA1yq39RSm4t0bCct3LYKyVq/ignNwniSo7RQOQKzpiRAYr7fnb69U8K1QEXFFAPJxMa4l6KBQ0SKqDBC6MSaJYN0v9rEGl2uwx/tCxPb90nHl4ixvBuLS1EVUtQ2U6kQ7NdPY4Hp5mtjjFPa7ttPH66SAq1ZcIBJy/JgNy2FYtswguen7kLSqd53E+cRff9UcFgxhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c668df5-26a9-0c44-83da-a2d6081974ed@suse.com> Date: Wed, 18 May 2022 11:50:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables Content-Language: en-US To: Juergen Gross Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" , xen-devel@lists.xenproject.org, Andrew Cooper References: <20220324140139.5899-1-jgross@suse.com> <06edd55a-86f2-52e3-e275-ee928a956fdf@suse.com> <8baf689f-2a20-cf07-6878-9f9459063a25@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0111.eurprd06.prod.outlook.com (2603:10a6:20b:465::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cfab4cc-d953-4a9a-0294-08da38b3e552 X-MS-TrafficTypeDiagnostic: AM6PR04MB4167:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lZ6Vz1lo5ruITrtT3sy2su9L2cF6Fpm5bDg+oFn7B9hrBChCX4YLwjA+o/SyWPrJ7fRGR+moOpQZwNLDC1ZU5zqymdqyDG0L413Lev0WJYNedd/N2s6KAeWkoP0B/VRVGePiJVSa/xzk0FEEthGidYoOxI5vXY4oTWs50v91XjkChDQ54ML0LWoqyqJzmkwxYUkNxb0J19V91gzud28y760LlTgtiwedPoHrUqyfv6aDQPCFCv9s6OHvOMDZs9pCMlqoSDQuS4Rq6yyXjeS5HPnjBptdBupausvADJUvTLKmv/+ektH81BngVs+2rK0a4YDRIBb+Ida/lpiTz1WOIhX6VFwZ3O331HZUdRz6Z1yJURwop9QLfz3+ZnKIqCQsmZZ7XxuRKXOKVWgOufcIUvZfw5eZ0Xvp1A88j6QJMJlRnSf6qenLHWPsaM7T4CXvFnCgkyCPHrHSwTGXgPjJIpVNQinijle2Kku3zhCHemL9KGgjA9moV2/JCMaReifOg1sVa9YwEnvl0aGDa7xPyvBHpJtLTLSyXvYYiifgKX+liA4JpuGtKC7/6eK/eFi/gEzvcAcizOt0dAALBRyGP01XfeN51wZ692SUmtPOH5czMoU4bJ1+uf5CU1G2gYXCBmi1zem/+BQMg+CNj9f8zwpWCDghIj01QP+jIz/l0MyiX5QuwYfdYnufQ67UEFxnfziuoGRkZ2zYqmtR9gd141waFz1OqoeJJEG30QMYNY4A0iyRRA1dmLlafAZqpXdZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6636002)(316002)(37006003)(4326008)(31686004)(36756003)(54906003)(38100700002)(186003)(26005)(66476007)(66946007)(66556008)(8936002)(7416002)(4744005)(6666004)(6506007)(53546011)(6512007)(6486002)(508600001)(31696002)(5660300002)(86362001)(2616005)(6862004)(2906002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHl0YUY5Wk5mSllzV01ZMG8rQXcwSmZHRGJCcG5hSllKeXMxNGNXQ2tlQmNV?= =?utf-8?B?dXdTdkM3WjBJeHV1YTVGdzlUamNNRzVwT29oeWx2LzR3b21Fb2NacXVlT29l?= =?utf-8?B?OFJYVGMxcWsyM2hqaE9RUG5sYkxPcjlTMmFnTmtXUTlqRDhVd3Z0QXNDeVdR?= =?utf-8?B?S0JhNUFCQkZzL2N0Mnh2enpFM2J1Y21OR0dWTHBkVkdFK3MrN0dIczhjWUhU?= =?utf-8?B?VlkzZHAvcVRWbHp1YmdodUs0a2Y2NjdaaEt4NFpITWlPL3ltZG1Vd2RTSnNN?= =?utf-8?B?eFZ3Tm0rSFljeCtFUnlQL3phd3JKR1VlMUZaVU52VXgybGdQM1IwazdXNEhP?= =?utf-8?B?NWlPTy91Sm5YV25pWkx3bGJIcUpvVTBRM3ZRT21CaXlDRytoem9UTUM2Ui81?= =?utf-8?B?UnFxc0UxUkkxNDJlK3UyQjJGWS80aDc3UUV0blN1NzM1Z05OSmhFOG9neUpI?= =?utf-8?B?MHpOQTYvakhqNjFRRE1XUFhHcG13M2Q4SVJ0cWR1Q090QWphd1dKd2lEdm4y?= =?utf-8?B?Y2ZYdnpwS283RDJZQUtldk9zdFNXMnliZzhxaVFTTmNFODlUM25ieDdnUWJK?= =?utf-8?B?SHpnWmtKS2tOS1pWTDFoL2ZHbGUrdnowUTJOTmt0N3V5Y0l0aG9ockpkemt1?= =?utf-8?B?SFhqQ1REZDB4RjNRMUt4c3NtZnNRSkVHS1orTDc0TnY0TWR4QStQL2xxZnRq?= =?utf-8?B?OEtrRTdONE9mUmorSXdzdTE4YmJpUElnM2k4cXFKWmxWVmhHZGZFdDFFNUFG?= =?utf-8?B?dmNnSkFNU0kvRVBXbGEyY3V6MmFJVzl5MUZLa1U5Tk5KL01YUTNNeEV1K1Zn?= =?utf-8?B?SlZxeFk3VElhc1JEU3FKQjN4dXNTUXJ2Y2hmUDYrT0FUNTFvTEZQajQ2SG5S?= =?utf-8?B?VWErOXBsSXJhTkRXb2VDRUdwRFg5d1FSRHZHNTRJN2RuQTJTNTVtOGp3VXNX?= =?utf-8?B?K20zaDlnY0pFTi9PeWNWcWxpSDZ6eGhtdDdobjZQUElVK3poNVpvL2ZlUU1u?= =?utf-8?B?UHVLMUFNWEpGeEhHNGpMVVBROW52NFo2V0M2VG5BM0RpNC8ycEMyeGltL2Ja?= =?utf-8?B?djhIclRoNWZZcnVzMFdWeHN4T0pnZHVqV2pqQVJ6SlNHOW5tM1FSZXhzaC9K?= =?utf-8?B?ZkgvRDBOZHhXYU1PTm9NRlZ4Skx5TDNCNGtSRmRKZGtzLzdnelM0YVRkeTRK?= =?utf-8?B?UjJQd0tuVUFYUko1WVh4ZWtXcXRVWlc0VWg4VWpjR3V2MHl1TlRtc1NsdEVj?= =?utf-8?B?SkU1UG9HVWtxeTJwK1FvZnhIQmJjNXloOWZMY080Wm5PeDNQMjRzNDNISnhG?= =?utf-8?B?cWVwRWFUYlNYR2lyNDFST3lVOTZvc1M4M0NCTkNOL3lNa3R4cXdCWHlYS3pY?= =?utf-8?B?a0Z5alpFSExvamZISUlCUVIvTnJ6aFN5Q3hNWWd6WWlQekZlRWprdjdVUzk0?= =?utf-8?B?NXVRVk5QRCt5WGV6ZWtBTlY0V1UxQWhjZEdIUldCdGZnYmIxcFJnWFpkQ20z?= =?utf-8?B?RjlibGtFZDFGWnh4OHlsYytZODhmamZWSzQ2b2l4UEdELzdReVNQOGI1aUh0?= =?utf-8?B?S3k0TVJ4RkxzYkt3bjZMckZYZm5QOCtUZmNzWG1ucG9LV0Y1S211RFBpY2tn?= =?utf-8?B?KzRnSmJjcC8vUGRiRmY2TUsybjhkc0xxVW1sdXYwQ3RDL1MxcEdrVGp3VEdr?= =?utf-8?B?UVpLcEpFNzNtSnEvK2hWTG9VL3E1b1JNeXhvZGMwTFFTWUJadXFqUFBoVkI5?= =?utf-8?B?WTJMYkVZMzcwaysveEsybVdtQUhkRCtKNEJDK0J6a3hPZkJUNTk0WXpkVzBG?= =?utf-8?B?b0JBOWNNYnl4eU80MDBEWmVBNkpiQVNMazNQQlhKK0JvRWNmUlptOHh1c0Y4?= =?utf-8?B?VUJaVWJRY1ZEbXhzRmJQU0cxYXowT0ViTlZaVERZc1pUTmk5bUEvZ0hVaWg2?= =?utf-8?B?QllMU1JxQTFyc3NRWm43L3R4NzIxcytmZ3I4V2FDQ1V0QTdTL2RvN2Z6aW5a?= =?utf-8?B?eWRrWEdPb3dIQnFsUHYra3R4N2xZakFpanVDL3hCckdkRThyMVJmYlpQSlV1?= =?utf-8?B?eUJOTWtOTWhVYTNKUjI0eUFsTGNJblJlMm1EWUhzakNYTUNZbnVVaUszTElX?= =?utf-8?B?V08wdVlaWjZEVUhXOVVtdmwwUW1Md0ZocEJxUTZzQXh6YUZ5bGg2ZFQvOTlm?= =?utf-8?B?QzBvVEt2dlcrMEYrZDJHZVQzaHhpTjBoYlVxRXZDcnpRTmxHUUNsVVhGS2Rs?= =?utf-8?B?STY0M3BFZzBZVGNwSC9QaDZTWXdDMVVFMEpuVko4WFB6MkNwN3JHN01kNUtv?= =?utf-8?B?Sy9BOWhmVDdPWDVoQkg0ekh0b1drVkJuVlorUDZ0OUVGSGhBelh1Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cfab4cc-d953-4a9a-0294-08da38b3e552 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:50:52.5411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IxXiSx7+gP/TWRJvW0Js8zH1F4cWFXrIwYx6G49jWSWLGd80bwmstWD2vuMBJQRKg0OLKn7xhZjdIEVCuiWzGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4167 On 18.05.2022 11:45, Juergen Gross wrote: > BTW, the question regarding patches 1, 2 and 4 to go in as being cleanups > still stands. I would long have committed these (without waiting for Andrew), but patch 1 continues to lack an x86 side ack (which, as indicated before, I'm not happy to provide, while I also don't mean to nak the change). From an earlier attempt I also seem to recall that patches 2 and 4 can't go in ahead of patch 1. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 09:51:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331841.555445 (Exim 4.92) (envelope-from ) id 1nrGLJ-0008Rd-6O; Wed, 18 May 2022 09:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331841.555445; Wed, 18 May 2022 09:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGLJ-0008RW-3l; Wed, 18 May 2022 09:51:45 +0000 Received: by outflank-mailman (input) for mailman id 331841; Wed, 18 May 2022 09:51:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGLH-00089g-Im for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:51:43 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on061d.outbound.protection.outlook.com [2a01:111:f400:fe06::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e949848-d690-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:51:41 +0200 (CEST) Received: from AM5P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::34) by VI1PR08MB2925.eurprd08.prod.outlook.com (2603:10a6:802:19::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 09:51:39 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::98) by AM5P194CA0024.outlook.office365.com (2603:10a6:203:8f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Wed, 18 May 2022 09:51:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 09:51:38 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Wed, 18 May 2022 09:51:38 +0000 Received: from 4844ad5d50d2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04BA4D00-30BB-4199-B3E6-E2447BF20AEA.1; Wed, 18 May 2022 09:51:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4844ad5d50d2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 09:51:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM0PR08MB4546.eurprd08.prod.outlook.com (2603:10a6:208:148::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 09:51:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6%6]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:51:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e949848-d690-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Tooc3TRk8d1pt3dU9Wlu46SuaCaeXhN+O41DG+6bbvGHSBoTrWMqItvhV+nfWCQ4eLtGBPdChejrUaUAXAaw6ggPxnqWEXOzon98Y1rWHFA4Aj5U+3yslMkRQUYFRGBo23rxL/d5aDYim/BzevZYEvhhX4RIIcq1tLR/XG3unvuqorj54a8juzR1IZVY7lCxQYPdn7dr6TKBuvYQArzru15yHBscER2lLeF85VM8y2TqdpmgTWZLyP9EY5xoMypdqXlxjit21U1dtZKPKJBtKj+h8NC8PvlxPZaIvPEE5ooXoSWvkGQDAMgca4we1EQSTRX3lTlOZirY2YWn7eZ+PA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=k7zkqOUukw6MZ1E9nu3qmxYvr4pOZ4GTYkE5dYuktTrI4yETiM2vgpOBRu4i1hGsxOcTsZwGZ3QfS4Y90CuX5K8RBRD9n3pyrcatr7OARPLFJoMVTwXxMx27cD7C5buBVHqjI7cZlGHPxlb6gZ9RmBxc06pX7tzXzfvy8AnIGm43ahIVs7Puq50VYsu4smuFkr8hGYmtAdXwFMUVpLUu2azhOFJCAbXuJlNg6cbL5MVcGSlC8JZCzZ/YyzbRIdYdeTAHeJnLkEJzuSN5HBmzIPXGYnEnUh28LaSnF6mNgGNdwPMmePoDjt0do1QuiEkiIwV4p8VZARIR8qLACEDC4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=JOUCHsB5CpVhPK+nyYJlTv4wmcBGNGhKa64D2oNE6Uz3VtQ/X1E3TwxTUsu1wYeoKyMOvEttuks/Dh6OxDvrTlZPyFWUufSIy99bWmiVrBNLPYG4Hra1LoTZM+RQvwzLnIFr8sbvPG6Jr+vMB9BRr+a6TcQnzuwr4kF5oTKjGXU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RhnC7wImcM0dAcF8OT1MG9ahngODwJyALH+Lx3+WcSssn3SMLXvOTBYCVN60mZuRMxNjiC3PsIdrMQNTjHl0bzTw4pj9zlIHhx35MOk3+wayCQeTcQyJlgKeqfV3jfwqanagquFT52iAVfQvOaG5EgNiAAZCJZhNuJGr/0SsJofp0Obb00QQx04M6AYlWKtrnWuU27p8GSkn32KnaeQB0icC0wpedMkbF6QATcb8ogpmob74e2ee5/OYhYl2epkVYeBtNrjG0k9GrCi9IQiG64zZSs35Yu3x5r21uJtBAFcEM4vLbA1aQHEusyR/M31mwt1pQRnP1yhvj6YwknaUMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=HgEPMKn/e1u4rVTEQzL8AD996nEhZROg7h1WrtdcoKqk+gnicwfLvu8FBuGsVAtC/xSs0G/y9b7f2IbTxB8AhEi7DLGA7OhuB0mdNJWIc1lxCz0okL5ExGWjKzp/7dEsdS+l9dz69NpljuNJCNoj+6wP3tHNJOTb0CroCGIT7F/PjUqCd1tFWm4badmA5PNvDsi3n+IUnNDkyoEF/EPxdOI2LLE4HjWXfzaS+BV71PrueHgnlJ93gjFCX/Z2/NdSB/U9fWH9DD4c7ptUV/7BUEXTTxErGhGlLfMUvoFcug0TWxOiXWG+KqwfZ0C3ii5zr2kKx+XV1/08rMfyhDnSiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DOh5A7i9lGFJOjz3cXf56oM0PXfKs4c/dTM0+6GHCuQ=; b=JOUCHsB5CpVhPK+nyYJlTv4wmcBGNGhKa64D2oNE6Uz3VtQ/X1E3TwxTUsu1wYeoKyMOvEttuks/Dh6OxDvrTlZPyFWUufSIy99bWmiVrBNLPYG4Hra1LoTZM+RQvwzLnIFr8sbvPG6Jr+vMB9BRr+a6TcQnzuwr4kF5oTKjGXU= From: Henry Wang To: Jan Beulich , Roger Pau Monne , Andrew Cooper CC: Wei Liu , Community Manager , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Thread-Topic: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Thread-Index: AQHYagM6tDpJ92rV50ONWDPDxej1sa0kY+2AgAABBzA= Date: Wed, 18 May 2022 09:51:30 +0000 Message-ID: References: <20220517153127.40276-1-roger.pau@citrix.com> <6b5362c8-2a41-d2c8-b25e-2e9c421d6da2@suse.com> In-Reply-To: <6b5362c8-2a41-d2c8-b25e-2e9c421d6da2@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1CFB2696FC852645B69C9AC31A52DEFB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 91e8caf3-b73d-4fa0-e5aa-08da38b400d4 x-ms-traffictypediagnostic: AM0PR08MB4546:EE_|AM5EUR03FT015:EE_|VI1PR08MB2925:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LRey6OFt3x13rGXXmP9C0c2N6C1iA25od2ralE6L7xLqIwP0Tt7XcvziRNmnEY0XjLIqLbzo00Zqpxq0/++GqhEgpWmuUjTU1oUvtzh0otOvdGbW0zx4Iwz+wd+MWB0SiwGjKWRe1qwD8CMV1uEgtPWg6IPjHWpttIjRiuWrsa1LZdkQvWy9nk4BlY+U8unEwiBDJcLTOHvxjC+DdttIRpd7jsCACLZSFgrD4vTrXusUfR10WoLcy3YdL/WOLheL60UF6GxuHqBpcICMSqGJ8xE8ILd/9vfMJyAuwifdgAAZZi8762rp8zgeOEYXdF9piG6pysEfQClvfgBHq+/4L5Vnoi5MBt3nNYAVIDLPdNhOUIbUsNSqA2mdRq2jSSgvTVyzq+MZ5jqUwc9XiMm8STVq8bqrAOvmsf7hZXkafxCaa3jFa2TweRcgjLDBx+SrkFLHvIJoSBiTam45b9QDHxsKmyEfe5QCrdlgLMZgeeDHg36u9Q4kQN2mFiEA6mraCEnM4gV715BzQPdczf5hJ0cxFF2C1IVdgbnBIco6xCU40XBEHrmM+Wcgf6fXmdDl7hP5CrbzpzR56aIi/IjQXVUN6yERH/cTTD6MEvEYXOWFykSyG4iF5Kf5/dEaEi/7i188lUnNdLVTtt0NhSo0RKOq0BJ/4ahBMmXOXcmIKhHzi85or2kEVIznkgng+QQR8awI9xjs+/fgFldOm0RnAQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(71200400001)(83380400001)(316002)(38070700005)(7696005)(6506007)(53546011)(66446008)(38100700002)(9686003)(86362001)(122000001)(54906003)(110136005)(8936002)(52536014)(26005)(4326008)(8676002)(64756008)(66476007)(66556008)(66946007)(76116006)(55016003)(5660300002)(33656002)(2906002)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4546 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4e2f7271-25e9-4c15-2a4f-08da38b3fbd4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TCH1CQhBRS+PXGYmEPrl/dCskf0z8tY/0sLLukOoqDNYOntNXBGwowF6PqJcJn6s8DMxPqmNXuxNpg7OCeyrG6sV4WEi1MpIqq6oElLq2HyYz3961CXZICrKWUSGSK1lJFLQAq2Fj8MfMKtEkeL7ODui7BUDxLUDxR67mtVytsscTIauc8IVpldTybSP4TKdYYv5004xgiDGca+R+kHNXUweAs2CuMV2Oy5rQ9KCAsd0jDKvX2EgSgtGZRaMNN7/7hRfX8IO2tjH5BWTXC198LaoSOrqNbBYfNfaEneLCcwGg9RNSMO1xcmfn0/23Is/bGDRyecQOBXTnCKJs9A1FJvpplUhmL3DNQtxmDgFtfPCtu0Uvcnq8fSLveDPC+U6CXSoLFhPqvyUP0UNcEGRSD4KU2PnJr5mSKubIr4j3DT2twwHPZCgSC+FYaZeorOwvDIZqtptoz1kXxLz//Tni2Ij6d5mcHu6OoZeZ/gKtvSoZMCfZKxIwMOtYv+I2rf5yAEfa6unyIUH1M8+IXipjDpvHwVsLEZqqgVDBGgfV5PxbVei0RqH5csf1cCtRDikuUNoAKPI/MZJWENdSPwmx8jUqFgpHTGtEjlSZWQj/yf4a56aqcJIsE4vcU1e7AT+x0MUZzWvQ3deKAhvAmTyeHFUkCgtr8v/swpAgD3NZ6H9EJHvg25ZJJxKpdpiBJDs X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(40460700003)(8676002)(316002)(83380400001)(54906003)(336012)(81166007)(9686003)(110136005)(7696005)(4326008)(86362001)(47076005)(356005)(186003)(6506007)(70586007)(55016003)(52536014)(8936002)(82310400005)(36860700001)(508600001)(53546011)(2906002)(26005)(70206006)(5660300002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 09:51:38.4942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91e8caf3-b73d-4fa0-e5aa-08da38b400d4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2925 SGkgSmFuLCBSb2dlciBhbmQgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQo+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IE9uIDE3LjA1 LjIwMjIgMTc6MzEsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gPiBIZWxsbywNCj4gPg0KPiA+ IFRoZSBmb2xsb3dpbmcgc2VyaWVzIGltcGxlbWVudHMgc3VwcG9ydCBmb3IgTVNSX1ZJUlRfU1BF Q19DVFJMDQo+ID4gKFZJUlRfU1NCRCkgb24gZGlmZmVyZW50IEFNRCBDUFUgZmFtaWxpZXMuDQo+ ID4NCj4gPiBOb3RlIHRoYXQgdGhlIHN1cHBvcnQgaXMgYWRkZWQgYmFja3dhcmRzLCBzdGFydGlu ZyB3aXRoIHRoZSBuZXdlciBDUFVzDQo+ID4gdGhhdCBzdXBwb3J0IE1TUl9TUEVDX0NUUkwgYW5k IG1vdmluZyB0byB0aGUgb2xkZXIgb25lcyBlaXRoZXIgdXNpbmcNCj4gPiBNU1JfVklSVF9TUEVD X0NUUkwgb3IgdGhlIFNTQkQgYml0IGluIExTX0NGRy4NCj4gPg0KPiA+IFhlbiBpcyBzdGlsbCBm cmVlIHRvIHVzZSBpdCdzIG93biBTU0JEIHNldHRpbmcsIGFzIHRoZSBzZWxlY3Rpb24gaXMNCj4g PiBjb250ZXh0IHN3aXRjaGVkIG9uIHZte2VudHJ5LGV4aXR9Lg0KPiA+DQo+ID4gT24gWmVuMiBh bmQgbGF0ZXIsIFNQRUNfQ1RSTC5TU0JEIHNob3VsZCBleGlzdCBhbmQgc2hvdWxkIGJlIHVzZWQg aW4NCj4gPiBwcmVmZXJlbmNlIHRvIFZJUlRfU1BFQ19DVFJMLlNTQkQuICBIb3dldmVyLCBmb3Ig bWlncmF0aW9uDQo+ID4gY29tcGF0aWJpbGl0eSwgWGVuIG9mZmVycyBWSVJUX1NTQkQgdG8gZ3Vl c3RzIChpbiB0aGUgbWF4IGNwdWlkIHBvbGljeSwNCj4gPiBub3QgZGVmYXVsdCkgaW1wbGVtZW50 ZWQgaW4gdGVybXMgb2YgU1BFQ19DVFJMLlNTQkQuDQo+ID4NCj4gPiBPbiBGYW0xNWggdGhydSBa ZW4xLCBYZW4gZXhwb3NlcyBWSVJUX1NTQkQgdG8gZ3Vlc3RzIGJ5IGRlZmF1bHQgdG8NCj4gPiBh YnN0cmFjdCBhd2F5IHRoZSBtb2RlbCBhbmQvb3IgaHlwZXJ2aXNvciBzcGVjaWZpYyBkaWZmZXJl bmNlcyBpbg0KPiA+IE1TUl9MU19DRkcvTVNSX1ZJUlRfU1BFQ19DVFJMLg0KPiA+DQo+ID4gU28g dGhlIGltcGxlbWVudGF0aW9uIG9mIFZJUlRfU1NCRCBleHBvc2VkIHRvIEhWTSBndWVzdHMgd2ls bCB1c2Ugb25lDQo+IG9mDQo+ID4gdGhlIGZvbGxvd2luZyB1bmRlcmx5aW5nIG1lY2hhbmlzbXMs IGluIHRoZSBwcmVmZXJlbmNlIG9yZGVyIGxpc3RlZA0KPiA+IGJlbG93Og0KPiA+DQo+ID4gICog U1BFQ19DVFJMLlNTQkQ6IHBhdGNoIDENCj4gPiAgKiBWSVJUX1NQRUNfQ1RSTC5TU0JEOiBwYXRj aCAyLg0KPiA+ICAqIE5vbi1hcmNoaXRlY3R1cmFsIHdheSB1c2luZyBMU19DRkc6IHBhdGNoIDMu DQo+ID4NCj4gPiBOQjogcGF0Y2ggMyBpbnRyb2R1Y2VzIHNvbWUgbG9naWMgaW4gR0lGPTAgY29u dGV4dCwgc3VjaCBsb2dpYyBoYXMgYmVlbg0KPiA+IGtlcHQgdG8gYSBtaW5pbXVtIGR1ZSB0byB0 aGUgc3BlY2lhbCBjb250ZXh0IGl0J3MgcnVubmluZyBvbi4NCj4gPg0KPiA+IFJvZ2VyIFBhdSBN b25uZSAoMyk6DQo+ID4gICBhbWQvbXNyOiBpbXBsZW1lbnQgVklSVF9TUEVDX0NUUkwgZm9yIEhW TSBndWVzdHMgb24gdG9wIG9mDQo+IFNQRUNfQ1RSTA0KPiA+ICAgYW1kL21zcjogYWxsb3cgcGFz c3Rocm91Z2ggb2YgVklSVF9TUEVDX0NUUkwgZm9yIEhWTSBndWVzdHMNCj4gPiAgIGFtZC9tc3I6 IGltcGxlbWVudCBWSVJUX1NQRUNfQ1RSTCBmb3IgSFZNIGd1ZXN0cyB1c2luZyBsZWdhY3kgU1NC RA0KPiANCj4gRlRBT0QsIHdoaWxlIGJlc2lkZXMgYSBtaXNzaW5nIGFjayBmb3IgLi4uDQo+IA0K PiA+ICBDSEFOR0VMT0cubWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAzICsN Cj4gDQo+IC4uLiB0aGlzIGFkZGl0aW9uIHRoZSBzZXJpZXMgd291bGQgbm93IGxvb2sgdG8gYmUg cmVhZHkgdG8gZ28gaW4sDQo+IEknZCBsaWtlIHRvIGhhdmUgc29tZSBmb3JtIG9mIGNvbmZpcm1h dGlvbiBieSB5b3UsIEFuZHJldywgdGhhdA0KPiB5b3Ugbm93IHZpZXcgdGhpcyBhcyBtZWV0aW5n IHRoZSBjb21tZW50cyB5b3UgZ2F2ZSBvbiBhbiBlYXJsaWVyDQo+IHZlcnNpb24uDQoNCk5vdCBj b21wbGV0ZWx5IHN1cmUgaWYgSSBhbSBwcm9wZXIgdG8gZG8gdGhhdCBidXQgZm9yIHRoZSBDSEFO R0VMT0cubWQNCmNoYW5nZToNCg0KQWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt LmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 18 09:52:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 09:52:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331849.555455 (Exim 4.92) (envelope-from ) id 1nrGLn-0000di-JT; Wed, 18 May 2022 09:52:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331849.555455; Wed, 18 May 2022 09:52:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGLn-0000db-Gc; Wed, 18 May 2022 09:52:15 +0000 Received: by outflank-mailman (input) for mailman id 331849; Wed, 18 May 2022 09:52:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGLm-00089g-Jf for xen-devel@lists.xenproject.org; Wed, 18 May 2022 09:52:14 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2de378d4-d690-11ec-837e-e5687231ffcc; Wed, 18 May 2022 11:52:11 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 05:52:02 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by BN3PR03MB2132.namprd03.prod.outlook.com (2a01:111:e400:c5f1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 09:51:58 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::688a:5865:9209:5345]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::688a:5865:9209:5345%8]) with mapi id 15.20.5273.014; Wed, 18 May 2022 09:51:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2de378d4-d690-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652867532; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aOGDflMWIOfR5MxxCXCWhCTvA1AZ+nhFSl7QzeI64rU=; b=RgZKvdeKaxDZ6I5nMnq1408jmhJYUlIGhfMpGFN8gedoEBUp5smzXr1E ll1kMeqH+UNyMEwvfaJhhWWd/BNO+UP1XS8HBcUFD05u6RW+xUGV+AQgR +yPUahsw9yFzA/bGHq+ZzpIvKyBhnmfdpwKdxMPbb004GoMwDUz48GiEI E=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 71974411 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:N1vYu624II5BojFrBvbD5b1wkn2cJEfYwER7XKvMYLTBsI5bp2cBm mscWTrTbPyCYmbweNEkbIS/oU4EupHWyNI2SwNopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Xjb6bSgs1NZfHs94kFCh2Fgd1H7V/reqvzXiX6aR/zmXgWl61mrBFKxhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfyVvLe03x9p7ixKNfvSe csfLyZodhPDSxZOJk0WGNQ1m+LAanzXLGQJ9w7J/PNfD277lil295fyNfrvVoLaHflFtE2Ag EL54DGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRokqjUNsZJ UUS8ScqqbUa/VauCNL6WnWFTGWsuxcdX59bFLQ84QTUk67MuV/GXy4DUyJLb8EguIkuXzs22 1SVntTvQztyrLmSTnHb/bCRxd+vBRUowaY5TXdsZWM4DxPL/enfUjqnog5fLZOI IronPort-HdrOrdr: A9a23:Hw41FKyDeAjQfoo181T2KrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm12Mw+N57y6 5FxGSfqt5eCg7Bhj3045zSWwhtjVfcmwtrrQaC50YvLrf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="71974411" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4no75c9D/1fvtvDdb4rCPIaVR+2pMyMT4sEQFWOAwr2G2NL6kiiXYXSzpDLYeBOy9HJJgjsu+kluFoJVmN5cZ9lBacG3TbUJ88+Pwgoe+KTBlbCK6Yx67wwHsegLWtVJ+8duVS1GgvntC+cTZD7GNJOGATyVmZFyG3svzxj/7VKfHfNGaea6a0U4T9MrEl/T854+ntdiCctVF8D44cqNmECZjgZapjQY4OgiBUKlShhag0c/xz/wjMeRiXGrByP94KauJ8SBVfmS9CPM/LLwKAA5twX4EAFy50VjqMXcpW9M7FZpvRXbEk9g+SBDiFDGGkwDYiI7ctDpx5Bmkl9PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aOGDflMWIOfR5MxxCXCWhCTvA1AZ+nhFSl7QzeI64rU=; b=dbspFz5GO+fdr3HNUfWwW4bO8N//CWjGSL+UbIkrereMyapGghnmQQlb2RyipHciVuNsgU29Dip3W6kH/MDv0IJQxTYN7lLl1mnmGjppPeldMD21EcKMTCLk4DsTLBu6UF4qyQJuHKF/uik7CndSTYU+2wlBIM+pTi+OT+GiIVYAyATeKRj+LDuJPV+5/E+znxQ8PxNzUm+YS61BBWlgGf8KgwWjgWzWgWPAN7HCzYt8/FqBP6IPOJh9pLF7bjJsujQbHViEC7v71Uzf3J7WA2HYSv/hYB5DTWHWaz8FtrxGHiVT0G7mt42zULjhNigPkVZzUBOqK4bg2bhqKfUe+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aOGDflMWIOfR5MxxCXCWhCTvA1AZ+nhFSl7QzeI64rU=; b=e9DhdzHUFIcmJzdcC+B1EQZdMyW4DPa/+yN1i+OYv78xJaHf+s0MHjSmhIIVQFeiQh/H1yIEadLBB9JQHl+PxglyXpYkZn58LwxER1Z14zAqX6liOvtEKCbSh0q2Bopn5ARsWh/W873lFu7bRfG6tAZzMKColPKX1oWwBDa+kJI= From: Edwin Torok To: Andrew Cooper CC: Xen-devel , Christian Lindig , Luca Fancellu Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYn6m40FzHJf0irMsT2T+YW1K0kZYcA Date: Wed, 18 May 2022 09:51:58 +0000 Message-ID: <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> In-Reply-To: <20220517194113.2574-3-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9de03cc8-426a-4688-30cc-08da38b40cc3 x-ms-traffictypediagnostic: BN3PR03MB2132:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s178+LlA37Xc/IbanAJRxeJBbFSOLhOHj5JPs9IAUMuffd1isbk3KdqTlSBqFjaomPVgunn23Aw3C+QecOl7brO85ad0+6tkQ1lWpcy/PehKjVvvCJ1M9lnmAY7eBxMyy2xEaAcOXR9K0LmVE/EHvq8nhj+CEFeKv5wdPK1pjIZ00kzzfhQjWwa4k9o5Qxd4D1bEaCNFGvjyULgGcs0VVT6hZY/SqK9sPJ9z6rqB97r9GUhPme0yrlgrUiB+AYKlgGn5Zhjijt3gqkqHiznM9MMGf2vIFUnHvQo5+AD3+q4sMg4KZ4OXrcYyHrG5joDF0bfyHmLhHgp3SegBf/sbmF2dYlyPdnM6T0WDHlkyznOiSYkR1XJyqUDq8aKwOyhl+CY6ohwmZjil7+3CExVt6JoRCxKNAMh9m/SxfNVBhGc3UIiHGXyov2m1TWce2Ab8GPyskm1gsTaX/e92zuBOdzNKKJTR8phSjmriZqprT3pEKy/o2k7VleCZ/ga41zjhv1g0CGxuMOE6Bup7PwEMQBzmYnw/oCJukzhBlTXw2keLvy/azcX3+rFZc5UCE1nM6qGRcY1cWLpqUfjauwKSiDUvs6c71befj7I1ECDciVBv1TiT05lRj7PIIAlf+teGLX89A9zbBLhHtT6X1/ATuZJGKHkyNlIYNmEirh1uaz3F/uRPjhw0kIFtc0Vt8Ejg/VqkFnyHAoHCfNYZKfFoW/nt5O9jfImYVmVQmbLtwzW00NHTQ9q6Skw+gljdFU4E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(2906002)(6636002)(37006003)(54906003)(38070700005)(66446008)(316002)(38100700002)(122000001)(64756008)(8676002)(4326008)(6862004)(82960400001)(66556008)(66476007)(5660300002)(91956017)(8936002)(76116006)(66946007)(186003)(66574015)(6506007)(36756003)(83380400001)(53546011)(71200400001)(26005)(33656002)(508600001)(6486002)(6512007)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cHVDRkJsOFlSMWtIY1gwMVFXb0tuZERFS3lkRklYZUZCUzg4UTVIcFc4NlBL?= =?utf-8?B?VmNjUHMxMU93Y0ZHN0NIdnRBOUhKdkhqamJ2S29iYjNISWpaMzRucWtvQkt6?= =?utf-8?B?R0FuN0xDWndSOGV6OHpOOGNaM2cxQzk4YnFpYXFhZndBcEZPNVFGMVQvUTNN?= =?utf-8?B?QlYvN3hRZXpYODFPUlhFKy92cGRpaW5vOEhqaExWOEpGNk0wQkRmb2gydXgw?= =?utf-8?B?ZEVYSWNTZ01RMGVRUHVjZmRIeVB1QWJmV3ZzaG5xaEkvWG5DdHJGOUlldjlZ?= =?utf-8?B?c1pSbG9SVTNvWjF5VHFTNk04TjA0T3lpNkoyQ2JOZVBNUm42K1pXZndTTDRh?= =?utf-8?B?eG5OUitqbWx0Uk5JUm5hK2k2QnZZMEZFbHZQWXMzTEZxSHlhMDZ4NzIzOC9S?= =?utf-8?B?bWpOL2JlZ21RMEZMSlNVcFhBZDBla2JpdWNqcXQxaXVtTm5pTnpVZ002OGJ3?= =?utf-8?B?bm5QT3RHM2RxWEtZeGZVL3Fackdpd3BGb242YWR6dUplU0NLeHBYTTgzb0F2?= =?utf-8?B?Zno0MkFwcGJodUZySjBHMWhLMGg1cWVvNVBTQTVIbVlQbU1iREJla3BwcnJh?= =?utf-8?B?aVBuUUI5am1ZSDhMWnZPSnpFRUxiNkNXVExtajJJTzVpWk9VMTlmVEd2RDVV?= =?utf-8?B?Ymg2RjlkVVNjbVNtemk1ZGJVUi81cHUwVFhWcjlGNE53VDVGRW00UHNZR1ly?= =?utf-8?B?SUV3RG5kWFRmR3lSMWlSa0dTajh3Kzk0NlFwSGpKY2lyVnc3eWllbEhsR0l2?= =?utf-8?B?Z1ZKQ2ZnT2E4Q3VFRTJ6UXVCSjFPdko2WFFEdXo0Nit6cldtbFd4WnFObnJp?= =?utf-8?B?aWFMMkxRb2IwQ0pPZFJXRmRLeGhwQjM3UGcxSm84Q29WMGloeHYrMm9GUkJJ?= =?utf-8?B?M1NpdzZGQVQzSXRZK2ZNRmtUUUFLMkhHU1QydFpLRmZnbURsZThzUHBlVlV3?= =?utf-8?B?U3ZqY01pU2dTNGFVdjZTakVheHIwOUM1d2hjalQ2aGwzVWp5UEJTOFErVllx?= =?utf-8?B?SGdSRDJvL1hSN01ka3ZaNk9xTmR3Y3BDSWJMMnhnSlcvV3lhbFZEelhHeTJa?= =?utf-8?B?TDZQNmJiY1Jzek80UzFEdmRtOGZUVTBIaktTZUQ0MnFWLzZuaFBDUUhPb0VY?= =?utf-8?B?c3hvSXJNNVZBUE1iVVY2aHpGVHRaTUgvQVRNNytNN3pKOU43aE9kditZQTFm?= =?utf-8?B?WE0xamF0a1hjaW9BK040MkpLOUhnblJIeVJtckcwbUw4aTVVb1BFdnFhL2E4?= =?utf-8?B?ZDZnZjFoZXd2Vnl2TjNqL0FhZktGazFkL1d6cXNCclBLbS8vWFRsUEo5blNX?= =?utf-8?B?QTFoR3RtUXhoYkNEK201VmFyWXpWRHBvOFZMUmF3anFiYTNpcUtyYjNiVUJL?= =?utf-8?B?TDFTUnk2QktLTWdjNFlEbzd0Skllc01IQi9nNkJMTm14UUhXekN1K3RsMW0w?= =?utf-8?B?bHc5NkZ3S3d2NTExSFZGSEQxZjlXMUdvQUpvSU81RXFlU2Z3WHcxTFlicG1v?= =?utf-8?B?NUJSRWRiKytVOXI1MEdKUXdUMW5FNEJpendwNmMzcERjWk1qVU00d0hZd0g1?= =?utf-8?B?NlVOWUJLdTZSQzVoN2xRenNUZnlzT25IeE9mZk4zZjgzVEk1U0lvUzVacHVJ?= =?utf-8?B?WE96d3NSTzd2WXFMRmtublU2a0FycitDMTZMbE9xZWFUSVdNQTVMY1lDOW9i?= =?utf-8?B?aEtydSs5UFh4Rm5sTEMyTWFMNmpyUU0raEtDSGcxZUh0SzY2K1VLUXE0QWE1?= =?utf-8?B?L3hxRFBWOG1xUy93c1FmOFpSVUh5U1dGTnZIVytKTmlwUE1iQlovMTdyRStl?= =?utf-8?B?akV1R1plOU5NbFB4TkVnK2tsTzhLUDBqN2JqYXZGckUwSERRRjR6Ykp2RmRa?= =?utf-8?B?YmlVUlBMcm9xR0JOOTJxbVFkaWpPaW41UjFnZTd2QlE5RVBxYzcvYnl6OU45?= =?utf-8?B?V3FETk5zSmxjOGZWV2c2Y1V5OUNJZlpadWhqZElYWUFmWFQwa2lnS0RVWmYz?= =?utf-8?B?bEZWVDVUSUV1T2VlYTdMNXAxZVQvdTRYTFdvMS9ONTdzR1N1Nms1TkJYYlg3?= =?utf-8?B?cnRpL1d2dkpLckM5bFN1K0VQaVhrLzNLc05LUVZyNWFFZ0hOaHZuRmgreFhy?= =?utf-8?B?VXE0TmNqRjVKUUVJTnMwMWRtUjljWVZ2YkU5bVlNbG02YkRETzVKK2N2RzNF?= =?utf-8?B?SERLYXNVSlYvRTlYUTROcFFVd3kwMmNYdFdscytmVDhwcnFNV21uOEdHUUhr?= =?utf-8?B?bXBIVnR2OU0raUdWWU4vLzEvTGZ1WG5ZMzZRQTBCb2NvNGtmTnI1WGRzS2tw?= =?utf-8?B?cjZhdjdCUlVSbGNoRU4rSUJ3cHEvSXhEaEQ5TkI4QytVc0ZlcEdIYjVxYi9G?= =?utf-8?Q?8D3EWGiqXv6LVIzM=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9de03cc8-426a-4688-30cc-08da38b40cc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 09:51:58.5264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kZMTTx2AMGBJzp4eZYkkLDSZ/V9qSRPgjXjBuJ0C8LLgNq8VbeAJwJpgRWOuudjbGJzvFgznGG0CoUEjNfMNpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2132 DQoNCj4gT24gMTcgTWF5IDIwMjIsIGF0IDIwOjQxLCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IFNhZGx5LCBjcHVwb29sIElEcyBhcmUgY2hv c2VuIGJ5IHRoZSBjYWxsZXIsIG5vdCBhc3NpZ25lZCBzZXF1ZW50aWFsbHksIHNvDQo+IHRoaXMg ZG9lcyBuZWVkIHRvIGhhdmUgYSBmdWxsIDMyIGJpdHMgb2YgcmFuZ2UuDQo+IA0KPiBBbHNvIGxl YXZlIGEgQlVJTERfQlVHX09OKCkgdG8gY2F0Y2ggbW9yZSBvYnZpb3VzIEFCSSBjaGFuZ2VzIGlu IHRoZSBmdXR1cmUuDQo+IA0KPiBGaXhlczogOTJlYTljNTRmYzgxICgiYXJtL2RvbTBsZXNzOiBh c3NpZ24gZG9tMGxlc3MgZ3Vlc3RzIHRvIGNwdXBvb2xzIikNCj4gU2lnbmVkLW9mZi1ieTogQW5k cmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0KVGhhbmtzIGZvciB0aGUg Zml4Lg0KDQoNCj4gLS0tDQo+IENDOiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGln QGNpdHJpeC5jb20+DQo+IENDOiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29t Pg0KPiBDQzogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPiAtLS0NCj4g dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sICAgICAgfCAxICsNCj4gdG9vbHMvb2NhbWwv bGlicy94Yy94ZW5jdHJsLm1saSAgICAgfCAxICsNCj4gdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j dHJsX3N0dWJzLmMgfCA4ICsrKysrKystDQo+IDMgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwvbGlicy94 Yy94ZW5jdHJsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+IGluZGV4IDc1 MDMwMzFkOGY2MS4uOGVhYjZmNjBlYjE0IDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC9saWJz L3hjL3hlbmN0cmwubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sDQo+ IEBAIC04NSw2ICs4NSw3IEBAIHR5cGUgZG9tY3RsX2NyZWF0ZV9jb25maWcgPQ0KPiAJbWF4X2dy YW50X2ZyYW1lczogaW50Ow0KPiAJbWF4X21hcHRyYWNrX2ZyYW1lczogaW50Ow0KPiAJbWF4X2dy YW50X3ZlcnNpb246IGludDsNCj4gKwljcHVwb29sX2lkOiBpbnQzMjsNCg0KV2hhdCBhcmUgdGhl IHZhbGlkIHZhbHVlcyBmb3IgYSBDUFUgcG9vbCBpZCwgaW4gcGFydGljdWxhciB3aGF0IHZhbHVl IHNob3VsZCBiZSBwYXNzZWQgaGVyZSB0byBnZXQgYmFjayB0aGUgYmVoYXZpb3VyIHByaW9yIHRv IHRoZXNlIGNoYW5nZXMgaW4gWGVuPw0KKGkuZS4gd291bGQgaXQgYmUgY3B1IHBvb2wgaWQgMCBv ciAtMSBpZiBjcHUgcG9vbHMgYXJlbid0IG90aGVyd2lzZSBleHBsaWNpdGx5IGNvbmZpZ3VyZWQg b24gdGhlIHN5c3RlbSkNCg0KVGhhbmtzLA0KLS1FZHdpbg0KDQo+IAlhcmNoOiBhcmNoX2RvbWFp bmNvbmZpZzsNCj4gfQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVu Y3RybC5tbGkgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpDQo+IGluZGV4IGQxZDlj OTI0N2FmYy4uZDMwMTRhMjcwOGQ4IDEwMDY0NA0KPiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hj L3hlbmN0cmwubWxpDQo+ICsrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCj4g QEAgLTc3LDYgKzc3LDcgQEAgdHlwZSBkb21jdGxfY3JlYXRlX2NvbmZpZyA9IHsNCj4gICBtYXhf Z3JhbnRfZnJhbWVzOiBpbnQ7DQo+ICAgbWF4X21hcHRyYWNrX2ZyYW1lczogaW50Ow0KPiAgIG1h eF9ncmFudF92ZXJzaW9uOiBpbnQ7DQo+ICsgIGNwdXBvb2xfaWQ6IGludDMyOw0KPiAgIGFyY2g6 IGFyY2hfZG9tYWluY29uZmlnOw0KPiB9DQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvb2NhbWwv bGlicy94Yy94ZW5jdHJsX3N0dWJzLmMgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1 YnMuYw0KPiBpbmRleCA1YjRmZTcyYzhkZWMuLjUxM2VlMTQyZDJhMCAxMDA2NDQNCj4gLS0tIGEv dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4gKysrIGIvdG9vbHMvb2NhbWwv bGlicy94Yy94ZW5jdHJsX3N0dWJzLmMNCj4gQEAgLTE4OSw3ICsxODksOCBAQCBDQU1McHJpbSB2 YWx1ZSBzdHViX3hjX2RvbWFpbl9jcmVhdGUodmFsdWUgeGNoLCB2YWx1ZSB3YW50ZWRfZG9taWQs IHZhbHVlIGNvbmZpZw0KPiAjZGVmaW5lIFZBTF9NQVhfR1JBTlRfRlJBTUVTICAgIEZpZWxkKGNv bmZpZywgNikNCj4gI2RlZmluZSBWQUxfTUFYX01BUFRSQUNLX0ZSQU1FUyBGaWVsZChjb25maWcs IDcpDQo+ICNkZWZpbmUgVkFMX01BWF9HUkFOVF9WRVJTSU9OICAgRmllbGQoY29uZmlnLCA4KQ0K PiAtI2RlZmluZSBWQUxfQVJDSCAgICAgICAgICAgICAgICBGaWVsZChjb25maWcsIDkpDQo+ICsj ZGVmaW5lIFZBTF9DUFVQT09MX0lEICAgICAgICAgIEZpZWxkKGNvbmZpZywgOSkNCj4gKyNkZWZp bmUgVkFMX0FSQ0ggICAgICAgICAgICAgICAgRmllbGQoY29uZmlnLCAxMCkNCj4gDQo+IAl1aW50 MzJfdCBkb21pZCA9IEludF92YWwod2FudGVkX2RvbWlkKTsNCj4gCWludCByZXN1bHQ7DQo+IEBA IC0yMDEsNiArMjAyLDcgQEAgQ0FNTHByaW0gdmFsdWUgc3R1Yl94Y19kb21haW5fY3JlYXRlKHZh bHVlIHhjaCwgdmFsdWUgd2FudGVkX2RvbWlkLCB2YWx1ZSBjb25maWcNCj4gCQkubWF4X21hcHRy YWNrX2ZyYW1lcyA9IEludF92YWwoVkFMX01BWF9NQVBUUkFDS19GUkFNRVMpLA0KPiAJCS5ncmFu dF9vcHRzID0NCj4gCQkgICAgWEVOX0RPTUNUTF9HUkFOVF92ZXJzaW9uKEludF92YWwoVkFMX01B WF9HUkFOVF9WRVJTSU9OKSksDQo+ICsJCS5jcHVwb29sX2lkID0gSW50MzJfdmFsKFZBTF9DUFVQ T09MX0lEKSwNCj4gCX07DQo+IA0KPiAJZG9tYWluX2hhbmRsZV9vZl91dWlkX3N0cmluZyhjZmcu aGFuZGxlLCBTdHJpbmdfdmFsKFZBTF9IQU5ETEUpKTsNCj4gQEAgLTIyNSw2ICsyMjcsOSBAQCBD QU1McHJpbSB2YWx1ZSBzdHViX3hjX2RvbWFpbl9jcmVhdGUodmFsdWUgeGNoLCB2YWx1ZSB3YW50 ZWRfZG9taWQsIHZhbHVlIGNvbmZpZw0KPiAJY2FzZSAxOiAvKiBYODYgLSBlbXVsYXRpb24gZmxh Z3MgaW4gdGhlIGJsb2NrICovDQo+ICNpZiBkZWZpbmVkKF9faTM4Nl9fKSB8fCBkZWZpbmVkKF9f eDg2XzY0X18pDQo+IA0KPiArCQkvKiBRdWljayAmIGRpcnR5IGNoZWNrIGZvciBBQkkgY2hhbmdl cy4gKi8NCj4gKwkJQlVJTERfQlVHX09OKHNpemVvZihjZmcpICE9IDY0KTsNCj4gKw0KPiAgICAg ICAgIC8qIE1uZW1vbmljcyBmb3IgdGhlIG5hbWVkIGZpZWxkcyBpbnNpZGUgeGVuX3g4Nl9hcmNo X2RvbWFpbmNvbmZpZyAqLw0KPiAjZGVmaW5lIFZBTF9FTVVMX0ZMQUdTICAgICAgICAgIEZpZWxk KGFyY2hfZG9tY29uZmlnLCAwKQ0KPiANCj4gQEAgLTI1NCw2ICsyNTksNyBAQCBDQU1McHJpbSB2 YWx1ZSBzdHViX3hjX2RvbWFpbl9jcmVhdGUodmFsdWUgeGNoLCB2YWx1ZSB3YW50ZWRfZG9taWQs IHZhbHVlIGNvbmZpZw0KPiAJfQ0KPiANCj4gI3VuZGVmIFZBTF9BUkNIDQo+ICsjdW5kZWYgVkFM X0NQVVBPT0xfSUQNCj4gI3VuZGVmIFZBTF9NQVhfR1JBTlRfVkVSU0lPTg0KPiAjdW5kZWYgVkFM X01BWF9NQVBUUkFDS19GUkFNRVMNCj4gI3VuZGVmIFZBTF9NQVhfR1JBTlRfRlJBTUVTDQo+IC0t IA0KPiAyLjExLjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 18 10:06:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331860.555467 (Exim 4.92) (envelope-from ) id 1nrGZi-0002Ra-TL; Wed, 18 May 2022 10:06:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331860.555467; Wed, 18 May 2022 10:06:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGZi-0002RT-PV; Wed, 18 May 2022 10:06:38 +0000 Received: by outflank-mailman (input) for mailman id 331860; Wed, 18 May 2022 10:06:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGZh-0002RK-By for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:06:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3362c0bc-d692-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:06:35 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-cm6aBcIwNfuowiyQc9eFKA-2; Wed, 18 May 2022 12:06:34 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4018.eurprd04.prod.outlook.com (2603:10a6:208:57::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 10:06:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:06:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3362c0bc-d692-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652868395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ZqUn5MEY1N+3Yu+HhtPw9nOEFIALZ6u6SYJer5eMJA=; b=l/qbQ5aVCgsJ20TAmgdZfRVnnClHQ+8Ft31t6cbIQolXyC5u/VaYLAGBvqGwCdWfLi99Ul GXo5l7rNwAfZMwoBcCGbm1rISdIM1QnWI0ApvOAkEkyzUhmX6BSMI9xpsb1TNA0ZjF1j4C X/IY8/NhuIX4fAV7ttsft75B6sKUsww= X-MC-Unique: cm6aBcIwNfuowiyQc9eFKA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECd1cm7Ub2lLO1tVuzqgTJIXmCLVSps2MzePAUFxFJwvGdGy53XaJta4F5HphxentgEnvIQBhiZlc736qPEHBBl+Uz11jBHksJBOScYaGJELtmyw2M4fl6Zp/y/SEa6cXSeqqCmDbqLaQ3v2WeIkTdnjKwdqhLtO+HGfOskroPp8EyuXyhgISFxBhbNyd8jdhAnG8Gb7MosVM19iY+Qc/vC2HFWedDSFMEm0+bTXOJp2YYK1XBzygsml6UY2uRbIavFG9sycD/5eZbRpek2J1VFAYrl43QyyOUDNC0YQ8LYyMmmivqeQKEYwswZA6DSd9aE4h76P9LM8IpuCoWn7YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5MIoE4F+YawzN1HinJ+m5r7g+dvKmgWA6WAMxPKzu9c=; b=ZOPmCUjmMA4QskkBrWkpzSVsaOfO9DdJQp23VTDJHT+BLST4hDpqw05DbeQENp25x2Aqhd0X4ZCI/khe3iMhJnzn/0HYpsjfH+Y/raShq/ohVJwUaXjVXTCNafy6R2TEh8F8pK1S6FCsfhy186buTD9z4gTo8CdJtf/xbaDdqLKtJnQ/Rc/dhFr9EXVxGoAXFnhoCsHJ6cB21UUyM8/cqvJvvaohtZHgpLjONF2iQ8Xjisb3UtbBUoKETs66saVzrzJeoMs3VKVoWiCP1vtUJZPRF+rcAEDOK84PtNNUsMtE+pyyxKV1Spcft/XOl409eAbGQVwkdizl6n2OzUKtow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80487976-5d72-5388-139c-422210bca73b@suse.com> Date: Wed, 18 May 2022 12:06:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5638b79-1bcf-4f56-e231-08da38b61555 X-MS-TrafficTypeDiagnostic: AM0PR04MB4018:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9BqcEtRRQi1YG5WBiUPpfv/PLQ6iI0/pnmDajU2vNKUqqkke+VNIsLDpz5Xum25GC9i5KA/fveSQxb/El2cRZTkIpZiQdJqTyOqowtHnrc2UY91dXWfu1slR0NK6ynhxY8JKR0ELvbyphbUOjYEviEz7HTtzV3n3AvkGbFfKIyiG2/+jEtFBxRsY9G7Flv25JcYT0Kpw5KeOtML8MF5LMb0J0k7r9Ln0Talps55n8lcFkWA++dYGgw9P3FR84XWdAATfDSLXvNXd1A4aZyXWFPPp1lSBR2UR5wjvHz2smLLjQRutix9QGjYDej8a7mMWt/mQrJz5kDdXz/kA/JOocJA4m6zH6gtJIRPGLqAa0oe4yYDC0I1axnmHkM959viyWfIBeryl9YnEJIjso4oxPhMbURTH4mkbYTvWiQdMjYglexGAWuwUIpvsGi3tLir6MzSX4mC5zxOwtRYxNnL2VbbtY6kxmVDTF5qh0VZKkBnpCtOf9BvA84oluWDieAGSEbafDsAUB7fiQ0uD0ZWKFch5alHovqm/TOKXZH05LW6KtrI8tek3Qhig1PTR7FcT/+4rBR6psHLqH0DAmeQ+eX2NZUZi3xyhOpytukD235fLwTdZeHj5DgTK6Z/c+4ZDKfB6pxpzUn67D0ZoXjr4K4PmYAkiGX7xqDOSlXTgO6kSGXDtw2+8PHYWsAAdlum4/ChLEkOyXVwUpj1+E2HzsbWgYsS0SAX4G5m3W4XL/5jkauqK+kKFQkDR2pAHJCXz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6512007)(53546011)(508600001)(83380400001)(186003)(6916009)(6506007)(31696002)(66946007)(26005)(66556008)(8936002)(66476007)(31686004)(316002)(36756003)(5660300002)(2616005)(6486002)(86362001)(4326008)(2906002)(8676002)(6666004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xL5jU7mnHFK3CvrjfhhuanKx+uTGnjpjKgR18xRKooSQhK4HdfhKEc6HEN6V?= =?us-ascii?Q?H4owemn4w2eK3yHBL65bjcU6pvOTfkvb5CfwT6QQP/tzP7AlDgfxMnPH70Nr?= =?us-ascii?Q?57VLwVuu786/w2NtJM/xyrqzrAlw06RFbnQTMwkWlseQbPswhSaLSvkO8WSP?= =?us-ascii?Q?l1HoJndV1evwLyaUi6wlOROw+BakrwQPYLqj2nvzSxgrKFe63RIqeAdhaYvB?= =?us-ascii?Q?okTLPseGSLtb+CrRilTyXNF5PrDs8aOTTBrbhLDPbwcHscxv0vLzbi9j+1it?= =?us-ascii?Q?eq6043OzpzEg1UMj9I2CBqghaDILK3ZIjeTZESor+zlSrDgxhJp2rz/CVA5Y?= =?us-ascii?Q?a+UXceBEOSianuYCOhDFPzwIN/+J2BcduOEroHsK4m+/wlz0nkcPgy3AzbUm?= =?us-ascii?Q?Gr6S9GOorrNBoxtpwrwof75ZVAiCneitwaCrGCyoIfAcUKoksCYOLYpDhtAj?= =?us-ascii?Q?deLoKPQUS4u/RpQn79sEhB9h2F6/P5DtFQdEONNAnH6evhZHnSSKLgifr8yO?= =?us-ascii?Q?dy9bFbgFSkyUAvoA1VKbEgUGZHE1KBH97qdfHt0uBAs1mtQcahTJihT8wy77?= =?us-ascii?Q?cDtQA2eWrO+mI40ByzmGkIGvtJdUUx4xSPSuqely1aD7rGx5Jqsr70JGvklp?= =?us-ascii?Q?/n9dncye9Mnc0+d6INKQHgYoMj3XjZEHoNKKpDZ/qBIYOquqrCzA7MFIO3N8?= =?us-ascii?Q?b7b63ipdiSjBnVxPtZGx2HmLCNyLKKuOVEtR2B02DIrfEscgwkxvrmOa9TOE?= =?us-ascii?Q?0Nr/uNjjWNvznSZb+o0Z7tVV3ON1PKPUvq8RtpakIhuhAISEWIYcEKiSLCbY?= =?us-ascii?Q?PX2WvsjVKsq8G1xAMl8VXlA42PqFxAQ10CCfgnQDOAxvBC5Tk4RV5jJjp/2M?= =?us-ascii?Q?7jZrW4+6LxSBA6Fg9wJqTVkE6VNe0KR4pFuW+T/3U2wWugLUq/qi8wpU07PJ?= =?us-ascii?Q?pUP0Np7FGmxDpMn8DzWY1SO+AzusZFb7H9nbOzgYdIEcjUP2iupGRB9O5EE/?= =?us-ascii?Q?V9p3YLfsnXRmaS4EGSknxeWbkpGdap7j0/JCMxcivXkuIo5G2drAkivN52k2?= =?us-ascii?Q?+vPCebhHWSBL8TmRi1qtlMBSob1xtSIhzSkriwjktc+j78RLdXijTTPDYhT1?= =?us-ascii?Q?WowJsIn0Ik2gN/Uwb/3GtfjTVMOjUK4g3p2f2oS88qS0KwrUw+TvHadON92q?= =?us-ascii?Q?Up5+PO3gLvBOgaF1Hg+H5fOZ6niEPMj4Oykxth/8Gosmofu8dWNNKPmf3D0B?= =?us-ascii?Q?yQaNVp6MPkQ7t2joIKlW1MWcZKVhffYws1iFh58yjbaNY2cqBbtY420xoPNT?= =?us-ascii?Q?nZ5id8E6c+aEkWDINTjzLDUYuUT6Y4BV9DM6daE7r2gMd9kMsTwt0FNcw6Ux?= =?us-ascii?Q?kimMGV4Rn+DPXZDLXMixIXFmdbKE7tzO+Q6DzhpstDzplzoSTX86D9vRRt2W?= =?us-ascii?Q?RFY5jy6lDe2rS9s0CGT7K23VItSB4FwAOLvutGhBp6FmUvXyFKGf2qvX4ATG?= =?us-ascii?Q?1YbO3LPyJN+b9hZevnTHxT1wkYCTbQJggBDAGyIu1BeHPFL22EH1I9/bGnLR?= =?us-ascii?Q?hHULd/X5YmWL31kMriQhfHtyLgWiEAqweo0uqz6KfNvZZoCDOWNSzOaJJPti?= =?us-ascii?Q?c5nSB9aqI0piOjqPjxOfvcmqzengbotYZOk2nEol8oWYAi82LRv504wRLiv1?= =?us-ascii?Q?vL0t8PfeiaODyHYTwduAo/k2HGv2nm0NWo2JszIbF+Dg0ThPGpkqc2wv9g8/?= =?us-ascii?Q?2scQSDI2nA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5638b79-1bcf-4f56-e231-08da38b61555 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:06:32.0749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uhY43hFgijx9HJJoQPAiEoK3otcBFG1lRnsuNpr3a/dY0c1nxlYbmesjo1MfmYw3ByHqdLcTfRfjZfbFvKH5OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4018 On 06.05.2022 15:25, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/pt-contig-markers.h >> @@ -0,0 +1,105 @@ >> +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H >> +#define __ASM_X86_PT_CONTIG_MARKERS_H >> + >> +/* >> + * Short of having function templates in C, the function defined below = is >> + * intended to be used by multiple parties interested in recording the >> + * degree of contiguity in mappings by a single page table. >> + * >> + * Scheme: Every entry records the order of contiguous successive entri= es, >> + * up to the maximum order covered by that entry (which is the number o= f >> + * clear low bits in its index, with entry 0 being the exception using >> + * the base-2 logarithm of the number of entries in a single page table= ). >> + * While a few entries need touching upon update, knowing whether the >> + * table is fully contiguous (and can hence be replaced by a higher lev= el >> + * leaf entry) is then possible by simply looking at entry 0's marker. >> + * >> + * Prereqs: >> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 >> + * contiguous bits (ignored by hardware), before including this file, >> + * - page tables to be passed here need to be initialized with correct >> + * markers. >=20 > Not sure it's very relevant, but might we worth adding that: >=20 > - Null entries must have the PTE zeroed except for the CONTIG_MASK > region in order to be considered as inactive. NP, I've added an item along these lines. >> +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, >> + unsigned int level, enum PTE_kind = kind) >> +{ >> + unsigned int b, i =3D idx; >> + unsigned int shift =3D (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIF= T; >> + >> + ASSERT(idx < CONTIG_NR); >> + ASSERT(!(pt[idx] & CONTIG_MASK)); >> + >> + /* Step 1: Reduce markers in lower numbered entries. */ >> + while ( i ) >> + { >> + b =3D find_first_set_bit(i); >> + i &=3D ~(1U << b); >> + if ( GET_MARKER(pt[i]) > b ) >> + SET_MARKER(pt[i], b); >=20 > Can't you exit early when you find an entry that already has the > to-be-set contiguous marker <=3D b, as lower numbered entries will then > also be <=3D b'? >=20 > Ie: >=20 > if ( GET_MARKER(pt[i]) <=3D b ) > break; > else > SET_MARKER(pt[i], b); Almost - I think it would need to be=20 if ( GET_MARKER(pt[i]) < b ) break; if ( GET_MARKER(pt[i]) > b ) SET_MARKER(pt[i], b); or, accepting redundant updates,=20 if ( GET_MARKER(pt[i]) < b ) break; SET_MARKER(pt[i], b); . Neither the redundant updates nor the extra (easily mis-predicted) conditional looked very appealing to me, but I guess I could change this if you are convinced that's better than continuing a loop with at most 9 (typically less) iterations. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:09:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:09:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331868.555477 (Exim 4.92) (envelope-from ) id 1nrGcO-00033r-Az; Wed, 18 May 2022 10:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331868.555477; Wed, 18 May 2022 10:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGcO-00033k-7y; Wed, 18 May 2022 10:09:24 +0000 Received: by outflank-mailman (input) for mailman id 331868; Wed, 18 May 2022 10:09:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGcM-00033e-Fy for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:09:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95ed934e-d692-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:09:21 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-phaPU4NtMpioekGm-fc6_A-1; Wed, 18 May 2022 12:09:19 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8139.eurprd04.prod.outlook.com (2603:10a6:10:248::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 10:09:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:09:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95ed934e-d692-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652868561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkgZtXx6a+UcBAE5MEq2ynW+KS4zJPKx1gWljVIDucg=; b=XMOsu7uF/8/Z4CKKj7EmNBGfQGdPO/ZyIF0/c/3JIa9gEMWrIHUVWUWJdMlK0POnKHoTe/ QbJc9exbm3iCapPvGMvNQCmODSHr8uLJ9qkQBIkEYr7ZKIB6W4rcsZnDer5F3MGSKoNX9l UGqGgt9tcJ0w9XGNXYv59yqsfWlBdfA= X-MC-Unique: phaPU4NtMpioekGm-fc6_A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ydc5AAVORM+XvrV149e1kwPzF5adXGNH+6IdIWWbFPjgtMIyyAdklrWuIsAjXHADDVFcfk32q1k47FOx2LX6LW0wFp24P8Iy6hGkMas6qfJZKXnQL3r9XxFJX7SHxvVpH44GghXz0NmuvDtDnniamz+/dTlEoyZ2ESFiIdJJ2tVbG8ougq+ng6ofD6QB0InnCDdi9k/I6NioMDoK4Qsaqj+orpnYsfCR4ZvlVpBGgImjRPA1l9kSDGx4/kquannNBFbC7DgsqsQMDXAB5atBlPlEshvB2C3bEqlK33jdWKrEt/zd/fYeBWdhv0SrWBpZ18GrbWjHsBITYwBHWEXEjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wkgZtXx6a+UcBAE5MEq2ynW+KS4zJPKx1gWljVIDucg=; b=cHdR8+Od/aciy5p5xX1nuucMZk1qpdeDIRCPuiBx9OPolzZwbFxhGB4Bxr7Hjx3heCK0jD66aomhwRl2Yhxr56NauW8yoSD4Fcw7XtfcBzwJNRsfO9UX8vU9uLFVdyblrNJbblh68BKIQOSBhQW03bCfpupiBg329CQn0yjn9f8A2I3e7UTBEqpcBQ2a+4iHAnLDGOdVXqpCf0/EzFeuHl0dSE7BZdAIMhezYAVshUU52DqW9XoI7fxt9jFSbey9iIywi/0uREnNTYX/y/Q5EukMzZBJJhln8N1bNsxJ96z2kBQvlWXrQg0Y+4Yxagn/t8//L5BKYBBf5QxyKuVbpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <17f8215c-7b8e-1c10-350b-21a9dec64d82@suse.com> Date: Wed, 18 May 2022 12:09:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: Henry Wang Cc: Wei Liu , Community Manager , "xen-devel@lists.xenproject.org" , Roger Pau Monne , Andrew Cooper References: <20220517153127.40276-1-roger.pau@citrix.com> <6b5362c8-2a41-d2c8-b25e-2e9c421d6da2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0016.eurprd06.prod.outlook.com (2603:10a6:20b:462::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 815bc73f-eb54-41e8-53d3-08da38b6781d X-MS-TrafficTypeDiagnostic: DB9PR04MB8139:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bq6AaOy7U0VqHZY2eK9aGbtIDaILKLOLA2fNUwWsxyQrwfrzdqAwBB582YjKtkpbGj1oAfAsk+70SFBmSKC0JzGH/x1k0GnLzd+0szWRTx8zoazxuWUtbYfvxF/OMnMVSta+J7CfjRlO0jbi2s4YGpcZF/PJT9k6N/zqBh2n8xGuwBs7ACEHqe1DQgOF1FrlLTMgn/yP+rIzBAHVajhJjeqIDl7BAt7nndiw25FjiUBbtMyhZzPuMGxhkAZ8L49uNL+AEHSbZNhYK15RDe4cndgE1cNuMLtLBVwhrDUO8aOBZ9DW5bj3QQmqGSngk21uje1q30nmNUdSNKZWQhQ5SkBRIx15+Vo6hoDcPjAsgNIM5y7f8FoAyQQqTMGSF4iQYHCGzAnK3Ag4DoMrr90cRdnLqyWgqhfpPVab9AXgWfThg0gLUOzcpuXTVN2I/3pNFiZFf/zSQpo/9/gO5lUO/nx1iMWqXMZIsJWMYx0jh74G6FIOhmn0q6dhtXjCUArU/dPtRyC6m83eWdJn2ES+CoGN8X6Ag+1qROB+ODnXj9ODQJ+voU2ItxB9VQU08Mh//hFg5MiMGFVFjL81Vrhoadm/QdXs1H5EZUFIF29kUI7eLnS+qdvq7GR422NUQlP881CUvb3qxMO3glqlBLcmP3EPKzeQK/hU7c3rBEeEP2olPEMw7vHLdLxtkt6zKZmnmqGPOuY7DJm/NGa8KSKtPycmtJoObr3z39Z1UE8QXa+FgkSmbS6rAmmWy/Ga2Ta6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(4326008)(66556008)(66946007)(2616005)(31696002)(54906003)(86362001)(38100700002)(508600001)(66476007)(6916009)(26005)(53546011)(6512007)(6486002)(8936002)(83380400001)(36756003)(31686004)(5660300002)(2906002)(4744005)(6506007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTNhSmpWS2U5d2Y1VEsrVjBNWE5yYnUyUEpqcHl0Zm5IMkNWNHFJTlhIVEZQ?= =?utf-8?B?RnFBMlhkcHZmbDlzZE5pUEZhRUl6WVpYTkVJelI1R1kvV3hWV0FBcjNLYmZq?= =?utf-8?B?WUorVDRCVXg4VW1mcTZuUTdGQ0FKUWk3VkF3RzlHcnpoWWRJdStoTWRwUHhW?= =?utf-8?B?MDJDeE1zbExlTHRVdm8ybkx3anNVcVlZN1FJRTUzc244TUE2SWEyNWJNWWtN?= =?utf-8?B?cStQTFVscVA4MmV5aFJaQ1JWUGtkTVBjTmM0OG9Sb0hFdFpkbHhmWitkR0Jk?= =?utf-8?B?TWs1aS9pd3VSMHRzSUxwaXVLNi9CbWlPM2gxQU55L08xL1NyS0x2NGFoZnFl?= =?utf-8?B?bmxVa0xMRUNKOHE3WlRoT3BUMFBRL1ZZOFV1TVc2RU1xN015d2FNOUpQSUt4?= =?utf-8?B?eHJ2MDc2cm5NOTYyZWFOV1RydWc1VGo1ZTNCWmtRZkVUTzkwcDdvaloyL0Zi?= =?utf-8?B?WEcxNzlvb1lkWmt1aWlxam92NGdFblphVGN3YzRlMkQyQzFTbm9vdXo5Q1lH?= =?utf-8?B?UWFKZElYQlh2NlhPbkdUUE5hWXVYb1dYMXRUeExxME4yK2hiUzlnQzNhSmtS?= =?utf-8?B?WGM0Qk5zdmFQN1dIdy9raVcwa25SazZXS2czUERXTkxZY2I4MExQWnFsOUo3?= =?utf-8?B?ZVBQZEZiVHFrTWpCUStmK09LYitVRktTTHFzbjRQRGJGYm5RbXhvWWd1REVt?= =?utf-8?B?RFk2OVh2NW9CRVNqeSt3YkFXS3Bhem1xaExyd0svSXFCbGRrNmJpQWZLYkll?= =?utf-8?B?K2tTL1FTaGtscmpBMll1WFlqRmV5TFhRQkxjUjBucmgwNitUUXFVV0xVYlZx?= =?utf-8?B?VjBTb0VqdnV1TG56THRLL3lJSTIzcVVRQytlN0QvUkpMWloydEZ4M293czBm?= =?utf-8?B?bFZITmdLYnRjcC96MUFYZEt4YXdkdFc0RmNZYThEM3BGM04zVWhBclhpMjJH?= =?utf-8?B?NXV3Qk5LNUhTRUdDWDQ3M3FpRWxkVWc2OTV2V2RLSW9WRmhaQW9lMEd0WWIz?= =?utf-8?B?Ymx2T0luY2tnWHVOYXpFWElJSWJnUEdTanlYSGgzTjlIV010Vld2Mm9xdndh?= =?utf-8?B?VUhiQTNOdG0wK1NCUFUydUt3WjYrYUhHOG5waWJrekM3NDhJZGVMZmYvVzdF?= =?utf-8?B?SnIrVW5hTENXYVJzUjR1Q0ozRjlJYkx0VDJhZ1d5OFBka0d6OVpKeW01dytZ?= =?utf-8?B?NjAyTGt2WkkzbFcyZXYwMkY2NUtBUzJmeVVGYlQ5eEgyMjc2SklFdkM2cGV4?= =?utf-8?B?SGNiOVRRajhGaEprbnBIVndBT1JGTHdrajhOZE9Yb010R1JadEJFcGgyQ1Ax?= =?utf-8?B?QktRaVI2OXZlMFZYQ0xmeXk3Kzd4bklLT2tDaDh1U2NOQUJGYWRmY3p4R3o4?= =?utf-8?B?VEZYa2pjSUQxUVdKZVkxTlB0b1BoVXlNd1BsWVcwRVBlbHFJdi9HOWcwU1My?= =?utf-8?B?UXNITFZMZWZXVi9QT1E4SkJZM1dpVFJ3ZVVCakhlbmhiMTR1UnlzSGZrVytE?= =?utf-8?B?dkpHYzBaVjMvKzNTQ1c2dnA3cjl4ek9XTGpWelV0NmlVaWhUYXBIRVNrRWow?= =?utf-8?B?b2hjVDRocXFZdVdpM2Y5Z1hnWWcvK2ZhWUROSHRDaDZWdUNCK3ZHMEtDa0Yw?= =?utf-8?B?K0Jsa3Z3TWkranVkK3ZpT2F5SisyNUNFSkZnK3RBaG1uQjlYeXhXMmJzdmlP?= =?utf-8?B?cElmRkRzMzdraHU4Y1JDaHRBbzBtWUtWNSsya0trWDM0dWM4NEFwSlFLR1Ux?= =?utf-8?B?b3o4anNiKzlINGhyTjZDZ2Y5WEMybGRCczB3QkJaRGFDdzlvSVArck05NUk5?= =?utf-8?B?bmw1V21kWVovUXQ0REhSRmRpRyt0enh2aUd5TVVHemRuWFJGQzBxNXZBcVZi?= =?utf-8?B?aVI0cFBjdS9xcE9DblVkTDZ2YVozQWYycnREZEtXQjFDOFp4amZYNGVmOGw3?= =?utf-8?B?S1M3L0lmOEpwNGlXQ2V1RGoybWs1bnh0b05mSlhiamtldWJoUmZ0b0ptZHh5?= =?utf-8?B?TUFGcXBiNUdNSlE5WE01L0dyNGE4U3pibkw2T3hJaVVxVnlEdVFtM0VYUHg4?= =?utf-8?B?R0cxNUtWNmFPV3Rtc3gyTllzbUdEWG9oNi9WZkliWXR3R0NEUDRBMUNJSDNL?= =?utf-8?B?K3g3RDIyYjZGZ1RKZ0QrUTVoUzkwL1lWc3NRSXI5OUxVZlY2N3VIbEJYczlU?= =?utf-8?B?WFZUbHRhQXpSWEVFdDhGMnM2c2NyRlZwVk1kS1BVNGJTbVJNR1JRYVJxRnc4?= =?utf-8?B?US9vbFpDc3NCWGgxQWFUMkxRblRDclplTjJWcGs5YTlieHEzZ1NVUWtsenJQ?= =?utf-8?B?VmtRTUVPcU9BNnRLRy9qZ3ZoMzRETGZjZEVwM3NvWGJKTGRIYWcwUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 815bc73f-eb54-41e8-53d3-08da38b6781d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:09:17.8143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kTYK+GpHcLkEeMsFgDUIpmoN2W1kvKhUoHUqKS20J5cXb+hO89aGI/PbeUSf71H/EM3HugTdQULYlvRf4msieA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8139 On 18.05.2022 11:51, Henry Wang wrote: >> -----Original Message----- >> From: Jan Beulich >> >> On 17.05.2022 17:31, Roger Pau Monne wrote: >>> Roger Pau Monne (3): >>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of >> SPEC_CTRL >>> amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests >>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD >> >> FTAOD, while besides a missing ack for ... >> >>> CHANGELOG.md | 3 + >> >> ... this addition the series would now look to be ready to go in, >> I'd like to have some form of confirmation by you, Andrew, that >> you now view this as meeting the comments you gave on an earlier >> version. > > Not completely sure if I am proper to do that but for the CHANGELOG.md > change: Well, no-one except you actually can ack changes to this file, as per ./MAINTAINERS. > Acked-by: Henry Wang Thanks. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:13:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331877.555489 (Exim 4.92) (envelope-from ) id 1nrGfx-0004aK-0C; Wed, 18 May 2022 10:13:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331877.555489; Wed, 18 May 2022 10:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGfw-0004aD-Ra; Wed, 18 May 2022 10:13:04 +0000 Received: by outflank-mailman (input) for mailman id 331877; Wed, 18 May 2022 10:13:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGfv-0004a7-GB for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:13:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1878c773-d693-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:13:01 +0200 (CEST) Received: from mail-dm3nam07lp2045.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 06:12:53 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BYAPR03MB4375.namprd03.prod.outlook.com (2603:10b6:a03:c8::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 10:12:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Wed, 18 May 2022 10:12:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1878c773-d693-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652868781; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zE2ZrqxLLy74i9pZ8mIIWuhGBGnwzixKs0TeOHb4F24=; b=IGPh0gnbzWAAohwnYO4iocBUChVIMuJhYkWO02lRmgpCEyonx1EKZWBl Jw/+3AnK/CkiXj55VMHJYcb/AG8i1Ms5Xe/9n1LLDKsF7iHSDaarYbp4o Sfgox38onTByb+ctAOGRMCzGHXhwxFvZJ10QvTx53USoQ2IW8R8IasVgc E=; X-IronPort-RemoteIP: 104.47.56.45 X-IronPort-MID: 71439409 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Q4YCa67gTFz9UY3CkTduAwxRtFDGchMFZxGqfqrLsTDasY5as4F+v mUZXGrTbqnfYzajKY90PY/jp0gFuZHRztdrHAM+qig2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgU1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTuUTt5GPDQod42DTlxHD5eGL9H2I/YdC3XXcy7lyUqclPK6tA2VgQaGNZd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4MFtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK/PZssjSLnWSd1pDOa+XScOSQGP5ng3SK+ 2Pf03X0UgsjYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3L 1Ef82wgpK45+UivU/H0RRj+q3mB1iPwQPJVGuw+rQ2Ikazd5l7GAnBeFmIcLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:zutUzqORn9xS98BcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="71439409" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKgu+hzf+FOmCcJqzkQjJXlw1uht9sg4LLEpg6SQxasATvzfdHxSEXZ15rxtw9TQlTsfYJcTMsIAoZCn0zsxCZf4R/HorPAueprq6036/z9q7I/QwSmSHc17iXVwgYRAmJdvcUchHgbt5LyX5tpkgFT8aKV94yoZiAf/SZNXdynbf97xIlUjy/SXyKDab6c/pEq43d5i/Nb0QgVV4IZ/6V47bLxJAu2bar1egEHpo5kyRv1/XDbI0pw365fvTRB9WkIHT6EojhIawg/YYB+09vCkJ4nSa0/Ywf2SHtXdQ6QF/gWgQirculz5+rxRN50y01UNyrONRGnbn0Sl8FihdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zE2ZrqxLLy74i9pZ8mIIWuhGBGnwzixKs0TeOHb4F24=; b=JgtCgfPJnhf4S06wIvlfVF/6WTsZsK61XeTLraoeX+tivqR7KF6RWWdL2aSoOoFWLRsIGpQWkOWoCn1FYFTeMSOffKbSU9EcOCJzAtKmqFFVk/SzEpQRpd/ebFD/Pp2QDA2wDRhOcCVVD8sxFY9MaCInIcrBcceVRKTfVVJhmWLO+w3lzN6uKazolQ5ij/cLV198Tpqjbprc1ph64ftV1/Bi+9Wva6MJwIhbx2uezMpEseRcf7xuqGMqgi9l48xkG2tSRd1kpP+rzS7ROVuXk55n4/YRe1gVVCEEDUG1ioK5vufE+7s8bqr8rXgPdbbGXLLOVxanO/v755JJFGfJxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zE2ZrqxLLy74i9pZ8mIIWuhGBGnwzixKs0TeOHb4F24=; b=xmJZYG9qo2e1j5N8Vo1ZA+HkSHK+lB4F7D3LJnk7AjmDy+eHuW2XaVmatPKNgn+WUuSAQ7tRc62lq5vVp0hW7fpOiCebN0QFayhShQy2WwQmU4y7sTaTWFEXTJQSHzMvMX79AHF1RpQi49RwBFqSvEJetuJ1jxx8kw2DI6kxc14= From: Andrew Cooper To: Edwin Torok CC: Xen-devel , Christian Lindig , Luca Fancellu Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYkF2Fwt7YEY0iLRkyR5qKZ760kZYcAgAAF1QA= Date: Wed, 18 May 2022 10:12:51 +0000 Message-ID: References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> In-Reply-To: <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7ef0047-5edf-47d4-abf0-08da38b6f74d x-ms-traffictypediagnostic: BYAPR03MB4375:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IdqCwzqkrNNZ5xqHNt+3wljG7cTui32RXChOyYGI5vgss+SVql+zYV5thgMtu8rXS1vATtf+AI5aPZihYSaPqqE+cDcWYvZjrPLSuexIdamlKplwoQ1mf14JP54LbzpWmKjowoYx6R+JfZblpyUZgvkWXphkXhizTj19kYOnwXrN2keK20ed3m5RUACYaXAOMnspeXIoQcJqohU+XOZWGcNgE0rWqlWqZP4bmzjAuhngy0SRz3MpwspqLAb5L6y21jN6UVUflqfR7GwCubWwvqA5MuA/zf4ZTMHbpk/uzjT80QVr7AJwKMNRJ0JKJexitYov9QVArlcgvNG7NIU6pecq2YpgU3Uxh2NvbOeMMIyyZlOLFnqWCwzVSXHnkSFacqubRMCasq4Spq1RfIu5BGa8aa0wMUkZ1etl6VQbw8hvpjRieczqhDpcNVIXq8D20X8gzcCWYXmfoQtJrAlIytjuk3tQ60jcvWp0F3PvwplwQ1s3xDSLdcBjqM/0/JPqWlON71wl3cfNkqsA6eZd/OqHNEZg/0MCVgV8V0emUptAgy30/EYp7qQe6tezaVeZf/Lsk91rs0Swjyy3xOh7xRY9vCaOdkUY1AQvvjPZWswug4IvdStFU5RDpKG4na64MQVAys6oVgNXo37xzVwiLv1+5r/G1VybknvyOTAAYmwsql8suuXcs+LBDkFwXQfl26x4ZO9IfhLngHM0Q3z7zL9CSlgvMHAwhPo319UvjzXcCmh6Bq3zYuHplrPkVPVDZCe0hx1QGONQISJPXyO7Gw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(53546011)(6862004)(8676002)(4326008)(66556008)(6506007)(91956017)(38070700005)(66946007)(76116006)(38100700002)(55236004)(66446008)(64756008)(82960400001)(186003)(71200400001)(36756003)(122000001)(6512007)(31696002)(508600001)(8936002)(5660300002)(54906003)(31686004)(316002)(6636002)(37006003)(26005)(66476007)(2616005)(6486002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VjFVY3RkcDN4eVRWS2dsenEvNGdBK1BrK0ZtYTFmOTNYTGNVTGx6REZBV2M2?= =?utf-8?B?OFk3TTNSdHp1VTVHOThwbGVOVHR3ZXVOaEY0ankwd1pkK2VUall1MmJBQXZM?= =?utf-8?B?S21pN25ZQ1pkcmZMeTlCMTZyZ0NiRFBHYWxSVWFyc0VYL25pNy9NLzhQRDBt?= =?utf-8?B?b2RmWDg0MVVKeDRYemhvS2ZLenFDUDIybUdtazNVZk02a1V3and0VHM1dldS?= =?utf-8?B?aHRBb3l6NGhhK0NzVnFLNk9yMWNRSEhXbG1zVU5zcHJEbW83NjZ3ZUdXUTl2?= =?utf-8?B?YXpCZG1hZDVvaUJ2bU1GRDBHdEpJUlZHT3lCRmw5RE5PS1ZJOTFyQWZtQjhC?= =?utf-8?B?WEFTZExIRWI5RVVjQlUxYVdsY2tDMFVjYjFvTWw1ak15UnhFZVBBRjBYd1FH?= =?utf-8?B?MFZoMjhYT1JHZ3VqVkdlTWZsN2NUS2FuT29wQnRVTE1YTldIWjRLeUZyNkph?= =?utf-8?B?bWx2QjRjRDVENzhnaWZ2VnIrTENtdEhVNi9WeHkwem5taVZzYUZaVFVwMU44?= =?utf-8?B?RVUzZStzZkJkdXhXeUpWSjNrS2owdGxNdk5XV2ExNVZPZ0NCbWorN0dSOG8v?= =?utf-8?B?UFV3d2tsQXZOK08yUHdDYTlEeVBscnZjZmVFRUh3Y1VQQkdFUnBTcFF2OGg3?= =?utf-8?B?WFVycENscWpUTWdUdUg0dC9wRGxwVjVrV2ZEbGdyVmdxZEFlVmhUWkxhbFcv?= =?utf-8?B?aENwMlpSMzRCL0RFUlpVL3IzbmdEc2lYU0Vxbk9SeDROQnk5V2lBYkEyTGo2?= =?utf-8?B?WkVjaDhPLzg3V3FyNmdtRHRic1B0bGlldnhSY25EaVBxMkZYREEzRzN5ZjJW?= =?utf-8?B?T0p5RVB1b2FOUjIxMGhiZEE3ODc4TE8rbXRTRTliajZzY3hrbm1tSmdyMzhp?= =?utf-8?B?REdnaVVwNG92WHc5WTZtb3VCZUwvV2RiTFVZTEt1L3hzQ09MRi90b3BUUFRy?= =?utf-8?B?SVl0SzI0WXhWcmZZa2FVb3puUnRaUnZISGNwQTVFa2pFSmhIUm1Qa0JMK0d6?= =?utf-8?B?WitPRGFycjFuS2lYMWcxaVIxb3k5eU9HTHJzK09RbHN4OWJhc01qYmh2R0dO?= =?utf-8?B?ZDd0R2hPMFlSK2NVZVBzS1pCZC9lM1pKdlA3NldZU0l1N1hOR0tWQUJKZ0Rn?= =?utf-8?B?VlFUYWM4bG1rS1FWSDdYU2RVUExLK3ozak5LQkkwaGNybFB5a2hubW9nSlli?= =?utf-8?B?Z1VGNkNPY3E3d0pjTjFJYTYyOElSTUMxTWxlZGdlSjA1MXpZK2VxdVRhVG1C?= =?utf-8?B?NGVNZzd1T2JqK3dlQmF3ZUoyZXRzK1VFR2RXaUpUcWlPbEY0ZDFsWjh0Z1I0?= =?utf-8?B?N28zOERjMWVEOWtHYmJBclJHVDQ2aHZ6amJOeHpOakpQbDRvdVFEM0M1Q1p3?= =?utf-8?B?aXJvd2lxSjlqMDYrOG1HaWMveFBVMWNoclFYVkpyMVdneXJZTzF5VkxlRGZK?= =?utf-8?B?SCtaZWhKME5aaUNhNU5yaGRPODF6UmZXRHFpTVloVnYrbFRBc0pBRlovNENV?= =?utf-8?B?dWZBaXBTajUzMXY4TDhlSkZmMUdteFJJZnFhZ2JwV1k0ZDZOS05IT3VmWEp4?= =?utf-8?B?MjZHOGNjM3oyMjlFQW5VUkkrWkkrY0hJUGxjTzU1NGpod1BsaitrdXl4Mkhn?= =?utf-8?B?dVFqc2R6b2ZUanJLRklEM1RqSmplQ0RnQndXVXVERG9EM3QwaVZqTjNXdVFX?= =?utf-8?B?eTAzMFRFUVFUYnNZQjBIek1ZSXpPQWNhNTM5a0FWRVNUd2dOUzN6YnlyakRE?= =?utf-8?B?RFBQNTV6UEZwWkpCajlXMzBjRFU0SmxWbkYrTGY5elArczBsRVQ1MkdJbjZw?= =?utf-8?B?Z0tCYmhUMHNFNjdOMllwb29semxVOE1sOW1QUjBJUDIvME9teG9YNjh4NEdv?= =?utf-8?B?Z2prb1QvYlU0dWE1UWt5M2FTOGZXV3dkelVMNWdBb1J6MUJvOUV1VnN4OTFB?= =?utf-8?B?N3pwOXd2OEd2WlhTUzdiTWdSTVhHWUxaMUlsckMwUHU5bXdaUWsrZ0x5YS9t?= =?utf-8?B?TFpvSGxPeW54ci9PS21FbnBUTXVUVHF2ZUFURXBGTzFCZmxPRkpmUWxSQzlq?= =?utf-8?B?RUVycC9FbUdjRHNtVWN4ZXVSVTd4V2dZUlh0T0NRQVFZT0Q5aEl0UVp3bkJM?= =?utf-8?B?cmVMd01ITEZYRUtlVzMxdEtmbWw4ejhzNEQ4THBMUjJ5MkVzdFg1VDQrTi9i?= =?utf-8?B?b3lrTnJUYURldXRuRXFSUHYwNFRMQ3R4bWRCd1dvRngwZnVvTy9yVXVoYWNN?= =?utf-8?B?ZmFvWGdKRXFNTndFdzh2dWFTaUhRdWVzN1U4Zkx5TXROTmdaZVpGdkc0RzM3?= =?utf-8?B?REFIaVFoek9jbnZ4TkYrNnd2U0t3RWh0elJaOVppeHpvbDFYMElPQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <5C9A227D0568064598932CFED4E0E148@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7ef0047-5edf-47d4-abf0-08da38b6f74d X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 10:12:51.0456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /OoGTbiWnMH/FF9ETw084oITQJFqEnRCh+0MMFHOBwYYbP0FE5AFCq0DUWkcwY3CKg8dL8dnFgwRGVELI6FjljJhmjWujNu4Mdi/GLV3SuU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4375 T24gMTgvMDUvMjAyMiAxMDo1MSwgRWR3aW4gVG9yb2sgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEv dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sIGIvdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5j dHJsLm1sDQo+PiBpbmRleCA3NTAzMDMxZDhmNjEuLjhlYWI2ZjYwZWIxNCAxMDA2NDQNCj4+IC0t LSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPj4gKysrIGIvdG9vbHMvb2NhbWwv bGlicy94Yy94ZW5jdHJsLm1sDQo+PiBAQCAtODUsNiArODUsNyBAQCB0eXBlIGRvbWN0bF9jcmVh dGVfY29uZmlnID0NCj4+IAltYXhfZ3JhbnRfZnJhbWVzOiBpbnQ7DQo+PiAJbWF4X21hcHRyYWNr X2ZyYW1lczogaW50Ow0KPj4gCW1heF9ncmFudF92ZXJzaW9uOiBpbnQ7DQo+PiArCWNwdXBvb2xf aWQ6IGludDMyOw0KPiBXaGF0IGFyZSB0aGUgdmFsaWQgdmFsdWVzIGZvciBhIENQVSBwb29sIGlk LCBpbiBwYXJ0aWN1bGFyIHdoYXQgdmFsdWUgc2hvdWxkIGJlIHBhc3NlZCBoZXJlIHRvIGdldCBi YWNrIHRoZSBiZWhhdmlvdXIgcHJpb3IgdG8gdGhlc2UgY2hhbmdlcyBpbiBYZW4/DQo+IChpLmUu IHdvdWxkIGl0IGJlIGNwdSBwb29sIGlkIDAgb3IgLTEgaWYgY3B1IHBvb2xzIGFyZW4ndCBvdGhl cndpc2UgZXhwbGljaXRseSBjb25maWd1cmVkIG9uIHRoZSBzeXN0ZW0pDQoNCmNwdXBvb2xzIGFy ZSBhIG5vbi1vcHRpb25hbCBjb25zdHJ1Y3QgaW4gWGVuLg0KDQpCeSBkZWZhdWx0LCBvbmUgY3B1 cG9vbCBleGlzdHMsIHdpdGggdGhlIGlkIDAsIHVzaW5nIHRoZSBkZWZhdWx0DQpzY2hlZHVsZXIg Y292ZXJpbmcgYWxsIHBDUFVzLCBhbmQgZG9tMCBpcyBjb25zdHJ1Y3RlZCBpbiB0aGlzIGNwdXBv b2wuDQoNClBhc3NpbmcgMCBoZXJlIGlzIHRoZSBiYWNrd2FyZHMgY29tcGF0aWJsZSBvcHRpb24u DQoNCkFuZCBvbiB0aGF0IG5vdGUsIEx1Y2EsIHlvdSBvdWdodCB0byBwYXRjaCB4bC9saWJ4bCB0 byBhcHBseSB0aGUgcG9vbD0NCnNldHRpbmcgZGlyZWN0bHkgZHVyaW5nIGRvbWFpbiBjcmVhdGUs IHJhdGhlciB0aGFuIGRlcGVuZGluZyBvbiBjcHVwb29sDQowIGV4aXN0aW5nIGFuZCBtb3Zpbmcg dGhlIGRvbWFpbiBsYXRlci4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed May 18 10:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331886.555500 (Exim 4.92) (envelope-from ) id 1nrGlY-0005Fm-Nl; Wed, 18 May 2022 10:18:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331886.555500; Wed, 18 May 2022 10:18:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGlY-0005Ff-JW; Wed, 18 May 2022 10:18:52 +0000 Received: by outflank-mailman (input) for mailman id 331886; Wed, 18 May 2022 10:18:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGlX-0005FZ-DY for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:18:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e901ad6c-d693-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:18:50 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-Sp_u_IYHOZ-Km5U7yFy5FQ-1; Wed, 18 May 2022 12:18:48 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6117.eurprd04.prod.outlook.com (2603:10a6:20b:70::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 10:18:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:18:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e901ad6c-d693-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652869129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxbmnoN3ECUmit/rHTKvacZBtge35bgZsyj+rhSyxxg=; b=Mup+N6QT4aVoxszSzAu03ah5LcL86aIC3EEKxGqKpLdtN7qEOCs8bAk8qJ+g+dgMtqwv9M fOaYXDWQ3qdlZnq+faTXZ+OsKJFsc8k1UOWFfjv9konE8x5vp2crrcvEm2Uegl1BlQPiqr aUPheAxr1dezW5I7to4pX1JMvnapNnQ= X-MC-Unique: Sp_u_IYHOZ-Km5U7yFy5FQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fl/ydblejImuA11KWBDqXw5HGS5Vrh4VGLC1RCUDnnlmq7ImhYLh7/nalQXPYnLu09xiTHF10bj+Ngc3BMf3Mo/0KdCdG8+1m6ShdoOqzpVPXayp50wqpQ6aUyKc5E1Ro6Luvu3Bbsrfp35NFeFOqKGjenVus0TXtnmoRGDblNyUsOkWO46qvN3+WpTfjQ8pi/+JhltJGSVb2lDsfSAdzqsGnHSIOHjf7SyNAiwFlpmnWABs4Zw7jkNfcdkKxTyGF32cRAljqM0wUqMpq7GBfyYnTYcUhkTbk0MO3kiWkRsk3n7uCfnfft1QQHmfconBBZZd1s86nozz2MycEOwfhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fI25F0S5T7JK5JzpBnf6DwdbMN1F1TCy/dlsT0E0OgE=; b=A2nxwu8EZYGE7wQcpu/SfdWRCWy80BaS7lxYBJnk17q3jiSaE2tr9vZrTNb7lO+Av9ikNLIU72bHuT0aVh6snuoaxHUJB2RN6WozJNxCpNJDzwJROGCZQy8OwrD9z310WdzBAVMa9c1Tqs+8yMXsTnR0ZHyALnZtw7lDsMupBVUaE26Se2MKqRofre3Ox2fZ5s5PjHieLPhHk58dcLxS6YJgjnnfodv/0KDNIhaH9uYtwyUTHmxkTmB6d7TtsNYZlJNLdEXzvFY+J7XZO2xog6mHE7ybipPlG+19fKQjVza0NmGyWeJ0BprjQxmy5oF05smZZGPvGVhYuOTCfpx1oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 12:18:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 15/21] AMD/IOMMU: free all-empty page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <16f5b398-56f6-a70c-9ce0-0ad72eab5058@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P191CA0018.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8609e011-dee0-4c66-8d11-08da38b7cbb7 X-MS-TrafficTypeDiagnostic: AM6PR04MB6117:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8+WmRrfnhfg9SgWg1jakXZH5Iimud1PO8IJO1tlCMEMx6DfgYhA/7iSTTlxTzCUtOp+Mjwu1BVun7aCJ29/G7QZ3+m1EFSFQyJAchnp2pvLBNy9O5i00lBuHbJAaPpeW/TA39Jp0ltEjBz0FJY88JCW17XT8EkyBZq9WyKSODx7duaBZDpBNmsb/Rnh0tx9kKf8dTC70nNycFcqfYw1v/2VSz6MfjtSOZEuNjjP7wOQlAWhigqdD+U7vN+jOa+VVnRaHMA8t+0WAeDuNLHSEA6QknUMJQkjESp1IUkbuzsygZJm8hNH5hV7qQYfFIWZLr6W1F8WK2Yilcp2v7zTQo98ifDAYicvIH061yYcHMwMTBFiEEXZjUecDxnTsP+Pk73OeOQR+oxqj3Nfw8IzI/EkkusOnF1DHUHNhBK6/7KhI/w7WjeI40PeoE86r+jqRfKkm6ITNIMDvOAmqYZLbX2r+N9apoWltpFjySNYD5dbww9WPEN8Ane6NpAwTMxnwvcCQGwaylZY+V5avmVESvAwSHN8GXFXxU5nq2ln38SYNN6gBQqfvQ158rH6a4MUp6QXjZwdA/oTW32fzYrJq5VYk9kXYihm4mhkkGhy6A5zdY9uV4N0ZulhU8SFFsc/xrqJJC+60rZHbV1WPk6RTU3M4xEBRjL0N/g9BBH3TykZfWM7VnrbIg/TdY+xCDPjZxzU5uLavcTbhWOGmeygrHgqTV20lcTtqHkgxgCzp8QZlW48tQ8dzBv1OtlXVj0Ko X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(2906002)(5660300002)(6506007)(83380400001)(53546011)(6512007)(508600001)(6486002)(66476007)(66946007)(66556008)(316002)(8936002)(2616005)(8676002)(54906003)(4326008)(36756003)(31686004)(86362001)(26005)(186003)(6916009)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yQ4QYALpoIylgEQkwPIMl+rrKanvKoArElrffm32mg3FmKy3bRiUfYAIgU/b?= =?us-ascii?Q?8npifBJDLHssL0GTPM2mLnIWeyrhLPhSvwZvB1nwSusapm3Ke/e02bX5ox9X?= =?us-ascii?Q?jKbp60rqJjKV1+WXRvFuqEGUFGycL75S259dnvkrtmxJaF5Bk0mgkq/h7NbJ?= =?us-ascii?Q?sFVxrNUjc+W5FeZOUBUHEvf6jqRh796rh4wvYavvkJgmRwdPzX1eTFJm825+?= =?us-ascii?Q?Qxi+QKoEmCpXnqT7PaqAgNCkNKi/+L8kc7ixWXvN1iK6TK5u/eP4F0nBixWV?= =?us-ascii?Q?c+I6IYN9eNO5qj1a1Cph2F9gOhj2aLrUkcWIimmuTdI1l1WEZKeCAaMaRKN8?= =?us-ascii?Q?eJz/bZ7stdeSW8cvo0NhpGuhakIPbO3hwZ5WpU7XMppa8t/Gs8GaVEnCqWA8?= =?us-ascii?Q?lYoLdywUXVv0xGvl8IBBBt8WH4F8w0PmC2uiPap9E9ywoN4kUoBFl3WWbRi4?= =?us-ascii?Q?cqi1Zz00xTC3un5Pd0vbNj4nGXWAXCRiUfmbyTLaQQjiQf9GBJoOkJyQBuLi?= =?us-ascii?Q?+pCzw9TWMutgdmnzcRrXNVMAoiGKOdW4yLMuIrXcQ3yVw2sFKqt5+cxJsiZv?= =?us-ascii?Q?E23sfHwpXQVtpS2y/We3lq58rm451fW+Pln7pJsiXEr1K+tKYDvV/YMs386w?= =?us-ascii?Q?PT8y7UbnEPtnpijaSOqpzfk3flbw/vul1DcnpwumsTQg0A9obj4sB4Kt4lG+?= =?us-ascii?Q?9PqdR4CrvEg0cYP2MRKdk4c4ZKeu0pAl1+EEZ4dBTWXb+0J6zrGDVnNbOdBy?= =?us-ascii?Q?Oj6SPZ/0T54sKETRxLWSjOhEkzqW2M6B3fT7s/m7vf4bL9mFSZaBPYpF/9p6?= =?us-ascii?Q?AoL6N7ba5bLtws62k2YxQrdNYRhcFHdcEFYWeuWhoBRPnzsnj+FXk+dZsFCx?= =?us-ascii?Q?R+T6Dd1DBlPSssGbuxKCQ+K6zntMcHpOhQnzVrd6lQu+84jjLm5up/hERc11?= =?us-ascii?Q?PJtz+jwWDgWJfxwdfYksrhcBsuPUlkQpeWJTuk6yGiXE1TQlNEROhG+a+hom?= =?us-ascii?Q?l2sRuiQHq26q5IPrfNZxzldrZTp/zvLmNNkJizF++zKkZk2aOH7s1NSfSsnd?= =?us-ascii?Q?puGJjp+QCZzVrhMr69yYc27kmNVYWslXZyPi2JYkyRR5NVA2gG/8teNPolaF?= =?us-ascii?Q?9GeySrSWCGkQ9A7q24NSYq2POy3L/vfe6FdG9cPDjzeEPUuxgHjhofIjeq2x?= =?us-ascii?Q?Qj8go5b+t4rJA5hdb1vNgnEd5L8azS/rRIek1I3WJ5fDyVZlRqx5YktzGClr?= =?us-ascii?Q?sYp8ozm+/jMuNKzHRJc8mgPHiZgFRdayKSmC04FIp7moRDy++JfwQAdik81a?= =?us-ascii?Q?F3IdoFVYrHo1v4BBPFqLjkXN3fEOPNgbm0cYDjRXvlCC86q3pKhsj2WcaStt?= =?us-ascii?Q?T+jqaYB/N8OxBJqH2Fwpv856VnbZYhR+LRJfFRTsqdTthWYOHumGr/1zbJkg?= =?us-ascii?Q?18v3aAQDKKtz5Hh6uOoITkzwQZpWEW85FoPVf0QK8Aj6W9sAlykyava2N8R3?= =?us-ascii?Q?vEPLWhmWg99oXKuGAs7/tdA/UNxvHHdlQ2IUUeMheERrR2jeuh1d/zRlIIBT?= =?us-ascii?Q?iSRFuXkkzBnnQvNcWPrPsZ3UfR2PUWtV/7WGvgK070NmaGJX1OsEiX2jSu3L?= =?us-ascii?Q?vEnXiIuuDwY1LiwXzZzlGYYxJhVjorKkgyJvKG0GAE83uEdpp17t/cqxKhB2?= =?us-ascii?Q?CdCCz2ekKNaj8aZS/+9lMEbzLO7dXatw9Kp8CZyApXo8qjEO+Z3RHChsRRVI?= =?us-ascii?Q?2n7GK+f2yQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8609e011-dee0-4c66-8d11-08da38b7cbb7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:18:47.5883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ScyrDeC5qqPoXJX39wKMGVTdmiJ76aLDzBOPvhEJQ8YarXUMQ1Foxqm+AuQsmJp7bzjWPowP3sn9CGSWv4nIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6117 On 10.05.2022 15:30, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:42:19AM +0200, Jan Beulich wrote: >> When a page table ends up with no present entries left, it can be >> replaced by a non-present entry at the next higher level. The page table >> itself can then be scheduled for freeing. >> >> Note that while its output isn't used there yet, >> pt_update_contig_markers() right away needs to be called in all places >> where entries get updated, not just the one where entries get cleared. >> >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. >> @@ -85,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte >> if ( !old.pr || old.next_level || >> old.mfn !=3D next_mfn || >> old.iw !=3D iw || old.ir !=3D ir ) >> + { >> set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >> + pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level= ), >> + level, PTE_kind_leaf); >=20 > It would be better to call pt_update_contig_markers inside of > set_iommu_pde_present, but that would imply changing the parameters > passed to the function. It's cumbersome (and error prone) to have to > pair calls to set_iommu_pde_present() with pt_update_contig_markers(). Right, but then already the sheer number of parameters would become excessive (imo). >> @@ -474,8 +491,24 @@ int cf_check amd_iommu_unmap_page( >> =20 >> if ( pt_mfn ) >> { >> + bool free; >> + >> /* Mark PTE as 'page not present'. */ >> - old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); >> + old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &fre= e); >> + >> + while ( unlikely(free) && ++level < hd->arch.amd.paging_mode ) >> + { >> + struct page_info *pg =3D mfn_to_page(_mfn(pt_mfn)); >> + >> + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, >> + flush_flags, false) ) >> + BUG(); >> + BUG_ON(!pt_mfn); >> + >> + clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); >=20 > Not sure it's worth initializing free to false (at definition and > before each call to clear_iommu_pte_present), just in case we manage > to return early from clear_iommu_pte_present without having updated > 'free'. There's no such path now, so I'd view it as dead code to do so. If necessary a patch introducing such an early exit would need to deal with this. But even then I'd rather see this being dealt with right in clear_iommu_pte_present(). Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:22:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:22:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331894.555511 (Exim 4.92) (envelope-from ) id 1nrGor-0006ib-6x; Wed, 18 May 2022 10:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331894.555511; Wed, 18 May 2022 10:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGor-0006iU-3j; Wed, 18 May 2022 10:22:17 +0000 Received: by outflank-mailman (input) for mailman id 331894; Wed, 18 May 2022 10:22:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGoq-0006iO-2m for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:22:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0d::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6292cd30-d694-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:22:14 +0200 (CEST) Received: from AS9PR06CA0299.eurprd06.prod.outlook.com (2603:10a6:20b:45a::28) by VE1PR08MB5216.eurprd08.prod.outlook.com (2603:10a6:803:113::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 10:22:11 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::87) by AS9PR06CA0299.outlook.office365.com (2603:10a6:20b:45a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 10:22:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 10:22:09 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Wed, 18 May 2022 10:22:09 +0000 Received: from 580a75d7349d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7089268D-2842-4877-9B06-24CF45F1DBFD.1; Wed, 18 May 2022 10:22:03 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 580a75d7349d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 10:22:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB6207.eurprd08.prod.outlook.com (2603:10a6:102:f2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 10:22:02 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::91a2:f704:9c0d:fca6%6]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6292cd30-d694-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=diVF5sFWFZsNXh5Wum896ILFL5Fg/P/XqI/3A5Zy2NyIJSyMPrLpfrPpGXhOhF5whNfyLJeJxx8H4jvE2EEfiF2R/6MiIdjVRA/L3HFIc6gFaBwUd86FtRnDDWl+LUhkiKj+0SEkrhWu8oEd92mf8MxxU0BKk5MHosOfjut1iI2Jk1gT5PW8D5dfUr/Kh5he0xDfMPDu2Cgcq6o760PPhA23BwV3CQwgnUUu2nN+fTg0ShvZPcE18/igdK1q57kdWl5B0Lw1T84luKoFJfy7ojDpGxE6E2fETdFAU7vBLQ4/SQhbbRWzwPZl2ttYFZh0jW5ScQUDki/OpIQVNT5spg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQy2dhOexMIlY4x0cMdRhmrw1eWU3wLJuWRqUHeBWvg=; b=GXV0PQXpMR7c+EiAzcPCiwAASGmtNc8aqgSPFKtqMiWxPx4F9t8C7b+Td8ZAJgDSksGhAo8d2TpVmmbauEQP/dZFcnNGFkDVDcJ7bhWC8Dkf9tpMzIovcfxNB/FCtyVi2nGbQtT+jntxfuC0EgEnIwm6rCCyCUittLb4dvFVswVyobag7JPEDjI2EaINRPJSo+kxj4YkdHc8vD3QAxEX27oRLDu8jktIocsW7N1c+hD3fg2lT12hO90zdeghAOz58ae3jiUl/ZZSHqldnlyaFF7xgJuLwPAze9PBr9dG6f1jitrZKLevBBrsr9YUaEYbAiNjXf2J+sE0cbNxZJA3AQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQy2dhOexMIlY4x0cMdRhmrw1eWU3wLJuWRqUHeBWvg=; b=X4/xJeuhy7aOmRB/1RTOElXNKcwN2zoOvmf0fTCh9zLc4lAYCQLfurIS3iclD1NAGIG1rrAm8KUscN+TTt/4QjfpZPyugqDfh0SJfU33IIWCeSFWOcNeykyfxidvaouXngpb4apzi7G72zO3gWnvHozaKGllG6VxdZpGAEB+ARc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ye3TzbgdrqAgjMYIm7c5o1VcwtLNzxI+rAzCw12fahX/qaaF4bsJMyyFXGYAYUbDXfno9TH7edM9AbzAw+W9fH/inev2+1X1t8w0c3Zpi/hXuzlLfUcRb9mlgokZFex6cvaGl8D2+X1E2yQp7RclPs2n+gIpwl+Fy9kR68bYKOzR16WLXZWdM24dJkScsvVhmsa4fRVMBUWcx80TewAFUshZ5MWiSb5Vv49qSNuCABdXveGB+lQZF3iqKi3t7cINJm0JXV7ywrAAsOPy2ifXNFmBdJP/ziKcAFBcAQTAiJXgGdbkYozy8353fvBQQN16voIDF7LCHXhb+IuUZgqftQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQy2dhOexMIlY4x0cMdRhmrw1eWU3wLJuWRqUHeBWvg=; b=XZSutT6ZxLHlnmIcecamCwD2jFsP+pwczuDGqgMx8Ho7hffapOodfOFS/GS8fO+Q+7vYG3I27HyPr7CLkJp8wPNZd/xlSfbo0jtCFbKvZmOILFoJdp/XoGBYeM6t7F73LXgEx/k4DrZbPj1zYFwjkePxpP/gm8mHkqhJyGtOO3LSmNOKRP/y/wFmWPhkKGw1tJBLPWLf6DGoYv/0LWguPDnDu2+nhp0nD54wqKo04o2YkmL6x9/03wsqceaOP/Oj89o5bmPmYwhYSJtL8lT+TPz6fyN+qFDnvc3j5/A9PFKhbU5Rif3nhQEDsxLs0MjmsmUm6UzOVzT7mwgFNgyl8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQy2dhOexMIlY4x0cMdRhmrw1eWU3wLJuWRqUHeBWvg=; b=X4/xJeuhy7aOmRB/1RTOElXNKcwN2zoOvmf0fTCh9zLc4lAYCQLfurIS3iclD1NAGIG1rrAm8KUscN+TTt/4QjfpZPyugqDfh0SJfU33IIWCeSFWOcNeykyfxidvaouXngpb4apzi7G72zO3gWnvHozaKGllG6VxdZpGAEB+ARc= From: Henry Wang To: Jan Beulich CC: Wei Liu , Community Manager , "xen-devel@lists.xenproject.org" , Roger Pau Monne , Andrew Cooper Subject: RE: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Thread-Topic: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Thread-Index: AQHYagM6tDpJ92rV50ONWDPDxej1sa0kY+2AgAABBzCAAAWtgIAAAFLw Date: Wed, 18 May 2022 10:22:01 +0000 Message-ID: References: <20220517153127.40276-1-roger.pau@citrix.com> <6b5362c8-2a41-d2c8-b25e-2e9c421d6da2@suse.com> <17f8215c-7b8e-1c10-350b-21a9dec64d82@suse.com> In-Reply-To: <17f8215c-7b8e-1c10-350b-21a9dec64d82@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 132EAFB82FB11241BB56695CC250A18D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f4eb4853-f693-4783-a427-08da38b8446b x-ms-traffictypediagnostic: PA4PR08MB6207:EE_|AM5EUR03FT015:EE_|VE1PR08MB5216:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gqFknhBYaWDFZPdd3DvrZB5iDl7LQImmHfTWaZhOvjpHCpJuawgW1guVvijbxVVga1terSacew1lhQUv1144Cq78aNj1pT+4cgFEXOclFEslEJE8PrCXDiAGznTKKVpw3PE2rIeI63ym+EHDRppny5aylOmMmRNGaMLcOg3LQC/ZxRFDqwVJsSWWE7HPw/4pYOBSpu13yObdU4zQgKaZmLQNeMqMRx2i9oHy6kkpq3op9neAILEEGgGFPmTMk+Ux9CMfGJpfKjBP4mgen0TG7O8up3Hxx8fvYyIC36n4S4nPaLYVjBg8DSlI/sg71+p0uK7IvFHORaDkm9kTvJEkUCounYjPWRAlFxM5yLmrrR91rHPWzhoquwb4b/nZOLVLGs5lP/lsLva+9te0xi6UGrCuqSfVB5He/fHrTI8ab9ZOXp3+uwlGB5Uiwnso0rU8XQbi7Vgtu+/3GhNPT4Ljg0l0e16zEDgA8lbxBu0NGwmeVYvk9OZfJJVkzvx9p3i3O5dj6Wa+llbbG4fc79sCn6fD8LWapoZsEbEF3ecpdbPvecP7Bol+MsoYURoaQNw7eDWtOLIfZuVtumy9tof/9AX+Kn9UFekhP2PaMj3YGiTj+JETv3QNZM7y0l2SwN9PfQRsH5Amleq3RnYP1xmP7w2FYMKvPT+Ty/ABuFY7lAJMQNRQbqE3fkj/+hrlTPshMbzSJrtw3fFlcY7sAhcNuw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(2906002)(7696005)(53546011)(54906003)(6506007)(66556008)(26005)(71200400001)(6916009)(38100700002)(83380400001)(38070700005)(55016003)(86362001)(33656002)(66446008)(52536014)(508600001)(8936002)(76116006)(122000001)(186003)(64756008)(5660300002)(8676002)(4326008)(9686003)(66946007)(66476007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6207 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4118bb45-b4c0-42d0-c13d-08da38b83fa0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j02fidEQUyR99JpghIvp/8u/gbVJUlDoFTO79AoEFluzpeLLnSiLPkT+h01Mgsn7qXnOoA8F77wXLeiGoPH6a0Ftyp19p3SJK1cYSbQ5ie55Py4p8aIOozt+yIq0UVvRLOZOukr3XeqV15C8hYHz0MlWMRXDvNLl/nAovI8os+MAT33B+0RTHBQu0/xmFIvihdU2p3gT507vuVPaSHWXSqRzDZGTbraiiBCe++bV+h3wQbmcbYAji+bH8BZdSLz3FtRzyJ2+ypTMO7xbO4D7rS6o5xetrPMW7Q91tAhBdxXFNx5j2Tq5G+2jS5lF0EKxqlBHjNF3TfCltRKFxswsNiM+lvVd2BpUh0TuFkPfLxhTY2trsy29qzguehr2t6SMBjZR0l3U4FyMw3jLU56hGN0uKvG0nejqAhKVr+N1LjDN5PRVaoOz9KdLUquvKvkeG4NbsZgev2720YLJMIYQUKoK+/ca0lFpMwvOILs5/izR/EjdqLt/2dFZciN3SM7G7oJmQA7ogmIw1uysV5Vtq+gyEkdB07/JyutLRReVf+3esEukl6Fu7q8DP0HltI75KUH7Z/M7LlXqLY0/TQ7grTwSSaKnuis5yluHbETKSv7Htz/d77DnqBE1CURr7d4cz2jZIBMm77SaZGo9djAOoBdtKn7+AzChsCCovldb8RzFfWXcy3SajUFM8K40Wibb X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(70586007)(33656002)(82310400005)(70206006)(8676002)(4326008)(9686003)(54906003)(86362001)(6862004)(508600001)(55016003)(26005)(81166007)(53546011)(40460700003)(356005)(316002)(7696005)(52536014)(336012)(8936002)(83380400001)(47076005)(5660300002)(2906002)(107886003)(6506007)(36860700001)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:22:09.8764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4eb4853-f693-4783-a427-08da38b8446b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5216 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IE9uIDE4LjA1LjIwMjIgMTE6NTEsIEhlbnJ5 IFdhbmcgd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4NCj4gPj4gT24gMTcuMDUuMjAy MiAxNzozMSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiA+Pj4gUm9nZXIgUGF1IE1vbm5lICgz KToNCj4gPj4+ICAgYW1kL21zcjogaW1wbGVtZW50IFZJUlRfU1BFQ19DVFJMIGZvciBIVk0gZ3Vl c3RzIG9uIHRvcCBvZg0KPiA+PiBTUEVDX0NUUkwNCj4gPj4+ICAgYW1kL21zcjogYWxsb3cgcGFz c3Rocm91Z2ggb2YgVklSVF9TUEVDX0NUUkwgZm9yIEhWTSBndWVzdHMNCj4gPj4+ICAgYW1kL21z cjogaW1wbGVtZW50IFZJUlRfU1BFQ19DVFJMIGZvciBIVk0gZ3Vlc3RzIHVzaW5nIGxlZ2FjeQ0K PiBTU0JEDQo+ID4+DQo+ID4+IEZUQU9ELCB3aGlsZSBiZXNpZGVzIGEgbWlzc2luZyBhY2sgZm9y IC4uLg0KPiA+Pg0KPiA+Pj4gIENIQU5HRUxPRy5tZCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDMgKw0KPiA+Pg0KPiA+PiAuLi4gdGhpcyBhZGRpdGlvbiB0aGUgc2VyaWVzIHdv dWxkIG5vdyBsb29rIHRvIGJlIHJlYWR5IHRvIGdvIGluLA0KPiA+PiBJJ2QgbGlrZSB0byBoYXZl IHNvbWUgZm9ybSBvZiBjb25maXJtYXRpb24gYnkgeW91LCBBbmRyZXcsIHRoYXQNCj4gPj4geW91 IG5vdyB2aWV3IHRoaXMgYXMgbWVldGluZyB0aGUgY29tbWVudHMgeW91IGdhdmUgb24gYW4gZWFy bGllcg0KPiA+PiB2ZXJzaW9uLg0KPiA+DQo+ID4gTm90IGNvbXBsZXRlbHkgc3VyZSBpZiBJIGFt IHByb3BlciB0byBkbyB0aGF0IGJ1dCBmb3IgdGhlIENIQU5HRUxPRy5tZA0KPiA+IGNoYW5nZToN Cj4gDQo+IFdlbGwsIG5vLW9uZSBleGNlcHQgeW91IGFjdHVhbGx5IGNhbiBhY2sgY2hhbmdlcyB0 byB0aGlzIGZpbGUsIGFzIHBlcg0KPiAuL01BSU5UQUlORVJTLg0KDQpUaGFua3MgZm9yIGNvbmZp cm1pbmcgYW5kIHNlbmRpbmcgdGhlIHJlbWluZGVyIHRvIGhlbHAgbWUgdG8gdW5kZXJzdGFuZA0K dGhhdCBJIHNob3VsZCBhY2sgdGhlIGNoYW5nZXMgaW4gQ0hBTkdFTE9HLm1kIGZvciB0aGlzIHNl cmllcywgSSB3aWxsIGtlZXANCnRoZSBpbmZvcm1hdGlvbiBpbiBtaW5kIGFuZCBJIGd1ZXNzIEkg YW0gZ3JhZHVhbGx5IGFjcXVpcmluZyBleHBlcmllbmNlcyA6KQ0KDQpLaW5kIHJlZ2FyZHMsDQpI ZW5yeQ0KDQo+IA0KPiA+IEFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ DQo+IA0KPiBUaGFua3MuDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Wed May 18 10:24:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:24:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331903.555521 (Exim 4.92) (envelope-from ) id 1nrGr4-0007OT-PE; Wed, 18 May 2022 10:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331903.555521; Wed, 18 May 2022 10:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGr4-0007OM-MS; Wed, 18 May 2022 10:24:34 +0000 Received: by outflank-mailman (input) for mailman id 331903; Wed, 18 May 2022 10:24:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGr3-0007OF-TJ for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:24:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b53f994d-d694-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:24:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6F29521B61; Wed, 18 May 2022 10:24:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2DEA1133F5; Wed, 18 May 2022 10:24:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id skRgCWDJhGJwLgAAMHmgww (envelope-from ); Wed, 18 May 2022 10:24:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b53f994d-d694-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652869472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vn6FkSbw2QpthMl9zFPwFfLa2MAKW+KZG9juhuh2fI4=; b=sSogkIdlVn65TzwUI8TlikhFrv5Q4WbjMILyEqZvjYwsRjd+GTTIzsPWZ0b4fNmeJb67si +Rkf/QV/QhdUIezFoCxPMZPB7tmCvFWFYCCSLk97YwBFe8K04gaFVihNQXKHoo4ttjQNyz hOmHVVNC/S/EH1VOmI3MIegDk6T2yjQ= Message-ID: <067cc1f8-bd82-f52f-3c01-b71fd7f82e6f@suse.com> Date: Wed, 18 May 2022 12:24:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: Dario Faggioli , Luca Fancellu References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-2-andrew.cooper3@citrix.com> From: Juergen Gross In-Reply-To: <20220517194113.2574-2-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yy07CPsTfRFxp8fZtyapMmLo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yy07CPsTfRFxp8fZtyapMmLo Content-Type: multipart/mixed; boundary="------------kz2ofvdFMmWo0cE0fcay5vl0"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Xen-devel Cc: Dario Faggioli , Luca Fancellu Message-ID: <067cc1f8-bd82-f52f-3c01-b71fd7f82e6f@suse.com> Subject: Re: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-2-andrew.cooper3@citrix.com> In-Reply-To: <20220517194113.2574-2-andrew.cooper3@citrix.com> --------------kz2ofvdFMmWo0cE0fcay5vl0 Content-Type: multipart/mixed; boundary="------------KkU0MVIU5lG3Xg0G84ZpjvW0" --------------KkU0MVIU5lG3Xg0G84ZpjvW0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDUuMjIgMjE6NDEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IGMvcyBjZmM1MjE0 ODQ0NGYgKCJ4ZW4vZG9tYWluOiBSZWR1Y2UgdGhlIHF1YW50aXR5IG9mIGluaXRpYWxpc2F0 aW9uIGZvcg0KPiBzeXN0ZW0gZG9tYWlucyIpIHJlbW92ZWQgdGhlIHBhdGggaW4gZG9tYWlu X2NyZWF0ZSgpIHdoaWNoIGNhbGxlZA0KPiBzY2hlZF9pbml0X2RvbWFpbigpIHdpdGggQ1BV UE9PTElEX05PTkUgZm9yIHN5c3RlbSBkb21haW5zLg0KPiANCj4gQXJndWFibHksIHRoYXQg Y2hhbmdlc2V0IHNob3VsZCBoYXZlIGNsZWFuZWQgdXAgdGhpcyBwYXRoIHRvby4NCj4gDQo+ IEhvd2V2ZXIsIGMvcyA5MmVhOWM1NGZjODEgKCJhcm0vZG9tMGxlc3M6IGFzc2lnbiBkb20w bGVzcyBndWVzdHMgdG8gY3B1cG9vbHMiKQ0KPiBjaGFuZ2VkIGRvbWFpbl9jcmVhdGUoKSBm cm9tIHVzaW5nIGEgaGFyZGNvZGVkIHBvb2xpZCBvZiAwLCB0byB1c2luZyBhIHZhbHVlDQo+ IHBhc3NlZCBieSB0aGUgdG9vbHN0YWNrLg0KPiANCj4gV2hpbGUgQ1BVUE9PTElEX05PTkUg aXMgYW4gaW50ZXJuYWwgY29uc3RhbnQsIHVzZXJzcGFjZSBjYW4gcGFzcyAtMSBmb3IgdGhl DQo+IGNwdXBvb2xfaWQgcGFyYW1ldGVyIGFuZCBhdHRlbXB0IHRvIGNvbnN0cnVjdCBhIHJl YWwgZG9tYWluIHVzaW5nIGRlZmF1bHQgb3BzLA0KPiB3aGljaCBhdCBhIG1pbmltdW0gd2ls bCBmYWlsIHRoZSBhc3NlcnRpb24gaW4gZG9tX3NjaGVkdWxlcigpLg0KPiANCj4gRml4ZXM6 IDkyZWE5YzU0ZmM4MSAoImFybS9kb20wbGVzczogYXNzaWduIGRvbTBsZXNzIGd1ZXN0cyB0 byBjcHVwb29scyIpDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv c3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------KkU0MVIU5lG3Xg0G84ZpjvW0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KkU0MVIU5lG3Xg0G84ZpjvW0-- --------------kz2ofvdFMmWo0cE0fcay5vl0-- --------------yy07CPsTfRFxp8fZtyapMmLo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKEyV8FAwAAAAAACgkQsN6d1ii/Ey+J UQf/XSgty4RWRAZu3/0V1ZBLw+7WggfGyJKRQW3FJ3PNTo5Ri0DAocaMSwir3CIzvR/nbEGpr2ej eMWZDK99S4Apr25TZFtrTRM99xKqP70zwIvES8rzJT2WvkTMuZZO1756Bn7GXkHLKmSCQaKrPTCs 95pQDF/Ki23WQW4VBtycUfp7q5fXXCqq6tNaQ5mXXTqlKa6A6tHRfQFuMOmDjHNTRMk+syATAIBB cT3v5sTCjXzu9moPgIUgudkWELNsUR2kQ5352MLnb/ux3c/UDH70dzJdV4mA7GLl4KpFAhVTL0ja mEPoJ7mjtUvXTn6mmA7v/Ms8ykp/etCClq6qeBeKEg== =XN3H -----END PGP SIGNATURE----- --------------yy07CPsTfRFxp8fZtyapMmLo-- From xen-devel-bounces@lists.xenproject.org Wed May 18 10:26:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331911.555533 (Exim 4.92) (envelope-from ) id 1nrGse-0007yU-4j; Wed, 18 May 2022 10:26:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331911.555533; Wed, 18 May 2022 10:26:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGse-0007yN-1h; Wed, 18 May 2022 10:26:12 +0000 Received: by outflank-mailman (input) for mailman id 331911; Wed, 18 May 2022 10:26:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGsc-0007yH-TH for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:26:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eee01b2e-d694-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:26:09 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-08_ARvgmNw6PfkPLAlGH4Q-1; Wed, 18 May 2022 12:26:08 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7347.eurprd04.prod.outlook.com (2603:10a6:20b:1d0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 10:26:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:26:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eee01b2e-d694-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652869569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pmGU5NItwdQtckzwIkwK1lEXygQooNH5fZX2CyiXxW8=; b=WA1KKCHIgsmzj1NswFSUl/a9hTgSx52wlvHSDWQ1m5HYNMurfX7MZl/+FvEAqzxyNooEnY jwPxx/DLYwKubATzO8QQiSkHCURYTAV5oSdFuVB6DtYlRGzkq7LDxQ0ptPJgLak3ez+DFd VgpATYLeIuOucglnxY5znxCDCISpPPU= X-MC-Unique: 08_ARvgmNw6PfkPLAlGH4Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjI8N/Xx7kF3tWhxC1SVU2atY7AQMT6KOfgXU8OCWUcnvnKBYCY+V3plZXCFezkcu0YJtKqQY3BMIbirXwI+WCgHgHta8YKqDHlyic8dBHIukipmeQrxY/ZkBl+QItvO5PPe6jFtE+/kA6EfyzbquddwQZ4mSJ7DCcXB0UlE35QqwqtBxDNSaH6v9eO0F19VUPfFKnAvfzGk3x6Zp7QzEL5pKYm4ilyeVLqudJS66z7LIXrU4Q6I3izqYnlxufW3419NfRl4aKaOykK3zhA/o0G9vSf+mf3W6gZnkBUcPAWKq5ERV1JgSamVvpvrBz5f2kucHwDlU6Pbr76BvruKfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BEXgRyi4Kx70iWWfzPx0MrfXl2zNjsllzDLpLgsv1+8=; b=CN/4gNHiLl+u0Ho3z4/Y+xJ1eA48ke0JjVRgsi8Vdya5SH3jnsd62TDiIoVc8MkQpeNzdU3/T2Tqxj2VeuDQbAMFS1EcbgbcLdWSi425mjyFQc3ZgcHr85kcKrmq9cBUSubS6Yu9uqtzn76KmHQbo7iE+CIA71zKM9ApBn5njrVje5/V3ZGns2Y9xpInDsjqbNliGZE0yKn2HH0lawq/zjrKKQtFWiGC5snMk29t1M/4lAidDjgRjLSHvQBRDDQbrnPBnX8xHZaj439Fxo4q2tIAeNwXofNxxbNJ6AgzmCs7kMsA2DP8Y2SRht/jGq9e6FDjEUzC9SNXgDfBPTe3bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> Date: Wed, 18 May 2022 12:26:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0107.eurprd06.prod.outlook.com (2603:10a6:20b:465::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ee8287e-9919-49d6-f93e-08da38b8d11a X-MS-TrafficTypeDiagnostic: AM8PR04MB7347:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gd4khmBtLycO6GdGkZCcerrMF8N6hKw0vsTA0smdDjimqLoj2jIAbnJ/Xg1aheABi6l1o9sU/eooh1V/CCSs83WEUVaIaFMccuwqUdR04j2LsbBvJ14U+aG3jQAKQKM8UToyrCXGg68LfWyNETEk2zVTxMDaE0oNzxrCQqt0P7V0KcYJYhcH0Plh1izms37QbllpBKdzwj+7CQeWU17RN9NvgguUGYo9ejcmkVDjLuspGxQ22niPBvJcU9pjpUtDjAYGAK/9/BoG0smHpdfIdkywThyy29j72b140AyaXVVCUm9QTFkIIY4TtClNB/SKJ3NnoxIfQZv/xWrS2yKPtSCMEH0tJUzHgPM3J/cvytV0gEdOB+qzmYsAwpgDU4Rpu5P1fn2j4f8ikQ2mIRXSwzVmiib3b6t4F+8edk7U9xvvnIyduIhYY3O+onlxpcwOHq8Hk4foPqMOSSidNxb4iTjsYy0GFCpB+ZoT7tp4QeL6MqzJOIMnxNXAI4uMn+z+K3uc9rfLt9G6aVVso8rfiY5bBgq5JcVCmaVFxroiO9/qYG6WXwB/llx6s4Q8kQjL2hSJY6cV25b6ZqFFPLW3dmrPFQArNAq9+iw78qrkwCmRzlOc12iVXP0B6CRqgnyh5y5M9Vny71UhFqIb1muZZMvpMGc+2PGHF3i5YKmYKL5B1/vpEFx29FjqrOnL/NKwvHe0TmY8PzTIH0o7hONHUjLVQVoFrclnrJ7n87+Ry8xC6Tv8f4/EwRFSaqHlQjMb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6666004)(508600001)(5660300002)(31696002)(8676002)(54906003)(66946007)(6916009)(6486002)(4326008)(86362001)(316002)(66476007)(66556008)(186003)(6512007)(31686004)(2616005)(53546011)(26005)(6506007)(2906002)(83380400001)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xtaSdrGfpsQjJzm/8/K3ur5Euz5nL3ae4OF3WdqtZ2Ka+0VcOvmfHlso/O9b?= =?us-ascii?Q?zAhqniMgMu43LMEvEEvwOlhca0vxuoNe5WgknYGqSlgiq0VVl7D6BD0OnR6U?= =?us-ascii?Q?ptuuHSB1ddGzfL3ZCgwvQgG40+H4uQl5YU5Am5O0I5DlAcwl6wbd23pIz1o3?= =?us-ascii?Q?d6G4ROD2Fi1SVtGDgQ6i7/QCEaMsy3JWC4UgJti9XzCtU+dMuQZWaw8C6zha?= =?us-ascii?Q?LBfNN2Q1QC9HEcWNXtA9qcNwYeNSZ00jaFGJ6SPrmjhHb2VdgrxxeVwP6UvP?= =?us-ascii?Q?twnDB7LckMQoyHw4m2UIPvM4qyMMvaco/xEjV3KBtPqoxGWCNQVFQJnJzn3E?= =?us-ascii?Q?qrUc1dAMagJS9ENV+FHKMcH95+RuYTN7o0/UWpB+SF3kHbfTStUrkGEaRjNr?= =?us-ascii?Q?VOWHvancgZt/IrNg9K51OwDdHka6gxydfifhbcitwhEfIpbW+5qFuszU2veU?= =?us-ascii?Q?02tGAHBY4yPyngrdEtUifImnnaoTUOFbVDLMQoRE/kZDsKXH+s4ch7nUw7h1?= =?us-ascii?Q?GQS5iQ01Zf35ZIeEAvV7NrDHLIR9Ls0LRe+VjHtPqTUqzZABZ3GzSQopFU4U?= =?us-ascii?Q?0eoXCBiW9lqmFYHGYHCxgOod1gIbgpVjEUj2uSlBVLZF/IJTO5W04MnGJKFN?= =?us-ascii?Q?fLit76ktJPJUpAplvtp+MoZmq26+a7Oa3UH/6Gl0MB6xBAPBSpUaUsAT2tws?= =?us-ascii?Q?zH0WwYQyyVHm0dvYkhOl+lUfY5IMr+HCrDKogFVWixwNK5Q9w+cHG+ywbc5j?= =?us-ascii?Q?FvxyJPDm4nni5Ag0OaJ/EkQyVLgjRkD7h5qDZf8F9TIpTCcM31jZfpodOOKp?= =?us-ascii?Q?NB/8ml9X26FIsttq9yXmtL5sxfXqG3UxkbyVyKIhcbSA5NC5RhkniCCN88bL?= =?us-ascii?Q?i/NQqLkIjELa5s8wdfGw0CL5jOzq6pfFnDEv7eXuGOcsKH/79rG18b2yOlJ4?= =?us-ascii?Q?hV9+W3mhmoztd1GVW9yCQmjuFRwwgX6+d+oP9ezvFF95az5r6YS4RLUcL4UW?= =?us-ascii?Q?mcZ4+h8EGKSTkIa5HEwrHPNDyN1qJTNZiCP1FN7LwHfoqSnxRvrD/Lyb4k+t?= =?us-ascii?Q?RHI2KVonUwo37gDSBBfJ8vGW7gvVfiGeheE2NayJuA2f5iTQTGdyGjQmBgja?= =?us-ascii?Q?7K9kQJHsoO54076WYcZFXNxAdKbGklFTWIBZDCeBpUKKI1yj1dto333zNmin?= =?us-ascii?Q?icLFgRMtlh0TxIbyFj7CQ259Gp9hAdOURHWadCtkV3B0z9Itrbo1szLtcDuX?= =?us-ascii?Q?61cbTzoWKoSAO2bkZ/30OQ4y3dk2DnSndtUH8cEOFIA0+vksZSb0KlQHkfBG?= =?us-ascii?Q?Ni6tHy+vl3FJLUxgP0KOsE86mB+n/yN0xIZa3+gSq/8q0fVVq+zklzbH2PcU?= =?us-ascii?Q?dQ0xcQkAretqcwrUOG6cYWVnM3DLTWZ9Qj0S1QYMeechdegkbLrqZWZETaz6?= =?us-ascii?Q?64H81fBa4N0ynQLBVOgSwamEeG1aTNRQ3zkG52qAG4xyXQi4ivizOZ7veS7f?= =?us-ascii?Q?B6eD0zlxA/UqwmL+yIg33P2hoW3DrBqCfABb0bn8wIu2E5g639gp0KbpFSSl?= =?us-ascii?Q?EbvycCLOaoz3hk8KGDWIY7O0l6IaxRfbaKs0lQI/upoRBqkI2DfiQYz4p5oM?= =?us-ascii?Q?muSM6ZnhXCyXgDpsMR5k6ZkUCSRzRXZtrZOEcHIiQo1qXtvhOfik0TgxtXSi?= =?us-ascii?Q?JHML7eE/dQ3/e0kWpDYHCL524qmLpekF8k2fBLfTCyKNbmD5zaQBPEqKdv0U?= =?us-ascii?Q?ywOmr9zMxw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee8287e-9919-49d6-f93e-08da38b8d11a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:26:06.5315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PVBwRRLEkI0mMKte0iEHFSpjwEOlVroE52KKRBUxnV1utn9Af9HbS9xRwLEyUjkizLn2uDWOe+US1qB6H7RuoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7347 On 10.05.2022 16:30, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: >> When a page table ends up with no present entries left, it can be >> replaced by a non-present entry at the next higher level. The page table >> itself can then be scheduled for freeing. >> >> Note that while its output isn't used there yet, >> pt_update_contig_markers() right away needs to be called in all places >> where entries get updated, not just the one where entries get cleared. >> >> Note further that while pt_update_contig_markers() updates perhaps >> several PTEs within the table, since these are changes to "avail" bits >> only I do not think that cache flushing would be needed afterwards. Such >> cache flushing (of entire pages, unless adding yet more logic to me more >> selective) would be quite noticable performance-wise (very prominent >> during Dom0 boot). >> >> Signed-off-by: Jan Beulich >> --- >> v4: Re-base over changes earlier in the series. >> v3: Properly bound loop. Re-base over changes earlier in the series. >> v2: New. >> --- >> The hang during boot on my Latitude E6410 (see the respective code >> comment) was pretty close after iommu_enable_translation(). No errors, >> no watchdog would kick in, just sometimes the first few pixel lines of >> the next log message's (XEN) prefix would have made it out to the screen >> (and there's no serial there). It's been a lot of experimenting until I >> figured the workaround (which I consider ugly, but halfway acceptable). >> I've been trying hard to make sure the workaround wouldn't be masking a >> real issue, yet I'm still wary of it possibly doing so ... My best guess >> at this point is that on these old IOMMUs the ignored bits 52...61 >> aren't really ignored for present entries, but also aren't "reserved" >> enough to trigger faults. This guess is from having tried to set other >> bits in this range (unconditionally, and with the workaround here in >> place), which yielded the same behavior. >=20 > Should we take Kevin's Reviewed-by as a heads up that bits 52..61 on > some? IOMMUs are not usable? >=20 > Would be good if we could get a more formal response I think. A more formal response would be nice, but given the age of the affected hardware I don't expect anything more will be done there by Intel. >> @@ -405,6 +408,9 @@ static uint64_t addr_to_dma_page_maddr(s >> =20 >> write_atomic(&pte->val, new_pte.val); >> iommu_sync_cache(pte, sizeof(struct dma_pte)); >> + pt_update_contig_markers(&parent->val, >> + address_level_offset(addr, level), >=20 > I think (unless previous patches in the series have changed this) > there already is an 'offset' local variable that you could use. The variable is clobbered by "IOMMU/x86: prefill newly allocate page tables". >> @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma >> =20 >> old =3D *pte; >> dma_clear_pte(*pte); >> + iommu_sync_cache(pte, sizeof(*pte)); >> + >> + while ( pt_update_contig_markers(&page->val, >> + address_level_offset(addr, level), >> + level, PTE_kind_null) && >> + ++level < min_pt_levels ) >> + { >> + struct page_info *pg =3D maddr_to_page(pg_maddr); >> + >> + unmap_vtd_domain_page(page); >> + >> + pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flush_= flags, >> + false); >> + BUG_ON(pg_maddr < PAGE_SIZE); >> + >> + page =3D map_vtd_domain_page(pg_maddr); >> + pte =3D &page[address_level_offset(addr, level)]; >> + dma_clear_pte(*pte); >> + iommu_sync_cache(pte, sizeof(*pte)); >> + >> + *flush_flags |=3D IOMMU_FLUSHF_all; >> + iommu_queue_free_pgtable(hd, pg); >> + } >=20 > I think I'm setting myself for trouble, but do we need to sync cache > the lower lever entries if higher level ones are to be changed. >=20 > IOW, would it be fine to just flush the highest level modified PTE? > As the lower lever ones won't be reachable anyway. I definitely want to err on the safe side here. If later we can prove that some cache flush is unneeded, I'd be happy to see it go away. >> @@ -2182,8 +2210,21 @@ static int __must_check cf_check intel_i >> } >> =20 >> *pte =3D new; >> - >> iommu_sync_cache(pte, sizeof(struct dma_pte)); >> + >> + /* >> + * While the (ab)use of PTE_kind_table here allows to save some wor= k in >> + * the function, the main motivation for it is that it avoids a so = far >> + * unexplained hang during boot (while preparing Dom0) on a Westmer= e >> + * based laptop. >> + */ >> + pt_update_contig_markers(&page->val, >> + address_level_offset(dfn_to_daddr(dfn), le= vel), >> + level, >> + (hd->platform_ops->page_sizes & >> + (1UL << level_to_offset_bits(level + 1)) >> + ? PTE_kind_leaf : PTE_kind_table)); >=20 > So this works because on what we believe to be affected models the > only supported page sizes are 4K? Yes. > Do we want to do the same with AMD if we don't allow 512G super pages? Why? They don't have a similar flaw. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:27:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:27:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331919.555544 (Exim 4.92) (envelope-from ) id 1nrGtq-00006B-Gw; Wed, 18 May 2022 10:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331919.555544; Wed, 18 May 2022 10:27:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGtq-000064-C9; Wed, 18 May 2022 10:27:26 +0000 Received: by outflank-mailman (input) for mailman id 331919; Wed, 18 May 2022 10:27:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGto-00005t-R8 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:27:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0616.outbound.protection.outlook.com [2a01:111:f400:fe0d::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b5121a8-d695-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:27:23 +0200 (CEST) Received: from AS9PR06CA0337.eurprd06.prod.outlook.com (2603:10a6:20b:466::13) by AM9PR08MB6260.eurprd08.prod.outlook.com (2603:10a6:20b:283::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 10:27:21 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::51) by AS9PR06CA0337.outlook.office365.com (2603:10a6:20b:466::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Wed, 18 May 2022 10:27:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 10:27:21 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Wed, 18 May 2022 10:27:21 +0000 Received: from 2fd44b83d5b7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CE9BBF76-D928-44FF-9D3D-95A37BF912DF.1; Wed, 18 May 2022 10:27:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2fd44b83d5b7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 10:27:15 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4245.eurprd08.prod.outlook.com (2603:10a6:20b:b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Wed, 18 May 2022 10:27:14 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5273.013; Wed, 18 May 2022 10:27:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b5121a8-d695-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jWMslMfbM4UYrt0Nj4VIMwFBHltbbcVUm2MDOKQfLdYbX6Vqzvc2LetGDT9vvAQDZznxCf4fQe1+5CF+IxvnsPt6+u3v6twsrWpEMfXVXAhiCKC4gZSddZb+xOUpvCtSixIDStoahG0WNYWXxj7+OdLNfm+AN2iE6UtPtMPzjSVVDSrDDsWaWjqf6+Hozi+n7Ax59TVyUxF+uBDhKWW6dOBLYvk8eTDtkQFaRobV8lhsN3YAkBzcPRnUokuxHNbI3nxe0gzcHvYZ0gEpPiQJ+yCGru+czOT+XhgfE0Ng1PGGn9aH2Qx4ZLPR+pMgc4vOHOEZxuVks7sSpBuy0tzKqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C/u9bsegGF40ABK22xm6M3A046Sjx9mDSLTJX5HtTVE=; b=I4VR6YA68Jk3I7h3OiWkaF5C3+vpFVaAonNo+vL8Xw7YQUn9TYBHGdDZ0Nz73LAHMt4OT7gaVM7rBpCA3CE6cVdssR3k+yR4SiihNXx7M0wyYeuna40QIhzPic5Uu0S2yW9gsrptiFPIbVXM7lNvSE2zopPdN6jdMtM7TSUAJyUOzRfz/qQdfASoTuSoAgOtv4Pz7Mjpfojagzz8RlBbNpkHKEyEtLZMAXZH+Df662O76iwq7ut2iOMvXAtd+1CboiU+xh0pdRKwnrPigSTk+c0KjCA7UFylkdoC+QDUgSkhn/E2U77RO8mabVt1iC47UsHovc+VAvzegROXve7njg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/u9bsegGF40ABK22xm6M3A046Sjx9mDSLTJX5HtTVE=; b=kQkn3d/EQoZDaJczPR+dsyLpI+W3MwjF3INam8FHuUoH5rLsN3Y5Djl53LID9VmPFw3A/u4gKMaVuUsmtNzc46kRA1JNqTm5npGOBsAiFH5o5ifziuP5VkbTmcs3mANurOlYUKAzQGWrHaRbin2hhn8b425ZlDDh6eiQbNAleos= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8c05096e494dd342 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DuZR1uozdd4xlgKJbBNwFGQShPhCBzOnZtNmFXy4O+aGRg7/r7luh4b9t+Lj3kiM8TtLwNHcAkztNBqp8T+9aqaAHLSKOAOEccFzw++83Mg6epM/FbcADzrc/W0YFbpm+MKCY/JXBDp/1VryF37Xcf1LVZHUafnKOZ6atkF3WdtCyqYQ31QNTFD85kGOBRgYZAzzvCg54S3JXzcNCzBzP19Ps8EOGvB8a9hZmi3Z8buY4v3o4KIxD6raz3pzMQenuABWDoMfiY+gQ5I3zRw3MaIuZFGbgGhAn89dE/wrrf6ycOnNGADAnRe3KtAM0QjHrZUf2qLas5FTfukJH+DsrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C/u9bsegGF40ABK22xm6M3A046Sjx9mDSLTJX5HtTVE=; b=jY8G4o0cNPX23fvNjSC2CIMfvx3oHOrY3NjflmWTm8ChC/0nwet6NsISW9v46yOQP1Wghe8+HC3mCf/mU+gSw+8PAOngEuDWBDfB2AOnVPunkxNTsSn43JE3gYuKRsVG8AIaCHglhc8U9TFsXKbDTakghp/YwaFnf24wVUb5C+eA8O8VKxXmNyyyWDmxN3kuIr9UrRIaCwqQxWa2nsrn4b707ezXkVCg1eTjPs8ENdaGaxxaKIa1mEuVLpqEQxrRIUiCPVr6gGLNMiEjVjk0uswJ2Y6YtAGTlasqWTQsaay6YcTy2R8CUoWBoo14tVmx3pToVoQ5gDz9KBySzUkn2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/u9bsegGF40ABK22xm6M3A046Sjx9mDSLTJX5HtTVE=; b=kQkn3d/EQoZDaJczPR+dsyLpI+W3MwjF3INam8FHuUoH5rLsN3Y5Djl53LID9VmPFw3A/u4gKMaVuUsmtNzc46kRA1JNqTm5npGOBsAiFH5o5ifziuP5VkbTmcs3mANurOlYUKAzQGWrHaRbin2hhn8b425ZlDDh6eiQbNAleos= From: Luca Fancellu To: Andrew Cooper CC: Xen-devel , Juergen Gross , Dario Faggioli Subject: Re: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Thread-Topic: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Thread-Index: AQHYaiYsSobfX0tA0kCIIfR0OlvQlq0kb2CA Date: Wed, 18 May 2022 10:27:13 +0000 Message-ID: <2D47137E-C808-4FA7-B220-7022C85BBB4F@arm.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-2-andrew.cooper3@citrix.com> In-Reply-To: <20220517194113.2574-2-andrew.cooper3@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8edbb745-4017-420c-d43d-08da38b8fe2e x-ms-traffictypediagnostic: AM6PR08MB4245:EE_|AM5EUR03FT027:EE_|AM9PR08MB6260:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2gfG2UZ6T+JKBkPW2p98ixmUYzJ6jbvdv1tYhZS286qV36SpdIX0oKA+sJChfRY7sn3yOXqQMhwVCulOfQ7LYjSkG96Asg27dKOULJ/3eUwLDjfNNGXViTaryRmtlU5Alljpw4KANxpG+/MjSQazMmFr4UmDS0XJ2a/83U6fGCbYmH0Po2rUlwgg0D9nuaoBOsvkclqgr9LecCe7D7JxgTYckZAwvuzzpWTWcDjI3Ixe0b9jwnxQEQ9WJw/crzXKs53c0xFSjQIzTJ3neJ1q7wTPvLlu96OlL8MhF8pywUaQzX8qLL0aqEx30W6VC2ofGmTX6QHEHLccTfWsRgT3Uhf1Md4DHrNKTFyeHd66Qwp8aymezTLqat279/hNOnEYpbCidHrbXDE2yDs1jnOrryYZQV0aob6pTcVzWxgMi3OxCpwWkF0TEP5l6GyMTJGaes52jZ03nM+qA9hsvPV9sHWqimGC78BESHICDHEK/WBTEFbnMoyhKkclM19BqFmjgR6PtBfm6gJAegDCI6A7Vurz2YHmvGH2pf/NELSmpNSFuJrwfsuOCtqZ55LzUxH9ID5+R1ELc7eF4/mKmsewC8L4ZxX9GZO8zqTC0PQ89nIAObiyHB5DVqU33jbOSpaK/sFW1WZyE8PE0lj3R+FysGx1ExiqU+fCXdWVpIqPj1+NfRqLDF+EW+SpvT2qrZ3ZnL/HQQvfnqBqBcGriBAhmfE4hizwxWqAv3TfUjswRQFm/cTPQ5+g3PJEgCXko4Wm X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(122000001)(38070700005)(316002)(2616005)(6512007)(6486002)(6506007)(2906002)(86362001)(66476007)(64756008)(508600001)(8936002)(53546011)(71200400001)(8676002)(26005)(91956017)(76116006)(4326008)(66446008)(33656002)(6916009)(186003)(38100700002)(54906003)(5660300002)(66556008)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8DA80ECD5E48FD44B03FD023C89CA7BC@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4245 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f0491246-698d-43cb-924d-08da38b8f9a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Inidpx6Oe8f2iwXUUd0f6Gv17UtvYH0dAxOuov1gCfvx+Xb2GucF2pBMI4UAgm4ZnzKX8vLEWrMXuf/sQ3//3yBFX2gTV7OhBR54LOZTVOViN1JT/9vfYe4+JW0H3iTSR1Ze3B4l559JRYOP11COpxpNmhF93yt/B6aku7Z9cc+Hynq6vbOBjQczil6Egzkxrryq/VJVvHrokk5FtL2lxj5Lt9jKsuuLqiooAT9EMiuPmfDfyLh603K8HmZ4dRK6Sx8EWOCeDXbZc9ZlEP8kbpIx+e8x08kny9DzGceSksQZUW71qHGWr0Nn3nQkV+If/KvhMPyLGdDvFYZo75Iz140ZbiRzD8gdxBVf+eGh7YuRUcwJ8IsP1ZyvBpaIoLfP9hvXivXdJKW8bOYXBZQKjeNbMDC5WxHc3O4vL8rIYM6OzQQSo3sWiWWvI4r9cT7GPKHnBICJh3qoPkidiD4qbPhdg+IMcx3x4zok/ivQXPLj/gC8NgH8L6oAFs+PDIqMbL/+1+O4/v4tpJBjJ2fvXLd4/6it4cpgCGwORsNhcfPsLlZ3U33h1jVuXuapMlVRgLK3bdlmhyQG9a8Krnd4bQflPHZTEIUZEYg/ZSPXQcHGR2URtG9o6RGhRaUVprd8gZ9svZ+zQZbiwjiNSPD/1R4TIIabdVaCLxWtr8IVTaWQLovRycreY04TmwlcieXU X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(6506007)(8676002)(70586007)(70206006)(336012)(26005)(47076005)(2616005)(40460700003)(186003)(6862004)(107886003)(316002)(82310400005)(4326008)(36756003)(6486002)(6512007)(86362001)(8936002)(36860700001)(356005)(2906002)(33656002)(5660300002)(54906003)(53546011)(81166007)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:27:21.5341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8edbb745-4017-420c-d43d-08da38b8fe2e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6260 SGkgQW5kcmV3LA0KDQo+IE9uIDE3IE1heSAyMDIyLCBhdCAyMDo0MSwgQW5kcmV3IENvb3BlciA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBjL3MgY2ZjNTIxNDg0NDRm ICgieGVuL2RvbWFpbjogUmVkdWNlIHRoZSBxdWFudGl0eSBvZiBpbml0aWFsaXNhdGlvbiBmb3IN Cj4gc3lzdGVtIGRvbWFpbnMiKSByZW1vdmVkIHRoZSBwYXRoIGluIGRvbWFpbl9jcmVhdGUoKSB3 aGljaCBjYWxsZWQNCj4gc2NoZWRfaW5pdF9kb21haW4oKSB3aXRoIENQVVBPT0xJRF9OT05FIGZv ciBzeXN0ZW0gZG9tYWlucy4NCj4gDQo+IEFyZ3VhYmx5LCB0aGF0IGNoYW5nZXNldCBzaG91bGQg aGF2ZSBjbGVhbmVkIHVwIHRoaXMgcGF0aCB0b28uDQo+IA0KPiBIb3dldmVyLCBjL3MgOTJlYTlj NTRmYzgxICgiYXJtL2RvbTBsZXNzOiBhc3NpZ24gZG9tMGxlc3MgZ3Vlc3RzIHRvIGNwdXBvb2xz IikNCj4gY2hhbmdlZCBkb21haW5fY3JlYXRlKCkgZnJvbSB1c2luZyBhIGhhcmRjb2RlZCBwb29s aWQgb2YgMCwgdG8gdXNpbmcgYSB2YWx1ZQ0KPiBwYXNzZWQgYnkgdGhlIHRvb2xzdGFjay4NCj4g DQo+IFdoaWxlIENQVVBPT0xJRF9OT05FIGlzIGFuIGludGVybmFsIGNvbnN0YW50LCB1c2Vyc3Bh Y2UgY2FuIHBhc3MgLTEgZm9yIHRoZQ0KPiBjcHVwb29sX2lkIHBhcmFtZXRlciBhbmQgYXR0ZW1w dCB0byBjb25zdHJ1Y3QgYSByZWFsIGRvbWFpbiB1c2luZyBkZWZhdWx0IG9wcywNCj4gd2hpY2gg YXQgYSBtaW5pbXVtIHdpbGwgZmFpbCB0aGUgYXNzZXJ0aW9uIGluIGRvbV9zY2hlZHVsZXIoKS4N Cj4gDQo+IEZpeGVzOiA5MmVhOWM1NGZjODEgKCJhcm0vZG9tMGxlc3M6IGFzc2lnbiBkb20wbGVz cyBndWVzdHMgdG8gY3B1cG9vbHMiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxh bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpUaGFua3MgZm9yIHRoaXMgZml4LCB3aXRoIHRo ZSBpbnRyb2R1Y3Rpb24gb2YgOTJlYTljNTRmYzgxICgiYXJtL2RvbTBsZXNzOiBhc3NpZ24gZG9t MGxlc3MgZ3Vlc3RzIHRvIGNwdXBvb2xz4oCdKQ0Kd2XigJl2ZSBjaGVja2VkIGFsbCB0aGUgcGF0 aCBwYXNzaW5nIHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiwgYW5kIGF0IHRoYXQgdGlt ZSBpdCBzZWVtcyB0byBiZSB0aGF0DQp0aGUgbmV3IGNwdXBvb2xfaWQgbWVtYmVyIHdvdWxkIGhh dmUgYmVlbiBhbHdheXMgemVybyB3aGVuIGNyZWF0ZWQgZnJvbSB0aGUgdG9vbCBzdGFjaywgYW0g SSB3cm9uZz8NCg0KSeKAmW0gYXNraW5nIHNvIHRoYXQgSSB3aWxsIGtlZXAgaW4gbWluZCBmb3Ig dGhlIGZ1dHVyZS4NCg0KSG93ZXZlciB3aXRoIHlvdXIgc2Vjb25kIHBhdGNoIG9mIHRoaXMgc2Vy aWUsIHRoZSB0b29sIHN0YWNrIGlzIGFibGUgdG8gd3JpdGUgaXQsIHNvIEkgZ3Vlc3MgdGhpcyBm aXggbm93IGlzIG1hbmRhdG9yeS4NCg0KSeKAmXZlIHRlc3RlZCB5b3VyIHBhdGNoLCBlbmFibGlu ZyBib290IHRpbWUgY3B1cG9vbHMsIG9uIGFuIGFybSBtYWNoaW5lIGFuZCBib290aW5nIFhlbitE b20wIGFuZCBhbm90aGVyIERvbVUNCmJ5IGRvbTBsZXNzIGZlYXR1cmUsIGFuZCBhbGwgd29ya3Mu DQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQpU ZXN0ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KQ2hlZXJz LA0KTHVjYQ0KDQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 10:30:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331928.555555 (Exim 4.92) (envelope-from ) id 1nrGwk-0001bj-2v; Wed, 18 May 2022 10:30:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331928.555555; Wed, 18 May 2022 10:30:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGwj-0001bc-Vz; Wed, 18 May 2022 10:30:25 +0000 Received: by outflank-mailman (input) for mailman id 331928; Wed, 18 May 2022 10:30:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrGwi-0001bV-95 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:30:24 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060f.outbound.protection.outlook.com [2a01:111:f400:fe02::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85e0613a-d695-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:30:23 +0200 (CEST) Received: from AS9PR06CA0233.eurprd06.prod.outlook.com (2603:10a6:20b:45e::14) by DB9PR08MB7116.eurprd08.prod.outlook.com (2603:10a6:10:2c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 10:30:21 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::f2) by AS9PR06CA0233.outlook.office365.com (2603:10a6:20b:45e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Wed, 18 May 2022 10:30:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 10:30:20 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Wed, 18 May 2022 10:30:20 +0000 Received: from 9695ccb5b0bd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 173B6B28-3649-470C-99C3-F3C1A982BBF1.1; Wed, 18 May 2022 10:30:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9695ccb5b0bd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 10:30:13 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB7PR08MB2970.eurprd08.prod.outlook.com (2603:10a6:5:17::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 10:30:11 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5273.013; Wed, 18 May 2022 10:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85e0613a-d695-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gJeiYDRgmKjEMdLgnwCa4NcDZECUEHA2NUWYIrsc52qpdCyHP1L40cM4sK7/vGWzY/kPcEyyQaVWh4qNn61piq5yYZUAEBD1tROTFh3LZt7/bXzNHamvxVACEjlk0t97cgi7aIzRcWS0h4lEVDJuMtHtrIGUZmd2rGTmKjiODSO10Dbxo13BEiy7kS6dbSg+W7Mpmj3BIHRF3lHLO6uv3vm3cKCKokmUgL76AYDImpXqzANcaGIelowcX8+1v8oMFt9qvPbZWD2aY9BQIM3SB60WKZnYKxsNa1zB1uK4IZiCwk25309FzgLzLr9jhJLRGYDbWwixXvTB4I2rrLGrVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=eHViKsD6j4IcEZ8Y5DQxGtSOZHrhEErH+qdo1veo9uNF12pBqvwx24pMyZaKvwQ97aCkJWAxsLAMsyol30R/KIxl6n4OnyX8TjPE8WpFDMf+XNM1Bj3KXGtA0wa174N/MLwJbSSJjW8SKNAmmOHbF6BOwUgkLzBxEn9hOdzACAHu9U8NmItCUH3ka6NyctJBgePpg4AThU7E0UxlcFV+Q6k6EfrKsXdcT6RhO7J6L+L0SmLGjQxTCnmbIq23xB43XuAGachkAWLyREzTVcP2gzsHpQntJ6pydWcZJxPqb3eyaheUwM1pOwvNwZrUPRQAkM15TpVDRG3IoMX1TvDlfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=HQK8WsP6kX0Rr3yJwlJgfvU8WCEY4nUq1EGWookE85i0yRZ64ngICltJxxkpMfuKesIDI2IezJsa6dzP9UriwoEDPcdl8fgKMwEcyq2pAjbdEmczPhu//Dok+XDmQ/pl80tMGUjCizAt7YCMPKAQwXwHc+OoYiqoEpJc1Wwdx8Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4a097301f8941428 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htMw2NHrwKFwubg/OrC+HCJsgQi4wHlYAiUNi85vzzdlGLN4VA8iDVWB0BQxcFNjyAXhYsiIPu5/TaFxBkQhJXAuJy1CwjqA0mtmdb4lV3LV7OT4cPowinylQjWnVsInSZghh6ko1Z1eF48fs5W41YWqIh5u4hoFnS1pkpsbbFYGMXfbOCfkE6KjA/0kVWzGJaWbP1J6Lx6KVCw4i7/imXclo+Q241EZPLThC5QaN3hlUXcckXZDkmP3ZKZzLjK7Ikre2AFui5WG0b3X4Uc9/pqyzLnzxuaggAct2ILJpcv3tttEA+4/TAi9efO7Et6GwfVPu/Mew2qq8YCZ7ZcGyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=Pw9Tp8OkRgtQbP/Vd94JJtooELYM/zSBhP0ZMstascMnHSKyrEVv8fc2Jsgfyu4VADPsV+uRqMmZExqvNjcVbdOl2wGEmFqshfwVTtQtGdc+XsZ2RxgAVCnc+PMxJtsMYyjtxNV/CCimFuz3L9z+ueOBI4+MKEOgqBpihBUxiYrTAfa3a22PFMpXbRQMIY7X++OBSlFBaoSSG5cYN6glwt5EEUDESqNVRssd+7e9VZQxZpP7wJaN/2eUsrWLQHiaFXLRTDzzVle7HCd0poHVXofXNX7E98hBypbp3G1+QVyOCOE2t+vTEKLtoFq3cr2xdIzvmSIUfFKRB31iKgVUrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=203D1QyzL6Qc/anx+STWZ6pvbF+5VSeHiEpMmn7+SGw=; b=HQK8WsP6kX0Rr3yJwlJgfvU8WCEY4nUq1EGWookE85i0yRZ64ngICltJxxkpMfuKesIDI2IezJsa6dzP9UriwoEDPcdl8fgKMwEcyq2pAjbdEmczPhu//Dok+XDmQ/pl80tMGUjCizAt7YCMPKAQwXwHc+OoYiqoEpJc1Wwdx8Q= From: Luca Fancellu To: Andrew Cooper CC: Edwin Torok , Xen-devel , Christian Lindig Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYlhlRp70KGIk+7qOp/vtrSaK0kZYcAgAAF1oCAAATWAA== Date: Wed, 18 May 2022 10:30:11 +0000 Message-ID: <107B2C8E-59DF-4D7B-A6E1-E136E702AB96@arm.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8b4af59c-5acf-44a0-0f87-08da38b968d0 x-ms-traffictypediagnostic: DB7PR08MB2970:EE_|VE1EUR03FT059:EE_|DB9PR08MB7116:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1CB/rl5k+qKCJHBeHXy2qghO4BI5nAU+qJxqppMItLNP0scxLH+PJ4PgjY5qxXjkaA8bzzgBtdMEY+Gmv5X8pYQAxvXimSndD019mUmpbF/1ju04GxiORqWVJ77UV7tqY1CSOF3E+xhsnyxZ1aX0HUFXk9xPl471spzhiBy5ziGex6kZGTRh5Ek2x7TzVjFMi7oTrw4ZDx/xsz4cDKCpW98AQyKuex1W0pwqC1R2sSsg0LRNRYGAKsmexF0RHtK3EL9w6VUPJ3oUtIM75KU5Fh8PMYr2N/Shlkfr2n9uJbaVc/oKzb53ZppW29zkmOHl/V2d83WyXYpqMDPiuO42/qvMmBuUJ0Fcxr6gts0srLNiW6y3OHEKsTV9Owas48U1ZkxE0KR83ntk8Me8XvINSjJGGjU57cmi5EWzTc7mFsCSuvNedEJOISg5i8R4WNHOz+OcmKgqKlDiUekB87TBBgUwF4lGTmkHnXE5nObObHzDAl5nPPGgYVc7LOmjuGbONXTHHqfwmad01vw2dt3UZfSDJwIRKzN7DS1KkrpH9vWmNRjoyAQ+ioQ7ndHkWUsB7p9uzQHJlBVivGP3POgHgZnQ6bI8688V1GS0JbIEfV0flWH2a0g5XWVJUaJs63ckkGq79sZNZFRaVPe2pNOrZHTVXdLbzH6qwbdogejQxB+gqjIJRl8F7vKKiUqZf1lrIMZR/REcZMOJ3R3hzC61JwaBo5aDXVK6pFr8QKFX/nLqaox8AxIAVwVP7VhhYnVD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(2616005)(8936002)(76116006)(5660300002)(53546011)(6506007)(508600001)(26005)(33656002)(2906002)(86362001)(6512007)(38100700002)(38070700005)(122000001)(186003)(71200400001)(8676002)(91956017)(64756008)(66446008)(66556008)(36756003)(316002)(54906003)(66946007)(66476007)(6916009)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8C17203CD3A0F44DB1221269DA2712DD@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2970 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7181b972-d4ba-4957-b454-08da38b9636d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L6CV/WBlFMBg6i8dl9sK3hr9LB6yt0vbF7T6S2sBpSKTZT/KyxEjDA2ACf1ttu2LS76XjdTpXMteFN47tcaYFYLYM3eUv8YxdBj74OWUIrcwFqvPX79dZBVu4l7gYZuG2oDLCG2Tn20/1jRA0XnaJddFKI1JV0EnlCXRfpUe5yfTSc+U8e2yyoLnK4EGiy+Tk44OP+TkfQzzTjfsbO3ldJd/7ksiuhczgEXze6ParhPPynQZMdjPrTcCmNkVEIRjmMB5BKn89Jw5nBIbB3p6wLE09c++LI6rubFVSJZc87gn9JOy9UghfufG+RBYNabVBNJSDLh1Rxu/pQ3t4nZ7uKAmdz3axi50rpfc0cGIMENM48YQ7TcCfJpRD0ms8ZBO586Ck8kjhOLH9mKsCE8L0MWSnqMEZ16I4sMwQMNk66hcypM4HhA//KrTauocN0QpUuUp+t8ElAPww675iiub2X7UrlfUcBz4QXVlVuxY10ZWUsC2eaE9uZlfw9jCc5xjBgMnwnNc3VYsCfwviDoau2kGux9BVPLa8AlRHuKiaQuFAAj5zjlqUaSXwcd2UUL9D/66alinjXcPaLpu3RQdl0I+vq8oeV7YRnnrxDfEXjH7hT2HjTxD2K53Ak8ktYGE7VhMV7cODoD2I0gWq6Gs/zCCs8YlzAAmGIMX4cESlvia6qInQPnDg+JV6Y5evyyL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(186003)(336012)(107886003)(53546011)(356005)(2616005)(86362001)(36860700001)(47076005)(40460700003)(81166007)(6512007)(8676002)(4326008)(5660300002)(36756003)(70206006)(70586007)(8936002)(82310400005)(33656002)(6506007)(2906002)(6862004)(54906003)(6486002)(26005)(508600001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:30:20.3884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b4af59c-5acf-44a0-0f87-08da38b968d0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7116 DQoNCj4gT24gMTggTWF5IDIwMjIsIGF0IDExOjEyLCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDE4LzA1LzIwMjIgMTA6NTEsIEVkd2lu IFRvcm9rIHdyb3RlOg0KPj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0 cmwubWwgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+PiBpbmRleCA3NTAzMDMx ZDhmNjEuLjhlYWI2ZjYwZWIxNCAxMDA2NDQNCj4+PiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hj L3hlbmN0cmwubWwNCj4+PiArKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+ PiBAQCAtODUsNiArODUsNyBAQCB0eXBlIGRvbWN0bF9jcmVhdGVfY29uZmlnID0NCj4+PiAJbWF4 X2dyYW50X2ZyYW1lczogaW50Ow0KPj4+IAltYXhfbWFwdHJhY2tfZnJhbWVzOiBpbnQ7DQo+Pj4g CW1heF9ncmFudF92ZXJzaW9uOiBpbnQ7DQo+Pj4gKwljcHVwb29sX2lkOiBpbnQzMjsNCj4+IFdo YXQgYXJlIHRoZSB2YWxpZCB2YWx1ZXMgZm9yIGEgQ1BVIHBvb2wgaWQsIGluIHBhcnRpY3VsYXIg d2hhdCB2YWx1ZSBzaG91bGQgYmUgcGFzc2VkIGhlcmUgdG8gZ2V0IGJhY2sgdGhlIGJlaGF2aW91 ciBwcmlvciB0byB0aGVzZSBjaGFuZ2VzIGluIFhlbj8NCj4+IChpLmUuIHdvdWxkIGl0IGJlIGNw dSBwb29sIGlkIDAgb3IgLTEgaWYgY3B1IHBvb2xzIGFyZW4ndCBvdGhlcndpc2UgZXhwbGljaXRs eSBjb25maWd1cmVkIG9uIHRoZSBzeXN0ZW0pDQo+IA0KPiBjcHVwb29scyBhcmUgYSBub24tb3B0 aW9uYWwgY29uc3RydWN0IGluIFhlbi4NCj4gDQo+IEJ5IGRlZmF1bHQsIG9uZSBjcHVwb29sIGV4 aXN0cywgd2l0aCB0aGUgaWQgMCwgdXNpbmcgdGhlIGRlZmF1bHQNCj4gc2NoZWR1bGVyIGNvdmVy aW5nIGFsbCBwQ1BVcywgYW5kIGRvbTAgaXMgY29uc3RydWN0ZWQgaW4gdGhpcyBjcHVwb29sLg0K PiANCj4gUGFzc2luZyAwIGhlcmUgaXMgdGhlIGJhY2t3YXJkcyBjb21wYXRpYmxlIG9wdGlvbi4N Cj4gDQo+IEFuZCBvbiB0aGF0IG5vdGUsIEx1Y2EsIHlvdSBvdWdodCB0byBwYXRjaCB4bC9saWJ4 bCB0byBhcHBseSB0aGUgcG9vbD0NCj4gc2V0dGluZyBkaXJlY3RseSBkdXJpbmcgZG9tYWluIGNy ZWF0ZSwgcmF0aGVyIHRoYW4gZGVwZW5kaW5nIG9uIGNwdXBvb2wNCj4gMCBleGlzdGluZyBhbmQg bW92aW5nIHRoZSBkb21haW4gbGF0ZXIuDQoNCklzIGl0IGFuIGVuaGFuY2VtZW50IG9yIGEgYnVn IGZpeD8gRnJvbSB3aGF0IEkga25vdywgcGxlYXNlIGNvcnJlY3QgbWUgaWYgSeKAmW0gd3Jvbmcs IGNwdXBvb2wwDQpJcyBhbHdheXMgcHJlc2VudCwgc28gdGhlcmUgd29u4oCZdCBiZSBwcm9ibGVt IG9uIGFzc3VtaW5nIGl0cyBleGlzdGVuY2UNCg0KPiANCj4gfkFuZHJldw0KDQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 10:38:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331936.555566 (Exim 4.92) (envelope-from ) id 1nrH4p-0002O3-W2; Wed, 18 May 2022 10:38:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331936.555566; Wed, 18 May 2022 10:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrH4p-0002Nw-SM; Wed, 18 May 2022 10:38:47 +0000 Received: by outflank-mailman (input) for mailman id 331936; Wed, 18 May 2022 10:38:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrH4o-0002Nq-Kr for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:38:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afd4306e-d696-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:38:44 +0200 (CEST) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 06:38:41 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by DM6PR03MB5241.namprd03.prod.outlook.com (2603:10b6:5:24c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 10:38:38 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:38:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afd4306e-d696-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652870324; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wYwl+OWIRYokE3kXxn1dDJyajJTxDekBQ4MH0IYhV/s=; b=iZNcsNRIZk7/an6pmohD68WB8D1Ttz22A99nNhiK3xlfoeHdEE0DPbSa wAMa3heqa6Go+z8IUvxPbnSYdxU1XugVwYQf1lfa/V/aoh4DUJpAQos4W TpF9klM8Wm6WfCmgSTDMbG+HElTcd0iyVW4u+JDn5/ZKwEXLp0FqO1mHJ M=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 71575258 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ejpw1a027UdTx6zm6vbD5aNwkn2cJEfYwER7XKvMYLTBsI5bp2YAy 2NLC2iHPvrbYWL3e90laI60pE8GupOBm9c2GVBtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1niqG/SzsyZ5eXgeocTTYfSHhTOoRvreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfySvbe03x9p7ixKNdTXY cdfTDNrZRDJZRBnMVYLEpMu2uyvgxETdhUH8Q/K+PBqswA/yiRN/ZKzLP3tS+a4G+BXnB2K+ WLX+nb2V0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwK8iG6JuFgbQdU4LgEhwASEy66R5hnDAGEBF2ZFcIZ/7JdwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:odaeAKOHSUWvW8BcT2P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+r5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa33ZcjEBS5tL7tUYvJ7f2qYUh3rA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CXQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9CS7kISaXOxDqBasHM3XCp9r+56g0/vijfNgSwJ47iP 36ISdlXK4JCjfT4OG1rex2G0r2MRuAtBzWu7Fjzok8vKHgT7z2NiDGQEwykqKb0ociPvE= X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="71575258" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnisSz9gG+b/NlGwQXfdF+83LTa+riVbDQ7NQVWDfALFecrBBuJUCRCNOkQ+8abNFSoCFbjFAqUm1zix/7JWP1pRsHwFGPEO4xxGzqj4TrvODzwkaOyoU2NQByhuPoDZes2eqUTB1I7dg2A5r6az637ae1QAoI8tzbJXvRSVKgylorwdN43mMaZL/P9xo3JvHrIkXMzzjucXhBAnItbTmH9I+i8xx/hUd06epIcAEeYEG1GLs0DV/IEBTWzptVxEqA1iP/9EWEjENQfX3D1gy9ORVlAJFR3mjAR7MMbvDYAoM2vZP7rohopgwgdR7TJCUuLQoK4ifLpDlR1tW3AfqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wYwl+OWIRYokE3kXxn1dDJyajJTxDekBQ4MH0IYhV/s=; b=eHc7bKQc0Lv+xxvnbFBwVnNEy/MlWOKQk7zx+6ph3ghUCByNdckxGNMFcItIgXWu5FL/qW8DQ0BuC/vgeyDG9T0VBaRNcuRGZpEt42qi83WPzOZK/Q3twfQobnbn9IXAqm2rwI4ytQ7FAouT3drlZ++IywBoMln8BoUgLWmNqgPu/u4P8v93L1ILbtTu+fKp6yR68RzX2xTnZFoPCJOYNgrXAxnDc1youtH5SKhTQHvB20fziIo4RKbBISbZtANUcM0n1nwl7Ma72NzqDSIFETUJj7LWwK4JOBNZ/NCJvCNOeGcWMFtNO2n1CaXQSoj1dNrGf48E3rKED+cBQQi6LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wYwl+OWIRYokE3kXxn1dDJyajJTxDekBQ4MH0IYhV/s=; b=tmWLIziVZUuczASmDwawweETs53PyopF4AyX9atqi+57rGVEB8lWQQSstcbtsfMBxXKTDOEso8a4MgWQQzVIWls6tHDDrJyICODA6BZb2pJlUKxq5QGOe30DgQKLcdvbK44wlfj21gwARtg6i+K+bQyJuZ8tqlgMaufsjPlxT20= From: Jane Malalane To: Jan Beulich CC: Xen-devel , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Topic: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Index: AQHYZUnyc7oF7QLoj0+gbrrX4WFU9K0c9NIAgAduj4CAABjlgA== Date: Wed, 18 May 2022 10:38:38 +0000 Message-ID: References: <20220511151423.20241-1-jane.malalane@citrix.com> <3db124b9-6ab7-f9e7-3c2c-13d82894bdbf@suse.com> In-Reply-To: <3db124b9-6ab7-f9e7-3c2c-13d82894bdbf@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3863782a-426f-424d-30dd-08da38ba91a6 x-ms-traffictypediagnostic: DM6PR03MB5241:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VoqZoRas3+ry3CdwLc6TLSP/mcRqK6lD6wglYKlJyY4dLt865yv2rh21DtG3FumRSfHBhP2w31ZBAqSnRw+36RxEiquGucVFPddAPH6PJvkBLbQwLnVTjMcFcMV11tvDFMXurzncS5eVLbOLTK1ZnE4ecgJYyMRklD4RIBkBp6PrTVEgcPRpckxq8gb97lBYIt8Ops9AcLlqvakkrcOksFR4L4ptxFi2tdjRsmK5c15/wtf5dIyTqn03Ta3XLeokZyGNIYk7eh3ELEjP9ktiNaf12VxAB7O90xUOVgOmBpPpdglC5WHRxiARfYB0ezxmuHDbfJAb/r4KxCzM0kbOKWSoAGdP423kCDVcNCG7Nb0pOjBKMXLZyI2A/jSqxeiYKY0oZznzMhaNhsB9BGdVrUALzakt75re+MKPO8M3L3UVt8NoP95mjOnpClXTv7K5eX8+Qwk9/MJz8A3I/ee9c4idLyVDRUXwbEgPRvQl5khI5+uFmY3m6jwjnszjE25q/Q3UIPw+qB8I05ZC0lmJMufA4f0r4NPAaCwxZUICnrWWYWoKhNJuRBipzesM+9RN0gR/F1lpeT6kTSysYGqRxgFTf2Th0fzI2zBkr0/ayCOM1Wp4aVPTJRDZwvcSrcgUS7nPuVGtQtnInyzH2Ayh2nP/kTjReRgfISa1u4vyq9tYx1j7h2T3l1NXfWmrY0tJyGFHe0NQivwx8rHPN0KcvoGNSHAIVTuYeKAy7A/dN4s= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(31696002)(82960400001)(83380400001)(36756003)(316002)(54906003)(4326008)(8676002)(6916009)(66476007)(31686004)(91956017)(66946007)(66556008)(71200400001)(64756008)(66446008)(5660300002)(76116006)(6486002)(6506007)(53546011)(38070700005)(2616005)(8936002)(38100700002)(122000001)(26005)(6512007)(508600001)(2906002)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dU9QMW9Nb1NuVm53cmtzQzhiOHU1U3BVUVRRTzJjRjFrWVBwMHFhYTFmaUdL?= =?utf-8?B?UU9yQmJPcHlHQzUzTmc2UGhYSitDajFBL3ZVdlc3MVE2c05XU25wZkovMi9q?= =?utf-8?B?MExwSHBlcUQ0bjlZT1JzUHU1UVhUblVwTkdab2k0QVZJWWxyZUUrb2VGQnRB?= =?utf-8?B?djhkTUR4bGF4T0pKZERLUGFoa1dKcG5UVjY2V3NMR0FxT0hoazM2RU9oUmJm?= =?utf-8?B?OGFNem5VVUh6blRXQkp0cjhUYTlvcmRHNWMrMnNqWVgzQTUrU0lCSWhSZnBQ?= =?utf-8?B?NG9oOWV0bHpjeWVSRFB3dUR2UkExNWlJTnRVa0NsUU5CZWlzU1RjL2FuRFFn?= =?utf-8?B?ckhZN09RcmNnVzhyYXQyTVU0QUZHRzYxUW5JOVl3eHBVc25WZFJ2bkVqNENu?= =?utf-8?B?VGZwdmVqSjhnVmF5dVFvSkJzN0hZRk1KbXJ4UmIwb2xVZXFQL0hMM0FUZ2Fz?= =?utf-8?B?ZmZCYkgrK1JIRnFRL3J3UUp6YW5yQmVYN3NoaHdRdHNabzNrelVXbDBmUGNp?= =?utf-8?B?NW1CeDh3UjROQVhNdGNBTGNyWHhlc1QxeHk0UUxZWldmWGR5RTgzb0c1cDRG?= =?utf-8?B?Vm45WklWcjRzMGNSbVJBdkVKbUIrdEVmUDNTY2JZdEJwU1UzRTRlQjNzT2hZ?= =?utf-8?B?KzhPaHR2RDIvbkxRRzFPcldodkRoWUVRVGhZUjNESlFNUnZMQld3MzhOYmNB?= =?utf-8?B?YW9XSHJTVTZtV0plRlZHWG52MGdOTWFpZDJZM1FUS1NzeDZucnQ0ZEk5YkVv?= =?utf-8?B?SFlOTkM1K0l5aEsvT0t5dm1jSVBMSWwzU1ZSdEdBMEU4Q0tmOWRocm8yTzl5?= =?utf-8?B?QVlDVzRFVU92UkNQTjVzL1h1N0tVQnNkaHBrYktxOGdPallkOHM5QTEzUGh6?= =?utf-8?B?RmNvcXBRR0YzazFKOGZGRE5pWHV6b0NCVnByckJTeGpyUTd5bW9pbGZ4Rk9n?= =?utf-8?B?d0hmOCsxazc3MWZUbDE3OUk5MVkwRHVoSmt3VUduUEpteFZZNU9xQnpWTGlG?= =?utf-8?B?WHJBRHZwVjdERVZtVzV3VEdEZXRRR0thYlJIaUFKMUdaQ25obTF6M1ByQnBK?= =?utf-8?B?ZlpHbVoyOHd3bFhnQzBYbUdVcGpMajlWUFVzdWIrMTNoVFdyM3ZzSDA0QklT?= =?utf-8?B?T1lnUUVzbG9zaGM0c1d5YTFIaWV5bFBhRVFKeEkydi9vMW55enc1bmcxekF6?= =?utf-8?B?cFR2WXlTT0JrTnNLTEJoZmVVU2xHS1RoSDhTcjZQTWF1bWNMZWtGcS9MUUU1?= =?utf-8?B?dlhkbi9EU0dZNHFJTFNvbU9qWGlzUGdnSzRHWWZ3WjBwZnZGb2doeWk3T04v?= =?utf-8?B?RlBWdFhnaXpyU1I4TTNyemJDMFUwOWpVdTVhUFR2cFJPRzRzVllRSk4zOHVq?= =?utf-8?B?Zis5VnJpNW9pNkw0VXhtSkxnY0JpMzJaVlJHUmttUkRZRGhyY09lUUdRTGlt?= =?utf-8?B?L3g4OHk4cFVBdHh5d1NjdjI3blV3TnZQdDFFdk52a2p5KzhMK3pDL3dMOXdw?= =?utf-8?B?Q25XWFZGVUJWaXVKRk1lK3g4U3I4enEwZUpwOXpxSWVSM0tsNitVbDhIZmFv?= =?utf-8?B?SnpELy9YVUx4V1MvR00xRzFROHVwM01pT29Zc3ZJQ1NpQmhrZys2eEhHSUp4?= =?utf-8?B?K1dhd2c5MGlTRVdQQUlSN2I2NzhzNUE0c1RMMlhFYTF3N2tpalVCWWM4elFo?= =?utf-8?B?cXlBeVFxNGg3UTRram5uaGp4Zzl6RjRqWTVob2h3UjJJb2NPNkRpeDNKRSto?= =?utf-8?B?Uks3MUdOazIrZHFSS1QyNStIYmMrekRnZ1JjNWhLZFJSTmtOKytCM2Z4K0da?= =?utf-8?B?bktxODJKZVB0RzVraWJlL2RWMkJDalByRkxMK1V1dE15TExyaHM0SnUxamt6?= =?utf-8?B?Y2ttK1dEVTlrelRtRHRHcWNyMDBURzkvanExUnNoOEhPSXlXYzZlM0s0UzhV?= =?utf-8?B?L2xERFRVbmRwT003dW42TzYvQ3JCTDN5cDlRa0I2OThaR0hvKzhOSnIzekFa?= =?utf-8?B?bFVnTkQwUzZ5cG5NQnVvMnFUelpoRS9SYXhVYWtIOUprbmJvSExiMGQvRDlL?= =?utf-8?B?STJBeC9GakVLVmFhVXdZdW1ZclBBMWpYVzI5TzV2bXZBSWYrOTRYbWRxZkda?= =?utf-8?B?UThVdDFTSFRpSi9MSDlwSWJjTmFRL2NQMVA0aytnVGNBcFRqRXZvQ0lWMWV3?= =?utf-8?B?WnZvOVByMjdUOTAxNVplSzc5U1NIakZUTjFZTWtYNlhvaEltWkFtTEhkdXAr?= =?utf-8?B?NnRhMlUreXVzRXE1amFnRHQrbWVzb25kOFZCUnRrTG9hMHVNWTJyYUtEOUhr?= =?utf-8?B?UXZBR0RPWVpSVDk4VThyYjh0cmN3bkwxT2RPS3NvWFVseXA2RC9JN2J3eEJ1?= =?utf-8?Q?cZuqpG5ABd3TC83Y=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3863782a-426f-424d-30dd-08da38ba91a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 10:38:38.4694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6zj3wZbqSCTWZRx804YsFE+e5UUNk/hNuHzb2wJhZKw4mz6S9aAsj85qAPMmA0X6PXVgWb9cuDT8Q2LekLJ4VuuB67/7D/by1O2txx/1UvU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5241 T24gMTgvMDUvMjAyMiAxMDowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDEzLjA1LjIwMjIgMTc6MzksIFJvZ2VyIFBhdSBNb25uw6kg d3JvdGU6DQo+PiBPbiBXZWQsIE1heSAxMSwgMjAyMiBhdCAwNDoxNDoyM1BNICswMTAwLCBKYW5l IE1hbGFsYW5lIHdyb3RlOg0KPj4+IEhhdmUgaXNfaHZtX3B2X2V2dGNobl92Y3B1KCkgcmV0dXJu IHRydWUgZm9yIHZlY3RvciBjYWxsYmFja3MgZm9yDQo+Pj4gZXZ0Y2huIGRlbGl2ZXJ5IHNldCB1 cCBvbiBhIHBlci12Q1BVIGJhc2lzIHZpYQ0KPj4+IEhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3Zl Y3Rvci4NCj4+Pg0KPj4+IGlzX2h2bV9wdl9ldnRjaG5fdmNwdSgpIHJldHVybmluZyB0cnVlIGlz IGEgY29uZGl0aW9uIGZvciBzZXR0aW5nIHVwDQo+Pj4gcGh5c2ljYWwgSVJRIHRvIGV2ZW50IGNo YW5uZWwgbWFwcGluZ3MuDQo+Pg0KPj4gSSB3b3VsZCBhZGQgc29tZXRoaW5nIGxpa2U6DQo+Pg0K Pj4gVGhlIG5hbWluZyBvZiB0aGUgQ1BVSUQgYml0IGlzIGEgYml0IGdlbmVyaWMgYWJvdXQgdXBj YWxsIHN1cHBvcnQNCj4+IGJlaW5nIGF2YWlsYWJsZS4gIFRoYXQncyBkb25lIHNvIHRoYXQgdGhl IGRlZmluZSBuYW1lIGRvZXNuJ3QgZ2V0DQo+PiBvdmVybHkgbG9uZyBsaWtlIFhFTl9IVk1fQ1BV SURfVVBDQUxMX1ZFQ1RPUl9TVVBQT1JUU19QSVJRIG9yIHNvbWUNCj4+IHN1Y2guDQo+IA0KPiBP biB0b3Agb2YgdGhpcyBhdCBsZWFzdCBoYWxmIGEgc2VudGVuY2Ugd2FudHMgc2F5aW5nIG9uIHdo eSBhIG5ldw0KPiBDUFVJRCBiaXQgaXMgaW50cm9kdWNlZCBpbiB0aGUgZmlyc3QgcGxhY2UuIFRo aXMgZG9lc24ndCBkZXJpdmUgaW4NCj4gYW55IHdheSBmcm9tIHRpdGxlIG9yIGRlc2NyaXB0aW9u LiBJdCB3b3VsZCBiZSBvbmx5IHRoZW4gd2hlbiBpdA0KPiBpcyBhZGRpdGlvbmFsbHkgZXhwbGFp bmVkIHdoeSB0aGUgbmFtZSB3YXMgY2hvc2VuIGxpa2UgdGhpcy5JbmRlZWQgaXQgaXMgaW5jb21w bGV0ZSwgdGhhbmtzIGZvciBwb2ludGluZyB0aGF0IG91dC4NCg0KSSBjb3VsZCBhZGQ6DQoiQSBD UFVJRCBiaXQgaXMgYWRkZWQgc28gdGhhdCBndWVzdHMga25vdyB3aGV0aGVyIHRoZSBjaGVjaw0K aW4gaXNfaHZtX3B2X2V2dGNobl9kb21haW4oKSB3aWxsIGZhaWwgd2hlbiB1c2luZw0KSFZNT1Bf c2V0X2V2dGNobl91cGNhbGxfdmVjdG9yLiBUaGlzIG1hdHRlcnMgZm9yIGd1ZXN0cyB0aGF0IHJv dXRlDQpQSVJRcyBvdmVyIGV2ZW50IGNoYW5uZWxzIHNpbmNlIGlzX2h2bV9wdl9ldnRjaG5fZG9t YWluKCkgaXMgYQ0KY29uZGl0aW9uIGluIHBoeXNkZXZfbWFwX3BpcnEoKS4iDQoNCldvdWxkIHRo aXMgYmUgZW5vdWdoIGNsYXJpZmljYXRpb24/DQoNClRoYW5rIHlvdSwNCg0KSmFuZS4= From xen-devel-bounces@lists.xenproject.org Wed May 18 10:41:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331944.555576 (Exim 4.92) (envelope-from ) id 1nrH76-0003iv-CQ; Wed, 18 May 2022 10:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331944.555576; Wed, 18 May 2022 10:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrH76-0003io-9S; Wed, 18 May 2022 10:41:08 +0000 Received: by outflank-mailman (input) for mailman id 331944; Wed, 18 May 2022 10:41:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrH74-0003ii-Sa for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:41:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05007d30-d697-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:41:05 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-ieELDBSmPr6ZexYzmEP7Jg-1; Wed, 18 May 2022 12:41:03 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2314.eurprd04.prod.outlook.com (2603:10a6:3:24::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 10:41:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05007d30-d697-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652870465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zUV2LAAnja/OWPTOsm2RC3+RN5iYLFD5o30dAUcg4c=; b=Nq89BswF0Zki4yFYct+1GeXZPfLEVNo5W4mwI97Y5cI43IWIfHbGFYEUvWlLoHlL1NZMcP 0HLBvNN2ueWyhaDgowH0ug+lW0S+0IVcHcfLXNmXzUTW9ALrB2RVVoFEhcun8q9HCfoQPz toTOdBL1A57Cb6AOiTPL1IObiyl0zlE= X-MC-Unique: ieELDBSmPr6ZexYzmEP7Jg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WnsJoqm0kueRWLuhupJefE0rg07bV0EtmUFYa03sno7nUzylr5fqUoLswqPDyulAZCAKTmOFmQNWyVUIEZmjabHiEdTyvcYgIeU+NHSMCPsNJGssIxqVqhMrXEybq4qkcaJk+R2E+0d8nu5rzeTq2eqHWV8YB5dqBwphblmB4rtt3L6JU4rl/DmIVax5PuvGAsfI6hUJJqYEioXp8JEEeLcNHN/BgAHR7chyRbC5Md4AjbnDnA9nOaNO2OvskRCx+WHk9cncD0QAZMGeF9Kg9brIguuUREh2b56iU9CGivxEzSDHJII85i1I2lFbp5FaL8DwqFry/nnvc78pNeDUHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EdH0keCRnrVv4uaQo/ur6zD6UHS4DcgosJK3el563VM=; b=YZtgAXYf2phPqjysxFghKtpK1k0JBb5WLA8evj7qTSK+7WxEdrDsurZGT/E/LXQ2wTMG9/4EaYbR7pJ8Faj8MAfNsopi9NN3z4PsyiEDttR2rymlnNSx42vMGnv26azCXQ8nKR49sZXhUwFgP+pFRG8XnXPEyDAqDSl3IcWkeinIGNpg54O/10u5bKDnHeNFLT+1c9C2q6TbiJ/sEiCENfdyKWdypV77huhu4MN4RPJGijXsz3p2md6x6Yl08VmGL/KVUgqXulaUG6tIP9TUYmVCl2+aMm/LBTlXd/VCzhNtNj3UBschzj4AInQmTxSsgnOvCTZgP18JM25uXVN9mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 12:40:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 17/21] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0133.eurprd04.prod.outlook.com (2603:10a6:20b:127::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a347760-8da0-40f5-aa98-08da38bae6c1 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2314:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SOJ+2jZvqoHJludgT9NJWFp/u2BlGU+YXd69gAotYr78emgATW6POjKk4p6Bfzcj0zPSeRbUgc+KuuInDh7nPx7m5AfeRt08GADWhEHIyY+8Yz7e5YYEnULuH/wWVewqmMU0SXNm3Y0xk0pShQo1fkyWgCX1kLL8L6mRRUUm8Z+dqx25IVJGLLPAWE9YsotoT/OVKOyKpReVSI2GMb5u5zP2TCgZI4E+ujYyZBx8NVIrMgfv+F0L5J09zPeZ402ux9lAsEHEYeXnigdCyZC9An7NKVNhhrpyE3g4CZmDgnP/n0ebDAXeif5LPmi5qzs0GNAGUL/qpz73JOUaw1km447RNhqHe1JrXerNe1yJnxhf2YWg5kh7lnRdusVX//zzNMOEQu8c1A6jzkfLclkWg6FsKaEoHTEZz4M89aJN8R7Nyi6PmrqB4yi/5ovN2H72zY/mAoAUyc7RTVuUEhTCvqRAPwcIfPo5KtghwZvaAX0IGCpKHPMhxCDvG0NGyGeWVFUuxaCfXPzTzOtsDfvoCROBHnBPjYNSABrCEoVfPl7oQRTFl4Zarc5Q/V6NMsmlJsUAAYbOgfCaXWr0QMpU517rQfGYXi+cBJzpywVwWpLpvuGedlex3GmsidMMIkpt+F06KanxSAvYy+PX02w7XvlWzbE3r1mVsG1e6pzXs7ODKQVtGN6qALWQVaWzrxD6oHN+iWqU9dUDL0ZA7ZzKJKsA+5u7BCjubfdrXZvZWZRg6p9PKWxelRLwz2HJWEzw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(31686004)(83380400001)(54906003)(66946007)(4326008)(66556008)(86362001)(36756003)(5660300002)(2616005)(53546011)(6506007)(38100700002)(2906002)(6512007)(26005)(186003)(8936002)(508600001)(66476007)(8676002)(6486002)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5JF0DvQZWZhGQ+oW6hzs8bmipE14FlEnTj7ZGKmNIw1duZ5W8OyhEfjza3sy?= =?us-ascii?Q?W7cKi5LAA7JiiuFK30HiAbTQU1D+w6dkJLoaFApkMRLiuEVMxNBuWpyqS15C?= =?us-ascii?Q?w//eCiDYSOiAXCYJZCj7Dh7gqbYbVQOuwhnneowuV0x/Wop0KsdzPxhwKLSH?= =?us-ascii?Q?+cN7iqDvNVb5uuyauPn9dgaNVZ6WKmgDr+ka3v7Q1Osna7n3Gak447ff8xhX?= =?us-ascii?Q?VAoXXPm7gCk517sO/2POd1I5s/WilBQCqY9fGr4ns1VPWDu+m5KBitJKZrYU?= =?us-ascii?Q?1v1rS8cxsZj1z9HGej2865dRsNgelrUugTqvQbDdRpu1SzInWotRRV6ssTHd?= =?us-ascii?Q?ZdNOtj4/3S0Jt+jxTgAyRaXu4rDoOrXvuF864KOc5LHyPH/HmJR16X6AulWh?= =?us-ascii?Q?m2NJx2i0q0nQY+byRqxvfyuSHm2i5alhcrm82yhMgjH1RLa39s2ukEHzPZJP?= =?us-ascii?Q?G91LjShqm50jfzs30PN8N1L9m+R9yfw75OLde7d9zWvdmPa53Lrn6TelgBUB?= =?us-ascii?Q?l9Tkv0bHC1ZuNLWQfYmhhpuKqyPkg7Tl+M4mprnoyrXy46sGCd3bwAI0z1x1?= =?us-ascii?Q?WhCBg5dvJ4C34EXqXmFRDB5Yzscjz2fsT/wwt3Ns1Dlp+VH3bNykzdefEye2?= =?us-ascii?Q?L5Fp3IfGgeXIpbLTlJXmJ/1Zy865X+fMza86ndzmj0QrR2rz5plIpoBonGet?= =?us-ascii?Q?NosNhMMRaqH+xl6DbgP8lp9VChWV7ijPHsCPfvJzftJKHGYld+N8KNr2E9Dw?= =?us-ascii?Q?G02BOFJ1edjH/uEcxwR+LzBcfuafpIFKdRhu8U+avLqimd/qIDa7UUoQB3FS?= =?us-ascii?Q?EQYuurWVPM77VWzXdyL8zOvtXrFwsciKkRpb8HWxTPlXUGmPIvzrZStZD1XG?= =?us-ascii?Q?dDBih7lL7JBzdpFAsLQTWuAENyWrPqfVMyunoC8xU4JkZcexCLeF7Lk5R2XT?= =?us-ascii?Q?n9GYzkDsxCh40GLG+3RHux1Exxf5QOKJquUMAHk7aiu2kiLS1eV2KDHBtWEm?= =?us-ascii?Q?1FSG1U6rEmVt2vROKGFeNzKGmmWFWvsQl1ZBMl4xBopJ44zxkDP9TdWCzAKm?= =?us-ascii?Q?J9x2N+yWDo2ZSL6SrfkUu/AchIhiv+5S99zCf6fFlrW07hVYoiJbVZ1El4l8?= =?us-ascii?Q?8QCtB/F6KSJd6d5+y+IkVPwo6fsw6eaJtcZYcHj2BhAiQPFEa8uZIJ0Am2uO?= =?us-ascii?Q?tPwnDAgoQG22qNjcOo3Vy5u876kCDRYE0eDMbyvQ8P7T48s4caIMx6hjTDlY?= =?us-ascii?Q?bDG7l38X0T1/iUBs3gz6frPAVYy0tXVFcXD0755/zKpSxtEonVBR4RDpi7Yj?= =?us-ascii?Q?MQ/U7Aq/uzISITB2E5J/Mcacf1haF4AqVswliGD/lc+zKlj1uJN19xJ5bF2K?= =?us-ascii?Q?VyyjeUG90+2QObmggxDbW566LJGweQwYwsUcDgmGgLH91owkKlLCOWmz++OJ?= =?us-ascii?Q?PhZhY6VLGkp0WHVxYv+IVtWYURLVPjslDCpsdMb8oDpCfNXyuKETsv1QRfmv?= =?us-ascii?Q?bk3oxRnUUf+UH0pJwXIdp0/Bc2AFdebY1bv+xGFUWQbIpEvpjpJU7+Wisp0C?= =?us-ascii?Q?Ue8GKaE39DC527KgcVNZyL8yP4pqT+hHpWEy94+gBSzAM2JjThIkZMFPIizg?= =?us-ascii?Q?jo5qfhWNUinHffv6JG6STF4MoS1nA6tM/9XXzWwKFIyMfSySahJ/x6CiDWfx?= =?us-ascii?Q?IDaR+T8M6LFIC7U2Z6AKek9sjpDoGPIzaznUtB9UG2Hxihqs8FSzujKUBFHL?= =?us-ascii?Q?NIrEGOPn8g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a347760-8da0-40f5-aa98-08da38bae6c1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:41:01.4745 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ObTgSnpH0LASmrA7je6z/RSBpWLd0rJjpdU0P2A8PSi36ZcrtpeRGSlht0fsi6nqL/aIypU4HiSLkn/Nz0JI0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2314 On 10.05.2022 17:31, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:43:16AM +0200, Jan Beulich wrote: >> @@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte >> old.iw !=3D iw || old.ir !=3D ir ) >> { >> set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >> - pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level= ), >> - level, PTE_kind_leaf); >> + *contig =3D pt_update_contig_markers(&table->raw, >> + pfn_to_pde_idx(dfn, level), >> + level, PTE_kind_leaf); >> } >> else >> + { >> old.pr =3D false; /* signal "no change" to the caller */ >> + *contig =3D false; >=20 > So we assume that any caller getting contig =3D=3D true must have acted > and coalesced the page table? Yes, except that I wouldn't use "must", but "would". It's not a requirement after all, functionality-wise all will be fine without re-coalescing. > Might be worth a comment, to note that the function assumes that a > previous return of contig =3D=3D true will have coalesced the page table > and hence a "no change" PTE write is not expected to happen on a > contig page table. I'm not convinced, as there's effectively only one caller, amd_iommu_map_page(). I also don't see why "no change" would be a problem. "No change" can't result in a fully contiguous page table if the page table wasn't fully contiguous already before (at which point it would have been replaced by a superpage). Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:44:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:44:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331954.555588 (Exim 4.92) (envelope-from ) id 1nrHA6-0004VZ-Vl; Wed, 18 May 2022 10:44:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331954.555588; Wed, 18 May 2022 10:44:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHA6-0004VS-Sn; Wed, 18 May 2022 10:44:14 +0000 Received: by outflank-mailman (input) for mailman id 331954; Wed, 18 May 2022 10:44:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHA5-0004VI-Di for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:44:13 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74489fc5-d697-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:44:12 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-0OTGWANPOre4WwH9PNlUVg-1; Wed, 18 May 2022 12:44:10 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8386.eurprd04.prod.outlook.com (2603:10a6:20b:3f6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 10:44:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:44:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74489fc5-d697-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652870652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=toyT0q65ke41PhnSxYKELlMN4aHJ6c1nc6qP0orh5Bo=; b=Pdi+UYwEcDILoyL7Ic2o7TqjotLXLgfft2P7DDnnGKt7BUnlK7nepmdXfpUEUL7ccf2zrw N0s/hsVgUQZULJI5LN2yUNk4xEyEhpgSFiGJkiA/XaQ6ukQKoJ7yozzKFXrEXOTdyHJz9H q3Ztevw6hzAs15CaK7r4jlJn8dlpFRY= X-MC-Unique: 0OTGWANPOre4WwH9PNlUVg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JgB2heJgsDC8JxX4jHeALn1Ceu554EOeQ8zlNTU+1c0ZaE+78Z7SDuHn/bRAghhaxKDiM4ydN6d/ENK7twEkvf2X1He21EaOqQ+Htgjpc8x6jyzFH/BFS097MUjSvGrG3nZwO4ZTKekX0a3MDMOAjccqBGZQ4rKlQt+d2US6nDv1wOHifvFMztkU8w0BgnDMMBzveePCWriz+tlD+TxGs83BcuoOFP7zFExHHh9RRlNlj4gHGlhHC13TuujLgVgkASq5qGtCmOr5HHTD4nifTptQv2koqLlKWSvc9gEZQq43f8iSXhlBdZxkE98X9sKYUstROMavw1IFzB7C+VSArw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i0h2MhtvAiylbwO7u2LDU9wyG7PVG1ZU+6D2qfjlzzg=; b=jaPVq9tQKsqljVEyNum0h7W4LfSelEkxB6EwKZvOBEjVAJKHDjmdk4DnfLqa9R4T3c40SHyfy94KgZotViV+GLb0shh8EmFlZKrp3rHhzZpIN7M4CvWuBvTRuV1c5Wnf1/88Ik+NLqpkXWuP5nzDoX86wkWYSyntpqmWymOCPo/6u6GH6x7uZbra8e5iGT/Bigd7OoWPZqdZj8fikylLRyA25BNSNon+MABr83/6jMiFUDx8SO8ujLJQddKx+8ciFaCzrE4skdwhUtdRJJmfeB3J3sg2EBv/GN1/+MMKYt8gHl+Hj889zs5JjQ6zMiP7tumUkf0bdx+Ktxzck2zu9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1f029c34-f300-3841-ab20-85aa796b486b@suse.com> Date: Wed, 18 May 2022 12:44:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 18/21] VT-d: replace all-contiguous page tables by superpage mappings Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian References: <98553b89-6296-9e4c-4677-9201cd7cdeef@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0054.eurprd07.prod.outlook.com (2603:10a6:20b:459::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2996d7e0-d60b-46df-ee83-08da38bb55fe X-MS-TrafficTypeDiagnostic: AS8PR04MB8386:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KmVfnnarL3Srh5yYETV/9TlIEx4o0vZfhsVm6znXdx6iC9oQ30S0wKJxxHDFxVBUeXJLFaysyblFYQthFBQ+ERmPMHeWYqy/e5k7OP5peD4lAa+8CGEuX1dfcIJ322eCFeBcnqAyAEJNsWyzk+JBCDc0JUo8ARykHpUzk9zsLOx3/F+CosBFEw5aAta8zlG3WnA/05Be3LItxdwbgi3eq7/Ocm4vaefEW/dEfI4qEQzpYVM+7B9giNAaTn63j7QWLZgu/ll+wGwVjFgZg/R+BrQqTPtBOQcKcdxWy1agiLLLEDVblNroYcvD1HuUv+YGa069ylm4P5EDoZCtG//GgO2WUGwqldaslwuGD9ZfhdKtCbPtgoVoCJOWJSmW1nnpZILvvTn/tALCDTndU2lZIQRAI/rFK7w69ckEvEn8lP2162MwI76+cBwuX4ZRdHjCJrKDJRp7+VviE3/pkLQAA8rtErMya0McB7Llz7yj/AVmiWhDGNqkIfklywhG9iKVKHbH5cWqAs3RMoG+OGANvJnq8QSH4sNMdVGzfy5SKmw5EtfolHZrbdegWW7sRcGAYvEligQLk3YhIXeV9cWxbpgb/sAdjSvmAGGn/n5YhEhNDJTrtvjYVVFnfaGidN3EEd8Y/lwAFKq7J+dgRETRCv18TZcO0v3s2joQcQKTOy4ALfKDhpWpOsj/E9b0koW/kTYtzXggcvQ489akZtB33XW+zQBtFvnJCDrv54HafUxZhn/xOS3hllNn324ewOoe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(66476007)(26005)(6512007)(316002)(8676002)(53546011)(6506007)(4326008)(2616005)(83380400001)(36756003)(5660300002)(38100700002)(6486002)(86362001)(8936002)(2906002)(508600001)(66946007)(186003)(31686004)(66556008)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FdbfcWNgvi3Cpja4KF5zyWawRBfcVA/mquFZSoVBfNuu1ucAGWgbDSzmbgCf?= =?us-ascii?Q?ONEeUR9VTWAleg4XdoSjJ5gbpB6PW4umHUqXtcWKb+m0COX5rz1aTsuEGiE3?= =?us-ascii?Q?7sAotpbBh7lRpGjEA+2YcFvYLDQ3U+ND1v/5B1p+uSY/oduImbn0rbrNgQ0x?= =?us-ascii?Q?PZCN5ZdAxKrOdsfUSuZyaorVPWrSUx73xA+zO/XMtm5cbzZtdLCNMfowH1u2?= =?us-ascii?Q?Q/3/suRuyeUoeip+GkFhbg7R0F8T8hziGGqLpWuaD9vqwkTF1hU096D1IXHD?= =?us-ascii?Q?nkPujiPq5eRuUynlhVMDvD/tEiL/pjJO/+FWloa+WLiTgg2vtTYg8hJEy1RR?= =?us-ascii?Q?r1yjc429jPq72N+hI70UeNLx1zRDDmTKAzfRm682YLcjPyk1wOM3qTMJAuA1?= =?us-ascii?Q?MubomLrWY2kxq0AJ+AxhWskC+y1t76VOcP9LHrdw/V2qeIJmeivq5M6AZRpn?= =?us-ascii?Q?5eR0WyewlZ4zyi+//L29uKFClJ03b6paUrRIbh8M1OGioKto57wc1cf/yH/L?= =?us-ascii?Q?UGoQTQalYNrBhEL7bxjtkLI0ZzPEsSE+Tsyc7oXteWQJyizMTDvNhDB83D54?= =?us-ascii?Q?LF1bGRW2oCNVtOu7BrdsoE3NyLpBnidWh8zAYJKf1OOie/fX58QE+F4nVd2I?= =?us-ascii?Q?9BGn35KpYxJwbGCM2zf5ITRkmXCQD0pzZWoVxvqMYoJN+mMTMmRTPAUeCmVj?= =?us-ascii?Q?ZIfVV5ViVWWJFyCnozcqM48Jw+XEzipvStiINt/UfnE9KO2nt36oNYkQuskW?= =?us-ascii?Q?7AZeK6zyPXuz2K4VsDSggVQEUs6OQzriq8+12Q1SRhVyA2zr/BcOhOGFQrvR?= =?us-ascii?Q?2RzkA+g/tG1tGbDOmIN5p/1xb4kbDUbRclUrQjJJq3X3Z3YrH5rmSRVcbYSj?= =?us-ascii?Q?Q0IPll4qdd7rcFpXBkFtXDzeQJbti+idoRariK2+ZOmRZ6uXCduDqZ+i7Zo9?= =?us-ascii?Q?fYAkQk6IKXkS5dWD7nni2eSx+5s+q+sp4cSj2tq0efXU/ErAxi/hKomQ1FzE?= =?us-ascii?Q?rsv2UEfw315d+t3R/yGg6+IQPAnMTIv9Nn1b/aAallo+NAewxPDyX2KSgx50?= =?us-ascii?Q?DXw/cWHIdHo36I87n9Ng2Yv61XRQGRCGU6U9NJCPqSB8UraZud0oN9drup0v?= =?us-ascii?Q?PsL59BnSwHk8cdQAkfMfymZyNHsxvE2DIklOX7yl/OFX9IN5f1dNFZUcrwrT?= =?us-ascii?Q?m55Dyc53Fx8UCUXDFu2tqzOMqwd7Cj3Hfzw5m9wZRCayE87g0TTZK+/SVLVb?= =?us-ascii?Q?Q0LU87XAGRoPiOUa2NMNSZS11URulL8SsefuKkxs2yA32+hhny/uGLPXf05R?= =?us-ascii?Q?+h5viDfA63Un7b/Dle+BwB5nqpi9vXzhGQReTl/JHuIJKQkDHVbACgtZK+N9?= =?us-ascii?Q?LIxhNSSX3m0JnMbETY4Rcfhc0CYZ6+VcvZ9ZukZlrLmpNTvoGirByvqr1UJK?= =?us-ascii?Q?VwURgZBE4QHG6qF5KKdvGm3cRZ8us1rqVqan73ulpGgiEgeNTjOBKP8OcKly?= =?us-ascii?Q?hv419p/3N9s/yW3u+AUIwZ0BCdKRvANgRBiO+Fj/VppDq3vBgP9A3xc9sOlh?= =?us-ascii?Q?Jr0PCOZxuBAbIyH0NyqSP0TsOCUrSY7+DXyyMqLXIGpRj6nEckYhvOWZUMLn?= =?us-ascii?Q?uQO/h3xsKh3s2nNOzl1ll+4omNU53NIz/J+kQ5qTcONLhG2Gt7uU/j+yTfkT?= =?us-ascii?Q?fiMoXqQD5UOSrq8BJvZYDnQqqZrNRToeMMHqmiCjqsrt9MNqo/cX3g9GLtqY?= =?us-ascii?Q?ONYIaCoMEg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2996d7e0-d60b-46df-ee83-08da38bb55fe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:44:08.0563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eoKnvp7VNOnz2/UY0e3z8eZg+sBrsbqieCH9Gh8LH0qjExlNmeoLIpCvw2AkC4XyTiHQFJnbR0j8ZaInLhPzkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8386 On 11.05.2022 13:08, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:43:45AM +0200, Jan Beulich wrote: >> When a page table ends up with all contiguous entries (including all >> identical attributes), it can be replaced by a superpage entry at the >> next higher level. The page table itself can then be scheduled for >> freeing. >> >> The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap >> for whenever we (and obviously hardware) start supporting 512G mappings. >> >> Signed-off-by: Jan Beulich >> Reviewed-by: Kevin Tian >=20 > Like on the AMD side, I wonder whether you can get away with only FTAOD I take it you mean "like on the all-empty side", as on AMD we don't need to do any cache flushing? > doing a cache flush for the last (highest level) PTE, as the lower > ones won't be reachable anyway, as the page-table is freed. But that freeing will happen only later, with a TLB flush in between. Until then we would better make sure the IOMMU sees what was written, even if it reading a stale value _should_ be benign. Jan > Then the flush could be done outside of the locked region. >=20 > The rest LGTM. >=20 > Thanks, Roger. >=20 From xen-devel-bounces@lists.xenproject.org Wed May 18 10:45:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331966.555602 (Exim 4.92) (envelope-from ) id 1nrHAw-00057e-Aw; Wed, 18 May 2022 10:45:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331966.555602; Wed, 18 May 2022 10:45:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHAw-00057X-7p; Wed, 18 May 2022 10:45:06 +0000 Received: by outflank-mailman (input) for mailman id 331966; Wed, 18 May 2022 10:45:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHAu-0004rA-5i for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:45:04 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92b5a772-d697-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 12:45:03 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-6-Y1zHuLzXODmsH9AhWRZUWQ-1; Wed, 18 May 2022 12:45:02 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8386.eurprd04.prod.outlook.com (2603:10a6:20b:3f6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 10:45:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:45:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92b5a772-d697-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652870703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3T4FCEKiM/CTDixmj3VrkfTyVY4s2eHzekCcMCYwkcQ=; b=fNGsJSYu1MMokkKRpZ/10GVn41ccir6S0SvFiVZ3qhkJdYUq8fmDgQl4otgiMnA4QJYryU isuPJk+uWHF91K37uWTNjfrcZAN4DxNBNLMGwY1J8b318r6J2de6A6y9QkhieO+GUP1lWG ljInwsmk3zd8fMahGKovfpX8PuuixpY= X-MC-Unique: Y1zHuLzXODmsH9AhWRZUWQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IBbT7+AsyQKjyFR119Ehp/XnLUUHQ9IEH3SwCgWTFm95kKm6JwF4cR07wjassEGeDqWqh9pZBZJqdT/3gPxj2NJdo5JXv7mMAVcHRgVj66ypdgOmMsUqPQmQ0YdU3rcPn9aGUIf1Z+OOQ7TV+v+2diviWeALVz+wRHsPt2Et1T0zpO4pdeGUSPonL8YM2KomWtJKrWAL/JoqFfy2dW0QtiDxQg0s44p/teNHAxGr2W96bQsqMSC+1P0N7UgPTOPfAK0WxhicYzz/CAeoNz5bVR1qLue8xQ0JecMb+arPmHZuPGa7fTEdeRrQdSU95z7eV0oPTCJKLxspkOhR4NqrWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZfxO6lat6NUulj4RhVj5pUT29acG6GHwB2SMywf12PU=; b=Hd7cDoUd/ZVlAy2dRdtUBzc121zmuskXs1Adt7dsFzo1R9igyPNSPn1zpSpMfnqBDkRNP+O7EVd5TAgWDJmflDxAApAdVRXJ50NsO/0AA/RAh1p5P7NlEShSWQOQ0UcqWnTGhkR4lpZpuhDWiqljMzorIOsmgZj5NBvNliyBxrqRNSoI0FBZphNZBjv/nFjgfTuWy7xWjjjDDznxZLXVgroFULJPh58dAkI+S92MMVpqyjrVQXBZcEXqqjU8VDpJPX3yFr1m1/UGvuUTDdgQG7BEia2o8Cg8pxM9BndopUkZc6LdhEvnU10DMHYaiRXxqgGkUTN7KmiawgFCKp1QHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 12:44:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Content-Language: en-US To: Jane Malalane CC: Xen-devel , Andrew Cooper , Wei Liu References: <20220511151423.20241-1-jane.malalane@citrix.com> <3db124b9-6ab7-f9e7-3c2c-13d82894bdbf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0052.eurprd07.prod.outlook.com (2603:10a6:20b:459::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1aa8104c-b0e2-4b94-68fe-08da38bb756f X-MS-TrafficTypeDiagnostic: AS8PR04MB8386:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VfHLEd5KoECNX/SG85B2+EH6sXeBNX0fgb+jY5m8I2dLP5vQem5/Jguh/SFYRTiswcr7ph+mHRzCUnf6RMuFUbf85AnAvuQSQ+ULNgmxhl4GG4PaME5eJIwLBxHh52AeYB5C033XtaKgN5+TWYMmylK3KwLrQMHInGNIWGA4PM7QGgk+RMWkXai2B6Mgg/rxU74WwhFCjrDX6qWF2/EnuYcUEea+th8+JDviFFyTqEdPS5VXfjcsxRVTIY8pXzuaPZ7evCIZqnHK8var5bTt3N1FR0weIRzgNObWdzjfduVwqGLbTnOXc9g0z/jogIqhZY+LdHdrdHwKs14A4WdiVLIZkN2nZjnP3UMUt9Zp7p/2PoQUQ+/gK5bSCdV0avQeoIiWVvjBbSTuCIWGWRWyHTe6omuMxlJwszAabwRRrP8fDlW1Wwq1rYCHkg+KaYhhkOPD/Y4kSu/xJTx4T+Bg84gpxiradm1xl1utHN+Fez7ltAFiFurew/UI8v4aaKdOsVHQ1m3pZg9q5NwAF8gwVumF7jjBXM6qkon1zTBZe0xc3HXbfs8qFb4/YFksZ3HDuosRXRIa5/2K2X+hZp1zLwdo5RSyEzuURK+G6HK0MZvxq68WvApLqUg/UOxjDg2I7fB1FhCOvLymmgnW30IfETfSiwNa20qGh/chXIJRAQshDApVVDMiqpvCmFKDlcKd6kNW9ivtPLAJwKgxYM5ewdygH4cvYAKx2E3QRzOLN1s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6916009)(66476007)(26005)(6512007)(316002)(8676002)(53546011)(6506007)(4326008)(2616005)(83380400001)(36756003)(5660300002)(38100700002)(6486002)(86362001)(8936002)(2906002)(508600001)(66946007)(186003)(31686004)(66556008)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CIIw7G1TKkl1Q7TBpKcbmnonNj/CD+PUWBxlZgphC0XVRIQdl4FSihe1FYNL?= =?us-ascii?Q?2npjpGPJ/Th8m2unfr1Dvle/ggurmQoOS/ykWkMHRG4hD7xef+iW39F5Ydmw?= =?us-ascii?Q?DBiDFLwXkbrHBx6x+/2I7dNTBh+U3fLIoUgUa0uJLv5905Z1xbasjJZNg2Af?= =?us-ascii?Q?TA7ho4rWMkmoU6XfLFD+H4wKRDPldDNIwWqoL43XbLWnEB+JzNeFOyMKaTR8?= =?us-ascii?Q?wVPkaSJ1T3j0kN0KVba6d5KoSang5OiQhYVC2fjM445mKLGZnGr+6s2Ur1Vv?= =?us-ascii?Q?GYZ8xTmkxBvrPQpueqlYeLgDIfkbCAnJ6XE64oGIhaGWfQeANrmO+9k5x4ic?= =?us-ascii?Q?GQqHaoqrYdApm0wYnFr726mIs6qc3fFobtVirzo9mJ5UI2R4YPjl6jHpPwJi?= =?us-ascii?Q?dT32bzcrHotoo3duQaU8qpttbixoZmJPwksxz5k3I+j3Au9sHMhaUqx4/28E?= =?us-ascii?Q?Umij4Kd0CARynsT78Fq9ZAYCLHl9zeCjf3r6uPCd3x+HxC3VWPBQ2Gkc8xuE?= =?us-ascii?Q?ehIxdgDrPioKAB3U0XlEeWcWSflAjnh045450SIv4beY07zsmqLY591PAp8Y?= =?us-ascii?Q?t8uoj9ZHuN74BNexwR00/ETl+wsz5/3qE5XsSgxf1cnu005XssXW6dpJsXQC?= =?us-ascii?Q?SCNryr1JHdFll77f+yzUe0pT1qIeOwEz6mgKRjqAvLBg1sT10I5jC4Q6xG/S?= =?us-ascii?Q?8zO5I3VSG9IaT4A+AV4NZ223HM6OcBuboYibg+DLNE+QdGQ3DtXf6xEpHJ52?= =?us-ascii?Q?1DyFe6a/PpEy/prQCh6xw/wvYYc0EpMXXFFhOkUsddySghTU8ESrAyf/UEPK?= =?us-ascii?Q?xMuj+f/pBrhPQiKluN/Qj9tuQYL8M9U8HoneH033v1rt2brnTUMKcUkI+A2R?= =?us-ascii?Q?1BMh+CWt/kXSr7WMGRe/0CkMvQKegmgFtu6eRcqIjJQV2e/jH72aEVhQD8vF?= =?us-ascii?Q?oMFUzngfxfQp9Mfl6jZn73xpCj3mh/Lzt+kb3/fYaifM/4q3Y9BWXqCdRHoB?= =?us-ascii?Q?oZJPi792BKbfUzgwe8x+GxNRaQ3xBkPPCzcXAS4dzUvFUobDo9ikIDsladdz?= =?us-ascii?Q?g0+u4+U5MKiHPkPpQmsM1BRQNcFi2B7ZAMdl2CxC3fHUP7VnAIzgHKhkVywQ?= =?us-ascii?Q?GRuJK4wAPImqpVfzFe9WfZyYwJ9OikUxs3kBB+WQA8ttpUhm5n+na2Rx7Kuq?= =?us-ascii?Q?XQb9W5/sSmcvZcXh57AMU6VZykvPDtSrChE2u/jW28WxR9nKwMUsvCbsW6Ix?= =?us-ascii?Q?8Dzshga+YJeB/S7wzgydrQfqFC0dH3s5XiB9QQ+dxex/44OVi8e9kR1Ks1jX?= =?us-ascii?Q?XtwiO5wg7Al+ZMp73D+mKhgJzYJTnjkxUX+B+bXwp317eLhYlApqMOzZWkxx?= =?us-ascii?Q?E9BWn0LoKD5pLpCywt1FgmUWGpv5eAf2w/5Mlo8VUw9X7PY+rerxbraSGk5i?= =?us-ascii?Q?QU3FzZKIeKjHcwjFQKqw4GJdqtcNoqJOgIfyTlYMwFQGxmoUVtkWWh0DMxNp?= =?us-ascii?Q?hmt6Q7nbWIF9Co8coFFRzxzH0x2koYzJgYyQ58LnJtRJ2ljIALSN9xvX+KNG?= =?us-ascii?Q?tb3eJmMcG1Uvh4WmtYXuDECHCgVuy4Tmq3UzOFccscBG26jCxsie7H7JJFDx?= =?us-ascii?Q?1O08qzLXvM45pfrd1dUnb1sXMwQHEBbRFIsrJaRmd28iFdxBpjAtep7aCHcB?= =?us-ascii?Q?GufSCZHr2ZvWPk8vlZ+zFT26sEEi95024ovXiwCHQMa+JZFAghn1//mqH8Wl?= =?us-ascii?Q?lyjZtiZM/g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa8104c-b0e2-4b94-68fe-08da38bb756f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:45:00.7715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M3gnwdpCx8UMYzjd7bqTOs0ucNHzYdx22v4tnlJDl3p6Go0ObXtmxMOkYINz8axFOehDWSyz9VbYQF/0Juy96Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8386 On 18.05.2022 12:38, Jane Malalane wrote: > On 18/05/2022 10:09, Jan Beulich wrote: >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachment= s unless you have verified the sender and know the content is safe. >> >> On 13.05.2022 17:39, Roger Pau Monn=C3=A9 wrote: >>> On Wed, May 11, 2022 at 04:14:23PM +0100, Jane Malalane wrote: >>>> Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for >>>> evtchn delivery set up on a per-vCPU basis via >>>> HVMOP_set_evtchn_upcall_vector. >>>> >>>> is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up >>>> physical IRQ to event channel mappings. >>> >>> I would add something like: >>> >>> The naming of the CPUID bit is a bit generic about upcall support >>> being available. That's done so that the define name doesn't get >>> overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some >>> such. >> >> On top of this at least half a sentence wants saying on why a new >> CPUID bit is introduced in the first place. This doesn't derive in >> any way from title or description. It would be only then when it >> is additionally explained why the name was chosen like this.Indeed it is= incomplete, thanks for pointing that out. >=20 > I could add: > "A CPUID bit is added so that guests know whether the check > in is_hvm_pv_evtchn_domain() will fail when using > HVMOP_set_evtchn_upcall_vector. This matters for guests that route > PIRQs over event channels since is_hvm_pv_evtchn_domain() is a > condition in physdev_map_pirq()." >=20 > Would this be enough clarification? Yes, thanks. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 10:49:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:49:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331978.555614 (Exim 4.92) (envelope-from ) id 1nrHFT-0005on-TZ; Wed, 18 May 2022 10:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331978.555614; Wed, 18 May 2022 10:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHFT-0005og-QZ; Wed, 18 May 2022 10:49:47 +0000 Received: by outflank-mailman (input) for mailman id 331978; Wed, 18 May 2022 10:49:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHFS-0005oa-VD for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:49:46 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39f348fe-d698-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:49:45 +0200 (CEST) Received: from mail-bn8nam11lp2174.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 06:49:42 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by BN8PR03MB4610.namprd03.prod.outlook.com (2603:10b6:408:9e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 10:49:40 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::a932:ea60:fb82:12b7%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 10:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39f348fe-d698-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652870985; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=efAx/8ljS/+OE6+4qUJIgOpijDrZxS8me08+v3JDzL8=; b=OgTJRH1vVgBJOH2ym76pS79WYhtrFmbcirxMRtYUr7Pp66plf0rNY265 jMRLQcl6jcUCuVA5hku0ki2JvBTg7LUOxVY4yjCBVoOC7SN+EE6KEZH5r GcdOuiGxx22D9Nto7w1ttwI+VwTaMa6h6Ah397SIIqoJOx8FRAsUUHFy+ o=; X-IronPort-RemoteIP: 104.47.58.174 X-IronPort-MID: 71977731 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YmJdmK03bs0jz2UTP/bD5aNwkn2cJEfYwER7XKvMYLTBsI5bp2MFy TQaWG6PO/6NNGrwKI8gO4jl9B5QusXTy4JnHgI+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1gsYD3VCx5Dpf3xtsFajBUFXo9PopJreqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVube03x9p7ixKNdTXY cdfTDNrZRDJZRBnMVYLEpMu2uyvgxETdhUH8QPK+vVsugA/yiRb4Ym0PsDaI+eNG+dfpk29n WLI3jzmV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwASEy66R6QDJAGEBF2dFcIZ/65NwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:GpDdQan+4xFkq0H0tk9vDwgSiI7pDfOOimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVo+VY7bVHHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wd9igF3ekGhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv fbAuMlP8Pe X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="71977731" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPOJvU4Lcyn0qRH1ldNQlT6DVF08RFiyKFBX+k0WtC9Q4Upe/feF50Zd22sCESDkm137u26PxlmzfdNw+Wllylm5Fx4yasFDiktjvrQ2vGtIxnqj5f/KUedjZJfxfPt5Ajn7yXqysPuYx8YE06h2PSB9BS+RciZ+I2JtntS3vWlbauEoeZKFuXH267w8nIbXgkjdUswVnY/jPcY2vNr0DX8cg4wbiz2HmsiLe/EeZdeptZvP/jYFxVNSbPqu7dxqAwFyBEPA/S4gUdSWgZ8vsepZo2GTf7aoP78FrPeNZvrcpWZykET8tE63seiV/Wj5qGoEsFcvRUzumwTz2EPn/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=efAx/8ljS/+OE6+4qUJIgOpijDrZxS8me08+v3JDzL8=; b=Z/wOTv0Z0WhnJLRtQNk+MpSSV6BKnKIYUrRmbtqd6/KhN6x05Pwy7BvVj2Zko9ICMn38Z6QhlSlqNPhgmm1ABPU2SGjHDEaX1M/DUQ2lMa3eFsxK7GwoOcwEN/PR+Kb9bs+F8BV8T1rS2cobN6IgHDK+u1Y3uevbJL1gJsVbe4vrqxvJTsTrHjYLzWJpEftgd5k+WkvIkQ9FTKVaSk1s97Wrlgj2rPSKNMTWNe5EzrvsKoUkfQStpBG0AiJKxh7WgNEnM5g4A5qhiygYdDV2v5rmEbKCSlSU2ZEDd6hah5eY2Hsj9D83aolbGvQzLvLnbqtwEWHYHnG259GBb2JknQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=efAx/8ljS/+OE6+4qUJIgOpijDrZxS8me08+v3JDzL8=; b=rxeMFqy7JDSRfzTl6PP5EVm5+WjF8NDWPNGNzFBRRKa/GT7rKVJShNZM/pUxKTET2vm6NQ7DTOq1O8+/C4FzZcKEF+paPzz9jRlRyLatTKeonvQ6ADxbjJ9xiAeARBEM71hthHtvkYk51GKvoBT6EXKaL0rGEh2A7Nvo91KSWeg= From: Jane Malalane To: Jan Beulich CC: Andrew Cooper , Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Topic: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu() Thread-Index: AQHYZUnyc7oF7QLoj0+gbrrX4WFU9K0kYs2AgAAckIA= Date: Wed, 18 May 2022 10:49:40 +0000 Message-ID: <649429ad-d4a8-5a53-45da-74bd8815318c@citrix.com> References: <20220511151423.20241-1-jane.malalane@citrix.com> <241a38af-65cb-a44b-4910-c1c310b7bfb0@suse.com> In-Reply-To: <241a38af-65cb-a44b-4910-c1c310b7bfb0@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45f700f7-352d-48a5-b871-08da38bc1c69 x-ms-traffictypediagnostic: BN8PR03MB4610:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kytm9rdMNhxWL8t3adiPaA3ABwcbLYXK5kGfQw1xoVo/MI668iMQ52jjP4d3S9YtWHicCxG3cAyOou8H0+6yDkMkxWYuwYZCCQCjVKOAl8aAHE4R1OYUONjVlKvC/QR+2d9hxMnyiL4ky6I9Vr9ofRFK+2/lC2OuP2kboUqGewJ/ZMT0a4eQFA9WGefRquN0NFfyR+13YfnHyB9862zHWPFGAk4AxyiYuy+sgIhBhNmis4hHCarcMnVVeRjhymOpGWhvLls/a+wZG56HJXAF6wGWDXAf1f0/caefVXf6JvFxo6JjjFTUFqB79sJkgWK6/bT9yWVrPeXoxyL6wTHL6QEUmFvpzqQa3qqiz69+7VgoduAAQOeKJ+C64Gu8lpAFeO+r8I1puW0iMlZ6LQGBvf72AUovxf+3rskc1cvyzDqYaNBGa+8fhLnDpZklP+POymdmC4wmrsrTIzucVgx7U6e61PsLEmuRpv8vwXBg5we/E9FV6WoI/jKLfF1nv8GllPNmtSyFXiaLlk2hqjMyM/0JyfVFJNfHa0v10XfUX0xKvWjK9LSPAhHrZNFRwce7+O3rywoxsQrpQt5IlA+zD5SgbKAclMyv/UGiSs7hSuxeo34+sMOAXqzul71DFT5+PNEeH0HE91ZrEUXdbwn4PtPs4tc2Xbz8usU6VeejiQAJ5b+OYUKRKNPySPInjSTabHbhCIhc5B9OLZ/HGkSq4nKPCB9Xu3rCK5pNBmuwNl6jZ1EknvjICCb2mfM3xDN2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31696002)(6506007)(8676002)(66946007)(26005)(5660300002)(4326008)(2906002)(6512007)(6916009)(122000001)(38070700005)(36756003)(86362001)(54906003)(186003)(64756008)(66476007)(66556008)(66446008)(53546011)(38100700002)(316002)(508600001)(31686004)(6486002)(71200400001)(76116006)(83380400001)(2616005)(8936002)(82960400001)(91956017)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c2k1SFRWT1BwcGFxQmI3Zjg0TjMxclFyRzdhSm11YUhoSGlpRzMrY0g3anJq?= =?utf-8?B?YVliM3hWOVA0eUx6aks5bS81aVR0V2NJYmVZU2xYNzhWOFE1dFg1MFBuK0d6?= =?utf-8?B?Q25vOWNhUnB6UUcxajJXNWgzVklaUktyMk4vNXhjZzZTSExudjR2c0dkQVQw?= =?utf-8?B?U0NzcjFmRjBPYytqbHEwdVlRWDVETUV1eEozU1lSYm12a0dNUERVQm8zbEFk?= =?utf-8?B?UFNKZktYbDhyM3k5VXJ2N3g1TnNrSUkvK0R2cnkwNGdrSXBQRlZZbW8zV002?= =?utf-8?B?SEtjSGl2WlJ0M2xBNlJ2Y0loald0bG5zRjVlWTNDZy9lTHI5aXJJKzBpa1M1?= =?utf-8?B?dnphRU83RzFqbUZzZWJhUDRtYnFlanlyaUFPbWptbEJUNWJtVE52QU0xVmVv?= =?utf-8?B?aDdtOWJpS1JublVsS2dKU1QzR3NpZWd4VlAzTXk4aUtkV1dwMXVJbkNsS3Mv?= =?utf-8?B?Rm5ZSmpWTVY3VGlPRDdKM01QcDhGOFZsQjIxK0lORFRtVUJaMEthb0E4MHpT?= =?utf-8?B?RzYrK1ZIQ0wwVGIxMDFKZVlXR0lnQ3Y0VHNwSkllRXNhaVcxQTVVUk1nYjNz?= =?utf-8?B?VzdXRys5QjJYdmErbmRFbVVhd0VFYmJBWXdtZ25vK3owcWdRS2VtMnRSSnZp?= =?utf-8?B?SHpRVFVqZ2N4MWhUWllqNnNnaFZBSVNvMWQzdW1SeDV5cXNvTC9LUDFEc2hG?= =?utf-8?B?TVlNcHZ3cC9aN2pmeVhtK3ZEcHBJSi82VG9NcFJjeHhVK3Vaa3NxeEJ2WjlH?= =?utf-8?B?d0xJWGhiaXJPWWpJNlEzZm4rV0tzVkF1dlN1QXZCenVab1NvRnhrL0VnTU1B?= =?utf-8?B?b2c5M05oVFA0TWkrV3Nucm5DWExaMEg3emp5K1ZpQkJDTWlFMHJQSWwwMFhj?= =?utf-8?B?WGxsY2g1VjRFOXAvcDhYcHMvRGdjVEg2MjJqRG5rbmx6cGV6WmUwYnFhL04r?= =?utf-8?B?MGpNdzhkN3ZTZ1lBWEZEamJpV1B1NlJVZ2k5SkdXRE43eEhDSnM0all1R3Rk?= =?utf-8?B?QXprSjR1WEhZVUpjWXR3VXdsRTJBU1hwaVFsQVQ4VVNjQUlzdCtNaEF6bjU5?= =?utf-8?B?VVVRMVh2blMrRmQvSTBsLysrR0RzSURNT3lzT3lINldaUW5GVDRiUE1QZ0dY?= =?utf-8?B?N3NGTnNzVmVSeUcyd2ptUDJPbWJ6UDNMTXJvQ1k1bnEwVnFIQmhOUDdJNFZB?= =?utf-8?B?NjlqSkZGdmFrWkNuTnhuTzYxenVoRnFJSnJxMWFpUkppZ2gxUFhFT29uVkFR?= =?utf-8?B?WUtDVlplUTZBSFo1MXBURTdkV3phZm00UWYyNjQ1SFR0c0RCMHRrTnUvN2U5?= =?utf-8?B?a1NuWWs2dFpCMGdzTzBWc0V6TDhKeFVjVnhudGVjcXk1NFV1RE9oU3BzS1Yy?= =?utf-8?B?S3NqaVc2bWRld1BWaGlqQVcwNmpFNWVFVFJkeTZqWTFpR2Y2THBVYnJlc1ZE?= =?utf-8?B?ejZqYWtoZzlUdzUyYkw0aUdtenptelBkK2I2NkMrdURNY2RSVlRzeWs3Vndh?= =?utf-8?B?MDloMXoyY2NqMStFRmV0S0VhaGJVdDVFeVpQM2I1TE9IblBhWnU2NGhZZCtU?= =?utf-8?B?aitPdXJsV0c2Qlc5VXBUdmtKUWpHM3oxYUV1TmU0dzd6Z0VKRVlabmRpcDFo?= =?utf-8?B?VEFOZmZPV3VuZVpvQTFJUDlvZkd6TnNoM2xiMXZMSlY0T055TlJUam9YNjNh?= =?utf-8?B?dUhBZGlnWTZ1bFhNL3BsVkRmcFVIcWdLRDU1aFo4SlR1OFhIYU1FL29VSHJm?= =?utf-8?B?R1VoVW1BWkhzdVh0ZlJoMFl3WHVadWt4aEcwcEpmeTZ6ZE9TemVETEFqMTBO?= =?utf-8?B?T0JPWitVWUt4Y3c0VWt6aDl3N3kxNlBOL2RTc1M3TE1heWpvLzFNS3JhWU45?= =?utf-8?B?aHZiOUJkVlkwWVBiZHMwamR6REZvTkg1c2lab1U1aVB5S3kzRlZ1ayt1QWNK?= =?utf-8?B?SGpBa3hCSFRoNVlDb3Vka0VvMDVJUlBGNVduL0hRa1ZkbzNuNUNtNkVMcGRn?= =?utf-8?B?QXQxb3AxdkdOc2ZsZXljeEJVTk5FVXVQbURoeXZnQTlFbjRDV1BCNFdhOUQ1?= =?utf-8?B?NFdURjJONllRQkFnR0RyczdCcS8vQjVMajhicjJBY0IzeXFDZTNEVnlic2Rm?= =?utf-8?B?RXFvZmFVZUlxN241TWY2clBndVdHbkhrRWlhS3ZLRnBMcG8xazBwbmI0R3hm?= =?utf-8?B?QTEvc0M2ejh6TCtKd3pmOXNQT1hlRGFHRnVyWFV3Q1NzaWdFdmQwaERXOUVD?= =?utf-8?B?TEExKy9jazlaeTJEaE1YZWNuRGdVZDF5ZEtvbHd6UjVtZ2wvQ2VmUWhZMDZu?= =?utf-8?B?RTAzVDVxeE1xNjhmdlVpbm1aYm5qaS9wREMxSHJPcHJiT0tYOVRhenhNSmNv?= =?utf-8?Q?i6pBmtSVw9usxVlI=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45f700f7-352d-48a5-b871-08da38bc1c69 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 10:49:40.7887 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wjBr9RxmPzQEmOnTDMhU1iAHPcpoBGs4LfQ0t2NVCWzGWxlEORLpK8pvQCnVTlIUQe8H5Zn7hsDinQ76RGbYdDBWu4/DXr+7lMihddXk6wE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4610 T24gMTgvMDUvMjAyMiAxMDowNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFtDQVVUSU9OIC0gRVhU RVJOQUwgRU1BSUxdIERPIE5PVCByZXBseSwgY2xpY2sgbGlua3MsIG9yIG9wZW4gYXR0YWNobWVu dHMgdW5sZXNzIHlvdSBoYXZlIHZlcmlmaWVkIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRl bnQgaXMgc2FmZS4NCj4gDQo+IE9uIDExLjA1LjIwMjIgMTc6MTQsIEphbmUgTWFsYWxhbmUgd3Jv dGU6DQo+PiBIYXZlIGlzX2h2bV9wdl9ldnRjaG5fdmNwdSgpIHJldHVybiB0cnVlIGZvciB2ZWN0 b3IgY2FsbGJhY2tzIGZvcg0KPj4gZXZ0Y2huIGRlbGl2ZXJ5IHNldCB1cCBvbiBhIHBlci12Q1BV IGJhc2lzIHZpYQ0KPj4gSFZNT1Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yLg0KPiANCj4gSSdt IGNvbmZ1c2VkOiBZb3Ugc2F5ICJwZXItdkNQVSIgaGVyZSwgYnV0IC4uLg0KPiANCj4+IC0tLSBh L3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9kb21haW4uaA0KPj4gKysrIGIveGVuL2FyY2gveDg2 L2luY2x1ZGUvYXNtL2RvbWFpbi5oDQo+PiBAQCAtMTQsOCArMTQsMTQgQEANCj4+ICAgDQo+PiAg ICNkZWZpbmUgaGFzXzMyYml0X3NoaW5mbyhkKSAgICAoKGQpLT5hcmNoLmhhc18zMmJpdF9zaGlu Zm8pDQo+PiAgIA0KPj4gKy8qDQo+PiArICogU2V0IHRvIHRydWUgaWYgZWl0aGVyIHRoZSBnbG9i YWwgdmVjdG9yLXR5cGUgY2FsbGJhY2sgb3IgcGVyLXZDUFUNCj4+ICsgKiBMQVBJQyB2ZWN0b3Jz IGFyZSB1c2VkLiBBc3N1bWUgYWxsIHZDUFVzIHdpbGwgdXNlDQo+PiArICogSFZNT1Bfc2V0X2V2 dGNobl91cGNhbGxfdmVjdG9yIGFzIGxvbmcgYXMgdGhlIGluaXRpYWwgdkNQVSBkb2VzLg0KPj4g KyAqLw0KPj4gICAjZGVmaW5lIGlzX2h2bV9wdl9ldnRjaG5fZG9tYWluKGQpIChpc19odm1fZG9t YWluKGQpICYmIFwNCj4+IC0gICAgICAgIChkKS0+YXJjaC5odm0uaXJxLT5jYWxsYmFja192aWFf dHlwZSA9PSBIVk1JUlFfY2FsbGJhY2tfdmVjdG9yKQ0KPj4gKyAgICAgICAgKChkKS0+YXJjaC5o dm0uaXJxLT5jYWxsYmFja192aWFfdHlwZSA9PSBIVk1JUlFfY2FsbGJhY2tfdmVjdG9yIHx8IFwN Cj4+ICsgICAgICAgICAoZCktPnZjcHVbMF0tPmFyY2guaHZtLmV2dGNobl91cGNhbGxfdmVjdG9y KSkNCj4gDQo+IC4uLiB5b3UgdXNlIChkKS0+dmNwdVswXSBoZXJlIChhbmQsIHllcywgeW91IHNh eSBzbyBpbiB0aGUgY29tbWVudCkNCj4gYW5kIC4uLg0KPiANCj4+ICAgI2RlZmluZSBpc19odm1f cHZfZXZ0Y2huX3ZjcHUodikgKGlzX2h2bV9wdl9ldnRjaG5fZG9tYWluKHYtPmRvbWFpbikpDQo+ IA0KPiAuLi4geW91IGRvbid0IGFsdGVyIHRoaXMgYXQgYWxsLg0KPiANCj4gQWxzbyAocmUtb3Jk ZXJpbmcgY29udGV4dCkgdGhpcyAuLi4NCj4gDQo+PiBpc19odm1fcHZfZXZ0Y2huX3ZjcHUoKSBy ZXR1cm5pbmcgdHJ1ZSBpcyBhIGNvbmRpdGlvbiBmb3Igc2V0dGluZyB1cA0KPj4gcGh5c2ljYWwg SVJRIHRvIGV2ZW50IGNoYW5uZWwgbWFwcGluZ3MuDQo+IA0KPiAuLi4gaXNuJ3QgcmVhbGx5IHRy dWUgLSBpdCdzIGlzX2h2bV9wdl9ldnRjaG5fZG9tYWluKCkgd2hpY2ggY29udHJvbHMNCj4gdGhp cyAod2hpY2ggaW4gdHVybiBpcyB3aHkgYWJvdmUgeW91IG5lZWQgdG8gbWFrZSB0aGUgYXNzdW1w dGlvbiBJJ3ZlDQo+IHB1dCB1bmRlciBxdWVzdGlvbikuIFdpdGggdGhhdCBhc3N1bXB0aW9uIEkg dGhpbmsgaXNfaHZtX3B2X2V2dGNobl92Y3B1KCkNCj4gd291bGQgYmV0dGVyIGdvIGF3YXkuDQpI ZXJlIG9ubHkgaXNfaHZtX3B2X2V2dGNobl9kb21haW4oKSBzaG91bGQgaGF2ZSBiZWVuIG1lbnRp b25lZC4gVGhlIA0KInBlci1WQ1BVIiB3YXMgaW4gcmVnYXJkIHRvIHRoZSB2ZWN0b3IgY2FsbGJh Y2sgZm9yIGV2dGhjbiBkZWxpdmVyeSANCnNldHVwIG5vdCBiZWluZyBnbG9iYWwgYnV0IG5vdyBk b25lIG9uIGEgcGVyLXZDUFUgYmFzaXMsIGluIGFueSBjYXNlLCBJIA0Kd2lsbCBhbWVuZCB0aGUg ZGVzY3JpcHRpb24gYW5kIHRpdGxlLiBUaGFua3MgZm9yIHRoZSBmZWVkYmFjay4NCg0KSmFuZS4= From xen-devel-bounces@lists.xenproject.org Wed May 18 10:52:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 10:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331987.555625 (Exim 4.92) (envelope-from ) id 1nrHIF-0007Ks-Eo; Wed, 18 May 2022 10:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331987.555625; Wed, 18 May 2022 10:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHIF-0007Kl-C7; Wed, 18 May 2022 10:52:39 +0000 Received: by outflank-mailman (input) for mailman id 331987; Wed, 18 May 2022 10:52:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHID-0007KU-Lk for xen-devel@lists.xenproject.org; Wed, 18 May 2022 10:52:37 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9eabc12b-d698-11ec-837e-e5687231ffcc; Wed, 18 May 2022 12:52:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eabc12b-d698-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652871154; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LOEEKV17fhboUoAHAlroS7b3W8TzEVY99C1J1TrtWps=; b=EQ2GJ5egLKLyFLk+fDFj1cv6UsTgEgU3x68KGp39l2DbsQH4F0uKKu6U ia+LkDNBA8Ch3mEdQzhzjY5ZaLcmSRhC6YMO7x/7I9vTfAYcAlprfd5Ll KMA1pJGoGH0tzT1x5HN37wbzpcVBjfPQPOQiyKXiaidglAXNzSwCLmh43 c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70956091 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:nSgNyaBXhTj2DRVW/7Xjw5YqxClBgxIJ4kV8jS/XYbTApD1whjYFz WYfCG7TPa6LZWqme95/PY/j8x4AvpOEmNZhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng0tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhcz NYSm4yzZj11ZI3ChLQGfwBaDSpHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8WTKuAP 5tAAdZpREzvPCcfYFYlM8IZsMqkmnvkcQdR803A8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo GPu/GnjBBwectuFxlKt8H22gfTUtTjmQ49UH7q9ntZonVmSy2o7GBAQE1yhrpGRgEOkR8hWL UBS/yM0tLUz72SiVNy7VBq9yFa6uRobV8tVAvcNwgiHwarJ4C6UHmEBCDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcFYSIHVhcU+NnLr4Q6jxaJRdFmeIayitD2Ajj2z yq9sDklh74TgMgI0I225VnCxTmro/DhVAku7B/QWWGjxgx8bY+hIYev7DDz8vJoPIufCF6bs xA5d9O2tb5US8vXzWrUHbtLTOrBC+u53CP0rFpsQLcx9BuXpySDc5wA+x1nJlliC5NREdP2W 3P7tQRU7Z5VGXKla65rfo68Y/gXIbjc+cfNDa6NMIcXCnRlXErepXw1OxbMt4z4uBJ0+ZzTL 6t3ZipF4ZwyLa18hAS7SO4GuVPA7nBvnDiDLXwXIvnO7FZ/WJJ3YepcWLdtRrpghE9hnOky2 48GX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/VqWBmOl9JtU7xPw9egL0E paVAx8w9bYCrSefdVXiho5LNtsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SnfEVeJPyQCX9tYtF 6NtU5zZWpxnE22bkxxAPciVhNEzL3yD2FPRVxdJlRBiJvaMsSSSoYS6FuYunQFTZheKWTwW+ OP8h1uGG8taHmyPzq/+MZqS8r94hlBF8MoaYqcCCoM7lJnEmGSyFxHMsw== IronPort-HdrOrdr: A9a23:LvUqKqsPxoOZyB7u9A1vEV4D7skC+IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H4BEDyewKlyXcV2/hYAV7MZniChILFFu9fBM7Zslvd8k7Fh6VgPM VbAsxD4bTLZDAX4voSojPIdOrIq+PmzEncv5a9854bd3AIV0gP1WZEIzfeNnczaBhNBJI/Gp bZzNFAvSCcdXMeadn+LmUZXsDYzue72a7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFqQrk/a+u2svLhiM0llWjoKi+quGRi+erN/b8yvT97Q+cyTpAUb4RFYFqegpF4t1Hpmxa1e Uk6C1QRPibo0mhBF1d5yGdkTUImQxelkPK2BuVnGCLm72IeBsqT8VGno5XaR3f9g4pu8x9yr tC2yaDu4NQFg6oplWL2zHkbWAeqqOPmwtXrQfTtQ0vbaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3kYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZ2feKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4vqfaWK 6xI2+wmVRCBH4GU/f+oKGj2iq9PlmAYQ== X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="70956091" Date: Wed, 18 May 2022 11:52:19 +0100 From: Anthony PERARD To: Oleksandr Tyshchenko CC: , Oleksandr Tyshchenko , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" , Stefano Stabellini , "Julien Grall" , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH V8 1/2] libxl: Add support for Virtio disk configuration Message-ID: References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-2-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1651598763-12162-2-git-send-email-olekstysh@gmail.com> On Tue, May 03, 2022 at 08:26:02PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-disk backend (emulator) which is intended to run out of > Qemu and could be run in any domain. > Although the Virtio block device is quite different from traditional > Xen PV block device (vbd) from the toolstack's point of view: > - as the frontend is virtio-blk which is not a Xenbus driver, nothing > written to Xenstore are fetched by the frontend currently ("vdev" > is not passed to the frontend). But this might need to be revised > in future, so frontend data might be written to Xenstore in order to > support hotplugging virtio devices or passing the backend domain id > on arch where the device-tree is not available. > - the ring-ref/event-channel are not used for the backend<->frontend > communication, the proposed IPC for Virtio is IOREQ/DM > it is still a "block device" and ought to be integrated in existing > "disk" handling. So, re-use (and adapt) "disk" parsing/configuration > logic to deal with Virtio devices as well. > > For the immediate purpose and an ability to extend that support for > other use-cases in future (Qemu, virtio-pci, etc) perform the following > actions: > - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect > that in the configuration > - Introduce new disk "specification" and "transport" fields to struct > libxl_device_disk. Both are written to the Xenstore. The transport > field is only used for the specification "virtio" and it assumes > only "mmio" value for now. > - Introduce new "specification" option with "xen" communication > protocol being default value. > - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current > one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model Is this still an issue? Since v5, the "disk/vbd" kind is used. Also see my comment about libxl_device_disk_get_path() regarding this. > An example of domain configuration for Virtio disk: > disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, specification=virtio'] > > Nothing has changed for default Xen disk configuration. > > Please note, this patch is not enough for virtio-disk to work > on Xen (Arm), as for every Virtio device (including disk) we need > to allocate Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree. The subsequent > patch will add these missing bits. For the current patch, > the default "irq" and "base" are just written to the Xenstore. > This is not an ideal splitting, but this way we avoid breaking > the bisectability. > > Signed-off-by: Oleksandr Tyshchenko > --- > diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c > index a5ca778..7fd98ce 100644 > --- a/tools/libs/light/libxl_disk.c > +++ b/tools/libs/light/libxl_disk.c > @@ -163,6 +163,19 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, > rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); > if (rc < 0) return rc; > > + if (disk->specification == LIBXL_DISK_SPECIFICATION_UNKNOWN) > + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; > + > + /* > + * The transport field is only used for the specification "virtio" and > + * it assumes only "mmio" value for now. When there will be a need to add > + * "pci" support, we will need to remove the enforcement here and > + * respective assert(s) down the code and let the toolstack to decide > + * the transport to use. > + */ > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) > + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; Could you check that `disk->transport` is unset when `specification==xen` ? And probably return ERROR_INVAL in this case. Also, I don't think you should overwrite the value set by an application in _setdefault(). If `specification==virtio`, check first that `transport` as a supported value (unknown or mmio) then you can then you can set the `transport` value expected by virtio if it wasn't set by the application. ( An example of this is done the function already when enforcing qdisk for cdroms. ) > + > /* Force Qdisk backend for CDROM devices of guests with a device model. */ > if (disk->is_cdrom != 0 && > libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { > @@ -317,6 +334,11 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, > goto out; > } > > + assert((disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO && > + disk->backend == LIBXL_DISK_BACKEND_OTHER) || > + (disk->specification != LIBXL_DISK_SPECIFICATION_VIRTIO && > + disk->backend != LIBXL_DISK_BACKEND_OTHER)); I'm not sure whether this assert() is useful. The value should already be correct as we call _setdefault(). It seems like an unnecessary potential crash at this point. > switch (disk->backend) { > case LIBXL_DISK_BACKEND_PHY: > dev = disk->pdev_path; > @@ -330,7 +352,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, > > assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD); > break; > + case LIBXL_DISK_BACKEND_OTHER: > + dev = disk->pdev_path; > + > + flexarray_append(back, "params"); > + flexarray_append(back, dev); > > + assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK); > + break; > case LIBXL_DISK_BACKEND_TAP: > LOG(ERROR, "blktap is not supported"); > rc = ERROR_FAIL; > @@ -386,6 +415,15 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, > flexarray_append_pair(back, "discard-enable", > libxl_defbool_val(disk->discard_enable) ? > "1" : "0"); > + flexarray_append(back, "specification"); > + flexarray_append(back, libxl__device_disk_string_of_specification(disk->specification)); > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); I don't think this is a good assert(). If an application sets the wrong "transport" for virtio, it should get an error, not crash. But I believe in this case that _setdefault() could already check that "transport" is correct, so there's probably no need to check the transport value here. > + flexarray_append(back, "transport"); > + flexarray_append(back, libxl__device_disk_string_of_transport(disk->transport)); > + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base)); > + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq)); > + } > > flexarray_append(front, "backend-id"); > flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); > @@ -532,6 +570,49 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path, > } > libxl_string_to_backend(ctx, tmp, &(disk->backend)); > > + tmp = libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/specification", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/specification", libxl_path); This mean that we introduce an hard error if we deal with a previous version of libxl that didn't write this path. But we know that it meant specification=xen, so could we default to "xen" when the node is missing, rather than return an error? (It's mostly useful for developper at this point as creating a vm with one version of libxl and keep managing it with a newer version isn't really possible for now.) > + goto cleanup; > + } > + if (!strcmp(tmp, "xen")) > + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; > + else if (!strcmp(tmp, "virtio")) > + disk->specification = LIBXL_DISK_SPECIFICATION_VIRTIO; > + else > + disk->specification = LIBXL_DISK_SPECIFICATION_UNKNOWN; That's a reimplementation of a generated function, libxl_disk_specification_from_string() I believe ;-) > + > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > + tmp = libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/transport", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path); > + goto cleanup; > + } > + if (!strcmp(tmp, "mmio")) > + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; > + else > + disk->transport = LIBXL_DISK_TRANSPORT_UNKNOWN; That's libxl_disk_transport_from_string() I think. > + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); Could you return an error instead of assert() here? > + > + tmp = libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/base", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); > + goto cleanup; > + } > + disk->base = strtoul(tmp, NULL, 10); > + > + tmp = libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/irq", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); > + goto cleanup; > + } > + disk->irq = strtoul(tmp, NULL, 10); > + } > + > disk->vdev = xs_read(ctx->xsh, XBT_NULL, > GCSPRINTF("%s/dev", libxl_path), &len); > if (!disk->vdev) { > @@ -575,6 +656,41 @@ cleanup: > return rc; > } > > +static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid, FYI, "libxl_" prefix is for functions exported by the library. You could use "libxl__" for functions used within the library or no prefix in this case as it is static. > + char **path) > +{ > + const char *dir; > + int rc; > + > + /* > + * As we don't know exactly what device kind to be used here, guess it > + * by checking the presence of the corresponding path in Xenstore. > + * First, try to read path for vbd device (default) and if not exists > + * read path for virtio_disk device. This will work as long as both Xen PV > + * and Virtio disk devices are not assigned to the same guest. > + */ That mean, we can't have both virtio-disk and pv-disk, and there's going to be weird error with device disappearing if one try to add a pv-disk after adding a virtio-disk. Also, I don't know whether the function is called before a first device is added, but it could be a potential issue as it would return an error in that case. The path generated here are path that are only used by libxl, so it probably doesn't matter which path is used, as long as there's a unique path for a device implementation. (The different path might have been useful in v4 of the series when there was a libxl-virtio-disk implementation.) So, is there a reason to have different path? Can we simply get rid of this function? Maybe this is related to the path that a frontend would see, and we probably don't want to have a pv-disk front-end trying to connect to a virtio backend as it doesn't going to work. I wonder if the "/libxl/*/device/" needs to use the same "device kind" name as the ones seen by a guest. I didn't investigated that. > + *path = GCSPRINTF("%s/device/%s", > + libxl__xs_libxl_path(gc, domid), > + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD)); > + > + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); > + if (rc) > + return rc; > + > + if (dir) > + return 0; > + > + *path = GCSPRINTF("%s/device/%s", > + libxl__xs_libxl_path(gc, domid), > + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); > + > + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); > + if (rc) > + return rc; > + > + return 0; > +} > + > int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, > const char *vdev, libxl_device_disk *disk) > { > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index 2a42da2..f783cac 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -704,6 +716,10 @@ libxl_device_disk = Struct("device_disk", [ > ("is_cdrom", integer), > ("direct_io_safe", bool), > ("discard_enable", libxl_defbool), > + ("specification", libxl_disk_specification), > + ("transport", libxl_disk_transport), Could you add a comment here about "irq" and "base", that say that they are for internal use by libxl and can't be modified? Is it possible that in the future, an application like libvirt could potentially change those two values and have libxl use them? > + ("irq", uint32), > + ("base", uint64), > # Note that the COLO configuration settings should be considered unstable. > # They may change incompatibly in future versions of Xen. > ("colo_enable", libxl_defbool), Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed May 18 11:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 11:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.331997.555636 (Exim 4.92) (envelope-from ) id 1nrHTt-0000XP-GK; Wed, 18 May 2022 11:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 331997.555636; Wed, 18 May 2022 11:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHTt-0000XI-Db; Wed, 18 May 2022 11:04:41 +0000 Received: by outflank-mailman (input) for mailman id 331997; Wed, 18 May 2022 11:04:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHTs-0000X8-4w; Wed, 18 May 2022 11:04:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHTs-0002rh-2R; Wed, 18 May 2022 11:04:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHTr-0005HA-IU; Wed, 18 May 2022 11:04:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrHTr-0005Kx-I3; Wed, 18 May 2022 11:04:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+vNuvWljsDroiDAQtJ5CLfdb+32g0b3ofWh6/qFHPd0=; b=jMCHwpCnL93O4aDJwdbXhixzgz u38mzxqJSXUTnbiFXkPZgFwtjO6oiKyI1p9CSAfTWf+xgyhY7YrNfCWNuX681px3xMrfuvzb94MYX 3Bm5AURMqKlp/tkzjrDbxsyhI9r0UUu0WIovExU9ruxTBqfq1oNxQrxS7plEcd1HTMww=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170534: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 11:04:39 +0000 flight 170534 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170534/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1081 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 100 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 11:06:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 11:06:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332007.555646 (Exim 4.92) (envelope-from ) id 1nrHVD-00016K-SD; Wed, 18 May 2022 11:06:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332007.555646; Wed, 18 May 2022 11:06:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHVD-00016D-Oo; Wed, 18 May 2022 11:06:03 +0000 Received: by outflank-mailman (input) for mailman id 332007; Wed, 18 May 2022 11:06:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHVC-000165-Kk for xen-devel@lists.xenproject.org; Wed, 18 May 2022 11:06:02 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f9267f7-d69a-11ec-837e-e5687231ffcc; Wed, 18 May 2022 13:06:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f9267f7-d69a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652871961; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iaY1WR4metXJyWPNHIiVGadin5NrWxhl8OS+cf7J8LI=; b=WXvTpMC3xm3/Bl1UxMrgUwoes6PxkhKUDxsHQMlaivOaZfTDsd1kA6DI JqTezVencMJs5OI6MvwTJ7LiYMI6+G7fWOFUZ2yGnjYjdScteV3h7bAPF aTbIFOH0hiNYiayoylrFNhf99ZHhSPmbKjCgowaCTqGrvmuwCFYxh/rR3 s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 70956835 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:RRpeoKCpTWngtBVW/7bjw5YqxClBgxIJ4kV8jS/XYbTApDtw1GEHy mBJXWvTPf/YMzT9KNx0aoyyoU4HvJHSn9Q2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng0tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhRy dNtmqK8ZD0lFfzCt8oMEAECOiBXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8WTKuAN 5FEAdZpRDHQYBpRE2gcMrAnvbqwxXPOeTdnmnvA8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo CTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3vRnmkGJz2ofThgfT0KmoOKRg1S7HdlYL iQ8/S4jrrM78kCxecXsRB2zoHOCvRk0VsJZFqsx7wTl4pTT5wGVF20VVAlrYdYttNI1bTEy3 1rPlNTsbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bphXLQ9V4DL+ujvX6HDjxx 3aBqy1Wr7cOic8G0eO051nDhxqlvJ2PRQkwji3VUXii9RhRf5O+asqj7l2zxelEBJaUSB+Gp ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqX5uGbkOyTiAwXKILI5/ziA9PB1AM+9RLFcFf 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquKN4QTO/CdYCfCpXgzPhDIgwgBhWB2yckC1 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59YaTNijchjtctoRTk5F P4GbqO3J+13CrGWX8Uu2dd7wao2BXY6H4vqjMdca/SOJAFrcEl4VaKLkep7J9E8wf8N/gstw p1achYIoGcTeFWdcVnaApydQO2HsWlDQYITYnV3YAfAN4kLaoez9qYPH6bbjpF8nNGPOcVcF qFfE+3ZW6wnYm2ep1w1MMmsxKQ/JU/DrV/fYEKYjM0XIscIq/rhoYS/IGMCNUAmU0KKiCfJi +b+ilKDHMBSHl0K4QS/QKvH8m5ddEM1wIpaN3Yk6PEJEKkw2OCG8xDMs8I= IronPort-HdrOrdr: A9a23:pt6kRqpWYsqiL2cHgvT7oikaV5opeYIsimQD101hICG8cqSj9v xGuM5rsiMc6QxhPE3I9urtBEDtexzhHNtOkO8s1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM VdmsBFeaTN5DNB7foSjjPXL+od X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="70956835" Date: Wed, 18 May 2022 12:05:52 +0100 From: Anthony PERARD To: Oleksandr Tyshchenko CC: , Julien Grall , "Wei Liu" , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: Re: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm Message-ID: References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-3-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1651598763-12162-3-git-send-email-olekstysh@gmail.com> On Tue, May 03, 2022 at 08:26:03PM +0300, Oleksandr Tyshchenko wrote: > From: Julien Grall > > This patch introduces helpers to allocate Virtio MMIO params > (IRQ and memory region) and create specific device node in > the Guest device-tree with allocated params. In order to deal > with multiple Virtio devices, reserve corresponding ranges. > For now, we reserve 1MB for memory regions and 10 SPIs. > > As these helpers should be used for every Virtio device attached > to the Guest, call them for Virtio disk(s). > > Please note, with statically allocated Virtio IRQs there is > a risk of a clash with a physical IRQs of passthrough devices. > For the first version, it's fine, but we should consider allocating > the Virtio IRQs automatically. Thankfully, we know in advance which > IRQs will be used for passthrough to be able to choose non-clashed > ones. > > Signed-off-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de0..37403a2 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -8,6 +8,46 @@ > #include > #include > > +/* > + * There is no clear requirements for the total size of Virtio MMIO region. > + * The size of control registers is 0x100 and device-specific configuration > + * registers starts at the offset 0x100, however it's size depends on the device > + * and the driver. Pick the biggest known size at the moment to cover most > + * of the devices (also consider allowing the user to configure the size via > + * config file for the one not conforming with the proposed value). > + */ > +#define VIRTIO_MMIO_DEV_SIZE xen_mk_ullong(0x200) > + > +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc, uint64_t *virtio_mmio_base) > +{ > + uint64_t base = *virtio_mmio_base; > + > + /* Make sure we have enough reserved resources */ > + if ((base + VIRTIO_MMIO_DEV_SIZE > > + GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) { Could you remove the second set of parentheses? I'd like the compiler to warn us if there's an assignment. > @@ -26,8 +66,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > { > uint32_t nr_spis = 0; > unsigned int i; > - uint32_t vuart_irq; > - bool vuart_enabled = false; > + uint32_t vuart_irq, virtio_irq = 0; > + bool vuart_enabled = false, virtio_enabled = false; > + uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; > + uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; > > /* > * If pl011 vuart is enabled then increment the nr_spis to allow allocation > @@ -39,6 +81,30 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > vuart_enabled = true; > } > > + for (i = 0; i < d_config->num_disks; i++) { > + libxl_device_disk *disk = &d_config->disks[i]; > + > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); > + if (!disk->base) > + return ERROR_FAIL; > + > + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); > + if (!disk->irq) > + return ERROR_FAIL; > + > + if (virtio_irq < disk->irq) > + virtio_irq = disk->irq; > + virtio_enabled = true; > + > + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, > + disk->vdev, disk->irq, disk->base); > + } > + } > + > + if (virtio_enabled) > + nr_spis += (virtio_irq - 32) + 1; Is it possible to update "nr_spis" inside the loop? The added value seems to be "number of virtio device + 1", so updating "nr_spis" and adding +1 after the loop could work, right? Also, what is "32"? Is it "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" ? > + > for (i = 0; i < d_config->b_info.num_irqs; i++) { > uint32_t irq = d_config->b_info.irqs[i]; > uint32_t spi; > @@ -787,6 +860,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, > return 0; > } > > + > +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, > + uint64_t base, uint32_t irq) > +{ > + int res; > + gic_interrupt intr; > + /* Placeholder for virtio@ + a 64-bit number + \0 */ > + char buf[24]; > + > + snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base); Could you use GCSPRINTF() here instead of using a buffer of a static size calculated by hand which is potentially wrong? Also, the return value of snprintf isn't checked so the string could be truncated without warning. So I think GCSPRINTF is better than a static buffer. The rest of the patch looks fine. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed May 18 11:14:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 11:14:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332025.555662 (Exim 4.92) (envelope-from ) id 1nrHdK-0002om-2O; Wed, 18 May 2022 11:14:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332025.555662; Wed, 18 May 2022 11:14:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHdJ-0002of-V6; Wed, 18 May 2022 11:14:25 +0000 Received: by outflank-mailman (input) for mailman id 332025; Wed, 18 May 2022 11:14:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHdI-0002oZ-RU for xen-devel@lists.xenproject.org; Wed, 18 May 2022 11:14:24 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aab6ef8a-d69b-11ec-837e-e5687231ffcc; Wed, 18 May 2022 13:14:23 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 07:14:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6450.namprd03.prod.outlook.com (2603:10b6:806:1c1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 11:14:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Wed, 18 May 2022 11:14:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aab6ef8a-d69b-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652872463; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=qA6mY1TGIYqa1RUBfpYs4NWpiulEUJrZAoKn08ZRtus=; b=HHHgZRMImG67zFZYvJU4rtjiePrhQwbGx+asxI7zswRDqP4vPNhPY5O1 1Ktj+ipC9xnSLOrPOvYfNJdXfSqecJhMkNLWr9/vy8Sl15jdvbVSHztA4 imZSkbYaHY5mQcS4fQKyEErKyd0/jS37yZRb7jip/QMODfRaQIRnP4kqI U=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 71577231 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/MiTlKBYdsErUhVW/z/iw5YqxClBgxIJ4kV8jS/XYbTApGwlgj0Bx 2QcW2nVM/jeMTSnL9F2YIWwp0wDvpbUnYBlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng0tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhww vNgpaWaEj0KL6fzhOAsCwlEGQFxaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcGM0m5vcBtNs0rulIEezTe Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGQF9w3P/vNfD277klBz8qDyOdruI9GRYsNQoVepj 3r+4DGsav0dHJnFodafyVqIm+TG2w3yXokfELml3vdwhRuYwWl7IA0bUx63rOe0jma6WslDM AoE9yw2t68w+Ue3CN7nUHWQonGeuQUHc8FNCOB84waIooLY7Q+WCWkDSj9pc8E9uYk9QjlC6 7OSt9bgBDgqvLjLT3uYr+2QtWnrZnNTKnIebygZSwdD+8PkvIw4khPISJBkDbKxidr2Xzr3x lhmsRQDulnatuZTv43TwLwNq2jESkThJuLt2jjqYw== IronPort-HdrOrdr: A9a23:cna8V65Pfh147EjtzgPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+ O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVDHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMiP8Pe X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="71577231" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cbg8jyyhlBPZfNastX9WhxVJpZ+Ky14EjdUZ+LZ8bzqr+Tt8c9b3KGlnxQltqVoidzJGZtvg0xqc38SDj3U/Vot7PkVw9kbrNWVYx0NuJehdGtyhchHUsBet5Rm6tN5dsVPNQZEJliop54Cn9vTmv81blQ2cu2jb9Dlq1508TfyTdEwBO+F/3JB178D52FsokyCq/Tta5w1gjGAjRP50ZsZe5ti0eHl9ubEhYQdRkWuIxlce7OcSfHQ526kMc93I0FQIUsTh4h+r9K1zD3kqGGm1iQ09fIMImeQlyTK+suQyfgVshjUZuQnx2MgSlsKLwQmAUgg4AtQAglMY2Ze4rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qA6mY1TGIYqa1RUBfpYs4NWpiulEUJrZAoKn08ZRtus=; b=dxSFYgcRNpBv5NxI8ge/h5qB4mDVGSItE0M4NlnYHU473rt0tGGRlQI8o6gl5sLjiROeawDH7RojEZ4NBltjWsIBsD+apXCDhLQSwTH4hECt644fTAIb+8kyQsN0hvGD9wGvIov/5wnRXGS2MP7NFtoKF1io30IGJ3GodC66jzDWJceP1aj57eum5YSI5jTGXUbqAo9lCVeCbCFARTYkW1e0OjJQGbBq/QG8rzAl7rT2d6QSIJnTwMtkuOmJPwhkOu2aJmi5ivmzAq0nZcsRSPksdh/uydCrehkclO7faEYU24nfmLNd5hRFxz73k+siTg5bfn+Y1JBhKghImJZhvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qA6mY1TGIYqa1RUBfpYs4NWpiulEUJrZAoKn08ZRtus=; b=hrzQ9urs0kDYrVba1w575xf11qA2jqaLNhhcESVNnEfcuam8XKKl2B66I1r99xdEVwFfThtb83CviEcIqYywA6m9I9RBTBI+HW1AyP9oCx9nIV03ueTrbuia50BuKrNZ0VVEa9ftKIELt3JH3/5LeErLkGFv4+gq+8zVQIX2vpk= From: Andrew Cooper To: Luca Fancellu CC: Xen-devel , Juergen Gross , Dario Faggioli Subject: Re: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Thread-Topic: [PATCH 1/2] xen/cpupool: Reject attempts to add a domain to CPUPOOLID_NONE Thread-Index: AQHYaiYkCDtg+YouUE6RTw/ztN5ARK0kb2CAgAANJgA= Date: Wed, 18 May 2022 11:14:17 +0000 Message-ID: <37b75732-29b5-7fd8-4d93-a7677eebbfa0@citrix.com> References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-2-andrew.cooper3@citrix.com> <2D47137E-C808-4FA7-B220-7022C85BBB4F@arm.com> In-Reply-To: <2D47137E-C808-4FA7-B220-7022C85BBB4F@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72c83b15-be5e-4d0c-6519-08da38bf8c54 x-ms-traffictypediagnostic: SA1PR03MB6450:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fEC7jAR2VZ5gvCfZmDrMWPaPAjYmQLV8fhm6gPp9KnAhnu/OI8ymxvtSL4rT9Uvi5d+CS2UjZINaZ39fymgiKX8LtbYdfyu1AqYTz+sJWWIboibny3ng9KjoAmOofbs7S8i9VgBPi17yokBTKdbNrJdnnGfzazOELkso2METQaYtrCvBFkbBE1Sd7tuTuQruWyF7Oe9NXpyPv47xNTl2/PplSlnEc1qsIe3y2Ouxiv95oXh4E6tLBM8ls/z+1IwrR0o4u/mqYAe/9G4x1mnmShxBttxccVUVbQZQhDIJHPlvnV9L0cFlo+b6+AuOpLLL2dRaNLLvCRTm8VXvtHEZoFaerasFgyxGBYFU4pMmtMSdE3LFJgKg0K5fSjlMgFbI/yAd6wEnYgTkSpSehVKbPWzLCqoTx/urqGUqn3Bc7yeyAAENZ2oWJVvL6QFXVKBwQSdPKzbHTHcxZHNkZxL9bhRtflN6K/fhE0is5pkEi0wGu+OSgtey2M5kC3j2VeS+4KOAR91dcfQ8i0D8shBCCk2IWH3h54Wk7Yt2iqnuh3ZuUT5UOiCVDc5WZ+RC2KkxbDrr1iXADkOTZoNSo9Ih6+x5HX2LoQiKrEiZPQt67EwO+GyM6CGf4m9EBFzOeAvm3NF2mI9dznhtgP+8FByjaR5aCjw2pbRGyDF+bJdxUBl/uoLwOoxjSCeo53PodBAu3um/m/FGhdI4hhuikkvHhMPXwYl5uwoOttDtk3l0EPWx8hEmSLfXn+raDIRtwFs5rl+0GvxtjGkSnvlUi9aW+A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(55236004)(2906002)(6512007)(53546011)(82960400001)(122000001)(5660300002)(38100700002)(38070700005)(508600001)(26005)(66476007)(31686004)(66446008)(91956017)(4326008)(66556008)(66946007)(76116006)(64756008)(36756003)(186003)(8676002)(316002)(71200400001)(6916009)(54906003)(86362001)(6506007)(8936002)(31696002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YVdaMUNuaHVFNUxzRHpDRmdLMVEvZWhDTHhSZ0xxc01IOUpmN25RdE54cWJN?= =?utf-8?B?eGFaMTBlM0lWS3UzNzJLS0grZGFRYnNSVDZlOWxlQ2VYM1VPVFlac1c5NjZX?= =?utf-8?B?OFp6ZzhicXhHWFQyd1RPZ2hEbm9yakxvdUtFQkt5TUFRYUJScE5EdzdFT3Bz?= =?utf-8?B?cEhEalZva25FdG5OTHhEcUxFMFdDTFllKzhZMnEyU0ExbGtvaitucjVGaTFI?= =?utf-8?B?bFFYOXVkdlB2RW1jb2MzcTFDQjZYajlxbEhpQkxMUjVSM3I2MnM2a3N4Z3pX?= =?utf-8?B?K3IrZmxqdGZKdjU0eDhSdTBjejdBb2FWbmtoRCtMc1VIcEpDbG80T0hoTmdD?= =?utf-8?B?WVZJajNzdk1qdngzVUFCZm9meWdZSVlFM0krL0l0VzhWazhPK1Z3V2pYNERS?= =?utf-8?B?NmVtcEc1UjRrT2J4SE1jY2JSS3c2TGlITzFWYW40VlgwSXdnL3QzNVBmdEtL?= =?utf-8?B?SWlOKzU5Q3lHblpwT09ReVJkWXYvQ0FXMzRZMEdyNGhPYk40RGdTMkhYVDRN?= =?utf-8?B?ZFEzMVdadW9hYklsNVAwVTN0U2NsQVF3VzJLNzJaWTlTeUZLemxIWWw2enh5?= =?utf-8?B?cXVkYTNicGNpV3liRzZKZXl3TWJxQ1NIOW00bDh3bDlIMmhNNnhJME04NExk?= =?utf-8?B?bHNJK3VvWHlRSC9rc3lmTi84ZzNHek4zcVJvNXd5U3dFWVhheFlmRWZKNC9H?= =?utf-8?B?ajhoQ3plTitrNjhJYmxpYnZyQitBRVM4UU8xMitrWUVrVFpDSzhEZnVpVWQ0?= =?utf-8?B?T0Uzdk82UjFHVm4xcFBlMktXUk80L1g2akh1WXpSeHRwK0pEZ2hta2JNY01v?= =?utf-8?B?cXJ1bW5iTEQzb1lORVR0Q3BueXBzNHpaN0RndVRJbWFrNUZkS0FaT0YzNGJF?= =?utf-8?B?Z0JzaWxSN1VEdkVFdnh4eEQ3Y0hVM1pvYXFpTXJjYjhUdUpjRFZvR3NTc1JD?= =?utf-8?B?V3BUUmZHSkxYa2NHTUVVdklNZUV3R0NjT1RqZDhQdHlRU0F6RXV6d1k2YkVR?= =?utf-8?B?bHovOXBiSmZ6WEFCMVZSK1pVUHE0OElKUGpBZU1CR3QzOXdjRkVTTk9ZdnBW?= =?utf-8?B?L0R5cEdTU01BTXp0U0M3Yyt5WmRxMWFJNkhMNXpnUEFYUzEySUt2ZTVJSzJv?= =?utf-8?B?cUc3aVdUT1lPdkJieVgzdTJHRWk5YjNIazhDckRLTVVUQjVGS3R2dVRwTks3?= =?utf-8?B?ZEROc01LSjJUaTlIZG5CSDdRbzhhUDZ4OVRBM0Vtem1DVGhSMGxJNWd4WEpa?= =?utf-8?B?bTN1RHp4TXhEYk41R2Z5SHBreDJMcmJPWm1Rb1VTUHpxeno0TzliZWRRWWha?= =?utf-8?B?VHd3b0liSkx0U0ZFMExoYjdKMkRzK3h2VnZtbGNFdUp0cHkvU3d2b081SC9j?= =?utf-8?B?anZUdFFXZFhsdllBSzZWLzczLzY5VmxqaGZpUkpxRFJ6R2FwZTVON1VmYXMy?= =?utf-8?B?WmxFMWRmbHl4KzJRL2tkaVpSYWIvVkVuMjJBRXRJekovQU9POU8wTmZkWGtP?= =?utf-8?B?SHBiVFY4UklwSUZ1RjhIS1NTbERFZFJFY3pRMUJ6U0M5QXVxcldoci9KT0xW?= =?utf-8?B?L29EQlpLYmtDOVFwWFhoOGtYM1gvR093eVhVWmNTYW1zeGIvQW14QnZHSWZi?= =?utf-8?B?cVdMRFZObUJDMkVmaTNLeUdnNlNabXJkd3VxeVpHdFRFMEVHZ3RiVllKdmp3?= =?utf-8?B?NHA4dHR3cDRyMHNpSG5leU9lbk8zb0Q1VVVOQkc1YnZPbG5sRitySStrdXgw?= =?utf-8?B?cWNIVGdiVksvSUNWQzYrV3JPaVVIdXc3WGh0YlN5VG1Ld0poNkVHejZ5UHY5?= =?utf-8?B?cE9qaDNCb2tzZW5jRWRBOGRnVFN1dThQaFpaMU12THNCQ0o0T2tDQVFhbXpq?= =?utf-8?B?eHpnMmJzSGZqOHNPTUNXUWgzVHBIanhNSlpLUEpCWncyT1VIR1lxTGR1M3Jo?= =?utf-8?B?OWpBcEtvNkZLUXRVVUdCaitZcWhGaDd0blBuc0ptd2wvRXpWQVpyclRDWlFU?= =?utf-8?B?Yld3ZzZtZUcyMVRJSzFjSmNSTjVwU2RGWlUzaUhMNzYwV01QaWJJMTk0Z2xY?= =?utf-8?B?N1h0eGZrbnJCaitjQnRqNHd5ZjFUTU9naFFDY1g4TnRaN3FRMDRIU3FWT25T?= =?utf-8?B?N211bHhqRi9lM2JDSUFrK2lKcklUWHJHcWpjMndSRW9WOC8xTG9ZSmhXMUFF?= =?utf-8?B?VS9MOGtSWUdTeGdvVVF6QnJMNHIrRDNSS1hMUldmU3oxU3g4VEVqeUZMV0Na?= =?utf-8?B?RUdRTXhsYjNwZEFPclkvd3o4ZlR1R3N1QlJsVmdHYXRHWkRzVUt1aUxEM2p6?= =?utf-8?B?dlV5azcwdklkRk9La1JDMkFtUWg2ZTVNaEhoaG9NOGFXZGhESVZRQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <9D3E0AE67FFEAF42A8BC3664451BAB91@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72c83b15-be5e-4d0c-6519-08da38bf8c54 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 11:14:17.0440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hk9uPuoMByrKNJQgh+W40OddFsEgtZsZeUb5jRyYv7Opl0PGrikPXZzqfRAnpTvINoRrXTOAv/GBNxSSyKMIsmFNU3B2tA4LtXLbyWoI5bM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6450 T24gMTgvMDUvMjAyMiAxMToyNywgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4gSGkgQW5kcmV3LA0K Pg0KPj4gT24gMTcgTWF5IDIwMjIsIGF0IDIwOjQxLCBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4+DQo+PiBjL3MgY2ZjNTIxNDg0NDRmICgieGVuL2Rv bWFpbjogUmVkdWNlIHRoZSBxdWFudGl0eSBvZiBpbml0aWFsaXNhdGlvbiBmb3INCj4+IHN5c3Rl bSBkb21haW5zIikgcmVtb3ZlZCB0aGUgcGF0aCBpbiBkb21haW5fY3JlYXRlKCkgd2hpY2ggY2Fs bGVkDQo+PiBzY2hlZF9pbml0X2RvbWFpbigpIHdpdGggQ1BVUE9PTElEX05PTkUgZm9yIHN5c3Rl bSBkb21haW5zLg0KPj4NCj4+IEFyZ3VhYmx5LCB0aGF0IGNoYW5nZXNldCBzaG91bGQgaGF2ZSBj bGVhbmVkIHVwIHRoaXMgcGF0aCB0b28uDQo+Pg0KPj4gSG93ZXZlciwgYy9zIDkyZWE5YzU0ZmM4 MSAoImFybS9kb20wbGVzczogYXNzaWduIGRvbTBsZXNzIGd1ZXN0cyB0byBjcHVwb29scyIpDQo+ PiBjaGFuZ2VkIGRvbWFpbl9jcmVhdGUoKSBmcm9tIHVzaW5nIGEgaGFyZGNvZGVkIHBvb2xpZCBv ZiAwLCB0byB1c2luZyBhIHZhbHVlDQo+PiBwYXNzZWQgYnkgdGhlIHRvb2xzdGFjay4NCj4+DQo+ PiBXaGlsZSBDUFVQT09MSURfTk9ORSBpcyBhbiBpbnRlcm5hbCBjb25zdGFudCwgdXNlcnNwYWNl IGNhbiBwYXNzIC0xIGZvciB0aGUNCj4+IGNwdXBvb2xfaWQgcGFyYW1ldGVyIGFuZCBhdHRlbXB0 IHRvIGNvbnN0cnVjdCBhIHJlYWwgZG9tYWluIHVzaW5nIGRlZmF1bHQgb3BzLA0KPj4gd2hpY2gg YXQgYSBtaW5pbXVtIHdpbGwgZmFpbCB0aGUgYXNzZXJ0aW9uIGluIGRvbV9zY2hlZHVsZXIoKS4N Cj4+DQo+PiBGaXhlczogOTJlYTljNTRmYzgxICgiYXJtL2RvbTBsZXNzOiBhc3NpZ24gZG9tMGxl c3MgZ3Vlc3RzIHRvIGNwdXBvb2xzIikNCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIg PGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFRoYW5rcyBmb3IgdGhpcyBmaXgsIHdpdGgg dGhlIGludHJvZHVjdGlvbiBvZiA5MmVhOWM1NGZjODEgKCJhcm0vZG9tMGxlc3M6IGFzc2lnbiBk b20wbGVzcyBndWVzdHMgdG8gY3B1cG9vbHPigJ0pDQo+IHdl4oCZdmUgY2hlY2tlZCBhbGwgdGhl IHBhdGggcGFzc2luZyBzdHJ1Y3QgeGVuX2RvbWN0bF9jcmVhdGVkb21haW4sIGFuZCBhdCB0aGF0 IHRpbWUgaXQgc2VlbXMgdG8gYmUgdGhhdA0KPiB0aGUgbmV3IGNwdXBvb2xfaWQgbWVtYmVyIHdv dWxkIGhhdmUgYmVlbiBhbHdheXMgemVybyB3aGVuIGNyZWF0ZWQgZnJvbSB0aGUgdG9vbCBzdGFj aywgYW0gSSB3cm9uZz8NCg0KSHlwZXJjYWxscyBhcmUgYW4gZW50aXJlbHkgcHVibGljIEFQSS9B QkkuDQoNCkxvb2tpbmcgdGhyb3VnaCB4ZW4uZ2l0IGdldHMgeW91IHRoZSBjb21tb24gdXNlcnMs IGJ1dCBpdCBtb3N0DQpkZWZpbml0ZWx5IGRvZXNuJ3QgZ2V0IHlvdSBhbGwgdXNlcnMgb2YgdGhl IGludGVyZmFjZS4NCg0KVGhpcyBoeXBlcmNhbGwgc3BlY2lmaWNhbGx5IGdldHMgZnV6emVkICh0 aGVyZSdzIGEgS0ZYIFBvQyBzb21ld2hlcmUpLA0KYnV0IGl0J3MgYSBidWcgZm9yIGFueSBoeXBl cmNhbGwgdG8gYmUgYWJsZSB0byBoaXQgYW4gYXNzZXJ0aW9uL2NyYXNoL2V0Yy4NCg0KPiBJ4oCZ bSBhc2tpbmcgc28gdGhhdCBJIHdpbGwga2VlcCBpbiBtaW5kIGZvciB0aGUgZnV0dXJlLg0KPg0K PiBIb3dldmVyIHdpdGggeW91ciBzZWNvbmQgcGF0Y2ggb2YgdGhpcyBzZXJpZSwgdGhlIHRvb2wg c3RhY2sgaXMgYWJsZSB0byB3cml0ZSBpdCwgc28gSSBndWVzcyB0aGlzIGZpeCBub3cgaXMgbWFu ZGF0b3J5Lg0KPg0KPiBJ4oCZdmUgdGVzdGVkIHlvdXIgcGF0Y2gsIGVuYWJsaW5nIGJvb3QgdGlt ZSBjcHVwb29scywgb24gYW4gYXJtIG1hY2hpbmUgYW5kIGJvb3RpbmcgWGVuK0RvbTAgYW5kIGFu b3RoZXIgRG9tVQ0KPiBieSBkb20wbGVzcyBmZWF0dXJlLCBhbmQgYWxsIHdvcmtzLg0KPg0KPiBS ZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPiBUZXN0 ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KVGhhbmtzLg0K DQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 11:34:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 11:34:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332034.555673 (Exim 4.92) (envelope-from ) id 1nrHwX-0005L2-Ow; Wed, 18 May 2022 11:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332034.555673; Wed, 18 May 2022 11:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHwX-0005Kv-Kt; Wed, 18 May 2022 11:34:17 +0000 Received: by outflank-mailman (input) for mailman id 332034; Wed, 18 May 2022 11:34:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrHwW-0005Kp-0s for xen-devel@lists.xenproject.org; Wed, 18 May 2022 11:34:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70ed8d22-d69e-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 13:34:14 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 07:34:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CY4PR03MB3078.namprd03.prod.outlook.com (2603:10b6:910:5b::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 11:34:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Wed, 18 May 2022 11:34:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70ed8d22-d69e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652873654; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Kr8WqZ1XN6M2i3dml6O22rlME34Dkh62jD+RCBBQlVw=; b=LcWTtADQ7o96+oBKQb+hNpKBwnd51qRx7SPhJVtlGytNCpg39xyqcCip o4a+GrWV+hmAEsnAwLOcXKnhDHiGHw8jdSG1dvCQEprVPqjRSNKYoeyRx yTq+pJIPoEhuEd5sxy/CMnQeP/vssM5VeGBo9G7PqqO1sp/M3xwU9tDLt A=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 70958368 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hObT8q71slpheg8QMfs+ZgxRtFPGchMFZxGqfqrLsTDasY5as4F+v jZNWG+Ab62DZDb2eNpzOYS0808PsZGHmtBhS1c5+3tkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgU1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTtVwINYfePqt8UVjZCGi1aYKNA57nIdC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YHh1/chegXdRraT +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+vJmvjiIklwZPL7FIeTZS8CVa9dprGnb+ Fvf2VTjIxsdHYnKodaC2jf27gPVpgvfRYkbUpOx8PVnhFmO7mUJDVsdUl7Tiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4FuQ77ESHzPrS6gPAXGwcFGceM5ohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:iWTtta0z3UUrH3XoJ5FAwAqjBetxeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+ UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgZJq3PoiFXluYd499ePBmfIaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAv23EigMyMeFPCC1zxdHk+1829vv4YHsrXH/ 6uJZM+OY6XEVfT X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="70958368" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqgWM9yu8Q2GqfHRd3FXEnksF5LkqRWHEV6jC/1ZvbHNa9kf/FluyQdqKSLN+himCfG1JVGhSl47inL8J282WB9fvHUtPNRHWBCPNq9fqCPy40cPnmUxwY6aEeuZVLicjCZa2Zovfs5SlTS99/CXJWV8eSmEvuQsEnuj5fOLH8xYlFvL2qT26hYmhuW6JLhlhbEA44grpZ6hn26AVY1FDGB5n+uI6pwX24iHTei1TgBuXAWRFshhXhf8o08dlIDK04G8mYsJknPrVgxRixTF9rg0PRXf7H+jrE/obBn7TTNjh65W3qk1wTiY37BTkVE4QwCG8Q2FsWCBIDzkuUMgbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kr8WqZ1XN6M2i3dml6O22rlME34Dkh62jD+RCBBQlVw=; b=XGWGqR77YubtC1wQOIWFGdikz4bUcEYdnYhXNlQgl2V3amQLv5kc4n945zyPVYFxPrxMnGGAr2gcSqMiS2NqBkRUiCTqxHk3C2R3tr5ZIMb8q+xQWs6EPOGyM6F4vi5X2F+i7n+xCtOWpRYpqMFZeQKIokOPgg+IRRVcN0kkygw/VqgkP8IdZJ3Iru13m58aVEyIZgVHzAqh1Pl/ejeXQzCB68ylocUr3Z1Q2SgIaObjD6llvDAFrIDprEN1GDq3IdBZNurYSwcWfWvO2pMKH94hVXjxyB5KfHxyGMUSrlM6bh1AKq/KbF+GUbehVvqDm6AhZuDp5gSejN7Vv2Z9vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kr8WqZ1XN6M2i3dml6O22rlME34Dkh62jD+RCBBQlVw=; b=eTreDGU4g/KPnJSv0g8PQ5srDjhqhCjMr8Rfi910dhMXRT4/bHUP1Aa4pf+xke8Q/N+5RlwoB1z4A9lquD1Mw6D78/liIjJ0Ob5/iT2+zvAiTqSO2BGD3Vqfnn1ivEUGmRudVFI/BuNLh1cQOiAJZ7/Q/1AIJ4AYGe7ST5HnFR8= From: Andrew Cooper To: Luca Fancellu CC: Edwin Torok , Xen-devel , Christian Lindig Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYkF2Fwt7YEY0iLRkyR5qKZ760kZYcAgAAF1QCAAATZgIAAEdyA Date: Wed, 18 May 2022 11:34:07 +0000 Message-ID: References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> <107B2C8E-59DF-4D7B-A6E1-E136E702AB96@arm.com> In-Reply-To: <107B2C8E-59DF-4D7B-A6E1-E136E702AB96@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19063613-34f3-4f75-26f2-08da38c25224 x-ms-traffictypediagnostic: CY4PR03MB3078:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g8kryGNRi6YYoIHaSznDnnK9KgnM9rtd9rbiTYsnBMm/wwhwM9oLRMUNEibiBe7sFr54E0il0v+5qkpz4GkT99Jzf6VgDmwr1NGy6DIxBurCz2oXbnbLWf+3vF4c15Bd+MMM8J+YxiaZQ01pfs/1UvoV9GKDx6cz6Y3xeVI51rEaDtOMESI/i88xLdqIgOYvS+TwVY+lyXUV2/dzq7/phkAw7437J64rQsD5oJ8L+B92x6UPaloSEfcJXswEiCPi+EY8/uNJIOm/iJJECNd1tTAc4dU/i9FoMJzUM7yJL8V/7fqPk1MM0dm+FzIwyQaAFv0PgPlBZARn5m9RBrB3RK0S316326e4ZR5pPSttkDeO3IUcWlQtjfbPZ+ZfrcrGn5yxW88QI9E6eQlmIxT3WWexsdE4owHsWNICylOrfNdTAagKq5lkCeGzvlA5DR96O/DKUhTlkMqwXJDzacVk2VIG1F//4C7RBtq3GLPJO6vlzhmkq4NFrRZCZ8MiNZmIrFQ8mgNA7rkahByU5i7lavE3zspwtHUpMD7cSmm2plThgWeZvxUkHc538QYDHV6KnhaGZEqftgPcB1QJyo7bqYdwHo9Xz52zRoeZrDoqOiPCrsji04sMeknNClN8p7u5ZhQNOG/yGmN7kOEhuNqcHUmdALKgWPSS4BPugAEru3ItKm/cCenrbVUckOY37oHiIuFVY/mMwWWp3wQk8AOfANXRuPBWkucHcAFBgiIdontT9kGqPvGmsLMmL0PuoCQENZZqKnkXHt/DmLUWHOqddQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(91956017)(4326008)(186003)(316002)(54906003)(66446008)(66556008)(64756008)(6512007)(66476007)(2616005)(66946007)(76116006)(31686004)(6916009)(36756003)(26005)(55236004)(53546011)(107886003)(71200400001)(6486002)(31696002)(6506007)(38070700005)(38100700002)(8936002)(5660300002)(86362001)(122000001)(2906002)(508600001)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVBuc3J4eDdUQnhCaWRvdDVneEx2elhxdTFZWnA4LzBKeVJzNzlrYy91UW40?= =?utf-8?B?MytBZnBRV1JSbE1OcjM2c25kYnFzNWZMM2g4NTVlZit2bEVVUGFoWFF0ekRi?= =?utf-8?B?RzdaQ0VxTDMwZ3NYU3cxdUFzUlZEczJSUDhuTHFmbU9lL0dtTXduQ0ljT01i?= =?utf-8?B?RXdXdG8zbGVQS01IcWVOMHo1RTBIdHFob2x3a3htV3hYOEZ6cXZScStoTHJq?= =?utf-8?B?OU41SzBSSElidXc1a3JxRnZNR0E5UkxPeGIzSjJSR2dXOGQ3d1B6bjRIMGxh?= =?utf-8?B?TGFVQVV0ZndCQ01leEsyR1Y2ODJ6Y1hoWUs4TzFMQ3lwNS9tNTIwazNVdkpZ?= =?utf-8?B?VHBnUlREbkxGbnVBM1JReFlYY0RVRjQvK2RrY3VzNnNvNW1NYnRMQkJLc3p2?= =?utf-8?B?MG5rZmpzcGNTbEN3b3dJUzRGTUhUa2Y0VkNiRnMvRHl3bTZna0FBUjdiLzVy?= =?utf-8?B?SFBvSHdYMjBzYVozYXJoVXVxQ29qdGVVYU1nMERJTzB3ZWMwMkx5UjdsbDFF?= =?utf-8?B?NTZkV3JVSldCK2FHd21JUkZDVjRMMXNQSkx6OWk4NjhSTmtBYlJnS1lUVDAv?= =?utf-8?B?eXlMcjhkZlVxRzdKOU5pNzFnbUpPaEx6R3VzNm41TU1wTVFscXJ3ODVuUmQ3?= =?utf-8?B?aVd0VkswZjBWdC9ma205SG8yL1h0Y2x2K1Vja0k5QkprRVJWYkUvYVJGYnBP?= =?utf-8?B?enNHbUVvRkFmbUZpdWI4VTFTcXo0dXhjbHJOdVlaU3hPS21hU0RlK0VSQ1E3?= =?utf-8?B?cU1YQVdOVTB5KzBpWDk5YTZPRW9UWWJaLzJGWUtOK1NPWjE5TFRSWS9HaXpU?= =?utf-8?B?RmxoTExweFZSVmpPTVBtWGNOekZtbEJVOEM2Tm96WnExc24vK3NOR2dSV1VW?= =?utf-8?B?cGYxcHpGRmlBNHZIM0Qxekt6d1kvTDBNVmhlY3lXTy8rbVcrOGxKcThkdnhy?= =?utf-8?B?S3F5MU0ySHJDcERVNVBSaWZHRk9NZmlnR2hsMFdRc1FWb3VTdG0yN2NJR0RD?= =?utf-8?B?dEJZTEV3OWphdWo1Ris0SWNuLzF1K0U4Z0l0dWt5cE95WjJEdnFRRTEreUc5?= =?utf-8?B?cU5GdytMRjFIQldRSFJ6bnppUGNkTjBZZ2ZQeUdVOGZNM25MdURjY3pJZFM5?= =?utf-8?B?R1YweGViQ0pxNGs2TkQ2SkZ1WWdIR2FvQkFPVitSdUVLZDlEZ3B4akJ3Szlq?= =?utf-8?B?WExaTWtTYzJFcGZ5MFVRZG1CaHp6K3B0Y3pzcEROWEYvdDBzdllVam54L2FE?= =?utf-8?B?TXRVd04yalUyR0QzQVBWbGlZSXBOS3ZjWFhrNzZMNlV4U0trdUNlSWROdldz?= =?utf-8?B?VXM2NERmbWpxV25EQWMwS1M0MWxCM1oyaTVPQi85dnByRGlwWVJDUWxySkFV?= =?utf-8?B?MkZySnJXRnZvZmpjV25BS1R1amc0RGdxNERLZnk0aDNVOXhIV0w0SzNDQnVs?= =?utf-8?B?UHhvZ3ZvUExUdlVIcnovZVdhMzJKMmlQa3FoY09wMzg1eDlEeHlvRGsxTUF4?= =?utf-8?B?b3pQczFUM1NKenR4Um1JUlZQOE9NeDJ5YWpnd2h4YVF1Z2VGdHRCRktTNFd5?= =?utf-8?B?ODhPWmV4K1FYb2R6Qnh5SmY2UWJsbW1qUXVtNjRYQVN0cEhidHp1R1BYbEJs?= =?utf-8?B?Z2VkK3pzYjZjeXBGZ2hQMHgyMFYycVhPZjRFcTVXNTQwVWx4ajZ4Qzk2NHdW?= =?utf-8?B?cFhNbUhUZmx6Q1dLbGtNaThiaytuMUZGSEo3OXNnTWpWdzR3VnF5aDFkYUda?= =?utf-8?B?SmczWWhTb0V1V2FLY0dnZEg3R0M3eEZiSGE4alpoa3c3Z3NGVXBkbG5aNm4z?= =?utf-8?B?NlV4Z1NrbzdtNnZaZFYwWmplT2YxbnRqRVdWZDluT2JwWWUzaUlPazNRNEVE?= =?utf-8?B?SXRBN0wvQlF1NXNycVZnWlRyZDZFR1pIN0xVendVdXBjUVRJaUhUSWtkM1A3?= =?utf-8?B?RzRyeWVybjVKZzlhVFFDN1Q4b0NqOVFrU2JiejV5VFQ4RlMyNDJQSjBwa2Zv?= =?utf-8?B?dmFZWTgwMEtHTElSb2R3M1FhNWNwQVVGZEFhMS9aMDdNMHpWTGRRbHpXY2Ir?= =?utf-8?B?ME1odmtsUzkvekxoRnRYMjhISEpsREd3M0wxMTVycmxJM20yKzlyRDZwekpu?= =?utf-8?B?TzlDeExCcHMxYUQ0dElCbjlhc0ZaUTVEQU0yRDluYU16bGR1SWJGTjl3YnFt?= =?utf-8?B?NDVZL1JUb3M1L1VwSUxKZ1ZwdCtIY3lDR0VJWmNrUVZ0NHhDbmNXNzkySGNO?= =?utf-8?B?cHlwdWVaMnoybFB6WEd1SEdGUG1GbTVabFBaaSs5aTZ1dTNZN01ZOVJqSVJG?= =?utf-8?B?eWdPaHBDTmlpQXQ4ZTQzWjBBWmZnY3hsUEo4Y0FHMHJwdkZCUkpuUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <3F1A8348B8B5E049A1E435928D9D5C86@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19063613-34f3-4f75-26f2-08da38c25224 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 11:34:07.8789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fznrF875zVSTHwRu0IhTWV1m2klPdOPwBS+xRwZ+VWtoc8/+g6/1woY3qSYR9Z6CBqHb21yKvxD84WIpYnKYXKGzSo/PrllhoD8IlPWeGAk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3078 T24gMTgvMDUvMjAyMiAxMTozMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+IE9uIDE4IE1heSAy MDIyLCBhdCAxMToxMiwgQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4g d3JvdGU6DQo+Pg0KPj4gT24gMTgvMDUvMjAyMiAxMDo1MSwgRWR3aW4gVG9yb2sgd3JvdGU6DQo+ Pj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwgYi90b29scy9v Y2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+Pj4gaW5kZXggNzUwMzAzMWQ4ZjYxLi44ZWFiNmY2 MGViMTQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0K Pj4+PiArKysgYi90b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwNCj4+Pj4gQEAgLTg1LDYg Kzg1LDcgQEAgdHlwZSBkb21jdGxfY3JlYXRlX2NvbmZpZyA9DQo+Pj4+IAltYXhfZ3JhbnRfZnJh bWVzOiBpbnQ7DQo+Pj4+IAltYXhfbWFwdHJhY2tfZnJhbWVzOiBpbnQ7DQo+Pj4+IAltYXhfZ3Jh bnRfdmVyc2lvbjogaW50Ow0KPj4+PiArCWNwdXBvb2xfaWQ6IGludDMyOw0KPj4+IFdoYXQgYXJl IHRoZSB2YWxpZCB2YWx1ZXMgZm9yIGEgQ1BVIHBvb2wgaWQsIGluIHBhcnRpY3VsYXIgd2hhdCB2 YWx1ZSBzaG91bGQgYmUgcGFzc2VkIGhlcmUgdG8gZ2V0IGJhY2sgdGhlIGJlaGF2aW91ciBwcmlv ciB0byB0aGVzZSBjaGFuZ2VzIGluIFhlbj8NCj4+PiAoaS5lLiB3b3VsZCBpdCBiZSBjcHUgcG9v bCBpZCAwIG9yIC0xIGlmIGNwdSBwb29scyBhcmVuJ3Qgb3RoZXJ3aXNlIGV4cGxpY2l0bHkgY29u ZmlndXJlZCBvbiB0aGUgc3lzdGVtKQ0KPj4gY3B1cG9vbHMgYXJlIGEgbm9uLW9wdGlvbmFsIGNv bnN0cnVjdCBpbiBYZW4uDQo+Pg0KPj4gQnkgZGVmYXVsdCwgb25lIGNwdXBvb2wgZXhpc3RzLCB3 aXRoIHRoZSBpZCAwLCB1c2luZyB0aGUgZGVmYXVsdA0KPj4gc2NoZWR1bGVyIGNvdmVyaW5nIGFs bCBwQ1BVcywgYW5kIGRvbTAgaXMgY29uc3RydWN0ZWQgaW4gdGhpcyBjcHVwb29sLg0KPj4NCj4+ IFBhc3NpbmcgMCBoZXJlIGlzIHRoZSBiYWNrd2FyZHMgY29tcGF0aWJsZSBvcHRpb24uDQo+Pg0K Pj4gQW5kIG9uIHRoYXQgbm90ZSwgTHVjYSwgeW91IG91Z2h0IHRvIHBhdGNoIHhsL2xpYnhsIHRv IGFwcGx5IHRoZSBwb29sPQ0KPj4gc2V0dGluZyBkaXJlY3RseSBkdXJpbmcgZG9tYWluIGNyZWF0 ZSwgcmF0aGVyIHRoYW4gZGVwZW5kaW5nIG9uIGNwdXBvb2wNCj4+IDAgZXhpc3RpbmcgYW5kIG1v dmluZyB0aGUgZG9tYWluIGxhdGVyLg0KPiBJcyBpdCBhbiBlbmhhbmNlbWVudCBvciBhIGJ1ZyBm aXg/DQoNClRoaXMgaXNuJ3QgYSBiaW5hcnkgb3B0aW9uLg0KDQpZb3VyIHNlcmllcyBhZGRlZCBh biBvcHRpbWlzYXRpb24gdG8gRE9NQ1RMX2NyZWF0ZWRvbWFpbiwgdGhlbiBkaWRuJ3QNCmFkanVz dCBsaWJ4bCB0byB1c2UgdGhlIG9wdGltaXNhdGlvbiAod2hpY2ggd291bGQgaGF2ZSByZWR1Y2Vk IHRoZQ0KbnVtYmVyIG9mIGh5cGVyY2FsbHMgdG8gY3JlYXRlIHRoZSBkb21haW4sIGFuZCByZWR1 Y2UgdGhlIG51bWJlciBvZg0KZHluYW1pYyBtZW1vcnkgYWxsb2NhdGlvbnMgaW4gdGhlIGh5cGVy dmlzb3IuwqAgTWFyZ2luYWwsIGNlcnRhaW5seSwgYnV0DQpjbGVhcmx5IGEgbmljZS10by1oYXZl KS4NCg0KVGhlcmVmb3JlLCB5b3UgY3JlYXRlZCB0ZWNobmljYWwgZGVidCwgd2hpY2ggaXMgb3B0 aW9uIDMuDQoNCkJ5IGRlZmF1bHQsIGFzIHRoZSBjb250cmlidXRvciwgeW91IGFyZSBleHBlY3Rl ZCB0byBhZGRyZXNzIHRoZQ0KdGVjaG5pY2FsIGRlYnQsIGJlY2F1c2UgaXQgaXMgYW4gaW1wb3J0 YW50IGRpZmZlcmVuY2UgYmV0d2VlbiBoYWNraW5nIGENCmZlYXR1cmUgdXAgZm9yIHlvdXJzZWxm LCBhbmQgaW50ZWdyYXRpbmcgdGhlIGZlYXR1cmUgbmljZWx5IGZvciBldmVyeW9uZS4NCg0KWW91 IGNhbiBvZiBjb3Vyc2UgbmVnb3RpYXRlIHdpdGggdGhlIHRvb2xzIG1haW50YWluZXIgdG8gc2Vl IGlmIHRoZXkNCmNhcmUsIGFuZCByaWdodCBub3cgdGhhdCdzIGEgYml0IGRpZmZpY3VsdC7CoCBJ dCdzIHF1aXRlIHBvc3NpYmxlIHRoYXQNCm5vb25lIG90aGVyIHRoYW4gbWUgY2FyZXMsIGFuZCBJ J20gbm90IGxpYnhsIG1haW50YWluZXIuDQoNCkVpdGhlciB5b3UgbmVlZCB0byBwYXkgb2ZmIHRo ZSB0ZWNobmljYWwgZGVidCwgb3Igc29tZW9uZSBlbHNlIHdpbGwgaGF2ZQ0KdG8uwqAgU29tZW9u ZSBlbHNlIGlzIGdvaW5nIHRvIGhhdmUgdG8gc3RhcnQgd2l0aCBkaWdnaW5nIGludG8gc291cmNl DQpoaXN0b3J5LCB3aGljaCBtZWFucyBpdCdzIG1vcmUgZXhwZW5zaXZlIHRoYW4geW91IGRvaW5n IGl0IG5vdy4NCg0KQXQgYW4gYWJzb2x1dGUgbWluaW11bSwgeW91IG5lZWQgdG8gYmUgYXdhcmUg b2Ygd2hlcmUvd2hlbiB5b3UgYXJlDQpjcmVhdGluZyB0ZWNobmljYWwgZGVidC4NCg0KPiAgRnJv bSB3aGF0IEkga25vdywgcGxlYXNlIGNvcnJlY3QgbWUgaWYgSeKAmW0gd3JvbmcsIGNwdXBvb2ww DQo+IElzIGFsd2F5cyBwcmVzZW50LCBzbyB0aGVyZSB3b27igJl0IGJlIHByb2JsZW0gb24gYXNz dW1pbmcgaXRzIGV4aXN0ZW5jZQ0KDQpGcm9tIHdoYXQgSSBjYW4gc2VlLCB5b3VyIHNlcmllcyBo YXMgcmVkdWNlZCB0aGUgbWFnaWMgaW52b2x2ZWQgd2l0aA0KY3B1cG9vbDAsIHdoaWNoIGlzIGdv b2QuDQoNCkJ1dCB0aGUgZmFjdCB0aGF0IGl0IHN0aWxsIGhhcyBtYWdpYyBwcm9wZXJ0aWVzIGlz IHN0aWxsIHRlY2huaWNhbCBkZWJ0DQp0aGF0IHNvbWVvbmUgaXMgZ29pbmcgdG8gaGF2ZSB0byBw YXkgb2ZmIGV2ZW50dWFsbHkuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed May 18 11:39:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 11:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332044.555683 (Exim 4.92) (envelope-from ) id 1nrI1H-00062h-En; Wed, 18 May 2022 11:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332044.555683; Wed, 18 May 2022 11:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrI1H-00062a-Bu; Wed, 18 May 2022 11:39:11 +0000 Received: by outflank-mailman (input) for mailman id 332044; Wed, 18 May 2022 11:39:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrI1F-00062U-Bq for xen-devel@lists.xenproject.org; Wed, 18 May 2022 11:39:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20b8ee29-d69f-11ec-837e-e5687231ffcc; Wed, 18 May 2022 13:39:08 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-cohQZRBqOzeE9PeN1wVS4A-1; Wed, 18 May 2022 13:39:06 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7634.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 11:39:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 11:39:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20b8ee29-d69f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652873947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xdyt7VXZgVdxcKH0N0AKRiKVoVy1tV7Pb639WALY7Rg=; b=ZjYa1BjhTfS8W1gWLbQgWbrSzTp7rP1SANAigoqaJSmuKCoe65R/27X/Wfe4eXgm6D1aDH BoqfT0mUpuCJ1v57qM2CqGgqKN18UPWBRKerKxksjB0hWp2rSIyjO5NSFenWCnE12An9TJ HuRbnYhJhjQrFecBOWQe+sgd7jpvHC0= X-MC-Unique: cohQZRBqOzeE9PeN1wVS4A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSR267e/49cLFTRg2yx3eukQMK2ZNphC04AeEnXivQIMNvBzF2Q2TMAUXqOUtUblMAGTbVgVsRkcHO2P0ZeQqYkRhfrvHLH45w6WvoHfBc9Z0XnaVj/JhxyPf6k9oGuySJGDT2QBAvSkOTkZYjUo33MbblQTj9mzBtGaJmz1xxtz5YK6/QqO3HKJHROGCahAGR5B/p5FLOawX9tak6yxi9ihPMMQqkiYTf1H22J/InVfuycjSOUg4T8ZErNBWjskwuOQilMEeyjW8IeNkpWMg3nsgVGVZmY5ytfNgkj94N7YWo2kNbEv2qVgjoaaUYcGoEsIt7SMIt69ckoLnFA+4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kn2ZofV4HJ/GMwAnBn02Iq3rnuCRMchLnpkXWNfy4P8=; b=Zb/kycdwLV69iem1+k771CLGZlKpvAoHyiPgoXzjaWYYwUeU3ZmM1pxoJemNIlkbNxmoSUHtfjgKyqxc/2nlo8AJ+ypJBHhXv/J/9xk6a7lKrerASmLabbCiAPYIrx+n44dbQm7fbAsf+YWS9sSv/8pO7abIQHVtsYyEjQaB6xVETHqs7dloyzFHvG3VXn4g4RgeN6XT1euZ1yBdQw5Tj+rFycamDKZEQlz0EVYyqsdcftdd0H18lF/AEy7voAVWIAXrXhdJ/wHCjSk2dH1OvXfuuJp+AFho85epnw5XJarQwopUIc9IXy593D36RdkdVehPD93RI+pkU2bc22u3Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 13:39:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 19/21] IOMMU/x86: add perf counters for page table splitting / coalescing Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0724.eurprd06.prod.outlook.com (2603:10a6:20b:487::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5036768-9913-46fb-deeb-08da38c302ee X-MS-TrafficTypeDiagnostic: AM9PR04MB7634:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6YcfPm6pDzKORy7S+g20BkCo9rScs1JfUumjMnFOf2C8TWDhwzZm5A+fuannAxdFSJjrGb3BaBIAwsejemny5IRci1wqvJa6/3PYVqIjiAEowCfh6gfu284+kRjfgUxFdQVzp4G//SL5xsKMZMrNuLohWMWvoB0SDUW/xX3BF6uH7Rew7f3JZyVlRVrNMfwVo364Wgkw3n+SfWf/K85oexrdcoEdwbdC1SGvlzFl0ToqXGLiCxo4Iq3f0fnWEFjQ+yJlx6Hacn8r6NudJKZxcaf1g28Ah7hwnoUTy1j5TNQ7KDW56rSkI3evUxFaYOaRmB+jSXJXz1ZnqAuZd3yc5fvzuVrxlsrSR47ybMOKmXZTp9vuyAOhVGabw2YdF92EgLsM1z7Amae/aZA+xtPzeLEF1mDPFVxgyxQbXBi1rfRaTDnReA6qet0Y0a4/TR1vlxPydzli5qco57BXkpSA0/+6LcwkNNCIiysnUCbUt/98cTv+SEhPRSSTnlrsfcGqnouAOIsWjnHsCnNQpugM6v5A850CfipofOJ/hbleiSkoxVULO0Hiuj7KrkwjM04zHe40P0sDjP9ziKV2NpXFl2R6nR42igFh7B3ykdCAbSy8jcHnq3tr63YTMBhBL3Y9oTCjKPf+H+3vqmxji/EdsKkE7bJn1cGRRkGnHd1jK+mcELUBJA/uRVrr5DDFXEddpjDVMxu0EyTZwVazYTKykhRdN9p7pxp8nt2lWQMnfUQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(31686004)(53546011)(66556008)(508600001)(6486002)(6506007)(38100700002)(6512007)(36756003)(8676002)(4326008)(54906003)(316002)(6916009)(26005)(2906002)(8936002)(86362001)(186003)(2616005)(31696002)(5660300002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wg94gziotFCXGBR5WpdDC251o+I55eJV/6HYJIFuTsfM38I6Hba01Fjxdiz7?= =?us-ascii?Q?YC4GU7NIYYgp4Iw3935sq4ORQQdlzjBkCCd3C0dcFjTXaS9kVrkZA7SHq1Ml?= =?us-ascii?Q?1kUVh+dUVBbZZLopukd+rTfK3/QNrqOcc4QS89E4ti47n371gSr5LpFFHYLD?= =?us-ascii?Q?4DuKGHkMIrJecUiJyOLimHsqBDS7bhbcVbXjx318lCGy96NQk72QNAC1CwgW?= =?us-ascii?Q?SUcVOm1PDMUEIa+gdEXoeHIzdhJOAtYU1mvUjrd3Kzd4GXOd6h8rAfWqx7IB?= =?us-ascii?Q?4opmS9mUT8lyXSOwF/TaRz2/YMlVpSI6/Ze3KOkKPzPO/mC5Flzl389V3FLY?= =?us-ascii?Q?fH6J+LKyQqPlPjcGda1unJ8mJWDre/ZIQvnlN5fqZhHFQqgn76XCNHqN88mw?= =?us-ascii?Q?0RF7wijzANxvad1QemzbBEwctqEJEqHk/aSpgMTJrbLq8hIrBiKWWjAnWe2p?= =?us-ascii?Q?TmXtA++1v1mBWFJzv1juOWA3ce8lZKO6yeEXFCrSBbPpywH9dS5FWo7AKjqO?= =?us-ascii?Q?iLNC1dZs5ZSj6/0S0MBoqVMNYfm7MFhINfYo7s1+DIE5NGwN6MjxGdvlRRcw?= =?us-ascii?Q?OfjEsZs5HyAmAQ149r3Jip/ojk/Yfr2aYbHxYR/0Swt2kKgw/JTspRGNMckF?= =?us-ascii?Q?bepmt/w0RVGfMBue1t1Rj6uAfLtLflLP5bA7PTtyrwTMqYTPbVtNiQWZ3ke4?= =?us-ascii?Q?s6ec6CrFHNX6Dnt4kYNI94hZypFafXHMuCM3Nl/84tBjiR0CrVjVaygCsV30?= =?us-ascii?Q?vEuhUSKsblmrqyzeUuoMgdD0qpoBfzMUx1GT2EaGDDZbkQcWqiNc+jpbcvbD?= =?us-ascii?Q?djd5SJqp9YHkEkzCYXqx8h8yHQsVs88mAuSsJIu/2Kex6NIv6NjXZmJSXwoF?= =?us-ascii?Q?XWsczQXziroilmM5SBUnDdobiRJwt618lkCDBycJlVDKZijJA4RLcpcR6KTL?= =?us-ascii?Q?CBdtpSM4+fjylKn6naps8XosiERotu2V19ssALdQCOThB+j5ypZY+aIEPSYO?= =?us-ascii?Q?Xo+lwySEs+Y8hKR75oNMngIAkg33V5XBJ4oFUBEi2gb86OZC0c6+gLRVFRwt?= =?us-ascii?Q?9OEPO0iwxcyEDczZT/wCrtjFddYYb1BC+ZO8ZrH6VZxx7YOHXmXNzFrHKPyC?= =?us-ascii?Q?vXH5lNEdVaQYSysvthN4kWC0QSN3d1QMfo0LFMHYu6FWL1HMsYNQ6PEQ5YKx?= =?us-ascii?Q?RWZh17a/VJ+v8rHfyxM4hHF2fci1k7zRLcRDfOKKH3W6pKdcBhFLqLT6KKI+?= =?us-ascii?Q?kCkrTOV3kimkg4CwoSQFKlnyP4lZWr2k9mxfRbk25/Jaj4bYr9oMR86AYwo3?= =?us-ascii?Q?0nlZZeNyGZL41fbwC7ganRlTLbloAJ/ZKkt/gBMVGemxi2wfk7FCSouVD32t?= =?us-ascii?Q?pooruUjKt84F6xohdj84nqy279rstoTgQP74rcxNqqtMgw3c4o0WKoQzwt7n?= =?us-ascii?Q?J61Iezs9Aek2slCKTOtKPms4l2xRFTEaMLXX4cURWxBSnmAglMR+jeoaWdbo?= =?us-ascii?Q?MrmFFfAobmWTdYWJclEjnNxQ0ujL/IB9Kub/MN/Ztj4yQVk8StAxk4YL9fX2?= =?us-ascii?Q?Ye9bEMLzjfDL0oJblVTsq2kUjmLPRcLsm5h/6NA0m34Rsd4uuJ99WabQzerj?= =?us-ascii?Q?UvwLcKo9+pRXm/L4t3rLIFD+iYslTtJQGEoFqrk6bRnMcrmWOSFhvFvlf2MZ?= =?us-ascii?Q?vGq6rR9RYMgOC24ocvMAAjeGnsgbn07yk8NH/qRyVJAEQ8diNklDO3eN4Aau?= =?us-ascii?Q?dlweu7skIg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5036768-9913-46fb-deeb-08da38c302ee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 11:39:04.7521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: upmh98E2p9du/rLZzftKZuOv35G7ChSYcs5VHDTDHEiSTCmNjkP/W1jlcOmNI6t2ZZX6rIFkITx/NN9f8ZqJ2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7634 On 11.05.2022 15:48, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:44:11AM +0200, Jan Beulich wrote: >> Signed-off-by: Jan Beulich >> Reviewed-by: Kevin tian >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. > Would be helpful to also have those per-guest I think. Perhaps, but we don't have per-guest counter infrastructure, do we? Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 12:16:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 12:16:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332063.555699 (Exim 4.92) (envelope-from ) id 1nrIaw-0002HC-Jz; Wed, 18 May 2022 12:16:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332063.555699; Wed, 18 May 2022 12:16:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrIaw-0002H5-Ff; Wed, 18 May 2022 12:16:02 +0000 Received: by outflank-mailman (input) for mailman id 332063; Wed, 18 May 2022 12:16:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrIav-0002Gv-2u; Wed, 18 May 2022 12:16:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrIau-000454-WF; Wed, 18 May 2022 12:16:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrIau-0001RH-HS; Wed, 18 May 2022 12:16:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrIau-0005lZ-H0; Wed, 18 May 2022 12:16:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PjcCJLMN/zJc11EZB8YhNthqOv6sPHwhu7dkSaFKoK8=; b=0MgFN1QLxge9yCRE9wCZPmHwSb u1DWJKbKJqk7h9HwrybZ/eRMTZ5bEf788izHMSG/a4CwJNhSg+zpJ49nbHZR4xcaC9uVQOkybJeEW 2ft/DtEImlLN/hGP/KRQjZY1lOQQLUHjhZbLsyCzl1EXkHJb4oYdR/yfeggzyaY0zBkg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170536: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 12:16:00 +0000 flight 170536 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170536/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1082 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 101 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 12:50:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 12:50:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332081.555713 (Exim 4.92) (envelope-from ) id 1nrJ8b-0006eM-Dk; Wed, 18 May 2022 12:50:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332081.555713; Wed, 18 May 2022 12:50:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJ8b-0006eF-Ay; Wed, 18 May 2022 12:50:49 +0000 Received: by outflank-mailman (input) for mailman id 332081; Wed, 18 May 2022 12:50:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJ8a-0006e9-5z for xen-devel@lists.xenproject.org; Wed, 18 May 2022 12:50:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22964def-d6a9-11ec-837e-e5687231ffcc; Wed, 18 May 2022 14:50:46 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-5-7jHIjs0mOpmpv1gRDrWnaQ-1; Wed, 18 May 2022 14:50:44 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5586.eurprd04.prod.outlook.com (2603:10a6:208:130::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 12:50:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 12:50:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22964def-d6a9-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652878245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ic6/eTvCTW/0g/PAsNimNgU6P/eHxUeDUpX/a4wa9MQ=; b=Qrr3m3M184+iSYLRDXGNOtNwR75PWKRAOFJYD2M6+TMa8EvXP8saP8ZhA4fsCD19zKGhUt s6AljP7ewcTJNnrkjGDNByUx3fgnIDyQu38gkvI9hjqg+ikOC30YFKfgRtBivrZVopu73z asaE+0fOGBDg658WJ734w9XY2iQUpus= X-MC-Unique: 7jHIjs0mOpmpv1gRDrWnaQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfE+XKqoce/4hU0AFtvpGPdqyDenEqlMP23tERllAb8btlxuGjS0ns+low1p20sh6q2tDVWhsV68EDqvOly5bvoinplLd6YItWl8LG4hJJGGgNDM9gI4psIJ44dyb0Uio1GhNlmMDP7ZKN210C3J8jm1owM/OgAGVJNJBf3+UIPQzeSbrDnlEdTqLvJUgkXqlVXKlbT6ZfXNP38g6P87LWdbAyVT3DxIEmshVcVdcx7gQKVPvigZVQ8GjNQvizrMiYVl6Y9tqR8YSGQcCN9KYS1VXea7pCvgtAXcfvq3SBNXUJGoq4ItxmNhAXeo4Ye/QbJ1WOL4H4muDmqGhwdVlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ic6/eTvCTW/0g/PAsNimNgU6P/eHxUeDUpX/a4wa9MQ=; b=fonSPmuXWTsAyc2US3HBKihup8rKqWSaeEZ46W6ptAHRdhieXCDGXagRCSvePwjYkzROXo8A0rbL5Rmed4BJlq102JT+azRkNjNmy7SGTey7SBh/9tQsZdxfmzjyYgsyx1I979oVfzzSaTpyZADfYrW2kInS7J4vfkzcres6DbPZ5yJZ/TQzGeAouuUtnks0biM+euWB3x9ETguZhzCiXJtZW+I79DljLC74PknvS7qZnRczdTVFEfSMBAfxb8tLJZJC8aLaXMPMvTeFhC309lRycj3/NgPfN0F/MSPO26rijwCzsu9kZNRChtw3qfxMne0C8AeBz0BE/hwXxIEk2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 14:50:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 00/21] IOMMU: superpage support when not sharing pagetables Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P251CA0006.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26242a17-d2e5-4cdd-1a72-08da38cd037f X-MS-TrafficTypeDiagnostic: AM0PR04MB5586:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dM+SqGMFyGNJ/o6VS112Egsonvu3Jtvzq2bR5cLQu7B/eAjMR545vzJzXY3ofvt5GPKMTJ+vUrv0WbduIN1C5cyi/0RV8ll6r67VOfSCMDmES8tXml7XM5vkXlz2DX7J/ju0I2Atq+57lvh1tVSK9KMr5utoOEXoOQxOXdNkDsBkltdG+GbboP06K8eo+XRiqmET0/PIiOayvARyKQYy+YcIz+KDmPg+snJ/hyDyi29y69Ua49JrM0o7+bgZcEVyj5S+W3ow3gbWOtghlpvxKhZ5lNw0UvZ40nW8WTMBw/GLuJ5Q+VlUS1NOaUXrKjH5Or+ViFMwzlK7wfyqNaeiioDHdiq5s6aE9KHHw7ypZ08asVmHD5QwEWVnCHrIerFtQ+2lOgpcEhFOA33YXkFvw2gfWZHcSFhd0VvTkqfxMX9CBYjA9qACDxjY9LRmGwLHIvM4O25dymJITvKacITY5hi8h/5Bi7wLkR2OiHklfe/aD4Lpb7kHtIyfe4COK3h582L83aiSd3xJ4+dR2zLdHmaN67aEeutPmXk1kwqBA6J0PsyE/AHikI8rEy4qDb5lEH0WUf57yjTtE8fvAb+UR5VKSUDPTdbxM0EUlLlGaYIH7nj1KZIYYwUaVhSM1hDwXNQ3InpIUVDQaED4qTSNmDF7Ca7rdMUom2Q2bLlJPSPDPUNpONL0gNKFfGW+AGS2MAyi6k37gds9uXftYmbtTMHr2hmkiV6irGJNCdMywhyZvgH1fQ4Yens3ygqUCb7XruT4aW0XH5MOPea+5+iudOUik+bbnglRCXinwY/beM7aZsjRVN8NErJbWc3BfFLvznl1t2ZfNKRi0CbkL+pK4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(83380400001)(5660300002)(316002)(4326008)(54906003)(6916009)(66946007)(66556008)(66476007)(31696002)(31686004)(8676002)(36756003)(6486002)(966005)(508600001)(8936002)(6512007)(2906002)(186003)(26005)(53546011)(6506007)(38100700002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXhqeGVDNXVNeklTaHUrZkVPV0lEbmJkMnUzMVdWRXcxTUNFa1hJTVU4dVB5?= =?utf-8?B?T29OM3ZNakxxZG1tanN5MDI1eVdnYkhybEM1WTAyUHhubVo4SFY2aXBzT0ZK?= =?utf-8?B?ekpROWRvWFltK1dWYkMxUEhVQlkvTllQTE43U3F2eXUwalkxMURwby9pMUE5?= =?utf-8?B?UTNlRm04RndFcHoyOHlFSzFVbURQZ0xJR3JBdSt4b1kzNUZPeE4rZnJRQ0NV?= =?utf-8?B?cEtYUnRyUGI4K2ViYnphK1RHN2FjYWRjQldxVlJwUEhJZFcybkkrbmhVVEV0?= =?utf-8?B?VDZsd2kxOS90ZXMzckRjdTNOSTR5U2lRQW5JU091K0JnUDFERWg1NlM4OHFU?= =?utf-8?B?V2J1U3ZKaEZvM21tQ2FBRVhZeDFpRWNnWDNUMU85dUFZY0Q0KzJjOC9vY0Fv?= =?utf-8?B?VWI2OUhBTmlPUFpQU1pVMzZsSG5JaUozNzlrY2E2VVprN1JOU05hT3A4SmUz?= =?utf-8?B?K25uYnB2YSsxRWRqVkY2RHNOMXZjSmQ0RnNkem02WktNUVVZaHkyTVRVc2dK?= =?utf-8?B?aFhRcGFqVjNHY2FzbzlkUnNkbzAyZlBvNEJrdHR6bmg5SkZKRHQyT2pFd3Rx?= =?utf-8?B?RnFUZEhEUnFiRnpUMCtLa2pCcHdlTEZ2eHZPTTkxVHVBSG0ya3pKd0NHUkw1?= =?utf-8?B?YkZrUWlQOEpHMXpmMVFhMVhKUVJDUU15TGc1UXduSVNtVjhVUTloMGMyNUxh?= =?utf-8?B?c2xwaGlWdStNak1DQVJTUjdSc3k4V1FPVnBiWWJPK1QrNG4xbXdySUVISVZi?= =?utf-8?B?UVFQVVdkcW9yRFZKNXhoUzJSNTF4aUNTMFU1RVRrN1VKcWFOZ3g5K1hIMWxH?= =?utf-8?B?bzl6aFk3NkJCbXNyRFFINldCOHdKcUlUYXhvdlVpZW9yQ2I5ZG1zdnUyZEl6?= =?utf-8?B?Y3p1NldtU0hZZVVaMTBsYW5OeFpxRnkwY01GNlI0SjQ4VGZCUDF0ZTQvbnly?= =?utf-8?B?MWdXNWFDSndGTTEzejFwUVY0czl1Tkl3VStnVVVqNWQvYnA5RmNGUVpCTlo2?= =?utf-8?B?WXZYejkxTitRNkp5N21RWVAvdldleU1DV3RpbnM3aHRzZ0wwT0ZoZFBmRjFn?= =?utf-8?B?WkZrTWw3SVk0T1I0MEQ4N3ZOTnVMUmNpL3Q3S0picEhyMG4yY1ZxUXhBbExE?= =?utf-8?B?MWpnMzN6ZWJubnppMjgxRGV2ZUZOR3RaWVFHL2wxUkU3M0Z4OCtYdUNwWFJs?= =?utf-8?B?MGRIZmpZT1MzOFk5Q2o0bGw0OXpMR3J0S1dENDJYSzJDQVU2K2dXUEpWTUlv?= =?utf-8?B?TnRDVkNYcHNySGx3eHhxbEUvWDdFeHoxMWVZM0YwK2tsMXVFMWgwaEhrckpv?= =?utf-8?B?ektrWTdkNHpJRXpnSWR2ZXF3SHNrV2FXVHUwRW5YMU1nRHU2RXBYTHpiMGVy?= =?utf-8?B?cTU2blVZSDdjMzNRWVlUY0I3K1ZwSGRLZnpYM3Z2MS9ZQWpKL01DYVhvNXJK?= =?utf-8?B?cU5hakc0STJQU2NZUGRFQVNiRFIyZlB1THVKWTRYaWlLK3QvMFp3SkMreFkz?= =?utf-8?B?M1pLOUt2THVYc1lpNzZkSzZHeW9WT0hlbkYyQzl0UnkxTnIxVWZrNjlVeTd2?= =?utf-8?B?OWVYSnFlNWNqbnF1Y1gyTUZaaGJjaE5MQktmRGo0U0FFT0JWUGF5WFFzaVlU?= =?utf-8?B?VldDVDlwdkNpYU9Rb2FWZnluTGc4d0lkQVlIOVRkZWFKNlZUVjFsRStkeWRv?= =?utf-8?B?VnNGbTJTdW52ZlBmQXFUYVAwTTBhc1BWWmpUUktXOWxkRVQxUytJZ1ZaeXBl?= =?utf-8?B?VHRaRWVUSzVUdVl5VUsvSmVnbVdTWlRhazR1T0hKcnpRMVRHRi92YVludVpt?= =?utf-8?B?SndXWjlsVHNiTU1wUVloYkZ4MkZoMXNFaVdXSzIxQ0dJTWppTWZqajZTV0J0?= =?utf-8?B?Mm9vZ05vZTNxcnZNWGF5a0hvTFZNdXVQNVc2dUluekpzdEkzdmxiR3NwR1dK?= =?utf-8?B?Rm1uR1Zxcm9ZUFlhemFtSHN2Wll1OVpLSWl5ZXp6THhFOXFYSjluQVlFUjlG?= =?utf-8?B?WW1ESHF1YU0yc3VMTGhkTTRqNnNsMCtsYkg0NUZzR2hNaUhheWErYTVXOEQ1?= =?utf-8?B?eFpvTXBJdHFHVldTN0ZiaXNmTWJXcDZ1Vk9vaW1HVldPNlpDMG5IMVBCSkxE?= =?utf-8?B?cC9hek5PbG5EWjBKcmdjRDVhNzk2ME80ckdhbkpKMVkwaUlaSXNwNVdpc2cr?= =?utf-8?B?aHpJR0RpODZLWmx4MmtiVG1Eb0M4Z0pZb0k4eG8rVmEvMURKaDZRMWZvY2JX?= =?utf-8?B?bTZ6R01jVS9zMFFpbUFTVVA1SXlHZXo2N2dXeXdadmd6cUhpbEtscm9oZmpD?= =?utf-8?B?NFN0eHgwd1M2TUxjcDNLS0t3UFZub2hUSlllc1g5NUdJWDV1YlRFUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26242a17-d2e5-4cdd-1a72-08da38cd037f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 12:50:40.6646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yd67aHjrzlcYtVWC5Dlwjcz0KfNDownACAdidfz0kAqe0XN+Yy5I+y2DoXkLlNoY0YnGpEh2wokR6jaj4Poi3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5586 On 25.04.2022 10:29, Jan Beulich wrote: > For a long time we've been rather inefficient with IOMMU page table > management when not sharing page tables, i.e. in particular for PV (and > further specifically also for PV Dom0) and AMD (where nowadays we never > share page tables). While up to about 2.5 years ago AMD code had logic > to un-shatter page mappings, that logic was ripped out for being buggy > (XSA-275 plus follow-on). > > This series enables use of large pages in AMD and Intel (VT-d) code; > Arm is presently not in need of any enabling as pagetables are always > shared there. It also augments PV Dom0 creation with suitable explicit > IOMMU mapping calls to facilitate use of large pages there. Depending > on the amount of memory handed to Dom0 this improves booting time > (latency until Dom0 actually starts) quite a bit; subsequent shattering > of some of the large pages may of course consume some of the saved time. > > Known fallout has been spelled out here: > https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html > > There's a dependency on 'PCI: replace "secondary" flavors of > PCI_{DEVFN,BDF,SBDF}()', in particular by patch 8. Its prereq patch > still lacks an Arm ack, so it couldn't go in yet. > > I'm inclined to say "of course" there are also a few seemingly unrelated > changes included here, which I just came to consider necessary or at > least desirable (in part for having been in need of adjustment for a > long time) along the way. Some of these changes are likely independent > of the bulk of the work here, and hence may be fine to go in ahead of > earlier patches. > > See individual patches for details on the v4 changes. > > 01: AMD/IOMMU: correct potentially-UB shifts > 02: IOMMU: simplify unmap-on-error in iommu_map() > 03: IOMMU: add order parameter to ->{,un}map_page() hooks > 04: IOMMU: have iommu_{,un}map() split requests into largest possible chunks These first 4 patches are in principle ready to go in. If only there wasn't (sadly once again) the unclear state with comments on the first 2 that you had given on Apr 27. I did reply verbally, and hence I'm intending to commit these 4 by the end of the week - on the assumption that no response to my replies means I've sufficiently addressed the concerns - unless I hear back otherwise. Thanks for you understanding, Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 13:05:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:05:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332089.555724 (Exim 4.92) (envelope-from ) id 1nrJMK-0008MW-L1; Wed, 18 May 2022 13:05:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332089.555724; Wed, 18 May 2022 13:05:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJMK-0008MP-I7; Wed, 18 May 2022 13:05:00 +0000 Received: by outflank-mailman (input) for mailman id 332089; Wed, 18 May 2022 13:04:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJMJ-0008MJ-8X for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:04:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d87ee5f-d6ab-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:04:57 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-LMbg5mXfPtSXCxzpVyn4MQ-1; Wed, 18 May 2022 15:04:55 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3250.eurprd04.prod.outlook.com (2603:10a6:206:b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 13:04:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 13:04:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d87ee5f-d6ab-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652879096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JCFWjg38DMiEyF7lKWWnUxcwO3pC19Y8ZRqkPG8+U4U=; b=Md35FX81YqZAEi5YhSwQOYWOtIbr5O5DNI23TcpNhcKp5j5SuMSAbj/ZcbxqaWcIGVv6kb XElR1/EFnVJXeS7iBiTTBtNUnmCsYjUCYxluN1gX77Pz6b8vqHVibmfhDP7frN24xS3/jE FzPOh7Y7eBwWRPFFMh5AXThUTSDBJzA= X-MC-Unique: LMbg5mXfPtSXCxzpVyn4MQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQZykUL+oSzIn5e/RLMjWDuK/KWjS2rkfcKOrpi6GOfWno/Aixs/1oY6HotdSbBVkypQ9T0Z/bIdx5FT2qtTyfWclKkTAf6bt2EIqYxPkPw91ZfqxsiIfXh16EtIksyRTxElf609Mm7Xwb+dUITZ38Y7YSoPPzk+hBFTU72isVtbD3xyVjh9zmi9QEtoj9hSQNY/TBfi6lDwrcgl3owMYbOmjhhO7ByqIQK+2crUT/E+0bfi1O9Od+T/kP+uVMV/u7mmbJcdrfF9+CCxQT3+HYpzRVgHaFivBS5naX2z9lWSfd2CmHNfRMuu1EEHAAUZmI6mVK50spT8fbI2dCyrGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JCFWjg38DMiEyF7lKWWnUxcwO3pC19Y8ZRqkPG8+U4U=; b=FNe+R+6B0zRR0njhdsEf/BJdfs/YhBykCnW47PUwExZ46vc4OcJAw9ha2xKECTcYfZym5r+Gjs3H8Ba6KTBS/51d50eegJ4hAzeLqh9dQw+CA4RZa00qd2WgvzDsoY6GTLhP5bl2VUOJb4IKE59CA/EWqr5Q4/PICGrBljsW/tiJh7/qtg1JpjuKaE4X+KXI2sEHiobn4qYf+nKDgj8YP2HgwBaDjR7BhxMlzWDEBYYpddI8cAPcVpk6IjcsItV9qrUfebLjDo99MJ7P4D0m92i2PI/MfAn14mophrlCJkkPsUkND4q2eTJ9/daoi/zPz0WMulPrG51LhSO4jb7CHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> Date: Wed, 18 May 2022 15:04:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220511014639.197825-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 626fd96a-38c0-4e37-1eaf-08da38cefefd X-MS-TrafficTypeDiagnostic: AM5PR04MB3250:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kv+8aFkDdi+N7tAsmuflE3/Jj/9mMax3TKR7jd+g/CXiZnbiFtV+va8mlikOLMxyKI8XZoBer0aXgpVFZmcy5eJZOrkE/oGNbslK64Sz87fAWeKMF9ZRwQqsLsYebb4t39PtxqaACwlYAv3ttfZ3l2WVqraB/ILMH+/U7McZu2QpdAiQF+dq4Gb012LKMgjMQyU3HE7aRGV5fdwEQTF+7VwR0Iiz2cFzjI1O+40qZlZVkAfkCPCODSZRpELW4QWRWI7Janjp/jDltJbA0i4aeZ2mN5sIreQOqR+jEGu5k80r1fW0XSAM2F9wwOCfn8qR1eY3x1o2P7zg50ew5xMksZW5Ph0G3ZUW+xDBRZfJqsk/A/nQNumTg0tnSgErQA56Ik0u+FUkhFF/z/1pWdhQk5SIicSy4gGiSY5Lbh/IxR9BDNsg3ZicsYGF+HqeGHzF2gWqmr78Yo4RMIwiSCewE9NCr/Yso7QfJOF+bPmzzLCGUYSvW2dwmuOZGbNJuwbz7fYPNSrk4xzDXGuftddw/z7Qpyu5ZrhGaiINnZ+lMIZ0IhXWgp3hDcPmi+Xd1m+EOirjrcFnM5DkRpSU3G3OjtRD7jd/HbjP4Hxet5Uujg9c/uOUDPmma2xQUNBppm6GZ2fq950gGv4EJB9ZJkGMWhcKiMvX1IHGqfenmiLfcHgfIW5R4o9aFkNgIZW8qi+rg2TFDFwzJQIJDmCTts4vaznvYLcy2HfkSO9svH//AZyjUYK2WTAuIBQ8gVYsH3TQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(8936002)(66946007)(66476007)(66556008)(8676002)(4326008)(7416002)(38100700002)(508600001)(54906003)(6916009)(6512007)(316002)(2906002)(6486002)(31686004)(6506007)(26005)(86362001)(31696002)(186003)(53546011)(2616005)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OURLaURuZjFDNmYrZ3hCNEpGMHFnRzdCdGd5OHpVV25hSERySFNzSzhhK2hV?= =?utf-8?B?UXJXYnlyOUpOUFpRMGQrQThZOTc4Q2hua2FhZEx3c1FseHJzbW8zVDZLSGJp?= =?utf-8?B?ZXFVNkZKMlhNQzlNVlZORUdSbWZrMElUQzd3a3dEdGRoZEZmSEdpVk1pdXFw?= =?utf-8?B?UzY1a0kvaktzdnlIOUY2alZmVWZXMmNGcEdSdHFMNmxyazZCWlY1Z3F1L2xp?= =?utf-8?B?RUNURXYwaHR5MlQvek1ra1FTZms1NUE1ZSs5clp5a3JsKzZ5SFpxRkFLb3dC?= =?utf-8?B?WTlIT0M0V0hKaU8zeWFzRzhReUZvczJCclpNbU1heXlaMklZNjhXblV1T0VF?= =?utf-8?B?dldjVHAvYVE1cUhpV0VPS0wxTnVmZjZvSmszMmdOcHE5UWx6bytpUUMyeWFh?= =?utf-8?B?OFpZVDJUMTJzRzhyemdWSjVxTXdKc2FUdGJ0TWdkODVWOE45Q2g3cEZWVTFW?= =?utf-8?B?VXBIaSs0MmF4eFdWMURnVzVYR1ZIQkJsTWpYcGlKcHBncFNFblNUZjdIY3dG?= =?utf-8?B?bXNmTmRiRzFKMlhhQ3pqU1J4bXA4RkNpTWo2Mk80SjlEdkV0WXVnTmQ2R0Nq?= =?utf-8?B?Z2YrZ21ZV202a3FqTlN4aDdlcjhvS3pwK0p2OWZzalRqL0oyNzN2OG93aVV5?= =?utf-8?B?RG41ZGgvTFZOZTEycXVGQjIxL012QVZvVVYvdldEM2JrbzVzeVE0bDkzQkJh?= =?utf-8?B?aU5sWTJFdVFyZEV3VFVkNUpCeDgxMVBSaS9lUFpmRjBkdVJ6QVJXTzJvaVdG?= =?utf-8?B?TnRHV2VUVmZ0eEplT1BUN2YzMC8vR3BiMkhUanBNYnFjOXRNMVFhSGtvUnRD?= =?utf-8?B?RFM0aGM5UTdwLzlPMndxVC9sYUFNbHFHc3RRTVZYRExpMGNXMWV2WlUwMFdP?= =?utf-8?B?V1M4a1RZWUtZaDhLb3RCR3JLa1c2cWh2S3N5aDRHVS8vOUhCTk1xR2tGMG1K?= =?utf-8?B?TWVtWlBWeDVxN0VTeU9DcnQvWGxhc3VjTTF3S21HQWpBWHJnaHl3T0RKM2l5?= =?utf-8?B?TWhCNFFGVm9ITkRWVGlUUC9DMVVuUW5UWkNNVVhqcTNyaVVqa1J0YkxMblBy?= =?utf-8?B?WlorMTV4T3loM29nMTBYMm5tMENodlVzWlZ6Yi9TZ3g1MDNvMTk4eFYyUzRF?= =?utf-8?B?N1VkdEhxTFBtenRIZlZVeG13NUMyTW9oTVVUdGpTQmlKdEhYOHhrREErV1gw?= =?utf-8?B?MDVqYjg3R3hwWHNPMXp6Wi9EbU1DRm5WeGJTVks1dnVNQk52dFpWM1E2VWw0?= =?utf-8?B?WUgxck1XdWNFVzI4SzJKaEREWGtJa2pFU0NUbUVRdXVZSC8xWFNraVQvUVc0?= =?utf-8?B?SXhYOU41eDQwK1BJUGdpa1pyVEVGZUhwYllxQW1IV2hIV0g4YTVWZ1h0djRM?= =?utf-8?B?bXcwcXZjUTRMdlFoL0JIclc0T1BYS3k0NDQwd3d5YVJGNkFiYVpZNHBCb2tP?= =?utf-8?B?dEtZY2s4ZXAwOGhzdEdSck5EOXFRUHV5NnRnNFVtVy9qNTlqODZGMmVrRmp3?= =?utf-8?B?UzhTMjlBNE12ZGFmbm1OVWRaeEEvc0xZb2ErVGxhdkVqMWtXVVM4SGFna2VX?= =?utf-8?B?YjNQTTBYUDZPVWdCZTVoN3h4YllMckJaT2ZqWE5wUHRIYzZOVkFKaWVxNVdr?= =?utf-8?B?Uk9qSk5CWlhMV2d0WDZRSnM0UnVUMS8vb3NYL2RCREJRd1kxQ3VNQjF1aEV5?= =?utf-8?B?NWViRHVzUWVHMExhM1FkRzBYdmRselp3eDl4ajdJNHQ2WWZQVld3bXNCc2hW?= =?utf-8?B?NkZOa2NWWDhNS05tR3U0TnltMFJBczdmTzFxZ2xMRXhxc2V6TENOWVNINWYy?= =?utf-8?B?Vlhha2Nidkt0dmFvbytudkNCWnYvK2M5MzdqOVRQR0FBcnZGdktYMCsweDJ3?= =?utf-8?B?QXB3TnFBdEJ0OSs2eVVuWGxNcGRBL1J3cWx6UDA2c3IyaDg3TUZNQy9XY3N0?= =?utf-8?B?RFowMXZHVFd3QmdQNkxmeGZIVzZ2alBiUVBFNU44Z2RVakgxMGpyc1ZsMmRM?= =?utf-8?B?NDdoRElNOG1oRVBNSU5yNVhYYWtDN2orWlBibjhZNS9XL2JRbTdCWGhTcEti?= =?utf-8?B?QTdTcFRlRHVLTkw3bm9mbnp5d0VEZkRWTjZQUnR0SGRoWkMzRkZPTTNqV01w?= =?utf-8?B?OE53dlAvUklBMFNPaVp0TGpPNzVFQVg0dlhVbHFYblRhbytxUGFiVjlMeUNk?= =?utf-8?B?RzEzWVRRTnFwKzZpT1l5a01jbXdCV3hwcVQyNVZCczlNYlVmTVptUUF6VTY5?= =?utf-8?B?aHl2Tk15Z3dEL1VWVW9rVUtZQ1RvYUVkUXM3VXZrbHkwekEwaThBS2k3c1Y1?= =?utf-8?B?YnA5eWN1NGxHTWRLZjd0NjgycXowOTVmTXErdDJmR3hIR2hsN1d5UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 626fd96a-38c0-4e37-1eaf-08da38cefefd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 13:04:52.0172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U+NhYCbm27vBai56XoK0u7q0LoHomyakn7Cht+OYHBM36QqAjKSTet8craYA+6WBkOAEwsyAy+ho0awPFfQnmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3250 On 11.05.2022 03:46, Wei Chen wrote: > x86 is using compiler feature testing to decide EFI build > enable or not. When EFI build is disabled, x86 will use an > efi/stub.c file to replace efi/runtime.c for build objects. > Following this idea, we introduce a stub file for Arm, but > use CONFIG_ARM_EFI to decide EFI build enable or not. > > And the most functions in x86 EFI stub.c can be reused for > other architectures, like Arm. So we move them to common > and keep the x86 specific function in x86/efi/stub.c. > > To avoid the symbol link conflict error when linking common > stub files to x86/efi. We add a regular file check in efi > stub files' link script. Depends on this check we can bypass > the link behaviors for existed stub files in x86/efi. > > As there is no Arm specific EFI stub function for Arm in > current stage, Arm still can use the existed symbol link > method for EFI stub files. Wouldn't it be better to mandate that every arch has its stub.c, and in the Arm one all you'd do (for now) is #include the common one? (But see also below.) > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -1,6 +1,5 @@ > obj-$(CONFIG_ARM_32) += arm32/ > obj-$(CONFIG_ARM_64) += arm64/ > -obj-$(CONFIG_ARM_64) += efi/ > obj-$(CONFIG_ACPI) += acpi/ > obj-$(CONFIG_HAS_PCI) += pci/ > ifneq ($(CONFIG_NO_PLAT),y) > @@ -20,6 +19,7 @@ obj-y += domain.o > obj-y += domain_build.init.o > obj-y += domctl.o > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > +obj-y += efi/ > obj-y += gic.o > obj-y += gic-v2.o > obj-$(CONFIG_GICV3) += gic-v3.o > diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile > index 4313c39066..dffe72e589 100644 > --- a/xen/arch/arm/efi/Makefile > +++ b/xen/arch/arm/efi/Makefile > @@ -1,4 +1,12 @@ > include $(srctree)/common/efi/efi-common.mk > > +ifeq ($(CONFIG_ARM_EFI),y) > obj-y += $(EFIOBJ-y) > obj-$(CONFIG_ACPI) += efi-dom0.init.o > +else > +# Add stub.o to EFIOBJ-y to re-use the clean-files in > +# efi-common.mk. Otherwise the link of stub.c in arm/efi > +# will not be cleaned in "make clean". > +EFIOBJ-y += stub.o > +obj-y += stub.o > +endif I realize Stefano indicated he's happy with the Arm side, but I still wonder: What use is the stub on Arm32? Even further - once you have a config option (rather than x86'es build-time check plus x86'es dual- purposing of all object files), why do you need a stub in the first place? You ought to be able to deal with things via inline functions and macros, I would think. > --- a/xen/common/efi/efi-common.mk > +++ b/xen/common/efi/efi-common.mk > @@ -9,7 +9,8 @@ CFLAGS-y += -iquote $(srcdir) > # e.g.: It transforms "dir/foo/bar" into successively > # "dir foo bar", ".. .. ..", "../../.." > $(obj)/%.c: $(srctree)/common/efi/%.c FORCE > - $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( + $(Q)test -f $@ || \ > + ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:06:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332098.555736 (Exim 4.92) (envelope-from ) id 1nrJNT-0000Xd-7T; Wed, 18 May 2022 13:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332098.555736; Wed, 18 May 2022 13:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJNT-0000XW-4A; Wed, 18 May 2022 13:06:11 +0000 Received: by outflank-mailman (input) for mailman id 332098; Wed, 18 May 2022 13:06:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJNS-0000XK-Nv; Wed, 18 May 2022 13:06:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJNS-0004uO-LI; Wed, 18 May 2022 13:06:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJNS-0002xX-9r; Wed, 18 May 2022 13:06:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrJNS-0007v6-9M; Wed, 18 May 2022 13:06:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T6Ks/bw5S6kuUuyK6b0HvA/aqdb50dL8Rn21vlf/2mE=; b=pbnkvmt2VIBfLkGdSlcyMDJi5u VNNqCHnrE60IslA2Qs0ETaktlCphVaHwjGGzSKpn0PbwWJIJvhqT2s9W8r1TgZz2Mq3IckKbE5TIK rluxufs5VjnD3vkfzAhHVtmQ78nJJujSH7rJc4hdsxEYSEeUrqNlkcNTeo/WUqGx3RKE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170537: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 13:06:10 +0000 flight 170537 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170537/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1083 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 102 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 13:09:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:09:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332108.555747 (Exim 4.92) (envelope-from ) id 1nrJQZ-0001E3-Ot; Wed, 18 May 2022 13:09:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332108.555747; Wed, 18 May 2022 13:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJQZ-0001Dw-Ks; Wed, 18 May 2022 13:09:23 +0000 Received: by outflank-mailman (input) for mailman id 332108; Wed, 18 May 2022 13:09:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJQZ-0001Dq-3m for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:09:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb8d3355-d6ab-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:09:21 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-Fjd0eupSMnOjpIxIlHhJPQ-1; Wed, 18 May 2022 15:09:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3156.eurprd04.prod.outlook.com (2603:10a6:206:c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 13:09:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 13:09:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb8d3355-d6ab-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652879361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ESkNfCumVruGG3vYp53gMsi4FlHTGLWtoN/cGHQtHg=; b=Ysl5sNCye5oFbD18O49K7Qb99JWER+KiB6yFphILaqeFoEgnylaSu4Yx/vapLiyLNrpLmh JutFglXlwkgz7cjPyGCfnnS9TCHTm4NpdRvKXHpbSAKO8B36318mRbOnSwHbDhN41NuNt4 ATWBQ0bdJXNPi0KBuwS+X6+AJ6uhlFo= X-MC-Unique: Fjd0eupSMnOjpIxIlHhJPQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Du4Qch7mN8mDlGFHqnGmbkDiuzSldTh/Ok3Vukyle55tXIxYnLja8GPn6AF3HJYZ0z0dEde/DYqFNygglEOUu2t6SMBqDJEryIk1ZRov+dy01/WqNGdBVOJWQaDsO6IC6cP4tFz+Br7zhCSnxZ4NzDsFRd8Rory3dZEXKFDKhY9EvF7XrnrYMc3y5ccj4HssLf56UZ4JXcYb9XqBIEpQE6sMSa5VKDBvmm7+DNhJ0W03bKFlYJ6c1dyNlLlC5gtQVX4kt0/V+KyEzv10VoiOonD0Rj6Y9843vSC849C1Me4tFUrUpZMGD31GdxnobMetwakFg+QiGfxiemTKo/ivyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ESkNfCumVruGG3vYp53gMsi4FlHTGLWtoN/cGHQtHg=; b=XDnEYW+BhoDdVfXcewOAuD+tA0dPOfMyS0rq3F9FeAHtfh72ADN7w6KkatiVdtlgHoHS84aCShLS0vxznnWW9Bti2FeGzkKLYWjGw3GifFfh1WxUGLWRgPXjDDg3xZVS5FF0ptvvhXuGSPi2eoEIYOXtiD6nc5AN8QTziJrbjeYzzk2kBalzYftkwyHJWvIhJRHq7r8HjkkhSkFheR9BmwizXAQHdUhns/tV9+rzOqVzEQpwBkFsd8DjI/reDrjGK+2/tMcTtkV6BpAqkqh0V2aJtr2wf9NE96eF18eRz5M4+i3pXj7dz8K/OuFh5CiUK3JriVS7etMTXmEuJtA3Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4c6ce6dc-5d03-37f2-8a7d-9c72716abfaf@suse.com> Date: Wed, 18 May 2022 15:09:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 4/9] xen: introduce an arch helper for default dma zone status Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-5-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220511014639.197825-5-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0552.eurprd06.prod.outlook.com (2603:10a6:20b:485::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a993c2f-c5d6-4700-3864-08da38cf9c15 X-MS-TrafficTypeDiagnostic: AM5PR04MB3156:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rTa6MH57ehvJUE3OKwpPkwXz7TMo1Fmx9NzBGt+ITMiJ6ZRcG0e+NbcdH9PdX3Nj4CebQN85Nv5NgN5q3+b5Co4Fv8H/qDLPtXefGCX5aj4BMhiwuKKyeyDcgWbpJqnVEFuQZlyWpbqw9czppqWuvIRUx+7Ico9HG+LH6v2zJCbpVm12m6+Jo5PwBctJ80hxkQeHnKzcouMBoqKoVm7YhrtfYx6Jj9shsjdkqzamMAmY5CMdfUVK4gBG14TVgf4Qu1CY412QCb+3VSQTnshXOOHVEua+AF/jGpYG5pBXPretoc9wPZH3FwW2VxUiHfpFOHRp1rWRulqKMvQ0VOnid+B0tX+IirYLseJp6zAEWU1HxUNggxZ7jlVGpn8IQ/ot4kOrc/hZ3FTyVeVC/y2U40WMFAB5chAPnxq9FUi5LNMrVqrQNQ+gb9/f4xivUFQjDcQOATc1To2FQs2ER2DWm5D9glW+DJeA2k0Ppm1w9QXk9RJ4tELU/4VWehZnYtSI3+azgibmewprBYPk21MisYw7E5hmB3CA7Y7xjLi0dfz4bwRZO4PDekpvRkcK/qi89iJhvf7z1Nsf3TipMUZeWvHApIaRrq1gva469M03MoHJ+XcMQu5YRkTRcsLADXalPoljCNjn3BKSxCpFIS5gbwA9kragN9vHkyhm1BwQG3cGDbt1YWTW7pSmsYQjlZXbPVAR17EZRYii2c5V2wvLkWlPh707Wxn1EUwZQik6jdnbv++kuRdlqkrzs+/LPxXD X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(86362001)(186003)(31686004)(36756003)(6512007)(5660300002)(7416002)(38100700002)(8936002)(6486002)(508600001)(2616005)(83380400001)(6916009)(54906003)(316002)(66476007)(66556008)(66946007)(2906002)(26005)(53546011)(4326008)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0psanRLWU1aV0VnVlNSdVYvR0ZITlZWdG1rUGdtMzNkSUNWQ2ZabkthZUNv?= =?utf-8?B?MWQ2RVJrSUs0UUtUZjZDZm95NzgwbUJoa25XdXA2SzBtTHZzRFlxandGVVJZ?= =?utf-8?B?NHhFOXZ5eEFQWW50MGl1ekhCTlFsa2NPTGNsUldaN3A0SXI1WmU2U0YwVFVw?= =?utf-8?B?OFl5K2pncFpudHlaVWRRSDlzbFBObi8xYmJHTmRwdWZ1SjBUVlV0WkhTRG4r?= =?utf-8?B?UVdZdjR0UlRRNEFQM0xEYmNPeXhseDBPVm5mY0NjMDJ0VzlPZjd4VHF3S1BJ?= =?utf-8?B?THp3VmEvSm54Y2dST2JhYVVGV0xCRDcxVDBFMVE1NFplMnpqcjRSSnlLVFls?= =?utf-8?B?SSs2K1F3R3FBTTkrQ2dOdXRZR2QwK1l0WjNJMW1NMXBsTHQ0YWdoL1VMano2?= =?utf-8?B?b3hWc2lXckRzakgyNEo4Y21EVHBmMXhUQWczNGh4TG9jYXVyb1cwRUxwZkxo?= =?utf-8?B?UHJsd3hFNlhKQlJpR0crbytKbTZoYzdkdXMrWDlNR0xWNUpRcHJFSXFnVjJQ?= =?utf-8?B?YThKaFpRSE5ZRFI1TFhIY3JOYXd3b0YwVE1jdW1JSzl1aUdkYzBKTXhDd0lH?= =?utf-8?B?WUZ6b0ZPUzFLN3Q1Mnh1VzVoZzA5U3R5OFA3YldCRGZveTQ2TUp2cEFjMFNZ?= =?utf-8?B?UmRodXJjNkF3bEJtZmJPWjN3NGVleWlvKzFaaEp2a2VtdzRXVURIWDZ6QjRx?= =?utf-8?B?K1BhN2llVS9ZNTFpMFJDMTRzL1FJbExlM1FKNHRQRWVlaER6VW4raWo0VUZx?= =?utf-8?B?UXFKUmV1aUF4TWs3U1c2amdLa0gwTS9MSnYzdmR1Z1VqdFk2alJlYXdTZzRj?= =?utf-8?B?M0FVZHpaSFF0dmx5UmRLaEl6VEsraERNaVNvTXgwUnlXOGtueUZudDBWVDdt?= =?utf-8?B?TFZFRkI2cjBEdnFqaFh0VWI5SW56eklPQ1RXQVByUGZWMENhTzFKM3RPZkZE?= =?utf-8?B?U3RZWkJublFTZEN3QlhHOUZYZHBqUE5TQWNsODdRUkJoQjFTOHdCYzc5aERs?= =?utf-8?B?WDlXOUVuSmNEL09QdVlWN3NkMFRqNmVXa3ZrQjNjM3BxTzhPWlJ6Yld2M3hh?= =?utf-8?B?aGJpMTRpMUlrb1ZSYlhrK2xiMVhyU2ZUM3FDOSt0TVRTYzFVRFRHTjN5c0tY?= =?utf-8?B?Y29hV0ZwT0Q5Unlndm5sUmhCMG1Md0tHVE5ORU5DUWh0RDRYUzlVWWNyV25m?= =?utf-8?B?THVqdHNPaGE2Nk8yemw3TGZqWTRqZWdWUjNhMitTaWhlQ3lqQTJHVjFRV1dJ?= =?utf-8?B?VFd2N2tmTHpjeUhHTWh0REdpcytDeWxvR2dkNlVFRE04MUEwRkFmd2xuSTky?= =?utf-8?B?LzlmMEJZQ3ZsRFFxOHhHck1zQzFkV1IvZ0pDNWsrdFIzelZKTkRnT2NCRGZC?= =?utf-8?B?LzZaQitpd2RDV212WWFxcENsVDltRmRvaEw3TE9CWmgvR1dKLzBRZk9CUVlu?= =?utf-8?B?YjRCY1cxS295cVZFR3hWZFl3bmxzYzZvLzdxNjJmd3hSaDVNYUFUZnBaMDhp?= =?utf-8?B?QThSd3h4djMvNzA4eVc3aVo1TU1SWkRueHNUamhvRXVwWVN0bndFcytPdmh3?= =?utf-8?B?VE82UVpWZnVMZmpudHhZUENNVnVKeDJXM0R2QzRFWDlUblY3VUJQamVJaVRv?= =?utf-8?B?VmR3V05kRTZQWWR6MmNUcVQ1QmYyRVRyQmx3UkhzL2NscHV3UnJGRjNmOWN4?= =?utf-8?B?M3JqeUhvTGpPMUg3M2tlT2ZQeDJHSnpGSVBpY2l4NHUzV1JKd0sraXc3YVdu?= =?utf-8?B?d09GbFgyazAxdDZVOG9ycmYwNmtMcTV1cUdob2p2Ukk4RkpjRmQxay9sZWdu?= =?utf-8?B?UHA5YndYcTlqMGozQ3ZLK1d5Si9NUUtQZjZVYlQwOFhVeTJCSnBzTm5nQ0w5?= =?utf-8?B?SHliQjlTR09pK0dnUlVVc3d0TndpS0NWUGtSTzV5NmhmelJSVldhNVVKWURG?= =?utf-8?B?Q2RXSCtwdFNPOTJBQ3VqM2lBbkdRVlNSYjdMK1hUYzNvVEllT0c4T3BnOGxF?= =?utf-8?B?VHBreFN5QUM5L1BBVHF0RkVqcHFDNlJlMlM1bjVDWW9GRS9CT3drdHRQcmo2?= =?utf-8?B?S3VBMGt1Y0s5djBKaWRHQUlHMTdOL3B3cTlKdWNyT2Y4VEZOUy8rK0lkZ1px?= =?utf-8?B?VE5ja2dzbC9kRHVGbng5WlEzZjFHQy9aYmc2bldQM3ZKQy9SQ2k4RUp2RE41?= =?utf-8?B?anB0YmhxNmh2Wm9GeDlRMjVwa1NvNU1oVDJNY3QwYzBLUzJTSi8vWFBNRWg1?= =?utf-8?B?NEFNa1F6TzZKRElWMFJBcElvVDdVb2ZqZHFUUTFFa0lYODhpRmdCMjNtalZk?= =?utf-8?B?bVNWanJRRDBFaVVDSlA2NTRUMmJQbC9NZnZMZ1FvR01JNEdVVG93UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a993c2f-c5d6-4700-3864-08da38cf9c15 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 13:09:15.5931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DmhvMCTL5uZ6bKm+ryrB1YeMklKpGwHDtFTw64qHaaLhuPwglnsJWvm7kJLVRuGSv/vAlAqFygET3FeZhO5Zbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3156 On 11.05.2022 03:46, Wei Chen wrote: > In current code, when Xen is running in a multiple nodes > NUMA system, it will set dma_bitsize in end_boot_allocator > to reserve some low address memory as DMA zone. > > There are some x86 implications in the implementation. > Because on x86, memory starts from 0. On a multiple-nodes > NUMA system, if a single node contains the majority or all > of the DMA memory, x86 prefers to give out memory from > non-local allocations rather than exhausting the DMA memory > ranges. Hence x86 uses dma_bitsize to set aside some largely > arbitrary amount of memory for DMA zone. The allocations > from DMA zone would happen only after exhausting all other > nodes' memory. > > But the implications are not shared across all architectures. > For example, Arm cannot guarantee the availability of memory > below a certain boundary for DMA limited-capability devices > either. But currently, Arm doesn't need a reserved DMA zone > in Xen. Because there is no DMA device in Xen. And for guests, > Xen Arm only allows Dom0 to have DMA operations without IOMMU. > Xen will try to allocate memory under 4GB or memory range that > is limited by dma_bitsize for Dom0 in boot time. For DomU, even > Xen can passthrough devices to DomU without IOMMU, but Xen Arm > doesn't guarantee their DMA operations. So, Xen Arm doesn't > need a reserved DMA zone to provide DMA memory for guests. > > In this patch, we introduce an arch_want_default_dmazone helper > for different architectures to determine whether they need to > set dma_bitsize for DMA zone reservation or not. > > At the same time, when x86 Xen is built with CONFIG_PV=n could > probably leverage this new helper to actually not trigger DMA > zone reservation. > > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed May 18 13:09:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332115.555758 (Exim 4.92) (envelope-from ) id 1nrJR8-0001km-21; Wed, 18 May 2022 13:09:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332115.555758; Wed, 18 May 2022 13:09:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJR7-0001kf-V3; Wed, 18 May 2022 13:09:57 +0000 Received: by outflank-mailman (input) for mailman id 332115; Wed, 18 May 2022 13:09:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJR6-0001YW-Fr for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:09:56 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc6a0f0e-d6ab-11ec-837e-e5687231ffcc; Wed, 18 May 2022 15:09:51 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-191-ngHoSp9hM-2D9F5m28W-Cg-1; Wed, 18 May 2022 09:09:48 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3041A294EDC0; Wed, 18 May 2022 13:09:48 +0000 (UTC) Received: from localhost (unknown [10.39.192.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 596B4492CA2; Wed, 18 May 2022 13:09:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc6a0f0e-d6ab-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652879394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=K801eJCmU2pj2pPB6zBLBAL3MRfzoEeZW44TvBJ7tvo=; b=adCb/tEzf8MiMzregr0D3rsk9Rko1ac6qb26i7NqMasNE5tW5Z3nEZ/Wh+ifyMkw+UPFgj bWp8AfoI4ZUb7UFGyPTeh2YtTxtj+mNOfumPrGJHSvhyZMc+1aDuNG/r+q2HqixLH0C+wN v09HtMOqM6QnVo+9IvOgrQcyfsoaJWc= X-MC-Unique: ngHoSp9hM-2D9F5m28W-Cg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Paul Durrant , Stefano Stabellini , John Snow , Paolo Bonzini , "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, Fam Zheng , Anthony Perard , Kevin Wolf , Hanna Reitz , Coiby Xu , Xie Yongji Subject: [PATCH] block: get rid of blk->guest_block_size Date: Wed, 18 May 2022 14:09:45 +0100 Message-Id: <20220518130945.2657905-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Commit 1b7fd729559c ("block: rename buffer_alignment to guest_block_size") noted: At this point, the field is set by the device emulation, but completely ignored by the block layer. The last time the value of buffer_alignment/guest_block_size was actually used was before commit 339064d50639 ("block: Don't use guest sector size for qemu_blockalign()"). This value has not been used since 2013. Get rid of it. Cc: Xie Yongji Signed-off-by: Stefan Hajnoczi --- include/sysemu/block-backend-io.h | 1 - block/block-backend.c | 10 ---------- block/export/vhost-user-blk-server.c | 1 - hw/block/virtio-blk.c | 1 - hw/block/xen-block.c | 1 - hw/ide/core.c | 1 - hw/scsi/scsi-disk.c | 1 - hw/scsi/scsi-generic.c | 1 - 8 files changed, 17 deletions(-) diff --git a/include/sysemu/block-backend-io.h b/include/sysemu/block-backend-io.h index 6517c39295..ccef514023 100644 --- a/include/sysemu/block-backend-io.h +++ b/include/sysemu/block-backend-io.h @@ -72,7 +72,6 @@ void blk_error_action(BlockBackend *blk, BlockErrorAction action, void blk_iostatus_set_err(BlockBackend *blk, int error); int blk_get_max_iov(BlockBackend *blk); int blk_get_max_hw_iov(BlockBackend *blk); -void blk_set_guest_block_size(BlockBackend *blk, int align); void blk_io_plug(BlockBackend *blk); void blk_io_unplug(BlockBackend *blk); diff --git a/block/block-backend.c b/block/block-backend.c index e0e1aff4b1..d4abdf8faa 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -56,9 +56,6 @@ struct BlockBackend { const BlockDevOps *dev_ops; void *dev_opaque; - /* the block size for which the guest device expects atomicity */ - int guest_block_size; - /* If the BDS tree is removed, some of its options are stored here (which * can be used to restore those options in the new BDS on insert) */ BlockBackendRootState root_state; @@ -998,7 +995,6 @@ void blk_detach_dev(BlockBackend *blk, DeviceState *dev) blk->dev = NULL; blk->dev_ops = NULL; blk->dev_opaque = NULL; - blk->guest_block_size = 512; blk_set_perm(blk, 0, BLK_PERM_ALL, &error_abort); blk_unref(blk); } @@ -2100,12 +2096,6 @@ int blk_get_max_iov(BlockBackend *blk) return blk->root->bs->bl.max_iov; } -void blk_set_guest_block_size(BlockBackend *blk, int align) -{ - IO_CODE(); - blk->guest_block_size = align; -} - void *blk_try_blockalign(BlockBackend *blk, size_t size) { IO_CODE(); diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c index a129204c44..b2e458ade3 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -495,7 +495,6 @@ static int vu_blk_exp_create(BlockExport *exp, BlockExportOptions *opts, return -EINVAL; } vexp->blk_size = logical_block_size; - blk_set_guest_block_size(exp->blk, logical_block_size); if (vu_opts->has_num_queues) { num_queues = vu_opts->num_queues; diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index cd804795c6..e9ba752f6b 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1228,7 +1228,6 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp) s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s); blk_set_dev_ops(s->blk, &virtio_block_ops, s); - blk_set_guest_block_size(s->blk, s->conf.conf.logical_block_size); blk_iostatus_enable(s->blk); diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 674953f1ad..345b284d70 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -243,7 +243,6 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) } blk_set_dev_ops(blk, &xen_block_dev_ops, blockdev); - blk_set_guest_block_size(blk, conf->logical_block_size); if (conf->discard_granularity == -1) { conf->discard_granularity = conf->physical_block_size; diff --git a/hw/ide/core.c b/hw/ide/core.c index 3a5afff5d7..f7ec68513f 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2544,7 +2544,6 @@ int ide_init_drive(IDEState *s, BlockBackend *blk, IDEDriveKind kind, s->smart_selftest_count = 0; if (kind == IDE_CD) { blk_set_dev_ops(blk, &ide_cd_block_ops, s); - blk_set_guest_block_size(blk, 2048); } else { if (!blk_is_inserted(s->blk)) { error_setg(errp, "Device needs media, but drive is empty"); diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 072686ed58..91acb5c0ce 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2419,7 +2419,6 @@ static void scsi_realize(SCSIDevice *dev, Error **errp) } else { blk_set_dev_ops(s->qdev.conf.blk, &scsi_disk_block_ops, s); } - blk_set_guest_block_size(s->qdev.conf.blk, s->qdev.blocksize); blk_iostatus_enable(s->qdev.conf.blk); diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 0ab00ef85c..ada24d7486 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -321,7 +321,6 @@ static void scsi_read_complete(void * opaque, int ret) s->blocksize = ldl_be_p(&r->buf[8]); s->max_lba = ldq_be_p(&r->buf[0]); } - blk_set_guest_block_size(s->conf.blk, s->blocksize); /* * Patch MODE SENSE device specific parameters if the BDS is opened -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Wed May 18 13:11:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:11:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332124.555769 (Exim 4.92) (envelope-from ) id 1nrJS9-00036j-Ci; Wed, 18 May 2022 13:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332124.555769; Wed, 18 May 2022 13:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJS9-00036c-8u; Wed, 18 May 2022 13:11:01 +0000 Received: by outflank-mailman (input) for mailman id 332124; Wed, 18 May 2022 13:11:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJS6-00036J-Pn for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:10:59 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f378af27-d6ab-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:10:57 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nrJR1-009xZP-0G; Wed, 18 May 2022 15:09:51 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f378af27-d6ab-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Du0yR9uhHpKwWrKsjoqMfifs7bCXApVmJcTLKS159Q8=; b=KR8Ca3qzn6Prru2b2ovD3a5c88 3Yl32PXNgwJAzJv1K+GwtALbIi3R7PHWPogPI//mjA46BacEdcFlczlu7VgbqBbi0iRFln4dhAmL3 5vAwoEH2Y5npRXnrsBS0Pt1IPEFHpxBOrNJbK+CGAUFY1mpA/Xk/bDS+XL+ITQtGq3i57YSw2ze27 6u/aeZyJiDji8Ld6K9lb+iY/t9E1NA5TGk8rCRjPY8WXYQAQH85dDOYmikTTt80JzPDf76BhHmUH/ IE+yGx2cI+Y6f449JTeHotkEOnM9AIr+trG8kHtj2MTTykTHXqJtKMQ7SzJhAjeP0O52jetyt0xPW XVvP+JXg==; Message-ID: <8a1159c6-b4c1-87b9-8a09-6d5696f8f3f4@igalia.com> Date: Wed, 18 May 2022 10:09:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek Cc: Scott Branden , Sebastian Reichel , Florian Fainelli , David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/05/2022 04:38, Petr Mladek wrote: > [...] > I have answered this in more detail in the other reply, see > https://lore.kernel.org/r/YoShZVYNAdvvjb7z@alley > > I agree that both notifiers in > > drivers/soc/bcm/brcmstb/pm/pm-arm.c > drivers/firmware/google/gsmi.c > > better fit into the hypervisor list after all. > > Best Regards, > Petr Perfect, thanks - will keep both in such list for V2. From xen-devel-bounces@lists.xenproject.org Wed May 18 13:13:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332137.555780 (Exim 4.92) (envelope-from ) id 1nrJUQ-0003vC-2K; Wed, 18 May 2022 13:13:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332137.555780; Wed, 18 May 2022 13:13:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJUP-0003v5-Vj; Wed, 18 May 2022 13:13:21 +0000 Received: by outflank-mailman (input) for mailman id 332137; Wed, 18 May 2022 13:13:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJUO-0003uz-Qx for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:13:20 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49702c45-d6ac-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:13:19 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-hVbh9_QpOEmpUKYa_QLW3g-1; Wed, 18 May 2022 15:13:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4124.eurprd04.prod.outlook.com (2603:10a6:5:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Wed, 18 May 2022 13:13:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 13:13:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49702c45-d6ac-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652879599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2yJS8IWcSVkk5NgcsZ3It4BivFPZc+QsJI8JiY6QOcw=; b=GM5zIFCi9IXup53MzAZHocUtb5Z5t3wjrnmWqVeWKu7ZpsC/I4AHDAOE6gVMw1ved4Hiuf sAGVr9HfgQIZeXx2MQsOFb2ygDRd+PDKa71AVSEkOQC38CafIKV0o+CbKsAIZaJP4ZB+nL 7r21HQdMltQzjGbATl4YlY+YQ98J3Fo= X-MC-Unique: hVbh9_QpOEmpUKYa_QLW3g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PAGt9aHPh3w4JLDknew2uQkPoim1Seh9F7KOo+vidO1mC9z1+QbPQJP3MEILaKTbq9NOamnKUGBTNtH87S1CrcPF1mGYn/8sCdzbPxn7Pjsmk8nLBZWi/8xqALiXQX48NbK/pXfrNRn/KzBm6SXawe3Y1C/Q4CX7ejcRQ8BkLvstd8AT3SuoBPP+vOR/FmEulLm2lYAy/YfXSP46F8NWQhao+m07tcuDU66nDdXSEeKD0XbO7QTAUvV5sTuyTuF8jSFow1e8d+QmScqaFrK/ngDWMlgP/ORSyVJzoUiReWK67LfWMo+R9xrSS/0YqjoC1w1QE/xkkfKmW6IgDFGtSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2yJS8IWcSVkk5NgcsZ3It4BivFPZc+QsJI8JiY6QOcw=; b=P4qKHZ9ELpC8Qd2RFJluDE0iNp+YEYVHJO9/NRdIBzQodPd1sn00VvxBu7DWFe+hVep7YwhNzAK+ZPJrtuGz8RmQpeFpXEA/6Lb+HRDVAVpl/fi5/WXuisnFtG2N/My5Pca7f2U1Z84SyrCRTHjpjna1j9CuwKaa+jlo+jj1O1kizR5BhJdTgNiw+TB4uUKu0DUCmtqNpn8higmqt3+gEpb+mZcCU5xAMPVdwnAxf91rQx5tSyVSndquykE9Te/TRbaeGWFWozpO3M8g82I055JcLHJjlr/px2h0w9IFb/jjEFJLZS7NGLq1pj9ngbt9r083+RbuMNYuwcQuZmmLUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 15:13:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 7/9] xen/x86: use paddr_t for addresses in NUMA node structure Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-8-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220511014639.197825-8-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0101CA0031.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::44) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d92fe547-61db-48ef-f138-08da38d02ae6 X-MS-TrafficTypeDiagnostic: DB7PR04MB4124:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m94Rnk7Gh8Ml16fsJo3p4p5tL1GYJH9HKpVNV4PBg5bd9qecXEnFqJ8q9/dUui17G3trYro7q4bYDMBajvNd9ezaf7yrnz2Oxxi465HORoM82s8PSKvBByQkucP/2gSwPeCvJWkkNgjFGlXUCMakmzDtGyk01UhcB/Kus4hoEWcJRyW+KjdGtQHH4p+2k5Fy/tTf91m0O3EwD2Q/b3hP67ux9sV4b/KP3VpEcnzPowYzMbaCITJA6lQDwdQLXXVuQUrF0T1gN8S3stGs28Cn5bJhUja0s2ic1sIF99Sk0NqfTvg4CbjBHejcqp6G1xj5qJkrynfCKrckKWgY5vQzL/S/hMqhewJuMupt+VAxaoCSJClsrfhtZA/ZJVmpJYeFBZSIp4d6zHO17+b2a+PogIM6BmHcWq+K8id4AWpklUvaY9HXD6Re9oJyVHPbIfNqxVcAxKybJoeJr2qgp/WluRecifhglzPJww2/Ep0Hk/R6fH+aGcKUCZvEdD8hAED5HZ61s7g/KLFrWjUla+Fiiy2MgFuI0lMZXh8yUrG4TH97PRMNw882MGLxA9cFZ3zLJM+ZcK/ipNVgMHRAX6RWMCukqBmNnClQZuuzzi3ZxVT7hx9ipHbwIvLcOFSsAE5MYeUljCbDVzpHvclV2JuPQBy9reEVRMIRz8kYikI6kj8aT99NDFthxKK/HahSAELgb01vOo9CPG7+z1hzzhgBA5NX48ge4D2lxtxuu/0b+hI3bouUJ/3oC295rdfGmYOq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(8676002)(66556008)(6506007)(316002)(66476007)(53546011)(8936002)(508600001)(6666004)(5660300002)(83380400001)(2906002)(2616005)(38100700002)(26005)(66946007)(54906003)(6512007)(36756003)(6916009)(31696002)(6486002)(4744005)(4326008)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGM3dXNPcVpRUEYzZkZlZ28zb3hWTUplRHJlTVdmdUpyS3FlbWVObHFkQVlW?= =?utf-8?B?NHdDaDhFK0RxNVIvNVpKVWxWRERlTUJzdG9ScEloVFFKMFIzdXVzUUFLY1pi?= =?utf-8?B?TFVFbHVwT2FrWmVka1MrVUU2ZWU4MUloUVFoWkNZeGowQnJzN2htTmYrTFNT?= =?utf-8?B?NWJKWm9jbGpwM2R2WVpzTDBSRitLZzNGdTFHcW4zNklqNXFkUFF4ZjlBNEp2?= =?utf-8?B?bUh2VW5qRzBJU2o2bm1wcEhUTE5IQ0g2Qk42WVhYdElkeDNaTnpkaktNaDBw?= =?utf-8?B?S3dYUkU1amVSM0RFR1dhSDRXenR4Y0cwK2kybFNGZHhCVWIyL2RoTW15ZTVv?= =?utf-8?B?K1E0VDRvQlhHQy94b0NNOEd5OW1KOWg2bkxPTE9oZjFlZVpDdkhUdTBQSjBY?= =?utf-8?B?RjRrUnhkNWJ3Y1czWThTU2dTM2FndHpmNSsvaWlYYVhTelJVVUN0L051VWoz?= =?utf-8?B?eXFFWFhjVHpJOGdVM3dNM2NnV0wrbGFLTkhqb0JqUmpLT3A2cG96VHFzMGNB?= =?utf-8?B?WWtpUFRlQnJPa3NTZzVTalhaM24rcnYzazgvclNTNmFHeHB2b0p1ai91WlpN?= =?utf-8?B?R3lpdW5aYTd2a2ZnK1psalkzNFJ4R010VEh2b1dVZWtMcWxOdEYxYlFqMDJm?= =?utf-8?B?djQyL1N0Umo5M29oSk10ZlNEMThGRVp6RklVZ3JBcVB6S0NOQ0k4Sm8wOUNo?= =?utf-8?B?b1VhRUxEUXZXSWtwb3Q2cnh1dHRGK0RiclEzbEkvYzg0OU5CNVhCaytHTHRT?= =?utf-8?B?aHlkTU5yT3BmcEpPSmNsbUFkOXlIUW5RdmVXYm5NSVlLcEtNMFducmJCOHo0?= =?utf-8?B?WlNKcDBSY2xudXE4UTUxeVBqRlExejFxQWh5L2c3Z0VCWjFwaWVJRG9BSW94?= =?utf-8?B?U0hOTHVRamgxdHRRYzJCbGE3eTN0T3p5UlNxSEZKMVlVcndPV1BCZXhUU1Zk?= =?utf-8?B?QjNiL3MrRk9ZbGQ4RitRbUtIclFqQlZRR3l4ZUx1NnFMWC9za0ZWdTA2NVN6?= =?utf-8?B?d09BNWptYVA1WHkybXo5ZHJOQzdGNEY3Ylk1T2dSTmdZc2hDY1I4Z0oxODl0?= =?utf-8?B?MWxkd1pVZ21pN1I4VjBoZ0F1VHhVaFRSS1Mvb3VWbEg3R2ZwbUZKYk1hUk9y?= =?utf-8?B?UE9IMXFwZUVCWkh2TGZYV0NSQ2IzZEhIanNjc2xmRXExbEFReEFpR3ZrT3V6?= =?utf-8?B?ZWhYRnlGbFdydnNzdnJ0MmpGMkRQTmM3ekEwWWJjTTcxTEo0R1hKbStpNG5T?= =?utf-8?B?VDZuR1VTREdkMXdncjAwQjhIelRIQnV0cGo2NTQ1OERwRVdZRkNjSWppWVRv?= =?utf-8?B?R25uSE5wemEyOTNmWjJJTVlEM1RmREVCeTdCVE1SeXJLcVhpM0JJbnRjQmY2?= =?utf-8?B?Zm03UlVlUDJ1a1VqaCtCWk0rUnZ3U1NPcC9Ba1FCcFc4VGxsdTAwZDg3ZmtI?= =?utf-8?B?K0tBN3hqTjNVTHcrbWZLQndnSUc3cDB3TVlnTUo5Y3h2VWg5Nmh0RXdyT3Ev?= =?utf-8?B?eWFJN2xZQ3I0aGFlQ1p1cHpDMCt3Sm5ZdERyeW9tSU0yU1NrRDV0NVZFVDBw?= =?utf-8?B?cmFqOEdRcUFwVFIzUkcrRlRJdUJNQ24rdG5EdlB3cllYWG8rUHRFUmNrSUZm?= =?utf-8?B?WDhMODJvaHpQNXJXUDh5K0tiVjBVc05NaStpS3pXVi9NK01wbTc2UmQ1ckhP?= =?utf-8?B?SDhaL3JWZEJ4THFGem02Z3VaOXJSNytoSlgxWXVCRGNSZS9hL0FpdUd6SXNr?= =?utf-8?B?RThYWjlTVC9FVk5iQ0Y5ak8rd1h6bGhIdzNqVHpTRDFtem14S0hGODZ2UlMr?= =?utf-8?B?Y1EyQXdWN0tyMUV4VXhDRTVDbkd3WlRwRi9CWG5SNDQwRWVEbEtFWExMY3Bn?= =?utf-8?B?c2NOTWRxendYR2pwaTZYeWg1WEIvM3YvdGFWY1YwMnZPdmR2QlNzTDJQSWZo?= =?utf-8?B?dWdsU2hGWDlCZ1NEUDFkUUYwUWVWSVN3a3hHalR4SnRUbWk4VU1jbWNQM3Vs?= =?utf-8?B?bmNtQkNvTlgvb3ZpK1ErNjdNby9xU21iTVBoS1VWS3pVd0ZQL2ZIY2tqQWhW?= =?utf-8?B?cnVtMmt0aytiZEo5bWMwdkU1L2dYTFlGa0JOb3dHaTk5RG5ydkxUdndPZlRV?= =?utf-8?B?SFVHTmZLUUZ6QzA0S3R2eUMvT2ZDazNxeG9KajduOUI5MXIzL3d3MkVZYzFF?= =?utf-8?B?WFhMUGgramtkeEtVSFZQbEY2bWVYcUhodmdpL1AwQTlET3ZPNEE1eXZVcWxF?= =?utf-8?B?N0V2OWIrZTRWa2FienZidTV4c1FLQlNOZ2xYUTVvVm02STV6MHdFK00zRlhU?= =?utf-8?B?QVVnN2Z3VmR6djlhVDhJZDFBWEM4Q3l1SGE0eWw5Z0xsVXp5bWpiQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d92fe547-61db-48ef-f138-08da38d02ae6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 13:13:15.2040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EtbJz2l4E67s+UQGf4miPWM/NshasYjD8ml7YQK/aqRRw/KTqG/5q9ubUj+XAqPD2nKYzmpQIwh/JBNE8G93fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4124 On 11.05.2022 03:46, Wei Chen wrote: > NUMA node structure "struct node" is using u64 as node memory > range. In order to make other architectures can reuse this > NUMA node relative code, we replace the u64 to paddr_t. And > use pfn_to_paddr and paddr_to_pfn to replace explicit shift > operations. The relate PRIx64 in print messages have been > replaced by PRIpaddr at the same time. And some being-phased-out > types like u64 in the lines we have touched also have been > converted to uint64_t or unsigned long. > > Tested-by: Jiamei Xie > Signed-off-by: Wei Chen Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed May 18 13:17:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:17:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332145.555791 (Exim 4.92) (envelope-from ) id 1nrJYZ-0004Xx-Kq; Wed, 18 May 2022 13:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332145.555791; Wed, 18 May 2022 13:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJYZ-0004Xq-HE; Wed, 18 May 2022 13:17:39 +0000 Received: by outflank-mailman (input) for mailman id 332145; Wed, 18 May 2022 13:17:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJYY-0004Xg-F0 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:17:38 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2aa8429-d6ac-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:17:37 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nrJY9-009xvH-Gp; Wed, 18 May 2022 15:17:13 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2aa8429-d6ac-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OR5WoGq1CiBDAgHBnMc6HRC3gZH7AlGvCLosZhpaTuo=; b=TbYUoDwLrw469UplQy2vOqzaUT pf9sYNhexiBEPGvwhLTHv/6lRpXHwZ6JfGGGGlsulYDVL6Ab6bTmmTfDu2arTCnucsnl3GTbcEJxy upUnjbTokylG1GlBlNoIFnEYhQoJuUa0AZWIVQLFFH54ECZKBuEMlIuh1SegIV664GotghzpLED+P tR0zE2dTdCcBKJ1ysKdatz+cCxii4k2F+OmNsFrEsRpmHW6NOWBwJw1oxdcsL+W3TvLq2ZgOX3GYp M0Pw2BUK0uK+s/Hb66H/45XrhqyaGuP4iDdvJd10W7kvlAK6+nwFNgEfr5ANXylTesYuPYEKJpUan NoQkEgFA==; Message-ID: Date: Wed, 18 May 2022 10:16:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek Cc: David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/05/2022 04:58, Petr Mladek wrote: > [...] >> I does similar things like kmsg_dump() so it should be called in >> the same location (after info notifier list and before kdump). >> >> A solution might be to put it at these notifiers at the very >> end of the "info" list or make extra "dump" notifier list. > > I just want to point out that the above idea has problems. > Notifiers storing kernel log need to be treated as kmsg_dump(). > In particular, we would need to know if there are any. > We do not need to call "info" notifier list before kdump > when there is no kernel log dumper registered. > Notifiers respect the priority concept, which is just a number that orders the list addition (and the list is called in order). I've used the last position to panic_print() [in patch 25] - one idea here is to "reserve" the last position (represented by INT_MIN) for notifiers that act like kmsg_dump(). I couldn't find any IIRC, but that doesn't prevent us to save this position and comment about that. Makes sense to you ? Cheers! From xen-devel-bounces@lists.xenproject.org Wed May 18 13:26:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:26:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332157.555802 (Exim 4.92) (envelope-from ) id 1nrJgc-00060m-El; Wed, 18 May 2022 13:25:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332157.555802; Wed, 18 May 2022 13:25:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJgc-00060e-BQ; Wed, 18 May 2022 13:25:58 +0000 Received: by outflank-mailman (input) for mailman id 332157; Wed, 18 May 2022 13:25:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJga-00060F-MD for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:25:56 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b7d0631-d6ae-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:25:55 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nrJg7-009yTw-Of; Wed, 18 May 2022 15:25:27 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b7d0631-d6ae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aBHSQ74cshobrBoDeAcAwH8dbmp4ORux6n0j1EJ9zhs=; b=PbQX6jJxrSTFYuY1QkUAm5HHAj 4zjhUqw9dZUmp+/h7FpyGsMd9T7KC01Lk8wihlfsVt15sYS07bd4AGqx/olI4ChlgEfTgoKgt6ghF u4Ul+3a/u8AC1yN3var2ePdBq3yJ0QNuCnzFCU2AsJ1yN+Ew0qnuNx0AKJJMSgaFsHSKjAS/RJyRX nQBP35ba/Mxst73B+b2bL1GyLemevCz0TIExKe/iFre2S2JyltNIOuuqHTXgx4xNR3AtqS8MDXev4 Htu1aPv+rb/vlxpa70azlfd8R3qZ4EjVERsEcfu9NCpHDF7PwWBcLltMr6Fz/cDtJaPv3zZndTfPs +f+vkTJA==; Message-ID: <5ed2ca7a-5bf3-f101-a1f4-9a320c79f5a0@igalia.com> Date: Wed, 18 May 2022 10:24:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek Cc: Evan Green , David Gow , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , Linux PM , Florian Fainelli , Andrew Morton , bhe@redhat.com, kexec@lists.infradead.org, LKML , linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm Mailing List , linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, Andy Shevchenko , Arnd Bergmann , Borislav Petkov , Jonathan Corbet , d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, Greg Kroah-Hartman , mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, Kees Cook , luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, Alan Stern , Thomas Gleixner , vgoyal@redhat.com, vkuznets@redhat.com, Will Deacon , Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi , Stephen Boyd References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/05/2022 04:33, Petr Mladek wrote: > [...] > Anyway, I would distinguish it the following way. > > + If the notifier is preserving kernel log then it should be ideally > treated as kmsg_dump(). > > + It the notifier is saving another debugging data then it better > fits into the "hypervisor" notifier list. > > Definitely, I agree - it's logical, since we want more info in the logs, and happens some notifiers running in the informational list do that, like ftrace_on_oops for example. > Regarding the reliability. From my POV, any panic notifier enabled > in a generic kernel should be reliable with more than 99,9%. > Otherwise, they should not be in the notifier list at all. > > An exception would be a platform-specific notifier that is > called only on some specific platform and developers maintaining > this platform agree on this. > > The value "99,9%" is arbitrary. I am not sure if it is realistic > even in the other code, for example, console_flush_on_panic() > or emergency_restart(). I just want to point out that the border > should be rather high. Otherwise we would back in the situation > where people would want to disable particular notifiers. > Totally agree, these percentages are just an example, 50% is ridiculous low reliability in my example heheh But some notifiers deep dive in abstraction layers (like regmap or GPIO stuff) and it's hard to determine the probability of a lock issue (take a spinlock already taken inside regmap code and live-lock forever, for example). These are better to run, if possible, later than kdump or even info list. Thanks again for the good analysis Petr! Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Wed May 18 13:27:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:27:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332169.555813 (Exim 4.92) (envelope-from ) id 1nrJiR-0006g8-RD; Wed, 18 May 2022 13:27:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332169.555813; Wed, 18 May 2022 13:27:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJiR-0006g1-Nm; Wed, 18 May 2022 13:27:51 +0000 Received: by outflank-mailman (input) for mailman id 332169; Wed, 18 May 2022 13:27:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJiQ-0006ft-2d for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:27:50 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ad0d84c-d6ae-11ec-837e-e5687231ffcc; Wed, 18 May 2022 15:27:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ad0d84c-d6ae-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652880467; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ami/JJ/NXiuqy6URnl3AX30woLzB9oddmX1Yk1IpAcc=; b=SxMqm1TsWWRdEY6cxabaPzgpZLKhGpMeNLNGRnS9LIiYy+AFrsIPMpGV PVVGmHp+Y12yDqWwK7WS0ntSR7MfqlCXk2aDnAiyAOaDHsjsCkEOjbJia i16urFQoFOpeIfWcWOsavjGQBcaY65l4pCpGWlYuRwLZfPed8rhpyt3QP 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74098050 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:05rS76r5DTI7A4JWT21NqEBp3uheBmJuZRIvgKrLsJaIsI4StFCzt garIBmFP6zfYDShftFzbY++pEoFvZ+DxtBiTFFqqiFnQSITopuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 IOq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHqSPwPQ+aDZiCn96Eahn27nFfVHhiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVI7zjfALADSJTKR6zM6PdT3Ssqh9AIFvHbD yYcQWUzNEWQO0AXUrsRIJ4vwLiDomv/Sh0buQmYqqk+sivDywMkhdABN/KKI4fXFK25hH2wu Wbu72n/RBYAO7S3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l6qOXuxa6PUc+V2BFRNkHl8k0GRV07 wrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6 2rSxBXSkYn/miLiO0+T2VncywyhqZHSJuLezlWGBzn1hu+ViWPMWmBJ1bQ5xasZRGp6ZgPY1 JThpyR5xLlXZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeR05a5xYJGa3O xe7VeZtCHh7ZSvCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im +ti2zyikEsDAbWjOHiOqOb+7zkidBAGOHw/kOQPHsbrH+asMDtJ5yP5qV/5R7FYog== IronPort-HdrOrdr: A9a23:NNrkDKOht+Cm9cBcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.91,234,1647316800"; d="scan'208";a="74098050" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID Date: Wed, 18 May 2022 14:27:14 +0100 Message-ID: <20220518132714.5557-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Have is_hvm_pv_evtchn_domain() return true for vector callbacks for evtchn delivery set up on a per-vCPU basis via HVMOP_set_evtchn_upcall_vector. is_hvm_pv_evtchn_domain() returning true is a condition for setting up physical IRQ to event channel mappings. Therefore, a CPUID bit is added so that guests know whether the check in is_hvm_pv_evtchn_domain() will fail when using HVMOP_set_evtchn_upcall_vector. This matters for guests that route PIRQs over event channels since is_hvm_pv_evtchn_domain() is a condition in physdev_map_pirq(). The naming of the CPUID bit is quite generic about upcall support being available. That's done so that the define name doesn't become overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some such. A guest that doesn't care about physical interrupts routed over event channels can just test for the availability of the hypercall directly (HVMOP_set_evtchn_upcall_vector) without checking the CPUID bit. Signed-off-by: Jane Malalane --- CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Wei Liu v3: * Improve commit message and title. v2: * Since the naming of the CPUID bit is quite generic, better explain when it should be checked for, in code comments and commit message. --- xen/arch/x86/include/asm/domain.h | 8 +++++++- xen/arch/x86/traps.c | 6 ++++++ xen/include/public/arch-x86/cpuid.h | 5 +++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index 35898d725f..f044e0a492 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -14,8 +14,14 @@ #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) +/* + * Set to true if either the global vector-type callback or per-vCPU + * LAPIC vectors are used. Assume all vCPUs will use + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. + */ #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) #define is_domain_direct_mapped(d) ((void)(d), 0) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 25bffe47d7..1a7f9df067 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1152,6 +1152,12 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, res->a |= XEN_HVM_CPUID_DOMID_PRESENT; res->c = d->domain_id; + /* + * Per-vCPU event channel upcalls are implemented and work + * correctly with PIRQs routed over event channels. + */ + res->a |= XEN_HVM_CPUID_UPCALL_VECTOR; + break; case 5: /* PV-specific parameters */ diff --git a/xen/include/public/arch-x86/cpuid.h b/xen/include/public/arch-x86/cpuid.h index f2b2b3632c..c49eefeaf8 100644 --- a/xen/include/public/arch-x86/cpuid.h +++ b/xen/include/public/arch-x86/cpuid.h @@ -109,6 +109,11 @@ * field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* + * Per-vCPU event channel upcalls work correctly with physical IRQs + * bound to event channels. + */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed May 18 13:30:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:30:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332178.555824 (Exim 4.92) (envelope-from ) id 1nrJlI-00088Q-D6; Wed, 18 May 2022 13:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332178.555824; Wed, 18 May 2022 13:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJlI-00088J-9m; Wed, 18 May 2022 13:30:48 +0000 Received: by outflank-mailman (input) for mailman id 332178; Wed, 18 May 2022 13:30:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJlH-00088B-45 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:30:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8e5a865-d6ae-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:30:46 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-52CYZIcoOWeLK56KO69bFQ-1; Wed, 18 May 2022 15:30:41 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8139.eurprd04.prod.outlook.com (2603:10a6:10:248::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 13:30:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 13:30:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8e5a865-d6ae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652880645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zfuZRJGHaXbHE1iSGSCOagDuMGcgcIz5rmybmP35Y8=; b=KL+jmHAabUQXLWATfGmHxjQu1dGzav/MT0nyDSKgjeg/QHcQibfZGqk8HqgnJ/i7kMVRDi q7bv3cTbvGlfDTSc2ZP4nj7LQH1z6NTd89QKdSyU/NVTsGhxbfOheeaBdO3n38p1J04EDF UcaflDR3m16ataiyxYMBUyXlZUilM64= X-MC-Unique: 52CYZIcoOWeLK56KO69bFQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YId4uIYxx2j2dIf1xAtJVlpawz8ou4yvFfG5GAR+g1t+fbb5ftqHZ3guq73PUanI0r32qBl+udXk7KjVteCl0NbHZw6BTH8VEnMbPtwhEJwX0UOr1DwW+g6eUPBIiBtc2h0i9AqDOhWUT61gGNFg5yhmkj7wtKVtmFfc9PQTRt/VhHfR/F3bgLhW29DMnijVjBKUWIN2cIPbPxgVoctk8DsJO/lhMUSXV6x2kJ547jE6mJDhjo82MZCZzPcvU3HnB11NIKyZFspc7thowiDhVgZENxmGKA/Tb5zoXR2q7zTjiPyfFCf0zYHQI24j/ZsuDZmEkpHTf+UYVJXIMkoBSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZwWP9WKr1TiKnBhwsqjwfLpGJEuh48drxaM7ZB8l/Y=; b=CUTZc+rOwsuhVLQcTaSI94Gss/FVqq+KdidzejrU58u7PTy/vgsvbicsJP/RFNTAfJUNtPLyYYyNMUG2JouFjyn4bKsnTI2jxU19oHWyusIOewjicB9nuXj0JHoKTe8hGZQwWn0PAu3Mbyt56egJ/GSXN6T1bN2fP1/x2Zo/Oi6FbWbTEawrT1s/WMo3ZTqA/lO1a4lP6ibTv1WrXhDxoJM/BuCVnxM40lmDZp7VHyLdE6YlzNEkc9MOIOXPn03k5zsJTcYyvJudqkSaRqyrb1PLLA/NsUOzyMJxmCO7nXWOvtlJqb/C6GHg9+ekPjyKho7zYsfc9oI7LG9BBHzVhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 15:30:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 8/9] xen/x86: add detection of memory interleaves for different nodes Content-Language: en-US To: Wei Chen CC: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-9-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220511014639.197825-9-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0601CA0028.eurprd06.prod.outlook.com (2603:10a6:203:68::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6bda8cdf-c9a4-4875-8b55-08da38d29986 X-MS-TrafficTypeDiagnostic: DB9PR04MB8139:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cpzdjy8uE+Wk741noQXdT45aAStbHCKEZVMeI7Cp2SPOdr3AWoiRhWHeL2+/cPjlJ9VYqcxY5SqeL23hXMmWq/s5QS1kfSQ5N9N3Yf4VkYGqgrtaVcfo9sHsUCGuqXoNhJ969w3KCE9aPe6lHYeAsezRMYVDY0zP/FoN7gYNmmriM1QTLCT3H6JPHlzBHm1b6qFY1mFIbWhclNKdezFNf2V6Enc/Cb8Z5zAKdLTG3Db0UaqIdNlJMrf3Z1xdg1BH3HyTTfhPH6uppdstwiX1z+ptq1C8qC6BrKObuAPsCVSjK3EhyaYfoYOh6bvKomHKzPmxN9hIeKfhhmkk0oYsucAUDfiTkvgIe/2/gx2RcS1X5wrPJkSkwejfuKAawajo8BnvCokkiz6iDc+7AhoDEswNmDdRFAGRd5PN0Aq6/lLudm6BZ+3/M9IKq1hyXs4OKXCEDwOXX6VLPsJd0HToXwwedn2RUFhC/b19voDP5TQG2qeSbcAoU6KhhcF/vrYN1oLiHDKLNDkm3rkLIlRVAODurMWhoM1m0RL7LgtvB1i1ciMd1xhwOPJuzbUkgjDk8O36siP+D641ab6xIYEFgU2PC688uR3M4pFWBko1P+Zw4uSgDeU5BDpYiWKX2s7f2YFrjMJ+mQg0seDZXTqF3wmJTNggCRR13hHoiaT63F6g/ftz0G671jR9462yrYatGlEEadrck4/R3A/79m4ZJNLovUGZkypDRHxEBIunW9fewEDDEgbZ0Db4m0YqfdUr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(83380400001)(6486002)(186003)(316002)(6506007)(31686004)(5660300002)(2906002)(36756003)(31696002)(54906003)(38100700002)(86362001)(4326008)(8676002)(2616005)(66556008)(66946007)(6512007)(53546011)(26005)(508600001)(66476007)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3/faVhn5f7/Zz5fxMIAhZSGJDWk0QZug38RG4JBBBrknCOV8IOL3+4YWo854?= =?us-ascii?Q?c+I4GlWzxcz2/oi8s9WsY3zuX2ffCCW/mADdpUW40ygcMLJa7DL5sKtwfTMx?= =?us-ascii?Q?FyEgCy+TUF89jSOVhBzKjbJNGM6tPLPQlHHL513CyAzmRTsNg2CKYaxSORY6?= =?us-ascii?Q?93nf0udB9unGyfxSnjbtRMrHoDpKrjLJDKvxWcynp/oMG6A8EBxjo5v1mM3N?= =?us-ascii?Q?iojB8Yh6uwwh09q8jvjguhAD3jVeCLw8N/XY+ta7m9iihiP10OX2Y2a3mJR+?= =?us-ascii?Q?5xJkCtfz8WU0ZOQKjB1LdKT2Kq97HhfLLEUdafBJtxlXoJlEfWJQo0a2pwzS?= =?us-ascii?Q?Jh4uCAdmZGp5GfTk3rCFQ1zcUy6Qo4jQq9zcrk3gj95LWpyzJWZLnU23JLLf?= =?us-ascii?Q?tSB9/cLdmxFockhI2XkBC8vcwlxtwFHduKeKwciFg67ZdqdDnfCknYiM47wP?= =?us-ascii?Q?o94XY66jyeHUTYc0XAN85if0/5/hPesmAxbN92jwbE9McZY9PWoLfVemWbVF?= =?us-ascii?Q?UqBbyep0gNzbsv7MOqlYtQRFaErCdcee4b1kgSLnHqH6+PX4w3g+CL2NgKPj?= =?us-ascii?Q?gE8J10/P+YQ4snpxRI0FGa+vKlWfXI66SGRvUWeF2z6swossK7iRWOD72MGd?= =?us-ascii?Q?icNlMT30vOCV5jEIsADVH7/Opj/yvKUiGvJvtkFMBM++IBe8zV8o51zUNq21?= =?us-ascii?Q?GFfi8Qu+TVdAsYz/Ffvzq+GGVJGkv3nftKGntllD4UL1D5Kd/7IAheIWtK79?= =?us-ascii?Q?Q/S4zJyb5o6SYjIvBV1QMaG16gVeInBH2sbfAZSFYmVvA/YV4N/E4NYfK4mj?= =?us-ascii?Q?ex11SaP1dl5FvzMPTsht6YfoYbNQiQoptJBi0HC0SvYV/Q41TntzIXmhsK6P?= =?us-ascii?Q?58NpnvuHFAUsp4kqcV48Vko9BOsdtcrKTj5a+GWNJe50Ts2sq+Nse88ZB50M?= =?us-ascii?Q?wsuVJbKDCUjueW8lk982UkjHAynvMAkQE65QUYoz+CLDJeVDEKWO0ahovhje?= =?us-ascii?Q?fL1roIg3nhV1Wfx2CaQYvVZm1CnYtjznTTUKZtuKRB61rx0dBsRSilfui/67?= =?us-ascii?Q?r1jdLdftXHFVzHdvlRg1K2xvRgNOeqUVGQzr3LTxq6PAVkQZ3zLJeVB9jXzk?= =?us-ascii?Q?9gJCFjmHmvajq/D7isPqVNnwI053MLCFWI0GYsSDmDTq8J4WTh88skBobTyg?= =?us-ascii?Q?U0nUn9U0FZcPD2I/CwfRHfoM1R7NhLdHTyhA02Ml80HsXfzLqt5Gd4DoPhLg?= =?us-ascii?Q?G6xMX+fJvDvq1V0ppxWFRn13L1SfRFarOxeW9EJey7DFpgdhr5jS9LTcmDa1?= =?us-ascii?Q?+YHWb1KaPRAUMLM0e3sS+6ooCni1nuPKx34cakQB7xT1utwfV4PEEXLqrycL?= =?us-ascii?Q?LeBgM0ETF4b1LcdxziP79t4D/bfgGJWkv4ydreXTS+WVYlVFFb7TO/W2bq3N?= =?us-ascii?Q?Ay/yof/0lehM2lfsTdCcpdUrJztnz3hX0MFZseQ9wrJ7AR8mNEgh/wCHUf6Q?= =?us-ascii?Q?81lGa8Yi/IfeEOay4q4A5V40lNo03mFeeDp8zLNnqa2ydNjZ3FoeGgxGdsbp?= =?us-ascii?Q?nwChbcJxaP50EJiO6s4g055jtBkw++3fUIphJswict5NLp9yugyDwSWWm9pB?= =?us-ascii?Q?kuOFp610gz2yg2PfVsef6XzOjaqC9j/8N9pvN9llJ+rwBdMXJmOznmeHh9mG?= =?us-ascii?Q?XrtdP9NIF65rc/OL5PrBy9LTiHwn5E2WyfqTvfm+jfW7gqvLphav2X6hBCs1?= =?us-ascii?Q?yGO38JHC3A=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bda8cdf-c9a4-4875-8b55-08da38d29986 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 13:30:39.7771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FVsZ5X+TupkdyscZvcHXRQko0LO6h9EHFqimF7dGnyoizKXUIr/ZwImyfJ/dvqHyDv0yfRowMMaaV09A4XHP8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8139 On 11.05.2022 03:46, Wei Chen wrote: > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -42,6 +42,12 @@ static struct node node_memblk_range[NR_NODE_MEMBLKS]; > static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; > static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); > =20 > +enum conflicts { > + NO_CONFLICT =3D 0, No need for the "=3D 0". > + ERR_OVERLAP, While this at least can be an error (the self-overlap case is merely warned about), ... > + ERR_INTERLEAVE, ... I don't think this is, and hence I'd recommend to drop "ERR_". > @@ -119,20 +125,43 @@ int valid_numa_range(paddr_t start, paddr_t end, no= deid_t node) > return 0; > } > =20 > -static __init int conflicting_memblks(paddr_t start, paddr_t end) > +static enum conflicts __init > +conflicting_memblks(nodeid_t nid, paddr_t start, paddr_t end, > + paddr_t nd_start, paddr_t nd_end, int *mblkid) Why "int"? Can the value passed back be negative? > { > int i; > =20 > + /* > + * Scan all recorded nodes' memory blocks to check conflicts: > + * Overlap or interleave. > + */ > for (i =3D 0; i < num_node_memblks; i++) { > struct node *nd =3D &node_memblk_range[i]; > + *mblkid =3D i; Style: Please maintain a blank line between declaration(s) and statement(s). > @@ -310,42 +342,67 @@ acpi_numa_memory_affinity_init(const struct acpi_sr= at_mem_affinity *ma) > bad_srat(); > return; > } > + > + /* > + * For the node that already has some memory blocks, we will > + * expand the node memory range temporarily to check memory > + * interleaves with other nodes. We will not use this node > + * temp memory range to check overlaps, because it will mask > + * the overlaps in same node. > + * > + * Node with 0 bytes memory doesn't need this expandsion. > + */ > + nd_start =3D start; > + nd_end =3D end; > + nd =3D &nodes[node]; > + if (nd->start !=3D nd->end) { > + if (nd_start > nd->start) > + nd_start =3D nd->start; > + > + if (nd_end < end) Did you mean nd->end here on the right side of < ? By intentionally not adding "default:" in the body, you then also allow the compiler to point out that addition of a new enumerator also needs handling here. > + nd_end =3D nd->end; > + } > + > /* It is fine to add this area to the nodes data it will be used later*= / > - i =3D conflicting_memblks(start, end); > - if (i < 0) > - /* everything fine */; > - else if (memblk_nodeid[i] =3D=3D node) { > - bool mismatch =3D !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=3D > - !test_bit(i, memblk_hotplug); > - > - printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself = (%"PRIpaddr"-%"PRIpaddr")\n", > - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, > - node_memblk_range[i].start, node_memblk_range[i].end); > - if (mismatch) { > + status =3D conflicting_memblks(node, start, end, nd_start, nd_end, &i); > + if (status =3D=3D ERR_OVERLAP) { Please use switch(status) when checking enumerated values. > + if (memblk_nodeid[i] =3D=3D node) { > + bool mismatch =3D !(ma->flags & > + ACPI_SRAT_MEM_HOT_PLUGGABLE) !=3D > + !test_bit(i, memblk_hotplug); Style: The middle line wants indenting by two more characters. > + > + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself= (%"PRIpaddr"-%"PRIpaddr")\n", > + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, > + end, node_memblk_range[i].start, > + node_memblk_range[i].end); > + if (mismatch) { > + bad_srat(); > + return; > + } > + } else { > + printk(KERN_ERR > + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (= %"PRIpaddr"-%"PRIpaddr")\n", > + pxm, start, end, node_to_pxm(memblk_nodeid[i]), > + node_memblk_range[i].start, > + node_memblk_range[i].end); > bad_srat(); > return; > } > - } else { > + } else if (status =3D=3D ERR_INTERLEAVE) { > printk(KERN_ERR > - "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%= "PRIpaddr"-%"PRIpaddr")\n", > - pxm, start, end, node_to_pxm(memblk_nodeid[i]), > + "SRAT=EF=BC=9A Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves w= ith node %u memblk (%"PRIpaddr"-%"PRIpaddr")\n", > + node, nd_start, nd_end, memblk_nodeid[i], Please log pxm (not node) here just like is done in the overlap case. The remote node ID will then require converting to PXM, of course. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 13:34:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332187.555835 (Exim 4.92) (envelope-from ) id 1nrJoS-0000RI-Tw; Wed, 18 May 2022 13:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332187.555835; Wed, 18 May 2022 13:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJoS-0000RB-Q3; Wed, 18 May 2022 13:34:04 +0000 Received: by outflank-mailman (input) for mailman id 332187; Wed, 18 May 2022 13:34:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJoS-0000R5-18 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:34:04 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b80b023-d6af-11ec-837e-e5687231ffcc; Wed, 18 May 2022 15:33:58 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-oMsLmpMwPiqRieWDfL3EEg-1; Wed, 18 May 2022 15:34:00 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5271.eurprd04.prod.outlook.com (2603:10a6:20b:11::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 13:33:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 13:33:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b80b023-d6af-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652880842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CdpQQLFkjDvga25tn09GfvRtH8pgjQVe+5EpXeAq6ns=; b=A1gVMf8Wsk7quEFS2yGJRJtsfqaOXl3zCHHPc5hG87F6rYk06rqf8IZTpRM99wz4El1PTU ATLyxZnFrP+veXK2UvFREbdADG1Yv7xjawRvwfHtcGRub5d15ba+5Cym81AqjrpQ2fuRFE jhyzmIijnFRg7WfaZyEhJMGsDYwKNI4= X-MC-Unique: oMsLmpMwPiqRieWDfL3EEg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8w2bLx14ID5+VUdv0JKDwBuIGB8eiXN6QfkdA/nxqh92u7L3aQtnlrGvqx3Z/Pa3BhGXxnh+SNqeV/43fThdip2ZHjoCR1aaCSExPre/1fbrVwrQNKL5DaeUqxKYW/uj8YobnV/FAc3ZDlHLhV9YcgT8GGwzSMeBOasj0B418Qt2W/FOjG6sNdd3Z1h5oay7gb2SAGr+4/Q8PF9Wpqwn8RUMjATNkY5gy5+7E4zJxdmEA7szMCVe41gwWUOVc2Aocj0aHnLzjV4dudLtM2WJnl6zagVMi7qwSotYa965tYmbf6njLC1F0DqbN4Mvne13h2jHk8Era0RTYD2eOC7Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CdpQQLFkjDvga25tn09GfvRtH8pgjQVe+5EpXeAq6ns=; b=hA2AnHZwZyY4qZ7eu96DykuXigdLIj4uxMSrecUdzelJkHgdRLL344+1u4xx4W4dri2K5VZQXioaZYP+Jx9iRMSkvcpYn19v7DOPKE1s9RmfW5iMyhhg50UmnFyCMnGzhA7VMG51rXGVPOil9FsTFyqCXqkYof/OtKDZk5DyPbXXYyjcZ8PFbTzzVd+c59CGBmxYgTMwIetKC2hYAFh4FsD9oXucBg0QwIe/WTB/qYqFhI+LEhqcGvmeNY6MM+H28UGr+t35d2BEU0CZW7jiif+MFQZ24TkIyBNAIYQ7Go/WUbsz7JCcaur342F/QoLePYAxga1xD2aMKktu5THUUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 15:33:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-10-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220511014639.197825-10-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3b7c10c-2d68-4e7c-c909-08da38d31098 X-MS-TrafficTypeDiagnostic: AM6PR04MB5271:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gn53jUpYVG/zg5LogcR7NQpU1Vvnv7jlInk70rdV0kZinKntcSYFFhWnFfwwSYmD4XcYDs+CXsB56fzhnS9yY7ED/yjYgcLDwslQL4GKpgdPZrBtmN/kfSCY5cGKvYi6i9gHielWMgMR8O44AuPzSRDAh4DiXlVIWBA0eNfP5tYCseGN5J0SSMEPpUcthaNv1BafzIq+/PTYxjMF7UlMdzWYA4yve8ioEpdyhrdqsYuFTMNGCSeq/RdDs5MsRUiXt0zPixV3KVg/f8lVTNwtFPZpkpzeoy0ig0gFaMuLJL9SkGrGnhGbRgp/xiChYht7u4adB2oxE0hpvifNZ2vNqyKxjmGkOozyJ+TGc0/70kfa5gERZWeXxxyVZxbSuF3fvnptXdpcMarjyXumos3nu/VuLjULWj6GeiSHkKWUK/SzTNVfKsCXol7cBekGdnzvnsx0AUhEB7T/zivrSRQBKNFa1nr06/bmT8hmb1YuxZuxJtq2yGe9JebFVp+iWrSRr5UjCsmYQklHCSo+qI1InXWssf42Z3za84w+7BpM4MGwm7GCEZjl6wUxBvKohpoGr0Hrv/g5BibInwuP8Zo2Ojr1zE0VnDogKRuKBo6K3gY3iaQ3jrVPpB3mvMhZs2qlHrvkjMgpsNn1DTh5TpAY+uqyanxAK+CKsjdHcpUwMzRfFJWWC/nfp2dOchu6ACBNpnLsr4HNjbx1DaP0tthADH30cgzt6haYCJIOO4junOxY7/sT7ZWz2gDbVIqzURW0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6486002)(6512007)(186003)(54906003)(15650500001)(316002)(2616005)(8676002)(6916009)(8936002)(26005)(508600001)(36756003)(31686004)(2906002)(5660300002)(66476007)(83380400001)(4326008)(86362001)(53546011)(31696002)(66556008)(66946007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjhLbG9wZnVlenBFeVZCUEtZOXpzZ05zUWQ5RFkvUjZoM1EwQkZZWjFaelk3?= =?utf-8?B?ZHVoNXRNRXNLMGdvSFBsRmlEeG51V3lQT2ZaRE1SSkdaTHVNK0pMdmhPRzFn?= =?utf-8?B?Qjk1S1kyY0t5UlVFdVJzaldGY0gwZldwMHd4bnU0QzFkOUloL25hZ3hsRDBB?= =?utf-8?B?VzhVWXBpMTZnRXdwWllGaXA0c0JvQ0VySW9wK25yNmI3ZzBqMlBvRlFUVU1C?= =?utf-8?B?U3YwWE5tTHBMSFVaSmJNamVIQUNyelRPN21qdE5hSDVXRm92bWFkbVdiV0s0?= =?utf-8?B?SHl6TU16KzlUbVY2OGFWMGFxL1phUjJjamlNNkZNMUJrT2JhVmxhZElPT3BL?= =?utf-8?B?NHhybVFheHFaS2ZObEpBRk9la0NpenZpa21oeXFtaVh4cjZxT0d4SDM0SzVs?= =?utf-8?B?bkgyT0JlSHpLSFlLZHdBMUI4ekxBenlQZk9wZ1ZncHhDTy9PZ3lDTHYzNmdW?= =?utf-8?B?aTQ3SElONkdPNCtsbnRqLzl6aDlIRzZDZ1l2RkI2Umc1a1FIRTVPeUtoZ0Rp?= =?utf-8?B?S1IweVI3TlNRaHZuNVkzNm5oWHFYbXBIcVJneDJxNFFyZzlvUnRiVnoza0pP?= =?utf-8?B?Zm9QdUkzV1pGT0VtYXg2QUdWdFBXZkJUVkQrMVVaOVJ3eEl5ekNEMmZ5SHBn?= =?utf-8?B?TGhYZElZU3k3bnB5OFBzaGFra2RpRWVRYVZoM3lBbHZqeUJDUUh1QXpZOXlQ?= =?utf-8?B?TitMeFd1QkhGY1FFVmJUNlFnZUx1cUZEZHFwZHQwSyt4U3Uwd3ZueGNEZVo5?= =?utf-8?B?K3dZZWVJVzhWOEpPM2dMemFPSzVsek5lM1VJdzlsQzhsU0VtTXVCU2ZPRXFS?= =?utf-8?B?NFd1KzdEUlBJRWkzT0JCWjFuWEZNVS9sSVBKclR0TnJRUE9XMCs4MVBlMFNN?= =?utf-8?B?d0M4MWVDSmZBSU8zOWV2NW83YmhCU3UrZ3RvRGhUWW10OHlra3hIWmowOEpE?= =?utf-8?B?SXQ5Y1NtMG9vUElFQTlmdHJ4Zk5FN2F0WWp0SHM5b2ZpNVBkaEFldG9VelJE?= =?utf-8?B?U3RsRm00U3JScm1RRjk4UmQ3TjdVRnpvUGtjdHNCSXptck5YZ2xqL3NhR2FK?= =?utf-8?B?K1lyV3JpcDBjS0tFYXZhU0Mwd1krRUwxRzV5Y1pLeWEyUWMrTlowbzNGWlg4?= =?utf-8?B?U0VCamRRN1JCL3FDakszOUdCcW5ZVTJJdVoyQXhha1o1eTMrcGFEMForR0Iz?= =?utf-8?B?aG1vTUUzTVFhQng3YXIranl0QndtNFJBL0UvbWRSWlkwSWlGT0pSWGV4QjRI?= =?utf-8?B?RWhnVllRL01GbHl4Wnpxei9CMGNhTTVhTllzalBmeVBuWWpPbWczdUwyeGFy?= =?utf-8?B?R1c2Ny9XRGpEQUhBY0VJNVA2cU53QVU2UWJzWDd1NmR5bGV2NkhxMDVUdGs0?= =?utf-8?B?Zk1UZk1uRUhtNzFzZ1NqaDFzMDkxU01sR2hUV2Q3WjFiejkrNmVFQTlqRUVI?= =?utf-8?B?MFVkckphTVpSQ0ZQN21yZmF6ZUFCQmFER2tob2UwZUFkdytETmhNM09BVHY2?= =?utf-8?B?UGFqYXk4K2xybE1JbWcvQVd3L3hwbHVhOVA2OEdNdXFyTFRiYlF2cjVScnJK?= =?utf-8?B?ZjVpLzF3QXJaNTZ6aUpGWGdsUEVGRUFuRktITFNFTVhiQ0dYQjIrdVYweVQz?= =?utf-8?B?U0RINk9yeWNwNW9aNWNvSVZycnRwSlZFTzdyVjFPOEo3QSt0VWg0STBIT25X?= =?utf-8?B?YUNaNVpBaXNSSGFMQnFGYXFPZmpEV3hkVGJkelYyZ3JwUHJhKzZ1eWNRdWVP?= =?utf-8?B?bEdtVndBbGpkUGF4ZlduQzczQlM2M1VpbGgzSFhoOWhmdVVwcm1xVTh1eTk0?= =?utf-8?B?VFJYWUFUQnIrdnN6NlpNUTlxZFdYN292RDhYRmhoK2I5Z0Q0M2JRNGxteGhR?= =?utf-8?B?QkFsWDNaRFpLeDFyT1d6aEc1UW1JeC9ScHdTT1VPb3N2TkhyaTMwSEtSaGVy?= =?utf-8?B?YUVSdGxNK1g3R0RkbStBdHhLcXlMdU9sUlpKNkNZeG4rVHczd0txejFQZm9u?= =?utf-8?B?bU9qNU5OT2JGTloyUXVjaCtPN1JWYlFISVU4MVFuMHFrMjdEN3Q0SDhlNlVm?= =?utf-8?B?M01MYm8wbUlsU1NIc0tlTjNmYldKdXZjeEF4VVlTQTRjcXlCQVdhVHJSTk1P?= =?utf-8?B?aHNoVnFaemFFOTMyRUZ4TmR3cmtaSUo1elJxakdmZll6L2Q1ZkFlaXVJeTQ1?= =?utf-8?B?dXRZL2NDSDE3UTJLQnRWTUxCMGV0bk82b2k5K21JS3plSGpiYXMvc3BKczg3?= =?utf-8?B?d2NRS1BBa2hzOFkwZFowTkNjanQzbVA4TVlVU0pQOHFkenpCWWRkbmxxbElR?= =?utf-8?B?VGJSK3Y2V3dvTG50a1BROVgwamlQZWlxb1FnQ1dpUWIvRmFDamNHZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3b7c10c-2d68-4e7c-c909-08da38d31098 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 13:33:59.5455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rAYw+505TJFaJpWuh+oDWQjDQQqlV/pxbMZH9yDLGaj8ze9c2wDkN8m9mWHN+sws35upT3ALyV+Tr+u/dA+Ltw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5271 On 11.05.2022 03:46, Wei Chen wrote: > In previous code, Xen was using KERN_WARNING for log message > when Xen found a node without memory. Xen will print this > warning message, and said that this may be an BIOS Bug or > mis-configured hardware. But actually, this warning is bogus, > because in an NUMA setting, nodes can only have processors, > and with 0 bytes memory. So it is unreasonable to warn about > BIOS or hardware corruption based on the detection of node > with 0 bytes memory. > > So in this patch, we remove the warning messages, but just > keep an info message to info users that there is one or more > nodes with 0 bytes memory in the system. > > Signed-off-by: Wei Chen Reviewed-by: Jan Beulich preferably with ... > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) > uint64_t size = nodes[i].end - nodes[i].start; > > if ( size == 0 ) > - printk(KERN_WARNING "SRAT: Node %u has no memory. " > - "BIOS Bug or mis-configured hardware?\n", i); > + printk(KERN_INFO "SRAT: Node %u has no memory.\n", i); ... the full stop also dropped (and maybe the upper-case N converted to lower-case). Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 13:37:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:37:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332195.555845 (Exim 4.92) (envelope-from ) id 1nrJro-00012x-Do; Wed, 18 May 2022 13:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332195.555845; Wed, 18 May 2022 13:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJro-00012q-AW; Wed, 18 May 2022 13:37:32 +0000 Received: by outflank-mailman (input) for mailman id 332195; Wed, 18 May 2022 13:37:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJrn-00012g-DD; Wed, 18 May 2022 13:37:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJrn-0005SP-A3; Wed, 18 May 2022 13:37:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJrm-0003kJ-Qy; Wed, 18 May 2022 13:37:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrJrm-0001e4-QX; Wed, 18 May 2022 13:37:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dia/WzvQ1iot4SrT946yqNm46I0FU6xWb2TvVo5GrAs=; b=5uRlvN9NvKYhg1+sW7oif3uhqH iWqnx7T/frlh+tU07k8TFDHPD7rQewltpUWe7M/0s1YLpwUID8ysgvtcxVNBe/nrc/fjAZHQgamEw 7A+hYP2TGZ2Hy/ii7eeNeV5pdYaNgVUIR3Tz2rfmwhq535VhU4xZOY4hTdZ7xM8QR1zU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170538: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 13:37:30 +0000 flight 170538 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170538/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1084 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 103 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 13:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332206.555857 (Exim 4.92) (envelope-from ) id 1nrJxk-0002dX-Ch; Wed, 18 May 2022 13:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332206.555857; Wed, 18 May 2022 13:43:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJxk-0002dQ-9C; Wed, 18 May 2022 13:43:40 +0000 Received: by outflank-mailman (input) for mailman id 332206; Wed, 18 May 2022 13:43:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJxi-0002dG-VD; Wed, 18 May 2022 13:43:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJxi-0005YH-U6; Wed, 18 May 2022 13:43:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJxi-0003tm-IX; Wed, 18 May 2022 13:43:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrJxi-0007yL-I5; Wed, 18 May 2022 13:43:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=STd8aV5YkNotkXLySRyLoTnMYT1zAvHCSq3zt6PUO9s=; b=dtswwz35v1QrWnDh9hwOebFagn 0pRLdOmEUkBfIvDLEf9q3GIwALwFVOUppzxaF/RL+ZqTj7xGB/oiZGSTrqYizgdicBsnoGtitrUB+ XHI/2qhyOObFNOojSJJ+VjaCyA9JXV8iFIj6WDRmxxnd4PPsV3GxDRCDrCT/3tKZugaw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170535: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=25c160a74f4489f031ac79a24078cc12efd5c96b X-Osstest-Versions-That: xen=69589c374a92d1b4f97db24623e5f760990eaf82 From: osstest service owner Date: Wed, 18 May 2022 13:43:38 +0000 flight 170535 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170535/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 25c160a74f4489f031ac79a24078cc12efd5c96b baseline version: xen 69589c374a92d1b4f97db24623e5f760990eaf82 Last test of basis 170514 2022-05-17 18:00:25 Z 0 days Testing same since 170535 2022-05-18 10:01:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Marek Marczykowski-Górecki Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 69589c374a..25c160a74f 25c160a74f4489f031ac79a24078cc12efd5c96b -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 18 13:45:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 13:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332216.555868 (Exim 4.92) (envelope-from ) id 1nrJzM-0003DD-Pw; Wed, 18 May 2022 13:45:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332216.555868; Wed, 18 May 2022 13:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJzM-0003D6-M6; Wed, 18 May 2022 13:45:20 +0000 Received: by outflank-mailman (input) for mailman id 332216; Wed, 18 May 2022 13:45:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrJzK-0003Cw-Gm for xen-devel@lists.xenproject.org; Wed, 18 May 2022 13:45:19 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:e::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf07e5a2-d6b0-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 15:45:16 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrJzC-002LqV-JH; Wed, 18 May 2022 13:45:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf07e5a2-d6b0-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zHCFhRbJ5KoBP25J/EVA30nZjwejxa0UyBXdd6YAaF4=; b=OfkWNCZWsoLrWqd56zXTPhczAR Xu6/rWTNKrHA5cVITymYCU7C4/BuduKoFrwDVkllDtDmTwQwvpwjUrpdfRvTvtZo8yvfgrRuSRptz dGZzY66n3hdKJFC0dVStt35QHnrIiK2a4cQzs1nuLJ6CLQydPerstjr5JbjRj7wd7gXMeR4XR6Fyl lTd2H2/zzj/WYjDnSh3AMB/sqU3wUqKqGTptHwfo0ecsQnNijGsQ3L3sW4OrscH+mwB3FG0Q48r3G KNYWIuEvYvH1LmuYE5O//C/SHYngGuQagyk3HMLrbcTMYU/L6AP1FKnFK27sU4snqP8olMxHVwBBt SSqd4aWA==; Date: Wed, 18 May 2022 06:45:10 -0700 From: Christoph Hellwig To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Message-ID: References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503132207.17234-3-jgross@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, May 03, 2022 at 03:22:07PM +0200, Juergen Gross wrote: > Some drivers are using pat_enabled() in order to test availability of > special caching modes (WC and UC-). This will lead to false negatives > in case the system was booted e.g. with the "nopat" variant and the > BIOS did setup the PAT MSR supporting the queried mode, or if the > system is running as a Xen PV guest. > > Add test functions for those caching modes instead and use them at the > appropriate places. > > For symmetry reasons export the already existing x86_has_pat_wp() for > modules, too. No, we never export unused functionality. From xen-devel-bounces@lists.xenproject.org Wed May 18 14:12:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:12:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332228.555879 (Exim 4.92) (envelope-from ) id 1nrKPq-0006jq-0P; Wed, 18 May 2022 14:12:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332228.555879; Wed, 18 May 2022 14:12:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKPp-0006jj-T3; Wed, 18 May 2022 14:12:41 +0000 Received: by outflank-mailman (input) for mailman id 332228; Wed, 18 May 2022 14:12:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKPo-0006jd-Lg for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:12:40 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92807625-d6b4-11ec-837e-e5687231ffcc; Wed, 18 May 2022 16:12:38 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id d15so3878313lfk.5 for ; Wed, 18 May 2022 07:12:38 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id v8-20020ac25608000000b0047255d211absm221374lfd.218.2022.05.18.07.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 07:12:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92807625-d6b4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=zUpra34RHpxyR0Ls3UM9NaIwGbYcisrFEnw8bjZ1+nY=; b=pyUBTpeyMaggkxd4bHlKItfgOSbzEa6zzDLbSMbbVWbXDHlxl6M7pzMumi64afvyYP k/h49AGTStKVVKax+VEoTLbr85i7u5VjBFXxnd85wPhRAvoPXv8ms98ptCoDu6wAMKRw 1WT6BaloTu/JPWlqn9v1z4MCeQJnGZyLGByJO7MtTLr7qebyPt0v8yoGcxhmpX/QvfLQ JN3kL8smxfOGZqC4Bsj0XqjKrHLTjov0TkbKHvf4/L0zVjtlxYA6Eo2tra8FlawDvL+l BCrjPpLoQtrzbSkMc2k5L8fenGmWJLBk9sp8gtZOQZ/YO3Ls77mv+tX3eWFyLyqW5zRt 77PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zUpra34RHpxyR0Ls3UM9NaIwGbYcisrFEnw8bjZ1+nY=; b=jfCaWPWuXZ7hjb1O0xKh20SR6nHxFvopijm5WIkCXlpFhDMJQ1CnxxvD+qBNijCYyY 86g5jUq4TVhvSjAH9XKaR4961Qds0jTb1k0HbeMbQbMSlV8SHnA3SwQyB/5lcuNainzJ 5/TBaT3MThqB4n0nWVRITqcK6E7oDSICG+zA9DFfpowaWdbdrC1xCcROAiFaONGV5bXA rA/6LgTuL0sBTPMe2DmXJt5CObWT2YeHKhj++DL6lLUyKXc2lR63QkrMQvvCLEYxIxqR yo6tNkhcI4LIF5qcdFFh8D5inp/rNAEVE0W/5VR0S2Se5i/8FOtlDMDXLZa+AOq0Posi sPdg== X-Gm-Message-State: AOAM530iEtKO5GFTdw6B8xllKjb+yRCN8saDdfT5XGMKg9W9cNPgQpR2 Qi35Yc74PvQrtBXj1II1yUA= X-Google-Smtp-Source: ABdhPJzp2tFmfVthOY9fdufPSFAz0WW8seYKWhdyy781iXWupDbYQ/8o7UbHzRqy48Qzm/hT285VZg== X-Received: by 2002:a05:6512:31c3:b0:473:e6ef:368d with SMTP id j3-20020a05651231c300b00473e6ef368dmr20602037lfe.141.1652883157723; Wed, 18 May 2022 07:12:37 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Rob Herring , Juergen Gross , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <20220517002750.GA3638680-robh@kernel.org> From: Oleksandr Message-ID: Date: Wed, 18 May 2022 17:12:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220517002750.GA3638680-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 17.05.22 03:27, Rob Herring wrote: Hello Rob, all > On Sat, May 07, 2022 at 09:19:06PM +0300, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Introduce Xen specific binding for the virtualized device (e.g. virtio) >> to be used by Xen grant DMA-mapping layer in the subsequent commit. >> >> This binding indicates that Xen grant mappings scheme needs to be >> enabled for the device which DT node contains that property and specifies >> the ID of Xen domain where the corresponding backend resides. The ID >> (domid) is used as an argument to the grant mapping APIs. >> >> This is needed for the option to restrict memory access using Xen grant >> mappings to work which primary goal is to enable using virtio devices >> in Xen guests. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> Changes RFC -> V1: >> - update commit subject/description and text in description >> - move to devicetree/bindings/arm/ >> >> Changes V1 -> V2: >> - update text in description >> - change the maintainer of the binding >> - fix validation issue >> - reference xen,dev-domid.yaml schema from virtio/mmio.yaml >> --- >> .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ >> Documentation/devicetree/bindings/virtio/mmio.yaml | 7 ++++ >> 2 files changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> new file mode 100644 >> index 00000000..750e89e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific binding for virtualized devices (e.g. virtio) >> + >> +maintainers: >> + - Stefano Stabellini >> + >> +select: true > Omit. No need to apply this on every single node. ok, will do > >> + >> +description: >> + This binding indicates that Xen grant mappings need to be enabled for >> + the device, and it specifies the ID of the domain where the corresponding >> + device (backend) resides. The property is required to restrict memory >> + access using Xen grant mappings. >> + >> +properties: >> + xen,dev-domid: > I kind of think 'dev' is redundant. Is there another kind of domid > possible? In general, yes. It is driver(frontend) domid. But, at least for now, I don't see why we will need an additional property for that. > Maybe xen,backend-domid or just xen,domid? I don't know Xen > too well, so ultimately up to you all. xen,domid sounds ambiguous to me. xen,backend-domid sounds perfectly fine to me, I even think it fits better. Stefano, Juergen, would you be happy with new xen,backend-domid name? If yes, Stefano could you please clarify, would you be OK if I retained your R-b tags (for all patches in current series which touch that property) after doing such renaming? > >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The domid (domain ID) of the domain where the device (backend) is running. >> + >> +additionalProperties: true >> + >> +examples: >> + - | >> + virtio@3000 { >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The device is located in Xen domain with ID 1 */ >> + xen,dev-domid = <1>; >> + }; >> diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml >> index 10c22b5..29a0932 100644 >> --- a/Documentation/devicetree/bindings/virtio/mmio.yaml >> +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml >> @@ -13,6 +13,9 @@ description: >> See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for >> more details. >> >> +allOf: >> + - $ref: /schemas/arm/xen,dev-domid.yaml# >> + >> properties: >> compatible: >> const: virtio,mmio >> @@ -33,6 +36,10 @@ properties: >> description: Required for devices making accesses thru an IOMMU. >> maxItems: 1 >> >> + xen,dev-domid: >> + description: Required when Xen grant mappings need to be enabled for device. >> + $ref: /schemas/types.yaml#/definitions/uint32 > No need to define the type again nor describe it again. > > Instead, just change additionalProperties to unevaluateProperties in > this doc. The diff is the latter takes $ref's into account. ok, will do. Could you please clarify, shall I use? unevaluatedProperties: false or unevaluatedProperties: type: object I am not too familiar with this stuff. Both variants seem to pass validation. Thank you. > >> + >> required: >> - compatible >> - reg >> -- >> 2.7.4 >> >> -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 18 14:15:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:15:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332236.555889 (Exim 4.92) (envelope-from ) id 1nrKSx-0007M6-Fd; Wed, 18 May 2022 14:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332236.555889; Wed, 18 May 2022 14:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKSx-0007Lz-Ch; Wed, 18 May 2022 14:15:55 +0000 Received: by outflank-mailman (input) for mailman id 332236; Wed, 18 May 2022 14:15:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKSw-0007Lt-3m for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:15:54 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 069e556c-d6b5-11ec-837e-e5687231ffcc; Wed, 18 May 2022 16:15:53 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id r23so2944825wrr.2 for ; Wed, 18 May 2022 07:15:53 -0700 (PDT) Received: from [10.7.237.10] (54-240-197-226.amazon.com. [54.240.197.226]) by smtp.gmail.com with ESMTPSA id c3-20020adfa703000000b0020d012692dbsm2612394wrd.18.2022.05.18.07.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 07:15:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 069e556c-d6b5-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d7pEXmTo1+jiC7c+dMQN/V6wcBYB/n6I1A9uTMxvqzc=; b=SpXrkSX72TbuPz7ojR/Ldx05LOgm+AGpVQbA7WJnZBm2bg6FPwO5ACMYPgYxA4kc87 ohtP2rmJ31797NxKKHkKst5jtttgQHwsqsaud/nBWe2M19FGsKasgCa2XLDsoddIFaeA 9UVfQJbCG5K4a064/Nl5fSID2RpHnrvP0ZttXbypIZffVYVievJkeezfCKRPaVWtUSUi BbeHpEaBpJteBFb/9es4xEwOO741NuVP9vokDl9D1+dCuoW7T2vLYx140ttkA/lpnp5l 7sIL0Pi2ZpmHFk4Dk0XBl7BFve9Fxkqw4vcwxY02qp4Ls44CAXCQ7IrhP02UCd6GhzXq tJ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=d7pEXmTo1+jiC7c+dMQN/V6wcBYB/n6I1A9uTMxvqzc=; b=MnMnPwMMZEqguG9HmRK4TLV2k1ayrhNxxbuAedpZhxqWv1FXsuu/KDlT7YbdbYKomV AU2uoLkK498aMC9xmJlor6ADtrEBCmxiCxVgKPvBDCGvtkyCiU5ItjdnsqLQr/jTi51W ybq8/KzqsSj1QZMpI/3Bu6VN8bky6dzZci8krsRxpJrH06js4UgVoFRNjS/gTtoLPBvK ssJZnX0nVqq8EAd44a11CaseBjx0szqeJ+0rkhYAMTGhaddjDmQv32ETI515Vp50j4U/ OdOlSiwhlFK19hbK8DGFC7px3W8hqGlX6dbyQST6LnroVpE+Ggat9849ANPRDp9ioiAN opGA== X-Gm-Message-State: AOAM533gyvkKPcRw5jqcOocDuZoD3FKpzYL6jhL5Vdjhts2QRR/KpJr3 rSiKpFfmDzZyDjN3wKq+dZI= X-Google-Smtp-Source: ABdhPJzmThoM72mKnHEu4QLQg1pD5emjxOEDlYr9k77eHYKaKqSy9x9l3kGrAdZArAWXoyZniGuv5Q== X-Received: by 2002:a05:6000:1868:b0:20c:95c4:ed9a with SMTP id d8-20020a056000186800b0020c95c4ed9amr23219040wri.243.1652883352673; Wed, 18 May 2022 07:15:52 -0700 (PDT) Message-ID: Date: Wed, 18 May 2022 15:15:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Reply-To: paul@xen.org Subject: Re: [PATCH] block: get rid of blk->guest_block_size Content-Language: en-US To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paul Durrant , Stefano Stabellini , John Snow , Paolo Bonzini , "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, Fam Zheng , Anthony Perard , Kevin Wolf , Hanna Reitz , Coiby Xu , Xie Yongji References: <20220518130945.2657905-1-stefanha@redhat.com> From: "Durrant, Paul" In-Reply-To: <20220518130945.2657905-1-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/05/2022 14:09, Stefan Hajnoczi wrote: > Commit 1b7fd729559c ("block: rename buffer_alignment to > guest_block_size") noted: > > At this point, the field is set by the device emulation, but completely > ignored by the block layer. > > The last time the value of buffer_alignment/guest_block_size was > actually used was before commit 339064d50639 ("block: Don't use guest > sector size for qemu_blockalign()"). > > This value has not been used since 2013. Get rid of it. > > Cc: Xie Yongji > Signed-off-by: Stefan Hajnoczi Xen part... Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed May 18 14:28:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:28:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332244.555901 (Exim 4.92) (envelope-from ) id 1nrKea-0000Ty-H2; Wed, 18 May 2022 14:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332244.555901; Wed, 18 May 2022 14:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKea-0000Tr-Dp; Wed, 18 May 2022 14:27:56 +0000 Received: by outflank-mailman (input) for mailman id 332244; Wed, 18 May 2022 14:27:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKeZ-0000Ti-DW for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:27:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b421acbc-d6b6-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 16:27:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3769321B83; Wed, 18 May 2022 14:27:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 15BC5133F5; Wed, 18 May 2022 14:27:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vxMxA2kChWJmLgAAMHmgww (envelope-from ); Wed, 18 May 2022 14:27:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b421acbc-d6b6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652884073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+LpNjiIrXuvwJPjUcayiJhAb12XiRbtZWzMe2TKNWA=; b=I7on6FGcZfmklbVEUrAMrye7as4QNCXeDwX5s9CH6ImzrlETNzLV6hlOOeQXQBNB4UvKry a8CZZDU2YQob80wl1N1n3XW7rHpqIRIvAs+eVV1bY/seMOcUJ0Gu5qv8IMlDAO7nw9wqrz UwOo/NHk1J6qDNFz+oFdQPc6rvK7caw= Message-ID: <6e5bb72f-6387-44ce-b7cc-de00c6a5acd3@suse.com> Date: Wed, 18 May 2022 16:27:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3] tools/libs/light: update xenstore entry when setting max domain memory Content-Language: en-US To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20220502084729.13044-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220502084729.13044-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WTOV6WYDBaysB1n2XKvBUQ0Z" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WTOV6WYDBaysB1n2XKvBUQ0Z Content-Type: multipart/mixed; boundary="------------zFYuwJb08Hv2UydumHymna0U"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <6e5bb72f-6387-44ce-b7cc-de00c6a5acd3@suse.com> Subject: Re: [PATCH v3] tools/libs/light: update xenstore entry when setting max domain memory References: <20220502084729.13044-1-jgross@suse.com> In-Reply-To: <20220502084729.13044-1-jgross@suse.com> --------------zFYuwJb08Hv2UydumHymna0U Content-Type: multipart/mixed; boundary="------------NC0dd10ljWM0NpliYitORjVH" --------------NC0dd10ljWM0NpliYitORjVH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 UGluZz8NCg0KT24gMDIuMDUuMjIgMTA6NDcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IGxp YnhsX2RvbWFpbl9zZXRtYXhtZW0oKSBjYWxsZWQgZHVyaW5nICJ4bCBtZW0tbWF4IiBzaG91 bGQgdXBkYXRlIHRoZQ0KPiBkb21haW4ncyBtZW1vcnkvc3RhdGljLW1heCBYZW5zdG9yZSBu b2RlLCBhcyBvdGhlcndpc2UgInhsIG1lbS1zZXQiDQo+IHdvbid0IGJlIGFibGUgdG8gc2V0 IHRoZSBtZW1vcnkgc2l6ZSB0byB0aGUgbmV3IG1heGltdW0uDQo+IA0KPiBBZGp1c3QgdGhl IHJlbGF0ZWQgY29tbWVudHMgYW5kIGRvY3VtZW50YXRpb24gYWNjb3JkaW5nbHkuDQo+IA0K PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IC0t LQ0KPiBWMjoNCj4gLSBhZGp1c3QgY29tbWVudHMgYW5kIGRvY3MgKEFudGhvbnkgUGVyYXJk KQ0KPiBWMzoNCj4gLSByZWFsbHkgYWRqdXN0IHRoZSBkb2NzIChBbnRob255IFBlcmFyZCkN Cj4gLS0tDQo+ICAgZG9jcy9tYW4veGwuMS5wb2QuaW4gICAgICAgICB8IDExICsrKysrLS0t LS0tDQo+ICAgdG9vbHMvbGlicy9saWdodC9saWJ4bF9tZW0uYyB8IDEyICsrKysrKysrKyst LQ0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo LSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kb2NzL21hbi94bC4xLnBvZC5pbiBiL2RvY3MvbWFu L3hsLjEucG9kLmluDQo+IGluZGV4IGUyMTc2YmQ2OTYuLjEwMWUxNDI0MWQgMTAwNjQ0DQo+ IC0tLSBhL2RvY3MvbWFuL3hsLjEucG9kLmluDQo+ICsrKyBiL2RvY3MvbWFuL3hsLjEucG9k LmluDQo+IEBAIC00NDIsMTUgKzQ0MiwxNCBAQCBhbGxvY2F0ZS4NCj4gICBUaGUgZGVmYXVs dCB1bml0IGlzIGtpQi4gIEFkZCAndCcgZm9yIFRpQiwgJ2cnIGZvciBHaUIsICdtJyBmb3IN Cj4gICBNaUIsICdrJyBmb3Iga2lCLCBhbmQgJ2InIGZvciBieXRlcyAoZS5nLiwgYDIwNDht YCBmb3IgMjA0OCBNaUIpLg0KPiAgIA0KPiAtTkIgdGhhdCB1c2VycyBub3JtYWxseSBzaG91 bGRuJ3QgbmVlZCB0aGlzIGNvbW1hbmQ7IEI8eGwgbWVtLXNldD4gd2lsbA0KPiAtc2V0IHRo aXMgYXMgYXBwcm9wcmlhdGUgYXV0b21hdGljYWxseS4NCj4gLQ0KPiAgIEk8bWVtPiBjYW4n dCBiZSBzZXQgbG93ZXIgdGhhbiB0aGUgY3VycmVudCBtZW1vcnkgdGFyZ2V0IGZvcg0KPiAg IEk8ZG9tYWluLWlkPi4gIEl0IGlzIGFsbG93ZWQgdG8gYmUgaGlnaGVyIHRoYW4gdGhlIGNv bmZpZ3VyZWQgbWF4aW11bQ0KPiAgIG1lbW9yeSBzaXplIG9mIHRoZSBkb21haW4gKEI8bWF4 bWVtPiBwYXJhbWV0ZXIgaW4gdGhlIGRvbWFpbidzDQo+IC1jb25maWd1cmF0aW9uKS4gTm90 ZSBob3dldmVyIHRoYXQgdGhlIGluaXRpYWwgQjxtYXhtZW0+IHZhbHVlIGlzIHN0aWxsDQo+ IC11c2VkIGFzIGFuIHVwcGVyIGxpbWl0IGZvciBCPHhsIG1lbS1zZXQ+LiAgQWxzbyBub3Rl IHRoYXQgY2FsbGluZyBCPHhsDQo+IC1tZW0tc2V0PiB3aWxsIHJlc2V0IHRoaXMgdmFsdWUu DQo+ICtjb25maWd1cmF0aW9uKS4NCj4gKw0KPiArU2V0dGluZyB0aGUgbWF4aW11bSBtZW1v cnkgc2l6ZSBhYm92ZSB0aGUgY29uZmlndXJlZCBtYXhpbXVtIG1lbW9yeSBzaXplDQo+ICt3 aWxsIHJlcXVpcmUgc3BlY2lhbCBndWVzdCBzdXBwb3J0IChtZW1vcnkgaG90cGx1ZykgaW4g b3JkZXIgdG8gYmUgdXNhYmxlDQo+ICtieSB0aGUgZ3Vlc3QuDQo+ICAgDQo+ICAgVGhlIGRv bWFpbiB3aWxsIG5vdCByZWNlaXZlIGFueSBzaWduYWwgcmVnYXJkaW5nIHRoZSBjaGFuZ2Vk IG1lbW9yeQ0KPiAgIGxpbWl0Lg0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9tZW0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfbWVtLmMNCj4gaW5kZXggYzcz OWQwMGYzOS4uOTJlYzA5ZjRjZiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9tZW0uYw0KPiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX21lbS5jDQo+IEBA IC0yMCw4ICsyMCw3IEBADQo+ICAgLyoNCj4gICAgKiBTZXQgdGhlIG1heGltdW0gbWVtb3J5 IHNpemUgb2YgdGhlIGRvbWFpbiBpbiB0aGUgaHlwZXJ2aXNvci4gVGhlcmUgaXMgbm8NCj4g ICAgKiBjaGFuZ2Ugb2YgdGhlIGN1cnJlbnQgbWVtb3J5IHNpemUgaW52b2x2ZWQuIFRoZSBz cGVjaWZpZWQgbWVtb3J5IHNpemUgY2FuDQo+IC0gKiBldmVuIGJlIGFib3ZlIHRoZSBjb25m aWd1cmVkIG1heG1lbSBzaXplIG9mIHRoZSBkb21haW4sIGJ1dCB0aGUgcmVsYXRlZA0KPiAt ICogWGVuc3RvcmUgZW50cnkgbWVtb3J5L3N0YXRpYy1tYXggaXNuJ3QgbW9kaWZpZWQhDQo+ ICsgKiBldmVuIGJlIGFib3ZlIHRoZSBjb25maWd1cmVkIG1heG1lbSBzaXplIG9mIHRoZSBk b21haW4uDQo+ICAgICovDQo+ICAgaW50IGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0obGlieGxf Y3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLCB1aW50NjRfdCBtYXhfbWVta2IpDQo+ICAgew0K PiBAQCAtODIsNiArODEsMTUgQEAgaW50IGxpYnhsX2RvbWFpbl9zZXRtYXhtZW0obGlieGxf Y3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLCB1aW50NjRfdCBtYXhfbWVta2IpDQo+ICAgICAg ICAgICBnb3RvIG91dDsNCj4gICAgICAgfQ0KPiAgIA0KPiArICAgIHJjID0gbGlieGxfX3hz X3ByaW50ZihnYywgWEJUX05VTEwsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIEdD U1BSSU5URigiJXMvbWVtb3J5L3N0YXRpYy1tYXgiLCBkb21wYXRoKSwNCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIiUiUFJJdTY0LCBtYXhfbWVta2IpOw0KPiArICAgIGlmIChy YyAhPSAwKSB7DQo+ICsgICAgICAgIExPR0VEKEVSUk9SLCBkb21pZCwgIkNvdWxkbid0IHNl dCAlcy9tZW1vcnkvc3RhdGljLW1heCwgcmM9JWRcbiIsDQo+ICsgICAgICAgICAgICAgIGRv bXBhdGgsIHJjKTsNCj4gKyAgICAgICAgZ290byBvdXQ7DQo+ICsgICAgfQ0KPiArDQo+ICAg ICAgIHJjID0gMDsNCj4gICBvdXQ6DQo+ICAgICAgIGxpYnhsX2RvbWFpbl9jb25maWdfZGlz cG9zZSgmZF9jb25maWcpOw0KDQo= --------------NC0dd10ljWM0NpliYitORjVH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------NC0dd10ljWM0NpliYitORjVH-- --------------zFYuwJb08Hv2UydumHymna0U-- --------------WTOV6WYDBaysB1n2XKvBUQ0Z Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKFAmgFAwAAAAAACgkQsN6d1ii/Ey/1 jQf/QjkQV3alsj9fl1fYx6wL6qd5Ql0Uj5s6GxcPyXJe4ESN5/pMKJJrjO1Srz4ZNsAkGqv16vXG HEaR0ElSXqfKKQwOc+u1HQdoy3cUZ30gXDSUlrd1R87lzLq6stPEr2V7kRsapaoaoaot/CJSHJh+ gbx/YwSkfdVJ99WLI3T0/ngj15zxdgtvAKJLHHsMSYCBBTJvpPs7bAJER/o+H/XStG3t3RqBOn3U Xqz4fum4PWa84Kxz1Pjp7czGe4MRiGit/TArhsHY+4q55h5uhm/uzZFbQ8LTsjFqKWXzOyzUJQ8f a09L5xxhvKZmWQFi91Wzo/LIXBWnTF8c2F3lrP8SDg== =Rpcy -----END PGP SIGNATURE----- --------------WTOV6WYDBaysB1n2XKvBUQ0Z-- From xen-devel-bounces@lists.xenproject.org Wed May 18 14:32:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332253.555912 (Exim 4.92) (envelope-from ) id 1nrKj4-00021p-8b; Wed, 18 May 2022 14:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332253.555912; Wed, 18 May 2022 14:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKj4-00021i-54; Wed, 18 May 2022 14:32:34 +0000 Received: by outflank-mailman (input) for mailman id 332253; Wed, 18 May 2022 14:32:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKj3-00021c-9h for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:32:33 +0000 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59ccaf7c-d6b7-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 16:32:31 +0200 (CEST) Received: from mail-yw1-f173.google.com ([209.85.128.173]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M3VAI-1nrsgn0FJi-000fJW for ; Wed, 18 May 2022 16:32:31 +0200 Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ff39b44b06so26177257b3.13 for ; Wed, 18 May 2022 07:32:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59ccaf7c-d6b7-11ec-bd2c-47488cf2e6aa X-Gm-Message-State: AOAM533KbuiTruuYcrBFgs44zHn9/680IJA1qf4KHyYPMA77fgv5Jb47 7kYxS8EkBGxWWhkokcEsJ6khW+68kP4mUY9vPNM= X-Google-Smtp-Source: ABdhPJxlE4uUCuxvYT1DUTMaDWGZzPyyY5pBzmvWGxQQ4rCwL5f9fheKzGazF0y+V/+NQaENE1GQBL2EymP+kgt99NY= X-Received: by 2002:a81:6283:0:b0:2ff:2443:6f3c with SMTP id w125-20020a816283000000b002ff24436f3cmr9731868ywb.135.1652884349891; Wed, 18 May 2022 07:32:29 -0700 (PDT) MIME-Version: 1.0 References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> In-Reply-To: <1651947548-4055-6-git-send-email-olekstysh@gmail.com> From: Arnd Bergmann Date: Wed, 18 May 2022 15:32:27 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Oleksandr Tyshchenko Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:WFVAKeO0MbZcUO/LbWW8rokfv9qQ/1NcjMQV3qavBzyRx0lVR3c XbLSGrmf+WurMCRtoGbzbfx4LVDIJsQP/trrfjz4GGGkZrliT9DmvBBYP4olTng4iTHFQb9 +pF4LdyFhOoqcc5oIlxhw17cZ48RPnZSei8TXjkZbrYtKo8GkB6IlVs9w67d8oovwjnRZNJ 7xgFzrgH5FNoqkWmP6TIw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZrHKYPx8XzY=:ZUL1iGTclFQFPhqr8hXSYa +lEcMnmbSNGkD109ww9zlFkCnTQ0/QCgA7mDg1plVg83irLtn6qRGcYH+2xx+uFI9/8TiZDDm jGkylXijqu3KfHq306FLv8zo5J9V8Uo5ORCQxWycZmPKQk8qYWdrOq0Zi8jB5sHZDSR99TH5a HPXGkC1rp/btEPimmeZACDNh+CPn2blbLet0yOiYDfy4z5hrex1Ow+0RFSspdNKsUoimUIjm2 Xr9QQcVTr3Myn7riRPQg41Gzks5SPpyEmFjRgLiKPEI+B/LZP5wJIvTz7ATZG+UKLADJI+WnX /fkn12AvB4Aw1gBhu+Tcx0z1XTYhempbB3oerSH84MCjZLuENqhuF48uUD5QyM4Gq7zvOGXYX nJ3THRrMmTGOATzFdYrdSem0Mgwkk9wFj/HwhDpw0hVabcgKFTGI57Zqu6f8VOLLv9Fx4CGi/ yOGuTt+e7pFJFOxTsIGcqViwjl6vbuaDgZYF2Y4VGYyvRwjYkP2HBGYoONDrJdUQvzDTZ3bK4 N6CKD/YXygjO+6uM7o2WPhVhCxgmKoqaKaHR8gMosvFsILneuMGPJTX58B5yMdey6mwvZhRd4 301Y3s5dc6xUrMA+DsrrGg0Ptz4ihaAuXuSRjrq62GkmqtkIRghNCn1jLceA+mbYaUYrw2bY1 5bocQCb+ApthBO/yrlYZtpAeAQtpbLyY9OG1t2EAzroAP1PG6gzhaJJiKvDqA4nI3YoMPFr3V MYAa5GVgEa9CgonvTvwcgDQ+MDlsnb8VPbOBY5cpAWFmFOYBH5x5Qc6MD9FnPyJt+L0H6Z2aV OiGb7z4ak2GBfPBmPs8aFd8SoLm/Mr8x90WLFNgmY/xXsv70cLKO3bRqwY4YCUNNEppJQps4t AqRPvzzb9f9eytktbvx0gxqOYNg+L/fPaF5SO74ow= On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > index 10c22b5..29a0932 100644 > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > @@ -13,6 +13,9 @@ description: > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > more details. > > +allOf: > + - $ref: /schemas/arm/xen,dev-domid.yaml# > + > properties: > compatible: > const: virtio,mmio > @@ -33,6 +36,10 @@ properties: > description: Required for devices making accesses thru an IOMMU. > maxItems: 1 > > + xen,dev-domid: > + description: Required when Xen grant mappings need to be enabled for device. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > required: > - compatible > - reg Sorry for joining the discussion late. Have you considered using the generic iommu binding here instead of a custom property? This would mean having a device node for the grant-table mechanism that can be referred to using the 'iommus' phandle property, with the domid as an additional argument. It does not quite fit the model that Linux currently uses for iommus, as that has an allocator for dma_addr_t space, but it would think it's conceptually close enough that it makes sense for the binding. Arnd From xen-devel-bounces@lists.xenproject.org Wed May 18 14:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332269.555938 (Exim 4.92) (envelope-from ) id 1nrKl7-0002p3-RJ; Wed, 18 May 2022 14:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332269.555938; Wed, 18 May 2022 14:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKl7-0002ow-OP; Wed, 18 May 2022 14:34:41 +0000 Received: by outflank-mailman (input) for mailman id 332269; Wed, 18 May 2022 14:34:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKl6-0002oq-6X for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:34:40 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0602.outbound.protection.outlook.com [2a01:111:f400:fe1f::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a5028f47-d6b7-11ec-837e-e5687231ffcc; Wed, 18 May 2022 16:34:38 +0200 (CEST) Received: from DB6PR07CA0191.eurprd07.prod.outlook.com (2603:10a6:6:42::21) by AS8PR08MB7205.eurprd08.prod.outlook.com (2603:10a6:20b:404::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 14:34:35 +0000 Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::a0) by DB6PR07CA0191.outlook.office365.com (2603:10a6:6:42::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.5 via Frontend Transport; Wed, 18 May 2022 14:34:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 14:34:35 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Wed, 18 May 2022 14:34:35 +0000 Received: from 2277c4fa6b64.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91DB3DD3-5532-4D4E-963B-2E709C932FD3.1; Wed, 18 May 2022 14:34:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2277c4fa6b64.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 18 May 2022 14:34:27 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by PAXPR08MB7320.eurprd08.prod.outlook.com (2603:10a6:102:223::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Wed, 18 May 2022 14:34:20 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5273.013; Wed, 18 May 2022 14:34:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5028f47-d6b7-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EEzFC3caKKtCnKu2+nXQWONrpmySF0w7VU4vxOJnvwTDwU6mFugEjvVYfLL/i02axZYjqCDa9hCTgAjwAJQytBNyKBA1irtilN9V2B1L5rIS3D1WXBWd03Bz4KFM3Psl9TYFabJKdMJ4G1fsYh7nuwbNDzi5tndwKS5BUROP3diggVEXLmZor0KA8n4eXE1rkcQU9Jm+hFU/tPlOj99EtESxytpfCmNddjEZf3acCnk+vZ4eM2D4aeC8sYeVzP9xp4tarfVcG4MQClPkuUYTXlvDi6oY9l1Y5pX53qg5lJMAII13/2/L73aLvnD0dRAHyrXjmh8vkOxKHK0EGizRNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTLCVwlrWKM3V3A61jSURmWa9cl69XKqoMPyl8wYNCU=; b=Ux2qiL1L7VnRvjWcT+WshIRxm00Lca8Vg90KetTGldf79RjGbjcCvwNx2hSVkl+E2Vb+uppUDL7O1RVEejMmFVWlicLb2v8ptQExfI5+P0UwPlQ6+SUX6AH0TB9A8AKVQswRHnzW7A7vANSBgXFJBYKIiy2qcxlGUI8H4qnNLI1k3j7Bcko+RZVK6GPAM6NauZufE/E6qLIJnZb/7PlbXXe7FMkBuOSClZw1NgBfJkl7x+Yfynvxo7cRYZtbwITJi8FU9x1tATSuS3EyDY8d4dLoxsvur/J9s/bNXFTiMF0qKU9dwtslDFMePEGs/3XjhTt6B0CTOb4EgTuEll31ZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTLCVwlrWKM3V3A61jSURmWa9cl69XKqoMPyl8wYNCU=; b=vKhM3VmuPv3NQ1wkGODJLPzV69E+zKLsDEKCzkcZPyRshAH2yojU+SqxCnk57Qfw46N7TYQLOMjbLmdNDtED2G++BiqWENQq0Q5Px01rgH0kPKwZ4aajJFKFA4bYrBH84Cy7sWGY5R8psDOrLTl5U2GtulzeUObkUFtSwU0HTDM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3906e04989055eff X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZqSufAsDYo0s6nLfO2hfH4ukbuT67p7GQv10exM6USB2oxnRStpTaT84XwN4NIoLA/9FYqZKi3jaVmrpKHAvzMjxqeBJ5UWf8KeY5t6UvWpp37pkacbGSTQVpWfk/ckntAFif0pWfX+oYebLeFfJpBOMR0gdIso73H+JY00j/HuANhkYe4KVCtgbzbeB5jLIWCbgiaxEgePbZOcycmL8Is1s7McwZAhAXmh0gmxccq1haAULAnq1RgKM4grwYeylAzvlKr0s4eOna3GdpIOe/8awJPPTepcJKJZxm1+Lxt1ss0QyIWLDC5zf1NwhG/WrMcuRnDjBpYEe77D33oGdyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTLCVwlrWKM3V3A61jSURmWa9cl69XKqoMPyl8wYNCU=; b=cVvH1zVhyXTxsHXxW1TDV+KuuFcPkjEpRIn/Ob1/ODn8Dg4nFC8ikAFmNUu1d5sfR7Wlgg1bFVS5aWpPEYps7PxPe9iXYy287tPmJb6XbzVdI2RMb5YIn02rcD+hiriiFHGQnBSgOYPRzqnSK6ARs1ZnVpzw6jzDopveQ15vKXTkayeSJB8fUyp3oGOr/ETj9dnCnyKrMpgpzYg/tLpUngM9vYNnbwP+zNGXxwI2CPXQEH2CX2H9dMuyfQFNWAyXQdLXnANoB6toKFE2CB4T0oIiGx3sT7uQBqtkuye4IQG1Y+TeLk6WlgB2+Xw9I0Huz9dfMxz321ldt6ZeFBa8jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTLCVwlrWKM3V3A61jSURmWa9cl69XKqoMPyl8wYNCU=; b=vKhM3VmuPv3NQ1wkGODJLPzV69E+zKLsDEKCzkcZPyRshAH2yojU+SqxCnk57Qfw46N7TYQLOMjbLmdNDtED2G++BiqWENQq0Q5Px01rgH0kPKwZ4aajJFKFA4bYrBH84Cy7sWGY5R8psDOrLTl5U2GtulzeUObkUFtSwU0HTDM= From: Luca Fancellu To: Andrew Cooper CC: Edwin Torok , Xen-devel , Christian Lindig , Anthony PERARD Subject: Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id Thread-Index: AQHYaiYlhlRp70KGIk+7qOp/vtrSaK0kZYcAgAAF1oCAAATWAIAAEd6AgAAyWYA= Date: Wed, 18 May 2022 14:34:20 +0000 Message-ID: References: <20220517194113.2574-1-andrew.cooper3@citrix.com> <20220517194113.2574-3-andrew.cooper3@citrix.com> <987CBBF2-D9EE-4644-96DF-5DA89D96921A@citrix.com> <107B2C8E-59DF-4D7B-A6E1-E136E702AB96@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 35e620b3-121f-45a5-a322-08da38db87d2 x-ms-traffictypediagnostic: PAXPR08MB7320:EE_|DBAEUR03FT063:EE_|AS8PR08MB7205:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8g6DTxe+g++30huOxgPkGKB1ey3ENM47HeLw5zP31dlC7Dt8sYprf8C2HoOiAZMkcwrIqinRPLigJCzbDfQeMwddlYamCrxu8cYSxD8OCISw69s8B0QjVjKEMTZdqUE+FDQ1OD7ZSg+lgaRElsGCOOW/iXzyYL2K35cFD13V/jGUjA9ShDIH4n+cxPM591gTclzDr1Uvl8RpFgUjHmjwOGt7aJ3z66rtF3o3uafz8gGqXCydVAywQrwsua2RuL1nMIlKkdYwbWabNa9ODAnFC8Xbk47z9Mp+LXzikhWs5p22G2+79FNirEfLqsjY6kRP9MG0Ewd4HuxzGEFw+a7coT4bVlcFiD9ywlTCkvkPRex1OxBAcS+Ivxoky4EA1qHreoV/krjQlOaEwEB90f5M2uu6o+tdGukWGN9Q05mJUG5P1rNQj4G1ZtXyVBLEzwujQKfjnlidFxXDChMpffWOZD78hPbX7EZIa/QCFA2/3Q+pxBLOoOjQ7a/o7Jk/dPA4d/qG9+IBpR3Uouyba7ecM4QSm1DSTQjM8+g25rPwt1EzczRbTsPSEOaezRp/EDK4NdaIR1na06T+vWz0DmeoTAlE9xCiCOHF71HOWQCKuPZFmc/OI152a4toQ6mBF5poPPWAge7lV8YKjoOiEwc25K2L2zM1jm0mnfA8P9oPfm1wmtrpdw2mj/BLjyUVWaxrVmcJlPL+lEisSTKf5sQBX9xMKWOXAf3ZJn2FpeEy7qpCMQu8Q+1UvwlH8+7vchVI X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(6506007)(316002)(91956017)(76116006)(4326008)(86362001)(66946007)(2906002)(508600001)(26005)(53546011)(38100700002)(38070700005)(186003)(5660300002)(36756003)(2616005)(6486002)(54906003)(6916009)(33656002)(6512007)(64756008)(66446008)(8936002)(71200400001)(8676002)(66476007)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7320 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c4973b6e-557c-47c4-06f5-08da38db7eec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T3+1ifkyXQIfYOb5JnSbmDn19+x5ryQSGoN9pNgQuuIZ7uQQerqrq8tAEj0vpGWX17LqOQblc/O4xSdk71HRLJ1/RUVele0eL66zVi3i5ZlIfs8SPjIe1cA9xWy2HqjN1UdzrAqOo4hMoAVM0UL/O8dKHAt/HWUN7q9m8PKfj0JeYNuH/hUR9vS9L/lkRcCsVh+bcqvMiPt/9kajxuJNNSmvMOAkZCRfsrtRA4W5t44nbTxK/dTv68l+ttmCPaUsOs/f38jh2C06mjl8FnmnGNSjq6P4HA+Vp7crFMvpPB8pHCxqBhTuYUJ5obA34ZmazXjIV1cYjpcmDgyksgSojNNA/g+hZw8LVLDH8pqOyz5vBJ61wjRQb2j+kdkPq2dTURDRDD1YcUhY9NtyvpFqSYSn2IIT8qmr4KMIA7hdIcwxTe3+5yPKnWx/29p1Eq1g+xXvJNT93RlR6MMTyMPl+GFKN6CDbn57KNLPzq1AWFuCl0SiRVOM0QGZehtGCyZZWGBtWdW0WrX1wB41wmF4dbIUY8RHzVcqWJmVXmu5Kq7l90uXlQlMw2Yj1GWqB84PQ8S5fWnA4XJYV/7Yu4b64ML1UUscVMHum0rkQXO4c38iEBP65ziqV2Usy8H8tlsdOhgSPp55fexClf3rArE9jV0fauD1dZK1ict+chkhLulC1f2/sI+jFiOab57Zb58y X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(70586007)(8676002)(6862004)(4326008)(70206006)(8936002)(33656002)(2616005)(316002)(47076005)(86362001)(5660300002)(40460700003)(107886003)(336012)(186003)(36860700001)(53546011)(82310400005)(36756003)(6506007)(6512007)(6486002)(26005)(81166007)(2906002)(508600001)(356005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 14:34:35.4068 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35e620b3-121f-45a5-a322-08da38db87d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7205 KyBBZGRpbmcgdG9vbHN0YWNrIG1haW50YWluZXINCg0KPiBPbiAxOCBNYXkgMjAyMiwgYXQgMTI6 MzQsIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiAN Cj4gT24gMTgvMDUvMjAyMiAxMTozMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+PiBPbiAxOCBN YXkgMjAyMiwgYXQgMTE6MTIsIEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5j b20+IHdyb3RlOg0KPj4+IA0KPj4+IE9uIDE4LzA1LzIwMjIgMTA6NTEsIEVkd2luIFRvcm9rIHdy b3RlOg0KPj4+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbCBi L3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPj4+Pj4gaW5kZXggNzUwMzAzMWQ4ZjYx Li44ZWFiNmY2MGViMTQgMTAwNjQ0DQo+Pj4+PiAtLS0gYS90b29scy9vY2FtbC9saWJzL3hjL3hl bmN0cmwubWwNCj4+Pj4+ICsrKyBiL3Rvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KPj4+ Pj4gQEAgLTg1LDYgKzg1LDcgQEAgdHlwZSBkb21jdGxfY3JlYXRlX2NvbmZpZyA9DQo+Pj4+PiAJ bWF4X2dyYW50X2ZyYW1lczogaW50Ow0KPj4+Pj4gCW1heF9tYXB0cmFja19mcmFtZXM6IGludDsN Cj4+Pj4+IAltYXhfZ3JhbnRfdmVyc2lvbjogaW50Ow0KPj4+Pj4gKwljcHVwb29sX2lkOiBpbnQz MjsNCj4+Pj4gV2hhdCBhcmUgdGhlIHZhbGlkIHZhbHVlcyBmb3IgYSBDUFUgcG9vbCBpZCwgaW4g cGFydGljdWxhciB3aGF0IHZhbHVlIHNob3VsZCBiZSBwYXNzZWQgaGVyZSB0byBnZXQgYmFjayB0 aGUgYmVoYXZpb3VyIHByaW9yIHRvIHRoZXNlIGNoYW5nZXMgaW4gWGVuPw0KPj4+PiAoaS5lLiB3 b3VsZCBpdCBiZSBjcHUgcG9vbCBpZCAwIG9yIC0xIGlmIGNwdSBwb29scyBhcmVuJ3Qgb3RoZXJ3 aXNlIGV4cGxpY2l0bHkgY29uZmlndXJlZCBvbiB0aGUgc3lzdGVtKQ0KPj4+IGNwdXBvb2xzIGFy ZSBhIG5vbi1vcHRpb25hbCBjb25zdHJ1Y3QgaW4gWGVuLg0KPj4+IA0KPj4+IEJ5IGRlZmF1bHQs IG9uZSBjcHVwb29sIGV4aXN0cywgd2l0aCB0aGUgaWQgMCwgdXNpbmcgdGhlIGRlZmF1bHQNCj4+ PiBzY2hlZHVsZXIgY292ZXJpbmcgYWxsIHBDUFVzLCBhbmQgZG9tMCBpcyBjb25zdHJ1Y3RlZCBp biB0aGlzIGNwdXBvb2wuDQo+Pj4gDQo+Pj4gUGFzc2luZyAwIGhlcmUgaXMgdGhlIGJhY2t3YXJk cyBjb21wYXRpYmxlIG9wdGlvbi4NCj4+PiANCj4+PiBBbmQgb24gdGhhdCBub3RlLCBMdWNhLCB5 b3Ugb3VnaHQgdG8gcGF0Y2ggeGwvbGlieGwgdG8gYXBwbHkgdGhlIHBvb2w9DQo+Pj4gc2V0dGlu ZyBkaXJlY3RseSBkdXJpbmcgZG9tYWluIGNyZWF0ZSwgcmF0aGVyIHRoYW4gZGVwZW5kaW5nIG9u IGNwdXBvb2wNCj4+PiAwIGV4aXN0aW5nIGFuZCBtb3ZpbmcgdGhlIGRvbWFpbiBsYXRlci4NCj4+ IElzIGl0IGFuIGVuaGFuY2VtZW50IG9yIGEgYnVnIGZpeD8NCj4gDQo+IFRoaXMgaXNuJ3QgYSBi aW5hcnkgb3B0aW9uLg0KPiANCj4gWW91ciBzZXJpZXMgYWRkZWQgYW4gb3B0aW1pc2F0aW9uIHRv IERPTUNUTF9jcmVhdGVkb21haW4sIHRoZW4gZGlkbid0DQo+IGFkanVzdCBsaWJ4bCB0byB1c2Ug dGhlIG9wdGltaXNhdGlvbiAod2hpY2ggd291bGQgaGF2ZSByZWR1Y2VkIHRoZQ0KPiBudW1iZXIg b2YgaHlwZXJjYWxscyB0byBjcmVhdGUgdGhlIGRvbWFpbiwgYW5kIHJlZHVjZSB0aGUgbnVtYmVy IG9mDQo+IGR5bmFtaWMgbWVtb3J5IGFsbG9jYXRpb25zIGluIHRoZSBoeXBlcnZpc29yLiAgTWFy Z2luYWwsIGNlcnRhaW5seSwgYnV0DQo+IGNsZWFybHkgYSBuaWNlLXRvLWhhdmUpLg0KPiANCj4g VGhlcmVmb3JlLCB5b3UgY3JlYXRlZCB0ZWNobmljYWwgZGVidCwgd2hpY2ggaXMgb3B0aW9uIDMu DQo+IA0KPiBCeSBkZWZhdWx0LCBhcyB0aGUgY29udHJpYnV0b3IsIHlvdSBhcmUgZXhwZWN0ZWQg dG8gYWRkcmVzcyB0aGUNCj4gdGVjaG5pY2FsIGRlYnQsIGJlY2F1c2UgaXQgaXMgYW4gaW1wb3J0 YW50IGRpZmZlcmVuY2UgYmV0d2VlbiBoYWNraW5nIGENCj4gZmVhdHVyZSB1cCBmb3IgeW91cnNl bGYsIGFuZCBpbnRlZ3JhdGluZyB0aGUgZmVhdHVyZSBuaWNlbHkgZm9yIGV2ZXJ5b25lLg0KPiAN Cj4gWW91IGNhbiBvZiBjb3Vyc2UgbmVnb3RpYXRlIHdpdGggdGhlIHRvb2xzIG1haW50YWluZXIg dG8gc2VlIGlmIHRoZXkNCj4gY2FyZSwgYW5kIHJpZ2h0IG5vdyB0aGF0J3MgYSBiaXQgZGlmZmlj dWx0LiAgSXQncyBxdWl0ZSBwb3NzaWJsZSB0aGF0DQo+IG5vb25lIG90aGVyIHRoYW4gbWUgY2Fy ZXMsIGFuZCBJJ20gbm90IGxpYnhsIG1haW50YWluZXIuDQo+IA0KPiBFaXRoZXIgeW91IG5lZWQg dG8gcGF5IG9mZiB0aGUgdGVjaG5pY2FsIGRlYnQsIG9yIHNvbWVvbmUgZWxzZSB3aWxsIGhhdmUN Cj4gdG8uICBTb21lb25lIGVsc2UgaXMgZ29pbmcgdG8gaGF2ZSB0byBzdGFydCB3aXRoIGRpZ2dp bmcgaW50byBzb3VyY2UNCj4gaGlzdG9yeSwgd2hpY2ggbWVhbnMgaXQncyBtb3JlIGV4cGVuc2l2 ZSB0aGFuIHlvdSBkb2luZyBpdCBub3cuDQo+IA0KPiBBdCBhbiBhYnNvbHV0ZSBtaW5pbXVtLCB5 b3UgbmVlZCB0byBiZSBhd2FyZSBvZiB3aGVyZS93aGVuIHlvdSBhcmUNCj4gY3JlYXRpbmcgdGVj aG5pY2FsIGRlYnQuDQoNCk9rLCB3ZSd2ZSBqdXN0IGNyZWF0ZWQgYSB0YXNrIHRvIGhhbmRsZSB0 aGlzIHdvcmsgc28gdGhhdCB3ZSBjYW4gdHJhY2sgaXQsIHdlIHdpbGwNCmhhbmRsZSBpdCBpbiB0 aGUgZnV0dXJlLg0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+PiBGcm9tIHdoYXQgSSBrbm93LCBw bGVhc2UgY29ycmVjdCBtZSBpZiBJ4oCZbSB3cm9uZywgY3B1cG9vbDANCj4+IElzIGFsd2F5cyBw cmVzZW50LCBzbyB0aGVyZSB3b27igJl0IGJlIHByb2JsZW0gb24gYXNzdW1pbmcgaXRzIGV4aXN0 ZW5jZQ0KPiANCj4gRnJvbSB3aGF0IEkgY2FuIHNlZSwgeW91ciBzZXJpZXMgaGFzIHJlZHVjZWQg dGhlIG1hZ2ljIGludm9sdmVkIHdpdGgNCj4gY3B1cG9vbDAsIHdoaWNoIGlzIGdvb2QuDQo+IA0K PiBCdXQgdGhlIGZhY3QgdGhhdCBpdCBzdGlsbCBoYXMgbWFnaWMgcHJvcGVydGllcyBpcyBzdGls bCB0ZWNobmljYWwgZGVidA0KPiB0aGF0IHNvbWVvbmUgaXMgZ29pbmcgdG8gaGF2ZSB0byBwYXkg b2ZmIGV2ZW50dWFsbHkuDQo+IA0KPiB+QW5kcmV3DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed May 18 14:42:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:42:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332277.555950 (Exim 4.92) (envelope-from ) id 1nrKsu-0004KW-MQ; Wed, 18 May 2022 14:42:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332277.555950; Wed, 18 May 2022 14:42:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKsu-0004KP-J2; Wed, 18 May 2022 14:42:44 +0000 Received: by outflank-mailman (input) for mailman id 332277; Wed, 18 May 2022 14:42:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKst-0004KF-5R; Wed, 18 May 2022 14:42:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKss-0006dJ-VK; Wed, 18 May 2022 14:42:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKss-0005MZ-Ib; Wed, 18 May 2022 14:42:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrKss-0000GB-IA; Wed, 18 May 2022 14:42:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VE5qfefHB1+5fBoIGGVbxkZptZJtyWozhBwBy+hjlJc=; b=G7JoON6D6Qi6U5faezrQuzATfD nFtMbxSGDQVVpKTXRSgIlSRoxuU102siSCPQzf80niXlqb/9db+iqOloX18d+dvb5KR38k8HaEP+r yFHxAmQsM+CHrtVyNMc7j4DJZosRRcdK0oWCogVuDJIjTMX/Qlp37FlFw+b/ZjBhSCM8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170539: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 14:42:42 +0000 flight 170539 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170539/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1085 attempts Testing same since 170392 2022-05-13 15:40:22 Z 4 days 104 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 14:44:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332288.555961 (Exim 4.92) (envelope-from ) id 1nrKuN-0004zA-7h; Wed, 18 May 2022 14:44:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332288.555961; Wed, 18 May 2022 14:44:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKuN-0004z3-4g; Wed, 18 May 2022 14:44:15 +0000 Received: by outflank-mailman (input) for mailman id 332288; Wed, 18 May 2022 14:44:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKuM-0004yx-Gz for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:44:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc196f62-d6b8-11ec-837e-e5687231ffcc; Wed, 18 May 2022 16:44:13 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 26F9D1F8C9; Wed, 18 May 2022 14:44:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0055E133F5; Wed, 18 May 2022 14:44:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id U+dCOjwGhWJ2NgAAMHmgww (envelope-from ); Wed, 18 May 2022 14:44:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc196f62-d6b8-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652885053; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Lp2JXZZbjQGpQ2E8nMNlpB3Q9z/2jFQfOgGeYMz8dMo=; b=WM53zxgOOECQo45ZRhQwIHZFRvNd6+4MGg3VeAFMEF3WpPVxbFtFAe6UsuguSv7nbFKMm1 u64/CEk6ac5JeGaTEE4QGjpKEAF8yhrKN9dCQ7wsb2jT8IVWJ8GA6ffKmbUCtkhk8MKBzQ GVn7WYGAFRirljg+jJNf8FqTt1SO5/M= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Dario Faggioli , George Dunlap Subject: [PATCH] xen/cpupool: limit number of cpupools Date: Wed, 18 May 2022 16:44:10 +0200 Message-Id: <20220518144410.6806-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today the number of cpupools in a system is unlimited. This can lead to multiple problems (e.g. duplicate cpupool-id). Limit the number of cpupools to twice the number of maximum possible cpus, allowing to have one cpupool per physical cpu plus some spare cpupools for special means (there are already existing use cases for such spare cpupools). Signed-off-by: Juergen Gross --- xen/common/sched/cpupool.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c index f6e3d97e52..7cc25ee8b4 100644 --- a/xen/common/sched/cpupool.c +++ b/xen/common/sched/cpupool.c @@ -30,6 +30,7 @@ struct cpupool *cpupool0; /* Initial cpupool with Dom0 */ cpumask_t cpupool_free_cpus; /* cpus not in any cpupool */ static LIST_HEAD(cpupool_list); /* linked list, sorted by poolid */ +static unsigned int n_cpupools; static int cpupool_moving_cpu = -1; static struct cpupool *cpupool_cpu_moving = NULL; @@ -276,6 +277,14 @@ static struct cpupool *cpupool_create(unsigned int poolid, spin_lock(&cpupool_lock); + /* Don't allow too many cpupools. */ + if ( n_cpupools >= 2 * nr_cpu_ids ) + { + ret = -ENOSPC; + goto unlock; + } + n_cpupools++; + if ( poolid != CPUPOOLID_NONE ) { q = __cpupool_find_by_id(poolid, false); @@ -332,7 +341,9 @@ static struct cpupool *cpupool_create(unsigned int poolid, err: list_del(&c->list); + n_cpupools--; + unlock: spin_unlock(&cpupool_lock); free_cpupool_struct(c); @@ -356,6 +367,7 @@ static int cpupool_destroy(struct cpupool *c) return -EBUSY; } + n_cpupools--; list_del(&c->list); spin_unlock(&cpupool_lock); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed May 18 14:46:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332296.555972 (Exim 4.92) (envelope-from ) id 1nrKwY-0005bM-LS; Wed, 18 May 2022 14:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332296.555972; Wed, 18 May 2022 14:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKwY-0005bF-IP; Wed, 18 May 2022 14:46:30 +0000 Received: by outflank-mailman (input) for mailman id 332296; Wed, 18 May 2022 14:46:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrKwX-0005b9-H7 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:46:29 +0000 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bf75829-d6b9-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 16:46:28 +0200 (CEST) Received: by mail-yb1-f172.google.com with SMTP id r1so4046557ybo.7 for ; Wed, 18 May 2022 07:46:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bf75829-d6b9-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3SGArFKDihyEBXlF8/XNeAemrWMKKpCb4khL75HityU=; b=m8Kpuq9/icSyAoJLHsexyVxVBj2T2pHsMEWAR0LcyGf7CtlJYOpQWBXoA6nvMx06q9 96szUnAWRpklNAcPNZjmxp4rVs0IFhr9gQn+iNn1u3uXNhbfvePoShYWSBoQz8iPpI9y QEGwTHVtw64hpaKmR9Xs+88ZpI+jJjWM5NM+SoML5xdI6LC7lAUlvnVjfxfldoD87msT G+8Ta6u/md9JFXz841AICo+737yFrNVlE/+0lJM8qJ81HgO0tijmp2bcKobJ3idBKki6 OoOevMCIPq9s6ETTuGT2qNlIDPDv74E3qRw9xUs6RfTA9XHqFN8fpasd2BmpMjrhhRD+ YZMg== X-Gm-Message-State: AOAM532YoyWERZdFqNlfd7sByZbtN2RVpwWmIxO11PpTbT0L9WQyUrLf T7d3NPFTBG08g8YUia+z19XPHxvP/oMByNfzdoU= X-Google-Smtp-Source: ABdhPJzrRXyFkOYYP+knWo30LGdADGmZZVDFFkLi378Dx+GKoFEryYPjgFz2aAoFwQStjD/27f3Wowem4YVwVmdPLVU= X-Received: by 2002:a25:d687:0:b0:64e:3a41:8d5 with SMTP id n129-20020a25d687000000b0064e3a4108d5mr3149496ybg.622.1652885186733; Wed, 18 May 2022 07:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> In-Reply-To: <20220509233235.995021-1-dmitry.osipenko@collabora.com> From: "Rafael J. Wysocki" Date: Wed, 18 May 2022 16:46:15 +0200 Message-ID: Subject: Re: [PATCH v8 00/27] Introduce power-off+restart call chain API To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko wrote: > > Problem > ------- > > SoC devices require power-off call chaining functionality from kernel. > We have a widely used restart chaining provided by restart notifier API, > but nothing for power-off. > > Solution > -------- > > Introduce new API that provides call chains support for all restart and > power-off modes. The new API is designed with simplicity and extensibilit= y > in mind. > > This is a third attempt to introduce the new API. First was made by > Guenter Roeck back in 2014, second was made by Thierry Reding in 2017. > In fact the work didn't stop and recently arm_pm_restart() was removed > from v5.14 kernel, which was a part of preparatory work started by > Guenter Roeck. > > Adoption plan > ------------- > > This patchset introduces the new API. It also converts multiple drivers > and arch code to the new API to demonstrate how it all looks in practice, > removing the pm_power_off_prepare global variable. > > The plan is: > > 1. Merge the new API and convert arch code to use do_kernel_power_off(). > For now the new API will co-exist with the older API. > > 2. Convert all drivers and platform code to the new API. > > 3. Remove obsoleted pm_power_off and pm_power_off_prepare variables. > > Results > ------- > > 1. Devices can be powered off properly. > > 2. Global variables are removed from drivers. > > 3. Global pm_power_off and pm_power_off_prepare callback variables are > removed once all users are converted to the new API. The latter callback > is removed by patch #24 of this series. > > 4. Ambiguous call chain ordering is prohibited for non-default priorities= . > > Changelog: > > v8: - Reworked sys-off handler like was suggested by Rafael Wysocki in > the comments to v7. > > - The struct sys-off handler now is private to kernel/reboot.c and > new API is simplified. > > - There is a single sys-off API function for all handler types. > Users shall pass the required sys-off mode type (restart, power-off > and etc). > > - There is single struct sys_off_data callback argument for all > handler modes. > > - User's callback now must return NOTIFY_DONE or NOTIFY_STOP. > > - The default priority level is zero now. > > - Multiple handlers now allowed to be registered at the default > priority level. > > - Power-off call chain is atomic now, like the restart chain. > > - kernel/reboot.c changes are split up into several logical patches. > > - Added r-b from Micha=C5=82 Miros=C5=82aw to unmodified patches from= v7. > > - Added acks that were missing in v7 by accident. The v8 looks much better than the previous versions to me. I actually don't really have any comments on it except for the minor remark regarding patch [1/27] sent separately. Please just send an update of that one patch and I will queue up the series for 5.19. However, I'm going to send a pull request with it in the second half of the merge window, after the majority of the other changes in the subsystems touched by it have been integrated. > v7: - Rebased on a recent linux-next. Dropped the recently removed > NDS32 architecture. Only SH and x86 arches left un-acked. > > - Added acks from Thomas Bogendoerfer and Krzysztof Kozlowski > to the MIPS and memory/emif patches respectively. > > - Made couple minor cosmetic improvements to the new API. > > - A month ago I joined Collabora and continuing to work on this serie= s > on the company's time, so changed my email address to collabora.com > > v6: - Rebased on a recent linux-next. > > - Made minor couple cosmetic changes. > > v5: - Dropped patches which cleaned up notifier/reboot headers, as was > requested by Rafael Wysocki. > > - Dropped WARN_ON() from the code, as was requested by Rafael Wysocki= . > Replaced it with pr_err() appropriately. > > - Dropped *_notifier_has_unique_priority() functions and added > *_notifier_chain_register_unique_prio() instead, as was suggested > by Micha=C5=82 Miros=C5=82aw and Rafael Wysocki. > > - Dropped export of blocking_notifier_call_chain_is_empty() symbol, > as was suggested by Rafael Wysocki. > > - Micha=C5=82 Miros=C5=82aw suggested that will be better to split up= patch > that adds the new API to ease reviewing, but Rafael Wysocki asked > not add more patches, so I kept it as a single patch. > > - Added temporary "weak" stub for pm_power_off() which fixes linkage > failure once symbol is removed from arch/* code. Previously I misse= d > this problem because was only compile-testing object files. > > v4: - Made a very minor improvement to doc comments, clarifying couple > default values. > > - Corrected list of emails recipient by adding Linus, Sebastian, > Philipp and more NDS people. Removed bouncing emails. > > - Added acks that were given to v3. > > v3: - Renamed power_handler to sys_off_handler as was suggested by > Rafael Wysocki. > > - Improved doc-comments as was suggested by Rafael Wysocki. Added mor= e > doc-comments. > > - Implemented full set of 180 patches which convert whole kernel in > accordance to the plan, see link [1] above. Slightly adjusted API t= o > better suit for the remaining converted drivers. > > * Added unregister_sys_off_handler() that is handy for a couple old > platform drivers. > > * Dropped devm_register_trivial_restart_handler(), 'simple' variant > is enough to have. > > - Improved "Add atomic/blocking_notifier_has_unique_priority()" patch= , > as was suggested by Andy Shevchenko. Also replaced down_write() wit= h > down_read() and factored out common notifier_has_unique_priority(). > > - Added stop_chain field to struct restart_data and reboot_prep_data > after discovering couple drivers wanting that feature. > > - Added acks that were given to v2. > > v2: - Replaced standalone power-off call chain demo-API with the combined > power-off+restart API because this is what drivers want. It's a mor= e > comprehensive solution. > > - Converted multiple drivers and arch code to the new API. Suggested = by > Andy Shevchenko. I skimmed through the rest of drivers, verifying t= hat > new API suits them. The rest of the drivers will be converted once = we > will settle on the new API, otherwise will be too many patches here= . > > - v2 API doesn't expose notifier to users and require handlers to > have unique priority. Suggested by Guenter Roeck. > > - v2 API has power-off chaining disabled by default and require > drivers to explicitly opt-in to the chaining. This preserves old > behaviour for existing drivers once they are converted to the new > API. > > Dmitry Osipenko (27): > notifier: Add atomic_notifier_call_chain_is_empty() > notifier: Add blocking/atomic_notifier_chain_register_unique_prio() > kernel/reboot: Introduce sys-off handler API > kernel/reboot: Wrap legacy power-off callbacks into sys-off handlers > kernel/reboot: Add do_kernel_power_off() > kernel/reboot: Add stub for pm_power_off > kernel/reboot: Add kernel_can_power_off() > kernel/reboot: Add register_platform_power_off() > ARM: Use do_kernel_power_off() > csky: Use do_kernel_power_off() > riscv: Use do_kernel_power_off() > arm64: Use do_kernel_power_off() > parisc: Use do_kernel_power_off() > xen/x86: Use do_kernel_power_off() > powerpc: Use do_kernel_power_off() > m68k: Switch to new sys-off handler API > sh: Use do_kernel_power_off() > x86: Use do_kernel_power_off() > ia64: Use do_kernel_power_off() > mips: Use do_kernel_power_off() > memory: emif: Use kernel_can_power_off() > ACPI: power: Switch to sys-off handler API > regulator: pfuze100: Use devm_register_sys_off_handler() > reboot: Remove pm_power_off_prepare() > soc/tegra: pmc: Use sys-off handler API to power off Nexus 7 properly > kernel/reboot: Add devm_register_power_off_handler() > kernel/reboot: Add devm_register_restart_handler() > > arch/arm/kernel/reboot.c | 4 +- > arch/arm64/kernel/process.c | 3 +- > arch/csky/kernel/power.c | 6 +- > arch/ia64/kernel/process.c | 4 +- > arch/m68k/emu/natfeat.c | 3 +- > arch/m68k/include/asm/machdep.h | 1 - > arch/m68k/kernel/process.c | 5 +- > arch/m68k/kernel/setup_mm.c | 1 - > arch/m68k/kernel/setup_no.c | 1 - > arch/m68k/mac/config.c | 4 +- > arch/mips/kernel/reset.c | 3 +- > arch/parisc/kernel/process.c | 4 +- > arch/powerpc/kernel/setup-common.c | 4 +- > arch/powerpc/xmon/xmon.c | 3 +- > arch/riscv/kernel/reset.c | 12 +- > arch/sh/kernel/reboot.c | 3 +- > arch/x86/kernel/reboot.c | 4 +- > arch/x86/xen/enlighten_pv.c | 4 +- > drivers/acpi/sleep.c | 16 +- > drivers/memory/emif.c | 2 +- > drivers/regulator/pfuze100-regulator.c | 42 ++- > drivers/soc/tegra/pmc.c | 87 +++++-- > include/linux/notifier.h | 7 + > include/linux/pm.h | 1 - > include/linux/reboot.h | 91 +++++++ > kernel/notifier.c | 101 +++++-- > kernel/reboot.c | 347 ++++++++++++++++++++++++- > 27 files changed, 639 insertions(+), 124 deletions(-) > > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Wed May 18 14:55:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332308.555982 (Exim 4.92) (envelope-from ) id 1nrL5H-0007AB-H0; Wed, 18 May 2022 14:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332308.555982; Wed, 18 May 2022 14:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrL5H-0007A4-EN; Wed, 18 May 2022 14:55:31 +0000 Received: by outflank-mailman (input) for mailman id 332308; Wed, 18 May 2022 14:55:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrL5G-00079y-3q for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:55:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e3b3e0a-d6ba-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 16:55:28 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83DE061982; Wed, 18 May 2022 14:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4268FC385AA; Wed, 18 May 2022 14:55:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e3b3e0a-d6ba-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652885726; bh=y/nVf707/t+pKLmjuo0j1M7q/g28bwWk29Oh1R8DBz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=guZ+Xxyh9gOkTE0/y4ptl2ieLoWdWs8y2aB+SXXif8B4B9IuEuRDrUwRsuZXklT3N ul7wcMyOzBlrEmtToMcUWRw6rfipS9zgxXnmXFTpOSCBZ761OnPlfU2BzgzIXwH76q UibMwKzOH1hdVomum7sS+fYiLUEaXUMIn40NKQsVnGERenGbm4F81BOboZHxe7IpVY 9jcmA4cH5OZTL2Z0LvDg1fLiu10iBYaPRrKvSxHCASViIEXxHCE5CmrvlRP5WYYOHp DeKdQsmHEOGj7bJ9CnOGrFR1d9SAn9QbK0l0othc6qYTacv6/1dm5sOEVVlGMoSM/b Y7FqFC23QbMUQ== Date: Wed, 18 May 2022 17:57:07 +0300 From: Jarkko Sakkinen To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe Subject: Re: [PATCH v3 15/21] xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() Message-ID: References: <20220505081640.17425-1-jgross@suse.com> <20220505081640.17425-16-jgross@suse.com> <642471c7-f717-2ef4-1d6d-6fabf57db08f@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <642471c7-f717-2ef4-1d6d-6fabf57db08f@suse.com> On Wed, May 18, 2022 at 11:41:51AM +0200, Juergen Gross wrote: > On 07.05.22 00:32, Jarkko Sakkinen wrote: > > On Thu, May 05, 2022 at 10:16:34AM +0200, Juergen Gross wrote: > > > Simplify tpmfront's ring creation and removal via xenbus_setup_ring() > > > and xenbus_teardown_ring(). > > > > > > Signed-off-by: Juergen Gross > > > > Please add to the commit message why these provide an equivalent > > functionality. > > Would you be fine with: > > Simplify tpmfront's ring creation and removal via xenbus_setup_ring() > and xenbus_teardown_ring(), which are provided exactly for the use > pattern as seen in this driver. > > > Juergen Looks fine to me! BR, Jarkko From xen-devel-bounces@lists.xenproject.org Wed May 18 14:59:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 14:59:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332316.555993 (Exim 4.92) (envelope-from ) id 1nrL8n-0007nP-18; Wed, 18 May 2022 14:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332316.555993; Wed, 18 May 2022 14:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrL8m-0007nI-UP; Wed, 18 May 2022 14:59:08 +0000 Received: by outflank-mailman (input) for mailman id 332316; Wed, 18 May 2022 14:59:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrL8l-0007nC-3I for xen-devel@lists.xenproject.org; Wed, 18 May 2022 14:59:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e84fcdb-d6bb-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 16:59:05 +0200 (CEST) Received: from mail-dm3nam07lp2046.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 10:58:58 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN2PR03MB2192.namprd03.prod.outlook.com (2603:10b6:804:c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Wed, 18 May 2022 14:58:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Wed, 18 May 2022 14:58:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e84fcdb-d6bb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652885945; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=/5EjpVdkv4Mmk/jN9FkWjoyrXIV6N4Q24toLkeKh6DQ=; b=Lk3ZpbL9alHC+8+xUFbbgYpJgqyvRYfYDu1aRwfXU4mJr+YI06/uDc0O rfVHzPGJQ6Li4Qr1die+G/HTyDhbfIDC4R94xJ1MzxTd2NFMle4mXYepK EKddBtt3D3mj+U9SSLV0zvO4Vcfds62UFrIvjFipsOstF07c1AtRl0StO E=; X-IronPort-RemoteIP: 104.47.56.46 X-IronPort-MID: 74109291 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LBljYqgn1lF3AbqvDrBWKka9X161HhEKZh0ujC45NGQN5FlHY01je htvWGjXb/aOazSmKtF1OorloUlUvsPVndZrSgBopC49FXkb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrd4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSEgY6fUweM2aB9jMg5GN/BN2bXXeHfq5KR/z2WeG5ft69NHKRlseKE9oaNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEegGlYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVrujCCll0ouFTrGNHbR+OJStxlok23i Vn8pHXgXREbbuXKnFJp9Vrp3IcjhxjTWo0IE6aj3uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiHKKtxETWt1UEsUh9RqAjKHT5m6k6nMsSzdAbJkqsZQwTDlyi VuRxYu1W3poraGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9UDSW517YRY36piG IronPort-HdrOrdr: A9a23:RlE9LKOmRyjZqMBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,235,1647316800"; d="scan'208";a="74109291" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRbTQIVxUh5HlBoFn6Q/F4JNYlta3TSIYBhMamGdTyZ4cwPWZhzgUARlWFOczsTmFNBISf5z6aE7pMjSNGe/QOPeUIXrzCRjdoQjC14Qh5faP1QsUeqXBTqjxUxvNqSPDNQBqkjyOcCM1TH761IhfbuZnN4Oek1VOGiYMSEljD+3qSosuh6eaPZwJ9q4NQvgZD8FPv4mKJpNrbW7qHzjCakTDB6pk7nPDr0CzOYg5DLBQu9eMo628MmGNVZwVzGzQTWL4kJXEsq8HkfPxJI/5hcEsy/b0sLPS61Y8tHeV2q0o5keyHFh2llZg+6vVJu42KvoPmOB6KsV6zCeuJ6yrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/5EjpVdkv4Mmk/jN9FkWjoyrXIV6N4Q24toLkeKh6DQ=; b=DjGsXFwCuLBo3DUIoZqkuycW26WcOh+b/pZL0UYEr5fiXUrKjY6joUAIQeEkgdZmD3iOP7aY6fzJG6bwqA4hFnq8PYuZ4lhzObnqLhCCjiDl0BLuplUt+TqDYJJi+sRoFdsJlG/YjyUHJyPAho4gvmGzpq0mkGtCMMNlNCS/aeDgAKro7sg36ZpT1z7CIqFJ1YJt1ZIwrLX0zgKZMIqcDFzqfqLGVhKF09pDUdalnqF3oLxMxCZgicMaib0wLbmNTtf+3eijCwQZmjdUs4H4tX9TzFJnvHJKk/yrHN5ET0K9h1xJ5pGyHpytiO7CtaLhl6zi8+5v7nrdGmB9BDFqAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/5EjpVdkv4Mmk/jN9FkWjoyrXIV6N4Q24toLkeKh6DQ=; b=tMX7XfdBfKuFe+YkR72mztGEFjPMOvWMqDv+hyRYxQKv9k2R3bXPtKFzxTFbhkoIEbNPC+V1qkdAwqyzWR11ul9Sayv3PeN5r1Nghiz8KyHe68C2G8HFi8PfFk1T5pgWWsK6qt65Q5UrwjBgzeoQQ+J40WiEOAjp0ZHDgf9KcME= From: Andrew Cooper To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Dario Faggioli , George Dunlap Subject: Re: [PATCH] xen/cpupool: limit number of cpupools Thread-Topic: [PATCH] xen/cpupool: limit number of cpupools Thread-Index: AQHYasXCvgLbjuumrUuXxuSY9QgvcK0kugwA Date: Wed, 18 May 2022 14:58:56 +0000 Message-ID: <66d823eb-cc2d-4c05-ac41-27e3a0af53bc@citrix.com> References: <20220518144410.6806-1-jgross@suse.com> In-Reply-To: <20220518144410.6806-1-jgross@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f0f8712-e92d-4998-1a2d-08da38deef1f x-ms-traffictypediagnostic: SN2PR03MB2192:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eXVTDrj/tjC1XmSn1DcN6Ni1T9rfreks9dlr0/uQHyhFh9iM1vbqBWJMXenvV6hme8CewsaVhcz7CwzJCt8BMbpS5rJPVoJh47M6Yh4km8iHw5GB2k9FPXEEbQGDl8Y/mopbBzEfvWHFvm78zhSnlgs4tzyAnR9aKkemAD8gKI4bPC7K4Op6+fQifgQoc0ME532Vs66Svtq1ICuNbC4u9ifOd8rQXpkLxznE8c7xmc4Lf1ed4SUd7kejXDf/jGCanxEvPOqCZsmBsKusuBdx/wFfNpGyOGbvRsd3zALQLa6Qur7ULTcC1RlXsJFMsIyudf+3/Ruh4wvsMZ1LYkgrZBKgazX7pY39P1SqT3429Hwu49mToMr5rZXf6T2sKPRnPWhDAZjfUspGR/dmHIcCyc/s9TFZD+i0ewCV2/5j9GZ8FtCXEf5Z1Ap7E2exdM9Zmiie8F62WlaP9Rhy1MMyf45reFC47gGq/xvuwX1BnzbDgFL+HkOUANYonDz/jEJZpsxSWPpH76fU9SbWT/O9DELagXHchB5JxWdX1L77gH5F20uSms6zmofGU+JpnXhSPujZFpCcJQAzuDs/ATkJx/V2ZsxKpobTNIIbgaJv1jVshq8QdxB/ZaG26+HfaVfDCJl3R2fxyDHo4PKyLlGNIBgjfyjCjNOFn6UWTa2JRqk/JwpvGAFlUhHoiiTKOfJkATyjW4jd5CmjyY2dBjCXvLDQKp4+Bi9GnaPtujz3vFlaKrGl1d5k8G2kt4uBxZPE09cuSTjgrHBTokPa2gK8Jg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(82960400001)(6512007)(508600001)(86362001)(5660300002)(122000001)(6486002)(38070700005)(38100700002)(107886003)(26005)(36756003)(54906003)(31686004)(4744005)(71200400001)(186003)(110136005)(316002)(76116006)(8676002)(4326008)(66446008)(66946007)(55236004)(53546011)(6506007)(64756008)(2616005)(2906002)(31696002)(66556008)(66476007)(91956017)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WFZGYUJGWXdlckJYQ0dnY2FuS0JjTy9Pei9ITFQvdGxqWFBvRitpK2l1M1pw?= =?utf-8?B?ZnNwV1RwZURJNktJZ1AxcnBacXpNellFbE96eXJlVGRZcWxzWDgrc0UxU0Ja?= =?utf-8?B?YlkwV2tjZGsweE1LWEloQmh1ckdMTVIxeExoVkdOZUY2V0kwaEhFSFVMNmdN?= =?utf-8?B?S2Z6MGlKbGtmbHdsYXlzZkdwYlF0RUdPMFlMaFFQa20wb2Q0OVBSMS9tLzMv?= =?utf-8?B?ZG9KRGhlVU9xVVU4bVhHV0lzTHIrREVPNzBYY2pVdHZIVm1EalQ3MW90YnNO?= =?utf-8?B?Mm5kWVpYL0JxTnRYU1UwckNWNkQyUFVUaEhJb2xOL2ExMFhGa3NmMW1tNjNS?= =?utf-8?B?amNmOGg2U3lIUGU2Snc0ZnBvU3VHcEU1Y0JqRDAyMmpOWUpuL2FtZUVkcjE1?= =?utf-8?B?MS84QzV1bVcyU1FLbS9xMVVBL1dXWWJCNnltZDlMalpHWDhYQVh5OUl6emI4?= =?utf-8?B?VEo1R1NaQXlIU3I3YU1OTlZ5Y3FJTjVXbGdxcnZzeFZmc1psYjNuejJWV1BE?= =?utf-8?B?QUI3dUh5OUM1YVVaOEdXSzZhcUx2ZWFoMFhoaUZkamU1TFl1T1QxSnFoR0sx?= =?utf-8?B?c2MvV1VvRDJvelZ3dTRyUzA4c3hBc1gyWkZlaUZ4RU1wRUNpL1JaSXVEcjdm?= =?utf-8?B?OEs4Y3Q0TGN1eHhQWC8vMVJoTXEzQ1EwcnpOZTNtbmdnSDA3YzBGK2JGcGdu?= =?utf-8?B?VDRmNTBOSEFEOXhEbkpONzZnRnY0clorb0piMS9aZVc2akxNZkJiQVVvTTlG?= =?utf-8?B?S3RUWEc3U3NpcGtGdXZCY2NUL0JqOVYvckw5MHZzcVl3VktpeldVdEJvbzlm?= =?utf-8?B?UkR3TE8vWE1zaVBtYnQ5MTdySVE2Z2VGaHN0VUNhTHUwWFJJa0NsdFVHSkNZ?= =?utf-8?B?YjUxRzdWb01SRXBqSUx3cVNTeitBaEliTHptYkxjbkZDZDdqZ0YrbE5ld01L?= =?utf-8?B?S0ZMbTE4MURKV0drL1ZZWm1rdlhnRTkva3JTZ0Y1eVZ6eklIbUZLRmNVdU1x?= =?utf-8?B?WHByMkt3TlQ5YU5kZkQ3bktaY1MvYnEvaXFLTUI1ZHAxRXNIajlqY0Z6ODdM?= =?utf-8?B?MDR3dEp1Qm1Ib2dhVDZ4TDk4d1JDazBnZTllRUFCcUIyNTE3LytrTExSbjEx?= =?utf-8?B?SXlVaE1rZlQ4Vk9MRmE2d0JrakxtSXFvMzJxU1QvRWZCcXI1Z0hsdmdyTUp4?= =?utf-8?B?RTNJM1RNVXN4WGk1S3ZCZjFDcHorVkx1R1EyYUdLZnhtVWlabndmaWdsOGdm?= =?utf-8?B?ZXV5OERpZkFDS0hKT25JSzlqZ29XYUpnaVozcU43N3VVWVQ1L1pCQTh1eDFh?= =?utf-8?B?MEE2UUREeGVrRUxsS0JYUDZJSU9JTGlGRUdhZWlselYzZDJzb2t3YVpiWTJM?= =?utf-8?B?U0hJY3c5UitOUUNWUVRDUlpaRE5kOENVUk1GYTZIYVJYV3dVdmxaYW5zUW9K?= =?utf-8?B?NUtSZVVRT0NOY2NNOHRnNzM4M0Z2TitGSmprMjJQdDBOcmpTa3lRSDB6UG1F?= =?utf-8?B?RU1SMHIzTG9OWGFHNlo3MnhBcGVJaGFQd2RkYnRqdXpxalowRy9KOGtzenFq?= =?utf-8?B?Ky9GSHN4MUE1VkZ0TWNDdGdSQWtDeEpXTGpJVVFYay9CaU5iQkZKRDdKeHA0?= =?utf-8?B?VEZJb2RJWEtyV3ZwTFNveDVJOXdlR1F2Zm0xOWlaSDNWS2xPWXoyeFpiRTVR?= =?utf-8?B?K0ZhbFpNaWJuQ0NON0UzTUdvK2dKYTZDdzlCcFBIMXJTWHFnelRQVHdIcGxh?= =?utf-8?B?ajZ6SjF1Q1pSTDJZQk5mMzFEVzFDWVdKWGVyWWNrZTh5a2NJVXkwbHdjMUk5?= =?utf-8?B?YzZaSll1cnhjaEwrMXVqNjN2ZlY1WVQ3VmJ5cHBVblRCeklIaGxwbWJ3QStN?= =?utf-8?B?Qm02TTRsRDJuK2NrVWM4TWFadHRXdkQvRGVQbk5NQ1B0UkR1VWpLbGxUQmFW?= =?utf-8?B?OGFuUEtRL0UyVVRiU2tpaFdZQmZnTGgvaEp4YWVINjJobDVxNWJ1MEdhanor?= =?utf-8?B?ZkRsajdWNW9mSk1lWnFxb2lsaE5tMHJINnR3YWd1TXduVlJaMzlJYUpXYjZQ?= =?utf-8?B?TGsrVHVMQmxzeGROOWxrclh5SU03TDlsVVhlbUdzS1pzR3lrdUhBZ2VudGxI?= =?utf-8?B?ekcwV1dsYVFTQUROQWx5WTFZSEVhcmRsRmRBdnErV2hNcHZsaUpPZ0lYKzVm?= =?utf-8?B?elFqTmMrTW1xNmczcDdndzhlUHZHWWhhNUVlV2M4enpLc0F2QnZZcnJUM0Nl?= =?utf-8?B?amJjMVhsRVdJdm9OaUhiVnlveEFUeVpMTmlORVRkQ3JYQUQ2OWF6a2xFa2JM?= =?utf-8?B?NW80RjE3TVBseFBMcFBjNUJxTjdqWnc5bHJTNEhXQUF4N3h1RDlJQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <1425C7E1ACE1AD48BB7C65A6309B3C6F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f0f8712-e92d-4998-1a2d-08da38deef1f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 14:58:57.1565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rk62WASMZW0G9j+qF70uaGO2M0O13S9GWQ5G2nxszCzLSfejgV+IxbhMKELeBMJFwGjAb6Tzn7GLB+9pjrqphO4fiV5bfkSwki8ZT2h3/Gc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2192 T24gMTgvMDUvMjAyMiAxNTo0NCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gVG9kYXkgdGhlIG51 bWJlciBvZiBjcHVwb29scyBpbiBhIHN5c3RlbSBpcyB1bmxpbWl0ZWQuIFRoaXMgY2FuIGxlYWQg dG8NCj4gbXVsdGlwbGUgcHJvYmxlbXMgKGUuZy4gZHVwbGljYXRlIGNwdXBvb2wtaWQpLg0KDQpO b3QgdG8gbWVudGlvbiBzY2FsYWJpbGl0eSBpc3N1ZXMuwqAgU2VhcmNoIGJ5IElEIGlzIE8obiku DQoNCj4NCj4gTGltaXQgdGhlIG51bWJlciBvZiBjcHVwb29scyB0byB0d2ljZSB0aGUgbnVtYmVy IG9mIG1heGltdW0gcG9zc2libGUNCj4gY3B1cywgYWxsb3dpbmcgdG8gaGF2ZSBvbmUgY3B1cG9v bCBwZXIgcGh5c2ljYWwgY3B1IHBsdXMgc29tZSBzcGFyZQ0KPiBjcHVwb29scyBmb3Igc3BlY2lh bCBtZWFucyAodGhlcmUgYXJlIGFscmVhZHkgZXhpc3RpbmcgdXNlIGNhc2VzIGZvcg0KPiBzdWNo IHNwYXJlIGNwdXBvb2xzKS4NCg0KUHJvYmFibHkgb25lIG9mIFN1Z2dlc3RlZC1ieS9SZXBvcnRl ZC1ieS9SZXF1ZXN0ZWQtYnkgOinCoCBEZWFsZXJzIGNob2ljZS4NCg0KPiBTaWduZWQtb2ZmLWJ5 OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCk90aGVyd2lzZSwgTEdUTS4NCg0K QWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 15:02:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 15:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332325.556005 (Exim 4.92) (envelope-from ) id 1nrLBX-0000uT-Li; Wed, 18 May 2022 15:01:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332325.556005; Wed, 18 May 2022 15:01:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLBX-0000uM-II; Wed, 18 May 2022 15:01:59 +0000 Received: by outflank-mailman (input) for mailman id 332325; Wed, 18 May 2022 15:01:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLBW-0000tx-N5 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 15:01:58 +0000 Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [2001:4860:4864:20::34]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7609198b-d6bb-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 17:01:57 +0200 (CEST) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-f16a3e0529so3061567fac.2 for ; Wed, 18 May 2022 08:01:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7609198b-d6bb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fc9KK8mYc1+nLTwXELTaMM6fHsqZOc9DbC5HpaJouSY=; b=b0TLgXfC2tijMOf18Jk3aTgbT1yh+56hExJkFuaVmDSpmhpkEu2nJBEAzLrzXIpAzy hCk1UWlRzY6QUaliXfXdZVgRRZNXj+ALBd7IhvfFg1Cn/7aUHGC5mjRIvKJtrDXhaFUH 80xB4fkc1X/MEm0RBwdjfKg+8+q/rsm/G0bBgmBb6TsAl8b+A0FaoWrqc2Bi/TWmMwZM 9LwBTI9Uy+TlogX5eiS0qKJGKqjqXp2fe2ALRvU0jYpph0rFYKKLci02PGbVKPgSlzzW onfVVWssP9LWANN0toivq8LiLbSoyWnYafBVDEBuRu7OU19+S5/nbIWPVMy98BDDwHgW JGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fc9KK8mYc1+nLTwXELTaMM6fHsqZOc9DbC5HpaJouSY=; b=bav/ajwzKRiiau3LPIE/nhNIfofIwNZPk4v4CjpKMf6PvMtzvy+Otlhe5pyNar6Xvs qPiccAv+ILMwBcVV1TkmXoaP0krUopBJB9B2n5ctVsDGk7Fm+5AWIdIktVibXc/YJTCH A1MFURM1IpPSQ0SOicDl0NnkY1ctQA2G22c/SErbDomQaWIhQhPLE3u9WhrqxteB90Ya 6h6hbHzOP4GMoBvENjWMxAYNKOMvKN/Nef+G+huOcGRxorve5CQ6k9Wv/WzjpDzlmtiw CMeutYSXZle/ky3q8nzqdOd8HB/TwrxVlUDq3+TyEJR+mIHlqxyPKafpVK40cj0O/iG/ utTA== X-Gm-Message-State: AOAM533mWOlLK9v76knCTWJcRGSXA6qrqyvebN9LL0le8rc0JigF8vZs n2gcG/CDchQfVfItGeJFVl167IgO3kyfWbPh68o= X-Google-Smtp-Source: ABdhPJyJMavZbnwU/jCc0Et++pGd+ikS696vUKPFNjYxAdkgM0qnhCKQqwlAg36Hlcjjq6z8zbVYcqQ1I820TTAwlb4= X-Received: by 2002:a05:6870:ea8d:b0:e6:135c:1a2e with SMTP id s13-20020a056870ea8d00b000e6135c1a2emr268714oap.9.1652886116451; Wed, 18 May 2022 08:01:56 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 18 May 2022 11:01:19 -0400 Message-ID: Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Tamas K Lengyel , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel wrote: > > On Thu, May 5, 2022 at 4:27 AM Roger Pau Monn=C3=A9 wrote: > > > > On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: > > > Need to separately specify if the reset is for the memory or for the = VM state, > > > or both. > > > > > > Signed-off-by: Tamas K Lengyel > > > > Reviewed-by: Roger Pau Monn=C3=A9 > > Patch ping. Can this patch be merged please? Patch ping. Tamas From xen-devel-bounces@lists.xenproject.org Wed May 18 15:02:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 15:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332333.556015 (Exim 4.92) (envelope-from ) id 1nrLCO-0001S5-WA; Wed, 18 May 2022 15:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332333.556015; Wed, 18 May 2022 15:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLCO-0001Ry-Sw; Wed, 18 May 2022 15:02:52 +0000 Received: by outflank-mailman (input) for mailman id 332333; Wed, 18 May 2022 15:02:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLCN-0000tx-FH for xen-devel@lists.xenproject.org; Wed, 18 May 2022 15:02:51 +0000 Received: from MTA-08-3.privateemail.com (mta-08-3.privateemail.com [198.54.127.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94f1c1ae-d6bb-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 17:02:50 +0200 (CEST) Received: from mta-08.privateemail.com (localhost [127.0.0.1]) by mta-08.privateemail.com (Postfix) with ESMTP id 336A718000B4 for ; Wed, 18 May 2022 11:02:48 -0400 (EDT) Received: from mail-oi1-f179.google.com (unknown [10.20.151.174]) by mta-08.privateemail.com (Postfix) with ESMTPA id 0E5CA18000B3 for ; Wed, 18 May 2022 11:02:48 -0400 (EDT) Received: by mail-oi1-f179.google.com with SMTP id j12so2979598oie.1 for ; Wed, 18 May 2022 08:02:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94f1c1ae-d6bb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1652886168; bh=LW4XxqWXz+2GnryvG/NbA7hfXZFNFa+imz9uW0VVUnI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mOLHv8kSFT08Ob4vvzTjRwOpDwbvi+lfn4S6IsI33BhwOMZsaQ+KzGar1s6foZCvM fOGx5YpiqGqeuh4ZcbXRhfL9RDSQAfd3j5kbiSFlsN4u/tgHMwtl6kb5+5ZT0PoMN9 VQSeYR/uTkYP+bVgm52c41/R1vDNN/X9JvB3PLqcxb3bci83htzxT2JbyHs92mc+xa flvDzCfBakzWPUtWObdrxoiKjoDCH1g97ZRhFCqTyrCW4mKZ9EWek57ou607cS7w0K IK2cjDwXWRhu3wOl9o5qRQWeI7kZ8XfTw3XO3N19RLZe6+ELIUzSHWoWM2OWklEFF2 bpkyFjc3+KVKg== X-Gm-Message-State: AOAM532wQX4RgXro5Kte6oU8WQn8yugeJ+mye5iUIiWHb0XrIATq+uLK RhK0e25qORxKUaSu+niWiaC671lilhM8F6HD9Uc= X-Google-Smtp-Source: ABdhPJzT0VjETOi6gcpFlHgSbtJYA8Qo0XHWJv8+lEvwsPWSDTubNzv4+sWNtKjZOuKwseSzWPWX27V3tLENMs5VgFs= X-Received: by 2002:a05:6808:249:b0:326:5ccd:1688 with SMTP id m9-20020a056808024900b003265ccd1688mr209874oie.9.1652886167368; Wed, 18 May 2022 08:02:47 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 18 May 2022 11:02:11 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Alexandru Isaila , Petre Pircalabu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jun Nakajima , Kevin Tian Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 12, 2022 at 9:47 AM Tamas K Lengyel wrote: > > On Wed, May 4, 2022 at 9:12 AM Tamas K Lengyel wrote: > > > > On Wed, Apr 27, 2022 at 11:51 AM Tamas K Lengyel > > wrote: > > > > > > Add monitor event that hooks the vmexit handler allowing for both sync and > > > async monitoring of events. With async monitoring an event is placed on the > > > monitor ring for each exit and the rest of the vmexit handler resumes normally. > > > If there are additional monitor events configured those will also place their > > > respective events on the monitor ring. > > > > > > With the sync version an event is placed on the monitor ring but the handler > > > does not get resumed, thus the sync version is only useful when the VM is not > > > expected to resume normally after the vmexit. Our use-case is primarily with > > > the sync version with VM forks where the fork gets reset after sync vmexit > > > event, thus the rest of the vmexit handler can be safely skipped. This is > > > very useful when we want to avoid Xen crashing the VM under any circumstance, > > > for example during fuzzing. Collecting all vmexit information regardless of > > > the root cause makes it easier to reason about the state of the VM on the > > > monitor side, hence we opt to receive all events, even for external interrupt > > > and NMI exits and let the monitor agent decide how to proceed. > > > > > > Signed-off-by: Tamas K Lengyel > > > --- > > > v5: wrap vmexit fields in arch.vmx structures in the public vm_event ABI > > > > Patch ping. Could a toolstack maintainer please take a look at this? > > The hypervisor side already has a Reviewed-by. > > Patch ping. Patch ping. Tamas From xen-devel-bounces@lists.xenproject.org Wed May 18 15:31:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 15:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332342.556027 (Exim 4.92) (envelope-from ) id 1nrLdw-0004uj-9s; Wed, 18 May 2022 15:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332342.556027; Wed, 18 May 2022 15:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLdw-0004uc-6V; Wed, 18 May 2022 15:31:20 +0000 Received: by outflank-mailman (input) for mailman id 332342; Wed, 18 May 2022 15:31:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLdu-0004uS-Hc; Wed, 18 May 2022 15:31:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLdu-0007Tj-D2; Wed, 18 May 2022 15:31:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLdu-0006p8-3O; Wed, 18 May 2022 15:31:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrLdu-0007i0-0u; Wed, 18 May 2022 15:31:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yEMcBXqIIMzcHvgBUXu/qzTVTQfJAnrMyp5L63MQRhA=; b=jN/89+T9iGOXeDenSTQ9/nHGTt NvclTph7TAIpZMfOyx1Jqqa7OnUEjvWbac+IFWtcXLGYKvPwLHRPpm+WnGB2OprZq1H3uFMjWHZS6 fEhVwndF4JQOX7bhzNx+4GCpYiBi+tlYMxMCeLh6fwEUcy8Ko2Icf1fRKIkpdZVIzZ3E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170529: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=69589c374a92d1b4f97db24623e5f760990eaf82 X-Osstest-Versions-That: xen=69589c374a92d1b4f97db24623e5f760990eaf82 From: osstest service owner Date: Wed, 18 May 2022 15:31:18 +0000 flight 170529 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170529/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 170520 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170520 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170520 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170520 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170520 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170520 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170520 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170520 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170520 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170520 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170520 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170520 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170520 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 69589c374a92d1b4f97db24623e5f760990eaf82 baseline version: xen 69589c374a92d1b4f97db24623e5f760990eaf82 Last test of basis 170529 2022-05-18 05:30:55 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed May 18 15:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 15:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332353.556038 (Exim 4.92) (envelope-from ) id 1nrLuY-0006kU-TM; Wed, 18 May 2022 15:48:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332353.556038; Wed, 18 May 2022 15:48:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLuY-0006kN-QE; Wed, 18 May 2022 15:48:30 +0000 Received: by outflank-mailman (input) for mailman id 332353; Wed, 18 May 2022 15:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrLuX-0006kF-Ls for xen-devel@lists.xenproject.org; Wed, 18 May 2022 15:48:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5f14835-d6c1-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 17:48:28 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-L-sfRauxOGildq7AWMHa-A-1; Wed, 18 May 2022 17:48:25 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6881.eurprd04.prod.outlook.com (2603:10a6:208:18b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 15:48:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.014; Wed, 18 May 2022 15:48:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5f14835-d6c1-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652888908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TVFyFHQJ+hXNVPzakcJVNOSZWmHIhHRHL54cgecHf0c=; b=YZpchhzjtqbkNyaclzKHk4JB+Qb/1j7StJrll9oluxY3kwGqcrAZhrgU9CS/E0/+at8PkG BhWBg7jVD+74bpsz3DNsgv6Z4GPj73Q7HzFNCP62MDSlbqbgsa1utpe6nqcE4u49/3ZXZi oOVusFM0+z8LPpg9k+1/N9dqaRArsQY= X-MC-Unique: L-sfRauxOGildq7AWMHa-A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTtv54dGdoQ1vp/JnSybRf+m6Sov7wueIgGd/CbrEZ+fLYxDaM5MY0/VLBP8TYY/nlW8Sk8o97Y6coE5WEaK63QsS5Ix6althkjE7AqE+cjUQIjRSoYkqlZMYQ0Pmi6BsSse/+uayk7RyKorwZwUPfBfZioyM1DMFLzHaAUnTM2VFqokCdVMSCQTj0BE96GTMdrtVZI9qZKjsKdq03mBntBO+6dcXuqv0xxfLkLwurNm9CC9Bcd2X/Qg1sPj9SPCNvD3lXANMKNl8nQd06ZzkfOdNKNgNw3ApiAX8oTJLeALBMnsqD/MjtCpk/Vb/G/KJnmnsZUsL7piTSa7ucfSBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rLlpkTtQDqtchdeTjjGOXc+ziaYovd/iPJhRB3sY04I=; b=IMKpC1StFmVsgxnfwEK6f4ynqoqsggJbP3z9aid6rTrvLUXfBkL6zyFdoZshJutNSpujqDVkN6elqQUwP4MJ8VYceY3q+hspZPzhEkML5x6/TIjDvS/5IDWpy6nfuuk/RCZ5uvX7fiVANp02McQfFWFNpFLIlibO2f4dVWDu1ginezv291Wd6kQ8MZ8HuV0qalRgEN+/u013rh1/Fh7GFmQj06+Z865iwYp6ymdmAOxXxCpHr167fDlKNV7sy1s3zpI4FQJk7kFWpI/q21mp1AQSPcFu736ry0wqiATzVmEGHOZxRyaMMkhuaeB71yA03gYEM20L3EtkscM5eM1x7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 18 May 2022 17:48:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor Content-Language: en-US To: Tamas K Lengyel CC: Tamas K Lengyel , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 861c389f-8208-4455-6ee5-08da38e5d773 X-MS-TrafficTypeDiagnostic: AM0PR04MB6881:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CxHwg3lXdieaQycelg4NJE5UnMNdw8WkbQc22Xkmy7rG5T5GUOdjQcGUcOh9LBzrswcdIWPCuWN2nS939YL4qPv8IE6LCdfk2KRaytIjngrLXBtUjxFjtW/lO0OyAXUPSiLtLB58vqfnLOKP3fALfzdWBl18f5FuQHdgdPT6SrLKw9xmL72PspaiA0MvLNwanmeDxT9fP/FLwDZ9jt6Sw3fbPc5eNpLWM+FvsUvvwJooE8kqczmnRhcV/Elm4HMDSMLf5V5XmHzBkFRtBR1XHl85oK8YEfJmEUOtV0THjvokxuI4LD6skYh9JCq1fJupnNXAb1DMZO2qQMqUN3QPOWvuR/7S4jcfGsv5fn1w6hwfPKnAySonLihq6r8SHFNYBwTrTfg/LRr3j8ipG4IpGqZDrWIGSQUojwGbdWKk4ueuEhQ/1bStpdC1NwANaeBlTs8a9kK5QtU2o+EiMSH0yKO/jadxT5ddK5ICCL0WmnJitmeJQl1m26SAN08WdxW7Z4yoypDZryyF3FP/MdyYyUBpRv9dnW1xvnDEtXiN9xHWNp7kkZfEwQiNdjx6r7F3D76jTG7RAE+g8GzTup9LuCC+0B6cTqLFmSL7iXfSeyffoGXarXVPIn7nVIM6LY/r0W0k7/W3RbqlxyJyABfDmK74E07IA7Diuk7gv2NxZdrjWXy1fM1Xwt4ErexDLR15FF1JtmMJ656m0k8N4+JP5UaPlToyH1PlET40PrrAq0Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6506007)(54906003)(186003)(31686004)(5660300002)(2906002)(4744005)(36756003)(508600001)(6916009)(6512007)(86362001)(38100700002)(4326008)(8676002)(31696002)(66556008)(2616005)(316002)(66946007)(53546011)(66476007)(6486002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lZiFi3/yW+sPpYzAkBsXaExG8wE1LRHi/FAUZS88cJSNh+LWEItyrZkgPF8n?= =?us-ascii?Q?BESWliWaB5yyXS5/Ka3u6O7SMjs3kc8+p+8GiEB8fnLG6MWmodmPXFsdArzO?= =?us-ascii?Q?QXCjSbjXG1s6ilCEzptacT/icfOKVYrtKRfa9UH+zbc7VQJLGlh27YksMCge?= =?us-ascii?Q?3IrS43CnLwPNT0hSYMGTU4ehG6XUNx9Iphm+YFIqmMQuEK62e6qbKiYyUIlc?= =?us-ascii?Q?KR8MBUdEAuk2G0XboCWzILZ3q7n/jZolocTAIF1870PCpSYsZ2wtsmrfwQkh?= =?us-ascii?Q?SUOuNCJGxOCok1yndjs4x5VgaJYKRnQ+bdTFrbd6CrSgZhwi+7dhgDQfOxrq?= =?us-ascii?Q?s2KAUkooDJ5N0PmRz5e+Sv/qxfGCg7V/Y7iZkYRJT8UV8XkCbPYoRlo9M/or?= =?us-ascii?Q?S9IKeeK+ZgMcrQPj89+BWlQ6gXDcAquujH83Fyc/VSEhrMbb2r/1qYhendKZ?= =?us-ascii?Q?TfagYP66XP14pkY/CzQJ8YDF3Sy86NvAIfxwXFhe1QCa+MhNfCKTgcIo3ui+?= =?us-ascii?Q?ppvRFpyKaK5Osq5PPuU2+A+TVAYeC9wJtOVkJSUxGQY9mAcdYOo1g+nkHhd1?= =?us-ascii?Q?kSb55IQg8QgmC/0Aja9B6+BSuA/ii3Af5HAevSJwPzwX3CgJwmhTd9vdEQEn?= =?us-ascii?Q?MGu1Mg89WwW3pn3eYjeYYHfWyp89TXQ6IZyNZNTgIjA+B1+8tE2glNk0BnPP?= =?us-ascii?Q?Zak1ruHCv7i4JtMV9gAVv7yT4Eer7evpQ7/Pf8/2ilV/gEWKCEoY/JOVMldp?= =?us-ascii?Q?+kY/vCZ4gBsDeUfa1TtW2TQidpf1TxcGBtgABuZJylpFTZD5GumMeAz37tlC?= =?us-ascii?Q?SDfWc75nhGL+esXrKoDtNyA4OR2iZTb4s43BH+GVvaTJ3s712d0Q1y9wbdWc?= =?us-ascii?Q?CQjgjxNZ2+8pdyPf3ska+TAvie0Z2fR+zySdS9H38NxSdHyRX7NUBPuPr21S?= =?us-ascii?Q?+fd8oYcrDrDmaZAsYEHJCVvzaHAxEH3Fo+7i1FXwbY3Cu2vIN9YnuprmnH8E?= =?us-ascii?Q?ks+FZC/I9RUDMd2PiGA5u/3TD5Z1CakBOpyjTy3ni4DoRgF3eaVJOPhb/Cy9?= =?us-ascii?Q?dThW0TPvcC450zLqI0YzsKk0uPqSDaB0SwSmd+CHDTyrT6xCfFXN2eZIwVpI?= =?us-ascii?Q?mMs5Bigyr555Jvh0q82MlMm2+EIVs1cHBFKVRX476vWSlzCZyXs9qNKd5+2j?= =?us-ascii?Q?NYYwsTGt67uOkU5TDwKKMDxCCvu36Kj1IQrmJRgzQXHaNMez+mWGHLwBNpq9?= =?us-ascii?Q?7WVcoFjZ54BIqsBqKE91ETwR+7tMNebEM66dpslCtUMnOL6iZfuPW8BhJQky?= =?us-ascii?Q?SVcX2fBselpl/hRNWQbUK7aQty+JY93pr6t2JUoc2uCSSBQw3boHARK/jc+K?= =?us-ascii?Q?ZvcP5oVW6RnUUcfXaC/XxtHdEzhyqBBh/CX/SfhNy6EkjApCtv3T37oNonQq?= =?us-ascii?Q?UeYANvnv3kajoaW2Z9YpEscUw9cMM2+BI7QsaQPH6US61jAtaZj0lUR/qED1?= =?us-ascii?Q?aAV7jO556FdA5NY8PaUqsg5z2njPO3Fr5gI0qqdD5ZcdBJJQstakG3QMZsTO?= =?us-ascii?Q?zlZyqc4KoRQW2UWaqo2vQrzJU/if0D80A/IEOT6B/RKyHEx8AavHzns6zQSh?= =?us-ascii?Q?F//R8CwGjMaV4h05GiOTDtYE/65DdUIIVlemMJxVgIewrmU99u330dAPHr/b?= =?us-ascii?Q?7YZhkKfpbkzkHuyXpVSrdsf2GYaLy2UXBzMeW3miuI7OL96k1a//pSCRUAYB?= =?us-ascii?Q?TPdwDN6Lbg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 861c389f-8208-4455-6ee5-08da38e5d773 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 15:48:24.0929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wkbLgEZcRQGAJUd7uSiKxtJB9CbBagxNFK/eaIahk16EJ14u5pmKWNkOxWc+33nzl3hiGJi3l+IHwwdBIlZkBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6881 On 18.05.2022 17:01, Tamas K Lengyel wrote: > On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel > wrote: >> >> On Thu, May 5, 2022 at 4:27 AM Roger Pau Monn=C3=A9 wrote: >>> >>> On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: >>>> Need to separately specify if the reset is for the memory or for the V= M state, >>>> or both. >>>> >>>> Signed-off-by: Tamas K Lengyel >>> >>> Reviewed-by: Roger Pau Monn=C3=A9 >> >> Patch ping. Can this patch be merged please? >=20 > Patch ping. Your mail (and I guess also your earlier one) was _To_ Roger, which is odd since he already did provide R-b. What you're missing is a tool stack maintainer ack aiui, so it may help if you send your pings _To_ the respective people. Jan From xen-devel-bounces@lists.xenproject.org Wed May 18 16:06:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 16:06:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332361.556049 (Exim 4.92) (envelope-from ) id 1nrMBh-0001Ll-CQ; Wed, 18 May 2022 16:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332361.556049; Wed, 18 May 2022 16:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMBh-0001Le-9a; Wed, 18 May 2022 16:06:13 +0000 Received: by outflank-mailman (input) for mailman id 332361; Wed, 18 May 2022 16:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMBf-0001LY-UD for xen-devel@lists.xenproject.org; Wed, 18 May 2022 16:06:11 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f06918d-d6c4-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 18:06:10 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id d15so4465021lfk.5 for ; Wed, 18 May 2022 09:06:10 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id d25-20020a2e3619000000b0024f812282a4sm251584lja.131.2022.05.18.09.06.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 09:06:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f06918d-d6c4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=w+vvhggY5msFSpuIeQjJEqzu6+KRYjG0/Dyaiz+6Ahk=; b=o26M6FjVrTvwKRycgzqdUgaD/fMY0jNvZPKMBprN5moxEjbqX217K52BG1UyjTlpW8 TkElvlCiEr0oFKj64FnK7D0BTaha0N/RKOAbCZp6lj202WvxDG9+npaV38mjznkxchK0 ca27lzngCapZSKAMZ71QiIF6JaqjhHixL77RF5Bgznjpw5Stn3YUEnJk7Ljy5+7O5rfS AeefrWPMFfMpSVc26Nd93nZqazft3eY/qwXCAtgu5VEdGtAYjSOMBZWD5xn/6e4p2iq3 q6td1dLpMO660K30fnggqk/bf3MfyuwonxtLf5vHC1eQ+bsW7qdtNcAqhVyDZeihDgFS iSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=w+vvhggY5msFSpuIeQjJEqzu6+KRYjG0/Dyaiz+6Ahk=; b=szgbqc9xDJfXwP+HJx+MVCAar4W7zkq7et/UJcuxIsk26ohRPQwFMsajjbMzyzkP2l YgCqutR8fa+QIxKKuz9ncBrCeiBu3YC7MaXcDFPrcsgMgI34qyZ2NxqCLf5cY36L9fZp nYxqpOSc5dHTNHpHTOpj8PL7e/g512jehXmxl3k7t/PMh+BscjEePTSkfO18RyvA9PGK 0OjkcOY19Yk3x42GZHiLed2e5XGTCrFG0UuxBu1s82GIim5FEcow1C9ZS0C0eX1CNxeF ullQJFlMHMPIEdHIPbLg2/Ov8EJt/6jVACGOZB3BQ0W7REE44+3YbKqv1+29CPtnO8aC 16Og== X-Gm-Message-State: AOAM531IhPLAbeNPIDjU4NauvuBK0NdnWuFX1RQCEh9q54IP8PzRlEww 2KDoXatdwH8ZuOft5X3JhWA= X-Google-Smtp-Source: ABdhPJyldHOvI5HvilGZWlaQciM2lbS6jc6SLzHNeG0x1TWsXIo+H5s/vjAmwMcAu+6qxzl7EalYOQ== X-Received: by 2002:a19:e203:0:b0:477:c1bc:452 with SMTP id z3-20020a19e203000000b00477c1bc0452mr156732lfg.534.1652889970184; Wed, 18 May 2022 09:06:10 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Arnd Bergmann Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> Date: Wed, 18 May 2022 19:06:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 18.05.22 17:32, Arnd Bergmann wrote: Hello Arnd > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: >> diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml >> index 10c22b5..29a0932 100644 >> --- a/Documentation/devicetree/bindings/virtio/mmio.yaml >> +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml >> @@ -13,6 +13,9 @@ description: >> See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for >> more details. >> >> +allOf: >> + - $ref: /schemas/arm/xen,dev-domid.yaml# >> + >> properties: >> compatible: >> const: virtio,mmio >> @@ -33,6 +36,10 @@ properties: >> description: Required for devices making accesses thru an IOMMU. >> maxItems: 1 >> >> + xen,dev-domid: >> + description: Required when Xen grant mappings need to be enabled for device. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + >> required: >> - compatible >> - reg > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? I have to admit - no, I haven't. I was thinking that Xen specific feature should be communicated using Xen specific DT property. > This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. I assume, you are speaking about something like the following? xen_dummy_iommu {    compatible = "xen,dummy-iommu";    #iommu-cells = <1>; }; virtio@3000 {    compatible = "virtio,mmio";    reg = <0x3000 0x100>;    interrupts = <41>;    /* The device is located in Xen domain with ID 1 */    iommus = <&xen_dummy_iommu 1>; }; > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space yes (# 3/7 adds grant-table based allocator) > , but it would think it's > conceptually close enough that it makes sense for the binding. Interesting idea. I am wondering, do we need an extra actions for this to work in Linux guest (dummy IOMMU driver, etc)? > > Arnd -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 18 16:10:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 16:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332369.556060 (Exim 4.92) (envelope-from ) id 1nrMFs-0002kk-Vj; Wed, 18 May 2022 16:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332369.556060; Wed, 18 May 2022 16:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMFs-0002kd-Rm; Wed, 18 May 2022 16:10:32 +0000 Received: by outflank-mailman (input) for mailman id 332369; Wed, 18 May 2022 16:10:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMFr-0002kT-NW; Wed, 18 May 2022 16:10:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMFr-0000F5-Ky; Wed, 18 May 2022 16:10:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMFr-0000OR-Az; Wed, 18 May 2022 16:10:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrMFr-0005XZ-AU; Wed, 18 May 2022 16:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IdpgCx738ZtQGNr9O8JlXAaCI/EM5X9iG+58Sy70tDI=; b=OY6UQmM+53KnZcyToq03HJpBtB C2iXEvdkzsvCtamG98y8nnxtyz4SCfNDV7xaq89IICjLNPU6/2EqJ16CaKuTwtzCrNhkPGkv9bj82 T+bKq7roxVEIHW/EyhVKDKvg65UeiRSsnhYMf5H5zsLl+2ALGrsXWca7wsNRhHzgdMUM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170544: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 16:10:31 +0000 flight 170544 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1086 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 105 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 16:14:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 16:14:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332379.556071 (Exim 4.92) (envelope-from ) id 1nrMJv-0003Ti-IY; Wed, 18 May 2022 16:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332379.556071; Wed, 18 May 2022 16:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMJv-0003Tb-EQ; Wed, 18 May 2022 16:14:43 +0000 Received: by outflank-mailman (input) for mailman id 332379; Wed, 18 May 2022 16:14:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMJu-0003TR-Gd; Wed, 18 May 2022 16:14:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMJu-0000J1-EC; Wed, 18 May 2022 16:14:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMJt-0000aJ-RI; Wed, 18 May 2022 16:14:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrMJt-0008CV-Qp; Wed, 18 May 2022 16:14:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=to67g//hyzhUwBtGm0D2UQ7FgseJk7BETVw8areLotQ=; b=5g7c6WranFWUSi6foK02Z9XEM9 D6oO/c3EBu8w2So3HUwQJe4gjZE/aXmEt4M10lDknWafRpMk2Af28vAs0B2imHgsaxipY0fKLMKjE 2SIWMBT9OLxTdhx861+Oo2bD7VwW1hLGKC6zDtBJLSFBIdUpjs3O5gXC1f/t9SADB4dk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170532: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0187300e6aa6246e9cebb22e2afbbc0d395839ee X-Osstest-Versions-That: linux=90659487578cd8a46636b4c507609af44c60a132 From: osstest service owner Date: Wed, 18 May 2022 16:14:41 +0000 flight 170532 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170532/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170454 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170454 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170454 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170454 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170454 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170454 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170454 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170454 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170454 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170454 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170454 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170454 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 0187300e6aa6246e9cebb22e2afbbc0d395839ee baseline version: linux 90659487578cd8a46636b4c507609af44c60a132 Last test of basis 170454 2022-05-15 18:11:16 Z 2 days Testing same since 170532 2022-05-18 08:13:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandra Winter Andreas Gruenbacher Andrew Morton AngeloGioacchino Del Regno Camel Guo Catalin Marinas Chris Packham Christophe JAILLET Daniel Starke David S. Miller Eric Dumazet Ethan Yang Felix Kaechele Feng Tang Florian Fainelli Francesco Dolcini Geliang Tang Greg Kroah-Hartman Guangguan Wang Guenter Roeck Gurucharan (A Contingent worker at Intel) Heikki Krogerus Heiko Carstens Hulk Robot Jakub Kicinski Jamal Hadi Salim Jesse Brandeburg Ji-Ze Hong (Peter Hong) Ji-Ze Hong (Peter Hong) Johan Hovold Johannes Berg Jon Hunter Karsten Graul Linux Kernel Functional Testing Lokesh Dhoundiyal Lyude Paul Manikanta Pubbisetty Mark Brown Martin Habets Mat Martineau Miaoqian Lin Mike Rapoport Nicolas Dichtel Oliver Neukum Paolo Abeni Radhey Shyam Pandey Randy Dunlap Robin Murphy Sasha Levin Scott Chen Sergey Ryazanov Shravya Kumbham Shuah Khan Simon Wunderlich Srinivas Kandagatla Sudip Mukherjee Sudip Mukherjee Sven Eckelmann Sven Schnelle Sven Schwermer Taehee Yoo Tariq Toukan Tejun Heo Tony Nguyen Uwe Kleine-König Waiman Long Willy Tarreau Xiaomeng Tong Yang Yingliang Zack Rusin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 90659487578c..0187300e6aa6 0187300e6aa6246e9cebb22e2afbbc0d395839ee -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Wed May 18 16:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 16:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332392.556081 (Exim 4.92) (envelope-from ) id 1nrMhs-00067J-SF; Wed, 18 May 2022 16:39:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332392.556081; Wed, 18 May 2022 16:39:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMhs-00067C-PH; Wed, 18 May 2022 16:39:28 +0000 Received: by outflank-mailman (input) for mailman id 332392; Wed, 18 May 2022 16:39:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrMhr-000676-Jr for xen-devel@lists.xenproject.org; Wed, 18 May 2022 16:39:27 +0000 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13dbc657-d6c9-11ec-837e-e5687231ffcc; Wed, 18 May 2022 18:39:25 +0200 (CEST) Received: from mail-yb1-f177.google.com ([209.85.219.177]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MNssA-1oFese2Uau-00OD9V for ; Wed, 18 May 2022 18:39:24 +0200 Received: by mail-yb1-f177.google.com with SMTP id i187so2410635ybg.6 for ; Wed, 18 May 2022 09:39:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13dbc657-d6c9-11ec-837e-e5687231ffcc X-Gm-Message-State: AOAM5329ql0mXp79ULdwivlO7+3ZXf4NXleq+sr3tPqzA9kD7/QeNd/b EUb+80yIL/SoizHcUjwLiFSMNi6BXDcTlxJSwUE= X-Google-Smtp-Source: ABdhPJzgO+qZWLWCVNG0zigCWvcyaAMnm3eGdOmvWgnrUQyVgjytOzSGXEWpAN07OlHuwbLMC0znLO5cjVzishwdUG8= X-Received: by 2002:a25:cfd7:0:b0:64d:9526:1ed4 with SMTP id f206-20020a25cfd7000000b0064d95261ed4mr487184ybg.106.1652891963222; Wed, 18 May 2022 09:39:23 -0700 (PDT) MIME-Version: 1.0 References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> In-Reply-To: <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> From: Arnd Bergmann Date: Wed, 18 May 2022 17:39:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Oleksandr Cc: Arnd Bergmann , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:AOTsW5eqCh8NyPfKQ0RVHlpld9aSahzU3E0n3dzqP4uqVD2tiZK j0pWXqNZI3+Yn6Z2xcToqYLyEO9ILsKOaXKUB8RRDxztURmWOKz7lpfGFDGJNb5/9MM10K/ cbuJv85wmLFLRkDw8A/7v8I8H8s+PWjobRQxj+RKsc5c0oh8ho2r0Zd8Ex2YR1nJJLqE5uu 2hQD6+2JT3so+KcMafIZg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fs8AsYdenys=:8lxOqoDbRk5jLfWsTTZN7+ WA7YRHOlKsD1gD/HvVboMFpZWmmIkpNaoHJik2Y/O8yun2Xab9IZpup/ac4UPX8FzAXhm/tEj 4ol5cn9H3n7VKM2iQC1rfvMvcRTZpEm3VA+wFWz+/8eaxc4J7byfh2zXweTtre5WzXNgJh66J aRee0Wl1o2p15EInVLjreThNecxJEB/78h0HCyp+puDg6KvizLbwAIx8I4pIu1YJfli42lXXU MXAHlKbuHZp8vTV31bPJXHLuie67g0GMAqhHwNvHGLZ/gyHR9o0TED4YipPeGY7PnBvEL4jap KH8m68Y6tXwbgIXNZ5IBQRNwGJ66zGIYJ4Rx27xsg6WNooT9EoZPhOqvo00pmpScz7T9vZcQ2 Q0zAe8WDRFh6atUyJVfZq+tyY7nJ1to/FBAxd+w0yyoRjSHYEY8qct0I43+fxjGobU5XMyt3D eVHklGHGWtKx6ieIMCvb7P9QtDouSv23sp17zCLCB8M8Xt0vTHWRvKurntmYhQ3RtA2F/nm9x 5nrMEHLizX0iPAWEFpHsYTz8+PS/6Isd9UAxzFa0Rny347xFfu+4kA/wQAmr+mXyOss6bnlEs IH4y//C5Ave6MMC9GQFvVR2s5Tf42oB17bnfSIalPdvB8rXm2eBEdQUJubHggDiiyJsDe1Z4z libcinN3+hrkexurNkYgJXnjp2+l1ZYIEeO//bz22H29ZoWOw1aTUXtKbCChrT/jFleTesU4k hLXvz4Ox13trC3Kk04MMog3Z0CWcfvqh0D8XrPccPVHoAWM/YK8HPtOPhrdZ6i4ixac0OQsAK i8uIh5N9Xz6z5cIp1v/NKazv2ZzUPwnT213QUHgvOmPOipFQ4WjeErWGcdozf3aV43LYr0Q+L /p4S8fBvX8sQYnKzxzWg== On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: > On 18.05.22 17:32, Arnd Bergmann wrote: > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > This would mean having a device > > node for the grant-table mechanism that can be referred to using the 'iommus' > > phandle property, with the domid as an additional argument. > > I assume, you are speaking about something like the following? > > > xen_dummy_iommu { > compatible = "xen,dummy-iommu"; > #iommu-cells = <1>; > }; > > virtio@3000 { > compatible = "virtio,mmio"; > reg = <0x3000 0x100>; > interrupts = <41>; > > /* The device is located in Xen domain with ID 1 */ > iommus = <&xen_dummy_iommu 1>; > }; Right, that's that's the idea, except I would not call it a 'dummy'. >From the perspective of the DT, this behaves just like an IOMMU, even if the exact mechanism is different from most hardware IOMMU implementations. > > It does not quite fit the model that Linux currently uses for iommus, > > as that has an allocator for dma_addr_t space > > yes (# 3/7 adds grant-table based allocator) > > > > , but it would think it's > > conceptually close enough that it makes sense for the binding. > > Interesting idea. I am wondering, do we need an extra actions for this > to work in Linux guest (dummy IOMMU driver, etc)? It depends on how closely the guest implementation can be made to resemble a normal iommu. If you do allocate dma_addr_t addresses, it may actually be close enough that you can just turn the grant-table code into a normal iommu driver and change nothing else. Arnd From xen-devel-bounces@lists.xenproject.org Wed May 18 17:04:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 17:04:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332404.556093 (Exim 4.92) (envelope-from ) id 1nrN61-000174-Qu; Wed, 18 May 2022 17:04:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332404.556093; Wed, 18 May 2022 17:04:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrN61-00016x-NA; Wed, 18 May 2022 17:04:25 +0000 Received: by outflank-mailman (input) for mailman id 332404; Wed, 18 May 2022 17:04:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrN5z-00016r-Lz for xen-devel@lists.xenproject.org; Wed, 18 May 2022 17:04:23 +0000 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [2607:f8b0:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8fe2e77b-d6cc-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 19:04:22 +0200 (CEST) Received: by mail-ot1-x334.google.com with SMTP id y20-20020a056830071400b00606a2ebd91bso1780744ots.5 for ; Wed, 18 May 2022 10:04:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fe2e77b-d6cc-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1FKO2SC4YduXW1JyydrxoRnczkyFkssvYlUA6YM8QXw=; b=Dbjsdog7x2DC/G8rFYotMdPTAcKDt+MZFUYYnlYERdq2iMXp6RRHND0ilR0WZVS+Lg SAKYHLTnMEs1p8ABkel5nZraGgyLTuNIdNc+ZgpTchv8jwmoEMapMkovva6jWz/my8di 9Ye1BBpCdtE16gQxrZJ4uLaUjN+fGqWQyzYq0k+qVByaNU3VxJTxWMhVXxuoyKX/cmZb tSuwUIKSd7Sthpv4no2p/C/uRqe6GHn6EWpNreFh4Z/p+YZBoDhjNKwOipuUCTgaNY0L lCwGTEedzzabDp7QQ9860XDTTXU2BplpUv/0yECJGZahH1AeVn6XiYTS6gFw34gzU1Rq 4S+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1FKO2SC4YduXW1JyydrxoRnczkyFkssvYlUA6YM8QXw=; b=oVnk5Pm7O5WFR9XdLbADvx5t13GVfAnKIMqS+Y+5O7Jx3ZocqdG4dNX2Ui3FHcuFLY dkEU8xoEgDAjiAHZ0KmuJabv8A7WJiCmbF6qFkAt1gLI+rESdV0bw6NlK/XhrU2nLE4/ EQ60R/ZrgCw65G48G2pxFvyibjG90hZ3JXjfMhNyKq0X7r9WIcFj83of+vIW6rq7ZiiM ykLMHbBHeSagBYtSxO8wFCxgSTvIH8MMppM3vuO9Do8vJdCS4qfIR6vDUK36h9yRfUE4 PyFD9XohwrdWOhmTsgcqkH2+ddgkr5vFWoKRNKQvasx1iqY2eUt9PyfeD6zeUklP1Fwl o5Nw== X-Gm-Message-State: AOAM5328UpI0nI3MzFOkX6sHchH8W1czZ6tPUVqIr/9HFdM+eL3tm/GO D46ayNDsLqSoA1s+8XQ0461fxBx09n0f6Cqn0BOR2iMFyB4= X-Google-Smtp-Source: ABdhPJwBPtvPEiXpLzyo7ka3RcpNGnUqGM8K3GA7sVU5wNJ3GgFZjOGJGzEwMwJXXpx31gyg0fTTQlxQkoCWdtEMgVE= X-Received: by 2002:a05:6830:1e86:b0:606:48b8:252c with SMTP id n6-20020a0568301e8600b0060648b8252cmr276032otr.204.1652893461247; Wed, 18 May 2022 10:04:21 -0700 (PDT) MIME-Version: 1.0 References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 18 May 2022 13:03:45 -0400 Message-ID: Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor To: Jan Beulich , xen-devel@lists.xenproject.org, Juergen Gross , Anthony PERARD , Wei Liu Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 18, 2022 at 11:48 AM Jan Beulich wrote: > > On 18.05.2022 17:01, Tamas K Lengyel wrote: > > On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel > > wrote: > >> > >> On Thu, May 5, 2022 at 4:27 AM Roger Pau Monn=C3=A9 wrote: > >>> > >>> On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: > >>>> Need to separately specify if the reset is for the memory or for the= VM state, > >>>> or both. > >>>> > >>>> Signed-off-by: Tamas K Lengyel > >>> > >>> Reviewed-by: Roger Pau Monn=C3=A9 > >> > >> Patch ping. Can this patch be merged please? > > > > Patch ping. > > Your mail (and I guess also your earlier one) was _To_ Roger, which > is odd since he already did provide R-b. What you're missing is a > tool stack maintainer ack aiui, so it may help if you send your > pings _To_ the respective people. True, but all the toolstack maintainers have been CC-d from the start. Is it the case that CC-ing is now officially insufficient? What's the point of ./scripts/add_maintainers.pl then which specifically adds maintainers only as CC? How are you supposed to get their attention? Just know you specifically have to send emails to them and not the mailinglist? I'm getting the distinct impression that the toolstack side has simply become unmaintained/orphaned with no one left who actually is looking at the mailinglist. Tamas From xen-devel-bounces@lists.xenproject.org Wed May 18 17:32:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 17:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332412.556104 (Exim 4.92) (envelope-from ) id 1nrNXX-0004Yj-2M; Wed, 18 May 2022 17:32:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332412.556104; Wed, 18 May 2022 17:32:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNXW-0004Yc-VT; Wed, 18 May 2022 17:32:50 +0000 Received: by outflank-mailman (input) for mailman id 332412; Wed, 18 May 2022 17:32:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNXV-0004YW-4c for xen-devel@lists.xenproject.org; Wed, 18 May 2022 17:32:49 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86dc5a81-d6d0-11ec-837e-e5687231ffcc; Wed, 18 May 2022 19:32:46 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2482A32008FD; Wed, 18 May 2022 13:32:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 18 May 2022 13:32:43 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 May 2022 13:32:42 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86dc5a81-d6d0-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1652895162; x=1652981562; bh=l3nshceWNm Nh4sbzOcO5cSmfwPWblYE/KIfax+ALspQ=; b=QFMkLX1r/cgDfiTupBMI9D2l31 PjmfEwzC9UAj9TQUVEOL+TOhfwN8ZhZ3/V285O7oAL1Ep2Gl1IMg5mNYugM5neqM g2JPcHp1ognEGx+sJvT7GXOx2hLycscrutbVX9P0wD+EXZ4owvuGzAmFFzLMzJbc B749DQMC0J+8hF8tmA4hf3yU0ioGTwcujI17Y8nP4Jtz+TjpAhL16fcyj2l90/5u tOfoefErVJVLKq5FPuboMhAUmosxWfHK5CPxMCttoW7HZIxOu5J2rBghI22H6+wU J9wsWUxfoWg0Q2+U+keIl+o/RjSHMBwaf9fJ4XTLsOixEnk16KI9Q8AV+Ixg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652895162; x= 1652981562; bh=l3nshceWNmNh4sbzOcO5cSmfwPWblYE/KIfax+ALspQ=; b=w P6lquywixaX+sjALnu9g8Q++0Slfj8N2ePxrRJYitdMrxBfTgrLgbTtUal7mYtfz MHyjvCB73phWO5UZDJJujGCJL/+FOLtKlweM8LV6ekM/N/tr8mc+zG9LPnFqwLqq t6ms+4bX0OYL4RFScNSJRQElJNndpBm9WMO1AejHxszvAKQj0FFAHyHzUgdYj49w oVut+Sv3Dl9RtIzRjFRdmSHnqZSlYJeDzX2us9tkdqfrNkwfve7vEutSIS2dE/HA vZ2Tcw2Ha0EgDcNaolEuciyd7b3O2pVKSGUHjYa29sXJvQ+R2OdQxDGHWVe+Z81I YnXx/LbLXSEwpdS8mkFKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheelgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugesghdtreertddtjeenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepudekteekkeekkedvteegtdektefftdfh tddtgfeifffhkeehhfejhfevgefgieehnecuffhomhgrihhnpehkvghrnhgvlhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 18 May 2022 13:32:33 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Jan Beulich Subject: [PATCH v6] Preserve the EFI System Resource Table for dom0 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H8okDFa7sllZcjg0" Content-Disposition: inline --H8okDFa7sllZcjg0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 18 May 2022 13:32:33 -0400 From: Demi Marie Obenour To: Xen developer discussion Cc: Jan Beulich Subject: [PATCH v6] Preserve the EFI System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification =C2=A723.= 4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour --- Changes since v5: - Use type and field names from EFI specification. - Remove tags from EFI types that do not have them. - Use PrintErr() instead of PrintStr() for error conditions. Changes since v4: - Do not call blexit() (via PrintErrMsg()) if the new ESRT cannot be allocated or installed. - Use the correct comment style. - Remove leftover change from earlier version. - Add a blank line between declarations and statements. - Re-fetch the memory map after allocating the ESRT copy. Changes since v3: - Do not modify the memory map. - Allocate a copy of the ESRT in EfiRuntimeServicesData() memory. xen/common/efi/boot.c | 108 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 106 insertions(+), 2 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..6a829b8278 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -39,6 +39,26 @@ { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b,= 0x23} } #define APPLE_PROPERTIES_PROTOCOL_GUID \ { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a= , 0xe0} } +#define EFI_SYSTEM_RESOURCE_TABLE_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21,= 0x80} } +#define EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION 1 + +typedef struct { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 LowestSupportedFwVersion; + UINT32 CapsuleFlags; + UINT32 LastAttemptVersion; + UINT32 LastAttemptStatus; +} EFI_SYSTEM_RESOURCE_ENTRY; + +typedef struct { + UINT32 FwResourceCount; + UINT32 FwResourceCountMax; + UINT64 FwResourceVersion; + EFI_SYSTEM_RESOURCE_ENTRY Entries[]; +} EFI_SYSTEM_RESOURCE_TABLE; =20 typedef EFI_STATUS (/* _not_ EFIAPI */ *EFI_SHIM_LOCK_VERIFY) ( @@ -567,6 +587,39 @@ static int __init efi_check_dt_boot(const EFI_LOADED_I= MAGE *loaded_image) } #endif =20 +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; + +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start =3D desc->PhysicalStart; + const EFI_SYSTEM_RESOURCE_TABLE *esrt_ptr; + + len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR ) + return 0; + if ( physical_start > esrt || esrt - physical_start >=3D len ) + return 0; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type !=3D EfiRuntimeServicesData) && + (desc->Type !=3D EfiBootServicesData) ) + return 0; + available_len =3D len - (esrt - physical_start); + if ( available_len <=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) + return 0; + available_len -=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); + esrt_ptr =3D (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; + if ( esrt_ptr->FwResourceVersion !=3D EFI_SYSTEM_RESOURCE_TABLE_FIRMWA= RE_RESOURCE_VERSION || + !esrt_ptr->FwResourceCount ) + return 0; + if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->Entr= ies[0]) ) + return 0; + return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +898,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTP= UT_PROTOCOL *gop, return gop_mode; } =20 +static EFI_GUID __initdata esrt_guid =3D EFI_SYSTEM_RESOURCE_TABLE_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +923,8 @@ static void __init efi_tables(void) efi.smbios =3D (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 =3D (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt =3D (UINTN)efi_ct[i].VendorTable; } =20 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1056,9 +1113,7 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHand= le, EFI_SYSTEM_TABLE *Syste EFI_STATUS status; UINTN info_size =3D 0, map_key; bool retry; -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP unsigned int i; -#endif =20 efi_bs->GetMemoryMap(&info_size, NULL, &map_key, &efi_mdesc_size, &mdesc_ver); @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHan= dle, EFI_SYSTEM_TABLE *Syste if ( !efi_memmap ) blexit(L"Unable to allocate memory for EFI memory map"); =20 + efi_memmap_size =3D info_size; + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, + efi_memmap, &map_key, + &efi_mdesc_size, + &mdesc_ver); + if ( EFI_ERROR(status) ) + PrintErrMesg(L"Cannot obtain memory map", status); + + /* Try to obtain the ESRT. Errors are not fatal. */ + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) + { + /* + * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * so that the memory it is in will not be used for other purposes. + */ + void *new_esrt =3D NULL; + size_t esrt_size =3D get_esrt_size(efi_memmap + i); + + if ( !esrt_size ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D=3D + EfiRuntimeServicesData ) + break; /* ESRT already safe from reuse */ + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + &new_esrt); + if ( status =3D=3D EFI_SUCCESS && new_esrt ) + { + memcpy(new_esrt, (void *)esrt, esrt_size); + status =3D efi_bs->InstallConfigurationTable(&esrt_guid, new_e= srt); + if ( status !=3D EFI_SUCCESS ) + { + PrintErr(L"Cannot install new ESRT\r\n"); + efi_bs->FreePool(new_esrt); + } + } + else + PrintErr(L"Cannot allocate memory for ESRT\r\n"); + break; + } + for ( retry =3D false; ; retry =3D true ) { efi_memmap_size =3D info_size; @@ -1753,3 +1848,12 @@ void __init efi_init_memory(void) unmap_domain_page(efi_l4t); } #endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --H8okDFa7sllZcjg0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKFLbgACgkQsoi1X/+c IsFciw/9FCy+ACtapGkS/J1+T5kTYfxNG1ivKYNboF2j0kU5mp5u3G0DA3D0H9eK gHyl2o7vsWBLob6oebr3uAtL7aG7c/mFu7k79r7k+xVm5miWIVvF4e2FM+f5kKwJ vQMKTylb2rY91g5M0+w6icCWWsmdh5bhCMRrWBoH2lfZuGL4Uu3DvdJ4uQotDPU/ rmE3noTLKhRS8ZtH81r3wQ87faQ6l/LknvMe6yMah4mwK/e+110L55cOuGdNOW6m 9Q9JuBKK3Fcl4ZNxBrMl6hn47ZgIuqN7h419I51wzjPRJYdNghvWGhKMe5MpvgMN LmNafPRGsXdhqeLez/b57vAUDIbEmPJQOlwGXOjTcySDpyjHtpxvd1kYBjITPHsR otjJcEmMYtYHmGvnImCv5dyil8gkf28bcrjH4rWVmpt4kYtHScAwUNi9tmXie8IA a6qti3pZERFlb6FQ2cZTo8tOcuYfocNxCuvnwGBY+vOsUSMVF01j02tzVCTyx7sQ J4XDlXT9hCa1EQST9iOPFKoDTfkB7nm7wADHl4+n+0wXK/j0mfWN/zYiz2QznkiK eALBjytD5itGPz5qZvZctGEa4BzgX9T9tUScPg5zefiYd0IXtgCOUYd7NF0HBqxv pydE1TBsx5I/fy8mZEdyXrs04ZggJoMvXFlHbdfOUShP4h3htMY= =qWNX -----END PGP SIGNATURE----- --H8okDFa7sllZcjg0-- From xen-devel-bounces@lists.xenproject.org Wed May 18 17:48:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 17:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332424.556115 (Exim 4.92) (envelope-from ) id 1nrNmS-00069w-EG; Wed, 18 May 2022 17:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332424.556115; Wed, 18 May 2022 17:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNmS-00069p-AQ; Wed, 18 May 2022 17:48:16 +0000 Received: by outflank-mailman (input) for mailman id 332424; Wed, 18 May 2022 17:48:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNmQ-00069j-Jk for xen-devel@lists.xenproject.org; Wed, 18 May 2022 17:48:14 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af62aa81-d6d2-11ec-837e-e5687231ffcc; Wed, 18 May 2022 19:48:12 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E30243200940; Wed, 18 May 2022 13:48:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 18 May 2022 13:48:10 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 May 2022 13:48:07 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af62aa81-d6d2-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652896089; x= 1652982489; bh=Ss8aixtbuvwZLZjYqXXq17seWN/wHL4KYaWqyXIwbtM=; b=m Pu/HCNhYkYjtWu4hRYGrZe8o9wh7B/9AGTeALZy4XdDNx6s/Gj1hyJaPwWtJy/HH zp0IS2sdezL2Z05qzEnkqGo+wLja5XhPJib/IXCbeL4UA7OohyT5IcYFw6+7py+V /MC6HEQaly5gQUmd16zyeEzn6qOPfCNrOCVu2j9Z1405CuRxPd1ONrYh3qjJ+F4P LnRL0d//SQIiKyLZmKSdAwhdew+toJo4HCpwritCaSYyWd4C82OXf8sszCFn6cEf mow02qf734xQJKXc4+0xpE4j6tgpMsW2f9Bo7UxfQ8Sc/KDTQhqPw97Kz5IgzEIm d4ndP2ZpUXh4BOBSnm4hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652896089; x=1652982489; bh=Ss8aixtbuvwZLZjYqXXq17seWN/w HL4KYaWqyXIwbtM=; b=mLJOFJUcXYhexIQbmYKgujRBWGej40YdCvl9lmnKTyQS jIKVPlH9yRiVfK4nt58Of4vfGdfYaZKMePlcMZEwnHMcQrzk0rOd4ZH/DrlE+UVR g4amRoh/+4rNdp1JyC9rDkerqV5KmdXmv+aTfjkBvSivIGh20cvbYAKQUkODQUDZ spqvU6bEZpuDYmLFTe6JtfbEXGksdCVVg9eV/Uvgg7+uts3Ia9MBYfa0SNW0lUXS F9yS1YWNZm0pHt5GE9V02HKrlOc2jin8Sai0EAdMsnyuoMe8FIRX4PME8ycf4Np/ iIz5tYDyaypHFlrK3ilZDY5gpP8VCogBTdwC14OcFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheelgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 18 May 2022 19:48:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220511143059.1826794-1-marmarek@invisiblethingslab.com> <9ad924ae-1a40-6ac4-55ec-a468dadf5dcf@suse.com> <12c5e743-0d7a-4866-ec92-03081b127619@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FCR9h3p3e0ZGkO74" Content-Disposition: inline In-Reply-To: <12c5e743-0d7a-4866-ec92-03081b127619@suse.com> --FCR9h3p3e0ZGkO74 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 18 May 2022 19:48:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff On Tue, May 17, 2022 at 05:46:07PM +0200, Jan Beulich wrote: > On 17.05.2022 17:43, Roger Pau Monn=C3=A9 wrote: > > On Tue, May 17, 2022 at 05:13:46PM +0200, Jan Beulich wrote: > >> On 17.05.2022 16:48, Roger Pau Monn=C3=A9 wrote: > >>> On Tue, May 17, 2022 at 04:41:31PM +0200, Jan Beulich wrote: > >>>> On 11.05.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: > >>>>> --- a/xen/drivers/char/ns16550.c > >>>>> +++ b/xen/drivers/char/ns16550.c > >>>>> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t= skip_amt, unsigned int idx) > >>>>> pci_conf_read8(PCI_SBDF(0, b, d, f), > >>>>> PCI_INTERRUPT_LINE) : 0; > >>>>> =20 > >>>>> + if ( uart->irq =3D=3D 0xff ) > >>>>> + uart->irq =3D 0; > >>>>> + if ( !uart->irq ) > >>>>> + printk(XENLOG_INFO > >>>>> + "ns16550: %pp no legacy IRQ, using poll= mode\n", > >>>>> + &PCI_SBDF(0, b, d, f)); > >>>>> + > >>>>> return 0; > >>>>> } > >>>>> } > >>>> > >>>> While this code is inside a CONFIG_HAS_PCI conditional, I still > >>>> think - as was previously suggested - that the 1st if() should be > >>>> inside a CONFIG_X86 conditional, to not leave a trap for other > >>>> architectures to fall into. > >>> > >>> The CONFIG_HAS_PCI region is itself inside of a (bigger) CONFIG_X86 > >>> region already. > >> > >> But that's likely to change sooner or later, I expect. I'd rather see > >> the surrounding region be shrunk in scope. Already when that > >> CONFIG_X86 was introduced I had reservations, as I don't think all of > >> the enclosed code really is x86-specific. > >=20 > > My though was that anyone removing the CONFIG_X86 guard will already > > have to deal with setting ->irq properly, as I expect this will differ > > between arches, at which point the check are likely to diverge anyway. >=20 > Hmm, true. What I would really like (and what I should have spelled out) > is that the build would fail if this code was enabled for no-x86, such > that it ends up very obvious that something needs doing there. Hence ... >=20 > > In any case, I don't see an issue with adding an extra guard, albeit a > > comment would also be acceptable IMO. >=20 > ... maybe >=20 > #ifdef CONFIG_X86 > ... > #else > # error > #endif The whole section was wrapped in CONFIG_X86, so I haven't added it once again. But if that's desirable, I can wrap the 0xff IRQ handling in yet another CONFIG_X86 guard (since the spec says this value is x86 specific). I don't think having #error in non-x86 case makes much sense here. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --FCR9h3p3e0ZGkO74 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmKFMVMACgkQ24/THMrX 1ywGeAgAhcB4xgdQHa5q2xAibLfDPdx6l4W0LdWe0se5B2jZhqA61kxwjddWmOOj GBh9Q8XVnalDndPNABlPXpkEhWYmBYClktFZNRzbEtnlKeAD++oQ24mCtj4OkKz0 ApZgnwCeTt5vUnvZztYGn1kEutyXa2nG8D0H049wH1wbyxHu/cZrxYbkQf3IJog1 KIGkZUzRibOsRmkQMj2uedRWkPJzxVXpVK4zmtNAPx1MER1kgr7C9W8Pqr8x4/Ss /SW54iuW05t2EmA5ayCczkPMgf6VNJJcdE4HxAJjU02WDVqViYsziJuutFF5Uw0K YDQr0/Mcm75aittanK7DTDR7AiZ5/g== =nKJL -----END PGP SIGNATURE----- --FCR9h3p3e0ZGkO74-- From xen-devel-bounces@lists.xenproject.org Wed May 18 17:48:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 17:48:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332425.556126 (Exim 4.92) (envelope-from ) id 1nrNma-0006U7-Ug; Wed, 18 May 2022 17:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332425.556126; Wed, 18 May 2022 17:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNma-0006U0-Qx; Wed, 18 May 2022 17:48:24 +0000 Received: by outflank-mailman (input) for mailman id 332425; Wed, 18 May 2022 17:48:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNmZ-0006T7-0p; Wed, 18 May 2022 17:48:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNmY-0001sK-Vz; Wed, 18 May 2022 17:48:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrNmY-0004vz-JE; Wed, 18 May 2022 17:48:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrNmY-0007TD-Im; Wed, 18 May 2022 17:48:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9MT0lnRLm/4V2Aez6P1/8d/yPK6yVsHq9PzVM4wJ93o=; b=X881amf4eko6m2lgsP49iCQmiv okhqoXbNamGQoVku82fE4eQ04XkMWN+r21LkraIt4IQzrdclZUW/F2Z27PxiKDj5TEFO9dnYlD3JN UPlHWb8SLsg/0BQO8Tiw5IfSDtqYot3+CgqqHF2lDJRGCJ57DpQvGKHlbqG02F/aJkdI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170547: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 17:48:22 +0000 flight 170547 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170547/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1087 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 106 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 18:32:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 18:32:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332447.556136 (Exim 4.92) (envelope-from ) id 1nrOSg-0004Yp-5Q; Wed, 18 May 2022 18:31:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332447.556136; Wed, 18 May 2022 18:31:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOSg-0004Yi-2h; Wed, 18 May 2022 18:31:54 +0000 Received: by outflank-mailman (input) for mailman id 332447; Wed, 18 May 2022 18:31:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOSe-0004Yc-00 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 18:31:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOSc-0002g7-Fs; Wed, 18 May 2022 18:31:50 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[10.95.143.196]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrOSc-0001bO-24; Wed, 18 May 2022 18:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=qbaZJgFoVl7FyJ/0Eyr+451DJr6dzsHNu+3Tdv9xf0w=; b=F8zYvB14eiJVJHCw6wX1o7wb4U xFuFiVfbRw3SJABgV73/frVB6iWUcBP1Ng46NAc6bHhlBYc+fUH49xA5TQhiT95m5NTdp604UUHcf edtYoYoanMXSnLtzFcaLksx8Q22w/kpwa0wI3XraljSaX0SELdz4faYQJmqFTZSzBtAQ=; Message-ID: Date: Wed, 18 May 2022 19:31:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 10/14] xen/arm: Implement device tree node removal functionalities To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-11-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-11-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vikram, On 08/03/2022 19:47, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using > device tree overlay. > > xl overlay remove file.dtbo: > Removes all the nodes in a given dtbo. > First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes > in dt_host and delete the device node entries from dt_host. > > The nodes get removed only if it is not used by any of dom0 or domio. > > Also, added overlay_track struct to keep the track of added node through device > tree overlay. overlay_track has dt_host_new which is unflattened form of updated > fdt and name of overlay nodes. When a node is removed, we also free the memory > used by overlay_track for the particular overlay node. > > Signed-off-by: Vikram Garhwal > --- > xen/common/Makefile | 1 + > xen/common/dt_overlay.c | 447 +++++++++++++++++++++++++++++++++++ > xen/common/sysctl.c | 10 + > xen/include/public/sysctl.h | 18 ++ > xen/include/xen/dt_overlay.h | 47 ++++ > 5 files changed, 523 insertions(+) > create mode 100644 xen/common/dt_overlay.c > create mode 100644 xen/include/xen/dt_overlay.h > > diff --git a/xen/common/Makefile b/xen/common/Makefile > index dc8d3a13f5..2eb5734f8e 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -54,6 +54,7 @@ obj-y += wait.o > obj-bin-y += warning.init.o > obj-$(CONFIG_XENOPROF) += xenoprof.o > obj-y += xmalloc_tlsf.o > +obj-$(CONFIG_OVERLAY_DTB) += dt_overlay.o > > obj-bin-$(CONFIG_X86) += $(foreach n,decompress bunzip2 unxz unlzma lzo unlzo unlz4 unzstd earlycpio,$(n).init.o) > > diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c > new file mode 100644 > index 0000000000..fcb31de495 > --- /dev/null > +++ b/xen/common/dt_overlay.c > @@ -0,0 +1,447 @@ > +/* > + * xen/common/dt_overlay.c > + * > + * Device tree overlay support in Xen. > + * > + * Copyright (c) 2021 Xilinx Inc. > + * Written by Vikram Garhwal > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms and conditions of the GNU General Public > + * License, version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > +#include > +#include > +#include > +#include > +#include > + > +static LIST_HEAD(overlay_tracker); > +static DEFINE_SPINLOCK(overlay_lock); > + > +static int dt_overlay_remove_node(struct dt_device_node *device_node) > +{ > + struct dt_device_node *np; > + struct dt_device_node *parent_node; > + struct dt_device_node *current_node; > + > + parent_node = device_node->parent; > + > + current_node = parent_node; > + > + if ( parent_node == NULL ) > + { > + dt_dprintk("%s's parent node not found\n", device_node->name); > + return -EFAULT; > + } > + > + np = parent_node->child; > + > + if ( np == NULL ) > + { > + dt_dprintk("parent node %s's not found\n", parent_node->name); > + return -EFAULT; > + } > + > + /* If node to be removed is only child node or first child. */ > + if ( !dt_node_cmp(np->full_name, device_node->full_name) ) > + { > + current_node->allnext = np->allnext; While reviewing the previous patches, I realized that we have nothing to prevent someone to browse the device-tree while it is modified. I am not sure this can be solved with just refcounting (like Linux does). So maybe we need a read-write-lock. I am open to other suggestions here. > + > + /* If node is first child but not the only child. */ > + if ( np->sibling != NULL ) > + current_node->child = np->sibling; > + else > + /* If node is only child. */ > + current_node->child = NULL; Those 4 lines can be replaced with one line: current_node->child = np->sibling; > + return 0; > + } > + > + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) > + { > + current_node = np; > + if ( !dt_node_cmp(np->sibling->full_name, device_node->full_name) ) > + { > + /* Found the node. Now we remove it. */ > + current_node->allnext = np->allnext->allnext; I find this code quite confusing to read. AFAICT, 'np' and 'current_node' are exactly the same here. Why do you use different name to access it? > + > + if ( np->sibling->sibling ) > + current_node->sibling = np->sibling->sibling; > + else > + current_node->sibling = NULL; Same here. This could be replaced with: current_node->child = nb->sibling->sibling; > + > + break; > + } > + } > + > + return 0; > +} > + > +/* Basic sanity check for the dtbo tool stack provided to Xen. */ > +static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) > +{ > + if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) || > + fdt_check_header(overlay_fdt) ) > + { > + printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n"); > + return -EINVAL; > + } > + > + return 0; > +} > + > +static unsigned int overlay_node_count(void *fdto) > +{ > + unsigned int num_overlay_nodes = 0; > + int fragment; > + > + fdt_for_each_subnode(fragment, fdto, 0) > + { > + > + int subnode; > + int overlay; > + > + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); > + > + /* > + * Overlay value can be < 0. But fdt_for_each_subnode() loop checks for > + * overlay >= 0. So, no need for a overlay>=0 check here. > + */ > + > + fdt_for_each_subnode(subnode, fdto, overlay) > + { > + num_overlay_nodes++; > + } > + } > + > + return num_overlay_nodes; > +} > + > +/* > + * overlay_get_nodes_info will get the all node's full name with path. This is > + * useful when checking node for duplication i.e. dtbo tries to add nodes which > + * already exists in device tree. > + */ AFAIU the code below will only retrieve one level of nodes. So if you have foo { bar { } } Only foo will be part of the nodes_full_path. Is it correct? > +static int overlay_get_nodes_info(const void *fdto, char ***nodes_full_path, > + unsigned int num_overlay_nodes) > +{ > + int fragment; > + unsigned int node_num = 0; > + > + *nodes_full_path = xmalloc_bytes(num_overlay_nodes * sizeof(char *)); > + > + if ( *nodes_full_path == NULL ) > + return -ENOMEM; > + memset(*nodes_full_path, 0x0, num_overlay_nodes * sizeof(char *)); > + > + fdt_for_each_subnode(fragment, fdto, 0) > + { > + int target; > + int overlay; > + int subnode; > + const char *target_path; > + > + target = fdt_overlay_target_offset(device_tree_flattened, fdto, > + fragment, &target_path); > + if ( target < 0 ) > + return target; > + > + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); > + > + /* > + * Overlay value can be < 0. But fdt_for_each_subnode() loop checks for > + * overlay >= 0. So, no need for a overlay>=0 check here. > + */ > + fdt_for_each_subnode(subnode, fdto, overlay) > + { > + const char *node_name = NULL; > + unsigned int node_name_len = 0; > + unsigned int target_path_len = strlen(target_path); > + unsigned int node_full_name_len = 0; > + > + node_name = fdt_get_name(fdto, subnode, &node_name_len); > + > + if ( node_name == NULL ) > + return -EINVAL; > + > + /* > + * Magic number 2 is for adding '/'. This is done to keep the > + * node_full_name in the correct full node name format. > + */ > + node_full_name_len = target_path_len + node_name_len + 2; > + > + (*nodes_full_path)[node_num] = xmalloc_bytes(node_full_name_len); > + > + if ( (*nodes_full_path)[node_num] == NULL ) > + return -ENOMEM; > + > + memcpy((*nodes_full_path)[node_num], target_path, target_path_len); > + > + (*nodes_full_path)[node_num][target_path_len] = '/'; > + > + memcpy((*nodes_full_path)[node_num] + target_path_len + 1, node_name, > + node_name_len); > + > + (*nodes_full_path)[node_num][node_full_name_len - 1] = '\0'; > + > + node_num++; > + } > + } > + > + return 0; > +} > + > +/* Remove nodes from dt_host. */ > +static int remove_nodes(char **full_dt_node_path, int **nodes_irq, > + int *node_num_irq, unsigned int num_nodes) Most of the information above are stored in overlay_track. So can we pass a pointer to the overlay_track? Also, I think most of the parameter (include overlay track) should not be modified here. So please use const. > +{ > + struct domain *d = hardware_domain; > + int rc = 0; > + struct dt_device_node *overlay_node; > + unsigned int naddr; > + unsigned int i, j, nirq; > + u64 addr, size; > + domid_t domid = 0; > + > + for ( j = 0; j < num_nodes; j++ ) > + { > + dt_dprintk("Finding node %s in the dt_host\n", full_dt_node_path[j]); > + > + overlay_node = dt_find_node_by_path(full_dt_node_path[j]); > + > + if ( overlay_node == NULL ) This error (and some below) may happen because we partially removed the DTBO but stopped because on error. So on the next run, it is possible that "overlay_node" will be NULL and therefore you will not be able to remove the node. In your use-case, are you planning to ask the admin to reboot if you can't remove a node? > + { > + printk(XENLOG_ERR "Device %s is not present in the tree. Removing nodes failed\n", > + full_dt_node_path[j]); > + return -EINVAL; > + } > + > + domid = dt_device_used_by(overlay_node); > + > + dt_dprintk("Checking if node %s is used by any domain\n", > + full_dt_node_path[j]); > + > + /* Remove the node iff it's assigned to domain 0 or domain io. */ > + if ( domid != 0 && domid != DOMID_IO ) I think I asked before, but I have seen no answer on that. What will prevent the device to not be assigned after this check? Also, in general, I think it would be helpful if you answer on the ML questions. This would at least confirm that you have seen them and we agree on what to do. > + { > + printk(XENLOG_ERR "Device %s as it is being used by domain %d. Removing nodes failed\n", > + full_dt_node_path[j], domid); > + return -EINVAL; > + } > + > + dt_dprintk("Removing node: %s\n", full_dt_node_path[j]); > + > + nirq = node_num_irq[j]; > + > + /* Remove IRQ permission */ > + for ( i = 0; i < nirq; i++ ) > + { > + rc = nodes_irq[j][i]; > + /* > + * TODO: We don't handle shared IRQs for now. So, it is assumed that > + * the IRQs was not shared with another domain. > + */ This is not what I meant in v2. Interrupts cannot be shared between domain on Arm. However, interrupts can be shared between devices. This is the latter part that needs a TODO. In addition to that, as I wrote, an IRQ can be assigned to a *single* domain without the device been assigned to that domain. So I think this needs to be checked possibly by using the information stored in "desc" to know where the IRQ was routed to. > + rc = irq_deny_access(d, rc); > + if ( rc ) > + { > + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", > + i, dt_node_full_name(overlay_node)); > + return rc; > + } > + } > + > + rc = iommu_remove_dt_device(overlay_node); > + if ( rc != 0 && rc != -ENXIO ) > + return rc; > + > + naddr = dt_number_of_address(overlay_node); > + > + /* Remove mmio access. */ > + for ( i = 0; i < naddr; i++ ) > + { > + rc = dt_device_get_address(overlay_node, i, &addr, &size); > + if ( rc ) > + { > + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > + i, dt_node_full_name(overlay_node)); > + return rc; > + } > + > + rc = iomem_deny_access(d, paddr_to_pfn(addr), > + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); I think you missed my comment here. Similar to the IRQs, you are asking for trouble to parse the device-tree again. It would be better to store the information using a rangeset (see include/xen/rangeset.h). I also think the double array for the IRQs should be converted to a rangeset as this would simplify the code. Furthemore, you are removing the permission but not the mapping in the P2M. Can you clarify why? > + if ( rc ) > + { > + printk(XENLOG_ERR "Unable to remove dom%d access to" > + " 0x%"PRIx64" - 0x%"PRIx64"\n", > + d->domain_id, > + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); > + return rc; > + } > + } > + > + rc = dt_overlay_remove_node(overlay_node); > + if ( rc ) > + return rc; > + } > + > + return rc; > +} [...] > + * overlay_node_track describes information about added nodes through dtbo. > + * @entry: List pointer. > + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. > + * @fdt: Stores the fdt. > + * @nodes_fullname: Stores the full name of nodes. > + * @nodes_irq: Stores the IRQ added from overlay dtb. > + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. > + * @num_nodes: Stores total number of nodes in overlay dtb. > + */ > +struct overlay_track { > + struct list_head entry; > + struct dt_device_node *dt_host_new; > + void *fdt; > + char **nodes_fullname; Looking at the code, the main use for the fullname are to check the FDT match and looking up in the DT. In order to check the DT, you could use memcmp() to confirm both the stored FDT and the one provided by the user match. For the lookup, you could avoid it by storing a pointer to the root of the new subtrees. Please let me know if you disagree with this approach. > + int **nodes_irq; > + int *node_num_irq; > + unsigned int num_nodes; > +}; > + > +long dt_sysctl(struct xen_sysctl *op); > +#endif Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 18 18:59:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 18:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332455.556148 (Exim 4.92) (envelope-from ) id 1nrOt4-0007AN-C5; Wed, 18 May 2022 18:59:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332455.556148; Wed, 18 May 2022 18:59:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOt4-0007AG-9D; Wed, 18 May 2022 18:59:10 +0000 Received: by outflank-mailman (input) for mailman id 332455; Wed, 18 May 2022 18:59:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOt2-0007AA-R3 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 18:59:08 +0000 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9777b426-d6dc-11ec-bd2c-47488cf2e6aa; Wed, 18 May 2022 20:59:07 +0200 (CEST) Received: by mail-oi1-f173.google.com with SMTP id l16so3799067oil.6 for ; Wed, 18 May 2022 11:59:07 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bd15-20020a056870d78f00b000e686d1389esm1202223oab.56.2022.05.18.11.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:59:05 -0700 (PDT) Received: (nullmailer pid 3695375 invoked by uid 1000); Wed, 18 May 2022 18:59:04 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9777b426-d6dc-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hl6vHR8m/JLovYO2gNE3ChbiYGqpt17k+OnwcqxZkjo=; b=plLHEWQBviL1JKX1XEORj8Gy4wxV9WNSHLb+VbfZ+lXq5Cr1KSdCLqvThrnGlVgUGF eHDeAG2Um1a7lwOiYjQB9HV8fGn3NVtU11T+HmCSVFmPI7utjJkNjaCeG316/CIp8qyq Rl/BKZQomqF7CQeObda2VLuRYDsx1A9qAdi5jQYvy7j3SE6mjkXo4k9ClM4LO2UzkXk5 OAB2AG+6PMlVq0GpU0NfE/H3ygGK1Bkde7zPeMqO4N9pJIy7592g1geHqvmOLYVqkRqQ pU+l8kW/bPDf4sAbEwdg2v6+folqR47RlzQM/UNOTjxc8nHD9TA4kStEqrxC1pHHChwi WJqA== X-Gm-Message-State: AOAM532ym+iRu62ep70ObL2HEXXSmrTZlmcS0Is/a+GS10ZGGzk2GjtV 8+yTKuoewVnBuJwtoYzU/w== X-Google-Smtp-Source: ABdhPJyZK52/lZYsS9R3kKj1OyynJ0P1NooNpNVdFnOOXczUhwNDyIXF2qHiL1sltyV70oHQTWK1Fg== X-Received: by 2002:a05:6808:aa4:b0:325:91ff:43cc with SMTP id r4-20020a0568080aa400b0032591ff43ccmr623013oij.166.1652900345928; Wed, 18 May 2022 11:59:05 -0700 (PDT) Date: Wed, 18 May 2022 13:59:04 -0500 From: Rob Herring To: Arnd Bergmann Cc: Oleksandr Tyshchenko , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220518185904.GA3685644-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: > > > > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml > > index 10c22b5..29a0932 100644 > > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml > > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml > > @@ -13,6 +13,9 @@ description: > > See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for > > more details. > > > > +allOf: > > + - $ref: /schemas/arm/xen,dev-domid.yaml# > > + > > properties: > > compatible: > > const: virtio,mmio > > @@ -33,6 +36,10 @@ properties: > > description: Required for devices making accesses thru an IOMMU. > > maxItems: 1 > > > > + xen,dev-domid: > > + description: Required when Xen grant mappings need to be enabled for device. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > required: > > - compatible > > - reg > > Sorry for joining the discussion late. Have you considered using the > generic iommu > binding here instead of a custom property? This would mean having a device > node for the grant-table mechanism that can be referred to using the 'iommus' > phandle property, with the domid as an additional argument. > > It does not quite fit the model that Linux currently uses for iommus, > as that has an allocator for dma_addr_t space, but it would think it's > conceptually close enough that it makes sense for the binding. Something common is almost always better. That may also have the issue that fw_devlink will make the 'iommu' driver a dependency to probe. Rob From xen-devel-bounces@lists.xenproject.org Wed May 18 19:03:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 19:03:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332468.556159 (Exim 4.92) (envelope-from ) id 1nrOxP-0000JA-34; Wed, 18 May 2022 19:03:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332468.556159; Wed, 18 May 2022 19:03:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOxO-0000J3-Vu; Wed, 18 May 2022 19:03:38 +0000 Received: by outflank-mailman (input) for mailman id 332468; Wed, 18 May 2022 19:03:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOxN-0000Ix-Tz for xen-devel@lists.xenproject.org; Wed, 18 May 2022 19:03:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrOxM-0003D3-Mq; Wed, 18 May 2022 19:03:36 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[10.95.143.196]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrOxM-0003b1-Bo; Wed, 18 May 2022 19:03:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hhoziTlvIZBhB24NZ1ZT1zfaKgpBh70uYGusgmJVMEs=; b=LCf79+9NsVKtgkn3wgAsN6NO9H B9GyPZi8f+bMyC/t3JmFJoEcM4r8CjhttMk3GT/vhAQQ8bbNNrqol05rB47rFjRCko2s3i30cYwDX r5xc6Q4BWIoPhcm7oxZQ7MWIccDBmlofD/1cHCv1yh8TktWiZ8GOEaQIHDfVzIiwgOQg=; Message-ID: Date: Wed, 18 May 2022 20:03:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 11/14] xen/arm: Implement device tree node addition functionalities To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-12-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-12-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vikram, On 08/03/2022 19:47, Vikram Garhwal wrote: > Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition > using device tree overlay. > > xl overlay add file.dtbo: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flattened) is created and updated with overlay nodes. This > updated fdt is further unflattened to a dt_host_new. Next, it checks if any > of the overlay nodes already exists in the dt_host. If overlay nodes doesn't > exist then find the overlay nodes in dt_host_new, find the overlay node's > parent in dt_host and add the nodes as child under their parent in the > dt_host. The node is attached as the last node under target parent. > > Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the > overlay node. > > When a node is added using overlay, a new entry is allocated in the > overlay_track to keep the track of memory allocation due to addition of overlay > node. This is helpful for freeing the memory allocated when a device tree node > is removed. > > Signed-off-by: Vikram Garhwal > --- > xen/common/dt_overlay.c | 324 ++++++++++++++++++++++++++++++++++++ > xen/include/public/sysctl.h | 1 + > 2 files changed, 325 insertions(+) > > diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c > index fcb31de495..01aed62d74 100644 > --- a/xen/common/dt_overlay.c > +++ b/xen/common/dt_overlay.c > @@ -82,6 +82,64 @@ static int dt_overlay_remove_node(struct dt_device_node *device_node) > return 0; > } > > +static int dt_overlay_add_node(struct dt_device_node *device_node, > + const char *parent_node_path) > +{ > + struct dt_device_node *parent_node; > + struct dt_device_node *np; > + struct dt_device_node *next_node; > + struct dt_device_node *new_node; > + > + parent_node = dt_find_node_by_path(parent_node_path); > + > + new_node = device_node; You only use device_node to set new_node. So the local variable is a bit pointless. I don't mind whether you want to rename the parameter new_node or keep the existing name. > + > + if ( new_node == NULL ) OOI, how could it be NULL? > + return -EINVAL; > + > + if ( parent_node == NULL ) > + { > + dt_dprintk("Node not found. Partial dtb will not be added"); > + return -EINVAL; > + } > + > + /* > + * If node is found. We can attach the device_node as a child of the Below you use new_node rather than device_node > + * parent node. > + */ > + > + /* If parent has no child. */ > + if ( parent_node->child == NULL ) > + { > + next_node = parent_node->allnext; > + new_node->parent = parent_node; > + parent_node->allnext = new_node; > + parent_node->child = new_node; > + /* Now plug next_node at the end of device_node. */ Same. > + new_node->allnext = next_node; > + } else { Coding style: The } and { should be on there own line. I.e: } else { > + /* If parent has at least one child node. */ > + > + /* > + * Iterate to the last child node of parent. > + */ > + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) > + { > + } > + > + next_node = np->allnext; > + new_node->parent = parent_node; > + np->sibling = new_node; > + np->allnext = new_node; > + /* Now plug next_node at the end of device_node. */ Same remark about device node. > + new_node->sibling = next_node; > + new_node->allnext = next_node; > + np->sibling->sibling = NULL; > + } > + > + return 0; > +} > + > /* Basic sanity check for the dtbo tool stack provided to Xen. */ > static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) > { > @@ -377,6 +435,267 @@ out: > return rc; > } > > +/* > + * Adds device tree nodes under target node. > + * We use dt_host_new to unflatten the updated device_tree_flattened. This is > + * done to avoid the removal of device_tree generation, iomem regions mapping to > + * hardware domain done by handle_node(). > + */ > +static long handle_add_overlay_nodes(void *overlay_fdt, > + uint32_t overlay_fdt_size) > +{ > + int rc = 0; > + struct dt_device_node *overlay_node; > + char **nodes_full_path = NULL; > + int **nodes_irq = NULL; > + int *node_num_irq = NULL; > + void *fdt = NULL; > + struct dt_device_node *dt_host_new = NULL; > + struct domain *d = hardware_domain; > + struct overlay_track *tr = NULL; > + unsigned int naddr; > + unsigned int num_irq; > + unsigned int i, j, k; > + unsigned int num_overlay_nodes; > + u64 addr, size; > + > + fdt = xmalloc_bytes(fdt_totalsize(device_tree_flattened)); > + if ( fdt == NULL ) > + return -ENOMEM; > + > + num_overlay_nodes = overlay_node_count(overlay_fdt); > + if ( num_overlay_nodes == 0 ) > + { > + xfree(fdt); > + return -ENOMEM; > + } > + > + spin_lock(&overlay_lock); > + > + memcpy(fdt, device_tree_flattened, fdt_totalsize(device_tree_flattened)); > + > + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); AFAICT, this doesn't need to be checked within the lock. So it would be better to move it before grabbing the lock and the allocation. > + if ( rc ) > + { > + xfree(fdt); > + return rc; > + } > + > + /* > + * overlay_get_nodes_info is called to get the node information from dtbo. > + * This is done before fdt_overlay_apply() because the overlay apply will > + * erase the magic of overlay_fdt. > + */ > + rc = overlay_get_nodes_info(overlay_fdt, &nodes_full_path, > + num_overlay_nodes); > + if ( rc ) > + { > + printk(XENLOG_ERR "Getting nodes information failed with error %d\n", > + rc); > + goto err; > + } > + > + nodes_irq = xmalloc_bytes(num_overlay_nodes * sizeof(int *)); > + > + if ( nodes_irq == NULL ) > + { > + rc = -ENOMEM; > + goto err; > + } > + memset(nodes_irq, 0x0, num_overlay_nodes * sizeof(int *)); > + > + node_num_irq = xmalloc_bytes(num_overlay_nodes * sizeof(int)); > + if ( node_num_irq == NULL ) > + { > + rc = -ENOMEM; > + goto err; > + } > + memset(node_num_irq, 0x0, num_overlay_nodes * sizeof(int)); > + > + rc = fdt_overlay_apply(fdt, overlay_fdt); I am a bit puzzled how this work. Above, you allocated 'fdt' with the size of the current device-tree. So there might not be enough space in the current fdt to apply the overlay. Can you clarify it? > + if ( rc ) > + { > + printk(XENLOG_ERR "Adding overlay node failed with error %d\n", rc); > + goto err; > + } > + > + for ( j = 0; j < num_overlay_nodes; j++ ) > + { > + /* Check if any of the node already exists in dt_host. */ > + overlay_node = dt_find_node_by_path(nodes_full_path[j]); > + if ( overlay_node != NULL ) > + { > + printk(XENLOG_ERR "node %s exists in device tree\n", > + nodes_full_path[j]); > + rc = -EINVAL; > + goto err; > + } > + } > + > + /* Unflatten the fdt into a new dt_host. */ > + unflatten_device_tree(fdt, &dt_host_new); As I mentionned before, unflatten_device_tree() may fail to allocate memory. So it needs to be updated to propogate any error in order to use it in an hypercall. > + > + for ( j = 0; j < num_overlay_nodes; j++ ) > + { > + dt_dprintk("Adding node: %s\n", nodes_full_path[j]); > + > + /* Find the newly added node in dt_host_new by it's full path. */ > + overlay_node = _dt_find_node_by_path(dt_host_new, nodes_full_path[j]); > + if ( overlay_node == NULL ) > + { > + dt_dprintk("%s node not found\n", nodes_full_path[j]); > + rc = -EFAULT; > + goto remove_node; > + } > + > + /* Add the node to dt_host. */ > + rc = dt_overlay_add_node(overlay_node, overlay_node->parent->full_name); > + if ( rc ) > + { > + /* Node not added in dt_host. */ > + goto remove_node; > + } > + > + overlay_node = dt_find_node_by_path(overlay_node->full_name); > + if ( overlay_node == NULL ) > + { > + /* Sanity check. But code will never come here. */ Please add ASSERT_UNREACHABLE just to make clear this is not expected. > + printk(XENLOG_ERR "Cannot find %s node under updated dt_host\n", > + overlay_node->name); > + goto remove_node; > + } > + > + /* First let's handle the interrupts. */ > + rc = handle_device_interrupts(d, overlay_node, false); > + if ( rc ) > + { > + printk(XENLOG_ERR "Interrupt failed\n"); > + goto remove_node; > + } > + > + /* Store IRQs for each node. */ > + num_irq = dt_number_of_irq(overlay_node); > + node_num_irq[j] = num_irq; > + nodes_irq[j] = xmalloc_bytes(num_irq * sizeof(int)); > + if ( nodes_irq[j] == NULL ) > + { > + rc = -ENOMEM; > + goto remove_node; > + } > + > + for ( k = 0; k < num_irq; k++ ) > + { > + nodes_irq[j][k] = platform_get_irq(overlay_node, k); platform_get_irq() can fail. > + } > + > + /* Add device to IOMMUs */ > + rc = iommu_add_dt_device(overlay_node); > + if ( rc < 0 ) > + { > + printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", > + dt_node_full_name(overlay_node)); > + goto remove_node; > + } > + > + /* Set permissions. */ > + naddr = dt_number_of_address(overlay_node); > + > + dt_dprintk("%s passthrough = %d naddr = %u\n", > + dt_node_full_name(overlay_node), false, naddr); > + > + /* Give permission for map MMIOs */ > + for ( i = 0; i < naddr; i++ ) > + { > + struct map_range_data mr_data = { .d = d, > + .p2mt = p2m_mmio_direct_c, > + .skip_mapping = true }; > + rc = dt_device_get_address(overlay_node, i, &addr, &size); > + if ( rc ) > + { > + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > + i, dt_node_full_name(overlay_node)); > + goto remove_node; > + } > + > + rc = map_range_to_domain(overlay_node, addr, size, &mr_data); > + if ( rc ) > + goto remove_node; > + } > + } > + > + /* This will happen if everything above goes right. */ > + tr = xzalloc(struct overlay_track); I think it would be best to allocate the overlay structure first. So 1) you don't have to undo everything because of an allocation failure and 2) you can remove a lot of local variables and use "tr->" directly. > + if ( tr == NULL ) > + { > + rc = -ENOMEM; > + goto remove_node; > + } > + > + tr->dt_host_new = dt_host_new; > + tr->fdt = fdt; > + tr->nodes_fullname = nodes_full_path; > + tr->num_nodes = num_overlay_nodes; > + tr->nodes_irq = nodes_irq; > + tr->node_num_irq = node_num_irq; > + > + if ( tr->nodes_fullname == NULL ) > + { > + rc = -ENOMEM; > + goto remove_node; > + } > + > + INIT_LIST_HEAD(&tr->entry); > + list_add_tail(&tr->entry, &overlay_tracker); > + > + spin_unlock(&overlay_lock); > + return rc; > + > +/* > + * Failure case. We need to remove the nodes, free tracker(if tr exists) and > + * dt_host_new. > + */ > +remove_node: > + rc = remove_nodes(nodes_full_path, nodes_irq, node_num_irq, j); Looking at the implement of remove_nodes(), it would not be able to cope if half of it is initialized. So it an error would be returned (or potentially crash as you set node_num_irq[X] before allocating the memory) and... > + > + if ( rc ) > + { > + printk(XENLOG_ERR "Removing node failed\n"); > + spin_unlock(&overlay_lock); > + return rc; ... no memory would be freed. It is not clear to me whether the memory leak is on purpose. If it is, then I think it should be written down in a comment. > diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h > index e256aeb7c6..bb3ef44989 100644 > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -1069,6 +1069,7 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); > #endif > > +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 I find a bit odd that the documentation is added before the number. I think it might make sense to either define the two sysctl in the previous patch or in a separate one. I don't mind either way. > #define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 > > /* Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 18 19:17:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 19:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332476.556170 (Exim 4.92) (envelope-from ) id 1nrPAv-0001sU-B8; Wed, 18 May 2022 19:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332476.556170; Wed, 18 May 2022 19:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrPAv-0001sN-8E; Wed, 18 May 2022 19:17:37 +0000 Received: by outflank-mailman (input) for mailman id 332476; Wed, 18 May 2022 19:17:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrPAu-0001sC-6G; Wed, 18 May 2022 19:17:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrPAu-0003Rb-3n; Wed, 18 May 2022 19:17:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrPAt-00037Z-Ky; Wed, 18 May 2022 19:17:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrPAt-0007Ir-KW; Wed, 18 May 2022 19:17:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OmwOblniyJnXfBSFpQvQ46oHuADjgmEqRCVPvo6Ds9Y=; b=4dtrhjToMVmFIh8nAxZNUvFcBx Ww6/hWWnm5Zw9p5sXkk37Ecv0DDxVGs2HOYa4fgBor59z7y/3lqB6c9oVOg4kVWmygAlNeNHFa8jd Rmwcmh9z7kFHT1BbMFplMCeM+sjxk8g0qBhomjqpoKaVzxWHTsMAxAkLpU2u2FFfFdDY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170543: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c8040aefe66edb9a9f9a54cc0541a77b4103c9f9 X-Osstest-Versions-That: xen=25c160a74f4489f031ac79a24078cc12efd5c96b From: osstest service owner Date: Wed, 18 May 2022 19:17:35 +0000 flight 170543 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170543/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c8040aefe66edb9a9f9a54cc0541a77b4103c9f9 baseline version: xen 25c160a74f4489f031ac79a24078cc12efd5c96b Last test of basis 170535 2022-05-18 10:01:52 Z 0 days Testing same since 170543 2022-05-18 15:03:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Luca Fancellu Roger Pau Monne Roger Pau Monné Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 25c160a74f..c8040aefe6 c8040aefe66edb9a9f9a54cc0541a77b4103c9f9 -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 18 21:52:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 21:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332486.556181 (Exim 4.92) (envelope-from ) id 1nrRa8-0000ys-Ja; Wed, 18 May 2022 21:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332486.556181; Wed, 18 May 2022 21:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrRa8-0000yl-G0; Wed, 18 May 2022 21:51:48 +0000 Received: by outflank-mailman (input) for mailman id 332486; Wed, 18 May 2022 21:51:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrRa7-0000yb-NU; Wed, 18 May 2022 21:51:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrRa7-00062i-KJ; Wed, 18 May 2022 21:51:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrRa7-0004Me-5D; Wed, 18 May 2022 21:51:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrRa7-0002PG-4l; Wed, 18 May 2022 21:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CG4wFX8M0hQQWx/5d1IGDYVzK9H+M4RBTP+ZZqRFimw=; b=xcmmzcq9RCld9gJbuO1hr7d9Np wnmtgOXm4OJ422ouuVIbNrTU0RDtXdkuJcI0rfAOZPqe6lWdmM7sz1IsF87DtAbrFM7rhIskQqGNc LsqMHb5BusGmvvxS8JYRKni8lEZIZOV9uhe/gMQMovgC/5DhpugKqRPTfytWkv58yHsY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170549: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Wed, 18 May 2022 21:51:47 +0000 flight 170549 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170549/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1088 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 107 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 18 22:50:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 22:50:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332506.556196 (Exim 4.92) (envelope-from ) id 1nrSUe-0007LC-0X; Wed, 18 May 2022 22:50:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332506.556196; Wed, 18 May 2022 22:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrSUd-0007L5-TX; Wed, 18 May 2022 22:50:11 +0000 Received: by outflank-mailman (input) for mailman id 332506; Wed, 18 May 2022 22:50:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrSUc-0007Kz-LZ for xen-devel@lists.xenproject.org; Wed, 18 May 2022 22:50:10 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd0e1db4-d6fc-11ec-837e-e5687231ffcc; Thu, 19 May 2022 00:50:08 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 18:50:05 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5451.namprd03.prod.outlook.com (2603:10b6:806:b0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 22:50:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Wed, 18 May 2022 22:50:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd0e1db4-d6fc-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652914208; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Zg+5Mucm0RhLHOcRpNOWbQI15SNxs3X3X6BztpDjvw8=; b=DCbUZRqKdBxpQSiyETsS3hHR/MU17SGUrlMPH39iix7S35TGOsxppm+n RPL0ZjpH7bluooOxMT+dWxmxTZ1jPPn8gws3RPrrTE4vD6/R8Cu1qx2Ju UETPRtycMSbkrAYbQeshdSTwEAxQlDQsrckQ+Jk+yc8SMoO0FuqU2LYxD E=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 72039074 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:46+Q6a0cvFB4wagj5/bD5fJwkn2cJEfYwER7XKvMYLTBsI5bp2EBz TAYCGmHP6zbYzD0etpyaoTn9E4DvZeByoIwGwE9pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0YDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1osIKMSAsFDpHOmco9cz5XUAtzPa1ZreqvzXiX6aR/zmXgWl61mrBFKxhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfyVuLe03x9p7ixKNd/Ya 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9wjN/vtvvDS7IApZ8+TfGcD8W4ezfOp7nRudu GDrrm3YK0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BCL QoS8yknr6k3/WSqSMXwW1uzp3vslh0RRdtWVfE74Qely6zI7gLfDW8BJhZDYtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoPSlID6ty6+YUr1EuQE5BkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:Wav+760d/ZDqV0exkB8nRQqjBe1xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hfAV7QZnidhILOFvAt0WKC+UytJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQgeVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEA9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyDpAJb4RHoFqjgpF591H22xa1u UkZC1QZvib3kmhOl1dZyGdgzUIngxesEMKgmXo/EcL6faJOA7STfAxxb6xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMAjgRBq3P4iFW5uYd499RjBmcga+S hVfbThzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/ XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyNeFOwC1zzdLkHqbrSn9wPRsvGRv 20JJVaR/f+MGqGI/c84zHD X-IronPort-AV: E=Sophos;i="5.91,235,1647316800"; d="scan'208";a="72039074" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFgI8S5cW9e9OB7BTm3fzFJbLWJhq+Nr/boavF2w+0/skqZu/xI2vBVKYJTWnNbWjOceIbH9OzeagaL4RTL4VnVCA6s3vWx2u3kMi1i5zcK37Om2/6h2p1yDplEMA26iCq4AWk3Fn/YMeFguWyVBQpJ7WwpnWnolvsIHf87WhnPwDsM1PIi+M2MDMvZC+SIberimek6qmIr1HD2r3kTcW80wtyUCxhO7hiG5k+Wh/CxCgVzkHsvwc82ENhjxwMCJzsW1ReSRZN5//aw4S1Iyd+r0klTtMQS18jS8waewqy3zVDqFHsS6vI096MRV4al1zT4Qdvdu2KvkXKJYBn4R0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zg+5Mucm0RhLHOcRpNOWbQI15SNxs3X3X6BztpDjvw8=; b=HiQZJYKpK4xHxEMHomcY9mrHik/I96apXn095GfsMH3xqA0mW29EdpCqK3QKLYdSULPuf22yzkY1t3mj6H89t7GWDwE1DRrZNPKnxcfYEYw4Tt7yGj8jAZqpJfRHoTXseeC8gfdw/y8W3ApQXCoI3+eiemZLa+953NrOc7uxG9bzAYnBjpq0IqJ98nH9GB5fOMPPznuY56rgzhRuUB6sqZthqkdlt7pHsxkNpnhSCRERqMDP5Gq+v2QzU3v9iCTCFrE4JyTpzxftFD5f1LoUcwZFGQKfUJkEjoA2Flm/n6uv1FwqKM0dcO0RfPHXFFj7ecl6fk31Ccc4b8Uofsl4nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zg+5Mucm0RhLHOcRpNOWbQI15SNxs3X3X6BztpDjvw8=; b=M9SGwZmugc4Izi8NTsJzsqSEIzFAs3Eq4fliZ0ECL0ZYtfOdgBAydDE9MNlvlJTDIg6d2VMFpX5hyanfjyt4zMdAL13B54JD42JGhXPVgtD6ZnAWh51WDS7KHZ/b/crplfA4TO4nWAyhBXgpETCBya8iPa2cVyL5QkBrzfsKTE8= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jun Nakajima , Kevin Tian , Jan Beulich , Wei Liu Subject: Re: [PATCH 1/2] x86/vmx: implement Bus Lock detection Thread-Topic: [PATCH 1/2] x86/vmx: implement Bus Lock detection Thread-Index: AQHYafEbc73MBdU1ZE2y9t/J11ujK60lP1UA Date: Wed, 18 May 2022 22:50:02 +0000 Message-ID: <84ee0886-9ed2-97ad-e9f9-c81e8a3885c5@citrix.com> References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-2-roger.pau@citrix.com> In-Reply-To: <20220517132130.38185-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27b7b35f-08df-44a2-ea8d-08da3920beaf x-ms-traffictypediagnostic: SA0PR03MB5451:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ARxY1bkZPJMDOR4jxNiCTCGC9i/YT5p2/iQijVCoby3kEIziurs+/+los5Q8sH0w5bdCDByHm9v/vLClI5aNJJVrZkGmXf0VUf2UbwKUzpbM00BoJgctZu73pLl7Wofr0pG2vHv8bYcfYj1ziB9l14RoBiqciAEL5bGTpXIBMsgoeSYGqfHz79Csh2nhTlTYQz8IPeBWxhNIKfQhwaILS5XcVAPRw7B2pGpjA0vmHUdiZfmVwtIofzwCteA94/mOdvDiSl+BCzZcEfbPUFnRgyufb6rqwnXZPJOW3YOSceTNDCViWEvQYy5zrRi9IYfIDWY9vBkM7grgwcMnSnNHSoeF/WOXx7UVMh3cZ40MDIuUpGw3P2F6jTcBQwoQtYCoNVAZ1PuP2D3Z8lidp6GiQrcSni/w/g8xRZyIPYbCNr+gw887WJhe4MtrqHIrq4kR5OSVJXEvMHtkAnh2JsHMHkNwxAAgsyCU7wSe7Ph54ikLekP2L+dBeKyQ0nKv/FRs4Tw6blrfTwks1zaxlAFZMe7nJP9dirajoOroMplDrftoawxrA8O9ZKzeUk4YoEIUn6PQxgnuON1DsJyEuXa4cIebk9+vLEAIELIlhzqqDlXPE/is9iNZhG0Mbk+iPN/fymOb9f6TC2ojgIFq2Hfs1cenUUiBJ6N3/TmXza6Pnrm0J12P6EuJcsMNgXbsr/vpkhD6FLST8FyTxysM8HOcLaLEM6sDrIE9z0vWokt3sli6oV49q6cWn0Gwr9B74WcyYHcGG6yj/WTQhfEaSzv2rw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(5660300002)(86362001)(54906003)(76116006)(66946007)(31696002)(110136005)(186003)(4326008)(66556008)(508600001)(8676002)(6486002)(6512007)(64756008)(66476007)(66446008)(91956017)(82960400001)(2906002)(38070700005)(31686004)(38100700002)(36756003)(53546011)(55236004)(71200400001)(122000001)(6506007)(2616005)(26005)(8936002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MkFycGNTUUhPbUFpY1llQnhCYm10SFNhUTl3VXN2aVNrQ0EvdkxQUWcrTjl0?= =?utf-8?B?MVlRMjgwTEJwTWxWc1FYb3BrcktiVkFRSWJjYlZnMmRNbUFBT0xmdlRpay9l?= =?utf-8?B?NzNLUjh4M2svUklGRWQ1bnFGM0RVK0REOTVxcjRLclAvaStCajhUYjhPaXdt?= =?utf-8?B?N0pPUnpyQzhBemJhWWJpK3JCNHFibmJqY1I1RHlDaSsweWVSUVVSelpXcXZL?= =?utf-8?B?Mm94KzAvWU9HVDR3QUJxalpPSDFvUktxT3FlZXFIU0lSR09GdXh5TFFFM0Q1?= =?utf-8?B?TGlUVDR1cm1jSUVRRDJKRWowSEpRd2lvWVVNSmZ2Y3lITi90SkMrVGtyUFhW?= =?utf-8?B?bEJSak9lQTh6TG04SWdPSXQ3UnFEOWpaYU8vTlJLZlRLZ2FKVXVncUs3YktU?= =?utf-8?B?dy9PZ0lGcndCTEFqYitEVXlGOTQ2RXNsVWJSSkRpSDZIWExRZm5wMUwxWUFP?= =?utf-8?B?N3BhOGlJOUl0MXRuaVh2dFQ1MkFxdTVpUGFVR1orVXdGSGVwanhDMjlrY2hO?= =?utf-8?B?YVpTcG0ycGMxclhmN213cWNVemhCNEY3V0cwejV6c09UY0xFb0xpSHU4WFBj?= =?utf-8?B?K0U0eld4ZVg3aGNyY09sSzlGMzFjZjN1cTZXRXdNbFJXcDJqR3FCaTBOMHJk?= =?utf-8?B?Uit5YlZrcHpxRlRyVEkrMWtkUmdmTEpxcGhFRUFrRmMzSkxpcWRFVTl0TW82?= =?utf-8?B?TDBicFV6V3lGbCtPQVBsbXZQanA4NnpscFZyTGJmZ0NFOEFUdEZDVjBoSkox?= =?utf-8?B?UnB2a3UwWGp5MmtEdEFQYmFIcnR4a09lZ1RPaVIvY1IzdUpuOWxhS2pRWkJL?= =?utf-8?B?WllZd1M1QXhWaUFKYWVlUmdHVDcwRmNFQ3k5OEttTHU5TGlQWUtsaG9rQ3Fz?= =?utf-8?B?eGxzdWYyWVU3Tkc5RnZxUXpiTlZlT2xxeEFHM0IxWGppSXNlT3phSUFEbnph?= =?utf-8?B?MEorVWdhNmpyUzQ0eXd5cko2Ukt4U1AzYUJBZE5wU205OEVBOFJubStUQzlK?= =?utf-8?B?ZXY2UURKN0RSZWQvZ1V6dDZLdUg4NE1UaUZIUHRoK2ZLUlhIYmJudzlVUktN?= =?utf-8?B?Z3FpV1lmUjhqQUNESXhtVU45dVJSakU5djQySlo5Vi9kSlNJa1gwMkFKOHl0?= =?utf-8?B?K0daQlJZOCtkMGNRcGtWNUxNUGFFMUQvaHJuMUZzT0xuNHN1Wkx1NDd6RnN4?= =?utf-8?B?bVpOaE4vL2F3WnltcFg0MXd5eGRwVEppMmNhVWVjWUdaYTAvRjlzRHN6TUxm?= =?utf-8?B?QSs1NCtWL2Uxd2ZSTXpBR3VPOFRWM3hZOElkZ0dwamlEM2RrU3VHYkhQeVhh?= =?utf-8?B?eWRYZm5VK0g5Y0RXSzhmV2tWb1FDdmJ1WktDYTdmbnF4RGkveldPVmk3aGN0?= =?utf-8?B?UFNEWmNVSWk1NTZ0NWhaVUp2YzV6RUJQR0Q0REE3dVVCdFg5alkyc2ZSeU03?= =?utf-8?B?K1F6ZW15M0hwUjZwWXBnUXY5VHdrZktxU3dhOFQxaHFMK29PTnFhSjlFeEhq?= =?utf-8?B?S3JaNC9TSmtmZEJEQUxKd0FQNHlDanE3VnlycDc0WG5nRnptZnhEaU13UWRW?= =?utf-8?B?NTdBeHk3NEd5ZnNOY3VhVjF2bmdwZkd4dWZ3TGRzNXJHb3BzaHRDUjNHYUFS?= =?utf-8?B?WlkxYnpyQkxWQlorNU00bnZqL2UyQis3ZXo4UTJrTy9POTBZUTJ3NjlXbloz?= =?utf-8?B?cUlvS01mWU1UZ2psMWlZV3dYL2p4alRvSzh2TTdiSFdVZE1aNCtZL3dWTTRn?= =?utf-8?B?TkJQQXNnUVZ4QVpyYVRUc0IyY3NnbzcrdExmRHIxOXkzVWdrZzVqWU5ieG1V?= =?utf-8?B?VG5mVVZ3V04xTll6MmdsSDI0UG5qY28vZ3ppNElUQWlyNE5Jd0s4NW9BTHJj?= =?utf-8?B?ZG5OOXRldE9sRW5USUlRcGRMaklreEo0a1phZHRnWHB1SW5BK1R1U3BWcVVW?= =?utf-8?B?aVdzRk5XOHhxVUhwWmE2U21IMmRoTWgzbHFTd1FmR1dYN2ZtV2tuVXE1TW9l?= =?utf-8?B?a0hUUDNQR3VnbVZnNjArY1Q1MnZkMmU4Q3RBQkQ5U3FpSzMvOTA5blZzb04y?= =?utf-8?B?c0N6Rk9FQUQ0VzNWMm9zaHpKY2NoWVBMM3ZmMm9xYTBpS1BnbWxWQ3UzWith?= =?utf-8?B?Q1BzSE5HOEtjS2t0SGJmMEFQeFRaczRaaURaa1UwRy8zTDdacHRhR3U5b3BF?= =?utf-8?B?d3g1eFowQU5HVEszYkp5QTlITlZJbTEybmlWbTVERlN1VjVxalFJWDY0Qm8x?= =?utf-8?B?L3U1aWt6Risva0Z4WWNrZDU4TzhsOFdMQ3VUbWUwMDMvQjg3VlkxSDU1MlhW?= =?utf-8?B?TjYxMDRPSm1TaEZWQXVtbld2cVpnWUY1bTJCVWVyUHJoRTFJK2UrQT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <8396D47F0B55AE4DAAA100E2ED2FA415@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27b7b35f-08df-44a2-ea8d-08da3920beaf X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 22:50:02.6658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h8PiuZkheEwWBXETPztMGDwPoyq2OorvZ7Ea1c6MHWLtlnz3unBunI2EBop+OoRS+cKnU+7jBa2J9TtdS1XNkMoZrLPtd/XvsmlPNOmaYa8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5451 T24gMTcvMDUvMjAyMiAxNDoyMSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBBZGQgc3VwcG9y dCBmb3IgZW5hYmxpbmcgQnVzIExvY2sgRGV0ZWN0aW9uIG9uIEludGVsIHN5c3RlbXMuICBTdWNo DQo+IGRldGVjdGlvbiB3b3JrcyBieSB0cmlnZ2VyaW5nIGEgdm1leGl0LCB3aGljaCBpcyBlbm91 Z2ggb2YgYSBwYXVzZSB0bw0KPiBwcmV2ZW50IGEgZ3Vlc3QgZnJvbSBhYnVzaW5nIG9mIHRoZSBC dXMgTG9jay4NCg0KIndoaWNoIGlzIGVub3VnaCBvZiBhIiBpcyBhIGJpdCBmaXJtZXIgdGhhbiBp ZGVhbC7CoCAid2hpY2ggQW5keSBzYXlzDQp3aWxsIGJlIG9rIiBpcyBwZXJoYXBzIG1vcmUgYWNj dXJhdGUuDQoNClBlcmhhcHMgIndoaWNoIG91Z2h0IHRvIGJlIGVub3VnaCIgPw0KDQpBIGJ1c2xv Y2sgaGVyZSBvciB0aGVyZSBpcyBubyBwcm9ibGVtLCBhbmQgbm9uLW1hbGljaW91cyBzb2Z0d2Fy ZQ0KYXBwZWFycyB0byBiZSBkZXZvaWQgb2YgYnVzbG9ja3MgKGhhcmRseSBzdXJwcmlzaW5nIC0g aXQgd291bGQgYmUgYSBoYXJkDQplcnJvciBvbiBvdGhlciBhcmNoaXRlY3R1cmVzKSwgYnV0IGEg bWFsaWNpb3VzIHBpZWNlIG9mIHVzZXJzcGFjZSBjYW4NCnRyaXZpYWxseSBjcmlwcGxlIHRoZSBz eXN0ZW0uDQoNCkZvcmNpbmcgYSB2bWV4aXQgb24gZXZlcnkgYnVzbG9jayBsaW1pdHMgYW4gYXR0 YWNrZXIgdG8gb25lIGJ1c2xvY2sgcGVyDQpob3dldmVyIGxvbmcgYSB2bWVudHJ5L2V4aXQgY3lj bGUgdGFrZXMuDQoNCj4gQWRkIGFuIGV4dHJhIHBlcmYgY291bnRlciB0byB0cmFjayB0aGUgbnVt YmVyIG9mIEJ1cyBMb2NrcyBkZXRlY3RlZC4NCg0KZXh0cmEgWGVuIHBlcmYgY291bnRlci4NCg0K QmVjYXVzZSBvdGhlciBoeXBlcnZpc29ycyB1c2UgYWN0dWFsIHBlcmYgY291bnRlcnMgdG8gZW11 bGF0ZSB0aGlzDQphYmlsaXR5IG9uIGN1cnJlbnQgaGFyZHdhcmUuwqAgTWF5YmUgc29tZXRoaW5n IHdlIHNob3VsZCBjb25zaWRlci4uLg0KDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZt L3ZteC92bXguYyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+IGluZGV4IGQwM2U3OGJm MGQuLjAyY2M3YTIwMjMgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5j DQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+IEBAIC00MDUzLDYgKzQwNTMs MTYgQEAgdm9pZCB2bXhfdm1leGl0X2hhbmRsZXIoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Mp DQo+ICANCj4gICAgICBpZiAoIHVubGlrZWx5KGV4aXRfcmVhc29uICYgVk1YX0VYSVRfUkVBU09O U19GQUlMRURfVk1FTlRSWSkgKQ0KPiAgICAgICAgICByZXR1cm4gdm14X2ZhaWxlZF92bWVudHJ5 KGV4aXRfcmVhc29uLCByZWdzKTsNCj4gKyAgICBpZiAoIHVubGlrZWx5KGV4aXRfcmVhc29uICYg Vk1YX0VYSVRfUkVBU09OU19CVVNfTE9DSykgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgLyoNCj4g KyAgICAgICAgICogRGVsaXZlcnkgb2YgQnVzIExvY2sgVk0gZXhpdCB3YXMgcHJlLWVtcHRlZCBi eSBhIGhpZ2hlciBwcmlvcml0eSBWTQ0KPiArICAgICAgICAgKiBleGl0Lg0KPiArICAgICAgICAg Ki8NCj4gKyAgICAgICAgZXhpdF9yZWFzb24gJj0gflZNWF9FWElUX1JFQVNPTlNfQlVTX0xPQ0s7 DQo+ICsgICAgICAgIGlmICggZXhpdF9yZWFzb24gIT0gRVhJVF9SRUFTT05fQlVTX0xPQ0sgKQ0K PiArICAgICAgICAgICAgcGVyZmNfaW5jcihidXNsb2NrKTsNCg0KSSdtIHByZXR0eSBzdXJlIHlv dSBjYW4gZHJvcCB0aGUgaWYsIGFuZCBkbyB0aGUgcGVyZmNfaW5jcigpDQp1bmNvbmRpdGlvbmFs bHkuwqAgWW91IHdvbid0IGdldCBFWElUX1JFQVNPTl9CVVNfTE9DSyB8DQpWTVhfRVhJVF9SRUFT T05TX0JVU19MT0NLIGdpdmVuIHRoYXQgd29yZGluZyBpbiB0aGUgSVNFLg0KDQpUbyB0ZXN0LCBJ bnRlbCBoYXMgUEVORElOR19EQkcgd2hpY2ggaW50ZXJmZXJlcyB3aXRoIG1vc3QgZWFzeSBhdHRl bXB0cw0KdG8gY3JlYXRlIHRoZSBjb25kaXRpb24sIGJ1dCBob3cgYWJvdXQgdGhpcy4NCg0KTG9h ZCBhbiBMRFQsIG1pc2FsaWduZWQgYWNyb3NzIGEgY2FjaGVsaW5lIGJvdW5kYXJ5LCBhbmQgc2V0 ICNEQidzICVjcw0KdG8gTERUWzBdIHdpdGggYSBjbGVhciBhY2Nlc3MgYml0LCB0aGVuIGV4ZWN1 dGUgYW4gYGljZWJwYCBpbnN0cnVjdGlvbi7CoA0KVGhlIGF0b21pYyB3cml0ZSB0byBzZXQgdGhl IGFjY2VzcyBiaXQgaXMgYSA0LWJ5dGUgYWNjZXNzIHR5cGljYWxseS4NCg0KVGhpcyBzaG91bGQg Y2F1c2UgdGhlICNEQiBpbnRlcmNlcHQgdG8gdHJpZ2dlciBvbiB0aGUgc2FtZSBpbnN0YW50YW5l b3VzDQpib3VuZGFyeSB0aGF0IGdlbmVyYXRlZCB0aGUgYnVzbG9jay4NCg0KT3RoZXJ3aXNlLCBM R1RNLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed May 18 23:32:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 23:32:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332516.556206 (Exim 4.92) (envelope-from ) id 1nrT9k-0003CL-Bc; Wed, 18 May 2022 23:32:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332516.556206; Wed, 18 May 2022 23:32:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrT9k-0003CE-8i; Wed, 18 May 2022 23:32:40 +0000 Received: by outflank-mailman (input) for mailman id 332516; Wed, 18 May 2022 23:32:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrT9j-0003C4-54 for xen-devel@lists.xenproject.org; Wed, 18 May 2022 23:32:39 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd68848e-d702-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 01:32:37 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id d15so6219126lfk.5 for ; Wed, 18 May 2022 16:32:37 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id 189-20020a2e09c6000000b00253b5bb829esm358776ljj.98.2022.05.18.16.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 16:32:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd68848e-d702-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+LGXPC/nc5jPsFNWeFnV3sMHcGrlhqWcYZ7LdmbKRk8=; b=YTHEh7mTOmNtdzt4vQbdAc2SgEofQ268qYKBDuNf/dOC6SxLJE063CXRsT7pOhKL1B EGVemTL1TLKqWYa9CSGx5cbFZ4E9T+4Of+1+hsq50kvDC4VGTl+vLzagzw/9FIiMD3mD 68EtqA8PUsGWxuwkNjJN7CN0F5dYVrBn60wH/8QkhglC7NjT1tcsmpDa3P1fOxbvWmqJ GGo/O2fedbOeYWcu0CSzqlUmHH69ulzsmxE4XTaT3WZenUfYjq66nFfHk9uJYHgiBNez 3SGwnSe2PpE/fxhUokfLiy6EqKaSwofgOGt66tG6Ex/mFSOaAX1KZIwwHiS95tMT+i/l kFrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+LGXPC/nc5jPsFNWeFnV3sMHcGrlhqWcYZ7LdmbKRk8=; b=tpJWpXye3SfYbIftup+SfYN+MYFs/f/GzXR/t0OJ2mWWtZmr7d8o2oHxigX3lH2JcN nPjpisRIQKopTZ93SXMRR4xCS9fqBGts7/i8HlXQd2l/XCTN5hR2wc4tPho1QlGi4SrD ZRDp3OsAT+cvglVESy/vFmDyq5mmICXZ4N1PzxiV8VBErXTQeCuZSZl7lL0o78W19WDq nxf9auNS8neYVL2rotx0OzBgZB5aCllOOKpPaQxWmcqf0/VE6MQfX3Cp7qiohNsQkhmd 9ivee9qV3D1YK0LQZszpxlkbF02CLkLo9n0geWYTOhA31tbCUeDP/daccH+HKluawkdZ PG9A== X-Gm-Message-State: AOAM530CiEobBViNFBSvcgWG+UbjZO/KM2FLYNlcsaiFiXw1OiaZjwkX 9FtEQtTHolhN97xuz4ee0bA= X-Google-Smtp-Source: ABdhPJwjk0UvPnxiWmUdMMDJvHCgF0t+PGqTImMMJx2jyaDgM9Se5UhDGarsoLtoC23AOueCaP89SQ== X-Received: by 2002:a19:494b:0:b0:476:5917:b67 with SMTP id l11-20020a19494b000000b0047659170b67mr1293318lfj.452.1652916757237; Wed, 18 May 2022 16:32:37 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Arnd Bergmann Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> From: Oleksandr Message-ID: <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> Date: Thu, 19 May 2022 02:32:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 18.05.22 19:39, Arnd Bergmann wrote: Hello Arnd > On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: >> On 18.05.22 17:32, Arnd Bergmann wrote: >>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: >>> This would mean having a device >>> node for the grant-table mechanism that can be referred to using the 'iommus' >>> phandle property, with the domid as an additional argument. >> I assume, you are speaking about something like the following? >> >> >> xen_dummy_iommu { >> compatible = "xen,dummy-iommu"; >> #iommu-cells = <1>; >> }; >> >> virtio@3000 { >> compatible = "virtio,mmio"; >> reg = <0x3000 0x100>; >> interrupts = <41>; >> >> /* The device is located in Xen domain with ID 1 */ >> iommus = <&xen_dummy_iommu 1>; >> }; > Right, that's that's the idea, thank you for the confirmation > except I would not call it a 'dummy'. > From the perspective of the DT, this behaves just like an IOMMU, > even if the exact mechanism is different from most hardware IOMMU > implementations. well, agree > >>> It does not quite fit the model that Linux currently uses for iommus, >>> as that has an allocator for dma_addr_t space >> yes (# 3/7 adds grant-table based allocator) >> >> >>> , but it would think it's >>> conceptually close enough that it makes sense for the binding. >> Interesting idea. I am wondering, do we need an extra actions for this >> to work in Linux guest (dummy IOMMU driver, etc)? > It depends on how closely the guest implementation can be made to > resemble a normal iommu. If you do allocate dma_addr_t addresses, > it may actually be close enough that you can just turn the grant-table > code into a normal iommu driver and change nothing else. Unfortunately, I failed to find a way how use grant references at the iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I am not too familiar with that, so what is written below might be wrong or at least not precise. The normal IOMMU driver in Linux doesn’t allocate DMA addresses by itself, it just maps (IOVA-PA) what was requested to be mapped by the upper layer. The DMA address allocation is done by the upper layer (DMA-IOMMU which is the glue layer between DMA API and IOMMU API allocates IOVA for PA?). But, all what we need here is just to allocate our specific grant-table based DMA addresses (DMA address = grant reference + offset in the page), so let’s say we need an entity to take a physical address as parameter and return a DMA address (what actually commit #3/7 is doing), and that’s all. So working at the dma_ops layer we get exactly what we need, with the minimal changes to guest infrastructure. In our case the Xen itself acts as an IOMMU. Assuming that we want to reuse the IOMMU infrastructure somehow for our needs. I think, in that case we will likely need to introduce a new specific IOVA allocator (alongside with a generic one) to be hooked up by the DMA-IOMMU layer if we run on top of Xen. But, even having the specific IOVA allocator to return what we indeed need (DMA address = grant reference + offset in the page) we will still need the specific minimal required IOMMU driver to be present in the system anyway in order to track the mappings(?) and do nothing with them, returning a success (this specific IOMMU driver should have all mandatory callbacks implemented). I completely agree, it would be really nice to reuse generic IOMMU bindings rather than introducing Xen specific property if what we are trying to implement in current patch series fits in the usage of "iommus" in Linux more-less. But, if we will have to add more complexity/more components to the code for the sake of reusing device tree binding, this raises a question whether that’s worthwhile. Or I really missed something? > > Arnd -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 18 23:48:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 18 May 2022 23:48:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332524.556217 (Exim 4.92) (envelope-from ) id 1nrTPA-0004kC-LC; Wed, 18 May 2022 23:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332524.556217; Wed, 18 May 2022 23:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrTPA-0004k5-IL; Wed, 18 May 2022 23:48:36 +0000 Received: by outflank-mailman (input) for mailman id 332524; Wed, 18 May 2022 23:48:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrTP8-0004jz-Pf for xen-devel@lists.xenproject.org; Wed, 18 May 2022 23:48:34 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06fa85a7-d705-11ec-837e-e5687231ffcc; Thu, 19 May 2022 01:48:33 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id f4so6210862lfu.12 for ; Wed, 18 May 2022 16:48:33 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id q7-20020ac25107000000b0047255d211e3sm83430lfb.274.2022.05.18.16.48.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 16:48:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06fa85a7-d705-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1UX9tyiY5Mk4r18rRaJBtwzhf1ZkmkQKY6AoHo3gkeU=; b=EOyUOmigcDiFSJvJvzr7SPnBBZOwM/2TtEwTD7jMMFA5XBQ/9fKlvqJpOV7W2t8GbK B8/80L59bPmxdfqwuyULyEbfFosEabN28Arqc/CGnHTIyHRWiujQceUHclJvVfjgVYQE lokfslEw8Tlser1eUC0JYMR5PPVVJ66H2uLntTHLTSKGDfRzDozIrZEVxY0wHtbsuiSL w835ogeyqZnJtEHC22eLFPj298OPdDLzS0I2dBzRyEHdWjzjYo5AQPhBrPsryyU3qyDc FgR/E/y5U41uYg8J4mT74V4NTW17TC7cHmZbDghtyW0LTdgdlc5AuS0pbYMOpYZikfZO Yo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1UX9tyiY5Mk4r18rRaJBtwzhf1ZkmkQKY6AoHo3gkeU=; b=ankB1i9FJipM1vx1MBdjEZL9DoZGJdg6kGC3Iw5NL3qgw2QAYZDfoFZxfvdDqZiM10 9qhC7boGDa8S6XX7P93UR8EFS4ONDJmwoUNQ4qdhw3UN/M8QJ+Cl4YnQ1oy/qYdWd0Qv fuPRs6T16vOGyD2nOG1ebiO0pT6Oztm4nk1s0kMKsgE1ihunqOR/ZeTAJzVroEFmI0rd lMASzjTe5rT0WZgiS9ll5gx3VD3dhU5Qa48+nVdYy+axqgVkhcOZG1PIDUgMHBCNDn2F WjB4pBZf/QcqPrxqY/2jSctuOKwnuEAcO19Jcu1zX3t7Kp1SRmswu8b+3XCQmT732o5V 9DUg== X-Gm-Message-State: AOAM532KiGNZx3PrV+mZIO3A+FAaeH800Pa266hygREdNRkls6SxShYX R1F0vpnH/KSZuifCnGNXAl0= X-Google-Smtp-Source: ABdhPJzSuJPZWc7BEOcp2vhD63R+kj8rGQqC2ji1faQfxLn5GP6aKbG88ceT3bgy+m/z5SjBgVVpFA== X-Received: by 2002:a05:6512:169a:b0:44a:fea7:50a5 with SMTP id bu26-20020a056512169a00b0044afea750a5mr1314227lfb.498.1652917712865; Wed, 18 May 2022 16:48:32 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Rob Herring , Arnd Bergmann Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <20220518185904.GA3685644-robh@kernel.org> From: Oleksandr Message-ID: <40758f3b-cab3-2096-1711-18837bc2f73b@gmail.com> Date: Thu, 19 May 2022 02:48:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220518185904.GA3685644-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 18.05.22 21:59, Rob Herring wrote: Hello Rob, Arnd > On Wed, May 18, 2022 at 03:32:27PM +0100, Arnd Bergmann wrote: >> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko wrote: >>> diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml >>> index 10c22b5..29a0932 100644 >>> --- a/Documentation/devicetree/bindings/virtio/mmio.yaml >>> +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml >>> @@ -13,6 +13,9 @@ description: >>> See https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio for >>> more details. >>> >>> +allOf: >>> + - $ref: /schemas/arm/xen,dev-domid.yaml# >>> + >>> properties: >>> compatible: >>> const: virtio,mmio >>> @@ -33,6 +36,10 @@ properties: >>> description: Required for devices making accesses thru an IOMMU. >>> maxItems: 1 >>> >>> + xen,dev-domid: >>> + description: Required when Xen grant mappings need to be enabled for device. >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + >>> required: >>> - compatible >>> - reg >> Sorry for joining the discussion late. Have you considered using the >> generic iommu >> binding here instead of a custom property? This would mean having a device >> node for the grant-table mechanism that can be referred to using the 'iommus' >> phandle property, with the domid as an additional argument. >> >> It does not quite fit the model that Linux currently uses for iommus, >> as that has an allocator for dma_addr_t space, but it would think it's >> conceptually close enough that it makes sense for the binding. > Something common is almost always better. agree > > That may also have the issue that fw_devlink will make the 'iommu' > driver a dependency to probe. Looks like I ran into it while experimenting. I generated the following nodes in guest DT using Xen toolstack: [snip]         xen_dummy_iommu {                 compatible = "xen,dummy-iommu";                 #iommu-cells = <0x01>;                 phandle = <0xfde9>;         };         virtio@2000000 {                 compatible = "virtio,mmio";                 reg = <0x00 0x2000000 0x00 0x200>;                 interrupts = <0x00 0x01 0xf01>;                 interrupt-parent = <0xfde8>;                 dma-coherent;                 iommus = <0xfde9 0x01>;         }; [snip] And got: virtio-mmio 2000000.virtio: deferred probe timeout, ignoring dependency > > Rob -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 19 00:10:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 00:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332532.556229 (Exim 4.92) (envelope-from ) id 1nrTka-0008TC-LT; Thu, 19 May 2022 00:10:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332532.556229; Thu, 19 May 2022 00:10:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrTka-0008T5-IG; Thu, 19 May 2022 00:10:44 +0000 Received: by outflank-mailman (input) for mailman id 332532; Thu, 19 May 2022 00:10:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrTkY-0008Sz-7q for xen-devel@lists.xenproject.org; Thu, 19 May 2022 00:10:42 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ae3ec6f-d708-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 02:10:39 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 May 2022 20:10:34 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM5PR03MB2796.namprd03.prod.outlook.com (2603:10b6:3:40::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 00:10:30 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Thu, 19 May 2022 00:10:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ae3ec6f-d708-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652919039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6dpfS5q1/RhgUhIsCh+xD8cLhfSbXpcFzJM/39TRqC4=; b=NWT2ZDFXN9zbAsiYb/ez4nhY3K+IPEmECPkqy+gPcG6FamdwCwXj/rwm ZwZ9cWEytr0MSYrdPkBwzFRLBOPsZ++F6NZEPXyHiF1KQEDjWOoN7lTjJ J/xmL6Ff5TqU7EWdkubfZ+XfFGOcMYcG9r/WTBTmUscg/4g4UE3A71klu w=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 71655055 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lf0PVarlXS6SqPVVXHWtr3OGiJxeBmLRZBIvgKrLsJaIsI4StFCzt garIBmHafiKM2ukfNgja46w8B4CusTVzNY2HVM6ri43E34RpJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 IOq+KUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBEqKWxsgnXRhjLTguALF21rLeC1OEmJnGp6HGWyOEL/RGKmgTZNRd0cEuRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgnFp2Z4m8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeKklEsiOWwWDbTUvizau5ExlzBn WTb7WC6GSMDEsey6xPQpxpAgceKx0sXQrk6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0WcdUEuA8wBGAzOzT+QnxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHmKKRYWKQ8PGTtzzaESoIKykEbCwNTwoA6vHipp0+ilTESdMLOK24kNzzXy3xy jairS4iirFVhskOv5hX5njCijOo45POFwg841yOWnr/t1wnIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF4n9hx0xZPpbxt3Qw= IronPort-HdrOrdr: A9a23:UDSCeKG5W4658tnEpLqFt5LXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNFICPoqTM2ftW7dySWVxeBZnMffKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj4Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWna4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlWFtyssHfsWG1SYczEgNkHmpDo1L/sqq iUn/4UBbU215oWRBDsnfKi4Xi67N9k0Q6e9bbRuwqenSW+fkN7NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxEC3/rFuGoO5gLZvtX+9Kq1wVB4SKbpXZd VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFoifA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94aLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg2bwqaWGLEPQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP v2MI5KApbYXB/TJbo= X-IronPort-AV: E=Sophos;i="5.91,236,1647316800"; d="scan'208";a="71655055" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DmqGAhbih2k0LBi/jM/cYGLD6l308QTrgEBHD71ellPhGc3ymc855CdVRaqRauN84Rhp0I4vhyDSdf0elCnqmgM6pj+bTJuSDvpkXPrbvlaSQ3UOvN2cYBa7FR1Q7ZhDjcF4tjFnv6IwA5MQ0ujSmXsmRniUYd4YBC5UaIXAAbh8dqWRG7qr7DotscLr4vNwU/govvshXTUVnTKYayBwUfSX12/mktFwA3stYF9/PA67c0sxVK9FpBw0v8NChG3RRq2Tfj5aL6NIY2DvbvXNh8MVIzEuFx9t/QEjnmPpkt+8YFlxQj7pClPWwUU1fdNXPRk5Ir7brKBF/Got4LCYvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6dpfS5q1/RhgUhIsCh+xD8cLhfSbXpcFzJM/39TRqC4=; b=CbqjzE3zd2FmW+VCGEUyiOhNLjQ7/ruyCjxENYVJ/jw5W7vUDXvciCPFcWroRFqB35/4Ep/RdJ3+NG+sqvXUy3tRc8tzkLC3Qr3B1coMZw/SdxDhENEobzDSaA2gFrA2GSDGjrqkGmYuIJ53yEa3JvkwrciV5URo99QLITGGA6IYx6bjmC/2V9s5WlIEW9p/Lrx1xI/2PHwDb70eDkEEh8hVNWAlMydIQEHMDQXG6j+8HL/7kxPbZMpeQYGV8dOMCoXOrdhBHvP6jLGBLXmgmF/DiBX512pL4W2u4OyWwZCxAZH/VPkcJv9A1F9lo5zH+OFFcaQ62OdnbTaWZe6kGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6dpfS5q1/RhgUhIsCh+xD8cLhfSbXpcFzJM/39TRqC4=; b=YiqGxF//E523TxkxrIYx7fP6Nis397UtDP2nhllSagBA2isTobb/Q0FKZdDSN3kE8ytLSQ9gj0W2ac6HQfONqG2IBV8xi2iEwYeo7MJ30Fctmm2M4BCSi9Dh3olDLm/ojBL+o3WrPJL2OoaZqJI7fAKuLAz4HXBwD67ZnY+pFxY= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Thread-Topic: [PATCH 2/2] x86/vmx: implement Notify VM Exit Thread-Index: AQHYafEfUx0WfCMplEq6U+wPIyhlOa0lVccA Date: Thu, 19 May 2022 00:10:24 +0000 Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> In-Reply-To: <20220517132130.38185-3-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8cf1f6ae-a01c-4ca0-436a-08da392bf8c1 x-ms-traffictypediagnostic: DM5PR03MB2796:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iydtRcBdTGTo6Rvh8p9q8RExZqHMadZcO+IVSy8MUvs114yEiUuJ0GvgUA9/1QbN7BUNNwelNGBIRK7c9JSQwbK7pll6idcHRef3UmSfvmHynxVjls5BUb2s5vrjOuCOYDDnTlMD3ilDAs7LY3TbZvK228ilxwHYm/9jj5jJwgL+oiTHzHVydMQyHvmKFSFoFPe4OrqIaTmsKHKdlwwhYQUUYR+BMiloq1IW9C1BfEP/R1T4V8kjr92mOMQCYS286Y6Ma0iEpedJdvhM/Jy+HVsrBW6Aso7PYwawUW9mL6rX4xnAfMZGSoHVMsGXiFYbae+MZCYN8uX5DDhIdogFYekgHJZRqzY91/G3XGJ6xp9IFDxexWJFJbe1geGR5gws4FObPfdFCX9aa1HRH3ufaOouswYhE+m0a1CjjJ/RsMfLsD7nTXdkNI5ZfEEydX9bey+ZFWxxb93c4Y2uQH76RDLV8dSSZvvKshs+k/Gv4mNIrkyuqKnZ+N9EhbQ60qTZkawOn6H+XMBUoyyrENT/EtoGR5bG6Svj+FLFlcWaURoFxNWhAZRbQ7b80LD73HTR9y4JfdWtyo8uc7Ox+40zp21B5cndY1YveW+JQEV6NQVFIMW7ZsovgVYj5xPkMg0XkxlCNSuw18XC05x5kd7EkeZ5fPj3V3qrP5JYuFKXZBma93D2liJp2u7uAKobODbspTOPN56+niE0NeoeY9b+cNZmAv6YIAft7eI5Y/cBRbE7zFse6ey42R+cKekMlMWVZv9OvD3V6K5Decj0Q2OOAA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(6486002)(122000001)(110136005)(508600001)(86362001)(36756003)(31686004)(186003)(91956017)(2906002)(54906003)(31696002)(82960400001)(71200400001)(66946007)(53546011)(66556008)(8676002)(55236004)(4326008)(66446008)(76116006)(64756008)(2616005)(6512007)(66476007)(38100700002)(8936002)(5660300002)(38070700005)(6506007)(26005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cUhTbm9OQTdMUWVON3Z4TmlTaDFkWDRodlRnd25admwwOVErMWMyUCtQdmNu?= =?utf-8?B?T0t6MFYrYk5YbmI0empENlVBNDg1eE9say91MTRKY1M1QUk0SXBtV3dvUkpQ?= =?utf-8?B?Kzg1bGxvZ1pGeEkxTHBLT2FuTHJDZEcxcTlUUW85cXdBSTlFajZ1SDY3a01I?= =?utf-8?B?TkMyRW1iOTdPYm1pbVk0dFlQMmJwVXkyRE9xUWZKVmcwRkxWcDB0cTZaV0lM?= =?utf-8?B?UVlLdFhka3QxQUd6QU91RDBnSGhUSnhHQ3oyNVdTeXZuM2ZWSTRldGJPNENQ?= =?utf-8?B?SE5QTUowamloUWlmN1l3NGtmb3JnOXdzNzNHRGhjTUNqTytFWXB3YS95YU9M?= =?utf-8?B?WVpialVMSUJPYXlrR1hHRVg4UHM1Wm00MTNLWVR6ajkvTWtpVUwvWnY4WDJJ?= =?utf-8?B?QXpKM2RjTmkrcXFHR2xmUkorYW14Tyt5ZDRWYkVlaTgwNWc0clRVOU45NU4w?= =?utf-8?B?cUxnVnpjUC83Q1RKaUFncFlaSW04aERQbFMwZGZHMTExZ1NWRnZQSHNLRU9J?= =?utf-8?B?QkczMVBRRFZQRGlWTG1jeTYwOGRTbWFzU3hjanhkTUJ4SXpXeEpQWHNHZGJB?= =?utf-8?B?UGN5MGplNzg4M24vMDFweUdLY0xFYm9CTXFBYkVDRU56SlQ0TnU3dXBZNFB4?= =?utf-8?B?RDNqTVBWdGdsZXFGaXlpUEVlbjE3Qml3Nk5yWjZTMVVXSllkdFlubTMyR2VH?= =?utf-8?B?NGNaYVljc1ovYk9xM3I1UTZaZGpNSmh3bzNZY0VYdTZ4TVMwL2RmN0VVTUF0?= =?utf-8?B?RWp2ZjFxby9XSis0YktKbE43dzVCUEhPL2s1TTdTTmZ0UGZjMGlEMy9MTjds?= =?utf-8?B?dnBqaTdoUnJ4c0ExMnkxYVJYZHhTclYrSjFSQ1NPbDkycGl3ZW1vTnlET2dM?= =?utf-8?B?b1paY3JVZUNjelhXZHpqa2RBRFZ2N2VaY2ljQUdxT0ZjTFFqUldQREg3S1pC?= =?utf-8?B?Zm5FOUxRelYrY1RqVGkvR01XUHpvQjBiaEVPWTRyaTlIejVNa3NsOEY3em04?= =?utf-8?B?cFRWOVRwRXhYbmkzbUR4c1h6WWwrb1d4dHYxYzZ1b1NwSkRwVFFiZk5GU0JX?= =?utf-8?B?RnJlclJVemVpSWFxZlZTUVBvbGFVWUhCcGJucWJXZkZGcEhVZTJyMTl2aXEx?= =?utf-8?B?S0dzSFo0R1I3WGlydVJydUNzZkVJNDd1TDErNlVIQnRUbmhWQTZoWk1TTUhs?= =?utf-8?B?Y0pHRjB0dC9pdTlya2VxVjdwT3MzUmVUd1Z1R2thVGVlUTkwUmptb1lQZFZX?= =?utf-8?B?WjhWMlFpaXl1Q3htYURNU29aaVNieXltYkdiSzNBR2xJNHl4Nnhtc2lNMC9V?= =?utf-8?B?VG1SN25mVDB3WnRqNWl1UkhQV0ZiVWViWlFnblV3SVQrNXNkdHdmaVBCU2JH?= =?utf-8?B?bUVaRXp4SkMrNW9OQTdXSmNBT0xIVHdmWFVZbzhyWEJDWkVFSFlHVkRxL1cr?= =?utf-8?B?RURRbWtJMGlzbUxWNGNWK2drczcrMlN3MDJnYnErSCt2aWZCQTRyTEZpN2JQ?= =?utf-8?B?cit0UXhLZXBibHhuZEUzcUFPL3hRaUtQOW1nR3YwT0ZvUmZPOE5Tajl1anFr?= =?utf-8?B?V2xyYk9kSkpvOUVxNU1xYUhld2VEQzdQZHI2UmlVaXZvOUFCM2laSStUa28x?= =?utf-8?B?dmxVdDllZ2tuMjhmVnlha0praEhtaEY4amNpVTJqQXgxczFWQkJWdWE3N3BJ?= =?utf-8?B?NitwMWsrMWU5R1lSbTc2TGNVdmFmZDF0eDYxcnIySisxVWtGcUVJcVdpdWFH?= =?utf-8?B?VTV0Yk42NFN3TDRqeVBUR1NwYjd1SlpHSVFISlhJNFhPcFlFeDFpek9TUFVZ?= =?utf-8?B?cklYK1RJZUJNVTBMdXloVGEyMGxmNXh3T2R6ZDNmWmR1cktJZWw2UHBackFV?= =?utf-8?B?Mk9JdVkwOThKdTYzQkJ6azJFU09VbmFlSVpjZk5sYTdrOXR2QS9KL25mSDBI?= =?utf-8?B?alFHWDN1N2d1Qjh5cUtLeTdrelY2YlZqQXhNYXl4SkVQUGMyZVFLVEs0M0hZ?= =?utf-8?B?b3kveStMLzFQS3RJS1RzMlkrSFZPeFRmelFaRHhIZUUzcDBUNkpkYVdXK3g4?= =?utf-8?B?K3A3NUdSQ1o5cnUxSis4R3l0Slh2a1RYZTlTV3hQcTdsZkFUc3dycmZRY0ZK?= =?utf-8?B?MWEzemxJUkJBanM3bjZPdm9CQ2EwOC9wcWZqak4vQW5paXd2UWptME5leHV0?= =?utf-8?B?a3BvTWtuTStkeWx0cWNDYWVZT3FHb0dVNkVHR2NqdGU0MTg5QWVPK1JyTStr?= =?utf-8?B?eE1xMTZwM2x5ckhpVGJndjVXd0E2MW9heEVzL0RSYmVoQTBXQU1wQ3JYMDJL?= =?utf-8?B?RUJyWGNLMFdaOWhkcnphaW1ob29DT1paS3MzUWpVNFRpNld2aXJmdz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf1f6ae-a01c-4ca0-436a-08da392bf8c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 00:10:24.5513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q8xnfvAlw1CdbHB4FidAtoGz3IH/6Tcan9nSKBE4AEpWERMKl99gM7RHP92lOs23LGRF08FEdMAUjGlqdm58g5baruWtNnPR5aAep5PEAxY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2796 T24gMTcvMDUvMjAyMiAxNDoyMSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBVbmRlciBjZXJ0 YWluIGNvbmRpdGlvbnMgZ3Vlc3RzIGNhbiBnZXQgdGhlIENQVSBzdHVjayBpbiBhbiBpbmZpbml0 ZQ0KPiBsb29wIHdpdGhvdXQgdGhlIHBvc3NpYmlsaXR5IG9mIGFuIGludGVycnVwdCB3aW5kb3cg dG8gb2NjdXIuDQoNCmluc3RydWN0aW9uIGJvdW5kYXJ5Lg0KDQpJdCdzIHRyaXZpYWwgdG8gY3Jl YXRlIGFuIGluZmluaXRlIGxvb3Agd2l0aG91dCBhbiBpbnRlcnJ1cHQgd2luZG93IDopDQoNCkFs c28sIEknZCBwcm9iYWJseSBwaHJhc2UgdGhhdCBhcyBhbiB1bmJvdW5kZWQgbG9vcCwgYmVjYXVz ZSBub3QgYWxsDQpwcm9ibGVtIGNhc2VzIGFyZSB0cnVseSBpbmZpbml0ZS4NCg0KPiAgIFRoaXMN Cj4gd2FzIHRoZSBjYXNlIHdpdGggdGhlIHNjZW5hcmlvcyBkZXNjcmliZWQgaW4gWFNBLTE1Ni4N Cg0KQ2FzZSBpbiBwb2ludCwgYm90aCBvZiB0aGVzZSBjYW4gYmUgYnJva2VuIGJ5IHNvbWV0aGlu ZyBlbHNlIChhbm90aGVyDQp2Q1BVLCBvciBjb2hlcmVudCBETUEgd3JpdGUpIGVkaXRpbmcgdGhl IElEVCBhbmQgZS5nLiBtYWtpbmcgdGhlICNBQy8jREINCnZlY3RvcnMgbm90IHByZXNlbnQsIHdo aWNoIHdpbGwgeWllbGQgI05QIGluc3RlYWQuDQoNCj4NCj4gTWFrZSB1c2Ugb2YgdGhlIE5vdGlm eSBWTSBFeGl0IG1lY2hhbmlzbSwgdGhhdCB3aWxsIHRyaWdnZXIgYSBWTSBFeGl0DQo+IGlmIG5v IGludGVycnVwdCB3aW5kb3cgb2NjdXJzIGZvciBhIHNwZWNpZmllZCBhbW91bnQgb2YgdGltZS4g IE5vdGUNCj4gdGhhdCB1c2luZyB0aGUgTm90aWZ5IFZNIEV4aXQgYXZvaWRzIGhhdmluZyB0byB0 cmFwICNBQyBhbmQgI0RCDQo+IGV4Y2VwdGlvbnMsIGFzIFhlbiBpcyBndWFyYW50ZWVkIHRvIGdl dCBhIFZNIEV4aXQgZXZlbiBpZiB0aGUgZ3Vlc3QNCj4gcHV0cyB0aGUgQ1BVIGluIGEgbG9vcCB3 aXRob3V0IGFuIGludGVycnVwdCB3aW5kb3csIGFzIHN1Y2ggZGlzYWJsZQ0KPiB0aGUgaW50ZXJj ZXB0cyBpZiB0aGUgZmVhdHVyZSBpcyBhdmFpbGFibGUgYW5kIGVuYWJsZWQuDQo+DQo+IFNldHRp bmcgdGhlIG5vdGlmeSBWTSBleGl0IHdpbmRvdyB0byAwIGlzIHNhZmUgYmVjYXVzZSB0aGVyZSdz IGENCj4gdGhyZXNob2xkIGFkZGVkIGJ5IHRoZSBoYXJkd2FyZSBpbiBvcmRlciB0byBoYXZlIGEg c2FuZSB3aW5kb3cgdmFsdWUuDQo+DQo+IFN1Z2dlc3RlZC1ieTogQW5kcmV3IENvb3BlciA8YW5k cmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7D qSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBUaGlzIGNoYW5nZSBlbmFibGVzIHRo ZSBub3RpZnkgVk0gZXhpdCBieSBkZWZhdWx0LCBLVk0gaG93ZXZlciBkb2Vzbid0DQo+IHNlZW0g dG8gZW5hYmxlIGl0IGJ5IGRlZmF1bHQsIGFuZCB0aGVyZSdzIHRoZSBmb2xsb3dpbmcgbm90ZSBp biB0aGUNCj4gY29tbWl0IG1lc3NhZ2U6DQo+DQo+ICItIFRoZXJlJ3MgYSBwb3NzaWJpbGl0eSwg aG93ZXZlciBzbWFsbCwgdGhhdCBhIG5vdGlmeSBWTSBleGl0IGhhcHBlbnMNCj4gICAgd2l0aCBW TV9DT05URVhUX0lOVkFMSUQgc2V0IGluIGV4aXQgcXVhbGlmaWNhdGlvbi4gSW4gdGhpcyBjYXNl LCB0aGUNCj4gICAgdmNwdSBjYW4gbm8gbG9uZ2VyIHJ1bi4gVG8gYXZvaWQga2lsbGluZyBhIHdl bGwtYmVoYXZlZCBndWVzdCwgc2V0DQo+ICAgIG5vdGlmeSB3aW5kb3cgYXMgLTEgdG8gZGlzYWJs ZSB0aGlzIGZlYXR1cmUgYnkgZGVmYXVsdC4iDQo+DQo+IEl0J3Mgbm90IG9idmlvdXNseSBjbGVh ciB0byBtZSB3aGV0aGVyIHRoZSBjb21tZW50IHdhcyBtZWFudCB0byBiZToNCj4gIlRoZXJlJ3Mg YSBwb3NzaWJpbGl0eSwgaG93ZXZlciBzbWFsbCwgdGhhdCBhIG5vdGlmeSBWTSBleGl0IF93cm9u Z2x5Xw0KPiBoYXBwZW5zIHdpdGggVk1fQ09OVEVYVF9JTlZBTElEIi4NCg0KVEJILCBJIHJlYWQg dGhhdCBhcyBhIGdldC1vdXQgY2xhdXNlIGZvciAid2UgaGF2ZSBubyBpZGVhIHdoYXQgdG8gc2V0 DQpmb3IgYSBkZWZhdWx0IHdpbmRvdyIsIGFuZCBpdCdzIG5vdCBhIGRlY2lzaW9uIHJlYXNvbmFi bGUgdG8gZGVmZXIgdG8NCnVzZXJzLCBiZWNhdXNlIHRoZXkgaGF2ZSBldmVuIGxlc3Mgb2YgYW4g aWRlYSB0aGFuIHVzLg0KDQpBbGwgQ1BVcyB3aXRoIE5vdGlmeSBWTSBFeGl0IGhhdmUgdGhlIFRT QyBjcnlzdGFsIGluZm9ybWF0aW9uIGluIENQVUlELA0Kc28gSSdkIHN1Z2dlc3QgdGhhdCB3ZSB0 cnVzdCBDUFVJRCB0byBiZSBhY2N1cmF0ZSwgYW5kIHByb2dyYW0gZm9yIG1heWJlDQoxMHVzP8Kg IFRoYXQncyAxLzMgb2YgYSBkZWZhdWx0IHRpbWVzbGljZS4NCg0KDQoNCj4gSXQncyBhbHNvIG5v dCBjbGVhciB3aGV0aGVyIHN1Y2ggd3JvbmcgaGFyZHdhcmUgYmVoYXZpb3Igb25seSBhZmZlY3Rz DQo+IGEgc3BlY2lmaWMgc2V0IG9mIGhhcmR3YXJlLCBpbiBhIHdheSB0aGF0IHdlIGNvdWxkIGF2 b2lkIGVuYWJsaW5nDQo+IG5vdGlmeSBWTSBleGl0IHRoZXJlLg0KPg0KPiBUaGVyZSdzIGEgZGlz Y3Vzc2lvbiBpbiBvbmUgb2YgdGhlIExpbnV4IHBhdGNoZXMgdGhhdCAxMjhLIG1pZ2h0IGJlDQo+ IHRoZSBzYWZlciB2YWx1ZSBpbiBvcmRlciB0byBwcmV2ZW50IGZhbHNlIHBvc2l0aXZlcywgYnV0 IEkgaGF2ZSBubw0KPiBmb3JtYWwgY29uZmlybWF0aW9uIGFib3V0IHRoaXMuICBNYXliZSBvdXIg SW50ZWwgbWFpbnRhaW5lcnMgY2FuDQo+IHByb3ZpZGUgc29tZSBtb3JlIGZlZWRiYWNrIG9uIGEg c3VpdGFibGUgbm90aWZ5IFZNIGV4aXQgd2luZG93DQo+IHZhbHVlLg0KPg0KPiBJJ3ZlIHRlc3Rl ZCB3aXRoIDAgKHRoZSBwcm9wb3NlZCBkZWZhdWx0IGluIHRoZSBwYXRjaCkgYW5kIEkgZG9uJ3QN Cj4gc2VlbSB0byBiZSBhYmxlIHRvIHRyaWdnZXIgbm90aWZ5IFZNIGV4aXRzIHVuZGVyIG5vcm1h bCBndWVzdA0KPiBvcGVyYXRpb24uICBOb3RlIHRoYXQgZXZlbiBpbiB0aGF0IGNhc2UgdGhlIGd1 ZXN0IHdvbid0IGJlIGRlc3Ryb3llZA0KPiB1bmxlc3MgdGhlIGNvbnRleHQgaXMgY29ycnVwdC4N Cg0KSHVoLi4uIFRoZXJlJ3Mgbm90aGluZyBpbiB0aGUgbWFudWFsIGFib3V0IHRoYXQsIGJ1dCBv YnZpb3VzbHkgaGFyZHdhcmUNCmhhcyBzb21lIG1pbmltdW0gc2FmZSB2YWx1ZSBpZiAwIGFwcGVh cnMgdG8gd29yayBpbiBwcmFjdGljZS4NCg0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2 bS92bXgvdm1jcy5jIGIveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5jDQo+IGluZGV4IGQzODhl NjcyOWMuLjU2ODVhNTUyM2UgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3Zt Y3MuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMNCj4gQEAgLTY3LDYgKzY3 LDkgQEAgaW50ZWdlcl9wYXJhbSgicGxlX2dhcCIsIHBsZV9nYXApOw0KPiAgc3RhdGljIHVuc2ln bmVkIGludCBfX3JlYWRfbW9zdGx5IHBsZV93aW5kb3cgPSA0MDk2Ow0KPiAgaW50ZWdlcl9wYXJh bSgicGxlX3dpbmRvdyIsIHBsZV93aW5kb3cpOw0KPiAgDQo+ICtzdGF0aWMgaW50IF9fcmVhZF9t b3N0bHkgdm1fbm90aWZ5X3dpbmRvdzsNCj4gK2ludGVnZXJfcGFyYW0oInZtLW5vdGlmeS13aW5k b3ciLCB2bV9ub3RpZnlfd2luZG93KTsNCg0KUGFydCBvZiBtZSBpcyBsb2F0aCB0byBrZWVwIG9u IGFkZGluZyBuZXcgdG9wLWxldmVsIG9wdGlvbnMgZm9yIHRoaXMuDQoNCkkgd2FzIGFib3V0IHRv IHN1Z2dlc3QgaGF2aW5nIGEgdm14PSBvcHRpb24sIGJ1dCBJJ3ZlIGp1c3Qgbm90aWNlZCB0aGF0 DQpwbGVfe3dpbmRvdyxnYXB9IGFyZSB3aXJlZCB1cCB0byBjbWRsaW5lIG9wdGlvbnMgb24gSW50 ZWwsIGFuZCBmaXhlZA0KY29uc3RhbnRzIG9uIEFNRC4NCg0KVGhvdWdodHMgb24gYSBzdWl0YWJs ZSBuYW1lPw0KDQo+IEBAIC0xMzMzLDYgKzEzMzgsMTkgQEAgc3RhdGljIGludCBjb25zdHJ1Y3Rf dm1jcyhzdHJ1Y3QgdmNwdSAqdikNCj4gICAgICAgICAgcmMgPSB2bXhfYWRkX21zcih2LCBNU1Jf RkxVU0hfQ01ELCBGTFVTSF9DTURfTDFELA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIFZN WF9NU1JfR1VFU1RfTE9BRE9OTFkpOw0KPiAgDQo+ICsgICAgaWYgKCBjcHVfaGFzX3ZteF9ub3Rp Znlfdm1fZXhpdGluZyAmJiB2bV9ub3RpZnlfd2luZG93ID49IDAgKQ0KPiArICAgIHsNCj4gKyAg ICAgICAgX192bXdyaXRlKE5PVElGWV9XSU5ET1csIHZtX25vdGlmeV93aW5kb3cpOw0KPiArICAg ICAgICAvKg0KPiArICAgICAgICAgKiBEaXNhYmxlICNBQyBhbmQgI0RCIGludGVyY2VwdGlvbjog YnkgdXNpbmcgVk0gTm90aWZ5IFhlbiBpcw0KPiArICAgICAgICAgKiBndWFyYW50ZWVkIHRvIGdl dCBhIFZNIGV4aXQgZXZlbiBpZiB0aGUgZ3Vlc3QgbWFuYWdlcyB0byBsb2NrIHRoZQ0KPiArICAg ICAgICAgKiBDUFUuDQo+ICsgICAgICAgICAqLw0KPiArICAgICAgICB2LT5hcmNoLmh2bS52bXgu ZXhjZXB0aW9uX2JpdG1hcCAmPSB+KCgxVSA8PCBUUkFQX2RlYnVnKSB8DQo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKDFVIDw8IFRSQVBfYWxpZ25tZW50 X2NoZWNrKSk7DQo+ICsgICAgICAgIHZteF91cGRhdGVfZXhjZXB0aW9uX2JpdG1hcCh2KTsNCg0K SUlSQywgaXQncyBub3QgcXVpdGUgdGhpcyBlYXN5LsKgIFRoZXJlIGFyZSBjb25kaXRpb25zLCBl LmcuIGF0dGFjaGluZw0KZ2Ric3gsIHdoZXJlICNEQiBpbnRlcmNlcHRpb24gd2FudHMgdHVybmlu ZyBvbi9vZmYgZHluYW1pY2FsbHksIGFuZCB0aGUNCmxvZ2ljIGdvdCBzaW1wbGlmaWVkIHRvIG5v dGhpbmcgZm9sbG93aW5nIFhTQS0xNTYsIHNvIHdpbGwgbmVlZA0KcmVpbnRyb2R1Y2luZy4NCg0K QU1EIE1pbGFuIChaZW4zKSBhY3R1YWxseSBoYXMgTm9OZXN0ZWREYXRhQnAgaW4gQ1BVSUQuODAw MDAwMjEuZWF4WzBdDQp3aGljaCBhbGxvd3MgdXMgdG8gbm90IGludGVyY2VwdCAjREIsIHNvIHBl cmhhcHMgdGhhdCBtaWdodCBvZmZlciBhbg0KZWFzaWVyIHdheSBvZiBhZGp1c3RpbmcgdGhlIGlu dGVyY2VwdGlvbiBsb2dpYy7CoCAoT3IgbWF5YmUgbm90LsKgIEkgY2FuJ3QNCnJlbWVtYmVyKS4N Cg0KPiArICAgIH0NCj4gKw0KPiAgIG91dDoNCj4gICAgICB2bXhfdm1jc19leGl0KHYpOw0KPiAg DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyBiL3hlbi9hcmNoL3g4 Ni9odm0vdm14L3ZteC5jDQo+IGluZGV4IDAyY2M3YTIwMjMuLjljMzc3OTBjMzYgMTAwNjQ0DQo+ IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9o dm0vdm14L3ZteC5jDQo+IEBAIC00NTY3LDYgKzQ1NjcsMzAgQEAgdm9pZCB2bXhfdm1leGl0X2hh bmRsZXIoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpDQo+ICAgICAgICAgICAqLw0KPiAgICAg ICAgICBicmVhazsNCj4gIA0KPiArICAgIGNhc2UgRVhJVF9SRUFTT05fTk9USUZZOg0KPiArICAg ICAgICBfX3ZtcmVhZChFWElUX1FVQUxJRklDQVRJT04sICZleGl0X3F1YWxpZmljYXRpb24pOw0K PiArDQo+ICsgICAgICAgIGlmICggZXhpdF9xdWFsaWZpY2F0aW9uICYgTk9USUZZX1ZNX0NPTlRF WFRfSU5WQUxJRCApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHBlcmZjX2luY3Iodm1u b3RpZnlfY3Jhc2gpOw0KPiArICAgICAgICAgICAgZ3ByaW50ayhYRU5MT0dfRVJSLCAiaW52YWxp ZCBWTSBjb250ZXh0IGFmdGVyIG5vdGlmeSB2bWV4aXRcbiIpOw0KPiArICAgICAgICAgICAgZG9t YWluX2NyYXNoKHYtPmRvbWFpbik7DQo+ICsgICAgICAgICAgICBicmVhazsNCj4gKyAgICAgICAg fQ0KPiArDQo+ICsgICAgICAgIGlmICggY3B1X2hhc192bXhfdm5taSAmJg0KPiArICAgICAgICAg ICAgIChleGl0X3F1YWxpZmljYXRpb24gJiBJTlRSX0lORk9fTk1JX1VOQkxPQ0tFRF9CWV9JUkVU KSApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZ3Vlc3RfaW5m bzsNCj4gKw0KPiArICAgICAgICAgICAgLyogRXhpdCB3YXMgaW5jaWRlbnQgdG8gYW4gZXhlY3V0 aW9uIG9mIElSRVQgdGhhdCB1bmJsb2NrZWQgTk1Jcy4gKi8NCj4gKyAgICAgICAgICAgIF9fdm1y ZWFkKEdVRVNUX0lOVEVSUlVQVElCSUxJVFlfSU5GTywgJmd1ZXN0X2luZm8pOw0KPiArICAgICAg ICAgICAgX192bXdyaXRlKEdVRVNUX0lOVEVSUlVQVElCSUxJVFlfSU5GTywNCj4gKyAgICAgICAg ICAgICAgICAgICAgICBndWVzdF9pbmZvIHwgVk1YX0lOVFJfU0hBRE9XX05NSSk7DQoNCkkgYW0g c2FkZGVuZWQgYnkgaG93IGlycml0YXRpbmcgaXQgaXMgaGF2aW5nIHRoZSBVTkJMT0NLRURfQllf SVJFVCAoaW4NCnRoZSBmaXJzdCBwbGFjZS4uLikgYnV0IG1vdmluZyBiZXR3ZWVuIHRoZSBleGl0 IHF1YWxpZmljYXRpb24gYW5kIHRoZQ0Kdm1leGl0IGludHIgaW5mbyBmaWVsZHMuwqAgVGhlIGNv bnN0YW50IHByb2JhYmx5IG91Z2h0IHRvIGJlIHJlbmFtZWQgdG8NCmxvc2UgdGhlIElOVFJfSU5G TyBwcmVmaXguDQoNCkknZCBzdWdnZXN0IGEgcHJlcmVxIHBhdGNoIHRvIGFsc28gYnJlYWsNCg0K c3RhdGljIHZvaWQgdW5kb19ubWlzX3VuYmxvY2tlZF9ieV9pcmV0KHZvaWQpDQp7DQrCoMKgwqAg Li4uDQp9DQoNCm91dCB0byBhdm9pZCBvcGVuY29kaW5nIGl0IGluIHNldmVyYWwgcGxhY2VzLsKg IFRoZXJlJ3Mgb25lIG90aGVyDQppbnN0YW5jZSBpbiBvdXIgY29kZSAoZ2VuZXJhbCBmYXVsdCBp bnRlcmNlcHQpLCBidXQgd2UncmUgYnVnZ3kgb24NClBNTC1mdWxsLCBBUElDLWFjY2VzcyBhbmQg RVBUIHZpb2xhdGlvbiBhbGwgb2Ygd2hpY2ggWGVuIGhhbmRsZXMuDQoNCkkgZG9uJ3QgdGhpbmsg eW91IG5lZWQgdGhlIHZubWkgY2hlY2ssIGJlY2F1c2UgdGhlIGJpdCBpcyAwIG90aGVyd2lzZS4N Cg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu May 19 01:06:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 01:06:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332545.556252 (Exim 4.92) (envelope-from ) id 1nrUcQ-0003YH-A3; Thu, 19 May 2022 01:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332545.556252; Thu, 19 May 2022 01:06:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUcQ-0003YA-5j; Thu, 19 May 2022 01:06:22 +0000 Received: by outflank-mailman (input) for mailman id 332545; Thu, 19 May 2022 01:06:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUcP-0003Y4-5s for xen-devel@lists.xenproject.org; Thu, 19 May 2022 01:06:21 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e42f0092-d70f-11ec-837e-e5687231ffcc; Thu, 19 May 2022 03:06:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CE889B82282; Thu, 19 May 2022 01:06:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92E4CC385A9; Thu, 19 May 2022 01:06:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e42f0092-d70f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652922377; bh=A37qzO27clIicOaYiKS+7XcGNtBlcRdGs+YWygQldiE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Q1ISrQZMlC7dfffXYF2LojSw8XRR0txL3DlfV3ijVpuPFCDh/xpWfJ6Q9YNmLQ8cB bOt31zuut1LXYk2EWEiMTcHWteKBs6YYiWit2LsoIf1ChT8OWizPh11zvSCt3h37rc o/Zs0vZAQkDgCAEoOZ9RU4XzqV7CBeMeQ6OS1tE2Oi/v4jdEyFVa8wks8VP3oomCZx b3JPlpEn7bEAT2UTulT4f/+xXkBIvh/Q+V0XBeZyUUqfLjcVLHaJtry+VANv/zARhy 63U8oicDVdlxmPS2FMniCnbbVrlisTOVkpnnupLhVku1I/gS1D9ONwetqJkxsjSPI7 O+hR72zkswG9A== Date: Wed, 18 May 2022 18:06:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr cc: Arnd Bergmann , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops In-Reply-To: <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-845912708-1652922160=:1905099" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-845912708-1652922160=:1905099 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 19 May 2022, Oleksandr wrote: > > On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > > > > wrote: > > > > This would mean having a device > > > > node for the grant-table mechanism that can be referred to using the > > > > 'iommus' > > > > phandle property, with the domid as an additional argument. > > > I assume, you are speaking about something like the following? > > > > > > > > > xen_dummy_iommu { > > > compatible = "xen,dummy-iommu"; > > > #iommu-cells = <1>; > > > }; > > > > > > virtio@3000 { > > > compatible = "virtio,mmio"; > > > reg = <0x3000 0x100>; > > > interrupts = <41>; > > > > > > /* The device is located in Xen domain with ID 1 */ > > > iommus = <&xen_dummy_iommu 1>; > > > }; > > Right, that's that's the idea, > > thank you for the confirmation > > > > > except I would not call it a 'dummy'. > > From the perspective of the DT, this behaves just like an IOMMU, > > even if the exact mechanism is different from most hardware IOMMU > > implementations. > > well, agree > > > > > > > > It does not quite fit the model that Linux currently uses for iommus, > > > > as that has an allocator for dma_addr_t space > > > yes (# 3/7 adds grant-table based allocator) > > > > > > > > > > , but it would think it's > > > > conceptually close enough that it makes sense for the binding. > > > Interesting idea. I am wondering, do we need an extra actions for this > > > to work in Linux guest (dummy IOMMU driver, etc)? > > It depends on how closely the guest implementation can be made to > > resemble a normal iommu. If you do allocate dma_addr_t addresses, > > it may actually be close enough that you can just turn the grant-table > > code into a normal iommu driver and change nothing else. > > Unfortunately, I failed to find a way how use grant references at the > iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I am > not too familiar with that, so what is written below might be wrong or at > least not precise. > > The normal IOMMU driver in Linux doesn’t allocate DMA addresses by itself, it > just maps (IOVA-PA) what was requested to be mapped by the upper layer. The > DMA address allocation is done by the upper layer (DMA-IOMMU which is the glue > layer between DMA API and IOMMU API allocates IOVA for PA?). But, all what we > need here is just to allocate our specific grant-table based DMA addresses > (DMA address = grant reference + offset in the page), so let’s say we need an > entity to take a physical address as parameter and return a DMA address (what > actually commit #3/7 is doing), and that’s all. So working at the dma_ops > layer we get exactly what we need, with the minimal changes to guest > infrastructure. In our case the Xen itself acts as an IOMMU. > > Assuming that we want to reuse the IOMMU infrastructure somehow for our needs. > I think, in that case we will likely need to introduce a new specific IOVA > allocator (alongside with a generic one) to be hooked up by the DMA-IOMMU > layer if we run on top of Xen. But, even having the specific IOVA allocator to > return what we indeed need (DMA address = grant reference + offset in the > page) we will still need the specific minimal required IOMMU driver to be > present in the system anyway in order to track the mappings(?) and do nothing > with them, returning a success (this specific IOMMU driver should have all > mandatory callbacks implemented). > > I completely agree, it would be really nice to reuse generic IOMMU bindings > rather than introducing Xen specific property if what we are trying to > implement in current patch series fits in the usage of "iommus" in Linux > more-less. But, if we will have to add more complexity/more components to the > code for the sake of reusing device tree binding, this raises a question > whether that’s worthwhile. > > Or I really missed something? I think Arnd was primarily suggesting to reuse the IOMMU Device Tree bindings, not necessarily the IOMMU drivers framework in Linux (although that would be an added bonus.) I know from previous discussions with you that making the grant table fit in the existing IOMMU drivers model is difficult, but just reusing the Device Tree bindings seems feasible? --8323329-845912708-1652922160=:1905099-- From xen-devel-bounces@lists.xenproject.org Thu May 19 01:22:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 01:22:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332553.556263 (Exim 4.92) (envelope-from ) id 1nrUrg-0005pr-K3; Thu, 19 May 2022 01:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332553.556263; Thu, 19 May 2022 01:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUrg-0005pk-H5; Thu, 19 May 2022 01:22:08 +0000 Received: by outflank-mailman (input) for mailman id 332553; Thu, 19 May 2022 01:22:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUrf-0005pa-7h; Thu, 19 May 2022 01:22:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUrf-00080c-5t; Thu, 19 May 2022 01:22:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrUre-0001Ib-QK; Thu, 19 May 2022 01:22:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrUre-0003He-Pq; Thu, 19 May 2022 01:22:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pqk9b3YkEkHuKPmZ/HMs7TsnQmvO+FRzTowI/o//R+M=; b=tuDMiupmmMwCKXjUySUXFtQKij QMdmxazX1N3d+4QWO5o5EJ0fnMLZ+oZdWjZ4CXQ/+inJDWRUp0EYqDmL/7/taGWdpeST3RAKpGuvi x6jesmv5Pszg1C9pqezF7KMZITsekLkhaeAUjpElNj248njgSCdEqlIWNp2G7atp73XI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170552: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 01:22:06 +0000 flight 170552 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170552/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 78 days 1089 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 108 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 02:05:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 02:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332563.556273 (Exim 4.92) (envelope-from ) id 1nrVXY-0001vm-Uk; Thu, 19 May 2022 02:05:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332563.556273; Thu, 19 May 2022 02:05:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrVXY-0001vf-Rx; Thu, 19 May 2022 02:05:24 +0000 Received: by outflank-mailman (input) for mailman id 332563; Thu, 19 May 2022 02:05:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrVXW-0001vU-NH; Thu, 19 May 2022 02:05:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrVXW-0000ig-Kz; Thu, 19 May 2022 02:05:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrVXW-0002Vs-9Z; Thu, 19 May 2022 02:05:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrVXW-0001UH-94; Thu, 19 May 2022 02:05:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9wGLiiFQXrOyakL0xfdEZwNQR2jrZEY4y/Xaizz1zaA=; b=v3JAf8muX2UPhjvkUaGVFCMQKD FMiPVsllxjSWmJHFt5F1BELcMRDzEo+5fJ5luTW4pmbGbn8Zec88DoKXfmIb91NIQFyqfFe3HleCL U9x0sNmW3EA1MccRlO/7q2hMyfvbzanItK2U687Gruo2BdojG6qqZTzDmA3T5wH+19Rc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170554: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 02:05:22 +0000 flight 170554 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170554/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1090 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 109 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 02:36:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 02:36:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332573.556285 (Exim 4.92) (envelope-from ) id 1nrW1t-0005AM-FE; Thu, 19 May 2022 02:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332573.556285; Thu, 19 May 2022 02:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrW1t-0005AF-Av; Thu, 19 May 2022 02:36:45 +0000 Received: by outflank-mailman (input) for mailman id 332573; Thu, 19 May 2022 02:36:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrW1r-0005A9-Ub for xen-devel@lists.xenproject.org; Thu, 19 May 2022 02:36:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0d::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8385a3f6-d71c-11ec-837e-e5687231ffcc; Thu, 19 May 2022 04:36:41 +0200 (CEST) Received: from DB6PR07CA0172.eurprd07.prod.outlook.com (2603:10a6:6:43::26) by AM0PR08MB3331.eurprd08.prod.outlook.com (2603:10a6:208:5b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 02:36:38 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::4e) by DB6PR07CA0172.outlook.office365.com (2603:10a6:6:43::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.5 via Frontend Transport; Thu, 19 May 2022 02:36:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 02:36:37 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Thu, 19 May 2022 02:36:37 +0000 Received: from 19da94ecff14.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 180682EA-4BDB-4DBC-AA22-1699C5127364.1; Thu, 19 May 2022 02:36:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19da94ecff14.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 May 2022 02:36:31 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB6796.eurprd08.prod.outlook.com (2603:10a6:10:2ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 02:36:29 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.015; Thu, 19 May 2022 02:36:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8385a3f6-d71c-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BSjShLCE2H9pzDM45wgO1u/OYxOgu2UtgM/ralqbxNRxfH5vq60ddYbVMjbBywDu7BDodafSaxDooRbUPSy1cJ/XrInm1PRA0enaZVbOnjCT21k1rU0lEfQ20iXPHkFuyPsd0ID24d7h2k8XxzDFnHNasF0WptBWyr/0/ceUbVz2GYq2PuCiQk+qXEmibN/QimMuxVvJnazjK/CuXQgU/180bTN9Fda0t5VXN60vPFSdBloKuYrxlLcGq5siaivjrmG+zPA2AaVMeBpc12kWO5BZ78mKm+M3r9E92ieRu6vnZLLiKUgmBzz1jMCNjqjIQNkHS7EA0IS03+nYfEKFDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zcYcWYo67SS8oRwVfMgyQwbAiML4RxhxUOaj5K+ZuKY=; b=aB9oPy/Q4kzvi6Bz+t2j3gPFexhtCCFARmxsIn2pkrA+Z16mMYhORFpk5cot+qo4cxIi1VfltjCiYQCDAg8ZptDm7ltEYiq2d3AFg5M920b+1elsGGV5viHpV0P4SMMhESmlBX/Niq1FkpXHpIeQ+k72z4w1sm61OqfuoO+ssRlYSysiWcgUseJkOnBp4nNPp6ezrKQr+kIf5PkZZYJkJKi5N+7CNW/Z84G45ebIcdog1CHifdqSRXFRxfXJSNrdFTY47mLTquFU8TUs7BHWgm3JBqmhzlnamtMilJ/F3weKGJkGdqVFf8QZAbGqpHez5Uj6pd/+W/4Na5FI6e5XTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcYcWYo67SS8oRwVfMgyQwbAiML4RxhxUOaj5K+ZuKY=; b=G3fVSojYGqzbOeAldkNoXxXGOaxgg4TErTe6IrbdOzwtfQJZeLTMiBPdXVcSv18eYUVLn5y3wWqOIlF9PG1ntsFqXlP/5pV4fviGEZspXu8wZASxDRr+JrPcFZxCaLs7WbUw0rIVJ79nUJRdgIlogs+E25py7RYKrdNCs0D3LS4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3pZcdlimEbhyjiE5ajAkp80XyYzpvlG6eg0xM+5Xs6KPrAz94DiN0SN/SyvmXrRNBXBqSSyofTMPSh/W2iKYtVEiHX2jHR2c7keFAzryrGgma2YQIr3GT2ZXj4UBZPqrDpWWkh3KZ+NkgGHSdY0ua2E+LNZVse2CvBjY1UCfVMllAcCSEShpbsH1JAVjIUJqEOARBtjc27CrRAxWCw2NTYKPq120y+UCDILYCTVibNa43BYPhXKHtu4mMra6G2bX+9ENg8+rbg61ZT3fksC8JZsrimr3/cd3+oZbNDDaxtws4k1VAFFuRIEReOB4irr6cZIcPGvAyQBmdICaQhDIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zcYcWYo67SS8oRwVfMgyQwbAiML4RxhxUOaj5K+ZuKY=; b=d74/dlnupvcDpK0mFmBnKd9MYaxsS02M4pLc74x+5mELA/mq5+ZjvThY9GwZJD0n1/MPGgTafJ95RrFo54PFSeGFqXvqcxkmPY19deg/lgv55Xior8k1LYf4YaQCL7fUeG8E/XQXrpIfwC6TINfPjQZ1fW+NWDOyPPJ1b1h68GTNwGaM0wiYyhlrMYbKTfNznp4lS43nEvIlKDANg1+/UEaoLPN46/lXCUjH2C9Zbeb7R8jkdp+/IZUmfvwkOfnViyI5UMpKnW26MLsYPfPdlL8Yhz+1cbF3wCZuHI9f49zgll018Mn4R9cpSSAwlDH4Q4djfAFjBt0n9TzkFevxMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zcYcWYo67SS8oRwVfMgyQwbAiML4RxhxUOaj5K+ZuKY=; b=G3fVSojYGqzbOeAldkNoXxXGOaxgg4TErTe6IrbdOzwtfQJZeLTMiBPdXVcSv18eYUVLn5y3wWqOIlF9PG1ntsFqXlP/5pV4fviGEZspXu8wZASxDRr+JrPcFZxCaLs7WbUw0rIVJ79nUJRdgIlogs+E25py7RYKrdNCs0D3LS4= From: Wei Chen To: Jan Beulich , Stefano Stabellini , Julien Grall , Bertrand Marquis CC: nd , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Thread-Topic: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Thread-Index: AQHYZNkE0M8gmGVKY0iTs20r+BonU60kpgQAgADcFxA= Date: Thu, 19 May 2022 02:36:28 +0000 Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> In-Reply-To: <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> Accept-Language: en-US Content-Language: en-US X-Mentions: julien@xen.org,Bertrand.Marquis@arm.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E868C6518C01E148817EC27BD443BF9E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4e9a3795-f1c3-4c00-da62-08da3940660e x-ms-traffictypediagnostic: DB9PR08MB6796:EE_|DBAEUR03FT041:EE_|AM0PR08MB3331:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vLfCDhFEnhQeDrH0sqDO/a1w9Oi1UAOJ7BnfxzveLw+Qo+I41NdoIbhddsxw2QMBl/tF1YLSdZuu77hEBbAhI6Q7oReY8/oE5UuoWVQOSzSmvWhlo5EHn2C5dcCyHQJmtEfpahxwmo/pv2NrKMxHLw0xHGek20NMDstYeVOo29NbP7+yi90JqSflzVp5Kg92dEibEFDQ+ctEw3dBFYH8ezwIDwVMBocARShqHwLABkgQ1aCXhkci1/QFzpgDq/sKc8zcjeh/DvFDJJZRSsqFEpt0QgsLD52TobCKoclF5fbHI/ciWy52BU4QpbqX9KMoAOGG1fQmn/N5PknEIBLz799QRmoeQ+MFthiLrs41frGyzOp4n+BGBlsUIXmA3M4ny/hmvAe6sXj5/1qqMKs1GU2GHuRPtfk3RCe9/R0lgE7VJfciQF2pkOQAXxzJ6+o08E/EMhFBaxlnRggyMMhIb9mvaOGXppKZFaZn0gu2SqIWJplN4lma48VgYM1+U0JvyVxLgrNho7e+nrQPPQQ10LLw+Zq3BPkpTWDRz8nDNBmuLd6ZIomX4ErisfUNJ5V8jfCgLqxQca9lt5+VJC2wefAKiiz0N7vtKgfToh02CRs9R8l0aKMl4Hrvx1NdjciLpYo1hYE1993gWcIK5m/ZWf0Zux6hPlRNv3RfN3z4t2iYdvGIQ3NW0LKHrRTP4vQuZ8ZgxlK5m7qdfI0rrmX55Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(38070700005)(4326008)(8676002)(38100700002)(66446008)(66946007)(122000001)(66556008)(76116006)(66476007)(316002)(33656002)(71200400001)(55016003)(508600001)(83380400001)(54906003)(110136005)(6636002)(86362001)(2906002)(8936002)(52536014)(5660300002)(9686003)(26005)(6506007)(53546011)(186003)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6796 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2208f7c1-77af-4ff1-4e35-08da394060c1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qwEcmIlH5r+vJjY5x5xHD/GPMOYyh8tLZEQJNSq6Ewp6bi/QHioyVo6n2JQam7vj+vnMPKf3UTeggWQnOy9KrkydGh2LRpyTQoORxBbixkxDbj3AekNqm/ftUX2uOiW+l9WgXSGuLVMLQ0UBS8M68IW/p0S4r+3m1UueSwtBvIZVM/gcFZsHt7qaiQqjfIY2X/hs9pgSNUcUH044pAQsMAKXaiuni26gPEsutLIlFYNMuvpRlRp0roR7+1oBaWBhsIGAw8mD32rIkLv5UkS/0Rnaa03HjExTVQG64yxgVOz7Avkkf7mv19pGy6Q8y22BrjnpAP/+I2J9OrAeWIpe1e9gkP2BEYEbY/N1Ivv9Pt00VlpZpMNPU/yqH7LHcfqgi03hB9COcqHry5cepXzOV6R+vhkWl7CDp7t2L03ah/BYP72tJFZ3ASKnzWRdRBy79n88K1p8sLnZfUyvrOaoS8BgrRsuqqOm8cL7B697z5oGFe23LbZ1hqIhyD7a0f5PYCSXxa+ycD5hMHWEoyTgT/3MR4wmOUMTcWzI/bZX9RqLJrTTFcuszunLvSKjW69W3gYNDUQfyhKXaQPdrmqqvWlThIMRt2aLU/ENK+89iNGLu0u/YjCG+ZJCp0Cfp06A3qVsTClBVDRoihkxA9BhZzDrH/ij/KVkPAR8e3bJr//qGY989VDBxnzAiXxMi5j1 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(336012)(47076005)(186003)(86362001)(36860700001)(83380400001)(356005)(8676002)(4326008)(81166007)(8936002)(54906003)(110136005)(82310400005)(70586007)(6636002)(70206006)(2906002)(55016003)(53546011)(508600001)(316002)(5660300002)(33656002)(26005)(9686003)(40460700003)(6506007)(7696005)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 02:36:37.9129 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e9a3795-f1c3-4c00-da62-08da3940660e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3331 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDXmnIgxOOaXpSAyMTowNQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbg0KPiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlz QGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5j b20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIg UGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3Jn PjsgSmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDIvOV0geGVuOiByZXVzZSB4 ODYgRUZJIHN0dWIgZnVuY3Rpb25zIGZvciBBcm0NCj4gDQo+IE9uIDExLjA1LjIwMjIgMDM6NDYs IFdlaSBDaGVuIHdyb3RlOg0KPiA+IHg4NiBpcyB1c2luZyBjb21waWxlciBmZWF0dXJlIHRlc3Rp bmcgdG8gZGVjaWRlIEVGSSBidWlsZA0KPiA+IGVuYWJsZSBvciBub3QuIFdoZW4gRUZJIGJ1aWxk IGlzIGRpc2FibGVkLCB4ODYgd2lsbCB1c2UgYW4NCj4gPiBlZmkvc3R1Yi5jIGZpbGUgdG8gcmVw bGFjZSBlZmkvcnVudGltZS5jIGZvciBidWlsZCBvYmplY3RzLg0KPiA+IEZvbGxvd2luZyB0aGlz IGlkZWEsIHdlIGludHJvZHVjZSBhIHN0dWIgZmlsZSBmb3IgQXJtLCBidXQNCj4gPiB1c2UgQ09O RklHX0FSTV9FRkkgdG8gZGVjaWRlIEVGSSBidWlsZCBlbmFibGUgb3Igbm90Lg0KPiA+DQo+ID4g QW5kIHRoZSBtb3N0IGZ1bmN0aW9ucyBpbiB4ODYgRUZJIHN0dWIuYyBjYW4gYmUgcmV1c2VkIGZv cg0KPiA+IG90aGVyIGFyY2hpdGVjdHVyZXMsIGxpa2UgQXJtLiBTbyB3ZSBtb3ZlIHRoZW0gdG8g Y29tbW9uDQo+ID4gYW5kIGtlZXAgdGhlIHg4NiBzcGVjaWZpYyBmdW5jdGlvbiBpbiB4ODYvZWZp L3N0dWIuYy4NCj4gPg0KPiA+IFRvIGF2b2lkIHRoZSBzeW1ib2wgbGluayBjb25mbGljdCBlcnJv ciB3aGVuIGxpbmtpbmcgY29tbW9uDQo+ID4gc3R1YiBmaWxlcyB0byB4ODYvZWZpLiBXZSBhZGQg YSByZWd1bGFyIGZpbGUgY2hlY2sgaW4gZWZpDQo+ID4gc3R1YiBmaWxlcycgbGluayBzY3JpcHQu IERlcGVuZHMgb24gdGhpcyBjaGVjayB3ZSBjYW4gYnlwYXNzDQo+ID4gdGhlIGxpbmsgYmVoYXZp b3JzIGZvciBleGlzdGVkIHN0dWIgZmlsZXMgaW4geDg2L2VmaS4NCj4gPg0KPiA+IEFzIHRoZXJl IGlzIG5vIEFybSBzcGVjaWZpYyBFRkkgc3R1YiBmdW5jdGlvbiBmb3IgQXJtIGluDQo+ID4gY3Vy cmVudCBzdGFnZSwgQXJtIHN0aWxsIGNhbiB1c2UgdGhlIGV4aXN0ZWQgc3ltYm9sIGxpbmsNCj4g PiBtZXRob2QgZm9yIEVGSSBzdHViIGZpbGVzLg0KPiANCj4gV291bGRuJ3QgaXQgYmUgYmV0dGVy IHRvIG1hbmRhdGUgdGhhdCBldmVyeSBhcmNoIGhhcyBpdHMgc3R1Yi5jLA0KPiBhbmQgaW4gdGhl IEFybSBvbmUgYWxsIHlvdSdkIGRvIChmb3Igbm93KSBpcyAjaW5jbHVkZSB0aGUgY29tbW9uDQo+ IG9uZT8gKEJ1dCBzZWUgYWxzbyBiZWxvdy4pDQo+DQoNClBlcnNvbmFsbHksIEkgZG9uJ3QgbGlr ZSB0byBpbmNsdWRlIGEgQyBmaWxlIGludG8gYW5vdGhlciBDIGZpbGUuDQpCdXQgSSBhbSBPSyBh cyBsb25nIGFzIHRoZSBBcm0gbWFpbnRhaW5lcnMgYWdyZWUuDQpAU3RlZmFubyBTdGFiZWxsaW5p IEBCZXJ0cmFuZCBNYXJxdWlzIEBKdWxpZW4gR3JhbGwNCg0KPiA+IC0tLSBhL3hlbi9hcmNoL2Fy bS9NYWtlZmlsZQ0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9NYWtlZmlsZQ0KPiA+IEBAIC0xLDYg KzEsNSBAQA0KPiA+ICBvYmotJChDT05GSUdfQVJNXzMyKSArPSBhcm0zMi8NCj4gPiAgb2JqLSQo Q09ORklHX0FSTV82NCkgKz0gYXJtNjQvDQo+ID4gLW9iai0kKENPTkZJR19BUk1fNjQpICs9IGVm aS8NCj4gPiAgb2JqLSQoQ09ORklHX0FDUEkpICs9IGFjcGkvDQo+ID4gIG9iai0kKENPTkZJR19I QVNfUENJKSArPSBwY2kvDQo+ID4gIGlmbmVxICgkKENPTkZJR19OT19QTEFUKSx5KQ0KPiA+IEBA IC0yMCw2ICsxOSw3IEBAIG9iai15ICs9IGRvbWFpbi5vDQo+ID4gIG9iai15ICs9IGRvbWFpbl9i dWlsZC5pbml0Lm8NCj4gPiAgb2JqLXkgKz0gZG9tY3RsLm8NCj4gPiAgb2JqLSQoQ09ORklHX0VB UkxZX1BSSU5USykgKz0gZWFybHlfcHJpbnRrLm8NCj4gPiArb2JqLXkgKz0gZWZpLw0KPiA+ICBv YmoteSArPSBnaWMubw0KPiA+ICBvYmoteSArPSBnaWMtdjIubw0KPiA+ICBvYmotJChDT05GSUdf R0lDVjMpICs9IGdpYy12My5vDQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9lZmkvTWFr ZWZpbGUgYi94ZW4vYXJjaC9hcm0vZWZpL01ha2VmaWxlDQo+ID4gaW5kZXggNDMxM2MzOTA2Ni4u ZGZmZTcyZTU4OSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vZWZpL01ha2VmaWxlDQo+ ID4gKysrIGIveGVuL2FyY2gvYXJtL2VmaS9NYWtlZmlsZQ0KPiA+IEBAIC0xLDQgKzEsMTIgQEAN Cj4gPiAgaW5jbHVkZSAkKHNyY3RyZWUpL2NvbW1vbi9lZmkvZWZpLWNvbW1vbi5taw0KPiA+DQo+ ID4gK2lmZXEgKCQoQ09ORklHX0FSTV9FRkkpLHkpDQo+ID4gIG9iai15ICs9ICQoRUZJT0JKLXkp DQo+ID4gIG9iai0kKENPTkZJR19BQ1BJKSArPSAgZWZpLWRvbTAuaW5pdC5vDQo+ID4gK2Vsc2UN Cj4gPiArIyBBZGQgc3R1Yi5vIHRvIEVGSU9CSi15IHRvIHJlLXVzZSB0aGUgY2xlYW4tZmlsZXMg aW4NCj4gPiArIyBlZmktY29tbW9uLm1rLiBPdGhlcndpc2UgdGhlIGxpbmsgb2Ygc3R1Yi5jIGlu IGFybS9lZmkNCj4gPiArIyB3aWxsIG5vdCBiZSBjbGVhbmVkIGluICJtYWtlIGNsZWFuIi4NCj4g PiArRUZJT0JKLXkgKz0gc3R1Yi5vDQo+ID4gK29iai15ICs9IHN0dWIubw0KPiA+ICtlbmRpZg0K PiANCj4gSSByZWFsaXplIFN0ZWZhbm8gaW5kaWNhdGVkIGhlJ3MgaGFwcHkgd2l0aCB0aGUgQXJt IHNpZGUsIGJ1dCBJIHN0aWxsDQo+IHdvbmRlcjogV2hhdCB1c2UgaXMgdGhlIHN0dWIgb24gQXJt MzI/IEV2ZW4gZnVydGhlciAtIG9uY2UgeW91IGhhdmUgYQ0KPiBjb25maWcgb3B0aW9uIChyYXRo ZXIgdGhhbiB4ODYnZXMgYnVpbGQtdGltZSBjaGVjayBwbHVzIHg4NidlcyBkdWFsLQ0KPiBwdXJw b3Npbmcgb2YgYWxsIG9iamVjdCBmaWxlcyksIHdoeSBkbyB5b3UgbmVlZCBhIHN0dWIgaW4gdGhl IGZpcnN0DQo+IHBsYWNlPyBZb3Ugb3VnaHQgdG8gYmUgYWJsZSB0byBkZWFsIHdpdGggdGhpbmdz IHZpYSBpbmxpbmUgZnVuY3Rpb25zDQo+IGFuZCBtYWNyb3MsIEkgd291bGQgdGhpbmsuDQo+IA0K DQpXZSB3aWxsIHVzZSBlZmlfZW5hYmxlZCgpIG9uIHNvbWUgY29tbW9uIGNvZGVzIG9mIEFybS4g SW4gdGhlIGxhc3QNCnZlcnNpb24sIEkgaGFkIHVzZWQgc3RhdGljIGlubGluZSBmdW5jdGlvbiwg YnV0IHRoYXQgd2lsbCBuZWVkIGFuDQpDT05GSUdfRUZJIGluIHhlbi9lZmkuaCB0byBnYXRlIHRo ZSBkZWZpbml0aW9ucyBvZiBFRkkgZnVuY3Rpb25zLA0Kb3RoZXJ3aXNlIHdlIGp1c3QgY2FuIGlt cGxlbWVudCB0aGUgZWZpX2VuYWJsZWQgaW4gbm9uLXN0YXRpYy1pbmxpbmUNCndheS4gT3IgdXNl IGFub3RoZXIgbmFtZSB0byB3cmFwcGVyIGVmaV9lbmFibGVkLiAocGF0Y2gjMjAsIDIxKQ0KQnV0 IGFzIHg4NiBoYXMgaXRzIG93biB3YXkgdG8gZGVjaWRlIEVGSSBidWlsZCBvciBub3QsIHRoZSBD T05GSUdfRUZJDQpoYXMgYmVlbiByZWplY3RlZC4gSW4gdGhpcyBjYXNlLCB3ZSB1c2UgQ09ORklH X0FSTV9FRkkgZm9yIEFybSBpdHNlbGYuDQoNCkZvciBDT05GSUdfQVJNX0VGSSwgaXQncyBpbXBv c3NpYmxlIHRvIGJlIHVzZWQgaW4geGVuL2VmaS5oIHRvIGdhdGUNCmRlZmluaXRpb25zLiBTbyBp ZiBJIHdhbnQgdG8gdXNlIG1hY3JvcyBvciBzdGF0aWMtaW5saW5lIGZ1bmN0aW9ucywNCkkgbmVl ZCB0byB1c2UgI2lmZGVmIENPTkZJR19BUk1fRUZJIGluIGV2ZXJ5d2hlcmUgdG8gZ2F0ZSB4ZW4v ZWZpLmguDQpPciB1c2UgYW5vdGhlciBoZWFkZXIgZmlsZSB0byB3YXJwcGVyIHhlbi9lZmkuaC4N Cg0KPiA+IC0tLSBhL3hlbi9jb21tb24vZWZpL2VmaS1jb21tb24ubWsNCj4gPiArKysgYi94ZW4v Y29tbW9uL2VmaS9lZmktY29tbW9uLm1rDQo+ID4gQEAgLTksNyArOSw4IEBAIENGTEFHUy15ICs9 IC1pcXVvdGUgJChzcmNkaXIpDQo+ID4gICMgZS5nLjogSXQgdHJhbnNmb3JtcyAiZGlyL2Zvby9i YXIiIGludG8gc3VjY2Vzc2l2ZWx5DQo+ID4gICMgICAgICAgImRpciBmb28gYmFyIiwgIi4uIC4u IC4uIiwgIi4uLy4uLy4uIg0KPiA+ICAkKG9iaikvJS5jOiAkKHNyY3RyZWUpL2NvbW1vbi9lZmkv JS5jIEZPUkNFDQo+ID4gLQkkKFEpbG4gLW5mcyAkKHN1YnN0ICQoc3BhY2UpLC8sJChwYXRzdWJz dCAlLC4uLCQoc3Vic3QNCj4gLywgLCQob2JqKSkpKS9zb3VyY2UvY29tbW9uL2VmaS8kKDxGKSAk QA0KPiA+ICsJJChRKXRlc3QgLWYgJEAgfHwgXA0KPiA+ICsJbG4gLW5mcyAkKHN1YnN0ICQoc3Bh Y2UpLC8sJChwYXRzdWJzdCAlLC4uLCQoc3Vic3QNCj4gLywgLCQob2JqKSkpKS9zb3VyY2UvY29t bW9uL2VmaS8kKDxGKSAkQA0KPiANCj4gUGxlYXNlIGNhbiB5b3UgaW5kZW50IHRoZSAibG4iIHRv IG1hdGNoICJ0ZXN0Iiwgc3VjaCB0aGF0IGl0J3MgZWFzaWx5DQo+IHZpc2libGUgKHdpdGhvdXQg cGF5aW5nIGF0dGVudGlvbiB0byBsaW5lIGNvbnRpbnVhdGlvbiBjaGFyYWN0ZXJzKQ0KPiB0aGF0 IHRoZXNlIHR3byBsaW5lcyBhcmUgYSBzaW5nbGUgY29tbWFuZD8NCj4gDQoNClllYWgsIG9mIGNv dXJzZSwgSSB3aWxsIGRvIGl0Lg0KDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu May 19 02:37:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 02:37:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332581.556295 (Exim 4.92) (envelope-from ) id 1nrW2g-0005j1-S3; Thu, 19 May 2022 02:37:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332581.556295; Thu, 19 May 2022 02:37:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrW2g-0005iu-PM; Thu, 19 May 2022 02:37:34 +0000 Received: by outflank-mailman (input) for mailman id 332581; Thu, 19 May 2022 02:37:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrW2e-0005A9-Vd for xen-devel@lists.xenproject.org; Thu, 19 May 2022 02:37:33 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0630.outbound.protection.outlook.com [2a01:111:f400:fe02::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a217b76b-d71c-11ec-837e-e5687231ffcc; Thu, 19 May 2022 04:37:32 +0200 (CEST) Received: from AM6P191CA0105.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::46) by AM0PR08MB3859.eurprd08.prod.outlook.com (2603:10a6:208:107::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 02:37:29 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::de) by AM6P191CA0105.outlook.office365.com (2603:10a6:209:8a::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Thu, 19 May 2022 02:37:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 02:37:28 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Thu, 19 May 2022 02:37:27 +0000 Received: from edf150d6f917.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9D3FBA21-F1EE-424A-9850-45B8F9306F4B.1; Thu, 19 May 2022 02:37:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id edf150d6f917.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 May 2022 02:37:21 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB6796.eurprd08.prod.outlook.com (2603:10a6:10:2ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 02:37:19 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.015; Thu, 19 May 2022 02:37:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a217b76b-d71c-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aU1ZZnqgrNYkUx9VdxenAgpy84r4p+ScpIsiSUE6TbyJTCovzfqBwVI5rVuDuy4SBrvZzJQmULt/657Qw3YszYYnX0DKZqhAwRxMTUq3eP35TZipYI8NlcQrKpiL7X1HB32qTI66clH16a7cL+EpbO/E9upWCZe6aYdhi80YoO5/v0GJqxd7yRtpuLt0Paa7vBAyL64bVn08AenXHDxesC1cHg5ebfS5SeGuTb2R9Zm9XOCG356uB/AGuaxCG/OUeOQiCG7e8xfQUWpX9ed9/2JJyOdaZ5NPRxO0+tW+a6+sOPIpfQlgJ1SlOlpi1tpaFohE80MAsXBXO5USj6/+QA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=TyGuRnf8NOaE9t2IL1b9OdlWGnS68q/rrvCoiwWzZyWc5tEVxLMzWkN7XxKsDaB5J48xwIrOOkQ+hNthDBTYZlV50q5KPf/u0RSVQvX9plFLk8I+ZoJNU6xW6mKBOregMgJQ0RLLY1bZIXdVhD+JI/r0zYRErM9EBgBddYFCLAmkhr0QmFxTok3Wp4HfvxX5wz8CW6kw5TQDyqAHWol/itaYDReAjvi6oO/q2nX3TGBn0bEvGQh8xlhy3cLlA1vPlgSqEA0f7OhEkEj5zigK7mg/2D/9Vpa9gatELa3HU88MgR7KHoXuYnp/jW5QQLLJfdUL2SN5GYGR6ZTVl92dUg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=S/7ofVYQYB4fnpBijM7zncHCYZJwm+BaQhr6bvXNRqfGA640ZTJ4eQfF0W7JDRf36dtSVU+GB5uFHQkNLixhbzKCOCXL00JFMQ46mFt9CKrRmBujHt1JHdWnX1jgwoxpxbTtC6hkf3xyxMxNmqCnvmzBmN7x6/00JB3/8EViiQQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGf/my5sl8WwIsx2mk3hpmq8q5moudNVLV31EmcbJnE7C2bIw1Iiu7rega4yKj4YzUXzkZbGjSXouhbaxWUmGtJjfXF1NxCHiimrzxVVPhXGNRqTl/6fmjfjMJdlWTWFgyUOYBfEzmVA9mn30PU/IDLG+f6W4vrRRu+rgJbYbWpLJhwx0qjOjjCJPPz/0eT9CnbA6LHvOOaBjsLSkahEi9VNZRt7yJP9mXA0C1IS57n9ehlHXr2mPEZPIIqBSvHk6heZzM4RZknAq8+dCp3GKVqTswVUdcnPtFZDb1QRzq6cKLbGhfkWu+Og6DH2xaGhkTaYFqmuwQji13VAv7HNOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=JaTiMfEMW70WKuA7Kn4eG3IzwN25NgDZ15vbnnTj/DkQMSlQQtI+JkwWcDJmcGgAY+G/J9Z9/mA6RKXsTDXV9CRemdtZmiv11/GvV+LcMFjzlYNwXy9pu6d1dJlPPy8fjubbI4e3e6+j6g2jqyN+uQyyCnCxiYrzSRGgpZO6VwmZohPZbjB1qm9NzHqkCE+FUL5vwJboKzj8sBoCrwkIyWyFpRzDzFj04TraOT64XbGY2B2AFN5FOEP/e2XwxuEy8Yaj3HBekizRkXq3IXngmcjmBCb2YRtrfTj6qg+NmzAcb3IqYgzyaydxj/PseGgypsq5Aa3+YdaVXk7HdjUhpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0VtX9O6STDiYkp7saiUV02SApI8T6q3B2TRx1qsQx8=; b=S/7ofVYQYB4fnpBijM7zncHCYZJwm+BaQhr6bvXNRqfGA640ZTJ4eQfF0W7JDRf36dtSVU+GB5uFHQkNLixhbzKCOCXL00JFMQ46mFt9CKrRmBujHt1JHdWnX1jgwoxpxbTtC6hkf3xyxMxNmqCnvmzBmN7x6/00JB3/8EViiQQ= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message Thread-Topic: [PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message Thread-Index: AQHYZNkPIMguWCkDT0iF46SXZxuwPq0krieAgADat1A= Date: Thu, 19 May 2022 02:37:19 +0000 Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A5FFDF57C93F1945AEF1E59B9EBDD5B8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7ea7460d-db16-4c72-ffae-08da3940841a x-ms-traffictypediagnostic: DB9PR08MB6796:EE_|VE1EUR03FT049:EE_|AM0PR08MB3859:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rjLmK8gxpM1ooKC1TT9I3tpqt/rMI+kHH+CHXSrsVMBz0BkyWW6d/Ogwoc59BjNftEDDLeVL8nPCHsxISJmcuTmRTrw3kf0eblNbvvYwh9MfEic/WAB8Ntcqb71Hig3Q+OMvMWueQU1Bc0TmTPnniiJn1PjbLH6ow4/wq4dsRU2REw4fT8dNDSyjvVddAelhEYQutqxWp+1RASuOVRdrtWrf6vNGV59D41l6a0e9aLTnaWLskJI1hd7SiUEFRBWr9GuTxMyo/OufH5QxFHzXq2KBKySgJxlXN5+uEB7kwHv7CJolc5kv0gmxESjigCmjhvUz2iz8/XfUejwkqZ5dhscKUOUSNggM0Kq8P+qckY06UjV5HeKE6CHXmcEj8yXrVF3PIpWReB0LII7KuTcRU56VO2c0OAI/URj03t/N2uTr/0aSJyARxqOG6RSEfXVzBM7ZxjjiigYCOwdWRsFlVN1oHwWvgLkBt1oM0APmxiDmKoo2rP92k5y6JIQfY2t/SmI4aL5tnIwfgj/WdFTSMjUgMYgGUZcW+HHG5v1RcfVw093KGJd5CZGi38wv1ildFqA+vClQydnxFJtL/aG4AGMDlhIxMNujG3coTRHuieiit2sdRqhOGLoaTzTm9R47HNoo2Bb2dRiPZJEcCpRPn39P+u+RODDVMGULEqG+XXDHOIUf12RetRCbkhDI5TpSJ3bSREzi6ay2EbBBEdI9xg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(64756008)(38070700005)(4326008)(8676002)(38100700002)(66446008)(66946007)(122000001)(66556008)(76116006)(66476007)(316002)(33656002)(71200400001)(55016003)(508600001)(83380400001)(54906003)(6916009)(86362001)(2906002)(8936002)(52536014)(15650500001)(5660300002)(9686003)(26005)(6506007)(53546011)(186003)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6796 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bf60dee4-c20d-47ba-af91-08da39407ed8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mc70q+vC8LDgVAoGUl8/+JEh6kYRDDNekZQMt4u5AGaORN0il8tjKbdcr/WGJMRdqKKVrJVnzYP6dDN/SK3lDNyHkmuBvoq+2ITRnLP9lL/+hU7q9sJjiGm3YPmTeGN+q9S8t/wA5aJEJMUhIdYdpvN3MR5JYEnyh+LaHqDt+HpBpM1K2cm1MvcIs7LXpvvyCtxHqz32g7Nf9HZQkfcWm4YDnFpVKIxCBb8Y/RIm7x9TJS58jqkE7NeijO11dHQroU7+3sBiZ35YifWBYUZEmIEAxnDrspk5olIkEwG0Abp6+C597m2Zv8eoyJbpBkaltq5+UHSdBkMHn/ZuraQXX69x5sirqsznxwib+6+JKk0IFQ6X2ijfTOGbfDJviqlu+BYbHe9yIFvGbTR0BlCfUoiBXLUiJhpf4JYyLOSFUrvn62p9jTjavp0l6ouzz7BvaCyxAny+SYynrRiacj4a8tOXA2mQMKWBrvD8UIDPxtDaZTxl7RMr4OIPW27ie+KXtWEU5pNpJxVb13Cg9hTfIoBZG7igktGZ3pZQ4OfBDoBU2AbY5U/0n6X/lRq4ZGXgHwswEbzD+WUIsl1AYL4AFpgVoc4wz8IMyJnzKCxNg2OhxdUEArtt2Bywr+nSBQue+K6XST5EYc4PI8sS3gvhRUPRxqlOGfESIvq6Lti8I40rJRzY1E7qIge/F+dfeOak X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(336012)(47076005)(82310400005)(508600001)(36860700001)(55016003)(186003)(5660300002)(2906002)(40460700003)(15650500001)(83380400001)(33656002)(316002)(8676002)(6862004)(52536014)(8936002)(70586007)(54906003)(70206006)(86362001)(6506007)(81166007)(26005)(7696005)(4326008)(356005)(53546011)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 02:37:28.2304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea7460d-db16-4c72-ffae-08da3940841a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3859 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDXmnIgxOOaXpSAyMTozNA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMg OS85XSB4ZW4veDg2OiB1c2UgSU5GTyBsZXZlbCBmb3Igbm9kZSdzIHdpdGhvdXQNCj4gbWVtb3J5 IGxvZyBtZXNzYWdlDQo+IA0KPiBPbiAxMS4wNS4yMDIyIDAzOjQ2LCBXZWkgQ2hlbiB3cm90ZToN Cj4gPiBJbiBwcmV2aW91cyBjb2RlLCBYZW4gd2FzIHVzaW5nIEtFUk5fV0FSTklORyBmb3IgbG9n IG1lc3NhZ2UNCj4gPiB3aGVuIFhlbiBmb3VuZCBhIG5vZGUgd2l0aG91dCBtZW1vcnkuIFhlbiB3 aWxsIHByaW50IHRoaXMNCj4gPiB3YXJuaW5nIG1lc3NhZ2UsIGFuZCBzYWlkIHRoYXQgdGhpcyBt YXkgYmUgYW4gQklPUyBCdWcgb3INCj4gPiBtaXMtY29uZmlndXJlZCBoYXJkd2FyZS4gQnV0IGFj dHVhbGx5LCB0aGlzIHdhcm5pbmcgaXMgYm9ndXMsDQo+ID4gYmVjYXVzZSBpbiBhbiBOVU1BIHNl dHRpbmcsIG5vZGVzIGNhbiBvbmx5IGhhdmUgcHJvY2Vzc29ycywNCj4gPiBhbmQgd2l0aCAwIGJ5 dGVzIG1lbW9yeS4gU28gaXQgaXMgdW5yZWFzb25hYmxlIHRvIHdhcm4gYWJvdXQNCj4gPiBCSU9T IG9yIGhhcmR3YXJlIGNvcnJ1cHRpb24gYmFzZWQgb24gdGhlIGRldGVjdGlvbiBvZiBub2RlDQo+ ID4gd2l0aCAwIGJ5dGVzIG1lbW9yeS4NCj4gPg0KPiA+IFNvIGluIHRoaXMgcGF0Y2gsIHdlIHJl bW92ZSB0aGUgd2FybmluZyBtZXNzYWdlcywgYnV0IGp1c3QNCj4gPiBrZWVwIGFuIGluZm8gbWVz c2FnZSB0byBpbmZvIHVzZXJzIHRoYXQgdGhlcmUgaXMgb25lIG9yIG1vcmUNCj4gPiBub2RlcyB3 aXRoIDAgYnl0ZXMgbWVtb3J5IGluIHRoZSBzeXN0ZW0uDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5 OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gDQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1 bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IHByZWZlcmFibHkgd2l0aCAuLi4NCj4gDQo+ID4g LS0tIGEveGVuL2FyY2gveDg2L3NyYXQuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni9zcmF0LmMN Cj4gPiBAQCAtNTQ5LDggKzU0OSw3IEBAIGludCBfX2luaXQgYWNwaV9zY2FuX25vZGVzKHBhZGRy X3Qgc3RhcnQsIHBhZGRyX3QNCj4gZW5kKQ0KPiA+ICAJCXVpbnQ2NF90IHNpemUgPSBub2Rlc1tp XS5lbmQgLSBub2Rlc1tpXS5zdGFydDsNCj4gPg0KPiA+ICAJCWlmICggc2l6ZSA9PSAwICkNCj4g PiAtCQkJcHJpbnRrKEtFUk5fV0FSTklORyAiU1JBVDogTm9kZSAldSBoYXMgbm8gbWVtb3J5LiAi DQo+ID4gLQkJCSAgICAgICAiQklPUyBCdWcgb3IgbWlzLWNvbmZpZ3VyZWQgaGFyZHdhcmU/XG4i LCBpKTsNCj4gPiArCQkJcHJpbnRrKEtFUk5fSU5GTyAiU1JBVDogTm9kZSAldSBoYXMgbm8gbWVt b3J5LlxuIiwgaSk7DQo+IA0KPiAuLi4gdGhlIGZ1bGwgc3RvcCBhbHNvIGRyb3BwZWQgKGFuZCBt YXliZSB0aGUgdXBwZXItY2FzZSBOIGNvbnZlcnRlZCB0bw0KPiBsb3dlci1jYXNlKS4NCj4gDQoN Ck9rLCBJIHdpbGwgZG8gaXQgaW4gbmV4dCB2ZXJzaW9uLg0KDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu May 19 02:53:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 02:53:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332590.556307 (Exim 4.92) (envelope-from ) id 1nrWHk-00086t-97; Thu, 19 May 2022 02:53:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332590.556307; Thu, 19 May 2022 02:53:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWHk-00086m-4i; Thu, 19 May 2022 02:53:08 +0000 Received: by outflank-mailman (input) for mailman id 332590; Thu, 19 May 2022 02:53:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWHi-00086M-Hr; Thu, 19 May 2022 02:53:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWHi-0001XH-B6; Thu, 19 May 2022 02:53:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWHh-0003s4-S5; Thu, 19 May 2022 02:53:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrWHh-0006CF-Rc; Thu, 19 May 2022 02:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GNr7+ySTsVFBukv0/Go53zQXfhpCR7ZQy52PmFKaS+k=; b=mRzKqL/NtgWbtGdbGva2c5jROt NDbkEfk7KnqQPgIH/2NtVSvOlGkfjdjHHKGFVzqvgEM7+UipWuaoT9LuUxMCD4PZztn111yt2ez8I 3RlCzJ9unKILv3LoyL6e2nCJqStjspnQsjjUZ5wQj6TFSt/0l9a1+lYps3CpY0edwEGI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170556: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=708620d29db89d03e822b8d17dc75fbac865c6dc X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 02:53:05 +0000 flight 170556 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170556/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 708620d29db89d03e822b8d17dc75fbac865c6dc baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1091 attempts Testing same since 170392 2022-05-13 15:40:22 Z 5 days 110 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6662 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 03:34:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 03:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332600.556318 (Exim 4.92) (envelope-from ) id 1nrWvn-0003pm-Fb; Thu, 19 May 2022 03:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332600.556318; Thu, 19 May 2022 03:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWvn-0003pf-Bg; Thu, 19 May 2022 03:34:31 +0000 Received: by outflank-mailman (input) for mailman id 332600; Thu, 19 May 2022 03:34:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWvm-0003pV-J5; Thu, 19 May 2022 03:34:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWvm-0002Dv-GM; Thu, 19 May 2022 03:34:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWvl-0004y2-Qm; Thu, 19 May 2022 03:34:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrWvl-0002dK-QI; Thu, 19 May 2022 03:34:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7zaGAj/NIPs9W9Guu6Iz8cogjE9eFdZcozplDv0RsKY=; b=CJratEcN0P0t07zhAgeWtOfxLS FNgz84OYTgZT4Voe5XsXrmCUry67auPDWOL8mBTNnuaqduovWDx61ed8kQkUOmEu8R2N8g1WcQsD+ YrRdhd0BsEkS/0/T8eBbFvazWy9+WM6CtFX315qqyoiEHbR2AaJ4VHyzPl6x3xtuoBW0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170557: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=2189c71026cba9dab768776a2f8ebf689b484c56 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 03:34:29 +0000 flight 170557 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 2189c71026cba9dab768776a2f8ebf689b484c56 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1092 attempts Testing same since 170557 2022-05-19 03:10:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6713 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 03:37:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 03:37:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332611.556328 (Exim 4.92) (envelope-from ) id 1nrWyX-0004UZ-26; Thu, 19 May 2022 03:37:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332611.556328; Thu, 19 May 2022 03:37:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWyW-0004US-VL; Thu, 19 May 2022 03:37:20 +0000 Received: by outflank-mailman (input) for mailman id 332611; Thu, 19 May 2022 03:37:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrWyV-0004UK-DG for xen-devel@lists.xenproject.org; Thu, 19 May 2022 03:37:19 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0607.outbound.protection.outlook.com [2a01:111:f400:fe1f::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id faf56ee0-d724-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 05:37:18 +0200 (CEST) Received: from DB6PR0301CA0085.eurprd03.prod.outlook.com (2603:10a6:6:30::32) by AM6PR08MB5000.eurprd08.prod.outlook.com (2603:10a6:20b:e6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 03:37:14 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::5e) by DB6PR0301CA0085.outlook.office365.com (2603:10a6:6:30::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16 via Frontend Transport; Thu, 19 May 2022 03:37:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 03:37:14 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Thu, 19 May 2022 03:37:14 +0000 Received: from 78f24063d63c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22FEF9E4-4012-4455-988A-789A9163DDDC.1; Thu, 19 May 2022 03:37:08 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 78f24063d63c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 19 May 2022 03:37:08 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB7351.eurprd08.prod.outlook.com (2603:10a6:102:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 03:37:06 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.015; Thu, 19 May 2022 03:37:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faf56ee0-d724-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FBBEKbXRGWRX8WUMTgmo7yCffzOWXw0PIvnZBY8CFRGzJTclt0rC8SHW1vIWZsC/MxmmNANuFD1yU3EvJMHIk/Uo5cFvdxxzIO+jyi6DIRcoXUUzurSuCfE93/x6HmsN6gcD4UA20I9uIPyCRYxd6aYRvEZ7Zwdl/Rc/qp1e6N0lZMtojebd8B2JMFZq8NYLg7RlzhzphBgrK0zexok7oK0nIVl4M9/oLOC5Giwk1/u3Kj1LfHa8itt5DbbaUvDr4gUPxUpAQN8tnosz4ce5MqQzV97cnvhQjGHNjgy0W38JGvw8i+LKilUahe5+d8gNwqWza5ij5wdQeIvtC49Uig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xs4zjADiaEX/YriP9sNFK7JlmaSd1WYyrSb7ClwrtMA=; b=hx0l6yLrecPD7KatwgJ2sD4u+INKhWYjA+nAlD6Q9Mkify+B0laVxyr/LHsZzTbOPJRSVRpts5bVhk/eKTz97fCt7y2Eta2e+X/ohG7NVH0n8DigH5wz5XvpyemNBf6Xejre6ZcrbMIQtC0+qVeDtOOa2WRVPk4P9fB2oP/INIYLkD+vb6FL7SE8dXx+feGxB5yjQGA7t3Dds+87A+zH3NlZ2ExxV6nROh14Zq8sHBSixoP3F6M0+tXQt0lwK6kFVV0xnppf+gxNKfzLRvcd6owkS5OEILaPNmeZWKst5u+xMoAz5EMozWSPpkMUOS5BMEbeLDK5H66Et/AWQlIlCQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xs4zjADiaEX/YriP9sNFK7JlmaSd1WYyrSb7ClwrtMA=; b=WAJ2X676y63OoQo2k5bk8dHJUugBp7thZ/ULvXNFgbuwNfYKjh5EBKE5mCIxopn5wJuIxQQTlJ/XumtJ3csIvXnfSoRn6xtjGRNfzG8oo7KGWjJleSAIMIc4OAf5DsJ+gWu8DEwVssmwhvP+m/q6QHkctXeYePXQkCUUDOwBoaI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGyfaF5CsmFGERQ0wkLAcbZYN9KUspgoOvQJiXxbVX0922hn8hQaEWaEDrIW3BBJtbsG3C4Lq94HxH5qrJtu0hMpIsF+nPrqi7gND+RdlabRUosrpFABGiLR3c66AyJ4Oy3DS9UCSOuypA/uOwEjkNSEGppsqJsBfmCAogVqdY/eNLZ9ewHuN29aYV/YZs5ToQXOIbLZoSE5KSSYGGZuyWVLbIUh2CDhjbOFX/9yoKrnEQP0yEpN2dhaV1DdShRC4JjHiqq/vhUWOiXdnXCLZ4sBad9hkWV9xBguc6DUHaJH0d19HgFfEOySyVvfYBNGAmQ0KrBJstB49SiuMC+/yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xs4zjADiaEX/YriP9sNFK7JlmaSd1WYyrSb7ClwrtMA=; b=ZJw2/v+DivS69JSBv4jATD/NZCs6QIDzFZUKnYn6qOkgdI65miqKNHwAELN11SkFVEluvIqEAmoCAvV2haStQ/ShZRiRqjXwhLw4gTcDOm2XEbVgjCY2PMJLv3Suu7BLE4vlI07OdqrFeIdqTGQH6MO3tO1UrG62dzom2vyeI7v2rTLO+KYqxD+TnwIz7tUn0rZHqzncQlXs131wlnJsSuX4DCGjF6FijA8EIMbjLWpttu7sYMo62AYVBkrYl75XyIMFrD7rMKui6JTQ+OuUxS1CPwxl3xqwz8FimddPdPKbQbjf0F1AY8gmu/SmKugKWN3k8sSNiCOjLMk6h5CkYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xs4zjADiaEX/YriP9sNFK7JlmaSd1WYyrSb7ClwrtMA=; b=WAJ2X676y63OoQo2k5bk8dHJUugBp7thZ/ULvXNFgbuwNfYKjh5EBKE5mCIxopn5wJuIxQQTlJ/XumtJ3csIvXnfSoRn6xtjGRNfzG8oo7KGWjJleSAIMIc4OAf5DsJ+gWu8DEwVssmwhvP+m/q6QHkctXeYePXQkCUUDOwBoaI= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 8/9] xen/x86: add detection of memory interleaves for different nodes Thread-Topic: [PATCH v3 8/9] xen/x86: add detection of memory interleaves for different nodes Thread-Index: AQHYZNkRevkwA8X5Q0qos/NOAm18uq0krTiAgADb+cA= Date: Thu, 19 May 2022 03:37:05 +0000 Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-9-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 91E66FCFB6F79B47B50E6D37E1D9BADA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ea267980-7a32-44e1-63d2-08da3948dd82 x-ms-traffictypediagnostic: PAXPR08MB7351:EE_|DBAEUR03FT042:EE_|AM6PR08MB5000:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7tRpuYiICLJmnKt0Z+X6tW35iSYnDxn9gVNoH1T4Z9JDyXjjR5i3hI2mq3F21EQkUij/OJ1N/84InWCw5Z7YmCdtwH5aWLv+tpknBUid50hZpa8I0a9YQtg8r6Ya/ZAoKDULhxPaG3EqRGT+gyUs/W6QOBOJ+iW/ZjLbxPd7N2jsJotrlzrGnZCN+UfauPJFFqtf3muYI4fydsh+JwIMUvEe/sVSQlm0slspbvT5eIyJTZ6eaTFLDlR8s5au894cxWPu06SPzF2kwd9bDteXZzbcMO7s/MVPz4ZHu3qfV+u1v/y+Q9Q6Xf/zvMmNMcz6Fa2xSYJhxtsDDrk5Hbr13M8hb1HmlvzAGwGml7JmUmT3zd1Ms0T3RAcRs5Yea4XaIdwS4xr2kA8dElSymGh3+nd+5a6cL9L5/sjHI81tcj8mdZrixLXzltW74z8s2/PzySnwwkae8PPv7v2gQeQ3/GnqibqwRyVUA+yqZ0+cToCmnnjq4mqr6Xu0d/G0tzqZkC3BVh148PgZ+q/PtsXLnFdM9PKJUCQ2X+efhSLvax/oAiJoCghXTB87sApMfzIbZ/t9gnSbZrUw/Fm8xlziooHLBWRgvCN+gKjytb360XE37F3HiiRuPE9fnvIAPxdfxQpr8Ego1/CtNAahIEBX4iB79j9gOiz6cJMtCOpmZGmmXIY5wDSS5KjzaYKJBIyNvgOLwakqLc1nCmUY6V9BmQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(38100700002)(9686003)(316002)(54906003)(53546011)(6506007)(86362001)(186003)(2906002)(122000001)(64756008)(8936002)(52536014)(5660300002)(66556008)(66476007)(66446008)(55016003)(76116006)(66946007)(71200400001)(6916009)(26005)(33656002)(83380400001)(38070700005)(508600001)(8676002)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7351 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d8d4a0f2-552d-4887-1a74-08da3948d892 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MnliTgJdHEVxC+JkKIpN8oVtU+/0KhP3G+vCuV9q/rv3J/DwonBFF2w6NdzC5upmIXaR6EfyQMWsZxhHuIC6kCWbXfUYwLG40sZRhmhQc4mk/MOuyaKxKE8HbvgtgCEthpFl40LlgRaw4V8hWA+xNS8/tJpKhL9zUGymTTotbLDk4paaXlnn8ryh1a/55wCVrVhQsseQMzFDqNBAIxl9/HxVqAdCHJjHmYqWpL3P3ZkVyiF6m5jeeasuhQngfX/VyrpgPQprZD6Lxs+6z+LK1k0ZbWeq9VBBOC1Nyq/yhQrliPm+Eyu7JA/xNe1nD3py042YKIr/YIs14vk2m+D++8hJ2BtIhsnFdrArZZpDMWsJRrNpPwIEsi4BPFD6Hgi4g/aePFAPljiWQLjt1sMDb6tMISfoyjgpS2jMyYTO+Tb1ZFBcr4ojEJB1ggAW+Y4EW7Yl8iFexpLxKQbz7U/ZCyjozHsQAgQHE1Okc7Q1VaplSGnyqCb+k2QjpjOU6Ob/NohAgXGMSJ7hy5DE7NLwuwFmj4qttv7fu78tZTdbyvjt4uj6bW9w80yk8r4nzsxZYTv/whDmMOwzr0UalSfA2+tWjoEOoXoin1QSiyooyWPDH65PO3DhN3L4MzPTKgvvQmgOQ5AIave3Fjz5V27WBLWUoMx3CAKUuYd+pAf5M6grBidJtLd0bT6U+gVh07Wp X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(82310400005)(70206006)(508600001)(4326008)(70586007)(8676002)(6862004)(316002)(36860700001)(54906003)(7696005)(86362001)(53546011)(52536014)(81166007)(8936002)(55016003)(83380400001)(6506007)(47076005)(5660300002)(40460700003)(356005)(186003)(33656002)(2906002)(336012)(26005)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 03:37:14.3085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea267980-7a32-44e1-63d2-08da3948dd82 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5000 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDXmnIgxOOaXpSAyMTozMQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBKaWFt ZWkgWGllDQo+IDxKaWFtZWkuWGllQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyA4LzldIHhlbi94ODY6IGFkZCBkZXRlY3Rp b24gb2YgbWVtb3J5IGludGVybGVhdmVzDQo+IGZvciBkaWZmZXJlbnQgbm9kZXMNCj4gDQo+IE9u IDExLjA1LjIwMjIgMDM6NDYsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9hcmNoL3g4 Ni9zcmF0LmMNCj4gPiArKysgYi94ZW4vYXJjaC94ODYvc3JhdC5jDQo+ID4gQEAgLTQyLDYgKzQy LDEyIEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZSBub2RlX21lbWJsa19yYW5nZVtOUl9OT0RFX01FTUJM S1NdOw0KPiA+ICBzdGF0aWMgbm9kZWlkX3QgbWVtYmxrX25vZGVpZFtOUl9OT0RFX01FTUJMS1Nd Ow0KPiA+ICBzdGF0aWMgX19pbml0ZGF0YSBERUNMQVJFX0JJVE1BUChtZW1ibGtfaG90cGx1Zywg TlJfTk9ERV9NRU1CTEtTKTsNCj4gPg0KPiA+ICtlbnVtIGNvbmZsaWN0cyB7DQo+ID4gKwlOT19D T05GTElDVCA9IDAsDQo+IA0KPiBObyBuZWVkIGZvciB0aGUgIj0gMCIuDQo+IA0KDQpBY2suDQoN Cj4gPiArCUVSUl9PVkVSTEFQLA0KPiANCj4gV2hpbGUgdGhpcyBhdCBsZWFzdCBjYW4gYmUgYW4g ZXJyb3IgKHRoZSBzZWxmLW92ZXJsYXAgY2FzZSBpcyBtZXJlbHkNCj4gd2FybmVkIGFib3V0KSwg Li4uDQo+IA0KPiA+ICsJRVJSX0lOVEVSTEVBVkUsDQo+IA0KPiAuLi4gSSBkb24ndCB0aGluayB0 aGlzIGlzLCBhbmQgaGVuY2UgSSdkIHJlY29tbWVuZCB0byBkcm9wICJFUlJfIi4NCj4gDQoNCk9o LCB5ZXMuIEkgYWxsIGRyb3AgaXQgZm9yIGFsbCBhYm92ZSBlbnVtZXJhdGlvbnMuDQoNCj4gPiBA QCAtMTE5LDIwICsxMjUsNDMgQEAgaW50IHZhbGlkX251bWFfcmFuZ2UocGFkZHJfdCBzdGFydCwg cGFkZHJfdCBlbmQsDQo+IG5vZGVpZF90IG5vZGUpDQo+ID4gIAlyZXR1cm4gMDsNCj4gPiAgfQ0K PiA+DQo+ID4gLXN0YXRpYyBfX2luaXQgaW50IGNvbmZsaWN0aW5nX21lbWJsa3MocGFkZHJfdCBz dGFydCwgcGFkZHJfdCBlbmQpDQo+ID4gK3N0YXRpYyBlbnVtIGNvbmZsaWN0cyBfX2luaXQNCj4g PiArY29uZmxpY3RpbmdfbWVtYmxrcyhub2RlaWRfdCBuaWQsIHBhZGRyX3Qgc3RhcnQsIHBhZGRy X3QgZW5kLA0KPiA+ICsJCSAgICBwYWRkcl90IG5kX3N0YXJ0LCBwYWRkcl90IG5kX2VuZCwgaW50 ICptYmxraWQpDQo+IA0KPiBXaHkgImludCI/IENhbiB0aGUgdmFsdWUgcGFzc2VkIGJhY2sgYmUg bmVnYXRpdmU/DQo+IA0KDQpUaGUgY2FsbGVyICJhY3BpX251bWFfbWVtb3J5X2FmZmluaXR5X2lu aXQiIGRlZmluZXMgaW50IGZvciBub2RlIG1lbW9yeQ0KYmxvY2sgaWQsIGFuZCBhcyBhIHJldHVy biB2YWx1ZSBhdCB0aGUgc2FtZSB0aW1lLiBTbyBJIGhhdmVuJ3QgY2hhbmdlZCBpdC4NCkFzIHdl IGRvbid0IHVzZSB0aGlzICJpbnQiIGZvciByZXR1cm4gdmFsdWUgYW55IG1vcmUsIEkgYWdyZWUs IGl0IHdpbGwNCm5ldmVyIGJlIG5lZ2F0aXZlLCBJIHdvdWxkIGZpeCBpdC4NCg0KPiA+ICB7DQo+ ID4gIAlpbnQgaTsNCj4gPg0KPiA+ICsJLyoNCj4gPiArCSAqIFNjYW4gYWxsIHJlY29yZGVkIG5v ZGVzJyBtZW1vcnkgYmxvY2tzIHRvIGNoZWNrIGNvbmZsaWN0czoNCj4gPiArCSAqIE92ZXJsYXAg b3IgaW50ZXJsZWF2ZS4NCj4gPiArCSAqLw0KPiA+ICAJZm9yIChpID0gMDsgaSA8IG51bV9ub2Rl X21lbWJsa3M7IGkrKykgew0KPiA+ICAJCXN0cnVjdCBub2RlICpuZCA9ICZub2RlX21lbWJsa19y YW5nZVtpXTsNCj4gPiArCQkqbWJsa2lkID0gaTsNCj4gDQo+IFN0eWxlOiBQbGVhc2UgbWFpbnRh aW4gYSBibGFuayBsaW5lIGJldHdlZW4gZGVjbGFyYXRpb24ocykgYW5kDQo+IHN0YXRlbWVudChz KS4NCj4gDQoNCk9rLg0KDQo+ID4gQEAgLTMxMCw0MiArMzQyLDY3IEBAIGFjcGlfbnVtYV9tZW1v cnlfYWZmaW5pdHlfaW5pdChjb25zdCBzdHJ1Y3QNCj4gYWNwaV9zcmF0X21lbV9hZmZpbml0eSAq bWEpDQo+ID4gIAkJYmFkX3NyYXQoKTsNCj4gPiAgCQlyZXR1cm47DQo+ID4gIAl9DQo+ID4gKw0K PiA+ICsJLyoNCj4gPiArCSAqIEZvciB0aGUgbm9kZSB0aGF0IGFscmVhZHkgaGFzIHNvbWUgbWVt b3J5IGJsb2Nrcywgd2Ugd2lsbA0KPiA+ICsJICogZXhwYW5kIHRoZSBub2RlIG1lbW9yeSByYW5n ZSB0ZW1wb3JhcmlseSB0byBjaGVjayBtZW1vcnkNCj4gPiArCSAqIGludGVybGVhdmVzIHdpdGgg b3RoZXIgbm9kZXMuIFdlIHdpbGwgbm90IHVzZSB0aGlzIG5vZGUNCj4gPiArCSAqIHRlbXAgbWVt b3J5IHJhbmdlIHRvIGNoZWNrIG92ZXJsYXBzLCBiZWNhdXNlIGl0IHdpbGwgbWFzaw0KPiA+ICsJ ICogdGhlIG92ZXJsYXBzIGluIHNhbWUgbm9kZS4NCj4gPiArCSAqDQo+ID4gKwkgKiBOb2RlIHdp dGggMCBieXRlcyBtZW1vcnkgZG9lc24ndCBuZWVkIHRoaXMgZXhwYW5kc2lvbi4NCj4gPiArCSAq Lw0KPiA+ICsJbmRfc3RhcnQgPSBzdGFydDsNCj4gPiArCW5kX2VuZCA9IGVuZDsNCj4gPiArCW5k ID0gJm5vZGVzW25vZGVdOw0KPiA+ICsJaWYgKG5kLT5zdGFydCAhPSBuZC0+ZW5kKSB7DQo+ID4g KwkJaWYgKG5kX3N0YXJ0ID4gbmQtPnN0YXJ0KQ0KPiA+ICsJCQluZF9zdGFydCA9IG5kLT5zdGFy dDsNCj4gPiArDQo+ID4gKwkJaWYgKG5kX2VuZCA8IGVuZCkNCj4gDQo+IERpZCB5b3UgbWVhbiBu ZC0+ZW5kIGhlcmUgb24gdGhlIHJpZ2h0IHNpZGUgb2YgPCA/IEJ5IGludGVudGlvbmFsbHkNCg0K T2ghIHRoYW5rcyBmb3IgcG9pbnRpbmcgb3V0IHRoaXMgb25lISBZZXMsIHJpZ2h0IHNpZGUgc2hv dWxkIGJlIG5kLT5lbmQuDQoNCj4gbm90IGFkZGluZyAiZGVmYXVsdDoiIGluIHRoZSBib2R5LCB5 b3UgdGhlbiBhbHNvIGFsbG93IHRoZSBjb21waWxlcg0KPiB0byBwb2ludCBvdXQgdGhhdCBhZGRp dGlvbiBvZiBhIG5ldyBlbnVtZXJhdG9yIGFsc28gbmVlZHMgaGFuZGxpbmcNCj4gaGVyZS4NCj4g DQoNCkRpZCB5b3UgbWVhbiwgd2UgbmVlZCB0byBhZGQgaWYgLi4uIGVsc2UgLi4uIGluIHRoaXMg YmxvY2s/IElmIHllcywNCmlzIGl0IG9rIHRvIHVwZGF0ZSB0aGlzIGJsb2NrIGxpa2U6DQoJaWYg KG5kLT5zdGFydCAhPSBuZC0+ZW5kKSB7DQoJCW5kX3N0YXJ0ID0gbWluKG5kX3N0YXJ0LCBuZC0+ c3RhcnQpOw0KCQluZF9lbmQgPSBtYXgobmRfZW5kLCBuZC0+ZW5kKTsNCgl9DQo/DQoNCj4gPiAr CQkJbmRfZW5kID0gbmQtPmVuZDsNCj4gPiArCX0NCj4gPiArDQo+ID4gIAkvKiBJdCBpcyBmaW5l IHRvIGFkZCB0aGlzIGFyZWEgdG8gdGhlIG5vZGVzIGRhdGEgaXQgd2lsbCBiZSB1c2VkDQo+IGxh dGVyKi8NCj4gPiAtCWkgPSBjb25mbGljdGluZ19tZW1ibGtzKHN0YXJ0LCBlbmQpOw0KPiA+IC0J aWYgKGkgPCAwKQ0KPiA+IC0JCS8qIGV2ZXJ5dGhpbmcgZmluZSAqLzsNCj4gPiAtCWVsc2UgaWYg KG1lbWJsa19ub2RlaWRbaV0gPT0gbm9kZSkgew0KPiA+IC0JCWJvb2wgbWlzbWF0Y2ggPSAhKG1h LT5mbGFncyAmIEFDUElfU1JBVF9NRU1fSE9UX1BMVUdHQUJMRSkgIT0NCj4gPiAtCQkgICAgICAg ICAgICAgICAgIXRlc3RfYml0KGksIG1lbWJsa19ob3RwbHVnKTsNCj4gPiAtDQo+ID4gLQkJcHJp bnRrKCIlc1NSQVQ6IFBYTSAldSAoJSJQUklwYWRkciItJSJQUklwYWRkciIpIG92ZXJsYXBzIHdp dGgNCj4gaXRzZWxmICglIlBSSXBhZGRyIi0lIlBSSXBhZGRyIilcbiIsDQo+ID4gLQkJICAgICAg IG1pc21hdGNoID8gS0VSTl9FUlIgOiBLRVJOX1dBUk5JTkcsIHB4bSwgc3RhcnQsIGVuZCwNCj4g PiAtCQkgICAgICAgbm9kZV9tZW1ibGtfcmFuZ2VbaV0uc3RhcnQsIG5vZGVfbWVtYmxrX3Jhbmdl W2ldLmVuZCk7DQo+ID4gLQkJaWYgKG1pc21hdGNoKSB7DQo+ID4gKwlzdGF0dXMgPSBjb25mbGlj dGluZ19tZW1ibGtzKG5vZGUsIHN0YXJ0LCBlbmQsIG5kX3N0YXJ0LCBuZF9lbmQsICZpKTsNCj4g PiArCWlmIChzdGF0dXMgPT0gRVJSX09WRVJMQVApIHsNCj4gDQo+IFBsZWFzZSB1c2Ugc3dpdGNo KHN0YXR1cykgd2hlbiBjaGVja2luZyBlbnVtZXJhdGVkIHZhbHVlcy4NCj4gDQoNCk9rLCBJIHdp bGwgZG8gaXQuDQoNCj4gPiArCQlpZiAobWVtYmxrX25vZGVpZFtpXSA9PSBub2RlKSB7DQo+ID4g KwkJCWJvb2wgbWlzbWF0Y2ggPSAhKG1hLT5mbGFncyAmDQo+ID4gKwkJCQkJQUNQSV9TUkFUX01F TV9IT1RfUExVR0dBQkxFKSAhPQ0KPiA+ICsJCQkgICAgICAgICAgICAgICAgIXRlc3RfYml0KGks IG1lbWJsa19ob3RwbHVnKTsNCj4gDQo+IFN0eWxlOiBUaGUgbWlkZGxlIGxpbmUgd2FudHMgaW5k ZW50aW5nIGJ5IHR3byBtb3JlIGNoYXJhY3RlcnMuDQo+IA0KDQpZZXMsIEkgd2lsbCBkbyBpdC4N Cg0KPiA+ICsNCj4gPiArCQkJcHJpbnRrKCIlc1NSQVQ6IFBYTSAldSAoJSJQUklwYWRkciItJSJQ UklwYWRkciIpDQo+IG92ZXJsYXBzIHdpdGggaXRzZWxmICglIlBSSXBhZGRyIi0lIlBSSXBhZGRy IilcbiIsDQo+ID4gKwkJCSAgICAgICBtaXNtYXRjaCA/IEtFUk5fRVJSIDogS0VSTl9XQVJOSU5H LCBweG0sIHN0YXJ0LA0KPiA+ICsJCQkgICAgICAgZW5kLCBub2RlX21lbWJsa19yYW5nZVtpXS5z dGFydCwNCj4gPiArCQkJICAgICAgIG5vZGVfbWVtYmxrX3JhbmdlW2ldLmVuZCk7DQo+ID4gKwkJ CWlmIChtaXNtYXRjaCkgew0KPiA+ICsJCQkJYmFkX3NyYXQoKTsNCj4gPiArCQkJCXJldHVybjsN Cj4gPiArCQkJfQ0KPiA+ICsJCX0gZWxzZSB7DQo+ID4gKwkJCXByaW50ayhLRVJOX0VSUg0KPiA+ ICsJCQkgICAgICAgIlNSQVQ6IFBYTSAldSAoJSJQUklwYWRkciItJSJQUklwYWRkciIpIG92ZXJs YXBzDQo+IHdpdGggUFhNICV1ICglIlBSSXBhZGRyIi0lIlBSSXBhZGRyIilcbiIsDQo+ID4gKwkJ CSAgICAgICBweG0sIHN0YXJ0LCBlbmQsIG5vZGVfdG9fcHhtKG1lbWJsa19ub2RlaWRbaV0pLA0K PiA+ICsJCQkgICAgICAgbm9kZV9tZW1ibGtfcmFuZ2VbaV0uc3RhcnQsDQo+ID4gKwkJCSAgICAg ICBub2RlX21lbWJsa19yYW5nZVtpXS5lbmQpOw0KPiA+ICAJCQliYWRfc3JhdCgpOw0KPiA+ICAJ CQlyZXR1cm47DQo+ID4gIAkJfQ0KPiA+IC0JfSBlbHNlIHsNCj4gPiArCX0gZWxzZSBpZiAoc3Rh dHVzID09IEVSUl9JTlRFUkxFQVZFKSB7DQo+ID4gIAkJcHJpbnRrKEtFUk5fRVJSDQo+ID4gLQkJ ICAgICAgICJTUkFUOiBQWE0gJXUgKCUiUFJJcGFkZHIiLSUiUFJJcGFkZHIiKSBvdmVybGFwcyB3 aXRoDQo+IFBYTSAldSAoJSJQUklwYWRkciItJSJQUklwYWRkciIpXG4iLA0KPiA+IC0JCSAgICAg ICBweG0sIHN0YXJ0LCBlbmQsIG5vZGVfdG9fcHhtKG1lbWJsa19ub2RlaWRbaV0pLA0KPiA+ICsJ CSAgICAgICAiU1JBVO+8miBOb2RlICV1OiAoJSJQUklwYWRkciItJSJQUklwYWRkciIpIGludGVy bGVhdmVzDQo+IHdpdGggbm9kZSAldSBtZW1ibGsgKCUiUFJJcGFkZHIiLSUiUFJJcGFkZHIiKVxu IiwNCj4gPiArCQkgICAgICAgbm9kZSwgbmRfc3RhcnQsIG5kX2VuZCwgbWVtYmxrX25vZGVpZFtp XSwNCj4gDQo+IFBsZWFzZSBsb2cgcHhtIChub3Qgbm9kZSkgaGVyZSBqdXN0IGxpa2UgaXMgZG9u ZSBpbiB0aGUgb3ZlcmxhcCBjYXNlLg0KPiBUaGUgcmVtb3RlIG5vZGUgSUQgd2lsbCB0aGVuIHJl cXVpcmUgY29udmVydGluZyB0byBQWE0sIG9mIGNvdXJzZS4NCj4gDQoNCk9rLCB3aWxsIHVzZSBQ WE0gaGVyZS4gQnV0IEkgaGF2ZSBxdWVzdGlvbiBmb3IgdXBjb21pbmcgY2hhbmdlcywgaWYgd2UN Cm1vdmUgdGhpcyBwYXJ0IG9mIGNvZGUgdG8gY29tbW9uLiBBcyBkZXZpY2UgdHJlZSBOVU1BIGRv ZXNuJ3QgaGF2ZQ0KUFhNIGNvbmNlcHQgKGV2ZW4gSSBjYW4gdXNlIGEgZmFrZSBub2RlX3RvX3B4 bSB0byBkbyAxOjEgbWFwcGluZyksIHNvDQpjYW4gd2Ugc3RpbGwgdXNlIFBYTSBoZXJlPw0KDQo+ IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu May 19 04:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 04:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332619.556340 (Exim 4.92) (envelope-from ) id 1nrXOe-0007nw-9N; Thu, 19 May 2022 04:04:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332619.556340; Thu, 19 May 2022 04:04:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXOe-0007no-66; Thu, 19 May 2022 04:04:20 +0000 Received: by outflank-mailman (input) for mailman id 332619; Thu, 19 May 2022 04:04:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXOc-0007ne-Sk; Thu, 19 May 2022 04:04:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXOc-0002oO-Ep; Thu, 19 May 2022 04:04:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXOc-0005nx-55; Thu, 19 May 2022 04:04:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrXOc-0002iT-4d; Thu, 19 May 2022 04:04:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rngzasRYJlb9f+lQiQd1RKO9NoTVWHciQD/qx/ZQZ20=; b=B87LNNgWa4/IE2iG84A4xi+O8U k9fZV00Opnib8Op22U6GkOGQ8UGUElt3mxvYefEIggue4goHIus0I0spYv0Nrp3AwXjvrig9f5Wk3 E66OihKqTb/84yMXyXobA6fbbuj+X9b43tWiuDwTZe0yzZoF29Fd86zy1xzdcjnjIIdo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170558: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=2189c71026cba9dab768776a2f8ebf689b484c56 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 04:04:18 +0000 flight 170558 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170558/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 2189c71026cba9dab768776a2f8ebf689b484c56 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1093 attempts Testing same since 170557 2022-05-19 03:10:24 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6713 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 04:09:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 04:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332629.556351 (Exim 4.92) (envelope-from ) id 1nrXTa-0008S0-SJ; Thu, 19 May 2022 04:09:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332629.556351; Thu, 19 May 2022 04:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXTa-0008Rt-PL; Thu, 19 May 2022 04:09:26 +0000 Received: by outflank-mailman (input) for mailman id 332629; Thu, 19 May 2022 04:09:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXTZ-0008Rj-6e; Thu, 19 May 2022 04:09:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXTZ-0002ti-3O; Thu, 19 May 2022 04:09:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXTY-0005wW-L3; Thu, 19 May 2022 04:09:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrXTY-00022C-KV; Thu, 19 May 2022 04:09:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ugwDmJnUI7P3P6Y+1E9zUNl/JekA4pjR32cj29z3Cds=; b=eRK21GyQgqKCU8Bf0k2+dKbGDs qwl6TS3p/Wyk7hGDSjE1GTEx6JIJWA+0wE3STnzz2lsbyQ5saF6ooia4Wh9tNQJctaK/mKoua2HJR /WwhjcKVm9FCUUwOhR71HRGv8KH2fOZuFhrpPg6ynF9cpYoQWieO79YXfUWOyu9/IIqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170553: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=43aa3f6e72d340a85d3943b86350f6196a87289c X-Osstest-Versions-That: xen=c8040aefe66edb9a9f9a54cc0541a77b4103c9f9 From: osstest service owner Date: Thu, 19 May 2022 04:09:24 +0000 flight 170553 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170553/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 43aa3f6e72d340a85d3943b86350f6196a87289c baseline version: xen c8040aefe66edb9a9f9a54cc0541a77b4103c9f9 Last test of basis 170543 2022-05-18 15:03:19 Z 0 days Testing same since 170553 2022-05-19 01:03:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Julien Grall Michal Orzel Stefano Stabellini Stefano Stabellini Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c8040aefe6..43aa3f6e72 43aa3f6e72d340a85d3943b86350f6196a87289c -> smoke From xen-devel-bounces@lists.xenproject.org Thu May 19 04:19:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 04:19:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332640.556362 (Exim 4.92) (envelope-from ) id 1nrXcq-0001Xr-V3; Thu, 19 May 2022 04:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332640.556362; Thu, 19 May 2022 04:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXcq-0001Xk-Rz; Thu, 19 May 2022 04:19:00 +0000 Received: by outflank-mailman (input) for mailman id 332640; Thu, 19 May 2022 04:18:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXcp-0001Xa-0O; Thu, 19 May 2022 04:18:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXco-0003Ch-U0; Thu, 19 May 2022 04:18:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrXco-0006At-G5; Thu, 19 May 2022 04:18:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrXco-0006Z3-Fd; Thu, 19 May 2022 04:18:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jKkfWWym1Y9xZmaOUaR6GrqLmyA5Xq4zbDa3zQTMzqM=; b=glE89oAy43Tb1tkBVgg68CabEQ Yct9KvH8jLT13TZPIhKEpI9RGMvZ5qvOA1GbFhc07q2mkg92ItlQ73Zac3wLloJ6cr8EPlTRUcQ1P TQjN/wNgWmszusrXD0WQMsTk+0nIBdk+7jyStBD/rz23QOHyzG21PYl3/fEtdx4kqEFQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170542: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=bcf0a3a422cd5d1b1c3c09c0e161205837dbe131 X-Osstest-Versions-That: qemuu=eec398119fc6911d99412c37af06a6bc27871f85 From: osstest service owner Date: Thu, 19 May 2022 04:18:58 +0000 flight 170542 qemu-mainline real [real] flight 170555 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170542/ http://logs.test-lab.xenproject.org/osstest/logs/170555/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 170555-retest test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 170555-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 170555 like 170499 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 170555 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170499 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170499 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170499 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170499 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170499 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170499 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170499 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu bcf0a3a422cd5d1b1c3c09c0e161205837dbe131 baseline version: qemuu eec398119fc6911d99412c37af06a6bc27871f85 Last test of basis 170499 2022-05-17 03:46:14 Z 2 days Testing same since 170542 2022-05-18 14:39:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Helge Deller Jason Wang Markus Armbruster Phillip Tennen Richard Henderson Vladislav Yaroshchuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git eec398119f..bcf0a3a422 bcf0a3a422cd5d1b1c3c09c0e161205837dbe131 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 19 04:49:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 04:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332650.556372 (Exim 4.92) (envelope-from ) id 1nrY67-0004vH-C0; Thu, 19 May 2022 04:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332650.556372; Thu, 19 May 2022 04:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrY67-0004vA-99; Thu, 19 May 2022 04:49:15 +0000 Received: by outflank-mailman (input) for mailman id 332650; Thu, 19 May 2022 04:49:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrY66-0004v0-Df; Thu, 19 May 2022 04:49:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrY66-0003gM-B5; Thu, 19 May 2022 04:49:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrY66-0006vi-1a; Thu, 19 May 2022 04:49:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrY66-0007jf-1A; Thu, 19 May 2022 04:49:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QNN0SOR8LMLjRStOF5LK3S+SihpiLi+MrZuC9vC+H98=; b=Zg/usH4Ze1jnHWVN55t7qiMZvp A57mw7LAg8vGMwhrtkVgMhq5yhsaF1TUfPmaOGkzcmVUnLGlwAqkhOTRoenf/7AJnVCcE7vaGvMKe 8CzkbNIRimkzCAygmCDc+FuzMJXPlPfugUBijYm9x+GSxFNmaZ62ee8ZCL+RlxBDjhTc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170559: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=2189c71026cba9dab768776a2f8ebf689b484c56 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 04:49:14 +0000 flight 170559 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 2189c71026cba9dab768776a2f8ebf689b484c56 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1094 attempts Testing same since 170557 2022-05-19 03:10:24 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6713 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 05:07:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 05:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332496.556384 (Exim 4.92) (envelope-from ) id 1nrYO0-0007YQ-VG; Thu, 19 May 2022 05:07:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332496.556384; Thu, 19 May 2022 05:07:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrYO0-0007YJ-S2; Thu, 19 May 2022 05:07:44 +0000 Received: by outflank-mailman (input) for mailman id 332496; Wed, 18 May 2022 22:17:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrRys-0003ZW-Pm for xen-devel@lists.xenproject.org; Wed, 18 May 2022 22:17:22 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48919457-d6f8-11ec-837e-e5687231ffcc; Thu, 19 May 2022 00:17:20 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id l20-20020a17090a409400b001dd2a9d555bso3466378pjg.0 for ; Wed, 18 May 2022 15:17:20 -0700 (PDT) Received: from [10.136.13.180] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id ji15-20020a170903324f00b001616e13fccdsm2195161plb.221.2022.05.18.15.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 15:17:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48919457-d6f8-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to; bh=BeMzYKDj0/gubphlSjQZreBctERYtWwyZX2TGXbvLRM=; b=Lzzuusb9kFWDIOc/GDdRDMX+gcF9zI/tyX4kwZLlHuiR7k7ZoyDJyi/B5tFmeDqbhz nh3yU61Je4pK5o3cgPKpmu4Sv2QjxeUuKtghPMaJ77pVKGreRACk7UNhy8S7e8uv2HmW QAFWGF9c8fmfZz/oPl8t0stH4jloxe3sGFk0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to; bh=BeMzYKDj0/gubphlSjQZreBctERYtWwyZX2TGXbvLRM=; b=Ie/tcMnoQvQO5rq9yVjub4xs8Dj3efJohi07k7AIQNZsx9UCciPwI9tubgKEAFliuU HgfBLRttRxGTnpq5aPcWgZFTrgPqn16yhr4/DtzGUItUnEGYPnPrvQmmaximAa5HBwQ/ qoisOX1a5Z+8D1qL84itgqSFdWbcRTgRgU5ON5wa7cWIXtlcVhhdwTtIue5ZGUkyU74G xBBUgXQHwc9uWri3YLFT1MfT9WK+eIEAdKbOAuHS+0Jew547vqAgRsVJs7fy12GOe5A/ yjCAt336X5YNSnA643D1MnTzvHPi8mJoadTjPq2o8okVJ8iO+Vvf4dwT8imtVWIuRIeL QvVA== X-Gm-Message-State: AOAM530KpoR+9Jnh6lWBBNZ2CiwbtQ2QJjQVNg6dHKMjYXn3f9ab1Xvz AAN4DnmiWYy1sgeZUPzanUeuqA== X-Google-Smtp-Source: ABdhPJxkLsE36Kq2JcCUoiWV2ClSYG7H68DZOk0Dnd5ufVpjZfzcSk9Zz5AbXiW59SdIpTBHz/LAmw== X-Received: by 2002:a17:902:ec92:b0:161:7e29:6f9d with SMTP id x18-20020a170902ec9200b001617e296f9dmr1458536plg.157.1652912238747; Wed, 18 May 2022 15:17:18 -0700 (PDT) Message-ID: <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> Date: Wed, 18 May 2022 15:17:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list To: "Guilherme G. Piccoli" , Petr Mladek , Sebastian Reichel , Florian Fainelli , Desmond yan Cc: David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: Scott Branden In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000e0603605df509e06" --000000000000e0603605df509e06 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Guilherme, +Desmond On 2022-05-17 09:42, Guilherme G. Piccoli wrote: > On 17/05/2022 10:57, Petr Mladek wrote: >> [...] >>>>> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c >>>>> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c >>>>> @@ -1446,7 +1446,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) >>>> [... snip ...] >>>> It seems to reset some hardware or so. IMHO, it should go into the >>>> pre-reboot list. >>> >>> Mixed feelings here, I'm looping Broadcom maintainers to comment. >>> (CC Scott and Broadcom list) >>> >>> I'm afraid it breaks kdump if this device is not reset beforehand - it's >>> a doorbell write, so not high risk I think... >>> >>> But in case the not-reset device can be probed normally in kdump kernel, >>> then I'm fine in moving this to the reboot list! I don't have the HW to >>> test myself. >> >> Good question. Well, it if has to be called before kdump then >> even "hypervisor" list is a wrong place because is not always >> called before kdump. > > Agreed! I'll defer that to Scott and Broadcom folks to comment. > If it's not strictly necessary, I'll happily move it to the reboot list. > > If necessary, we could use the machine_crash_kexec() approach, but we'll > fall into the case arm64 doesn't support it and I'm not sure if this > device is available for arm - again a question for the maintainers. We register to the panic notifier so that we can kill the VK card ASAP to stop DMAing things over to the host side. If it is not notified then memory may not be frozen when kdump is occurring. Notifying the card on panic is also needed to allow for any type of reset to occur. So, the only thing preventing moving the notifier later is the chance that memory is modified while kdump is occurring. Or, if DMA is disabled before kdump already then this wouldn't be an issue and the notification to the card (to allow for clean resets) can be done later. > > >> [...] >>>>> --- a/drivers/power/reset/ltc2952-poweroff.c >>>>> +++ b/drivers/power/reset/ltc2952-poweroff.c >>> [...] >>> This is setting a variable only, and once it's set (data->kernel_panic >>> is the bool's name), it just bails out the IRQ handler and a timer >>> setting - this timer seems kinda tricky, so bailing out ASAP makes sense >>> IMHO. >> >> IMHO, the timer informs the hardware that the system is still alive >> in the middle of panic(). If the timer is not working then the >> hardware (chip) will think that the system frozen in panic() >> and will power off the system. See the comments in >> drivers/power/reset/ltc2952-poweroff.c: >> [.... snip ...] >> IMHO, we really have to keep it alive until we reach the reboot stage. >> >> Another question is how it actually works when the interrupts are >> disabled during panic() and the timer callbacks are not handled. > > Agreed here! Guess I can move this one the reboot list, fine by me. > Unless PM folks think otherwise. > > >> [...] >>> Disagree here, I'm CCing Florian for information. >>> >>> This notifier preserves RAM so it's *very interesting* if we have >>> kmsg_dump() for example, but maybe might be also relevant in case kdump >>> kernel is configured to store something in a persistent RAM (then, >>> without this notifier, after kdump reboots the system data would be lost). >> >> I see. It is actually similar problem as with >> drivers/firmware/google/gsmi.c. >> >> I does similar things like kmsg_dump() so it should be called in >> the same location (after info notifier list and before kdump). >> >> A solution might be to put it at these notifiers at the very >> end of the "info" list or make extra "dump" notifier list. > > Here I still disagree. I've commented in the other response thread > (about Google gsmi) about the semantics of the hypervisor list, but > again: this list should contain callbacks that > > (a) Should run early, _by default_ before a kdump; > (b) Communicate with the firmware/hypervisor in a "low-risk" way; > > Imagine a scenario where users configure kdump kernel to save something > in a persistent form in DRAM - it'd be like a late pstore, in the next > kernel. This callback enables that, it's meant to inform FW "hey, panic > happened, please from now on don't clear the RAM in the next FW-reboot". > I don't see a reason to postpone that - let's see if the maintainers > have an opinion. > > Cheers, > > > Guilherme --000000000000e0603605df509e06 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDH2hdImkqeI7h1IaTzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDA5MDJaFw0yMjA5MjIxNDMxMTRaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVNjb3R0IEJyYW5kZW4xKTAnBgkqhkiG9w0B CQEWGnNjb3R0LmJyYW5kZW5AYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAtKitgySOPXrCfmgJJ/6N4Bq2PYQ9C7pbBbEOgcLdGZyOHK9MJW3fcf8NXplv3OfFCQzp rm9QWjKvH806lCzDhSKgAg+vro9Alv6BTl7wBdSVpgFsV/Tl+kbDfeBxjE/AwOW+WNGIPJLH4WCo MMkaRzH4Lg/8h9DnzxR46++4CqLY4KQQ151a+4Ojb/u/YlVGYlZa/jmTEgk3It8dzv54hZ/UoZg1 cRe0CRXA7ypOJSgxO/nOOyQoaJxT7CGg1npOeSpPjEuc3fE4xum3l0nvU85hj6MlKZu43hokdBh0 D0nLyyhEwlR3AC/msdff/UGbM/JR9vk812RP4m/aNWZFJwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUOhjEpl04Sz9dh5MI82E1 V39lM/owDQYJKoZIhvcNAQELBQADggEBAA7Rlypx/esz/iq1yA4+KW7uwV/aBY344BWcXt6I+SNK VwFBgFWfLj5vaEud9TVv2fPSiaHJo0umemOJk+43QD+bsoqmgcFXd21PrOt7Jjs+jjVED9VC5kJq S4NNKUkS+BqijJwSegtVygrc/atrIlJbjI21q4qpemUo5fgwqCNm++BmBGTI8yA09vtGSNDRN42k lLX9hl3iEj5SBgkQqCbbnoE+ZjjKfqt7ED166WhgyQWNrl39yLcvLj+JRUB3RuvXKZjH0NQEEBII wZBDSkyneykLt3CBNIhSCTxKM6OWxVp936ALSa5K9FNy00TeWSpokR6NmzaW8VD/EjTgvqAxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgx9oXSJpKniO4dS Gk8wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIILFBbO32At0jlQYmvDlBzxxKfke QfIJzMrdu2nIpFihMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIy MDUxODIyMTcxOVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQBIc7nOZb/W3CkCvD0kf3LJMsgwBiUyTBcOQHeudvIMXgiB QQ8+U0c03geY7pr3oC9UDTjRSIF1RwJcP3BwheBLJu7kfHK3jy1JiouqgOLb3cV+n/v8R/+Xc+Q9 MlWFHGJrAD9gPOMrvJ1KMqx0CFXaz0l8rlyXDGV6s+r8X1jt1rnbjZIGoBbGOP0+bObjxE+1Gdyd bQJRFfYVGChsqzAPm+mOmOBOafJhgclqEhJSTDfXRiL12HGLyzWipIAmcAo0FrSMyjIkYTvnPG2n n3uZVbKScFO51F6GoCOYWwE5SK0CHfHOWXk8TRl9CTBHlWCZR0XRAfCmijeVCq6/xT0J --000000000000e0603605df509e06-- From xen-devel-bounces@lists.xenproject.org Thu May 19 06:03:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:03:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332668.556395 (Exim 4.92) (envelope-from ) id 1nrZG1-00057T-Ac; Thu, 19 May 2022 06:03:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332668.556395; Thu, 19 May 2022 06:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZG1-00057M-7p; Thu, 19 May 2022 06:03:33 +0000 Received: by outflank-mailman (input) for mailman id 332668; Thu, 19 May 2022 06:03:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZG0-00057D-12 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:03:32 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6875b67f-d739-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 08:03:30 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id w14so7223561lfl.13 for ; Wed, 18 May 2022 23:03:30 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id z9-20020ac25de9000000b0047255d211b3sm159674lfq.226.2022.05.18.23.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 23:03:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6875b67f-d739-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=X+iyqLf77Krjb4QH3xlKBzqBdXBeBxfWT5vFT9hWB/E=; b=jMiIn+oPqAbUSnsl0S1EqWOpvRnIcpeNMiwZI6oyIi8xhmBfbS0iXSTPrI9fRM0yK3 shzE8bDkGkYA9EhOOUX0QU0wLP4QQoFJglzVWFRGUFihYkHMmO4E6qMuMAwRmBE3Fb29 LEbCqY6aee+/3T+wPLd3RffpjN6/xgG291hMA+v9JF2TUTVdVeWsT6J6ofyyeD01qlKm fBBHfR1YeYk1vyGq0IXKTNfhaswYcqCTmShveU5CSbuNb0b2uKBm9D5eUMnaLKaogBcO IVdN60uPvVqB2IVOgavpFDPsgOrh/GOMGkUwu0zXQ//s/G6C/9uX5K58kzqdB8e9hAMB XgEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=X+iyqLf77Krjb4QH3xlKBzqBdXBeBxfWT5vFT9hWB/E=; b=37svC6MBkLBacZyqwyAV98P0JaQ7A4xBnBfelehSg8EgACpqlFOTiUEg+2t8yZN36L KpUkdw5ng0eyz72RrNyD3TiNwa268D+Vn+zmtH8cwr1pdE86xbbwg50mKJtmLAKWflJN QdpXDi622uqOLi8KYsBDzca/afiOY9A6h1Wh+xKbSz8SavVg4BvnIU4F+Nz84JjFwj4C ebHLuK7335+nnWTE0P3JbpkMz8vLzb6BPkQX1YEh5JS7WfdQSBhMGOUoA7ZXQpiV8ajF XIDZ3CadPFT2va7JcEexLpXtrXqCqIO0U9QSxonS/9NRXFZMSWOQEodHghxwuf1GhivF HCFg== X-Gm-Message-State: AOAM5300HcR0xYPTkRNLEikgj1ygPYNuWlQyrgQdI6lS0/qxUxyXhfug 99kjC1+e2Ss+f2+eFw3qKY4= X-Google-Smtp-Source: ABdhPJzwmwkFDCRWW2Cad13XCWqyTTIZvwGLTYnv5Wt5Re5HVYbl0W10atfcLup8GeN/5VWUJmeMMg== X-Received: by 2002:a05:6512:ace:b0:473:ba5b:8e06 with SMTP id n14-20020a0565120ace00b00473ba5b8e06mr2114663lfu.614.1652940210293; Wed, 18 May 2022 23:03:30 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Stefano Stabellini Cc: Arnd Bergmann , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> From: Oleksandr Message-ID: <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> Date: Thu, 19 May 2022 09:03:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 19.05.22 04:06, Stefano Stabellini wrote: Hello Stefano > On Thu, 19 May 2022, Oleksandr wrote: >>> On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: >>>> On 18.05.22 17:32, Arnd Bergmann wrote: >>>>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko >>>>> wrote: >>>>> This would mean having a device >>>>> node for the grant-table mechanism that can be referred to using the >>>>> 'iommus' >>>>> phandle property, with the domid as an additional argument. >>>> I assume, you are speaking about something like the following? >>>> >>>> >>>> xen_dummy_iommu { >>>> compatible = "xen,dummy-iommu"; >>>> #iommu-cells = <1>; >>>> }; >>>> >>>> virtio@3000 { >>>> compatible = "virtio,mmio"; >>>> reg = <0x3000 0x100>; >>>> interrupts = <41>; >>>> >>>> /* The device is located in Xen domain with ID 1 */ >>>> iommus = <&xen_dummy_iommu 1>; >>>> }; >>> Right, that's that's the idea, >> thank you for the confirmation >> >> >> >>> except I would not call it a 'dummy'. >>> From the perspective of the DT, this behaves just like an IOMMU, >>> even if the exact mechanism is different from most hardware IOMMU >>> implementations. >> well, agree >> >> >>>>> It does not quite fit the model that Linux currently uses for iommus, >>>>> as that has an allocator for dma_addr_t space >>>> yes (# 3/7 adds grant-table based allocator) >>>> >>>> >>>>> , but it would think it's >>>>> conceptually close enough that it makes sense for the binding. >>>> Interesting idea. I am wondering, do we need an extra actions for this >>>> to work in Linux guest (dummy IOMMU driver, etc)? >>> It depends on how closely the guest implementation can be made to >>> resemble a normal iommu. If you do allocate dma_addr_t addresses, >>> it may actually be close enough that you can just turn the grant-table >>> code into a normal iommu driver and change nothing else. >> Unfortunately, I failed to find a way how use grant references at the >> iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I am >> not too familiar with that, so what is written below might be wrong or at >> least not precise. >> >> The normal IOMMU driver in Linux doesn’t allocate DMA addresses by itself, it >> just maps (IOVA-PA) what was requested to be mapped by the upper layer. The >> DMA address allocation is done by the upper layer (DMA-IOMMU which is the glue >> layer between DMA API and IOMMU API allocates IOVA for PA?). But, all what we >> need here is just to allocate our specific grant-table based DMA addresses >> (DMA address = grant reference + offset in the page), so let’s say we need an >> entity to take a physical address as parameter and return a DMA address (what >> actually commit #3/7 is doing), and that’s all. So working at the dma_ops >> layer we get exactly what we need, with the minimal changes to guest >> infrastructure. In our case the Xen itself acts as an IOMMU. >> >> Assuming that we want to reuse the IOMMU infrastructure somehow for our needs. >> I think, in that case we will likely need to introduce a new specific IOVA >> allocator (alongside with a generic one) to be hooked up by the DMA-IOMMU >> layer if we run on top of Xen. But, even having the specific IOVA allocator to >> return what we indeed need (DMA address = grant reference + offset in the >> page) we will still need the specific minimal required IOMMU driver to be >> present in the system anyway in order to track the mappings(?) and do nothing >> with them, returning a success (this specific IOMMU driver should have all >> mandatory callbacks implemented). >> >> I completely agree, it would be really nice to reuse generic IOMMU bindings >> rather than introducing Xen specific property if what we are trying to >> implement in current patch series fits in the usage of "iommus" in Linux >> more-less. But, if we will have to add more complexity/more components to the >> code for the sake of reusing device tree binding, this raises a question >> whether that’s worthwhile. >> >> Or I really missed something? > I think Arnd was primarily suggesting to reuse the IOMMU Device Tree > bindings, not necessarily the IOMMU drivers framework in Linux (although > that would be an added bonus.) > > I know from previous discussions with you that making the grant table > fit in the existing IOMMU drivers model is difficult, but just reusing > the Device Tree bindings seems feasible? I started experimenting with that. As wrote in a separate email, I got a deferred probe timeout, after inserting required nodes into guest device tree, which seems to be a consequence of the unavailability of IOMMU, I will continue to investigate this question. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 19 06:04:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332672.556406 (Exim 4.92) (envelope-from ) id 1nrZGV-0005ay-LW; Thu, 19 May 2022 06:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332672.556406; Thu, 19 May 2022 06:04:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZGV-0005ar-Gh; Thu, 19 May 2022 06:04:03 +0000 Received: by outflank-mailman (input) for mailman id 332672; Thu, 19 May 2022 06:04:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZGT-00057D-U3 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:04:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a5e67d7-d739-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 08:04:01 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-54LQB2xTN7WNxLYSVqQ4hA-1; Thu, 19 May 2022 08:03:57 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8793.eurprd04.prod.outlook.com (2603:10a6:20b:408::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 06:03:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 06:03:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a5e67d7-d739-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652940240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQDBXjQYRnn9HMUzgtpNDzSU3AqMyCnMlbhx5IzLiA0=; b=SFDrgHqdZ4q0556pr64DHYY15fbVZnhnxrRJMH2mmhfPVxHG1eZpCflVZG4MenKt3wUPOv Bm0SaiyXZbBKc6hnBBZgINSa1QY7ROpL1D2xZ9CMblQUb3Yagvm3lEtS8x2MY6r2PXGvIe THDPaIbsk4yVrBp0rNztfnxmemK9hAU= X-MC-Unique: 54LQB2xTN7WNxLYSVqQ4hA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LH6X5j15PzAzLVIzSUmkkdAZKOu5Exve+AtJy05a+TGJoIrX4zJsRw5rMN4OUmSQPKc8oJsE+9P7tC65KF9ubCD210rtf1CQHF690lNMx5o5Uy5eKSGzwLhqed8Wujig+omQGcysxXjs/q7B/J9SFP0l8NqtuDz23W23izznwOgXFeKVCLuF8og5w12f5/W4GnYpLvlaVdd2u+roBIMSU7JbElj1hwGWSV9hgBRA2xq7RFDx3Jafv2hQfKqnCPOQIKy2TPEyRAeAtJAS+BL/19HBt/nThG+9XaJu0XMbAXO2Jh1udF/724wsAQuMZgUhGT3RszsDTpATs1Gv5rUQKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBttHXc9Bah/LeexF21QC1EdU+43Kka3upiCyrlpYO4=; b=nXzREZfDozzunRhruFNm5C0HC5oU3Uhmb4jdml1CdX8q0hXtvWRgdE7jElQaIi8xnIE1YGUiIhwJ1i7/gDurIrQrN5UzBIkl+OWAI1Rrkeb4mQLMrvbTjTeu5Zncj0WLVh2nLCHc9TmilmzTzjGSKZrWcEf3At3fAMOmwqx5o52FBuVeGeXYb9yM9YVSdqg1VxOYS/Th/6rEVWycI7QT3vzzUfd6GOoPgU+ieMCu7+LB/ttw9jJ24q+rkhfO/p8jQVMb9fsdRIOSHo0Ki+9C49pofl6R7Qm3e8/xIXbVS5wk0eLz0UiN5dpCd76dHDgysUKLhrxgSYsWYahPdEfBrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 19 May 2022 08:03:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/3] tools/libxc: change xc_memshr_fork_reset API to match hypervisor Content-Language: en-US To: Tamas K Lengyel CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Juergen Gross , Anthony PERARD , Wei Liu References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0169.eurprd04.prod.outlook.com (2603:10a6:20b:530::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52f3b390-6789-4987-bf40-08da395d5af8 X-MS-TrafficTypeDiagnostic: AM9PR04MB8793:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gCEa0cj9VknMUjfeWnpDGQSuA957okZxyXV052KuFlee5s8TAujkarWQOJM9eV5CkJXFH2rIaLwLPARbjZih8HqC8OVI8VU3vJzrBY2VGFdHefCj3UKU1Jh6HWWcIFaVK6rjM2ZUr2pobDu+C37HAmTnlW77wBXhpn6tmzrDWt0uxzXZEMryDnwXqCn57ei51xTXk406DJ+sf+Mprd4r0Mr4Vd7K9y0RsVbKIl4G/C9wQYyMzYr+AACtMtT55ba/RNhqUubWf28Y8P6M+vZPQaJsblOUF3B+gKr5N9rwqYUG39jTBwchzGLqwTvX0MZzdADnZrKE2T96MpoyNigEkV0wdV/0JEwXdNJUgZyTp+1uiik+NTZhmeRjH6J6o0O74rlSGDUHXAmZH2oT01Gn62ivFe6tD/1xFPPvTL5aRpTc8JuTg9BHmxIwH5Dskvfl6PeojrgZWORaE8j91OyMGRCWJ7m2l7oc7Qo89NftQIt9FVwAILoR9x3Zmi7ZIwhZCQLm+0+8sffPbBuk+QMHUgBZ5R8FldzkpkJEctlLrBBjwSVyfBBGWvTxBYFr+telfrlRfVARP0GAKiElACfwuqyzhT8ThunGJAAAbzAZI3NKlPa5ghifSYwBCy9u2CgKHiT2DwpjvFkeOx+yvKCgAETc5tgeSpR6dUwzAYPTkY54XDO7uCylRCOgjeLPV/rxZA2kk/y10Ga4vWQtg+8WLVz+qaM6gzm9yPW93QXPpdlpti3TJUHHTeYlXwgubblh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(86362001)(31696002)(53546011)(31686004)(36756003)(186003)(2906002)(6506007)(316002)(8676002)(4326008)(66946007)(6916009)(54906003)(66556008)(66476007)(6486002)(5660300002)(38100700002)(8936002)(2616005)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cqUostkoR14WlHLhh/A7EAYtRbKi0evQNLghgHrUrbCZO62AO4CgwXttRK+l?= =?us-ascii?Q?O4NTtUAX2ThPrVwiLr4z7TBeDWvH/BxJFy3kXU0a5ptk7fyIsXt7VKn6oKzx?= =?us-ascii?Q?KcTNZXpbdeF84YUcBo3QyzayzL7MCJZu6wuIRfGj6uZGwtuSuq+QEyBlknM5?= =?us-ascii?Q?DoxRTa9fKnjrpoP6Jl9Jt/kUuSEDNpe9U5zYW1ac7xp60/huikRwqjwkesNk?= =?us-ascii?Q?JITc8CWaLjNlvHbUjqGtcn5TDbsWIEWqajfynitLE75zrigB6V9idaAmOqqV?= =?us-ascii?Q?p5+tAQXf+5no9cWv+gGqix8ZDP0lTiRdzeiAPkz9kwhIW5CIWGeyvFtQQgLG?= =?us-ascii?Q?de+PE6ynjuQwfkrMAwwJZgXnD8TS1aHIGhuMWA6DgNs/Y+rXcLMbMcyPi1dS?= =?us-ascii?Q?ywL0E4TXnzkFvGdStatOBgAtTw035XJ724n1+5Tgzt43MEIkJTl8FrnWT05k?= =?us-ascii?Q?Hvo2RSJncjNvDH0uggWjU8OUFbS6y4h5MCvIMHfQ3D3AiiIWA0XY0jBGlwTG?= =?us-ascii?Q?iF3skizQncEAD5FIFljyD9/D0fKixkCxyE7+4lOFAPJloEuGWwNIrVw3NUkv?= =?us-ascii?Q?R/BezWYEGi26p91phXbQkm32g61z9NpPbiOGQePvzPd3LAbWkhOQnxjQQp5t?= =?us-ascii?Q?JQcKrWMVMa3d9FeFQ68jahm/0rZK4HIlTp2o1qfMP3zvZHbR9/thrHkqbiIL?= =?us-ascii?Q?rhR0Wt2wY2juJQYrSK4WMbCCa3lXC9TkG6CXb8aXZwcJfo4LmX8rF+nO5A3E?= =?us-ascii?Q?0r4a/j7AL3kpC98H4ewuTElYZNZQrrZps40ggenxgCSm2SQtUw9hnCMBTRyw?= =?us-ascii?Q?iFU7DoCMHG0QIWR5094+KQzw4D1Pi5Fgj2cHXXgDp0GnyrVtjjYZ8yhoW23N?= =?us-ascii?Q?zHNDigjJqWjwhOczoq+BT0KocfAR6E03NHGOBcyyMW4ke/mOiNso38YCfwwU?= =?us-ascii?Q?HwkPZ/t/U7tPvloaZtccdz+UMAZFsgmAD+nNmSygPAaSkC6BHSJz0EEUkvIU?= =?us-ascii?Q?7LRVtaSVNGOj/09K/d/q/hFRMPWOigjI3Gsp0K3F37p6N6ptg2KqNqhRsJW/?= =?us-ascii?Q?ncCMPwgs709Slb6kVV/VMs4vrKPC9RbWqeuqgO04Wmzk+Rt3s1zw8gtsp3Gt?= =?us-ascii?Q?x3u4JKLoTJMcrtcv86lVShVzlg166rmA30iAI18bmbv37NUreIzkH46hpVsW?= =?us-ascii?Q?0fOZRC3jPUYs5yTdSTwbRNzTIRzaY1NGLFdyr5rH0Yw+7GBUXwQuafjRxkGf?= =?us-ascii?Q?ZdgCeXZBRtaQ6CHAgpk9Lyx4TwLe4aTIMATGSmC948MZ/9GidATXSQKO8OWq?= =?us-ascii?Q?ZbCgMOZXhuKN1wjxsNzpTFD1dUBs01reljIGzYwLXE3/ezi80WBhaOr2TGzl?= =?us-ascii?Q?KbwLIRCMqNHODiuVxF7ddQiVDB9FbZgTg/gwXvnh6Y/rOJHSUsce0OmdZVsm?= =?us-ascii?Q?VFe2+hH8GyKeCfIOgdW9xe2H5F8j5p25WHbQrKmA3sMXDg4YHND5PhPsN2ND?= =?us-ascii?Q?21ShOnbRoTvauWwaHcN1WVVnF+pV7vjSb2KaLcu16mgNrMtf7w9UQZaVAh0q?= =?us-ascii?Q?1bfX+HPezweivix7ykHC5mCfh6Pjd/h70lKTjPf5l8n27uyZhKbWY8H/4HvF?= =?us-ascii?Q?JyHntgZoNdUCuZFvdCfb1u7bK8KtwtHd7zINwyjzJFYovgIg8PjUGofu1Nmd?= =?us-ascii?Q?bHH/yyLW5MbOe72ZBVgse8qSm5UUzWaDY0kTE0vqlIbJf5gL4/vFFxlwDn8J?= =?us-ascii?Q?iL9SB/FpyQdlqeBgRyyCquR65/c8jWgufY7XLEdmq15Mj2Wc4zHgh+eLIPbC?= X-MS-Exchange-AntiSpam-MessageData-1: EGCgTvIIAHPNBg== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52f3b390-6789-4987-bf40-08da395d5af8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:03:54.9058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GFztfleDbSIq2HcQCyrcaH9FPQoeIRRtYVfqacSNsRZA8uX1Y1gzgJXpiWrqNz/sYpXD887NALflgHXFK8zUnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8793 On 18.05.2022 19:03, Tamas K Lengyel wrote: > On Wed, May 18, 2022 at 11:48 AM Jan Beulich wrote: >> >> On 18.05.2022 17:01, Tamas K Lengyel wrote: >>> On Thu, May 12, 2022 at 9:46 AM Tamas K Lengyel >>> wrote: >>>> >>>> On Thu, May 5, 2022 at 4:27 AM Roger Pau Monn=C3=A9 wrote: >>>>> >>>>> On Wed, Apr 27, 2022 at 11:34:19AM -0400, Tamas K Lengyel wrote: >>>>>> Need to separately specify if the reset is for the memory or for the= VM state, >>>>>> or both. >>>>>> >>>>>> Signed-off-by: Tamas K Lengyel >>>>> >>>>> Reviewed-by: Roger Pau Monn=C3=A9 >>>> >>>> Patch ping. Can this patch be merged please? >>> >>> Patch ping. >> >> Your mail (and I guess also your earlier one) was _To_ Roger, which >> is odd since he already did provide R-b. What you're missing is a >> tool stack maintainer ack aiui, so it may help if you send your >> pings _To_ the respective people. >=20 > True, but all the toolstack maintainers have been CC-d from the start. > Is it the case that CC-ing is now officially insufficient? No - patch submissions should still only Cc maintainers. But I think pings, especially repeated ones, would better go To the respective people. (And this follows my general remark I keep making every once in a while: There's a reason there is both To and Cc, and using them appropriately can help. Of course there's no guarantee, as people may not pay attention at all.) > What's the > point of ./scripts/add_maintainers.pl then which specifically adds > maintainers only as CC? How are you supposed to get their attention? > Just know you specifically have to send emails to them and not the > mailinglist? I'm getting the distinct impression that the toolstack > side has simply become unmaintained/orphaned with no one left who > actually is looking at the mailinglist. While things are far from ideal (and as you likely know we're still looking for a 2nd tool stack maintainer), I have actually got the impression that things have improved a little lately. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 06:11:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332684.556417 (Exim 4.92) (envelope-from ) id 1nrZNu-0007Ch-Dn; Thu, 19 May 2022 06:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332684.556417; Thu, 19 May 2022 06:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZNu-0007Ca-Aq; Thu, 19 May 2022 06:11:42 +0000 Received: by outflank-mailman (input) for mailman id 332684; Thu, 19 May 2022 06:11:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZNt-0007CU-IR for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:11:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8be2db0a-d73a-11ec-837e-e5687231ffcc; Thu, 19 May 2022 08:11:39 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2169.outbound.protection.outlook.com [104.47.51.169]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-EtcjoTyPMx2aMJ2XParChw-1; Thu, 19 May 2022 08:11:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4337.eurprd04.prod.outlook.com (2603:10a6:208:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 06:11:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 06:11:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8be2db0a-d73a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652940699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cd4Ah2Scrigf4LFW8YJUKbewQGKuVS2B66rI6GYXFGE=; b=jEQrxNHcWuB8O+5AuGoKL57Vi4LmvZNWq8ymeMYYupJOK9FBLgIFXEIrkpjLobiNbRxjB8 iCLs2ax+IT7U0YnUKefcauTUS6eD7TLbcltisX0F3t5t9nL4SaWEuz88trAS6PjzAyb9jx 9SZS4fFj6AHIqIH+LRGFuDp8GVIC5H4= X-MC-Unique: EtcjoTyPMx2aMJ2XParChw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LRClkG9ZGoDsvIlJ92oIznEFJytMI51GbDQWreZqoVYP7B9+SixAA0Fi+r3JV5/34xH7meqfPoyj3/jSkPyjBwmaWmD0MofXuq409vfgjbi3P1kvQHhUq+GNULhemoex8xvMPJztsnSrKQev+PzbFpN/RXihxGZZGhP8Bt1b0xsKNLv7L1rYBsBN84QI1pEjWjc+/qcqc0tYEwjbbxePUXxnmEWuAeRvwaHN3pMeVjVN2aiDyI8vCqMzgdK/KrBCNvnhxnj12+MN3f5TkWYZz9pDT2feIaGXNo3ukSuJz1J2EvStwHlgpypjh7d5mROmSGIXs1sn+QpizJpx308lXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n9g4H5kUoLSt+qDobNssArVwpovkB4TocAvlBiAehkU=; b=Cz9nvzmmCToFqTFJZqLdB3ghkJSh5tQOg8ODGSgVlNro1CU2nRBZ2qsv6T7E8wsJDYZBZe0BBOonFEzEhATl+FGhk8YStDxcLt5cn4QJhiKbbT+XtCBADzwoHKupyv1uZY+rsUnfiE6Yd+NcuZQG2SCELnjq9vsDVR5ceq+E5CqBFGlIsO8i99HnJ0VWngXbBTWPhM93rc20LwXPCMW4a32Ak5Kaar0peojPxbhP3sjPX+5ZV2qW53I541RHZ+tAutVt0FoDEC4MTi2O5cDg38/ERAvwhbGXC2xcmxoakNQTTInHY/gzVrKI5i1djh4prBwlrM41TpBlDozKo5at/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5af0fe8b-12fe-f7dc-0fa4-20c5e395c268@suse.com> Date: Thu, 19 May 2022 08:11:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US To: Wei Chen CC: nd , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Bertrand Marquis References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P192CA0090.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51e4e16a-c9ce-4405-c99c-08da395e6db8 X-MS-TrafficTypeDiagnostic: AM0PR04MB4337:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IwPZrvJPz4PowQWDHeS0T1+FsXv77t6f3/ac0d0skFkr9vxXyqeweiaqxWbMFsJZqQO0mkSi2mkQyKzrvtLLsYcWJm2NsmQKD/MC5tYK7xYVXpjfulvTC7pu8YFXz+dHYT6OqOEYwY3eJ6ahhVw+b+4zklc2bnNIJW8mz6CptYcBUiC/7KCuJD2bRtV/TC+tQsA+NY6e7sESKLHjjjLVdiVWBKAvAP1d0+kstVj3QnMC45287PkjheVhEhjgd4tR1xwfuYjtD15eafoGkqOtSld5qYwNZsR59Ki7lQJF119koOueRO5MnP6iTQJOn5uY7fsi6QG6HbcMehlsD72Cu2Fw0+tzsHj6B6gv1WZqCD4F66oKpkLgxfcaEPWoD2IdU/2Mbs73RomZBtP1N9wtKZ55G6P9uGroBmWj8jHNkria07b8guA4vTB/4k0xZm74FTxZtNp1sMEM38PvLggFaGpvxR+nlamq9FU4g6XShS5Ouw+rxtIdj9GT8u58/2mBPEefnbpPwdFhLSBKXeUBOB/a3WICEvn8n1CBsUPTiwUxvNe6yXLMXCmg9schSZhx+/JBMJsLPRDITWdVscJGqsZHZX9O/asDRy/FI0tlsQxUzhbXENc1m6z0BYBqd6fwwtSZjLDXgQS23bPf80H/sNn2H83ux66ny9QDmM7O9PvsR8Iyw8ZjWCmzU0+EAWOBE5mFo6GUIQMSGlqlY2ewgU8wBW2RId7kjCm9H2FlEB+VZJgnUh5Jg/16ydQccfwR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(6916009)(54906003)(66946007)(86362001)(66556008)(8936002)(31696002)(316002)(2616005)(4326008)(53546011)(6512007)(6506007)(6486002)(38100700002)(508600001)(31686004)(2906002)(83380400001)(36756003)(186003)(7416002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xP2vKrkypfRqrUjJusWO5aVgl1Vtej3T1diBG4iQLj4QTrKSuziuKqaqnoMq?= =?us-ascii?Q?zXn8Fq4SEmmCkynE0xgPLVwccxhdcri6tG5r/ID1rVRhfCuW1w1ku59T45/x?= =?us-ascii?Q?SXAZUjSwPjzkvvJudMmxm/xBHLdL9yi76NDrZJzvW9+sz5B3XPNDsYGmqE45?= =?us-ascii?Q?Le8XIql4X07RY9QsbIRIzxE5A8kv5bb4mj7EwLM/IaBvb9ecNAw0mMWlHnzi?= =?us-ascii?Q?CW8z3QO2ixmV9af7lAmVOCP1PO07FVBh1DPIVbsmQ7JsdR9LP0j+HueeGXgT?= =?us-ascii?Q?afO+fKGrze49pT8ll/etgy8QglFYWe7dKXRcj4rEnaLFVBsD+kBukX6N/Hpm?= =?us-ascii?Q?B7vvTq/H+RnnNcDcRY4xz3PSqn6QHn7Znk2irSz83X+haQtgrzD4hWuvuqJS?= =?us-ascii?Q?V/RVmH+kfmYCLdkSp//oYFVR3xDHVBq0DwtzWb3kKcvyNC14IBWIAraVu2j7?= =?us-ascii?Q?iuVD0f2DrZ0F+YUApOmsqC5zWYvkT9Ysj0+auxV8wi8nPuZ0unOuud6lRYLZ?= =?us-ascii?Q?eehtnCmbAiQUsTdxhVKBjFOR8oaL6hji8j1KIavY1unYQEuC7RBjmhKXpcKv?= =?us-ascii?Q?f+JL27QHBAhkxyrZXS+9MzJvZdZxmdC+yAv3Ur2yQh+zvugLTUjukCvNs292?= =?us-ascii?Q?cFzWk0xiEG/fRlDguCyGgUcXKlOehgIn4KkTHcdYza9CQ/4TkKjUpzC/bJpY?= =?us-ascii?Q?dG2GPtyvI5BLBxOcwqCc4RdwHXiu3s+WSJMCxzn/6wfI7PO2aaSjVzSzwqWX?= =?us-ascii?Q?qzJcdKCNiTiT3ju1A4dhu74mzZebUgOelEIB8Tv/DcV48IDUdY0MoOz1U7WJ?= =?us-ascii?Q?001PzlzlhTsmrOWMjbsynvW3kmB+sDC0wehxlWxl3j1sXO0tf5nNVVrd/xBf?= =?us-ascii?Q?eRJmqap+sApxyUzfD6sTHxkMmj3Dp6ia2dEmrqnRotsLwnhVzHe010+O6xDk?= =?us-ascii?Q?MCQIoXm7FoPF2LtQ1Om99L0Y7D+6ucbBRNDxhZE3d627v7CATcCjnMTsrNoI?= =?us-ascii?Q?HGXJu42YmnoFWFLPFRlZol/HtGD7JlMhQvXsQT93DkAqlJ0yIBG2V/IJAsL/?= =?us-ascii?Q?oqfm7ndatwusMQ69uXkKoe2tvRQDzS8nhwSMzFz2eJM0mteSLULR/byMTjaG?= =?us-ascii?Q?FOPRLbXATEXm++DMBdzMLgOEJr6XxYMJEbvwIkN4TR2Y6Jp3BFAGFaZZb35Z?= =?us-ascii?Q?c5Sf//YhXM+HMGX4Ok9QAbLG8hUiXviki8GD8QtTiv14K2IwnSwK28/M4ib5?= =?us-ascii?Q?a0hURcoesqUePTslPV1NonZR5cYFgVLZRly5Mc1EwGD70/Msjt1PTFSDZcBs?= =?us-ascii?Q?rpM14/rSgzsk2Ge2PN+Qul9piln0C0ZTDjqBh5sYYOGh0aNFp9Y7Y1OvGcPN?= =?us-ascii?Q?2ScPxui2Au9fdjiXjzCes2aeDWctWiVHxTBaeRAz2wxgsm7UPIEfsHA9J9PP?= =?us-ascii?Q?x1DGuFedeZxvKyJg5TMpfWNlrRvnPHMoSfau96wzfg2SbYM7/epdbtk3zaA3?= =?us-ascii?Q?/hvNxQ80UBsQWA+0QDZ+UllimEdMmZseLFFaLOdwSPTNX3JYHKkiD0dJ6HE8?= =?us-ascii?Q?bNW8XLFEOojlVxVzCQDU79s62GMeJChuksgcf9aLpNUWkFFo26wtswFwMWep?= =?us-ascii?Q?EeWLva9DgHpu7W7o0x640jFawog0KLRMQv4QQCB2v/1ArcEvZLTch1h1vEME?= =?us-ascii?Q?mcFpx070DcWGuG7gp66dxzG4pbRWkGyy2tw17b7tgdBgSKFylZyVbrWzt4P1?= =?us-ascii?Q?XoGKoZOGY9W0C3JyoC+7Jq9MQQYqEnQxvlrbpg9uMbMkYqNw4rWKStd7Vbq4?= X-MS-Exchange-AntiSpam-MessageData-1: QZ+RC9Ve+PnN+Q== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51e4e16a-c9ce-4405-c99c-08da395e6db8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:11:35.8757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q+Lb2pMJOnj9/AoPIdIbJ3VzBGLNZQTwT3Jm5m4yHO0cvqd6OLczDwFAk2msFdZKcKmWSOhpY+PSRwZfWJzJcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4337 On 19.05.2022 04:36, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022=E5=B9=B45=E6=9C=8818=E6=97=A5 21:05 >> >> On 11.05.2022 03:46, Wei Chen wrote: >>> x86 is using compiler feature testing to decide EFI build >>> enable or not. When EFI build is disabled, x86 will use an >>> efi/stub.c file to replace efi/runtime.c for build objects. >>> Following this idea, we introduce a stub file for Arm, but >>> use CONFIG_ARM_EFI to decide EFI build enable or not. >>> >>> And the most functions in x86 EFI stub.c can be reused for >>> other architectures, like Arm. So we move them to common >>> and keep the x86 specific function in x86/efi/stub.c. >>> >>> To avoid the symbol link conflict error when linking common >>> stub files to x86/efi. We add a regular file check in efi >>> stub files' link script. Depends on this check we can bypass >>> the link behaviors for existed stub files in x86/efi. >>> >>> As there is no Arm specific EFI stub function for Arm in >>> current stage, Arm still can use the existed symbol link >>> method for EFI stub files. >> >> Wouldn't it be better to mandate that every arch has its stub.c, >> and in the Arm one all you'd do (for now) is #include the common >> one? (But see also below.) >> >=20 > Personally, I don't like to include a C file into another C file. > But I am OK as long as the Arm maintainers agree. > @Stefano Stabellini @Bertrand Marquis @Julien Grall Well - an alternative is to follow the boot.c model: Have a per-arch stub.h which the common stub.c includes. >>> --- a/xen/arch/arm/Makefile >>> +++ b/xen/arch/arm/Makefile >>> @@ -1,6 +1,5 @@ >>> obj-$(CONFIG_ARM_32) +=3D arm32/ >>> obj-$(CONFIG_ARM_64) +=3D arm64/ >>> -obj-$(CONFIG_ARM_64) +=3D efi/ >>> obj-$(CONFIG_ACPI) +=3D acpi/ >>> obj-$(CONFIG_HAS_PCI) +=3D pci/ >>> ifneq ($(CONFIG_NO_PLAT),y) >>> @@ -20,6 +19,7 @@ obj-y +=3D domain.o >>> obj-y +=3D domain_build.init.o >>> obj-y +=3D domctl.o >>> obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o >>> +obj-y +=3D efi/ >>> obj-y +=3D gic.o >>> obj-y +=3D gic-v2.o >>> obj-$(CONFIG_GICV3) +=3D gic-v3.o >>> diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile >>> index 4313c39066..dffe72e589 100644 >>> --- a/xen/arch/arm/efi/Makefile >>> +++ b/xen/arch/arm/efi/Makefile >>> @@ -1,4 +1,12 @@ >>> include $(srctree)/common/efi/efi-common.mk >>> >>> +ifeq ($(CONFIG_ARM_EFI),y) >>> obj-y +=3D $(EFIOBJ-y) >>> obj-$(CONFIG_ACPI) +=3D efi-dom0.init.o >>> +else >>> +# Add stub.o to EFIOBJ-y to re-use the clean-files in >>> +# efi-common.mk. Otherwise the link of stub.c in arm/efi >>> +# will not be cleaned in "make clean". >>> +EFIOBJ-y +=3D stub.o >>> +obj-y +=3D stub.o >>> +endif >> >> I realize Stefano indicated he's happy with the Arm side, but I still >> wonder: What use is the stub on Arm32? Even further - once you have a >> config option (rather than x86'es build-time check plus x86'es dual- >> purposing of all object files), why do you need a stub in the first >> place? You ought to be able to deal with things via inline functions >> and macros, I would think. >> >=20 > We will use efi_enabled() on some common codes of Arm. In the last > version, I had used static inline function, but that will need an > CONFIG_EFI in xen/efi.h to gate the definitions of EFI functions, > otherwise we just can implement the efi_enabled in non-static-inline > way. Or use another name to wrapper efi_enabled. (patch#20, 21) > But as x86 has its own way to decide EFI build or not, the CONFIG_EFI > has been rejected. In this case, we use CONFIG_ARM_EFI for Arm itself. >=20 > For CONFIG_ARM_EFI, it's impossible to be used in xen/efi.h to gate > definitions. So if I want to use macros or static-inline functions, > I need to use #ifdef CONFIG_ARM_EFI in everywhere to gate xen/efi.h. > Or use another header file to warpper xen/efi.h. Actually I wouldn't mind CONFIG_EFI - eventually we may want to make this a use-visible option even on x86. Sooner or later (I hope) we're going to bump the tool chain base line requirements, at which point the build time check on x86 can at least partly go away. Plus there we support EFI in two different ways, and CONFIG_EFI would hence have a meaning even when the build time check fails. The one thing that I wouldn't view as reasonable is a prompt-less EFI option, which x86 would (not entirely correctly) select unconditionally. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 06:18:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:18:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332693.556427 (Exim 4.92) (envelope-from ) id 1nrZU5-0007ud-8K; Thu, 19 May 2022 06:18:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332693.556427; Thu, 19 May 2022 06:18:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZU5-0007uW-5K; Thu, 19 May 2022 06:18:05 +0000 Received: by outflank-mailman (input) for mailman id 332693; Thu, 19 May 2022 06:18:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZU4-0007uQ-1i for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:18:04 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 700f30d5-d73b-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 08:18:02 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-q8hJPLqROb-sGL8TjhCrPw-1; Thu, 19 May 2022 08:18:01 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4337.eurprd04.prod.outlook.com (2603:10a6:208:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 06:18:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 06:18:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 700f30d5-d73b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652941082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QWTnE3aXTHVjQN7DWRPrV2r+m4FxudE/Vh3ECcphPDg=; b=IT4ZMvXElMCCq0MKnCfurpLx1B604o506CsDmus1DzJryHZjOcmBVnloJ9cRFESgisFUwP M2W71hZeukpIfNW8RqQamSnYnh1X4DmLJr1F/5LWlhRlslDxD5DY5yYbSZj5qyyS6Wlg/i 7QhQQ/xrQrWlA9TJ/EzJWewMX8p3Nzs= X-MC-Unique: q8hJPLqROb-sGL8TjhCrPw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nMWxmo2VGINRn2FaRsSK4Ivb8dmLy7FBgGOr+FgRSiF1yYeuoA9CEjZNTlo7oSaktR/2iolefLQlZldtPCv4IFokng/DgKWtfIkyQM/2w8/eg3qgHYI44tklDqBcvGZvtFRKPbkPjKTyrPD34iv7Qm3PdCFVCEmlScsTdX1am+LJhMp+swb31euHlR7LBKrsXPUNPJ4XAUkoQOHjm0iAXA1o51DqWTwYWxeD/b/YTPTdBWWMpAl1IT6FWfqnZDV0TPEycQmA8QsN2fzqX0IQBuB3EdReEBZk2J/fUjA98uQfEQ0kJaPJDmXFPdXbbCrd60re2Lm5DrIYARZ3ZeOkUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0WPu9sAXKxQTk+WGl5yre8/RwW5c771AEUl+e2xJQc=; b=SGtoniKLCrZmS4zKrVBnFGjOKnBxBwvkPKV1GsgmpGdG8PP2AFG+AurmPTOVpw9k3JofpAZUhUimYUkOrrVSSZMa4mfnqozxJzEOJ7VNEcucPOsc99AYesyNUMABBy2/uufg0qq3w9bMd8rXQ56d8JXVs+u9zJS5Sqd3X+5ms4SX46VPPhHtS0nEIfT2tYgp6qZCYYZDp02eo3aaBnwyWWydJwxW1UYgJXsfIiLto1Rt9z7niuOTQA6u8nU5jLSqO8LRKLms2QzaxNfIdirrQGdGSs2ExeNd8OVmK/RLMGjsh0Kip6ljX8jArRFVUv9SkcA0GgFAeNVfHqff81WGQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4dd8521e-b63f-564a-6fff-87e3f1dc6f3c@suse.com> Date: Thu, 19 May 2022 08:17:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 8/9] xen/x86: add detection of memory interleaves for different nodes Content-Language: en-US To: Wei Chen CC: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-9-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:20b:b2::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ab43808-05af-4e27-737c-08da395f52d2 X-MS-TrafficTypeDiagnostic: AM0PR04MB4337:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0tfcvtnPH0bxZl8Pjmoo5ZH61QsXkwPtw4Op1DGYzLGpM8g7GFWD8yl0hALolEFCofrucVvx0pYEWrUmmEGwTFnBYUQBGAGh8MbntRiw0ImMDsIvNP/AsjKYNoxbu6XdcobyuDV5qjv0XQC1MyNMytM+/7db9oGob0+/+1krxrezuEYOiASzUyGaBv/OpwfvYcUtgW6sBh+GleQewpFKALuRjd0oRF5ww1drNc6gvlK7EhU42Ae6uVHAXHr0qtolP29Gb3uLU26waFZAXMo6XdfGrCgDCqbZVTzPanwxJdDYxl/iDygd4Ou/oSmAt56RjT/mgzXhsko+/S3VRIx4FEsL2CP/cnAZ0V6qm4nW8XF4XFanozX9TbX9xzQGy6G/b9o5WiFHnmPPInaUju/0p+ltBS4v2A0Q66uMBBVmAPXF9Qr0SOlIRuo9l6/OYKAInaJjTSJDISRi1bnH/utsOSwrxHEi0iqyUHTLrOFW0NT5mBU++YYjmRUiR10B55RBx+uwyTLN7tAfyZBUgS9I2f7f6X2QE84bJR9x2pCqkZQXJBZdb/h0jc6hxkJaVHmqQ4YILnAtc9GsIKPAkofZytUaA8O8EMNy16wXevVDMOruCqc15AMOtGWl/4LqGtAvJydModD4Uv//1x/cuHoUnwwUZ9tS0RfED96H9GoxDhsTqjhVv/7sLt0fBqeiTz1kN6QgVvKw1OxfdJYlLXb3L4stjWVrsTqveivmARK44uk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(6916009)(54906003)(66946007)(86362001)(66556008)(8936002)(31696002)(316002)(2616005)(4326008)(53546011)(6512007)(6506007)(6486002)(508600001)(38100700002)(31686004)(2906002)(83380400001)(36756003)(186003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IGWlfnqMDbXFAah8W7ia6aZNnSOqfXBWvxoNf3CXi1ViqRzirfm+PgMh2DUE?= =?us-ascii?Q?LgLkV3li/RXJi5cDE8GTR3+9301YVmFchcQFuKVyq1f7/4RS/sgXL+tiv725?= =?us-ascii?Q?GhiVjq5ZpQs4vyYmP7K+S+Y1r5HOKPM6fZjQif6dxsUcWkPTp76XTStZ72C4?= =?us-ascii?Q?5KmBJltotNLI7AjSRvHwtKJAw3//HHbXeb5sDkqTZIjYLrGA/dy5SXu/Au8h?= =?us-ascii?Q?RfBQB8ENs8lXMMcqMu5wxKXRP+SKmFssVHh3ERoEjWQL+SobO/fSs6GGHLd7?= =?us-ascii?Q?VB4rV2aLmzHTz07Ym6nQS8uaihHRAo2NUcWiYSGGLa0uH8Er0NIgsUOQ4WGP?= =?us-ascii?Q?hg+L6rnqPPhp1sDD8zJY5FudkljhXOqijoc7rDbLzOGfj8NxIzkX/or6Sfnf?= =?us-ascii?Q?TIvPEWSHn2CcXlWv43Mgx5aMbnDca1WbUi13BEzmkG8XF9LY9XXMgNenakNx?= =?us-ascii?Q?bzr4/BMscaqXlDJyIXmBQBhffG6SktQc1ixAzQWLocwM4Hm3MZgMTF3/BlLs?= =?us-ascii?Q?h0yI5UMRqeA99uy+uLlK6cqUpioT23BgVSL+PN2Ar8ouTzBSYrY2RauHuDHZ?= =?us-ascii?Q?u3QPeDoYa1QuxEOHXNEFPlsgRL/yK0mWbaq1qy5zat4Qe3GE91FB8geg7SjQ?= =?us-ascii?Q?TzWGSKWFdyu1C39pIqMZjZTKC/vqAKWwg0VhBZCy/rLK/i8bJK4QJccb7OJz?= =?us-ascii?Q?JB/2cd6vdMx7owOq78FBZhDDlv1bwO+rQ0esoEn/XwqRzEXhWCOtomwx5T/Y?= =?us-ascii?Q?rG3xm7YNXo5u5itpS76zn5YsBgyhpF8Ah93frhMmrHL3dEdOhHm85Uz6hWpb?= =?us-ascii?Q?NzgCjl3i5Rc+E9C+Zs3smRO5Pp8cjVe1+CIBAdyUyxQzJVfDtgbl/+p+nwHE?= =?us-ascii?Q?GwXNR0Bxrb/hGrMAHmj7kNXgg3GGNmlrtLF6XBOGAexerPqqPB9tfiVFn7c2?= =?us-ascii?Q?r/KAYCbvH7DGdwU1iQncS22deQKl47NIRdRaaXpBgmnGzT1AsbbkCb14FJhD?= =?us-ascii?Q?utqlMTC1Ja6ddPwVIRIAGY73kkQZMi38eurPQyqdiEm/J0vI2zPzTGBPZfcm?= =?us-ascii?Q?6uNlXFHC02bkzmEfOXpTYCkyg6oD9Xf6UkhSBZ+W5siHfI9CAdoPnXwdkpwN?= =?us-ascii?Q?0TiEzkGAX437UCRvishpkP05GScjOXsIsLhvNfG2R3VCT/4eLW4rhpfEVwns?= =?us-ascii?Q?S4o2P8elPQUXhuSxRtiXUfFFMWdG67zQHjuYeUYcw50WlnXkw7QD2fFdXcVC?= =?us-ascii?Q?xQ4kpIs0NmS0De8F67FbWPwUvxqYiApl/flF6NOgDPwEk1E5za0Wzw5IL0Ms?= =?us-ascii?Q?pXxIJV4YdNkAVPBvBeDdiGKWQq0+0K9Jhwb9bk9XR9ogv7rY5vGGREI49z50?= =?us-ascii?Q?TLPaAb3oMwVUWy/H8WXDLLFHX5Ibz/H5btzrbRSc97GtkkepFCbPR77H7bbZ?= =?us-ascii?Q?3cjwehL6uOeqEIKibirEM8foC3TURhK5t+ez1HXKsDANn8PsJfX/OZYA3jHv?= =?us-ascii?Q?QPf1y0n63lvuHpUSdFvkKnXmLFGXuQSFZVyWwLIvN74VnqWAhxJusjRCIovn?= =?us-ascii?Q?yP4jESWrAw63PBydpFAp6I5zUggMe7pjZQ1iVpHxg/AE73jGcAgkpNTQTEDh?= =?us-ascii?Q?yVPt1wi/qGlaV5nzM6b2Wv2s0g+/a8qax1FlN37jCVNiD7PemD22wmzZ9IC7?= =?us-ascii?Q?gJfmZTjlz4sflbiOWXcRftdevRah3soz4ilTeTyofbIqdCEJgNmhsn4kbl0Q?= =?us-ascii?Q?pxaig45yr9Vf7HnTojiEFezOOU0QC5TCiyygCY31Ink40gabY+YjrRG9qilK?= X-MS-Exchange-AntiSpam-MessageData-1: f65gl4j6+AGTTQ== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab43808-05af-4e27-737c-08da395f52d2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:18:00.2265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XMALEbqDkeWAxnufv4eSgJcEPkmiPA6AQiHosmgG05sJjh9uOjsGG9aVgESI2Vqc2q/G0/oQVLlG2RrNk4XppQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4337 On 19.05.2022 05:37, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2022=E5=B9=B45=E6=9C=8818=E6=97=A5 21:31 >> >> On 11.05.2022 03:46, Wei Chen wrote: >>> @@ -310,42 +342,67 @@ acpi_numa_memory_affinity_init(const struct >> acpi_srat_mem_affinity *ma) >>> bad_srat(); >>> return; >>> } >>> + >>> + /* >>> + * For the node that already has some memory blocks, we will >>> + * expand the node memory range temporarily to check memory >>> + * interleaves with other nodes. We will not use this node >>> + * temp memory range to check overlaps, because it will mask >>> + * the overlaps in same node. >>> + * >>> + * Node with 0 bytes memory doesn't need this expandsion. >>> + */ >>> + nd_start =3D start; >>> + nd_end =3D end; >>> + nd =3D &nodes[node]; >>> + if (nd->start !=3D nd->end) { >>> + if (nd_start > nd->start) >>> + nd_start =3D nd->start; >>> + >>> + if (nd_end < end) >> >> Did you mean nd->end here on the right side of < ? By intentionally >=20 > Oh! thanks for pointing out this one! Yes, right side should be nd->end. >=20 >> not adding "default:" in the body, you then also allow the compiler >> to point out that addition of a new enumerator also needs handling >> here. >> >=20 > Did you mean, we need to add if ... else ... in this block? If yes, > is it ok to update this block like: > if (nd->start !=3D nd->end) { > nd_start =3D min(nd_start, nd->start); > nd_end =3D max(nd_end, nd->end); > } > ? No. I attached this part about "default:" late in the process of writing the reply, and I did put it in the wrong spot. I'm sorry. It really was meant to go ... >>> + nd_end =3D nd->end; >>> + } >>> + >>> /* It is fine to add this area to the nodes data it will be used >> later*/ >>> - i =3D conflicting_memblks(start, end); >>> - if (i < 0) >>> - /* everything fine */; >>> - else if (memblk_nodeid[i] =3D=3D node) { >>> - bool mismatch =3D !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=3D >>> - !test_bit(i, memblk_hotplug); >>> - >>> - printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with >> itself (%"PRIpaddr"-%"PRIpaddr")\n", >>> - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, >>> - node_memblk_range[i].start, node_memblk_range[i].end); >>> - if (mismatch) { >>> + status =3D conflicting_memblks(node, start, end, nd_start, nd_end, &i= ); >>> + if (status =3D=3D ERR_OVERLAP) { >> >> Please use switch(status) when checking enumerated values. >> >=20 > Ok, I will do it. ... here, explaining the request to use switch(). >>> + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") >> overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", >>> + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, >>> + end, node_memblk_range[i].start, >>> + node_memblk_range[i].end); >>> + if (mismatch) { >>> + bad_srat(); >>> + return; >>> + } >>> + } else { >>> + printk(KERN_ERR >>> + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps >> with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", >>> + pxm, start, end, node_to_pxm(memblk_nodeid[i]), >>> + node_memblk_range[i].start, >>> + node_memblk_range[i].end); >>> bad_srat(); >>> return; >>> } >>> - } else { >>> + } else if (status =3D=3D ERR_INTERLEAVE) { >>> printk(KERN_ERR >>> - "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with >> PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", >>> - pxm, start, end, node_to_pxm(memblk_nodeid[i]), >>> + "SRAT=EF=BC=9A Node %u: (%"PRIpaddr"-%"PRIpaddr") interleaves >> with node %u memblk (%"PRIpaddr"-%"PRIpaddr")\n", >>> + node, nd_start, nd_end, memblk_nodeid[i], >> >> Please log pxm (not node) here just like is done in the overlap case. >> The remote node ID will then require converting to PXM, of course. >> >=20 > Ok, will use PXM here. But I have question for upcoming changes, if we > move this part of code to common. As device tree NUMA doesn't have > PXM concept (even I can use a fake node_to_pxm to do 1:1 mapping), so > can we still use PXM here? This will want properly abstracting once made common, yes. What the correct model on Arm/DT is I can't really tell. But my (earlier voiced) request remains: What is logged should by referring the firmware provided values, not Xen-internal ones. Otherwise someone reading the log cannot easily know / derive what's wrong where. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 06:19:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:19:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332701.556439 (Exim 4.92) (envelope-from ) id 1nrZV5-0008UP-KO; Thu, 19 May 2022 06:19:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332701.556439; Thu, 19 May 2022 06:19:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZV5-0008UI-HC; Thu, 19 May 2022 06:19:07 +0000 Received: by outflank-mailman (input) for mailman id 332701; Thu, 19 May 2022 06:19:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZV3-0008U4-R8; Thu, 19 May 2022 06:19:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZV3-0005Xa-MU; Thu, 19 May 2022 06:19:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZV3-0001SP-7m; Thu, 19 May 2022 06:19:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrZV3-0001Jt-7L; Thu, 19 May 2022 06:19:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zg0a56WA7PWVPV1YagQYoA0XpyBC9RESLGxZW+tAEtI=; b=0N+FVUMhMwsjW3FrQv+e/9A/Jb Z11tMJA9AFBmdu1l/EUIJ+16j1tVY8cC4Kf0PKMYG5HVO3u7q0GI+R5ou/qTZJUCU3u0H/+9rL2dI SydH0P9vtG/Z9eYCb51zFGQyILknxTn80ETfkS5WTL1bvag2EqQN/2AIVal+Cu3DdMKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170562: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=2189c71026cba9dab768776a2f8ebf689b484c56 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 06:19:05 +0000 flight 170562 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170562/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 2189c71026cba9dab768776a2f8ebf689b484c56 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1095 attempts Testing same since 170557 2022-05-19 03:10:24 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6713 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 06:28:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:28:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332711.556450 (Exim 4.92) (envelope-from ) id 1nrZeJ-0001ZO-Jh; Thu, 19 May 2022 06:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332711.556450; Thu, 19 May 2022 06:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZeJ-0001ZH-F6; Thu, 19 May 2022 06:28:39 +0000 Received: by outflank-mailman (input) for mailman id 332711; Thu, 19 May 2022 06:28:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZeH-0001Z7-Qp; Thu, 19 May 2022 06:28:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZeH-0005i8-Mf; Thu, 19 May 2022 06:28:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZeH-0001uo-77; Thu, 19 May 2022 06:28:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrZeH-0000VT-6f; Thu, 19 May 2022 06:28:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UNsDhPtHZFMDvEZxov272lzF8scJWXuJYyR/TTcYVns=; b=n6jDvKsbEIlKcGmL4lwjXunBq7 Z4P3Hs8KgRn0OmRjDgQ1yXQrHP0epBscUyX7KyzlSa8NB7eEUB2owTkbSaty5ESMR2tcr+778mgLh IBweoezvlou8r6gxor25VNHhlkAzugRA3vxvYgb7MRrwYZDyy20hjkvRKTq8e2iroZf8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170545: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=25c160a74f4489f031ac79a24078cc12efd5c96b X-Osstest-Versions-That: xen=69589c374a92d1b4f97db24623e5f760990eaf82 From: osstest service owner Date: Thu, 19 May 2022 06:28:37 +0000 flight 170545 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170545/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170529 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170529 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170529 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170529 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170529 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170529 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170529 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170529 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170529 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170529 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170529 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170529 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 25c160a74f4489f031ac79a24078cc12efd5c96b baseline version: xen 69589c374a92d1b4f97db24623e5f760990eaf82 Last test of basis 170529 2022-05-18 05:30:55 Z 1 days Testing same since 170545 2022-05-18 15:40:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 69589c374a..25c160a74f 25c160a74f4489f031ac79a24078cc12efd5c96b -> master From xen-devel-bounces@lists.xenproject.org Thu May 19 06:51:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:51:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332727.556481 (Exim 4.92) (envelope-from ) id 1nrZzz-0004ze-Ug; Thu, 19 May 2022 06:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332727.556481; Thu, 19 May 2022 06:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZzz-0004zX-Pc; Thu, 19 May 2022 06:51:03 +0000 Received: by outflank-mailman (input) for mailman id 332727; Thu, 19 May 2022 06:51:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrZzy-0004zR-Ge for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:51:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b74f39d-d740-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 08:51:01 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-vrB51aNsNpugYgGSpVNDbg-1; Thu, 19 May 2022 08:50:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8134.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 06:50:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 06:50:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b74f39d-d740-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652943061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9rEtgbWEYWkZBXaiTG6KlCNdTdef+KS8OdNeXAHESrg=; b=accL4y79F+suTgjS5uCkqPIDPjuJV43TFDNkYd2LsOu1gIRrS99HyK2vOAMPgzYAZoim0/ 8jxbUA61r7WCBSukXD3KACwt0xdRAW3UFE/omXK7MZg2d/hrFY59qQYjNL4RVf7RCHZM1+ 08PNokEHH+1UI9Pgi05iZ5dGaPnUuWY= X-MC-Unique: vrB51aNsNpugYgGSpVNDbg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4Au3eVppV+zbVGTSOhGDckHGU4SZE4MltRqZjfgLikQ699TEa3VSXoa3rlLqRgm6kfpprJHO0gHu7OoPu84rU6aJVYndXhdSCmFcpTLtWyw9LmVwfauj6VjRRUhKrB8KwaVRuaVqrm1US/XmVQ3uv6YsTd40c5hY2PPQ4Q1HpNoBch2NU2KlZg7CC0oMnXXBZv0Ci2HibkCXbvpz5mEnWYyWQixDiQm+qIotTV5tZL7wQ1Vo7PwcBetXV48N1ORQCEZT01TwLv9z3uzsoXRwFQShNZqRhazEoL8uBaibIyWV8EYld9L1XlFnXZz8iRr44ZX/eHSGeXgzDkXY6IaSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rEtgbWEYWkZBXaiTG6KlCNdTdef+KS8OdNeXAHESrg=; b=e44XvF4O2/99irkAcr0j3pYBy+7L17e4jEQ6CEBpKK0ZnWAnFlL8V5d+AFmlUSxnNh9JKsmOlujIOTPpaadKRg7V4na5lOQ2waDQWfoIarBxaPfNQ+kF2QPJX7NCXU/xKnurncao5S2zK0jgrZw7aoRjOhkJ0R4iZtLtXpdILpYVIlilqP6gJz5RrBpHVy9f9Wg2bfNsebzSyH+QYSQ0jxdtXlrcHaurXgeHMeFruDFi9SRVhgKPQ56NwcjAVuAGjnJ8+02biicBR9QCkFAJMKK4vmF+uiDJYlr3Qh8FNNTOB5COZONssjgv4AtstgcKYikZw5CfUbtAi4K/PE893g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5cf98549-6fc0-67f7-a882-0778e7ab6f98@suse.com> Date: Thu, 19 May 2022 08:50:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220517132130.38185-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0019.eurprd08.prod.outlook.com (2603:10a6:20b:b2::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c13e3816-5c06-4333-4fb8-08da3963ed6b X-MS-TrafficTypeDiagnostic: AS8PR04MB8134:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +dkdylaB9wmp76FDt0cOKRzI0psYHAMnpu8YjMYDWFVe2NKCFsa90T9XSzdxnyntQqwxxr7HiPCtim9JjTRzCmEJIyX6ctsRRbKPGls0KIQqO8NXzpRgBx30eA1TYGw5yeNftzmuk2vFRKw+TByzmnm9RX4UNtw4Asd6L3Yn7/KO/cQ+/Ihe6ZJYwLTLQNEc7/5pH09cGNRm25HMCONdnEpfr2GOgSnp+e9oDrGRGNqZyELwAyGElhC+yixPYqNPDssbtQDrU9R4VTyeyAb/1W4/QEg/QTi/14atEjp5ZFf2Y8pQov9unOv4Id3PGTK0dnLiF9i8+5iC89b1MmNsS2e39pnmbushZClhEq2DimWqx5wEnOsahDSdUvNXTbVuROKKA4ds5WkE7bC2EFaCw9xx4PvVAIzShoir1rzB/CL9rGNjMD3wJ9BrqZygPIG327Vdvu56V1gVf0WkENKKTO5gQP7l2o9CHIYhCyFvrRoAlFR+1FW7Sxr/CRo5gO48VwnHGlU3lERudJxaOPztbHGjY0zkD3/AwJF9yH0eifpCFBj3BgoZF7af2zi3AMbCO2L5OvvvD/wFBSpYQPKpNLqiUXeK4NBTksj37OR+1NMXSooi6/mgKO34mdRHmGY/SbhazTeQTQnwDub0phFMuXF+ubGb3WOgMRAfbnr4cRsrCdAoDneYxaRW/7ODkIIHhYEC4+B0tcfIDDujE+FTwEOgBjFiy+2v0kigRgzUo4g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(6916009)(6486002)(66946007)(508600001)(8676002)(54906003)(66556008)(66476007)(6506007)(6512007)(4326008)(53546011)(31686004)(8936002)(5660300002)(36756003)(2906002)(2616005)(31696002)(186003)(83380400001)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3p2VmpySGhFaHVNUlp4VDFOcWdPb1JyL1YwdGJnL1lrdWdIYjh5YS90RVEx?= =?utf-8?B?c01GcHp1QzBUbFhueUVJZEJYNnFKSGlsdnlyV2tKRzI2MUNWcytyNFFJV0ha?= =?utf-8?B?QWdEbHVXdWVra1lIRnRsS0lHR25LdHRFclNXbisyNlAzMzM3c3NXU3pEOFlI?= =?utf-8?B?T2FhbWs1aEhzSVJ0NDFibTJqZnJ6bmVGYWF0NytCU2FPUmpyRjQ1TFo5aXJV?= =?utf-8?B?WTFrak03QnlmeDdnQ2dpYmZXR0NWVjNiM2RCQ1hZTGZPWTNYdVNhK21pZklJ?= =?utf-8?B?RXh1Z2RIcG1TMmZxa24yeGZuK2EzbFlFMXFkNk15QkpDZ2xUNlpiMDBoY1ky?= =?utf-8?B?WnNlK3JNdWRLOTFVZVJ0RkVjcWJvdFdTcWJyanJvUmYwT3hRNVhkQ21qWHMz?= =?utf-8?B?akxNMzdtTTY3dFgzNS9QYVJ6TDJJdFJYNUprakVkVVhxVmwzZ2N1cStBUDFm?= =?utf-8?B?ZUFGNFZSZTJpNkkrRW80Y2Y3TTNMeGlyTWxENHZKcCs1ZnRZUEY3Q2xxV3Vz?= =?utf-8?B?ODRQYWprN3ZSVlBtYk84Y2FKVERMYWhzSDB3VGVZM21NOXc5MzJybk9SM2N2?= =?utf-8?B?T3hWUy9Sb1dlRnZ6UElWTUxqc3QybW1DU08vemtYMU9Fc29OdldBZnM0cHBX?= =?utf-8?B?V25samtEZnRQc01BUFhhM3Q2Wi9ETW5WRjBia1hQTE1RQlk1QWRXSmRWRU9W?= =?utf-8?B?VjhJMXFQZE8yVGtDTlA2MmU0TFVEQk5mdFF5Ni9ZMTdMSXVtUGUxakpGcFRi?= =?utf-8?B?eUtpNzFwY2ZZUTFhYjY3TnNaZjdOT2NWOTgyTTBjczlGdWg1WWpaak9nODJi?= =?utf-8?B?d2xicG1JU3BYV3h2Q2RXai84c2tSYVRJeWl6bFBnc2JnaTN0ZzBPOHB2YTRk?= =?utf-8?B?V2tTSjZ6QW56SXBaK1FDRlRKUnc0cDlCM1QwdTZVd3JUSlFhV0ZWZkhpWXJG?= =?utf-8?B?eWorZ1AyWWh4K1lKTHdneS91R2tnekNTNGQxQ2tHMzBpQ0w1Uy81ZWhudmhY?= =?utf-8?B?L1JlRUNWOGNIL0s0T0JIbnRYV2dWNjJhUFhRSG95Rkg5VHN0SmQ1aGZWQzFk?= =?utf-8?B?VUo0amwyMk9uZ3lOdnVuR2NTZFM4Zzc1eTZnWnNhL0pSc3V4STl5SFVQT1VK?= =?utf-8?B?MURwWnY3WEJCcWxMdU5XdTRKeUpKYUR3aVBiZXZ0WmI2bXVOTU9JSGNRS3BW?= =?utf-8?B?THpIc1A4SXYrUmQ4b09BbWpaR3Z0cmxSN0NhclN0R3h3eHhKb1M2UUhqemY3?= =?utf-8?B?UVZzUElzemdBUCtSMStVUThDcnhSWHk0REtqdDFsdTBRNTRqRzYySThXK3Zj?= =?utf-8?B?bHdMZ2libUR6UU5vSThldTQ3Ry9OVjlIYVlSYTByVnpUL2hyMkdxKzBWWEpX?= =?utf-8?B?SmEydW5TQzdQeDZXay9ZaC8zZ0tYUGVJaFhVRS9kTmwyeEgvYWRKTkE2bXdQ?= =?utf-8?B?Zzk1WWJUSzdQeFpmSUhVeXV5OGFNVTJodzdzWmJ0Qk9Md1FzWVJabXVMVjZR?= =?utf-8?B?cDJqNWJnZkVqL2gwU3UwVzYyakphc1NsdzRhOTZIOUN5dDRvekxwd0hBaGoy?= =?utf-8?B?WTNZWjA1emk4T3RQaVJqeTZzK0tidy9Vb1RLZi9EUHNRUXhCbDBPYXl6MURT?= =?utf-8?B?czc5a3hyQ0ZlUVp0djhSMEFTQ3VheHJXTWNJdGdQb25VTkZQYkFnYWgwNTVJ?= =?utf-8?B?ZlZZbjUvY25TNk5YTmZJejA4V1dUaUFjano5cE5ORzdKTnVmYmFHS0ZrTEpR?= =?utf-8?B?OVplTWcreUc0QnNpSjBHa1FZN3ZpUWJWRmQvYlhFV1daM3ZSbC84RENGY09T?= =?utf-8?B?MDdBVWxsRk4wb0JFOXEzcHU0VXVrczhzUE84NmF6ZXRoSjJ3YmtKNDBVSWhv?= =?utf-8?B?Q1JjWmc0ZUxqTG1qNVBVR1VnZ20zN3hTemgwYXhNWmVsRFloSXZESEVobm1n?= =?utf-8?B?YisrNHRTM25aRXdVaVIrb2NHV2dqRndVek10bnpxQ0hZaVhQQXJqem1oTzhO?= =?utf-8?B?TU5NQkxiSGtsRWl3Q3ErckR5N2diSlFWMzlMZFF3WmJOYU1VSkVNc2FxeVRK?= =?utf-8?B?ZVlpeDZqMHk2ZUxYV0FBamEwN3lkbnZzRXlKK0l1SEM5SzRibTROVWt4aXRY?= =?utf-8?B?ZG9wRzg2OXhGcDdMWDlWeVBOc1hBQUl5Ly9jL0QycHFCRy9OL3ZjbUlrVTRi?= =?utf-8?B?dzBiMkkvVTI5Q1l1UjQ3eWx3R0ZhMExJa1ZNWUMxbmZGNGFiaFNnWlB4M0ZX?= =?utf-8?B?WnVOUy83bTlhaTlESjE1NlhLZWVwWEtselhlY0RoMXZJNWttbVpFWXRRQ0ls?= =?utf-8?B?SHE5S2h6OE4vMFprMitoNjFKanlMeHliVFdOMS9FZWc1NmJyN3N5dkN5VnAw?= =?utf-8?Q?BZSsgatvDapAPatLH8gaz9E+OoHrEY2EFwdHfCI+iHNKw?= X-MS-Exchange-AntiSpam-MessageData-1: J4K2r/Z3y4l9Gw== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c13e3816-5c06-4333-4fb8-08da3963ed6b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:50:57.5531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIUN+ICq8EmVm9qk+YRwEOfEkc44B76waoI/26wLDQaBtUUkI1y5RbEgrdTAws5zbH+Wx+8CjOuIKS+mi65Etg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8134 On 17.05.2022 15:21, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); > static unsigned int __read_mostly ple_window = 4096; > integer_param("ple_window", ple_window); > > +static int __read_mostly vm_notify_window; __ro_after_init? > @@ -1333,6 +1338,19 @@ static int construct_vmcs(struct vcpu *v) > rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, > VMX_MSR_GUEST_LOADONLY); > > + if ( cpu_has_vmx_notify_vm_exiting && vm_notify_window >= 0 ) The assumption then is that values >= 2^^31 are nonsense? Generally I'd think we want to special case merely ~0u, giving the variable unsigned type. However, I also don't see where you disable use of the feature in that case: Merely skipping the VMCS update here isn't enough, is it? The field itself doesn't know any special case values (like ~0) as per the doc I'm looking at. So I guess the OR-ing in of SECONDARY_EXEC_NOTIFY_VM_EXITING in vmx_init_vmcs_config() wants to be conditional. > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > */ > break; > > + case EXIT_REASON_NOTIFY: > + __vmread(EXIT_QUALIFICATION, &exit_qualification); > + > + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) > + { > + perfc_incr(vmnotify_crash); Is this a useful event to count? We don't count other crash causes, iirc. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 06:59:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 06:59:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332735.556492 (Exim 4.92) (envelope-from ) id 1nra85-0005gs-Ny; Thu, 19 May 2022 06:59:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332735.556492; Thu, 19 May 2022 06:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nra85-0005gl-L5; Thu, 19 May 2022 06:59:25 +0000 Received: by outflank-mailman (input) for mailman id 332735; Thu, 19 May 2022 06:59:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nra83-0005gf-Rr for xen-devel@lists.xenproject.org; Thu, 19 May 2022 06:59:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36687cb7-d741-11ec-837e-e5687231ffcc; Thu, 19 May 2022 08:59:22 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-QgKjtH3-PoqWj8Jcpzz5cw-1; Thu, 19 May 2022 08:59:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2294.eurprd04.prod.outlook.com (2603:10a6:4:46::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 06:59:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 06:59:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36687cb7-d741-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652943562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XvDDzknZzMcxfntwIJvK5bXWbo7dri2NsUaVwghPuUQ=; b=AHr4KaJmSVud2SVEVBu4GPb8T8rIMw1/ArdOFTGeipUwDO3QuPzpUiWBU9Zl2rHTxcaNC+ 3HBTtI4qrj6Aaz4nqoQFUKtpY6s41lixiBw3GeVk0BOym8VcUlTShjBrHn3jkchkY8hutS EY7Mx52zonykSYqEiG6n/guVuzcUIuY= X-MC-Unique: QgKjtH3-PoqWj8Jcpzz5cw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqmds8or1eBAMD/mpQcf4OreaFB4GyoZtP3tml2x+XFCJSFuvEwbs4acOwfTkvIKRnrYjWelzb9fe1M5FgGgYVDCBx+EFakM6uXZxiSane8QjF9WQ7ji6jrQLGUrVXbsJBpayjAhFzwsVKyCMCuHajdtEeICqn4ZBwUFd41s9V0CICNTh9i0fqc06+JE41rxWP4RHGkFlgMxdRvHJxRYQjoKnabUtLq9rG8da1Pn2XrsRy4exfKgvWNhElRQLFUk8SNIsTe4grCcqmg8hjfSw0zYeLrZLzQ8BDXVL+utIzK/GL7MCgoNjMUrPJFM+84AKaOKR6hX9NUZKA0tJGyfog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvDDzknZzMcxfntwIJvK5bXWbo7dri2NsUaVwghPuUQ=; b=A12kr4qG7XHtd16zrCwcNI9UN3mwDxnjsXHyqbf0j+n2x5svNDQWDoXF69EvNMjVepMUc8lpM2Fln9Vl+EHxFPA11EL8PO6E61ckH4Se99GT/jHEgu2dsV2Fup29nd/bT4kbKCUIapdNm29dFiXw/rJuNqnUPN3fFtpomZFqi9uBzDA/JXS9hIflcoWd8RsL8Ore07/232EKW9qTMS56sk4dTCSnSPCflIb+sZcuxoHlGM078UozkpS+3jkKOlnAITqGDEy2x4gH5I66gJ0tSaPcyjolBTt4cGZo9JBcexVcqL2DeDHJjINcbQqw2waL9/kDrmvLeuWWQPUc1Fd0zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 19 May 2022 08:59:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0029.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb96770f-e95d-4a5c-bde8-08da39651625 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2294:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L+O/YD9Ade3ERgbCcckgNUBoMYkraNGlJZa/yr/SmTfSvKJLL1H67hijpyDx1VgmA35JczNjUqXXxG+ja/1/VPQ2c8GsSdf/avjyT5X1zTPTBrHKnxwfMrntGLL0vpo8Y18Yhd67/7yDA0aveQtDUKRdzRjIasVRM2QHUKzeL9l6U6Ety+NrzjwoKlzBUKrLIZP0oZ8q8rYepKSifl9r9wbwQDobUovv7zIzkGyYPHZaDNqp29MKQ2EKMyqF7seY7M6dpYo+axBT930+xmB0eSjciqv5OyZEyASJL4hlPDgaXFRja3yARfxyB97CTYxHeCEebWQ1dp6m1AY1s1gZ99xhgUrcdFRvom8J+zRmsI6UbBPSsyClNnVyAbyZvZHEB3qtAWqNf3ctZ3zFKAY7mEP4G8DPmm5s5TnRlknrvDxOLcU9Z7zm1Tz1yvLwLKmDoX4Ay3jw+U1uKx+/okLLhdBAudimYVHjieNCy3sgDnQLSSzEDIzgQfZ91RN6JioQq0jrg9zxWlZvLGAqXZ5wm8be4QE4rRGsy8u9XsDn5AtkkOVypcuRAkgFoVL965i6D8ykCX8wvqUxCZK7y7Zb1TfGDD0qvK6g6DvZuGxjBhD5PzTFEBuDN9C9E3G9CjJOPj98w3rV1IljHqEQ+Eo0QWZPNc4lZGrbGP380mgv3zXCEOwimCamEONeSAE5Q88Sml+BiwKglY1oIEWNAquTWDq+8dpZ5TRdIqjyj/zcOJ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(186003)(2616005)(2906002)(31686004)(6506007)(6512007)(6916009)(54906003)(316002)(5660300002)(53546011)(66946007)(8936002)(66556008)(8676002)(38100700002)(4326008)(31696002)(6486002)(86362001)(508600001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0ZQZW9HTFBkeGNaZUx3Zm9KTW5sZ1dXbkFleFpnVTRvSFZDem5ucGNLSTcw?= =?utf-8?B?Znp0TnlRSm0vYjh5Z2ZxaFNzQklScTQ0cXhFN1hSTUFMS3c5ZHlBRno3dSta?= =?utf-8?B?cXhCd1ErSXpLazVjdytpZmFxemp5bWJtUWtmeUo1LzdYUTltM25iUDJ3MGVQ?= =?utf-8?B?NHkrOGQvaktGWlZLaE1yUmFkRXBuOEdYdXpWNGZiN2orQUxibEVLamtCWjV5?= =?utf-8?B?OWtyQ2pqMUczVmtrajUzZW4rNzU2ZnlSeUVSMkhldldQck9UVEVUUHRuY3Yx?= =?utf-8?B?dldMZnZhb28yZjFNbXF1VmV5bEFwYVpqTDdrQTRYajF1VENyb3BwbGY0cmRY?= =?utf-8?B?ak8razI1emoxQXNvSS94WEJESFBHQ3pGME1NVEM1S09IWkEwd1VwelBqekRh?= =?utf-8?B?dUpTRisyMmlxNXNrQkMrNnp5cU9jdU9kMVFMb2RrQlNHU05rVWJpL0d2UmxV?= =?utf-8?B?RlZNMGhuZk1yQmdXZ2gyRzkvOVRycGZqYUg2YUpWVWFOY3U3cmNzdXR3eStD?= =?utf-8?B?bzNVOUdSbVdlUWlpU2FOaW96dXNtazdzZU1rOSs3TERvbzUyUTd0TTRDVjRx?= =?utf-8?B?ZndxcGJvc2RKL0JUR1pYS3VONGxoS1FJQmVNNkRoSmdMU1pzbkVsTmdPL2py?= =?utf-8?B?bEFDOW04SGRUMmpXYUdwUGd0N3d6d3p1bms5NXlINVhmaWdSNVF6NnJhWERC?= =?utf-8?B?ZTc1RmhPajBJOUlUQ01PNW54RmJiQmg3N1d1QzlrVDJJNzk4WTdEN2s0bk4z?= =?utf-8?B?ZEMwMk1NU05lczFiV1JpNnI3aHBzMTgzclBkdDhuSGU5RDdLcFVkZ1Jadlpv?= =?utf-8?B?V1FIVHpqeEF1U21yT0ppTGdDYVhpVVJNNUsxM05yK3h3UTV5b3BoSDQ3eWNK?= =?utf-8?B?SjY3cm0vb2NPQkVJWVNOZ08zbjdDZDJtRk4wYUtweXZIbElnSXdYY2h1TFNa?= =?utf-8?B?QmdOaWV1N1liK2dlb3hzeS9hUTlEeGtETWZjemc2Zm1wRWpiZG56eFc5QVRB?= =?utf-8?B?WWdFa1Z6bTZtNTF3b2NnZGx1d29Dck82SXFoVFNyOThIaldXMUtTMXVVY2J1?= =?utf-8?B?dXM3N1ZRZUlvWDZ1dGllMld3UjZYT0tmT1F6djNoTGdWQmRGbFBSYnByeERx?= =?utf-8?B?VE1kK3d6cEwrNXRjUWh6azU2R2NRZWhxb0FhVU8rdkZTaVd2Z2hkVnNqdkRr?= =?utf-8?B?dEFqa2FWQzVEN0hvK3h6eTlUY2RTTVgybTMrTEhjbFpQeWZTM0grL3VsMDFO?= =?utf-8?B?WUZiUFBUYVgxbVI1MHlLc0tPbmdMMnlHb0thVW00MVhTK3M5Rk1HRFFUcnVX?= =?utf-8?B?MmVES0h4R1V4bWpSY0NBLzA4TmYzdkROUUN2b0VhaWR6QjBXclZMTUZFR2V5?= =?utf-8?B?RDdhWW9xemt6aDZKdVNVOTQrdzRENFEvNmxiSEh4N1E2Tk5HTUdlQVJsUE5P?= =?utf-8?B?a2h6SFNlSlg5cVZHTTFFelRyOGZoMHR0aThHMGljRXN6dVowdFRkcXFYSXNP?= =?utf-8?B?VjM4azRFTzFwTUtrSUl0b0IvL3ZZS3VZUWVQbWZSQk53WWpEVng4VDFDMjVN?= =?utf-8?B?MEErVHEwNXB2V1ZKZDNWNHU4RVZMYUhPcVBQZytydEFheXR5UXdkS3ZGMkRW?= =?utf-8?B?cDlUbExNNFdVdER4VTBSQ2w4clozazNhNlpyclBGMTRwS0FkZk1NSEFvRSsw?= =?utf-8?B?UzlUS3pLUGdKTkVpc21lK2VNTFo1UXFjYlB6cnV3U05qMVlCMGR1YnRjZ1hI?= =?utf-8?B?UnBTL1pCdTBqZjVaYS9CY3llRlQ0TjFHYXRkZWlsU0N1bGRnV1FtazBUR2RI?= =?utf-8?B?aFllWVZnUHpZN3hCMlN1cTcrTjY5dEp5ckY1YWZQVGtDUWFna3ZlUHVucmNB?= =?utf-8?B?SDRDYVE5cm9NVnF5S3Bvb3NCQmxVYmJ2UHk4bHBVVjJORllwZ1JsZnBCbjdr?= =?utf-8?B?UHB5NGQralA2ZDlvOFozTmVGSnlvUlRrWjVYRGU4U21aWmVDeERXclJYUHEv?= =?utf-8?B?SVF3bkY1R0hYQW5TS1VzOGVIZnpJd3VOWHE1VzlvOWNSbTkrTjFhNVV3MXps?= =?utf-8?B?Q2hOaGxxb2F3N3cxcXlWSjF3a3dTRFc3M0JCbVN2UGs1eDlSQ1UxOFcyMjBi?= =?utf-8?B?VXhvdjEzUXluZUREK21MNlduRmkrYklrSkZDUVgxM3pKQ1JIaVZ1OXU2dGZN?= =?utf-8?B?U2dMMzBHSTNHWm1zOUhZQkZoWVlzYjdPdU1hV0syN0RtcHQwVURDdzc5R0VC?= =?utf-8?B?NFFRanJJTTdUYjZGQk5IeUxHbUlleWJIQjB6bTNPOFBqem1GZ0pDakRYR2hi?= =?utf-8?B?QXkybjN4SUMwSDlUVUdKb245a3hmbDFsQ3RCeEFZODdFQmlIN3NTNGxLMmRs?= =?utf-8?Q?imIjLfGbIwJTQoouFWVTBcaIXFlgMCfnp+OUR6ixluPOs?= X-MS-Exchange-AntiSpam-MessageData-1: TL4Qxk0PNqDaUg== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb96770f-e95d-4a5c-bde8-08da39651625 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 06:59:15.3804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tK0lYdsgeYcF8qHFhkl93v0hXvGgVnvdDPyJDFkuXkYsJAAtRukxpJZkMeXJGQUl1UxUDaB74FxPoQ4pISWDxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2294 On 19.05.2022 02:10, Andrew Cooper wrote: > On 17/05/2022 14:21, Roger Pau Monne wrote: >> Under certain conditions guests can get the CPU stuck in an infinite >> loop without the possibility of an interrupt window to occur. > > instruction boundary. > > It's trivial to create an infinite loop without an interrupt window :) > > Also, I'd probably phrase that as an unbounded loop, because not all > problem cases are truly infinite. > >> This >> was the case with the scenarios described in XSA-156. > > Case in point, both of these can be broken by something else (another > vCPU, or coherent DMA write) editing the IDT and e.g. making the #AC/#DB > vectors not present, which will yield #NP instead. "Can be broken" as in "the loop can be forced to be exited"? If so, how would a remote CPU / agent become aware of the situation, and know what the cause is (and hence know which IDT entry to clobber)? After all it's guest state, which we wouldn't want to alter for no reason. Nor should we put a guest in a state where #DF might eventually result. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 07:04:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 07:04:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332743.556503 (Exim 4.92) (envelope-from ) id 1nraCY-00079p-AN; Thu, 19 May 2022 07:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332743.556503; Thu, 19 May 2022 07:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraCY-00079i-6A; Thu, 19 May 2022 07:04:02 +0000 Received: by outflank-mailman (input) for mailman id 332743; Thu, 19 May 2022 07:04:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraCW-00079c-AB for xen-devel@lists.xenproject.org; Thu, 19 May 2022 07:04:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db19530b-d741-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 09:03:59 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id CF6261F9DC; Thu, 19 May 2022 07:03:58 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 813A52C141; Thu, 19 May 2022 07:03:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db19530b-d741-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652943838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=395st/CngVntAAOn5uSBsdHcf6UJsehUQOcbe6ab9wI=; b=qJ/FgyV3p4LuXUdkZjoAbs2+ewn4o7aNZN0S67D2rC96Mde70WoKxt5D1iYy3vIxFGNywX NYQFStO7xXozlUSKqQPZCblT/M2McgEFa5ttVGDSrZzFsBjH4DUBLxqHsrlOhubnXz8Ip9 VRfQAfc3f6HDJx77hS/XQSQpNXuMeJQ= Date: Thu, 19 May 2022 09:03:52 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 2022-05-18 10:16:20, Guilherme G. Piccoli wrote: > On 18/05/2022 04:58, Petr Mladek wrote: > > [...] > >> I does similar things like kmsg_dump() so it should be called in > >> the same location (after info notifier list and before kdump). > >> > >> A solution might be to put it at these notifiers at the very > >> end of the "info" list or make extra "dump" notifier list. > > > > I just want to point out that the above idea has problems. > > Notifiers storing kernel log need to be treated as kmsg_dump(). > > In particular, we would need to know if there are any. > > We do not need to call "info" notifier list before kdump > > when there is no kernel log dumper registered. > > > > Notifiers respect the priority concept, which is just a number that > orders the list addition (and the list is called in order). > > I've used the last position to panic_print() [in patch 25] - one idea > here is to "reserve" the last position (represented by INT_MIN) for > notifiers that act like kmsg_dump(). I couldn't find any IIRC, but that > doesn't prevent us to save this position and comment about that. I would ignore it for now. If anyone would want to safe the log then they would need to read it. They will most likely use the existing kmsg_dump() infastructure. In fact, they should use it to avoid a code duplication. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Thu May 19 07:49:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 07:49:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332752.556514 (Exim 4.92) (envelope-from ) id 1nrau5-0002wy-Vb; Thu, 19 May 2022 07:49:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332752.556514; Thu, 19 May 2022 07:49:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrau5-0002wr-RP; Thu, 19 May 2022 07:49:01 +0000 Received: by outflank-mailman (input) for mailman id 332752; Thu, 19 May 2022 07:49:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrau4-0002wh-BO; Thu, 19 May 2022 07:49:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrau4-00076X-7w; Thu, 19 May 2022 07:49:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrau3-0006RF-Qo; Thu, 19 May 2022 07:48:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrau3-0006R4-QN; Thu, 19 May 2022 07:48:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qctKzdx+tMSbSGNymUIe8Vlivvkl7+fqFceJDUrxBYc=; b=f/JGpHxmbwhRrmmF2zz728UQHQ feF4m7B8jxbCIrozynIFRfF+qG+8rAJcTFB4ch0LNcmYmTAssEa0VuHj8XmbRdd4rhP7j453TlRoE CUlfDDKOVOSf+Uuz3+Tayudg0NcRLzffpMkltC07AQNUmNim6En65KZ2MnSu4NATc8IE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170546: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ef1302160bfb19f804451d0e919266703501c875 X-Osstest-Versions-That: linux=210e04ff768142b96452030c4c2627512b30ad95 From: osstest service owner Date: Thu, 19 May 2022 07:48:59 +0000 flight 170546 linux-linus real [real] flight 170565 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170546/ http://logs.test-lab.xenproject.org/osstest/logs/170565/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 170565-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 170565 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 170565 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170523 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170523 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170523 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170523 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170523 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170523 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170523 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170523 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux ef1302160bfb19f804451d0e919266703501c875 baseline version: linux 210e04ff768142b96452030c4c2627512b30ad95 Last test of basis 170523 2022-05-18 00:11:33 Z 1 days Testing same since 170546 2022-05-18 16:16:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Chi Dustin L. Howett Forest Crossman Gabriele Mazzotta Linus Torvalds Randy Dunlap Takashi Iwai Werner Sembach jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 210e04ff7681..ef1302160bfb ef1302160bfb19f804451d0e919266703501c875 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu May 19 07:52:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 07:52:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332762.556524 (Exim 4.92) (envelope-from ) id 1nraxU-0004JQ-Gl; Thu, 19 May 2022 07:52:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332762.556524; Thu, 19 May 2022 07:52:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraxU-0004JJ-E9; Thu, 19 May 2022 07:52:32 +0000 Received: by outflank-mailman (input) for mailman id 332762; Thu, 19 May 2022 07:52:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraxT-0004J9-L4; Thu, 19 May 2022 07:52:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraxT-0007AU-KB; Thu, 19 May 2022 07:52:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nraxT-0006p4-92; Thu, 19 May 2022 07:52:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nraxT-0001Sl-8b; Thu, 19 May 2022 07:52:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7a4h0s6JFXIUVgXxn+XTRhbKz4NmcmECvuCG2F3E3uA=; b=eBPpG8fZV9rB9DHS2ZXWe8KjyE m6kB8w40PI7G9xKpARodrsadQ4EkBRgXYL3DhT0B+xkFvOQXhF5pBT1j4ImmpuSOG2ydRBEcfivBI 5/uoitVhUkYe8caAKg/XYlqJShpg1EJd2m5UnDlYzAgdrpVTlDzQCkXZOZrQAHO/6Xnw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170564: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 07:52:31 +0000 flight 170564 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170564/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1096 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 08:03:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 08:03:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332775.556536 (Exim 4.92) (envelope-from ) id 1nrb8R-0006MY-RN; Thu, 19 May 2022 08:03:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332775.556536; Thu, 19 May 2022 08:03:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrb8R-0006MR-O1; Thu, 19 May 2022 08:03:51 +0000 Received: by outflank-mailman (input) for mailman id 332775; Thu, 19 May 2022 08:03:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrb8P-0006MH-Rq; Thu, 19 May 2022 08:03:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrb8P-0007tH-Pu; Thu, 19 May 2022 08:03:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrb8P-0007hd-AT; Thu, 19 May 2022 08:03:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrb8P-0000c8-A0; Thu, 19 May 2022 08:03:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DVxIh0NrmbcFF4x0e9mzFsE8qw0ldZbDOnwkMh55BjU=; b=MkI0AohDZd5Hz1cmQshIemzDpL 24J4D76NozgUjH177SitpY35l0IUFC+tuIqchGegueXUhltvqPfJyzqRXtM0eEGulFzWRohWlsPzB R6w4mDh0bbt9OlzxfNqARmfNiGvuWhQl53EgCaVWB+3G0qqTvopHdHANj3d+jfbkx7kM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170560: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=1bd51b6afef633be2d79a1a83242dd7d79bd70d6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 19 May 2022 08:03:49 +0000 flight 170560 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170560/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 1bd51b6afef633be2d79a1a83242dd7d79bd70d6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 678 days Failing since 151818 2020-07-11 04:18:52 Z 677 days 659 attempts Testing same since 170560 2022-05-19 04:20:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 108622 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 08:13:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 08:13:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332786.556547 (Exim 4.92) (envelope-from ) id 1nrbHr-0007u6-TG; Thu, 19 May 2022 08:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332786.556547; Thu, 19 May 2022 08:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrbHr-0007tz-QL; Thu, 19 May 2022 08:13:35 +0000 Received: by outflank-mailman (input) for mailman id 332786; Thu, 19 May 2022 08:13:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrbHr-0007tt-G1 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 08:13:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrbHq-00083A-Bg; Thu, 19 May 2022 08:13:34 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrbHq-0008GO-5H; Thu, 19 May 2022 08:13:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N58ydY1mQnPE18529/sv6+YtSsgLIZYHPOhZdC7Pxbs=; b=lOWI+xHI7AMOk6aYKNzkOmmcTc bpMfD9E6vxwYMYgmu2sjBUcZoWjOTd+pLwP/rGivk3/UjK60jQnGTYYMnT7RaNlbYOG7bwCc0IGe0 /Coxi5hrqowvmh1Ig9JPN/OmHmBvIsF6Lt18VjvPm5ETo9f98GAC9Xv/oK4lDsxlxmy4=; Message-ID: Date: Thu, 19 May 2022 09:13:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [XEN][RFC PATCH v3 10/14] xen/arm: Implement device tree node removal functionalities To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, volodymyr_babchuk@epam.com, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220308194704.14061-1-fnu.vikram@xilinx.com> <20220308194704.14061-11-fnu.vikram@xilinx.com> From: Julien Grall In-Reply-To: <20220308194704.14061-11-fnu.vikram@xilinx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vikram, A few more comments that I spotted after reviewing the next patch. On 08/03/2022 19:47, Vikram Garhwal wrote: > Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using > device tree overlay. > > xl overlay remove file.dtbo: > Removes all the nodes in a given dtbo. > First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes > in dt_host and delete the device node entries from dt_host. > > The nodes get removed only if it is not used by any of dom0 or domio. Can overlay be nested (let say B nest in A)? If yes, how do you deal with the case the A is removed before B? [...] > +long dt_sysctl(struct xen_sysctl *op) > +{ > + long ret = 0; > + void *overlay_fdt; > + char **nodes_full_path = NULL; > + unsigned int num_overlay_nodes = 0; > + > + if ( op->u.dt_overlay.overlay_fdt_size <= 0 ) From my understanding, FDT are typically limited to 2MB. At minimum, we should check the overlay is not bigger than that (to avoid arbirtrary allocation size). I would possibly consider to limit to lower than that (i.e 500KB) if there is no need to have larger and to reduce the amount memory consumption by the overlay code. > + return -EINVAL; > + > + overlay_fdt = xmalloc_bytes(op->u.dt_overlay.overlay_fdt_size); > + > + if ( overlay_fdt == NULL ) > + return -ENOMEM; > + > + ret = copy_from_guest(overlay_fdt, op->u.dt_overlay.overlay_fdt, > + op->u.dt_overlay.overlay_fdt_size); > + if ( ret ) > + { > + gprintk(XENLOG_ERR, "copy from guest failed\n"); > + xfree(overlay_fdt); You free overlay_fdt, but not in the other paths. > + > + return -EFAULT; > + } > + > + switch ( op->u.dt_overlay.overlay_op ) > + { > + case XEN_SYSCTL_DT_OVERLAY_REMOVE: > + ret = check_overlay_fdt(overlay_fdt, > + op->u.dt_overlay.overlay_fdt_size); > + if ( ret ) > + { > + ret = -EFAULT; > + break; > + } > + > + num_overlay_nodes = overlay_node_count(overlay_fdt); > + if ( num_overlay_nodes == 0 ) > + { > + ret = -ENOMEM; > + break; > + } > + > + ret = overlay_get_nodes_info(overlay_fdt, &nodes_full_path, > + num_overlay_nodes); > + if ( ret ) > + break; > + > + ret = handle_remove_overlay_nodes(nodes_full_path, > + num_overlay_nodes); > + break; > + > + default: > + break; > + } > + > + if ( nodes_full_path != NULL ) > + { > + int i; > + for ( i = 0; i < num_overlay_nodes && nodes_full_path[i] != NULL; i++ ) > + { > + xfree(nodes_full_path[i]); > + } > + xfree(nodes_full_path); > + } AFAICT, nodes_full_path is not going to be used by the subop to add an overlay. So I would consider to move this within the case or (even better) create a function handling the subop (like you did for add) so we don't end up with a large switch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu May 19 09:21:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 09:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332794.556558 (Exim 4.92) (envelope-from ) id 1nrcL4-0006GN-UY; Thu, 19 May 2022 09:20:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332794.556558; Thu, 19 May 2022 09:20:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrcL4-0006GG-Pe; Thu, 19 May 2022 09:20:58 +0000 Received: by outflank-mailman (input) for mailman id 332794; Thu, 19 May 2022 09:20:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrcL2-0006GA-Ti for xen-devel@lists.xenproject.org; Thu, 19 May 2022 09:20:57 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa611338-d754-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 11:20:54 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 May 2022 05:20:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MWHPR03MB2525.namprd03.prod.outlook.com (2603:10b6:300:b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 09:20:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::ac51:a410:14d4:de37%6]) with mapi id 15.20.5250.018; Thu, 19 May 2022 09:20:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa611338-d754-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652952053; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xX+CmuWrdjZ3pZxe86LUf+HCDOnuKvTuKvSKG1d6y/4=; b=frIAW5g1zAB3vUztOVwpw5LWm54bB3AMjlSL/34cBK5uEObgpT6dLOgo w0P4zbr3+JUzrpz9M1qXDEAve8lye6cs/ykExGUxS1hwTjdhe1rJqkpx8 +M2rvPTs1A64CLI3Ruj7MmSxjr4HPpR1u+DzCqaaaIdIHsDo1+D9tcb2X g=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 72072189 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xyqpJ6CiFum6KRVW/+Diw5YqxClBgxIJ4kV8jS/XYbTApDsihmQHy 2sYDG+FbPnfMzT9c99wbI2wp05XuJCHy4diQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgh+ PFsp6GgFzsPM4PGxPs6Cz1RHSthaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcH80m5vcBtNs0rulIEezTe Iwybj13YQ6bSxZOJk0WGNQ1m+LAanzXLGcA9wjM9ftfD277ziBLzafDCNjsfMGjf+lwv2i3v 0LJ1jGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW7xHEXCRAQfUu2p7++kEHWc8lEN 0Ue9y4qrK4z3E+mVN/wW1u/unHslgEYc8pdFas98g7l4qjJ5UCfD2sNTD9EYfQnstM7QXoh0 Vrht9DkGz1p9qGUQHS197GIoDf0Mi8QRUcSaClBQQYb7t3LpIAokgmJXttlCLSyjND+BXf32 T/ikcQlr7AajMpO26Dl+1nC2miovsKQEVJz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6zt3OH06bK3I6Qcyg== IronPort-HdrOrdr: A9a23:wrt5Hq7ul50P1tvqhgPXwZeCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+873WBjB8bZYOCAghrnEGgC1/qv/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIUurIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonSs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaAkEyzzYIbiJaYfy+wzdk9vfrmrCV+ O8+ivICv4Dr085uFvF+ScFlTOQiwrGoEWStGNwyUGT3fARAghKS/apzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jdiuCQlGc1sRKEkjQpo+a07bWrHAUEcYZ xTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYEit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tTKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG6fIx8Z0Wb9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqbJbp0 X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="72072189" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Frg66Mmbbb6XL3x/n3Q/F4eBVC2eh5Ohr288BmZQIMAoP5MmwVCWDZ8/ERhDzb99vcByxG3nNw8gJy9WJRKWv8flxgVguBZf/1Q+PwnmQLVuMT2BqET5d2B/m+BQqTPXaT50bzDIUPHVt/dvnC6E8IOECg/wbT2IEvXZh6/Afqba+FjXpLa2AncduUT9ZiBSYCkCdJdh/6aRXGb3Glx+aJjKFVeCHcDMMZSOsVr4s9soBsoPtCvKsuY8m4vzhOA4E9eRqaxudiJEO9bPfjwm1CdmtE224I5iVRmQS8WXREC54fZLBcy7z3VF40gvWEh9zH3yEqaUFEiJrZGIz14jqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xX+CmuWrdjZ3pZxe86LUf+HCDOnuKvTuKvSKG1d6y/4=; b=QztCRGiwAJy29VxXlqylV41J0rYw7qvwvWPhmbKn+ztatlFhF48Yw/2dNOjmNq0vGsPRx+pI3HA2aCycXy4NEastW44OlELul9RgL1JyZzcACCf+4IvUDQAOmuh81dtz1jDltqCxDvTNv21BNneuzYSOh3UcRjFEskLr4Ol+yVY4Uqm24HbRnlG97bQ5Zjrvl6mmFEvNSn6Xu+9EKvFzpgz3EFSQcNR//mdYyl5uOlKHzkMB7zgCaEcRSBWLmGHjkzLbKnyRTrNdACUi5lnkeVQSTMJI5wAbXFtcJoYUkvztVWoLzvhzNT3izjdLayS4CiS2xVJmB9gOdSANEBlIOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xX+CmuWrdjZ3pZxe86LUf+HCDOnuKvTuKvSKG1d6y/4=; b=mNXjwXaX2qT53OX/FTQeFFRN0As4ZjfWBkhgH+srik4ZScgBNKXJoFCDp0aRyiYQZq3AbHiO42lAhsvREnhS66t4FXdsfgD/FBfP7RiPaOmI+oIj9ur6hB/0w8w9KHhzpyv9qALN5jT0x5JZcvdQaN4aiuqVobs45AS2NZaxGzo= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Thread-Topic: [PATCH 2/2] x86/vmx: implement Notify VM Exit Thread-Index: AQHYafEfUx0WfCMplEq6U+wPIyhlOa0lVccAgAByO4CAACeOgA== Date: Thu, 19 May 2022 09:20:48 +0000 Message-ID: <590b57f6-75ea-73e4-5267-b2ec63be9f97@citrix.com> References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bce2d61c-9981-4345-e74d-08da3978dca4 x-ms-traffictypediagnostic: MWHPR03MB2525:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JMjpDd0IMth9qMJu2mJGGN/OJHXJQ/9sGe2hfihZfnFz4lVu07/CNIieEbCkhxCZK/gb8iFu2r3mzWhmOvbJLPp9s76aXR8XztgKh+tJrTLf4aKZXKb23n0Vl4Hi4pz+5tkKygv5BgZ5Eu78df/TVyYZbJ3bHzl0M27emlrmdVB1EDgKm6Fu5LsM8VCMTWbuDq0+HzFqrIFcdpsKknKh3MU+EG1mDbK7ILne9NcHkx9RoepEaWCfyJfchKdDqhksFVDealEYmT83mnOJYkVs6ZUeywUlULk5bKKWX9Yp46aZ/xq+4e6167NMx0r5ZZf3256plwnW57RvAWRJ+TooXW9OWK5E2e0JiGnxxV8IZDl0Qt0uuEDFmN9RUA8b0XuVUpg30NaZEi+FKEyBtWTdN2WbNXPwQxKsKUWdO16CghFKD5hxCRdHpmg+sVRvimtAL00pXTT+o5P53IvZo4kGXL6dTSShN1pTHjHXOsIiBPYdnr3jkNN+Ro0cN30L1HyVzMMZSx7KFwBMpZDk/ATfAV+FVvEkOV5In/RZDb08tu/yjbSuo7c2gFsLQPXqhWtqWdHRyU4+rRbIfKt7ClTps9i1DtUvd9xz2InbCCBejW96UQ3eYEsCRMsbXLWnVOuaVoXYdoYhpOhCfGgW2L+NY72dvRx171tm0xUHxY1TqjblpDwZ9LmbqIIWRL4iuWlV4pjwT/1BjM3y9zwRZOlOSASZ8YDZDRtt1Q87I9ZbV9Nq9Mnt1fG1jVgie8q+YfQ+LVRAXxdBY4OEWwnIxYJf/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66446008)(53546011)(66556008)(64756008)(36756003)(55236004)(91956017)(316002)(31686004)(83380400001)(6506007)(5660300002)(2616005)(71200400001)(38070700005)(8676002)(4326008)(82960400001)(26005)(31696002)(6486002)(8936002)(54906003)(6916009)(6512007)(76116006)(86362001)(186003)(2906002)(66946007)(38100700002)(508600001)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eERpU1hWdHlWM0pzcFJlTWVMbVJ5MG1udDVVUHBPVkY1WkFPNzlINXgzU1V2?= =?utf-8?B?MGMzVnFmWEgxWVg5dWh6VlptRDJMVWtyS0V4ZDNCR1cxMkJtaWVzMUNpMTFa?= =?utf-8?B?R2E3VXA5VTRyamVkU2hwUVJFMERQWm1xTWh6VWdMeGJYMWd3WkJqdDkvYnRl?= =?utf-8?B?QWszSUxPR1d2MFlPR2xqcnFPM2g3Yk1MQWEvOERHYU9UU05wa0M1bTRGdUxo?= =?utf-8?B?OGdTWlZPcDhpN1MrdjhxSHNoSGhyMXBRRU42cDNxMDBkTGRacWpXUGFRYnNM?= =?utf-8?B?RGpYTEl3QVJXWUo0RXAzbjhwOWxzUnMzSmZBMEJsYmErWENtbUpWZG4yNG9z?= =?utf-8?B?WVBJemgxbGhKWUxHK0s4bk5SZ3Zac0JsaTgrdnlab1NnTWFMb3phOHpha3Q3?= =?utf-8?B?dXJkQWhmaFVxSjFoLy9ibXNVSTcwcHFCdFVzOC8xNjVrK0dMOFZ6YUFiVk5Q?= =?utf-8?B?K1RzM0lIeE1oM1p5RU0wald3VnkwOUs0aGlFRmxXa2hGdURicm1INm1FZk9r?= =?utf-8?B?aEF2dXBOVTAzSUYvS0JUKzlYd1pKVHN3S2JtSWE2c3ZVVndxUGhSZ084bGI5?= =?utf-8?B?MkI4OC9ZU1hKc3JUc09xM0tSd05zQVN5QXU0SGkzQkRGeFdqM0pNaTRsRFJC?= =?utf-8?B?ZEE2bWZoUU52SzNIK1hDbGRKMEZ1eXRYbURCTWdka1VKQURJYUxvdzRiOEF5?= =?utf-8?B?MmU1bk5wNDZRTkJiV0E0OUg1S1NJbmxNSTVMbFhrS0FXblEydzJ1MHhqWTQw?= =?utf-8?B?ZS95Tk1GblJsbGQrV1psLzJOSFRHNWpDbHBOb2ZMVDdVODJobTVrRUtpWmpT?= =?utf-8?B?MjFOWURGQUxIeHBIdEp0c0JBUEJ5NGVOa0FHb0pQLy9NQjJyZDFUTlNhTFpG?= =?utf-8?B?clFFc1k1cEJ0YTV2SEIwRWUvMC9zUUIyV2xQbEN6a1B0ZkhMQStKMVQ3KzlX?= =?utf-8?B?OUVtb3lRV0tOeXVhWFVFVSt2b0VFTGhrNG1FQmJUM2puZUF6NU5kOFdhanJV?= =?utf-8?B?OWs1Y0hhOUQzd09PQVgzeW5KNjlhUUtsS1JqY3prZGpVMkhVSVEyNWFyOGZn?= =?utf-8?B?b2hBczEraWFoaWFCSUloTytReEkrSzNVU3QxNmJ6RHd6ZTY4OWlCT3VWNWJH?= =?utf-8?B?U0Y0YlBjZWdjUGEvR1k0MHU5K0l1cjd1UlhoQkcyT28vZGVXRUo0ckNBMG9a?= =?utf-8?B?cGxDdEp5ak9Ga1BkWXdvWjdvOGt2UmRpUzVRNVg5WE94K3lpcXhpUzhsY05p?= =?utf-8?B?RWpGeE1QZXZ0UUkvb2hUazhMdGU3OTNueGNWWURQdEI5YVRPcEJzeTZSTkZq?= =?utf-8?B?cU9NNE1aak5sWmwvQXRtTkhSWWZOTTh0cTZwQW1xcENsMDk5M2V5WmhJUWRr?= =?utf-8?B?cWxQTDVDSXFtUnlhZUNtK24vcWlNcUNtSUIrZWM4Q3BPeWFTZDhqamVIOGV6?= =?utf-8?B?TVlpZzc5UkNlVGc3UHJMVWlhZkxCOGVDV0NJSEJwUVdKUTVybVlKUzhJaTJF?= =?utf-8?B?V0paMlErV2QvQUVLWE1XenZMWCtKY0VKUlVJbXFNZ3B4TUVWd1gydHJDRFdS?= =?utf-8?B?eVRGUU51cnZFWVlTWVBRSEhJZ1N5RG81VHJBcVIrbDAyc2l4TUhLQSsyY1dh?= =?utf-8?B?a3ZUQTBjVktuWTFoeXBoaDFncEh6bW9IaGxrUFJFQXRIM2J2R2JyL250Y0pn?= =?utf-8?B?ZHgxZGtXWW9Dc0hqNzhDRGZwa1hHUU5Ya2VRY3RiamR4dUM0RkVyd0ZrcjBM?= =?utf-8?B?RVZhTVhrWjRycnUvNEY3emw0akd2eFRiMkVIV04va3lEY1dQTks0eWllWURi?= =?utf-8?B?cVpNZ0dYbjczWW9kTUNjQXpiSVRqYXBsSmVlTFpGRU0yYmgyK2NSRDVKSTlC?= =?utf-8?B?RUpUV1cwRmtrOXNrRkNhYlNEMjBMZUNzUTR1WVF6dnhIV1hlSFRtM2FabE1S?= =?utf-8?B?YWR3ME1Pa0tsUVRQRHM3UUZYUHkrWVJudDVsZm5EY0lkUXJNcnVZRm1ndFYz?= =?utf-8?B?Z2Rwb25NdU5OZEV0UlF5UHVkaDc3ZU5rem1CZ3R2SExMd1BXUS9IMzRKM2RS?= =?utf-8?B?NDlzTCszNWw5MURoSjh3UGxlK0ovaVBEaTZvaWRWd0E0QnVraGxxTjlTRjV0?= =?utf-8?B?R0ZNblJoTWZnRWtEV2w5bExZSDgySllLd1p6OFpDTmR3akkxeWJyUGQvN3VC?= =?utf-8?B?NmVGNGI5L0tmbmdGOFFyeEN4WnBwbE40ZHF3NGlIT0paMmhPQ3E1UHZVTWl1?= =?utf-8?B?dk16WUkzVXNVajdjNlBYd0FBOUR4R1Q3ZGg0dWZGSzNuL0RuZFlOcE5WWndL?= =?utf-8?B?ZVE2RTZhY2dwdnNSRTVadmF1WWJvZnoyL2VZMDM1Q1dlbm1pM0pOZz09?= Content-Type: text/plain; charset="utf-8" Content-ID: <89AE616AE100C644BA2CB1F1989B0A53@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bce2d61c-9981-4345-e74d-08da3978dca4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 09:20:48.6531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iM0BG3VDsHIHl6OaWCfTOCJg5T9CY8K1MCzORJcCO268+USoht/x/cpcb+74wRXDNiO+/4WKS7RYx9PVfxYHlAZS9wDiBrXOeBji1ACuxn8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2525 T24gMTkvMDUvMjAyMiAwNzo1OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE5LjA1LjIwMjIg MDI6MTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNy8wNS8yMDIyIDE0OjIxLCBSb2dl ciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4gVW5kZXIgY2VydGFpbiBjb25kaXRpb25zIGd1ZXN0cyBj YW4gZ2V0IHRoZSBDUFUgc3R1Y2sgaW4gYW4gaW5maW5pdGUNCj4+PiBsb29wIHdpdGhvdXQgdGhl IHBvc3NpYmlsaXR5IG9mIGFuIGludGVycnVwdCB3aW5kb3cgdG8gb2NjdXIuDQo+PiBpbnN0cnVj dGlvbiBib3VuZGFyeS4NCj4+DQo+PiBJdCdzIHRyaXZpYWwgdG8gY3JlYXRlIGFuIGluZmluaXRl IGxvb3Agd2l0aG91dCBhbiBpbnRlcnJ1cHQgd2luZG93IDopDQo+Pg0KPj4gQWxzbywgSSdkIHBy b2JhYmx5IHBocmFzZSB0aGF0IGFzIGFuIHVuYm91bmRlZCBsb29wLCBiZWNhdXNlIG5vdCBhbGwN Cj4+IHByb2JsZW0gY2FzZXMgYXJlIHRydWx5IGluZmluaXRlLg0KPj4NCj4+PiAgIFRoaXMNCj4+ PiB3YXMgdGhlIGNhc2Ugd2l0aCB0aGUgc2NlbmFyaW9zIGRlc2NyaWJlZCBpbiBYU0EtMTU2Lg0K Pj4gQ2FzZSBpbiBwb2ludCwgYm90aCBvZiB0aGVzZSBjYW4gYmUgYnJva2VuIGJ5IHNvbWV0aGlu ZyBlbHNlIChhbm90aGVyDQo+PiB2Q1BVLCBvciBjb2hlcmVudCBETUEgd3JpdGUpIGVkaXRpbmcg dGhlIElEVCBhbmQgZS5nLiBtYWtpbmcgdGhlICNBQy8jREINCj4+IHZlY3RvcnMgbm90IHByZXNl bnQsIHdoaWNoIHdpbGwgeWllbGQgI05QIGluc3RlYWQuDQo+ICJDYW4gYmUgYnJva2VuIiBhcyBp biAidGhlIGxvb3AgY2FuIGJlIGZvcmNlZCB0byBiZSBleGl0ZWQiPyBJZiBzbywgaG93DQo+IHdv dWxkIGEgcmVtb3RlIENQVSAvIGFnZW50IGJlY29tZSBhd2FyZSBvZiB0aGUgc2l0dWF0aW9uLCBh bmQga25vdyB3aGF0DQo+IHRoZSBjYXVzZSBpcyAoYW5kIGhlbmNlIGtub3cgd2hpY2ggSURUIGVu dHJ5IHRvIGNsb2JiZXIpPyBBZnRlciBhbGwgaXQncw0KPiBndWVzdCBzdGF0ZSwgd2hpY2ggd2Ug d291bGRuJ3Qgd2FudCB0byBhbHRlciBmb3Igbm8gcmVhc29uLiBOb3Igc2hvdWxkDQo+IHdlIHB1 dCBhIGd1ZXN0IGluIGEgc3RhdGUgd2hlcmUgI0RGIG1pZ2h0IGV2ZW50dWFsbHkgcmVzdWx0Lg0K DQpXZWxsIHF1aXRlLi4uICJDYW4gYmUgYnJva2VuIiBkb2VzIG5vdCBtZWFuIHRoYXQgdGhpcyBh cHByb2FjaCBpcyBhDQp2aWFibGUgc2VjdXJpdHkgZGVmZW5jZS4NCg0KSXQgZG9lcyBoaWdobGln aHQgdGhhdCB0aGUgbG9vcCBvbmx5IGNvbnRpbnVlcyB3aGlsZSB0aGVyZSBpcyBubw0KcGVydHVy YmF0aW9uIHRvIHRoZSBtZW1vcnkgYWNjZXNzZXMgaW52b2x2ZWQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu May 19 10:24:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 10:24:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332811.556573 (Exim 4.92) (envelope-from ) id 1nrdKc-0003tk-JO; Thu, 19 May 2022 10:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332811.556573; Thu, 19 May 2022 10:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdKc-0003td-GD; Thu, 19 May 2022 10:24:34 +0000 Received: by outflank-mailman (input) for mailman id 332811; Thu, 19 May 2022 10:24:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdKb-0003tT-HL; Thu, 19 May 2022 10:24:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdKb-0002Aj-D3; Thu, 19 May 2022 10:24:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdKb-00074h-2C; Thu, 19 May 2022 10:24:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrdKb-0006Vr-1U; Thu, 19 May 2022 10:24:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SwBioqADd+OLIMni5w5HtkcLuoqPsJSYhbMqoWFndIE=; b=f6LBOxwMPSWc32GYqV+NUYdnMT EF47qOGKDu3Zv8q66bstYsCGuo1667Ie/09nA0d7JNUGa9h/2S/jT9nCqB0iC9lq+Pesv+/U9SSHj nzA8op0yfqVFh15QjcHW2sN89NGV9btk6rGsWV0V9EPoFMz95Yug1qnzJk6PVDeYnqHU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170567: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 10:24:33 +0000 flight 170567 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170567/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 79 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1097 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 10:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 10:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332821.556584 (Exim 4.92) (envelope-from ) id 1nrdSV-0005Jt-Eu; Thu, 19 May 2022 10:32:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332821.556584; Thu, 19 May 2022 10:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdSV-0005Jm-B9; Thu, 19 May 2022 10:32:43 +0000 Received: by outflank-mailman (input) for mailman id 332821; Thu, 19 May 2022 10:32:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdST-0005Jg-Tm for xen-devel@lists.xenproject.org; Thu, 19 May 2022 10:32:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 020c6488-d75f-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 12:32:40 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-Fiy5J7WUO7iDUpTAfkAEpA-1; Thu, 19 May 2022 12:32:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB2907.eurprd04.prod.outlook.com (2603:10a6:3:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 10:32:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 10:32:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 020c6488-d75f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652956359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eRcYCD5M3FR7ndpQdaBQaABts0RuTBNmeFNj4DwBthE=; b=gTpFlVwTunlxex1V/9/wTLPtF/qyzii5SLGm3k94PQ5/VcQ75GUPKBH6c0tR9+rB7Gehag zeibQJvN2PuLPaOF9ocRy7BPTW3erRfgkj/sPKSStMDTcDxI0BDZ4XVphG1j4eqgCpD9Vf w7U0QzAvnMHNrUaV8mtKSym8DMNnXfU= X-MC-Unique: Fiy5J7WUO7iDUpTAfkAEpA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Is8R2LvF2RoF+WKAcSupsewKMncEgpSPDgC4u57SbMzJIMH2se9Sw40TXIaCz/BJ3uZ1AnwvY/BGlUMWAqfiAYgEv6n2k78mNrA+czUvPRHN6B09r+E0q8P9b5G5YedkXsdKDFFGfbZKJRyB7zpvHeWRSa6MkHL1LUvsXMngtlUuK7aa6761FbL/k/V4cb9WH39GJS+WghQQKBufq3bbIt4OzBBlb5ffcn//pL0vFOGO6jT1izkYpQgipCizNnxh2ypncGkOdPfu7JZ7MTDhNhrNLoAJ9xjRpjX9/7LMXuo+lAIoz6PaXDqRTRRjLDt9X0CFMXRRwPBueIQrqnYbAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRcYCD5M3FR7ndpQdaBQaABts0RuTBNmeFNj4DwBthE=; b=HhaW+hrQjA0PBmbYsQZ6iVHg/RFJxVBP8mQYFwCeIX7FyPdpFJB/3wu3e+4+qSQoSKD/BAqgb/bDUyo15KiY6Idex0048yurC9j2HjKVb9RZkQW1Rrb6FzU3TJzmJP6ddMxh7xKdx/tBJtt4Iv8Yfunxf7Ecpe26RHCJSjHHV8Q7CwltQBqOx73I3KtymeBcibS0DIDkr9/krlsMFmF/B1gqGMqBJuYy509MHBHr0vlSDMHXTz81l9+GzAphoN90PbMjUJCeK4pVh7h3/5qXOBiFjuLchtyZKD49DH/WMYK8EZzw4eYgzdMZeMgcLzTYfIrfnLhyzUU0sZkxXDr7OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> Date: Thu, 19 May 2022 12:32:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour References: Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0031.eurprd06.prod.outlook.com (2603:10a6:20b:463::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b1f48de-0c34-4125-d2ce-08da3982e3f5 X-MS-TrafficTypeDiagnostic: HE1PR0402MB2907:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ch7EimI0CdASbDEjYtS61/f58RZjBummLSoI3k9P5+lOLswtPo7NwRsdesHRR+JktDGz1HMzPdnh3M0WX1QjM5wyURwQmSk3QvdI0q8kfXD8v2Prluu3u62kIjWtrHi7sQLAqqnCuFDuf4Xtn9/jYzIWOm84WhlMim4jV6sYUBMfptMLwFvQjb+1XHJmb2ABY2zh0UdaTkDd5np3OBILmOwfHo1ORlnZTmwOyYvITHeDAynRpkFDuMlkHq1/2WK2hz3VtgmmB5NcKdEFVC1JbVeQ2GD55FcLBNJLgx8Y9HqCmKwJHlLQbMymKaFQQCSYAPMZ6HY7ht9xLvPFqrh+VoHd023i8fAl8f48nLEYyOhIEahfoHKPxF89ztyYtPjhk7uV+jXxv+BRCql4JiolTOPY9Eh4pJgU8KZg/Fs/1aRnaKydQITN95E6C+r4Zid/ss+1d2tGFv5SMfOUlwIlU7xjwhysoFyG7mEt7cI2BX3cZSEU65NskfT2DPaWbpJzEdV4NR0N0gk6SZZ+nHPO5zEfBNV8BGANvFUb9R6EXBXjoo40eX0KpQx7Pd4sA+10iQl35u+tqiDxB0eunvDoGe4TsQQ4bomXIa9WDFZMpL+iYBeNzXckEs/1BpVdrOXDvzQ/9inGWx90UKkcPPXbeptwyzoENSF5y7ApPJ+VDDJwVOGkQ0QH5wXsBCc1oJhRwNlz2qpWW5ofdVMKF/duRee4nrkrw4FbZQTafV18Bj8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(186003)(2906002)(6666004)(53546011)(2616005)(38100700002)(4326008)(83380400001)(6506007)(6512007)(26005)(31686004)(36756003)(5660300002)(8936002)(6486002)(508600001)(316002)(6916009)(8676002)(66556008)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXVPNUk4NGVoRGVVa3JNNHlxVnZoQ2tlYmlNUitGT1Q1M1dwOWlNMGJIOUpK?= =?utf-8?B?RU1ybFZaY3hkWHRJNFQ5V0x3anF0dWZEd253dDVabVpqU0dGUDgyU1RjOG9i?= =?utf-8?B?bElTaU4yN3gza0NOMFJsZTNBWjgvYU1VbDlPZG5GOUQ1MWM1RnlWUzlybXZM?= =?utf-8?B?bzZORmFEQ0M2MVJpekF4eXV0ZU9MSzJIOEpXeHR1NXl4RmxkVXJsRnZ0WVlx?= =?utf-8?B?RXIwdjE3aFQ3K2cwYXFVZWhETVVQalFBMHVHYUFXK3VpbzhRYzhnaUsyTnhJ?= =?utf-8?B?SjE5UzkyRGZMNTZQSVY3b2p1eHdPWHJaVEh3YjNsVVRKcUZ4cURaNndKZ1ND?= =?utf-8?B?QzI2cnNxNW9pWFBEeTRYMk1yQmxLMytXcVVXTGtlZGlPcDR5OUkva1Z4NG5y?= =?utf-8?B?VFI2d3ZzaU1HRThSUjl5eFFPSDcxaWVYWDIrNEM2cFNmNXpNd09FUzgveXk5?= =?utf-8?B?cUxtektUM3pyQkJnM3NkOXZyU2Jqbm1FcTFEQ1RZemdqSkttaGpPMkp4aWxI?= =?utf-8?B?dUtQNmQ5ZDBxK0pubklwMlQ5Q1g3S09IczVjUHB5QTNYTUVyOXJLcnRnK2VM?= =?utf-8?B?ZWxCMWtyanhZUWhPTnV0dng1Zm9hV0ZpWUkxU0Y2QlQ1eDZ0UVEwSWVQVTdY?= =?utf-8?B?VFJ2SExPQmhxSXEwbS9mZVA4eHhUNUxadHUzV1ZtV05Vd0huTDlGazlJMk95?= =?utf-8?B?NHRVUzN0Mk5aVm1KZ1BKZ3VBTjVjTzBkZ28xSkVRTXBOU2xjM1FLdGhGUkFJ?= =?utf-8?B?dmZLaEdBM0kvajhRWkZYdzRMOFpZOWtnTGxTUmFYaVZnU2FYdHBxUzY2U3RN?= =?utf-8?B?aGIzblpLZFpSWTRCclJ6OEIzU1FOa2tqRWI2VkhxTDIxeStJeFZoby9wbEpx?= =?utf-8?B?OUFYOUtFbnh1c2JIZjlzTGp4U09aemp1aDRtTUpmOU9lSTNCMWg0cWNwLzVB?= =?utf-8?B?enFPZmgzOSsxSldJdHNQa3IyNFUwQ2hXQlllcGlnZlBqdnA1RDV6b2FZdzhq?= =?utf-8?B?dW4vbnY0V2tqSnhYVEhaekVtcjMyUjR5dWhHSS9uYUlmTVVKVWJ1YUFTMGh3?= =?utf-8?B?alFpYXplUUdqNW0raFgrQi8yMHZBbUN0Vi9kQThpR2g0bHdlalppVmdoU2hl?= =?utf-8?B?NHl0dC9IQk5pY3B6a0hZQklaRzZyUjZoaklwTzkwWGdDNVR3ZnFKQTc1MVFz?= =?utf-8?B?bytRazhBeGd2OVZqTzJ6dlk4RTFoMmFqZGc5RGU1eTNSNktMYUFsaGU2M0l2?= =?utf-8?B?YSs5enhSN3Zqd0dOUXZ4TG1aMjlUbUh4NThJU0hCWnE5dXZuZElmVk5xdVZD?= =?utf-8?B?MDFKanR3eEFEdnd0YW1xaGRNb3lHbVZWK1lVcEJiNFozMXgvOWhqYmZoWENS?= =?utf-8?B?dFpEU2gvRUVodE5uRVBBUUFFRmJ5eUN1SjVnaE9OMlFDak53Vkp3VWhFR3JJ?= =?utf-8?B?NVJiUmc2WmFzbVhza3hUcTRieW9sQmgrQkFTVDFFR2tWWXQ5aXZTSXdydTg1?= =?utf-8?B?L0dCYk0va2J2TW9maTFQNFhLdjlGWHZHWTQ2WVVDOUxpMUI4MHRCVUJ4di9O?= =?utf-8?B?NlpwVy9OeTg4cm0zNEhzWmRTL0dUZ0VMdFFkZ2thcnZvKzlFVnoxbEZodk5F?= =?utf-8?B?cWVYcnRTckZsN2JOSmJZRDFuVFhnSGJldnlmb3lEWUhMOWNMR1hPVmhYbXFp?= =?utf-8?B?OHRNUHo1OFRyMGN1Z1BpRDRraXUwaFJtMGxoaFZSUGNUMERnU1ZvczdicUs0?= =?utf-8?B?NnZYZm52V2U0dCtHU3dDcmtaUnlmL2hJYzRRNHVBMXRMRGc3aWUvb0tVbS8y?= =?utf-8?B?eXhlNE16U0hEdkNXQk5GQlRrOCtHMi9jQlRpWFYxUlA1eFZ3UUgzTlA4QzBs?= =?utf-8?B?U0JJVng3N0VaZ1N4aTZmQkQxWHRlaDA5dGxBb0FqNWdDOGpNemFuMlJSekky?= =?utf-8?B?WlkrK2kzREI4VkxKWm9nTWxxZnI4MWtrRWd4YU5FYWhOS1pBT3ZCdzV6NTZW?= =?utf-8?B?TWVMSnJ6NjZsS1FCbUV5K2loOFNRd3Q1YzZ3OFBMcnlyeEVLU1FRcmV3TDht?= =?utf-8?B?MWw0d1ZiMHFTYXV1YmdpTVBTSWRickozVENUL2pEWWtTUjlVbmFudExCaCs0?= =?utf-8?B?d1drTVl1OHZTMVJkc2QwRjB0N0tzUHY2bkxrVjZrYVlzd0syM3hyVFNObG5v?= =?utf-8?B?WjVsUWg1STFGRmlBaFpxYy9zbXE0NWxrMTFNdGIybVVueEJJeUhBNHJRRWN1?= =?utf-8?B?UzFnMXdmb1dBOVZjUUIzNnJCK0NaYmpDelh2am8rWXhZVnB4Z2EvZzNDaWtL?= =?utf-8?B?TmNReE9aTHJ6RVdGTnc1L0lnZkg5cU1JQXJGOFR3MDMrYUFCYTVDZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b1f48de-0c34-4125-d2ce-08da3982e3f5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 10:32:36.1916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5LvhZJ9WEkzT5UFnUlUDCqIe5LT1AZkCJb8nib+0hN+XSKMGUsh50hPolsbkIm1hj92CI/G1qmbwrTDqMD6yxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2907 On 18.05.2022 19:32, Demi Marie Obenour wrote: > @@ -567,6 +587,39 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) > } > #endif > > +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR; Just out of curiosity: It's an arbitrary choice to use this initializer, i.e. no initializer (and hence zero) would do as well (with ... > +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) > +{ > + size_t available_len, len; > + const UINTN physical_start = desc->PhysicalStart; > + const EFI_SYSTEM_RESOURCE_TABLE *esrt_ptr; > + > + len = desc->NumberOfPages << EFI_PAGE_SHIFT; > + if ( esrt == EFI_INVALID_TABLE_ADDR ) ... an adjustment here, of course)? > + return 0; > + if ( physical_start > esrt || esrt - physical_start >= len ) > + return 0; > + /* > + * The specification requires EfiBootServicesData, but accept > + * EfiRuntimeServicesData, which is a more logical choice. > + */ > + if ( (desc->Type != EfiRuntimeServicesData) && > + (desc->Type != EfiBootServicesData) ) > + return 0; > + available_len = len - (esrt - physical_start); > + if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) > + return 0; > + available_len -= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); > + esrt_ptr = (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; > + if ( esrt_ptr->FwResourceVersion != EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION || Nit (style): Overlong line. > + !esrt_ptr->FwResourceCount ) > + return 0; > + if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->Entries[0]) ) > + return 0; > + return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); > +} Nit (style again): We generally put a blank line ahead of a function's main return statement. > @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > if ( !efi_memmap ) > blexit(L"Unable to allocate memory for EFI memory map"); > > + efi_memmap_size = info_size; I don't think this global needs setting here, yet? The local will do just fine here, likely yielding smaller code. But I realize that's connected to how you did your change vs what I was expecting you to do (see below). > + status = SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, > + efi_memmap, &map_key, > + &efi_mdesc_size, > + &mdesc_ver); > + if ( EFI_ERROR(status) ) > + PrintErrMesg(L"Cannot obtain memory map", status); > + > + /* Try to obtain the ESRT. Errors are not fatal. */ > + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) > + { > + /* > + * ESRT needs to be moved to memory of type EfiRuntimeServicesData > + * so that the memory it is in will not be used for other purposes. > + */ > + void *new_esrt = NULL; > + size_t esrt_size = get_esrt_size(efi_memmap + i); > + > + if ( !esrt_size ) > + continue; > + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type == > + EfiRuntimeServicesData ) > + break; /* ESRT already safe from reuse */ > + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, > + &new_esrt); I should have re-raised the earlier voiced concern when reviewing v5 (or maybe already v4), and I'm sorry for not having paid close enough attention: This may add up to two more entries in the memory map (if an entry is split and its middle part is used; of course with an unusual implementation there could be even more of a growth). Yet below your addition, before obtaining the final memory map, you don't re- obtain (and re-increase) the size needed. As to (re-)increase: In fact, prior to the allocation you do there shouldn't be a need to bump the space by 8 extra entries. That's a safety measure only for possible allocations happening across ExitBootServices(). And yes, in earlier versions you had - info_size += 8 * efi_mdesc_size; + info_size += 8 * (efi_mdesc_size + 1); there, but that's not what would be needed anyway (if trying to avoid a 2nd pass of establishing the needed size). Instead in such an event you need to bump 8 to 10 (or at least 9, when assuming that normally it wouldn't be the middle part of a new range which would be used, but rather the leading or trailing one). While I'd be okay with addressing the two nits above while committing, this allocation size aspect first wants settling on. Personally I'd prefer the more involved solution, but I'd be okay with merely bumping the 8 (plus the addition of a suitable comment, explaining the now multiple [two] constituent parts of a seemingly arbitrary number). If you want to go this easier route, I guess I could also make that adjustment while committing (and adding my R-b). Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 10:56:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 10:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332830.556594 (Exim 4.92) (envelope-from ) id 1nrdpC-0007mL-Dw; Thu, 19 May 2022 10:56:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332830.556594; Thu, 19 May 2022 10:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdpC-0007mE-B6; Thu, 19 May 2022 10:56:10 +0000 Received: by outflank-mailman (input) for mailman id 332830; Thu, 19 May 2022 10:56:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdpB-0007m8-4q for xen-devel@lists.xenproject.org; Thu, 19 May 2022 10:56:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 452c8361-d762-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 12:56:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 452c8361-d762-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652957762; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Z4vRUXSAJaAL2sBFivCMDPdY3PI4a6wJUKemvNgqPcY=; b=I15lBeXEmqoU3XMb9CRDnJD80S2WYjNxbnl33d0DxC2lESr8UtFKopkX vTWx6VrLu6dnfJNvrwrc/3A9cXgnaqz8OBTM2/vaNKvym8GvJ6cKfu/lf 5qHeUoXcD4ZwfzUM/YAvd3VOeG4sNBadG4KQMhITTTQMdysPfq3IRG47M o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71054945 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:/p3MLqAX+aNI+RVW/0Xjw5YqxClBgxIJ4kV8jS/XYbTApDgmgmAHy mEdDTiPPvqINGb1eNhwYIiz8xgAvsCAyYBkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhqk MljrYadUz0QP/LKic80VRYGATNhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8XRauCN pZEAdZpRBadZgB2NUVONK4ZtreBuFOgImJR8k3A8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co WDL9Hi/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc hFKvHp1xUQvyKC1ZsKlQzOgulOehCcdBNxBOMQ851+f2LWBtm51GVM4ZjJGbdUnsuo/Sjory kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG5+OkOYgTzosGP+UJfpvn8AnnOz j+Dt0DSbJ1D3JdQh81XEb0q6g9AR6QlrCZov207vUr/t2uVgbJJgKTxsDDmAQ5odtrxc7V4l CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmCG0Qc1Q8R4qW/1k5JGQWy3yGguTHqFz+5eIWO5C KMtkV05CGBv0IuCMvYsPtPZ5zUCxqn8D9X1Ps04nfIVCqWdgDSvpXk0DWbJhjiFuBF1zckXZ MfKGe7xXC1yIfk2k1KLqxI1jOZDKtYWnjiIG/gWDn2PjNKjWZJiYexbbArWM7potfrsTce82 483CvZmAi53CIXWChQ7O6ZKRbzWBRDX3azLlvE= IronPort-HdrOrdr: A9a23:ULuLl6nI5DdCR/iH93rdhk9CVv7pDfIX3DAbv31ZSRFFG/Fw8P re/8jztCWVtN9/YhsdcLy7VZVoIkm8yXcW2+Ys1N6ZNWGMhIaxFvAH0WKL+UyEJ8SUzIBgPM lbH5SX1LXLfCFHZZmQ2njeLz+L+qjgzEnSv5a980tQ X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="71054945" From: Anthony PERARD To: CC: Anthony PERARD , Roger Pau Monne , Ian Jackson Subject: [OSSTEST PATCH v2] ts-xen-build-prep: Install newer NASM version, to build OVMF Date: Thu, 19 May 2022 11:55:25 +0100 Message-ID: <20220519105525.211344-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Recent versions of OVMF now need a version of NASM that is newer than the one available on Debian oldstable/buster. They want to use NASM 2.15.05 [1], which is available in Debian stable/bullseye. The need to use a newer version started with d3febfd9ade3 ("MdePkg: Replace Opcode with the corresponding instructions."). There is no backport package available but the nasm package from Debian Bullseye can easily be installed on Buster as it has few dependencies and are already satisfied. [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 ("BaseTools: Upgrade the version of NASM tool") Signed-off-by: Anthony PERARD --- production-config | 2 ++ ts-xen-build-prep | 2 ++ 2 files changed, 4 insertions(+) diff --git a/production-config b/production-config index 9d2e7e0ee492..b77763a19443 100644 --- a/production-config +++ b/production-config @@ -112,6 +112,8 @@ DebianExtraPackages_jessie chiark-scripts_6.0.3~citrix1_all.deb DebianExtraPackages_stretch chiark-scripts_6.0.4~citrix1_all.deb DebianExtraPackages_buster chiark-scripts_6.0.5~citrix1_all.deb libc-kernel-bug.960271/linux-libc-dev_4.19.118-2.0iwj_.deb +DebianExtraPackages_build_buster nasm_2.15.05-1_.deb + DebianExtraPackages_uefi_i386_jessie extradebs-uefi-i386-2018-04-01/ DebianExtraPackages_uefi_amd64_jessie extradebs-uefi-amd64-2018-04-01/ DebianExtraPackages_uefi_i386_stretch extradebs-uefi-i386-2018-04-01/ diff --git a/ts-xen-build-prep b/ts-xen-build-prep index 67b3eae62155..e76c0254bfd0 100755 --- a/ts-xen-build-prep +++ b/ts-xen-build-prep @@ -250,6 +250,8 @@ END if ($ho->{Arch} eq 'amd64' && $ho->{Suite} !~ m/squeeze|lenny/) { target_install_packages($ho, 'libc6-dev-i386'); } + + some_extradebs($ho, [ 'DebianExtraPackages', 'build', $ho->{Suite} ]); } sub ccache_setup () { -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 19 10:57:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 10:57:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332837.556605 (Exim 4.92) (envelope-from ) id 1nrdqg-0008Ln-O7; Thu, 19 May 2022 10:57:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332837.556605; Thu, 19 May 2022 10:57:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdqg-0008Lg-LE; Thu, 19 May 2022 10:57:42 +0000 Received: by outflank-mailman (input) for mailman id 332837; Thu, 19 May 2022 10:57:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrdqf-0008LZ-H9 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 10:57:41 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fb9bcf2-d762-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 12:57:39 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id A064E1F41C26 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fb9bcf2-d762-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652957857; bh=n5xuyUTKwTtfK1E3KUXlguxQHbXpNAqOc2gndpqI8jA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JodT7xtJhuDdpRliWmuR69V68cdLgMXYC8d7buT+z/skOa4D3K2ioz+upZrBg2HUI fFJ9Rn8C3zYLSF4itEkiZf4lAf9mhOFGsXHiH+NvNHs2flmyQC/4D/NcGC8PSQsOSO GcqoxRa4TTV0C4aYYrl2y+kEE4aiAR0BuXE3s+rTbSRmruSUiKG/62QN94HtkxPd8h 5hZsoL+SJmGw8nEPAF5+YZtOZrPZ6NRg8hcTQlgW4L/qyI+I5dRn80ayHZZC1Hf8GO mkG9ultCG+PShiWcqnTz48Dvqc3PWYvBoJFQUeF+LqJAZWbjIhdXyvsG+uqjGWPers YX5xODM5B4tmA== Message-ID: <43133a4d-8bad-93ba-c376-21d30d039b15@collabora.com> Date: Thu, 19 May 2022 13:57:31 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 00/27] Introduce power-off+restart call chain API Content-Language: en-US To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/18/22 17:46, Rafael J. Wysocki wrote: > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > wrote: ... >> Introduce new API that provides call chains support for all restart and >> power-off modes. The new API is designed with simplicity and extensibility >> in mind. ... > The v8 looks much better than the previous versions to me. > > I actually don't really have any comments on it except for the minor > remark regarding patch [1/27] sent separately. > > Please just send an update of that one patch and I will queue up the > series for 5.19. > > However, I'm going to send a pull request with it in the second half > of the merge window, after the majority of the other changes in the > subsystems touched by it have been integrated. Thanks, Rafael. I sent out the updated [1/27] patch to you. For the reference, the updated patch can be found here as well: https://lore.kernel.org/all/20220519105015.1195955-1-dmitry.osipenko@collabora.com/T/#u -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Thu May 19 11:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 11:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332847.556617 (Exim 4.92) (envelope-from ) id 1nre6h-0002Ih-6x; Thu, 19 May 2022 11:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332847.556617; Thu, 19 May 2022 11:14:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nre6h-0002Ia-2a; Thu, 19 May 2022 11:14:15 +0000 Received: by outflank-mailman (input) for mailman id 332847; Thu, 19 May 2022 11:14:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nre6g-0002IU-4K for xen-devel@lists.xenproject.org; Thu, 19 May 2022 11:14:14 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cecfb5a6-d764-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 13:14:11 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6BE785C01C9 for ; Thu, 19 May 2022 07:14:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 19 May 2022 07:14:10 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 19 May 2022 07:14:09 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cecfb5a6-d764-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1652958850; x=1653045250; bh=e7UOwb51ZR vIfzKcwBFx4l4oCIv0K678V83oOqmAH5U=; b=ap9d34GdSYzsCvoI2rBj6BlS0T Njtz5R5JPtqciNV2SU0PktzffvVeaH9y60/v68jvUvakxsPEKyFAe96c5KjhxGdE shNfR9ZBCauVh1GailTJy18k9D7rrIkDH7drpHQOGJrdGoWk47FydAsg1vZpBrP0 QDBwYTE1kTYRpU4QSq3wJtb7GNYMRl64YeuEkuC/MzfKqdYj24o0KPioBPrLnE77 ioYZXpdQ0GAdJU4cUnIzRSiy7IT2WtzyrjfU1lLYeESpNagujzhbpjakTf+uTqRW z8VKZxAnDPME42Tg1fmKTFV4Sj5jZu5PfoF0jvjlz1ho3xK6LJv5+FZcIBzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652958850; x= 1653045250; bh=e7UOwb51ZRvIfzKcwBFx4l4oCIv0K678V83oOqmAH5U=; b=K kVw1cjyD4A6agmrj5HjWqclNuM3bOD8CXGBSwzW7iOyQzrbGh8d+MBtem65s8XS2 v4tAvlmtsFnWez7eb0Rxz3GNieg6CDkzMn8MFD1iLiBLOvuGxH8x5c6ozIJ1hGvM de7ZLDikUiFKejYqAQOKzd92w4uTfQc82E3cMAUy7uQq0gasRaMznBVuWcWibN7w fB47rLJbQ9Rh4ZXIYVrzEmBxishLpBJZ4bInxBpUPqQGBVJd7GTsWid6aU4g7vWR IPyIsNMT8SG8r/G4Bt+MsVR2TrdXpIGRDzssXvFQsqcHvgaqWhKukeFZJQt/PYnD pPUeucXXRkG3AASVKjRMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggusehgtdorredttd ejnecuhfhrohhmpeforghrvghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcu oehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenuc ggtffrrghtthgvrhhnpedvueehheeitdeuieehgfetfeeuvedvteeuudeuheekvdefgfei kedutdegfeejleenucffohhmrghinhepqhhusggvshdqohhsrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 19 May 2022 13:14:06 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Showcase of openQA for testing on physical hardware Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HcZLkqUjUk/HWt8t" Content-Disposition: inline --HcZLkqUjUk/HWt8t Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 13:14:06 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: Showcase of openQA for testing on physical hardware Hi all, I have recent-ish made openQA to run tests not only inside KVM machines, but also on physical hardware. The setup is described here: https://www.qubes-os.org/news/2022/05/05/automated-os-testing-on-physical-l= aptops/ The live instance is at https://openqa.qubes-os.org. Tests running on physical machines are marked with "@hw(number)", but from outside they don't differ that much from virtualized ones. This might be interesting for you, in context of extending/replacing OSSTest. I think the above setup is an overkill for testing just Xen - in my case the goal is to test mostly unmodified Qubes system, the way the user would interact with it, but for Xen, running tests over SSH and/or collecting output over serial console should be enough (you don't need all this HID emulation, HDMI capture etc). openQA provides nice way to schedule tests on various machines, a utility library for writing tests (most of it is useful for GUI tests, but still) and then collect and present results. It's main use case is running tests in virtual machines which is visible in few places (much more flexible scheduling, if you can take a disk image and connect it somewhere else), but running on a bare metal is supported use case. BTW I intentionally decided to build thing to be tested elsewhere - gitlab specifically, and then provide it as a test input (there are various methods for it in openQA, mostly using URLs that will be automatically downloaded). I use subset of this setup for `git bisect run`, but that has more to do with remote power and boot control, than openQA. Currently I only run there Qubes-specific tests - especially only Xen versions we have packaged there. Running tests on xen-unstable (master or staging) is complicated in Qubes case, because unstable ABIs force rebuilds of several parts in that case. But I guess testing just Xen with its native toolstack won't have this problem (and you build all of it in gitlab already). I'm open for any questions about this setup :) --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --HcZLkqUjUk/HWt8t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmKGJn4ACgkQ24/THMrX 1yyL6Af+PEMr5t4A5eO7UcFS/2Bumi9lBqUUcy5iRrDTBqems4AF3pT/StIdg+ly l6GL+em2mljCDVMg7EcXhb+CduofZ2UmZ9QfvKc6zwKrINeOyTKCxNTMyxX038I/ WSoD51pxSP7G0D/fR6I8D1fSqsNna9h2rvJ6k5qogDraNUx5+C4Dxloq2OORsHP7 8MUXfjqLD6Nh7s+xoi1R0T4ViHtglDF562odwh1Dt2ndIA+LJyptutWDb5qkocKN xl7BrweSDFtxNy29EmP2PDCooyXbbbAGnC15Fq6Aek/wwzWmEDT421drA4DznFA4 vt2W52nEHIHMwKgZUdVysUfhJjZ4sw== =WZ1e -----END PGP SIGNATURE----- --HcZLkqUjUk/HWt8t-- From xen-devel-bounces@lists.xenproject.org Thu May 19 12:09:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332862.556628 (Exim 4.92) (envelope-from ) id 1nrexj-0007Rd-M9; Thu, 19 May 2022 12:09:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332862.556628; Thu, 19 May 2022 12:09:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrexj-0007RW-Hq; Thu, 19 May 2022 12:09:03 +0000 Received: by outflank-mailman (input) for mailman id 332862; Thu, 19 May 2022 12:09:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrexh-0007RQ-Vb for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:09:02 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7655cc7c-d76c-11ec-837e-e5687231ffcc; Thu, 19 May 2022 14:08:59 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nrewo-00BE00-NL; Thu, 19 May 2022 14:08:07 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7655cc7c-d76c-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Or+sigV8tAW403lBCNOcYfh+f/QtBZxoM4MtJnkEDo=; b=JqidS10tAFi8w45bv/QRWgkoh/ KOgIwZ/tIUUpLlbLrbLO1ldSksH/br07uow35GeONuGXn9H2gl6Zc+ITyazsuepTHCwyY7cXFe/h7 MtwjDL5RB9ZO6kq5gTfsayx//B9lueprkuY9Bysrv6zGbl5LRv1UeYThThR2djyvHZK5yH9WAOS3f IAvBZnCmpegeYcMo7srxsmSG31D8d5jvfPawZOHcM5Mv+NhxsgRuyQoZ7I4NYbnvdtmZ38tbx+LTT WmYVOrIBhGzwQtf/+4wAyIFnS+fHagBv45fyKy1zunamCTiZMunglm+e59nItrKVAlZjSL4ou4wbM ShGTIh/g==; Message-ID: <73ade79a-5d76-0e68-708c-f14d3665a7d2@igalia.com> Date: Thu, 19 May 2022 09:07:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Petr Mladek Cc: David Gow , Evan Green , Julius Werner , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Sebastian Reichel , linux-pm@vger.kernel.org, Florian Fainelli , akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/05/2022 04:03, Petr Mladek wrote: > [...] > I would ignore it for now. If anyone would want to safe the log > then they would need to read it. They will most likely use > the existing kmsg_dump() infastructure. In fact, they should > use it to avoid a code duplication. > > Best Regards, > Petr Cool, thanks! I agree, let's expect people use kmsg_dump() as they should =) From xen-devel-bounces@lists.xenproject.org Thu May 19 12:12:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:12:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332874.556638 (Exim 4.92) (envelope-from ) id 1nrf0o-0000NN-4s; Thu, 19 May 2022 12:12:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332874.556638; Thu, 19 May 2022 12:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf0o-0000NG-2A; Thu, 19 May 2022 12:12:14 +0000 Received: by outflank-mailman (input) for mailman id 332874; Thu, 19 May 2022 12:12:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf0m-0000Mm-OT for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:12:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9290906-d76c-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 14:12:11 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-FbQc3NKYMi6lnrlHbzcS1Q-1; Thu, 19 May 2022 14:12:09 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9343.eurprd04.prod.outlook.com (2603:10a6:102:2a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Thu, 19 May 2022 12:12:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 12:12:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9290906-d76c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652962331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b5ga6yALPUAqDCnoSZUd/muUM4D2vsSXqVizLBb/0Nw=; b=cFvauXg4r20zk16RPOsJxwyvaGJ9+/E4fyu6kNClndX6URl/Nbl11dfJC866Z/kQnqUf4k tL6Av8eOui/QnSxm+w0zaiP6uLWqE+uQtI0kRwKC8U9IhrRcjOv5AYVb4XWTKr/GtpfNvQ X/xGG3cruXm5bqZALxMyZOGC/uoMY2Y= X-MC-Unique: FbQc3NKYMi6lnrlHbzcS1Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mrHgEkKElhNbdz18OKCAS2qyp7R4nslFZxwu/ZfRBEQeED4UnWTvlU5IDZfUFP4ccpmju7u2wFUnIBgs7DBAFrkWBG+O9mJ0J5jwaDXrZ5GqwM9Q3MZy6kAHwdmsNm308cipjbN3JmCJITZZLnopTihdU7lKYkRrRaosKzdXowoMcaXVg64827MIkzByH1SQ4R5eoSpcnpJYo/LkP2WjA/mnbHAs8qZoReuHGJvfRWRP3w5cUwChGvJX0ZRarKLTyNJpMEntWG8Z2CKKwZL1lXyr9zYlpTifaspl4/AS/nwH5E8QrT9lsVNSvPI0uYVYsrkMq2baegQ1rWzCfXwBRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8KdnmbeScEm0NJAmg+0qpTXR6rHCOI4fCV4TpPpLV64=; b=P61VkcH96GEx+ZpEOOUryobC2RWPOBBwaE7les21thUQw2xLU4NQG+LKzEg7EAd3mP0bpf5thz+WvC/eEiAa7Iy+xtx/o2xyirynfuppZQsNI4Wqjy6+1/L4gyd+l26ifkh1wr+HZq8R0OaUXEQ+2gD2UjhpuTiMB7UpuosmnbwgPQZjQuKwzgqh8SFICjriZiBoEgcIFz3nA+klkaJdBsZGo0UrYlDUmczvSOeWXPACkX/dWQQXqAQ7V7RJawq38gjjyNx7Nb3PGG6mMXuPYxsg4OrjcTshziRLMDfFi8w7MlTmTlFjN1v2p5oQ7+8zGcI01dTnzT5zeJTL+ZXZ7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> Date: Thu, 19 May 2022 14:12:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0310.eurprd06.prod.outlook.com (2603:10a6:20b:45b::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bae4c71d-d430-4249-4d8f-08da3990cb0b X-MS-TrafficTypeDiagnostic: PA4PR04MB9343:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UM2N4i+OO/UCi6bVOOUtTi84lWuIO7hf7jSAORhcTItDbl1LvZ3BTGJPlQPMW4AzRNybDseHPqZP7ekTXATzySH59kHUXJ9y2DoPtFs86Un08FE8Y3TRg5WzXLxpbfqm5K87vG9EeFb84uSXKCM+zUB86q8nl3rbY7awJaP4esBkrN6oA9Q8TlJ+6CmpOhUIn7J6NxJL/yUuIFk/O71M2nDTW8tSQxCq0pseOmoX4oqztvhnS6kgPHqcxOZczHvftGvJAhz9q9RuWbK0wREyOfCJXzQeu+/Hu83ois+3w5sZ4tQveX4CGIdR11u3jgAgwOKBWqH4T0oE2P8fwbYRgHjqNqe/dyPWzYdNalrWPNYIw/xJBnHejErJid33CUdYL0N9YE1lk+MnstWBXjbDIlcmSEN36KAVCGUiQZfvUKkJBzcYZCBGrOgcFQUzyoT9gzE7oJGUeVni+Zy8RvGSyh0txxPzK1a+I1NfVe37pXYnrTvcRlPeAMZf7X7MpITdO69fHckLBOt520L3OI43yrnncBRJnA5sRucGSCkzH/OA/9UYTLaYVCDPhcc2ukEgRQCMrtwGFYuxmcI/bm2i4sHV1ZzgwyHFeOG/SOC1CdY9iUdqsFllLTRJqFsbLkqk4m+x+bSr/SBHuaooBEQrw8PhzLIsMWXMIFFJVn0Vz/nLcDGIDYYdxhzgEsimaERs/YKmCHZTkixngQoW1qILbrznd6QvPH6EMBNs0zljElw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(2616005)(8936002)(6486002)(186003)(38100700002)(54906003)(31696002)(86362001)(6512007)(26005)(31686004)(5660300002)(83380400001)(6916009)(66946007)(6666004)(2906002)(53546011)(6506007)(8676002)(66556008)(66476007)(4326008)(316002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yq8GjNWNcukqSP5sTVEUGc0obRW2T73KegqwRcDZeHSId1Zy/I7oam3H2zw1?= =?us-ascii?Q?8NSidcHg5qWGcK2s1EU8L3aGkrzCLbImXe/vn6RmIsz8/S3YCcg0Gfph2vAX?= =?us-ascii?Q?1yPcCXGXoT0ieOQR7GhlieFuxhp9TTEERm1RidyTKGU7ZGLXdEnsUeUM/i4B?= =?us-ascii?Q?eDnI9gNleQIvxpdAUToGHQsSLon9/1jOWFdrw/HraOJFdGDuxlMjgzvEAOFG?= =?us-ascii?Q?WaafgHlstZ6U2SsfXlOb5UYgH8rlKy0kHCgA/73rDTUK6QxcVYYV9QxHNAQw?= =?us-ascii?Q?ON9qZXbcYH7E7AfzSBzkz9o9rhXutvyLrCBkISKtWqUTBEi5EOw1mZeiT//Z?= =?us-ascii?Q?AXGKhdgAxalk3qVtvCnsLZ4KdHszJmUfXhSjfSESpFUKp/Yr+5cRHwhqMbaF?= =?us-ascii?Q?WioHBg9BL1YvMA/sAeVtbqswnRhNkKp2l1lljSLA8HjRbprhY2Z5WomHYpmh?= =?us-ascii?Q?weHKdoaCBu4UoQ/0HfEkw3uXsr3ug5DjuJJPPYTp3CB8DmyqtX+xjkXOgIyF?= =?us-ascii?Q?oAYTz+5WCEDtQzMLerrfBPmqvC+dFYBN9XZwBL7dwojeMcsCdis9Xf3BFn31?= =?us-ascii?Q?cMy+2hxi1ItzxSgrjUKxoe+b8NQfuEVTKacyNUiJPUv4LLuu5MBj+/mIIPR6?= =?us-ascii?Q?YY87486fKraOS6IrdV0SOwlGnEIEwmdz2SogGN9SLFu0+7NbP6g5408dl1kK?= =?us-ascii?Q?Vcpmotn7RmyY6OIt6+t9K7a+p7jFSimuEi0wtN62chTJwKDl34OD+1R8bViB?= =?us-ascii?Q?zjHEqTLOcMFkwHTQ7V2MkeTyf8NZALL8W39ep88jeYK1/tgSj11Utx8r29Lt?= =?us-ascii?Q?PIlzNNc4OqAILEcrQHUekZg/v7DLJ8PkiH537A+J1zRDmZmIA6GBN84Km2vN?= =?us-ascii?Q?FUB9F/MWx2PAVDBgLgpCcR2Rh5cnHG3ZUihxMOOYizeUL2r+HtWnbYIZSnRg?= =?us-ascii?Q?KU8oT1CqMnXfFvkuLN8MYi7Tiv1slnGqwK6psJ41F0xgFwxEa59X5T54KgRN?= =?us-ascii?Q?YnvI4MPzbC5YYgmFkzvACpUPdoDFhHaRnBvegxH3WjJEnd3ALCPYbQJPlfGD?= =?us-ascii?Q?/iHYOHKYM9UX2satNqqCSc+mfxBaKufbnGHe9ZJzGEdUzSf+PpHuVlYvfun/?= =?us-ascii?Q?eUBcZUZQ6BEO3S641dvhR2LEM4Mf019EUciEqWU8sBlh3F9tQHKmsWWs2HEy?= =?us-ascii?Q?qshalceuMLGVKDdTcyiZryVpOpr4Mg/W3C2DbzcZTEQx365IUF8dXWKKGOME?= =?us-ascii?Q?0tjPS3g6BMAlw9Awp8bkGWKeIjzy9ANs8vWmAXhqxBq/KjbzbXELNxmY/16q?= =?us-ascii?Q?QigwDvCJIzJfSWhNQBfTOigJwLrate9MVcUxDqugHpv8lMxji7XpK9HCc/lQ?= =?us-ascii?Q?CKmBFGestM79PsnjQeVCOMdD7/qh/41kbzbt1iGAYm8+uSSPxjlRjjyM6bgN?= =?us-ascii?Q?bhAKBWKf1+HZl5wRXc9giibGUgdNe8UIp5j7Ddb32U5NaieuGRCgL+Schur+?= =?us-ascii?Q?1XsgP8B2ejRjX6cT0kwUE8PtFA2qCuhUQccamzyE4xo7XUe6Nmq/KG91o/md?= =?us-ascii?Q?qPHDyTj0912CVVFdMzO7lxamtzFBPr96xE0HanjTkXCnTR31ngcc6XqpjTpE?= =?us-ascii?Q?fpAffc2aWXX/Vvh0LSliQ7LFQYNWwxmZ8cM/HaufvfCq15W8RbCDUNb9Vs30?= =?us-ascii?Q?qc14uqJLYKDSlJgW3BJy0m6yYgdaZlg2vw6I94B+CHNEX2qeYdXEkthYxuEk?= =?us-ascii?Q?rVuV4kSc2w=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bae4c71d-d430-4249-4d8f-08da3990cb0b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 12:12:07.2654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PMnxSeZG/g4RJK2zHOlu2lZ9zXOCHkFk8DBYLW6P2JtjEH589W7s79BWE5BiBadhuA470U7LS7JdNzUczDyMKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9343 On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: > On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >> --- >> An alternative to the ASSERT()s added to set_iommu_ptes_present() would >> be to make the function less general-purpose; it's used in a single >> place only after all (i.e. it might as well be folded into its only >> caller). >=20 > I would think adding a comment that the function requires the PDE to > be empty would be good. But that's not the case - what the function expects to be clear is what is being ASSERT()ed. > Also given the current usage we could drop > the nr_ptes parameter and just name the function fill_pde() or > similar. Right, but that would want to be a separate change. >> --- a/xen/drivers/passthrough/amd/iommu_map.c >> +++ b/xen/drivers/passthrough/amd/iommu_map.c >> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >> =20 >> while ( nr_ptes-- ) >> { >> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >> + ASSERT(!pde->next_level); >> + ASSERT(!pde->u); >> + >> + if ( pde > table ) >> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table)); >> + else >> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >=20 > I think PAGETABLE_ORDER would be clearer here. I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere in IOMMU code afaics. > While here, could you also assert that next_mfn matches the contiguous > order currently set in the PTE? I can, yet that wouldn't be here, but outside (ahead) of the loop. >> @@ -717,7 +729,7 @@ static int fill_qpt(union amd_iommu_pte >> * page table pages, and the resulting allocations are = always >> * zeroed. >> */ >> - pgs[level] =3D iommu_alloc_pgtable(hd); >> + pgs[level] =3D iommu_alloc_pgtable(hd, 0); >=20 > Is it worth not setting up the contiguous data for quarantine page > tables? Well, it's (slightly) less code, and (hopefully) faster due to the use of clear_page(). > I think it's fine now given the current code, but you having added > ASSERTs that the contig data is correct in set_iommu_ptes_present() > makes me wonder whether we could trigger those in the future. I'd like to deal with that if and when needed. > I understand that the contig data is not helpful for quarantine page > tables, but still doesn't seem bad to have it just for coherency. You realize that the markers all being zero in a table is a valid state, functionality-wise? It would merely mean no re-coalescing until respective entries were touched (updated) at least once. >> @@ -276,7 +280,7 @@ struct dma_pte { >> #define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE) >> #define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K) >> #define dma_set_pte_addr(p, addr) do {\ >> - (p).val |=3D ((addr) & PAGE_MASK_4K); } while (0) >> + (p).val |=3D ((addr) & PADDR_MASK & PAGE_MASK_4K); } while = (0) >=20 > While I'm not opposed to this, I would assume that addr is not > expected to contain bit cleared by PADDR_MASK? (or PAGE_MASK_4K FWIW) Indeed. But I'd prefer to be on the safe side, now that some of the bits have gained a different meaning. >> @@ -538,7 +539,29 @@ struct page_info *iommu_alloc_pgtable(st >> return NULL; >> =20 >> p =3D __map_domain_page(pg); >> - clear_page(p); >> + >> + if ( contig_mask ) >> + { >> + /* See pt-contig-markers.h for a description of the marker sche= me. */ >> + unsigned int i, shift =3D find_first_set_bit(contig_mask); >> + >> + ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) =3D=3D PAGE_= SHIFT - 3); >=20 > I think it might be clearer to use PAGETABLE_ORDER rather than > PAGE_SHIFT - 3. See above. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 12:20:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332882.556650 (Exim 4.92) (envelope-from ) id 1nrf8k-00022N-Vk; Thu, 19 May 2022 12:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332882.556650; Thu, 19 May 2022 12:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf8k-00022G-Sg; Thu, 19 May 2022 12:20:26 +0000 Received: by outflank-mailman (input) for mailman id 332882; Thu, 19 May 2022 12:20:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf8k-00022A-DS for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:20:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f75d24f-d76e-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 14:20:25 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-2wCtcYBBNkSIJzCp7kW5aA-1; Thu, 19 May 2022 14:20:21 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Thu, 19 May 2022 12:20:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 12:20:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f75d24f-d76e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652962825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ETlAfvDhBrJt5SXvFZKOMq749xzBtSdwwfx+GCo+p4Q=; b=ikpbJ2e8TMa3GY7dPqYVeCTi9GUsww9UrAvf+VZTwPNLddgCDF2kw6SvCHlmJ+c5WbCIVr k9ZThILQ+eU0xbdoQ8f2IS3VFQd5Mf6XC9tz4t8Bsnre8xsLer95tlxqnvIjx7mVeA5E1y talL5GD2czbLAAny1CDLe4lYUe36IKM= X-MC-Unique: 2wCtcYBBNkSIJzCp7kW5aA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvPAbAG65YWy4h78BJMqpXcCWDxItSkmThjUbhECxz03lm+S7pgssfLJHlKmDFLNRyQt2GrfJdHAWZXxYsrEsp2VeD6kEdIy0MV7peCyfYvmpIokNo/ulfxRCYyCxKkV5mOK9mFZT25jbaMQMRds5OuobGVVwPmJXCkd4Hp7CSzvfOBZ/fkxWoVtF6rqBUe9A4FBjzRmSutX8/FpDMobZByg79eL+irtIod2RfinqBaSF4n0VeB0DRF3v3SQR6tQc4hN7an2jffQYSD/x4fjs+NI6ZWBByOHv/Bd2bllA9YLuRYERp+AA97aIZb4MHyZJpYiJrKeB/wnJsPdPzVr9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ETlAfvDhBrJt5SXvFZKOMq749xzBtSdwwfx+GCo+p4Q=; b=eL791kY2ZCt9QnFwLqLv5IMVJfexm/gck9o4F6buF+fAa1NKUyI5JHLJ33CY+UVcX4z91MVLSHU9y4qR09pp8q687mna0HWcMr6clF2yF3XHHOz4V00fpOJdZsd9SKugLdArBleiAuIUQoBH60yEuET/zm0n4zfVZvOjK3f/eTtBv1izgRoBvEWP1KTUm1z36Ce7ldBoXTPE2vIXa/363XZQG5YtJUuAAxce6w7Gy+B+6a9CS2uzPD400GmcZBqPCtTbm4BZPXBBECPaXuGomn5OhWgIaJx3fYONsDfC++j9efwS5De0q/NnfvyU016RfFgtcmX0bFokaUqScWDu1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <072cf387-f61e-919e-a0a5-7c767d91d99c@suse.com> Date: Thu, 19 May 2022 14:20:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Ping: [PATCH] VT-d: fix !HVM build Content-Language: en-US From: Jan Beulich To: Kevin Tian Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" References: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com> In-Reply-To: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0567.eurprd06.prod.outlook.com (2603:10a6:20b:485::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ef0e640-e63a-40d6-1a7c-08da3991f0f1 X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LXsAHfzTKyXOcO56zcrB2pWEoNd3gKyIWoEEGpCA5r8LupYC33UJwzwfmDuP3vjdniy3wEclGN6f9oG6TRxsDpWF6g5mqviQ96x0jPhxBwMm51cP5oza2MGh9WpJh3/zw7F1xKFdVMrhNy0oAGU2KGqZFQ0Ra2/FPjVeMlH/5vaVCcvNWVDHD9mJjh9TCKV8mCi7rq8T9j5NeR1vdm/bYXe3upEXs8oEqD/0bxCQSMSi1AS/cWmMSOm3AUQ8qyzkl/xBmo1O+15HmAJGnk6yrcDMzS9a+hBwUmMt8+ahLtimTwPYuUJ9+fLWnm/zjIh42GdclmQL2sheuDV+YOgikM+vooNoEaNNV9/vzDwdKnvGeqs1MpjT/RSp52ljo0b3lYkSamQ1h3dcRbNKfCIRpYAyFFq21bOaVUA0EuzO+HrlCDYLs9w5dZExeqkMxdzU5LxkNxj5Il6MVXBlwULpffcsaLi4kPUIC5/umi4NGJtyVVUfSS9sOqyOq/9pceiNZbxEzDLITvCyuUFg0J4kjlhFvfbP9OAH8/knPrbzWY2IqZL41/E5Hdflid3QHi5H79FNMhRN6sYuC1sg8NidkQXf+ZNzKgzGXLlA3LLDzuvx1Ikwd7/ygKG854qqYyNOF7MBxmb1jzIDG1bGJR8qbae6XtTtKkoNUgrQA8HAXepdi7QY4qBM8k0TGxTFCkyvaUOqEQq4FFfrxocrSx2BlURwNQtEuQg4qCAIh3GVyG0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(83380400001)(6666004)(31696002)(38100700002)(186003)(86362001)(6486002)(66476007)(26005)(6506007)(6512007)(54906003)(8676002)(66556008)(6916009)(316002)(2906002)(4326008)(36756003)(66946007)(508600001)(53546011)(31686004)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjIzMFZhVC8rOFBWNld6Z01HWHRsN0Q1MWRkT1FxS1grb3VCY04xT1RVd0JF?= =?utf-8?B?OThOZ0VsSDhCMDhvbmFuR3YxNXl3Z2tyclJ2aVppQyswV085NkkzMVJENlFo?= =?utf-8?B?RmtmT0thZUxMUEs4TW5Fa0ZkUlBsOFFLZDZUanVrV0F0ZmM4ejViSUZERUNt?= =?utf-8?B?elY0K1NMVGVIQ2c3QlFadXMwWGhaM2c2SkU5TGIweG5KcDMwenhNUEVOTUdH?= =?utf-8?B?QmkyTGZTRFZKK2ZHcUltMFl0OEFVaWxEelRRWi95dDdVMktFRUV1S21GWWJi?= =?utf-8?B?S0toR09Edk83aG5rSmIrMWdSRktpVTRGS0J4TW4wOUFDMktkMzluWVV5ZWJH?= =?utf-8?B?V2twWWpQb2RrMGtNZGdpL1duZVI1QTRCd2FzaGRIUTNYdXp5aVk4UGIyZEZR?= =?utf-8?B?bUdpYmQvdncwZi8zQWVsTjg5QUx1c2k4SEhISkFaRGZZNkZvM2c2dU5KQzBZ?= =?utf-8?B?bGgvY2g2RkZEVUhsZ0ZnbVFUWU1ob1FUOGEvWE1JdmVvbzJQOTE2cVVvU3o5?= =?utf-8?B?aXBMeXM2YTNZWGhkM3kxWEVCckMvaFNpcUhhNFVCeTRkejdoMTBOZEJDeExF?= =?utf-8?B?aENpUE52alpVL1JpRTRkNk1NZTRRTkx4QmhibGlST1hDeHArYXhzTGpOS2xh?= =?utf-8?B?MTd0eUVBUzRMZUlIdGxaV3JVNFdjMTl1Mmg5UFJ1ZTJDMCtudGdkWmFSemVG?= =?utf-8?B?RGV4M1RDQVR3ZXlQUVpoTjN3Qkl0b1NDcDlzZ0Zpb2FDTGxaazByeTRkVjBt?= =?utf-8?B?TGl6ODlIbWhyQ25sOHFmRzlZemhjR3lreWRpMGNNMWFBWnREUW13eHdtNnBi?= =?utf-8?B?OEV6STRVZVhLY1htYkFzZHI5c1huVTlKc0xoemxoZGZHazZWcUlPQ2NTYVpq?= =?utf-8?B?aiswc1pjREp4eUNkQldsMzN1eTl6WjgvbVRGOGlMdnBBUEVnUVdrUC9ZRkVp?= =?utf-8?B?R0NTejRXRHN4cis1YkFWM1dMbVBHQXA0eG9xSk54bUQ2ZUhZTE9JNktKYlgr?= =?utf-8?B?dnQzWGl5Qm1yVG1hN3RTejFjdnR5YWlRblZ2czZXQmJoeVBCRGs3Tm9Zekhs?= =?utf-8?B?QzR5cXVvMXgwZXpHVTY4RjdtYUJQRWNvajhkaWhldklIb0UwK2tGVDlSNWlv?= =?utf-8?B?KzYvK2VKYkRjbnRudEVta0wwY3FFdXZRVWZzeHJEU2NBdXJOeklSWEllOVZN?= =?utf-8?B?VEdPNEx4OFI3Q1l3VVpOcmpZVUYyZkhZemdGbFhIRmZBTkcxTTlTM1VDazAw?= =?utf-8?B?L3R4STduYkdydElNckFOZkRTTUhFRnJZZkt4bnpwWHA5WWpuNnpCcXc3RDB6?= =?utf-8?B?WkF4cHhLbXZ0bFBCbkZ1U0IwWDNqYm9uaE83SG1tMjZraXFNek5ZRHQ0V1Jw?= =?utf-8?B?NVVhZk4vaEttemZpeU5HcE1rR1EyWEZiNjFsQmU5R3daOGxGaE51UDBYNlI3?= =?utf-8?B?aGIxbEdFbWI1a3lhdnFQcjljakcwelBSUDd1VStOUkNOT1g5UnNNeVVOdG9r?= =?utf-8?B?RlQ2OXNMa2Z2U3ZYdzhOczV2OE1oWkJVQnJCUUlIM2VQMUVKUS9sZGQxV3Jq?= =?utf-8?B?L205b09kUmJqc2xrcW5XRTJmZzFYd24wZlFvSG5NYncvYktmc2YzVkx1clZ6?= =?utf-8?B?V09oOWxOWGJ5cklhYy9IOUFocUdGRlpaMGUzdzNCNHVZcHlNeU8rYVZaWEgz?= =?utf-8?B?SWdaRmFOSHVRWTF3NVBGOUlhYW1XbjluN1gvVnkrUTg4Rk5DWkt4M0VmV25Y?= =?utf-8?B?VjZOZ3RTNHpzWmxZd0oxUVpsb2NoOTh1Z2R3TGRFUVNZWU9VS0VwSkx0TUFx?= =?utf-8?B?Q1ZWbDZLWmQ3bUJkQUtEdTkzUm1kU2JoL0lYQlJsUkxtYUxndlhGNGptS2I4?= =?utf-8?B?REJTZ3pVS25HektVdzlVeCtpRzcrc3REZXNCZkZzTGxuUWtWZ04vUTRaTjJN?= =?utf-8?B?cTBoOEc3RmZBT2piYXI4TlNyQ2JldTk4Y1A1d2Qxdy83NjFrL1RZSmRDMmJu?= =?utf-8?B?K0h5b29rZUYrNmFzUFAxd0pTRzRPYitDTCszZkRNbGZjcEI5Q1h0NEtYREIx?= =?utf-8?B?WVdwUG9UZWFtcVdCNVNtZWNDTnN1SWxiTXhnYnU3dk94Ukh6VnkxaXB1OVRY?= =?utf-8?B?M2xYRXM0MVFCeEtveVhrNjVNcHRnSHpzRFRJZ28rT1BhdytSS1p5RXp3QSt4?= =?utf-8?B?QVVWUjZ4ZkhFeEN2K0FPSDdPVGZlb2UzclViVHVYQW8wYmVVdHZTYVd2RHFZ?= =?utf-8?B?UThDM3Ixdjh3MVR6QTNNZFh5V3dqbUZmVTJwTnhuN2d2NUE2d3BFeWphOXFH?= =?utf-8?B?c3o0VXh2dXU0dFVNS0c2YnVET1ltS1Jnak9DRGQ5Z2lVdmt6bzVOQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ef0e640-e63a-40d6-1a7c-08da3991f0f1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 12:20:20.4220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iu8+Fdy0ZvINSKtXV96SBQKWNWSN/BYxMYcSMCAgKsx5q0YknuE1cFg3TLKkJv4JRcGUjNA/q9EJScfRhCcEmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8788 On 22.04.2022 11:58, Jan Beulich wrote: > EPT is of no interest when !HVM. While I'm observing gcc11 to fully > eliminate the function, older gcc's DCE looks to not be as good. Aid the > compiler in eliminating the accesses of opt_hap_{2mb,1gb}, which > otherwise cause undefined symbol errors when linking. > > While there adjust types. > > Fixes: c479415610f0 ("x86/P2M: p2m.c is HVM-only") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich I guess I'll put this in (as being simple enough) if I don't hear anything back by the end of the week. Jan > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -2155,14 +2155,17 @@ static int cf_check intel_iommu_lookup_p > return 0; > } > > -static int __init vtd_ept_page_compatible(struct vtd_iommu *iommu) > +static bool __init vtd_ept_page_compatible(const struct vtd_iommu *iommu) > { > - u64 ept_cap, vtd_cap = iommu->cap; > + uint64_t ept_cap, vtd_cap = iommu->cap; > + > + if ( !IS_ENABLED(CONFIG_HVM) ) > + return false; > > /* EPT is not initialised yet, so we must check the capability in > * the MSR explicitly rather than use cpu_has_vmx_ept_*() */ > if ( rdmsr_safe(MSR_IA32_VMX_EPT_VPID_CAP, ept_cap) != 0 ) > - return 0; > + return false; > > return (ept_has_2mb(ept_cap) && opt_hap_2mb) <= cap_sps_2mb(vtd_cap) && > (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap); > > From xen-devel-bounces@lists.xenproject.org Thu May 19 12:20:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:20:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332887.556661 (Exim 4.92) (envelope-from ) id 1nrf99-0002UY-CD; Thu, 19 May 2022 12:20:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332887.556661; Thu, 19 May 2022 12:20:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf99-0002UP-88; Thu, 19 May 2022 12:20:51 +0000 Received: by outflank-mailman (input) for mailman id 332887; Thu, 19 May 2022 12:20:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf98-0002NI-54 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:20:50 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1af77b2b-d76e-11ec-837e-e5687231ffcc; Thu, 19 May 2022 14:20:44 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nrf8d-00BEVm-Gn; Thu, 19 May 2022 14:20:19 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1af77b2b-d76e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e6xrJm1a3ay+4weLnrCkh2SRSEeyZycIIB/twweqf9Y=; b=BhOEtl3IEpq+ZutVgH7P2rHsfA mhGkC2PSuDrVyQ8IQfXtbB2pfD2fLPqKTP1L2vPLew3hLPbkforpZGHUalxvr86M8T2G/zNh0P/pw wi++cJ5XXfisCo4sQPAYOpaVMhBvNWB3svhNAgbQKxYFPy0Oeko+Z9jhUOVMogS4VQkCRHPLo2bnq jjqxb69zYzPORFRcZZlayXhHSqDz7B+6f3XjEVdBQ2ftzK2PDz+TwQa11JztdT1Ouzc0j+U1m1POY rbklHHuyIwI+fwGIyQbgwTEldlCv1PEui/a5Qzds7nWr2ZDdu+bcGybfUaDSvUQ/88wOr+qjGKQ2s 3BFZ9Urg==; Message-ID: Date: Thu, 19 May 2022 09:19:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Scott Branden , Petr Mladek , Sebastian Reichel , Florian Fainelli , Desmond yan Cc: David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> From: "Guilherme G. Piccoli" In-Reply-To: <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/05/2022 19:17, Scott Branden wrote: > Hi Guilherme, > > +Desmond > [...] >>>> I'm afraid it breaks kdump if this device is not reset beforehand - it's >>>> a doorbell write, so not high risk I think... >>>> >>>> But in case the not-reset device can be probed normally in kdump kernel, >>>> then I'm fine in moving this to the reboot list! I don't have the HW to >>>> test myself. >>> >>> Good question. Well, it if has to be called before kdump then >>> even "hypervisor" list is a wrong place because is not always >>> called before kdump. >> [...] > We register to the panic notifier so that we can kill the VK card ASAP > to stop DMAing things over to the host side. If it is not notified then > memory may not be frozen when kdump is occurring. > Notifying the card on panic is also needed to allow for any type of > reset to occur. > > So, the only thing preventing moving the notifier later is the chance > that memory is modified while kdump is occurring. Or, if DMA is > disabled before kdump already then this wouldn't be an issue and the > notification to the card (to allow for clean resets) can be done later. Hi Scott / Desmond, thanks for the detailed answer! Is this adapter designed to run in x86 only or you have other architectures' use cases? I'm not expert on that, but I guess whether DMA is "kept" or not depends a bit if IOMMU is used. IIRC, there was a copy of the DMAR table in kdump (at least for Intel IOMMU). Also, devices are not properly quiesced on kdump IIUC, we don't call shutdown/reset handlers, they're skip due to the crash nature - so there is a risk of devices doing bad things in the new kernel. With that said, and given this is a lightweight notifier that ideally should run ASAP, I'd keep this one in the hypervisor list. We can "adjust" the semantic of this list to include lightweight notifiers that reset adapters. With that said, Petr has a point - not always such list is going to be called before kdump. So, that makes me think in another idea: what if we have another list, but not on panic path, but instead in the custom crash_shutdown()? Drivers could add callbacks there that must execute before kexec/kdump, no matter what. Let me know your thoughts Scott / Desmond / Petr and all interested parties. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Thu May 19 12:21:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332899.556672 (Exim 4.92) (envelope-from ) id 1nrf9Y-00038F-KI; Thu, 19 May 2022 12:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332899.556672; Thu, 19 May 2022 12:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf9Y-000388-GV; Thu, 19 May 2022 12:21:16 +0000 Received: by outflank-mailman (input) for mailman id 332899; Thu, 19 May 2022 12:21:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrf9W-00022A-9h for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:21:14 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2954d26d-d76e-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 14:21:10 +0200 (CEST) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 May 2022 08:21:07 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5455.namprd03.prod.outlook.com (2603:10b6:a03:27b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Thu, 19 May 2022 12:21:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.016; Thu, 19 May 2022 12:21:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2954d26d-d76e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652962870; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=R7jkYktH2zw72lBR2KXCu8hpkmt3VPudGnIsZArRlhE=; b=KPrVt64FTdGWRZWikhZ+jbTF+iyAMz84IlWNZnjdmTbX8JqCJJOpznbC Hgoqg7pFDDMbK3gdBz8At3zuQHdTF1Zvgjz5Z4n+0vp466gNJjAP1pDer d007fvNCk/sMm3VWTxHrf6H7rivjPImsTzjNF3QOz785osRKg1LKWyAem c=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 72083973 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9h2vM605PqY3hbouCvbD5clwkn2cJEfYwER7XKvMYLTBsI5bpzxWm mQZCGqEbvjZMGr3f9EjYIi1/B8BuJfXmtMwTAU9pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1sm5DzUQIWMpb8mb40C0lYGgBDGPZJreqvzXiX6aR/zmXgWl61mrBFKxhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82dBfyVube03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrialK20D+Q3OzUYxy3Txyi16jqHyCcKWd4y7ZddOw0G9q VuTqgwVBTlfbrRz0wGt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7l0j4XdtcI k4V/yMGrK4u+UjtRd74NzW7rWCFuFgAWtNWO+w89AyJjKHT5m6xBGIJUzpAY9wOr9ItSHoh0 Vrht8ztLSxitvuSU331y1uPhTa7OCxQJmhbYyYBFFIB+4O6/911iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:tuoSu6v2vFyGmj1or36R2b6X7skC/4Mji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVeUiz9bUN1LNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUUHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0k9 gsfJ4Y0I2mdfVmHJ6VNN1xP/dfNVa9MS4kEFjiV2gPR5t3ck4klfbMkccIzdDvXqA0570Pv7 mEeG9klAcJCjfT4Iu1rdB2ziw= X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="72083973" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqHiDNFYBv4J5fqaa6MLBVKED4e/WcTMfj2iYxutM5kJW7LZ1l7G7xdmK20B/rrJl83+VdIqTRngBuujqJTflYUhZ1A7bJ8KvePIBLKq2asowfGJAoXJps2Me5Wvg1nOSC3RbZt0ub+vgPWuqw6QNfdqZo8y88zH4vxYSfpJC24+/yVzuBcedGOufwzX/wHX6Gs0gYzhoqPi8EhfNzHB1TOTCMtgrsGFw6yU8E21PmFdccjUedSmwpIK3xPu7bkOo0uKHMx2NVXLKnb70rjPKEUISPgCT6lNoknzHr/J0PDl1B4L+dh0qTlwxhkERqlKg+8jR5itzJtZTgaGMP5RRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9bvXr78t6uo5huIrtNfrwELMwIeizoRIZf2M6XyVjk=; b=gP4GenPX3FXRG4wT4Cit/CuCY50OdlkxEZiVrVCUip6phbc6aXAaJkc0I9Kj+NvSeegpK/K2RSnOUeYf98rCSsDGMABFy/o0IOzG3r9OrecICnEwFIOus84mLOlWe6gFtDcRvaGPkt0QZ02i5hjNu7Xg9cSo06UXpMXJEvR/t2FF/0rAVqcbjGs5lZpNhW18jqbTkqYuw3Ymfvde9rmQMx25DmTJAwSMvXTv1T5OaAy7fF14qZ0ohl+2IwfxZf3zTf5glnZo2J2n3B7phck25UVNJwPaFxJkry7s/LztXdpO9ROmFftuCykD4RW7aV+aiE3IfM/MybED1ahMqaUdcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x9bvXr78t6uo5huIrtNfrwELMwIeizoRIZf2M6XyVjk=; b=Pjo7MtB9h+xHyyZPnnXruwZ6Y2VM5umd4I9jMWEWXOkkJWmdihBsosW4wji+chHi3TRYkf/5PHF7VwT3sOr79XGq7zBrE8WjOithBO4e2ZLGkBUee5AAxD20/yFulYDigCQQMC+Kt8cEb1UBcIHHR3tvp82oC/grKtRovf4Mkzw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 19 May 2022 14:21:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jun Nakajima , Kevin Tian , Jan Beulich , Wei Liu Subject: Re: [PATCH 1/2] x86/vmx: implement Bus Lock detection Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-2-roger.pau@citrix.com> <84ee0886-9ed2-97ad-e9f9-c81e8a3885c5@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <84ee0886-9ed2-97ad-e9f9-c81e8a3885c5@citrix.com> X-ClientProxiedBy: LO2P123CA0091.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d449f77-42fc-409d-e7cf-08da39920c24 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5455:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: //M2Si1dFs2qreW/EH3qf3yejeed5J0TwWYkxg0H9RpLSy+8Wy3UavI6wbgJ6bv1DtnfTIUE1VIliG+TOLhDyLBkN6FiPlYcz488dwnxONdQ3tPyzP/XWNL7BkIPovCuGXPz9/UL0zxq5OtBbIpeAuBQn5htmYQF2XUA7Xu4kj3ZrAhd0mdE8rxa6pqNcT++xqI/x8/8/fe76hDqcAk3zcZHlSA5lMX+8qD4ZNwgvgeIuuS9OJaipNUFEC3Jji6e6KeEScbG3ORp/KA9MxQfwzv1Q7ihqKXhlH82Psy9PF/cFlrX1nIaRXV5ksPoLAsehhq0/0mZPyYjPHHEQVolPeb+JtFrLliLVIRkPgpraQKF/w2Xidb5pCOHYsdKkPRmN7wDutG/UUbk+ndzvw79q9FNGkOLfqkWabD5LBTAv2EEKVimTIVDjGIQjmPukvNyGA9P/eBypQIoDMonlp4QdEyJdD+JHn7rXCinPOeIQBIb3EeADlmJw7RVlANPW6Cd+XeXMhUc5ZwarxCVufC2vtNx/wFPB1LrnGvzcOZV2lxt/J7vJRseSeRAESc5U+quqrL/O9ILKGo0ONejPuPh27gOjEFXq5UM3BzBBVrU/U57/lOitaILmCYSqn/x9o8cuOeuKuTbjj/lT8D8bZD8iA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(5660300002)(2906002)(86362001)(6862004)(66556008)(4326008)(54906003)(6636002)(66946007)(33716001)(6506007)(53546011)(38100700002)(9686003)(26005)(66476007)(6512007)(186003)(316002)(8936002)(508600001)(85182001)(8676002)(83380400001)(82960400001)(6666004)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3FYL090Nm42YUgvbzlVVThTVW1CdlV3UzVWeWYrTE8xUnVWRkt4S3hHVEJm?= =?utf-8?B?VzcyVmVpc244MytYelRUMUdodWJqMXNYc3lNTjdNOTBLcFJXTERZdGdGeFht?= =?utf-8?B?VVdPOFRVZmY4a0luQk1scGcvQUNDaXIzQkN1N1Fha1k1bEFEeEZySzZsWEVU?= =?utf-8?B?T1dCUHFtYkFUbktla1l5UnZsckNxQTlCRTgzN1Vhb1ZaTHZ4czYzWDhTeU0z?= =?utf-8?B?OWJNbzd4YmxoSm5JcTVpeGVuaVVHMlBJWlNESzMzQXdsVDVDRGxDOEgxdWNJ?= =?utf-8?B?dHNtZk5YcTJnbUxXTCtXTm0rNXhva0crOFJMZGJDQjlZUTFUTENZWTB4U09u?= =?utf-8?B?dXF6RHQvZVFSblA2V3hKSW5XRitsK2NKYVF6aEJPNENueUZ2bm01TTJWQWUz?= =?utf-8?B?b3ZPNEw5eEdrMFhNYW9yajhwSVE5VFVmMnBtdzRVVm5HVmFkQVNzaGFOa2JS?= =?utf-8?B?YU10WjN4N294bkx2V3lFT3Fmd2x2TmpsZU5KT3p3YnNnaDArZlNPUys2aUxi?= =?utf-8?B?NzRDQTFvVEFibEF3K3I0OUtxRlB6UEJIMXdUMFVXb1ZtMlVCY2tzRXFMcDFn?= =?utf-8?B?WllDcTBjRUIwN2taVEowS1ptVkRxVWhSNG00UE9aSSs2NFg2bmUyYXg1TFVD?= =?utf-8?B?enYraWhkallnMDNZT2NTS2RwY3U0cFNzMGR5aERBNGN5dkVUTER6a1NBV0I4?= =?utf-8?B?Y2Z1cnl4bDU3NFRmZDFJQW9objI2MVNRU2lodDE5bmoyYkhST1kwc0R0cVdX?= =?utf-8?B?VXZLdXQwQkZjRm5HN2lEYmFwd1o3MENiV0JmUmdPTU5kejVBY0Fqd2tKekNT?= =?utf-8?B?MHJBWW9CbU5zT05jOWNMdjRJdDk2N2Vnd0M5S1p4TU1JMVpBY2o1SWswbkJT?= =?utf-8?B?cGNHcDcrMEREaFFNRmVpNG50YTNZNkg4SEhwRllBRm5NYThTeno2YnQwNjJw?= =?utf-8?B?anJOVVNlWjdTRlg1djRrazhGSWZBcGxDMzk2NGlSNlcxaUlwcXBxTUtMVUFD?= =?utf-8?B?R042NUY0QzNTVW1vdENzY1ZlalFaN0lPTEo3NFowVXJoUFdQY3NMMHA3L0lw?= =?utf-8?B?WmRLbWt6UVViU093Mk4vMHFuOE9STzNQay9zakl2UE5KMktyc3hsdWhBclR2?= =?utf-8?B?Sk9IU21tM2RsUDd0MHgvcGNYdHdSaDBHY2FKQ0VSM1Y5dm9rNHYreUluVmlm?= =?utf-8?B?cjhEV3hDMmVCTWxnZUxlbis0TkNRcTc1TnZrWlpma1krN1pwa3FFeTZRNkFU?= =?utf-8?B?OCt2Y3hzdUFCYit1MGJYY3FRTVNsN0o1M1NrTEFZcllRTnByOVUxSmVRVkNl?= =?utf-8?B?ZUI5MDVNbm8wMWt3SXVhSmszenpyNjNKVkdJd0RhYnNuOXdHaUVuQ0NXNmVT?= =?utf-8?B?WXA1TTZUS093YkV1N0NuK2xBaWdqdGcyMk5FTzB3emx3VWlVcVFXYlpyZE5u?= =?utf-8?B?UDRhelZ3Ujl3OHlrRWxqRWhHOFlpaHlkQjVnTTNmNWhhM1ltR1BKd08wNXRL?= =?utf-8?B?am9tbkVlSDJVL0psZjJrNUh5TzE5Z3lEZlpDcHJKNCtXNVluVHNGQ3k4dklF?= =?utf-8?B?eW83TWplZXQ5YVpxK3NEZElCcm9kaFZKZnRGQTNVeVRMV2pFV0FIT1JjclRW?= =?utf-8?B?TlBMY3lDM29DQjF4aTE0VGoxd0hjVUpHbE5lUVp1dDhYcnQ1WjJBSUxDd1Fl?= =?utf-8?B?ME9mK0xCY01JYkNaR1dlL2VPZ2UzalA2Q21TSHJ1NTM1RmtmajZaZ2NqS0xY?= =?utf-8?B?bXpIK1lXWnlzZXFNeHczc3hYOEtTa2xuTzNxc3NUR0orNmE4TWFkV0ljVkxE?= =?utf-8?B?WHhWZXdlY2NSdkI2MnlzM0d1RWx6emRsQUVuZzEzTk5WVXBqQmhveDJzaWVQ?= =?utf-8?B?UWdxTG9IeGlQVDhEcys4eCtSdU5oMldQdnlzdHp4WTV3YjZTSDN2TGp0aDla?= =?utf-8?B?SGZ3OEFGT0ZPeHZtVDBNcDlubjk0Qythbkd0bGVCWkI0eXZFK0hQa0phMysz?= =?utf-8?B?WnB2S3l1T2RNKzMyVWdVWGpEWUFvWDAva1B5NmhHTndFUFM1MmlGdVByWVVY?= =?utf-8?B?MzI3bUVzYUY4Q1lYUGRuMkdFMjBoUTRRR2tFcVMrR1RGTUwzYlUwWEdTYmRz?= =?utf-8?B?L2VYdzhJREpBTkNRSWRyZWtrYVpKdUV1WUdBSlN6Q3BldzNmN3BNT3RRNmFy?= =?utf-8?B?OWhTNUp5d3Y5UGxrT05qNHpBRG5MeFp5ZWt6L3lHKzYwdXNONXIrTWhkenB2?= =?utf-8?B?WlB4YTVnemVPU3FXYkJiNlVDMCt5SHNXN2VMMHZnckphWUpKMTY5UnBaeWFT?= =?utf-8?B?dTVMZjc4RERtWUpyTVg0cG5hNHNiQ2JNVjN5dFJsRzlGeE9XbEF5QT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d449f77-42fc-409d-e7cf-08da39920c24 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 12:21:06.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KZTQTF3kHf6KCnNTVychTcIqcfn6V+0H+pLH+pkx4R4YIa+zWV2F9I/DhQvrIc3254ZgD9+wCPnAJzk90qkf/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5455 On Wed, May 18, 2022 at 10:50:02PM +0000, Andrew Cooper wrote: > On 17/05/2022 14:21, Roger Pau Monne wrote: > > Add support for enabling Bus Lock Detection on Intel systems. Such > > detection works by triggering a vmexit, which is enough of a pause to > > prevent a guest from abusing of the Bus Lock. > > "which is enough of a" is a bit firmer than ideal.  "which Andy says > will be ok" is perhaps more accurate. > > Perhaps "which ought to be enough" ? > > A buslock here or there is no problem, and non-malicious software > appears to be devoid of buslocks (hardly surprising - it would be a hard > error on other architectures), but a malicious piece of userspace can > trivially cripple the system. > > Forcing a vmexit on every buslock limits an attacker to one buslock per > however long a vmentry/exit cycle takes. > > > Add an extra perf counter to track the number of Bus Locks detected. > > extra Xen perf counter. > > Because other hypervisors use actual perf counters to emulate this > ability on current hardware.  Maybe something we should consider... > > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > > index d03e78bf0d..02cc7a2023 100644 > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -4053,6 +4053,16 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > > > if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) > > return vmx_failed_vmentry(exit_reason, regs); > > + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) > > + { > > + /* > > + * Delivery of Bus Lock VM exit was pre-empted by a higher priority VM > > + * exit. > > + */ > > + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; > > + if ( exit_reason != EXIT_REASON_BUS_LOCK ) > > + perfc_incr(buslock); > > I'm pretty sure you can drop the if, and do the perfc_incr() > unconditionally.  You won't get EXIT_REASON_BUS_LOCK | > VMX_EXIT_REASONS_BUS_LOCK given that wording in the ISE. I though the same, but got a EXIT_REASON_BUS_LOCK | VMX_EXIT_REASONS_BUS_LOCK fairly easy by simply doing a xchg over a cache line boundary. I think at least on the model I'm testing it looks like VMX_EXIT_REASONS_BUS_LOCK is added unconditionally, regardless of whether the vmexit itself is already EXIT_REASON_BUS_LOCK. > To test, Intel has PENDING_DBG which interferes with most easy attempts > to create the condition, but how about this. > > Load an LDT, misaligned across a cacheline boundary, and set #DB's %cs > to LDT[0] with a clear access bit, then execute an `icebp` instruction.  > The atomic write to set the access bit is a 4-byte access typically. > > This should cause the #DB intercept to trigger on the same instantaneous > boundary that generated the buslock. > > Otherwise, LGTM. If you agree with the above I will modify the commit message and resend. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 19 12:22:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332908.556683 (Exim 4.92) (envelope-from ) id 1nrfAw-0003ot-Uq; Thu, 19 May 2022 12:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332908.556683; Thu, 19 May 2022 12:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfAw-0003ok-Rh; Thu, 19 May 2022 12:22:42 +0000 Received: by outflank-mailman (input) for mailman id 332908; Thu, 19 May 2022 12:22:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfAv-0003oM-HE for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:22:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d62b990-d76e-11ec-837e-e5687231ffcc; Thu, 19 May 2022 14:22:35 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-s3qADb2RMcWpGDcK7cgaNw-1; Thu, 19 May 2022 14:22:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB5913.eurprd04.prod.outlook.com (2603:10a6:10:ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 12:22:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 12:22:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d62b990-d76e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652962959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QDj8nOLE310Yg9AXe/JiJsw5AnGEe1qU8aPSS6+/iTU=; b=XXEFeFW7ZFxW2bNFugi4Be3cy1NinfaCn4q2rybxY1GefDvJ2/q7kyD29z2a3MItYgIeMJ wXVEVvLKGjlaBoubi3wDg8YoGGsMRXxQPAw626IpUE7etWghEd0a/gdxgUHZwDp/E/Gs+G IOOwpvbvTet8TznI6iBZaTJmyNwuVww= X-MC-Unique: s3qADb2RMcWpGDcK7cgaNw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2MATuYi1MYHwt35YauMLDrGJy3bwHdMRaLDlN7jpxK8k7WpTNm9ProHG3hc4+gkl2wsAow5ljj/q/uQBwY1H4ka9ewXHxZ/GK9Yl5+IO8r4f8iYH1QwHk1lG3PH9Kii+/wDIGqVFMmEP0hO7Xs4Oh9DqSXuysirKWzAhAyTCYrbaV04eCCRF2SLaCyw1SXIyRNe3tvj17X79mHL/9HbwS23pSa9cmGGAoAj210Yc7s56tTcyVz3YSDkG+oFzgcL8FVxZQts58y5Wb8FBY/WqYXQBKiNLDnRx8dn+9uX45x7WnkjEghSbPgjHCwkgAEqPlnl3mhsXe7f3FFqeKs2bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSVvAn9AgHGc4nGZhUV6MD2LeqinleQj4ejUP9yl9XQ=; b=ktwgxTMhe7FilWTZ/fYA5JtFWH2mxRHqHXKuGyCMRsYUZ5bcXa2wHbLDj2z5+Ohzcrd+QtD4tX7Z9MFOmGasg9IXJqEGWM38hRcR2LCkkvGl0589p5es40kGqxi0f/CCV9eWRmj89trjqM9RNYtgLv93W+bJy6j0ThbyIGg0wt3Kn5NBYCtUMTj8a62v3yPu8UGE6sLJXn/iOLpFNcuObpoTCqEKlZyM4qdMS6jp5NG+a6cytaGLlinKt1SJVhZs6HywqOQGvnAo+mCRQauBK4Vw4RDl42caKwn/BkfBv59O/35Cknh96AhMfnyeA4RsU4NT6u+zqLu2jUYqqtYxbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <176ef608-6114-d1f6-1772-982d2e7297ff@suse.com> Date: Thu, 19 May 2022 14:22:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] PCI: don't allow "pci-phantom=" to mark real devices as phantom functions Content-Language: en-US From: Jan Beulich To: Andrew Cooper CC: Paul Durrant , "xen-devel@lists.xenproject.org" References: <02804746-c5e3-aada-7096-fbb9d04ca952@suse.com> <3e7eef54-975f-4c2b-2ab0-bcd16289a0c1@suse.com> In-Reply-To: <3e7eef54-975f-4c2b-2ab0-bcd16289a0c1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0174.eurprd06.prod.outlook.com (2603:10a6:20b:45c::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bfbfe79-7bdf-4472-d34d-08da399242c0 X-MS-TrafficTypeDiagnostic: DB8PR04MB5913:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ii//CggxkeyByZPgO7pmo78KLlYMDQxeEQlzT92P0g7LwTjiqHtWEnelCjdVtFSOD8i1yWCwv5fV6mIB4gTcRSSuJFG+cxtrDPio2wTtcTt8jlaZt/i0x0fw1OY0BRm/3NvYUorLREGWVVT6+9cvf4JuPl7V7ycFXD36p0vYRpKxJlqU5X48TVxVtGzb6lufkI99ToRT+OiK0Hgj2NJsfEe6eC8W1E4lDKYaJSjKpCP7XnsACVGONbRkd6Pya6qm4sX9irm34LGRqlH7DTc7rY9U6Lf6qII8Lp5+E7eLuhJJMXALiRXvcdRWRBOZCbiaekRxYLBkuTC+nbEqWDCskmckUiHXOmDgLiP05aLBt6Ww0V9dec+wlstOuM7gggnnD8iRlkktZGkWtZcKoGRKPUxkEte1c2IiYmNFhDpxqYG69E1cyNU1WfqLyGb1zCejryfqe5Hgb81vD3NYuJChg8D6Le+gATZ3dswPUW5znn18BmS1Y3Tr0WQBf/w226NookwKvPeofB+fG8kl3Da/Y5jevTABjnYa4DmjGFjbearKZMu0LOCu3whoAwFqjsP7PcllO6VrQapbuhW8O+JvQYYiQKV/GZs7gmqIZB5+YA9tWT12LpkwmJdJhmqguNREGUPjZvl0TFhLfquGX99t3InG5YVxGhEUfI8BTinzYmU4fevbqX/xeLpfLNS2i/SrPOcJwX9gCMswDyLG7SxNmqwwx0Cf//dkd4U2/XVSG25h0xUnkP9MIvaaO1Dq/wab X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(6512007)(4326008)(6506007)(31686004)(2616005)(38100700002)(186003)(2906002)(86362001)(66476007)(66556008)(26005)(53546011)(8676002)(31696002)(5660300002)(36756003)(508600001)(8936002)(83380400001)(316002)(6916009)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nFqlUMlHj+h5Md2Y3HwKGcrpPxrB8TZWr6oMZuVjah4GuKs8TF1bkfi9Zz8e?= =?us-ascii?Q?XOnvFTTM/rrEbBHsnuUDxwBQWm8+/1PUXfe21lfYXfqoj/zhNYxoySgzTMYc?= =?us-ascii?Q?++6+VUQ19HkUlngKZNh235BNNYSPkbEVUsRCrAz7G4t3GQG8uMkmZqanOst4?= =?us-ascii?Q?/mU1JdwtiQeYuJV8ca9h0Cnd7k1gSw1YYnK3F6Gq0bTNd18k0a5YlpJATk9x?= =?us-ascii?Q?/KfEsWLAO5GcktOB2a00peC/i1VaCrvXA/Ok68UgP2R8LwunVOom8W61F7iQ?= =?us-ascii?Q?7ACZ2XoGaEjJqOOqLVEPWEiBPtYQzYrmRwUWWvcCQ+YZse7zhtAoksjFU1eQ?= =?us-ascii?Q?aKoaYG/AnsThMglyV6BLlnprHHM9YJIyjN8ql5AOITH59RI5WlrAjG2jlqlm?= =?us-ascii?Q?ovQV6EVDRiMmFLKIlBNj/HkhoVQNug91oDZkqQdhP1aR4Dop8DIUEh5mL943?= =?us-ascii?Q?lGdL/vwAOOL5KRTFt75ObBXui1t4D0FYwEzdDUtHLh5igzdyOBj3tAAYVH/a?= =?us-ascii?Q?7qVFOmYF2PqXkLK41IzjMZ/p2WFqKDlAWKKpUml3slYF+7HojiPvVinfow/C?= =?us-ascii?Q?J+vN+VU6xGBahxJDnJ0OQTun+AHwPfc/xSgqwBwU6F30NH0jqdaD8cDCznjx?= =?us-ascii?Q?75/dQhILGJZdc9R84rGUySoWnwFo+Y8Noifc4qNwPboKwr2Um8FatGX+6vjb?= =?us-ascii?Q?oz8qLGD/Ip9B3s+zn0K/MlobDDvKyJZh11CcN/JprTnPqRtuAHLVPuX07NEJ?= =?us-ascii?Q?JJGtsKf82GfxxxLQ35KgNJjzIkBKus83YE+hwbbp2ghwhYCO6NGo6GJ7nsvU?= =?us-ascii?Q?L4T9g26i8/gksOpvnXqdg1zb/JQYkofS+kR7zooQGw403J+dmfS5geybC2Yy?= =?us-ascii?Q?mqkNra/b0oSpCP7jJVbKmLLkD+W5zrZdWbkRQVQ9qxL3ev+bGYgQDkaxdO4Y?= =?us-ascii?Q?XtOjds+3srUjyQdohipjoY4kRQofqh9k0AQfB3AtohFnBo2jP8jp2if/FXsT?= =?us-ascii?Q?sSuetZFaACQ9tQTEqLlqaxnX3Zo+9YlGSA2ncfrBfZ4DeOycpKRA6MERPkSM?= =?us-ascii?Q?aEwWKKZXsL158xsEwoD3wE7wMTR+bSl8CYiIqbWmFwq5Tn5AU+6g8HzTyx7J?= =?us-ascii?Q?sFPyJ98IrUb491VNb5BI/ON19JUUnOCyO7S/oxysjw11HTk/zX0TYU5TOR78?= =?us-ascii?Q?uJwnAqpbq7oz2lOiuHpQKcIrTOQbyLLPenyI2bnzoVjZKi/3LBAG/B5H8pTO?= =?us-ascii?Q?cuoH0f9Lbwdrm0SXIfct17S+HRBcHJSjFiVMYnM3c0CySMeDSInx2fh9IjeX?= =?us-ascii?Q?I422Ql2f3J7A5dqZOugodOUYcjOf8ZtKFxpE0rP8653qC6y8QI1brJLh5knU?= =?us-ascii?Q?tUYs1xAMxB8vGA4dVplA1IoP+V6t45KI0t/bQz68BVytZiVR6i+HuQV1/9PB?= =?us-ascii?Q?CSzyaLnmXhuPvgKW3wqFuB+Hjxmvk3y9vXk3F4x0vviJh8Uz3DErqDHGztul?= =?us-ascii?Q?OTvvGnD16Uhl6zUbjPm1hRzIo/ii3pWw9VnOIp4UonzzLRrXHCDexX9Nyt6v?= =?us-ascii?Q?eqTEKvOIR05s8Vg++chXbgzUGt8R7YFJxtc0lxzcxCeTHcBSiXHs5TU/lgwi?= =?us-ascii?Q?CuKiS3F2Jc69ZQPlhfhj5mnwaahhVcDlHausoAXoYlDNjnROqT5ZJ5qvyVTt?= =?us-ascii?Q?sylNHWzsG08rNKVlSeb1xfdeS+/WdmPT5krP711r+PVz95iT/ZfIqY6k2uWJ?= =?us-ascii?Q?QdRumPesyA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bfbfe79-7bdf-4472-d34d-08da399242c0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 12:22:37.5850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hBRXwEZ3CYEmuu7z5Z9pQ1EvwXYE2YfSXoiIjYX5u6IbrxmO49zNXnO+YBdAlGpBRIY+4QxgIuLVgxA+SfNDVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5913 On 06.05.2022 08:21, Jan Beulich wrote: > On 05.05.2022 21:10, Andrew Cooper wrote: >> On 29/04/2022 14:05, Jan Beulich wrote: >>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachmen= ts unless you have verified the sender and know the content is safe. >>> >>> IOMMU code mapping / unmapping devices and interrupts will misbehave if >>> a wrong command line option declared a function "phantom" when there's = a >>> real device at that position. Warn about this and adjust the specified >>> stride (in the worst case ignoring the option altogether). >>> >>> Requested-by: Andrew Cooper >>> Signed-off-by: Jan Beulich >>> >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -451,7 +451,24 @@ static struct pci_dev *alloc_pdev(struct >>> phantom_devs[i].slot =3D=3D PCI_SLOT(devfn) &= & >>> phantom_devs[i].stride > PCI_FUNC(devfn) ) >>> { >>> - pdev->phantom_stride =3D phantom_devs[i].strid= e; >>> + pci_sbdf_t sbdf =3D pdev->sbdf; >>> + unsigned int stride =3D phantom_devs[i].stride= ; >>> + >>> + while ( (sbdf.fn +=3D stride) > PCI_FUNC(devfn= ) ) >> >> I'm fairly sure this doesn't do what you want it to. >> >> .fn is a 3 bit bitfield, meaning the +=3D will be truncated before the >> compare. >=20 > And this is precisely what I'm after: I want to stop once the value > has wrapped. >=20 >>> + { >>> + if ( pci_conf_read16(sbdf, PCI_VENDOR_ID) = =3D=3D 0xffff && >>> + pci_conf_read16(sbdf, PCI_DEVICE_ID) = =3D=3D 0xffff ) >>> + continue; >>> + stride <<=3D 1; >>> + printk(XENLOG_WARNING >>> + "%pp looks to be a real device; bum= ping %04x:%02x:%02x stride to %u\n", >>> + &sbdf, phantom_devs[i].seg, >>> + phantom_devs[i].bus, phantom_devs[i= ].slot, >>> + stride); >>> + sbdf =3D pdev->sbdf; >>> + } >>> + if ( PCI_FUNC(stride) ) >> >> This is an obfuscated way of writing stride < 8. >=20 > And intentionally so, matching a few other similar instances elsewhere. > An open-coded 8 here doesn't really make clear where that 8 would be > coming from. The use of PCI_FUNC(), otoh, documents what's meant. >=20 >> Given the printk(), if we actually find an 8-function device, what gets >> printed (AFAICT) will be "bumping to 8" when in fact we mean "totally >> ignoring the option".=C2=A0 I think this really wants an else clause. >=20 > Yes, "bumping to 8" is what is being printed in that case. I did > realize the slight anomaly when writing the code and I observed > (verified) it also in testing. But I didn't see a good reason for an > "else" here - 8 being mentioned in the log message is clear enough > for anyone vaguely understanding phantom functions. But if you strongly > think we need to make the code yet larger and indentation yet > unhelpfully deeper, then I will (begrudgingly) do what you ask for. But > please explicitly confirm. Like for the first few patches of the IOMMU large page series, I'm going to put this in (with Roger's R-b) by the end of the week on the assumption that my reply (above) did address your concerns. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 12:44:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 12:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332929.556698 (Exim 4.92) (envelope-from ) id 1nrfVr-0006Nx-So; Thu, 19 May 2022 12:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332929.556698; Thu, 19 May 2022 12:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfVr-0006Np-PC; Thu, 19 May 2022 12:44:19 +0000 Received: by outflank-mailman (input) for mailman id 332929; Thu, 19 May 2022 12:44:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfVq-0006NQ-7O for xen-devel@lists.xenproject.org; Thu, 19 May 2022 12:44:18 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63e8da7c-d771-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 14:44:16 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 May 2022 08:44:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5837.namprd03.prod.outlook.com (2603:10b6:a03:2df::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 12:44:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.016; Thu, 19 May 2022 12:44:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63e8da7c-d771-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652964257; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=7xs7fh9jGwQ3TzYrbbOPuex8BoTxFH1w68QsiJXOWC4=; b=T/vXVvbIpY8spV8zTk107snWAL2ARunUxCSA+2mtNrxuEaVXvr6U2MQu flqgCHjjtGmELrgrzNiQC3U7rbMlHQImECouqrSOq5SHrG3vGMJuO40R4 HmSZJ9IL0avZqAoMcLevSRP1isXbLphXgqJAK/jVN/EmbEIfxuvlrjHdJ M=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 72085922 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:fbZNtKz7aceEUmi10AN6t+f0xyrEfRIJ4+MujC+fZmUNrF6WrkUBm jRLWW6DO/iMYTb1L9x1YYzl9x5Uv8PVnNJgHgI+/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12InhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplh8C8bwcJDPz1it8MdgVkSypAHI1t0eqSSZS/mZT7I0zuVVLJmq8rKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtadHeOWvLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrialK20F+QjPzUYxy2/9xSZQ4YPNCdPMQuCFZe5PmEjfr H2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqF+Owm0eDjUGWF39puO24malQM5WI UEQ/isorIAx+VatQ927WAe3yFabujYMVtwWFPc1gCmP16yS5Q+aD2oFSzdpado6uctwTjsvv neKks3oA3pzsbSTYXOb6rqQ6zi1PEA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q w1mtwA7jrQXyMsUjaOy+Amdhyr2/sSQCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnzjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:x5pO0qsvnIkhpX0rSQnmseAM7skC5YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YaT0EcMqyNMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPHxXgspbnmNE42igYy9LrF4sP+tCKH PQ3LsPm9LmEk5nHviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y6o2mfvVmEp6VO91xMPdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="72085922" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQTo2HS1mfPrOBAzkDzST5oRpJy5/5feOybuZ5uni738OvebfWXlMSygZigRUrbeqy9OZq8h6ucKS59w2QMwDwoE0dpLUnsA4y1/DEUoAlxtKQawWuto2WXQ3KJl+TN4mUW5p4cp5JjPFm6I4di1CkP4oMzGxvHVQ6rF0HbQKn5rhIKOt7C6B+xmf81Bz8dN8HtYDlIsj/s/draxftzSFojBSjcWlMZt1HsdHc/unKIf/GDmDvhlj2PDq6i3UUwJgPtTwfLbIE9fNC6zsdjyomwl9qUd3kT3cwedHksLkRoEjgYGpdjlC+6N9QJyDr/+IHA620PqkhEe6Rijyg1mRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z0AFcOzXgPed0QR8GiVtIfq1e/KCM27xxJIur1+7LhA=; b=hXM3IyJarJgjp6xPyz2XoR5lT256nYSRLXwjQncPaHDKXltT8dIz5KfAojFb1+pEBoJRKs7KhIVSRsKsIP07wFb+U2Zxk+sKVezgYdN/+4gf99O2ca45NwuVgFmgf+ldIa/595thzTAI3u/2fQPLRQ/E0sBqiCKPJW+iVGFUQfpYYMY9AwwXW9lPhSY3t7Jk8krbKKlM668oSuoWRB0/un36zdvm22A8/gHVkallOdguEHciEl+G61jYJeFRlu/K3xZClyKOWceKYRlEFVCADr70+hrfg2h8XKNPegH6GJ8aWoq/xHRDaAyN9WIuYhhNFBOuwHFyOLJ9MW782G7WkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z0AFcOzXgPed0QR8GiVtIfq1e/KCM27xxJIur1+7LhA=; b=XomgmqFkrCbc16pocOcQ1xW3LHgq6+lySwrNisIbw9u4ztlIuzyxR/RMu9JXGLaS5ZIywY+u2wn3KhbFkHT1ZLhLEwjtaYT4dliKI2MbDuUbvvBZV5wYvwCm0Xysc8+7OHGPgvP5yg6mcIiF9VGwmsbSUQ31QkbQHHaah6iF6Ao= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 19 May 2022 14:44:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> <5cf98549-6fc0-67f7-a882-0778e7ab6f98@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5cf98549-6fc0-67f7-a882-0778e7ab6f98@suse.com> X-ClientProxiedBy: LO2P123CA0084.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d050804f-60f8-42af-89f9-08da39954522 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5837:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BvbpqG2OCrOndi4Egqe4pk9qlWBoIhSgHu8JaDF0ypq03plPu3t8l3QDjuwiiXwH7wEHOjRfHJqsEgc07Kl708YMhXHH4Sizafna3ekHs+jxHaiuYa2+accAbgnsnWf7sHk7eJJsMnXbbyJMgq/LpqkLdfA492UIl4SgQFamNbAxUmXiFLdAQDMJTHU6h6kgojrhtJMcZr9R4y4JtOAv4qDWSHLClanCsf4ZF2GjvUAYLDHoAamscoX8SApaItwV/uJq7L/oIwfTs/ArOBTr730+itYqlpCvSig3F0pKAsfCTsesjesY8kmNfdeTts6aTMw9BLrt4FrQHK69VHzPV73JqRyXCsPNC2bYjEyhqWnHUxsyNY2elBwIYne3nI3TsjU/B83N6eH7ewo99emWHbHEtN43hKZGIiC1xma+9ubZfWqUCuZ2uFwEw0ZlBT92tQNsfglOpENobe+3e4Tq98x+vHy5xyJTYkrUqYcr9iR/4h6t2PiyhooKfFaz9VQMayZnaA+qfDLq4xY3koGAgTWts/LOkygoll0pQ01ems2po4dkTQd6H+o1q1VGcflZ854NDhx2op80ruMdTfqWtW0yy317MmrGknOPAqmr+aESCWN/4Q6yDnNySx+Kdc/kjArBxSpRoXLaKzhtyPsaew== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8936002)(9686003)(6916009)(508600001)(2906002)(82960400001)(54906003)(5660300002)(6512007)(85182001)(4326008)(66556008)(66476007)(66946007)(186003)(8676002)(53546011)(316002)(86362001)(83380400001)(26005)(6506007)(38100700002)(6486002)(33716001)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U24wSjZxR2FUTE0rUGJDbWk4dVg4Y2h6amM0V2haUEJ5VHdsZDRtTCtPOTJK?= =?utf-8?B?NkZPR0xEMEh6SC81QmtzY1d2bzRvQ0Y4dGErTms4eHg4c1FrOWZzOW9oMEFk?= =?utf-8?B?Z01qaDRQWi94U3hLL0Q5R0JSQzdMWFMyWEZwcHNkVHlHNXFQUHk0cWVUNjFB?= =?utf-8?B?ZmhKb2h3cjJyQ3p5SVJhWmNVb2JqYmxmUUlQS21mLyt5WDdaa05OdURRK1dy?= =?utf-8?B?VzVHWHIwbUtvM0pMN0dNZ1RqSlJLbFdPdkI3bE9xbDNEWkF4clZwZEJtYnJS?= =?utf-8?B?QTVZYTVDL1dPWWZIVExsb1JSdklxb1dkejR2Z3Q0Y2M3cUNxR2kraC9RNk1C?= =?utf-8?B?Wk9sd2ZHazJscjR3eC91V0pHR0RCSFN4TGpaUFFjT0h2SHNtQjYwcmpPRmZY?= =?utf-8?B?R0lXQkxzVUtJZVppVVh3czZCSi9BYktQZThwTUwzdnVqV2NWdkJZL0wwTytV?= =?utf-8?B?OWo5alBuL3MwanlqazlscUVDQUJZeVIxMmlkK2M1ZlZ5L3Uya2huSlV0bWhn?= =?utf-8?B?WC9QUER3Unh2NFN6b09QSklMdmlHcTY3c1AxMjRyTVJnVDMzeHlZWTY0RUNr?= =?utf-8?B?ZERtdHpsQ3pMWDI4RjMxckJtUERnZTBMTm94ZVFKVTlJRTh3TndjbEFsNnFt?= =?utf-8?B?V0toaXVoTUJ5b0MyRU1odVkwR3V6TUtlaVVsdFhMVHhHMW0ySXRXUU9MMCtT?= =?utf-8?B?NVBVVkR2ZUhmd2xTayt4Q2llSUZtT3Q5Y1cxWG01dCt1Mk80TjBWVzFMclRw?= =?utf-8?B?U1FrSjVaYmJ5M3Q4QllmOVpyUHVWRC9CTUJCejc3M2FaUkVDUHB5NC95RXZw?= =?utf-8?B?SEk0OTBZakdBNVpwYUpDODYwdWQ2dHVNQjFra21nLzc2ZFZnME01Vm9qRjQx?= =?utf-8?B?enhmYWFCSWllODJQMW9wR3NsT2hZL1AyQVM4dEJkd1FtOWRJaXdVVWdaUVJ4?= =?utf-8?B?dXlNWGw0d2RwR09yQ005eUtqQjAwMFpvK3N3QU5TcnAwY0Q5cWVkTnE3MW8y?= =?utf-8?B?QXZsMFdqWis5KzRNbExHeTZ5ZStzaHBDQ2tNN1EyQWVQVENNZEdablJhY3dU?= =?utf-8?B?eHZyWnNBUlJNRTQya1JXOTN0aS9JTTJNMm5IT3pyMGlCdG5tNklLZ21hOElW?= =?utf-8?B?VHZmeWtBSXRBbU1UQWx0SkNwWk5vSi9IQmZlRjlQVzVZVmZRampPd0trNHRR?= =?utf-8?B?dEpZU1YwUTRFOURBblRIN2NIR2FaOEgrVGJUdjU3ZVhnUTBpUDkyMS9OVUls?= =?utf-8?B?Y0poS1pTQWRqdEI1cEpFRnVVc05JYkJ5M01XMUt0Q2diUmtDaGQySkYxU3Bw?= =?utf-8?B?b0did25QeG5jNFRlMFpZUW9zVnJMd1owVkFqZEZCV241enl6MTFwckxnZVE4?= =?utf-8?B?Y0xSMDlsdjk5UFErSHNSMlpFVTFCMUwzRXhDOEVtcjY5ZkR3NHovK0VONUFn?= =?utf-8?B?L0xhNXdkeHJVVnlvaFZjSkN3T3dZSEU2K0Q4NDhpeDJsM3BRWXk5MVc4K1Za?= =?utf-8?B?OUNQVHdVMVhBR09laDF5RzBjS0l3OStPNjZxZytHb0hKZHRDd0VwSlQ3ZWdn?= =?utf-8?B?WnllU2pIb3UzUkplbkwwK2FjN1p2MXFPcUNucUpzdXBlV2pueXIwdFV4Zmha?= =?utf-8?B?MlpsVDFaUXM0TDdWRTF6WWtjNFJ5NVZRK3Q1NzhBZTk4Q2psaDFoSk9LbC9B?= =?utf-8?B?T0RBTE9BOTBLMWN0OTMwVEljMmllQ09mTXpUK1dDeFFSZkxmZTNreEtibk0z?= =?utf-8?B?VmdTL0ZYL3l0a3l3QXR1aFB0ejN5eE41YVBrZHhpSkFYRWthbEZPSVcwY1Ar?= =?utf-8?B?dERYUGV6MVhqbGtjYXExb0JsM0lLN2pOSEo4dWRDdk9wWkpuemQ0cENMcGdD?= =?utf-8?B?Q3VDUGViTExYOTRRUlRmYVBwY0t2MTk4Zi9qSnJlVWhudU8wQWxacUcrejd4?= =?utf-8?B?WVVyWUVJdUhxbkJ3M2QwVWMrL3ZaNjhoc1g4bFNpL1djK1ZvVldLc1FUQkxt?= =?utf-8?B?QVEzZGxzekM3SWlkbzJWM3dCMFNxVHRHbmtucmJUMWt0UndIVHZBckN2NUZV?= =?utf-8?B?ZVVaajNEVGQycW9wUDJINzVKb1FtZWN4UGRCRGFwRVc3UUZVMnJYa05FekJa?= =?utf-8?B?c3JOKzJlL1dSZFV6NlN1cFVqWE5XclM0SFFseEZHOFpnY24xTFR2L1JkZ2RE?= =?utf-8?B?WTJSbnRGWnZSYitxOE05Zm9RNlpLTWxFMzRTOUR5ZUlnSGdObjhvZVQ4dEpw?= =?utf-8?B?cUFJNzQwV0FMRjRNWFVET1pENXpCYTVzM0VybHJUUG04dmxFN1dTK21QeWh6?= =?utf-8?B?eU1MVkVpWGE3TjVYNXR1OXIwWnB0T2F6aTRPYjFzU1JUaVB6ZmU2L0ZBN2JP?= =?utf-8?Q?ioaU1vcQRpCZh+Qs=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d050804f-60f8-42af-89f9-08da39954522 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 12:44:10.0554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vku9EUS6iCxAj7JgyBggv/LCSlUkHlNhrliy8uGQlh3/h910oz6GKqxnJoQ9LJTyHysSe5YfPerfHzPd/G7+CQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5837 On Thu, May 19, 2022 at 08:50:55AM +0200, Jan Beulich wrote: > On 17.05.2022 15:21, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > > @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); > > static unsigned int __read_mostly ple_window = 4096; > > integer_param("ple_window", ple_window); > > > > +static int __read_mostly vm_notify_window; > > __ro_after_init? Yes, I tend to forget we have this now. > > @@ -1333,6 +1338,19 @@ static int construct_vmcs(struct vcpu *v) > > rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, > > VMX_MSR_GUEST_LOADONLY); > > > > + if ( cpu_has_vmx_notify_vm_exiting && vm_notify_window >= 0 ) > > The assumption then is that values >= 2^^31 are nonsense? Generally > I'd think we want to special case merely ~0u, giving the variable > unsigned type. OK, I really don't know whether >= 2^31 makes sense or not, I would think that using such values the window would be too big to be helpful. In any case I don't see a point in preventing >= 2^31 so will adjust the type and check. > However, I also don't see where you disable use of > the feature in that case: Merely skipping the VMCS update here isn't > enough, is it? The field itself doesn't know any special case > values (like ~0) as per the doc I'm looking at. So I guess the OR-ing > in of SECONDARY_EXEC_NOTIFY_VM_EXITING in vmx_init_vmcs_config() > wants to be conditional. I've sent the disabling chunk as a followup, forgot to add it here, sorry. > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > */ > > break; > > > > + case EXIT_REASON_NOTIFY: > > + __vmread(EXIT_QUALIFICATION, &exit_qualification); > > + > > + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) > > + { > > + perfc_incr(vmnotify_crash); > > Is this a useful event to count? We don't count other crash causes, > iirc. I thought it was helpful information from an admin PoV, but maybe I'm mistaken. I know we don't count other crash reasons, but that doesn't mean it won't be helpful to do so. Given that users have to opt-in to enable counters I suggest to leave the counter there. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 19 13:06:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 13:06:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332946.556713 (Exim 4.92) (envelope-from ) id 1nrfqy-0000RT-NC; Thu, 19 May 2022 13:06:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332946.556713; Thu, 19 May 2022 13:06:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfqy-0000RM-K9; Thu, 19 May 2022 13:06:08 +0000 Received: by outflank-mailman (input) for mailman id 332946; Thu, 19 May 2022 13:06:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrfqx-0000RG-5p for xen-devel@lists.xenproject.org; Thu, 19 May 2022 13:06:07 +0000 Received: from ppsw-41.csi.cam.ac.uk (ppsw-41.csi.cam.ac.uk [131.111.8.141]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f2aba07-d774-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 15:06:05 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34306) by ppsw-41.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1nrfqg-000gSU-Py (Exim 4.95) (return-path ); Thu, 19 May 2022 14:05:50 +0100 Received: from [10.80.3.190] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C471C1FA77; Thu, 19 May 2022 14:05:49 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f2aba07-d774-11ec-bd2c-47488cf2e6aa X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <096a2967-1947-1d49-fa9f-c33bce7bb108@srcf.net> Date: Thu, 19 May 2022 14:05:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-GB To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jun Nakajima , Kevin Tian , Jan Beulich , Wei Liu References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-2-roger.pau@citrix.com> <84ee0886-9ed2-97ad-e9f9-c81e8a3885c5@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 1/2] x86/vmx: implement Bus Lock detection In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19/05/2022 13:21, Roger Pau Monné wrote: > On Wed, May 18, 2022 at 10:50:02PM +0000, Andrew Cooper wrote: >> On 17/05/2022 14:21, Roger Pau Monne wrote: >>> Add support for enabling Bus Lock Detection on Intel systems. Such >>> detection works by triggering a vmexit, which is enough of a pause to >>> prevent a guest from abusing of the Bus Lock. >> "which is enough of a" is a bit firmer than ideal.  "which Andy says >> will be ok" is perhaps more accurate. >> >> Perhaps "which ought to be enough" ? >> >> A buslock here or there is no problem, and non-malicious software >> appears to be devoid of buslocks (hardly surprising - it would be a hard >> error on other architectures), but a malicious piece of userspace can >> trivially cripple the system. >> >> Forcing a vmexit on every buslock limits an attacker to one buslock per >> however long a vmentry/exit cycle takes. >> >>> Add an extra perf counter to track the number of Bus Locks detected. >> extra Xen perf counter. >> >> Because other hypervisors use actual perf counters to emulate this >> ability on current hardware.  Maybe something we should consider... >> >>> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c >>> index d03e78bf0d..02cc7a2023 100644 >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -4053,6 +4053,16 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >>> >>> if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) >>> return vmx_failed_vmentry(exit_reason, regs); >>> + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) >>> + { >>> + /* >>> + * Delivery of Bus Lock VM exit was pre-empted by a higher priority VM >>> + * exit. >>> + */ >>> + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; >>> + if ( exit_reason != EXIT_REASON_BUS_LOCK ) >>> + perfc_incr(buslock); >> I'm pretty sure you can drop the if, and do the perfc_incr() >> unconditionally.  You won't get EXIT_REASON_BUS_LOCK | >> VMX_EXIT_REASONS_BUS_LOCK given that wording in the ISE. > I though the same, but got a EXIT_REASON_BUS_LOCK | > VMX_EXIT_REASONS_BUS_LOCK fairly easy by simply doing a xchg over a > cache line boundary. > > I think at least on the model I'm testing it looks like > VMX_EXIT_REASONS_BUS_LOCK is added unconditionally, regardless of > whether the vmexit itself is already EXIT_REASON_BUS_LOCK. Hmm, in which case you've found either an SDP bug, or a documentation bug. Lets follow up with Intel and try to identify which it is. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu May 19 13:17:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 13:17:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332958.556724 (Exim 4.92) (envelope-from ) id 1nrg1b-0001wx-Ok; Thu, 19 May 2022 13:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332958.556724; Thu, 19 May 2022 13:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrg1b-0001wq-Ky; Thu, 19 May 2022 13:17:07 +0000 Received: by outflank-mailman (input) for mailman id 332958; Thu, 19 May 2022 13:17:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrg1a-0001wk-F5 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 13:17:06 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8996407-d775-11ec-837e-e5687231ffcc; Thu, 19 May 2022 15:17:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8996407-d775-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652966224; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kwJWUVJP9XHoEw/vpbMs72YU20U0++WYBU1e/pXt2jc=; b=IMILEqTsHS8nJ6nUULpsg0fgKEXc8oBHQ4YlARNUePTVK8pH9tTv2zvS RGAZZGTbOXgmWWaw1QoKfHsgG5NOFEANa+9jc+WoGfp53YlCxh7hkaNid eGha0hbRKI6I6qx3+KC17p5kanFIkHg5jEKbH9ePssPd7QT+gAQMH8Lwo g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74203548 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:1NTqHKtK6zbhzjNODpZ2V7XSZefnVCJeMUV32f8akzHdYApBsoF/q tZmKTzUOKqJYDGkL9Bxb4q0pksOupfWm95mQABlqS4yQiND+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U6 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8NEvfhu745CyMfGh49IO5MppHVJCag5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUzNkybPkEfUrsRIMskh/v5hUjhSWJ3jAK5oLQ70zjxyhMkhdABN/KKI4fXFK25hH2wu Wbu72n/RBYAO7S32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5ruO+kVWWQM9EJ gof/S9GkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwCWhkIf3uSLBPC8NcX1cK9Z4mt0zGyN/g zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmqm 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtJ6sz67DFzFtW UTofODHtYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmwkdB4zbptdJ2SxC KM2he+2zMYDVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz jqoH5LalEoECLemOUE6M+c7dDg3EJTyPriuw+Q/SwJJClMO9L0JYxMJ/Y4cRg== IronPort-HdrOrdr: A9a23:mM83DqByNlqkEtHlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="74203548" Date: Thu, 19 May 2022 14:16:50 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH v3] tools/libs/light: update xenstore entry when setting max domain memory Message-ID: References: <20220502084729.13044-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220502084729.13044-1-jgross@suse.com> On Mon, May 02, 2022 at 10:47:29AM +0200, Juergen Gross wrote: > libxl_domain_setmaxmem() called during "xl mem-max" should update the > domain's memory/static-max Xenstore node, as otherwise "xl mem-set" > won't be able to set the memory size to the new maximum. > > Adjust the related comments and documentation accordingly. > > Signed-off-by: Juergen Gross Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 19 13:28:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 13:28:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332973.556739 (Exim 4.92) (envelope-from ) id 1nrgCL-0003WR-SI; Thu, 19 May 2022 13:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332973.556739; Thu, 19 May 2022 13:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgCL-0003WK-Ox; Thu, 19 May 2022 13:28:13 +0000 Received: by outflank-mailman (input) for mailman id 332973; Thu, 19 May 2022 13:28:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgCJ-0003WE-Tl for xen-devel@lists.xenproject.org; Thu, 19 May 2022 13:28:12 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 823b5a1a-d777-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 15:28:05 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 06:28:02 -0700 Received: from tlengyel-mobl3.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.213.172.167]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 06:28:00 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 823b5a1a-d777-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652966885; x=1684502885; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zxkU79kiZQ0Xv31PEe8WAmmoX/6h53i+GCeRX9CU+x4=; b=U+XY/BmK18zZfAetjpeuwveLP1mngmvdKKCK+jqaVJ8F0C2GGliV+5jt M0P1ifKtVlMQOPsVnWSYk7IQ5wJUduLSrH4a1Atf7/SUOMLtL7IERzOPl kmx116gtiDZJGX2ID7PBV8ZSzLg42FAMyXfOryeJODNwq1HCtp4nL8l8Q id91VkXBgaDbizS/w5OgGSwNEuMK2szVRlU3lq+gRU/gxx+gcB7HC2mII tnrcK6/IgUtEQBM3WknoX1GfHCx7XjHQ8SvOey+53/AivLyxxWpgIxdWm CVYjA5C8XzFcx42njAEihBzWM0i6As6xz4W9cRQAVqKMtQFOurvFrfXct A==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="358608399" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="358608399" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="606486489" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper Subject: [PATCH] tools/libs/ctrl: add and export xc_memory_op Date: Thu, 19 May 2022 09:27:49 -0400 Message-Id: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add and export xc_memory_op so that do_memory_op can be used by tools linking with libxc. This is effectively in the same spirit as the existing xc_domctl and xc_sysctl functions, which are already exported. In this patch we move do_memory_op into xc_private.h as a static inline function and convert its 'cmd' input from int to unsigned int to accurately reflect what the hypervisor expects. No other changes are made to the function. Signed-off-by: Tamas K Lengyel --- tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_private.c | 63 +++--------------------------------- tools/libs/ctrl/xc_private.h | 58 ++++++++++++++++++++++++++++++++- 3 files changed, 63 insertions(+), 59 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 95bd5eca67..484e354412 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1597,6 +1597,7 @@ int xc_vmtrace_set_option(xc_interface *xch, uint32_t domid, int xc_domctl(xc_interface *xch, struct xen_domctl *domctl); int xc_sysctl(xc_interface *xch, struct xen_sysctl *sysctl); +long xc_memory_op(xc_interface *xch, unsigned int cmd, void *arg, size_t len); int xc_version(xc_interface *xch, int cmd, void *arg); diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index c0422662f0..6a247d2b1f 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -326,64 +326,6 @@ int xc_flush_mmu_updates(xc_interface *xch, struct xc_mmu *mmu) return flush_mmu_updates(xch, mmu); } -long do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len) -{ - DECLARE_HYPERCALL_BOUNCE(arg, len, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - long ret = -1; - - if ( xc_hypercall_bounce_pre(xch, arg) ) - { - PERROR("Could not bounce memory for XENMEM hypercall"); - goto out1; - } - -#if defined(__linux__) || defined(__sun__) - /* - * Some sub-ops return values which don't fit in "int". On platforms - * without a specific hypercall return value field in the privcmd - * interface structure, issue the request as a single-element multicall, - * to be able to capture the full return value. - */ - if ( sizeof(long) > sizeof(int) ) - { - multicall_entry_t multicall = { - .op = __HYPERVISOR_memory_op, - .args[0] = cmd, - .args[1] = HYPERCALL_BUFFER_AS_ARG(arg), - }, *call = &multicall; - DECLARE_HYPERCALL_BOUNCE(call, sizeof(*call), - XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - - if ( xc_hypercall_bounce_pre(xch, call) ) - { - PERROR("Could not bounce buffer for memory_op hypercall"); - goto out1; - } - - ret = do_multicall_op(xch, HYPERCALL_BUFFER(call), 1); - - xc_hypercall_bounce_post(xch, call); - - if ( !ret ) - { - ret = multicall.result; - if ( multicall.result > ~0xfffUL ) - { - errno = -ret; - ret = -1; - } - } - } - else -#endif - ret = xencall2L(xch->xcall, __HYPERVISOR_memory_op, - cmd, HYPERCALL_BUFFER_AS_ARG(arg)); - - xc_hypercall_bounce_post(xch, arg); - out1: - return ret; -} - int xc_maximum_ram_page(xc_interface *xch, unsigned long *max_mfn) { long rc = do_memory_op(xch, XENMEM_maximum_ram_page, NULL, 0); @@ -489,6 +431,11 @@ int xc_sysctl(xc_interface *xch, struct xen_sysctl *sysctl) return do_sysctl(xch, sysctl); } +long xc_memory_op(xc_interface *xch, unsigned int cmd, void *arg, size_t len) +{ + return do_memory_op(xch, cmd, arg, len); +} + int xc_version(xc_interface *xch, int cmd, void *arg) { DECLARE_HYPERCALL_BOUNCE(arg, 0, XC_HYPERCALL_BUFFER_BOUNCE_OUT); /* Size unknown until cmd decoded */ diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index ebdf78c2bf..cf6ad932b0 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -367,7 +367,63 @@ static inline int do_multicall_op(xc_interface *xch, return ret; } -long do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len); +static inline long do_memory_op(xc_interface *xch, unsigned int cmd, void *arg, size_t len) +{ + DECLARE_HYPERCALL_BOUNCE(arg, len, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + long ret = -1; + + if ( xc_hypercall_bounce_pre(xch, arg) ) + { + PERROR("Could not bounce memory for XENMEM hypercall"); + goto out1; + } + +#if defined(__linux__) || defined(__sun__) + /* + * Some sub-ops return values which don't fit in "int". On platforms + * without a specific hypercall return value field in the privcmd + * interface structure, issue the request as a single-element multicall, + * to be able to capture the full return value. + */ + if ( sizeof(long) > sizeof(int) ) + { + multicall_entry_t multicall = { + .op = __HYPERVISOR_memory_op, + .args[0] = cmd, + .args[1] = HYPERCALL_BUFFER_AS_ARG(arg), + }, *call = &multicall; + DECLARE_HYPERCALL_BOUNCE(call, sizeof(*call), + XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + + if ( xc_hypercall_bounce_pre(xch, call) ) + { + PERROR("Could not bounce buffer for memory_op hypercall"); + goto out1; + } + + ret = do_multicall_op(xch, HYPERCALL_BUFFER(call), 1); + + xc_hypercall_bounce_post(xch, call); + + if ( !ret ) + { + ret = multicall.result; + if ( multicall.result > ~0xfffUL ) + { + errno = -ret; + ret = -1; + } + } + } + else +#endif + ret = xencall2L(xch->xcall, __HYPERVISOR_memory_op, + cmd, HYPERCALL_BUFFER_AS_ARG(arg)); + + xc_hypercall_bounce_post(xch, arg); + out1: + return ret; +} void *xc_map_foreign_ranges(xc_interface *xch, uint32_t dom, size_t size, int prot, size_t chunksize, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 19 13:32:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 13:32:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332984.556750 (Exim 4.92) (envelope-from ) id 1nrgGh-0004y9-Hh; Thu, 19 May 2022 13:32:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332984.556750; Thu, 19 May 2022 13:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgGh-0004y2-E0; Thu, 19 May 2022 13:32:43 +0000 Received: by outflank-mailman (input) for mailman id 332984; Thu, 19 May 2022 13:32:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgGg-0004xu-9j for xen-devel@lists.xenproject.org; Thu, 19 May 2022 13:32:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27f0069b-d778-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 15:32:41 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC2D41FD43; Thu, 19 May 2022 13:32:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A238313AF8; Thu, 19 May 2022 13:32:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id c+BCJvhGhmIYKwAAMHmgww (envelope-from ); Thu, 19 May 2022 13:32:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27f0069b-d778-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652967160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1BbGET/6ToU1vbmwg/Y15gVpYaOfmLXmpSzSQWkmUxE=; b=FR6b2dOOMPM0wISijoqbZK6ONIpJ566l/AJfHd8VN/E3t9OSzsD0HJXAs955rlR/OEYGC0 /Qy5Etvl6o4PVkJSg8ni4gvZeDFl5Ml8pODVhOiZUNie09UBdLPXLHl/RBGhfYu1Ocr7fj 4B6hLHU2bXkNMDKHJol8MO1rQIn+f6s= Message-ID: <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> Date: Thu, 19 May 2022 15:32:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] tools/libs/ctrl: add and export xc_memory_op Content-Language: en-US To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Andrew Cooper References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> From: Juergen Gross In-Reply-To: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8bTg0scaOKBxD10tWCdeDa8L" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8bTg0scaOKBxD10tWCdeDa8L Content-Type: multipart/mixed; boundary="------------4Mqp7auokwklZQvbey7xdyIl"; protected-headers="v1" From: Juergen Gross To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Andrew Cooper Message-ID: <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> Subject: Re: [PATCH] tools/libs/ctrl: add and export xc_memory_op References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> In-Reply-To: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> --------------4Mqp7auokwklZQvbey7xdyIl Content-Type: multipart/mixed; boundary="------------C0Rb8uTJH4l5JfFCZG3j0Mak" --------------C0Rb8uTJH4l5JfFCZG3j0Mak Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDUuMjIgMTU6MjcsIFRhbWFzIEsgTGVuZ3llbCB3cm90ZToNCj4gQWRkIGFuZCBl eHBvcnQgeGNfbWVtb3J5X29wIHNvIHRoYXQgZG9fbWVtb3J5X29wIGNhbiBiZSB1c2VkIGJ5 IHRvb2xzIGxpbmtpbmcNCj4gd2l0aCBsaWJ4Yy4gVGhpcyBpcyBlZmZlY3RpdmVseSBpbiB0 aGUgc2FtZSBzcGlyaXQgYXMgdGhlIGV4aXN0aW5nIHhjX2RvbWN0bA0KPiBhbmQgeGNfc3lz Y3RsIGZ1bmN0aW9ucywgd2hpY2ggYXJlIGFscmVhZHkgZXhwb3J0ZWQuDQo+IA0KPiBJbiB0 aGlzIHBhdGNoIHdlIG1vdmUgZG9fbWVtb3J5X29wIGludG8geGNfcHJpdmF0ZS5oIGFzIGEg c3RhdGljIGlubGluZSBmdW5jdGlvbg0KPiBhbmQgY29udmVydCBpdHMgJ2NtZCcgaW5wdXQg ZnJvbSBpbnQgdG8gdW5zaWduZWQgaW50IHRvIGFjY3VyYXRlbHkgcmVmbGVjdCB3aGF0DQo+ IHRoZSBoeXBlcnZpc29yIGV4cGVjdHMuIE5vIG90aGVyIGNoYW5nZXMgYXJlIG1hZGUgdG8g dGhlIGZ1bmN0aW9uLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVGFtYXMgSyBMZW5neWVsIDx0 YW1hcy5sZW5neWVsQGludGVsLmNvbT4NCj4gLS0tDQo+ICAgdG9vbHMvaW5jbHVkZS94ZW5j dHJsLmggICAgICB8ICAxICsNCj4gICB0b29scy9saWJzL2N0cmwveGNfcHJpdmF0ZS5jIHwg NjMgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ICAgdG9vbHMvbGli cy9jdHJsL3hjX3ByaXZhdGUuaCB8IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLQ0KPiAgIDMgZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgNTkgZGVsZXRp b25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS94ZW5jdHJsLmggYi90 b29scy9pbmNsdWRlL3hlbmN0cmwuaA0KPiBpbmRleCA5NWJkNWVjYTY3Li40ODRlMzU0NDEy IDEwMDY0NA0KPiAtLS0gYS90b29scy9pbmNsdWRlL3hlbmN0cmwuaA0KPiArKysgYi90b29s cy9pbmNsdWRlL3hlbmN0cmwuaA0KPiBAQCAtMTU5Nyw2ICsxNTk3LDcgQEAgaW50IHhjX3Zt dHJhY2Vfc2V0X29wdGlvbih4Y19pbnRlcmZhY2UgKnhjaCwgdWludDMyX3QgZG9taWQsDQo+ ICAgDQo+ICAgaW50IHhjX2RvbWN0bCh4Y19pbnRlcmZhY2UgKnhjaCwgc3RydWN0IHhlbl9k b21jdGwgKmRvbWN0bCk7DQo+ICAgaW50IHhjX3N5c2N0bCh4Y19pbnRlcmZhY2UgKnhjaCwg c3RydWN0IHhlbl9zeXNjdGwgKnN5c2N0bCk7DQo+ICtsb25nIHhjX21lbW9yeV9vcCh4Y19p bnRlcmZhY2UgKnhjaCwgdW5zaWduZWQgaW50IGNtZCwgdm9pZCAqYXJnLCBzaXplX3QgbGVu KTsNCj4gICANCj4gICBpbnQgeGNfdmVyc2lvbih4Y19pbnRlcmZhY2UgKnhjaCwgaW50IGNt ZCwgdm9pZCAqYXJnKTsNCj4gICANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvY3RybC94 Y19wcml2YXRlLmMgYi90b29scy9saWJzL2N0cmwveGNfcHJpdmF0ZS5jDQo+IGluZGV4IGMw NDIyNjYyZjAuLjZhMjQ3ZDJiMWYgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2xpYnMvY3RybC94 Y19wcml2YXRlLmMNCj4gKysrIGIvdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuYw0KPiBA QCAtMzI2LDY0ICszMjYsNiBAQCBpbnQgeGNfZmx1c2hfbW11X3VwZGF0ZXMoeGNfaW50ZXJm YWNlICp4Y2gsIHN0cnVjdCB4Y19tbXUgKm1tdSkNCj4gICAgICAgcmV0dXJuIGZsdXNoX21t dV91cGRhdGVzKHhjaCwgbW11KTsNCj4gICB9DQo+ICAgDQo+IC1sb25nIGRvX21lbW9yeV9v cCh4Y19pbnRlcmZhY2UgKnhjaCwgaW50IGNtZCwgdm9pZCAqYXJnLCBzaXplX3QgbGVuKQ0K DQpXaHkgZG9uJ3QgeW91IGp1c3QgcmVuYW1lIHRoaXMgZnVuY3Rpb24gYW5kIG1vZGlmeSB0 aGUgdXNlcnMgdG8gdXNlIHRoZQ0KbmV3IG5hbWU/DQoNCg0KSnVlcmdlbg0K --------------C0Rb8uTJH4l5JfFCZG3j0Mak Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C0Rb8uTJH4l5JfFCZG3j0Mak-- --------------4Mqp7auokwklZQvbey7xdyIl-- --------------8bTg0scaOKBxD10tWCdeDa8L Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKGRvgFAwAAAAAACgkQsN6d1ii/Ey+e cAf/fbpegsi4c5GRrh4iSKd4WryDUckh8LA/Cxxa6E9ckE85mjBqePUChVCK9E6YDl/GLLag9xXH crIVuVHacre0f7/3KATGPtasQG6MJloOsQG1dkAlPgXbl5XRIr7+wB+I7nkvhgZ5vvyHALFxj7OK XCavr1MqoNa3is0urqMOx5EzdbH9peQ/bs72gUKbNev6RglXFPOxBfh2nyKGs0sHHhBDWmHamgex TQ/AAwScN4mro25GIE3w6BifhVh8IyjH2k45mPeP9ceppcaNIAGnWtp3/7y1UBjN/o4Il2ogihaL CpD+hkbYL3Kd0oZblIzx3jkDtmpiTmk/vcTFP3+EpA== =f9Bt -----END PGP SIGNATURE----- --------------8bTg0scaOKBxD10tWCdeDa8L-- From xen-devel-bounces@lists.xenproject.org Thu May 19 13:59:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 13:59:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.332992.556761 (Exim 4.92) (envelope-from ) id 1nrggc-0007SG-Kz; Thu, 19 May 2022 13:59:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 332992.556761; Thu, 19 May 2022 13:59:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrggc-0007S9-Fs; Thu, 19 May 2022 13:59:30 +0000 Received: by outflank-mailman (input) for mailman id 332992; Thu, 19 May 2022 13:59:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgga-0007S3-D6 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 13:59:29 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e23af36c-d77b-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 15:59:24 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 06:59:20 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 19 May 2022 06:59:20 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 06:59:20 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 06:59:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 06:59:19 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 06:59:19 -0700 Received: from CY4PR11MB0056.namprd11.prod.outlook.com (2603:10b6:910:7c::30) by BN6PR11MB1939.namprd11.prod.outlook.com (2603:10b6:404:ff::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 13:59:16 +0000 Received: from CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f]) by CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f%7]) with mapi id 15.20.5250.018; Thu, 19 May 2022 13:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e23af36c-d77b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652968764; x=1684504764; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Tt4HgQwb3iIBbOJi3FOSUT1ONHQlUSSv9LGRFWKTg7Q=; b=iSLlbsGjICcFCHu7s2GZ0E+lFJ9cJ0eWHB32GeR79/TcrUSK+p83KZ5A UPCFn2HmpOGQ65YGWghrSULyCGeMcuMy4OgyT8SDro5w482cYZZBPvh2G 77JQv/m3LXS03/Vg5Aia0gPwGsugy7mf+OBbCd3Gsuo9tqP01BKQyp+lA IjOwTmh63wJW9qBLacu6lsXAemZJz0T9HZYP1PQsnEu/4GrxHVSG29JKB Ws6Gi3d8inSr2yaygxUy0A+vI7ZLlo4ClSc8Ih/3DWp0p0nXjZzPNNAv0 eBskPRn/Z7949lNS/x6swmT0oNIAx2m5sF1VXq7NwrfIsR0jZVmtal76J w==; X-IronPort-AV: E=McAfee;i="6400,9594,10351"; a="269800383" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="269800383" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="639796476" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpcJX6mMSrY3F3DsTg1fsoCWoDMV/zZ8yi50ASi5HbA+Sknt0sr0CUsX9lO8I7QXWYtF5KCBG2WDhWrOWB3AovyUdbGCfDBXXFxkdwQ3PSyzHszGg0tq24kBBRKsc6w8jDLzzWHyja+SGRAxpU2GUJqzVWD1phu4BZ3MBVFY37Z0a6mI5X8sK4SrtlCe7s8H8nN/3kolRdo+G5gjRoPxBMEp8yeK/Wl5WJdSWpV1m9Tjntq21qA+Qx+ML9OSjTX6NjcZP1FiLgObFaeTydYGtfcPQ7reX9l9zCmyQLyhhM1e4RCCcude90DglfvQVH9PXoSQUEF6F+71+Qs+G3LN2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tt4HgQwb3iIBbOJi3FOSUT1ONHQlUSSv9LGRFWKTg7Q=; b=U5+GsS3iAwyhC3AAcYLyzm5Ww5T17m71Iq/fhTdCBJ8t8xedlNpJIsC9B7JrY2WqXstRxNdkq8z1igDNHHXCY01uccM3Y1zn1ML9+pwrur4dOFDbHMBSETGCCTizn2lUHePbWcN34WtKyJCIcwlYqpAVAeRZIZwkwtBawPVlAAH7swl2uz/sX+j0Mo/vve3xr9EhkhECUKUCqTLhY4xiUDS8t+2pcQzStNFnuqmlzYmES5lpFnUxunPro2TogRoiWwJLiTBZ4kHA9QVubNYftQHXcBdtYZDo/JNLTqXkzMo2JsMTa4DTP4h+emqxgvzvrSfU+VLZMCZh2bTvNwfUHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Lengyel, Tamas" To: "Gross, Jurgen" , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD , "Cooper, Andrew" Subject: RE: [PATCH] tools/libs/ctrl: add and export xc_memory_op Thread-Topic: [PATCH] tools/libs/ctrl: add and export xc_memory_op Thread-Index: AQHYa4RIF+g6mxBRRU+cd4s+ndSX+a0mMskAgAAGnRA= Date: Thu, 19 May 2022 13:59:16 +0000 Message-ID: References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> In-Reply-To: <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd8fab01-c21a-495e-dde7-08da399fc372 x-ms-traffictypediagnostic: BN6PR11MB1939:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pFfSuydxRL4ve+kpK6p0apdcf7q03rXlyj5KzAn1HoEGp3A0c5SkI7469CSMxrBw4GSSdGMMpPzH8OoD4hW6XcWhnjLW7X9FHHp88oalEzLsN2A+ZYet8ha/j7vZBDW2yBxeCOcW67NySENBEfb0e4ilcJW77C7hVf4GVed1T1iWIYE0qc0ld3NqkzSM7NTz0Yvbs78mo4s+2Zcnk3SVfB7VHKm7vjcYwHELio4maeo+0flwSaXFZ/s2d8wm6rvTl+ohWtgkaYPJucAuJ6e1yh74GLA1LgkeUUr0iBs2xc501SQXX9ypg5DyvQfRZtk3QZ7OfGmE1BIVaKsp2s0dmMswRWx0UfrnF3JUzbK62hwdwzLmFOs3Y0c913rX7UPOanPzmFt2ayDU4fyoZ+9Av5ctqP5MDNyGMG+AT97lGWAydWs2RcmE7S8WVp5hYtJU1paOqqTPhmaPfyOSgqDIeXexUclAAFwqPU9BLVEgrrqfJpRS3Io/bnIlMnw1Ag/CWu3YTVG/gHVvCqzASvfqtoWbkSfsZQ2+ef2XD07shZ7dW4NxWOBieGLjs9JrlkAuMmFJHUpseFmv+J4e4srCJOCNtLqJ7Gz/FoP+u/g2Gi8gheTqkxY1VBfWFkYHJmyymAOJtnxvUOgvclCLVaW4+Ig1ejBouS4lLMcuTkXVswiVnpYiU1xVXWlR7ON184bxR1cyzR5EWdcC8HmB79v9YQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB0056.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(186003)(8676002)(316002)(6506007)(4326008)(7696005)(33656002)(8936002)(52536014)(9686003)(26005)(53546011)(66476007)(66446008)(64756008)(55016003)(54906003)(5660300002)(508600001)(38070700005)(38100700002)(110136005)(66946007)(76116006)(66556008)(122000001)(82960400001)(86362001)(2906002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YURmVm8wVFF1aHdHWjRtOU4zQ1ZmeXB6ODNaY1BXYVFWNmcraFhoYmU4NGZ3?= =?utf-8?B?K29uSVRTVytRcXMxT3hKQmNaQWptb3Z6S05YK2RKdldqeEFNRjRGa1lOVHlj?= =?utf-8?B?dEdmVEtINk5ZbktMNlB5U0pGeHFXZi9xSkdGa2pTSkFxaWZDOEtKMzBSM0I3?= =?utf-8?B?STRhM2kvTzFGaVhoNUNXSzA2V3RwaWxyRTI2aTRFOElyZDlVRFRGR3NZRnhX?= =?utf-8?B?eFRNWGJEN0ZoR09iOUhsczFPWWU0RjNMeHdnaVhhMkNWL1QrU2RYbTQxZlVp?= =?utf-8?B?cGVoMDN3aWtxbi9SVkRWaE1yUXNENnc4aTRPTUp5WWthMmJlam1lLzhWQmtW?= =?utf-8?B?bmVsN1g3V3lDeS8wSW1RMVllNWZ6OWplR2FHQ3dRQUZ5K1lmamw0czBJWXEr?= =?utf-8?B?Y1RIdmxpaytVb1ZuVDQ1bjJzNDVGd0JIQkdsYzlOeDN4enVuTGFUaXVOTG1u?= =?utf-8?B?V0NadFkrazVSSXgyR1hVUGZmanlOeFdFY2Y5SGZrelhmbmlYdlJIQ2xpcklr?= =?utf-8?B?Z0ZWOU5sNkFxcDFiMS9JU2JteDVqaVdRWnFtcThBcVAxWm5Ra2JZcFVldjV6?= =?utf-8?B?bVQ0WkdyNCtZeGZoVjhtSVJtVnJ0MEN3c3dJVStvcHJtRUZoSkNIODY3QVBJ?= =?utf-8?B?WmxZS3llZmxnMWdvL3NoZU91am1WanRRbk8xL3Z3a2ZoRkFEd3FhVlhuTXMy?= =?utf-8?B?TytOSWszYmszbDM4UHpvbTZ3eEZycllwNmdHR3VCUGVkK1Y2dkh3NkphR05t?= =?utf-8?B?enhHUmxFVkNGYUZrYzFoeTlNRDlZQWN5dHVjNWRVdVBxZ1FLUWdtOCtlY0Jk?= =?utf-8?B?aDZUSHFQZXlVNGx3K1VaL1JBaHVZbFViQmZrWVRPckQ5T3Z0Y1JKNDNjd1lM?= =?utf-8?B?WGpQUFJjVzQxVXZaazlFME5wSkN3ci9BK21jWU1JV2JzejhodzRaSmZVc3Rp?= =?utf-8?B?aVU3NjZoTWpEQVc3NnpLVGR6L3lmbXJwV2FOK1E1QVRVd0kzU3dyc2tVTEI3?= =?utf-8?B?WjRBR3Q3NThYL0h4VFhlOVlWT1JQRVl6dkQxMWhhbVpacllvNXk4YWUxQ0Vt?= =?utf-8?B?Q0NFb3pzN2krWU15ckw2ZXpJVlRYVmJYZEdBM0tNamlaSEh3ckdnU1FVYjll?= =?utf-8?B?aUp6OENJWXpaOU1TcEp0anB6VkZDSmR1SVBMMThvSDBKTjI4YmROWjNWZ1lX?= =?utf-8?B?VEtMNnROTnZManhhMVp5WnFFZVBKRTVUTWpCSGQrT1dvSXY5WlM2UTFVMnRM?= =?utf-8?B?T2xPSjV3bnptd2lEaG0xTnFGOG1sZnJBMDVhVk91dEZTSU9kMlRXbEdoZ2VO?= =?utf-8?B?V2wxcis1aGJXTkRXdE9SZEFhanZuQUNJY0puanNrWHB6dmZZazR1NUhvSEdj?= =?utf-8?B?V2lXY2VjNGJJVHJ6bzI5TGllU3I3cm5zNU5GUkk2bVVqbnV1VkVkQmc0cUxB?= =?utf-8?B?Q05MSGhmOUlZbmtUZEFIUFVrNlY3RzFSVllDUkU5Z1JWQk5QRFBCM013UUtU?= =?utf-8?B?ZHR0UXl2KzNibHdCS09RNElzbk55TTZGL3Jud1JqSC8ydmx0a1hhWDYzSWhL?= =?utf-8?B?MHdMa1JQUU92eHVyRmxkK3BmQk8zbjZ5cXNrdk1hTDhsZSsyZWxFZElGdnkx?= =?utf-8?B?WjJPWHREaVdGREkrM01zSTVHYkFxaTVaMHhPbmpObzV0R01Kc1VzQVROUkVr?= =?utf-8?B?aG5MaW1DTVVDdnZIaW9FTWcyaU9LM0JPdnZWeUNDVUx3TGxJaEErejdMclU2?= =?utf-8?B?TzJjbmZqa2NncTNlUDdEMXF6eUJEZTVLU0dTL0FQYTJMMmVIdlV1dHRKSith?= =?utf-8?B?LzZSb2IxZHcvYlJ2blhnMUtqT2pnWEh0RmdYN2tWeW52UFJtSkVOcWVkb2pn?= =?utf-8?B?RzN2cnpFOUhJbGtlRHhSY2I1T3NHTG1UQXA5djcxZVB5MG9aQ2xwSG5JZ1dU?= =?utf-8?B?Wjhjc1ViSnJ0WVMyNGlsZFdkZFIxK1RkdDBPbGtnOU8xaTl5Nk1yTnRwTmdQ?= =?utf-8?B?SFBMaHBITXIyUzYwZnhOWGpGZldEMkREb3AvT0dZd0V5aktjdCtua3YrLzFx?= =?utf-8?B?bUsrVURBZm1JcjQxamJFY1hYN05lLytVZjdMUHhIakZYenE2Yk1LU0dSWVZT?= =?utf-8?B?eHA3ZmRibTBxd3B5eW1KQW9BK0tWbDhMUDREK3BvWWpaNExBT0lYUkNSQTNn?= =?utf-8?B?SGJKbGUzMVh5UWJnSGxlYkk1QWw5cGduRTVpQUpsTkoxUi9SSHlqdlE1cFdj?= =?utf-8?B?ZkZ2WTVzK2NQMW9PL0pxUnp6eDl4Vi96S2lKd0lJdFA5R1RRNGNUeDlXZHhs?= =?utf-8?B?NFdCODQyZ3hjaFRPMmtGRkxWQS9HT1BMcXQ3TDlpSElhOXlEdEs2QT09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB0056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd8fab01-c21a-495e-dde7-08da399fc372 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 13:59:16.7546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f2rfXx3c4yu+A2E/fHN+0CrcSElnYbQjrgStaz90CwGqt1zS6eSNpxtltnqjozAtay0KjA2BzpR/micEmHmywA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1939 X-OriginatorOrg: intel.com DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRldmVsIDx4ZW4t ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+IEp1ZXJn ZW4gR3Jvc3MNCj4gU2VudDogVGh1cnNkYXksIE1heSAxOSwgMjAyMiA5OjMzIEFNDQo+IFRvOiBM ZW5neWVsLCBUYW1hcyA8dGFtYXMubGVuZ3llbEBpbnRlbC5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47DQo+IENvb3BlciwgQW5kcmV3IDxhbmRyZXcu Y29vcGVyM0BjaXRyaXguY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSB0b29scy9saWJzL2N0 cmw6IGFkZCBhbmQgZXhwb3J0IHhjX21lbW9yeV9vcA0KPiANCj4gT24gMTkuMDUuMjIgMTU6Mjcs IFRhbWFzIEsgTGVuZ3llbCB3cm90ZToNCj4gPiBBZGQgYW5kIGV4cG9ydCB4Y19tZW1vcnlfb3Ag c28gdGhhdCBkb19tZW1vcnlfb3AgY2FuIGJlIHVzZWQgYnkgdG9vbHMNCj4gPiBsaW5raW5nIHdp dGggbGlieGMuIFRoaXMgaXMgZWZmZWN0aXZlbHkgaW4gdGhlIHNhbWUgc3Bpcml0IGFzIHRoZQ0K PiA+IGV4aXN0aW5nIHhjX2RvbWN0bCBhbmQgeGNfc3lzY3RsIGZ1bmN0aW9ucywgd2hpY2ggYXJl IGFscmVhZHkgZXhwb3J0ZWQuDQo+ID4NCj4gPiBJbiB0aGlzIHBhdGNoIHdlIG1vdmUgZG9fbWVt b3J5X29wIGludG8geGNfcHJpdmF0ZS5oIGFzIGEgc3RhdGljDQo+ID4gaW5saW5lIGZ1bmN0aW9u IGFuZCBjb252ZXJ0IGl0cyAnY21kJyBpbnB1dCBmcm9tIGludCB0byB1bnNpZ25lZCBpbnQNCj4g PiB0byBhY2N1cmF0ZWx5IHJlZmxlY3Qgd2hhdCB0aGUgaHlwZXJ2aXNvciBleHBlY3RzLiBObyBv dGhlciBjaGFuZ2VzIGFyZSBtYWRlDQo+IHRvIHRoZSBmdW5jdGlvbi4NCj4gPg0KPiA+IFNpZ25l ZC1vZmYtYnk6IFRhbWFzIEsgTGVuZ3llbCA8dGFtYXMubGVuZ3llbEBpbnRlbC5jb20+DQo+ID4g LS0tDQo+ID4gICB0b29scy9pbmNsdWRlL3hlbmN0cmwuaCAgICAgIHwgIDEgKw0KPiA+ICAgdG9v bHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuYyB8IDYzICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQ0KPiA+ICAgdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuaCB8IDU4ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiA+ICAgMyBmaWxlcyBjaGFuZ2VkLCA2MyBp bnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS90b29s cy9pbmNsdWRlL3hlbmN0cmwuaCBiL3Rvb2xzL2luY2x1ZGUveGVuY3RybC5oIGluZGV4DQo+ID4g OTViZDVlY2E2Ny4uNDg0ZTM1NDQxMiAxMDA2NDQNCj4gPiAtLS0gYS90b29scy9pbmNsdWRlL3hl bmN0cmwuaA0KPiA+ICsrKyBiL3Rvb2xzL2luY2x1ZGUveGVuY3RybC5oDQo+ID4gQEAgLTE1OTcs NiArMTU5Nyw3IEBAIGludCB4Y192bXRyYWNlX3NldF9vcHRpb24oeGNfaW50ZXJmYWNlICp4Y2gs DQo+ID4gdWludDMyX3QgZG9taWQsDQo+ID4NCj4gPiAgIGludCB4Y19kb21jdGwoeGNfaW50ZXJm YWNlICp4Y2gsIHN0cnVjdCB4ZW5fZG9tY3RsICpkb21jdGwpOw0KPiA+ICAgaW50IHhjX3N5c2N0 bCh4Y19pbnRlcmZhY2UgKnhjaCwgc3RydWN0IHhlbl9zeXNjdGwgKnN5c2N0bCk7DQo+ID4gK2xv bmcgeGNfbWVtb3J5X29wKHhjX2ludGVyZmFjZSAqeGNoLCB1bnNpZ25lZCBpbnQgY21kLCB2b2lk ICphcmcsDQo+ID4gK3NpemVfdCBsZW4pOw0KPiA+DQo+ID4gICBpbnQgeGNfdmVyc2lvbih4Y19p bnRlcmZhY2UgKnhjaCwgaW50IGNtZCwgdm9pZCAqYXJnKTsNCj4gPg0KPiA+IGRpZmYgLS1naXQg YS90b29scy9saWJzL2N0cmwveGNfcHJpdmF0ZS5jDQo+ID4gYi90b29scy9saWJzL2N0cmwveGNf cHJpdmF0ZS5jIGluZGV4IGMwNDIyNjYyZjAuLjZhMjQ3ZDJiMWYgMTAwNjQ0DQo+ID4gLS0tIGEv dG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuYw0KPiA+ICsrKyBiL3Rvb2xzL2xpYnMvY3RybC94 Y19wcml2YXRlLmMNCj4gPiBAQCAtMzI2LDY0ICszMjYsNiBAQCBpbnQgeGNfZmx1c2hfbW11X3Vw ZGF0ZXMoeGNfaW50ZXJmYWNlICp4Y2gsIHN0cnVjdA0KPiB4Y19tbXUgKm1tdSkNCj4gPiAgICAg ICByZXR1cm4gZmx1c2hfbW11X3VwZGF0ZXMoeGNoLCBtbXUpOw0KPiA+ICAgfQ0KPiA+DQo+ID4g LWxvbmcgZG9fbWVtb3J5X29wKHhjX2ludGVyZmFjZSAqeGNoLCBpbnQgY21kLCB2b2lkICphcmcs IHNpemVfdCBsZW4pDQo+IA0KPiBXaHkgZG9uJ3QgeW91IGp1c3QgcmVuYW1lIHRoaXMgZnVuY3Rp b24gYW5kIG1vZGlmeSB0aGUgdXNlcnMgdG8gdXNlIHRoZSBuZXcNCj4gbmFtZT8NCg0KRm9yIHR3 byByZWFzb25zOg0KMSkgaGF2aW5nIHRoZSBkb19tZW1vcnlfb3AgYXMgYSBzdGF0aWMgaW5saW5l IGlzIGNvbnNpc3RlbnQgd2l0aCBob3cgZG9fZG9tY3RsIGFuZCBkb19zeXNjdGwgYXJlIGltcGxl bWVudGVkLCBzbyBsb2dpY2FsbHkgdGhhdCdzIHdoYXQgSSB3b3VsZCBleHBlY3QgdG8gc2VlIGZv ciB0aGUgbWVtb3J5X29wIGh5cGVyY2FsbCBhcyB3ZWxsLg0KMikgdGhlIHBhdGNoIGl0c2VsZiBp cyBjbGVhbmVyIGJlY2F1c2UgdGhlcmUgaXMgbm8gY2h1cm4gaW4gYWxsIHRoZSBmaWxlcyB0aGF0 IHByZXZpb3VzbHkgY2FsbGVkIGRvX21lbW9yeV9vcC4NCg0KVGFtYXMNCg== From xen-devel-bounces@lists.xenproject.org Thu May 19 14:10:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333000.556772 (Exim 4.92) (envelope-from ) id 1nrgrE-0001Kg-Ky; Thu, 19 May 2022 14:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333000.556772; Thu, 19 May 2022 14:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgrE-0001KY-I3; Thu, 19 May 2022 14:10:28 +0000 Received: by outflank-mailman (input) for mailman id 333000; Thu, 19 May 2022 14:10:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgrC-0001KS-J0 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:10:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6caae4f6-d77d-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 16:10:24 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-ODLQJ5aDPW-6zvVOsjDIJQ-1; Thu, 19 May 2022 10:10:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8F591C08968; Thu, 19 May 2022 14:10:20 +0000 (UTC) Received: from redhat.com (unknown [10.2.17.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 342BE400E115; Thu, 19 May 2022 14:10:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6caae4f6-d77d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652969423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N8kGEbTrTEeHt4NwMjp2TuqdkAELMIVAn53F1kvMq94=; b=ZEFG+x7IZSLbekc8T4tz5osOUuEXPzqHF+5LCgLksDDXq5e22Dfe7ILKqxl6nkHfDm3k/L Q5EkUMT34ZVy9VLa5MUiAzNC/w/71w5hIgMQshZLjLZBdsf9wrk6rZE4BCumqa750Xr5e/ ETNGhqv0Rxt6va4qSKnaXJQGTWD+Rh0= X-MC-Unique: ODLQJ5aDPW-6zvVOsjDIJQ-1 Date: Thu, 19 May 2022 09:10:17 -0500 From: Eric Blake To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paul Durrant , Stefano Stabellini , John Snow , Paolo Bonzini , "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, Fam Zheng , Anthony Perard , Kevin Wolf , Hanna Reitz , Coiby Xu , Xie Yongji Subject: Re: [PATCH] block: get rid of blk->guest_block_size Message-ID: <20220519141017.3xkntu4x7yslgpge@redhat.com> References: <20220518130945.2657905-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518130945.2657905-1-stefanha@redhat.com> User-Agent: NeoMutt/20220429-71-6f7d3e X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 On Wed, May 18, 2022 at 02:09:45PM +0100, Stefan Hajnoczi wrote: > Commit 1b7fd729559c ("block: rename buffer_alignment to > guest_block_size") noted: > > At this point, the field is set by the device emulation, but completely > ignored by the block layer. > > The last time the value of buffer_alignment/guest_block_size was > actually used was before commit 339064d50639 ("block: Don't use guest > sector size for qemu_blockalign()"). > > This value has not been used since 2013. Get rid of it. > > Cc: Xie Yongji > Signed-off-by: Stefan Hajnoczi > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From xen-devel-bounces@lists.xenproject.org Thu May 19 14:15:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:15:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333009.556783 (Exim 4.92) (envelope-from ) id 1nrgva-000227-EI; Thu, 19 May 2022 14:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333009.556783; Thu, 19 May 2022 14:14:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgva-000220-B7; Thu, 19 May 2022 14:14:58 +0000 Received: by outflank-mailman (input) for mailman id 333009; Thu, 19 May 2022 14:14:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrgvZ-00021u-En for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:14:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e75ca81-d77e-11ec-837e-e5687231ffcc; Thu, 19 May 2022 16:14:56 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-kiYvWRl7MpuvCfgYhD3_qg-1; Thu, 19 May 2022 16:14:51 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5988.eurprd04.prod.outlook.com (2603:10a6:208:11b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 14:14:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 14:14:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e75ca81-d77e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652969694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ap9UYxYQNFVMr9gOus9ZKxdIBgrdSg7K7YbC7n76t8=; b=P+MpzIm+wLJqMnmZlDdxtY3buoHnCCFhbOPWKy1S+/0H1ypfKcHnTfG5N1KZZz7ZuVQio7 cWkcRgviHVGZubr2gfvJgbeiWxkCOOKpGL3p8bVicMDiJ4TWYiaC+6XGvxCTxFOjmZBH9S CKr0SDNGkioOzgR2639MTmw/lDLVLLs= X-MC-Unique: kiYvWRl7MpuvCfgYhD3_qg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhADKJy6Y/+ofIiXNmyuxoqY7AThsTI8y/dFKhcrkUx8WYRaqSc7jnW+33SS65KRiGbQSBdPgjtPqwsPAO/ESbjsMtBZPgc13jvLUV+2UEQ3BofH4G8ArUC1MHINh5uoymMEhOVD4SdV6j95yATLrHVUTC2zaHxJhcqqQucEYvdCdN1GwWtBG5+w2uqIZETDrf+TBXI67b9eIcwImjZcKgZxdvDf6fwezFe1X+sE/xCEOA9mjgyiHHX5dkiY1/bn9Xh4AL3wgff4JX1kj5iB9N938tpqP7DvFNR/NUhnC6xv+wnXTPedHl5mAQlDxnPgHLjmDvRAYK5JUPRs2eUOow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2A1KSEKolR1dcqsQ80tDoRxBIeE5QPuyzbgsBvaRW3g=; b=QKjRdDZRzQ75kcl1kQ/3ne/1z6Z7fXMZJVyGKTcJVDlFslTrbXA/qtJq3iL6lp+Cm+VawLksrEOT5h8c1meWtQRCiuqPzi07UVR+RmWWmEQySKOKBS16BBQYEP6BftONB9Hi5Jc49PriSteK6C0s1yXzXcMEp0q7mdc5CQkGMDHL1kFdbU7fBpMsxvfNzCzbaASJxHuLrzUlR+FouvY6PWvelNe7yxBz66T7eGeXxIUKRZQ2zqYRZFZDtk53pMrWmIv9dVbUJYNpADviYRLWlEo1AsuMCWZjFw0mN+H3TamkDRLkVDUX2z8rUxE3ufzyQdMNut4ptwjUx1Cy4cOQaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <90c4d10e-1304-822d-ff85-9f86561d5b00@suse.com> Date: Thu, 19 May 2022 16:14:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> <5cf98549-6fc0-67f7-a882-0778e7ab6f98@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0021.eurprd04.prod.outlook.com (2603:10a6:20b:310::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bd7ad76-3063-4d0d-9b47-08da39a1eef8 X-MS-TrafficTypeDiagnostic: AM0PR04MB5988:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZnF52DStUof1kpYjCF8kg6u4sMMMeXpYPiEBuiOT/UCBFubq0dJmMQyx7d1lSNZxBqldoyPDyKrTCXmBU/OrdIZKgEfd8n7bCpiujEJApwhqjpTljyBZr065N1M4hKpQ2s4fRqgOfJfJ8Gz1+dLa4owf2c9xPObO7USkmGrLTyFhdctoldTG2AG7HrJfrhPkL5/KUCOb6JPo7THRuPYZgkfYdZukQdumlAQIBEWvd1sQv+pI+29HyaOMeIe7GIB7ujIDSd/cSPYu+f4HtnJ+4A/iWcn0oNfYDL5csjU4tD19sXpLmlL6S4d8HAC9zMUrKcpK+njvHshTVZH4MXJbv/a7XoNymxsKE8F5RDQskoxjnyFlZGcdX/bTCyy2J2Oz2CRz+t0l4eKUhWTR5vX/i711+9SN+NAloIsdb6vFc/6tYfb7FLhV90/f7pzz+ALKUMD3sSmpC/p/mD/uHo1kyu3eZaeSoW90otLUDb5armaPqzS/yCKiAK3oqBw+0BLJdQFxfZQ1OdRjY0esxeaaje6eUhJaLQPYfLlUlVToqodcU0I3Ms8QidC3wYSLUKRobm0wqAUAJg6rH501oH4exyp5i3ODXnw23kAC14vgQyM5RhHxH/IBl23bdAxWfDmt9gE+0OMI/92hdpx0oXsNXWo8SielE0hqySGoGqTngJ7baO1d/x20yXePVxFYK28dzs1u0uPVx7QCy1Y5emTtOwXSo6NYJ2nxQRWnk8VqlvQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(66946007)(31696002)(66556008)(8936002)(6916009)(54906003)(86362001)(316002)(2616005)(4326008)(6666004)(6512007)(26005)(6506007)(53546011)(508600001)(38100700002)(4744005)(31686004)(6486002)(2906002)(186003)(83380400001)(36756003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?npL6ifslzlgXXSUggozSA76LuSNs0JhZaTVKzgwLZqB7fESwdwCIrCRfbzUS?= =?us-ascii?Q?zkpNw3wiuoexjPsh54g/oQluRB2UYHNmPH1gr7I/sZylVyTh4lRhsa0PY4ho?= =?us-ascii?Q?eQC9ADfMNoY056RlogPDZK1jhRiEJrgyxzlal8JUlkkoKDUmdW0q1a7G5p62?= =?us-ascii?Q?dpv+WLIleIL6Qih5vdG1fzOMPAiEcS/bNTfnoCZKU74rlRChYaCXj6d+BdEP?= =?us-ascii?Q?09YaFLJpT4QrXgdr3nfcxKhkL+4htC8dxxrplQw/jFcpaZ2w+KCWvqKY7VRs?= =?us-ascii?Q?4SjJisb14wbGOLZNZNJPE9GmUopvl7gjaZlgyT84hr0g4bDKnux6YWhyZDbO?= =?us-ascii?Q?PurvRlthaRhr7Hp7EqEquEJNPEIRH+TcQ7wyrrZgRM1VnyPRg9vVB4H/HiTh?= =?us-ascii?Q?Q1PJR3RJ3EI6FgB0JMXCCXlV75huMCZ2+SOlqYGa72yTbIe9LTYcBmwoqzPD?= =?us-ascii?Q?WPpRB0lIGsyTb4IToAQWry/ZlPfy1woZ88pBgRArenAeNeMG1p9+JV0E3bN1?= =?us-ascii?Q?tt1lElEDXRdRYejFEp5GX301a3SgNcBaKGntilTVOjKCLvCShCpNOnpEJHQr?= =?us-ascii?Q?oiiR153dsUOd8kknkM5E6tpDJ5xCCxS8rvMGHNoBd1JiU2hKfPqmZdmgd6qH?= =?us-ascii?Q?Nc7ibvLJrhbaVNylGUKsO2fLVay/FkkKb6CyCBcs21/5NNU0wKp3iVtMbR5y?= =?us-ascii?Q?DTiBpVMLcsJRLxJTJhezlHiKmHcS/e//+xF9L/kpyzQFYa+36ipAXuQ5mPaB?= =?us-ascii?Q?zveECy8Lb1B3yZ+SS1o9PshbPOSu9qLTlhHYATta3tz4LtYdzny1DYFhEARK?= =?us-ascii?Q?dhIp8SzCupRk+gVYWXdXie1wGrrXYwvaIiu4LpAhmh6Q486++Cri2XojMZuf?= =?us-ascii?Q?3HoWkDgtROhHmVE49RUy+pQK3u2hfhE/LkTIrwDTB/qFNi5G5HFuTJYA9wQN?= =?us-ascii?Q?i2Bhwd0AN7dV0V1wJm1DisbAzCyL7Yutw+26EZZImboMowD73MhLnzQkajWu?= =?us-ascii?Q?rw7HAcw1XgMW4ON6kg69A2fdWdeWBakTvOCcFixj8afVN9kKHLEhhk1j4Cci?= =?us-ascii?Q?c4GYNh0adz6KhFm/lA+3HBNKeEDWPeRoXf7bSTjyVEMIiiEt1+GgHBMsq09C?= =?us-ascii?Q?banf2iSACj5IXl4BtU+ikm9wSh2Q2uEsf31UanjjeD+I0FwNBUFFW6TSkGRd?= =?us-ascii?Q?9ln3zcb/7stHTem6TR+9KbpUpz/o63DFE5s3WQFema0Jn4H2IKuteoe3amEI?= =?us-ascii?Q?G1o7uLIFT+dihROvMkiW5jXZLNSsGmBJoTpEM7PXxhXXiwTvzwJnEiWnO5V8?= =?us-ascii?Q?fnw9bo3QxBcFtN3e7kb6xtKqyHNBJr2reuOwSUSgwydNwdo5XJANFoUqkad4?= =?us-ascii?Q?AT5ShxEApwu/RYQDPlJyulOl+AGR6FBtGVyilFfVvRvhYxvf7zz/b4IxuY31?= =?us-ascii?Q?wXSUIenza2Gifa8/TAgbmvyyDAalT8mWV3v7wWh1jQGoRp52GLDeMUQKq26t?= =?us-ascii?Q?Zgu7YY3EoI26G6leYMRAMijdcSd3/Ze4URC8Z4WDOjT+Adjwl07GBxHNRvLJ?= =?us-ascii?Q?R9mMHvwxrAkbdykN46g0hWgtkzwPtZbpYktpJR6na6RHB+xStxALdwhtq4j0?= =?us-ascii?Q?aFa35RbXyi3illVasOfGMyevDVjmNml08xkyQ9GK2AS3w0F03n8xSM2NGNSr?= =?us-ascii?Q?81Acqv5Yfg+etG0CrJGs6bmkC7q93C9zZPc8dcElYMVI39V5bmJwxQmQpPOo?= =?us-ascii?Q?D/P17ZOC9g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd7ad76-3063-4d0d-9b47-08da39a1eef8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 14:14:48.9696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w0tuYlmSPv8wV1OfkmthdgGVEhBSG+S7xqISXkwUkX93W2/gnlfxrvOGnuSH/Yn9kraFuB1Fp/NLYSVCpdD9Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5988 On 19.05.2022 14:44, Roger Pau Monn=C3=A9 wrote: > On Thu, May 19, 2022 at 08:50:55AM +0200, Jan Beulich wrote: >> On 17.05.2022 15:21, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *re= gs) >>> */ >>> break; >>> =20 >>> + case EXIT_REASON_NOTIFY: >>> + __vmread(EXIT_QUALIFICATION, &exit_qualification); >>> + >>> + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) >>> + { >>> + perfc_incr(vmnotify_crash); >> >> Is this a useful event to count? We don't count other crash causes, >> iirc. >=20 > I thought it was helpful information from an admin PoV, but maybe I'm > mistaken. I know we don't count other crash reasons, but that doesn't > mean it won't be helpful to do so. Given that users have to opt-in to > enable counters I suggest to leave the counter there. Just to be explicit: I don't mind the counter, I merely find its addition inconsistent with what we've got. Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 14:30:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:30:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333017.556793 (Exim 4.92) (envelope-from ) id 1nrhA2-0003ZG-OC; Thu, 19 May 2022 14:29:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333017.556793; Thu, 19 May 2022 14:29:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhA2-0003Z9-LD; Thu, 19 May 2022 14:29:54 +0000 Received: by outflank-mailman (input) for mailman id 333017; Thu, 19 May 2022 14:29:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhA1-0003Z3-3U for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:29:53 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23497ab5-d780-11ec-837e-e5687231ffcc; Thu, 19 May 2022 16:29:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23497ab5-d780-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652970590; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=r9lkrrxfjkjFuwcAENsqT/4XhkccjDDyecQwXCzjSPY=; b=WsA4wF+UbsxE0Y+0B/3CpvyMTGLNp/6n9Zewapc7bmZ+6SyZn6xuiv2f Bs6ETatVItZzXzeRQZbx6jDJwH6NR8oIVvCyT5ZTYWbdG0A7YLATiqzjX yeD5oGl/wuoWWW3jq+w0QCwwUiLOAH417VXg/iq+d3B/Ky2V60N46DUxI w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72097988 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:v3GPyqzBMmFL99XFBYd6t+dowSrEfRIJ4+MujC+fZmUNrF6WrkVWy zEZXziPM/vYZzanf9skOYuy9EkB6JSGytNkG1dsqSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12InhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplm4WdSy1wAZL1le1MahQFOjk9Eb140eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6BP ZJINms/PHwsZTUfEFE6NbwXld6npXDOXmRakUy/lfEetj27IAtZj+G2bYu9lsaxbcBOgm6Cq 27G9ni/CRYfXPSSxSeM6H6rru/GlyD8Q55UErCkntZwgVaTz3YfTh0bU1e2u+K+jGa6WtRWM UtS/TAhxYAr+Um2C9P5WBa7iHiDuBEaRpxXCeJSwAOWzK3LyxyUCmgNUnhKb9lOnMo/Xzcn0 hmAh93kATZmrbi9RneU97PSpjS3UQANJ2gEdy4CTCMf7tXjqZ11hRXKJv56Hauoy8HvGC/xy jSiqi84iLMOy8kR2M2T5F3Cnnegq4bESiYz4QPYWH/j6Rl2DKa+Z4Gu9VXKxflFJYedCFKGu RAsi8WYqewDE5yJvCiMW/kWWqGk4e6fNz/RikIpGIMunxy18mOnVZBd5nd5PkgBGt0fZTbjb UvXuAVQzJxeJn2naelweY3ZNigx5fG+T5K/DKmSN4cQJMgqHOOawM1wTWCJ8mLHyXcTqKw2a K6WLO+0TloKN40ymVJaWNwh+bMswyk/w0baSpb60wmr3NKiWZKFdVsWGADQN75ktctotC2Qq o8CbJXSl32zRcWkOkHqHZgvwUfmxJTRLbT/sIRpe+GKOWKK80lxWqaKkdvNl2GI9pm5d9skH FngAye0K3Kl3BUrzDlmjVg6MdvSsW5X9y5TAMDVFQ/AN4IfSYiu9rwDUJA8YKMq8udupdYtE aRfK5zaXqkWFG+fk9j4UXUahNUyHClHeCrUZ3b1CNTBV8AIq/P1Fi/MIVK0qXhm4tufvsoiu bywvj43srJYLzmO+P3+Mar1p3vo5CB1sLsrAyPgf4kCEG2xodMCA3Gg0ZcKzzQkdEyrKs2yj F3NX3/1ZIDl/ucIzTU+rfnU8NjyS7EmRSK33QDztN6LCMUTxUL7qacobQpCVWq1uL/ckEl6W dho8g== IronPort-HdrOrdr: A9a23:OeyjjKD0QigQIbzlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN 5dmsNFaOEYY2IVsfrH X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="72097988" Date: Thu, 19 May 2022 15:29:42 +0100 From: Anthony PERARD To: Bernhard Beschow CC: , , , , , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , John Snow , "open list:IDE" Subject: Re: [PATCH v2 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class Message-ID: References: <20220513180957.90514-1-shentey@gmail.com> <20220513180957.90514-2-shentey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220513180957.90514-2-shentey@gmail.com> On Fri, May 13, 2022 at 08:09:55PM +0200, Bernhard Beschow wrote: > Commit 0f8445820f11a69154309863960328dda3dc1ad4 'xen: piix reuse pci > generic class init function' already resolved redundant code which in > turn rendered piix3-ide-xen redundant. > > Signed-off-by: Bernhard Beschow Creating a guest and migrating a guest seems to work fine without "piix3-ide-xen", and I can't find this name used outside of QEMU. So I guess it's fine to remove it. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 19 14:31:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:31:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333025.556805 (Exim 4.92) (envelope-from ) id 1nrhBM-0004rs-2w; Thu, 19 May 2022 14:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333025.556805; Thu, 19 May 2022 14:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhBL-0004rl-W0; Thu, 19 May 2022 14:31:15 +0000 Received: by outflank-mailman (input) for mailman id 333025; Thu, 19 May 2022 14:31:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhBK-0004rK-Ni for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:31:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55997722-d780-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 16:31:13 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2DBD01FD43; Thu, 19 May 2022 14:31:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EDE8613456; Thu, 19 May 2022 14:31:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LT6WOLBUhmIgSAAAMHmgww (envelope-from ); Thu, 19 May 2022 14:31:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55997722-d780-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652970673; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b/07qHUzYvpEObVNl+Re9m/EoCA0HOiIwPKHhDH7M7c=; b=WTf0LHdGE/60ZOHN6WaQpv9YhpiPex2uKd2la11Iyaj6TshUVWXkWlC8sBbuiHFuGbpjny JZntyH8pdxmlx052g/XpPVqXqTDPtb+m9bNPbAs95JL3eqGKhQGMzZmK0H3qwfWbOnIxjK csiCShlETRRB2Lg8rINBs/8o959za+s= Message-ID: <403a66db-143a-7d05-1d0f-5a7d30721e34@suse.com> Date: Thu, 19 May 2022 16:31:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] tools/libs/ctrl: add and export xc_memory_op Content-Language: en-US To: "Lengyel, Tamas" , "xen-devel@lists.xenproject.org" Cc: Wei Liu , Anthony PERARD , "Cooper, Andrew" References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EtefNS5gnDDF4A3NdlOwHIlg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EtefNS5gnDDF4A3NdlOwHIlg Content-Type: multipart/mixed; boundary="------------YA7LONw6iPpF09Gy0sLh6EwF"; protected-headers="v1" From: Juergen Gross To: "Lengyel, Tamas" , "xen-devel@lists.xenproject.org" Cc: Wei Liu , Anthony PERARD , "Cooper, Andrew" Message-ID: <403a66db-143a-7d05-1d0f-5a7d30721e34@suse.com> Subject: Re: [PATCH] tools/libs/ctrl: add and export xc_memory_op References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> In-Reply-To: --------------YA7LONw6iPpF09Gy0sLh6EwF Content-Type: multipart/mixed; boundary="------------RoAzGDslZIwx1fwjR5VupjH4" --------------RoAzGDslZIwx1fwjR5VupjH4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDUuMjIgMTU6NTksIExlbmd5ZWwsIFRhbWFzIHdyb3RlOg0KPiANCj4gDQo+PiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4gRnJvbTogWGVuLWRldmVsIDx4ZW4tZGV2 ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+PiBKdWVy Z2VuIEdyb3NzDQo+PiBTZW50OiBUaHVyc2RheSwgTWF5IDE5LCAyMDIyIDk6MzMgQU0NCj4+ IFRvOiBMZW5neWVsLCBUYW1hcyA8dGFtYXMubGVuZ3llbEBpbnRlbC5jb20+OyB4ZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4+IENjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsg QW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Ow0KPj4gQ29vcGVy LCBBbmRyZXcgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiBTdWJqZWN0OiBSZTog W1BBVENIXSB0b29scy9saWJzL2N0cmw6IGFkZCBhbmQgZXhwb3J0IHhjX21lbW9yeV9vcA0K Pj4NCj4+IE9uIDE5LjA1LjIyIDE1OjI3LCBUYW1hcyBLIExlbmd5ZWwgd3JvdGU6DQo+Pj4g QWRkIGFuZCBleHBvcnQgeGNfbWVtb3J5X29wIHNvIHRoYXQgZG9fbWVtb3J5X29wIGNhbiBi ZSB1c2VkIGJ5IHRvb2xzDQo+Pj4gbGlua2luZyB3aXRoIGxpYnhjLiBUaGlzIGlzIGVmZmVj dGl2ZWx5IGluIHRoZSBzYW1lIHNwaXJpdCBhcyB0aGUNCj4+PiBleGlzdGluZyB4Y19kb21j dGwgYW5kIHhjX3N5c2N0bCBmdW5jdGlvbnMsIHdoaWNoIGFyZSBhbHJlYWR5IGV4cG9ydGVk Lg0KPj4+DQo+Pj4gSW4gdGhpcyBwYXRjaCB3ZSBtb3ZlIGRvX21lbW9yeV9vcCBpbnRvIHhj X3ByaXZhdGUuaCBhcyBhIHN0YXRpYw0KPj4+IGlubGluZSBmdW5jdGlvbiBhbmQgY29udmVy dCBpdHMgJ2NtZCcgaW5wdXQgZnJvbSBpbnQgdG8gdW5zaWduZWQgaW50DQo+Pj4gdG8gYWNj dXJhdGVseSByZWZsZWN0IHdoYXQgdGhlIGh5cGVydmlzb3IgZXhwZWN0cy4gTm8gb3RoZXIg Y2hhbmdlcyBhcmUgbWFkZQ0KPj4gdG8gdGhlIGZ1bmN0aW9uLg0KPj4+DQo+Pj4gU2lnbmVk LW9mZi1ieTogVGFtYXMgSyBMZW5neWVsIDx0YW1hcy5sZW5neWVsQGludGVsLmNvbT4NCj4+ PiAtLS0NCj4+PiAgICB0b29scy9pbmNsdWRlL3hlbmN0cmwuaCAgICAgIHwgIDEgKw0KPj4+ ICAgIHRvb2xzL2xpYnMvY3RybC94Y19wcml2YXRlLmMgfCA2MyArKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4+PiAgICB0b29scy9saWJzL2N0cmwveGNfcHJpdmF0 ZS5oIHwgNTggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystDQo+Pj4gICAgMyBm aWxlcyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkNCj4+Pg0K Pj4+IGRpZmYgLS1naXQgYS90b29scy9pbmNsdWRlL3hlbmN0cmwuaCBiL3Rvb2xzL2luY2x1 ZGUveGVuY3RybC5oIGluZGV4DQo+Pj4gOTViZDVlY2E2Ny4uNDg0ZTM1NDQxMiAxMDA2NDQN Cj4+PiAtLS0gYS90b29scy9pbmNsdWRlL3hlbmN0cmwuaA0KPj4+ICsrKyBiL3Rvb2xzL2lu Y2x1ZGUveGVuY3RybC5oDQo+Pj4gQEAgLTE1OTcsNiArMTU5Nyw3IEBAIGludCB4Y192bXRy YWNlX3NldF9vcHRpb24oeGNfaW50ZXJmYWNlICp4Y2gsDQo+Pj4gdWludDMyX3QgZG9taWQs DQo+Pj4NCj4+PiAgICBpbnQgeGNfZG9tY3RsKHhjX2ludGVyZmFjZSAqeGNoLCBzdHJ1Y3Qg eGVuX2RvbWN0bCAqZG9tY3RsKTsNCj4+PiAgICBpbnQgeGNfc3lzY3RsKHhjX2ludGVyZmFj ZSAqeGNoLCBzdHJ1Y3QgeGVuX3N5c2N0bCAqc3lzY3RsKTsNCj4+PiArbG9uZyB4Y19tZW1v cnlfb3AoeGNfaW50ZXJmYWNlICp4Y2gsIHVuc2lnbmVkIGludCBjbWQsIHZvaWQgKmFyZywN Cj4+PiArc2l6ZV90IGxlbik7DQo+Pj4NCj4+PiAgICBpbnQgeGNfdmVyc2lvbih4Y19pbnRl cmZhY2UgKnhjaCwgaW50IGNtZCwgdm9pZCAqYXJnKTsNCj4+Pg0KPj4+IGRpZmYgLS1naXQg YS90b29scy9saWJzL2N0cmwveGNfcHJpdmF0ZS5jDQo+Pj4gYi90b29scy9saWJzL2N0cmwv eGNfcHJpdmF0ZS5jIGluZGV4IGMwNDIyNjYyZjAuLjZhMjQ3ZDJiMWYgMTAwNjQ0DQo+Pj4g LS0tIGEvdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuYw0KPj4+ICsrKyBiL3Rvb2xzL2xp YnMvY3RybC94Y19wcml2YXRlLmMNCj4+PiBAQCAtMzI2LDY0ICszMjYsNiBAQCBpbnQgeGNf Zmx1c2hfbW11X3VwZGF0ZXMoeGNfaW50ZXJmYWNlICp4Y2gsIHN0cnVjdA0KPj4geGNfbW11 ICptbXUpDQo+Pj4gICAgICAgIHJldHVybiBmbHVzaF9tbXVfdXBkYXRlcyh4Y2gsIG1tdSk7 DQo+Pj4gICAgfQ0KPj4+DQo+Pj4gLWxvbmcgZG9fbWVtb3J5X29wKHhjX2ludGVyZmFjZSAq eGNoLCBpbnQgY21kLCB2b2lkICphcmcsIHNpemVfdCBsZW4pDQo+Pg0KPj4gV2h5IGRvbid0 IHlvdSBqdXN0IHJlbmFtZSB0aGlzIGZ1bmN0aW9uIGFuZCBtb2RpZnkgdGhlIHVzZXJzIHRv IHVzZSB0aGUgbmV3DQo+PiBuYW1lPw0KPiANCj4gRm9yIHR3byByZWFzb25zOg0KPiAxKSBo YXZpbmcgdGhlIGRvX21lbW9yeV9vcCBhcyBhIHN0YXRpYyBpbmxpbmUgaXMgY29uc2lzdGVu dCB3aXRoIGhvdyBkb19kb21jdGwgYW5kIGRvX3N5c2N0bCBhcmUgaW1wbGVtZW50ZWQsIHNv IGxvZ2ljYWxseSB0aGF0J3Mgd2hhdCBJIHdvdWxkIGV4cGVjdCB0byBzZWUgZm9yIHRoZSBt ZW1vcnlfb3AgaHlwZXJjYWxsIGFzIHdlbGwuDQoNCkl0IGlzIG11Y2ggbW9yZSBjb21wbGlj YXRlZCB0aGFuIHRoZSBkb19kb21jdGwgYW5kIGRvX3N5c2N0bCBpbmxpbmVzLg0KDQpBZGRp dGlvbmFsbHkgaXQgaXMgYmVpbmcgdXNlZCBieSBsaWJ4ZW5ndWVzdCwgc28gbWFraW5nIGl0 IGFuIGlubGluZSB3b3VsZA0KZXhwb3NlIGxvdHMgb2YgbGlieGVuY3RybCBpbnRlcm5hbHMg dG8gbGlieGVuZ3Vlc3QuDQoNCj4gMikgdGhlIHBhdGNoIGl0c2VsZiBpcyBjbGVhbmVyIGJl Y2F1c2UgdGhlcmUgaXMgbm8gY2h1cm4gaW4gYWxsIHRoZSBmaWxlcyB0aGF0IHByZXZpb3Vz bHkgY2FsbGVkIGRvX21lbW9yeV9vcC4NCg0KT1RPSCBhbGwgY2FsbGVycyBhcmUgaW4gWGVu LCBzbyBpdHMgbm8gZGVhbCB0byBjaGFuZ2UgdGhvc2UuDQoNCg0KSnVlcmdlbg0K --------------RoAzGDslZIwx1fwjR5VupjH4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------RoAzGDslZIwx1fwjR5VupjH4-- --------------YA7LONw6iPpF09Gy0sLh6EwF-- --------------EtefNS5gnDDF4A3NdlOwHIlg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKGVLAFAwAAAAAACgkQsN6d1ii/Ey/k fAgAhudhlQN0xAafqFDNkNVCSzWmUS+5hxxyEpyE03XO80TkGDrtZAqPOfFUbvRmhiP5FxuMY/pg +zl2nCEi6dUbTzZTaEr113l/mW+b6BDW5XmvB41i9rU8i9R5kC+DSWRwNRq+BT6fUMw9b7/o1CRQ KdbB04jSupUpRgJ7Y2owE8b75NwgUhgPeIb/t9KdmC8JzuiAxoY9qGArCzEaHMykjRZac+mmCbCJ dOgkiZ/zISYxUdX4SUMpzPS2yf1Q9CAi30q/wnO/nvswzGNLNOauXnIYLlzyj7/M4ZVcOMGxSffy RLQktJ8QnZXmou7IjjUCZumjUaBp2p9iJPws/8/YSg== =qSOS -----END PGP SIGNATURE----- --------------EtefNS5gnDDF4A3NdlOwHIlg-- From xen-devel-bounces@lists.xenproject.org Thu May 19 14:33:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:33:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333033.556816 (Exim 4.92) (envelope-from ) id 1nrhDC-0005Tw-G3; Thu, 19 May 2022 14:33:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333033.556816; Thu, 19 May 2022 14:33:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhDC-0005Tp-Ca; Thu, 19 May 2022 14:33:10 +0000 Received: by outflank-mailman (input) for mailman id 333033; Thu, 19 May 2022 14:33:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhDA-0005Tc-RD for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:33:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98df4682-d780-11ec-837e-e5687231ffcc; Thu, 19 May 2022 16:33:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98df4682-d780-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652970787; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QT0pu8MxxL6RqJbybWAqXmT9dVU0yAKlVYyXlrkqQg8=; b=M9YT39eHY0e7B2YvFofEInPwFiChe6s0vW+Jt3IV+A6WcOjIciZtFCNk RelNSiDS1mGrhAoTe60CeHmJphKoGABqCr61fEn4VG4TsgRe3lb7hOe2H CkiaLfUnq/OZFLuFJwHP5PT66Xsr6c8aD9nCHeJJWU9APd3jpzMz+PTOA c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72098467 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:o0mbnaMWTDbw0xHvrR1Gl8FynXyQoLVcMsEvi/4bfWQNrUohhDQPm DNLXmHVM6mPNjbwKtB2Pong8xsOvcXWnYVlTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk298w2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z1 fxc5d+2ERkSDKDHkfs0ckRGLQZ+MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRR66PN 5ZHNlKDajz6Oh9xanIqJq4shf+srH3gMBFDj0ia8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTQIsPEJWo+/gsh0ecrkQKBRgLEFG/pvK6oki5Xd1ZN goT4CVGhaop8ku0ZsPwUx2xvDiPuRt0c8NdFvB/5AyTx6785QGfCW4ZCDlbZ7QOr887QyAnx 3eGmtroAXpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiJg+iw+KUsxiDq+8ivXzHjf/x S3MqzIx74j/luZSif/9pwqexWvx+N6ZFWbZ+zk7QEq4xxIpJ4j9ebea5FPS8t9hcZinaVmO6 S1sd9el0MgCCpSElSqoSeoLHa206/vtDAAwkWKDDLF6qW3zpifLkZR4pWgneRw3appslSrBO he7hO9H2HNE0JJGh4dTapn5NcklxLOI+T/NBqGNNYomjnScmWa6EMBSiay4gjmFfKsEy/hX1 XKnnSGEVC9yNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXTNLBgtv/Z+VuOq 76z0vdmLD0GAIXDjtT/q9ZPfTjm01BlbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9zY/1E oWGchYAkjLX3CSfQS3TMywLQO6/DP5X8CNgVQRxbAnA5pTWSdv2hEvpX8BsJudPGS0K5aMcc sTpjO3ZUqsQEWydo291gFuUhNUKSSlHTDmmZ0KNCAXTtbY6L+AV0rcIpjfSyRQ= IronPort-HdrOrdr: A9a23:NdLe2q+ifBk5HTPD6RFuk+DYI+orL9Y04lQ7vn2YSXRuHPBws/ re+MjztCWE7Qr5N0tMpTntAsW9qDbnhPlICOoqTNWftWvd2FdARbsKheCJ/9SjIVycygc079 YHT0EUMrzN5DZB4vrH3A== X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="72098467" Date: Thu, 19 May 2022 15:33:01 +0100 From: Anthony PERARD To: Bernhard Beschow CC: , , , , , John Snow , "open list:IDE" Subject: Re: [PATCH v2 2/3] hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() Message-ID: References: <20220513180957.90514-1-shentey@gmail.com> <20220513180957.90514-3-shentey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220513180957.90514-3-shentey@gmail.com> On Fri, May 13, 2022 at 08:09:56PM +0200, Bernhard Beschow wrote: > The comment is based on commit message > ae4d2eb273b167dad748ea4249720319240b1ac2 'xen-platform: add missing disk > unplug option'. Since it seems to describe design decisions and > limitations that still apply it seems worth having. > > Signed-off-by: Bernhard Beschow > --- > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > index 2345fe9e1d..bc1b37512a 100644 > --- a/hw/ide/piix.c > +++ b/hw/ide/piix.c > @@ -173,6 +173,17 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) > } > } > > +/* > + * The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to > + * request unplug of 'aux' disks (which is stated to mean all IDE disks, > + * except the primary master). > + * > + * NOTE: The semantics of what happens if unplug of all disks and 'aux' disks > + * is simultaneously requested is not clear. The implementation assumes > + * that an 'all' request overrides an 'aux' request. > + * > + * [1] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.pandoc > + */ > int pci_piix3_xen_ide_unplug(DeviceState *dev, bool aux) > { > PCIIDEState *pci_ide; That comments seems to focus on 'aux', but it also gives some pointer on what calls the function. So it looks fine. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 19 14:37:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:37:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333044.556827 (Exim 4.92) (envelope-from ) id 1nrhHT-0006Dj-5q; Thu, 19 May 2022 14:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333044.556827; Thu, 19 May 2022 14:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhHT-0006Dc-2k; Thu, 19 May 2022 14:37:35 +0000 Received: by outflank-mailman (input) for mailman id 333044; Thu, 19 May 2022 14:37:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhHS-0006DW-1N for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:37:34 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 363cc6c0-d781-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 16:37:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 363cc6c0-d781-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652971052; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ebfjX54Q/dRlgfHegJC/4k9RI/dgb8rA4FaZPyu1KJc=; b=K84E+qbbtPb23OWLAYOtDKCcozWkkpwpGjp14KN5Xf4ivdKSFR2QnYr2 5PsKubJ6tawqYpUP1sS1tGoDy2yQmHfCtQyQISHAnYtrVuZNy5Sg+ab0B 7sQotjVc7YhjTaCMVe1Cxu2lXmXski+6vzBQE2cqE9/WGfuz27837kR1e 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71710597 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:NIQFwKC8e5CfWRVW/3bkw5YqxClBgxIJ4kV8jS/XYbTApGwr1GdSn DEfXG3VMveIMWWjfNogb43n9hwF68fdytEyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhq8 sdRmL+sRj0jAbz2vuZMcAt+TiNXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8XQq+GO ptGAdZpRBSfOiwMKHosMps/oOa4nXfwUHoBtWvA8MLb5ECMlVcsgdABKuH9YN2BRcxPkgCYq 2TK8n7iBRcyMN2ZwCCCtHW2iYfnhSn8XpATEryQ7PNmgFSPgGcUDXU+UFKhqvS9zEemVd9bI UUJ/wIhqKEz8AqgSdyVdwS1pWPBtBobUNl4Feo85weQjK3O7G6xBHMCSSFpctEqtMYqAzct0 zehkt/0DCZjt5WVQHie8ayI6zW/JUA9KHQeTTUJQQsM/5/op4RbpgvCS8smDLS0kNz8HRn2x DaFqjV4gK8c5eYS2qCmuFzKnT+ojp7OSAEz+0PQRG3Nxhh5aYi5ap2A5l3S7PIGJ4GcJnGRs X5Bl8WA4eQmCZCWiDfLUOgLBKuu5fuOLHvbm1EHN4Eo6jCF63OlO4dK71lWP1x1O8wJfTvoZ k77ug5L4pJXenywYsdKj5mZUppwi/K6TJK8C66SPoEmjoVNmBGv5xt8eWOzw2/Xmnc9q4c9a LSJV5uuJCNPYUh49waeS+AY2L4t4ykxw2LPWJz2pyiaPaqiiG29EulcbgbXBgwtxObd+ViOr Y4DXyef408HONASdBU75mL6wboiCXEgTa77pMVMHgJoClo3QTpxYxM9LF5IRmCEo0i3vrqRl p1echUBoLYauZEgAVzTAk2PkJu1Af5CQYsTZETAx2qA1Xk5epqI56wCbZYxdrRP3LU9kKQkF qNZJpzeWawnptH7F9M1NMmVkWCfXE7z2VLm09SNPlDTgKKMtySWo4S5L2MDBQEFDzattNtWn lFT/lizfHb3fCw7VJy+QKv2lzuZ5CFB8MovDxqgCoQCIy3Erdk1QxEde9dqeqng3z2YnWDEv +tXaD9FzdTwT3gdqYmW2vvc9d/yewa8d2IDd1TmAX+NHXGy1gKeLUVoCY5koRi1uLvIxZif IronPort-HdrOrdr: A9a23:v08bXqwXPdbnKZsMDznDKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU= X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="71710597" Date: Thu, 19 May 2022 15:37:24 +0100 From: Anthony PERARD To: Bernhard Beschow CC: , , , , , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , "open list:IDE" Subject: Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Message-ID: References: <20220513180957.90514-1-shentey@gmail.com> <20220513180957.90514-4-shentey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220513180957.90514-4-shentey@gmail.com> On Fri, May 13, 2022 at 08:09:57PM +0200, Bernhard Beschow wrote: > This function was declared in a generic and public header, implemented > in a device-specific source file but only used in xen_platform. Given its > 'aux' parameter, this function is more xen-specific than piix-specific. > Also, the hardcoded magic constants seem to be generic and related to > PCIIDEState and IDEBus rather than piix. > > Therefore, move this function to xen_platform, unexport it, and drop the > "piix3" in the function name as well. > > Signed-off-by: Bernhard Beschow > Reviewed-by: Paul Durrant Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu May 19 14:45:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333063.556842 (Exim 4.92) (envelope-from ) id 1nrhPJ-0007mO-3f; Thu, 19 May 2022 14:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333063.556842; Thu, 19 May 2022 14:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhPI-0007mH-Vd; Thu, 19 May 2022 14:45:40 +0000 Received: by outflank-mailman (input) for mailman id 333063; Thu, 19 May 2022 14:45:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhPH-0007mB-NB for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:45:39 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57962362-d782-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 16:45:37 +0200 (CEST) Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 May 2022 10:45:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO2PR03MB2326.namprd03.prod.outlook.com (2603:10b6:102:a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.17; Thu, 19 May 2022 14:45:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.016; Thu, 19 May 2022 14:45:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57962362-d782-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1652971537; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2BRMicQzuF5aLdNlVH9RaEGorNx4Fir7qDpArhAAu5o=; b=bcpuzRAXa0Ev8nN1/qHQqsgZj6NhlacjZef+6rZGS6nh8+MKwVP4u+D1 g7kvXdqymflpGkicnAMkVo1VqUI3jOQ679e6eaXJJedDzk3iPTBZm8swu HQduOoRYDQWamyBUWVqL0Nv5RKgqaDsUu6wx5ptoPlWB94G/WfsWEAhPv g=; X-IronPort-RemoteIP: 104.47.58.103 X-IronPort-MID: 74215243 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UjEmo6vs/KTZIZeGoqKTczXQkefnVJRfMUV32f8akzHdYApBsoF/q tZmKWuPPfrbazT0f9oib4yyp0pUupbUndZmQQM5qyFmFCNG+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U6 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8kH4TQuNY8FCB1AhlcF6dU2oXqYmeW5Jn7I03uKxMAwt1IJWRvZcg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5o3aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3J//NquTSIpOB3+KPSNcOEe/6befRMoRigl mvbrifBJzhPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz FDht8ztLSxitvuSU3313rWJq3W0MCscL24HbAcFSxcI55/op4RbphHCUNdlVrK0h9vdGDfsz jTMpy8774j/luYO3qS/uFzC3TSlo8GRShZvv12MGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWB6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:9ePEga3/vvU2orl/IHn6dAqjBTtyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMUj+Ka+Adwo4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z LxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72PeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu15Dq r/Q+BVfYp1P74rhJJGdZk8qPSMexzwqDL3QRSvyAfcZeg600ykke+E3JwFoMeXRbcv8Lwe3L z8bXIwjx9GR6upM7zC4KF2 X-IronPort-AV: E=Sophos;i="5.91,237,1647316800"; d="scan'208";a="74215243" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QV5dUxXncp2NVJjImYUCgoEy3nnRCPmphzBTq/5ITD/GpAK1tZaNFEGf51azZ77NYdB6lsvgV5XUj1T46IsEMxszoHC76C8fYg39D/U7+FXdLCJ6jBz9Y/oBKseA10t8W8FJAcrsNN/2C23a0fDTVMcl3uBefoZBIIrgWs4EA3mh2jm9DKy9qUu6EYJCgYOQ90Jf8Ii14PjVCw4cJuBAoVbZMmUbHAwHJ/S/G48g19KsyrwgefGjrlpX7r8wZ6yLDTwpPdaV89rwJuDWYEq8EfbNj+Ewj2x89PjvJQMFx1NeMmbkeugPKqtykLmgZyYHIGu1bJtm2MXgW9mClneD+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ESu5xGfl/aC4U/R27cvs98qrOCW91AnVEnn7djkdbc=; b=jNhKTuUce1EL8BYl2mreooNeu1lMGzScIBacDg5e0rcFp8qwETRQcMSZ7nc8Ly6dKf3Zmo9pyhUNEHWJNeXg+UOIKS9FBavtlXkFc/8tFNGl0GTe3Iwsxp0jNazPPYdYkO5HJuzr0F+ukEY1+0OJOujSKfMBN1keuLKO7qCazjStKBRhk6hVa1w3Fznb9fd5zszWfZJEEfNSqF1Wk3GfuXeAFmyj4+6hvWqJ9PMNqJvNK92aM8aSCGBi3209ZyXrLkL8ceQXq2n/8AcGmpMCsEjMQDp5q0zWTc7Et87sNZ7o+QuCgAsL335RNdWS/Ek4xCHrMVyZ7hbKg4cucwsF9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ESu5xGfl/aC4U/R27cvs98qrOCW91AnVEnn7djkdbc=; b=PURyxy7cpwAYZIyKFNlNFl4OMv0Itv6qOD4kMRTgvRrCjNSg+P95STj/zxpYNTS8ykJ2G4h01uWRGDx6mImzuajjfti1iSZqiyu1Ec4V/aUbb3o/XlJPmYkj9idl2Ry3JR79lpiWGPfxeZSGndR3cs1bvxTsHmhDjrukb2hS7SU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Thu, 19 May 2022 16:45:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0345.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4d0d2c8-3a7d-4f77-6e4d-08da39a635a6 X-MS-TrafficTypeDiagnostic: CO2PR03MB2326:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0kVkz0/OmPRwhxzomB8fLq3rxeGWyBy43stE4lGSfmc8dLah3RJT3EuJR7joTnyuEkoHxVuw+ZaPURAT7bC7CSawU1eHkG89riKquH1Y+OT8qoDcGWwOTIZOzlkr0HSFPyzf3gpQJMCZ2ZT2yLS+jE5TYVhVl9RKXRcOvFArv5bXFWloT4/IyuGThdaaCeq5atOq/RO7st4Y1ICtRHjuigpLQrkM2U2f2bmQJ5mQm0TcQHwe5vTGdWzrCY01ip/oeIhGgeFVNgbxiIN1GRqQHkmrHOnKARnt39PuQkAElEuZ1g7ItXwwOy8JaaVyJxP3eVnTy5rermbujQwq/rAH7O+yKjMjF/VlT7wY47zYkPao1jFUwG2rQzhX1q6Gp7Gc8Yv2zjQxbqxHT94K87C130G/La1DKf+L5Cel1nSyBtHhsBpm/m1chNPdMutw1tBpbaFo+LN9ltRN65TBI3/S/VJ1zEzEUg8N+ABFLJekkVrMWIO6bPAkTmoU2aOmjqDBxb0BBEXYlTAU9Rfb6mfw36nXkkG2wf80Ab9ZxCXeA1lbnEhFf4STn+v1M5YYhnyODucC/ifoLUv3bY0n3kQQhHPqKXVb78VsOK/o8HmE0figs5myMZx824j60w1zBGpXUbVLAI085NBY8n504wXgig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(316002)(6636002)(33716001)(83380400001)(53546011)(2906002)(186003)(66556008)(6512007)(9686003)(26005)(8676002)(6486002)(5660300002)(86362001)(66946007)(508600001)(82960400001)(4326008)(66476007)(38100700002)(6506007)(85182001)(54906003)(6862004)(6666004)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3FnOHBxRmFhQmM0VHQwK0I4NlZoMWxaMlFpZVVtVlJHQ1Q4bjlJNk5PRFp2?= =?utf-8?B?Y2FsNVFLck1nZHZJK2ord0hVUzA3T2ZSV3lMbFIyS1ZISzAxdVh3eXB0VEt2?= =?utf-8?B?aUlkUWFMNWRFT05VMDBkdWxtK0hDK2V3Uy9mSGZZN2dTRW03VzFCSE5CbXdE?= =?utf-8?B?bXphaitWQjRnOHJudFl5eGViWTJibVdBZklmRHVzTTJ6SVFXVFVZM3Yzd0JK?= =?utf-8?B?aXhnZHJIRmR4bTcwY0NURFF6SmEyVW5tN2ZlRU16d0hMVmVkdXdjSitUbHlv?= =?utf-8?B?cis2R0pRT3AzSVB3L2ZQVUR4ZzBmVnpSQmwzYXd5Rk85V2g1VVc0Y2RyR2s4?= =?utf-8?B?d09DRkJoOTk3MzVyckRlcTBRb1NpNmFKMnVwV2JXS1VHQ2tHcTFVQnkxSkR0?= =?utf-8?B?bG9RK0c4TTFreXN3bHVGRVZBby92MnZyS0x0OWI5ZHo4Z3liYW5rbXl6VjhJ?= =?utf-8?B?RmJ1Rll6R1pMdlhIcS9QQ3FEOHh0SVVSWDNjK2F3UXBTQm5XV3hJd2UvNity?= =?utf-8?B?cFRmVVBjOUpUK2JGRXZQeGh3Nlo5MlJIMUJ2dXRaa29RaHJ0QnkxeWltQm1Y?= =?utf-8?B?ZGh2TmdPUjN0VWxqbzdUQ3AyZmR5ZEZWMlQ0L0dTVSt1ODl4WTU1OVpOaTFt?= =?utf-8?B?c1BwS2E5SG12QS9zd0dRMFZETjlpa2RlMjZYNVBIdVY5Nm5JVGkvNWpieGVP?= =?utf-8?B?Tk1QNGtOOTJhSFVMY285Zk1kMVhkV1FPdXovS3BkTm5rUy90elZwcHhRSlVW?= =?utf-8?B?UnRoeHgzT0VHei9NSHhlU2ltZmVMZlh5ZW1UWU1veFlqTEk0OG5pRklmVVlV?= =?utf-8?B?SkFOdmg3RmFHN0tOam1McEFWTThvbzBNSTFoM0hKeWx1cStDNk9lOEQ3dDk1?= =?utf-8?B?QkJobVZXeExyMFpkQ0lXN2JydGptQnd6VW0xcUlKb3h3Yk5TTzkwY2RPRW5y?= =?utf-8?B?Tm1rNGNEdHd2MXlOWUJwTDVLYU12QTZUcko4NFpFWVJ4RVpsMGNjdEFoRHI1?= =?utf-8?B?NHZFaWJHdW0vcTVHMEIwM2FMdkc3dStxVUJzaTlrRjBBakQySHV5dWNjcThL?= =?utf-8?B?cFNNWlFBL3UvMUlPb2NwK0h0b1Nudk80d3BaNHV4V05OMlJMc0F0bkhqdlRs?= =?utf-8?B?TEZscHNyNkZSVGh0QXQrRVdMbjVkclNXTmZnR3VkWVJ2aUU4OUhrVUpnbmd1?= =?utf-8?B?YTFUWkVMUktRRElFQm81TmdiaDlSTHJJMWFSV1g0bHo0MUFIa0NoV0taRytr?= =?utf-8?B?aHBEV3RUd0JqZUZNODlvQTcza0ErVWtvaEVvMFZMajFyTU5rM1ZVODFWNWxY?= =?utf-8?B?ckxGSmtqWnRpdm10VnVpVTJVbnNFVEZSL25BS1BOakN2SlRwM1luWS9kODhP?= =?utf-8?B?SUhqL1R4YWkzcHhKOVhCZ1loU3RpeURtbjBlUktITnY3aVNEeFkxeGdtZTBK?= =?utf-8?B?a3RUL1hLc3RiT3kzL0FBd0ZxbGVEb2I2UEZJRExHM28yenFBYUtqY3hiQmEw?= =?utf-8?B?ZWxpYnM1YWEwU2U0MllvVjlPZitIVkllL3JKckREZ3NHYkY5WkgwMkMzRHYv?= =?utf-8?B?WFFNa3BNSGlORUlRRGRWeXJZZmprTEUxbFF4WUlvWngzQWFFcGZna2wzSTFz?= =?utf-8?B?QXFzWTQ0SXpMb1E0cjA2QWM4bmhJeFJCVEErSzVQaVhsZGlrcDB6QlhqcHFn?= =?utf-8?B?ZFNEYTNDL3hGQmJ5cDN2SE5PL2x2bnB5VmFUUzlDRlhDWjhBZTkyOThVcTJH?= =?utf-8?B?QmJrRGRsd2dnazZaQnA5Z2I5MitvRE9VN1VrU3R2MHQrYXkybWE1enlzZ0ha?= =?utf-8?B?N2Z3ay9EVFlYeW5peDR0SGt5WFJXTlcrU0FpZk1HY203VTFEODZBMVZYamNa?= =?utf-8?B?ajlKV0IzK0hic3RqNGJKTXBKcnpmV0padzk4RHViWGhBeUFYZFUwR0k5a2tn?= =?utf-8?B?Zng5aWFheDdXMjdtYUhYWWxmbWhHbTFFKzNGR3hJOG5MSVZxTnhJVWQ0dS91?= =?utf-8?B?bVdRYzBqRkRXUkI4UDhFSFVTR0syMnJBOWk0dExmeFc1NWFzUTVxa3o0RmUy?= =?utf-8?B?SjNSYzRmT1VsMDdNTldCcWxsYXJiazM5dHlDYXVLTGhPcWxRcTIwa2pqL2VF?= =?utf-8?B?alBVSS9HcHMyWFdpYjBTd1M2eUNRTkxJQlVBSjN6L2xxRzJuMUsxaWVSS0M1?= =?utf-8?B?cEhta3FvQjBLeDNGRkNOV1dIRXh1WWo0Zlg5bDJHRnU1Rkp1QndEeW5vMHJN?= =?utf-8?B?VHdYaEtUL0k1SGl1eEM2bGRlZ3A4ank5YjEzMDZlTmtPb3BDZUY2anpJOC9p?= =?utf-8?B?MEhqbEFrcWhpUW1FOUtnN1JUaW9vbWtTekhpTU5hVTRTcGNKQVJQaVNnWHps?= =?utf-8?Q?7rR5MKJotLP152c0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4d0d2c8-3a7d-4f77-6e4d-08da39a635a6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 14:45:25.5675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K0xYpmNaq4wWPBpuxE0zvY2Zg/IJ5LCSLFATF7tQh6euBH2XyQ62hrEXQmaLHSxf1Kwnj3YFl0jtFGYDDNBr1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2326 On Thu, May 19, 2022 at 12:10:24AM +0000, Andrew Cooper wrote: > On 17/05/2022 14:21, Roger Pau Monne wrote: > > Under certain conditions guests can get the CPU stuck in an infinite > > loop without the possibility of an interrupt window to occur. > > instruction boundary. > > It's trivial to create an infinite loop without an interrupt window :) > > Also, I'd probably phrase that as an unbounded loop, because not all > problem cases are truly infinite. > > > This > > was the case with the scenarios described in XSA-156. > > Case in point, both of these can be broken by something else (another > vCPU, or coherent DMA write) editing the IDT and e.g. making the #AC/#DB > vectors not present, which will yield #NP instead. > > > > > Make use of the Notify VM Exit mechanism, that will trigger a VM Exit > > if no interrupt window occurs for a specified amount of time. Note > > that using the Notify VM Exit avoids having to trap #AC and #DB > > exceptions, as Xen is guaranteed to get a VM Exit even if the guest > > puts the CPU in a loop without an interrupt window, as such disable > > the intercepts if the feature is available and enabled. > > > > Setting the notify VM exit window to 0 is safe because there's a > > threshold added by the hardware in order to have a sane window value. > > > > Suggested-by: Andrew Cooper > > Signed-off-by: Roger Pau Monné > > --- > > This change enables the notify VM exit by default, KVM however doesn't > > seem to enable it by default, and there's the following note in the > > commit message: > > > > "- There's a possibility, however small, that a notify VM exit happens > > with VM_CONTEXT_INVALID set in exit qualification. In this case, the > > vcpu can no longer run. To avoid killing a well-behaved guest, set > > notify window as -1 to disable this feature by default." > > > > It's not obviously clear to me whether the comment was meant to be: > > "There's a possibility, however small, that a notify VM exit _wrongly_ > > happens with VM_CONTEXT_INVALID". > > TBH, I read that as a get-out clause for "we have no idea what to set > for a default window", and it's not a decision reasonable to defer to > users, because they have even less of an idea than us. > > All CPUs with Notify VM Exit have the TSC crystal information in CPUID, > so I'd suggest that we trust CPUID to be accurate, and program for maybe > 10us?  That's 1/3 of a default timeslice. > > > > > It's also not clear whether such wrong hardware behavior only affects > > a specific set of hardware, in a way that we could avoid enabling > > notify VM exit there. > > > > There's a discussion in one of the Linux patches that 128K might be > > the safer value in order to prevent false positives, but I have no > > formal confirmation about this. Maybe our Intel maintainers can > > provide some more feedback on a suitable notify VM exit window > > value. > > > > I've tested with 0 (the proposed default in the patch) and I don't > > seem to be able to trigger notify VM exits under normal guest > > operation. Note that even in that case the guest won't be destroyed > > unless the context is corrupt. > > Huh... There's nothing in the manual about that, but obviously hardware > has some minimum safe value if 0 appears to work in practice. Got the tip from looking at the KVM patch submission for notify VM exit implementation. Seeing your suggestion above to use 10us and your reply here, I'm unsure whether you are fine with using 0. > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > > index d388e6729c..5685a5523e 100644 > > --- a/xen/arch/x86/hvm/vmx/vmcs.c > > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > > @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); > > static unsigned int __read_mostly ple_window = 4096; > > integer_param("ple_window", ple_window); > > > > +static int __read_mostly vm_notify_window; > > +integer_param("vm-notify-window", vm_notify_window); > > Part of me is loath to keep on adding new top-level options for this. > > I was about to suggest having a vmx= option, but I've just noticed that > ple_{window,gap} are wired up to cmdline options on Intel, and fixed > constants on AMD. Do we want to make this VMX specific? The problem affects both Intel and AMD, so I would think it's possible for AMD to introduce a similar solution in the future and hence we might want to share "vm-notify-window". That however raises questions as to whether AMD will also allow specifying a window, and whether it will be in crystal clock units. > Thoughts on a suitable name? vmx and svm would seem fine to me. > > @@ -1333,6 +1338,19 @@ static int construct_vmcs(struct vcpu *v) > > rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, > > VMX_MSR_GUEST_LOADONLY); > > > > + if ( cpu_has_vmx_notify_vm_exiting && vm_notify_window >= 0 ) > > + { > > + __vmwrite(NOTIFY_WINDOW, vm_notify_window); > > + /* > > + * Disable #AC and #DB interception: by using VM Notify Xen is > > + * guaranteed to get a VM exit even if the guest manages to lock the > > + * CPU. > > + */ > > + v->arch.hvm.vmx.exception_bitmap &= ~((1U << TRAP_debug) | > > + (1U << TRAP_alignment_check)); > > + vmx_update_exception_bitmap(v); > > IIRC, it's not quite this easy.  There are conditions, e.g. attaching > gdbsx, where #DB interception wants turning on/off dynamically, and the > logic got simplified to nothing following XSA-156, so will need > reintroducing. > > AMD Milan (Zen3) actually has NoNestedDataBp in CPUID.80000021.eax[0] > which allows us to not intercept #DB, so perhaps that might offer an > easier way of adjusting the interception logic.  (Or maybe not.  I can't > remember). OK, will look into it. > > + } > > + > > out: > > vmx_vmcs_exit(v); > > > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > > index 02cc7a2023..9c37790c36 100644 > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > */ > > break; > > > > + case EXIT_REASON_NOTIFY: > > + __vmread(EXIT_QUALIFICATION, &exit_qualification); > > + > > + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) > > + { > > + perfc_incr(vmnotify_crash); > > + gprintk(XENLOG_ERR, "invalid VM context after notify vmexit\n"); > > + domain_crash(v->domain); > > + break; > > + } > > + > > + if ( cpu_has_vmx_vnmi && > > + (exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) ) > > + { > > + unsigned long guest_info; > > + > > + /* Exit was incident to an execution of IRET that unblocked NMIs. */ > > + __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); > > + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, > > + guest_info | VMX_INTR_SHADOW_NMI); > > I am saddened by how irritating it is having the UNBLOCKED_BY_IRET (in > the first place...) but moving between the exit qualification and the > vmexit intr info fields.  The constant probably ought to be renamed to > lose the INTR_INFO prefix. > > I'd suggest a prereq patch to also break > > static void undo_nmis_unblocked_by_iret(void) > { >     ... > } > > out to avoid opencoding it in several places.  There's one other > instance in our code (general fault intercept), but we're buggy on > PML-full, APIC-access and EPT violation all of which Xen handles. I don't think we are buggy on APIC-accesses, the SDM says: "Executions of IRET may also incur VM exits due to APIC accesses and EPT misconfigurations. These VM exits do not report information about NMI unblocking due to IRET." > I don't think you need the vnmi check, because the bit is 0 otherwise. Right, the bit is only defined in the Xen case if vnmi is enabled, because Xen requires PIN_BASED_NMI_EXITING to be set (NMI Exiting set to 0 could also allow the bit to be 1). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Thu May 19 14:46:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:46:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333068.556853 (Exim 4.92) (envelope-from ) id 1nrhPp-0008GZ-Bs; Thu, 19 May 2022 14:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333068.556853; Thu, 19 May 2022 14:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhPp-0008GS-8R; Thu, 19 May 2022 14:46:13 +0000 Received: by outflank-mailman (input) for mailman id 333068; Thu, 19 May 2022 14:46:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhPn-0008F0-7P for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:46:11 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6575c809-d782-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 16:46:02 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DDA18320091A; Thu, 19 May 2022 10:45:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 19 May 2022 10:45:58 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 10:45:56 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6575c809-d782-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652971557; x= 1653057957; bh=oB+ldJHY4tOV0pnetVPWTYdJNqusaNeb1y9bZQDgR4Q=; b=H EUmJo6b8rkiKCBC6yRqfhm5Pr9YDa40ZQNDDk5GsNBtq8YTQYW5bH3kzhsSPTskp tAcnigIK6lwBXKpwO290HCMyxLTyLw/0GCtjdQY69jAUJHFvP0nrW8ZDwH4d0Usk CkXyVAQ2wXKxTSC8kzt+jZWAxfya5EYlxtDq1OpA1rYVEoi9twsZC8URBDc0Hhzz REdQxJWQHkQthC65ZZVAUXk/XkjC5eNSijMjSLkfQelRiaI97J8R8XB7RLrVilTf yDhDAhWPLDFJCrHPW68/K1HRvBY/IdEX9g8qCCMhcCec/yKixMZg+eoPqPG0RV/E Ay7eRaQ/dLRA6lnoUMEwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652971557; x=1653057957; bh=oB+ldJHY4tOV0pnetVPWTYdJNqus aNeb1y9bZQDgR4Q=; b=fcykL4k7IXMKUByRq1mxH/KL/jXE6xJOR4W8UWkUyxqN 6bxTKWT0ivalKMS8A36UJ3EJ+KUdr3dI1QISu5siRruHiR7UBqZzHKpqvZIRWRKT UVjZS1fJ46eIuc5dkvOKBLIIsBLJq3qWp1iHUTW66E11vjWbxQtSzVylNWyvR81B zJ8HQDV2tlHw1WFY8oc9qxpnUzvN8vq/vcLoGO/txuWXAH2ykygs92pd0DGZcFSF WMKsFimdJk+E0XsYHTvM6qr2Mjv1J4X9WnymdaVGvCLhCeAWCoRISpaIC2kL1xKt pplb7345ogV5xKQcMzA043g42EAMi3mERpGAKERO+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffejgeej geffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 19 May 2022 10:45:51 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 Message-ID: References: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ys4fH9DfKD++O4Sh" Content-Disposition: inline In-Reply-To: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> --ys4fH9DfKD++O4Sh Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 10:45:51 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 On Thu, May 19, 2022 at 12:32:33PM +0200, Jan Beulich wrote: > On 18.05.2022 19:32, Demi Marie Obenour wrote: > > @@ -567,6 +587,39 @@ static int __init efi_check_dt_boot(const EFI_LOAD= ED_IMAGE *loaded_image) > > } > > #endif > > =20 > > +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; >=20 > Just out of curiosity: It's an arbitrary choice to use this initializer, > i.e. no initializer (and hence zero) would do as well (with ... That is correct. I chose EFI_INVALID_TABLE_ADDR because it seemed meant for this purpose. > > +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) > > +{ > > + size_t available_len, len; > > + const UINTN physical_start =3D desc->PhysicalStart; > > + const EFI_SYSTEM_RESOURCE_TABLE *esrt_ptr; > > + > > + len =3D desc->NumberOfPages << EFI_PAGE_SHIFT; > > + if ( esrt =3D=3D EFI_INVALID_TABLE_ADDR ) >=20 > ... an adjustment here, of course)? >=20 > > + return 0; > > + if ( physical_start > esrt || esrt - physical_start >=3D len ) > > + return 0; > > + /* > > + * The specification requires EfiBootServicesData, but accept > > + * EfiRuntimeServicesData, which is a more logical choice. > > + */ > > + if ( (desc->Type !=3D EfiRuntimeServicesData) && > > + (desc->Type !=3D EfiBootServicesData) ) > > + return 0; > > + available_len =3D len - (esrt - physical_start); > > + if ( available_len <=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entrie= s) ) > > + return 0; > > + available_len -=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); > > + esrt_ptr =3D (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; > > + if ( esrt_ptr->FwResourceVersion !=3D EFI_SYSTEM_RESOURCE_TABLE_FI= RMWARE_RESOURCE_VERSION || >=20 > Nit (style): Overlong line. Where is the best place to split this? EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION is a rather long identifier. > > + !esrt_ptr->FwResourceCount ) > > + return 0; > > + if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->= Entries[0]) ) > > + return 0; > > + return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); > > +} >=20 > Nit (style again): We generally put a blank line ahead of a function's > main return statement. Will fix in v7. > > @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE Imag= eHandle, EFI_SYSTEM_TABLE *Syste > > if ( !efi_memmap ) > > blexit(L"Unable to allocate memory for EFI memory map"); > > =20 > > + efi_memmap_size =3D info_size; >=20 > I don't think this global needs setting here, yet? The local will > do just fine here, likely yielding smaller code. But I realize that's > connected to how you did your change vs what I was expecting you to > do (see below). >=20 > > + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_siz= e, > > + efi_memmap, &map_= key, > > + &efi_mdesc_size, > > + &mdesc_ver); > > + if ( EFI_ERROR(status) ) > > + PrintErrMesg(L"Cannot obtain memory map", status); > > + > > + /* Try to obtain the ESRT. Errors are not fatal. */ > > + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) > > + { > > + /* > > + * ESRT needs to be moved to memory of type EfiRuntimeServices= Data > > + * so that the memory it is in will not be used for other purp= oses. > > + */ > > + void *new_esrt =3D NULL; > > + size_t esrt_size =3D get_esrt_size(efi_memmap + i); > > + > > + if ( !esrt_size ) > > + continue; > > + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D=3D > > + EfiRuntimeServicesData ) > > + break; /* ESRT already safe from reuse */ > > + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_s= ize, > > + &new_esrt); >=20 > I should have re-raised the earlier voiced concern when reviewing v5 (or > maybe already v4), and I'm sorry for not having paid close enough > attention: This may add up to two more entries in the memory map (if an > entry is split and its middle part is used; of course with an unusual > implementation there could be even more of a growth). Yet below your > addition, before obtaining the final memory map, you don't re- obtain > (and re-increase) the size needed. As to (re-)increase: In fact, prior > to the allocation you do there shouldn't be a need to bump the space by > 8 extra entries. That's a safety measure only for possible allocations > happening across ExitBootServices(). >=20 > And yes, in earlier versions you had >=20 > - info_size +=3D 8 * efi_mdesc_size; > + info_size +=3D 8 * (efi_mdesc_size + 1); >=20 > there, but that's not what would be needed anyway (if trying to avoid > a 2nd pass of establishing the needed size). Instead in such an event > you need to bump 8 to 10 (or at least 9, when assuming that normally it > wouldn't be the middle part of a new range which would be used, but > rather the leading or trailing one). >=20 > While I'd be okay with addressing the two nits above while committing, > this allocation size aspect first wants settling on. Personally I'd > prefer the more involved solution, but I'd be okay with merely > bumping the 8 (plus the addition of a suitable comment, explaining > the now multiple [two] constituent parts of a seemingly arbitrary > number). If you want to go this easier route, I guess I could also > make that adjustment while committing (and adding my R-b). I would prefer the more involved solution too, but I am not quite sure how to implement it. Should Xen call GetMemoryMap() in a loop, retrying as long as it returns EFI_BUFFER_TOO_SMALL? If I do get EFI_BUFFER_TOO_SMALL, how should I allocate memory for the new buffer? Should I ask ebmalloc() to provide all remaining memory, and then tell it how much was actually used? Once I understand how to allocate the memory for the new memory map, and where to split the long line mentioned above, I will send a v7. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --ys4fH9DfKD++O4Sh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKGWCQACgkQsoi1X/+c IsFhfw/9EDQqHs9BDO/twYIZ7YIHjJP6YIHTahbJ02jBQBSgcPDpCO0JJtzncCDr dKxR2zJUlw6Y5jtBJr6DGWIG1lkb2b9Cc3FlKskoeYDywpjC0OqkR4DiwRh1D+Ix 2vN5/HpJDfdsU76gsa5ixvvV6x/kGOlydzzMlzOfH6ZOxM9TXzMj4Qk92dHN+pSa qzJNAR98Fij9caStfqyULkG6w5jxQ/wT/Bzir8hkzBsC8AEJDH/s7hcjLcLu9ZZL fNQ08xduFkLwe94YJmspPNTgWnCxm3YhF0gGcYT/k/NaacQN99iZwMbDz+cKn0gL sV3xXZoG+WsUHwTeSoVTpdq0XXezP74X2HSmx7h2qWvj0+/9P0hyBsUOSIPgdXDt mf1fiNWRL6e3RpAzVmg0g6ZkCFL7C9WToHhewoxU+wrZjUYUfsjpxEDYkTtoIVpA uTEMph+zPN+Q+2nPpC3khqls/GZxIApdKh/y+yoOHJ5Q3qsb9iSEKAGM0I52LpXD wk5O5bC4pXJpsVMW47cukujlUyyGaDkeSrTIT1qcfcVduvwQNZ9/tYltqoxAx37b JLWaIKhZZ7H2yFfxB48JIYOKN3EAxpnKdCUggIKnggTtNTepWdLeJFipINR4b1fS cgmIdQ3uD4KNSayyFcfvRZkfZaVawXDEbM0YjCwOEXKkQMhkL9E= =ZC0K -----END PGP SIGNATURE----- --ys4fH9DfKD++O4Sh-- From xen-devel-bounces@lists.xenproject.org Thu May 19 14:55:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 14:55:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333084.556863 (Exim 4.92) (envelope-from ) id 1nrhYe-0001SP-BJ; Thu, 19 May 2022 14:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333084.556863; Thu, 19 May 2022 14:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhYe-0001SI-8c; Thu, 19 May 2022 14:55:20 +0000 Received: by outflank-mailman (input) for mailman id 333084; Thu, 19 May 2022 14:55:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhYc-0001SC-Fz for xen-devel@lists.xenproject.org; Thu, 19 May 2022 14:55:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b20d1209-d783-11ec-837e-e5687231ffcc; Thu, 19 May 2022 16:55:17 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-xOugt2u7NICp0fvNlc1SRw-1; Thu, 19 May 2022 16:55:14 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5997.eurprd04.prod.outlook.com (2603:10a6:803:d0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 14:55:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.016; Thu, 19 May 2022 14:55:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b20d1209-d783-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1652972116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=528nIOCAJHjIXQ1X77cUjEYGlCmFSVGpMWemLO9XUbg=; b=AqeVaSTEWbtBmxHAc7XqsepLMPO+16sZSd3LYFfXzrX7+jxqm/OmgvFsYDbhzSMmkSlc1o v4Pcz3pqUwpDO9mkIH0+WhhbEB6S36s+64vqrmJ1pSR2cj4QFBmdzkg53TQFgZT4b7gmv0 DlFbMZCx8JpwKqrvICJ/CDrYPhZ7WsQ= X-MC-Unique: xOugt2u7NICp0fvNlc1SRw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lPP1pNrwIQ2kz7O7Iziq33+HuNlkPi/Aiw2CABNHRkgSQY6YIdW3i1TyU14Vt6ReRPn8HLb8LWs6DnhC56p3WOOFkivjTtcPfg6pKmkpR/NUiz5SYoxi0FmjaqKzBA+GaW3f55QbcY3tvgxl/+/CnUAUn0TI1OYeXAk8HrqClcAdcyh6N7e9SuJcYTYaWuR0pixievcTd1GpzIWEJhZBqIkzp6fpfLG4VrEd6DXzWzn6kmJqIpysEI68KqosAmUr2C00WQAsDkni3YRVILiNinO8E4Bukd1bn/Demm58N4LEMaKOsNwiWhf5TPRCe/IAbcDgLBbxO4bXeHcs1shupg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=528nIOCAJHjIXQ1X77cUjEYGlCmFSVGpMWemLO9XUbg=; b=eJlbXxqevrVDGvswI4Orv5FlmO05y38kFEZ95BVqEGfylrodkykUjwHuAMDeFjZL4RZPyFDQUyXESI+mWtiQ7O3kmOSiz39qNikhrHgW0QfTH0sb5o2lmNtrHfieFcV+WU0jgq0RFVDP06MtPuB2AF2PjFhTPo4bffJypt+RyZdnnRoXzB1wFUd1MHK3+av2SlIQgs9oCsyunUNLRqq4vKa8/8/l01+ASzhTgRx88dVk8oEZXGmud65Ggt6F3urzdhZlJ0Q3WgK3PnfgGwJGL/EH4zi8TQVpDoJNvJKVVf+/AwEmseClxmYByjEtc+49Jq0JxGdqPyiZAIS5vls0Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <05d4fa5b-78d6-96e6-b643-a98d26ec954f@suse.com> Date: Thu, 19 May 2022 16:55:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour Cc: "xen-devel@lists.xenproject.org" References: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0201CA0009.eurprd02.prod.outlook.com (2603:10a6:203:3d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dafa2650-9b18-467a-7487-08da39a793df X-MS-TrafficTypeDiagnostic: VI1PR04MB5997:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dopoXURTIB/jQCUEFIgsGbSvgwCxFUwWjeb1dxu2oGvqAXMRMhByCYwW0qOoE9KC+Ba4HaJIXE01Zj199CdVOuNPHdEgxO6ZVqgGydvENQzCpjTGdq3VA59/fTSnycllmodzLpi8CsZEiJLKQl6ItuOfF+LNZT2Xf6lbubcliAiJE+snqIHDexuMUbusGiN4JH/KwDpYnnJoIDDY00giH+Qrmoyh/WOhOP1+2sjsvnASGJWIIJQJaEyx5vaSKi0xvy8eCj/r7cfh66Fcj4/z7V76n3APw6Zqoje2lS+ifXf/5FC7t3RHixmnEWi20i9JBC0IV3DJGTyQAGwTC7ZpApsgr831SNKUBuYXNulDLeBJirxss24F4vxRySqAHYsXjrjJkQ/78JRMzNGlk57Ed0xAksJHyFHwujkVwynj60WAPLgV6vC3JVElIQ8fQJbLMr8gMl2BbCPWNtdtb/cEXDqwDfjhEftVMN03P38XgEQ0mVArxVrIa/ldRyGehK8sNjt7aj4yuXul0iPVO384eWjTETSIcAV4/7tVcU57WT1CPMCvBSnskL3nqQ5rB/fo8YM7J8sRP6ob+vpI9A0NkWuuj0FadU31+ivX1PgvpC0VoIa5HIn7VyB2uY7h9pdS+qf/T+EiVSo2TtHm3O+Cr+Ajap9TpZXBQxjRbplkN4BBajyTc676eA3xDQVs5y2EL97psRSTNCmQbB2QfXdJCZL+rqcvnHWmgAcqwT4GIxgHi8okowB5wVcGkE6eZqm1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(5660300002)(83380400001)(86362001)(6486002)(31696002)(6512007)(26005)(6506007)(508600001)(53546011)(2906002)(6916009)(2616005)(186003)(66556008)(66476007)(66946007)(316002)(8676002)(4326008)(31686004)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0w0UHJoM3FlcVd0RkxCYy9VTXAzOWNGcjhQR0hIZkdBRVl1c1Y4WVRMY0lE?= =?utf-8?B?bllFVDlFTFFzZEEwWmVkSmJvZU5HbmFzYmlsNWxNTm9namJTaGJFOTEzTFdC?= =?utf-8?B?U1gwbVgzNy96alV4VjUrcWtaZ2hPeEl4R0lxb0RMblZTMnNmaG5icEVxZ2lX?= =?utf-8?B?Y1NFM0FyeTVBSDd6bG1qZ1dKUzhneHVWcWI2Njh2aUI5MW12VWEzeFBwQk5y?= =?utf-8?B?dE4yVTZZNXA5ck5EaTNXRWpPMTJVTFF6QzBobTA2Q05ValI2ZndlVkNzK3NG?= =?utf-8?B?S3ZHd1lYdk9MeWpxbFpaaFJwOExSWmZqMEpnN2pOQUhxb2lsR3FPOVByeFpP?= =?utf-8?B?T1gzNGtMandKVGdRWDdHeDJFSTdVZjc0WUY2bm1MSDUzN3NZaDIzVnpHMWht?= =?utf-8?B?enQyQ05TQ3QwU2F0ZGR3NVA2TVM3a0ZGQ2FJcEZXUFJsbVpMbEtOcFlNOWdr?= =?utf-8?B?OUpzT1ZlZUVKa1pvbG1LeWRxUFNlSXpLRUtoMzE0Y1FQbFdDSzliQ21xTkcr?= =?utf-8?B?alU0YVJMcGQ5NVJUYklOOWhHOExPMHJDLzIvVFI3SmpIM2VFVHRrWFdBVDhx?= =?utf-8?B?SGowQjNDaGlGUHpnekVzMnpvanV4cDNvQVJhVWJRajFTbHJ0UU5xbzNhbDJk?= =?utf-8?B?cktzcmVZS2wyZFcwVUwwQlc4blFjRzh5aDErSjN0VVJoaDVadlRKVHR5N2xx?= =?utf-8?B?V2tCOGJzelpQem40am1lajV6THFRYUM3c2Nsa0hSYzNYNVdSZkc5ZmpDb0xH?= =?utf-8?B?V1lMLzNMam1weUlQczZoK21JNTRZM1lmU1BKMlhVSG1LK0lVQit3N2ZzckNk?= =?utf-8?B?UUJYUy9ZaW9hai9jbmJXRy9paThSdCszWStKbmdONFZWRHY3cGl2MHZuSUhy?= =?utf-8?B?eDhCZE1mWS9qZVd0em1jN3ltREJTTzNiME0rQUJXZVN0YnNWbTJIRlhtemxR?= =?utf-8?B?cTloTGlUUzNKdEpDYXo3eTE1QWlrbXJXcklEQkN0b0hmSk1JSGxQMnZlYysy?= =?utf-8?B?eGdoSTRJUmRwcnNQSGcwSXk4R2MwTUpkNGJPNHFERGx6L09vZW5kNW1JL0Zv?= =?utf-8?B?WEROcC9INXFnb1dVelZNUUhxdzFNcDJ0NjlxMjVsZFJDMlhzd0hqU2Z4Q1Zw?= =?utf-8?B?Qm1ZYnIxTlF2aTFLd3JxVGdlQjd1OG4zb005eUNQZk5YSDRsdG1nMzJHNUo1?= =?utf-8?B?dHFGTVdtZjdDaGJZWG0yOXJacUMreVNJTEQxaDAzUVI0ZEUweXhaS2N1N3k3?= =?utf-8?B?aEoyS2FUeVRmMW9hZHEwdkhFdE9IVEh6ZmUyYStSdWttcVJtZXRISXFibld4?= =?utf-8?B?ZDR5aVpaMFlINDlnM2I1a2ZDcWtVaEpZT3N0NUdORFZxZTEzYjhPdi9LNVVs?= =?utf-8?B?YU8zUTlsTXpKa05yWTQ2SDBuRGNJY0pXWitSa0pLdXcvWDlBem1COUZvMnYr?= =?utf-8?B?OEtxZUk1QkptYis4REVuanFSdGhQOVZwU0dlQnFvTzdSSUF4bGRTdllzN01T?= =?utf-8?B?VmU5R2hsb2x0Y0lnMUdBTmhIekx6Q01PcjA0SEQ0cC9ETFQvZm9OTnpVRjdm?= =?utf-8?B?YVAzMTJUL25zdFVVOGlTcmg1YnNCUDJEeUNSK202NzdPd21YdXlEUkN3SXlU?= =?utf-8?B?Wjg4R2gzS0FnaWN1dHBUNndOdU9hUjBiZWhyNXYxVCtVWE1MSCtKWTVPcFo4?= =?utf-8?B?ZnhNNEwrZDI4UTQvTnBXdEJ3TEtZSnBPcnBwMDZaT1Y1U3BMNWFXWTFGTjhZ?= =?utf-8?B?Q1V4R2xQN2F4b3pGc2xTUkxPeitYNC81RUpycGhYcHY2THQ0eDZHTE9EcGND?= =?utf-8?B?Q2ZEeW13ZHcwWmx5cHkrZHpEalNZcU1xVjB5SVg4QjlOUkF1NGh3Tm5xWUpG?= =?utf-8?B?SXg0NjhmbXBscU83TFlFNDFJOEZKNHFpZTVtRjlrbnpKSmlYT1Bmd2FjT3Nm?= =?utf-8?B?NWc0MjVnM2dnNWJqU3NoQnh0cVhKUGo2L1RCYk1hVVZEODlwdUdKSG8wOFZJ?= =?utf-8?B?MFFsVGFNQzZFVXRiRWcwL0tXVUpCUGJGcDRqWm9tZkNGNmQ1N3pMZkV6OHd3?= =?utf-8?B?QnlqUGVCVnhPTStDM2dDWlZzRVkvU1VSSU5mZEg3ckVTcXVSaXpDSkErTHNY?= =?utf-8?B?K3ZhdHdLWDZGSmlWZDNZcnpIaHgwSmFUYkRRaVdPZTlnOUNBZHB4c3puS0ho?= =?utf-8?B?R0N6cXhNWDAycTlseWh2MnBWNHd6dnd5cTd5L2xTNGtXT1ZtYkhQQlArUUZJ?= =?utf-8?B?WXdmSVpCUFhSNU50MHhNQTFHL3pqdjhrc2Z6NC9KMFpUWTVBbkIydmpzN1RX?= =?utf-8?B?SVRVaU5WNURDelFjU1I0RTM5eEhjcDZzVjZ1R2daVUU1Ny9TU0IxQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dafa2650-9b18-467a-7487-08da39a793df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 14:55:13.0813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nMg65Jzj56Q+8kPeBGtamwajg6MaaQt8XtHZvl9ji8VPgBnAAGI64z3Py9DUwsD8ByqbfLAbd+GGnPzuh0pAJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5997 On 19.05.2022 16:45, Demi Marie Obenour wrote: > On Thu, May 19, 2022 at 12:32:33PM +0200, Jan Beulich wrote: >> On 18.05.2022 19:32, Demi Marie Obenour wrote: >>> + /* >>> + * The specification requires EfiBootServicesData, but accept >>> + * EfiRuntimeServicesData, which is a more logical choice. >>> + */ >>> + if ( (desc->Type != EfiRuntimeServicesData) && >>> + (desc->Type != EfiBootServicesData) ) >>> + return 0; >>> + available_len = len - (esrt - physical_start); >>> + if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) >>> + return 0; >>> + available_len -= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); >>> + esrt_ptr = (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; >>> + if ( esrt_ptr->FwResourceVersion != EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION || >> >> Nit (style): Overlong line. > > Where is the best place to split this? > EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION is a rather long > identifier. There's no good place to split; the only possible (imo) place is after the != . >>> @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste >>> if ( !efi_memmap ) >>> blexit(L"Unable to allocate memory for EFI memory map"); >>> >>> + efi_memmap_size = info_size; >> >> I don't think this global needs setting here, yet? The local will >> do just fine here, likely yielding smaller code. But I realize that's >> connected to how you did your change vs what I was expecting you to >> do (see below). >> >>> + status = SystemTable->BootServices->GetMemoryMap(&efi_memmap_size, >>> + efi_memmap, &map_key, >>> + &efi_mdesc_size, >>> + &mdesc_ver); >>> + if ( EFI_ERROR(status) ) >>> + PrintErrMesg(L"Cannot obtain memory map", status); >>> + >>> + /* Try to obtain the ESRT. Errors are not fatal. */ >>> + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) >>> + { >>> + /* >>> + * ESRT needs to be moved to memory of type EfiRuntimeServicesData >>> + * so that the memory it is in will not be used for other purposes. >>> + */ >>> + void *new_esrt = NULL; >>> + size_t esrt_size = get_esrt_size(efi_memmap + i); >>> + >>> + if ( !esrt_size ) >>> + continue; >>> + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type == >>> + EfiRuntimeServicesData ) >>> + break; /* ESRT already safe from reuse */ >>> + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, >>> + &new_esrt); >> >> I should have re-raised the earlier voiced concern when reviewing v5 (or >> maybe already v4), and I'm sorry for not having paid close enough >> attention: This may add up to two more entries in the memory map (if an >> entry is split and its middle part is used; of course with an unusual >> implementation there could be even more of a growth). Yet below your >> addition, before obtaining the final memory map, you don't re- obtain >> (and re-increase) the size needed. As to (re-)increase: In fact, prior >> to the allocation you do there shouldn't be a need to bump the space by >> 8 extra entries. That's a safety measure only for possible allocations >> happening across ExitBootServices(). >> >> And yes, in earlier versions you had >> >> - info_size += 8 * efi_mdesc_size; >> + info_size += 8 * (efi_mdesc_size + 1); >> >> there, but that's not what would be needed anyway (if trying to avoid >> a 2nd pass of establishing the needed size). Instead in such an event >> you need to bump 8 to 10 (or at least 9, when assuming that normally it >> wouldn't be the middle part of a new range which would be used, but >> rather the leading or trailing one). >> >> While I'd be okay with addressing the two nits above while committing, >> this allocation size aspect first wants settling on. Personally I'd >> prefer the more involved solution, but I'd be okay with merely >> bumping the 8 (plus the addition of a suitable comment, explaining >> the now multiple [two] constituent parts of a seemingly arbitrary >> number). If you want to go this easier route, I guess I could also >> make that adjustment while committing (and adding my R-b). > > I would prefer the more involved solution too, but I am not quite sure > how to implement it. Should Xen call GetMemoryMap() in a loop, retrying > as long as it returns EFI_BUFFER_TOO_SMALL? If I do get > EFI_BUFFER_TOO_SMALL, how should I allocate memory for the new buffer? > Should I ask ebmalloc() to provide all remaining memory, and then tell > it how much was actually used? Well, there are certainly multiple options. I was thinking that you'd add a new call to size the memory map, add a few (again 8?) extra entries there as well for the allocation, and leave the present sizing call effectively alone (and sitting after all of your additions). Jan From xen-devel-bounces@lists.xenproject.org Thu May 19 15:04:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 15:04:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333092.556875 (Exim 4.92) (envelope-from ) id 1nrhh6-0002wP-7k; Thu, 19 May 2022 15:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333092.556875; Thu, 19 May 2022 15:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhh6-0002wI-3v; Thu, 19 May 2022 15:04:04 +0000 Received: by outflank-mailman (input) for mailman id 333092; Thu, 19 May 2022 15:04:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhh5-0002wC-Cl for xen-devel@lists.xenproject.org; Thu, 19 May 2022 15:04:03 +0000 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8eeaa2c-d784-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 17:04:00 +0200 (CEST) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 08:03:57 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 19 May 2022 08:03:57 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 08:03:57 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 08:03:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 08:03:56 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 08:03:56 -0700 Received: from CY4PR11MB0056.namprd11.prod.outlook.com (2603:10b6:910:7c::30) by CO1PR11MB4836.namprd11.prod.outlook.com (2603:10b6:303:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 15:03:54 +0000 Received: from CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f]) by CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f%7]) with mapi id 15.20.5250.018; Thu, 19 May 2022 15:03:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8eeaa2c-d784-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652972640; x=1684508640; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dy47+LCe1rnw9Uz4ogMSHAsTEseQzSt/iaei8La9KAg=; b=gdWAGZFAphQOOpwcPVJFcoH2L1wt8h1fviL+aqaccyzS9oaZSiYcsMRF IBJIuwRKMl47KelfDlOim0gnGhH2povYTkdIxQIXV8jCW7sifEWYU0+dp xGY133hQV4kTBq4zr0NNOICy4r9tQ8pmJQLVADicLPwNuis3dOTBTWPcf ZmJrSG8HpdBQr+hRNUKiiSDk8dIIYf3S7Qaxh5fwwhGo/s7Fc5TxKWJSD tb8ufxgmxBj9kqLOU4Wi2giYh3Q3yFdYOqe/RaWN063IuezGTi8empRxP rSmyhTcjzkakcoRYmfSi/Lof1V6XBnjP5Mihgs7N0xb2rpFLpogQsyyf7 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="259813643" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="259813643" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="598614765" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxoQ7KNEiNwj/KOcMCqfn29fgsmy8qL3vMZiLTPC2z/2LJ1zU+V682gyQdhqVcRdpDjr/hUarKAien1/u3JIkZPX6ez2qtTj+xVw1V1bLn1pFeVNdquaSFql8C0wCZiCCpYiP9MornTnNm18IK6E4MdAI8btHMYiIxukTPJy5C+EKaA+p6H7yYGYFJcNVhCsPBseSkEk4F6xwUGeVMIPqAqj2CWvC8ibwFbVqjqGePk03+xtHv0Xg+2aISemj5kbXeG0nuHFOnLiyBwrP0afHE0dUXCswDYbaWkTnn9/66yQ6qigcHPQuxIMsYpOPNTdlhi8DpzbBpYvNOq/HOz34A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dy47+LCe1rnw9Uz4ogMSHAsTEseQzSt/iaei8La9KAg=; b=T94ZTM2s2e9iawjsS2B9prLk8ANTkBpRz85mvRPo6q1IIyHYXkqyCsjucNpifLM514xkkh1IaBQZ3HuaVLk6ngEmJ8/WSDEzNJkvA5VyUzz8el8f3QQ18pLldQccec6VFFtI+1dxFrphA3T4Ohwp1mAzF98CqTEtkQmlqgHetS/gsvInsK5fCdBv4F6Ev/zPAnN1haO/FyUeu4t/tx5b5lIIx93Qfni9RypADfkJzG8l01ztqjo9cI7KhtA+vOT5l99nQ+SfaGxX4C2UqaNSqrC5gAiP4d5k8rGfn5HLZpN19/IJikCS5UBznhR9kt2ecoB6jkTGxSxdxzNgCMK5Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Lengyel, Tamas" To: "Gross, Jurgen" , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD , "Cooper, Andrew" Subject: RE: [PATCH] tools/libs/ctrl: add and export xc_memory_op Thread-Topic: [PATCH] tools/libs/ctrl: add and export xc_memory_op Thread-Index: AQHYa4RIF+g6mxBRRU+cd4s+ndSX+a0mMskAgAAGnRCAAAm+AIAACMUQ Date: Thu, 19 May 2022 15:03:54 +0000 Message-ID: References: <5c72f793978997970888254a9050e97b34cbb3c7.1652966447.git.tamas.lengyel@intel.com> <9b3c46f8-737b-b145-4abf-a08b34d4e932@suse.com> <403a66db-143a-7d05-1d0f-5a7d30721e34@suse.com> In-Reply-To: <403a66db-143a-7d05-1d0f-5a7d30721e34@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b75e142-636a-4d12-1e67-08da39a8cae5 x-ms-traffictypediagnostic: CO1PR11MB4836:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +d10NtUw438Ryvtxp5pzhq5jJB6igGd5BgxqyqGy318cUvcqoooM9aeXUjIp7qCjJfvKzP/zO3pmADS7Fu3+jrXophA9po8GgQVaG9zDzW6RZIcgGCfM2yeETdkeZgwah8+FomgZvnrf/kH6xv1opyPVlXgyRwJF6VWRYbXQwh2shytzT8fLMzF4OYxJc/kLeuYx5UIa776rZBd8HIxCdBPAs8nTSFWvlyH1uU3kPF6W/63fUqx53yJ6df0dfnFjgwr/Xu+GSaelKBIsM+ZnOl9/ys6I2XBuSxq+luJXNDh6KXMkcjS+t4cfd/E8oqoPioIwkwh1yIESjhpwLEd57SZh3EZagLJn7WMH7VJG7fKHmZm9+nfv29Sk1emtP4r3QYN6euuCqd4DrflDh7ru8HATzueEPfSAxLBo1PdL01LvE+x6ZKXhNT8LIpXtTdhuOMMXSK4I71lhdBjKbMzfapT10wAaRrOg3OgjmqC4YL1X/5P4OEKoscAjDVRQz+gBx8zOzFJyw5wEV+c9/0gyVfpi2EGj+uyFtKj49Nou4yFulu4aWCZftQ1/tpZWEySK3T1gWeYD04zeYgWH05CczYgGogc54gox0rKKj9yt//ond8f7rYvC+0kSYYHNULqGb5mVNuTiBf8UA9EGmWpmZLd0Ho/rE1X7iUExpEIpGnG362s2qjTiOM5wPOLq4mzgRZOLnKXGcprIzvvohJbUfg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB0056.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(86362001)(8936002)(5660300002)(54906003)(66556008)(55016003)(66446008)(76116006)(66946007)(52536014)(110136005)(186003)(4326008)(508600001)(64756008)(33656002)(66476007)(316002)(53546011)(38100700002)(38070700005)(122000001)(8676002)(2906002)(7696005)(82960400001)(71200400001)(6506007)(26005)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OXlwSHExVlNiTXN5SXlnTElhY3dueVBieW0ra29KbkVUaFF6WlE5TEpVMFlm?= =?utf-8?B?aUd1RjRHREJ4anYvZ242TmRlYmJSK1BqZlBabWw0Y2w1NGV4SS8xR0lERlRJ?= =?utf-8?B?cXdZUWR2ZWw5SmRKU2s0SDlQdVIyZnFxdkUwa0ZIWW0rSzNpR05abDlvZTF0?= =?utf-8?B?SmJnZjhVYitGK0xiVmh2MjRsQVE3TFlwV2pSSlZHSk1Sc2l6QlJ5MEFrS0k4?= =?utf-8?B?UTBDZzVkblVZOTdDeS9Jai9yNWI1a1l5bWlGUWExSTI2cFV3WHlJcWplcHk1?= =?utf-8?B?WmNDb3d2NG8zMHdjOW9wQktEYnlzOEJ0MEd5djJMM3owTnBqUG95cVdjV2dK?= =?utf-8?B?SE1peC9OZ0paNTU4Z2xOb1dweDc4MUhEVDlxUXBXQWdKMVFCY2tkanRpNUt2?= =?utf-8?B?SVRDa3VEVFNvRzJZUlM0NUR0anZkeTY5dFYxUi9rc0JmclVaR0tJYUJFVVpv?= =?utf-8?B?WGE1K3F4M2dPZDBManV0alR3cm9yMm1tUXNCWlFPRDVBWlhyK2swUEtRcnpj?= =?utf-8?B?NWZHSEFGL0l0c2JZNW52VFZPRTRXUDdqcVUwV1ZOQUVmYmZSSHFZbng3bmFR?= =?utf-8?B?MnJzUVZ2UGlvWTl5UE1SN1ZuQ0hKLzBhb29XMnRZL2RIOFYza2dxWkFWOXB2?= =?utf-8?B?UytnZWxjVHc2Yjl5NXBJZnAyR0dyRllDREcraFZQdDZqWWJ0ZTZlcit2N0gw?= =?utf-8?B?YmFSSUt6S0I4aUdkeEU3SnZKNExkdUtpWUgxL0lPUnBac0hjTlVYSUR2TGhu?= =?utf-8?B?aGljYlJ0b09RN0huM2FpRzNyWWdyYm1QTzZaekFTYnRnZ1J3T0xPR09WMXpR?= =?utf-8?B?amlUTC96dW5KU3UwWmJZK285cFVNMXlWem9pYnluTmZub0h6clBNZDFLbUtZ?= =?utf-8?B?bG10bDhiMTNKVTFUanVuenJLcWRXdUp0TjBva1FRNUc4UVd6NHNZTURLRjEw?= =?utf-8?B?OFdMQThwTUxjM0JlcnE3WmthU1VDL3JhVWw0bHVXYnlxVEw2OTZsbllaazNi?= =?utf-8?B?QnBYaVNlRVllVlZ0WnU0KzRlOTBuYWdlcnFyQ3JQWk4ybHdDSDJWSVhodVRa?= =?utf-8?B?N2NKbW83Z0luZU9XdkxlUlhSNWxablVpNnMrOHhBTUxIdEMzdFdRVS9mZGZq?= =?utf-8?B?U0RBTGthY2MyVkJFdlNBTXl5dnFKaW1Rd3hSZTlBTGxYdGVpWXd6a0xSRExG?= =?utf-8?B?Qi9jV2RkOVg2bTE4SVlFbndJaTZjMllKQ054ZlpINjhDcVFrY28zVmhWV2Z0?= =?utf-8?B?aDdBTVZvb091aGp4ZCtpT3d1Z3BHbzJnaXZtKytWKzBqYzdRd3g3SlIvdjR0?= =?utf-8?B?MXl4bVRoNlZjVHBMQ0I5SHJHWU1pSEhqZTd4S3M1OHBmeGY0RnVSZ2YzZitF?= =?utf-8?B?NDJSenBXK1EwZjZ2SzJrRW9ieFpoUFRZdUlxNmdCOFVnWHM0RG9FNkQ2Nkw3?= =?utf-8?B?MmorNnJSYlNWeDJaKy9rck9EL2tHQ2VwM3ZXNzcrOXBGU3JUM092VWMwR2JB?= =?utf-8?B?VzZtWGRRZjRqaEUzN2d3VlE4SkgvcGFmWFo1b2RwU2VNc3AvYndjS0QxTVlV?= =?utf-8?B?SUZreHdyalRmL202andYV3dVRm1nSU9oU0RTNGlvOWF5TWxtZHZXNkJOQXBj?= =?utf-8?B?ZHFwNFllOHNiWjhZcyswUVpzRCsxZnMyNWhBeGx3bjEzWGVVREdyWENLVm5h?= =?utf-8?B?SkZ3bkw5a0FsRmg0ajNaajY1WEdlSmIyeG8vVEZSUTRscmRzSnl3czNIVk43?= =?utf-8?B?VVhINjJvMm9keXNPTVBnYW9wSkk3b291emRlRXV0UkRLcnJpc0RyN0YwU0RI?= =?utf-8?B?ZmVnRHFBWTk5MURSNnN3cVFEaVZBU0NvRUFldHUydWtKZExJeExYNXNZdnRR?= =?utf-8?B?d25EWjBMc3Y2aHVUYjRSWWNpcndJMHpIMTh6VzBpMllhaWIwOW10YkVybmlZ?= =?utf-8?B?am52UTlhNkNocVQ0Rm9hcE4rdUNvdmJsSS9IK2dlTCtkYmY1eWpTWk9NTjYv?= =?utf-8?B?c2NnQi9abVNmWlFuYkxoTmVHci9RQ3VhWGV6dDBPb0RpV1JERkhsNWxvNS8y?= =?utf-8?B?M3Z1YWpDc0NucnFvMTFJV1Y1VytvSVZoTXc4WUZvQ1Z2enVJUlJ2UkdnNXlR?= =?utf-8?B?OVFhUDA4dVY2K25QZVdPQmtQaDR3OWVGVERJZlArakJFdnhyekxyZDVOUTlI?= =?utf-8?B?c256MlU2cFJqdFIyenlCQ2oybUgyRmRZOHEvKzZhQ1ZUOXc3WGRqdkNQRWVl?= =?utf-8?B?ZmN0YzV4VzcvdDVEckVtZ004L3I2Wko3QjJ5YUtVaXBSeW1hTHYxWXZXSUtO?= =?utf-8?B?NldIUExVNXhUdW9jaUEzWXVyT2QrVm1NcWFKZElzVzZqUXNMQkhMZz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB0056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b75e142-636a-4d12-1e67-08da39a8cae5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 15:03:54.7179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GTKKzZc5oI7RlA3EDulVkBviSvD8BNiyKSOYeCoKXFMv+Q4+VHz62t1i1dkKZfkNIZik0p34Wvh2ZcyqymJe6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4836 X-OriginatorOrg: intel.com DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDE5LCAyMDIyIDEwOjMxIEFN DQo+IFRvOiBMZW5neWVsLCBUYW1hcyA8dGFtYXMubGVuZ3llbEBpbnRlbC5jb20+OyB4ZW4tDQo+ IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsg QW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Ow0KPiBDb29wZXIsIEFu ZHJldyA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0g dG9vbHMvbGlicy9jdHJsOiBhZGQgYW5kIGV4cG9ydCB4Y19tZW1vcnlfb3ANCj4gDQo+IE9uIDE5 LjA1LjIyIDE1OjU5LCBMZW5neWVsLCBUYW1hcyB3cm90ZToNCj4gPg0KPiA+DQo+ID4+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJv dW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZg0KPiA+PiBKdWVyZ2VuIEdy b3NzDQo+ID4+IFNlbnQ6IFRodXJzZGF5LCBNYXkgMTksIDIwMjIgOTozMyBBTQ0KPiA+PiBUbzog TGVuZ3llbCwgVGFtYXMgPHRhbWFzLmxlbmd5ZWxAaW50ZWwuY29tPjsNCj4gPj4geGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4+IENjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgQW50 aG9ueSBQRVJBUkQNCj4gPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Ow0KPiA+PiBDb29wZXIs IEFuZHJldyA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gPj4gU3ViamVjdDogUmU6IFtQ QVRDSF0gdG9vbHMvbGlicy9jdHJsOiBhZGQgYW5kIGV4cG9ydCB4Y19tZW1vcnlfb3ANCj4gPj4N Cj4gPj4gT24gMTkuMDUuMjIgMTU6MjcsIFRhbWFzIEsgTGVuZ3llbCB3cm90ZToNCj4gPj4+IEFk ZCBhbmQgZXhwb3J0IHhjX21lbW9yeV9vcCBzbyB0aGF0IGRvX21lbW9yeV9vcCBjYW4gYmUgdXNl ZCBieQ0KPiA+Pj4gdG9vbHMgbGlua2luZyB3aXRoIGxpYnhjLiBUaGlzIGlzIGVmZmVjdGl2ZWx5 IGluIHRoZSBzYW1lIHNwaXJpdCBhcw0KPiA+Pj4gdGhlIGV4aXN0aW5nIHhjX2RvbWN0bCBhbmQg eGNfc3lzY3RsIGZ1bmN0aW9ucywgd2hpY2ggYXJlIGFscmVhZHkNCj4gZXhwb3J0ZWQuDQo+ID4+ Pg0KPiA+Pj4gSW4gdGhpcyBwYXRjaCB3ZSBtb3ZlIGRvX21lbW9yeV9vcCBpbnRvIHhjX3ByaXZh dGUuaCBhcyBhIHN0YXRpYw0KPiA+Pj4gaW5saW5lIGZ1bmN0aW9uIGFuZCBjb252ZXJ0IGl0cyAn Y21kJyBpbnB1dCBmcm9tIGludCB0byB1bnNpZ25lZCBpbnQNCj4gPj4+IHRvIGFjY3VyYXRlbHkg cmVmbGVjdCB3aGF0IHRoZSBoeXBlcnZpc29yIGV4cGVjdHMuIE5vIG90aGVyIGNoYW5nZXMNCj4g Pj4+IGFyZSBtYWRlDQo+ID4+IHRvIHRoZSBmdW5jdGlvbi4NCj4gPj4+DQo+ID4+PiBTaWduZWQt b2ZmLWJ5OiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzLmxlbmd5ZWxAaW50ZWwuY29tPg0KPiA+Pj4g LS0tDQo+ID4+PiAgICB0b29scy9pbmNsdWRlL3hlbmN0cmwuaCAgICAgIHwgIDEgKw0KPiA+Pj4g ICAgdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuYyB8IDYzICsrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQ0KPiA+Pj4gICAgdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUuaCB8 IDU4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiA+Pj4gICAgMyBmaWxlcyBj aGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkNCj4gPj4+DQo+ID4+PiBk aWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS94ZW5jdHJsLmggYi90b29scy9pbmNsdWRlL3hlbmN0 cmwuaCBpbmRleA0KPiA+Pj4gOTViZDVlY2E2Ny4uNDg0ZTM1NDQxMiAxMDA2NDQNCj4gPj4+IC0t LSBhL3Rvb2xzL2luY2x1ZGUveGVuY3RybC5oDQo+ID4+PiArKysgYi90b29scy9pbmNsdWRlL3hl bmN0cmwuaA0KPiA+Pj4gQEAgLTE1OTcsNiArMTU5Nyw3IEBAIGludCB4Y192bXRyYWNlX3NldF9v cHRpb24oeGNfaW50ZXJmYWNlICp4Y2gsDQo+ID4+PiB1aW50MzJfdCBkb21pZCwNCj4gPj4+DQo+ ID4+PiAgICBpbnQgeGNfZG9tY3RsKHhjX2ludGVyZmFjZSAqeGNoLCBzdHJ1Y3QgeGVuX2RvbWN0 bCAqZG9tY3RsKTsNCj4gPj4+ICAgIGludCB4Y19zeXNjdGwoeGNfaW50ZXJmYWNlICp4Y2gsIHN0 cnVjdCB4ZW5fc3lzY3RsICpzeXNjdGwpOw0KPiA+Pj4gK2xvbmcgeGNfbWVtb3J5X29wKHhjX2lu dGVyZmFjZSAqeGNoLCB1bnNpZ25lZCBpbnQgY21kLCB2b2lkICphcmcsDQo+ID4+PiArc2l6ZV90 IGxlbik7DQo+ID4+Pg0KPiA+Pj4gICAgaW50IHhjX3ZlcnNpb24oeGNfaW50ZXJmYWNlICp4Y2gs IGludCBjbWQsIHZvaWQgKmFyZyk7DQo+ID4+Pg0KPiA+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xp YnMvY3RybC94Y19wcml2YXRlLmMNCj4gPj4+IGIvdG9vbHMvbGlicy9jdHJsL3hjX3ByaXZhdGUu YyBpbmRleCBjMDQyMjY2MmYwLi42YTI0N2QyYjFmIDEwMDY0NA0KPiA+Pj4gLS0tIGEvdG9vbHMv bGlicy9jdHJsL3hjX3ByaXZhdGUuYw0KPiA+Pj4gKysrIGIvdG9vbHMvbGlicy9jdHJsL3hjX3By aXZhdGUuYw0KPiA+Pj4gQEAgLTMyNiw2NCArMzI2LDYgQEAgaW50IHhjX2ZsdXNoX21tdV91cGRh dGVzKHhjX2ludGVyZmFjZSAqeGNoLA0KPiA+Pj4gc3RydWN0DQo+ID4+IHhjX21tdSAqbW11KQ0K PiA+Pj4gICAgICAgIHJldHVybiBmbHVzaF9tbXVfdXBkYXRlcyh4Y2gsIG1tdSk7DQo+ID4+PiAg ICB9DQo+ID4+Pg0KPiA+Pj4gLWxvbmcgZG9fbWVtb3J5X29wKHhjX2ludGVyZmFjZSAqeGNoLCBp bnQgY21kLCB2b2lkICphcmcsIHNpemVfdA0KPiA+Pj4gbGVuKQ0KPiA+Pg0KPiA+PiBXaHkgZG9u J3QgeW91IGp1c3QgcmVuYW1lIHRoaXMgZnVuY3Rpb24gYW5kIG1vZGlmeSB0aGUgdXNlcnMgdG8g dXNlDQo+ID4+IHRoZSBuZXcgbmFtZT8NCj4gPg0KPiA+IEZvciB0d28gcmVhc29uczoNCj4gPiAx KSBoYXZpbmcgdGhlIGRvX21lbW9yeV9vcCBhcyBhIHN0YXRpYyBpbmxpbmUgaXMgY29uc2lzdGVu dCB3aXRoIGhvdw0KPiBkb19kb21jdGwgYW5kIGRvX3N5c2N0bCBhcmUgaW1wbGVtZW50ZWQsIHNv IGxvZ2ljYWxseSB0aGF0J3Mgd2hhdCBJIHdvdWxkDQo+IGV4cGVjdCB0byBzZWUgZm9yIHRoZSBt ZW1vcnlfb3AgaHlwZXJjYWxsIGFzIHdlbGwuDQo+IA0KPiBJdCBpcyBtdWNoIG1vcmUgY29tcGxp Y2F0ZWQgdGhhbiB0aGUgZG9fZG9tY3RsIGFuZCBkb19zeXNjdGwgaW5saW5lcy4NCj4gDQo+IEFk ZGl0aW9uYWxseSBpdCBpcyBiZWluZyB1c2VkIGJ5IGxpYnhlbmd1ZXN0LCBzbyBtYWtpbmcgaXQg YW4gaW5saW5lIHdvdWxkDQo+IGV4cG9zZSBsb3RzIG9mIGxpYnhlbmN0cmwgaW50ZXJuYWxzIHRv IGxpYnhlbmd1ZXN0Lg0KPiANCj4gPiAyKSB0aGUgcGF0Y2ggaXRzZWxmIGlzIGNsZWFuZXIgYmVj YXVzZSB0aGVyZSBpcyBubyBjaHVybiBpbiBhbGwgdGhlIGZpbGVzIHRoYXQNCj4gcHJldmlvdXNs eSBjYWxsZWQgZG9fbWVtb3J5X29wLg0KPiANCj4gT1RPSCBhbGwgY2FsbGVycyBhcmUgaW4gWGVu LCBzbyBpdHMgbm8gZGVhbCB0byBjaGFuZ2UgdGhvc2UuDQoNCkknbSBmaW5lIHdpdGggZ29pbmcg dGhlIHB1cmUgcmVuYW1lIHJvdXRlICBpZiB0aGF0J3Mgd2hhdCdzIHByZWZlcnJlZC4NCg0KVGFt YXMNCg== From xen-devel-bounces@lists.xenproject.org Thu May 19 15:07:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 15:07:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333101.556886 (Exim 4.92) (envelope-from ) id 1nrhkG-0003ad-Tf; Thu, 19 May 2022 15:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333101.556886; Thu, 19 May 2022 15:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhkG-0003aW-Qb; Thu, 19 May 2022 15:07:20 +0000 Received: by outflank-mailman (input) for mailman id 333101; Thu, 19 May 2022 15:07:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhkF-0003aP-Ju for xen-devel@lists.xenproject.org; Thu, 19 May 2022 15:07:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5fb4702f-d785-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 17:07:18 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9A7871FD38; Thu, 19 May 2022 15:07:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D534113AF8; Thu, 19 May 2022 15:07:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XYt5MSRdhmJpWAAAMHmgww (envelope-from ); Thu, 19 May 2022 15:07:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fb4702f-d785-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1652972837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IWH8FsPC8/ygpHOHonzeBfxn5Hz3dIsT3esa4BuohSw=; b=L1wnzQCN98EtULwo7rWgMsVWrGpIqw1OEFykq7S4VaSrHUN417Nvy+MuyV0bJroSRmzy3M 5xSbrtjNYJSnHWF9siwjJsICkEhIPlFD71CmIA3krAFrlir2Ib9wQP1D9MNLN+WE8+GBNw z1SnCL+8POea8sqpsg/MK603z03iuNU= Message-ID: Date: Thu, 19 May 2022 17:07:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access() Content-Language: en-US To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-3-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220504155703.13336-3-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------X2JEafOWLT00pgbXX5l1hgWW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------X2JEafOWLT00pgbXX5l1hgWW Content-Type: multipart/mixed; boundary="------------1I1ZTSyF7lu6th38xRuLvtF5"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Message-ID: Subject: Re: [PATCH v3 2/2] virtio: replace arch_has_restricted_virtio_memory_access() References: <20220504155703.13336-1-jgross@suse.com> <20220504155703.13336-3-jgross@suse.com> In-Reply-To: <20220504155703.13336-3-jgross@suse.com> --------------1I1ZTSyF7lu6th38xRuLvtF5 Content-Type: multipart/mixed; boundary="------------q0Ma1pV467Hqz8bFVYRGEh6g" --------------q0Ma1pV467Hqz8bFVYRGEh6g Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDUuMjIgMTc6NTcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEluc3RlYWQgb2Yg dXNpbmcgYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2VzcygpIHRvZ2V0 aGVyDQo+IHdpdGggQ09ORklHX0FSQ0hfSEFTX1JFU1RSSUNURURfVklSVElPX01FTU9SWV9B Q0NFU1MsIHJlcGxhY2UgdGhvc2UNCj4gd2l0aCBwbGF0Zm9ybV9oYXMoKSBhbmQgYSBuZXcg cGxhdGZvcm0gZmVhdHVyZQ0KPiBQTEFURk9STV9WSVJUSU9fUkVTVFJJQ1RFRF9NRU1fQUND RVNTLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPg0KDQpDb3VsZCBJIGdldCBzb21lIGZlZWRiYWNrIGZyb20gdGhlIHMzOTAgc2lkZSwg cGxlYXNlPw0KDQoNCkp1ZXJnZW4NCg0KPiAtLS0NCj4gVjI6DQo+IC0gbW92ZSBzZXR0aW5n IG9mIFBMQVRGT1JNX1ZJUlRJT19SRVNUUklDVEVEX01FTV9BQ0NFU1MgaW4gU0VWIGNhc2UN Cj4gICAgdG8gc2V2X3NldHVwX2FyY2goKS4NCj4gVjM6DQo+IC0gcmVtb3ZlIEh5cGVyLVYg Y2h1bmsgKE1pY2hhZWwgS2VsbGV5KQ0KPiAtIHJlbW92ZSBpbmNsdWRlIHZpcnRpb19jb25m aWcuaCBmcm9tIG1lbV9lbmNyeXB0LmMgKE9sZWtzYW5kciBUeXNoY2hlbmtvKQ0KPiAtIGFk ZCBjb21tZW50IGZvciBQTEFURk9STV9WSVJUSU9fUkVTVFJJQ1RFRF9NRU1fQUNDRVNTIChP bGVrc2FuZHIgVHlzaGNoZW5rbykNCj4gLS0tDQo+ICAgYXJjaC9zMzkwL0tjb25maWcgICAg ICAgICAgICAgICAgfCAgMSAtDQo+ICAgYXJjaC9zMzkwL21tL2luaXQuYyAgICAgICAgICAg ICAgfCAxMyArKystLS0tLS0tLS0tDQo+ICAgYXJjaC94ODYvS2NvbmZpZyAgICAgICAgICAg ICAgICAgfCAgMSAtDQo+ICAgYXJjaC94ODYvbW0vbWVtX2VuY3J5cHQuYyAgICAgICAgfCAg NyAtLS0tLS0tDQo+ICAgYXJjaC94ODYvbW0vbWVtX2VuY3J5cHRfYW1kLmMgICAgfCAgNCAr KysrDQo+ICAgZHJpdmVycy92aXJ0aW8vS2NvbmZpZyAgICAgICAgICAgfCAgNiAtLS0tLS0N Cj4gICBkcml2ZXJzL3ZpcnRpby92aXJ0aW8uYyAgICAgICAgICB8ICA1ICsrLS0tDQo+ICAg aW5jbHVkZS9saW51eC9wbGF0Zm9ybS1mZWF0dXJlLmggfCAgNiArKysrKy0NCj4gICBpbmNs dWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaCAgICB8ICA5IC0tLS0tLS0tLQ0KPiAgIDkgZmls ZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pDQo+IA0KPiBk aWZmIC0tZ2l0IGEvYXJjaC9zMzkwL0tjb25maWcgYi9hcmNoL3MzOTAvS2NvbmZpZw0KPiBp bmRleCBlMDg0YzcyMTA0ZjguLmY5N2EyMmFlNjlhOCAxMDA2NDQNCj4gLS0tIGEvYXJjaC9z MzkwL0tjb25maWcNCj4gKysrIGIvYXJjaC9zMzkwL0tjb25maWcNCj4gQEAgLTc3Miw3ICs3 NzIsNiBAQCBtZW51ICJWaXJ0dWFsaXphdGlvbiINCj4gICBjb25maWcgUFJPVEVDVEVEX1ZJ UlRVQUxJWkFUSU9OX0dVRVNUDQo+ICAgCWRlZl9ib29sIG4NCj4gICAJcHJvbXB0ICJQcm90 ZWN0ZWQgdmlydHVhbGl6YXRpb24gZ3Vlc3Qgc3VwcG9ydCINCj4gLQlzZWxlY3QgQVJDSF9I QVNfUkVTVFJJQ1RFRF9WSVJUSU9fTUVNT1JZX0FDQ0VTUw0KPiAgIAloZWxwDQo+ICAgCSAg U2VsZWN0IHRoaXMgb3B0aW9uLCBpZiB5b3Ugd2FudCB0byBiZSBhYmxlIHRvIHJ1biB0aGlz DQo+ICAgCSAga2VybmVsIGFzIGEgcHJvdGVjdGVkIHZpcnR1YWxpemF0aW9uIEtWTSBndWVz dC4NCj4gZGlmZiAtLWdpdCBhL2FyY2gvczM5MC9tbS9pbml0LmMgYi9hcmNoL3MzOTAvbW0v aW5pdC5jDQo+IGluZGV4IDg2ZmZkMGQ1MWZkNS4uMmMzYjQ1MTgxM2VkIDEwMDY0NA0KPiAt LS0gYS9hcmNoL3MzOTAvbW0vaW5pdC5jDQo+ICsrKyBiL2FyY2gvczM5MC9tbS9pbml0LmMN Cj4gQEAgLTMxLDYgKzMxLDcgQEANCj4gICAjaW5jbHVkZSA8bGludXgvY21hLmg+DQo+ICAg I2luY2x1ZGUgPGxpbnV4L2dmcC5oPg0KPiAgICNpbmNsdWRlIDxsaW51eC9kbWEtZGlyZWN0 Lmg+DQo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm0tZmVhdHVyZS5oPg0KPiAgICNpbmNs dWRlIDxhc20vcHJvY2Vzc29yLmg+DQo+ICAgI2luY2x1ZGUgPGxpbnV4L3VhY2Nlc3MuaD4N Cj4gICAjaW5jbHVkZSA8YXNtL3BnYWxsb2MuaD4NCj4gQEAgLTE2OCwyMiArMTY5LDE0IEBA IGJvb2wgZm9yY2VfZG1hX3VuZW5jcnlwdGVkKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gICAJ cmV0dXJuIGlzX3Byb3RfdmlydF9ndWVzdCgpOw0KPiAgIH0NCj4gICANCj4gLSNpZmRlZiBD T05GSUdfQVJDSF9IQVNfUkVTVFJJQ1RFRF9WSVJUSU9fTUVNT1JZX0FDQ0VTUw0KPiAtDQo+ IC1pbnQgYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcyh2b2lkKQ0K PiAtew0KPiAtCXJldHVybiBpc19wcm90X3ZpcnRfZ3Vlc3QoKTsNCj4gLX0NCj4gLUVYUE9S VF9TWU1CT0woYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcyk7DQo+ IC0NCj4gLSNlbmRpZg0KPiAtDQo+ICAgLyogcHJvdGVjdGVkIHZpcnR1YWxpemF0aW9uICov DQo+ICAgc3RhdGljIHZvaWQgcHZfaW5pdCh2b2lkKQ0KPiAgIHsNCj4gICAJaWYgKCFpc19w cm90X3ZpcnRfZ3Vlc3QoKSkNCj4gICAJCXJldHVybjsNCj4gICANCj4gKwlwbGF0Zm9ybV9z ZXQoUExBVEZPUk1fVklSVElPX1JFU1RSSUNURURfTUVNX0FDQ0VTUyk7DQo+ICsNCj4gICAJ LyogbWFrZSBzdXJlIGJvdW5jZSBidWZmZXJzIGFyZSBzaGFyZWQgKi8NCj4gICAJc3dpb3Rs Yl9mb3JjZSA9IFNXSU9UTEJfRk9SQ0U7DQo+ICAgCXN3aW90bGJfaW5pdCgxKTsNCj4gZGlm ZiAtLWdpdCBhL2FyY2gveDg2L0tjb25maWcgYi9hcmNoL3g4Ni9LY29uZmlnDQo+IGluZGV4 IDRiZWQzYWJmNDQ0ZC4uZWViN2M2YzhlZWM1IDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4Ni9L Y29uZmlnDQo+ICsrKyBiL2FyY2gveDg2L0tjb25maWcNCj4gQEAgLTE1MTUsNyArMTUxNSw2 IEBAIGNvbmZpZyBYODZfQ1BBX1NUQVRJU1RJQ1MNCj4gICBjb25maWcgWDg2X01FTV9FTkNS WVBUDQo+ICAgCXNlbGVjdCBBUkNIX0hBU19GT1JDRV9ETUFfVU5FTkNSWVBURUQNCj4gICAJ c2VsZWN0IERZTkFNSUNfUEhZU0lDQUxfTUFTSw0KPiAtCXNlbGVjdCBBUkNIX0hBU19SRVNU UklDVEVEX1ZJUlRJT19NRU1PUllfQUNDRVNTDQo+ICAgCWRlZl9ib29sIG4NCj4gICANCj4g ICBjb25maWcgQU1EX01FTV9FTkNSWVBUDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9tbS9t ZW1fZW5jcnlwdC5jIGIvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHQuYw0KPiBpbmRleCA1MGQy MDk5MzljNjYuLjE4YTU1YTBmMWNhMiAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYvbW0vbWVt X2VuY3J5cHQuYw0KPiArKysgYi9hcmNoL3g4Ni9tbS9tZW1fZW5jcnlwdC5jDQo+IEBAIC0x Miw3ICsxMiw2IEBADQo+ICAgI2luY2x1ZGUgPGxpbnV4L3N3aW90bGIuaD4NCj4gICAjaW5j bHVkZSA8bGludXgvY2NfcGxhdGZvcm0uaD4NCj4gICAjaW5jbHVkZSA8bGludXgvbWVtX2Vu Y3J5cHQuaD4NCj4gLSNpbmNsdWRlIDxsaW51eC92aXJ0aW9fY29uZmlnLmg+DQo+ICAgDQo+ ICAgLyogT3ZlcnJpZGUgZm9yIERNQSBkaXJlY3QgYWxsb2NhdGlvbiBjaGVjayAtIEFSQ0hf SEFTX0ZPUkNFX0RNQV9VTkVOQ1JZUFRFRCAqLw0KPiAgIGJvb2wgZm9yY2VfZG1hX3VuZW5j cnlwdGVkKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gQEAgLTc2LDkgKzc1LDMgQEAgdm9pZCBf X2luaXQgbWVtX2VuY3J5cHRfaW5pdCh2b2lkKQ0KPiAgIA0KPiAgIAlwcmludF9tZW1fZW5j cnlwdF9mZWF0dXJlX2luZm8oKTsNCj4gICB9DQo+IC0NCj4gLWludCBhcmNoX2hhc19yZXN0 cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKHZvaWQpDQo+IC17DQo+IC0JcmV0dXJuIGNj X3BsYXRmb3JtX2hhcyhDQ19BVFRSX0dVRVNUX01FTV9FTkNSWVBUKTsNCj4gLX0NCj4gLUVY UE9SVF9TWU1CT0xfR1BMKGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21lbW9yeV9hY2Nl c3MpOw0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHRfYW1kLmMgYi9h cmNoL3g4Ni9tbS9tZW1fZW5jcnlwdF9hbWQuYw0KPiBpbmRleCA2MTY5MDUzYzI4NTQuLjM5 YjcxMDg0ZDM2YiAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHRfYW1k LmMNCj4gKysrIGIvYXJjaC94ODYvbW0vbWVtX2VuY3J5cHRfYW1kLmMNCj4gQEAgLTIxLDYg KzIxLDcgQEANCj4gICAjaW5jbHVkZSA8bGludXgvZG1hLW1hcHBpbmcuaD4NCj4gICAjaW5j bHVkZSA8bGludXgvdmlydGlvX2NvbmZpZy5oPg0KPiAgICNpbmNsdWRlIDxsaW51eC9jY19w bGF0Zm9ybS5oPg0KPiArI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtLWZlYXR1cmUuaD4NCj4g ICANCj4gICAjaW5jbHVkZSA8YXNtL3RsYmZsdXNoLmg+DQo+ICAgI2luY2x1ZGUgPGFzbS9m aXhtYXAuaD4NCj4gQEAgLTIwNiw2ICsyMDcsOSBAQCB2b2lkIF9faW5pdCBzZXZfc2V0dXBf YXJjaCh2b2lkKQ0KPiAgIAlzaXplID0gdG90YWxfbWVtICogNiAvIDEwMDsNCj4gICAJc2l6 ZSA9IGNsYW1wX3ZhbChzaXplLCBJT19UTEJfREVGQVVMVF9TSVpFLCBTWl8xRyk7DQo+ICAg CXN3aW90bGJfYWRqdXN0X3NpemUoc2l6ZSk7DQo+ICsNCj4gKwkvKiBTZXQgcmVzdHJpY3Rl ZCBtZW1vcnkgYWNjZXNzIGZvciB2aXJ0aW8uICovDQo+ICsJcGxhdGZvcm1fc2V0KFBMQVRG T1JNX1ZJUlRJT19SRVNUUklDVEVEX01FTV9BQ0NFU1MpOw0KPiAgIH0NCj4gICANCj4gICBz dGF0aWMgdW5zaWduZWQgbG9uZyBwZ19sZXZlbF90b19wZm4oaW50IGxldmVsLCBwdGVfdCAq a3B0ZSwgcGdwcm90X3QgKnJldF9wcm90KQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0 aW8vS2NvbmZpZyBiL2RyaXZlcnMvdmlydGlvL0tjb25maWcNCj4gaW5kZXggYjVhZGY2YWJk MjQxLi5hNmRjOGI1ODQ2ZmUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvdmlydGlvL0tjb25m aWcNCj4gKysrIGIvZHJpdmVycy92aXJ0aW8vS2NvbmZpZw0KPiBAQCAtNiwxMiArNiw2IEBA IGNvbmZpZyBWSVJUSU8NCj4gICAJICBidXMsIHN1Y2ggYXMgQ09ORklHX1ZJUlRJT19QQ0ks IENPTkZJR19WSVJUSU9fTU1JTywgQ09ORklHX1JQTVNHDQo+ICAgCSAgb3IgQ09ORklHX1Mz OTBfR1VFU1QuDQo+ICAgDQo+IC1jb25maWcgQVJDSF9IQVNfUkVTVFJJQ1RFRF9WSVJUSU9f TUVNT1JZX0FDQ0VTUw0KPiAtCWJvb2wNCj4gLQloZWxwDQo+IC0JICBUaGlzIG9wdGlvbiBp cyBzZWxlY3RlZCBpZiB0aGUgYXJjaGl0ZWN0dXJlIG1heSBuZWVkIHRvIGVuZm9yY2UNCj4g LQkgIFZJUlRJT19GX0FDQ0VTU19QTEFURk9STQ0KPiAtDQo+ICAgY29uZmlnIFZJUlRJT19Q Q0lfTElCDQo+ICAgCXRyaXN0YXRlDQo+ICAgCWhlbHANCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdmlydGlvL3ZpcnRpby5jIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvLmMNCj4gaW5kZXgg MjJmMTVmNDQ0Zjc1Li4zNzFlMTZiMTgzODEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvdmly dGlvL3ZpcnRpby5jDQo+ICsrKyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpby5jDQo+IEBAIC01 LDYgKzUsNyBAQA0KPiAgICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4NCj4gICAjaW5jbHVk ZSA8bGludXgvaWRyLmg+DQo+ICAgI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+ICsjaW5jbHVk ZSA8bGludXgvcGxhdGZvcm0tZmVhdHVyZS5oPg0KPiAgICNpbmNsdWRlIDx1YXBpL2xpbnV4 L3ZpcnRpb19pZHMuaD4NCj4gICANCj4gICAvKiBVbmlxdWUgbnVtYmVyaW5nIGZvciB2aXJ0 aW8gZGV2aWNlcy4gKi8NCj4gQEAgLTE3MCwxMiArMTcxLDEwIEBAIEVYUE9SVF9TWU1CT0xf R1BMKHZpcnRpb19hZGRfc3RhdHVzKTsNCj4gICBzdGF0aWMgaW50IHZpcnRpb19mZWF0dXJl c19vayhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQ0KPiAgIHsNCj4gICAJdW5zaWduZWQg c3RhdHVzOw0KPiAtCWludCByZXQ7DQo+ICAgDQo+ICAgCW1pZ2h0X3NsZWVwKCk7DQo+ICAg DQo+IC0JcmV0ID0gYXJjaF9oYXNfcmVzdHJpY3RlZF92aXJ0aW9fbWVtb3J5X2FjY2Vzcygp Ow0KPiAtCWlmIChyZXQpIHsNCj4gKwlpZiAocGxhdGZvcm1faGFzKFBMQVRGT1JNX1ZJUlRJ T19SRVNUUklDVEVEX01FTV9BQ0NFU1MpKSB7DQo+ICAgCQlpZiAoIXZpcnRpb19oYXNfZmVh dHVyZShkZXYsIFZJUlRJT19GX1ZFUlNJT05fMSkpIHsNCj4gICAJCQlkZXZfd2FybigmZGV2 LT5kZXYsDQo+ICAgCQkJCSAiZGV2aWNlIG11c3QgcHJvdmlkZSBWSVJUSU9fRl9WRVJTSU9O XzFcbiIpOw0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9wbGF0Zm9ybS1mZWF0dXJl LmggYi9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtLWZlYXR1cmUuaA0KPiBpbmRleCA2ZWQ4NTk5 MjhiOTcuLmIyZjQ4YmU5OTlmYSAxMDA2NDQNCj4gLS0tIGEvaW5jbHVkZS9saW51eC9wbGF0 Zm9ybS1mZWF0dXJlLmgNCj4gKysrIGIvaW5jbHVkZS9saW51eC9wbGF0Zm9ybS1mZWF0dXJl LmgNCj4gQEAgLTYsNyArNiwxMSBAQA0KPiAgICNpbmNsdWRlIDxhc20vcGxhdGZvcm0tZmVh dHVyZS5oPg0KPiAgIA0KPiAgIC8qIFRoZSBwbGF0Zm9ybSBmZWF0dXJlcyBhcmUgc3RhcnRp bmcgd2l0aCB0aGUgYXJjaGl0ZWN0dXJlIHNwZWNpZmljIG9uZXMuICovDQo+IC0jZGVmaW5l IFBMQVRGT1JNX0ZFQVRfTgkJCQkoMCArIFBMQVRGT1JNX0FSQ0hfRkVBVF9OKQ0KPiArDQo+ ICsvKiBVc2VkIHRvIGVuYWJsZSBwbGF0Zm9ybSBzcGVjaWZpYyBETUEgaGFuZGxpbmcgZm9y IHZpcnRpbyBkZXZpY2VzLiAqLw0KPiArI2RlZmluZSBQTEFURk9STV9WSVJUSU9fUkVTVFJJ Q1RFRF9NRU1fQUNDRVNTCSgwICsgUExBVEZPUk1fQVJDSF9GRUFUX04pDQo+ICsNCj4gKyNk ZWZpbmUgUExBVEZPUk1fRkVBVF9OCQkJCSgxICsgUExBVEZPUk1fQVJDSF9GRUFUX04pDQo+ ICAgDQo+ICAgdm9pZCBwbGF0Zm9ybV9zZXQodW5zaWduZWQgaW50IGZlYXR1cmUpOw0KPiAg IHZvaWQgcGxhdGZvcm1fY2xlYXIodW5zaWduZWQgaW50IGZlYXR1cmUpOw0KPiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmggYi9pbmNsdWRlL2xpbnV4L3Zp cnRpb19jb25maWcuaA0KPiBpbmRleCBiMzQxZGQ2MmFhNGQuLjc5NDk4Mjk4NTE5ZCAxMDA2 NDQNCj4gLS0tIGEvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgNCj4gKysrIGIvaW5j bHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgNCj4gQEAgLTU1OSwxMyArNTU5LDQgQEAgc3Rh dGljIGlubGluZSB2b2lkIHZpcnRpb19jd3JpdGU2NChzdHJ1Y3QgdmlydGlvX2RldmljZSAq dmRldiwNCj4gICAJCV9yOwkJCQkJCQlcDQo+ICAgCX0pDQo+ICAgDQo+IC0jaWZkZWYgQ09O RklHX0FSQ0hfSEFTX1JFU1RSSUNURURfVklSVElPX01FTU9SWV9BQ0NFU1MNCj4gLWludCBh cmNoX2hhc19yZXN0cmljdGVkX3ZpcnRpb19tZW1vcnlfYWNjZXNzKHZvaWQpOw0KPiAtI2Vs c2UNCj4gLXN0YXRpYyBpbmxpbmUgaW50IGFyY2hfaGFzX3Jlc3RyaWN0ZWRfdmlydGlvX21l bW9yeV9hY2Nlc3Modm9pZCkNCj4gLXsNCj4gLQlyZXR1cm4gMDsNCj4gLX0NCj4gLSNlbmRp ZiAvKiBDT05GSUdfQVJDSF9IQVNfUkVTVFJJQ1RFRF9WSVJUSU9fTUVNT1JZX0FDQ0VTUyAq Lw0KPiAtDQo+ICAgI2VuZGlmIC8qIF9MSU5VWF9WSVJUSU9fQ09ORklHX0ggKi8NCg0K --------------q0Ma1pV467Hqz8bFVYRGEh6g Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------q0Ma1pV467Hqz8bFVYRGEh6g-- --------------1I1ZTSyF7lu6th38xRuLvtF5-- --------------X2JEafOWLT00pgbXX5l1hgWW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKGXSQFAwAAAAAACgkQsN6d1ii/Ey/L egf+PtIFC+UL1k00i5cGXLAvvs8VuzFwHOSoHas4lsathJJpwXrhkABtwPx7118RhEE5UodV/pOg tOMhBAiqg9sPi1tySOLdX/C642vn09hQfE37CWd9rL2Pzp48T8bsCjBeWm0FnXRGUrWWxqceswmH m0Ko5/OFTom3atSI8NfET94COzEq9Jy/QAb1fMap7tmeaUXvtXyYJckYl/ZLtzzUYq42OZG9Ths0 XXlNqa1wSRBzf82jZl2lGMQpXLW3617IIbZ1ERkrSubU7VeDnp1PMKBrj5cqwwdVDk8dv80dHz5i wUPBNaxyygC20eqhpF27w+qmz+P96j7cvBSPeOucqA== =zzt7 -----END PGP SIGNATURE----- --------------X2JEafOWLT00pgbXX5l1hgWW-- From xen-devel-bounces@lists.xenproject.org Thu May 19 15:09:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 15:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333110.556897 (Exim 4.92) (envelope-from ) id 1nrhmO-0004Dq-CQ; Thu, 19 May 2022 15:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333110.556897; Thu, 19 May 2022 15:09:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhmO-0004Dj-8C; Thu, 19 May 2022 15:09:32 +0000 Received: by outflank-mailman (input) for mailman id 333110; Thu, 19 May 2022 15:09:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhmM-0004Db-Id for xen-devel@lists.xenproject.org; Thu, 19 May 2022 15:09:30 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aca95c00-d785-11ec-837e-e5687231ffcc; Thu, 19 May 2022 17:09:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id ACBAB3200956; Thu, 19 May 2022 11:09:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 19 May 2022 11:09:25 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 11:09:24 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aca95c00-d785-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652972965; x= 1653059365; bh=8OcZJCdW56cWb9j78h7kTBMhLSl25Igl3mKMZFBwYp0=; b=Y Thvar2qo+vuHydAWOra6T4whdZXbjH2KCYYGeFgJzdRTi375EGIoyP9iYH+y+GAD 1cHGsTYqOIL3IT7aiDx46UkZGkj5EGBUax3YtIh9DaVyBGKdIQgT482GJEbYTbsr NpS4nXshFzpWSLGFVOf0DNZcUd1hUcXmlJbD0v2DbPJGv0gWhWwGo2DMfQq1epYj cm2YRS3A8Y7vTatU59aIZIayRHCsSnJjFsDle9f/V3AqTC9aeQYhHo9waJI4Re0f p2gS/0v6vLT3BNeCQpcv2yN9l6xnk4oLjNHvcXMiIf5iOWviJLDOCUpmFYmrX5In SKVm1j+at5ysE1CjwhqdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652972965; x=1653059365; bh=8OcZJCdW56cWb9j78h7kTBMhLSl2 5Igl3mKMZFBwYp0=; b=xkuCzmMFFKI0JQnfCR6eO/hs9NH4d4mm/EQQmlohnOf7 mUrJ09prCNi6D0e/7/qmLYwvQpd7KxXW6aonMT/3X3VBcfDZ/tXjsYEjpOUTcZVE WFyrJdwvvWyOVvLAFNrmXr+QFHO+7eIIN6WaGcJNfMKXyI8B0xjmB/ndik8YVvWK JhE+XqhQkn0WjarQlYEmbIzy4kK7xh6wkmKsrpuzMSJANweiQ0Dyr8cUMwjtyOMD e1dWWzH7buCHRishYLlsK5xVZAsEtV24qYusv/EvO1bGpRrNokCpvAqL2ZACTye+ pEg0DJg1slBlIi3K0u1ge8lGyXPcM4GJrZGeoeZ5hg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 19 May 2022 11:09:20 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 Message-ID: References: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> <05d4fa5b-78d6-96e6-b643-a98d26ec954f@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nj+Vcc5uU4o32Esz" Content-Disposition: inline In-Reply-To: <05d4fa5b-78d6-96e6-b643-a98d26ec954f@suse.com> --Nj+Vcc5uU4o32Esz Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 11:09:20 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 On Thu, May 19, 2022 at 04:55:10PM +0200, Jan Beulich wrote: > On 19.05.2022 16:45, Demi Marie Obenour wrote: > > On Thu, May 19, 2022 at 12:32:33PM +0200, Jan Beulich wrote: > >> On 18.05.2022 19:32, Demi Marie Obenour wrote: > >>> + /* > >>> + * The specification requires EfiBootServicesData, but accept > >>> + * EfiRuntimeServicesData, which is a more logical choice. > >>> + */ > >>> + if ( (desc->Type !=3D EfiRuntimeServicesData) && > >>> + (desc->Type !=3D EfiBootServicesData) ) > >>> + return 0; > >>> + available_len =3D len - (esrt - physical_start); > >>> + if ( available_len <=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entr= ies) ) > >>> + return 0; > >>> + available_len -=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); > >>> + esrt_ptr =3D (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; > >>> + if ( esrt_ptr->FwResourceVersion !=3D EFI_SYSTEM_RESOURCE_TABLE_= FIRMWARE_RESOURCE_VERSION || > >> > >> Nit (style): Overlong line. > >=20 > > Where is the best place to split this? > > EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION is a rather long > > identifier. >=20 > There's no good place to split; the only possible (imo) place is after > the !=3D . Will do in v7, along with parentheses to avoid any visual confusion. > >>> @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE Im= ageHandle, EFI_SYSTEM_TABLE *Syste > >>> if ( !efi_memmap ) > >>> blexit(L"Unable to allocate memory for EFI memory map"); > >>> =20 > >>> + efi_memmap_size =3D info_size; > >> > >> I don't think this global needs setting here, yet? The local will > >> do just fine here, likely yielding smaller code. But I realize that's > >> connected to how you did your change vs what I was expecting you to > >> do (see below). > >> > >>> + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_s= ize, > >>> + efi_memmap, &ma= p_key, > >>> + &efi_mdesc_size, > >>> + &mdesc_ver); > >>> + if ( EFI_ERROR(status) ) > >>> + PrintErrMesg(L"Cannot obtain memory map", status); > >>> + > >>> + /* Try to obtain the ESRT. Errors are not fatal. */ > >>> + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) > >>> + { > >>> + /* > >>> + * ESRT needs to be moved to memory of type EfiRuntimeServic= esData > >>> + * so that the memory it is in will not be used for other pu= rposes. > >>> + */ > >>> + void *new_esrt =3D NULL; > >>> + size_t esrt_size =3D get_esrt_size(efi_memmap + i); > >>> + > >>> + if ( !esrt_size ) > >>> + continue; > >>> + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D=3D > >>> + EfiRuntimeServicesData ) > >>> + break; /* ESRT already safe from reuse */ > >>> + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt= _size, > >>> + &new_esrt); > >> > >> I should have re-raised the earlier voiced concern when reviewing v5 (= or > >> maybe already v4), and I'm sorry for not having paid close enough > >> attention: This may add up to two more entries in the memory map (if an > >> entry is split and its middle part is used; of course with an unusual > >> implementation there could be even more of a growth). Yet below your > >> addition, before obtaining the final memory map, you don't re- obtain > >> (and re-increase) the size needed. As to (re-)increase: In fact, prior > >> to the allocation you do there shouldn't be a need to bump the space by > >> 8 extra entries. That's a safety measure only for possible allocations > >> happening across ExitBootServices(). > >> > >> And yes, in earlier versions you had > >> > >> - info_size +=3D 8 * efi_mdesc_size; > >> + info_size +=3D 8 * (efi_mdesc_size + 1); > >> > >> there, but that's not what would be needed anyway (if trying to avoid > >> a 2nd pass of establishing the needed size). Instead in such an event > >> you need to bump 8 to 10 (or at least 9, when assuming that normally it > >> wouldn't be the middle part of a new range which would be used, but > >> rather the leading or trailing one). > >> > >> While I'd be okay with addressing the two nits above while committing, > >> this allocation size aspect first wants settling on. Personally I'd > >> prefer the more involved solution, but I'd be okay with merely > >> bumping the 8 (plus the addition of a suitable comment, explaining > >> the now multiple [two] constituent parts of a seemingly arbitrary > >> number). If you want to go this easier route, I guess I could also > >> make that adjustment while committing (and adding my R-b). > >=20 > > I would prefer the more involved solution too, but I am not quite sure > > how to implement it. Should Xen call GetMemoryMap() in a loop, retrying > > as long as it returns EFI_BUFFER_TOO_SMALL? If I do get > > EFI_BUFFER_TOO_SMALL, how should I allocate memory for the new buffer? > > Should I ask ebmalloc() to provide all remaining memory, and then tell > > it how much was actually used? >=20 > Well, there are certainly multiple options. I was thinking that you'd > add a new call to size the memory map, add a few (again 8?) extra > entries there as well for the allocation, and leave the present sizing > call effectively alone (and sitting after all of your additions). How should I allocate memory for the new memory map? Getting the size is easy; allocating the memory is the tricky part. That=E2=80=99s where the idea of calling AllocatePool() and GetMemoryMap() in a loop came from. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --Nj+Vcc5uU4o32Esz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKGXaMACgkQsoi1X/+c IsFzrg/9HokvWhpxi+ZEC4W6ublKkDi7fU0cPgUA4BUfqy/q8uVrYn2yHRZmsjKP txysmNDcvQIMGRLm45DA2TvKr05Kwq19K2ZsMEUe/DcxLUubM8wO8hI02j/VMf1t /aO6CesvyyV+91re8qJXp5M5QhZrf/OPGL2G0gVYE7nLLXp03vqTvhJcx8R/XLaP LT7XElGBt7gFCOT41iAbUomiAvh8Qw9jjb1eZBylGNNcAV1FqLcda50GSS2pSY4A 1W2l7SU06NWAuCUmrnmEN/jdlikIxk7mS4Ydk/l9bpNx6XavTkOMLuASVlf9vJx6 AZrFjYwklv5q1aGVOat8sii14/YHTIe0YnCYbw71+OaSFjeRvdnyNBl9LwPHnHHG KJOBeZ3+e/A9mIWF7moh5LpobVITecY0kEH5WJhe4+jtx3UKfNLypinWnUejLR3o 7Y58ypiA3GMuw4sbmMzcZ8hXTQEm3AkOq4ZGtm7MMkUh1x+iWmmGELdTmnRRiJ0U OAufk07/VCZhv/ubCu304h318oVAQa1Cg43rOJYNCScstMiFBlR0FJWPs3J6sT4A 373dbcK89WlF79WMNw89yX0jC5PTjXi9wJPKJTPx9h5p8LSBglLy1EzMKAQD65OD mgvajRVzrDDhseNVHG/HVkOpfHu926Ka0zD1wdFBe7wIggJYKBw= =ZXkn -----END PGP SIGNATURE----- --Nj+Vcc5uU4o32Esz-- From xen-devel-bounces@lists.xenproject.org Thu May 19 15:22:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 15:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333133.556912 (Exim 4.92) (envelope-from ) id 1nrhyU-0006cc-O3; Thu, 19 May 2022 15:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333133.556912; Thu, 19 May 2022 15:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhyU-0006cV-Kq; Thu, 19 May 2022 15:22:02 +0000 Received: by outflank-mailman (input) for mailman id 333133; Thu, 19 May 2022 15:21:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrhxi-0006b7-Vi for xen-devel@lists.xenproject.org; Thu, 19 May 2022 15:21:15 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 518411c9-d787-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 17:21:13 +0200 (CEST) Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-MEKXsXuSPRWk9CaFymr4YA-1; Thu, 19 May 2022 11:21:03 -0400 Received: by mail-io1-f69.google.com with SMTP id i189-20020a6bb8c6000000b0065e475f5ca9so1452782iof.15 for ; Thu, 19 May 2022 08:21:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 518411c9-d787-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652973671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kXd/KXupdtmjxq/4SY395DYkyzm3K35XRINwHe8irxs=; b=MDQguJFnQM86N9dYUMv1L6Nxyy48vqiCHLCR3zi5XKTw/5yv//CE0M5rkR4n0Yt/XyoIBO WG1+ZJlPQ/ADG/GxIqTg1zvoLYENfiGyh+dlyWWzl0SdNIlrk7AU8VrMWc87gECChKYe9+ Dm9I+IWJULbGygeIryzpZA4aXMKE3NU= X-MC-Unique: MEKXsXuSPRWk9CaFymr4YA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXd/KXupdtmjxq/4SY395DYkyzm3K35XRINwHe8irxs=; b=baPHkJDAZ4E+hUwv0HMS+IWNcFlR4XLCR8w8nqYYTjHXeF09IlUaWetoWQomVsHxDd W7Tzl1WwJ9EeNgeUXuxoyYHsK7RY6QP6wmR+RlJagfpGngEbvlh3d1VyGXJ08oKhuwLJ kf7GK96+WMIJVzWJI5HmzX4dtdFdTp3LNNNZmqYihWGzSfZc8cJsYVheTgUsZi8nUbMX zTAKPQitvVb0IW4oYiuweTRPc7AbG+rgPVVfgv21G54uOh/78l1q0wcnvVv4MAwBVWxL aA6A6iWIhDIirG8xdqY8WeA84gjBHVMMTAjyl7dFJvaJogLrC50m192MCMPBAQWW5z3/ YCSA== X-Gm-Message-State: AOAM532qQ3JVHzab+9xAWwnd+O3OSKYEDqBtEvmR/yoha2Whab7rbTAI APQLw2tVM/c5SqyvZDFibp9l7C78gh/pWvoCc6XNoDvKmtgh/mGhj6Dn4q9W9NOpE5h8IRhI9k/ T6ODQa5DD4tGqG+9RgFZUe9FQZZ7oOU6J7Z3i0H0lrBs= X-Received: by 2002:a05:6638:1392:b0:32e:51e5:13fa with SMTP id w18-20020a056638139200b0032e51e513famr3017203jad.263.1652973662691; Thu, 19 May 2022 08:21:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVEJuNBAbP7uNezP2WpklP0FvEPhmrPpG0D9hQTRzYnOAhTSZ27Q+FaJmT8AitFoKl/d1StXHk8iDG86gDIus= X-Received: by 2002:a05:6638:1392:b0:32e:51e5:13fa with SMTP id w18-20020a056638139200b0032e51e513famr3017189jad.263.1652973662496; Thu, 19 May 2022 08:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20220518130945.2657905-1-stefanha@redhat.com> In-Reply-To: <20220518130945.2657905-1-stefanha@redhat.com> From: Alberto Faria Date: Thu, 19 May 2022 16:20:26 +0100 Message-ID: Subject: Re: [PATCH] block: get rid of blk->guest_block_size To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paul Durrant , Stefano Stabellini , John Snow , Paolo Bonzini , "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, Fam Zheng , Anthony Perard , Kevin Wolf , Hanna Reitz , Coiby Xu , Xie Yongji Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=afaria@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" On Wed, May 18, 2022 at 2:10 PM Stefan Hajnoczi wrote: > > Commit 1b7fd729559c ("block: rename buffer_alignment to > guest_block_size") noted: > > At this point, the field is set by the device emulation, but completely > ignored by the block layer. > > The last time the value of buffer_alignment/guest_block_size was > actually used was before commit 339064d50639 ("block: Don't use guest > sector size for qemu_blockalign()"). > > This value has not been used since 2013. Get rid of it. > > Cc: Xie Yongji > Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Faria From xen-devel-bounces@lists.xenproject.org Thu May 19 16:24:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 16:24:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333142.556923 (Exim 4.92) (envelope-from ) id 1nriw9-0004cy-Gr; Thu, 19 May 2022 16:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333142.556923; Thu, 19 May 2022 16:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nriw9-0004cr-DQ; Thu, 19 May 2022 16:23:41 +0000 Received: by outflank-mailman (input) for mailman id 333142; Thu, 19 May 2022 16:23:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nriw7-0004ch-Vj; Thu, 19 May 2022 16:23:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nriw7-00024s-PM; Thu, 19 May 2022 16:23:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nriw7-000387-Cy; Thu, 19 May 2022 16:23:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nriw7-0004Mx-CY; Thu, 19 May 2022 16:23:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xHBqFr4TPbPh7d6rrR48AjXB//Y+c6RDkU/G7kAx+AA=; b=HTSt1qq+6LKmYBd29tZBEsYCtC NO5us2N/kG3Kvc0kAesr4beM2ZY1yZgQqZ6WUc5AN1Xc3AhE4LXeF+/8A6m7ENNe84wVJKqT58p0z ItXs7uhXCeW/iL4I0q8HAJ7GypBm+jPrbZA1SEaYGselmzGlB5pssHRf4tJveKdB1keY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170569: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 16:23:39 +0000 flight 170569 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170569/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1098 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 16:40:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 16:40:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333152.556934 (Exim 4.92) (envelope-from ) id 1nrjCH-00071v-VI; Thu, 19 May 2022 16:40:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333152.556934; Thu, 19 May 2022 16:40:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjCH-00071o-Ro; Thu, 19 May 2022 16:40:21 +0000 Received: by outflank-mailman (input) for mailman id 333152; Thu, 19 May 2022 16:40:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjCG-00071i-96 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 16:40:20 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c4f5cb1-d792-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 18:40:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E0FEC3200976; Thu, 19 May 2022 12:40:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 19 May 2022 12:40:14 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 12:40:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c4f5cb1-d792-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652978412; x= 1653064812; bh=iyV8Eu14mHuegnfdclejo0S/9e+seMI1lnnSy6NkAK4=; b=E AiFsdBDzYgW5IFDHFRT9kLEZc6KU5gvX0jMc3PeOBK9928OjngEwI/C2XbM4Oc6+ /+putqYFBX/iPXqzO59LLClAAkji+prFK1oPtxEmlTTy8ABHvJw1oxcR9j+KQ0VD JDHm4wMA5dtH0lYPYabAMG/detnsYJ7d0eW2ut+77d5AixjZEnJ+qpDe69b2OoXz xycTI4VvwC5Br2mo/Jz3ls9NS/aYIkuJ5VLnhZy38yjkuTi3CZreiQbL2v2jDuW0 nU/vEd0jmsLEwSY2p14CYJswQunuSNCKcTTJNZjgsER0+fzlyaAjsBDfDN0RPTyR ZKlx606YDCRarILOTMhmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652978412; x=1653064812; bh=iyV8Eu14mHuegnfdclejo0S/9e+s eMI1lnnSy6NkAK4=; b=wboXbzf7gyIUHkCYjUmsq2UDBZMwfK2FP6TVvWTkr3n3 lPOE2CVN829Wqbv8jv5XI5sCOah2+2gYj/VCmhyFlu1GnFtLBL6YkOXejfU09PSE rsvAXL/rtyNNnEprkfO8Ud1KT0o5a9T9wb/1sNpjCip7UFD2U8FPhIX8azJ1Yuu3 B0Dm6cdXdMNXDifzbOr+O90Ut31G8r0dnjwo8ozgQV6vjgkpHzV2XIgP9yFPyOrQ IalkVDHLk/Dm/lAPTRq1kOlcWeQakBcdG1BczKlGUjKskivNtfVsOIddGj3t7N5o 258Oxavq3PrGr1MWGa+5giUCIHn61evk5r9IRsxvGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuedthefhtddvffefjeejvdehvdej ieehffehkeekheegleeuleevleduteehteetnecuffhomhgrihhnpehgihhthhhusgdrtg homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 19 May 2022 12:39:40 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion , Andrew Morton Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Linux Memory Management , regressions@lists.linux.dev Subject: [REGRESSION] Hang in 5.17.4+ that appears to be due to Xen Message-ID: References: <55436ae1-8255-1898-00df-51261080cd41@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P1/QErjS2jIercDB" Content-Disposition: inline In-Reply-To: --P1/QErjS2jIercDB Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 12:39:40 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion , Andrew Morton Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development , Linux Memory Management , regressions@lists.linux.dev Subject: [REGRESSION] Hang in 5.17.4+ that appears to be due to Xen On Mon, May 16, 2022 at 10:00:07AM -0400, Demi Marie Obenour wrote: > On Mon, May 16, 2022 at 08:48:17AM +0200, Juergen Gross wrote: > > On 14.05.22 17:55, Demi Marie Obenour wrote: > > > In https://github.com/QubesOS/qubes-issues/issues/7481, a user report= ed > > > that Xorg locked up when resizing a VM window. While I do not have t= he > > > same hardware the user does and thus cannot reproduce the bug, the st= ack > > > trace seems to indicate a deadlock between xen_gntdev and i915. It > > > appears that gnttab_unmap_refs_sync() is waiting for i915 to free the > > > pages, while i915 is waiting for the MMU notifier that called > > > gnttab_unmap_refs_sync() to return. Result: deadlock. > > >=20 > > > The problem appears to be that a mapped grant in PV mode will stay in > > > the =E2=80=9Cinvalidating=E2=80=9D state until it is freed. While MM= U notifiers are > > > allowed to sleep, it appears that they cannot wait for the page to be > > > freed, as is happening here. That said, I am not very familiar with > > > this code, so my diagnosis might be incorrect. > >=20 > > All I can say for now is that your patch seems to be introducing a use = after > > free issue, as the parameters of the delayed work might get freed now b= efore > > the delayed work is being executed. >=20 > I figured it was wrong, not least because I don=E2=80=99t think it compil= es > (invalid use of void value). That said, the current behavior is quite > suspicious to me. For one, it appears that munmap() on a grant in a PV > domain will not return until nobody else is using the page. This is not > what I would expect, and I can easily imagine it causing deadlocks in > userspace. Instead, I would expect for gntdev to automatically release > the grant when the reference count hits zero. This would also allow for > the same grant to be mapped in multiple processes, and might even unlock > DMA-BUF support. >=20 > > I don't know why this is happening only with rather recent kernels, as = the > > last gntdev changes in this area have been made in kernel 4.13. > >=20 > > I'd suggest to look at i915, as quite some work has happened in the code > > visible in your stack backtraces rather recently. Maybe it would be pos= sible > > to free the pages in i915 before calling the MMU notifier? >=20 > While I agree that the actual problem is almost certainly in i915, the > gntdev code does appear rather fragile. Since so few people use i915 + > Xen, problems with the combination generally don=E2=80=99t show up until = some > Qubes user makes a bug report, which isn=E2=80=99t great. It would be be= tter if > Xen didn=E2=80=99t introduce requirements on other kernel code that did n= ot hold > when not running on Xen. >=20 > In this case, if it is actually an invariant that one must not call MMU > notifiers for pages that are still in use, it would be better if this > was caught by a WARN_ON() or BUG_ON() in the core memory management > code. That would have found the bug instantly and deterministically on > all platforms, whereas the current failure is nondeterministic and only > happens under Xen. >=20 > I also wonder if this is a bug in the core MMU notifier infrastructure. > My reading of the mmu_interval_notifier_remove() documentation is that > it should only wait for the specific notifier being removed to finish, > not for all notifiers to finish. Adding the memory management > maintainers. Also adding the kernel regression tracker. #regzbot introduced v5.16..v5.17.4 --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --P1/QErjS2jIercDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKGcugACgkQsoi1X/+c IsG0sg//ZqBwhdpDjpK+PYyQI+aJdCfEVMWueglKYpsUmrNPhYgxCNbALIrELYEy Tw9tkJGJU7ENVh81aaAx6tCfj4wHEbxX6EOJzuTiwwAVtMHqeoPzX9d6vygcqWXL TJpjCVhcQ/F+kIjZcjPq2F7eIfmj2w+gfi64X0h0CtkNCVoFaiD638Hp0T/OF6sb yvgcleR94ObA6Tjz1jGFddEZSrQPEpZ4RVIg/Ak6OIHSI3phEtbwfoDyig59FT6O U5KmBswlz/7jTyjl9UPKLMEZidv3LWBbhEICX/6rCvZUPpdQ/hi3FlkpjMFh00wz vVAq4JIkvfY0YrOZHnHqitjZSLcpIvH7aVTxP0iWa6fGBopua0ZeyNDSmL6uFe6D MbvfojPY04p20pkuma3OfR1WIkAstnZdOn9oxGMbGokvGBd1lWZLbe94YZzV9bvi HTCVN2pn/YCRqktnUyAiaIQcnHKzEoEe7pDJR4OgNND0l9mg/GBMS9y7mHfw9SMI 4fSZr8xMgLwnUYHLFIFdfGaOlsf6wNhGOWGROY7FpetrlJ+R8A9x6SxBfVq9VffF B9Pu7kwEnIgaCGrwcQz6mU1h0Hz7fS7Ffig9YepRlYmNHuC1zhM2PraUjkbm+IRE 2NU3mQjopmT5Nb+gWTNgt2m0jo3K+z6GcMSvcYoQ4ef66GjW9A8= =KIy2 -----END PGP SIGNATURE----- --P1/QErjS2jIercDB-- From xen-devel-bounces@lists.xenproject.org Thu May 19 17:03:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 17:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333164.556945 (Exim 4.92) (envelope-from ) id 1nrjYy-00012I-PK; Thu, 19 May 2022 17:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333164.556945; Thu, 19 May 2022 17:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjYy-00012B-M6; Thu, 19 May 2022 17:03:48 +0000 Received: by outflank-mailman (input) for mailman id 333164; Thu, 19 May 2022 17:03:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjYx-000121-Cs; Thu, 19 May 2022 17:03:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjYx-0002lF-Ao; Thu, 19 May 2022 17:03:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjYw-0004KC-Ss; Thu, 19 May 2022 17:03:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrjYw-00016w-SS; Thu, 19 May 2022 17:03:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=quTibI5/NVyiypV2rv2tdzw5ZE9K7lDAatDHUmE2Les=; b=OLigO7nkZtDC0XFhhvupxbAUCo h+1Od+pClZ/6SC+HmXYt8oaHxRuRNJJ6O4CsvBS6jq4zhtDImwJKg8v703vAFXqB9CxFtq2Am5eGw 9fsMJ2AuiU9ZKy8TKpe23Pb0eemzQEy6DuK4DsbGwbm5wC7Zbql8kD4zBMpNQO+fMg94=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170570: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 17:03:46 +0000 flight 170570 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1099 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 17:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 17:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333175.556956 (Exim 4.92) (envelope-from ) id 1nrjl8-0002a4-38; Thu, 19 May 2022 17:16:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333175.556956; Thu, 19 May 2022 17:16:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjl8-0002Zx-0E; Thu, 19 May 2022 17:16:22 +0000 Received: by outflank-mailman (input) for mailman id 333175; Thu, 19 May 2022 17:16:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjl6-0002Zq-Cl for xen-devel@lists.xenproject.org; Thu, 19 May 2022 17:16:20 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65dccd85-d797-11ec-837e-e5687231ffcc; Thu, 19 May 2022 19:16:19 +0200 (CEST) Received: by mail-lj1-x235.google.com with SMTP id e4so6456510ljb.13 for ; Thu, 19 May 2022 10:16:19 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t5-20020a056512208500b0047255d211cfsm342560lfr.254.2022.05.19.10.16.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 10:16:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65dccd85-d797-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=KCMYHEZzLVzWO/NgFR4uh6OCxET/1BguPqK7/3lzzEc=; b=qd2s90ai+R7SPhnQJa9l8uy5s9Y8ktjDyEHqjAGmzwmChcDaLzkxByTTMTGEXqgAP4 VMHqaV0d0It8XbO3jdeYAGXqWcDSyEKPzgHpkk/ZcAQ85mXQAG3zOy9zqIYvNLJGwT5o sCqv/ecRf7wUwGo+PHo0KKwkjw7fyo6eDdCTPCQm5v5hI4OKULIjDYYwzRHpvV5QsfYb IKNAh/M/axjlUaz+t2ghiq9MJJsuzPz0CCZ4Gwqh616IMIrJiViT0Nr8irje270fP1Sc AetZNAxkA1TSSImI+88Efx8gAtNmZ2YaB/TShweqhfpJLan8GoC7ms6P5Zm/O+qbDDLo lhUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=KCMYHEZzLVzWO/NgFR4uh6OCxET/1BguPqK7/3lzzEc=; b=qWtQweiuhECIvuv6nYY5QK+Vc6edlGfRhWiC7lOr/tqn9avGa5BkiGwwMwlSDfhnW7 B8TCy56/p5lGrp2PAOoiUi4qk9TKGydh6P6owz/0X4/ArtAnKn6ibbyukv91fsZyZed0 HHCjkoVXMjNRaHOeHG5j63LlpMXucgPw2X4JKlyhUIGftG7zKjHAaz/wOYI9JsQWOz2L jQCK8Z6Ymoxr4v6YbXLrxj80hx3n0vryIQKrLTY0UOBmSh8x1wd2kowy+gUAeNyBZgS9 bWhvs0099NVLSiynyXdfYMnbKd20jz4Of0lQTcvSjJWqdWqFYe5BmOYZT869rlO89urr OiFA== X-Gm-Message-State: AOAM5307K/KUi8HWcc+TSoJ2V8381GQ7wksLgDnf//XXbea9WZ8ZlTRY yxPGsudPdaZofiinQp+ZTsk= X-Google-Smtp-Source: ABdhPJzVEeNR3HVocoYiIq8pvCH31i8/+ZUnIcZ1E9POBmJfCWmk+3HTdqCERPFxcseqriXaPp8YLg== X-Received: by 2002:a2e:91cf:0:b0:24f:11ea:d493 with SMTP id u15-20020a2e91cf000000b0024f11ead493mr3178996ljg.408.1652980578549; Thu, 19 May 2022 10:16:18 -0700 (PDT) Subject: Re: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-3-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <755f075c-db1f-bcd3-9f0d-f5979237e431@gmail.com> Date: Thu, 19 May 2022 20:16:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 18.05.22 14:05, Anthony PERARD wrote: Hello Anthony > On Tue, May 03, 2022 at 08:26:03PM +0300, Oleksandr Tyshchenko wrote: >> From: Julien Grall >> >> This patch introduces helpers to allocate Virtio MMIO params >> (IRQ and memory region) and create specific device node in >> the Guest device-tree with allocated params. In order to deal >> with multiple Virtio devices, reserve corresponding ranges. >> For now, we reserve 1MB for memory regions and 10 SPIs. >> >> As these helpers should be used for every Virtio device attached >> to the Guest, call them for Virtio disk(s). >> >> Please note, with statically allocated Virtio IRQs there is >> a risk of a clash with a physical IRQs of passthrough devices. >> For the first version, it's fine, but we should consider allocating >> the Virtio IRQs automatically. Thankfully, we know in advance which >> IRQs will be used for passthrough to be able to choose non-clashed >> ones. >> >> Signed-off-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko >> --- >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c >> index eef1de0..37403a2 100644 >> --- a/tools/libs/light/libxl_arm.c >> +++ b/tools/libs/light/libxl_arm.c >> @@ -8,6 +8,46 @@ >> #include >> #include >> >> +/* >> + * There is no clear requirements for the total size of Virtio MMIO region. >> + * The size of control registers is 0x100 and device-specific configuration >> + * registers starts at the offset 0x100, however it's size depends on the device >> + * and the driver. Pick the biggest known size at the moment to cover most >> + * of the devices (also consider allowing the user to configure the size via >> + * config file for the one not conforming with the proposed value). >> + */ >> +#define VIRTIO_MMIO_DEV_SIZE xen_mk_ullong(0x200) >> + >> +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc, uint64_t *virtio_mmio_base) >> +{ >> + uint64_t base = *virtio_mmio_base; >> + >> + /* Make sure we have enough reserved resources */ >> + if ((base + VIRTIO_MMIO_DEV_SIZE > >> + GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) { > Could you remove the second set of parentheses? I'd like the compiler to > warn us if there's an assignment. ok > >> @@ -26,8 +66,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, >> { >> uint32_t nr_spis = 0; >> unsigned int i; >> - uint32_t vuart_irq; >> - bool vuart_enabled = false; >> + uint32_t vuart_irq, virtio_irq = 0; >> + bool vuart_enabled = false, virtio_enabled = false; >> + uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; >> + uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; >> >> /* >> * If pl011 vuart is enabled then increment the nr_spis to allow allocation >> @@ -39,6 +81,30 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, >> vuart_enabled = true; >> } >> >> + for (i = 0; i < d_config->num_disks; i++) { >> + libxl_device_disk *disk = &d_config->disks[i]; >> + >> + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { >> + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); >> + if (!disk->base) >> + return ERROR_FAIL; >> + >> + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); >> + if (!disk->irq) >> + return ERROR_FAIL; >> + >> + if (virtio_irq < disk->irq) >> + virtio_irq = disk->irq; >> + virtio_enabled = true; >> + >> + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, >> + disk->vdev, disk->irq, disk->base); >> + } >> + } >> + >> + if (virtio_enabled) >> + nr_spis += (virtio_irq - 32) + 1; > Is it possible to update "nr_spis" inside the loop? yes, but ... > The added value > seems to be "number of virtio device + 1",    ... not really ... > so updating "nr_spis" and > adding +1 after the loop could work, right?    ... from my understanding, we cannot just increment nr_spis by "one" inside a loop, we need to calculate it. Something like that (not tested):        uint32_t spi;        ...        spi = irq - 32;        if (nr_spis <= spi)            nr_spis = spi + 1; Shall I update "nr_spis" inside the loop? Are you asking because of eliminating "virtio_enabled" and/or "virtio_irq" locals? They are used down the code. > > Also, what is "32"? Is it "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" ? Although currently "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" = "32", we cannot rely on this (I mean to use "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" instead of "32"),  because "32" has yet another meaning. This is an offset for SPI, the values before 32 are for private IRQs (PPI, SGI). > >> + >> for (i = 0; i < d_config->b_info.num_irqs; i++) { >> uint32_t irq = d_config->b_info.irqs[i]; >> uint32_t spi; >> @@ -787,6 +860,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, >> return 0; >> } >> >> + >> +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, >> + uint64_t base, uint32_t irq) >> +{ >> + int res; >> + gic_interrupt intr; >> + /* Placeholder for virtio@ + a 64-bit number + \0 */ >> + char buf[24]; >> + >> + snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base); > Could you use GCSPRINTF() here instead of using a buffer of a static > size calculated by hand which is potentially wrong? Also, the return > value of snprintf isn't checked so the string could be truncated without > warning. So I think GCSPRINTF is better than a static buffer. I got it, thank you for detailed explanation, will use. > > > > The rest of the patch looks fine. Thank you. > > Thanks, > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu May 19 17:17:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 17:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333183.556967 (Exim 4.92) (envelope-from ) id 1nrjlp-00036e-CR; Thu, 19 May 2022 17:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333183.556967; Thu, 19 May 2022 17:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjlp-00036X-9E; Thu, 19 May 2022 17:17:05 +0000 Received: by outflank-mailman (input) for mailman id 333183; Thu, 19 May 2022 17:17:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjlo-0002Zq-58 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 17:17:04 +0000 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c146c52-d797-11ec-837e-e5687231ffcc; Thu, 19 May 2022 19:16:59 +0200 (CEST) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 10:16:55 -0700 Received: from hcommiss-mobl2.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.62.193]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 10:16:54 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c146c52-d797-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652980619; x=1684516619; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jFHiIJiSbGbUIR6G4WjofS5RXbmz0hE6Nvokb7TyQhk=; b=See85NEcegUIpfPkjYq1LXrwANbgyqB2iLkAKyOEwkcI0e719YnOm4Zs V6awh80Cac4tXQzFOtGSALZK+Xd3+fEZgX0U4uQTQZ1zvVXWMW097maTd qDi2azfZ7hJiJ2L9KbYntyClHCs01Lna0sdrSu6duMzKlHACD7cXDSoIU 34ZZUh0UlH70FGkFKsUycM6uhisYl+HPJVCmcgNd52WOle1y5lBwyiIXv N5OFr8U6TupJOBwS1Q2m2FIPFdqVP/YlXJLfYmXiaQhDX+VSvM+V8jr9d O66g3mhB4acAaMvF5skptTkYgpe8Z+g0ewrHQ7tMF2z7e/jCNYgcx/f6k w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="332910133" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="332910133" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="546209103" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper Subject: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op Date: Thu, 19 May 2022 13:16:35 -0400 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make the do_memory_op function accessible to tools linking with libxc. Similar functions are already available for both domctl and sysctl. As part of this patch we also change the input 'cmd' to be unsigned int to accurately reflect what the hypervisor expects. Signed-off-by: Tamas K Lengyel --- v2: rename function in-place --- tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_domain.c | 28 +++++++++++++------------- tools/libs/ctrl/xc_mem_access.c | 6 +++--- tools/libs/ctrl/xc_mem_paging.c | 2 +- tools/libs/ctrl/xc_memshr.c | 8 ++++---- tools/libs/ctrl/xc_private.c | 6 +++--- tools/libs/ctrl/xc_private.h | 2 -- tools/libs/guest/xg_dom_boot.c | 6 +++--- tools/libs/guest/xg_sr_common_x86_pv.c | 2 +- 9 files changed, 30 insertions(+), 31 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 95bd5eca67..484e354412 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1597,6 +1597,7 @@ int xc_vmtrace_set_option(xc_interface *xch, uint32_t domid, int xc_domctl(xc_interface *xch, struct xen_domctl *domctl); int xc_sysctl(xc_interface *xch, struct xen_sysctl *sysctl); +long xc_memory_op(xc_interface *xch, unsigned int cmd, void *arg, size_t len); int xc_version(xc_interface *xch, int cmd, void *arg); diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index 71608c00e9..14c0420c35 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -736,7 +736,7 @@ int xc_domain_set_memory_map(xc_interface *xch, set_xen_guest_handle(fmap.map.buffer, entries); - rc = do_memory_op(xch, XENMEM_set_memory_map, &fmap, sizeof(fmap)); + rc = xc_memory_op(xch, XENMEM_set_memory_map, &fmap, sizeof(fmap)); xc_hypercall_bounce_post(xch, entries); @@ -760,7 +760,7 @@ int xc_get_machine_memory_map(xc_interface *xch, set_xen_guest_handle(memmap.buffer, entries); - rc = do_memory_op(xch, XENMEM_machine_memory_map, &memmap, sizeof(memmap)); + rc = xc_memory_op(xch, XENMEM_machine_memory_map, &memmap, sizeof(memmap)); xc_hypercall_bounce_post(xch, entries); @@ -814,7 +814,7 @@ int xc_reserved_device_memory_map(xc_interface *xch, set_xen_guest_handle(xrdmmap.buffer, entries); - rc = do_memory_op(xch, XENMEM_reserved_device_memory_map, + rc = xc_memory_op(xch, XENMEM_reserved_device_memory_map, &xrdmmap, sizeof(xrdmmap)); xc_hypercall_bounce_post(xch, entries); @@ -879,7 +879,7 @@ int xc_domain_get_tsc_info(xc_interface *xch, int xc_domain_maximum_gpfn(xc_interface *xch, uint32_t domid, xen_pfn_t *gpfns) { struct xen_memory_domain dom = { .domid = domid }; - long rc = do_memory_op(xch, XENMEM_maximum_gpfn, &dom, sizeof(dom)); + long rc = xc_memory_op(xch, XENMEM_maximum_gpfn, &dom, sizeof(dom)); if ( rc >= 0 ) { @@ -924,7 +924,7 @@ int xc_domain_increase_reservation(xc_interface *xch, set_xen_guest_handle(reservation.extent_start, extent_start); - err = do_memory_op(xch, XENMEM_increase_reservation, &reservation, sizeof(reservation)); + err = xc_memory_op(xch, XENMEM_increase_reservation, &reservation, sizeof(reservation)); xc_hypercall_bounce_post(xch, extent_start); @@ -987,7 +987,7 @@ int xc_domain_decrease_reservation(xc_interface *xch, } set_xen_guest_handle(reservation.extent_start, extent_start); - err = do_memory_op(xch, XENMEM_decrease_reservation, &reservation, sizeof(reservation)); + err = xc_memory_op(xch, XENMEM_decrease_reservation, &reservation, sizeof(reservation)); xc_hypercall_bounce_post(xch, extent_start); @@ -1031,7 +1031,7 @@ int xc_domain_add_to_physmap(xc_interface *xch, .idx = idx, .gpfn = gpfn, }; - return do_memory_op(xch, XENMEM_add_to_physmap, &xatp, sizeof(xatp)); + return xc_memory_op(xch, XENMEM_add_to_physmap, &xatp, sizeof(xatp)); } int xc_domain_add_to_physmap_batch(xc_interface *xch, @@ -1068,7 +1068,7 @@ int xc_domain_add_to_physmap_batch(xc_interface *xch, set_xen_guest_handle(xatp_batch.gpfns, gpfns); set_xen_guest_handle(xatp_batch.errs, errs); - rc = do_memory_op(xch, XENMEM_add_to_physmap_batch, + rc = xc_memory_op(xch, XENMEM_add_to_physmap_batch, &xatp_batch, sizeof(xatp_batch)); out: @@ -1087,7 +1087,7 @@ int xc_domain_remove_from_physmap(xc_interface *xch, .domid = domid, .gpfn = gpfn, }; - return do_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, sizeof(xrfp)); + return xc_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, sizeof(xrfp)); } int xc_domain_claim_pages(xc_interface *xch, @@ -1104,7 +1104,7 @@ int xc_domain_claim_pages(xc_interface *xch, set_xen_guest_handle(reservation.extent_start, HYPERCALL_BUFFER_NULL); - err = do_memory_op(xch, XENMEM_claim_pages, &reservation, sizeof(reservation)); + err = xc_memory_op(xch, XENMEM_claim_pages, &reservation, sizeof(reservation)); /* Ignore it if the hypervisor does not support the call. */ if (err == -1 && errno == ENOSYS) err = errno = 0; @@ -1134,7 +1134,7 @@ int xc_domain_populate_physmap(xc_interface *xch, } set_xen_guest_handle(reservation.extent_start, extent_start); - err = do_memory_op(xch, XENMEM_populate_physmap, &reservation, sizeof(reservation)); + err = xc_memory_op(xch, XENMEM_populate_physmap, &reservation, sizeof(reservation)); xc_hypercall_bounce_post(xch, extent_start); return err; @@ -1197,7 +1197,7 @@ int xc_domain_memory_exchange_pages(xc_interface *xch, set_xen_guest_handle(exchange.in.extent_start, in_extents); set_xen_guest_handle(exchange.out.extent_start, out_extents); - rc = do_memory_op(xch, XENMEM_exchange, &exchange, sizeof(exchange)); + rc = xc_memory_op(xch, XENMEM_exchange, &exchange, sizeof(exchange)); out: xc_hypercall_bounce_post(xch, in_extents); @@ -1227,7 +1227,7 @@ static int xc_domain_pod_target(xc_interface *xch, .target_pages = target_pages }; - err = do_memory_op(xch, op, &pod_target, sizeof(pod_target)); + err = xc_memory_op(xch, op, &pod_target, sizeof(pod_target)); if ( err < 0 ) DPRINTF("Failed %s_pod_target dom %d\n", @@ -2178,7 +2178,7 @@ int xc_domain_getvnuma(xc_interface *xch, vnuma_topo.domid = domid; vnuma_topo.pad = 0; - rc = do_memory_op(xch, XENMEM_get_vnumainfo, &vnuma_topo, + rc = xc_memory_op(xch, XENMEM_get_vnumainfo, &vnuma_topo, sizeof(vnuma_topo)); *nr_vnodes = vnuma_topo.nr_vnodes; diff --git a/tools/libs/ctrl/xc_mem_access.c b/tools/libs/ctrl/xc_mem_access.c index b452460e32..6d613037d0 100644 --- a/tools/libs/ctrl/xc_mem_access.c +++ b/tools/libs/ctrl/xc_mem_access.c @@ -38,7 +38,7 @@ int xc_set_mem_access(xc_interface *xch, .nr = nr }; - return do_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); + return xc_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); } int xc_set_mem_access_multi(xc_interface *xch, @@ -71,7 +71,7 @@ int xc_set_mem_access_multi(xc_interface *xch, set_xen_guest_handle(mao.pfn_list, pages); set_xen_guest_handle(mao.access_list, access); - rc = do_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); + rc = xc_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); xc_hypercall_bounce_post(xch, access); xc_hypercall_bounce_post(xch, pages); @@ -92,7 +92,7 @@ int xc_get_mem_access(xc_interface *xch, .pfn = pfn }; - rc = do_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); + rc = xc_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); if ( rc == 0 ) *access = mao.access; diff --git a/tools/libs/ctrl/xc_mem_paging.c b/tools/libs/ctrl/xc_mem_paging.c index 738f63ac20..999a572cef 100644 --- a/tools/libs/ctrl/xc_mem_paging.c +++ b/tools/libs/ctrl/xc_mem_paging.c @@ -47,7 +47,7 @@ static int xc_mem_paging_memop(xc_interface *xch, uint32_t domain_id, set_xen_guest_handle(mpo.buffer, buffer); } - rc = do_memory_op(xch, XENMEM_paging_op, &mpo, sizeof(mpo)); + rc = xc_memory_op(xch, XENMEM_paging_op, &mpo, sizeof(mpo)); if ( buffer ) xc_hypercall_bounce_post(xch, buffer); diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c index a6cfd7dccf..6c6db8aae8 100644 --- a/tools/libs/ctrl/xc_memshr.c +++ b/tools/libs/ctrl/xc_memshr.c @@ -71,7 +71,7 @@ static int xc_memshr_memop(xc_interface *xch, uint32_t domid, { mso->domain = domid; - return do_memory_op(xch, XENMEM_sharing_op, mso, sizeof(*mso)); + return xc_memory_op(xch, XENMEM_sharing_op, mso, sizeof(*mso)); } int xc_memshr_nominate_gfn(xc_interface *xch, @@ -275,15 +275,15 @@ int xc_memshr_audit(xc_interface *xch) mso.op = XENMEM_sharing_op_audit; - return do_memory_op(xch, XENMEM_sharing_op, &mso, sizeof(mso)); + return xc_memory_op(xch, XENMEM_sharing_op, &mso, sizeof(mso)); } long xc_sharing_freed_pages(xc_interface *xch) { - return do_memory_op(xch, XENMEM_get_sharing_freed_pages, NULL, 0); + return xc_memory_op(xch, XENMEM_get_sharing_freed_pages, NULL, 0); } long xc_sharing_used_frames(xc_interface *xch) { - return do_memory_op(xch, XENMEM_get_sharing_shared_pages, NULL, 0); + return xc_memory_op(xch, XENMEM_get_sharing_shared_pages, NULL, 0); } diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index c0422662f0..2f99a7d2cf 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -326,7 +326,7 @@ int xc_flush_mmu_updates(xc_interface *xch, struct xc_mmu *mmu) return flush_mmu_updates(xch, mmu); } -long do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len) +long xc_memory_op(xc_interface *xch, unsigned int cmd, void *arg, size_t len) { DECLARE_HYPERCALL_BOUNCE(arg, len, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); long ret = -1; @@ -386,7 +386,7 @@ long do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len) int xc_maximum_ram_page(xc_interface *xch, unsigned long *max_mfn) { - long rc = do_memory_op(xch, XENMEM_maximum_ram_page, NULL, 0); + long rc = xc_memory_op(xch, XENMEM_maximum_ram_page, NULL, 0); if ( rc >= 0 ) { @@ -428,7 +428,7 @@ int xc_machphys_mfn_list(xc_interface *xch, } set_xen_guest_handle(xmml.extent_start, extent_start); - rc = do_memory_op(xch, XENMEM_machphys_mfn_list, &xmml, sizeof(xmml)); + rc = xc_memory_op(xch, XENMEM_machphys_mfn_list, &xmml, sizeof(xmml)); if (rc || xmml.nr_extents != max_extents) rc = -1; else diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index ebdf78c2bf..ed960c6f30 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -367,8 +367,6 @@ static inline int do_multicall_op(xc_interface *xch, return ret; } -long do_memory_op(xc_interface *xch, int cmd, void *arg, size_t len); - void *xc_map_foreign_ranges(xc_interface *xch, uint32_t dom, size_t size, int prot, size_t chunksize, privcmd_mmap_entry_t entries[], int nentries); diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index f809dcbe97..263a3f4c85 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -348,7 +348,7 @@ static int compat_gnttab_hvm_seed(xc_interface *xch, uint32_t domid, xc_dom_printf(xch, "%s: d%d: pfn=0x%"PRI_xen_pfn, __func__, domid, scratch_gfn); - rc = do_memory_op(xch, XENMEM_add_to_physmap, &xatp, sizeof(xatp)); + rc = xc_memory_op(xch, XENMEM_add_to_physmap, &xatp, sizeof(xatp)); if ( rc != 0 ) { xc_dom_panic(xch, XC_INTERNAL_ERROR, @@ -366,12 +366,12 @@ static int compat_gnttab_hvm_seed(xc_interface *xch, uint32_t domid, xc_dom_panic(xch, XC_INTERNAL_ERROR, "%s: failed to seed gnttab entries for d%d\n", __func__, domid); - (void) do_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, + (void) xc_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, sizeof(xrfp)); return -1; } - rc = do_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, sizeof(xrfp)); + rc = xc_memory_op(xch, XENMEM_remove_from_physmap, &xrfp, sizeof(xrfp)); if (rc != 0) { xc_dom_panic(xch, XC_INTERNAL_ERROR, diff --git a/tools/libs/guest/xg_sr_common_x86_pv.c b/tools/libs/guest/xg_sr_common_x86_pv.c index c0acf00f90..1fa2821e91 100644 --- a/tools/libs/guest/xg_sr_common_x86_pv.c +++ b/tools/libs/guest/xg_sr_common_x86_pv.c @@ -161,7 +161,7 @@ int x86_pv_map_m2p(struct xc_sr_context *ctx) .extent_start = { &ctx->x86.pv.compat_m2p_mfn0 }, }; - rc = do_memory_op(xch, XENMEM_machphys_compat_mfn_list, + rc = xc_memory_op(xch, XENMEM_machphys_compat_mfn_list, &xmml, sizeof(xmml)); if ( rc || xmml.nr_extents != 1 ) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu May 19 17:29:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 17:29:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333191.556978 (Exim 4.92) (envelope-from ) id 1nrjxr-0004fI-JW; Thu, 19 May 2022 17:29:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333191.556978; Thu, 19 May 2022 17:29:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjxr-0004fB-Fn; Thu, 19 May 2022 17:29:31 +0000 Received: by outflank-mailman (input) for mailman id 333191; Thu, 19 May 2022 17:29:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjxq-0004f1-Fb; Thu, 19 May 2022 17:29:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjxq-0003Cp-C9; Thu, 19 May 2022 17:29:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrjxq-0004yy-52; Thu, 19 May 2022 17:29:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrjxq-0000h5-4a; Thu, 19 May 2022 17:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2ucuBMllshgnZWGrWrnZJDKpeMDcMQU9s8QV591OuCo=; b=RpA929BaSMZmy2R+HmLDAb6rLe Y7iIBFjFnibJBrHG+v0ZlTOUTqS70znppd+9mxlZBraAB7Xl9N2RoBxYDCdAWgt4uoCtJ2iGSebgr CdgMKXvhY6Gk+kFeGsKo8pyy16gTG7684Wh3Rlpmi1VFTqmDodimQ+1z90iLHPctMRNk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170572: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 17:29:30 +0000 flight 170572 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170572/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1100 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 17:43:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 17:43:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333204.556989 (Exim 4.92) (envelope-from ) id 1nrkBC-00071v-3V; Thu, 19 May 2022 17:43:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333204.556989; Thu, 19 May 2022 17:43:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkBC-00071j-01; Thu, 19 May 2022 17:43:18 +0000 Received: by outflank-mailman (input) for mailman id 333204; Thu, 19 May 2022 17:43:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkBA-000700-MQ; Thu, 19 May 2022 17:43:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkBA-0003RC-J7; Thu, 19 May 2022 17:43:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkBA-0005K0-4R; Thu, 19 May 2022 17:43:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrkBA-0003wH-3y; Thu, 19 May 2022 17:43:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zwVn99ZaYje/M38i9w9YVqgpBsZ8Hn/7dSdOla3fIbU=; b=wTVndcaXUkegCrlSe0/OsuknwK k91mJKNSLCgXbrFBA+p5yjkKGwt2fHFMS+d0V0j+wjDEqRhpPIwfB36Uzk5q5TATT3Djb3K3zUeJz PcRRT6YZfY7iOcdUV90hJ48qdQXtgz31Em4w59u9Bo/kVag1H7i6yrJZVauh7qFnip/g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170561: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=78ac2eebbab9150edf5d0d00e3648f5ebb599001 X-Osstest-Versions-That: qemuu=bcf0a3a422cd5d1b1c3c09c0e161205837dbe131 From: osstest service owner Date: Thu, 19 May 2022 17:43:16 +0000 flight 170561 qemu-mainline real [real] flight 170571 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170561/ http://logs.test-lab.xenproject.org/osstest/logs/170571/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 7 xen-install fail pass in 170571-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 170542 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 170571 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170542 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170542 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170542 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170542 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170542 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170542 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170542 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 78ac2eebbab9150edf5d0d00e3648f5ebb599001 baseline version: qemuu bcf0a3a422cd5d1b1c3c09c0e161205837dbe131 Last test of basis 170542 2022-05-18 14:39:22 Z 1 days Testing same since 170561 2022-05-19 04:21:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Helge Deller https://github.com/hdeller/qemu-hppa.git artist-cursor-fix-final Mark Cave-Ayland Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git bcf0a3a422..78ac2eebba 78ac2eebbab9150edf5d0d00e3648f5ebb599001 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 19 18:04:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 18:04:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333215.556999 (Exim 4.92) (envelope-from ) id 1nrkVE-00012s-QD; Thu, 19 May 2022 18:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333215.556999; Thu, 19 May 2022 18:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkVE-00012l-NR; Thu, 19 May 2022 18:04:00 +0000 Received: by outflank-mailman (input) for mailman id 333215; Thu, 19 May 2022 18:03:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkVD-00012b-2O; Thu, 19 May 2022 18:03:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkVD-0003rr-0p; Thu, 19 May 2022 18:03:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkVC-0005nI-Lw; Thu, 19 May 2022 18:03:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrkVC-0000yB-LT; Thu, 19 May 2022 18:03:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SloIdF2fHAlQBPREzbCu+b3jyMXewgZafMQvvrc/Ko0=; b=UyKyw6kADWZALvzz5N1q2LXq8/ 1IAYXd83OUEBpEUysvS/HjjXgOc2swYJ34N4i9e9ygYK+mXJoyt/bi4YbMcFWrg9yj0e/4ssRqVo1 dqSXy8HaiJXc06cpTlIE/wyvPxMD6AZ36h54ru4dwt448UnZg1pweRN61Rxdw18jDRx8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170573: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 18:03:58 +0000 flight 170573 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170573/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1101 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 18:18:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 18:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333225.557011 (Exim 4.92) (envelope-from ) id 1nrkjB-0002ZW-56; Thu, 19 May 2022 18:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333225.557011; Thu, 19 May 2022 18:18:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkjB-0002ZP-1s; Thu, 19 May 2022 18:18:25 +0000 Received: by outflank-mailman (input) for mailman id 333225; Thu, 19 May 2022 18:18:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrkj9-0002ZJ-OU for xen-devel@lists.xenproject.org; Thu, 19 May 2022 18:18:24 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cb7d0d4-d7a0-11ec-837e-e5687231ffcc; Thu, 19 May 2022 20:18:16 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5CD0C5C01FC; Thu, 19 May 2022 14:18:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 19 May 2022 14:18:19 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 May 2022 14:18:18 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cb7d0d4-d7a0-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652984299; x= 1653070699; bh=p/ZcdHvmtB8X1rkCDJsKxIe35fAqtqdi3lNcAexvvSo=; b=P gZzioXTTzenseX65+yBfXdA8/uzdM3p94L6iHsPd3BJfqvwcboOTcO/BHCn0T/LN edSz1SM9MB+SyXd3ZTJ6pJRUTGKdZuBuqdUtzWyrDEjdYe+LwXcmvDrlSPpz1ygM 38NJpPrU0kx2LeJVMyiQZxVl5BT0XloxnhrTuyi81zJxi6b5XiGdynYyFc2BWGXK vPnsfC0Enf0A0eq3/zJ6WJ+ioxEcvyw8ZVAsKXrUdLRpG7InuX/cIc6tI2TgxtPj VzD2rcpCFGmqTNSYziIEIHvrJItJ5gofJn4gRKch75hk4cBYVBnUrAQOda4mPjhk LH8ofMDuf6VF2id38XPjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652984299; x=1653070699; bh=p/ZcdHvmtB8X1rkCDJsKxIe35fAq tqdi3lNcAexvvSo=; b=Evw7E5LD2FXeQTxFHCfso+lRe/JtkQrZYFw5W0mBCzqo MMV46hiPpAQX5q5iDScPgFexHo48yJEkBdfx7h109FGeQ8UAh2eU/L/wNac3P4Mp iRyW0LhqrjDQPnvZUl1LKkNWJIBXbCyfv5m/cq4N0hUXVcXeZH9hq94pU5VAim98 9S3jmvi3bhIBMlYDi5ibNeuh9kDidt62ZjpYwuzO9+kTA+AiEC/KLXQR1gv40KSF /WSzmes4KTssmmceM16KeFaPxLqqBEsf+8O7rA0vToKTNm0gIyZFEezl8OJGYrmf n/UyMRRlWzZuq/+weMrtt7+5XIW4UVTkDGmS8+1wBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedugdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuedthefhtddvffefjeejvdehvdej ieehffehkeekheegleeuleevleduteehteetnecuffhomhgrihhnpehgihhthhhusgdrtg homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 19 May 2022 14:17:46 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development Subject: Re: Hang in 5.17.4+ that appears to be due to Xen Message-ID: References: <55436ae1-8255-1898-00df-51261080cd41@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2ArJoZLmXtBnMmHx" Content-Disposition: inline In-Reply-To: <55436ae1-8255-1898-00df-51261080cd41@suse.com> --2ArJoZLmXtBnMmHx Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 14:17:46 -0400 From: Demi Marie Obenour To: Juergen Gross , Xen developer discussion Cc: Boris Ostrovski , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Intel Graphics Development , DRI Development Subject: Re: Hang in 5.17.4+ that appears to be due to Xen On Mon, May 16, 2022 at 08:48:17AM +0200, Juergen Gross wrote: > On 14.05.22 17:55, Demi Marie Obenour wrote: > > In https://github.com/QubesOS/qubes-issues/issues/7481, a user reported > > that Xorg locked up when resizing a VM window. While I do not have the > > same hardware the user does and thus cannot reproduce the bug, the stack > > trace seems to indicate a deadlock between xen_gntdev and i915. It > > appears that gnttab_unmap_refs_sync() is waiting for i915 to free the > > pages, while i915 is waiting for the MMU notifier that called > > gnttab_unmap_refs_sync() to return. Result: deadlock. > >=20 > > The problem appears to be that a mapped grant in PV mode will stay in > > the =E2=80=9Cinvalidating=E2=80=9D state until it is freed. While MMU = notifiers are > > allowed to sleep, it appears that they cannot wait for the page to be > > freed, as is happening here. That said, I am not very familiar with > > this code, so my diagnosis might be incorrect. >=20 > All I can say for now is that your patch seems to be introducing a use af= ter > free issue, as the parameters of the delayed work might get freed now bef= ore > the delayed work is being executed. >=20 > I don't know why this is happening only with rather recent kernels, as the > last gntdev changes in this area have been made in kernel 4.13. >=20 > I'd suggest to look at i915, as quite some work has happened in the code > visible in your stack backtraces rather recently. Maybe it would be possi= ble > to free the pages in i915 before calling the MMU notifier? Honestly, I would rather fix this in gntdev, regardless of where the actual bug lies. GPU drivers get little testing under Xen, so if something like this happens again, it is likely to remain undiscovered until a Qubes user files a bug report. This results in a bad experience for Qubes users. I would much rather code that works on bare metal work in Xen dom0 too. I have had random hangs in the past (with various kernel versions) that might be due to similar problems. Furthermore, similar problems can arise whenever a driver removes an MMU notifier on userspace pages that someone else has references to. It is hard for me to see how this is the fault of the driver that removed the MMU notifier. I find it much more plausible that the correct fix is on the Xen side: allocate the delayed work parameters on the heap, and free them after the work is finished. This eliminates this entire class of bugs. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --2ArJoZLmXtBnMmHx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKGiegACgkQsoi1X/+c IsGnpg/+OOZRF3GOjff1/VSuGntrXoauU8RINbU98Rfv9GpTzq1h6l4EdlqIX7kX OFO2d6uVwkuJNFWOu0TWf5Yqz9k/G0fK2q2GUTikDYq3YyTmvUbsClkKBtJVjGxY mkHM21nJ/ao7ZET/UyKI8obwWeuC/VHIcTjjB2iKe4sYtltyWd9gfiJweJxt7Nd2 C/FqerrslTLEz42B/OO31qstbqxuXadl7L6kQhq3CIhtVl+ZEA8/8p92BKaEP/Wp Lsv2jkfDGIEmAWvZuEvaTkS19yQCeKq3jBoUgXHuYwSdEIX0A7x+MblengVfqrFv ZFYF5TVn7HSziGTVahYm/McAH2kCfmVsSh5DAB8v+k4EyDUsrbaPLSJGZboQsutb yUeqSueUV+fPvnD6XyWORtIQvOmeF9ecUWH9AUcWEtDrC1DxCeJADYcmE+RuLYuv t3t9OEo2SB55CmS28u9BIYFmlUDDKVvsQ3xUxDR9114HY++Dulj0W1R3ZrW0mWHH 49OrKp47DvmdaX1OyRhI/3RaPc4u+OTV8Z/1jWL0cHrybsimiTkjySKPXonIaO2E emd+UWqLoYAyQLZ+u8alEI5s7IBjeXPcL8VEwh6K7nblCjK3yfqdOCyYRem+1lgx JlHonk/YOiLPfZG1xN29p+/vRnzQBaZR28py7GpsVBsniWQQxS4= =DHnk -----END PGP SIGNATURE----- --2ArJoZLmXtBnMmHx-- From xen-devel-bounces@lists.xenproject.org Thu May 19 18:45:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 18:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333237.557022 (Exim 4.92) (envelope-from ) id 1nrl9M-0005vq-G2; Thu, 19 May 2022 18:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333237.557022; Thu, 19 May 2022 18:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrl9M-0005vj-Cg; Thu, 19 May 2022 18:45:28 +0000 Received: by outflank-mailman (input) for mailman id 333237; Thu, 19 May 2022 18:45:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrl9K-0005vZ-Tb; Thu, 19 May 2022 18:45:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrl9K-0004Yq-R2; Thu, 19 May 2022 18:45:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrl9K-0006pR-EX; Thu, 19 May 2022 18:45:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrl9K-0003cz-E8; Thu, 19 May 2022 18:45:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E6NCIwuPfQT7BKP3eBWCpFgPzmST0+/VX5A/8cT29PQ=; b=YvOO/+OKBoIEV3KqT3Om09sTwV r+fMiRLsbqtZ7eeuQ5ifjfOD9uX5iDpw+hd5nymzc9XJH+mwBP1HrqH/l54zUti8t7LkAKEpFsLMD U9uDmkT59CW9vd8RhcTuF9telYM+vFR7LG8NeZuZi9hta1P2LBcVp29vZTtkW7rmEToI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170574: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 18:45:26 +0000 flight 170574 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170574/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1102 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 19:21:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 19:21:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333247.557033 (Exim 4.92) (envelope-from ) id 1nrliR-0001bT-9K; Thu, 19 May 2022 19:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333247.557033; Thu, 19 May 2022 19:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrliR-0001bM-66; Thu, 19 May 2022 19:21:43 +0000 Received: by outflank-mailman (input) for mailman id 333247; Thu, 19 May 2022 19:21:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrliP-0001bG-83 for xen-devel@lists.xenproject.org; Thu, 19 May 2022 19:21:41 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e795dfd5-d7a8-11ec-bd2c-47488cf2e6aa; Thu, 19 May 2022 21:21:39 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id z7-20020a17090abd8700b001df78c7c209so9610347pjr.1 for ; Thu, 19 May 2022 12:21:38 -0700 (PDT) Received: from [10.136.13.180] ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id s13-20020a17090302cd00b0015e8d4eb244sm4097873plk.142.2022.05.19.12.20.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 12:21:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e795dfd5-d7a8-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to; bh=/Tb/IYJvo+PkUSUJ82nVsrU2mOtAwbc0Ba8xr30Pids=; b=YScfOEqKzNQTRP5/ZoitN/PQyZzhAw/3cVXPMcC6aYkfXAXmpBuw1/cdfefCBndNu7 1YfgopKDi331uVaKtcjhywsm3ML3+DRz4v6Ye3wRuEhgt6kvRQfNn5pgVKqkK5Dg8K7n +0BDhWzyyB+x74EejYVFLNI7nj4uAte6uwrXY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to; bh=/Tb/IYJvo+PkUSUJ82nVsrU2mOtAwbc0Ba8xr30Pids=; b=EBpMKf5C1OIbNQSyzd9y/sh3YIfYByaRMrKy14OgPxTKtXCpycRuSC2yPLKZ6rkIZW hGplfx/H4TuCc/ySX7IM7HqLZBTB9igj7Z5O0sylFjo2ntUXea8D4EvbyWVOmLDq3bvK JjFpeBfH7MGlh6RzSjMWtv0wkigZ9klTKcVoT6YVSuOgVuANIvd26wd6clNUMt2U0zTE ddHIYKYr2LXpuK1y2ZWhzDvz3AsmVvPyQSgJovXJKGql6IQz8E5F87fObYPfiJccs7YU tBjo1VCu+uNgOFhgzTSHuVbLs9s5ZcI/ttSmgj5O8ECqFMtZEujPoaIl3hIg40ZyPwfb 8jZw== X-Gm-Message-State: AOAM5331WD6tp7sjdBrLhlXYaKrzt/zYVuwzDjgI6DS6x7sGAriNj988 YKHN6JQxoGC4EAESWA+YsXvW3w== X-Google-Smtp-Source: ABdhPJy10NyoQgp6RBZKGliXG8eNodnAGbYEZ6SUYrfrdh7Px/LOSRK6yXAE0oXiUJBwAYB6KTRkcw== X-Received: by 2002:a17:902:8644:b0:153:9f01:2090 with SMTP id y4-20020a170902864400b001539f012090mr5952326plt.101.1652988097307; Thu, 19 May 2022 12:21:37 -0700 (PDT) Message-ID: Date: Thu, 19 May 2022 12:20:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list To: "Guilherme G. Piccoli" , Petr Mladek , Sebastian Reichel , Florian Fainelli , Desmond yan Cc: David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> From: Scott Branden In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000627bf605df624890" --000000000000627bf605df624890 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2022-05-19 05:19, Guilherme G. Piccoli wrote: > On 18/05/2022 19:17, Scott Branden wrote: >> Hi Guilherme, >> >> +Desmond >> [...] >>>>> I'm afraid it breaks kdump if this device is not reset beforehand - it's >>>>> a doorbell write, so not high risk I think... >>>>> >>>>> But in case the not-reset device can be probed normally in kdump kernel, >>>>> then I'm fine in moving this to the reboot list! I don't have the HW to >>>>> test myself. >>>> >>>> Good question. Well, it if has to be called before kdump then >>>> even "hypervisor" list is a wrong place because is not always >>>> called before kdump. >>> [...] >> We register to the panic notifier so that we can kill the VK card ASAP >> to stop DMAing things over to the host side. If it is not notified then >> memory may not be frozen when kdump is occurring. >> Notifying the card on panic is also needed to allow for any type of >> reset to occur. >> >> So, the only thing preventing moving the notifier later is the chance >> that memory is modified while kdump is occurring. Or, if DMA is >> disabled before kdump already then this wouldn't be an issue and the >> notification to the card (to allow for clean resets) can be done later. > > Hi Scott / Desmond, thanks for the detailed answer! Is this adapter > designed to run in x86 only or you have other architectures' use cases? The adapter may be used in any PCIe design that supports DMA. So it may be possible to run in arm64 servers. > > I'm not expert on that, but I guess whether DMA is "kept" or not depends > a bit if IOMMU is used. IIRC, there was a copy of the DMAR table in > kdump (at least for Intel IOMMU). Also, devices are not properly > quiesced on kdump IIUC, we don't call shutdown/reset handlers, they're > skip due to the crash nature - so there is a risk of devices doing bad > things in the new kernel. > > With that said, and given this is a lightweight notifier that ideally > should run ASAP, I'd keep this one in the hypervisor list. We can > "adjust" the semantic of this list to include lightweight notifiers that > reset adapters. Sounds the best to keep system operating as tested today. > > With that said, Petr has a point - not always such list is going to be > called before kdump. So, that makes me think in another idea: what if we > have another list, but not on panic path, but instead in the custom > crash_shutdown()? Drivers could add callbacks there that must execute > before kexec/kdump, no matter what. It may be beneficial for some other drivers but for our use we would then need to register for the panic path and the crash_shutdown path. We notify the VK card for 2 purposes: one to stop DMA so memory stop changing during a kdump. And also to get the card into a good state so resets happen cleanly. > > Let me know your thoughts Scott / Desmond / Petr and all interested parties. > Cheers, > > > Guilherme --000000000000627bf605df624890 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDH2hdImkqeI7h1IaTzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDA5MDJaFw0yMjA5MjIxNDMxMTRaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVNjb3R0IEJyYW5kZW4xKTAnBgkqhkiG9w0B CQEWGnNjb3R0LmJyYW5kZW5AYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAtKitgySOPXrCfmgJJ/6N4Bq2PYQ9C7pbBbEOgcLdGZyOHK9MJW3fcf8NXplv3OfFCQzp rm9QWjKvH806lCzDhSKgAg+vro9Alv6BTl7wBdSVpgFsV/Tl+kbDfeBxjE/AwOW+WNGIPJLH4WCo MMkaRzH4Lg/8h9DnzxR46++4CqLY4KQQ151a+4Ojb/u/YlVGYlZa/jmTEgk3It8dzv54hZ/UoZg1 cRe0CRXA7ypOJSgxO/nOOyQoaJxT7CGg1npOeSpPjEuc3fE4xum3l0nvU85hj6MlKZu43hokdBh0 D0nLyyhEwlR3AC/msdff/UGbM/JR9vk812RP4m/aNWZFJwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUOhjEpl04Sz9dh5MI82E1 V39lM/owDQYJKoZIhvcNAQELBQADggEBAA7Rlypx/esz/iq1yA4+KW7uwV/aBY344BWcXt6I+SNK VwFBgFWfLj5vaEud9TVv2fPSiaHJo0umemOJk+43QD+bsoqmgcFXd21PrOt7Jjs+jjVED9VC5kJq S4NNKUkS+BqijJwSegtVygrc/atrIlJbjI21q4qpemUo5fgwqCNm++BmBGTI8yA09vtGSNDRN42k lLX9hl3iEj5SBgkQqCbbnoE+ZjjKfqt7ED166WhgyQWNrl39yLcvLj+JRUB3RuvXKZjH0NQEEBII wZBDSkyneykLt3CBNIhSCTxKM6OWxVp936ALSa5K9FNy00TeWSpokR6NmzaW8VD/EjTgvqAxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgx9oXSJpKniO4dS Gk8wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEILXYB80rvGoONbSrKccJNuW/yt4P RwosxTdX9/zqPyCuMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIy MDUxOTE5MjEzN1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQBsqFeeADkOUmIUQkOFTz4+tbTbcu1kJOu0o2LxolE41ACQ Jjl4mG3AxFObAA/vLQRFL2LzmM7+OQ1nUaL/1rIXCVF7a9/kONy4oIc1uslvIVE6XRS3TrWAZyJ1 KXT1lLM7MUhCe5EkzcZxuapBiKdpmxfhxDzt27vOsC3LpZXW8YbnYGANBVAG0RYROLCIzpGsRUeh vHZtk9Zj5ppQPXoMCjx9Nah3XO3Uhnp0i0UbRd2dsZj60JkDxx2H+iX54btyjpq60IUp5n2ulZMN latE6tPUnpMceZbDhq45QMDYde9jGlCoU4/7lo4RwQhU+Kl7xsUECNDbTk4UszM1uyGJ --000000000000627bf605df624890-- From xen-devel-bounces@lists.xenproject.org Thu May 19 19:42:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 19:42:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333255.557044 (Exim 4.92) (envelope-from ) id 1nrm2I-0003w6-11; Thu, 19 May 2022 19:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333255.557044; Thu, 19 May 2022 19:42:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm2H-0003vz-UH; Thu, 19 May 2022 19:42:13 +0000 Received: by outflank-mailman (input) for mailman id 333255; Thu, 19 May 2022 19:42:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm2G-0003vp-KF; Thu, 19 May 2022 19:42:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm2G-0005XG-Fv; Thu, 19 May 2022 19:42:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm2G-0008OY-1D; Thu, 19 May 2022 19:42:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrm2G-0002ZL-0l; Thu, 19 May 2022 19:42:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RPKKqm6kvmIhcJ+NDttvql1BtPusU5XJ1f9gLom/YKQ=; b=hMAP5nB52OQIK9epML/Wri/VQ+ JIZzi27rj6oXOQfRgiXJhKNqJgCZSI7VT19Yf8bAl+I+HDaqsq9co4xjPf4s8jye1B7pGuTWin4q1 x6EzCO8jFFGgbu7ALkKLbNZn3Ubb4Oh4sfPh4N+M9/wNRnhoxvVcQdsunnFKeXlwGMtk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170563: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-saverestore.2:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=43aa3f6e72d340a85d3943b86350f6196a87289c X-Osstest-Versions-That: xen=25c160a74f4489f031ac79a24078cc12efd5c96b From: osstest service owner Date: Thu, 19 May 2022 19:42:12 +0000 flight 170563 xen-unstable real [real] flight 170575 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170563/ http://logs.test-lab.xenproject.org/osstest/logs/170575/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-amd64 17 guest-saverestore.2 fail pass in 170575-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170545 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170545 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170545 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170545 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170545 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170545 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170545 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170545 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170545 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170545 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170545 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170545 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 43aa3f6e72d340a85d3943b86350f6196a87289c baseline version: xen 25c160a74f4489f031ac79a24078cc12efd5c96b Last test of basis 170545 2022-05-18 15:40:11 Z 1 days Testing same since 170563 2022-05-19 06:32:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Bertrand Marquis Christian Lindig Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Stefano Stabellini Stefano Stabellini Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 25c160a74f..43aa3f6e72 43aa3f6e72d340a85d3943b86350f6196a87289c -> master From xen-devel-bounces@lists.xenproject.org Thu May 19 19:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 19:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333273.557083 (Exim 4.92) (envelope-from ) id 1nrm82-0004ya-6m; Thu, 19 May 2022 19:48:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333273.557083; Thu, 19 May 2022 19:48:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm82-0004yT-3x; Thu, 19 May 2022 19:48:10 +0000 Received: by outflank-mailman (input) for mailman id 333273; Thu, 19 May 2022 19:48:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm81-0004yG-1O; Thu, 19 May 2022 19:48:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm80-0005eV-UA; Thu, 19 May 2022 19:48:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrm80-0008W9-Dr; Thu, 19 May 2022 19:48:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrm80-0003GT-DR; Thu, 19 May 2022 19:48:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=O4MDd7WcI9nau9iqxGcNB05eQf4snfHE59d2tq1enRY=; b=so1gObL6eNMn6Hgy95vBBQ2ePL edCryLJ1Qn+ubv70G5JyZy3rDDCGS0N4ltDNzCBaxxcIY7eKDLJIPzyn8OcASf4X1j8laYdPsM2Np 5WnPUEj6E3waq49/UrgJpXc2d1CkdJX+L/Q548w3p+6be26uzKaUo08PComEevCSR2o4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170576: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 19:48:08 +0000 flight 170576 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170576/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1103 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 20:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 20:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333285.557093 (Exim 4.92) (envelope-from ) id 1nrmo5-0001YT-Gs; Thu, 19 May 2022 20:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333285.557093; Thu, 19 May 2022 20:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrmo5-0001YM-Dt; Thu, 19 May 2022 20:31:37 +0000 Received: by outflank-mailman (input) for mailman id 333285; Thu, 19 May 2022 20:31:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrmo4-0001Y9-1b; Thu, 19 May 2022 20:31:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrmo3-0006U4-Ue; Thu, 19 May 2022 20:31:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrmo3-00018X-Gs; Thu, 19 May 2022 20:31:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrmo3-0006uw-GR; Thu, 19 May 2022 20:31:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=alTO3jFitXuVAiD8rBJ670NksQiuH32m83ROqMSTeqk=; b=27TuEx8y0MNzFRDzsbg5fbb4Bp vMYHmltgOSTY07u/i2glXgQQ/ZfQwFiwwu+SCQ6fZ9+WctlN4yPp+hR7TyxVj+XZG8WqOliDdvXIk ZqTfH62TzFizq7SlirNc4Qp4DxvrIvEBrCkwixCe2SHmimxjYpIj5nxpeRUDvb9SKLaA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170577: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 20:31:35 +0000 flight 170577 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170577/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1104 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 21:33:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 21:33:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333295.557105 (Exim 4.92) (envelope-from ) id 1nrnlL-0007S0-8C; Thu, 19 May 2022 21:32:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333295.557105; Thu, 19 May 2022 21:32:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrnlL-0007Rt-4f; Thu, 19 May 2022 21:32:51 +0000 Received: by outflank-mailman (input) for mailman id 333295; Thu, 19 May 2022 21:32:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrnlK-0007Rj-Gy; Thu, 19 May 2022 21:32:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrnlK-0007VJ-9j; Thu, 19 May 2022 21:32:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrnlJ-0002aN-Pu; Thu, 19 May 2022 21:32:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrnlJ-0005hY-PU; Thu, 19 May 2022 21:32:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=b+uAbA4eqHuUWOOFmxv9vwtByfyB1Lfgk8dsHz6FgvA=; b=C3Vx42eTp8WdLnxOJKSB0znmBo 6ccE33el8VneAAMxMfoFsMY0EqgeyfzYZD89WDHlOZm1ON5CtYnZM/M1Kc6UneSeL/e2nJaAMACoZ lsufqC1qp251xgOY1kVWA7Rr2NTN8yWXz0yIpFDXBPuikf8GPwXTBrh76RdWfPaCe9j4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170566: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f993aed406eaf968ba3867a76bb46c95336a33d0 X-Osstest-Versions-That: linux=ef1302160bfb19f804451d0e919266703501c875 From: osstest service owner Date: Thu, 19 May 2022 21:32:49 +0000 flight 170566 linux-linus real [real] flight 170579 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170566/ http://logs.test-lab.xenproject.org/osstest/logs/170579/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 170579-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170546 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170546 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170546 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170546 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170546 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170546 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170546 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170546 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170546 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux f993aed406eaf968ba3867a76bb46c95336a33d0 baseline version: linux ef1302160bfb19f804451d0e919266703501c875 Last test of basis 170546 2022-05-18 16:16:14 Z 1 days Testing same since 170566 2022-05-19 07:54:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Arnd Bergmann Bart Van Assche Bjorn Andersson Dmitry Baryshkov Dylan Yudaken Eli Cohen Frank Wunderlich Heiko Stuebner Howard Chiu Jae Hyun Yoo Jason Wang Jens Axboe Joel Stanley Johnny Huang Julian Orth Linus Torvalds Michael S. Tsirkin Ondrej Mosnacek Paul Moore Rajendra Nayak Rob Herring Tony Lindgren Zev Weiss jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ef1302160bfb..f993aed406ea f993aed406eaf968ba3867a76bb46c95336a33d0 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu May 19 22:01:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 22:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333306.557116 (Exim 4.92) (envelope-from ) id 1nroCw-0002KL-Lu; Thu, 19 May 2022 22:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333306.557116; Thu, 19 May 2022 22:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nroCw-0002KE-JB; Thu, 19 May 2022 22:01:22 +0000 Received: by outflank-mailman (input) for mailman id 333306; Thu, 19 May 2022 22:01:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nroCu-0002K3-VF; Thu, 19 May 2022 22:01:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nroCu-000815-U9; Thu, 19 May 2022 22:01:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nroCu-0003Sz-J4; Thu, 19 May 2022 22:01:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nroCu-0004Ht-IZ; Thu, 19 May 2022 22:01:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=akZvruiozKv0S3egihpV2MoCQbfU7gTO6hdvkynUS6U=; b=c5UnWS3a3QQFhwiOXE1UusfJUJ /Bb6Va+P00o69wdfv2j6sd8l6o4aNEGwHzsDO2Jj4nCHMb9wZ9OT1Cgz3fjXOUZmnZKVJocqwJum6 ZdKkU6T1cotB0JAnUZdB1SMS655xQBvvsr++j01OXhW266V2ou3iPPy2b6BeWKmUxPX8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170580: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 22:01:20 +0000 flight 170580 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170580/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1105 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 23:04:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 23:04:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333316.557127 (Exim 4.92) (envelope-from ) id 1nrpBm-0008GC-D7; Thu, 19 May 2022 23:04:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333316.557127; Thu, 19 May 2022 23:04:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpBm-0008G5-9u; Thu, 19 May 2022 23:04:14 +0000 Received: by outflank-mailman (input) for mailman id 333316; Thu, 19 May 2022 23:04:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpBl-0008Fv-2h; Thu, 19 May 2022 23:04:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpBk-0000dC-Ve; Thu, 19 May 2022 23:04:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpBk-0006GW-L6; Thu, 19 May 2022 23:04:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrpBk-0007Os-KX; Thu, 19 May 2022 23:04:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JTLuFqp7haWIUKWk5Bsbh2GybteJtTkCXQdrsFCNJL4=; b=QbD+uU7C6dM+RuC1yvLBqpvfMC W27wscaA9bsxXBLuFEvODWhFNIGXA5RbJt5zzyMyFqvak1qlc4FI04kgGgcUeXg5VR6EVzN2kqep/ 3olEY/XytCjrkuxeBKd5DmBZ7N++OvjzAk0odk7a04htbuZUF0CNL4RcksJPLuNX7D6A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170582: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Thu, 19 May 2022 23:04:12 +0000 flight 170582 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170582/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1106 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 19 23:23:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 23:23:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333326.557138 (Exim 4.92) (envelope-from ) id 1nrpUC-0002B7-0m; Thu, 19 May 2022 23:23:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333326.557138; Thu, 19 May 2022 23:23:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpUB-0002B0-TL; Thu, 19 May 2022 23:23:15 +0000 Received: by outflank-mailman (input) for mailman id 333326; Thu, 19 May 2022 23:23:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrpU9-0002Au-VO for xen-devel@lists.xenproject.org; Thu, 19 May 2022 23:23:14 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4692d36-d7ca-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 01:23:11 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DEC7F5C0109 for ; Thu, 19 May 2022 19:23:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 19 May 2022 19:23:07 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 19 May 2022 19:23:07 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4692d36-d7ca-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1653002587; x=1653088987; bh=zqjTFcLaia d3MqNunNtu7UVCBZfKCDjBEpQDzT8tflI=; b=kFK9casaG8C+rdIaQV4g8Zrvvk Ktc4X2r/CMTXY00nq9h7J1591clfasO5Ue4ELIwatDGGEYDKA7UJvUcnnsyumwyy T5KUYhV24Dv95fyLdLcW88KghJEYTdRjlBc/h/YOPyUQjjRhMzHisFyhgzrb3Lb7 V20xzB3nIbY4fNa3ExrNhHDtXyvhPr3OByjmik2U2hPDXfsFJ3c2DCsDkynYsIfX wnvEg3YJvRLDaloayv/Xn+VFQpKHolYfLfrBMvAIxphe6Pb1PWvZnHG2HCwoo8yR MCB6nfwDkOCETGAXMZwE4ulk4G2TDBzOZiJNwc+4mj1ns2+/1ryds10AgNDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653002587; x= 1653088987; bh=zqjTFcLaiad3MqNunNtu7UVCBZfKCDjBEpQDzT8tflI=; b=T aK+XoUp3RwF4BOiKXulvX17c3F1SuFmDBNW2RWRwAEz/ZJuOYYyqdxQe6IwjCOlf sftmwpdBJJJW1H/5En8HHti3C8AQQS/uT3HCOrZLCF7OO4gcKbERO3qzQRVWn0gK 70eMktajrCWi4q5ixxdGRNKNKbxjU9Ku6B86tXF+2iERi9aF9LOH7dc4/6RWV6m+ DC8TKwwtgCG3fINu+TmE0v43BSUchncNhkhKAx9O4odYAOWIIFzCr2XXVIOKQ0Pq shv1HHrshsoYNjpaOix0vkw8a6f8WGhXRQlOwbdvZJsklsO6CBxE1zZ222V9MRKU cXGlzkk05Qxj+Iphh1QtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedriedvgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugesghdtreertddtjeenucfhrhhomhepffgvmhhiucforghr ihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsg drtghomheqnecuggftrfgrthhtvghrnhepleejtdegjeffleevfeeuleehjefgvdefhfeh gfejgeelteegtdetjeelueeuveefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdr tghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 19 May 2022 19:22:33 -0400 From: Demi Marie Obenour To: Xen developer discussion Subject: Grant operation batching Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L0eN+3MD/NWPHsz0" Content-Disposition: inline --L0eN+3MD/NWPHsz0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 19 May 2022 19:22:33 -0400 From: Demi Marie Obenour To: Xen developer discussion Subject: Grant operation batching It is well known that mapping and unmapping grants is expensive, which is why blkback has persistent grants. Could this cost be mitigated by batching, and if it was, would it affect the tradeoff of memcpy() vs grant table operations? Alternatively, would there be any interest in an =E2=80=9Cunsafe=E2=80=9D m= ode for blkback that skips both the copy and the grant operations? This is obviously unsafe (hence the name!), but in many cases that unsafety does not actually matter. For instance, a Qubes dom0 can execute any shell command it wants in any Qubes VM via qvm-run. Much easier than trying to exploit some UaF or race condition =F0=9F=99=82. More generally, when t= he backend is the all-powerful dom0, trying to defend against a malicious backend is (at least in the absence of SEV-SNP or TDX) pointless, so one might as well not bother and take the free performance. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --L0eN+3MD/NWPHsz0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKG0VgACgkQsoi1X/+c IsHFIw//Uh5sIZUsANcp+T81YUAzTZZV5G+V1dktrmsETESPXsVrx8FpnVr3l0Us X+0Ny717o9Xxe9xZ8ER9OtFNa6CcDreaKisCyC4jyw6wVo6N7QRNRR/EdVpIBIZl cDMC5FzIcPTOkxkYeagixHfmIN+5dtBW/pEh1N907wLYu217DNG9hnqciP2PkzvP sVsaI48HMAGe68bbxcXmhT2h4tPaB6lucpfUKLC4/7TIRkTxxuRrMQKcUfNqeA0f WfEsRP+RzYq+qvHXXoMw44rTxmX0aXu3cq7dlpQsRVXpXVLZkGxbPieN+xmdJZS8 qaIxaY+tVcHgIbjCT5V4thTYYrjfNvwOywBKintrinPXvBfj5gSSGxItrh59ypWp n5/fH6TuhOkyQrLWkULbh6ow2wOYwpq8xij7TQb3ybE3vpspR5IwyLihXN2XwN1N 7E2iTQdZ6FuIE54ch1+5q48SZT6LCxeNGoFU8I1RarT4xCu66LYS0sjeQSsMbagy 5EXE/qMm2IdLXSwCHhKajHMUZ8aZ4bWH4yAKykPpJQEKnPFSlGcllq9SUbWptPPK 4IRH4k0ZBhpCEioaQULuphOlAmZAj+CBCM2wChOfgUXnb8Xf6SUAWXQfbGmSTMyA MKUOe/85yv3e2bS4oEWD3rfMRznt8gL6D8GS2Th2QJ8Gxh3bplw= =HO26 -----END PGP SIGNATURE----- --L0eN+3MD/NWPHsz0-- From xen-devel-bounces@lists.xenproject.org Thu May 19 23:45:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 19 May 2022 23:45:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333338.557148 (Exim 4.92) (envelope-from ) id 1nrppV-0004ZP-SI; Thu, 19 May 2022 23:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333338.557148; Thu, 19 May 2022 23:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrppV-0004ZI-Ov; Thu, 19 May 2022 23:45:17 +0000 Received: by outflank-mailman (input) for mailman id 333338; Thu, 19 May 2022 23:45:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrppT-0004ZC-Np for xen-devel@lists.xenproject.org; Thu, 19 May 2022 23:45:16 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9c952cc-d7cd-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 01:45:14 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-51qE-HMZMJ-_l5k-QlXFHg-1; Thu, 19 May 2022 19:45:10 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A41B685A5AA; Thu, 19 May 2022 23:45:07 +0000 (UTC) Received: from localhost (ovpn-12-42.pek2.redhat.com [10.72.12.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4ABA5492C14; Thu, 19 May 2022 23:45:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9c952cc-d7cd-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653003912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xcqeqNHBqLaEPFvaMSIdVsHM/2ssgjepqSc89Z+McDY=; b=HQ9a3tDxc88Fmu9vSqWBD3zMyyUqGM7Pfv4sBbu6gyG8SBJ52VeRpMEFuMsTX2IrNSwHKe fK7SmYbjvS34vhtDZ/AckHKpJsO+yTJ0/IbfoekwC3LuyzdLv0YfTg1gHsZ4rUMdvcfFE4 +wi6yzhXqsbhwbbQyLCN86WpIhakYPI= X-MC-Unique: 51qE-HMZMJ-_l5k-QlXFHg-1 Date: Fri, 20 May 2022 07:45:02 +0800 From: Baoquan He To: "Guilherme G. Piccoli" , Petr Mladek Cc: "michael Kelley (LINUX)" , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: <20220519234502.GA194232@MiWiFi-R3L-srv> References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 On 05/15/22 at 07:47pm, Guilherme G. Piccoli wrote: > On 12/05/2022 11:03, Petr Mladek wrote: ...... > > OK, the question is how to make it better. Let's start with > > a clear picture of the problem: > > > > 1. panic() has basically two funtions: > > > > + show/store debug information (optional ways and amount) > > + do something with the system (reboot, stay hanged) > > > > > > 2. There are 4 ways how to show/store the information: > > > > + tell hypervisor to store what it is interested about > > + crash_dump > > + kmsg_dump() > > + consoles > > > > , where crash_dump and consoles are special: > > > > + crash_dump does not return. Instead it ends up with reboot. > > > > + Consoles work transparently. They just need an extra flush > > before reboot or staying hanged. > > > > > > 3. The various notifiers do things like: > > > > + tell hypervisor about the crash > > + print more information (also stop watchdogs) > > + prepare system for reboot (touch some interfaces) > > + prepare system for staying hanged (blinking) > > > > Note that it pretty nicely matches the 4 notifier lists. > > > > I really appreciate the summary skill you have, to convert complex > problems in very clear and concise ideas. Thanks for that, very useful! > I agree with what was summarized above. I want to say the similar words to Petr's reviewing comment when I went through the patches and traced each reviewing sub-thread to try to catch up. Petr has reivewed this series so carefully and given many comments I want to ack immediately. I agree with most of the suggestions from Petr to this patch, except of one tiny concern, please see below inline comment. > > > > Now, we need to decide about the ordering. The main area is how > > to store the debug information. Consoles are transparent so > > the quesition is about: > > > > + hypervisor > > + crash_dump > > + kmsg_dump > > > > Some people need none and some people want all. There is a > > risk that system might hung at any stage. This why people want to > > make the order configurable. > > > > But crash_dump() does not return when it succeeds. And kmsg_dump() > > users havn't complained about hypervisor problems yet. So, that > > two variants might be enough: > > > > + crash_dump (hypervisor, kmsg_dump as fallback) > > + hypervisor, kmsg_dump, crash_dump > > > > One option "panic_prefer_crash_dump" should be enough. > > And the code might look like: > > > > void panic() > > { > > [...] > > dump_stack(); > > kgdb_panic(buf); > > > > < --- here starts the reworked code --- > > > > > /* crash dump is enough when enabled and preferred. */ > > if (panic_prefer_crash_dump) > > __crash_kexec(NULL); I like the proposed skeleton of panic() and code style suggested by Petr very much. About panic_prefer_crash_dump which might need be added, I hope it has a default value true. This makes crash_dump execute at first by default just as before, unless people specify panic_prefer_crash_dump=0|n|off to disable it. Otherwise we need add panic_prefer_crash_dump=1 in kernel and in our distros to enable kdump, this is inconsistent with the old behaviour. > > > > /* Stop other CPUs and focus on handling the panic state. */ > > if (has_kexec_crash_image) > > crash_smp_send_stop(); > > else > > smp_send_stop() > > > > Here we have a very important point. Why do we need 2 variants of SMP > CPU stopping functions? I disagree with that - my understanding of this > after some study in architectures is that the crash_() variant is > "stronger", should work in all cases and if not, we should fix that - > that'd be a bug. > > Such variant either maps to smp_send_stop() (in various architectures, > including XEN/x86) or overrides the basic function with more proper > handling for panic() case...I don't see why we still need such > distinction, if you / others have some insight about that, I'd like to > hear =) > > > > /* Notify hypervisor about the system panic. */ > > atomic_notifier_call_chain(&panic_hypervisor_list, 0, NULL); > > > > /* > > * No need to risk extra info when there is no kmsg dumper > > * registered. > > */ > > if (!has_kmsg_dumper()) > > __crash_kexec(NULL); > > > > /* Add extra info from different subsystems. */ > > atomic_notifier_call_chain(&panic_info_list, 0, NULL); > > > > kmsg_dump(KMSG_DUMP_PANIC); > > __crash_kexec(NULL); > > > > /* Flush console */ > > unblank_screen(); > > console_unblank(); > > debug_locks_off(); > > console_flush_on_panic(CONSOLE_FLUSH_PENDING); > > > > if (panic_timeout > 0) { > > delay() > > } > > > > /* > > * Prepare system for eventual reboot and allow custom > > * reboot handling. > > */ > > atomic_notifier_call_chain(&panic_reboot_list, 0, NULL); > > You had the order of panic_reboot_list VS. consoles flushing inverted. > It might make sense, although I didn't do that in V1... > Are you OK in having a helper for console flushing, as I did in V1? It > makes code of panic() a bit less polluted / more focused I feel. > > > > > > if (panic_timeout != 0) { > > reboot(); > > } > > > > /* > > * Prepare system for the infinite waiting, for example, > > * setup blinking. > > */ > > atomic_notifier_call_chain(&panic_loop_list, 0, NULL); > > > > infinite_loop(); > > } > > > > > > __crash_kexec() is there 3 times but otherwise the code looks > > quite straight forward. > > > > Note 1: I renamed the two last notifier list. The name 'post-reboot' > > did sound strange from the logical POV ;-) > > > > Note 2: We have to avoid the possibility to call "reboot" list > > before kmsg_dump(). All callbacks providing info > > have to be in the info list. It a callback combines > > info and reboot functionality then it should be split. > > > > There must be another way to calm down problematic > > info callbacks. And it has to be solved when such > > a problem is reported. Is there any known issue, please? > > > > It is possible that I have missed something important. > > But I would really like to make the logic as simple as possible. > > OK, I agree with you! It's indeed simpler and if others agree, I can > happily change the logic to what you proposed. Although...currently the > "crash_kexec_post_notifiers" allows to call _all_ panic_reboot_list > callbacks _before kdump_. > > We need to mention this change in the commit messages, but I really > would like to hear the opinions of heavy users of notifiers (as > Michael/Hyper-V) and the kdump interested parties (like Baoquan / Dave > Young / Hayatama). If we all agree on such approach, will change that > for V2 =) > > Thanks again Petr, for the time spent in such detailed review! > Cheers, > > > Guilherme > From xen-devel-bounces@lists.xenproject.org Fri May 20 00:08:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 00:08:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333347.557159 (Exim 4.92) (envelope-from ) id 1nrqC3-0007cw-0g; Fri, 20 May 2022 00:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333347.557159; Fri, 20 May 2022 00:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqC2-0007cp-Tq; Fri, 20 May 2022 00:08:34 +0000 Received: by outflank-mailman (input) for mailman id 333347; Fri, 20 May 2022 00:08:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqC1-0007cf-DD; Fri, 20 May 2022 00:08:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqC1-0002KC-B9; Fri, 20 May 2022 00:08:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqC1-0002x3-0N; Fri, 20 May 2022 00:08:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrqC0-0005GA-W8; Fri, 20 May 2022 00:08:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FO5/yEoSHSI0p+N14pUUF0eN9dMY/LNQE2rUreU7m14=; b=LjEseP4MLkNsljr6sp/fMGSJuK 0AmR6T6MbUFBSFN0ZhE23PhkFUjHEF8imcyFHsGvEOQl+y3sNqTku6ILYPy6BW9wZXel6sXBem4ZJ iugU8K7tEi5qUU4MoK0BIcGUSetqVbQ+BqqVYNoQtNB774HYDyq8L/6Gv3EQAU/X8cro=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170583: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 00:08:32 +0000 flight 170583 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170583/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1107 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 00:30:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 00:30:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333357.557171 (Exim 4.92) (envelope-from ) id 1nrqX8-0002Iy-RB; Fri, 20 May 2022 00:30:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333357.557171; Fri, 20 May 2022 00:30:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqX8-0002Ir-O7; Fri, 20 May 2022 00:30:22 +0000 Received: by outflank-mailman (input) for mailman id 333357; Fri, 20 May 2022 00:30:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqX7-0002IS-24 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 00:30:22 +0000 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04847c2b-d7d4-11ec-837e-e5687231ffcc; Fri, 20 May 2022 02:30:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 17:30:14 -0700 Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 19 May 2022 17:30:14 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:30:14 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:30:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 17:30:13 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 17:30:13 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by BN6PR11MB4019.namprd11.prod.outlook.com (2603:10b6:405:78::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 00:30:11 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5273.017; Fri, 20 May 2022 00:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04847c2b-d7d4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653006617; x=1684542617; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uGbVWzwOUCqloBLTEE9qFy9a6PxFR60HT2g9mikyTZI=; b=NYDAziuTQPMPRkF2+qos8bgZ5RMGwx+JJyI9WWnhrysRlWUceoFNZzOT 1jcbQp0KAttm4wKnP9y70NV1WN9k3Flm6oAs3l0k5MuwgqpMZ28zgplen zpuDae6OR1WBurk79C+dKv/wPP4mxLwOJt3kfwH083qmH8HJSfI+l5Nnp UHkorUD9iaKxt1dqjdphrXSW9Y+C5LSpBe7etL/kDRrFofwv+kwgTYcdv 67lQX46Su6GuF1YgNLaLPLbOZ7jk3uTYK0n02ZDWKQ9OTeC8miLSAurx8 d1IORAOjBZlpcIoKbI5LqWs2cKxvwhG7bnLe/BRFgjsMKSEES9gUzwKqi w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="335481201" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="335481201" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="606760549" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6dJKP5OVzU8paOtAZfZ2xvzUG6ceshLkgT6cWRfqREiUBwfg/AZFUV2P43PJRKX6tze2DPG2VtoAAOUMllYQ1W9omnWoqql5fjP8zGcyCSKcJ4SO1PAYPDBpD4Ce9YI9yvJgUkASsVBz65Xz7l3pZKHowyk4CXCOMJl7q9emrL1q7+A1OxUZmvNPcxUN4C7JLzPsJnmrSyDb4YYT6ei+QPxVMNYf4ofBdgN1IidwVxnLPuI+XEeSc/pnVrnEVJSV8OwpwazwVGUoNAHIj6Q2zfhum/61366vx59xE+LCKqpfpyHsXo7ht2tCS2OU0Zct861GBfTnBlzy8Olak7nvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uGbVWzwOUCqloBLTEE9qFy9a6PxFR60HT2g9mikyTZI=; b=IZBO2O5GBIF0wBOrxJUgAJ37+inNY7D2N3E3Ajx7GPchET6TE2xd8zBdwGmwmDKhscwBDtN5pbWnJl+BbtOyWEADDuTb1ZUuibprJWIBwauY4HAftrupVwh7cTXhM8AW/Ou1hJBUW+MuSxpKXg1fdmctTsjwscwvNg8W5vy5wk8MgsHDFD0nEAjE5NcHAZW5fhwfGzyW3FS0QZiTuwMFbhpG4bterQ1swerLHyngQvRnjdAc794lz2byADmhanM8u8f4+swJ8Xp+XBW+Ha6TiOc6pSY+Qc7h6DOuYMnWX/6GwlRA0ov0p9/XfUv7o9xFfdolENxcvx47hLc7nWLLVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Beulich, Jan" CC: "Cooper, Andrew" , "xen-devel@lists.xenproject.org" Subject: RE: Ping: [PATCH] VT-d: fix !HVM build Thread-Topic: Ping: [PATCH] VT-d: fix !HVM build Thread-Index: AQHYVi+q4CycUma8TECQ0Ag+stUm460mSTmAgADL0nA= Date: Fri, 20 May 2022 00:30:11 +0000 Message-ID: References: <431d4212-07b8-63d5-1a4d-7e8c7a9108ea@suse.com> <072cf387-f61e-919e-a0a5-7c767d91d99c@suse.com> In-Reply-To: <072cf387-f61e-919e-a0a5-7c767d91d99c@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a9e7e55-3f9c-49a8-3241-08da39f7e6b7 x-ms-traffictypediagnostic: BN6PR11MB4019:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n5hJTjXMmtiNH1Z1l/9iC4mEnH18KlcXT9SqO8NW6KOLEMmsR/k440WB+Jy3kNQkFGQOfbpcchbA6AmgEbbcSfcSRYbHd+1FSAY9TuW8Lv5Xyp4uZNCZzYas/oGFYyToU25RIXHeX2W06Yd9tCQ2kYr+owHbi/AQ6dQQU641/VF1EIa/SjwEUR8yRboDEh8z6Z6PWMaOTYtLptyeGzLhnD8qA0f7/2LMJLAkv5iYSWpMvn6xVU6bA5RFtnn6TTshMWbIOZhAobQ90LbC6guOnSkbz2T3cJ8qRtI9U4Hiofv5F7S3ZbYFOwg5BBy82nAovIa8ZGkXfAxPjwiANW7S7SjsFLlWrmxLm27wJ3eHIQQ3XNwQrn73Fjs823l1vRGNxWS+VEYuCz1Rxos8KUwpIPT72GZFvx7BFjBJeUbFwEyeD6TmdTLGq6YuHHP1rE5VYpGdK7gnvEObG8Qk8AS0w2Fd7eBVa4PwbA+Kg33eDoGfjguZccqdVXWC/jtllu8GAD1LMo/6LcvRpI2SyvlAAc+TG9+HYmRdWVg1JGYcfk5ELEtkCahGny3dp5n2wjiWe/LUALs5XMECfzAtXqlDXIoRuvWV/pyWsLoPVi1KY4tBOben4V6e9hBUkxP9pri9m7+nkNv7mqc3aB74ovBmrnOKj3mjydqXjqljKcMQ6y61vAroTmRUvOViigZKl7w2/zfnS05hPaDRDJpsWvQLvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(122000001)(8936002)(38070700005)(38100700002)(2906002)(82960400001)(52536014)(7696005)(71200400001)(86362001)(8676002)(53546011)(508600001)(6916009)(6506007)(186003)(316002)(54906003)(66476007)(66556008)(64756008)(66446008)(76116006)(66946007)(55016003)(83380400001)(33656002)(26005)(9686003)(5660300002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NWRnbHBZQlVaSnl6d3Fjb3pvMXdQdVRhK0QwOEtYY2NIWitMTytzWWZyb2NQ?= =?utf-8?B?S0dBY0lOUnBBTi9CaDl0aVJ0K1llWEh5aVdjYU9PR1F0OHFYY1cwWFk0Yzgw?= =?utf-8?B?U1drWDRqU0lraXQySnVVcll1TlNtZ0ZiT0JuRDFKRCt1ZHl2c21PWmJRQ21t?= =?utf-8?B?eWdGcWprNWlQZ05hWDNNZ1NKU2VnV3ptMVB1N1doY293NXFOTlo1K0dhTm1O?= =?utf-8?B?Rlh3cUsrTjNMZGZjZG9RaCtvUTBDc2tYTFZTZ2xIR3VibERWRnJ4Tm5Ubk94?= =?utf-8?B?TjBRMDJZVlh5Umw2VjJFT0NqbUVSRHpVZnNvSkVCcEhaaFVURnRXako5d252?= =?utf-8?B?VVJuS1BURVdqY09Pa0hUN1RzVzhqcVZ4L0ErcmZ5UER2b2wzZ3RISHBLemVt?= =?utf-8?B?Qjl5c2V5YyttUmRVbnd2K2xBQWdpakN3WE52NU9vRk5ERFNabi9WNmNYSmZF?= =?utf-8?B?WHZPdDJSOWhVeE04TTNqZWhjZVFDUS9oSmxTc01FK0lzRnRydTAwU05OUi92?= =?utf-8?B?UXhvOVltSHRyYlU1MHcrVnZhMHZONVpqMXpGYlB3VU1leVZHZFVWcHNxdlR4?= =?utf-8?B?YkhNcG96M1l0cXAxRGE5aWMyYTBoNWpHOUFDcWNoMVVQZk9zWW9YTU1XT042?= =?utf-8?B?RVI3SHFhbGhvUzJWbnR1NTZXdFFZQzZoOTFNQU1EWnFNaytDbW5JMjlNdkQz?= =?utf-8?B?U0VBWmp6WFhsaHNSWjhkUkNtTjJwakJ1MWxvdVpXVDY0SFVpVWVvSkY4aE9y?= =?utf-8?B?WnlKbVU5R1g5d2JnZkZLWGJQUmdJOHBONk9ZcjVvMEk4amdlU0IvVXZCcE04?= =?utf-8?B?WUczaTk5cVpMREQ3NnplaWllcGR4K2pPa0VwQnFQNFY4czNUaVJZSjNUNExU?= =?utf-8?B?dHRvSktIWnJFZDNKdEJjdkpzdjVXL1NNdDNnQ0xKSk1ZME5leFB4azMxcFpZ?= =?utf-8?B?cDV1UXFuNkE1K1IyeUI1K1dkK2VFUDVBYWxPVUQzNlVlanptZlBVSm83ZExu?= =?utf-8?B?WGhiRVYvNWs2ZVM3UlpBczNKR2x4Q0l6SjJVcThPS2hwWnI3d09BT0o5N1c3?= =?utf-8?B?bVBuVytOd04xMjZxRXBaZTRjVXR1VCtoOHNWMGVUblYvOU9BOWRuWFBia0RN?= =?utf-8?B?VHhiUVlPbk1BYzVIVDc3OGNoMnR0eHdHWlR3cEZuUmRQSG5oQ29YU0p4RnFz?= =?utf-8?B?Ny9aZEV5QmhxUUlLaVRDdzg4R2hKU2VnWTJZTG9PaDg4WnIwNTdaRnducm5V?= =?utf-8?B?L2FSeG1Yd092dnovdFNDcS9TTEpOak93cUI0alRSekZqcGpKU2x0RDI4OEdX?= =?utf-8?B?YXV3RHBoL3VTdDVyejBxZVUyOERGWjIyVnVkaWdhV1NTZjRyZ0dDa2lPY0N4?= =?utf-8?B?Y0JxQzNURUo0QkxTT1dpWjI5RTJqMHNtNGw3NHE0NS9CVGZ6aTJxYmtIQXBi?= =?utf-8?B?alN4cW1JemE0VGNSYm4rMnU1enJoNWExcFl4b2xZdVllMEZiRDFzai9UZjhH?= =?utf-8?B?c0IyY2ZBUWsvakgzRGVnYmJUS0x5RWJQWXBlK3EwWnYvMW1jUDcwSFBrdWdw?= =?utf-8?B?Wks4TzhQUE5iRzE3eHlmODlGM2RUUFZlSHVMTmtSbisveEtUQ3RHdktXUXpk?= =?utf-8?B?aDUrUGVxYUJ0T3h5OUtUMEFiTml0aVpHOEduSFh3MExMTDhwdGV3V3JCWGQ1?= =?utf-8?B?Q3Jyc2F3VVZqQ3VKdEFEZU1qODZkNXBBVWFMbmhTRVRDWVk2Uk9IdWM3UDFl?= =?utf-8?B?RHJ0b0tuQy9KOGx1QkxqbG1yTWt2eGwvM2pOY3RXWnFGUGc1RlQ0UDh2eHhn?= =?utf-8?B?KzRNdVMyckM0NlNEaVVoNWt4a2ZlTU9FVTZrRjI3SDN0MVBIR3k4amQxUWg5?= =?utf-8?B?Vi9XbEJHU01xUXJQRXp0YlY1VHIrTG1YQjBLdWN6WUpSd2xwaE5HcTQrNHpj?= =?utf-8?B?M29YL1lsOWI3ejNGazVYa25lcDhxM2VSN2F2TFNBaDZiSTBKbmpNejVMTFV3?= =?utf-8?B?dWlCVEx2ajJvLzNBeUI1c0NmbUp4TTVuSHJYVU9mR05OVnVqSEdwOGliUXA0?= =?utf-8?B?VVBrVWxjTlpxdVkzN3JsRElBMC9yVkhmTzZOaGZ6eHFzZTNBdTNtYVBKSm82?= =?utf-8?B?MGMvRlUyZjZ4aVkvWFB5djFBUlhUeUdJYXFQazl4YmhHelJBSlY3NHVCN0x1?= =?utf-8?B?ZnFvVUFiak1kK2IxbWV0d0VDb3A0RXQ1NVF0Y2s1T3U1NzZMUytJLzg2QlNL?= =?utf-8?B?NkdKRHZGcEFjNjNtWlZDMzUzajhHUkU5ZEVxUTVTS2dKMENwN3dCMkpscEho?= =?utf-8?B?Q0RvZjZyTHhOTnY4bGxBUjgxcVhSZ3FZVWtQUEViSCtkblRUODZodz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9e7e55-3f9c-49a8-3241-08da39f7e6b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 00:30:11.6348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mpr4QQXJnuo+iAovUa28pmy/M6ca7v8USSllGs/HixItRyjSyTJmIP+rO99zvtbd5CmobDS710blWoJENWxQFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4019 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5 LCBNYXkgMTksIDIwMjIgODoyMCBQTQ0KPiANCj4gT24gMjIuMDQuMjAyMiAxMTo1OCwgSmFuIEJl dWxpY2ggd3JvdGU6DQo+ID4gRVBUIGlzIG9mIG5vIGludGVyZXN0IHdoZW4gIUhWTS4gV2hpbGUg SSdtIG9ic2VydmluZyBnY2MxMSB0byBmdWxseQ0KPiA+IGVsaW1pbmF0ZSB0aGUgZnVuY3Rpb24s IG9sZGVyIGdjYydzIERDRSBsb29rcyB0byBub3QgYmUgYXMgZ29vZC4gQWlkIHRoZQ0KPiA+IGNv bXBpbGVyIGluIGVsaW1pbmF0aW5nIHRoZSBhY2Nlc3NlcyBvZiBvcHRfaGFwX3sybWIsMWdifSwg d2hpY2gNCj4gPiBvdGhlcndpc2UgY2F1c2UgdW5kZWZpbmVkIHN5bWJvbCBlcnJvcnMgd2hlbiBs aW5raW5nLg0KPiA+DQo+ID4gV2hpbGUgdGhlcmUgYWRqdXN0IHR5cGVzLg0KPiA+DQo+ID4gRml4 ZXM6IGM0Nzk0MTU2MTBmMCAoIng4Ni9QMk06IHAybS5jIGlzIEhWTS1vbmx5IikNCj4gPiBSZXBv cnRlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gPiBT aWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IA0KPiBJIGd1 ZXNzIEknbGwgcHV0IHRoaXMgaW4gKGFzIGJlaW5nIHNpbXBsZSBlbm91Z2gpIGlmIEkgZG9uJ3Qg aGVhcg0KPiBhbnl0aGluZyBiYWNrIGJ5IHRoZSBlbmQgb2YgdGhlIHdlZWsuDQoNClJldmlld2Vk LWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KPiANCj4gSmFuDQo+IA0K PiA+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ID4gKysrIGIv eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMNCj4gPiBAQCAtMjE1NSwxNCArMjE1 NSwxNyBAQCBzdGF0aWMgaW50IGNmX2NoZWNrIGludGVsX2lvbW11X2xvb2t1cF9wDQo+ID4gICAg ICByZXR1cm4gMDsNCj4gPiAgfQ0KPiA+DQo+ID4gLXN0YXRpYyBpbnQgX19pbml0IHZ0ZF9lcHRf cGFnZV9jb21wYXRpYmxlKHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11KQ0KPiA+ICtzdGF0aWMgYm9v bCBfX2luaXQgdnRkX2VwdF9wYWdlX2NvbXBhdGlibGUoY29uc3Qgc3RydWN0IHZ0ZF9pb21tdQ0K PiAqaW9tbXUpDQo+ID4gIHsNCj4gPiAtICAgIHU2NCBlcHRfY2FwLCB2dGRfY2FwID0gaW9tbXUt PmNhcDsNCj4gPiArICAgIHVpbnQ2NF90IGVwdF9jYXAsIHZ0ZF9jYXAgPSBpb21tdS0+Y2FwOw0K PiA+ICsNCj4gPiArICAgIGlmICggIUlTX0VOQUJMRUQoQ09ORklHX0hWTSkgKQ0KPiA+ICsgICAg ICAgIHJldHVybiBmYWxzZTsNCj4gPg0KPiA+ICAgICAgLyogRVBUIGlzIG5vdCBpbml0aWFsaXNl ZCB5ZXQsIHNvIHdlIG11c3QgY2hlY2sgdGhlIGNhcGFiaWxpdHkgaW4NCj4gPiAgICAgICAqIHRo ZSBNU1IgZXhwbGljaXRseSByYXRoZXIgdGhhbiB1c2UgY3B1X2hhc192bXhfZXB0XyooKSAqLw0K PiA+ICAgICAgaWYgKCByZG1zcl9zYWZlKE1TUl9JQTMyX1ZNWF9FUFRfVlBJRF9DQVAsIGVwdF9j YXApICE9IDAgKQ0KPiA+IC0gICAgICAgIHJldHVybiAwOw0KPiA+ICsgICAgICAgIHJldHVybiBm YWxzZTsNCj4gPg0KPiA+ICAgICAgcmV0dXJuIChlcHRfaGFzXzJtYihlcHRfY2FwKSAmJiBvcHRf aGFwXzJtYikgPD0NCj4gY2FwX3Nwc18ybWIodnRkX2NhcCkgJiYNCj4gPiAgICAgICAgICAgICAo ZXB0X2hhc18xZ2IoZXB0X2NhcCkgJiYgb3B0X2hhcF8xZ2IpIDw9IGNhcF9zcHNfMWdiKHZ0ZF9j YXApOw0KPiA+DQo+ID4NCg0K From xen-devel-bounces@lists.xenproject.org Fri May 20 00:35:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 00:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333365.557182 (Exim 4.92) (envelope-from ) id 1nrqbt-0002wa-Fz; Fri, 20 May 2022 00:35:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333365.557182; Fri, 20 May 2022 00:35:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqbt-0002wT-Bs; Fri, 20 May 2022 00:35:17 +0000 Received: by outflank-mailman (input) for mailman id 333365; Fri, 20 May 2022 00:35:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqbs-0002wN-OE for xen-devel@lists.xenproject.org; Fri, 20 May 2022 00:35:16 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b35e6168-d7d4-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 02:35:11 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 17:35:06 -0700 Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 19 May 2022 17:35:06 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:35:06 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:35:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 17:35:05 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 17:35:05 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by BN6PR11MB4019.namprd11.prod.outlook.com (2603:10b6:405:78::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 00:35:02 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5273.017; Fri, 20 May 2022 00:35:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b35e6168-d7d4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653006911; x=1684542911; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HrluVUIA/CwOYLY6YUDhzrkmIhpYwqc707q58L270KY=; b=O+YjzGagGjHWscc3Nyfzqiob67u/l0CLFS3ZmiSZ1jOgsgcaabeAyUjh ZV8gyfeZ1TTo6Rcpq93xo50r1PtGuSkPSvN4jRphSitZm9/g/1KXLr0s5 QAZOyK5v7sJFhsrT43hjACJSI2cibIU3uoRWALocd/x3+eMq1DwsNscxP nBOGrfZYVZY0dg4rQcmehg4DCgsWlA9ohbWbRT0PgK77fhJ/I44qV6nfF 9Zk/sPS+dXly39i/s49y/siAEZbLC09b1YVDz7rbm603Lud+JLy5iTfvP rXlpxWSIXbIk0EYgi7rQNn0U8Z0GoWWo/DsBxlEo5lJNOgRmyWO7ZfYww A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272133182" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272133182" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="606762031" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYcXLFNo+EHEFit04f2W0JNN4uSOFhoiFJIZcCESQU7Vg7SZXZ71/5pvPEtVIlFfbSkH3LTLmCQ8+u5j1qCZTjpSeH/sQ84wmcU7MLeL24+XG7sJdpPP5695Q3CaTkVQ+o/aVLL9+RIUYX9YnMKs1Hbh0J89dyk0mSdkKkdn8tms2jDNssKbzRMSzWrgtT2PsdQStrtlkQCA+djYHKmek7vMqrs8q1dbzrfuqt2OuEpqLsGVQ9BZO6K2mqj/QkyYg46bpnYEHBlA5o3eabt3/28QImyhk2I/62OM+OFEZf00ZNBSzE5M1FVbt6kUzi0n9akHqb0R/Vguo9Hazig2Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HrluVUIA/CwOYLY6YUDhzrkmIhpYwqc707q58L270KY=; b=jsSaAdUNnscUrtBZGIA5P+t+o/SCIt1j0+Yo+/Q5XQbmlWJpB4O0vhSXgrEJMGPI0abjmVR04Ux+LMSXIg6lEiYKOBMP3Yja6o9OUPLeyUT7s3FdaJSTBWd+aZvDRJqo2Cya1XIXTM+lpAWjwD2UEsEyQbTqE3mBOLG24AWoocD6It37TMuRNS+TvdNjD9UB3GCbDRx65Qgp2LqO2UAkd1a2NPb8HNae4ej764okC0kEKXaPFH+3SojWX5SOuCmCYB+L37s/qRBuvynge8r7xLHJ2qIbiRsQRxUHoUyd4zokte5rdWkjjvZRPS8SHQCpU/pcZiIzlHkvcj86DHyfdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: Tamas K Lengyel , "xen-devel@lists.xenproject.org" CC: "Lengyel, Tamas" , Wei Liu , "Anthony PERARD" , "Gross, Jurgen" , "Cooper, Andrew" , George Dunlap , "Beulich, Jan" , Julien Grall , Stefano Stabellini , "Alexandru Isaila" , Petre Pircalabu , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Nakajima, Jun" Subject: RE: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits Thread-Topic: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits Thread-Index: AQHYWkxRftUbU7b5kE+JHC0++cT1y60OvK8AgAycPYCACYL7gIACMivA Date: Fri, 20 May 2022 00:35:02 +0000 Message-ID: References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6cb3ac08-f1e0-4202-4cd0-08da39f89425 x-ms-traffictypediagnostic: BN6PR11MB4019:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QQEXLJCF8o1i18tkTLJ/EvvCiA/XUV6D59Z4w3CRXo1ZvPW3G9Vbxrrhs/1Q2fyf4QAkTHta+FVf79JilGFN+/lTvdO1AMc2T84GF1cy2o4S7HczIra+vnrMS0Mp5fspBDmCd4N20NRBdnq3dI4moMCh5c+LizMVhl+R9njNjq9YriMJnxvb1J3vHnj1eGHXhc9fDdeDp0SgiXSSd1oM2cj0CEaNhYv98e+OQf4YuvDphMsRzeGjlBhwKI0onLfCcROXQQZpZkkRMc49tCkz+rXQHBtqpN+2rGoqt29zj/VKYMKHJZMcmjA8vKO6/Sem7y4KjukDmKlMEEFkhuUIormwBbJiHBfOzHCDHtQLWa+KbzU4TQg0lfRnnvmVqCVy3pUcXygq+TyWIrQULoj3xhm2agTpTqHEfU98zjH/C438FrGPI9+tbludLFZeVi0KyZvE9wjPNIPPBqqZcMcRkjKbQxvo/bF/8BE+e8caaIIeH6kzdJjFe6T1JhvIOdeWDqsFEoZoquLI/qZDQEXCtoGKg/UevkhZBlvulXp3+qD62X2FwR08K2fCccWqOnU1qppMzzLpVVVXvutSCFSGRImVGJY3EKcbg1AFHbsJs7kYIcM5cvreCXv+Pcc7/nfrjKobT62uz8EJ5TaDS+BgPhXYCJWUEcTrx8CmmTibluGXcT25ThRkyO779FaIznvtojhIWjhloPH4F4EUaBHlWg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(122000001)(8936002)(38070700005)(38100700002)(2906002)(82960400001)(52536014)(7696005)(71200400001)(86362001)(8676002)(53546011)(508600001)(107886003)(6506007)(186003)(316002)(54906003)(66476007)(66556008)(64756008)(66446008)(110136005)(7416002)(76116006)(66946007)(55016003)(33656002)(26005)(9686003)(5660300002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZExzblZGSjdmQjZndlJmc2NtSnpObkllZGpqR3RTRkJNQlUra1VRVTEzdjdu?= =?utf-8?B?OVl6bEU0QXBUZUNtb3pwbDBYeWc4Vy8xUHpSdGlGWENuNlc2eFRNeFQrOGFn?= =?utf-8?B?MjU1NUpwSU1jQjlBZjhpcWpsQkZHQVlIZGhPVldoOFNRUWIzd3laUGhEWnA4?= =?utf-8?B?d2sxbHJhVC81ZVQrUW53T2w3U1BnVkVvU1YwYXRvWHR2dlY5c3M0Q1NiZXpC?= =?utf-8?B?TEFtVlNSZzVSM0lhU3R4VnRKUTJFSnR1WWdaSmMvZU5PQnV6TVp0dFhldWVW?= =?utf-8?B?R2FpbFhTMW1qNElHZC9lRFB1R0xmWGJHR29TOGdSZDRlV3VXT3FEd1AzTzhF?= =?utf-8?B?OFp5NWJWdkZLOUpWeUUwL2UvSHZ4Y2p5VGFNRUhnbFcvUExSMXp1Z3lZdGlH?= =?utf-8?B?eitFRmUxdmZ0QWNRS01RQ2ZTMXBVdE9OQkttdXdzWmtNR2o1TFlSWG9JVWpF?= =?utf-8?B?Y1ZBbVJ2NEEwVlhob0QyNEhHZU52TzNYc1ZyK2FnTVZSWm8reklncUh3NFBS?= =?utf-8?B?QUlKVU1hQjJwcVJsb2ZSd3c3MG95RDN6Y3RYRGlaWUxBekZWN0wwakVpSFE4?= =?utf-8?B?cDNlKzR6Y2JuVGIyTy9qZWFFZUVxVVJwRFVwTWtDNWVCbFpSNHpVbkpFWVgr?= =?utf-8?B?aDYvTllRWHRncS9wM2M0ekYyME1jbkNDR0VDNFc1R3VnMmFIb1F1NTdZdUo3?= =?utf-8?B?MW1qNFNBcUk3TEdmbElpSGtNMzJEc1dXUGIwMEQ4NzBwN0NVRC96bXVHMmxk?= =?utf-8?B?K1hDZWM3NlZVV1oxcjFqZGhaTlZxYlBud0RGWTF1N3BZTTQvQWZnMFZIVnpG?= =?utf-8?B?U2FWaE41WG5PeWJ2UXRFd1d2bDAyeCtJSTdhTm82ajRRbVh5QXNiYzBzMG9k?= =?utf-8?B?b0NZZ2FZVldIUHhidXFlV29SakR6RWsxbzJxUy9JK3NmWVdjV28zcE54QzdV?= =?utf-8?B?TE9DVlUvZEdNV0VwN0VIMDMxK2NubVlkbjhZb0NVaThpVGF0RDVXaXMzeUM0?= =?utf-8?B?QVNuRHArZzNneUZ5U29LS3NDSjRxRmpBRmkwcTFCaUFhMFpoQ05KcGloQWN4?= =?utf-8?B?bkVBb2YyQ0pKdGorOTJaWHRnRWlUTStsT0c2RDRmdTN6b0Z1VGlSb2JseVdy?= =?utf-8?B?NFRIK2YyaVRRcmdTUnFnWkV4QXJwSEhwVWpla2dVVWZ2UU5pejRuS2dsZ0Nw?= =?utf-8?B?dlluQklETFZidlNHa09ueDdkZEVIYXlSSGNsTW5wRUtLaHVJOVd3UVZycXV3?= =?utf-8?B?MTZheUdZSTFJbkdHYkw4L0JhaVl0RHJsczh2Wk51VnBDdlE4bU9TR0hFVjF0?= =?utf-8?B?SHc5WWsyU1huckZqSVM5Mi84VHp2cUJVdU9nZU9rR2tDdGZzQTdPSlFRUlhn?= =?utf-8?B?Z0JPYUgzYXhnemVYM25SOWF0WFArZ0hUZU5kSU44cXN1ZS9ZWG1zSi9JTGNP?= =?utf-8?B?cStqOGdkS3E2d2ZqZlV4ODEzS2d1T2JuTXJ5eFEweW5SN1F4dXhSem4zM3lj?= =?utf-8?B?Ykx1NmZjMUJzRGovY1plcm0yRzA3QUhPWHR5Y3pNZFEraDZqQ215QTBFRkw0?= =?utf-8?B?b3RBWVA2NDRIS0VpTXl6cG9PME5IaFRuME1BUFlYVUN3MVNRTmZVV3c5V0Zr?= =?utf-8?B?NWJVaW9KMnBGa3pRSlk4N1ZsbXhRMlMzK3hBZEwybE9iRmFGRnFxRThRc0Vw?= =?utf-8?B?N3VGSy9TL0RKWTB1R24xVzlITldQNnNKdHp2eTJQUVlYN2VWb2w3VHZYTkxx?= =?utf-8?B?bVpibjFKWWFxYTBPdG9LTVlab01tQUZ0UVZDclF2Zm0xNEJCaHBXQ3MyaDZt?= =?utf-8?B?SU5UUXBXbm5UMTJKY1QzQVorR0tqRks0OWhGOFFmZUJDdjE5OUJrd0FNZHlG?= =?utf-8?B?TytUeGRMU3p6Y0gvUXF6T1U4VW1GMzFDd0hkckthbkM5RWRiQ041VGxaVjJ4?= =?utf-8?B?SzRlZG1Fdzh1RVFXQis1STlmczI5T0Vyb0FxVHo5Nm1NdnpNZG4rSDkyZXRt?= =?utf-8?B?ZXlDakorUEdvWnNnV0NWZThOdlV1dzZWUFo1NVRrQzRuc1BMNDF1VnJJUGRq?= =?utf-8?B?TzVVeFZFWW8wQmtlVEpKU3lLNFdYRzg1RVRvTUJrdnRuOG1TSGxLR21vYVhj?= =?utf-8?B?azF0SVNDVWZ5NVJJNFY5R09uQm9NdWdXUmpJTUhxbjBXZmFLNjQ0aEFRbnJr?= =?utf-8?B?RmV3UEVXRFJVT0cyaWdlajRGVDBJUm41STNXTzFKcXlkK3JBMU5MaHhwYkMx?= =?utf-8?B?czJHemJkVmNjdnljanAydGs1endqb0hpTnNBcnpaRGRmWVJWSFU2YUx4bHlF?= =?utf-8?B?WjBnZnRaWVpIaGQwek5tRTNCVnowU0JncVk3SlF5SEl6bVBwR01nZz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb3ac08-f1e0-4202-4cd0-08da39f89425 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 00:35:02.6179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6cc2h7IXHwgITAv39C+77EInWPffUB3QUEPPFv0X4U54y7Xbo+E7G6Y0aH8FLLWjpWWK2T6fCOrVslpdyu1fMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4019 X-OriginatorOrg: intel.com PiBGcm9tOiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzQHRrbGVuZ3llbC5jb20+DQo+IFNlbnQ6IFdl ZG5lc2RheSwgTWF5IDE4LCAyMDIyIDExOjAyIFBNDQo+IA0KPiBPbiBUaHUsIE1heSAxMiwgMjAy MiBhdCA5OjQ3IEFNIFRhbWFzIEsgTGVuZ3llbCA8dGFtYXNAdGtsZW5neWVsLmNvbT4NCj4gd3Jv dGU6DQo+ID4NCj4gPiBPbiBXZWQsIE1heSA0LCAyMDIyIGF0IDk6MTIgQU0gVGFtYXMgSyBMZW5n eWVsIDx0YW1hc0B0a2xlbmd5ZWwuY29tPg0KPiB3cm90ZToNCj4gPiA+DQo+ID4gPiBPbiBXZWQs IEFwciAyNywgMjAyMiBhdCAxMTo1MSBBTSBUYW1hcyBLIExlbmd5ZWwNCj4gPiA+IDx0YW1hcy5s ZW5neWVsQGludGVsLmNvbT4gd3JvdGU6DQo+ID4gPiA+DQo+ID4gPiA+IEFkZCBtb25pdG9yIGV2 ZW50IHRoYXQgaG9va3MgdGhlIHZtZXhpdCBoYW5kbGVyIGFsbG93aW5nIGZvciBib3RoIHN5bmMN Cj4gYW5kDQo+ID4gPiA+IGFzeW5jIG1vbml0b3Jpbmcgb2YgZXZlbnRzLiBXaXRoIGFzeW5jIG1v bml0b3JpbmcgYW4gZXZlbnQgaXMgcGxhY2VkDQo+IG9uIHRoZQ0KPiA+ID4gPiBtb25pdG9yIHJp bmcgZm9yIGVhY2ggZXhpdCBhbmQgdGhlIHJlc3Qgb2YgdGhlIHZtZXhpdCBoYW5kbGVyIHJlc3Vt ZXMNCj4gbm9ybWFsbHkuDQo+ID4gPiA+IElmIHRoZXJlIGFyZSBhZGRpdGlvbmFsIG1vbml0b3Ig ZXZlbnRzIGNvbmZpZ3VyZWQgdGhvc2Ugd2lsbCBhbHNvIHBsYWNlDQo+IHRoZWlyDQo+ID4gPiA+ IHJlc3BlY3RpdmUgZXZlbnRzIG9uIHRoZSBtb25pdG9yIHJpbmcuDQo+ID4gPiA+DQo+ID4gPiA+ IFdpdGggdGhlIHN5bmMgdmVyc2lvbiBhbiBldmVudCBpcyBwbGFjZWQgb24gdGhlIG1vbml0b3Ig cmluZyBidXQgdGhlDQo+IGhhbmRsZXINCj4gPiA+ID4gZG9lcyBub3QgZ2V0IHJlc3VtZWQsIHRo dXMgdGhlIHN5bmMgdmVyc2lvbiBpcyBvbmx5IHVzZWZ1bCB3aGVuIHRoZSBWTQ0KPiBpcyBub3QN Cj4gPiA+ID4gZXhwZWN0ZWQgdG8gcmVzdW1lIG5vcm1hbGx5IGFmdGVyIHRoZSB2bWV4aXQuIE91 ciB1c2UtY2FzZSBpcyBwcmltYXJpbHkNCj4gd2l0aA0KPiA+ID4gPiB0aGUgc3luYyB2ZXJzaW9u IHdpdGggVk0gZm9ya3Mgd2hlcmUgdGhlIGZvcmsgZ2V0cyByZXNldCBhZnRlciBzeW5jDQo+IHZt ZXhpdA0KPiA+ID4gPiBldmVudCwgdGh1cyB0aGUgcmVzdCBvZiB0aGUgdm1leGl0IGhhbmRsZXIg Y2FuIGJlIHNhZmVseSBza2lwcGVkLiBUaGlzIGlzDQo+ID4gPiA+IHZlcnkgdXNlZnVsIHdoZW4g d2Ugd2FudCB0byBhdm9pZCBYZW4gY3Jhc2hpbmcgdGhlIFZNIHVuZGVyIGFueQ0KPiBjaXJjdW1z dGFuY2UsDQo+ID4gPiA+IGZvciBleGFtcGxlIGR1cmluZyBmdXp6aW5nLiBDb2xsZWN0aW5nIGFs bCB2bWV4aXQgaW5mb3JtYXRpb24gcmVnYXJkbGVzcw0KPiBvZg0KPiA+ID4gPiB0aGUgcm9vdCBj YXVzZSBtYWtlcyBpdCBlYXNpZXIgdG8gcmVhc29uIGFib3V0IHRoZSBzdGF0ZSBvZiB0aGUgVk0g b24NCj4gdGhlDQo+ID4gPiA+IG1vbml0b3Igc2lkZSwgaGVuY2Ugd2Ugb3B0IHRvIHJlY2VpdmUg YWxsIGV2ZW50cywgZXZlbiBmb3IgZXh0ZXJuYWwNCj4gaW50ZXJydXB0DQo+ID4gPiA+IGFuZCBO TUkgZXhpdHMgYW5kIGxldCB0aGUgbW9uaXRvciBhZ2VudCBkZWNpZGUgaG93IHRvIHByb2NlZWQu DQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFRhbWFzIEsgTGVuZ3llbCA8dGFtYXMu bGVuZ3llbEBpbnRlbC5jb20+DQo+ID4gPiA+IC0tLQ0KPiA+ID4gPiB2NTogd3JhcCB2bWV4aXQg ZmllbGRzIGluIGFyY2gudm14IHN0cnVjdHVyZXMgaW4gdGhlIHB1YmxpYyB2bV9ldmVudCBBQkkN Cj4gPiA+DQo+ID4gPiBQYXRjaCBwaW5nLiBDb3VsZCBhIHRvb2xzdGFjayBtYWludGFpbmVyIHBs ZWFzZSB0YWtlIGEgbG9vayBhdCB0aGlzPw0KPiA+ID4gVGhlIGh5cGVydmlzb3Igc2lkZSBhbHJl YWR5IGhhcyBhIFJldmlld2VkLWJ5Lg0KPiA+DQo+ID4gUGF0Y2ggcGluZy4NCj4gDQo+IFBhdGNo IHBpbmcuDQo+IA0KDQpJIGd1ZXNzIHdoYXQgeW91IHJlYWxseSBtaXNzZWQgaXMgYW4gYWNrIGZy b20gdG9vc3RhY2sgbWFpbnRhaW5lciwgYnV0IGFueXdheToNCg0KUmV2aWV3ZWQtYnk6IEtldmlu IFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0K From xen-devel-bounces@lists.xenproject.org Fri May 20 00:38:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 00:38:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333374.557193 (Exim 4.92) (envelope-from ) id 1nrqfI-0003dk-4I; Fri, 20 May 2022 00:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333374.557193; Fri, 20 May 2022 00:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqfI-0003dd-0L; Fri, 20 May 2022 00:38:48 +0000 Received: by outflank-mailman (input) for mailman id 333374; Fri, 20 May 2022 00:38:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrqfG-0003dX-Tr for xen-devel@lists.xenproject.org; Fri, 20 May 2022 00:38:46 +0000 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3369c66a-d7d5-11ec-837e-e5687231ffcc; Fri, 20 May 2022 02:38:45 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 17:38:42 -0700 Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 19 May 2022 17:38:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:38:42 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 17:38:42 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 17:38:42 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by IA1PR11MB6243.namprd11.prod.outlook.com (2603:10b6:208:3e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 00:38:40 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::24dd:37c2:3778:1adb%2]) with mapi id 15.20.5273.017; Fri, 20 May 2022 00:38:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3369c66a-d7d5-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653007125; x=1684543125; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mZD+eysfE5wzUcPQkxrPInegcpLTHXSHQSGYSuJL1wo=; b=H75K/U7GEZms01nXqE4LqZsDxQzVZt0o8CZCQ5EFSRAbvMovsBLCbkcA 9qT6VcL+NgrrzBvs9+vFOAA/JEUHHHo5DlSVTPmUimBBidnhhOahNnSes QGOgdpHeEqVWKM7TMQ85+MjCaOgv01jdBCLo7UKHsPtR4iqsSyH6zpp7t neVN5HSixcVqQmo1A2fPdducg7mwe6qlcJ5xLssepm1t3M1iLAbjNUu+m SVtYwEx8JJFUzRrgKZNJwbLiI1rW0Dz2T1Fx0HhZjJ1ejFyEIeVn1/N7Y ofuVJ0xHYS50R7k0LsSCh3ofhkeLn1yyteR2yoOIowJTNUNXwl4GKc2Ew w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="252948632" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="252948632" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="674345195" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ih1QUnV0kzPdfUjNHMtuVarG5CU0vNtk9XkS7PDryAVtoaS6auEDA2hIVPfv/rE4lmkV1h/3CU8w2aYaWtFYltoupyzHGFZzt6g9Li6D0dLPElTjBtZMSvWzWzgSlMo3JmioIyoSbJUUl4QpCO2Mcbyyacyw9J1/zQ2suR116DhCBU/f8bqUQIdcaxGKfByunAay9CFug/CxmKIF+kwIUBKG8Jn/avtikg6QRIJPQkeFm0hAZ1BZQI7OR4Yeh5yZNmO4pTscirgrTjyn2jwGt8mS5W0rjStK1HJE79S54ABiEmLVv5eF7aCRI7HxPR9n9lqqfXLCVGidiAc31xLqDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZD+eysfE5wzUcPQkxrPInegcpLTHXSHQSGYSuJL1wo=; b=lSQ1JSBx0A3pcdI/5u1py4aoZrWpcPDuyIZNzoI1MFgMaA0YPFC0rLcwTQJAYASy2op92HfOjluBqtj+Y54UHzJTmlZ42Syo76YbkiMgNGldq7G3QVzQSDJn9BBqRySSlNt0npfTe2dSL5eFgF1IBo8gn/IlKduc/FQu5pMDM8cYy2xlQQmr1AFTjfzqZK0zCiEGL7+hYDI+j3eUZi5mg6QGNpXllTWrbbokNHfto5YUtQQYXxwyGYa4UmxtDCt3Zm7GGPkJCS3ps0R5/m1BB7BzLVs+2I9/ojLbKxrNK0KBWfjR4KefoZmYRfjub1RPPTMQD1RFXD/KxjSUlbLT9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Beulich, Jan" , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= CC: "xen-devel@lists.xenproject.org" , "Cooper, Andrew" , Paul Durrant Subject: RE: [PATCH v4 16/21] VT-d: free all-empty page tables Thread-Topic: [PATCH v4 16/21] VT-d: free all-empty page tables Thread-Index: AQHYWIB55LiJis4LlU+Of8jQSBwnua0YQ++AgAxOaYCAAoAxgA== Date: Fri, 20 May 2022 00:38:39 +0000 Message-ID: References: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> In-Reply-To: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 896e22ff-bca1-4b5a-2b28-08da39f915aa x-ms-traffictypediagnostic: IA1PR11MB6243:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3RNguWbfysyVjamhfvA1v+OtR2cd3VzrzDS2fdE2fnBuqjTtliUYUNpykDtGCUzgI6jWoZrddH7xPzd6UbOehTBE6pXNmmG81rOAKlMSLekl28sqYL6bpX5tU6EduBoeX8Pr3O352rgZHUU7kHZKae0l88lxXUv+If0ZAjcGOq3brzL9Hl/hG3suOKecmdzSu0jpDG+QrMIXMnfs7Y+NBal/Wpm7qTDcek4Ohirq3UcEVoGtGr22QEXF9rkj8N6dknxaRtqjQqNr6ZBxNu3oe769ynC/9m8yG9/fXT/WKd6pjQ3d4EzEGAeLAIDScsfJx+TcwpPVKfeQbc77DVtuolQsoazuNii1+njt0kLW5vlC1L1TDKiwmRjAs6d7raW9ufbog1Is+GB8erSO5X/loCi47dcAexZGugso3yKU8G6HnruFVOw1eKFaXWl8UFlb+AZnBAxopaB9UONrQhSrC5/MSCliCNLZOEGYMAXpWkimtd8F8+471Bd0NTwzFlvW4S6ryXKiKCy1e1H68n6T9ieLAGeRWerkfYA7GegfR41aXWbspbxY7l/U4F53cwDW3O1Npa7lWEMyX9hLy2fwCt4tAhCjZvOh3tt3z6+tvfA8A3mz/yx0/NDed7PAzX1q73F9lbFJWqmUp1JPDCZsbmizZu7KQqs3POJwE5H0QLlYjE6PcYgy//GKTf5D6CvoJmccwTLSkPykfmoWxD4J9A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(7696005)(6506007)(53546011)(8936002)(2906002)(33656002)(52536014)(9686003)(26005)(55016003)(38100700002)(64756008)(4326008)(71200400001)(508600001)(66476007)(86362001)(82960400001)(66446008)(76116006)(8676002)(122000001)(38070700005)(66556008)(83380400001)(186003)(66946007)(54906003)(316002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RkxuYTdiV3ZBRE5qVm9zRzh3OHRrMlMwb202aU83Y1l3UjBhSWJnMTNCaE9r?= =?utf-8?B?YzZiak5TYzhtNzZKNGxuSmRtanR2RWtpcE9vb1ZUL1NxV2FCZUpqS2VXU2I1?= =?utf-8?B?Q1haQVJJRzJaaFMyS0lTeldSRkVxRVNCTXhsWllHVERHTXJZa2loY0hqOU9S?= =?utf-8?B?aE5kd3dpZ1FqT2p1SW85NDFHcDFXK1dVbXROREJLNXlocFNEWEUxTDA5NkJ4?= =?utf-8?B?Nk12bjFjSUFDTk41SFhNd291SzVDVFdQWDZrZjV4d25GaG5BT1h1RkRVUzU2?= =?utf-8?B?T2lDZnVYRmRsQ0hiMnpsZzZKaVhEaU1BU2VKYkJNbnBMYmtXUkVkbEl3TTJo?= =?utf-8?B?UGlYK2EwclE0RXhqOHJUbHJGOUlER0l6WUsyRnpWbHBVQk1OTVhGS1N2eHBP?= =?utf-8?B?RVVXQ1kxMFlHWEM4N2RkQXM0QmFQNHFNQVhwNVYrQXFMYW5odFpZL0ZYSWNO?= =?utf-8?B?RU5ZTW1tZEdmdW5vcnlES3NqaUhCeXIwNXE0c3NZQ203S1JEQWl1ZHY0ZlIw?= =?utf-8?B?elcvWmo3T1RIQXhxeVlXMy8vblNjYnR4SThiQlV4bXkvZjNJZEFEenMrZjVq?= =?utf-8?B?RDYvREVyNlI5dEJuNkl6NlFGRVN3bUhqRUVGNko1Yis0UGJJeDNKWWNIZWJo?= =?utf-8?B?Sm5XaWs1dXRDdndrSmVLSWJKaUdNd1ZxTkNFNGQrZlhmdUVQQ1VZNG85enp6?= =?utf-8?B?QWVEU0wrSzNpelFyUHNqZDRuWDZSbFNzVTZKWUZYWWhBU3M2cFVKNGV5UEFZ?= =?utf-8?B?TEpTcjhxbEJ6czduT0t4bEVrdzVXUENjdDJSeDRheTFpZUQ2czRYalY5NlNs?= =?utf-8?B?cjZGQU1SVGEwOXNReWM2V0p6RmtxenIzSkJqdlFjYnlyNlVtYnMvVFJIM1dC?= =?utf-8?B?ZGV2MGNlVnNDNzR1U1JUL2VlenRNWUQxVUo2QzJmVWhnM1VXVHJreFE2dHBO?= =?utf-8?B?eVlQY1MvUkRFRWljOXZ4TlA3eDRLaHA4SkllNXhONkw0N3Y4S25QY1ZkU2pX?= =?utf-8?B?VFN4dDZZTy9xblBHOXlraUxpT0t3aWJGUGxJbFBaYzFNVWZFUk5rQ3RIeFA3?= =?utf-8?B?TWZOVlRQckZQZWNjWHBlNVNtZWJjZkRoOVNqbUVORVBkTFhCMTBYdjh5OFBl?= =?utf-8?B?S3NLV1poUGJmWmdkNFYyQjI1RTdpd0FtS1RpNHdsN1ZweEJkN0xJSFlLRE9u?= =?utf-8?B?cERGU2JBd0R5b2hWSkFZM1BxTmlyNFQwR1REWWpPclJ0ZjUwZFEzVW45dWMr?= =?utf-8?B?WDAzM05Lc3VTdTFUcXdvZ3dac1kzUXZIMmpET2NvSVVLL1Y0Yy8zWnNiTEk0?= =?utf-8?B?Qkk4anVQVnNac2hlVjRIaUkyWEFPZ0pCWkZoU3ZIVHNjS3dIWXdzcVd1bERa?= =?utf-8?B?dGhZTXJjbnE5YlZpWExDSitvTlFqQ0VXa0pickpka0lURDA4MUlZRHpaNmFO?= =?utf-8?B?MHNCVnZkNkxvQ3YweDZ5S2pxcXJYeGlaZjYzdGJrSVV4d2JnbDBIY3R4Zlpu?= =?utf-8?B?NThDdjdJTSs0VzNtNnU3TkFrR1BRQU5lL2tPU0J0QjZtb2VlRUZheW1JcDhj?= =?utf-8?B?OWNOOVFGZTBvbXk5VmIwTE1kMHc5UjdMVVNjWitTOS8zV0JUNXhlVnpka2Zx?= =?utf-8?B?NzIzTmVIZUR0S2F6ejR6SWpiQW12WkNiTUxJV3U0bnB5eDdGSUk0cmJLU21J?= =?utf-8?B?aUFNWjFpdzJKQm1BM0ZiMHF1QitZS2FuQlhQOUh5cGlvUnlCSHNVaWhkYnNL?= =?utf-8?B?SnJXeTE1TUpDcW4vTHVDTUViT3F4ZHA5V3l2UXNnbGh6YjJCdjUzL2cxdEh2?= =?utf-8?B?aCtXcndOK0llVkRoRE9NRGJ3WWthUnlEQzR5QjlWT21ZS3AzdC95Vk50QTdi?= =?utf-8?B?Vm9mWVcvdkQxc05WMzNIU25TL0tRRTB6Q1JteFZkOVQvS2c4RUhzN1hkUUxL?= =?utf-8?B?Zk45K3IwM2pNbFdCNnNKLzUvcTV4eTNLRGZQWStQSFQxMExHOElGSDNxNloz?= =?utf-8?B?VHVVd3FvVk5ESmJnbEk1dHdwTUQxektLSDZBallVcTdZL0lTVUdlb29BL2ov?= =?utf-8?B?NXlaMEhIOXovblh1VEZKR1ZiV242a3hvRjNnRHpuRjBTNDBxdlJMcXlDWVMv?= =?utf-8?B?c0V2WmFsdy81eEorOUdLSERDMngyMm54RVhmdzl4dnhOS1cyQWMzRGlwWUZP?= =?utf-8?B?b1JQSWpQOVVsM3hQU2lpRXF4aklRMU9QWWltWGNQMGpTMlhzRGxUd3pTNGpr?= =?utf-8?B?QWRyMDBDczJBbmtRSysrT0t6M0lTVFprczh1b3Q1aUdNT1pTSlpxUGQ4TVow?= =?utf-8?B?Rndyakt6U24zYnF4WEwzRnVFdTdJeUc1Q29jL3V4M05Dc1h3ZXg0Zz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 896e22ff-bca1-4b5a-2b28-08da39f915aa X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 00:38:39.8510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UFkOQY0TYn9APO8Yq5gN361JifNxwrkmXedlasnvB7NXsxDaLP3FA+Pc6Zq7pk1KMnnXHiHIim/a6ddcNXKK5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6243 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaA0KPiBTZW50OiBXZWRuZXNkYXksIE1heSAxOCwgMjAyMiA2OjI2 IFBNDQo+IA0KPiBPbiAxMC4wNS4yMDIyIDE2OjMwLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0K PiA+IE9uIE1vbiwgQXByIDI1LCAyMDIyIGF0IDEwOjQyOjUwQU0gKzAyMDAsIEphbiBCZXVsaWNo IHdyb3RlOg0KPiA+PiBXaGVuIGEgcGFnZSB0YWJsZSBlbmRzIHVwIHdpdGggbm8gcHJlc2VudCBl bnRyaWVzIGxlZnQsIGl0IGNhbiBiZQ0KPiA+PiByZXBsYWNlZCBieSBhIG5vbi1wcmVzZW50IGVu dHJ5IGF0IHRoZSBuZXh0IGhpZ2hlciBsZXZlbC4gVGhlIHBhZ2UgdGFibGUNCj4gPj4gaXRzZWxm IGNhbiB0aGVuIGJlIHNjaGVkdWxlZCBmb3IgZnJlZWluZy4NCj4gPj4NCj4gPj4gTm90ZSB0aGF0 IHdoaWxlIGl0cyBvdXRwdXQgaXNuJ3QgdXNlZCB0aGVyZSB5ZXQsDQo+ID4+IHB0X3VwZGF0ZV9j b250aWdfbWFya2VycygpIHJpZ2h0IGF3YXkgbmVlZHMgdG8gYmUgY2FsbGVkIGluIGFsbCBwbGFj ZXMNCj4gPj4gd2hlcmUgZW50cmllcyBnZXQgdXBkYXRlZCwgbm90IGp1c3QgdGhlIG9uZSB3aGVy ZSBlbnRyaWVzIGdldCBjbGVhcmVkLg0KPiA+Pg0KPiA+PiBOb3RlIGZ1cnRoZXIgdGhhdCB3aGls ZSBwdF91cGRhdGVfY29udGlnX21hcmtlcnMoKSB1cGRhdGVzIHBlcmhhcHMNCj4gPj4gc2V2ZXJh bCBQVEVzIHdpdGhpbiB0aGUgdGFibGUsIHNpbmNlIHRoZXNlIGFyZSBjaGFuZ2VzIHRvICJhdmFp bCIgYml0cw0KPiA+PiBvbmx5IEkgZG8gbm90IHRoaW5rIHRoYXQgY2FjaGUgZmx1c2hpbmcgd291 bGQgYmUgbmVlZGVkIGFmdGVyd2FyZHMuIFN1Y2gNCj4gPj4gY2FjaGUgZmx1c2hpbmcgKG9mIGVu dGlyZSBwYWdlcywgdW5sZXNzIGFkZGluZyB5ZXQgbW9yZSBsb2dpYyB0byBtZSBtb3JlDQo+ID4+ IHNlbGVjdGl2ZSkgd291bGQgYmUgcXVpdGUgbm90aWNhYmxlIHBlcmZvcm1hbmNlLXdpc2UgKHZl cnkgcHJvbWluZW50DQo+ID4+IGR1cmluZyBEb20wIGJvb3QpLg0KPiA+Pg0KPiA+PiBTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IC0tLQ0KPiA+PiB2 NDogUmUtYmFzZSBvdmVyIGNoYW5nZXMgZWFybGllciBpbiB0aGUgc2VyaWVzLg0KPiA+PiB2Mzog UHJvcGVybHkgYm91bmQgbG9vcC4gUmUtYmFzZSBvdmVyIGNoYW5nZXMgZWFybGllciBpbiB0aGUg c2VyaWVzLg0KPiA+PiB2MjogTmV3Lg0KPiA+PiAtLS0NCj4gPj4gVGhlIGhhbmcgZHVyaW5nIGJv b3Qgb24gbXkgTGF0aXR1ZGUgRTY0MTAgKHNlZSB0aGUgcmVzcGVjdGl2ZSBjb2RlDQo+ID4+IGNv bW1lbnQpIHdhcyBwcmV0dHkgY2xvc2UgYWZ0ZXIgaW9tbXVfZW5hYmxlX3RyYW5zbGF0aW9uKCku IE5vIGVycm9ycywNCj4gPj4gbm8gd2F0Y2hkb2cgd291bGQga2ljayBpbiwganVzdCBzb21ldGlt ZXMgdGhlIGZpcnN0IGZldyBwaXhlbCBsaW5lcyBvZg0KPiA+PiB0aGUgbmV4dCBsb2cgbWVzc2Fn ZSdzIChYRU4pIHByZWZpeCB3b3VsZCBoYXZlIG1hZGUgaXQgb3V0IHRvIHRoZSBzY3JlZW4NCj4g Pj4gKGFuZCB0aGVyZSdzIG5vIHNlcmlhbCB0aGVyZSkuIEl0J3MgYmVlbiBhIGxvdCBvZiBleHBl cmltZW50aW5nIHVudGlsIEkNCj4gPj4gZmlndXJlZCB0aGUgd29ya2Fyb3VuZCAod2hpY2ggSSBj b25zaWRlciB1Z2x5LCBidXQgaGFsZndheSBhY2NlcHRhYmxlKS4NCj4gPj4gSSd2ZSBiZWVuIHRy eWluZyBoYXJkIHRvIG1ha2Ugc3VyZSB0aGUgd29ya2Fyb3VuZCB3b3VsZG4ndCBiZSBtYXNraW5n IGENCj4gPj4gcmVhbCBpc3N1ZSwgeWV0IEknbSBzdGlsbCB3YXJ5IG9mIGl0IHBvc3NpYmx5IGRv aW5nIHNvIC4uLiBNeSBiZXN0IGd1ZXNzDQo+ID4+IGF0IHRoaXMgcG9pbnQgaXMgdGhhdCBvbiB0 aGVzZSBvbGQgSU9NTVVzIHRoZSBpZ25vcmVkIGJpdHMgNTIuLi42MQ0KPiA+PiBhcmVuJ3QgcmVh bGx5IGlnbm9yZWQgZm9yIHByZXNlbnQgZW50cmllcywgYnV0IGFsc28gYXJlbid0ICJyZXNlcnZl ZCINCj4gPj4gZW5vdWdoIHRvIHRyaWdnZXIgZmF1bHRzLiBUaGlzIGd1ZXNzIGlzIGZyb20gaGF2 aW5nIHRyaWVkIHRvIHNldCBvdGhlcg0KPiA+PiBiaXRzIGluIHRoaXMgcmFuZ2UgKHVuY29uZGl0 aW9uYWxseSwgYW5kIHdpdGggdGhlIHdvcmthcm91bmQgaGVyZSBpbg0KPiA+PiBwbGFjZSksIHdo aWNoIHlpZWxkZWQgdGhlIHNhbWUgYmVoYXZpb3IuDQo+ID4NCj4gPiBTaG91bGQgd2UgdGFrZSBL ZXZpbidzIFJldmlld2VkLWJ5IGFzIGEgaGVhZHMgdXAgdGhhdCBiaXRzIDUyLi42MSBvbg0KPiA+ IHNvbWU/IElPTU1VcyBhcmUgbm90IHVzYWJsZT8NCj4gPg0KPiA+IFdvdWxkIGJlIGdvb2QgaWYg d2UgY291bGQgZ2V0IGEgbW9yZSBmb3JtYWwgcmVzcG9uc2UgSSB0aGluay4NCj4gDQo+IEEgbW9y ZSBmb3JtYWwgcmVzcG9uc2Ugd291bGQgYmUgbmljZSwgYnV0IGdpdmVuIHRoZSBhZ2Ugb2YgdGhl IGFmZmVjdGVkDQo+IGhhcmR3YXJlIEkgZG9uJ3QgZXhwZWN0IGFueXRoaW5nIG1vcmUgd2lsbCBi ZSBkb25lIHRoZXJlIGJ5IEludGVsLg0KPiANCg0KSSBkaWRuJ3QgaGVhciByZXNwb25zZSBvbiB0 aGlzIG9wZW4gaW50ZXJuYWxseS4NCg== From xen-devel-bounces@lists.xenproject.org Fri May 20 01:33:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 01:33:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333382.557204 (Exim 4.92) (envelope-from ) id 1nrrWK-0007ig-43; Fri, 20 May 2022 01:33:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333382.557204; Fri, 20 May 2022 01:33:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrrWK-0007iZ-0i; Fri, 20 May 2022 01:33:36 +0000 Received: by outflank-mailman (input) for mailman id 333382; Fri, 20 May 2022 01:33:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrrWJ-0007iP-2G; Fri, 20 May 2022 01:33:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrrWI-0001YS-K4; Fri, 20 May 2022 01:33:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrrWI-0007wG-86; Fri, 20 May 2022 01:33:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrrWI-0004mM-7f; Fri, 20 May 2022 01:33:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=61Nw6c8FbaBu2U7Gn7JtQv4x7wCQa89W5KA+o/26JB0=; b=d+HSdM/vdh70hmqQwzU/u3Uy8z fp+BKhllgRJGj9SV0jwUQybzqbdRQv7Y/ms+HCA0BjXyFX4vJ04xyfX9HS2unnVGoJu7H3hMJND5S 5baSXEMWAMaQJuX7qX6pVbxoQKXEkWNcD929oEx8vNkbdzrMcTZfh4aPvYzoWheuDdiI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170584: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=1f026ababf350746c6071c0873d9d1c8824029ca X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 01:33:34 +0000 flight 170584 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 1f026ababf350746c6071c0873d9d1c8824029ca baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 79 days 1108 attempts Testing same since 170564 2022-05-19 06:40:42 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6908 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 02:16:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 02:16:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333392.557215 (Exim 4.92) (envelope-from ) id 1nrsBX-0003lL-CO; Fri, 20 May 2022 02:16:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333392.557215; Fri, 20 May 2022 02:16:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsBX-0003lE-8t; Fri, 20 May 2022 02:16:11 +0000 Received: by outflank-mailman (input) for mailman id 333392; Fri, 20 May 2022 02:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsBV-0003l8-MF for xen-devel@lists.xenproject.org; Fri, 20 May 2022 02:16:10 +0000 Received: from sonic309-22.consmr.mail.gq1.yahoo.com (sonic309-22.consmr.mail.gq1.yahoo.com [98.137.65.148]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbe61880-d7e2-11ec-837e-e5687231ffcc; Fri, 20 May 2022 04:16:04 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 02:16:01 +0000 Received: by hermes--canary-production-ne1-5495f4d555-xgn59 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 49a5d3ad8fd09327a59bccdd561ab452; Fri, 20 May 2022 02:16:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbe61880-d7e2-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653012961; bh=7b30/DpTLb5SVpAp4UHZjIHf2v+mEoFOGRCWalC6alk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=USnf2QYQaj6nl7LxofQViMdBJ/eDjmsJlBtwH3wY3YWSXuIbV72F/oLNBlH2zSrKM/+WYQPZgD/BCCXKIyaEY1TcolQROmvaDF/sOFm2Q4RxqekIFvP5NSABaxk4BXOqHlry+PF1caE3Mat0azFw2v0UvpirjGd4UFv4my14ekQDkOLDo8h7T22f0xN4Z8vKuXLsF6OO+vublN1oZKzOW7ILp3+bh4IuQaUvEgq5Ml2fdvg6Tw1Crs0M1RkwaMvfKc8OpRlCZKB1M6xvJxnj3nMn00EeSoWyTD20QzT4jbzt1rPBZdR5LQ2N9sQJ6VN1kVP4BJKJx+qWNb33RzHSoA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653012961; bh=lgtsVyE93WpkxCRZRawyN3iVw0rx+Gw65El69Q/tblA=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ZfRx5ZVV9BxgiCZHXZgrp/nKsLmi/bcLkMx7gwgoxYRIKTaV7x/POQdGunMnhTkyXVhN7DSYNVTYAwudLiuLamOyBtecwE6IHPKLB1NAqEh+4CEaQQ+EmPt2i3aOZ3UOHrb9nIUvZPJyZjcCKOoiLMNy19csJltJmYXTWY84VLIL3AceIXuEXHfl2bRPZGrAmmx2GaaIGbQhWVZqV692qCkU1ZCJb8Fxjt7BOQtXlwW/i8vcgoqH5S19Jx4/eq5zlhnZ3qoc44Y9Lf0q1NZEopQGaadV4q7G3XhUQ2vEbHUFcLLjs98hpDTz25V0EFlqfEwRe2SUnY0qeWW3aNy+bw== X-YMail-OSG: x61LLaYVM1kq7tWP_1hNaOKp6w7u9jbOH7P65gKl8HHmQ7Y72IIIiFhiXHBW6qW ESrMDQbkv8bMiQIV_XTVC.5vKsAJgifa30Ent9uN8xvwocvsb6A54Kaxuc7vtOV2sSMDjfoDJyFX 8i4adJo8SJhO56uGosXENfEDnIc_AGNMHTv3xlJY7KKSSCc9qWyzlvYWMLM.iU.qdmtA5z.m60R0 h6CHV73wjupOEqY1U7VPnwivWmXirghDQs1EwlPF4DM1jXFF5KZQL6khQ6zBJQCeeO0n_NxWEjQs YjTktjHRujhrQXxsHvrW4A_uYff1yLwvKuZF5f8gV2ROnPFE7E0j2uW.pdrECf8ak2KKiXtBM2Tu 9bf4gFGed5jONY6Sg_zh9R2ET.9WCb3ssmZCzfM6BRV_JLM.H4swaElOhwqUHn9L9cHfTZkla4e7 nkiJGHXDgKmZc5vqj5LZi4Nk8.js0G3KrGJT4vZn8_zb9mxM0EOZl7nIUXIGQJeGoMI1Iq4LQuHT t9PG0pIevwkT8nJYGbdM7CCTCuaec.tgp2gA5hDaNkSC0ivT7Bzco6pGvNcl2xkeaoBpwHaV3hPP Iv0TUIkShI5g.2tRmNGEngB1BN79X0T0ulEgyH9COzfMnDPXhMEoYV016RpW90kx9EKp6MRPgGoi Pzw4tK4PBBSqQD7Rjo0TKKf7YqxN8.mAW27qfWHaZHPga_jGnPHS26nRmJwgvUnEsNfcCtOSuF_t MQNpRyR7rwlgFRq0IMZ89tZuJrzXfUKE1p63DUSyc.bZR.zs4AdsMbSheRlgRBVvHztNXnhH6Wgs 1yNiuOGwFizYOBkEUeczSwu7qmMZMoRqLxXTCQFnD2MdaiP4KBlR5B.XmDJlqwAb_KGe.5TY47me w3HqdK8Yh4eN.1T29kmM5NaAw8uKMLv2o9a3_nR8DIXXmnnEI7w15YIncl.vb2D9_QoJ7Jcs_cHl jyWz28rtlG9hDLx.P04gB0rR7qgLxzBOOlrJDIPBGW.Vh8rXxgtpOsbVYGpk_AawaFzxp54wA70o eJpLsVxFAY7LlbbfaYaAIVODj4awD1ZIIZAd6KSuS9R.638.YG3gDvnDzB3tMO28t1dmMFi0zBzn dWZVlFHKbGwUi67JvAfAtTa.w1.r3ZTWvKzB7wy5rcNXrlcfZt_OWiWPL_xqSzpkBt2iUiE1KfIN oO4EeaBHQBcJGY6dmV8G0unjTLdh0.QQniVyCzDUfoIw6QbDtXHQku.ay0fwMaFAGcP63XTi3rU2 gLFshTCiHPpaAtmWT3zZYD.rqnaEjwgbVmQerbHhZhI2O80MyCfOqT7pqrimgjU2jmqOMiQ6RbEM WpasJVIEBcg8MlTfStbm3xCrvH0BDj1PzYUKW3qCxcON6.vs1bGYroXsYytVpEgeiCPTXfJGqlnI 6_57Y6FI8fnN7nfVQ_FalDIU8lzwBnaoKY2otL0x_I4fTBAhOy1AlM2inYeJfuwCv_4M6KaRKuyK 0G8x.FRwnqKbj34lzBYPQNcria1eDm.Wvk827FsYM_HOYMuYUYU0rPyhFEBctopUPrOl3r910dEV xghoIX9WTniKUY1j_uA2Ma9r5JOvYf4yTKPEFqf5xUdM8ZYPq.5CVY8aSIOa.YOThr9.ynGV5kqM dFVUhm.HYB7ZgvwP1TJhnA3uCQleecMiHbjDpol4fptQQspZLGUO1wv4mt88KMeFc4_Gq.8TaZVK HT9jsLtQgZuz3k1ZzCmrRZNXzhBH1M6p38fc4LJxP5GD0fOwHTArA6KBbgNZR8cXxds3wkqM5mDd kW6yKxLLzgvER_KH30adihpBMzVCdyyv68KB1SpNOQHf82cjnGZss0uCEBl1MoeExFeGxhwARxSn nsRyiroOVXbP4YJfcrBVbvUEM.xXfRTgIR3.rdQ_B2rcmMbcTMkoltxFzBZAVduYleKTW3xHGNfU D88DSUXb8A1u4A.oeC9vM8XcgGYALOCNlHpPgf4rp4vVn04CTvkjc5IyQf.tkHnP3TohAxM_7jWA RYwN_wW_crxJAcerRE3fnmwo9qnYTIa1kb3XpqVItun_sggiu3mZLFZCkmLJ6ftHtKSX4y6H0Ksu daL1QttImJ2XKvC4Se4LjOL5GTnpsCvzIQ3NAjXaOfE0dZIUTIQtNzddksp.2whsQzIiGMblgvja UNEjIAICtPtD6FBzQrCLHpkHcMNazh9zI4d9MkmAU6guyAdu48msc7xAihTX7vsBVc1FlE0IG X-Sonic-MF: Message-ID: <788dc391-6a20-5c03-9613-9f22fcc125f1@netscape.net> Date: Thu, 19 May 2022 22:15:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , pkg-xen-devel@alioth-lists.debian.net References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> From: Chuck Zmudzinski In-Reply-To: <20220503132207.17234-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20258 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5788 On 5/3/22 9:22 AM, Juergen Gross wrote: > Some drivers are using pat_enabled() in order to test availability of > special caching modes (WC and UC-). This will lead to false negatives > in case the system was booted e.g. with the "nopat" variant and the > BIOS did setup the PAT MSR supporting the queried mode, or if the > system is running as a Xen PV guest. Hello, I am also getting a false positive in a Xen Dom0 from pat_enabled() where bdd8b6c98239 patched the file drivers/gpu/drm/i915/gem/i915_gem_pages.c I think this patch also needs to touch that file to fix the issue I am seeing. Ever since bdd8b6c98239 was committed, I get the following in the logs when running as a Dom0 on my Haswell processor, including with the untainted official Debian build of 5.17.6: May 15 06:31:59 debian kernel: [    3.721146] i915 0000:00:02.0: [drm:add_taint_for_CI [i915]] CI tainted:0x9 by intel_gt_init+0xb6/0x2e0 [i915] This causes the system to hang with the backlight on. The only recovery is by hitting the reset button and rebooting Linux Dom0 on Xen with Linux version 5.16 or earlier, or by rebooting Linux version 5.17 without Xen. I was able to fix it with a kernel that fixes the false negative I was getting in drivers/gpu/drm/i915/gem/i915_gem_pages.c Can the patch also touch that file, replacing pat_enabled() with x86_has_pat_wc() in the place where bdd8b6c98239 patched that file? Thanks, Chuck Zmudzinski > > Add test functions for those caching modes instead and use them at the > appropriate places. > > For symmetry reasons export the already existing x86_has_pat_wp() for > modules, too. > > Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") > Signed-off-by: Juergen Gross > --- > arch/x86/include/asm/memtype.h | 2 ++ > arch/x86/include/asm/pci.h | 2 +- > arch/x86/mm/init.c | 25 +++++++++++++++++++++--- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 ++++---- > 4 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/include/asm/memtype.h b/arch/x86/include/asm/memtype.h > index 9ca760e430b9..d00e0be854d4 100644 > --- a/arch/x86/include/asm/memtype.h > +++ b/arch/x86/include/asm/memtype.h > @@ -25,6 +25,8 @@ extern void memtype_free_io(resource_size_t start, resource_size_t end); > extern bool pat_pfn_immune_to_uc_mtrr(unsigned long pfn); > > bool x86_has_pat_wp(void); > +bool x86_has_pat_wc(void); > +bool x86_has_pat_uc_minus(void); > enum page_cache_mode pgprot2cachemode(pgprot_t pgprot); > > #endif /* _ASM_X86_MEMTYPE_H */ > diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h > index f3fd5928bcbb..a5742268dec1 100644 > --- a/arch/x86/include/asm/pci.h > +++ b/arch/x86/include/asm/pci.h > @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, int pin, int irq); > > > #define HAVE_PCI_MMAP > -#define arch_can_pci_mmap_wc() pat_enabled() > +#define arch_can_pci_mmap_wc() x86_has_pat_wc() > #define ARCH_GENERIC_PCI_MMAP_RESOURCE > > #ifdef CONFIG_PCI > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c > index 71e182ebced3..b6431f714dc2 100644 > --- a/arch/x86/mm/init.c > +++ b/arch/x86/mm/init.c > @@ -77,12 +77,31 @@ static uint8_t __pte2cachemode_tbl[8] = { > [__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC, > }; > > -/* Check that the write-protect PAT entry is set for write-protect */ > +static bool x86_has_pat_mode(unsigned int mode) > +{ > + return __pte2cachemode_tbl[__cachemode2pte_tbl[mode]] == mode; > +} > + > +/* Check that PAT supports write-protect */ > bool x86_has_pat_wp(void) > { > - return __pte2cachemode_tbl[__cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]] == > - _PAGE_CACHE_MODE_WP; > + return x86_has_pat_mode(_PAGE_CACHE_MODE_WP); > +} > +EXPORT_SYMBOL_GPL(x86_has_pat_wp); > + > +/* Check that PAT supports WC */ > +bool x86_has_pat_wc(void) > +{ > + return x86_has_pat_mode(_PAGE_CACHE_MODE_WC); > +} > +EXPORT_SYMBOL_GPL(x86_has_pat_wc); > + > +/* Check that PAT supports UC- */ > +bool x86_has_pat_uc_minus(void) > +{ > + return x86_has_pat_mode(_PAGE_CACHE_MODE_UC_MINUS); > } > +EXPORT_SYMBOL_GPL(x86_has_pat_uc_minus); > > enum page_cache_mode pgprot2cachemode(pgprot_t pgprot) > { > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > index 0c5c43852e24..f43ecf3f63eb 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > if (args->flags & ~(I915_MMAP_WC)) > return -EINVAL; > > - if (args->flags & I915_MMAP_WC && !pat_enabled()) > + if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) > return -ENODEV; > > obj = i915_gem_object_lookup(file, args->handle); > @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, > > if (HAS_LMEM(to_i915(dev))) > mmap_type = I915_MMAP_TYPE_FIXED; > - else if (pat_enabled()) > + else if (x86_has_pat_wc()) > mmap_type = I915_MMAP_TYPE_WC; > else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) > return -ENODEV; > @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_WC: > - if (!pat_enabled()) > + if (!x86_has_pat_wc()) > return -ENODEV; > type = I915_MMAP_TYPE_WC; > break; > @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_UC: > - if (!pat_enabled()) > + if (!x86_has_pat_uc_minus()) > return -ENODEV; > type = I915_MMAP_TYPE_UC; > break; From xen-devel-bounces@lists.xenproject.org Fri May 20 02:22:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 02:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333401.557226 (Exim 4.92) (envelope-from ) id 1nrsH6-0005EJ-3a; Fri, 20 May 2022 02:21:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333401.557226; Fri, 20 May 2022 02:21:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsH6-0005EC-0A; Fri, 20 May 2022 02:21:56 +0000 Received: by outflank-mailman (input) for mailman id 333401; Fri, 20 May 2022 02:21:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsH5-0005E6-4F for xen-devel@lists.xenproject.org; Fri, 20 May 2022 02:21:55 +0000 Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bacb4ed-d7e3-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 04:21:53 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 02:21:49 +0000 Received: by hermes--canary-production-ne1-5495f4d555-vwstm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 418a811caf32e9bb9537443005bbc38e; Fri, 20 May 2022 02:21:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bacb4ed-d7e3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653013309; bh=O9Iz0YCSaCQOHi8+J38vW/gZxqJdLA0UYeA/SDg5U+w=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=jOiM7JT5VanGyuKRieA98Wppi56m2wqlZrhriyy+zCzJTeQqBVbDAQFEIUOysTqxtnkEMyBcIEMseQj8FpRIrdItX/L9jDgZTaYTokRNvHfqfRIkr8M16m/2pewA79gfkM3kcH+LpI4WEqtIllo0Sp7ubx/BxgMIdhzBk2hLb7yUwcdn37WQwBycZj8nM+SRWsgMHaXXrL2bUx6K6F7VTPoJltqYLguYR7LD+0tqgTTenAvaRfbWWBFg7z+xdQ1D4suOG4Cm+j0GLNMb8PiEb+A0vwEp/F8TWNe03T6isKhyg/VsLFZk6dA4OKDZeMljwlWozdmT0AbW7JRLfJgWfg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653013309; bh=6MGScbnfauf9PPcM25Q2+iWYrJGmOgdqYWQb0WMLjIE=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=GUbmXdo7ITGpi/gQoJwtZsuJkduReS1ZzX+3bskP0o4sZfBSYyWjZ6Dz9m+cDy6239bj0pDIE2eHPJwLPk4JW/36vM/nXSpIQuV9M4C5jT9uUW29PFZWawswtOYdaOz493ziM070ZZBC97t/BqJdWV2QJTpYRiUWbU8A78bZzN88BrtrvQgfu0WhrtRAL/o/ObqQzMaAlbxo5bO+E6GhWi75YCz5xXZAG/KXNEJHbXuV5bgKe/29K3ab7whcnx16f0ChPIpj88IBTsgo0lymw8GXl4TudQFyC3Kk45zQDItyjbCEkw8hIvW+evdOkra1b959VumT5IjolhxsLWQYng== X-YMail-OSG: emYvzjUVM1l4fqlM8exikyXPZwlQsDInBWS4j_i2OUXqFaHZYmDSDjzSrfvrpjl AwPzBYEYO943tyOm0YwVTonYKwFFFXDD.yKkWG5MmOSnOcZfI.7NJ.7881xRdint.9WXx_qYpBbF _mTY.b46F3xY.Ey9zma_r3WqjSFrhtAOIHa7upoePwDBthFd3qIYYenlO1iG4xo2Q4UrJALbc.jL 7ozE7_VZoGKo8tTaDLXmuFqF_C9g6MfwRR5UxBIf1GsMrjU0Zf_tUXHfSpUCew._TR6f8BkmQiaH NO5p81elA1WZfj7B7rEfCBM11P_4GW5p2gEtbA4O6PF.NLcOczqTefIpJDW9iBVMkq2w7t84_RAc ebtwvhbFk7lr.ZEoXwN0jR7ajgGDL7bjG6YbNisMnIw03n1lGlee8xxXXL4eO0IUj.WOE_8VvO54 NpC12TWwNV8P_FbZ2jcua1ygFk6bUax3w8s17YtNDeIXDZFYapFtgnHMHgchSukH7nUgQxV4fY3q zJxuN5IB1YVmaxVvFGk4m8I3EhKTwznKYLzhmgiGjx8OdU3S8pfl7H__tvmImXf.4SnLoIzhCpPK VhUg2gIAIonKK8AImgaiDU_aYMLJ1nejjjBFtBL0WtiRfh_vwHbH0cW6U3pdADF2bX0kurFvCwnI Zw_jAZwY5CwQxstWSlN_yXkMqeCkikfyb6CX9kOUvdP3ZcbKBJrkBuWKieRAIryrNQ4RDpGs1PWY P2LisBH5YMbmPonk1D0eyeWOOcjqdA6AFWblsTUA4VSIW9FdqIW7dxCW3uKd6EhsgjaNcEThOExz 2tvW2Ohe5rJ.y1CcDg7XJ50EXUKPV2T3PwAIDSsU4PkQprntV10jBiXr2FLnk_EPBy1w4laW3kYh 9F3gxChZgH19SpE9KA5tH6Q69hIn0rj5BzVmVQMwukq0v10cFNt6EenyxOiI97bw70xd9kOvJ5hO e3XGmYri6upDAOVSQGGGBGiMxEf9TkP4t9GQYzae8ozGyAhMnJzI2X1GHsA_1pgjY3NbMON09Ywd 8Flg4jguBYAnVUEXJhnxNT9m8mg9x7uarMlTwE9mv44J7iL.a5WwsEXorW.RLwsXoby35YKUkTNw Ttyak04SM_7zJPoJTDlBefld0RUFDBCyHju4H08iY2KLqhQTEhLhJLmZIPqg2pQt_2td9sISQ1kF OEJh59pDwZGFCaFegRaGjiILKv6TAN_rpVvtAWUd5.DqbCytdR8OqGjJFt90GAWbXPOypTe5ut7r tqvf72keSq.X0vwBF8j5x8RYZ.faP2tFPiEJrp1c2n264kZPvAqrWhnKOIrLNX6qBUJsxrFRdzqt t5gqbK42Hbao6VdWxM_7e7Vewv.UkOVou4h23Hjto4ul4P3BQwC9WJtVUyWirWtw0_HZ5fkXew8V jCSnji4tIfDrakSykIuZQlB93U2hKnQ0S8806GD6bkYEsYWUWw4xSXuyf1e1DM8vtjDYbS9_N__R bX3.X87tSyUPXAZKcKOg9aYurFvkpUcOCDcwq3Qmtd67mFSAQZrhkrXfujeds_1hlnEMi1vAAgpo QuzkwZF76gzpeypkXGsPB9Ep4YvZMB4VQ2vEsnGK7GTbWT3iBPxZpV_FwuPxwne0OLW9mPYLB1TS scyTix0mlZPxDKb_TGI9sSrXs2SAAQaNMX3F8vHdtY3L29ITOMIDRfY5xP981y_ePA9VzaGneWQF DVS3mz5e6_Mf9uiosyyPsJVFpF1uduwsnHDs2Qyh8j_QhrXf9nrs_hkksclxsTFaUCnORq6hA6OO AXXorcTe7aMAwovCD.o2T7vhe0s2Lg1990gggcrlHF3o1lX4YNNbH20KerVCcSoe6FJ_.sKpxJHY c2QJEYlHUQlStato1ygy.ERiVXvw57q67pyZd80BRSNB42QEwpaqd9R9bVOlleprcPzjVNYDoy27 r3L114EPmz4vkeUuJXwD4qd98OHpmZVXyztywsvgDMoiEHKhegr2mrG45uIM19VnXjOaDHgBx.hm wYGhlEGkfYHvOao7ClN15NrGwrFm9sXHFg.gnL_6j_83lqupNs_CEO1f6MThT_1OGEugH0A6lI9y Ps4NteURzQ_ckISrzZrhzSafJUxcb0EKmZo.320_NC3NsYNPFQPnBxclrybUuEriY1MqdspZfHQ5 l3okdQcehIkxgUcQBLvByeZPWuQjI.uu_XRiPEwCwX9AIsG3e.A4WrBDVMvKxwyAkQOgIXJ6yvOv N5YdxJHA- X-Sonic-MF: Message-ID: Date: Thu, 19 May 2022 22:21:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , pkg-xen-devel@alioth-lists.debian.net References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <788dc391-6a20-5c03-9613-9f22fcc125f1@netscape.net> In-Reply-To: <788dc391-6a20-5c03-9613-9f22fcc125f1@netscape.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 736 On 5/19/22 10:15 PM, Chuck Zmudzinski wrote: > On 5/3/22 9:22 AM, Juergen Gross wrote: >> Some drivers are using pat_enabled() in order to test availability of >> special caching modes (WC and UC-). This will lead to false negatives >> in case the system was booted e.g. with the "nopat" variant and the >> BIOS did setup the PAT MSR supporting the queried mode, or if the >> system is running as a Xen PV guest. > Hello, > > I am also getting a false positive Sorry, I meant false negative here, not false positive. Chuck > in a Xen Dom0 from > pat_enabled() where bdd8b6c98239 patched the file > > drivers/gpu/drm/i915/gem/i915_gem_pages.c > > I think this patch also needs to touch that file to > fix the issue I am seeing. ... From xen-devel-bounces@lists.xenproject.org Fri May 20 02:23:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 02:23:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333409.557237 (Exim 4.92) (envelope-from ) id 1nrsIe-0005pW-Fi; Fri, 20 May 2022 02:23:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333409.557237; Fri, 20 May 2022 02:23:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsIe-0005pP-B6; Fri, 20 May 2022 02:23:32 +0000 Received: by outflank-mailman (input) for mailman id 333409; Fri, 20 May 2022 02:23:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsId-0005pF-DH; Fri, 20 May 2022 02:23:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsId-0002qR-Bb; Fri, 20 May 2022 02:23:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrsIc-0000yb-PC; Fri, 20 May 2022 02:23:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrsIc-0003BT-Om; Fri, 20 May 2022 02:23:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4I+yX8NRoC7vLHTboufkj+5sHXOMotHWUFlVTbau21w=; b=kop2Lr5rp4RWWsj+nxs+FT10v/ MKDaTFklRFGFvDDFBmld60B4HTRMN9Ier0gqVauxlqbIERAIl/NRUi6zds/dkNqDOCT11VnBv4LfR v3PkNEfFj1UxmhqNySvIQiKj7Uf0zRRb6pcDgu0EZpMRC+NC+Fl+QQ9/gPtR8FqZgfLE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170585: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a72d552f197b9b5cc3afdf22891b27ecf4067037 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 02:23:30 +0000 flight 170585 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170585/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a72d552f197b9b5cc3afdf22891b27ecf4067037 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1109 attempts Testing same since 170585 2022-05-20 01:43:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6940 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 03:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 03:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333420.557247 (Exim 4.92) (envelope-from ) id 1nrstz-0001aJ-H7; Fri, 20 May 2022 03:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333420.557247; Fri, 20 May 2022 03:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrstz-0001aC-De; Fri, 20 May 2022 03:02:07 +0000 Received: by outflank-mailman (input) for mailman id 333420; Fri, 20 May 2022 03:02:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrstx-0001a2-MB; Fri, 20 May 2022 03:02:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrstx-0003V6-IL; Fri, 20 May 2022 03:02:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrstx-0001zU-0n; Fri, 20 May 2022 03:02:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrstx-00088y-0L; Fri, 20 May 2022 03:02:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z4HNfUdX5XkVHO0ZamlLwaF6tSvIEBKMhzPrS4g9eh4=; b=CK8IXWYwzVLWIUyrFxpt75feuB jVUZLuDMaAc7on0wotub5IbYqpfUvdLssnExS7H25kuN2CYeJNrc/EICEjaP5LkLZ85D0zIyvGREw 4FqQ2Rip9qdtBZ9smzwG5ZLpDmK0J5eR1fU1LMryUSCRJVstUEMNu0u141cPZW2IWWSk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170578: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-xsm:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3a650ac995ca36fb9974b82ba50aac8d1fd18b6a X-Osstest-Versions-That: qemuu=78ac2eebbab9150edf5d0d00e3648f5ebb599001 From: osstest service owner Date: Fri, 20 May 2022 03:02:05 +0000 flight 170578 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170578/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 7 xen-install fail like 170561 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170561 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170561 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170561 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170561 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170561 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170561 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170561 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170561 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 3a650ac995ca36fb9974b82ba50aac8d1fd18b6a baseline version: qemuu 78ac2eebbab9150edf5d0d00e3648f5ebb599001 Last test of basis 170561 2022-05-19 04:21:12 Z 0 days Testing same since 170578 2022-05-19 20:39:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: CHRIS HOWARD Florian Lugou Peter Maydell Philippe Mathieu-Daudé Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 78ac2eebba..3a650ac995 3a650ac995ca36fb9974b82ba50aac8d1fd18b6a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 20 03:37:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 03:37:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333431.557259 (Exim 4.92) (envelope-from ) id 1nrtSC-0004vQ-FM; Fri, 20 May 2022 03:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333431.557259; Fri, 20 May 2022 03:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrtSC-0004vJ-Cg; Fri, 20 May 2022 03:37:28 +0000 Received: by outflank-mailman (input) for mailman id 333431; Fri, 20 May 2022 03:37:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrtSB-0004v9-Ly; Fri, 20 May 2022 03:37:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrtSB-00044u-H5; Fri, 20 May 2022 03:37:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrtSA-0003ZW-Ka; Fri, 20 May 2022 03:37:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrtSA-0002Pd-K6; Fri, 20 May 2022 03:37:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4AlnU1cKhhmTB4zkKXkzL1DhVUF/U/LzZ3m4+aYjtFU=; b=xoFWVKis36Lx6EQCyN6ysz1e+l SMqigysYQzouPtEcp1jn7seyf2QH+TDDSNltG/0QAcSBtMt+qwJ7fLdVYqtLEL/oCim6ls9vgfcbd 1WIMwWVYsBAtPdifGFXFyvzdGeGB6DcAxA9kJtc89xjKNiUzdDkOk9/RuNFfJa9ymA30=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170587: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a72d552f197b9b5cc3afdf22891b27ecf4067037 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 03:37:26 +0000 flight 170587 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170587/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a72d552f197b9b5cc3afdf22891b27ecf4067037 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1110 attempts Testing same since 170585 2022-05-20 01:43:00 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6940 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 04:21:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 04:21:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333444.557270 (Exim 4.92) (envelope-from ) id 1nru8c-0001VG-Sl; Fri, 20 May 2022 04:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333444.557270; Fri, 20 May 2022 04:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nru8c-0001V9-OT; Fri, 20 May 2022 04:21:18 +0000 Received: by outflank-mailman (input) for mailman id 333444; Fri, 20 May 2022 04:21:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nru8c-0001Uz-3R; Fri, 20 May 2022 04:21:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nru8c-0004sk-11; Fri, 20 May 2022 04:21:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nru8b-00064X-M6; Fri, 20 May 2022 04:21:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nru8b-0002GL-Lb; Fri, 20 May 2022 04:21:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MnAppUW0iksoYuSOL4ybHUZcVJUfjWlJHJe5oGr1uaU=; b=f5Bs9KUtl60zLgxMTCim9gck5S W1kVZ8SjDmLZy0o4iYKb5VjjgTTR+2ct6qVnyOe6wxyVzNOctPdNdpdatLKUW5V0caCAnmkpT5nz7 xOl1dK/V2yKxFmkawF6fNtny29ZL9XXmPfsRpnz49/VyW/9mITmT/cQqc2Z1Z/a531f0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170588: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a72d552f197b9b5cc3afdf22891b27ecf4067037 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 04:21:17 +0000 flight 170588 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170588/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a72d552f197b9b5cc3afdf22891b27ecf4067037 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1111 attempts Testing same since 170585 2022-05-20 01:43:00 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6940 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 04:43:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 04:43:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333454.557281 (Exim 4.92) (envelope-from ) id 1nruU2-00049R-LY; Fri, 20 May 2022 04:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333454.557281; Fri, 20 May 2022 04:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nruU2-00049K-IV; Fri, 20 May 2022 04:43:26 +0000 Received: by outflank-mailman (input) for mailman id 333454; Fri, 20 May 2022 04:43:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nruU1-00049E-Id for xen-devel@lists.xenproject.org; Fri, 20 May 2022 04:43:25 +0000 Received: from sonic315-8.consmr.mail.gq1.yahoo.com (sonic315-8.consmr.mail.gq1.yahoo.com [98.137.65.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 606e01c1-d7f7-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 06:43:23 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 04:43:20 +0000 Received: by hermes--canary-production-ne1-5495f4d555-bjbtf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a1795d04c77b5a17be6e88fe29b6a939; Fri, 20 May 2022 04:43:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 606e01c1-d7f7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653021800; bh=J1YKr5RacY3w5lsZh/paPzmLPI5/GokFPpbgIzeL1N8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=DPjf6byxXe7OOvRJuwoUNRxkSLMIOl7fm5wIMi6KkNUOnrUaUDIOilQXe1YtorzHmDz9z3Algj5evXV5+Z8/K2OSpuBNcuav565OYJ9uiIU8UO7MsdZLiATjZVRw7aC/k+OnSCM5AYFzXkGDVFsuYlr/5lsfVtj8pCkcb3MZuQlty0lHCbgKHUmlk+1Oz+uKvDWaOIXxFB8y040J3l74VrcSOlu3ZgG28IRzqtZvQ98hRYzbTrXrNoe/LY+PQae/qTyvoW/fgIgzng8A3CcSPmnOCyAkuccTOyidEyzA4/5IIQ1ecy1HraQ9zJR7ynls0m0rHesFg1XpaTvvGGGIDg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653021800; bh=mBfj7zqheyE1tLGfiJ0ww0RKlhBpFN3oc2UFTWLtPCI=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Mnya2XL47Fhd1rH7cqwg5FB6+px506jhzRBHwJ4QsGeqUWYIX5i6few3UJeZ1CnkEgauOhjo7e3Xm1JUsEmV5F7sRZwXpggbEXTxvLPL4oRtyRRQVVUn5twrlpNBbNoSmbvCBkJR5zHy6dpIUd5xuxSfU516fuPvsI0RSZ1YaGrwVPJb2UR7lXX8O7DKeRk6iPdXkfvUp2ABVZwWulfkLIusHqRPa3eYpVQCdT4QkkSctkhGtlz+2yhj1FomH8OOHHAjwPIHQF0wYGhXnqdhS0Vy+UH4hEWQDHoiSCOEKM7WBkGPaiVKh2i6QcUsxMOjZoElTssOffKYc8ckzVk1lQ== X-YMail-OSG: R.k3XAIVM1kotrSaFFhdpBpoD4xSgja4_dkfHDhErnJNqmVRceWBxOlPNtzElRS 0qhYAtbZrNv56G9bIeNEXEXZuvaUa6t22zhUx7_q8_mvpB5SC_4CorEoljneMSyTt7qhv2kzX8M9 h21HJ3Z.IRg7kpKUIMBw6J4gRGP99_5AOAAeGVWvItLBvLgOjszD1rl5B0IZzOcTN6MVfgiEO6G9 D38EE.wn5YNgi1b7F5ce4Tp3bDYPxwvgpNFXyCwV3Z1wI2kUCj3_enjseb3To3DLU7gSydv4C5ZO rFBdZZ8TX52gfdk5kUUDB38yy6c62gpUHI51pjF.QM50K4aG28gVJnt7se1nbelja.3_PfOES80B wYn5fRpHetrc4OcRMIa2j8kqypfoZM.OEfnUS4kHWDr6aM97Qb4mKqB0jB8lG87ekKdmlrTOAA9Y _qc8jyMAtGz854ciX6WvzMgKXBhAxffwQpJcmqi0mMq9i8k6Uu90R3BdVvOYuko6YKmwMJOnBobS 1j8BCI4D8aPmB7ro3EKp.l1zzbobJfEIafQYxbxh6V4s0kXloaPp_3nXvJSnkuj1T1Yx_AZactm3 hl6KwiB2sfDTT4iA8hMM5PdUF61SNEOwf.rSvX9S0rDAz3TlWliFbAlXnZnrt4vFYEZNQRh5Opus eAkgPFNue8zyrWksx8rqEYMQXLok1ZXVcAHUL7c2aFHLF.nufV5HipkRlI6kTEcn3vXf8RrCjmCn J1mrv4U3R3aDF7XrqemtxASI9gUP7oBz_JWCIfWad59NmZ2jClblfDPFLsV6eOfGgxXHjVTG4tdY 7sPL6WD8XnhZ06JQyk3BNAOZCjxDMI1Lbw7n5BVSslt_PjqW.tLzDlFklpKLCiuG238.mhESvaep 6KnMkLXM4hFEKdjTlc8DQ6dJrHisJ3xYEZ3Ewk2._TM8fIm3v7F3JLp2ex7BiRnrEdi26omVoWKv aGt3VX4GQIbxAJI7GlIXsXHDinW2xrvbUM7RXZAXYG_IoL1cNyTEuwtg43qXQ4agYoe8wBzOUS8e ru8oMRlyQwXMR2jXwWHd7AstIsUqtH8qProlbIFPvLZoBD.S.p_sYR_gf7CxD0cjckg_Ka7KTw_W MJhPd_ZbeTv60yW6lBAD9st1w4WAqBTP3RSawE0cr3cSONsX1lSBAIEvgbh6VZ2r2jk.GT1zjXeA BVcHBbO0vMKTeQPq0J2B7Yj7128f4SImKaF4FY7BbcpAtxtUWUPJXPRE0dFGfMfBy22fuEdA0_GU kgktZWyoOHOzaDGY_CC5zubGmxvWQachEdDM.P4vVTuNMOsW5ebgWyIcBCxpobGRuXQvyh5h5lwa OJXJAbW9DfyKwxoQafOdF3valglMgZanQJvIY2K78IHovBy9PVEY3tltJOFxsCoudcYuXehCbgPE c8Gg1C4BedQDVUnHCIO9a3IHzCbFfywpARwZjgkSkue.9i9icsltyeoQMbfev5upHSeC_Ri_l9Q7 8WawkOGOwa31yF8.US0wqx4HJ6UD_gGpOsFrmyYLKm0h6RZjFziKt1UGau3kgEPPr7BMZSQwBMBp FJNcy3m3mLqd95V8dqAVVZlYVyNC7UWe.G.PGxo23kYeqNsdn9rYIa.VhcPLMCF6KZDxo3RZ0eqv BXZW6P5mYwAzmvTZTW7yqryRBEsGqJOWO3Cna_X4clc_dHaaG2mgGBf.9aaENFW6a16sAMnzb_eg hIY2yIb2ih9PATNrWWW1pgaKls7zakAZlr2qnhBC7xfWD99mHNhC49HaJRsBEW4..EcJw1EUP8VM CMzQBk8fRrxKJse7bsNGi_KLyDWS1uQMjq.k1kAw_Wxqj6pdyg6TKs_oSmiF7PjcBil9_50Iq4o7 NsC3zfLhuO0DLKpOkkcp72sZliNYrmnsuDk86KePlardyMZ9DynTJZL6pj_2nU5EluZcJt0yvlY5 vGmRN6WQg7dXCO2nqS9hFOIhViTirdP8ClDzZnMtvpbjOOF65pKTEn.Hz6IeYvWRx6UmeNfQKz5l z5SdSU4hKd1.ICaA3EnQE247Z0OUfUZ0A92Yk6Tslam3jb24_gdVapYnfDv5msqeyfF3TXLb2ADX nzq_msCXI0cmEJX_BAki7tVbdRK7fbmA1EI2lo10RCYxOjGloMV44vPS7JrV9n5r3yX2Nsgr0Xrv cc.S3.oWJb95oXhUcxz8TRnk9_4GBaaU_GGDj0kBA_Z5w78ZsfvEISJaf5ynXKYkI6i4_suDg6Wh wgekAoVM- X-Sonic-MF: Message-ID: <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> Date: Fri, 20 May 2022 00:43:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Juergen Gross , Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> From: Chuck Zmudzinski In-Reply-To: <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4740 On 5/4/22 5:14 AM, Juergen Gross wrote: > On 04.05.22 10:31, Jan Beulich wrote: >> On 03.05.2022 15:22, Juergen Gross wrote: >>> Some drivers are using pat_enabled() in order to test availability of >>> special caching modes (WC and UC-). This will lead to false negatives >>> in case the system was booted e.g. with the "nopat" variant and the >>> BIOS did setup the PAT MSR supporting the queried mode, or if the >>> system is running as a Xen PV guest. >> ... >>> Add test functions for those caching modes instead and use them at the >>> appropriate places. >>> >>> Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with >>> pat_enabled()") >>> Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") >>> Signed-off-by: Juergen Gross >> ... >> >>> --- a/arch/x86/include/asm/pci.h >>> +++ b/arch/x86/include/asm/pci.h >>> @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, >>> int pin, int irq); >>>       #define HAVE_PCI_MMAP >>> -#define arch_can_pci_mmap_wc()    pat_enabled() >>> +#define arch_can_pci_mmap_wc()    x86_has_pat_wc() >> >> Besides this and ... >> >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>> @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void >>> *data, >>>       if (args->flags & ~(I915_MMAP_WC)) >>>           return -EINVAL; >>>   -    if (args->flags & I915_MMAP_WC && !pat_enabled()) >>> +    if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) >>>           return -ENODEV; >>>         obj = i915_gem_object_lookup(file, args->handle); >>> @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, >>>         if (HAS_LMEM(to_i915(dev))) >>>           mmap_type = I915_MMAP_TYPE_FIXED; >>> -    else if (pat_enabled()) >>> +    else if (x86_has_pat_wc()) >>>           mmap_type = I915_MMAP_TYPE_WC; >>>       else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) >>>           return -ENODEV; >>> @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device >>> *dev, void *data, >>>           break; >>>         case I915_MMAP_OFFSET_WC: >>> -        if (!pat_enabled()) >>> +        if (!x86_has_pat_wc()) >>>               return -ENODEV; >>>           type = I915_MMAP_TYPE_WC; >>>           break; >>> @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device >>> *dev, void *data, >>>           break; >>>         case I915_MMAP_OFFSET_UC: >>> -        if (!pat_enabled()) >>> +        if (!x86_has_pat_uc_minus()) >>>               return -ENODEV; >>>           type = I915_MMAP_TYPE_UC; >>>           break; >> >> ... these uses there are several more. You say nothing on why those want >> leaving unaltered. When preparing my earlier patch I did inspect them >> and came to the conclusion that these all would also better observe the >> adjusted behavior (or else I couldn't have left pat_enabled() as the >> only >> predicate). In fact, as said in the description of my earlier patch, in >> my debugging I did find the use in i915_gem_object_pin_map() to be the >> problematic one, which you leave alone. > > Oh, I missed that one, sorry. That is why your patch would not fix my Haswell unless it also touches i915_gem_object_pin_map() in drivers/gpu/drm/i915/gem/i915_gem_pages.c > > I wanted to be rather defensive in my changes, but I agree at least the > case in arch_phys_wc_add() might want to be changed, too. I think your approach needs to be more aggressive so it will fix all the known false negatives introduced by bdd8b6c98239 such as the one in i915_gem_object_pin_map(). I looked at Jan's approach and I think it would fix the issue with my Haswell as long as I don't use the nopat option. I really don't have a strong opinion on that question, but I think the nopat option as a Linux kernel option, as opposed to a hypervisor option, should only affect the kernel, and if the hypervisor provides the pat feature, then the kernel should not override that, but because of the confusion, maybe a warning could be printed with the nopat option when a hypervisor provides the feature so the user can at least have a knob to tweak if if does not behave the way the user intends. But I must admit, I don't know if the Xen hypervisor has an option also to disable pat. If not, then maybe Jan's more aggressive approach with nopat might be needed if for some reason pat really needs to be disabled in the Linux when Linux is running on Xen or another hypervisor, but I don't know of any cases when that would be needed. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 05:44:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 05:44:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333463.557292 (Exim 4.92) (envelope-from ) id 1nrvQh-0002N2-3i; Fri, 20 May 2022 05:44:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333463.557292; Fri, 20 May 2022 05:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvQh-0002Mv-02; Fri, 20 May 2022 05:44:03 +0000 Received: by outflank-mailman (input) for mailman id 333463; Fri, 20 May 2022 05:44:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvQf-0002Ml-AR; Fri, 20 May 2022 05:44:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvQf-0006jS-7o; Fri, 20 May 2022 05:44:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvQe-0001yy-T1; Fri, 20 May 2022 05:44:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrvQe-0002qR-SO; Fri, 20 May 2022 05:44:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UAj10+FJ3N9Cp5sx2oRsgLUztYz310vI31MqJWnRZQE=; b=AtXvr21OMngW8oJa2GuCWv+Gjz 9WDMHopzDzn8u7WQ0w+eKbHAEqvk1g1YYAdZ9+cL9PHyloSqZRBZr7le0Elafb8HMQsYBtzWumvc4 79A6bdCyEmvW5ItuNuNnQ8xFttqkM/3IYn4fNRHxpvaKMnepqc5JnhT9Uy8d0HicJAZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170581: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b015dcd62b86d298829990f8261d5d154b8d7af5 X-Osstest-Versions-That: linux=f993aed406eaf968ba3867a76bb46c95336a33d0 From: osstest service owner Date: Fri, 20 May 2022 05:44:00 +0000 flight 170581 linux-linus real [real] flight 170591 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170581/ http://logs.test-lab.xenproject.org/osstest/logs/170591/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 8 xen-boot fail pass in 170591-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 170591 never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 170591 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170566 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170566 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170566 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170566 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170566 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170566 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170566 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170566 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux b015dcd62b86d298829990f8261d5d154b8d7af5 baseline version: linux f993aed406eaf968ba3867a76bb46c95336a33d0 Last test of basis 170566 2022-05-19 07:54:03 Z 0 days Testing same since 170581 2022-05-19 21:41:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Elder Andre Przywara Andrew Lunn Ard Biesheuvel Arkadiusz Kubalewski Aya Levin Christophe JAILLET Dave Cain David S. Miller Duoming Zhou Eric Dumazet Eyal Birger Felix Fietkau Florian Fainelli Gal Pressman Gurucharan (A Contingent worker at Intel) Hangbin Liu Harini Katakam Helge Deller Horatiu Vultur Ido Schimmel IotaHydrae Jakub Kicinski Jarkko Nikula Jernej Skrabec Jiasheng Jiang Joachim Wiberg Joel Stanley John David Anglin Jonathan Lemon Kevin Mitchell Leonard Crestez Lin Ma Linus Torvalds Linus Walleij Maor Dickman Marc Kleine-Budde Mat Martineau Mattijs Korpershoek Maxim Mikityanskiy Michal Simek Michal Wilczynski Nikolay Aleksandrov Oz Shlomo Pablo Neira Ayuso Paolo Abeni Paul Blakey Paul Greenwalt Radhey Shyam Pandey Ritaro Takenaka Russell King (Oracle) Saeed Mahameed Shay Drory Steffen Klassert Sven Auhagen Thomas Bartschies Tony Nguyen Vadim Fedorenko Xin Long Yevgeny Kliteynik Zixuan Fu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f993aed406ea..b015dcd62b86 b015dcd62b86d298829990f8261d5d154b8d7af5 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 20 05:56:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 05:56:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333474.557302 (Exim 4.92) (envelope-from ) id 1nrvcs-0003up-E1; Fri, 20 May 2022 05:56:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333474.557302; Fri, 20 May 2022 05:56:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvcs-0003ui-BC; Fri, 20 May 2022 05:56:38 +0000 Received: by outflank-mailman (input) for mailman id 333474; Fri, 20 May 2022 05:56:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvcq-0003uZ-MX for xen-devel@lists.xenproject.org; Fri, 20 May 2022 05:56:36 +0000 Received: from sonic304-23.consmr.mail.gq1.yahoo.com (sonic304-23.consmr.mail.gq1.yahoo.com [98.137.68.204]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a1a8086-d801-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 07:56:35 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 05:56:32 +0000 Received: by hermes--canary-production-ne1-5495f4d555-7fknq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b06f9e3ae8187a718e33d020c3bbcec0; Fri, 20 May 2022 05:56:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a1a8086-d801-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653026192; bh=4Me/4JASdrdloQbgKafyPXvRt8VNrcs6HsuYguHjRzY=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=tyDM4I7Bq1sCFvdwy62MLgwnyUxAY1AhLZv1yxjv62Uq4ogSD1KShKZ5YQDNfbOvG/T9gnaTIca5Hx8QCRRmEONISsyoZr9fNSpvBwrMMJHqN4G3/O48BW8NQv3bAfVugmGERWTI6Ol+erEuVpZ9DrdyHDdpiQlKLByzeKIAKt7eCB1E9sPisoUTi/mcN1JvdAi/Ncr1n4D+zFOWtNxRJE7bWgDyxKVy++MiLvrW5x8tPpQnsIVQz4AQ50kPlELGoBCBRYGjTztZdKwtgv29yyMwVbQ7FN66veUTlDniLD+ndDEKXwjIju8VEveLYcwC2TE/hM7Pu6GFPfBx84iTmQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653026192; bh=e1dpCefxzUdOh6XsXzGjZpGDOOQHZNMaNtJy0wzKme9=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=lcUhXzacJfSlTVSsR0qS16dvnxHnyHtwxhValk1PTwNaCc7BlgpdSPEjh5ZRCfZJs3ZM1uFryUceqa9aFuCZHUT70SRHn0RN0FBdQRUpk1JGhRAdhqrD33i2oEH9mdRRD8cQ/riOQCpkURxjQjEuuu1IWOFLmEFwYVFbqLQAQFmRDpq5/PPhc4LL4L3eFXpCHYx9E6GHb4FiOwJU8InSHsWCKkYqVmd+VlBiH+cEY1fNRXotP74fVyCiiEbw28NtJ5wc+/eXaigsuRRqZPhF9HsLCXeq8ry1as4OqXhR6BVXRmh/9pWjxy/YTC72wO/ZCwks/jqPqrakPbZINLnWFQ== X-YMail-OSG: KMm6aw8VM1kY.qTbM6378OyzYj34nnkGleDCLgcsyGmHjYVmVjI5kL_I8yckJv0 5qIVK6onGiyLpH4JcLnmoA.CVosZcSSvt0pjIQc6bmHTYBdTrTtDxhfTJvTQMzzLoqPtvjxYPR4x De_PbI4lMmJedPboG4is_29kRrHeEVdPXi2c7xqd.VpMCcWJL0zfvT624g9gJCGV.QeNPjfgvvTy C3GNWOCrmtQz._lkBgdvIRa1YIslCBFbdgu4YBA8gWr56C.ZuCwhwi65zhvNkZxID8Tdf6UQTq.B jnhhHnB9F6eVekh0nvJ19oit4Pb2lUE1FV6itTgLrkCwOV7iQyUxKlrdRvsK4SXsq4MV4p4iCWjP qmtY2itdLcEJGmqTCufNRrinb51RyijQW765aewQuRXiw_8iyNId2cUwEIJRHOhKXVv5vkeSkMC0 PEmW2DsWYJB40vVFPjr5gELDmUE1Cl2lEGb8adNsJVydygQkdLjOhmpQvVbk3vGoVtNyIeZiyWxL PlPkJrgVu.ZlzvH.oAV9k1P8oqn4Awx5ItyQolilndBtznCy0AbYSnuBo5Q3INmxmrYFfoByDblW XGmVQSqLZEkCh9WvCOd8jFoWPzPSxKOzBCVdAMyVjDmbt2DlqnntwYG601cM11c9MBYynpJhcfeo Vqk89a1pBn5PUtTMEkSOvdbMY7azY2zHw1Saunyae3vONQIbZ_lY_pdl.ycsfsud4vIigJDjwpV4 dx9dwhq68nY6KyhgpYFAdgraEGZTbLJ4kL7RZp.nAvKZigXKuvLhl8Qng41XpK14SxD7BjQQwkrE i32GdytMB6JndVJ2AMurmwQ9CWQ5jhCJBLzOutyh1M.CcY.SjAs6n1JlFgC241W2D4NbOESIHS2R J1OyxUnd9eKb.U58cDvUYz3SfMzaaCkXucWPPS_Ugn2cyDyrKM_Vw2CcBXVkn1uYt_mtJtVtzUDy sPoD5DyK8SSXcIBNIxRjATYcA8njffmqyn3aWnzO2Y.RBve0wTTm5Ngyg.pAQhxGajFk_BumZxY. PeBppfoKjWxbzIECZcGAc.ROhB2cfuc.8x_hc3a3Y3KOGopUu7TYzEKydwQ4CO_CmfmJQAQljaex TPdCzp40iln9e6X2w2wsHslyin0W2kJduFhLhkOFrQ8PmckyBAgVIpM1hJL347GsEwjYcJbMjrJg beb2OJey8n0MHz96Z07edvV3FkHRPXrVFaxYStMSjscAWQRAkBoH6k4a7C6c_0agMumYw7pBEYeO lLAiGArOW9eH2Y3pFMQboWQwZFLw8cPCqnyoVS6hcBN.VlpDOx6k.40u5VQeOHlAjGzXH2d.TORG f9rdOn1jYkIrV9ru3xo4nle8FRo8fbEGBKn3BAvUszyXRYZH_Kw1TnCYaNAzlFt8UUxQc1cIMQ6y VnqEfYW6UVMulg6_ZgXyibP4swWnU2kgEBaFUWb7NWC.rcKwolwpy03898RatSamPkVX8yZvA9po eHIqtzOScS6QwXbSw8I3LCjwo8vGRjNvocy6bHlqjKwSddZiO3HtwpZx9RnCBFgv.14T7amEJ4QA 9zjQL6cQm8yNPQYrNyEBhEDyryzJtNeMRvcd_tCO_wvd5mEmGdhWsRKMD6WfU4iMGq_JqqaAkV3N 1KXWR3c8QnsvArz.enpzl1YRK19jw7uSehWza4u31OQPZ.tuHxvpqzrRON8AjzCvYDHFTJA93W3. LfIxxYUwcCaimCVdVta7vpjZJPZaXgvRU2_QlIYDi7oJR4TXrxDdwSy_6k2ziJUP3c.J_fInhToE 8YasVyj4UaHH4MwbOMzoiTX5aqbSnfVz0cLB9pBzaXLdg1Vrt8dh99POm0cKfyatH40WSWV9WhuZ wTG4E2mySRPEd0NWB7A.0Q.L1xBv5tTRGEj2qJVVy50ifILhoMAzWnfxrpfJ02HAbxuvnnFZcEJP jxmlCeFq8waUaeomuqUYC1hWw_9LRP5UW7Jy.e4BEhPwCeTA6WVCaMp5sDkPcnOuVMxnXTc3XZd8 AjLvsfSy5RlWaIMntI3URZXnisx4Rhi9mNBXGGV4in6qDmgYjQqzmvyEwnrPqHQdCfH43zC11LRW E9cvI112oFbS5iYDrG3EAnfXkUnfOBlB1woocD_gi9GfijgUt2Tfuu.IItCAoR5_PbZJsB_btMmT YJ2vUfEv83.OGFDrmXKa_ZdQi5jg2cDmgBS2m1ye6.HOUT16M6i4CBW93f7vJt.keQjUJzb5T_4_ z7huevnaSxw-- X-Sonic-MF: Message-ID: Date: Fri, 20 May 2022 01:56:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> In-Reply-To: <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2746 On 5/20/22 12:43 AM, Chuck Zmudzinski wrote: > On 5/4/22 5:14 AM, Juergen Gross wrote: >> On 04.05.22 10:31, Jan Beulich wrote: >>> On 03.05.2022 15:22, Juergen Gross wrote: >>>> Some drivers are using pat_enabled() in order to test availability of >>>> special caching modes (WC and UC-). This will lead to false negatives >>>> in case the system was booted e.g. with the "nopat" variant and the >>>> BIOS did setup the PAT MSR supporting the queried mode, or if the >>>> system is running as a Xen PV guest. >>> ... >>>> Add test functions for those caching modes instead and use them at the >>>> appropriate places. >>>> >>>> Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with >>>> pat_enabled()") >>>> Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") >>>> Signed-off-by: Juergen Gross >>> ... >>> >>> >>> ... these uses there are several more. You say nothing on why those >>> want >>> leaving unaltered. When preparing my earlier patch I did inspect them >>> and came to the conclusion that these all would also better observe the >>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>> only >>> predicate). In fact, as said in the description of my earlier patch, in >>> my debugging I did find the use in i915_gem_object_pin_map() to be the >>> problematic one, which you leave alone. >> >> Oh, I missed that one, sorry. > > That is why your patch would not fix my Haswell unless > it also touches i915_gem_object_pin_map() in > drivers/gpu/drm/i915/gem/i915_gem_pages.c > >> >> I wanted to be rather defensive in my changes, but I agree at least the >> case in arch_phys_wc_add() might want to be changed, too. > > I think your approach needs to be more aggressive so it will fix > all the known false negatives introduced by bdd8b6c98239 > such as the one in i915_gem_object_pin_map(). > > I looked at Jan's approach and I think it would fix the issue > with my Haswell as long as I don't use the nopat option. I > really don't have a strong opinion on that question, but I > think the nopat option as a Linux kernel option, as opposed > to a hypervisor option, should only affect the kernel, and > if the hypervisor provides the pat feature, then the kernel > should not override that, but because of the confusion, The confusion is: does "nopat" only mean the kernel does not provide pat to device drivers, or does it mean kernel drivers are not to use pat even if the hypervisor provides it? I think the original purpose of bdd8b6c98239 was to enable "nopat" to disable the use or pat in the i915 driver even if the feature is present from either the kernel or the hypervisor. This interpretation of the meaning of "nopat" would favor Jan's approach, I think. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 06:05:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 06:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333482.557313 (Exim 4.92) (envelope-from ) id 1nrvlZ-0005Rv-9e; Fri, 20 May 2022 06:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333482.557313; Fri, 20 May 2022 06:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvlZ-0005Ro-6o; Fri, 20 May 2022 06:05:37 +0000 Received: by outflank-mailman (input) for mailman id 333482; Fri, 20 May 2022 06:05:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvlX-0005Ri-P2 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 06:05:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc6bc4e9-d802-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 08:05:34 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-koBqpQerPPO8nhPALlYEgg-2; Fri, 20 May 2022 08:05:28 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9066.eurprd04.prod.outlook.com (2603:10a6:10:2f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Fri, 20 May 2022 06:05:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 06:05:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc6bc4e9-d802-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653026734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eftByQOw/98Iyqlou20TtEqZPQMdkwpudL9Nhw9SVt0=; b=Aoqxb/Dllrj1eVcTAZeToxMNVnZkcDbAxuarlLPKv/cS48o71BNyYZ4GbQih1008MwJr9V xkDbYM5UNvE9xJYYBcN6TQMsRdOquadpv6lT9YGhTW5aTZIXulQJr8U+jFCJU4ffVgdUqz YWRuJmbqF3gI2SY19AIAmSR6mWwqnoY= X-MC-Unique: koBqpQerPPO8nhPALlYEgg-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N3KQjM4qp5R7ecaDbrCUMnEGf/qo7T8n2dPXyLhaZ2JcWt0deiPB1OYaR23Hw0D2TTdP4N2S1qxeZNPKuObgTA82J2UIGuXtnsA0yFT584ppU4Z/Z7qOvk6xUKLXxzoknCF3Cxq8gsmToXXC3G+2bwoczRJGRqk0Vw54lVpA0NUw5aIc5IuSh4R3yv2XgPAr5WCi1LVvu6pdLWaovYXXmKuT0Pi3RkekrTjeAh47XDHRvrf63yroKFInrLus7Q0fdXBX33h1emOl8Ufu1226zHktCq1LC9fScLr8VCU+Dj05DkFyO3YBNtKKZthdT6AvrsD6K8ua2UCDvb7wDZtMBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P21rAljciaAKLSv3QWyYdNHHhSpmhmRlZkvtfIBJeeM=; b=SqNu0ZKu0wo4kJQjyDpMXwYMaWOX9a8D8FQdIvPMvAsulj+WUnD041W3kmZjc9h68u08V3XENCYt8NwQlOvK+lEPLrmztBQ2oR0QewJOh6McLvbASDWwOCo4wTGmR6cSkBIptGySzQpJ9dLVpVHCAryX7INYjIganE8aeLUtsaBMalzoPTrsG4slQ2pcBPf6/VJnQLohuR/mNapIFtI9IezJ09HVS58MG2X+HOX2FHqe2CV3go6LRL0G3OI/nWXxa03MWqzkKZNG1ISD4H4WbkSK8xPBLDZmXqnrmW1zoELVuzAn09jm9Jqp2P5ZFE9l2YmN7KGgFfeL1C5ARnubvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 08:05:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Chuck Zmudzinski CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> From: Jan Beulich In-Reply-To: <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89e43463-1c92-474b-376c-08da3a26baca X-MS-TrafficTypeDiagnostic: DU2PR04MB9066:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETEc8JRAdWVHpZKwiVrOc7nwAXI8itNVTqRz5VMcrU7SBV+qlyPzbaN12Xl07lNg7mvlW/GBydxdQyoVumdWLupXB22XNEEX7kecGC0sveRs/qrTFBoYr5Ip9gh0T5+xdg0aXg6ycJ4vaQYUHa8JCIk4UbPBfr6IVKLd0ADlMEHNboUdbHIBr1wfB+mwfhrDDs7x3Wqg8st8K6Tx2CKbp6B7JuwGyDUa/2Jjys0pAOhCfvaodOiTzNF0kQ4ScRgSFIHkA8UOSEZ8/H1Lx5vsVX0SiwZtNlqdyY/346Frq56ejR5VkWIJ6b6zk7s2CDkeJ1DO184XA/kLIJaUwJgm9pimDHvbuh8MF8lcV1re+mmbzRfm8Uz9HeV/zeQsV7lDyGQFladm364MWS/71I17pQdTjYz5A2VbIVSv5fse1KXQgrUor2YrZQx76uDub4KTQPCM2SMmpCjrlIf1/OB8vEwvVV7m624KdjLo/nTNWselz48jU+oynQt8nhjrMyfvd/cm99MXkdwQ/zwdGUbmdi7kd0afFXiTo8gQdxm6jMdEMiISYa8K13TtOg2r8h/3akKhbd4ihdE+4/eTDKqNK3Fpk2FZl9q6HJRf2kRDBXftVvoAt3KrpabJ5BjWEhY3xMuSswF1EJSN1WEjZYj8iICGc2CXZsjyeDdHorucH569Ih2cLyYV7jU5sEw0ZDuHItfU0DjQLYrCt6Br7GIHizmHy/f4k15NM3PelAA4OwA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(83380400001)(316002)(2616005)(36756003)(6916009)(31686004)(38100700002)(66556008)(66946007)(8676002)(4326008)(6486002)(508600001)(107886003)(6512007)(6666004)(2906002)(53546011)(5660300002)(86362001)(8936002)(54906003)(31696002)(6506007)(26005)(66476007)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g48/Tuk3XWFbnSqtRBTSYTbU318qy8GrOJwMMqgwMzGd3UHT/w5KtVf/bhQl?= =?us-ascii?Q?Roc2uIZZ0Inq+u5l9utd73cq1poi+7NU073o2JoxZuy6Wzny7r8XECMSUQC/?= =?us-ascii?Q?1xCBh6WBpZTP5noCw/GT2Bf2tJgn2CmohdU+lRKUKFoaHGuexHTUP/sZ8p3g?= =?us-ascii?Q?KqMhabJNfQ7t1AC9deo+7FY4oKby4iIccsU/MyWxgV8nGiTNAumvAFRyKV03?= =?us-ascii?Q?RcNPUvBhpAXWSXY22CP1T9GQC31VhDjfGdTshJwoNV2JxGSDV2jta3cFio8T?= =?us-ascii?Q?xW9MzERJPu4URRCUhPlVjt9Y8nqzDKh7qsdYrVRziZ3Z43aXPH9QMT21Zy3q?= =?us-ascii?Q?NNFAoWiYodIhD53oYZq7KT2p+5G/qXWgD93Fu66WuG0a3LkI48SXSdejrL6G?= =?us-ascii?Q?Ec+DcWEc46QJzuJ540YA0YFLOYG1fJPLF/g53pkhvtR2Kb1k738AtL6dEr9u?= =?us-ascii?Q?Eboed82wcxmyZppS9B9+757PqVrnGPDGUbgVQJ7FDi3U6fwbQJy6Ga4HFxlZ?= =?us-ascii?Q?W8BXnZDn0+rDP3WYzAsWwdxyiBQL2FSb6SCtPhyxB69HqDlX+ovHL9ku6o7F?= =?us-ascii?Q?u0ry6oXyLOwjFiZS0/Mwd3JZKo4mw3u3a/09sT1X6Zf3uLol8NoHiX76npSX?= =?us-ascii?Q?Jwc7qboNnYAq75pm0mXpV8NSDj7vGIr6yLXAJ5s30p4uS686tuoAWRMeYSfg?= =?us-ascii?Q?64+1ARwLr4Jg+azL+HnMxsl55mZuG9ehc9WAVeORabjGfXTLSRDoDyFG0v/0?= =?us-ascii?Q?+IXqIV5VU4ARu7mePLbgb1Oo3sv35KIehFY3Ynjmf1uqVDwqkiZ6bUtwPXnf?= =?us-ascii?Q?QWPmX7JKCjKeZUiJBQPysqTA5QGvFJuKvGPcg9CZb8dlrhhmILvyie/6yRRM?= =?us-ascii?Q?J0z0ejpLV/0J9sv7geO5adwFcOimZjF+T+SbfnXYw9b5ik1ar04xy5v5tdr0?= =?us-ascii?Q?juUNv1oOZ8p06auQdR8AEUGEFRmXmFbUOgczPvdJQyWIzkPhY58evLMnYSbf?= =?us-ascii?Q?Mhp5nXT3pxsU6kBH3nZzC71ajbaILW/JsjEwUOWIaSQ4XN1RQitUI+WmgF6j?= =?us-ascii?Q?nPOOH8rtk97akb2ZyTUbeiSfYtzOq52qQ27lkFKHe8TpImJ8IrQZwPuqu4Yk?= =?us-ascii?Q?m5DW5gQnr17VCXHh7QtkJU+b2Z7zzDbuUFEisL9PBb5GJtqjSaZ+MD0Edp9X?= =?us-ascii?Q?l46MsjzV603+C77Hg77qUZe430pXlTeVwQAnWiM0+JX5gBpK4Wn3DFqxNkcU?= =?us-ascii?Q?eBCpLxLMBAHshkT502SsmyFXs9yD9T8mCP/yXmrVNKQRieQuGC+e8GlFRxZt?= =?us-ascii?Q?PiEldgLAUukpXmPfT2pZGkDlV7jPxWttDPibZjxDYRS93LPmDX56IxgUhDDn?= =?us-ascii?Q?EPaNAelsbiL1rvpMBv3mqSys8+y91L5xJj8p5wnUo41VY3s3mizEU8qodtq7?= =?us-ascii?Q?IOoyURw3ifMXEHBeycXMr1qY5rzxjVahy2xjs47DIczyi8FKjK6Kc8iFeJuL?= =?us-ascii?Q?RMnQaqSYJCpwIyJXSrEcD2HkWq9A7Ah3GErNfrBplZ1YE6GCpEcpXHXSPhUS?= =?us-ascii?Q?zr20I6lVYGCLD4KULrF933NpizjBUQ19QHuiKQswA/U+2kQGt/GbZvOIdM9O?= =?us-ascii?Q?WdspQlp3M/F3K8JJBFV+jtOaclbWnaRfd30Rgv9Ts+sQphziPfh33WQQChpZ?= =?us-ascii?Q?bXlzfBkVZtUPFMmTMZ13CzOsuWJnlAveSbCysrsZkJh4AsHHJ3nMtSP45Wqj?= =?us-ascii?Q?dRDrbl8Dzw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89e43463-1c92-474b-376c-08da3a26baca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 06:05:24.5360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H2WUDTGiEHuZmmVuglqYS/UwXc6+bkKPBmjlCfHQOA4kSEEBTV5kD/OW7CEkFidsY/5r7LXByR3cn7+zAo/GAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9066 On 20.05.2022 06:43, Chuck Zmudzinski wrote: > On 5/4/22 5:14 AM, Juergen Gross wrote: >> On 04.05.22 10:31, Jan Beulich wrote: >>> On 03.05.2022 15:22, Juergen Gross wrote: >>>> Some drivers are using pat_enabled() in order to test availability of >>>> special caching modes (WC and UC-). This will lead to false negatives >>>> in case the system was booted e.g. with the "nopat" variant and the >>>> BIOS did setup the PAT MSR supporting the queried mode, or if the >>>> system is running as a Xen PV guest. >>> ... >>>> Add test functions for those caching modes instead and use them at the >>>> appropriate places. >>>> >>>> Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with=20 >>>> pat_enabled()") >>>> Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") >>>> Signed-off-by: Juergen Gross >>> ... >>> >>>> --- a/arch/x86/include/asm/pci.h >>>> +++ b/arch/x86/include/asm/pci.h >>>> @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev,=20 >>>> int pin, int irq); >>>> =C2=A0 =C2=A0 =C2=A0 #define HAVE_PCI_MMAP >>>> -#define arch_can_pci_mmap_wc()=C2=A0=C2=A0=C2=A0 pat_enabled() >>>> +#define arch_can_pci_mmap_wc()=C2=A0=C2=A0=C2=A0 x86_has_pat_wc() >>> >>> Besides this and ... >>> >>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>>> @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void=20 >>>> *data, >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (args->flags & ~(I915_MMAP_WC)) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EINVAL; >>>> =C2=A0 -=C2=A0=C2=A0=C2=A0 if (args->flags & I915_MMAP_WC && !pat_enab= led()) >>>> +=C2=A0=C2=A0=C2=A0 if (args->flags & I915_MMAP_WC && !x86_has_pat_wc(= )) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENODEV; >>>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 obj =3D i915_gem_object_lookup(f= ile, args->handle); >>>> @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, >>>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (HAS_LMEM(to_i915(dev))) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mmap_type =3D I= 915_MMAP_TYPE_FIXED; >>>> -=C2=A0=C2=A0=C2=A0 else if (pat_enabled()) >>>> +=C2=A0=C2=A0=C2=A0 else if (x86_has_pat_wc()) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mmap_type =3D I= 915_MMAP_TYPE_WC; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if (!i915_ggtt_has_aperture(to_gt(= i915)->ggtt)) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENODEV; >>>> @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device=20 >>>> *dev, void *data, >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case I915_MMAP_OFFSET_WC: >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!pat_enabled()) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!x86_has_pat_wc()) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 return -ENODEV; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 type =3D I915_M= MAP_TYPE_WC; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>>> @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device=20 >>>> *dev, void *data, >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case I915_MMAP_OFFSET_UC: >>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!pat_enabled()) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!x86_has_pat_uc_minus(= )) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 return -ENODEV; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 type =3D I915_M= MAP_TYPE_UC; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>> >>> ... these uses there are several more. You say nothing on why those wan= t >>> leaving unaltered. When preparing my earlier patch I did inspect them >>> and came to the conclusion that these all would also better observe the >>> adjusted behavior (or else I couldn't have left pat_enabled() as the=20 >>> only >>> predicate). In fact, as said in the description of my earlier patch, in >>> my debugging I did find the use in i915_gem_object_pin_map() to be the >>> problematic one, which you leave alone. >> >> Oh, I missed that one, sorry. >=20 > That is why your patch would not fix my Haswell unless > it also touches i915_gem_object_pin_map() in > drivers/gpu/drm/i915/gem/i915_gem_pages.c >=20 >> >> I wanted to be rather defensive in my changes, but I agree at least the >> case in arch_phys_wc_add() might want to be changed, too. >=20 > I think your approach needs to be more aggressive so it will fix > all the known false negatives introduced by bdd8b6c98239 > such as the one in i915_gem_object_pin_map(). >=20 > I looked at Jan's approach and I think it would fix the issue > with my Haswell as long as I don't use the nopat option. I > really don't have a strong opinion on that question, but I > think the nopat option as a Linux kernel option, as opposed > to a hypervisor option, should only affect the kernel, and > if the hypervisor provides the pat feature, then the kernel > should not override that, Hmm, why would the kernel not be allowed to override that? Such an override would affect only the single domain where the kernel runs; other domains could take their own decisions. Also, for the sake of completeness: "nopat" used when running on bare metal has the same bad effect on system boot, so there pretty clearly is an error cleanup issue in the i915 driver. But that's orthogonal, and I expect the maintainers may not even care (but tell us "don't do that then"). Jan > but because of the confusion, maybe > a warning could be printed with the nopat option when a > hypervisor provides the feature so the user can at least have a > knob to tweak if if does not behave the way the user intends. > But I must admit, I don't know if the Xen hypervisor has an > option also to disable pat. If not, then maybe Jan's more > aggressive approach with nopat might be needed if for > some reason pat really needs to be disabled in the Linux > when Linux is running on Xen or another hypervisor, but I don't > know of any cases when that would be needed. >=20 > Chuck >=20 From xen-devel-bounces@lists.xenproject.org Fri May 20 06:11:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 06:11:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333490.557325 (Exim 4.92) (envelope-from ) id 1nrvrO-0006t0-Vn; Fri, 20 May 2022 06:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333490.557325; Fri, 20 May 2022 06:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvrO-0006st-SE; Fri, 20 May 2022 06:11:38 +0000 Received: by outflank-mailman (input) for mailman id 333490; Fri, 20 May 2022 06:11:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvrO-0006sj-59; Fri, 20 May 2022 06:11:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvrO-0007HQ-3i; Fri, 20 May 2022 06:11:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvrN-0004Rr-OT; Fri, 20 May 2022 06:11:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrvrN-0004gw-Nx; Fri, 20 May 2022 06:11:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7cj6wtsD3SmE23JDEaCwlOjJzuljBSWfvwbr4l1IOfk=; b=tl2Ki+WcE8pf382E2AkGX7uboe EGFn4Ls9qTYoNv61v/VbKXot0bZoSv59a8cj419DjoDdZVcjmJ2UdLem/vehRDRGkEi2n8iHVIoCi kEaDY4e1pArN3OwYGE7JiMqK8ptOP7/gxvbc1yZXhYsUwtKqfieb7WNRclG4PHZOl1eg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170590: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a72d552f197b9b5cc3afdf22891b27ecf4067037 X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 06:11:37 +0000 flight 170590 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170590/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a72d552f197b9b5cc3afdf22891b27ecf4067037 baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1112 attempts Testing same since 170585 2022-05-20 01:43:00 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6940 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 06:14:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 06:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333501.557335 (Exim 4.92) (envelope-from ) id 1nrvuU-0007Zw-HE; Fri, 20 May 2022 06:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333501.557335; Fri, 20 May 2022 06:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvuU-0007Zp-EQ; Fri, 20 May 2022 06:14:50 +0000 Received: by outflank-mailman (input) for mailman id 333501; Fri, 20 May 2022 06:14:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrvuT-0007Zh-57 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 06:14:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2633492e-d804-11ec-837e-e5687231ffcc; Fri, 20 May 2022 08:14:47 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2176.outbound.protection.outlook.com [104.47.51.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-kbXw-wdRNLSqJJ1_LYgLlg-1; Fri, 20 May 2022 08:14:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4984.eurprd04.prod.outlook.com (2603:10a6:20b:7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 06:14:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 06:14:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2633492e-d804-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653027287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lm9r80XAjw+zFjEQ3Obx4Nqk6FGu/MOVjmR5iQ3sb/Y=; b=C4aJyWBZW8scAJAJ/aKXuEpL3nz51tUMt9swzY9eYGq0xdkBiExRLp7y5k64r7NiyAwvNX lTcgGlfYAd1oZX7Bizv2VFLEhKcMMmnZGccsIKPS93NNzxOdSyeUFeuqBMFsWP87vZuHyq MM7OG6TPKSmeoYdGCzwOFXq1xwfDU9E= X-MC-Unique: kbXw-wdRNLSqJJ1_LYgLlg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kiq9Q3a5V67B62hOUi+xhhlvgepLZr0XyAT+aFDpH8j/w/DyBtsYxJGwT2y6zi4yb+OUS1oZoqBJ7Yst4D19mrB2GQYO104IWT6pqk1oVIBZbDPQDuD+IzU3cpXZqgPaSwjg1ErjGa5vqdsBh4AC7AjblylWZIB/Sra7AxQe+daV3j6KBWRejJgS1gFTVD9l5aeTS2GBRzteMGHXTeL6IGA4alBJDATJcuEhFxGP9ckltY51bhX8i9iNy5g93VbaQsIz+MAg/agMsA5vQPUR/7Lx3uG4XYhCv5vPD4reikY8W3UNH2tJamdDaD6juIgddJk+QrxSpR1egB3+ryx7RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f8X2aNgt1CsGcGvfrF170fWe+Xr2h091MkLh4PLn4cc=; b=l0v0Jh58MPcRJw6ol0BmwsojmmG8b0rKPS76Qkop5JKdzsGR6Dj1ZSx45Dqld3581wy7cVR5Ek7RqnVrCfCUuL3tV5glHZUzdNIFTpFVr94J+VFSEOslOcjowtkPmTxhrSq/EwTbDZ3n9cxKFyCnb6NN4IIskE9VqQtmSVi8wh65BfllR1mLkWYqrhSGHeTSkLdUV/2yJYnWOzaXtscnR2npl/9l3TWgT2UJr3T7+C+z2Vp/aVVO4MX32GNiuOWJVSud3sf7eCoMZEFNOPvitI32CiPMXKeZEwgEV6ch9KEgGsybDsZcu6blRtEJ2VbJTDUh02UhZYpI/Wu33shFLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 08:14:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour CC: "xen-devel@lists.xenproject.org" References: <2add184c-04a5-3ca0-876d-e354f35df62a@suse.com> <05d4fa5b-78d6-96e6-b643-a98d26ec954f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM7PR04CA0003.eurprd04.prod.outlook.com (2603:10a6:20b:110::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b953695-d1ef-4cd2-3144-08da3a280905 X-MS-TrafficTypeDiagnostic: AM6PR04MB4984:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j32+LkI79RjQhUE0Ug75FoTAPJf0fEIs2dXW06B1o/uONdOwy8YM4KzPrUWdCZT85pFBNg3wfreapXF1BSe8Drs6tqkazLjeoDlbON4CWoSZoXMUZLq9HBiBhj0nVFXxVU7x5bOvOe33UIwZ9tFUtL/7PZt6O4ec04wt7+kgsC/787pJTChvc3RH5nEZTZz390+CX/uhJuUtBQ+AJpidCY2SRaPawvWvXOJzANXG3rIA1h5D9E2tbUS2Ee5TTE8y9HLcv7xuoGPKBBhazZ2i66+Ao+MUsTCJp5kxZI+4cEBAEED52ejPYrlPFWLLz9dLtl2ry+WOjmgPYzQqZGsvOazK4J/aeVrZbl59aEVBler8BvmUmqvoQMB0QsT7WO+BwBhZrYSzpke5LUyEZgF4XtvyTK8zYqkm7oyjvKQFrezZvPpYbh9FWR7GPJBymlrVKEa9Q8B+L99iOrhrRxxHbdwU2hVtP7ClzVvR5sZLJUEuuUpdQ41ehmjgl/shGA4qwSAEGgTPp/srQe/JV6M236Gba/jz/Nk1ySE5oH+hlwz8Zz1VnRY+qZjmdg8ug19658qDsMOtRigiY9vnhMqH2LvE+to2PrXQ5O5rYu243MUTNe0rnecDQMHSufaOlpVOBDDhJX96rP49pAepBSrxgv/RIh23RBByjywOXkT9Zl8G85Zyj/UUbyY9Tlwi+QHZTCf74BqPgQtZlxX+c8miZh9BiJSroKw0HQ92bWqSf84= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(66476007)(8936002)(5660300002)(6486002)(66556008)(38100700002)(508600001)(31686004)(2906002)(2616005)(186003)(66946007)(86362001)(26005)(53546011)(316002)(6512007)(6506007)(6916009)(4326008)(31696002)(8676002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1hKfBYBeHbc2P7c3dZSHD9SUekqDYIQbKbhg0q5dWxLp1JHf3fLzcHF83RNr?= =?us-ascii?Q?N2Sf6HozK216JvE3eRjad2Kwsg18dQLMDK+GUBpwt/7Jn5ZTjZwvmeUiLFEC?= =?us-ascii?Q?okWGSYGg78A4ayFe3JfYZWg0vx0XK5cFTWerim6Jx+73TeBitIh7/DDk6mmX?= =?us-ascii?Q?6TKo56qm0Tw+BFcWMNpxkqzzcctiMAjUqNSDGzATRqynTHIyHcTjwlkQYOMu?= =?us-ascii?Q?YeJIRtOA34drZiHeqxhrobcTofU6xjQKbnJWnZbTn1h1IismP8Z6nhhQuc61?= =?us-ascii?Q?jnQjRnSIE+hu0TPPhj+1lS+HgtYWgLbSIvHMNejGwGPXkjQe70Gx2j0960Mn?= =?us-ascii?Q?sLTTVOpN2gvuNEmvRx72sCyAdcGRfBq8eLKYw7PBX/STZeDL9d98nbGnmesX?= =?us-ascii?Q?rkatMKRS88v2WKZ9GKHYViaZ3TxCKHbgeXfYL/EPE+J1vA4NDWZ5uNwMy4/5?= =?us-ascii?Q?LdM5IwEtYtMjxUAyHf4ZGdrSEivJuWGztoLFg2JmBQ4IidJj7JBdkaHt6jKJ?= =?us-ascii?Q?7XXSH+tcJouqWjMb1icXg0y/TMhP4ggPXINseSkobWducxVAoiO1Jj/Puuqx?= =?us-ascii?Q?+BD5egtgXeLs3fyyr74Q4/7muFYUOUFuFftQKBcLoOOy7LggU6qCY2tgEDK6?= =?us-ascii?Q?TBYKBVdAANpX7itPYuboqfL73gblHAS0dGQLnwHH8ulk53951jHYaPYMwDfh?= =?us-ascii?Q?BkAvsIGRH2MfC4Y28wee0C5wR4VESmkN7raI1bhSMgb0ghEDV4mDoE5EKYnj?= =?us-ascii?Q?E1SM6EpBr/Ns87I9wyNSrN9WeUzXRsJLiPDi/Ch6KMi+1WTm5SCJGzV30KQD?= =?us-ascii?Q?rpSNR6o+/oddxS8t6RSt4o2hSegzLp1KYOebe9KX/eZ83GFcD/mak7CSDxyV?= =?us-ascii?Q?uVlKAbhky2OjHEIPOwuWNN4mfTpF7t2Y7pov0hipW41yM2aZbJIqarYU1qIj?= =?us-ascii?Q?QM+NT2zc/3sukroe//uqkKT0MBHm/yUab0YP2+XohShg4Yfy3ILDFvmAtTgL?= =?us-ascii?Q?AGbqQKo9ZbrScgGeU6cxncCeLJ15QFxFHe+4PPAH7nJ3FguCxn+20EXXoCaA?= =?us-ascii?Q?3aQjtciHVUBEJSBNE2zTZzOz6+pZWveHWvs9T43WlaFeS/UYq7crkRtqb44U?= =?us-ascii?Q?2kmdBAva/vlSvTqt4SV1DesPBVFMYm5fVChtByX1y4eN+Iv21gQMtF1b9319?= =?us-ascii?Q?Q5+zx+mzJfuByWZNZb1rk1kyRl2MQEvzd95xT8hq1Rp9EWJ/9fNq1B3dnejx?= =?us-ascii?Q?Z49dny+zB/Iut5SA5scdlp8vNZTY9q9kCMe5o1rQniWdbkS/qC5QZX6QPjdO?= =?us-ascii?Q?4Ryripn/kBYN5Nfylbb2C0Wcg9Hcet6meIz8wLyW9j26Z+ISXtpu3bqyoZH7?= =?us-ascii?Q?xCqjsHAJ8WfyIxEfvzaZ0ibMdaRRvwn4TH8obMHaLIDL3JSRHQ329tbNqCr4?= =?us-ascii?Q?1uHmb8+TEXyRtvt9RQlUKSGUSnKZ0dfzDB5aDp7aoQh4sBXUMaG1tHLKQ/mn?= =?us-ascii?Q?HFf4+ZFVjGi2bdOmwTiNtg9CkBVWo4Gkf4Bh/52mkq2Z40or5f2QZVX/BUJB?= =?us-ascii?Q?ygMb3auFeerMpIthP56rSPIGJuSQ/S5e+kFfiUObdaRH41isEr9NW/OAzNgZ?= =?us-ascii?Q?QwadfVayH/ZQ3XRFtwvChdy5jyoV+oXOGBXPztyQHlkV4qtiAv84Mq+hSDES?= =?us-ascii?Q?1AI10Zlcf/IPBqG+Bpb767j0FohiAn1UnYUVNsYhf5jeCrC3vjmMoEa11agI?= =?us-ascii?Q?uURAXQ7suQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b953695-d1ef-4cd2-3144-08da3a280905 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 06:14:45.2034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 49Cvele4kxYUhpl4WaUy+trcSywLWAZh0aZt6uUVQ6YRL715U7s6YKyQOCo1QDyGPcDB7cHxiQMyHrzeTzPBkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4984 On 19.05.2022 17:09, Demi Marie Obenour wrote: > On Thu, May 19, 2022 at 04:55:10PM +0200, Jan Beulich wrote: >> On 19.05.2022 16:45, Demi Marie Obenour wrote: >>> On Thu, May 19, 2022 at 12:32:33PM +0200, Jan Beulich wrote: >>>> On 18.05.2022 19:32, Demi Marie Obenour wrote: >>>>> + /* >>>>> + * The specification requires EfiBootServicesData, but accept >>>>> + * EfiRuntimeServicesData, which is a more logical choice. >>>>> + */ >>>>> + if ( (desc->Type !=3D EfiRuntimeServicesData) && >>>>> + (desc->Type !=3D EfiBootServicesData) ) >>>>> + return 0; >>>>> + available_len =3D len - (esrt - physical_start); >>>>> + if ( available_len <=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entr= ies) ) >>>>> + return 0; >>>>> + available_len -=3D offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); >>>>> + esrt_ptr =3D (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; >>>>> + if ( esrt_ptr->FwResourceVersion !=3D EFI_SYSTEM_RESOURCE_TABLE_= FIRMWARE_RESOURCE_VERSION || >>>> >>>> Nit (style): Overlong line. >>> >>> Where is the best place to split this? >>> EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION is a rather long >>> identifier. >> >> There's no good place to split; the only possible (imo) place is after >> the !=3D . >=20 > Will do in v7, along with parentheses to avoid any visual confusion. >=20 >>>>> @@ -1067,6 +1122,46 @@ static void __init efi_exit_boot(EFI_HANDLE Im= ageHandle, EFI_SYSTEM_TABLE *Syste >>>>> if ( !efi_memmap ) >>>>> blexit(L"Unable to allocate memory for EFI memory map"); >>>>> =20 >>>>> + efi_memmap_size =3D info_size; >>>> >>>> I don't think this global needs setting here, yet? The local will >>>> do just fine here, likely yielding smaller code. But I realize that's >>>> connected to how you did your change vs what I was expecting you to >>>> do (see below). >>>> >>>>> + status =3D SystemTable->BootServices->GetMemoryMap(&efi_memmap_s= ize, >>>>> + efi_memmap, &ma= p_key, >>>>> + &efi_mdesc_size= , >>>>> + &mdesc_ver); >>>>> + if ( EFI_ERROR(status) ) >>>>> + PrintErrMesg(L"Cannot obtain memory map", status); >>>>> + >>>>> + /* Try to obtain the ESRT. Errors are not fatal. */ >>>>> + for ( i =3D 0; i < efi_memmap_size; i +=3D efi_mdesc_size ) >>>>> + { >>>>> + /* >>>>> + * ESRT needs to be moved to memory of type EfiRuntimeServic= esData >>>>> + * so that the memory it is in will not be used for other pu= rposes. >>>>> + */ >>>>> + void *new_esrt =3D NULL; >>>>> + size_t esrt_size =3D get_esrt_size(efi_memmap + i); >>>>> + >>>>> + if ( !esrt_size ) >>>>> + continue; >>>>> + if ( ((EFI_MEMORY_DESCRIPTOR *)(efi_memmap + i))->Type =3D= =3D >>>>> + EfiRuntimeServicesData ) >>>>> + break; /* ESRT already safe from reuse */ >>>>> + status =3D efi_bs->AllocatePool(EfiRuntimeServicesData, esrt= _size, >>>>> + &new_esrt); >>>> >>>> I should have re-raised the earlier voiced concern when reviewing v5 (= or >>>> maybe already v4), and I'm sorry for not having paid close enough >>>> attention: This may add up to two more entries in the memory map (if a= n >>>> entry is split and its middle part is used; of course with an unusual >>>> implementation there could be even more of a growth). Yet below your >>>> addition, before obtaining the final memory map, you don't re- obtain >>>> (and re-increase) the size needed. As to (re-)increase: In fact, prior >>>> to the allocation you do there shouldn't be a need to bump the space b= y >>>> 8 extra entries. That's a safety measure only for possible allocations >>>> happening across ExitBootServices(). >>>> >>>> And yes, in earlier versions you had >>>> >>>> - info_size +=3D 8 * efi_mdesc_size; >>>> + info_size +=3D 8 * (efi_mdesc_size + 1); >>>> >>>> there, but that's not what would be needed anyway (if trying to avoid >>>> a 2nd pass of establishing the needed size). Instead in such an event >>>> you need to bump 8 to 10 (or at least 9, when assuming that normally i= t >>>> wouldn't be the middle part of a new range which would be used, but >>>> rather the leading or trailing one). >>>> >>>> While I'd be okay with addressing the two nits above while committing, >>>> this allocation size aspect first wants settling on. Personally I'd >>>> prefer the more involved solution, but I'd be okay with merely >>>> bumping the 8 (plus the addition of a suitable comment, explaining >>>> the now multiple [two] constituent parts of a seemingly arbitrary >>>> number). If you want to go this easier route, I guess I could also >>>> make that adjustment while committing (and adding my R-b). >>> >>> I would prefer the more involved solution too, but I am not quite sure >>> how to implement it. Should Xen call GetMemoryMap() in a loop, retryin= g >>> as long as it returns EFI_BUFFER_TOO_SMALL? If I do get >>> EFI_BUFFER_TOO_SMALL, how should I allocate memory for the new buffer? >>> Should I ask ebmalloc() to provide all remaining memory, and then tell >>> it how much was actually used? >> >> Well, there are certainly multiple options. I was thinking that you'd >> add a new call to size the memory map, add a few (again 8?) extra >> entries there as well for the allocation, and leave the present sizing >> call effectively alone (and sitting after all of your additions). >=20 > How should I allocate memory for the new memory map? Getting the size > is easy; allocating the memory is the tricky part. That=E2=80=99s where = the > idea of calling AllocatePool() and GetMemoryMap() in a loop came from. Just like it's done now. GetMemoryMap(), AllocatePool(), GetMemoryMap(). I don't think you _need_ any loop for that, but you may well code it that way if that looks neater to you. All I'm asking for is that you leave the existing code largely undisturbed, which - as a consequence - means that I don't think the logic strictly needs to live in efi_exit_boot() (iirc I did hint at that before). But of course we want to avoid relocating the blob and then exit for some trivial error (like the kernel image not being readable), so it can't be done arbitrarily early. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 06:25:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 06:25:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333509.557346 (Exim 4.92) (envelope-from ) id 1nrw4F-0000bn-FE; Fri, 20 May 2022 06:24:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333509.557346; Fri, 20 May 2022 06:24:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrw4F-0000bg-CV; Fri, 20 May 2022 06:24:55 +0000 Received: by outflank-mailman (input) for mailman id 333509; Fri, 20 May 2022 06:24:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrw4E-0000bV-C7 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 06:24:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f29c293-d805-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 08:24:53 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-27-o7bhSYRwP4WUtylg8lVrmQ-1; Fri, 20 May 2022 08:24:51 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8817.eurprd04.prod.outlook.com (2603:10a6:20b:42c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 06:24:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 06:24:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f29c293-d805-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653027892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0yvV6XaqRyg33fLdED6d6S29/wXFFo5+6nKAJQOkLvI=; b=jmcnnFfcaVJ4GxD/YnvpzTevJITrOSgJt+Ee/mmdarAKVBV147WrRfhwlND63dZFMyU/VO EWi5tvLlkJlTwS8PsRab/k6bmMuOr/YtuWqcjSQt8XmLPC26GfDNplmbhlFye1jt/gp+M8 6EW0dsgcI0LHSFpJ0jBEO0J1iiTvTvs= X-MC-Unique: o7bhSYRwP4WUtylg8lVrmQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+D+QmOIPtrvK/TMt17aQ7g7ympV3NMSuNBJ3WSGngyXl8bcBEhYJPT/guY4v9Gp1hDsjtIWQL+smVXfE46YACDNPyL+iPYvPcjK7LXh3B2RIBQpDhyx7RxDI7bOGtUOcuhytvi0EKe3DD7K5D+oppPjGOwE9Yz5wN//H/YEdrf5SfqESPFpXGUJHhvw2u9QtWW0u8K7KD4BS5Ql1XxP+J7OBo0VxsXTO+kNU6l9aWwIQYv5BHr33TyFGNueJ3RU8GxKzkKuqBp7VIkaqw4Lcv3K4ETtp+3Cfa13m0BiLCTLY9LgWRU59Bp/ZTed8t2K+EDKR5IjFqXK6pNJiKYiMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yvV6XaqRyg33fLdED6d6S29/wXFFo5+6nKAJQOkLvI=; b=RjAjRN5eIneuOcbGFU2kkpVaYPn4K6zy2S5hNymMvLrvXk9q7wcVCA8EqZdyj47tCFf/xKxrfb6xkL6b98jpp/LK9jc0hdabagpeo2Uos0qi6am0YH6GXtFHbZRnd7GYwJtM8tKwl6BEmoL3Y6oQOuIkVHstPriJLqZ8/9u9hZ/XltIHW0+aBW+bc7WrPxrgxzV40CDGYXOvvbKiLrQV5aIDjj8S5TVrCzh2iNVVADo3tlT9h0x8PVXvs1ubLu7++gEz+LCluC5ghfw15uO4YSpjgBwy64rsIrJgVpw/twNhIJNAzRAb7p1RKfMFWH+qL4g2kJBWjKwPRuL9Kl8MXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 08:24:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Grant operation batching Content-Language: en-US To: Demi Marie Obenour References: Cc: Xen developer discussion From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0040.eurprd04.prod.outlook.com (2603:10a6:20b:312::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 623e8493-0adb-4c4c-089c-08da3a29718f X-MS-TrafficTypeDiagnostic: AS8PR04MB8817:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N4oSfEZ0Kx/U0Zxj/qx88tsnSnejRuRt8Vee1ie1dC+grfRo9pszQbUzQPMrfb+JtBYSTBMZPkI9F5YkflSiH2je0K7XwgFJ8y9CHruCaTFKr4dRRm1H6s6fON3UjP23+E4Bo/xDdP/a2zyTcyGgI1/cIm4PmvDY+NlHJk0MGB6Yzp4ZSwRzPqqlAAXXPUAd+PmdceTn2g77WqGSSnKj86Q2z8P6ierejUma1+n+MIjxQv0nCnU5X/5d2F4vqS8fw8qtMFs7FTZI/IL8CLm7tDelHX2Z83snrQFWbuX7ekOtok+uvZJxpDX3cO0wSIuaXqVQjhwKo3GTRw6JJXmAkK778C7Y1NJm8hSe9wLefiupsT9J7iuhnU3NSCF/iRFggcoFcMcT65k0FHjmMNDSFAGN+QOs8Jo+ZSRuL7kDRyGyzYOppS5GTRnlOSYcbHSo1J7bGTA4rMuNoUVNxHEdt9gPHgGt19xNBT3QIRY0iuudG1wGk0xMo10Fs+caHuhxMPGFi7uPWiueV7Stcj9alUCOmn9cC0DDQK01/l5jyGkIK97u1HMYs5hCn9uKb89ktUm7eaWov95o+lZ6s98oXXbj58orzeW9BGV6uA2jRZ2ZBZzwwhEs8L6kn49rmY4fakdQEHALvLhRS6fNrT6XDZfbwG1AtbXaJNZRPZD3OesHVxvxRhF7UypqJX708sZm0CNY55tv1Zk11E9Hpd2styvVI+QMfZfFXjWQskddbqU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(2906002)(508600001)(316002)(3480700007)(6486002)(31696002)(86362001)(38100700002)(66476007)(2616005)(66556008)(186003)(6512007)(26005)(6506007)(53546011)(4744005)(66946007)(8936002)(8676002)(7116003)(36756003)(4326008)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amxUTE9HTk1QMS9qNXlmVDJDY3FEdlBzODcxZDlETEFrR0s3R2JCS2FDaFY4?= =?utf-8?B?SSt0WXZMWGYxeXpzVUNUSWF6K0cvaE9Hdksvd1doaHVjVXNabU83Vy81eU1u?= =?utf-8?B?aW1Yalo3QzMwZTAwTUVndnd4czA0aHZtUDI2SjlVaFRGZjZOaElQRWM0S0dJ?= =?utf-8?B?b2g3YzV3bXY1VlZFTzAzN2kzQ0pHRi9mVHQ2aUw5cHZpZHBZQTBxTUFzV2N2?= =?utf-8?B?TmJWSDY3YVdnK29YZEx2eVpJMnFPQzFQTjhZSkFFdVlTZWtZaTkwaFU1RC9N?= =?utf-8?B?WitjbXdyY0ZNdXZZNjRkemFKMGU2NGV1d1EzakJRRHNnbEZwdWVMd3haeWFP?= =?utf-8?B?QzJHd0FpWkwyTHZPTXNMNDZUQjZ3Q1Y2RU5vcVREZlV4OUNsVGNiaG80UjdQ?= =?utf-8?B?eUJlVWVZN2VwL29JRlpmell3ODFqSlpxS1BjWkF0NXJySTNYSEh2TFFQaFNF?= =?utf-8?B?amp4TzlCM1ArVWxSMFFxUDc5T09uaFRLUlhaTVk5NHVoS0tKcXJtT3dDSENl?= =?utf-8?B?WWxQUy90UFpxTjdwdlNPS0kxZXExczZzakZjYU1mQmhOSWZyL09iMERzOHEw?= =?utf-8?B?SEtBaVF0WDFmdVRDRHg5Q3RpMmRXdmt0YXAxRkdvRmllSGtIL0VsMnNobU1N?= =?utf-8?B?aFFGcEM3QUZDb1Q1d3BYeEw3bkhpaUJuOThkMUtzM081VkdWZ1FjaWI0RnhB?= =?utf-8?B?TTBvckFmQ1F3UEVsMXNGdU9GL1hnLzFRMGo1cVpOWVhucDlJdDVhcURaeC9G?= =?utf-8?B?TDMyQ3JBK2tIWGpmOHBiTnpUK21kQ0E5elliOFJGMjJ4eDFmTWtoR1VCNTZC?= =?utf-8?B?RU01RVBrR0dieExUTlJ0MjVFTFJjQ2s0WEd1Rnc0dFRISEtaRmR2UTZJcnhJ?= =?utf-8?B?K1pFWlpMMHlrS29XRXhGdmsvSzVRaHVoSEhzcDMvQWlMYnVhUEtBeCt2eHg0?= =?utf-8?B?N3hCaVJZU2tYN3pEWTg4U25iKzQ1Z3FTK2E3TFo0Z2J1QzVJd1oyUTMzMTdx?= =?utf-8?B?MXpPNkJlWEpxNG1qV1BLTE1NZXVjZGdnbElWaEkxU1hsN2FycklyRTFxaGNr?= =?utf-8?B?d0dNajJmWFU4eEkzbTk4MEpDSjFURG9UWFdxblYzWEZtWE04bzNrQWZZMlJz?= =?utf-8?B?T3E4WCtrRGI1Skt0cHRkWWdyQzBHL0FUeHJHa0ppTEVoUC9ERXhhTU12bnQw?= =?utf-8?B?Z0lON1RzelVOV2ZGNi9KQmozTzlIdFB4S2c3WGJISWdXUVNrNFFiTFRhaldG?= =?utf-8?B?ZHZhZDNDQmxOaDQvRjVOV0lUdXV3aGh1MlF5aVdDTG5mWHEyZ0tuLzVNNFho?= =?utf-8?B?d0Qya0FmemY5ck5namc2TXR1amo2NjdhOWFmc1FCaGZFejVMK0Q4ZWJXUHFB?= =?utf-8?B?TWtLUzRNVXBSZTV5cFJ1azlLOWtJMVI0Z28vcVB4SCtyU0tNOUVRdUlhMERx?= =?utf-8?B?bzhmVmNUVndnZHExRldYNVBiNHprR29QNVlhTjBiUDI2QUt4Tzg1UjJ4dnM4?= =?utf-8?B?TzdCTC84S05ka2JiNkdnU1pVMGc5OUdiVDhBZ3p2NnBSYm1PbFpQVXZ3ZXhv?= =?utf-8?B?TU5QNjQreU04WlpFeFFUTjJzTkZZUVBGamRMYytqUkhLRTdleGZuVHZ2L2xP?= =?utf-8?B?dWRJcXByU0EweGIwMEZGc3NUSHMrSGI4U2xZQXVPcnJ1VjdjS3dXUi9MWEZ1?= =?utf-8?B?Wm5jdExjbk9rSEtnaEN0ajdnQ0dUY0JUZFdjZkJhNmQ3ZFlJVThDSVZqY0ZZ?= =?utf-8?B?N0hvVFZkWGIya05MUTdtU3F4RmdWcTU0aGY2MkttLzFCZEpXN2JWa1JRa2s2?= =?utf-8?B?UnJyMTRJaXBaZlNvSjdjVmpqaThJVEUyeThqby9iSDdmNlVtMDRVaHEwU2oz?= =?utf-8?B?KzFKYjl3azZOT2hKYXgzb0ZHUzNGLzAxNGVuaE5SU213T2pHY05LRnhFelJF?= =?utf-8?B?Zmx1N1FycUxtQ1llVUJjTFZiZjFZZVJjYmF1TUQwRGpwd0d2TEtJOWExeHhJ?= =?utf-8?B?bHNVeTRlMmxNaER0TFlBdnJraFBzZ3kwUzh5VHIrYXM1cUtYZEdaeitaTzJC?= =?utf-8?B?NDl5Wk9CYUFSUDg3eUNoamcwODN0b0FXUGRjZmk1VmpibTFVb0dDdW41M3c3?= =?utf-8?B?VzNIUkxjbU8wdG5mWjgvZG9lUW9NaC9KQ08rdnp6dmtvcWxqeDJjbnBNTzJa?= =?utf-8?B?NGFzOHFtSlpNMm1Nb3RCZ2N2UFlaSUZMbWhQeC9FMUxlNGtBSVQwaEl0alJZ?= =?utf-8?B?akRKQUI3Q2VTRlNGa1MrdjEzYitCbTJrdDcvZG5GRU9mYUp5c2QrRDR0Yzlp?= =?utf-8?B?R1ZGM3d5c1kwTG96TlJId0laT28vQmZHWG5BNU1SVnFKUHNYVzlOdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 623e8493-0adb-4c4c-089c-08da3a29718f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 06:24:50.4303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: en9OV00sOEExuFQzQYX4Zg1v+WtufkXvPJ+sT/iuuVBNc8RxH4vhm0Xvpz07ILjntheb51ZBH9CkXyaeW/yxoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8817 On 20.05.2022 01:22, Demi Marie Obenour wrote: > It is well known that mapping and unmapping grants is expensive, which > is why blkback has persistent grants. Could this cost be mitigated by > batching, and if it was, would it affect the tradeoff of memcpy() vs > grant table operations? Which backend driver are you thinking about? The in-kernel Linux xen-blkback already batches grant operations, afaics. Such batching is helpful, but the main cost is assumed (known?) to be with the (installing and) tearing down of the actual mappings of the guest pages (into/)from backend address space. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 06:59:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 06:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333517.557358 (Exim 4.92) (envelope-from ) id 1nrwbt-0003rt-6a; Fri, 20 May 2022 06:59:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333517.557358; Fri, 20 May 2022 06:59:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrwbt-0003rm-3G; Fri, 20 May 2022 06:59:41 +0000 Received: by outflank-mailman (input) for mailman id 333517; Fri, 20 May 2022 06:59:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrwbq-0003rg-H6 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 06:59:39 +0000 Received: from sonic317-22.consmr.mail.gq1.yahoo.com (sonic317-22.consmr.mail.gq1.yahoo.com [98.137.66.148]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 667e8f7d-d80a-11ec-837e-e5687231ffcc; Fri, 20 May 2022 08:59:34 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 06:59:31 +0000 Received: by hermes--canary-production-ne1-5495f4d555-xgn59 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 077428ea294e9eca2cd83f945fe6833b; Fri, 20 May 2022 06:59:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 667e8f7d-d80a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653029971; bh=nAiiF/gaLx9YvHz1WBDFG9vBQFV8yYAG36DVxtUDGKg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=tLvZ3yzsCHOuV4WrX1KecYXs0pEIszI6bSoNzA1XE25GAU6V3pjIWuolHmY8padgkyekUiCsDaaE5QLypBFyYaxojzCWKxb1HJWRAAAWl8pTnJQzt91y4vddc0IkD9w+njtNwZxCGvjEM1955itIu76Fb4NkqaHPuzHRbySgIf/DSF01Zyn2MHsIE/fPPBHDRK9XxDjiz9wBqyqgy62WqZ59RZmQnDjG7X2UZ50N382AbyBV6BPqT50BZuatq78Oo6yxhouXC1BATI/ki9vBlszgc4BlDGSJCCyTVLHFwU0I8EDZQ0s/iS6i5KKQkoCO0ekSFRqhnES/hqkrMwOe2g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653029971; bh=qaC13H91UDc+VejYtnG4e4YoYUKSODRWjrwz7203O68=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=FBLtiV+7nG53sWH4vtivDlRsiQ7U9+H2O82e70byZhBu5q513G53nK2/vCRSAif2sFdKprG9M+VRbaSbxlPyjl8LeNIz4DVevl8m2I2aZVeTyV2zvt5JQ77fThijKOQjnX1jAM4vlFIsupDo53wkuhtSUATJWbIySkBTNAO90VV6Syv0Uk6qvAz1skwaI68hOtJ5RPindoD85fX5QgLH6b3Y91hDwRqCdlFX6bPvo23x9kojLsRd5jbpQHrEwWSk27ukIFwhqZm3KJ3OGRpbvezesfwLya8R/u1asItlsDqQnmRKsC6ODgy4H4wjahYYmEHyxNjnldMHwWkhM2+JDA== X-YMail-OSG: 7xtcaasVM1lx5OMihPL.hTlRrM1A8gAiFAluZtMNuTWzcGcv870G4vhNQPZRIZS ilxDgYTnY6Km_vUamZlf4scV5t21_TYQ3L18f1vS8IF2oTF0jrqEYdQWjiwAD_po1Durvana8z9k S5Nmu0gvJnezglWTF1P5xNECJtfXsYc75paLHUVCjR0eSwSKmztMsmNOGlP4eTVqXq.1NeSkl2g6 QvsEqSV3DWHURxjOEGXk68nRQY7hkY4U_3rrBNbxF9HlnxTDidZ2eU2uaytTPAaBYX8PLyMD6KfI 8Qh4i6fIEQj27ZDyuBs7D2ejdSKXAawjuo0c1F_4jIJPUIIlLcYEmzlDXWaL6ryL_Nn3VPbreDzz acD1Z73p_3ufdSev_GUX8DiMfR0Etah7zgfP_jGUa6ctalbF3NcnUck3NqSjO4iH.pT4IVDoO4g. SsDFxvhI9kx1Qyw6q_YBnuCSE7Sa7PYi_Yg3g6Qoe5HDOXcze8BWT91QRrax9983YrQDuhSKcY1O FdXs0nHPgFowx47xZOC5eoVOqmgT0DUEtE3FbioTjwoJuuX4IRGwookpeDxxLzS5xQ23QLdHNZen DSCh3o5wUhfR1bgjTg7XORYgXc4GlXiKAU2svD41dsQIT3WB73cC88lcP_0Hm1P8cfEV1bXDqTV3 ITLSOplghvQymnxjEv7gLH0nca9XmBaeoLje_SBduuVgJX5rpoTIDZJs7d757Ic.vVqkIuSFTXrZ 95Op_O8e1Oz7YS7rOcy8FJFk59NED_KjHBGe3mu61MCrFpN.4L7W.6eYBqL3se5ksp6w5LBerJqd 98sTqB5wG70a5sA.SkXOG.S7wx3faRCL8J0XNFTNQluhnilgXbwIdL99WmBXkVgRFEJnafwoRYCa Z8k8yUTnb7ckMJmZejnNq.b_hYLG41aZSXjzaveOZH3OXxuoL46_tQ3EQteu4jJ2yY5_eHWNYqat Ri_jkXOsmNcD9_pr3VJITniq2Jn0ZNTY8ZJyraIM_M3PhVkaE8dI711kZ70YCzZRKnsyzq8exphZ B_cnxDyPJIT88zju7u81eNctVt2ora4rVYrzPIptRU2HUhOW8_Jpkd4rN6vi5vs95cDPQkGnDaRQ ZI_bObcrELFaOZ.ky3MZCLJp6K0gd5EdjeRdhKqtOS5f_hMeX5yiXP0lyRF0g4sswTTDKCUs7lAx pwd9mINEq07kqdrZrVC3DKO.aFwFB.KjlW2lsgjl30OXphrTnlTNPkDt2Wb4BTKAzIAW1Zjl_0WD Lc9vaypKYJ.vBO4ssOTh7KKvkv3JP1Mfu4jr6Tp70GE05I3QfJLghqxMzOtj5KlGj0FhcTLH3kcc 0IiuJDtyjAgcQDU6zykDmf1SX.Rm_t1WgWrZ.bQ4vGk3ln56eftNhkBkewlMVT1iUaXlqUcwH8F4 wV.KlsDBRfUyrcfzEK.eatnVe_TNlQ1yxBd2rqjsl_vZfDPrYG8HywXgOSAlNHm_2VPX6NkoM5xT 6G1N5lhaTXs1mXbT_F.3sWbISjecItVM5zKDNADFOjEW9MKOA_J1Ckgw37pIdFWPpVhtOcoG1qYT oU2EALUQZ66qle9q5H50ck6o2jWgsQi5EAl6W2PzLXmdVGhFNcVHWk7lrkHcT6RgtE4gknfAi.12 h3C6m8F8CgMfO3GQ.5yxgl0wAxslMHGGqQU9FrpNecAJ4a88Aw9Zrk2rEUlB5iRePZiiA0t3DoE. 2.egF7I7_T9cyNZyFPTsAdZGsAEn0ifH91EgCZvRvLy.Xa8M.pfNLN30TVHGYVRvzxijxcdXqDs1 g_20vFXNo.n824fOAMKq0yXKWg9ribjIxu.T69RwZAmsFFqtpMknS1OGHnsJrnb3T6vqsPYMMMMd zP_8BlykH.soKnXEJY4YgY8NIWMLPXX1Oc7JaR7b5AkfNAHtJQZtGYFBo16RnUAFioTGM9vcij1D RRNZbLbpvVkLOLeIffNQeqeQTJo3W2e9pZ2Ti6zWPvU0AY9fFGcYWPxmB8h4SKJmLat4MVnUGLcs nmFw4uL21s9Hsiyb987egxLFul1L_70Jt7rQ.u3GuQX9BJ4GHNlmWJs0RI6iMrCRFWoyYmZNxO_P aCcQdZDnCbMIIIFMaeYgF77GZlIzio6lCsPkWxOdUI7epcuPKOA0a97onBFS.bRWfb37uNZ0H8Au ckQZogbtCcbzM4DuVH2c_hb_2GQhNuLSq72OSZ.m__vZtFIQwCLL6hH1jYdSlZbes5DIhL58aF2x Z5C82 X-Sonic-MF: Message-ID: <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> Date: Fri, 20 May 2022 02:59:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6450 On 5/20/2022 2:05 AM, Jan Beulich wrote: > On 20.05.2022 06:43, Chuck Zmudzinski wrote: >> On 5/4/22 5:14 AM, Juergen Gross wrote: >>> On 04.05.22 10:31, Jan Beulich wrote: >>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>> Some drivers are using pat_enabled() in order to test availability of >>>>> special caching modes (WC and UC-). This will lead to false negatives >>>>> in case the system was booted e.g. with the "nopat" variant and the >>>>> BIOS did setup the PAT MSR supporting the queried mode, or if the >>>>> system is running as a Xen PV guest. >>>> ... >>>>> Add test functions for those caching modes instead and use them at the >>>>> appropriate places. >>>>> >>>>> Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with >>>>> pat_enabled()") >>>>> Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") >>>>> Signed-off-by: Juergen Gross >>>> ... >>>> >>>>> --- a/arch/x86/include/asm/pci.h >>>>> +++ b/arch/x86/include/asm/pci.h >>>>> @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, >>>>> int pin, int irq); >>>>>       #define HAVE_PCI_MMAP >>>>> -#define arch_can_pci_mmap_wc()    pat_enabled() >>>>> +#define arch_can_pci_mmap_wc()    x86_has_pat_wc() >>>> Besides this and ... >>>> >>>>> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>>>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c >>>>> @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void >>>>> *data, >>>>>       if (args->flags & ~(I915_MMAP_WC)) >>>>>           return -EINVAL; >>>>>   -    if (args->flags & I915_MMAP_WC && !pat_enabled()) >>>>> +    if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) >>>>>           return -ENODEV; >>>>>         obj = i915_gem_object_lookup(file, args->handle); >>>>> @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, >>>>>         if (HAS_LMEM(to_i915(dev))) >>>>>           mmap_type = I915_MMAP_TYPE_FIXED; >>>>> -    else if (pat_enabled()) >>>>> +    else if (x86_has_pat_wc()) >>>>>           mmap_type = I915_MMAP_TYPE_WC; >>>>>       else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) >>>>>           return -ENODEV; >>>>> @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device >>>>> *dev, void *data, >>>>>           break; >>>>>         case I915_MMAP_OFFSET_WC: >>>>> -        if (!pat_enabled()) >>>>> +        if (!x86_has_pat_wc()) >>>>>               return -ENODEV; >>>>>           type = I915_MMAP_TYPE_WC; >>>>>           break; >>>>> @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device >>>>> *dev, void *data, >>>>>           break; >>>>>         case I915_MMAP_OFFSET_UC: >>>>> -        if (!pat_enabled()) >>>>> +        if (!x86_has_pat_uc_minus()) >>>>>               return -ENODEV; >>>>>           type = I915_MMAP_TYPE_UC; >>>>>           break; >>>> ... these uses there are several more. You say nothing on why those want >>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>> and came to the conclusion that these all would also better observe the >>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>> only >>>> predicate). In fact, as said in the description of my earlier patch, in >>>> my debugging I did find the use in i915_gem_object_pin_map() to be the >>>> problematic one, which you leave alone. >>> Oh, I missed that one, sorry. >> That is why your patch would not fix my Haswell unless >> it also touches i915_gem_object_pin_map() in >> drivers/gpu/drm/i915/gem/i915_gem_pages.c >> >>> I wanted to be rather defensive in my changes, but I agree at least the >>> case in arch_phys_wc_add() might want to be changed, too. >> I think your approach needs to be more aggressive so it will fix >> all the known false negatives introduced by bdd8b6c98239 >> such as the one in i915_gem_object_pin_map(). >> >> I looked at Jan's approach and I think it would fix the issue >> with my Haswell as long as I don't use the nopat option. I >> really don't have a strong opinion on that question, but I >> think the nopat option as a Linux kernel option, as opposed >> to a hypervisor option, should only affect the kernel, and >> if the hypervisor provides the pat feature, then the kernel >> should not override that, > Hmm, why would the kernel not be allowed to override that? Such > an override would affect only the single domain where the > kernel runs; other domains could take their own decisions. > > Also, for the sake of completeness: "nopat" used when running on > bare metal has the same bad effect on system boot, so there > pretty clearly is an error cleanup issue in the i915 driver. But > that's orthogonal, and I expect the maintainers may not even care > (but tell us "don't do that then"). > > Jan > >> but because of the confusion, As I just wrote earlier, the confusion is whether or not "nopat" means the kernel drivers will not use pat even if the firmware and hypervisor provides it. I think you are correct to point out that is the way the i915 driver behaved with the nopat option before bdd8b6c98239 was applied, with the same bad effects on bare metal as with the hypervisor. I think perhaps dealing with the nopat option to fix bdd8b6c98239 is a solution in search of a problem, at least as regards the i915 driver. The only problem we have, as I see it, is with a false negative when the nopat option is *not* enabled. But the forced disabling of pat in Jan's patch when the nopat option is enabled is probably needed if the goal of the patch is to preserve the same behavior of the i915 driver that it had before bdd8b6c98239 was applied. In any case, especially if we do include Jan's aggressive approach of disabling pat with the nopat option and preserving the same bad behavior we had with nopat before bdd8b6c98239 was applied, the i915 driver should log a warning when pat is disabled. Right now, the driver returns -ENODEV with the problem in i915_gem_object_pin_map(), but it does not log an error. The only log message I get now is the add_taint_for_CI in intel_gt_init which was not very helpful information for debugging this problem. It was only the starting point of a longer debugging process because of a lack of error log messages in the i915 driver. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 07:49:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 07:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333526.557369 (Exim 4.92) (envelope-from ) id 1nrxOT-0000YW-3i; Fri, 20 May 2022 07:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333526.557369; Fri, 20 May 2022 07:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrxOT-0000YP-0M; Fri, 20 May 2022 07:49:53 +0000 Received: by outflank-mailman (input) for mailman id 333526; Fri, 20 May 2022 07:49:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrxOS-0000YF-6Z; Fri, 20 May 2022 07:49:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrxOS-0000Vu-4k; Fri, 20 May 2022 07:49:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrxOR-00028g-M6; Fri, 20 May 2022 07:49:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrxOR-0002fG-Lf; Fri, 20 May 2022 07:49:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s3YyekMJxqr+Q32RY8709wcnlh0CGe/QkSmBGiZRAhI=; b=mg9EP2EFOxVh3U3Fq1VeNx1xse svU11jyt8RlXRDXbGUCgJZYZVI8fJLzoJJOGeKLj/ueYBN93Zt2hYgVp3AFqqG5HejEDcxwq2qK0A 6zUQ4dZ0KIQsaeW+gIrKUlSrYHPOBcF8mdaGX0YwEOUb3Mi4fEdGLR4hYzFHiqIWg80Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170593: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 07:49:51 +0000 flight 170593 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170593/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1113 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 08:31:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 08:31:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333541.557380 (Exim 4.92) (envelope-from ) id 1nry2V-0005zW-MP; Fri, 20 May 2022 08:31:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333541.557380; Fri, 20 May 2022 08:31:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nry2V-0005zP-I4; Fri, 20 May 2022 08:31:15 +0000 Received: by outflank-mailman (input) for mailman id 333541; Fri, 20 May 2022 08:31:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nry2S-0005zJ-Qt for xen-devel@lists.xenproject.org; Fri, 20 May 2022 08:31:13 +0000 Received: from sonic314-21.consmr.mail.gq1.yahoo.com (sonic314-21.consmr.mail.gq1.yahoo.com [98.137.69.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e586227-d817-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 10:31:03 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 08:31:00 +0000 Received: by hermes--canary-production-bf1-5d4b57496-wjd85 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b6f8f6a30f469bee93e26cb01475724b; Fri, 20 May 2022 08:30:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e586227-d817-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653035460; bh=WuvwqA1c8r2r+p12+b/hUYdMq9rnRGTuBcxt58to+Ao=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=HF4w2B3LXxAzsPu0cKlClPAp4lIFCVFZUlM+pPQk/ux+ANH+hXbKsjrMjPSA0fZJ7bFN0k3vBmgockcp65NFWPRjltp/uZX8m6/CHBdr+bCznj5y10gd4DlD8HEzG69uE3tqaVbbHsoRnvclRrccUySMDf9kJ1C9NXsVBlCML8dQT9W9zbLw+22y3mNNGSaq/bL8pBTiaCsZ1FW4aFBOwyR2iMix+qtlmTAh2VK/hzqEyMo/dLfJQtZdgFZQeyxm8X+8RTOo9VhypjdtEObCOc6lZPTBSUTACmWdnQ142+D1X8U3FscLu7nqk75T10eZHlh/FT9c4xcPNXHZtL9fMw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653035460; bh=O145fJvMYEd44wHYCOcQPm3BRaty1a+efZ4N8LUkQQr=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=KTMMx1J1l42zBLEuD7iEYrVpRZ7tenDIzhJP+FNinhG3SjIyDMVzw5N0pDNVL2N2MQ9pb94qH7dr01GJOCOZcXNtF8TViexLW79zwv6ynfIDVQKFpS6XcgMAsXtYpnghDDtVAALwjd1vB81Lt0374U4JDN08+xNpIlCqrxBcoc75xbCbKUwYizkkDqgLilGxLfiRDz8S0S9Gxn5MU4glFMXNaQAKCF1dwkGi1+k+TdJPi7eidZEKU7fihPGPg7vII2CW9XcWkjQ1lU6CFTr5srzCOHQVtMq9U0EeZOeKGy8AtuFKfsD9VLMOg512Kzby6gny/gOQ4gHLvwbJklvxvw== X-YMail-OSG: 7CjV_foVM1l0tGFHgoKRE.wnpkoqWeJCUCM8L4Pwg7EBf4yx.s.aoDJ2z8Y4XF5 nkBd3hXNBdVVi6K__NDC5IxyqplLijiN9NeZ4cFpS.V3YLTiqBnHc6oRK5Z8EqCF41FjbcgasEe_ .7jTmaDxxxf1seLHTx3CMGqC.uE0FcUfHFCdQ0aFCHAylPQXkQbxVdVLtetzY5jGVyjJjYAwblN1 vPfLUmFTOFV92.71_ntQfBCwQwxYodrAu9_5r9.7MLVTv3RsXOFhjJzUzjOjuXkVlViS6EWQK39I pAOH1zQrv4fDeo.H8kIqXiLaLguNxlaaZ_5BkUXZmDyonaKBi.sYdF2Q8XKolWBpPxBjL8ABwAxz dORGC7HOvY3DqgaDeTcW1VX0UNy2rSYcPdOHELAgnsIw.ReQ.6t8Zi38Ww_9v0Y.eIJ.JhBK3F4y 3AvYhUpNIQ7E4y0_KowaJFdmoLIWOs39S41mUGY04i6hwR2YBSQiTyf1skcbtWjF1o1DGoJiA47p tGB643aWqy7swWezv7nWOrH7RgGfwz0QXrfxM_SD651_S7WfPhLprmZ4DJsaKp2huC182n9G5mj2 J7tDv8s3ODCP_Pam_edh69oKeODvNDb7Wcv9Q4WPDh2ow0MWkSw9Gd_JegWygV6hWYcSVGsyIMrC Wul_q8qqQk4r9Um3QQe1X7fiwQzX00qdEhCJN3gRgddGsttY9VmdmLOmGAk8VGRxDNx3EZZvVTom k55_gpE8nhH2sQRR4p_qDBVjbfd6tGLNXmeZct5LkVFmiuMbBvTeGbWeJ6beEq6bINfpeuA1s7Vz dUw9sJsRt_EVP7jT3WUu.lwEUKXqn8iCY.mH_6LNHYGiCFFh1u_geLafXI7TvrwGd__DIWkfGN0c B21Ne4nzqW3mM.zen08WR5bF_h7EkCQKcdGQs7B0_U6psVHys5khnmhSFSkPgLuNt7Mzg81aq_i5 lEb6CJ7LjZ068w7uni4NWUwKNYJPDEuChGKW9zLeXqUpPxcGtYLksJ38AFZFIYttRsR5isWRdf3V PVZDQGlDooMFGmzRHM8Vzxl99v5HLLnuw18gf7b5N9Wfhj_fNjPBDcloD1_sqZ3rhcZQmBP9_Qfj aL693WDn0UhR8roOTVIiA8r4v9qdPji4UHbg8G4CvQqeY3DXoyrFh8bJ75dFqvI6tPdjgjULmUnS uatpSUT5iyIUuNJZsKUMlrkXPZ01xbMjD37Qlqxlryt5PgONqdq_V.oKu.mHofpNX4Xs3SfbwzVv O0TOoGKHDE1LufOSQaSaJkQqei.wo3J4HqrbMCYCIuGkcdq7cOlVLzJZakFZBOBBFcA8KYqKPDNm 9Jl4vloFJ.L3QWh_4yJvRtbkIZp5HOzayLuZgpb96FqCHsCw4Nj1zkOZ_S2BvjISwUOnSmj7ci1L 46Led9OyVaAkyuSIr0zWtBA1VqJi_Hgrj.kD3zvG7RATCJGALuaHWtp3qGr3Th74hoZ5P.AFKhiA jX7R5smlDei5Eqq2bJH97wSPKzCzvv6QUOi5q2d8PZxHiDiyL6Ln0tKdVhpmrGGpuc.ZKRBiD8Nk OH2dAahaCJegaKgkXPsjWp4eoB540liVr0lbyginWNwwuX0o.J4lBvOfFz7JAlLA60DB_mgL5ELJ tIdfcySg.Rwa8Wp0nOiNuehVWR18vyOqHc6AQjdUnqFUO11t06w9wVnXk8.KY.InwPEryEvMp5yC GkVlRDktIfUiGsrnm8EHJcPr6PFCDJvU0aS.ZZWIeX5YefIp1ia0F8OKBeioS5d0TlIbhaJ1perB VC8aEYplBd6nDvIbBgVINPEqP86l8KrhYsaofvY_KFasBr8DgnTzvoQVQrRzWpT8q8pQKIf8DcGF kVqA6Oadng9UvGIr4J8ZNFir93IcQFiB5YCQQ7NPseQ6Jz15Cum5De1zuR3xvLk.2GNwjrtfTfWI jog8o9t3Hwq595MgPp04QPPyH09YM.m5.vyqLRFjcyz_qRmZr_dXE2DfZslymukJNVGJcr5euLX_ ExafElfRJQ5PA88fSzYl33h7dRiPCVxt.gj6.sUHE8tfZNgU7dF6fwb1jrrK4hYy85fEDlhsjwPo tJTd4wvGHA9eAEs7BX_MGbWtbvv.Bo86PLThrT2VFseqEjtbs487_aIswCgSe1BYROpOoQTVbqmJ dUl0qV2u5_EGU5ZMvZYeg_Q2Y7toVdr73hw5cJfn5UFjOyl6kspqzrW0rE0YHIknQdgQ._MTGKhq Dgy1f X-Sonic-MF: Message-ID: Date: Fri, 20 May 2022 04:30:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US From: Chuck Zmudzinski To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> In-Reply-To: <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3790 On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: > On 5/20/2022 2:05 AM, Jan Beulich wrote: >> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>> >>>>> ... these uses there are several more. You say nothing on why >>>>> those want >>>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>>> and came to the conclusion that these all would also better >>>>> observe the >>>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>>> only predicate). In fact, as said in the description of my earlier >>>>> patch, in >>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>> the >>>>> problematic one, which you leave alone. >>>> Oh, I missed that one, sorry. >>> That is why your patch would not fix my Haswell unless >>> it also touches i915_gem_object_pin_map() in >>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>> >>>> I wanted to be rather defensive in my changes, but I agree at least >>>> the >>>> case in arch_phys_wc_add() might want to be changed, too. >>> I think your approach needs to be more aggressive so it will fix >>> all the known false negatives introduced by bdd8b6c98239 >>> such as the one in i915_gem_object_pin_map(). >>> >>> I looked at Jan's approach and I think it would fix the issue >>> with my Haswell as long as I don't use the nopat option. I >>> really don't have a strong opinion on that question, but I >>> think the nopat option as a Linux kernel option, as opposed >>> to a hypervisor option, should only affect the kernel, and >>> if the hypervisor provides the pat feature, then the kernel >>> should not override that, >> Hmm, why would the kernel not be allowed to override that? Such >> an override would affect only the single domain where the >> kernel runs; other domains could take their own decisions. >> >> Also, for the sake of completeness: "nopat" used when running on >> bare metal has the same bad effect on system boot, so there >> pretty clearly is an error cleanup issue in the i915 driver. But >> that's orthogonal, and I expect the maintainers may not even care >> (but tell us "don't do that then"). Actually I just did a test with the last official Debian kernel build of Linux 5.16, that is, a kernel before bdd8b6c98239 was applied. In fact, the nopat option does *not* break the i915 driver in 5.16. That is, with the nopat option, the i915 driver loads normally on both the bare metal and on the Xen hypervisor. That means your presumption (and the presumption of the author of bdd8b6c98239) that the "nopat" option was being observed by the i915 driver is incorrect. Setting "nopat" had no effect on my system with Linux 5.16. So after doing these tests, I am against the aggressive approach of breaking the i915 driver with the "nopat" option because prior to bdd8b6c98239, nopat did not break the i915 driver. Why break it now? Prior to bdd8b6c98239, the i915 driver used static_cpu_has(X86_FEATURE_PAT) to test for the PAT feature, and apparently this returns true even if nopat is set, but the new test, pat_enabled(), returns false on the Xen hypervisor even if nopat is not set. That is the only problem I see. The question of nopat should be irrelevant to the i915 driver. It was unfortunate that the author of bdd8b6c98239 mentioned nopat in the commit message when in fact nopat was never intended to be used to break the i915 driver. The i915 driver should ignore the nopat option and decide what to do based solely on the capability of the cpu, firmware, and the compiled options of the Linux kernel. That is how it behaved before bdd8b6c98239, and that behavior is what needs to be restored with a patch. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 08:54:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 08:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333550.557398 (Exim 4.92) (envelope-from ) id 1nryOa-0008SM-Ux; Fri, 20 May 2022 08:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333550.557398; Fri, 20 May 2022 08:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryOa-0008RV-N9; Fri, 20 May 2022 08:54:04 +0000 Received: by outflank-mailman (input) for mailman id 333550; Fri, 20 May 2022 08:54:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryOZ-0008OY-BO for xen-devel@lists.xenproject.org; Fri, 20 May 2022 08:54:03 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 635e06fb-d81a-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 10:54:00 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C35875C02A8; Fri, 20 May 2022 04:53:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 20 May 2022 04:53:58 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 May 2022 04:53:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 635e06fb-d81a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653036838; x=1653123238; bh=9SoDrM5QXO ZZaENaU/Vm3Kz95pyoPpFXFzfpd79RRT4=; b=LCszMCKuP0zC9hT2zd1cAdmOcQ i2N+8aSPgul9dfjJ3mUS4ILp4ZI4MUJSi4Bjlx0H6vTV+Ru7mf5IYK1wRf4Qz11j qpIiMuP4m2Ft3pV9j5QckOn0ZY56JeKnXG1RMRmfDcl20mLj7lydKkLO3wHTVhHD aorEXVluZK8kPZeB3aPwZa9LBQ5Z/eU5rU98njX8CwiK/ckju0BL2vu1gdE8kY8t CqARfaz0DavHu8wFuk9XDmMTv5PX3smvEG8e16QHgu2lCx9ZNwPL0p9xzvYqrC1x CbR5fKBS0f8dRaf/uFm7kEbT8h1gpTYUaPFBNzwWGlUhRM9Lpncu/HUCAYsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653036838; x= 1653123238; bh=9SoDrM5QXOZZaENaU/Vm3Kz95pyoPpFXFzfpd79RRT4=; b=s Rfw21pbDfj5erRoCBw/z/ClKDcbe9RCZo+13dXolDLK0dWBD1RXPPQ5RgB2Y/CB5 5tnzEKbsYlo4Su4AV16u+o+LQ2B0Oi0LTH9ff8WcaqxW0qDOMrQPsn6f+BewxLrW ONEA4idSPHr8+a3it1wO1C+RRi+T7rn+sWk3NC8PGVJI+3nsk0b/u+R5kvZC6R1d zwy1dEPUA9Ie2cw56pyPckQt7sThgZ14bK/0xM65N8q93ngarMgECf7tZ3X80BsI pWCSZBxonB2f7ecc6n22XTfiHnEWScrYPEMDXiIb3CTCQPqghMn2ZBw05Hsl3Rl2 iO72YutBtypT5AbjlY9pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfeu udehgfdvfeehhedujeehfeduveeugefhkefhheelgeevudetueeiudfggfffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 2/2] ns16550: Add more device IDs for Intel LPSS UART Date: Fri, 20 May 2022 10:53:43 +0200 Message-Id: <20220520085343.1835866-2-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> References: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is purely based on the spec: - Intel 500 Series PCH: 635218-006 - Intel 600 Series PCH: 691222-001, 648364-003 This is tested only on TGL-LP added initially, but according to the spec, they should behave the same. Signed-off-by: Marek Marczykowski-Górecki Acked-by: Andrew Cooper --- Changes in v2: - new patch, adding more IDs to the patch that went in already --- xen/drivers/char/ns16550.c | 80 +++++++++++++++++++++++++++++++++++++- 1 file changed, 79 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index b37f67dc7430..b7da5646fc28 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1077,12 +1077,90 @@ static const struct ns16550_config __initconst uart_config[] = .dev_id = 0x0358, .param = param_exar_xr17v358 }, - /* Intel Corp. TGL-LP LPSS PCI */ + /* Intel Corp. TGL-LP LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0xa0a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-LP LPSS PCI UART #2 */ { .vendor_id = PCI_VENDOR_ID_INTEL, .dev_id = 0xa0c7, .param = param_intel_lpss }, + /* Intel Corp. TGL-H LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a8, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a9, + .param = param_intel_lpss + }, + /* Intel Corp. TGL-H LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x43a7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51a9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51c7, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-P LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x51da, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #0 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa8, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #1 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7aa9, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #2 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7afe, + .param = param_intel_lpss + }, + /* Intel Corp. ADL-S LPSS PCI UART #3 */ + { + .vendor_id = PCI_VENDOR_ID_INTEL, + .dev_id = 0x7adc, + .param = param_intel_lpss + }, }; static int __init -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri May 20 08:54:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 08:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333549.557390 (Exim 4.92) (envelope-from ) id 1nryOa-0008Oq-HR; Fri, 20 May 2022 08:54:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333549.557390; Fri, 20 May 2022 08:54:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryOa-0008Oj-EC; Fri, 20 May 2022 08:54:04 +0000 Received: by outflank-mailman (input) for mailman id 333549; Fri, 20 May 2022 08:54:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryOY-0008OY-I0 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 08:54:02 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6286ade5-d81a-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 10:54:00 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 39EA95C0299; Fri, 20 May 2022 04:53:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 20 May 2022 04:53:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 May 2022 04:53:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6286ade5-d81a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1653036837; x=1653123237; bh=Zbc3jOEPowRT040X5wqGBooak9Aro6tWaKi WhEvPW/w=; b=Utan18Sivb2kE1qnbOcBnFVKPEVEc/wV/xtYE+jQPyxOS9ani6L NmURZ0OsZZTYk17o8/es+OTlN5lONR7eFOhiiBG9Jn978a7hXF9sHFq0ZaFAmVIj 2XzigI44GL1QveXOCblBZ+nQB+dfMAfV/hBM0TAho3pzL68ooExKhvaA3JBMY+wz iBzFg3YzsStn1CfYTyl1W/oUKFEwVi1i3USrdIzjxp/v6MSq+hOwsoQ9OijI97er fLHL+eVUSX57hNQMNBJtkrxbviBLmHIEGxKChvvd/l+QnXSMebJn4A1CUqm+5YAR yGG4MI3+4niQu34IDSzRBFpWqbGFa/JHpFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1653036837; x=1653123237; bh=Zbc3jOEPowRT0 40X5wqGBooak9Aro6tWaKiWhEvPW/w=; b=pLIqHj/Pe7P28uk2kBurSppqfA2gR 2u/ocmCWeWFyj9WsL1hKnfDyaF3RvTiQeXzdK872rfgJ8bzE5Z6Ld0zTawlF8Asp 7z/M+sANC2Pwunai1ed9M7KFKOnJBXbybNhg4marhUHr3ARlBRTsRl8ToVFKcPFg H/jzAEzA5o/KkcPe5Pq+F2+0gGtA7Rcy50v0h0meh+QAd6LTBeTWGALJjUpLEJ3x RQJjwL9b+aDXcRHwwnyT9NwR6RiDEX1S4eIinJUmPd/8HpAoGJjHPeBIidLv+AWj MolRa7bLvjC+vtCAa7Wkjq6IvGVXZnmm2g2q9uh1XEWgmeNJf/o7EiO1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleekhfdu leetleelleetteevfeefteffkeetteejheelgfegkeelgeehhfdthedvnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v6 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Date: Fri, 20 May 2022 10:53:42 +0200 Message-Id: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Roger Pau Monné --- Changes in v6: - wrap the check in additional CONFIG_X86, with appropriate comment Changes in v5: - drop IRQ 0 from the log message Changes in v4: - adjust log message, change it from WARNING to INFO - re-add x86 reference in the commit message Changes in v3: - change back to checking 0xff explicitly - adjust commit message, include spec reference - change warning to match the above Changes in v2: - add log message - extend commit message - code style fix --- xen/drivers/char/ns16550.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index fb75cee4a13a..b37f67dc7430 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1238,6 +1238,17 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) pci_conf_read8(PCI_SBDF(0, b, d, f), PCI_INTERRUPT_LINE) : 0; +#ifdef CONFIG_X86 + /* PCI Local Bus Specification Revision 3.0 defines 0xff value + * as special only for X86 */ + if ( uart->irq == 0xff ) + uart->irq = 0; +#endif + if ( !uart->irq ) + printk(XENLOG_INFO + "ns16550: %pp no legacy IRQ, using poll mode\n", + &PCI_SBDF(0, b, d, f)); + return 0; } } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri May 20 09:05:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:05:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333574.557413 (Exim 4.92) (envelope-from ) id 1nryZI-00027a-2Q; Fri, 20 May 2022 09:05:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333574.557413; Fri, 20 May 2022 09:05:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryZH-00027T-Vm; Fri, 20 May 2022 09:05:07 +0000 Received: by outflank-mailman (input) for mailman id 333574; Fri, 20 May 2022 09:05:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryZG-00027J-Sv; Fri, 20 May 2022 09:05:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryZG-0002LN-QK; Fri, 20 May 2022 09:05:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nryZG-00055e-Be; Fri, 20 May 2022 09:05:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nryZG-0005Um-BA; Fri, 20 May 2022 09:05:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L8jFfH3Mp/9nRPHTuI+geVVXJMfoyAAIcKEzSUGbsH8=; b=e4pyln/0S1wzzXSruNyVCGStTx xC8167384Xmmi+Gb0RPlW9gKxMh6OCg/pzRSntRWOnSAyDxrO7qq1ggCDO96VcQHXcWlMHlhiLVpE uRtRIJl5a09K7kUaojYElPG29vZFciXPC/AfvBWNYsrXlB1z1g/Co6ebhotfx1wwVKVA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170594: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 09:05:06 +0000 flight 170594 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170594/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1114 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 09:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333584.557424 (Exim 4.92) (envelope-from ) id 1nrycu-0002l2-M7; Fri, 20 May 2022 09:08:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333584.557424; Fri, 20 May 2022 09:08:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrycu-0002kv-I8; Fri, 20 May 2022 09:08:52 +0000 Received: by outflank-mailman (input) for mailman id 333584; Fri, 20 May 2022 09:08:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrycs-0002kp-FZ for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:08:50 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0605.outbound.protection.outlook.com [2a01:111:f400:fe02::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7599967b-d81c-11ec-837e-e5687231ffcc; Fri, 20 May 2022 11:08:49 +0200 (CEST) Received: from AS9PR06CA0250.eurprd06.prod.outlook.com (2603:10a6:20b:45f::8) by AS1PR08MB7636.eurprd08.prod.outlook.com (2603:10a6:20b:478::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 09:08:47 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::8e) by AS9PR06CA0250.outlook.office365.com (2603:10a6:20b:45f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 09:08:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 09:08:45 +0000 Received: ("Tessian outbound 6580ae46f51e:v119"); Fri, 20 May 2022 09:08:44 +0000 Received: from 7712050afdbf.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 28F45EB4-A854-4C1F-9F97-623D69173078.1; Fri, 20 May 2022 09:08:38 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7712050afdbf.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 May 2022 09:08:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM4PR08MB2851.eurprd08.prod.outlook.com (2603:10a6:205:d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 09:08:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:08:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7599967b-d81c-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K6P+y6XYwAQPShHyS/3T/JXYfoHYEM9kFOKGRt45Vej+iVJXPMNPgxg94O6pHzVc7Cg76CAzXYmVsV038Is0gYQ99b+v01x9UpTb6mCpEZZIdOGMMXJCYu2Sxb5wPvzZChyq5D1D/V2Ua7l4VhgP41IdePoFM8H3N51wTZ/ULpIutFaW7GIWODj4Gcd0wpWMkHPCqiFjAJfXlg7N2otGUbbmWtTQ1WWJjRKoy+qs3xHjiMI6vtUtB9yK0CCsb9dlA8hUiKGRFo8I2VQKJvX1SEYBfT+F5Z6F2tHE4JaVM0UHAZ4uZZOi+ddFhl1Op3VbDIcMzv+eylbD3LZiqunBaA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tg9wI8pbLsSNAOGEc544JGsIFy0/XLtT+D4FLaodeWQ=; b=hjSZi6qSStBFZpDlir5mNs/wk6W0IpMNFTRBWTabT26HFPQSFx0ek/bsT4eRoIaHOfmSp7LatqVXdlPCrG82MTIsqqdmfKK/KUYEbA74zWqIwoaU3Vi25+tYToHSXuThB2ugbovg0Ol2L7m/Y2Oc58jMJPWS3bahiec/tMzVZUa23cEXnm7AsYU3dZ5Nd3SH0xJOuklFn1a7ptppjhGP86EVRVnMefwkPJxAeB8E51PImOuhtVZmdyloCda22o/mNzHkligib+srLDsZZ27yGRL8NyZYA/rQHSmMz6iPrDM0+QWxtckLwRhFva+XO05Urwpl4owXI79qTWmYFOj1dQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tg9wI8pbLsSNAOGEc544JGsIFy0/XLtT+D4FLaodeWQ=; b=G91+6aCcZ++R4Vj2HkA0/lovs4FnurVUUT/sB1YsAqVgH61lXhiJRXf6l/CHbz2EFhaD6YDVDyBDA3agYQx6fFHpm/NUZVZhw0Xx+3BnlqMO8kN8kL2zmpU94mrZXi+Xd4QjGaVL18UIsgo9T6ASvWBGXfDVxgr+jhtFrXozqMM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3811c6f2841b5ec5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=noEccqOyPZMiV0Ia6f1x8SSadP3zPl31uy++hftBXi4iIriF7zun4++6RbyVvKkgirKbqwv2fIYTrSnBKWUyD9NJtEi9/sW7wmyEPh7U4ych7dBYinAIZvazWGryAjuG7yck3TKk59WqX/G4MQfdAFQSu/8g2JG9eYiv4rvslgbI2lWbwOllCi3Lxhs0E7k8dPMwijjmOxvEaqgy/OvtM59eUBStyc10BBoh7v+VHnuQGjiJB8AX438Q86UQd4HF8GN4DjSzNcEpa5yi3tp5R1J0MbgNZ2HBHU1Bat6nsAnP6nTiuVp/3+3Og7v978zTnk7fmYmtmVKp7n5bpDMiIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tg9wI8pbLsSNAOGEc544JGsIFy0/XLtT+D4FLaodeWQ=; b=WF3M7dynjO+xJcuCGi5t6kXVMG82W3NnHEL8JHzxW0rA6K+CuRpNwLrCm7OGVWVGDglvYckkClqQ875VcseGAOpLFTUx3dTESuwMJIAat06iQb0U71qpA4w51PC3QMaq7PEtyvhNt8YWZ+1tnO1uxwqOWHvD4c7AfrAoY1GD27ZzPXffV4tjm1Jniy8/6v82xr5U41OV+GsqUFnnT1xC+qYDc6B9I9oIa5kDTB5UalbjL1JsfEpucoB2vHA7uj5EF7bQomzAn1gu6GtNyQhpzxB35cYBpmp9wHJKvtkd+Z3JtJz1B6MgJYpnLq1gXhkCntJBvRWsTojAetSUWH1ffw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tg9wI8pbLsSNAOGEc544JGsIFy0/XLtT+D4FLaodeWQ=; b=G91+6aCcZ++R4Vj2HkA0/lovs4FnurVUUT/sB1YsAqVgH61lXhiJRXf6l/CHbz2EFhaD6YDVDyBDA3agYQx6fFHpm/NUZVZhw0Xx+3BnlqMO8kN8kL2zmpU94mrZXi+Xd4QjGaVL18UIsgo9T6ASvWBGXfDVxgr+jhtFrXozqMM= From: Bertrand Marquis To: Wei Chen CC: Jan Beulich , Stefano Stabellini , Julien Grall , nd , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Thread-Topic: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm Thread-Index: AQHYZNkEfStZ9tvSv0uE8gVJVUTE+a0kpgQAgADixQCAAf/jgA== Date: Fri, 20 May 2022 09:08:36 +0000 Message-ID: References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2e430025-2dac-4dc2-9b87-08da3a4057d7 x-ms-traffictypediagnostic: AM4PR08MB2851:EE_|VE1EUR03FT025:EE_|AS1PR08MB7636:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6YG+T63/Xanrd9Ott1UiDEMmqjgcQg8eAXGyOUb0e8gqb6kAGQ0mrm1OcY3o+OOkNtsJqt6p2q22UM1JPz148bteclgQnEtCvygc58VffS4SwyLzAmaW67lAh36r5ped+rbM/vL2W+ose9jN0ZZ9XVD8wlEcdWD3kzzWnthDarC0hoX05rruYn/HjUxBF8m9H2X2ecuR8OGhPinI0ngVTCIzzQyIFvXTQA141oFpInTEkvgCAHIFZ7y5IFF4eRyEp3HqFosZq2uC6ATI9Eggiulc7Dzy8UQhnxd+xUgBBD5qf9rYTg0Vah0Pe1uPO8zxcVzVriXBg1mR9MTXSLJaF6Z4x1z+DHL7hlELS06CrzteI3slRRIvDtaImAUb2aab337wBz5JiSnjICBSU88PO3zZTrTcEFxBdXfRpqtmzmiMwHr1P4lqYmeAPTR/l0pGZ8F/dKHjzXnM4itoxzh7Y3Xd9OtB8sPFMteB+M6i81hxz+nVbEcXPIpe6hDlA3reg+p3OQcFzMovKRR1q/GwGJzntd/kdJBlq4Qoa8BYdVLzlh48EF1uN5YDtVQ/zPEPQOp/koRBMxftJGGxu5CW/NYQlIeWgY8hBLRI0wzUtzqwyQHaLLYz8tzk+qDPPGtuFen7SjP0PC3eQDPTquQYtQW63YX7oKKBj4ZZ3t3OY4XrhxKw3fwvrKyf5fOFju4qvAbELUSiER3Yo2NxLXZm7OZlsAEd/1hwtbVLCOeeDECs1J4GLdErFBKOh3s74jSe X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(316002)(6636002)(26005)(6506007)(53546011)(37006003)(54906003)(38070700005)(36756003)(122000001)(2906002)(71200400001)(8936002)(186003)(5660300002)(64756008)(66476007)(4326008)(2616005)(6862004)(8676002)(6486002)(508600001)(86362001)(66946007)(38100700002)(76116006)(33656002)(66446008)(66556008)(91956017)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5585BE3133EE0946A314E5C9AB0A78ED@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2851 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 63efc7eb-748c-4739-1319-08da3a40528c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vmofAJrNJ5G7FxXrDAiK5WydUpFDTgvM6Ybmyd0WluL/xqhS721A+U65w6Belws5mNa3uuP1r8M0EvJhAg10plmRhk8bbDyWnblpVKNsjU1Dm+AA7GY2chvKvsRSDMzTNVDCX/oI1JO8VD6UPIkrjCsDK/loWIUKG48zvmUjCyPdSFNG5RY5hKAexIkh0i5MEwEf2CYW6VQRXzVDY5iHsqtqGdDvVW7wNAmBlnG5CShVXjAD8ndrPPnR83Bek1Rpup1orMUA5nf6jCEPM59HTjBjO9U9HsIzk4QWiYts5zn/RDGV44uYtH36R9lKOuoxlGi36lLcWCtf8F9G5ua4tawJZz+jxd1KGMi57TMpeguCEqHb1IEmJDU5e4E1xTDHkn+rzNECO+u3bTcL8wgDgGLga4WmGuliWXmjcWYXgr5eapX0X/MtAhEObqKri+Yjb3LBMw9qdtoSWOSR7B4FM7qCZCvBktYjqaZBWKnVkEju6sN5hP54PGsimT+xywoisLJ5jV6JDtMbh1HfopmCa6vAtlMPcWH5wqBRYr/4+8qGcHjPkay56eIX23iyv/djepM9Y8JPbKd3kEl9cQ53TEDFR/8giRiEOo9dGuRM2iZ8iLPNXOeEl3tU8lny6S5jTDH0+Vc9LLG9We3zDRh1iqUaslURDB2vtggPgz07hNw+ynGZYyUJvDxxX54Jq6mm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6512007)(53546011)(6506007)(6486002)(26005)(33656002)(40460700003)(508600001)(81166007)(356005)(2616005)(36860700001)(6636002)(82310400005)(86362001)(47076005)(83380400001)(336012)(186003)(36756003)(70586007)(70206006)(8676002)(37006003)(316002)(54906003)(5660300002)(8936002)(4326008)(2906002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 09:08:45.1474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e430025-2dac-4dc2-9b87-08da3a4057d7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7636 SGksDQoNCj4gT24gMTkgTWF5IDIwMjIsIGF0IDAzOjM2LCBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJt LmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBKYW4sDQo+IA0KPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+IFNlbnQ6 IDIwMjLlubQ15pyIMTjml6UgMjE6MDUNCj4+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT4NCj4+IENjOiBuZCA8bmRAYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxp bmlAa2VybmVsLm9yZz47IEp1bGllbg0KPj4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgQmVydHJh bmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4+IFZvbG9keW15ciBCYWJj aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEFuZHJldyBDb29wZXINCj4+IDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+OyBXZWkNCj4+IExpdSA8d2xAeGVuLm9yZz47IEppYW1laSBYaWUgPEppYW1laS5YaWVA YXJtLmNvbT47IHhlbi0NCj4+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+PiBTdWJqZWN0 OiBSZTogW1BBVENIIHYzIDIvOV0geGVuOiByZXVzZSB4ODYgRUZJIHN0dWIgZnVuY3Rpb25zIGZv ciBBcm0NCj4+IA0KPj4gT24gMTEuMDUuMjAyMiAwMzo0NiwgV2VpIENoZW4gd3JvdGU6DQo+Pj4g eDg2IGlzIHVzaW5nIGNvbXBpbGVyIGZlYXR1cmUgdGVzdGluZyB0byBkZWNpZGUgRUZJIGJ1aWxk DQo+Pj4gZW5hYmxlIG9yIG5vdC4gV2hlbiBFRkkgYnVpbGQgaXMgZGlzYWJsZWQsIHg4NiB3aWxs IHVzZSBhbg0KPj4+IGVmaS9zdHViLmMgZmlsZSB0byByZXBsYWNlIGVmaS9ydW50aW1lLmMgZm9y IGJ1aWxkIG9iamVjdHMuDQo+Pj4gRm9sbG93aW5nIHRoaXMgaWRlYSwgd2UgaW50cm9kdWNlIGEg c3R1YiBmaWxlIGZvciBBcm0sIGJ1dA0KPj4+IHVzZSBDT05GSUdfQVJNX0VGSSB0byBkZWNpZGUg RUZJIGJ1aWxkIGVuYWJsZSBvciBub3QuDQo+Pj4gDQo+Pj4gQW5kIHRoZSBtb3N0IGZ1bmN0aW9u cyBpbiB4ODYgRUZJIHN0dWIuYyBjYW4gYmUgcmV1c2VkIGZvcg0KPj4+IG90aGVyIGFyY2hpdGVj dHVyZXMsIGxpa2UgQXJtLiBTbyB3ZSBtb3ZlIHRoZW0gdG8gY29tbW9uDQo+Pj4gYW5kIGtlZXAg dGhlIHg4NiBzcGVjaWZpYyBmdW5jdGlvbiBpbiB4ODYvZWZpL3N0dWIuYy4NCj4+PiANCj4+PiBU byBhdm9pZCB0aGUgc3ltYm9sIGxpbmsgY29uZmxpY3QgZXJyb3Igd2hlbiBsaW5raW5nIGNvbW1v bg0KPj4+IHN0dWIgZmlsZXMgdG8geDg2L2VmaS4gV2UgYWRkIGEgcmVndWxhciBmaWxlIGNoZWNr IGluIGVmaQ0KPj4+IHN0dWIgZmlsZXMnIGxpbmsgc2NyaXB0LiBEZXBlbmRzIG9uIHRoaXMgY2hl Y2sgd2UgY2FuIGJ5cGFzcw0KPj4+IHRoZSBsaW5rIGJlaGF2aW9ycyBmb3IgZXhpc3RlZCBzdHVi IGZpbGVzIGluIHg4Ni9lZmkuDQo+Pj4gDQo+Pj4gQXMgdGhlcmUgaXMgbm8gQXJtIHNwZWNpZmlj IEVGSSBzdHViIGZ1bmN0aW9uIGZvciBBcm0gaW4NCj4+PiBjdXJyZW50IHN0YWdlLCBBcm0gc3Rp bGwgY2FuIHVzZSB0aGUgZXhpc3RlZCBzeW1ib2wgbGluaw0KPj4+IG1ldGhvZCBmb3IgRUZJIHN0 dWIgZmlsZXMuDQo+PiANCj4+IFdvdWxkbid0IGl0IGJlIGJldHRlciB0byBtYW5kYXRlIHRoYXQg ZXZlcnkgYXJjaCBoYXMgaXRzIHN0dWIuYywNCj4+IGFuZCBpbiB0aGUgQXJtIG9uZSBhbGwgeW91 J2QgZG8gKGZvciBub3cpIGlzICNpbmNsdWRlIHRoZSBjb21tb24NCj4+IG9uZT8gKEJ1dCBzZWUg YWxzbyBiZWxvdy4pDQo+PiANCj4gDQo+IFBlcnNvbmFsbHksIEkgZG9uJ3QgbGlrZSB0byBpbmNs dWRlIGEgQyBmaWxlIGludG8gYW5vdGhlciBDIGZpbGUuDQo+IEJ1dCBJIGFtIE9LIGFzIGxvbmcg YXMgdGhlIEFybSBtYWludGFpbmVycyBhZ3JlZS4NCj4gQFN0ZWZhbm8gU3RhYmVsbGluaSBAQmVy dHJhbmQgTWFycXVpcyBASnVsaWVuIEdyYWxsDQoNCkkgYWdyZWUgd2l0aCBXZWkgaGVyZSBhbmQg aWYgd2UgYXJlIHJlYWxpc3RpYyB0aGUgY3VycmVudCB3YXkgdGhlIEVGSSBjb2RlIHdvcmtzIG5l ZWRzIGEgcmVkZXNpZ24gYW55d2F5IGFuZCBhc2tpbmcgaGltIHRvIGNoYW5nZSB0aGlzIGluIHRo aXMgc2VyaWUgaXMgbm90IHJpZ2h0Lg0KU28gSSBhbSBPSyB3aXRoIFdlaSBzb2x1dGlvbi4NCg0K Q2hlZXJzDQpCZXJ0cmFuZA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 20 09:41:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:41:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333592.557435 (Exim 4.92) (envelope-from ) id 1nrz8E-0006k3-8l; Fri, 20 May 2022 09:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333592.557435; Fri, 20 May 2022 09:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrz8E-0006jw-5f; Fri, 20 May 2022 09:41:14 +0000 Received: by outflank-mailman (input) for mailman id 333592; Fri, 20 May 2022 09:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrz8C-0006jq-HY for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:41:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb1180a6-d820-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 11:41:10 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-0v1tkyQ-PGG5Rlt6bw6XTw-2; Fri, 20 May 2022 11:41:08 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6515.eurprd04.prod.outlook.com (2603:10a6:208:16f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 09:41:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:41:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb1180a6-d820-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653039670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kq0o3HFsRHNjMdV32ZHN/hvfJaOGtyVOMLJu1ZLX0U4=; b=dlkf+6LX6p2jHbcvJftKb57p9GkAWQt0aSwH2HGcPyzUkNtfM7/b4jtUNS3cPDyKaknZZb XOwSwuZr5I7+VaIgvhir4j/FYtZHaNVjZ8k+UXQM1M5gydNoVnBFUavNxUT7eJhusDRk6U 5RrJQcLLFwk2GiC3T2smAv+wa604SQE= X-MC-Unique: 0v1tkyQ-PGG5Rlt6bw6XTw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETO5EDsnavCoMBJJSKrRh3d4N56tZijZCAQEXON75vvkPhl59ViO+Rk+nYOKR3rtmrDZPOYePvUOA4iy/w9pZIxKkqcjKXaZNNne8BoCUIosJCWqeVc0jhEW5qV4ZhEakJ//FLP103Woo+uTpOojvnw+x7MdIEmZ0W3M6XaCOs377F+NJJrP56EjbW5OPEWBKoRs8DC9mfwqPA89xND3Xt6mWLH3Xq7wCtwNtDwj26NXZhAc1OH+jAyrCaJIO6eBA9EWbiFSlyTLLOvTsq6i3Xpgc4fLcHxhvZAvLKnOK2IgD+wILXC9853dRTK5bQHSDwkv1uzMrE1Ms1tfIIkO1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kq0o3HFsRHNjMdV32ZHN/hvfJaOGtyVOMLJu1ZLX0U4=; b=ku2lmCC27HSgIrTgXB17OdvwZKt56Z8Gecm0bh6Em0oeKqhkzktewRMQtw0ccn/QCxa/sqEzEF4tx1n8Tx/YDqIAcOSoPpo8kYuxv+QtipUqtnVfYh6+gHCsGZpSDRBvuezf0dkVu15ramSplIbWphFZmcTdz+fvYOOcclkZTsgQfnAr2jpiz01DEvUiRHlvT2xz5Ri/KmdVZzKP4is1/2NWjEgIWMiaviAisI7xQHBhjTenc4vdoSTbX73nsdy3eQzF1Sl3z++DW9ym31vU2vSaBEBg+oywqcbMfNoF4D+kCJ6hJXF6VvrkXOQ2dWNmuzNGczZov/e+vcPc45ElFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> Date: Fri, 20 May 2022 11:41:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Chuck Zmudzinski Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0323.eurprd06.prod.outlook.com (2603:10a6:20b:45b::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b17af9dd-760c-4e04-7b8a-08da3a44db4e X-MS-TrafficTypeDiagnostic: AM0PR04MB6515:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dAfJvDz03H6oRK0e8eDDJVj1nqiQGr59FkkJCCAWrEBnCJqwVEsTgnmpsHJ9s2R4M3XOTXwqB48tsZG0WPa60NCEqHaEFjLzqIYFB8XyYJCAonhBQf9c3eVv2xJ/fJ/852D8FRQCn64exKD3EiSfksavLk1E64nj+oUVqFB6k2aErzb7iuUznhRj4/EduoO4tbsSKCrHsnlVvlsAemfXrs0Ct3mXJEqjmHlPzgrqfbFdLkiiXTgXPB0SxGyA85cSp/3y5Nz3oLhU8lTdiqTbaR+/jk5pf0PRIcAHBi+a74RCysLkNjJBdQmJtm+fKhAgOLbCpyPV/jO1ULM3M/hb5pOSntTbZD53JFUOfUaqybE+0RSmHAR3eEpD1eVhiFuQ1Jtq9Ceucj58GjefZrqmJzg+DdwQDbWuFegaQhkIyh/x1WjhIXqskG1Mj//fuiChpLL3vCCHtdpv7QtvSs1OHVk8JTfxOJUo4GPUtCmdjSc/rCa0elm9wzPFNn/EfctYF5colGXBnVKVorGjg1CFU79w/dE2XqYjrNQUYGd97CvmUQwKtO8mfcvDr+6rG8Y3BmQCawWCOm16HEiSPIH5kOB8dydDlCxepwafVX7pnqTPK2iD7lz6apoPurTU9VNd3nOTcVs0katFWuqPJbJR3Lq6OXGY1G6Ps+HIObY2UwWLOjdBuynImeIVdzl+HN1mBmP/mD7+kPSRnaZSazYVgTV/H7/Z0xihojGUxly+csg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(5660300002)(66476007)(66556008)(66946007)(86362001)(7416002)(36756003)(8676002)(31686004)(4326008)(107886003)(2616005)(31696002)(186003)(38100700002)(6486002)(53546011)(508600001)(6916009)(26005)(6512007)(6666004)(54906003)(6506007)(316002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUFkMWx1NWpWZUVIMS9XcHhzbXk0UzgwWk92Z0tJbWNrSWNxSWFZYW80YTRT?= =?utf-8?B?dmIvQ2FhY0dSRGdqaUx5WXNKMXgvREllWFlsdWlTS1dmMVZYdlhwUzJkR29z?= =?utf-8?B?Y3lhZ3cvaW9KRVZ3SVRDdjVpeGVrUEdjakhpUXd4NWFhY1BOV1MxLzhEVEhK?= =?utf-8?B?MmdjcHM5aVRZdGdGWlFIQnNabTR5K2RYUkxhVWxrdElYRVp1Z3l2ZE90REVZ?= =?utf-8?B?Tm9hWm9BbkMxeUpBQmxlUmZya1ZrMG1EWjJjQk9sWDBQbjh2aHd4M3lpT08r?= =?utf-8?B?L3hLK3hCODFMWkxpMWFjdGVXNGpTcWY2aEE4Z3RScHFSZ0MzdzIwRTFQNkxG?= =?utf-8?B?UDVnbFdQdnZDd1l1YUNFQ0dJZWd2aXdBc2kzOWQ3R2I3YmhVQUtQZG5xUVhq?= =?utf-8?B?VzJaTjh3UStnclp4OWJCNjRVVHFpeTlDa3IyS1I3akxyRkM1OWZqaHdsZmMz?= =?utf-8?B?cnMzQlhYRWRJMDh3ZmVqMjdCWDV0Y0VsMDB6UVQ4R0dscnRndFEyaEFHZDVn?= =?utf-8?B?K1pJSFB1Rk1QOE5UaTRZTFZqTGR2eFdnTWkxRFJDejFDQVhFcXNXK2xQdVdK?= =?utf-8?B?YTgra3E0bFc2ODZmZEJFK2Ywd29MWGwxbk1qNEVKTklXM0ExVTFYbDNrUUhD?= =?utf-8?B?dGxrY3JLQlVaaGtKclRVNk93MjF0akhsVVJUVG5lSVA2VHR6SE96UnhVbWM2?= =?utf-8?B?QzQrUjROTnF5L2g1YlE4bDduU2FRb094OWZzMXVqS1dxRUpIT0lCRit3MmpO?= =?utf-8?B?ekhobmxPZkFSTDFPTHVMelFCZi9jSElFYm5oOURDeUNrV3QvbGYxYVFFYWtK?= =?utf-8?B?Y2Z0bGV0cDhLRitURHdRMnJ2dzRQaHI0ak1XM0xqRHA0YW00VXFsSXNmekt0?= =?utf-8?B?VDFPamEzOU9wWkRqVnM1OEl5SDlvL21VNDhjWXNLT255MHkzeGduaStHNXYr?= =?utf-8?B?bGlIbFROa3llK0NPdFNQUTRPOGN0VktsYWVBc01nbEZ2UkswcFBxTStUTThP?= =?utf-8?B?UmRBL01QT2RzbUdUaFIzQmpsZEhoQTlnaHhGWEs5WDNPZDVpVUdsTHhGb2Nl?= =?utf-8?B?bzAzOGk1dnBmK1VYUytJYkUxME9iWDRYVmE0L3pVNVI2bmVyRkFjVnlzVGoz?= =?utf-8?B?TUt6SU9nWFNXUU9UZUZJQWw3cnpmT0ZLWlp2NndxTWNYQ0ZWVlFwSGlwWmZs?= =?utf-8?B?RjBzNC95bW5qN2Y3STVBTEhoS0JqSjAvdzBqUVpYVWVJMi85dHNDL0pTVlhx?= =?utf-8?B?b1lBR0ZMWkRuOWtuNDFBdkw4ZWc0MjBLWW9FVmJHQmpmWG8wODIweHdjeVBL?= =?utf-8?B?V1FsR21mMC9yVXVwYm1mZUhlanNrYlFyMUlWWVIxdmM2S3ovY2hGOEpveTZo?= =?utf-8?B?enJOdFhFankzSit2MC8rMmRlYzZWUDlzZDVpMExGaG1UYnY4V2VLOHZWd1gx?= =?utf-8?B?WVRPY1FraFpmMHdNZzc0emZGMFY1SUYzblBaQUV4ODNCdk1Tcm54Ny9RVmFv?= =?utf-8?B?R2s5YlBDSnNRVzNaOGRta29lM0xBYUhuOWk1cU93OXM4anVKOTMxUVh4cjcw?= =?utf-8?B?UDh2ZGp3RWJlZXljSE5wU0ZRc0IvbVFDYlJCREkxV3hvcDREVXJ1bXFpMkpn?= =?utf-8?B?UVMxM1VmbVJwQk5mVnUrdzdQajBPU1lZK2dLNXhOUWZiWmdRWHhEanNFODlj?= =?utf-8?B?c0xjak53QVVWeU9xTExvSVExazNFd2pLK0pTTHpFTDg4b3ZjWHI2amF0TmlV?= =?utf-8?B?T3JSVWZibjZKSkMwMVdzcnRNWXJhK2p1eTRMT21ObVJkSEVLaE1ydTZPU3Jy?= =?utf-8?B?VHRFeWU0bmdNM0NXcHdKaTZzdzRVU3k1d1dOcytqbllrYXltVEZhVFpjZDBZ?= =?utf-8?B?ZGk4dmNsUlZHbmNhdWtmMHJzeWxBOE1hRDRxTU95YmxzNUNVWGt1TjBYeW5y?= =?utf-8?B?Qlh0QlR2RWxDYzhtUmM1TDc4aFI1NmlTcDN1bm9ybGJ3U0M5T3FmM0p6dzNY?= =?utf-8?B?amdKY0ZMeHMzS05kcUE3UEtka0FBR2xVd281ZFREVElWZXJjUCtiWFdxMDNZ?= =?utf-8?B?U3U1aXpvRTNGaUpESjRBZ2k4bytXc1dDS3VtOHFKaEdZS29RdnZMYVFEdHlr?= =?utf-8?B?bTNWdkRPU3o4c20zd0ZxZDNqMDViVnBOcGl6Zm1WcU1uL0pYTkhSR0p4S2d4?= =?utf-8?B?ak80V0o0QU9RVWZManc1UHNoQmliRW1PbkhubjFnWkdtWThreWNUQjdmN1ln?= =?utf-8?B?NDY1MHBSdzYxcEFyeFZpamxiblJNMWZiK0JPbkQ0N1cwMGI0K0doOFMrTWRR?= =?utf-8?B?QUVyWDg3cFdUVDVXcENrYXNBalN1ZHVTYTE2eTB5RXBUNUwxQXM4dz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b17af9dd-760c-4e04-7b8a-08da3a44db4e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 09:41:03.9918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +hZqBG0s884oEYaKbJKP13sSNGGksMSgW1bpyv7CllHHZ04VAkyo9mTR42HhrePsGCDrfmB4ai/Ek1JXVwYC0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6515 On 20.05.2022 10:30, Chuck Zmudzinski wrote: > On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>> >>>>>> ... these uses there are several more. You say nothing on why >>>>>> those want >>>>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>>>> and came to the conclusion that these all would also better >>>>>> observe the >>>>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>>>> only predicate). In fact, as said in the description of my earlier >>>>>> patch, in >>>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>>> the >>>>>> problematic one, which you leave alone. >>>>> Oh, I missed that one, sorry. >>>> That is why your patch would not fix my Haswell unless >>>> it also touches i915_gem_object_pin_map() in >>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>> >>>>> I wanted to be rather defensive in my changes, but I agree at least >>>>> the >>>>> case in arch_phys_wc_add() might want to be changed, too. >>>> I think your approach needs to be more aggressive so it will fix >>>> all the known false negatives introduced by bdd8b6c98239 >>>> such as the one in i915_gem_object_pin_map(). >>>> >>>> I looked at Jan's approach and I think it would fix the issue >>>> with my Haswell as long as I don't use the nopat option. I >>>> really don't have a strong opinion on that question, but I >>>> think the nopat option as a Linux kernel option, as opposed >>>> to a hypervisor option, should only affect the kernel, and >>>> if the hypervisor provides the pat feature, then the kernel >>>> should not override that, >>> Hmm, why would the kernel not be allowed to override that? Such >>> an override would affect only the single domain where the >>> kernel runs; other domains could take their own decisions. >>> >>> Also, for the sake of completeness: "nopat" used when running on >>> bare metal has the same bad effect on system boot, so there >>> pretty clearly is an error cleanup issue in the i915 driver. But >>> that's orthogonal, and I expect the maintainers may not even care >>> (but tell us "don't do that then"). > > Actually I just did a test with the last official Debian kernel > build of Linux 5.16, that is, a kernel before bdd8b6c98239 was > applied. In fact, the nopat option does *not* break the i915 driver > in 5.16. That is, with the nopat option, the i915 driver loads > normally on both the bare metal and on the Xen hypervisor. > That means your presumption (and the presumption of > the author of bdd8b6c98239) that the "nopat" option was > being observed by the i915 driver is incorrect. Setting "nopat" > had no effect on my system with Linux 5.16. So after doing these > tests, I am against the aggressive approach of breaking the i915 > driver with the "nopat" option because prior to bdd8b6c98239, > nopat did not break the i915 driver. Why break it now? Because that's, in my understanding, is the purpose of "nopat" (not breaking the driver of course - that's a driver bug -, but having an effect on the driver). Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 09:42:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:42:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333601.557446 (Exim 4.92) (envelope-from ) id 1nrz9m-0007Ne-Oa; Fri, 20 May 2022 09:42:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333601.557446; Fri, 20 May 2022 09:42:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrz9m-0007NX-Lb; Fri, 20 May 2022 09:42:50 +0000 Received: by outflank-mailman (input) for mailman id 333601; Fri, 20 May 2022 09:42:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrz9l-0007NN-I3 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:42:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3579bc2d-d821-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 11:42:48 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-mF-8T5uzNNO3isLH8Kncow-1; Fri, 20 May 2022 11:42:44 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4060.eurprd04.prod.outlook.com (2603:10a6:5:23::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 09:42:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:42:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3579bc2d-d821-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653039768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IclR5YN6S+Fq/Ycgrs5PBrPPAqm9Yru3iC86IYfJ/Rc=; b=Xsvomgh1/JbZHofWCEk4ikDElI4PpEYCtWO9oZCUq1KQkoLEb4W8bb+/KlvdTvDkEEiRcy 2KEfIFwrJNdsTujsf8PbW5rgg5pMOuv5jtcNaylnuT22qvcd2nr/kQ2IRqRGI0ZPrIHfIH 5/Z/8B96PvFf4QgtjbntmlsbyrETFJw= X-MC-Unique: mF-8T5uzNNO3isLH8Kncow-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFarrIhzmZJdXeL9zLJitTowLcbZEEktAEIpSY0OEgCQXWFwNwUgtpUmuUgR1/aev1pTzHSQAOB1maWzl25jluX/4F1NSH0PjKg98M9oaUeyZdbHI1qSyAF6FuXToPEyH3JKBudVcHvDcZlEGXAjMuapeJ2LVwlJoW1epBuQpX2qO7bYzfSWrr3oSutZ5+vZJXQHECqk7+GrGHndm7T8rrwwwJ3NGvbRN3rny+WxRAqL+nbCJWT9xSYOMXsSzgJFBg4W/YjV38WkG5rI3C+mPTmdUwvURRnTMK+RojmTKcQ+8jAFad4n8O0i2imCzAX35+RDqleZ6g/o87IgW1BaBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8dL1yg921o09JUI+MuCYTqS449xFU0BUBLNKzmZlYM=; b=agm0nJ9EOAy5BPZyt5NE9MatirT32mToZmwWrlqQ6YG6UTfK9W4MFbbDBVP3vkVtteOgEWLpGyG/zFbhl5umq9HBr3Yeya0Ix5rl2MMdGAVsoGhMGP64G7uQ5GxGaCaZoOAoaXFrqubITR86tfg7S9NugU6rvwF9uKSZ1fJhW46nzeHzemss2qELGIlBRefZ2YtYFeGZMEmKhRB2pi5ouEjQb4qzbTeT5zDSPV2xBtee37Rv2xX3viLDPXcm60PW6YhzHvLzS8MLniG4JapzWUrK6frXBNdimZ27wI6s6VF/dJWA+GEBdRyq7q4+7/naF4uYf2s//F5lalmo9fswsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <663a03ad-9df1-173e-19b1-4f4af1aa9b37@suse.com> Date: Fri, 20 May 2022 11:42:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 2/2] ns16550: Add more device IDs for Intel LPSS UART Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> <20220520085343.1835866-2-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20220520085343.1835866-2-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0570.eurprd06.prod.outlook.com (2603:10a6:20b:485::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e672b815-484e-4f56-e774-08da3a451491 X-MS-TrafficTypeDiagnostic: DB7PR04MB4060:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AB/u2xr1vilgoqEXkEqDGoXN22kLNYvTYNkknpgnuevQPka77O4Sgv4pNghl1ot2//M28ML3X8ROWzHesijwEsf9weFDa1WsRSi5UqjTcyqlp1IwFhlYndCszTmbidlhTBDREDcO1143njZwttelhoYRhXZNEBy2udk9WKIl3NAEtI0jzkDXZiGhL2/MIOi7lt1fxWp8yp6FidJ8x7rpTvyPK1CHNkS/i7cBp5rnuk4NoerR1lkuuCUEkmXWjl5Bbxo9yaFf835LKbkRYHi5E/SKK7ByA1b73w2Oba+uzzI+NkP9HNniwqVM2B+vN0INETi0395AGLl7eJtmN4ne1jf04U5hmn7yNwdOcxKaTAe2m68qLgNL19VwWdqBgUqeOtjXE5N5qY9RH/ZMrjj1ssOQ15tQ1jVj7djF6dh2PTmM2EP9w4jd9cBlGCumjEBVYTyKr5kd83WggrwnB4Qp30K8cbvwWbaRx+BqXypPpBta19qPP8+NAr+k9dFh0+20kWzMufl33Io5O+gtProHXPvm2Cjt+JnyoBVyPi2kxQ1j2TZSJAOwBTf8/z4PugvAUQG5EdU+1NpPaRxdVAT6NwTmWpJGtZSxEqgGUmdkjyY//VJpFVIEJpuvHBkPbpnTfgcnkvcVQTgX5rXSzhqNrJiOV5hwFFnMmrhev3Zu+8nPGrcLKnE7pscvrgFdHCNaW9DfsOCrmRjMQe037C/zleZLHcP+nuE6NcAWbFnKriuxfnvO0/6X5Gpvx4Ugtvus X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(6666004)(31686004)(8936002)(508600001)(36756003)(38100700002)(6486002)(26005)(86362001)(4744005)(66476007)(66556008)(2616005)(5660300002)(2906002)(6512007)(6506007)(53546011)(66946007)(316002)(54906003)(66574015)(186003)(6916009)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?umSAXY06V3mBLsFaakHWjvH72/gSsXWr8h/wGhxImkTK1PNqXQPKysXKnCOY?= =?us-ascii?Q?0zYT1heSkOG06ihl1x+VjomHuZ0oOEACr7XDLJ2J0r6rH1OjbJaleqLJYUHV?= =?us-ascii?Q?AuNx1Xy+neO6SrA9RY6ozeKLvtYAdm5KjVG9pP/2ilg5cnRMYo4iSWwWSf+B?= =?us-ascii?Q?hKBhUs/IU6Td7Qll4RLkUQ6SSygAguTVCFb+OE+lAqxwG2MX27JxxcK/X1Ox?= =?us-ascii?Q?cyStUgYNUAqb9Tme+xv2NmTEZ+hy1EC5B4wpEtrKD+2sjqW/YZHx/afqaYva?= =?us-ascii?Q?S8Fqk7N+vR7PX8zIdFnHka77j8vEetiuZXYJqyD37ygmwM5n+wDCxbuFweTU?= =?us-ascii?Q?v1jZEh8PJM3sYRIPg6ODoFFUvczTbjUJyP8AxnAbPShKqp46wT3TQJQBWmNW?= =?us-ascii?Q?UC3VGvVcmyHCtGxag116iwlIGzm7g9jfLQlqpNXvwZyAyKDbrzJCX6+c2C3p?= =?us-ascii?Q?14W1Yms22EhIEvOFqECLpC1hm7+nvbTqVFkSU7tK47tUjtbjuB3Nr4vxHT+0?= =?us-ascii?Q?Gn1hd2tEjHn012nikk8fCYrPJoLWF2CkKRBaDZupFadF81S2b2Ge2oretTHq?= =?us-ascii?Q?ngXIHHfhWlScMjiungX5nzDEyCOGx6dUuFe8nxzSTHcjAQBByks4Z2RtS/Zz?= =?us-ascii?Q?Dl7/GtLZed6O24DAImCfFl7++Lfvq359XehOQv3FaK9/KDg06hCcfm1l6adD?= =?us-ascii?Q?m3TiLMPizMFXI3nnYQUs8AX/6DqwKYBL+h5H0BmetmBnNTS71btQg2ZVOrf9?= =?us-ascii?Q?ZiRqsIu2z9ba8D47PKSR94PiFD6A5tIqsPzqQ9Ml3JmUHpXC8Q6Man1re6Fq?= =?us-ascii?Q?+3raRecij7gjibeKzh0WZ23pTgwg0rKbopj11BMGS1abNTUmeJ3Bq2rKnA17?= =?us-ascii?Q?yvLv0d97QgVp29jYwbNxHgY5bJ92Sp/jcWQSP94d8WQcePgJdiHTYQ1GcCko?= =?us-ascii?Q?Aq9qFqNF0CePUbDWv2oPNo9DTaSHCikoH0y+uagzd4iCPYVBuV9pUQpyCLXX?= =?us-ascii?Q?wSJsBGHQwfLAzi5uzmRU6k1zbDqWpjZDb6WdMOJcLkObn+P8EQA/1yNaJQXw?= =?us-ascii?Q?HqISNCDrzzBlJAE0XRGEFA+WC/Niwov+MUFnYFicA9cz+m5JdaAb/tEDYLgA?= =?us-ascii?Q?4QWU9UQVOWgFxwWaBf2a6zz5XKuSDcBioyWBn3jaWE7XorFDgw8Qnh/lxPsj?= =?us-ascii?Q?3Qn50oTRjEn9ILgIZyodr3dC0wWbmAZET61nR+rBiEEtL6/FPjmpsexAVpCr?= =?us-ascii?Q?KVqN3Jn475N5FYr4lAw3gLoSlJISRDCy5HwFSneg8CUfpekFZerCoHPf3AGL?= =?us-ascii?Q?xyiRU2A69UhvHdxGpDHP8U1Tq85FWyBYj0QLOYgAHX6X7oQocv+Qd+rp0/oG?= =?us-ascii?Q?V4etqHBioedENl/3LU5Y3zWrkUM1Vn4EVJCEFOW71kTgM4pTXIQpxhQZl8EN?= =?us-ascii?Q?BvqrC/rdHjEdMMOVasvd+dkYl6uNOkCdHuFd1NME+ilwOZTGnW3JVNUnlsRf?= =?us-ascii?Q?7PcOvrVja2OtSxZHrIDB1X8h7HcyKamVbeKM3rMpHWzkwvxbC1eeRNEIM8bl?= =?us-ascii?Q?LrsCafLuP3tQd1wGJkjeQX2Tc9+WGsby3LAor0TLUPUPu2NFqMlj2BGec0OA?= =?us-ascii?Q?Nd3ddccV2QbYWnIgwJMp7PTpzgOQuZX3H43WXpLpqhkLELuRWKPYs1hL6TjM?= =?us-ascii?Q?mRWAZ04J/6bS+/z18vkTO4ny3QrUN4Wb6rdcMtZYTi/fwRhv/gcBuw91XB+8?= =?us-ascii?Q?OKChe0Ox3w=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e672b815-484e-4f56-e774-08da3a451491 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 09:42:39.9388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E9BowbO7IU6zqs++7FLhEm+RkC4hT6hETR4SBtdEbKFTA+eiufQhkxhWVTaM9vD2RRPeqGiw7nXOSOtih4k2qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4060 On 20.05.2022 10:53, Marek Marczykowski-G=C3=B3recki wrote: > This is purely based on the spec: > - Intel 500 Series PCH: 635218-006 > - Intel 600 Series PCH: 691222-001, 648364-003 >=20 > This is tested only on TGL-LP added initially, but according to the > spec, they should behave the same. >=20 > Signed-off-by: Marek Marczykowski-G=C3=B3recki > Acked-by: Andrew Cooper Oops? Commit 1f0b1f5cce9d. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 09:46:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:46:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333609.557456 (Exim 4.92) (envelope-from ) id 1nrzDe-00083S-83; Fri, 20 May 2022 09:46:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333609.557456; Fri, 20 May 2022 09:46:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzDe-00083L-5I; Fri, 20 May 2022 09:46:50 +0000 Received: by outflank-mailman (input) for mailman id 333609; Fri, 20 May 2022 09:46:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzDc-00083F-SP for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:46:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzDX-00034X-De; Fri, 20 May 2022 09:46:43 +0000 Received: from [54.239.6.186] (helo=[192.168.4.58]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrzDX-0008Dw-6x; Fri, 20 May 2022 09:46:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XUm/SSk7GCzQrh//822CuekK5vAFysWo5BpOTzl6WCE=; b=bqufTKx78N5SCijUDAi4Dpdu6t gauysOkiDNrwGbSF30DLguDlfdfSY0E4o0Ir5rL6eCOrAbW2MwbPKrI0r+Rg/a/h2Z5l8PoQ89B9D S2sG4aVCR8clWDpaKtHZXf5XUjP1v845/EbuCd509pX7e90FW3TNPjfp0T740gZeOUBI=; Message-ID: <997030b6-2f7b-a180-d72a-2e3eaa15b93e@xen.org> Date: Fri, 20 May 2022 10:46:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm To: Wei Chen , Jan Beulich , Stefano Stabellini , Bertrand Marquis Cc: nd , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" References: <20220511014639.197825-1-wei.chen@arm.com> <20220511014639.197825-3-wei.chen@arm.com> <9b04ca55-f617-dc14-cbf0-a3e427ad5869@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Wei, On 19/05/2022 03:36, Wei Chen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年5月18日 21:05 >> To: Wei Chen >> Cc: nd ; Stefano Stabellini ; Julien >> Grall ; Bertrand Marquis ; >> Volodymyr Babchuk ; Andrew Cooper >> ; Roger Pau Monné ; Wei >> Liu ; Jiamei Xie ; xen- >> devel@lists.xenproject.org >> Subject: Re: [PATCH v3 2/9] xen: reuse x86 EFI stub functions for Arm >> >> On 11.05.2022 03:46, Wei Chen wrote: >>> x86 is using compiler feature testing to decide EFI build >>> enable or not. When EFI build is disabled, x86 will use an >>> efi/stub.c file to replace efi/runtime.c for build objects. >>> Following this idea, we introduce a stub file for Arm, but >>> use CONFIG_ARM_EFI to decide EFI build enable or not. >>> >>> And the most functions in x86 EFI stub.c can be reused for >>> other architectures, like Arm. So we move them to common >>> and keep the x86 specific function in x86/efi/stub.c. >>> >>> To avoid the symbol link conflict error when linking common >>> stub files to x86/efi. We add a regular file check in efi >>> stub files' link script. Depends on this check we can bypass >>> the link behaviors for existed stub files in x86/efi. >>> >>> As there is no Arm specific EFI stub function for Arm in >>> current stage, Arm still can use the existed symbol link >>> method for EFI stub files. >> >> Wouldn't it be better to mandate that every arch has its stub.c, >> and in the Arm one all you'd do (for now) is #include the common >> one? (But see also below.) >> > > Personally, I don't like to include a C file into another C file. Same here. I know we already use it in EFI but I am not in favor to add more of them. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 20 09:47:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333614.557468 (Exim 4.92) (envelope-from ) id 1nrzDy-0008Uu-Gr; Fri, 20 May 2022 09:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333614.557468; Fri, 20 May 2022 09:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzDy-0008Un-DV; Fri, 20 May 2022 09:47:10 +0000 Received: by outflank-mailman (input) for mailman id 333614; Fri, 20 May 2022 09:47:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzDw-0008Mh-Uy for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:47:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d02f52e7-d821-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 11:47:08 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2059.outbound.protection.outlook.com [104.47.5.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-v-aG9JhRNHiqWyFRargKbA-1; Fri, 20 May 2022 11:47:06 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3018.eurprd04.prod.outlook.com (2603:10a6:7:1f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 09:47:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:47:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d02f52e7-d821-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653040027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctR/k4BEgZRwWAsjZ5XBJxpXkEOU9t98wbo7KbK5c5c=; b=UTF5R3o3PI9z3hpz22gYiskI9U8L69v69Z9hoppbiF0EkMFyHzKRRLvf74GkoLNcQrUGFU AVHl4/x9VGORC26vsCPOlc8OXhgF6dulVC/u6J/v1xLm5fHNGRpqqJEMLxl9d75F68WoHr 5LK3NSA69IyN+gIfgbU6pKJAs6KHDEY= X-MC-Unique: v-aG9JhRNHiqWyFRargKbA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EOCKLyvlAykeuY0BlJCo2JnocwSi2mQER6Rx+/LNJzxY7wHUgE3vJGWW86ZX1g1rzn+ak/iRQBQbDqjWLkFBh86yq4iGyWH2/Wh3sgmNnvDXk62nZpkkpHfWGLN0bSP3b3HQb81SB7qxd5sbq4G4uJFQJkhE8DeQrx7uQiUl7oY7mzTFQkpw5ndm/LEz6DxsdHbxf+90oHXJQYt+PNzzMPQT9Y1n6Tghf4h1xZNbx3gDWoBVBOtw1r5kg7Ov38/okJNSfB9a4D2st7yOe6Cx9HbB7cEVU3ubhkPJR1Z2m6c16lRCIll+Au4qeOLILhtyBPbqzDuMBeVrzU7Qhynd8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g5r7iEN+48pW6ircr7WYXa1NE7WzPMOpEtcbzM3LXYs=; b=X7+AGaqh2YXCDD7pL3HPzCOj3NmmDofA3yatSAuxmgh7QgeIcSgL3PEN0e9hX+OciAt5/nGxpmqkpyedxqyzSA1aJsdtYn+B0LtvZi+gGkN2gPSITgAiZLQTahZ9UECx9wuKNHlgJ7nHRXI/2kmRhgpCtNce9fgY76TAiw2aIgfISQH7PAuBj/4MIsTXFwEjRELBWdpYgfLjHdLrNRJXAshUVGRBrjilfQg+63oWpbAyIYTv/4jK2pPkNghMqqzDEJlIjH7vOBXxxxK7UbtRMSKSB38+gwo2sCzplYfgvpy67KDagG1Yx2dTrbIPrl6FFmxVnWlfNiN1D4dPpBhqkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <825cbef2-2b1c-b05f-1c4e-cace2eef099e@suse.com> Date: Fri, 20 May 2022 11:47:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:20b:92::40) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4c89be0-58c4-47ff-a636-08da3a45b28c X-MS-TrafficTypeDiagnostic: HE1PR04MB3018:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yvIXSS8Pw2P699pIMFl5WuR7Fa8B0imARlmJZILT4IkBt+ETLKvIIonZplVhMyROC3Fo9E1lg1EnuouVp3yeDXEMM6FKMKqZTjoAm41X64DMbz4FjFuicVpWdzs96f3hcvEoIboNPdnYvL2UrYg8t06hiljAqZbTwCGkxpCWTAdTYVTenyWww1w7pf8ZcODismprRLufBmFB44JVeC+EFw0oH4nbHVN98dxYn96CTuFhUhJPWB+HQC0KNCAX+XxjO9V7Ty85qf2tHxWvYUmtbjsGU2NLXT46xSIq5OcFfjnJvPypxCeGoAH8q4V2b9iRYUxcGzJbcxyvXz14I69cy81QZfxFwg5Y1wUTGSsRPfs4NLSQSzIuUVpEgXsqugqrjH0FqiH2PaQgAAP5UA6yB355mG+uNnml/ErzGn0yWct1MjSPdnKoba8IeLuU5gHxu9hIMtQZhBV1/dGK+VD1M79BT2dDflpyRKzjiLv9Jhw11knfbNAveMbBhzYvC/ruDCyTg64Vmhlwm2Y+wsq9zDCFTXJNX8k49jJW6xebdAQouBM+Bv32kuhq5AcGGjL4oETD46VhH/fpcGO3eoGRW7I0dEUhngpOeTrb8JKTfwxJo6DQox7qiFg+2Lhw1T8WQFiP1ZW2UD7aVbDvZF/YL8HU7q5/PA7pc5k1SdxX6ckzGZ1HZwnZe1h/jKfY6j0efdyuVgQhEX9Zt3KoxmQklZdzwvYa+B11nGul2ztmfhU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(4326008)(5660300002)(8936002)(6486002)(8676002)(26005)(31696002)(38100700002)(53546011)(86362001)(6506007)(6512007)(2616005)(186003)(316002)(6666004)(2906002)(36756003)(6916009)(54906003)(66556008)(66476007)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ejfUyE0Lwn6xUk9De4mWQfGXHLSKYG1X87Gq61nDJdI8ppON1aVbpB6OAajR?= =?us-ascii?Q?73OSG2RrmvEHh+LbJsz+n8qGAO5DerLDS8Zb0rgE4Vl/Q60Xpogo1DmMRgSb?= =?us-ascii?Q?/yNuhsZM1VCXk+vEUuaMabdHgzFn8S9zAit69up0hNnV/u6zmcTcIaWxwR2+?= =?us-ascii?Q?p9V2niC2lHpBI3t2tWLgI8lPckQotIU75SB7Fo8cMwYH+3ns8xc7OPb7pEqD?= =?us-ascii?Q?p1oFczWci5mkUv8bDzLtcoTLXfRskCECJcY6m1l79MT4zRG55iX435++m3wW?= =?us-ascii?Q?CpubCC++XYKySWA44JKRcmK8XPoyooHZS76OuQynvDncfTJoqejiOer9a91+?= =?us-ascii?Q?OjTOsbL9Q4euDJO4GpK0Rb1bLL7E4TvT2GwdtMGf488q08dm8QwLTXcXpE/N?= =?us-ascii?Q?aKeEeUdTrIP2qRIZ9M8E/l9xCkhu1GvzppvMpjz0uVHS1iSzykKxQsgnMTAE?= =?us-ascii?Q?znqaqd7bSBl6pMwqlZGFPwx/cL8YDEyTSc0jB7VYC7Nt+o6GdevDY4YxpaM7?= =?us-ascii?Q?1BADn2JQi6NdsxUfEGNrOqDp07RxOQNGu/csJqZwpn1M0AMLIgznHnHbdI5o?= =?us-ascii?Q?EYuVgMv+KgWptiO8SD7N+1OfsIyrogPdnoWaFWCenRbKApsi+ksVmpHip8aJ?= =?us-ascii?Q?e0jsoTCN/NyQzjmiQouAaKldJxxs2mXsUnSYWhlOYsm34kDT9pmqoArF9d+G?= =?us-ascii?Q?R4VIDUK9lZ/UONWrQEIB+RSdpqIyFGZkG6sMBGS+aQ7FzSRcQh/aFxY/jjV2?= =?us-ascii?Q?ofN/mQPuUCs0kwCDMekICEqD9TZGuyp6I302B/wYP4J8LscB7MP0Gab2YFuh?= =?us-ascii?Q?EAEgl79+syMxtGeZU8OkUU1125PyujibaXn+k+G50d8vOdK50FePLM8E4+wE?= =?us-ascii?Q?uxA04Buk5D1L+wl2+Dzt8rm+8WnQB5TmcRb8yxOv4nY25bOFYIW5p66aTwxS?= =?us-ascii?Q?w/G6LYeGWr8Hlq62y2juVjAzyjo6C8JAYR3xN5CiSDeaqY8I+2GmTArEFbyu?= =?us-ascii?Q?Lojyum7ohp90zic5ogaupdyp4CCkIguTeQWUvugYzVQE5rSEN2jZtHo4e3Q3?= =?us-ascii?Q?QrdarOp554HavFXAA2LVhHw14XOyHc65n9GriljU5X1cLgIxyUcK4gOPTYBj?= =?us-ascii?Q?HsOUMOazIfsT7r8RpttA8RzyjOwvKYy22DZREmYFEa2zuVlbN0HBNw7+vwtw?= =?us-ascii?Q?srv9hNmg+TUDpegMynUDHVQ7AwTskyLCUsmuaR1L4lmDEZfsG9whg82pKlT1?= =?us-ascii?Q?Hh1M0eJACgJcfbTc5tDW1n0mIuoQVJuKjHCQ7G49n1q06R3s5BS2AVF0qapU?= =?us-ascii?Q?SSiCBeNXro2pjumK29WTTn4Kq94fTkSEj0pDhuxTO1NKzSWYdYy7xxzHH2C5?= =?us-ascii?Q?33tSyuV6DICRia428z68nYI28wC1FJxeJG84w2ssAaz0nV9a2oC+7oeMonHl?= =?us-ascii?Q?ZF4Qtt0N3aorOdwuQItLoZ86c31S5mgU55bKOX1LGozS9wVAbZaHEo8JGKwR?= =?us-ascii?Q?R/nbrdxzsU/ZhBWL3PL9vQ7GZKIObxKKE35rXuELqtpb0Cz5/RjEq7YxsjQH?= =?us-ascii?Q?OMrFYH4bu1BbXF10VgWwU5fBSks9HIRigWFaO+X3M5UeYh6Uecp/KnxNwBF7?= =?us-ascii?Q?q1/ncbXGOVtMd6xeMeUBqlNgwuC6VulMEACtdf425SSQjyCV1Tyvw9gODotb?= =?us-ascii?Q?UDKqpIZWl046lQ1420WG5XuSZZOsfwAVKMgRPrQ+nRrH088fHZlBP+5unwX1?= =?us-ascii?Q?qwY+Fnhrqg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4c89be0-58c4-47ff-a636-08da3a45b28c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 09:47:05.0000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rvvINmzV0WMOX1qAzsKg2IC8N3HO+WbvALkai+fT3ZxCddvI/vxx1zRlirUZjcA3NZ4h1QIStfMM3exv5IRbOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3018 On 20.05.2022 10:53, Marek Marczykowski-G=C3=B3recki wrote: > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > by the PCI Local Bus Specification Revision 3.0 (from 2004) as > "unknown"/"no connection". Fallback to poll mode in this case. > The 0xff handling is x86-specific, the surrounding code is guarded with > CONFIG_X86 anyway. >=20 > Signed-off-by: Marek Marczykowski-G=C3=B3recki > Reviewed-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich > Changes in v6: > - wrap the check in additional CONFIG_X86, with appropriate comment Thanks, albeit ... > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1238,6 +1238,17 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_= amt, unsigned int idx) > pci_conf_read8(PCI_SBDF(0, b, d, f), > PCI_INTERRUPT_LINE) : 0; > =20 > +#ifdef CONFIG_X86 > + /* PCI Local Bus Specification Revision 3.0 defines 0xff= value > + * as special only for X86 */ ... I'll have to remember to correct the style of the comment while committing ... > + if ( uart->irq =3D=3D 0xff ) > + uart->irq =3D 0; > +#endif > + if ( !uart->irq ) > + printk(XENLOG_INFO > + "ns16550: %pp no legacy IRQ, using poll mode\= n", ... and perhaps insert another colon after %pp here. Jan > + &PCI_SBDF(0, b, d, f)); > + > return 0; > } > } From xen-devel-bounces@lists.xenproject.org Fri May 20 09:50:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333625.557479 (Exim 4.92) (envelope-from ) id 1nrzHK-0001b9-W1; Fri, 20 May 2022 09:50:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333625.557479; Fri, 20 May 2022 09:50:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzHK-0001b2-T4; Fri, 20 May 2022 09:50:38 +0000 Received: by outflank-mailman (input) for mailman id 333625; Fri, 20 May 2022 09:50:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzHJ-0001as-N2; Fri, 20 May 2022 09:50:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzHJ-00039Z-MC; Fri, 20 May 2022 09:50:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzHJ-0006R4-BD; Fri, 20 May 2022 09:50:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrzHJ-0002ad-Al; Fri, 20 May 2022 09:50:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mFBED21IVY2W08hJ/FujLOcm4mtx9WHOYEqQcDu7es8=; b=UucgZz0ZR0o3ntbXi3GObX1tTc /+qk0p75kYGMIw5/mQg5+utCf7502NFKcoDIBnMx7jUovLbQehfYy4TI0uk2Z3tcRq9klEnOttJ4p Kb4JQKu4w+UkMihrAJxMEAQROlpvmi0KBTNgqZer0VG9JjT8RRoU1iwESc2c74S1NJQY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170595: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 09:50:37 +0000 flight 170595 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170595/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1115 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 09:55:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:55:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333636.557490 (Exim 4.92) (envelope-from ) id 1nrzLV-0002Iy-Ln; Fri, 20 May 2022 09:54:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333636.557490; Fri, 20 May 2022 09:54:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzLV-0002Ir-Is; Fri, 20 May 2022 09:54:57 +0000 Received: by outflank-mailman (input) for mailman id 333636; Fri, 20 May 2022 09:54:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzLU-0002Ih-7D; Fri, 20 May 2022 09:54:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzLU-0003DI-31; Fri, 20 May 2022 09:54:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzLT-0006e0-HC; Fri, 20 May 2022 09:54:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrzLT-0005Wk-Gk; Fri, 20 May 2022 09:54:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zzfYnbRjEf2rQsMuKIU6jYQgy7ERwd/bH/kL2vGushw=; b=4nuQKAKbuJSYf9pWXeXOYjgDP+ eXQiS4QVO2ipdHNEprnFCCzAAa0mRxsH+Ytovvs0/sRcO/4o+6kK8H3cfjHkuklbwtPp8EcYswWgx 2NtDApi6lFWauxXfoK1MUAheLqKuUi2y0SUV3XMbZPZZcj6OIf8Dm8YtukgSXoD8td/M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170589: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=1bd24e79bee1800e7191863cc4617b12fe614dbe X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 20 May 2022 09:54:55 +0000 flight 170589 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170589/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 1bd24e79bee1800e7191863cc4617b12fe614dbe baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 679 days Failing since 151818 2020-07-11 04:18:52 Z 678 days 660 attempts Testing same since 170589 2022-05-20 04:20:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 108839 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 09:56:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:56:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333646.557501 (Exim 4.92) (envelope-from ) id 1nrzN2-0002sh-53; Fri, 20 May 2022 09:56:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333646.557501; Fri, 20 May 2022 09:56:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzN2-0002sa-0b; Fri, 20 May 2022 09:56:32 +0000 Received: by outflank-mailman (input) for mailman id 333646; Fri, 20 May 2022 09:56:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzN0-0002sM-V3 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:56:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzN0-0003GQ-Ax; Fri, 20 May 2022 09:56:30 +0000 Received: from [54.239.6.186] (helo=[192.168.4.58]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nrzN0-0000dD-4Y; Fri, 20 May 2022 09:56:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PRzw3ZRTxQMZAlyfVcQtky5xDGWzbmeaJT/z9RJpTG0=; b=ltbjWweqQUPFOijBcTdzJdnT9i g/S8sKIxmAEwE9EU1zwBie2+nYVBPsj/x0j21SnpHwX/zYsghEUsXKaNGvwkjTrg9BXFHXbTtfPcr 3MmQu5yu8vNeecW5c5YSAu91xQ2WZ2rd4FUprkdi5V+BjJ10lEwStdnYRc3/ajAORJWs=; Message-ID: <69ec386c-6d2b-635a-0d8a-b72afe09f579@xen.org> Date: Fri, 20 May 2022 10:56:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, Since this patch has been committed, I get the following message for on every build (make -C xen): which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found I wasn't expecting the build system to check every time. I think... On 26/04/2022 13:38, Bertrand Marquis wrote: > +cppcheck-version: > +ifeq ($(shell which $(CPPCHECK)),) ... this is because ifeq is similar to pre-preprocessing. So it always get executed. So far, the message is harmlesss (I can continue to build) but I think the check should really only happen when the target cppcheck-version is executed. So can you have a look to rework the rule? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 20 09:59:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 09:59:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333654.557512 (Exim 4.92) (envelope-from ) id 1nrzPh-0003Wk-LM; Fri, 20 May 2022 09:59:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333654.557512; Fri, 20 May 2022 09:59:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzPh-0003Wd-GZ; Fri, 20 May 2022 09:59:17 +0000 Received: by outflank-mailman (input) for mailman id 333654; Fri, 20 May 2022 09:59:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzPf-0003WW-KZ for xen-devel@lists.xenproject.org; Fri, 20 May 2022 09:59:15 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8095aad8-d823-11ec-837e-e5687231ffcc; Fri, 20 May 2022 11:59:13 +0200 (CEST) Received: from DU2PR04CA0062.eurprd04.prod.outlook.com (2603:10a6:10:232::7) by AM6PR08MB4408.eurprd08.prod.outlook.com (2603:10a6:20b:be::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 09:59:12 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::17) by DU2PR04CA0062.outlook.office365.com (2603:10a6:10:232::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17 via Frontend Transport; Fri, 20 May 2022 09:59:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 09:59:12 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Fri, 20 May 2022 09:59:12 +0000 Received: from 84fcb394dee6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8B341E55-FDAA-4014-9E52-E2A3C6D20A90.1; Fri, 20 May 2022 09:59:05 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 84fcb394dee6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 May 2022 09:59:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB4203.eurprd08.prod.outlook.com (2603:10a6:10:ac::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 09:59:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 09:59:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8095aad8-d823-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dfMqCYcKt4MJccWxSakV/MgMAn2CL8n+bLQPjsF4jgySUDgfKNkHHXQ5++42fGUviM1Yt+r6ugcEuB8JxUL/ahJNb5SGwU3PxlbpvBFmaTL8EbK8e53NKY1Om/AU/QMce5QdBjRP/JcmKXcsWbE57u9cactOq1WTF5G13jXnIbXCDcY4qbZGf5KlDkA+MQqajO5ObEKKDW3ZbFZsPav4uJkWhn3l7zkRu69tcHPhqssCmVl4u/NS9mef5/kml++edgOA8sAvsej8B1h2YRRLTjUOYhnNM7ls+H9og2I/QaFmNasS1fleUdijM5EHlCHieV+NRpnULnpJCRRTVZpcug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=MCUbN16Oo0r6DCn1bFDS6z6TPuptjwyIOWTI4IBbuPEuG4egzcnt1GejcoqKq1Gd38a+ckN0XRz9FsBRAWKp9d4sG4JQZnVInuzFOfVezZVXyFpoA1yAUfqMFsJO4iU6woJmOf0/FjbyLN4RZblVs2qpFotZgV3aZFp1s0Ph7rjg3WBiI0OSLIhkhkstu9D7/GyrE9ReIjLwxv9LiaGFaV/4shb4iel+viNWumZgfz49JhPT/6mlQmlZxPuxjszFT+IfOtSFNfROqNWDE2w25l01uv0/0WNWFVH+/fj6eRsCEPyhBoyTAjLQl8fPG0M0ANk3wVy/nPHzp+XvMOUfzw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=OnGsoyAfOQ7q/n7mqG9mzJXdU4XsQd95XKN2Kv4Ivw4trNZYUpdPYateTEujSHZghWgV9JxwIsC2k9UM54mEzcRyihFPj0YTFJeC5LrTdSoasz2TxaSs9I0ezoQ19kr7/zq4q1qypO7HFwpEUMnc/dz1Hsgbe/4bDt9yM+vE6bU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cb779eb9896c884a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFZhVLWWqGp1GASt3GeGFX2RGyVy+MDrrmRv5Txe0Wv1YaO1RX+YJpj0plVja9xIgbLp6TxZCu0MEAFPE2rTYnCHk1/tzE9S4dKm8SF/ke903Y0wsaMWJ9xkHqRW8HX4GYuh0S89LBRCHE8gYlgZS7DUy8auP68Edu4FF31J8+4HQXplJTz583pba3HGN8N2CQuvEbeV+wwNQYAjT7hFWTEDlZ9VJeWnOtBFUF594XmHJsCEdPUSqMaRCzCg8EioiGflDqj8zpiOdpmo35P0a8JTUoIBpy+OOd0DnTNj8P4Qn1B/jSgsIHAJDldJg3W6jOFdsGEZTmPomFF2uMiJIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=hUdHQOyBn3eQooNRjwVdJl/aL8MODr7D0lSzpq+S6nbYM3v5Fsm8J1NTjgxq3/k44yFVvOf2zHmpGycNQpWNc8CWzv+Zr9Kf8lg5JV/jhyG1QJ6ndgUDM4hCoXbMq5O++5O6Uc+BGOdC8leCI5gGNUJv6dh6+UCAeEiTakS1vrZRMWwSbs3XrXPdNQJzAutIL2sO34wyrNaHLbgyTX8Lk3/DoEnP37qwPV6JcWMX/Q2uGkeROdeSvAfu2ZInUw4jYJmQYPJ1BYuB55mS9NZCWweegqBxlLIEoQd8HHILEoM3qMd4QJPFtynlFvWyifAq1vDmni0Z9SYhspq+36KBdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PW6L+UHr0I4Egz+Ef+UDCrUa3rCGJEm+zZMjtcVPBw=; b=OnGsoyAfOQ7q/n7mqG9mzJXdU4XsQd95XKN2Kv4Ivw4trNZYUpdPYateTEujSHZghWgV9JxwIsC2k9UM54mEzcRyihFPj0YTFJeC5LrTdSoasz2TxaSs9I0ezoQ19kr7/zq4q1qypO7HFwpEUMnc/dz1Hsgbe/4bDt9yM+vE6bU= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules Thread-Index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0nrOiAgAAAuoA= Date: Fri, 20 May 2022 09:59:03 +0000 Message-ID: <185A2E52-AE50-4914-BCED-3E0831EF3A8E@arm.com> References: <8a8ffce11591efb284c93214b77534fa4e4134b2.1650976647.git.bertrand.marquis@arm.com> <69ec386c-6d2b-635a-0d8a-b72afe09f579@xen.org> In-Reply-To: <69ec386c-6d2b-635a-0d8a-b72afe09f579@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c0c86be3-c5e4-40e0-9dde-08da3a476443 x-ms-traffictypediagnostic: DB8PR08MB4203:EE_|DBAEUR03FT014:EE_|AM6PR08MB4408:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Bf/qQnKOPANz/wALAySf0NGNXhQcbER3I9XquZVduRjzbJ7P8M9YLVWSSjZKBt6oHfkbFtNGMbn8dwlGfvBVMEyaSCTb+WAgAv7U1lIe6b9V1IaZ917LQSQRUhDLSJOHkllJeb96joFxTSK1mfLMsraVyoKUrzd776OGgTT2yc6FN8hleI45oraNxNqSdeu3mEw7kURQLTXhEPRc0smlA+olmxtTv3hUVhnJv0WvWGovhbvzS0AAm6x5MvD5E9XXHlxKQUUDVTnri8dRwuD9mfBk+2BBANf3lNo0T20huhXIDoJ6f1VKCK/j67ha36W71u6QTZIfrb/768zy9iOi+WrBTJbX4YKNdu5Vm//SK5ox9m0kG84RrBcggdgsBzJX733M8sh3yDAVViwyICHeDie01kiHPBnzVDNUEJ6uWDocm5D6u7GZPx+yqIOazEiPneG00droVLYB3TQmeOAkN6UYJ4cZbiSVLlcyuyBkm9SLTIvKjQazyc88On8mrAJb9lG3szjflLedHnGJI/eW5awUq8v9FFYAbZ9OgIVmP9HUcSE4Ayw8ySSc7v1frGHTkdnJKroNvsTLgCBpV45lOk/U56QpfTiWPg0HRZyEyHHkEJ7ZCf3H9P9jbYekcYdrnDrp6NM4QAaEgICPr9h5N/KB7sIvhrKBhbKhdExeMJVpQPotlwEidSCGziwLVZigFwt0+9Yom7cp8m/qK7OqPHtN87X53kPfKA5VHajKqWiBxArC0ssT3idInepNLNXo X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(508600001)(316002)(38100700002)(5660300002)(71200400001)(86362001)(6486002)(54906003)(6916009)(4744005)(2906002)(8936002)(76116006)(66476007)(66556008)(6506007)(53546011)(91956017)(64756008)(66446008)(8676002)(2616005)(33656002)(186003)(83380400001)(66946007)(122000001)(6512007)(26005)(36756003)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4203 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8e1c5ff-7af6-425f-b739-08da3a475eec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wu3+d7ISfK6ebUmQyVNLr4N5IFLmveUS5CBxFDWaxgenFJrtrDtmp+l291p3cJ9JqHGanLzQ6Gh1LKiWz62d/5EMrhv3h0OLKz3cRdvwMyqk9guqOeuCt84uYuiSb/5YbpuKIdghJnVmA4p55M/eXWyaCwLty3Wr4JiiysxHQuwrJbHbqDO4ilvGqvy1L0EUeT6WYcrgwkPG5x2izAvf+mTO42RM8SYarwMCQmXHnXrGoo4VKgBZG+XHR4bRQF7tAJ+qf90jQn2i6AkJA8RGANShI0ks45wa7tpQ52IjNSlV8EfaBpJr0tCQUi1IBeqqgLocVlRh6Xv/c8DyPV75J2pBXDq44W+lA6cr0MBiSeP606qpvidV+Ly9uJ3xZSBS6LA0NLbrVrdOJbJcqTsKukboQgMw8ahix/CT5fK7eqaokNvjhNSxEEqB64NZhvzI4bJYEL5aLzTGQ1iMCMdtGFnC4lFDZdJCNirJ5jerKeoKO7hE5vja4CD6kFO4p82kqt9onWce0zFQP3auuzL77+C2GI1qTcXbH2EoGlSh8+2IQTg74t0yg1gFfGxBlkbjepaEKXjWr3mYJTrqZp/KrwEf0Jd5YsshvR+KojUSrGpDOfTRW0RmlXzkNiAinqgPruSJZ6HaqX/dWNw3PRt0MsKOjJa4oMxBw76bcvVaxtVjdO6bRBnIcoMr2yoW15kq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6506007)(8676002)(2616005)(6862004)(70206006)(53546011)(33656002)(82310400005)(6512007)(26005)(36756003)(83380400001)(4326008)(70586007)(36860700001)(47076005)(40460700003)(336012)(186003)(5660300002)(356005)(81166007)(316002)(86362001)(508600001)(2906002)(8936002)(6486002)(4744005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 09:59:12.5432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0c86be3-c5e4-40e0-9dde-08da3a476443 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4408 Hi Julien, > On 20 May 2022, at 10:56, Julien Grall wrote: >=20 > Hi Bertrand, >=20 > Since this patch has been committed, I get the following message for on e= very build (make -C xen): >=20 > which: no cppcheck in ([...]) > /bin/sh: cppcheck: command not found >=20 > I wasn't expecting the build system to check every time. I think... >=20 > On 26/04/2022 13:38, Bertrand Marquis wrote: >> +cppcheck-version: >> +ifeq ($(shell which $(CPPCHECK)),) >=20 > ... this is because ifeq is similar to pre-preprocessing. So it always ge= t executed. >=20 > So far, the message is harmlesss (I can continue to build) but I think th= e check should really only happen when the target cppcheck-version is execu= ted. So can you have a look to rework the rule? Sure I will push something to fix that. Thanks for the notice Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall >=20 From xen-devel-bounces@lists.xenproject.org Fri May 20 10:09:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:09:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333664.557526 (Exim 4.92) (envelope-from ) id 1nrzZD-00058m-Oj; Fri, 20 May 2022 10:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333664.557526; Fri, 20 May 2022 10:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzZD-00058f-LA; Fri, 20 May 2022 10:09:07 +0000 Received: by outflank-mailman (input) for mailman id 333664; Fri, 20 May 2022 10:09:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzZD-00058Z-1q for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:09:07 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e07c3caf-d824-11ec-837e-e5687231ffcc; Fri, 20 May 2022 12:09:05 +0200 (CEST) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:08:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM5PR03MB2683.namprd03.prod.outlook.com (2603:10b6:3:47::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 10:08:55 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:08:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e07c3caf-d824-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653041345; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=WO2E8EcvMfDZUQgtm7mMap8OWmSklnmVr4sI4Hn8z0I=; b=HmXzxEbpC8gWNCrEa6+asLlucgEGX259FxjgrIHNfS33fnSVcK/YHHY3 KZNkfYs8Zih3VuOwFjyyKyttMUJJS+dIjuZg518NHNDMzGspjlwto7f2r 0Hf4S5LB5nocTQ679/YmVo+B9tTut8ea4OmziHyrpQcifwAfCCrVg15z2 M=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 71635313 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VqugJ6megKO59LiYI0xdtrzo5gxDJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIaC2nSOvbcY2ehfo1xYI638UpS6sPcn4c1TFA9rS09HiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWlLV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYRDsNG6/MifUhCyZRLTBSbaMB2r7+Pi3q2SCT5xWun3rE5dxLVRhzEahGv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXupkBg2hYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8QzO+PFuuAA/yiRX7b+1Hf3/XubXeucMkhuFh 2vY7ljQV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdx+lpH+JuDYMVtwWFPc1gCmW0bbd6QudAmkCTxZCZcYguctwQiYlv neWm/v5CDopt6eaIVqf67HSqzqxMCoUKGYqZCkYQA9D6N7myKkwgwzOSJB/EaezptzzBTz0h TuNqUADa647iMcK0+C3+A7Bijf1/5zRFFdquUPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytaVUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:nijMOKCkw+qba5HlHeglsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl4J6T33KQwVlUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZpzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDl1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9kfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ1yHtycegB2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB26ffueChPaHbzYfJt3SU7lmtrQ3Igfwt2MVdgh8KYS8a 6xJW+w81RCNn7TNQ== X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="71635313" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUzew5PX5agHCXGiTyW/Rdn7A3p7GmypdFnAnLc/Cw7b111ardGk40pUKiviGpR3PrdM33aUrPZ5hSTq1ARROcCM3/glUCbKx1JwomVtny2yAw/ef0pQ+6AbN37Meeqn261z5dKQEj5oSfKWHlEhrr2oXZBCOrdggr0MvjaaqvBONGxqsDTLZu0jVU+M38QLKIU/4IoaJX9LKz7/6KevDJQbcsGM6/9CI/sNK7/RBufatUl9LIp1Mkx1C4iVwgTFvjBLnVnTzqKwKnmdOLjUZ5CsG3FiZCeQ18F2YPEZrPvKCJj3aYR61eg/j55KLMO7IRXAgANvAXZevKnF2VhC7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mzj7IhHVUpLPt/v/QrMEDI1JbRah5YZACjpeB9K8ovM=; b=BwdrrqKPtgZ3fwee8CwwGebpVcg6McDGx5u5tltz5rGSV0Kyr5iFe5nQ5WObaV7JgO54gaFtrELap3kRT50WQt5I27kfkS8GVkqqo37W8AP5cV1Qv8QfPXJpLa0shqBgk3+Ppn52oWQd2GZvDkP3wyHm5FW6AZ+3JHkhTvxKMcIptB9ekpUyzIBIR2CJVMxrUbTS9mMI/eTfhmX/bIXNhj/hQsXqChysQMBp46MNWZBiGKy27CvUM5UigiGomet6LveBfcfG2ngNxOCnnJLLTQdafGBGwBl5Ep4YbCkZp593WKtL44OiO0xGZuRTt3H8RFVa93aVAjsJu4Yp6XTyBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mzj7IhHVUpLPt/v/QrMEDI1JbRah5YZACjpeB9K8ovM=; b=wJL9MyGW2zc+g3KTerpqG4jpG+5nFSMVez6CIK8w6M8qhyYlGGBgRYMcO5yYny3/1y8TW0jtrVIDxoiQd8LmEPm32BLcxxuf2Ylytxb9ohMu4attR4JEtuMX4vR3cvGOS2f9bqvHz50KZC9jfUFQVA0P9BwhUFH0UvEPKxO42Mw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:08:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper , Jan Beulich Cc: "xen-devel@lists.xenproject.org" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit Message-ID: References: <20220517132130.38185-1-roger.pau@citrix.com> <20220517132130.38185-3-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0173.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f7ca32f-d5a9-4100-b022-08da3a48bf7b X-MS-TrafficTypeDiagnostic: DM5PR03MB2683:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QMT8ASGwFW+E4B6oiVvM5d+h0w4ZSJmuhN7iw0pa8LLIIWC0O34Q1NsLLrxsk2ZeukvLFNl9qDOsYK21/O2Kv7Xf13iFpjbkIEKL5s2zXdcQIFpk/2wynnzWLogDQTsETKvBjdl1o590RK5ufqVPqhVJCD+tnv3PGyg7QUwfw68daZAB2BQipcIZuGyAPpjhK2rnhgJeCTwAPkE/VUAzqBWhTHx8drYjJNKMc95s7JNephy5j4IG9fiN2CydIFInKWQV83MJrJf2uuLRlpIaMu9IvvwoG25p3IEtnsZ80STB4Clfyb7CLv84YaM/anp5zzXTS9W6TfccZov7OGb4bMQpfZg23dFTG3Dbwi0IjQJHjReimOn3LXKdEIjjpKaNWDYVPPNLceaUT77hNmwlqGuBHg6QRRsE/Zst2XP+3f/WAkaSpCUfrpEzqt91/x+rNiU6pwiW3eUADDVnDNa09NiUYHwjeof8IfH4UzS21ZT6qx77xByZrC3TUqpjZ8MsFl7/gpx7jrff6s2jWH+lYVqEdPemRa/+fpTJfYWQUNEYIF95YVwXde5FL4FxW2/dCEqBOiMaoXKDjhe99SZSaWTRvZH3HIqrrtZKVJbRPnoFVQzrpmfjiUevaCU2W91EQDnvWupMBhijEL5im+McUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(33716001)(83380400001)(2906002)(6666004)(186003)(26005)(9686003)(6512007)(6506007)(53546011)(38100700002)(4326008)(82960400001)(8676002)(66556008)(66476007)(85182001)(86362001)(110136005)(54906003)(316002)(8936002)(508600001)(5660300002)(66946007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEhXQk56bXdBYXRrblpKdHdvUkxpeDhSRk5BUGd3NEZscTNESGlIaG9jWnA5?= =?utf-8?B?MERta0dXd2JNdmljZTc2UWFiOURRQldZZ3FaWDFHT0FJVm1RUWpoWUVIZjEz?= =?utf-8?B?SHhNWXBiS1RZRHpxNjB6WDdMTm1BSjlNRkdISFBkRzB0RjJYZXRlTDdRZjZn?= =?utf-8?B?V2s2MjBlejJNZHF3T0dFZHpULzUxTlA4dWVUK3JqaGszUWFhNmZvT0UvNDJw?= =?utf-8?B?b1QwbUNVanBKT1lpVzdXamNTSVRRTFZ4bXdiU2cyZE1yT3ZoVVpFQ2h6NnYx?= =?utf-8?B?NVFLVkVwSHUwTFgwa2VLMGxsKzdqa2lySHZTcTM4TStGWUlFVkp5Vm11bEVG?= =?utf-8?B?UW5ndDhsSCsyY2E5NEp1WWpqQmYxbFBlNmlqOWZHTE5hZkswdG8xOGFNcUM3?= =?utf-8?B?SGp0N0p4cVN1clBzUVI3QUlzc09lZFhlUUJITzNrTUo1Y0dvWHpxeG5vQkto?= =?utf-8?B?NjdnNDhRUXR0cE03Y2wrcmVrOUlxUTRjSHBzc0JaZXVnbS9YK0ZYVHB4TW5W?= =?utf-8?B?UW9LQnN6cWcxMVBmZ0FYc3pNMmYwRzB2UGdpZFBCMGRCbWh6Q25HdnluUldN?= =?utf-8?B?QW1lYXp3MmdFWEJMazdVZkNYcDg1MmZvTFpJS2IvUmhITFd1QzVUblU2TWpy?= =?utf-8?B?WUhQRmZ6YkpkdVVUU3hGQkNYOUdmeXZlMVI2YXpuQVhWSWExUFVTWW5BcVFl?= =?utf-8?B?WU0zLzIydUNENTlDb0FEVkE5ajlqRlBIUitBMmorZ1pZY0tEckFZdHVJVEQ2?= =?utf-8?B?RzczNi84TXRYQ1hqV3A1Umd5Zm45K3RLM3V2NGRZczFGSklEVG5lQzBFaGV1?= =?utf-8?B?LzZDMkRXWXVkeGpSTENLQXBZZHozVUphVUNhY2dqbXN3YjQrc3RGL09SZEVs?= =?utf-8?B?dkdXNXBBV3pNTWUrbVBVaElFNTNoNm9rM3JCTmljVTZ1NXhsc0tyMU83eGhV?= =?utf-8?B?NG94eGwxTHI0R2xsZTVOdUtpQS9YNjdyQTVjQnhjSk1Zd1dEbWg5Smp4OWti?= =?utf-8?B?Q0JJRTBUaU9YVFNxOFFuSHFrUFpNc2E5SS9vY3RWZHVUalFTcVE4cG42cktX?= =?utf-8?B?Ni9yZVJFY0pQU3VTMVFhRElIT2VxSkxLa0VGNldjQ1crUU4zWXpudU5EWExI?= =?utf-8?B?anNXVGtJTndTS1M2bXFtdWhsRlZlalB6QURZOXI3bnBOcEVCSEJnZW1pSFlF?= =?utf-8?B?aXdxOGpmejY2eXFiUjEwa1ZtTzdCc1haWk9DMFZWc3o2S2YyeWhSV3M5cllt?= =?utf-8?B?Z1dkMXJCRlBuTlVPYngvM21WRTQwQm0yV1JuaXpZTm53dmcwN0lobFhLcUtu?= =?utf-8?B?OWlKZ3MyM25DUmNTZ2psNU9aT2huWTdmc1pHNUswbE5EbysxR3Q2MTVCdk1G?= =?utf-8?B?eG44Zkl4S1p6b3Ywd2Y0eHB4Y1RxMjNNZndSSDRvRFZnVXpXZEtJMHVJOWcr?= =?utf-8?B?WU91eGUzdHBTZEJtYzBOeE12WmxQeWNuYXA4cXFDc09OZW1LMWZkUFBHQjNh?= =?utf-8?B?bzZUeDE1VUtlc0UrZXZaNkJOZXhUUlJmeTFlWFhvc1lXY1czeENHSWJZczRv?= =?utf-8?B?cng2U01sY09BRXpoQ3p2UlJ6MXFQcVNtQXVWL0hiZUZnUEZRbS91YUVscFo3?= =?utf-8?B?QkQ2MkxaMFZMbjM3ZDA2NldRdzZvakhoajBDTVdnMlpGS2FPa2hVL2FGcFZK?= =?utf-8?B?Z3R4TmtrVnlIakIwUGo2VHZBMkJ6L042QSsvZzVoRlYzWUFxalJQYk94MmlG?= =?utf-8?B?ZFRlZE43dHZWUUt6eVRNVlZ4U2YyeW5zRjJlUUNSRjRMUDF5NktiZ0ozdkJv?= =?utf-8?B?VDJDOW52RDNGSmxMU3hWSDVJRXhzaExUTjU3d3JFaVJTS0NzTUFSWlh5TTA0?= =?utf-8?B?RGFLSVY3NFBmS2ovNWQ2YzZhYnpRcTgrakhlZTJTb2dWU2k0QjN6ZVMvbGpk?= =?utf-8?B?WCttd0ljU2hGcnEySTZ6VUNCMUVMZXo2RmdZSXBXcXlDYW5pK1BHSk1ZeUlD?= =?utf-8?B?SzVRSU1pbGdXSDJJZnRtYktIdXdURWdBeTdzWlVBRSswSG5QWXVna0l6aU1s?= =?utf-8?B?NkdQWlNieDdueWZTZkdTSm8yOUIwa1B4UUh5Vnp2VGRhbklSVHF1U1l4UGtK?= =?utf-8?B?SEtKSks4L01BaXlDTlJZVlJ2aFNGcjhJemJ5Zk9mVVFiQXVwaC84Rko0Tmls?= =?utf-8?B?YTdqeU1aUjZNZm5EMTZ4cXdDVjNZSzFNTnozT2p5K0ZFK1lVczF2NE5ucU1j?= =?utf-8?B?Zk9MYllEalJFMGpTZzQ0bW5yRzl3R25jZ3F1UldRV3BKN3NTaXRZcHBidm9V?= =?utf-8?B?aEUwbjJZOTQ3L0pqRVhTRzlJaUhvMGs1U08xbFIxZFV1ME14eU9Edz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f7ca32f-d5a9-4100-b022-08da3a48bf7b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:08:55.2831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /czrFPVK2KekcZt1TSjQfuUMo4aJ53+UCJfix/EK7HzXQVlyrxoZUufTQkfooXEZlsp/H/7vI/2XZX8y+qBUqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2683 On Thu, May 19, 2022 at 04:45:20PM +0200, Roger Pau Monné wrote: > On Thu, May 19, 2022 at 12:10:24AM +0000, Andrew Cooper wrote: > > On 17/05/2022 14:21, Roger Pau Monne wrote: > > > @@ -1333,6 +1338,19 @@ static int construct_vmcs(struct vcpu *v) > > > rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, > > > VMX_MSR_GUEST_LOADONLY); > > > > > > + if ( cpu_has_vmx_notify_vm_exiting && vm_notify_window >= 0 ) > > > + { > > > + __vmwrite(NOTIFY_WINDOW, vm_notify_window); > > > + /* > > > + * Disable #AC and #DB interception: by using VM Notify Xen is > > > + * guaranteed to get a VM exit even if the guest manages to lock the > > > + * CPU. > > > + */ > > > + v->arch.hvm.vmx.exception_bitmap &= ~((1U << TRAP_debug) | > > > + (1U << TRAP_alignment_check)); > > > + vmx_update_exception_bitmap(v); > > > > IIRC, it's not quite this easy.  There are conditions, e.g. attaching > > gdbsx, where #DB interception wants turning on/off dynamically, and the > > logic got simplified to nothing following XSA-156, so will need > > reintroducing. > > > > AMD Milan (Zen3) actually has NoNestedDataBp in CPUID.80000021.eax[0] > > which allows us to not intercept #DB, so perhaps that might offer an > > easier way of adjusting the interception logic.  (Or maybe not.  I can't > > remember). > > OK, will look into it. So after taking a look, I think we need to modify vmx_update_debug_state() so it's: void vmx_update_debug_state(struct vcpu *v) { unsigned int mask = 1u << TRAP_int3; if ( v->arch.hvm.vmx.secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING ) /* * Only allow toggling TRAP_debug if notify VM exit is enabled, as * unconditionally setting TRAP_debug is part of the XSA-156 fix. */ mask |= 1u << TRAP_debug; if ( v->arch.hvm.debug_state_latch ) v->arch.hvm.vmx.exception_bitmap |= mask; else v->arch.hvm.vmx.exception_bitmap &= ~mask; [...] I'm however confused by the usage of cpu_has_monitor_trap_flag previous to XSA-156, which was: void vmx_update_debug_state(struct vcpu *v) { unsigned long mask; mask = 1u << TRAP_int3; if ( !cpu_has_monitor_trap_flag ) mask |= 1u << TRAP_debug; Was it fine to not set TRAP_debug only if cpu_has_monitor_trap_flag is supported by the CPU? (even if not currently set on secondary_exec_control)? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:20:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333673.557537 (Exim 4.92) (envelope-from ) id 1nrzk8-0007NV-Q6; Fri, 20 May 2022 10:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333673.557537; Fri, 20 May 2022 10:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzk8-0007NO-L9; Fri, 20 May 2022 10:20:24 +0000 Received: by outflank-mailman (input) for mailman id 333673; Fri, 20 May 2022 10:20:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzk7-0007ND-41; Fri, 20 May 2022 10:20:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzk7-0003ku-0d; Fri, 20 May 2022 10:20:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzk6-0007MQ-Aw; Fri, 20 May 2022 10:20:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrzk6-0003kE-AS; Fri, 20 May 2022 10:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=svHdw8+Hc3kKzFKzP869EEDjzwIs8nlAMsLMmitapbw=; b=LTf55ektiAmoKFONFGJH+ZJc/A 6J7NMzcicfQJyf0xE5sDxEz08wI/3QGWFZ0sdMvQLwZ9I7v1/Js4sGi2MmUvyT/9WKJ643THvwBjl rEi3ehFD55DY4d8IcZIo6DegQ3SxoFfLcGd1j9BA0mwvNDk33Gm4MFyJWF7tt5F92ILo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170586: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-saverestore.2:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=43aa3f6e72d340a85d3943b86350f6196a87289c X-Osstest-Versions-That: xen=43aa3f6e72d340a85d3943b86350f6196a87289c From: osstest service owner Date: Fri, 20 May 2022 10:20:22 +0000 flight 170586 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170586/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-amd64 17 guest-saverestore.2 fail in 170563 pass in 170586 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 170563 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170563 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170563 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170563 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170563 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170563 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170563 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170563 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170563 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170563 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170563 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170563 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170563 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 43aa3f6e72d340a85d3943b86350f6196a87289c baseline version: xen 43aa3f6e72d340a85d3943b86350f6196a87289c Last test of basis 170586 2022-05-20 01:51:50 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:23:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333684.557548 (Exim 4.92) (envelope-from ) id 1nrzmv-00083X-Ds; Fri, 20 May 2022 10:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333684.557548; Fri, 20 May 2022 10:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzmv-00083Q-9h; Fri, 20 May 2022 10:23:17 +0000 Received: by outflank-mailman (input) for mailman id 333684; Fri, 20 May 2022 10:23:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzmu-00082X-38 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:23:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da277654-d826-11ec-837e-e5687231ffcc; Fri, 20 May 2022 12:23:14 +0200 (CEST) Received: from mail-bn8nam11lp2171.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:22:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB4353.namprd03.prod.outlook.com (2603:10b6:408:36::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 10:22:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:22:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da277654-d826-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653042194; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QcEmnplIxFiWVnNUSRM5zx0GUhssE5uGEVHxBoSVwHI=; b=AGwy5ckI61l/KTQlTz6uIgVhqT/VKKe1iBBm611ra8V+7N35Knfpgwge IqR04TYqv6YBg+OqxRRrJG/T6mZtc+dluwSxoYKXiPM9eBXwD7f2ril2H yw4m4vMcqPQpSFhACwde8nq31RIf2k0XOb5KdOta++rcIZaef6dgeOGLy A=; X-IronPort-RemoteIP: 104.47.58.171 X-IronPort-MID: 72175587 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pL2SKajzZxMfeOS5tQHgR5OAX161ZREKZh0ujC45NGQN5FlHY01je htvUD/UPvzZYGOgfdF2O9njph4BsJGDn4NnSQNuqXo0Higb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlrc4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQgID6j0xc5FakVJKmZdAa1N5rLhBUHq5KR/z2WeG5ft69NHKRhveKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuI8ehWhp7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wjM+vdqsze7IApZ/r63a+CWR9q2eMB13Vm2r Tmc32ncDURPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNzWgqWOAlg4RXZxXCeJSwB6J4rrZ5UCeHGdsc9JaQNkvtctzTzp60 FaMxortHWY27+TTTm+B/LCJqz/0ITISMWIJeS4DS00C/sXnp4YwyBnIS76PDZKIszE8Ihmoq xjikcT0r+xK5SLX/81XJWz6vg8= IronPort-HdrOrdr: A9a23:TgFSuqOH2hvj6cBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="72175587" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsZA7Ze47mbye8DlWugW/8fXnoAQ8B5nJRG4gIsdBCm02VfkfvY1KD1n/Ht6Z7fVd+SAtCqNNerzvRj119YyhvfkSdIvChKefQNk45xUpcXAFGdnIppxd0leYVhzzdcSCD29zcVzrSZiErmkgQWfe99ivGHisrLt/UltkDOKUI7ttZ7Kb6K/RKR5ChhHBnc/mH4BN5M5wXVNcjOnQ/533iwK08h3D8ERU/LQl4cWWRP2sZCgg7d2T5qeA7wBcBj3QOqOYPYLr553j39yuCn087y8KNaZYSsQ7ZObgaV2Bg2wwspN11wJjRjnnLzLCKyF+x/yH5yI8HS8epI5rN+DyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eOF31MhYg89v7WzK1ZURVJVvLicKiIw52Bpp2bDuph0=; b=HvTdhg6HHacRsNKdKSUQHSVWjwB+uLlR8XPfIdY4ShoyhYxHfAJ7H1BAdZSZNaGixQnYUn1QV4KPEGdZ3DR5NKEaGERMniqql6AmtLOh+MSI/9VcnOoC0VC4s6bizxdKrrff0U+tIZ8AKN98dSV4tIkZQpxYuPPLPMqsGxbGGfuxduHxQDOwM4ahsWWaEor+BWfSvEmJmE3jeQEpmA8gCsznDqze26lwSNVr2oJft9jlIjhFgZ0fU2sRjPaHzVIlyIgdAXQeU3/Vs7xU7m4XFuo1t0Vgq5aEcQ5SD6pds3tftoG1bSu+WWcDNShjvCcB76QPhKsVDhyWf/VQXaBmKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eOF31MhYg89v7WzK1ZURVJVvLicKiIw52Bpp2bDuph0=; b=afMiyYqZWFJYcFvrBZm7DMygKgs5QYcHI6dZWE0p4yx2JvlPqfKowVHtoT8V6v27EC6kxTJTXcqmC3UJcfLJcDPWLX89tgFdWCe1nY0Kn69ssadTfdx3duz/U8bal2iWd10cRE8vw1oaRilbagXI/pzZaBOxAkThhMvjAubMZV0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:22:49 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables Message-ID: References: <80487976-5d72-5388-139c-422210bca73b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <80487976-5d72-5388-139c-422210bca73b@suse.com> X-ClientProxiedBy: LNXP123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9c73c81-4c17-48a7-c956-08da3a4ab302 X-MS-TrafficTypeDiagnostic: BN7PR03MB4353:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QdeoWrv+8DXZscdkIqeBpE7wDaU5f9zu6yFTvOWnQHqFe67ahNNFy4QPoIsO8m6wolC1vY4I2zFQ2ZC3Lcxm8ioUXL5ovY4nNdPRz0xYi3GFGYXGpWMkPBXB6b3CFzNEmbfPMkUR9ngXDIYfsQNagXsGzETqqHcgXaA+1xXJO4xIF1/5X9H04oywtiG7sNuY4yzwhwpt57bjnhLM5N8MG0t4rcrZIc4YGmk66mcHTEKw7e5/rFeTzcCVgYr+Et9HdOADUZyUZ8dz/H8HQf3AGXoFA4bkjEScCe6DldUYutsuL0+sagXL5ajgfm3eTz64BD9kjTT/3vrdLuza2I73/yfMwJJsCIat+67NxmPTBUm/fsg3/fZIOnkITWZTTxvx2FSebOoer3pWg/ijyObrCcJAhPcDlJd1sSu9UQdIr22hbc2sJPmu3NRUsREPDavq+mfM5p/GZ0O3W6tgfl8oXNDsHp188PIV/mknjtBV3jWTU1Nxs5ctj4ZiYlkIufLxzK9AehkaihUREhLnFTx19zP6Syfs4r/S4eleg6dcOHLV0u2PPSBpeJAi6Ja9A9OQacW8ONreLsErQsIFt7hp+7CWVBtFvvsuQ8KE6E3CDW7VJyKNgdHVxT69EzG3blczq+PHUZnRT0S1sKVAQ9OkjQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(54906003)(6916009)(6486002)(38100700002)(508600001)(82960400001)(5660300002)(6506007)(86362001)(2906002)(6512007)(83380400001)(26005)(66556008)(66476007)(33716001)(53546011)(316002)(6666004)(4326008)(8676002)(85182001)(9686003)(186003)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGVucStLTDY4Y1dpbUxYeWxCU2N6amtnK3dDTFg3R0lacDd3aVgwNDByWVNY?= =?utf-8?B?UW1ySHJCVEg0MHVYRHNEWGI3Y250akZ6NTlZckxYTDZ4M3o3UzRVdFdSbWht?= =?utf-8?B?VXZab3oxLzNkZFlmaDdsZmc5RDJtdWNvT1BvcUwrMCtJWnBBVW4zRkdaNFQw?= =?utf-8?B?bkdGbVVNT3VHc0VnSkpIN3RFWjJaeFNCU0NtU2xwTWo3WWNmOUlBcXFQenRr?= =?utf-8?B?S2tOMTlHR0lJYjNhQ09paHowNWdFeE9zTEk2WjlneVVPTGlsL0NwWVAvWUxa?= =?utf-8?B?T3FqTENnVHY0czZPT2RPQzFwUjRyTm0wSnQ1c0llNWhuL29tR2NPWTBFNEVL?= =?utf-8?B?VUxwZXBwRWppVk81OXJCNHhHZDlPSXFZbm1kcDVtaWgzQ1B0bVdkVE5mUVFT?= =?utf-8?B?Zy85d2hwWUNSbEMyQ0tNZHpqTXJpeFlnL2VpWjNKUUFPQzdJMzhOekhtRUJ0?= =?utf-8?B?QmpXRW0xd0c3Vy9XS2RXSERoWGs1SXZ4Z2hub1hsR1U5U1VHZ05wYW51cHZm?= =?utf-8?B?N3FGdXhwTmdyMk5OcVY0V0VTRytnbnhhQzFKQUpnS3UyVmNZayt4K05ESFFv?= =?utf-8?B?MFNtVmFsWFFaTkJwaGRrR0xIQ1pkY1dqVWZqRG1nd01YcGE1b2ZodGI2MWt2?= =?utf-8?B?WWlVejdJRDFLNENzMWRIKy9XOUxta1ZseGFLT2IyL240cGUxZkgyYkFNM28r?= =?utf-8?B?RjNGbWwxSWpKQWhUbEZsR05ydHdET3VLRDZmOUZydW9pRk4zN3c5U0lJQlBi?= =?utf-8?B?bTNxUUlLQmNWdTRMQlFEZkZsa3NZSmo2Ui9VeUZnelRiaGJSTUYzMVpNN0Yz?= =?utf-8?B?S0VNdVlxd2FWMVFFN05UTVZBY0lrZzJnRmVQeWUwUVl6T1c3eXU2S3I4NktG?= =?utf-8?B?cGl3N092TlJpZWtRblVPU3JKNGt5VzFIOEluZFh2cXdGU2kzK2t3aG94a3Rl?= =?utf-8?B?RGlkNFhZZFVOWG1HVDJ2SEw3WjBRUHJZRmFxUHdTaG9JZmh3OVlhY1d3a3hx?= =?utf-8?B?TGRmeFUrZDR0R1JHR0owdlFhYXpSM3RRUUFWM3pSLzh4cVZxaDZCT3BtaWx0?= =?utf-8?B?ZzgvNjhObFhGYTFJV3NBeWIxY0JITFB2dVVrUFZXa2I2V3g1TkkyTjh4cU5T?= =?utf-8?B?OEQ0YUNhM0MwenM2OEZVTTdGWVFib0dmbzB2cEVuMXhENEJpaXJhMlZVdU9p?= =?utf-8?B?NWo0MWN1VFJnQ0ZnYm94eU1FbC94THNBWVFYZ2NtRUlDZGp5MHdJNnZoYlNL?= =?utf-8?B?eFZMbFZleFZYR05IdVdPdzVtQnIyb1o5V1RGcGhXNXc5U3VoNW5GQ1hIUGln?= =?utf-8?B?WXN0YlZDbVE4S0FIanVZUmYycStvT2FyUmtvWmdOTFFMcHU1bE5ocVNEZHoz?= =?utf-8?B?Q0hLaVdJZ3dsRjhxM29RbjVhaGlPOGM1QlJSSjBVYnF1d29pWTB4Z3ovL3N6?= =?utf-8?B?SG1hQTBiSHpXaVJ6aTdiZlo3clFaNUVXTlltNk45b0MxdTJSTXhidit4eG1D?= =?utf-8?B?NnBYeXBJRFVPQmRSWSs1QS9TV1EwWkZBai8yaVpSemdFcWZ6aFQ2WWY5VVVX?= =?utf-8?B?d0JYRGlSeHFKNjQrNTJUNXFwaDBMb0toOWQ5OWV4YWowdGtVVWl5ZEFEbm9r?= =?utf-8?B?Q2lKMGdxeW1QT25tblpTWkpJTTJzejcrSXRMQUFEYk1xN3VtUVVGaGhnSkJK?= =?utf-8?B?Nm03REZsc1l0NmxWTS9kUm93Y2M1ZXFVVTlOZ1UybzQ5OXV3d3pIcFBpY2NG?= =?utf-8?B?R0dZbjJ2Z0dSRTdNRnh5aWRWQUYyYlZrOGRaVGVMU2dTc3VtZWxBUkZOT2g0?= =?utf-8?B?QzhNL3h5VHYwMkZDZGliczFBeFlIWFhMVWVXN3Bhbk9aMU5uQnRlczRtdk9p?= =?utf-8?B?WmtDRWJiTXZwTXBGTjk1ZTBJNit3TlRkQWVBYURPUEliOEl5QmNHMWo0ZVFB?= =?utf-8?B?OWNiMm5odlBGSVNFMTVFd1ppRHBtOXM3Wm1meTBTamd6ejFVM1JOT2tpZEpp?= =?utf-8?B?elZCTFhZUVkwMmVVNHd4K2Nxd3VXR1phSjMrbWIxVk5OVmJEVW14SnFidG5t?= =?utf-8?B?a09ESFJQU0VVUFJTc3pHVWJFTk9lcENCdE0yeENDeGZLRzFDR0V2V3lpMnk0?= =?utf-8?B?Z3FMR2VTbXgreldCa29ZeFN1SUl2TFRaSG1TYm4yaTU2b2k5YlFzNXVRT1Ft?= =?utf-8?B?VDJrWjV4cE5GNXFjczcvbWNiaDFmNTNwamJQVksrOTdPQ2RuMzNRenpXMGpy?= =?utf-8?B?S0NzcjY0Q2dreHdxU1UrdGhpdGFpVnUzZHdXbW10WUFrL01MWER6bGdxRkQv?= =?utf-8?B?aUNtR0ZGSi9EdDRyMzFSanRLWU9YRVJ3M1lIci9Od1AyV2h5NkZXTFY3ZHgv?= =?utf-8?Q?RtE08+KMOSZrnCqw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9c73c81-4c17-48a7-c956-08da3a4ab302 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:22:53.3359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j5iuYXRQBFBMhT8VVuiFvvzofcsDaLJW/Pep5qwSFScy6aLNxNykLRk4Nnwn5W/C4ddiiYU8ag2OZAjQvdKMKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB4353 On Wed, May 18, 2022 at 12:06:29PM +0200, Jan Beulich wrote: > On 06.05.2022 15:25, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: > >> --- /dev/null > >> +++ b/xen/arch/x86/include/asm/pt-contig-markers.h > >> @@ -0,0 +1,105 @@ > >> +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H > >> +#define __ASM_X86_PT_CONTIG_MARKERS_H > >> + > >> +/* > >> + * Short of having function templates in C, the function defined below is > >> + * intended to be used by multiple parties interested in recording the > >> + * degree of contiguity in mappings by a single page table. > >> + * > >> + * Scheme: Every entry records the order of contiguous successive entries, > >> + * up to the maximum order covered by that entry (which is the number of > >> + * clear low bits in its index, with entry 0 being the exception using > >> + * the base-2 logarithm of the number of entries in a single page table). > >> + * While a few entries need touching upon update, knowing whether the > >> + * table is fully contiguous (and can hence be replaced by a higher level > >> + * leaf entry) is then possible by simply looking at entry 0's marker. > >> + * > >> + * Prereqs: > >> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 > >> + * contiguous bits (ignored by hardware), before including this file, > >> + * - page tables to be passed here need to be initialized with correct > >> + * markers. > > > > Not sure it's very relevant, but might we worth adding that: > > > > - Null entries must have the PTE zeroed except for the CONTIG_MASK > > region in order to be considered as inactive. > > NP, I've added an item along these lines. > > >> +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, > >> + unsigned int level, enum PTE_kind kind) > >> +{ > >> + unsigned int b, i = idx; > >> + unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT; > >> + > >> + ASSERT(idx < CONTIG_NR); > >> + ASSERT(!(pt[idx] & CONTIG_MASK)); > >> + > >> + /* Step 1: Reduce markers in lower numbered entries. */ > >> + while ( i ) > >> + { > >> + b = find_first_set_bit(i); > >> + i &= ~(1U << b); > >> + if ( GET_MARKER(pt[i]) > b ) > >> + SET_MARKER(pt[i], b); > > > > Can't you exit early when you find an entry that already has the > > to-be-set contiguous marker <= b, as lower numbered entries will then > > also be <= b'? > > > > Ie: > > > > if ( GET_MARKER(pt[i]) <= b ) > > break; > > else > > SET_MARKER(pt[i], b); > > Almost - I think it would need to be > > if ( GET_MARKER(pt[i]) < b ) > break; > if ( GET_MARKER(pt[i]) > b ) > SET_MARKER(pt[i], b); I guess I'm slightly confused, but if marker at i is <= b, then all following markers will also be <=, and hence could be skipped? Not sure why we need to keep iterating if GET_MARKER(pt[i]) == b. FWIW, you could even do: if ( GET_MARKER(pt[i]) <= b ) break; SET_MARKER(pt[i], b); Which would keep the conditionals to 1 like it currently is. > > or, accepting redundant updates, > > if ( GET_MARKER(pt[i]) < b ) > break; > SET_MARKER(pt[i], b); > > . Neither the redundant updates nor the extra (easily mis-predicted) > conditional looked very appealing to me, but I guess I could change > this if you are convinced that's better than continuing a loop with > at most 9 (typically less) iterations. Well, I think I at least partly understood the logic. Not sure whether it's worth adding the conditional or just assuming that continuing the loop is going to be cheaper. Might be worth adding a comment that we choose to explicitly not add an extra conditional to check for early exit, because we assume that to be more expensive than just continuing. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:30:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333696.557559 (Exim 4.92) (envelope-from ) id 1nrzu3-000152-9R; Fri, 20 May 2022 10:30:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333696.557559; Fri, 20 May 2022 10:30:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzu3-00014v-5T; Fri, 20 May 2022 10:30:39 +0000 Received: by outflank-mailman (input) for mailman id 333696; Fri, 20 May 2022 10:30:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzu1-00014l-7F; Fri, 20 May 2022 10:30:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzu1-0003x6-4n; Fri, 20 May 2022 10:30:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzu0-0007bh-Py; Fri, 20 May 2022 10:30:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nrzu0-0008L1-PY; Fri, 20 May 2022 10:30:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jU30Ty8t/zvEetHgByJCNKSt292gY2P1OEZVwPEWQ64=; b=tpUEY4Uab6BFM1gRU3ZLdDA97t 0KGJPInJOsCJiFt38SvifHRCd0KqdyNiW7minaSsBt+yThcYU0nzcugtnhISeG1UY4DfNTqLlLHhw gTb8kA2qAEQZjzxKLICg+wYQye5X8LLFPHSXfkjfI1MzGPuRYGboJA8G8Nz0ORCyg/SQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170597: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 10:30:36 +0000 flight 170597 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170597/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 80 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1116 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 10:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333706.557570 (Exim 4.92) (envelope-from ) id 1nrzw6-0001fj-N4; Fri, 20 May 2022 10:32:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333706.557570; Fri, 20 May 2022 10:32:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzw6-0001fc-Jz; Fri, 20 May 2022 10:32:46 +0000 Received: by outflank-mailman (input) for mailman id 333706; Fri, 20 May 2022 10:32:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzw4-0001fW-6L for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:32:44 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ce7e0a0-d828-11ec-837e-e5687231ffcc; Fri, 20 May 2022 12:32:42 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 33E625C0269; Fri, 20 May 2022 06:32:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 20 May 2022 06:32:40 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 May 2022 06:32:38 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ce7e0a0-d828-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653042760; x= 1653129160; bh=TXyd2jwAtc+G9T46sH/m7OiAUHw3FJC24Trx9vtVOUM=; b=l 05wDjaojTJ2zpN48OzB4bkFR9orW/fnoLQNQch3AnJzrRQ9WdpGyyJn5H4hBmBvZ WXSFohQRwW3uYBcK8L5lcHR0G+qwYuPzQalnIDu4d+A1AzYZC/CGHKB+mzwazMRM psigInw/+257JIAq1SUuSC+Q/FQLjkW3ZwZO1I5NCahGBvLl7Im5JPKKGWc232Bf n5GXxBZagSxipdYWwJ6uq/S8f0PgWyiu6rYPfASF96OEbMSXhryl4oWbGZo7Y+xD 8L+113TMH/+IM8IkqlkmexQLENR1I8g9GlK2YDJEel7Cg0jJGvNPFdTK/ymPECuB gDpjAuIC2BdlqWySo2vQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653042760; x=1653129160; bh=TXyd2jwAtc+G9T46sH/m7OiAUHw3 FJC24Trx9vtVOUM=; b=E+l89lGaaP+6gAI5rrQjHZ+ft+zcQKDZV32ae9IgTlzr G+KR7hxKytaUXsfDkr0qeM4VyS7BtZ+RqGjbsnXcw9GG0+YoSG5nphJAJhHEGwi+ onWGKxCvCMMza+w50dMzpiWbAIYnthpec/13uZZG9e+xTWYRn7V/BMpurH5yf+Rp ZhQshLYzgtaWJ9ksH5t0lkY12hp7vnrvPndNEH0Q2lkOlFTLmxcGf5OX1KyCAWcD Kjt2f0SH0VfQO7aL5e2eaZ2ENedwfD+muvfSfjysapgoeQ2rTz4HK9GLenHpup9z wxFPIbQYPGcubbuTLW10C98rYZWrtuGkRdV8BZ2MCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 20 May 2022 12:32:35 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 2/2] ns16550: Add more device IDs for Intel LPSS UART Message-ID: References: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> <20220520085343.1835866-2-marmarek@invisiblethingslab.com> <663a03ad-9df1-173e-19b1-4f4af1aa9b37@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g4A2vc3PI9AlducC" Content-Disposition: inline In-Reply-To: <663a03ad-9df1-173e-19b1-4f4af1aa9b37@suse.com> --g4A2vc3PI9AlducC Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 20 May 2022 12:32:35 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 2/2] ns16550: Add more device IDs for Intel LPSS UART On Fri, May 20, 2022 at 11:42:37AM +0200, Jan Beulich wrote: > On 20.05.2022 10:53, Marek Marczykowski-G=C3=B3recki wrote: > > This is purely based on the spec: > > - Intel 500 Series PCH: 635218-006 > > - Intel 600 Series PCH: 691222-001, 648364-003 > >=20 > > This is tested only on TGL-LP added initially, but according to the > > spec, they should behave the same. > >=20 > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > Acked-by: Andrew Cooper >=20 > Oops? Commit 1f0b1f5cce9d. Right, I haven't fetch new master. No changes here for several iterations, so everything is fine. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --g4A2vc3PI9AlducC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmKHbkQACgkQ24/THMrX 1yzVawf+MR7Xp1jDHLPL6l4O6M7MINpcDf+sJnBMj+mkaYAi5UheRw5VHTMkBYEs HxReVlNPnQCDlUvx1hUuLOyPuPDb0FmOag5D6gNl7mlpEVV4q/mX0SznPAeC51N0 3XcDAcMUIVylvjVJRkrWnZJl6X6yibzzw8DqsgrdtHonYFLciLPeS5EMzAOKoN/a rfpa9V7ZF2l4go5WUBpyFQE6QnsuVwR9ybdyrXLa6FxwMkUUS50kUkhe+QuJEsfE SK3BxlgTTxsIFy7XdCBFUzIaK1dAxAjl5S1Xee8VHp7p4M0SSKU4eR7qFNnIzmz6 ZvmkFWztSBQDOVQlng1IsVKHJu+UBg== =BJ05 -----END PGP SIGNATURE----- --g4A2vc3PI9AlducC-- From xen-devel-bounces@lists.xenproject.org Fri May 20 10:33:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:33:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333723.557605 (Exim 4.92) (envelope-from ) id 1nrzxG-0002aG-FV; Fri, 20 May 2022 10:33:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333723.557605; Fri, 20 May 2022 10:33:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzxG-0002a9-Bn; Fri, 20 May 2022 10:33:58 +0000 Received: by outflank-mailman (input) for mailman id 333723; Fri, 20 May 2022 10:33:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzxF-0002Zk-F4 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:33:57 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58fdbbb8-d828-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 12:33:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 58AE35C0265; Fri, 20 May 2022 06:33:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 20 May 2022 06:33:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 May 2022 06:33:52 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58fdbbb8-d828-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653042834; x= 1653129234; bh=W11EzLqcSs3boOanI3c6p62+m8O8TTNeUza4fSvw0io=; b=K IUiyL4WlHdBVc/KYht4drBNHDg8gfLNQGuPLjVtnZeeOGin2w7JV7gHrc5smbJUp bl84S5cVxhsxq24BW8NMg3WWhp0R0Pd1dDSI1MGHfZFNlqLJ8kK2KDiO8aZ7LHBw xUxbFEh+73ihBnbR6AhGI2ixDxsfndn5k/P5Hi+HLiU8AGYaSMqiJcO3HPNN4AjY 8AO3HosJSIgucq8rEvjamqvpBSiUpfxllWQRu7Ia9zxakKlNADkfWnETPeW+LY1L 5mQlvI2wJJk4gGN41oBSVkR+qy95LnAZ524FF4ExxWEqi8sxob2gGDWcGl7v6SLD TUpzgygI0qSuJUvVurYMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653042834; x=1653129234; bh=W11EzLqcSs3boOanI3c6p62+m8O8 TTNeUza4fSvw0io=; b=PGHTcgB0O3byALFejWf6Jg/2qUJ+pWQBxLhee5RSfkT3 HPE53fXCIz2bXpU51mX+TtHvLAd+g4BREVFgjbmrsarq5lJ/Czxxfa8DxW2SWDiu Be3Hs9LH94OqOvHS+6bSmd0e6Pp4toeD3veyYqZojruLoI3z0vc3EdconZDwLmAY 1bmZYcG6H50C5q0RRP0fFWbw0wwEBWuq8rpL0T84vy+mFNMSp+FYjS6gpAtsipS9 7FrEMF1fQ8JmDYsLOfWkRsQS6dOow2kz51N614Zp3WpNA21bFzLSYA/IEl7LHNYO 8XWTkU0FO0CHVWjwQ5x/HRVP1Lne0BY9YKOUx2xj/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 20 May 2022 12:33:50 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff Message-ID: References: <20220520085343.1835866-1-marmarek@invisiblethingslab.com> <825cbef2-2b1c-b05f-1c4e-cace2eef099e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="heNkV7qPBJb1kdKr" Content-Disposition: inline In-Reply-To: <825cbef2-2b1c-b05f-1c4e-cace2eef099e@suse.com> --heNkV7qPBJb1kdKr Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 20 May 2022 12:33:50 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff On Fri, May 20, 2022 at 11:47:02AM +0200, Jan Beulich wrote: > On 20.05.2022 10:53, Marek Marczykowski-G=C3=B3recki wrote: > > Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared > > by the PCI Local Bus Specification Revision 3.0 (from 2004) as > > "unknown"/"no connection". Fallback to poll mode in this case. > > The 0xff handling is x86-specific, the surrounding code is guarded with > > CONFIG_X86 anyway. > >=20 > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > Reviewed-by: Roger Pau Monn=C3=A9 >=20 > Reviewed-by: Jan Beulich Thanks. > > Changes in v6: > > - wrap the check in additional CONFIG_X86, with appropriate comment >=20 > Thanks, albeit ... >=20 > > --- a/xen/drivers/char/ns16550.c > > +++ b/xen/drivers/char/ns16550.c > > @@ -1238,6 +1238,17 @@ pci_uart_config(struct ns16550 *uart, bool_t ski= p_amt, unsigned int idx) > > pci_conf_read8(PCI_SBDF(0, b, d, f), > > PCI_INTERRUPT_LINE) : 0; > > =20 > > +#ifdef CONFIG_X86 > > + /* PCI Local Bus Specification Revision 3.0 defines 0x= ff value > > + * as special only for X86 */ >=20 > ... I'll have to remember to correct the style of the comment while > committing ... >=20 > > + if ( uart->irq =3D=3D 0xff ) > > + uart->irq =3D 0; > > +#endif > > + if ( !uart->irq ) > > + printk(XENLOG_INFO > > + "ns16550: %pp no legacy IRQ, using poll mod= e\n", >=20 > ... and perhaps insert another colon after %pp here. Both fine with me, thanks! > Jan >=20 > > + &PCI_SBDF(0, b, d, f)); > > + > > return 0; > > } > > } >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --heNkV7qPBJb1kdKr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmKHbo4ACgkQ24/THMrX 1ywfVwf/boCSBqdGGsysRXii23Cj0VruqIoAHVpmFMtvb0Nw3CF4kogHKcgZG4/F jatlHAueWPykLipeGLT/uAe7o6KI976oFxkj/kK6Cg4DPYTGpG10z0vSjotD+zYn 7mfWnUlCOzkoKyKlK9qPt8reLqwFd9gPODggDWTiK9vI9udebHEAd4Tn07mb3Rc8 BhS+K39SqRlgKer2IiPfvuTA90iDsAXFAt3CaUe+wNBotr+nNomYaeurjjqpEwYE uIxt6LZdKPCJsgTsbFquX8a41FIY852V5czRla8p2U0mSM5txPQ7agIg9d8zGRXa 2baUGOurBMkmQ1nskBalimdjhpYxcA== =lxEO -----END PGP SIGNATURE----- --heNkV7qPBJb1kdKr-- From xen-devel-bounces@lists.xenproject.org Fri May 20 10:35:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:35:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333739.557636 (Exim 4.92) (envelope-from ) id 1nrzyr-0003S6-58; Fri, 20 May 2022 10:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333739.557636; Fri, 20 May 2022 10:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzyr-0003Rz-1O; Fri, 20 May 2022 10:35:37 +0000 Received: by outflank-mailman (input) for mailman id 333739; Fri, 20 May 2022 10:35:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzyp-0003Ro-1V for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:35:35 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 934b612b-d828-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 12:35:33 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:35:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB3862.namprd03.prod.outlook.com (2603:10b6:a03:6e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 10:35:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:35:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 934b612b-d828-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653042933; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=0BzexlI7fOX4t9ZUy3cgGKLdGSZbSaxgKBLtN/A2DrY=; b=AqP54Ayq4pokVYNYPnUDTbcOlbFA/vJJLFzEiANBCe8tepPDcHnyjxJh rNNrJo15WltQIJskapqrRDzxJGmFcho19gAaerG+qIu6DtZkgnCJFPhWN CbOyBeeM7FL89INDTqTYxQj0PHmCcTE6XrIgOC6K1RV4GdKuaqQNIszU8 M=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 74295254 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mfxy9KMZYpEjZuLvrR3SlsFynXyQoLVcMsEvi/4bfWQNrUpw3j0Bz jZMWz2DPK3cYDGjKNx2O4jgoRkEsZGAzYcwHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk298w27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0 49is42fWzoQPYrNyLUgCjgCDn9aMvgTkFPHCSDXXc276WTjKiGp5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB4H9afGM0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLj03CiiKWAEwL6TjbUrs2T3711c66K3MfOPcO6TZ+ROrEnN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1iPwQPJVGuw+rQSSkKzd5l/DAnBeFmIaLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:n3dgiahTF6LtCpLACeFzqGSLcHBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="74295254" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUIPDmoQKKBIJ/CJ3VhGwrCKvaNMPVd6fOGAq34UmJLcuf9f2T95U1ewKxkVO9vrHQTTq66lqwnYZcl5cva7YvdsS0OsWhyjHtyTortTioMwOx8UtguRHPkSL4l/IcaXHtCWxTGYXdnVONdmDEUG64FOIReZxJbKlY0NecjbbQ9mQmFLjF/WIopbeeFj74jxwfEplhSRhZa87tMvNjiL78PRGd7bE9CxjKf86MC+SkzAn4xdiV2n4txlOzYBF/tmPRHPRCIUhQbSL75c2NW5GKRODuYjSW//7aBC/s7ldSjz3GfWtT5vDvqcUTZPeDFpRKYsQKh5uHSwHuzIfx2RYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rofpCty6Kvkv0LUEsCfwK0/E6lctfHUDZtt+xooZ7sk=; b=NrErsk+9iLWr62m9fefmmy+6xsFlNVJNJK/lokH8VSDn0n4duxMwmwq5wUUck+pfBZYoZbcgk0geyAmoF6hdqLr5mYr63NW/7XDsymDb+8cABraSuxXPh3iDXmnN7IIo/d7O2148o5bk4dp4vopZ6BQHX+FumtzDwEZDQRfMRZHegApnr654TVVUklPkj8KR1p1gAQHpSH4tZx+dNdk7oUgKx98eqyKiOtRPU8/9LwZmx/emiD9xlthaYVqQWJACg2+lwZWwYbmUppHnjtFb4E/JZ6GZ9/kUVMv69XBilLaUzRAtokMtANtnjkBUHDrzahxhyrBXll7G7fUnV8/djg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rofpCty6Kvkv0LUEsCfwK0/E6lctfHUDZtt+xooZ7sk=; b=aP7/Og5x3sxLYOdwwb7w/V8R1EcWTERxBVQ6nnz/Vk8jb2m8j/MjpV/QAMU0fqica06i8eljNP3ekBQjEphQRuxQuoTbDt0gPBYZpYOiM4pj0qpKcrX8hQeMnsATDDwtCJSGCc+kOlzBqGJv/4utqr2fhvps/d9VzSZ1O+0Na+E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:35:20 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v4 17/21] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0081.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18747c44-9b4b-4f4b-e118-08da3a4c72cd X-MS-TrafficTypeDiagnostic: BYAPR03MB3862:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j8eCVnm1aOtJKSCbBlgY9JR7CmSNZMxDIF5TxwW4P0shppEigJU1E8dp83gSurUgyl4IXYf3cUCfyBC3xiLauhL2ISscilMal+wx51ts2Yvz61JagUB8bQ3msGcWT5GPqjP0XE28Ei9ZP7ySX0BTjvh22w3ak5L35Dekszdy3oLnJ/LbQvX2tcbyeV5RZGcageCDjmoxn5EgB3UNMP2Tbe2PrZbbOnYiGzqYJG4HHSScuwIcT7Gg9vBi3rN+TgmXgCUamdjJCmPM+vkCZGm2K//8JuWy8eBQ7Efzq6ZFsy7reP+gg1kRNEMFdmIjbqNYbXWUyCaynEI0M+WN8D6Iws8I0Coyi1f4sQKBop1ooedslyNItf8xIAKmfoZK4FCtizP9gFc/79FkANL8RZtE+HGUu1qknd4JXb6sQS5vPphiwA9FGdOyh8dw+s9NfX3CsRrIiu6p6YSancCzq7lY4i/5toJBmNajd0FI6dcDDPvePCZjFcg7PwFB77TiI/4iOl+xDG9Oxvljpm3bNRdS05xRLBErtaWEbVApCC6+hYk9Uila5Nn4OEVtFlpK/bS2qPkPJcmg+1wnFf4UbmOGsWttJ3ZWexG/KGDE5no4feeXQeHBYW5/cd0P7oa1+kVPDNUcS7jUo36fQ2cnsWSe/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(508600001)(38100700002)(85182001)(186003)(33716001)(5660300002)(2906002)(83380400001)(53546011)(316002)(66476007)(66556008)(8936002)(66946007)(6506007)(26005)(86362001)(8676002)(4326008)(6916009)(54906003)(6666004)(82960400001)(9686003)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmU2eXpNZXE1Smt2M09RaFN0QlVzUEwwRTlRWWNQaWNSclIwd1NGZHVJY3h5?= =?utf-8?B?RlNXblNuZDBoNi9CdlNzbHNkdW1nSk0xb3hWNzh3WnhUcjl2SmlpTGNDYnFx?= =?utf-8?B?bTF5azJ1MFhnVVdFL0FQN0dUMitnQ0dTRXpYcGg2S1pDdzBoRVRFdWI0eGdC?= =?utf-8?B?dnUwZENNSEV5RkFTOFcxT0dWWjYxbEwyakNGZFR4Ym9HbVZxaW94Q3dEY3Nl?= =?utf-8?B?Z0VxRk1nVGk5MEtQZnVQN0Zab2RrMjVrbldqTVhWMnFlOHE3UjB2eWxBMEZY?= =?utf-8?B?RHd6R2J4Q2hIemZGbHgxcEhONFJiTzFkeFZpSng5elV0Q0o2L0JZWFEzeXRj?= =?utf-8?B?NkZUNit0d2tKYXdTaHZiRWNRcUQ3bysvRWVKa1dOa25MdGhRdmYxVkVuUzMx?= =?utf-8?B?eE9JL2R4K1VsRExkd0drbVBZa1ZxU24zNENOcWp5Rmp6RjNVU20vNnBXbHFQ?= =?utf-8?B?ZC9KT1pwbnUvcDFCVzBtU1phSU9VRE80cEtJVS91UGVzVEJoV0NsT20yOTVY?= =?utf-8?B?OG5rY0F4RlhpaXdDVGs2WUpjUGZEOTd2UDRnd2hPZk1uUkFxZlBoVmRPZVNT?= =?utf-8?B?alUrUjgzbGxiVUlVVVdyWldHT3dEUDlPNC9SZkQ0ck5HWmZQbGcrSUxDSUMv?= =?utf-8?B?eUZkc3pvRTg4dzhiYUw0VDVYV213TVJPMkd6ZGw3amNXa3VVMHBET0x0MzRk?= =?utf-8?B?cTlsVGRHakdIamUwSHdHdWRuK3FoemZUMHpvRENxNUZVSDQ5T09ocjFEekhi?= =?utf-8?B?UFRhU3RSUW9wQXc5SjNtbXpPVUthZGk1RUlBNm1GUi8wV3J6SG5lM3VCZFBr?= =?utf-8?B?R21Qc0Y3cXFJTlkzQXdYTzd6K21WbStKUVp0WHVmdGhzaU5KTGRMRGNCWFZW?= =?utf-8?B?TTRsOTdlSDMzME5TV3ppbXlyOEpqY1ZEekNidGZjaTM1YjZvdCtyc1QvSnBa?= =?utf-8?B?UHNyTEkySExubXJ5emdVRElsK1BpdnZsUVNic0FnMTRmR0ZqRmJ1cE1WSVhy?= =?utf-8?B?U3NZSHkxRi9vU0cyLzc0d3RjdnVFNjBuVnhmdUNyOWZQbDdscWlvSllQbEVI?= =?utf-8?B?QXE2QWRwam9FOXUwbWE5L3dRTGtvUkZxUzNzVGNFZ21xUjF3NVZsM0JYVmVI?= =?utf-8?B?c2NGd29mN0FVMVRnS01mTGpDUTVYQ1dlT1hnN0NvUUFqelQwUnAzRmEwckZQ?= =?utf-8?B?WWdjM2Q0L3owSGFjMFZwTWp1RVZZYjg3aW1LcE9HZmlBZmVUU2xSZkIrZkpv?= =?utf-8?B?OStVaE5pQUh2VE55ZzRwRGNDWWc3MWRNS0NsU2RuVEt3aXUyUGxSYVlZWEsw?= =?utf-8?B?RHN0Rk52M2FIWkllMTVWWGpLN0c2Tnpsc0VvZmtPWng0aWI1QlVHQWFWa1NN?= =?utf-8?B?RHVab0Y5QXlKTlVldnRyYXFrbnhTeVFRa1phMy9TOXdPRmVnQzZHa21EbW9K?= =?utf-8?B?QWFZWGJUS0JwclFpUWVoaXppVm1GMGNLMXQwc3NiWWpDckxJcGtxMjBMcGlw?= =?utf-8?B?UEJYUFNMcXdwVFF5b1VTOUVyZW92bEdGZExRTjNXOXRjOHc3Mnh5T1ZrUWFC?= =?utf-8?B?MnljMjYveGxqWkNRaDdicmxpaTlNYlI1alVWZjg2aWFKc3gxMGl4MElrVmFY?= =?utf-8?B?aWplWVhjeE9WZE4wcUZzaStIUU9aZDV2NGZCSGVJZEpkVEFZd3k2WVptVXhT?= =?utf-8?B?c01sMFo5M3hHTVVvRVhJeE9QamJRWGV4YXFNQkFzSmZYR1MyWXo0UWNQelBk?= =?utf-8?B?dGk5NmRIRkJiU2xlZ2Z1QU96Y1lwd2JiZ05zckZ1U0haa1JzVG1yOGM0SGx5?= =?utf-8?B?VGNYWVNlbWx3c3ptMDdueW9lbUgvYUlFdEFWTUhjWDFaa2ZxVHVTSkxpQ0xw?= =?utf-8?B?VzFjY3pydU9TY1ZPQjQ5SGROMnBjWWo5WjJ5dTZOWmllSHVsRHFKRS9TaXEx?= =?utf-8?B?TUV1Ui9WOVVVZk04VGdCbGFXNEcrckI1bEJQYkk1eXpOOWowdUxRNmtLVGJ5?= =?utf-8?B?cDFURFdMcCtSa2Y2TlhrdkJDQVI3T0hnTTJ1YWRzTURraWdvRHRQaWd2ODkr?= =?utf-8?B?SzN4alcrNmlSRGdqK3ZXbDV2UFlUREJMaXIxcm8zUW8wVUU0MGREcmlGb3lC?= =?utf-8?B?TVR3azdhVTZRT1NteEN6RVlraEhLaDB0eDV0aTF2QTBkK1lrVSs0VzlSMDF0?= =?utf-8?B?QzdKaVFTVGF1eGZjRUR2cjRrY1cxM1d1OFFwZGtmQzlnL0V6dUdSVzBxSCtX?= =?utf-8?B?Z1dqeHBzVzZ2QXFyRWEycUpLczhqMk5nTUFicUdGMis5VTJWdGo0MkJ6TjNl?= =?utf-8?B?YzVRV3ZyUHYxTmJ4T0ZHT3lJYUcwQ09rT3QxY0Q5c0ZLVzZ0VTlFR3Z3YUkz?= =?utf-8?Q?I0UAJ97OlB2yy7f0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18747c44-9b4b-4f4b-e118-08da3a4c72cd X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:35:24.6554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ti8ZhdUrBK5fpOqj6Mkq4bZMOyv1h4m3wVgoZRvmaoQLe5/hxr16zcYQsrbcnoUJpp38Lr0Kv2J+96M8Ts72Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3862 On Wed, May 18, 2022 at 12:40:59PM +0200, Jan Beulich wrote: > On 10.05.2022 17:31, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:43:16AM +0200, Jan Beulich wrote: > >> @@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte > >> old.iw != iw || old.ir != ir ) > >> { > >> set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > >> - pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), > >> - level, PTE_kind_leaf); > >> + *contig = pt_update_contig_markers(&table->raw, > >> + pfn_to_pde_idx(dfn, level), > >> + level, PTE_kind_leaf); > >> } > >> else > >> + { > >> old.pr = false; /* signal "no change" to the caller */ > >> + *contig = false; > > > > So we assume that any caller getting contig == true must have acted > > and coalesced the page table? > > Yes, except that I wouldn't use "must", but "would". It's not a > requirement after all, functionality-wise all will be fine without > re-coalescing. > > > Might be worth a comment, to note that the function assumes that a > > previous return of contig == true will have coalesced the page table > > and hence a "no change" PTE write is not expected to happen on a > > contig page table. > > I'm not convinced, as there's effectively only one caller, > amd_iommu_map_page(). I also don't see why "no change" would be a > problem. "No change" can't result in a fully contiguous page table > if the page table wasn't fully contiguous already before (at which > point it would have been replaced by a superpage). Right, I agree, it's just that I would have preferred the result from set_iommu_ptes_present() to be consistent, ie: repeated calls to it using the same PTE should set contig to the same value. Anyway, that's not relevant to any current callers, so: Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:36:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333746.557647 (Exim 4.92) (envelope-from ) id 1nrzzo-00040w-El; Fri, 20 May 2022 10:36:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333746.557647; Fri, 20 May 2022 10:36:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzzo-00040p-Bc; Fri, 20 May 2022 10:36:36 +0000 Received: by outflank-mailman (input) for mailman id 333746; Fri, 20 May 2022 10:36:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nrzzn-0003Ro-N5 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:36:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7816a59-d828-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 12:36:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7816a59-d828-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653042994; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S5xCJQcroAZaAJyun2qGjw1znnSHkWD/ElHptovrOko=; b=eaQFRCv06QN2RDhm0uBFSccju5wVsxjF2I79daIyrrOmW7ZzybpBZ8Qq fPlsVEXIrZFzLh4hixQy+RCt0Y+IRXZTaCuGR/rjjDHTHyRUj9picUPgn 8ZL54OSu2UXIEa4qKh4YAmpssXgmFO2IY06Et1PWIgJpcUXjAlKDCiYgA w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71774822 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:YRimT691dyNWz6CV3VVvDrUD236TJUtcMsCJ2f8bNWPcYEJGY0x3z jQeWTyDafeDYDD2ftBxatzn9UtQsJTWx9Y3TFY4qH08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IHoW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaHta1sME6vdpPk+YiF0LHBxHYNm85aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O JNGNmY/Nk6ojxtnHxQpCMNmhOeTt3jBXSFzjAqfgPYmyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IBAWWF74sfS/okvjQ5RUL El8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO9Bnyl2o56zF3xu6N1AocW9OSPIGv+ZjEFTGy WS1c8PV6S1H6ePIEirErunI8lteKgBOczZcOHZsoR8tpoC6/dpt1k+nosNLSvbdszHjJd3nL 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuBRPtfNi3SAswSz0Bq5BN/xoqO9l HYFgdOCy+sFEIuAkieAKM1UQuzzt6fVYGOF2gA1d3XEy9hK0yf8Fb28HRkkfBs5Wir6UWKBj LDvVfN5u8YIYSrCgV5faIOtEcU6pZUM5vy8Ps04muFmO8ArHCfepXkGTRfJgwjFzRh9+Ylia MzzWZv9Uh4n5VFPkWPeqxE1iuRwmEjTBAr7GPjG8vhQ+eDAPyfEF+1abQPmgyJQxPrsnTg5O u13b6OioyizmsWkCsUL2eb/9Ww3EEU= IronPort-HdrOrdr: A9a23:Nn7fpKusPOqT7oMWtCq+qa1o7skDdtV00zEX/kB9WHVpmszxra 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IObuEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="71774822" Date: Fri, 20 May 2022 11:36:29 +0100 From: Anthony PERARD To: Elliott Mitchell CC: , Wei Liu Subject: Re: [PATCH v2 1/3] tools/xl: Sort create command options Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Apr 19, 2022 at 06:56:03PM -0700, Elliott Mitchell wrote: > Hopefully simplify future changes by sorting options lists for > `xl create`. While at it, declare the options list constant. > > Signed-off-by: Elliott Mitchell Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 20 10:39:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333756.557658 (Exim 4.92) (envelope-from ) id 1ns02C-0004g6-TL; Fri, 20 May 2022 10:39:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333756.557658; Fri, 20 May 2022 10:39:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns02C-0004fz-PD; Fri, 20 May 2022 10:39:04 +0000 Received: by outflank-mailman (input) for mailman id 333756; Fri, 20 May 2022 10:39:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns02B-0004ft-N4 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:39:03 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f370b26-d829-11ec-837e-e5687231ffcc; Fri, 20 May 2022 12:39:02 +0200 (CEST) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:38:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB3592.namprd03.prod.outlook.com (2603:10b6:a02:ab::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 10:38:55 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:38:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f370b26-d829-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653043142; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=daoX953iOxPnmzVX4DqZgysDzroHTTyfQ1x+s/wWFYw=; b=ax9Yf0k17wDGMo//a3bVq/mUX481GgTRgk/ovQJu1+OYnWsutJ9Y0blr M5SJTomBhJD6l4UbK8G1N0ESUZul6HKz7Gah9zfcY0BcyBthcgxAWcb5b Py3CSuUj41ZHNWvrrqFiIP1iKDmlYTAr4Z73HYQVfIMdpOIfHMtKbrL3x c=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 71774954 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:af6xd6BM2nxc1BVW/yXiw5YqxClBgxIJ4kV8jS/XYbTApGwg1jIFx 2FLWG/UM/2CZmL1e95za4ngp0xX6sLdzNA2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhy2 OdUs6OACj0oYPT9hMgtbkQGDRxxaPguFL/veRBTsOS15mifKz7G5aorC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6l+B8mbHM0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx2SajImAEwL6TjbcT/XaP/DIq6bPsLsrlIMOOVetwslnN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1jYfVsRRFasm6QiL4qvS/wudQGMDS1Z8hMcOscY3QXkg0 ACPltawXTh36uTNFjSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa3871KbnC43TEYj7vg+R IronPort-HdrOrdr: A9a23:oM/TmauZg1DKABxUB8aiU2ie7skC/4Mji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVeUiz9bUN1LNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUUHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0k9 gsfJ4Y0I2mdfVmHJ6VNN1xP/dfNVa9MS4kEFjiV2gPR5t3ck4klfbMkccIzdDvXqA0570Pv7 mEeG9klAcJCjfT4Iu1rdB2ziw= X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="71774954" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJDqH7JHk/zT4P8o0rW/tMz9LgtjPgHjDvFljcFoZWOutEpR9i4ZbcscSjzJCEAJsVMU7pSzw8RW3sUFaN0Y+0Dn4EOslZQ+jG2fozQw18VivhXUGhHAR7yBXU5nbSpmaxvpFnqcFgcNov6pygX22x5WT7UF3FkpVGkj3W7c73a4NAZMY/a08gblxRjSc1/izIrFF9/cm0eOwVXALGx4pNrVUOPz2G/pELM6S0ef0S9YZAn4i+E5Tx8gNUAAxXtoV2a1uIECInB8LguZSj6GQzaAAGgbCBV53JJRXbUHf0OBgMUZJ7s5cDkOSqHkBwc0kvPhhLnoE6J2qKWwcNZqVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vX2awDhbP6uvAySCIHuiB3VbLGxnueUtPToMQYR9gpc=; b=ncqozEhafFSC6n3YxoCQr6OhxJMuC7nyYuf8s4zTaxsFCApdq4jh3ViokD9S+tV2XAufhi71WHbZ2CwN95PqRt7zA7ruZXFvKr5CSpjXbuDdM0DLpWnaeWviUsKE0eF0VnIu2g/IN4hecSylvKexCj+Ze9BkaoL8ho+02IpMQGocu2FIvtrzrcuoL/GjxpisduwqyBAXvDmb9ZZvZFDVMt6Waa9QP5c74p9GQkosv4J8lu2HNmMj92sQvJwG7PWBjMRJRudkIzUkbpRcFOjW8bFHWW4fU7n5SGkIWheGpmBqo3F5qhBSYL2616jAHOdUUAHpNjr5bdkBeNs+2Vm5Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vX2awDhbP6uvAySCIHuiB3VbLGxnueUtPToMQYR9gpc=; b=eX6n+3FAJhaIEz0LkKkHD873aA2ftCIy8z7GAwA9gAbQrZEaI0Mt01ne54DlFd+W/ZLcA6ouhyyXyQsYJmxvrmTHyCrA/3uEwV6HGbJlJO7M1yODIE36hwn5SYxwY3njlIZRFbRdYUcC0prTekzCW5Sz7EZQBBWRW/Qd1SQQuIg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:38:51 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 18/21] VT-d: replace all-contiguous page tables by superpage mappings Message-ID: References: <98553b89-6296-9e4c-4677-9201cd7cdeef@suse.com> <1f029c34-f300-3841-ab20-85aa796b486b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f029c34-f300-3841-ab20-85aa796b486b@suse.com> X-ClientProxiedBy: LO4P123CA0099.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e831be2-b1ae-46dc-a660-08da3a4cf090 X-MS-TrafficTypeDiagnostic: BYAPR03MB3592:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frxiuGl8jkYELmnKA+EG0mf2LZ2U8qYx6fKzE5feJV1/0/PIwxEibcD4KrzcfDrtQU1PQ9Knlk2zN7jH9mIPSxrFgflMe4ZEW67mmKzPMcY1iRiJ3jWjKTWypGtLfar2gkASx8h9kBdGHK9d8wYZ5RwGFispz+AqbPk1IRCIvP9r3NsYHbXz3XgSwlJ5tEbrtOFELoed03Yta90FeoBEh2hQwoeDOgCFDwpOo2FZ525J0GHlq4mhR0skfU450dp+d3v8hhljqcp61z9YWlSUf2vwTruuuNmUN5zFhVlq9P0Cz1sr+V+knEkBhbyj0/ETn6KmMQjtBZfUQIh5NetqjRneZaQUCmS8rO0ebUhs0LBdiQpykL552COTwJ/0EdWpsRqIJH/tZ52+xwzJjQxNyzBmx1Y3L1d4o9PzcUkOqZhOAH4Toc5LH6Bl4C4UU3w9tSbGvS4nyNTk74J3hAmMtM1fhErqHjiwJIpNnSK1VK15n5ScqE8DBODasia7l+FkY7/XsnHQUJyfIuP02XI3a8220ZOrVZjgqQOPoDeuIgwffs8/Bm/A4sj20g3diBklQ1X/96muhmHhtsAoJgv/BFS9xxkZPvQbo02yHSbe6LU7OJVMpdTU4G7XsjObAAjCXjcsOyXzroquRiTtvFhMCg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(38100700002)(316002)(54906003)(82960400001)(9686003)(6512007)(83380400001)(8676002)(66946007)(4326008)(66556008)(66476007)(6666004)(2906002)(6486002)(186003)(86362001)(53546011)(6506007)(33716001)(8936002)(85182001)(6916009)(508600001)(5660300002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVBHUktuajR2OVVWeFdZZVJlWnZaQUN3a3B2V0NyK1J3KzlRSG9PdUxDRkpX?= =?utf-8?B?SjA2ckRtNzZtZGJPV1padnI1V2V6S05peG9tNCtKSGl0aGlRY01Qa01WUmdJ?= =?utf-8?B?WHFLZWRjQ1lxSm9FTENSbWFEN251RlkzazhPaWpJRmIrTFJLbHVMUmFUTXU2?= =?utf-8?B?eDZNU2IxeExkWERIMXVwRjNGYnQzdG5UTnFiWERYMENiaU1WaU1ZVEhFY0d4?= =?utf-8?B?R2trN2h4MDNZTEd2aHhZUmd0OEdGTzJucEp1ZFk3aEIxQ1F4eVZGTzNxWGJj?= =?utf-8?B?UUJOSzF3M29RUExmTnd1ZlcxemZTaStKaW1OZlRMeENiZ2dIOVd1ajhKM1lO?= =?utf-8?B?NFp5MmJ5NlU1b2pqaWdDRU95dDZ3aS9lTW83UjRkYS9haXFaNzBieUFKZS9G?= =?utf-8?B?L0ZhWitGTnNQTzFlMmdtaXJyT0JiUE5QYzFUa0NsNEZYd1JSdVRrK2JzZGsx?= =?utf-8?B?c2t5Sm4rM3VYZzVtYVJkWklQNFVwZFVQMm1vR2dFZ0ZXNnJhYVdQYjlyWmxD?= =?utf-8?B?amQ5SzFqMHY4Q0NwTkNrZEVlMEtXM20zNVJhRk1WVE9nQVRkUUY1bkhXTFd1?= =?utf-8?B?VFNPQ29RVDM2aHdOMHZWV0JyWjgrdnpDL2c1bzkxWXgzSUdXRTFXK3lFaVpQ?= =?utf-8?B?QVFidDBNSlNaK3p4b0N0VTQ4ZWFlSmRXMk9oNGZOTGI1NnlXNUFkTEhSak9W?= =?utf-8?B?MW41OUZvY2N2MHFTdmtuWDVzS0RteFZFQjg1YSsyZmhCV0l4OUdLbWVyaDhl?= =?utf-8?B?ZlFNZ3NVc2FyN1dNa3BRRmc5UlRGSTdiV28yWTBacVVUMU9TbFJlcFVlZElJ?= =?utf-8?B?Z0luRzF0djc5ZENYRFpFczVOQmZwSzN3VW1KYUhuRXI1blIyUUgyMVcwT2tL?= =?utf-8?B?cU1VMVVJcE1UbURody9pOTZuZ1lZMkRpVVpKTVJWdTY5Q0NBd1hIdXpSYUpi?= =?utf-8?B?VXVEejVYTkE2U05tRW52c0R1R3JVMkUyUlRjaFNvaDd3WVJ2Ri9FZmJzalBN?= =?utf-8?B?aE14azg1MitwYTNTR0NmMmdmZUhub1VYRUg5RkliVkNEczI5ZlR2VkZtUWdv?= =?utf-8?B?akZSTFBiekJVNlFWSUVFTmMyNHo2NENubFZnSitMb3VlbytoUE1ycjdmUmlu?= =?utf-8?B?N2E1UEVVeGJZcVdxakVRTklnU0JPa0J5R29NUkIySXJkQ1I5WmZoZHlSdU1h?= =?utf-8?B?cmd2V2NiQjJCN0RQSkRtRVJMdXZlQlpBNGk4cHlOa3J2ZzViaUhKUW8wVEFi?= =?utf-8?B?SlNWYi91UGhJWDJadkNNRWk1amxWOFlFcDVwYVFzaE1WbnhWVW05bC9OU2wx?= =?utf-8?B?d0owZHpOYWpHRGVOREdtZ3Z1OWtZMUNNZjBINUcvZHVwU2I2ZTd2RzB0azJu?= =?utf-8?B?OUJhZWxHSWpjMVR1Y0o4b2NvMXdyMTVOYTNhQU1Ld3lmVDVzWktaMkNMM3Iy?= =?utf-8?B?aVdpUlI3cHpBMUE2Y0lIN0NhU2RhK0c4Rml6YU9wOCtHZmQ3NkFxNExBREJ3?= =?utf-8?B?amVZblliU0hxdnNVN1ZLSzFWVVVsbVJlWEIrQmM5UVRaWTJpTHI1Sk9HUXB6?= =?utf-8?B?TGo2dklNSS9yT05pWkJzZWJoV3lQcXJrSFV1REFvOEZLYWh5U3JyOWV1N292?= =?utf-8?B?SDVwN3JlN1dFQ3R1ZnpsamlGbUxMTUtPRnRUN3FTYUV1WGJRa0pHRDFpS1VC?= =?utf-8?B?MEJodEtsbi9HQXhOMDhUcGU5aUUzSHpJZ0N5RnhCUXIxbkJ2aS9qdUVERzZE?= =?utf-8?B?THlrS3RHOVdqdVErcXVSbGx0VG5iVFVUTXA0K3lLcFFMZ2RjQ3pTMkFpYlpi?= =?utf-8?B?czF0VlF5ckJhUXhGb1MvbThrRHZ6LzlNTjc3Rm1EbjRMdjduVDNXQ2w4WmRo?= =?utf-8?B?U0QyNW1kaDZ4dUtOZWtTNHpya0YvcDVDYTA1Tk14Zkg5Q3Z4aW1VdkRERzh1?= =?utf-8?B?dVFwK0N2cFpXdGF2dzRvSDluaXBXbzlGdERSeHE5R2xxMkVjUy82OVhSaFZv?= =?utf-8?B?SEtheXlZMlZUTFBaaFpuNkVnNmpZL3dUaXdETCtOV2p3N1ZveVl3RTI5R0JQ?= =?utf-8?B?enVkMG1VSDUrOEpTM2JRTWZvOXFScXNzZjJyRVVQL2JIUGNyelNRZjlzajJ6?= =?utf-8?B?V2VOODZaWUtRUWl5R09uaC8wUmg1alJ2UGNjQzREUTIva01PNzh1MFc1alVl?= =?utf-8?B?dS93WEZocVpQaW5UTkdwNCtjcXpIVmQxVnFiaXBETklnb2Vhc21kQ1BzSzRR?= =?utf-8?B?NWNGU1h2T2o5RXg2Q2tPK2x0V0ViWWdXSm43aU5ONlJKTTBwRmQ3SktMbFNN?= =?utf-8?B?N0c5aVJETmlkS3NXekY1clJRK1NFL21rU0hwWWd3RXZ6UnlnVTNoR0l5MG1s?= =?utf-8?Q?/WxNrorm28F1zoRk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e831be2-b1ae-46dc-a660-08da3a4cf090 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:38:55.6158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Uduqtp4j8H4JMrzzpKm111gKsAzGH9X5K7B4Teq74B5/ueJsyA/FE9qR1TAY5shuAYwn9dzSA0MkWi3frLrYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3592 On Wed, May 18, 2022 at 12:44:06PM +0200, Jan Beulich wrote: > On 11.05.2022 13:08, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:43:45AM +0200, Jan Beulich wrote: > >> When a page table ends up with all contiguous entries (including all > >> identical attributes), it can be replaced by a superpage entry at the > >> next higher level. The page table itself can then be scheduled for > >> freeing. > >> > >> The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap > >> for whenever we (and obviously hardware) start supporting 512G mappings. > >> > >> Signed-off-by: Jan Beulich > >> Reviewed-by: Kevin Tian > > > > Like on the AMD side, I wonder whether you can get away with only > > FTAOD I take it you mean "like on the all-empty side", as on AMD we > don't need to do any cache flushing? Heh, yes, sorry. > > doing a cache flush for the last (highest level) PTE, as the lower > > ones won't be reachable anyway, as the page-table is freed. > > But that freeing will happen only later, with a TLB flush in between. > Until then we would better make sure the IOMMU sees what was written, > even if it reading a stale value _should_ be benign. Hm, but when doing the TLB flush the paging structures will already be fully updated, and the top level visible entry will have it's cache flushed, so the lower ones would never be reachable AFAICT. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:41:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333766.557669 (Exim 4.92) (envelope-from ) id 1ns04q-00066K-Gr; Fri, 20 May 2022 10:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333766.557669; Fri, 20 May 2022 10:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns04q-00066D-E0; Fri, 20 May 2022 10:41:48 +0000 Received: by outflank-mailman (input) for mailman id 333766; Fri, 20 May 2022 10:41:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns04o-000663-VI for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:41:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7067ebad-d829-11ec-837e-e5687231ffcc; Fri, 20 May 2022 12:41:44 +0200 (CEST) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:41:39 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BY5PR03MB5064.namprd03.prod.outlook.com (2603:10b6:a03:1e2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 10:41:37 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:41:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7067ebad-d829-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653043304; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=C799wSVd8mheasBi+UFY2ISFXzyimWK5JgtnMgfUL0g=; b=VLArUcMUxZtqPiC+HDbH/D2EQ78ywMrSLQ1KVJW8h6S7PHCYGLKufy51 R0iqHq9wdLyXffncEB2zUIRa/nDWs9y2e0+MGm+GnkQtv37eCwtavMO+t GBGBlWjde0eyBfRFMqUT9oz/b+Mvs5PMUZnwSv2F9C+VD/JLJ3ui16WLw E=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 71149295 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:l3azMqD2bwJ3lBVW/1Piw5YqxClBgxIJ4kV8jS/XYbTApDJ31DUDy GoeXzzVbK7fMzeje9h2a4Sx/RxTsMXcyNFkQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhvx 41x6qySST14O6/exeM9TCtaLhBXaPguFL/veRBTsOS15mifKT7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t3B8mcG80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx3yWuKWwFwL6Tjaxwv2Xh8AFQ6uHwbvjNf8GkSptJnm/N8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1jYDX/JAHut87xuCopc4+C6cD2kACzJENtovsZZsQSRwj wDR2dT0GTZorbuZD2qH8auZpi+zPi5TKnIeYSgDTk0O5NyLTJwPsy8jh+1LSMad5uAZ0xmpq 9xWhEDSX4kusPM= IronPort-HdrOrdr: A9a23:n2L7MK+KFlpmKyXI9bNuk+E+db1zdoMgy1knxilNoENuEvBwxv rOoB1E73HJYW4qKQ0dcKO7Sda9qBLnhNNICOYqTM+ftWXdyQ6VxcRZnPbfKl7bamHDH4xmpN xdmsFFYbWcYTcK7reZ3OD7Kadb/DDuytHtuQ609QYLcegeUdAY0+4PMHf8LqQZfngjOXKxf6 D22iLIzwDQP0j+Ma+AbEUtbqzmnZnmhZjmaRkJC1oM8w+Vlw6l77b8Dlyxwgoeeykn+8ZszU H11yjCoomzufCyzRHRk0XJ6Y5NpdfnwtxfQOSRl8kuLCn2gArAXvUuZ1TChkF1nAic0idorD D+mWZjAy1H0QKQQoj6m2qp5+Cq6kdR15ar8y7ovZJIm72/eNtyMbswuatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAjqqOYmwtVrQcotQ0XbWLeUs4kkaUPuEdOVJsQFiPz744qVO FoEcHH/f5TNVeXdWrQsGVjyMGlGi1bJGbNfmES/siOlzRGlnFwyEUVgMQZg3cb7Zo4D51J/f 7NPKhknKxHCsUWcaV+DuEcRtbfMB2HffsNChPkHb3KLtB0B5uWke+F3Fwc3pDeRKA1 X-IronPort-AV: E=Sophos;i="5.91,238,1647316800"; d="scan'208";a="71149295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fe6cXykSyTBwLe9rEBHyqWpEEgUu54RnJAuE4E7WZCxGCks7uT248kjIV0GiDfoI7HLBA+dDI2wcT0TSCYxNqRYiHGI6vpKuHhsgEWV9kepGjvQqxNb/yWB71sV5FiICVJGhvf/SnHVDc2py6g8gFfSPxtPLA11/SqZ1KKo9sBTWlg+/9eka3w9pATh6N54+0z5P4J2hO3xyqXzFaPWSgf6odR9CnJtgTow3yZcCKmxx4aJQTJl8k/8xdUQEWdy5hCtpjfTsLiVWHAKEvpv7sc+hGVvBkiPZNiKzjtbwhSO6haTmQLTqchCFB8qG45IKMIlvEfs76G3K4B6GH8WkPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxJSHlIXV2cmu39YQHH4XEkxVJxVrkvXVMjyBXONdCM=; b=MRFy7oiaokEB+0mKEOi3lnDqJ2OjaU/x8jAco83uGkpi21nworW2a4g5QHL1lQWctg1cX52SvDCGEIu9993+zfvvaxxCoUSS8AK/mg2QzaFWIM/tCIAx9eww+m+L3FrYC3PfmzvokGHOc2A9NmgusqQYGARbJ55yKeDTZFxla1RdgLxAel/B9NVbWnCY6F6qAd4WEwOo15lJNPYrNez77yOSzYFq5nyOYXr3UuEB4+vy7FCNNz6FNsNuPzStM2SgKkIuRVBtZoFmTpdtIKKP2CAxiP3qUHg3AWsJKZWnEKkL7jqR8Ec1MuQQufkb08BfLqQ5UlkhWW1K4GmbiEnXRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxJSHlIXV2cmu39YQHH4XEkxVJxVrkvXVMjyBXONdCM=; b=GaTRH1mLOW0WsnKoY8SmEf4xb2Oe8ieBU5I+Hw54DceyqyzLhvDt5OuAP7YODUIdOaRPMdXENvbt27iix38Oyj0Fk5n61XvglNwF25t9j9/89Hhur73Fzs8t2zGjxjFCLoj/IYavtYNLkObw8choi1MQAW/Ih2fk+SBuPo80QeE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:41:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 19/21] IOMMU/x86: add perf counters for page table splitting / coalescing Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0316.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 343bfdaf-2895-4758-23f1-08da3a4d5146 X-MS-TrafficTypeDiagnostic: BY5PR03MB5064:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RJ4KwkPJ/BfiBynzCchGhCzAowt+cNhncS1hSbsebRrhspOuqXQ5rvvIQpEm2u1s4YqQd2blHo4itDucmgaZ9WeQJU6TjlAynravts/jBt8K54llxbojRHumiSrWyX3pTNElv89A7IWXqIm1YjtLiOmzCkOwxNnEyt5/CDBtjilSeNrEKHfYju0/6KcPXqoZwpfC8ROs1KYBE+/IxpyKtQVSP2qI7RF5JK+i+qgI9X47qYdW5vSavvErTQWcEAiPlpg/RHWT/K/e0BVFf9o2fajoRDwOZ/Q0Lx7cnJgofAAsIkCaEqxbV2+jRfr0GZDPp0IIQ7kyyQ7jHhmuX9FD0s6WcsPJX21FW7OIv4PrvlzOCofwapPVKi4WAmNBJR+DVUTR8CkCCU8GI47K6BahRbQvjz7wVH2qlBPiryePABkC4p3zaEf+D92np00cDixdNQvxwy/teWuffOM1OsQq58dNvce6iiDGkKPHE1aiM1UOIho22XMtjDsMuMhhC/uVrkZa+71JnNkDtQ8s90Sd2az0+vdv/vPvAfRFxKVr9v3csPdm83/nBOsRY/QUC940CNJ0V9/XPhlXKRT0x9clvi0NYEWj4M8/dAkhq2p9LZn7B2TaS0jroHqGpSvld3Iu5U1uajTQbbREph4Uv6Fdeg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(33716001)(38100700002)(2906002)(5660300002)(4744005)(8936002)(66476007)(66556008)(66946007)(4326008)(8676002)(54906003)(6916009)(186003)(9686003)(6512007)(316002)(86362001)(6486002)(6506007)(26005)(508600001)(6666004)(53546011)(82960400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDdWKzV3MjNzaFdmTFNEbUhBdDBHWVBJM0NsMVhaeEE2TnFrOUFQZ1B2aW4w?= =?utf-8?B?bnIyNjhEMDBjcHhnajhna3pDUks4SjRJb29laUNqUTdBdnpJcEUwUDY3bnY4?= =?utf-8?B?ZGVVZnhLU0tRVUlhOURMM3cyUVBySVhIQjNhcXlmSmY4aEppUzUzZllpanBs?= =?utf-8?B?aXBOZjNlVUpmMFhnWmgxWmxVQXBCT21LN2ZyQW5jblhxaEpSbklMdit4Wlkw?= =?utf-8?B?cHRDeHQyMU1qY3Zham5UYks0S0dFaVdtKzc4N0lIUnM4UHNpeVZkbTlxMzl5?= =?utf-8?B?VFNUVjJUdzh3MXpzRHFvSm03bjc5NjNkbDE5TU1NdTJMMUQxRGtHaDN0Ynpn?= =?utf-8?B?eFlGNWs0elU0NGk1aTZIcEdJTUtqRmIyN3B4NVZrdzhRbFNORmxmMDFVNXdL?= =?utf-8?B?K2xySFdOczBJNlFvZVBuYzVMdjNCcDdXOW51OGtHQTVCSm4wVmgwUklpYy8z?= =?utf-8?B?YnE3dmY3M2U1OTRMWjBKSHV1S3hkc09uM0FrdjNnZUg0NEJzY0N3cFlzbTFw?= =?utf-8?B?R0dRQmxvd0FqMy9sSDBqVms2Y1pTVW1jN1NKSGVaZERML3h6Uk1iRmthVm5C?= =?utf-8?B?dTM1NWcrdTVrYkJ2ci9Fd2MzSy9vcFo3eS80T1ppZk1xaHg2MER2QTRrVVZH?= =?utf-8?B?TFdMWUxDeW1OeFBkMGgvUWIydjVMZUdTNzlDS1VKV2RQRE9QUEhRWkF6SG4x?= =?utf-8?B?S0p3ZjBxN0x1b2RheXBCdVJuSnBLc0psUDJRT0NpTmk3SFExbTB5MkhhRTRx?= =?utf-8?B?SkVUbWpxZ0RaYzNRbEc5VWtSRUJKSDFZYS9tV3YwOVRMT2VKTWh5dlJ6emY5?= =?utf-8?B?Um1KeWdjSUc5UkpUNmt3T2dhSHpGc2MxTHpmVDY3eEtoL203YUt1VkMzNEt4?= =?utf-8?B?dkRZVVo2TFVLeVZEbmw0b1I5anlTaHJ3VzdKOUJkNGFFaUM4U2ZaVGtrWUM3?= =?utf-8?B?VlFqY3ZySTMrS2xOcjRjWStUL0dMQWEwaDBLVFNpSjhIK25aald6Tm5SU3V6?= =?utf-8?B?bS9idkFENzd0emhRU21BSkR6ODMxUVZncTgxdzNnUndQdHlQclI2WkdxUnFu?= =?utf-8?B?aE1tWGNjQWkxS3IydUdJbTd3eFYvaVZIRkxVMkhvT3NnajFndmxyS0EzVzFL?= =?utf-8?B?eU1wTU4vQnRIN2lDbjVoOU5TdGtHcFNVWHVEdksvZFBMNGpxcG1XZlordmps?= =?utf-8?B?ZC85U2tCaGpROGpXOEJiSkZ1UE5LVW9HVUlhK2haRWdzQUZBOWFLQ2NLampk?= =?utf-8?B?c1k1eXozdjlZeFVRUFVqUkI2UTdJYVNUNzh5WFZvak5wc3A4czJBNU5nWFhy?= =?utf-8?B?NzFFQ3Y0Tis5clNYcjB1MUdtUlY1MVR2SDNMSTRNR21FY2FDRWpLMWhxaS8z?= =?utf-8?B?clZkc29EK3pJa3NsQm9Udm0xNFpOeGgzaEJJajFTMCtwUGI2eVFJeFZ4czdx?= =?utf-8?B?aVhPeGtLRDRaZU03Vng0eldudER6OWI5S2llTGpQQThuL1YvSDYraHVzYzlP?= =?utf-8?B?eU1wNVVyMTExOUc4N2lSWGZpRklrMDhuOFlxU2lPSTVGMTFpZTl0NmQ2MEEy?= =?utf-8?B?bzBUMHNyc01McUhUU0I5WC82dVJSYUQ5SklFbmlBWmtJQmZsVVZaMmt0akRu?= =?utf-8?B?bFFTOUE5YXNlQmpWcWFESW5tSTZUem1Hd08zSU5VSzlGWFZoM01HeENSTXJR?= =?utf-8?B?NFYxc1BHOGRPNUYvN01Bb1pBRE8ySjFyYW80ZkJhaHcwYmM2SXppTTZNOVJR?= =?utf-8?B?L04yVVhOSldDNmNqSGZlTzM3Z21SRVgraXZ0bmp6dWZwUTV4UnJma05XQjVy?= =?utf-8?B?UjBkZ2EwalBVVWx3R0lNc1MzVzAzWkxuWGU0bnl1dGFhMUIvWUcvMWsxT0N1?= =?utf-8?B?djUzenBMcXlpMGxwbzJnL2NYQmJ0UFJCWkJTSTZLWjBVZVNjNTU2NHY5RkdU?= =?utf-8?B?Y0p0MXNzZ00ycURnL0RJekxMVEdmbHVhSDJVeW53WVJ6dGRocStPUzRvOTdX?= =?utf-8?B?OWgwZWlJUHhiUEN5SnprMG5FUVkvVElEZlJHSDhqL2RDRGNwZEJwV0ZaT0Zy?= =?utf-8?B?eE1kMExWeW52d1pwY3JJMFBGR3liVThyaEozelFHdXFWWXdMS2ZSZVEwTGho?= =?utf-8?B?d3ZFSjdickE2T0NBLzhieEZuQXpzRHVrVDNRT0ZNelNWNkw2T1hxUWd6T0hi?= =?utf-8?B?S3lRcXVkY0RoT3lxVUhhQ2hQQkZadlpLYUJRRnNESVN0dU5YbXZiUkVDdm5U?= =?utf-8?B?eVhFWXRiZXQxcGFhS3hjK0lSSkdRd0cwZkcxOGUybDQzUzhvUWZ6UmFsNi92?= =?utf-8?B?d3p3aUl1T2pLbDMva29HemJtNm5DUWJ4VGZFaW1TRmxydXVuS3ZBVTFSUjZ3?= =?utf-8?Q?bTM/VKP7hrkouVEI=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 343bfdaf-2895-4758-23f1-08da3a4d5146 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:41:37.7767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z4uxVq75sj9UW1mQT5CCRQxZjbnxgBOI+B/mpvXPB8X5QHi8mogF0xrlJDvCo20ok6Ab1cgoCK8vCRGjk7X4hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5064 On Wed, May 18, 2022 at 01:39:02PM +0200, Jan Beulich wrote: > On 11.05.2022 15:48, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:44:11AM +0200, Jan Beulich wrote: > >> Signed-off-by: Jan Beulich > >> Reviewed-by: Kevin tian > > > > Reviewed-by: Roger Pau Monné > > Thanks. > > > Would be helpful to also have those per-guest I think. > > Perhaps, but we don't have per-guest counter infrastructure, do we? No, I don't think so? Would be nice, but I don't see us doing it any time soon. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:48:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:48:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333780.557680 (Exim 4.92) (envelope-from ) id 1ns0Ay-0006lv-8F; Fri, 20 May 2022 10:48:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333780.557680; Fri, 20 May 2022 10:48:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Ay-0006lo-4U; Fri, 20 May 2022 10:48:08 +0000 Received: by outflank-mailman (input) for mailman id 333780; Fri, 20 May 2022 10:48:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Ax-0006li-CM for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:48:07 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 533c4c71-d82a-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 12:48:05 +0200 (CEST) Received: from mail-bn8nam11lp2177.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 06:48:02 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB3544.namprd03.prod.outlook.com (2603:10b6:a02:aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 10:48:00 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:48:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 533c4c71-d82a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653043685; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=yliR896BWLb8DfqcOENbAG8jMR81XgE/0WSUqUmZY98=; b=PBd66bYTE5KWkS6fXcTcCUBHe4G+Fgw1xkd1OkMJgHhLumyT0OaMemDR 73wbW8Ie4WRGg/GQLv9KEMGh8o9D3xpFYraBOq5iwNAbV3upAKY59n/9d 5KkV38CCdcLUOiESaqh2BrEHJAauMOB4vUQDuJ7lzBrZlfZqwulu7OZin 4=; X-IronPort-RemoteIP: 104.47.58.177 X-IronPort-MID: 71785295 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:O2hRWqIpzpBtIB/nFE+Rq5QlxSXFcZb7ZxGr2PjKsXjdYENS1jwCy WJMX2GCOvjYNjPwfdFxaY21p0hU6J+Gy4M2SwRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qw2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MlxtMGIGTh4AvaWhcEncz1+FwE5M7ITrdcrIVDn2SCS52vvViK1ht9IXAQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGvqVjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SCgI2AC+Q/9SawfvCvwiyB6zPvXK9uEQOeGGsVbv2qCq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0c8VUO/037keK0KW83uqCLm0NTzoEYtp2ssYzHGUuz gXQwIyvAiFzurqIT37b7q2TsT65JSkSKykFeDMASgwGpdLkpenfky7yczqqK4bt5vWdJN066 2niQPQW71nLsfM26g== IronPort-HdrOrdr: A9a23:gEHvAqg0a4QPANcYvKZ1HF/teXBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71785295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QIGTMIJ825lBwt8pksG4KcvscVnsjuZCQ4nESjfCiIbuXMNHDk5lybiO1+NK0nQHoBtJ7HfjAKDyQicLqYyh1/J77bRd+hHvIKwooTHTXoIHZjhRpgLKKayOX6tT2TNkSfJ/qRw7MueoVTAbfvNXwP4QKUAsDGCJcv1II5lZtHLxdzmguJtnwYv/F5Lq1Xx/GeScqGmSgOij+ZaYNXdMgM0GMISyku2Z1OLBU4UItrW3smfNb3WfaFSJ5an9xivQ8OmWtlrRL9Pazj/kQJlVMroa1fptN+KYYOJvbyfFHPYUwNANhzXf4uGnjr+kggX1j4usTNIiZ426JblcyCV+fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KyLuuJQ99pGXy4h9taQ/mipk4urv5Fp+BoDS2GaMjiI=; b=oNjO/MKknttQFBoNbAklpYSvdKfMJPnLM3YT7R7EGDsDCkJTz6S1yWWO99/sOpvdft/IDk7SOkzgX7Ug48ZIWzZm1vidHpaGjTbX0bVSboqRpsAydmWn/16G5dlDz4WbsqZqP1iJzt1yZF1IvcxFgjHB//5z7uLHQ0YXriId2OzYJTDPf4k//c0vLJFmmZqJBupHzpVhRkc1xUfK6UUq8fKbYoof4l6SqeFJRo95Bj7JuSmnmwW4MP/ToybXdNFI3VTXrSd4pB9zpuI3wfZpER2oeFiIhhM63kSfPl3Xh1KqIZRErlipx1YzwVdaOLYbFfETZpHHYWRkJm+DDQMQMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KyLuuJQ99pGXy4h9taQ/mipk4urv5Fp+BoDS2GaMjiI=; b=YI4wVxIln8B9RyvqU1AAzsLnaCRq7LytFV8QwZ6O6gkkockr80AFWEpOa0BTtSf65fVcyQgiNKbKM6hvVYcS9rHV//IiLwQ5WNV1quinPg64SomrTvhWVobFVKt9hcWF48HBUx5Gm83FuvpQUSh0BRsuoobJQvbSkBg1dP/aslg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 12:47:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> X-ClientProxiedBy: LO4P123CA0372.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9f34d01-6694-4030-9979-08da3a4e3507 X-MS-TrafficTypeDiagnostic: BYAPR03MB3544:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DN09GVE3nlunsrkOLoSVcyk9TKFSaRPYWRGbeBnbOo9GpNlVwtJjzHk2P6zd52Hiqsml9N88WSNiMxRdDaxl1S0El+q/Egp/vj5iO6d2NxVXT5ThmeaqMgdftiI5Uvlw5qhuTELJ3e3A5P1+6SYreSzatZ4jJ7kgj/Bqbe+XAa0IIz9epFr/trgo7/mu3WSqVdqjxIdrMFXYOIETuEbArWcIoZhbnIsb9+PqNbkXbui9F+A2D1LalL02qD8vAdwk1YPWw2g0qV2Ky4797vY/RJDJbKh6gfJVcKzEXKX2Hlk+3xmcPDfUCuBKb1C1GB9psUzCIiCFKrS7o+FA7KvXyf1LcpKkz1OlLj3OCs0gFVWg2VErg563GuX+OGfnv5ZzwJLpvp7YN14rvT9h6SaGDF81++ljnzcW2uwU8s4D2pg5l4ZogPxExAlNmfh3UdiKgDzjN98s8UVNlPdN8QA5uAhe8IwaCYZtEWH9Ln7u1kcW23qIeEyKoPce6p4NMf/X8BTTD5wsRTn3SrKLpcOVoboTlPf57vJgqwGFy7kNisQC3IDpvIpvUin+oO9lcdiwOxqKEEysR6Rl+AhrmuCJv/eJ+CnlNlBIqoJOtTBCU0G61kFvHpwoKKAonNsnt1hj8CU3QrGGL/pUas8gcqBuhQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6512007)(8676002)(33716001)(4326008)(66946007)(53546011)(66556008)(83380400001)(66476007)(26005)(508600001)(82960400001)(9686003)(8936002)(5660300002)(38100700002)(6506007)(6486002)(6666004)(316002)(85182001)(186003)(6916009)(54906003)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDRtcG44Ymx3Y256bU82RkZqaXFOUFhmd2NqOExaVW5mMlVtd1psL2NaTjFn?= =?utf-8?B?a1Y4WjJLd05zZGNDOVBLYUk0cVA1OEFTSDVRMWZ6OWxEelFDeWI5d282b1ov?= =?utf-8?B?bWU5cTlCY3M3cmdPTGdpOXNMYmNGaWd1S2I4TGpyUUhzREdsS3hhYXE1bGNp?= =?utf-8?B?ZTJLdzJJSWdPSWYwT3ZCTGNjckduUjBWMzJLNG5qUTVFeW1UYTBsK2VUd1VI?= =?utf-8?B?bHdyN3BtZm1QR0hvZVR0Y1pra20xdVFvQ1V5M1U1eEhLbExvU2tlQzd6eTM4?= =?utf-8?B?dTBwdEZIc3JOTHZTUE1RRlpLREc0RncycUltTlZjM2FPTGVxSzNldzdVa0Ro?= =?utf-8?B?Qnl2WjUzOHpQYUcwcnBzaVAvSGRmOXllZEVSdmFYVUV5SHlCRXlTYnJVUDNT?= =?utf-8?B?NHQ1Y3FPSE9PUFA3MGVWWDhDcVVqcXJBMWt4NTBQUmhqQld1UXNIUlZMQ0FT?= =?utf-8?B?NHVqUk5nVnYyb3lyVDE2OHp6MUVCdXVOTGJUb29ocnlMc1JNcndZenV4S0tY?= =?utf-8?B?NW9lYTQ0Mnp3Q3BHVjBNajVkZ2w0WDAvNVZOanBpOWxUTUtrcEl6YnRyekps?= =?utf-8?B?M0tWTHdEdU02Yk9ZdXcvM2wvQUJDaDRHRE1xNEI3SVRQSHl2OFY4K2xhYUF4?= =?utf-8?B?K2poTWphVDJ4Q3dCcVZHcGd3WHZPVy9YbCtNaS8vRElNUDI5c3VaSTM3azZL?= =?utf-8?B?VVErYmlrOUlEbTd1U3pITFJEZUxiem82YkRHRHcvdUdGUUduSUVMbEZxWS90?= =?utf-8?B?bDlHK3hYNGl4U1RoUXRkaktvK3A1dDFBbWFYY1daR3lEdlJ2YXBRWEFEeGhN?= =?utf-8?B?MDZDa2xJd3p5bXR3YkpzR05EUXl6Y1ZjOEdvbjZld0RoSlNWZnJ0R3BacWtW?= =?utf-8?B?SEdjWnRvOFQxNVZLdUo1WHNPazA1dmxkcThNL1I3YWxSMW9vWTFLRVg3cnUv?= =?utf-8?B?QUJQOW9qUlA1QWF4TjRCaVJoTFJURFQ1UUVVTk5wT0kxcGtiK3ViSHhBdHFn?= =?utf-8?B?QjdlMVNxbzNoQkZIOEdHb0llRW14dXNFL1c2S1dPSVp2RmxvWFJTZFYvdyt1?= =?utf-8?B?cmlFUEJRL2ljd3ZpTHpORkNjSmhUQ04rWDdjaDlBK0pZVDdzTHkzVHprcWFr?= =?utf-8?B?UVpnYXRVVGNNMCt6R2pwTktsQi9WNUZVYk1qN25pL1JGS0tHRnNadHB1dEJM?= =?utf-8?B?R08xRTlPWTNEa2RsWWdiRTBHeFh0TVU2UXFjck1lYWw0aWY1WTFtcHNHQmZw?= =?utf-8?B?WXFiWDBvLzBaQWd5NVdEMUw2R3AzVmNPTlJyaW50SFpmOEU2N0hnNDRZYWsx?= =?utf-8?B?ZVBaenZWazhPSk9COFgwYzFqZUp2akYxc2ZVaWdGVjJES3I5NTJWcFlDeTUy?= =?utf-8?B?bVdPZHBRZ2p0WWoyZ2dMWG1odTlqL2k4RGdEZVN3MnJ0TzJmajE5UjhEMVJt?= =?utf-8?B?MDZQRmRmRDhKeXNYcEY1aC9tNUZmalc4SE9KbGtVNHpVbVk4SVRiSHhIVFBI?= =?utf-8?B?VnUwdXpud3ptb2pUSFh6YlV5b2pqaXQ5QXByUDJvWHRhWHJ6WkRsM1Q1WENu?= =?utf-8?B?SktiM0pHMkJoc0w4VXFubjBsZVJvTU9WZWs5TEhPQk1ZU0dLeUw2UUlVcHVQ?= =?utf-8?B?RTgyUHVOZEkyN0dEVDdzdVIrUzVmYldZWWJabEN2bklKWTlyVFpkNjJ3OTZ0?= =?utf-8?B?eEMzRVZ3QU44VkU5UzU3aHhycmFXOXUrcGFPdk8vZ2lMMTA4SzlKQlVCM1d2?= =?utf-8?B?ZCtKV0xmVmpLOW5nMjlmcUR2WnBpYW9kYmZ6d1RhVmQvV1N4enFiMFVBcEJw?= =?utf-8?B?NzlXMXg0UG5tZmpUM0x3bC96THJZSWtnRUdqSDN4bVV3WWhNb3lDOUtncndu?= =?utf-8?B?U2dBYnFMdlo1eDhGendKMzJhdFpnREZKTEN4bzNGNHVIemV3NlFDYUN2OGRN?= =?utf-8?B?MEh3a1hxbkp6MGNlYmhoSC9YR3JLdGc3REFGZ2krNmMrYkY0L0NtcUlyZWxv?= =?utf-8?B?bEpjZDQwSUFhTUxYQkFmOG5OS1E5Ni9VM2lvRUZCbExCUm9BQ3hjdTIwelFr?= =?utf-8?B?cGZPYVJQZlRUckxkS213ZkQxbnkyeVdKY1d2YXVUaHBROGIyOVlyRzh2ek1P?= =?utf-8?B?K0NaZzlVZ1NNcnZWNnA1Qm5oNnBtUEIyL1U1cmdqbmxxV1ordDM2Z0hJNDU1?= =?utf-8?B?Tm1RaitXeHBUN3JzUUlKUTUzVkJzSTQwRkZrZEZmMzRxcFFqblRyZEIxSHUx?= =?utf-8?B?SzNyYllpVjVQNEpiWlZMeDc1Y0YwRVcwanJIQkR3NWJQVEZWNndNMGZObW1r?= =?utf-8?B?VEZvRktFV1E2bytsM21Kc1luR1NUVWZnaWNKeFI1b1lvVDNIQkZYNWxCaklq?= =?utf-8?Q?rzFAMbYPmu1izq5w=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9f34d01-6694-4030-9979-08da3a4e3507 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:47:59.9772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AFStItaG6In2OlVwB3lUOzwieWFYMuS/afGqevvnJGsftA8Mo/2yNXfdeDmeVzKeA96oqw2eGyj4nbAYviFnNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3544 On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: > On 06.05.2022 13:16, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > >> --- > >> An alternative to the ASSERT()s added to set_iommu_ptes_present() would > >> be to make the function less general-purpose; it's used in a single > >> place only after all (i.e. it might as well be folded into its only > >> caller). > > > > I would think adding a comment that the function requires the PDE to > > be empty would be good. > > But that's not the case - what the function expects to be clear is > what is being ASSERT()ed. > > > Also given the current usage we could drop > > the nr_ptes parameter and just name the function fill_pde() or > > similar. > > Right, but that would want to be a separate change. > > >> --- a/xen/drivers/passthrough/amd/iommu_map.c > >> +++ b/xen/drivers/passthrough/amd/iommu_map.c > >> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > >> > >> while ( nr_ptes-- ) > >> { > >> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > >> + ASSERT(!pde->next_level); > >> + ASSERT(!pde->u); > >> + > >> + if ( pde > table ) > >> + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > >> + else > >> + ASSERT(pde->ign0 == PAGE_SHIFT - 3); > > > > I think PAGETABLE_ORDER would be clearer here. > > I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere > in IOMMU code afaics. Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not sure what's the rule for declaring that PAGE_SHIFT is fine to use in IOMMU code but not PAGETABLE_ORDER. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 10:49:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 10:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333788.557690 (Exim 4.92) (envelope-from ) id 1ns0Ck-0007OS-Iz; Fri, 20 May 2022 10:49:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333788.557690; Fri, 20 May 2022 10:49:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Ck-0007OL-G9; Fri, 20 May 2022 10:49:58 +0000 Received: by outflank-mailman (input) for mailman id 333788; Fri, 20 May 2022 10:49:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Ck-0007OF-07 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 10:49:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 962674e2-d82a-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 12:49:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF7E51477; Fri, 20 May 2022 03:49:55 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA1953F718; Fri, 20 May 2022 03:49:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 962674e2-d82a-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] build: Fix make warning if there is no cppcheck Date: Fri, 20 May 2022 11:49:42 +0100 Message-Id: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If cppcheck is not present, the following warning appears during build: which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found Fix this by hiding the error output from which and only try to execute cppcheck --version if we have a cppcheck. Reported-by: Julien Grall Signed-off-by: Bertrand Marquis --- xen/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 15388703bc..f42be3d0ab 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(call if_changed,cppcheck_xml) cppcheck-version: -ifeq ($(shell which $(CPPCHECK)),) +ifeq ($(shell which $(CPPCHECK) 2> /dev/null),) $(error Cannot find cppcheck executable: $(CPPCHECK)) -endif +else ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) $(error Please upgrade your cppcheck to version 2.7 or greater) endif +endif # Put this in generated headers this way it is cleaned by include/Makefile $(objtree)/include/generated/compiler-def.h: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 20 11:00:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333802.557702 (Exim 4.92) (envelope-from ) id 1ns0MW-0000ru-L6; Fri, 20 May 2022 11:00:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333802.557702; Fri, 20 May 2022 11:00:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0MW-0000rI-En; Fri, 20 May 2022 11:00:04 +0000 Received: by outflank-mailman (input) for mailman id 333802; Fri, 20 May 2022 11:00:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0MV-0000i7-MZ for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:00:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff461a37-d82b-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 13:00:02 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-6-KC4pYEg9NF-9S-lu0lS1Qw-1; Fri, 20 May 2022 13:00:00 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB2922.eurprd04.prod.outlook.com (2603:10a6:3:d6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 10:59:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:59:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff461a37-d82b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653044401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZFv3dkRCmDgbv3vPr0emUEmHt833Gm/SkUyB9U7gUVM=; b=KkxwdwsMQpdB6Qjb87N/CdPtWcG4gOLT0Vysh+LkmGm30tKHV+dfZtL3krWDpiQuFbQBrZ 3PnuiDit3avSSkAhwnV0cisgWwoprHtdoFEn0jAsKGopvhEEqEpKC+TExKdoxyt48+muz3 MjN9yMJb6/dkXN/5zc68PB4wdvbupeE= X-MC-Unique: KC4pYEg9NF-9S-lu0lS1Qw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kYcAUJOHRD+vE39qysGMJufUqohn1KgPzFLGmYk47Kwn7LyF4vfRl2iveMthjonFHycUmfPv6PXBCF6oCp++ADwmAJ9RHcbW/EJIAxqThhBPdOrtyrS+U5kbp3+P++Ksc46nwAiGAA8X6wFk/8oCxCCVMWgb4PvvC3mxncEI8FdP9hvWZF39hFvAqTIjlLNS02D8AIc82BllMp34wWiizgljPAdbwvrKvRfl1f6NJ4CLi9KzVF35To33QCJR3Xvux0jEeczbRllynjhBnF9Ict9jzzDH2gJJpbd8UYO9oYx6RQQUvUPjUiMtTRBA2PHw0kUp+ELKb63BUvl5F8dQiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBPen8ehI1NWnb+H18VZAfUdshQa698HDFzQAHBLScM=; b=WZAr3qvccuzT8WrkCN/iRoTtXxcC9oGg+qduZ/U3X/BvITaMY1sf4w3RcVODvEtzq6MO00ovFVk9sEpZ85lH3bFRbeawb5yBY8qSiK7Dr5sQiZQSLnpog2f1dbXUVGwCOJAIWebUuZE4bLO3bcbLmHQHH1646/SgwF4NSDKvW0F+Wqc7UKYJ9DDVi5oGIqKFj/9yqqU09vrD/JaH8yjkuEMVKqGfdGh2g9QZftfB0rmsu7bwLo82t4vk5Ns+vfYdTTc0xo+kLG9DjcEx7Z6ioI2kt9j8L7LcVjFK2ZHuRxOsCz1Zczei1LK6a6zSux/vQSAzL+CxW3q7HI9UzNn8Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 12:59:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <80487976-5d72-5388-139c-422210bca73b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0028.eurprd08.prod.outlook.com (2603:10a6:20b:c0::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc5b9e64-fdbe-4e94-223b-08da3a4fe0fd X-MS-TrafficTypeDiagnostic: HE1PR0402MB2922:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZgQYree/D5ndPIYI2LWfvLL7XA4k7c6eYH8f0EkFSRm9Yp8cdTPIxF2dJpFRl1gCFa1Ufy3VZU+l/TkRRC93jEArnGlmtrCTL34zfeytn0/ySNRNVJx0eRikOoV8uuAMyB4bLl4u0mlAwX0iNTetlc3dSc0Pxek+0Q7XG7SDZkbgnEd13qgaJaNFLOHpeIMfCowtD+TfEd+8a6TWbtDqen0RDt23BzwBh5l+ud4nhKRBhjWocDl042kTjkTPzQNKFiSgZYDFMuMtw8ZlVnsstzMC3D/6nCehFyT/r5HjwN6X7yZGwMSSX2Ebec1usHmu4q948qEM+nnCcY81FAuokerQztr27lKjAUuCguShYajKUkJD516jZxC+1qJHJ3O/HiawzTTG1LfGsnyAGVtNgdEZhHF0P0ZLHyz4dnT/afygSSJ1d8+Rn7XsgzcbW+eu3WeeTNeYrBWRgymvZKMjtzES96gF3W6xkxVwkXJYx/UQwM4q9GFGELd1e4DXeE9jN0Xb740jRirZf+M7K6AsNWn6brLsNRDm26XLKQjD5VEFGXNDQS/aCez/6s7JNZMP69fCmbmwic4UVqRmjJ4e7qEqJQKI83TclEanlnHQRaQ82WY5mbmIn5bp6HPN36BaUYYmp430rg7Xnn2hcXNn3EpkhUrxKaNRRAQgFwSR7dTr3AL49ILRM04hCh54r9TsKU+Sm767URtGtUGSmb6rYc7N8gw6aiTqo1oA9QBLtdc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(4326008)(2906002)(5660300002)(66556008)(66476007)(8676002)(83380400001)(316002)(6916009)(54906003)(36756003)(66946007)(31686004)(6506007)(6666004)(6512007)(53546011)(26005)(6486002)(186003)(508600001)(2616005)(31696002)(86362001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B6L6PHMd7uFSDEVkQ/rMWVCDxy2aCr4j/QDcBK1TWdt0ZC1GWkvTOomFYvqE?= =?us-ascii?Q?3s7XUtJWBXd58mj1C6+7FhFxX5IbTTKu5orMjgFaKR2kvOFyJ3jsgtupFbJL?= =?us-ascii?Q?1kKI00pFIjvYH3ENN+x6YLk7Ki70c8SRyqzWwKPC0S02VRC1b8/mde+br72d?= =?us-ascii?Q?SGubcWNn5rQ1GR81ijJtREbyKMcNX1TrQb4oY9ngOkLnf7Df1yWVwoN9AkkQ?= =?us-ascii?Q?bSKfEp4rdSYU/+Y2/suDXf6QcPv33wNdGj+JDYjNCFACvQG9wlEt1YFqzWSW?= =?us-ascii?Q?MYTbgT2oXpDRQM9Sja5TJ/lG5Hf3MjWRcVbzht4Yr55qIgagcX6C7uBe7t1Y?= =?us-ascii?Q?x9xI6A11PHLCYNfccDiKFFQE8Rtxa9TkJStsqFxjTCpSCBzChRCIn02AwugW?= =?us-ascii?Q?DiOiGCP1QFsxoXQ8B0QAX8DCWvDqAUI676bRlHeSH9+7+zsF27ty/v67QbOi?= =?us-ascii?Q?Ob47Nlf6ErGR+iQBB71EgIeIJDi6PqTQAOkiEAU/zpWJlqhDEp/urRMJ+Lrj?= =?us-ascii?Q?lDKxWAW9I9LFt+Vz/TKi/WJ+kQA/HLY6omWoWETYGE7RHkilENU8EBxXXdIo?= =?us-ascii?Q?44TfkOYGo2yaLguXPqlXiE5UcLoBHW+vK7gwRHvQpQHpoq9Cs5ud1KDz9Q09?= =?us-ascii?Q?QZGn+BH88O6tGlII0D/idhK/VlhfKosVOXqBOn50bpMAbKVQE5qgGolDgDKC?= =?us-ascii?Q?2Ame7u7chnUQ/apQCFtGxruxnqngesc8R1NYIujYDgEvnda0GrW1r7cgZviz?= =?us-ascii?Q?6fEIUIToDJ/UOo0szhOKb/P6H/wq5tPgaFRf2MTLQd25brqLHGuBFwW7TFuK?= =?us-ascii?Q?2mgqPeHtQ9YO8+PKy+Z3++AnllKHEO7iHviSCUyROGy6N7bTDOEiHAh+dBdB?= =?us-ascii?Q?AuKNIXupyYx/aMisOjN0N/fwXUqjZqZcpBaKEl3ftbOMhUkDpUfs/sakMxeY?= =?us-ascii?Q?1uNlWgemZCYIxeR6BYqu+uxNlV3UZFttnH4MrX1hfycJlxouKnbM4CuXb9q3?= =?us-ascii?Q?7tXN56WR1gjMwFJUlhq/GZUkn/gRCtsjJzxmANjuZz6FfzEB+pWeqiCsEK9N?= =?us-ascii?Q?8BEZRYtsU7oSVshNZ604UeUxFgcwfWF2GxHsTzRA0poQ2xyi6Keavxubk3WC?= =?us-ascii?Q?vRvEWxfIwS0Wroz0yIr5aYPtyoVe8suXDXhAN1NqqYpp1agaHkv9EtM8VA2f?= =?us-ascii?Q?bNYiFfL04cx9lVTIL2S5MTvfdgOQXgAyqBm5sRVg1oUXbNs5OBqomJyRQru6?= =?us-ascii?Q?AKq4HEJg1V6hQ33MWuc79R8q4/Uvwrtca1DITq2lyO4jUv3Y36ZSRHU7LmII?= =?us-ascii?Q?M+uhSa0RNJxp3eYBOIxkvLV7URd3iynj64z+tzaOtTHDEq1fxaQJ5qmnQls8?= =?us-ascii?Q?eJn+tEX8msCVdTa7hGTf/FCGHGd0r6MkjYpXyBOoGNGw3wDBkHjSulNQVbH8?= =?us-ascii?Q?9D7GakWjScrLP/CFBBDXmix2ijurxMjPQLBd7KqRRe323f20RVe0Y4ImN2UM?= =?us-ascii?Q?IdU++lOs7a1VQd6k8RQIEbZ64GVQPTi8UPQIXx7rS2LbEdFwm6x9sGdHrTva?= =?us-ascii?Q?uOW9pfpyIBqtdM56tZbGgDl5RDjaRtkpMLHK82kTUHVPULSNDelyiisnNpQU?= =?us-ascii?Q?JJr+53Lbm0aRj02KqQlQndOgfZORsc8PtaQQ1jvJGc1JQI7zu//JiHz3zd4Z?= =?us-ascii?Q?KLmaSflMV9U0SNUbJ8qhW1+/upUZVHMYuFYf39lIiQ4cabffvPh/M/c4vK20?= =?us-ascii?Q?oFlYL5B6jg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc5b9e64-fdbe-4e94-223b-08da3a4fe0fd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 10:59:57.9422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yDnn/Apvcw0tfRXD9+IxsxW7B+iz6LLS7aY1bk/8Ohv3F8S+Q6DjPtJzAg2E+LwRTdypwkyTiomT8evOuDRz/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2922 On 20.05.2022 12:22, Roger Pau Monn=C3=A9 wrote: > On Wed, May 18, 2022 at 12:06:29PM +0200, Jan Beulich wrote: >> On 06.05.2022 15:25, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: >>>> --- /dev/null >>>> +++ b/xen/arch/x86/include/asm/pt-contig-markers.h >>>> @@ -0,0 +1,105 @@ >>>> +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H >>>> +#define __ASM_X86_PT_CONTIG_MARKERS_H >>>> + >>>> +/* >>>> + * Short of having function templates in C, the function defined belo= w is >>>> + * intended to be used by multiple parties interested in recording th= e >>>> + * degree of contiguity in mappings by a single page table. >>>> + * >>>> + * Scheme: Every entry records the order of contiguous successive ent= ries, >>>> + * up to the maximum order covered by that entry (which is the number= of >>>> + * clear low bits in its index, with entry 0 being the exception usin= g >>>> + * the base-2 logarithm of the number of entries in a single page tab= le). >>>> + * While a few entries need touching upon update, knowing whether the >>>> + * table is fully contiguous (and can hence be replaced by a higher l= evel >>>> + * leaf entry) is then possible by simply looking at entry 0's marker= . >>>> + * >>>> + * Prereqs: >>>> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 >>>> + * contiguous bits (ignored by hardware), before including this fil= e, >>>> + * - page tables to be passed here need to be initialized with correc= t >>>> + * markers. >>> >>> Not sure it's very relevant, but might we worth adding that: >>> >>> - Null entries must have the PTE zeroed except for the CONTIG_MASK >>> region in order to be considered as inactive. >> >> NP, I've added an item along these lines. >> >>>> +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, >>>> + unsigned int level, enum PTE_kin= d kind) >>>> +{ >>>> + unsigned int b, i =3D idx; >>>> + unsigned int shift =3D (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SH= IFT; >>>> + >>>> + ASSERT(idx < CONTIG_NR); >>>> + ASSERT(!(pt[idx] & CONTIG_MASK)); >>>> + >>>> + /* Step 1: Reduce markers in lower numbered entries. */ >>>> + while ( i ) >>>> + { >>>> + b =3D find_first_set_bit(i); >>>> + i &=3D ~(1U << b); >>>> + if ( GET_MARKER(pt[i]) > b ) >>>> + SET_MARKER(pt[i], b); >>> >>> Can't you exit early when you find an entry that already has the >>> to-be-set contiguous marker <=3D b, as lower numbered entries will then >>> also be <=3D b'? >>> >>> Ie: >>> >>> if ( GET_MARKER(pt[i]) <=3D b ) >>> break; >>> else >>> SET_MARKER(pt[i], b); >> >> Almost - I think it would need to be=20 >> >> if ( GET_MARKER(pt[i]) < b ) >> break; >> if ( GET_MARKER(pt[i]) > b ) >> SET_MARKER(pt[i], b); >=20 > I guess I'm slightly confused, but if marker at i is <=3D b, then all > following markers will also be <=3D, and hence could be skipped? Your use of "following" is ambiguous here, because the iteration moves downwards as far as PTEs inspected are concerned (and it's b which grows from one iteration to the next). But yes, I think I agree now that ... > Not sure why we need to keep iterating if GET_MARKER(pt[i]) =3D=3D b. ... this isn't needed. At which point ... > FWIW, you could even do: >=20 > if ( GET_MARKER(pt[i]) <=3D b ) > break; > SET_MARKER(pt[i], b); >=20 > Which would keep the conditionals to 1 like it currently is. >=20 >> >> or, accepting redundant updates,=20 >> >> if ( GET_MARKER(pt[i]) < b ) >> break; >> SET_MARKER(pt[i], b); >> >> . Neither the redundant updates nor the extra (easily mis-predicted) >> conditional looked very appealing to me, but I guess I could change >> this if you are convinced that's better than continuing a loop with >> at most 9 (typically less) iterations. >=20 > Well, I think I at least partly understood the logic. Not sure > whether it's worth adding the conditional or just assuming that > continuing the loop is going to be cheaper. Might be worth adding a > comment that we choose to explicitly not add an extra conditional to > check for early exit, because we assume that to be more expensive than > just continuing. ... this resolves without further action. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 11:06:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:06:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333811.557713 (Exim 4.92) (envelope-from ) id 1ns0T1-0001z4-Iq; Fri, 20 May 2022 11:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333811.557713; Fri, 20 May 2022 11:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0T1-0001yx-Fz; Fri, 20 May 2022 11:06:47 +0000 Received: by outflank-mailman (input) for mailman id 333811; Fri, 20 May 2022 11:06:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0T0-0001yr-0O for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:06:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef6349a7-d82c-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 13:06:45 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-sLBo5shSPIiap29FWQu9kQ-1; Fri, 20 May 2022 13:06:42 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5008.eurprd04.prod.outlook.com (2603:10a6:803:62::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 11:06:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 11:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef6349a7-d82c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653044804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kxkD9SQPfX+XP4H2QDGmxtlXZBVelTA1FqvdYRuEKxU=; b=d8aHnxlQK9Kv1pVvCvrRUCHjdpAnPiwsrqSKBDpt9lyBShOZTHXrFlJWVf0MDKTV+SQBRi vNRD5DKgdRB/SbNs2MQBQiCWrdzXDE4UXGYi56QBVrG3XIT0vBe6P63UVhmoV8z094o8h+ oi+Yky+C59xzOEbOUHhGdwxdeRVUuHQ= X-MC-Unique: sLBo5shSPIiap29FWQu9kQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMKo826Y47jxoLHSxNOyR7qbB03g2OnjIn9tSiraheRtkAOKmRYthR9R4sdOfkfjsvBZRTH+yC854e6FlV8W4b5wxflz9n95SoxqkGOZlMsBAsvlNJvH8iG5mEWxTa/ztcvvS07um1Uw2gg/G4jGwfLLF2IB2RcSUjh0D6MqqrsWtYqj42Pyq/I33JO4WF4cXrSshWPpz6tL14JX+Nf8XVrlG5C7kGdfe7SLDPxIDA5UVP9c2jgydMDLpoiUkY7JunFxuVvcpqt7IY402wm1XgI8qtTZLeM1p5c+55KExdeU+Cw1c4hBf4vsu+7nQqANNxBY1fVVAWM7PDXHBAnmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kxkD9SQPfX+XP4H2QDGmxtlXZBVelTA1FqvdYRuEKxU=; b=Tpj3LoZP2BGmzGXoyCxoq6y1pJU2OHzaGJL4HYjmpvUoHRmtEJjFUHK/WPkuR9NQJ+d6J4hwkEWvdTuTjHt/nv/GQdeWzM4hHAlIYutUdnEbD9LV2V2gEC3UkT18P9UJup3cSFWbTsa7NPJ2qayFmQ8CTT3kbX+4kk2mpFrT+CvFOb6GrB1MjqrkJu5ac9Qq96S/VYNGrgYjCWokxDvbU8iY8V53v/S2xDwCe445K6Rgf7HhEPBMjUc+lD7C+eJ3DtOCq15OjpxuVAwy0AVK56DQGLa2poSHKUxxLiwN+FWEf0/fhi/mk99OnRbubJFUSA13Q34FpQ37RQz1imtICg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <739ac0c5-0c58-0e0f-ade6-5d48db5254c6@suse.com> Date: Fri, 20 May 2022 13:06:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] build: Fix make warning if there is no cppcheck Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> From: Jan Beulich In-Reply-To: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0505.eurprd06.prod.outlook.com (2603:10a6:20b:49b::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d23e65e-2e3b-4e2c-2292-08da3a50d061 X-MS-TrafficTypeDiagnostic: VI1PR04MB5008:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3S2kDNYWuz5LNkp/Q5YXkhFx8MEQjkeJ4UnNSTZMzlvWSRB7QaS3NNMABJ6g0uUIaico+XaIPTDhnU7OX4QvlMce91inU0vyFMK6Vgke1pSw6X1e4R+2W8pe5W3HEaZ9OaUyKWAMR+nPP1vR7Fnsb0y737kLNKX+LlRyNbbfSfH6YbaggU1wZapNzwa8UnTSMGTdifNbf76CG3bM7Dv6pPLpGZ8WTaJld4QQ4544nGEWj4vSnRjQW94SdEOlBPBcKU752XuCQhD55Hgt5EFlJSDSWAA+3kKe5h26kKUjU+zk2Z5IK5JJx91nOhpu4hrQfZF1Qk0HxkpjxI7M7Bp9HDinQhaQdVz1Gnso+xegm8Y+6SWpRpX7TbXIBpQ/pxw9y0ermEu7hxP0PBRfboWqnb2wzw1zNGIIQ5kMbVToWiusb6AU3mSKuiQrCELzyr9SAXGxeHCVmuD3yw3BZWXeBZLjQYJTe+7n3husPX6W7PKwHhlQNscpu2AF+ady8RkxjTufcJkPffWb49jNPx2KgB8Gu94MpVCsR1wCdqnjQ+Guu8xqtP6YCb+5kunO9TSupvQ7wi5sg01YEqcKq6vPehMFQUOhgVQEqi3Gf4uux+FQAFE9mrckxgOwEpcj9Od8GHUGkt2Z8BiSYer+AQ8ewx2NkxHi7VYoFRRbmYPAjrkbql1ScKhkrfJqPtioRx8iMue57kYDYnDXcAeU2ItBbxy8pitWUH557lzKUHZQp9LG8bf0jEQztfExDisNGYw6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6486002)(83380400001)(186003)(4326008)(6916009)(2616005)(53546011)(86362001)(31686004)(54906003)(6506007)(6512007)(26005)(316002)(2906002)(5660300002)(508600001)(31696002)(8676002)(4744005)(66556008)(66946007)(66476007)(36756003)(38100700002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFE1TFpJZlIrNUZxVm1KeEo5S2lJaFNMd2RGekRiMWJDNHcxenFWcmJnMzJW?= =?utf-8?B?dHVEQWFVUXVreDJqVXkwM0hsczcybThxcWxQREx5amVOcG9DaW80aUxsU01k?= =?utf-8?B?eldURWcyejF5U3ArTjBpSGdhWHVIRlZuakFkZ2RKZEU3cnkvOXJicTJNc0Jp?= =?utf-8?B?Tjh4d2Z0cGZsTTRaQnlmQjlGZVpvc0kvbWJhaG9hS0xRYW01V3VDZ2YwODlX?= =?utf-8?B?OXIvbFlKT2pwRFV6T3hsZGM0QitZSnhTQUFtRy9MaDR1TjY2UzlKUm5CbHpN?= =?utf-8?B?enhFbER4OGo5UU5kT0o3V1BlWWxtOXNTVmpnQWhpcjI2MnhYMTJNTndzWjlv?= =?utf-8?B?UXVrQVZhbGhQcSt3cTVVQlYrRFFMdzRST2VlSVZoa1RxcXZ0bk9mNTF2WWYx?= =?utf-8?B?NFZscWVlY2g5eEJNMzJ0ZXY0QzloS2N0SFJaMkZHZFVTMzlwbkd2dmtrKzk0?= =?utf-8?B?NHRXYUZ4dFpLbW1iVHh4NEllZkpROXhCeURZdE5VT1dIU0NzOXlnVHlCYVVG?= =?utf-8?B?MFdxNUhTVTJ0UkdYWkZ4SWxSQmNoTEd1VjFIMWVCazB1MFVEVWhjR0tFL0to?= =?utf-8?B?N3o4NS9tcGdTb3RJTE5ra2IwZHVSS2RoK0xjOUhTNnBXOTdyTnZPZTA2NUcw?= =?utf-8?B?TGFXL2ZMMVdWU3RxeG9QeVpCZGxja2diMWJCaFh2NmpyU2FPRUFFNEVCK24r?= =?utf-8?B?eE1RR2UyWVBnTzFyVG1CMUplMUtIdXpjSnVBR3cwTk51MnIwQXRpbjZqaWlM?= =?utf-8?B?QUtNaUhHUnBBd2czRWNGQXJqU2ZxRFZkS0xKN2l0U1p3SXZ3bmRZa3dHUU04?= =?utf-8?B?bUpwVW5JYXh3OXVyLzBvV21icHQzSlBzRUpzdlUrcGNLVDZrRm85WkFELzNS?= =?utf-8?B?c3E2bVlmMVVoaERLL3ZWWi9BdUU1MVAvZko5WnlraTFuRGFhYkx5cTE1TzRr?= =?utf-8?B?QzYyVWVydW9KMUMrZTVncnFZM012MFl1Z3IvcTBQUk1FcHh3ajJSMi9IOXpD?= =?utf-8?B?emVZQWZMZktQQkxXaGhzRWl5RUw0azJwUmlKM3ZmY1k2V3A2WG5qTVZTcWNQ?= =?utf-8?B?Y2JxbmF6NE4yWlZPTHZ3S0phSXRuK1ZEc044T1kzaDErVXAwMGFDelo1UzFB?= =?utf-8?B?RldvbTltcEZleGRGNXF1ZkpMUFdCU3hLN3ZsVXUwb1JmM2gvVk5FMTdxT0Vv?= =?utf-8?B?WUhKNitRZXBGK0g3bDk3MHNRMFQzUWNqMDhPUkwzV2ZKRmRHbGlTSll2OTN5?= =?utf-8?B?cllReWw0VHY1dFExamRUTlRXM3dlUkF5N291MWRvdkp3Q0VyWWNVSVZFZGVo?= =?utf-8?B?L1cxd0MybVE2Y1c3U21IWkVJY1hZSVFUd2lCQW9RdDYyb1REaEd3Y05VWHcy?= =?utf-8?B?Wm1ST3o2WkUxS0xFNUhNcmVZNmp0NThuQnVsSjJETlVZRmxxVzlqenZZQ1l3?= =?utf-8?B?ZzB2aytMblJ5WUhKK244akM1Uyt0MEtoUmM2aGZtc0lybzN1OG5jNEx5cW5l?= =?utf-8?B?bkduWTVYOC8xUmgwMnYvcDZjbHlhMzkrTjlibVJYdk4ySU9melhZdUZKRGRS?= =?utf-8?B?SnVvYjJDWStZd3I3VElLRHhJQVIreXVQd3dyVTNUSUhscGVtTHRHdDVRbjd4?= =?utf-8?B?NE1wOGM0NWFScFkxTnhsQXl3MUlQUEI4bGRGaEJXNnE1cGJrY3owTXVrM01M?= =?utf-8?B?aWd0ZjdRaUZEb1kvbFRNT28wYXQ3bTdlVmZwN3VrZ3VVbTk2QTdtRTAwb3pk?= =?utf-8?B?ZDNlVkNLaldjVHd5VlFqb05GKzNWakl6SE81a3NOMG5KWWV3NGRjeTNTUmpD?= =?utf-8?B?SWhzd3VpMitBMmNGWXdyRU5qcVZrUVlCRzR5c1lYS3BtY3MrRjZaU3dDOURY?= =?utf-8?B?MDNydkN2RmIvM2FHenlPRzNSMnhiNi9IOTVLeVVHSXM1LzdNYjJTNUlPa1pq?= =?utf-8?B?WG9JYUxlRjYwZ1VyYVh4MTVJa3RKQ3A0bTNZYUg0TENJYkt1Y284SjhWTEQ2?= =?utf-8?B?N2VISVlMUzRZRk9sZ2xNcTZrWVhCTU9ldHF4OElrRHJVRlhCMTlTd3RxNU1B?= =?utf-8?B?Q2o5M3R2U1cvL1dZRW1wSURiNm5HNlVraUZHbWM5aGZnVHRWRHg2NUl3b1pY?= =?utf-8?B?SWZmb1UrRlR4Z3Yya1lHaTBnWTl6bmZsV3YvQjlSVWNWbDhQS1F3Tzk2eGox?= =?utf-8?B?dkw4SlBLRms1aDk4SnEzV2VYem9xRTAyUW9JVFduQkJOdHdCMmUrdGU4K0Rl?= =?utf-8?B?dlpIM3d2SkNsYUQwcEJwYUZDQ0poOXR5cCtxSVBzS21UcFZQVTh1ZjJKNnV2?= =?utf-8?B?ZlE1eVZ0a0ZvaEp1Qm5rQkwxemNsNzBESFRVeGRYYVNObEFhUnJOdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d23e65e-2e3b-4e2c-2292-08da3a50d061 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:06:39.5574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: etEHsAro8HfcjMT+MtUYlK8F3s2Tuppql3jh0MYABnrh3hg50BnaGO6Qx0z3zV9jG9nEPOGaj/88N7h644o7Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5008 On 20.05.2022 12:49, Bertrand Marquis wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h > $(call if_changed,cppcheck_xml) > > cppcheck-version: > -ifeq ($(shell which $(CPPCHECK)),) > +ifeq ($(shell which $(CPPCHECK) 2> /dev/null),) > $(error Cannot find cppcheck executable: $(CPPCHECK)) > -endif > +else > ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) > $(error Please upgrade your cppcheck to version 2.7 or greater) > endif > +endif While I agree this will silence things, I still would prefer if you switched to $(if ...) inside the rule - there's no need to invoke the shell while parsing the makefile. Anything like this only needlessly slows down the build. Not by much, but it sums up. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 11:11:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:11:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333819.557723 (Exim 4.92) (envelope-from ) id 1ns0XV-0003Nr-5k; Fri, 20 May 2022 11:11:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333819.557723; Fri, 20 May 2022 11:11:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0XV-0003Nk-2n; Fri, 20 May 2022 11:11:25 +0000 Received: by outflank-mailman (input) for mailman id 333819; Fri, 20 May 2022 11:11:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0XU-0003Ne-KD for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:11:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95474714-d82d-11ec-837e-e5687231ffcc; Fri, 20 May 2022 13:11:23 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-UJpTS28OMGaW36TVJFZ2sQ-1; Fri, 20 May 2022 13:11:20 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6164.eurprd04.prod.outlook.com (2603:10a6:208:13b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 11:11:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 11:11:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95474714-d82d-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653045083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hhz/s9zEFt0Ndc7C3JnhAb0ewS7J+DJwnjc9vVXmIf0=; b=QkqLerxdKWP6EDuORDbRTudpKqfDcnmK7u1F58s/PBBy3/4+Hd4Heaxq0PEJxoDQAAjcP7 CMyS0uV5uQi7eEpkn5jMFEkkCR1SWf7NTU488omVLTtO7N0ViMhNYeCOAXJc7eMYrKBZI3 wroQjlBwWkxOqYpA5IGIunPP+R34kpk= X-MC-Unique: UJpTS28OMGaW36TVJFZ2sQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZUsHvv1VOBOXqAxcRP428vzAU6QlKmpvP11wFO08aETzwNHNbm9IRgcIJMEGIOSa4xPae9TXXmacXj12QM3n0cLqfkDy1UwHhr4cctiw7fgyx8LABNNTzODJQlM6uyyJ5T9eyw01KU6ae5CJy1m5MsoJ7ANvDamoKhN7SBkj4fHLvN8eWxmzyElOiQCTqxScAl/zRSQLEvfkEgZp55cfzUULA8+n0F2GoA7XVUSWf6b+PjdCHdqt22QnuCVRLFwbGZgKaOniwqa2LELB98p9Ed8Cvz3R4nuX2Bk7Sl5LcoMFTLAZgU250iPFWBKkeXfIKzu84EXBIkuoha3iTkarw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dz5rzOLMUT3rMOjAQV0OuVPbZxrRl3+om8PP8fPbGys=; b=YGWV04HXPCTjtaLz2ix83ABix5DKtmvCyMzzu1EerXrnhEFOD8SInZqpjVv/EYaQ+jBPkHyVo3HiXbPPBRRlaoDfIgdGGXXl8nnYCdhKVLq4JELlGR7hm7cM1IHW1JAdrm0li1ZQvvv1U8Wi7PgJv0DTJUBwyqCb8qDUMFj4g7nX2QO9koXTL//9rZ+fz28rAoiXm712iRrTIOyjR9lyrMcELcDw1Iu7OWuRYX2ulitTYNHRzwtuh80w65wdfHWchQFKRs1s3+CXdvdRmCLmfpC9uZ7BV4Q0UQo4MXMFOZ22GZBjnMU6XA6ZaHvZ/Tx3Az0MZgM34nh1uuhoQoC5aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> Date: Fri, 20 May 2022 13:11:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5P194CA0018.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e0f5869-3e77-4973-1fee-08da3a5176da X-MS-TrafficTypeDiagnostic: AM0PR04MB6164:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KdnSEdRQ3yxyZzFE9Zt3eW48/opYm6fJTwbuw84yvFii4i8eVpFewSm6RhEvUSKHesanvBkNQp93V7UCRty21UB1tuRV4f4Kg321fkeBvOzlHa+zFsBoXiirDRY2bWnXPWkrlY7YQQ5znySdFjqgc4x/NL5nlFQBeCTZ2Ug8jFDahAbfH+aw4n76iIBhDHxLUSuWq0jAmi8guG8TPG02uPOA65ha1MjSUMAurW+NSnpEMaw6Ckpr4kjO0eAh4JkyvcdWIzNzf52qdeyYDA8ESCym1fdHpSeIxwBEqrE+Yr01dF8EpIeL6AuSV/1tEI8zmFB1ATflpv27rapg9EowYexcZyfeL0HJy9KhLaQUc2bVV9flluQsD1C+mTwAXRHRO/UeXsL4XeCAfRYOmY8S3EkHfml/5WCpH3TUc3hvH9MR8eqPQ+NmaWne95H2wxCUY2gH+VK7x52c0x4LPwXmkRbYy+abg/i2yDEgMOmqTVl4f+qvi1vBhtQRHSi/BJ9BKlNOEQWUWo8vi2ExGsorvtr5izkOZDNMECOXMz9JrghURoMGfAlCkksxMWnM3KzpptPoUKehpBpF+cDvH6d53UsXJV19LPV1hhftE3c2GexRsiRD+TP3jQeWgY1dNC+tqeGKVZ+0LSFbWwotUxTQZtci+NqJ4AkXFmfiOYwAWoRnQffQ5uBc177wxEUlanxCmT+jC0XyT077gPBe22YmQwekzqovo3aY6OCHid9QP0vpaf3W3x2YhIIvV6m7gy49 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(53546011)(6506007)(6486002)(26005)(31696002)(508600001)(38100700002)(2616005)(86362001)(83380400001)(186003)(36756003)(66946007)(8676002)(66556008)(316002)(54906003)(31686004)(5660300002)(6916009)(8936002)(66476007)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D6SegEZyA9+Bkpqk9EVXFOCGrMdAXkqOR2HBu3JLTUQqbKwXwgA9vSoZIc4s?= =?us-ascii?Q?YS5AOXPkFf+skuzdcYoP1RDkmXWy3nXqPB+0zVvZuMDIPrRpyMDaIyY8ntR5?= =?us-ascii?Q?8XZO14wOTnno4kw82djTosZWKioK5CeNJrIy2TZV3si1ZfznUI+PumqdnoZ+?= =?us-ascii?Q?pOFEgnyPesT0no/tDVZw3wIwCijd8kXdEJ+2tQgKdLHFBDEw5OdQ7xvABnRT?= =?us-ascii?Q?eVyXiApItth/snx2vxtYCZ5OY8Mo35OXx49BiaXepAGt0gEq0aRyQqOXZt48?= =?us-ascii?Q?U93mHdif4I6/UL49K6/0KGXfh7gsqoK9W3n4oBrZ9Uv+bzMn7rhh9mk8yZMr?= =?us-ascii?Q?nnaW+WPQ1fwJaXl9cJ1/YH+qUBKKQ9eifX/izaK/Abfyc/7xOthg+NqJCQKL?= =?us-ascii?Q?emWGrBXPtohAPlGuEFoCpMA+A9JEvI1yByw3qd68Llq5eEhX8AemFWZzFrM2?= =?us-ascii?Q?Wk2UB4zJPnx2yooGuNAeHRHF6VR+Yph+tXZSGFllEdfzwpLUD+1Zo9kt9Ga6?= =?us-ascii?Q?+o9EfQb+kvIFy6E3Csj77CrWhs+Q5PrQNxTzFHlkJiSyKSyYAS9cmIjWI2EA?= =?us-ascii?Q?L4UXzubKmeTfVHXBSzxTXO4LiGszChf5x5qHNU+VDRCqrN0GlPK0yfUJfLHL?= =?us-ascii?Q?cyeGHWcXHhQtWvxu0SaJ6fUYRTDa3rrrMPiYxtGRFDKLVRso8nQ9rfdW9Pkt?= =?us-ascii?Q?a5MRe7oXRl5wlCWXIqKOUYQKvv/9hstmEUhHMTjAv8QKAoAOVwfSm4r/cMPt?= =?us-ascii?Q?2AKRmSgmcQSh2Ob/kgX8REwMOPuViEhVmfm3al3Ca6WHaU/nUwCnNqdL+vkh?= =?us-ascii?Q?qPRq26VfIBomwkGaHtKquvMQTQbmQHcWBrVrxTrM3E/CihxZmEA5y6jNWJzj?= =?us-ascii?Q?X39pvtSWLDiVmvRR28+5bzBQOY7MD8WcxnD9mi5VnXTbEhdTLXBHog4h3HeR?= =?us-ascii?Q?tW3OQZ79pCVJ3FAu5EwYa0ZIEOeYg8ZHk3hwXN4GtYcKhL8cLchGfOoJ9l2u?= =?us-ascii?Q?t+pURDX9jJ7b+NiPVXQMKb1SCDlLhxotIyKl9OCZLVpmi0+loeeYQJAmf08C?= =?us-ascii?Q?D5u7/d2ejMU4i2s9GvmEE4jpZKug492RUTkwSdDHj5N6ONRmhUyDCjMI4xw+?= =?us-ascii?Q?yajW8VZNZ+Pyv+MucO+Ah7GWP92lHKnvpljDDYbaqbb6cIvGD33XVgqPmDH1?= =?us-ascii?Q?ePuCrfaWzRX+t0gQ1ou3Pvo/HjDJ1bi8arUIj+1X6zxqIKEBUwnWe6aGxRNE?= =?us-ascii?Q?5+NhIcNTB+qBiZLD67TC+0Fdg0q+4+l42/NNGb59Rg1lz4y2e/XFPy5CBGbM?= =?us-ascii?Q?l4C4SreHES1U1i1XSMKgI0W6rHJ6al84UcU1hBySLElLFyISyU9Izw/u128W?= =?us-ascii?Q?NJQnMyla0ghGaHd0eTuhsWRvAq+Etvy8HWF4otSoWHVHUMNDbBnAfx+qBqZM?= =?us-ascii?Q?x9oXPo06xIsP/yrWrgfc3rMllNWXKPW5jet4XuHBDvVKjXoN5j700lKzAIeN?= =?us-ascii?Q?v4g28e746TdLOOAoXcZHgVKFl64MoB3AdEAGK4t8udtPy1sOL4FhQxJIkfNm?= =?us-ascii?Q?E4VFLCwBmoSOIl4QZNSoXVqBeX13xSbFJbDZBihN3n8cZxK6QOPVKH4vxR5R?= =?us-ascii?Q?HNVyrK3tzX9uEELxpQJC/NcNHyHTjdgy2o4Dp4OZiZO/XGwxG1IjGG0wsajx?= =?us-ascii?Q?8lvURO4TkUAmlEtM3bunYiokO+GKMfoCCbeIo/90nnMhQNKTwLY3+2QHjDa1?= =?us-ascii?Q?q2tMmv0CSg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0f5869-3e77-4973-1fee-08da3a5176da X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:11:18.8833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 82BwVuxv2odlxBXrTqdSIAIDojohcZ7gu98XMw3DssNmVfJlThQXR3HbCtm29duoPYFtjLko8z7jN+3y7fK41g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6164 On 20.05.2022 12:47, Roger Pau Monn=C3=A9 wrote: > On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: >> On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >>>> --- a/xen/drivers/passthrough/amd/iommu_map.c >>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c >>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >>>> =20 >>>> while ( nr_ptes-- ) >>>> { >>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >>>> + ASSERT(!pde->next_level); >>>> + ASSERT(!pde->u); >>>> + >>>> + if ( pde > table ) >>>> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table)); >>>> + else >>>> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >>> >>> I think PAGETABLE_ORDER would be clearer here. >> >> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhe= re >> in IOMMU code afaics. >=20 > Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not > sure what's the rule for declaring that PAGE_SHIFT is fine to use in > IOMMU code but not PAGETABLE_ORDER. Hmm, yes and no. But for consistency with other IOMMU code I may want to switch to PAGE_SHIFT_4K. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 11:13:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333827.557734 (Exim 4.92) (envelope-from ) id 1ns0ZP-000400-JN; Fri, 20 May 2022 11:13:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333827.557734; Fri, 20 May 2022 11:13:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0ZP-0003zt-GY; Fri, 20 May 2022 11:13:23 +0000 Received: by outflank-mailman (input) for mailman id 333827; Fri, 20 May 2022 11:13:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0ZO-0003zk-FS for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:13:22 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da754fe1-d82d-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 13:13:20 +0200 (CEST) Received: from mail-dm6nam08lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 07:13:08 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB4218.namprd03.prod.outlook.com (2603:10b6:5:59::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 11:13:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 11:13:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da754fe1-d82d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653045200; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=5Q2kUVgjhc6SdfnLcaT+I+SDSqsJBNkmCFpUhoc+p5c=; b=Zw+XRKZcW6rbjwcbIGEFlCPtp6q/JNBL/3H+UZQMBxhthQyKFIapP2fD q56uelnk3a0MKewdYComGVmxsUg5xUuVNOfjYT2jzibgAWY7Hnd43N/uR SJ4Jf3K2adoAADd6XpGZbXS8l8GgIdzRwTIF1pDyHm6+4moqe6+5qY3AL E=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 71150850 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6XzdqawNdWZIYmmknEt6t+c6xyrEfRIJ4+MujC+fZmUNrF6WrkUOy moYX26PaPqINGfwL4p3O4jn/BtUv8OAztA2SFRtqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY124DhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplt9+aTFckOYf3neUPejJaSwYiLZ105+qSSZS/mZT7I0zuVVLJm6krIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtacGOOWvLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamKmAA+A/NzUYxy2v04DRt7IDrCsWPa4bNdJ5QhWW19 32TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDVtDgWzWorXjCuQQTM/JTHvM77keRy6PSywefGmUACDVGbbQbWNQeQDUr0 hqFmo3vDDk34LmNEyrBr/GTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL /mxhHBWr90uYQQjjs1XIXivb+qQm6X0 IronPort-HdrOrdr: A9a23:tiZ+6asMi2pCLKv3zTpmFLEu7skC/4Mji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVeUiz9bUN1LNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJrJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUUHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0k9 gsfJ4Y0I2mdfVmHJ6VNN1xP/dfNVa9MS4kEFjiV2gPR5t3ck4klfbMkccIzdDvXqA0570Pv7 mEeG9klAcJCjfT4Iu1rdB2ziw= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71150850" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Va6bvB/lnXsrRzcqOYErSBNVTrhVU4yOB9LSlIH4TDXdUEIzwXqPkW39Cr0eCgd+Qd4psWMahPYKZTrLGyynLh5Yyx+9ZaqtS2coNXRaB5DUm4191ZjO59e9n/TAPg4JPLoqPMUrhyEnb1L2AqnpwpnZonsiYRArS/g1ndlcwL00Ny4279qnLKGGRYWx8SNAcYiGxCbCeYcWPWzzBm4kPXD0Rq6/BiNZ1El/J5Vh1tpfabRYSkm8e+v07ZCXpxv8MQm9v9TpiVIi8Wc8UUMNiIQKeIg2kjU7dAqTYoHzh8Ih1YfoEi3UDKnO/xEGP9ieIYzqATgE1S+JPJxGUOVzTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=++tL+1LepWkBGrq4ioGauRpSMuFcwSdyc//ZIqPvrss=; b=UoIywdX2wfNjSfnWK477/c9vJ/n8tUonJvQ01d0rJa59Oj2uoKIveZSEwALoOEl1dCkHP85mP2uTMCTjAMDpYxodSJhTLuzht8F6RYp2jmA/W1eJw/IrvUTOZ6CtHBYOdg8/khWuTgR2a4JMDtlPBmf2Jj8vM8SuKnreXe2Z2QyDzmqQ/WndnCHwNcA2ZR+FKOBimgJr3bSHGUML4ykRtFmXJFtOM189D+yhmvAWKDEZGs5VmCLopyZXY7DnXnKrEVXmlnl3zAGa1QqM9pY+E5VToA+GAi9DNTxZ9mR41mqBFDmx/WSy1WL4YLZkIpyG7ZNATQ6cilRYSrNFLLPk4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++tL+1LepWkBGrq4ioGauRpSMuFcwSdyc//ZIqPvrss=; b=RoWZ+s/2gght5vJTDOAm1fIm1AnDkFxWQVO2m0cdLkLklkwap6Y0TzzawrgXKPP5j2qKA0lHIs093DeynTWVzOvLZ/eFL4hmSCIHDklJtBiPEriwpksGISqOdVeP2SjpSVl6M1EeXgaaMqeldy5zspm7Zi3JwAIoGn/0YQS3urg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 13:13:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Message-ID: References: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> X-ClientProxiedBy: LNXP265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e41aa7b-417a-4994-d84c-08da3a51b728 X-MS-TrafficTypeDiagnostic: DM6PR03MB4218:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z5coAcIeZf2Nlo2TPNu5wVSip9iRs6q53xc2ElOjohtojNHb2maE3GeunAWu13IglJ3r1MIfZPZ3GO4J4jCUnHRT6F84gXRtP9C60PCyr5DGBoAMCIIoStWRW8RAzLgaIQHbKxTkmIns8vmp532bVCcK8yT74tTBvyZzF9w0pq5lwT/zgNiqUc5KKPWhx4SO7qdw8t0W4F85dgXUsQBIjSBJ9iCoVUDOpBSZdW4a1bPyXngKbI0n+ZlC4Q31jMqT1jis2Km5qdkT1B5aL4iNx1OV167nBe+XeshXv6Z7cw/peeyhhrw09B/0zrls4WpVMRsS5w8z/K+xtypZEYibPqCV34jw7RoSGrb9YSx2OxEkqtY48t7G60G1ijuOMEEDuS3eGyEH0CiiPtgtR828BMe+yCQ+eoLt7yZ+kw7ytzUUhVm4JRGW9wuRFgqNsUv+WObpyw93wr3b7Ry91mDNAL4dwiDFRqm2Yrmy1H9XuZnwXFyQrTDXcDQU/fDDjj1wTmyqApssIxdj2yp3mgKsNEPfbWqsyNNY7kkq5QwvO00uBaLiR6vawKPY43D0rBageVutmtkKM3Yxrh6BftGpx/jFkPTv6zk8bjLEmWVwjC0IMRI6+XTY2FVAhi65WU85br41Laa2BDX8jURPfDjXvA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(2906002)(6916009)(508600001)(5660300002)(4326008)(53546011)(82960400001)(66476007)(316002)(66556008)(66946007)(186003)(83380400001)(54906003)(85182001)(6666004)(86362001)(6486002)(9686003)(8936002)(6506007)(6512007)(26005)(8676002)(38100700002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekVjdDRBRTdMVllubHF4N1VWSlo4aHRndzZ2MjVDTG5jRWh1d3lkVXBSSTN3?= =?utf-8?B?aHpPcSs0UVA5WEtuVWh4b0N5dHlibWxpTlNlbUJoMTUxZEZMNXVwaVBJTU1S?= =?utf-8?B?cGI3WnhZWHl0NmlIdTRrQXh4Y3RJNEJ2R2tzdENwNmpWS3NkcGtqRmxqaWVr?= =?utf-8?B?ZUtxS2tESzdvRTQxck5PY0psR3dYemlXRlZnUkdETWRvSUhpbTVTb2ZEUlo4?= =?utf-8?B?WndZQWtMT2JaaHhTVkRlMzQrVWVmRGVLZmlSR2dUd3pNZ2RSeElINDcyMEwx?= =?utf-8?B?MWFuUHNBeDhVNk1tN1BsN1ZKL1NTazBHUm5kQSs1VytYZ3hiTjRFbENpTEx5?= =?utf-8?B?bmtCU1MvcGZla2pPWHZjMjNCaEl1a0NzL2F2K3NhVzFDdk1lYXNJeTNFOXRu?= =?utf-8?B?c1FRemMrREhONmFZLytnekZhTEVFWUNDNm9WbjQ5RDQ1Mlc0Y0RpUXAzU0Zq?= =?utf-8?B?MlkxN25wM3VOMDZ3Y0syL0s0US9wSzNrWmtSbU94WXZPTFhBZ3ZwOXFQQ0Z3?= =?utf-8?B?cnZEZE9Pc2NrNndMa0pscFJxWWxsU0s3QlpOeEcrQ1FYU28vbGtpc1A3aGtq?= =?utf-8?B?MHlGazdWQmI2KytaZVo1MStWbnlKQlA4RjlLR01uRFI3c1FXeDdxbVk2UExI?= =?utf-8?B?cmJBZFhrTXlZblBwb2M1Z0VZVEp5TGw3endXaGtXTi9VOVpkdEYwa01YRzV2?= =?utf-8?B?ajVBZXk4V1VLL3R5eExLUFdyQXdqM3ZIN00rYWxEM2tGL3R4SHhweVpFR1Np?= =?utf-8?B?K2phMFo5RnNlZVU3aERRVDBUK285UVlYcWdzUVc0SDJZZjViODJhVkErZmMr?= =?utf-8?B?YStwWkZjOHE2VXZxUzE1VThzbkJtbWR3cUI5aVZ4SDJ1NlhaWFpDZTBDb1VE?= =?utf-8?B?eDFqaFNROHJVLzF4UFRrYjlXRWNmeVJQbTZwNWw5b0pOUkdYL1RMTTdUVXlE?= =?utf-8?B?UjRCbm02bjBtK3YydTN2R2V5TEh1MXROUS9FYjAraTgwVTFjNFZUeHgrL1Az?= =?utf-8?B?dnRCUEFLcDJDT2psM1JLdDBTODNDVXJmN29oVXd1L3dyeTh6c01vRmdta1da?= =?utf-8?B?M1hoTmYzakthWWhXU0orcmdFc2pOR3NacTNOSmZxSnQ3OStNbTRGZTJuTWpK?= =?utf-8?B?WVZvL0JPOU5lOWRsMDQzM2UyM0lPbkE4eG52aVpvVlhPTHE0Ykk0NVFLYlVt?= =?utf-8?B?bWdsMGVNSElvMlFNSVlwaHh3YkJMa3ZiVFNaUGdtTThLQ2E1Nm5iZ2JzbTBk?= =?utf-8?B?VE5uWHlDc2pFYTJLVmlJUStYVlY4L3d4Wjd6bkFNWHlxeURWVWo2dExJditH?= =?utf-8?B?SEZCQkVPRUltY3NxblpTYURZd3NlQjF4Vm1QQkJHcGRpeHpIZGpJL1N2Z3lr?= =?utf-8?B?aCtwNkY2WGtKODl4WGFkUDc4bU8vTEtMUitlanFSeENVR0RuMS9wWDdJdWZG?= =?utf-8?B?NE5DeGVRVFd0Z1BmL3h3aUExSHdGVHBVRXdZZDZnRXAwMFpuTm85dXhRTWw1?= =?utf-8?B?WnhnUSsreFM4RWRWUDNJUERRd0Npc1o4ZEFML1hWSHZ1NDJ6ZHZpcmVmMGZH?= =?utf-8?B?dm9IcDRDVHVnU1NLV3JySzQ2RThORlZkcXJ5eWwzTlA3cXd3RVgvMnhqeDlQ?= =?utf-8?B?OHltV3haTm5DeC96YmJxa1Y2dk5hdFpIQW1SWmNJYzVFMldBcDNmaENzT3lr?= =?utf-8?B?TDAvcElyV0p6OFlhQ0lmQngxTE5aa0M1OFZhRElTL2s1dUpKRHA2WmMrL2w4?= =?utf-8?B?TGJ1dkUremZNd2JpTk85dDMzZXM5R3grdGRPdDNLQkN0UnM4amxJSFlGNmM5?= =?utf-8?B?Ti9VMG9udFJCKzNTVHpGbEYraDJxOVZseEZlTHU2bEVEaEk0SjRRd21GYThV?= =?utf-8?B?RkF2OXRTT1Y5VXJOdzVjazRvaTUvUjI1V2JxcXdxbnEwUXkwRkZ3RUFqOGxK?= =?utf-8?B?YjhoWEs3TFBkUS8xWksxTkx5YmU3bS9NQmpTcC9BNTJQekFic05Uc2JPWXgz?= =?utf-8?B?ZlBETTJSVWlkNUNJWStlK1RybVQrMy9pYzY1MWhMbEloQmVVUndrb0VnOHFo?= =?utf-8?B?TjFUQ2pIbGtiL0tPY1dqOHcyNUJUQitEU0ZrWFdpZzVGMVFnbVdRY3NTTFZG?= =?utf-8?B?T3ZqckcrNyt1ajVrZHA3bmVHQTk5STJSZHQzUlhMbC9zWEgvZkhjU1RSa3pI?= =?utf-8?B?b2VzVldrU3RXMEJ3MUcvSDlqNVNPcVpiWmVyRmNLcC9vcHBUR3A1NFF3Y0ps?= =?utf-8?B?VWZWMVMrODRYWmE4ZURuOWEvNFVaTkt4VXIwTUlWdmZWVGJzOVdwVFVzN1RK?= =?utf-8?B?NlRnL2JhTHVPbWR4TnkyNkJvREtGSXVqVk4zM3VRVThMd05vclBrQUtDbmIx?= =?utf-8?Q?qz/LpGkoCl3dJS4c=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e41aa7b-417a-4994-d84c-08da3a51b728 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:13:06.7109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Re1tQB6Xp+pGSQJAz40zAAvSHWhMus03LiLsoEDYFDsnJKuRps8pHABcFhcPXawiY5/GWONOWNYcd6b/eXJAHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4218 On Wed, May 18, 2022 at 12:26:03PM +0200, Jan Beulich wrote: > On 10.05.2022 16:30, Roger Pau Monné wrote: > > On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: > >> @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma > >> > >> old = *pte; > >> dma_clear_pte(*pte); > >> + iommu_sync_cache(pte, sizeof(*pte)); > >> + > >> + while ( pt_update_contig_markers(&page->val, > >> + address_level_offset(addr, level), > >> + level, PTE_kind_null) && > >> + ++level < min_pt_levels ) > >> + { > >> + struct page_info *pg = maddr_to_page(pg_maddr); > >> + > >> + unmap_vtd_domain_page(page); > >> + > >> + pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, > >> + false); > >> + BUG_ON(pg_maddr < PAGE_SIZE); > >> + > >> + page = map_vtd_domain_page(pg_maddr); > >> + pte = &page[address_level_offset(addr, level)]; > >> + dma_clear_pte(*pte); > >> + iommu_sync_cache(pte, sizeof(*pte)); > >> + > >> + *flush_flags |= IOMMU_FLUSHF_all; > >> + iommu_queue_free_pgtable(hd, pg); > >> + } > > > > I think I'm setting myself for trouble, but do we need to sync cache > > the lower lever entries if higher level ones are to be changed. > > > > IOW, would it be fine to just flush the highest level modified PTE? > > As the lower lever ones won't be reachable anyway. > > I definitely want to err on the safe side here. If later we can > prove that some cache flush is unneeded, I'd be happy to see it > go away. Hm, so it's not only about adding more cache flushes, but moving them inside of the locked region: previously the only cache flush was done outside of the locked region. I guess I can't convince myself why we would need to flush cache of entries that are to be removed, and that also point to pages scheduled to be freed. > >> @@ -2182,8 +2210,21 @@ static int __must_check cf_check intel_i > >> } > >> > >> *pte = new; > >> - > >> iommu_sync_cache(pte, sizeof(struct dma_pte)); > >> + > >> + /* > >> + * While the (ab)use of PTE_kind_table here allows to save some work in > >> + * the function, the main motivation for it is that it avoids a so far > >> + * unexplained hang during boot (while preparing Dom0) on a Westmere > >> + * based laptop. > >> + */ > >> + pt_update_contig_markers(&page->val, > >> + address_level_offset(dfn_to_daddr(dfn), level), > >> + level, > >> + (hd->platform_ops->page_sizes & > >> + (1UL << level_to_offset_bits(level + 1)) > >> + ? PTE_kind_leaf : PTE_kind_table)); > > > > So this works because on what we believe to be affected models the > > only supported page sizes are 4K? > > Yes. > > > Do we want to do the same with AMD if we don't allow 512G super pages? > > Why? They don't have a similar flaw. So the question was mostly whether we should also avoid the pt_update_contig_markers for 1G entries, because we won't coalesce them into a 512G anyway. IOW avoid the overhead of updating the contig markers if we know that the resulting super-page is not supported by ->page_sizes. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 11:13:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:13:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333828.557746 (Exim 4.92) (envelope-from ) id 1ns0Zb-0004LQ-Vh; Fri, 20 May 2022 11:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333828.557746; Fri, 20 May 2022 11:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Zb-0004LJ-Ri; Fri, 20 May 2022 11:13:35 +0000 Received: by outflank-mailman (input) for mailman id 333828; Fri, 20 May 2022 11:13:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0Za-0003zk-5z for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:13:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2d444d5-d82d-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 13:13:33 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-29-OpUeQ2gSOAuhBnwQHvJNEw-1; Fri, 20 May 2022 13:13:31 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6164.eurprd04.prod.outlook.com (2603:10a6:208:13b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 11:13:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 11:13:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2d444d5-d82d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653045213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eqM2RAFRgLy1ulHNW4ILE9U6rrTln1lD78nbV7TfMos=; b=B9aHBQ9C68s6Mal5CIvPiRhIgvO3aCmPNTlpMAgY6xqeAPOp83hJgPbu1iUOcXBDq7wp5t jCTJw8eCL29BIejH/MovYVZYozFYgkDCRFo19Yrsd4t9uM884mLpoIx6QCA65rxtkP2EnY 73mlWe87jmVOsBpgcbGVq5dLXPaKyiU= X-MC-Unique: OpUeQ2gSOAuhBnwQHvJNEw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlOLsP0sRKUdswaYY36+5zOxIqkPMN5BECiYoa0iY9gtNqCzdhGDbdyTFAGZcQWL+WdjkEAd5wa3XeAlVvUrbXYvdX2zu2UI8Cxy0BMFwhVvD6Ad6SYuepyZ7uyh7WW2KsyCIW0iqrTKJxkSlh6XgdY0vRGQnRmEU8Q7C0E7eNdD+Fb3CPbIkaJypKMIAqFLgW2zbRjo+pYiaAhWmwE0ICWqALIbN3nE56GKYwg0uOH3AOWWUyHBCqC1nBrEmwbUg40gWob2uukskcmFDM/Aaj1MscV9VSlascrXnOxwaVJNN+V37cXDkSAcJh53Q+l8JyQhz2PJXbiMfBNhuD/4Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKSeaHlzp1uOtHYT1aSDSk3o8Q4IC8Sv6L0kCrRoKHY=; b=UkRl4nLBVKek9cNeGAEoeFlwJBMnZoXObudOK5YJ28hqUbx40hZm53XKfAztVP5MpznTMlSLtQAaOAQ97tR3JXcjAv4H+XsBvGgZqOB8wEfFsGtwaRoVE7Mbj7b9Aa2v12c9CNvDgP/HJOBtOEuK93mV/7sTvjwUccFZOfxuzj3csIgtGevuK5cYvMOhyM3gF4N7KqP6K1lDJxK1i3nm4Pzh40oGNUYypnrn23r9O1aHfcUcaAQkajrco251EFd5Oe/8zPLJAV7xIaiIfEv5fO8CDz50GQV0BCzfTE5uuUCNYfFapeKxYVN87Rf0epUB5jRHqoYbDr4LP1eZRcoB3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> Date: Fri, 20 May 2022 13:13:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> In-Reply-To: <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0166.eurprd06.prod.outlook.com (2603:10a6:20b:45c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdbb5743-b5ad-4ef3-72b6-08da3a51c567 X-MS-TrafficTypeDiagnostic: AM0PR04MB6164:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c+ATQFURpUKgWAlpiQ5jfc66NmVccygVkxRWfKjy7UrA5RoTaZIvbfZoq9noAM/ipGosbWfe/QdMrI92c9pX/z76zzknp8ZVg6aaw+g5O99/465S8frM2+jVWNKNIRPNQcLcC8XYl/sUpEsacJ6Y3D1YFUwhJzxl1gNtxHemQFkBiAJavZtO8ZdFqJJ/WQE8i24k7H3rnEqbVi4kKTJAgzv/JtUmwXvV5bwUEb2HSsAjc5yOBoiVGcIjJm5z93/bxeNr3aOWqkihsAnVBGT2QrND24eUhnWewc79t4XLuBtz2YaFrboD/fNkyjTwgJ4nf3Cdwmv2wUU2fZsbHmPBjr/TnhA3uoPhq86gH6fsSbOHQq/xNjsZqf1VP9uHXCZXvGY9r/7DUsTk/oOKEhmXKZX0X7RKMiSOyMjEaq5W/vbSF2hkBSzc/Q9f5BwhPBwDRqh1QOXOKO0EbStdBDc2UP3zCat4wKNCkU2+RhXAhy151iLO1meJD4bm7er7WMRq5Vh+FrTP8Dvdd6E8QJ6PRQsJ/OBGfwxsE3CMBTnygau8fbd0O0UjkYkLgmQtbpwoWI+O+1gfSAlBie32unAryjt5UH8aHFwarYDBDdTXqwyfD6IU8u8wCRrkcBKKk10UJ+epLpdSRC0+UOkzUoXTNAUgNpALQHoQA+VFcsaLC8LUWkuEUcea+CzJDV08moDe+fc1cx0lUKP3VQIrBFihkiOY2P1leBgwptjU55kB85jWyXJjElvD9GjGzbCmCXXX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(53546011)(6506007)(6486002)(26005)(31696002)(508600001)(38100700002)(2616005)(86362001)(83380400001)(186003)(36756003)(66946007)(8676002)(66556008)(316002)(54906003)(31686004)(5660300002)(6916009)(8936002)(66476007)(2906002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wyjcY6CMvW8KVDxFFmJD1AtDmo5PoyODoaJ2r+P3+b0A3wl02oFzIvxZ8Uk1?= =?us-ascii?Q?YYn3QjRyhs37S3eP/4SvMBe6H/0Av6FoJ1Qljli3eTrfZ7wzZig71nv/W/O8?= =?us-ascii?Q?jxL0bOdQSS+N4K7d10pMvw4+Zkd+42hrph35KcQpfUJa/IKZATq6tXpYwrsu?= =?us-ascii?Q?HtGNVZGI9yjwHMrcqZ/Xbo3fRwZbezMonREmhdQnwP+/QEJ9Ai9EJ+6LdVgP?= =?us-ascii?Q?yA782rurMotbJ8Xq6W6V7uMgP0iwndXCxfMj9/3VzQse0nFzeC583dOlgJ9N?= =?us-ascii?Q?sFTXVVqmdTsmqOx0s9FwF1d3fSlVsz1sp2n1lBuAPFiJW+Cay6AGBLFNrLpN?= =?us-ascii?Q?qcxUuhP/y9L0wIQFQo52jso4bw7rnuQlp2di9ke04qSbFwcChrMYiKR8MK21?= =?us-ascii?Q?NmCuK3DDGite2/wB+bUgQbKNXNbcfecPv1Fs7WHhbDwStIXSeouZGQ/QUQdS?= =?us-ascii?Q?aWyBbHY1Zh5SLRHEBRrzvaoWVAvNaal5/9XZBmRQ95dK34QGWyPIVjqdHGY9?= =?us-ascii?Q?fplQu0c8AgAZ2hX9v3sicmhSfbypGgcIsWSGl7BxFnHlzV3FmHuuTarDZXyB?= =?us-ascii?Q?6YMnb/UW88ka8xXYCZW2kz0AGAWOQb4eaOSuOsVe8G4SGJL1Jfq5R/eLEbL6?= =?us-ascii?Q?JSipVeQzEJUPjz0hN7wS3fvoSqsug8MqGn9EnkTY1bG/U/R/b4dSgefGHQgX?= =?us-ascii?Q?yvZ8QuZxj6/Ft7RA4nDKW3R7KAuzJBCKhffZUw9H5XQAUqmfZouHeewphK4W?= =?us-ascii?Q?CNcwlziCSLycGuSJbKvitBsMZsHsTb2qDK6vtKuU5wv+JYaScqIZLF9t9dPT?= =?us-ascii?Q?No1PT6Ozlj2TQpQgT6bx9Fnb5P7F+KAndM1dRTHqGgHB2yAFDMv+luK6E5cU?= =?us-ascii?Q?egUnHvzXljnyaCXQwFj0p6lgeWWC96wMCniTNUTNVMzxsDNsJHa6bC4jsEtM?= =?us-ascii?Q?Xob7WS3wdkMJka8GWhHqqxgJeVawrLxXfvz6V8bkGkyZvjLat2iq1FOM4+p/?= =?us-ascii?Q?Zhi2xvaLwTE0eQRY0nR5d7z8w4Q0gwNYo1Vs3EOB2I1uK3W+tf87eZJScERl?= =?us-ascii?Q?rk+jm9ewBtydfz4h/WT/dDFrtoYC1IETQl8Tr8/g0rDE6kVH4JYYQyjF9sis?= =?us-ascii?Q?MsMTclwmJSDu/Zh0sYQEQGpO+U6g+usx+s3KHvjEUzKrByGMsy6KxSaVB5wm?= =?us-ascii?Q?Aupd3GSdEiPza09r7O4YILTVvoTRcnwhjJymaFMhP0nukrVePnknFWU5ntUo?= =?us-ascii?Q?+01KblgxuQAYhp5PeuS+pTAM/pKgFezVlH+MU0ZSVQv7GB7I/XrGist8ojJK?= =?us-ascii?Q?FZdtdyNt/eMWrPMK9ryW9veBgVvI/B3Hi8h7r9wCOoUAdDvb1+9SeEq29xF1?= =?us-ascii?Q?wkSc/caMtcz7reTRMLcTNr8dgtHAE7nOZ7H4XiFtGzvDihmdyLlbWkffsCv8?= =?us-ascii?Q?mOPLgyE7k6CdHztklQL8ZoJk7gCxaz5ztImlLpSiCIOJ+yL9axNTTJefbwMs?= =?us-ascii?Q?QR9APvoi31U1OOr5CkR1J5lr/gfpAh4i5QK9PgVZfQhdTTrGnv/wUidj1A/N?= =?us-ascii?Q?mcFuJDm0VJIulXWged4N/FL9enV+hjX4/7FCivV50xH2heTwH73qQKaBds7C?= =?us-ascii?Q?Qyy1eJje45gajzPWNJUtwdF+hyutqmWZ7IvsEPCT4iYHV3Jgy0j568VoaBs2?= =?us-ascii?Q?dWhsedM4aE5grseQ4C2nRg+Wqp7FoF4SKPBQFzi+vQP8SDfrBFfT1EU98MKq?= =?us-ascii?Q?2zDs0TcYfQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdbb5743-b5ad-4ef3-72b6-08da3a51c567 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:13:30.6405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zJ0R4t1BIfvRnCVApED6XjCn63kHMh5DuKXMMDoc19tw1ew8XytrcrgXq3An0/nOrk1w1XxomE6Ra1H1Xax8TA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6164 On 20.05.2022 13:11, Jan Beulich wrote: > On 20.05.2022 12:47, Roger Pau Monn=C3=A9 wrote: >> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: >>> On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: >>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c >>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c >>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >>>>> =20 >>>>> while ( nr_ptes-- ) >>>>> { >>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >>>>> + ASSERT(!pde->next_level); >>>>> + ASSERT(!pde->u); >>>>> + >>>>> + if ( pde > table ) >>>>> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table))= ; >>>>> + else >>>>> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >>>> >>>> I think PAGETABLE_ORDER would be clearer here. >>> >>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywh= ere >>> in IOMMU code afaics. >> >> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not >> sure what's the rule for declaring that PAGE_SHIFT is fine to use in >> IOMMU code but not PAGETABLE_ORDER. >=20 > Hmm, yes and no. But for consistency with other IOMMU code I may want > to switch to PAGE_SHIFT_4K. Except that, with the plan to re-use pt_update_contig_markers() for CPU- side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 11:25:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:25:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333845.557757 (Exim 4.92) (envelope-from ) id 1ns0kc-00067v-1H; Fri, 20 May 2022 11:24:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333845.557757; Fri, 20 May 2022 11:24:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0kb-00067o-U1; Fri, 20 May 2022 11:24:57 +0000 Received: by outflank-mailman (input) for mailman id 333845; Fri, 20 May 2022 11:24:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0kY-00067d-LR for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:24:55 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 776828f1-d82f-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 13:24:53 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1ns0jj-00Cb4k-Od; Fri, 20 May 2022 13:24:04 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 776828f1-d82f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DGPrrkXTp6oI8cbbgByz5QLKv15GNHxUgmjuIwTAy/E=; b=eqnE/suLTpG3xbkMCBtDpxLY3n NIRgLQiaBi0sCvdNCD4AFRLhJwRt1fDLW5HSSGFY7WXFEGFCYXn6Q0dC8gIFph3vTjXA6DvyBiQwz I5PwxVn4HFAkq1g0udGCDh7f8awWYDjllyLtGAcRh6eSoRE6OIuNpAwHVy7SfEQenDYcne2doKiCl jXXzZQlRm486qDYGQtQ0jW8Ms6RtpLdk65Qcz7YJ7/YEdFvKdb+dzF1Re9Q6nwXZnFrLVKgAD5Mwb LfHsy0RngN1antwERG5D/EtoEWfAXqtoLg2k7TzZKasJtkGm7zpf+kH+Fd2GGS1HnQh8pXfJiIePS VAbFF/9w==; Message-ID: Date: Fri, 20 May 2022 08:23:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: Baoquan He , Petr Mladek Cc: "michael Kelley (LINUX)" , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <20220519234502.GA194232@MiWiFi-R3L-srv> From: "Guilherme G. Piccoli" In-Reply-To: <20220519234502.GA194232@MiWiFi-R3L-srv> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/05/2022 20:45, Baoquan He wrote: > [...] >> I really appreciate the summary skill you have, to convert complex >> problems in very clear and concise ideas. Thanks for that, very useful! >> I agree with what was summarized above. > > I want to say the similar words to Petr's reviewing comment when I went > through the patches and traced each reviewing sub-thread to try to > catch up. Petr has reivewed this series so carefully and given many > comments I want to ack immediately. > > I agree with most of the suggestions from Petr to this patch, except of > one tiny concern, please see below inline comment. Hi Baoquan, thanks! I'm glad you're also reviewing that =) > [...] > > I like the proposed skeleton of panic() and code style suggested by > Petr very much. About panic_prefer_crash_dump which might need be added, > I hope it has a default value true. This makes crash_dump execute at > first by default just as before, unless people specify > panic_prefer_crash_dump=0|n|off to disable it. Otherwise we need add > panic_prefer_crash_dump=1 in kernel and in our distros to enable kdump, > this is inconsistent with the old behaviour. I'd like to understand better why the crash_kexec() must always be the first thing in your use case. If we keep that behavior, we'll see all sorts of workarounds - see the last patches of this series, Hyper-V and PowerPC folks hardcoded "crash_kexec_post_notifiers" in order to force execution of their relevant notifiers (like the vmbus disconnect, specially in arm64 that has no custom machine_crash_shutdown, or the fadump case in ppc). This led to more risk in kdump. The thing is: with the notifiers' split, we tried to keep only the most relevant/necessary stuff in this first list, things that ultimately should improve kdump reliability or if not, at least not break it. My feeling is that, with this series, we should change the idea/concept that kdump must run first nevertheless, not matter what. We're here trying to accommodate the antagonistic goals of hypervisors that need some clean-up (even for kdump to work) VS. kdump users, that wish a "pristine" system reboot ASAP after the crash. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Fri May 20 11:28:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333857.557768 (Exim 4.92) (envelope-from ) id 1ns0no-0006jS-GO; Fri, 20 May 2022 11:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333857.557768; Fri, 20 May 2022 11:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0no-0006jL-Cx; Fri, 20 May 2022 11:28:16 +0000 Received: by outflank-mailman (input) for mailman id 333857; Fri, 20 May 2022 11:28:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0nn-0006jD-2D for xen-devel@lists.xenproject.org; Fri, 20 May 2022 11:28:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee9e26d6-d82f-11ec-837e-e5687231ffcc; Fri, 20 May 2022 13:28:13 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 07:28:07 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB3043.namprd03.prod.outlook.com (2603:10b6:404:111::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 11:28:04 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 11:28:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee9e26d6-d82f-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653046093; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Gb4Paz7mlRR1t6gPuETGi5qsncvBztt0ZpDRZhOCyyc=; b=MV5ihEbHbK6C5Jada1NyT5O4bYdIvki0cSJDpPN21r32fP7BrVWBqI64 Pa8lJkBsGQn2sd5bXHIFE9vidu5VhfqO5/4KFQtRGkmgHeLalAaPGUXzV wgd9NEKdVVMD0YRZ8FSNBLgmr9hCdC7kgGDd8xfqvSRc1VTYEZgo0G2gQ g=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 74297645 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:P6JLSalj0fItB1tUUmPWPyvo5gz7J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZXj2EaauOZDfzKY9+bt7kphwP7ZKEmt82TwpurnhkQyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVvV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYVzUPFKrSmP4kWUNYOXxSN/VD4+7oLi3q2SCT5xWun3rE5dxLVRhzF6tIv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXtZkBg2pYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH9AjE+vRrvgA/yiRA06Doa8v0SuXUQNoPjkTJq E3/+EfAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUS9wWl2qfSpQGDCQA5oiVpbdUnsIo8Q2ws3 1rQxtfxX2Uw7fuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6 1i3QOIW3t3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:AR97pasoBbCLyd0w89rK2ugO7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="74297645" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cvTHf+TVuGk/FoHNXYW0y+9wjxrGpfBN5/b6n2KRWcqza6nb8PidQi2+u5s5crL93mbMB70A85niIPl3sMAzrGf+vOW5OePoi41Acj5D0IRPRdv9PXmN4GTkwoQtOF+zg5YC8xmMLs3w9Z93Ks10wjYtn2VReBuks89SH1VQ9MY3xPtTDqgrV2+FpORK1V6glN/bjoULtFZoOP7VjmPLweTuIcL3rqD0oSjLToGw+yY6tVHSGX2SMG62Ujt2U5zEEJzg1ajN2+i89FrSKp8fn4R1oIMFwqmiMkN97zVYlCPFAdyB5h2b4uX3KUdz8XeyQh4uiavHAYomm9EHUNa7wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EgJ/TOj0IFlk5oTaYicaTNHipKMiEfLk19bhZDp75aU=; b=f7FpQp9IDQBOEIIfCSKhPOMkZ2X2oY5MLoTxdujGyrYccEJQiCdgkHciUIhp4DmU+KUyoleKYI+pMCuZzYNrdXilhUHfftyjhqOixYVkC3DgXK3XBsJ2KFSUAztccFdn4a4GLmXS/WICn4ndoBjrGm785OCpBAUOCNDIKOv1cso9TThms5322k7ClGSJIL3Pz5fvb8WtOi1LiLY6lC0wwhztO3lip+oKVA+lIxCW7p3/BLI6pZKD1T9+HdB7xcVyaAt0d6NzB1zrmMg/l+ykm7QFZOKaEximdHsChPxhQPBBYxSJN5fElBXoa9WSCOqVlPAwaHuP1I/BmI7bmD+3Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgJ/TOj0IFlk5oTaYicaTNHipKMiEfLk19bhZDp75aU=; b=BfHf3pQJxLR3wENdZXyi4D2Z22ao0XUaCnnffCNNoGO/CnonwjyY4x9ze+8OHSTR4w9XGBWbC+nCSNOSn+16Ng3nJX9otUhtbMfDnE8xbVKD3AQ3DIbmqqAU9o/TZo/0f29s7Cbyq73a2J7v/fFHkDGGJ/dCMXMWDLU0GAX7wIM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 13:27:59 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 14/21] x86: introduce helper for recording degree of contiguity in page tables Message-ID: References: <80487976-5d72-5388-139c-422210bca73b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0253.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3789d0e4-79ff-4602-64ce-08da3a53ce0f X-MS-TrafficTypeDiagnostic: BN6PR03MB3043:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aWbazRo3uLAzCSv7/T/Yp+ktsn4DGPpNd/J7QjYquC2fF5lJ8HMO2/bGRjIjlCx8Ld9THt0pItEM4hXO/MlSk78YDlH0mger7vJPJpwWSMpjHVV9r/YJXIWH3gcTwI2D7mj2klvhOEdL0vhjgGuwwV8MKxABn7Cb/leuDjFPp8jT9ctVtdQGJ1dgl/E4FhwooN14u9fe/pzWoDcAOPLmF3F7iGjOzzkgQxSJicukrz7cwyTE/OrRS68iSNX7vQG28k5re/kx02UjRadHHBD/3shZPaHscCGDVTX3CAab2r7z1VKA5hrZGTLknlrBDODt6RSufqn27qZJGcPaVMFb91Slb9eg2JzJZFcDVTshC3/Fw0ouA7r+XODWqOFILyXN0AiMyQB9+bcVdPLoM7rK6yX30HlFlk88XLwNpRx1fIewcAzNRFAXoWOm425Ik5RO8QUAI+5ZDe+eEsyu8KJpeB9LcBj1dYAc/dHsArEr/VqEWTRpv9SSywLuLj40sH4QwJAeUtmrm+0HbAvkPwr9UIn6mhIEuBqEwwm9mtYMlZsjzoBXn/TG5SN1R/eX5jMep6iTDGnUJbcYrG/Hoda6pjT+mqPZY0lHvogp4FD1OZvfYDa19CkdBCg4lDWcbxPl2Zva+PqPhUC1mL7EUtX5YI7DJVL1oitzP7n2OVl7vvqTyapIj2DveDEJ567q4IcCyGRkx49VSK+uexSxeVWacw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(53546011)(38100700002)(316002)(9686003)(26005)(6512007)(2906002)(82960400001)(6506007)(85182001)(6486002)(6666004)(8936002)(8676002)(5660300002)(33716001)(86362001)(66476007)(508600001)(66556008)(186003)(66946007)(54906003)(83380400001)(6916009)(4326008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDYrVjNtZ05PdGdkbjJwcm0xQXh3UWxlMDl6bmNiUktIbnNxRjRpWFU1bGxl?= =?utf-8?B?VmFJWGg3ZDNYYUVxL2d6VWJnZStRYU5pVmNsbVVMWkRIeFoxdGltWERFQVhC?= =?utf-8?B?WGtKbGRXc0RyZE1PdjhQZDRRbnVTOHMrampRYUkzZ1FKR3Vmc0s1T1FDQXg3?= =?utf-8?B?RFBsMG1JY1BsZTNZam5lcC9jRGp4SXo3V3h5U0wwZjdDQXc1ZFNBdlFiVUsw?= =?utf-8?B?UVhtODgycmtmMmhyb2tkMkdlRy9wWDhYNDdYQm54NENmalI2eWdVYUZmdUFj?= =?utf-8?B?aGF3ci9EbmYrQ3BESXF2aXBzY1R6SUJIKzd4UEMxNmEyTjRzM3AwZ0VISloz?= =?utf-8?B?V1duQ21NVXNHTVhuY2ZEeGZRM2N0bU9nN2tPZkYzTFFiWElkZHdORTNRS1Bz?= =?utf-8?B?enBkUEs2Wm92OUttM0FRcXE3UHRDdDE2VUVDOVJRQW9heDUwZGpxR2czeXhK?= =?utf-8?B?ZTg3cnl4ZDUyNmVhY2I1TmV2ZTZpWGRCeUpMVzMzVXg5UVNtSlhNZHVUMkdO?= =?utf-8?B?Q3d2RndwaEUvUG1uS05IMUM1ZnpwblJPOElzeUdiQkgzbUZCVitkNlA0WXp3?= =?utf-8?B?ZkxzK1lkd3AwQk1ZN0p2QVN4Q1JzZXRsdUoxVjM3Unh6S1h5Z2QyT1Z6QW5l?= =?utf-8?B?czc3SHVQQ1FKTWZKSGxpMjh3UHF0YUVBbUhqWUVyQWc0TDRyYlhNK3cwTkpT?= =?utf-8?B?UXM0RCtoRWZMbm5UYWIwU1NheG9KQ2oyYmUwN1o0YUNGeVNaMm9oUDJGY0FT?= =?utf-8?B?VkVuYVpDQ0V1c0RuU0k4by9Kb2ZlaWtNSEFWWHF3SUUyd1FhMkhtSzMzU3dt?= =?utf-8?B?MGZyRlhUZ1p4bzQ2cXpEUm9NaVV6OVBScmd4RUxiZHYxVEJuUHJLSmVvSDBN?= =?utf-8?B?alo0NzBmd3VPTWVNdFg3QVlNbTFBWmdXa3FiZm42RHQveUZ4STRNV1pQNFB4?= =?utf-8?B?OWVkbDA4cTRRM0RmbEgzWXhpUXh0cktTL0hoZ05BMWx2UnZ4Q0NMRjRJNTVY?= =?utf-8?B?M25HMjRkTE1aUjJCSE50ZGxPTGxxV3YrR0t0dnhERHZnRE9wL0hKOWRkajBB?= =?utf-8?B?bkszdEZ4MXFuMHQ2b0ZDOEhlSDUvSzZLcTJXdzJHOEkrZFk1aG9ZQy9CM3hR?= =?utf-8?B?M0h3L3M5UFA1UEN1VHlCOHVkLzFHejZCSGVpQlRHVUJwc2xldk56TU4rUnA3?= =?utf-8?B?ellDMXlZdFBaSlFqTFNoTmRaRHlXMVg3M211UktQSjhDRjN2RitINmZyZHlQ?= =?utf-8?B?OWlRcmtXRXJRTlA4REIxQ00wZ0VwblVZekZVOVN4RGJGbzlrZTlLZ2dFMS9V?= =?utf-8?B?dnFxemhpQWhjYzdYUXNXeno2ajNzSE90Si9oQW9yMTdrRk9BbDFQWFZETFZN?= =?utf-8?B?M253U2EwY08xMkIvK2lyTjdkYzRiTGI3cjdWYysrMUFoNEIwZ0VtQzlMbldn?= =?utf-8?B?c2dRVW5yOE9DVU1nelpVRFl4WGFKakNyZ3EzN0FsTFNROEtXL2tYZFJlb04y?= =?utf-8?B?SjBTTFpZY3A5dlJnZENCMnR6WGdKSzVzS2NmM0d1OWxmd21vUlRTSUdNR1Fj?= =?utf-8?B?ZjFQTjJ3VHM1NGdYYW9Gam1CUldFVFRHSERyem1SV3gwR2w1cFRBajg0cDg0?= =?utf-8?B?UERybkxUSHpsbEJCaGp5MTQyeEZVQlMxNjZhbklZa2RoYnI2eExtM2JzSjJ4?= =?utf-8?B?SVhtdDdJUFUvbWozMHVpY2R6cnFiaThId2IxT2MzWi9DaWUza21jT2gxZkVn?= =?utf-8?B?cjJVNDJOYzlpS0QvUzVleEQzOGRHSFVycjRxeDNnMDVnOWYxZ1JsVE5uZWN2?= =?utf-8?B?ZlduRlVQLzZ1VFlXM3lJRDBZTXE3T2ZjYnNQemxjOVFCTmhIODlKZGJ1djU1?= =?utf-8?B?UlgwYzhQNGhBNWdHbUNwKzgwd3MvdkViakQvZ2RQMU1ERjRhSE5VM05FRWdB?= =?utf-8?B?WXYxVHJhdUxVUTNib3dNSUdtcVhySTk3R1lGVSt1N05DM2RvZDRVMEJFcmVH?= =?utf-8?B?dmZTQ21ZY3VjZWRzdXA3KyttdUJmRVlOcnNkaE5JOHJ3YUtNZjdFL0Z1UUxD?= =?utf-8?B?b1R1V2RCSmJUZEpLeXB5WW5wRjdkbFNMYlV1bHo1N0V5d0J6ZHdjMzRwUVpY?= =?utf-8?B?eWcrNjlub1lTaUZFVGlHdkdWYk5BWTVhaW9ScnVwTDU5ZWg4RHp4cTFTelkv?= =?utf-8?B?a1Z4OGRFZ0RwenpDMzZqZUt1YlY3M2Q0ZWNpK1hnV2tHLzM5N2gwa2ZWaUJv?= =?utf-8?B?QlNmTWF2YXNWa25PMGlCbTc2OXp3aHEwV3czNFgwVzFDT2MxNVNoV09YSlVF?= =?utf-8?B?NW1tNFBkQlhMK0ZJVHJxK0RERzdiQ050TUQzRlMzVHJQbEZKSjBIWVVLdE9m?= =?utf-8?Q?xOJOrA4TREmDWf7c=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3789d0e4-79ff-4602-64ce-08da3a53ce0f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 11:28:04.2033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SPEToBVlA0VoWTZXBLZTkMkCEPGFsHYvb30C2q2vyxeawofgBh2/6VcvDAsvFRdnhBqEicX5RYWEdzeQbbWNdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3043 On Fri, May 20, 2022 at 12:59:55PM +0200, Jan Beulich wrote: > On 20.05.2022 12:22, Roger Pau Monné wrote: > > On Wed, May 18, 2022 at 12:06:29PM +0200, Jan Beulich wrote: > >> On 06.05.2022 15:25, Roger Pau Monné wrote: > >>> On Mon, Apr 25, 2022 at 10:41:23AM +0200, Jan Beulich wrote: > >>>> --- /dev/null > >>>> +++ b/xen/arch/x86/include/asm/pt-contig-markers.h > >>>> @@ -0,0 +1,105 @@ > >>>> +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H > >>>> +#define __ASM_X86_PT_CONTIG_MARKERS_H > >>>> + > >>>> +/* > >>>> + * Short of having function templates in C, the function defined below is > >>>> + * intended to be used by multiple parties interested in recording the > >>>> + * degree of contiguity in mappings by a single page table. > >>>> + * > >>>> + * Scheme: Every entry records the order of contiguous successive entries, > >>>> + * up to the maximum order covered by that entry (which is the number of > >>>> + * clear low bits in its index, with entry 0 being the exception using > >>>> + * the base-2 logarithm of the number of entries in a single page table). > >>>> + * While a few entries need touching upon update, knowing whether the > >>>> + * table is fully contiguous (and can hence be replaced by a higher level > >>>> + * leaf entry) is then possible by simply looking at entry 0's marker. > >>>> + * > >>>> + * Prereqs: > >>>> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 > >>>> + * contiguous bits (ignored by hardware), before including this file, > >>>> + * - page tables to be passed here need to be initialized with correct > >>>> + * markers. > >>> > >>> Not sure it's very relevant, but might we worth adding that: > >>> > >>> - Null entries must have the PTE zeroed except for the CONTIG_MASK > >>> region in order to be considered as inactive. > >> > >> NP, I've added an item along these lines. > >> > >>>> +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, > >>>> + unsigned int level, enum PTE_kind kind) > >>>> +{ > >>>> + unsigned int b, i = idx; > >>>> + unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT; > >>>> + > >>>> + ASSERT(idx < CONTIG_NR); > >>>> + ASSERT(!(pt[idx] & CONTIG_MASK)); > >>>> + > >>>> + /* Step 1: Reduce markers in lower numbered entries. */ > >>>> + while ( i ) > >>>> + { > >>>> + b = find_first_set_bit(i); > >>>> + i &= ~(1U << b); > >>>> + if ( GET_MARKER(pt[i]) > b ) > >>>> + SET_MARKER(pt[i], b); > >>> > >>> Can't you exit early when you find an entry that already has the > >>> to-be-set contiguous marker <= b, as lower numbered entries will then > >>> also be <= b'? > >>> > >>> Ie: > >>> > >>> if ( GET_MARKER(pt[i]) <= b ) > >>> break; > >>> else > >>> SET_MARKER(pt[i], b); > >> > >> Almost - I think it would need to be > >> > >> if ( GET_MARKER(pt[i]) < b ) > >> break; > >> if ( GET_MARKER(pt[i]) > b ) > >> SET_MARKER(pt[i], b); > > > > I guess I'm slightly confused, but if marker at i is <= b, then all > > following markers will also be <=, and hence could be skipped? > > Your use of "following" is ambiguous here, because the iteration > moves downwards as far as PTEs inspected are concerned (and it's > b which grows from one iteration to the next). But yes, I think I > agree now that ... Right, 'following' here would be the next item processed by the loop. > > Not sure why we need to keep iterating if GET_MARKER(pt[i]) == b. > > ... this isn't needed. At which point ... > > > FWIW, you could even do: > > > > if ( GET_MARKER(pt[i]) <= b ) > > break; > > SET_MARKER(pt[i], b); > > > > Which would keep the conditionals to 1 like it currently is. > > > >> > >> or, accepting redundant updates, > >> > >> if ( GET_MARKER(pt[i]) < b ) > >> break; > >> SET_MARKER(pt[i], b); > >> > >> . Neither the redundant updates nor the extra (easily mis-predicted) > >> conditional looked very appealing to me, but I guess I could change > >> this if you are convinced that's better than continuing a loop with > >> at most 9 (typically less) iterations. > > > > Well, I think I at least partly understood the logic. Not sure > > whether it's worth adding the conditional or just assuming that > > continuing the loop is going to be cheaper. Might be worth adding a > > comment that we choose to explicitly not add an extra conditional to > > check for early exit, because we assume that to be more expensive than > > just continuing. > > ... this resolves without further action. OK, since we agree, and that was the only comment I had, you can add: Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 11:31:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333866.557779 (Exim 4.92) (envelope-from ) id 1ns0ql-0008C5-3d; Fri, 20 May 2022 11:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333866.557779; Fri, 20 May 2022 11:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0ql-0008By-0a; Fri, 20 May 2022 11:31:19 +0000 Received: by outflank-mailman (input) for mailman id 333866; Fri, 20 May 2022 11:31:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0qj-0008Bo-AZ; Fri, 20 May 2022 11:31:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0qj-00055z-8v; Fri, 20 May 2022 11:31:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns0qi-0000Vs-TF; Fri, 20 May 2022 11:31:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns0qi-00062T-Sn; Fri, 20 May 2022 11:31:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pqXdkw7K8ebBLSLbj35y9+6JWNiZzQzhjyWOMpV24b8=; b=cClrnlX0YQTPjRDNxT9giC23VD DCe9EOGr5WQtTlBdHJ8wMc4wf03Did8hwRXwAUompf2lt5BqqZJDRxjZWdbp1s8SbN0HVFW5x7Z6L pNlwizQcwxdUWY6piMitq6kktL3pr0gUCslBBU8UifS3eMQWVQDCg8QI5I6yTFgq9plw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170598: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 11:31:16 +0000 flight 170598 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170598/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1117 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 11:59:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 11:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333877.557789 (Exim 4.92) (envelope-from ) id 1ns1IC-0002F3-Cp; Fri, 20 May 2022 11:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333877.557789; Fri, 20 May 2022 11:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1IC-0002Ew-A6; Fri, 20 May 2022 11:59:40 +0000 Received: by outflank-mailman (input) for mailman id 333877; Fri, 20 May 2022 11:59:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1IB-0002Em-7f; Fri, 20 May 2022 11:59:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1IB-0005Xv-5T; Fri, 20 May 2022 11:59:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1IA-00019R-L0; Fri, 20 May 2022 11:59:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns1IA-00069l-KX; Fri, 20 May 2022 11:59:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y2ZYWK+IkonKfjF/FQuLxaxdzWQviX4M6IPaTUjtfJs=; b=6rMgP553GD8f6UPa0iobHIl3YB ZqvfTYuJolx2bnFAkqaZmIMjGEUiU4rNEqpbdwEbSfHohHIuCdzgll5OxXJ8UH+IIn8DCTHT0ioFe dcMKdQ3AJLuC8/jpnBNZhZIS4N4k+njnHeiYRe3lSrBF1xPGDa7d27O+9KeaAL8L4B7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170600: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 11:59:38 +0000 flight 170600 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170600/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1118 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 12:02:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:02:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333890.557801 (Exim 4.92) (envelope-from ) id 1ns1L7-0003hV-3J; Fri, 20 May 2022 12:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333890.557801; Fri, 20 May 2022 12:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1L7-0003hO-0M; Fri, 20 May 2022 12:02:41 +0000 Received: by outflank-mailman (input) for mailman id 333890; Fri, 20 May 2022 12:02:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1L6-0003hG-Cd for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:02:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1L5-0005dw-G8; Fri, 20 May 2022 12:02:39 +0000 Received: from [54.239.6.186] (helo=[192.168.4.58]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1L5-0001Bz-9j; Fri, 20 May 2022 12:02:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JwX0JobA4BMoA7jf56a/hJnolgRdRg60wpWgTWz9Ol0=; b=CVD8sMUJScaIsepiZBuDyUiIPM KD/9V14sCQBZNcWICtVMQUlLEIPCV1wS2mepPtCr5iKNQAnG1KcsLW+3Tzof0q9GHfgVMbZP2eLjG bky3jSGnfIq0+FQpbrQ5//K3+27uD4rwWzEOctcktSVa/H2lOE2u8WXnij4COIdADtbw=; Message-ID: <1c234dba-0b1a-49d6-e4c7-045c8bfda87f@xen.org> Date: Fri, 20 May 2022 13:02:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] build: Fix make warning if there is no cppcheck To: Bertrand Marquis , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> From: Julien Grall In-Reply-To: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 20/05/2022 11:49, Bertrand Marquis wrote: > If cppcheck is not present, the following warning appears during build: > which: no cppcheck in ([...]) > /bin/sh: cppcheck: command not found > > Fix this by hiding the error output from which and only try to execute > cppcheck --version if we have a cppcheck. > > Reported-by: Julien Grall > Signed-off-by: Bertrand Marquis This solves the warning so: Acked-by: Julien Grall In the long term, I think using what Jan suggested would be better. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333899.557833 (Exim 4.92) (envelope-from ) id 1ns1Sd-0005fH-F7; Fri, 20 May 2022 12:10:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333899.557833; Fri, 20 May 2022 12:10:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sd-0005es-Ah; Fri, 20 May 2022 12:10:27 +0000 Received: by outflank-mailman (input) for mailman id 333899; Fri, 20 May 2022 12:10:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sc-0005Sb-A9 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sc-0005n7-2i; Fri, 20 May 2022 12:10:26 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sb-0001lI-RB; Fri, 20 May 2022 12:10:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=G/yN/MMtss1f4FLjXsFIcnhjFW34XkVIM7A866pB5UU=; b=269d0/n+a5ZxknKGNjRNIHkykk ai0vXTeeOTqJUDLP2r/QRjhi54o7qkt8Rj9oncohm+yT7uow6nHpFMLeaHmbAG5S7cfGxfh3tJjhM 0DuQNlMIq3tBOW9rbRqshKDt28Cy+H2vPRG35KnPVM1X5+nw5ppchRD0URig3DQBXc/Y=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Hongda Deng Subject: [PATCH 02/16] xen/arm: mm: Add support for the contiguous bit Date: Fri, 20 May 2022 13:09:23 +0100 Message-Id: <20220520120937.28925-3-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall In follow-up patches, we will use xen_pt_update() (or its callers) to handle large mappings (e.g. frametable, xenheap). They are also not going to be modified once created. The page-table entries have an hint to indicate that whether an entry is contiguous to another 16 entries (assuming 4KB). When the processor support the hint, one TLB entry will be created per contiguous region. For now this is tied to _PAGE_BLOCK. We can untie it in the future if there are use-cases where we may want to use _PAGE_BLOCK without setting the contiguous (couldn't think of any yet). Note that to avoid extra complexity, mappings with the contiguous bit set cannot be removed. Given the expected use, this restriction ought to be fine. Signed-off-by: Julien Grall Reviewed-by: Hongda Deng Reviewed-by: Stefano Stabellini --- Changes in v4: - Add Hongda and Stefano's reviewed-by - Exit the outer loop as soon as there is an error. Changes in v3: - New patch --- xen/arch/arm/include/asm/page.h | 4 ++ xen/arch/arm/mm.c | 83 +++++++++++++++++++++++++++++---- 2 files changed, 79 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h index 07998df47bac..e7cd62190c7f 100644 --- a/xen/arch/arm/include/asm/page.h +++ b/xen/arch/arm/include/asm/page.h @@ -70,6 +70,7 @@ * [5] Page present * [6] Only populate page tables * [7] Superpage mappings is allowed + * [8] Set contiguous bit (internal flag) */ #define PAGE_AI_MASK(x) ((x) & 0x7U) @@ -86,6 +87,9 @@ #define _PAGE_BLOCK_BIT 7 #define _PAGE_BLOCK (1U << _PAGE_BLOCK_BIT) +#define _PAGE_CONTIG_BIT 8 +#define _PAGE_CONTIG (1U << _PAGE_CONTIG_BIT) + /* * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not * meant to be used outside of this header. diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index be2ac302d731..c4487dd7fc46 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1252,6 +1252,8 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt, /* Set permission */ pte.pt.ro = PAGE_RO_MASK(flags); pte.pt.xn = PAGE_XN_MASK(flags); + /* Set contiguous bit */ + pte.pt.contig = !!(flags & _PAGE_CONTIG); } write_pte(entry, pte); @@ -1304,6 +1306,51 @@ static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, return level; } +#define XEN_PT_4K_NR_CONTIG 16 + +/* + * Check whether the contiguous bit can be set. Return the number of + * contiguous entry allowed. If not allowed, return 1. + */ +static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, + unsigned int level, unsigned long left, + unsigned int flags) +{ + unsigned long nr_contig; + + /* + * Allow the contiguous bit to set when the caller requests block + * mapping. + */ + if ( !(flags & _PAGE_BLOCK) ) + return 1; + + /* + * We don't allow to remove mapping with the contiguous bit set. + * So shortcut the logic and directly return 1. + */ + if ( mfn_eq(mfn, INVALID_MFN) ) + return 1; + + /* + * The number of contiguous entries varies depending on the page + * granularity used. The logic below assumes 4KB. + */ + BUILD_BUG_ON(PAGE_SIZE != SZ_4K); + + /* + * In order to enable the contiguous bit, we should have enough entries + * to map left and both the virtual and physical address should be + * aligned to the size of 16 translation tables entries. + */ + nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; + + if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) + return 1; + + return XEN_PT_4K_NR_CONTIG; +} + static DEFINE_SPINLOCK(xen_pt_lock); static int xen_pt_update(unsigned long virt, @@ -1338,6 +1385,12 @@ static int xen_pt_update(unsigned long virt, return -EINVAL; } + if ( flags & _PAGE_CONTIG ) + { + mm_printk("_PAGE_CONTIG is an internal only flag.\n"); + return -EINVAL; + } + if ( !IS_ALIGNED(virt, PAGE_SIZE) ) { mm_printk("The virtual address is not aligned to the page-size.\n"); @@ -1348,22 +1401,36 @@ static int xen_pt_update(unsigned long virt, while ( left ) { - unsigned int order, level; + unsigned int order, level, nr_contig, new_flags; level = xen_pt_mapping_level(vfn, mfn, left, flags); order = XEN_PT_LEVEL_ORDER(level); ASSERT(left >= BIT(order, UL)); - rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, flags); - if ( rc ) - break; + /* + * Check if we can set the contiguous mapping and update the + * flags accordingly. + */ + nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); + new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); - vfn += 1U << order; - if ( !mfn_eq(mfn, INVALID_MFN) ) - mfn = mfn_add(mfn, 1U << order); + for ( ; nr_contig > 0; nr_contig-- ) + { + rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, + new_flags); + if ( rc ) + break; + + vfn += 1U << order; + if ( !mfn_eq(mfn, INVALID_MFN) ) + mfn = mfn_add(mfn, 1U << order); - left -= (1U << order); + left -= (1U << order); + } + + if ( rc ) + break; } /* -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333898.557823 (Exim 4.92) (envelope-from ) id 1ns1Sc-0005PE-5D; Fri, 20 May 2022 12:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333898.557823; Fri, 20 May 2022 12:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sc-0005P7-1Y; Fri, 20 May 2022 12:10:26 +0000 Received: by outflank-mailman (input) for mailman id 333898; Fri, 20 May 2022 12:10:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sb-0005Hy-9I for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sa-0005m7-V3; Fri, 20 May 2022 12:10:24 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sa-0001lI-JW; Fri, 20 May 2022 12:10:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=bZGPX4hXWWtjiKuU1/G3tIZ/8HOIH6yjg6x6XxicNi4=; b=NDIly0hgLKDaJXvQhwtnoWQMU0 kv5OKALIHsTD2RNWd11IEAkRLYEo8HFEV2c6RnyXP8gK1U8HpdPytmPJaVZV6ALuW0IFEuMNLJ+kp 0rBswn0mHO/CMrm/d3Oxflk3KHFzLNhVRgGmC5wgNCkGoJE8VYu6ZFahH0cjYNImNtoM=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Hongda Deng Subject: [PATCH 01/16] xen/arm: mm: Allow other mapping size in xen_pt_update_entry() Date: Fri, 20 May 2022 13:09:22 +0100 Message-Id: <20220520120937.28925-2-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, xen_pt_update_entry() only supports mapping at level 3 (i.e 4KB mapping). While this is fine for most of the runtime helper, the boot code will require to use superpage mapping. We don't want to allow superpage mapping by default as some of the callers may expect small mappings (i.e populate_pt_range()) or even expect to unmap only a part of a superpage. To keep the code simple, a new flag _PAGE_BLOCK is introduced to allow the caller to enable superpage mapping. As the code doesn't support all the combinations, xen_pt_check_entry() is extended to take into account the cases we don't support when using block mapping: - Replacing a table with a mapping. This may happen if region was first mapped with 4KB mapping and then later on replaced with a 2MB (or 1GB mapping). - Removing/modifying a table. This may happen if a caller try to remove a region with _PAGE_BLOCK set when it was created without it. Note that the current restriction means that the caller must ensure that _PAGE_BLOCK is consistently set/cleared across all the updates on a given virtual region. This ought to be fine with the expected use-cases. More rework will be necessary if we wanted to remove the restrictions. Note that nr_mfns is now marked const as it is used for flushing the TLBs and we don't want it to be modified. Signed-off-by: Julien Grall Signed-off-by: Julien Grall Reviewed-by: Hongda Deng --- Changes in v4: - Add Hongda's reviewed-by - Add a comment why nr_mfns is const - Open-code pfn_to_paddr() Changes in v3: - Fix clash after prefixing the PT macros with XEN_PT_ - Fix typoes in the commit message - Support superpage mappings even if nr is not suitably aligned - Move the logic to find the level in a separate function Changes in v2: - Pass the target level rather than the order to xen_pt_update_entry() - Update some comments - Open-code paddr_to_pfn() - Add my AWS signed-off-by --- xen/arch/arm/include/asm/page.h | 4 ++ xen/arch/arm/mm.c | 109 ++++++++++++++++++++++++++------ 2 files changed, 95 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h index c6f9fb0d4e0c..07998df47bac 100644 --- a/xen/arch/arm/include/asm/page.h +++ b/xen/arch/arm/include/asm/page.h @@ -69,6 +69,7 @@ * [3:4] Permission flags * [5] Page present * [6] Only populate page tables + * [7] Superpage mappings is allowed */ #define PAGE_AI_MASK(x) ((x) & 0x7U) @@ -82,6 +83,9 @@ #define _PAGE_PRESENT (1U << 5) #define _PAGE_POPULATE (1U << 6) +#define _PAGE_BLOCK_BIT 7 +#define _PAGE_BLOCK (1U << _PAGE_BLOCK_BIT) + /* * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not * meant to be used outside of this header. diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7b1f2f49060d..be2ac302d731 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1078,9 +1078,10 @@ static int xen_pt_next_level(bool read_only, unsigned int level, } /* Sanity check of the entry */ -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) +static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, + unsigned int flags) { - /* Sanity check when modifying a page. */ + /* Sanity check when modifying an entry. */ if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) { /* We don't allow modifying an invalid entry. */ @@ -1090,6 +1091,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) return false; } + /* We don't allow modifying a table entry */ + if ( !lpae_is_mapping(entry, level) ) + { + mm_printk("Modifying a table entry is not allowed.\n"); + return false; + } + /* We don't allow changing memory attributes. */ if ( entry.pt.ai != PAGE_AI_MASK(flags) ) { @@ -1105,7 +1113,7 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) return false; } } - /* Sanity check when inserting a page */ + /* Sanity check when inserting a mapping */ else if ( flags & _PAGE_PRESENT ) { /* We should be here with a valid MFN. */ @@ -1114,18 +1122,28 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) /* We don't allow replacing any valid entry. */ if ( lpae_is_valid(entry) ) { - mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", - mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); + if ( lpae_is_mapping(entry, level) ) + mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", + mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); + else + mm_printk("Trying to replace a table with a mapping.\n"); return false; } } - /* Sanity check when removing a page. */ + /* Sanity check when removing a mapping. */ else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) { /* We should be here with an invalid MFN. */ ASSERT(mfn_eq(mfn, INVALID_MFN)); - /* We don't allow removing page with contiguous bit set. */ + /* We don't allow removing a table */ + if ( lpae_is_table(entry, level) ) + { + mm_printk("Removing a table is not allowed.\n"); + return false; + } + + /* We don't allow removing a mapping with contiguous bit set. */ if ( entry.pt.contig ) { mm_printk("Removing entry with contiguous bit set is not allowed.\n"); @@ -1143,13 +1161,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int flags) return true; } +/* Update an entry at the level @target. */ static int xen_pt_update_entry(mfn_t root, unsigned long virt, - mfn_t mfn, unsigned int flags) + mfn_t mfn, unsigned int target, + unsigned int flags) { int rc; unsigned int level; - /* We only support 4KB mapping (i.e level 3) for now */ - unsigned int target = 3; lpae_t *table; /* * The intermediate page tables are read-only when the MFN is not valid @@ -1204,7 +1222,7 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt, entry = table + offsets[level]; rc = -EINVAL; - if ( !xen_pt_check_entry(*entry, mfn, flags) ) + if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) goto out; /* If we are only populating page-table, then we are done. */ @@ -1222,8 +1240,11 @@ static int xen_pt_update_entry(mfn_t root, unsigned long virt, { pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); - /* Third level entries set pte.pt.table = 1 */ - pte.pt.table = 1; + /* + * First and second level pages set pte.pt.table = 0, but + * third level entries set pte.pt.table = 1. + */ + pte.pt.table = (level == 3); } else /* We are updating the permission => Copy the current pte. */ pte = *entry; @@ -1243,15 +1264,57 @@ out: return rc; } +/* Return the level where mapping should be done */ +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, + unsigned int flags) +{ + unsigned int level; + unsigned long mask; + + /* + * Don't take into account the MFN when removing mapping (i.e + * MFN_INVALID) to calculate the correct target order. + * + * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. + * They are or-ed together and then checked against the size of + * each level. + * + * `left` is not included and checked separately to allow + * superpage mapping even if it is not properly aligned (the + * user may have asked to map 2MB + 4k). + */ + mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; + mask |= vfn; + + /* + * Always use level 3 mapping unless the caller request block + * mapping. + */ + if ( likely(!(flags & _PAGE_BLOCK)) ) + level = 3; + else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && + (nr >= BIT(FIRST_ORDER, UL)) ) + level = 1; + else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && + (nr >= BIT(SECOND_ORDER, UL)) ) + level = 2; + else + level = 3; + + return level; +} + static DEFINE_SPINLOCK(xen_pt_lock); static int xen_pt_update(unsigned long virt, mfn_t mfn, - unsigned long nr_mfns, + /* const on purpose as it is used for TLB flush */ + const unsigned long nr_mfns, unsigned int flags) { int rc = 0; - unsigned long addr = virt, addr_end = addr + nr_mfns * PAGE_SIZE; + unsigned long vfn = virt >> PAGE_SHIFT; + unsigned long left = nr_mfns; /* * For arm32, page-tables are different on each CPUs. Yet, they share @@ -1283,14 +1346,24 @@ static int xen_pt_update(unsigned long virt, spin_lock(&xen_pt_lock); - for ( ; addr < addr_end; addr += PAGE_SIZE ) + while ( left ) { - rc = xen_pt_update_entry(root, addr, mfn, flags); + unsigned int order, level; + + level = xen_pt_mapping_level(vfn, mfn, left, flags); + order = XEN_PT_LEVEL_ORDER(level); + + ASSERT(left >= BIT(order, UL)); + + rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, flags); if ( rc ) break; + vfn += 1U << order; if ( !mfn_eq(mfn, INVALID_MFN) ) - mfn = mfn_add(mfn, 1); + mfn = mfn_add(mfn, 1U << order); + + left -= (1U << order); } /* -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333900.557845 (Exim 4.92) (envelope-from ) id 1ns1Se-0005x9-Ro; Fri, 20 May 2022 12:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333900.557845; Fri, 20 May 2022 12:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Se-0005wQ-LS; Fri, 20 May 2022 12:10:28 +0000 Received: by outflank-mailman (input) for mailman id 333900; Fri, 20 May 2022 12:10:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sd-0005fF-Bv for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sd-0005o0-4E; Fri, 20 May 2022 12:10:27 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sc-0001lI-SC; Fri, 20 May 2022 12:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=cXnFYR1s5Y1jTbUV7oiOEy9M5vJYn4ZOPU2cNphW9n8=; b=IgB6/e2OpHBYymW363eOT6isR8 2ydHpuICXzkkbxiAC84pf2WJBrTBqgAGsd1CkUUupwhrlXwN2fabRLA8cnJAYeeKhFAXo5+Qg2cld wFlGWGnlQgfFqDDf4j6exrdOECLtgq4PzFaaGpidkEWaLdPyKeAqbbPjWft5fl7kvGqQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted Date: Fri, 20 May 2022 13:09:24 +0100 Message-Id: <20220520120937.28925-4-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Currently, the function xen_pt_update() will flush the TLBs even when the mappings are inserted. This is a bit wasteful because we don't allow mapping replacement. Even if we were, the flush would need to happen earlier because mapping replacement should use Break-Before-Make when updating the entry. A single call to xen_pt_update() can perform a single action. IOW, it is not possible to, for instance, mix inserting and removing mappings. Therefore, we can use `flags` to determine what action is performed. This change will be particularly help to limit the impact of switching boot time mapping to use xen_pt_update(). Signed-off-by: Julien Grall --- Changes in v4: - Switch the check to a different expression that will still result to the same truth table. Changes in v2: - New patch --- xen/arch/arm/mm.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c4487dd7fc46..747083d820dd 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1119,7 +1119,13 @@ static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, /* We should be here with a valid MFN. */ ASSERT(!mfn_eq(mfn, INVALID_MFN)); - /* We don't allow replacing any valid entry. */ + /* + * We don't allow replacing any valid entry. + * + * Note that the function xen_pt_update() relies on this + * assumption and will skip the TLB flush. The function will need + * to be updated if the check is relaxed. + */ if ( lpae_is_valid(entry) ) { if ( lpae_is_mapping(entry, level) ) @@ -1434,11 +1440,16 @@ static int xen_pt_update(unsigned long virt, } /* - * Flush the TLBs even in case of failure because we may have + * The TLBs flush can be safely skipped when a mapping is inserted + * as we don't allow mapping replacement (see xen_pt_check_entry()). + * + * For all the other cases, the TLBs will be flushed unconditionally + * even if the mapping has failed. This is because we may have * partially modified the PT. This will prevent any unexpected * behavior afterwards. */ - flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); + if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) + flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); spin_unlock(&xen_pt_lock); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333897.557812 (Exim 4.92) (envelope-from ) id 1ns1Sa-00059h-Sm; Fri, 20 May 2022 12:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333897.557812; Fri, 20 May 2022 12:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sa-00059a-PZ; Fri, 20 May 2022 12:10:24 +0000 Received: by outflank-mailman (input) for mailman id 333897; Fri, 20 May 2022 12:10:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sa-00059U-5U for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1SZ-0005lu-Lm; Fri, 20 May 2022 12:10:23 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1SZ-0001lI-Br; Fri, 20 May 2022 12:10:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=PfQdHha3NyDl+QbbUrGt+GR8CbRK1UHmtQoAcc4a784=; b=FcPNpO9ckqkCdhHITw729Ei3qR R8/nIoxBDcEWSOwKKfdPQ+1e8Gvcu4f84RTl37QvwXA/JXAp711pkVpVlde+4s3v7dCZsJqHqJsMg vpd9EZcQ9BIVpj8hRkoGvuBXH6lAFWfmvY1WJYoBmd9GOlkGYkI0JbHSHJ/ojC6xpNxg=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH 00/16] xen/arm: mm: Remove open-coding mappings Date: Fri, 20 May 2022 13:09:21 +0100 Message-Id: <20220520120937.28925-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, This series was originally sent as "xen/arm: mm: Add limited support for superpages" [1] and finally has grown enough to remove most of the open-coding mappings in the boot code. This will help to: 1) Get better compliance with the Arm memory model 2) Pave the way to support other page size (64KB, 16KB) Cheers, [1] <20201119190751.22345-1-julien@xen.org> Julien Grall (15): xen/arm: mm: Allow other mapping size in xen_pt_update_entry() xen/arm: mm: Add support for the contiguous bit xen/arm: mm: Avoid flushing the TLBs when mapping are inserted xen/arm: mm: Don't open-code Xen PT update in remove_early_mappings() xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen() xen/arm32: mm: Re-implement setup_xenheap_mappings() using map_pages_to_xen() xen/arm: mm: Allocate xen page tables in domheap rather than xenheap xen/arm: mm: Allow page-table allocation from the boot allocator xen/arm: Move fixmap definitions in a separate header xen/arm: mm: Clean-up the includes and order them xen/arm: mm: Use the PMAP helpers in xen_{,un}map_table() xen/arm32: setup: Move out the code to populate the boot allocator xen/arm64: mm: Add memory to the boot allocator first xen/arm: mm: Rework setup_xenheap_mappings() xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen() Wei Liu (1): xen/arm: add Persistent Map (PMAP) infrastructure xen/arch/arm/Kconfig | 1 + xen/arch/arm/acpi/lib.c | 2 + xen/arch/arm/include/asm/config.h | 6 - xen/arch/arm/include/asm/early_printk.h | 1 + xen/arch/arm/include/asm/fixmap.h | 48 +++ xen/arch/arm/include/asm/lpae.h | 8 + xen/arch/arm/include/asm/mm.h | 4 - xen/arch/arm/include/asm/page.h | 8 + xen/arch/arm/include/asm/pmap.h | 32 ++ xen/arch/arm/kernel.c | 1 + xen/arch/arm/mm.c | 494 +++++++++++++----------- xen/arch/arm/setup.c | 141 +++---- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/pmap.c | 72 ++++ xen/include/xen/acpi.h | 18 +- xen/include/xen/pmap.h | 16 + 17 files changed, 549 insertions(+), 307 deletions(-) create mode 100644 xen/arch/arm/include/asm/fixmap.h create mode 100644 xen/arch/arm/include/asm/pmap.h create mode 100644 xen/common/pmap.c create mode 100644 xen/include/xen/pmap.h -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333901.557856 (Exim 4.92) (envelope-from ) id 1ns1Sg-0006Fs-9T; Fri, 20 May 2022 12:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333901.557856; Fri, 20 May 2022 12:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sg-0006Fl-4S; Fri, 20 May 2022 12:10:30 +0000 Received: by outflank-mailman (input) for mailman id 333901; Fri, 20 May 2022 12:10:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Se-0005v8-Hk for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Se-0005oM-BP; Fri, 20 May 2022 12:10:28 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Se-0001lI-3Z; Fri, 20 May 2022 12:10:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=noAFzbg7XMXNKcoQy6EbRQkG8IRrJ9Zy042sIzuyylk=; b=JMmHBQf30UDfDEGdAOJclsCP2F MfBJ0ImN4oLdOXiZZmlAYP361G0+BY+p+TKwEIwLRK4yddh+z4yP/tcYuOt7yxiUAsGsf3XQBPwCv 9psvqC+wV5F5oe89mmB5JgLAhP+9RHy7QpMCX/jHvaDZoW7Ev1S0nszbujx5CneafAA8=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Hongda Deng Subject: [PATCH 04/16] xen/arm: mm: Don't open-code Xen PT update in remove_early_mappings() Date: Fri, 20 May 2022 13:09:25 +0100 Message-Id: <20220520120937.28925-5-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Now that xen_pt_update_entry() is able to deal with different mapping size, we can replace the open-coding of the page-tables update by a call to modify_xen_mappings(). As the function is not meant to fail, a BUG_ON() is added to check the return. Note that we don't use destroy_xen_mappings() because the helper doesn't allow us to pass a flags. In theory we could add an extra parameter to the function, however there are no other expected users. Hence why modify_xen_mappings() is used. Signed-off-by: Julien Grall Signed-off-by: Julien Grall Reviewed-by: Hongda Deng --- Changes in v4: - Add Hongda's reviewed-by - Add a comment to explain what modify_xen_mappings() does. - Clarify in the commit message hwy modify_xen_mappings() is used rather than destroy_xen_mappings(). Changes in v2: - Stay consistent with how function name are used in the commit message - Add my AWS signed-off-by --- xen/arch/arm/mm.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 747083d820dd..64a79d45b38c 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -614,11 +614,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr) void __init remove_early_mappings(void) { - lpae_t pte = {0}; - write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START), pte); - write_pte(xen_second + second_table_offset(BOOT_FDT_VIRT_START + SZ_2M), - pte); - flush_xen_tlb_range_va(BOOT_FDT_VIRT_START, BOOT_FDT_SLOT_SIZE); + int rc; + + /* destroy the _PAGE_BLOCK mapping */ + rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END, + _PAGE_BLOCK); + BUG_ON(rc); } /* -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333902.557867 (Exim 4.92) (envelope-from ) id 1ns1Sh-0006Wn-In; Fri, 20 May 2022 12:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333902.557867; Fri, 20 May 2022 12:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sh-0006Vv-Do; Fri, 20 May 2022 12:10:31 +0000 Received: by outflank-mailman (input) for mailman id 333902; Fri, 20 May 2022 12:10:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sf-0006BN-MN for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sf-0005oi-J4; Fri, 20 May 2022 12:10:29 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sf-0001lI-BC; Fri, 20 May 2022 12:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=cJm41f6bVbuh9BtVBTWvTK9jtgSvHumHceiTZgvegME=; b=kWMwtARSZEDeCPKM84SONgQCxm zSwLU3CORC3yppW+MV/MuXvyEq4yqQc09qGooh3xSJowT3/Rn+GB/LwJtWD53sn1o6CWX55Mvruh6 ukX8KEqaHtb/wQ2WkfgC0bjMLOB4+SdMVpp/VEb0Z4Nlxd5fERjFys57PmV9G8P+Xy+Y=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Hongda Deng Subject: [PATCH 05/16] xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen() Date: Fri, 20 May 2022 13:09:26 +0100 Message-Id: <20220520120937.28925-6-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Now that map_pages_to_xen() has been extended to support 2MB mappings, we can replace the create_mappings() calls by map_pages_to_xen() calls. The mapping can also be marked read-only as Xen should not modify the host Device Tree during boot. Signed-off-by: Julien Grall Signed-off-by: Julien Grall Reviewed-by: Hongda Deng --- Changes in v4: - Fix typo in the commit message - Add Hongda's reviewed-by Changes in v2: - Add my AWS signed-off-by - Fix typo in the commit message --- xen/arch/arm/mm.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 64a79d45b38c..03f970e4d10b 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -574,6 +574,7 @@ void * __init early_fdt_map(paddr_t fdt_paddr) paddr_t offset; void *fdt_virt; uint32_t size; + int rc; /* * Check whether the physical FDT address is set and meets the minimum @@ -589,8 +590,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr) /* The FDT is mapped using 2MB superpage */ BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M); - create_mappings(xen_second, BOOT_FDT_VIRT_START, paddr_to_pfn(base_paddr), - SZ_2M >> PAGE_SHIFT, SZ_2M); + rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr), + SZ_2M >> PAGE_SHIFT, + PAGE_HYPERVISOR_RO | _PAGE_BLOCK); + if ( rc ) + panic("Unable to map the device-tree.\n"); + offset = fdt_paddr % SECOND_SIZE; fdt_virt = (void *)BOOT_FDT_VIRT_START + offset; @@ -604,9 +609,12 @@ void * __init early_fdt_map(paddr_t fdt_paddr) if ( (offset + size) > SZ_2M ) { - create_mappings(xen_second, BOOT_FDT_VIRT_START + SZ_2M, - paddr_to_pfn(base_paddr + SZ_2M), - SZ_2M >> PAGE_SHIFT, SZ_2M); + rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M, + maddr_to_mfn(base_paddr + SZ_2M), + SZ_2M >> PAGE_SHIFT, + PAGE_HYPERVISOR_RO | _PAGE_BLOCK); + if ( rc ) + panic("Unable to map the device-tree\n"); } return fdt_virt; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333903.557879 (Exim 4.92) (envelope-from ) id 1ns1Si-0006pt-Uh; Fri, 20 May 2022 12:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333903.557879; Fri, 20 May 2022 12:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Si-0006on-Mv; Fri, 20 May 2022 12:10:32 +0000 Received: by outflank-mailman (input) for mailman id 333903; Fri, 20 May 2022 12:10:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sg-0006RM-RJ for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sg-0005p1-Jx; Fri, 20 May 2022 12:10:30 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sg-0001lI-CD; Fri, 20 May 2022 12:10:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=x8Bsa7TYWnNoGQK+pARdRdk5x9L3RhzgU3aFf8j8hqY=; b=rJ+xL3CzsAOPOmH5sEymKxEf41 Um7SI/EwztZBDG1lYa6DyX//+Zc4HQZ1V3wikCCqwDs2Hk6ZTwnlG/QMeooADUZWIrEQC6JmbjbeR S4fVs3EF0ODBNb2SzJMbQHhpfhJ4hWGBKu7gUS3rU4WLh0DafZOUOaz5P17/slZecjMg=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 06/16] xen/arm32: mm: Re-implement setup_xenheap_mappings() using map_pages_to_xen() Date: Fri, 20 May 2022 13:09:27 +0100 Message-Id: <20220520120937.28925-7-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Now that map_pages_to_xen() has been extended to support 2MB mappings, we can replace the create_mappings() call by map_pages_to_xen() call. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v4: - Add Stefano's reviewed-by Changes in v3: - Fix build when CONFIG_DEBUG=y Changes in v2: - New patch --- xen/arch/arm/mm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 03f970e4d10b..47c2111c36a4 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -825,7 +825,12 @@ void mmu_init_secondary_cpu(void) void __init setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns) { - create_mappings(xen_second, XENHEAP_VIRT_START, base_mfn, nr_mfns, MB(32)); + int rc; + + rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the xenheap mappings.\n"); /* Record where the xenheap is, for translation routines. */ xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333904.557882 (Exim 4.92) (envelope-from ) id 1ns1Sj-0006uT-D5; Fri, 20 May 2022 12:10:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333904.557882; Fri, 20 May 2022 12:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sj-0006sQ-16; Fri, 20 May 2022 12:10:33 +0000 Received: by outflank-mailman (input) for mailman id 333904; Fri, 20 May 2022 12:10:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sh-0006dX-SG for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sh-0005pF-L3; Fri, 20 May 2022 12:10:31 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sh-0001lI-DD; Fri, 20 May 2022 12:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=P+NWrrFhs3KxS6dDexgzIQNemrzeLTVuO4hodlzBMxc=; b=zpjOljw9eKfhAEkzKFoZ951lxC Lsinhm3LjaJqyo4Goz9AVjTRs64vMfo4jrGxslDEQIJxWNutHUQyzjHDO3hV09Ngp0NhBITbRafrt TiyAFlXDMbz93Yx3biv7GJXzfYXus1p+7GYdgi31lWg5fZilsgWfirwNXOk3sWsJ6fzY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 07/16] xen/arm: mm: Allocate xen page tables in domheap rather than xenheap Date: Fri, 20 May 2022 13:09:28 +0100 Message-Id: <20220520120937.28925-8-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall xen_{un,}map_table() already uses the helper to map/unmap pages on-demand (note this is currently a NOP on arm64). So switching to domheap don't have any disavantage. But this as the benefit: - to keep the page tables unmapped if an arch decided to do so - reduce xenheap use on arm32 which can be pretty small Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v3: - Add Stefano's acked-by Changes in v2: - New patch --- xen/arch/arm/mm.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 47c2111c36a4..252114d67df5 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -988,21 +988,6 @@ void *ioremap(paddr_t pa, size_t len) return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); } -static int create_xen_table(lpae_t *entry) -{ - void *p; - lpae_t pte; - - p = alloc_xenheap_page(); - if ( p == NULL ) - return -ENOMEM; - clear_page(p); - pte = mfn_to_xen_entry(virt_to_mfn(p), MT_NORMAL); - pte.pt.table = 1; - write_pte(entry, pte); - return 0; -} - static lpae_t *xen_map_table(mfn_t mfn) { /* @@ -1043,6 +1028,27 @@ static void xen_unmap_table(const lpae_t *table) unmap_domain_page(table); } +static int create_xen_table(lpae_t *entry) +{ + struct page_info *pg; + void *p; + lpae_t pte; + + pg = alloc_domheap_page(NULL, 0); + if ( pg == NULL ) + return -ENOMEM; + + p = xen_map_table(page_to_mfn(pg)); + clear_page(p); + xen_unmap_table(p); + + pte = mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL); + pte.pt.table = 1; + write_pte(entry, pte); + + return 0; +} + #define XEN_TABLE_MAP_FAILED 0 #define XEN_TABLE_SUPER_PAGE 1 #define XEN_TABLE_NORMAL_PAGE 2 -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333905.557896 (Exim 4.92) (envelope-from ) id 1ns1Sk-0007J8-M2; Fri, 20 May 2022 12:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333905.557896; Fri, 20 May 2022 12:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sk-0007Hy-CW; Fri, 20 May 2022 12:10:34 +0000 Received: by outflank-mailman (input) for mailman id 333905; Fri, 20 May 2022 12:10:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Si-0006rd-Vd for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Si-0005pW-PB; Fri, 20 May 2022 12:10:32 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Si-0001lI-HX; Fri, 20 May 2022 12:10:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=gimEip3VkLJRKnHAXm3TnqTrnKrLjfGvOIOXBXVQdRQ=; b=0Z94Mp5HwfpHEQTToAgWAdkw0B dl3gC1Pt7J4lRQn0guwGshH858PED22AWw97r9tRaPTJfwE71z0V3E2AIYSKwZx8dEhCkSBbwlEeW JVZ1usC0K8n8o8kgTOd0QR51IWhSsa3Ut81N1erIFaf7IVvvfSoydJkiKrfnkp8yy6IU=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH 08/16] xen/arm: mm: Allow page-table allocation from the boot allocator Date: Fri, 20 May 2022 13:09:29 +0100 Message-Id: <20220520120937.28925-9-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, page-table can only be allocated from domheap. This means it is not possible to create mapping in the page-tables via map_pages_to_xen() if page-table needs to be allocated. In order to avoid open-coding page-tables update in early boot, we need to be able to allocate page-tables much earlier. Thankfully, we have the boot allocator for those cases. create_xen_table() is updated to cater early boot allocation by using alloc_boot_pages(). Note, this is not sufficient to bootstrap the page-tables (i.e mapping before any memory is actually mapped). This will be addressed separately. Signed-off-by: Julien Grall Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v4: - Add Stefano's reviewed-by Changes in v2: - New patch --- xen/arch/arm/mm.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 252114d67df5..6b7b72de27fe 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1030,19 +1030,27 @@ static void xen_unmap_table(const lpae_t *table) static int create_xen_table(lpae_t *entry) { - struct page_info *pg; + mfn_t mfn; void *p; lpae_t pte; - pg = alloc_domheap_page(NULL, 0); - if ( pg == NULL ) - return -ENOMEM; + if ( system_state != SYS_STATE_early_boot ) + { + struct page_info *pg = alloc_domheap_page(NULL, 0); + + if ( pg == NULL ) + return -ENOMEM; + + mfn = page_to_mfn(pg); + } + else + mfn = alloc_boot_pages(1, 1); - p = xen_map_table(page_to_mfn(pg)); + p = xen_map_table(mfn); clear_page(p); xen_unmap_table(p); - pte = mfn_to_xen_entry(page_to_mfn(pg), MT_NORMAL); + pte = mfn_to_xen_entry(mfn, MT_NORMAL); pte.pt.table = 1; write_pte(entry, pte); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333906.557909 (Exim 4.92) (envelope-from ) id 1ns1Sm-0007jB-BH; Fri, 20 May 2022 12:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333906.557909; Fri, 20 May 2022 12:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sm-0007hO-3t; Fri, 20 May 2022 12:10:36 +0000 Received: by outflank-mailman (input) for mailman id 333906; Fri, 20 May 2022 12:10:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sk-0007Ji-HT for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:10:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Sk-0005pq-7b; Fri, 20 May 2022 12:10:34 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sj-0001lI-Vp; Fri, 20 May 2022 12:10:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=kU92uCk+wpW7sogs8vL65U0R39Ihu48YVjWuEhMIJGI=; b=ST0W8BXPufeABbx+NK2KIQ+a6D zZcLC2rI2uMKWUsWCFa3NCw8HODlm/LgTvSccCSKGbsd6QiyneZEjRbTQcxIIUC1eVtEe1vIe9rQB dFGCv0GyNGIkWafmiRAT25afqbw6Vb1de+xDeBeqwGaT5wBK69tY9aY04FSO3A8gmHbk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH 09/16] xen/arm: Move fixmap definitions in a separate header Date: Fri, 20 May 2022 13:09:30 +0100 Message-Id: <20220520120937.28925-10-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall To use properly the fixmap definitions, their user would need also new to include . This is not very great when the user itself is not meant to directly use ACPI definitions. Including in is not option because the latter header is included by everyone. So move out the fixmap entries definition in a new header. Take the opportunity to also move {set, clear}_fixmap() prototypes in the new header. Note that most of the definitions in now need to be surrounded with #ifndef __ASSEMBLY__ because will be used in assembly (see EARLY_UART_VIRTUAL_ADDRESS). The split will become more helpful in a follow-up patch where new fixmap entries will be defined. Signed-off-by: Julien Grall Acked-by: Jan Beulich --- There was some disagreement with Stefano on whether fixmap.h should include acpi.h or this should be the other way around. I chose the former because each components should decide how much entries in the fixmap they need and also because this is the current behavior on x86. We should stay consitent between arch to avoid any headers mess. Jan acked this patch, so I am assuming he is happy with this approach. I would be OK to rework it if others agree with Stefano's view. Changes in v4: - Add Jan's acked-by - Record Stefano's disagreement on the approach Changes in v3: - Patch added --- xen/arch/arm/acpi/lib.c | 2 ++ xen/arch/arm/include/asm/config.h | 6 ------ xen/arch/arm/include/asm/early_printk.h | 1 + xen/arch/arm/include/asm/fixmap.h | 24 ++++++++++++++++++++++++ xen/arch/arm/include/asm/mm.h | 4 ---- xen/arch/arm/kernel.c | 1 + xen/arch/arm/mm.c | 1 + xen/include/xen/acpi.h | 18 +++++++++++------- 8 files changed, 40 insertions(+), 17 deletions(-) create mode 100644 xen/arch/arm/include/asm/fixmap.h diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c index a59cc4074cfb..41d521f720ac 100644 --- a/xen/arch/arm/acpi/lib.c +++ b/xen/arch/arm/acpi/lib.c @@ -25,6 +25,8 @@ #include #include +#include + static bool fixmap_inuse; char *__acpi_map_table(paddr_t phys, unsigned long size) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index b25c9d39bb32..3e2a55a91058 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -169,12 +169,6 @@ #endif -/* Fixmap slots */ -#define FIXMAP_CONSOLE 0 /* The primary UART */ -#define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ -#define FIXMAP_ACPI_BEGIN 2 /* Start mappings of ACPI tables */ -#define FIXMAP_ACPI_END (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1) /* End mappings of ACPI tables */ - #define NR_hypercalls 64 #define STACK_ORDER 3 diff --git a/xen/arch/arm/include/asm/early_printk.h b/xen/arch/arm/include/asm/early_printk.h index 8dc911cf48a3..c5149b2976da 100644 --- a/xen/arch/arm/include/asm/early_printk.h +++ b/xen/arch/arm/include/asm/early_printk.h @@ -11,6 +11,7 @@ #define __ARM_EARLY_PRINTK_H__ #include +#include #ifdef CONFIG_EARLY_PRINTK diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h new file mode 100644 index 000000000000..1cee51e52ab9 --- /dev/null +++ b/xen/arch/arm/include/asm/fixmap.h @@ -0,0 +1,24 @@ +/* + * fixmap.h: compile-time virtual memory allocation + */ +#ifndef __ASM_FIXMAP_H +#define __ASM_FIXMAP_H + +#include + +/* Fixmap slots */ +#define FIXMAP_CONSOLE 0 /* The primary UART */ +#define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ +#define FIXMAP_ACPI_BEGIN 2 /* Start mappings of ACPI tables */ +#define FIXMAP_ACPI_END (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1) /* End mappings of ACPI tables */ + +#ifndef __ASSEMBLY__ + +/* Map a page in a fixmap entry */ +extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes); +/* Remove a mapping from a fixmap entry */ +extern void clear_fixmap(unsigned map); + +#endif /* __ASSEMBLY__ */ + +#endif /* __ASM_FIXMAP_H */ diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf28230b..045a8ba4bb63 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -191,10 +191,6 @@ extern void mmu_init_secondary_cpu(void); extern void setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); -/* Map a 4k page in a fixmap entry */ -extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes); -/* Remove a mapping from a fixmap entry */ -extern void clear_fixmap(unsigned map); /* map a physical range in virtual memory */ void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned attributes); diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 8f43caa1866d..25ded1c056d9 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -15,6 +15,7 @@ #include #include +#include #include #include diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 6b7b72de27fe..52b2a0394047 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -41,6 +41,7 @@ #include #include +#include #include /* Override macros from asm/page.h to make them work with mfn_t */ diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 39d51fcd01dd..1b9c75e68fc4 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -28,6 +28,15 @@ #define _LINUX #endif +/* + * Fixmap pages to reserve for ACPI boot-time tables (see + * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/fixmap.h), + * 64 pages(256KB) is large enough for most cases.) + */ +#define NUM_FIXMAP_ACPI_PAGES 64 + +#ifndef __ASSEMBLY__ + #include #include @@ -39,13 +48,6 @@ #define ACPI_MADT_GET_POLARITY(inti) ACPI_MADT_GET_(POLARITY, inti) #define ACPI_MADT_GET_TRIGGER(inti) ACPI_MADT_GET_(TRIGGER, inti) -/* - * Fixmap pages to reserve for ACPI boot-time tables (see - * arch/x86/include/asm/fixmap.h or arch/arm/include/asm/config.h, - * 64 pages(256KB) is large enough for most cases.) - */ -#define NUM_FIXMAP_ACPI_PAGES 64 - #define BAD_MADT_ENTRY(entry, end) ( \ (!(entry)) || (unsigned long)(entry) + sizeof(*(entry)) > (end) || \ (entry)->header.length < sizeof(*(entry))) @@ -207,4 +209,6 @@ void acpi_reboot(void); void acpi_dmar_zap(void); void acpi_dmar_reinstate(void); +#endif /* __ASSEMBLY__ */ + #endif /*_LINUX_ACPI_H*/ -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:12:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:12:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333961.557922 (Exim 4.92) (envelope-from ) id 1ns1US-0002ZD-8L; Fri, 20 May 2022 12:12:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333961.557922; Fri, 20 May 2022 12:12:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1US-0002Z6-5V; Fri, 20 May 2022 12:12:20 +0000 Received: by outflank-mailman (input) for mailman id 333961; Fri, 20 May 2022 12:12:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1TR-0007nf-Qi for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:11:18 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0625.outbound.protection.outlook.com [2a01:111:f400:fe0c::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f36115d6-d835-11ec-837e-e5687231ffcc; Fri, 20 May 2022 14:11:17 +0200 (CEST) Received: from AM6P192CA0080.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::21) by AM9PR08MB6241.eurprd08.prod.outlook.com (2603:10a6:20b:281::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 12:11:04 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::e8) by AM6P192CA0080.outlook.office365.com (2603:10a6:209:8d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Fri, 20 May 2022 12:11:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 12:11:04 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Fri, 20 May 2022 12:11:04 +0000 Received: from 1970b5736e44.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 32AA5BE6-03A9-402D-B852-239AD7719A31.1; Fri, 20 May 2022 12:10:57 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1970b5736e44.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 May 2022 12:10:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2344.eurprd08.prod.outlook.com (2603:10a6:4:87::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 12:10:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 12:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f36115d6-d835-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y1igTrvLoc+ELxafe9dopGEnKPYvtPn1BLEPWEY+SEnz4JAR7kIfypj3neQqo1QB2FjmjqhdvJ5uOfPkEH4pNHvdeJarhwPCdgQTPSRGTvRWR2SquOVO4+2x2SfSKWLMO84tboDCEp/NfwRzBaonp+CEUmPrcnJasIop7lUetoah/ivq9liG6AGT/lHOQjMnVquTXkT1hKXe2tK14ccr+N9siqBs2cYujAtSRGqCBa3YUwHhptoKWUaIv5P71YtDW+i6XqsqGXMPsJnDNWfrjd70ZjFUxuBWVUXg7F1aapWlQkcKF1xKsqmvTYB0yKWUbt2xT4+LyuaGPIYcQ1Erlw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=A9VyhjhXNrzs69ZCOCa6wZrPyr+VGxla81TM72T95+7rfWnALWrdpfUOEg8Z3vhG9IkdXX5ytjFGHqjFlcfRMGSRbFD3EEcSsTLPCwsPt2EAlI6151FUAW7y9YbOyFViBMS6JAxxiwSY4U+Cgk2xUY0fdV2bs//uXwH9a0sSnM4VR+AMIyRK6pGiU57ylSOUUDBmdPtEHC0rge5AjZcSGJnxnTtq0lwNeEuF9VGpmWNzP9zlldQQbOyy/gAjjj706cWjx4uwsGFR6oqq5DpjeWWfuFOdNCXPzfEnap0dlh9IIY0jYgtSJ7hChZnHB9AlrIn8oC3a0m6+rR3t4DRw+Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=yK0BcJbMd/4m9N0qa54JX0MUz4Ze8gpsIeYD/xFA0cqVSjhFBbxq+TWiFVztR9uPEo2vdc25kbHxF50Jc/XdSagMFI+jT3EBvWkB+tNzJVW3p5/oP3XGcDYnTwYHo+1v/3vP2HwCnjU/fsFRkh1dFKLWujRfLFn1mCZ7dvW4zL4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 476d27481ef1835c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EBkjvIorzCge3jmc+9vOYfG1qbp4Y9x9ngmIOGOuljgPGDTDSELsa2dSaRXtpuloZM4pZXO4i/dRmpNQY2WBBvNq0k0SeMtUFfmFkTVsGQ/5Nu5jls4kOGfHFdsX1betxa8kHsd8c8qhXg3wHkmr5IQTPjJOv0V3sXamoSzXofoTDn2vl+Pxzm2IhSXmmkSjKOe5XtEF+yQqg1G1JHFI2QSEavA96bNGD4ONZPT/wWBugz/q0HnZXvaiAE77hIsGKbXzrhceOq3T74yfm4ih1GYTk73cFR/A54xZIIhp/tuDvRpEAxVJh3fZ/xtC5gemEXVcmLqBIP7laT6xz0QgpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=cIsmfQm1th5Xfe6pSosSOGzCLZ6hbO7JW4/RqDCamywZnarVu7LFGPLrYGvLO1NrZ8PcHZDKxPjiM7uDXfQDmHSS4xudk2rxPOj9wWP0iy2vIw9tpZTm8pJlHpWjFIfkLc0p7Ahk7DU/J0GBP0pA/rzzqgcEnXdYqXsh0t+K/YTDqKmBLXrMiaonemXIjk3zkkbpbN43PmIlHFxcFKx82U1WAxTgliHe3WGepQjezklP4Yv/LRrV+3oTW9dOqtJT2GUDGdOvxR7zpXhyDNz9dNuJmkou+Fyo1R1aRM4xQRpfb6FOwZcj8MD2M+R/SgqbrYtMSYLLxO+mdkCTh/R/Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GhV4J4gc+JgRi2wv6n9qzrSo3gUycWcP4lSQ8bQmDhM=; b=yK0BcJbMd/4m9N0qa54JX0MUz4Ze8gpsIeYD/xFA0cqVSjhFBbxq+TWiFVztR9uPEo2vdc25kbHxF50Jc/XdSagMFI+jT3EBvWkB+tNzJVW3p5/oP3XGcDYnTwYHo+1v/3vP2HwCnjU/fsFRkh1dFKLWujRfLFn1mCZ7dvW4zL4= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] build: Fix make warning if there is no cppcheck Thread-Topic: [PATCH] build: Fix make warning if there is no cppcheck Thread-Index: AQHYbDdo2r5944WyY064u79v8h3JAa0nmuqAgAAR9IA= Date: Fri, 20 May 2022 12:10:54 +0000 Message-ID: References: <11fe35abe0a4cc79e6f7253d04ed12d951f1d09d.1653043632.git.bertrand.marquis@arm.com> <739ac0c5-0c58-0e0f-ade6-5d48db5254c6@suse.com> In-Reply-To: <739ac0c5-0c58-0e0f-ade6-5d48db5254c6@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2989100f-bdbf-427d-3b67-08da3a59d026 x-ms-traffictypediagnostic: DB6PR0802MB2344:EE_|VE1EUR03FT004:EE_|AM9PR08MB6241:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2cvA7VKVqVrevrp+a0S0jcimszFN5dSI162vpzHPttigVTgAtYTv/F2C5ZGj+8vJPxl8hVyYyWmth4Az3gP+HZW/UBgaYh9p5V5gcw6fR707p7jJB7yp7SB2hNWT2ImJsjdRN9SbevijD+0ZIlNrS5egjX36wcxsHaor5tOk6MoJm3ffbEQPrjJFKVlCWsWyJEDBePoNqiVg28QBJVYNW4+AtWDL+b7V6sEtZGJYhwvCJUGbTVmhPTk0xLx+B/cvk0DOqZR3uo5bHlJNSrFELECcUF5T3GetU4JAhxzgELXrq+aGGDopHGM331vu9ZDuvjrDrJuyAg/LT6naYcehk0MupEaJDCjJAubCb4oVc4GTnNNFkvYpuo1k3D/Omz1TKyX7n7KHNjavrnlZD585vzNMQCXZ7wv48CiCajEL14TtAm9dmMG9PGra5gtWQeT0FcAh4CJx4Ao6NOr8+s5vdCfUDQS7cxLyCNVDkF8fiJ6dkryyKMU2yRlEXTuCTRELeC5+iPr/mteMqZYYWJL2Uy/gVz9O6n3+3gFMIrE87L9Ge4uud5Mo2CQAjrly0m6qC0id7WY7mycL5TC82P83MdS5oIyllb0H9dEUhrzP7dbzDC/LesIQ6jz96UfqiQACjHsVhJitXiv20nsFWzcjm85l+ioTe+FD7Kxa0cON1ZuxdkNANSv0bGC3k4+/QsLfNJ232WndLhbcsNB5QaXgsJa/UEj5CYNVt15VJ/td29uBQ4j5jnLKiMG6dzBvv9Iw X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(66446008)(66946007)(66556008)(8936002)(91956017)(122000001)(64756008)(53546011)(316002)(2616005)(4326008)(54906003)(86362001)(6916009)(76116006)(8676002)(6512007)(26005)(6506007)(71200400001)(6486002)(186003)(33656002)(508600001)(38100700002)(4744005)(2906002)(36756003)(83380400001)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1370BBBD5BD68A469C68B40507280692@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2344 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ad59f10-4d3b-4b05-2230-08da3a59c9ff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wIxo+abHiW0XBD00tqre0ldEHX+up/qczhpBWbOahFEzELol6v7hVfZMbAF6Fgh0tt5PzK05e9xWpIUVwhuSF2giuIk/HybTWvLuGO9d+ZwRi9XjUy4uCdEposjlMNVb3CSo4wDRYdZy2rfxUY8Pi6kOS0iYXhdAfUfTRTZ8sTS7N7N3iP+hP/5FVHs2pHZ5YZPvbqFmbRCarJxKgGeQHNeJeJe7KRtmQdqTolHy3YxGnW48gfCOaOPdORI1ja0PIggba6nUixubsEkDuPEeXTC8iE//X8vlNRRfkJe/Uw0qBVAC+XV9w6ybaNuZ0PlyiFMm5Y0KR8WefHCklyV3GHeC3PlFAAawnCZ5an4G+pFaxZp2A96WmaUTP2eldPRuVGiK6T+nq5tNiTX25Merb/t46ywtUzoJ7v/K+KeDebILICc3/uS+R98LIdpGjICeycQzZXWyKjrqCSNJ138G+g4+CtEK3nu2EpIDPSBG4xLd7QqH3O49jaztGby56ntKGX7JScfowQauFuZmT45IsDXtprZjHAFtIE88+MtxOL2ZpE2O8LNrIR4qC23vYKd9F7HZWg9HfTVXOKI0Yi1B+iIVFOOsAGgX+swH4bOU4u3c5gTAqnxLN5Jb0WrBCNuQcgI5NEoh9yzXeQiv2MFqHGMCaMuEHoLNLPMxKik3sq5EQuku4QHxp+nwkfOzUpXH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36756003)(6506007)(26005)(86362001)(82310400005)(47076005)(6512007)(53546011)(356005)(83380400001)(2906002)(336012)(6862004)(5660300002)(81166007)(2616005)(4326008)(70586007)(186003)(70206006)(33656002)(8676002)(54906003)(8936002)(40460700003)(4744005)(316002)(36860700001)(508600001)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:11:04.3919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2989100f-bdbf-427d-3b67-08da3a59d026 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6241 Hi Jan, > On 20 May 2022, at 12:06, Jan Beulich wrote: >=20 > On 20.05.2022 12:49, Bertrand Marquis wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -694,12 +694,13 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)= /include/generated/autoconf.h >> $(call if_changed,cppcheck_xml) >>=20 >> cppcheck-version: >> -ifeq ($(shell which $(CPPCHECK)),) >> +ifeq ($(shell which $(CPPCHECK) 2> /dev/null),) >> $(error Cannot find cppcheck executable: $(CPPCHECK)) >> -endif >> +else >> ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) >> $(error Please upgrade your cppcheck to version 2.7 or greater) >> endif >> +endif >=20 > While I agree this will silence things, I still would prefer if you > switched to $(if ...) inside the rule - there's no need to invoke the > shell while parsing the makefile. Anything like this only needlessly > slows down the build. Not by much, but it sums up. I will submit a v2 to solve this properly. Cheers Bertrand >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333987.557937 (Exim 4.92) (envelope-from ) id 1ns1Wm-0003Qb-VY; Fri, 20 May 2022 12:14:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333987.557937; Fri, 20 May 2022 12:14:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wm-0003Po-SF; Fri, 20 May 2022 12:14:44 +0000 Received: by outflank-mailman (input) for mailman id 333987; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NG-Od for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wO-FC; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1So-0001lI-U1; Fri, 20 May 2022 12:10:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=mOn3zp5wUGYujSQe5FrNT0Pt6XF+4/RdAAfK0S+9m+Y=; b=cbG95IzqZm/2Lgg6aseyQY31Zd NlLO/aB0E6nWqkJ7QtRqxCA62EP19nQ6MA901oF2mCR+tRSTrLliDccxFa/oS1VwKUcvCTRrBnucP tocIDpjaz4VaPd1JbJPa7b2pUe2WURB4Tng+8mkJqFCcWVFFg3jhhUlmLd7qeihrrWSI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator Date: Fri, 20 May 2022 13:09:34 +0100 Message-Id: <20220520120937.28925-14-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall In a follow-up patch, we will want to populate the boot allocator separately for arm64. The code will end up to be very similar to the one on arm32. So move out the code in a new helper populate_boot_allocator(). For now the code is still protected by CONFIG_ARM_32 to avoid any build failure on arm64. Take the opportunity to replace mfn_add(xen_mfn_start, xenheap_pages) with xenheap_mfn_end as they are equivalent. Signed-off-by: Julien Grall --- Changes in v4: - Patch added --- xen/arch/arm/setup.c | 90 +++++++++++++++++++++++++------------------- 1 file changed, 51 insertions(+), 39 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed48a..3d5a2283d4ef 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -637,10 +637,58 @@ static void __init init_staticmem_pages(void) } #ifdef CONFIG_ARM_32 +/* + * Populate the boot allocator. All the RAM but the following regions + * will be added: + * - Modules (e.g., Xen, Kernel) + * - Reserved regions + * - Xenheap + */ +static void __init populate_boot_allocator(void) +{ + unsigned int i; + const struct meminfo *banks = &bootinfo.mem; + + for ( i = 0; i < banks->nr_banks; i++ ) + { + const struct membank *bank = &banks->bank[i]; + paddr_t bank_end = bank->start + bank->size; + paddr_t s, e; + + s = bank->start; + while ( s < bank_end ) + { + paddr_t n = bank_end; + + e = next_module(s, &n); + + if ( e == ~(paddr_t)0 ) + e = n = bank_end; + + /* + * Module in a RAM bank other than the one which we are + * not dealing with here. + */ + if ( e > bank_end ) + e = bank_end; + + /* Avoid the xenheap */ + if ( s < mfn_to_maddr(xenheap_mfn_end) && + mfn_to_maddr(xenheap_mfn_start) < e ) + { + e = mfn_to_maddr(xenheap_mfn_start); + n = mfn_to_maddr(xenheap_mfn_end); + } + + fw_unreserved_regions(s, e, init_boot_pages, 0); + s = n; + } + } +} + static void __init setup_mm(void) { - paddr_t ram_start, ram_end, ram_size; - paddr_t s, e; + paddr_t ram_start, ram_end, ram_size, e; unsigned long ram_pages; unsigned long heap_pages, xenheap_pages, domheap_pages; int i; @@ -718,43 +766,7 @@ static void __init setup_mm(void) setup_xenheap_mappings((e >> PAGE_SHIFT) - xenheap_pages, xenheap_pages); /* Add non-xenheap memory */ - for ( i = 0; i < bootinfo.mem.nr_banks; i++ ) - { - paddr_t bank_start = bootinfo.mem.bank[i].start; - paddr_t bank_end = bank_start + bootinfo.mem.bank[i].size; - - s = bank_start; - while ( s < bank_end ) - { - paddr_t n = bank_end; - - e = next_module(s, &n); - - if ( e == ~(paddr_t)0 ) - { - e = n = ram_end; - } - - /* - * Module in a RAM bank other than the one which we are - * not dealing with here. - */ - if ( e > bank_end ) - e = bank_end; - - /* Avoid the xenheap */ - if ( s < mfn_to_maddr(mfn_add(xenheap_mfn_start, xenheap_pages)) - && mfn_to_maddr(xenheap_mfn_start) < e ) - { - e = mfn_to_maddr(xenheap_mfn_start); - n = mfn_to_maddr(mfn_add(xenheap_mfn_start, xenheap_pages)); - } - - fw_unreserved_regions(s, e, init_boot_pages, 0); - - s = n; - } - } + populate_boot_allocator(); /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333986.557932 (Exim 4.92) (envelope-from ) id 1ns1Wm-0003O4-ML; Fri, 20 May 2022 12:14:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333986.557932; Fri, 20 May 2022 12:14:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wm-0003Nx-JZ; Fri, 20 May 2022 12:14:44 +0000 Received: by outflank-mailman (input) for mailman id 333986; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NF-Od for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wQ-Gq; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Ss-0001lI-7T; Fri, 20 May 2022 12:10:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=7kkcUtTj63g7Kwg1pXZqqsSOsowp6Vr0NeH5tERRvKE=; b=Y/a0/6lqiOd+ENWCW26KMos1CT IaBH4JCumNkQJzAc5WJwRhRuYudmnr30I+g1PGh1IbPw6S5ql5Jyur0RS7RrTsGnnCCUugQmf58F0 zp+VjvgR9JrglKY39gKq8IQgbAvetjSL8qW//zW1WX3mjX9E7s3R7x5prKh+NnG5VgLQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH 16/16] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen() Date: Fri, 20 May 2022 13:09:37 +0100 Message-Id: <20220520120937.28925-17-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Now that map_pages_to_xen() has been extended to support 2MB mappings, we can replace the create_mappings() call by map_pages_to_xen() call. This has the advantage to remove the differences between 32-bit and 64-bit code. Lastly remove create_mappings() as there is no more callers. Signed-off-by: Julien Grall Signed-off-by: Julien Grall --- Changes in v4: - Add missing _PAGE_BLOCK Changes in v3: - Fix typo in the commit message - Remove the TODO regarding contiguous bit Changes in v2: - New patch --- xen/arch/arm/mm.c | 64 +++++------------------------------------------ 1 file changed, 6 insertions(+), 58 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 65af44f42232..be37176a4725 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -369,40 +369,6 @@ void clear_fixmap(unsigned map) BUG_ON(res != 0); } -/* Create Xen's mappings of memory. - * Mapping_size must be either 2MB or 32MB. - * Base and virt must be mapping_size aligned. - * Size must be a multiple of mapping_size. - * second must be a contiguous set of second level page tables - * covering the region starting at virt_offset. */ -static void __init create_mappings(lpae_t *second, - unsigned long virt_offset, - unsigned long base_mfn, - unsigned long nr_mfns, - unsigned int mapping_size) -{ - unsigned long i, count; - const unsigned long granularity = mapping_size >> PAGE_SHIFT; - lpae_t pte, *p; - - ASSERT((mapping_size == MB(2)) || (mapping_size == MB(32))); - ASSERT(!((virt_offset >> PAGE_SHIFT) % granularity)); - ASSERT(!(base_mfn % granularity)); - ASSERT(!(nr_mfns % granularity)); - - count = nr_mfns / XEN_PT_LPAE_ENTRIES; - p = second + second_linear_offset(virt_offset); - pte = mfn_to_xen_entry(_mfn(base_mfn), MT_NORMAL); - if ( granularity == 16 * XEN_PT_LPAE_ENTRIES ) - pte.pt.contig = 1; /* These maps are in 16-entry contiguous chunks. */ - for ( i = 0; i < count; i++ ) - { - write_pte(p + i, pte); - pte.pt.base += 1 << XEN_PT_LPAE_SHIFT; - } - flush_xen_tlb_local(); -} - #ifdef CONFIG_DOMAIN_PAGE void *map_domain_page_global(mfn_t mfn) { @@ -862,36 +828,18 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); mfn_t base_mfn; const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); -#ifdef CONFIG_ARM_64 - lpae_t *second, pte; - unsigned long nr_second; - mfn_t second_base; - int i; -#endif + int rc; frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); /* Round up to 2M or 32M boundary, as appropriate. */ frametable_size = ROUNDUP(frametable_size, mapping_size); base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); -#ifdef CONFIG_ARM_64 - /* Compute the number of second level pages. */ - nr_second = ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT; - second_base = alloc_boot_pages(nr_second, 1); - second = mfn_to_virt(second_base); - for ( i = 0; i < nr_second; i++ ) - { - clear_page(mfn_to_virt(mfn_add(second_base, i))); - pte = mfn_to_xen_entry(mfn_add(second_base, i), MT_NORMAL); - pte.pt.table = 1; - write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte); - } - create_mappings(second, 0, mfn_x(base_mfn), frametable_size >> PAGE_SHIFT, - mapping_size); -#else - create_mappings(xen_second, FRAMETABLE_VIRT_START, mfn_x(base_mfn), - frametable_size >> PAGE_SHIFT, mapping_size); -#endif + rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, + frametable_size >> PAGE_SHIFT, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the frametable mappings.\n"); memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); memset(&frame_table[nr_pdxs], -1, -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333988.557943 (Exim 4.92) (envelope-from ) id 1ns1Wn-0003Y5-AG; Fri, 20 May 2022 12:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333988.557943; Fri, 20 May 2022 12:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wn-0003WA-5W; Fri, 20 May 2022 12:14:45 +0000 Received: by outflank-mailman (input) for mailman id 333988; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NP-R9 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wW-Li; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sm-0001lI-S2; Fri, 20 May 2022 12:10:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=HwmRtt4otl1crmQ3IgjCxj/lVWCzBdIkM8zTQonw0lU=; b=EiJ687OV4u5psb86gk5OSHYba4 gE5eOTcNprJA0+yjr3EcYZo+FUl/WEp+BWKB+Xz9owRPWsmeK6yZQz+y+7V+kIjhLXlPySjjEH4Qt +M7dZYhOx8bgcih8R1K/0YRJJKsbLBgy6DgZdCkI9YhC7Kl5vry0Ob7hKk4bU5PrzS4M=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 11/16] xen/arm: mm: Clean-up the includes and order them Date: Fri, 20 May 2022 13:09:32 +0100 Message-Id: <20220520120937.28925-12-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The numbers of includes in mm.c has been growing quite a lot. However some of them (e.g. xen/device_tree.h, xen/softirq.h) doesn't look to be directly used by the file or other will be included by larger headers (e.g asm/flushtlb.h will be included by xen/mm.h). So trim down the number of includes. Take the opportunity to order them with the xen headers first, then asm headers and last public headers. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v4: - Add Stefano's acked-by Changes in v3: - Patch added --- xen/arch/arm/mm.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index bd1348a99716..d40dd4e6c9e6 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -17,33 +17,26 @@ * GNU General Public License for more details. */ -#include -#include -#include -#include -#include -#include +#include #include #include -#include -#include #include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include #include +#include +#include #include + #include -#include -#include -#include #include #include +#include + /* Override macros from asm/page.h to make them work with mfn_t */ #undef virt_to_mfn #define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333989.557948 (Exim 4.92) (envelope-from ) id 1ns1Wn-0003f7-LY; Fri, 20 May 2022 12:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333989.557948; Fri, 20 May 2022 12:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wn-0003c3-FI; Fri, 20 May 2022 12:14:45 +0000 Received: by outflank-mailman (input) for mailman id 333989; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NU-S7 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wY-NE; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sp-0001lI-V2; Fri, 20 May 2022 12:10:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=/p4UF49sOqtR4ILsBBu0AgkjXqEpW9beFbXzPB2vh14=; b=RqVcFZF6NOBVK1/WkZJeoI26DI KjGigIBdadzMlNjOeFHlUxYSOA4GqqHVuYh4RYON/Zew2s28W4WPqgZFlbArO5ZqEvhFrfZv1QEK/ dIJGEL6krsspXyYMhrNhKLKfPpfI2gg26QDRiumPAdCX567ojsYK1djN0jqTD/itkY1k=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first Date: Fri, 20 May 2022 13:09:35 +0100 Message-Id: <20220520120937.28925-15-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Currently, memory is added to the boot allocator after the xenheap mappings are done. This will break if the first mapping is more than 512GB of RAM. In addition to that, a follow-up patch will rework setup_xenheap_mappings() to use smaller mappings (e.g. 2MB, 4KB). So it will be necessary to have memory in the boot allocator earlier. Only free memory (e.g. not reserved or modules) can be added to the boot allocator. It might be possible that some regions (including the first one) will have no free memory. So we need to add all the free memory to the boot allocator first and then add do the mappings. Populating the boot allocator is nearly the same between arm32 and arm64. The only difference is on the former we need to exclude the xenheap for the boot allocator. Gate the difference with CONFIG_ARM_32 so the code be re-used on arm64. Signed-off-by: Julien Grall --- Changes in v4: - The implementation of populate_boot_allocator() has been moved in a separate patch. - Fix typo Changes in v3: - Patch added --- xen/arch/arm/setup.c | 55 +++++++++++++++++++------------------------- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3d5a2283d4ef..db1768c03f03 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -636,13 +636,12 @@ static void __init init_staticmem_pages(void) #endif } -#ifdef CONFIG_ARM_32 /* * Populate the boot allocator. All the RAM but the following regions * will be added: * - Modules (e.g., Xen, Kernel) * - Reserved regions - * - Xenheap + * - Xenheap (arm32 only) */ static void __init populate_boot_allocator(void) { @@ -672,6 +671,7 @@ static void __init populate_boot_allocator(void) if ( e > bank_end ) e = bank_end; +#ifdef CONFIG_ARM_32 /* Avoid the xenheap */ if ( s < mfn_to_maddr(xenheap_mfn_end) && mfn_to_maddr(xenheap_mfn_start) < e ) @@ -679,6 +679,7 @@ static void __init populate_boot_allocator(void) e = mfn_to_maddr(xenheap_mfn_start); n = mfn_to_maddr(xenheap_mfn_end); } +#endif fw_unreserved_regions(s, e, init_boot_pages, 0); s = n; @@ -686,6 +687,7 @@ static void __init populate_boot_allocator(void) } } +#ifdef CONFIG_ARM_32 static void __init setup_mm(void) { paddr_t ram_start, ram_end, ram_size, e; @@ -781,45 +783,36 @@ static void __init setup_mm(void) #else /* CONFIG_ARM_64 */ static void __init setup_mm(void) { + const struct meminfo *banks = &bootinfo.mem; paddr_t ram_start = ~0; paddr_t ram_end = 0; paddr_t ram_size = 0; - int bank; + unsigned int i; init_pdx(); - total_pages = 0; - for ( bank = 0 ; bank < bootinfo.mem.nr_banks; bank++ ) - { - paddr_t bank_start = bootinfo.mem.bank[bank].start; - paddr_t bank_size = bootinfo.mem.bank[bank].size; - paddr_t bank_end = bank_start + bank_size; - paddr_t s, e; - - ram_size = ram_size + bank_size; - ram_start = min(ram_start,bank_start); - ram_end = max(ram_end,bank_end); - - setup_xenheap_mappings(bank_start>>PAGE_SHIFT, bank_size>>PAGE_SHIFT); - - s = bank_start; - while ( s < bank_end ) - { - paddr_t n = bank_end; + /* + * We need some memory to allocate the page-tables used for the xenheap + * mappings. But some regions may contain memory already allocated + * for other uses (e.g. modules, reserved-memory...). + * + * For simplicity, add all the free regions in the boot allocator. + */ + populate_boot_allocator(); - e = next_module(s, &n); + total_pages = 0; - if ( e == ~(paddr_t)0 ) - { - e = n = bank_end; - } + for ( i = 0; i < banks->nr_banks; i++ ) + { + const struct membank *bank = &banks->bank[i]; + paddr_t bank_end = bank->start + bank->size; - if ( e > bank_end ) - e = bank_end; + ram_size = ram_size + bank->size; + ram_start = min(ram_start, bank->start); + ram_end = max(ram_end, bank_end); - fw_unreserved_regions(s, e, init_boot_pages, 0); - s = n; - } + setup_xenheap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); } total_pages += ram_size >> PAGE_SHIFT; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333990.557961 (Exim 4.92) (envelope-from ) id 1ns1Wo-0003o1-AC; Fri, 20 May 2022 12:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333990.557961; Fri, 20 May 2022 12:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wn-0003ji-Sm; Fri, 20 May 2022 12:14:45 +0000 Received: by outflank-mailman (input) for mailman id 333990; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NV-SG for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wS-IR; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sl-0001lI-Nm; Fri, 20 May 2022 12:10:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=xXyiaAqaXOE8UjksPYWndQvCCsS0jnjjnrlX2Gok8p4=; b=xkgAUx/nd4GGJbbvcAtEElB/+V ZOrrVNlIN7mSVaB1/vbRHaovXTkHyRSNQKsmcT+4u9Y1HcZ3KxKZwkDsnkHe5l4l4MYYzXX7cfL5e 7tC996Az2c/Dw7GUKuajB29F3rPAwQSOEXcB+gJWDbrI4awHqt+jBXC7iESLGFQ50/bM=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Wei Liu , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure Date: Fri, 20 May 2022 13:09:31 +0100 Message-Id: <20220520120937.28925-11-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Wei Liu The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We pre-populate all the relevant page tables before the system is fully set up. We will need it on Arm in order to rework the arm64 version of xenheap_setup_mappings() as we may need to use pages allocated from the boot allocator before they are effectively mapped. This infrastructure is not lock-protected therefore can only be used before smpboot. After smpboot, map_domain_page() has to be used. This is based on the x86 version [1] that was originally implemented by Wei Liu. The PMAP infrastructure is implemented in common code with some arch helpers to set/clear the page-table entries and convertion between a fixmap slot to a virtual address... As mfn_to_xen_entry() now needs to be exported, take the opportunity to swich the parameter attr from unsigned to unsigned int. [1] Signed-off-by: Wei Liu Signed-off-by: Hongyan Xia [julien: Adapted for Arm] Signed-off-by: Julien Grall --- Changes in v4: - Move xen_fixmap in fixmap.h and add a comment about its usage. - Update comments - Use DECLARE_BITMAP() - Replace local_irq_{enable, disable} with an ASSERT() as there should be no user of pmap() in interrupt context. Changes in v3: - s/BITS_PER_LONG/BITS_PER_BYTE/ - Move pmap to common code Changes in v2: - New patch Cc: Jan Beulich Cc: Wei Liu Cc: Andrew Cooper Cc: Roger Pau Monné --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/fixmap.h | 24 +++++++++++ xen/arch/arm/include/asm/lpae.h | 8 ++++ xen/arch/arm/include/asm/pmap.h | 32 ++++++++++++++ xen/arch/arm/mm.c | 7 +-- xen/common/Kconfig | 3 ++ xen/common/Makefile | 1 + xen/common/pmap.c | 72 +++++++++++++++++++++++++++++++ xen/include/xen/pmap.h | 16 +++++++ 9 files changed, 158 insertions(+), 6 deletions(-) create mode 100644 xen/arch/arm/include/asm/pmap.h create mode 100644 xen/common/pmap.c create mode 100644 xen/include/xen/pmap.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4d3..a89a67802aa9 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -14,6 +14,7 @@ config ARM select HAS_DEVICE_TREE select HAS_PASSTHROUGH select HAS_PDX + select HAS_PMAP select IOMMU_FORCE_PT_SHARE config ARCH_DEFCONFIG diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h index 1cee51e52ab9..365a2385a087 100644 --- a/xen/arch/arm/include/asm/fixmap.h +++ b/xen/arch/arm/include/asm/fixmap.h @@ -5,20 +5,44 @@ #define __ASM_FIXMAP_H #include +#include /* Fixmap slots */ #define FIXMAP_CONSOLE 0 /* The primary UART */ #define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ #define FIXMAP_ACPI_BEGIN 2 /* Start mappings of ACPI tables */ #define FIXMAP_ACPI_END (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1) /* End mappings of ACPI tables */ +#define FIXMAP_PMAP_BEGIN (FIXMAP_ACPI_END + 1) /* Start of PMAP */ +#define FIXMAP_PMAP_END (FIXMAP_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */ + +#define FIXMAP_LAST FIXMAP_PMAP_END + +#define FIXADDR_START FIXMAP_ADDR(0) +#define FIXADDR_TOP FIXMAP_ADDR(FIXMAP_LAST) #ifndef __ASSEMBLY__ +/* + * Direct access to xen_fixmap[] should only happen when {set, + * clear}_fixmap() is unusable (e.g. where we would end up to + * recursively call the helpers). + */ +extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES]; + /* Map a page in a fixmap entry */ extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes); /* Remove a mapping from a fixmap entry */ extern void clear_fixmap(unsigned map); +#define fix_to_virt(slot) ((void *)FIXMAP_ADDR(slot)) + +static inline unsigned int virt_to_fix(vaddr_t vaddr) +{ + BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START); + + return ((vaddr - FIXADDR_START) >> PAGE_SHIFT); +} + #endif /* __ASSEMBLY__ */ #endif /* __ASM_FIXMAP_H */ diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h index aecb320dec45..fc19cbd84772 100644 --- a/xen/arch/arm/include/asm/lpae.h +++ b/xen/arch/arm/include/asm/lpae.h @@ -4,6 +4,7 @@ #ifndef __ASSEMBLY__ #include +#include /* * WARNING! Unlike the x86 pagetable code, where l1 is the lowest level and @@ -168,6 +169,13 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level) third_table_offset(addr) \ } +/* + * Standard entry type that we'll use to build Xen's own pagetables. + * We put the same permissions at every level, because they're ignored + * by the walker in non-leaf entries. + */ +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); + #endif /* __ASSEMBLY__ */ /* diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h new file mode 100644 index 000000000000..74398b4c4fe6 --- /dev/null +++ b/xen/arch/arm/include/asm/pmap.h @@ -0,0 +1,32 @@ +#ifndef __ASM_PMAP_H__ +#define __ASM_PMAP_H__ + +#include + +#include + +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) +{ + lpae_t *entry = &xen_fixmap[slot]; + lpae_t pte; + + ASSERT(!lpae_is_valid(*entry)); + + pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW); + pte.pt.table = 1; + write_pte(entry, pte); +} + +static inline void arch_pmap_unmap(unsigned int slot) +{ + lpae_t pte = {}; + + write_pte(&xen_fixmap[slot], pte); + + flush_xen_tlb_range_va_local(FIXMAP_ADDR(slot), PAGE_SIZE); +} + +void arch_pmap_map_slot(unsigned int slot, mfn_t mfn); +void arch_pmap_clear_slot(void *ptr); + +#endif /* __ASM_PMAP_H__ */ diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 52b2a0394047..bd1348a99716 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -305,12 +305,7 @@ void dump_hyp_walk(vaddr_t addr) dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); } -/* - * Standard entry type that we'll use to build Xen's own pagetables. - * We put the same permissions at every level, because they're ignored - * by the walker in non-leaf entries. - */ -static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr) +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) { lpae_t e = (lpae_t) { .pt = { diff --git a/xen/common/Kconfig b/xen/common/Kconfig index d921c74d615e..5b6b2406c028 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -49,6 +49,9 @@ config HAS_KEXEC config HAS_PDX bool +config HAS_PMAP + bool + config HAS_SCHED_GRANULARITY bool diff --git a/xen/common/Makefile b/xen/common/Makefile index b1e076c30b81..3baf83d527d8 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -29,6 +29,7 @@ obj-y += notifier.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o +obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o obj-y += preempt.o obj-y += random.o obj-y += rangeset.o diff --git a/xen/common/pmap.c b/xen/common/pmap.c new file mode 100644 index 000000000000..9355cacb7373 --- /dev/null +++ b/xen/common/pmap.c @@ -0,0 +1,72 @@ +#include +#include +#include +#include + +#include +#include + +/* + * Simple mapping infrastructure to map / unmap pages in fixed map. + * This is used to set the page table before the map domain page infrastructure + * is initialized. + * + * This structure is not protected by any locks, so it must not be used after + * smp bring-up. + */ + +/* Bitmap to track which slot is used */ +static __initdata DECLARE_BITMAP(inuse, NUM_FIX_PMAP); + +void *__init pmap_map(mfn_t mfn) +{ + unsigned int idx; + unsigned int slot; + + ASSERT(system_state < SYS_STATE_smp_boot); + ASSERT(!in_irq()); + + idx = find_first_zero_bit(inuse, NUM_FIX_PMAP); + if ( idx == NUM_FIX_PMAP ) + panic("Out of PMAP slots\n"); + + __set_bit(idx, inuse); + + slot = idx + FIXMAP_PMAP_BEGIN; + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); + + /* + * We cannot use set_fixmap() here. We use PMAP when the domain map + * page infrastructure is not yet initialized, so map_pages_to_xen() called + * by set_fixmap() needs to map pages on demand, which then calls pmap() + * again, resulting in a loop. Modify the PTEs directly instead. The same + * is true for pmap_unmap(). + */ + arch_pmap_map(slot, mfn); + + return fix_to_virt(slot); +} + +void __init pmap_unmap(const void *p) +{ + unsigned int idx; + unsigned int slot = virt_to_fix((unsigned long)p); + + ASSERT(system_state < SYS_STATE_smp_boot); + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); + ASSERT(in_irq()); + + idx = slot - FIXMAP_PMAP_BEGIN; + + __clear_bit(idx, inuse); + arch_pmap_unmap(slot); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/pmap.h b/xen/include/xen/pmap.h new file mode 100644 index 000000000000..93e61b10870e --- /dev/null +++ b/xen/include/xen/pmap.h @@ -0,0 +1,16 @@ +#ifndef __XEN_PMAP_H__ +#define __XEN_PMAP_H__ + +/* Large enough for mapping 5 levels of page tables with some headroom */ +#define NUM_FIX_PMAP 8 + +#ifndef __ASSEMBLY__ + +#include + +void *pmap_map(mfn_t mfn); +void pmap_unmap(const void *p); + +#endif /* __ASSEMBLY__ */ + +#endif /* __XEN_PMAP_H__ */ -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333991.557968 (Exim 4.92) (envelope-from ) id 1ns1Wo-0003yz-S2; Fri, 20 May 2022 12:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333991.557968; Fri, 20 May 2022 12:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wo-0003vf-EY; Fri, 20 May 2022 12:14:46 +0000 Received: by outflank-mailman (input) for mailman id 333991; Fri, 20 May 2022 12:14:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003Nd-Tk for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005we-Oq; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sr-0001lI-38; Fri, 20 May 2022 12:10:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=41WjXhbveDV5dmNCQg1PHVgqE6S+lfA5Dgi2tBRYmT0=; b=sZoYCpyBcFzHWZlYss8ssgcJBg ZCC9jzSuNV0zXOmMwhY6dEB7lqRhdIJuoWSebGFUDYQGwbVbq1NKe0tpccxEASdhs/B7XKNDv5d26 1PJsLbQ+CVjSrKVjX54SZdXZe5AyZ6LUcfJeXIXviwddedkf4qOKLwAKdRQZLlIStO7A=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH 15/16] xen/arm: mm: Rework setup_xenheap_mappings() Date: Fri, 20 May 2022 13:09:36 +0100 Message-Id: <20220520120937.28925-16-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The current implementation of setup_xenheap_mappings() is using 1GB mappings. This can lead to unexpected result because the mapping may alias a non-cachable region (such as device or reserved regions). For more details see B2.8 in ARM DDI 0487H.a. map_pages_to_xen() was recently reworked to allow superpage mappings, support contiguous mapping and deal with the use of page-tables before they are mapped. Most of the code in setup_xenheap_mappings() is now replaced with a single call to map_pages_to_xen(). Signed-off-by: Julien Grall Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v4: - Fix typo - Add Stefano's reviewed-by Changes in v3: - Don't use 1GB mapping - Re-order code in setup_mm() in a separate patch Changes in v2: - New patch --- xen/arch/arm/mm.c | 87 ++++++++++------------------------------------- 1 file changed, 18 insertions(+), 69 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index b019e4b35b55..65af44f42232 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -138,17 +138,6 @@ static DEFINE_PAGE_TABLE(cpu0_pgtable); static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES); #endif -#ifdef CONFIG_ARM_64 -/* The first page of the first level mapping of the xenheap. The - * subsequent xenheap first level pages are dynamically allocated, but - * we need this one to bootstrap ourselves. */ -static DEFINE_PAGE_TABLE(xenheap_first_first); -/* The zeroeth level slot which uses xenheap_first_first. Used because - * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't - * valid for a non-xenheap mapping. */ -static __initdata int xenheap_first_first_slot = -1; -#endif - /* Common pagetable leaves */ /* Second level page tables. * @@ -831,77 +820,37 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, void __init setup_xenheap_mappings(unsigned long base_mfn, unsigned long nr_mfns) { - lpae_t *first, pte; - unsigned long mfn, end_mfn; - vaddr_t vaddr; - - /* Align to previous 1GB boundary */ - mfn = base_mfn & ~((FIRST_SIZE>>PAGE_SHIFT)-1); + int rc; /* First call sets the xenheap physical and virtual offset. */ if ( mfn_eq(xenheap_mfn_start, INVALID_MFN) ) { + unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); + xenheap_mfn_start = _mfn(base_mfn); xenheap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + /* + * The base address may not be aligned to the first level + * size (e.g. 1GB when using 4KB pages). This would prevent + * superpage mappings for all the regions because the virtual + * address and machine address should both be suitably aligned. + * + * Prevent that by offsetting the start of the xenheap virtual + * address. + */ xenheap_virt_start = DIRECTMAP_VIRT_START + - (base_mfn - mfn) * PAGE_SIZE; + (base_mfn - mfn_gb) * PAGE_SIZE; } if ( base_mfn < mfn_x(xenheap_mfn_start) ) panic("cannot add xenheap mapping at %lx below heap start %lx\n", base_mfn, mfn_x(xenheap_mfn_start)); - end_mfn = base_mfn + nr_mfns; - - /* - * Virtual address aligned to previous 1GB to match physical - * address alignment done above. - */ - vaddr = (vaddr_t)__mfn_to_virt(base_mfn) & FIRST_MASK; - - while ( mfn < end_mfn ) - { - int slot = zeroeth_table_offset(vaddr); - lpae_t *p = &xen_pgtable[slot]; - - if ( p->pt.valid ) - { - /* mfn_to_virt is not valid on the 1st 1st mfn, since it - * is not within the xenheap. */ - first = slot == xenheap_first_first_slot ? - xenheap_first_first : mfn_to_virt(lpae_get_mfn(*p)); - } - else if ( xenheap_first_first_slot == -1) - { - /* Use xenheap_first_first to bootstrap the mappings */ - first = xenheap_first_first; - - pte = pte_of_xenaddr((vaddr_t)xenheap_first_first); - pte.pt.table = 1; - write_pte(p, pte); - - xenheap_first_first_slot = slot; - } - else - { - mfn_t first_mfn = alloc_boot_pages(1, 1); - - clear_page(mfn_to_virt(first_mfn)); - pte = mfn_to_xen_entry(first_mfn, MT_NORMAL); - pte.pt.table = 1; - write_pte(p, pte); - first = mfn_to_virt(first_mfn); - } - - pte = mfn_to_xen_entry(_mfn(mfn), MT_NORMAL); - /* TODO: Set pte.pt.contig when appropriate. */ - write_pte(&first[first_table_offset(vaddr)], pte); - - mfn += FIRST_SIZE>>PAGE_SHIFT; - vaddr += FIRST_SIZE; - } - - flush_xen_tlb_local(); + rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), + _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the xenheap mappings.\n"); } #endif -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333992.557977 (Exim 4.92) (envelope-from ) id 1ns1Wp-0004BU-EL; Fri, 20 May 2022 12:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333992.557977; Fri, 20 May 2022 12:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wo-00047E-Vu; Fri, 20 May 2022 12:14:46 +0000 Received: by outflank-mailman (input) for mailman id 333992; Fri, 20 May 2022 12:14:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0003NZ-TR for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wl-0005wU-K9; Fri, 20 May 2022 12:14:43 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ns1Sn-0001lI-T1; Fri, 20 May 2022 12:10:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=QrMX+f1B9/uCnIONfcNrd5IjXpsYHLALKUn/Mv7SupA=; b=6Up0ZDUUnV7j3M6/hSXLAhP30w JjdnUfUG1voWCIHjL4TOnQyYZFkX4i1J0w1x10XhV5yAe10ZeDXQigwv4OK11+YZkzQAVyhIur8ED QEDfrRXcCTkokXAVlBrpuvsBzcin/bcjIgkl1EJciGHxzTMy4kC6TWq6k6y64nJ78Efk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 12/16] xen/arm: mm: Use the PMAP helpers in xen_{,un}map_table() Date: Fri, 20 May 2022 13:09:33 +0100 Message-Id: <20220520120937.28925-13-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220520120937.28925-1-julien@xen.org> References: <20220520120937.28925-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall During early boot, it is not possible to use xen_{,un}map_table() if the page tables are not residing the Xen binary. This is a blocker to switch some of the helpers to use xen_pt_update() as we may need to allocate extra page tables and access them before the domheap has been initialized (see setup_xenheap_mappings()). xen_{,un}map_table() are now updated to use the PMAP helpers for early boot map/unmap. Note that the special case for page-tables residing in Xen binary has been dropped because it is "complex" and was only added as a workaround in 8d4f1b8878e0 ("xen/arm: mm: Allow generic xen page-tables helpers to be called early"). Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v4: - Add Stefano's reviewed-by Changes in v2: - New patch --- xen/arch/arm/mm.c | 33 +++++++++------------------------ 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index d40dd4e6c9e6..b019e4b35b55 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -980,27 +981,11 @@ void *ioremap(paddr_t pa, size_t len) static lpae_t *xen_map_table(mfn_t mfn) { /* - * We may require to map the page table before map_domain_page() is - * useable. The requirements here is it must be useable as soon as - * page-tables are allocated dynamically via alloc_boot_pages(). - * - * We need to do the check on physical address rather than virtual - * address to avoid truncation on Arm32. Therefore is_kernel() cannot - * be used. + * During early boot, map_domain_page() may be unusable. Use the + * PMAP to map temporarily a page-table. */ if ( system_state == SYS_STATE_early_boot ) - { - if ( is_xen_fixed_mfn(mfn) ) - { - /* - * It is fine to demote the type because the size of Xen - * will always fit in vaddr_t. - */ - vaddr_t offset = mfn_to_maddr(mfn) - virt_to_maddr(&_start); - - return (lpae_t *)(XEN_VIRT_START + offset); - } - } + return pmap_map(mfn); return map_domain_page(mfn); } @@ -1009,12 +994,12 @@ static void xen_unmap_table(const lpae_t *table) { /* * During early boot, xen_map_table() will not use map_domain_page() - * for page-tables residing in Xen binary. So skip the unmap part. + * but the PMAP. */ - if ( system_state == SYS_STATE_early_boot && is_kernel(table) ) - return; - - unmap_domain_page(table); + if ( system_state == SYS_STATE_early_boot ) + pmap_unmap(table); + else + unmap_domain_page(table); } static int create_xen_table(lpae_t *entry) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:14:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.333993.558010 (Exim 4.92) (envelope-from ) id 1ns1Wu-0005RH-IG; Fri, 20 May 2022 12:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 333993.558010; Fri, 20 May 2022 12:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Wu-0005R5-CJ; Fri, 20 May 2022 12:14:52 +0000 Received: by outflank-mailman (input) for mailman id 333993; Fri, 20 May 2022 12:14:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1Ws-0005Cp-Lk for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:14:50 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 71b37d81-d836-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 14:14:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB8551477; Fri, 20 May 2022 05:14:48 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ABFDC3F718; Fri, 20 May 2022 05:14:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71b37d81-d836-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2] build: Fix make warning if there is no cppcheck Date: Fri, 20 May 2022 13:14:38 +0100 Message-Id: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If cppcheck is not present, the following warning appears during build: which: no cppcheck in ([...]) /bin/sh: cppcheck: command not found Fix the problem by using shell code inside the cppcheck-version rule to also prevent unneeded call of which when something else than cppcheck is built. Reported-by: Julien Grall Signed-off-by: Bertrand Marquis --- xen/Makefile | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 15388703bc..e8d8ed71bc 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(call if_changed,cppcheck_xml) cppcheck-version: -ifeq ($(shell which $(CPPCHECK)),) - $(error Cannot find cppcheck executable: $(CPPCHECK)) -endif -ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) - $(error Please upgrade your cppcheck to version 2.7 or greater) -endif + @if ! which $(CPPCHECK) > /dev/null 2>&1; then \ + echo "Cannot find cppcheck executable: $(CPPCHECK)"; \ + exit 1; \ + fi + @if [ "$$($(CPPCHECK) --version | awk '{print ($$2 < 2.7)}')" -eq 1 ]; then \ + echo "Please upgrade your cppcheck to version 2.7 or greater"; \ + exit 1; \ + fi # Put this in generated headers this way it is cleaned by include/Makefile $(objtree)/include/generated/compiler-def.h: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri May 20 12:22:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334052.558021 (Exim 4.92) (envelope-from ) id 1ns1eN-0000dv-Cz; Fri, 20 May 2022 12:22:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334052.558021; Fri, 20 May 2022 12:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1eN-0000do-A1; Fri, 20 May 2022 12:22:35 +0000 Received: by outflank-mailman (input) for mailman id 334052; Fri, 20 May 2022 12:22:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1eL-0000dY-Gt for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:22:33 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 845a2afa-d837-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 14:22:31 +0200 (CEST) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 08:22:27 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3253.namprd03.prod.outlook.com (2603:10b6:910:51::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 12:22:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 12:22:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 845a2afa-d837-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653049351; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=WR4yy3JeEeqy9x+5BqS1xYw3IpQBa8MXbtJRIXiOWdo=; b=KejB0BzhkOdZgAc+B/HbX0rkQlhLks4PpvoNtc33uKGWanY5LCNTIHYT QEmcNUH6f9iz7D5DK2hPWNI5f8RyD5ueRfy/EXdydtz759hFvKbYoXmZp /Iolbp/y2eDAG+ftlsgAbSFtZ6Ibw0CqMbRwWmkU76D70V+l4zHpZO7ui s=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 71790984 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8qIII6nZqHlP0sqmacDQ6ujo5gz7J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWXm6FM/2IMDf1Lo0iPYzjphkPupWGzNBqGQBvqSoxECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVvV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYe0AkDpDvmPkkDgBVKChyEoAY/KTBGC3q2SCT5xWun3rE5dxLVRlzF6tHv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvZkBhG9YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8Q3E/ftnvwA/yiRyzOjAHf3KOeCUH+xojl/Jm SX30GDmV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUS9wWl2qfSpQGDCQA5oiVpbdUnsIo8Q2Ms3 1rQx9fxX2U36PuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6 1i3QOIW3t3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:zRF1xKPlP8TtMMBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71790984" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJ0sQOQXQ2I8ZjTSXpDTuBzAd59DuV93eeN86X5ePYZ4KLbGuW5AJi/+wGjcMuebgjoZOOtdECYhy+Nrjf/i3v5umLaoaaOWhtzr1E7JetnPHjx9hbinWEiQSR45IX6/FljNIrcoVmkM6CEsCV0piA7duhsOrTTwGhZUhMSHf43/NCiwV7kotTG+mof1jRM38CrbY7o1shvAi1j9FUzuZHXZE8A7Hi0xgYk2T8S9WEyraIhflUQFKLwD1W7TP8CjQAs/cBN0HBrX4bZLSpMTok7Jr20lPhViqxVvGOikh6IqcDbz91DfpMuHqGBFtoHqksKGZmDYc5+gq9loTsBUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R/LA+0Gfb12hAYwy+8E0wEGgvXmIqfNUmIkMT/r8nYg=; b=VGbSCTuusj2Gq/PdJyQ5Q3k9lje5ihvlOPy1nkAUzIcDKekXw7yo21cLufVy0w09/aye11l6ElSFxZBc1HmDiK0xkxSli7Ann2ZjY4l+3xDNH4M2Fef4elorMOARxvB+TuuwFDlXMYlxejwcJPnnCH/vlFaAflb43PYHk1QXT8EImdGVdLhRFwav+ndSKMF7eCd+Uyo2FmTsWxxoT8fpy9bKM/bbQ2jYBy4THJuZNP/L8XSBS5qWBa66hWFFbu3slZJbMXHqXBfBQOf2uEy1Vk3WeQpvTIArx0cs4O+ubNdGIaELSpjUJdSvDMkinloKh7lx5sqtAXmEg+Em8rncUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R/LA+0Gfb12hAYwy+8E0wEGgvXmIqfNUmIkMT/r8nYg=; b=TTXWWAQyxcerf5rqiJM9FErta1l2Z9dVbn2ichtMQH8Fgs5mnX1Smn9XGGJqjtLTZsTj0NxyuDcJUEBgHQaR/61dwaqc3418pOz4arHKqi15caUCztICC7FOVYXAcmCs34LVVGFOZof0c5ImZ6zkhsHMzwD48xk/QkzkcMEREG4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 14:22:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> X-ClientProxiedBy: LO2P123CA0080.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be269eb5-3c5b-4b2c-67f6-08da3a5b651b X-MS-TrafficTypeDiagnostic: CY4PR03MB3253:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gY3poQkUa4JuBGEDooYq1gh4Su+WREddECfqly6WBKsjoGNKcUugJEZrye2DEqh3Gt0ye4eYasKNbmYyyvbDumslKvLZBb/fmUtI2HTixiqMZBubgkQs32zuiUJxKCH3wqp6A4BJHCOddfKbmxPsJbjUFU3MpqCsTyuTpyEZgnDUQIivJPl6lhHN824BGZSQFnkjQMLx/bWN1FuHD2t3imnswMkZSp1AhgAIX82jdVGOjKwqLORP6ixWKA9lXH37MSwLg7KHMa++jPoIBolCPUnJyBrpjCCXARouzi6ENyINAVcxb3CEG4fMydeHqa5O3yZQpOKC7T19ndicj6h7ZnudkoQSCotg+vtD6h38UcmOttIxz70Wsl0UaEcWupqBxlERvbqs0g7k7PHfrhzu+K9M88iHq5yy3j/k9deKEVwiUQ6RlHqvHAkKuNAwC+nnl3kHeiIt4Xg86PS8s3VXOGG/pspTZfSGWskH/mwx8tmEFqqFPlhO+bCiZ4+F45nbmuUkRm4ZGO29YNqQSLBdVVnl+yK2Xm0qY5jQ2yX9B3Oe/orc9Uap8OU6bpRBXNr3B4jCrukDbQinxdczYxDOXTZN+LRJeBCJ1bj66Gcej8j/IlsJK9hjVB6g1lezkzfCdH5TatHpH7CM7sl/CNcwwNHpi5qqVYJc/gya3jOU6NvtJVEuj2+O8nHlMJ0zAiaV944FGzSpLodJ+drd5gxQVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(6666004)(86362001)(82960400001)(8936002)(6506007)(9686003)(26005)(6512007)(53546011)(83380400001)(186003)(2906002)(38100700002)(85182001)(6486002)(508600001)(4326008)(54906003)(6916009)(8676002)(33716001)(66476007)(66556008)(66946007)(316002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXlHSklubWM5K0R0ZjRkMCs1VHZKS2dyV0VkamFhT2JMVkhHVGZYMk5RTEE4?= =?utf-8?B?ekVSY3F3UHpwZnRwazJxMG5zUnRUUUgzdXA5aUFuNTFKalQ0VXZZWnc4clF3?= =?utf-8?B?WDhDNCtta3dxcGd4NWQxdTI2ZTFGNTljZUJuaVlFZzFodWovak8wT3FsWWdR?= =?utf-8?B?bUF1MDlueUtKRlF6V3drZGFYTDlhUndZZGk1cDNDVDdGaS9PeHNQdnR0RmhR?= =?utf-8?B?WkhOSU9XbXJ5ald6dExFT2V4TmZGRXNtYUlCMis4VGxOanlnMDcyTTg0cU1K?= =?utf-8?B?b29FV0p1eEp2dndxZkJNa0FsRmtCOEM2MXZJOGR2V08rcndENUVhMnIwdnFE?= =?utf-8?B?NkpmV3N4Wm1TVG5SVGhBbGlvbmlVejBQUVJzRU42MEN2ZzlPemlwd3pONmty?= =?utf-8?B?S3d5amZJdklpME9XcXZFb0EwWHNLVkZoNkNZWDVnQ1BoL2tLN1F0dkpHWWVy?= =?utf-8?B?TTlReERkRmx6VWNmbmR0ek5NanppRnJCWUFYYUFIbm1FRlQ4b1RRWFJiemlZ?= =?utf-8?B?U25Ta0wycDFrblkyS2dMMzUyNGFuNjErWVlPSXFzbjk5Mk16cDdib0RVMnMw?= =?utf-8?B?MU0yYnFrVUpCbERMcnRlMGJnMGJRdkhxS21RYTE5Zm1FTXFhMzM1VVFucXpU?= =?utf-8?B?Zkc0L2haZ2x4eUNhd1drM09BUmpFdVZ1cHlTZmRXR2M5U1AyR21EY2lVMHE5?= =?utf-8?B?TlpPWDhhWVdnL3E1ZXFUSWtTQUNPNFNvZldKU0szb3I2WkZtYjdKby9FaTl5?= =?utf-8?B?eXZZVHo5WkFEemZBMnhaS0hOYXZXYlpobUhRTHRSRFh0Sjk5ZVl3WXl2RVV2?= =?utf-8?B?UVNVZWJFS2F5TGxnNDRXdHpVTjR3VGxibFhWZDNnOVM5THdPV2N2QVA1aTZ1?= =?utf-8?B?NzJMWU9EaGtjOFZJaks4aU9BTTdpaHdBbGxVZlpMZXp2S0M0OTgydWo4TlF3?= =?utf-8?B?T3VKRmlzL1pwejV6QnhYekJvZ01wNkdoK1VTSU1aRWllSDgxV25QUjh6dWRt?= =?utf-8?B?eUtWbVhwbkJhOWQrdUNHZVhOS3RCZi82WHhwQityWlFBV0Q3akVUcHoxUWJt?= =?utf-8?B?a2E5K29nT2ZMcHA5OURrZllEWFcwdW9sSDR1ZFFhRkRId0l2RHJtWFFWbVNX?= =?utf-8?B?eE94U1BwOEJQdUNSa0JuYTN6UkdBWVRzNnl4ZDA1L0tvSXdDcHI1YnlQMzVa?= =?utf-8?B?QWRiMWdVSk56Mnl1UDgxYVlzaGVTTElmbW1pWjI5ck15VlJHYU5HVU5nQjU5?= =?utf-8?B?b0o4aEVwNXRYWm9OUnNhaGtJR004NDQ4cUlMWHo0dU1JUnRtNm5KSnV5cjBO?= =?utf-8?B?NDIyUys1SjhSQ1BDT2xWK1VoSHR0dUdWKzZidkxjdThDRlFoQUhRRkkrMjZ1?= =?utf-8?B?cXRLY0xEdEVGOHNmeVZtM3BCQ3JIK1BYODJUVGFFUmN5RTdyamdOQ3FxdzJv?= =?utf-8?B?WVA5ZXBHeGVwODVrTWdyVkc2VmlFZ2JtdEVrTGZjbXMyRDRlNytTT0g0UVpK?= =?utf-8?B?WDdySU1zRVhGYXlramxQYnNwNzlOZHduc005aWlZanNEZVFVL2IrdFRnUk5D?= =?utf-8?B?S2s5SkdyODdWWTRZMGltZUhWOG1oL0VXa1JrVnRZWlFaZjR4L0dvSDlRaXhE?= =?utf-8?B?L0JldnVmdnd0Y2N4OE5QWTJ0TTRxMjBERHpPTHlrTFJBMTJPSUhRUjNGbTFi?= =?utf-8?B?SkRBaGwzTEpDbisyTE5kTkJxTCtsMXRjWWx2UTd0ajhsRXFFSnhYdHZ1eC9R?= =?utf-8?B?YlppSmdtdTJyeUNvalljK0I0c2FSSjdkNngwcFdVajBZWTJySUxHWEFKSThT?= =?utf-8?B?ZmcvTk0wVE9BNXBzZkxCVVFITXZqblE4aTdZMWlEYllpd0tQS2ZtRnUzZFB0?= =?utf-8?B?YlpudzlWLzQrejhDbS9OcWtmUEdCNW56MytRVXNyb2MwQlJpNm5QSHVBa1Vs?= =?utf-8?B?TWg3SnU2UHdCeHJLc0hnT3ZNdFlDZnhhbWk2R3R4bjRidVRXVVo4ZnpLR09V?= =?utf-8?B?WkJZVHZXOWYzOFE4TXR1Q09qUTV6T1hxM2VSaFFEWmxHRnRNZldlblRLbldn?= =?utf-8?B?VkVJa3ZoK0ZtbkJlUzdmWHp2dGIzVnI0WmZtSSt2a2FYVmczZ2Y2bTFOTUtE?= =?utf-8?B?aDBEOEhJVDVGNWVGRkNwa2hOdGw2dUQzZHRRVEV5eUo0SEFOVmxpaXVKcGk5?= =?utf-8?B?NnJodWhDeVJYNWhMYVdxc1RhdjE0dTVXL1ZtUlpuWDNiTElnd01nWXZJeUVi?= =?utf-8?B?SzB3Z3hUS0haSU5ZSmRRb0k4dUxidjkrWmw2KzVEUlpsTnJ4aXF3L0svbEkv?= =?utf-8?B?TWNWWkRNR1l5cFd1Z0ExdjRVYnhXY2RnQ2QwS09YaHJEb3lLT1l0Z0dSVkdO?= =?utf-8?Q?lrtUNlG1wPPZ/+8c=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: be269eb5-3c5b-4b2c-67f6-08da3a5b651b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:22:24.2513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3r4IG1F32W3BZ8hs7O5mDuzUeZCAqVCxZ2QapdJ+XgRdOdyVe2KX3RC8zVU66jZNLx3OSUqASAm+xM1/EXBykQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3253 On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: > On 20.05.2022 13:11, Jan Beulich wrote: > > On 20.05.2022 12:47, Roger Pau Monné wrote: > >> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: > >>> On 06.05.2022 13:16, Roger Pau Monné wrote: > >>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > >>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c > >>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c > >>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > >>>>> > >>>>> while ( nr_ptes-- ) > >>>>> { > >>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > >>>>> + ASSERT(!pde->next_level); > >>>>> + ASSERT(!pde->u); > >>>>> + > >>>>> + if ( pde > table ) > >>>>> + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > >>>>> + else > >>>>> + ASSERT(pde->ign0 == PAGE_SHIFT - 3); > >>>> > >>>> I think PAGETABLE_ORDER would be clearer here. > >>> > >>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere > >>> in IOMMU code afaics. > >> > >> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not > >> sure what's the rule for declaring that PAGE_SHIFT is fine to use in > >> IOMMU code but not PAGETABLE_ORDER. > > > > Hmm, yes and no. But for consistency with other IOMMU code I may want > > to switch to PAGE_SHIFT_4K. > > Except that, with the plan to re-use pt_update_contig_markers() for CPU- > side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? IMO it makes the code quite easier to understand. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 12:31:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:31:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334065.558031 (Exim 4.92) (envelope-from ) id 1ns1mc-00026O-9W; Fri, 20 May 2022 12:31:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334065.558031; Fri, 20 May 2022 12:31:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1mc-00026H-62; Fri, 20 May 2022 12:31:06 +0000 Received: by outflank-mailman (input) for mailman id 334065; Fri, 20 May 2022 12:31:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1ma-000267-Sx; Fri, 20 May 2022 12:31:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1ma-0006Hj-JI; Fri, 20 May 2022 12:31:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1ma-00022b-9P; Fri, 20 May 2022 12:31:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns1ma-0007SH-8u; Fri, 20 May 2022 12:31:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4ZfAQvuqmiYIdk7tOtmlwDRSAJapOWw24iCWBzi1El4=; b=pbs8kCHgeD9kzia2zgFRyNmuRO CjGqh1NSwaoiyrtvgcx+e4/wuzj9rW4rRHpR+k+CQaJrS13DxljmiGfKL7sY5NzE+9VyHcrhUq1uG tXoOKwyXZQTyJcsfBBDRfexd1WazLWOZVtSpW8+wycv+P4pQmEoSdVfwgsu7Knqrab1g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170601: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 12:31:04 +0000 flight 170601 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170601/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1119 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 12:36:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334075.558043 (Exim 4.92) (envelope-from ) id 1ns1rY-0002me-TO; Fri, 20 May 2022 12:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334075.558043; Fri, 20 May 2022 12:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1rY-0002mX-QO; Fri, 20 May 2022 12:36:12 +0000 Received: by outflank-mailman (input) for mailman id 334075; Fri, 20 May 2022 12:36:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1rX-0002mR-J9 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:36:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6500e20a-d839-11ec-837e-e5687231ffcc; Fri, 20 May 2022 14:35:56 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2171.outbound.protection.outlook.com [104.47.51.171]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-Ayefw1dyNmOhXJ8mKmsSNw-1; Fri, 20 May 2022 14:36:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9329.eurprd04.prod.outlook.com (2603:10a6:10:36f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 12:36:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 12:36:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6500e20a-d839-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653050170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oUjSjzcVxflSe5HJLiKtUf57+IkleojLi1RQqpbn6CA=; b=akWElo77wTW8RUu8SeXtm5ssRYvmhtcl7OL9Di8JbOb8f7ZSpTcq2uDL1CRIu2ZAHFQjjh 6m6ECNrG6qU8QXdeeYlONz7coo1LHHkHekagchzrUF8Q/HFulB19znnxuAMYx1s1tiUflb dC1ViuIsu8nOlGF7Mx9slyCEpcarsH4= X-MC-Unique: Ayefw1dyNmOhXJ8mKmsSNw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IK62eiGu79ZD6r9HQFajcCkDJM042fgiS5a6pERVr1DDRvelx8KcACdZQN5K3E/FJw5HE/4zCxYerLuvOI8Oh/W597JFYIYMxj8kiOz7aF6sLGJyLF3N9SJdeJ93/xa6OHeh/YTu84Ra0nnM+eYv1Dunu52XXzWvBcnhe55e6ZD8G2Du8dZ6ID6bE4zpT81vmFtSNKyCvisKyLq7VqgBVIy4kdjQeGcZ89ySaZlLwkdSGU0Np0o12X/QAz9xRf87KfT6WZQ/Z5JsVGYTFu1iE4PBeNQ5rcuU8lPTS5LPwbxwuJDsMjFgB6DnisY1YWMO/ki4sHtvBPbkzjYLQfQwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RbYbo1TrIzQ9/2UOFaqOBCVBcDWG3QjtI0iqOqpKkto=; b=hSsmUlKMs3DUhzYlPAueAI9iHPZQGUAvg6TZ7Gpb0xJHNtf72bbovXWOoRl3595vr3caX8YYxOFbM2HeyhVnwFQRUAyKAO7YMwcXM6a2tqUIUku8iQdlVGojxTlPaD3y+DwJ7UTGz2sb5/uiboh6Ax4X6Z7ESn+i8TUPqRe23kCnFouxkn9QGANn0zhr8lRlRIsVXqOzyJ8hpPf5u3xN2wcFkXHCvLNdOlk/l5eKe+AaJLhV571o0SqegbNHCJJ7sPCLhR+1aGKgyU8K48XePvxh4lmn8MpLg48zcH9WT8VJJ6j1qC93TyDDDUIdXxI7O7Lwe5iksqDDXljGhG9eGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 14:36:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0168.eurprd04.prod.outlook.com (2603:10a6:20b:530::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86b78322-b4e0-43d2-4986-08da3a5d4e60 X-MS-TrafficTypeDiagnostic: DB9PR04MB9329:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CxRayO9utJqCpUq+4e0DNi0lQTIkfyQbxj0Qu+c6V3L5l3qBsy+0JSBGC94IpcUqECwlVGpBGcs8JewcmpiQFuQzuxJO8Uz8BsuoFaz3KoN35aRSJkO0UkBRU7ubGjgpZPyf3wjccC2WXF5dXsgPqMhb8ZxtCGN6vd3zl6TYon2z4Ba+bJEVJ9lXoaEAhLTfr95q8w9WNKhaHwhFDz2D5GBgxlUSQxdY9DV3befbHN5v84ItHw1x6Uk4C08fa5sndbXbGHj5nYkPP/1PGFUk8cZlsv8fwDiffcMJmJaVTSxP81zoRP3J4CwILB1mEldLn/1Yb7ART7m/iPBEiQdaadvr4UqMw0dTkBiJi+kH+ifQXr9zXvoSGYdthDmUtD8nAXWv6xoXw/ZqrCZRXUds1AZlchOYenXKRSS3vMTo/qiA5QvL55l/m9DDhmkX0lnyd/4iqFMCv4DX1yJF+RIJZLeQl/3OtTcH+KdrmfRu+f+4Qh/nhQsdOI8/XeqsdwZY8P6YNRsqtAuhIBlIQM5oO4PVVDFlpcNsN3tHTkiCRxpx8BZIORPm2NbstNYQ+8pIzu3Z+25AxdK9w8ME6aieO9v2RudwThj7rzqocORKbz9VFWidZQirLwou994fIhif50kYcYsI7mPX4pEQunSmrjGbmyjLbOMroh40JNcidBbkO723jwwhTSRuzk4RXG7tFFpIBFc7QMhGuvz7xZv9ijxXEfoKmFWDTD2UVn83EKPhwlbaYpOcVFfeG7RFcuRZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(31686004)(38100700002)(6486002)(186003)(508600001)(54906003)(6506007)(6916009)(26005)(6512007)(2906002)(31696002)(316002)(66946007)(66476007)(8676002)(4326008)(66556008)(83380400001)(86362001)(8936002)(5660300002)(53546011)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q8aUX4qjWUwCAEqeWG3zoTnKudT18tZnkdeD/pwCpj9cR044G+8bk/stc+e0?= =?us-ascii?Q?MSHJz2QcI7qBt7/NaIufvN3NUcOMWCcDZ6h426Cv5iXICdQ3Xd7YWl4OKoA7?= =?us-ascii?Q?9OuSkBRs6Ega3/sO7VfcjiUCIdKf4BZrnbgdsA3ERESkfKFeopOg5nQIwvA6?= =?us-ascii?Q?G0cPdja3CVgegLMbg1RByqsIhx+CWMa89n2CcAogILC2fDAnBTH4VXywNJgW?= =?us-ascii?Q?VojAeljw3CcDjZmXyRwnxVu2i5A5+8vpCpeAtaRdPc7hwqRCD4vsKvrzgPk8?= =?us-ascii?Q?IK/m+m7Os5h83Np+IRBabybI8GZ8kRmMHVUslrzvZkzHLleAU0C0WfbMVt3a?= =?us-ascii?Q?7e1fDBN+TMMRjHpbbMMgcodOl4AQUgPHmDPaEcYzdP6qfgxkrKBaS2BBkHtB?= =?us-ascii?Q?iTSM+KXY1PGQfhvFL5FyvQHnoJu3FGiT8QXIIo7UuAtJeoYwUs60Z0OHAVDf?= =?us-ascii?Q?VbOnkzsntxuRt/pBQ0Mq2IJfio61szyPG0ykM48Aw4TM+ONR7dEdN970Tbb8?= =?us-ascii?Q?k8nE5vNVE5zp0nvtqqg4LlCgIn/st8ezkpxtfDzQymJD0zfxs6MagR52G/+6?= =?us-ascii?Q?S2SXljJJj6tveqBMl1jGIhoz5BXltmpB/ipQRUZMXwcfwq9M84Fcs0y93Ubm?= =?us-ascii?Q?sHjyJp4+Nbfyp35127nVpwK98Mqg40KMSM//94pK9CCEWwthr1UDFaL8uHX4?= =?us-ascii?Q?EjTh/2pvtQ4aK/pv7mBPAKo/gttfAm6n4WU6jTQD9gGGcsiqf/NvvAHZqpCg?= =?us-ascii?Q?8Xk3TaO+vLKqQ62nSQpfyKMObTc2vzyi7d3L1vJrIolvwrqwDMN1bNws2GNa?= =?us-ascii?Q?qmNknXjcTT8IBQXl4taJCkglvSkjuNA7sGIM6rBKiyLIX056IFR/UZVzUcD8?= =?us-ascii?Q?cTRCaRlKe7OJIe0B42ivcnngn0XgNmmFPWHinehIs+9iYCO6T8rvJLxBPcN2?= =?us-ascii?Q?z/BKEpajpAOQ701w3v9kktMCDFX2Hyaw+TNSVcXd051RIVbMWcEsrHV1Nmt4?= =?us-ascii?Q?4Egh25exj7/k4Hb/WXtpi6O46QSyTOd9AqLkKD9uKCM25FPESuKmszmT1mnv?= =?us-ascii?Q?t67f60oSmuu7mQb1svmqnMNJhGco2T+rhTM+T3OAcpB6jfVwlZl4NkiP8FFy?= =?us-ascii?Q?Avnr/SAdd1r/8LTRPFmtDbX3OAhCc4sSr7tUN8UQ1RvWiP3OvcveS67JADFB?= =?us-ascii?Q?/CrwIZ7CKESjsozfCCL89WlAJoZXmuqb/r+MQtWfAY8o0CL880Jhwl2TYDlF?= =?us-ascii?Q?kjEA8Ji2mq2Fmpy/b80zTs8zO76HjvXvHkpgBJGPolEg0qMlnlRD6qnvfMEO?= =?us-ascii?Q?s0abzvtjo5gSB7qKHWlL46u+xzts5XEYBcKoDTYQRcm1wj1b6QErIQ+bpNjb?= =?us-ascii?Q?EdhWmQ56JClnWJdhnmI3kT++k66j2ycQYVxIQW0wLggHHbLD7B4sj7NYkcfF?= =?us-ascii?Q?BMMC+9LO5HLM41pvYFkQQitoBd4ZLqveuNBJLqhTjkcMQMEUWO2onpWeTdj7?= =?us-ascii?Q?ANBU9soYfmbi6OFzIrplSayRa0pk2M/tif/zfuHejZiWpU2jdu6OIbHu63A7?= =?us-ascii?Q?E0O0cM9XhRR/rEdrIayish6WpUGb5tmWo+0isNU9HC3AKJ2GcV9d7rpxxKDO?= =?us-ascii?Q?nbJ4YsYrjc4pm56wGTP981wPA3TuYqBqKTYpwExxSZHdbJSbpnQC9uJRdiro?= =?us-ascii?Q?8Bf+OKp1LKt2uFYd1HXiOCSQy6sM2LJAlbyHsynHM0njxuroNi7FbiTGI5bT?= =?us-ascii?Q?6rpar9eHgg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86b78322-b4e0-43d2-4986-08da3a5d4e60 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:36:04.9055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LieC0Y8UUkqN69fgVlfn8goB9gD7VObzjl63dSn/pO2Rc9LdSl2F9M0sdV7TnuY3nVjj+Z+HtuPXkx/0tV55hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9329 On 20.05.2022 14:22, Roger Pau Monn=C3=A9 wrote: > On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: >> On 20.05.2022 13:11, Jan Beulich wrote: >>> On 20.05.2022 12:47, Roger Pau Monn=C3=A9 wrote: >>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: >>>>> On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: >>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c >>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c >>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >>>>>>> =20 >>>>>>> while ( nr_ptes-- ) >>>>>>> { >>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >>>>>>> + ASSERT(!pde->next_level); >>>>>>> + ASSERT(!pde->u); >>>>>>> + >>>>>>> + if ( pde > table ) >>>>>>> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table= )); >>>>>>> + else >>>>>>> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >>>>>> >>>>>> I think PAGETABLE_ORDER would be clearer here. >>>>> >>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used any= where >>>>> in IOMMU code afaics. >>>> >>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not >>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use in >>>> IOMMU code but not PAGETABLE_ORDER. >>> >>> Hmm, yes and no. But for consistency with other IOMMU code I may want >>> to switch to PAGE_SHIFT_4K. >> >> Except that, with the plan to re-use pt_update_contig_markers() for CPU- >> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. >=20 > Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? pt_update_contig_markers() isn't IOMMU code; since I've said I'd switch to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I could at the same time start using PAGETABLE_ORDER there. What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correct/ consistent, ... > IMO it makes the code quite easier to understand. ... or in fact helping readability. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 12:36:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:36:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334076.558054 (Exim 4.92) (envelope-from ) id 1ns1rg-00034o-99; Fri, 20 May 2022 12:36:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334076.558054; Fri, 20 May 2022 12:36:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1rg-00034h-5q; Fri, 20 May 2022 12:36:20 +0000 Received: by outflank-mailman (input) for mailman id 334076; Fri, 20 May 2022 12:36:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1re-0002mR-MC for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:36:18 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68a20581-d839-11ec-837e-e5687231ffcc; Fri, 20 May 2022 14:36:03 +0200 (CEST) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 08:36:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB4884.namprd03.prod.outlook.com (2603:10b6:408:9c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 12:36:13 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 12:36:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68a20581-d839-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653050177; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xC0vjxIyRbNHBiwFx1Dc/YcynbgE7HtDZkd+l5hF/+o=; b=NBGfhLbPeNyy9zgBtBmYbj7b7sguocZlf0iSHcxyc3A/bAnthg/tXr2C p7R6m8HyMqkaIICS3ibJwsEVFbAcbR4xvRzrVO5/72t8ln5fSUXyfAzIp ZtbN2zdHp7CZbtAeoe4jnLI/+6ZhLYNz5Otdk4VOIJV/hSSVlOWysYUE/ c=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 71791870 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:abekAqtjAOHgOxzSAKgD+kkDxefnVEZfMUV32f8akzHdYApBsoF/q tZmKWiDOKuKYGqgL913bYjj9RsDsZXXz4dqSVNlrio9RSwW+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X4 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi92ELbTtOAabyNHAisvM45B2+/dMCmW5Jn7I03uKxMAwt1IJWRvZMgz3b8yBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IGmm5v2aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3M+vtuszeLpOB3+LPKAOiWZJuYefl6px2E+ mviuGrIXg5PYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUS6wyTy6yS/weQAEAFSCJMbJots8pebSQjy 1uhj97vQzt1v9WopWm1876VqXa5PnETJGpbPCscF1JavJ/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//AgpJMisRiFaZWrGV IronPort-HdrOrdr: A9a23:XsGkFagY8BcHNOagorZkyKzP3HBQX0l13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCJSWa+eAcWSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AWV0gK1XYcNu/0KDwVeOEQbqBJbq Z0q/A37gZJPh8sH7SGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5c9zp/8tHN1A7dg6MLqK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb WpaiIriYd1QTOlNfGz X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71791870" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=an5sUqBXr8IcAfL200XPJ+S/O4/F8Ao6vycDvTwA9/WvYpdAT42k9nXpQzI2Kc1KoonPRpmONNhvccosvsp4LEi4gwRH3cH5Wzkksi4o9b1uQwUEi30H2uWSDykrHSqWl/3R6xHQPPvQfVPvO9IFv1ltDJ7KUZLwRGcDgISxPD6rgS0bKM7HDHL3PaRSeN6b0P07AzlOBfERUsXsleAoXgGV1oAjKBNgRxibOFdnN6O+F/sc7YiorP/VJ0PvHNuhqhUZU9bTSrrMZm8qH+wIMNGRp92C640vXxxcRF4Vl648TEpGF+a0F2XDHuLt3PHM73xBg/DO4fCjfgFYw8w/BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7zxTzpyk1fZJOjHA/b3qnVUkyP1pYre8UY2eBMabXVs=; b=J6rQu0YbdtAFR5/+eZczzPibK3oFkWqoMCB6cLfAxZeOIeRT8zgZQYyo7tr+93/QTxB0N80Tua20doojzA9fP8pJBnx8KvndvBTXUPtz/zhP3a7EVfbIuIaDlhQYQIlL1bh0LRa5Xvx39WMibuXkZGPsC2w559W/QXL3MrXTv8wEBU/HHPgRjteoTHacpmA3xAKGdEdB1DPFB/UT7GKYYOwaT9x4HdmGO9Y+qw5ppkzeqgaGWf0OkV/xx/fb9rYAU7UL+SrTsQGk5fXFdRFhdzKlzRHrg23A5j3nci50PwK9jwspGnzWAM1b7py6lN9nIlcxzoRXIVqCdVmgdURjdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7zxTzpyk1fZJOjHA/b3qnVUkyP1pYre8UY2eBMabXVs=; b=QNkct4mHGX5kfbGFt1aC4jIglPZZeBSi0FtR1Yhlsoqe08EzoFtJcXY+edblGgUbumWdowY0/fy/Z6btgpBkgSQoA2nOVSypHilAi8oHsJYCdniwZGSrIlzjxpy7Xw6x6tATXleSS1tEKxrxpiyLCZD7fxwGpucVsCxLdLoskzQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 14:36:08 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Wei Liu , Kevin Tian , Paul Durrant Subject: Re: [PATCH RFC 0/6] x86/ioapic: fix edge triggered interrupt migration Message-ID: References: <20220421132114.35118-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220421132114.35118-1-roger.pau@citrix.com> X-ClientProxiedBy: LO4P123CA0293.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47f12388-7c07-43b7-8286-08da3a5d52e5 X-MS-TrafficTypeDiagnostic: BN8PR03MB4884:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nMX/OPwyI3Sd4d8MsFEP3l3Ti+PH81/jNvM4TS96/QSXKmxQKeZZUV1wpw8km0sowsdJiCCk4avFk6Q/vMcC0hMDMvFr9jX0gkSawQpdukBfPQ5ap78GSjp8K5MV057p2J1YTZEh33nY8nv/PSxq4t1s6ky9/rrX6qsawSt5tpqixk7zvIM/0yPUbdyLAN8KUkiJl24NEfuDjZDo6vzoQ1CFiRUgVYKwS0es58ebRjI22V3leBmXEjDmlR36EybbDkPu5a0npa/bvgHyjIYw4/Z69TJTwf9vztMWTnnTahLcwD9EF5i+8t2sNp3HhzHGcUxz3Kg5ik7FHuIylAQMeYW4Ouat1Hyjm/A8E+oVtEAkl5LGZZz9t9zf/st/rOtRK6hAzwxSdLHIiVilA6ZRdn2CDQVChOnZPAW2pOEdJxexkusG5ZT0vF37FtYBeOU8fiW0xrDxWCyu08E6S0VspT7e6+IwPEbnMcqY2XYpEBwqgbHNMXuWd1i1MYU2DhHK9mNuTks4bRVfCYXl9SI4Lna6qS4Gz9H3lrXesYog//JCfA9O0eWko4pOfsxgUeihxjWeDivh0D2IOaQAzOJ9ap9YjwP9kl+49WTxGOzcMoa3RUXzM+McbTQtLdMA3LaPp1o4SYdxOUCkzeW/DUN4VLzy2ZeY0JYPk4vr+Z4QUD4s3l7Kj6Yaiwm8NrpSZ+DbkNujeSfIcpWoIqt1obyzzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(86362001)(6506007)(8676002)(4326008)(2906002)(66946007)(9686003)(4744005)(6916009)(6512007)(6666004)(54906003)(26005)(186003)(66476007)(66556008)(5660300002)(38100700002)(316002)(6486002)(33716001)(8936002)(508600001)(82960400001)(83380400001)(85182001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0d4NEZzZE4wT0ZGVDRoSysvMU9XL0ZwUHRvVGpkNzJhcFdCZFVjZ0dZZDRM?= =?utf-8?B?ZXVXMk8yTUJuMDk3WnQvRms5OXE1a3FtQ0xqWStrdmY0MzFubndUQ2JOdEMy?= =?utf-8?B?Y05OblRNZEY2eW5zNmx4KzJwQmxMUTNZenhDOURnQ1UwQmhuZkhldWpzOGc2?= =?utf-8?B?ZklLRjU0ZGF2NUx6Q0VQK294bVVZd3FCc1NXaGp1emExK2d3Y3liWDlxck9k?= =?utf-8?B?dlUydmF3OEh4RVE1YkE0UitMbFpld280Q043Z25uOUtpOUtKaXdYZHQwK2tR?= =?utf-8?B?NEk1TVVybG1VMFFIU1NSUWs1eGdpS21zeEpERzFHT0piVmpEanlYMXFXNmxz?= =?utf-8?B?bEdzZVpaVGl3c2tMRDNIc0p4V0ZzMEVPdmJpdnpnNDlPazdoSmpKb3UvYXg4?= =?utf-8?B?UjR3cjUxWGNZc2JoOUhWRWRDKzdudmV2bGMwcFh4dlF3d0V3WXpleXgxQWt5?= =?utf-8?B?Z0VJblpBWDZMZHBtRkx0enpPbWdOTnp1MXh0UHl6cVJqY2ZhcGsxNDg5YVlG?= =?utf-8?B?S2lJYUttL1FoZWJ0VVh3NUFCUE5YckRlYlhYSVc3bmRHU0FYbUY5RWUvdmtw?= =?utf-8?B?eDNQRWVGYUJxVmNDMjRtWWZIVU53OVN3Y0wrYmp5MjRGZysxMWxxU2U1WS9D?= =?utf-8?B?TmZQdXpscm1iRUJDN2N4aDErWklUK2lSV1Y1RXF1akZRM1Q2OWp2azB4OWxO?= =?utf-8?B?RTI2OHlpWFlYQnA1L2NnRisxTWd0S2pDV20zREhJM0RWdGpEbUFqeDl3OHhZ?= =?utf-8?B?Y0tUTkZKeXh1SnlTNktDMGtsZElqY1lKbWNXRnk3eXBENHgxRDVwSThQa3kz?= =?utf-8?B?Q1d6UFFCN0RJZWlENU9wQ1pVN3oyL21aTzg0Wlh6SWpLL2dTQXo4cTJqaTB4?= =?utf-8?B?MVpEdEJZaVgvZWlBdEh6QytSR0VnZ1ZqeEovcGhWUnduUUtNWTZKL1hzeVJs?= =?utf-8?B?dk0xcjY3N2pjSHJFM0cwRTVUU0dhVEp3eExnM011YUQrNjBCNlVLSnFTWmN0?= =?utf-8?B?SlhDY1hMampJYzJ5aUZSVFZ4UlgvY1ZPQ1ZidFArT2hCazg0Qk01R2NWSlZo?= =?utf-8?B?MnloelJlMWg0WHl1aHFLdFVjamNPUk5QN1NUWmpFaUhsWVZsUEEyT0NCNzNW?= =?utf-8?B?NkVrTzNrMDZKQ2x3aXQ5d3RET295QUdzSkdEbjcySDRBeEs0Z0RkRkZhWkcr?= =?utf-8?B?cFltemdwakxOejgxWTF5WjMxMmFzaHB2byt2QkFsbVVTMEdGUnpoOHNmb3dV?= =?utf-8?B?SCt1eVovZ3RkTTMrNDYwTlNyVmNzaUd4dDJEYzd3VXVPWlJ0aEp1VEdsS1R5?= =?utf-8?B?WldJaEpQREFIODc5UURmd21FYUhmU1I2MXdTeEowMkVjYnZ2ZjZ3cXNrNDMx?= =?utf-8?B?VFpNV2gydlYrNy9pQTJRNzgvVXFjNUxUL0s3YVpJSHF5OXpBN1JoVkRYTmpy?= =?utf-8?B?M3A5VFpuN3RjNU92R0tDMnNISFBtc3ZVNm9lRE1GOG5XUnExcDNRTjRLMUQz?= =?utf-8?B?ZmpyK2pPcDN5RUhJY012c0ovZ3VsTUlZQ3NSazF3c2t6NDkzZW5CazMxT3JE?= =?utf-8?B?dlYwYU5OOVJPbTFkQ0xud3IyTnArZHRUSE5xVkt1SUJrbTBmelpoUUljTDhr?= =?utf-8?B?eUlIeW14QnpHZ0NDcXNFaS8rcnNodE9oWGZ1K2NVdkhGQUZSRTNSS0M3WUdV?= =?utf-8?B?UDQyMTVueTBzVjFMNVhySUVZNmpqSzByajlOSzFvTnk4cndpNk1RbkNZUmt5?= =?utf-8?B?a2JTR3cxUkdURmcvMzYvUDBTOG1kSGI5YjdmNVlWeWFKaklaUGY5djE5ajhz?= =?utf-8?B?RW85bitCM25mS0d0MDVYdnpxTnZpWC9TMG1YQmxrZTErMjQ5Rll6ZWRrOTk0?= =?utf-8?B?UlQ5UW0wbURDWHMycGF4WGlyb2pRSEpmN3c1allJZ3pOMkpwS0t1c1Z4ZFho?= =?utf-8?B?SXpLdkc1WU14ZmF4NWw0MzJndXFZZE4rMEg5YTdvTDkzSEVBNUtVUk5NTVpx?= =?utf-8?B?Z0J3ZFB1YmlQc1dHT3QxMVdmYUxvNFI0MXZJN09pSWRtL2tOODFrNTJMQmtG?= =?utf-8?B?WjF1WHBWMjhPbjN3UXRIZzFGTDFaOFA2TmhTRzNKOXdoUmtRRlVFS0xoR2ZX?= =?utf-8?B?Q0R1K3hYWUlGb29jMklLYWs2cUw0MzVoLzZMQzIrZUc1bWV4NUY2TUh3Qmxl?= =?utf-8?B?eXNVcTBXbmJxTDBXMnpwelVFSUpMR3FHWlRuQjFURDE3c29nQTdHYzZQZUxC?= =?utf-8?B?M2MxZDFTNDBGNmUzamVDR1lPdjB6RDhSbDdLelIvaVZhOHlBT1BLdXFud3RT?= =?utf-8?B?Nlg3MGRYdUUvWmZaM3VuM0pmOHNRK3BoRnNYVVVxc2xWeWI3emJiWWpFeHRa?= =?utf-8?Q?pRdq1gPymS7Tr0VE=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47f12388-7c07-43b7-8286-08da3a5d52e5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:36:12.8343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GNuwrk27+BzNcmJC2FCrLGCsYkI1uSJ1QMPXpfDTxmDrJPwozb2HYxdecb9Mb0EoBtj140fnABnop2t0hwIrCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4884 On Thu, Apr 21, 2022 at 03:21:08PM +0200, Roger Pau Monne wrote: > Hello, > > Following series attempts to solve the issue with IO-APIC edge triggered > interrupts seeing an inconsistent RTE or IRTE when injected while being > migrated. > > It's currently RFC because some patches have post commit message notes, > and because I'm not sure if patch 1 is really needed. I originally had > the idea of suggesting to only backport patch 1 in order to fix the > issue in older releases, while leaving the more complex (and thus > error prone) IOMMU changes in unstable. Note however that patch 1 is > just a workaround to prevent interrupts seeing inconsistent entries > while being updated, masking the entry just makes the warning go away, > but the interrupt will be lost. Ping? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 12:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334092.558065 (Exim 4.92) (envelope-from ) id 1ns1sq-0003xv-K5; Fri, 20 May 2022 12:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334092.558065; Fri, 20 May 2022 12:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1sq-0003xo-GD; Fri, 20 May 2022 12:37:32 +0000 Received: by outflank-mailman (input) for mailman id 334092; Fri, 20 May 2022 12:37:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1so-0003xd-AX for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:37:30 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93e8612d-d839-11ec-837e-e5687231ffcc; Fri, 20 May 2022 14:37:15 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 94C055C01D1; Fri, 20 May 2022 08:37:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 May 2022 08:37:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 May 2022 08:37:28 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93e8612d-d839-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653050248; x= 1653136648; bh=05LDLzDpQgSVtdIYI1dti9Q3kXv2e4QWs6tuSTHMGR8=; b=T UYiNdKHY9eZpMqgxGQHkt2/+NVyeXur3TL4eDI/AfXZSfyuMoX5iDgT+1rqj3WBu zA/YXQmZlSxcpU89Am8zCvgmx6MlFaD3Cz5oxA5ItyauL9AjAdfIMmnPLHVevAj2 H+zI+NYKGnWHQejytafAXn/gj3JOF46LXAvG9AzitLt3x6TtQiHNLO3j92kjknvX DnoPWgxTHoixnRdD1xxknL/sj049w8JadfiONffBVIZZFex5+D5SPmGV+SDB0AHn uO47mnW4QkQ0n7YJRHpgFYG7xDvvzbtwWArQkYnoc4BCj8fVfAjyuXSfqEAcjRmF x+wmy2IhEjm2M/Dt5gvIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653050248; x=1653136648; bh=05LDLzDpQgSVtdIYI1dti9Q3kXv2 e4QWs6tuSTHMGR8=; b=oIqHE2aKJ9oojLMRgYfOZnX7TVNI9Wf9PNN9lCxXBfv2 Q2xHjWAtj7X/yLorLzaqQ9RIm8siY1986Lx/+liOuuJ476Rx/LeHCv9Hnzp3qgAq oUITqjf+sZnvNA+OoDBSWMnb7gE2GtPn6+TYti62/pzZRv/6K3b24a4T+1cuxXRz 9ErvGJ+v39nFcPHQH055xkomXc0pEKyVA9yk+XHQ0GGNECT2yOaK/+x47cdj0Nr1 C7OrCXrEkKvncSpaSDDY24sWp+UYbD1e320HixwxJQPloOVD2AUnWzFUejFQJVfV 5M46vymR4ajGopyWgR0HJpr39tRMhdxikHzz4Diycw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffegfffg uddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 20 May 2022 08:37:25 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Xen developer discussion Subject: Re: Grant operation batching Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uuRkDiSCjN6lALX7" Content-Disposition: inline In-Reply-To: --uuRkDiSCjN6lALX7 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 20 May 2022 08:37:25 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Xen developer discussion Subject: Re: Grant operation batching On Fri, May 20, 2022 at 08:24:48AM +0200, Jan Beulich wrote: > On 20.05.2022 01:22, Demi Marie Obenour wrote: > > It is well known that mapping and unmapping grants is expensive, which > > is why blkback has persistent grants. Could this cost be mitigated by > > batching, and if it was, would it affect the tradeoff of memcpy() vs > > grant table operations? >=20 > Which backend driver are you thinking about? The in-kernel Linux > xen-blkback already batches grant operations, afaics. Such > batching is helpful, but the main cost is assumed (known?) to be > with the (installing and) tearing down of the actual mappings of > the guest pages (into/)from backend address space. My thought was that the expensive part of this is TLB flushes, which are only needed once per batch. Also, what do you think about the =E2=80=9Cuns= afe=E2=80=9D mode? It would only be unsafe if the backend is untrusted, but it is quite common for the backend to be trusted. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --uuRkDiSCjN6lALX7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKHi4cACgkQsoi1X/+c IsF2mxAAozWbWyuKKLqdBLmQ+zK4PH4uPR6QlSSE5rmtj5tYgTcrxqJGHGcgvIbe 43SG91VRlUHkfuZq/X/eDN1cTzdkTRZqmuOT4Mz9UzYCTxbxtVrAetBt2kndjxmo YjjXi76Uk2k2ugSf6RZ1Cma29bINDg6DoeDq07tUeEGyo0mtGv/KsZ5UjSqiP5sx 3HLnIiTRfXC3Lj84s0IBj0Rp/8ee0SQijwZCim2HwOMXUXMKYMlYD+umJ8r0z/um X6EQ+iqr4wcv2ZOqrwPmkd+bFfiNDF62gRIB77razlGDzx6uk0Pp0oWgp5RKXSSa J750io542n8AjAcShmKetyFszymQXWqeIcFVZdfYD+i45oJk6udqv3/M6LDvB2Sx YXsmaVXR7RDGWf30aTuSMl7U/iob+q+bwkdTTmHgyvCrHrkc13lQ1r8Gkz8cwOdt MPqMgbgH16bvDXF4bxNOY5QJlco8BGkwy1LLe7PSCp6nmrbaKwiBws4yGwdaxYcn rY8v1dgxXMlquGSYX66smFThCLkORLhMZcUVUTzXRH7WtRst4MkwGsPJuUwPEkSa B82y4YY9YmIWBtzVbztrFGkjn42NRyCWtOcUoeiq5sR1ChHic8EUaT2XX58yIXuo RB7Fw9WG3UVOs8YmJD9FYPeWPRZQHyjoB8/+xPE1/6EvONkAOqs= =JyL7 -----END PGP SIGNATURE----- --uuRkDiSCjN6lALX7-- From xen-devel-bounces@lists.xenproject.org Fri May 20 12:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334105.558075 (Exim 4.92) (envelope-from ) id 1ns1zy-0005Sp-Dx; Fri, 20 May 2022 12:44:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334105.558075; Fri, 20 May 2022 12:44:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1zy-0005Si-B8; Fri, 20 May 2022 12:44:54 +0000 Received: by outflank-mailman (input) for mailman id 334105; Fri, 20 May 2022 12:44:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns1zw-0005Sc-Fd for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:44:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3d75733-d83a-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 14:44:51 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-DCDIeMV0MYqPUcGkQQbvJQ-1; Fri, 20 May 2022 14:44:49 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3939.eurprd04.prod.outlook.com (2603:10a6:208:11::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 12:44:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 12:44:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3d75733-d83a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653050690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vOAws/wsV/QYxvOOqHizxZvbK5vPT37ezCSxJrWLu8o=; b=VlBVtw+l4OqJi69zh067H6Gk+kK+4Nar537FliLzwkl8lMWqohc0H8FucXk4wEwERaKTsG 1B6uo1jRv+Hl7CCmHsXReOdYUnzt7qO3OS4vUcsssu2assNOLBtIgVfn9yaLSKA9SdUDAA DN5gPHtTfFYxg9wajl7bsAJwFE8FaPE= X-MC-Unique: DCDIeMV0MYqPUcGkQQbvJQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SovPfNRLfZvgDo4Oye7nLSy3au27lWEsvpmC+U0jKxcVc4/ePl8e9QoBvsxd0pXlLc9DPmFZnZWXYfEUis0C4o9HkS8jaYCyyYGzdRaqy38b4nIgybPF7JaHxSGimmyJELoxbImfHVYSMeAO7GpwdOEbh3e5/mvMRAtHOW+XxZAo0qb4KyxYgEKQ4gaHcUPwhOLbd5lWeV2Nt0OyUiV9nU2I0I6iD+kIoyHCvXhuw8Se8DkDgT6HHW3EDNym5XJ3+fJTuAGs2gWqC8JlVldN56N2LQhy9UWzWYyU1v18OAr83hOhk5VwDq3vD4OxVZ+C/Url6c+o61DxH45FRhrhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHuxhy7yweiZSN67XVLHur0kY5HDi7JRRSlgZscP/k4=; b=Tr3bRj52O7m4xvos3dOlRVZalqcaPddYT3lu/k28KCp675EuSihrjL7jA6yrDfg1Zp8i2lWSIYRk+f487sI08yulCHmzReU/dwWruAhAsKkds55Tegwu+MVzKZY9V/3vLDI5pK+O94G3mpTAmz2NrQnx6s+ckWDmypby5LignEFKti4QYDYFeYoWZm/PCsbpwErXJZd5TBPVHx1cSWCaYFisZLw6TfuP6FE8qjuyrHJCca93udmiLPwl6KJ2CfCU9qH01iefxuU4C+/mXKnbt6hPYrQC+jzbdtlYr4Lg9a54XfeWR8xOWFeW+cYbhQJb/HXVOcnOmA2vadBHeCwlxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29616926-abcb-1fea-740e-a7b938c8befc@suse.com> Date: Fri, 20 May 2022 14:44:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: Grant operation batching Content-Language: en-US To: Demi Marie Obenour CC: Xen developer discussion References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7d731db-2c37-4f03-dda5-08da3a5e861d X-MS-TrafficTypeDiagnostic: AM0PR0402MB3939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y208dbip6asa6fR+5roHgk5q+SKcNv/hvNGQTNToa5ojtlZAu/3sjT8lnP1niZtHjL8H/5NGpFW/gpJ+JL2fN8v/erPKEyTdPwmlGaWE6rAI1rHlQmq9Y/hf18Y2i87Jy281eCBDmrY7YIg6sSYcWi0+H8LeYZF9wBGg19PMgqQh0KCDSbvBK6RfdG0xFstIoeU5OyTJaYNqZ7vTLKXIxRbrWWkz1/fjAfoaVGJGgt0U+eBjwBRTsSuYd+jZO70idHhUgLEP/MhIITYd0a8KmR7m7edjXJHpGIMLqfjX55KJEy8z56H2ZOJpLSowpWEbzmRqkDs4MgEXlg+aJPIGUK4+bG3n2BB+PPdbRSqW4I+SxWZQY/jw85cWIK9f6ltMN93uOziLd9eFe/PNSgfSIt3hqTJCgMiXLzcR1s/wYT+L8oW3Uh2s+T1bXO0zFmubeWDDlzIvTeHD88yuYJ6w//vrdvsBWx45y/8EnLPys35JQo/woVEpIt92P/JTE5m7P0456wKofPcUEFmRkv58pUDTWL5mjvSJbjZq1MRr/8Ubz76yVF6sIh5SmwAS+tNxQPweW5DYFFO/munf5SnBUAifBDrFjbPbbWjRx+N1cyAR40vs1XMeYs20BHbDxHP6YxcU8SETSeLph7xA4swUFYrlnngDL2mo3UkKp2wsEk2QWVNaxp4YnR5vrUjeY4oZ7hExt46xMYo4S25tv8xe8aPexgxnDHJAvPYKOPNw76FXXPfoGfIwwFWqrp1/66ha X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(186003)(316002)(6916009)(2906002)(6486002)(36756003)(31686004)(38100700002)(26005)(7116003)(8676002)(4326008)(2616005)(66946007)(86362001)(6512007)(31696002)(66556008)(5660300002)(8936002)(6506007)(3480700007)(508600001)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bB5fmBqx25Tc0Ex/1ywyVSkxTyljvbsgOSIrLHntVS97NN2KIsCL5tpUNdem?= =?us-ascii?Q?ulm6gsn0daU7a8Br+d+AIIi3zDQOFgmo6FmrT/Vhr0xM30qRURh5zBdQL7nA?= =?us-ascii?Q?z2YfuVo6UFnIaADCkNjQXl70G9ugbKnBHE/LQa98ZDLcwxGOXp+QtW3qCSpM?= =?us-ascii?Q?afngHo+LnjsDJ8TexEvwEwLVQQ4VrAXb+sc27FyTf3OyhqRtMRU+9OWjfQbN?= =?us-ascii?Q?5dFdTlRg4aW8WtV7oGihh0lo4hTH2mjne6jmBFCFXJ1NQVP+gxbgZU6JpJ3s?= =?us-ascii?Q?305z05rx94J+xtlyp+hZBYZk79iT6AAYmM3lRW716KLBHaY6NThTs84Pgjla?= =?us-ascii?Q?y/zvNzK88rldIGcRFEWjvDDrtPR8EL6nju4H31l9+nM0QaPEq6tRNhqmSJCG?= =?us-ascii?Q?PGLoLqHTGyNuD9QPcfj8x9CwFy4PNRYSjwd+7ePTNT7VdidWKG/lRe76tZ92?= =?us-ascii?Q?P6vtojSC0CdG7jycSt3IQGY94+0XdLYEpbNzMtO4VvFwEyTNI7kYkIeSNHww?= =?us-ascii?Q?/EPM4ivFaWMRSk4NNd2wQGSwlX8unZ+SPLZhw9k/8spQLiYvagGHU0rvKa0E?= =?us-ascii?Q?KPmXRBcILJb0FRastUXhcRekcZaoOtXjvNBtG2D6Xx9/ScLpfqlV++tjM0aC?= =?us-ascii?Q?kPiplrZMHA/t7v4ryo61tuRA767SGshe+e7LYnDyz40jHUva9EmhrO+bHEnK?= =?us-ascii?Q?LA03+3ISEvmFy4qCwhGCQi5KoACyWu4tkZo8n7O9P225IobmRUrDhugxqNWp?= =?us-ascii?Q?tG/Ab+BvBLXWdgIezVhafhHVBAEQzzN/YFIahipUeYwWAQD2Mc2NhEq75W/E?= =?us-ascii?Q?+qsHbe7rJo06ghp0C/1FSvy4UYOasuOvfPmeMq4uF7+TF7Bk6mtRTkMh4/up?= =?us-ascii?Q?fWjIYsbAmEpx+D3Om1PXHkJx30+f+3Y50z7lLXuka1HbiN1qHoaQPA8jrnnk?= =?us-ascii?Q?cfPexupQ8JOPRXAQ2mxLSJ+aD+60asY5gDGbXbWovSACWj4i365/kjqnnON5?= =?us-ascii?Q?0WykxeLTqO42qnxDSsxyuts+tSbEMBSkXzvC6wKyAME4A6llIXVPY9yGN674?= =?us-ascii?Q?aP1tyCFlPTLGfVg6o2/x8uBjTk/iobQcsIzrnDpzK6Mnp++oyt+0VyYdoDtC?= =?us-ascii?Q?lMJEgcKRGeewtfGcFnnqNa4ADsrljxy+CDK+0pCn9TjPHcaFRl5dkdJWo3Kb?= =?us-ascii?Q?JRIb1//jk9V1kZ9OtpBFZgQB0nE2By8Lc3Q35O7vWvQScUPGehCejtgnOQF+?= =?us-ascii?Q?UFEik673gvnVL/QEkkFN6aSdSMNg0kRplSX8pTNLrfReB21CWwyhNQdSpPeR?= =?us-ascii?Q?PTisDSpjc7MkSqyLJXDdtM+zJ25OpM2czbcOoasuI2S21MWTTsHg3os7ohKF?= =?us-ascii?Q?jkhNb6JOcXFPeOjeECJtGFsT+OmEKEcz7B7EpE3rKcvjms/v4kyjsd9ffpeM?= =?us-ascii?Q?SIcNLQoLn1qZV5QL8+rssFaetpzCQpKcP8LPjrfbJ1+fsdIRXbnPsb7TCEuf?= =?us-ascii?Q?7JPUp8/J1fvU9WHO4sWdXaOSPjpvthjcWhH5Xlm6L+jSNvq0ft/6RpTQT9Ad?= =?us-ascii?Q?Mnb05r7vp28KVlbVn9r2LIzw6bV8034kTCEEazf2oHdKxt44dLPUIGrvsBil?= =?us-ascii?Q?rPjCzl2Wm/++/Z6PFD9BTuOT4VzDxSDij7y81XshfpnJG8Cl163zWJe1mFP0?= =?us-ascii?Q?FO0QGCW0OppJlHji9VKgwH78v33mqLlUdTuLqEm4mzcS1HKNRZIf8++h+nSJ?= =?us-ascii?Q?0PcznRVpLg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7d731db-2c37-4f03-dda5-08da3a5e861d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:44:47.9193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OcenXoNDNp0ywAS485SypeKnb3WBRbttZGJVt6wiXsNfzMLY4uK3n4Z0qNH9kZOkj7F3tf11chUchhWDgJPnDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3939 On 20.05.2022 14:37, Demi Marie Obenour wrote: > On Fri, May 20, 2022 at 08:24:48AM +0200, Jan Beulich wrote: >> On 20.05.2022 01:22, Demi Marie Obenour wrote: >>> It is well known that mapping and unmapping grants is expensive, which >>> is why blkback has persistent grants. Could this cost be mitigated by >>> batching, and if it was, would it affect the tradeoff of memcpy() vs >>> grant table operations? >> >> Which backend driver are you thinking about? The in-kernel Linux >> xen-blkback already batches grant operations, afaics. Such >> batching is helpful, but the main cost is assumed (known?) to be >> with the (installing and) tearing down of the actual mappings of >> the guest pages (into/)from backend address space. >=20 > My thought was that the expensive part of this is TLB flushes, which are > only needed once per batch. Correct, but as said - such batching is already being made use of by the in-kernel Linux backend. Of course "once per batch" is not entirely precise - very large batches would be split internally into smaller chunks, each of which would be followed by a TLB flush. > Also, what do you think about the =E2=80=9Cunsafe=E2=80=9D > mode? It would only be unsafe if the backend is untrusted, but it is > quite common for the backend to be trusted. Well, I didn't put much thought into that (and hence intentionally didn't comment on it), so for now it's only "Why not?" Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 12:46:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:46:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334114.558087 (Exim 4.92) (envelope-from ) id 1ns21n-00066e-Tr; Fri, 20 May 2022 12:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334114.558087; Fri, 20 May 2022 12:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns21n-00066X-Qx; Fri, 20 May 2022 12:46:47 +0000 Received: by outflank-mailman (input) for mailman id 334114; Fri, 20 May 2022 12:46:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns21m-00066R-My for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:46:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dea31cb5-d83a-11ec-837e-e5687231ffcc; Fri, 20 May 2022 14:46:29 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-BPNTWDsIOUeGMrMQ73CQVQ-1; Fri, 20 May 2022 14:46:42 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3939.eurprd04.prod.outlook.com (2603:10a6:208:11::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 12:46:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 12:46:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dea31cb5-d83a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653050803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HK2fVTGtVegtQ6AusFxh4fBv5Hp3P5/RNxuO2jvzwg4=; b=m8pwDluvHASAm4ZpxV6IC8hC2MdO4XRCpNfWnK5GZ8sqTcrLHSPDb1QLhYUmE4ArMTyGKI dvkMs8iYTQcRlBYV7AcKjbGybfM7b1RGZ0fIVnlYfysHEfBp+aK9etyP0QQPHnm5trwAON t1G6xmi0/5M8n34kyvh7JIWCzde4K8o= X-MC-Unique: BPNTWDsIOUeGMrMQ73CQVQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSlnV4ohuYTYf/hTSdebD4aUqvdxRxsTzDN70pBlsS4csreZtEbcp9YVgVIX3cIR6pxRKkY15gwUtGN1kbwaNcaOr1MbXs/4fGjQ6ZRbgfwToLoB3nFi9Ps+0Y9LN9kRpfz+jkFfW+sK4tpGraHOvWFRXHCuhtcS++TBHV40w/xbmisdb/6IYBIq5c+I7aSIo+k5WWWXeHxzwNjXlGIdyk3WRp5fwBE1ninfBE7o8GWC27dg7YxBFYsSrdOvDWECTosFGNgDAggXE4QwOQfyB4eioyFjHM6ISiR4LsvJGY+fo6T8ON22opoOVw0SMVcI0CPkNOp01h2zr6BuUgP/zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+Huf44qyn3w+VmPqL/PA9FWIDimXVfAFTxsaINxHu8=; b=lleWYdP6sIFAO4lyRiyKS1wRKA1tK4p3VFw+OlfjIxpUaGdSzaPO31C9fOt+1p8OA0SstntIHhfcSGeWDwnrHxTCoruec2izSxw/TCaJ8DgjDzPlwjGkMuxwehIB+zWrii8za/YU2CpPVNq2n3pVNdgV7PTf1QJlhBDmIvbdFmbEypmTy90E/WMQe9yjBuhlfy5KCvp7qvTt96g8qg2XVP7/Z7X7PRGSyH8zh+LuMgWB7IzUDbScw7FXxfxT0ERujR87RocA+vYiArTAjGi8vQx3VvQgQiEH32eTzOYY0HlM7m0PGuKAjbbTInIW+9FleONnBUQ9uUsMZhxENn0hXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <02c5d597-70ce-23a7-d48e-0e9d2abe72f1@suse.com> Date: Fri, 20 May 2022 14:46:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH RFC 0/6] x86/ioapic: fix edge triggered interrupt migration Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , Kevin Tian , Paul Durrant , xen-devel@lists.xenproject.org References: <20220421132114.35118-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0043.eurprd07.prod.outlook.com (2603:10a6:20b:459::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c9794a6-0441-476d-322f-08da3a5ec996 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AB6KSOyDvsQ7hp0FJLbREDUbaBwpO/dUy557uifFriApMfy29uoa3RDSENFw1ofUi6FpBM7oeB0tnTE1+onRVXRgmBUFP3jW/V5cekkk/8aSk11v/eU5tWSlhQtqxucPme83oo7kav1eUPmzppqOSWcSD7ZWe0FUW3UldfrUJlvKxM91rh4m8Bvsa10fa8cJ1/1/CpPE2oSL51mJIA+fuz1f8WbIqshqBwo0oz41WnxEk6xMXtSwmuNc+i3bqFalPCpPLIkhyobgUTXZm9P4ApD5Cr0Teqkgt1q0rzsqLpb1MlhlP8zEt5nQhqHzoiBjpulsI4fDXhxukUhu7roNbAqZNxtcxyyEZZsMoHvO1kQ0+2KCeyPFUkAXjw1qB2r9LiQd2KjdqySlH5DYJg63qBjhA8Pnsd4K8zo7Wm9CgnLV0XGaGIv6BIFTznDkdbeZICmNEHHoOJtrsoiaLdBY+RLDiIegnuH6ve8eEvpPHyJdqneKFMHb6nUk+F1vwCxBwI6L1C/78ss8lUdpZhZV2jP6tCXYuERaRvr7K+841wv+wSbXBG+4RkdmrWieqaUEAsaBMbF2Zy8f5VIJTMAgeIDvaJwkvOSfTffEcvsWnuimp56np+M1G4AOl/OszBtNzz6aIhIHZtkv3cT/XcqAzQ0k8BLH0KgEYmA+Zq00uVn/5SGKRVd16cnTTprOiaEsOGDthGtPpwtoWW9QrReH7NsIuyk4uBmiLZ1HGHVe/6ucoOL9gxGc/hVoqYqymjZF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(186003)(316002)(6916009)(54906003)(2906002)(83380400001)(6486002)(36756003)(31686004)(38100700002)(26005)(8676002)(4326008)(2616005)(66946007)(86362001)(6512007)(31696002)(66556008)(5660300002)(8936002)(6506007)(508600001)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KBIUtixCx4EF2zK8vh5buuoxX8Xj2TQjNgCOp9SxQ9839q5dib+rmEo9DG8Y?= =?us-ascii?Q?f1Hm+oXzlMh//SMeKM6rFcGcECsGBExUpZGAKnRKreVic/C61iaAfvjI4Rak?= =?us-ascii?Q?2yk5zBws2heZM6GEryoieHOHcTzh6Rynm2iXdIXMC2ZO+Z6PFdTSzc+WwOc0?= =?us-ascii?Q?uhOFL+uUp0QnFcza07LCMZojqO/NeUojiXL76x9YYTJFukvIzfeaoPKcFZSq?= =?us-ascii?Q?J351IfY+66WNSAHC19j7WCGRbi1lbGeBY9TaoR4oQ4aRRGYNUKgzzj5DFvt2?= =?us-ascii?Q?E/3Q5sS1C4QgbON8aAx5FxrKN28KDS7S2hxDcEmEtbzqPtSXWUMRSOGlzuCj?= =?us-ascii?Q?Zei0ZZ0jXBR5ePmRFaL4lZrauoOFHzPqo7vPYdzhDXSNZvlMQubkjzi7iPkK?= =?us-ascii?Q?ZFac45ixF13TYqosAW09kM/HyMwj/sOOV6UGigQriJ85G8KoqmDMBUuXJEN1?= =?us-ascii?Q?5eV3L12fbRVWQ3QTebym4oHbpu9UYi3tb3jCOCh/82RzR5xv+SvVUiL5yl35?= =?us-ascii?Q?khKnxA8b5TDiJeZq8KLUeCyxnoVxlZ5mpiOofcOGGE1ZEhBumLo6Kdfife0A?= =?us-ascii?Q?VGlXHPGaV5BI0L1gVV8bW5zifynQDWsg9IZpysyG0gzLTh6UQyS1MHkRe2Vv?= =?us-ascii?Q?BULJjdIIVd01CFEm3evpW8mMmsbV2LAkzflgdu3ZvKpQccRg9aRiubAhA1ef?= =?us-ascii?Q?I226c47lJgZux4uEYT7OgsQRn7Urj5Q75PkhJakIP4QvK7CkRGRmhD4dWe9z?= =?us-ascii?Q?8+mU9eNUuWSRt3W5kLYWaNWrLMqo4dlVRdFgkl+pqaGeBb7JPeMtQRwW6knQ?= =?us-ascii?Q?DZx7FoCZbDUWerTqquBvTI8CJGim1TTGuzNoJbhhAa0VxrwDkg6yncurDxza?= =?us-ascii?Q?PV8s83Tbvvq888qHsYDJZsmW/iQwvu1iKQnIUHNObzi8cJ1hzB9FbUw99ESa?= =?us-ascii?Q?XOnvBnFxS0oeVB6YD7r3GncRqUdHjFyPRIkJOrOJdcheJLus19u9I8emQKvB?= =?us-ascii?Q?zFBj3KwfZagBsVpRuPNgHKfViB1v6L9/dZsrE5izcBxgMTtdBCOkW07YVcX1?= =?us-ascii?Q?gHP9u6BRWjp1TKBP8dLa+NVgiX9hVIdVIrWTpBjECSf9HfUMvs/jS3CvVoJC?= =?us-ascii?Q?AfsSYHxC5Y2kz1N+d2Or5dP1pmgEKia+kB4r9FCrTVVn5CoOlXLOv+H+0olc?= =?us-ascii?Q?W6JLYaXtNYQb93wzgeHu4QgjUgna8IVFqg9g0SooQBYxO6rFCGT3A8e2b6eq?= =?us-ascii?Q?JSX2G3MADWmDFrSAJpqXMkpm/mAXHxDMHTm7JoNxaxMEl3ZSMd6ZQpsAqcNH?= =?us-ascii?Q?bmfN1F+NKLcPNt/NYCDy/4SOilDPLB+n//SfPhKusfuaIDcb8AJFc7P9PYfO?= =?us-ascii?Q?K3mmy+xqW6emHmP2+VxWfy1XwCiO3zQa1giCBe4d5hb/i674BgfI/EAgbDuU?= =?us-ascii?Q?EQCFCNCJhJuECTVAgclDfGiHa4uH/piVQISC/Cai/U3DeFozwsTSk5QkEcIc?= =?us-ascii?Q?K4utuqAwfY4eDkYEXMfq9NZ/4Xmu2/pmWPzV8/2iS4b/ZAUp9XDfhIy6nwc9?= =?us-ascii?Q?YxuTOniv0F4T61/PfdfhHAgOBkUExOZjgkG3nMUYggkNr951mvL5YDe1E1l8?= =?us-ascii?Q?gk5ePj9ziVLAFavLo34L1zv+sdD5VnNQjOMqX/mSorbvOCI8hZQzzc7slojL?= =?us-ascii?Q?zzB+9qBvKErBrqCZ0qCvEoFoZa5W/DDyMx3gUwj6rRNFfeMS6s8sSPDBIOn/?= =?us-ascii?Q?Yj3swyKqhg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9794a6-0441-476d-322f-08da3a5ec996 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:46:41.0996 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BNEdCLBc7rw+ZKUJzP33rrRGNKUYtYwhEjfuEkbaxTSdhH48kJX9wajd+ti2pR36W6KNAnzMMNwuXaBd5ip4tA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3939 On 20.05.2022 14:36, Roger Pau Monn=C3=A9 wrote: > On Thu, Apr 21, 2022 at 03:21:08PM +0200, Roger Pau Monne wrote: >> Hello, >> >> Following series attempts to solve the issue with IO-APIC edge triggered >> interrupts seeing an inconsistent RTE or IRTE when injected while being >> migrated. >> >> It's currently RFC because some patches have post commit message notes, >> and because I'm not sure if patch 1 is really needed. I originally had >> the idea of suggesting to only backport patch 1 in order to fix the >> issue in older releases, while leaving the more complex (and thus >> error prone) IOMMU changes in unstable. Note however that patch 1 is >> just a workaround to prevent interrupts seeing inconsistent entries >> while being updated, masking the entry just makes the warning go away, >> but the interrupt will be lost. >=20 > Ping? Sorry, the usual thing with RFCs: They take lower priority than other work items. This series is certainly the first of the several pending RFC series which I mean to get to, but it's hard to predict when this would be. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 12:51:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 12:51:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334122.558098 (Exim 4.92) (envelope-from ) id 1ns26A-0007Wi-HQ; Fri, 20 May 2022 12:51:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334122.558098; Fri, 20 May 2022 12:51:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns26A-0007Wb-DP; Fri, 20 May 2022 12:51:18 +0000 Received: by outflank-mailman (input) for mailman id 334122; Fri, 20 May 2022 12:51:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns269-0007WV-4H for xen-devel@lists.xenproject.org; Fri, 20 May 2022 12:51:17 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8949544a-d83b-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 14:51:16 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-mZRB384WMIqcgr_KTfg2lw-1; Fri, 20 May 2022 14:51:14 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3939.eurprd04.prod.outlook.com (2603:10a6:208:11::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 12:51:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 12:51:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8949544a-d83b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653051075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zt6DIOpsmTW6jf+rRgcJ2dV3ltRHop+tG8FkJT5RAVY=; b=DNx0kak2Ab0hGJODm+UjDynYPU1HRc2m1sS2RaX9m00ekvAZ537gs/x7JKLWdkn7HEStV+ 3VZ+PbR2BdNdGXVAv1dy124uRDL+mjCXYg68iMSgwZLIHU/iw0PREj5+uWdXmguG6Q2J+9 kQRg1UnFJPegqnxfJPbfgDpQoaLmMEY= X-MC-Unique: mZRB384WMIqcgr_KTfg2lw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h7nGei4EokwuJUIZyxIJiKw2+kvpLHaRn/TxFXqolvvlTN/g+4n7GoJuVOfw7+M/rb6I4YEh6/DPWZlpeROP/mdRXKrjDh6WdqxIYaNmrPT2IrWrtnMOnObnxF7MwSM8PAxjwgJRj41g7+7upWAkJRMkU6wDScL4jQesJas3JoD4HqgfOlVLlQzRL9alYrFDhye7Arb2UbmUVLqyngk6vjv0rFY2fZ93iQyJ+Bid4/ZpEjTnq6eZ24vzX8ji2c+KfV4Kxkr7DF1jZMZ8khcShNI61NQ8sgtqVoUSW+sWQQHEqbOHIi8wFqQJJ//kbbaPS/7CiVU4tkcP4VL7dFo+lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zt6DIOpsmTW6jf+rRgcJ2dV3ltRHop+tG8FkJT5RAVY=; b=cSllIJJ8IDo6Fc6eoAfOwaU+HE0VjybUzCHja5OOradKZS2/u2TMMfO33oDSKeullaq0dQBhKLBXMUbpgQAlqBbcfI24htr2fk5o3sXEBOA46hFOvap3hbKAVqoAvMaqr9jrdQykkr2YblgtWfHpWBPYASSFSon816upHJ4BhCY4CJBdUywTX/lN1Ve7esFhAU7zuS44aqLlAEq+19uidBxc4Cd7w6XjsQNyJ/ln89dytp1686/uKLtAM72gdypPtBrYxnjuccRIx9xRgAUNhufrjazy/CrYP8fD9nE0T0JHo81tJ5DPcO6fFVaTkgGdJkHuQ4Byt4KQUKY/xKiPjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 20 May 2022 14:51:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] build: Fix make warning if there is no cppcheck Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> From: Jan Beulich In-Reply-To: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P250CA0010.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e702e45e-3ff2-4fc1-738f-08da3a5f6bd2 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vIdhuzuarx3kxF+G4nst93RVTpvk78eLmYji17NxBq7j9bBiLkJVHEi6BGMjx/6fwTfWodp9XgACx9sunwzrcltKmYDRl64MUVK1+wUlDuFpIGi5RMMFeOatkeZVLKTE3iQ0Rk1BEDYRLR58u3N9DGMC1jDTeiKyZZWBy7Oo77MFatLPFVdg11Zb08ECXlSc5P5EsYhgWqlTskVc20Ly8VxLaBZKK3q+EwrlFGUbdR6bTa71uc/u4rKzrLThaxLr3E+TlZLHhsZybF2amZ4H9xZbXJFvye+LPQmhbqCqcJ2YZIT9Z9wwau+Q4Y+5YNJKe8Er7mqJkqigRNOl+UMk6dW2GK+C2gWcJsAHosvD2GDOdlcrfxlDsYr36MUJbmtIYFsA/lhrCHF00nEcDvxQPTm6dsol7fLe7gdldlEkVLXW1PSo2mn2OPrB3uSj4UvLTS4vPwue/uxl5Byck9qYbyfmPSPTTGs/rVljMKfI3zrCwsK55ih781VrLxAGYbwtqzaWyHusprga5YH2qKbNNr2HNYnsRXpnkDgIY9ZF2JEPCvkR4JQDypMiDc/Ipp1VVb+sclNMNDgeWmNkFLZJEMrsPZRjO4Q/2XL+NtGeEbgIHAhoEJYTXUmXwO3nHrr4pcwjcXRIuiquYR/+TEj7MxW9xoaRi2uhqHKkHFFXsFy3qHKqCBF35zcHiVEymXuWaHFyN62NqAxVY1Yz8fIeFzUx/jIwSTXRvc8fpLw42Ug= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(6512007)(31696002)(66946007)(26005)(8676002)(4326008)(2616005)(66556008)(508600001)(66476007)(8936002)(5660300002)(6506007)(186003)(2906002)(316002)(6916009)(54906003)(53546011)(31686004)(36756003)(38100700002)(6486002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzU3WCtVY3YxOUI1bkxkU3N3Vnl2ZXF0cGh6R0dZUDNOeitDZklxa0RoYUcz?= =?utf-8?B?cEJZZVExb2FWaHR2NnVBaGxoZjg5Z0MrNmhJd0kraXl4QVRkdEJjMXFnN1pk?= =?utf-8?B?WTRBanNBZVVwMmxhbEdmdENsRUVyL3F3RFcza0VNSXgwRFEvdG9EbXJsT3Iz?= =?utf-8?B?SnVQRVA3TEpVTmgraStGaVVyQnF3dlhVT09aWStwb1N6SEIvUmVsNWVodmx0?= =?utf-8?B?OHN5cTJndENzRWpkN0wvQUVxNWNPSndkQWFGaEQ3dDc4ZkQraEhUSURsMkpp?= =?utf-8?B?NHJXTkpUbkVlelgyMUY5dnJqSUtGUWp3VkMxSVk1R0ZydWd4VTllR3pHK0FD?= =?utf-8?B?djJGcWVKc0xramZPaXFRZ0tuSy9oVjRPYVRFQ0NxTFB0OStjQTkzMjhtR3cx?= =?utf-8?B?d1ZxK1Zrclp1YThsYnpSWElCNTRlZUpjM0UvdXN3WUtXR05XNW5BaTRKajRN?= =?utf-8?B?aHVqY3R5dkluTGlkTXF2N3ptUU9iekcveHFsL1BxZjhET0lEdEZJczdNekZo?= =?utf-8?B?bzc5eXNDYjIxL09CaUZCMGU2RmNOYjBCVFhkeWt0clI0aXVZNmNneU1HZHNh?= =?utf-8?B?MGVnNUVOMkNwRVFYUzJLWUZlVFVnVEpqclpONVRGdHB3d0Jhb1FRUzF6dHgv?= =?utf-8?B?UTRub2ZMQWU0c0NyY2xZU2xkeTBxMjFSNXM2VXFKcDY4VnBkM1ErM01RdGFj?= =?utf-8?B?MlpwcHdYczd6dXh6RjR2QWxqM1R2Z0EwL00yZW1lYWFxcG1yaGJBSm5tV2ho?= =?utf-8?B?d2tBL1lRVUpDcDZERUNhaWpWTFhYWDRoU09GOGs4OGtwbUNqQkszMFA0NytG?= =?utf-8?B?YXo3eWE2RVN3ekIvU1k1ME9KQXB0NXBSaG1Bc01SVm1kWFJPMkltc1FwM2pU?= =?utf-8?B?U2JrVmVMODBLNndYeWFidERyUEw1UGIvZFlsREk3Mk9hSS9xWC9yMUNhQzFX?= =?utf-8?B?cURIT3I1T2NZNWUzNnl0bXl4bWx4QlR6UzViT3BRZVhRVTY4ek1QQU1vanJk?= =?utf-8?B?WGRGR0xLN0tJMjQydHVXbHpsSkRwWVh1UTEzbFNIbzAyTTZGeDc5eEk2UlVN?= =?utf-8?B?UldwakJFY3hZZmphRitFR2JhY2hWbDNKYWJaZXZZZEtIU3hHV2FMTHJQaWxK?= =?utf-8?B?ckxXWXlFUDF5RmZVald1aElEM3J2N2dwZlRNWWpJTVE0TFJMUXFvUjZOUGJN?= =?utf-8?B?UGo5L2FwK0x1cHNjRXdvcWpVaEhkbXFNV0FqWUlpMk90RG5lYXFLZUNScDdJ?= =?utf-8?B?WTQrUnlwb3V0ZXQ3L2xWb3dzMFJHd0ZGM1VXcEJ4Wk8zUWh5UGo0OFNsWlBh?= =?utf-8?B?NXkyOXpDaWl5YVdjZDl5QmYwZkxmR2ZINE5yUEQyd2o4bThySzJSSWJOZjlZ?= =?utf-8?B?R1FvOFhXdzd3SFVmd202UkVRclB0MDZ1V3VrYmdhd29URmFwOFp6b3lnL083?= =?utf-8?B?SGVPc2VpMjV0QVpoN203OTQyd3h2WFdwRmRvMHBOK1Nzc2dLbEtIdytJWjFT?= =?utf-8?B?Qkt0ZitzYWFPSG5vNmZpQTNsWHpPOWRCc3lmRUtoeG5YMG16K2dZOWJ6b2xK?= =?utf-8?B?bG5wRmdZSkwzM05kQkpGRVM5WUpYNXlzT3Y3VCtVUDFITUlHTnNzdWs2c3o5?= =?utf-8?B?NC82TU1udFFNVGpCbnVkRjZkUjFpZ0dkM3VlbDVJU0xiWjBjNmVUWGpIeTNr?= =?utf-8?B?d212cTUxUlcwTklOWFlvdHhESnlYK2tReTZBbzdDUDM4TE5ldFBROUphaWR3?= =?utf-8?B?dmdhdHFSSm5pU1FqWEJKZlpKZ01MT3BYZE85bkR0TnIrVG1wTzMvaEdXNngw?= =?utf-8?B?ZWpYbmNVOGZIc3BWcC9vU0lCaHJDUFFWWXZxMWR4eFluWXJ6eFByZURpRllq?= =?utf-8?B?QnFpUVdJTG9FdXRMUHQwaFdoaFFwcThQMEI2OHpZcVJma2pBSjdWUG1GOTZ5?= =?utf-8?B?VUlUYUcvMnhoS0p0eTg4WWF6c0MydnJBVmZFUEpoUGFjeWtBSG0xTHBTVUF2?= =?utf-8?B?alEyeHYyZGY4cTBaVms1cWVXY3Zjc0FWcjF5dnRtV3U2STJHOVM2TzgyUTBS?= =?utf-8?B?bnJtdWplN0Jhd3p2Q2ZYUmdYdXlWeHdvb1ZFbHVFQ3pGM0sxUThtVkxVVTFM?= =?utf-8?B?a0lCbU82K2RnQkFFQ0o0aCtRZytCVVpNeDk2TEFnTzgxQTZ4N2sxd2JEZjAw?= =?utf-8?B?Q0hDUGRoTlBhQnplQzg3S2ptQUlBeWxWblN4RXgvSDBMeXZ4Qmpaai92VEQz?= =?utf-8?B?ZVBveWhsYWhSWXNxY2VpeWhubVdzbTRLdFhYWTdGd1o3bnZjMXJwaXJtYXZI?= =?utf-8?B?ZFhmczJ4YU1uMkRLemhqWW5nYTA1ZlltSGt6YVpYWE1tSEVCYmMzUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e702e45e-3ff2-4fc1-738f-08da3a5f6bd2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 12:51:13.3011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQnBt/JUaeC0J4vw2wDMLosCis/X5yGa8mcma8NAW3hFxi9enoHCBt8WpYi0jF/MkRwlwiwGBF1ynN322rVKZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3939 On 20.05.2022 14:14, Bertrand Marquis wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h > $(call if_changed,cppcheck_xml) > > cppcheck-version: > -ifeq ($(shell which $(CPPCHECK)),) > - $(error Cannot find cppcheck executable: $(CPPCHECK)) > -endif > -ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) > - $(error Please upgrade your cppcheck to version 2.7 or greater) > -endif > + @if ! which $(CPPCHECK) > /dev/null 2>&1; then \ > + echo "Cannot find cppcheck executable: $(CPPCHECK)"; \ > + exit 1; \ > + fi > + @if [ "$$($(CPPCHECK) --version | awk '{print ($$2 < 2.7)}')" -eq 1 ]; then \ > + echo "Please upgrade your cppcheck to version 2.7 or greater"; \ > + exit 1; \ > + fi > > # Put this in generated headers this way it is cleaned by include/Makefile > $(objtree)/include/generated/compiler-def.h: Fine with me, even if - as said on v1 - I would have preferred $(if ...). One question though: Wouldn't it better be $(Q) instead of the two plain @? Preferably with that adjustment (which I guess can be made while committing): Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 13:24:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:24:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334130.558109 (Exim 4.92) (envelope-from ) id 1ns2bf-0002Os-2l; Fri, 20 May 2022 13:23:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334130.558109; Fri, 20 May 2022 13:23:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2be-0002Ol-Vl; Fri, 20 May 2022 13:23:50 +0000 Received: by outflank-mailman (input) for mailman id 334130; Fri, 20 May 2022 13:23:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2bc-0002Of-Qf for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:23:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20618.outbound.protection.outlook.com [2a01:111:f400:7d00::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1381586b-d840-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:23:47 +0200 (CEST) Received: from AM5PR0301CA0035.eurprd03.prod.outlook.com (2603:10a6:206:14::48) by AM0PR08MB3409.eurprd08.prod.outlook.com (2603:10a6:208:d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 13:23:42 +0000 Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::e8) by AM5PR0301CA0035.outlook.office365.com (2603:10a6:206:14::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17 via Frontend Transport; Fri, 20 May 2022 13:23:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 13:23:42 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Fri, 20 May 2022 13:23:41 +0000 Received: from 9fa200a4b361.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D65E51DD-2FD8-402C-A8CF-C736BC6EE937.1; Fri, 20 May 2022 13:23:35 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9fa200a4b361.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 May 2022 13:23:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by HE1PR0802MB2571.eurprd08.prod.outlook.com (2603:10a6:3:e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 13:23:32 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 13:23:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1381586b-d840-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gg6AeYzXkYLeVpKkl7O28+9T4+Yervw/tKqcOFyDiZTut9gTlYGFH009UGFnrhzYVHXs13VYyDZRQLby3BogstVsQ7opFBjSh34qHWV2/S7Qfm7sKFA98x17rl281zQI/+iCUbxBKTRCnSxhfOunHd7J/cE649LtfDGRHBjU48zBmcZJj/llQQvQU1NDxJN2mXsq9IQEol9Rq9+UqF1ICmu1erYyL8dydmrzsesmYr2dtHnMZzlba7s/5qhnp+0myzN77m7X2Jp33q+RhQcTQy6W2NKpIGXvsCRM9P6XS6CSa4mqeHFivdFnN4Zgxd4hgz9Zt7l1K+n1LjmHIfL+HQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tI4pZCi9R5KxIuaVk09t7Djqp4YupJZ8MLecdi6brM=; b=lwwUDylp6nKxJ4dn2ofoVUKHQ7KEBb8LKPrAZBnMvRCNPChtEggzXdiJNeh2iu60r19Vn2xiElyhP+45HRo/U6HDpCuZJdUhfjM4MQihYL+r1Dn1KOHA3/cnp20sSas7Xcw90T8zlzl+btlg7gc1YdHd6q8/KaBEYye9UltBeY7Luk82A9ONfHcgClQBtFD42Ukwi7rbs4DDaZfvFysLTmpCHDfsbhZEx3YCw1Z48Xdl+IwKFkmFz5h9HlAybBmCW9P+DviXrDXlZ7ya5VBQPcrAVkSupUi4Dx59AfOT9N+9wk/u8gkD4Q/k2dxH2GIUKjf6BOC+CjCMS1cJYocdJg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7tI4pZCi9R5KxIuaVk09t7Djqp4YupJZ8MLecdi6brM=; b=sZWEYuKgZb1kHuMfc1un68NBBYsesYk88hlHgyZQdkiN1Ky5p0sBNMCfwSd1AQ0NMWw8/rJN10ZkrkH4gBHmOJvbmBzSgF4YKn1lLuB39pjwMh7W0cdfG0pGi9g2IB9yfO5+ymSs9e7S13pkK89x4pgN7dT0HmRvxIOj58OwtOw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0883335a70f3c399 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oPQHN0TyM6FX8h80G2GTNXSIdRKANIds8iU/Blkm3tA/aa39PlTAVMWDRXg7LNE/J+FWpqajax10S8DgKJjiT61Ri3ZG3lDeZFBOulNESy6sFxOXEdh4zrbFn2ZWfhcRmDehqXX60GTW1cAoKu0epiU7BUdIwJWZ0r8eMFMfE5ZvLZT12l1rsrO/OjA0I4CocdMHhZjEpa6YeRnqT3xOVloBXOxvmlOkkx2w4eIDAQj0/mYjl6dby0XeJ8hcQ+ls8VutPKgyz0UJQC5nolDzsbBewvX0U1fkfqPpEud7l5HXdFi7KMVihLUCvTGIe8Iz/5ysSVt2+Ox8DGK66HZA8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7tI4pZCi9R5KxIuaVk09t7Djqp4YupJZ8MLecdi6brM=; b=lWLUnYNfWol9N1jMIwlmjfzdBlbDy3ksY+EurL9lOpQiavFvhFT3gvzm6D82u3Fr52SrmH78xhbuDkBjG5I1OaDsrKdQcY6rNCTTKEpusdxb0Bf8ctHOj4s5wpjFEtzzOy5dGyU4ZF1hbcSrL2AYPAT9A2iCgkr2EKIUvKMT/ec24y31nqf+S1jWyzHH7AivVNvxx9y7gOO/q6co1/C6lqweTSTnUxcdBLu2wowuTkVawvHqaY4WYZXYB8VqEKf7TDIH7J7hc5qio0tcWorj+cxSRhVM+r8JkilkRFsDNqAvyGpEpQKkob/yLnZfJVCv8Sduj7xC8/OLIW5brQbA0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7tI4pZCi9R5KxIuaVk09t7Djqp4YupJZ8MLecdi6brM=; b=sZWEYuKgZb1kHuMfc1un68NBBYsesYk88hlHgyZQdkiN1Ky5p0sBNMCfwSd1AQ0NMWw8/rJN10ZkrkH4gBHmOJvbmBzSgF4YKn1lLuB39pjwMh7W0cdfG0pGi9g2IB9yfO5+ymSs9e7S13pkK89x4pgN7dT0HmRvxIOj58OwtOw= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] build: Fix make warning if there is no cppcheck Thread-Topic: [PATCH v2] build: Fix make warning if there is no cppcheck Thread-Index: AQHYbEM7+m9qlHUq+EuzILzbZuQ4Yq0nuAgAgAAJCoA= Date: Fri, 20 May 2022 13:23:32 +0000 Message-ID: <3C17CA95-8415-4A05-BD3B-95FE57465C82@arm.com> References: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 01f523c4-4ccb-4a54-2e5e-08da3a63f599 x-ms-traffictypediagnostic: HE1PR0802MB2571:EE_|VE1EUR03FT032:EE_|AM0PR08MB3409:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 06T4hzwr2MSL4IFhxWTIK4Vs6QCr9C0rf9Yjye6kbCaHBupgQi1aeKH1R9Fr3MdbIqCooc6sX88U/bl2LXJNuMc8YrVL88E+sO7K/oKT6taV6/pKq/SyctYcJWOOCR2Uywy7o9B1/Ru13htQvzOrjJn26YBRBUapjYEtqIYlL8z2+XwYSN4nCnvApC0jrRKWsbd0gRY6oOm7H3G48RjD3X/YyQwiOWRfitMtkpq11GiQWk1JRehMSJY/ol5LqWs3WGMoeMc1vx3BTfzkI++qeGwv2I9woOAL7wLDGQhds3GSqfPS2YSoENbJ8U0T6xGgBNbK0DTnVF1o1JCqEIx+wmHI9uJlcpHQ1/mHn4PCPv55I5DxilbOt3TTWfrqky+I6V/xUPHgA7EoLRXlILyrPBz7ESae6vPDDwIvUIWbsDtI3lBARDIzSUwunKXfVyAvAv+yLc1EiSF52bujHNZmCNXzc1ZkyROpegkzrqnPffeMbrmgmQKYtB/gvkJ4udayK0gko90Dh7S/0ECGfLAg/kV3qSB5tlxDqkyIi6KNooFRquOOE/PaKGlM4jaeT7WozaHmz5JwmMfhAT001zBvSSxMD1Am67eXLl1ESsL5JrAISGZ1YxI1lx4+PerYL27nHAJ/XWNRwgkxrmlCwzF581+ytD/yhkPXXQvjhIgJKlUhlBIhiGzKLzU6naq+7fcKyw1DgmJvWz4SzBCgRbYzjuU4yN5Ursfk3N3nq450Zyk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(83380400001)(2906002)(66946007)(66556008)(86362001)(76116006)(5660300002)(316002)(36756003)(91956017)(66446008)(64756008)(66476007)(8676002)(4326008)(6916009)(8936002)(54906003)(122000001)(26005)(508600001)(6486002)(33656002)(2616005)(6506007)(71200400001)(53546011)(6512007)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2571 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6206b90c-3437-453a-5157-08da3a63efa3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S52XVltGuNTbiQSPdZaSmQRA3obKdXgo6+7WAXH3ntfhRr9KO02qy77FTge0JouzjyUaXpzz9IH7n0uNjmcGYHFk7uTgifucNFWD0ydzF+SYP0XSRmndR8K4mkUskphJJabNDOFXABbLB0t3bP7aMVKTFax4ceP0VPjf79Ok0MNIvYNnudaVT9eGRrsImM9rM3TrnshqZqKxNI+Q3nehGt65ovIGExrs5oXVaUC4Yl6SrsjmB27FQcgIYQvSljrXD6ikmOyhXJqaT0IF4fTziGlinEmVoXyM5Ah3P+TJkHol1Y4z06n5eyNfJ8IiSldfZ1+Xy0XMLgXKhLnsjtFKAzZ+v8pyNvao1tL3ZfUY0IV8mszOB4Bma8LpkHb/OYMCFg855T6edM9J5QOQEn75sckHZqv2Oij2Dri23g2sbUO+A9aFOhVdeD9efMVYeo0nuEmp2Dnw9ge4jJ3+3J/0pqLXGbyTi4Q35T2qUSdlDMlQqCW8iOOj5L0rvt/dGj7sd+oLe1re5tsOy8fiPQo/+DwmxXjjmWwDB2Gr/Tnyh5S26N/vFwJuiNb9x/AiiQnpgfc73LNg5WUQQS4Z7YJeY0+8T/eXuMwsXil5PLQLIIPbL6Gwas5WenLILwVDhybX6jDNdT80OYpWCCI3CS6JzFxJmuX3/0pMq6rzEjbeyKIOzIp+3B2FY/8R1jevkyBF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(186003)(36756003)(53546011)(316002)(2906002)(36860700001)(54906003)(336012)(82310400005)(47076005)(6506007)(356005)(5660300002)(40460700003)(83380400001)(33656002)(8676002)(70586007)(6512007)(508600001)(26005)(6486002)(86362001)(70206006)(8936002)(4326008)(6862004)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:23:42.2039 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01f523c4-4ccb-4a54-2e5e-08da3a63f599 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3409 SGksDQoNCj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjUxLCBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjAuMDUuMjAyMiAxNDoxNCwgQmVydHJhbmQgTWFy cXVpcyB3cm90ZToNCj4+IC0tLSBhL3hlbi9NYWtlZmlsZQ0KPj4gKysrIGIveGVuL01ha2VmaWxl DQo+PiBAQCAtNjk0LDEyICs2OTQsMTQgQEAgJChvYmp0cmVlKS8lLmMuY3BwY2hlY2s6ICQoc3Jj dHJlZSkvJS5jICQob2JqdHJlZSkvaW5jbHVkZS9nZW5lcmF0ZWQvYXV0b2NvbmYuaA0KPj4gCSQo Y2FsbCBpZl9jaGFuZ2VkLGNwcGNoZWNrX3htbCkNCj4+IA0KPj4gY3BwY2hlY2stdmVyc2lvbjoN Cj4+IC1pZmVxICgkKHNoZWxsIHdoaWNoICQoQ1BQQ0hFQ0spKSwpDQo+PiAtCSQoZXJyb3IgQ2Fu bm90IGZpbmQgY3BwY2hlY2sgZXhlY3V0YWJsZTogJChDUFBDSEVDSykpDQo+PiAtZW5kaWYNCj4+ IC1pZmVxICgkKHNoZWxsICQoQ1BQQ0hFQ0spIC0tdmVyc2lvbiB8IGF3ayAne3ByaW50ICgkJDIg PCAyLjcpfScpLDEpDQo+PiAtCSQoZXJyb3IgUGxlYXNlIHVwZ3JhZGUgeW91ciBjcHBjaGVjayB0 byB2ZXJzaW9uIDIuNyBvciBncmVhdGVyKQ0KPj4gLWVuZGlmDQo+PiArCUBpZiAhIHdoaWNoICQo Q1BQQ0hFQ0spID4gL2Rldi9udWxsIDI+JjE7IHRoZW4gXA0KPj4gKwkJZWNobyAiQ2Fubm90IGZp bmQgY3BwY2hlY2sgZXhlY3V0YWJsZTogJChDUFBDSEVDSykiOyBcDQo+PiArCQlleGl0IDE7IFwN Cj4+ICsJZmkNCj4+ICsJQGlmIFsgIiQkKCQoQ1BQQ0hFQ0spIC0tdmVyc2lvbiB8IGF3ayAne3By aW50ICgkJDIgPCAyLjcpfScpIiAtZXEgMSBdOyB0aGVuIFwNCj4+ICsJCWVjaG8gIlBsZWFzZSB1 cGdyYWRlIHlvdXIgY3BwY2hlY2sgdG8gdmVyc2lvbiAyLjcgb3IgZ3JlYXRlciI7IFwNCj4+ICsJ CWV4aXQgMTsgXA0KPj4gKwlmaQ0KPj4gDQo+PiAjIFB1dCB0aGlzIGluIGdlbmVyYXRlZCBoZWFk ZXJzIHRoaXMgd2F5IGl0IGlzIGNsZWFuZWQgYnkgaW5jbHVkZS9NYWtlZmlsZQ0KPj4gJChvYmp0 cmVlKS9pbmNsdWRlL2dlbmVyYXRlZC9jb21waWxlci1kZWYuaDoNCj4gDQo+IEZpbmUgd2l0aCBt ZSwgZXZlbiBpZiAtIGFzIHNhaWQgb24gdjEgLSBJIHdvdWxkIGhhdmUgcHJlZmVycmVkICQoaWYg Li4uKS4NCg0KQ291bGQgeW91IGV4cGxhaW4gd2h5IGFuZCB3aGF0IHlvdSBtZWFuIGV4YWN0bHkg Pw0KSSB0aG91Z2h0IHRoZSBjb2RlIHdvdWxkIGJlIG1vcmUgY29tcGxleCBhbmQgbGVzcyBjbGVh ciB1c2luZyBpZiBhbmQgSQ0KZG8gbm90IHNlZSBob3cgaXQgd291bGQgc29sdmUgdGhlIGlzc3Vl IHdpdGggd2hpY2ggYmVpbmcgY2FsbGVkLg0KDQo+IE9uZSBxdWVzdGlvbiB0aG91Z2g6IFdvdWxk bid0IGl0IGJldHRlciBiZSAkKFEpIGluc3RlYWQgb2YgdGhlIHR3byBwbGFpbg0KPiBAPyBQcmVm ZXJhYmx5IHdpdGggdGhhdCBhZGp1c3RtZW50ICh3aGljaCBJIGd1ZXNzIGNhbiBiZSBtYWRlIHdo aWxlDQo+IGNvbW1pdHRpbmcpOg0KDQpJIHRob3VnaHQgb2YgaXQgYnV0IHdobyB3b3VsZCBiZSBp bnRlcmVzdGVkIGluIGFjdHVhbGx5IHNlZWluZyB0aG9zZQ0KY29tbWFuZHMgd2hpY2ggYXJlIG5v dCDigJxidWlsZGluZ+KAnSBhbnl0aGluZy4NCg0KPiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPg0KPiANClRoYW5rcw0KDQpCZXJ0cmFuZA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 20 13:30:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:30:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334139.558120 (Exim 4.92) (envelope-from ) id 1ns2hY-00036n-SR; Fri, 20 May 2022 13:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334139.558120; Fri, 20 May 2022 13:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2hY-00036g-PI; Fri, 20 May 2022 13:29:56 +0000 Received: by outflank-mailman (input) for mailman id 334139; Fri, 20 May 2022 13:29:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2hY-00036W-1o; Fri, 20 May 2022 13:29:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2hX-0007Jk-Vv; Fri, 20 May 2022 13:29:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2hX-0003TN-P6; Fri, 20 May 2022 13:29:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns2hX-0005d1-Ob; Fri, 20 May 2022 13:29:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jugYjj+njNqY2RqDD1k3CzAEisW9686gjr4Ir/lS5xY=; b=q6g0JQ/tKVUWQNbyVr1KpTF2R0 o9Om9SUZ30dma+E8GISRzQfurMzrDjtvcyw82wpjh85ll/f4qX6+B0PjhuVOgc4VDzchWZfVsmC1Y G95X6vB0lNZEjjJOK09cahzSJPxsf2txveILpqjIHf8Mbn42/Rbj7gjhCQKFuimtAOqU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170602: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 13:29:55 +0000 flight 170602 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170602/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1120 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 13:34:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334149.558131 (Exim 4.92) (envelope-from ) id 1ns2lc-0004VN-F0; Fri, 20 May 2022 13:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334149.558131; Fri, 20 May 2022 13:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2lc-0004VG-BP; Fri, 20 May 2022 13:34:08 +0000 Received: by outflank-mailman (input) for mailman id 334149; Fri, 20 May 2022 13:34:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2la-0004VA-NT for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:34:07 +0000 Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7af04742-d841-11ec-837e-e5687231ffcc; Fri, 20 May 2022 15:33:50 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 13:34:01 +0000 Received: by hermes--canary-production-bf1-5d4b57496-srbfg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 457ab9e3e0994f36cbc2ca446594030f; Fri, 20 May 2022 13:33:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7af04742-d841-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653053641; bh=K5D2ddvcAFT7qU/7/cIEJD0V4lwIe18sO6+LKjoJkw4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=PkYqpkkuQo45ByHHvchEhcebEAtp8AaC3/itk3+k6pOYzK1Vl/z8z2g9vmutXN7I+03ApExQ4Y6NLB+mJcTpxYKJvvgyubHih/MqBK1Y11BeD30vqVTc0y1MeyFfiy3rCLZWZIHEDBZC4ahH0inwNJWV4xCg2iwePPljxybrImoNt1fbIhLFEizqXiPa4oducIBTEgo/mA96tSRC+OvtAgX6rD6ayRTLgxi5VR/46+xLeyq6zj6iUiGngD9191uvtGbsX6W2THai8Km28tbUH07O+9GAxGU8OOdoTvL2OxR6ZVpzH1zVjegzIF7Rog41ycBWUqiR2YYy+asOTrHKlw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653053641; bh=k377TC4FGAEpIeRlbM1rv1iA2GuaofkGOp8RBu3yFHW=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ugE6ujVanxC1STiP9viWDUWUTNr/7Wt7WN+8jsE/QCpermZtrtRAmb+JEtTaPCqWvzCLjKRzlFHmOmRlqly5nRy6Pco3dqpWzd+rCRd8nPoHcWX0uXI46JW+Rcxe4e5blbA0AB4+/e0weqdbzBQPr8Fj+4Jjrwt9l6wOn1ngb9jg77j3LsRIUF60sw2r0tJMr2WNI3fO9KAhu+ab9BOdtFRCES0M9WUvS9cMcQFIjtRgQJhFLbegsXhXPke0fJM2W56NR7EOVruOBmrw0REmQHnlmYmIqkHKMcbaTSBFZMhwyRP68X9o9jBO9UAYFlH3wkfHoWT3bBG2Bgi/TZVDoQ== X-YMail-OSG: Y48VktsVM1mw1z0tQFnDRFf5ZFKaFyl88afrKxRgVCgenPdgml44kt9snHULpVT 0hp3_yGN5gR8i1DwVi8RSa8Tjln6rXBvzF_mi6gMpilobbMMYPhnFUsBCXflENor4wEUUZNSmxyw ai48GGw8Y6.jdx043KG_tOo8G4Jmhkj05v3Ch.1Ut3YFFvauy_jNvaiswLqGx_5CkZib26t67mWd v.fg36jpHJlDXy6dFR3IVxO7AZmdzT2ML1jvHYDGU3XniZ_gAxL9hB_5nCYJLjv96xYlLK2yZvWi 7.uHJxWl3WWsJU5PaaHz9vzU0LH4nW9xRufzzv8nU8jKIK0FTuG7UePWKD.QveI1K516F.xFZ2Sv KdFfpBV7t98KX1GzR4CXAi2Fmro4iNkk2gW6KkQYyZvddsSsBvES1Vk3IKz_JaBt46ORP71IICFf _cZQKiIrezoGDURRIwoCo7fuhQBoUPnevV1uuIKBoR08ir2zaE3SrGWq4xQI5NozSPjI6xS8mUcL 8LQREAONgkJvqpkY1ChD1yiEcApxNn3Kg67R_hH9Zag8DjckAboKfmcwhFuLthXYyRQOq.orj1og U6XtQR6s3Z4iNUZNupP178rGJoDuSB.m4ZqG6.rQ33Z9SuuwVo2FJ9CkbGb8VrEqIMmNUMuU96Hm mKYWS3fhCsK5TS6efG98kfRrHdJiyfFRhr2amzI1ru0Yk4OrF68XOnjEubxPzj7CNz7QSYP9ji2k C.ziTjq9SyX9oJ75DCIiheFoncYe3YPD0B6KZaP9NqGUj6jqbxWkLprxJF6jJAN8mna77uif7jLU AdviL5AaGK03B6rKCJu_4YzT1KCElh_OjJdMCtL1iV_HhUiD3pwTRGe5x0MY5mBpML35XU2WoUG. tcJb7gTfdE0yvdGszIy9Mi670l890r258zDdaeeaXNEjkzrJ2tWBVn9kjMJFpFe_aV_FB_IbziQ9 HWabonezKTYBrLnm49Mn9rhQR4LKGlbA5puye05mehZWT0VacflQ.cMQgiiqdwhERh1Re8zSh26m Gk0r57T6lXZ5fDhUXK.tp5RSZbTl4c43W.9qZwG9HUgeNLWNCsl_Bu9HWsk6wtfeciGjagOJHFcl 5ibrmoOf.5n7dpBCLhOnNE5G9OZmS_r81Fup_YgNPry9aBT7cVlfQjvpzHHnuS._UbSYZ0noJWzW BwTcwZByIjHOCmqaqQW8HIW1tA1N_xLmdC8aOkaibNjVLS1FUhD_adW.YKBMGvd2AljWFHM0weoX A1cQNlmZLS7T26QoTblYoV8f6qf0kO5xt_6RevEWsbEUVehI2DrRCE7G1Wfohx.hqi4T8TA.puAQ sv.TrzuZhbSJ7eWZ06OH74Fcdbe_i2p9Y6hoWTeaPkkp6Xoc.hF3XI48Vz9SZuuYaDklhkS_QEYl 5xwQH895VwCP3RL5gqIU_Y4GfhctIUqn9RdQwVxOPkjw_jT2xz7Cle_jzNNKnCf5vL5RaJF1WndL LXx3O1qoLa_wWrbzXSTdSHOh8sOda8aFNeNYBtBmKP4PKP7KuyyslQSSLp2D.MbE3nmkYma5bsWL HMpO40hsuCZmIMaSdc8tqNyPKo1DpY3M_GkEcVGlqG2INwshP294ZHblx.Tcrhk895hodtT3KCG4 iTwjk5odyFIZt8XZMl.NV5MuGr1XuUJgjPDJTf_7B_yqJcGyVDGJKpBmc9fLvmqtJjSue1TsSJK4 uu5gR1eBHHke7g_zT2Zfves6VxMqDUYC9gKikpXfc8fhUzA0cr0eKd9Je61rCWZKILB3.UogNaPC YJPWxETcskk6NC_Wp.RjKC6.4DsmNBjk0XzEAS4uKfqFDLI6XbtCkv04_1l67umJkst_y9XkoAX. xNPe4YNN7394MMO8MyzmWn3iiosn30eO6PBD4v3MbmivZHLxrpIySMuvAWpWF5Yx.13EakdrURU9 vPPVKuDnSfeBAlIQiIlA34.bosrKDPG5EZGLwwJDOVXc5HhFVjCjJcIbe0LfNbHxYwH7H47VQIne hoDB_nqDX4ZY5qJaX_smXDE_i0TB80HHXWa6bplXabf9K2qEBMna3975kd7RoWhKoHXdddkml9ia zYyEnt4j9FimF826VhH8qwOA_1NKnOEDNM3gi6EoQjR5cC2qC5idpK8oxrS1WUzekA3zM52RKYb2 nbRsuf8iAUsVckiUApbxO1aWK1cLqCX3xTvd8CcZK3SrItQxhcDnnSok0e6ZC4KA5tIupcYA6fTg gGjcC X-Sonic-MF: Message-ID: <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> Date: Fri, 20 May 2022 09:33:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> From: Chuck Zmudzinski In-Reply-To: <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5878 On 5/20/2022 5:41 AM, Jan Beulich wrote: > On 20.05.2022 10:30, Chuck Zmudzinski wrote: >> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>> >>>>>>> ... these uses there are several more. You say nothing on why >>>>>>> those want >>>>>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>>>>> and came to the conclusion that these all would also better >>>>>>> observe the >>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>>>>> only predicate). In fact, as said in the description of my earlier >>>>>>> patch, in >>>>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>>>> the >>>>>>> problematic one, which you leave alone. >>>>>> Oh, I missed that one, sorry. >>>>> That is why your patch would not fix my Haswell unless >>>>> it also touches i915_gem_object_pin_map() in >>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>> >>>>>> I wanted to be rather defensive in my changes, but I agree at least >>>>>> the >>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>> I think your approach needs to be more aggressive so it will fix >>>>> all the known false negatives introduced by bdd8b6c98239 >>>>> such as the one in i915_gem_object_pin_map(). >>>>> >>>>> I looked at Jan's approach and I think it would fix the issue >>>>> with my Haswell as long as I don't use the nopat option. I >>>>> really don't have a strong opinion on that question, but I >>>>> think the nopat option as a Linux kernel option, as opposed >>>>> to a hypervisor option, should only affect the kernel, and >>>>> if the hypervisor provides the pat feature, then the kernel >>>>> should not override that, >>>> Hmm, why would the kernel not be allowed to override that? Such >>>> an override would affect only the single domain where the >>>> kernel runs; other domains could take their own decisions. >>>> >>>> Also, for the sake of completeness: "nopat" used when running on >>>> bare metal has the same bad effect on system boot, so there >>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>> that's orthogonal, and I expect the maintainers may not even care >>>> (but tell us "don't do that then"). >> Actually I just did a test with the last official Debian kernel >> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >> applied. In fact, the nopat option does *not* break the i915 driver >> in 5.16. That is, with the nopat option, the i915 driver loads >> normally on both the bare metal and on the Xen hypervisor. >> That means your presumption (and the presumption of >> the author of bdd8b6c98239) that the "nopat" option was >> being observed by the i915 driver is incorrect. Setting "nopat" >> had no effect on my system with Linux 5.16. So after doing these >> tests, I am against the aggressive approach of breaking the i915 >> driver with the "nopat" option because prior to bdd8b6c98239, >> nopat did not break the i915 driver. Why break it now? > Because that's, in my understanding, is the purpose of "nopat" > (not breaking the driver of course - that's a driver bug -, but > having an effect on the driver). I wouldn't call it a driver bug, but an incorrect configuration of the kernel by the user.  I presume X86_FEATURE_PAT is required by the i915 driver and therefore the driver should refuse to disable it if the user requests to disable it and instead warn the user that the driver did not disable the feature, contrary to what the user requested with the nopat option. In any case, my test did not verify that when nopat is set in Linux 5.16, the thread takes the same code path as when nopat is not set, so I am not totally sure that the reason nopat does not break the i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) returns true even when nopat is set. I could test it with a custom log message in 5.16 if that is necessary. Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) to return true in 5.16 when the user requests nopat? I think that is just permitting a bad configuration to break the driver that a well-written operating system should not allow. The i915 driver was, in my opinion, correctly ignoring the nopat option in 5.16 because that option is not compatible with the hardware the i915 driver is trying to initialize and setup at boot time. At least that is my understanding now, but I will need to test it on 5.16 to be sure I understand it correctly. Also, AFAICT, your patch would break the driver when the nopat option is set and only fix the regression introduced by bdd8b6c98239 when nopat is not set on my box, so your patch would introduce a regression relative to Linux 5.16 and earlier for the case when nopat is set on my box. I think your point would be that it is not a regression if it is an incorrect user configuration. I respond by saying a well-written driver should refuse to honor the incorrect configuration requested by the user and instead warn the user that it did not honor the incorrect kernel option. I am only presuming what your patch would do on my box based on what I learned about this problem from my debugging. I can also test your patch on my box to verify that my understanding of it is correct. I also have not yet verified Juergen's patch will not fix it, but I am almost certain it will not unless it is expanded so it also touches i915_gem_object_pin_map() with the fix. I plan to test his patch, but expanded so it touches that function also. I also plan to test your patch with and without nopat and report the results in the thread where you posted your patch. Hopefully by tomorrow I will have the results. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334158.558153 (Exim 4.92) (envelope-from ) id 1ns2pc-0005N0-Fa; Fri, 20 May 2022 13:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334158.558153; Fri, 20 May 2022 13:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pc-0005Mr-Bx; Fri, 20 May 2022 13:38:16 +0000 Received: by outflank-mailman (input) for mailman id 334158; Fri, 20 May 2022 13:38:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pa-00056k-RB for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:15 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 162db06d-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:12 +0200 (CEST) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:00 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:37:59 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:37:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 162db06d-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053892; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=VYJh6n90s2Z2f/hoLcEnXwqvv8sM0GrhXmOREGpZMZU=; b=IWhnK4FXXQwAldDPRSem5oWpjEGTh3iOv9zXbHgodpDt+fEguJgduwbp FrQtzCONK68aPFgIfKVBpgR7OqCU/4Kw6R5nV2/wC6Xo9/I5j1KW0yaRG cauOBirdoGHTySlhfE0NF/YpI56RtwhFRT0Zb4Thixzah2oCjEsIReyQy g=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 71798612 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vbAiuqnmbid3PJ4c44GMCEHo5gykJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJMCmCEOv6Ja2SmeI0iOoqxp04G6JbRy99nGQJt+3o0QyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVvV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYWV0WP4yTkcAkWggBHiBGAYdg57/tLi3q2SCT5xWun3rE5dxLVRlzF6tHv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOVvZkBhGpYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8Q3E9fRuuQA/yiR32ZOuNeLqSuW1RJ1fsHeFu D/ozmDAV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN kgV8SoGtrUp+QqgSdyVdwK8iG6JuFgbQdU4O+8n7keLw6nd4QecD0AFSCJMbJots8pebT8ny F6P2c/oDDpHsbuJRHbb/bCRxQ5eIgAQJG4GICUCEg0M5oC7pJlp10qSCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8O+RENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:NoRwcq0IlZ5RWydaffYQ2AqjBS9yeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8M3WBxB8baYOCCggeVxe5ZnO/fKlHbexEWldQtqJ uIDZIOb+EYZGIS5aia3ODRKadb/DDtytHMuQ6x9QYPcek8AJsQlDuRRzzrZHGfA2J9dOsEPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wg9HaIGOuV5Dt v/Q9pVfcl1P6krhIJGdZM8qJiMexvwqSylChPjHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou WLbG9l X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71798612" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=an+8CZ/RgZtkbOaReBB+a99Cr0AnHIDUqCSuFQ4J+OTAqGTBXYu97AVrPUOFFq3VuN2twMk9GZjFmSqbaDqGi4FWGI6AAZmBtoej4BiHrb6wAwLWMv6Mv7ej6Lrm/ErzC3Q3UWZagyzTqCrOH/Y/zMEJzj83CfVfIapBB45OM56DDfE0g5lvVSepWKMftOYlWhjf/uojNjyoki1gY2Wxv4eN5ssPsi1UJO02ROavQFPAhJsmtcuPr0T3RIupoF77j0tAloHMln02Hjzn1IhPvIvpELnQpJPQDnSkOsc1RfyGe92IkmusbZ9bWhv2H7ZLYqCY7LhA6AIzd7FhDsONgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1KcoChvovYQDsK3p29jg9hzF+dhhtG/SSZ4U6GNOE7U=; b=bLxWTbpGMJo8j154yQXOt/afBZIslcdsqzCkehZeNGELWQU7gC0VdrEBm946lwAnH0TKM9uWUGYlVDsdWVqxQGoc07M2EhtC9Ts2O698kuMvtHiencOp/zdkzSaif/pctpNlyZuh99rsTB5NCdAylfMjadrYQn/oo4lU3mmlK4dNzME1DJUEHZm+ZcyVyh/5Qgy9C4onueVXiiUWx9MwXehUC5mC+Gwax4T94PxAUjT5+JurrWSSqpxUO/YxOyXJiSQcQfo7dGssYJ1Y+UhNzgQvmE8s2wbIl9wUU0NnUpH2+IN65QLY/suwVR3wPn8MEu+xS3ZJu/vUcQ5DRKEl+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1KcoChvovYQDsK3p29jg9hzF+dhhtG/SSZ4U6GNOE7U=; b=NUmDotmnMGRSf6qPad11gRPYba58hRX6HzjqWITzl5Pn3GgaOfQOkFmHsGAGaSIOdUHPMsaHOwsUNX4IXiAz9jsfJO3WL+wmJCQLPu3d9WEM1z94S+lfXoeBdK8kuhx7+BM43JWUBh+LRhk5muAXF2zIuQTktPvt4SO6ikHg8ok= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 0/5] x86/lbr: handle lack of model-specific LBRs Date: Fri, 20 May 2022 15:37:41 +0200 Message-Id: <20220520133746.66142-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12903cb0-6255-41e2-d171-08da3a65f424 X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 60ImD7+KNxpWHcVoG3Bhv4IzSI+tfD5kaCTstihtXwsaXRZ7iRyNrt75UI+G0qgI/hYus80jxkP7F2dyCJzQaKWE99pQvlstJeHzCbm0XacPj1I5UfNnm5oF+ScJz0oj9MOyrpEmI+GdyPh/JIqUlAX26AzJVrlLn+aMGZfCDKfGo3fj6M4fMs5DrWS03KryH4iZXUBlIa8odWxCfMLUUSLmbw4ulJkmEMGZFTA0KlyutdIb8YSsmo4+xIOr845zy4Goz19gHgeMNZ3MoezCvxrSnOLJO8YxmDZScMm180+lAWMM2jnMl/CaOWxZKk6UzrieCzR0jXzOfE8mrBhW1FVavqAeRyEVQs/Zp7/2haVD76J5fRwaFakYXKBC5fGXY8X8ZbdsocHWRssZ5wbxdPKedweU/OvDQS865bo04KsTO3sOhPdFtzDjFMEp1dHDoZNW76nYS3VzPoUJWgtVkJt5K1amyu1u+vIB12X/T3jZ010c0SX/vDLhUy0lp3dhMGNErnnML9uzCtijjz7Awl9nVkkEYZbMNhXvyTPhPvHPL7TcBcAZb54VvTpq+LGIXNTakDCZcnQwJC2fUyeyyPlleJDRsHCpPfcFOV//Q+NDWnVgOFdJ2GzDTWfhqUUC8oLhA/q7/m4bN1YHbWmU2g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUFPWXhYdWhIakFYSTN4NitUNTV0Ry9YQnlwVXpuWTNDVFMydWRDQWFEa2hr?= =?utf-8?B?OERNYzM4MXNOMXl2Ulh4VFFHeVpmK2lUU1FMZGRaZ3JvSmFGUzM5VW42bkMy?= =?utf-8?B?cFhqMTJxR1U3L0RYWUFZS2ZuRHRMeTNnQlJMVmhSU1BsaUxydkcwOW9mSk5T?= =?utf-8?B?bGdaUGVGYTdMc0lMMlpmS0ZCaGFvZzUzWUI1MVlxcGRoQzhXeE1CN0g1YmFn?= =?utf-8?B?UFBPUzlkQmVrN21ZWExrSHZiaXg3WDNJbXpBUlgxK1g0TTR1RmcyemEzMExk?= =?utf-8?B?U041aFR3bUFidGNQT0tVd1p0SzVtb3A0WjdreVRMTGtuVmswSjNDL1ZWRmo2?= =?utf-8?B?R1RXbjJ2WURWYzI3QXVwcER5NkRRQWp6V2dHcnZLaHhaZ3RhME9aRzA1OU9Y?= =?utf-8?B?ajN1a28wNVBLRFBZYk45R2RoRG9WNnM3SDltamxwNjlvT0tMM1lqSkNqSGkr?= =?utf-8?B?RnJiSVJFZ1ZYbmRvQ3ZBdW93NHVzVC9FODBTQlRodnhZbVBKUzhJTDdGOGNG?= =?utf-8?B?YkJNaWMrYk1SeEhSZSt3TEEwb3RkcjFpVjF2S3hsRzhKWTJtdUlCMmlPL0ZI?= =?utf-8?B?YnJZM0JydWtPR2NmU0hMSnNScUZWSnpUQVN3ZXJTR3BjYzhteVF5ZmlvM0l4?= =?utf-8?B?TEdDa0FNdmc0SHZBdzBKN014aEFPa29PcENFaXZsT3RFbEx3TmVCSGJMOHd6?= =?utf-8?B?R3p0aXFhaGMvcEV5TmZXWGNGQTlaUElJY2h4NUJkWkg4ZkxvcGJrZTNrRnRy?= =?utf-8?B?Y0I2TkdCcm5Bb2dsbXhGclhYUWhMYm44VEtqdmJmR0ZkTnkwVGxIVEJUZlpF?= =?utf-8?B?VTM4TXBtMXk2eWdCcDVmMVdJNjI5VFBtUUxkK1JaSE81eUVBaVEvV3FCNlhQ?= =?utf-8?B?QkRHQ3FOOXJtcjROeXcxUmJFSjBLREZhdUZUcm9NMHJ4YWdrc0ExRTVuQXZW?= =?utf-8?B?ZGE5S25BZTdqNTE2dS9YVlQ2TVI3a3VVbE85dG41ZGhMNHVNYXkrZlJaRlhE?= =?utf-8?B?RENWdUdRRCtlZEtPMVpXSnRlMnd3UEwrUjk3RmR5K3R4OFYzb21qK1FWZXAw?= =?utf-8?B?T0ZoamUwWVg3RU9QdjIwUzB2Vy8vc2ZYbE4yY0ZucmdlUldGbXovRU1MV3c5?= =?utf-8?B?WFBJZDlCRW9nYyttNWJkdmVqcklLUC9rdzJOemxwd3NUTitrb3pPWCtGdUd6?= =?utf-8?B?eEZVSTJsMkpycEdFV20zd1h1TW1RZXRQN0RXZXFHdXExd1BKZVdYTVZOUzdz?= =?utf-8?B?Y1hnQ3N3aUdKL3l6QXBQU2ljYnVNZDNxMDlGcXY3K01XanRhb1R5VlVHWkEv?= =?utf-8?B?bDNpM3R5R1ZqZlVDS2NHWUxnT1ErK2FVcTVoNlhEM2tqYmozV0JHQUxlajZG?= =?utf-8?B?N3NiaWEyS2VWWFNGakFOUTB6WENpT3Ftb3o1Tk1hTzBvcWk5QzRwY1JBaS9U?= =?utf-8?B?OXRYbFpTdGF5WDdJTUoyUTZjYjFlNEovbTZNajNWSTQrUWppSkI0dmRIcnNH?= =?utf-8?B?elNUOUx3V2lJc0NkaUhuSEg4aWpld3l0azB0L3N2eHVaRk12TGJ2WnM4RWli?= =?utf-8?B?MG9kZlFYTTNiYW1KNVVNd1FGU0hySEkrSXcxcVJYcGdjSlE0bjJCdUh1RzM4?= =?utf-8?B?R3U1NGpWR3dQVEpmOFZrV09OM0pqcFdYMHNxQWEzS3lkR1dUcSsyZjBFZEdC?= =?utf-8?B?OHI1OVd5RnBRMEl1OFRKNXZ3blMwaVZMQXFxN2NGcnRLSGx1R1Z2R2poME05?= =?utf-8?B?cTBML0lsM0IyNG9Ta3pvblE2MjRRQ0p6ZUZYNDM3bDM5cFkvS1k2dVI0T0ZZ?= =?utf-8?B?WHRJbjE2am5BUzloeEM5SVlwTG5iS0lnenY0MnZVSmE1ekdJTWRuUUpuNDBR?= =?utf-8?B?UlJLUm1zRlkrZzdjRUlDY1ZzV2MzYjRSUG9CZmUxUlByL1Q4eVJjd2xzSE52?= =?utf-8?B?SjE0WWxydExLT1ZBVHRMQ3BFem9qRTh1aXdTWWhhbVAzMlBWdStMQWJQUmk0?= =?utf-8?B?ZGtEeDdySnU3ckJCNFhSeWY1RGV6cmpYbDQrdTVyT2R2R0Y1dk5nWjAwUDB6?= =?utf-8?B?d09zMld2QnY1ZE8zT3l4UktuTVM2WU5xSms0cUkwdlBGd0lVNCtUZlNqWDYy?= =?utf-8?B?dGpDQThOOEZpaFdSMUhuUzFTeEhrSnV3aE5rZnNic1p4NTRmTnE2VE9pZUNQ?= =?utf-8?B?NUdGZEZmVW1TdEtEcFZIVzdTWmxTazU0Vm81cFFGQXh6MU5VU2VkckQxZitJ?= =?utf-8?B?T3diNHQ0QldqVFlVS1RHaituOFFBc1BnZkhxN2FtOTZqZjBSczlDM0R6ZHI0?= =?utf-8?B?dEo0WXNleWRzczl3d3V6aCtwTnd1UmdFN1pjUW83L1Z5Qkhuc1BqOGE3cmVw?= =?utf-8?Q?JKUv8pQvBfxduQmk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12903cb0-6255-41e2-d171-08da3a65f424 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:37:59.0538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lccO8oTBS9mOEa+vCEijnWdJO/qaLyL/0/cZqrJwv7fToNXrKajZUdi+askh1C7kX+Xm0gWLbvX8N5MENruwPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 Hello, Intel Sapphire Rapids CPUs doesn't have model-specific MSRs, and hence only architectural LBRs are available. Firstly implement some changes so Xen knows how to enable arch LBRs so that the ler option can also work in such scenario (first two patches). The lack of model-specific LBRs also affects guests, as setting DEBUGCTLMSR.LBR is now ignored (value hardwired to 0, writes ignored) by the hardware due to the lack of model-specific LBRs. The LBR format reported in PERF_CAPABILITIES also need to be exposed, as that's a way for guests to detect lack of model-specific LBRs presence (patches 3 and 4). Patch 5 is an indentation fix that can be merged into patch 4: done separately to help readability of patch 4. Thanks, Roger. Roger Pau Monne (5): x86/ler: use feature flag to check if option is enabled x86/lbr: enable hypervisor LER with arch LBR x86/perf: expose LBR format in PERF_CAPABILITIES x86/vmx: handle no model-specific LBR presence x86/vmx: fix indentation of LBR xen/arch/x86/hvm/vmx/vmx.c | 59 ++++++++++++++------- xen/arch/x86/include/asm/msr-index.h | 18 +++++++ xen/arch/x86/msr.c | 9 ++++ xen/arch/x86/traps.c | 29 ++++++++-- xen/arch/x86/x86_64/traps.c | 2 +- xen/include/public/arch-x86/cpufeatureset.h | 3 +- 6 files changed, 97 insertions(+), 23 deletions(-) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334159.558158 (Exim 4.92) (envelope-from ) id 1ns2pc-0005Pb-RR; Fri, 20 May 2022 13:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334159.558158; Fri, 20 May 2022 13:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pc-0005Oy-Kx; Fri, 20 May 2022 13:38:16 +0000 Received: by outflank-mailman (input) for mailman id 334159; Fri, 20 May 2022 13:38:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pb-00056k-RH for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17375472-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:12 +0200 (CEST) Received: from mail-sn1anam02lp2044.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:10 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:38:09 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17375472-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053892; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=vuqEjtABieXu9Vo87t3IJkTLruYFx2uqb2Zc5LtfZjw=; b=WkTepDBoZk0JjbEMIERxDebjYhtUy/v1b2eSx2GhXUvahtfjCkBYzDmG B54m0fkpiFp1nTZyhTvqICgVTvFsHw7H8zRlwPQ/tiZr4AptI6PeqmLUl PgTlDQhycTLDdyewkTbAwbvuVPctmRSI1YmLa6yZHUKaa1hKfoaWu0s7i U=; X-IronPort-RemoteIP: 104.47.57.44 X-IronPort-MID: 71650040 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rbZkhq0j7UyayJib0PbD5adwkn2cJEfYwER7XKvMYLTBsI5bp2cFy WIXCm2OPvaJMDOjftsgPI3n9BhQucPcy9NjSwE/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1ok6KfbBUwIZSdo8ECVl4IMQpEAJRvreqvzXiX6aR/zmXgWl60mbBVKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82cBfmWjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SChLmUA9Ar9Sawfv2/Qky5K05bUIITcUMfNeMVxwneSn zeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rRqLk6PS6gPBXGwcFGYdNJohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:IzV//ayxUGds2Wz2+7+XKrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vU2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnS4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUoZ5Sy+BQO5M2/4lcjl9 fB5z8mIsRI8nvUOlq4pBP8sjOQpAoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPXi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZNIMvD0vFnLA BSNrCd2B4PGmnqLEwx/1MfjeBEZ05DUCtvGSM5y46oOzs/pgEN86JX/r1bop46zuNNd3B13Z W7Dk1WrsA/ciZvV9MaOA4ge7rBNoWfe2O7DIqtSW6XZ50vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71650040" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCYHoXmHTfr3TZEJ8LuPO/Hu9Ytk0cK7+DHPa3yQ9fLGenw6ABisVRAsxAvt8wphJIFqNaoSLCYOfe0igAj5ergfJ8xzvwXx4LZKHv6wZt3QQHtgGhDMAs3quTuyZ1EDn3hyW3mjPj6A5jn8GX/kCktYntUDssm/JuUFi2MVvGExgr2lZH2l1fuZ6qJvy19oWREBkU5EiJ1L+MyH8AqIvGYBfC6JaovBo0XCB4/MgRJUxzLsEU1vdHDl8c4m6PTYInpajBsdyqKDevsQJQ49fO02lMdp2gmE/0/1Cucaz7dlGEekblxDB8AaV155IonRt11MH73ME8rIx0ELOnvfQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v9Ekmh3tbPwwgEDDXKvXO+tVDL7mMqUMplf8TjgDEWQ=; b=HOealfUS7+T01miNdDwL9s4fwDeAgDVHEa3jAuC4GE1XTTYBEHW2teBTvHJ5d01ga758r00/OTUAgdk+srCnZ0nw9KsvwQuHg6ICZu2y+uuIQkl6xGEZHimLpg7mWNspBa/B54eUGVzF+8DdFtdtTJqPtataX/XMhQK2GDmvGGmivEd7tP2xeavaGXXj3gccdVUeSMYE4vZPgSFGQRSpr2R2acgxse8pROOcKc/FXajHdl819cINlG/x3y4Bhp0vzuebWkbGH6aBnH50XPdOYlhLelUxDWqYvt2Z2bM1IuLIiDs4lHZw+VpEMUIf4B1iRstrHSWkvmNE7ut7zTMAdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v9Ekmh3tbPwwgEDDXKvXO+tVDL7mMqUMplf8TjgDEWQ=; b=c3118TzE6ZMbMHxY6Fbfi6TRXqBvf0wrYgCH/cCnUugdnl8tyv783NxLDtRjwo8KnsZbUIQ9/hV0BXaULDp5WQvTXCvxBImpJEVFxVH/ilOZKA5tBgXUBQfeWDs0R9jGyUvFLPsOtfnmOWomY/xjv1Rg4eyW/OMM6IUJC+Pbqb8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR Date: Fri, 20 May 2022 15:37:43 +0200 Message-Id: <20220520133746.66142-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0377.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 745f6886-5750-461e-994e-08da3a65fa0f X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B4jxkw1Z9fVWJg6SQ50Vvv4ogiPEou3PJEOW2Xvb8IRH8e+ERf3FsS2pSLOVrCEA4qnulVuqNCqSesm43Q8yJBp24FdJ5E0cF2y4I0lMzT0YYrMelLhI/Y1A4esV2Wy8U4WPul+fzCU+XH9Go2E7Ui8B6W2G5kccVNXyCbMcER7YLdID8usTkJXa8tkLVAN0SoWY+Iz+i34SAbDcHhjlRvCjVi1/Y54YV20rW5YUL1JT2YvGDSFOos2qTwaUP+460e61+ezuiZ29B0Q2nAQzIZvYcp6F4l1B1sawEr77uz0Aegt9bNBbibCMyD2hbx6ZjUOjjB6X/34R1zfmzwDkautRDScwDFRUKlpqYA/BpJXMjXj+Lb3e1IAvzSjPXaoptYo+z20Jx+kslSBNY2c3xRMxhhyX6aT295KJocysWddIOVWShTWqgxM2ov52goont7O91TU0lf4CLXbeHpv026HeMiEQD1KpKGqRrUQXjPzzg4uisnUWqInT8zWQFoHNwG0KYVmhNbg6eLeJtrh2Bp9GL7RHfBUBAWUPkzI0t8M3H66kEv9QySxUKEphLUCTpCyh9zUp71IBETY1G3u8T2AEUGRm9DHIuse1YiZy8m5IZIsGVhmFWix/i/0EnJUyzq8RnCkgR48MEYvn5DwEOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjI5cVVRMWJTZ1l6bVRMeHpNNHFyanJIVDNnNDBTSmNjR2FKZlIvSUlva1Rn?= =?utf-8?B?Si8vNHBqT0ZlRDIrUW5STUhnbFkzTXZJZThkRjhtYnJOLy9qL24rblFieXli?= =?utf-8?B?TXlPY05wdUtiREUvREhtSGNrSjZoTnhabk1rUXdZaWp5bTRGdXpwOFBCNlEy?= =?utf-8?B?SnFiSEFpTHVUUzZqZzA3Wktad2taQnA2NzFvOUE1UnJNRUtOa096TGViY3Jm?= =?utf-8?B?bkFKRFEyYnAxaXRqbXZ4K2VwZjZxYllCaUYyejc5LzNyL0l4bzdOempqODNJ?= =?utf-8?B?MEpjZlIzdG92a2lMZk4yTE54MlROTnpJV2IxWDJKbGM1NkFzSVFIbFJsVzJF?= =?utf-8?B?QWdTR2YvU3ZFbkhFVFVrQzhJQllMWUQwcjNzTHhIS2hYZWNHZFQrdGJncnlO?= =?utf-8?B?ZHNZV0RwMndDUHRreVdrT0kzZlUvNHNBWjBPZWNXOU9UYmZ4Y1ozczRpSW5u?= =?utf-8?B?WlA2K01wTXpVcHlQNWZIQmFBVkg0cVAram5QYmN6bWwvZWtFN1ZDbFhTNmtP?= =?utf-8?B?U2RCYVBBSEdVZDJjc0xwMDFKY0prcWs2RWFKNmJBWFpUZmZ3YjZsS1plMGJi?= =?utf-8?B?VGl1a2ZRbnQ3d2wvN0dTSDFZYmFqc2Qza1pxSzBneldWUUQranVXR2JST3hS?= =?utf-8?B?dkcvbGFXMUU0d01odkFMNnRjMm1nUHN2Wk9SRTJwUFpqR25WcDBid3BHci9N?= =?utf-8?B?TUt3ckZRaHZWTklIQjJucDNRL3RpOU9tbHJSRkF1OHl3S2UxbUJ4MnJ0UXY5?= =?utf-8?B?NUdxdEJ6R3FJM2dFTTZsNC9NNmtWcEVjdzRsdnhWc1RNUWFER3gvSTJWVUxD?= =?utf-8?B?RHB2MEt5TUJtVzRzc0hCZzhNY0EzSTlkZTZWREpWR3RPOEs4N1ZZUHlZb3ky?= =?utf-8?B?ZmZmTWVhZ0g3SHRlTENmbENJV3BuOWl0N3U1RXJZZGNPV0xSOTF0bmdodlpm?= =?utf-8?B?S2pZeWRaSHkzSDlyNVdyNFJLY3J2cC90cUZ3eUJuZG1XbkZvLzg4Rk9UY1c1?= =?utf-8?B?SHR2OURvRi9MQXd3cC9idFZicFhxU3VFVDl2c2JPc3FLbmJMalA3ZUgvR2FB?= =?utf-8?B?NFJzc2hFbkNRWG5QMDVIMGsvdlZTL1RITGVoeWY2MEVBb1FEN2hMV1pNMmY5?= =?utf-8?B?Sm1nclRtL202Y3FRbkZSakxLb3VhZDNTSFVWSE9qR28wV2R0RC96bGtpNHE4?= =?utf-8?B?UUUrT1A0R09ac1NreUdrd2xCTlEzcVA5K1lGWXFjTTVXQ213TWVvcG9RUWhN?= =?utf-8?B?VUw3dHhUMm5NQ3Zxa0x0RngwMDNvMS9VVXZOSTl2WUR5MnpMTy9TRVUvSHl5?= =?utf-8?B?dXBCcjgzbmN6WE1YQVpWbWk0VEg1NkkyWGZlVzVCcGlYQUFwTXd6VUdua3RV?= =?utf-8?B?MGZjcjVDdmVTN1BMK2tTbmFBcWJTdytISldHUHozSVBwbHNVRTJmOGxWcG8x?= =?utf-8?B?ZnZ2Z2c0eGE3MGZiUFNXeEZCck5FNk1tRjl2K3lrTlExWHZ1MWk0UG1YL3NR?= =?utf-8?B?dHJ2Vyt1aHFsaFVQSjRvMENSWEY0ZW9OYzE4S0ZaNVg2ZnVCM0xkWUN4SStX?= =?utf-8?B?VEY0amVidlNlL0pTbW44Y2QxUTZ5TmsvdWZIS3YxWkp0a3Q0VE5TakxSQ3oz?= =?utf-8?B?ZFROVC8vOFBBdWl2N05oVFo5T09xYm16SHJDK3QrSHl1cW11RmhNUDVzYVc3?= =?utf-8?B?eUdEcVFQK2ROcWdRUEpvVW9xaU5QdlBIU2ZkbmdxdU9sSVdWMHVkbHpqQnR0?= =?utf-8?B?MkNJVEsyTU9taVBLZGpTYXdiYWJ3elN2bHJ0RWlWV1AxOURONDBYYVh6dERF?= =?utf-8?B?eXhndTdlZ3gxRkY1ZllHR01UdHBDQjVGK1VuendrWnFjb1RENklYcWExbEsr?= =?utf-8?B?YmRIbndJMXg0QjZiUHlYck9ZY25NMStpd1czUlFtc21MZVNxcHVFTFJEcm5P?= =?utf-8?B?bEpUQ3F2b2dLR1VnTllFQ0dsd0xSS2YzUXlnN2dwRWJ1QkZXYm1VM25TSGli?= =?utf-8?B?a1FVN1MrS3hvZUFTcytEdGxFS3VHSFFXeWRwMFRPaTRwYU9ybzNpdXhCdmlZ?= =?utf-8?B?Q2U2eHh5UkhRL25YMVE2SFJyZFhKQm56YkZSajJXNVdEQmJjT1JtbGVMMmpL?= =?utf-8?B?L3JSWEtmYU9rOU1URkdHTGJBd21xRVBrVjBXbWtGb3hjaWhIWUlBVlFvaFg4?= =?utf-8?B?cEdXMnZEd2RRbTZlMFV3Y3JtdDRaQnREK2J3SnNiNTk1ekVTMXdYczc4aWRB?= =?utf-8?B?akxtNW5tNVIxYXlWMTRVMlBTcHBrdS82VDlFbWxmdzhxbEM2NUhxcVhYV3Fi?= =?utf-8?B?V0JvdnIzd3dEdUp6SEpTZVlHcEl0K2orZklDdHNPekFPUmhseU00U2Y3ODBP?= =?utf-8?Q?sLyxSEBZv/oL+/1I=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 745f6886-5750-461e-994e-08da3a65fa0f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:38:08.8874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MwAQ15aAC9cNAmQwkv8fRyTkZglnbrKc/vJmVsB3/1qBp5hv1Of3cHvORVGZ8CpD8meOj0MCH4ITAQ9x/94yIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 CPUs having no model-specific LBRs don't implement DEBUGCTLMSR.LBR and LBRs can only be enabled if the processor supports architectural LBRs. Split the logic to enable LBRs into a separate function and expand the logic to also implement support for arch LBRs if model-specific LBRs are not supported. Signed-off-by: Roger Pau Monné --- xen/arch/x86/include/asm/msr-index.h | 18 +++++++++++++ xen/arch/x86/traps.c | 29 ++++++++++++++++++--- xen/include/public/arch-x86/cpufeatureset.h | 1 + 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 3e038db618..7b08e1804b 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -139,6 +139,24 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_ARCH_LBR_CTL 0x000014ce +#define ARCH_LBR_CTL_LBREN (_AC(1, ULL) << 0) +#define ARCH_LBR_CTL_OS (_AC(1, ULL) << 1) +#define ARCH_LBR_CTL_COND (_AC(1, ULL) << 16) +#define ARCH_LBR_CTL_NEAR_REL_JMP (_AC(1, ULL) << 17) +#define ARCH_LBR_CTL_NEAR_IND_JMP (_AC(1, ULL) << 18) +#define ARCH_LBR_CTL_NEAR_REL_CALL (_AC(1, ULL) << 19) +#define ARCH_LBR_CTL_NEAR_IND_CALL (_AC(1, ULL) << 20) +#define ARCH_LBR_CTL_NEAR_RET (_AC(1, ULL) << 21) +#define ARCH_LBR_CTL_OTHER_BRANCH (_AC(1, ULL) << 22) +#define ARCH_LBR_CTL_RECORD_ALL (ARCH_LBR_CTL_COND | \ + ARCH_LBR_CTL_NEAR_REL_JMP | \ + ARCH_LBR_CTL_NEAR_IND_JMP | \ + ARCH_LBR_CTL_NEAR_REL_CALL | \ + ARCH_LBR_CTL_NEAR_IND_CALL | \ + ARCH_LBR_CTL_NEAR_RET | \ + ARCH_LBR_CTL_OTHER_BRANCH) + #define MSR_EFER 0xc0000080 /* Extended Feature Enable Register */ #define EFER_SCE (_AC(1, ULL) << 0) /* SYSCALL Enable */ #define EFER_LME (_AC(1, ULL) << 8) /* Long Mode Enable */ diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 4c38f6c015..133348d9f9 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1963,6 +1963,29 @@ void do_device_not_available(struct cpu_user_regs *regs) #endif } +static bool enable_lbr(void) +{ + uint64_t debugctl; + + wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); + rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl); + if ( !(debugctl & IA32_DEBUGCTLMSR_LBR) ) + { + /* + * CPUs with no model-specific LBRs always return DEBUGCTLMSR.LBR + * == 0, attempt to set arch LBR if available. + */ + if ( !boot_cpu_has(X86_FEATURE_ARCH_LBR) ) + return false; + + /* Note that LASTINT{FROMIP,TOIP} matches LER_{FROM_IP,TO_IP} */ + wrmsrl(MSR_ARCH_LBR_CTL, ARCH_LBR_CTL_LBREN | ARCH_LBR_CTL_OS | + ARCH_LBR_CTL_RECORD_ALL); + } + + return true; +} + void do_debug(struct cpu_user_regs *regs) { unsigned long dr6; @@ -1997,7 +2020,7 @@ void do_debug(struct cpu_user_regs *regs) /* #DB automatically disabled LBR. Reinstate it if debugging Xen. */ if ( cpu_has_xen_lbr ) - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); + enable_lbr(); if ( !guest_mode(regs) ) { @@ -2179,8 +2202,8 @@ void percpu_traps_init(void) if ( !ler_msr && (ler_msr = calc_ler_msr()) ) setup_force_cpu_cap(X86_FEATURE_XEN_LBR); - if ( cpu_has_xen_lbr ) - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); + if ( cpu_has_xen_lbr && !enable_lbr() ) + printk(XENLOG_ERR "CPU#%u: failed to enable LBR\n", smp_processor_id()); } void __init init_idt_traps(void) diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 9cee4b439e..cd6409f9f3 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -280,6 +280,7 @@ XEN_CPUFEATURE(RTM_ALWAYS_ABORT, 9*32+11) /*! June 2021 TSX defeaturing in micro XEN_CPUFEATURE(TSX_FORCE_ABORT, 9*32+13) /* MSR_TSX_FORCE_ABORT.RTM_ABORT */ XEN_CPUFEATURE(SERIALIZE, 9*32+14) /*A SERIALIZE insn */ XEN_CPUFEATURE(TSXLDTRK, 9*32+16) /*a TSX load tracking suspend/resume insns */ +XEN_CPUFEATURE(ARCH_LBR, 9*32+19) /* Intel ARCH LBR */ XEN_CPUFEATURE(CET_IBT, 9*32+20) /* CET - Indirect Branch Tracking */ XEN_CPUFEATURE(IBRSB, 9*32+26) /*A IBRS and IBPB support (used by Intel) */ XEN_CPUFEATURE(STIBP, 9*32+27) /*A STIBP */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334157.558142 (Exim 4.92) (envelope-from ) id 1ns2pa-00056x-Vn; Fri, 20 May 2022 13:38:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334157.558142; Fri, 20 May 2022 13:38:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pa-00056q-SI; Fri, 20 May 2022 13:38:14 +0000 Received: by outflank-mailman (input) for mailman id 334157; Fri, 20 May 2022 13:38:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pa-00056k-41 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16d66ef3-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:12 +0200 (CEST) Received: from mail-sn1anam02lp2043.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:05 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:38:04 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:38:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16d66ef3-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053891; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=9yPdTOaoLfsg2kKEiAZjMTN90W25mzu1BXfoMHPOCt0=; b=B/Qk1a1+fA9n6ArJCcoHVkZqtVy4F2YKn55EYSavitqA8R5xylpRQMWu /45YIAVkU2VpJXeZdCKXUroaxD41RIF3Hr+GFKDVcLIrSR7+zC8MW/Cru dOL51sNpASUDia8j1STzSlw1mi5TU2tSN3bJ//EJ6rB4WB2ANWdK3/Wnk g=; X-IronPort-RemoteIP: 104.47.57.43 X-IronPort-MID: 71163081 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:L+Q26q1q7nW08TDvxPbD5adwkn2cJEfYwER7XKvMYLTBsI5bpzMGz 2AYUWDQO/vYZDGnLdggPYS38EkFvpSGmNdjGlFkpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0WhaeSTUAzAJTpnfwDSBRXSig5NqR/reqvzXiX6aR/zmXgWl60mbBVKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82cBfmRjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SCmLWYA+Av9SawfsnX0nVco/IXWaoDzV8HSYcRIhHzCn zeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rRqLk6PS6gPBXGwcFGYdM5ohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnFL6PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:MP0CcqBn/XsAAMvlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dNMEPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfXHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+06VTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qY5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ9o+a87bWPHAb0cYa lT5Jm23ocUTbraVQGVgoBX+q3jYpxpdS32AHTruaSuok1rdT5Cvg4lLfck7wY9HaIGOud5Dt v/Q9RVfcl1P6krhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71163081" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y8wAQnRbO5PYkN+nnU056NpBA1bKKsgqlBuO1d9VV9s/tCiZvVpsNAZ7VdYLACekPMfUxud7vDnJStAU4OQlbqi+Q+BDQR02psM9Cet9tM4IgVUQVQpC3L0Tc01H2amvYZGQpfMfcPbW9jIQnwWu2Cj7hDJoZDgqhfxR0vQTrZPSkMbUYgLOZjQSYVTL5BOzz5pCoDlUHUVTChbP5x67zpMQOoFa6SsVeGXDwzHOuU67AdmJq8mmiZ1NcnevuF+ArxDOSnoWDi5W41X9Jc1CBSAk71FxNIrCMfbh3LcZAhzr1w3HhwBlM5Pbd38T8aeAexFz5wiLPM3Kd1mxo+Ec0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MeoUp+iACJOfr/zDdBgUFwZ+3CraUjxfCVfwhWsGF5w=; b=hR+FOI5z3mqBS7y2bbPmrQ5gwJ8F5yGyJKu6N596j5BUJY8ZOYkEXBaZQTnGVXLCeCWbqPfGu3PIvYhhSfGk3cqtWEaNqxlHbNxAkbvqVb//OKxmElnzDZydHzXPoB2u3MVJXiHnm15T6Ce46QoT0NlGApvCb+Em6bp9L+5BYR5B8muSKRHymKCBn9qcMQI/3u4qpQOFdPrdR2XNyYCXMoNy/0p6atppZT+Kf9qNL5KzO60C8TZw53KhgDDjUoEXeVj9ijRYLzbqv+fVMYBFJvOf8qt2bktbHPILMLfkreZsDX4LN9y1rg3DykUv34zBK461BaxC6gTjqGU8rz/APw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MeoUp+iACJOfr/zDdBgUFwZ+3CraUjxfCVfwhWsGF5w=; b=FJ6ckKoytv1ehaaIcvmQOs/xJiazeIp7zaYC6oQs+PIiUVgxr7mZgCHyDc0dk1wa1tfiBVX8aXKZe4W4pE6o3HkRhBGZ5kdc5XOUIy069BAw3nagpmvpP2ZHBrFy1R746Oleosu3O29s++FLNW9rVXMHkdVR27mMP3lt9kacSlE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 1/5] x86/ler: use feature flag to check if option is enabled Date: Fri, 20 May 2022 15:37:42 +0200 Message-Id: <20220520133746.66142-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0173.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fc9d0a5-a093-4d27-05f1-08da3a65f76a X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EG0BOY9EdM+aMoQ2GS867YNIlRaYl9ab7V0/s1F0BSALuSugKzSzxh5ul/fJaJOESuPFOOmx6h6kmGEf9lAsY9gXG4YN/3aO6mElsHDHYndemeUnlBH04ww943ZnF1Wmed616HhjtKZNq1p+TPdvyfRPBc6Je1jDP7HcIIj3UrR1Npr8AbMswOHONz4UHXDiEU/WIR+B/Uc5jU7n4LuzkDTi8yrH3ZiKpih+djmgNvSCo+Afvs/w2I8H+tgKz+P8HVKa1jqlVVzGXi3v2BHAaQupmb9EuAIRrUzRskPEPw1w41XEjfU/WDKYazVBgWgzUEg8vh8CwBw6slArY2OE9ErPE59lzAKvxAlnfBoCF0e9YFiwEqaqTnrLdaQ/+UwL2X6Ea3R42ciQjjabTY/gcl2+E5FFd7I144YKBvifRdAqrLr/8SmP3ZsDD6YxVTRhiLmlRarNCUmy8PaTxzd4vnUlUNBhzlxwTOWwe5DvMtiod8WATn+HahEj2GfgxlUPYgMKt3sgS5xihOVLo1hxgcTu5CRxJjEM7Cdt4ZwRPYA9V0SmT1g/9Qy0YWOBDMWiTAx1TWd+zvGzSJskV0hYnxa5nra1fmxuFaAtfh4Tkvmb1Am5X4QssjcbrWvGk4dcmLbm6PY590U2CfavPgirTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(4744005)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3ZXUFN1aXdTYWtFRlRxSnVsWiswNU0yTGJBaWFtMDVQTWpGZGlrTUdGRThT?= =?utf-8?B?TnUwOHAxRmVEU3FEQ0ZNbHdKWC9TSEFkMkFlRzhSQUxhZ2VEWEVaQll2OGsz?= =?utf-8?B?aEZiZkdiMHpBaWFZWklGYWd5Z1czbUdCcXVrMWNsdDEyVUowb1FyaEtFU0VK?= =?utf-8?B?djR2aWU0cWc2UHluYWJCS0xOUG8xMGt1Yi9KVENGS0dUWXExVno3RUlmOGVF?= =?utf-8?B?OXd0SVV4MytxYWlURlRlZEpRRjE5T1I5VWM3RFd2M1JFc0hHRlczc1BZamJ1?= =?utf-8?B?M3JoUWJxaE1FU3Uzc1VkdDY5NmMwRkxXNG1TczFVUEZ5SVRmclFmOGdvWXBC?= =?utf-8?B?NExsamR1NHRXbEx1ZjdtM1ZpY3Uxczc0YjJ2Znc1NlZUVGhPL1pGa3AxMUtK?= =?utf-8?B?OG92YTRrbGoyN3Zqa0FSSFAvZm5oc3lUN3AzYWY2bW9nM3NLMS9XUlVNaWEy?= =?utf-8?B?SmlRcmc2cWV2bXBxNDFwQ0pzOUphaVFZOUFBYlJubnYrU3d4bmRET0VkNXFI?= =?utf-8?B?bGhzeXgzQlE5V0JPNWtRUVFHdENUTlg3RVZ4WFdqM3I4OFAzcHFLemhJNzUv?= =?utf-8?B?cXZWVWtxZC9BWTJoeEJPN1JkNlIyRUVWTzNrN2UvUTFKTG1YalhMZkdMd3lI?= =?utf-8?B?cG56UGlUUk5WUnRxQS9pK0ZJU2ZNbVUwUEFFa3lrajYrU2JsS3JNZjJUdDNz?= =?utf-8?B?YURhdEt2WWhrdGFXRHdGb1plMlJkZzFlMGdROEcrbmErVGpsSnZtbFdpZWlJ?= =?utf-8?B?VDNCUU51SmYwcEl6YzJDUXZXekhUNCs1ZHVGRTRMamdpSlFzR29PeHdnRWoy?= =?utf-8?B?YnpoWmZKYWdYbytNUngwVy9GYk5iZVFXcTk1b3hiVjZoWVAwczJEZk5mV1p2?= =?utf-8?B?Nk9qN3VMTTVoY3g5M2IxaTh3QklZK3B5b1Y1YkQ2ZUpaQ3JwQW1FVVVDUkxU?= =?utf-8?B?ZnRQaHRES29vOXV0UzROeWhxMXhRdnhvRTRLdEUzMlAwZm5XS254b2FUSDJr?= =?utf-8?B?ZUFTQmQ4UjcvMllUcmlKY0RVOEVmSnAzNEJZOSt1aUgzNFdHSDhzMi9PaWVp?= =?utf-8?B?WmhqMElmWEM3VFp0cmZNSmdQeS9jUnJmSWNGc0I5ZGxWbmdFMzd5M3pYWDUx?= =?utf-8?B?bzd4czF4VThlOFJ5NVNlS2lXQytPUHFOYmZvS1E2TXFRUFhobWk2TXZad214?= =?utf-8?B?cXV3cTk4YlRYejdHMmtqTGpmY2FlSm9sVHN1Um45YSs2R3NMTVhwWXhkekJo?= =?utf-8?B?QTFYNHZWYmdnZGE4WGVuQlkyOUZnelhVakZoaks3M1ZOZW5iMGhiUkplT2ov?= =?utf-8?B?algvRWIwUktqQXhVeUxyb2w3T3Z5dUJKcGh6MFZzMHErVkJkOHYwYlZLUHpK?= =?utf-8?B?L0cxVHlnRCtXWHdMeVVKSTl6d09LYmYvdUZ5UEZ1UDM1Ty8yL0JKNHhsYVhm?= =?utf-8?B?aXQxMlNGbkxYYTJLalM2VVlROC8yMU9zVklNV2VRd2lOcFNvU0lmeW1aWVZE?= =?utf-8?B?Nm92LzRUaDhZbVB3b0tROG4zYlVLZXpqbVFUNkdFVVp0OS9ydmlLZ3lGWkZp?= =?utf-8?B?L093NmJGaytBT0JyMTRUNzlManRkc0NvdFFvMWVvLzJFaGl5WlVRQUZyM1FQ?= =?utf-8?B?THlBd1lCVGtDaHhzcS9EYThFbzI2bGcxVDVjb0g5bEpiQXA4eTZUOThIbkov?= =?utf-8?B?MnVxN1FlWEhWZ1NEbGxsY1NkWC94K0laQXN3MlZGVUFZYXFCR1dnbWFJRUV3?= =?utf-8?B?emVhZ2I2SkhqcXRHRGFFejk1TmowcERpYzI2RkxXUEpuUUl6YTR0RmYweDJR?= =?utf-8?B?Y2dUWW9rL0FKcWVLUk5TS0dTN1ZpTUR4N1R5MlE3WkVPVXVKUzVTUXNKd0ZO?= =?utf-8?B?dk5IejRFdDYyaWVVUU15ZTlIemRyQnFyTHozOFp2UTZELzVxYVNGM2J0c2tU?= =?utf-8?B?SUFBb1RYWW1rS2hDOW5NU3NVK2E5VU56SUZUK3ZYS2R0TXMvZE5FWXpYTk5N?= =?utf-8?B?R1dScFRxMlhDNHQ1R3BFQUJ0ZDJ3U2pQdmp5VWdHblplaHhIb0Z3YjZYbkNE?= =?utf-8?B?eXZRT2dqSHJiVERTUGxZTHBtTjN5TDNJSFFZQ1lJUFhGb3M2OFE0SWVTV1JC?= =?utf-8?B?UWVSRTJ6aTdJb2kzckUrSVhZSWI1RG55MEdUUEVxc1UzUU4rZTJvZ0hLY3E0?= =?utf-8?B?Ykttc21nU1NoSjgrTmN6SG9wa3BSQndoYUZOMUtYK255ak8rRzI1Q2ZDZHlj?= =?utf-8?B?UHBkTUFzQjV1Z0pPWFVtZW5wT0JKcWhrcmpHa0ZKbHRZeUZMdS9JNHQ2bENP?= =?utf-8?B?eUVBK09rTDdRbVBESEREZzNXZk5PY05tZG80emM4V3FYT3l0Q2QwMlg1dlJR?= =?utf-8?Q?Lfl+TusZK8arEYxM=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc9d0a5-a093-4d27-05f1-08da3a65f76a X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:38:04.3999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oNxznAJlZO9sdE1t03X9vriuzzFFXfH2/uGRgqHyMfIgNKNJRTByxIafaWxdSR+QbyqxQjbDucpjdOPLjSAsrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 It's more consistent with the rest of the usages of cpu_has_xen_lbr. No functional change intended. Signed-off-by: Roger Pau Monné --- xen/arch/x86/x86_64/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c index 9d7f1f818b..24c5067ca2 100644 --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -156,7 +156,7 @@ void show_registers(const struct cpu_user_regs *regs) printk("CPU: %d\n", smp_processor_id()); _show_registers(&fault_regs, fault_crs, context, v); - if ( ler_msr && !guest_mode(regs) ) + if ( cpu_has_xen_lbr && !guest_mode(regs) ) { u64 from, to; -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334160.558175 (Exim 4.92) (envelope-from ) id 1ns2pf-0005wm-29; Fri, 20 May 2022 13:38:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334160.558175; Fri, 20 May 2022 13:38:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pe-0005wV-UY; Fri, 20 May 2022 13:38:18 +0000 Received: by outflank-mailman (input) for mailman id 334160; Fri, 20 May 2022 13:38:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pd-00056k-80 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:17 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19efacff-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:15 +0200 (CEST) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:14 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:38:13 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:38:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19efacff-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053895; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=J60n5jqdMwAAtpUd0Sb/CZ3lcfzBgmMhxbvEASQztDY=; b=FkDBc4HdQSZtbwzDE5HyrsU7/IeODNJYkrqzToymaBT6EWDqzVDNfuP3 R3BqWJju3CHcL6zaiUVmPMSa5W/FIs6qootsH6gwLtESx+XafjgRBduVj vkW3ldggMkRTPApBqGt4qh6IBjD8NV4wdjzbOqVpV1GxLemK4Gsbr5goa 4=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 71650041 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Uu/+oqI+0vddXpeqFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENS1zdTn 2IfWWqGbPnbZGSjf4wjbou1oEkG6MLdxtYwSldlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qw2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 M0OhYGbbiMTB4bFnPsPCEhATgNuGrITrdcrIVDn2SCS52vvViK0ht9IUwQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHsiFGv2bjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SChLmUA9Av9SawfpDmPyyEhy7jWHteEReGUHe9zhR2Au TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA 1cJ4Sdopq83nGS0SvHtUhv+p2SL1iPwQPJVGuw+rQuLlazd5l/BAnBeF2YQLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:F/M/Za/N+YyP1c+K3ORuk+FKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsj6KdgLNhRotKOTOLhILGFvAH0WKP+V3d8mjFh5dgPM RbAtdD4aPLfD9HZK/BiWHXcurIguP3iJxA7d2us0uFJjsaDp2IgT0JaTpyRSZNNXR77NcCZd Ohz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlOl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFcxccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiV7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri2knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYds99RrBmcEa+d RVfYHhDK48SyLYU5mZhBgj/DWUZAV8Iv/cKXJy+PB80FBt7QVEJgUjtYkid0w7heMAoql/lp r525tT5cFzp7ctHMRA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71650041" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bbJGrKihM0r4M17xmkPV/SEIjd4FyOAbocPk/LZPF9gHqy1NxUb5jtNw0KJVJBDx4zXrhv4eFT8RTDQmuwLmUYxJlemWrHtSwK5Y9WbQbQQYhWFgpzHRods8Vvwlw8iufCmze8xGzjJP4f8VqYk1oZkjbkQFEfEmieFcVxXnIqG/oGv/mSA/z96cq9t3gco2fhXWH4BP4NHFy+kc2oKjXbcj8uQos78kdkdUCYE9ZmRaNa7pjDrRVb7DdDpVjzbBzF1raMZeZq4PKLrW8qnbDvoGLm6H8oHBXKbWSO/8gVlDD0XoSE99SDiwy/BZ391362M7NkNfhNmpmrWmCdtGfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jb7AH61H+rViXQ6rYuunouCojzr47RKHvH4ITvQrb1M=; b=HnlQwv8ZZv6kYAuzvlJZeerFwrr+8R7vunmu/W2yq8numw3HTuWujb7ip5Jf3xijku+ON08BHKMViRO124ZHuFSqa6HJhG8v1bvKueHi08tJIAtUrtHSq/FmHkfv5Gok6KcYtUf1ezLmMlPe9JeTmh8C+Zbf/NZ07ALxUXQgQGRhwGyMHPwMVQaOdtvFYE2h3TroIbBMqlLtDzQLy1s9gxoLANEy2Nalb+2hiwGuhjGBm0EXtQbn1MXewTi777y2ykFMqt+ZpIv7B1bW2uI3Zx3msxHhq04A0IB19Gb1g3Uyo5Wg7Fn5j/d1J1gLzTRZQe0hi0zepsvtJxyaIjvAjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jb7AH61H+rViXQ6rYuunouCojzr47RKHvH4ITvQrb1M=; b=oXOgOcc9nxATnQSwCWHGdbHypyIm2jzuVBO5wuPbdyXjycxiU5Rs3G83cHQn+ggNxfI+TdGLSw4As4joJJlK6W18YXBUW9+9faV4rJHYJ3jB5O+h62puiigw6Gjc1mBbolV6rTZGUynZQrZTMcHIzU+IGZnOgXaY3OioWEI6uVY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Date: Fri, 20 May 2022 15:37:44 +0200 Message-Id: <20220520133746.66142-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0401.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0dbe4ca5-8e86-4749-6211-08da3a65fc79 X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D5ZuQ5twQWWZI6Q5yKWXfz/vbSX7YRKS+g7H9K4ZZUeo7QJxpD33/2qkJ6GN1uVz/x20DsmnM4XTSp+REPlR2/zgDz4Oqw62hQOfq8Eup/ftnWK5oUVZ6nN6p0tuwHfJnGOc8CDsHvrN4Mw1ywgFggYWPK/M0y5AEDUKIosUXntsSSlWl7MAWq7077/JZ/wg259K/VTZPOde6wlnE1fvbdz5iyb1Hx0ryuvBSpiF3Iixge7wlAULKO3709/HfO2+lmxEjN7uRtNgV6Uv0GtyzVrZY0kbdXDPXTNYIy3fmgmbeJI53u1tUybB241bC1wqyBnN0Dq9LVpnr68jBHkaA8fwNa7KOgOPJNoQc/YjTZH9eguuf0ujah1VcKaThf758FeFCXQmj1ZxqdyQE9uOvYFugn+NWDXSE7AKL874xUI25HH7W18CVuzzfNiOy2AQG/9MMKqAf/WDATPS/C6eI6isY5HbMTgPpj3AJzRalRgzLZSSlcC0Kcjk7aytHxh/3Nt2AcWEmI+GhAFjq1zgmySpKC/JTP8F967wGugz8qwSdtQpKampdlobqAPSgRsSA0FVQjYFClfetWXdcrNwRT7AT069QEq/oRa0y2Op1YsDGLLCZUzCmZpxaWxDBNDHeP9gSPqYxgcxpXrKp5HatQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2thc2twMGlOL2drY2xLVE5jakJ1Mm9MQVVaL0RzTlIybU5yenVaMWsrMVJM?= =?utf-8?B?cmpCTXIzNUdWSEJ4Q2daWU5hYkdCUjlGaGVUNlN6dCtTWjdnWW1RYm1IUFlv?= =?utf-8?B?RVNSMDc0VmV0Vk8zaDl0cDZKNTBOMi9lQUFRbURhWmdzZmM2QXVvSmNYN0Z2?= =?utf-8?B?SFdIdUxKdmRZc0FCSzJKU0RWY1ZzUUNtOGpqcU9jTkl6QWwwam5lbGphaXdI?= =?utf-8?B?NzcvRElXY0pJNXE2dUFMUWI5NzdvQm5MYWdZUVg3dC9nN1Y0M2dZRWl1UFpQ?= =?utf-8?B?RUptWUdYZzA3MjMyRWo3ZlplbDFQZER2VGt6Z0o2dGYvVmNBbExIL0QxU0g4?= =?utf-8?B?R216cS9Yamh4bWpnQ01oVE85Z3RtVWlmQWpLSXJoSW5rMzBmN0ZlUTVyaW8x?= =?utf-8?B?QlNRbUtEWjZEV3NNRGwwenk2alRQcjZIVHpGZ3JYQVp4NDYrWjd3Tml1Mjc5?= =?utf-8?B?WFpSdUtjNkU0RFNGdFViTERqZmFjb3NSUWo5UDZqTEZ3NmtoVExVeUdXaVRC?= =?utf-8?B?WFdjbzJESHZjN3lSNzNuZC9ReHJ6Y0JkbjdrUm5qRXY5bmxuSGkzNm93NmJY?= =?utf-8?B?UVovMGovQ0R0U05kTkVUTjJ1OGZ6SWNoVnBEcE9LOG1XMzNwbktsQ3plSWhl?= =?utf-8?B?czlYdGdjOGN0YkpOMG1LaGE0WFlGOW45QUxxMWhiQ0g4MnRiYSs4alJIQUdM?= =?utf-8?B?L29ubjlVZ0ZuYkoyOExCUlZDVXBzcGRmRlBoVEE1NnBab05oRUFpSWxhRWFz?= =?utf-8?B?L2tBUXN2enF2UlFVYUwyemNsZVpwM2NuellZOE11cGkvczk0TTVWcEhTY3BB?= =?utf-8?B?aTVVNnNBUzl2aXcrZVlCMzZZUnhQR0JCRzlyZUZEaHFNczJmenhQNFBvQytC?= =?utf-8?B?QUpYVE1uL0NzQlAyeG5vTzEzclVYQzJwRGJLVzhQaGF0dk9hZW9ESHFHN2lX?= =?utf-8?B?dlV3Y3NpL3lsM0QxUUk5ckFidGJBb3BWc0gwc21IM2h4Y2cwREhTWEE3WnJC?= =?utf-8?B?bnRRZWIxbjRHZlZnVkoydlZCVm5OMXQvcTlQem5SQktSYUNUVTQyZGdJY0Za?= =?utf-8?B?VlQxa1A1T25OSGFhaUlGZEpJaDFYZnMzakdlYTlxdll1Sm5zWnVOZVhiWHY0?= =?utf-8?B?L3FTOVdodGV3L1JZeVlOSDA2THBSUGRrZ3N6akt5YjFCREgrSWZDcFc2TDVm?= =?utf-8?B?YmRYclZPR01oMVh3dXM5VzFkZWEwenBJM0ZtU0NFWXdOU3pINEpyTUlZd3hJ?= =?utf-8?B?dFpscmhTUTUweTd6TXUxYlhMOEhxTVRnYytJY1k5Q0h1VE5qSXBFUDMwN0Z2?= =?utf-8?B?djl0UHIremcrL2pKOHF4aXoxOENBWHlaSFVmYXhyK0Q0RlBLdlFhNkl0d09m?= =?utf-8?B?RFJ5MUpzcHlpcjBHU0pqc0Z2SzFuaVBSZzZKK2xEU0RPNjlYdWlaQWRxR1Jj?= =?utf-8?B?cWV3SS85d0o0VWVpbHVtdTc3UGdLNVlJVzhXVTVUaEJ0b2tCOFpvQlRoVFR3?= =?utf-8?B?TkxJSTdUTWhlQ1krWmovdmg5S2FLNTlnRStNTzJWN1ppTmdWbVUwaVFOVEZh?= =?utf-8?B?Z3RXRWRvZWFxTnJxaTV5dkhQYzc5a21FTkhNc0FiNVZpSFBjakRzTGpDcGp6?= =?utf-8?B?U0hIUzZhTHdDZU90VGJPa0FQQm0xTXlSbFFDMk1aME5CRmt2ZXVPWHpNeVB5?= =?utf-8?B?Y1RMb2JNU3c2dWF1ZWIyWlVYNWthWmZSYTRLSCt6ZURuc3VsNWF0SHdDZWo3?= =?utf-8?B?ZGtMZ01LSUZNWTZJVVA2dnVvY09TeVA3T2tOL3M1S3R3bW1URklkYmw4VU9s?= =?utf-8?B?aDF6cm44aDhLNzdmbUx0QTRJVUd4OEpqdTlpVndyWnhsNFd3TWk3STBzZDQ0?= =?utf-8?B?cDIvLzQybUY1Tzd0ZUx3ZS94dTBnenl0OVBaU3NCVHlhblp3V2pjYUJUbUNG?= =?utf-8?B?ZjVNQVZnSW5YZWtSQ1ZLcmd4bFV5bEZGTzVtTC9zbHIxQnNCS2pKcGRKa0hw?= =?utf-8?B?aGp2WGVoUHRQME9LNjZvV3hKZityTXhhN1BYUVlJS212elE2OEpWQmNEYmMy?= =?utf-8?B?dFh0WmJEU1FseUg2UTBCbFBFbmFJUHRIT3NXZWRndkFGdkR3bTBTN3c5SWQr?= =?utf-8?B?SVB5dDVyc1NZUGlYNHFDakdGYU1wNDdyME0ybHJwMnUwTTBObWZRbTQ1SkdS?= =?utf-8?B?YTBVdm1kcy9mZXZWcXZuOHFkR1p5UU5ZTHV4ZnY3dTcxQWNIYTEvME5PVUpp?= =?utf-8?B?aXBzNkFjbEp0c0VHY0xSR2JFdmdLMXdBS1Z4QkVHL2F1aXJtRTNrRHFQU01h?= =?utf-8?B?Kyt3ZFlPOVQrdW5kdVdNTVhKVUhPU0ZwTGFWOWxMcnZnRU9FejNyMG0wUHpu?= =?utf-8?Q?9nRzTTP9uyiU98kg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dbe4ca5-8e86-4749-6211-08da3a65fc79 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:38:12.9830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kNNpOi8NGp+F6DbdhXUz9umrfUEqhjwPO481hSocSpS9zT1+5uyiJnsT+wBtHgnaloUewubdGK2Cx83rPEbupA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 Allow exposing the PDCM bit in CPUID for HVM guests if present on the platform, which in turn allows exposing PERF_CAPABILITIES. Limit the information exposed in PERF_CAPABILITIES to the LBR format only. This is helpful as hardware without model-specific LBRs set format to 0x3f in order to notify the feature is not present. Signed-off-by: Roger Pau Monné --- Seeing as we have never exposed PDCM in CPUID I wonder whether there's something that I'm missing that makes exposing PERF_CAPABILITIES LBR format not as trivial as it looks. --- xen/arch/x86/msr.c | 9 +++++++++ xen/include/public/arch-x86/cpufeatureset.h | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 01a15857b7..423a795d1d 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -316,6 +316,15 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) *val = 0; break; + case MSR_IA32_PERF_CAPABILITIES: + if ( !cp->basic.pdcm ) + goto gp_fault; + + /* Only report LBR format. */ + rdmsrl(MSR_IA32_PERF_CAPABILITIES, *val); + *val &= MSR_IA32_PERF_CAP_LBR_FORMAT; + break; + case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST: if ( !is_hvm_domain(d) || v != curr ) goto gp_fault; diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index cd6409f9f3..5fdaec43c5 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Supplemental Streaming SIMD Extensio XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages */ -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR */ +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR */ XEN_CPUFEATURE(PCID, 1*32+17) /*H Process Context ID */ XEN_CPUFEATURE(DCA, 1*32+18) /* Direct Cache Access */ XEN_CPUFEATURE(SSE4_1, 1*32+19) /*A Streaming SIMD Extensions 4.1 */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334161.558186 (Exim 4.92) (envelope-from ) id 1ns2pi-0006Ix-J1; Fri, 20 May 2022 13:38:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334161.558186; Fri, 20 May 2022 13:38:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pi-0006Io-Eh; Fri, 20 May 2022 13:38:22 +0000 Received: by outflank-mailman (input) for mailman id 334161; Fri, 20 May 2022 13:38:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2ph-00056k-0t for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c2ec3d9-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:19 +0200 (CEST) Received: from mail-sn1anam02lp2049.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:18 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:38:17 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:38:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c2ec3d9-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053899; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=mMJ5P0Y1TvLI0FEIdfDVmzdQ0NnWpot2Jwnk80caOVw=; b=TwzyxQ822meB1dPOnEBWNNLqC1cDRmoQb00ddo0OtFqn6cl009I4xyyz TXwV7XKE+BnC/fwrWGl5pUT2fANFQRbq2Sa1gU+nG8EwdBSf+pIwXp+wZ 9BPj24lVpy1WmGfeq+UYMzAgrZeolvyuK6hzKY+WZZvYpXL5JeaE4sBAu E=; X-IronPort-RemoteIP: 104.47.57.49 X-IronPort-MID: 71650044 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cnTWLaCEGIJYsRVW/zPiw5YqxClBgxIJ4kV8jS/XYbTApDMh3jZUm mofXWyCM6qIYmrzctx+bYm1/UwH7J+Bm9RgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj2tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhI5 tZCu4TtaTsyfYrqpPsCWgFbEhphaPguFL/veRBTsOS15mieKT7X5awrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t5B8ySK0nJzYYwMDMYnMdBEOyYf 8MEQTFucA7Bc1tEPVJ/5JcWw7722yGnL2EwRFS9+IYv/zDKzFNIganUCouOUPe7dP9FkRPNz o7B1yGjav0AD/SPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+fVmmp7+/g023WdNaI mQV/DYjqe4580nDZtrwQRy+5mKFtxg0WtxMHul84waIooLW6QuEAmkPThZadccr8sQxQFQCy Vuhj97vQzt1v9WopWm1876VqXapP3EcK2YHPXUAVVFdv4ilp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjvNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:iQFAAaAQkQFJylXlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dNMEPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfXHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+06VTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qY5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ9o+a87bWPHAb0cYa lT5Jm23ocUTbraVQGVgoBX+q3jYpxpdS32AHTruaSuok1rdT5Cvg4lLfck7wY9HaIGOud5Dt v/Q9RVfcl1P6krhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71650044" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfN++KibEMnFvXHBmIXaZjynOtUN9kr4tnEnRTXVcv25PFB/HQreWA731QtN9DhQZYIp+bCTnI9XGy+IioLLI4teAFNutf0z3X4YZqbxIWMK6l65p7OiYrnOlSRUTp4+oXpIcm2XT7eq7fN+0t7aqrpPoyOuLxnR6pdRNq0GVoL0vJMhsbVjTZ1Mn6Irspx5jfrhr8hxkj6NpfEZbRhjfXdoJXYisP4DffaKgmxuUgCGUYA3qUlZ02XM5wVWFsXTv8jh02Dp89jXMvA1MPjvrBBU16CrS2AUi0PkL5UGuPnqbL/r3i8ZL1PFd0A4AYIK4sM0SF5wMBjHX6N0128tZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5AvxiNqFtJGVi/aGyaifVpzhB4RDM41TL+u3JB+MDoA=; b=G5M3pVPfsmoUU2bhBauUMGyO+axgHBYoVR8lT7ZFkoaG+ApSlcnqsHiUhRQugj92XjxuT/6Yt8UC9Y3BOg26SA6JL5NlfkjLZaALHXh0AcxC/yMm1FhaL3pUPo8kjnN8sEYjonjfaAl9SBWvkC2bY3sF70E4JEIL+PiyWT4X8ao8hGUBZKSdtn8Hl+znTDUdBi/x3ilhXebMh7KWB9CL6cJT3sUYv15AIzpvIVoD3n7I1twBm3NeK1egD9ck5hzFjIknt7Xr6YI4ayFUTIGBdt5nUeAUCj7wBt68vHdgy4kr02s5TPJFOPgso2ruy+HWPxwjZ0R7OqgatQ5+XrV+Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5AvxiNqFtJGVi/aGyaifVpzhB4RDM41TL+u3JB+MDoA=; b=o6QCtwVm5cNssF8DWwSHdTTpZVDl169pwpSXk8t+hG3vRvJjD/jj3jx13BS6HzBTojU6y2Nq4eMXkLdOEo+JbVGgIgXqkZUosvbVQ8HQ7L+Trbi2eqZK4Q1HaTk+P9s84uOg02URy+37muPoS0H355zgq+wD/HeorRy1Rev+kIk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 4/5] x86/vmx: handle no model-specific LBR presence Date: Fri, 20 May 2022 15:37:45 +0200 Message-Id: <20220520133746.66142-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0078.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2f8db8a-813f-4da4-458a-08da3a65fef6 X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Bvu0nahcCeRFDFJHB4ahfLVIk2rzFpkDYBf7IKsEU+cqAp+FnxdZK/aBfBsiqCG4YoVRgtl9x2+hM7bwbQXha+cvQyCfJUqjldNmmRkvBSPDiN1AuIZOtPHS4bgZARcSUBRRZ5yUHypeFKW6O9dWgvY43lnetCqtaXPVBK+0GB5E/A5e3z8klWZ8IE4IMwVcSfmtFN9XF2iKd7a/oP92qDKOzCau8V6UB2aVm/l4mDGUUtxz+Wfl2sliyqJDvb0E2mN7faw4zfWvd5VIjdFQ3ljBmPm0AUu2pvQiQR3uwLaX5o3qTfrNpRWxPUr1ZXMdXNbnCv2V5Xov6wMM3KyAzMXGSpH1Eagt82bI5TTQJaDVxtuYimc1fCC2lq0Pq9nvQitgcsiB/VW4383RJ+Y0ySkp+d6/Vm44KHCN0VWQTcUaW9BVZkcV9Gn7hit+pL2iRyta6gjBl2AqQR4twwShHBrSNLReN/q9ai6NqPFmyLGfecqisA95+VCR0D6uN6uiP3Hod4BVxy1AI7xpoMvrM8IDf0AJ0evXbeyBNKXfuzQS6rjyzIvEEDqnyXA2eYYQELsRjp3XnBnHHIZPBInDPF/ZQvhgoUpVlREVagLiHtYCfHK/2wI4TUDXRq8PqhfcPAS3p/zfnsSw1S498sFBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVJYM2NEL3JGOVh2aUVRZWp5TG5ERDB5ZVFzRlJta0t3UGFPWjdKQ2tWZVJz?= =?utf-8?B?RG9qZitzNytiMkVNbWNUb2REdHh4cXg1SmFOL0IzeTkzZW81dzMvbUNzV1Zq?= =?utf-8?B?RTRha3BtUjFWb3R3ZjJucEMrMG9tMUdPcGtJTkVlbEVDd3JwL2Q4cExTMVly?= =?utf-8?B?RmZKNFdYL0pqTVR6ZVZLejQycmhFSkFRQVQybFppRTZWMDI3amtlOEtvclRo?= =?utf-8?B?SkNLRmVtT0ZtMjNYRmdnblZXb2lNLzdJTkVxVVZZZGFsMUc1UklkMVhPVWc2?= =?utf-8?B?MjhMZzFNcWNHNmRCeEsxMGdoOXh6OGpYYkdXTk1zMWNBaEZxbitNUW83UkVD?= =?utf-8?B?blFHRlZTalJ2TEdGaUFZRDdNVy8wbEp3KzhZTUM0RnR1VUt3WDRDbHA0aHY1?= =?utf-8?B?OUZDZlVEbTAxaVhEZUdYMW50djNvQnU5bFprR0FQYm9jNTJkOVFLN0NrVEg5?= =?utf-8?B?YkllNTlRWG52YWxoT1dCRUVOQXE4Zm9zMXNrRHFkSDhZWkNjWGQ2a1N6c0xM?= =?utf-8?B?M3NCWjJsRTVhNVpMVHZQTHE5L3diUjBKOTdrUjJORFhSYkJRTmx5Nnh4K0Uv?= =?utf-8?B?NDVlQXVJVkNJeW1sT0pMNEpPSE41dklSYmhEa2lSMk1PM0xZYUdUaWdCMUNU?= =?utf-8?B?M0R6UkJmU0pFZ2hrTm9Fdm40ZENvOFI1c1N5TXkwWExlQ0JjbDBGUUhvYkFC?= =?utf-8?B?ZWhXQSsrZVRBNnlYMjArQmNOZFdRUkg2ZVpOamdVNUZMaTVwU1hFN1BMdjFk?= =?utf-8?B?SnRZWitCdjFXcDhMMkt1STE4MkVPL2hkRUxycmJ6RUlYTnhPNnBGQlVITUJV?= =?utf-8?B?WmFsVFVFb0N2UFhUUDRaQ1ptU3dUNW9rVzN2ZS9FMC9rTnl2VzU2RitxcnRi?= =?utf-8?B?WHdUWVdaSFhaSlFjTThsM3BtNG1BaWNIQTUyMnhOQUcwTUZqVi9JT214OXRB?= =?utf-8?B?TERBbzFxRDlFWlRURGhXUUw2YThTS1BMVzd5N0Z3aWNkTXNRU3YxeG1lbDZu?= =?utf-8?B?ekcwOHRzeFNpY1htelpBeHQ3Z2pnMEdxSVRsUWx5VVF6Wmg2cFdNOVFGUFdF?= =?utf-8?B?ZEpxUmVDVFI3bzVxWkZtSVlhNkMwN204SW81YTZ2UU9rUEZ0eWI0RFRYWDVV?= =?utf-8?B?ZldJQVArRVFmVVBVdHpUYVB6bjRrVjZTSXFacTU2eEZLSS80b2pyWUpvNFpX?= =?utf-8?B?QTR1N3BSMmJZMGI4QXVBSnp1a3Z1VTRra01qMHl3T2ZBb2tMVWU2M0ZYcDJE?= =?utf-8?B?TXUrbjN2VktCanlNRFZpRUJvOFQzL3l2MU9mV1BQR3ZyMzA3T3lXUkw0WjA2?= =?utf-8?B?b0hEQUVXd3BYZTl3YURVNnF0VTJXS0tKVkZhL25na3h6RWlCcEpNZHQ3QVVJ?= =?utf-8?B?eWIrUTVzUWxlbktXK3VkamZEUWxaSFdGdkpnVXBobllYUDRndDc0bSsrQUEz?= =?utf-8?B?TEgvejV1S2UzWW9UNlZzdENSNGZQT0VuR3pjelMwa3BtUXZuVW5rMkZSR1NK?= =?utf-8?B?SWxJdmpPNzJkYVlidkszcnJDaENQdnhPakdZeWNtOFUzU29waWlvSHdNT0xL?= =?utf-8?B?aXFhZjdtUituQjBQN0IxRjhnUW5TcjlCVG1oL3hERkQ4VElicjQ4bDYvRlR1?= =?utf-8?B?K2hCTkxJOUpEYVlZdDZXejk3TWt6bDNobCt4cjVGckNzaEVvT0R1SFdwSVlq?= =?utf-8?B?cTZja0VYTE93ZU4xZW9xaHNIL3FBamJ2cGVEdzRoc2dlVUhOeHhyWU9aZXpV?= =?utf-8?B?VkgrWVU1RkRLTUt3Y1BTRldnSE5wNEZEOEptRHRwU2IxSFVuUzFSWFEwOXpJ?= =?utf-8?B?enR0MlY0TWdiSWRXbFdBTDIwRGYvQmFFUHg2eUtRRGphRDB0Vmk2SStPQmJ4?= =?utf-8?B?U0xZMkpEU1dEWmwzYmtueUpiZzZUbkgwRlQ2dCswOVpkWUJ2QUpXdWtsa2dO?= =?utf-8?B?bDNVcWhaWnRtUGZucmYvTW94c3A4ZGRHOXk4TjJUZm9wcHZrRHBZR2RxaXV4?= =?utf-8?B?bVN4Y1JRdTlYMDNWYnlsdGNSajhLTXFxN2xLWG51S2lKSC9TcnR0aW1qWkM4?= =?utf-8?B?dzZOUVVLOFpPb2JZaUs2b21XYjdaTS9rWElzRWg4dU1EdmduMUVJL1dQVnU4?= =?utf-8?B?UXI0MUNBNXFlTVYzZVlDWkdNRHIwU2hjL0Q5NHJ2SUdKNHAwbjJ3cUJadlhI?= =?utf-8?B?SVJ5OWVZZ2VXNDRLM2xKbW5mVk5iaFplc0llTGlOVC9MODcvODQ0UFRORjFG?= =?utf-8?B?KzJEYTFRTmpzUnJmQmlURFJGREZJeXJTMnU0bElIN092RGF1Y0ZmV3hCS2RV?= =?utf-8?B?N20yQ3IvWEhuUjFRTDZrS3dKS05ubGJrZ1lLV2FPVDZyUW15VE5RNTk1YVpt?= =?utf-8?Q?QVgJAVCNMmtNfsrQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2f8db8a-813f-4da4-458a-08da3a65fef6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:38:17.3924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FCSmLOWkXo+LoC1wmktdundXOUZXBraRlZMD7/UYlIj5YNEHcjKltmcuuCtzrexF2T8udfqwqZxw/WtKHHU/kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 Sapphire Rapids have no model-specific LBRs, and instead only expose architectural LBRs. As documented in the Architectural Last Branch Records specification, processors not supporting model-specific LBRs MSR_IA32_DEBUGCTLMSR.LBR has no meaning, and can be written to 0 or 1, but reads will always return 0. Implement support in vmx_msr_write_intercept() by adding generic detection of lack of model-specific LBRs by checking if the LBR format reported in PERF_CAPABILITIES matches 0x3f, which is explicitly listed in the manual as a way to signal lack of model-specific LBRs presence. Signed-off-by: Roger Pau Monné --- Note the indentation change in vmx_msr_write_intercept() as a result of the addition of a new condition is left for a following patch in order to aid readability of the change. --- xen/arch/x86/hvm/vmx/vmx.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index cf428a4849..3f45ac05c6 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3007,6 +3007,8 @@ static const struct lbr_info { { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, { 0, 0 } +}, no_lbr[] = { + {0, 0} }; static const struct lbr_info *last_branch_msr_get(void) @@ -3070,6 +3072,21 @@ static const struct lbr_info *last_branch_msr_get(void) /* Goldmont */ case 0x5c: case 0x5f: return gm_lbr; + + default: + if ( cpu_has_pdcm ) + { + uint64_t cap; + + rdmsrl(MSR_IA32_PERF_CAPABILITIES, cap); + if ( (cap & MSR_IA32_PERF_CAP_LBR_FORMAT) == 0x3f ) + /* + * On processors that do not support model-specific LBRs, + * PERF_CAPABILITIES.LBR_FMT will have the value 0x3f. + */ + return no_lbr; + } + break; } break; @@ -3521,6 +3538,8 @@ static int cf_check vmx_msr_write_intercept( return X86EMUL_OKAY; } + if ( lbr->count ) + { for ( ; lbr->count; lbr++ ) { unsigned int i; @@ -3546,6 +3565,10 @@ static int cf_check vmx_msr_write_intercept( v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_TSX; if ( ler_to_fixup_needed ) v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_LER_TO; + } + else + /* No model specific LBRs, ignore DEBUGCTLMSR.LBR. */ + msr_content &= ~IA32_DEBUGCTLMSR_LBR; } __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:38:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:38:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334169.558197 (Exim 4.92) (envelope-from ) id 1ns2pq-0006tn-VH; Fri, 20 May 2022 13:38:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334169.558197; Fri, 20 May 2022 13:38:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pq-0006ta-QU; Fri, 20 May 2022 13:38:30 +0000 Received: by outflank-mailman (input) for mailman id 334169; Fri, 20 May 2022 13:38:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2pq-00056k-3C for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:38:30 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20a5a0bc-d842-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:38:28 +0200 (CEST) Received: from mail-sn1anam02lp2045.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:38:24 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 13:38:22 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:38:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20a5a0bc-d842-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653053908; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=6MXC9SRRU9edsk/Euin3gOSSBFKjI554IJeuGPPnKKw=; b=iKQ324taiG3eWLF8KXpBmv+UZBgPmtKyTuVBr4frB9UXA5a+/9gYeRuF 4nxVxZiGjq7N1N2ZdoDNUMFnpAvAGCOyI7Kp4YRW2YqKOAZyyJsy5paHI YcdQ5ke2zJ34XSg8DkY9b3k0B8pnWa7qjenkOkZeSNvLmW7qW6gkJgL9g I=; X-IronPort-RemoteIP: 104.47.57.45 X-IronPort-MID: 71798641 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vYCrhq6u2r8WZK7sAVPZGwxRtCLGchMFZxGqfqrLsTDasY5as4F+v jAXXWGGPfiNNDaneN5za9vi9EhX7JTXn9JgSFA9riAwHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjW1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSwE10JOqrigtgZDRd6MQouMpNM/ebudC3XXcy7lyUqclPK6tA2VgQNG9Rd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiVo4MFtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGQH+QLL+fNfD277lk9ozrrBHcvpe83TYdkPo2O+h VOf4DGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRokyjXZRZI k8d+CsrpIAz8lCmSp/2WBjQiH2JoB8aHcZRGusS6QeRx66S6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBGjhHoLCTD3WH+d+pQSiaPCEUKSoZY3YNSwIAu4PnuNtr0k+JSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ== IronPort-HdrOrdr: A9a23:rHK3U65DWLTvpPMUMwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKnyXcV2/hrAV7GZmXbUQSTXeVfBOfZowEIXheOj9K1tp 0QDJSWdueAamSS5PySiGfYLz9j+qj+zEnBv5aj854Hd3AOV0gP1XYbNu7NeXcGOTWuSKBJXa a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWCSw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLLhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqn3d+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7kF6xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXKvoJBiKqbzPLd MeTP01vJ1tABCnhjHizyRSKeWXLzoO9kzseDlBhiSXuwIm6UyRgXFogfD3pU1wha7Ve6M0md gsDZ4Y5I2mNvVmC56VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71798641" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n/BVOxJw9h2Kg1Su+/KWbU1sThMnPC9hnj21grXqKWkYqaMwVzlQVN/GqoNQyvTuruOH1PUMtJj+NerKyTvoGEM6sLaB0xTXuJVc6X5MKJCllq3IshpEOY+6aGkwHiIErvJ2WNcEACGLKzpqlqpqYjDlj5ghMtK8IUH1ax0/1rfLyN8NinRp2hNYmmiRJXKuN78X9G+blM1V2pxQLfvijCQlXCp4Z25BBvSySDWI9O0UcACbnzms7YJDvjJG1wWD7Ojl3GAZBXzQ5l/f5q+/BOpUscQ09Lkh8RWhctmlIHhIHR2DNdxu9VQGbV+Ho6mkFCDhDI2CcZ89tokNx1SQvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5wQyHDBl72WDDVIoX0a3nPky6wCNM1VhocR08J8m0p4=; b=IJ0hAbQg/sdSVg3apMfR56SEMRILCiDFr5ZCSfKB1zOxlLrSMzR70PvOFwm6hmrgblRY0o1l3l2ycluBZwC2oOu/jwCCNG3b+dSxMhKNTXD2jpZQWNWqSp9PkR8YUgpLlOucdK+Gpcu7y8+ZJ0WPSsaophsJbDz+tTDuqp0RS08K5C1hYs7VFKd6QSkw6MGmGfDT0ZEVvB7hLR1umvqUXRv+9G2O9Ph/BzK6JqA5QCMeDFnBs4eXEQYNjMDpxljuZ5Ff2Vta++z751Wtu1lEm4dUp8BvqY1AaHR4QEUK2W2HpqLZeyN6MKcDak1/flvsU3X0XdleDQ8JACgcVv6wRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wQyHDBl72WDDVIoX0a3nPky6wCNM1VhocR08J8m0p4=; b=n0hJmV6yFBrG6SVj6wyPmNRmnbRsBQNpE+ErEvlLkKO6f5Jz6B/Z4U6Gn4naeUP7r3DABNrv6wAiDkDZ0LCPgl9T6jvWo3+Rk/7SqsmZd+srTCIYh31fPchLZM0pf9fEfvxeRuUU28UgJwJWEeCl+gy69TkqGNUcvH9kTHm1A7o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH 5/5] x86/vmx: fix indentation of LBR Date: Fri, 20 May 2022 15:37:46 +0200 Message-Id: <20220520133746.66142-6-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0506.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2d15561-4d60-4ccd-99f7-08da3a6601d5 X-MS-TrafficTypeDiagnostic: SA2PR03MB5755:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: obKYK02mWqQIX8OvM7VWRnzHlkaarh90WEPFVIcutC9qCHupeOPdIGYWJDEE9a3m17xXmJQzDZ5w/O6VWS0H83+rjh2c31aNNkbAdoGndiGfFdxbaWc3O6zkH3+4uVS930xQ/BrO5M1gryOjLIwJfFk5oD4exhgvtZ02oTVpR9tX9Fr5QZ7awLRdq/y8G40vmFCKrjO6vw1XM+RCoSxW0lkC05gvGAq5f+DaRP1O23vt/ZD9o3rEfu4M9f/FMotfkzARrXvTvajxOomp0nyFNWckJl9Ou181qn4/mkG1/wR/IVkL75kbGIRgcmTUE9aLKAU5Do7M0io6aG5W+9oLpE0Q6qyZ3FcfM2mUJwj+cLYJDJPWM7Gl/3OT6IBmjReAM/xFFK6t7UeLLoMWLqtJOMK8i3OiS4hpsZ/tj+V/m9kQ/+w6yvTY8AYqZwkkEAnHwXFOObMpee/BdHcMigm86grdJcHVh2t86pooX/7C8vuQHaa2ur2rUxvxTY5N6iKJQNQJ1WQjn0cUGoKkfdK7f8NHHMapGqdYEvWzDmZuAf/wOReJ4N+5nIUhNgUYoMc9YJ+vpPQfCU9zdzoi8jQSSXNuyidC6f8uEPRpWU+jPaRmHTUVLU5eEeiJ5hU64uyOeKzxl9UeVghn1xUy5jmD8g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(316002)(6916009)(86362001)(66556008)(66476007)(66946007)(8676002)(4326008)(6486002)(83380400001)(6512007)(26005)(2906002)(6506007)(508600001)(1076003)(38100700002)(2616005)(82960400001)(6666004)(36756003)(5660300002)(8936002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aExWcTJxTUk0a0R5anhJNyt5S2o1dVU5aDFOQnVWczl6ZDJSZVhKcUJBNU9u?= =?utf-8?B?N0t0c0MzS0Z3ZHQwUFZaOFRRWXJtT0oyUVRjdGd4S0F4REZYMHVIelgydkVR?= =?utf-8?B?ZlB0RVlSVkdZSG03dE03S0tpbFVISEJLeHk2bHkyUHQxSnVaYjVzUDVFWndB?= =?utf-8?B?bmdVdWVkdjBPWlVuK3I2R0QwWHRJd3BieVBmc01BMEg2YU1NajNBTml2L3NV?= =?utf-8?B?ZWNqVUtNY0JCM3BhSUZYTUZZZzVQVTZ3ejgzZ1RMWXlCYUkyeWFRRStobWdy?= =?utf-8?B?ckFLNDFvM0NHc0o5RFg2QlZ3VWR1UzZ1RVdyWU8rS2NGY3hxZUNLNldxUFZm?= =?utf-8?B?MWtqZEhHTzUzV2w1OENWeXk5cHJuV1BxM0xUQjNmUENNZStWMzVwTGRxSXhQ?= =?utf-8?B?REpGR3dpWDA2WUtxRGZ4enZuaWZRRi82U1RncmVCR0FRK3VBdFp6cDNJZXhz?= =?utf-8?B?N3Yyb053NkRCNk0zUkRWZkxkcTJ3Qmk5OFgrV1VDa0kzb0pzRW1wemYzNHhK?= =?utf-8?B?TENpbi8zbWFxdE9yRnFORjR2UVk4RGM0NzRNWFdSYzU5dXdQb282Sk5WZkRV?= =?utf-8?B?UnBsTDkwcjRseHVYazJCL0xOVUw1NlFENUpIdkJpV0N6V1lUd2tjWDhQLzZr?= =?utf-8?B?ZUZNN1E2T29qTXIreXVUWTBpdENVeUptbWF0OUVRV2l0YXlkYXI1WUVyY0M2?= =?utf-8?B?Q1MwZHgwVGtJY0lkY0RMM3JVek10MUp0MDhZZmJ6OEVJdkRvUTFjYVgwaTNv?= =?utf-8?B?QW8rRkc0VUxEK3FPM0hwL1dReXNGVndJdzRGSTFRdUxkSG9oajFrVkRpaGVI?= =?utf-8?B?THArWlRwZE02NU5kaHE4VkhGNmxXNUM0UGMydDNWeTlwcGhZc2J5VWhIMkRG?= =?utf-8?B?YkdjVXNnSnhYaWo4bkg0T0ZPL1lqbjdBSkphNlMycUxDT1c5am9zY1l5WmZR?= =?utf-8?B?UUdNL3B0Qmsra3k3YUV0cktwcFN1VDB3RElmb0U3d2twTmUzUmpma05oL0dT?= =?utf-8?B?MkxBcG5MUXZzK01GenluWnBXbmZKcDVEMWdLOHFzUVdIR3QxbDZzNWdwRUlk?= =?utf-8?B?U2hhUjdqZ3V4RFZ0NGE3ODBxM3NHaGoyL3JYTnFkdWVZNi8xSkY2K1BYdG8r?= =?utf-8?B?OHZSM09nMXU2a1dhMFJMeHRqbkJ3VXM0TFNmdnFKa1g3WkJza1dRUnFSc0dr?= =?utf-8?B?ODRMeWhhejBpdlV4OHQyR1ozdklGalBHNVZaN3R0YWloU2pzR3pZVzJ3dmQx?= =?utf-8?B?UVIvUC9zWXpHbmNwYTNWMjR0TXRBQkhLMTVEOVJiYUN0eHpuZXJIcTNzcWI0?= =?utf-8?B?ZUlUTnBHNHpvWk1zQU12aVJBRVFlSEhvVEQ3RTI3eUZVM0pDK2xXRHF3dXp1?= =?utf-8?B?SXlTNVcxUUR3OUtwNzIzbm1RWitZNlo2eFJ3djNOYUdkQkdyR01pblVFMzhv?= =?utf-8?B?T3N3c2hib0IzV3pWclgwUHJSa0YvRjcwRzBUeDEwNWhHaXQ0OTlPYnVXZlBt?= =?utf-8?B?V1BEVENJMER6ZFFzdk5ERThLalN4RzJjV2F5dmhRYldSb3pjMkpDeVdjeW0y?= =?utf-8?B?YitmWng1RnJ6eGo0RTByczdjcjFUZWVCaXZ4cmJqa3IycGN3eFJ3RllUV0xJ?= =?utf-8?B?V3hIQzBGZ0l4KzhtTGN5RTI2Qk9wem1McG9zMmt3bHRIYVpuTE0zNklIOUVN?= =?utf-8?B?NjlvWTZZWkFhb0xySlFleWgvV1Y5OGc3S0RIUGkwYUNHUmFkNCtDbTlhS1Nv?= =?utf-8?B?Z2dxbjZFQ1NCenpVUUwwVVBnbzltL2hxckJZd20zL0pldS9sdGRtRkdjaUJi?= =?utf-8?B?TG14MGFxbEdLRzJ5VmlERTIzeXRHNkc1Nm4zWEw4am5aaWc4M3BsRTVsMnMz?= =?utf-8?B?Vy90T2tHRGJjZVBQQWNQb0NMcW9PZFZnQUVub1BVTmVsZDZkMnNpdjBONE5Y?= =?utf-8?B?YTJEZjViLzJPQTNTVkhnVmhNWHdERnliU1ZSaDhBQ1BLcXZFOVBzdFFIMHdJ?= =?utf-8?B?c1VrK0N6Wk5uKzVXQWV1NGNXU2Q1R0RHa1RGcTFBd08xakpoTkJVbDVGOWts?= =?utf-8?B?clV5ZG4xcnVFZWYzQWJGdW5SYS9YS3FYWnl2UzQrMzc4bTVDb3pZQm04RUty?= =?utf-8?B?blN1SmNhdlNCQ2IreWdCZnRSUHpIKytxTjNRaVBxVVliVkdOTUpORWpKdnh0?= =?utf-8?B?aEk5WWJTTWJMaVBWMUJWL3ZFdHhRNktSNWU3bGZHdGhxN1VENFlXMmFRaGdl?= =?utf-8?B?UWZxYTZSckdiNGVvQkh0Z1J2NTliTW9lQXhpNTBrME5sZFFseEExaEs1cUNR?= =?utf-8?B?elovTzVLSm1XUmJIaW8yUGtzbkgwZDB1amZxQ0dwVjJtOHcwNklzU2V1bUN5?= =?utf-8?Q?dLIoj9LMs/N4xARs=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2d15561-4d60-4ccd-99f7-08da3a6601d5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:38:22.1478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zXTi61gzez7fZ9dwJV+CsE/tW6po5vCmcFfePspzrazRDNaZAlC+JiihDCUc4/lODvKFL45/SsMMwI8ESuvg9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 Properly indent the handling of LBR enable in MSR_IA32_DEBUGCTLMSR vmx_msr_write_intercept(). No functional change. Signed-off-by: Roger Pau Monné --- Feel free to squash onto the previous patch, did separately to aid the readability of the previous change. --- xen/arch/x86/hvm/vmx/vmx.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 3f45ac05c6..ff10b293a4 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3540,31 +3540,31 @@ static int cf_check vmx_msr_write_intercept( if ( lbr->count ) { - for ( ; lbr->count; lbr++ ) - { - unsigned int i; - - for ( i = 0; i < lbr->count; i++ ) + for ( ; lbr->count; lbr++ ) { - int rc = vmx_add_guest_msr(v, lbr->base + i, 0); + unsigned int i; - if ( unlikely(rc) ) + for ( i = 0; i < lbr->count; i++ ) { - gprintk(XENLOG_ERR, - "Guest load/save list error %d\n", rc); - domain_crash(v->domain); - return X86EMUL_OKAY; - } + int rc = vmx_add_guest_msr(v, lbr->base + i, 0); - vmx_clear_msr_intercept(v, lbr->base + i, VMX_MSR_RW); + if ( unlikely(rc) ) + { + gprintk(XENLOG_ERR, + "Guest load/save list error %d\n", rc); + domain_crash(v->domain); + return X86EMUL_OKAY; + } + + vmx_clear_msr_intercept(v, lbr->base + i, VMX_MSR_RW); + } } - } - v->arch.hvm.vmx.lbr_flags |= LBR_MSRS_INSERTED; - if ( lbr_tsx_fixup_needed ) - v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_TSX; - if ( ler_to_fixup_needed ) - v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_LER_TO; + v->arch.hvm.vmx.lbr_flags |= LBR_MSRS_INSERTED; + if ( lbr_tsx_fixup_needed ) + v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_TSX; + if ( ler_to_fixup_needed ) + v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_LER_TO; } else /* No model specific LBRs, ignore DEBUGCTLMSR.LBR. */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Fri May 20 13:41:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:41:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334188.558208 (Exim 4.92) (envelope-from ) id 1ns2sh-000159-BU; Fri, 20 May 2022 13:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334188.558208; Fri, 20 May 2022 13:41:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2sh-000152-8Y; Fri, 20 May 2022 13:41:27 +0000 Received: by outflank-mailman (input) for mailman id 334188; Fri, 20 May 2022 13:41:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2sf-00014i-W8 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:41:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8151910c-d842-11ec-837e-e5687231ffcc; Fri, 20 May 2022 15:41:10 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 09:41:21 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BLAPR03MB5572.namprd03.prod.outlook.com (2603:10b6:208:292::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 13:41:20 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 13:41:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8151910c-d842-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653054084; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=A14EhTHf/0LHaiW/FRqzDvNnjd2dGUC4n1zM7imSz2U=; b=V7kVjQw4NDHMKlQ+3722Aj3lhEcA5jGSR/7XEJo4bFQZ+eT6SyZUkGA8 ONk9amv+O6bRY5cGd8J6E249+hTIhtEGfShh6dH4g7Z+s8A5bNc7fZJUe M6W9s1CFUeIMhc6ow3x3MmBneZ6cP1lvdZ8YyT1aKrEHxr0F7aRM+lMt4 I=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 71788872 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/6uvoayUvsrbTiDuKEZ6t+cnxyrEfRIJ4+MujC+fZmUNrF6WrkUGn zAZWmqGOfeJMzOheIsnYIji/BhT7ZfdyoJkHAZuriAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY124DhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplv42fSCIxJqzwnv07ejVeGgRxD6JEweqSSZS/mZT7I0zuVVLJmqwrJ2ZveIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHeOTuoEwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKmII+ALK/8Lb5UD/1g5q3ofxaeHJa9ikSNkShE2lj F7vqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWMwkQDBRtQUkG0ydG6h1C/XZRDK kUS0isosaU2skesS7HVRxSlpFaUsxhaXMBfe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBONB0mLicSHbY/bDNqzq3YHERNTVbOnFCShYZ6d7+po11lgjIUttoDK+yiJvyBC30x DeJ6iM5gt3/kPI26klyxnif6xrEm3QDZlddCtn/No590j5EWQ== IronPort-HdrOrdr: A9a23:avSvs6jmi09on3hdLTpTKechsnBQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hqAV7CZnichILMFu1fBOTZslnd8kHFltK1kJ 0QCpSWa+eAcmSS8/yKhzVQeuxIqLfnzEnrv5an854Ed3AXV0gK1XYdNu/0KDwUeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71788872" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AePKWpQlJiee916ViM5cIDIv3bUV+ET2OFsXEvmdR56L7dUlM6nx+PCC4rPxei1u5/dXMMwNFLUVS8vLIPYW9WQ5dDiSKJIZj+BVUg4XT3njlWo4gAqkwN3esNbWtzMUJwZVrhpxoo9WsazG04XlDGRFj579R5C7gFfpGrYzVEvsOiEHT2WSE2wYay0CvLi3ZtD0mVeiyPj4rjCfRdfeb9lIBhf7d2irOlrLxmIwobZ27KDk++DnZGnPCKfrozMlmKWANGpPdAiuLMdDQzzfm3Yurpf/uULTDxQFe5xyZu3ykcpJLZOUxvr40EYFRLbwH0FcO5Dj0AtuUVnKrslAZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ofld6Ep71YeyYxHfidBH/b9x2bm3x7TqyRzarWNNHVI=; b=XCRcZgLVd8T1DF9/Q0QrZ5f0UT7Q6noG16xWw/PdIGHIDi6u1rQGnvXkL3l/v0vHx1nJi+Tc+8gBPxjsKxDRWfV4mCEUqflIGRSeAdIgGYd86V8O1WPEC4ln2/6zuzdePYcBsvZDxGTPe2qoNgkqAwRREaA7u3zdpp/XOGig3arZFB8qsBmHRt8BpLNgv2I2GCFjav6lF3rSuVPd0GxVtCYSCyT8nUEguIBG/0zNoSkOS17YutGyJXbiOkCVILeCOmeBKm5KmGxM+8LgLwQJuVdR1JVHoX1B+/PZAOE6TVj6PNDxIn5eX5jvAmiUI6nQjzSVWArR0DmoHQvwJY9WVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofld6Ep71YeyYxHfidBH/b9x2bm3x7TqyRzarWNNHVI=; b=MGm7m+HBC2uIDwIXiCGJfGqFAMazPtu5vox+wO+5X/mz3fUuOaA6/Gm62enGlwN2wfUhUCSspBdlKC7guCMMiUPdxCFD/CvpADipWuvyJt6mD4E+4j5ftPiFNuoGow0h95UmaE8dc5CZNp1+J4v2YplxM+0MePGu22o1leixjH8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 15:41:15 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Kevin Tian , Paul Durrant , xen-devel@lists.xenproject.org Subject: Re: [PATCH RFC 0/6] x86/ioapic: fix edge triggered interrupt migration Message-ID: References: <20220421132114.35118-1-roger.pau@citrix.com> <02c5d597-70ce-23a7-d48e-0e9d2abe72f1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <02c5d597-70ce-23a7-d48e-0e9d2abe72f1@suse.com> X-ClientProxiedBy: LO2P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bce8c5f1-e3b5-417e-9d27-08da3a666bf1 X-MS-TrafficTypeDiagnostic: BLAPR03MB5572:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wH0/sVeXb1Lp1tGA+yusO8nWbvy1zA/KrEjnQyHmsQOla3oU7R7pXgzUJmCvVBdylvfrjJ3Y+050y6gJlF+q8Kr6+PtqYqTe9wMD8V2zW/CG6jocYF2t+V4ilUNh2CyEeP0D+hMmwroU3CL3XH2mMfn+GelO8Oca9Q3c1OyYpVEhOyxjtcAnrHDme8BsDU4HWjMQQciD0jlx7Zk/N863dPj9kDsRwqguiNnR7qvR9Ii+4S7y4X8y+RiO4hmqSUOQGYaYnqKFhKmpESNbM6GcXzJR8sjFEVAazWpqcQ5kiTKq1a0uyw+2hK4XBnwv0+Hv09lTG26uoMVzCWCPUvnQB7NVVB4/pWDqsBEw0aRg3F83T0h5ivkoQe/7MJjcEOG0AyLkp78Zks9D/CejlUorW+BopLy1/ZcYfZ3dJhbEAYooT2G+uCCAxeBkO7sM/wcGlaAYapS6xfNUvPH2HxrIFq1LMS6VRmLJftclAoF55zvaaOfEcVow7YTauzLbdq6cO7roG8nfPQPlS3njeDSA0Z0OfVqHZUZcuEmqY+pUXRP3Ai39QqJQYGk1OrCf2Fu0t2G4iNZAlkz1rLrM+uSMAgAbjFF99Km/dMctFm+ZkWl8sof0jvp0ybZq1ZYS22qLVwo6j27GdFFA4jQJfn8SsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(38100700002)(82960400001)(83380400001)(86362001)(8936002)(5660300002)(508600001)(66946007)(8676002)(4326008)(66556008)(66476007)(33716001)(85182001)(2906002)(26005)(6486002)(53546011)(6666004)(6506007)(9686003)(6512007)(316002)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0hrSU96L28rSHlBc0lxTDBMdGt6Mkt1V1lDenU1QXE0SS93WDB2U25YeG03?= =?utf-8?B?Unk2bjBjMC82Y2tnS2RVWGlLazNPNVVYRmN6SVp5bVE0bG9kMUtMK0ZCY1cy?= =?utf-8?B?cTR2RkNuQytDSlR1UEFNWGdMeWhKTURMSXQ0V1RMV0gvNHZlTDd1bEhTcS82?= =?utf-8?B?V3NWYVF1WmgzZ2grR2dVbVRFbHozYytlaDlSSTRYczRWYmF2NnRmN0FzaE41?= =?utf-8?B?SENHaHJOSThtUDZNWE1HNGZFUHQvVmRsRFhCSC9NYW1NYTRhNldpN2NtaFZE?= =?utf-8?B?ZmRpazFidXZVU093a1ladE1FWHoxdHR5UVFRWko3UmxEYVNqMytkUzNDSjI2?= =?utf-8?B?Y2diYTd1SGJJZENRaTJEWnZyam9qZ0o0aHczSWNRbG1BektNOWlFaFFCMnhw?= =?utf-8?B?Nit2dk81YXBSM2xvVlhLQjdoeW1LekpQV0g0TGtuZmZRdmovemJUcHd0RGtp?= =?utf-8?B?WCs5dXZiN1NuQU1qMkUvU0NjQ1lvUWdkZEJzTWpUcllDek5QcksxUTFkencr?= =?utf-8?B?cXAwZUc2TUE4aHA0SHlmUVdDYWZWSy9PTjNxZE9yb0ZobENzQktlWWcwalNQ?= =?utf-8?B?cDJ5UmczTkFqSmthWGlWZTdWOU9XWHdldzZMV05GK1VNem5CM3kxSEpnY0t0?= =?utf-8?B?dG5FR2lldEZhR0hPS1JWOVZ2c0lUVlFyaXZyVVFaSU9QRjdkUnUyOTlwY3dv?= =?utf-8?B?TnE2Nk9XWURDWU82bFFYUE5xL2VwUlB4MVNRZmFZVlJtMm45RkMrMmtsUDZ4?= =?utf-8?B?a29FWHNYVEIyL0VCaHE1MEJ6U3E0QlJlaTlRK2tzK2dHTFJRM08zL2VLWExq?= =?utf-8?B?SjBiR0tMQmp4bkhuRmV0V0dpb21qK0xnNVNqK0VSK2FTdVpvL0ZyQ01PM1Qy?= =?utf-8?B?eDZnRmR4ZmdkenVPKzJlckJPWmhRMVd2YndhWUcvYURXdlRjUHpjd2tDbEw5?= =?utf-8?B?QWNSYlBpM0hGR1p6UEZYVHBSNU5tZ29KTEJZSVI4cG1KdG5iRHBWUVBtdW5J?= =?utf-8?B?dXd0NkoydW5ETUVZa1lHa1NRMFZlNUdsdHkxMzlRNlF4TEFUVG5vS2tyL1Fn?= =?utf-8?B?VUt4ZkovS2s4L084TVZGQUVOdTY2MndSd1RvSWRMZGVBNTlLQXh0RWErSUlT?= =?utf-8?B?VThsTEx0VHR6bGlLSEQvUFJvTGdkYnYvbWtJaS96UmkramdBdWF4V25aYXNY?= =?utf-8?B?Z2NBSi9UWUdZaExEaG40R1Y5YkdITzVYVHNvRWlxOWl6TGhPZXdaZC9iTzNu?= =?utf-8?B?SFJvZmdrbEMxMUp5czdiTVhpV212NGtXVkZaVmcxTFFvUjhPeVg0cnhhaFlM?= =?utf-8?B?L0xSNW5uZDlIVkg2MWd5Szh1T2xsdHNiUTZJZkxSbUhITVFjMWxIMnBjRU4w?= =?utf-8?B?aDRkQ0pUVitONFVTd0ZYRnFLOFNhV2dSWnNldll0b1g4SlczMDdqbTIxMUgz?= =?utf-8?B?K1hRZVNmTEdJM29nYUxWbStJZmFCQ2cyYTdyUEpNaXpyMHkrcGxBRmxtVGEx?= =?utf-8?B?UTN1dkhUTFBRQm9WSW1nbkpDZ0YxNGRRckMxeUtRZjR5bzJ3dWczZnNNZ0tZ?= =?utf-8?B?dlBLQ1MxL1VqN2U0MjNsQ3N0c1VSUnhZWWg4c2gxYUhXSDRYMmJZSGpkd21W?= =?utf-8?B?UnpnZmZCenN1N1Q0MGpWMlFNUDM0VjY4T3MzeWZqenNxRFBCUlJ4dG9XTzFr?= =?utf-8?B?TXVDS1NTUE9zWHQ3WlVVd1NjL21BM0RIRUFmWU1tNlZ5VXc2ODVTWExCWFN5?= =?utf-8?B?VUxxWDMwYjcrWTdHaW93UG82RTd0RlZ1M1Y4bzk5Q2ZUUS9uRWh2d3lIWmFR?= =?utf-8?B?Y0dkYzhFNjdHVTJQTndjSmlwelNaRnhybVhKeFg5Nnl4YkdTL2NJa0YyRGpv?= =?utf-8?B?UUhSU3hYUGU5Z3NzTHA2OFU3QUMyZWplR0pyQ1U0UDgvbElDaUkyQ3UwWDF0?= =?utf-8?B?bitLNGNVeU1ieUhObjJFcmx6MUVHdW5xUElLWDZMZUQ1Tnh4a2pWSVc2NWJK?= =?utf-8?B?ZVIzSDhEMVQ5YkRJTEJNcnhHSXIraXR0eTFzN1M5eXFZaGJ2czB6SFJHNEFp?= =?utf-8?B?Y2Nid1J4UHh5ZitUbXBDZ2pONFUxVGhLbkEvcFd1SUloNTdmdUhsejJBNXA3?= =?utf-8?B?Q0NKa0VZbFNSL2lMRkN1ZW8yZE5yVTlrWklqeHVCMFNZM2VhQS9wZ3I2TFVK?= =?utf-8?B?dSttZ0VsaE9oNk4wUHBsQ3dKbm9jdTRqYzd5Nmw3WmNpUldZckJxeDlMajJm?= =?utf-8?B?aEZHS1Z3UnFtZXBFVm53c24rSHBONzVRWTJCYkVwNFg3NitFRW8yL1YxYVlv?= =?utf-8?B?Ni8wVnJsampkWVdUTWFSeml3elpjbEo3QS95Nk9iVFppeWZjVXlEYWFSVjdX?= =?utf-8?Q?LrPpkmbBg6dp9NK4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bce8c5f1-e3b5-417e-9d27-08da3a666bf1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:41:20.0306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D6oWF54u9t/NOOIuPlGucfOL5lF82VzvnljLBDARJ/sUlfPasedjH/Cy8jYhkKLobZldmjMYwQLal705aeJsPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5572 On Fri, May 20, 2022 at 02:46:39PM +0200, Jan Beulich wrote: > On 20.05.2022 14:36, Roger Pau Monné wrote: > > On Thu, Apr 21, 2022 at 03:21:08PM +0200, Roger Pau Monne wrote: > >> Hello, > >> > >> Following series attempts to solve the issue with IO-APIC edge triggered > >> interrupts seeing an inconsistent RTE or IRTE when injected while being > >> migrated. > >> > >> It's currently RFC because some patches have post commit message notes, > >> and because I'm not sure if patch 1 is really needed. I originally had > >> the idea of suggesting to only backport patch 1 in order to fix the > >> issue in older releases, while leaving the more complex (and thus > >> error prone) IOMMU changes in unstable. Note however that patch 1 is > >> just a workaround to prevent interrupts seeing inconsistent entries > >> while being updated, masking the entry just makes the warning go away, > >> but the interrupt will be lost. > > > > Ping? > > Sorry, the usual thing with RFCs: They take lower priority than other > work items. This series is certainly the first of the several pending > RFC series which I mean to get to, but it's hard to predict when this > would be. No problem, I don't think it's a super urgent issue: we have always handled interrupts this way and so far got no noticeable issues (apart from the log messages reported on the console). There's a non-trivial amount of IOMMU code changes, so maybe the IOMMU maintainers could take a stab at those as a start? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 13:48:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334223.558219 (Exim 4.92) (envelope-from ) id 1ns2zT-0001tW-6z; Fri, 20 May 2022 13:48:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334223.558219; Fri, 20 May 2022 13:48:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2zT-0001tP-3e; Fri, 20 May 2022 13:48:27 +0000 Received: by outflank-mailman (input) for mailman id 334223; Fri, 20 May 2022 13:48:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns2zR-0001tD-CU for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:48:25 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83c24d25-d843-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 15:48:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83c24d25-d843-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653054504; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/vb/EolaX43fnGmzZp+0qeqrGpz2/YSy+BS4fIoskTo=; b=hEUkz6oJ6GY9/ekOSereD6Nzkpz6XSXzkcr7FHzIvjWrhws9ZSKHfGHe LdS8frBN3+ga1wK9V702s8PbPNHB+YX8SqHCucOM1CvdnwPVGXNSk4F4F EnMcULAaEXrcrO11NkaQAffPhWMWZFUiT6hrZwDbuBU/HhYvaUklr5ywO 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71163897 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ZR35XK6Z6eB6cE91geIPswxRtFrHchMFZxGqfqrLsTDasY5as4F+v jcYDTqDa63cYmugfN4gbo3joRtTv5eBzdFmTFM4rCxnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjW1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSJZiQKGvSVgNhDCShgGnBSGI5937XIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT 5VAMGQ0PEWfC/FJEmYnFIs8w8CuvEvEYiN9gljK+JQK/WeGmWSd15CyaYGIK7RmX/59gUKwt m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUbVVa+4um0jGa7BsoZI EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUDxyKu7vON+zrHXFk8R29tTf8dk8U5EGlCO kCyoz/5OdB+mOTLFCnFr+/K8Wza1Ts9djFbO3JdJecRy5y6+dxo0EqSJjp2OPTt5uAZDw0c1 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+aTNT8D2BQwQKHhcus1rqxQFibp 2QjkMOD9u0IBpzlvHXTHb9dTeH5ua/ebme0bbtT834JrmvFxpJeVdoIvGEWyLlBb67ohgMFk GeM4FgMtfe/zVOhbLNtYpLZNijZ5fGIKDgRbdiNNoAmSsEoLGevpXgyDWbNjzGFuBV9yskXZ MbEGftA+F5HUMxP1iStfe4B3NcDn2ZmrY8lbcuglErPPHv3TCP9dIrpx3PVNbBlvP3e8VqJm zudXuPToyhivCTFSnG/2eYuwZoidxDX2bieRxRrS9O+ IronPort-HdrOrdr: A9a23:r06Dta/f4ZA9xu8ApJNuk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/ re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM 9bAtFD4bbLbWSS4/yV3DWF X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71163897" Date: Fri, 20 May 2022 14:48:00 +0100 From: Anthony PERARD To: Elliott Mitchell CC: , Wei Liu Subject: Re: [PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate vars Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Fri, Apr 29, 2022 at 03:45:25PM -0700, Elliott Mitchell wrote: > Rather than having shadow variables for every element of dom_info, it is > better to properly initialize dom_info at the start. This also removes > the misleading memset() in the middle of main_create(). > > Remove the dryrun element of domain_create as that has been displaced > by the global "dryrun_only" variable. > > Signed-off-by: Elliott Mitchell Reviewed-by: Anthony PERARD Thanks for the clean up. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 20 13:57:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 13:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334232.558229 (Exim 4.92) (envelope-from ) id 1ns37g-0003KT-25; Fri, 20 May 2022 13:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334232.558229; Fri, 20 May 2022 13:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns37f-0003KM-Vb; Fri, 20 May 2022 13:56:55 +0000 Received: by outflank-mailman (input) for mailman id 334232; Fri, 20 May 2022 13:56:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns37e-0003KG-Pq for xen-devel@lists.xenproject.org; Fri, 20 May 2022 13:56:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abbd5e03-d844-11ec-837e-e5687231ffcc; Fri, 20 May 2022 15:56:39 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-13y8Cn5iO1iEYxdMK1SJew-1; Fri, 20 May 2022 15:56:49 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7420.eurprd04.prod.outlook.com (2603:10a6:102:93::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 13:56:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 13:56:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abbd5e03-d844-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653055013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dFU6grAchxmaSPoDPT0/TN4xdOlUQyN+/Ob9XXj/Z9s=; b=c5vr5l460Qnv9SWeSki5J6MkcQbfG/Pae0iUVGVEQNN+OAvOrQIrN+XVwft0XGJA56Yx4K VyQ8yUa/0aQxUxKcTqaC6V+A4J2GxU5M8z1N93XdVUPqUeafQzi69Fo2790dzddNzRFo0j du69AAxHpB5qpd1N5jFr2YhyOzCPUww= X-MC-Unique: 13y8Cn5iO1iEYxdMK1SJew-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KWlzHHqmrvVo/4Y+AnJqf4ZKXyLWGYLe32HkIEV+UbWsUhQzBBTkkHefHmsFD0mtcSdyJ5BZfB3kR5F9DcL2qrvEookr5Ajky1xDMRNCTOXyr/AP72VoHEYQwW4vxY1c9/KrZGpIC262sJG1gzW17ZnIpGsZ05C05d8Jp5Kb0dEnEV8U16p07nY8s9jw78ZvRe7GJzrBIOo9Gtx5SRneIEbMCOm09EHrx5rYhD1Er6Oxihdojiv5moSfGb8CQ+bxn0uIVArAcaMBeU5HoQMJO/rkHBJPcgA08kr2I67GjrqwG8wKiVv9EnLbk8DVlLW1KI3bsh3M5zY7+6LOeEVn0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ynqs+BSk2t9/Jj2XX7dHUyBhK73T24oGcZM40uf9Hfs=; b=VPK/XOnBeD2C5028OrXBMwd3Pp5Mab/9oWfkH+V8OiP7/tbAfuQDzNI3VJFpTjsXURnyPJMOcZo9YncAcig9FKvYwPd1TWX7ADn5aVLgz+OUzLp/EfbSyJrJrrf+xSrjyoUme947lxuMvxOaMQItW7H/PR/JtF9NWqiXswZgXxvS72bETPkjxJx8PQSXMwVAcuQNcs+yF5W/mQXCz9lm2qS6D+eg33WP3DLPWHyD4aoHq0+CNTzYSvoFvNzZui46JmnVRrKv1ZS/CJ1EjASfGTtLnB56a3JkXGJ5RXNDJm4cQn6nZwc1Gp5m/B6whvO7M59BWQU29CjMrHc0RwIKUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4f9343a2-7ac1-11ea-276e-32b7207db072@suse.com> Date: Fri, 20 May 2022 15:56:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] build: Fix make warning if there is no cppcheck Content-Language: en-US To: Bertrand Marquis CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> <3C17CA95-8415-4A05-BD3B-95FE57465C82@arm.com> From: Jan Beulich In-Reply-To: <3C17CA95-8415-4A05-BD3B-95FE57465C82@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR07CA0060.eurprd07.prod.outlook.com (2603:10a6:20b:46b::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3bd3731b-e681-4dbf-a414-08da3a689554 X-MS-TrafficTypeDiagnostic: PR3PR04MB7420:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lIp/HeKyQGXSK1Omu6TRVYKG8qjVqOCiQgfMD/XDcE/ZDg5zY/Z6NbqNCVazs6Z9aa6x5pafvFFC+sYWSOmCW4cI6M9hs70GbyuGWAJaTUKLE5tfRv2spBTBrUKLGCgm8dWsz9ElAkFi3szaJZcHf4OPz56DGy+wQTbmDFIOLbtSZPz8G11Fs39jmrBthw+UuK/pQONYdvMivjXmkAJ9J23Tkq2+QvFVpECEvIUdizef9JCvAslkpQTShGkL2b8pYnbBqCFlOGKwKxzmEN8YLzWvoH1L9iG0nLodY0WOjfmMRvBtR20wxaLsxRD8kLgR5Ozev2L0I6mlH5QWECpH2R6E/Y+AyYhWV4R3X1uj2JA4O0GHcCjCEW5w9juE/qY8gRKITPyLZVT72YDen1/uqxs2KefCMPMWnpK+P78o5W7womnBRMaxqGkSwmpPRehNAJIh7w9MytaHrONSyx7sRHIgYsNZ7OlQrqcQrWo5Oj4GpiH7HuVLRjAFd/HC9/WfvLJbEGX4QqtmuaMFSY9IdKzoa2ZjfgyRJmnznIuTK6OwwF8SeNS8Li8vzua4wnXBQTpVUoj6x8hrCZW1X4M8j3uQp7/i2wceLNIUICGZjS15QWZhM0CYczK5OMfjwVHuX495+Tg4UJ2yIuCPyPUl94T3rx3kTmyTpDh/i7G3y+mwM8IZsH/VdC+0UHOtKn0pPWfIs6Nrogx/aX3SSuOCLcCbGdsXkQvLJ9fKXgaxzSc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(8676002)(66556008)(66476007)(83380400001)(38100700002)(26005)(6512007)(31696002)(4326008)(5660300002)(2906002)(86362001)(6486002)(2616005)(31686004)(508600001)(8936002)(316002)(186003)(6506007)(6916009)(54906003)(53546011)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+KwcUL8+ORhouqTi96Sf8ib48QPKb2W/Inq7K8ljYAV0K38o2jgV2piDyx0d?= =?us-ascii?Q?cjPKBwa/b124K8NFEaoj2yZBuHlqmdYfKB9LGA84eze+LhQzboMhdjdyhhR0?= =?us-ascii?Q?jd5dSLHr+A1kn9LMvFhQe7yaoCbvrrr/z1Ojd44hDpwAIJeJ6nVM1OpdKJVk?= =?us-ascii?Q?yLngSAdbPAtka71KBeOEOHLoxlOyv/YaAMbIyhniYwFExp60hnsloCCy93e9?= =?us-ascii?Q?7atbcpzLEIt9MvRWNgy8OwpjGUOQyaPJN40xEo9s78z6FwCh/EUsVl2VxgF4?= =?us-ascii?Q?EaaIWfQEa7DhiSonRLhAucHiKNG6m8/+8dad/bmnU/gt5E7JOatXe3FVDqje?= =?us-ascii?Q?LH8hzzR2nygf6ffRQFsy8/mOUgktCIs2lII0tCkO6kb2l4Iu8wLQm1G5r3OP?= =?us-ascii?Q?YW4y90Fpr11rjRvAvjDutjOwqmynO2CkFVbwF18wPxhQ2x8xEj5Vjb+7KI0T?= =?us-ascii?Q?BSHCDB38ZgUHX2EyEGNMnCutXfu8rlIaAhoCtumuTj/IZzVHkK3cGZGWRcXu?= =?us-ascii?Q?+Qc7zAFiGmAB23p4lkKPTRH+YWtK0Hg35XrfVCTkzGigJYZshHFIqlIBSkKF?= =?us-ascii?Q?bTKWAQQUz24D+nN3Kqbgr7FkYXSexvP0eIzcN+YWWG2jZpDi4N+AMAZ6MdUA?= =?us-ascii?Q?FM0UzVUD0/4v5TndBGsTYsOobJVAamEbLWLWhH3HdlQ84riQvL5Rl7D5v2wo?= =?us-ascii?Q?0RENKKSeBJPTAX2nCB38Rf0KZGrhK67en9PtaUcTQNLUYV+d5dMjzfjLUcLu?= =?us-ascii?Q?LpeNzLdFkHO8/LJzbMU4f3Z0wUKW/YE0KM5XHdaEgTd+XLXMXPCdjiQae0KS?= =?us-ascii?Q?AHI++nXNz2vY2yYFPqDLeyIECslAe8Pnx7++LGz4020pX75Z7JsrrPIl23ef?= =?us-ascii?Q?td5riMYkANADEN6GW/7VfU5q9yU4WItedZm+69b08gDSf0fbs+eKm0nOcX6A?= =?us-ascii?Q?5Kh/PJZDkF5JDZewXomHJWSV3KJnucDZ41C9QcwgrpDMAFmAHxiZgTl2fJPO?= =?us-ascii?Q?4U118lCxxMuJLZs5PI0xtu2kmXhfsTA4HvQ1x6u1lNuPRmQE9gdmse81jtCy?= =?us-ascii?Q?PgD7+OKVOv2DNOi04fxzO+fJZgjTGvkbGXPsegKe3Ag3BkcBSVJ0w97yXg3E?= =?us-ascii?Q?C7mu3q3ds7GxYwE2RspXGOJTj+OxtyzUyqGOxbOt0U05twzgouxmqkbwcZhz?= =?us-ascii?Q?NIhxEDutzRrr6AlXrmfLka+cd+RWrGNsavnaQYKBAnqhJXFMrATnMWJvQf0u?= =?us-ascii?Q?TaIohuQFsZGtGCPeEuXQ3Hh+ABX+36pdp4KMuurgPKx8Z51AUieFkOuqU2V7?= =?us-ascii?Q?Q1yWyOASSKVe8gZ2ysSQmqFA4Ya/fCqbR+ASjen2kJULoMUUdwrL7n2U3j1w?= =?us-ascii?Q?6aWHMd+y5bfJbyeBG6ebkl7XpkEWsky2j56sMsYWSl4SEXjemwqvlXurwNiZ?= =?us-ascii?Q?rRvmI4fhw9bxIFqTAe4tI37QPXklPpLgjpfZ5KhtyBauVOVE67GOsXxbJ53m?= =?us-ascii?Q?9A8/DHkhuNmjw4rnEMZ6sdl3SA3Juofs1NHKgfGKSNETrD0fu4QY+cp0IjkQ?= =?us-ascii?Q?rUVEput9vbl/6GzjtekuZvuDYiCcIA2MBl1dr9sNbaD2J05bplNLUmIw88Mc?= =?us-ascii?Q?l6oUpJ3mGIGQvZ2zSolcUUe56bnwOX2XRMkkO9NcpuOU+bkMlD1kmWBGhmVA?= =?us-ascii?Q?9klkrnKd2HORld6UdHeXf8CvTaIOqlAGqtd1czs3wLr9zbFDFvjjvvhNU+2W?= =?us-ascii?Q?0XSFoYL41g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd3731b-e681-4dbf-a414-08da3a689554 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 13:56:48.4583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P04Kjrd+XXU1DxbvhSRqsbMBbO/zy5c0XJvJ4Rz+prjbMRMwF3PNMYpaQVUJT+4XnJtUtsIV2fonUI/sda5fCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7420 On 20.05.2022 15:23, Bertrand Marquis wrote: >> On 20 May 2022, at 13:51, Jan Beulich wrote: >> On 20.05.2022 14:14, Bertrand Marquis wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -694,12 +694,14 @@ $(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree= )/include/generated/autoconf.h >>> $(call if_changed,cppcheck_xml) >>> >>> cppcheck-version: >>> -ifeq ($(shell which $(CPPCHECK)),) >>> - $(error Cannot find cppcheck executable: $(CPPCHECK)) >>> -endif >>> -ifeq ($(shell $(CPPCHECK) --version | awk '{print ($$2 < 2.7)}'),1) >>> - $(error Please upgrade your cppcheck to version 2.7 or greater) >>> -endif >>> + @if ! which $(CPPCHECK) > /dev/null 2>&1; then \ >>> + echo "Cannot find cppcheck executable: $(CPPCHECK)"; \ >>> + exit 1; \ >>> + fi >>> + @if [ "$$($(CPPCHECK) --version | awk '{print ($$2 < 2.7)}')" -eq 1 ]= ; then \ >>> + echo "Please upgrade your cppcheck to version 2.7 or greater"; \ >>> + exit 1; \ >>> + fi >>> >>> # Put this in generated headers this way it is cleaned by include/Makef= ile >>> $(objtree)/include/generated/compiler-def.h: >> >> Fine with me, even if - as said on v1 - I would have preferred $(if ...)= . >=20 > Could you explain why and what you mean exactly ? I generally think that make scripts should resort to shell language only if things cannot reasonably be expressed in make language. > I thought the code would be more complex and less clear using if and I > do not see how it would solve the issue with which being called. The problem to deal with was to move the shell invocation from makefile parsing time to rule execution time. Hence I don't see why cppcheck-version: $(if $(shell which ...),,$(error ...)) wouldn't deal with the problem equally well. But I guess I may not be understanding your question / concern. >> One question though: Wouldn't it better be $(Q) instead of the two plain >> @? Preferably with that adjustment (which I guess can be made while >> committing): >=20 > I thought of it but who would be interested in actually seeing those > commands which are not =E2=80=9Cbuilding=E2=80=9D anything. You never know what's relevant to see when hunting down some obscure build system issue. Jan From xen-devel-bounces@lists.xenproject.org Fri May 20 14:01:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:01:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334240.558241 (Exim 4.92) (envelope-from ) id 1ns3Be-0004nN-L5; Fri, 20 May 2022 14:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334240.558241; Fri, 20 May 2022 14:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Be-0004nG-Gy; Fri, 20 May 2022 14:01:02 +0000 Received: by outflank-mailman (input) for mailman id 334240; Fri, 20 May 2022 14:01:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Bd-0004n6-M2; Fri, 20 May 2022 14:01:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Bd-00083w-JI; Fri, 20 May 2022 14:01:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Bd-0004Ar-74; Fri, 20 May 2022 14:01:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns3Bd-0004yb-6d; Fri, 20 May 2022 14:01:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ez5TOdbzyqsW3EM3ALieJysk0rZeGzMZbqNyUlowEsg=; b=zC824g16B33DZKU/38sm5DhKkz jgODfw4ShZ+6MVY1lqEEidXRIbU0MJ2g09LMSs5tA2EhgIqlhI+gIcG2UwkSksFG8YO8WSQIoD7Ta l5UPFB6qvOK4NhQMCZNHMUCB5u3PbvkuVojVWEkUZySYbS9eL+JKqxl2yLBkgkStuV34=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170603: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 14:01:01 +0000 flight 170603 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170603/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1121 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 14:05:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334250.558252 (Exim 4.92) (envelope-from ) id 1ns3GC-0005Ru-AA; Fri, 20 May 2022 14:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334250.558252; Fri, 20 May 2022 14:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3GC-0005Rn-6h; Fri, 20 May 2022 14:05:44 +0000 Received: by outflank-mailman (input) for mailman id 334250; Fri, 20 May 2022 14:05:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3GA-0005Rh-TF for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:05:43 +0000 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ebafcdf1-d845-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 16:05:38 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 07:05:35 -0700 Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 20 May 2022 07:05:34 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 20 May 2022 07:05:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 20 May 2022 07:05:34 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 20 May 2022 07:05:34 -0700 Received: from CY4PR11MB0056.namprd11.prod.outlook.com (2603:10b6:910:7c::30) by MN2PR11MB3613.namprd11.prod.outlook.com (2603:10b6:208:ee::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 14:05:30 +0000 Received: from CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f]) by CY4PR11MB0056.namprd11.prod.outlook.com ([fe80::181f:ef86:8705:bd1f%7]) with mapi id 15.20.5250.018; Fri, 20 May 2022 14:05:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebafcdf1-d845-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653055538; x=1684591538; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JGqMiaNCtiKWopGTCzc8G1mAq76OUlPHlMgwCadM3C0=; b=OgRN1Mu9iciGcp2EXgBrsgyxYHTfNFx0r64SN7xqPbtB8tadBd0zmYaG Al3azpi9LBWol5bofu7g9Aj/TXPbkflao9G0qsSeBVuXZqQN92gOmygoW oOI7D52goki35t/A2Lfji5wd3hOT0gaFWwsMXJ2J9X1SDMN8m/bk2WPve YwMMltY6mpeu3Edotm/7JKyjBUdjr/yAuB0DRDb6MHop8mU9DwLFuJv04 YMI2xp7BlvIX/c4teGV2thFtuvUa8tIYwEc1n+VhxhOshLn8CtxaZYm18 3+JWdM7z+e8ofRvNw9MzBAhQmWiD9RvSZrYfJjEnO6w1nQ4LNX8HQwgmt A==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="253129864" X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="253129864" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="701759726" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BWANSao1HXiE5wM2tJ7JujF3L+RLMOYLjd88STtVePfR1YEinISYZyTGYbF2ODlpoQzix39ITfDAGnOP2ahjqA1tyCztM4TgQAqXAVJua3TxvRx7Tnxtqv0KUVlgGjJhbCe3IdXsC+y6Vkj8uBZahhxDW51Y/jx6L7KHbcPTNorEQR1n3/UG8xZmcunX8vuVrxIOztPqtreTHRecigVNYGHuU6coCgQaaVpSHIbHyuwfBGEIpon+UT2n0Rmuc5m2BHJ/q+2MslL0ZQuWpEN/ZZBfm827xkbf2CbPSZXX6idwrdORmFB6+9utMBPriZdUgwW8moaY2lyXnDraULQxwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JGqMiaNCtiKWopGTCzc8G1mAq76OUlPHlMgwCadM3C0=; b=f67OhvpnqQTdJ1w06GsXtvgQUxFr9fcX3wnleJEUHM0lP5ilh66S+usM51nALr89TKUEFZELpRTmkwUriTL2NOj6Q0yv4x8Yt8PGTgVG9P1BNTITDmzAEjKzuNzEvuRnMOpIVeiZiC5B4+XLXmG2xYRquNeq7H4Oc+kpuFFu7OmSt8Vtf3byW3ipy2Ociz+4RF9i+ysAnQtGZoEqbjN3GAm+xsBFqU8UK7F+ecrpWSiW60+4Jn09780VoKlc3uyEknH/9pwvP7wPSCbLFwjwsLBp4+76YmfFABwARnhXBAnbGN5Q0t88xoJmL1lmVdU1gSwoovRnbmvmZuWAIl5GIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Lengyel, Tamas" To: "Tian, Kevin" , Tamas K Lengyel , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD , "Gross, Jurgen" , "Cooper, Andrew" , George Dunlap , "Beulich, Jan" , Julien Grall , Stefano Stabellini , Alexandru Isaila , Petre Pircalabu , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Nakajima, Jun" Subject: RE: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits Thread-Topic: [PATCH 3/3] x86/monitor: Add new monitor event to catch all vmexits Thread-Index: AQHYWkxRLPl0PMiFWESicSOc/TYisq0OvK8AgAycPYCACYL7gIACMmIAgADiI1A= Date: Fri, 20 May 2022 14:05:30 +0000 Message-ID: References: <7f03387eebf9de474f404ef661f80133e3725365.1651073086.git.tamas.lengyel@intel.com> <65645a9d2ada525c9ffc07dce594eeff5891b5a7.1651073086.git.tamas.lengyel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8165255-62b0-41af-2a6a-08da3a69cca5 x-ms-traffictypediagnostic: MN2PR11MB3613:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X3rVgUWUs2B5kcRk4r2xt9CeM1gaTXhgYT47p9nvbRpHVia1dT15TDipcNyeVSu95M88G4kGU3LsaFYGe1kRA783ci1sgcwj3Nm4egv8RVndW3i7tO3kpNgkj5lHiYs+240LbHW3dEb6WQBEyP3TGFs2yQbmIi+vILrSx3mhiWGJ/T5wZPJqxoSRTNpe98CXoPdNH7K93lcOamfS1qIALDc+3Rew+X6AqNmun2rB6LHF01C7h7XG7HpDe9vIR+re8Wp+J9WbAUQt5tv5TnAiFx81f4Sqd8JGV0dwcWNZfqZU20nqNbiRV+rGLqDFIDyVD4pKp+ierfkWn5/4b7KP6To1rgBarjV3f31zA5n+8BRCiCKW6gwM6eNds+6LgnEmkJLoS8Aw8rL6Bv60SxmjopJEn2JGd5pbPiwY+OeZFfdBV9+xqnfc5KQ0opNWM4lSUNiNVkS/h6mqsB3+xrhm6gOp4hTBowFbbARSFRsXVTtdfv2hriPmWtKKh7MIxsJRvPbV6sBU4yRb9NdAHR2RCEllFULJ1DVVGAteesH/J/8gS+sL1d/aaBqL1ocsRhFBHjPBVxdDKs7E+HdjUultItsVRljTZS+5PRPMCR3sUpt56UWHX6zM5M5AMOQ3zKLkO8tsk02jLNciKIMGdb6LKeQllVyBFzIjXlAYgHQioJUNWNIUbZQheHaaL0xNHEdUEil5KsaD3iXO3CjnBgacuw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB0056.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(53546011)(54906003)(186003)(107886003)(110136005)(316002)(9686003)(26005)(86362001)(6506007)(71200400001)(2906002)(508600001)(4326008)(8676002)(122000001)(38070700005)(8936002)(82960400001)(38100700002)(7416002)(33656002)(76116006)(66946007)(7696005)(66476007)(66556008)(66446008)(64756008)(55016003)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UVNXdy9MSjVjcmlNUzFtNGh0ZFhTWXJNUUdCa0RLRXN0dEVyMkQwUHVwWGxU?= =?utf-8?B?aGU0OFhXN29PdnRCSEpueUF6ck9oMWZsMHhwVEVVelRkZjViS2ttbWtLQXBR?= =?utf-8?B?MStmK0VVZThEOGdiMTlOd1JuMmpSMnNIczBxdk1JSDZNdG9tWkZodWtmd1Uy?= =?utf-8?B?YnpMQ296cmJVRHJpcENVMnpuVFdHQkt6aTNGcXRSUlludjZpTTdxUmJDZnVD?= =?utf-8?B?amJkRUNiRTQ5UXl6NzVGVkJTSzJhWjArSUpKZUZMbEpWaVRrYUxibU1hNHdW?= =?utf-8?B?VlhFQ2lKdWFPeHFwd0ZJSWtCZk5WMGdmaVFEUHFzREJKQmVyandnTWIySWlJ?= =?utf-8?B?SWhvNXJWbTZUQ0hxUm5NZ3F2Y29LUkFLL25LWTRKUlV4OS9KYkVxTXRRNmZE?= =?utf-8?B?c1lNQ2lzZllmK1VSczBWallQcDBTSmtTZjBSTlJZMlRzY3MyQ09XOE1NSUJL?= =?utf-8?B?OVlES2o4eGxjUms3cUlYWmZEY0tmWkVuMitIVkxhUlNVWVViSUF2UmVvOFIv?= =?utf-8?B?RUJUNjAwVFN2bjNrSEFCSjVHZkJCNFhnMWo5dG5WNDA1WG96RUMxS25nWXBY?= =?utf-8?B?YlBSOFY0MS94ZnVXdTN0SU9wNnhCMnFwQi81VXB5OUx4ZDF6bzFsYkZmL3dZ?= =?utf-8?B?WnpsN1dWR3owcHBxMnBXSzIvaE9HeFJmYWhBVVVYcWkvOWNKVGw5SUFiczZy?= =?utf-8?B?ZlN2WFI0bVFzNkJleFRKL3N4ZkZkMUlnUTROR1hMcFpzeXZWbiszVFQ0Tmhj?= =?utf-8?B?NVV5ZmxqbmJ3RjhmMGhZckFyZmZEamYreE1PaWEyZ2w3MTJieWFPL2t4Mzk1?= =?utf-8?B?ZmkyWEJLblE1V2syUFRkVnhGZmFubnZmQ1VFZmpBaWtOblhRdFlxVW5ZZXl2?= =?utf-8?B?bTRjSWZKekVISGRCNFA5Rlk2dGhHNWdPWWlrdURKNzF4RlhyZlo5RUlYd1Yz?= =?utf-8?B?ZDdjZzgvdVBtd1Rid3dIY0FEeG80WnVQamd6MjAvUWdmL1dFeXN6ZFNrWlg1?= =?utf-8?B?Y2JXYTFFTWtEenFFbWtWM24xam4zSDN1VWNOaE5ZRjhrY3dvZTJJKzZreUJ0?= =?utf-8?B?Zk11UGNiMUlNa25VREUvZU9aZUUzSEwrSTh1RUtMazdocEV2ZHhKbVRVUXJJ?= =?utf-8?B?R2ZVdnk3bTl5YWhhUHM0YW1neTYyKzdQUEZJNHJuT1JrZTJlNlFPMmloTXov?= =?utf-8?B?OHB6bi9XTno2MVR5YmpFT241blhmWnpFYVRVRlRjdjQ5RVhqbExUZG40WUZT?= =?utf-8?B?bHk2c2RpYndaRTgzaGdvN3FDZlR4Yk9JZHIxKytyYmg3Z2RYWHFmc0lFZmlt?= =?utf-8?B?TDRUWkxvMFhKdXliL0lQUytVQnhqTW9nUUJFbnUrYUNVQ3lDM052TEhpQ3F5?= =?utf-8?B?T21IbTQyUzhtbUJpQVdkM0xsY1AycGNEb2h1d2k4aWNvWFVucG5xNE5WeDIx?= =?utf-8?B?ZVZJTFdhdlliOUhVWjFHQXpNUnpjVXZ2NzUvTk9tS29EUng4TXBLaTNoK3d4?= =?utf-8?B?WmlsMUZKTkF4Y0syT0xONlN3VXZLZHVGZG5vM3NSZS9QRW5FYm9RUTVvekhU?= =?utf-8?B?djFPRWxZck9QbHVOTEk3YXM3RG5ONWpoRUQrV3VHcVpOVzNMOWZSNXV5R0h0?= =?utf-8?B?Y25Dc1BMbHhNcFFPb0tIcXh3a0FzUmtrRHdRSTQ2OTdTdzlpL0hFb3hEb0lo?= =?utf-8?B?VHRpVklEUFFaa005b3VIbmZJU0xvVEVGY21yNlNnUHNDRTBUNC9zZ3pmWmJX?= =?utf-8?B?OGczQ2pzSWxVb1paNnNHWEpReE1HTlFFSms5Y25XZzhDbytQbVlOMDhqVnoz?= =?utf-8?B?ODgwSFNjWlI1a2c2b2NaOE12VXNpVVJoM0xWU3lBbnZZZ3V4cXF5SDdOcmFq?= =?utf-8?B?U0wwYUo2ZmJDTG1SK0w0RTRQSnlUdjZRR1B5WUNycFU1Nk1JMEphTmJqbWRn?= =?utf-8?B?ZjZDbmdTa2xkczRnaWFSaUZnMnJpREZlQitGTkk4bHJRL1dLMDMvZFAyQTY4?= =?utf-8?B?REg5VktnRlpzR1pCeGlvSWRmWVJORDZmL0c0SzBYTkx0RjFJc0VQSWJpQzhJ?= =?utf-8?B?dGpGMTh1MXFnQkFNdWpiUHBRVG1WTkpVR1NQZ1g5Ni9LK2FQdGZ1R2doa2Nt?= =?utf-8?B?TlFPdDZUQ1gzRDRYMmtGbE84YUJQVkJIWjJLazdtMVZQQVVkVXNqT2NTcnQ3?= =?utf-8?B?b0kwTStIdHBhR3hDOW9uazU0QURaZzhNWDNVTnMzeXhJL00zdzBzOEkzZ1FW?= =?utf-8?B?dXlEaFVFcmhtR3NDcWNkWjZtRFhYdHlmbG5YQ1psRTBDRnRoNVByVEl0NXcx?= =?utf-8?B?RDNHVnl3ZUhpNkdtS0t3cVpqR3B2M3JJR2J6QXpCb1RlTmZVNDJ5Zz09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB0056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8165255-62b0-41af-2a6a-08da3a69cca5 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 14:05:30.5387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G71nxVHAJt8Td0/rig01Y+FY5og79/inQxUut3VT34q7BXYrjEkHnR/2SBAoY/Lm9rcQ2vN4HMWzIDrPO7HO0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3613 X-OriginatorOrg: intel.com DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogVGlhbiwgS2V2aW4gPGtl dmluLnRpYW5AaW50ZWwuY29tPg0KPiBTZW50OiBUaHVyc2RheSwgTWF5IDE5LCAyMDIyIDg6MzUg UE0NCj4gVG86IFRhbWFzIEsgTGVuZ3llbCA8dGFtYXNAdGtsZW5neWVsLmNvbT47IHhlbi0NCj4g ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IExlbmd5ZWwsIFRhbWFzIDx0YW1hcy5s ZW5neWVsQGludGVsLmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+Ow0KPiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47IEdyb3NzLCBKdXJnZW4NCj4gPGpncm9zc0Bz dXNlLmNvbT47IENvb3BlciwgQW5kcmV3IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsNCj4g R2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgQmV1bGljaCwgSmFuDQo+ IDxKQmV1bGljaEBzdXNlLmNvbT47IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVm YW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBBbGV4YW5kcnUgSXNh aWxhIDxhaXNhaWxhQGJpdGRlZmVuZGVyLmNvbT47IFBldHJlDQo+IFBpcmNhbGFidSA8cHBpcmNh bGFidUBiaXRkZWZlbmRlci5jb20+OyBQYXUgTW9ubsOpLCBSb2dlcg0KPiA8cm9nZXIucGF1QGNp dHJpeC5jb20+OyBOYWthamltYSwgSnVuIDxqdW4ubmFrYWppbWFAaW50ZWwuY29tPg0KPiBTdWJq ZWN0OiBSRTogW1BBVENIIDMvM10geDg2L21vbml0b3I6IEFkZCBuZXcgbW9uaXRvciBldmVudCB0 byBjYXRjaCBhbGwNCj4gdm1leGl0cw0KPiANCj4gPiBGcm9tOiBUYW1hcyBLIExlbmd5ZWwgPHRh bWFzQHRrbGVuZ3llbC5jb20+DQo+ID4gU2VudDogV2VkbmVzZGF5LCBNYXkgMTgsIDIwMjIgMTE6 MDIgUE0NCj4gPg0KPiA+IE9uIFRodSwgTWF5IDEyLCAyMDIyIGF0IDk6NDcgQU0gVGFtYXMgSyBM ZW5neWVsIDx0YW1hc0B0a2xlbmd5ZWwuY29tPg0KPiA+IHdyb3RlOg0KPiA+ID4NCj4gPiA+IE9u IFdlZCwgTWF5IDQsIDIwMjIgYXQgOToxMiBBTSBUYW1hcyBLIExlbmd5ZWwNCj4gPHRhbWFzQHRr bGVuZ3llbC5jb20+DQo+ID4gd3JvdGU6DQo+ID4gPiA+DQo+ID4gPiA+IE9uIFdlZCwgQXByIDI3 LCAyMDIyIGF0IDExOjUxIEFNIFRhbWFzIEsgTGVuZ3llbA0KPiA+ID4gPiA8dGFtYXMubGVuZ3ll bEBpbnRlbC5jb20+IHdyb3RlOg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gQWRkIG1vbml0b3IgZXZl bnQgdGhhdCBob29rcyB0aGUgdm1leGl0IGhhbmRsZXIgYWxsb3dpbmcgZm9yDQo+ID4gPiA+ID4g Ym90aCBzeW5jDQo+ID4gYW5kDQo+ID4gPiA+ID4gYXN5bmMgbW9uaXRvcmluZyBvZiBldmVudHMu IFdpdGggYXN5bmMgbW9uaXRvcmluZyBhbiBldmVudCBpcw0KPiA+ID4gPiA+IHBsYWNlZA0KPiA+ IG9uIHRoZQ0KPiA+ID4gPiA+IG1vbml0b3IgcmluZyBmb3IgZWFjaCBleGl0IGFuZCB0aGUgcmVz dCBvZiB0aGUgdm1leGl0IGhhbmRsZXINCj4gPiA+ID4gPiByZXN1bWVzDQo+ID4gbm9ybWFsbHku DQo+ID4gPiA+ID4gSWYgdGhlcmUgYXJlIGFkZGl0aW9uYWwgbW9uaXRvciBldmVudHMgY29uZmln dXJlZCB0aG9zZSB3aWxsDQo+ID4gPiA+ID4gYWxzbyBwbGFjZQ0KPiA+IHRoZWlyDQo+ID4gPiA+ ID4gcmVzcGVjdGl2ZSBldmVudHMgb24gdGhlIG1vbml0b3IgcmluZy4NCj4gPiA+ID4gPg0KPiA+ ID4gPiA+IFdpdGggdGhlIHN5bmMgdmVyc2lvbiBhbiBldmVudCBpcyBwbGFjZWQgb24gdGhlIG1v bml0b3IgcmluZyBidXQNCj4gPiA+ID4gPiB0aGUNCj4gPiBoYW5kbGVyDQo+ID4gPiA+ID4gZG9l cyBub3QgZ2V0IHJlc3VtZWQsIHRodXMgdGhlIHN5bmMgdmVyc2lvbiBpcyBvbmx5IHVzZWZ1bCB3 aGVuDQo+ID4gPiA+ID4gdGhlIFZNDQo+ID4gaXMgbm90DQo+ID4gPiA+ID4gZXhwZWN0ZWQgdG8g cmVzdW1lIG5vcm1hbGx5IGFmdGVyIHRoZSB2bWV4aXQuIE91ciB1c2UtY2FzZSBpcw0KPiA+ID4g PiA+IHByaW1hcmlseQ0KPiA+IHdpdGgNCj4gPiA+ID4gPiB0aGUgc3luYyB2ZXJzaW9uIHdpdGgg Vk0gZm9ya3Mgd2hlcmUgdGhlIGZvcmsgZ2V0cyByZXNldCBhZnRlcg0KPiA+ID4gPiA+IHN5bmMN Cj4gPiB2bWV4aXQNCj4gPiA+ID4gPiBldmVudCwgdGh1cyB0aGUgcmVzdCBvZiB0aGUgdm1leGl0 IGhhbmRsZXIgY2FuIGJlIHNhZmVseQ0KPiA+ID4gPiA+IHNraXBwZWQuIFRoaXMgaXMgdmVyeSB1 c2VmdWwgd2hlbiB3ZSB3YW50IHRvIGF2b2lkIFhlbiBjcmFzaGluZw0KPiA+ID4gPiA+IHRoZSBW TSB1bmRlciBhbnkNCj4gPiBjaXJjdW1zdGFuY2UsDQo+ID4gPiA+ID4gZm9yIGV4YW1wbGUgZHVy aW5nIGZ1enppbmcuIENvbGxlY3RpbmcgYWxsIHZtZXhpdCBpbmZvcm1hdGlvbg0KPiA+ID4gPiA+ IHJlZ2FyZGxlc3MNCj4gPiBvZg0KPiA+ID4gPiA+IHRoZSByb290IGNhdXNlIG1ha2VzIGl0IGVh c2llciB0byByZWFzb24gYWJvdXQgdGhlIHN0YXRlIG9mIHRoZQ0KPiA+ID4gPiA+IFZNIG9uDQo+ ID4gdGhlDQo+ID4gPiA+ID4gbW9uaXRvciBzaWRlLCBoZW5jZSB3ZSBvcHQgdG8gcmVjZWl2ZSBh bGwgZXZlbnRzLCBldmVuIGZvcg0KPiA+ID4gPiA+IGV4dGVybmFsDQo+ID4gaW50ZXJydXB0DQo+ ID4gPiA+ID4gYW5kIE5NSSBleGl0cyBhbmQgbGV0IHRoZSBtb25pdG9yIGFnZW50IGRlY2lkZSBo b3cgdG8gcHJvY2VlZC4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFRhbWFz IEsgTGVuZ3llbCA8dGFtYXMubGVuZ3llbEBpbnRlbC5jb20+DQo+ID4gPiA+ID4gLS0tDQo+ID4g PiA+ID4gdjU6IHdyYXAgdm1leGl0IGZpZWxkcyBpbiBhcmNoLnZteCBzdHJ1Y3R1cmVzIGluIHRo ZSBwdWJsaWMNCj4gPiA+ID4gPiB2bV9ldmVudCBBQkkNCj4gPiA+ID4NCj4gPiA+ID4gUGF0Y2gg cGluZy4gQ291bGQgYSB0b29sc3RhY2sgbWFpbnRhaW5lciBwbGVhc2UgdGFrZSBhIGxvb2sgYXQg dGhpcz8NCj4gPiA+ID4gVGhlIGh5cGVydmlzb3Igc2lkZSBhbHJlYWR5IGhhcyBhIFJldmlld2Vk LWJ5Lg0KPiA+ID4NCj4gPiA+IFBhdGNoIHBpbmcuDQo+ID4NCj4gPiBQYXRjaCBwaW5nLg0KPiA+ DQo+IA0KPiBJIGd1ZXNzIHdoYXQgeW91IHJlYWxseSBtaXNzZWQgaXMgYW4gYWNrIGZyb20gdG9v c3RhY2sgbWFpbnRhaW5lciwgYnV0DQo+IGFueXdheToNCj4gDQo+IFJldmlld2VkLWJ5OiBLZXZp biBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg0KVGhhbmtzLCB0aGUgcmV2aWV3IGlzIHN0 aWxsIGFwcHJlY2lhdGVkIQ0KVGFtYXMNCg== From xen-devel-bounces@lists.xenproject.org Fri May 20 14:06:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:06:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334258.558262 (Exim 4.92) (envelope-from ) id 1ns3Gq-00061t-Nu; Fri, 20 May 2022 14:06:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334258.558262; Fri, 20 May 2022 14:06:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Gq-00061m-L0; Fri, 20 May 2022 14:06:24 +0000 Received: by outflank-mailman (input) for mailman id 334258; Fri, 20 May 2022 14:06:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Gp-0005Rh-81 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:06:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0722967e-d846-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 16:06:22 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-atkjlmlMNlWNhtsRyPDFdA-1; Fri, 20 May 2022 16:06:15 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3792.eurprd04.prod.outlook.com (2603:10a6:803:20::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Fri, 20 May 2022 14:06:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:06:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0722967e-d846-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653055581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8kMqEf9YfAX3H29253p/70YKpwvNJYTtZtS12zg/C0=; b=AM4JggtzSJeXsNC2p138SG5zp5LLKgXPOOV34hdfi89T9Cp/FLMzlV4cLU4tUCJ+uM+6aC cofC4szvW/R6t3hYSFAkOJZrVD809dcDLQLuguxVbxkEHlTi33oTZ9cMhMfM0GmvyJ+bOq 2z/m2D18gTz/B6fzTN0etew94CQRK6I= X-MC-Unique: atkjlmlMNlWNhtsRyPDFdA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KNkXmOs/ncKIbe7ThH/QtYwCOdEi8vSM5AyaRJj70inFJByMD/R1C9zoxwbgXB1VlPw3UG3/a8Lz8NEAGZFUzwvnxbpmaWRTSGAUVAb6eySW5dXfatSrmDbpU69rkCpKF9yM64Y0IZ4OnV/jI675zxGQyAbOxQP4sDSw2V/4oFAgBId4iCLKUM5p1yvmk8UbDOERhAyhgB0n/mGhhc7moz4BZ9cP5MrPPjC1siNcJurFbVnnhePky/f5Xz5Re2JYtHvy1VxugV3obyixEPxUibRLXznPcu+9tXqKq3GKNCSJLAEFx83gEGYknB8BkrWH0OVZJ9ykpSyujkai4j4r2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nbfn2DqF++Z2hUraN3a5UmYO8l7KJ0rCWKc+6E3Y1bM=; b=DpsVCXAhEEyLKjfbzVgwHWZGbr6pdZvEu6F05QvQECP4BkTMbAcFHeLmeFtiFfUaA7HtgQSfX06rwvVd70D7+FT0VYDeTi+NcO/gtNeedjp8HfZlhQcdMX8hgkzYLrrH3AlzhIkpOSRsRyDl3FBCkZiGoCBf4PLFccbXfZYY7jCzlY707RQCnBDAJ+B/FKpdLnRxfquulTM3HtLCUe8LSoz3ESknJOFcYLdrcPInPP+TjjUt2wD2asDRD6hmGYqTV0nbjAGXTYJQegOpC1OjZeiAlts4kaLDQbyvrAvcDTaTIlnsvAHhuOZ3ryXu/yAeIUhhnIgXm+M/KZVCURKk9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> Date: Fri, 20 May 2022 16:06:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Chuck Zmudzinski CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> From: Jan Beulich In-Reply-To: <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0496.eurprd06.prod.outlook.com (2603:10a6:20b:49b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6670da7-e65c-4abf-9908-08da3a69e573 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3792:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HLnBuBIgQ8gqfwOLzhAHmRluhhMONmIZAJEi/zVeKl788/wBFD4JgPxaMj5JI7OWuYmw8jednPGeDy5Q4b1KqboeUn6OEOg7fMwEv7c0uDn4VB5ImURLBo+OBT/d91uYEqJtszzpGAW1bo6HOA4mGcX31CPBQvLIkeSULmGa+pU7YGQVE5Qa+wRodeCiZI5aChe+VoOO3BM7aMfXVaartWt4SXS+rPVhqIaA72mAjKYTxIGLJUBDs2Sz1DLv23fA4YfRQLSmPP/eqO3UHRmB4LkRzsZCQV1PTqBStOQ7CvxThV8WOQBNjj1eJHVfHXSJ1pvW0GSJPMNrrpsS+vr9bIRqbfrgDhx85S0YCyoPP9EcI/fenFTEuXxYakUy9D8Iu7pPeiEg26J1TlLnbkqEnJG1OdSe3vRSkqxglo45cYvc9IDFm3d5HezLKePsPS770ZCNRd3Ci2K3zh6OaXLQi/14U4jNgqX2OJJV1NirO6e1wxSD+Iek3I2QTCgs+4gqWtIKtqW3OlvOeQZ7Aa1O/vhZs7epu3tRCsurghaEdpNfZXh0ydP9KPPzqz8CmGU+PWWcJ9/XQLCloboXLnt1NJ3+XMaBb5SZPJrKmreshwe9n/CMOOZtc1KeZ2PGb5L0kUqgz0699Hm9m2ADkM8PEMYEircHnNNEW7TWc9e7TYy9ex21THFhPCB/BaxK5SEnFeWGU1DiRXfQg6m/wgR1xjJIFqNCGIJCW/PKu3cWHfMuRrvcQDcwWO+3cNJ9oNtx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(186003)(31686004)(2616005)(107886003)(36756003)(83380400001)(7416002)(2906002)(66946007)(53546011)(54906003)(316002)(6916009)(8936002)(38100700002)(6486002)(5660300002)(6666004)(86362001)(4326008)(8676002)(66476007)(66556008)(31696002)(508600001)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RNRJxt6348ITF1tOaCAbM7Gh7tcoJaXJjCKb1l6c1zsnfydqBhfCorkjvWze?= =?us-ascii?Q?Fapmk/EQvHMrX2Sa+PJ/W+QoP6xBvNqE1PwkqXHsjp3xce9tD5FZzCUlMaAd?= =?us-ascii?Q?S7PpNbJTIU0b/xfATcs+TSGjSl2XHbCRSafvPXpGhi+TXRIZQwE15erRIr25?= =?us-ascii?Q?B1y8TY6JUvn7CVRBNf2nAyUvrTm1hG1Y+2TFjIBIH9hVVepyajhdT7uqvsP9?= =?us-ascii?Q?Vn1qH0z5xN3GCrmeV18mbtjhWczACgLM/TpZVSNNDWVuXnS07mAwm3pXWa3G?= =?us-ascii?Q?2IxlsOoU4+O2zqiD+b6YIP3KCn/a07q9SCezYfjgLnICU83Epr/sULjQOJnD?= =?us-ascii?Q?8wYw08G2EIpJU9pQDeqFGrc4/LpNnM4xY2EX+mZfOpVq4h1p6z68e2ky1/WF?= =?us-ascii?Q?ljC6FQq0yBdenujRpOvNlYT5FQo361vVRvuVSQWo1Xo4Sec+rwwl+0uTdcXD?= =?us-ascii?Q?/avWvBMQof9DBF7WGwgw/bwyMgR41q04ZpO1EsHVWVykAm9YWBkY5sqR+yRZ?= =?us-ascii?Q?aBySkbHfE17MZS7DWx/HqSZ8MNnUT5JtPWuYRVU2/+QdEsHBHvTfYiV3QCdV?= =?us-ascii?Q?lkpviMuGVRrwjlse7mUFFI2gP5YffhmVMxHZEjVcqOZReDyb/vdntRI+eWUW?= =?us-ascii?Q?NasZKZAfyuc5VYlEVriu73I2x8MsmONvoSEhiuUCk5CuDfosiNFKshGd9yxI?= =?us-ascii?Q?KIMoAtV+PAaWIqKX0VO0AqpMlHeN9AB3c0v4CwvCTDqr2Ebap6MzTC6kln5g?= =?us-ascii?Q?Avh4HpipNNn3kyZg5l2ULsxeYYcTZCMY4MY83AjMRdOrTLF4kzm72iMx0EUw?= =?us-ascii?Q?8KBqKNfx/VtYZFyb8LpyD2LsW30eF00OhHd89bE6UXHVAa5EK/TDDexl/eC7?= =?us-ascii?Q?9ES0VJ4gCQ6JWqJuHZ/t08yzsxKl4EW5D51M8DKdkeu7KDwVbRwZv6rruf90?= =?us-ascii?Q?zsrx3mK0sObMgQXDpvCiNNoXK399sXpzaxGt3/x1Dql6oSkASTRYC2atzKic?= =?us-ascii?Q?C2zgNYvQEFtNf6NTeitF4MAzXDeR94NSk4WagAt5HfTAc6ocVQCrqPvF8q4T?= =?us-ascii?Q?nTB6jQ8fPT3194lRr1l7IPHAEBW9Q5cTf5A7QwgLY/re0YpHB0cgLDw95adR?= =?us-ascii?Q?SuExHuoK7gj/FACDRteoESS7qj0RtAELg/tLQHIkA6dcW3A2IQ1xrOTBd0A+?= =?us-ascii?Q?L5QpkNfQLkYgWrUjpplaXoirYUZ1+a2RaFEFqjsGnZp3NhrJ3Tsg28wzYo6/?= =?us-ascii?Q?eEs1bOJYwGP4f5Z78dSrm29FwUe/KQK1exj10gEPdak2QdwaeFbcXQdF8jOa?= =?us-ascii?Q?+GCO2qM0khkmOp/xgV+niy3xkSjGOTfc+4AZXaXIN9SaNMt5ZIE3bzpznZy1?= =?us-ascii?Q?7C+G7/lOU/G03pbgmqj1zndkRA44XLPPpKSxsRKhZDZKq8+wdeEba+qXHkVO?= =?us-ascii?Q?y9dolyCUXz1dqOTuv6RCTSZ/Otj8zz78sX7BtNv1TlbxYNDObzh8NdtbLe/4?= =?us-ascii?Q?dmg6IvLn+OFIMfLM8b5dVZjYoRyWPeEmtoa7rUhufpYj/Z5e7bpg/M0BUtcT?= =?us-ascii?Q?QoV2Ii64RJDmb8WmdbnIQNlco3l3e2c83YAQMq6UhtVS9o44EiILmDg8DWzC?= =?us-ascii?Q?tR9Za/fqKzEMfIFkUffMAr3Zt9BhiMMYtiKjIpDAdjYEw3y9bJlOdqODvXp1?= =?us-ascii?Q?e96f+/NHNjclTp1aNkgrUcCispKUctYZe/ckuuuMrGa0LD9XST07YhEMo4wl?= =?us-ascii?Q?l4k5Tw7qgg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6670da7-e65c-4abf-9908-08da3a69e573 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:06:12.3131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mt/j61/+hYBLfFT+OYetP5T8RV6/4g09AkioVUQwEFYqr36qVB1vI6Lx3kMCv/f7jVp+R1l7FOjNgEprXhqLVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3792 On 20.05.2022 15:33, Chuck Zmudzinski wrote: > On 5/20/2022 5:41 AM, Jan Beulich wrote: >> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>> >>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>> those want >>>>>>>> leaving unaltered. When preparing my earlier patch I did inspect t= hem >>>>>>>> and came to the conclusion that these all would also better >>>>>>>> observe the >>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() as t= he >>>>>>>> only predicate). In fact, as said in the description of my earlier >>>>>>>> patch, in >>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>>>>> the >>>>>>>> problematic one, which you leave alone. >>>>>>> Oh, I missed that one, sorry. >>>>>> That is why your patch would not fix my Haswell unless >>>>>> it also touches i915_gem_object_pin_map() in >>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>> >>>>>>> I wanted to be rather defensive in my changes, but I agree at least >>>>>>> the >>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>> I think your approach needs to be more aggressive so it will fix >>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>> such as the one in i915_gem_object_pin_map(). >>>>>> >>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>> really don't have a strong opinion on that question, but I >>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>> to a hypervisor option, should only affect the kernel, and >>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>> should not override that, >>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>> an override would affect only the single domain where the >>>>> kernel runs; other domains could take their own decisions. >>>>> >>>>> Also, for the sake of completeness: "nopat" used when running on >>>>> bare metal has the same bad effect on system boot, so there >>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>> that's orthogonal, and I expect the maintainers may not even care >>>>> (but tell us "don't do that then"). >>> Actually I just did a test with the last official Debian kernel >>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>> applied. In fact, the nopat option does *not* break the i915 driver >>> in 5.16. That is, with the nopat option, the i915 driver loads >>> normally on both the bare metal and on the Xen hypervisor. >>> That means your presumption (and the presumption of >>> the author of bdd8b6c98239) that the "nopat" option was >>> being observed by the i915 driver is incorrect. Setting "nopat" >>> had no effect on my system with Linux 5.16. So after doing these >>> tests, I am against the aggressive approach of breaking the i915 >>> driver with the "nopat" option because prior to bdd8b6c98239, >>> nopat did not break the i915 driver. Why break it now? >> Because that's, in my understanding, is the purpose of "nopat" >> (not breaking the driver of course - that's a driver bug -, but >> having an effect on the driver). >=20 > I wouldn't call it a driver bug, but an incorrect configuration of the > kernel by the user.=C2=A0 I presume X86_FEATURE_PAT is required by the > i915 driver The driver ought to work fine without PAT (and hence without being able to make WC mappings). It would use UC instead and be slow, but it ought to work. > and therefore the driver should refuse to disable > it if the user requests to disable it and instead warn the user that > the driver did not disable the feature, contrary to what the user > requested with the nopat option. >=20 > In any case, my test did not verify that when nopat is set in Linux 5.16, > the thread takes the same code path as when nopat is not set, > so I am not totally sure that the reason nopat does not break the > i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) > returns true even when nopat is set. I could test it with a custom > log message in 5.16 if that is necessary. >=20 > Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) > to return true in 5.16 when the user requests nopat? No, I'm not saying that. It was wrong for this construct to be used in the driver, which was fixed for 5.17 (and which had caused the regression I did observe, leading to the patch as a hopefully least bad option). > I think that is > just permitting a bad configuration to break the driver that a > well-written operating system should not allow. The i915 driver > was, in my opinion, correctly ignoring the nopat option in 5.16 > because that option is not compatible with the hardware the > i915 driver is trying to initialize and setup at boot time. At least > that is my understanding now, but I will need to test it on 5.16 > to be sure I understand it correctly. >=20 > Also, AFAICT, your patch would break the driver when the nopat > option is set and only fix the regression introduced by bdd8b6c98239 > when nopat is not set on my box, so your patch would > introduce a regression relative to Linux 5.16 and earlier for the > case when nopat is set on my box. I think your point would > be that it is not a regression if it is an incorrect user configuration. Again no - my view is that there's a separate, pre-existing issue in the driver which was uncovered by the change. This may be a perceived regression, but is imo different from a real one. Jan > I respond by saying a well-written driver should refuse to honor > the incorrect configuration requested by the user and instead > warn the user that it did not honor the incorrect kernel option. >=20 > I am only presuming what your patch would do on my box based > on what I learned about this problem from my debugging. I can > also test your patch on my box to verify that my understanding of > it is correct. >=20 > I also have not yet verified Juergen's patch will not fix it, but > I am almost certain it will not unless it is expanded so it also > touches i915_gem_object_pin_map() with the fix. I plan to test > his patch, but expanded so it touches that function also. >=20 > I also plan to test your patch with and without nopat and report the > results in the thread where you posted your patch. Hopefully > by tomorrow I will have the results. >=20 > Chuck >=20 From xen-devel-bounces@lists.xenproject.org Fri May 20 14:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334266.558274 (Exim 4.92) (envelope-from ) id 1ns3L0-0007UG-8j; Fri, 20 May 2022 14:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334266.558274; Fri, 20 May 2022 14:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3L0-0007U9-5j; Fri, 20 May 2022 14:10:42 +0000 Received: by outflank-mailman (input) for mailman id 334266; Fri, 20 May 2022 14:10:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3Ky-0007U1-BW for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:10:40 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 967f60bb-d846-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:10:25 +0200 (CEST) Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 10:10:35 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DM6PR03MB3801.namprd03.prod.outlook.com (2603:10b6:5:52::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 14:10:32 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::6d0d:b9fa:6b59:36d4]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::6d0d:b9fa:6b59:36d4%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 967f60bb-d846-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653055839; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uUQXC3Fq79Y/LyBYuv63z+vROOqFqA4Hte1H/F2uajI=; b=JtmkLWajm1o84FwBG8w2FIeNRlQ0N9gCW90jwc6o/HUir89dbeHiNQAh IFlTyzn52zUH5gcEoErNGkAtwa+Stp9a87kgODiVPSd7ZG25iFlUHAkV0 ApICZ0+BEiNuMeQhUEalL+Uw1X+I6NMQ5SSTI14mBy3jiVBeQEOUB73FO 8=; X-IronPort-RemoteIP: 104.47.55.101 X-IronPort-MID: 72193311 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dWr6u61MpLzYoZ27J/bD5aBwkn2cJEfYwER7XKvMYLTBsI5bp2BSz WEXCGmDPK6MamH9f4p2ady0pksHv5CExoNqHAU5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1znIS+aFw4L5HRv/sDcT5yP3BTMINJreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfySvLe03x9p7ixKNd/Ya 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9wjM9PFsujG7IApZ7aPiLvT5IcSxRe51uxq6g 0iaon3JK0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe9DW8ymIw6vQpgOGXG4NS2cZbMR87ZdvAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG wy3kRU= IronPort-HdrOrdr: A9a23:+dWFwqNsFwdP7sBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="72193311" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJ/uB8ljyp3D1n10AG7tbe1klL9jtFYud07m/6gWVJUzWFy4q2t58/wqGZqx5rkzfsjAN/D6+F3HWwETox+AVNfw2uSobDqyXGDN3fwH48u5m9B+5vwJXN8aWmBHR4b20ciU0UaxawFCU18vR7XBwPb1sP/eqXh6ODWMOqXOYK/rS+mJRksY51L7vx0IL4o/NYot33yTbOoYZMVGi0YyakzUz49BR1fNqFj5DJC3FL/imk6RkToZyA5EvZRdmhxu2R83D62yoBYS2M43mAiNBFMU5d1fJU9ndEa3CXY+RLOx5a0ythxEXou96VqtWVO6w07iR45JRxJcxMdD1THW3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uUQXC3Fq79Y/LyBYuv63z+vROOqFqA4Hte1H/F2uajI=; b=Pd1buDryNoifgeYoaqqZmF4qjILUnrawtfEbFcdz4yIl1ErZEGfOFHzm4PLhpmjHM5IC/tPbxZ8wU54mlz0Ps7xh8hoU/G+/TISlKqkRkghVlubS1CFEuhXV5DcIGFI3DiFO1L61PRm4Q2n5gu5OziKN604K11aw+sSdl+nmkGbUK02B7mOlNe7u11RgwU3WZZx47hyDVdTLmYexvo0wVN6uQyP7ayNSEq4Bux5WIOQHll+ZtCuylJal91OkXkZcs6MbqhjWVPFWzpQRfBH27JYWYPWR4ISocvBDar/cjZO49ONfGZHoBZjQAWgtCBaG+VNT9E/+z7raV98JalNlrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uUQXC3Fq79Y/LyBYuv63z+vROOqFqA4Hte1H/F2uajI=; b=b3GsLRX1A/qvvTdU5Cpm93sr9TYHItOhHKYLtMY1KUTCDaa2M2gYbTq5qxvG8rPPF7qZJcjyzexoF9u+2yeUeim4nrnc/DuChYUJTyYB4G87gLSZUo05OuF26Dl6D4pdivdYJigHrYigShh/pDJJZNoqFafvmT9PBEr9G1hXBt4= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Thread-Topic: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Thread-Index: AQHYbE7auBjYBybQdEGztrNyxSKPiK0nzhyA Date: Fri, 20 May 2022 14:10:31 +0000 Message-ID: <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> In-Reply-To: <20220520133746.66142-4-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a24331df-ace5-4738-1194-08da3a6a800c x-ms-traffictypediagnostic: DM6PR03MB3801:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oBJ7kVFEro/HtDTxXsG6aeaM9hDpYj3whW1kB2oMABN4WujerNKLuZlv0IMtyWmg+jMHV2LTE3QYlVBkXeLNDLrqPWFtL/v8ncI0P/3BI0OzIDX5FzR4pzXzNxG9zGTOlxix1Zwukp8ro1w0slnThqswobv/OuMG0fHOoJbySpVjiY5avrBG+DUA7x12wGM9rAZ88lLupbkmcolA+sXr31FKNWnGuNuFgpmmiixrCU4bS5qSsQqAw+lkB4otL9g+Q7kBEBRB0X2ejNFgUBdzHhUdrR+HHkKzukAMARLXRw0sYv+F2kE1WqjHMVWUz9QXunAlMDMIdFF1ax8QWaCEsZf4nHmJKDN5XqqIF+gbEZKriYClpEw+2lgr6JOOB/Ji0p4okLw+gKgkwznmSwz9usX5E2+Z0TnT6bRz3kyGqdSfioFXyaN5iDelZRed9nMSHgg2Ntg4eV1U2ieMVLZ9Zc5abmArn3ceO2iu8eVgx426EuHOUt5svDA/u3nQc4CbHYSeELu18x6oCs91i8hAuyD584B2fsVWph+L9NCOi0orDi9by/L6RiMMmHIxDsHIjBD7T4BcNpAW5Vo/XltXtNXOuppkqxGxToHB6p2mBzgfONtcplY2dKR85JTdwH0HBohGTX+k9et/qdz3c9UjJdt9wPhmfp82QAhVFnyq5P15VzbGW1Gm8VYEeBJWz0m17dWBJBuFL/NycN4f21SO0ZDPXnlkpWUh07J6Si4v1YcOouxvU8bzz92BIEUKKyvlCTt9FdotLl4dHdz2WkFzcw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(86362001)(66946007)(26005)(2906002)(31686004)(6486002)(76116006)(64756008)(66446008)(5660300002)(8676002)(66476007)(4326008)(71200400001)(91956017)(31696002)(316002)(36756003)(6512007)(53546011)(38070700005)(38100700002)(2616005)(110136005)(6506007)(122000001)(54906003)(82960400001)(186003)(508600001)(8936002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?em43MWlSUG1mRUhSa3lrYk45MHhrbHp2aFBxWm8zd0lkVW9qRGdSOVFWNm5U?= =?utf-8?B?T2ZubENMTUgrWnUzV3pDQllQYVdlQ0N6WEl6WSs5Nmp6cXBSaEcrVzltb200?= =?utf-8?B?UHA3U3lQYVozVG51YUV6YXA1R20rc0VIT3Y3NnUxQ3RBMmZlcTM4a2xHWUFT?= =?utf-8?B?dXVsbC9Qa2lnbFBSeGtlM3gva2dldkNQa0I3QVI0MUtwalVnMUVtbDB5Q0ln?= =?utf-8?B?a3lnUGlJaE01aGttd0pYU2FMdTZKMkJiaHp0dkJwOEtJZlRxOEVMSTdmeWtH?= =?utf-8?B?UjJkak5DM25kdGdndS9DaUhUMU00dGh6UDJCNHlmMjYxK1MyZ050UXMvNGxJ?= =?utf-8?B?ZjdDRjVha0dBSFFLSUNZUDJPeGxZK1oxNzJJK1A1TTZONVhsZkk2YjdoZWNV?= =?utf-8?B?L1VCcVVGakZZRUFNTjF1K0d2cU5DT3VGYW1RL3A1Q0JyYnJzT0dISC9ld01v?= =?utf-8?B?QjdsbzZlUHZld2lmeTFsbWZzYnVZeUxRZ0cvQmd1bEJodnBKUEZ2U1JsUnl0?= =?utf-8?B?eThteVZuMVlXTkgvT0wyY0t4QnhCR21sSm54WjNkNXE4M3ZBL1FqMTdFdlZa?= =?utf-8?B?KzhUWW5tYWNqNnFQOThDVnpJWTRGYjYxU28xa0VKejVIbEZYYjdMdTZKL0VR?= =?utf-8?B?MkdJMWVRWS9rUm9TVkFnTFJ0TnBsSlo3RjJvSFY4dkdwT2NFNjFWTDYvbzhm?= =?utf-8?B?a2dENUd3SGdONmlWNGZpdERvN3FnUGtBTVpMQk9henBPM1M2d0NIMmttcWlS?= =?utf-8?B?bjVwRVZqYm45OHFxMnVjTm9lTHFITEFNY2thdDM2eGVOS3dzSnFRUlRrZ1d4?= =?utf-8?B?L3ptdTZudGlzb05GOG03VnJOVEFGUUZZTmIzOSsxR1kwREFjbUJZNG5Ld1pr?= =?utf-8?B?aXlVNVZ4cHdlK3UvWEFqUDVKenBzbFFpUjNHbVJkNTIvaTAxTzdsUWQrOHJE?= =?utf-8?B?MlJMMUtxbnYxWmtTYmJjN1RVQXdwT1JhUnFuMGFXdGUrNlRxL3ZYZTRpTkNq?= =?utf-8?B?Sll6NUQwWDdVMExXcUw2TUd3NTR0WklBVkFXa1VybStNM1RZNklFaDh5cWtk?= =?utf-8?B?eVJGTnF1dUwwamJGY0laWjd1Q2xtUkdTVkpDemFrUWNjUVFnZ1RzSG9nUXZM?= =?utf-8?B?Sm1NMThDalZ2SW1mRm44aW1HL3dHbnhjcyswN1N3d0JUWC90Q21XSFVueTJa?= =?utf-8?B?YzhlK3VwWFNnN3d4Mlk4ZUErSWRrTEVtYmU5bmMrc0VpRHNTMVBSRTBhWE1v?= =?utf-8?B?TWQrd29vNThvUnd6K1BLWXdGTmMxUkdYZ2l5TGtZWW1UZWhXVFYxMEtDSWJq?= =?utf-8?B?OEtrdlV4ak5iWnBjYVI3QkpJWStWLzRxRUNEdVpuSXN2eEV5NGFQZWM4Kzln?= =?utf-8?B?VE9Sc1NhenlLRkFQNFF6eGVoSlpZbGw4S3QxYkpoNFJQb2RXNm9pR0xHMVZP?= =?utf-8?B?K0djVjZaVzU2T2huYy9CajliTHVqbmpKTkdvck10RStQaUZZZGlxMkpqYTdw?= =?utf-8?B?Z2d1K1dpUUwyWFA4ZnFhZ3ZIczdqekc3dmZ5R3Z4VTN1VmY1cHFzb0Ircmph?= =?utf-8?B?OUVub1NkVW03MW9SNVMzN09wamwzUDBIQVErcW9nWkswaUtldGxwK1MvOWlB?= =?utf-8?B?b1FGU01rMytnWWtMaGF2T2MwNzNLMDNJb0grdHdHSjZ2SjUzbHl5OE93UU43?= =?utf-8?B?SnZQaDBFaGpTOWt6WGcwSWxxVXNZWC9LWWxQMnp0MEozdTBvNXl4a3RHQ09B?= =?utf-8?B?SGNSak95YTV4VEVQTjhFNk52akI2a0tLNVhxbEU3UGZjbFQwa0lQbkE4K1lU?= =?utf-8?B?Si9FQm9sZVdza3AxdktBZnBpdU5KR1lzTnpKV2JwcTBXVmRPRUZ3eWpNNTZi?= =?utf-8?B?eTE0U3NiL09yekdCdGl1ZnFNWERWVTZndWxQNVpweXFPQllpSzJoYU12U1l6?= =?utf-8?B?eGFRdUwzNnJQU2YxSU9DNUdIY2k1VFlTZ1M5UUxsYmtqdFpkQi91WDNDL1ZZ?= =?utf-8?B?N1RwandDc0VINUttWk16VHVvUUlOWHBiRU0vZ3FFSnpsRlJpN0JqUFVEbDFC?= =?utf-8?B?VnFTTUR3SDk0cEh2TnJmQWdXU1VDcjE0cjVFLzBDRXVVcmtTb05DdW1TV2dF?= =?utf-8?B?aHFRM092RWh5TWplTDNxaXJtWlIvdE9TRjd2QmtzQzFuNXRXV0l0ak82ZVhT?= =?utf-8?B?eXU1a2I2c1IxWTBiT3BWcmxnL1RPdEZVdjk2WjNEd2UwQkUxVDNueUp6Rk91?= =?utf-8?B?empCL09VcndMZjV2U1E3bzZxUWtTOUhwNnBUa1c1K09aS1JLNkFMeUJ6QldB?= =?utf-8?B?SkwySEpWc2NGczBLM3lxVm40ZGtFOTFOM1RET000SjFxd2ZReVpJZkNhVEw5?= =?utf-8?Q?9qd65LMHZ5hxpWFE=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a24331df-ace5-4738-1194-08da3a6a800c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 14:10:31.5096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ACZRNuDht/5myb7s31YKhrI5EIcyLQGwRCqYwAMNgLYl24kVsKtk6KIuUsbFkSMh2uGWVN3Ddhu2ZwFpq+3K5NVY1Wyn+rBN5DRNCmTzkxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3801 T24gMjAvMDUvMjAyMiAxNDozNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBBbGxvdyBleHBv c2luZyB0aGUgUERDTSBiaXQgaW4gQ1BVSUQgZm9yIEhWTSBndWVzdHMgaWYgcHJlc2VudCBvbiB0 aGUNCj4gcGxhdGZvcm0sIHdoaWNoIGluIHR1cm4gYWxsb3dzIGV4cG9zaW5nIFBFUkZfQ0FQQUJJ TElUSUVTLiAgTGltaXQgdGhlDQo+IGluZm9ybWF0aW9uIGV4cG9zZWQgaW4gUEVSRl9DQVBBQklM SVRJRVMgdG8gdGhlIExCUiBmb3JtYXQgb25seS4NCj4NCj4gVGhpcyBpcyBoZWxwZnVsIGFzIGhh cmR3YXJlIHdpdGhvdXQgbW9kZWwtc3BlY2lmaWMgTEJScyBzZXQgZm9ybWF0IHRvDQo+IDB4M2Yg aW4gb3JkZXIgdG8gbm90aWZ5IHRoZSBmZWF0dXJlIGlzIG5vdCBwcmVzZW50Lg0KPg0KPiBTaWdu ZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0t DQo+IFNlZWluZyBhcyB3ZSBoYXZlIG5ldmVyIGV4cG9zZWQgUERDTSBpbiBDUFVJRCBJIHdvbmRl ciB3aGV0aGVyIHRoZXJlJ3MNCj4gc29tZXRoaW5nIHRoYXQgSSdtIG1pc3NpbmcgdGhhdCBtYWtl cyBleHBvc2luZyBQRVJGX0NBUEFCSUxJVElFUyBMQlINCj4gZm9ybWF0IG5vdCBhcyB0cml2aWFs IGFzIGl0IGxvb2tzLg0KPiAtLS0NCj4gIHhlbi9hcmNoL3g4Ni9tc3IuYyAgICAgICAgICAgICAg ICAgICAgICAgICAgfCA5ICsrKysrKysrKw0KPiAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2 L2NwdWZlYXR1cmVzZXQuaCB8IDIgKy0NCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L21zci5j IGIveGVuL2FyY2gveDg2L21zci5jDQo+IGluZGV4IDAxYTE1ODU3YjcuLjQyM2E3OTVkMWQgMTAw NjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tc3IuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvbXNy LmMNCj4gQEAgLTMxNiw2ICszMTYsMTUgQEAgaW50IGd1ZXN0X3JkbXNyKHN0cnVjdCB2Y3B1ICp2 LCB1aW50MzJfdCBtc3IsIHVpbnQ2NF90ICp2YWwpDQo+ICAgICAgICAgICp2YWwgPSAwOw0KPiAg ICAgICAgICBicmVhazsNCj4gIA0KPiArICAgIGNhc2UgTVNSX0lBMzJfUEVSRl9DQVBBQklMSVRJ RVM6DQo+ICsgICAgICAgIGlmICggIWNwLT5iYXNpYy5wZGNtICkNCj4gKyAgICAgICAgICAgIGdv dG8gZ3BfZmF1bHQ7DQo+ICsNCj4gKyAgICAgICAgLyogT25seSByZXBvcnQgTEJSIGZvcm1hdC4g Ki8NCj4gKyAgICAgICAgcmRtc3JsKE1TUl9JQTMyX1BFUkZfQ0FQQUJJTElUSUVTLCAqdmFsKTsN Cj4gKyAgICAgICAgKnZhbCAmPSBNU1JfSUEzMl9QRVJGX0NBUF9MQlJfRk9STUFUOw0KDQpVcmdo LsKgIFdlIHNob3VsZCBoYXZlIHRoaXMgaW5mbyBjYWNoZWQgZnJvbSBib290LsKgIEV4Y2VwdCBj YWNoaW5nIG9uDQpib290IGlzIGJyb2tlbiBvbiBoeWJyaWQgY3B1cy7CoCBUaGUgUCBhbmQgRSBj b3JlcyBvZiBhbiBBbGRlckxha2UgcmVwb3J0DQphIGRpZmZlcmVudCBmb3JtYXQgaWlyYyAodGhl eSBkaWZmZXIgYmV0d2VlbiBsaW5lYXIsIGFuZCBlZmZlY3RpdmUgYWRkcikuDQoNCkdpdmVuIHRo ZSBvdGhlciBwYWluIHBvaW50cyB3aXRoIGh5YnJpZCBjcHVzLCBJIHRoaW5rIHdlIGNhbiBpZ25v cmUgaXQNCmluIHRoZSBzaG9ydCB0ZXJtLg0KDQo+ICsgICAgICAgIGJyZWFrOw0KPiArDQo+ICAg ICAgY2FzZSBNU1JfWDJBUElDX0ZJUlNUIC4uLiBNU1JfWDJBUElDX0xBU1Q6DQo+ICAgICAgICAg IGlmICggIWlzX2h2bV9kb21haW4oZCkgfHwgdiAhPSBjdXJyICkNCj4gICAgICAgICAgICAgIGdv dG8gZ3BfZmF1bHQ7DQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYv Y3B1ZmVhdHVyZXNldC5oIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVz ZXQuaA0KPiBpbmRleCBjZDY0MDlmOWYzLi41ZmRhZWM0M2M1IDEwMDY0NA0KPiAtLS0gYS94ZW4v aW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oDQo+ICsrKyBiL3hlbi9pbmNs dWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgNCj4gQEAgLTEzNSw3ICsxMzUsNyBA QCBYRU5fQ1BVRkVBVFVSRShTU1NFMywgICAgICAgICAxKjMyKyA5KSAvKkEgIFN1cHBsZW1lbnRh bCBTdHJlYW1pbmcgU0lNRCBFeHRlbnNpbw0KPiAgWEVOX0NQVUZFQVRVUkUoRk1BLCAgICAgICAg ICAgMSozMisxMikgLypBICBGdXNlZCBNdWx0aXBseSBBZGQgKi8NCj4gIFhFTl9DUFVGRUFUVVJF KENYMTYsICAgICAgICAgIDEqMzIrMTMpIC8qQSAgQ01QWENIRzE2QiAqLw0KPiAgWEVOX0NQVUZF QVRVUkUoWFRQUiwgICAgICAgICAgMSozMisxNCkgLyogICBTZW5kIFRhc2sgUHJpb3JpdHkgTWVz c2FnZXMgKi8NCj4gLVhFTl9DUFVGRUFUVVJFKFBEQ00sICAgICAgICAgIDEqMzIrMTUpIC8qICAg UGVyZi9EZWJ1ZyBDYXBhYmlsaXR5IE1TUiAqLw0KPiArWEVOX0NQVUZFQVRVUkUoUERDTSwgICAg ICAgICAgMSozMisxNSkgLypTICBQZXJmL0RlYnVnIENhcGFiaWxpdHkgTVNSICovDQoNClRoaXMg aXMgdGhlIGJpdCB3aGljaCByZXF1aXJlcyBtb3JlIHRvb2xzdGFjayBsb2dpYyB0byBzYWZlbHkg ZW5hYmxlLsKgDQpVc2luZyAncycgZm9yIG9mZi1ieS1kZWZhdWx0IGlzIGZpbmUgaWYgd2Ugd2Fu dCB0byBnZXQgdGhlIHNlcmllcyBpbiBub3cuDQoNCkJ1dCBiZWZvcmUgd2UgZXhwb3NlIHRoZSBN U1IgZ2VuZXJhbGx5LCB3ZSBuZWVkIHRvOg0KDQoxKSBQdXQgdGhlIGNvbmZpZ3VyYXRpb24gaW4g bXNyX3BvbGljeSBzbyB0aGUgdG9vbHN0YWNrIGNhbiByZWFzb24gYWJvdXQgaXQNCjIpIFJlamVj dCBtaWdyYXRpb24gYXR0ZW1wdHMgdG8gZGVzdGluYXRpb25zIHdoZXJlIHRoZSBMQlIgZm9ybWF0 IGNoYW5nZXMNCjMpIEFjdHVhbGx5IHB1dCB0aGUgbEJSIHJlZ2lzdGVycyBpbiB0aGUgbWlncmF0 aW9uIHN0cmVhbQ0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri May 20 14:13:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334275.558285 (Exim 4.92) (envelope-from ) id 1ns3NT-00089n-QD; Fri, 20 May 2022 14:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334275.558285; Fri, 20 May 2022 14:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3NT-00089g-NH; Fri, 20 May 2022 14:13:15 +0000 Received: by outflank-mailman (input) for mailman id 334275; Fri, 20 May 2022 14:13:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3NS-00089Y-T5 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:13:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f34d52f0-d846-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:12:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f34d52f0-d846-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653055993; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oBNRIut3D0N2Tk9UPM11O0ntkDoGKca/eaaKq37A9lQ=; b=Mhks0musTcaAuN/YDuwbMRkBhrLCuEnP94OFIOyryq4lmddjzasyGd4m p1s/X3hePK4TNCNcBBafcTChNJw+2nViZpP4shuBoupB+t5meNOR+WW5U G4YEILL9foDcI6s8/Qotu9f5qJqr6lQYoWjrWLkYAzHGI6Pu2DTSRmfHl g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71801745 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GrEaFav2lQoccW1FqbkKOCa7QefnVA1eMUV32f8akzHdYApBsoF/q tZmKT3TPv2CNjemftl0a9yz804OvJOBm9RmSVNsqXgyHytA+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X4 YuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8lMpWcx94MUiVlAmJEeoF99eKEEFag5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWU2PEyZPEESUrsRILUckN6u1ybBSG1BrlPF4po632381TUkhdABN/KKI4fXFK25hH2wu Wbu72n/RBYAO7S32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO2ofS8yV6zXfpad lRS8S0rxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imBxpKEvDyIB1Q5X317L/AduZJ1dBI1g wrhc8zSOdB/jFGEYSvDq+zM9GvsZXd9wXwqPnFdE1ZcizX3iMRq10+UEI4+eEKgpoetcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJGT9bxgbQjxawcRLt1t3HY1 JT+p+CQ7foVEbaGnzGXTeMGEdmBvqjYam2N0Q4xRsJ/rVxBHkJPmqgJv1lDyLpBaJ5YKVcFn meO0e+u2HOjFCTzNvImC25AI88r0bLhBbzYugP8N7JzjmxKXFbfpklGPBfIt0i0yRREufxva P+zLJf3ZV5HWPsP8dZDb7pEuVPd7ntlnj27qFGS50nP7Idyk1bOEudZYAXUP79lhE5GyS2Mm +ti2wKx4003eIXDjuP/q+b/8XhiwaAHOK3L IronPort-HdrOrdr: A9a23:1sbquaqp6qOC4Tgnt/6jPlsaV5oreYIsimQD101hICG8cqSj+f xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U 4JSdkZNDSaNzlHZKjBjzWFLw== X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71801745" Date: Fri, 20 May 2022 15:12:46 +0100 From: Anthony PERARD To: Elliott Mitchell CC: , Wei Liu Subject: Re: [PATCH v2 3/3] tools/xl: Allow specifying JSON for domain configuration file format Message-ID: References: <9aa6160b2664a52ff778fad67c366d67d3a0f8ab.1651285313.git.ehem+xen@m5p.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9aa6160b2664a52ff778fad67c366d67d3a0f8ab.1651285313.git.ehem+xen@m5p.com> On Tue, Apr 19, 2022 at 06:23:41PM -0700, Elliott Mitchell wrote: > JSON is currently used when saving domains to mass storage. Being able > to use JSON as the normal input to `xl create` has potential to be > valuable. Add the functionality. > > Move the memset() earlier so to allow use of the structure sooner. > > Signed-off-by: Elliott Mitchell So, I gave this a try and creating a guest from a json config, and that fails very early with "Unknown guest type". Have you actually tried to create a guest from config file written in json? Also, this would need documentation about the new option, about the format. The man page need to be edited. An example of a config file written in json would be nice as well. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 20 14:17:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334307.558308 (Exim 4.92) (envelope-from ) id 1ns3RS-0000ag-KB; Fri, 20 May 2022 14:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334307.558308; Fri, 20 May 2022 14:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3RS-0000aV-F6; Fri, 20 May 2022 14:17:22 +0000 Received: by outflank-mailman (input) for mailman id 334307; Fri, 20 May 2022 14:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3RQ-0000aP-W8 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:17:21 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060e.outbound.protection.outlook.com [2a01:111:f400:fe1f::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 864d0e9c-d847-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:17:05 +0200 (CEST) Received: from AS9PR06CA0353.eurprd06.prod.outlook.com (2603:10a6:20b:466::30) by PA4PR08MB6240.eurprd08.prod.outlook.com (2603:10a6:102:ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Fri, 20 May 2022 14:17:17 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::a4) by AS9PR06CA0353.outlook.office365.com (2603:10a6:20b:466::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 14:17:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 14:17:17 +0000 Received: ("Tessian outbound 42cead292588:v119"); Fri, 20 May 2022 14:17:16 +0000 Received: from b9ed847913a5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8A33E36C-E356-4548-86CB-72875E45F3E4.1; Fri, 20 May 2022 14:17:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9ed847913a5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 20 May 2022 14:17:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3647.eurprd08.prod.outlook.com (2603:10a6:803:85::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 20 May 2022 14:17:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:17:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 864d0e9c-d847-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ML/lOGgPyoLM4pw9dMgDg1IuUOQ+JmfG5CMb7z7FZfPJIa8Kwmv7/E4ROfr2BqY+0PJ/JwCIetPEeW93CUVv7FNTAI9cJwu9k5BoCzIPKNSws4YzVCZAf3pGexTLnio2K/aVQP/i1/YOtyRqi8GYbgDDP7iZxFGbYnDZJXRYxB1v3oZeUbrtab+jJFfE7zx7r5+07+NVe/wGuYcthrkLjTUqjVKkfnDH/jijm9DTWwWzRt+bnpV3rJgDl2evCCdSuU8FiNb6n6VD0QPnpfddfUeoR4Y6AuWIj+oWBN560lGSPtDSrDg+AXP1/HAfe/aoktAIqztbzfDamZ+1tV0w+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JL/h8O39hNxLgzq2BYm/aokZ2NmRdG+eHs8Z8CChyDA=; b=OE76wAqDzRtdPutYfi7n2wpvI0v5xcDwhMyT152YvS7wqQbpWIDnrduhwJU8TNkGxsynesvEKp5eQuN5GYS4C3dVGz9JgaxO7euO1lyQmPRl8qn/nZu/HfCb2ZCLAeQ5Evsifv+Y0vdYmw67SqjPnMsk2Hw3eg0YDFzbBCC8PB+WkgIougaHArVYCMPqnEmO+1VS8Kd6ZEm9gcGbv1pzAls2TatVDt3UU1ylzIfcudTgTGzFgpjDIg2XNV1DVvEvDqcdsmPAg2/7hH1i3ATJkPrIAgzznJmxfPOX3JKNwBQcmFirG9tk93AjHk1bFT+3crjOTLJblfaD76lLjFU3CQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JL/h8O39hNxLgzq2BYm/aokZ2NmRdG+eHs8Z8CChyDA=; b=kL/cEz4rBtBqe5gBScBgXLrdSOUtaKjjYfalth+5pUpHzxu8UD4OA0o1rl5k6Hsmvv0N/7bwrGlgklbIL9/6In4AjHJvZPW5m+gDHrua996wDGiJrMmSD2/2IJ7CZ91fWjMjEk3tCdD+DGadxT9AGB83H1+vXigNWMLc6oRYE2I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cff07ed8d44880ad X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=anrQmUYaAHDAWmuoiI1FWc9mFku7JOs2EPQr6736v/LhZcFHZMKPJcAfzB4/AhJywq79etNAhpEp3dBhsiUn/WplvxbEp26L3bXcREnA0TWOOctpBeyYb4dR3hSevG4hqsl6V/y4Ggk6lIm/z/7YnNxtV6vCshdoCdbtRL/JJktu5+YBQx1Mxib/TqNlUE1BSk5qtzXCzCHf3e+9NxtddonJ+K7gAl7obToQvLvpYqqQ8BvNO4unL+DUbVbhONdcTNirqLUQCoDLmjL+Jy4cXE1i3Im4A/IWqTtqA3+xqmZEvBA3jfVzXNmFYc43Q17AI5LO+CYB3lPjYs3UcvVvMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JL/h8O39hNxLgzq2BYm/aokZ2NmRdG+eHs8Z8CChyDA=; b=NG2f5ufFLRJyKITiH/0aTuFKrLiTESCvKDoR8vZBTEbE/9OKOWLu3vSdnoWW9tlSMO6+vN1NMetULUhZHJUcrkrDfp0oSn1la9XuoPaBX9YbLCntyJP0Ab97CKEx95W6y+QpoLaxtShpvy3lEG5IpCn4U6L6IbZB0fG3cU7KRAuWi0T9yMdp9BnTIDT8OahVre0KznI2AFfu0HU5UBHqX6JIkIM0isObgUi9KwOwuQP/TLcWnyEPQgkA6CrNli6f/5YCQ1Ut8mXSoY+01wLoRvQMFKoxjCitrN2tzf+hEe8t6uAARbDcUz30hVdjzQmX9YJdDSt2hv9XB6YIcgw8Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JL/h8O39hNxLgzq2BYm/aokZ2NmRdG+eHs8Z8CChyDA=; b=kL/cEz4rBtBqe5gBScBgXLrdSOUtaKjjYfalth+5pUpHzxu8UD4OA0o1rl5k6Hsmvv0N/7bwrGlgklbIL9/6In4AjHJvZPW5m+gDHrua996wDGiJrMmSD2/2IJ7CZ91fWjMjEk3tCdD+DGadxT9AGB83H1+vXigNWMLc6oRYE2I= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] build: Fix make warning if there is no cppcheck Thread-Topic: [PATCH v2] build: Fix make warning if there is no cppcheck Thread-Index: AQHYbEM7+m9qlHUq+EuzILzbZuQ4Yq0nuAgAgAAJCoCAAAlKAIAABa2A Date: Fri, 20 May 2022 14:17:07 +0000 Message-ID: References: <20277da971c1050d0464410e24ecff9d5d659990.1653048581.git.bertrand.marquis@arm.com> <3C17CA95-8415-4A05-BD3B-95FE57465C82@arm.com> <4f9343a2-7ac1-11ea-276e-32b7207db072@suse.com> In-Reply-To: <4f9343a2-7ac1-11ea-276e-32b7207db072@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5624c8b3-1745-4c46-5b65-08da3a6b71cd x-ms-traffictypediagnostic: VI1PR08MB3647:EE_|AM5EUR03FT064:EE_|PA4PR08MB6240:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gG1IiacaFy0mxOKqIPTJXEVjbxb0WGBEsQb0J6dvSw8Efm6t1lbMr8jestuEKZjiQ7/KzPjS6pxnaED8kUsvU5L3KFtHSNEusgNrAkvJrj+g34axS41qKd9YWnm5gN+e1H6CIt0X39dw08IKvSb7AuYAKtFMtXdzLQfcjdg2ScBh6vKyGhRglijGyigvW7fY2U7z4SlZqDVRzl3ptqJ0d+LI7AYHwcpXDJF3nwWdz53XdviEua1TalgG3UZeWLRcoH6GYcyLnE8GVwG27/JtoE9NXhQB0MBcyMArs4fCld3k4zISPk8OosOErhxBAD/INWI3N7IGeu9r+p7EbiEjmVBYLJhw2Hyv4wzdglsUSYeE5dvgdQfJTA59gtD7BfMzxbMeGxBJdH6zM3meZxWktHhAqrIMZAvS/n2/M6cSj93MSiB5UUn+rKvAjkHLBYhRWDUIt7adekn3qZw2d28ZFIHGge8zHv2DqJeCUx9dYius+PZIkDD0TT4eISlt92ltkbr+5McXQ+dBIxUVKyV7MJzPwaaqLDzkabIIIClp2uSuh8yo/EKz4+xyS8TETT4k40efXi5kf+g2+iu7GrjofJa+sCo2odS8vpngPxnzt16bMyz4Bmbwii+Zv/+Arh8ic2sSbeZd82N2CbrjFO2kTe0WG8cVpk2Q3SIOwbAznybswaSKQt89KxAOEFIwpzY688PxCywFIU+hvc1popHPdYtbMakMdXRPzJ4ZE3WKd09zD5NzFWTfsbPU0SAdKfYU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(71200400001)(6486002)(38100700002)(186003)(5660300002)(2906002)(122000001)(508600001)(8936002)(76116006)(33656002)(38070700005)(36756003)(4326008)(316002)(8676002)(53546011)(54906003)(6506007)(66446008)(83380400001)(86362001)(91956017)(6916009)(66476007)(26005)(66946007)(64756008)(6512007)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0039360799B8C542BEB2D2721A2A1EDB@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3647 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3eefda70-89a8-4d45-b084-08da3a6b6bd7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B5jBUBvDDg3FJ4rmqSd+f3Nvhlt5AEFN5r6/JQtf20Aoi9LcljV+wmC6t9YJTsT3q2xRMQHpMdxC3eKD+WmrfURnzm8B9FVJeoZbOGTLFGByM/NLTQwyNvhm841gXVFbf2OEfvEkrFuuD4R+EQX2scXZUYJbblxENKJuPnoyG+MCNKs+wkQTGULWObIWE093Yb/jXidqBMPfxxsQVhSBsFqojUKoESyIrdz7LsaXNTv0LYJFMhX/sYBe2W5s+zmgL+9iiMbHXC5Cl6acPU8pZF+vsyAo8UIGE414o5qYSGCFTB+z4P65YNG6irgUyYOxOylsRg9MSZ697BYvW2K8cE4GOSSleZt1vZ0SXWzpa8YlTseusoF/UaiGN6hySq7+HYFHD5q4r90cp5OZr1SRd00dxtTfqJemm/GS0s5sWK69o78987Ya8lPdSeIaEtt6CqYtGSxFOFdfgFwtnNk1LFebPRy+FmXzyskhizHDVBtuNOpDLd9GcLqArI4uQQyCFv26nsOgOYgIlyw9A7NkS7qeURhhO1PrAahuy5G/XZ3KYR4fGH23i3b8bQtsIYZkjv7r5Z61t4QLuFEl03rip/ONe+v2ZsXoNXV7mV/tNQUvs5N8syQYhufo+ObsxZ4iXfXJ439gVB5NAs2VrlQ82C8JhEpcL3Y755XXttHDqfm82fVkg2F9iZCR0PCdZj4i X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(6486002)(316002)(70586007)(6862004)(2616005)(2906002)(36860700001)(40460700003)(70206006)(186003)(336012)(54906003)(8676002)(47076005)(4326008)(81166007)(36756003)(6512007)(86362001)(508600001)(356005)(8936002)(26005)(82310400005)(5660300002)(33656002)(53546011)(6506007)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:17:17.0962 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5624c8b3-1745-4c46-5b65-08da3a6b71cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6240 SGkgSmFuLA0KDQo+IE9uIDIwIE1heSAyMDIyLCBhdCAxNDo1NiwgSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDIwLjA1LjIwMjIgMTU6MjMsIEJlcnRyYW5k IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjUxLCBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDIwLjA1LjIwMjIgMTQ6MTQsIEJl cnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+IC0tLSBhL3hlbi9NYWtlZmlsZQ0KPj4+PiArKysg Yi94ZW4vTWFrZWZpbGUNCj4+Pj4gQEAgLTY5NCwxMiArNjk0LDE0IEBAICQob2JqdHJlZSkvJS5j LmNwcGNoZWNrOiAkKHNyY3RyZWUpLyUuYyAkKG9ianRyZWUpL2luY2x1ZGUvZ2VuZXJhdGVkL2F1 dG9jb25mLmgNCj4+Pj4gCSQoY2FsbCBpZl9jaGFuZ2VkLGNwcGNoZWNrX3htbCkNCj4+Pj4gDQo+ Pj4+IGNwcGNoZWNrLXZlcnNpb246DQo+Pj4+IC1pZmVxICgkKHNoZWxsIHdoaWNoICQoQ1BQQ0hF Q0spKSwpDQo+Pj4+IC0JJChlcnJvciBDYW5ub3QgZmluZCBjcHBjaGVjayBleGVjdXRhYmxlOiAk KENQUENIRUNLKSkNCj4+Pj4gLWVuZGlmDQo+Pj4+IC1pZmVxICgkKHNoZWxsICQoQ1BQQ0hFQ0sp IC0tdmVyc2lvbiB8IGF3ayAne3ByaW50ICgkJDIgPCAyLjcpfScpLDEpDQo+Pj4+IC0JJChlcnJv ciBQbGVhc2UgdXBncmFkZSB5b3VyIGNwcGNoZWNrIHRvIHZlcnNpb24gMi43IG9yIGdyZWF0ZXIp DQo+Pj4+IC1lbmRpZg0KPj4+PiArCUBpZiAhIHdoaWNoICQoQ1BQQ0hFQ0spID4gL2Rldi9udWxs IDI+JjE7IHRoZW4gXA0KPj4+PiArCQllY2hvICJDYW5ub3QgZmluZCBjcHBjaGVjayBleGVjdXRh YmxlOiAkKENQUENIRUNLKSI7IFwNCj4+Pj4gKwkJZXhpdCAxOyBcDQo+Pj4+ICsJZmkNCj4+Pj4g KwlAaWYgWyAiJCQoJChDUFBDSEVDSykgLS12ZXJzaW9uIHwgYXdrICd7cHJpbnQgKCQkMiA8IDIu Nyl9JykiIC1lcSAxIF07IHRoZW4gXA0KPj4+PiArCQllY2hvICJQbGVhc2UgdXBncmFkZSB5b3Vy IGNwcGNoZWNrIHRvIHZlcnNpb24gMi43IG9yIGdyZWF0ZXIiOyBcDQo+Pj4+ICsJCWV4aXQgMTsg XA0KPj4+PiArCWZpDQo+Pj4+IA0KPj4+PiAjIFB1dCB0aGlzIGluIGdlbmVyYXRlZCBoZWFkZXJz IHRoaXMgd2F5IGl0IGlzIGNsZWFuZWQgYnkgaW5jbHVkZS9NYWtlZmlsZQ0KPj4+PiAkKG9ianRy ZWUpL2luY2x1ZGUvZ2VuZXJhdGVkL2NvbXBpbGVyLWRlZi5oOg0KPj4+IA0KPj4+IEZpbmUgd2l0 aCBtZSwgZXZlbiBpZiAtIGFzIHNhaWQgb24gdjEgLSBJIHdvdWxkIGhhdmUgcHJlZmVycmVkICQo aWYgLi4uKS4NCj4+IA0KPj4gQ291bGQgeW91IGV4cGxhaW4gd2h5IGFuZCB3aGF0IHlvdSBtZWFu IGV4YWN0bHkgPw0KPiANCj4gSSBnZW5lcmFsbHkgdGhpbmsgdGhhdCBtYWtlIHNjcmlwdHMgc2hv dWxkIHJlc29ydCB0byBzaGVsbCBsYW5ndWFnZQ0KPiBvbmx5IGlmIHRoaW5ncyBjYW5ub3QgcmVh c29uYWJseSBiZSBleHByZXNzZWQgaW4gbWFrZSBsYW5ndWFnZS4NCg0KQWdyZWUgaGVuY2UgbXkg Zmlyc3QgaW1wbGVtZW50YXRpb24uDQoNCj4gDQo+PiBJIHRob3VnaHQgdGhlIGNvZGUgd291bGQg YmUgbW9yZSBjb21wbGV4IGFuZCBsZXNzIGNsZWFyIHVzaW5nIGlmIGFuZCBJDQo+PiBkbyBub3Qg c2VlIGhvdyBpdCB3b3VsZCBzb2x2ZSB0aGUgaXNzdWUgd2l0aCB3aGljaCBiZWluZyBjYWxsZWQu DQo+IA0KPiBUaGUgcHJvYmxlbSB0byBkZWFsIHdpdGggd2FzIHRvIG1vdmUgdGhlIHNoZWxsIGlu dm9jYXRpb24gZnJvbQ0KPiBtYWtlZmlsZSBwYXJzaW5nIHRpbWUgdG8gcnVsZSBleGVjdXRpb24g dGltZS4gSGVuY2UgSSBkb24ndCBzZWUNCj4gd2h5DQo+IA0KPiBjcHBjaGVjay12ZXJzaW9uOg0K PiAJJChpZiAkKHNoZWxsIHdoaWNoIC4uLiksLCQoZXJyb3IgLi4uKSkNCj4gDQo+IHdvdWxkbid0 IGRlYWwgd2l0aCB0aGUgcHJvYmxlbSBlcXVhbGx5IHdlbGwuIEJ1dCBJIGd1ZXNzIEkgbWF5DQo+ IG5vdCBiZSB1bmRlcnN0YW5kaW5nIHlvdXIgcXVlc3Rpb24gLyBjb25jZXJuLg0KDQpUaGVyZSBh cmUgYWx3YXlzIHRob3VzYW5kcyBvZiB3YXlzIHRvIGFjaGlldmUgdGhlIHNhbWUgYW5kIGhlcmUg dGhpcyBpcyBvbmx5IGEgbWF0dGVyIG9mIHRhc3RlLg0KSSBtdXN0IGFkbWl0IHRoYXQgSSBkaWQg bm90IHRoaW5rIG9mIHVzaW5nIHRoYXQgc29sdXRpb24gdGhpcyB3YXkuDQoNCklmIHlvdSBwcmVm ZXIgdGhpcyBJIGhhdmUgbm90aGluZyBhZ2FpbnN0IGl0IGFuZCBJIHdpbGwgYWNrIGEgcGF0Y2gg Y2hhbmdpbmcgdG8gdGhpcy4NCg0KPiANCj4+PiBPbmUgcXVlc3Rpb24gdGhvdWdoOiBXb3VsZG4n dCBpdCBiZXR0ZXIgYmUgJChRKSBpbnN0ZWFkIG9mIHRoZSB0d28gcGxhaW4NCj4+PiBAPyBQcmVm ZXJhYmx5IHdpdGggdGhhdCBhZGp1c3RtZW50ICh3aGljaCBJIGd1ZXNzIGNhbiBiZSBtYWRlIHdo aWxlDQo+Pj4gY29tbWl0dGluZyk6DQo+PiANCj4+IEkgdGhvdWdodCBvZiBpdCBidXQgd2hvIHdv dWxkIGJlIGludGVyZXN0ZWQgaW4gYWN0dWFsbHkgc2VlaW5nIHRob3NlDQo+PiBjb21tYW5kcyB3 aGljaCBhcmUgbm90IOKAnGJ1aWxkaW5n4oCdIGFueXRoaW5nLg0KPiANCj4gWW91IG5ldmVyIGtu b3cgd2hhdCdzIHJlbGV2YW50IHRvIHNlZSB3aGVuIGh1bnRpbmcgZG93biBzb21lDQo+IG9ic2N1 cmUgYnVpbGQgc3lzdGVtIGlzc3VlLg0KPiANCg0KRmVlbCBmcmVlIHRvIHJlcGxhY2UgQCBieSAk KFEpIGluIG15IHBhdGNoIG9uIGNvbW1pdC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoNCj4gSmFu DQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Fri May 20 14:19:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:19:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334317.558319 (Exim 4.92) (envelope-from ) id 1ns3TW-0001Cl-VQ; Fri, 20 May 2022 14:19:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334317.558319; Fri, 20 May 2022 14:19:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3TW-0001CY-S7; Fri, 20 May 2022 14:19:30 +0000 Received: by outflank-mailman (input) for mailman id 334317; Fri, 20 May 2022 14:19:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3TV-0001CS-9v for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:19:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d350ae11-d847-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:19:14 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-2daqM5v5PlGTEk-N5SlUcA-1; Fri, 20 May 2022 16:19:23 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4245.eurprd04.prod.outlook.com (2603:10a6:209:4f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 14:19:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:19:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d350ae11-d847-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653056368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3F+88970A8YskHn3cFMA7OZEcNc+a1V1u/CfOSPRyFk=; b=S0rFSHzQ2YxLVANsYhq8Ab8uYWjqoX2xfK8Qtd20ERSe8mMo99yHND2MdxXkC2qSiXhVrz xfH0c/PmzlrUN+/7fTScVvZUYFlYFoqAZg4kTtUTJcS3rkHBtPqYPic5c4HpIMHS7qnN2L mjkQszWtv0QKsVIy+RMg5AOMzsvVJMI= X-MC-Unique: 2daqM5v5PlGTEk-N5SlUcA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xm/mGdVYeMJ5KE1X5MJqlojXueiMNE+Vl0y4+x9WZv4q4fCmQI/oewFAARGItaTRZrYH6dxNS/pvq9hLAUgRoS3O8lRETjMK1gkQCERFHov+OsXiY322n8JeoH79HAGltjqplTNRd3wi3FKsnxMayirlY7ENqc6LSZso2DowjZpi1J5XNZyZXCxr6RrHjo/vw+N0h2+ToqkClRsuBAX1SAVtwyCpS7wVOS64XzEbKA+s0we3lz7IijrFzr7EHMWczFWFti35xeB7p3VY2XgOAwJXBT+5Vydc+MDpkn4o6WIr6sAtlRGONOlvKjoJ7m00t9o22VxGCzuQ0brwm5yiMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D+k0QVKOVY2sbgCdWnc/pDspJiwA7gfRhAjH6WChs/A=; b=Tjq+vCEjEzX16VNC870sOiPeOQpdP1YA/wSiBds23QyPjdwPBGMBb94dmZA4gHdHkQhpRmGNQGpMgwZHsOOqqmXTmGi1j1tJ4bUbiIvgx3VUWMcZrJyFHgqh+uMdb+eXiie63zFzY/K2ryRCOlFRvSmxqDjnNmIMOWnRZURzBWdNK0l+F4Y++p2uqPP/o0v6MofLNjrRn55pn4AD5VVsi0xMxLuiCbC8iexxEf3buZM1Rg1y2mkZiz2o8KBhf+MW1LWq7NathEKooFQklXqKtW/rKywHwkMMySzKqnDjkRk9p046+2QVwJRVkAVA6LVJbhSA3wF3MBrzSbtMi/TCiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> Date: Fri, 20 May 2022 16:19:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> From: Jan Beulich In-Reply-To: <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM7PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:20b:100::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f716b474-1b2a-46de-88fc-08da3a6bbc53 X-MS-TrafficTypeDiagnostic: AM6PR04MB4245:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dycNqubeYztgXvKUe4dq89ceHY3XxIREYZkrRfikWLEjP3uW72FQyP/qXLpdFIXuAgqz3+LPCPWI/rbHTNZ3DXIlqqqRNR2/VMmfftHqj5SwuldOk0fNGXHFensQIBPzCpYxiegM2IYqZ55KrV2bD5/F4oyGZjgHzABRxvw3qx7GnUniLkDGbz7gaOOjGwDA2VC0mQPjWP3o6wDi6nDaYG+8cy6UjGEL5QX3OhW1/WirTXg7AIMRX0R+u4tk3H7wL8Q26Mj/cCmfhp1Am8pIYF+iI0zzH6ZV/QDiHFUlafcb764vEGSslVvTt5AkT21C6o6yiGUgAx9xio75cFb6dVtkEO2eolfXK/pq9HoaZrcN21QkUHV6kFUgAvxTvmjV+5ob7/zUoyW1m4G3uqq0vMs0BK/KNpPpF0hcLsG0O1yoHWDduhU+xYU54OUO/x1Wk5S0G5O1+t7hf8nDFAZ0dQPx2Hz0O99B2mpRzr3bZHS3kTas2vj3o03sNvXfnqfPDSBkIDQ6jPVXMSZ+aM89zGHSXhynUJtlr4P0KJNHa+rw72rftV5kAeZR3J6evW1kRtKypKbgWBFOljLbuPbILQj0pn/Whb2kwJJraG0bUx4va5eGsm+obpL5ZNfHOZ594Q7FeOwNiRcL2KoBdup0e1uxbw5PWXlDWNdxI9UD8CodyFP2n3Hdqyg22B9mSYgZjz30kAlJXO9Y47+lvBT5u7JhB9YnYC+ElF2f6VMYoRG4+D2YSMnlh8qD0C1anadq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6666004)(31696002)(8936002)(508600001)(38100700002)(86362001)(83380400001)(53546011)(6506007)(26005)(5660300002)(6486002)(31686004)(2616005)(2906002)(66476007)(66946007)(66556008)(316002)(4326008)(6916009)(8676002)(36756003)(54906003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bSfZI3YIeVTGmZG/qVaH/nBGzenkSGBiBaF5jb8e1LFhvSYUBnQTvXnEN2fU?= =?us-ascii?Q?VBk7BA/fPnZqlFE+CrXrKXLuHWYdnwMk5Y1BYTfYba04CDuZtTp9vWr1qMtz?= =?us-ascii?Q?smHVkiCa2n3DUdDPg71JjnwoLs01t7v5kksSbSJSf4d67UgUZCfXud+fONm9?= =?us-ascii?Q?JND76Xv2mtUhaRhjue5GRyTyQdMeP2QUq6HgZt5kpXmd/otGv884IUmFIIQr?= =?us-ascii?Q?hC2KceIx3rEDxpTDhHKwiCG/AarzRQCBaBZxDPKq4vXPonN4DkeSBzPhzOjk?= =?us-ascii?Q?3vnBvAhgxdxmTxQRq05/H+fPWm6zcnO95PYFBUMphIjc1RxByB54sPpOylqz?= =?us-ascii?Q?ljbNMJu4o+I0oo88MOVdFCAqxlvfgOQ4Y9z5mKXb8ZZy9oV6jCH65spjatqI?= =?us-ascii?Q?Eig6We5eGeRC27/4/AJyZnlwJTSslsxkMK8iBOARjD0q479zNcfuUSikE7Cg?= =?us-ascii?Q?6OiANzUIweMU8Yenyp8JVpDoe+tN9iB7RQmQ5KW/vJb0Xez4UkN4Q1ihogj3?= =?us-ascii?Q?oIexEcwYKPQ9IoPwkzKVN0teVOe8UODldfQ7/BW9X4UPyuR2tBXe9pxS5Hbz?= =?us-ascii?Q?NBsMsrolM2FybEld75Y9A1DEHdS4r3V5XfFy5mLFc2W4b4vGuWGaVr2NHzH6?= =?us-ascii?Q?rdS29r8jRk2cJiWFhw/77kMrpjHpu+GYoP5A9yNHifTxVwQMHag0PgmrRsA3?= =?us-ascii?Q?JNN29UL1bts1BJeNcmkWI/MwQdT/KtWh3ur4agvZbJvrNvM4863Wo1+ne4Nj?= =?us-ascii?Q?4kdi64FPNcjIb5FHbBWNroVtRH9TudL/IUN2NCeZ2MJJTFj6KdiE1eGekLYn?= =?us-ascii?Q?NmtsQOGMTjA1aAWCwj6NqYkbv820F8Xei8DoyXR8pE5R/XHNJ9bTOYm2FG+u?= =?us-ascii?Q?ik/P7aQoaAtx1UO6BOGEyAq1hjeXIuf8Llt/0m000gySFzmhuD0mLlgrIxUb?= =?us-ascii?Q?8c0PmiT8x7vpmzzccnT0F+Pnm84Z/LSzmyzI/WP7yKSpDS0sDfVwhOggQFbG?= =?us-ascii?Q?OPE58oBDGAtxKxX5O8J2Vi4DgvDhamvYN/hBkfjwv712dgVe2D+g0BC7bX8r?= =?us-ascii?Q?YlNp6bg/34e1fBACrkS2BRKWA2rsTbsPyB7ts04wNg98AN8cKAfowen8NFJe?= =?us-ascii?Q?qxc+RFfqWhH1/1bwoHy/lHBA6DoLjpmcVCJPElNVIE4b9lxcleUbICR/5ofW?= =?us-ascii?Q?rxxA3wVkd9bwc70mB6+iO1GD2iyMT7ut6C/WcpFFzC+42lHmd25NgYR05HDv?= =?us-ascii?Q?4rHtJNq/rC/PLjtWXs2c+ZfV7v+9ojyV5zCxe0xCNcm1Y3W/XBRviM0BOESw?= =?us-ascii?Q?ILCiCjCZpqV5/svcZ9iJ6lMcETvdFWwAOJBJOE6BciNhTRrvP7ZVMrLVm8eG?= =?us-ascii?Q?C7bXe7TZNCdVCDmn80njv0GPrGecjdOoKzeB1Hk73bwUuChYAplYSBWerJMc?= =?us-ascii?Q?As0LmauJXBiNUamNEi/iyQVFIptI2niRcfDGbWq8oTWAWDATIgPpg1g6W73S?= =?us-ascii?Q?hU0ZYhglj0ZWR0EW2DT0ynXBInMWmH4T0NtoLO1WYHvk7hjGpWpfoJ4ib+pD?= =?us-ascii?Q?lzm2cca+uv+UOoRjoIf0qLhVmtTUIICWqe/S4MFUY/S19Lb+SoJ0UvlhVxCb?= =?us-ascii?Q?GxVVlcVpVF3HFyfKyCLK92RHtZfKDjykSzjuGJ9Hi7qdozMkTeIZtygHB21L?= =?us-ascii?Q?onP1xohNNc8JY7Rhd9ztV2vsICoYHoBUouH6f9Uwm0uqkLiVT0dzwAd4+Fqq?= =?us-ascii?Q?hKXeaUGNHA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f716b474-1b2a-46de-88fc-08da3a6bbc53 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:19:22.2943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3noTQxROOGb82qVGDNU9wr7jBMjzS5KiJLL/lOUInE9GbZFvttgbxAHYI364++az0zIdUCYHHoxVEWq2eULjEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4245 On 20.05.2022 16:10, Andrew Cooper wrote: > On 20/05/2022 14:37, Roger Pau Monne wrote: >> --- a/xen/include/public/arch-x86/cpufeatureset.h >> +++ b/xen/include/public/arch-x86/cpufeatureset.h >> @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Suppleme= ntal Streaming SIMD Extensio >> XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ >> XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ >> XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages= */ >> -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR *= / >> +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR *= / >=20 > This is the bit which requires more toolstack logic to safely enable.=C2= =A0 > Using 's' for off-by-default is fine if we want to get the series in now. >=20 > But before we expose the MSR generally, we need to: >=20 > 1) Put the configuration in msr_policy so the toolstack can reason about = it > 2) Reject migration attempts to destinations where the LBR format changes Since this could be quite restrictive, and since people needing to know they need to hide this feature for migration to work, I guess this would further want qualifying by "did the guest actually use LBRs so far"? Jan > 3) Actually put the lBR registers in the migration stream >=20 > ~Andrew From xen-devel-bounces@lists.xenproject.org Fri May 20 14:29:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:29:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334328.558329 (Exim 4.92) (envelope-from ) id 1ns3cS-0002kX-UJ; Fri, 20 May 2022 14:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334328.558329; Fri, 20 May 2022 14:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3cS-0002kQ-Rc; Fri, 20 May 2022 14:28:44 +0000 Received: by outflank-mailman (input) for mailman id 334328; Fri, 20 May 2022 14:28:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3cQ-0002kK-FV for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:28:42 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23686f80-d849-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 16:28:40 +0200 (CEST) Received: from mail-bn8nam11lp2172.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 10:28:23 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MWHPR03MB3103.namprd03.prod.outlook.com (2603:10b6:301:42::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 14:28:18 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 14:28:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23686f80-d849-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653056920; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2w4RLP7PAuMHYnk5gbClU9CSyGtXvMeJSmZw0B74V3E=; b=YpM02l4AiyeinJVMHC8qIDSLAMDXy8LcXp8w06kc6WPtx506SVTxLfHB u8zPEydCcLPwQRkeKTmpwyXV9djOtowcQIb7eLxF/SZbvSRlWzC2ATGYH B9POV9/rDq3huZ0VNhuR6yOOJLhvMrUh4TLm9qgKE9fLZtXpG+vMpnBhY k=; X-IronPort-RemoteIP: 104.47.58.172 X-IronPort-MID: 72195138 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0mLJdK/ZDavLoybUdBrWDrUDhX+TJUtcMsCJ2f8bNWPcYEJGY0x3y 2YZD2+COPbfZGXzLdojYYq/8RlV7ZGHm9JmTgRl+SA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3ILhW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCncWtVxdzL4fQo9giXBIIPCFSPJdE4ZaSdBBTseTLp6HHW13F5qw3SWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIACtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGcB+Q/M/vpfD2770zR7jJ6zN//vQp+kHf8Erh6zi EjL1jGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJvHlVgC8iG6JuFgbQdU4O/I+wBGAzOzT+QnxO4QfZjtIadhjvslmQzUvj waNh4mwWmYpt6CJQ3WA8LvStSm1JSUeMW4FY2kDUBcB5N7g5oo0i3ojU+peLUJ8tfWtcRmY/ txAhHFu71nPpabnD5mGwG0= IronPort-HdrOrdr: A9a23:KMLlNqNlmYTwDsBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="72195138" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NeaoHCV8SrcOxLCs9qgG/Pxw4+e51B1VYbwsfU3KVhFOaIjOzXD8gwMXCe6HkmeQBxMPubfSKMdzJjTXhpOEF122y2AMQq6Sgxpq2sLZ94veIiXSF1YMbLRlZ24D+io7gO4i/I1gR4zvx6+IPXKcsN7Frw0l962q1X9rTIQtiHap93/Oz+8zs6GHqrdtpCxP4CE0WDvNTLgXSzl70LYc94ZUNH0qGYmBtaZC8pxR3U7GWq6ig5S9KO5iRCS0D/hTSE/1h9bBl4I9FQdFeWXFcucgWOXtGGOacKpWceRD2+1Qfg4oRI8zjD/mNN1BSKBfYvXWJ0cHmUdeTOncRFDivQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kt+KUfPjvmjzDzkwzedVyLrFAfbLyn16qUQ4UXrAOg0=; b=oW3fJA+BaAgF5LuBqr+fCxh/E+WMnqXBkhbUpID8DYes3czzbmU94lZfv7Ssf8gSNuik/Yqr+2QyqoUo/x7QO6a/y5rtGqDZXY1FVX1CiPzC5QY8V3GuHmrcGW/B/mIT5CqAFPsR/6RugZCMCepl+sG+A3XwUU569P+tqHxdVGNzF6vMtda7EPJPrC0cdGLnOuCKtr2udP1iyaOeSRWDnVQRpP0P4e61rpdpIuOjhlOiF10FD5N0PX5rh5g3j0s9ep73OBU9UIvGp+RCgtE3ETX0Y7mL+x4izxRYWfB1mlCgZ7uyZTktVWHeDpGsMXXNuvGfkh0Ejj9IEa+PW83p1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kt+KUfPjvmjzDzkwzedVyLrFAfbLyn16qUQ4UXrAOg0=; b=JLB0AjRbI231oLSpwJu2osGgktu4Y7qKzzH13RiIc9Ji/5Is36Sm6iIJhpoOG7sBvJN+ZkI7QrJpohTT5yo0UUIQdpw2v8a2vrOabVTpA6GuYluGSHfZsWMyK8gPC+ou+24gVvBYJaAtuWlB3k/++dM/wVnjwtCGZjaioaRBoUw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 16:28:14 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0013.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa762711-d4e0-4292-79df-08da3a6cfbf4 X-MS-TrafficTypeDiagnostic: MWHPR03MB3103:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GURCitgcIer31dK1XTgqqHRx8T++aRfD/4MyFhE1gSrj/Tj1FdyK1bv0gN4he30KZvooL+V9ZU5mvfrcZow1/6cDmaD64mwk7WuZH6oNUo7PQVCnXSWpv04513xeZ4bB1B/1FFhi++arm895n9+eTrIEmNlYoYQq781yFH+vMg3A2JANvXb4TaqHHyAUb46nklbySXOW1dHBNeF5ZOeIsbAhQ1qOTZgijMcNW5kP/8Ha3rq2iO4dvSLVmGN8EmJx0WxJg7XM9OZvpsulDHMUr0VR5IsSHJ66quDORHap8wT4PrVFS0mG6NF5dsOekb/WlyCNSPaZl5iJdv+r5NFbqVgXGGqIiAd9BGropAI3puzMNiV6Cn1JVGzJ8OTZfa5S0TGb08TupdNdxELabyOxHBT8pNt8YHMyMP4t3SnLjDGl0DgXSpEXvfhFIFzWfODm01buUzWmWxfeJThHRbRVcJ6wwOn14WQ7stCCxxi2nGyQAsAzB11eWJX1YGMw/ffTUq/5NobqYV/vy70R+7apRpl2Zwd+7GltwEjIdOW/7TmdJvYPDdkXtOtMnDEMIg79Qp5eylaxpOXYe/C6ctLeCdxa3zI+1c/M6OTy3NWIEX27cUyDrPe5l0N0n3YsI6Lo1NsglZY4mOG0KYTkkIGnwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66946007)(5660300002)(53546011)(38100700002)(8676002)(8936002)(66476007)(6506007)(9686003)(2906002)(26005)(66556008)(83380400001)(4326008)(85182001)(6512007)(186003)(82960400001)(6486002)(6666004)(508600001)(86362001)(33716001)(316002)(54906003)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFUvcy94RDY5Ty9uZFVsd09JQkRXem8vdHZCNnBBaEJkOGFvOTFKQnByWmdX?= =?utf-8?B?a3pLRnBUWnFySHh5OTBvSjBjc2ZOWXpTeHVoUGZRa2FKTDhaWWdpYkltY29o?= =?utf-8?B?c2cwYUJiOG50bVJGVVJOcVRLM29HNFRnVEpaTnNVVWVUSWJpVHFlb3dtaWE3?= =?utf-8?B?ZTUwUHhzS3VlTlpTUXlVWHlwVkxuQkZNNGp3UzV5OGxEbXUvdTdINTgyRk5V?= =?utf-8?B?N3BxL2Z4c0ppaXAvWlJoeXFvVGpkam1acG9HSFFuQ2hob0orTEViMnJTR0Nx?= =?utf-8?B?SDYyNEE1aTN3Y0I2c09LMXh4c3dVeHZFVDlLMFQ3UkN4QlhjeGZocFBNWVV1?= =?utf-8?B?V3pTZmdKdGl3OEpEUlVaWEc4RUlYdHpLaEszM1pocWlHeHVNaDVNMGpmNlRM?= =?utf-8?B?NnpCeXQ1dWhVcm81OGEvdmNNaEJDN1FMdW9KK0VMbkhCYjlSUXh3VFZWRUN3?= =?utf-8?B?K1hZeXRTNzF3VjJLbG1iRzNnaE14eURScHp2bmgydXNHZmtPTGw5ZG9jRTFs?= =?utf-8?B?b3dCRkxacVFxRVJEd2tpb2d1OVlrSkc0K0Z6ZDdCeThmRjdYQ0QvRXo1dXNJ?= =?utf-8?B?eDdXMnFkVGtseWNmNFBBdVVyK3Q5WFBEdnRFS2NPdGlwclozUDJ1QmJQeHlp?= =?utf-8?B?eFdGN0k1dFV1ZlI5Sms4cVBMTWJHVjVFYUIxUWwyNmkzTjJ5TkdjUXZ2SGlP?= =?utf-8?B?bUJqUlJYQWJtSEl3dFA2RlFXOFNEeDlhaUxweHFZcitBbXFOclFNbDNyMVhE?= =?utf-8?B?bUhtRWY1anRiLzlaSlJGMXYzMEU3NUFyaVNSQ3ovQWFRblFBS0ppV0dLcVFQ?= =?utf-8?B?dlkyM0JNVllqM29VZllubXp3ODhrdnpwM1o2MDh6R2Q2TG44ZWNVQ0xWTmta?= =?utf-8?B?RU1TSlFVMTcwMlVFWFU5d3FvN3F1Rm9NbU9WaXpPUG03QUJRbS9JUTY1VTlU?= =?utf-8?B?Y2lTSXBKMTZpY0MzUnB1ZlMzNkU4TzRUd21JRmU3bGE3NEkvMlpXMVpqVTJt?= =?utf-8?B?UUt6YlMxSXN4V3hWWlNyRitvakMrQjFHUWNqUlFjbGtac2dieGVralAralNX?= =?utf-8?B?bVc5SEhueWZTbVVteDV6V3haTkVXMndqNWdzdDRreWpIbFlzdTM2VjZjSTVW?= =?utf-8?B?NFZFenIvSXNReWxhMk5NTnMzY1JnakE2WlZRLzFXRVQxbjFFT2NDQ1FMZ0Iz?= =?utf-8?B?Wm1HOE12cDJkSFdoSkFXRTFQdlVSTHFmV3VvRVh3UThraFRRWjl4bDRzMmFK?= =?utf-8?B?TDZFYmpyNmpwMVNrYjgydG9zMkFtKy9Oa0dRM0YxUTllMGRMUWhoYjl3Znp2?= =?utf-8?B?WnhWYy9hTmRCMXVhYytTUnhPZnNBTjJpSkQxUW9vWHRKMjNWdTFIZnJjMkRS?= =?utf-8?B?SHY1ZWFKNjI1MDJOMnFTeGo4THAzRlRpUmsxWWY3Q29RRmI3eUFmQkhzQjRG?= =?utf-8?B?QnQwNm15QXpLR1BHNFpRaWlTYVFVTlBuWDJlSE4vWW43RHFmRDl6b1Bjb2hm?= =?utf-8?B?eFA5aFNKbkFFVTJLYzM4OFlMZTRwNXkzTGN2VVNmMUVFTXFBODFLbkJ4TXdZ?= =?utf-8?B?czZ0Q2d0NkVjWUlIdUxsbTVUWXhyWDRhempFWHN4dXY1WlJPcGw1cENMb0Rp?= =?utf-8?B?dkl4cU5TMHJGdE1GT0JJY1pmbnFzZU11QmVHSG1adG5KTVZtcGtZcTlhSFIz?= =?utf-8?B?Rjl1UnNwRkZQak5NeW1URmFldVVtMS9zc29TYTR0ZCswWXNMckl5M2xrRHc0?= =?utf-8?B?dmZ5bWs0TEIrL1daSnpiVnVVSzlwUExsUG1FY003c0pJQ1gzdkIyb1BLcVhN?= =?utf-8?B?Qm13TjJZb2orUlBCMmV2Mk80RkNkUCsrMEoxY3VJS09QOXN3Vmt6WFJaMHVw?= =?utf-8?B?VUpPZko2clBaeFF1MFFOYkpIQ0lwbElDQ0JlVXdVb2ZIa0VzcVZkRnAxNXg2?= =?utf-8?B?NUxNRTdGbjNOYmphYWlibXZZYmZoRzZHdFREYTRET2Z1Sk90eVpxa00yNVY0?= =?utf-8?B?c0NRSVNaRU8vaGt1djlDVWJqZ09zeG5NbXRZL2crM0g2OXJKUGJOcEdqMWZD?= =?utf-8?B?Z1lOVndvTVhYVDluUTk0RmlRM2xZKzFVUWNZT05zcmxPbDNRYzl4RG13c01v?= =?utf-8?B?aVh5Y25lemNQMit3VElzVkZHNjRoVXZIeFUrRGV6RHhRcXhxZ044eVhLQzN4?= =?utf-8?B?eitOQjYxVzZ6RWpxa1AzbGRPcHViQUVEVzJHOWJYYlFBZHNGZEZxQlZXRVB2?= =?utf-8?B?ZHp6TlljT3NiczhaSWJpYnh1VmFQVXE4OTI2ZXlad3pvR1Y3NVZYOVRzaGs5?= =?utf-8?B?QWxvSFBDQ2RzV21hZXE2MWNyNnNVczQ4MWdFUmE3Y1A3Z1FSZE9oUEYveVlx?= =?utf-8?Q?fMdf7ilzZUnWP/PU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa762711-d4e0-4292-79df-08da3a6cfbf4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:28:18.5890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C8MuEhLTQCjcLLcrBovyx6RF75rB8EAQRNfzz94PMX+LbstfHJHuMPGXjXXuJTU0gkSmBYv1xJefu3vhSY+mjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3103 On Fri, May 20, 2022 at 02:36:02PM +0200, Jan Beulich wrote: > On 20.05.2022 14:22, Roger Pau Monné wrote: > > On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: > >> On 20.05.2022 13:11, Jan Beulich wrote: > >>> On 20.05.2022 12:47, Roger Pau Monné wrote: > >>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: > >>>>> On 06.05.2022 13:16, Roger Pau Monné wrote: > >>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > >>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c > >>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c > >>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > >>>>>>> > >>>>>>> while ( nr_ptes-- ) > >>>>>>> { > >>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > >>>>>>> + ASSERT(!pde->next_level); > >>>>>>> + ASSERT(!pde->u); > >>>>>>> + > >>>>>>> + if ( pde > table ) > >>>>>>> + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > >>>>>>> + else > >>>>>>> + ASSERT(pde->ign0 == PAGE_SHIFT - 3); > >>>>>> > >>>>>> I think PAGETABLE_ORDER would be clearer here. > >>>>> > >>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere > >>>>> in IOMMU code afaics. > >>>> > >>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not > >>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use in > >>>> IOMMU code but not PAGETABLE_ORDER. > >>> > >>> Hmm, yes and no. But for consistency with other IOMMU code I may want > >>> to switch to PAGE_SHIFT_4K. > >> > >> Except that, with the plan to re-use pt_update_contig_markers() for CPU- > >> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. > > > > Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? > > pt_update_contig_markers() isn't IOMMU code; since I've said I'd switch > to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I could > at the same time start using PAGETABLE_ORDER there. I've got confused by the double reply and read it as if you where going to stick to using PAGE_SHIFT everywhere as proposed originally. > What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and > LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correct/ > consistent, ... > > > IMO it makes the code quite easier to understand. > > ... or in fact helping readability. Looking at pt_update_contig_markers() we hardcode CONTIG_LEVEL_SHIFT to 9 there, which means all users must have a page table order of 9. It seems to me we are just making things more complicated than necessary by trying to avoid dependencies between CPU and IOMMU page-table sizes and definitions, when the underlying mechanism to set ->ign0 has those assumptions baked in. Would it help if you introduced a PAGE_TABLE_ORDER in page-defs.h? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 14:30:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334337.558341 (Exim 4.92) (envelope-from ) id 1ns3eX-000451-AF; Fri, 20 May 2022 14:30:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334337.558341; Fri, 20 May 2022 14:30:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3eX-00044u-7G; Fri, 20 May 2022 14:30:53 +0000 Received: by outflank-mailman (input) for mailman id 334337; Fri, 20 May 2022 14:30:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3eW-00044k-0f; Fri, 20 May 2022 14:30:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3eV-00009g-Vr; Fri, 20 May 2022 14:30:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3eV-0004tk-Ib; Fri, 20 May 2022 14:30:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns3eV-0004Rq-IB; Fri, 20 May 2022 14:30:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GUOYXvsnnLsytgn8NAnXH4Pyd5OAZgw7kDnifEHGD7U=; b=M8MGG0d1Rg8nssm1F4KCzWgc4I 9VjAxOPKutIxtAQ+NgpqrGBAFqcNj0EZE6e2J/lDwaPheJDm0Vxn9DyUgj8Hi6LpXlCrZZuPjuVSe RzudiVs2Zy2qAbMY/2VMlh1kO+5UdwZ2I/s0vwvjb+1FhRYwkfkDd2dzwcUHpQ0nD+y0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170604: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 14:30:51 +0000 flight 170604 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170604/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1122 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 14:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334348.558352 (Exim 4.92) (envelope-from ) id 1ns3ml-0004ny-8K; Fri, 20 May 2022 14:39:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334348.558352; Fri, 20 May 2022 14:39:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3ml-0004nr-50; Fri, 20 May 2022 14:39:23 +0000 Received: by outflank-mailman (input) for mailman id 334348; Fri, 20 May 2022 14:39:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3mj-0004nl-Dw for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:39:21 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98d79556-d84a-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:39:06 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 10:38:59 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2849.namprd03.prod.outlook.com (2603:10b6:404:118::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 14:38:58 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 14:38:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98d79556-d84a-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653057559; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=hwahVbhThukWNLmfnLTNeQOWyK/Q5fuo8ULIfLHESuY=; b=Q46xN52ViEijCqWGEDa8U6FUDl3tohYaunPU/kyd5tI4Scn1KDlANfSE IqOVcz6tw1xpmMoOybGB3MhFdRyYsspL1kER2vq+EcmEEBjrGEl7Q3vru P0ncimzFbDgzyM7DgzJ2gC3sTXLp/RhlrIcwU3tjElZE+Lu4UvWOvdKhV M=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 71168849 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:WMzOu6iWEyTGZtBW08/7AMsRX161GxEKZh0ujC45NGQN5FlHY01je htvW2CFbqyNMTejetp/PIW+9UsP75OHn9E2HFZoqSswFXkb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnV4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSxyJq7PnMM8akBnCAImP65p1qfGJnfq5KR/z2WeG5ft69NHKRhseKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMu4EegG9YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8QvL9fprsgA/yiQtyoe1YYvMZ+aFROgKxkGph Fjn3mXAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUS9wWl2qfSpQGDCQA5oiVpbdUnsIozWmYs3 1rQxdfxX2Qz6PuSVG6X8aqSoXWqIy8JIGQeZCgCCwwY/93kp4J1hRXKJjp+LJOIYhTOMWmY6 1i3QOIW2N3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:QAkPLqo8urE6o//WUOWiIxUaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71168849" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xnv5CpcV9B23d8wGUruu+eLZ8LFJL5HUH8uRr257Ulq30MOdfaijXhYbCCU5b0DOHFCvm7TlTYAtzYz6S/bia7WFEpI4hRlAGzPo6hGKtByuCo9ZsmwIRogddsU+Dys122IhbFTtP6JuTs0lH7UF7RuMdFwokUlCh5KBfD+K5GQKdnXZgc3mbS8zVz2QklelM4SRcefeKvyLVh3EnT+H7zsKHiHZImneLiB3n35vndWztzZC6ZrH40Fmt/PzuVjepykmesdbtV95p3C8Ra5GdMqDHXqUuLrMorNi8pGupNKL15K5JB+n2oN+b3RCxUV/UbBNCdYdHyw77lXeIFQicA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J9c2QB+/UfFbD1WhIYVZAX4nGis3KjHoOsQOs8VFihk=; b=hfoN8Q5xd5oKoHjykjD/jzvHNmklkzGDbQhObe59l5THKwJokGNf0wDlU/zW4DZaV2iZ6nOe4T/G7uO3T9cOakbAvbMYLkPpgACNkxU0yc9id97ms5C1u12FSATCmTGb6Iss/K6Ge7G17YowgmQhWkp/PtujELf5xC9/6Ev4xlL6V9LmFo5otKiivHKoqAbi3SOmBThQOtJ/ghWX+A+/33dqp1f3Tu28YLLeHs5IHNp5LT6Dqlkt6lNxWsmwEdIbfuZy0nr6m7W3UaKcYdjYfBakQdJ7Loupc7ytA0ZOnGor6QT71sl2VmbAd4QzTKubWofvTf267ZMTPCf8cV+WVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J9c2QB+/UfFbD1WhIYVZAX4nGis3KjHoOsQOs8VFihk=; b=nH3/PEr9zzCQYaConnsgpoFpovnzN1FSBm2CUkdytBBoD0rXvSiogQX2A706ObVJ75tkYfSGQaGRvoh4u/qCIOLFviVSvR6NwFWrfcpjqmUYt6cR66ydBzCQnbzX4bJLK/7cjfSkvDct5StG+T6gX6hgpCFT7vKwAtFBLJZaYcg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 16:38:54 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::15) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d507643-03bb-4184-1b5a-08da3a6e7914 X-MS-TrafficTypeDiagnostic: BN6PR03MB2849:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X98SmXuTxp7U9J5T/UGkrn3NqCXZ+pFchrFORKDwoy2WFVLnwiBE3b1hUnFUn5+/305qql34pvVo1SGo03vlInaOD5Q+SD9hS4zG2G63Zj6qveM1uNkRLUzAFXWTXcMjS6YybjTTwyO6AMSd+f5ck7cKx7uiJWEdPH+dKgvuLDHYoPmN1F99EdJsrRTYLucSBfVRzY/z8x3MlJlaGcp4N62MjwM2WyY+iwbZXg77kNdnB6eAqcikrDcVq3eSDnIp3zHWW+yAgufDitdpREPXxZg3ychH8pm+oeQofJLJ0BYuwcd0aCjpKPJY7jeC0Hk1/9VuZh5jI51ATOaHdrTi4Dgivx4EIF7Qz8v/D5VfH9ajK6SE+khwN1lQRF1FzHaXS+LijuyNdv9hdE8tPcpf45dZR2f/tWz3LfQf/CgbLM8GftpofIjFkDD5e6fF8zvHsQz88nw4lKG7xchnK6a1nJuRn4Pr7Rgk3+bw5bQszZTxb8ghvTlbzH4VEMhCwhnkLo5q21+hyj6Am/V/i4+WqK0dHj0oxn01Fz9qtzMyWNfYN9sMCAoVht1w0SmRC9qgXrbgkZQ2FV/qtbAkRt05EgSpYxMuV53ijBfZhjWkiz8AtSU8GnYAqCN7Sdkh0dQFrV+upiIfyXcKNw5NqqNI3g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66476007)(66946007)(66556008)(8936002)(53546011)(316002)(4326008)(86362001)(8676002)(54906003)(6916009)(9686003)(6512007)(82960400001)(26005)(6506007)(6666004)(186003)(85182001)(6486002)(508600001)(38100700002)(2906002)(33716001)(83380400001)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2ZsbUhxbWZleExoOFVpdmlxNGhKSHFqblZLalEzNHpNaTN2STRTelhPWGNE?= =?utf-8?B?dXk1Nm42cC9sWW5oQ083UEx6cFRCVHFTSk14U3VmV3J5d2t1eHN0bE1sQnRO?= =?utf-8?B?TjJXZHRReHhiaVcyOUV2Rk5mdk1ZWStmTDREaW5OeUtRL3RMa2RKK1R6Yk9O?= =?utf-8?B?aWJVWm1OakZkaTBjVDNzWkxIMDVHVUFYeFhLTmFKMXF1SFkwTlYrR29aKzRh?= =?utf-8?B?cUxLbHZ5bi9uenRwa0dLZjMvNkRmK0RhMlVqYTlhTEFOQ0F0RTRzL2YrRElT?= =?utf-8?B?Z013ZUN1T2VNN1RlZHN1VG1LVnk4ak9BNUt6a0VXdXdrSzZwTndkRVZQT1ZF?= =?utf-8?B?NG9pZnpCR2hvc0drek1aVlVxUHc0N2JUS1V6NytoZHdoK0tuaDFtcXBWekJm?= =?utf-8?B?aWlPOWQvMWUzWjRLQlNEMUdzZkxwTjZ6aEZ3bzJJWmIzQlJGZnJZTDdKYnNL?= =?utf-8?B?TDZQVGJmUDJBZnpwR0IvZUt0QkVKUEEyRnJsR3V2eWFGZkZwYkh0S2pSUmVv?= =?utf-8?B?R2RUVVlJcjdOcWtPdmpPVDNicVJybFhoTlBDOTRHeXFMN295RzJiM25sOU9z?= =?utf-8?B?NTRid2dRNFBDeUNhRjF3Qk55T0c0aWp2UG4yMEZBNzFvN1VUckhFQzRTOGpw?= =?utf-8?B?SkZYTG1sdkFKSlhBNjVMcklPdXo5aVlBcmNYSENUazl0bEMzNUp4NXhFaHlM?= =?utf-8?B?d3BLQ2paVGN2WHpYU0cvc1ZWRG5YajZXNUFZcWp5TXIvVUFBWG56QUYxck5S?= =?utf-8?B?KzF4Q09PeXZnTzl2UHZ5Z2YzcEViNFo3VkhrZS82UUVqUjN4cUtyQkd2Si9J?= =?utf-8?B?MGRDcWhsQjlscW9BSjBiNExvS2EvcGlGOWpEL25vT0FwdzJxQmlndDZOckQv?= =?utf-8?B?VVY4d0pVemlsNWtaaFBKTTRrekFOVnpvSHAxc0R4S2N6UFlDRWFwb2hkbmpw?= =?utf-8?B?Q3VBV1VkSFF0bUMvYnhWRVBRSllKTXFMOFl2Q1JQTEZpZHo4d0JuVjJYNUF2?= =?utf-8?B?V2U0bElKZ28rSy84QzVKbmZ5eTFwa0FlSlJNTVQ1aFZYL3VoMmVzd29BbmR0?= =?utf-8?B?dnhMVjR4WGIrcUNFcUZNcjk5STVIWXVMRzkvcU1kTjJQd0lGQW43eTlZYk4r?= =?utf-8?B?VkxxYmxmME85Yy9wVkNhN3VSYWRmVEdHRzQzWGxSUFozMjR4QXVkTUdXaEZ6?= =?utf-8?B?ZW44S0VrMTcwc3MzUlhUL2F1SFhYdU43VmRLTXhoZnRvWGd6aWhnY2taVktY?= =?utf-8?B?d1p4OFdiWmYrWGdRRnFhVVZzb1BtVVRxNWcwa09UTVE2UzhhaDJ3VGtURFd2?= =?utf-8?B?eFZQRnFhdlR0ekIzbWRuN1lGbGhLWCtUY3I1M05oME9McDVFY0JtcmpFQjF1?= =?utf-8?B?QWFCUWhXd091OHJVaGQ1bDlJVFJ6Q0ltZEd5V3ZtYnBPMGJyY2xKaHNyMGdT?= =?utf-8?B?M2N2bGNBWXVOTm5HdVcwcXFpV043aWRsaEdhWkdudXNxTEVNUDlobUZiRVh3?= =?utf-8?B?UHNKRWRhbTV6bHEvNUVaZUFlZFVUZ04yRXJzSXBHNnVQM3E0ek5zTGtOazFy?= =?utf-8?B?b3dTN2dSNnpMblk3MDRkejlwMkdqNEg4Sld0UjVEQUVES1NkZmJzSXp5eW5L?= =?utf-8?B?RWllN0VIRXFWa3BBSFJ6ZEhVS2pncXNtSHliRk43Y3l1azU5RnI4RkVobEFB?= =?utf-8?B?RkZldko2NXp3ZThwdG96SU9WaUdsMlFCMVN3dVBza2ZZMFNpOGxjT3Z0NFkw?= =?utf-8?B?TVlWSzRHOTFRRC9VMUZwZUl0WXdiK3h6L3lidzJQZHpjYTl6MWoxZGN0QmRE?= =?utf-8?B?TXk2T05NbmFuWEs5YkdQTlBoUkdjRnRvNTdBL2NudVVBTjI5b0Q3NGxYcmdw?= =?utf-8?B?QkpmVFlSTTlZM3dSaEI5VW9TZFZlOWl6NE9LL2pNL3JVQ0tBbFFEMkdrQldC?= =?utf-8?B?MDRFMkpLNVdiRk9MWmFSRmVOR20vTGZRREhuRUFqYmlMelVkVndaSXIzSEpC?= =?utf-8?B?K2YxcVo5ZjVWM0xLVW5XYThOSDBxcmZ4VVVabEhuNWNRTkZjWmd6VnMwOTIz?= =?utf-8?B?cEdXRk1lRXR0dkhpdjdUVVkvbEV6RWZWb1BENnNtQVZMMlR5Z0k5R0ZrbGsr?= =?utf-8?B?WjFoVkZ6ZC8vUXRGMWMyZmNZdStrb0xIcURkekFPQkwrMXFYVFNrZkROMUZl?= =?utf-8?B?UCtXQnJKVUY0VFVJV0Z3bldlMUJ2T0hQRUZIdmZVcHIrbXhPNEdxODdJYlRs?= =?utf-8?B?bVFNNFZSVHpHY08xZ3VieExJTm9GUmNwcE9uY2FIR3c0YVBJMThINVhvYm9F?= =?utf-8?B?MWZhOUZsWjJJVDJITnEvMlExUnpFVWpEM3VFamdhRUh5aGVNQ09jNDY4RWxY?= =?utf-8?Q?87kjMD4qYtiPTFOg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d507643-03bb-4184-1b5a-08da3a6e7914 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:38:57.9614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l6P2weuPOFUqly55IprczX7NAptMGPh+eQdl6bobXDKUl8He/FLzTi5n4CIk7EGXSTEmJ391mfr3O3wsR4+ajQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2849 On Fri, May 20, 2022 at 04:28:14PM +0200, Roger Pau Monné wrote: > On Fri, May 20, 2022 at 02:36:02PM +0200, Jan Beulich wrote: > > On 20.05.2022 14:22, Roger Pau Monné wrote: > > > On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: > > >> On 20.05.2022 13:11, Jan Beulich wrote: > > >>> On 20.05.2022 12:47, Roger Pau Monné wrote: > > >>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: > > >>>>> On 06.05.2022 13:16, Roger Pau Monné wrote: > > >>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > > >>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c > > >>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c > > >>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > > >>>>>>> > > >>>>>>> while ( nr_ptes-- ) > > >>>>>>> { > > >>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > > >>>>>>> + ASSERT(!pde->next_level); > > >>>>>>> + ASSERT(!pde->u); > > >>>>>>> + > > >>>>>>> + if ( pde > table ) > > >>>>>>> + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > > >>>>>>> + else > > >>>>>>> + ASSERT(pde->ign0 == PAGE_SHIFT - 3); > > >>>>>> > > >>>>>> I think PAGETABLE_ORDER would be clearer here. > > >>>>> > > >>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere > > >>>>> in IOMMU code afaics. > > >>>> > > >>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not > > >>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use in > > >>>> IOMMU code but not PAGETABLE_ORDER. > > >>> > > >>> Hmm, yes and no. But for consistency with other IOMMU code I may want > > >>> to switch to PAGE_SHIFT_4K. > > >> > > >> Except that, with the plan to re-use pt_update_contig_markers() for CPU- > > >> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. > > > > > > Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? > > > > pt_update_contig_markers() isn't IOMMU code; since I've said I'd switch > > to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I could > > at the same time start using PAGETABLE_ORDER there. > > I've got confused by the double reply and read it as if you where > going to stick to using PAGE_SHIFT everywhere as proposed originally. > > > What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and > > LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correct/ > > consistent, ... > > > > > IMO it makes the code quite easier to understand. > > > > ... or in fact helping readability. > > Looking at pt_update_contig_markers() we hardcode CONTIG_LEVEL_SHIFT > to 9 there, which means all users must have a page table order of 9. > > It seems to me we are just making things more complicated than > necessary by trying to avoid dependencies between CPU and IOMMU > page-table sizes and definitions, when the underlying mechanism to set > ->ign0 has those assumptions baked in. > > Would it help if you introduced a PAGE_TABLE_ORDER in page-defs.h? Sorry, should be PAGE_TABLE_ORDER_4K. Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 14:44:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334358.558363 (Exim 4.92) (envelope-from ) id 1ns3rf-0006IV-11; Fri, 20 May 2022 14:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334358.558363; Fri, 20 May 2022 14:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3re-0006IO-Tb; Fri, 20 May 2022 14:44:26 +0000 Received: by outflank-mailman (input) for mailman id 334358; Fri, 20 May 2022 14:44:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3rd-0006I9-1F; Fri, 20 May 2022 14:44:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3rc-0000NQ-GN; Fri, 20 May 2022 14:44:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3rc-0005Do-46; Fri, 20 May 2022 14:44:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns3rc-0007Vp-3g; Fri, 20 May 2022 14:44:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iOpaJ5mTK7XjPgFxvPUxD5kO4hTw++eqs4dXCjr8r7c=; b=oF9R/QDlEsg1y0hkdYkCdixalc slIIad8ei9EX3z55LsdX+39vXQkmRwtImvMe5niu5U+AqXiewlpLad+SPOtdjriyexOxSX9RetNGB 7F0gHpIpTzIQHOiQUz/BvWCStRDXCdN11VOcr6UYYBSNFoy3psayyajZzFLrX4Ikv53E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170599: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=43aa3f6e72d340a85d3943b86350f6196a87289c From: osstest service owner Date: Fri, 20 May 2022 14:44:24 +0000 flight 170599 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170599/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen 43aa3f6e72d340a85d3943b86350f6196a87289c Last test of basis 170553 2022-05-19 01:03:09 Z 1 days Testing same since 170599 2022-05-20 11:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Julien Grall # Arm Marek Marczykowski-Górecki jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 43aa3f6e72..ec0cce125b ec0cce125b8b9fccde3fa825b8ee963083b5de3b -> smoke From xen-devel-bounces@lists.xenproject.org Fri May 20 14:48:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:48:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334368.558373 (Exim 4.92) (envelope-from ) id 1ns3vP-0006xq-JG; Fri, 20 May 2022 14:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334368.558373; Fri, 20 May 2022 14:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3vP-0006xj-GG; Fri, 20 May 2022 14:48:19 +0000 Received: by outflank-mailman (input) for mailman id 334368; Fri, 20 May 2022 14:48:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3vN-0006wr-Hx for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:48:18 +0000 Received: from sonic311-23.consmr.mail.gq1.yahoo.com (sonic311-23.consmr.mail.gq1.yahoo.com [98.137.65.204]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0089472-d84b-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 16:48:15 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 14:48:12 +0000 Received: by hermes--canary-production-bf1-5d4b57496-n4p64 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d77aeccd90ab3900c3b3abd94bd345b8; Fri, 20 May 2022 14:48:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0089472-d84b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653058092; bh=ecCcTHN/2j4q/asbW1Ibk0Ydf5EAE/ER3GPAGku96ZU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=V5Km9I73HM6lcClKrScegsgse2K1Ln3SjsBPv1aMWQ9T87bh3PN50zbhFTUcYWUyJsxNtOcx4Tdy4o2qTC3k8i1nzCC/1SQAjaxm6907o/l2alW3xIrrU99hZLWsYvXLbheRM9tr24udXqbEHwRhxFB5z3b5GvxeR6TNkESmHXhC3yVxITW3jia5zhG4VOqSc0MYcBccO56yuu6gBP7/7Jny3L1AeMhK8pqM8AqtHYHXasG2WyGa9XYHiw+rXTTLHnzwoujL6wl7o1stsjmgUXu5IEZllgxPjNDzCy0DLTHkYYJBMAhJ9yHjEPoIJd0+3JcDChcFubCCah064djHGQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653058092; bh=1416R1MSilgHvGCcGyrPm+pAtivsYRo3q2jSqmtVs4p=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=a0wy3XomK2RIu10QB1d+2AbN66Dwn3907IbWEmhPwx7R4Eq11VjmR/4uTPPmGX1M+otf3iOHAR5GFP6Lc5P/vFLSsuvjLWYQ+YcBUEOXUxJ9jIcJ2hPLdcTRDid9OILOy+xEe+dfE1IImXuvFtcu0oM5O1d5Tw7cAujsnh3LZnFkgOhXVhhC/G2zW2gfWM3zYP+AR3fVIeOjO67Wnw2epaV2YXTfH1vfu8nb2/2D+Q2548eFNOfsC4gFCKjYiFMqXZa/6Kf5XsRNi/oCT8XOCjz+ENDVOelRfY4VIkOPiVB5Y/dfy7u0/w/rsgxTN92OaGK4pew0bd9xzn/fwvDn2A== X-YMail-OSG: CognXTYVM1mBbBhkscyikIDMCD.HbAwkk9KcwGjyFdhGad70Vp9S4rJw8emke6o IadPBPyjgB.UYI9T2IpafdwJtql4v.Ten95hLNwkOQ3XJ89iZBX7wc2rokVFq6alSPFuWozDPiEN vCaIXvSSAf8SPRn.lHV608fPmsKXxa6aD_iY07ab22dpRHpmQ0yVGRArmy4LCTB4lPu9Y.AByd6O CjBQEccInr.pq4o9Fq72vHWRM1KhqP0mKBI6nD8xkHtH3fnlkV4ZZypomHm4wSZEpcnlbocyAHRE beXkAkQ4lw3.cy_3bC1FhGok.uj_FvBxjELV4wwlA.uzhNYek5GulSuLCmOUrTmDswvebMqsYWhf 4t0qU_1UU9kbSrsT_Q4Nbd9gtEzTq1IZOu6ZWCz2WPNlF2rLTv13HV4t2x5gEMwZl0Z1VlZV5Lur qKRi5kGKk_ln5GVZIijB_8B5ZWUpJcagYHl_IPLrhbobXtKpiIu.nZqyNFqL64aCWArE7aD3ZwA. J6KKYUSWbyaoYDNOGewS.x452v_48cz5ySnYwehpOkxr1XEGhOTxdFT2hXf3cPnQp.MSQ4mPrKqB y1MmhUS1ERehmAnVcVf5p.Mk9dy0Cd9lPi8PDfjMijx3tsYIfo3R.m3a90XBqIy53y20xhUKAaUk TIJPAA0hACeWfWCiEtNSv3M0N8iJjCsMlKvD9L9udu2yWQPdZZHoICfQJdzJUiRN8M_Kvi1fNT2i HJYJ9cinElHIrQ9uDV06LcBgh84JMX20zaI63qxG4HZ35SFo9ywQFly0kg0GCrdHX6UGZ40sSwLr 5lomXwKBXH639KT8mB3TK3E7QQOWe40aQn2N.6HopoeT4oD4GSp4Z7b7JTYCeILAZhnOofcNb6qc szI91EsG3HtkgNiAQN0s4_LyBF4kaMtqzKrQtJK5suBIwBxfIKCG1SbvoRbW30HNvWNPXVmrVK8. .Au_lT0pRPnU765iJFLQrQZBk4kHz.wJNWZL_YrEXnS3Lj24b99svP1K06kOrSWHGjVy_LFAlZ8O plK74HCEWUyGv1soi1FOPho.b_gIr.TztkYrW_UD9nazEM3PKC97zeITCl1LfpxSSm.oXXdfmpNJ 5xbv9nj8ya.afEQOAjtHSBM9fwCAqIidUIjmNtObQ4MatwwAkK3WBy.MmqYo93EBGZcfmGNJn33U AyFz3aNeMnrJI22H2l3s.Xg890wHiYoE19NFYafwShYhzBFIeXyt5Wn2HdcJU7XFzgvEtDZAmnZp OWBx0O1C4oOWZOt7q3_bK7U7Sfzl9_Cq79DbM.y.eQNtOn8dE53DvcImOrDmKhnfHFtDM12PCTGK GifZem8uVelcKbxmS0ronycKSCm2dDgRdHmk_fFiLHMVQO8xVP4cBxXon3aCO6R2TjvTNwGHOtgX sDyxLhMmlIdyGoH9EftcN47sVQjWaCZM2q3VB7xAAw47jx1HYAUBhSiGxIn.qO8RNyH2nqPgIuCr Lsz3lxwqEyyIPg4GghZJpjvhXx76jr.zBbJY9_7AtaPwy5EorSfZri1dzroZfBBUr9MvECPpyJho 3qc0ukWBKPETtoeJKQigVHCM2JXvXXSzc8jMYopkroLsIY6XoHOfTcs0ybwhKCR33dYE50fADwam urxAV1HDmAVOzkp8qwVUdCmGsJncWAtxcr7irczuoDjHg5748lxbUei1H19CuEQvp8DAend46AkB F9SAELzuheoDtw5PNiFbLc4boQ.1pmTdNyAkpEO.JqfJBJM9_7eyo7jyGLv86XRo0LElyCSPRlMA pHPu.yAd0POvmZVwASiBFft_HlJ6YifEn1PrKVki.Tlcm2Yyy0JIcgf4y8HgykDSgoaJkvb6cUV0 _lReh7YYWUmRnfupI5WKFGZIKzdsneWYaf2PYaa0tdsSpFqjbcyqULIZqMQQ2FsLaPcXae8rFMtK esbxwSnjHTrUU_TYwgo9LQ3SecCKX898bJI9zSqkfsbPCmulbBe51YrLOo3bVgXQlNdYnZ8ZXuAA 7d6StWniR5am85XcuHYHVnsTBy6HATG9lof.vN9_gOYz1Uc3unzH5X2oRNMUn60.1OutX_a.3C3I fslrQ5_hoGLrM8q18R30AVAeasZotvwNelCtIBQp1mRFdzu...V5AWqFTumIv0JvwQ9oWRti3D3M 9cIv7aSmzUc0XP9HW1RySUWFrz6.CEwvs1THMNMKxwe.SUAcwRUfwdmsSGUnxSIsX0Ak5QCoyOvF 37O0c9fpbWNCP X-Sonic-MF: Message-ID: Date: Fri, 20 May 2022 10:48:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> From: Chuck Zmudzinski In-Reply-To: <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7796 On 5/20/2022 10:06 AM, Jan Beulich wrote: > On 20.05.2022 15:33, Chuck Zmudzinski wrote: >> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>> >>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>> those want >>>>>>>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>> observe the >>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>>>>>>> only predicate). In fact, as said in the description of my earlier >>>>>>>>> patch, in >>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>>>>>> the >>>>>>>>> problematic one, which you leave alone. >>>>>>>> Oh, I missed that one, sorry. >>>>>>> That is why your patch would not fix my Haswell unless >>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>> >>>>>>>> I wanted to be rather defensive in my changes, but I agree at least >>>>>>>> the >>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>> >>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>> really don't have a strong opinion on that question, but I >>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>> should not override that, >>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>> an override would affect only the single domain where the >>>>>> kernel runs; other domains could take their own decisions. >>>>>> >>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>> bare metal has the same bad effect on system boot, so there >>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>> (but tell us "don't do that then"). >>>> Actually I just did a test with the last official Debian kernel >>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>> applied. In fact, the nopat option does *not* break the i915 driver >>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>> normally on both the bare metal and on the Xen hypervisor. >>>> That means your presumption (and the presumption of >>>> the author of bdd8b6c98239) that the "nopat" option was >>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>> had no effect on my system with Linux 5.16. So after doing these >>>> tests, I am against the aggressive approach of breaking the i915 >>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>> nopat did not break the i915 driver. Why break it now? >>> Because that's, in my understanding, is the purpose of "nopat" >>> (not breaking the driver of course - that's a driver bug -, but >>> having an effect on the driver). >> I wouldn't call it a driver bug, but an incorrect configuration of the >> kernel by the user.  I presume X86_FEATURE_PAT is required by the >> i915 driver > The driver ought to work fine without PAT (and hence without being > able to make WC mappings). It would use UC instead and be slow, but > it ought to work. > >> and therefore the driver should refuse to disable >> it if the user requests to disable it and instead warn the user that >> the driver did not disable the feature, contrary to what the user >> requested with the nopat option. >> >> In any case, my test did not verify that when nopat is set in Linux 5.16, >> the thread takes the same code path as when nopat is not set, >> so I am not totally sure that the reason nopat does not break the >> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >> returns true even when nopat is set. I could test it with a custom >> log message in 5.16 if that is necessary. >> >> Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) >> to return true in 5.16 when the user requests nopat? > No, I'm not saying that. It was wrong for this construct to be used > in the driver, which was fixed for 5.17 (and which had caused the > regression I did observe, leading to the patch as a hopefully least > bad option). > >> I think that is >> just permitting a bad configuration to break the driver that a >> well-written operating system should not allow. The i915 driver >> was, in my opinion, correctly ignoring the nopat option in 5.16 >> because that option is not compatible with the hardware the >> i915 driver is trying to initialize and setup at boot time. At least >> that is my understanding now, but I will need to test it on 5.16 >> to be sure I understand it correctly. >> >> Also, AFAICT, your patch would break the driver when the nopat >> option is set and only fix the regression introduced by bdd8b6c98239 >> when nopat is not set on my box, so your patch would >> introduce a regression relative to Linux 5.16 and earlier for the >> case when nopat is set on my box. I think your point would >> be that it is not a regression if it is an incorrect user configuration. > Again no - my view is that there's a separate, pre-existing issue > in the driver which was uncovered by the change. This may be a > perceived regression, but is imo different from a real one. > > Jan Since it is a regression, I think for now bdd8b6c98239 should be reverted and the fix backported to Linux 5.17 stable until the underlying memory subsystem can provide the i915 driver with an updated test for the PAT feature that also meets the requirements of the author of bdd8b6c98239 without breaking the i915 driver. The i915 driver relies on the memory subsytem to provide it with an accurate test for the existence of X86_FEATURE_PAT. I think your patch provides that more accurate test so that bdd8b6c98239 could be re-applied when your patch is committed. Juergen's patch would have to touch bdd8b6c98239 with new functions that probably have unknown and unintended consequences, so I think your approach is also better in that regard. As regards your patch, there is just a disagreement about how the i915 driver should behave if nopat is set. I agree the i915 driver could do a better job handling that case, at least with better error logs. Chuck > >> I respond by saying a well-written driver should refuse to honor >> the incorrect configuration requested by the user and instead >> warn the user that it did not honor the incorrect kernel option. >> >> I am only presuming what your patch would do on my box based >> on what I learned about this problem from my debugging. I can >> also test your patch on my box to verify that my understanding of >> it is correct. >> >> I also have not yet verified Juergen's patch will not fix it, but >> I am almost certain it will not unless it is expanded so it also >> touches i915_gem_object_pin_map() with the fix. I plan to test >> his patch, but expanded so it touches that function also. >> >> I also plan to test your patch with and without nopat and report the >> results in the thread where you posted your patch. Hopefully >> by tomorrow I will have the results. >> >> Chuck >> From xen-devel-bounces@lists.xenproject.org Fri May 20 14:52:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334376.558384 (Exim 4.92) (envelope-from ) id 1ns3zm-0008LC-6O; Fri, 20 May 2022 14:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334376.558384; Fri, 20 May 2022 14:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3zm-0008L5-3A; Fri, 20 May 2022 14:52:50 +0000 Received: by outflank-mailman (input) for mailman id 334376; Fri, 20 May 2022 14:52:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns3zl-0008Kz-91 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:52:49 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a33a82b-d84c-11ec-837e-e5687231ffcc; Fri, 20 May 2022 16:52:33 +0200 (CEST) Received: from mail-bn8nam11lp2172.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 10:52:45 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN6PR03MB4190.namprd03.prod.outlook.com (2603:10b6:805:ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 14:52:41 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.018; Fri, 20 May 2022 14:52:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a33a82b-d84c-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653058367; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YBvgaiAPmrdYxIe9cqOyiH0RadAqegCUmYQTj1q7hjQ=; b=NbB+NIl7l/FRvsA7JMCaMh5qL/0JhhfmKmxwjar4pS98wltMiLUhOPVW 2nb5M7Pbiz1gZOQNoZwRCYTGe5UpMJB+jGKLZH2aH+IChqPkPQXRCv0Cm I7vptQnrRv3ZjkGTD+fUn5IeVIMb5bwOifwabY/1Igl4z9o6+ZEbCFwjr 8=; X-IronPort-RemoteIP: 104.47.58.172 X-IronPort-MID: 71169933 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YCTtnK1rGIStnhp6//bD5adwkn2cJEfYwER7XKvMYLTBsI5bp2BRx mIbXW3QPPfeMWbyfI9wOo639U4EvsSDm9VmTgRspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0UjZuIFSpqAJTPncA0DD5SCno9IO5/reqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVv7e03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamKmMJ+QnOzUYxyzjN4zAgjIi0C+H+S9KNVdpIpUq3r EuTqgwVBTlfbrRz0wGt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7gEOjX9NUK 2QP5zEj66M18SSDUd3VTxC+5nmesXYht8F4FuQ77ESHzPrS6gPAX2wcFGceMpohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:1hrvYKp0W62Lgbfs06yVYY8aV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71169933" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uk40whUybuS0XUCT5obGSdjMqT6YPdH8bChhA6jf4iGhATIwmZc52kX1zsfPe74lvalC6b9LfxIk6mRDzfdu1C3LY0vZipQbDmsvXonDUr9zU7XH7VLdi/zQGGr7ql/lRPdP0ycP8LGm17+oHsxWlAUQsaiImm3sq+XMqwcUfA36CquuMajx7p05pF2F7aJ3KDsdAbAEDlXOBqLYs/gi6PwpY9lt/J7se5ezUjeNQi+Qg2Zjf147iRvb/Z0eNJ3hw4FnnlBiZY8XxpyrLKn0X+Wi+vgpfqAkHDty0aaUi8MoqYXsXuy9PlA3ISbqxwFOL4QR1YtegNLiYlR3dpGLcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBQXBL2udM8g4lvwZ7uHFmcEic51g2I0jWoPZL7tB6M=; b=T6R1rg9/O7Fq3Yv2VeQY5wbGsK6e2X2MQtrp2ms6Hm/qj+HN5p6oR01GxLeXZg5jgJqZvOpQ6Psd7jjNe5PpaI7RrhIJMLGfJPD4uiwNXsQ2N3AjGbe2aBuC6STgG9iAqSaFyQ07hgbGgZK7hHpvc02YeX959JqRwFbOxN4s7nfvujAlyUbBtBr6rTL84eSuPKfh0tKQBjGIGWrEbads7C2OnTcqoS2xvQSlpko7loS4tpSpV3XtEYnbHZQQ5lXiEBTUzQOPMl7WZAesmJoYaoyVtAsN4ofzYMG129VoA1BbJeDqxDC6efd6NA9skWBSg0kSbGDmNNM1CDVcCeGhFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBQXBL2udM8g4lvwZ7uHFmcEic51g2I0jWoPZL7tB6M=; b=TiMYGGNR6bSYAZ1yXSJnLuNvi8YI5gaAq3OCIzTRJfU/SEnVUmkuJU4Z7qLery4gMNeX+dxfeJ2v/yNEHlSBXvGSAojbMcce5/xvzbSlVQNV86iKIwaKpbsPtmsn0nmU3DIs+b/pajH6jIpLZKpwYrL2bEa93TUsOL90sWQha44= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 20 May 2022 16:52:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Wei Liu Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> X-ClientProxiedBy: LO4P265CA0158.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 705585f6-6f23-472c-f298-08da3a706401 X-MS-TrafficTypeDiagnostic: SN6PR03MB4190:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGO5gY10sdpMb09o351dXzn3lmCvE27ouTAh8CVsbe3I7f7fxlwb2amkTRwDZSto0fQ5+7bIhJtu1OFCjwJImMcHtQxI3i38AW+9vIhrhRRcqxKSwStTWn6tRn1YJIZprcDp8DTphxyWxp4T1W4dz+//TCfa/oqc5WyITWjaYrUm7Z9AfqUspT/bb2xRAa+ranM83hCSBMeXQ62Jv7KzaSKVXE9tNtgZiUBM6ltoznF6YelWYD6UYD0I83d+DrpTsfv9ZKPlnrLXYUPxZlP0o/HX3S22ic1PGW2C2lrYoyPdyzoEBwy5foKteBXpGmSc8C3qRWdi5OpTLgSS5oynLA/2P4WitsKfNvIEFDOT2fqowRN4QqkPwWxvgh70MnEZ5icvTH1WqKbGvxzKtLrJ2cgpZxFXiRaFj2IqOZuU9NV0iRqY2WRr2/3xGrhDhBs6blYC1UAmzaRirW03Nif+KoxwgWW22IjkQLV9hICxIoiNqwRv6/px9NuimvYjoFWM2o8B3LKMhXmOwL4NKlFa/Q9M2NXgt++WIr7uHmdfPALqTVObq4qlPztiFyjtbsROjSGygfgG1TZAfucL2eYMXVQqRZC5URI31a6BzQ8u0TUrqNjr2YP+MoM3G4GGwiCk8NAk9Fuw61LzunwfJRPeYw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6506007)(38100700002)(508600001)(6666004)(6862004)(4326008)(8676002)(66946007)(66556008)(83380400001)(66476007)(5660300002)(186003)(8936002)(6486002)(86362001)(9686003)(33716001)(6512007)(316002)(26005)(82960400001)(85182001)(6636002)(53546011)(2906002)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEtiNk5wVzQwbC9Zd3VBbzJlQU9OMnN6Z3VQdlpjM0lMME5oNk1wd2M5ZGdq?= =?utf-8?B?bnBXaEV1cHRIaURGU3RwVUR1QWxkL2g1cHk5VllCbGp4OUNEWGsyRXFYeDhq?= =?utf-8?B?OHFuU2Z6akpXeXU3ZUN5QUl4UnBhb1lEOWJMQWtVU2NFeWJxMzE1MlNJTTRH?= =?utf-8?B?QWh2L3ovenRLZnppaitnYnF1UTNwcXl6Z3psWEFOZ1pFVnpDV3FVNHpmcWFl?= =?utf-8?B?bm81R00zUGhNVWJUdzdaS2Q0QXFKRjBDanVXek1aV0p2TFJMc2R2MG9tMGxF?= =?utf-8?B?cnVqS1Y0cFBkbmIvSnhlbUNhbW5DanVYbG1YeStleHBuOU52Q2F1d2RONXM5?= =?utf-8?B?dEZmeGE0bDBqcW5lcE01dFZXR2tjenBuT0NVWHdCQlpETVN0cG02akxGeWRo?= =?utf-8?B?ZkQ3UUczL051VE1IYm1RK2RSMXpkbkhSUlFhZDNOZHQwYklEWXlxc2JQSFdw?= =?utf-8?B?UDZCN2R5N3V3QlBNQmE5MGtXcHpBamlrSHh5VXo4Z3lzZWY2cUIvcWFWREN6?= =?utf-8?B?RUQvS1lNRnIxK3duMHMzTU9MalE5YmtVWk0rOVdOMTRVa2RPRWtSd3ZsYms4?= =?utf-8?B?R2VUZzFqVTBtRm4wZFJ0VE80OWxHOGZSdXZBVWFjWGdYMXdhUGRMRHdUc1cy?= =?utf-8?B?VGtJNG1VaDRkMkE1VFVuREJOT01idlk1WWxtcEpheGVQYXN5YXRXNndHQmxU?= =?utf-8?B?ZlVsKzdieUdTYm9oUDFkQUIxemErQUNRbU52MU5PbDF3UTVnME1YOE5VWVAz?= =?utf-8?B?ZHE0TE1COWQrMlRDdldGNFRlU3g1VENaVzVDaHRDcUx1MHJjaFYrZnlZZTEv?= =?utf-8?B?VUxqNkgvQ0ZIMk5RTnFLMUZDYldjczI4VURDMjZDSmNUaVU1amFBVWRrd1c5?= =?utf-8?B?eiswcnBSYXpNS0UraVVudGg0bFcxQVVsU2NNUEllOTh2YXRtOURHKzdZRjRv?= =?utf-8?B?OTdtOTRVL1lWM2xBZ2N4MmsyTmh0WVdrK0hBRVlqM2tGaUF1cUlIY1N2ZnR3?= =?utf-8?B?aWNLamJpb3N5Y2x3cU91WjJxNXRkS1F1MXA1K0xMbm1jaEpnb3J2YjVYUm1o?= =?utf-8?B?RDhWYlgrL1p3QWZJVzFEZU5CUjFIU2MvM0V6dS96cXhBSEVOYlFCdms3Q0Zq?= =?utf-8?B?eE1Cd1RZVmV4YVNFd21TckRnbU5GZmFILzJnM3JmWXBTV1R4N3AybnhhdVM1?= =?utf-8?B?MUE5NVBKMUwyVzdEVU42dHI2TTJ2OUZJRHFOeXl3STRVSG91WDQ5dnY1Yld0?= =?utf-8?B?M0dvbnA3UlNaTlZ0Y3hpZmlNdTRDbGlpUzE1S0hjTU11dTFhb1lnclAvb2pJ?= =?utf-8?B?OG4wdk9ObUFzRWNoc1RqSUhiVUtSbkREQ0ZtVEYxeHFHUFppaXMvZkdCNDZi?= =?utf-8?B?UEpSc1FCaUdVcHBkbi9HUmpQemVQS1NTb253cHRITCtyL0FubDNKVElpbTNl?= =?utf-8?B?TlJ0WlVCSklCSXFZbENvYkNYb05OTjd0ZTVZanQvUGVaMG0xV2dzOXJ1UW92?= =?utf-8?B?M1BhdG82Znd2WjM3ZmVTQ2V6RVFFaVc5ak53dCtBaVRoVU1nbEpoUzIxTzEz?= =?utf-8?B?dnlxd3JwYXVPcjZSbTA2b3k3dS96U2dFK1QvUlErc2dHVklicktydjQ1dVBu?= =?utf-8?B?aTgvaWtzUHQ2RzNUanpBWEUwVEtldmxCN29zUE5XdWRJaUlzQ2xRMVpueG94?= =?utf-8?B?UEhJUGVuc0lwRkhwVkQ5Q3dZV05ZdjIyVTFKMnJ6UHJkd21XQ0IrM0l1VkYx?= =?utf-8?B?ano2d2Z5enhDVytDRENpckdxVzhpMVN1alNOQXh4WWVRY3BidE1tWExpV0FJ?= =?utf-8?B?RVQ0S2RmTEoxczBHcTRTaXV3R3dTOTBuaTE3dlRPN0NhUnZ0bVdrTThsTkUw?= =?utf-8?B?YkFaOHgvcVdyWS9nRkU4di9maXdrVGpnelRwLzVRNUJDTnduRDFEUmMvMjQx?= =?utf-8?B?T0JXTlpKcjJnUVc5emxPSHFUSU02bXRqNHJKM05GQkh5aUh3WVZuMjdPLzZw?= =?utf-8?B?QzM5eUQ1UWdaWTF3aStmdkFHQ0x5QVg5SjdnTmZTY2FrLzVURHdHK1Zqdytl?= =?utf-8?B?NC9zTzZQWDYzSEJiRHFqdHJqMXd5OWZvKzJBei92ZUlOOWVCVTQxdkRhQzBQ?= =?utf-8?B?Mm9uQVQrZitYeFIxV25ndUZBQW1YenNmM3FwY2toeHBxQ1VMeXRYTkZwVkZV?= =?utf-8?B?YVl3NDlXL2htcmFmRmowNUpoWjZrSmFMSUsybjFTRkg4SE41MkUzOEp1Z0dN?= =?utf-8?B?NWJwUTlzaXRqcFY1T2NFTXd2NVBWMjdQTktPMTVsV3Nydlo0MTI3bFNoS056?= =?utf-8?B?VFJIVGloVXM5MFlRQThWeG1DNmpTelpWM3I2NGxiUWNBb3VRUWxsSVdDUlln?= =?utf-8?Q?7TW+TlhFOld+NfWc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 705585f6-6f23-472c-f298-08da3a706401 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 14:52:41.7599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XoNfiYRGOMbZKlYPBZ6D1of5xoZa0TD8KjcWJsO/K4BH4zc4EJL+Qh7uQn+P7SmE+uljbipas+uSzPggFxNqZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4190 On Fri, May 20, 2022 at 02:10:31PM +0000, Andrew Cooper wrote: > On 20/05/2022 14:37, Roger Pau Monne wrote: > > Allow exposing the PDCM bit in CPUID for HVM guests if present on the > > platform, which in turn allows exposing PERF_CAPABILITIES. Limit the > > information exposed in PERF_CAPABILITIES to the LBR format only. > > > > This is helpful as hardware without model-specific LBRs set format to > > 0x3f in order to notify the feature is not present. > > > > Signed-off-by: Roger Pau Monné > > --- > > Seeing as we have never exposed PDCM in CPUID I wonder whether there's > > something that I'm missing that makes exposing PERF_CAPABILITIES LBR > > format not as trivial as it looks. > > --- > > xen/arch/x86/msr.c | 9 +++++++++ > > xen/include/public/arch-x86/cpufeatureset.h | 2 +- > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > > index 01a15857b7..423a795d1d 100644 > > --- a/xen/arch/x86/msr.c > > +++ b/xen/arch/x86/msr.c > > @@ -316,6 +316,15 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val) > > *val = 0; > > break; > > > > + case MSR_IA32_PERF_CAPABILITIES: > > + if ( !cp->basic.pdcm ) > > + goto gp_fault; > > + > > + /* Only report LBR format. */ > > + rdmsrl(MSR_IA32_PERF_CAPABILITIES, *val); > > + *val &= MSR_IA32_PERF_CAP_LBR_FORMAT; > > Urgh.  We should have this info cached from boot.  Except caching on > boot is broken on hybrid cpus.  The P and E cores of an AlderLake report > a different format iirc (they differ between linear, and effective addr). > > Given the other pain points with hybrid cpus, I think we can ignore it > in the short term. > > > + break; > > + > > case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST: > > if ( !is_hvm_domain(d) || v != curr ) > > goto gp_fault; > > diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h > > index cd6409f9f3..5fdaec43c5 100644 > > --- a/xen/include/public/arch-x86/cpufeatureset.h > > +++ b/xen/include/public/arch-x86/cpufeatureset.h > > @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Supplemental Streaming SIMD Extensio > > XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ > > XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ > > XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages */ > > -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR */ > > +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR */ > > This is the bit which requires more toolstack logic to safely enable.  > Using 's' for off-by-default is fine if we want to get the series in now. > > But before we expose the MSR generally, we need to: > > 1) Put the configuration in msr_policy so the toolstack can reason about it > 2) Reject migration attempts to destinations where the LBR format changes > 3) Actually put the lBR registers in the migration stream So far we have allowed guests to enable LBRs (DEBUGCTLMSR.LBR) freely without any restrictions, and migration of guests using LBRs certainly won't work currently, hence I wonder why exposing the LBR format makes it worse as to require all this extra handling. I'm not saying it's not worth having, but IMO we should better spend the time in getting architectural LBRs available to guests and migration safe, and for architectural LBRs we don't really care about PERF_CAPABILITIES.LBR_FORMAT other than hardcoding it to 0x3f. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 20 14:58:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 14:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334386.558395 (Exim 4.92) (envelope-from ) id 1ns44v-0000cN-Vw; Fri, 20 May 2022 14:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334386.558395; Fri, 20 May 2022 14:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns44v-0000cG-T2; Fri, 20 May 2022 14:58:09 +0000 Received: by outflank-mailman (input) for mailman id 334386; Fri, 20 May 2022 14:58:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns44u-0000c7-KL for xen-devel@lists.xenproject.org; Fri, 20 May 2022 14:58:08 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 40fb233e-d84d-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 16:58:07 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 May 2022 10:58:04 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by DM6PR03MB5177.namprd03.prod.outlook.com (2603:10b6:5:22b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Fri, 20 May 2022 14:58:01 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::6d0d:b9fa:6b59:36d4]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::6d0d:b9fa:6b59:36d4%5]) with mapi id 15.20.5273.017; Fri, 20 May 2022 14:58:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40fb233e-d84d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653058687; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bwX4mSYgR9u+NMfq7GY0/SZf2/CRLgGzbn3igJFoc2w=; b=IwAriHVGAbSWdBJFRXNeo6xf/hKNFADBM1nW7N2gMi0Za1T86BFqd8W+ QFn0j/9V5UsPryI5pzCtqshbBv5BGdRCbGixfSKFq/aAxzHWJVR1GaghZ qLka62J7vXm+fsXXkHFFl3fQWp+yUOhceG5LuYDwFm1c/InDWx6MWcFeN s=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 71170316 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:skpnhaKiAxVSki+vFE+RopQlxSXFcZb7ZxGr2PjKsXjdYENS1z0Fy 2AcWWGDP/7YZ2fwetwjbYTk9B4H7JDRmNJnGQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qw2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 OkTsZqdTRYUB6nRpsUzekJEHjFCYKITrdcrIVDn2SCS52vvViK1ht9IXAQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMCFGvuajTNb9G5YasRmNPDSf ccGLxFoawzNeUZnMVYLEpMu2uyvgxETdhUH8QvK/fFuvQA/yiQh+4DUCNDnWueDXN5yrEiUv j7j4XXAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwASEy66R6QDJAGEBF2dFcIZ/6p9wQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPTdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:Vj5RpKyn+V3+GAz8Qq3LKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71170316" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCx8aMUPPU8Rh0eXi62dVitGRVANiJUxqhKM5fnGuuGwOwwCqqP2Ka1Yt6vV2EUjGNdUR+FBWXmz1IJC43JXpTJfhhdt0SWmva4J1kJM+qNuIi18FH4sLPju7XonEbpKIYyNKwQVuiAfasfaAEgnaXZBh/y382+D63GgHJLUVMWin1l2LZb5b0s++RyU5dBwRsojoWWqQnc3M1RnY3loobbuK75JjO5X6GqcQy76Y4mS7WN7Kx5UQFmC/4Gkby6Nz12o3+LSE2w9JHCuxqBHNFL8GiyVkqye/dfpEvr4ZoinSIOlQdUQO90C136ipWb8pMojNUpm/QTd/58kBwLBYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwX4mSYgR9u+NMfq7GY0/SZf2/CRLgGzbn3igJFoc2w=; b=UZiioI0PQ8qxM3MNI/eFMThzf3s9nVeCatbpJD3aOxJpyz/X0mBgRP/apl+3otbPEeS6ZXSOuxqAXJZjeE3rL/YELZV9oZGjD/Flci8K6dhrvDuR3uylxDiacDq7Iyr4mSYGli6h2FAWkqPRJUEnJCj46k3SyjycC6A/IZLqcXciha0K6Pgqb29kwmaJGYhu1r17Zm7/+JTMvfdHI+5jCt/mhhbw0JBe1HtXpD/3wcgfozWd9ahUyMi86j0fdXJWxEBXTJnGO+s4SfdJdIulY+oB26UfIevY8BD16Dh7oSswgEaeV0vvIGO8a/vV8C5MTriL85B0hdFjvFcJhCTT5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwX4mSYgR9u+NMfq7GY0/SZf2/CRLgGzbn3igJFoc2w=; b=hVafZZ+KmYLiAltaLaf0VeVYmwktq/cdpy7gxECLv0vQaLjWAxY10JyAsELD9bN23b+7sj0e47YhiEBwGEX+gEIbShZsuqETBbfET1X2XhN/GgaSnuTnO7wjkTopyod0gIQQmFBWuyb8NNKZ7bXEOrQEqByrdLdSMJBrpnJK4dc= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Thread-Topic: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Thread-Index: AQHYbE7auBjYBybQdEGztrNyxSKPiK0nzhyAgAACdoCAAArQgA== Date: Fri, 20 May 2022 14:58:01 +0000 Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> In-Reply-To: <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ab1671c-8779-4a8e-f267-08da3a7122c4 x-ms-traffictypediagnostic: DM6PR03MB5177:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5xQnMAL5jlLTIccNBuxF9yUAy6EzAbyk/JbkRt9mev8AIBeMJN2D4B6RPy1LQXMPrAhU2HDfTP3LKG4VAC2v0FBxq9FlZ8oo4zY5mXtLRygj2H9CG5KXOs1dsRzIBF+ZIeu7oK6/jgFhUZjSx5g7rR6B1uK0uUB+C1+SbqH/ZpZBSveII/xrxfyFic1Ztvd/6rkevnQkoDMl46o+7/S+kydZe2B0zVrhjyo53Le35ghCGiv+p1w7k8ji+MCpwGF6RPtjTkwRtRcARC2DDbHshLVs82Kpge7hPseBYNSFKJUgENHoVTGRkL76GYy1S9mB5sPJWKdxvPBs9jWocbMonMk0YsZjrmak0z0JwbPsgoAefXnCSgyTa+x4MdfHiE+2R7bnvS3Kx7oAjqNBypGM83gA4VWpeoTTg3Z3XVWHaNMZGfoZj3hR5ndFINRrZz+u+zYZ+NgFxoVN1jcSwhR/SzuIT4VFi8qfrHRZDf45V8hctFh3RjBjRROThjD2sQmHInOdnZhUNAuamIfEiQA636FFOC+oc+yTrTdftJ2z62SzUUShBGjIRkZKNLphKxH81e9pr3aVG1zm7itB9GkbmfH909lg5vKaKVOnj6JIB4Id3B6O5n6NGWsfKqhluVwR7rk2nosuUBru8sIsNLJSM0wQ9REZglIAQluN3gSpWt7B86q8kf5NrXcw0R2az5tWQnaex3moOwK3wwbd4+QufHseyvcuoGqFIwEsJBjkq5bQ4dTswxxapkJ5mFLYlB9HVfPXvpHXfpUDUIf4xnrA3g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(38100700002)(38070700005)(83380400001)(36756003)(31686004)(508600001)(2906002)(5660300002)(186003)(4326008)(76116006)(66446008)(8676002)(2616005)(316002)(31696002)(6916009)(54906003)(91956017)(8936002)(86362001)(66946007)(6506007)(71200400001)(26005)(53546011)(82960400001)(122000001)(66556008)(66476007)(64756008)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?alVXdS9YeCtzclBUQjRmMFVUSHBrdFVJRlNXRVpvazFTUXFFRlE2ZmZpRjVV?= =?utf-8?B?ZTBWaEhuWjYxNXRTZk54UHRoT0FPd1ZpaEFXMlZndjh2ZE1xTDdpTkdlcjVX?= =?utf-8?B?U3d5bTNwdmw2bXlEK2VreGIycmw3S014Rjl6cXBsR2pSdnArQ0tzbUtJN1pn?= =?utf-8?B?bzFMRGJvVUZyZDA2dVExK0FVTlJEb09VdWdEenZtN1NHZFI1VWlHdFg2YTF0?= =?utf-8?B?bDgydkRpYkZzdGovVEdkVlZpU096dHpTckNDaFZnTkE3d1paeXpOUzIrdllm?= =?utf-8?B?VzUzZ0E5M254aWxJdEZkSE52N2UzOHpyTlh4NmpQNlQ4UWhRbjNvNWpDc0kz?= =?utf-8?B?ajZGMTh6Q0FnSEg5ZWhpc2NmN3l4czVZcmxVQkN6dTVmNHpnNEVvWkMzWjNU?= =?utf-8?B?dXhFYTErUHAxVDdNVnJ3QmRhUUlUM1N5eXpPS1BjZEF3U01ZVUp1UzA2OE9y?= =?utf-8?B?eVQyQStPVXUwSnhoVndYdDQ2ZlRYRnU2VENDUlhIM01ZelhKT1Z1RG94MDhi?= =?utf-8?B?dm0zejZVMzY2OXJDMTk0aUg0RDRFWUdMYVQ4clJTZUR0MDdjcjNMVTV0THhn?= =?utf-8?B?b1EvZGI3WUZ2YytCNUZZM1NRMUJjeXRTcmtmclZIek90RnFFYzFvMWdWdmdO?= =?utf-8?B?SFlYWUQwRlZTand2eGRaZG9qZStrRnJkY2dTTFdlVVZqY2xlWGFmdnY5VFRM?= =?utf-8?B?a0dRa0FPQmFWMFc2MDNQckhYL3JoSGVyTDdOWUR6TDdOMzIxMU5zKzhJS2tp?= =?utf-8?B?OFB0d21aWG1tckE4SGdSMjNKSDZVa01qR3UyV2ZjYm9vb3pTWEhUSmoxcXht?= =?utf-8?B?WTI2NEsvUFJEcHFqUGNWMmxmaXMzcUphSm9ZdnU2bzRNcm56eklSLzYxLzhV?= =?utf-8?B?WjlKU3o1WTNuY2tGOWE3a3VWMnc3WjFwV3JDeVR0RklYVDF1N2ZVY0JWeDJV?= =?utf-8?B?NzFKdkRnS0xrZ2NRUm5Pd2Z0UHI3czNEWVNvUFlKUGRoZTRoNWZnLzBKa0Fj?= =?utf-8?B?MzkzVGFuUXhwQXpNWHc1RTNoeGNleVpodlFyenVxRFQyQkd5ZkpmZmRZY1o1?= =?utf-8?B?NVZObnpTcC8reVVheEFId2ZCZjlmRG9ISThzdHlaM1VTdkpPeHcwaXdrRzhJ?= =?utf-8?B?N2xuamFwTDR0Y2oraUVXY01vbWhzME9PSWV3NnFGekh3Sm9odVcxL3NiWXB2?= =?utf-8?B?YitVT3p1T3VTcitHakRacHZiS0gweVhaU2VEdkwvOHhGTHVIQ3NBQlpQWVQ1?= =?utf-8?B?M0RXVEtqbVR4RlVWUFc1NVRGYWFKSGl6aW0wNnU3RExXQkNHcVZybGw5UEhJ?= =?utf-8?B?ZDlTcGdRMUVJR0l6NnkrZkJUdTBSbFlIVGZUb3JvQ2F0NnYvYlNmVUlVS2Vz?= =?utf-8?B?MDdJdS8vd1U4TmI1RmVvMlF1aTJiMG5QdEp3bnp2VjAwbW0xSndZU3dKbDhK?= =?utf-8?B?bEhzY2c2ODhLR21jZ3BiRksvVHB2UlJCUGR1NWtUT2FyczhLQUYyZXMxMGVD?= =?utf-8?B?cE56RDkyL2IrMzJLelpoOTRLRVY3am5DYlNkcWx2ejNYZWtEWG9hSkNZK0hh?= =?utf-8?B?bWk0V0FnNFVTUGx1SlZNQ2xPMkZ4NytzWHo1bmJTTWRRUGcydVVCZ0d1QlBL?= =?utf-8?B?UDFRTHdHZVk3NnFRbWIrS0ZyekJtZ0hZckVsOEpOdXd5STkrZm5JM0lESU1z?= =?utf-8?B?M2NSWjQvdVFudkg0OHdRUTU4OE0wanM0djVwRCtYNDZZZEtuRHVyRVpOUDJS?= =?utf-8?B?b2lQVmJyQkVGN1RmZm9XVExUYkVWa0dLaWdTdmZEMWdxWVNiSFpYZEdOTFky?= =?utf-8?B?Wk9Nek9CNVhtSXpMZzNlc0dPUVlBa3J2N3p2cVdqQnhoWGpucWVqdGQyVlA5?= =?utf-8?B?WmxITzMzZzhQM212OEgxTXBhbkVDRk53a0I3bUNTMkR3SHh3ZVBLTUpQMkN4?= =?utf-8?B?SWpyR01vU1Z1L3R3bm1HUnVMTkFWbGg5VE1icWZwY0M2cTkxc1RtM08vSTQw?= =?utf-8?B?V2NzbEpQUUpvRVFDRUNFbGk1azlRSUNBVnNBSXJmNTY5d29lYXFmaEFKN3RQ?= =?utf-8?B?U20xUVJYYUdIK1dQa0xWVU5JSjJxODE5YjgvNStoeHYvcDlCb1p1YmNXaU1S?= =?utf-8?B?SWJ2UkFDTjNtMDZnSWwrZGNjRVB5Yk9LbWhxNWNEbVduUFZvRVdYdHhlWEdn?= =?utf-8?B?QnlyaEp0ZlRUVnp3dzdQc0FrWmh3TmJidzdjWDRNZGozdTZaeThKSGRCY29R?= =?utf-8?B?cFJycUJPTE1FUE0wNm9tREN6QWs1UVlwZTBJRWMyOW5hNU9IeW9vMW05RGc5?= =?utf-8?B?WWEzcmQ2NWFTSlNCZDRmcUFQL0VXbDByaktYeVN1MlY1QWhQZDdXSDNsc21F?= =?utf-8?Q?OwnkL/4HIZsy0A30=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <166DC331312CAB4FB740FBB23304FACD@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab1671c-8779-4a8e-f267-08da3a7122c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 14:58:01.5238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HWVqkhNS/5lDVrPeFJbPoRCd8ntYQcEa9R1y2X93QgOjc6xwSITsFcZGZ6t5jOc9Y68NXreq/8zFlFhGSk2GARwm4NcPB7e50c99nGOgqoE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5177 T24gMjAvMDUvMjAyMiAxNToxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA1LjIwMjIg MTY6MTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyMC8wNS8yMDIyIDE0OjM3LCBSb2dl ciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4gLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2 L2NwdWZlYXR1cmVzZXQuaA0KPj4+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgNCj4+PiBAQCAtMTM1LDcgKzEzNSw3IEBAIFhFTl9DUFVGRUFUVVJFKFNT U0UzLCAgICAgICAgIDEqMzIrIDkpIC8qQSAgU3VwcGxlbWVudGFsIFN0cmVhbWluZyBTSU1EIEV4 dGVuc2lvDQo+Pj4gIFhFTl9DUFVGRUFUVVJFKEZNQSwgICAgICAgICAgIDEqMzIrMTIpIC8qQSAg RnVzZWQgTXVsdGlwbHkgQWRkICovDQo+Pj4gIFhFTl9DUFVGRUFUVVJFKENYMTYsICAgICAgICAg IDEqMzIrMTMpIC8qQSAgQ01QWENIRzE2QiAqLw0KPj4+ICBYRU5fQ1BVRkVBVFVSRShYVFBSLCAg ICAgICAgICAxKjMyKzE0KSAvKiAgIFNlbmQgVGFzayBQcmlvcml0eSBNZXNzYWdlcyAqLw0KPj4+ IC1YRU5fQ1BVRkVBVFVSRShQRENNLCAgICAgICAgICAxKjMyKzE1KSAvKiAgIFBlcmYvRGVidWcg Q2FwYWJpbGl0eSBNU1IgKi8NCj4+PiArWEVOX0NQVUZFQVRVUkUoUERDTSwgICAgICAgICAgMSoz MisxNSkgLypTICBQZXJmL0RlYnVnIENhcGFiaWxpdHkgTVNSICovDQo+PiBUaGlzIGlzIHRoZSBi aXQgd2hpY2ggcmVxdWlyZXMgbW9yZSB0b29sc3RhY2sgbG9naWMgdG8gc2FmZWx5IGVuYWJsZS7C oA0KPj4gVXNpbmcgJ3MnIGZvciBvZmYtYnktZGVmYXVsdCBpcyBmaW5lIGlmIHdlIHdhbnQgdG8g Z2V0IHRoZSBzZXJpZXMgaW4gbm93Lg0KPj4NCj4+IEJ1dCBiZWZvcmUgd2UgZXhwb3NlIHRoZSBN U1IgZ2VuZXJhbGx5LCB3ZSBuZWVkIHRvOg0KPj4NCj4+IDEpIFB1dCB0aGUgY29uZmlndXJhdGlv biBpbiBtc3JfcG9saWN5IHNvIHRoZSB0b29sc3RhY2sgY2FuIHJlYXNvbiBhYm91dCBpdA0KPj4g MikgUmVqZWN0IG1pZ3JhdGlvbiBhdHRlbXB0cyB0byBkZXN0aW5hdGlvbnMgd2hlcmUgdGhlIExC UiBmb3JtYXQgY2hhbmdlcw0KPiBTaW5jZSB0aGlzIGNvdWxkIGJlIHF1aXRlIHJlc3RyaWN0aXZl LCBhbmQgc2luY2UgcGVvcGxlIG5lZWRpbmcgdG8ga25vdw0KPiB0aGV5IG5lZWQgdG8gaGlkZSB0 aGlzIGZlYXR1cmUgZm9yIG1pZ3JhdGlvbiB0byB3b3JrLCBJIGd1ZXNzIHRoaXMgd291bGQNCj4g ZnVydGhlciB3YW50IHF1YWxpZnlpbmcgYnkgImRpZCB0aGUgZ3Vlc3QgYWN0dWFsbHkgdXNlIExC UnMgc28gZmFyIj8NCg0KSW4gcHJhY3RpY2UsIGl0J3MgZXZlcnkgbWFqb3IgZ2VuZXJhdGlvbiAo InRvY2siIG9uIEludGVsJ3Mgb2xkIG1vZGVsKSwNCnNvIGlzbid0IGFjdHVhbGx5IGxpbWl0aW5n IHRoZSBraW5kcyBvZiBoZXRlcm9nZW5lb3VzIHNldHVwcyB1c2VkIGluDQpwcm9kdWN0aW9uLsKg IChNaWdyYXRpb24gZ2V0cyBzdGVhZGlseSBsZXNzIHN0YWJsZSB0aGUgZnVydGhlciBhcGFydCB0 aGUNCnR3byBDUFVzIGFyZS4pDQoNCkFzIHRvIGR5bmFtaWMsIG5vIC0gdGhhdCB3b3VsZCBiZSBh IHNlY3VyaXR5IGJ1ZyBpbiBhIGNsb3VkIHNjZW5hcmlvLA0KYmVjYXVzZSB0aGVyZSBtdXN0IG5v dCBiZSBhbnl0aGluZyB0aGUgZ3Vlc3QgY2FuIGRvIHRvIGludGVyZmVyZSB3aXRoDQp0aGUgbWFu YWdlYWJpbGl0eS4NCg0KVXNlIG9mIExCUiBpcyByYXJlLCBhcyBkZW1vbnN0cmF0ZWQgYnkgdGhl IGZhY3QgdGhhdCBub29uZSBoYXMNCmNvbXBsYWluZWQgYWJvdXQgdGhlIGZhY3QgdGhhdCBtaWdy YXRpbmcgc3VjaCBhIFZNIHdpbGwgbWFsZnVuY3Rpb24uDQoNCkFzIHdlIG5vdyBoYXZlIGEgd2F5 IG9mIHJlcG9ydGluZyAibm8gbW9kZWwtc3BlY2lmaWMgTEJSIiwgSSdtIHRlbXB0ZWQNCnRvIHN1 Z2dlc3QgdGhhdCBWTXMgZ2V0IG5vIExCUiBieSBkZWZhdWx0LCBhbmQgc29tZW9uZSB3YW50aW5n IExCUiBoYXMNCnRvIG9wdCBpbiwgd2hpY2ggaXMgYWxzbyBhbiBleHBsaWNpdCBhZ3JlZW1lbnQg dG8gdGhlIG1pZ3JhdGlvbiBsaW1pdGF0aW9uLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri May 20 15:22:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 15:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334398.558407 (Exim 4.92) (envelope-from ) id 1ns4Sf-0003os-1G; Fri, 20 May 2022 15:22:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334398.558407; Fri, 20 May 2022 15:22:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Se-0003ol-UZ; Fri, 20 May 2022 15:22:40 +0000 Received: by outflank-mailman (input) for mailman id 334398; Fri, 20 May 2022 15:22:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Sd-0003ob-4c for xen-devel@lists.xenproject.org; Fri, 20 May 2022 15:22:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad40d70e-d850-11ec-837e-e5687231ffcc; Fri, 20 May 2022 17:22:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad40d70e-d850-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653060157; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Fn6fsFdz+u8WTlc5u0ycVtt/0N0wQVoIjarOnUcgIpU=; b=Jdd2KRl80L5b5ei/Q1QrtiGp6mfph7fBhE3BgUHZhryMHg9DmZDKPZ2v 4zfpTtTCeAMbua+EDAvbNIHH41V3dk5ZKYxduqgMtA+XrvwEHCdv2hRge 8gQRM36HbdHNTQKdJFgI5VALWcanBrnE7IC+v9n5qfvyMoZMD4BoZSOZy s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71798530 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:DZKpYKkSIIEjrhbtsfE6B6bo5gwBJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJMUG2Cb/6JMGbzeIhxPYng90gFvJCAzNA1HQVpqn02HiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVvV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYb1wZGIeLw70nChQfKB1aBLIY3I6aCC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJGMGU+PEmbO3WjPH8FEqouosDv2UXeWBNc63e3vJM8wlncmVkZPL/Fb4OOJ43iqd9utkSFo mPL+UzpDxdcM8aQoRKe6W6ljOLLmSL9WaoRGae++/osh0ecrkQZBQcKT1K9rb+8g1SnRtNEA 0UO/2wlqq1a3EuvQ9rmVhu0ukmYrwUcUNpdFe49wAyVw6+S6AGcbkA6STpGZM0jpdUBbzUg3 V+UnPvkHTVq9raSTBq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIayitD2Ai3h2 DCioy03hrFVhskOv4254FTGjjTqqYLASgod7x/SGGmi62tRZoG/YJezwUPG9vsGJ4GcJnGeu FAUls7Y6/oBZaxhjwTUHr9LRuvwoa/YbnuM2jaDAqXN6RyLoE6FV8cLuQsnKQBSDuI9ZmHNU RL67FY5CIBoAJe6UUNmS9vvVp9ylPC+SYuNuuP8NYQXPMUoHOOT1GQ3PBPLgTiw+KQ5uftnU ap3Z/pAGprz5U5P6DOtD9kQ3rYwrszV7TOCHMurp/hLPFf3WZJ0dVvmGAHXBgzBxPnYyDg5C v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6r8ZwGJr7de1E4QgnN7sM9Jpt4JORYc1l9zL+Ur hlRpGcFoLYAuZE3AVrTMS0yAF8edZ1+sWg6LUQR0aWAghAejXKUxP5HLfMfJOB/nMQ6lKIcZ 6RVKq2oX6UUIhyaqmt1UHUIhNE7HPhdrVnVZHTNjflWV8MIejElDfe/JVuzpHdUX3Xr3Sb8y pX5vj7mrVM4b1wKJK7rhDiHkztdYVB1dDpOYnb1 IronPort-HdrOrdr: A9a23:ZBQqxKE/OM+w1cmppLqE7seALOsnbusQ8zAXP0AYc3Jom+ij5q STdZMgpHjJYVcqKRQdcL+7VZVoLUmxyXcx2/h2AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IOceEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.91,239,1647316800"; d="scan'208";a="71798530" Date: Fri, 20 May 2022 16:22:23 +0100 From: Anthony PERARD To: Oleksandr CC: , Julien Grall , Wei Liu , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: Re: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm Message-ID: References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-3-git-send-email-olekstysh@gmail.com> <755f075c-db1f-bcd3-9f0d-f5979237e431@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <755f075c-db1f-bcd3-9f0d-f5979237e431@gmail.com> On Thu, May 19, 2022 at 08:16:16PM +0300, Oleksandr wrote: > On 18.05.22 14:05, Anthony PERARD wrote: > > On Tue, May 03, 2022 at 08:26:03PM +0300, Oleksandr Tyshchenko wrote: > > > + for (i = 0; i < d_config->num_disks; i++) { > > > + libxl_device_disk *disk = &d_config->disks[i]; > > > + > > > + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { > > > + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); > > > + if (!disk->base) > > > + return ERROR_FAIL; > > > + > > > + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); > > > + if (!disk->irq) > > > + return ERROR_FAIL; > > > + > > > + if (virtio_irq < disk->irq) > > > + virtio_irq = disk->irq; > > > + virtio_enabled = true; > > > + > > > + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, > > > + disk->vdev, disk->irq, disk->base); > > > + } > > > + } > > > + > > > + if (virtio_enabled) > > > + nr_spis += (virtio_irq - 32) + 1; > > Is it possible to update "nr_spis" inside the loop? > > yes, but ... > > > > The added value > > seems to be "number of virtio device + 1", > > ... not really ... > > > > so updating "nr_spis" and > > adding +1 after the loop could work, right? > > ... from my understanding, we cannot just increment nr_spis by "one" > inside a loop, we need to calculate it. > > > Something like that (not tested): > > uint32_t spi; > > ... > > spi = irq - 32; > if (nr_spis <= spi) > nr_spis = spi + 1; > > > Shall I update "nr_spis" inside the loop? > > Are you asking because of eliminating "virtio_enabled" and/or "virtio_irq" > locals? They are used down the code. I'm asking because the calculation doesn't really make sense to me yet. At the moment "virtio_irq-32+1" happen to be the "number of disk + 1" and we have "nr_spis += " which I don't think makes sense with the "+1". Doesn't "nr_spis" only need to be the highest irq value for the devices we're adding? (Maybe with +1) (also -32 because I think I understand what 32 stand for now) (also, the "num_irqs" loop just after this loop seems to do exactly that) But I think what this line of code needs the most is a comment. > > Also, what is "32"? Is it "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" ? > > Although currently "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" = "32", we cannot rely > on this (I mean to use "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" > > instead of "32"), because "32" has yet another meaning. This is an offset > for SPI, the values before 32 are for private IRQs (PPI, SGI). Do you think it could be possible to name that value? I've seen other use of 32 in the same function that have probably the same meaning. But if you don't have a good name, I guess we can also live a bit longer with a plain "32". Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri May 20 15:30:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 15:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334407.558418 (Exim 4.92) (envelope-from ) id 1ns4Zx-0005Fx-Rx; Fri, 20 May 2022 15:30:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334407.558418; Fri, 20 May 2022 15:30:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Zx-0005Fq-O4; Fri, 20 May 2022 15:30:13 +0000 Received: by outflank-mailman (input) for mailman id 334407; Fri, 20 May 2022 15:30:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Zx-0005Fg-5U; Fri, 20 May 2022 15:30:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Zx-0001By-1F; Fri, 20 May 2022 15:30:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4Zw-0006DJ-OQ; Fri, 20 May 2022 15:30:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns4Zw-0003V6-O0; Fri, 20 May 2022 15:30:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TDLG/oG0zhMJnWfgvxLP965M5OnLTIJpohDGjV/Kkf8=; b=SU6t8j47ohfy0mR6aqcyQGO825 BrhyTho5kaMntmTAV+8ixP1zz8NnuVX0ejvCPrHGtrtxY/4p0et4GSD9dQnZ3Ffo3apbTpr3JXmuw BixtUIz5kBUTxa4vfcLVjqXsjYyCZ8gPIuBtrkyNp8kNfJhfWkW3ls6qRts66q33hRoI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170605: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 15:30:12 +0000 flight 170605 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170605/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1123 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 15:47:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 15:47:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334418.558429 (Exim 4.92) (envelope-from ) id 1ns4qA-0006s0-EM; Fri, 20 May 2022 15:46:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334418.558429; Fri, 20 May 2022 15:46:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4qA-0006rt-Az; Fri, 20 May 2022 15:46:58 +0000 Received: by outflank-mailman (input) for mailman id 334418; Fri, 20 May 2022 15:46:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4q8-0006rn-L5 for xen-devel@lists.xenproject.org; Fri, 20 May 2022 15:46:57 +0000 Received: from sonic310-21.consmr.mail.gq1.yahoo.com (sonic310-21.consmr.mail.gq1.yahoo.com [98.137.69.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11718773-d854-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 17:46:54 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 15:46:51 +0000 Received: by hermes--canary-production-ne1-5495f4d555-xgn59 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5d25dbe75183c009d9335f93b2057068; Fri, 20 May 2022 15:46:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11718773-d854-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653061611; bh=dYvOsYj975WZtAhaXLvp5QnpcOqZNNHInEfhbuG4NHw=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=Cxjt1KXv3fLQrBLUITJrZ5qC0ekqzxNCzezQ5ytSEnMGtHDbX6Ox96Ul/yob6k7aMsu4LVyXY1lqmakYOHHkiLjcgJfWpTDbRwzkZWrZ9RDcg3zsv8IC4DiEPLeyKhttt+VtJ7iju0oOyWFAFgLdGu/M9aC/D6l7m4oShDyXho0PMK1u35ruEgKUG30iujIAXm8yxwV3ZbQ8in3CCW6E/RIY7iM2OCXOCaw1TGQq8GIEHUDUwB8r4020db4BrDrLJ/PCe6pb9KnC3nleAXLYKLBq+PpGW+G266MZmazeR8ssC8dXQKwBnRe9BQ1yQPuQJuoOgCbOel8/ml9Hw4dGxw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653061611; bh=H54F1szVjTyLu890ZQRCRRW7CSMdm2B8Nd3tknxxcLq=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=WK1zAniam0y5W1FFnOzY6sfOgAiw64JYID+e+/KodRW5+qoTKbL2ms/9sVdANM1DQy0fhl7dWBpYpqJCNx5f0dhDoKDmhkbQLM8QK491AEmILSNuCNuP8sM5nJFC0nackOix7GpmGQD13uuLqPNB0WBo7KI5sKt3ZhNua7H+pKqeNye8ciWKmmi+Spx1K/sBq8AF3JV1a69qg8LDRv+3bq2QxqrEdo0QO5/ZNskXaLOZiH8+vFV2wp4OvUxHu0X6/+59fC87ZnvJoCO+m4mf/sXI36RF8wcM9YjAhX7n0uutTJxuJylxQd2RBWEd+Cofl4ARY1Heute72T/TIrWdUA== X-YMail-OSG: HPcVJVgVM1mCYTQXmFkVArz9P8kXrdWw0VJjD7_O8Yt9gLvXdcGoVAgVsnjtVda ZcmBU1C4FgvUPaJHDwKfzvVVBkKQgTzbBM.DuWf01x0YT6khsIsczeih1dxtjw54XIPKkiTMj7MS uLS5OCgPmIe1XH6N3of6EBVtJObEB2X0Vywtjvybf2GQTYezKturPfx0ShGOOcIRJAr0Xl1r_OUN 6uLOAljW37OxjurFoRnfgNHjVaGPS9zd8MscSVBhMJA5MDj8YZa7QlPuAsroqL1Zj2cXhwA4SjPz 14CzkX_y0eCzoJoFlBaOvuIIMuqgibGcIkn.ra3g6p0ycS_HcHDdtHcE_FA8AaJjRPlThlSQCigm hU7vW.4rUtP7UgCXcNXAyjCxgJDyVWXXTAuneh0Cv7OGOanofBJRDvU5V2W7OdIkEZu_Ir5vGnVy Gi6IJG5mZcwJ8k4xbc6htu3v89neRWHGm3kRJcouYcJT_Hpn8cNKeLkoJd73qshLbNU85Tc5_I6C snQXcD.NxE5gzgdSuHtmRsdtML38hiZqUCZt4UCvT8zJE3HP.9SMi4uu.jhaEJRmZJHkilOKzens rkd90KNCkt6PGE9.22YoL0BD323ydMHiciQMcDcvg2.OtHYi9jsSzRc2tmNiY26RNJCZehBjMDhw RAT9sRAszt0DYBIe00LAsXXiwGtlgoLlLt20TJ9pQRxrGctc90y0iMr2XTErpJPMOfbHYTtLx5w8 651vi.NqbJ47fzVIS4ZNXnGJxxE7NcstLHQqtaKNrLcp2p8svw70peNxeDnFZEdqwHsDk5ELyJHl eJAY58HhEPxZIo0NSyvsTfEbQ8dCOWVQMjeFxYZXecN2nJUgRKh4enit_wzd.zL0eViRdYvfhCyi T.10g.zRJCVCU7.bkIfNJttIZSynG4GrxYWm.rHiy.kcxAV0pMZBSubgcSgaLID.l0NDWV4pfBab HCcNe1kX_enUO5fr9P.mgi7EwxbVbpeow.ediO1CTrZjSCQ00aflFcvedjhNnGNDZ6e7WYaBhfKg rhTHIauqxNDTMC3UEHQUJG08M_Jc.opTYAtDPH56Hqq5775xTqnt7e67UYPlHZl8_ktw1TiwzgSk ByF3NVo_A89AgpzJdkREadxZnKXES9heCBBMmDzI4nWG8Bg8JvDU9cs6OFv3yakh_romkCSG.XuB EnwcmpVWj2.lESiyvakzJo6k2hua4ETwv19Jpe9Zp0jh5M7Xrq760Bjx5S5gFGJWZI_B0uLCSm1B DheQXVfnfKfq_rEtiTIQmeses_ByNA_zdOumFhUlxevE9gMhHB5ZHMZGqPlyTGkwgr9.OjjLygWo l0wTmYLOchaI2MDuJdESTpIKMNsxRLLm2uQR7v7S.gA4kooZIZvnB4NP498elRPM3Hr_tMRKlh0e onxRhqiJr3zt4egFCEbmA6Fp7UpnMyIv5YUg9L2TKTwT_1cAOq0QbklAhwfcRkvZeOfSw759WG.J 3HIGUvWvAh7WiR9o5RhqubC455n3SFeVffOCDfBnVsJUajp39jwuHMZYXAFr9pVDwFtyDcvjVpG1 xbu8Oo3Cxp_PrSHPeuPsqGCzmIgKyTTDmK.F.Oo2q3p.WmFZcNm25pDqRXjx9V2VEUPGeVEqYea_ LAfZBFlioghP60yOJa3fUE_1b_R6gxymFWVZGS7lcRUeRiL0WUv6iFt8dfgPA56ko5GTkfhL_xxa sn1esF85gG41bs6BqSvBGSoduDurGj_vXgGWwJit.iUKiaFi6KlF2xKJXV6ceaNA9Phs6K5L9HdF 7qR9Krm5wCTL2a0OMsDZfupV9MFz5mnAqoId1Dd3ne5O1JbTAQQ7NBaVUAcV4lGy5sH_2_JMXu6x wddkEfnikU8w.offg7WTT0vKU.SRYgR.qwKhfyCAJwYAb5QC2XbLcfI9rKfeCbdQvV9nw6NBKJT3 BPmOdEsW20ttaQ7ow2lcwXDw6xWCL0AlOA9dqg7JPrF5WNc4PfQuydqPspQwhZtXyr5B8CqrAif5 SSl3LyW92_ASxvg0GOo1zYWxEq75eID9AY.IH05kiumPkszBAv4LcPhKVrNHt9N2QuTVgHSvoypd nhEzsQDVfkmgz7a_bgCcq.cOk1CHQ_K_zaHf2JZeUVtLmVi.0dMxLMxA2b3iwKNpJ_MquaVMtgDM wuJHLeKUg89Xspa4iCbfdvlcZTMn.wzNkaPIj.vqmAPJPOwahkX99dPNZrXQzskD0TUf_kdUiBAE 6NWuemK79OKSy X-Sonic-MF: Message-ID: <3efb9e54-b0d6-36db-c1c4-68d4f8f9a5ed@netscape.net> Date: Fri, 20 May 2022 11:46:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Chuck Zmudzinski Subject: [REGRESSION} Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability To: Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> Content-Language: en-US In-Reply-To: <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8943 On 5/20/2022 10:06 AM, Jan Beulich wrote: > On 20.05.2022 15:33, Chuck Zmudzinski wrote: >> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>> >>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>> those want >>>>>>>>> leaving unaltered. When preparing my earlier patch I did inspect them >>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>> observe the >>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() as the >>>>>>>>> only predicate). In fact, as said in the description of my earlier >>>>>>>>> patch, in >>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() to be >>>>>>>>> the >>>>>>>>> problematic one, which you leave alone. >>>>>>>> Oh, I missed that one, sorry. >>>>>>> That is why your patch would not fix my Haswell unless >>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>> >>>>>>>> I wanted to be rather defensive in my changes, but I agree at least >>>>>>>> the >>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>> >>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>> really don't have a strong opinion on that question, but I >>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>> should not override that, >>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>> an override would affect only the single domain where the >>>>>> kernel runs; other domains could take their own decisions. >>>>>> >>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>> bare metal has the same bad effect on system boot, so there >>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>> (but tell us "don't do that then"). >>>> Actually I just did a test with the last official Debian kernel >>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>> applied. In fact, the nopat option does *not* break the i915 driver >>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>> normally on both the bare metal and on the Xen hypervisor. >>>> That means your presumption (and the presumption of >>>> the author of bdd8b6c98239) that the "nopat" option was >>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>> had no effect on my system with Linux 5.16. So after doing these >>>> tests, I am against the aggressive approach of breaking the i915 >>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>> nopat did not break the i915 driver. Why break it now? >>> Because that's, in my understanding, is the purpose of "nopat" >>> (not breaking the driver of course - that's a driver bug -, but >>> having an effect on the driver). >> I wouldn't call it a driver bug, but an incorrect configuration of the >> kernel by the user.  I presume X86_FEATURE_PAT is required by the >> i915 driver > The driver ought to work fine without PAT (and hence without being > able to make WC mappings). It would use UC instead and be slow, but > it ought to work. I am not an expert, but I think the reason it failed on my box was because of the requirements of CI. Maybe the driver would fall back to UC if the add_taint_for_CI function did not halt the entire system in response to the failed test for PAT when trying to use WC mappings. >> and therefore the driver should refuse to disable >> it if the user requests to disable it and instead warn the user that >> the driver did not disable the feature, contrary to what the user >> requested with the nopat option. >> >> In any case, my test did not verify that when nopat is set in Linux 5.16, >> the thread takes the same code path as when nopat is not set, >> so I am not totally sure that the reason nopat does not break the >> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >> returns true even when nopat is set. I could test it with a custom >> log message in 5.16 if that is necessary. >> >> Are you saying it was wrong for >> to return true in 5.16 when the user requests nopat? > No, I'm not saying that. It was wrong for this construct to be used > in the driver, which was fixed for 5.17 (and which had caused the > regression I did observe, leading to the patch as a hopefully least > bad option). Hmm, the patch I used to fix my box with 5.17.6 used static_cpu_has(X86_FEATURE_PAT) so the driver could continue to configure the hardware using WC. This is the relevant part of the patch I used to fix my box, which includes extra error logs, (against Debian's official build of 5.17.6): --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-09 03:16:33.000000000 -0400 +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-19 15:55:40.339778818 -0400 ... @@ -430,17 +434,23 @@          err = i915_gem_object_wait_moving_fence(obj, true);          if (err) {              ptr = ERR_PTR(err); +            DRM_ERROR("i915_gem_object_wait_moving_fence error, err = %d\n", err);              goto err_unpin;          } -        if (GEM_WARN_ON(type == I915_MAP_WC && !pat_enabled())) +        if (GEM_WARN_ON(type == I915_MAP_WC && +                !pat_enabled() && !static_cpu_has(X86_FEATURE_PAT))) { +            DRM_ERROR("type == I915_MAP_WC && !pat_enabled(), err = %d\n", -ENODEV);              ptr = ERR_PTR(-ENODEV); +        }          else if (i915_gem_object_has_struct_page(obj))              ptr = i915_gem_object_map_page(obj, type);          else              ptr = i915_gem_object_map_pfn(obj, type); -        if (IS_ERR(ptr)) +        if (IS_ERR(ptr)) { +            DRM_ERROR("IS_ERR(PTR) is true, returning a (ptr) error\n");              goto err_unpin; +        }          obj->mm.mapping = page_pack_bits(ptr, type);      } As you can see, adding the static_cpu_has(X86_FEATURE_PAT) function to the test for PAT restored the behavior of 5.16 on the Xen hypervisor to 5.17, and that is how I discovered the solution to this problem on 5.17 on my box. >> I think that is >> just permitting a bad configuration to break the driver that a >> well-written operating system should not allow. The i915 driver >> was, in my opinion, correctly ignoring the nopat option in 5.16 >> because that option is not compatible with the hardware the >> i915 driver is trying to initialize and setup at boot time. At least >> that is my understanding now, but I will need to test it on 5.16 >> to be sure I understand it correctly. >> >> Also, AFAICT, your patch would break the driver when the nopat >> option is set and only fix the regression introduced by bdd8b6c98239 >> when nopat is not set on my box, so your patch would >> introduce a regression relative to Linux 5.16 and earlier for the >> case when nopat is set on my box. I think your point would >> be that it is not a regression if it is an incorrect user configuration. > Again no - my view is that there's a separate, pre-existing issue > in the driver which was uncovered by the change. This may be a > perceived regression, but is imo different from a real one. Maybe it is only a perceived regression if nopat is set, but imo bdd8b6c98239 introduced a real regression in 5.17 relative to 5.16 for the correctly and identically configured case when the nopat option is not set. That is why I still think it should be reverted and the fix backported to 5.17 until the regression for the case when nopat is not set is fixed. As I said before, the i915 driver relies on the memory subsyste to provide it with an accurate test for the x86 pat feature. The test the driver used in bdd8b6c98239 gives the i915 driver a false negative, and that caused a real regression when nopat is not set. bdd8b6c98239 can be re-applied if we apply your patch which corrects the false negative that pat_enabled() is currently providing the i915 driver with. That false negative from pat_enabled() is not an i915 bug, it is a bug in x86/pat. Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 16:18:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 16:18:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334426.558440 (Exim 4.92) (envelope-from ) id 1ns5KD-0002CS-Vm; Fri, 20 May 2022 16:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334426.558440; Fri, 20 May 2022 16:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5KD-0002CL-RI; Fri, 20 May 2022 16:18:01 +0000 Received: by outflank-mailman (input) for mailman id 334426; Fri, 20 May 2022 16:18:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5KC-0002CB-NG; Fri, 20 May 2022 16:18:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5KC-0002XL-Fc; Fri, 20 May 2022 16:18:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5KC-0000m0-1i; Fri, 20 May 2022 16:18:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns5KB-0001Qj-VE; Fri, 20 May 2022 16:17:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FfVnS/mx5prhN2TESZlgGVDBeiTCpH8xDzHx0XxSaOM=; b=1dZCLSC8ieLK6Oh5+O43cvYcyE GUcJbQllllHQv2ImSgswjXfBswGgMmI+ovf7AOwa9QrFg0BSHfINrMsV6JiEf0XZDuzthlaJCvQa4 Mq3pSlovx8Djrs3VxIJtjTVqTUisULmQ5mxRibFWR/olEJSBCvmJmTB84D/xC03+1tEk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170592: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3d7285a335edaf23b699e87c528cf0b0070e3293 X-Osstest-Versions-That: linux=b015dcd62b86d298829990f8261d5d154b8d7af5 From: osstest service owner Date: Fri, 20 May 2022 16:17:59 +0000 flight 170592 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170592/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170581 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170581 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170581 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170581 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170581 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170581 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170581 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170581 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux 3d7285a335edaf23b699e87c528cf0b0070e3293 baseline version: linux b015dcd62b86d298829990f8261d5d154b8d7af5 Last test of basis 170581 2022-05-19 21:41:24 Z 0 days Testing same since 170592 2022-05-20 06:42:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Herbert Xu Linus Torvalds Ondrej Mosnacek jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b015dcd62b86..3d7285a335ed 3d7285a335edaf23b699e87c528cf0b0070e3293 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri May 20 16:54:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 16:54:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334437.558451 (Exim 4.92) (envelope-from ) id 1ns5tB-0006KD-VV; Fri, 20 May 2022 16:54:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334437.558451; Fri, 20 May 2022 16:54:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5tB-0006K6-S6; Fri, 20 May 2022 16:54:09 +0000 Received: by outflank-mailman (input) for mailman id 334437; Fri, 20 May 2022 16:54:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5tA-0006Jw-95; Fri, 20 May 2022 16:54:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5tA-0003BB-17; Fri, 20 May 2022 16:54:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5t9-0002ev-HU; Fri, 20 May 2022 16:54:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns5t9-0005J7-H0; Fri, 20 May 2022 16:54:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aPEtnNaJYcUBrOkv3SYo0bPOLy/zrkgRQBlFemTvCLI=; b=kvESmVJ3WQTgaeuQVCoV/BhevG 9jRByTQL11kGbCdvPMPk6FCPxcJwSgDVem6bzpGrkAZHuM7y0SbvkAGsDaW0PBRnHoFwIvzZ/GT1V gO8zMJ+w18QuLovlaUTVf9GitiQIJuV6Sv9mr2s8KzZLyZaV281HJYzh8gLgytb7v2gk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170607: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 16:54:07 +0000 flight 170607 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170607/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1124 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 16:57:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 16:57:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334447.558462 (Exim 4.92) (envelope-from ) id 1ns5wk-0006wN-GN; Fri, 20 May 2022 16:57:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334447.558462; Fri, 20 May 2022 16:57:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5wk-0006wG-Cf; Fri, 20 May 2022 16:57:50 +0000 Received: by outflank-mailman (input) for mailman id 334447; Fri, 20 May 2022 16:57:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns5wi-0006wA-8X for xen-devel@lists.xenproject.org; Fri, 20 May 2022 16:57:48 +0000 Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk [2001:ba8:1e3::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7dcc39a-d85d-11ec-837e-e5687231ffcc; Fri, 20 May 2022 18:57:47 +0200 (CEST) Received: by chiark.greenend.org.uk (Debian Exim 4.89 #1) with local (return-path ijackson@chiark.greenend.org.uk) id 1ns5we-0005j9-0t; Fri, 20 May 2022 17:57:44 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7dcc39a-d85d-11ec-837e-e5687231ffcc From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <25223.51335.932439.379210@chiark.greenend.org.uk> Date: Fri, 20 May 2022 17:57:43 +0100 To: Anthony PERARD Cc: , Roger Pau Monne Subject: Re: [OSSTEST PATCH v2] ts-xen-build-prep: Install newer NASM version, to build OVMF In-Reply-To: <20220519105525.211344-1-anthony.perard@citrix.com> References: <20220519105525.211344-1-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) Anthony PERARD writes ("[OSSTEST PATCH v2] ts-xen-build-prep: Install newer NASM version, to build OVMF"): > Recent versions of OVMF now need a version of NASM that is newer > than the one available on Debian oldstable/buster. They want to use > NASM 2.15.05 [1], which is available in Debian stable/bullseye. The > need to use a newer version started with d3febfd9ade3 ("MdePkg: > Replace Opcode with the corresponding instructions."). > > There is no backport package available but the nasm package from > Debian Bullseye can easily be installed on Buster as it has few > dependencies and are already satisfied. > > [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 > ("BaseTools: Upgrade the version of NASM tool") LGTM assuming Roger is also happy... Acked-by: Ian Jackson -- Ian Jackson These opinions are my own. Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter. From xen-devel-bounces@lists.xenproject.org Fri May 20 17:13:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 17:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334459.558473 (Exim 4.92) (envelope-from ) id 1ns6C0-0000rY-Rl; Fri, 20 May 2022 17:13:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334459.558473; Fri, 20 May 2022 17:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6C0-0000rP-OO; Fri, 20 May 2022 17:13:36 +0000 Received: by outflank-mailman (input) for mailman id 334459; Fri, 20 May 2022 17:13:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6Bz-0000rJ-Mz for xen-devel@lists.xenproject.org; Fri, 20 May 2022 17:13:36 +0000 Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c0f7df9-d860-11ec-837e-e5687231ffcc; Fri, 20 May 2022 19:13:33 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 17:13:30 +0000 Received: by hermes--canary-production-ne1-5495f4d555-vwstm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 931cede65a94a3eeacd5e1369d2ebbf5; Fri, 20 May 2022 17:13:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c0f7df9-d860-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653066810; bh=ZnNjsgwavctM88RO14AtFlicUyxZdGakReSouC7+2Sc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=n+nql3SVs5x/p1JjpWauHUSqJi2Pid3hPFdX1IOjez3ueDnN2ynpZ1uff4AEOEVlBp1oX73SN9qaKzy5bthXTVsE5Q9d4a9IEnHuOcezmUTVK5azJrOK6SVklkHBEfUnLvjsTE2EggRm0uhvcqOtZq/izUSoP947Hx3dNNUFBsnl0TTtI58LvFumD53SZpw7hLqCOiHkmXPcybEROQ3BNfVXkGLwEvyqntvYMwH4a6yh2e+VgORaZRSoJSEcxNDXkYdTpKoFTOhk/jWFvcEzwhdt8JkTULXAtvu8Ol6FB7bYWbk11KHQsdnLXb4SCFLry5yVX1U6ZZdFrcFuWFzukA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653066810; bh=wNWZIHUcsrK1WLhY8BinSDrv8NSUTAF6pz2t2BSqdkk=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=WQXzUPFY0kZ/sFlFlir+Cg8C/PFS4akMMtn43YHi7FDlI2hu8HSfX+kWTvlA9BqF9ASifhMyIaz5J5/qBqRmTeDLFTC99sB4tEx0mx+McpvzAsfDRH4RZukSstgwt0ILBuRzinYU46iY0eNeOw6LjGkeltZfQLabK7WkBlD79n4EGrTvXh7ztoQ9TOM/SgW0MyEDEV+7gvcvPdMyAjr8oL7rRthFMOMsfkymxTIssde9gCmOGgnpSkGtTtAXRWm+uk6dx2HCCYobVBFJoPV3Aq65Z7p5qaHNfCRDAhdpFy4YfoX1MBiTt/Kqb2IcFx1nQ6d+7WfgyfANEbQvHCTlZQ== X-YMail-OSG: KAivCtcVM1mCPV0sW8DrhJ9VfMC0kqr9SKouDANqbDMh4JOy8BM94.sPxvNph9K QOVeWnvlX8AKgKMYjmePNFOu.nIpP0oj6zfeVN4vL6wdKGF3g.O2FqxVEhFza8htb1jgPeN8GRFp z1AcC_7jLQDxIk78vIxK9F6LSIBEySwwDlFWgGuasNsSD311EMZKgrrv6anJ0pz.CpIE3baA5Ec9 H.FGT7RSn5RFLvLB6oysmqb1Rf0b8x1p91kTv2Tg72gEj.sfNtDpaSSdsiwW.B9hWs.ZtwJwMJZD B60PqXWd11XS8i46iQwJIqKxW6T5.Q.bVizpjKVjNAQxNHhK7f5mGk46eXmvEQ2CsVarNNE2NlpN QRb4VY6551_9rI.UmRe93hpeKDR_N.jsa5KR4e357JDGOSyYHB_cbH5S5yqk7Kn8t..4vdVtkfSP 7aa7vTbA649lp9Aufed21Wdrmuy8agy93So4MSPcD0NIZjLousYCBg.DoGKFyLm2_Ads9jj8RgWj 17AsXzc2h..t8syNOhLfyJ0WuiYfALpco8V7e_I7_DaI2pYNcy_0rW3SNMkfEkLFeKlzAvUjlyeU V1XGa2fVX8gNvzadocGKwCHyWzsXxhvcdL3GIDULCpRM2CSF.zQAtvJwm7L.emeweBgdRvW8w.qi GvB4.zZNCTWToCpfC.Kb9qUi0YNlt6ZNo.vCkIIZ9bMHaEhCYJ.rDI7NoDAkqFdCK41W9OeHWAgK YxTXAEynDjY11i1Rx_I_tBpAyATAZcU_TZs7m0XCqsnNxB0WanRB.7EZpSsrIzRaMhNics2aWzcQ XShu4AnAF8kbLE_E1WaD1JDFUnhMRJQZJfifBDDavfs4JEqqCSgdtjwoxLDFj0q5oPMQVxIGZxW. bNTFLwYny54uAloS6aMwZ3468rJtJ43dIFw5Hu10hUkz9JkhPElnLvgoXdCpgzhru_sS6nOG.q60 SL3SSc6.1jkLEWRKMx1MFDCXuZgWUPHdxt2yQqfBz8HeuzGzF1_EdJjmTAR51NTUcoIPXZ08IIcX Rs1ZAQRBENtxeoR_MuELDhPwOExIvT6chIdyPFwLyACv3emk4ia3NN9p.JkmdRjWViWEdIC5RWKk XiROu1vujJBcrL06mVSjtuDcSnnYQDkipg5TQyx4p_nkpNzs6YHDmuvTGxrCaZIsC8Z8rPAXFxC8 mr32xjlD0f2ycT.257FxNdqifkl9Nglcnn4kEwDGF6fVKBJpvRsFXVffOwWbBk8WFjYZkKwxFVC6 jtftteVcZhBBZxRReIwN4TTVcxGmdErABPaLOCvx3lR9fPUtQQGZECjd537lAY993_32ILIZcP6M pIdNBwGZTflmkl80sZl_xSiuN17GRs9xQouAct2oCZ2_UmVxTBm51b92rPbKIC0nIlALSIVhh7SV k.cBYGvg8YiOJnDoy54TL4amAy9mIAkm1tAg5fUIqHmTbBYEIPgyRLIG04Q9GUmK1PdgwyXXdPwJ 8D4jbSmROS2dEkl5G_koSZGrEo5KIb_0zd64JlfRfFw4viJG4p80.ML29G7EPPjvEcXRyIL_C.X9 M0jmrz1BPbTyMk7WBuI.g7l4Jro1NnfQOUhZkaDJHrqI95mBVuAjwxK._iGO9grdcDgarAA7saQp aB.oIRm.5l1KuYPt4wdA4AUeL6dyhKgsGnZkzkUeW0EkPMXEYmn.V4ZzYMiZK0eX7YKXn2BtZn4h ybM1UP3FTn4gBhA5qaoxEqtB9mLZJI1oCuFZOMVOJ1Bli_DT2k35zrft0GYPDp9_81hrCd7uikC2 aRPMFtk9jKm1kxWb5JAVWYlH4ZdIJbvBqwdbU.teWpLEDQCzh6HIUkV0Mz0r6BAYPgife.5CoSNC xzr.NykytrT5B4eAksJFS87RIc_WL.220BSArWY8xFREq.hDOr3DQPYdnDJnPfJQ0xnEoWhsHvLw SKM42_M.5G82UvbhKeT06C1FoKYd3c.u0oswpPmDMhxdaSYg1LMEmdMCiyVFlKPTUddDryOcCS7p rlAledo3h0VluSYgEa9A17iitnUWLkI3.e3qY0M54FoiBYLKJEyXq.O2_omUN6vb5xhWoe342WSh EEyL0fFZYmh6iFujwJBYGDoIz_jGHI29m5epp4KsYEFSzRGOxlfhNYmf0E__EWJfRNNx9rr02y.p OP.Aosei6Nspa4dpNYZHEPp1ODfTIjdU_tHQWqFxRRB52wSjQKe7gJR6x4IKYADpcRGkhNkxqNec MhARqDbTWKM6MVg-- X-Sonic-MF: Message-ID: <0a2e61ea-a73c-bbdc-e7c7-5110162b39bb@netscape.net> Date: Fri, 20 May 2022 13:13:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [REGRESSION} Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US From: Chuck Zmudzinski To: Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3efb9e54-b0d6-36db-c1c4-68d4f8f9a5ed@netscape.net> In-Reply-To: <3efb9e54-b0d6-36db-c1c4-68d4f8f9a5ed@netscape.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 10220 I think this summary of the regression is appropriate for a top-post. Details follow below. commit bdd8b6c98239: introduced what I call a real regression which persists in 5.17.x Jan's proposed patch: https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ Jan's patch would fix the real regression introduced by bdd8b6c98239 when the nopat option is not enabled, but when the nopat option is enabled, this patch would introduce what Jan calls a "perceived regression" that is really caused by the failure of the i915 driver to handle the case of the nopat option being provided on the command line properly. What I request: commit Jan's proposed patch, and backport it to 5.17. That would fix the real regression and only cause a perceived regression for the case when nopat is enabled. In that case, patches to the i915 driver would be helpful but necessary to fix a regression. Regard, Chuck Zmudzinski On 5/20/2022 11:46 AM, Chuck Zmudzinski wrote: > On 5/20/2022 10:06 AM, Jan Beulich wrote: >> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>> >>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>> those want >>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>> inspect them >>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>> observe the >>>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() >>>>>>>>>> as the >>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>> earlier >>>>>>>>>> patch, in >>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>> to be >>>>>>>>>> the >>>>>>>>>> problematic one, which you leave alone. >>>>>>>>> Oh, I missed that one, sorry. >>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>> >>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>> least >>>>>>>>> the >>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>> >>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>> should not override that, >>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>> an override would affect only the single domain where the >>>>>>> kernel runs; other domains could take their own decisions. >>>>>>> >>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>> (but tell us "don't do that then"). >>>>> Actually I just did a test with the last official Debian kernel >>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>> normally on both the bare metal and on the Xen hypervisor. >>>>> That means your presumption (and the presumption of >>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>> had no effect on my system with Linux 5.16. So after doing these >>>>> tests, I am against the aggressive approach of breaking the i915 >>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>> nopat did not break the i915 driver. Why break it now? >>>> Because that's, in my understanding, is the purpose of "nopat" >>>> (not breaking the driver of course - that's a driver bug -, but >>>> having an effect on the driver). >>> I wouldn't call it a driver bug, but an incorrect configuration of the >>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>> i915 driver >> The driver ought to work fine without PAT (and hence without being >> able to make WC mappings). It would use UC instead and be slow, but >> it ought to work. > > I am not an expert, but I think the reason it failed on my box was > because of the requirements of CI. Maybe the driver would fall back > to UC if the add_taint_for_CI function did not halt the entire system > in response to the failed test for PAT when trying to use WC mappings. > >>> and therefore the driver should refuse to disable >>> it if the user requests to disable it and instead warn the user that >>> the driver did not disable the feature, contrary to what the user >>> requested with the nopat option. >>> >>> In any case, my test did not verify that when nopat is set in Linux >>> 5.16, >>> the thread takes the same code path as when nopat is not set, >>> so I am not totally sure that the reason nopat does not break the >>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>> returns true even when nopat is set. I could test it with a custom >>> log message in 5.16 if that is necessary. >>> >>> Are you saying it was wrong for >>> to return true in 5.16 when the user requests nopat? >> No, I'm not saying that. It was wrong for this construct to be used >> in the driver, which was fixed for 5.17 (and which had caused the >> regression I did observe, leading to the patch as a hopefully least >> bad option). > > Hmm, the patch I used to fix my box with 5.17.6 used > static_cpu_has(X86_FEATURE_PAT) so the driver could > continue to configure the hardware using WC. This is the > relevant part of the patch I used to fix my box, which includes > extra error logs, (against Debian's official build of 5.17.6): > > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-09 > 03:16:33.000000000 -0400 > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-19 > 15:55:40.339778818 -0400 > ... > @@ -430,17 +434,23 @@ >          err = i915_gem_object_wait_moving_fence(obj, true); >          if (err) { >              ptr = ERR_PTR(err); > +            DRM_ERROR("i915_gem_object_wait_moving_fence error, err = > %d\n", err); >              goto err_unpin; >          } > > -        if (GEM_WARN_ON(type == I915_MAP_WC && !pat_enabled())) > +        if (GEM_WARN_ON(type == I915_MAP_WC && > +                !pat_enabled() && !static_cpu_has(X86_FEATURE_PAT))) { > +            DRM_ERROR("type == I915_MAP_WC && !pat_enabled(), err = > %d\n", -ENODEV); >              ptr = ERR_PTR(-ENODEV); > +        } >          else if (i915_gem_object_has_struct_page(obj)) >              ptr = i915_gem_object_map_page(obj, type); >          else >              ptr = i915_gem_object_map_pfn(obj, type); > -        if (IS_ERR(ptr)) > +        if (IS_ERR(ptr)) { > +            DRM_ERROR("IS_ERR(PTR) is true, returning a (ptr) error\n"); >              goto err_unpin; > +        } > >          obj->mm.mapping = page_pack_bits(ptr, type); >      } > > As you can see, adding the static_cpu_has(X86_FEATURE_PAT) > function to the test for PAT restored the behavior of 5.16 on the > Xen hypervisor to 5.17, and that is how I discovered the solution > to this problem on 5.17 on my box. > >>> I think that is >>> just permitting a bad configuration to break the driver that a >>> well-written operating system should not allow. The i915 driver >>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>> because that option is not compatible with the hardware the >>> i915 driver is trying to initialize and setup at boot time. At least >>> that is my understanding now, but I will need to test it on 5.16 >>> to be sure I understand it correctly. >>> >>> Also, AFAICT, your patch would break the driver when the nopat >>> option is set and only fix the regression introduced by bdd8b6c98239 >>> when nopat is not set on my box, so your patch would >>> introduce a regression relative to Linux 5.16 and earlier for the >>> case when nopat is set on my box. I think your point would >>> be that it is not a regression if it is an incorrect user >>> configuration. >> Again no - my view is that there's a separate, pre-existing issue >> in the driver which was uncovered by the change. This may be a >> perceived regression, but is imo different from a real one. > > Maybe it is only a perceived regression if nopat is set, but > imo bdd8b6c98239 introduced a real regression in 5.17 > relative to 5.16 for the correctly and identically configured > case when the nopat option is not set. That is why I still think > it should be reverted and the fix backported to 5.17 until the > regression for the case when nopat is not set is fixed. As I > said before, the i915 driver relies on the memory subsyste > to provide it with an accurate test for the x86 pat feature. > The test the driver used in bdd8b6c98239 gives the i915 driver > a false negative, and that caused a real regression when nopat > is not set. bdd8b6c98239 can be re-applied if we apply your > patch which corrects the false negative that pat_enabled() is > currently providing the i915 driver with. That false negative > from pat_enabled() is not an i915 bug, it is a bug in x86/pat. > > Chuck From xen-devel-bounces@lists.xenproject.org Fri May 20 17:17:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 17:17:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334467.558484 (Exim 4.92) (envelope-from ) id 1ns6Ft-0001T7-Cn; Fri, 20 May 2022 17:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334467.558484; Fri, 20 May 2022 17:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6Ft-0001T0-99; Fri, 20 May 2022 17:17:37 +0000 Received: by outflank-mailman (input) for mailman id 334467; Fri, 20 May 2022 17:17:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6Fs-0001St-3p for xen-devel@lists.xenproject.org; Fri, 20 May 2022 17:17:36 +0000 Received: from sonic304-24.consmr.mail.gq1.yahoo.com (sonic304-24.consmr.mail.gq1.yahoo.com [98.137.68.205]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc681081-d860-11ec-837e-e5687231ffcc; Fri, 20 May 2022 19:17:34 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Fri, 20 May 2022 17:17:32 +0000 Received: by hermes--canary-production-ne1-5495f4d555-xbnpg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4cde7a491d1a07ad2c7d8298ef77e73b; Fri, 20 May 2022 17:17:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc681081-d860-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653067052; bh=ca7iPlJkCoStYqyWys5LDO2Gdak2vbwjABNP3QbxdJg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=RLP+eUn0luQR8MFMsK/Bu5ozIMe3R3FhPOqzUlCheTcgF25eEhykrJNUvPSs+a0W8xnMrI9rbHzkLZgVpJtbL5TP+M7Ze1WB3ndhlmODjBS/83tU91WiIEv7q+6a/gq3uI8u2FBODzcy8OZmJc3xLlVbRCVGvFowyXb4vUOxf/CFG2TdClzQETllOExsOb34u/KtnpLCvyhJXcnjAnOJ/KtcKn7YR3wMxjOmD7OXZgxcObjquGGwXrWP05Aie06o3y61XbVbs+uOsDt0kGobUDuta2ORf7o4ZE3vmQJnh0MlR32dGuxnxY6MTfFPorKsNJzKPGFrNzwU2c6wHxJwNw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653067052; bh=7j3FEybidpG6WjHNRSwkmMNeWZDsakO25VD+3F7N2fN=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=kmbnkkNnYg5sOtHb/xjdjF356Lx7YhHBck56jvGr0JFPI3CLpzpkJ1ZWBDvM1n92FHCRZsVb8tB0grNGXH/Es1KqY+cTfsm9CjEAWoadb3HaEiFmiLwKuGG5qhdR8+gCrhWu+8aFTXY5tPdUI31gXXTAD4ZLQVPGnL171CdHkN9ZE9sb94cRfUOIuoG2a5X+4tESTWVwMxK+dcKB/Z2o0GENJYUI6HBnrfR8EBq/JzDVzWCqup4++tV/QzqAHJaZubtqc8QtQ2FOtwG7GFZE0WrlNCLHo9kArDw3iTRi5gmKw9PxptiYnMacMunLO8V5v6zu8XTfEjJYjGIDVv4QBQ== X-YMail-OSG: H7OfiakVM1mSUOX8IbzsVvdwYO9oiQlgoDHPzQIgieY13RNtcqlf3ffrgLXFLu8 ZMIugdCyo6V0GHELne5XGXeClyex4va1MyN77hEwq2jv0KS3SO7bb_M1Vd83duLCAfrPVzKFozOb YcIYKgw_soHeb4CerZhH5QsT5fpB5zt5dfFpDBfg.spni553wE8rJhgRezws_aP_U26M8LkhDdJF gJiUUwWm9fj7FeTtpfcULoF4EG7oANqLNMgMZ9U0J2qlgPcN9SmWeMG43haVPHavlwpS4b7Su2_i fbV5NNEa2pt70yItIwncyqm1k4Pzy6BJoKfdBkVJBCG2uspzHLysvCFOeW6jb.IS5D9EeDGDOcPV lPp.nZKJQRiUNuIOIZgrOWtXwiZ3JjbUuytT5Yf9O9Yqfi1HY2328fALl9MutLaCZe15UpVnWHbc xfspJigMbnWbgmlIW3E69FHPnlqWnunkkVfucABP90PZZ7VJHaHX4CmX_bxdCu0qeLwCdrJl5DNU R6EKUiqvC6R8Sbf5b5xxXowWnb9FPUQFvxNcQOf.OowStsZIK51oIFxJpPwu2UOjziXkxNCEn.jn LXeQ87r9NRPwn2c_aYfpFO2GH_7mHKB9oPNECRevc4kzflfbBj57nZrsRLTIhxgFgTxhfQMgTL0O ueCdodwiGPgxtj2U58Y9diorXJ6AlbjFZgA1lbVf1AqNdT2AvFHSfvw.6FHsO02ewjbXM6QZh0YC Phr_zV4wXnF9fombQJPfbb3JFTeTUWSJ83G_0XYyKDdVIf.LGd.eQTpr6abmVwyTwPWgnMyWnt.D 4dZ2AEnzX6B1biKSHNRVrQaWrQ0mp0NDBgeYCGG6F_TetndAl7a_qZ7gFCErvbFMqaQKeWCBeXGO Ev0UmswUVcg.SORIjsr5XRRo1J5Y8sn2Hny35byVnolGAL1omtzpv2BC2dXYOJMxksX9lxzoUhiw rrPJYlqY4qAswEz6dM_7S7l_M5KH5vm8FXSJOHi9slxWUvphi.v0af_UwptMiM9A36z7nmZi6X.d 4Gb9jQ.NSCZaxWu1Bv5u92SFOzTSD2GWza4ZlGwtVBAEwiBIBqK4ZwmD07JPnrWWPFfn.mY7Bwr6 .cqwBuCJUJOiAOCSV3.mAX3.gM3RUuQ1xU_QPGCTBCBtKD8gW52Yp8l.0N8Wry9XHz6emY.Hqlln J8wSBkFwSq6azUKiZNtp1CA9kes7Stwwq1cNoIYUwthnzbD84Mp6wAT2a_.U10MdgXO..qOKaXzq IdGRsHQKX.s63.4U_sGMVLPjL2LrMP9nHyV.4vYxJJ8tsEpIfb8O00WVNOMaEXLgSZRPdhR6bZjU jQ.lQHx7IAUIvODcXDA.v1gsqok5cMZISxD.va0xMVrNKmzsCz.xA.eUgrJ2PvMYl80KXDGqGX8P orH5y_uyMjBPZiTBTOG5pjWx_6EHyglq3SHCJP.Ezpr9NH6tfG6U7GARFx.lqL_8ZFlehPTWHmrQ XaN60UihPwGuYhF9np8PS8nVPgt6f6BHjzezx6Z1a..YBsGFFenRdHwejTIVdCrt4v1HxRzWHQ5r xYqAwwKlhsbne7PSH5NIELGpSbwBHjww7vl9ZhEtdcji3Rhj8D5DYZlSj.qBxPUIKq5I5nbwydOb luZfq7cB5m22fajZUhwe8_1ZQTjqmTZ5V0KF.aeyBo6Pw02R0G.LBzrve7Jk6r3xmndggHaCDhse aU1g2pC.ycMbFjoxWsswE_W25RBpDQkHSkREvrMTcXWaNoZ7YuFxXuUm7xATDhGFuLTNm5gVz.u1 Uc9V2edW286TNHq93GuvbYLUKxYsWu2qjo9E8flfg24wGTioyXtzR4qYs4Z0MUmKel_ztXvuX5Gz i2JULnrN3Q04PPsmRd0a2i_O43nWcycPW6IQd5u6mjcgPsvD0RRsGKjZUzbZVobxVet.cExc3taN 7rndFk6AhHHvRWZWKkWj1ZudFIAnQ5tIjRjEQGCOBge.qFeqp7Orl5eODciqINjUnOepKsK6ndeU vG_3hOUVzOTLEiyOo93sEaxe_g7FCfM6cLG6gorqRnZUC27HFuQBIpzjVByfhe.6OPt6oe04wZYt SVmFJpwuUVe.VUN5geIHcrLJgvfABoIoW5qZKO3YTnGTR5VDgjojz3_1iVoGCbqoJJ3HpWcQTs0U .JiWE0WZa0x3jUi1dZoJRmz97nvCGnpcujPjIL1ZziNDsu0Ep7H7FEVYkKWpnf6iaaYSKU7f_YgR MVWkN9jRib.rqmGQ9Iw-- X-Sonic-MF: Message-ID: <3a69fa16-6b3e-e567-818c-30959e50e985@netscape.net> Date: Fri, 20 May 2022 13:17:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [REGRESSION} Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US From: Chuck Zmudzinski To: Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3efb9e54-b0d6-36db-c1c4-68d4f8f9a5ed@netscape.net> <0a2e61ea-a73c-bbdc-e7c7-5110162b39bb@netscape.net> In-Reply-To: <0a2e61ea-a73c-bbdc-e7c7-5110162b39bb@netscape.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 10603 On 5/20/2022 1:13 PM, Chuck Zmudzinski wrote: > I think this summary of the regression is appropriate for a top-post. > Details follow below. > > commit bdd8b6c98239: introduced what I call a real regression which > persists in 5.17.x > > Jan's proposed patch: > https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ > > Jan's patch would fix the real regression introduced by bdd8b6c98239 when > the nopat option is not enabled, but when the nopat option is enabled, > this > patch would introduce what Jan calls a "perceived regression" that is > really > caused by the failure of the i915 driver to handle the case of the > nopat option > being provided on the command line properly. > > What I request: commit Jan's proposed patch, and backport it to 5.17. > That > would fix the real regression and only cause a perceived regression > for the > case when nopat is enabled. In that case, patches to the i915 driver > would be helpful but necessary to fix a regression. Sorry again, I mean patches to i915 would be helpful but *not* necessary to fix a regression. Regards, Chuck Zmudzinski > > On 5/20/2022 11:46 AM, Chuck Zmudzinski wrote: >> On 5/20/2022 10:06 AM, Jan Beulich wrote: >>> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>>> >>>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>>> those want >>>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>>> inspect them >>>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>>> observe the >>>>>>>>>>> adjusted behavior (or else I couldn't have left >>>>>>>>>>> pat_enabled() as the >>>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>>> earlier >>>>>>>>>>> patch, in >>>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>>> to be >>>>>>>>>>> the >>>>>>>>>>> problematic one, which you leave alone. >>>>>>>>>> Oh, I missed that one, sorry. >>>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>>> >>>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>>> least >>>>>>>>>> the >>>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>>> >>>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>>> should not override that, >>>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>>> an override would affect only the single domain where the >>>>>>>> kernel runs; other domains could take their own decisions. >>>>>>>> >>>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>>> (but tell us "don't do that then"). >>>>>> Actually I just did a test with the last official Debian kernel >>>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>>> normally on both the bare metal and on the Xen hypervisor. >>>>>> That means your presumption (and the presumption of >>>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>>> had no effect on my system with Linux 5.16. So after doing these >>>>>> tests, I am against the aggressive approach of breaking the i915 >>>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>>> nopat did not break the i915 driver. Why break it now? >>>>> Because that's, in my understanding, is the purpose of "nopat" >>>>> (not breaking the driver of course - that's a driver bug -, but >>>>> having an effect on the driver). >>>> I wouldn't call it a driver bug, but an incorrect configuration of the >>>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>>> i915 driver >>> The driver ought to work fine without PAT (and hence without being >>> able to make WC mappings). It would use UC instead and be slow, but >>> it ought to work. >> >> I am not an expert, but I think the reason it failed on my box was >> because of the requirements of CI. Maybe the driver would fall back >> to UC if the add_taint_for_CI function did not halt the entire system >> in response to the failed test for PAT when trying to use WC mappings. >> >>>> and therefore the driver should refuse to disable >>>> it if the user requests to disable it and instead warn the user that >>>> the driver did not disable the feature, contrary to what the user >>>> requested with the nopat option. >>>> >>>> In any case, my test did not verify that when nopat is set in Linux >>>> 5.16, >>>> the thread takes the same code path as when nopat is not set, >>>> so I am not totally sure that the reason nopat does not break the >>>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>>> returns true even when nopat is set. I could test it with a custom >>>> log message in 5.16 if that is necessary. >>>> >>>> Are you saying it was wrong for >>>> to return true in 5.16 when the user requests nopat? >>> No, I'm not saying that. It was wrong for this construct to be used >>> in the driver, which was fixed for 5.17 (and which had caused the >>> regression I did observe, leading to the patch as a hopefully least >>> bad option). >> >> Hmm, the patch I used to fix my box with 5.17.6 used >> static_cpu_has(X86_FEATURE_PAT) so the driver could >> continue to configure the hardware using WC. This is the >> relevant part of the patch I used to fix my box, which includes >> extra error logs, (against Debian's official build of 5.17.6): >> >> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-09 >> 03:16:33.000000000 -0400 >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c    2022-05-19 >> 15:55:40.339778818 -0400 >> ... >> @@ -430,17 +434,23 @@ >>          err = i915_gem_object_wait_moving_fence(obj, true); >>          if (err) { >>              ptr = ERR_PTR(err); >> +            DRM_ERROR("i915_gem_object_wait_moving_fence error, err >> = %d\n", err); >>              goto err_unpin; >>          } >> >> -        if (GEM_WARN_ON(type == I915_MAP_WC && !pat_enabled())) >> +        if (GEM_WARN_ON(type == I915_MAP_WC && >> +                !pat_enabled() && !static_cpu_has(X86_FEATURE_PAT))) { >> +            DRM_ERROR("type == I915_MAP_WC && !pat_enabled(), err = >> %d\n", -ENODEV); >>              ptr = ERR_PTR(-ENODEV); >> +        } >>          else if (i915_gem_object_has_struct_page(obj)) >>              ptr = i915_gem_object_map_page(obj, type); >>          else >>              ptr = i915_gem_object_map_pfn(obj, type); >> -        if (IS_ERR(ptr)) >> +        if (IS_ERR(ptr)) { >> +            DRM_ERROR("IS_ERR(PTR) is true, returning a (ptr) >> error\n"); >>              goto err_unpin; >> +        } >> >>          obj->mm.mapping = page_pack_bits(ptr, type); >>      } >> >> As you can see, adding the static_cpu_has(X86_FEATURE_PAT) >> function to the test for PAT restored the behavior of 5.16 on the >> Xen hypervisor to 5.17, and that is how I discovered the solution >> to this problem on 5.17 on my box. >> >>>> I think that is >>>> just permitting a bad configuration to break the driver that a >>>> well-written operating system should not allow. The i915 driver >>>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>>> because that option is not compatible with the hardware the >>>> i915 driver is trying to initialize and setup at boot time. At least >>>> that is my understanding now, but I will need to test it on 5.16 >>>> to be sure I understand it correctly. >>>> >>>> Also, AFAICT, your patch would break the driver when the nopat >>>> option is set and only fix the regression introduced by bdd8b6c98239 >>>> when nopat is not set on my box, so your patch would >>>> introduce a regression relative to Linux 5.16 and earlier for the >>>> case when nopat is set on my box. I think your point would >>>> be that it is not a regression if it is an incorrect user >>>> configuration. >>> Again no - my view is that there's a separate, pre-existing issue >>> in the driver which was uncovered by the change. This may be a >>> perceived regression, but is imo different from a real one. >> >> Maybe it is only a perceived regression if nopat is set, but >> imo bdd8b6c98239 introduced a real regression in 5.17 >> relative to 5.16 for the correctly and identically configured >> case when the nopat option is not set. That is why I still think >> it should be reverted and the fix backported to 5.17 until the >> regression for the case when nopat is not set is fixed. As I >> said before, the i915 driver relies on the memory subsyste >> to provide it with an accurate test for the x86 pat feature. >> The test the driver used in bdd8b6c98239 gives the i915 driver >> a false negative, and that caused a real regression when nopat >> is not set. bdd8b6c98239 can be re-applied if we apply your >> patch which corrects the false negative that pat_enabled() is >> currently providing the i915 driver with. That false negative >> from pat_enabled() is not an i915 bug, it is a bug in x86/pat. >> >> Chuck > From xen-devel-bounces@lists.xenproject.org Fri May 20 17:28:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 17:28:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334476.558495 (Exim 4.92) (envelope-from ) id 1ns6Qj-00031r-HK; Fri, 20 May 2022 17:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334476.558495; Fri, 20 May 2022 17:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6Qj-00031k-EE; Fri, 20 May 2022 17:28:49 +0000 Received: by outflank-mailman (input) for mailman id 334476; Fri, 20 May 2022 17:28:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns6Qi-00031e-2L for xen-devel@lists.xenproject.org; Fri, 20 May 2022 17:28:48 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d9d6917-d862-11ec-837e-e5687231ffcc; Fri, 20 May 2022 19:28:46 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id r3so3531320ljd.7 for ; Fri, 20 May 2022 10:28:46 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id v20-20020ac25594000000b00477cdd77ac0sm475702lfg.175.2022.05.20.10.28.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 10:28:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d9d6917-d862-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=NWNUaA41yaQWJiq/W0Tib8y24DO7hyxO1VVhuKdkKxY=; b=mQIKg8tBkJU+FbTnQk5BIt6dMPfj3EPpOk0KgQTES74IPyBTQeb1GxsM0lx9pNDZnm bjLjMm0liEoy5YlL8R0c8Ded7Sw7ScFbaeapd/QFkHjWJYTzJ82aTZLpu7L7jPv05Ex5 fVq5K6BifqL+wUHgPLzr1vrrMkv74zcODeAolf7XkPwc4SBeAZxUplJDWlMsK680JhDi VTCd1N4HW5ub/1HZRH4awbBug3o9hm36UV0lLMh/MeyEEV0AEmjYNMSTSskpeHazfadj uHbusEFqudDz1PEmm4OicXBnCHLIoxWW5jL9JuP/+gwGSX7aE3Y6NHtN2y/fg62p9+xb dAeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NWNUaA41yaQWJiq/W0Tib8y24DO7hyxO1VVhuKdkKxY=; b=A3X5IMQSys9wCGVXHDrGEnXhfX3sGbuQlg1xb4Oq8EmcHz4VN+Kp8XdXAxLm+dC4gY K0IhOHDL/lYAW2IAGxBa2KPyJGW8Zsgf64fSBIIPoKWqCRcCEvFXGIVie8bbqwcwYDRr 5cwA8xJbStiIm33UtpoZOY15j9LWPhqiKVoKHLLk+SpZkABkuSLsW/12YLY3NpFy9dtm xONMjK2Wpt5B0Q3EFWXl/RLNXjX+uM0XwWbACqzFD5SQyuJnv556As8QzYFSoYad69bc WnaM4DN7ar7FvLUZoqIjVMZY34swpQvxloeK8s/GoJT4PwT11pYmz3ARjSAVZE4hNpf2 gJRw== X-Gm-Message-State: AOAM532iBn7i1i02y/9ryMT0ws9D4y+cQZ40whwJ1pe5YpE9GmWtw6np Y8b+E4uC+ZJzcX9TxXSXS0hm5AcRyiM= X-Google-Smtp-Source: ABdhPJwQ57iVP+QXbigt6TSa0K5uRpYg6zIB4wuK15rt9gy/Q5TPe8zFuNF2UnyLfDihl4RHyJ+Ocw== X-Received: by 2002:a2e:9ad5:0:b0:250:9be1:cc95 with SMTP id p21-20020a2e9ad5000000b002509be1cc95mr6148661ljj.79.1653067724073; Fri, 20 May 2022 10:28:44 -0700 (PDT) Subject: Re: [PATCH V8 1/2] libxl: Add support for Virtio disk configuration To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Wei Liu , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-2-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Fri, 20 May 2022 20:28:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 18.05.22 13:52, Anthony PERARD wrote: Hello Anthony > On Tue, May 03, 2022 at 08:26:02PM +0300, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This patch adds basic support for configuring and assisting virtio-mmio >> based virtio-disk backend (emulator) which is intended to run out of >> Qemu and could be run in any domain. >> Although the Virtio block device is quite different from traditional >> Xen PV block device (vbd) from the toolstack's point of view: >> - as the frontend is virtio-blk which is not a Xenbus driver, nothing >> written to Xenstore are fetched by the frontend currently ("vdev" >> is not passed to the frontend). But this might need to be revised >> in future, so frontend data might be written to Xenstore in order to >> support hotplugging virtio devices or passing the backend domain id >> on arch where the device-tree is not available. >> - the ring-ref/event-channel are not used for the backend<->frontend >> communication, the proposed IPC for Virtio is IOREQ/DM >> it is still a "block device" and ought to be integrated in existing >> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration >> logic to deal with Virtio devices as well. >> >> For the immediate purpose and an ability to extend that support for >> other use-cases in future (Qemu, virtio-pci, etc) perform the following >> actions: >> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect >> that in the configuration >> - Introduce new disk "specification" and "transport" fields to struct >> libxl_device_disk. Both are written to the Xenstore. The transport >> field is only used for the specification "virtio" and it assumes >> only "mmio" value for now. >> - Introduce new "specification" option with "xen" communication >> protocol being default value. >> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current >> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model > Is this still an issue? Yes, it is. Both LIBXL__DEVICE_KIND_VBD and LIBXL__DEVICE_KIND_VIRTIO_DISK are for disk devices, but they are quite different from toolstack PoV. They use different specifications/transports. The latter is for virtio-blk driver which is not xenbus driver. The way how both Virtio backend and frontend get configuration and communicate with each are completely different from Xen PV drivers. > Since v5, the "disk/vbd" kind is used. Also see > my comment about libxl_device_disk_get_path() regarding this. ok > > >> An example of domain configuration for Virtio disk: >> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, specification=virtio'] >> >> Nothing has changed for default Xen disk configuration. >> >> Please note, this patch is not enough for virtio-disk to work >> on Xen (Arm), as for every Virtio device (including disk) we need >> to allocate Virtio MMIO params (IRQ and memory region) and pass >> them to the backend, also update Guest device-tree. The subsequent >> patch will add these missing bits. For the current patch, >> the default "irq" and "base" are just written to the Xenstore. >> This is not an ideal splitting, but this way we avoid breaking >> the bisectability. >> >> Signed-off-by: Oleksandr Tyshchenko >> --- >> diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c >> index a5ca778..7fd98ce 100644 >> --- a/tools/libs/light/libxl_disk.c >> +++ b/tools/libs/light/libxl_disk.c >> @@ -163,6 +163,19 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, >> rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); >> if (rc < 0) return rc; >> >> + if (disk->specification == LIBXL_DISK_SPECIFICATION_UNKNOWN) >> + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; >> + >> + /* >> + * The transport field is only used for the specification "virtio" and >> + * it assumes only "mmio" value for now. When there will be a need to add >> + * "pci" support, we will need to remove the enforcement here and >> + * respective assert(s) down the code and let the toolstack to decide >> + * the transport to use. >> + */ >> + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) >> + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; > Could you check that `disk->transport` is unset when > `specification==xen` ? And probably return ERROR_INVAL in this case. yes, will do > > Also, I don't think you should overwrite the value set by an application > in _setdefault(). If `specification==virtio`, check first that > `transport` as a supported value (unknown or mmio) then you can then you > can set the `transport` value expected by virtio if it wasn't set by the > application. ( An example of this is done the function already when > enforcing qdisk for cdroms. ) I got it, will do I transform to something like that:     if (disk->specification == LIBXL_DISK_SPECIFICATION_XEN &&         disk->transport != LIBXL_DISK_TRANSPORT_UNKNOWN) {         LOGD(ERROR, domid, "Transport is only supported for specification virtio");         return ERROR_FAIL;     }     /* Force transport mmio for specification virtio for now */     if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) {         if (!(disk->transport == LIBXL_DISK_TRANSPORT_UNKNOWN ||               disk->transport == LIBXL_DISK_TRANSPORT_MMIO)) {             LOGD(ERROR, domid, "Unsupported transport for specification virtio");             return ERROR_FAIL;         }         disk->transport = LIBXL_DISK_TRANSPORT_MMIO;     } > >> + >> /* Force Qdisk backend for CDROM devices of guests with a device model. */ >> if (disk->is_cdrom != 0 && >> libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { >> @@ -317,6 +334,11 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, >> goto out; >> } >> >> + assert((disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO && >> + disk->backend == LIBXL_DISK_BACKEND_OTHER) || >> + (disk->specification != LIBXL_DISK_SPECIFICATION_VIRTIO && >> + disk->backend != LIBXL_DISK_BACKEND_OTHER)); > I'm not sure whether this assert() is useful. The value should already > be correct as we call _setdefault(). It seems like an unnecessary > potential crash at this point. agree, will drop > >> switch (disk->backend) { >> case LIBXL_DISK_BACKEND_PHY: >> dev = disk->pdev_path; >> @@ -330,7 +352,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, >> >> assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD); >> break; >> + case LIBXL_DISK_BACKEND_OTHER: >> + dev = disk->pdev_path; >> + >> + flexarray_append(back, "params"); >> + flexarray_append(back, dev); >> >> + assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK); >> + break; >> case LIBXL_DISK_BACKEND_TAP: >> LOG(ERROR, "blktap is not supported"); >> rc = ERROR_FAIL; >> @@ -386,6 +415,15 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, >> flexarray_append_pair(back, "discard-enable", >> libxl_defbool_val(disk->discard_enable) ? >> "1" : "0"); >> + flexarray_append(back, "specification"); >> + flexarray_append(back, libxl__device_disk_string_of_specification(disk->specification)); >> + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { >> + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); > I don't think this is a good assert(). If an application sets the wrong > "transport" for virtio, it should get an error, not crash. But I believe > in this case that _setdefault() could already check that "transport" is > correct, so there's probably no need to check the transport value here. ok, I can drop this. The reason why I put this assert is to draw developer's attention (who will implement pci transport in future) to the need to update code below. > >> + flexarray_append(back, "transport"); >> + flexarray_append(back, libxl__device_disk_string_of_transport(disk->transport)); >> + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base)); >> + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq)); >> + } >> >> flexarray_append(front, "backend-id"); >> flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); >> @@ -532,6 +570,49 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path, >> } >> libxl_string_to_backend(ctx, tmp, &(disk->backend)); >> >> + tmp = libxl__xs_read(gc, XBT_NULL, >> + GCSPRINTF("%s/specification", libxl_path)); >> + if (!tmp) { >> + LOG(ERROR, "Missing xenstore node %s/specification", libxl_path); > This mean that we introduce an hard error if we deal with a previous > version of libxl that didn't write this path. But we know that it meant > specification=xen, so could we default to "xen" when the node is > missing, rather than return an error? (It's mostly useful for developper > at this point as creating a vm with one version of libxl and keep > managing it with a newer version isn't really possible for now.) agree, will do. But maybe it is worth leaving debug print here? LOG(DEBUG, "Missing xenstore node %s/specification, assuming specification xen", libxl_path); > >> + goto cleanup; >> + } >> + if (!strcmp(tmp, "xen")) >> + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; >> + else if (!strcmp(tmp, "virtio")) >> + disk->specification = LIBXL_DISK_SPECIFICATION_VIRTIO; >> + else >> + disk->specification = LIBXL_DISK_SPECIFICATION_UNKNOWN; > That's a reimplementation of a generated function, > libxl_disk_specification_from_string() I believe ;-) indeed, will reuse Taking into the account both comments, the resulting code can look something like that:     tmp = libxl__xs_read(gc, XBT_NULL,                          GCSPRINTF("%s/specification", libxl_path));     if (!tmp) {         LOG(DEBUG, "Missing xenstore node %s/specification, assuming specification xen", libxl_path);         disk->specification = LIBXL_DISK_SPECIFICATION_XEN;     } else {         rc = libxl_disk_specification_from_string(tmp, &disk->specification);         if (rc) {             LOG(ERROR, "Unable to parse xenstore node %s/specification", libxl_path);             goto cleanup;         }     } > >> + >> + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { >> + tmp = libxl__xs_read(gc, XBT_NULL, >> + GCSPRINTF("%s/transport", libxl_path)); >> + if (!tmp) { >> + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path); >> + goto cleanup; >> + } >> + if (!strcmp(tmp, "mmio")) >> + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; >> + else >> + disk->transport = LIBXL_DISK_TRANSPORT_UNKNOWN; > That's libxl_disk_transport_from_string() I think. indeed, will reuse > >> + assert(disk->transport == LIBXL_DISK_TRANSPORT_MMIO); > Could you return an error instead of assert() here? yes, will do > >> + >> + tmp = libxl__xs_read(gc, XBT_NULL, >> + GCSPRINTF("%s/base", libxl_path)); >> + if (!tmp) { >> + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); >> + goto cleanup; >> + } >> + disk->base = strtoul(tmp, NULL, 10); >> + >> + tmp = libxl__xs_read(gc, XBT_NULL, >> + GCSPRINTF("%s/irq", libxl_path)); >> + if (!tmp) { >> + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); >> + goto cleanup; >> + } >> + disk->irq = strtoul(tmp, NULL, 10); >> + } >> + >> disk->vdev = xs_read(ctx->xsh, XBT_NULL, >> GCSPRINTF("%s/dev", libxl_path), &len); >> if (!disk->vdev) { >> @@ -575,6 +656,41 @@ cleanup: >> return rc; >> } >> >> +static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid, > FYI, "libxl_" prefix is for functions exported by the library. You could > use "libxl__" for functions used within the library or no prefix in this > case as it is static. I got it, will do > >> + char **path) >> +{ >> + const char *dir; >> + int rc; >> + >> + /* >> + * As we don't know exactly what device kind to be used here, guess it >> + * by checking the presence of the corresponding path in Xenstore. >> + * First, try to read path for vbd device (default) and if not exists >> + * read path for virtio_disk device. This will work as long as both Xen PV >> + * and Virtio disk devices are not assigned to the same guest. >> + */ > That mean, we can't have both virtio-disk and pv-disk, and there's going > to be weird error with device disappearing if one try to add a pv-disk > after adding a virtio-disk. I was thinking this wouldn't be a big issue (at least on production). I might be wrong, but what is a reason to assign to the guest the virtual devices of the *same* type (block device) using different virtualization techniques (Xen PV and Virtio)? > > Also, I don't know whether the function is called before a first device > is added, but it could be a potential issue as it would return an error > in that case. > > The path generated here are path that are only used by libxl, so it > probably doesn't matter which path is used, as long as there's a unique > path for a device implementation. (The different path might have been > useful in v4 of the series when there was a libxl-virtio-disk > implementation.) > > So, is there a reason to have different path? I think, the completely different guest's view of the virtualized device is a reason. If virtio-disk and pv-disk was only different in software implementation of the backend, I would reuse LIBXL__DEVICE_KIND_VBD for virtio-disk. But their frontends are completely different. Or I really misunderstood the idea of device_kind? > Can we simply get rid of > this function? Without it, libxl_vdev_to_device_disk() won't work for virtio-disk. > > Maybe this is related to the path that a frontend would see, and we > probably don't want to have a pv-disk front-end trying to connect to a > virtio backend as it doesn't going to work. Yes, exactly > I wonder if the > "/libxl/*/device/" needs to use the same "device kind" name as the ones > seen by a guest. I didn't investigated that. > >> + *path = GCSPRINTF("%s/device/%s", >> + libxl__xs_libxl_path(gc, domid), >> + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD)); >> + >> + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); >> + if (rc) >> + return rc; >> + >> + if (dir) >> + return 0; >> + >> + *path = GCSPRINTF("%s/device/%s", >> + libxl__xs_libxl_path(gc, domid), >> + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); >> + >> + rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir); >> + if (rc) >> + return rc; >> + >> + return 0; >> +} >> + >> int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, >> const char *vdev, libxl_device_disk *disk) >> { >> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl >> index 2a42da2..f783cac 100644 >> --- a/tools/libs/light/libxl_types.idl >> +++ b/tools/libs/light/libxl_types.idl >> @@ -704,6 +716,10 @@ libxl_device_disk = Struct("device_disk", [ >> ("is_cdrom", integer), >> ("direct_io_safe", bool), >> ("discard_enable", libxl_defbool), >> + ("specification", libxl_disk_specification), >> + ("transport", libxl_disk_transport), > Could you add a comment here about "irq" and "base", that say that they > are for internal use by libxl and can't be modified? yes, will do > Is it possible > that in the future, an application like libvirt could potentially change > those two values and have libxl use them? I am not sure I understand that the libvirt is for, but I don't see a need for any external application to touch these fields. These are allocated internally in libxl_arm.c. > >> + ("irq", uint32), >> + ("base", uint64), >> # Note that the COLO configuration settings should be considered unstable. >> # They may change incompatibly in future versions of Xen. >> ("colo_enable", libxl_defbool), > Thanks, > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri May 20 18:17:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 18:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334484.558506 (Exim 4.92) (envelope-from ) id 1ns7BB-00082c-4c; Fri, 20 May 2022 18:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334484.558506; Fri, 20 May 2022 18:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns7BB-00082V-1U; Fri, 20 May 2022 18:16:49 +0000 Received: by outflank-mailman (input) for mailman id 334484; Fri, 20 May 2022 18:16:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns7B9-00082L-PF; Fri, 20 May 2022 18:16:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns7B9-0004fe-Mu; Fri, 20 May 2022 18:16:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns7B9-0006YZ-C9; Fri, 20 May 2022 18:16:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns7Az-0005Lf-Fe; Fri, 20 May 2022 18:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IcqQNdi28GupONgJ31oNykcKdUg00fZP5qxJT+xzPrA=; b=M/aHXZd78ddoKr9ZLTHCAjbWa5 uEuVF9U4RrkgTruMeMhCbLKcNM2z+Pm7Gwpyl5SibQfWF9lr+PiAWLM9Y1RYpM3P/t3S2+ejqO6EW bANLO/w433IBxoZFEHyF7Raxa6HSdWfq7vkNE7GP7YzLR3KpOgmiu18CUlEMUj7oxMks=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170608: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 18:16:37 +0000 flight 170608 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170608/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1125 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 19:10:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 19:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334494.558517 (Exim 4.92) (envelope-from ) id 1ns80r-0005Tc-63; Fri, 20 May 2022 19:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334494.558517; Fri, 20 May 2022 19:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns80r-0005TV-2x; Fri, 20 May 2022 19:10:13 +0000 Received: by outflank-mailman (input) for mailman id 334494; Fri, 20 May 2022 19:10:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns80p-0005TP-PA for xen-devel@lists.xenproject.org; Fri, 20 May 2022 19:10:11 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78065bfd-d870-11ec-837e-e5687231ffcc; Fri, 20 May 2022 21:10:10 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id u23so15931154lfc.1 for ; Fri, 20 May 2022 12:10:10 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s9-20020a056512202900b0047255d2114csm758168lfs.123.2022.05.20.12.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 12:10:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78065bfd-d870-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=uY1JkTGiJQDhGBUBrMHucysX+YL/hEg2cKvszOSGbKg=; b=DL0SgxQq1+2p5MTwvw58lD34raQZPL2AxZAuaqpc51bDoWgOIwz8ogH6TKbOsPj0FC 93jutYN1ZcFk4trCLB/2zV6sGC3aGIvvF6BU6YL5XH6DclaN+pNobLo4YDU8YznpnBSz gCDMfe6WQ9Yn38gZ6tSHKV19lQQHRFxMw4hf/BnGYEqJNPfVu0mregSk6wCYnEvkspIJ flYHSZKuKHeBgpbnpWEIYZefYq+5hj7Z/6+KcYYSK/brD/xQ3NuPWJyyt3eXaLbj4PWO EqOA9Q6nIduDlw3S2AAikQpEJxpParVtqDZ3kKtKHPGYPDf8TOqCNS6MoPSUILhvk82d APKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uY1JkTGiJQDhGBUBrMHucysX+YL/hEg2cKvszOSGbKg=; b=Agb1n7j2ya/DxjI+RmmOenjj6XW1PdIRu8TxHRW3nHuyHrDmkgq3v7DqtxpvZvUNbE hWWy1gfNYuY74V9bEgBEDEkmM21xfddDofyGVWKNnkrdDR1QxoE+QmJgbBOBIyie6etM 2exdYjK66f+YIntFX4AKUzCr2X0KK48fLHejAzeRRsjA8DlU5HMRWtAChJfTPfA3GwG7 AmrfkQYOFbQ8sUJK8Aty0abWcU/vLrHc9pYEfJwh4Lbg9WEJ4e7cfwinW3Sr4/hJSoZ9 bpmWwso/8e4NTD29wFqxaEXkjzC3dg2WfsOufQ/DbjpF3AatZ4tjl042Wu+y3HxHq95J /Rvg== X-Gm-Message-State: AOAM5331sW6dndrvihX363FLPCwXHaZqZBj/VkkhJKNHqcRVsccFshHd UtihohmC/Ve6RPerXFhejIg= X-Google-Smtp-Source: ABdhPJzJFLH3Wv6NCJvfvq7dbR869LU1BKFDeV9atETbL8Gd0RFruC7rnOrvLTRhDd98Fli+ihUrag== X-Received: by 2002:a05:6512:39c1:b0:473:be4f:726d with SMTP id k1-20020a05651239c100b00473be4f726dmr8116456lfu.259.1653073809875; Fri, 20 May 2022 12:10:09 -0700 (PDT) Subject: Re: [PATCH V8 2/2] libxl: Introduce basic virtio-mmio support on Arm To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko References: <1651598763-12162-1-git-send-email-olekstysh@gmail.com> <1651598763-12162-3-git-send-email-olekstysh@gmail.com> <755f075c-db1f-bcd3-9f0d-f5979237e431@gmail.com> From: Oleksandr Message-ID: <739287eb-9fc6-af3d-a511-69e048296291@gmail.com> Date: Fri, 20 May 2022 22:10:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 20.05.22 18:22, Anthony PERARD wrote: Hello Anthony > On Thu, May 19, 2022 at 08:16:16PM +0300, Oleksandr wrote: >> On 18.05.22 14:05, Anthony PERARD wrote: >>> On Tue, May 03, 2022 at 08:26:03PM +0300, Oleksandr Tyshchenko wrote: >>>> + for (i = 0; i < d_config->num_disks; i++) { >>>> + libxl_device_disk *disk = &d_config->disks[i]; >>>> + >>>> + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { >>>> + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); >>>> + if (!disk->base) >>>> + return ERROR_FAIL; >>>> + >>>> + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); >>>> + if (!disk->irq) >>>> + return ERROR_FAIL; >>>> + >>>> + if (virtio_irq < disk->irq) >>>> + virtio_irq = disk->irq; >>>> + virtio_enabled = true; >>>> + >>>> + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, >>>> + disk->vdev, disk->irq, disk->base); >>>> + } >>>> + } >>>> + >>>> + if (virtio_enabled) >>>> + nr_spis += (virtio_irq - 32) + 1; >>> Is it possible to update "nr_spis" inside the loop? >> yes, but ... >> >> >>> The added value >>> seems to be "number of virtio device + 1", >>    ... not really ... >> >> >>> so updating "nr_spis" and >>> adding +1 after the loop could work, right? >>    ... from my understanding, we cannot just increment nr_spis by "one" >> inside a loop, we need to calculate it. >> >> >> Something like that (not tested): >> >>        uint32_t spi; >> >>        ... >> >>        spi = irq - 32; >>        if (nr_spis <= spi) >>            nr_spis = spi + 1; >> >> >> Shall I update "nr_spis" inside the loop? >> >> Are you asking because of eliminating "virtio_enabled" and/or "virtio_irq" >> locals? They are used down the code. > I'm asking because the calculation doesn't really make sense to me yet. At the > moment "virtio_irq-32+1" happen to be the "number of disk + 1" and we > have "nr_spis += " which I don't think makes sense with the "+1". I see > > Doesn't "nr_spis" only need to be the highest irq value for the devices > we're adding? (Maybe with +1) (also -32 because I think I understand > what 32 stand for now) (also, the "num_irqs" loop just after this loop > seems to do exactly that) I also think the same, the "nr_spis" needs to cover the highest SPI. > > But I think what this line of code needs the most is a comment. ok > >>> Also, what is "32"? Is it "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" ? >> Although currently "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" = "32", we cannot rely >> on this (I mean to use "GUEST_VIRTIO_MMIO_SPI_FIRST - 1" >> >> instead of "32"),  because "32" has yet another meaning. This is an offset >> for SPI, the values before 32 are for private IRQs (PPI, SGI). > Do you think it could be possible to name that value? I've seen other > use of 32 in the same function that have probably the same meaning. yes, all uses of "32" within current function have the same meaning. > But > if you don't have a good name, I guess we can also live a bit longer > with a plain "32". Except here in toolstack, this plain "32" is used in a few places in hypervisor code also. I don't have a plan to convert this value into appropriate #define everywhere. But, I can introduce local to this file #define NR_LOCAL_IRQS 32 and change in current function. Shall I? > > Cheers, > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri May 20 20:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 20:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334502.558528 (Exim 4.92) (envelope-from ) id 1ns9IW-0004l1-AE; Fri, 20 May 2022 20:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334502.558528; Fri, 20 May 2022 20:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns9IW-0004ku-6x; Fri, 20 May 2022 20:32:32 +0000 Received: by outflank-mailman (input) for mailman id 334502; Fri, 20 May 2022 20:32:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns9IU-0004kk-TJ; Fri, 20 May 2022 20:32:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns9IU-0006zw-RQ; Fri, 20 May 2022 20:32:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns9IU-00067A-C6; Fri, 20 May 2022 20:32:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ns9IU-0004pb-Bc; Fri, 20 May 2022 20:32:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=25wnD1vxS7nyULCZM8qq6o+JqEqx0GCoNZo1RQdZr3U=; b=NJzSF4NQHgaHQe9V3Uk7ypRvdc qyGvRTAPkKufluw1AAfHecAyPpWXmotxtvwWAyneKSXiCAwkxZrrbh7KaWTmqF+qLfMwsUk6RDH44 YPFa6gs8FPn5E2DQp6Iz1wMUBd1y2f6RJQ/nnEATy1U57ya1Kjq4OmfM9B5hXjvPTi58=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170610: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 20:32:30 +0000 flight 170610 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170610/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1126 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 21:35:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 21:35:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334512.558539 (Exim 4.92) (envelope-from ) id 1nsAHJ-0002Hh-2r; Fri, 20 May 2022 21:35:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334512.558539; Fri, 20 May 2022 21:35:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsAHI-0002Ha-WB; Fri, 20 May 2022 21:35:20 +0000 Received: by outflank-mailman (input) for mailman id 334512; Fri, 20 May 2022 21:35:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsAHH-0002HQ-HX; Fri, 20 May 2022 21:35:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsAHH-00080j-Et; Fri, 20 May 2022 21:35:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsAHH-0001w4-1c; Fri, 20 May 2022 21:35:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsAHH-0002Zw-1D; Fri, 20 May 2022 21:35:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=m0GyIzM357FPsGd3NcvW0oFwzb7mjJvNsOUxUrN+/qU=; b=UlvM7JqihNHmoDM+nt023ey/E5 meVicBnJ6kJ7cuMHEuRmPuQLnhbhGOlsCUg0KYLZHc5HgGl3frjSHSIpjjAYgnX3aNz3rEbOYHwZP xjr95vhCyRqxM4GhtmqDK3REYHT2j5HJFqQmQ1hgEGv/Lf++J4LJv5wFPPR4+LF6m4Tc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170612: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 21:35:19 +0000 flight 170612 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170612/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1127 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 22:43:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 22:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334522.558550 (Exim 4.92) (envelope-from ) id 1nsBKe-0000o3-5x; Fri, 20 May 2022 22:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334522.558550; Fri, 20 May 2022 22:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBKe-0000nw-2y; Fri, 20 May 2022 22:42:52 +0000 Received: by outflank-mailman (input) for mailman id 334522; Fri, 20 May 2022 22:42:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBKc-0000nm-In; Fri, 20 May 2022 22:42:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBKc-0000iV-GR; Fri, 20 May 2022 22:42:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBKc-0004rV-2T; Fri, 20 May 2022 22:42:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsBKc-0002Eh-20; Fri, 20 May 2022 22:42:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OVVMYZ2VHhXtXdBbm71k5AfL2gyamIv1si59bEcM5p0=; b=QT/dFuxWQzju8DsIL35NGq5KYG sh94zJg0CQAAICPYBYFpEDY0VaGjkdkVPDUPxEM9iprglch98fMHUO5ApWgRLEBmSAZDH0NK7edkA ci9Hjklzjuteukk7OpTYMp4RDaeh0+bCHlPi37TrUQuz4SW05l4JBnHDDgl1q+M++ouk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170613: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Fri, 20 May 2022 22:42:50 +0000 flight 170613 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170613/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 168254 build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1128 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 20 22:54:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 20 May 2022 22:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334533.558560 (Exim 4.92) (envelope-from ) id 1nsBWC-0002Pl-Ch; Fri, 20 May 2022 22:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334533.558560; Fri, 20 May 2022 22:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBWC-0002Pe-9g; Fri, 20 May 2022 22:54:48 +0000 Received: by outflank-mailman (input) for mailman id 334533; Fri, 20 May 2022 22:54:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBWA-0002PU-EK; Fri, 20 May 2022 22:54:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBWA-0000un-6W; Fri, 20 May 2022 22:54:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsBW9-0005IJ-OB; Fri, 20 May 2022 22:54:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsBW9-0007Br-Nh; Fri, 20 May 2022 22:54:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gTj7/NCrR+Zo8I5+CBRI4eQyjZj15ikduOphM+k2fsQ=; b=c0mNmt9IWGS+RC30qCUMEH0KND tvQ8tG6SkY7Dzzj9UMcEawnMqlYqPBbFOpg1F1SZdi9pxndGf4PWhBIldNEHMoQQxeZwp1jx7A/ns +1QqdWjoYtBR9wun222ogR8DrMBMIGfucnBu+LwYWrQ+Q9osLtYh/1Ebh9rfMvsuaNq8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170606: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-examine:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=43aa3f6e72d340a85d3943b86350f6196a87289c From: osstest service owner Date: Fri, 20 May 2022 22:54:45 +0000 flight 170606 xen-unstable real [real] flight 170614 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170606/ http://logs.test-lab.xenproject.org/osstest/logs/170614/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine 6 xen-install fail REGR. vs. 170586 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen 43aa3f6e72d340a85d3943b86350f6196a87289c Last test of basis 170586 2022-05-20 01:51:50 Z 0 days Testing same since 170606 2022-05-20 15:06:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Julien Grall # Arm Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit ec0cce125b8b9fccde3fa825b8ee963083b5de3b Author: Jan Beulich Date: Fri May 20 12:24:43 2022 +0200 AMD/IOMMU: return old PTE from {set,clear}_iommu_pte_present() In order to free intermediate page tables when replacing smaller mappings by a single larger one callers will need to know the full PTE. Flush indicators can be derived from this in the callers (and outside the locked regions). First split set_iommu_pte_present() from set_iommu_ptes_present(): Only the former needs to return the old PTE, while the latter (like also set_iommu_pde_present()) doesn't even need to return flush indicators. Then change return types/values and callers accordingly. Note that for subsequent changes returning merely a boolean (old.pr) is not going to be sufficient; the next_level field will also be required. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 0e461c2d7f45c50fcf4d26c7730cdd7cde77eb1f Author: Jan Beulich Date: Fri May 20 12:24:11 2022 +0200 AMD/IOMMU: walk trees upon page fault This is to aid diagnosing issues and largely matches VT-d's behavior. Since I'm adding permissions output here as well, take the opportunity and also add their displaying to amd_dump_page_table_level(). Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit ba3fcb5f52eb2d3cc43b64bad2fc78507ad4fc7a Author: Jan Beulich Date: Fri May 20 12:23:31 2022 +0200 IOMMU: have iommu_{,un}map() split requests into largest possible chunks Introduce a helper function to determine the largest possible mapping that allows covering a request (or the next part of it that is left to be processed). In order to not add yet more recurring dfn_add() / mfn_add() to the two callers of the new helper, also introduce local variables holding the values presently operated on. Note that strictly speaking iommu_unmap() doen't need to consult mapping_order(), as unmapping doesn't require superpage support. This, however, prevents freeing of deep hierarchies of page tables in vendor code (once suitably enabled), which otherwise would require dealing with preemption needs. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit e0de7c2ee63dc440b41c79c203707abde3a473dc Author: Jan Beulich Date: Fri May 20 12:22:24 2022 +0200 IOMMU: add order parameter to ->{,un}map_page() hooks Or really, in the case of ->map_page(), accommodate it in the existing "flags" parameter. All call sites will pass 0 for now. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Acked-by: Julien Grall # Arm commit 09e4ac7bc071ad0549adcb24d82d8a3c4e72d05c Author: Jan Beulich Date: Fri May 20 12:21:49 2022 +0200 IOMMU: simplify unmap-on-error in iommu_map() As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, similar to flush") there's no need anymore to have a loop here. Suggested-by: Roger Pau Monné Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit d029b9cf13875823532ee6e4201421dba16c81d4 Author: Jan Beulich Date: Fri May 20 12:21:10 2022 +0200 AMD/IOMMU: correct potentially-UB shifts Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify the target level for page table walks"]) have made Coverity notice a shift count in iommu_pde_from_dfn() which might in theory grow too large. While this isn't a problem in practice, address the concern nevertheless to not leave dangling breakage in case very large superpages would be enabled at some point. Coverity ID: 1504264 While there also address a similar issue in set_iommu_ptes_present(). It's not clear to me why Coverity hasn't spotted that one. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 444b555dc9e09fa3ce90f066e0c88dec9b47f422 Author: Jan Beulich Date: Fri May 20 12:20:35 2022 +0200 PCI: don't allow "pci-phantom=" to mark real devices as phantom functions IOMMU code mapping / unmapping devices and interrupts will misbehave if a wrong command line option declared a function "phantom" when there's a real device at that position. Warn about this and adjust the specified stride (in the worst case ignoring the option altogether). Requested-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 6a2ea1a2370a0c8a0210accac0ae62e68c185134 Author: Marek Marczykowski-Górecki Date: Fri May 20 12:19:45 2022 +0200 ns16550: use poll mode if INTERRUPT_LINE is 0xff Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Roger Pau Monné commit 488a15a669e5b83267590ed8dad2428a5216ee87 Author: Juergen Gross Date: Fri May 20 12:19:06 2022 +0200 xen/cpupool: limit number of cpupools Today the number of cpupools in a system is unlimited. This can lead to multiple problems (e.g. duplicate cpupool-id or scalability issues). Limit the number of cpupools to twice the number of maximum possible cpus, allowing to have one cpupool per physical cpu plus some spare cpupools for special means (there are already existing use cases for such spare cpupools). Suggested-by: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Andrew Cooper commit 77bbea1bafe2d5155e6325bdd782c9f19f8a6aea Author: Juergen Gross Date: Fri May 20 12:18:50 2022 +0200 tools/libs/light: update xenstore entry when setting max domain memory libxl_domain_setmaxmem() called during "xl mem-max" should update the domain's memory/static-max Xenstore node, as otherwise "xl mem-set" won't be able to set the memory size to the new maximum. Adjust the related comments and documentation accordingly. Signed-off-by: Juergen Gross Reviewed-by: Anthony PERARD commit c038304b46ffb3d3d314819d1331ca61e9ff668b Author: Jan Beulich Date: Fri May 20 12:17:52 2022 +0200 VT-d: fix !HVM build EPT is of no interest when !HVM. While I'm observing gcc11 to fully eliminate the function, older gcc's DCE looks to not be as good. CONFIG_UBSAN apparently also limits how aggressively dead code is eliminated. Aid the compiler in eliminating the accesses of opt_hap_{2mb,1gb}, which otherwise cause undefined symbol errors when linking. While there adjust types. Fixes: c479415610f0 ("x86/P2M: p2m.c is HVM-only") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Reviewed-by: Kevin Tian (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat May 21 01:23:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 01:23:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334552.558581 (Exim 4.92) (envelope-from ) id 1nsDpy-0007FJ-64; Sat, 21 May 2022 01:23:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334552.558581; Sat, 21 May 2022 01:23:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsDpy-0007FC-2O; Sat, 21 May 2022 01:23:22 +0000 Received: by outflank-mailman (input) for mailman id 334552; Sat, 21 May 2022 01:23:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsDpw-0007Ez-Jt; Sat, 21 May 2022 01:23:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsDpw-0001qr-Hi; Sat, 21 May 2022 01:23:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsDpw-0003H5-5x; Sat, 21 May 2022 01:23:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsDpw-0002FR-5X; Sat, 21 May 2022 01:23:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I6XR75qzUhRck+oQdwwzKYawD+5Mn4FwqXl+7pUiw+s=; b=eMKdPdCRnDX7/KZCMuVuBvfOJC /OEGQcI/+08rQleGq5Fjos6NgZURQvQcgYavEsX7SHcp2SROgdcCH6Opm3K1/+WFdBDZ+uBPAxiFN CzYVHAoobBZ0ggY/0Qr8AuFoHL1VDXDcDOsPXkovR3atsIeoFEg5OK15eqzBTQFFHCS4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170617: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 01:23:20 +0000 flight 170617 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170617/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 80 days 1129 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 02:47:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 02:47:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334565.558598 (Exim 4.92) (envelope-from ) id 1nsF9G-0007DO-KH; Sat, 21 May 2022 02:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334565.558598; Sat, 21 May 2022 02:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsF9G-0007DH-H8; Sat, 21 May 2022 02:47:22 +0000 Received: by outflank-mailman (input) for mailman id 334565; Sat, 21 May 2022 02:47:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsF9F-0007D5-9m; Sat, 21 May 2022 02:47:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsF9F-0003gU-4r; Sat, 21 May 2022 02:47:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsF9E-0007Im-LG; Sat, 21 May 2022 02:47:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsF9E-0000Jx-Kq; Sat, 21 May 2022 02:47:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TK7pCWreUMx3M/ouzFLPyROREo80PhqhFOGrqtzFRcY=; b=5Ke/zpfWW23yQCGCHG/b1p6m5z MXo6Ayq24I4+6NKQD26z+3DB8WxtbCMw94WmGMRQJd2yAVsYFEPHprdzateJ3k0f2QqgTrl0E8ix2 ncNlErgajA+RZP0znlTqj7WecwlhQRyTcoP07nfnjAM2iwWJz4NjE+yFa/9nr1mXUYt0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170619: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 02:47:20 +0000 flight 170619 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170619/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1130 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 04:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 04:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334579.558621 (Exim 4.92) (envelope-from ) id 1nsGtT-0001CT-0G; Sat, 21 May 2022 04:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334579.558621; Sat, 21 May 2022 04:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsGtS-0001CM-TB; Sat, 21 May 2022 04:39:10 +0000 Received: by outflank-mailman (input) for mailman id 334579; Sat, 21 May 2022 04:39:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsGtR-0001CA-Mr; Sat, 21 May 2022 04:39:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsGtR-0005gw-Iw; Sat, 21 May 2022 04:39:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsGtR-0004cH-6k; Sat, 21 May 2022 04:39:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsGtR-0005c3-6G; Sat, 21 May 2022 04:39:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zxZKlFNo9aPMqWZxsQyquHFEyq/kaHyKuYQHhTDP1cM=; b=cwipbXCpmmWNNDiRu2ney918lx xt78g1XW69ZtPxUPLrWTYnwAoDUrLwh/bMP+q6El6FTs4dxBrp4lP+ByOUEZArnZpl/qF2gdZlBLp Thn577QR9Ye1r1PKS/HICzqS/W6IR6VMRu+Nv5jgTf0JP16mNWjt7dszRv6ys8cJ8wuY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170621: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 04:39:09 +0000 flight 170621 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170621/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1131 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 05:37:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 05:37:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334591.558638 (Exim 4.92) (envelope-from ) id 1nsHo1-0007iq-Ca; Sat, 21 May 2022 05:37:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334591.558638; Sat, 21 May 2022 05:37:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsHo1-0007ij-9h; Sat, 21 May 2022 05:37:37 +0000 Received: by outflank-mailman (input) for mailman id 334591; Sat, 21 May 2022 05:37:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsHo0-0007iY-P2; Sat, 21 May 2022 05:37:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsHo0-0006wW-Em; Sat, 21 May 2022 05:37:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsHo0-0006Jr-2A; Sat, 21 May 2022 05:37:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsHo0-0005T1-1g; Sat, 21 May 2022 05:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wtAtfg/NGGBeNatiEXOBhvt2O0w8cy6CBG9bpJtzGk8=; b=3E3S64P6xWxpYTyU4++x2GygTt y/rwfMITIvjChtih40qYqgFvrnnEF9DmDvOu/rvDNJJ71hla0IqeLsmvw7X08G/z/BEtbXvaipi+z D2dpFoS1C6BniyzQrxpA2JWD1GzGOyfEQ+5URjTuUE/uTVBf4R+QVklk65g6F1S38ROI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170625: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 05:37:36 +0000 flight 170625 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1132 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 05:52:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 05:52:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334601.558648 (Exim 4.92) (envelope-from ) id 1nsI27-0001dJ-KC; Sat, 21 May 2022 05:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334601.558648; Sat, 21 May 2022 05:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsI27-0001dC-HD; Sat, 21 May 2022 05:52:11 +0000 Received: by outflank-mailman (input) for mailman id 334601; Sat, 21 May 2022 05:52:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsI26-0001d2-Ss; Sat, 21 May 2022 05:52:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsI26-0007BV-QG; Sat, 21 May 2022 05:52:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsI26-0006eR-7p; Sat, 21 May 2022 05:52:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsI26-0004NP-7M; Sat, 21 May 2022 05:52:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5U8UbnjBSLzCznK/dxg5neupbnuntAw1MdXCT/YmGxU=; b=50iJIx4SxwaqEDzCtotwjouxI2 FQ+7yrIU3jgB1jS3a2O0DIencL0QNwqWgerzlk1v5ArPy5y5BpZm7jE3y3nTW9c+S4HOMJ1bXiqUt PUIRxPTKR7W8FTp0a3JZecPvMiuFWcKyegFp2bzRkHcfuZpfNtoyP/I22uhlIsWLz89s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170609: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-raw::broken:regression linux-linus:test-armhf-armhf-libvirt-raw:host-install(5):broken:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-saverestore.2:fail:regression linux-linus:test-armhf-armhf-xl:debian-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=3b5e1590a26713a8c76896f0f1b99f52ec24e72f X-Osstest-Versions-That: linux=3d7285a335edaf23b699e87c528cf0b0070e3293 From: osstest service owner Date: Sat, 21 May 2022 05:52:10 +0000 flight 170609 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170609/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw broken test-armhf-armhf-libvirt-raw 5 host-install(5) broken REGR. vs. 170592 test-amd64-amd64-freebsd12-amd64 18 guest-saverestore.2 fail REGR. vs. 170592 test-armhf-armhf-xl 12 debian-install fail REGR. vs. 170592 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170592 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170592 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170592 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170592 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170592 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170592 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170592 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 3b5e1590a26713a8c76896f0f1b99f52ec24e72f baseline version: linux 3d7285a335edaf23b699e87c528cf0b0070e3293 Last test of basis 170592 2022-05-20 06:42:30 Z 0 days Testing same since 170609 2022-05-20 18:41:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bartosz Golaszewski Catalin Marinas Conor Paxton Elliot Berman Haibo Chen Ilya Dryomov Jean Rene Dawin Jeff Layton Krzysztof Kozlowski Linus Torvalds Mark Rutland Palmer Dabbelt Prakruthi Deepak Heragu Ulf Hansson Uwe Kleine-König Vladimir Murzin Will Deacon jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw broken test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-raw broken broken-step test-armhf-armhf-libvirt-raw host-install(5) Not pushing. (No revision log; it would be 353 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 06:02:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 06:02:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334613.558663 (Exim 4.92) (envelope-from ) id 1nsIBj-0003H8-R4; Sat, 21 May 2022 06:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334613.558663; Sat, 21 May 2022 06:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsIBj-0003H1-Nm; Sat, 21 May 2022 06:02:07 +0000 Received: by outflank-mailman (input) for mailman id 334613; Sat, 21 May 2022 06:02:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsIBi-0003Gr-OF; Sat, 21 May 2022 06:02:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsIBi-0007RP-Le; Sat, 21 May 2022 06:02:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsIBi-00070v-5T; Sat, 21 May 2022 06:02:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsIBi-0000qx-53; Sat, 21 May 2022 06:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qZw9mE6BoFeqWXAGn8PZW7CdNn3DGTdNe1odwd27YIk=; b=6piuzkg00IBOT+1wcV4NUFB+lr E5rbT9NE7CkRjeGfQJ7C8LhvqZkzGX5epQyfAKWjc50WszEAbvJx6vGYyZZg1imV17qDEyoR2UlBL QlVpQD3HSl0KDQssQ8qRH7YiE3XL7gLIRsC8/HzqVd+owh2jMkzCo99ZCNy6zJOCW5Gk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170627: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 06:02:06 +0000 flight 170627 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170627/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1133 attempts Testing same since 170593 2022-05-20 06:42:41 Z 0 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 06:25:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 06:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334396.558677 (Exim 4.92) (envelope-from ) id 1nsIYC-0005hq-Qi; Sat, 21 May 2022 06:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334396.558677; Sat, 21 May 2022 06:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsIYC-0005hj-MI; Sat, 21 May 2022 06:25:20 +0000 Received: by outflank-mailman (input) for mailman id 334396; Fri, 20 May 2022 15:13:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ns4JO-0002vj-4X for xen-devel@lists.xenproject.org; Fri, 20 May 2022 15:13:06 +0000 Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 588a82f9-d84f-11ec-bd2c-47488cf2e6aa; Fri, 20 May 2022 17:13:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 2CD1E3EF507; Fri, 20 May 2022 10:37:54 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id K6z2fUU2BRbM; Fri, 20 May 2022 10:37:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id B3B213EF505; Fri, 20 May 2022 10:37:51 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id eBm25T-A2ldC; Fri, 20 May 2022 10:37:51 -0400 (EDT) Received: from thinkos.internal.efficios.com (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by mail.efficios.com (Postfix) with ESMTPSA id 7161A3EF14F; Fri, 20 May 2022 10:37:50 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 588a82f9-d84f-11ec-bd2c-47488cf2e6aa DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com B3B213EF505 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1653057471; bh=eKAcUJ3Vwog/U5pko6aDj4DxDE5BHJKJTsP7eji0qRI=; h=From:To:Date:Message-Id:MIME-Version; b=Dalrt/O/csYw6k+1pFLjX1u/7y6LmT2e0VvGO6Z/iLTutpGc44TGfvsfdBK50yhAl dTxcV2n8uOpV7ZXEMI0l33iQ/+au029/3yhJBnpXD0PyRNGvWPK6Hgzd5FZN9rzuT5 6q5cFEHY+u8PcEmfJeZ46fV9pVIt323m+nX5n9ywSMtO8uK/Y31yvwYaIIX7/mtA3Y GOV2UpvEfu8AS3gMUcMY4jUDJUkvcZ2f9W6grMHe0zpnNtKTvS2cBVE53VmsECQrPd 01J1t2kODSEC9jWxzMArK4IIzDpXyjQktX47Ju6/nVjIumWJs8Da4ySIK9u4Qpnkrs 4MHPL49SroLHA== X-Virus-Scanned: amavisd-new at efficios.com From: Mathieu Desnoyers To: grub-devel@gnu.org Cc: Mathieu Desnoyers , xen-devel@lists.xenproject.org Subject: [RFC PATCH v3 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items Date: Fri, 20 May 2022 10:37:38 -0400 Message-Id: <20220520143741.217690-3-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> References: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The current implementation of the 20_linux_xen script implements its menu items sorting in bash with a quadratic algorithm, calling "sed", "sort", "head", and "grep" to compare versions between individual lines, which is annoyingly slow for kernel developers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Xen environment could test it before it is merged. ] Signed-off-by: Mathieu Desnoyers Cc: xen-devel@lists.xenproject.org --- util/grub.d/20_linux_xen.in | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_linux_xen.in index f45559ff8..3178eb430 100644 --- a/util/grub.d/20_linux_xen.in +++ b/util/grub.d/20_linux_xen.in @@ -237,11 +237,17 @@ esac # yet, so it's empty. In a submenu it will be equal to '\t' (one tab). submenu_indentation=3D"" =20 +# Perform a reverse version sort on the entire xen_list and linux_list. +# Temporarily replace the '.old' suffix by ' 1' and append ' 2' for all +# other files to order the '.old' files after their non-old counterpart +# in reverse-sorted order. + +reverse_sorted_xen_list=3D$(echo ${xen_list} | tr ' ' '\n' | sed -e 's/\= .old$/ 1/' -e '/ 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/' -= e 's/ 2$//') +reverse_sorted_linux_list=3D$(echo ${linux_list} | tr ' ' '\n' | sed -e = 's/\.old$/ 1/' -e '/ 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old= /' -e 's/ 2$//') + is_top_level=3Dtrue =20 -while [ "x${xen_list}" !=3D "x" ] ; do - list=3D"${linux_list}" - current_xen=3D`version_find_latest $xen_list` +for current_xen in ${reverse_sorted_xen_list}; do xen_basename=3D`basename ${current_xen}` xen_dirname=3D`dirname ${current_xen}` rel_xen_dirname=3D`make_system_path_relative_to_its_root $xen_dirnam= e` @@ -273,8 +279,7 @@ while [ "x${xen_list}" !=3D "x" ] ; do fi done =20 - while [ "x$list" !=3D "x" ] ; do - linux=3D`version_find_latest $list` + for linux in ${reverse_sorted_linux_list}; do gettext_printf "Found linux image: %s\n" "$linux" >&2 basename=3D`basename $linux` dirname=3D`dirname $linux` @@ -349,13 +354,10 @@ while [ "x${xen_list}" !=3D "x" ] ; do linux_entry "${OS}" "${version}" "${xen_version}" recovery \ "${GRUB_CMDLINE_LINUX_RECOVERY} ${GRUB_CMDLINE_LINUX}" "${GRUB_CMDLINE= _XEN}" fi - - list=3D`echo $list | tr ' ' '\n' | fgrep -vx "$linux" | tr '\n' ' '` done if [ x"$is_top_level" !=3D xtrue ]; then echo ' }' fi - xen_list=3D`echo $xen_list | tr ' ' '\n' | fgrep -vx "$current_xen" = | tr '\n' ' '` done =20 # If at least one kernel was found, then we need to --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Sat May 21 07:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 07:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334633.558694 (Exim 4.92) (envelope-from ) id 1nsJW4-0003Vd-Cx; Sat, 21 May 2022 07:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334633.558694; Sat, 21 May 2022 07:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsJW4-0003VW-8t; Sat, 21 May 2022 07:27:12 +0000 Received: by outflank-mailman (input) for mailman id 334633; Sat, 21 May 2022 07:27:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsJW3-0003VM-0y; Sat, 21 May 2022 07:27:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsJW2-0000Oj-Uh; Sat, 21 May 2022 07:27:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsJW2-0002Tr-Nv; Sat, 21 May 2022 07:27:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsJW2-0000c3-NQ; Sat, 21 May 2022 07:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0VnMxWpLEoGChFRnS7ppzzcZNJWGMFAoumLg1dcWVUw=; b=eBEp4lpOvioeaEXpFBhqnJHjHG zWEVzsPJyX9mD2crLl8OakRzNBuk8/3t1Q/8meVbegC/Scnl7w4NugtnVKwArhgobcmEOKJqjEJXY 9PXAoZRyYllEuEsDGk5IyGL5xXfMu11bMqTC7BPYgejVfWgXZW1ux3rlZ9r9wlsNV/C0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170630: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 07:27:10 +0000 flight 170630 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170630/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1134 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 08:47:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 08:47:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334648.558711 (Exim 4.92) (envelope-from ) id 1nsKln-0003IY-LL; Sat, 21 May 2022 08:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334648.558711; Sat, 21 May 2022 08:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsKln-0003IR-HU; Sat, 21 May 2022 08:47:31 +0000 Received: by outflank-mailman (input) for mailman id 334648; Sat, 21 May 2022 08:47:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsKlm-0003IH-Kj; Sat, 21 May 2022 08:47:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsKlm-0002Em-F8; Sat, 21 May 2022 08:47:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsKlm-00069g-4X; Sat, 21 May 2022 08:47:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsKlm-00060S-45; Sat, 21 May 2022 08:47:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rG4epwGIAmZqxh96BDAsLFciUNMHgq8ZzpqodS4kbRE=; b=uKYCq/arAa+TSu+PL4hXRJCIFh diMrk+7YHNmXdLQaY9Yp5uJ2/6JQ0P5SfR83eZCF7IGQwJ9novyoMhbGXzvh2E/M64b2n4K8sfs2/ 2bVVqosD+7RnqP7zdFstn/a7Qds17AoHi9C9JyH88gLhKvEFs5o4vFrN0gmP7/lGITnQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170632: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 08:47:30 +0000 flight 170632 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170632/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1135 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 09:47:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 09:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334660.558725 (Exim 4.92) (envelope-from ) id 1nsLhK-0000qA-EH; Sat, 21 May 2022 09:46:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334660.558725; Sat, 21 May 2022 09:46:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLhK-0000q3-BO; Sat, 21 May 2022 09:46:58 +0000 Received: by outflank-mailman (input) for mailman id 334660; Sat, 21 May 2022 09:46:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLhI-0000ps-I9; Sat, 21 May 2022 09:46:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLhI-0004br-DE; Sat, 21 May 2022 09:46:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLhI-0007lh-1s; Sat, 21 May 2022 09:46:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsLhI-0000u8-1P; Sat, 21 May 2022 09:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2WGx84wLfAdu4Y4W2VC4DuuEWxgJoqOEKt53U7c9Fxo=; b=mZpZiGZk0rMOB28WxlwLQp2Rot HxZocQkC9SfDn+nlBdHnPMzebD8EppJwasKa7Ms4iMwjF5FpnNj+nJv8mYYqEerilDSXyJ25YgomS L2A69XlNHPbO6bBUBmZeWNTwGQ1baFTdPRsKoSbC9Z2pvuUGbCTJV+tPccnRYc3GiFuY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170634: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 09:46:56 +0000 flight 170634 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170634/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 81 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1136 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 10:01:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 10:01:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334671.558736 (Exim 4.92) (envelope-from ) id 1nsLv3-0003Cj-PM; Sat, 21 May 2022 10:01:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334671.558736; Sat, 21 May 2022 10:01:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLv3-0003Cc-Kn; Sat, 21 May 2022 10:01:09 +0000 Received: by outflank-mailman (input) for mailman id 334671; Sat, 21 May 2022 10:01:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLv2-0003CS-C4; Sat, 21 May 2022 10:01:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLv2-0004wC-7I; Sat, 21 May 2022 10:01:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsLv1-00083b-Qt; Sat, 21 May 2022 10:01:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsLv1-00055i-QO; Sat, 21 May 2022 10:01:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gi+8kj0MMzoyuB/MvuHRIHfF0ESB1goZAJcjbAeBrKA=; b=OJy4aU9IJBwSj/EMdehaMXrQkb z8edqU2ol/kHslP65MLJfr8f34r9K0dkf5MoCjGOqKgfor9tIAnnLgW3FAXYs3rwkD4048MOrERtf vTNW69J9iWi12hYK9RrZ+XxrzsqId/mVpPb3Tlq4sDjw/+4/gcpZdogbe+mzyq6vQ2A4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170611: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt-qcow2::broken:regression qemu-mainline:test-armhf-armhf-libvirt-raw::broken:regression qemu-mainline:test-armhf-armhf-xl::broken:regression qemu-mainline:test-armhf-armhf-xl-credit2::broken:regression qemu-mainline:test-armhf-armhf-xl-arndale::broken:regression qemu-mainline:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:regression qemu-mainline:test-armhf-armhf-xl-arndale:host-install(5):broken:regression qemu-mainline:test-armhf-armhf-xl:host-install(5):broken:regression qemu-mainline:test-armhf-armhf-libvirt-raw:host-install(5):broken:regression qemu-mainline:test-armhf-armhf-xl-credit2:host-install(5):broken:regression qemu-mainline:test-arm64-arm64-xl-seattle:debian-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3757b0d08b399c609954cf57f273b1167e5d7a8d X-Osstest-Versions-That: qemuu=3a650ac995ca36fb9974b82ba50aac8d1fd18b6a From: osstest service owner Date: Sat, 21 May 2022 10:01:07 +0000 flight 170611 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170611/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 broken test-armhf-armhf-libvirt-raw broken test-armhf-armhf-xl broken test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-arndale broken test-armhf-armhf-libvirt-qcow2 5 host-install(5) broken REGR. vs. 170578 test-armhf-armhf-xl-arndale 5 host-install(5) broken REGR. vs. 170578 test-armhf-armhf-xl 5 host-install(5) broken REGR. vs. 170578 test-armhf-armhf-libvirt-raw 5 host-install(5) broken REGR. vs. 170578 test-armhf-armhf-xl-credit2 5 host-install(5) broken REGR. vs. 170578 test-arm64-arm64-xl-seattle 12 debian-install fail REGR. vs. 170578 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170578 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170578 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170578 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170578 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170578 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170578 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 3757b0d08b399c609954cf57f273b1167e5d7a8d baseline version: qemuu 3a650ac995ca36fb9974b82ba50aac8d1fd18b6a Last test of basis 170578 2022-05-19 20:39:37 Z 1 days Testing same since 170611 2022-05-20 19:08:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl broken test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale broken test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 broken test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw broken test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-qcow2 broken broken-job test-armhf-armhf-libvirt-raw broken broken-job test-armhf-armhf-xl broken broken-job test-armhf-armhf-xl-credit2 broken broken-job test-armhf-armhf-xl-arndale broken broken-step test-armhf-armhf-libvirt-qcow2 host-install(5) broken-step test-armhf-armhf-xl-arndale host-install(5) broken-step test-armhf-armhf-xl host-install(5) broken-step test-armhf-armhf-libvirt-raw host-install(5) broken-step test-armhf-armhf-xl-credit2 host-install(5) Not pushing. ------------------------------------------------------------ commit 3757b0d08b399c609954cf57f273b1167e5d7a8d Merge: 3a650ac995 83602083b4 Author: Richard Henderson Date: Fri May 20 08:04:30 2022 -0700 Merge tag 'pull-request-2022-05-18' of https://gitlab.com/thuth/qemu into staging * Remove Ubuntu 18.04 containers (not supported anymore) * Improve the cleanup of the QEMU binary in case of failing qtests * Update the Windows support statement * Remove the capstone submodule (and rely on Capstone of the distros instead) # -----BEGIN PGP SIGNATURE----- # # iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmKEovQRHHRodXRoQHJl # ZGhhdC5jb20ACgkQLtnXdP5wLbXXtxAAsjL2M/kUcr1KBSfkaMhTa0D3OKPQ+p/e # Bac/9+l7UhZZLLffzg53lSsCmlj9cSr5cVUkooT7IFS03wauH7ZJ/wuefIS8IYED # jREmeMWXmVTTfQo4QQZ+6T+XknG2DWjzXQ3sNat71LH4RbHXO5um3zYIdDUaujP+ # v4sAKKH+F/FUsEXMP1rFmZpkaWOcvsuSwP/H4kEfhlovebAZINPow26eYYRrTM2t # Ifs7HelO12TlmqlBFn0UzHj8bV8MZkqcjj0efocVzuYMQ8DVcxE7IPc3tft2PuUu # Ia+Czh1hLsLA1zYiO/nN9bVIIewFGOErASzjlYWUlQwNRc1nLik+m+p4Cl9WOEhL # JpkN/yY3pTI5uC6a4KgxDQGTeFUR4D5la6Hg7yQjQbTBMEeGFCV50iOdkItdnRBx # ByReVctXS3oIhsDqHMb8qydlBkPp5pUrAXdj43IBCUb3UsrHmCxH+z8U5BhHvv4D # OleykLKyMcuff6HcEpC1fBQNIFJX5uS69EtAXYtyo2kb5zAJWezCv65UPldAZJCT # kRT4beueQ+d5t+4LZn1qNePdoyeFArdCLlOqg/3Fx08kM5eEv22pSQhOtWclE7U3 # tgorikFybClvKJ+YnXBAxD7oFKe+h9L+RYCFOgoTebrbMX54IjjJfeo2DydhHTt7 # IaJnsI+vvAA= # =z6e9 # -----END PGP SIGNATURE----- # gpg: Signature made Wed 18 May 2022 12:40:36 AM PDT # gpg: using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5 # gpg: issuer "thuth@redhat.com" # gpg: Good signature from "Thomas Huth " [undefined] # gpg: aka "Thomas Huth " [undefined] # gpg: aka "Thomas Huth " [unknown] # gpg: aka "Thomas Huth " [undefined] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: 27B8 8847 EEE0 2501 18F3 EAB9 2ED9 D774 FE70 2DB5 * tag 'pull-request-2022-05-18' of https://gitlab.com/thuth/qemu: capstone: Remove the capstone submodule capstone: Allow version 3.0.5 again tests/vm: Add capstone to the NetBSD and OpenBSD VMs docs/about: Update the support statement for Windows tests/qtest: use prctl(PR_SET_PDEATHSIG) as fallback to kill QEMU tests/qtest: fix registration of ABRT handler for QEMU cleanup Remove Ubuntu 18.04 container support from the repository gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs Signed-off-by: Richard Henderson commit 83602083b4ada6ceb86bfb327e83556ebab120fc Author: Thomas Huth Date: Mon May 16 16:58:23 2022 +0200 capstone: Remove the capstone submodule Now that we allow compiling with Capstone v3.0.5 again, all our supported build hosts should provide at least this version of the disassembler library, so we do not need to ship this as a submodule anymore. Message-Id: <20220516145823.148450-4-thuth@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth commit 43ecd16678b74b281c3cc7de0dd62a36279b6025 Author: Thomas Huth Date: Mon May 16 16:58:22 2022 +0200 capstone: Allow version 3.0.5 again According to https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/ there was an issue with Capstone 3.0.4 from Ubuntu 18, which was the reason for bumping our minimum Capstone requirement to version 4.0. And indeed, compiling with that version 3.0.4 from Ubuntu 18.04 still fails (after allowing it with a hack in meson.build). But now that we've dropped support for Ubuntu 18.04, that issue is not relevant anymore. Compiling with Capstone version 3.0.5 (e.g. used in Ubuntu 20.04) seems to work fine, so let's allow that version again. Message-Id: <20220516145823.148450-3-thuth@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth commit 28e7e95e6bc374262a3f03cf7b6fb7a1b3c3ebbe Author: Thomas Huth Date: Mon May 16 16:58:21 2022 +0200 tests/vm: Add capstone to the NetBSD and OpenBSD VMs The Capstone library that is shipped with NetBSD and OpenBSD works fine when compiling QEMU, so let's enable this in our build-test VMs to get a little bit more build-test coverage. Message-Id: <20220516145823.148450-2-thuth@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth commit 0ce9b08c10d043307d125709032a897d05c80bdd Author: Thomas Huth Date: Fri May 13 08:39:58 2022 +0200 docs/about: Update the support statement for Windows Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Additionally, glib sets the _WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API, so QEMU effectively depends on the Windows 7 API, too. Thus let's bump the _WIN32_WINNT setting in QEMU to the same level as glib uses and adjust our support statement in the documentation to something similar that we're using for Linux and the *BSD systems (i.e. only the two most recent versions), which should hopefully be easier to understand for the users now. And since we're nowadays also compile-testing QEMU with MSYS2 on Windows itself, I think we could mention this build environment here, too. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/880 Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Weil Message-Id: <20220513063958.1181443-1-thuth@redhat.com> Signed-off-by: Thomas Huth commit 6cbde91a27587ca27a3c1979fe7f5f0d28eb6db9 Author: Daniel P. Berrangé Date: Fri May 13 16:49:06 2022 +0100 tests/qtest: use prctl(PR_SET_PDEATHSIG) as fallback to kill QEMU Although we register a ABRT handler to kill off QEMU when g_assert() triggers, we want an extra safety net. The QEMU process might be non-functional and thus not have responded to SIGTERM. The test script might also have crashed with SEGV, in which case the cleanup handlers won't ever run. Using the Linux specific prctl(PR_SET_PDEATHSIG) syscall, we can ensure that QEMU gets sent SIGKILL as soon as the controlling qtest exits, if nothing else has correctly told it to quit. Note, technically the death signal is sent when the *thread* that called fork() exits. IOW, if you are calling qtest_init() in one thread, letting that thread exit, and then expecting to run qtest_quit() in a different thread, things are not going to work out. Fortunately that is not a scenario that exists in qtests, as pairs of qtest_init and qtest_quit are always called from the same thread. Signed-off-by: Daniel P. Berrangé Message-Id: <20220513154906.206715-3-berrange@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth commit 83f79d4efc8dac7e511bc4375d0f9d90ff9db731 Author: Daniel P. Berrangé Date: Fri May 13 16:49:05 2022 +0100 tests/qtest: fix registration of ABRT handler for QEMU cleanup qtest_init registers a hook to cleanup the running QEMU process should g_assert() fire before qtest_quit is called. When the first hook is registered, it is supposed to triggere registration of the SIGABRT handler. Unfortunately the logic in hook_list_is_empty is inverted, so the SIGABRT handler never gets registered, unless 2 or more QEMU processes are run concurrently. This caused qtest to leak QEMU processes anytime g_assert triggers. Signed-off-by: Daniel P. Berrangé Message-Id: <20220513154906.206715-2-berrange@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth commit f3f0cbaf97c78b1fc1f3855f576e46ea6ad4f34c Author: Thomas Huth Date: Mon May 16 13:59:12 2022 +0200 Remove Ubuntu 18.04 container support from the repository According to our "Supported build platforms" policy, we now do not support Ubuntu 18.04 anymore. Remove the related container files and entries from our CI. Message-Id: <20220516115912.120951-1-thuth@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth commit e4e68c31db5472111fbff528d7348a7e6b2ae07d Author: Thomas Huth Date: Mon May 16 10:23:10 2022 +0200 gitlab-ci: Switch the container of the 'check-patch' & 'check-dco' jobs The 'check-patch' and 'check-dco' jobs only need Python and git for checking the patches, so it's not really necessary to use a container here that has all the other build dependencies installed. By using a lightweight Alpine container, we can improve the runtime here quite a bit, cutting it down from ca. 1:30 minutes to ca. 45 seconds. Suggested-by: Daniel P. Berrangé Message-Id: <20220516082310.33876-1-thuth@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: John Snow Signed-off-by: Thomas Huth From xen-devel-bounces@lists.xenproject.org Sat May 21 11:11:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 11:11:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334684.558747 (Exim 4.92) (envelope-from ) id 1nsN0u-0001aq-71; Sat, 21 May 2022 11:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334684.558747; Sat, 21 May 2022 11:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsN0u-0001aj-3y; Sat, 21 May 2022 11:11:16 +0000 Received: by outflank-mailman (input) for mailman id 334684; Sat, 21 May 2022 11:11:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsN0s-0001aZ-Jb; Sat, 21 May 2022 11:11:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsN0s-00065N-F0; Sat, 21 May 2022 11:11:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsN0r-0001FY-Uz; Sat, 21 May 2022 11:11:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsN0r-0003Vt-UT; Sat, 21 May 2022 11:11:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RRON5pk6dwnvATr6yy27crHlnp5mNt6pzhtMOQTUiCk=; b=eronZSkLtgP5ahWA1TFv56U378 OG0+858g/2VWwfkeMbB5PIrwRIR4hmaDaAPy4QKEEbPXF3vDUXNd68GW48cyQ9IE0GIVXQuQYMpQN 5qLCODzi4O6vZQNJLKINBxERbhFxX/sFiYTfiLNdGJnPF75nvD6mbrEQ19GdeAjBzEuw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170636: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 11:11:13 +0000 flight 170636 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170636/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1137 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 11:38:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 11:38:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334694.558758 (Exim 4.92) (envelope-from ) id 1nsNR3-00041O-DB; Sat, 21 May 2022 11:38:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334694.558758; Sat, 21 May 2022 11:38:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsNR3-00041H-9E; Sat, 21 May 2022 11:38:17 +0000 Received: by outflank-mailman (input) for mailman id 334694; Sat, 21 May 2022 11:38:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsNR2-00040Q-7W for xen-devel@lists.xenproject.org; Sat, 21 May 2022 11:38:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsNR1-0006Vg-LG; Sat, 21 May 2022 11:38:15 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nsNR1-0007xp-Eq; Sat, 21 May 2022 11:38:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lTuoWx6mRZsb/net6vk3evSBY5xzenmNWJQ9EeKj5aE=; b=SzIUNNzMNhxC2cxzrKdQxvmNHz jrC136yURZYw+HpUNavzYTRWZfl7w8aGBLCbuqm1FVdCKQ+b0uDjynP4pjYjozv/D3N2GHBR1dGsL cD3u9jCFTcfGwFQeRzclrvBkJdHE2YTgtYukxhd3RVEkkotH7kPPrGd2zfQCQrhizznI=; Message-ID: Date: Sat, 21 May 2022 12:38:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure To: xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-11-julien@xen.org> From: Julien Grall In-Reply-To: <20220520120937.28925-11-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 20/05/2022 13:09, Julien Grall wrote: > +void __init pmap_unmap(const void *p) > +{ > + unsigned int idx; > + unsigned int slot = virt_to_fix((unsigned long)p); > + > + ASSERT(system_state < SYS_STATE_smp_boot); > + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); > + ASSERT(in_irq()); This needs to be ASSERT(!in_irq()). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 21 12:08:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 12:08:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334682.558769 (Exim 4.92) (envelope-from ) id 1nsNtk-0007Jn-TH; Sat, 21 May 2022 12:07:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334682.558769; Sat, 21 May 2022 12:07:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsNtk-0007Jg-Q0; Sat, 21 May 2022 12:07:56 +0000 Received: by outflank-mailman (input) for mailman id 334682; Sat, 21 May 2022 10:47:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsMe9-0007Pm-Up for xen-devel@lists.xenproject.org; Sat, 21 May 2022 10:47:45 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 717c5c8e-d8f3-11ec-bd2c-47488cf2e6aa; Sat, 21 May 2022 12:47:44 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nsMdj-0001BZ-PR; Sat, 21 May 2022 12:47:19 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 717c5c8e-d8f3-11ec-bd2c-47488cf2e6aa Message-ID: Date: Sat, 21 May 2022 12:47:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Chuck Zmudzinski , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> From: Thorsten Leemhuis Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1653130064;99a35e26; X-HE-SMSGID: 1nsMdj-0001BZ-PR On 20.05.22 16:48, Chuck Zmudzinski wrote: > On 5/20/2022 10:06 AM, Jan Beulich wrote: >> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>> >>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>> those want >>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>> inspect them >>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>> observe the >>>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() >>>>>>>>>> as the >>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>> earlier >>>>>>>>>> patch, in >>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>> to be >>>>>>>>>> the >>>>>>>>>> problematic one, which you leave alone. >>>>>>>>> Oh, I missed that one, sorry. >>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>> >>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>> least >>>>>>>>> the >>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>> >>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>> should not override that, >>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>> an override would affect only the single domain where the >>>>>>> kernel runs; other domains could take their own decisions. >>>>>>> >>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>> (but tell us "don't do that then"). >>>>> Actually I just did a test with the last official Debian kernel >>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>> normally on both the bare metal and on the Xen hypervisor. >>>>> That means your presumption (and the presumption of >>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>> had no effect on my system with Linux 5.16. So after doing these >>>>> tests, I am against the aggressive approach of breaking the i915 >>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>> nopat did not break the i915 driver. Why break it now? >>>> Because that's, in my understanding, is the purpose of "nopat" >>>> (not breaking the driver of course - that's a driver bug -, but >>>> having an effect on the driver). >>> I wouldn't call it a driver bug, but an incorrect configuration of the >>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>> i915 driver >> The driver ought to work fine without PAT (and hence without being >> able to make WC mappings). It would use UC instead and be slow, but >> it ought to work. >> >>> and therefore the driver should refuse to disable >>> it if the user requests to disable it and instead warn the user that >>> the driver did not disable the feature, contrary to what the user >>> requested with the nopat option. >>> >>> In any case, my test did not verify that when nopat is set in Linux >>> 5.16, >>> the thread takes the same code path as when nopat is not set, >>> so I am not totally sure that the reason nopat does not break the >>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>> returns true even when nopat is set. I could test it with a custom >>> log message in 5.16 if that is necessary. >>> >>> Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) >>> to return true in 5.16 when the user requests nopat? >> No, I'm not saying that. It was wrong for this construct to be used >> in the driver, which was fixed for 5.17 (and which had caused the >> regression I did observe, leading to the patch as a hopefully least >> bad option). >> >>> I think that is >>> just permitting a bad configuration to break the driver that a >>> well-written operating system should not allow. The i915 driver >>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>> because that option is not compatible with the hardware the >>> i915 driver is trying to initialize and setup at boot time. At least >>> that is my understanding now, but I will need to test it on 5.16 >>> to be sure I understand it correctly. >>> >>> Also, AFAICT, your patch would break the driver when the nopat >>> option is set and only fix the regression introduced by bdd8b6c98239 >>> when nopat is not set on my box, so your patch would >>> introduce a regression relative to Linux 5.16 and earlier for the >>> case when nopat is set on my box. I think your point would >>> be that it is not a regression if it is an incorrect user configuration. >> Again no - my view is that there's a separate, pre-existing issue >> in the driver which was uncovered by the change. This may be a >> perceived regression, but is imo different from a real one. Sorry, for you maybe, but I'm pretty sure for Linus it's not when it comes to the "no regressions rule". Just took a quick look at quotes from Linus https://www.kernel.org/doc/html/latest/process/handling-regressions.html and found this statement from Linus to back this up: ``` One _particularly_ last-minute revert is the top-most commit (ignoring the version change itself) done just before the release, and while it's very annoying, it's perhaps also instructive. What's instructive about it is that I reverted a commit that wasn't actually buggy. In fact, it was doing exactly what it set out to do, and did it very well. In fact it did it _so_ well that the much improved IO patterns it caused then ended up revealing a user-visible regression due to a real bug in a completely unrelated area. ``` He said that here: https://www.kernel.org/doc/html/latest/process/handling-regressions.html The situation is of course different here, but similar enough. > Since it is a regression, I think for now bdd8b6c98239 should > be reverted and the fix backported to Linux 5.17 stable until > the underlying memory subsystem can provide the i915 driver > with an updated test for the PAT feature that also meets the > requirements of the author of bdd8b6c98239 without breaking > the i915 driver. I'm not a developer and I'm don't known the details of this thread and the backstory of the regression, but it sounds like that's the approach that is needed here until someone comes up with a fix for the regression exposed by bdd8b6c98239. But if I'm wrong, please tell me. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. > The i915 driver relies on the memory subsytem > to provide it with an accurate test for the existence of > X86_FEATURE_PAT. I think your patch provides that more accurate > test so that bdd8b6c98239 could be re-applied when your patch is > committed. Juergen's patch would have to touch bdd8b6c98239 > with new functions that probably have unknown and unintended > consequences, so I think your approach is also better in that regard. > As regards your patch, there is just a disagreement about how the > i915 driver should behave if nopat is set. I agree the i915 driver > could do a better job handling that case, at least with better error > logs. > > Chuck > >> >>> I respond by saying a well-written driver should refuse to honor >>> the incorrect configuration requested by the user and instead >>> warn the user that it did not honor the incorrect kernel option. >>> >>> I am only presuming what your patch would do on my box based >>> on what I learned about this problem from my debugging. I can >>> also test your patch on my box to verify that my understanding of >>> it is correct. >>> >>> I also have not yet verified Juergen's patch will not fix it, but >>> I am almost certain it will not unless it is expanded so it also >>> touches i915_gem_object_pin_map() with the fix. I plan to test >>> his patch, but expanded so it touches that function also. >>> >>> I also plan to test your patch with and without nopat and report the >>> results in the thread where you posted your patch. Hopefully >>> by tomorrow I will have the results. >>> >>> Chuck From xen-devel-bounces@lists.xenproject.org Sat May 21 12:37:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 12:37:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334717.558780 (Exim 4.92) (envelope-from ) id 1nsOLl-00027x-73; Sat, 21 May 2022 12:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334717.558780; Sat, 21 May 2022 12:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOLl-00027q-4J; Sat, 21 May 2022 12:36:53 +0000 Received: by outflank-mailman (input) for mailman id 334717; Sat, 21 May 2022 12:36:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOLj-00027g-IG; Sat, 21 May 2022 12:36:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOLj-0007Un-HD; Sat, 21 May 2022 12:36:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOLj-0006d4-1w; Sat, 21 May 2022 12:36:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsOLj-0002Tp-1F; Sat, 21 May 2022 12:36:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aRpEpCjDFU2aymp4HcebQIbPdUtUorwskaE99AOQo+8=; b=pahGQSeNrJGWjqTosrNpKQnJU+ fkpJ77t4q/DyrVM93XC6BbjTBP4IyAgShhrjqoOcpbW7/nqpH5va/xS11nZMZj0i5GA04mBb+QiZr QshQLxRGAdzN3iv7WFc6JHNCsZTWLckrWwosOoaTnbUBa0VIjxAV5/0UMAQNpoXo6vKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170637: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 12:36:51 +0000 flight 170637 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170637/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1138 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 12:45:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 12:45:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334727.558791 (Exim 4.92) (envelope-from ) id 1nsOTZ-0003aZ-2P; Sat, 21 May 2022 12:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334727.558791; Sat, 21 May 2022 12:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOTY-0003aS-Vq; Sat, 21 May 2022 12:44:56 +0000 Received: by outflank-mailman (input) for mailman id 334727; Sat, 21 May 2022 12:44:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOTX-0003aI-Q5; Sat, 21 May 2022 12:44:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOTX-0007cn-KE; Sat, 21 May 2022 12:44:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOTX-00079s-38; Sat, 21 May 2022 12:44:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsOTX-0004K4-2f; Sat, 21 May 2022 12:44:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nqoH29Nl4GJqNlzjSRnVWTT6Tm6MNzXTdcsCm6TCPT0=; b=NFNet8/Rmcfh5VWjwsCc4EfSvo z1kClH8LrPWnza955lAgpZnt7MO+Ft7oUiAbVwd8fuUCMQfpUOIaVTIKPr26ybJEzuzFsbKcQ5h5g jSVsxzG15qVE5NWgkWI/t2SnDNt1UKCk27+i6WmFETD1W/WgH4hWthDhF8c6S76kXsWI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170624: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=42cb54804588aa82e32219fc56c15817f8b1edb0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 21 May 2022 12:44:55 +0000 flight 170624 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170624/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 42cb54804588aa82e32219fc56c15817f8b1edb0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 680 days Failing since 151818 2020-07-11 04:18:52 Z 679 days 661 attempts Testing same since 170624 2022-05-21 04:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 108861 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 13:09:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 13:09:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334739.558805 (Exim 4.92) (envelope-from ) id 1nsOrW-00065D-7k; Sat, 21 May 2022 13:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334739.558805; Sat, 21 May 2022 13:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOrW-000656-3u; Sat, 21 May 2022 13:09:42 +0000 Received: by outflank-mailman (input) for mailman id 334739; Sat, 21 May 2022 13:09:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOrU-00064w-Qj; Sat, 21 May 2022 13:09:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOrU-00083P-OF; Sat, 21 May 2022 13:09:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsOrU-00087A-E6; Sat, 21 May 2022 13:09:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsOrU-0004Ao-Db; Sat, 21 May 2022 13:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kO2R9k4E+0BgfDE380U5bYScTCiJzEfcQheWr1gNb/o=; b=kie4sdmvCHS1Yoamwmu+rFto43 A/CSXRpWgnhQl7H+D3bRrlOkXS9l7wkFI2XaNWRMCpAwaB2rGTZnXgNGYIuLvuvLDMgR8QRvg8BaM nCMlkPtxv7NR2wDayppSHtZpuqTNi9KQKMuihf7BzxLLWgWcpxsqZYV0vbF4J8iOJKNU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170638: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 13:09:40 +0000 flight 170638 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1139 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 13:24:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 13:24:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334749.558818 (Exim 4.92) (envelope-from ) id 1nsP5b-0008NV-IY; Sat, 21 May 2022 13:24:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334749.558818; Sat, 21 May 2022 13:24:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsP5b-0008NO-Fv; Sat, 21 May 2022 13:24:15 +0000 Received: by outflank-mailman (input) for mailman id 334749; Sat, 21 May 2022 13:24:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsP5a-0008NI-CU for xen-devel@lists.xenproject.org; Sat, 21 May 2022 13:24:14 +0000 Received: from sonic315-54.consmr.mail.gq1.yahoo.com (sonic315-54.consmr.mail.gq1.yahoo.com [98.137.65.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c269b90-d909-11ec-837e-e5687231ffcc; Sat, 21 May 2022 15:24:12 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 21 May 2022 13:24:08 +0000 Received: by hermes--canary-production-bf1-5d4b57496-srbfg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b79d68d9aeaaa8a76906c73f93b0ea7b; Sat, 21 May 2022 13:24:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c269b90-d909-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653139448; bh=u7Yu+KyEIfPZJbhWAIRqnrm/m3z+dGwiH+Er13915nE=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=Vz/X7Tg2KXqHVb0jKRQz9cJZrnXS6Y0rMqdMeizybrsocQSbPfzfutoh/J3UP0G1gsnBS02sQJLl4BPL4MVHEFtijFGTXttTpdw5UYoNFz9yzMMIDEA7FKHSbuQec1GzeBEiM83Kh+tnyu3YAns5Qr8CH/EzVHaN4rehQyCan/+Uf1Mb6jtvCi9O5T88AUxwxf9+8qsB55nQW/xqnSu17UuUPSxjrf4YuHm6dYwxxcl1IBQ9QCBK1iVmh2FEApWUmX/yap+reTSCOLChc5SVBIV53xjyUOaRsSjmhYp88c+l2Q6fRugEDhWn2vYsLRG9NhzKKDzAeIZC1OdwYgovMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653139448; bh=fjywVtOkL+0USSEpOqb1IdSWmSiRUy7HljK9ZuevyH9=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=REmdCsNLmO5djeOLQ0OMVJaDeOY8bQKZoTfIErzQJX21RscnkKf0SYroqeSzNSXxJ0/cqSdLoBrPIoRdBoGHmA5DW7EzpFtJ3E4+og/ELN8uCdYYO2Q5pzWQVII0stCPD6+/76EBiknW7cgFBbQhcAMQL83XCBBZqtpxSRKrKZHQwdltsK3qogqF7gBBg2wXaAXQblY6Joowrq7TqO96Mk9GNmzT+lmjXPaXnNzS/m8G4RlWKz4GNpnonZiE4EU6XgNuyydgxLWfmBpSZfI15aJBzRPay8IrZtF3hYPfFoHwCxXmkoAbI0daWTRFgPZlbxNXXjIwsWkqWFFQUEtM1w== X-YMail-OSG: dGjnYDYVM1nZFIxMGgIyXvS33pdt8sJTeJDIiUVrevs4mbVRYc9JT4J52MOoXFo 2cmWTv0ymmA5a.XrpPIirj2zCrOKW1cD4PDtyUkTkMvWgA.dQufwQHJ1bktN8Kn7TwSOpMhVt93L DMCAfGwmhMRscJH_GslY1rGJdnTJNkFuEhbJu9UxrpM3JnHmFGSfZDlNyrtLvKuGl_4W8G741WCP JDu97AzYxdMPQeJGJ7VEPUR7GAvgyZ4TQAKSpTTfI1WjWAW.cgNHO86ukAkrU5OVIbX2i4x.h5PJ BHwgAHWpZ.VUIlvQn8rQ.J_WCXWvex.Wt8547Trf8THc6rnE2JMpE1MSWzHqf1UfIh_HGf4L9C8u SCghkIwaj35mCeq5neDHxa9hr_Zv8tZMvHwv8kLMrEqk6XLaaVWFwAS1XD3M4KzJRa31tzI37FDk QXt7bp3acIE72ibVmS.aUfRJG2W.mTwbSOKcUSXroteXR_2OS.2_W8i_K.4uvIHye0iPfYTJKXxC lBTcqugQj0xiRAO96XTHSLHlitLK8ZMDztlXxiWP2UvV7587GzeuXEkFigVkm6KLqY4viE5ZIHvB Pb0q25Av2XkjI2TBdfoeYqwqWh9F3WNBzTmS1IJXQPJ66JwQRiEfa3p9XKxztfx5FyeHFKoQUeId PCZ9fpGXv5fhIZDC5l6X.RPDacaAtAwOEYNIsgfsEkA6S1y9XNdiiDs2BSoy68f3Mu0F99Uyh.9F Wz9PUbH7AMcZ6iX0UKft1J8OUhrkW01WvbjuW0VB7lB4Z8PSwY9fpKXNNtPf6.lGr6bRCnBQv9v4 AoSI9FwsCPTqlAkhoJ3ftMih_G7GS.J3bC3gQvutP_9CGAvlzeU80xM8dOlgT7kCAvA7xI7SWBS6 7L472O3tbs2Kog3Yn08ViAY4Ojx_n8JaGTOYC0jB6mQdaqbiXx0Dod9VhOi9NdROaQ7K_jM2Fg6q jfX0lJFgcURmZxQIER9oqJUDNGSvwU3O3TI0GS5HLZXzWZOfDvsdLaZd7eAtgVCh7K7wiAvfe4F8 yMlzWfEgLxgtUWZRj8oz7KaSTL8otVTauLWgccOfaI4TXRJqLgfei7HaJJ5prAa2MDLVUXfcbrjK AFezWEsMjJJz1jExkY.jVIJt2aHPZ5jU_iaGKWwIIckODByIMFrcKN._fRUrneCyXMBDajYVWi78 z8WxhwE961lFmVxFjJQHT6Gei1eRuSBe7CbMJpt7Sv2aCf_1aCiU1Zyk3g8newjwJyOcE8G0lln1 gFPLNp5LkdcHkL7DyxCwjk4KBX93L8E8QyyhR.cb6I3TVQUtE71AhHkQ9Oe8amJShJ5NxHx1t4ZS qLoj9R3SozO1KD4nJzkHTa8xOGBaSBqMuWsi3L59zFykR19Rhm7mGPcvDEEdh8pQPb7miqjQSTAp va.zuhmV.8nPmfugL63FgqXpMDWMj.noB0SXevpSCNu2pb0t971LbflvRku0dQ8sdidFPjP0T59e n7j3zux1vsAKSVODZfBUylDIayyLZO8DyJ8s2Tjz2yqZELG6TkSnZhUQGt5uNaPzy3o64voqXyGw CtKbYLMRO_4EEk.MH.roLBmZ0ErR_9n.FF339MWy6d.YUf.32MBVCTKaMt62vUjdqT8tFy8H0hlH kD._tV6XPf9OcEVCtI9gDKBbjXfrh6CR.MMC9ldL4d1kHPg1amuhdc0riFynonchkfjKiDNjZVkz 8S5e_cOKFB.ExWBtqIdS7hBeTiWkOi7V._.7UgwHrTUFT41CTEbHLNrTM0I32.xxYNn8izmJ0iWf 6IOQPUAWyDt5_uZWxtpD7bsWgFRf1MHQnvsgd4D_edQEXfKITXduB20HO3aiB4amJZrRXev3maFv .UaFb.y6uRbXN08phHBQmLW4RLEFFZK_bJLb_tCAXurN_k9Oc.nmmySBgde74mBIDbn3eJAZOZ.s erewTSNVwNPlAZHCDrWjFs5u6kfAVA7rnW4vXS6Q0wOOOf8dyICsjYbJ4pxSfx3q6A_Y0cuYgP3A AnCrTQQs5KzIWcZVrOuD7BWcykmDxlBfoYfJs1rvEiD1NLdNT2pkJe.9PfhsuoP2ZViKr3HYfH.0 jxgHneh0253SxqRrsGsiBskaaZcjTsdA1q7bhcfmfFhHKSPA8vBH3NkWKsbw_AL21U4OdW92qHRH bWhDHPshEz_xyfbLkB.ESMn5LKE3_ATG4UDBb8t6tPXnMr9gOH6llQC7gxcyL7rz6O0rieSRKpNd zst9pFHIsyguMlw-- X-Sonic-MF: Message-ID: <6c13b3ec-dc39-8de1-8e5d-87138f2a3b4b@netscape.net> Date: Sat, 21 May 2022 09:24:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Chuck Zmudzinski Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Jan Beulich References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> Content-Language: en-US In-Reply-To: <20220503132207.17234-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7846 On 5/3/22 9:22 AM, Juergen Gross wrote: > Some drivers are using pat_enabled() in order to test availability of > special caching modes (WC and UC-). This will lead to false negatives > in case the system was booted e.g. with the "nopat" variant and the > BIOS did setup the PAT MSR supporting the queried mode, or if the > system is running as a Xen PV guest. > > Add test functions for those caching modes instead and use them at the > appropriate places. > > For symmetry reasons export the already existing x86_has_pat_wp() for > modules, too. > > Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > Fixes: ae749c7ab475 ("PCI: Add arch_can_pci_mmap_wc() macro") > Signed-off-by: Juergen Gross > --- > arch/x86/include/asm/memtype.h | 2 ++ > arch/x86/include/asm/pci.h | 2 +- > arch/x86/mm/init.c | 25 +++++++++++++++++++++--- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 8 ++++---- > 4 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/include/asm/memtype.h b/arch/x86/include/asm/memtype.h > index 9ca760e430b9..d00e0be854d4 100644 > --- a/arch/x86/include/asm/memtype.h > +++ b/arch/x86/include/asm/memtype.h > @@ -25,6 +25,8 @@ extern void memtype_free_io(resource_size_t start, resource_size_t end); > extern bool pat_pfn_immune_to_uc_mtrr(unsigned long pfn); > > bool x86_has_pat_wp(void); > +bool x86_has_pat_wc(void); > +bool x86_has_pat_uc_minus(void); > enum page_cache_mode pgprot2cachemode(pgprot_t pgprot); > > #endif /* _ASM_X86_MEMTYPE_H */ > diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h > index f3fd5928bcbb..a5742268dec1 100644 > --- a/arch/x86/include/asm/pci.h > +++ b/arch/x86/include/asm/pci.h > @@ -94,7 +94,7 @@ int pcibios_set_irq_routing(struct pci_dev *dev, int pin, int irq); > > > #define HAVE_PCI_MMAP > -#define arch_can_pci_mmap_wc() pat_enabled() > +#define arch_can_pci_mmap_wc() x86_has_pat_wc() > #define ARCH_GENERIC_PCI_MMAP_RESOURCE > > #ifdef CONFIG_PCI > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c > index 71e182ebced3..b6431f714dc2 100644 > --- a/arch/x86/mm/init.c > +++ b/arch/x86/mm/init.c > @@ -77,12 +77,31 @@ static uint8_t __pte2cachemode_tbl[8] = { > [__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC, > }; > > -/* Check that the write-protect PAT entry is set for write-protect */ > +static bool x86_has_pat_mode(unsigned int mode) > +{ > + return __pte2cachemode_tbl[__cachemode2pte_tbl[mode]] == mode; > +} > + > +/* Check that PAT supports write-protect */ > bool x86_has_pat_wp(void) > { > - return __pte2cachemode_tbl[__cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]] == > - _PAGE_CACHE_MODE_WP; > + return x86_has_pat_mode(_PAGE_CACHE_MODE_WP); > +} > +EXPORT_SYMBOL_GPL(x86_has_pat_wp); > + > +/* Check that PAT supports WC */ > +bool x86_has_pat_wc(void) > +{ > + return x86_has_pat_mode(_PAGE_CACHE_MODE_WC); > +} > +EXPORT_SYMBOL_GPL(x86_has_pat_wc); > + > +/* Check that PAT supports UC- */ > +bool x86_has_pat_uc_minus(void) > +{ > + return x86_has_pat_mode(_PAGE_CACHE_MODE_UC_MINUS); > } > +EXPORT_SYMBOL_GPL(x86_has_pat_uc_minus); > > enum page_cache_mode pgprot2cachemode(pgprot_t pgprot) > { > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > index 0c5c43852e24..f43ecf3f63eb 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c > @@ -76,7 +76,7 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > if (args->flags & ~(I915_MMAP_WC)) > return -EINVAL; > > - if (args->flags & I915_MMAP_WC && !pat_enabled()) > + if (args->flags & I915_MMAP_WC && !x86_has_pat_wc()) > return -ENODEV; > > obj = i915_gem_object_lookup(file, args->handle); > @@ -757,7 +757,7 @@ i915_gem_dumb_mmap_offset(struct drm_file *file, > > if (HAS_LMEM(to_i915(dev))) > mmap_type = I915_MMAP_TYPE_FIXED; > - else if (pat_enabled()) > + else if (x86_has_pat_wc()) > mmap_type = I915_MMAP_TYPE_WC; > else if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt)) > return -ENODEV; > @@ -813,7 +813,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_WC: > - if (!pat_enabled()) > + if (!x86_has_pat_wc()) > return -ENODEV; > type = I915_MMAP_TYPE_WC; > break; > @@ -823,7 +823,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data, > break; > > case I915_MMAP_OFFSET_UC: > - if (!pat_enabled()) > + if (!x86_has_pat_uc_minus()) > return -ENODEV; > type = I915_MMAP_TYPE_UC; > break; This patch is advertised as a fix for bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") bdd8b6c98239 causes a serious regression on my system when running Linux as a Dom0 on Xen. The regression is that on my system, the error caused by this issue causes the i915driver to call its add_taint_for_CI function, which in turn totally halts the system during early boot. So this makes it impossible for either 5.17.y or the 5.18-rc versions to run as a Dom0 on my system. I cannot upgrade my system to the 5.17.y or to 5.18-rc versions without a proper fix for bdd8b6c98239. I did some testing with this patch on my system (my tests included the first patch of this 2-patch series), and here are the results: This patch does *not* fix it. I expected this patch, as is, to not fix it but allow me to add a simple patch that uses the new x86_has_pat_wc() function provided by this patch to the i915_gem_object_pin_map() function in i915_gem_pages.c that would fix it. However, even by adding the following simple patch to the i915_gem_object_pin_map() function to the patch, the patch series still does *not* fix the regression on my system: --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c @@ -428,7 +428,7 @@              goto err_unpin;          } -        if (GEM_WARN_ON(type == I915_MAP_WC && !pat_enabled())) +        if (GEM_WARN_ON(type == I915_MAP_WC && !x86_has_pat_wc()))              ptr = ERR_PTR(-ENODEV);          else if (i915_gem_object_has_struct_page(obj))              ptr = i915_gem_object_map_page(obj, type); I verified that this is the function where pat_enabled() is returning a false negative on my system. This means x86_has_pat_wc() is still giving me a false negative, even when running as a Xen Dom0. I am not sure you understand what is really causing the problem Jan is trying to fix here with false negatives from pat_enabled(). I also tested Jan's patch that you are trying to replace with this patch, and his patch *does* fix the problem on my system. Jan's patch is very simple and solves the problem by editing pat_enabled() so that it returns true if boot_cpu_has(X86_FEATURE_HYPERVISOR)) is true after the other checks for the x86 pat feature failed. I expect you do not have a system that actually has the problem that Jan and I are trying to fix because the problem only exists on systems with specific hardware, and in my case it is an Intel Haswell CPU with integrated GPU. You might be able to test your patch, though, if you boot the patched kernel with the nopat option and check if your new functions return false when running on the bare metal and true when running in a Dom0 on the Xen hypervisor. That is what the new functions should do. I think you were expecting your new x86_has_pat_wc() function to return true when Linux is running as a Dom0 on the Xen hypervisor even when pat_enabled() returns false. But it does not seem to be working. In any case, after testing this patch, I cannot confirm that it fixes bdd8b6c98239. Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Sat May 21 13:36:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 13:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334758.558833 (Exim 4.92) (envelope-from ) id 1nsPHK-0001UX-Q9; Sat, 21 May 2022 13:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334758.558833; Sat, 21 May 2022 13:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPHK-0001UQ-Lu; Sat, 21 May 2022 13:36:22 +0000 Received: by outflank-mailman (input) for mailman id 334758; Sat, 21 May 2022 13:36:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPHJ-0001UG-PY; Sat, 21 May 2022 13:36:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPHJ-0008W8-Nd; Sat, 21 May 2022 13:36:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPHJ-0000UD-Cg; Sat, 21 May 2022 13:36:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsPHJ-0001Ya-CG; Sat, 21 May 2022 13:36:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bwPK5cS5cW5z25+PsRrt+7BsErqhWCMkIv4KOcaD/Ak=; b=wVcbm/dM/oMRfBsTKj98a3p63d UcjRV9jh4IaCVlAccAGCochYmgVV9pMFoxj1d2zS81XAYC4fHU2DpQT4vi2mEkZvLPAOwEKrZN9qh 4pSAaaJgZ+mKqM9Br++BX7KrzP+A6Jr/aTfFgY9i1HT6gWRU0ALyJS8pnWy1tsOZftQI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170640: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 13:36:21 +0000 flight 170640 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1140 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 13:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 13:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334769.558844 (Exim 4.92) (envelope-from ) id 1nsPbS-0003uG-Oy; Sat, 21 May 2022 13:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334769.558844; Sat, 21 May 2022 13:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPbS-0003u9-Jv; Sat, 21 May 2022 13:57:10 +0000 Received: by outflank-mailman (input) for mailman id 334769; Sat, 21 May 2022 13:57:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsPbQ-0003u3-H0 for xen-devel@lists.xenproject.org; Sat, 21 May 2022 13:57:08 +0000 Received: from sonic313-19.consmr.mail.gq1.yahoo.com (sonic313-19.consmr.mail.gq1.yahoo.com [98.137.65.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e50c72d8-d90d-11ec-837e-e5687231ffcc; Sat, 21 May 2022 15:57:05 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sat, 21 May 2022 13:57:03 +0000 Received: by hermes--canary-production-bf1-5d4b57496-wjd85 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0613f202b0117a0c0dc022c343ea5959; Sat, 21 May 2022 13:56:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e50c72d8-d90d-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653141423; bh=uor+SXxCnw0boc1/6/JwSKTrqtsPIa2jA3Q1RkHef18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=RggvGHgiQ+1WxGrXWSAL0pV6znv8gHOgwcej5KAnoLQNsbpxnjji15mO7S75FIJf2YPyomi0T53RZ1IF0XiXcoeRaOCfmP1lTckLCZGeIBDYspnhlKKgMiKLPGCNHUlGcl0l5XwijgGzdK6kdx4826JRGUeOneV1nGfwffqGDtqOIjtGJPtimZyrXQz51e3FbUJ7ZHG6QoBETSzsKROWWCwzDyY9xepdia0k2EUrrrr02s5HCrEL3fho6QPWMOU6VmSXP/fE6GQePQpVBZN58aUStadD8hcTq2ehXY/rn/t+3K33V0LY3+kwZ/t51AD2Lz8YLGpg59LhUf8caEcn0Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653141423; bh=tUONEN5pSlByfiW2yc8zwSvY0IUJoln0Ufpvj052B0D=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=q7tyCRkmEVC82fpHDn2ynSYBEnAiaWGoTNSxDRbcXAYJPiPw87f15oJx5oztw/S0BVkW+4VxghVWH0/NT13xJ4ps4bmZyo4yb5MbGs8KwL7UNq6jqCmWWf47he18jrkJNa6FGygRHG8DIzZaDe4j0sMucdQiKXi0xxWHsgqEMaLxSPrYICuw0YoHiuwUGD/e100poiAFtxIL7rEpEjFNq3LblvkIYCM05Il4OhOObcyKaj+URFMgvVaTF3QHbdsJxvtTQTpW7lJuuQDTbNYofZc1EHVdioviZSf+er1nyqFCv7GOXn1qoUeeHfeWPzqMf1zcDMLakNN5Q2+xE92YiA== X-YMail-OSG: pLmcIpMVM1mF8pf3QufOf5xoOKcd_WkSzBZrsLHvR09a512QVRT5dzyw34B3bEk OfwOlxtRXj0PgKBI_dmWJJbRAUeZ37ReJIg73HJKxVsGkqqus324X_9nVVw1jh_i.sGTQwrFOvLe HXxupDWOGOvqitUfdXIY360MtTR2W4XcqTpQTU6TPuOLPqlk0EDVqxhtWOOd4v25Q2dV4QyMsDYQ B4QQM3_NYWmjATI0i.Mkmc12FkOUbNm6AxiZaYjexMS7j1A_6YbE_0NaukHby5KSJHHgkrX46aWN yMAi2yEoVD_L.ljv0molIjAZz8dHFMaWymcc658PUr3sHfqcihp4PVwbJwIFUGC5BOP2IYQZbjwG gzxzG2M096fGzKxF2y7PyUngexF8Tr5R73WW1nHKc0AFKjKBjau5PeqOp_0d8NvzKu9DDuPJa_b8 VmBfGXRnmvAA1LNdcEApJPfuOgtnrqeBgxS88E1JWnNWXoHG0Ne_nUwX.PiGOahRNer.n8nZgNec rCJ3v5Kp9l1i0C8FXlx5e8PsD61xOrhWtxt0_ypQDG6TUzRw3ZajORuZvZVYbB9fcNdeOcxtt0hu 6zgdjr8lpGJHR4biSZYZgGwysM5JRbVQv.bIwj5GC1fLBQevd5lAYgoWbgZG5qHcZWamjMzLx53P IHCkoq2bdTlS1aiGVwl1Uk.IiN0PYTjOLQagRywHX9U.5UyhbsO5uiIUspYCPiPsNT9p8zA06F.g rzDFrvwpwDkWnVTFV7CxrwjYXttZU6O5zEXgrlD0wIG6yVW40ZaPPCIG5B5IjC22w.Q4fTIbJLqo VuLebzt5b43gvqikzyxd_WRmsLC59lCMuK9R97pGzqTaNofDW0ocIzhNEEBP4Faj6FdJEdYwAYEd jnkylLbizc0A9MjaHc8a5hj0vWKuBVv2PZZFEyuTLc3THv4OTilUCuXoFo64p9SpU1LhRJTMDNqT kdKYxLLeGrS9zovgCVzYcb_7RCB5ZpVTMF.Gm8NLsnKKSQer8TSFEcgH370GVwi2mZrfEcE_rcYT LlT1tEyFfpYJrBr2vZhEy0YBdKHsTCoH0wPpkcieMA4mdMAksM_.RqgfwxzQNLJyzgnXwQSkz8Z0 3qqYEkdd3uGoOdgxdWARGkF18LI52E.m1AcWmWmFR982GEC9BG5oh1tV.DZf31bQP9MTj7wBHWEo lOkCYLcHaDCUGNIC4690m360S2ZQeHsjNM.y6YNPtT9xf76RElaRWD2ybObRoVHk3HqyGE7pXhvF NDfeuB2BW0d6BdKvRMrCRvuJnAAY7hGbeYH8d4DIEbhiU2Sy5Bk9CjDIlBWpxzdQcuI8gKxtuu9Y fxubsoCgz6T5b2BBXFUzcGlqdMQGt8VzFVjzDGtsalsK6q5g80Am31hGyHmc8mZxh_Z5YfGC4MFA GaJLOZQCOveHnOD0skO3.kAu1UKssNt5ZY_mZE22vjz7h7K5jdRqwCabDgCpT6KfdaqD76IQK5kt 8K24esLa2nCGCbhCoGfMo5Pt_4pAIzo6dZD5JXSj6B4IkWEOR6bq8saNljg8SC5keREXhMv5Kld6 vIaubQIOOGcqCd2UVVpkrV0vrIrzqs9CcsuyJdNFoR6HQzEX0_7WMAhdnwRG_61QlouYi4gO110S e.2UHVWFJ2tib9IBWZCqh3omU.pucdjR5qieHWWeYSbFY1SiEB2y0q_lr4DFt5.newJn2UTUZndm kLAHqcB1Fxe9TIL.4KRGIUVB6FWlTBKPfIrP5zZfWn3VJGcuYX.XnCWPtODmioaR8gjjj6KcBa3b aSXqN8czo5te4g5GPnDbawyH6j0pIogqH9M4iy.NV7gAwl8B4CgNChPDBab0GEjUOKXi9fs8fWm1 .MhghSVlhqh.KwuHgb87s9C4uFSIQje.H3jT0ynBW_8uFohInDjqxLc9Qk3Vychf55O_aG8QGMfR LHpFiT6yR_Y63rs2YS4FZeMOD.ykRSpQkSSNySVgs3eBTDCdyeyNLGgxcXpFVC4oOrkjwaEBv1wG MPTxjWHuwuAR9oKPqsEtgCMLH.LTOqoII7DvQQSRXPy8yl7DxKfAG.p6ueLUE1iROmOTdrBOIKVW s8D0eihcQM9pHtsNPuoivvd5lcD4sfhKavvxZPtLArnCviaA9Fy4miWN3.6Zj7bDsOUh6L43VDRL oUp48BOCSI8oPKfakNjzGAe.SVm9e4rhbVeFFDy8_N8Vao6eqWFT14p79GTs7Nf7vbMGrA.106fV TjdXMDSZzjHrgdFWM8vMTIz_9u5m55Gfr.Q-- X-Sonic-MF: Message-ID: Date: Sat, 21 May 2022 09:56:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> From: Chuck Zmudzinski In-Reply-To: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3611 On 4/28/22 10:50 AM, Jan Beulich wrote: > The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > with pat_enabled()") pat_enabled() returning false (because of PAT > initialization being suppressed in the absence of MTRRs being announced > to be available) has become a problem: The i915 driver now fails to > initialize when running PV on Xen (i915_gem_object_pin_map() is where I > located the induced failure), and its error handling is flaky enough to > (at least sometimes) result in a hung system. > > Yet even beyond that problem the keying of the use of WC mappings to > pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > graphics frame buffer accesses would have been quite a bit less > performant than possible. > > Arrange for the function to return true in such environments, without > undermining the rest of PAT MSR management logic considering PAT to be > disabled: Specifically, no writes to the PAT MSR should occur. > > For the new boolean to live in .init.data, init_cache_modes() also needs > moving to .init.text (where it could/should have lived already before). > > Signed-off-by: Jan Beulich > --- > On the system where I observed the issue, a knock-on effect of driver > initialization failing was that the SATA-controller also started to > report failures. > > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -62,6 +62,7 @@ > > static bool __read_mostly pat_bp_initialized; > static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > static bool __read_mostly pat_bp_enabled; > static bool __read_mostly pat_cm_initialized; > > @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) > static int __init nopat(char *str) > { > pat_disable("PAT support disabled via boot option."); > + pat_force_disabled = true; > return 0; > } > early_param("nopat", nopat); > @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) > wrmsrl(MSR_IA32_CR_PAT, pat); > } > > -void init_cache_modes(void) > +void __init init_cache_modes(void) > { > u64 pat = 0; > > @@ -313,6 +315,13 @@ void init_cache_modes(void) > */ > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > + } else if (!pat_force_disabled && > + boot_cpu_has(X86_FEATURE_HYPERVISOR)) { > + /* > + * Clearly PAT is enabled underneath. Allow pat_enabled() to > + * reflect this. > + */ > + pat_bp_enabled = true; > } > > __init_cache_modes(pat); > Hi Jan, I tested this patch on my system with an Intel Haswell CPU with integrated GPU. It fixes my system which currently is unable to boot the official Linux 5.17.y as a Dom0 on Xen. The first suggestion I have is that the commit message should be edited to explain how the behavior of the kernel in response to the nopat option would be changed by this patch. My tests indicate that this patch changes what nopat actually does, and the commit message should clearly explain that fact. Thank you for this patch, I hope it is committed soon and backported to 5.17 stable. I consider that it fixes a regression caused by bdd8b6c98239, so my second suggestion is that you add Fixes: Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") I will be using this patch on my system until it, or another fix, is committed to Linux. Without such a fix, I cannot run 5.17.y and later on my system as a Xen Dom0. Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Sat May 21 14:39:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 14:39:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334777.558855 (Exim 4.92) (envelope-from ) id 1nsQFt-00086r-V0; Sat, 21 May 2022 14:38:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334777.558855; Sat, 21 May 2022 14:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQFt-00086k-R6; Sat, 21 May 2022 14:38:57 +0000 Received: by outflank-mailman (input) for mailman id 334777; Sat, 21 May 2022 14:38:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQFt-00086a-6y; Sat, 21 May 2022 14:38:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQFt-00019b-52; Sat, 21 May 2022 14:38:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQFs-0002fe-KF; Sat, 21 May 2022 14:38:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsQFs-00066G-Jq; Sat, 21 May 2022 14:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=khZZSYUY1mh3Gf28/ZqDvJcIewoTnUFfvZ+N9+zBhAU=; b=J/PrCuuT6PmzV2A9/K7V5f6g+h r7NpmAnjFn/a5yskyHB9/Ebw1KAVx5GBKmp8uJS39XPZpJrIQWg1bpkvY0RD6lVIzB2OcCz+IwhtN IhkRTcIoSK4hGeYj0mh47zbo965kjL+Behh5uI1+52Q3LZK1LgzAIi6Ou0bIBBWBtSww=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170643: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 14:38:56 +0000 flight 170643 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170643/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1141 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 15:06:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 15:06:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334787.558865 (Exim 4.92) (envelope-from ) id 1nsQgB-0002vY-4b; Sat, 21 May 2022 15:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334787.558865; Sat, 21 May 2022 15:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQgB-0002vR-1q; Sat, 21 May 2022 15:06:07 +0000 Received: by outflank-mailman (input) for mailman id 334787; Sat, 21 May 2022 15:06:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQgA-0002vH-IY; Sat, 21 May 2022 15:06:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQgA-0001dE-HV; Sat, 21 May 2022 15:06:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsQgA-0003M7-9E; Sat, 21 May 2022 15:06:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsQgA-0001f0-8l; Sat, 21 May 2022 15:06:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i1t+tbYVPrV10mTq1r4pEx5YPK+SvXt7LxWB1vY/4OE=; b=gbHd9x+VLt4slHsZ4M3uhEnkml 8lRAYTMgKsFcSTqCDAgwyuDvz0/4XDD0dLSom0+h7TDBdmsTVy95F+bi6XW/HKm0AGh2f2GDRbw5I Dbnjk0+G6es599NIBd/EUMuwhmmsM2QkgvAj6819Cmq8VbFcZ78q/w8HdUiuYrUqG5RM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170644: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 15:06:06 +0000 flight 170644 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170644/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1142 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 15:36:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 15:36:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334797.558876 (Exim 4.92) (envelope-from ) id 1nsR9M-0006Da-L0; Sat, 21 May 2022 15:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334797.558876; Sat, 21 May 2022 15:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsR9M-0006DT-Hr; Sat, 21 May 2022 15:36:16 +0000 Received: by outflank-mailman (input) for mailman id 334797; Sat, 21 May 2022 15:36:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsR9L-0006DJ-7z; Sat, 21 May 2022 15:36:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsR9L-00027r-5Z; Sat, 21 May 2022 15:36:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsR9K-00046H-Up; Sat, 21 May 2022 15:36:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsR9K-0001Wk-UP; Sat, 21 May 2022 15:36:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=27wbtUYeSn2nQ2+as7oLcQs7TU8j2RnrzsnF+GDKK2M=; b=z2nsBGhJyaJTkjLmUzVrdlCiSb 03nhyWuixhjZWcaG3Ewp3FliiHKXe00pexkN4XxGBbErl3Qh4f5hlU2KPhFwEv+T+iW9dmTECeT8K ZpHiGjUpQxY5RSOOVaRb5qrYO1cGu0nbPQiY5ecjKijijtiyHta3zfYjpQa3KqfbUliQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170645: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 15:36:14 +0000 flight 170645 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170645/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1143 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 15:44:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 15:44:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334808.558888 (Exim 4.92) (envelope-from ) id 1nsRH8-0007jJ-LY; Sat, 21 May 2022 15:44:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334808.558888; Sat, 21 May 2022 15:44:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRH8-0007jC-IO; Sat, 21 May 2022 15:44:18 +0000 Received: by outflank-mailman (input) for mailman id 334808; Sat, 21 May 2022 15:44:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRH6-0007j2-W8; Sat, 21 May 2022 15:44:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRH6-0002FR-Sw; Sat, 21 May 2022 15:44:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRH6-0004JL-GZ; Sat, 21 May 2022 15:44:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsRH6-0001iT-GA; Sat, 21 May 2022 15:44:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UfcdkIO3q7MJxG7CRPPgvEW+qkFuzngBFz0YUSrYZW0=; b=pC0j0MgfMjLnQLzbbEykgHg5g2 qXDnZGHCGvQa/9hh+xac5Ac0gRBZ37NhpoZht/mFayp5yzzoSzjx+h9ueJ+9Heq7LXxYb7neIdJiY VeMc/CX/rLtummbHWrYERrM+o+//wbAgXLebWMFEruxK9PrH+iff/vT5w/ApeAVoV4mw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170616: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-credit1::broken:regression xen-unstable:test-armhf-armhf-xl-credit2::broken:regression xen-unstable:test-amd64-i386-examine:xen-install:fail:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-armhf-armhf-xl-credit2:host-install(5):broken:heisenbug xen-unstable:test-armhf-armhf-xl-credit1:host-install(5):broken:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=43aa3f6e72d340a85d3943b86350f6196a87289c From: osstest service owner Date: Sat, 21 May 2022 15:44:16 +0000 flight 170616 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170616/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken test-armhf-armhf-xl-credit2 broken test-amd64-i386-examine 6 xen-install fail REGR. vs. 170586 build-arm64-pvops 6 kernel-build fail REGR. vs. 170586 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 5 host-install(5) broken pass in 170606 test-armhf-armhf-xl-credit1 5 host-install(5) broken pass in 170606 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 170606 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 170606 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 170606 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 170606 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 170606 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 170606 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 170606 never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 170606 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 170606 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen 43aa3f6e72d340a85d3943b86350f6196a87289c Last test of basis 170586 2022-05-20 01:51:50 Z 1 days Testing same since 170606 2022-05-20 15:06:55 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Julien Grall # Arm Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 broken test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 broken test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-xl-credit1 broken broken-job test-armhf-armhf-xl-credit2 broken broken-step test-armhf-armhf-xl-credit2 host-install(5) broken-step test-armhf-armhf-xl-credit1 host-install(5) Not pushing. ------------------------------------------------------------ commit ec0cce125b8b9fccde3fa825b8ee963083b5de3b Author: Jan Beulich Date: Fri May 20 12:24:43 2022 +0200 AMD/IOMMU: return old PTE from {set,clear}_iommu_pte_present() In order to free intermediate page tables when replacing smaller mappings by a single larger one callers will need to know the full PTE. Flush indicators can be derived from this in the callers (and outside the locked regions). First split set_iommu_pte_present() from set_iommu_ptes_present(): Only the former needs to return the old PTE, while the latter (like also set_iommu_pde_present()) doesn't even need to return flush indicators. Then change return types/values and callers accordingly. Note that for subsequent changes returning merely a boolean (old.pr) is not going to be sufficient; the next_level field will also be required. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 0e461c2d7f45c50fcf4d26c7730cdd7cde77eb1f Author: Jan Beulich Date: Fri May 20 12:24:11 2022 +0200 AMD/IOMMU: walk trees upon page fault This is to aid diagnosing issues and largely matches VT-d's behavior. Since I'm adding permissions output here as well, take the opportunity and also add their displaying to amd_dump_page_table_level(). Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit ba3fcb5f52eb2d3cc43b64bad2fc78507ad4fc7a Author: Jan Beulich Date: Fri May 20 12:23:31 2022 +0200 IOMMU: have iommu_{,un}map() split requests into largest possible chunks Introduce a helper function to determine the largest possible mapping that allows covering a request (or the next part of it that is left to be processed). In order to not add yet more recurring dfn_add() / mfn_add() to the two callers of the new helper, also introduce local variables holding the values presently operated on. Note that strictly speaking iommu_unmap() doen't need to consult mapping_order(), as unmapping doesn't require superpage support. This, however, prevents freeing of deep hierarchies of page tables in vendor code (once suitably enabled), which otherwise would require dealing with preemption needs. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit e0de7c2ee63dc440b41c79c203707abde3a473dc Author: Jan Beulich Date: Fri May 20 12:22:24 2022 +0200 IOMMU: add order parameter to ->{,un}map_page() hooks Or really, in the case of ->map_page(), accommodate it in the existing "flags" parameter. All call sites will pass 0 for now. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Acked-by: Julien Grall # Arm commit 09e4ac7bc071ad0549adcb24d82d8a3c4e72d05c Author: Jan Beulich Date: Fri May 20 12:21:49 2022 +0200 IOMMU: simplify unmap-on-error in iommu_map() As of 68a8aa5d7264 ("iommu: make map and unmap take a page count, similar to flush") there's no need anymore to have a loop here. Suggested-by: Roger Pau Monné Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit d029b9cf13875823532ee6e4201421dba16c81d4 Author: Jan Beulich Date: Fri May 20 12:21:10 2022 +0200 AMD/IOMMU: correct potentially-UB shifts Recent changes (likely 5fafa6cf529a ["AMD/IOMMU: have callers specify the target level for page table walks"]) have made Coverity notice a shift count in iommu_pde_from_dfn() which might in theory grow too large. While this isn't a problem in practice, address the concern nevertheless to not leave dangling breakage in case very large superpages would be enabled at some point. Coverity ID: 1504264 While there also address a similar issue in set_iommu_ptes_present(). It's not clear to me why Coverity hasn't spotted that one. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 444b555dc9e09fa3ce90f066e0c88dec9b47f422 Author: Jan Beulich Date: Fri May 20 12:20:35 2022 +0200 PCI: don't allow "pci-phantom=" to mark real devices as phantom functions IOMMU code mapping / unmapping devices and interrupts will misbehave if a wrong command line option declared a function "phantom" when there's a real device at that position. Warn about this and adjust the specified stride (in the worst case ignoring the option altogether). Requested-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné commit 6a2ea1a2370a0c8a0210accac0ae62e68c185134 Author: Marek Marczykowski-Górecki Date: Fri May 20 12:19:45 2022 +0200 ns16550: use poll mode if INTERRUPT_LINE is 0xff Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared by the PCI Local Bus Specification Revision 3.0 (from 2004) as "unknown"/"no connection". Fallback to poll mode in this case. The 0xff handling is x86-specific, the surrounding code is guarded with CONFIG_X86 anyway. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Roger Pau Monné commit 488a15a669e5b83267590ed8dad2428a5216ee87 Author: Juergen Gross Date: Fri May 20 12:19:06 2022 +0200 xen/cpupool: limit number of cpupools Today the number of cpupools in a system is unlimited. This can lead to multiple problems (e.g. duplicate cpupool-id or scalability issues). Limit the number of cpupools to twice the number of maximum possible cpus, allowing to have one cpupool per physical cpu plus some spare cpupools for special means (there are already existing use cases for such spare cpupools). Suggested-by: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Andrew Cooper commit 77bbea1bafe2d5155e6325bdd782c9f19f8a6aea Author: Juergen Gross Date: Fri May 20 12:18:50 2022 +0200 tools/libs/light: update xenstore entry when setting max domain memory libxl_domain_setmaxmem() called during "xl mem-max" should update the domain's memory/static-max Xenstore node, as otherwise "xl mem-set" won't be able to set the memory size to the new maximum. Adjust the related comments and documentation accordingly. Signed-off-by: Juergen Gross Reviewed-by: Anthony PERARD commit c038304b46ffb3d3d314819d1331ca61e9ff668b Author: Jan Beulich Date: Fri May 20 12:17:52 2022 +0200 VT-d: fix !HVM build EPT is of no interest when !HVM. While I'm observing gcc11 to fully eliminate the function, older gcc's DCE looks to not be as good. CONFIG_UBSAN apparently also limits how aggressively dead code is eliminated. Aid the compiler in eliminating the accesses of opt_hap_{2mb,1gb}, which otherwise cause undefined symbol errors when linking. While there adjust types. Fixes: c479415610f0 ("x86/P2M: p2m.c is HVM-only") Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Reviewed-by: Kevin Tian (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat May 21 15:49:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 15:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334819.558899 (Exim 4.92) (envelope-from ) id 1nsRMM-0008R0-F7; Sat, 21 May 2022 15:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334819.558899; Sat, 21 May 2022 15:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRMM-0008Qt-CU; Sat, 21 May 2022 15:49:42 +0000 Received: by outflank-mailman (input) for mailman id 334819; Sat, 21 May 2022 15:49:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRMK-0008Qn-7R for xen-devel@lists.xenproject.org; Sat, 21 May 2022 15:49:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsRMJ-0002LB-Rj; Sat, 21 May 2022 15:49:39 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nsRMJ-0007cA-LV; Sat, 21 May 2022 15:49:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: References:Cc:To:From:MIME-Version:Date:Message-ID; bh=r2AVLzgOm0aYjYZGuq/sADyxpZfz3+q/tII/NUlZQmY=; b=tfPzClU7U0YVDJfB6/kQIi5Z63 8R1lOBHIrxRBebJ7tqNVxlz6mOm9Gyh84sZIkIIwkr+Zjhz/HJhgXDMsNcUtP7jQnzr41M/umqUeP p12G5zhWSO8dgs1IHGFS0zZ9aWOIUpUOp+wPmHwvktfTr6Qm+dunYa/z70uG6C0Cs734=; Message-ID: Date: Sat, 21 May 2022 16:49:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Julien Grall To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , "marco.solieri@minervasys.tech" , "lucmiccio@gmail.com" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20220309112048.17377-1-julien@xen.org> <20220309112048.17377-3-julien@xen.org> <4384DB81-5692-4F04-AA21-387B11A88C6E@arm.com> Subject: Re: [PATCH early-RFC 2/5] xen/arm64: Rework the memory layout In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 25/03/2022 14:36, Julien Grall wrote: >>>>> be loaded at (512GB + 2MB). This requires a slight tweak of the boot >>>>> code as XEN_VIRT_START cannot be used as an immediate. >>>>> >>>>> Signed-off-by: Julien Grall >>>>> >>>>> --- >>>>> >>>>>     TODO: >>>>>         - I vaguely recall that one of the early platform we >>>>> supported add >>>>>           the memory starting in high memory (> 1TB). I need to check >>>>>           whether the new layout will be fine. >>>> I think we have some Juno with some memory like that, tell me if you >>>> need help here. >>> >>> Would you be able to check the memory layout and confirm? >> >> I checked and the Juno we have as the high memory a lot lower than that: >> RAM: 0000000880000000 - 00000009ffffffff >> >> No idea why it was a lot higher in my mind. > > I have only encountered one board with the memory over 512GB. I can't > remember whether it is AMD Seattle or X-Gene. So I found the answer. This was AMD Seattle where the memory start at 512GB. So I will map Xen starting at 2TB (so there is a bit of slack). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat May 21 16:35:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 16:35:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334827.558911 (Exim 4.92) (envelope-from ) id 1nsS4U-0005U9-VQ; Sat, 21 May 2022 16:35:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334827.558911; Sat, 21 May 2022 16:35:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsS4U-0005U2-QK; Sat, 21 May 2022 16:35:18 +0000 Received: by outflank-mailman (input) for mailman id 334827; Sat, 21 May 2022 16:35:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsS4T-0005Ts-Fq; Sat, 21 May 2022 16:35:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsS4T-0003b2-DO; Sat, 21 May 2022 16:35:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsS4S-0005f3-Tz; Sat, 21 May 2022 16:35:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsS4S-0001PI-TW; Sat, 21 May 2022 16:35:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eGmMkp2JoPAM62oaZ1xHaNb5cMWtcolmtyRaSdxk4M8=; b=Enk5vyUHdtlLDXWv3Mi1bBNLxh oXPwDtW3eYP8fLfaV7UWk2sXalxgIpcxhsGm9q+UDfz0haCprIY++JCzexrXgp79LNqJh8nGvsvMP evpX3HjBt0ZXwIlu0neYr/Piz4b/QBvGOrmUDjRtWIohqhWwQ6rvCU5manV/AnoR7myc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170646: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 16:35:16 +0000 flight 170646 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1144 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 17:51:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 17:51:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334837.558920 (Exim 4.92) (envelope-from ) id 1nsTFw-0004fG-Hn; Sat, 21 May 2022 17:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334837.558920; Sat, 21 May 2022 17:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsTFw-0004f9-F5; Sat, 21 May 2022 17:51:12 +0000 Received: by outflank-mailman (input) for mailman id 334837; Sat, 21 May 2022 17:51:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsTFv-0004ez-I6; Sat, 21 May 2022 17:51:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsTFv-0004r0-H2; Sat, 21 May 2022 17:51:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsTFv-0001Zw-6Y; Sat, 21 May 2022 17:51:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsTFv-0003X5-63; Sat, 21 May 2022 17:51:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jy94BsBn9ZM5dS3OKQBcsTMHfNEpx2fEItNJz8l1oAM=; b=NbaniNdajSa2UQ8SsXLoYWH/Lz FIEMVyVmvv6U5YZzPTRKZgwjTibZJPVzkLBlHr5MmZSvGaDKYvn3EpiA7f3mx+Xi7+yodx6tvG3kC BUSut0Iuf4AndYd8U9s9Hyhl+ALVfFyRkZtq/OxpjasskPcBshW8I3rET5tkQwXTlF3U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170648: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 17:51:11 +0000 flight 170648 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170648/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1145 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 19:08:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 19:08:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334847.558933 (Exim 4.92) (envelope-from ) id 1nsUS4-0003HX-DZ; Sat, 21 May 2022 19:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334847.558933; Sat, 21 May 2022 19:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUS4-0003HQ-7s; Sat, 21 May 2022 19:07:48 +0000 Received: by outflank-mailman (input) for mailman id 334847; Sat, 21 May 2022 19:07:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUS3-0003HG-5G; Sat, 21 May 2022 19:07:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUS2-0006Ay-TX; Sat, 21 May 2022 19:07:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUS2-00053u-IO; Sat, 21 May 2022 19:07:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsUS2-0006nz-Hy; Sat, 21 May 2022 19:07:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p8yOqwAgteTnrvy0sbV7XGw/EBeoOf3hVy7V5WRKftQ=; b=I1oMY4K0XnUf2Ek1if6MuY9kWR MQR6KPmp3oBYEuMKx9TfWMz/f7u7p13EprHn9+VXGDIht8qoavbsKA86KYlxjOZNrt8sOtBYNPdsw aaimkWu3AA03csn0VJDVlXNiit9SD+4IcidNILwDIAocubZo9Ph2ushRLwjgG+LOS4as=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170649: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 19:07:46 +0000 flight 170649 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170649/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1146 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 19:35:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 19:35:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334858.558943 (Exim 4.92) (envelope-from ) id 1nsUsg-0006dw-NR; Sat, 21 May 2022 19:35:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334858.558943; Sat, 21 May 2022 19:35:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUsg-0006dp-KF; Sat, 21 May 2022 19:35:18 +0000 Received: by outflank-mailman (input) for mailman id 334858; Sat, 21 May 2022 19:35:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUsf-0006df-1R; Sat, 21 May 2022 19:35:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUse-0006dH-V1; Sat, 21 May 2022 19:35:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsUse-0006Rr-Lf; Sat, 21 May 2022 19:35:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsUse-0006c0-LC; Sat, 21 May 2022 19:35:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0pDl7VRsf0zA17e4ia5HL5MurhDuJbbt5hiK9Y200bo=; b=4JzXJCphGwRzB1HtE46wU3QGQE 9JYLL+ntWyXcWOvBiGUefBP1l4+FQgxs0L8s4gpHHTxq7o2ktnNScYpfzKnXpNQPBeigupPW47pEW wx5MJsRnoDOixbBs9ZSNa8W/EUDc/x5jyGOiz4Q16Of2Op3xmGBqiTiwX3Odbg9KBJrI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170628: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b3454ce0b2c8a56e760e6baa88ed10278585072b X-Osstest-Versions-That: linux=3d7285a335edaf23b699e87c528cf0b0070e3293 From: osstest service owner Date: Sat, 21 May 2022 19:35:16 +0000 flight 170628 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170628/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170592 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170592 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170592 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170592 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170592 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170592 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170592 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170592 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b3454ce0b2c8a56e760e6baa88ed10278585072b baseline version: linux 3d7285a335edaf23b699e87c528cf0b0070e3293 Last test of basis 170592 2022-05-20 06:42:30 Z 1 days Failing since 170609 2022-05-20 18:41:29 Z 1 days 2 attempts Testing same since 170628 2022-05-21 05:54:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Anusha Srivatsa Bartosz Golaszewski Catalin Marinas Charan Teja Kalla Christian König Codrin Ciubotariu Conor Paxton Dave Airlie Elliot Berman Haibo Chen Hangyu Hua Hans de Goede Ilya Dryomov Jean Rene Dawin Jeff Layton Jernej Skrabec John Harrison Joonas Lahtinen Jérôme Pouiller Krzysztof Kozlowski Linus Torvalds Lucas De Marchi Lyude Paul Maarten Lankhorst Mario Limonciello Mark Rutland Matthew Auld Maxime Ripard Palmer Dabbelt Peter Zijlstra (Intel) Peter Zijlstra Prakruthi Deepak Heragu Stefan Wahren Stephen Boyd Ulf Hansson Umesh Nerlige Ramappa Uwe Kleine-König Vladimir Murzin Will Deacon jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 3d7285a335ed..b3454ce0b2c8 b3454ce0b2c8a56e760e6baa88ed10278585072b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat May 21 20:09:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 20:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334868.558954 (Exim 4.92) (envelope-from ) id 1nsVPK-0001gu-Fn; Sat, 21 May 2022 20:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334868.558954; Sat, 21 May 2022 20:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsVPK-0001gn-BM; Sat, 21 May 2022 20:09:02 +0000 Received: by outflank-mailman (input) for mailman id 334868; Sat, 21 May 2022 20:09:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsVPJ-0001gd-Po; Sat, 21 May 2022 20:09:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsVPJ-0007GP-Ga; Sat, 21 May 2022 20:09:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsVPI-0007gk-SE; Sat, 21 May 2022 20:09:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsVPI-0000Tg-Rb; Sat, 21 May 2022 20:09:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gbZ/qO1XHVKYCinK9H1xOgrVlLbXFj0AX88X3t60ol0=; b=aK2wp1maHk0KaA2FlqZuQOLxAB /tLnl7FxGqpQvWCvhL+vOrz6MwYIBhWwg9W9DkPbQMlCbtEYPzkzFjP2a1yKQluRIRVSMW8xYAAkJ ffKgdIDVkYPfkpr0wqaFS251l1rWSEZ2ReOYqdv71L3ygzSxkjw/cUlvupSdVtzARkOw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170635: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3757b0d08b399c609954cf57f273b1167e5d7a8d X-Osstest-Versions-That: qemuu=3a650ac995ca36fb9974b82ba50aac8d1fd18b6a From: osstest service owner Date: Sat, 21 May 2022 20:09:00 +0000 flight 170635 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170635/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170578 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170578 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170578 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170578 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170578 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170578 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170578 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170578 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 3757b0d08b399c609954cf57f273b1167e5d7a8d baseline version: qemuu 3a650ac995ca36fb9974b82ba50aac8d1fd18b6a Last test of basis 170578 2022-05-19 20:39:37 Z 1 days Testing same since 170611 2022-05-20 19:08:21 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 3a650ac995..3757b0d08b 3757b0d08b399c609954cf57f273b1167e5d7a8d -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 21 21:04:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 21:04:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334879.558965 (Exim 4.92) (envelope-from ) id 1nsWHL-0007lf-R2; Sat, 21 May 2022 21:04:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334879.558965; Sat, 21 May 2022 21:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsWHL-0007lY-Nv; Sat, 21 May 2022 21:04:51 +0000 Received: by outflank-mailman (input) for mailman id 334879; Sat, 21 May 2022 21:04:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsWHK-0007l5-CS; Sat, 21 May 2022 21:04:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsWHK-0008Th-91; Sat, 21 May 2022 21:04:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsWHJ-0003UU-Ur; Sat, 21 May 2022 21:04:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsWHJ-00067W-UM; Sat, 21 May 2022 21:04:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DH1mDPlDqGbvkb40QxslbQp7RemzTuhwdbGOvZGUzmo=; b=Z5KRSbzkgiIx7gPut4Sab62DOC Bl+BBit+OgmDtlIGOETwec1MBR3qv9UALXva5K4HxARVIWLfYM1N5VED0n0jvBV8RcDl/dqV3jgbH XeMwlDG2AxZKa/ILU4vNBxbq28z+itQK98OnYcyzu85aOigGDZmAeZRSXcWXS+CwOUes=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170650: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 21:04:49 +0000 flight 170650 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170650/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1147 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 22:03:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 22:03:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334889.558975 (Exim 4.92) (envelope-from ) id 1nsXC3-0005SI-7L; Sat, 21 May 2022 22:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334889.558975; Sat, 21 May 2022 22:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsXC3-0005SB-4m; Sat, 21 May 2022 22:03:27 +0000 Received: by outflank-mailman (input) for mailman id 334889; Sat, 21 May 2022 22:03:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsXC1-0005Rv-Fv; Sat, 21 May 2022 22:03:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsXC1-00013m-E7; Sat, 21 May 2022 22:03:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsXC1-0006SC-6N; Sat, 21 May 2022 22:03:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsXC1-00013J-5s; Sat, 21 May 2022 22:03:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UMGXt4gceO4yPQpog0/AJy325JSML8xOJT/nf6jEV+g=; b=rxqR5tm5Q/ItAJ1BdFERXrgWOb kvFSaieq8NPHHLiYJpB4XRXm14BLxFnR3M41ebUdf7IVD2ltIJdHk0OkQCw4OY2j/1T0EjTFR03pR AINn5IFAAX6kSCCjSVinS1DOwZFkvD09YuxZ+6jdumKDgRNZ/YzAuYoyjP3Mfs9uveA4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170652: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 22:03:25 +0000 flight 170652 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170652/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1148 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 23:07:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 23:07:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334899.558987 (Exim 4.92) (envelope-from ) id 1nsYBP-0003DI-0z; Sat, 21 May 2022 23:06:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334899.558987; Sat, 21 May 2022 23:06:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYBO-0003DB-UR; Sat, 21 May 2022 23:06:50 +0000 Received: by outflank-mailman (input) for mailman id 334899; Sat, 21 May 2022 23:06:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYBN-0003D1-Iu; Sat, 21 May 2022 23:06:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYBN-00026p-HX; Sat, 21 May 2022 23:06:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYBN-0000a3-5A; Sat, 21 May 2022 23:06:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsYBN-0001Z8-4g; Sat, 21 May 2022 23:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wLzBLjw55A6Dd+9Fhrzu58iigHQYflCQvI/5QtlB/zg=; b=5+8mqsyojsYveSaM5x3BI/x4Ra +ck1j2FZVF/fMTIsiAKQPbZaUctWhbLFIPERCFRM/8wGfK5hBOAi242GbvPOWT3FU9LLaI94trqlM IMvDhhvdf/5mHIul7zXkw/22qckHfiGX16QDiLKhucPfhEMhcrH9MDhTe3euGOPbMsVk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170653: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 23:06:49 +0000 flight 170653 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170653/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1149 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 21 23:51:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 23:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334909.558998 (Exim 4.92) (envelope-from ) id 1nsYsp-0008Mz-Ea; Sat, 21 May 2022 23:51:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334909.558998; Sat, 21 May 2022 23:51:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYsp-0008Ms-Bj; Sat, 21 May 2022 23:51:43 +0000 Received: by outflank-mailman (input) for mailman id 334909; Sat, 21 May 2022 23:51:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYso-0008Mi-90; Sat, 21 May 2022 23:51:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYso-0002pN-4y; Sat, 21 May 2022 23:51:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYsn-0001kG-PE; Sat, 21 May 2022 23:51:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsYsn-0001Qr-Op; Sat, 21 May 2022 23:51:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rzqZl+bY4yIxEo7DJi9wdIlJmUikOKlaaOgtf6ungxM=; b=G9CTkzCIpCPauiH/rHZUE1kebv L3N1pMqFahcYRl1j4wN7BAG9ntXOEHs2bXAggbAwDmVmMsMdllAHor2iIl0TLlz2lcTManIdih12x TMAqe7kcRzpmIfzGZpgGd+PVpbB+TC1Qe6pw16bv8xLDdiiBvv+giphW17mXNDsG5WQs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170647: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=43aa3f6e72d340a85d3943b86350f6196a87289c From: osstest service owner Date: Sat, 21 May 2022 23:51:41 +0000 flight 170647 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170647/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170586 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170586 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen 43aa3f6e72d340a85d3943b86350f6196a87289c Last test of basis 170586 2022-05-20 01:51:50 Z 1 days Testing same since 170606 2022-05-20 15:06:55 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Julien Grall # Arm Marek Marczykowski-Górecki jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 43aa3f6e72..ec0cce125b ec0cce125b8b9fccde3fa825b8ee963083b5de3b -> master From xen-devel-bounces@lists.xenproject.org Sat May 21 23:59:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 21 May 2022 23:59:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334931.559053 (Exim 4.92) (envelope-from ) id 1nsYzs-0001ES-Sv; Sat, 21 May 2022 23:59:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334931.559053; Sat, 21 May 2022 23:59:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYzs-0001EL-QC; Sat, 21 May 2022 23:59:00 +0000 Received: by outflank-mailman (input) for mailman id 334931; Sat, 21 May 2022 23:58:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYzr-0001EB-Q0; Sat, 21 May 2022 23:58:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYzr-0002xS-PB; Sat, 21 May 2022 23:58:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsYzr-0001tS-C8; Sat, 21 May 2022 23:58:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsYzr-00056m-Bd; Sat, 21 May 2022 23:58:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EcR3POJv/cbIrcFGFLxHQ64gOqXVvBU3codlIzAJQgw=; b=SHtWXlnJymd8Rk+XIpRTCturjX HbXUiotLVbqvVsHGzEUkzAApCosv0bzeoz24GhI5svQtXLXhmcZyAjVWfb2PS+Znvxq+4O6iXIB2I v4fzrboO3TaY24IKy5pZUY9uQmEp6S7Xgo7orQCE0ALPZdk8zXZl/oVHpGvU8g0ah40U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170654: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sat, 21 May 2022 23:58:59 +0000 flight 170654 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1150 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 00:43:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 00:43:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334941.559064 (Exim 4.92) (envelope-from ) id 1nsZgi-0006ta-Fe; Sun, 22 May 2022 00:43:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334941.559064; Sun, 22 May 2022 00:43:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsZgi-0006tT-CG; Sun, 22 May 2022 00:43:16 +0000 Received: by outflank-mailman (input) for mailman id 334941; Sun, 22 May 2022 00:43:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsZgh-0006tJ-4B; Sun, 22 May 2022 00:43:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsZgh-0004JM-0q; Sun, 22 May 2022 00:43:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsZgf-0003Iz-Ve; Sun, 22 May 2022 00:43:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsZgf-0006Uy-VF; Sun, 22 May 2022 00:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=poeVDF3ICTVMaAXes3/QLc/gaUrn4bmVzW8BtJdPgYI=; b=NwenwfYDd5olz0DARFm+xtFi8V eggbulxc/0P4DVYxQBmbcN3pjh8pp5pKEnnWpL5aoUDXvGjm4BvOgAF0Vq3pb45zaZCybgdAe90OM xw0TlACclxSP8IjkFKwYjAwlMBz+iJY+XLVb6bCavoe5fHEYpwNFGRk9t7O+fSj23RaM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170655: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 00:43:13 +0000 flight 170655 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170655/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 81 days 1151 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 02:25:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 02:25:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334953.559075 (Exim 4.92) (envelope-from ) id 1nsbHZ-0006yi-Vp; Sun, 22 May 2022 02:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334953.559075; Sun, 22 May 2022 02:25:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsbHZ-0006yI-Pn; Sun, 22 May 2022 02:25:25 +0000 Received: by outflank-mailman (input) for mailman id 334953; Sun, 22 May 2022 02:25:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsbHX-0006y8-PZ; Sun, 22 May 2022 02:25:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsbHX-0004Gi-OU; Sun, 22 May 2022 02:25:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsbHX-0005nn-A7; Sun, 22 May 2022 02:25:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsbHX-00060k-9f; Sun, 22 May 2022 02:25:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4HdGRZPzXFgT+x6D8ZfkFyHQiNygHAuDdMPZ39+ceQg=; b=xtgwmZIRY3XyAE4TQ6+XPDBPyd 8gnc0BQRDsNQvDh/ajgz7fRAK+3YQgZ1Wf/k1PMiaF+bGjj94icxqEMPNSsPwkCJUSQTAsrRyyho8 MZxCc3PkRD6s3AQNHIaRLXqwS/RdVcue9K9Q/xuHMHj/0ZG0L2D9TFbxcsSnY/7wS8b8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170656: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 02:25:23 +0000 flight 170656 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170656/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1152 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 03:25:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 03:25:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334963.559086 (Exim 4.92) (envelope-from ) id 1nscDY-0004fM-Cf; Sun, 22 May 2022 03:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334963.559086; Sun, 22 May 2022 03:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nscDY-0004fF-98; Sun, 22 May 2022 03:25:20 +0000 Received: by outflank-mailman (input) for mailman id 334963; Sun, 22 May 2022 03:25:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nscDX-0004f5-1E; Sun, 22 May 2022 03:25:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nscDW-0005Fm-Uy; Sun, 22 May 2022 03:25:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nscDW-00009X-JK; Sun, 22 May 2022 03:25:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nscDW-0004mp-Ip; Sun, 22 May 2022 03:25:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rgC0Igk9FsEtcxi38vh4KIGRfFtxblFgTpoI8UpiQNo=; b=SdRUM9tYZ7f8ROcNUhYMzGWaBa 1fCjjPA/zlNH57cb0rXuE/qqHHj4IiXPjgFNsBMDHDsTCNjDrkThSa3gYATs092aUJ9xKgmcymgYx fAXSI1oE6OKpCykhcT1JZ79kM8oNDSDMNCe0fRINaUe+6BD+bthmshXlsbdI1jIVByOw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170658: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 03:25:18 +0000 flight 170658 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1153 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 04:26:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 04:26:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334974.559096 (Exim 4.92) (envelope-from ) id 1nsdAn-0002UX-0L; Sun, 22 May 2022 04:26:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334974.559096; Sun, 22 May 2022 04:26:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdAm-0002UQ-Tt; Sun, 22 May 2022 04:26:32 +0000 Received: by outflank-mailman (input) for mailman id 334974; Sun, 22 May 2022 04:26:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdAm-0002UG-9X; Sun, 22 May 2022 04:26:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdAl-0006Ki-PU; Sun, 22 May 2022 04:26:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdAl-0003Fb-CG; Sun, 22 May 2022 04:26:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsdAl-0007pB-Bp; Sun, 22 May 2022 04:26:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H8CKAPNhwB8J+aMEX3EaSJMCkibe9IzbeOIVne96Adk=; b=N64lYo3yUmFN8lcqnLr52Kqw1E KRC9Zk1fjSiawVK7f5FH9xp12nxpoFgE/ieMcHJQxLsUeM/fRZbI/G4W+r89+W6BTBwCFQh37pXsY VLMeXjogOi8JE4yltBvOMitrlZR+CiaqbOBzlX/ZQ7h8sjvJQy7YEUREEe51pOUcJeA0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170651: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6c3f5bec9b40b9437410abb08eccd5cdd1598a3c X-Osstest-Versions-That: linux=b3454ce0b2c8a56e760e6baa88ed10278585072b From: osstest service owner Date: Sun, 22 May 2022 04:26:31 +0000 flight 170651 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170651/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170628 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170628 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170628 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170628 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170628 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170628 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170628 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170628 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 6c3f5bec9b40b9437410abb08eccd5cdd1598a3c baseline version: linux b3454ce0b2c8a56e760e6baa88ed10278585072b Last test of basis 170628 2022-05-21 05:54:56 Z 0 days Testing same since 170651 2022-05-21 19:41:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lewis Linus Torvalds Marc Zyngier Paolo Bonzini Quentin Perret Sean Christopherson Wanpeng Li Yury Norov jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git b3454ce0b2c8..6c3f5bec9b40 6c3f5bec9b40b9437410abb08eccd5cdd1598a3c -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 22 04:58:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 04:58:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334984.559108 (Exim 4.92) (envelope-from ) id 1nsdfR-00060a-Eg; Sun, 22 May 2022 04:58:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334984.559108; Sun, 22 May 2022 04:58:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdfR-00060T-Be; Sun, 22 May 2022 04:58:13 +0000 Received: by outflank-mailman (input) for mailman id 334984; Sun, 22 May 2022 04:58:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdfQ-00060I-02; Sun, 22 May 2022 04:58:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdfP-0006xK-U0; Sun, 22 May 2022 04:58:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsdfP-00052D-Fz; Sun, 22 May 2022 04:58:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsdfP-00008A-FX; Sun, 22 May 2022 04:58:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k1sC1M8lEJpSn+tcmEOD7G6FxYFAFMHn36YUrPDTWC0=; b=adH+fpiXHMViJnr53i6MO/F3r+ V7Z6MWwYALx34DBcTyEL3cnlxoQhOcxInmp2J31c2SAlpk4MyuxJLCXAbNlcNpyMwTB1ZbQTraPgb Sbs3Vyudehpm0CR83Df/X7r0oICV585Zdr/3UAe4bS961q1XiwUcmM8fuBihVmpruMjU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170659: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 04:58:11 +0000 flight 170659 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170659/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1154 attempts Testing same since 170593 2022-05-20 06:42:41 Z 1 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 07:01:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 07:01:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.334994.559118 (Exim 4.92) (envelope-from ) id 1nsfax-00023Y-Fh; Sun, 22 May 2022 07:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 334994.559118; Sun, 22 May 2022 07:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsfax-00023R-Cq; Sun, 22 May 2022 07:01:43 +0000 Received: by outflank-mailman (input) for mailman id 334994; Sun, 22 May 2022 07:01:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsfav-00023F-Dg; Sun, 22 May 2022 07:01:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsfav-0000zu-Av; Sun, 22 May 2022 07:01:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsfau-0004fW-VZ; Sun, 22 May 2022 07:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsfau-0004q0-V9; Sun, 22 May 2022 07:01:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xtd7wZzUyRiZR5mMubJf0vf9JM+3X3AT5VFlGZ38KNg=; b=WNQjuRzvRlThVu+6r1rjDoiBtc koF0ZFapoc7M4nQeX3IJJW0GdswEm06FBuJ9hSVpz7E1LH0/p40VGhDVa9dAWkvd2fDsP9R+C9/3H VbiaW7yJNOBIf7+pPeQUCH06giuzsZk2yMGXWcwfoEYTrnj1TNUiMvzlIWpNNqQG6UcI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170662: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 07:01:40 +0000 flight 170662 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170662/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1155 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 43 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 08:21:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 08:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335009.559129 (Exim 4.92) (envelope-from ) id 1nsgpM-000263-Tf; Sun, 22 May 2022 08:20:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335009.559129; Sun, 22 May 2022 08:20:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsgpM-00025v-Qp; Sun, 22 May 2022 08:20:40 +0000 Received: by outflank-mailman (input) for mailman id 335009; Sun, 22 May 2022 08:20:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsgpL-00025l-ED; Sun, 22 May 2022 08:20:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsgpL-0002oF-BD; Sun, 22 May 2022 08:20:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsgpL-0008Bx-18; Sun, 22 May 2022 08:20:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsgpL-0002bl-0f; Sun, 22 May 2022 08:20:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ChHwfFTTNKqTukCaSApWYowiQMHWFmnKQ9keLKmC5HM=; b=EGeyIcgrW1zyOft2TeEs/3OFaH OCZVw9uuQ4hWyGBaMbYHRvQlZht+a2ihl8kqpE9NGSspNWLYiLmcoGVXGs3MrvCE7T1NM3mBgEUOd kF5cqpDC2WZMv4QFSb7JdJuQuwbQXTKY9H9Bmijh5jvWuOYLXQ6HJJwTZFIA0ZooacVA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170663: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 08:20:39 +0000 flight 170663 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170663/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1156 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 44 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 09:06:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 09:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335019.559141 (Exim 4.92) (envelope-from ) id 1nshXM-0006e5-Ch; Sun, 22 May 2022 09:06:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335019.559141; Sun, 22 May 2022 09:06:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshXM-0006dy-95; Sun, 22 May 2022 09:06:08 +0000 Received: by outflank-mailman (input) for mailman id 335019; Sun, 22 May 2022 09:06:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshXK-0006do-KO; Sun, 22 May 2022 09:06:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshXK-0003Yo-JH; Sun, 22 May 2022 09:06:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshXK-00011V-51; Sun, 22 May 2022 09:06:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nshXK-0003p6-4a; Sun, 22 May 2022 09:06:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Bg2feeEDMld5NYvQjF603TC8mDRpQM3G6EDcwKJJVJg=; b=qLvQjSuPmsuRtjj/5KZc00yl1l 79XWBE6dDzlCY5rpkal44ZulmaQGiA8dYIAv8ia4CC6Hk8k3+q0ber4Zd/UAPU5puyvnwhaHDI550 EXMGCrDlJMPM4sruGmwNJrMTAZ9fP0jgacOvb4BDA+IypLpJkpHrSqhjqaN3ei3LPqzw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170664: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 09:06:06 +0000 flight 170664 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1157 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 45 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 09:21:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 09:21:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335029.559152 (Exim 4.92) (envelope-from ) id 1nshlu-0000XF-OV; Sun, 22 May 2022 09:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335029.559152; Sun, 22 May 2022 09:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshlu-0000X8-LK; Sun, 22 May 2022 09:21:10 +0000 Received: by outflank-mailman (input) for mailman id 335029; Sun, 22 May 2022 09:21:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshlt-0000Wy-4c; Sun, 22 May 2022 09:21:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshls-0003nv-Vf; Sun, 22 May 2022 09:21:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nshls-0001NH-4u; Sun, 22 May 2022 09:21:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nshls-0004s5-4T; Sun, 22 May 2022 09:21:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+/++qFSsw6k40+F+ErmDtN38NEES5YgdChwlgBm+j1o=; b=oMV0TH6n89Ovnrdl5zHNGmTXIL XP3HETsJLLs3dKyTW5V64YlI9r7ch8eL4o3GgSWh4thf9tHOsibB8uw8RCiglHkw+AohwO7pEqOBC mBNSjv6i5CHWJToqZgk2saOkLdahgK9R2EJVHod6soT2H2wOrszSivQn31L9Ai+RKbhI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170660: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=42cb54804588aa82e32219fc56c15817f8b1edb0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 22 May 2022 09:21:08 +0000 flight 170660 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 42cb54804588aa82e32219fc56c15817f8b1edb0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 681 days Failing since 151818 2020-07-11 04:18:52 Z 680 days 662 attempts Testing same since 170624 2022-05-21 04:18:50 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 108861 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 09:57:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 09:57:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335040.559163 (Exim 4.92) (envelope-from ) id 1nsiKd-00040e-Oi; Sun, 22 May 2022 09:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335040.559163; Sun, 22 May 2022 09:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsiKd-00040X-Jv; Sun, 22 May 2022 09:57:03 +0000 Received: by outflank-mailman (input) for mailman id 335040; Sun, 22 May 2022 09:57:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsiKc-00040N-Dz; Sun, 22 May 2022 09:57:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsiKc-0004QH-A8; Sun, 22 May 2022 09:57:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsiKb-0002EF-NC; Sun, 22 May 2022 09:57:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsiKb-0006is-Mg; Sun, 22 May 2022 09:57:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RjeMjHuc/wDdg+JSnVdpk30nPa0sWoHeppPMZeFR9+c=; b=Kngvz5IX+BCzCX+GDMD0L8OelK brOMHlF02HvTbzRfMY2qF/9l9a4OwZWA8HX+D0ydr9F1Po0B/aMeU+vq+6Z0JA65hOvvlCNMAnpLL knjmFGynq35uuGH3EOv4Ay+woc50PKYae/WBEhOhtjNBx9HXWLj6LVGNPxEqRnXVTrIw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170665: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 09:57:01 +0000 flight 170665 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 82 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1158 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 46 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 10:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 10:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335050.559173 (Exim 4.92) (envelope-from ) id 1nsigN-0006Z4-IU; Sun, 22 May 2022 10:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335050.559173; Sun, 22 May 2022 10:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsigN-0006Yx-Fl; Sun, 22 May 2022 10:19:31 +0000 Received: by outflank-mailman (input) for mailman id 335050; Sun, 22 May 2022 10:19:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsigM-0006Yn-Nu; Sun, 22 May 2022 10:19:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsigM-0004to-JH; Sun, 22 May 2022 10:19:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsigM-0002k7-5E; Sun, 22 May 2022 10:19:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsigM-000202-4m; Sun, 22 May 2022 10:19:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JK83jcgb82DTuvfAtViyBeaz4n0ysqiYcjYdNgzX79s=; b=TgrwKaw3BgxIXoUqojwYeuFLhu xGjBLtDBj2PgEOfRe5dOLrXEXm8XJpkOH5M0iTGATAE3U3BufmD9E23aYUBjrVjKmz7WrzcakPPtK C6UENFqrHSmRbR7i6LcaKyA9W7lG5F5XAosFGKzDn7hZxhR4QahqN+wMRsi17lP82blo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170657: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Sun, 22 May 2022 10:19:30 +0000 flight 170657 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170657/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail pass in 170647 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170647 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170647 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170647 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170647 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170647 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170647 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170647 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170647 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170647 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170647 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170647 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170647 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170657 2022-05-22 01:51:52 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 22 11:06:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 11:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335061.559185 (Exim 4.92) (envelope-from ) id 1nsjQ2-0003JT-Bb; Sun, 22 May 2022 11:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335061.559185; Sun, 22 May 2022 11:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjQ2-0003JM-7Y; Sun, 22 May 2022 11:06:42 +0000 Received: by outflank-mailman (input) for mailman id 335061; Sun, 22 May 2022 11:06:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjQ1-0003JG-7j for xen-devel@lists.xenproject.org; Sun, 22 May 2022 11:06:41 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 409bfa83-d9bf-11ec-bd2c-47488cf2e6aa; Sun, 22 May 2022 13:06:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6BE1421A8F; Sun, 22 May 2022 11:06:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E5EB13ADF; Sun, 22 May 2022 11:06:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ntitDT4ZimK7bgAAMHmgww (envelope-from ); Sun, 22 May 2022 11:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 409bfa83-d9bf-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653217598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BPbwnbUgotrmzB4jGp5Bg5QUjYbKcc8XqzYjsj4lnbY=; b=SdaitK8omDqJoMkyD/xB9FFK1tl6wGSoL6uoMjmWDbq2A18q7xirKe7onTBM+LEIBqKgAy RS/lTuwoTYIn9BPD6+LQHv9lB9FBZeV9Emae7M+A2Lafjr3lpoyMMrvyEGODJS2+h7xkKf 6QqVVHNBs4Mr6SRvQgEsL66Nvic42cM= Message-ID: Date: Sun, 22 May 2022 13:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent Content-Language: en-US To: SeongJae Park Cc: roger.pau@citrix.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220420072734.1692-1-sj@kernel.org> From: Juergen Gross In-Reply-To: <20220420072734.1692-1-sj@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1fZZKOQew5jH6WG0AeQeAli1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1fZZKOQew5jH6WG0AeQeAli1 Content-Type: multipart/mixed; boundary="------------JQQRCi2NjgNJke0jkpCz9jff"; protected-headers="v1" From: Juergen Gross To: SeongJae Park Cc: roger.pau@citrix.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent References: <20220420072734.1692-1-sj@kernel.org> In-Reply-To: <20220420072734.1692-1-sj@kernel.org> --------------JQQRCi2NjgNJke0jkpCz9jff Content-Type: multipart/mixed; boundary="------------1F3xaqsmVc0wAx3Q0X4fxlid" --------------1F3xaqsmVc0wAx3Q0X4fxlid Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDQuMjIgMDk6MjcsIFNlb25nSmFlIFBhcmsgd3JvdGU6DQo+IFNlb25nSmFlIGlz IGN1cnJlbnRseSBsaXN0ZWQgYXMgYSBjb250YWN0IHBvaW50IGZvciBzb21lIGJsa3tiYWNr LGZyb250fQ0KPiBmZWF0dXJlcywgYnV0IGhlIHdpbGwgbm90IHdvcmsgZm9yIFhFTiBmb3Ig YSB3aGlsZS4gIFRoaXMgY29tbWl0DQo+IHRoZXJlZm9yZSB1cGRhdGVzIHRoZSBjb250YWN0 IHBvaW50IHRvIGhpcyBjb2xsZWFndWUsIE1heGltaWxpYW4sIHdobyBpcw0KPiB1bmRlcnN0 YW5kaW5nIHRoZSBjb250ZXh0IGFuZCBhY3RpdmVseSB3b3JraW5nIHdpdGggdGhlIGZlYXR1 cmVzIG5vdy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFNlb25nSmFlIFBhcmsgPHNqQGtlcm5l bC5vcmc+DQo+IFNpZ25lZC1vZmYtYnk6IE1heGltaWxpYW4gSGV5bmUgPG1oZXluZUBhbWF6 b24uZGU+DQo+IEFja2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4 LmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy01LjE5DQoNCg0KSnVl cmdlbg0K --------------1F3xaqsmVc0wAx3Q0X4fxlid Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1F3xaqsmVc0wAx3Q0X4fxlid-- --------------JQQRCi2NjgNJke0jkpCz9jff-- --------------1fZZKOQew5jH6WG0AeQeAli1 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKKGT0FAwAAAAAACgkQsN6d1ii/Ey/h 8ggAnpPBFYomNQI9YwXgCQmQuksbKJQ+yf4MIGwi6oiv7ntKHX580j771eTKV+crht49BRPK5MuG 7DVEzH55TBG87XBcQ0kzUcRb5dQ+faQ7CQIcLZiJfviFlRMtGP8Pz5KDQT2Rsx0YUjyVqbAA3U3s E3JHrJGpV9LOvUl97BT31328WG5yhEYKyTPq2n9wYam3XF4DnhouQz68s7RSYBl/vb32GzB2yoW0 H2Ol02AgxeDe7NU7/lw/EtF+QUwfQeQuWehob0LhT5SDrExm5IiBFAWLX+0D5YvrGuV2iKBQDSFE eOy1tXWuxWuBQlix61NSls2/aEzK7bYyOZJxx82b7A== =FrVy -----END PGP SIGNATURE----- --------------1fZZKOQew5jH6WG0AeQeAli1-- From xen-devel-bounces@lists.xenproject.org Sun May 22 11:07:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 11:07:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335065.559195 (Exim 4.92) (envelope-from ) id 1nsjQR-0003hu-JK; Sun, 22 May 2022 11:07:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335065.559195; Sun, 22 May 2022 11:07:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjQR-0003hn-GZ; Sun, 22 May 2022 11:07:07 +0000 Received: by outflank-mailman (input) for mailman id 335065; Sun, 22 May 2022 11:07:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjQQ-0003JG-Dp for xen-devel@lists.xenproject.org; Sun, 22 May 2022 11:07:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50a8b86a-d9bf-11ec-bd2c-47488cf2e6aa; Sun, 22 May 2022 13:07:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9854721A8F; Sun, 22 May 2022 11:07:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7759A13ADF; Sun, 22 May 2022 11:07:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BjGZG1kZimLObgAAMHmgww (envelope-from ); Sun, 22 May 2022 11:07:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50a8b86a-d9bf-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653217625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9AhnZ0XRigy5OBsZplHYRUxP4XGy2JkVMG595h8PoGI=; b=fYiSFlh72RTrjr/b3L9LwXsybr+BxlRiIzDaeR7GHrJ2dfE8PUiazwQtwZ1Xflx4E/9g3l B34ppG6QXQx5hQDnvS2M9q3VxCPvy/0GCXfjrRvMomranBYJf5UbLCN4cy96s7zEk13CCn EYxkDbz6e6s9PZPX4OZMQ3D9uFuhjdQ= Message-ID: <64f99415-61ed-c8a2-730b-8608377d06dc@suse.com> Date: Sun, 22 May 2022 13:07:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH LINUX v5 0/2] dom0less + PV drivers Content-Language: en-US To: Stefano Stabellini , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------36cMPlUx7nGadOTPeMaY6u2e" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------36cMPlUx7nGadOTPeMaY6u2e Content-Type: multipart/mixed; boundary="------------D2c7wBRTPKa6fuGn0vE7LAaD"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , boris.ostrovsky@oracle.com Cc: xen-devel@lists.xenproject.org Message-ID: <64f99415-61ed-c8a2-730b-8608377d06dc@suse.com> Subject: Re: [PATCH LINUX v5 0/2] dom0less + PV drivers References: In-Reply-To: --------------D2c7wBRTPKa6fuGn0vE7LAaD Content-Type: multipart/mixed; boundary="------------IzBCKOpAPEBtqLf0laCRa1WN" --------------IzBCKOpAPEBtqLf0laCRa1WN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDUuMjIgMjM6MTksIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gSGkgYWxs LA0KPiANCj4gVGhpcyBzbWFsbCBMaW51eCBwYXRjaCBzZXJpZXMgaW1wbGVtZW50cyBzdXBw b3J0IGZvciBpbml0aWFsaXppbmcNCj4geGVuc3RvcmUgbGF0ZXIsIGlmIG5vdCBpbW1lZGlh dGVseSBhdmFpbGFibGUgYXQgYm9vdCB0aW1lLiBJdCBlbmFibGVzDQo+IGRvbTBsZXNzICsg UFYgZHJpdmVycyBzdXBwb3J0Lg0KPiANCj4gDQo+IA0KPiBMdWNhIE1pY2NpbyAoMSk6DQo+ ICAgICAgICB4ZW46IGFkZCBzdXBwb3J0IGZvciBpbml0aWFsaXppbmcgeGVuc3RvcmUgbGF0 ZXIgYXMgSFZNIGRvbWFpbg0KPiANCj4gU3RlZmFubyBTdGFiZWxsaW5pICgxKToNCj4gICAg ICAgIHhlbjogc3luYyB4c193aXJlLmggaGVhZGVyIHdpdGggdXBzdHJlYW0geGVuDQo+IA0K PiAgIGRyaXZlcnMveGVuL3hlbmJ1cy94ZW5idXNfcHJvYmUuYyAgfCA5MSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQ0KPiAgIGluY2x1ZGUveGVuL2ludGVyZmFj ZS9pby94c193aXJlLmggfCAzNyArKysrKysrKysrKysrKy0tDQo+ICAgMiBmaWxlcyBjaGFu Z2VkLCAxMDQgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pDQo+IA0KDQpTZXJpZXMg cHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy01LjE5DQoNCg0KSnVlcmdlbg0K --------------IzBCKOpAPEBtqLf0laCRa1WN Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------IzBCKOpAPEBtqLf0laCRa1WN-- --------------D2c7wBRTPKa6fuGn0vE7LAaD-- --------------36cMPlUx7nGadOTPeMaY6u2e Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKKGVkFAwAAAAAACgkQsN6d1ii/Ey+Y nAf+PRBaqgw5u3uwPM8PBX3t9r2VHqTCirO/Wu9iuIjObrCgAoTAZU/Ee6gMX3RRfIEZV75AVdsP d9X8K9xwxT60zzJPz9ZpcWGF4rV+rNratCSrtyY/ev/EC1b17hlwd71Woa+f0gcf7iBqGKavcb4W Pct5PLJ1R1IzwRVVKB1nXTlvTIXN6l7kC13YDexkrsXbP0nNWqHC6OwOD0yzLbXc5MRO4u5jbM9x 9lBIJG6y2EQ04HwP7d9fC7GrXTY/hDVhXteVOt7N/jRgqAJhOH54eomFNNd2PtMffrbLg0aGw5jO /6oMQjie7Ij18KBSoHnb9jcIRQZ0wE/q5/eBR0gJxA== =ZPX0 -----END PGP SIGNATURE----- --------------36cMPlUx7nGadOTPeMaY6u2e-- From xen-devel-bounces@lists.xenproject.org Sun May 22 11:08:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 11:08:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335077.559207 (Exim 4.92) (envelope-from ) id 1nsjRM-0004OQ-UG; Sun, 22 May 2022 11:08:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335077.559207; Sun, 22 May 2022 11:08:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjRM-0004OH-R9; Sun, 22 May 2022 11:08:04 +0000 Received: by outflank-mailman (input) for mailman id 335077; Sun, 22 May 2022 11:08:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjRK-0004Nu-UM for xen-devel@lists.xenproject.org; Sun, 22 May 2022 11:08:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72187642-d9bf-11ec-bd2c-47488cf2e6aa; Sun, 22 May 2022 13:08:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF34D1F388; Sun, 22 May 2022 11:08:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3684613ADF; Sun, 22 May 2022 11:08:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nuSQC5EZimL7bgAAMHmgww (envelope-from ); Sun, 22 May 2022 11:08:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72187642-d9bf-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653217681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7jhhjX59gp3INCmTVN5+tXAZn7wIvtS1GymA5skwI10=; b=MiUd93T0uon1p0IVPOalJHOEW93egU72//t2wjtdwQbSSw+6mFRVU02/IwihOhcz/7nlcJ FOqzCDhGjG+2uneC2iuYk1OT9yWmegF7zOZxcbscbKF9GlOoojE17bZSL0XjU248q0qaq2 +cZAJc0efSNmT1jzybDvrXSjf6ha9uE= Message-ID: <2f70c3fc-fdb6-450c-d570-f39280798872@suse.com> Date: Sun, 22 May 2022 13:08:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid Content-Language: en-US To: Maximilian Heyne Cc: Josh Poimboeuf , Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20220517162425.100567-1-mheyne@amazon.de> From: Juergen Gross In-Reply-To: <20220517162425.100567-1-mheyne@amazon.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------UjP09znP3YBjHC9yreCDjkQ0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------UjP09znP3YBjHC9yreCDjkQ0 Content-Type: multipart/mixed; boundary="------------7a22TXAifxypLWqiFjNtqLoM"; protected-headers="v1" From: Juergen Gross To: Maximilian Heyne Cc: Josh Poimboeuf , Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <2f70c3fc-fdb6-450c-d570-f39280798872@suse.com> Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid References: <20220517162425.100567-1-mheyne@amazon.de> In-Reply-To: <20220517162425.100567-1-mheyne@amazon.de> --------------7a22TXAifxypLWqiFjNtqLoM Content-Type: multipart/mixed; boundary="------------dPizdxr0IEHdFSKZq8XyRjCl" --------------dPizdxr0IEHdFSKZq8XyRjCl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDUuMjIgMTg6MjQsIE1heGltaWxpYW4gSGV5bmUgd3JvdGU6DQo+IFNpbmNlIGNv bW1pdCA0ZDY1YWRmY2QxMTkgKCJ4ODY6IHhlbjogaW5zbjogRGVjb2RlIFhlbiBhbmQgS1ZN DQo+IGVtdWxhdGUtcHJlZml4IHNpZ25hdHVyZSIpLCBvYmp0b29sIGlzIGFibGUgdG8gY29y cmVjdGx5IHBhcnNlIHRoZQ0KPiBwcmVmaXhlZCBpbnN0cnVjdGlvbiBpbiB4ZW5fY3B1aWQg YW5kIGVtaXQgY29ycmVjdCBvcmMgdW53aW5kDQo+IGluZm9ybWF0aW9uLiBIZW5jZSwgbWFy a2luZyB0aGUgZnVuY3Rpb24gYXMgU1RBQ0tGUkFNRV9OT05fU1RBTkRBUkQgaXMNCj4gbm8g bG9uZ2VyIG5lZWRlZC4NCj4gDQo+IFRoaXMgY29tbWl0IGlzIGJhc2ljYWxseSBhIHJldmVy dCBvZiBjb21taXQgOTgzYmI2ZDI1NGM3ICgieDg2L3hlbjogTWFyaw0KPiB4ZW5fY3B1aWQo KSBzdGFjayBmcmFtZSBhcyBub24tc3RhbmRhcmQiKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6 IE1heGltaWxpYW4gSGV5bmUgPG1oZXluZUBhbWF6b24uZGU+DQo+IENDOiBKb3NoIFBvaW1i b2V1ZiA8anBvaW1ib2VAa2VybmVsLm9yZz4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZv ci1saW51cy01LjE5DQoNCg0KSnVlcmdlbg0K --------------dPizdxr0IEHdFSKZq8XyRjCl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dPizdxr0IEHdFSKZq8XyRjCl-- --------------7a22TXAifxypLWqiFjNtqLoM-- --------------UjP09znP3YBjHC9yreCDjkQ0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKKGZAFAwAAAAAACgkQsN6d1ii/Ey9t Ygf/RyJdnElkqpjOx/hFvASnaqEo7bBY8I6oLiz+H1XOZCxW+x8y71NU3WJA+8ykTLg2jDk9rpKB cJSXWWfK7MjVs3Ku05PnvzawCYdYPJybbrvfEYMEdAQfF5SPTxKXlLFCUr1guf6JtlnvaxuC08yo kHFgxaCc2ewm6w+XBlih3TJQ1wEN3fbNhbhLdHgTKZLJv6H1WYj+JACGG8j6e/YDvx8ZpMOlDiLD 8AL8HRmhf66IZTLxwOMcV4XPi6Ukz+asrWE2FDRa/lmGdAJei/UqDkZyMZR8FHPLAkyH6o7c6Ous mjzb5QG70tHNJLW3Cx3t2ViPXsjJefvxSKKW+uJhpQ== =tVnq -----END PGP SIGNATURE----- --------------UjP09znP3YBjHC9yreCDjkQ0-- From xen-devel-bounces@lists.xenproject.org Sun May 22 11:09:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 11:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335085.559218 (Exim 4.92) (envelope-from ) id 1nsjSI-00052J-C9; Sun, 22 May 2022 11:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335085.559218; Sun, 22 May 2022 11:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjSI-00052C-78; Sun, 22 May 2022 11:09:02 +0000 Received: by outflank-mailman (input) for mailman id 335085; Sun, 22 May 2022 11:09:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjSH-00051w-92; Sun, 22 May 2022 11:09:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjSH-0005i7-6M; Sun, 22 May 2022 11:09:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjSG-0003nf-PX; Sun, 22 May 2022 11:09:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsjSG-0003Y1-P8; Sun, 22 May 2022 11:09:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q8Puerqr/odSt0y9fdWbPP6fAi9dbBuW4MPhBngDG0s=; b=zfUogQu2IFXbmb8kkNQGIBrRV4 UfcPkSlsgY7JqGkPVYHRZzkicQcCvRPnfQAyf/2opDh5ocHUVVIgEq2qJVYArl1pV0SHybjvLtdKL A/eO8+T1TKIk0fBEJjR6ag5c11Jc3Lt1bIzK5z8CqEUb+Ll+o6LLPSWE1pgQYegkVcnQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170666: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 11:09:00 +0000 flight 170666 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170666/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1159 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 47 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 11:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 11:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335096.559229 (Exim 4.92) (envelope-from ) id 1nsjuO-00007Z-W6; Sun, 22 May 2022 11:38:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335096.559229; Sun, 22 May 2022 11:38:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjuO-00007S-RU; Sun, 22 May 2022 11:38:04 +0000 Received: by outflank-mailman (input) for mailman id 335096; Sun, 22 May 2022 11:38:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjuN-00007I-QM; Sun, 22 May 2022 11:38:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjuN-0006BQ-Nm; Sun, 22 May 2022 11:38:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsjuN-0004R1-FP; Sun, 22 May 2022 11:38:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsjuN-0001hl-Ey; Sun, 22 May 2022 11:38:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x4cobNAMbdrCLXfKzea8aSkm1aGnMK1VdBBOcY7XXiE=; b=xgxYSJUDMw0KfxuEqfBSJEfHCL oTVmihdfOVo7IhUpLZu5FHvL3uAHNs/7pAmEXra0I65jIIRip5DJ30C8t4h9N9YQqVUxYKBep+/Sz LEpfUMR6sgcWDpMt9uTp1cvn3nnkqnyVOELRYbTNiiNz2PPxTFDZ9vh6h8537ahzaAec=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170667: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 11:38:03 +0000 flight 170667 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170667/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1160 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 48 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 12:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 12:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335107.559240 (Exim 4.92) (envelope-from ) id 1nskg8-0005P4-2I; Sun, 22 May 2022 12:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335107.559240; Sun, 22 May 2022 12:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nskg7-0005Ox-VM; Sun, 22 May 2022 12:27:23 +0000 Received: by outflank-mailman (input) for mailman id 335107; Sun, 22 May 2022 12:27:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nskg6-0005Ol-DR; Sun, 22 May 2022 12:27:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nskg6-0006ze-B5; Sun, 22 May 2022 12:27:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nskg5-0005ko-Vn; Sun, 22 May 2022 12:27:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nskg5-0002bB-VM; Sun, 22 May 2022 12:27:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dx+6iDYjWWX2w7oxGhxW/YRN3Kwwtk5Kb/b7DxxKx/A=; b=T7cXupNb6NKkue1JVgrOSKxGEo yRVR3bMRRAt6LPunv6Yzm7fiu+e1tMfOo+kuJpi6cLSlrWWhYvEeFFftLWJqUZxZpeNA+iXDeQIIO 0UQoRugkUxUIuJMDSvaR5/TFrVCxBhGpZVOGfpu9dJvDCdUD6NAbJ5oG9SyI2s8Gt+JA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170668: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 12:27:21 +0000 flight 170668 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170668/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1161 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 49 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 13:40:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 13:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335117.559251 (Exim 4.92) (envelope-from ) id 1nslo6-00043p-Bp; Sun, 22 May 2022 13:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335117.559251; Sun, 22 May 2022 13:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nslo6-00043i-8I; Sun, 22 May 2022 13:39:42 +0000 Received: by outflank-mailman (input) for mailman id 335117; Sun, 22 May 2022 13:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nslo4-00043Y-V4; Sun, 22 May 2022 13:39:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nslo4-0008LP-TV; Sun, 22 May 2022 13:39:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nslo4-0007Zs-DI; Sun, 22 May 2022 13:39:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nslo4-0001jh-Co; Sun, 22 May 2022 13:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OnwONfC5GwLUyQeO0hMrRY3arn71ACKGJ5vU1VouT1I=; b=JRAPl3HsAAClTfBPdd3olKhEBP X5IADcOht1vNHwoFTs0ikcJ2xFmsjpd4lrO/N01uswCYzbiRRGN1auzK0kRtvwWcYWkCd7cMDHXTM PueTIvKseWrB9UV7m9r3+4/VTTQw2pHCJbvotrgFusyWv5kxwxz5CilymVtkmUsMwVyU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170669: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 13:39:40 +0000 flight 170669 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170669/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1162 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 50 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 14:07:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 14:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335127.559262 (Exim 4.92) (envelope-from ) id 1nsmEy-0007Os-Je; Sun, 22 May 2022 14:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335127.559262; Sun, 22 May 2022 14:07:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmEy-0007Ol-GH; Sun, 22 May 2022 14:07:28 +0000 Received: by outflank-mailman (input) for mailman id 335127; Sun, 22 May 2022 14:07:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmEx-0007Ob-8o; Sun, 22 May 2022 14:07:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmEx-0000Ss-7j; Sun, 22 May 2022 14:07:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmEw-0008Bv-U9; Sun, 22 May 2022 14:07:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsmEw-0005wk-Tg; Sun, 22 May 2022 14:07:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bzqpzdwW/JzZO7/dQ925ivrtTNxE+iOfUm4u2Vd1Hes=; b=c8+XH7A8cNsrIo56XMMkHasduv /JPtJuQTJsB+4gYpJ03ns1ZOAbC4VgAiLyeHfExmZn23z8Gp6SsLW6ZbAAuaanQ9De+qVMzZOF3h3 gKy+gDtHbJ1Js+yqBuMbM7fVzIakvf4mxamIUxMR0IJ9l8rzOURRFUFmExL6lwTgkiOo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170670: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 14:07:26 +0000 flight 170670 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1163 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 51 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 14:36:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 14:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335137.559273 (Exim 4.92) (envelope-from ) id 1nsmgs-0002Bd-VZ; Sun, 22 May 2022 14:36:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335137.559273; Sun, 22 May 2022 14:36:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmgs-0002BW-RK; Sun, 22 May 2022 14:36:18 +0000 Received: by outflank-mailman (input) for mailman id 335137; Sun, 22 May 2022 14:36:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmgr-0002BM-Tm; Sun, 22 May 2022 14:36:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmgr-0000vf-S0; Sun, 22 May 2022 14:36:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmgr-0000Ni-H4; Sun, 22 May 2022 14:36:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsmgr-0002fy-Gc; Sun, 22 May 2022 14:36:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0ywWj8a61KWSEki0nKCp2dWiNEwoeC/c6C1LhsWVBn8=; b=0smmeeskCDrgBmBQhUroy29gSQ y/TjYNfKoJF0grVkr/QqsXZNb1ROOUQbDc8lRCEEIBdiRy6nzzS5EhydTsyVezMVzK1qN3i6Eyc1Q wlHZ/Q3lIzNrEpjhH83fvwKRxlpn7oYipeVnIuyQ672E68vBdLjtdoXmui1uSM4UXHJg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170671: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 14:36:17 +0000 flight 170671 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170671/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1164 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 52 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 14:55:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 14:55:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335148.559283 (Exim 4.92) (envelope-from ) id 1nsmzA-0004dX-Jv; Sun, 22 May 2022 14:55:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335148.559283; Sun, 22 May 2022 14:55:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmzA-0004dQ-HP; Sun, 22 May 2022 14:55:12 +0000 Received: by outflank-mailman (input) for mailman id 335148; Sun, 22 May 2022 14:55:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmz9-0004dG-NN; Sun, 22 May 2022 14:55:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmz9-0001DJ-LU; Sun, 22 May 2022 14:55:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsmz9-0000q8-AI; Sun, 22 May 2022 14:55:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsmz9-0005M1-9q; Sun, 22 May 2022 14:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TRs0x2irGmHgYZPdcpHIHC0S5MIxXJR3xHMfOfyXcDA=; b=h1kvONDyvroDLKnBv99Lp2hWIU x97/GvBX42cpRVkEA6jyU5aMemLUQNeeTWbuBBtUQNkEFJDvRHunronY4udKFBYupb36aelzQkFVZ d8XOeplOSyoHm75t35sDvfvtu7CNMd7qiMarP9Gxq6Sv/3ZyxHu4plqxSt40lNb+OmR8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170661: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=eaea45fc0e7b6ae439526b4a41d91230c8517336 X-Osstest-Versions-That: linux=6c3f5bec9b40b9437410abb08eccd5cdd1598a3c From: osstest service owner Date: Sun, 22 May 2022 14:55:11 +0000 flight 170661 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170661/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170651 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170651 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170651 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170651 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170651 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170651 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170651 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170651 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170651 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux eaea45fc0e7b6ae439526b4a41d91230c8517336 baseline version: linux 6c3f5bec9b40b9437410abb08eccd5cdd1598a3c Last test of basis 170651 2022-05-21 19:41:06 Z 0 days Testing same since 170661 2022-05-22 04:29:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arnaldo Carvalho de Melo Athira Jajeev Athira Rajeev Athira Rajeev --- Avri Altman Chengdong Li Daejun Park Disha Goel Dmitry Torokhov Ian Rogers Kan Liang Linus Torvalds Marek Vasut Martin K. Petersen Mattijs Korpershoek Mingzhe Zou Namhyung Kim Thomas Richter jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6c3f5bec9b40..eaea45fc0e7b eaea45fc0e7b6ae439526b4a41d91230c8517336 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun May 22 15:17:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 15:17:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335159.559294 (Exim 4.92) (envelope-from ) id 1nsnKL-0007Ku-F9; Sun, 22 May 2022 15:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335159.559294; Sun, 22 May 2022 15:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsnKL-0007Kn-C9; Sun, 22 May 2022 15:17:05 +0000 Received: by outflank-mailman (input) for mailman id 335159; Sun, 22 May 2022 15:17:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsnKK-0007Kd-FD; Sun, 22 May 2022 15:17:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsnKK-0001bt-B9; Sun, 22 May 2022 15:17:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsnKJ-0001KA-UZ; Sun, 22 May 2022 15:17:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsnKJ-0001M4-U7; Sun, 22 May 2022 15:17:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Zdk0Tlw0umDWKEH7ueZPfGAsqgsd/CMe3/+ORFN1NbQ=; b=4672yJAka3W6PYTmuMD4N3kn6c 4jqn4JpzpxutRXkDGj/bO/zwdM5I5rssljpr+MMP3hAGHg2gwr2AEC+o3YBD0Bu2bbTV8tjo7+mlH BPYL0gH8ApnhAPQ6WNwxzZoEcHWRQjI11wlCa8Ji5zfhyBsIBuR6fJ6M1m+SJaHtxAqs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170672: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 15:17:03 +0000 flight 170672 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1165 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 53 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 16:34:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 16:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335169.559306 (Exim 4.92) (envelope-from ) id 1nsoWc-00077d-6X; Sun, 22 May 2022 16:33:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335169.559306; Sun, 22 May 2022 16:33:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsoWc-00077W-3a; Sun, 22 May 2022 16:33:50 +0000 Received: by outflank-mailman (input) for mailman id 335169; Sun, 22 May 2022 16:33:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsoWa-00077M-Gi; Sun, 22 May 2022 16:33:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsoWa-0003LQ-DH; Sun, 22 May 2022 16:33:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsoWZ-0002xu-V8; Sun, 22 May 2022 16:33:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsoWZ-0002Au-Uj; Sun, 22 May 2022 16:33:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KOhRXD8c4t032iwnWO2dlfbp3SCsByo4gAFEjpJbJHk=; b=fkQ4zBFYxHEspHt+RcHjpIh4jR pth2frPbJZ1D10Xt5BupV3uRvJKvSa8iWaIC+F0Lo3kl4mPDXYk1a6ThQjeTIa3j58s6ZmL+8mALg zBatlUSOij0wyZVhldJi0uVvshn0B54sG65NLrernkZ34blO+RTF/BYGEzvFbcwQyNno=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170673: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 16:33:47 +0000 flight 170673 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1166 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 54 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 16:59:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 16:59:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335180.559317 (Exim 4.92) (envelope-from ) id 1nsov7-0001Ak-B6; Sun, 22 May 2022 16:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335180.559317; Sun, 22 May 2022 16:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsov7-0001Ad-8C; Sun, 22 May 2022 16:59:09 +0000 Received: by outflank-mailman (input) for mailman id 335180; Sun, 22 May 2022 16:59:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsov5-0001AX-KI for xen-devel@lists.xenproject.org; Sun, 22 May 2022 16:59:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsov5-0003kU-HT; Sun, 22 May 2022 16:59:07 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nsov5-0007oz-8o; Sun, 22 May 2022 16:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=2OHKG4CNbHIABlE0qBztVW9rVs14MrnSgfvgveIJfz4=; b=vn91Za +LRukmHabTBmMjPQTvan6t9BHUGjRiGadxUAfoO26ziG8Za1t9s6jaQHArGatwZ3tk8cIBW8Iy2nE 6/WFiqXKRkEt8t9I4OWgjKcWmLuNK/GlQkzmUy/iNjuzU1cOH12p0JdlEcCA4PCWYVB1Cok/Bu6Fy Yxv+Pc/TTNI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini Subject: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() Date: Sun, 22 May 2022 17:59:00 +0100 Message-Id: <20220522165900.83104-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall xsm_deasign_dtdevice() will indicate whether the caller is allowed to issue the operation. So the return value has to be checked. Spotted by clang static analyzer. Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") Signed-off-by: Julien Grall --- Platform device-passthrough is not security supported. Hence why this is sent directly to xen-devel. --- xen/drivers/passthrough/device_tree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 98f2aa0dad68..1c32d7b50cce 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -269,6 +269,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct domain *d, break; ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)); + if ( ret ) + break; if ( d == dom_io ) return -EINVAL; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Sun May 22 17:09:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 17:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335188.559328 (Exim 4.92) (envelope-from ) id 1nsp5K-0002gG-BA; Sun, 22 May 2022 17:09:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335188.559328; Sun, 22 May 2022 17:09:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsp5K-0002g9-7x; Sun, 22 May 2022 17:09:42 +0000 Received: by outflank-mailman (input) for mailman id 335188; Sun, 22 May 2022 17:09:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsp5I-0002fz-Vn; Sun, 22 May 2022 17:09:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsp5I-0003wY-St; Sun, 22 May 2022 17:09:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsp5I-0003jh-ED; Sun, 22 May 2022 17:09:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsp5I-0001G2-Dj; Sun, 22 May 2022 17:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z4PrPCx8MqXpnLEzcqWIaC2F/7vLybg1EG/+CQvPsl8=; b=JXiXBnBr+4fqZvPQMQWs8S6N4/ Wephvam/cTv7mab2TN+QzZ4DVMQUBkP+SgeT0y6Ndb7kgBlABlLrq8lSagsqz8NkxL4qKV4j+BMeK CtwxFcLDJfqusQX8bKnDlNuNbVuNsjcSidL/F72jqXOa9GDSlQb1tusEsHFzTDMaaeWk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170674: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 17:09:40 +0000 flight 170674 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170674/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1167 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 55 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 17:56:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 17:56:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335199.559338 (Exim 4.92) (envelope-from ) id 1nspoa-0007ef-VJ; Sun, 22 May 2022 17:56:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335199.559338; Sun, 22 May 2022 17:56:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nspoa-0007eY-Se; Sun, 22 May 2022 17:56:28 +0000 Received: by outflank-mailman (input) for mailman id 335199; Sun, 22 May 2022 17:56:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nspoZ-0007eO-IO; Sun, 22 May 2022 17:56:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nspoZ-0004gz-Gc; Sun, 22 May 2022 17:56:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nspoZ-0004kC-3E; Sun, 22 May 2022 17:56:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nspoZ-0005Xu-2l; Sun, 22 May 2022 17:56:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eXDPO0xY64C1j3WtxxKy4lVHW2qT6dZvGjYACz31wKw=; b=qUn+SuLzs+PvMEx7pBtHnShEh+ Ia9c+43E9Ti/gXT3mXsi1O2WbjAs4B84ob9ChHRoIu2NoBlG8LE0JZBAoQts95lc62u+KFFVoeHDE bGxYSu4Q+/BnhxklmEqWOfpVAvHASRLC9UlIu9D69NdAjhUp4lYry094vWU6PwhmuEaw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170675: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 17:56:27 +0000 flight 170675 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170675/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1168 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 56 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 19:40:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 19:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335209.559349 (Exim 4.92) (envelope-from ) id 1nsrQU-0000Jn-Ec; Sun, 22 May 2022 19:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335209.559349; Sun, 22 May 2022 19:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsrQU-0000Jg-C1; Sun, 22 May 2022 19:39:42 +0000 Received: by outflank-mailman (input) for mailman id 335209; Sun, 22 May 2022 19:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsrQT-0000JW-39; Sun, 22 May 2022 19:39:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsrQT-0006S0-0M; Sun, 22 May 2022 19:39:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsrQS-00082V-Ge; Sun, 22 May 2022 19:39:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsrQS-0007Ru-GG; Sun, 22 May 2022 19:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M7M/8wFr2+GRoyKlPU16oYn4IgbLhtAp3cDf5HXeTsI=; b=Fmt7T3zVZRqt5hloi3ffBimyof I3dJflpzi6i9CW4V1+6trq+SmDJc0Ebnz7BGlrsObVF1tW2MCg2ELoLvWCFGYIY5IX26zc1460yGU cPXBrFWb/JMufwDfB7Ttsrivc+s7TgXWAaPwmg/1dNubWy8FIEacnSfrMK0WeqbrbR5w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170677: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 19:39:40 +0000 flight 170677 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170677/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1169 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 57 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 20:17:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 20:17:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335219.559360 (Exim 4.92) (envelope-from ) id 1nss10-0004Sp-CY; Sun, 22 May 2022 20:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335219.559360; Sun, 22 May 2022 20:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nss10-0004Si-9U; Sun, 22 May 2022 20:17:26 +0000 Received: by outflank-mailman (input) for mailman id 335219; Sun, 22 May 2022 20:17:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nss0z-0004SY-0M; Sun, 22 May 2022 20:17:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nss0y-0007BZ-S0; Sun, 22 May 2022 20:17:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nss0y-0001lb-Hp; Sun, 22 May 2022 20:17:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nss0y-0008O6-HP; Sun, 22 May 2022 20:17:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IHSkN5sdcajqZc4lBxGPK3o7HNnKMWgiooIra30t6Bg=; b=OQc9s3M1tX80XHYWULno+bGORj 6VqtL2oTyCo4oqcDMMqtKFlqjrHpcPBDUreUyJw5styA1w4qIKMiuocrOvEXDPia8sxVrn4+55Hfa yIffl62GJ6GJR/NFSwnP1HeiWFZs6UOvfyudjaInlBHKI55Pq1WHcbKqsFbEjg+8aq1M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170678: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 20:17:24 +0000 flight 170678 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170678/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1170 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 58 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 21:48:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 21:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335230.559372 (Exim 4.92) (envelope-from ) id 1nstQt-0004ba-8S; Sun, 22 May 2022 21:48:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335230.559372; Sun, 22 May 2022 21:48:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nstQt-0004bT-5j; Sun, 22 May 2022 21:48:15 +0000 Received: by outflank-mailman (input) for mailman id 335230; Sun, 22 May 2022 21:48:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nstQs-0004bJ-9I; Sun, 22 May 2022 21:48:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nstQs-0000G9-8D; Sun, 22 May 2022 21:48:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nstQr-00057b-SG; Sun, 22 May 2022 21:48:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nstQr-0006lK-Rp; Sun, 22 May 2022 21:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1XQnFo30U69BphqzhyasDjWr8jDXnCzPBea7fSLtzUk=; b=o5F8hkR/1KaK0R2WaEu73GJaPl ZoPe1WYGzdAAT2KKCE4yCwbSM6wzbKwTFnQa3bdTzCy6EJLAUfYKkHhVoQMlZ3vLKTokh0eSxhdbc 21LX1Y6qCttFv60UXCqubqSYEWih/M9fVcEH9WExRLKAgGkCd74UswoeB3F+4QAGiCpc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170679: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 21:48:13 +0000 flight 170679 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170679/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1171 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 59 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 22:38:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 22:38:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335240.559383 (Exim 4.92) (envelope-from ) id 1nsuDd-0001Bh-49; Sun, 22 May 2022 22:38:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335240.559383; Sun, 22 May 2022 22:38:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuDd-0001Ba-1D; Sun, 22 May 2022 22:38:37 +0000 Received: by outflank-mailman (input) for mailman id 335240; Sun, 22 May 2022 22:38:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuDb-0001BO-JL; Sun, 22 May 2022 22:38:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuDb-00015f-HU; Sun, 22 May 2022 22:38:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuDb-0006TE-Af; Sun, 22 May 2022 22:38:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsuDb-0002d7-AD; Sun, 22 May 2022 22:38:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TR6IbWWkn11zG1xY6hjakugFeJOS/XZPIStGou/APWs=; b=xGtI6moxdogPWPVuDrhLDBBtOo AmtDlRnF4Aszz0nsk07HBl/07dV4I5IK+Rotuh/1erSA78Nx1h3k/RDO2LdTY90RoG0DetWuQgr8z u9z9CBmTJU1z9tW2lQC4NxxiNvdJWrNrw0K6tH4s5ZPXwgYxe9UnJ0J0TGFMIJzJTf8c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170680: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 22:38:35 +0000 flight 170680 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170680/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1172 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 60 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 22 23:28:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 22 May 2022 23:28:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335250.559394 (Exim 4.92) (envelope-from ) id 1nsuzA-00069s-SG; Sun, 22 May 2022 23:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335250.559394; Sun, 22 May 2022 23:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuzA-00069l-PF; Sun, 22 May 2022 23:27:44 +0000 Received: by outflank-mailman (input) for mailman id 335250; Sun, 22 May 2022 23:27:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuz9-00069b-39; Sun, 22 May 2022 23:27:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuz9-0001tf-1u; Sun, 22 May 2022 23:27:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsuz8-0007fJ-DE; Sun, 22 May 2022 23:27:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsuz8-0001rB-Cl; Sun, 22 May 2022 23:27:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZXdWcA7+k2KNcwHIqBipF2E+B4DqO1YoraFFBq5kSe4=; b=PdCBF0yjchRmxJ9yUla2p3huuk J3fMBeGztx1YBwVY7r+eg0K0HUwV7dztL4v+J2QMSGALHDM1NUqb7BpnKwltw5FN7tTKPjqn/wM2C VVYS9f4Lv7xCqVVKjXz6qtJczNeujJOY8ENukTt6hLp/dZclCBJzN9n0vGEWsepFCkfo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170681: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Sun, 22 May 2022 23:27:42 +0000 flight 170681 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170681/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1173 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 61 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 00:25:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 00:25:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335260.559405 (Exim 4.92) (envelope-from ) id 1nsvtC-0004BQ-FI; Mon, 23 May 2022 00:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335260.559405; Mon, 23 May 2022 00:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsvtC-0004BJ-C6; Mon, 23 May 2022 00:25:38 +0000 Received: by outflank-mailman (input) for mailman id 335260; Mon, 23 May 2022 00:25:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsvtA-0004B9-Hq; Mon, 23 May 2022 00:25:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsvtA-0003S9-FC; Mon, 23 May 2022 00:25:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsvt9-0000Vc-Vv; Mon, 23 May 2022 00:25:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsvt9-00063M-VR; Mon, 23 May 2022 00:25:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/L5HeVRQCU6rsexLhRi/KKL3q7MTaiifqwRL93BWBC4=; b=YJPf1NulaODKShsivWpwKWhh70 4X92+2cxINbgNuYCMyloLcfrEyqL/KVmjGyCzZtkrasN+Z9RMsuq0EUHe48y+tvFDPv6rOiZhJ1PY a3zFTPrb8Mx/sXG8M2WoJCL/LwMju0RYOAVMH5CGcG60eFAIStgm+s2ZsMAIzwmv1xOQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170676: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=978df3e158467ae09be635b27e9e1eb990704e0b X-Osstest-Versions-That: linux=eaea45fc0e7b6ae439526b4a41d91230c8517336 From: osstest service owner Date: Mon, 23 May 2022 00:25:35 +0000 flight 170676 linux-linus real [real] flight 170682 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170676/ http://logs.test-lab.xenproject.org/osstest/logs/170682/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 170682-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 170682 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 170682 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170661 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170661 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170661 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170661 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170661 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170661 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170661 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170661 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 978df3e158467ae09be635b27e9e1eb990704e0b baseline version: linux eaea45fc0e7b6ae439526b4a41d91230c8517336 Last test of basis 170661 2022-05-22 04:29:36 Z 0 days Testing same since 170676 2022-05-22 18:09:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Mika Westerberg Piyush Malgujar Szymon Balcerak Wolfram Sang Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git eaea45fc0e7b..978df3e15846 978df3e158467ae09be635b27e9e1eb990704e0b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 23 00:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 00:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335270.559416 (Exim 4.92) (envelope-from ) id 1nsw4X-0005iB-Lx; Mon, 23 May 2022 00:37:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335270.559416; Mon, 23 May 2022 00:37:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsw4X-0005i4-J4; Mon, 23 May 2022 00:37:21 +0000 Received: by outflank-mailman (input) for mailman id 335270; Mon, 23 May 2022 00:37:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsw4W-0005hu-RV; Mon, 23 May 2022 00:37:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsw4W-0003dG-PD; Mon, 23 May 2022 00:37:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsw4W-0000mh-9Z; Mon, 23 May 2022 00:37:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsw4W-0003iZ-96; Mon, 23 May 2022 00:37:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1c7A4ZMiervlfqZ2FSxTLZ+B9ykiToLsjarzqVnT8lQ=; b=3hjpVFNRLz31yJD8tp/I3QGEPI UCYH25QUsk9DbEGmuIOrEYrmQuXOYu9VXztM+jWb76R458z4LTiyHhm9yqjiqlDIIaILwZI9k7HVl C+Nr67zE2XPgMQW83+0YI6uHefr58GRou/9Es/2j877yY+bS4Is4uFvBmnaxnqFOJNHU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170683: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 00:37:20 +0000 flight 170683 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170683/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1174 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 62 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 01:23:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 01:23:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335280.559426 (Exim 4.92) (envelope-from ) id 1nswnG-0000UF-7t; Mon, 23 May 2022 01:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335280.559426; Mon, 23 May 2022 01:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nswnG-0000U8-4x; Mon, 23 May 2022 01:23:34 +0000 Received: by outflank-mailman (input) for mailman id 335280; Mon, 23 May 2022 01:23:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nswnF-0000Tx-2V; Mon, 23 May 2022 01:23:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nswnF-0002Ga-03; Mon, 23 May 2022 01:23:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nswnE-0001mm-NI; Mon, 23 May 2022 01:23:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nswnE-0004ml-Ms; Mon, 23 May 2022 01:23:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mc+cPGRDQAdcvVdNSqsd4+CmMfnzbLGOn7fVDjZPsH0=; b=OW7+yP5FEqzzAhV1Rd1nX4+9dL YPToEk9CXvFOUMPMab1F+N5G88NbD8AfACfGrO524Gm8snkwY6kQGdzr7sdZ+OwDXxKaDGGdMwr++ 3USRFj6nMQy25ZynwkKyw3KJLAWdl6EqbmhnG4tzDFGNyjjZ60HFmWSroT8Kqkb375kA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170685: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 01:23:32 +0000 flight 170685 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 82 days 1175 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 63 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 02:28:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 02:28:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335290.559438 (Exim 4.92) (envelope-from ) id 1nsxnd-0006vh-0F; Mon, 23 May 2022 02:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335290.559438; Mon, 23 May 2022 02:28:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsxnc-0006va-Tj; Mon, 23 May 2022 02:28:00 +0000 Received: by outflank-mailman (input) for mailman id 335290; Mon, 23 May 2022 02:27:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsxnb-0006vQ-Ht; Mon, 23 May 2022 02:27:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsxnb-0003lF-Ft; Mon, 23 May 2022 02:27:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsxnb-0005MY-5Q; Mon, 23 May 2022 02:27:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsxnb-0002T5-4u; Mon, 23 May 2022 02:27:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zPC9HVa6x+gTqnuFTerFL6RFtgjUyPXrLlYtXbzEPQM=; b=TDN4B5vZklWTb26lhumJO9BQe/ VzhMQy07ApCIHhb2GyL7L62khn77WemYlzIar14/R1hX8i28If+N4q16IssmasN5nqPc4C8vT2kdd FYr3mxPaO7mtfatRDylShjpGbm6GoSQQc+RUbGjWKteLbf5t1214T6KI8/3nnUSoch6Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170686: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 02:27:59 +0000 flight 170686 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170686/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1176 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 64 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 03:28:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 03:28:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335302.559449 (Exim 4.92) (envelope-from ) id 1nsyjj-0004rn-Ke; Mon, 23 May 2022 03:28:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335302.559449; Mon, 23 May 2022 03:28:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsyjj-0004rg-H6; Mon, 23 May 2022 03:28:03 +0000 Received: by outflank-mailman (input) for mailman id 335302; Mon, 23 May 2022 03:28:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsyjh-0004rW-P2; Mon, 23 May 2022 03:28:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsyjh-0005DZ-MO; Mon, 23 May 2022 03:28:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nsyjh-0008EQ-CQ; Mon, 23 May 2022 03:28:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nsyjh-0002VW-By; Mon, 23 May 2022 03:28:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Sio5pAr3P936eDOMcVpw2qcy8/+tSv0bXe3TGXc/jB0=; b=nPhZTwz+QP7Mpn2jI78S6H4cf3 Kc54pBXtm8nQWsRFePYyWZanhaLMp0zJwU6OvUCyMvmvSDzh3UimX0upAoET4dggr1E6sXPuSJ9h+ SMsPA/jrt6/BOwGlMNt23+aFW99h4CRgZOE2o68b6duISSoZa8tKiFWWYOR3zux4QvAI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170688: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 03:28:01 +0000 flight 170688 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1177 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 65 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 05:15:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 05:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335313.559459 (Exim 4.92) (envelope-from ) id 1nt0PQ-0007OY-Nb; Mon, 23 May 2022 05:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335313.559459; Mon, 23 May 2022 05:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0PQ-0007OR-Kd; Mon, 23 May 2022 05:15:12 +0000 Received: by outflank-mailman (input) for mailman id 335313; Mon, 23 May 2022 05:15:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0PP-0007OH-Ds; Mon, 23 May 2022 05:15:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0PP-0007UK-7k; Mon, 23 May 2022 05:15:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0PO-0006jm-Mc; Mon, 23 May 2022 05:15:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt0PO-0007vv-M6; Mon, 23 May 2022 05:15:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YfYRNm8dvt+OZjlqD5vqib8ciiHr3M8CNJbnvHOVeB0=; b=6pxo81xIkZ2xGe+nVDmTOKkU4S jgkXCBgqWznincYftZBaEaugDAqrF09WrGc7kZTS0AYFudOTlKZEEGx3XrP2mwdW1l4jucnMsErNu RXhVrTSwrxtoRERTapCDEPnIZmdMWT7H0/a+yH+cH5+z2AYAFSfIwIosP08tdXQlhSBA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170689: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 05:15:10 +0000 flight 170689 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1178 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 66 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 05:31:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 05:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335323.559471 (Exim 4.92) (envelope-from ) id 1nt0er-0001F8-5Z; Mon, 23 May 2022 05:31:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335323.559471; Mon, 23 May 2022 05:31:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0er-0001F1-2U; Mon, 23 May 2022 05:31:09 +0000 Received: by outflank-mailman (input) for mailman id 335323; Mon, 23 May 2022 05:31:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt0ep-0001Ev-Bd for xen-devel@lists.xenproject.org; Mon, 23 May 2022 05:31:07 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ac01e31-da59-11ec-837e-e5687231ffcc; Mon, 23 May 2022 07:31:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 379D71F383; Mon, 23 May 2022 05:31:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12F2313A5F; Mon, 23 May 2022 05:31:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sVReAxkci2K2bAAAMHmgww (envelope-from ); Mon, 23 May 2022 05:31:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ac01e31-da59-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653283865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uphm0Y/N5CG4YBHQqvTXWrYN71GenUf/+ErGraqLDVw=; b=oe0ld5c9q1l5HfqybFBHAgBmpX6oV8nAMIA4HoOXTmFMJ77+3cGiMQBN0qk2K42kg1vs2g qEK2g3iFiJQ3xcrOBBkzSMsjO7ZWSWfjFHQtbtfBWdxyl/TKls8B4agxhcTSg/Oa0vUKW2 yjrm6zLfrK/fxscwCKTbJCKyry4z0Rs= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.19-rc1 Date: Mon, 23 May 2022 07:31:04 +0200 Message-Id: <20220523053104.22814-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19-rc1-tag xen: branch for v5.19-rc1 It contains: - a series for the Xen scsifront/scsiback pv drivers to decouple the PV interface from kernel internals - a patch to harden the Xen scsifront PV driver against a malicious backend driver - a series to simplify Xen PV frontend driver ring page setup - a series to support Xen setups with multiple domains created at boot time to tolerate Xenstore coming up late - two small cleanup patches Thanks. Juergen Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 +- .../ABI/testing/sysfs-driver-xen-blkfront | 2 +- arch/x86/xen/enlighten_pv.c | 2 - drivers/block/xen-blkfront.c | 57 ++---- drivers/char/tpm/xen-tpmfront.c | 18 +- drivers/gpu/drm/xen/xen_drm_front.h | 9 - drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 43 ++--- drivers/net/xen-netfront.c | 85 +++------ drivers/pci/xen-pcifront.c | 19 +- drivers/scsi/xen-scsifront.c | 199 ++++++++++++++------- drivers/usb/host/xen-hcd.c | 65 ++----- drivers/xen/gntdev-dmabuf.c | 13 +- drivers/xen/grant-table.c | 12 +- drivers/xen/xen-front-pgdir-shbuf.c | 18 +- drivers/xen/xen-scsiback.c | 82 ++++++++- drivers/xen/xenbus/xenbus_client.c | 82 ++++++--- drivers/xen/xenbus/xenbus_probe.c | 91 +++++++--- include/xen/grant_table.h | 2 - include/xen/interface/grant_table.h | 161 ++++++++++------- include/xen/interface/io/ring.h | 19 +- include/xen/interface/io/vscsiif.h | 133 +++++++++++++- include/xen/interface/io/xs_wire.h | 37 +++- include/xen/xenbus.h | 4 +- sound/xen/xen_snd_front_evtchnl.c | 44 ++--- sound/xen/xen_snd_front_evtchnl.h | 9 - 25 files changed, 734 insertions(+), 476 deletions(-) Juergen Gross (25): xen: update vscsiif.h xen/scsiback: use new command result macros xen/scsifront: use new command result macros xen/scsifront: harden driver against malicious backend xen: update grant_table.h xen/grant-table: never put a reserved grant on the free list xen/blkfront: switch blkfront to use INVALID_GRANT_REF xen/netfront: switch netfront to use INVALID_GRANT_REF xen/scsifront: remove unused GRANT_INVALID_REF definition xen/usb: switch xen-hcd to use INVALID_GRANT_REF xen/drm: switch xen_drm_front to use INVALID_GRANT_REF xen/sound: switch xen_snd_front to use INVALID_GRANT_REF xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF xen: update ring.h xen/xenbus: add xenbus_setup_ring() service function xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/xenbus: eliminate xenbus_grant_ring() Luca Miccio (1): xen: add support for initializing xenstore later as HVM domain Maximilian Heyne (1): x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid SeongJae Park (1): xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent Stefano Stabellini (1): xen: sync xs_wire.h header with upstream xen From xen-devel-bounces@lists.xenproject.org Mon May 23 06:06:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:06:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335331.559482 (Exim 4.92) (envelope-from ) id 1nt1Cl-0004bF-Rj; Mon, 23 May 2022 06:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335331.559482; Mon, 23 May 2022 06:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1Cl-0004b8-Ok; Mon, 23 May 2022 06:06:11 +0000 Received: by outflank-mailman (input) for mailman id 335331; Mon, 23 May 2022 06:06:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1Ck-0004b2-07 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:06:10 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e688f49-da5e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:06:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B67641F899; Mon, 23 May 2022 06:06:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E77C13AA5; Mon, 23 May 2022 06:06:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1CrOF00ki2JIdwAAMHmgww (envelope-from ); Mon, 23 May 2022 06:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e688f49-da5e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653285965; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBol9KN+kIIDQUlOQe3NDj96wloUsVN38d0jaLqznSY=; b=pBX1vuGF+578QbT4NwNKmfgVuxNM+kCUdYmeLTA2tP2wHfqSHq/hSCEh05cLzZ6XK9gHra 4g7nR8xi5QmBpb6u7OUPJPaZO2zATRuv1k7ZzvDfRye9Nj9xLHtWjOan1QoXUSzdL8OsD9 p0Qk/sHiLuWiFDOjTiUMq3Nvd+xv2l0= Message-ID: <54c20bf3-85eb-29f7-35e7-906436e4cb75@suse.com> Date: Mon, 23 May 2022 08:06:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7 5/7] xenstored: send an evtchn notification on introduce_domain Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini References: <20220513210730.679871-5-sstabellini@kernel.org> From: Juergen Gross In-Reply-To: <20220513210730.679871-5-sstabellini@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CgdslzVUpSB6QkQGJQyZhE3g" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CgdslzVUpSB6QkQGJQyZhE3g Content-Type: multipart/mixed; boundary="------------EXfsNMHh6OoBwmctGTXbUkpS"; protected-headers="v1" From: Juergen Gross To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini Message-ID: <54c20bf3-85eb-29f7-35e7-906436e4cb75@suse.com> Subject: Re: [PATCH v7 5/7] xenstored: send an evtchn notification on introduce_domain References: <20220513210730.679871-5-sstabellini@kernel.org> In-Reply-To: <20220513210730.679871-5-sstabellini@kernel.org> --------------EXfsNMHh6OoBwmctGTXbUkpS Content-Type: multipart/mixed; boundary="------------0x47wVZSPZvEVPpl0Znvzf8D" --------------0x47wVZSPZvEVPpl0Znvzf8D Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDUuMjIgMjM6MDcsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gRnJvbTog THVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IA0KPiBXaGVuIHhzX2ludHJv ZHVjZV9kb21haW4gaXMgY2FsbGVkLCBzZW5kIG91dCBhIG5vdGlmaWNhdGlvbiBvbiB0aGUN Cj4geGVuc3RvcmUgZXZlbnQgY2hhbm5lbCBzbyB0aGF0IGFueSAoZG9tMGxlc3MpIGRvbWFp biB3YWl0aW5nIGZvciB0aGUNCj4geGVuc3RvcmUgaW50ZXJmYWNlIHRvIGJlIHJlYWR5IGNh biBjb250aW51ZSB3aXRoIHRoZSBpbml0aWFsaXphdGlvbi4NCj4gQmVmb3JlIHNlbmRpbmcg dGhlIG5vdGlmaWNhdGlvbiwgY2xlYXIgWEVOU1RPUkVfUkVDT05ORUNUSU5HLg0KPiANCj4g VGhlIGV4dHJhIG5vdGlmaWNhdGlvbiBpcyBoYXJtbGVzcyBmb3IgZG9tYWlucyB0aGF0IGRv bid0IHJlcXVpcmUgaXQuDQo+IA0KPiBJbiB4c193aXJlLmggdXBkYXRlIHRoZSBjb21tbWVu dCBvbiB0b3Agb2YgWEVOU1RPUkVfUkVDT05ORUNUSU5HIHRvDQo+IGdlbmVyYWxpemUgaXRz IG1lYW5pbmcgdG8gc3VpdCB0aGUgZG9tMGxlc3MgdXNlLWNhc2UgYmV0dGVyLiBBbHNvDQo+ IGltcHJvdmUgZG9jcy9taXNjL3hlbnN0b3JlLXJpbmcudHh0Lg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogTHVjYSBNaWNjaW8gPGx1Y21pY2Npb0BnbWFpbC5jb20+DQo+IFNpZ25lZC1vZmYt Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+ DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0K SnVlcmdlbg0K --------------0x47wVZSPZvEVPpl0Znvzf8D Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0x47wVZSPZvEVPpl0Znvzf8D-- --------------EXfsNMHh6OoBwmctGTXbUkpS-- --------------CgdslzVUpSB6QkQGJQyZhE3g Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKLJEwFAwAAAAAACgkQsN6d1ii/Ey+R awf/eYjN6A3e0u3x4FCs2q/MV6o0ioKN/+4T4P+BhZ2oSUCpXA5swawo2gITXY7KsyFk0J99ANpF Ku1pjl9AjG0O/BKTHbH7AwKXMfW+f4+czrnVnBEoGMFCaKIQ5IcjHxwCavuXP5gAMOx/zIDynWm3 y8yljiWHUsfog2KKXVCV6+R7eOlGyDJzdK/cp0vKaZcBBM+YoMyz7k8KPcZb/Td0oj84ZWe3McXf wGwrUaFCqgtEx2aB3W/3ULVXbskxaSboJB9ZgAsrpUHysjdbyK6fk0hBkDclFE3bKMrnElY1y60p e57z6iJj9bqV35qsQkW2yvcgYoX2jaC15umycui+0A== =kSe5 -----END PGP SIGNATURE----- --------------CgdslzVUpSB6QkQGJQyZhE3g-- From xen-devel-bounces@lists.xenproject.org Mon May 23 06:06:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:06:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335334.559493 (Exim 4.92) (envelope-from ) id 1nt1DG-00053B-79; Mon, 23 May 2022 06:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335334.559493; Mon, 23 May 2022 06:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1DG-000534-2q; Mon, 23 May 2022 06:06:42 +0000 Received: by outflank-mailman (input) for mailman id 335334; Mon, 23 May 2022 06:06:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1DE-00052c-0c; Mon, 23 May 2022 06:06:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1DD-0008PS-UA; Mon, 23 May 2022 06:06:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1DD-00013s-IT; Mon, 23 May 2022 06:06:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt1DD-0001uu-I0; Mon, 23 May 2022 06:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JErz93kTw3pwqM7AXdby0OgnixXv9U6cmY7buhhC2NE=; b=6NuP42RnAoCtpwkPk2G03qJYLP JWVxPlCTrT94MPEWtM3IplRzFj10npJ3X6tvBw4L/SEHpb6Czms+9LaGaXdc+hnzi5PEvskyxNP5K iAvfQCwnUQHhQj0MCsK+x5ZdlEBrqYzGkqA/bTsonVJSSxfLudmTproPEG5svjgPacr0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170691: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 06:06:39 +0000 flight 170691 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170691/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1179 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 67 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335351.559515 (Exim 4.92) (envelope-from ) id 1nt1W5-00085d-Ck; Mon, 23 May 2022 06:26:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335351.559515; Mon, 23 May 2022 06:26:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1W5-00085W-8w; Mon, 23 May 2022 06:26:09 +0000 Received: by outflank-mailman (input) for mailman id 335351; Mon, 23 May 2022 06:26:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1W3-0007pn-Ny for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1b::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a16bae3-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:26:06 +0200 (CEST) Received: from AS8PR07CA0054.eurprd07.prod.outlook.com (2603:10a6:20b:459::32) by PAXPR08MB7549.eurprd08.prod.outlook.com (2603:10a6:102:24c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 06:26:03 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::c0) by AS8PR07CA0054.outlook.office365.com (2603:10a6:20b:459::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.12 via Frontend Transport; Mon, 23 May 2022 06:26:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:02 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Mon, 23 May 2022 06:26:02 +0000 Received: from b2b1ae26b73d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49E9562D-944A-4F42-8459-EA8E520D366B.1; Mon, 23 May 2022 06:25:55 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2b1ae26b73d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:25:55 +0000 Received: from DB6P191CA0015.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::25) by VI1PR08MB4302.eurprd08.prod.outlook.com (2603:10a6:803:fb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 06:25:52 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::6c) by DB6P191CA0015.outlook.office365.com (2603:10a6:6:28::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 06:25:51 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:25:51 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:25:50 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:25:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a16bae3-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Fb4hL0yc09MLsc5zFMdAdz3FRS2CMqlYrpjijDzFgp4vypMRT6ZWxGCaRILJba5L3BRx4A3iVRKTsxMbmF/7uCuvgBD7RLHcQM2v7yPyYHssl6JtbEblpeycMLw1Zu+i4Z2IiQZncC9MFoEg+9pUkvRN/EV4+XUep5Wtklq6UXClBTBMurygzoj1E6xWWmAxTamaQQ8oVgfFvch+njX4GoxcVFVgzi/xgcHtVTYL5JlT2/jMQTfsldfnCZmeKUQ86aTJRpI8paajrWiSNNy2P+j1DdnFejsDlF/9o7NOOHYJVl6bsMJV8FuxIzLJ4qgJacVMkMztdF+8wg/TEnZOAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oo+mgb4JbHlmUNvz//rcx4bdSUBO9I8LAbHX+BGSbl8=; b=C6ey0GQe3dQ6sDy+bFe0OmrBZsl67YT3MOJYftRdhkJvEpALVxA8iX7jpvVuNmuDEOG8jiDeWWwehCeqZeZCJVgpzx7QyEW6wWXkvaiXxGDSGtSEn5Yr86mZvuDSRrm5isA8RgDW2V8i67Ggn+cVESpKY2M8GzsIfqKesmgPnu0JN3E0GRxkVffemqLrecDH0UalbQYG2hvoykOnIqioHNkd7iS940J8iTo2ypTrgmJFylhaXqFKVZoDAUF/9yjTq4uh7VaWvRqjezLRbrKuiXldrgtI+EvOvXKVTLpWPNe29VLymK6G/8ICXXMIZhAJU4iYBl9Gy0//3XMnc5GJpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oo+mgb4JbHlmUNvz//rcx4bdSUBO9I8LAbHX+BGSbl8=; b=naldSN/AGHLaBYh1998QuFBtcCjP00xCEuLo1/iN/nL/JpwVveuXzJhPpPo4EWe2PO79lxpRIsg/jPF4LGvHaXc1I9e/djX/FVvX3HubpxhRhIebzNRa5jhTRF1ObgvbYWrW+CNd8MBzV5stmzLxOX7VfS1n7rfZaELxQTqtHag= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 10ac714f71a4c7c1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ib1MBpQnmeGgtnymx/w4iwDdthDhyeILfda7T3zsGU4xk6r+QO2FoucSIAGNZsttkdYwTE+MytyPb2Yaju1aThdTa678jIH8J63TMDvXv4dfc8YgK0w+2B5KwvhRYhurPHO4QPtJf7U32CtqHeDqpTi2rTGF1R/DfJsOMI7yHY0Cedi/w962zssC3I6msAeTKXbRJANRJYkY69Dg83Xm3OirRvYFdNtZWphnbowGgrFGQmfvFO5f14LsdBhRoCls+RhRRPTlptpGoD6dr1Pabu6boZm60rYsaCNU9W590aLlxoFAkwkTgG79zpK0erccVipHqQjur6fQWNk0X8kvcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oo+mgb4JbHlmUNvz//rcx4bdSUBO9I8LAbHX+BGSbl8=; b=XdmlnRwpK7W9eKfvbtLlNcPxCv5xnwt22rLyJT6mXaKeiN6psNuFm+Z/+WRjBKAYn/bLfVyKenfUSyLPxKkOGXnaXeMr+9ti5Cu7zgWOH/JwBV7Gti1xzomQFmH9VSbvfA+t4OkMhLxdsOwbWhQJThHTpwOjOeJxHBniokURFmQW+pRY7BCmbFfcejQdlxLkh6vVCG7G8nRm5/flfYUrISgsMbsO8bb14q4ODMs5Q34CV4Cp43WYBj4glvi0S0OGikQgDepDYGPjYp7iUW0hHmNO2v21TLrYT6K278JoTPAuDnK7DgDp9I26+uVkgZxsHJ7VR0Ixw2Y+gUdODBdZSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oo+mgb4JbHlmUNvz//rcx4bdSUBO9I8LAbHX+BGSbl8=; b=naldSN/AGHLaBYh1998QuFBtcCjP00xCEuLo1/iN/nL/JpwVveuXzJhPpPo4EWe2PO79lxpRIsg/jPF4LGvHaXc1I9e/djX/FVvX3HubpxhRhIebzNRa5jhTRF1ObgvbYWrW+CNd8MBzV5stmzLxOX7VfS1n7rfZaELxQTqtHag= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm Date: Mon, 23 May 2022 14:25:18 +0800 Message-ID: <20220523062525.2504290-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 6caa2191-6d48-4feb-44a2-08da3c851c48 X-MS-TrafficTypeDiagnostic: VI1PR08MB4302:EE_|AM5EUR03FT047:EE_|PAXPR08MB7549:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GMommwcAWmF5rJFW2Wu1Kgcte/Ed+NVBxpzCuyepcEV9VD/vLKnli3RCFMzy9rJr2L4zVF+tHtI+ivggU5ao/dYfiXEeX3+TPA3voU/msu08gkKkJQGTw4D3QOEerrXUmyJslmTRdXLBJH5wtJBD18LJs/MF/tfDQazejkc3tuaYAYbbREWIxLIku1zRmRqom8zo4x1Rto7e5q5G599m73LMssCFyRvwzTc9b9JxWhWpujaPqy6TorOFxaf5Oe78QV54hihGnOmswqBC6q/uH0nAli6PUSYgeQmyV7/YGh+CYDCoeqoektpQht3oi0PL7hMahX0ILVCOBte59+4jWaEw9YOI7vr4q691qgFAEWwhbSRRXw0voAI9IukslAzmoe4NkC5qNtf24lKR6K0DS9i6ABa+U+CyINcBplCm6JiiHcfnhtM/LcCQHgknLHx5BDFEu4qhRQaCX61aI4u/JQmp8zICDEi4VU0s0ufBVKh+1UGyHz3mGOxkfjIG+yr9ZD1J+2idXpSyo4FCROlgulSNvRgfvqxlsqxfz1e+5XOYyy8UHlQraBXX+Lo0ZKV8Sa2YGodgNoixAbQkQpjLAGplG4cGfsdTZgdkLZZRvTXSF6ZbPARtMxgfmtMw2nWTg7FnpM/Lu8IbPczitwnqktwzQEvR3yDIc8xBdR8z27dAz6qi2V0Ea2pdSQ/Iu45T2tkIkXsCxrIjKrlUiWnkYQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(82310400005)(5660300002)(2616005)(81166007)(36860700001)(36756003)(44832011)(2906002)(8936002)(6666004)(316002)(356005)(426003)(86362001)(1076003)(26005)(70206006)(7696005)(70586007)(508600001)(6916009)(54906003)(8676002)(47076005)(83380400001)(336012)(4326008)(186003)(21314003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4302 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: deb31881-8cac-49e3-1bb3-08da3c851574 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVjx4cgcVqh5ZvtKZQ00GezPeE539MZimGr6hhBxFlJeVIXKLOk+7gOrCkBxFhtE3PuWO0xrJxz1GNf3QzmBGZHTugZW3fzQVUD25LWXPrU4mqP8ax8JQSipaRqIQ8WB8h6vyGLdccy93uHD3ojJCigDn3f+M/szeRsvX2TcdfH1OYx9HEYHNKMUXJE80U7iixEk9lR1v0/0pNgxtSYsoXzWEiZCwmKPtjBvlu3hczThQxWlOI7BCui6/y/bf3XdfgKy8rj2u3W8WneDPJ/jTPvYGO3DcOTyRlTvSEYe6mp9HzgsbRkmLcxVbvQOdB8gHZjL4bv48/2Fn9s/JX9WtN+KLED9Op0NFKUTRWCnXrKwe2yjclIorPrD6fiZ4DWdpUS3gPSuxB1mhaG57T3+U+yNnYuhK+gnAhvOu8vl8LafXm3A1gz4CE0mcpkw9aHA/NAq/t0CzVSbYsGy8v3TiOkXrky75PVShuNAzbInhNfVm3h80cP8VmMnkYa1dJLF6iAagWwt32q7gkM+eIW4OzOFC/VEwGgukb4G+zLbsb2dhvSF6aVm3HldfOlE83/SoQJm29CUgUtSJAVz1UjowlzRRhCUsVw53R3ctoQTEiC1giolC/0vc1snGtzTaVCadpUfn8ekp0PQR8kMHyf68rgTUP7eOEAk6GWT1WVcvwASFICQ6EC4qdkLHcEMERAIKh56CxSfQBkQoc7LjaJCqg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70586007)(70206006)(83380400001)(6666004)(40460700003)(2616005)(7696005)(316002)(36860700001)(82310400005)(8676002)(2906002)(336012)(5660300002)(4326008)(47076005)(426003)(1076003)(26005)(8936002)(81166007)(508600001)(6916009)(54906003)(36756003)(44832011)(86362001)(186003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:02.8536 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6caa2191-6d48-4feb-44a2-08da3c851c48 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7549 x86 is using compiler feature testing to decide EFI build enable or not. When EFI build is disabled, x86 will use an efi/stub.c file to replace efi/runtime.c for build objects. Following this idea, we introduce a stub file for Arm, but use CONFIG_ARM_EFI to decide EFI build enable or not. And the most functions in x86 EFI stub.c can be reused for other architectures, like Arm. So we move them to common and keep the x86 specific function in x86/efi/stub.c. To avoid the symbol link conflict error when linking common stub files to x86/efi. We add a regular file check in efi stub files' link script. Depends on this check we can bypass the link behaviors for existed stub files in x86/efi. As there is no Arm specific EFI stub function for Arm in current stage, Arm still can use the existed symbol link method for EFI stub files. Change-Id: Idf19db1ada609d05fc0c0c3b0e1e8687c9d6ac71 Issue-Id: SCM-2240 Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v3 -> v4: 1. Add indent to make ln and test to be aligned. v2 -> v3: 1. Add existed file check, if a regular stub files, the common/stub files' link will be ignored. 2. Keep stub.c in x86/efi to include common/efi/stub.c 3. Restore efi_compat_xxx stub functions to x86/efi.c. Other architectures will not use efi_compat_xxx. 4. Remove ARM_EFI dependency from ARM_64. 5. Add comment for adding stub.o to EFIOBJ-y. 6. Merge patch#2 and patch#3 to one patch. v1 -> v2: 1. Drop the copy of stub.c from Arm EFI. 2. Share common codes of x86 EFI stub for other architectures. 3. Use CONFIG_ARM_EFI to replace CONFIG_EFI 4. Remove help text and make CONFIG_ARM_EFI invisible. 5. Merge one following patch: xen/arm: introduce a stub file for non-EFI architectures 6. Use the common stub.c instead of creating new one. --- xen/arch/arm/Kconfig | 4 ++++ xen/arch/arm/Makefile | 2 +- xen/arch/arm/efi/Makefile | 8 ++++++++ xen/arch/x86/efi/stub.c | 32 +------------------------------- xen/common/efi/efi-common.mk | 3 ++- xen/common/efi/stub.c | 32 ++++++++++++++++++++++++++++++++ 6 files changed, 48 insertions(+), 33 deletions(-) create mode 100644 xen/common/efi/stub.c diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..8a16d43bd5 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_64 def_bool y depends on !ARM_32 select 64BIT + select ARM_EFI select HAS_FAST_MULTIPLY config ARM @@ -33,6 +34,9 @@ config ACPI Advanced Configuration and Power Interface (ACPI) support for Xen is an alternative to device tree on ARM64. +config ARM_EFI + bool + config GICV3 bool "GICv3 driver" depends on ARM_64 && !NEW_VGIC diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 1d862351d1..bb7a6151c1 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -1,6 +1,5 @@ obj-$(CONFIG_ARM_32) += arm32/ obj-$(CONFIG_ARM_64) += arm64/ -obj-$(CONFIG_ARM_64) += efi/ obj-$(CONFIG_ACPI) += acpi/ obj-$(CONFIG_HAS_PCI) += pci/ ifneq ($(CONFIG_NO_PLAT),y) @@ -20,6 +19,7 @@ obj-y += domain.o obj-y += domain_build.init.o obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o +obj-y += efi/ obj-y += gic.o obj-y += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index 4313c39066..dffe72e589 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -1,4 +1,12 @@ include $(srctree)/common/efi/efi-common.mk +ifeq ($(CONFIG_ARM_EFI),y) obj-y += $(EFIOBJ-y) obj-$(CONFIG_ACPI) += efi-dom0.init.o +else +# Add stub.o to EFIOBJ-y to re-use the clean-files in +# efi-common.mk. Otherwise the link of stub.c in arm/efi +# will not be cleaned in "make clean". +EFIOBJ-y += stub.o +obj-y += stub.o +endif diff --git a/xen/arch/x86/efi/stub.c b/xen/arch/x86/efi/stub.c index 9984932626..f2365bc041 100644 --- a/xen/arch/x86/efi/stub.c +++ b/xen/arch/x86/efi/stub.c @@ -1,7 +1,5 @@ #include -#include #include -#include #include #include #include @@ -10,6 +8,7 @@ #include #include #include +#include "../../../common/efi/stub.c" /* * Here we are in EFI stub. EFI calls are not supported due to lack @@ -45,11 +44,6 @@ void __init noreturn efi_multiboot2(EFI_HANDLE ImageHandle, unreachable(); } -bool efi_enabled(unsigned int feature) -{ - return false; -} - void __init efi_init_memory(void) { } bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) @@ -62,32 +56,8 @@ bool efi_boot_mem_unused(unsigned long *start, unsigned long *end) void efi_update_l4_pgtable(unsigned int l4idx, l4_pgentry_t l4e) { } -bool efi_rs_using_pgtables(void) -{ - return false; -} - -unsigned long efi_get_time(void) -{ - BUG(); - return 0; -} - -void efi_halt_system(void) { } -void efi_reset_system(bool warm) { } - -int efi_get_info(uint32_t idx, union xenpf_efi_info *info) -{ - return -ENOSYS; -} - int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *) __attribute__((__alias__("efi_get_info"))); -int efi_runtime_call(struct xenpf_efi_runtime_call *op) -{ - return -ENOSYS; -} - int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *) __attribute__((__alias__("efi_runtime_call"))); diff --git a/xen/common/efi/efi-common.mk b/xen/common/efi/efi-common.mk index 4298ceaee7..ec2c34f198 100644 --- a/xen/common/efi/efi-common.mk +++ b/xen/common/efi/efi-common.mk @@ -9,7 +9,8 @@ CFLAGS-y += -iquote $(srcdir) # e.g.: It transforms "dir/foo/bar" into successively # "dir foo bar", ".. .. ..", "../../.." $(obj)/%.c: $(srctree)/common/efi/%.c FORCE - $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, ,$(obj))))/source/common/efi/$( +#include +#include + +bool efi_enabled(unsigned int feature) +{ + return false; +} + +bool efi_rs_using_pgtables(void) +{ + return false; +} + +unsigned long efi_get_time(void) +{ + BUG(); + return 0; +} + +void efi_halt_system(void) { } +void efi_reset_system(bool warm) { } + +int efi_get_info(uint32_t idx, union xenpf_efi_info *info) +{ + return -ENOSYS; +} + +int efi_runtime_call(struct xenpf_efi_runtime_call *op) +{ + return -ENOSYS; +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335350.559504 (Exim 4.92) (envelope-from ) id 1nt1W1-0007q1-3R; Mon, 23 May 2022 06:26:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335350.559504; Mon, 23 May 2022 06:26:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1W0-0007pu-WA; Mon, 23 May 2022 06:26:05 +0000 Received: by outflank-mailman (input) for mailman id 335350; Mon, 23 May 2022 06:26:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1Vz-0007pn-Qo for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:04 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on062a.outbound.protection.outlook.com [2a01:111:f400:fe06::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35e12dee-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:25:59 +0200 (CEST) Received: from DB6PR0601CA0003.eurprd06.prod.outlook.com (2603:10a6:4:7b::13) by AM0PR08MB5506.eurprd08.prod.outlook.com (2603:10a6:208:17e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 06:25:57 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::97) by DB6PR0601CA0003.outlook.office365.com (2603:10a6:4:7b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 06:25:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:25:57 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Mon, 23 May 2022 06:25:56 +0000 Received: from 8a838bab2af6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 19D4D063-E5CC-4EA3-B283-728787C5AEF6.1; Mon, 23 May 2022 06:25:50 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a838bab2af6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:25:50 +0000 Received: from DB6PR0201CA0034.eurprd02.prod.outlook.com (2603:10a6:4:3f::44) by AM6PR08MB2999.eurprd08.prod.outlook.com (2603:10a6:209:44::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Mon, 23 May 2022 06:25:48 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::d9) by DB6PR0201CA0034.outlook.office365.com (2603:10a6:4:3f::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:25:47 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:25:47 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:25:46 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:25:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35e12dee-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=R4qad5UlQypIBk30htOiHvSGaqgeFI66ggtEbzEWHUMXMCjyNTcd1JYUt14RenE/PqUUvQCMJwmwIy54WWQkHpbwmW1JtP/Hc+kRwEgCTow4FNrlzsOvI2m3k7OTbHjImNPBjOmpiwdGHkATeTgVx1teYXPlf5nFuICADSJw95G7Nj4vKja9n+J1QKqnj5R8oPuGhO0swUijxJNmDrYipjtFzl0ojIOIi59Kbrjatq/zgYw0W0DspSpFfcCvhxE2K0S04ztMQa+p18YgAUsQdMcu0C7jPC7ZOsS7AgWLax7GjGQpiRnW6bJitA1EmOv7qkF0A01kZSELgq8N4Vo0tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SLQ2m7gOYNHgd1/212k4a11FnWgtoPLhxR6vTurlfYI=; b=NdP3nIpeMgLIsxs6kFyZqi+/SXkDcljwyl4yJttuzAU8ttDSzKUWPwg22EhjQK6SZ/Jngefqd9TTJ8s7zcghg/HnH2q/TMaxhCA9UZAB6Io9A92/2NeC2wd48rwtEKv5kncxDos7FdgOHgRqN2CpdJ6iVzvPP7+TDSa5/9ROAkcMzys9C0lHbhTplDjzUjj2IpmeLlLvZTJWo98iORRdz8A0j5EZeW6QYSwRHaE2QUpn5NjoNvXZpRvLnj0aYZgv6OspJA3v0R7JaWeyOT0jpqyrLhsy8ajK1lOpKmuwkSYFy6dcE2OpHUFA5kMCoILjooGkC1nDVNgSvXRz/15G4w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SLQ2m7gOYNHgd1/212k4a11FnWgtoPLhxR6vTurlfYI=; b=CG2mbGYsFAIZPpziti86RiooqVr37U20bHZeIeTxgtBPvUB1vMMVocmi95PhrVOUKMkAjWYO9pLWB4h4RUechLexK2BkdhLPTaG2v7NhL+LXUl5XoEjBSBwkfuVlYfDermfoCeAgVZTJ/Vgudee8bFeqsT5jF0PJ9j8TXUD14JE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cc9ddee32c642f3d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDhpa+lTL5L52+E4Hk52PUfM18pqdxt8VEEYU4gFvslXpbOBTWgh9d2rTvPQJr68xkHR0wn4+EMAda3IBykSH8Px4R5Zy4+c5GZMyvftKn1Aha2fI2b6N5bjbenjq5c6vQ+WSTKft0cYgdbEfTr7JD3gH7f92QAfBpPbgCZSG6S7NjBhYbmuoIkLMnWF4Wkd1YmVkao6vsJk1YMvr/NLbnMV3plc3aV9E2tPqAzgvMSpsR28nYdzhsg2a1znAA91pwCaxBne2RbD8ZlZN2IkLw+q0o6Hpt3nyK8WcnWsL/MqSndDWDmSwZOYpVjZfcjyel3lgpVePloIDrJnNRgnqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SLQ2m7gOYNHgd1/212k4a11FnWgtoPLhxR6vTurlfYI=; b=fKOQcp5THVvWIZcAMpKgNgSfDdgvDnPs61cTAKu1LUqgJj+/Tkt/YsQMcpTNz7CI5DCMS1Y+0JgQgP3IB0GjysrVYu2OiVxtcDGtC32ARWAeEC+JsQDZT3OgV7VLVVqAW4I487ATBfyX5nW6AZWEWr6o7sIQ6nJ/MqRinjsjNqPZqxrO4+5GwPwvoJm+LVUMrAZsIiUdLqT6e1Htyunj52kQR2K1l+w06aIOAZvJJn7EGY7nDFXJOoJd+t0wmFWlURj+XlvSfhB3Dj7aF9Kkd7CK2IxaVOodq+1z7QBW3jnJJc6OJQB3DXcxfEWyS7Bv3G8niRzHHvpm/BbQ7peNwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SLQ2m7gOYNHgd1/212k4a11FnWgtoPLhxR6vTurlfYI=; b=CG2mbGYsFAIZPpziti86RiooqVr37U20bHZeIeTxgtBPvUB1vMMVocmi95PhrVOUKMkAjWYO9pLWB4h4RUechLexK2BkdhLPTaG2v7NhL+LXUl5XoEjBSBwkfuVlYfDermfoCeAgVZTJ/Vgudee8bFeqsT5jF0PJ9j8TXUD14JE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap Subject: [PATCH v4 0/8] Device tree based NUMA support for Arm - Part#1 Date: Mon, 23 May 2022 14:25:17 +0800 Message-ID: <20220523062525.2504290-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: bce4e0b0-f855-4ebb-b37b-08da3c8518c5 X-MS-TrafficTypeDiagnostic: AM6PR08MB2999:EE_|DBAEUR03FT061:EE_|AM0PR08MB5506:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a+xZXKUuYoMw7TuYbZcxeIuA4tc1MTcVReMKQIViGkJtN8IY2y15krwVZHNydYkVA5OkyJmbOKfK+on6emgCumx8ggzBXwACGbMA8B+8TGtBiqknF2dn55tfONg3BCKmk1mPo57f503reZ8JQGpblAPzzdh8gikD4Xn08gIg2OuwvvobNawHBMobP6b4FMWtgGQxpCTDJn7sE4CMRthwv8M6un4rcsHSBmpWSDU/2rmnwD16IE+mzx/Vz3Q/oSZRiifaSlugMh6twmYPilV4+365mAIIs8iI6Rm8bzoFZjdDjou8PWs8Mi+b5NbxSv4b7/TW2/ABo+RWpA+zUQwZ5l36aPuj7Rx3y7Pv7TtBVU0U9pHBHjkUkTh6faaqI9HAVBz1vBRqctfTGRE7hyLaV216JiRFGoupzPtxIr3xbIg+zQLYFpcegYBB/Oo8oloVVA/Ur1vaMrK9ORCD//CN2vsAObhSc81eECpzx9R6Xe/P67gtaU0yIhvMc+ydrecI9l3VaSoaqOGz/UYAgYKZmTjgl/1di0Jd/Ggdha+vijMjZILNEi6V4pSVXs9DrASBFdwHS4ATVXtZvazZSEr2Nx1/XCQ2M8oyqhBdrCucrFZaRIF4jOZwVk2L/lKMkI0VySMzzmcB2SGYeSW7AAqA/01tDki4C5hpFAPSxR8XVDjRSiVVhEYxDQ1BoKHngilnvYjbzIkiAnSp71yHoqblVUdFYwMRWRgRNRikTnOHoaTTLojSZom7F/fkXy+pgHSkCVwovh7TqOSsCP9QTEJ6Sg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(81166007)(83380400001)(82310400005)(86362001)(5660300002)(40460700003)(356005)(316002)(508600001)(6666004)(36756003)(36860700001)(7696005)(2906002)(47076005)(8676002)(1076003)(26005)(6916009)(426003)(336012)(70586007)(70206006)(8936002)(54906003)(44832011)(4326008)(186003)(2616005)(21314003)(17413003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2999 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c542f12-e9b2-40a3-aefa-08da3c851327 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kml9Suk3Gwps/8CTLYxHLlmKtI5OYMpqjMI4vFEKVaGvJItltjVinvWudbLkOS3cCG0vdbXmmd++8XfirEmU35rIj5Dk9JcdHJtew4TcEXCznfa8AK9IIlC7hJE0wb+JyEWyLgJEFU2TVamr1FwziokUvkLQXAp8LovYVkksX3HtPEZZMjLrtN2jiFQJ8IuBa+3ATlYJEqCeJ0u3nzexoT8d3k5UFt98cz+BTc1sZFAx+2pUkqme7aYwOqmWQtewV0QclJEVCCU3c2BCz4u8/f45HjdT/MVlLSybQv/Wc5LsuiV5neeHbjAxG25bolEI17ImJNIvYyo7DLBZLmJwGNuQsHam6ANxFuVPD4H6pX8FKv6ZY7erQ1q9/VFei5JkXyL+SwzvHNGs65gsUmYCurZz5GP5Q9tkVYCPGTMF7kOHQkwPOB/udEM9RIWlRdEt5nyICKN+Bpo8WLI5tiuBixPaIBFU60Fmh9+wt7jBrFtouw+QEizBU/vMrJsw3MvPLs7DnZykKoPwZ3DN6fI3YJeAIrS3Mw13L7r1AG0PREoQ+Q7aK35HOR5piVlAlLLgyuHGqIJkyUu0aZhTrDJ3RiIhU+PHDl8EfI1j/eRVNMYnCAYXEC+4jHaWjvxkka//+Wzx9yQP61SADCkEpmXIB67iHMNXGg9PJ/AzQlmgSibaMMlmNzHaMMNInFsX9nK7XyiAAELvPxP/8hGCWclB5JU5fpozhea8ieF4OYPE8iw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(70206006)(6916009)(36756003)(316002)(40460700003)(107886003)(8676002)(54906003)(82310400005)(81166007)(4326008)(70586007)(8936002)(6666004)(44832011)(5660300002)(83380400001)(36860700001)(2906002)(86362001)(508600001)(186003)(336012)(426003)(7696005)(2616005)(26005)(1076003)(47076005)(21314003)(17413003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:25:57.0116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bce4e0b0-f855-4ebb-b37b-08da3c8518c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5506 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series. 2. Move generically usable code from x86 to common. 3. Add new code to support Arm. This series only contains the first part patches.) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. --- Part1 v3->v4: 1. Add indent to make ln and test to be aligned in EFI common makefile. 2. Drop "ERR" prefix for node conflict check enumeration, and remove init value. 3. Use "switch case" for enumeration, and add "default:" 4. Use "PXM" in log messages. 5. Use unsigned int for node memory block id. 6. Fix some code-style comments. 7. Use "nd->end" in node range expansion check. Part1 v2->v3: 1. Rework EFI stub patch: 1.1. Add existed file check, if exists a regular stub files, the common/stub files' links will be ignored. 1.2. Keep stub.c in x86/efi to include common/efi/stub.c 1.3. Restore efi_compat_xxx stub functions to x86/efi.c. Other architectures will not use efi_compat_xxx. 1.4. Remove ARM_EFI dependency from ARM_64. 1.5. Add comment for adding stub.o to EFIOBJ-y. 1.6. Merge patch#2 and patch#3 to one patch. 2. Rename arch_have_default_dmazone to arch_want_default_dmazone 3. Use uint64_t for size in acpi_scan_nodes, make it be consistent with numa_emulation. 4. Merge the interleaves checking code from a separate function to conflicting_memblks. 5. Use INFO level for node's without memory log message. 6. Move "xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid" to part#2. Part1 v1->v2: 1. Move independent patches from later to early of this series. 2. Drop the copy of EFI stub.c from Arm. Share common codes of x86 EFI stub for Arm. 3. Use CONFIG_ARM_EFI to replace CONFIG_EFI and remove help text and make CONFIG_ARM_EFI invisible. 4. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 6. Extend the description of Arm's workaround for reserve DMA allocations to avoid the same discussion every time for arch_have_default_dmazone. 7. Update commit messages. Wei Chen (8): xen: reuse x86 EFI stub functions for Arm xen/arm: Keep memory nodes in device tree when Xen boots from EFI xen: introduce an arch helper for default dma zone status xen: decouple NUMA from ACPI in Kconfig xen/arm: use !CONFIG_NUMA to keep fake NUMA API xen/x86: use paddr_t for addresses in NUMA node structure xen/x86: add detection of memory interleaves for different nodes xen/x86: use INFO level for node's without memory log message xen/arch/arm/Kconfig | 4 + xen/arch/arm/Makefile | 2 +- xen/arch/arm/bootfdt.c | 8 +- xen/arch/arm/efi/Makefile | 8 ++ xen/arch/arm/efi/efi-boot.h | 25 ----- xen/arch/arm/include/asm/numa.h | 6 ++ xen/arch/x86/Kconfig | 2 +- xen/arch/x86/efi/stub.c | 32 +------ xen/arch/x86/include/asm/config.h | 1 - xen/arch/x86/include/asm/numa.h | 9 +- xen/arch/x86/numa.c | 32 +++---- xen/arch/x86/srat.c | 154 ++++++++++++++++++++++-------- xen/common/Kconfig | 3 + xen/common/efi/efi-common.mk | 3 +- xen/common/efi/stub.c | 32 +++++++ xen/common/page_alloc.c | 2 +- xen/drivers/acpi/Kconfig | 3 +- xen/drivers/acpi/Makefile | 2 +- 18 files changed, 201 insertions(+), 127 deletions(-) create mode 100644 xen/common/efi/stub.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335352.559526 (Exim 4.92) (envelope-from ) id 1nt1WB-0008Qh-Px; Mon, 23 May 2022 06:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335352.559526; Mon, 23 May 2022 06:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WB-0008QY-Lp; Mon, 23 May 2022 06:26:15 +0000 Received: by outflank-mailman (input) for mailman id 335352; Mon, 23 May 2022 06:26:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1W9-0007pn-Rf for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:14 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on060d.outbound.protection.outlook.com [2a01:111:f400:fe08::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3deefd84-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:26:12 +0200 (CEST) Received: from DB6PR0501CA0014.eurprd05.prod.outlook.com (2603:10a6:4:8f::24) by AM9PR08MB6802.eurprd08.prod.outlook.com (2603:10a6:20b:308::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Mon, 23 May 2022 06:26:11 +0000 Received: from DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::6d) by DB6PR0501CA0014.outlook.office365.com (2603:10a6:4:8f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:26:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT037.mail.protection.outlook.com (100.127.142.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:10 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 23 May 2022 06:26:10 +0000 Received: from 789b36f4b8f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 037BA0AD-56EC-4408-BEA3-BCB4ECA73B7A.1; Mon, 23 May 2022 06:26:04 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 789b36f4b8f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:04 +0000 Received: from DU2PR04CA0262.eurprd04.prod.outlook.com (2603:10a6:10:28e::27) by DBAPR08MB5590.eurprd08.prod.outlook.com (2603:10a6:10:1aa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Mon, 23 May 2022 06:25:59 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::9) by DU2PR04CA0262.outlook.office365.com (2603:10a6:10:28e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:25:59 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:25:58 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:25:57 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:25:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3deefd84-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VkdGOfwZCpAxM9Jzo5tGmJ5BViErXu0puJe9N2mjh4G0nxpAUnRc9BcQeoqbhoHE/hlNWHXtABLhepIxmFN/RYBMZlD6OuHtQ8jy9Cxa5ySbPM9kp/gSvYh6R872VzMRQMn1VnpuM6Jx6zz47NsPCQfabXmTT/Cx7UpPidbmhv9yPD9F67sBZekyqS+qPCTcfWonxa1iY8ycdT9tNjw4QuZuHCcT7coa/tEudh1eeFoKn8BsQ3zzi8Sa4o9nZ6gMnz9YnC0uICxoUYZmDVHFYxm66KOm3i+oO71IHrp7i1QSKtZYjaJg8HwU3LmdbJD5GIi23ecjBZEPECHbsiBvTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+h4lby9uhtIt+w9bPcDu7mqnxP5TtPdNw4xy2M6UuS8=; b=c9wVCdFX+x/8ZbqpgR2iJhL6Sz+AiYwlybcQNVLi6KnNt+L/dwuqSvV9hNuhqEsJgnAtwAa/xtPLo6Uh0mCBQk+Y362QC+o5GpVm8wZ905ldcB9eWBDs6YdQnxe3TAxrbmFNx4VLh1XEMY68JFNqvalK52dimqx/7mCscQwfntJi9WuJlym4vdTLZc+7vqiIuzsbfC3woOtFM38HW+MATKoieIJD6e7uNYlD60j3vnJ0JrHfYTfoyu3UrYLvxTV5W8ENgzJbGAlGcWx/sWEmFOJokpkGc7TYKpc/u29NnH+9H8AEY8JC+DgzfD65zu76x+vlLQH9pFViXUodI8Z95A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+h4lby9uhtIt+w9bPcDu7mqnxP5TtPdNw4xy2M6UuS8=; b=XdW+R8RNyJMX5YmOufsq/CthT6YyujFW95cvy2ueGGrkpDblMBEF5/1BR7M/z4jDCmE7X/EdalaouqIGeV1lLx4bpF//zvck9NVbGfp6oHYXTAslN+ejJK9cYqK+MOBeadaNMOI/gUHYx9uwUHMoR1+Rm3rlXebWYbVGaOek4bk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 04c0b99e10f7ac77 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwWWL+gfuMnP8wkhlWCzKDJuxK82tndhDUkbQAxXWyXNR3BuxTphMA/OtvKbIr8qXCN0vO96i6pd7WGhdmyRfN5nMVwBOK/GeFwFwSMgRyoVKCvIygRCKFdY2xHjO1yVBYonfGYxu/gSo/gjsP/S5KORRk6KJQ6SkBVgoJijDcfVBehmihvqOMcV9hs3wzGUDPncGJQF62KaTcR0LMT/kbmGOkuLClfiErdHU0Ef0xUn6Z5CHFddULILlMBHeIBJeaTpJYhefK+KWM2E1CrK8kl8J8eIHgpT1gyd1M+25p/11QIDoXalZ2OIPHFJu3issC4lBfq9GtjiqMEU53EX6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+h4lby9uhtIt+w9bPcDu7mqnxP5TtPdNw4xy2M6UuS8=; b=T6ULq8KwbsvABEefPWX1df52oUJpOa7i8Z9tQ43P3acddPp5nNo2x9Mon9U4wHlQROFOHPO5/mc941yZ3rpHYSV8vSbGlGGh2+bLht0CY2K9xihXhOew1e/GZ7vq1jrNZDbtoz5cgRE4K6QkaQDB1dWbShYqHpdwuYnpURp8mOyaiQHYk8/zGBtEiHuryDp7/3A8isbGBf/b3Cj9xciX38Xp9n8GkqYf8er/6bZudrSKG1Y73jbba4QGwgQqV+y6ZHSXN5EMd2mOIV4v4zwzzZSczzP/NePsQKR9NKliK8QWzpVEPhY1ILklOZUlXIHBhsA+BVzqB7LUULglQJpydw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+h4lby9uhtIt+w9bPcDu7mqnxP5TtPdNw4xy2M6UuS8=; b=XdW+R8RNyJMX5YmOufsq/CthT6YyujFW95cvy2ueGGrkpDblMBEF5/1BR7M/z4jDCmE7X/EdalaouqIGeV1lLx4bpF//zvck9NVbGfp6oHYXTAslN+ejJK9cYqK+MOBeadaNMOI/gUHYx9uwUHMoR1+Rm3rlXebWYbVGaOek4bk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jiamei Xie Subject: [PATCH v4 3/8] xen: introduce an arch helper for default dma zone status Date: Mon, 23 May 2022 14:25:20 +0800 Message-ID: <20220523062525.2504290-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: a81e30a7-b06e-49ce-bca8-08da3c8520fa X-MS-TrafficTypeDiagnostic: DBAPR08MB5590:EE_|DBAEUR03FT037:EE_|AM9PR08MB6802:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ivJGpZea3Qu0DD8urVw0nJNA7nL5PLjtKmYfDwqWnLw1mXouGP3j50P6sSm5a62F9p3NaiB2hReaQfD6+CxPxOnqjK/WHEfUfNoec7MJ9kuSfJ0UFBIlIkvhxdH5Ob2BxFKEltYIek0Oyhde81YbbFWWrpmdu+8iXRAN1o+tG1dlUMBLh7vPP2VrSpPC5qh+qvJxxn6VofABR/Y+cYCk4M/IAMIP2bkAekikk1FGANnPjytAJMY1gAGt4QvAtRjWWbrtAQv5AX9Z7KMAUT1BPfCv+Snbt13SW3nhzTT/ZmAcqNMWegNCWZG3raZ8SlWOPr29JU9abioH+ucVWNlnp1CV3hQ0PDMXpdGNH58Km8XgLf92FwpPZZLX0cwstvCvVmF7UyFZPXY3ZFxMP/MsAc7vpj/pY9RjulxmCMskC8HDlYdattQ9y0A+ktICOCG4nzST/MuloWFyjlfclCBwxanhYMkjmdbKhCpuzrlEsFUF7b5q/Gd9BC2MmOgHYeUbCVoR5QkBzuczDupchFMMEvyzroH1Tid6ZX+l6UrxobmoMuvqHZ1w0atr6Ie6uvaCUadAauaAZH11kRnHGpJJ/Z6EOAgERy/8Ipc8E+2OVst/AasYUG3c8JXmn7bfABswcqlIQ4wj43aAtruNAD4KjVxuAxn4pwfW85bza4xbZfD553nnK6Szm8O1U5YY7JSg X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(26005)(54906003)(2616005)(6916009)(316002)(336012)(426003)(47076005)(1076003)(6666004)(186003)(7696005)(36756003)(83380400001)(82310400005)(508600001)(8936002)(70586007)(2906002)(4326008)(8676002)(86362001)(70206006)(81166007)(44832011)(5660300002)(36860700001)(356005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5590 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 11e4956e-f20c-44a4-4d7c-08da3c8519d2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kZvuxfR7IYHI1s7M6yMwAWuuzSgf7bS7zHoZw3nqJwS0Rc6h9mLjNXH6yFN3jL+kej/mhulxlPulhwVuO2ul7P1hYqGndyihj2ngJxCZfz2FYRO85UnYy14LqjJGaY7evGbKhNoLXvcNeUgvs4V34y4kp6BTJcN3xZcAD6cBQE3TzDseONUMCa0pY7YCJcJxaZDz9yRdTwfBzYeRMgcIxy95nausYBEeq+X5gIMoVCQ7yh+Bv6nHF5YKD3KoTKPnAWvFoqC3YNohZZS0+G9PuizbfWqM+kS+NZirPjoc8/kOLgBkCpoGGGdEps6M1ZQGWE7pupfXG599K01ZiSj6DryE1ttCKUlq+cKHyk08jMUOi7UG3ox3TKzUTC3Te5K5kfyrba1eG8CaIC62LHnYc7ooRsKtHEr176RkVvRIrY7hB+TK9Smuj7eYvhY4uY533c3C8IViDvPbexXjaDCqmR8V/MsDc0BrBv6sCO2BdqgfhGhVmztfCMQ3x+qus08XJ2g8ibfFVPKn2a5PXRdqPl34A2u1aNl+z9AtT+oI1N++1312XKj2/LIbBPonLmZAla09iM+c8UcFLowByVzo5cNHOlvYrSIca8QYneOYN8l4WtYCjRXAmTrOTthvP6JAZJVZGnNUnC+y2n0JHH63WAiyw6EIckMy36lzOM+7OMZvWDmCzhRUdgKQM9vtrlUi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(44832011)(6666004)(82310400005)(40460700003)(36756003)(86362001)(5660300002)(316002)(36860700001)(26005)(2906002)(7696005)(83380400001)(8676002)(4326008)(2616005)(6916009)(54906003)(47076005)(70206006)(426003)(186003)(81166007)(8936002)(508600001)(1076003)(336012)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:10.7966 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a81e30a7-b06e-49ce-bca8-08da3c8520fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6802 In current code, when Xen is running in a multiple nodes NUMA system, it will set dma_bitsize in end_boot_allocator to reserve some low address memory as DMA zone. There are some x86 implications in the implementation. Because on x86, memory starts from 0. On a multiple-nodes NUMA system, if a single node contains the majority or all of the DMA memory, x86 prefers to give out memory from non-local allocations rather than exhausting the DMA memory ranges. Hence x86 uses dma_bitsize to set aside some largely arbitrary amount of memory for DMA zone. The allocations from DMA zone would happen only after exhausting all other nodes' memory. But the implications are not shared across all architectures. For example, Arm cannot guarantee the availability of memory below a certain boundary for DMA limited-capability devices either. But currently, Arm doesn't need a reserved DMA zone in Xen. Because there is no DMA device in Xen. And for guests, Xen Arm only allows Dom0 to have DMA operations without IOMMU. Xen will try to allocate memory under 4GB or memory range that is limited by dma_bitsize for Dom0 in boot time. For DomU, even Xen can passthrough devices to DomU without IOMMU, but Xen Arm doesn't guarantee their DMA operations. So, Xen Arm doesn't need a reserved DMA zone to provide DMA memory for guests. In this patch, we introduce an arch_want_default_dmazone helper for different architectures to determine whether they need to set dma_bitsize for DMA zone reservation or not. At the same time, when x86 Xen is built with CONFIG_PV=n could probably leverage this new helper to actually not trigger DMA zone reservation. Issue-Id: SCM-2240 Change-Id: I08c5d463995322ecaf7e6755d417c814825010eb Signed-off-by: Wei Chen Tested-by: Jiamei Xie Acked-by: Jan Beulich --- v3 -> v4: 1. Add Acked-by. v2 -> v3: 1. Add Tb. 2. Rename arch_have_default_dmazone to arch_want_default_dmazone. v1 -> v2: 1. Extend the description of Arm's workaround for reserve DMA allocations to avoid the same discussion every time. 2. Use a macro to define arch_have_default_dmazone, because it's little hard to make x86 version to static inline. Use a macro will also avoid add __init for this function. 3. Change arch_have_default_dmazone return value from unsigned int to bool. 4. Un-addressed comment: make arch_have_default_dmazone of x86 to be static inline. Because, if we move arch_have_default_dmazone to x86/asm/numa.h, it depends on nodemask.h to provide num_online_nodes. But nodemask.h needs numa.h to provide MAX_NUMANODES. This will cause a loop dependency. And this function can only be used in end_boot_allocator, in Xen initialization. So I think, compared to the changes introduced by inline, it doesn't mean much. --- xen/arch/arm/include/asm/numa.h | 1 + xen/arch/x86/include/asm/numa.h | 1 + xen/common/page_alloc.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index 31a6de4e23..e4c4d89192 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -24,6 +24,7 @@ extern mfn_t first_valid_mfn; #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) #define __node_distance(a, b) (20) +#define arch_want_default_dmazone() (false) #endif /* __ARCH_ARM_NUMA_H */ /* diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index bada2c0bb9..5d8385f2e1 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -74,6 +74,7 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) #define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +#define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(u64 start, u64 end, nodeid_t node); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 319029140f..b3bddc719b 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void) } nr_bootmem_regions = 0; - if ( !dma_bitsize && (num_online_nodes() > 1) ) + if ( !dma_bitsize && arch_want_default_dmazone() ) dma_bitsize = arch_get_dma_bitsize(); printk("Domain heap initialised"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335353.559536 (Exim 4.92) (envelope-from ) id 1nt1WD-0000H6-2n; Mon, 23 May 2022 06:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335353.559536; Mon, 23 May 2022 06:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WC-0000Ga-Vu; Mon, 23 May 2022 06:26:16 +0000 Received: by outflank-mailman (input) for mailman id 335353; Mon, 23 May 2022 06:26:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WC-0008Q2-2c for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0614.outbound.protection.outlook.com [2a01:111:f400:fe0d::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e95f427-da61-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 08:26:14 +0200 (CEST) Received: from AM5PR0701CA0014.eurprd07.prod.outlook.com (2603:10a6:203:51::24) by AM0PR08MB3827.eurprd08.prod.outlook.com (2603:10a6:208:104::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 06:26:06 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::69) by AM5PR0701CA0014.outlook.office365.com (2603:10a6:203:51::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.12 via Frontend Transport; Mon, 23 May 2022 06:26:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:05 +0000 Received: ("Tessian outbound 6580ae46f51e:v119"); Mon, 23 May 2022 06:26:05 +0000 Received: from da875ee8d977.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 21F0A427-C99C-43AC-8521-962A7984EE93.1; Mon, 23 May 2022 06:25:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da875ee8d977.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:25:58 +0000 Received: from AM6P193CA0110.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::15) by AM6PR08MB3336.eurprd08.prod.outlook.com (2603:10a6:209:41::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Mon, 23 May 2022 06:25:56 +0000 Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::f) by AM6P193CA0110.outlook.office365.com (2603:10a6:209:85::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 06:25:56 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:25:55 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:25:54 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 23 May 2022 06:25:53 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:25:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e95f427-da61-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y7m3nVdANowdvf2tVP9Es8exkjovarxVOk4cOG+cJN0dHqaNQ0yAT7bz7RtizrPAVo5YfiWa1suOvKV1EHOV+sQ35RnoAxWVGxhyX9nVsNMzSlAkkzpkERtCXeXDO88AihZxvuzWIP6h3FUR2ZOQuAJyraWo8a6AMQI85kKQyJtfjVRfwj3mTI8lSasNXXFOKYWaDRMMgKxMVhXcM/8Wnp6sJTUysc973ZJa6qgZflb6DMJZJiy0hDoGduK63h7tad1gj/9NDGLIf8UO+brzycTmseuVxsdB6ccYIVCpxBDUxXx06465Xs+nVVHHc5nR+Y/QQRRhDbFFUpm2Gm5OfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3Bvh2fxVQKbOjJTKRlirSTts06RHaeGkbdUGi12wmA=; b=Cpf1lZ1/0dK7htdifj13RRQ20fB8tNeVOoIdRL/XFuIHW0ryFgEyv8JlFOAMbJnCeIKofG3ZXuOKLgP08Jakt6K9GT9gf/xvsUSeMkvlE9oysQ4oPIuhUIEaKT/S4Tgiywct3DowTpxEOvy7bWXKn2NUNg9yGVUH+Kvklyp509VNXGT2nbAteObRZQl0jr0xn5PE0wlLsY8HqxpkaHSsInU8TjYE4EerqMsTkNoS5nvB9GZmjXhaLDoimQkObGFNTSljWE1UtpfK/+LRrkjSa1B2em2xLTKBRc//gb3bUXFRnui8szVQi5xKMJ8JIDEJ7sTh4yrPxbXeG+oA5MP0Wg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3Bvh2fxVQKbOjJTKRlirSTts06RHaeGkbdUGi12wmA=; b=xULc6Pedz5pXWao5FTyRojNZ+Hgs/001uB45mBEqr24NcvA6mgM2la3n0g5rj9zkszCOyV2leGK7UmFuDegi09hHznruI2Vg+2cHxmIJicE6X00I3N5xCqo4kmfA6gXv1t9tUny39AGa4YRTgrQ2/Ft3G6KXOxIQUxd4D8/1Vzg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 270bdc83925346d5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QP7UzN22hKthGQljDyM+tGb4qsuKWMnWw59lwAbVwIgO+XSB6BZktXkEloXC4dD9tHalNq0Xk0gYfBEGosCwW3WLbSWF+7ZffBRXqWZ5H1G5h9IQU/ktZVHmGOJLac6mUFUWeqC9n9HxsyRAm0bRi9Ebtm84dC+FZiNCmt4v5KhqFONRSgYv/O9ZBptDlfeQMqcZS0UiT9Y/BgiOuddIB2ZvqlwWDcRAfrDZR5NBG0S+91SpKjmIeVY2nWTkoSmQjHc4CMCKwIeqoTPI6PYddBbXOfsT3lwsJ4FTLfss8oSkupRuz441uYPBlJT/4+vu0oFnxmgiBh/pRceXrlkjMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3Bvh2fxVQKbOjJTKRlirSTts06RHaeGkbdUGi12wmA=; b=XuJQ8gKFZppNJVytLZ13qHoeaPRFZpFkpMH5sb/UDuQc4J2Fkm/ofuamnB1ApHLKfXWPgeF0hdSuppieqXnfvAQYRENc0H+inQ4jLV872DoM9EgQFcTCOU7F19UAIXIjLssunTbMjORE/F3bzIud1RVdGydDTsIwO0K//hoV6WUBue/ECSY0v/NH3oycV0yikapFOE5WUPoTnQh/l7gV1vcWxvzINY2WipXLFmNVhx7+AhE2FKRv6UkjlJHWZc7/Ry7xjVigciDAkeP4HZ/A45aDRbm13outmgchP+olwQ+2IeiMJASbhygSYW8AwBIu4MsacdmcpPPa7C+SBQhAQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3Bvh2fxVQKbOjJTKRlirSTts06RHaeGkbdUGi12wmA=; b=xULc6Pedz5pXWao5FTyRojNZ+Hgs/001uB45mBEqr24NcvA6mgM2la3n0g5rj9zkszCOyV2leGK7UmFuDegi09hHznruI2Vg+2cHxmIJicE6X00I3N5xCqo4kmfA6gXv1t9tUny39AGa4YRTgrQ2/Ft3G6KXOxIQUxd4D8/1Vzg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: [PATCH v4 2/8] xen/arm: Keep memory nodes in device tree when Xen boots from EFI Date: Mon, 23 May 2022 14:25:19 +0800 Message-ID: <20220523062525.2504290-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 5b99b23b-7e10-433b-8d7e-08da3c851e22 X-MS-TrafficTypeDiagnostic: AM6PR08MB3336:EE_|VE1EUR03FT064:EE_|AM0PR08MB3827:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cf2B1NtiL6CTXvhKzZ9LIItc1aGkDmOatslT44HU/4DRyUijrLnX0nX2liXVFal5TLSJwFckhxrh6mycj1VzzZe+cGbJb1T/ZGiHkOii13CVcDBNgzo7RcwvppyI1qqsV7sidG0Lad5V9pymZUUVZpAFwT6eFLhfPQyR6tMnMojRpfClNdvcfB313CjZ1kSqXK0aZzINyHsva0vmBzXPGdkQC9vqHxLloki9vUSL9UiIiYGFmET7Jq5Q30dhviHyDuZMrof2DUnAWAUsVn1kMdslOOOG2KxSnJJD+n1xG2VMKmG3xTJhkUYJ2w6nsmB6SrO1W/BD6CF++Zyc2ukaWMndvegsdMFt+gVJ8Kf9Oh2SHWOaU3zsC+g8TSyp0h8Em5WfrQTN6Uth+ZCN1ajVS3LfSevIJpyC6JkaMJ13CVUBIjy7cHqSddO+sEAA81InmHvNRp2GyLOZIKhDDXgv4sbDMHRGcYHQmuG4CkvASqzORR+rjTtE1stW9dh0GB6j2b5Uhl0dtWpiI9/uq5SqRfxUp4eN7bP4jOTWRB2SUGQx8pUmgPTU9ylSexQdew4xaVv0oMVhcGp7/EjgCEyXyGzoK6KybHe3hnIa/mg6Xnpq8X2jQQz57Y723cQomgVg9UT4rWUuWUVKWpADNeiiphncaSrUyhU/39LYWQj28uP35MAftF1mRLh+TSn1pIa9Zw3i+m6Wqt2e106dJLw5Ig== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(44832011)(426003)(36860700001)(508600001)(6916009)(47076005)(336012)(54906003)(1076003)(40460700003)(83380400001)(2906002)(316002)(26005)(6666004)(70206006)(7696005)(86362001)(356005)(2616005)(82310400005)(5660300002)(8676002)(70586007)(36756003)(8936002)(186003)(81166007)(4326008)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3336 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3545e596-d5a7-4818-057b-08da3c8517e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AB3k6r/Nx8px9orO3za25NCNhRjOJecfHwWOt/fxvC3W3p3vTI8tCVYSLcRFjUXL3DWYoEFwKQBOqnaKQeiwtzsX7lNnD45KjqT3fuYSQK4HwNKHWzn5/NRtDYZctIUyA0sNsH2Q+8Ts3GSnWM+NEjtj8O11MTVY6k7aAv4IwTN5lw6bd1EqPJWWLGV19Ow8mYdr26FEJy6hD3Twr/dyJCc8f4lQ8slhQpy2RuMgh374w6WsWpVmTjmuDO1kOBIeOk0+0gqt4v0Pgex9uVPgZTaXQodt2j0Ca9IHE1jynRPYgjMfToFc3n25wX6yNZKk6U3wsbmPX3JMjJ2eUDB0KpOGhNW2+iK4ZCXqTU1TGBZrCOarz0pUpkTwwuAfTaU8DrlzIArbLWrCrl5geHKAmmBNaFw4547b+Wqn7xQVafi6e2Y7Mk+Mk5bRpxTBW6qcndg7ETGJXZGdxvm921YLqijGUzWmPo0pI9BQEa/ZC6IOM08hojRUoJd2I4lgrV76TKFRoi4aGjnD6kMm9XmgSeHWJC56UZhCdauryh8lJVkvDQEZyNr3jvMsV/oWFQ0Tlczd9VI9/MlTnXbem98uqBpfVG64AmggKQ3CLomN4NRyYz6v0/zXMqHv8gGhIFl6xHmvFDhRsd1dvIJQCvr7REimEqSGRci1SPMSAEvMTJj8M9xhJwp42nH9YeFH8OJH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(5660300002)(70586007)(70206006)(8676002)(26005)(44832011)(86362001)(4326008)(8936002)(2906002)(40460700003)(81166007)(6666004)(54906003)(6916009)(508600001)(186003)(1076003)(336012)(7696005)(82310400005)(426003)(47076005)(36860700001)(2616005)(83380400001)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:05.9216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b99b23b-7e10-433b-8d7e-08da3c851e22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3827 In current code, when Xen is booting from EFI, it will delete all memory nodes in device tree. This would work well in current stage, because Xen can get memory map from EFI system table. However, EFI system table cannot completely replace memory nodes of device tree. EFI system table doesn't contain memory NUMA information. Xen depends on ACPI SRAT or device tree memory nodes to parse memory blocks' NUMA mapping. So in EFI + DTB boot, Xen doesn't have any method to get numa-node-id for memory blocks any more. This makes device tree based NUMA support become impossible for Xen in EFI + DTB boot. So in this patch, we will keep memory nodes in device tree for NUMA code to parse memory numa-node-id later. As a side effect, if we still parse boot memory information in early_scan_node, bootmem.info will calculate memory ranges in memory nodes twice. So we have to prevent early_scan_node to parse memory nodes in EFI boot. Change-Id: Ia1acab203887114c9f31cb3eeeb38794868efc9d Issue-Id: SCM-2240 Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Stefano Stabellini --- v3 -> v4: 1. No change. v2 -> v3: 1. Add Rb. v1 -> v2: 1. Move this patch from later to early of this series. 2. Refine commit message. --- xen/arch/arm/bootfdt.c | 8 +++++++- xen/arch/arm/efi/efi-boot.h | 25 ------------------------- 2 files changed, 7 insertions(+), 26 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 29671c8df0..ec81a45de9 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -367,7 +368,12 @@ static int __init early_scan_node(const void *fdt, { int rc = 0; - if ( device_tree_node_matches(fdt, node, "memory") ) + /* + * If Xen has been booted via UEFI, the memory banks are + * populated. So we should skip the parsing. + */ + if ( !efi_enabled(EFI_BOOT) && + device_tree_node_matches(fdt, node, "memory") ) rc = process_memory_node(fdt, node, name, depth, address_cells, size_cells, &bootinfo.mem); else if ( depth == 1 && !dt_node_cmp(name, "reserved-memory") ) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index e452b687d8..59d93c24a1 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -231,33 +231,8 @@ EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table, int status; u32 fdt_val32; u64 fdt_val64; - int prev; int num_rsv; - /* - * Delete any memory nodes present. The EFI memory map is the only - * memory description provided to Xen. - */ - prev = 0; - for (;;) - { - const char *type; - int len; - - node = fdt_next_node(fdt, prev, NULL); - if ( node < 0 ) - break; - - type = fdt_getprop(fdt, node, "device_type", &len); - if ( type && strncmp(type, "memory", len) == 0 ) - { - fdt_del_node(fdt, node); - continue; - } - - prev = node; - } - /* * Delete all memory reserve map entries. When booting via UEFI, * kernel will use the UEFI memory map to find reserved regions. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335354.559548 (Exim 4.92) (envelope-from ) id 1nt1WH-0000eq-RJ; Mon, 23 May 2022 06:26:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335354.559548; Mon, 23 May 2022 06:26:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WH-0000ed-Mq; Mon, 23 May 2022 06:26:21 +0000 Received: by outflank-mailman (input) for mailman id 335354; Mon, 23 May 2022 06:26:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WF-0007pn-QL for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:20 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7e1b::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4165afca-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:26:19 +0200 (CEST) Received: from DBBPR09CA0001.eurprd09.prod.outlook.com (2603:10a6:10:c0::13) by DB6PR0801MB1847.eurprd08.prod.outlook.com (2603:10a6:4:3c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 06:26:12 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::7) by DBBPR09CA0001.outlook.office365.com (2603:10a6:10:c0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 06:26:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:12 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Mon, 23 May 2022 06:26:12 +0000 Received: from b5eab67ce7ec.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D0DB6EC1-099D-4C69-856F-F6F8094BDFE1.1; Mon, 23 May 2022 06:26:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b5eab67ce7ec.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:06 +0000 Received: from DU2PR04CA0261.eurprd04.prod.outlook.com (2603:10a6:10:28e::26) by DB8PR08MB4153.eurprd08.prod.outlook.com (2603:10a6:10:a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 06:26:05 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::a) by DU2PR04CA0261.outlook.office365.com (2603:10a6:10:28e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:26:05 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:05 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:26:04 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:26:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4165afca-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NdPYEV01QDiACvm/kmTgxYwzuqpZSLww43AgDcfdiqeDKk4h9W9+YtikM7cPYFocVtbKZ77YksZJo7NYXDo3+Ykm443huQZuve9l4IGJQ+eV9PMuPYQ0+JA8Xi3XxkYzCEyvrcFt08vEYr22oOK4MV35waRN7+YNBhZaE9rkUsXkLx71ecedD3YBANE/iEp5+/rof9L1OnELgiJPHhD7jtlIF5JShexHrMovCPww8Wt/FDOqXV09mMoYfuy+Q37ebWbuOPwcBjm7N90sAvkqF3N3tCpgdBFYuokDvTSRI4P9ifTrIKI/bAt/WBSOE1Ht+wqkmCB36EzJPf5P8/6n0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZH7C2DqN/PCll0sk/Ops4kNowCdYB+hJ4yS3CHVcHc=; b=YNwzrFL2s6lTcTt3cPm0qPOXXZN2vqxOWi22N5IT1BJU+Dr3iAt0Axw0OnIMpo9Cv3vguIXuojGLyqOVuF82Sfg/coEqSk5A9FweKVHo9TKA4V+aQHtRublAz1QwIMQCDY6SLv3SbrwlLOQViYVnGMGoFncXWFsZ57dz/U9SkxT7lM5Hthhup9T6P1B18mynaL5Nx/hGFlq/jeqVYVJkJh2iLOi7BB1gHT9xvFAxSgrih2G7mwgwZCj7h+OD3gZxNc5M2hspk8De8uB+cn9djpmjV6khrRdOQPd35ctKCViSxnkBROLN6XPzThtk9Gd5OyEzXOSGyDqhcKWR+LXMbg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZH7C2DqN/PCll0sk/Ops4kNowCdYB+hJ4yS3CHVcHc=; b=R78yTLitvo0Flswj6c3nZ0LS3eifhq/mKyVmdGjjdsYjxEl25CdARYWsV4NT7D9TTHHt+tn2Y5i80dPb0cGChAVmX+ynuaqK4T157cuGc8GO2O6tE5p36yqhLHbkh92kieqWTWby5gaz3U/nLnjMclYIi0MyMa0Yb52bnCrl+3s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a65b5303d344cfe3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAIFWLCjmQXthbN4ZoXQ5i+lsYqPxahW7b65r617zFULgmhpfYu9t2KzeorjQkzjnVedT7vod5nFkEUmO0CkCzwDxvGxIMjLB4YCyM2G6hQvMKpRrkEiq7UKOElzKYdM6nzOuxGOJwXNGd3yeZ0BKWKyUSWhDgX8WjL/ac6INSikg2bxavXEemtWw2eLMAsB4WRZi7bIkZ7ESJ+woM/2llDX8U44rl6bKuiY9f5TCZ88S2L694oX0pzlkxLXXAdDCcGbjQH06od803ynBt2IntLmQd2WR4bwVC/DmOfwnS7IdOIlK7RA7pDBkpb3aD+gMBkF6chqSfCGzGY3Ij451Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZH7C2DqN/PCll0sk/Ops4kNowCdYB+hJ4yS3CHVcHc=; b=iUBDpgBhVclV4KsQGSwFbi8ePEOen9jplc1ia9my5ex/knSDDcOhuWu+RQbehPqCmGEYtNsQ/id04iAGFcOpJTI/dZiGT1sxSVZrZMk/+vF9/qMRFtxzWNwffcUcODaZ+vZgGMamXr9SSuooYkHngkwUM0HB10CRaFJaEWAdxtXKFNhzwLazCnSwh/5HbveFYKh9I8l19F575BJ/hcrteoXzBfx9vqyvyJA38G3KiUdXGuEhw19UReCJIVqJv4oWoDOlPIlwBsmHlAZFAPIxFRlWHap7p5LSTUg/Pzqq2+xpbvV2JLTwu9/GAS28oPc5MCLjB+f8jcYxQoJASCHthg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZH7C2DqN/PCll0sk/Ops4kNowCdYB+hJ4yS3CHVcHc=; b=R78yTLitvo0Flswj6c3nZ0LS3eifhq/mKyVmdGjjdsYjxEl25CdARYWsV4NT7D9TTHHt+tn2Y5i80dPb0cGChAVmX+ynuaqK4T157cuGc8GO2O6tE5p36yqhLHbkh92kieqWTWby5gaz3U/nLnjMclYIi0MyMa0Yb52bnCrl+3s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jiamei Xie Subject: [PATCH v4 5/8] xen/arm: use !CONFIG_NUMA to keep fake NUMA API Date: Mon, 23 May 2022 14:25:22 +0800 Message-ID: <20220523062525.2504290-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 526069b3-284d-44d5-69e7-08da3c8521f7 X-MS-TrafficTypeDiagnostic: DB8PR08MB4153:EE_|DBAEUR03FT023:EE_|DB6PR0801MB1847:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EWaPCoDYcZaTPJMKbRtZdzJucY/XFqnRmG/TQSEKGr2d6jSAeGhlka710iN9dAXCr7iIsHXOvSbYwhI3+FR3+O5RDlNwkImxNTBshVYBr3Xtv9n3j8jGKRqUd+DCjnp4XV7sAqKB0iwRgQs2bhVdPaEBE4KZ6t2i1XvrdQn4jgK8ke/Tij9M/LWmSm+rXi5RbH9xQwj9crutKzQqztFjxEmC0q+33r/K22zAcTrZZdCvay0a3/tg+VJZKNYrNwVSr3HoKZeczSs1kJl8+kXpxtCSPcf9dpLa3RVjXnm+dfGFW91OBdfjKrdoZ/6zuO082RdsTTu0l0PTCkMauX3MhZmIxwqmIPa5f4TDeiA42DkHfwygNsGFDX4XaxgC5XBIYMEmIkESjgO4+05nyZsy7uyvoYjFC8jMn+ZW7uKhnQtawQx37CQrVjEypG5lzdQxmsahQbbwdUUqOscNj77mvUeQ2qxD0vlOSi7NZ5l5/IKddeMcXu3aen9CJm30A5BAJv12UEXYl4nzNXc5BTAzeQWRhUdYFdFoI2CBDev2ZOWyngOzjPtEwJXBU5L7/7906AJgMFTbxHXeBn7gJteRfQm3mqIiE+BjYv3Ie+cXF3MnrIUlqbqc88ajjG5UJNNDgG2TyVZIdcR+w0DcVlPlr5lGjQztv7Dk1rTdIL151+ESsGzGoeE1mBrLWAfx0XRyYtsjr/yHAQ1qFSnK2t/cLg== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(356005)(40460700003)(81166007)(1076003)(2616005)(70586007)(70206006)(6666004)(26005)(8676002)(4326008)(44832011)(86362001)(7696005)(8936002)(5660300002)(54906003)(36860700001)(6916009)(316002)(186003)(82310400005)(83380400001)(336012)(508600001)(47076005)(426003)(36756003)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4153 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 798b3546-7772-48c9-e5e4-08da3c851d8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U6cHKa6fau1rZm9lniL+OXs5fiYhvHRugZ7Ff/eanHw3R3/Wg3+v7jbcSo835vUg38HzkBQeBhR8zypLr0wIr8Y8ClJXE8P0XQ14xHJ/GnKu9SgM58XrccpDqiKJWPj8OZEL5pC4GKyrvF+CYr61VAr8DHJdwS+ZxYbjZvLFYdqifcGCZKu96cL5Et/WAIbZNcTu6csCzjqZclaj2hlvCrz9UifbGYlA9z6gjm6Y86zPUPV5NVZKR2U1sYyTVOMFTvXA5v9iwY/50rrHJ09b+/Xcd1KtL77emzAWVMwLGDElbXE6DiWSIJ28k/+4koPvl42ahvpIuedUfe7v+J2MBcDQ1cLWrKCJN7+HIq8GdY+EdgfjQ/SwUm/APIDAQscrnMOVJB4e6OP/bKKxnCQh10KHUoc0OnczcDeustQ+mSzXl2YtLYWikFkWmHEiBAYzV7iK9YcLav84dnkoO4pctRUIfGhMsXPhSy84BkJr+3+WVtmQxFNEX1F1jYExG5boYxfdc3s9lPBR9ghwnX5Lmag2RHGw0vQ26NBfWj6fkDeuPkwX6q9iSNi/k43vjHJ3e6VBFfvTC/i2LvvoisYanuofF6G831aoaslDepQfutrZQY54qfz7DnvmsSuplKrJpeaHezjJnSyIh5j8UZGMMw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(44832011)(6666004)(82310400005)(36756003)(86362001)(5660300002)(316002)(36860700001)(26005)(2906002)(7696005)(83380400001)(8676002)(4326008)(2616005)(6916009)(54906003)(47076005)(70206006)(426003)(186003)(81166007)(8936002)(508600001)(1076003)(336012)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:12.4369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 526069b3-284d-44d5-69e7-08da3c8521f7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1847 We have introduced CONFIG_NUMA in a previous patch. And this option is enabled only on x86 at the current stage. In a follow up patch, we will enable this option for Arm. But we still want users to be able to disable the CONFIG_NUMA via Kconfig. In this case, keep the fake NUMA API, will make Arm code still able to work with NUMA aware memory allocation and scheduler. Change-Id: I595b4c84f61f0b827ad9dfbeef03aae30f4752f0 Issue-Id: SCM-2240 Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Stefano Stabellini --- v3 -> v4: no change v2 -> v3: Add Tb. v1 -> v2: No change. --- xen/arch/arm/include/asm/numa.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/include/asm/numa.h b/xen/arch/arm/include/asm/numa.h index e4c4d89192..268a9db055 100644 --- a/xen/arch/arm/include/asm/numa.h +++ b/xen/arch/arm/include/asm/numa.h @@ -5,6 +5,8 @@ typedef u8 nodeid_t; +#ifndef CONFIG_NUMA + /* Fake one node for now. See also node_online_map. */ #define cpu_to_node(cpu) 0 #define node_to_cpumask(node) (cpu_online_map) @@ -24,6 +26,9 @@ extern mfn_t first_valid_mfn; #define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) #define node_start_pfn(nid) (mfn_x(first_valid_mfn)) #define __node_distance(a, b) (20) + +#endif + #define arch_want_default_dmazone() (false) #endif /* __ARCH_ARM_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335357.559559 (Exim 4.92) (envelope-from ) id 1nt1WK-0000yp-6w; Mon, 23 May 2022 06:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335357.559559; Mon, 23 May 2022 06:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WK-0000yd-3L; Mon, 23 May 2022 06:26:24 +0000 Received: by outflank-mailman (input) for mailman id 335357; Mon, 23 May 2022 06:26:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WI-0007pn-Qu for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:23 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0600.outbound.protection.outlook.com [2a01:111:f400:fe1f::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42aecdae-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:26:21 +0200 (CEST) Received: from AS9PR04CA0098.eurprd04.prod.outlook.com (2603:10a6:20b:50e::29) by DB7PR08MB3642.eurprd08.prod.outlook.com (2603:10a6:10:4a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 06:26:19 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::d6) by AS9PR04CA0098.outlook.office365.com (2603:10a6:20b:50e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:26:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:18 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 23 May 2022 06:26:18 +0000 Received: from 1df778f9afdf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD48433C-39B2-4CE4-9B55-16FBCDE8EB08.1; Mon, 23 May 2022 06:26:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1df778f9afdf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:11 +0000 Received: from DB6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::13) by AM6PR08MB4551.eurprd08.prod.outlook.com (2603:10a6:20b:70::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Mon, 23 May 2022 06:26:08 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::c4) by DB6P191CA0003.outlook.office365.com (2603:10a6:6:28::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:08 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:08 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:26:07 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.27; Mon, 23 May 2022 06:26:07 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:26:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42aecdae-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VgE00X9kVtQbIzXXEG9qzacXaXWER5WfS3RgOLR5DLxg2hemNnh3nh0nGjbNaFdNaZqqxNee3jbJ07RWFPQipE2yAnL9n32B+QOZc8bJi73fzIlXQxClg/sJ1CpSyc3Y0P55GPuyASt2NBtnYWr9UQCmBA5uEk5vKEknMznGk8AlhCLyGbvM5Rj2IQcnjWDxZ4V/ZSF6NmK9mnOql7TMrkg9bNGZJGbAtpw0uRmjxdFOu2JhcG0IBB0m7XmCffQutrCsCg1/5z/y3e0EUxNDXQ7JuZhqpiKjoDYZZ1oTjj/tJokYrkMIlhx4Cl+gQSBTOrknzRfhFh1qWwyYH25aug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLz9U4f5kBuwv8fnxvQyEObMqpaBQsZ5NTftoU1ebo0=; b=n3prIL8aCyivzg5zQ7tLjU6DctejpEnpIoUazvi1tIrgCi1Lj8UxzyITFDldqn0UDxse+R1qDUSNy13y/NVxnzdy9yNlrqfeqP+49Zffz3UNcXIhmcZ+FMHGqWSJy/e/TGFAVCdqaSQ+/dB0YRpQENwWUp450R/7ec5KPbROPSEvvgS5gt6B/FVd7k2Lteoqedluy3VtmRQm5VPcPC9rDKAvD/Tf4NdfQN3IBShLYcUHNPSYSnXJICSs8LrCxqQRkgHvnaJj7m9/E+1/ExBczE/Y7zFMIzbQ1kqxHGFb2D1tECzseoiQ0lYrLsjN+tZEg6fhSniRCbUmJl55fQgBhg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLz9U4f5kBuwv8fnxvQyEObMqpaBQsZ5NTftoU1ebo0=; b=Sb6cy0hPMNnvEwSqRE1pz9YQAl/r4PXPATqrH0cPntT7VVGCA4Tz94AkZURZb79Z2FrSeD0jVGwLKJHPQBsipDTgFm/FnKl0or2HOBlzVsKL+ZfhmAZTACZ21JkMIQivqJqdCZKnxzaNbkCB581k5QPRlccaC4U5pMV4iYOC29k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f5aa893e04a90374 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izPrzjYtgf8q4E/3BmZOqMEJZyvmbSQNpw3zRAA7Ik2rGtlZ1NJcMyoovq0rSlJnHLFbF70+4i5LZDyFjm542mc30wIs+nQ3RYSyE/kZlQB/xdpXTPZNC+jnp3f9JFPx8hMsmDls5y586x85pzj0d2ka/DbiPwkNPLlQoxPCbF1PG557uYJyWyVDXFHDMLZgku7/Lv0xCt9knj8slJTtMxKVz3XA0uQNmunBmo1RbEWxUqQDIlW8h4V6fKLRs7P/zdrYFE6eozPM1hAO/A2qYNf+rK+QBYUaA0ZHk9ELgiZfgRQAkh1xUKIrNwPrcbMAjACpp8q+/5gJPHMvZZLqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLz9U4f5kBuwv8fnxvQyEObMqpaBQsZ5NTftoU1ebo0=; b=Rz/dc0gMbVSgScVb6fYy0gyutK8Y1fnpaJffOLTMaA3p5KUhp4FckbPSEPdyRfDXnOUSSZ77VvQswWp+mmLoH4J9g4ypPTWd8WL5p1OaCVfFqrtbUkJrllQE0DdrR+MSHkvelLKgRPnUDxMIbP+ud5xNZydieUuoMZkrO4D2sZNrgA7w2BCgETFtsznW7wwLP+moXuI9USZNRsDhDHnsT4vfqypbiL2ut78ESqUvZe8WZ4AVC5pXUj2e/BDrIj4aVAlDuFmPJ2/IoVxePmNiKaB1krUl4dmuCYuNYhBm8FtBuKYD/hKl9Yrd6mCKfNOTMXb9VDn5xwQBn+KwCDvhQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLz9U4f5kBuwv8fnxvQyEObMqpaBQsZ5NTftoU1ebo0=; b=Sb6cy0hPMNnvEwSqRE1pz9YQAl/r4PXPATqrH0cPntT7VVGCA4Tz94AkZURZb79Z2FrSeD0jVGwLKJHPQBsipDTgFm/FnKl0or2HOBlzVsKL+ZfhmAZTACZ21JkMIQivqJqdCZKnxzaNbkCB581k5QPRlccaC4U5pMV4iYOC29k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v4 6/8] xen/x86: use paddr_t for addresses in NUMA node structure Date: Mon, 23 May 2022 14:25:23 +0800 Message-ID: <20220523062525.2504290-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 0b5b9c2a-c195-4d8d-76a8-08da3c85259e X-MS-TrafficTypeDiagnostic: AM6PR08MB4551:EE_|VE1EUR03FT044:EE_|DB7PR08MB3642:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GJU/wEYLfiuXfxxnb/OkXgmAGgo9v8i1LBqLNl6GsNEL5d+PNXDK83Lp2t7SX5H3d2pV1jFX2NRNqYMQqR8rtSNNyUex7aW/EQFRhyTZpB8TqrX4JX2lIqPvyi1Sv+LD86/7xUgT17frvPQ4aQDg0XbYjrt5mdi/CBpOJGugNEqLOE9lhUrq4pgc0GUgmiHnXRjTcKW6BQJXMLMV2VvKcGi4RPfLw+79D5zlmxdsDKOsEk9mSPA7bCuGoNzk1WKTeArstSVAqo7JNsbKFeNxg91zcXbhmn/r0/mzLZZyoFB97EKrjjNd+AvNOvPni3CfJ8YCdDrCE/9LoX5sYPdbwX3c0xO6JFKqlCXrAycQY8WoLNTqXdljxlyXXAPl5FM/IYcJ2pCTAIDQ6Y0Xz42uYcTJsC0dLwd4RIA8LDoFlSbOIpWWW5uKJYlYE1fneOTFY2sWZFQ7M3niYqbTkxByhK5/EBQuXchFfkuc17195WNWd4+t8okINr5thy54GQdH+fi9mU1z0pdCo0Qp/NvL33P0DcTUR7dlCB3kVn49pypShQZTBfE+ZIfNisK4eHvxnLnNjVUHKoEI4eZhJDZIL9PLg7G90vpqBtWm6MxEpqfS9Xxn5PQKNBOzZuxnP3VRktVzKW5lJm7sUaGdcy44FywqPgCZEg3rztKh/2D+7/Bx2PV2hsCokfsDFaWWIoXad+S4eBoXCeeRtg0XgA+keA== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(47076005)(316002)(54906003)(4326008)(336012)(426003)(83380400001)(8676002)(82310400005)(70586007)(70206006)(86362001)(36860700001)(356005)(81166007)(2906002)(26005)(2616005)(508600001)(6666004)(44832011)(36756003)(7696005)(40460700003)(186003)(6916009)(1076003)(5660300002)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4551 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 37b3d7dd-7440-41b1-9fdf-08da3c851f9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hs/ZPJRdBIgS/J3az0a2mKOs4wC1ndzzYEPeg+Po1qQpWDQEMI9hV7O7bAfUZ7470cO+2tIRyXzPNzF7vvnylMSarY6VmACC4ZcxtO8G0Ci7E61bUoJXZ2yKGkn4Gb/JX8dRr6IgsayOJMtSpPNibT4eZSnXvr1AVo1rY92eSjHzjRCZCZgseG8yt1FRaufKKd5G3+EMD5DwrVA8fqrLrjyQ7uJV3kM3Jg2J6gnn+Orc9Asnz3v6T03vfWGnftVthlM1hKDlbgmkwpmYVAtqZEqXsVkY7FGF3MYvG7CP9QQHApRdxXBtLJRIjUat9R/CJizjFbYmedJqkEnod5pFzZSD2tRwkEMMTDCUXBgLiryilmbmZ5qqpIaFnsDRCFHyjCW1FOzMC/urS+mS3hTDo5S1bfeSzRC3V/F8lKOwh9j6YJjtynf8zj2FQdLAh9+K5kIA4mVsDjKWRR2eHLK02yFFl1qCCprtdi9qPexfPsUO/esmz2T67aNqPP1cIqHhIjOz2E3P0Ui/gf8GnMS+7CbCouGYz+v+4/i48cAa79US5ynuDzLG11NpCiMSVrmyLfybbLIrsZT9FG4IcYKvOdavrXGViRTpJSzZKAh1y16n1z9otuChP10krXFHqBU0Es2L/kS/CDpcM5e0LZZ2AQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(4326008)(83380400001)(86362001)(5660300002)(36756003)(8936002)(508600001)(8676002)(7696005)(316002)(47076005)(426003)(336012)(82310400005)(70586007)(70206006)(36860700001)(81166007)(6916009)(1076003)(54906003)(44832011)(186003)(2616005)(6666004)(2906002)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:18.4399 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b5b9c2a-c195-4d8d-76a8-08da3c85259e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3642 NUMA node structure "struct node" is using u64 as node memory range. In order to make other architectures can reuse this NUMA node relative code, we replace the u64 to paddr_t. And use pfn_to_paddr and paddr_to_pfn to replace explicit shift operations. The relate PRIx64 in print messages have been replaced by PRIpaddr at the same time. And some being-phased-out types like u64 in the lines we have touched also have been converted to uint64_t or unsigned long. Change-Id: Iac64ff398c10f6e642d40d06fc57e28806a1a4ff Issue-Id: SCM-2240 Tested-by: Jiamei Xie Signed-off-by: Wei Chen Acked-by: Jan Beulich --- v3 -> v4: 1. Add Tb. v2 -> v3: 1. Use uint64_t for size in acpi_scan_nodes, make it be consistent with numa_emulation. 2. Add Tb. v1 -> v2: 1. Drop useless cast. 2. Use initializers of the variables. 3. Replace u64 by uint64_t. 4. Use unsigned long for start_pfn and end_pfn. --- xen/arch/x86/include/asm/numa.h | 8 ++++---- xen/arch/x86/numa.c | 32 +++++++++++++++----------------- xen/arch/x86/srat.c | 25 +++++++++++++------------ 3 files changed, 32 insertions(+), 33 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index 5d8385f2e1..c32ccffde3 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -18,7 +18,7 @@ extern cpumask_t node_to_cpumask[]; #define node_to_cpumask(node) (node_to_cpumask[node]) struct node { - u64 start,end; + paddr_t start, end; }; extern int compute_hash_shift(struct node *nodes, int numnodes, @@ -38,7 +38,7 @@ extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); @@ -76,9 +76,9 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(u64 start, u64 end, nodeid_t node); +extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); -void srat_parse_regions(u64 addr); +void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 680b7d9002..627ae8aa95 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -162,12 +162,10 @@ int __init compute_hash_shift(struct node *nodes, int numnodes, return shift; } /* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, u64 start, u64 end) -{ - unsigned long start_pfn, end_pfn; - - start_pfn = start >> PAGE_SHIFT; - end_pfn = end >> PAGE_SHIFT; +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); NODE_DATA(nodeid)->node_start_pfn = start_pfn; NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; @@ -198,11 +196,12 @@ void __init numa_init_array(void) static int numa_fake __initdata = 0; /* Numa emulation */ -static int __init numa_emulation(u64 start_pfn, u64 end_pfn) +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) { int i; struct node nodes[MAX_NUMNODES]; - u64 sz = ((end_pfn - start_pfn)< 1 ) @@ -218,9 +217,9 @@ static int __init numa_emulation(u64 start_pfn, u64 end_pfn) memset(&nodes,0,sizeof(nodes)); for ( i = 0; i < numa_fake; i++ ) { - nodes[i].start = (start_pfn<start < start) { @@ -275,7 +275,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - u64 start, end; + paddr_t start, end; unsigned pxm; nodeid_t node; int i; @@ -318,7 +318,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) != !test_bit(i, memblk_hotplug); - printk("%sSRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with itself (%"PRIx64"-%"PRIx64")\n", + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, node_memblk_range[i].start, node_memblk_range[i].end); if (mismatch) { @@ -327,7 +327,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) } } else { printk(KERN_ERR - "SRAT: PXM %u (%"PRIx64"-%"PRIx64") overlaps with PXM %u (%"PRIx64"-%"PRIx64")\n", + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", pxm, start, end, node_to_pxm(memblk_nodeid[i]), node_memblk_range[i].start, node_memblk_range[i].end); bad_srat(); @@ -346,7 +346,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) nd->end = end; } } - printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIx64"-%"PRIx64"%s\n", + printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n", node, pxm, start, end, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); @@ -369,7 +369,7 @@ static int __init nodes_cover_memory(void) for (i = 0; i < e820.nr_map; i++) { int j, found; - unsigned long long start, end; + paddr_t start, end; if (e820.map[i].type != E820_RAM) { continue; @@ -396,7 +396,7 @@ static int __init nodes_cover_memory(void) if (start < end) { printk(KERN_ERR "SRAT: No PXM for e820 range: " - "%016Lx - %016Lx\n", start, end); + "%"PRIpaddr" - %"PRIpaddr"\n", start, end); return 0; } } @@ -432,7 +432,7 @@ static int __init cf_check srat_parse_region( return 0; } -void __init srat_parse_regions(u64 addr) +void __init srat_parse_regions(paddr_t addr) { u64 mask; unsigned int i; @@ -457,7 +457,7 @@ void __init srat_parse_regions(u64 addr) } /* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(u64 start, u64 end) +int __init acpi_scan_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; @@ -489,7 +489,8 @@ int __init acpi_scan_nodes(u64 start, u64 end) /* Finally register nodes */ for_each_node_mask(i, all_nodes_parsed) { - u64 size = nodes[i].end - nodes[i].start; + uint64_t size = nodes[i].end - nodes[i].start; + if ( size == 0 ) printk(KERN_WARNING "SRAT: Node %u has no memory. " "BIOS Bug or mis-configured hardware?\n", i); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335362.559569 (Exim 4.92) (envelope-from ) id 1nt1WN-0001TU-Ty; Mon, 23 May 2022 06:26:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335362.559569; Mon, 23 May 2022 06:26:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WN-0001TH-QF; Mon, 23 May 2022 06:26:27 +0000 Received: by outflank-mailman (input) for mailman id 335362; Mon, 23 May 2022 06:26:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WM-0008Q2-M6 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 458d16e5-da61-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 08:26:25 +0200 (CEST) Received: from DB9PR02CA0016.eurprd02.prod.outlook.com (2603:10a6:10:1d9::21) by DU0PR08MB7613.eurprd08.prod.outlook.com (2603:10a6:10:311::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Mon, 23 May 2022 06:26:13 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::90) by DB9PR02CA0016.outlook.office365.com (2603:10a6:10:1d9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:26:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:13 +0000 Received: ("Tessian outbound 6580ae46f51e:v119"); Mon, 23 May 2022 06:26:13 +0000 Received: from 40971db31545.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3F52B494-63F4-45C3-85DC-6468C30B9DC6.1; Mon, 23 May 2022 06:26:07 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40971db31545.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:07 +0000 Received: from DB9PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:10:1db::27) by AM6PR08MB4936.eurprd08.prod.outlook.com (2603:10a6:20b:eb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Mon, 23 May 2022 06:26:02 +0000 Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::8b) by DB9PR06CA0022.outlook.office365.com (2603:10a6:10:1db::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Mon, 23 May 2022 06:26:02 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:02 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:26:01 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:25:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 458d16e5-da61-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nq9/h4o66eCTO62J8SHiEvmv/+W8LAEeSWjQ110P5xycNwN3hxFOXytPIQonnKEg04dLVMAVyCnlvUFvVMfKUcOsSMSITelyy6uoIESqDjlCh/zh2VZnWrTHKO2I2A6WLfseS0Kmrut9pb1LnTwFMMFviCWqlKiYk4ADRaNE7G8JeJxFZ+gYny65UIGiLLbR3JsWkv78Lttf0zzDZP55mcwzvXCv+WIQty2InFyVcVv5+UXt+kitFEUZKVe0tS2Kq4khjXadKv5xsihtJOTvxr7H3HdW1IerKT+Mbaw+2HEjIcWTCM2kLDB315zt3Fx1L2It+XqJWbzwRNOmpJAl6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GQ8cRjoyAomDmwPvqhEhvMhEOhwa4PJfeQ52AeZoUY=; b=FcUbvcGuVhpqM5Gkolfm/WhXKjEPxx5uXa5R2J4ngUmflG5j5Vx0CP6aoGWFEJrmiu9McYLTh0u6PLJfdNnW7zkFLT7MTgwrdy4ul6YxXxBHjMpOzIzI6ED7vrkpUhijK7fB2hKFi55PNUqX3lQ2+CPgDjrqq5DWODvIq7vR4lhzTGx2h9oojeTujAkhX1sR8zrmWprAnHz9w3xdW/YEailwix6EVrZSsLDugHsO+R441GL8IUu2tu66DqB5uJdmhiDUJD9FVBWh4Stk98Zu84Mq/k1c5/KY0i/l2mU/yAETJZNWYyMvfU1BKyfsGzEPOTfDOHwrWIPHHigcxjfp6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GQ8cRjoyAomDmwPvqhEhvMhEOhwa4PJfeQ52AeZoUY=; b=jS5uYugkkXeX6jZ/zj7kV0DMzaqLtDgK2pKUVMmelch8H3zJgfZd7TvEf613PbTkU++LJbHBDI2PHcpHukdDWZc3VYSiZSOh7RINSgSX8nMcmjd6Mk66tLEMbP1hYmpBX5kK9CQ6GHRIiD8qIHM9lm9qsqN4HJx4vFIJVuAjfik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3e3845afd65344b0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oz136JsgiiXMSykpSmpkv3GtkcDiJ1F9snFVy8vuC0yEH5Z9xJLV5HFGfMAzJvhEphNpArGWhGzNURgp5OdsZEQrvtexTvCVMRA9gUPdG+ZcB+PDRha+qhwPn0X5t7Wg3Nxn8UyGzJo3GfT3n81rSU505bWaJDzhkJSPGicP74XWhPyKpx6AlVrvX/0nVr93kinBePpUUAg+pAxRIsX2DNxuEzzFrKPULH7eVAN78CaY+lWjOI5AQRQwYNvH5S/IFa09pwHNB50DrDmR6kpUwCsWjn3cyTktC9LQztJ8cvPHV5HBYcyJ3Ug3BkzkmnRH1SH6ZZF/e3VxAHSmD39Bgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GQ8cRjoyAomDmwPvqhEhvMhEOhwa4PJfeQ52AeZoUY=; b=GJvhalGY5whTNIjpCkJpqaxp3sl5tTkDZ8x3WbmA+kqLclttKpFJqngPUzSWM0G9XEyeYVJ+gJzMiUWBEjyGT5ZeoLRQV3l89nbe8Znn3ijKiqAIG9ALeHUiDN6+zrf964Uj5wC/3LgQjnT8uO0M33c5p9thnIzNKCf/RQy+NGc8MjUVmwfQ6nqgBwvdad8U2VCHq6Agrv2sRccVYryxMgaqUWaPUcf1V12gPBF16AoABTPOCD+vHapgeL60A4/TzXkDadQZWPmE/5JjacH/LcmXIx3KGQjvMSCuKE4/BG9DCkBr4oyNgWyFyuWUcJaGkSFXb8pZlYmOy9bxFWK+yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GQ8cRjoyAomDmwPvqhEhvMhEOhwa4PJfeQ52AeZoUY=; b=jS5uYugkkXeX6jZ/zj7kV0DMzaqLtDgK2pKUVMmelch8H3zJgfZd7TvEf613PbTkU++LJbHBDI2PHcpHukdDWZc3VYSiZSOh7RINSgSX8nMcmjd6Mk66tLEMbP1hYmpBX5kK9CQ6GHRIiD8qIHM9lm9qsqN4HJx4vFIJVuAjfik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Jiamei Xie Subject: [PATCH v4 4/8] xen: decouple NUMA from ACPI in Kconfig Date: Mon, 23 May 2022 14:25:21 +0800 Message-ID: <20220523062525.2504290-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 89bbd995-69e4-4830-1b22-08da3c8522b7 X-MS-TrafficTypeDiagnostic: AM6PR08MB4936:EE_|DBAEUR03FT043:EE_|DU0PR08MB7613:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8wrQRKmB2bxTo5kapelnM3YNFawBKWt5VD2SsjvISJ3Y0zdN9Mp+cJmpnmpYS5n5fyvsGHoWqcec9BStC5oBBY2rZRqmN1UPPerGXK6Ej2qddZUqvHIqVrPkYOgVO31DjeZyKmC7ky7/b0wbiXATm3xMJhmhf64JmP4SHVxWdnoxQkkQW3YFDVYVn7ICVy/otT+6WkoaNMKNzQDZLeMmaoyAZpsLI3euoiF3+szxJRm7uVzmkhcK14zxunm7X0PgD12fHHntUvHw3Pl99pCoac1Wg/coIm/4ac8vPoIKHyNfxQzYiIdtCFqYURlE9MmmzQvmv1xOrpyCgz8SZbfXX8PIA0TYhe0DakbvL5qSRxec5pozIcgXhujzv+D9PgDjA6kO+PKgQR2/lWkQ/eUuVh+XQ2cgRxwwI7y8M37E+38md7aZaR4UeIcBiHgg9FXdY+hd6RaqD6kZoC+t9kWn9wxxx9uKLKFP7+5hwFuGUVv8g18OjnMj4MpbY27dSCYkoFlH8trFGvuQ3JNMWMStX9cLrnLEsRZLoNVME4/28ux4CRq9O6F2EObZvDksaIHq9YACNqgcaYfw+Il/1b6FQSqb+AMQciiGg/PnNwYT09/c+3W0fwjM4go/Nutz8po1EVC1FqubrxQLSQq0wnMmvDECJxlYVPOepRuOOae/W49RjMuPTqYXlBcHc94uIhByugNXzkVhziBFJjrjtE7Z8A== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(81166007)(83380400001)(82310400005)(86362001)(5660300002)(40460700003)(356005)(316002)(508600001)(6666004)(36756003)(36860700001)(7696005)(2906002)(47076005)(8676002)(1076003)(26005)(6916009)(426003)(336012)(70586007)(70206006)(8936002)(54906003)(44832011)(4326008)(186003)(2616005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4936 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: de5541b3-f6e0-40e5-7fad-08da3c851bcd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MCzm8p5R8g/OYzMg/OPgTBwfQqbGlqe4/d2+K//AsUr/3jplZd1WxMrybHUDRAQhdkfialZndlvYYqTqxP1FPlReIlosiqUXvliYrSKjpSkc4MQi+7xbMA7r5pIC8Y/gRpOGfkcmmFsNjlWF38SeSCrGLXdtV63aaIaiq80YodpjSj0WnPqzS08vqbsUNYDUHRSNApMS4gnowDiYRd+L/U+eSuYm/ILRdCbBJUbvn46tJbmuW03sPr+57FRzSKuMCrMnj4BC7pO5vDfYeoN2eosOpyjwImqtDTy4mi6dU0VlQ0lAvy/f9FkYjGzFFAL2PA8fcdcvbJvM6UGQIs2und//4jI9YO6PWV5x8GQFj49ZRCyl26EYZtE1+DAXxbYrNy9lMxrpgOwzxcvD8FOZW/e7j4TP32wRRxlLtbDjITZRO2i5vAPIEwYhqZOo+ZboBEG3QpiNs0Pnw/LnYndT+lp78/0arvJIsvu0NeZOCd+9/8T2mVUp6BRSKDc0BWJEKTgtD2suvX6FDCGOXFOgLI6HvVdc31z6gpZWgAcOn988fpQE+WFBtKzCe8JUO2Ee78S46B95ZF4Qxi+1BDidmCHD9CN7caY9dpzjOQJBWJn3tUswSX9gkGeidzoE84WzrufigiSv3JfRBTcR5g+XZIwnv83RwPEdE8EZ5KY6RUEnM8gQMlqY/nmEctyjXiPr X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(186003)(7696005)(1076003)(47076005)(86362001)(336012)(426003)(2616005)(81166007)(26005)(36860700001)(83380400001)(5660300002)(6666004)(82310400005)(44832011)(8676002)(4326008)(36756003)(2906002)(70586007)(54906003)(40460700003)(6916009)(508600001)(316002)(8936002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:13.7088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89bbd995-69e4-4830-1b22-08da3c8522b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7613 In current Xen code only implements x86 ACPI-based NUMA support. So in Xen Kconfig system, NUMA equals to ACPI_NUMA. x86 selects NUMA by default, and CONFIG_ACPI_NUMA is hardcode in config.h. In a follow-up patch, we will introduce support for NUMA using the device tree. That means we will have two NUMA implementations, so in this patch we decouple NUMA from ACPI based NUMA in Kconfig. Make NUMA as a common feature, that device tree based NUMA also can select it. Change-Id: I926c73c10aa9bb8e1e7ff77596afb11d3ea18363 Issue-Id: SCM-2240 Signed-off-by: Wei Chen Tested-by: Jiamei Xie Reviewed-by: Jan Beulich --- v3 -> v4: no change. v2 -> v3: Add Tb. v1 -> v2: No change. --- xen/arch/x86/Kconfig | 2 +- xen/arch/x86/include/asm/config.h | 1 - xen/common/Kconfig | 3 +++ xen/drivers/acpi/Kconfig | 3 ++- xen/drivers/acpi/Makefile | 2 +- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 06d6fbc864..1e31edc99f 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -6,6 +6,7 @@ config X86 def_bool y select ACPI select ACPI_LEGACY_TABLES_LOOKUP + select ACPI_NUMA select ALTERNATIVE_CALL select ARCH_SUPPORTS_INT128 select CORE_PARKING @@ -26,7 +27,6 @@ config X86 select HAS_UBSAN select HAS_VPCI if HVM select NEEDS_LIBELF - select NUMA config ARCH_DEFCONFIG string diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/config.h index de20642524..07bcd15831 100644 --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -31,7 +31,6 @@ /* Intel P4 currently has largest cache line (L2 line size is 128 bytes). */ #define CONFIG_X86_L1_CACHE_SHIFT 7 -#define CONFIG_ACPI_NUMA 1 #define CONFIG_ACPI_SRAT 1 #define CONFIG_ACPI_CSTATE 1 diff --git a/xen/common/Kconfig b/xen/common/Kconfig index d921c74d61..d65add3fc6 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -70,6 +70,9 @@ config MEM_ACCESS config NEEDS_LIBELF bool +config NUMA + bool + config STATIC_MEMORY bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED depends on ARM diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig index b64d3731fb..e3f3d8f4b1 100644 --- a/xen/drivers/acpi/Kconfig +++ b/xen/drivers/acpi/Kconfig @@ -5,5 +5,6 @@ config ACPI config ACPI_LEGACY_TABLES_LOOKUP bool -config NUMA +config ACPI_NUMA bool + select NUMA diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile index 4f8e97228e..2fc5230253 100644 --- a/xen/drivers/acpi/Makefile +++ b/xen/drivers/acpi/Makefile @@ -3,7 +3,7 @@ obj-y += utilities/ obj-$(CONFIG_X86) += apei/ obj-bin-y += tables.init.o -obj-$(CONFIG_NUMA) += numa.o +obj-$(CONFIG_ACPI_NUMA) += numa.o obj-y += osl.o obj-$(CONFIG_HAS_CPUFREQ) += pmstat.o -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335365.559581 (Exim 4.92) (envelope-from ) id 1nt1WQ-0001wz-Ep; Mon, 23 May 2022 06:26:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335365.559581; Mon, 23 May 2022 06:26:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WQ-0001wm-8j; Mon, 23 May 2022 06:26:30 +0000 Received: by outflank-mailman (input) for mailman id 335365; Mon, 23 May 2022 06:26:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WP-0007pn-Co for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0d::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 461f1715-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:26:26 +0200 (CEST) Received: from AS9PR04CA0096.eurprd04.prod.outlook.com (2603:10a6:20b:50e::26) by VI1PR0802MB2512.eurprd08.prod.outlook.com (2603:10a6:800:b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Mon, 23 May 2022 06:26:23 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::1d) by AS9PR04CA0096.outlook.office365.com (2603:10a6:20b:50e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 06:26:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:23 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 23 May 2022 06:26:23 +0000 Received: from 087b98c53955.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 70469D15-99EB-41AA-98D4-AE064CED749F.1; Mon, 23 May 2022 06:26:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 087b98c53955.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:16 +0000 Received: from DB8P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::21) by AS8PR08MB5944.eurprd08.prod.outlook.com (2603:10a6:20b:297::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Mon, 23 May 2022 06:26:14 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::bb) by DB8P191CA0011.outlook.office365.com (2603:10a6:10:130::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16 via Frontend Transport; Mon, 23 May 2022 06:26:13 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:13 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:26:12 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:26:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 461f1715-da61-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KCVcJZhJUZbhnkKSMpKaO3cdh3pvmYhNpz7DFCUDQRkq0UF02uqcokFBBB/ZGRHwQu3iOeKB+1Dz4AgJJDxqhZdzT65lNQSKs8elOBRz0SXDZYBoDfETJZwFthH2Pv4lRq57+eRyHewLV1Rdc93nYpNAcL7E8jPjz7753SKt6P4wKttlyIxs65krkENwL9dyfxX9vUN3gIWauOCymZROvBdxW32pBpYe3mA5vLkjpY7PBJUGRIAiyNrb2v+5JAfGKkF6gdd4A0AgNSg023PZSwstidwUIqnQv0LYWeOAVZmVzPgxlCjD7+xovL7MU1p5QbcaMElSeyL912pPPTDD/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=MxRw32muwCC5hE+EmCg7ucoXyUnukSHBAgCBeC+jub9xc6JGZoj6ydnWeD535Kas8cfv02ROtgJ9t4Kl5vo/rd2SC2ff+3VDqms/ah7Qc/sQkdaXzwHlMtE3qRmV9LO0rg4kmpB5lVtJBFO1Fe95amifSwAd58+tTKuNxOmrAlnCONVebrMPZFe6iQzjn3A3C8CDygzRZgiRN+4oTP1836UTwqWk/FnIuj0UQipC1MRfLoAA1lN8ob9vMTAYTWCPh0w9u5nAsUmGdHUawnJQu6mHTtiE16C2VC6yoNbhXxP+2hHP2W4cpge6J460c93XHIh4HaL2W0bo/iXSZsTtPQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=KBaZZdq74csLi6ln6eYuQxJ5hU6Xqwf3fWSAQKknxJo369e7PtEuf3NDNFXs5DJN8Gb5qCvWq19VYLmVb/j3sUNKk9pXdTv6TSFo+76j+IwR0Ghp55etdeMU+/88gRnuIo5kOwlBcNsmf6TSt8NUO9VVYe860bkvA7DDJF1rOxQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bcb0d0647ddc198f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYNw9B522rvIP5stLZMPI7Aswxl5/52XMGIb9s59D2LfNrlPBivZraUuhjPg4ltIYzTmn7sHkvqjMTOrl91wqay/XSNYQ9+dK7GfLK4P/Eg3RkjepdTO2z8WVmfIhzICTkKP1iqRk++GWasKebDUqwOaEpK3y6VfzT4xDaJKXKHrMKzCJ3suWyyzpODdnUbj9tURfuJRtAa7aCFGSBj6LSJ4/lAwdU8ykKTTfUJhGgKAInqRihXyvuQqafkNbsyWm4TyYVCWd6+FNCZK5XO+PUPGWoGcqLqKAm/IT2rxnacr915zJQ0TF7aM7zQgCBCpdNvBwiFMFemjytNwmDK/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=QdvKwzQ0NKb6fXKS2hfI844uZq3LnVYD3PlXPtzFMB7owJQtsk+vQdV6mHGOOChR+rBhD7OV+1H3wGtjodZJ7ji58GJHkRiXQhcby42NybL7dtOMlnHlmQZtRnMvfkXB3L3JuP3ra4LPQY3q/UpQgpGaGG/mNeXzRJMcfqctO5PaKGwOlvKgO+Yhrv7fFkicBA+SE7S4keK0t/nCW3LhyMTt9459zSK1rRrZiGaXhelSs4yhbk3cVfEQ1ktOyAz647GyQx5C45mDqynxiN8syQHGqwW+GTrq/fwvMphBDq5zvdTV4YYPkmBpeQc6pOYMZLmi3VaKwjqe2fxgxDfBjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=KBaZZdq74csLi6ln6eYuQxJ5hU6Xqwf3fWSAQKknxJo369e7PtEuf3NDNFXs5DJN8Gb5qCvWq19VYLmVb/j3sUNKk9pXdTv6TSFo+76j+IwR0Ghp55etdeMU+/88gRnuIo5kOwlBcNsmf6TSt8NUO9VVYe860bkvA7DDJF1rOxQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v4 8/8] xen/x86: use INFO level for node's without memory log message Date: Mon, 23 May 2022 14:25:25 +0800 Message-ID: <20220523062525.2504290-9-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 3b7b541f-472f-40cb-f96b-08da3c852877 X-MS-TrafficTypeDiagnostic: AS8PR08MB5944:EE_|VE1EUR03FT044:EE_|VI1PR0802MB2512:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vH2pEClYPyETMjP1jSI42xqA+RGpwNvFb0/TxkMJFNllPZM5neyrMHjp0K2Sj1dJDgpaGktBTUcxJeta0o8I3rsfEVnAgTQ6Sj/YAOYflkI32zxbwVj/yT9N698pChFDvACleixHuDfLbX4qpY2hiyjfhY/6qNqRSkLV950WqamI3PmWn0Bk9YmX1UvTwEj3FCe8rVM4EParSNXqOk6WLE5dMN2+reUZSXj1r8PgbRvEBdIfnYmhWW86j/0A+4VeZ2nAK2gCjyGFTV+knezNtFu/3DZliQuZSCNMidiRA0I2+qbeY3U2EPb2jcJyqdU+Ou2Os9R1Iz+PKV1fMxJ7iY7d1N1yUMp1ot173BvrMZc7zDbbOKJyEnKgc63uLbQdMdCQSkT9QHwIOZ4FOiNOMVPBirZ5Pbz+JfuzBOK2f+QkhAZoyfFl9aAAxW5r78s1O1YnVlHFjh18mvULUXZyIL4t/bEIYa14lY3udgTKtoko8/FC+JIjePMAMsyydnpG1n6t0z0lZABcLI44KcF5RYGvrCbM/bjLR0LF4jXRrz/BL/hvRE5k4C1BCX4ZSZoPRjGFCIqF4FO258NxohLNnclGsGRgz+8B38se7Fm3tXrqoOELGHFOZZu8w22oOfXY6SEe7IMIyXy5cBsW09xGBlekVjMgY6B7XonY4AYJBNSz94AcQV/XRlzFnntPO7H1f14TJVLSMB0KoIApUCCbfQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(356005)(7696005)(70206006)(8936002)(36756003)(81166007)(4326008)(186003)(2616005)(5660300002)(8676002)(70586007)(82310400005)(1076003)(54906003)(508600001)(6916009)(47076005)(336012)(15650500001)(83380400001)(40460700003)(44832011)(36860700001)(426003)(26005)(6666004)(316002)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5944 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0557d275-4b3f-4df0-32a7-08da3c85229c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BhB3vtE7jOpPhvqJx5zZ407sfN0vKKMNNf+UNh797H7b91j7kU/WXXCl7lXyaq++L1CvBG7caYZl+hB4l4xwhZW5HW+iD4PBo1jwUQmLNFQFZTpvS2Zr/yptDds7OflPVhxegTkFCLSpqr6zZOm7yHQFD8uR0pduv9vICSGa0UMd/uKdMD3je+VV1U4LEairxedDCNanHk+KRt16ezmOnOWhf4P6OyrnndBaTqBokChnWKRxDiCqQfbvGWoTtbVv8+LK+Nid/I8+Q7gvae4P3ZVhBtOnyBVN/RoHG1vhmD11t+VUHFCugwdSqtESyI6WRWEH63oeF+DYXU+AUIelI4L71DF+3Kc5+j8hMLU5d0p2BX0k610OyFnBi5Fsi1lNEXNZhCd24s8GdRqiEQ03hPnRs1A35LgjwwIJRTyY8K7JDeI7d25cuaeLdQ3xEiP6J41nYGEdQGk1KXTiAY5RyoIapbirZNg7lzq+8fS6Bo9F2020Q3BXCKSX4tbjVI8tqY99SA5qYPG+hzdzkgCH4hLj/d+UuiGTUwua4F+2rn+NiXUvUurgPL1VTiidNFGJ6gComII1FNYwooDl296MYfCOqT/3bXHAM/DfVmbce+u6SUXCOeRHIcPshrfCLxEo7KerzcI2j9Ce8x3XG19z2g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(70206006)(70586007)(36756003)(47076005)(2906002)(426003)(336012)(186003)(2616005)(1076003)(26005)(4326008)(82310400005)(6666004)(8676002)(83380400001)(15650500001)(7696005)(81166007)(316002)(5660300002)(6916009)(44832011)(54906003)(508600001)(86362001)(8936002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:23.2521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b7b541f-472f-40cb-f96b-08da3c852877 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2512 In previous code, Xen was using KERN_WARNING for log message when Xen found a node without memory. Xen will print this warning message, and said that this may be an BIOS Bug or mis-configured hardware. But actually, this warning is bogus, because in an NUMA setting, nodes can only have processors, and with 0 bytes memory. So it is unreasonable to warn about BIOS or hardware corruption based on the detection of node with 0 bytes memory. So in this patch, we remove the warning messages, but just keep an info message to info users that there is one or more nodes with 0 bytes memory in the system. Issue-Id: SCM-2240 Change-Id: I922a5f17e8d7e9d250a70eb3f703dabe4698027a Signed-off-by: Wei Chen Reviewed-by: Jan Beulich --- v3 -> v4: 1. Remove full stop and use lower-case for node. 2. Add Rb. v2 -> v3: new commit. --- xen/arch/x86/srat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index a831df7648..5bd6279920 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -562,8 +562,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) uint64_t size = nodes[i].end - nodes[i].start; if ( size == 0 ) - printk(KERN_WARNING "SRAT: Node %u has no memory. " - "BIOS Bug or mis-configured hardware?\n", i); + printk(KERN_INFO "SRAT: node %u has no memory\n", i); setup_node_bootmem(i, nodes[i].start, nodes[i].end); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:26:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:26:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335369.559592 (Exim 4.92) (envelope-from ) id 1nt1WU-0002a3-A1; Mon, 23 May 2022 06:26:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335369.559592; Mon, 23 May 2022 06:26:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WU-0002YR-1S; Mon, 23 May 2022 06:26:34 +0000 Received: by outflank-mailman (input) for mailman id 335369; Mon, 23 May 2022 06:26:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1WS-0008Q2-E0 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:26:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1a::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48c0547f-da61-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 08:26:31 +0200 (CEST) Received: from AS9PR06CA0213.eurprd06.prod.outlook.com (2603:10a6:20b:45e::12) by VI1PR08MB4144.eurprd08.prod.outlook.com (2603:10a6:803:e2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 06:26:27 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::b1) by AS9PR06CA0213.outlook.office365.com (2603:10a6:20b:45e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Mon, 23 May 2022 06:26:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:26 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 23 May 2022 06:26:26 +0000 Received: from a5a1382e5d4a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 153250D8-CC9C-45D7-970F-CCD81DEDCAA7.1; Mon, 23 May 2022 06:26:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a5a1382e5d4a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 06:26:19 +0000 Received: from DB3PR08CA0019.eurprd08.prod.outlook.com (2603:10a6:8::32) by DB8PR08MB5193.eurprd08.prod.outlook.com (2603:10a6:10:e6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Mon, 23 May 2022 06:26:11 +0000 Received: from DBAEUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::a2) by DB3PR08CA0019.outlook.office365.com (2603:10a6:8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Mon, 23 May 2022 06:26:11 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT052.mail.protection.outlook.com (100.127.142.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 06:26:10 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 23 May 2022 06:26:10 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.27 via Frontend Transport; Mon, 23 May 2022 06:26:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48c0547f-da61-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=W6U93C3iqDqKgWwNjzaPS7oz/qfdWlCdm36MVBXIRIK9DPf/RZi1PYJ8Wq1uVOOVfh2v27dAz55hTErbnBG9RYP6Mw8iiLqPLGOpbN82KMWnmz9TDSi1lw327/FjIkh/fjh7fxfNPkKgcsrFy0mChxXQl3lg5WNOLf+5509R1PprK09x1ZD7GQ2LXpo/f6T85OKO3Uge27VNtVbO7JCvBAv/gcehgOIb45fZDJ82wyMsdCO0zrdX2v7iaJ+Cj3CppSt07VhJADrae7x60LOUbzhREueTOf9i1+5K2j3tS00SDXlTH2fcET1uuxuwahKaw6IjazM6IdYTNfbFFt+f3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+0l6aEvx/DTIL60yMCTuk7IatOAWAYvcrFcxcdYsBY=; b=dJTN3zW08Kze9SrSFUe/zLkwO/gYpFgOXQeLHV8BP5Q9ejIs4Eoi9VOk5Sofj/BM1cZ/7MLLham2l6PbzPI227JQFe3CKB2Mid4R+NLNUSMlG6H5lkqgEk1PT1MDUOsFrmzjM0hN1EO2u+FTXd2GQ+MmJymhmrMoO3xh8Xs+E45qR5kcVykqJSaFLUg35Q/FsWx0nyDbiSNmG/MlwarENlW8yKATPjrCu+6IZRX761H/T5gtC092qnyRYZLiWUiaAtjudhRglWsjSBj5oKZPAwDNkP2koRFat4AG8dU+Qbc28malPeD3MFMrlZbOiVYqzQM4O7Q8XPeRNnjB+PPYwA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+0l6aEvx/DTIL60yMCTuk7IatOAWAYvcrFcxcdYsBY=; b=Fqrh7eOvFNqtq9REfZ6ZU47LvfGm75/1YRCS1qti3uQGoQUD8sFOoOk691y8dh3ZTAUooOHuULkAoySUzOXPn3oxh50beQrKwxVhpJNM8VWKaeIlOwiRdvMaVXPx7WDqF9LQoIHbTUKZHX0fQKUWht8pDorFaBSmItaJ5yAIS9g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 34b6f2de4d519696 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFmI2/1rpqQLiZs7vkmXz5FNmlvBsh7XI1cpACZFKLfpTI00M0+3/FbUwq0WGlRUVNDEsQB9FlVkn8nXvhwfKUZ80VbM6d2VaXrML46DckOZbgG5rZbGQrLzl2Gxrrb6g+ZU/pW+SqSoSm2STjI0e0u++eOs3f0mBbQqzT281KaDB7Rn7WAlQ1Nf9pfwE77emClK5mL4ERBhrorRd+K8UsKBspvoUGseZqLCROd3nXVohvCyhslj18VCHaBZBBaDDl4GKP3BRnFH/kLLeUqoApotElESrFEBUabsV3ec0aJy6SDZ2GfETA0Uy0MuKgDQfECRwiIRCQHeUowKjIARJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+0l6aEvx/DTIL60yMCTuk7IatOAWAYvcrFcxcdYsBY=; b=Tql3jfskXYQ8KGYCpvdi8vDJd+W8mboMkY4DM34UlkfxFIsu2gwABncl1CcJtfUMFM2J2Xhm95n3wsYRSu4YrhbiYuCxWE9PFMXw/dDNs3YLYkL6kCraYCpmCZw841W3Kf0Dmy0Yl4mW7el9EzDp1Zswst/LAnK2/YZNwJhYLJtbk/qHedha22DzCKGtKJGYYkxuq6m8kLBywzpmHtXOJHGlEbIcaENuIlvKdi7SxcuBehVEFFyBO3ZdOB54X2knkItt2DbKdvFw4dcaoeptDKqwf/50rhQA6amU6qs12NxRUTghn/PJjV41uMxHx5pOzaC4RcEBNWRWwDGyD3bUGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+0l6aEvx/DTIL60yMCTuk7IatOAWAYvcrFcxcdYsBY=; b=Fqrh7eOvFNqtq9REfZ6ZU47LvfGm75/1YRCS1qti3uQGoQUD8sFOoOk691y8dh3ZTAUooOHuULkAoySUzOXPn3oxh50beQrKwxVhpJNM8VWKaeIlOwiRdvMaVXPx7WDqF9LQoIHbTUKZHX0fQKUWht8pDorFaBSmItaJ5yAIS9g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jiamei Xie Subject: [PATCH v4 7/8] xen/x86: add detection of memory interleaves for different nodes Date: Mon, 23 May 2022 14:25:24 +0800 Message-ID: <20220523062525.2504290-8-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220523062525.2504290-1-wei.chen@arm.com> References: <20220523062525.2504290-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 61b5c1e2-c789-4f87-f12b-08da3c852a5a X-MS-TrafficTypeDiagnostic: DB8PR08MB5193:EE_|AM5EUR03FT030:EE_|VI1PR08MB4144:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EfCIdYz6JRxum8gInCmgE0/QSQ685/890se25ATAhJR1rEsMcG86Q14VjE+5HeJl+ESgXTk/D6N0/9mZafIoYFwvlR9vM83n+eABnnQfBtT5G/HwENs7IFCb97ihp4S4qeJ4ZopDy3AlSxcJUxSO6D1FQtssvu5u4s1HBGKIstf3uXBISctQxcM+ZTPkO5BZDIPI2tYc2jeJHlRpqul1AJvpFDnOnTYCXR1u5mde8MlGqAe55pNnEDxCeMF7XJlFwDfQ2G5g0cklA8243lhymkFzCUZbYyS+m5Ihjr/swqrW1YgvPsg7g6wZCaZnPjccdEI3M7Yl5JDEY1e3WR6PqGox9rRxb/VRG3zStW8XgAOeXcekEpHxOdrDGA1APiQ7VchRb9sI8cBsU2SvtWxWQqJmpNjMK7oZVM7iinSR4bm/Am3GJi1vAIQH9GZZZnAJ1TENYQg15CgM7FmgOH3Mz00qIJlLksy497/wpjFcs3fZz6HqC7YD7PO34yJjvMNJguWH82ENm8qJNTbWXDCmzfiQDnVkFANljC24iru7hC3uHUcJsxB1G7xoK5aTqkQ335QuXDZJp18pdWDNJO5V8j1YKiGUk341HNRkA6070wBweiUbUFJiNb+3GihbNNv5Zqi+pCiwtyzEAsRDYFYdKOXNvEKU6G5ssAaxdPRQ5teQen8AF61WjMBQHSlxEzzQzuvxauG87HPhPnadcZKH8Q== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(5660300002)(36756003)(356005)(508600001)(7696005)(6666004)(54906003)(26005)(44832011)(40460700003)(81166007)(316002)(70586007)(70206006)(4326008)(8676002)(6916009)(8936002)(82310400005)(426003)(336012)(186003)(47076005)(2906002)(36860700001)(86362001)(83380400001)(2616005)(1076003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5193 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 68ea353d-2482-48a3-f06d-08da3c852117 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 81nemQxR9m2B27sh7Cp0st257eeFLIZ9upT5PMyutlvWk7RTVt3PKlrHfhTmVN0W6LElJsVGAKy7K/g/N0nEmwHyYtucsWAttjFry9f/2lGb7vbcd013d/t3LwEmSvG/uTsomYk7kv3fJFCOGyOGYHQDWSmcGvEjo0Gz0VtFf+RUTxPl88rCKF4F4m3Co2oDA6FM6umHjCj8xfSx2CUb8thwad75/mCtRuzsyyzWO7ELkDHcfK7Qx5dODW+Nx3YyrvUx8nlAk3Kzy/pmUpmi4HUoTxBtl/zQZbheHngZagbY4ZK5KHySPQYwaUhz+ZLceUU2z07B1lRgyTU+oerntQuooW6l0Xj9DPJ8m+4Hfa8o/RGTIvu5JMMx4LKgEr3UEs1y+8vxIf9gV2eBEgOFAqAWoHIFB+BsBeMut9/vVcFvjF8zgVAM+ijJCbF5kepLTzAbxb4jHp482MXy1usOiPJjCX8rSixdJQUUG+8sZ5dQFJcLLIf6r0QuzcaQotFddQnyOMrjQf1NtetI6nMGex5EE4jT6mPOQwTd3zB5Fs81PQDL7rjKu02u3hX9HVIK3pkv5KoZIsKoxIdidgJ4G9ueExFDGPJ7pYmmyJz3wsIiCWVA/oS0K6SuhWGLzwTPVwPIlbaicLYaCbBxR0fnRA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(26005)(186003)(81166007)(7696005)(47076005)(36860700001)(8936002)(426003)(6666004)(2616005)(2906002)(36756003)(1076003)(44832011)(5660300002)(336012)(316002)(82310400005)(83380400001)(4326008)(70586007)(70206006)(508600001)(86362001)(8676002)(54906003)(6916009);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:26:26.4641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61b5c1e2-c789-4f87-f12b-08da3c852a5a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4144 One NUMA node may contain several memory blocks. In current Xen code, Xen will maintain a node memory range for each node to cover all its memory blocks. But here comes the problem, in the gap of one node's two memory blocks, if there are some memory blocks don't belong to this node (remote memory blocks). This node's memory range will be expanded to cover these remote memory blocks. One node's memory range contains other nodes' memory, this is obviously not very reasonable. This means current NUMA code only can support node has no interleaved memory blocks. However, on a physical machine, the addresses of multiple nodes can be interleaved. So in this patch, we add code to detect memory interleaves of different nodes. NUMA initialization will be failed and error messages will be printed when Xen detect such hardware configuration. Change-Id: Ia7ff9a9128ecbe3eb4dddd1307ae8fbe65575ccf Issue-Id: SCM-2240 Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v3 -> v4: 1. Drop "ERR" prefix for enumeration, and remove init value. 2. Use "switch case" for enumeration, and add "default:" 3. Use "PXM" in log messages. 4. Use unsigned int for node memory block id. 5. Fix some code-style comments. 6. Use "nd->end" in node range expansion check. v2 -> v3: 1. Merge the check code from a separate function to conflicting_memblks. This will reduce the loop times of node memory blocks. 2. Use an enumeration to indicate conflict check status. 3. Use a pointer to get conflict memory block id. v1 -> v2: 1. Update the description to say we're after is no memory interleaves of different nodes. 2. Only update node range when it passes the interleave check. 3. Don't use full upper-case for "node". --- xen/arch/x86/srat.c | 132 +++++++++++++++++++++++++++++++++----------- 1 file changed, 101 insertions(+), 31 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 8ffe43bdfe..a831df7648 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -42,6 +42,12 @@ static struct node node_memblk_range[NR_NODE_MEMBLKS]; static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -119,20 +125,45 @@ int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) return 0; } -static __init int conflicting_memblks(paddr_t start, paddr_t end) +static +enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, + paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) { - int i; + unsigned int i; + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ for (i = 0; i < num_node_memblks; i++) { struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ if (nd->start == nd->end) continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. + */ if (nd->end > start && nd->start < end) - return i; + return OVERLAP; if (nd->end == end && nd->start == start) - return i; + return OVERLAP; + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if (nid != memblk_nodeid[i] && + (nd_start < nd->start && nd->end < nd_end)) + return INTERLEAVE; } - return -1; + + return NO_CONFLICT; } static __init void cutoff_node(int i, paddr_t start, paddr_t end) @@ -275,10 +306,13 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { + enum conflicts status; + struct node *nd; + paddr_t nd_start, nd_end; paddr_t start, end; unsigned pxm; nodeid_t node; - int i; + unsigned int i; if (srat_disabled()) return; @@ -310,42 +344,78 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) bad_srat(); return; } + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expandsion. + */ + nd_start = start; + nd_end = end; + nd = &nodes[node]; + if (nd->start != nd->end) { + if (nd_start > nd->start) + nd_start = nd->start; + + if (nd_end < nd->end) + nd_end = nd->end; + } + /* It is fine to add this area to the nodes data it will be used later*/ - i = conflicting_memblks(start, end); - if (i < 0) - /* everything fine */; - else if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, - node_memblk_range[i].start, node_memblk_range[i].end); - if (mismatch) { + status = conflicting_memblks(node, start, end, nd_start, nd_end, &i); + switch(status) + { + case OVERLAP: + { + if (memblk_nodeid[i] == node) { + bool mismatch = !(ma->flags & + ACPI_SRAT_MEM_HOT_PLUGGABLE) != + !test_bit(i, memblk_hotplug); + + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself (%"PRIpaddr"-%"PRIpaddr")\n", + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, + end, node_memblk_range[i].start, + node_memblk_range[i].end); + if (mismatch) { + bad_srat(); + return; + } + break; + } else { + printk(KERN_ERR + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", + pxm, start, end, node_to_pxm(memblk_nodeid[i]), + node_memblk_range[i].start, + node_memblk_range[i].end); bad_srat(); return; } - } else { + } + + case INTERLEAVE: + { printk(KERN_ERR - "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%"PRIpaddr"-%"PRIpaddr")\n", - pxm, start, end, node_to_pxm(memblk_nodeid[i]), + "SRAT： PXM %u: (%"PRIpaddr"-%"PRIpaddr") interleaves with PXM %u memblk (%"PRIpaddr"-%"PRIpaddr")\n", + node, nd_start, nd_end, node_to_pxm(memblk_nodeid[i]), node_memblk_range[i].start, node_memblk_range[i].end); bad_srat(); return; } - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - struct node *nd = &nodes[node]; - if (!node_test_and_set(node, memory_nodes_parsed)) { - nd->start = start; - nd->end = end; - } else { - if (start < nd->start) - nd->start = start; - if (nd->end < end) - nd->end = end; - } + default: + break; + } + + if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; } + printk(KERN_INFO "SRAT: Node %u PXM %u %"PRIpaddr"-%"PRIpaddr"%s\n", node, pxm, start, end, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 06:30:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335381.559602 (Exim 4.92) (envelope-from ) id 1nt1af-0005e4-R0; Mon, 23 May 2022 06:30:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335381.559602; Mon, 23 May 2022 06:30:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1af-0005dw-NU; Mon, 23 May 2022 06:30:53 +0000 Received: by outflank-mailman (input) for mailman id 335381; Mon, 23 May 2022 06:30:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1ae-0005dq-8U for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:30:53 +0000 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0a41347-da61-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:30:48 +0200 (CEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4L66sG0b1tz4xD8; Mon, 23 May 2022 16:30:41 +1000 (AEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0a41347-da61-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1653287444; bh=xgg1hS9BSFr5BuV1JPPaBTBshDJNljlVHdKXJO5tQ78=; h=Date:From:To:Cc:Subject:From; b=sYnPmLi8oYAqcYCjY6GHNChs5KYvus+P0r4Ha+hu2Qpo4kVIGVj3bhfLVwJn2ECT9 PItx4IuEgzjyncJt2ukJrkkvkgo/Fv1BP4r3Sg01O985QC2dDBSVqergEj1J6aeBmX ixUmaX8DtshIG85goiSPBdK6QLcd+4Upjjm8mwLFnhm21hocfXOfWy3xy9rOrqLOqU ah63LfYwt5wNL9w1tP47lwxGiCsdZJRhodfw3bW4nWXtmpm5os/6fD7q7RffpbUVdE GDUC0EEl/UfPdyuTfLneQT6/f8y+tw87u/TO1lbIuDfaV7ECB1+RjP5meIVBOmXYfT GTl8/z/PRXEbg== Date: Mon, 23 May 2022 16:30:40 +1000 From: Stephen Rothwell To: Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , "Rafael J. Wysocki" Cc: Xen Devel , Dmitry Osipenko , Linux Kernel Mailing List , Linux Next Mailing List , Maximilian Heyne , "Rafael J. Wysocki" Subject: linux-next: manual merge of the xen-tip tree with the pm tree Message-ID: <20220523163040.6064b190@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/LHaDpV_gDAUXQ2VrDx=4El="; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/LHaDpV_gDAUXQ2VrDx=4El= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, Today's linux-next merge of the xen-tip tree got a conflict in: arch/x86/xen/enlighten_pv.c between commit: f089ab674cea ("xen/x86: Use do_kernel_power_off()") from the pm tree and commit: 1591a65f55bc ("x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid") from the xen-tip tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. --=20 Cheers, Stephen Rothwell diff --cc arch/x86/xen/enlighten_pv.c index af1f6e886225,ca85d1409917..000000000000 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@@ -30,8 -30,6 +30,7 @@@ #include #include #include - #include +#include =20 #include #include --Sig_/LHaDpV_gDAUXQ2VrDx=4El= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmKLKhAACgkQAVBC80lX 0GwP1QgAm4zlmI0lzfyk52XGg8pKpPdKKocChsJEtTH1iwbUUM+owKfGB6L7OMlY bRZFmQUgIy581cwpFPqYhi1vOcTkOX3E6npA1fhBdamYar7tCqu4xwq2f1A0rTjZ Zb9+lcJZHYcp5nApkqC0Us7UICIrvI0ylGXF3okKtscKsoMLPT1jfqrUGo8UIjyA l2jPDtIFntlk5bKhcjH4Bk1igoNW/hX97iPzsgj9KTrtVwQ2ISq5PjptZToaiaS0 JCE4UGrHdiXjmzaDo7saPc5lEs9cUpvLm1TV+9VHYDfs3/UJvS29BTlCHra02K6e j3xKHiad9zTxderG5aSSt88c1YZ3AA== =BbA2 -----END PGP SIGNATURE----- --Sig_/LHaDpV_gDAUXQ2VrDx=4El=-- From xen-devel-bounces@lists.xenproject.org Mon May 23 06:32:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335443.559614 (Exim 4.92) (envelope-from ) id 1nt1c2-0006I9-4O; Mon, 23 May 2022 06:32:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335443.559614; Mon, 23 May 2022 06:32:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1c2-0006I2-1W; Mon, 23 May 2022 06:32:18 +0000 Received: by outflank-mailman (input) for mailman id 335443; Mon, 23 May 2022 06:32:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1c0-0006Hq-W8; Mon, 23 May 2022 06:32:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1c0-0000RS-TU; Mon, 23 May 2022 06:32:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1c0-0002eA-IP; Mon, 23 May 2022 06:32:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt1c0-0000FD-Hx; Mon, 23 May 2022 06:32:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4+J5dhhuRAXOyHnkb1WOMZnYF56Qkwa2bKknRb2UqiQ=; b=p9Aw6Wht2/77ku5gWArx23KW8O lIIjIopQ6zHeZyOSKkTuBNoTigFEnAhHZF4X++ipq4gWCy75cx3r4JiHcWbP4lhuukjAiCCROT7Qr xgA7AlXM5um1xkVCmTBYIqlG7pY7sbPOpbrKtR2y9Mo6Uw3SVFpOLQ84TISEkexYaV6c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170692: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 06:32:16 +0000 flight 170692 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170692/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1180 attempts Testing same since 170593 2022-05-20 06:42:41 Z 2 days 68 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 06:37:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:37:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335454.559625 (Exim 4.92) (envelope-from ) id 1nt1gg-00072S-Re; Mon, 23 May 2022 06:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335454.559625; Mon, 23 May 2022 06:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1gg-00072L-Ol; Mon, 23 May 2022 06:37:06 +0000 Received: by outflank-mailman (input) for mailman id 335454; Mon, 23 May 2022 06:37:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1gf-000729-F9; Mon, 23 May 2022 06:37:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1gf-0000Wn-DP; Mon, 23 May 2022 06:37:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1ge-0002xJ-U1; Mon, 23 May 2022 06:37:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt1ge-0005EX-TV; Mon, 23 May 2022 06:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=R+VNoGEUh1YFTAgidGw+i8ko5hYkSyA4HjzYZsExmLs=; b=jkKsJ6vur7zJzROrxsGZgTZSZK JTdPMe4UhjPshXeUyhQSJCBTuG3gchKWjwf4d5OxqJnAT3TKv2awYjTDTT5ZLJ7hsBGaS/wcMC9k6 Z+KkAV/urw7z45EuQzLHF1+NkNZLajTSVUJVIXlDUGhBWqmMAcQslKqxn8w8NZp3YUCs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170684: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b0986a3613c92f4ec1bdc7f60ec66fea135991f X-Osstest-Versions-That: linux=978df3e158467ae09be635b27e9e1eb990704e0b From: osstest service owner Date: Mon, 23 May 2022 06:37:04 +0000 flight 170684 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170684/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170676 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170676 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170676 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170676 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170676 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170676 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170676 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170676 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 4b0986a3613c92f4ec1bdc7f60ec66fea135991f baseline version: linux 978df3e158467ae09be635b27e9e1eb990704e0b Last test of basis 170676 2022-05-22 18:09:49 Z 0 days Testing same since 170684 2022-05-23 00:41:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Howells kafs-testing+fedora34_64checkkafs-build-496@auristor.com Linus Torvalds Markus Suvanto jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 978df3e15846..4b0986a3613c 4b0986a3613c92f4ec1bdc7f60ec66fea135991f -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon May 23 06:49:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 06:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335468.559636 (Exim 4.92) (envelope-from ) id 1nt1sl-00009L-3W; Mon, 23 May 2022 06:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335468.559636; Mon, 23 May 2022 06:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1sl-00009E-0K; Mon, 23 May 2022 06:49:35 +0000 Received: by outflank-mailman (input) for mailman id 335468; Mon, 23 May 2022 06:49:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt1sj-000098-Ic for xen-devel@lists.xenproject.org; Mon, 23 May 2022 06:49:33 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fb82508-da64-11ec-837e-e5687231ffcc; Mon, 23 May 2022 08:49:31 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-5-oYaixDHVPCOZKz92bgrr8g-1; Mon, 23 May 2022 08:49:29 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7437.eurprd04.prod.outlook.com (2603:10a6:800:1b3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 06:49:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 06:49:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fb82508-da64-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653288572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N9tiIAFTvgFfwxlos58MasgrWlittgNXSxEu/+vRbSQ=; b=euEDj/RVvhOhqLn4A5m9HK9onQ2Idx14jUPefBpVXCPrjTezTqF1KvsrwV0s7LIJI0QXh0 Ip4ESS2wiLVqA6ivU9Tr3eySPjEN3kf4BrT1bwFJM02x2qbW1hwyadvbpBAG88aXckSJDb CQiRi8M/+kSSqU0gtsX/cjfLnuPM7/Y= X-MC-Unique: oYaixDHVPCOZKz92bgrr8g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cwo68RuqI+QdOg4OMIuxWfAaT8PbeczpX33r84Cpmn2VRrtMLgDIm2q21hbsq4blNG/VZPch9VhXP3K4XFhEhO+r98D6JonAu1h7SF/Ao0tztKXSqIiJs1tAImtxKkP7nnSZzvEg9WW2xHCaIH8A19w3MO+LwM7eEMgPEcJTUqUEZt/SHo/rsiZ7OqTGiOacMBNMSrdNpMDOm5LPyII3SeQL/sLL7MA2JmpZ1WYfEWlbcoo3fZuD1L2j3rXXIQK7Fl7aZnQiQfifP64fHX50QYcO3b1RUToio4T3LAp5ugEnUL9h5326xc3Xg1+0evtJVmxWUjEFXTc260ZWAhdzmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v9YqcDAGrCEL2/2iezwsvYWtnO/JBEtf1x37ZuwsURw=; b=bYyLBm61+SpKv56VGhZm1p6S94F2TeewLAYEmMZD1pQOlDPydYtZo5bw/iCsJT6MyYKdFuNny9FcX5HY35A1qQhzlgXaAnYphu2MPya3pEbrSX0rbu3yOCRkvAMvAyfFkehAyHr2XnI0UbToyrL8CHY6JLSUP+e2FRuGK2XrxZ8TFYQ+Ddjo3v2gt9+99euO7wPp4vEhPFvIyS1SoJp+NW3LyUsYKib8IqpULuel8VviTGc6SAA/JLaLis8jOikrz2iIVXuXy19l8OzLeiJcEgMKU1p8r6N/DuhfHKmQZ5qstRiLvWt+cHqYfCpgycsafZr+zmm7boh2ZgWN8oTLRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 23 May 2022 08:49:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <9d073a05-0c7d-4989-7a38-93cd5b01d071@suse.com> <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:20b:451::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba127e7d-377e-4816-77b1-08da3c886209 X-MS-TrafficTypeDiagnostic: VE1PR04MB7437:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: deZcuzQw2YnWY7Y8H7ptTY7LAXtEKDV/3LR5PW3euW3Q3iJZ010Lkjj1PheRvAVAXRE+Z6vtWvRWkg6iY1k/o72SIt9SJxN3H345v7SdoRlx5VB1VywY+Up6jDJA2146BvyqebA0wBCwlnpKZl/goAwTcDnoZBJCiYqzePFCs+KveDy7G590D4/7zv3ekPoQEcQpo2a4lUiCD6qQdv2rN0+VEAqrB9JB6vEv6HYWJrfv+3eKx6AFhaDfSK2QBFJIUKv4hdOkTauCrIeCWIsIh2bcnnH5RnGKkluDOiFf8uLK+L57kQ3WmGDx6nL8Ep7T2vpt4KCx/Q+XASi32EJVphhGeU9FTz1cttmHZ0kDDgTQcAwbDaDD1zRLaFR/PvlW1BYPNt/+02BdnY6atFMnViTlK2faMACaiXphQQ5cDVHw0ywCXzQcv8hOH6zLdQ6aAhzUe9mklFFaONyBbgnV/ClREJ4aJIZnCF0200lwkCW8C5bPTkNBdUbQD1Xvt5UtPAFcQmgba+qCloAKEwdv+EpGRt4Mr2SYvoOLLz3oFvs5PiCDjXl0ZVHke/K7A7J22fFsGZGc0l+M1eZqwRFZt/hOUz3O54ZWvhSKFqwApYvP6N1UKsvnst5ywl+ahJfMH2jLL6vTsV1ZRMRuz/TBpqEd7/cMR5IV3bpuNmls+3o3r+XDrZ9xtUXJXr3/88NQ9gI4Jlz4YfHanNcd2jL3xj/4IBA6jt/jQLy6bl5O6/A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6506007)(54906003)(6916009)(508600001)(6486002)(2616005)(36756003)(31686004)(83380400001)(316002)(26005)(86362001)(31696002)(38100700002)(5660300002)(66556008)(8676002)(66946007)(66476007)(53546011)(6512007)(8936002)(4326008)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6asYcP0lwaOiJNm13G1BHHUPsVXlNuzaLR1JTqlsmzStnBrJUeDkT8Yx2aHd?= =?us-ascii?Q?+m9A2y2LPJHWwtUMwhldr/zDs78rzPSJnGLnMogwy3BU/IlDW/60DPKrqre9?= =?us-ascii?Q?K+38HoKXzySkAD4Icd4HAcHlr8yuWFjhcDyoMnoMqHfjV9G5CG0gZ7TXrLjB?= =?us-ascii?Q?P/KrloXX1uLvtRWDnvEguKoiIZYN5oO0ZQS/SZOBs1kCsZjazD14vYTR1TWS?= =?us-ascii?Q?npgvXfFc4suxOgxLpdpgciobrXm/IYaewecOgkD7f2aiE1bV2NuGQMyES459?= =?us-ascii?Q?5P5I8PZprKho/HD95+CcHaR8ZcXuUNk1WElsJi93hFHVgei6bytirmTYQgaM?= =?us-ascii?Q?h51uM+B9BL1rbg/RnUkfvRiG5MIXJZzjsIgJGlhl8DRO1sCuRxgltGbq+7LM?= =?us-ascii?Q?e/LmclAiVuAGDX5FiGtkZdW2l9nBAIK5r7EZqRLBvaHp5X/P1z7prMIGWY7G?= =?us-ascii?Q?8qR6tcV9vmIEIci2QpdGYCSZH+4dyWyOPuZ+cTqMCX4cKGfAWSysdCZ8jPOF?= =?us-ascii?Q?0im3KKhNF0RyG2/nxJpp/yy08zJ5cr3NymNF6d6aG22yX3IkHMENInKo4lkM?= =?us-ascii?Q?IOBThuEfa+nTLRNiiV155Mm7YdGeySQ+vSUAYndQN703AFfc84YyyoiPGxQK?= =?us-ascii?Q?1y6bB1T/4yTrgMuUbT+ugPIVY3N7uRW8j7ZpAdEEMW19nj0Ie49Y+87SjM5C?= =?us-ascii?Q?oHZntqfIj49IsEPFCBaPRvgIovSRBo7g8CeEnd6FKeJwF/Ux1g4g++wmXdbN?= =?us-ascii?Q?Q5OkAb/YnnvZxu6AjdH4tNSrMVyIyH2jzgXnV19Zh6T5SGNUvumOqB4EO3X8?= =?us-ascii?Q?mRxNoyDllelUuuJczj1MngL5MdRiXT6Sf5ej5tMS17JWhMfSSRTym6wTl0PG?= =?us-ascii?Q?w2n9Y3M18ptMD0RlBTp3dGXcsyUwbWYcztVlbyNhN4BKFk+pYZ7oc4GGXAEz?= =?us-ascii?Q?g6L/IK4j/Wkt8Onb7p6tT+hwQu6WzpLlULHhzlwcCQCAL2PFwg4J3E790BhS?= =?us-ascii?Q?VyXXGaWGBYHrd9ArI697oLzs2FTfLvVhv5PkIe3mlDFjj9OcuE/uPGOQDOYk?= =?us-ascii?Q?G+3u4ODv2DJSKmP14Tn3XvdrPCUwRFJdGVnVWJzAXlTwmhPzSit8lGvJi96/?= =?us-ascii?Q?BEa7Vh50nVKwEYhjtAKL8MULWzxNx/vPiwtF/zOYq9VmqM/cyRcFcYx10b6T?= =?us-ascii?Q?G3FyNMkBcIXMDiIc5pijKzoF6ohoHYw+HTwQQTFyo4o2YVdK4ISPc+psz7dj?= =?us-ascii?Q?izbF9dr54Ze055Zf5qtbtjL0WHYRUojW+IJY8yrPNyJoHtFdUdZA0Xf621Fi?= =?us-ascii?Q?o24jkg2OfFJ24unzUyjlDFFMIXwCbEIQ9h+gGuyNIGz0HeFMejXP/Rdelc8d?= =?us-ascii?Q?WRT3FfPlJ1UzyWXFcyM6gLoExn1BAUpf389FUh0ji7BRxvtS8wm8IVLlULho?= =?us-ascii?Q?AoSefbGkbrX8YshhUL1mgXII/YxuCc5W9CYWhDUsfokmLcjrOW1xFf3mK718?= =?us-ascii?Q?zSep9go9oc1x02WXGCnWAcg+2z+YDOwwpjMt1NcGDeAGVz//418oy7EOxXqr?= =?us-ascii?Q?xWFX7E7rdkwgLgAju43q6D36PU04sFpCPZfHeNDejumiyf9GlaEha5p3FNbP?= =?us-ascii?Q?OXs8I1pqmpB2tSIakpWNCxky47SGEC4HdSGHZ0RAdCg1cZ7oqON18X6Gtm0Y?= =?us-ascii?Q?98IxvV0QP7R0tHikshMwATN6AivwNJkM32T6UgFcuk+uFxdKMr/6iGgwvbE1?= =?us-ascii?Q?krDzIuh/wQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba127e7d-377e-4816-77b1-08da3c886209 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 06:49:28.5915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VCZ5rxpR3x4lAcaS70GNwXSa6tw7ztc9g3CBTy/hw3PMmcCarns7yhQjMSPRv5QxO8Aj8PS/D7Iz7Oc5GmWhpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7437 On 20.05.2022 16:38, Roger Pau Monn=C3=A9 wrote: > On Fri, May 20, 2022 at 04:28:14PM +0200, Roger Pau Monn=C3=A9 wrote: >> On Fri, May 20, 2022 at 02:36:02PM +0200, Jan Beulich wrote: >>> On 20.05.2022 14:22, Roger Pau Monn=C3=A9 wrote: >>>> On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: >>>>> On 20.05.2022 13:11, Jan Beulich wrote: >>>>>> On 20.05.2022 12:47, Roger Pau Monn=C3=A9 wrote: >>>>>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: >>>>>>>> On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: >>>>>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >>>>>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c >>>>>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c >>>>>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >>>>>>>>>> =20 >>>>>>>>>> while ( nr_ptes-- ) >>>>>>>>>> { >>>>>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >>>>>>>>>> + ASSERT(!pde->next_level); >>>>>>>>>> + ASSERT(!pde->u); >>>>>>>>>> + >>>>>>>>>> + if ( pde > table ) >>>>>>>>>> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - ta= ble)); >>>>>>>>>> + else >>>>>>>>>> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >>>>>>>>> >>>>>>>>> I think PAGETABLE_ORDER would be clearer here. >>>>>>>> >>>>>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used = anywhere >>>>>>>> in IOMMU code afaics. >>>>>>> >>>>>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not >>>>>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use i= n >>>>>>> IOMMU code but not PAGETABLE_ORDER. >>>>>> >>>>>> Hmm, yes and no. But for consistency with other IOMMU code I may wan= t >>>>>> to switch to PAGE_SHIFT_4K. >>>>> >>>>> Except that, with the plan to re-use pt_update_contig_markers() for C= PU- >>>>> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. >>>> >>>> Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? >>> >>> pt_update_contig_markers() isn't IOMMU code; since I've said I'd switch >>> to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I coul= d >>> at the same time start using PAGETABLE_ORDER there. >> >> I've got confused by the double reply and read it as if you where >> going to stick to using PAGE_SHIFT everywhere as proposed originally. >> >>> What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and >>> LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correct/ >>> consistent, ... >>> >>>> IMO it makes the code quite easier to understand. >>> >>> ... or in fact helping readability. >> >> Looking at pt_update_contig_markers() we hardcode CONTIG_LEVEL_SHIFT >> to 9 there, which means all users must have a page table order of 9. >> >> It seems to me we are just making things more complicated than >> necessary by trying to avoid dependencies between CPU and IOMMU >> page-table sizes and definitions, when the underlying mechanism to set >> ->ign0 has those assumptions baked in. >> >> Would it help if you introduced a PAGE_TABLE_ORDER in page-defs.h? >=20 > Sorry, should be PAGE_TABLE_ORDER_4K. Oh, good that I looked here before replying to the earlier mail: I'm afraid I view PAGE_TABLE_ORDER_4K as not very useful. From an abstract POV, what is the base unit meant to be that the order is is based upon? PAGE_SHIFT? Or PAGE_SHIFT_4K? I think such an ambiguity is going to remain even if we very clearly spelled out what we mean things to be, as one would always need to go back to that comment to check which of the two possible ways it is. Furthermore I'm not convinced PAGETABLE_ORDER is really meant to be associated with a particular page size anyway: PAGE_TABLE_ORDER_2M imo makes no sense at all. And page-defs.h is not supposed to express any platform properties anyway, it's merely an accumulation of (believed) useful constants. Hence the only thing which I might see as a (remote) option is IOMMU_PAGE_TABLE_ORDER (for platforms where all IOMMU variants have all page table levels using identical sizes, which isn't a given, but which would hold for x86 and hence for the purpose here). Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 07:01:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335477.559646 (Exim 4.92) (envelope-from ) id 1nt23y-0002Xp-AF; Mon, 23 May 2022 07:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335477.559646; Mon, 23 May 2022 07:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt23y-0002Xi-7E; Mon, 23 May 2022 07:01:10 +0000 Received: by outflank-mailman (input) for mailman id 335477; Mon, 23 May 2022 07:01:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt23x-0002Xc-8W for xen-devel@lists.xenproject.org; Mon, 23 May 2022 07:01:09 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1e58dca4-da66-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 09:01:07 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCBF5139F; Mon, 23 May 2022 00:01:06 -0700 (PDT) Received: from [10.57.7.84] (unknown [10.57.7.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C90A3F66F; Mon, 23 May 2022 00:01:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e58dca4-da66-11ec-bd2c-47488cf2e6aa Message-ID: Date: Mon, 23 May 2022 09:00:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini References: <20220522165900.83104-1-julien@xen.org> From: Michal Orzel In-Reply-To: <20220522165900.83104-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 22.05.2022 18:59, Julien Grall wrote: > From: Julien Grall > > xsm_deasign_dtdevice() will indicate whether the caller is allowed s/deasign/deassign/ > to issue the operation. So the return value has to be checked. > > Spotted by clang static analyzer. > > Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") > Signed-off-by: Julien Grall Apart from that: Reviewed-by: Michal Orzel From xen-devel-bounces@lists.xenproject.org Mon May 23 07:02:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:02:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335486.559658 (Exim 4.92) (envelope-from ) id 1nt24t-00035N-Ll; Mon, 23 May 2022 07:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335486.559658; Mon, 23 May 2022 07:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt24t-00035E-Hz; Mon, 23 May 2022 07:02:07 +0000 Received: by outflank-mailman (input) for mailman id 335486; Mon, 23 May 2022 07:02:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt24r-0002Xc-QP for xen-devel@lists.xenproject.org; Mon, 23 May 2022 07:02:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 407d7e34-da66-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 09:02:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 539BA21A3D; Mon, 23 May 2022 07:02:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CD1F139F5; Mon, 23 May 2022 07:02:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MkytBWwxi2LNCwAAMHmgww (envelope-from ); Mon, 23 May 2022 07:02:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 407d7e34-da66-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653289324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i/GEqblCgyyxZu7IKBZnxRexD9k9kcO3pe+RXkb4b54=; b=hQpd8fXwKc9SriPpIB7ea7ahCTmSYRwIuwUep+DnHNRC490Wu65uMqp5dnbncxJDq72nRv +d+HjeiIoMSXUew3mVOA1dnFBDielBt1NVzDNZdy7//sGzl3YvphQrjEntcbmANwswNnkp lUSo5YQVgjPLL097H7Zm96aiEU9gl9g= Message-ID: <2c448474-2a07-599a-8894-44b4e72b2055@suse.com> Date: Mon, 23 May 2022 09:02:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op Content-Language: en-US To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Andrew Cooper References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------h5V2JjR2HQqgGAUkQOkjrui3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------h5V2JjR2HQqgGAUkQOkjrui3 Content-Type: multipart/mixed; boundary="------------yTnZMuVIhnudWQTVrvx1GUZr"; protected-headers="v1" From: Juergen Gross To: Tamas K Lengyel , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Andrew Cooper Message-ID: <2c448474-2a07-599a-8894-44b4e72b2055@suse.com> Subject: Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op References: In-Reply-To: --------------yTnZMuVIhnudWQTVrvx1GUZr Content-Type: multipart/mixed; boundary="------------TnmUb4X15WuVu0XbI5prQnL0" --------------TnmUb4X15WuVu0XbI5prQnL0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDUuMjIgMTk6MTYsIFRhbWFzIEsgTGVuZ3llbCB3cm90ZToNCj4gTWFrZSB0aGUg ZG9fbWVtb3J5X29wIGZ1bmN0aW9uIGFjY2Vzc2libGUgdG8gdG9vbHMgbGlua2luZyB3aXRo IGxpYnhjLg0KPiBTaW1pbGFyIGZ1bmN0aW9ucyBhcmUgYWxyZWFkeSBhdmFpbGFibGUgZm9y IGJvdGggZG9tY3RsIGFuZCBzeXNjdGwuIEFzIHBhcnQNCj4gb2YgdGhpcyBwYXRjaCB3ZSBh bHNvIGNoYW5nZSB0aGUgaW5wdXQgJ2NtZCcgdG8gYmUgdW5zaWduZWQgaW50IHRvIGFjY3Vy YXRlbHkNCj4gcmVmbGVjdCB3aGF0IHRoZSBoeXBlcnZpc29yIGV4cGVjdHMuDQo+IA0KPiBT aWduZWQtb2ZmLWJ5OiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzLmxlbmd5ZWxAaW50ZWwuY29t Pg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoN Ckp1ZXJnZW4NCg== --------------TnmUb4X15WuVu0XbI5prQnL0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TnmUb4X15WuVu0XbI5prQnL0-- --------------yTnZMuVIhnudWQTVrvx1GUZr-- --------------h5V2JjR2HQqgGAUkQOkjrui3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKLMWsFAwAAAAAACgkQsN6d1ii/Ey9c FwgAhSoGjce81g121prQrfZ7RCV+4kYh1wsQeCCFuBRqgpxJH76GUZR2VHrigQjH7pcYinDWNXja PnQPcHAUL8Ixy1nVbh+rgwEpvzbtBK6TdqPS55EUyQta6o09ceOl9PnoTOtuEOSOy2QGxOvNAxf2 xeEVD8Oib9i4yUTnJzN+THg4Yjw1FiidY7j/qOEvSGEPZd04cgorQzG1yCnMvmUzDsXDzF4AuE2p FtNFenr6ea5HIYMeZkwjopVZoxrZEO8XmwZba8FjJ2Wp4pDISThKCpouh0oZBD7EuqBOqXLe35NR CJ3nQXJMu8B6Dx7xpNxgI6cEO0Igz3tX+r0N6Tx1Dw== =+8oa -----END PGP SIGNATURE----- --------------h5V2JjR2HQqgGAUkQOkjrui3-- From xen-devel-bounces@lists.xenproject.org Mon May 23 07:10:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:10:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335497.559669 (Exim 4.92) (envelope-from ) id 1nt2DC-0004cM-L0; Mon, 23 May 2022 07:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335497.559669; Mon, 23 May 2022 07:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2DC-0004cF-Hp; Mon, 23 May 2022 07:10:42 +0000 Received: by outflank-mailman (input) for mailman id 335497; Mon, 23 May 2022 07:10:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2DB-0004c9-Ct for xen-devel@lists.xenproject.org; Mon, 23 May 2022 07:10:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 734f350f-da67-11ec-837e-e5687231ffcc; Mon, 23 May 2022 09:10:39 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-WfdEKInJP0iq865JtY8jdA-2; Mon, 23 May 2022 09:10:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7718.eurprd04.prod.outlook.com (2603:10a6:20b:29b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 07:10:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 07:10:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 734f350f-da67-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653289840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HaxAR7rp3D5IiDtV0NxL4k3Xi5SJG6mTeMnH9eEUfD0=; b=S/zVvOWVKxCh7vQa2TVvz2jG2b9lYRmsohV4gdL2LFy/N6WRpuRda/i0GAyP5+UZzh0Yq4 SLGR03xH9elLtlHtcNL7Gewnj6vwOxwdlgVka3ufbmcnvn+i7kd5G+HCpSh97T9wkEtMTu 3p1QM7A1llALE2lm5EOZT1sRP9yk0f8= X-MC-Unique: WfdEKInJP0iq865JtY8jdA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O5I0ERoU6oVsWAS4Mvk4oGSUwFNcQgMjfi32inZKOTijyLTpgOQEtWTr3Nw0Pd+HZPilojbKudvq+V4xoYLzMF+YHHRlNiAW3Mr2sIRnMyFweTdyuwnv7YhhYwwXarklEqrIJ8gtqI2N7InJK6fzsJkDUOjAMek2jegHAPUYtzK6kJp00p5F9uvKBY3wOCjoQ+zbeYBbPmec1Lwcrz6cIOcYCq4fzksZHkCxO5z6PT62ebOO6GkXfb7l5lyDs18igXD1mp3DdOLs2J2j+UBZ4Zp4k7zR8YOb1J7JC3hGc60ZgXrq8afoohBocnXl9VW5+4RODGn2Oi4mNBeNU/KMeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HaxAR7rp3D5IiDtV0NxL4k3Xi5SJG6mTeMnH9eEUfD0=; b=fmPR3waYxv30pnSdBBecJCl/Slsww5XIl26mk7TYbwfX7DCqNCTg+S1aE6Jl2+Co1dQb44UCCJlK7OUOea88X/m40t57jaYGHbW8UfjUVMa5SNXfawsLG1rcd3kSzL+feSSS0RUEkA6A3YmyocLd9EyN5sCm1MMUCNA45vC+HyIBD6W/lK8Jb8TBDPlu1rJGhs6SowEsqB++HrN53tvmBsQMaHvIfkYnzMBic6tdEBDB3DKdqRUsjbHjpUjFb9zpPHUwQ0L92NO05rHF2eTdJDrC7JOqME8mt0ijuf5wwbgBtNg9MN1nDbKfxhBM1yv3TmO1Gzv6ltO2y84K/AMtiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4254847c-3364-d0c3-5e32-66a12a200ed2@suse.com> Date: Mon, 23 May 2022 09:10:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220523062525.2504290-1-wei.chen@arm.com> <20220523062525.2504290-2-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220523062525.2504290-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0318.eurprd06.prod.outlook.com (2603:10a6:20b:45b::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1071e5ae-6e8c-4588-6a84-08da3c8b563b X-MS-TrafficTypeDiagnostic: AS8PR04MB7718:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DEgM43E5nKurgA3y2yE2T2WYoQDDsA6UDSsrbdoOaJ1CsySXi5YkgET4dGKZ9nCHm02EnRj0jKSb6PTsNp+H6oAsOCKn2P6ghfhpBHJxTrNEUZWvCH7M0OajaOyH4keu7LIXFARDb8RF+9GobHVNBwVITSbJ6KlJPZvrQ3Pst5iddAaKsSgSj2QQmw3q+F/oxd3MpB8zUjazK7Ek/g/cj0K1vR83VZnL65rCa+quThckRw8KJEedL79TNtO9fPjq/AgKL7m+o8dh4KvlSBXsEvDz3pgqRq3pt0uQLqS4pmXPjkJa/jZRLAouwaIZz2QlOeSMGmKgFjA4/s8qkJybDVzEHnVNoQ7I71GaTBDvV3zJ6iX54u3sRgoK04pzoy58aA3Xb7pEV7hELTRLz8XPkPEDwyD/BMxWlkKis4DDVRqQmhsfTFt5DubOmkDG94dFhkpkbAOQiYTvEpB1Jpz5bQcq8PqGIzpyC/HbrDoa4RLset+eQZ15HMDmfLNNuhOAtLD9TDD49YkHKKLnCWPV/H2qIU8Hb0MkMersoHwKjFPvPjZR+CE/VVde0L+U4zSeIAiHKya5vDcrj/VOiz0eICtOXq+idCwdKTfMbKVibjBVVdQ0a/Ik5V2aSQPJDaX6Fe8t7FcFMUe8Q3lF9pX24tLeOCZiFSCaGOuH3HfnzeMtrsBl2RoXb14Pc6c1tP9FnueTn1ragDSBKqyeB4/QugZTAHnKG4tL5Wb/VXVZ5TQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(2906002)(54906003)(4326008)(66946007)(66556008)(66476007)(6916009)(8676002)(316002)(86362001)(31696002)(6486002)(2616005)(83380400001)(186003)(36756003)(26005)(5660300002)(6512007)(6506007)(53546011)(38100700002)(8936002)(7416002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZyeXA0VXNGV1RITXg2WUlHcXZ4bUFpcW1UUjVUZlJQK3M4ZFhwSGdnNGxh?= =?utf-8?B?TlNYc0oxNjd6QzYzQW9LVCtqdkVqNTBnUkMrVlN1eFloMjUxWnB1ZDBZK1pB?= =?utf-8?B?UFh6eWZFQ0VwRnpOb1dSVXRhU1BRSi9oRndmUjYrZG91VXo5Qm1BVzJCVS9s?= =?utf-8?B?ZVFBUit6Ny8rQ3Eyckpvbmp5emZSYzhyNkc5azlvMExpbEFyTzAzTk5WUzR5?= =?utf-8?B?cWdETVY5NXo1NHR5eEpCbUpyL2VoNlloS1haaDBrQy9wdXBjL1Ara2xka0Y5?= =?utf-8?B?eXFYUmtmYy9FZC9lYlR3Z05LOG5RdHV3dDRiMkhqdG5ZMDNKM3F1d0xpTVlE?= =?utf-8?B?VlErV3BCVjV2VnVQaExsV1YwOEdIQXlQYXFRRWdLTlpSTjlNdEh6TmxDOThI?= =?utf-8?B?Y3NuK1JKME11Tm9PR21kNVBnN25pcXBVYXJjd3Nld1hqWjBvNG1GdEplalZv?= =?utf-8?B?OHBQdEttVnlSZFpsR1JEbFNkdFVFUnlwN3pJR3FiNSt1NnNTSG5lRGI4L2dQ?= =?utf-8?B?cDJyR3ZRc3M1MjBLUm1ja0JKYm1BSXFZQThkMm45QmVsanFhL3hvOVBkOFdD?= =?utf-8?B?NG5aUm0yNDlJY0pYNWN6Q0pia3JVMm1zWitOQVNuejFHYy9RY1loSnNNSVhU?= =?utf-8?B?QnBoQ3ZYTXl3Q2g4bjBLZW9rbVNTNDJKWTVpdkZNS2NFYUhDM2c1RUF0QVRD?= =?utf-8?B?YlA2eGt0UlVzWWpXMUhkckZ3MjduUmxlbnVuWWh5bnJ0T3IwRkNnTVNKb0hT?= =?utf-8?B?UkZCeEJFSEFBNXIraUFEdys2U0llSXFHSTRWcTdPWnp0NmRKV0VFZ0V6b1Bn?= =?utf-8?B?Q1ZQSDRpb1FJczVNNHQxSHVrRnorSXhldjJyQVdPWkt6SFlYcFlTTHYwcy80?= =?utf-8?B?YzJ3K01ZUWhHM0tzMlVIMHBDdHVtc29wSis4VDJjVnNDY0dYYUVYeHBLNDRD?= =?utf-8?B?V2hvbkVuQU9PbC80WFBqV1FsQUoraFBmakhHOXY2dXkwbEFxUWpLRHVTaTNQ?= =?utf-8?B?WXNaL09OQ0NGTUJhN2J3MnZILzFwWHpSRFVtZHlPVGhQRC9lWFgyRklKTjNh?= =?utf-8?B?Z1FvR1BYVWVoR1FXRFpMQm5NUEdQMnVuN2Fka0JCN2M1VHJCVVdZcENoUUd4?= =?utf-8?B?aTFHYUM3SzhWY2g2ak9kUFJhb0RzTDJ4a0NmU2dVdjZKNGR5NjA3dVlRZGtK?= =?utf-8?B?SURYSFRCZVZPL3o2azYyclRjeXQ4WjNCZmJpYUNqVmhDaUJJR3lHTU5RWUFr?= =?utf-8?B?M2V6Ry9aU0lsakk3V09FNWJUajNTbnBxc0U3VmZUU05rc2FWOU80Nm9sa05w?= =?utf-8?B?ZVZ4SGU5blZpVGxYcDFxWEsyYjVyTVI3SVlSakRCSmFFUXhEWWFxeWhwQnRj?= =?utf-8?B?SE5mRFB0UUhyUTNWWlFMV1E2dkhzUkU5YXpKUVpNdlZIeVlNalQ0bE5RZUFj?= =?utf-8?B?UU1ZSVJWaG1QblRlYzNQb2J3ckx5TnYyYUIzd2dWbGhmQmUzb2k2L1owd1JW?= =?utf-8?B?Sk9lRXkwbjRjdnBZeFJIendZNGxRYmgrUGNDbGpOMEdzTUI3SHExOGVPalEr?= =?utf-8?B?SnZrN0pFYit0Mk1lcStWMnoxRU1kNUdFQVBoRnI0ZjkrRGgxTldVc3FDWjJi?= =?utf-8?B?Z0dYMDNzNVh0Q3JzS2N3SDdBZUx2RFRsRGd1RHEycXdscXh6M3A2K0drZ1VI?= =?utf-8?B?WFNleFZHdmtEUXpDdHFGQWg3blYzT1I2UlFyTnNkZFgzWERiT2dtZmVvVWpG?= =?utf-8?B?ckwzcWJvS0hQSFBsOWpKc2xrQ0tKK0M1Qm1YZmV1cW5BQWNENmZyY2M4TFFI?= =?utf-8?B?US9wQXFiUGhwYnQ2dnFsdmk1TjFWaTRTRzY4TGIrOWp2bDhGSzQrMng5M051?= =?utf-8?B?NVNPc0FyNWZQQjN1enNRaUhVSXI5NWNTQlplVjNJSGNWSHJZL1FzdWR6Smxh?= =?utf-8?B?TXJleGQvbE41dFpXNENrTnZ4eWsvVVpkQVNxakkwWkpjNkIrbGZKSVdHVGZS?= =?utf-8?B?MzhRSEcyWC9JVytnNG12WWFrSUVLeGYzMk5oQlNjcy9rbGdzUi96MmtDOCtU?= =?utf-8?B?WEx4WWM2dGhSWmxwcU5SSU9WZUFHQkFJbUtsdnRxTFlGalAxM0MybFJuaURQ?= =?utf-8?B?bEo4VFVaMzUyM0JPZ043RGJNbVVGR1czMFFMbkk4Y3I3MlhFS2NDUU4yVnVJ?= =?utf-8?B?Qkh1RWtQMm9PbW1tYURCNGRrWE1VdlpNVmtleFFvaFZFaWU0ZUZPWWJmVUtE?= =?utf-8?B?Q09zcHV6ek1KMUw5b3VTT1BMMHF6NHRacTh6bzdqdCtPNDlmWFNVKzhBTExs?= =?utf-8?B?ektpRnJoWnRWdks3eUp4amZFT0ZnRlJ2anl1MGFMZFppaUZydE5YZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1071e5ae-6e8c-4588-6a84-08da3c8b563b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 07:10:37.2920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KD8wuZY27bdtzSZENpDtQf6Fo78nCJZAQuF0u0Rj20k040g8OWWVb9skX4L5GbcmDeE2WwOBUtXcVDJtbhXm8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7718 On 23.05.2022 08:25, Wei Chen wrote: > x86 is using compiler feature testing to decide EFI build > enable or not. When EFI build is disabled, x86 will use an > efi/stub.c file to replace efi/runtime.c for build objects. > Following this idea, we introduce a stub file for Arm, but > use CONFIG_ARM_EFI to decide EFI build enable or not. > > And the most functions in x86 EFI stub.c can be reused for > other architectures, like Arm. So we move them to common > and keep the x86 specific function in x86/efi/stub.c. > > To avoid the symbol link conflict error when linking common > stub files to x86/efi. We add a regular file check in efi > stub files' link script. Depends on this check we can bypass > the link behaviors for existed stub files in x86/efi. > > As there is no Arm specific EFI stub function for Arm in > current stage, Arm still can use the existed symbol link > method for EFI stub files. > > Change-Id: Idf19db1ada609d05fc0c0c3b0e1e8687c9d6ac71 > Issue-Id: SCM-2240 I don't think these two lines belong in an upstream submission (I checked patch 2 and at least there they are two similar lines). > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie While I'm not really happy with the Arm side, it's only the other parts which this is applicable to anyway (with the stray tags dropped): Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 07:17:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335506.559679 (Exim 4.92) (envelope-from ) id 1nt2Jv-0005Hb-Cc; Mon, 23 May 2022 07:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335506.559679; Mon, 23 May 2022 07:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Jv-0005HU-9y; Mon, 23 May 2022 07:17:39 +0000 Received: by outflank-mailman (input) for mailman id 335506; Mon, 23 May 2022 07:17:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Jt-0005HG-Md; Mon, 23 May 2022 07:17:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Jt-0001Fl-Cw; Mon, 23 May 2022 07:17:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Js-0004OK-To; Mon, 23 May 2022 07:17:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt2Js-0000Gi-TN; Mon, 23 May 2022 07:17:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A4qKpeoUMVNJjN17/YoO+cMoNRcC8T3MDdcEUM9DceE=; b=qsVh69JG7Ixgb3QcT90zX53MqD q1+mn/+IW/IycBX0E0+i5Rs0fbP8LmGe8AnsLTz3730hIRPt2yhJ+em0s+tIHjCcZvmYtQZqMAVlQ jEDq7l4WVLX30/N5oNYQrPbiMWPgv7NmabC9ztQftsvraEjkCIgtADdEY3q7lY3W3QTQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170693: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 07:17:36 +0000 flight 170693 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170693/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1181 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 69 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 07:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335517.559691 (Exim 4.92) (envelope-from ) id 1nt2Lr-0005wz-Tv; Mon, 23 May 2022 07:19:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335517.559691; Mon, 23 May 2022 07:19:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Lr-0005ws-Qt; Mon, 23 May 2022 07:19:39 +0000 Received: by outflank-mailman (input) for mailman id 335517; Mon, 23 May 2022 07:19:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2Lq-0005wj-SD for xen-devel@lists.xenproject.org; Mon, 23 May 2022 07:19:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0d::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3d5a195-da68-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 09:19:37 +0200 (CEST) Received: from AM5PR0201CA0016.eurprd02.prod.outlook.com (2603:10a6:203:3d::26) by DU0PR08MB7737.eurprd08.prod.outlook.com (2603:10a6:10:3bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 23 May 2022 07:19:35 +0000 Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::37) by AM5PR0201CA0016.outlook.office365.com (2603:10a6:203:3d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Mon, 23 May 2022 07:19:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 07:19:34 +0000 Received: ("Tessian outbound 42cead292588:v119"); Mon, 23 May 2022 07:19:33 +0000 Received: from 58f4032245c7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 326B7388-F97C-4974-811A-EFB1883F75C1.1; Mon, 23 May 2022 07:19:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 58f4032245c7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 May 2022 07:19:23 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU2PR08MB7312.eurprd08.prod.outlook.com (2603:10a6:10:2e7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.20; Mon, 23 May 2022 07:19:22 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Mon, 23 May 2022 07:19:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3d5a195-da68-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WLDOOew1wHYqr98/tzkE2OJ+jpShoAm+sY4PVGqJaVqgVnUnajqNak4WT3HtrO+eKAUY5ITbx+ClPs3H1CuAezIfsM3CRg3kmNW1WsHaa7i3OcTqJmpw9JUUBfqfg6LwA0rJniEAxtCYPeEKFzsDuSmly5hifnYwfmNTV1javr0EB16rlypBNmHtSnW9ezNj24hfJYZEBq9AhSc7MTWvK7ujSzD8mpeN1ErDgl6IMFhCy3UPsbhKwCGEX/xkKm6wc4ZRGGiW5fjUNHuGY48BF15oQV3E0nlPofHMCbY52RrWPGEgdsFQFhxaI3bg/RnbC/DhotdNELkpD3/3SgXU1w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=eiuifb7wLuJjmkwNbLBJySShAo9M+U9gfpXfHgQ+b4H6/DiGwm5VcmDE75kuVYakgZBXMKMzN5tD0/YIT8Bp8bSD4L+7V6VBUVE9fJd8IWUVGKEBz++35XLe1UpKZLdxX7f6JKDbZXVuxaTZab5XOCMc2KzIoiFqU6ho2dHImxHvHeYoACt0N3vyJPcWaFiVjNvLIgVy4DrfJgb6erbQpPvbau98Nbno8MLMoSwuGBHYN9Ym70aFanCav5q106U4NDKVG6Vdnc8H2Z1GYxndbVz3ZWt3EZoHJgyyvP1JDbAyrM326tnkA7ZS4Z3lnPzgYUv8GzPND1RG3jWu/5/rCg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=BMXpXSZcYC1yRUqBVRtRgnryV3QaQRDYMjWEUpD6Gk3CMaOtyX6lcYsK98yX8ceL2yrzEI4P0wutSY9eGhAmdkWawYIJtBgo2JRHr/JH/Yfv+j8zW7jISBz4AuX4pOxh4uDQWIiwAGq4Zj+fmsh5zwbUm5FgJyXOMRp8EQcXkm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hiArrzuzXUe6l7zjYZLDfmUVseLhW0oZ8a270n+CMRG7zT/dcxR6/hOCkralwTJfH8ukb2LJInYHH84OOCCUmpMfEh1YBjxU7AyDC6hhhCKbFpTm3Tb9dHBXdf7vq3yRN866ASPbQm5dt9ozat+n0ATtMblsitpaX1Mg877imKu1It2Gao0vwBDiEYmRYgQiGvHdAWk+JG+BRgHB5yqwqYohteavaTYb4uV8dRCOoyy5OMvqDr7ofVEZ8Mny/l38cknMU2z29Jm4EkYu2FSp9TMfZNMJUVrrzO3n+1v2uwGPxtr8wjfi/MK1IFM4MEpa0DyhOCT3a3esSFr7iqN8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=KY+3QggHvrvGOlMi/hQxVg3GQQxLtgIvQ8/nt+tDluAZe1LWgQ2HmuDvKST0Jv5X9ZVM1X+zStGVSc24yMUOchWcoQfp9ylIA2BSeW7HKTL9ruZLBEv0DH0gTbb9WCNqq1gPvJxz62+01FwjN5/dS1QynnLEzJLX2f9/TeRDI8wDgLWrRrAB3L51voOh9UBZKQ/yZ9eChPzH2TDQCNtmJ5thmD38llXqM5VFFhpUf7ILBFbDODBSbZFehJObsLA7EdZjDjTITfu3OG4RoqAPIWBOjA02CDG8+RDz12Ihokl1Sjw+2lrb8h2Z5/I//0qN0u3Ol6/a9E7Vg+bCm1rUZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tjP7EIVAkBtTHUF8RX62iJa4V70bhXyRSs0SPfDbKE8=; b=BMXpXSZcYC1yRUqBVRtRgnryV3QaQRDYMjWEUpD6Gk3CMaOtyX6lcYsK98yX8ceL2yrzEI4P0wutSY9eGhAmdkWawYIJtBgo2JRHr/JH/Yfv+j8zW7jISBz4AuX4pOxh4uDQWIiwAGq4Zj+fmsh5zwbUm5FgJyXOMRp8EQcXkm4= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Topic: [PATCH v4 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Index: AQHYbm35zG4dPV1xEEaM1LzUwkDv8K0sC4oAgAABzdA= Date: Mon, 23 May 2022 07:19:22 +0000 Message-ID: References: <20220523062525.2504290-1-wei.chen@arm.com> <20220523062525.2504290-2-wei.chen@arm.com> <4254847c-3364-d0c3-5e32-66a12a200ed2@suse.com> In-Reply-To: <4254847c-3364-d0c3-5e32-66a12a200ed2@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D86E11DC46D8CD428F2928E713734816.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f0f7e4f8-9fdf-40c3-84d8-08da3c8c9673 x-ms-traffictypediagnostic: DU2PR08MB7312:EE_|VE1EUR03FT063:EE_|DU0PR08MB7737:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kBKM+PnMfqsr0BVf87P6rsmgaLFEJUAv1mmtw2nH/7gxkj1T5MTfCrtYjeR9074p66mfNPjiO5ISu8lG6am/HKHZN0lLyAcMAvJP6uw4AR1ykpxosoPBlSJnpiwqb+WsvKaXrxbtzBW0BH2LDP8o9+nrkDhzjn+Zl+XAtzlRdZ169iMjZBkVzrumX5Mzt6xiz814LO2eowF3Pauvg4J/9JpVbX4TNSsRvhlg9jO7K4HbBd6drHuM83FUphiwWtNrIq2ueFqPZjPyG2fQZX6UlDy+kj35mpYX8Q4VD9FRdv1bZrT+v+tjadDxAZ9F1wkE75c1F/JkIQD8w5xyH0EyIj+3nddhy3pIvCJmqQp+6Zi2aPTNC0SKsTC1mqgKL/Yc3lEiuFiHiPXFZW+C42OUsTxUl84OdKGMuEFS9cFb77ic2j3YEfzSDu5I1GQHK0p8dihtdSx2CaB4ExjUlsjU9w1a9BN72FTYEVkiMBZmknvv5E+80DmKAEKHZvs0AGPxtHdaf0u7fLbx1pySLeo0j0HLoiI/+DZUDrbGUQYdzj1y/5cztOVqSCxAkL5MWb6brCF62Cc3FTnRdOCFAG1V3S3lrtjGychrj9PFhUn5TK5CvAowx5K3500wKdZuPrbAlDaJCYXx5KNjTPmgj35fXJpo0+ykGw3y0+4G182k2F/E2JSPNDOWQoncjqy9As3dvPONQRT30cjO5r3yaIQ1hQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(316002)(55016003)(122000001)(8936002)(7696005)(52536014)(508600001)(53546011)(8676002)(33656002)(4326008)(83380400001)(64756008)(86362001)(186003)(66556008)(54906003)(71200400001)(38070700005)(38100700002)(26005)(6916009)(66946007)(66476007)(6506007)(76116006)(9686003)(2906002)(66446008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7312 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 970eeb61-e05f-4d35-37a8-08da3c8c8f37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HPDx81gd+y8eY8Erdh+etsqG/eS5tlDVZJxOJsctCiZsu89I3tOfgU/kv2jZxOh2SeFZCtJPeFgdwUli6Jz08W3Be3wxjxUiRP3jlfHbSKFSB/l21BiJ65PUh5f37cI1VezfeuEjeGcErTpDtHVmJFVHpsHFImp+rymiJ2++P7bBu3M9PcW4PMnyC5gHy9vh/eNLWIAPX6QtxLADX14wcP90ZWasJBZzPRH5u1TvsYEKevr5hmowEUPztdUkMrl8GY9/mPuUSGK8dZOegpHlRiANgu4zyb+McEdHySIfhPVWVSwj+txwmQ7S318xHF/Yov6eGzj98DudWz/ANg+viw4nh2eVx3lB9nPi8MxlLyP3yHRzQEmoWJpVGQPmK3iwe9mdc4l0A4Ni2nPQFV6uemmmX1lRnOFA8cVKM66D4lYdCNYV8Wn+p/Iq1p9emgqNdRLId64FILL1fsm/80vpzihbMMGyzVsfPFAjk/eSUUJ4KkUIH9/OVrcK00GYQSzoIgUkWkKSvad617aMvAMa0fIZasQXNomRTaIkbiljfYXQ8gF82Oj7v03nQBqahazoWcPYUwcOSetw7690Cr+RGByHqUstpjw1P9whm7xKPCVhg23B/eVHTp5fxqXr87PHIaDs1xhdZRzSpUirKLQ4YlfJMjzuvqIdaElELtaEl5z5z8s/JQTt26C1MAGe4pO6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(40460700003)(82310400005)(33656002)(7696005)(53546011)(54906003)(356005)(81166007)(316002)(8936002)(55016003)(186003)(9686003)(70586007)(52536014)(70206006)(26005)(508600001)(5660300002)(2906002)(86362001)(83380400001)(6862004)(47076005)(8676002)(36860700001)(4326008)(6506007)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 07:19:34.2493 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0f7e4f8-9fdf-40c3-84d8-08da3c8c9673 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7737 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDXmnIgyM+aXpSAxNToxMQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbg0KPiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlz QGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5j b20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIg UGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkNCj4gTGl1IDx3bEB4ZW4ub3Jn PjsgSmlhbWVpIFhpZSA8SmlhbWVpLlhpZUBhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0IDEvOF0geGVuOiByZXVzZSB4 ODYgRUZJIHN0dWIgZnVuY3Rpb25zIGZvciBBcm0NCj4gDQo+IE9uIDIzLjA1LjIwMjIgMDg6MjUs IFdlaSBDaGVuIHdyb3RlOg0KPiA+IHg4NiBpcyB1c2luZyBjb21waWxlciBmZWF0dXJlIHRlc3Rp bmcgdG8gZGVjaWRlIEVGSSBidWlsZA0KPiA+IGVuYWJsZSBvciBub3QuIFdoZW4gRUZJIGJ1aWxk IGlzIGRpc2FibGVkLCB4ODYgd2lsbCB1c2UgYW4NCj4gPiBlZmkvc3R1Yi5jIGZpbGUgdG8gcmVw bGFjZSBlZmkvcnVudGltZS5jIGZvciBidWlsZCBvYmplY3RzLg0KPiA+IEZvbGxvd2luZyB0aGlz IGlkZWEsIHdlIGludHJvZHVjZSBhIHN0dWIgZmlsZSBmb3IgQXJtLCBidXQNCj4gPiB1c2UgQ09O RklHX0FSTV9FRkkgdG8gZGVjaWRlIEVGSSBidWlsZCBlbmFibGUgb3Igbm90Lg0KPiA+DQo+ID4g QW5kIHRoZSBtb3N0IGZ1bmN0aW9ucyBpbiB4ODYgRUZJIHN0dWIuYyBjYW4gYmUgcmV1c2VkIGZv cg0KPiA+IG90aGVyIGFyY2hpdGVjdHVyZXMsIGxpa2UgQXJtLiBTbyB3ZSBtb3ZlIHRoZW0gdG8g Y29tbW9uDQo+ID4gYW5kIGtlZXAgdGhlIHg4NiBzcGVjaWZpYyBmdW5jdGlvbiBpbiB4ODYvZWZp L3N0dWIuYy4NCj4gPg0KPiA+IFRvIGF2b2lkIHRoZSBzeW1ib2wgbGluayBjb25mbGljdCBlcnJv ciB3aGVuIGxpbmtpbmcgY29tbW9uDQo+ID4gc3R1YiBmaWxlcyB0byB4ODYvZWZpLiBXZSBhZGQg YSByZWd1bGFyIGZpbGUgY2hlY2sgaW4gZWZpDQo+ID4gc3R1YiBmaWxlcycgbGluayBzY3JpcHQu IERlcGVuZHMgb24gdGhpcyBjaGVjayB3ZSBjYW4gYnlwYXNzDQo+ID4gdGhlIGxpbmsgYmVoYXZp b3JzIGZvciBleGlzdGVkIHN0dWIgZmlsZXMgaW4geDg2L2VmaS4NCj4gPg0KPiA+IEFzIHRoZXJl IGlzIG5vIEFybSBzcGVjaWZpYyBFRkkgc3R1YiBmdW5jdGlvbiBmb3IgQXJtIGluDQo+ID4gY3Vy cmVudCBzdGFnZSwgQXJtIHN0aWxsIGNhbiB1c2UgdGhlIGV4aXN0ZWQgc3ltYm9sIGxpbmsNCj4g PiBtZXRob2QgZm9yIEVGSSBzdHViIGZpbGVzLg0KPiA+DQo+ID4gQ2hhbmdlLUlkOiBJZGYxOWRi MWFkYTYwOWQwNWZjMGMwYzNiMGUxZTg2ODdjOWQ2YWM3MQ0KPiA+IElzc3VlLUlkOiBTQ00tMjI0 MA0KPiANCj4gSSBkb24ndCB0aGluayB0aGVzZSB0d28gbGluZXMgYmVsb25nIGluIGFuIHVwc3Ry ZWFtIHN1Ym1pc3Npb24gKEkNCj4gY2hlY2tlZCBwYXRjaCAyIGFuZCBhdCBsZWFzdCB0aGVyZSB0 aGV5IGFyZSB0d28gc2ltaWxhciBsaW5lcykuDQo+IA0KDQpBaCwgc29ycnksIEkgaGFkIHNlbGVj dGVkIHRoZSB3cm9uZyBkaXJlY3RvcnkgYWZ0ZXIgSSByYW4gdGhlIHNjcmlwdHMuDQpCdXQgdGhl IHBhdGNoIGNvbnRlbnQgaXMgdGhlIHNhbWUuDQoNCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hl biA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gPiBUZXN0ZWQtYnk6IEppYW1laSBYaWUgPGppYW1laS54 aWVAYXJtLmNvbT4NCj4gDQo+IFdoaWxlIEknbSBub3QgcmVhbGx5IGhhcHB5IHdpdGggdGhlIEFy bSBzaWRlLCBpdCdzIG9ubHkgdGhlIG90aGVyDQo+IHBhcnRzIHdoaWNoIHRoaXMgaXMgYXBwbGlj YWJsZSB0byBhbnl3YXkgKHdpdGggdGhlIHN0cmF5IHRhZ3MNCj4gZHJvcHBlZCk6DQo+IEFja2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IA0KDQpUaGFua3MhDQoNCj4g SmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon May 23 07:28:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 07:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335525.559701 (Exim 4.92) (envelope-from ) id 1nt2UR-0007Pt-PF; Mon, 23 May 2022 07:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335525.559701; Mon, 23 May 2022 07:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2UR-0007Pm-M7; Mon, 23 May 2022 07:28:31 +0000 Received: by outflank-mailman (input) for mailman id 335525; Mon, 23 May 2022 07:28:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2UQ-0007Pg-FJ for xen-devel@lists.xenproject.org; Mon, 23 May 2022 07:28:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id eff79ce7-da69-11ec-837e-e5687231ffcc; Mon, 23 May 2022 09:28:28 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EE86D139F; Mon, 23 May 2022 00:28:26 -0700 (PDT) Received: from [10.57.7.84] (unknown [10.57.7.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5673A3F66F; Mon, 23 May 2022 00:28:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eff79ce7-da69-11ec-837e-e5687231ffcc Message-ID: Date: Mon, 23 May 2022 09:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-14-julien@xen.org> From: Michal Orzel In-Reply-To: <20220520120937.28925-14-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 20.05.2022 14:09, Julien Grall wrote: > From: Julien Grall > > In a follow-up patch, we will want to populate the boot allocator > separately for arm64. The code will end up to be very similar to the one > on arm32. So move out the code in a new helper populate_boot_allocator(). > > For now the code is still protected by CONFIG_ARM_32 to avoid any build > failure on arm64. > > Take the opportunity to replace mfn_add(xen_mfn_start, xenheap_pages) with > xenheap_mfn_end as they are equivalent. > > Signed-off-by: Julien Grall > > --- > > Changes in v4: > - Patch added > --- > xen/arch/arm/setup.c | 90 +++++++++++++++++++++++++------------------- > 1 file changed, 51 insertions(+), 39 deletions(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed48a..3d5a2283d4ef 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -637,10 +637,58 @@ static void __init init_staticmem_pages(void) > } > > #ifdef CONFIG_ARM_32 > +/* > + * Populate the boot allocator. All the RAM but the following regions > + * will be added: > + * - Modules (e.g., Xen, Kernel) > + * - Reserved regions > + * - Xenheap > + */ > +static void __init populate_boot_allocator(void) > +{ > + unsigned int i; Shouldn't this be an int (as it was previously) because ... > + const struct meminfo *banks = &bootinfo.mem; > + > + for ( i = 0; i < banks->nr_banks; i++ ) ... nr_banks is int ? Apart from that: Reviewed-by: Michal Orzel Cheers, Michal From xen-devel-bounces@lists.xenproject.org Mon May 23 08:01:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 08:01:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335538.559713 (Exim 4.92) (envelope-from ) id 1nt2zu-0003aC-OU; Mon, 23 May 2022 08:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335538.559713; Mon, 23 May 2022 08:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2zu-0003a5-Jy; Mon, 23 May 2022 08:01:02 +0000 Received: by outflank-mailman (input) for mailman id 335538; Mon, 23 May 2022 08:01:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2zt-0003Zv-3D; Mon, 23 May 2022 08:01:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2zt-0002Xb-27; Mon, 23 May 2022 08:01:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt2zs-0005Xr-P3; Mon, 23 May 2022 08:01:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt2zs-0006Cg-Od; Mon, 23 May 2022 08:01:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wvvCra2NwzrUQJsUxkajJn7TYrs2NdwZvfGzUzxNy+8=; b=ejqYW2C6dDLA+KLgnEz15+c0U4 2XyrHqnMd4Zy4Qh0tDn4oLuwnb6CTglCC/u4WFeNuhLsY+dlHx1pmG1vV4jtNzcWGrlyby6/a8y+4 CMnD+Z0zcDWTaKZcQlcL48YgT6AIzVjtfqdarhvq4OcU5awYml8Qq0nuHXfm4QqzbB6E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170694: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 08:01:00 +0000 flight 170694 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170694/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1182 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 70 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 08:04:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 08:04:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335547.559724 (Exim 4.92) (envelope-from ) id 1nt33M-0004FB-9X; Mon, 23 May 2022 08:04:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335547.559724; Mon, 23 May 2022 08:04:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt33M-0004F4-6X; Mon, 23 May 2022 08:04:36 +0000 Received: by outflank-mailman (input) for mailman id 335547; Mon, 23 May 2022 08:04:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt33K-0004En-10 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 08:04:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f91939cc-da6e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 10:04:31 +0200 (CEST) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 04:04:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5454.namprd03.prod.outlook.com (2603:10b6:a03:284::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Mon, 23 May 2022 08:04:25 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.022; Mon, 23 May 2022 08:04:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f91939cc-da6e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653293072; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Rz4hzDuzA9kTzkNOKNeWpiC1JUO88Q91EZyS+HXZzZM=; b=GHNlBp+/INehgK94HwDpJu8W56Exfq/W68zrQjOrjSXw00DAhlhNZqk1 eyt/z1HWMQ7WrD7nncZY2K5UztyDtJEY5x0tc4HYB7zqqPEexR5JldmqU aLUMcbuVXwN0MyVGQris7Yq8klyatXDtgAHlvg8qbkG5dzMi11fCDxtFa I=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 72321082 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7MKeJ644Pf9xA9yDQuglpgxRtEzGchMFZxGqfqrLsTDasY5as4F+v mQWDT+GOayMMGOkKdEjYIu38kJTsJbXx9JnGVRo/y8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSxFxkbYpaQnt1BeAZ3M3FFA5Fo+6PYdC3XXcy7lyUqclPK6tA3VAQcG9Jd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfqSo4YAh1/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IC8wjM/fpti4TV5CFSjZLAFOiSQcyHFNsNlX6lr 3La202sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/e5VmfD21dFjpZMoV+74kxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:CZRxhq58s7wIf4WkwAPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="72321082" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hcg6xHSB4j87yFNPbJXKKmIdPrJWYSCnLl70IaBf4koRgv8g9S/yHFz6iQPYj9dPnuyw8WhLabTfITDA+58ljrV3QwbZa8cLLMTekOXTwHL9TKG7Aiy8tsTmemZHOOCcuKTMLYNtezN/ODj1BfCi6ZWeN3D101Omi+0c3wg3vKKvBR9DrtAgMHmhggLr/yeWEAwBrXb/PhxZOacrnq1EfFhp6StgkxybBHLlxUCglI1kTtzOhWIav+NVkCUvzJnjL+5xyD8DiwPrb79twzHj437EZtdHTJ57kGIvT/MNM93wZjGq+zVTgYUa4NTEX3AX8RFPQLDMGQM54ZSscULdlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c6SjOGvFSMVgKXM0stxsmuSoigHb1a+2G+Uj+FzAquo=; b=jzJYWaw7JvhtiFVbab2/9T+aeZbk967m9kCoHVpp8WNY7ABSLaXp225vQnAtD2UdxgaIKZsoEZ5o+yWLpNQ1lTcu2Pbyxmj8c8WDmNqSMPkhbrbRfyY9ek7Vm3qWbsfMXTI6YCQ4Ll7vHOFDuE1AwvsCxfMv3oa+zE+3ubqfKe/rgaqszTYnXfZiERC9wsqpJQzZ0MAYecz8djvd9TpspRdbr0JTDAchUR4yjLpQpt5DVOx6TZsYFIIcTe6cSrdTzWaMFbgUzawN/njGS6GmEfFmaPMwc5F+8PO547L6Vv9VDTeEy68ToFjMI5M7sFSEzP3STK+x8Xq90255wLQCSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6SjOGvFSMVgKXM0stxsmuSoigHb1a+2G+Uj+FzAquo=; b=CkdbdSYinhVddb1Khz/ErVDnax/ZpUhGvPq46NCr4dPrcMQf6kNcwWPRLsHUg4V86cRpya2jF9XWV56YDiaKbTfb3gEJuvYe2Arl8tdTyckLM99ROCCpDs1Qkf3Hi0od8sWjWMFFLsCU5q3tNXgUvgep7Z7dRmIdUly7DxSsPFI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 10:04:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: Jan Beulich , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: MR1P264CA0068.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:3f::33) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca653d4d-6d17-4443-e471-08da3c92da65 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5454:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m70z0TmNLOtzAfGszuRSC1ZeHhQnfDcRf/A2k96yH0zToymYbuaixvacTCe4MsCQAFd85BWL7x1o5YBh+H9QEG3lOsVelTxhvvt9B94I3CTLRD3ymgkjl3duYQez0r3V7cbRb++AtGlTpN+JLunlshi0obm2wEM3zfM/JeH7zcd4bzWEQJTKj0pRS82Q8g8S8JrzAwpOfWfMfvPF/zQl9WEBOmza97Wpsl+PJCTapw2C/ywO0sdB8cM1bbNnBQvVwHv+jtbF42cUVzRH71SeLZX5uO3/6H9IpdSa0T3RTOzBG61Lre64+K+nHeg8NiJ45F15lvrwWTndGYjAq3xtwnZlNDtQMGzTx6qFVbIwYbiLl+E+LbDGJxhQzNxKA9GjobF/BiatNAJkdK0tS3r6SXDBPasytHJ0sIDNtBdf/7v4XUYzC2OwT/phBc+looxIS9eFSXgliBTDEHQ9EBgrGhGWz7NonD8vBnx1lFMsApk38Cgb+tnPWY2wzlNVpIdsxrqVRMPNltzAyaVBTrUYRYW/yOH3Hlr6/R3edzEmy62mh4nlZezGu+6mrVAWZ2Gv8ETosrGNb+PTPDIdKkS6IsrP8waP0Ip+2wP7Fzux1cNkVKfcHOE++X878N8nEw5cBKPxv2IeOmiqRyklMMDBJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(38100700002)(66476007)(66946007)(85182001)(8676002)(6862004)(4326008)(66556008)(82960400001)(33716001)(6666004)(2906002)(8936002)(6512007)(6486002)(26005)(6636002)(86362001)(6506007)(53546011)(316002)(508600001)(9686003)(54906003)(186003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2Jnb2paRjNwdFl0UmhRb2NQZS9oUHZVelg2aHEwb0xwajE0Ym05UXYvNUVC?= =?utf-8?B?NnoxUGw5TktMR0FuTU5aVklCRmFDSjJQL01tZXlCcit4cDFzTXhMZlRsNGpS?= =?utf-8?B?dE53MG9PZktPYkoxT2x5SzIwNFN6MThBT0x0Rmx2VGVIWWJ0U1NIbWxqWU43?= =?utf-8?B?WGtPRzR1VEhNUzdjZDZxL1BPS2Z2OXZ3U252NnIyeHRTVmdtZmlPRksvSGZC?= =?utf-8?B?b1FSSkNKSUlqclRNVDVMTlZERklvdzNhblE2WWZaY2VQYzNtclcxM3dZcTJp?= =?utf-8?B?a2pmQXJOQzZyTmhUY3hBNHk5VWlGbzM3ZmxsdFdsVjA0b3lOZ2h1ejMvOGk5?= =?utf-8?B?MEdBaFVFakREcVZGcEIvZFpJVFhWUHhqSms5a3ZsSXBSSUwzZE9mODZBWnk0?= =?utf-8?B?c1NRQzZqdlVaYTNVVStZTnhFUU5JL05hYzFYMDZ5cGUrR3VQdlo5WXBQeWY1?= =?utf-8?B?MlhDSno2ZGYvR2t4YktibURjejNJNEFITk9mR202TU1wU2xTK0hVWXZNbHY5?= =?utf-8?B?QXBmS01GQmRlZ2R4WmU1d28vaFVFRHdpZnRiZTVTV0dKck1KaGVsMlU3WXhW?= =?utf-8?B?MEZhYTZIbGhpMUhWVmVDQUQ3YSt6TGxwN0IrVFJRSW4raHpzd1BCY1IxN1Ex?= =?utf-8?B?RGJ4OWV6ZEF6aytWZkJTWEFKNGFacE0yV2tkNzVld2RkU0lpWmRBZ3FQUVAy?= =?utf-8?B?a0FzeGJSQzJpNEZHQzMrRno0b21wTkc1Y2k4K2tLUFZpWkQwbEl3VjZIV3Uv?= =?utf-8?B?eUl0VDYvd0d4TU1BWU5PZHhERUlBM214cGxZUDZNMUlxYUVMV3lQOXcrMXVR?= =?utf-8?B?ZDh4YjZLaDQzNkF0NkQwM1JIZDdUdFZvbFlyUU1NM1AxWnpma0xpRVVOVEU1?= =?utf-8?B?Uk50a2Z4Q0s4VmFFZUVqTUFTQWdUVkNGK01sMHo0dDFNM0J4S2JuREwxTnNN?= =?utf-8?B?ZWEvZFlza2ZkRm82TmFvUVFBb3JGZW80VjVQTWNyeUt4NmpOeEdITGNZZFd4?= =?utf-8?B?enRMbzhHbEdyNm5EZnprckhnTkFnMFcreG5FVzQ2cTBrYkJzeGFUbDFZcUhH?= =?utf-8?B?OFhUWnoyVzBXQ2ZhWFBNS0RmcHAxQUcxamJzMmFBc1U5c2lFYS94U0s4N3Qr?= =?utf-8?B?R3FvUzB2OC9WS0JYMlN4TitRS0llWklMMjRsSWxrZkEyWUczQy9zM2gwVXZX?= =?utf-8?B?MVRWcGVkZ2hVdXhsNmVodVdCSXl0dUVPTlREZGE2SkZua2E5RkdOU2V0SDJG?= =?utf-8?B?bTF2bmNhU0g3QlRSZVAyb2tDeUtmaFlEaWhCNXRsSE1PdkZGeDAwdDYrbUlJ?= =?utf-8?B?UXV3RURNcE1rTFVKb0NGTlRoUkg1NXJudjJBNERyV1ZwNllpblBmR3BaVURy?= =?utf-8?B?bkg0S1BDQm9LUjczVklsdXRsTkNOWG9YdlovaGFBdkJTYUpTOFB6dTBoMndt?= =?utf-8?B?OXJyZTJYTTFnUjBiN2o4YmIvKzhzRUlHdnFYUVJMOE54cEhSb3Bkb0d0VXlT?= =?utf-8?B?WmY4bVg1SFVkUnp2UnovbDhOM1RVamVQTzNZV2JtVDkzV25qeEM4RG85eDUz?= =?utf-8?B?QUVsUjFEeEphYldET3BwK1JqSXRnV1BmRXB0SW5ycG12RHBIb2IrUzA1bEZn?= =?utf-8?B?VDAxVDVsd05IUXJCVzBMY3N4RElnQkFMNE1uTjBLL3R2NVpMelF3cVdFU0Ro?= =?utf-8?B?aUNzN2VpcGxDZjQ2bjQ1d0RkcmhEUDMrRFAvbUY5dFZzalpFT2dEdVpFNWVI?= =?utf-8?B?UFRzUXREUytzcUJFQ2J5ZXFId3FzTFdJM0Z0SzJYYXdBTkp0QkRDNzNUMUta?= =?utf-8?B?WmRac1lHS3ZMQUVvYm82SFJpK0FuZFFSMUI5YzFkQk9pSGp5UGtFcU0xNUVC?= =?utf-8?B?SE5nM1dVMlN1UGEvdmNLWHFvS3kxblFnV2lwZTFHcEYzQjlNREQ0cERXcERi?= =?utf-8?B?dm5wSXgzMnMySUZjRFRDYmppTlFYT3RWNnoyMkxmOVpVRTRJQlpZci9JeHZw?= =?utf-8?B?TmRiZEJySkIwei9JaHVmbGgwMVM4NFIvOTE0T3FQQzhNVDhoZGJEaXJJZ0ZT?= =?utf-8?B?V2pwWGd3dmltTDh1OXVTNGZTSHFiZTJmL04vem5HM1dhWDVuWEVlU29uQy84?= =?utf-8?B?MGxHbDAyZ2o4dm9TbXpYdUtiL2xQRU1HckRqQXVCTHhnTUZkcGZMckJmN3dG?= =?utf-8?B?anhvVWFHVEZPZlVyc3BXaTNVWGZUVGVjWUtsZzFXVDJTeFZQWU00cEdqVEMy?= =?utf-8?B?di9IZ1c4b1lkckFrT2VVckxIVUFWbmR0WVJrcjJpSGtFTTNTdk9mMSs3OU1m?= =?utf-8?B?akRhRytuY1N0TVZtOXlJeFV2VWk3RTlkSTU3bGt3UVJQNWl2NXlQQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca653d4d-6d17-4443-e471-08da3c92da65 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 08:04:25.4598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nYC1pydRSPvw5/KxZb7yJEKhTP0SbDMMwfKcGIkgzmqUIdp4s52wfgR8tXXQNYGoe1Hj8bANSPjM4YKwb5UiTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5454 On Fri, May 20, 2022 at 02:58:01PM +0000, Andrew Cooper wrote: > On 20/05/2022 15:19, Jan Beulich wrote: > > On 20.05.2022 16:10, Andrew Cooper wrote: > >> On 20/05/2022 14:37, Roger Pau Monne wrote: > >>> --- a/xen/include/public/arch-x86/cpufeatureset.h > >>> +++ b/xen/include/public/arch-x86/cpufeatureset.h > >>> @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Supplemental Streaming SIMD Extensio > >>> XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ > >>> XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ > >>> XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages */ > >>> -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR */ > >>> +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR */ > >> This is the bit which requires more toolstack logic to safely enable.  > >> Using 's' for off-by-default is fine if we want to get the series in now. > >> > >> But before we expose the MSR generally, we need to: > >> > >> 1) Put the configuration in msr_policy so the toolstack can reason about it > >> 2) Reject migration attempts to destinations where the LBR format changes > > Since this could be quite restrictive, and since people needing to know > > they need to hide this feature for migration to work, I guess this would > > further want qualifying by "did the guest actually use LBRs so far"? > > In practice, it's every major generation ("tock" on Intel's old model), > so isn't actually limiting the kinds of heterogeneous setups used in > production.  (Migration gets steadily less stable the further apart the > two CPUs are.) > > As to dynamic, no - that would be a security bug in a cloud scenario, > because there must not be anything the guest can do to interfere with > the manageability. > > Use of LBR is rare, as demonstrated by the fact that noone has > complained about the fact that migrating such a VM will malfunction. > > As we now have a way of reporting "no model-specific LBR", I'm tempted > to suggest that VMs get no LBR by default, and someone wanting LBR has > to opt in, which is also an explicit agreement to the migration limitation. I did also consider exposing "no model-specific LBR" in PERF_CAPABILITIES unconditionally, but I was worried whether that would break existing setups. If we think that providing an option to expose the native LBR format in PERF_CAPABILITIES is fine that could be a sensible solution IMO. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 08:13:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 08:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335558.559735 (Exim 4.92) (envelope-from ) id 1nt3BY-0005jc-B3; Mon, 23 May 2022 08:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335558.559735; Mon, 23 May 2022 08:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3BY-0005jV-6q; Mon, 23 May 2022 08:13:04 +0000 Received: by outflank-mailman (input) for mailman id 335558; Mon, 23 May 2022 08:13:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3BX-0005jP-7E for xen-devel@lists.xenproject.org; Mon, 23 May 2022 08:13:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29dc1ce6-da70-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 10:13:01 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-bj4x5uwyMaWFPTcAAPSucw-1; Mon, 23 May 2022 10:12:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6868.eurprd04.prod.outlook.com (2603:10a6:208:18c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 08:12:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 08:12:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29dc1ce6-da70-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653293581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQ24r0YUc6qh7IvEhWFMsvsADczbMGaGoENmb57gQ/8=; b=bJT1ewnebu9TL2SOCAflQ9rnZrw1YeDj3URqpn4gJtq1+Gjxh/YBsSCCjVJ6Bn2qrCzpi4 4cjG2zsioL8n8uaIEJ4AAB7dCa+NyeP/rLRpGkL0VsuNG3nCA6lLVA95zMF2enC84xyOre QlyPj86Sy/rn2ob2wgCX0bAx1KOpwCk= X-MC-Unique: bj4x5uwyMaWFPTcAAPSucw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnHbtDTT8jWc5S225ImFFQs8m+nTBccVKDsgzUxTj8XMMeGsKejurYXJGXIHZnHD/YJjbGUJU6cIotvoY3q6tRGoMbqJAWd+SIap8sD6JgO1+Wv/x6mNvkoeAPKvc1Y7pkxPeXfuwGljPCeYUn4JBuMbrtTAv6APd6PUHPMpYXfUtJ3C0JHZ8ut2F7Kc1SaP2pgwlEy5XRHsFKre1hvF1L1emX2oCKJf/IF3IwFNZCuFoVI6wKrpDkO8iQ/sXx6DzygFWivDvBfUh8dlDPCaHh3GqNdadwV3rt5j7P6a+m9axHDZ8iSWvg11f5OGna+2NxHPv0wh7gUEeJTsPZ8cJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B0IYNLEgBeHXbWvEkHgbLyf7B7ltz3Z71RxN3MdbvH8=; b=mflyaXZ8FDLXcryLUJGlIdmRA5FbQJJBWaaEkjyIGRH6Oaa/nyepoWAHoC2Dq6RVRAhrrKYDcO1XwscqZnkmnQeSn3tXoQIu8WXuZvJfGe/3UQdFuNKBj+1ozBxMrWc3xXmhj5ANKxj+PS1j8XjZ8ZRSc+GuJJT+g38AiBZ2VHROil5aqfYqCh70RHB0to8qdNzzP6rbkXaIiECdYMPRAytVYiHfFpbUZJeyGvp3R9sbLQhZB1p5buWAtEmUAaoWvc1JlMPDja6QDnWSn2ILTDLmuogecWhcvmEl/1FOrITgEGH6AKMkIkJhhwVtkbgHGs9oWp5ep6UcqfTFDJ9Bug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5330ca97-2b72-409e-c021-61ab4356e051@suse.com> Date: Mon, 23 May 2022 10:12:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Content-Language: en-US To: Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0777.eurprd06.prod.outlook.com (2603:10a6:20b:484::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0716f269-a048-48a9-2c9c-08da3c940a96 X-MS-TrafficTypeDiagnostic: AM0PR04MB6868:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LXI7e2bTmBpl4vDgE1t+FALOVNunZ4D0xXYatuKwpdSzRY50C+eE39PP1ketGFBpPS1aL7nSNE18wwzyTgt2DmtLQoruZCl8GqlO5gNny+mfwK2llQPIhaOsDunhT99Ju6Wdw8x/YEi+AnGLYtGLkABv01b+V1MD5iYux55WogaSXiHQHTI40K3trUVS6nMg2Yidzjp30Lj9JaRslkGTH1JV0hWH6q8BQLgj1q2UgzHqa9N4yAzI4+i2IlD6ziEJcn+Iy8wfq70za6coV1gzei7CjojcMUPKPSW1hIoI2/r9ffCu/8aicVbu9BpI1je/TQcEd3zZHkxfjBLACumR0tkFhwAqP4dKGFT9bTYGenP6z3eSOKlYd6PvKaUXG59CTzlA7DXHiHdTEia7a2xUIj3tIDPeo69+UjCa2JD98m3QF99EMjGZwKfkrxg+uSzvPp9a0I1vhVC+3QV2SEcMfXwHHZW4Z4oWtq27EJdDb56Eba8R5nx/J9ngr1mpTChXWVAO11h3HJVPINnrUL0h45o7r427U4K39pqBzT9QaKUU0zZb78M/lXwi9/8c6KU4HXxlp7VftYvG7GT0kVV78UTfUd8R1Zdr1utti3BwoU3r2T0HPk3QHMAvyMPYfvVivKfAclJKDbicjrfNP84Kgfibl5nxlOCy5MWJbK6wNtPbV/QDRIjOJ+l/01mlGsbfRvvw5ikLlL26ajecTqR1F8Kv9vSepCoBCLxKvS2RaXCkbcR3xhtIfQn3USOTeNqz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(6916009)(53546011)(6506007)(508600001)(6512007)(26005)(6486002)(54906003)(2616005)(86362001)(31696002)(5660300002)(31686004)(8676002)(316002)(66556008)(66476007)(8936002)(2906002)(186003)(83380400001)(66946007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KwkmT+HL7E6uF/gsg0/QSkWUd/9Uaqla/Xe+rUik0dYPKv73AzWoxNZGeT/V?= =?us-ascii?Q?hcQ2cTVcSGfh+Xaidy27RKytjgnPHszh4S8i50vALsaGG+CpNSASKyOe91St?= =?us-ascii?Q?nFwa+nMKVm1xW7BPYCpd2HMfmu0xlgdXT9BzDMUYcc3nGBglIO+L39zkB46J?= =?us-ascii?Q?LLr937Gq7VUV2XX/1WI0Tf0y5mpl4psoZ85nOXxw6bhZ6XssrD4CuUhdOgk/?= =?us-ascii?Q?DsTVvxKt71AXetsQl9z8DHyGbsvV80x0NFTUgRZW3KPhnPEEesYbYiKSEsGT?= =?us-ascii?Q?cTHLue3uRwgSaSVOw3+dggWg8fIbvR+/dvzuFqjJqmwSwZIV1n4dhBsl99iN?= =?us-ascii?Q?bYhXEdKJvHoXeXClsqwzexfZqjJXeDy37wWoPIBlyL8/eWkvyrbt4arYHeO0?= =?us-ascii?Q?j+csk5Cfzk0qyA1cfKQFMxdsAwc5f5To7DCeJwDCQboO7GA+TfknY5OjcjZs?= =?us-ascii?Q?bKbZzPFH0IuxfACkxgR4PheF6JeNw34YnvoRS4lmqeElf0z1vU6SFuAtu+Y+?= =?us-ascii?Q?yp4rOX2zIbTeOubMxLUafXhr/5tFIYsPVmTE/hCa3IuHfMIvUkEcd7oBoVEy?= =?us-ascii?Q?CZ8TXeB1JQ+MXkeqhRQVn794tU7hNTRObnNHq2u4Gj+Dpn3SUKS4aIqHUKJ1?= =?us-ascii?Q?gQ/c+UBBLp1xVfh9Py96q0v2x+Tzf0wS29TPR1nGktSsMqkv1AnNtqcz6gEA?= =?us-ascii?Q?/4MUYED9ad0plI0UKOcsEk6grOVYGV5Dr2mc9MbZIF96Tza3YuMorrsKTctQ?= =?us-ascii?Q?mWAlO0vh2qPRkvFM0c0NOv/4Na2Xw8RfJqhOVdt20Rp+dqnrnAx1kL/NNQss?= =?us-ascii?Q?VO1/hdGu2T/mK8Dlq3eESQlDgkDeYOa7WqsA7787Z2x9p+szFrYdUDNXqcJ/?= =?us-ascii?Q?YiUkRdaItsQYstOWQKZUyxMMUGbQHr3eccDa+91NpfFQNGqFsBD63lU3dfwF?= =?us-ascii?Q?78oJKvGs+YmhaCbENlFQa3Ha1qiAZUrYtnycutXFf5D7ThlSHe6Xd2I6+JjZ?= =?us-ascii?Q?0Wh2IeNShmTrfGlQBNbjFjGw8a5btoMXDM1t1etcRmRGpBwuPUmIxpGo5n62?= =?us-ascii?Q?zcce91OIJ93k9/N2Vd9QAMsDXHHt8bGmUs6aWxRmXZda88kjuXnwPpA+ZI3u?= =?us-ascii?Q?C4ykURjiYHSBuyofOgJuyd58Z4KaCCfdjMBzbQV5sg3HN2zBtyp1zGnI/hRB?= =?us-ascii?Q?Sbq7zob2Vuq6cuNtDcksZ8YoQd+OEDvmCLH1+WNJuQXOgYCNPE7/kXTQfx8L?= =?us-ascii?Q?9j07fazmTfXSRdOlxknSJ8X4KOB8tzqyfQSMoSsYVPkKs5oyC7EcQVLdI72T?= =?us-ascii?Q?0RPbEta7VW04W4aGItnqksBeYg9g5dPIP3+r3tBOERgN6E5qQ15u5DlyOp0L?= =?us-ascii?Q?61W41AsYKZ0H6gfWE66tSS3ya1UuM6TiLH8MwDB/55ebIPYgAsC6EfjfTFp6?= =?us-ascii?Q?5oRajJihG1LL6NaP/4EaHPZ+1w1VU6AAp1FzG5KJl2hRpoAsXKuhuOe7R2FV?= =?us-ascii?Q?oDpGXfpgkSos6sMYxGLcgHIQvxdKoE7pItnA5SkT8oqKCDNUyHyXNtefihwQ?= =?us-ascii?Q?SynPp/fR3n3FsmL+wwlLTQh+Dl4DyHLZLck2bFp8fzC+1PkBhgrP2e7a7lDe?= =?us-ascii?Q?wVTTpeV6dwpCHKHxFft9ukE9HOjAD6xHgZO0UODAY8ZMZ6x8N0KwD7U2EJZA?= =?us-ascii?Q?dPWirV7taR9p11rNsH1W7BxdBjSS1qyxCRdH2E7yVQEkX2j7wiU/dY6hF+yK?= =?us-ascii?Q?+62ThuteMg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0716f269-a048-48a9-2c9c-08da3c940a96 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 08:12:55.8192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e5oyvoRMnStgqVUmPFDgBTEIQ2+26j+YIoz3Urecdzn5eRCN7gevqg1Kmk4HXrDRBvaRziBaaD/WFHf7eeKRfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6868 On 20.05.2022 16:58, Andrew Cooper wrote: > On 20/05/2022 15:19, Jan Beulich wrote: >> On 20.05.2022 16:10, Andrew Cooper wrote: >>> On 20/05/2022 14:37, Roger Pau Monne wrote: >>>> --- a/xen/include/public/arch-x86/cpufeatureset.h >>>> +++ b/xen/include/public/arch-x86/cpufeatureset.h >>>> @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Supple= mental Streaming SIMD Extensio >>>> XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ >>>> XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ >>>> XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messag= es */ >>>> -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR= */ >>>> +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR= */ >>> This is the bit which requires more toolstack logic to safely enable.= =C2=A0 >>> Using 's' for off-by-default is fine if we want to get the series in no= w. >>> >>> But before we expose the MSR generally, we need to: >>> >>> 1) Put the configuration in msr_policy so the toolstack can reason abou= t it >>> 2) Reject migration attempts to destinations where the LBR format chang= es >> Since this could be quite restrictive, and since people needing to know >> they need to hide this feature for migration to work, I guess this would >> further want qualifying by "did the guest actually use LBRs so far"? >=20 > In practice, it's every major generation ("tock" on Intel's old model), > so isn't actually limiting the kinds of heterogeneous setups used in > production.=C2=A0 (Migration gets steadily less stable the further apart = the > two CPUs are.) >=20 > As to dynamic, no - that would be a security bug in a cloud scenario, > because there must not be anything the guest can do to interfere with > the manageability. >=20 > Use of LBR is rare, as demonstrated by the fact that noone has > complained about the fact that migrating such a VM will malfunction. >=20 > As we now have a way of reporting "no model-specific LBR", Which only rather new guest kernels will know to look for. Hence ... > I'm tempted > to suggest that VMs get no LBR by default, and someone wanting LBR has > to opt in, which is also an explicit agreement to the migration limitatio= n. ... while in principle I agree with this, I see a practical issue. Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 08:31:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 08:31:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335566.559746 (Exim 4.92) (envelope-from ) id 1nt3Sj-00086c-T1; Mon, 23 May 2022 08:30:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335566.559746; Mon, 23 May 2022 08:30:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3Sj-00086T-PH; Mon, 23 May 2022 08:30:49 +0000 Received: by outflank-mailman (input) for mailman id 335566; Mon, 23 May 2022 08:30:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3Si-00086F-61; Mon, 23 May 2022 08:30:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3Sh-000337-S4; Mon, 23 May 2022 08:30:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt3Sh-0006GL-Kr; Mon, 23 May 2022 08:30:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt3Sh-0006HM-KQ; Mon, 23 May 2022 08:30:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ynDuJmtCF6om/mZKyIsqSSF28Ofa0roxU9ZBlS5fl7M=; b=PP0L3VV7BKimcWGEb5Va74F5aE 5nZ5UShhrHhQw/VbZNhop+rpg0BcLrJZCe/B5C0KL6/FxiF0Tz5CVkKgrmJ4a6S/+cwfUqVqBX0P3 QCWeMkclClQs7v2BcCHIiiqG3GBiTYpPT9pj5lzKTWBfuQanRIzslSWhfczX3HRNCEsA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170695: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 08:30:47 +0000 flight 170695 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170695/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1183 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 71 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 09:10:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:10:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335614.559775 (Exim 4.92) (envelope-from ) id 1nt45I-00052Y-DN; Mon, 23 May 2022 09:10:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335614.559775; Mon, 23 May 2022 09:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt45I-00052R-AA; Mon, 23 May 2022 09:10:40 +0000 Received: by outflank-mailman (input) for mailman id 335614; Mon, 23 May 2022 09:10:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt45H-00052L-L7 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:10:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3496e104-da78-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:10:37 +0200 (CEST) Received: from mail-sn1anam02lp2045.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 05:10:31 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6344.namprd03.prod.outlook.com (2603:10b6:a03:395::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 09:10:27 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.022; Mon, 23 May 2022 09:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3496e104-da78-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653297038; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QmPYcP6Zo8r08YcSlqTd0sab6aSkDy9smRZc5NHTA4U=; b=Dp7oxfwXFJin2cKgJyFDXg3qmGB1661Pr0GYZnBUKbF9thOAoGCMyZB8 FgyOWIX+iELC0W7F/qDbQeGFFeeNGWOjNYqt0qAXicvbhw/fZd/++jvv6 UH/w9CxuoWunGbG7A/rD35Q4YWG/2MV2z6qxzWKLcB6uEN8nTQZUBpOgE o=; X-IronPort-RemoteIP: 104.47.57.45 X-IronPort-MID: 71785547 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kWNnDaOvoSmJ6yPvrR3flsFynXyQoLVcMsEvi/4bfWQNrUpz1jMOy 2FMXziBOPmCYjT2eo8gPtu1p0lU7J6HzodrQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NUw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z8 edEnsWUVBkTFKztgb8FDxZzSjl4IvgTkFPHCSDXXc276WTjKyGp+NM3SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtafHs0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx2SmiLmEHwL6TjaZm5FD63DVY7LHkF/zXfM3TeZxosX/N8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ kcIvC00osAa7EW2SvHtUhv+p2SL1jYDX/JAHut87xuCopc4+C6cD2kACyVHMdUgvcpuHzgyj AfVwpXuGCBlt6CTRTSF7LCIoDiuOC8Ta2gfeSsDSghD6N7myG0usi/yoh9YOPbdprXI9fvYm lhmcABWa20vsPM2 IronPort-HdrOrdr: A9a23:pRNFpKrgGmT0jwBLnhiPWGYaV5rbeYIsimQD101hICG9Kvbo8v xG785rsSMc6QxhJU3I9urgBEDtexnhHNtOkOss1NSZLXXbUQmTTL2KhLGKq1bd8m/Fh41gPM xbH5SWfeefMbEMt6nHCWeDfurJHLG8gd+VbKzlvhBQpElRGsddxg9pAgyfGldtRAZHD5IlFJ yaj/A33wZJJxksH72GL2hAVbPbvNvAmIj9bRMBHBBP0nj1sdqH0s+ALySl X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71785547" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MxsCX6vcFKt2K2w+h2FglrX4Rdan/ySQvWwQwCx2O7ZeoRG4GQ4rkRcHHn4hLzQgDVi9ZQshzsH2pebG/jwL9/cGHxSCkzmfonbazVkAYQqBGnNWx+xoh8ta+h+qneT/GGdUXMuqHbMfyyqs1H1f2/cdST7wvpSb0cd4IRFOcBRWl7uPY2FPAQwZs6+HQIg5nISb/l78k3cuOvhcj/CcAzNzHeLRZ4c7sIMH9Bh2TR3FoNhhFM/HYUv3XVZZ7U2MOaB47Ih5euSZDOsxZJs3RQDS93azYa0ahDm58V6kGAyOH9IizgFnoK+MctlDrBRxeJ15MkxTreuEOHJuPmjisw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SKJgNxPQt9o21Nwf5CUmDHwwizeC1rwiuNDaQvhGeW4=; b=Y9IBtViT5/0PR+hM4rtH7JDNEPOYh2JmEojjrJx2lF3q+PBEnljwHXk4kshSvlCaPcAtm+JZNR39jDFYuDDpSP7kmq94l7c8leQv9TrQGxx+gHRetc+4zEdwhGrJWC7gRDMRzS+D8ta5XPHu49qcRbMKRHnJ7CBBebbeDTsBNii/ZxZPxlcqkdWDonOFkWHbNDZ2flTRXiDlhrVKU3SH+mDne+IbiWEEz6o45Hgi2NXdL7b69/MhBNEkzAwTLVqIhDZ8AJbdNM2SsrJIf4Q00rDK4f81CjspC8hk3P+r9zNYTJba3648M3dQYkwOdECl7v2L8mN4XWfw9OPkxy8vkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SKJgNxPQt9o21Nwf5CUmDHwwizeC1rwiuNDaQvhGeW4=; b=qNibvKCqduTQz8bKpJVoI0ruQssc6W/sFUNvZGcHuc/W11Sa6it6g4rzBt98OtUqTFGkDprJneuLqF3cDnW+fkJONOmKsCsJ/EtdYYu7qoGgvMpLmLujFlrVSV2DAZXMT41bOz3N2CHz2jBy35T1EDqRigYvec2AbkhMklX2F9Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 11:10:22 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Message-ID: References: <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0126.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ffb5e64-dd08-4e2b-bbe4-08da3c9c138f X-MS-TrafficTypeDiagnostic: SJ0PR03MB6344:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yc1HKtc57ZcR0EMcViQkhQ+71Ob+FyWpEUqZTCCgoDVcu6CUZndTt6Fd0XtSpZSlZEnMaNSTeO2LJeKudhlgA++cxk1wZ36mz1s3b3wp/ffjfz+IOya4RBMwyl2PUOc+Okt8q/leC1FiUb6UtkDSqFRpdnEkVNoJOjRULzRDFpXS4Q/gwf9zwBdQi7eOagXugk+W91cE1EZzSjFTJwDyHll9cQ5j54uqUsP2kG/GJTedNd5+6ggq9BrLgzExZ7nBu507wJWMqIjnv0SZphPIQw8ZCpvXkwvEh5KuwU7rbhlX2vnJphO4HMQNwSWZTAzI3KLRA6nMoDWqbhESWMOs8ThewtmIvxd+Ec3ieSlJSDiDeCyhRKvxPofApy4OrTifrxNSbR7lWk7PyjvbIDvfFXlPdlhkVxb/Ik7duBAEYIe4kxmAoPXKkwTlGIGK7/k1qKwTO3xO9YdcXzcD1NhSJcYyejl1hRVowk5T1fXUArWzmw5ilx/nYaj/rBUFudCpZl2Qrhpvh6WzjiqGYbpFMH6Rj8UKlXesyPKYCmY+kiqwxWl71KLa8oQCS7Zg0c5yLMi/x59YReLNzloUv+LbZyQ/mAI0ZQTbfc6yqzZnCRDhdIps6Rdgly+QPiUkNAcwkR1s+7nzjiiEcew7oSma7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(83380400001)(508600001)(86362001)(6486002)(186003)(26005)(6512007)(2906002)(6506007)(9686003)(33716001)(38100700002)(66946007)(66476007)(66556008)(4326008)(8676002)(82960400001)(85182001)(8936002)(5660300002)(6666004)(316002)(6916009)(54906003)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVlHeWhoMytnazkydklKOUxuYWNnUE9KeFpFci9VRXNuWW1lZGRhbEhocHJD?= =?utf-8?B?T3BoUGNKV243RzhkVjhQNTJpUVJOT2NpUWZvclFVVCtGMS9IWkhiL055U2FI?= =?utf-8?B?Wm0vWmoycFlIcWVEVk9vMGRGS3RMVWdqeHV5RS9MTmZ0RmI0aXRGd242UkdL?= =?utf-8?B?RVNXVXRkTndFbUdObm5oWXNzUnA3NUU2aEsrOHBQY0txcGpYMUY3WldnM1Nm?= =?utf-8?B?MnhxeU93NFczSFo1MEx2alNUSm9zZ3p4cTJOUlMweCtZOStmQXZmY1RWUUtu?= =?utf-8?B?ZFd0TmJENUNIQWVteDZzVUF2dzRMUm9kR3RqNHNmUDZEdTlrZzY3S3dGcHRl?= =?utf-8?B?ZWYvbnM2TTVxSnRzdFEyVkIxK3hlRDNMeDEyYXUxblVHd21KSk1xdTBzMVBa?= =?utf-8?B?LzNxenFlSE9oZlcxdGRLQnFjRDhJc1JwTlhvNzB4RnVUOW9jdHlSanRDUjNI?= =?utf-8?B?alljdTNQN2I1VkZnbnZKQ2RKSWNwNTZTYjdWOERNUmtvdmZxcGF0SEVHSG5N?= =?utf-8?B?Zmd0Y2lHa08vdzFhS2dvVlVpZElLcnh2M0gvNHFaZ2ErOTlQY0xaalYxa1ph?= =?utf-8?B?VnUvSStaVy9NS3JsRmJjeTd0bjlPcGZvelhEN3hhQlc5VWJFc0d6dHY3M2RN?= =?utf-8?B?ZWZOWjlhcU1ndkY0c0dNdEVwSGtpM1hXaWVXRENIT1h4M1JLSzlVUnVCQlAv?= =?utf-8?B?Z0crdmlhQjUrS095d1RXQmZRdEs3NytPSlJnekVZa3ZQWHhCWldSVjNQcmR5?= =?utf-8?B?cGJPdC9MWnpIUTZXaGJpMWIrdU8xZXRhQTZUeWxqb3JzOUptUlFXRG5oZTR1?= =?utf-8?B?QTVyUnZFYnNKQWU3cy9zdGZCRlpJdmIyUkZsaWJ4M1g2WVl5N1laaHpEZWdQ?= =?utf-8?B?N2Vyc0NuZ2h4QnpmZjFHcW9qR1NGUTVuK21pM1BRb2tELzhRUmNPcjdhR2hu?= =?utf-8?B?NDRWakt2R0ZsSnM5Tk42eHRCeFl3QkVNMDBUTlRBbXJOelVPMGJPRkJkU0Rw?= =?utf-8?B?TWcvVlgxSlpXc0w3OFRQZFFzTnB2dFlsWUNGb0NnaW95WU5tWVBaYXlNaVRJ?= =?utf-8?B?Rm53STdoM2c4Z3ZJWXBIRFRIaUV1LzNydmc0aFhnMWN0Tm1vdnQxUC92Smtt?= =?utf-8?B?b1dscllHeFV4Z2I3dUc1QUY4MVRSUjNEQjJSaS9hYlZVQTBrWGl0NGNtbDVQ?= =?utf-8?B?OGRvZWpFcHhjTTNXYVFBenlSRmxuMU00b3pFTWVIQ29kNmNwdnpzSVRpa3hY?= =?utf-8?B?RnlBM3NJaWNReXg1OW44ZjBWRGFiYzR6RjI2TzU0T25NSHdyUENDbXBsWGp4?= =?utf-8?B?bXVXd0drVmN6dnhtamRZT3R3UEVZV2J1K3M0eHlIdU5BVDdxMm5tZGNMRnNq?= =?utf-8?B?OFhUS3UwaTZBOTUxN1luVlQzaEhDSml1dGFLdGJNTk5ZVCtmU0YyWVVINzZQ?= =?utf-8?B?UlpRcUtwaldKSGxZRzRRVTVqb2ljZUdWNklLdUdWT05rNllLaU56MnFQa3ZU?= =?utf-8?B?bmVIenZrdDRTQlpTQmZ1QmNsbFVoeXFvdUU3bFVnSFVZU0hpMU5FSTdVdFg3?= =?utf-8?B?QVlCYmpKZFBwUlB3Y3MxaWFoSVprbStRYmVRdVIrd296M1RzOEkrYVRkT0ll?= =?utf-8?B?ZFFqQmE5amttQWdTdjZselJQbmIxcEFrL3ZFaVYxeWVScENlRUh0RnlkK3dp?= =?utf-8?B?Tzk5SkozcVlJTDN3RVVUbFlycTFKeWJIbUoyQ3k1US9wNkd3cGZJN0ZOWi9r?= =?utf-8?B?ZHZuVGdTdkJLNE1xb3dBTmZvcURDYXV0L0R2Njkwb2Z0QmNhQ0x1cUxJaTdw?= =?utf-8?B?UXhvRWI4dE1maFIwYjRoc2ZBSmk2NEtKbEsyanowK3JJNENsOFZHY0FybFRo?= =?utf-8?B?aUM2NGpsWGU1cVU5QzRGU0pPd1pqelAzWTBORkdBRWtiT1NNVThOTDI2d1Nq?= =?utf-8?B?S0NRaXAzL0FhU2dqeUlLVUcwS3dxWHpzSGpPQ1pmbXg5M0FFK290djdPM3Zx?= =?utf-8?B?cmo5UlZUSjRDTStoSnVoNDI0VkQ3MGhlZ3RGdk1HRlhRN05Kdmp5cWcvdHJY?= =?utf-8?B?dUF2L1BuVlE2Tk9ZSTBVS1lEeWZEd1pSOUJta2xkZ3Q2cFhLTzRGSERPS1Rk?= =?utf-8?B?aC90WGVCZU1yT1AybVlKWk9EWmEyZHM0aHNKRUxZdzdjTVgxWU5YdS9MWnJ5?= =?utf-8?B?RFBUaTl1b1JQOWNFVTdaVkJFU25tSkw5RkE3WjdPVFZCS3NUM3dmaHU0MFBi?= =?utf-8?B?N2JlL0NvVUJUamJ5MlhxcEFFNG1IclFrWEZiNGMrb2Y1QVJoTXl3R0dxSmhO?= =?utf-8?B?Ty9zRUg3RUtzT3lmNmptT1lWOGlrN3BYdTVoZENyb0crRzZDWGwwVDNFUHRu?= =?utf-8?Q?iGA4zdWliJa56a6Y=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ffb5e64-dd08-4e2b-bbe4-08da3c9c138f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 09:10:26.9143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64z7/ondMcf1L5ounOAqmqv05FvJmRLWEQo+CE/MSJ44v3O31Apzoz0q1dWZuc5oT5zpmFwv8O2XxCf9qjO04g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6344 On Mon, May 23, 2022 at 08:49:27AM +0200, Jan Beulich wrote: > On 20.05.2022 16:38, Roger Pau Monné wrote: > > On Fri, May 20, 2022 at 04:28:14PM +0200, Roger Pau Monné wrote: > >> On Fri, May 20, 2022 at 02:36:02PM +0200, Jan Beulich wrote: > >>> On 20.05.2022 14:22, Roger Pau Monné wrote: > >>>> On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: > >>>>> On 20.05.2022 13:11, Jan Beulich wrote: > >>>>>> On 20.05.2022 12:47, Roger Pau Monné wrote: > >>>>>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: > >>>>>>>> On 06.05.2022 13:16, Roger Pau Monné wrote: > >>>>>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: > >>>>>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c > >>>>>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c > >>>>>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig > >>>>>>>>>> > >>>>>>>>>> while ( nr_ptes-- ) > >>>>>>>>>> { > >>>>>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); > >>>>>>>>>> + ASSERT(!pde->next_level); > >>>>>>>>>> + ASSERT(!pde->u); > >>>>>>>>>> + > >>>>>>>>>> + if ( pde > table ) > >>>>>>>>>> + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); > >>>>>>>>>> + else > >>>>>>>>>> + ASSERT(pde->ign0 == PAGE_SHIFT - 3); > >>>>>>>>> > >>>>>>>>> I think PAGETABLE_ORDER would be clearer here. > >>>>>>>> > >>>>>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not used anywhere > >>>>>>>> in IOMMU code afaics. > >>>>>>> > >>>>>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm not > >>>>>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use in > >>>>>>> IOMMU code but not PAGETABLE_ORDER. > >>>>>> > >>>>>> Hmm, yes and no. But for consistency with other IOMMU code I may want > >>>>>> to switch to PAGE_SHIFT_4K. > >>>>> > >>>>> Except that, with the plan to re-use pt_update_contig_markers() for CPU- > >>>>> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. > >>>> > >>>> Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? > >>> > >>> pt_update_contig_markers() isn't IOMMU code; since I've said I'd switch > >>> to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I could > >>> at the same time start using PAGETABLE_ORDER there. > >> > >> I've got confused by the double reply and read it as if you where > >> going to stick to using PAGE_SHIFT everywhere as proposed originally. > >> > >>> What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and > >>> LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correct/ > >>> consistent, ... > >>> > >>>> IMO it makes the code quite easier to understand. > >>> > >>> ... or in fact helping readability. > >> > >> Looking at pt_update_contig_markers() we hardcode CONTIG_LEVEL_SHIFT > >> to 9 there, which means all users must have a page table order of 9. > >> > >> It seems to me we are just making things more complicated than > >> necessary by trying to avoid dependencies between CPU and IOMMU > >> page-table sizes and definitions, when the underlying mechanism to set > >> ->ign0 has those assumptions baked in. > >> > >> Would it help if you introduced a PAGE_TABLE_ORDER in page-defs.h? > > > > Sorry, should be PAGE_TABLE_ORDER_4K. > > Oh, good that I looked here before replying to the earlier mail: I'm > afraid I view PAGE_TABLE_ORDER_4K as not very useful. From an > abstract POV, what is the base unit meant to be that the order is > is based upon? PAGE_SHIFT? Or PAGE_SHIFT_4K? I think such an > ambiguity is going to remain even if we very clearly spelled out what > we mean things to be, as one would always need to go back to that > comment to check which of the two possible ways it is. > > Furthermore I'm not convinced PAGETABLE_ORDER is really meant to be > associated with a particular page size anyway: PAGE_TABLE_ORDER_2M > imo makes no sense at all. And page-defs.h is not supposed to > express any platform properties anyway, it's merely an accumulation > of (believed) useful constants. > > Hence the only thing which I might see as a (remote) option is > IOMMU_PAGE_TABLE_ORDER (for platforms where all IOMMU variants have > all page table levels using identical sizes, which isn't a given, but > which would hold for x86 and hence for the purpose here). Since you already define a page table order in pt-contig-markers.h (CONTIG_NR) it might be possible to export and use that? In fact the check done here would be even more accurate if it was done using the same constant that's used in pt_update_contig_markers(), because the purpose here is to check that the vendor specific code to init the page tables has used the correct value. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 09:13:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:13:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335623.559785 (Exim 4.92) (envelope-from ) id 1nt48E-0005jH-VL; Mon, 23 May 2022 09:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335623.559785; Mon, 23 May 2022 09:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt48E-0005jA-Sl; Mon, 23 May 2022 09:13:42 +0000 Received: by outflank-mailman (input) for mailman id 335623; Mon, 23 May 2022 09:13:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt48D-0005j4-J8 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:13:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a244e8a8-da78-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:13:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34C95ED1; Mon, 23 May 2022 02:13:39 -0700 (PDT) Received: from e129167.arm.com (unknown [10.57.7.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDC263F73D; Mon, 23 May 2022 02:13:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a244e8a8-da78-11ec-837e-e5687231ffcc From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Date: Mon, 23 May 2022 11:13:24 +0200 Message-Id: <20220523091324.137350-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a command line parameter "maxcpus" on Arm to allow adjusting the number of CPUs to activate. Currently the limit is defined by the config option CONFIG_NR_CPUS. Such parameter already exists on x86. Define a parameter "maxcpus" and a corresponding static variable max_cpus in Arm smpboot.c. Modify function smp_get_max_cpus to take max_cpus as a limit and to return proper unsigned int instead of int. Take the opportunity to remove redundant variable cpus from start_xen function and to directly assign the return value from smp_get_max_cpus to nr_cpu_ids (global variable in Xen used to store the number of CPUs actually activated). Signed-off-by: Michal Orzel --- max_cpus is also defined in x86 setup.c. It would be possible to join these definitions in xen/common/cpu.c. However in that case, max_cpus would become global which is not really what we want. There is already global nr_cpu_ids used everywhere and max_cpus being used only in x86 start_xen and Arm smp_get_max_cpus should be kept local. Also there are already lots of places in Xen using max_cpus (local versions) and that would start to be hard to read (variable shadowing). --- docs/misc/xen-command-line.pandoc | 2 +- xen/arch/arm/include/asm/smp.h | 2 +- xen/arch/arm/setup.c | 10 ++++------ xen/arch/arm/smpboot.c | 18 ++++++++++++------ 4 files changed, 18 insertions(+), 14 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1dc7e1ca07..a40d0ae2e8 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1651,7 +1651,7 @@ with **crashinfo_maxaddr**. Specify the threshold below which Xen will inform dom0 that the quantity of free memory is getting low. Specifying `0` will disable this notification. -### maxcpus (x86) +### maxcpus > `= ` Specify the maximum number of CPUs that should be brought up. diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h index 83c0cd6976..8133d5c295 100644 --- a/xen/arch/arm/include/asm/smp.h +++ b/xen/arch/arm/include/asm/smp.h @@ -33,7 +33,7 @@ extern void init_secondary(void); extern void smp_init_cpus(void); extern void smp_clear_cpu_maps (void); -extern int smp_get_max_cpus (void); +extern unsigned int smp_get_max_cpus(void); #define cpu_physical_id(cpu) cpu_logical_map(cpu) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed4..b8d97950b7 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -862,11 +862,10 @@ void __init start_xen(unsigned long boot_phys_offset, unsigned long fdt_paddr) { size_t fdt_size; - int cpus, i; const char *cmdline; struct bootmodule *xen_bootmodule; struct domain *d; - int rc; + int rc, i; dcache_line_bytes = read_dcache_line_bytes(); @@ -942,9 +941,8 @@ void __init start_xen(unsigned long boot_phys_offset, processor_id(); smp_init_cpus(); - cpus = smp_get_max_cpus(); - printk(XENLOG_INFO "SMP: Allowing %u CPUs\n", cpus); - nr_cpu_ids = cpus; + nr_cpu_ids = smp_get_max_cpus(); + printk(XENLOG_INFO "SMP: Allowing %u CPUs\n", nr_cpu_ids); /* * Some errata relies on SMCCC version which is detected by psci_init() @@ -988,7 +986,7 @@ void __init start_xen(unsigned long boot_phys_offset, for_each_present_cpu ( i ) { - if ( (num_online_cpus() < cpus) && !cpu_online(i) ) + if ( (num_online_cpus() < nr_cpu_ids) && !cpu_online(i) ) { int ret = cpu_up(i); if ( ret != 0 ) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 9bb32a301a..22fede6600 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -43,6 +43,10 @@ cpumask_t cpu_possible_map; struct cpuinfo_arm cpu_data[NR_CPUS]; +/* maxcpus: maximum number of CPUs to activate. */ +static unsigned int __initdata max_cpus; +integer_param("maxcpus", max_cpus); + /* CPU logical map: map xen cpuid to an MPIDR */ register_t __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = MPIDR_INVALID }; @@ -277,16 +281,18 @@ void __init smp_init_cpus(void) "unless the cpu affinity of all domains is specified.\n"); } -int __init -smp_get_max_cpus (void) +unsigned int __init smp_get_max_cpus(void) { - int i, max_cpus = 0; + unsigned int i, cpus = 0; + + if ( ( !max_cpus ) || ( max_cpus > nr_cpu_ids ) ) + max_cpus = nr_cpu_ids; - for ( i = 0; i < nr_cpu_ids; i++ ) + for ( i = 0; i < max_cpus; i++ ) if ( cpu_possible(i) ) - max_cpus++; + cpus++; - return max_cpus; + return cpus; } void __init -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:17:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:17:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335632.559797 (Exim 4.92) (envelope-from ) id 1nt4By-0006LU-Gd; Mon, 23 May 2022 09:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335632.559797; Mon, 23 May 2022 09:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4By-0006LN-Cy; Mon, 23 May 2022 09:17:34 +0000 Received: by outflank-mailman (input) for mailman id 335632; Mon, 23 May 2022 09:17:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4Bw-0006LD-WE; Mon, 23 May 2022 09:17:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4Bw-0003pq-Sa; Mon, 23 May 2022 09:17:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4Bw-0007Mi-Km; Mon, 23 May 2022 09:17:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt4Bw-0008DU-KM; Mon, 23 May 2022 09:17:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QXUmv9xtedIhZg8OXW/bkFitaIsOhWIcFldX/XLtFuY=; b=4+VOhJL++YLPdWhfgZzFDtOlB1 pr1D3o7vtWhYiYoNciZE1KJLnFLOkFDiSoZYjDUIfUUoq3paWKmCD6UwWBeOyvUZ187EH+ttCSOm+ CwC50dXVn9e3UDlCMYURrwGUKDg8eMAesPwpHPxEf2gVRASCae6910tvbdJf8LelBXIM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170690: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=42cb54804588aa82e32219fc56c15817f8b1edb0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 23 May 2022 09:17:32 +0000 flight 170690 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 42cb54804588aa82e32219fc56c15817f8b1edb0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 682 days Failing since 151818 2020-07-11 04:18:52 Z 681 days 663 attempts Testing same since 170624 2022-05-21 04:18:50 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 108861 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 09:30:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:30:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335643.559808 (Exim 4.92) (envelope-from ) id 1nt4O9-0000Av-Nf; Mon, 23 May 2022 09:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335643.559808; Mon, 23 May 2022 09:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4O9-0000Ao-J3; Mon, 23 May 2022 09:30:09 +0000 Received: by outflank-mailman (input) for mailman id 335643; Mon, 23 May 2022 09:30:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4O8-0000Ae-0L; Mon, 23 May 2022 09:30:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4O7-00042U-Tk; Mon, 23 May 2022 09:30:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4O7-0007dD-Gk; Mon, 23 May 2022 09:30:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt4O7-0003oI-GJ; Mon, 23 May 2022 09:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aYHOvyWBpSI/yw/Tg/XvGrrpEKx88w8Mw+6GdtyrDtY=; b=qKpO3rxX7qf+jGkhEnS4oSgPrd ltB722RJ9+2NlDbf5K7qHmEufw0RMin3Nyg8u7LF3tK6EDq2kyj/TqJttGkYu9b3F8txjWzEvkgpR jT1eo0VkoEMb+/srsgk5ubQ6Nc6OXEN5g7sVY2bzr6AR2VdOyUtbpOg8MLQLrRVR0Ldk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170696: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 09:30:07 +0000 flight 170696 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170696/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1184 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 72 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335658.559853 (Exim 4.92) (envelope-from ) id 1nt4k6-0003Kr-2Y; Mon, 23 May 2022 09:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335658.559853; Mon, 23 May 2022 09:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k5-0003Ip-Qw; Mon, 23 May 2022 09:52:49 +0000 Received: by outflank-mailman (input) for mailman id 335658; Mon, 23 May 2022 09:52:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k4-0002dp-3K for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:48 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 182efc9e-da7e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:52:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 182efc9e-da7e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299565; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PIpXZNS/tomnFn9AY0+D+Gnk6UU+fhiL/46ZWzyvQm8=; b=CzZPOP/xt3g7MVprCG/6/Q6FBMqKgUlrOx/69ekjQmRVXp3PqvZ69z0a mjxFjYN7VE5VJP4r/A//mdoaDoWEdp6AaKK5aTDDzniGnu40srDrJk+F4 1KIzeCIZ3imrWpJgqCM842/eJ/X40WhDrEA450qaJj8MDtBUJzED7zFhL 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74445149 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LmU+9auhBGPlsTlAxMhLRG8udufnVEdeMUV32f8akzHdYApBsoF/q tZmKWCBM/2LYDake9l1atm2o0tXupLXzNNkHgZkqS8zQy1H+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X4 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8ZGIfXo/Q5bSJXKC4kE790wJn6eymg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllkzDefCfc7aZvCX7/L9ZlT2zJYasVmQqqCO 5dANWsHgBLoeB5EPmUQK8oEsdyhgHr5TxdBlxWxnP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco mPA/kz6DwscOdjZziCKmlqum+vOkCXTSI8UUrqi+ZZCn1m71mEVThoMWjOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwAsRDNbdMYvssNwQDUwz 0KIhPvgHzkpu7qQIU9x7Z/N82n0Y3JMazZfO2lUFmPp/uUPvqkDqDjUdcZHLpW6tdKvNyPC+ xa39nkh0uB7YdEw60mrwbzWq2vy+8OTFV5lvV+/snGNtV0gOtP8D2C8wR2CtKsbct7EJrWUl CJc8/Vy+tziGn1keMalZOwWVI+k6P+eWNE3qQ4+RsJxn9hBFpPKQGyx3N2dDB0wWir8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66JNYASPsQoLlferEmCgHJ8OEi0zSARfVwXY 8/HIa5A815EYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PRaopUM+GALWNIgRtfrcyC2Mq oY3H5bbkH13DbyhChQ7BKZOdDjm21BgXcCowyGWH8beSjdb9JYJUK+Aneh7ItU690mX/8+Rl kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:iFmkQqolqa4LfMCLd2rCiLgaV5oTeYIsimQD101hICG8cqSj+f xG+85rsyMc6QxhIE3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaTN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="74445149" From: Lin Liu To: CC: Lin Liu , Jan Beulich , "Andrew Cooper" , George Dunlap , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: [PATCH v4 2/6] crypto/vmac: Simplify code with byteswap Date: Mon, 23 May 2022 05:52:18 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This file has its own implementation of swap bytes. Clean up the code with xen/byteswap.h. No functional change. Signed-off-by: Lin Liu Acked-by: Jan Beulich Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Bertrand Marquis Cc: Stefano Stabellini Cc: Wei Liu ---- xen/crypto/vmac.c | 76 ++--------------------------------------------- 1 file changed, 3 insertions(+), 73 deletions(-) diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index 294dd16a52..acb4e015f5 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -8,6 +8,7 @@ /* start for Xen */ #include +#include #include #include #include @@ -50,7 +51,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ * MUL64: 64x64->128-bit multiplication * PMUL64: assumes top bits cleared on inputs * ADD128: 128x128->128-bit addition - * GET_REVERSED_64: load and byte-reverse 64-bit word * ----------------------------------------------------------------------- */ /* ----------------------------------------------------------------------- */ @@ -68,22 +68,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({uint64_t x; \ - asm ("bswapq %0" : "=r" (x) : "0"(*(uint64_t *)(p))); x;}) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && __i386__) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint64_t x; \ - uint32_t *tp = (uint32_t *)(p); \ - asm ("bswap %%edx\n\t" \ - "bswap %%eax" \ - : "=A"(x) \ - : "a"(tp[1]), "d"(tp[0])); \ - x; }) /* ----------------------------------------------------------------------- */ #elif (__GNUC__ && __ppc64__) @@ -103,37 +87,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ppc__ || __PPC__)) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ARMEL__ || __ARM__)) -/* ----------------------------------------------------------------------- */ - -#define bswap32(v) \ -({ uint32_t tmp,out; \ - asm volatile( \ - "eor %1, %2, %2, ror #16\n" \ - "bic %1, %1, #0x00ff0000\n" \ - "mov %0, %2, ror #8\n" \ - "eor %0, %0, %1, lsr #8" \ - : "=r" (out), "=&r" (tmp) \ - : "r" (v)); \ - out;}) - /* ----------------------------------------------------------------------- */ #elif _MSC_VER /* ----------------------------------------------------------------------- */ @@ -154,11 +107,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ (rh) += (ih) + ((rl) < (_il)); \ } -#if _MSC_VER >= 1300 -#define GET_REVERSED_64(p) _byteswap_uint64(*(uint64_t *)(p)) -#pragma intrinsic(_byteswap_uint64) -#endif - #if _MSC_VER >= 1400 && \ (!defined(__INTEL_COMPILER) || __INTEL_COMPILER >= 1000) #define MUL32(i1,i2) (__emulu((uint32_t)(i1),(uint32_t)(i2))) @@ -219,24 +167,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ } #endif -#ifndef GET_REVERSED_64 -#ifndef bswap64 -#ifndef bswap32 -#define bswap32(x) \ - ({ uint32_t bsx = (x); \ - ((((bsx) & 0xff000000u) >> 24) | (((bsx) & 0x00ff0000u) >> 8) | \ - (((bsx) & 0x0000ff00u) << 8) | (((bsx) & 0x000000ffu) << 24)); }) -#endif -#define bswap64(x) \ - ({ union { uint64_t ll; uint32_t l[2]; } w, r; \ - w.ll = (x); \ - r.l[0] = bswap32 (w.l[1]); \ - r.l[1] = bswap32 (w.l[0]); \ - r.ll; }) -#endif -#define GET_REVERSED_64(p) bswap64(*(uint64_t *)(p)) -#endif - /* ----------------------------------------------------------------------- */ #if (VMAC_PREFER_BIG_ENDIAN) @@ -247,9 +177,9 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #if (VMAC_ARCH_BIG_ENDIAN) # define get64BE(ptr) (*(uint64_t *)(ptr)) -# define get64LE(ptr) GET_REVERSED_64(ptr) +# define get64LE(ptr) bswap64(*(uint64_t *)(ptr)) #else /* assume little-endian */ -# define get64BE(ptr) GET_REVERSED_64(ptr) +# define get64BE(ptr) bswap64(*(uint64_t *)(ptr)) # define get64LE(ptr) (*(uint64_t *)(ptr)) #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335657.559847 (Exim 4.92) (envelope-from ) id 1nt4k5-0003Cf-Ks; Mon, 23 May 2022 09:52:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335657.559847; Mon, 23 May 2022 09:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k5-0003Bl-Dy; Mon, 23 May 2022 09:52:49 +0000 Received: by outflank-mailman (input) for mailman id 335657; Mon, 23 May 2022 09:52:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k3-0002dp-Ih for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16ab978c-da7e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:52:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16ab978c-da7e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=++cTDuCI2eUXrno3sLGrk+Z0rJmvgXXtlDQhmlqs4d8=; b=Ekg2mjOdfnMeNaz9GQ7soDSqN01naxIyr0zR6QQmK8KUxSn2c8iLF32U xnoZZ2RS7mDaPiM8mXZiTyjDtIXA38zH7p9XShqo7brg+3yOBdKx6wAbo /XxIv5PeRMpkXPZRCBj+iZJFIMv/5uoikST7N66F2pCzTPYeLirup8k61 M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71298197 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Bagp7qPJz19mqCrvrR20l8FynXyQoLVcMsEvi/4bfWQNrUp0hTAPz zYWWT2FbqmDZDSgedEgOYqwoRhV75XRyd9kTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NUw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0 v9t77agUioVF4rSuNQFfyVyKCdMBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYABhmZg35ERdRrYT 4kUM2JkS0//WRdwfXUcE5IPveuDjXaqJlW0r3rK/PFqsgA/1jdZ0rLgLd7UcdyiXthOkwCTo Weu12bkBhAXMvSPxDzD9Wij7sfQmQvrVYRUE6e3ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FewUtD3Uhm8oXiFlh0RQdxdF6s98g7l4qDZ+RqDD24ICDtIcsU7tdQeTCYvk FSOmrvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsVyElufPzu6wPpzXRbuZ7PJKftdvHIGSlq 9yVlxTSl4n/nOZSifjgpwuX02n2znTaZlVrv1uKBwpJ+is8Pdf4PNLwtDA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGFb5JOi8GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510kPO6SYi5D6qMN4omjn1NmOivpXwGWKJt9zq1zBhEfV8XZ /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcmT8vhT6pLHPCT9Ye5caDOmN7lphIvZ8V692 4sOaKO3J+B3DbSWjt//qtZDczjn7BETWPjLliCgXrXTc1Y9Qjh4VJc8A9oJIuRYokicrc+Ql lnVZ6OS4ACXaaHvQelSVk1eVQ== IronPort-HdrOrdr: A9a23:UywuyaitvpBc9ry8dDDEPQ623nBQXuAji2hC6mlwRA09TySZ// rOoB19726MtN9xYgBapTnuAtjifZqxz/FICMwqTNOftWrdyQ2VxeNZnOnfKlTbckWUnIMw6U 4jSdkYNDSZNykDsS+Q2mmF+rgbruVviJrY4Nvj8w== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71298197" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v4 4/6] xen: Switch to byteswap Date: Mon, 23 May 2022 05:52:20 -0400 Message-ID: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Update to use byteswap to swap bytes. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Changes in v4: - Revert the __force in type casting Changes in v3: - Update xen/common/device_tree.c to use be32_to_cpu - Keep const in type cast in unaligned.h --- xen/common/device_tree.c | 44 +++++++++++++++--------------- xen/common/libelf/libelf-private.h | 6 ++-- xen/common/xz/private.h | 2 +- xen/include/xen/unaligned.h | 12 ++++---- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..70d3be3be6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, if ( !val || len < sizeof(*out_value) ) return 0; - *out_value = be32_to_cpup(val); + *out_value = be32_to_cpu(*val); return 1; } @@ -264,7 +264,7 @@ int dt_property_read_variable_u32_array(const struct dt_device_node *np, count = sz; while ( count-- ) - *out_values++ = be32_to_cpup(val++); + *out_values++ = be32_to_cpu(*val++); return sz; } @@ -490,7 +490,7 @@ static int __dt_n_addr_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#address-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_ADDR_CELLS_DEFAULT; @@ -507,7 +507,7 @@ int __dt_n_size_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#size-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_SIZE_CELLS_DEFAULT; @@ -660,7 +660,7 @@ static void dt_bus_pci_count_cells(const struct dt_device_node *np, static unsigned int dt_bus_pci_get_flags(const __be32 *addr) { unsigned int flags = 0; - u32 w = be32_to_cpup(addr); + u32 w = be32_to_cpu(*addr); switch((w >> 24) & 0x03) { case 0x01: @@ -1077,7 +1077,7 @@ dt_irq_find_parent(const struct dt_device_node *child) if ( parp == NULL ) p = dt_get_parent(child); else - p = dt_find_node_by_phandle(be32_to_cpup(parp)); + p = dt_find_node_by_phandle(be32_to_cpu(*parp)); child = p; } while ( p && dt_get_property(p, "#interrupt-cells", NULL) == NULL ); @@ -1110,7 +1110,7 @@ unsigned int dt_number_of_irq(const struct dt_device_node *device) intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1241,7 +1241,7 @@ int dt_for_each_irq_map(const struct dt_device_node *dev, imaplen -= addrsize + intsize; /* Get the interrupt parent */ - ipar = dt_find_node_by_phandle(be32_to_cpup(imap)); + ipar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1358,8 +1358,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, int match, i; dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n", - parent->full_name, be32_to_cpup(intspec), - be32_to_cpup(intspec + 1), ointsize); + parent->full_name, be32_to_cpu(*intspec), + be32_to_cpu(*(intspec+1)), ointsize); ipar = parent; @@ -1471,7 +1471,7 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, dt_dprintk(" -> match=%d (imaplen=%d)\n", match, imaplen); /* Get the interrupt parent */ - newpar = dt_find_node_by_phandle(be32_to_cpup(imap)); + newpar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1565,7 +1565,7 @@ int dt_device_get_raw_irq(const struct dt_device_node *device, intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1676,7 +1676,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, * If phandle is 0, then it is an empty entry with no * arguments. Skip forward to the next entry. * */ - phandle = be32_to_cpup(list++); + phandle = be32_to_cpu(*list++); if ( phandle ) { /* @@ -1745,7 +1745,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, out_args->np = node; out_args->args_count = count; for ( i = 0; i < count; i++ ) - out_args->args[i] = be32_to_cpup(list++); + out_args->args[i] = be32_to_cpu(*list++); } /* Found it! return success */ @@ -1826,7 +1826,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, int has_name = 0; int new_format = 0; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag != FDT_BEGIN_NODE ) { printk(XENLOG_WARNING "Weird tag at start of node: %x\n", tag); @@ -1919,7 +1919,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, u32 sz, noff; const char *pname; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag == FDT_NOP ) { *p += 4; @@ -1928,8 +1928,8 @@ static unsigned long __init unflatten_dt_node(const void *fdt, if ( tag != FDT_PROP ) break; *p += 4; - sz = be32_to_cpup((__be32 *)(*p)); - noff = be32_to_cpup((__be32 *)((*p) + 4)); + sz = be32_to_cpu(*(__be32 *)(*p)); + noff = be32_to_cpu(*(__be32 *)((*p) + 4)); *p += 8; if ( fdt_version(fdt) < 0x10 ) *p = ROUNDUP(*p, sz >= 8 ? 8 : 4); @@ -1956,13 +1956,13 @@ static unsigned long __init unflatten_dt_node(const void *fdt, (strcmp(pname, "linux,phandle") == 0) ) { if ( np->phandle == 0 ) - np->phandle = be32_to_cpup((__be32*)*p); + np->phandle = be32_to_cpu(*(__be32*)*p); } /* And we process the "ibm,phandle" property * used in pSeries dynamic device tree * stuff */ if ( strcmp(pname, "ibm,phandle") == 0 ) - np->phandle = be32_to_cpup((__be32 *)*p); + np->phandle = be32_to_cpu(*(__be32 *)*p); pp->name = pname; pp->length = sz; pp->value = (void *)*p; @@ -2034,7 +2034,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, *p += 4; else mem = unflatten_dt_node(fdt, mem, p, np, allnextpp, fpsize); - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); } if ( tag != FDT_END_NODE ) { @@ -2086,7 +2086,7 @@ static void __init __unflatten_device_tree(const void *fdt, /* Second pass, do actual unflattening */ start = ((unsigned long)fdt) + fdt_off_dt_struct(fdt); unflatten_dt_node(fdt, mem, &start, NULL, &allnextp, 0); - if ( be32_to_cpup((__be32 *)start) != FDT_END ) + if ( be32_to_cpu(*(__be32 *)start) != FDT_END ) printk(XENLOG_WARNING "Weird tag at end of tree: %08x\n", *((u32 *)start)); if ( be32_to_cpu(((__be32 *)mem)[size / 4]) != 0xdeadbeef ) diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h index 47db679966..6062598fb8 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -31,9 +31,9 @@ printk(fmt, ## args ) #define strtoull(str, end, base) simple_strtoull(str, end, base) -#define bswap_16(x) swab16(x) -#define bswap_32(x) swab32(x) -#define bswap_64(x) swab64(x) +#define bswap_16(x) bswap16(x) +#define bswap_32(x) bswap32(x) +#define bswap_64(x) bswap64(x) #else /* !__XEN__ */ diff --git a/xen/common/xz/private.h b/xen/common/xz/private.h index 511343fcc2..97131fa714 100644 --- a/xen/common/xz/private.h +++ b/xen/common/xz/private.h @@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p) #endif -#define get_le32(p) le32_to_cpup((const uint32_t *)(p)) +#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p)) #define false 0 #define true 1 diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..56807bd157 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -20,7 +20,7 @@ static inline uint16_t get_unaligned_be16(const void *p) { - return be16_to_cpup(p); + return be16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_be16(uint16_t val, void *p) @@ -30,7 +30,7 @@ static inline void put_unaligned_be16(uint16_t val, void *p) static inline uint32_t get_unaligned_be32(const void *p) { - return be32_to_cpup(p); + return be32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_be32(uint32_t val, void *p) @@ -40,7 +40,7 @@ static inline void put_unaligned_be32(uint32_t val, void *p) static inline uint64_t get_unaligned_be64(const void *p) { - return be64_to_cpup(p); + return be64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_be64(uint64_t val, void *p) @@ -50,7 +50,7 @@ static inline void put_unaligned_be64(uint64_t val, void *p) static inline uint16_t get_unaligned_le16(const void *p) { - return le16_to_cpup(p); + return le16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_le16(uint16_t val, void *p) @@ -60,7 +60,7 @@ static inline void put_unaligned_le16(uint16_t val, void *p) static inline uint32_t get_unaligned_le32(const void *p) { - return le32_to_cpup(p); + return le32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_le32(uint32_t val, void *p) @@ -70,7 +70,7 @@ static inline void put_unaligned_le32(uint32_t val, void *p) static inline uint64_t get_unaligned_le64(const void *p) { - return le64_to_cpup(p); + return le64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_le64(uint64_t val, void *p) -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335660.559885 (Exim 4.92) (envelope-from ) id 1nt4kD-0004PS-2t; Mon, 23 May 2022 09:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335660.559885; Mon, 23 May 2022 09:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4kC-0004PJ-Tp; Mon, 23 May 2022 09:52:56 +0000 Received: by outflank-mailman (input) for mailman id 335660; Mon, 23 May 2022 09:52:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4kB-0002dq-3N for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:55 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bf98f02-da7e-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 11:52:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bf98f02-da7e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299573; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ENKGHyqakgatMFXhjwFCV+ZEI5TqFZ1FQ890jq+2cI4=; b=O6o4MRDHBc5v+CjikR3vegbYg6GkLXYXTiXZ5FEb2ROOfkgnfDsQ4pNF +P9z7pVv1Hnk/foFnsKt+6MDBwm+352KsJE74R3SbpNqUQCUjWe/2HFWV pkZpDxs52wHSwTqIpWHp7/YV2J6z1h+BAdSTiB03fawlqImS1c/Hq/xGv I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72327724 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:D4y7FqLsZsgLmUGEFE+RwJUlxSXFcZb7ZxGr2PjKsXjdYENShjEOn WVMXDrXbvzbNmqjc990b46//EoCuJSGz9RiS1FlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qz2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 OVMipeAY1kRArfvws1afBgAPgx9YbITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBM3qOsUbu2xIxjDFF/c2B5vERs0m4PcHhmxq2Z8UQZ4yY eI6Q2pWaRf/RCdNAX4JJc8wh8mvoGXWJmgwRFW9+vNsvjm7IBZK+KP2LNPfd9iORMNUtkWVv GTL+yL+GB5yHN6CzTuI9Fq8i+mJmjn0MKoNEJWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdx+yrWOAvxUcc8FNCOB84waIooLe7hyFHGECQnhEYcY/qc4tbTUw0 xmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZTsE3NLTit8LsgjsFP8kP6/to/D2RS6ll lhmsxMCa6UvYd8jjvvmpgqc02L3/PAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9k4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/W7T4i5CqmONoMeCnSUSONg1HgzDXN8Iki3yBR8+U3BE cnznTmQ4YYyVv08kWveqxY12r433CEurV4/triipylLJYG2PSbPIZ9caQPmRrlgvMus/VSOm /4CZpTi9vmqeLCnCsUh2dVLfQ5iwLlSLc2elvG7gcbYcls6Qzt4UqC5LHFIU9UNopm5X9zgp hmVMnK0AnKi7ZEbAW1mskxeVY4= IronPort-HdrOrdr: A9a23:9UCHSqAf2AdXZbXlHemW55DYdb4zR+YMi2TC1yhKKCC9Ffbo7v xG/c5rriMc5wxhO03I9eruBEDEewK5yXcX2/h2AV7BZniFhILAFugLhuGOrwEIWReOkdK1vZ 0QC5SWY+eRMbEVt6jHCXGDYrMd/OU= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="72327724" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: [PATCH v4 6/6] byteorder: Remove byteorder Date: Mon, 23 May 2022 05:52:22 -0400 Message-ID: <8c025497fb679c92e33c036caa705d23ffd18fbb.1653295437.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain include/xen/byteswap.h has simplify the interface, just clean the old interface No functional change Signed-off-by: Lin Liu Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Bertrand Marquis Cc: Stefano Stabellini Cc: Wei Liu --- xen/include/xen/byteorder/big_endian.h | 102 ------------ xen/include/xen/byteorder/generic.h | 68 -------- xen/include/xen/byteorder/little_endian.h | 102 ------------ xen/include/xen/byteorder/swab.h | 183 ---------------------- 4 files changed, 455 deletions(-) delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h diff --git a/xen/include/xen/byteorder/big_endian.h b/xen/include/xen/byteorder/big_endian.h deleted file mode 100644 index 40eb80a390..0000000000 --- a/xen/include/xen/byteorder/big_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_BIG_ENDIAN_H__ -#define __XEN_BYTEORDER_BIG_ENDIAN_H__ - -#ifndef __BIG_ENDIAN -#define __BIG_ENDIAN 4321 -#endif -#ifndef __BIG_ENDIAN_BITFIELD -#define __BIG_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)___constant_swab64((x))) -#define __constant_le64_to_cpu(x) ___constant_swab64((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)___constant_swab32((x))) -#define __constant_le32_to_cpu(x) ___constant_swab32((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)___constant_swab16((x))) -#define __constant_le16_to_cpu(x) ___constant_swab16((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)__swab64((x))) -#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)__swab32((x))) -#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)__swab16((x))) -#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __be16_to_cpu(x) ((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)__swab64p(p); -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)__swab32p(p); -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)__swab16p(p); -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return __swab16p((__u16 *)p); -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)*p; -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return (__force __u64)*p; -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)*p; -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return (__force __u32)*p; -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)*p; -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return (__force __u16)*p; -} -#define __cpu_to_le64s(x) __swab64s((x)) -#define __le64_to_cpus(x) __swab64s((x)) -#define __cpu_to_le32s(x) __swab32s((x)) -#define __le32_to_cpus(x) __swab32s((x)) -#define __cpu_to_le16s(x) __swab16s((x)) -#define __le16_to_cpus(x) __swab16s((x)) -#define __cpu_to_be64s(x) do {} while (0) -#define __be64_to_cpus(x) do {} while (0) -#define __cpu_to_be32s(x) do {} while (0) -#define __be32_to_cpus(x) do {} while (0) -#define __cpu_to_be16s(x) do {} while (0) -#define __be16_to_cpus(x) do {} while (0) - -#include - -#endif /* __XEN_BYTEORDER_BIG_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/generic.h b/xen/include/xen/byteorder/generic.h deleted file mode 100644 index 8a0006b755..0000000000 --- a/xen/include/xen/byteorder/generic.h +++ /dev/null @@ -1,68 +0,0 @@ -#ifndef __XEN_BYTEORDER_GENERIC_H__ -#define __XEN_BYTEORDER_GENERIC_H__ - -/* - * Generic Byte-reordering support - * - * The "... p" macros, like le64_to_cpup, can be used with pointers - * to unaligned data, but there will be a performance penalty on - * some architectures. Use get_unaligned for unaligned data. - * - * The following macros are to be defined by : - * - * Conversion of XX-bit integers (16- 32- or 64-) - * between native CPU format and little/big endian format - * 64-bit stuff only defined for proper architectures - * cpu_to_[bl]eXX(__uXX x) - * [bl]eXX_to_cpu(__uXX x) - * - * The same, but takes a pointer to the value to convert - * cpu_to_[bl]eXXp(__uXX x) - * [bl]eXX_to_cpup(__uXX x) - * - * The same, but change in situ - * cpu_to_[bl]eXXs(__uXX x) - * [bl]eXX_to_cpus(__uXX x) - * - * See asm-foo/byteorder.h for examples of how to provide - * architecture-optimized versions - */ - -#define cpu_to_le64 __cpu_to_le64 -#define le64_to_cpu __le64_to_cpu -#define cpu_to_le32 __cpu_to_le32 -#define le32_to_cpu __le32_to_cpu -#define cpu_to_le16 __cpu_to_le16 -#define le16_to_cpu __le16_to_cpu -#define cpu_to_be64 __cpu_to_be64 -#define be64_to_cpu __be64_to_cpu -#define cpu_to_be32 __cpu_to_be32 -#define be32_to_cpu __be32_to_cpu -#define cpu_to_be16 __cpu_to_be16 -#define be16_to_cpu __be16_to_cpu -#define cpu_to_le64p __cpu_to_le64p -#define le64_to_cpup __le64_to_cpup -#define cpu_to_le32p __cpu_to_le32p -#define le32_to_cpup __le32_to_cpup -#define cpu_to_le16p __cpu_to_le16p -#define le16_to_cpup __le16_to_cpup -#define cpu_to_be64p __cpu_to_be64p -#define be64_to_cpup __be64_to_cpup -#define cpu_to_be32p __cpu_to_be32p -#define be32_to_cpup __be32_to_cpup -#define cpu_to_be16p __cpu_to_be16p -#define be16_to_cpup __be16_to_cpup -#define cpu_to_le64s __cpu_to_le64s -#define le64_to_cpus __le64_to_cpus -#define cpu_to_le32s __cpu_to_le32s -#define le32_to_cpus __le32_to_cpus -#define cpu_to_le16s __cpu_to_le16s -#define le16_to_cpus __le16_to_cpus -#define cpu_to_be64s __cpu_to_be64s -#define be64_to_cpus __be64_to_cpus -#define cpu_to_be32s __cpu_to_be32s -#define be32_to_cpus __be32_to_cpus -#define cpu_to_be16s __cpu_to_be16s -#define be16_to_cpus __be16_to_cpus - -#endif /* __XEN_BYTEORDER_GENERIC_H__ */ diff --git a/xen/include/xen/byteorder/little_endian.h b/xen/include/xen/byteorder/little_endian.h deleted file mode 100644 index 4955632793..0000000000 --- a/xen/include/xen/byteorder/little_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_LITTLE_ENDIAN_H__ -#define __XEN_BYTEORDER_LITTLE_ENDIAN_H__ - -#ifndef __LITTLE_ENDIAN -#define __LITTLE_ENDIAN 1234 -#endif -#ifndef __LITTLE_ENDIAN_BITFIELD -#define __LITTLE_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)___constant_swab64((x))) -#define __constant_be64_to_cpu(x) ___constant_swab64((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)___constant_swab32((x))) -#define __constant_be32_to_cpu(x) ___constant_swab32((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)___constant_swab16((x))) -#define __constant_be16_to_cpu(x) ___constant_swab16((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)__swab64((x))) -#define __be64_to_cpu(x) __swab64((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)__swab32((x))) -#define __be32_to_cpu(x) __swab32((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)__swab16((x))) -#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)*p; -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return (__force __u64)*p; -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)*p; -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return (__force __u32)*p; -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)*p; -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return (__force __u16)*p; -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)__swab64p(p); -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)__swab32p(p); -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)__swab16p(p); -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return __swab16p((__u16 *)p); -} -#define __cpu_to_le64s(x) do {} while (0) -#define __le64_to_cpus(x) do {} while (0) -#define __cpu_to_le32s(x) do {} while (0) -#define __le32_to_cpus(x) do {} while (0) -#define __cpu_to_le16s(x) do {} while (0) -#define __le16_to_cpus(x) do {} while (0) -#define __cpu_to_be64s(x) __swab64s((x)) -#define __be64_to_cpus(x) __swab64s((x)) -#define __cpu_to_be32s(x) __swab32s((x)) -#define __be32_to_cpus(x) __swab32s((x)) -#define __cpu_to_be16s(x) __swab16s((x)) -#define __be16_to_cpus(x) __swab16s((x)) - -#include - -#endif /* __XEN_BYTEORDER_LITTLE_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/swab.h b/xen/include/xen/byteorder/swab.h deleted file mode 100644 index b7e30f0503..0000000000 --- a/xen/include/xen/byteorder/swab.h +++ /dev/null @@ -1,183 +0,0 @@ -#ifndef __XEN_BYTEORDER_SWAB_H__ -#define __XEN_BYTEORDER_SWAB_H__ - -/* - * Byte-swapping, independently from CPU endianness - * swabXX[ps]?(foo) - * - * Francois-Rene Rideau 19971205 - * separated swab functions from cpu_to_XX, - * to clean up support for bizarre-endian architectures. - */ - -/* casts are necessary for constants, because we never know how for sure - * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way. - */ -#define ___swab16(x) \ -({ \ - __u16 __x = (x); \ - ((__u16)( \ - (((__u16)(__x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(__x) & (__u16)0xff00U) >> 8) )); \ -}) - -#define ___swab32(x) \ -({ \ - __u32 __x = (x); \ - ((__u32)( \ - (((__u32)(__x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(__x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(__x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(__x) & (__u32)0xff000000UL) >> 24) )); \ -}) - -#define ___swab64(x) \ -({ \ - __u64 __x = (x); \ - ((__u64)( \ - (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) )); \ -}) - -#define ___constant_swab16(x) \ - ((__u16)( \ - (((__u16)(x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(x) & (__u16)0xff00U) >> 8) )) -#define ___constant_swab32(x) \ - ((__u32)( \ - (((__u32)(x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(x) & (__u32)0xff000000UL) >> 24) )) -#define ___constant_swab64(x) \ - ((__u64)( \ - (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) )) - -/* - * provide defaults when no architecture-specific optimization is detected - */ -#ifndef __arch__swab16 -# define __arch__swab16(x) ({ __u16 __tmp = (x) ; ___swab16(__tmp); }) -#endif -#ifndef __arch__swab32 -# define __arch__swab32(x) ({ __u32 __tmp = (x) ; ___swab32(__tmp); }) -#endif -#ifndef __arch__swab64 -# define __arch__swab64(x) ({ __u64 __tmp = (x) ; ___swab64(__tmp); }) -#endif - -#ifndef __arch__swab16p -# define __arch__swab16p(x) __arch__swab16(*(x)) -#endif -#ifndef __arch__swab32p -# define __arch__swab32p(x) __arch__swab32(*(x)) -#endif -#ifndef __arch__swab64p -# define __arch__swab64p(x) __arch__swab64(*(x)) -#endif - -#ifndef __arch__swab16s -# define __arch__swab16s(x) do { *(x) = __arch__swab16p((x)); } while (0) -#endif -#ifndef __arch__swab32s -# define __arch__swab32s(x) do { *(x) = __arch__swab32p((x)); } while (0) -#endif -#ifndef __arch__swab64s -# define __arch__swab64s(x) do { *(x) = __arch__swab64p((x)); } while (0) -#endif - - -/* - * Allow constant folding - */ -#if defined(__GNUC__) && defined(__OPTIMIZE__) -# define __swab16(x) \ -(__builtin_constant_p((__u16)(x)) ? \ - ___swab16((x)) : \ - __fswab16((x))) -# define __swab32(x) \ -(__builtin_constant_p((__u32)(x)) ? \ - ___swab32((x)) : \ - __fswab32((x))) -# define __swab64(x) \ -(__builtin_constant_p((__u64)(x)) ? \ - ___swab64((x)) : \ - __fswab64((x))) -#else -# define __swab16(x) __fswab16(x) -# define __swab32(x) __fswab32(x) -# define __swab64(x) __fswab64(x) -#endif /* OPTIMIZE */ - - -static inline __attribute_const__ __u16 __fswab16(__u16 x) -{ - return __arch__swab16(x); -} -static inline __u16 __swab16p(const __u16 *x) -{ - return __arch__swab16p(x); -} -static inline void __swab16s(__u16 *addr) -{ - __arch__swab16s(addr); -} - -static inline __attribute_const__ __u32 __fswab32(__u32 x) -{ - return __arch__swab32(x); -} -static inline __u32 __swab32p(const __u32 *x) -{ - return __arch__swab32p(x); -} -static inline void __swab32s(__u32 *addr) -{ - __arch__swab32s(addr); -} - -#ifdef __BYTEORDER_HAS_U64__ -static inline __attribute_const__ __u64 __fswab64(__u64 x) -{ -# ifdef __SWAB_64_THRU_32__ - __u32 h = x >> 32; - __u32 l = x & ((1ULL<<32)-1); - return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h))); -# else - return __arch__swab64(x); -# endif -} -static inline __u64 __swab64p(const __u64 *x) -{ - return __arch__swab64p(x); -} -static inline void __swab64s(__u64 *addr) -{ - __arch__swab64s(addr); -} -#endif /* __BYTEORDER_HAS_U64__ */ - -#define swab16 __swab16 -#define swab32 __swab32 -#define swab64 __swab64 -#define swab16p __swab16p -#define swab32p __swab32p -#define swab64p __swab64p -#define swab16s __swab16s -#define swab32s __swab32s -#define swab64s __swab64s - -#endif /* __XEN_BYTEORDER_SWAB_H__ */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335659.559865 (Exim 4.92) (envelope-from ) id 1nt4k6-0003Zb-RB; Mon, 23 May 2022 09:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335659.559865; Mon, 23 May 2022 09:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k6-0003Vx-Gi; Mon, 23 May 2022 09:52:50 +0000 Received: by outflank-mailman (input) for mailman id 335659; Mon, 23 May 2022 09:52:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k4-0002dp-ON for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:48 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18e08260-da7e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:52:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18e08260-da7e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299566; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YEOHu0aPYMpRRwah1nehuHESqF4dTCOGh65pg9RBCsU=; b=ag+m0g+QVMleGGMofc0dvnl/T+RVQW6LQuPsfTMXIHcSLU0+L+pN9b88 fXl7OrGEMBcKEbyV4EbNy305zTEnwL2IpBD+JmyqqYopEyaCk8F7L2aYX CpSRV2oAQYMU3tx05uvwdt/VrKnxEpIt6P9E5uwXxq8gjs/jFZUs4y1k2 s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74445150 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:rLCqU6jgwGWJxIN78pwa5VTYX161dBAKZh0ujC45NGQN5FlHY01je htvWjuAaf6KY2Kkeoh+aYSw8xlTvZ+ExtM1SgtpryljQXwb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnW4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTcrI/Pdk7QQaDd/GgFvDINGv4D9HkHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknVhy3fdDOsOSpHfWaTao9Rf2V/cg+gRQaqCO pNEMVKDajzJahEVFH0VOKsEo970qyfnUg1kkhW88P9fD2/7k1UqjemF3MDuUtaHX9lPl0CU4 GfP5X3kAwoyPcaajzGC9xqEuOjLmi/qXZMII5ex/PVqnV67y3QaDVsdUl7Tifukjk+zXfpPJ kpS/TAhxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHjVGOYSvDrPHO92r0YHVLaz9ZDcMZcecby+nhvd8ihULCdfhEGY6kv/P1Xg7K/ Anf+UDSmI4vYd43O7STpA6a2Gj39siSFGbZ9S2MADv7s1oRiJqNItXxtAOFtasowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWN4umgWyL9BaJpsRNMQS Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4m+DKyIMoMUOsEhHONiwM2JTRfNt10BbWB2yf1vU XtlWZjE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz+uYdykEW9EO9fWHPXN7hRxPrd8G39r ocEX+PXmko3bQELSnSOmWLlBQtSfSZT6FGfg5E/S9Nv1SI9SDB9UKWImOxJlk4Mt/09q9okN 0qVAidwoGcTT1WeQelWQhiPsI/SYKs= IronPort-HdrOrdr: A9a23:igdNq69rBSGM+tJcG0xuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="74445150" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 3/6] arm64/find_next_bit: Remove ext2_swab() Date: Mon, 23 May 2022 05:52:19 -0400 Message-ID: <906b399ee86969fb86304c60c3b725326620d50f.1653295437.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain ext2 has nothing to do with this logic. Clean up the code with xen/byteswap.h which now has an unsigned long helper. No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk --- xen/arch/arm/arm64/lib/find_next_bit.c | 36 +++++--------------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c index 8ebf8bfe97..e3b3720ff4 100644 --- a/xen/arch/arm/arm64/lib/find_next_bit.c +++ b/xen/arch/arm/arm64/lib/find_next_bit.c @@ -161,30 +161,6 @@ EXPORT_SYMBOL(find_first_zero_bit); #ifdef __BIG_ENDIAN -/* include/linux/byteorder does not support "unsigned long" type */ -static inline unsigned long ext2_swabp(const unsigned long * x) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64p((u64 *) x); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32p((u32 *) x); -#else -#error BITS_PER_LONG not defined -#endif -} - -/* include/linux/byteorder doesn't support "unsigned long" type */ -static inline unsigned long ext2_swab(const unsigned long y) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64((u64) y); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32((u32) y); -#else -#error BITS_PER_LONG not defined -#endif -} - #ifndef find_next_zero_bit_le unsigned long find_next_zero_bit_le(const void *addr, unsigned long size, unsigned long offset) @@ -199,7 +175,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp |= (~0UL >> (BITS_PER_LONG - offset)); if (size < BITS_PER_LONG) goto found_first; @@ -217,7 +193,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp |= ~0UL << size; if (tmp == ~0UL) /* Are any bits zero? */ @@ -226,7 +202,7 @@ found_middle: return result + ffz(tmp); found_middle_swap: - return result + ffz(ext2_swab(tmp)); + return result + ffz(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_zero_bit_le); #endif @@ -245,7 +221,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp &= (~0UL << offset); if (size < BITS_PER_LONG) goto found_first; @@ -264,7 +240,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp &= (~0UL >> (BITS_PER_LONG - size)); if (tmp == 0UL) /* Are any bits set? */ @@ -273,7 +249,7 @@ found_middle: return result + __ffs(tmp); found_middle_swap: - return result + __ffs(ext2_swab(tmp)); + return result + __ffs(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_bit_le); #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335656.559841 (Exim 4.92) (envelope-from ) id 1nt4k5-00039A-81; Mon, 23 May 2022 09:52:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335656.559841; Mon, 23 May 2022 09:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k5-00038k-55; Mon, 23 May 2022 09:52:49 +0000 Received: by outflank-mailman (input) for mailman id 335656; Mon, 23 May 2022 09:52:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k3-0002dq-Ct for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18f05811-da7e-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 11:52:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18f05811-da7e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299566; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TVa+erymlQY+WbivPygOYiIdpa/oed2z8s+mtE7ohZw=; b=fufJeyRtKQqiT6V/2VV9glVz4xr1sea1UpyFxlVqi8EobIiGsVXaAoBZ MDJBhNPzZyEicbbMEnACM1TsxBsYTFUJTL9aeIoHKGo4cM6j24XCFfAKD TGci30+BA0ldFUe++RFLhHwVhYP7gnjwXOShqDYDIgoZQMugUik+woUB7 U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71787721 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:3qqAq6pc6bwtPWe5oqkNlbrEThheBmKMZRIvgKrLsJaIsI4StFCzt garIBnTOazcNmP0c9p+aIm08UsCsJTRxt5hTgJk+C02RXwQ9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 4iq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBN/edgfsUAgVhTDxnbKthyJqAJ0mCrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIyTDfS/InXLjIQrnQ5M8e1zA17ixLNamHO JpGNmA2BPjGSyFjBkxNEp4HpeStlz7gdmEDgnypq4NitgA/yyQuieOwYbI5YOeiXt5Jl0yVo mbH+WXRARwAMtGbjz2f/RqEhejJhyr3Hp0TEL6Q8eRji1megGcUDXU+a1y/pvWoj1+kbPhWI UcU5ykGoLA78QqgSdyVdwK8iG6JuFgbQdU4O+8n7ACAzILE7gDfAXILJhZLZcY6rsYwSXov3 0WQgtLyLTV1tfueTnf13ruboT69IyE9MX4JZShCSxAMpdbkvukbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lXjLmympp4TJZgct6x/LQ3m+6QdkeI+iYZfu4l/ehd5CJouESliKv FAfhtOTqusJCPmllTOPaPUAGqmz4PSIOyGahkRgd6TN7Bz0pSTlJ9oJpmgjegE5aa7oZAMFf mfa41JI+5YCIEL1cLYmZaWBLoMs/JX/QIGNuu/vUjZeXnRgXFbZoXo0Ph7AhDqFfFsEyv9mZ 8rCGSq4JTNDUPk8kmLrLwsI+eVzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H js2Cidr9/m8eLenCsUv2dRPRW3m1FBibXwMl+RZd/SYPi1tE3w7BvnazNsJItI4xP4JyruRp CnkCie0LWYTYlWedG23ho1LMuuzDf6TU1plVcDTAbpY8yd6Otv+hEvuX5A2YaMm5IReIQ1cF pE4lzG7Kq0XEFzvom1FBbGk9dwKXEn63mqmYnv6CAXTirY9HmQlDPe/JluxnMTPZwLq3fYDT 0qIjVOKHcFZHl09ZCsUAdr2p26MUbEmsLoadyP1zhN7JC0ALKACx/TNs8IK IronPort-HdrOrdr: A9a23:iAAjva+Q/lPzsNJ544Juk+DWI+orL9Y04lQ7vn2YSXRuE/Bw8P re+sjztCWE7wr5N0tQ+uxoVJPufZq+z+8Q3WByB8bBYOCOggLBR+sOgbcKqweQYhEWndQ86U 4PScZD4aXLfD1Hsfo= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71787721" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , Daniel De Graaf , "Daniel P. Smith" , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Bertrand Marquis , "Konrad Rzeszutek Wilk" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Ross Lagerwall , "Stefano Stabellini" , Volodymyr Babchuk , Wei Liu Subject: [PATCH v4 0/6] Implement byteswap and update references Date: Mon, 23 May 2022 05:52:16 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Lin Liu (6): xen: implement byteswap crypto/vmac: Simplify code with byteswap arm64/find_next_bit: Remove ext2_swab() xen: Switch to byteswap tools: Use new byteswap helper byteorder: Remove byteorder .../libs/guest/xg_dom_decompress_unsafe_xz.c | 5 + .../guest/xg_dom_decompress_unsafe_zstd.c | 3 +- xen/arch/arm/arm64/lib/find_next_bit.c | 36 +--- xen/arch/arm/include/asm/byteorder.h | 6 +- xen/arch/x86/include/asm/byteorder.h | 34 +--- xen/common/device_tree.c | 44 ++--- xen/common/libelf/libelf-private.h | 6 +- xen/common/xz/private.h | 2 +- xen/crypto/vmac.c | 76 +------- xen/include/xen/byteorder.h | 56 ++++++ xen/include/xen/byteorder/big_endian.h | 102 ---------- xen/include/xen/byteorder/generic.h | 68 ------- xen/include/xen/byteorder/little_endian.h | 102 ---------- xen/include/xen/byteorder/swab.h | 183 ------------------ xen/include/xen/byteswap.h | 44 +++++ xen/include/xen/compiler.h | 24 +++ xen/include/xen/lib.h | 4 - xen/include/xen/unaligned.h | 12 +- 18 files changed, 180 insertions(+), 627 deletions(-) create mode 100644 xen/include/xen/byteorder.h delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h create mode 100644 xen/include/xen/byteswap.h -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335654.559819 (Exim 4.92) (envelope-from ) id 1nt4k3-0002eH-Qc; Mon, 23 May 2022 09:52:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335654.559819; Mon, 23 May 2022 09:52:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k3-0002e5-LP; Mon, 23 May 2022 09:52:47 +0000 Received: by outflank-mailman (input) for mailman id 335654; Mon, 23 May 2022 09:52:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k2-0002dq-JR for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17077772-da7e-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 11:52:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17077772-da7e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JBHSAD2WTCaM2SftEiZKTTucLKJZ7SWdUx1sAhYs8n4=; b=QxBqD4z7V4hIPZGm2gS6+hxvm+wdFn6vbFnKD6expCN1NQZ/p8Zr1ddt StbtK/lW4Og1OR2Nwamk0ZwfYQ9yjegIAEkkO18IFrjZObIAAnt65NdBm wBeUU7oI/YjU7b38c8ZvjCal+IO3Xk7O412sXvTt/wwHkWtaCEBr2C4A8 Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71787716 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+h2RBK/CFFOuVFq8qCFsDrUDtX6TJUtcMsCJ2f8bNWPcYEJGY0x3z zQaWGDSO/7ZZzPzfNt+PY7g9x8Cup7cx4JjTwBt+y88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3ILiW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnayeaxU5BfDjodYidEVILy9SDfB//KCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIcevDdkzCzxBvc6W5HTBa7N4Le02R9v358eQqmHO aL1bxJgSRn/WR9IamxMEY09kvanuF64QSFx/Qf9Sa0fvDGIkV0ZPKLWGNjfd8GORM5Vtl2Fv W+A9GP8ajkYKdiexDyt4n+qwOjVkkvTR4Y6BLC+sPlwjzW7+GsXDxEHUEqhltOwgEW+RtF3J lQd/2wlqq1a3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsVSVdYdYrsMs3Qz0C1 VKTmd7tQzt1v9W9Q3+H6q2dqz/0PCEPNHIDfgcNVw5D6N7myLzflTqWEIwlSvTsyISoR3egm FhmsRTSmZ0jo+wZx57m0mn1vBXwtqTHYj5o3wHICzfNAhxCWGK1W2C5wQGFsK0ad9bJFQPpU GsswJbHsr1XZX2ZvGnUGbhWQun0jxqQGGeE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O RSD0e+9CXI6AZdLUUOUS9joYyjS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9iY s3HLZr1Vy5DWcyLKQZaoM9EjNcWKt0WnzuPFfgXMTz5uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivBnFSnCPq+Y7dAlSRVBiXMCeg5EGLYarf1s5cFzN/teMmNvNjaQ+x/QL/goJl 1ngMnJlJK3X3i2WdV7QMyk8AF4tNL4mxU8G0eUXFQ7A8xAejUyHsM/zq7NfkWEbydFe IronPort-HdrOrdr: A9a23:9Qjl8a7Y7RYnTc1JxwPXwPDXdLJyesId70hD6qhwISY6TiX+rb HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71787716" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , "Jan Beulich" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 1/6] xen: implement byteswap Date: Mon, 23 May 2022 05:52:17 -0400 Message-ID: <89b15afe026a84748ac0d9ca28e8608085454e78.1653295437.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit swab() is massively over complicated and can be simplified by re-implementing using compiler builtins. The compilers provide builtin function to swap bytes. * gcc: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html * clang: https://clang.llvm.org/docs/LanguageExtensions.html This patch introduces a new byteswapping infrastructure in terms of compiler builtins and bswapXX(), so the swab() infrastructure can be retired. Signed-off-by: Lin Liu Reviewed-by: Andrew Cooper --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Cc: "Roger Pau Monné" Changes in v4: - Move `PASTE` definition to xen/compiler.h to support tools - Revert emacs magics Changes in v3: - Check __has_builtin instead of GNUC version Changes in v2: - Add fallback for compilers without __builtin_bswap - Implement with plain C instead of macros --- xen/arch/arm/include/asm/byteorder.h | 6 ++- xen/arch/x86/include/asm/byteorder.h | 34 ++--------------- xen/include/xen/byteorder.h | 56 ++++++++++++++++++++++++++++ xen/include/xen/byteswap.h | 44 ++++++++++++++++++++++ xen/include/xen/compiler.h | 24 ++++++++++++ xen/include/xen/lib.h | 4 -- 6 files changed, 132 insertions(+), 36 deletions(-) create mode 100644 xen/include/xen/byteorder.h create mode 100644 xen/include/xen/byteswap.h diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h index 9c712c4788..b6a33b23c0 100644 --- a/xen/arch/arm/include/asm/byteorder.h +++ b/xen/arch/arm/include/asm/byteorder.h @@ -1,9 +1,11 @@ #ifndef __ASM_ARM_BYTEORDER_H__ #define __ASM_ARM_BYTEORDER_H__ -#define __BYTEORDER_HAS_U64__ +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -#include +#include #endif /* __ASM_ARM_BYTEORDER_H__ */ /* diff --git a/xen/arch/x86/include/asm/byteorder.h b/xen/arch/x86/include/asm/byteorder.h index 1f77e502a5..82aadee7bd 100644 --- a/xen/arch/x86/include/asm/byteorder.h +++ b/xen/arch/x86/include/asm/byteorder.h @@ -1,36 +1,10 @@ #ifndef __ASM_X86_BYTEORDER_H__ #define __ASM_X86_BYTEORDER_H__ -#include -#include +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -static inline __attribute_const__ __u32 ___arch__swab32(__u32 x) -{ - asm("bswap %0" : "=r" (x) : "0" (x)); - return x; -} - -static inline __attribute_const__ __u64 ___arch__swab64(__u64 val) -{ - union { - struct { __u32 a,b; } s; - __u64 u; - } v; - v.u = val; - asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" - : "=r" (v.s.a), "=r" (v.s.b) - : "0" (v.s.a), "1" (v.s.b)); - return v.u; -} - -/* Do not define swab16. Gcc is smart enough to recognize "C" version and - convert it into rotation or exhange. */ - -#define __arch__swab64(x) ___arch__swab64(x) -#define __arch__swab32(x) ___arch__swab32(x) - -#define __BYTEORDER_HAS_U64__ - -#include +#include #endif /* __ASM_X86_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteorder.h b/xen/include/xen/byteorder.h new file mode 100644 index 0000000000..2ec434e6a6 --- /dev/null +++ b/xen/include/xen/byteorder.h @@ -0,0 +1,56 @@ +#ifndef __XEN_BYTEORDER_H__ +#define __XEN_BYTEORDER_H__ + +#include + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ + +# ifndef __LITTLE_ENDIAN +# define __LITTLE_ENDIAN 1234 +# endif + +# ifndef __LITTLE_ENDIAN_BITFIELD +# define __LITTLE_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) (x) +# define le64_to_cpu(x) (x) +# define cpu_to_le32(x) (x) +# define le32_to_cpu(x) (x) +# define cpu_to_le16(x) (x) +# define le16_to_cpu(x) (x) +# define cpu_to_be64(x) bswap64(x) +# define be64_to_cpu(x) bswap64(x) +# define cpu_to_be32(x) bswap32(x) +# define be32_to_cpu(x) bswap32(x) +# define cpu_to_be16(x) bswap16(x) +# define be16_to_cpu(x) bswap16(x) + +#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ + +# ifndef __BIG_ENDIAN +# define __BIG_ENDIAN 4321 +# endif + +# ifndef __BIG_ENDIAN_BITFIELD +# define __BIG_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) bswap64(x) +# define le64_to_cpu(x) bswap64(x) +# define cpu_to_le32(x) bswap32(x) +# define le32_to_cpu(x) bswap32(x) +# define cpu_to_le16(x) bswap16(x) +# define le16_to_cpu(x) bswap16(x) +# define cpu_to_be64(x) (x) +# define be64_to_cpu(x) (x) +# define cpu_to_be32(x) (x) +# define be32_to_cpu(x) (x) +# define cpu_to_be16(x) (x) +# define be16_to_cpu(x) (x) + +#else +# error "Unknown Endianness" +#endif /* __BYTE_ORDER__ */ + +#endif /* __XEN_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteswap.h b/xen/include/xen/byteswap.h new file mode 100644 index 0000000000..d2e371fbe7 --- /dev/null +++ b/xen/include/xen/byteswap.h @@ -0,0 +1,44 @@ +#ifndef __XEN_BYTESWAP_H__ +#define __XEN_BYTESWAP_H__ + +#include +#include + +#if !__has_builtin(__builtin_bswap16) +static always_inline uint16_t __builtin_bswap16(uint16_t val) +{ + return ((val & 0x00FF) << 8) | ((val & 0xFF00) >> 8); +} +#endif + +#if !__has_builtin(__builtin_bswap32) +static always_inline uint32_t __builtin_bswap32(uint32_t val) +{ + return ((val & 0x000000FF) << 24) | + ((val & 0x0000FF00) << 8) | + ((val & 0x00FF0000) >> 8) | + ((val & 0xFF000000) >> 24); +} +#endif + +#if !__has_builtin(__builtin_bswap64) +static always_inline uint64_t __builtin_bswap64(uint64_t val) +{ + return ((val & 0x00000000000000FF) << 56) | + ((val & 0x000000000000FF00) << 40) | + ((val & 0x0000000000FF0000) << 24) | + ((val & 0x00000000FF000000) << 8) | + ((val & 0x000000FF00000000) >> 8) | + ((val & 0x0000FF0000000000) >> 24) | + ((val & 0x00FF000000000000) >> 40) | + ((val & 0xFF00000000000000) >> 56); +} +#endif + +#define bswap16(x) __builtin_bswap16(x) +#define bswap32(x) __builtin_bswap32(x) +#define bswap64(x) __builtin_bswap64(x) + +#define bswap_ul(x) PASTE(bswap,BITS_PER_LONG)(x) + +#endif /* __XEN_BYTESWAP_H__ */ diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 933aec09a9..ae029afa14 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -185,4 +185,28 @@ # define CLANG_DISABLE_WARN_GCC_COMPAT_END #endif +#ifndef __has_builtin +/* + * Backwards compatibility for GCC < 10. + * All supported versions of Clang support __has_builtin + * */ +#define __has_builtin(x) GCC_has ## x + +#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >= 40800) +#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >= 40400) +#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >= 40400) +#endif + +#ifndef __ORDER_LITTLE_ENDIAN__ +# define __ORDER_LITTLE_ENDIAN__ 1234 +#endif + +#ifndef __ORDER_BIG_ENDIAN__ +# define __ORDER_BIG_ENDIAN__ 4321 +#endif + +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_(a, b) a ## b +#define PASTE(a, b) PASTE_(a, b) + #endif /* __LINUX_COMPILER_H */ diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index aab1fc7c4a..ebf2193569 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -15,10 +15,6 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) -/* Indirect macros required for expanded argument pasting. */ -#define PASTE_(a, b) a ## b -#define PASTE(a, b) PASTE_(a, b) - #define __STR(...) #__VA_ARGS__ #define STR(...) __STR(__VA_ARGS__) -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 09:52:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 09:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335655.559822 (Exim 4.92) (envelope-from ) id 1nt4k4-0002g6-04; Mon, 23 May 2022 09:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335655.559822; Mon, 23 May 2022 09:52:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k3-0002fU-Sm; Mon, 23 May 2022 09:52:47 +0000 Received: by outflank-mailman (input) for mailman id 335655; Mon, 23 May 2022 09:52:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4k3-0002dp-1s for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:52:47 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16a63e5a-da7e-11ec-837e-e5687231ffcc; Mon, 23 May 2022 11:52:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16a63e5a-da7e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fEkEMnPb+q1gLdgxKH7ndanRPUKwGzgXMdy6eBWVxBI=; b=KcSzmiiDACObnkdzFPCcFC+0HszyloCyEwN3hVSa9kSAvL93QgSmhbm8 ffYcNsk2GM1PK0R9Pc2yy26bxkfesqPvjDkAZo4u59B+pu+CQPC0+SSwe n/DXDV+3aT+E2NB0i0lQCoAU3cEyV66c1/762pmQCTmeHF/L5hyrhEKXy c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74445148 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:iQmXt6kRhckX7sWuOuVaf2Lo5gzUJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJMWG3VafzeYmb3cogkPdy2/EtXsZfWz9U1QAdo+yEwFiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVjV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYeSEDJZbcvNomXCJXSQ9sD5VgxeWWPi3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3vnBmizXYEN4tQIzZQrWM7thdtNs1rp8SQaqDP pZJAdZpRCuHaiNsHFoVMpIFkf6BoXvEagwAl03A8MLb5ECMlVcsgdABKuH9eNOQQt5Otl2Fv W+A9GP8ajkFMPSPxDzD9Wij7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA xVKoGx09/F0rRH1CImmN/GlnJKali46ccFrA8kE0w62xfD68TShIFVeHyEUPbTKq/QKqSwWO k6hxo20XmY04O3OExpx5Z/P82rsZHF9wXsqIHZdEFBbu4SLTJQb1Eqnczp1LEKiYjQZ8xnUy ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCub/BDvNAvtRPtLNWmBRwQGzAQx8BIiYVEKdm 3MPhtKT6usDZbnUynHWGrlRQOjzv6/VWNE5vbKIN8B8nwlBBlb5JdwAiN2ADBkB3jk4lc/BP xaI5FI5CG57N3q2d65nC79d+OxzpZUM4e/ND6iOBvIXO8AZXFberElGOB/Lt0iwwRdErE3KE crCGSpaJS1CWfoPIfvfb7p17ILHMQhllTKPHsqilkvPPHj3TCf9dIrp+WCmNogRhJ5oai2Pm zqDH6NmEylibdA= IronPort-HdrOrdr: A9a23:BSCFIquqKXSpjDe62mMIRMwg7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="74445148" From: Lin Liu To: CC: Lin Liu , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v4 5/6] tools: Use new byteswap helper Date: Mon, 23 May 2022 05:52:21 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Include new header to use new byteswap helper No functional change. Signed-off-by: Lin Liu --- Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross --- tools/libs/guest/xg_dom_decompress_unsafe_xz.c | 5 +++++ tools/libs/guest/xg_dom_decompress_unsafe_zstd.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c index fc48198741..493427d517 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) return cpu_to_le32(*p); } +static inline u32 le32_to_cpu(u32 val) +{ + return le32_to_cpup((const u32 *)&val); +} + #define __force #define always_inline diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c index 01eafaaaa6..b06f2e767f 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c @@ -31,7 +31,8 @@ typedef uint64_t __be64; #define __BYTEORDER_HAS_U64__ #define __TYPES_H__ /* xen/types.h guard */ -#include "../../xen/include/xen/byteorder/little_endian.h" +#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#include "../../xen/include/xen/byteorder.h" #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ #include "../../xen/include/xen/unaligned.h" #include "../../xen/include/xen/xxhash.h" -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 10:00:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:00:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335689.559895 (Exim 4.92) (envelope-from ) id 1nt4rY-0007ji-1C; Mon, 23 May 2022 10:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335689.559895; Mon, 23 May 2022 10:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4rX-0007jb-UM; Mon, 23 May 2022 10:00:31 +0000 Received: by outflank-mailman (input) for mailman id 335689; Mon, 23 May 2022 10:00:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4rW-0007jR-9S; Mon, 23 May 2022 10:00:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4rW-0004gs-5u; Mon, 23 May 2022 10:00:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4rV-0008Hp-On; Mon, 23 May 2022 10:00:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt4rV-0002qa-OM; Mon, 23 May 2022 10:00:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QC+sGqWTWpkalAk0J5yioBwEDFf6Wue/U43Uqis5uaA=; b=OTyPWYXy6Bh53PcTcNUPMNTKL6 cCOgzU2VHwn6LCSuCTP865glwPKvsxkYEaUROJVRqqUoemB6c5g8fhjYeLsbjr3tugpRTphO5YE4u uc58ZalS2E5YgmcwzdfHIc4CF8QzvGl4k7OaXc4JYyQwqdDnU3uuGxRK4rtTGpacRvKo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170697: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 10:00:29 +0000 flight 170697 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170697/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 83 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1185 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 73 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 10:01:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335729.559907 (Exim 4.92) (envelope-from ) id 1nt4sd-0008L7-EF; Mon, 23 May 2022 10:01:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335729.559907; Mon, 23 May 2022 10:01:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4sd-0008L0-9S; Mon, 23 May 2022 10:01:39 +0000 Received: by outflank-mailman (input) for mailman id 335729; Mon, 23 May 2022 10:01:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4kd-0002dq-3y for xen-devel@lists.xenproject.org; Mon, 23 May 2022 09:53:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c3b21ab-da7e-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 11:53:20 +0200 (CEST) Received: from mail-mw2nam08lp2175.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 05:53:17 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SA0PR03MB5465.namprd03.prod.outlook.com (2603:10b6:806:b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 09:53:16 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.022; Mon, 23 May 2022 09:53:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c3b21ab-da7e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653299599; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Er/yBhvdJArxp83rPCJMWsmhZ3OweLmcLpFTR0wi1tQ=; b=N4WiuYFm/rXL742NMTt0XUrSevf4krnZc6Zr0mQHzGe9ln5L6DRIS+iK OkJ0VVQKGZaN4K7GOgxYpGeSfDpjNvKgnP4bPAeW3uZD3icUSUADigS9A JqujFEloREFaWKwlpGbZ9XGieEjiHlKfmiCwt84ylkZfBEYNTH9tWlDqe Y=; X-IronPort-RemoteIP: 104.47.73.175 X-IronPort-MID: 71925730 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ohoxMKOGqBtUWGnvrR3RlsFynXyQoLVcMsEvi/4bfWQNrUp0hjQEz zNLXmuCPP+JZ2L9e9x+Pd/ioUIBvMCDn9VmSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NUw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5 Y1nt5OsdFwQMoboyMg5XjNXSBgkIvgTkFPHCSDXXc276WTjKyep5so0SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB5GtaaHPiiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33yilLmID8Dp5o4ILszHOxU900IPoPeDPOfCaYP1aglyx8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ1hHWDy2pVDwcZPXOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsg/IHc99ZEul/7R7XzKPRu1adHjJdEWMHb8E6vsgrQzBsz kWOg97iGT1otvuSVG6Z8bCX6zi1PED5MFM/WMPNdiNdi/GLnW35pkunogpLeEJtsuDIJA== IronPort-HdrOrdr: A9a23:mrUe5KrEpawGKvaUKnfAzS4aV5oleYIsimQD101hICG8cqSj9v xG+85rsyMc6QxhP03I9urwW5VoLUmyyXcX2/h0AV7BZniFhILAFugLhuGOrwEIcxeOj9K1vp 0BT0ERMrPN5CBB/KPH3DU= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71925730" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjDdiOc5XEQUztzyNF5Udn2UEgguxaPPh5RCX1CZNUROory2xNdP98RzlAZyUbWy6sDvg/4pymkQ6n73t9XzT1g+mJypnqrSxHwGiLlElQcWSPN1/nMP+wZBRgoWeKxMFoVpcZRhovIFLV66Y3N8wbCOAwA7WzJ51qUDPh/hw7a+n943SSECdOvkivgmCOdaltSgG/PXMkczEnsRVVhiQjFdGmlAGGi9r7mYJGGR7erhfwdt9yVObqwHR1Be99cH8usjcNAw9RqhAQ8h9bZ0EdN3SBDXOBv9E8Zal3IiGqChI3QKMZ0jyefWqZ7v32dXU9MXPfjkbcH70zacm/thcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hueTV5O0UHuRLSL6GaRN1R2ZatIg17psVt+HIchGY4o=; b=iyf3Wk7xzIZrpc94ooDkzsJX/lv14rVhRaW3DqDOI9NG25Gf/zLtukVkMc1GZ/jiocUMeD1AdGPP7/vLQg0Q/Rn1AvZKZh0ONeOB04LSawi2gj834GBYhXXma1EiS51fJ0HB1PJXIIcnnniUYHqpiyEChlPKnIsMALUAzB2piX6wHe5aB49Ky9+NX9S/NUM6NkckAZgxlLhvBcW/aLk5A2VM9hB6lALD7sGTTw7UHiM9Oy07U4Tf6K8HjwGzOtlFFKtIJEYAQ5ud2qMe4thTSH2n8Y3NYRgDqMILzNBANWFqewFWfR1rNNbRfuBgw/jpAnt4fiwi5n6Rc0Xlr206vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hueTV5O0UHuRLSL6GaRN1R2ZatIg17psVt+HIchGY4o=; b=RJjYSe8/Al9IC9Q4SxelK0z1J9nT8IJb/MGhyhO5d8lqx+RAcFj8yyAR4AYFADDmyOB1oaGpFph790oEySoxZmAfB0eEdCIHEdK6U/k/Np2g4Df12Jd1RZQLp8OYc7k/LTHc1tJ2f/+NOWAYX2L7b/tTAkc7RDBp2eYJYcAM4oE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 11:53:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/5] x86/perf: expose LBR format in PERF_CAPABILITIES Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-4-roger.pau@citrix.com> <33632dc6-940f-6737-c808-48e6c28fc0bf@citrix.com> <42cac54e-134b-dcfd-3ce1-1d6bfae9176c@suse.com> <5330ca97-2b72-409e-c021-61ab4356e051@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5330ca97-2b72-409e-c021-61ab4356e051@suse.com> X-ClientProxiedBy: LO2P265CA0494.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0f31213-1be0-4b5d-7327-08da3ca20ef5 X-MS-TrafficTypeDiagnostic: SA0PR03MB5465:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WzrvBS03KY7erswSgCR//c0lkg66CJYI3hThdAJNH4FlyTCxKMlnbC0YnF1ve+AKvOftzaVb5cx72QHC5igl0SyTD5nOxYSRWcg0w67jYPBR6xNgHzUptJcAyTWVB4PzXYEIBtwbvYLpEYC8jAuvjtnvloc8iKNTfNmEjKP4bhcnXfQkPXV8aczZAZolpPc26CJLFLQ37iT8ROmqcbQ/dBWLBuMgAv8HRkpw7aAjjbDueNvkecmPabDGb8oH3T84eiJP+BRnIni3nSRfTl5DPNOq7EmjR9t7tCy4WWuiA3pJq9sDf5zni4UBgYlSCK8Du5iYGWREV/bfdo33OV3Yn75VSVbCdt3gJzzwbapZ2f9R9/EGv2Yu3uG95pHy05vu+grWiHPTuvDExsuD+nU1laZsj93cvgWbblfmNUxzh6EnLBdNJXODID/t/9nuim4Rn/SlU1C4G3yhsqsmpmEyDGYdH3L3ba7lQLJ5xx0teIbHXc1yAbMB+Hqi+5oi3lx8NIc2UFOuhfZdyNA2oQCEEvOvy/DVWtk73FYkw0Jn5F5hKiFuKcYcEY6MSyb5ueI0eLT8QOdJnQ+K4D55b9EneoAgSmpRzCspMvn2y+OZaJ+hOAygCPd7TpBxC6AfzCnYV618Y+n1rT8u2nvbcYqhcg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(6916009)(6512007)(186003)(6506007)(53546011)(26005)(9686003)(85182001)(508600001)(6486002)(316002)(83380400001)(2906002)(8936002)(5660300002)(66946007)(66556008)(8676002)(4326008)(66476007)(82960400001)(6666004)(86362001)(33716001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmtpQzZ3VmJzdmMzb2d5VFVKLytTM1NkQzVYUFZxRE92aVdJL24zSVZTa3Vu?= =?utf-8?B?eHVMQ0N6NTlrNW81eU5mdzlhR3hKOXVDQW9nMk1NbWUvQ2Jad2o4RGh6S3U0?= =?utf-8?B?SzNzeHJuNE5LWW9ONFNCZ0wxNlg5N0hoTHZXWFNBSG9ic1prZFNLUkF3Vm9r?= =?utf-8?B?VXlmQ0gwV25uS1plZHAyVVAyNHdiOU9wOTVjV1lyM1pCVFdjRCt1dCtXT0dw?= =?utf-8?B?ODc0YXBzOFppNWZNTFNSQytnRnpTOVpXTFlGcU4xM3lVdFJrVnMzTE5JRXNh?= =?utf-8?B?SU1MUzZKZjJFN0k1YkFYeXF1eTkyczJ5QVdpVHA2V0MrbG9vYm1hU3FPVUFv?= =?utf-8?B?b2t5TnlJblhKSnNZVzg0RytlYnZIR0RMTFU3VUdWVDQ3NEFpNW1mVVJhWjBx?= =?utf-8?B?TlNiN05LRjhMa3FMd25rVloxb05LRnZaYlRhSjY2VmRZNkxyeGllbEY5OFFZ?= =?utf-8?B?ZVp2QVF3eHByNVdPNjVKS1IrVFkyeDBGR3I5YVFtQnFIYm03NEptYVR0c0R4?= =?utf-8?B?Z21lNmtMSjVEaFVmSk0xSndYM0Ywc0lUT0lpWGxRWGpPODhvZmxNVkhodWh0?= =?utf-8?B?YnI2ZSthT2pma3hIV2wrNGRNU2h2ZkVJZ1FNZ1lJckFKb0NJeG5LTm41Q3dB?= =?utf-8?B?Qzdac3hxVXpUK2FCTlFHN1EvUHBHNExVcFdaSHFVMS9ScWM0bFlwQ1ZtZFZx?= =?utf-8?B?Q1RmYjJIKys4ZTh6M2QrT0Vac3YxQjhVZEhOTTJ2cXFheXBkMXFyYlRaSEFh?= =?utf-8?B?M1N3Uno3dUQ2ekV4aGdiL0RMaVVtNSt3czhNbWpYSkVzYzBZT0t1bWdZMktQ?= =?utf-8?B?VVFXOXAvSUl1R3lqUklDbWVPTktlNmtPZ1ZYbEE0VDBKblRxdmQyeGFLWXpr?= =?utf-8?B?WTgveXptZGZNT0lpcFo0NFRZZlVKY2Q5UHZTS21lYXA0WTV0MmVVWGRFRlpX?= =?utf-8?B?aU8wSmtBV1BwMzJkRnlCQVZUZHNRMzJJOGw1T1p3cTBHZG9uZlZDMkhkWEJJ?= =?utf-8?B?MUxlNk9Jd0Y0QktnRm56VDU3a3U4cXlveW9SRDVFSVJIQmY3MG43aG0vcXNQ?= =?utf-8?B?Z1ZzTmlVWSs0dXNaWXJlTmdNeFhYTUlyWTRYVzR0eStjTldHR3NlWjRrS3hk?= =?utf-8?B?ZUE2QnJvbkJnMHkzcThqWEM4ekR2N3NPQ1VacEJhRGpGSTJDSXFIdzl6TDhS?= =?utf-8?B?S3crN3l2ZUI3M2ZkYVJRanJ6bHpBbnUzLzNHVzRubGhVdTBYRnVmZ0VmL0dr?= =?utf-8?B?dEZCZ2xkZllQY0lXOUUxaDhDd3VIWlBmdWpRdDd0UStKZ3hoVVNQTTlqcy80?= =?utf-8?B?WkhCQXNGYm9haFhPNVFNZ0t0SUpNNjI2RG5nMGc4d29odVRIdzR1WDVYbUZl?= =?utf-8?B?YjR3SWtzNXQyb2tZQVhpc3dyYjRHcXFYSnNVeFpvWEJmTC80WlppV2MrNWQw?= =?utf-8?B?Tkc3WDhsT0NKT2tCamhVQVYrRDVVSDF0MDcvREdEMTNFdWpDcTVqcW4wb1Fl?= =?utf-8?B?c3hMdWFTRHVIN1owdW9ZVzNmRUc3UHpQMVBQTXpRaGt0Tm5tUEVDWHlpb2tG?= =?utf-8?B?UTlSUjl5dEg1MEZBMDRzdkkzbEdnejFRQlVBQzBvYUY0RGdZaXJJMEFialZy?= =?utf-8?B?RHF3NWhNWFBVaCtuMTdRY1dJUzArQ3hKMC9OMmZ5MGZvblhrVUlnN2U3ZkZT?= =?utf-8?B?TGl5b2N5dnBHUzN5NURsZEt4dUhLdEpVSVQySTc1UlhaSGdLdW5KQUFHcFRy?= =?utf-8?B?K3hXNnR3d1ZrN0RhZEhSakNRRjNvL1ZKNXQrMXhqYXBKbzBxUkE1eUpCMVRo?= =?utf-8?B?MWg2YWpRNVVXWHUrNDJGWmJHMyt5S3RXU2JkY1U2RnF5Q0dFQUpKNmw0TWRM?= =?utf-8?B?WHBRR0JzOGNSRUFESkxxRXkySHM5T0E5VFQ2djk2ekZCeklzSG1udGVYVFQ3?= =?utf-8?B?OVg3NGdXWSs2ZXVVaDRybElOM1k2eGU3MDNwdjBoS2FtMEV4UlFHc29pbk9G?= =?utf-8?B?U2U1M0VoUEhzempPdGVzK3NQWC9MaGxLVFpOY1JHSVNsY21oTjhJelpvbHVn?= =?utf-8?B?cFdqSjByci9IQm1oZk9SZThEVGFZdURQem5OL0hyMEhQSWtVTW9tV1IwZVNL?= =?utf-8?B?bjJuZUpQUlFIMUlVVngzRlpRK2t2WHpCN0p2N3dyc0dlcVZVMldzeXpXeG0y?= =?utf-8?B?K3pTY2VvbE1SM3AvL3Q4aGwyOEJoNXZDb2tNZmF4Z2wzRzA1K2tDcUQwd2xE?= =?utf-8?B?ZDQ5ZFd3bUhKNnhGZDRMRHVpM3VYMTlrSTAxVE5BdXF5R1Z6L2dDUHJQc1Zk?= =?utf-8?B?bEc4Z282RU90NU12S1ZMc1Mrek1uNnRCTzFkSmRZckk5ZEk2N2hrS0NIdklR?= =?utf-8?Q?Ww+UA2kUKolr1dno=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0f31213-1be0-4b5d-7327-08da3ca20ef5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 09:53:16.0907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l5oNoZ4t6S+brlPyA52XsEu0D2mmNCsB4IfZvl99AM4e5Z875hK0nqgNpVKmihpaimVb5q9NyQEqYotcZoNGYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5465 On Mon, May 23, 2022 at 10:12:55AM +0200, Jan Beulich wrote: > On 20.05.2022 16:58, Andrew Cooper wrote: > > On 20/05/2022 15:19, Jan Beulich wrote: > >> On 20.05.2022 16:10, Andrew Cooper wrote: > >>> On 20/05/2022 14:37, Roger Pau Monne wrote: > >>>> --- a/xen/include/public/arch-x86/cpufeatureset.h > >>>> +++ b/xen/include/public/arch-x86/cpufeatureset.h > >>>> @@ -135,7 +135,7 @@ XEN_CPUFEATURE(SSSE3, 1*32+ 9) /*A Supplemental Streaming SIMD Extensio > >>>> XEN_CPUFEATURE(FMA, 1*32+12) /*A Fused Multiply Add */ > >>>> XEN_CPUFEATURE(CX16, 1*32+13) /*A CMPXCHG16B */ > >>>> XEN_CPUFEATURE(XTPR, 1*32+14) /* Send Task Priority Messages */ > >>>> -XEN_CPUFEATURE(PDCM, 1*32+15) /* Perf/Debug Capability MSR */ > >>>> +XEN_CPUFEATURE(PDCM, 1*32+15) /*S Perf/Debug Capability MSR */ > >>> This is the bit which requires more toolstack logic to safely enable.  > >>> Using 's' for off-by-default is fine if we want to get the series in now. > >>> > >>> But before we expose the MSR generally, we need to: > >>> > >>> 1) Put the configuration in msr_policy so the toolstack can reason about it > >>> 2) Reject migration attempts to destinations where the LBR format changes > >> Since this could be quite restrictive, and since people needing to know > >> they need to hide this feature for migration to work, I guess this would > >> further want qualifying by "did the guest actually use LBRs so far"? > > > > In practice, it's every major generation ("tock" on Intel's old model), > > so isn't actually limiting the kinds of heterogeneous setups used in > > production.  (Migration gets steadily less stable the further apart the > > two CPUs are.) > > > > As to dynamic, no - that would be a security bug in a cloud scenario, > > because there must not be anything the guest can do to interfere with > > the manageability. > > > > Use of LBR is rare, as demonstrated by the fact that noone has > > complained about the fact that migrating such a VM will malfunction. > > > > As we now have a way of reporting "no model-specific LBR", > > Which only rather new guest kernels will know to look for. Hence ... > > > I'm tempted > > to suggest that VMs get no LBR by default, and someone wanting LBR has > > to opt in, which is also an explicit agreement to the migration limitation. > > ... while in principle I agree with this, I see a practical issue. I think it should be fine to expose no model-specific LBR support in PERF_CAPABILITIES, but we shouldn't change the behavior of DEBUGCTLMSR.LBR exposed to guests if the underlying platform has model-specific LBRs and those are known to Xen. That way old guest kernels that ignore PERF_CAPABILITIES.LBR_FORMAT will continue to work, while newish kernels that check the format will avoid using LBRs. In case we introduce a guest config option to enable LBR, should we then expose the native LBR format in PERF_CAPABILITIES? Or would it be better to just keep the current model and not expose PERF_CAPABILITIES at all (and don't report PDCM in CPUID in that case). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 10:06:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335738.559917 (Exim 4.92) (envelope-from ) id 1nt4wt-0000aZ-VA; Mon, 23 May 2022 10:06:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335738.559917; Mon, 23 May 2022 10:06:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4wt-0000aS-Rm; Mon, 23 May 2022 10:06:03 +0000 Received: by outflank-mailman (input) for mailman id 335738; Mon, 23 May 2022 10:06:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4ws-0000aM-Ep for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:06:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4wr-0004mf-QU; Mon, 23 May 2022 10:06:01 +0000 Received: from [54.239.6.189] (helo=[192.168.27.249]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt4wr-00054I-Im; Mon, 23 May 2022 10:06:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bMBe0/7TJA3ZaAErtN09mcWAYt7fBGRuH8DYt/jdaXg=; b=vdwrfVtLC5yZXXQrNUhLbuXi1B gkqYwpaFAVPwn+PUcvjky99FIoqjpUuAU8B/uQiSY6iMYr8qWlXHc7qkGT6yXyqzfLazPzDERQ/71 Yhn1CLQKNxzrKeuTZ5CoMhqN2JWSsgvYolCkrR7WKuBOfTjsDW0PolzqnvMsSjR7M16c=; Message-ID: <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> Date: Mon, 23 May 2022 11:05:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> From: Julien Grall In-Reply-To: <20220523091324.137350-1-michal.orzel@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 10:13, Michal Orzel wrote: > Introduce a command line parameter "maxcpus" on Arm to allow adjusting > the number of CPUs to activate. The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. So what's your use-case/target? > Currently the limit is defined by the > config option CONFIG_NR_CPUS. Such parameter already exists on x86. > > Define a parameter "maxcpus" and a corresponding static variable > max_cpus in Arm smpboot.c. Modify function smp_get_max_cpus to take > max_cpus as a limit and to return proper unsigned int instead of int. > > Take the opportunity to remove redundant variable cpus from start_xen > function and to directly assign the return value from smp_get_max_cpus > to nr_cpu_ids (global variable in Xen used to store the number of CPUs > actually activated). > > Signed-off-by: Michal Orzel > --- > max_cpus is also defined in x86 setup.c. It would be possible to join > these definitions in xen/common/cpu.c. However in that case, max_cpus > would become global which is not really what we want. If we move the global variable, then I would also expect to move the parsing parsing (i.e. smp_get_max_cpus()). So why would max_cpus end up to be global? Is it because the x86 would continue to use it? > There is already > global nr_cpu_ids used everywhere and max_cpus being used only in x86 > start_xen and Arm smp_get_max_cpus should be kept local. Also there are > already lots of places in Xen using max_cpus (local versions) and that > would start to be hard to read (variable shadowing). We should avoid variable shadowing. > --- > docs/misc/xen-command-line.pandoc | 2 +- > xen/arch/arm/include/asm/smp.h | 2 +- > xen/arch/arm/setup.c | 10 ++++------ > xen/arch/arm/smpboot.c | 18 ++++++++++++------ > 4 files changed, 18 insertions(+), 14 deletions(-) The patch looks ok to me (see one coding style comment below). I haven't acked it because I am waiting to get more input on your use-cases. [...] > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index 9bb32a301a..22fede6600 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -43,6 +43,10 @@ cpumask_t cpu_possible_map; > > struct cpuinfo_arm cpu_data[NR_CPUS]; > > +/* maxcpus: maximum number of CPUs to activate. */ > +static unsigned int __initdata max_cpus; > +integer_param("maxcpus", max_cpus); > + > /* CPU logical map: map xen cpuid to an MPIDR */ > register_t __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = MPIDR_INVALID }; > > @@ -277,16 +281,18 @@ void __init smp_init_cpus(void) > "unless the cpu affinity of all domains is specified.\n"); > } > > -int __init > -smp_get_max_cpus (void) > +unsigned int __init smp_get_max_cpus(void) > { > - int i, max_cpus = 0; > + unsigned int i, cpus = 0; > + > + if ( ( !max_cpus ) || ( max_cpus > nr_cpu_ids ) ) Coding style: We don't add space in the inner parentheses. I.e: if ( (!max_cpus) || (max_cpus > nr_cpu_ids) ) > + max_cpus = nr_cpu_ids; > > - for ( i = 0; i < nr_cpu_ids; i++ ) > + for ( i = 0; i < max_cpus; i++ ) > if ( cpu_possible(i) ) > - max_cpus++; > + cpus++; > > - return max_cpus; > + return cpus; > } > > void __init -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 10:07:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:07:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335746.559929 (Exim 4.92) (envelope-from ) id 1nt4y3-00019E-9r; Mon, 23 May 2022 10:07:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335746.559929; Mon, 23 May 2022 10:07:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4y3-000197-6l; Mon, 23 May 2022 10:07:15 +0000 Received: by outflank-mailman (input) for mailman id 335746; Mon, 23 May 2022 10:07:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt4y0-0000uU-T5 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:07:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b4ae6e1-da80-11ec-837e-e5687231ffcc; Mon, 23 May 2022 12:07:10 +0200 (CEST) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 06:07:08 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3923.namprd03.prod.outlook.com (2603:10b6:408:24::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Mon, 23 May 2022 10:07:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.022; Mon, 23 May 2022 10:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b4ae6e1-da80-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653300431; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=NqAUvl91fvCKDZuL7Qmvt1rOH7sKyRS+JLSMsm8mKko=; b=UX1fc9KcdIK87+5Q7tVBkQSdrqEC7n80ss6/jjdmysIu7YfATxcwQEaz cOhHIZCG3/oCSvlnqECQMGOLUaJwtoq3qwW1Djo56G+fJwycLwCWFlaIR X/c1tstyOE3+hLeY+DPuaYCrUyQk22cagDleroSPRgR54/S3GHtULHPqv 4=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 71926948 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OTQ33qBON9cGARVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApD1w1DAFz mZOWmvVa6nbZ2X8edlza4y18xsDvMfUm9c2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj2dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhPy /VCtYyraD13faqVyeQ2YUkGPHBHaPguFL/veRBTsOS15mifKz7A5qsrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mbHM0m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx1yOhImEIwL6TjfQU+lWP3CZz6aLKCfzUdPKJS913x1nN8 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXOguuWwgEO6X9NZK mQX9zAooKx081akJvH/Qhm5rXisrhMaHd1KHIUS4gyX1rDd5QrfA2EeVyNAc/QvrspwTjsvv ne3mNfuCS1qoaeiY3uX/beJrhu/ISEQa2QFYEcsTwEI/t3iq4EblQ/UQ5BoF6vdpsLxMSH9x XaNtidWulkIpcsC1qH+8VWZhTup/8DNVlRsvlqRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:IKs4c63rAxr9nF6klEAwFgqjBS5yeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNNaWs19 60TZiAq4s+P/P+TZgNcNvpEvHHfVAkf3r3QRKvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d /8bG8= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71926948" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E/v7u2ANbge2TsrpE/qhQvwSAWRhSTZkEgrxGQOISq+hbUUOOGhua+N/pmFHKhr9RcfK7b+x+gr3NtuyjPqMPob5HxdwGGCwcZiIwRdVagHusWkPDB+blsiztN/14QFrDJ/c7PbaumYY0bN5nyU1UbXgA9tHOQ3luDbS3MDK+noyKxjcWdsNoIk/y2h3F3g4WKq0HAj/IYbtjnsJnvB+rbhWMxE++H05PhSv7pM6SYUzFtmtU4YpyFEVA5xgwb9wmf7eqheX5/ShQRq7yADHk05VxuP3kZDtrQF7EBGQqqovfjV6C9aWjg6NJPXTzTU+nfiXVJTk+M6ke1GkYw3nGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=26E/DV1roI2sAcBvSS0wmnSdKy704aSFtfjk3zOs2Ms=; b=ZStdpMKPAS+/mBxO+lHXPKYE//1msPbS1FKIb3rc44pJb3jBxViN/an3knV1BldkMtR8OY4ZCBLnLjZAEsB96mBn43zH3UJfO48+yIVv+fVyRby1+iyTvIXkVSQ1IA5vBeTpDTvGvvKWmvTQKqaP3iwC+YCY14TZQfvEcYeo32IXXxBPzXnhJMqBmZd+A5d+/ty4h8KcROEvJ9KU/vMYHDDeud1+whurufSPr7Qq7U4nv8NqBE+a8Kpx2lH7oCetZBHhHL8auIdOQc+EepVHaMkMVIx6hU9pvaDO9xyuqeTorvCJ5HW+CmLku+uwCN587PA30Qmpo7OIfFAZgiK4ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=26E/DV1roI2sAcBvSS0wmnSdKy704aSFtfjk3zOs2Ms=; b=cTk7u+1wo4M1BfqXh2eOV99G2HbDwGxsSdK3QQCjxKSXF7IezeWXB6qgoj1TOe16HccmUdpBWYq+HN5qpmaDuhC9PfhC9zs3iikmAzDobfWj+myHcRQRLxUxO2VIcTWu/nvFt6PTeWT774Yq6YIVUWXlKm+wxGf2a1zK3dWN2F4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 12:07:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Lin Liu Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v4 1/6] xen: implement byteswap Message-ID: References: <89b15afe026a84748ac0d9ca28e8608085454e78.1653295437.git.lin.liu@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <89b15afe026a84748ac0d9ca28e8608085454e78.1653295437.git.lin.liu@citrix.com> X-ClientProxiedBy: LO2P265CA0449.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12731ba0-a62e-4bf5-0ebf-08da3ca3fdd1 X-MS-TrafficTypeDiagnostic: BN7PR03MB3923:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: srPx0JmQgOXK8ohO2y8Xu8YH1K0g6RI+PCQq6NmAlMKuXrzN3AMDjWj2DHwde13m/tZT+UjanPIXgFTXUHynEoK+Lqmzui4zIiW/qjOC+5Z6zqMf85ai2GMWklDmu6+yNP0wwLl7vs2DTC5DnErCzuh0K+PimKoBDvQDaGdbMqSwBqAtojjEKro4ndpgpkofHkFQOv2DKiAt5g/IQtoZfszZXcsXEWZO+Wc99Pveh5bO3fL4eC4d3wjP+P2KQhNG/e4ZRDlxD77jB6pjL4pBQC5yhDbiQ0pl670by4b16woVj3fa//r6Fy6NQEG6sFQoHBv57o9BW+SxSXN2VB61hA4pGeIsLJouV/lKSw5n3nUWL0MjWiky+AGB2BIz+7z+Pvgr8fmAnzbulqwMOSdSYSKccPNakAYzblk4oYuNMqtOQHr/4YhZQU7aMg+71KTFoK1ozpLz5P8UH7hs73dK0OeL3e1RU4Z1UDATm1N2USE77APUU7p+teD8Y1rKpmn2MpUw2+Jlt14586JpraFg9ICwDYDhNdK6bS9IwPeCvUyKDMc9i9NbRbrZckjt731KE3TGY6hYxBg9oY94MUgzOUefT+99sSBAw1ckjydrI1mt7o4y2UadfUtQnVcUgBcV4zhnTjY7xC2uF1andN2p5g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(5660300002)(82960400001)(9686003)(6512007)(186003)(8936002)(85182001)(83380400001)(26005)(33716001)(6506007)(6666004)(2906002)(66556008)(4326008)(86362001)(66476007)(8676002)(66946007)(6486002)(54906003)(508600001)(6862004)(316002)(38100700002)(6636002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUZSWFdBTGxXSXlRVlhvNG5wbGE5YmpjY0lxM2FzVEtxQmtXQ0lPUVdLSWZo?= =?utf-8?B?RXp2Z1ZWRktvcHhXQ3JrTHQ1dm1HRldNaGJ1VXdJazB4QWFmeEZCOTRXZWhj?= =?utf-8?B?dWRUOUIxa3puZkNVTWRnTm4vYWZtNzRRaDZ6b3dGYUVSNEh5YTdxVlpleEtO?= =?utf-8?B?SG9vL0hBN1pPRyt2LzhXQVZ2UjJpb0JNRVBPVVYrTDBENG9jQzZHOUNKSTFL?= =?utf-8?B?S2VTRTNGd0Zta2c3bXhNVHZVWldCQTFVN2dRQ0pwblpXNjdiMEtiQ2FKSnlu?= =?utf-8?B?NFpFU1NuWklsQ3cyVE16TWdzczlDN1BzYVNnTnBURXREdlRLYkhYS0JwR21w?= =?utf-8?B?Y3BmbTF4ZnFvV3BXR3VoVkR6UUFDTHRRSXhweHhJQXRVU1JwQ2dBemJhT0Fm?= =?utf-8?B?ek5pOXNaZkdhNzFNMGRSMDZyendubTJNaE41aXR5UWVpQ3VhQThyY1lnTm1y?= =?utf-8?B?RFBMN2czdXZaZGREaGRrTHpScXgvYVUyL1NtMXhJQUtoUDVrVGdpbXBvMHIr?= =?utf-8?B?akFiK3R6cXpxcWhXR1JVSkczTjNTMFVka2Q2UjIzb2dvL1lqWDZ2RzJYcEYx?= =?utf-8?B?K2FnemgrdStaZzkzdzMrKzlSb2hkeDE4dTF4dktBa2lBUVMwRFE2ZTJmSGJw?= =?utf-8?B?ay83RC84ZTVBOUh1T1JXMDYzQUZaTmJIRGR6Z3JjWEZncEZwR0kyTnRlWEtP?= =?utf-8?B?bFRMNDhBSS82cEdPaXRHbHZlMUJ0UGswUlVZSVkyS0d5d3gvLzk4a3BJbWo5?= =?utf-8?B?d2hzakFGN1VweFlCSUR0ZVlqbnJDWkUvemRBWUxUcStMbU5GUU1tQk11T2JP?= =?utf-8?B?VDBKZFRHRm0rWGhJVU93QWtiL3BsdkFwL3RoaSszVnhPbXVFUWZQdjF1VS9S?= =?utf-8?B?a2tqdWI2RzRTb1dPeFBWNHNmUTNQVS9IQ0tZVWJFa2doZml4ZXFRWVM4cVpO?= =?utf-8?B?QVVGdDB5UWdXSmJWQ0xla2hxSFR0QVdycDFyNlQzWXNWaWNMdzU1cVJFQzVU?= =?utf-8?B?SkVIYThWaStPRWpkNTZGenFaYU5Pbi9iUCtubmxMMy9wZ1RVcjVkQ2Jtckd1?= =?utf-8?B?NnQyZjhiZC82UlJiTlRsNjlXTjN3a1ZRTGczdkhxeUpDUlUwSFpVaEJCVExX?= =?utf-8?B?M2lGc1J3ZVFPczB1SmtDekhmZi9qWkhaSWlRR0VreGNjOExrWStCY3diZzUw?= =?utf-8?B?L2ZybndvZnFmVzM3T3NqNmhYM3lkYlJaR2N1SUE5MjVPTTZKVGtTWDBhRnVK?= =?utf-8?B?M0VZb3p1ZXVvSmFtckl2MytzWWZtdXhSTSt4WnJ6UnRLdVdLcHJlUWNIZE9x?= =?utf-8?B?M1VkUVhoMEVmZ3ByV28yWENWMnU4TElVTU5mai9UU0RhN3Z3bXRmQVdLZWM3?= =?utf-8?B?SkNVbk5zL09DYmNaS21ZYnVCUGlXVHc4SzhBZmo2TGhKdFhRU1RCS1BCY1ZD?= =?utf-8?B?ekJMTExoWWxwbVBnSng3OW5WVzNPaGg5MWhCLzlmWWdvRVd0VDdnaktiVWMz?= =?utf-8?B?anlKWGNUcDJ1eFBKdklYTFc1UFhwU1BsN0V0QlRVdlp3aW5JNU5wSkFGdGVU?= =?utf-8?B?Q1l5eUlqQnR1VVhTU3FKVUxIMHBydGhyM3lwUWdIeFJqQ0dtWG4zdWpxVjZ0?= =?utf-8?B?RnFKOFZMbXlsb2gyQUprcFgvOWFSVmxubkYxM29JQzUzOExnWDRkQ21ZUS9R?= =?utf-8?B?UlZQZUNvaUFic2RNRWJDS3FWMi9rOXUvY0FtTFFrUFgrTEl1R0VpRXo3K2Iz?= =?utf-8?B?S2tBaWo4dmxiR3hSMU4yRHpCRUUvbHgvaUFuekxNa0VrWGUxNGQrQzF0alhY?= =?utf-8?B?S1YyMkVGUk14K0RhbUFOWWg5N1J4eXBBTUV5d3o3ZmdsRll4bWJsS0JjMnRV?= =?utf-8?B?RkVPT05jQ2FvWjBTR1FlZ2x3WEVTVWJzKzM3TVhJbU9IWUVVcCtEdVlsYW10?= =?utf-8?B?QkxUWnl2SWhHb25nRXZSNEZ4MHRvUnA2Y1ZvdGVPNHo1eFAxcjVwM3B1WHVI?= =?utf-8?B?d1pHOXo5L2JLemZMZ3hRLzdyRTltdTkzeEhYTFpZd2R5TU40Sk1oWjQ3T081?= =?utf-8?B?b1c0UStBU1MzTHVyMUxLejY5TE9XSkkrUHlLN1hVYXY3RGk1VTVxTnh0SlEz?= =?utf-8?B?ZXNGeGtUQy9iNHI0ak9tV1FCWmYzL082aEU3UlNUOEhYQk9XTUpLcis5RWZ2?= =?utf-8?B?VXlNR0Z5cVJxaHlObWNlNitBUVVwZ3FnVE9nSncxRVVCVDNsZVZuNEExcmRo?= =?utf-8?B?RzJYVmpFY20rZ3pHOXZVMzBWTXJNYUhxQ3Y0YlM5djNFSXhFaVNqNkVxdWll?= =?utf-8?B?YjhvdzFLR3NEem91YlR3MjgzNGc0NG1pdW1RMGl6NEhHNUZKUENFc0hOK2I2?= =?utf-8?Q?kQR7+3E8MnAsilrw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12731ba0-a62e-4bf5-0ebf-08da3ca3fdd1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 10:07:06.4049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kk71R3jyPwCrI91JcKqFdtyDLSfPWNWiXyL5illFzAokO1Rnjjf8SON01PzGuSHYeS5EjGTvn/jVZ8NDEDCbLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3923 On Mon, May 23, 2022 at 05:52:17AM -0400, Lin Liu wrote: > diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h > index 933aec09a9..ae029afa14 100644 > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -185,4 +185,28 @@ > # define CLANG_DISABLE_WARN_GCC_COMPAT_END > #endif > > +#ifndef __has_builtin > +/* > + * Backwards compatibility for GCC < 10. > + * All supported versions of Clang support __has_builtin > + * */ > +#define __has_builtin(x) GCC_has ## x > + > +#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >= 40800) > +#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >= 40400) > +#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >= 40400) > +#endif > + > +#ifndef __ORDER_LITTLE_ENDIAN__ > +# define __ORDER_LITTLE_ENDIAN__ 1234 > +#endif > + > +#ifndef __ORDER_BIG_ENDIAN__ > +# define __ORDER_BIG_ENDIAN__ 4321 > +#endif > + > +/* Indirect macros required for expanded argument pasting. */ > +#define PASTE_(a, b) a ## b > +#define PASTE(a, b) PASTE_(a, b) I think it would be better if byteswap.h included lib.h, rather than moving the PASTE define into compiler.h. Likewise the __ORDER_{BIG,LITTLE}_ENDIAN__ defines would be better placed in byteswap.h itself if possible IMO, since it's not strictly related to the compiler. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 10:10:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:10:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335755.559940 (Exim 4.92) (envelope-from ) id 1nt50u-0002ce-UQ; Mon, 23 May 2022 10:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335755.559940; Mon, 23 May 2022 10:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt50u-0002cX-Ql; Mon, 23 May 2022 10:10:12 +0000 Received: by outflank-mailman (input) for mailman id 335755; Mon, 23 May 2022 10:10:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt50u-0002cR-2i for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:10:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt50t-0004q8-Ov; Mon, 23 May 2022 10:10:11 +0000 Received: from [54.239.6.189] (helo=[192.168.27.249]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt50t-0005UP-JP; Mon, 23 May 2022 10:10:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NrNGLlysh4CwZvmcEHWxtNCj64YCukx3HAn9Z5exPz0=; b=vZFxneiqvz7wckdqTLohyN2D9K BtiNwF72tAvqPTYDnft57sLm1aEkzONnkdz85G309dNgu22ok7enA8bWY0JEees69dk6zZ87fH8ef nILQuEi4Dy0s7rpGyGGLp57qouHOCd3BdS0DJZzLTcERa8f8EkhDiY7vZSCOQ3t7Foww=; Message-ID: Date: Mon, 23 May 2022 11:10:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 3/6] arm64/find_next_bit: Remove ext2_swab() To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <906b399ee86969fb86304c60c3b725326620d50f.1653295437.git.lin.liu@citrix.com> From: Julien Grall In-Reply-To: <906b399ee86969fb86304c60c3b725326620d50f.1653295437.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 10:52, Lin Liu wrote: > ext2 has nothing to do with this logic. Clean up the code with > xen/byteswap.h which now has an unsigned long helper. It looks like my comment in v3 wasn't addressed. This could possibly be done on commit if there are no other version. > > No functional change. > > Signed-off-by: Lin Liu You forgot to carry the tags from Andrew and I. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 10:12:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:12:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335764.559951 (Exim 4.92) (envelope-from ) id 1nt53M-0003FN-BR; Mon, 23 May 2022 10:12:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335764.559951; Mon, 23 May 2022 10:12:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53M-0003FG-82; Mon, 23 May 2022 10:12:44 +0000 Received: by outflank-mailman (input) for mailman id 335764; Mon, 23 May 2022 10:12:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53L-0003FA-8u for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:12:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53K-0004uc-RJ; Mon, 23 May 2022 10:12:42 +0000 Received: from [54.239.6.189] (helo=[192.168.27.249]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt53K-0005rG-Kf; Mon, 23 May 2022 10:12:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TZYJXEONpXWC5QOC3nHKsqTq8o3wfdN146Gq25qnHXo=; b=Mzc4J3pCHORuq82i514Jdc6bBj fVb1AuOhIOL2FqzguAiRyjC7OK4oPzrZiaxx1WfCBXaUDo0nBLgXsvSuyLVkGv6/hDmSRTqQ55AJG 5EJurcTfuKwPIt7SM1MV2hjaT/pQdVEQKmY5o6+SNPAxgMPLNSTDUcvfBOw41REXniWk=; Message-ID: Date: Mon, 23 May 2022 11:12:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 4/6] xen: Switch to byteswap To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> From: Julien Grall In-Reply-To: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 10:52, Lin Liu wrote: > Update to use byteswap to swap bytes. I am still objecting on switching from be*_to_cpup() to be*_to_cpu(). I will not Nack, however the strict minimum is to explain why you want to replace the helpers as I think the reason that was currently provided is incorrect. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 10:21:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335772.559962 (Exim 4.92) (envelope-from ) id 1nt5Bh-0004kP-60; Mon, 23 May 2022 10:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335772.559962; Mon, 23 May 2022 10:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5Bh-0004kI-27; Mon, 23 May 2022 10:21:21 +0000 Received: by outflank-mailman (input) for mailman id 335772; Mon, 23 May 2022 10:21:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5Bf-0004kB-LT for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:21:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 14bf242b-da82-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 12:21:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8352A11FB; Mon, 23 May 2022 03:21:16 -0700 (PDT) Received: from [10.57.7.84] (unknown [10.57.7.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7CD1B3F73D; Mon, 23 May 2022 03:21:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14bf242b-da82-11ec-bd2c-47488cf2e6aa Message-ID: Date: Mon, 23 May 2022 12:21:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> From: Michal Orzel In-Reply-To: <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Julien, On 23.05.2022 12:05, Julien Grall wrote: > Hi, > > On 23/05/2022 10:13, Michal Orzel wrote: >> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >> the number of CPUs to activate. > > The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. > > Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. > > > So what's your use-case/target? > - use cases where we have no big little (although even on big.LITTLE limiting this number makes sense if we do not care about the types) - debug cases where we want to set maxcpus=1 >> Currently the limit is defined by the >> config option CONFIG_NR_CPUS. Such parameter already exists on x86. >> >> Define a parameter "maxcpus" and a corresponding static variable >> max_cpus in Arm smpboot.c. Modify function smp_get_max_cpus to take >> max_cpus as a limit and to return proper unsigned int instead of int. >> >> Take the opportunity to remove redundant variable cpus from start_xen >> function and to directly assign the return value from smp_get_max_cpus >> to nr_cpu_ids (global variable in Xen used to store the number of CPUs >> actually activated). >> >> Signed-off-by: Michal Orzel >> --- >> max_cpus is also defined in x86 setup.c. It would be possible to join >> these definitions in xen/common/cpu.c. However in that case, max_cpus >> would become global which is not really what we want. > > If we move the global variable, then I would also expect to move the parsing parsing (i.e. smp_get_max_cpus()). So why would max_cpus end up to be global? Is it because the x86 would continue to use it? > Yes, that would involve more x86 modifications that actual Arm coding. That is why I wanted to avoid it. >> There is already >> global nr_cpu_ids used everywhere and max_cpus being used only in x86 >> start_xen and Arm smp_get_max_cpus should be kept local. Also there are >> already lots of places in Xen using max_cpus (local versions) and that >> would start to be hard to read (variable shadowing). > > We should avoid variable shadowing. > >> --- >>   docs/misc/xen-command-line.pandoc |  2 +- >>   xen/arch/arm/include/asm/smp.h    |  2 +- >>   xen/arch/arm/setup.c              | 10 ++++------ >>   xen/arch/arm/smpboot.c            | 18 ++++++++++++------ >>   4 files changed, 18 insertions(+), 14 deletions(-) > > The patch looks ok to me (see one coding style comment below). I haven't acked it because I am waiting to get more input on your use-cases. > > > [...] > >> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c >> index 9bb32a301a..22fede6600 100644 >> --- a/xen/arch/arm/smpboot.c >> +++ b/xen/arch/arm/smpboot.c >> @@ -43,6 +43,10 @@ cpumask_t cpu_possible_map; >>     struct cpuinfo_arm cpu_data[NR_CPUS]; >>   +/* maxcpus: maximum number of CPUs to activate. */ >> +static unsigned int __initdata max_cpus; >> +integer_param("maxcpus", max_cpus); >> + >>   /* CPU logical map: map xen cpuid to an MPIDR */ >>   register_t __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = MPIDR_INVALID }; >>   @@ -277,16 +281,18 @@ void __init smp_init_cpus(void) >>                       "unless the cpu affinity of all domains is specified.\n"); >>   } >>   -int __init >> -smp_get_max_cpus (void) >> +unsigned int __init smp_get_max_cpus(void) >>   { >> -    int i, max_cpus = 0; >> +    unsigned int i, cpus = 0; >> + >> +    if ( ( !max_cpus ) || ( max_cpus > nr_cpu_ids ) ) > > Coding style: We don't add space in the inner parentheses. I.e: Noted, thanks. > > if ( (!max_cpus) || (max_cpus > nr_cpu_ids) ) > >> +        max_cpus = nr_cpu_ids; >>   -    for ( i = 0; i < nr_cpu_ids; i++ ) >> +    for ( i = 0; i < max_cpus; i++ ) >>           if ( cpu_possible(i) ) >> -            max_cpus++; >> +            cpus++; >>   -    return max_cpus; >> +    return cpus; >>   } >>     void __init > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Mon May 23 10:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335781.559972 (Exim 4.92) (envelope-from ) id 1nt5Rr-0006Jm-Hu; Mon, 23 May 2022 10:38:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335781.559972; Mon, 23 May 2022 10:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5Rr-0006Jf-Eq; Mon, 23 May 2022 10:38:03 +0000 Received: by outflank-mailman (input) for mailman id 335781; Mon, 23 May 2022 10:38:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5Rp-0006JZ-Ld for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:38:01 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 699be87c-da84-11ec-837e-e5687231ffcc; Mon, 23 May 2022 12:37:59 +0200 (CEST) Received: from mail-mw2nam08lp2175.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 06:37:52 -0400 Received: from SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) by DM6PR03MB4457.namprd03.prod.outlook.com (2603:10b6:5:10c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Mon, 23 May 2022 10:37:49 +0000 Received: from SA0PR03MB5610.namprd03.prod.outlook.com ([fe80::61c5:9817:f069:7366]) by SA0PR03MB5610.namprd03.prod.outlook.com ([fe80::61c5:9817:f069:7366%3]) with mapi id 15.20.5273.022; Mon, 23 May 2022 10:37:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 699be87c-da84-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653302279; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=M/poI189oI/8Wbtz8x/tDJDFP/o0qwNXuYj9zgEveW4=; b=YxuQKTnZti+YdwTQse98/X3UyzXvoWhjPe0w0S9taXm8AWRy8A25/noH 7iQoooVoWr3JyHKN5rRF4JCnL622S0pDGcttLqln0k8FcKSAOee7+j8ey y4rYvfEh1L7hdBemgT4hR62jrHbAZFVzOMvi8ULXK1Y1ZPHOhjSC6jNgO M=; X-IronPort-RemoteIP: 104.47.73.175 X-IronPort-MID: 71301426 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YXX8Jqh6ySHcXAogTZZHjVgCX161FhEKZh0ujC45NGQN5FlHY01je htvDTqCOfyONGfwKNxxb4S39R4O6pPQxtUwQAQ4+383FXsb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnW4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YR4MN6fThf1CaRJ/LWZabJ8Z/JzAH2fq5KR/z2WeG5ft69NHKRlqeKgnoKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQehWht7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wvO/fNruTa7IApZwrvGE/PuI/OwVZt5gmiYj 0fD9jjcK0RPXDCY4X/fmp62vcfOnyrwW5kVEpWz9v9jml7VyXYeBRsbU1f9puO2zFO9M/pPJ kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJS1e2W4q/d4gLcA3deSDdEMIwirJVvGmFs0 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poad9e3Yq 9xSkBUDug== IronPort-HdrOrdr: A9a23:PtMSaKztg8tDsmDWUZpiKrPxsOskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu vr2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJToLHQQu5gWihS6hrOeSKWnR4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0ve9Y5fltfNwsZKQOaMls8WADPxjRvAXvUpZ5Sy+BQO5M2/4lcjl9 fB5z8mIsRI8nvUOlq4pBP8sjOQpQoG2jvH8xu1kHHjqcv2SHYREMxan79UdRPf9g4JoMx8+L gj5RPUi7NnSTf72Ajt7dnBUB9n0mCup2A5rOIVh3tDFaMDdb5qq5AF9k89KuZMIMvD0vFoLA BSNrCc2B4PGmnqL0wx/1MfiuBEZ05DUStvGSM5y4+oOzs/pgEK86JX/r1cop46zuNCd3B13Z W6Dk1WrsA+ciY3V9MIOA5Te7rBNoTyKSi8QF66EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06 j8bA== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71301426" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXJqfJ+e/v6EFrP9iCYYnabWFatyJRaHIlp6y/KeaMc8CIVbqZfYHdC1daRFNDYUfka6O1JtCMkvdTPhEqjJKrTK47gdJx7jajT5w1aNSzvl8bHOGNJkCs1VItZ4Q6zzsWevWBP0BKWJqJzwpZ/6y46h+1HdZRi31uCdJivr5UopJg/aHKQ6/gMtlHabwVIIfE25ykniK5Q6ZEFex+AsxjAz7G/GsfoQ83dDkom2NqLsB+Ud/Ppi27X3ai0ArnhgFkufmRGDvel0L3YtMRjGEavuwmm4sT40pu/CtLSak6Mv0OywevxzsNwZw0ZbKXxcTU2E8v9TukMqNLidd5vwYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pvPiP3XIPhYMazso9R/CXHqNFQUch3dpHlo/Sg+grhY=; b=Ig0nRZzeIS8Kw1FBq6lhGD/njJ+nyRIjRrVPB0bRIUcYvf62ZluRwQBqmyZUvSGBPTU1L0i0ztwOOgR9k8K8Cajv7it7gpDzytUZr1bzKbQxLHNMExWRAnQstWb0boCV0244BzQtMWRmpLYthGMZng+7LK5VPEXAaVbqgQIryg53Ab0itet2FewV0QCws8MR1Ex7/9HHtS4O3P44P1nFdR/3gPqsuPHIUIY7u9zD1yW/kTIV9dCMgRHEWpPQXs0fIsyMNw8Kf0owgFJGAFcKK8ycpx2w50n6fWbrccVO8yScm1Pd6OtZtQaMiVFFEB4eVjctNWm6amGwVKcnrQKc5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pvPiP3XIPhYMazso9R/CXHqNFQUch3dpHlo/Sg+grhY=; b=U+vwJC47N/Z1gigZsesk11MxGnXyDfHvdMNaOnD/Dffr2hhAVZNypCHUYC/5r/+MwjjaAZDGeHEySKyaQpJjnQ0MV7TIl071qb5wUJkBOaC5IuRKdymCNTgBq+Tre8OgEnGBlGai1sLYY4iKbmx6RCXH94ZLWMrPVzmCX22e7qE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 12:37:44 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ian Jackson Cc: Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [OSSTEST PATCH v2] ts-xen-build-prep: Install newer NASM version, to build OVMF Message-ID: References: <20220519105525.211344-1-anthony.perard@citrix.com> <25223.51335.932439.379210@chiark.greenend.org.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <25223.51335.932439.379210@chiark.greenend.org.uk> X-ClientProxiedBy: LO4P123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::6) To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81d16bb0-7941-40cf-d834-08da3ca84859 X-MS-TrafficTypeDiagnostic: DM6PR03MB4457:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DSdkE+PXhPYY/atWjuEzPh3ck+2k9DoCxXrKpLggUZiIW611BPODuOcO7KBdPZTIBO1B4E286iIg8114dqpo0HApsXpATWungnuQ/imcgf7kPV05yXwQfeC33xOLsWVVpbELL6B6yUYFwACPuJ0I2KIM6ynwnoZaCuOB3xaFyRKkkXAKEfPU4ln57MaCaI7cJsaVY/qA3e+UQzrnOO+DgQkV6g22QasSJMsD3Nxdw7LYfeL47HNo7BLwXY7L84xTQxMVLfiGyQ891eJq0LHqC4cTVO4Lg2Wpi0Oomukdq/OrWK3GwdOJjtsKXHAuJUJRh5UudjdMn4B4etkIbKxSR1UKpRiCbYlLrxvpsrLeBBNFPHqM9LBKnYlQvDj4vQnFUIl6pupqYSiRatEMhDK5Ai8onSa2136upPZGGjsfl4w/t+PZRxtIOWmU/EFlwTWe1936mQDxvF4LRTTzzbB6L5JODFJ/RaGH2U03W3qHq7OEykLJR1RkBH20T/jxpuxXPf6xB3uImTV1J4l8WWHwyZ0RuT0fmhf+fKGS+nh/LtcdtrycGwpjet3i5PSm5QNFoXeAE8WiUc8VA0ceQwXGkMp/8lbsxtkBx92Se/tzMapbsA5opZf1HllvHnrAbWRI6JAU5q8v4LcsiOQAly4C8fYpYuKPlbhOvId41f/l1224un9B+aKxl2nkiQK7SvE/WDL5b3fTnH7cuxMqi6SyH5Pl7Cxl4k1iFFYNJN57E9L1oo9F/z9tq5mu66gmU7X88Yb75KlxRh3d+e/sAtMkAZi0xg9hWgktZgpyvCKfFds= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(66556008)(4326008)(66946007)(83380400001)(66476007)(966005)(5660300002)(508600001)(8936002)(8676002)(6486002)(6666004)(9686003)(6512007)(85182001)(26005)(86362001)(38100700002)(6506007)(33716001)(2906002)(6916009)(4744005)(82960400001)(316002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3dPVFZ3NDM3NnVnSzRPVDQ1YzBnN3krYkR4cUpORktOeWdzb0dZTlF2RlNJ?= =?utf-8?B?YmF1QVNDWWVWV1l1dFlaVVhsWk9wQkdlZTFvNFdadkZ0Z2FsWklpYnp0cWpT?= =?utf-8?B?UTNnM2N5S3dUK09tUWZwMHRhMHNXZHpuMWFyYnlDVWFMa3BvSVpzaVVhQnVk?= =?utf-8?B?OWJ6T3AyeitRVTlDQUZCdGp0Y1RmMDNMbk83R2doSjNTYlhFVk1PcTJib08w?= =?utf-8?B?VHRuRGQvLy9tWGZGbk9NMitoSGpmU3lrUS9OQ3k3VkgzaTh0cUM4cllCL3V4?= =?utf-8?B?Z2tKOXRFYmxyZzdkcFJVSFNIL2F0clRZT1laRDN0ZmpqR1ZJaFp6VDJEekty?= =?utf-8?B?NWxZUXRRVVJHS1NTa241K09zUEpaY015SzN3d0dhd2xveTRwM0pBN0pBakVY?= =?utf-8?B?NjNCT3JCTVJGMGRCVVBLMk5mZGQ5N2w2dktNbUJrZEpIRCtwaXp2UWUwSFBx?= =?utf-8?B?S3BMVnVLVHVXanF4NXR0ZUJuZmdmRHJ4QjJlWERLSmMwVXd1UzJuOGIzd3Z6?= =?utf-8?B?SVA0RUtyQ1VtSDZEUC83UmNyY3g2S3IzRWFOWWJWTlRwSnRtSzdNd3JqRUJh?= =?utf-8?B?Y1ZKcXp4TjF3K3YvdXZsVis0Z3BXMnVLV1dlWFlhaCtyS0JpMEp5WXhDdm11?= =?utf-8?B?STJwNXRMNDB1TTF5N29PakJnY2t5ZFI2dXBFc3lsNDFZaUV6QTh5RTRwYjhj?= =?utf-8?B?Y0tZeFBFTURZK0hqUEI3S3Bqekdxczd4UzBGemRFbnNiVTBJTlFOajFxQjBo?= =?utf-8?B?NUszUW9xY1BGUVRUYXR5VW8vcmt4NmpjZ0ZzS3V1R0tHWTRuc1ZoRFp3VW1G?= =?utf-8?B?VzJWd0ZXRmZlN3hubHBhSzY5VElQRGxPUnBSd1RlZkhvVHlFQ1J6RDRMWTBC?= =?utf-8?B?RnhCa3BZQWFjNEM2ZlM3azhDVTJ5WHNpU3hKU1N3N0hiZTcxS0Nmd1RiMGJ6?= =?utf-8?B?c2RSemJTVWZNbU1YSGlid1phNUlYOFR5UGR3cWtGZUI4MkFCQUdTYmp6d2Z4?= =?utf-8?B?L0VETE1IY3lkNHd1UzU2dXlhRlhHQ3N2Y0dDTHFsM2ZUMjJ5UCt0bkRJYjYz?= =?utf-8?B?TDQwdDA5RlAzMmJGR3dVTmRTemNIV2Ztc0xIWlp1WXJZYTAwYjUrb1lFTmxV?= =?utf-8?B?RjZLVm9hWWhHNkJNcDJCTktOdUlPMkRkTkpHUWJ4eWQvd1ZaLzdyaEdUcTNo?= =?utf-8?B?V3NrNVZnbGxXdlowb1dEOGxDeXg0TCtmNnV1Qy9rRWh5cnpnOElJb3hKTThm?= =?utf-8?B?c1JKcGNzbHBGdEw0NlMzVFk5b2JQK1B4Tm9JOGoxVHpzUGhQUW4wTkgrRk5s?= =?utf-8?B?Tzl4L09MTlg5SzlDWC81Wnl1QzJlUHN5R28wRkQ4N01yTzRPWlp4Ym9CRWM3?= =?utf-8?B?ZTFqZEozdklnSWNLV3dwS3F1OC9aYTZKQkZEVUlVTnduYnkrWDFnd0YxT1k3?= =?utf-8?B?Q3ovU3lVcFdUaWYyeDM4NXBuNHFHdXd0ZHFwdk5WeHc0Z3RKSzlqY050WTZ6?= =?utf-8?B?VStCazE2RlpQUWtRRWNXMk5MT3VsTGwzVW8zbThYNTJsRlZMM1BMcGIvOUUz?= =?utf-8?B?Y0djL2QvM2h5MThYNGtnTTI3MUxXUjZZMDdNbGQ2TlFaN3pUMHpxSDVheStn?= =?utf-8?B?dWFIblZ3LzBYb3JHZ0dXZTNnNVJIZ21UZHpHa1lTOWJhNkg1WnY3M3BVNXhB?= =?utf-8?B?TGdwZkVNR3k5UDE1UXFPalJXZVRhOWdZYjhRV1F5Y3FUa2FYc2ZWb2N2SXJh?= =?utf-8?B?QnNlSHpiMjVtUmg4WXkvN1dqTFFvQ1VkY3hGTEd6MnVCTW9hY2gzcVFnNlFz?= =?utf-8?B?TzRWOWlPRVZ5S2ZmTkNmL043N1llUSs1eldKdE01YnpNMHhYNDg0dzF2SVFm?= =?utf-8?B?dGd0cnNOc1FXZnVQM3lLUStGVU0vMk1HZlg1QlFCZ3JRN285OXpCVWJsNDBM?= =?utf-8?B?YnVnMDdIZGF4clY2M0dicU1ncU5waFZuUzRXeDYzaFpqL1hUNzJteWpmLzJy?= =?utf-8?B?ODJOOUpkRll6NzhqdFFIRzc5dTVQTzNaVFg4OGZndk40SElqZzJlSzNoWlNP?= =?utf-8?B?Nm9SSDNDYjhTWWxYNWp0SDI2K0dXcmw1MmptZGh4ak9BVmxoZkFIaWR2dzI4?= =?utf-8?B?OWdJZmNKcXlEZWhWOVF0VHpnR1ZXZStOU21LSW83WEh2N0wzaTFLQXJnaXk5?= =?utf-8?B?TFlBOEZmeFRpUkJzVFl1NmhBT1poSytzbFcwSWZUYlMwNmg0c1JJY3d6MktQ?= =?utf-8?B?SW02dDVpRk95ZERxdCtCd0pUdGlqWjFnQk9vZlZWSWhxNmhvTVo3NW5sV0ZL?= =?utf-8?B?bG01c2NtelIzRmNrT21QVTRZaTNIbW5RWlBaRmg1OEsyMmdkMExSd3hSU3Nn?= =?utf-8?Q?drr5LupH85naLvrk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81d16bb0-7941-40cf-d834-08da3ca84859 X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 10:37:49.5177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TGTjle4XwKNG2JTZladf7kA61vLQc2pTrPWVeKPBrg/vP6AQ50mSCjtmAffIatmTUd+lFRaecEDgc8iQYP3/yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4457 On Fri, May 20, 2022 at 05:57:43PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[OSSTEST PATCH v2] ts-xen-build-prep: Install newer NASM version, to build OVMF"): > > Recent versions of OVMF now need a version of NASM that is newer > > than the one available on Debian oldstable/buster. They want to use > > NASM 2.15.05 [1], which is available in Debian stable/bullseye. The > > need to use a newer version started with d3febfd9ade3 ("MdePkg: > > Replace Opcode with the corresponding instructions."). > > > > There is no backport package available but the nasm package from > > Debian Bullseye can easily be installed on Buster as it has few > > dependencies and are already satisfied. > > > > [1] https://github.com/tianocore/edk2/commit/6a890db161cd6d378bec3499a1e774db3f5a27a7 > > ("BaseTools: Upgrade the version of NASM tool") > > LGTM assuming Roger is also happy... > > Acked-by: Ian Jackson Sure, I'm gonna push this now then. Thanks both, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 10:47:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335790.559984 (Exim 4.92) (envelope-from ) id 1nt5bF-0007nG-HA; Mon, 23 May 2022 10:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335790.559984; Mon, 23 May 2022 10:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bF-0007n9-E6; Mon, 23 May 2022 10:47:45 +0000 Received: by outflank-mailman (input) for mailman id 335790; Mon, 23 May 2022 10:47:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bE-0007mz-0n; Mon, 23 May 2022 10:47:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bD-0005UZ-Tm; Mon, 23 May 2022 10:47:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bD-0000wl-FN; Mon, 23 May 2022 10:47:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt5bD-0004HG-Eu; Mon, 23 May 2022 10:47:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B+UUn+7dGH3mE1Ao/OEVWs8VaJGzT3U4ubTKpPPxIMM=; b=MOwdsBhiJtbCbBuv4aFNyJ9Y15 5PUPiwZ6pXJ2e6+chFRHb4DyLM/f7HMv7gW83DScVb2B161vUIA8J4fWWJ7baQlesgg5vk4zZwyEN n+SE9V40m6xzZgiGAAh/eZGs3QheYL8o1NGOONXKpp1fKD16WDGtlApFUzIOTX/hN+JY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170687: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-qemuu-freebsd12-amd64::broken:regression xen-unstable:test-amd64-amd64-qemuu-freebsd12-amd64:capture-logs(25):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Mon, 23 May 2022 10:47:43 +0000 flight 170687 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170687/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd12-amd64 broken Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 25 capture-logs(25) broken pass in 170657 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail in 170657 pass in 170687 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170657 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170657 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170657 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170657 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170657 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170657 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170657 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170657 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170657 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170657 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170657 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170657 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170687 2022-05-23 01:51:57 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 broken test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-qemuu-freebsd12-amd64 broken broken-step test-amd64-amd64-qemuu-freebsd12-amd64 capture-logs(25) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 23 10:48:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335797.559995 (Exim 4.92) (envelope-from ) id 1nt5bg-0008Lp-Uw; Mon, 23 May 2022 10:48:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335797.559995; Mon, 23 May 2022 10:48:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bg-0008Li-SF; Mon, 23 May 2022 10:48:12 +0000 Received: by outflank-mailman (input) for mailman id 335797; Mon, 23 May 2022 10:48:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bf-0008LW-Hl; Mon, 23 May 2022 10:48:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bf-0005VG-Gx; Mon, 23 May 2022 10:48:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5bf-0000xB-6Y; Mon, 23 May 2022 10:48:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt5bf-0004Ho-66; Mon, 23 May 2022 10:48:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EEHfFZvk1kR6DQnXC3+XGLa+uIoiAxNXHTxZp1sLitA=; b=3GOtu9zRgmVyjTKpylH0YezwvM 718wY+09qQM4PJsrnH8UdmAlTL341CIhVXM1aNdms+3/xc8Ne2cPTYfjWIszZ38TJCta8p3zy1+DT 7ebz7cE2BktKyEkM/WAEgWSJMPD4jWwzlcBGUcApBqZFQ0Rfbg/Vx5+Mki4PHXUqfYz8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170698: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 10:48:11 +0000 flight 170698 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170698/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1186 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 74 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 10:53:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 10:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335811.560006 (Exim 4.92) (envelope-from ) id 1nt5gD-0001R5-Jw; Mon, 23 May 2022 10:52:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335811.560006; Mon, 23 May 2022 10:52:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5gD-0001Qy-GA; Mon, 23 May 2022 10:52:53 +0000 Received: by outflank-mailman (input) for mailman id 335811; Mon, 23 May 2022 10:52:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5gB-0001Qs-LR for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:52:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d02d01f-da86-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 12:52:50 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-tgE6k_ksP82er3EjCQEt1w-1; Mon, 23 May 2022 12:52:48 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6364.eurprd04.prod.outlook.com (2603:10a6:10:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 10:52:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 10:52:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d02d01f-da86-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653303169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lwYsk84wKLhX0rmAw6x74J75fUUGmQwcf+s9UsX9G6U=; b=Qp60Pyfknqw7JdWzz1SHrrNHFvbmgrcX9HUo3ObIWEzoh6vkUvsR8m3Us6Qlr64BP6/RfS 0daQxJ+p9++PgihHQRD+fMCZdFIpV5o4z174Po3+phIoMk6v8P11X3i1xVVh7GrhbBuU+q RoebmJUUhJYKo8VnprELTIAM3gY4eSo= X-MC-Unique: tgE6k_ksP82er3EjCQEt1w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gR0GPt30ZqPtCyt9zUV2X+SVzdjiZ3Cu22NWw4XdSzaxmU5WlAYpcRasxL2j//1En1WGCI2rLZd4V3DKTeWinHRulaA379dLYdAgLJL43CujGFzOZL4/bK2JN1NjWCvDqZbrYcn3/3ktZ3WA6CjMSciKKvEEiEd5MffqY0d+5DhIEWN6/fsesgtX6c2NYcR0ymT/ji+uC0D7Oquiu6YvCuzGRPKYM6f/MmXgfvGR8u/Dd9gyTAHfDEOgiKj/6tW+Be1Y7NvBCdGO2ie2pZ+Zdq/3NogUWxtvPg6dm+gMZXrt//c0ctGK8URFA4mP53bccldXLGz9pEiYuo1apNhsSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4wh6fxHVlmT13wnaT7xH9pRzVVvHD5c7f3mMCVmBHvw=; b=Xeo/iWE4bYgi8fXv/Jl+p/YRgZTE6Xeja5f5hS/FLA2ECw3c5zCPevL5QZMsi2pXZhF7FrF4LBE9r1jJgYRbrBg4LuCg9tu2RnZdqKhQ5UbL7Jm6/mFgcSZfq6vYHcjm6jw7VHX6M3t8wT1Macqk27oQwE2/TJx3gsxkUnvOArY3UqqbxmgP4/35tWed808bDc16o50HKNuNOh90zeSvilxukKkXIV+MJpvjmpLFwbJuiwmsrfYIeUkn0Qd2rs6zWD4Ak7qtZ851hxiatYuUdMtfIM1TscyBUsKRSJYNvAJlKr+x2VNNQyICnO6nWMZKS9m3gKbXMIDIuE/djAgUUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 23 May 2022 12:52:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 13/21] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <6666ab70-b68a-eac5-a632-893f950a984a@suse.com> <600c894e-a35b-e27c-898e-8f1cf3ea0ee4@suse.com> <7163fdba-c128-1226-e1cc-d210c5db06ad@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR02CA0028.eurprd02.prod.outlook.com (2603:10a6:20b:6e::41) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 902dae93-91e5-4405-978f-08da3caa5eee X-MS-TrafficTypeDiagnostic: DB8PR04MB6364:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wOmqMUqWGXpg3ULLoh/THJSs9SvxotZft/wEz9d6cj1EiJ07U80Ugye9xdJv9SS1soIMZxY6Id4iHQFrmktlVH+FNTwluSJOuydKPeVNSkxR0jVJJJZLbEZBQSHP8P5Vk5ZFsDCC5efs+OW10mqph3HB4OsnMNPmaL82eksHqz3Sl4KWOtVscbDhV99+9ll65VHtGngxMbWZrhY8MY4GCsGHqTjdCNU91RKJ9fJ6BwwHBem/sIGUf7u5y+W+D1mwBTN5p4pnWJwVPj+2Lp1wPnSXp9d8Ksv7N7T+5z25b4zdo+Mg3ltHMW/eCSrqYJqd2R39Imr6L4XBE4JGIlSHhsReLLIsj8JFArvUtM4DtEmNnOEZSO5xf/JruhXajYk0m4XONS5IMBDG9A9jl5xaHBZKRw72UL+JevaFi8phq5m712+TY6ix2McXvZieIpbfLP47h7XBhZLd4ZomiUj1AkZqgWPsvEj40QDYP/XvfpIal/oiA1UpH3Xg7zdWsXikw/B7qKeoYJ2SSe3E6hguUkT+KyltL8sjNoA41UZ8KRbdr7WS21oT/tIAs2Q0t7XpyZequsIa1DiSRXpxUGjoiIpdO+aPTSQ502mYgfms7mXQOxyVZWTWGZ5UvaVDB36uL2t3yIFEUgMKMSO6tj8VyK23WaanDUn+PcFUOSYnLih3EwZZpxrXJBtwe6ArBi+TYQ81pONGIeGxOwLTqe52g/6fq1So4o8iuc/gRAsfkx4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(2906002)(5660300002)(31696002)(316002)(38100700002)(26005)(508600001)(86362001)(6506007)(6512007)(4326008)(8676002)(8936002)(53546011)(54906003)(6916009)(66556008)(66946007)(31686004)(36756003)(2616005)(66476007)(6486002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q7TYUbLYCoNbVkE+MZfTiuLeYngI2vkp80CWn0ZMMfDkC0vDWf6XjAfNprbm?= =?us-ascii?Q?257uUke720O18CZpJhawA1EscPkBbUbSVxRn5n5D7TcSF1wEvESpUippXhUH?= =?us-ascii?Q?o2ZPyNHtvz/b5GXAW9JT3ZTBhAdkwiNGMD+Whg4hVGDQJBshsgsGQQc3bRUt?= =?us-ascii?Q?BAGUPrUwZxvxEjHQh6yNJ/rW426esA3nOX15msWbA2DjE9lUAnpTvshdUZX1?= =?us-ascii?Q?tI3CpXfr80mc2oNuyy1Gb2HeEtVoVQRbE3AE+Cvgi2aguwI/4j3uaDlEaBlp?= =?us-ascii?Q?fS6JivAa1l03kv2YbG2l3px2jZmE1akU4kBQhKJv43UHcdhekfyJaYW/pOZb?= =?us-ascii?Q?TYVdcddrACyeGKHZcBexYultiT3+BKJq5nUc67HS3b15NvnpFo1QXjF9EAbW?= =?us-ascii?Q?/YJY960frYnDhRb2/8SgSe7kgaHzU7d7XddWT8JZDphZRad4/obfUwsdYjmv?= =?us-ascii?Q?Q2pywB5TzmbR3V4iGbtn0MjM3ML0SJWTbMI5uGaRP7EkTU5rkp8lfvhVskxv?= =?us-ascii?Q?rjZEJtFQsYWd80D0q6le2YBPjN1i7avpF0h55ymoCG3ocTdN+x7RJWwXoE1K?= =?us-ascii?Q?o1qLodGx0nm1LIE0qDeIikO4ES736tY4dqCbDlYj43/v1HwFVZKUoLiDfQjS?= =?us-ascii?Q?w9aeQUPp3uSJ14KPxhoYLD1QXg3I4ieexIctFp6zgQDV0k1xXto15ptjtups?= =?us-ascii?Q?gQbR2wyHos94KKDmKwzaKAAtYdL2jQlOipTtcjZ/1xXDth399hGrBN2iwLHL?= =?us-ascii?Q?UXbsTYsDns9WJYYWgs+g+nWjlXo+LmyZ9xsMxq37uni+AYHOIDBcpFDtgeOO?= =?us-ascii?Q?tCuD9mCvyj0yXdQ6zYznWJPkAsxliddsEegqmWA0Nej4IVC0CjbrMwVrd0Im?= =?us-ascii?Q?GV1ExPaCcpdgcd344BzymKmO0xxIDCEzHG+XgiFRKaku44no7IPW0Dfw6lkZ?= =?us-ascii?Q?+dEWUA1VKbnG/a1T35eeUADlsUzUenL57YRYh7yjh991NXJdxVr87F9fU3Ej?= =?us-ascii?Q?+RSv58iYNa/Y+XJscEYhj58tCF2Ct0RvNTuMqFdT5A+VduozXsg9qumBuu7Z?= =?us-ascii?Q?NzyIzoaEC4Oty0BNetXT2mQmgZnrydQBz9mRyXOWP8ld8ovR50EElbgdhL5H?= =?us-ascii?Q?Fp3xm6n/6m9kSyouRhtrSGybWYvRYNWy52pj80+MJ4tWkiO1ruUzQRQA7/OU?= =?us-ascii?Q?ctzCHRqKu9I1epxmEf1ki6M9x0saayOfbp7VvVZ07kHnlW8I0rypU3R5b5Go?= =?us-ascii?Q?vBr1n61fgsJdl0uIly5oFiSgIHMnsMwZM2/sHKMtuLZ0285mEY4MV1x10Mu8?= =?us-ascii?Q?B7Ac6SvohyMWzsPWWGP0z+En/DmpDdjoQzniOUDdachHF5k57nLK5DXFTKFA?= =?us-ascii?Q?j8Lquuk0Pco7hw1X2mei6GdCT0OoJoWiHHKgXDUCl4/GmvAs9P7qwfsBQkTt?= =?us-ascii?Q?z0VwLqAKapdzeEjsNirt8BnG/B5yLZd4cmDcy+3aUoEo+jx9JEb8GPi/28aO?= =?us-ascii?Q?+o0ZfDRUJB3qwA7lx1ZFtOQ9iVT4IzrKp2pmCB1ufJcozKugMigAv5Z93NLB?= =?us-ascii?Q?yygl7iMNY9Jp19pbLPiPrviEwdk1xraANoRTienQXFNBSNeVcaKtEc7lt9Rs?= =?us-ascii?Q?cqwwtAaIjPTWGry9wcUKMdr4g5RbFaSRZu/gwiDbtBYDBMgL4uPggXiHfSMu?= =?us-ascii?Q?gLxLPUvPYwEjWSjOqM4Twq6DHkeWbmkF1xCOgaADz0IXwr6qQPOVbi9FpmcT?= =?us-ascii?Q?i2ek5Zrz4A=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 902dae93-91e5-4405-978f-08da3caa5eee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 10:52:46.3491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qXoFuTo2QagsxHmsWZ0nBvlHDfFxP5AM3iLDJx+trwDjLf/tlGGb+yPO0OZxXPbTX/l3peouMZQIMWAxyc2zvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6364 On 23.05.2022 11:10, Roger Pau Monn=C3=A9 wrote: > On Mon, May 23, 2022 at 08:49:27AM +0200, Jan Beulich wrote: >> On 20.05.2022 16:38, Roger Pau Monn=C3=A9 wrote: >>> On Fri, May 20, 2022 at 04:28:14PM +0200, Roger Pau Monn=C3=A9 wrote: >>>> On Fri, May 20, 2022 at 02:36:02PM +0200, Jan Beulich wrote: >>>>> On 20.05.2022 14:22, Roger Pau Monn=C3=A9 wrote: >>>>>> On Fri, May 20, 2022 at 01:13:28PM +0200, Jan Beulich wrote: >>>>>>> On 20.05.2022 13:11, Jan Beulich wrote: >>>>>>>> On 20.05.2022 12:47, Roger Pau Monn=C3=A9 wrote: >>>>>>>>> On Thu, May 19, 2022 at 02:12:04PM +0200, Jan Beulich wrote: >>>>>>>>>> On 06.05.2022 13:16, Roger Pau Monn=C3=A9 wrote: >>>>>>>>>>> On Mon, Apr 25, 2022 at 10:40:55AM +0200, Jan Beulich wrote: >>>>>>>>>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c >>>>>>>>>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c >>>>>>>>>>>> @@ -115,7 +115,19 @@ static void set_iommu_ptes_present(unsig >>>>>>>>>>>> =20 >>>>>>>>>>>> while ( nr_ptes-- ) >>>>>>>>>>>> { >>>>>>>>>>>> - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); >>>>>>>>>>>> + ASSERT(!pde->next_level); >>>>>>>>>>>> + ASSERT(!pde->u); >>>>>>>>>>>> + >>>>>>>>>>>> + if ( pde > table ) >>>>>>>>>>>> + ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - = table)); >>>>>>>>>>>> + else >>>>>>>>>>>> + ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3); >>>>>>>>>>> >>>>>>>>>>> I think PAGETABLE_ORDER would be clearer here. >>>>>>>>>> >>>>>>>>>> I disagree - PAGETABLE_ORDER is a CPU-side concept. It's not use= d anywhere >>>>>>>>>> in IOMMU code afaics. >>>>>>>>> >>>>>>>>> Isn't PAGE_SHIFT also a CPU-side concept in the same way? I'm no= t >>>>>>>>> sure what's the rule for declaring that PAGE_SHIFT is fine to use= in >>>>>>>>> IOMMU code but not PAGETABLE_ORDER. >>>>>>>> >>>>>>>> Hmm, yes and no. But for consistency with other IOMMU code I may w= ant >>>>>>>> to switch to PAGE_SHIFT_4K. >>>>>>> >>>>>>> Except that, with the plan to re-use pt_update_contig_markers() for= CPU- >>>>>>> side re-coalescing, there I'd prefer to stick to PAGE_SHIFT. >>>>>> >>>>>> Then can PAGETABLE_ORDER be used instead of PAGE_SHIFT - 3? >>>>> >>>>> pt_update_contig_markers() isn't IOMMU code; since I've said I'd swit= ch >>>>> to PAGE_SHIFT_4K in IOMMU code I'm having a hard time seeing how I co= uld >>>>> at the same time start using PAGETABLE_ORDER there. >>>> >>>> I've got confused by the double reply and read it as if you where >>>> going to stick to using PAGE_SHIFT everywhere as proposed originally. >>>> >>>>> What I maybe could do is use PTE_PER_TABLE_SHIFT in AMD code and >>>>> LEVEL_STRIDE in VT-d one. Yet I'm not sure that would be fully correc= t/ >>>>> consistent, ... >>>>> >>>>>> IMO it makes the code quite easier to understand. >>>>> >>>>> ... or in fact helping readability. >>>> >>>> Looking at pt_update_contig_markers() we hardcode CONTIG_LEVEL_SHIFT >>>> to 9 there, which means all users must have a page table order of 9. >>>> >>>> It seems to me we are just making things more complicated than >>>> necessary by trying to avoid dependencies between CPU and IOMMU >>>> page-table sizes and definitions, when the underlying mechanism to set >>>> ->ign0 has those assumptions baked in. >>>> >>>> Would it help if you introduced a PAGE_TABLE_ORDER in page-defs.h? >>> >>> Sorry, should be PAGE_TABLE_ORDER_4K. >> >> Oh, good that I looked here before replying to the earlier mail: I'm >> afraid I view PAGE_TABLE_ORDER_4K as not very useful. From an >> abstract POV, what is the base unit meant to be that the order is >> is based upon? PAGE_SHIFT? Or PAGE_SHIFT_4K? I think such an >> ambiguity is going to remain even if we very clearly spelled out what >> we mean things to be, as one would always need to go back to that >> comment to check which of the two possible ways it is. >> >> Furthermore I'm not convinced PAGETABLE_ORDER is really meant to be >> associated with a particular page size anyway: PAGE_TABLE_ORDER_2M >> imo makes no sense at all. And page-defs.h is not supposed to >> express any platform properties anyway, it's merely an accumulation >> of (believed) useful constants. >> >> Hence the only thing which I might see as a (remote) option is >> IOMMU_PAGE_TABLE_ORDER (for platforms where all IOMMU variants have >> all page table levels using identical sizes, which isn't a given, but >> which would hold for x86 and hence for the purpose here). >=20 > Since you already define a page table order in pt-contig-markers.h > (CONTIG_NR) it might be possible to export and use that? In fact the > check done here would be even more accurate if it was done using the > same constant that's used in pt_update_contig_markers(), because the > purpose here is to check that the vendor specific code to init the > page tables has used the correct value. Hmm, yes, let me do that. It'll be a little odd in the header itself (as I'll need to exclude the bulk of it when CONTIG_MASK is not defined), but apart from that it should indeed end up being better. Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 11:00:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 11:00:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335819.560017 (Exim 4.92) (envelope-from ) id 1nt5nK-0002uC-BY; Mon, 23 May 2022 11:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335819.560017; Mon, 23 May 2022 11:00:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5nK-0002u5-8W; Mon, 23 May 2022 11:00:14 +0000 Received: by outflank-mailman (input) for mailman id 335819; Mon, 23 May 2022 11:00:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5nI-0002tz-Vp for xen-devel@lists.xenproject.org; Mon, 23 May 2022 11:00:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84007a64-da87-11ec-837e-e5687231ffcc; Mon, 23 May 2022 13:00:11 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-9-dulwta_iP6C39fGuvozhJQ-1; Mon, 23 May 2022 13:00:08 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB3324.eurprd04.prod.outlook.com (2603:10a6:7:83::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 11:00:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 11:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84007a64-da87-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653303611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmRdzYkfMb/oYp4c9nDzwccXLX9ZljQ66qGb4s21slg=; b=bm7Qt3Dtssn1kWVaJOfr27f5KUyGTcQo77zBV6dA4dDwpf5ADu92n2toVX8xxLCifq+gXC lGh5KViPQtevF2k8DiTlbuO8SPFeyAKFxrsQ/DmVLoyoGUZbBWcfs4NDtl3JGzoIOwpOiX FwbrQoAi4hu++hcP3kkhXVCkJyifVHU= X-MC-Unique: dulwta_iP6C39fGuvozhJQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lgDR1PhN+JvD/MfNdMhuHT9HmfWV6Pk3y4nMc2ZBGgRK1vPRA/PUftHjYYbOkOyuLCuc3P80njMPjOpYHOdOrlm95b70yqZ9bhK3YoBTKijZri5zPeyLmLUgG3SsMsBJXHJpux6QHiZuOYXbaMEjgGwAp7iaNf4qVgGbpOQsY80YkWwKj+aykpBKSHjQzTg9QfZCh93VX6iUvvFlSd27bZt9XAARjwz3zGrcM/8uGdxnPb0zdNWYpd9cqWii/5mgnvNE/RGtgva6OD7gfCqJsTVY9UFLBiB5kWfrWueetmSd/49UUfxAzK4DHws1CNDFtLKSCaXbPBoJ2V4YUUdkfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQKzw+5fuPAhnUSaQnwi4psZFPcsGoT6Os08Bnau7og=; b=a7a3LQE9WHRDv3/B+atonFuDmjqFA92EUTonFZzNnCTcCwiF6Nl6jTb0dGX9XTM3wh6Pws144Wt3myH4J7/w4AGUJIvUttVxPJmxtevPHr+xCfkEEiCBvkiLHML4vryDnrfYJzNbAcqq/IkNpJL4HrfEIMK4SHZRp4hI/IRbN6tX7LjYuqzAcQfoGmGTNdbPvaiy/zjPy/juXcBSTti7StqYaKhcYhg4YEwR4N3kQ73+CWWuXDw3WjJ5t5gBsAzYSIxCHhGpjRMiLtE2OxrAihf2Ittvhu8YuTNYGDI+Iq0MRtoMY+R0GlqokBw7HW1yqAzvBAjmLFueuwVyPLibtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4ed6ac07-b6c1-e7cf-b8f8-154da425357e@suse.com> Date: Mon, 23 May 2022 13:00:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 1/6] xen: implement byteswap Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Lin Liu CC: xen-devel@lists.xenproject.org, Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu References: <89b15afe026a84748ac0d9ca28e8608085454e78.1653295437.git.lin.liu@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91c72fb5-817f-4446-e8ff-08da3cab640e X-MS-TrafficTypeDiagnostic: HE1PR0402MB3324:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRhanK5/PSK3hzEIdG7bWOP0SwCTH6SEIUAqKBiN7AqrKE7ypVgjXhQmvzzg+CV/MiFdKxBuKaDhIj5jHts5VXt5NKeHZNqSywntk61TKdYQO0mWgbN6eEHS9zoV6sqtgKg9ieKERUGasXMZeBYwcK+l6m2mOrq0cNA6cetzs9dDrpTsy29rW9kqW3u58la1+z/AtQXE7iU+p6IazYf0eoUJx74/AoFO2uybz8yvDxCXA77Km/V8mXEFI469vYCh9TmYBlpUfJdMoqDGZXzzEwtx7xP068tLcJXjuZf/Y8iYQE5i7mK8UzNTHsUey64Dkhr4OBZgFpn6llstKvWOqYdcEgWx0UMV3CfKpSO47DAVdyYaskXRrE3lgjfB5smgIpoGAALS58AOfBofHB3z2xVV0m+Yw2lEFr2CAbJB8oYmC4V0wpGOy4q/gixXy2iEoljho3q075NwJMu3Gmg4VEkUvxQzbSIQFBN4ugOXXnbOq938tW76ML+KnrWLdtrFKwIdCv+TaC0JJ5Rvf4bhOCCG2E6PYJQHVJL8Ftl5n7bW31dCXbpQ3FEXCA3GCb3ZrqdSzk/rF+lSkjrjq1UhalB44iG34ctJj36HFXCDADvG/gupGMizfP3fXzsQQjhIZhEG4lpb4aMbekYhqAlBFM+xKOeAEba7wTVEMmPFptiWLKGrTN1xDN2w37MbjgOvx7IyoD3n84m218q/IlZGXjtL8CLsgEMSzbGThNi8GxScDg2GMg39MUfWgIIJB4Ok X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(38100700002)(66946007)(6486002)(6506007)(53546011)(31696002)(6512007)(316002)(5660300002)(186003)(36756003)(8936002)(508600001)(8676002)(7416002)(2616005)(66476007)(66556008)(26005)(83380400001)(4326008)(86362001)(110136005)(31686004)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MtNUMUMrjGPgIPefOUQkQmEkX0G0CzEWkPI/wD3KSzD3aYeCvSK0xK9tXMIY?= =?us-ascii?Q?GFPnhBcU6Zn+oUp4+J/ooVrbwYVp+IWSgqxq4cwtP3jggYoYZTc94LI4HNXN?= =?us-ascii?Q?/SNY+MqjM+0zaf0WAaxVGNmnVNobk92c2LXLkEvLNnWsoW69S9djm63S/Ngn?= =?us-ascii?Q?vKVIqo0mmgSb3D6F4AtPEFbX/T/W2hOYODEJWwn40VoM1KQUe9/IpzYGJnwk?= =?us-ascii?Q?P4R//3HkeXxGXSCU3LZcSPliHKQil6Y6mD2t37OSKQVVXlQos8yU0ci8upi/?= =?us-ascii?Q?rnsHJY87DWXBG2A5bGvINUJihlItr/VbY/3Ak10CFZgRjxYYXvD5l/rgsQO3?= =?us-ascii?Q?W9yc4pe5v58SKN/UspsbN/od+33lRRk98mF18QTI7YsdelUf2lDwP4zBUjq0?= =?us-ascii?Q?A+u4Nb+U12TOV8Ib6TxNwr3fmd0nuSY8z4mHgQ9SPPsme+BPOvKYOqKgA3/L?= =?us-ascii?Q?wZ++4hmG3bCVX300Fpnszb+XhJaKABtDw1IrUj7w5qrpdzO0ql94Sbnk5Bbu?= =?us-ascii?Q?kB8g8xyHuEUMTf6xnmJxOCuToR63UO4NP5qDiF093JKi5qfLQIVwNqmLrCLB?= =?us-ascii?Q?RW9c1n5ZjGGCZavUbrKKG6r11Se0TKya9DPPJiOk5lyz1svNlmeVw5EBzGTz?= =?us-ascii?Q?RyT6TEZEgNfGCh/Z2sH+XvrPuvu3Zd0kVELIx5hwv5b+esBoQihO02w8UeK1?= =?us-ascii?Q?a2Wm6PmDB6NztnfqwZJJ77CrguH+bwCBTWj9VEvjRe+6CzP8motwWWdMXj+b?= =?us-ascii?Q?LeFERGnlvr/NinCbPu2s6NoWi9LmBAefMNnhqSjRsxUITzKOWet+W8XhGUIV?= =?us-ascii?Q?E6zt+n8WN3LoDJvviX9D+NxyDIFSsDk3UP8WC0keADeeHIgP6qaBTuH3DQgF?= =?us-ascii?Q?Qgvf8ptyZ3puClAd3k7i6bS/dW3PZE9dmhgWouGHdgUhRqkyK8S3m2KxqP7V?= =?us-ascii?Q?4r60xCVQUH/nt/+kv+MGO3KOc4xivckTL+5srTGO2oowbWWJrMk/Zu8/Oepc?= =?us-ascii?Q?qh8673qYorBwrMPOlVFcblxRZfsQvabB1PAQ4a3JdGA+A5w1Za8BMZeHdaaX?= =?us-ascii?Q?On0LqxMBAA4pOdxCh+XGgibv0IScyOyV9+0kgfo3qRrc7aRhXi47Mrp0rM4m?= =?us-ascii?Q?YyJc020HgFGdC6sVLIupBVvghMfRMdECasmR4fn7k+v1WOtyd9Pk0NYWiIHR?= =?us-ascii?Q?E6zcjJBFyQkTpOcK/jKope79SoOwivclB7CeTUBwq9YDWdn5e0KJOhMCoM+P?= =?us-ascii?Q?ljZdGb9O+HYlH2dhIjxQaIT/m/hbTKJRQaUN5Yo/5z+SnnItPxH3GtVPO7VB?= =?us-ascii?Q?Z7GD8xfE28V/CO/OnqiXm+rGhtABEkmhq3KzfrOK9PUEMGou2ZNCsk7+/6n6?= =?us-ascii?Q?1ecOPddw+H0mWRtcKsPvoVLYy8/vwwiWeu8M6PQHs+Tmmu7kA3n32SX4fvgb?= =?us-ascii?Q?oIzagJVZEIV1nNCYIB00pwVQA0MkLpDe3hWzaKoVkgerafdWaaenI/jketek?= =?us-ascii?Q?R0+1H3kL32UR9fZcuXyxhZDj0XrOC7Axgm5wuERfKFIpXVNKKyi2y69FJYlW?= =?us-ascii?Q?+HIB8EqOD4d7Yv+3HYhYPjPf/x2XE5qGFNgKAuSlS2RyNA0G8n8N34TIw5mS?= =?us-ascii?Q?SBPToQbX2L0dwpLhJC3T5pSbPMyZ36YWvCDeZNcqu/9KKFw6lq2hft4UJIva?= =?us-ascii?Q?LuiJVk2Zo4zi+g7D9K4oAkp0YYtCC2Og5avYsyHVtbvRDkirv2ZAoTaq2Tc1?= =?us-ascii?Q?k7v0BdUMOw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91c72fb5-817f-4446-e8ff-08da3cab640e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 11:00:04.3056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZLELXUrxYEYeIxNWzyTnN7tRlR82pyK0qKxa5WO/pwuDqzQKm0yC/KqwwAzt+6QnUh5hUcg5ICBUsjjgai1vYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3324 On 23.05.2022 12:07, Roger Pau Monn=C3=A9 wrote: > On Mon, May 23, 2022 at 05:52:17AM -0400, Lin Liu wrote: >> diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h >> index 933aec09a9..ae029afa14 100644 >> --- a/xen/include/xen/compiler.h >> +++ b/xen/include/xen/compiler.h >> @@ -185,4 +185,28 @@ >> # define CLANG_DISABLE_WARN_GCC_COMPAT_END >> #endif >> =20 >> +#ifndef __has_builtin >> +/* >> + * Backwards compatibility for GCC < 10. >> + * All supported versions of Clang support __has_builtin >> + * */ >> +#define __has_builtin(x) GCC_has ## x >> + >> +#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >=3D 40800) >> +#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >=3D 40400) >> +#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >=3D 40400) >> +#endif >> + >> +#ifndef __ORDER_LITTLE_ENDIAN__ >> +# define __ORDER_LITTLE_ENDIAN__ 1234 >> +#endif >> + >> +#ifndef __ORDER_BIG_ENDIAN__ >> +# define __ORDER_BIG_ENDIAN__ 4321 >> +#endif >> + >> +/* Indirect macros required for expanded argument pasting. */ >> +#define PASTE_(a, b) a ## b >> +#define PASTE(a, b) PASTE_(a, b) >=20 > I think it would be better if byteswap.h included lib.h, rather than > moving the PASTE define into compiler.h. +1 > Likewise the __ORDER_{BIG,LITTLE}_ENDIAN__ defines would be better > placed in byteswap.h itself if possible IMO, since it's not strictly > related to the compiler. These need to live in per-arch headers, i.e. asm/byteorder.h. Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 11:05:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 11:05:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335828.560027 (Exim 4.92) (envelope-from ) id 1nt5s7-0003dX-3Q; Mon, 23 May 2022 11:05:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335828.560027; Mon, 23 May 2022 11:05:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5s7-0003dQ-0U; Mon, 23 May 2022 11:05:11 +0000 Received: by outflank-mailman (input) for mailman id 335828; Mon, 23 May 2022 11:05:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5s6-0003dK-A5 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 11:05:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 358fe29f-da88-11ec-837e-e5687231ffcc; Mon, 23 May 2022 13:05:09 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-Ok8ZnDo1P3eO9nJqtggemQ-1; Mon, 23 May 2022 13:05:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8765.eurprd04.prod.outlook.com (2603:10a6:102:20c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 11:05:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 11:05:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 358fe29f-da88-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653303908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKRSySOYehnReLELVDpxuSoWopnYBrwiSBIK4eDBNuU=; b=mz0X38cF9gcEUt7eJXzO3kJ49Vkuc4064qLy5TfZWlmNgW8WAYx1MiFmfbCeP851s1EY2k xogvgjSWFLMGEJz8FJKiOggBgGYVU1x5Zuvm+y3j2fygGwLYIyn40UOw8Uv2WrWk/Mghee /9QwVCFfuhpuh+mFLGQ6bieRAiD10b4= X-MC-Unique: Ok8ZnDo1P3eO9nJqtggemQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gtNcHfw3xh5RcZBH0ehBCv0k5VXQXPUo/TNcR7HoFT0FsLsLeM94qJ0oDas8LvqYWcZnHg4efcUfmCXWNth692MSl5r1bxDFSNWgalYR3GbTNgbtV923CvDbtIg8q86/hY3lNo2z1uVfTjpnE1Y+jkZUsfrhGYEzTCFHf5xSOQ4Xvx7qazshIs1upjlfH+c3r0dvuDvipC9xZNRoQtsKdKEUceEUfLcG/9s25Dr9EcTOxqlGhRguTP3AAiJ5qnAuDFe3fBzBWtXUB5cpZU5/glWGcfq/rT25b3clWZp8Uq1jrPn/C4MGYorAw0mo0A4sBvdDd2wVD3zc/MTT9U1jFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mzIVZMyoi35U2KDDaBp06NfhSwNDMnKJNXfExSzbGXE=; b=MjdGvhZ8LrlaVddQvWTmn5zMpZCwiFd5efcc+RyqIMhPRKV9sk7sNkNyAtOUg55xSkPKTUCFbJUDCq1+v8nKcvDPkMwgcf6V74yoAHGNW9qPDzXVyfx0gJsP93xdDpysNPcCYoEXK+5X2DdXQdIPq5iR6VOqSiozP8zhYVo3a3D+St+6Zpo4yKJn1bWiCAXqP3YxleFrRuhwiFV8xP8P+rDdtmsSDovAI2tQgBceA4fti5tPU1Hrk8yVyq9qXj0vgixzmsVlEz3dO9hcSXi0tgESMIjZsd6aFwhilsSBKpwG36ILHzZwdVZCAbzsli5YmEHC/Bv8tv6E6SNoGG3B+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 23 May 2022 13:05:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 1/6] xen: implement byteswap Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: xen-devel@lists.xenproject.org, Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Lin Liu References: <89b15afe026a84748ac0d9ca28e8608085454e78.1653295437.git.lin.liu@citrix.com> <4ed6ac07-b6c1-e7cf-b8f8-154da425357e@suse.com> In-Reply-To: <4ed6ac07-b6c1-e7cf-b8f8-154da425357e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0136.eurprd04.prod.outlook.com (2603:10a6:20b:127::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea3ba44-b897-464c-fddc-08da3cac17e4 X-MS-TrafficTypeDiagnostic: PAXPR04MB8765:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: odp4ImXSzjifHEiHDrrE1wvBWVocjYhPm2NyyvUt4NuzTxI4NPKwYidHWTYQwnjcQ+XLrW8E+4D/KGcAoitM1V63Lgj6rCYKw5mq8Ws26UR3bVp1AZqIxdhCHuj+dHKZUWWiwDiJYI1a382zxBAJyUxVEc/ENJbOzl+K9IX/2CCQIhL+0A7dN7AiMlq5sPWt/frA2/viEDfNh1TFkScUEY0iKzYbJmBQGxcIyYoPaEDczFuqutxCCn8NU1uu5Pog1YbgJ52rVeg0i3wu4Lt7bxZ1OV4iD0pfwm71oYYO99pjivFX82xu6qVB0t9L1yiXx7hB1x8IkE3bheZ9zZCCe1X2V2+UVZqsmfavzxELKWO9OZVkOQDR08Eo3PzGBA9vxMsTg4IXDssGGvOf0OzNI9d+BrMCIdMM8/jwDFJPzwDU1cbfJGen6d1MUlVxWFw/xoYDvbnGWNZ/U1UyLx3FP49Jj64POhmOs5V2zQfCj630rlLa7ovidhv+wPZkedHh21u8sTQOFMZXku6lOoYgxu7JlsFlnQlb2J4JwluOvaoWohrYyKBHWlNGAl827ZmuZymySy60G/1k5Q5lQWetNmNrBltkjFOsKYBFXs9v+wtIa4AZhy0pZInzjgdjQeCLsostWrR4kaTLaUbuVTvdFRxBgVmkr4uLQ6+fSxzPsaVjqLB7tGLz/hYQNF76sl7rQUARRF/orEOg3Qe/m/ZrlcWvoqSs9fbfyn/2ULXe3V6Ax8xMuL8WgH65FBRePuR0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(26005)(6512007)(316002)(6506007)(54906003)(53546011)(83380400001)(6916009)(186003)(31686004)(36756003)(66946007)(66556008)(66476007)(8676002)(6486002)(8936002)(508600001)(4326008)(7416002)(5660300002)(4744005)(38100700002)(31696002)(86362001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iFkY88L/Y8C+oC9FAlNxZbMJ39R/LAHdFKy0IgXfs8I5LMRZVbr7nQ9W77n+?= =?us-ascii?Q?QRgOY9V5RTsF89/Y7JVTqYvq9WzkQlK/jyN6L/gnPfZf9N+i9orD3c4hgB3/?= =?us-ascii?Q?dlxfeN488uvtMDR2lRz0048KXmfcWdkYMA/KYygAiJs8uBmg/x9SmcGrJY50?= =?us-ascii?Q?SKX0I7Ao4UeAcvuLxrQyTZf6bq685o5jm7BJ++uGe7H+niBpiZ8rVKkCly/1?= =?us-ascii?Q?O3GxglN5z6P74ykn2NfGxBW2ctwi+lqVfGRFvyDH0+ejoczYkrMqZylti9HJ?= =?us-ascii?Q?89Ddh9ugKu58UAtd65jWjR6jF7k4iRiiPJayQhG6LSGGIkrwWP4oAOcylACh?= =?us-ascii?Q?RvHkRuOxlP4DaRlNiAZ7OXy8IJOSMeiP15nhUbjOh9E/+PlwQwedysqlkOtN?= =?us-ascii?Q?HDIvgtSSqn59X8yHtGRjWZSYM6bBz7BU09eFMXeo/6p9uEMjrzhgCEKyJOOF?= =?us-ascii?Q?lM3Op5PDDRUGcrWWTbC+rs0K9smnsenntoSHtfXleI/MR5J9nfR6UdTBgN7o?= =?us-ascii?Q?Y7oxc3pkW6HCzfsGDpbR2TbsLGA9e1jHN44m6MAeVplaqsYxm1XPK+brJjcM?= =?us-ascii?Q?ap8AUaWUOatlL06x10CiW+zlB30tSTW9ixsHogvDU+BECwbapWbr2THAVscb?= =?us-ascii?Q?2MXifL6pyX9CFPB0rQZcWh9snuDFb3B1dDq4jfo/tQjpXubgfukuSN6oGKCt?= =?us-ascii?Q?ebkHCKAzua4mxEyPQZedlqkCzIlpqcabXMnk/1ocib3MUs9Jo6zIRdwf0QE7?= =?us-ascii?Q?VgJdtfjMIW01PG5A3Dta82RO2t8xHKeqVrOx3sUybD+gBBSsti0iou3S+Xna?= =?us-ascii?Q?HKXe0ydRnby591Z12OVDIlex9+1e2bZ3IvjJryhj6r+aicDFzPa9MBN64Xvx?= =?us-ascii?Q?31LbxNMGhEKvBcd8Gqk3D4OVApMXupFrMqI7sa0PQJoaSDNxCjL7477aphTm?= =?us-ascii?Q?NprsKXkBEW5pRfRw9f3Wliu4iB+WLQhh428HAX6+iN6NPvzi/sG754BxPcBe?= =?us-ascii?Q?OUpcskymTS1EGvY9KDMhTPrVoIjSgQsTeh0YyvMcLVD1qu/0brf/qbknbVHM?= =?us-ascii?Q?QsUFJQ14TEhqzPXBibrAh94zQJyIPoJP+uC/oRm6eQuzsEIYgdvuQ5IF1Fe+?= =?us-ascii?Q?v8D8u8J9WanPSeDqnZBZmC5Uz/Qs/38fX7IYrbnyunl8OCdyVrHA5p1G1wYH?= =?us-ascii?Q?krMP3EglDTPAd1CMEKHqQJvjbUFNYFD/Cnl80v78X0r4M+MTYA2T5LEx76nT?= =?us-ascii?Q?Kr9fMqJ4xj1L2JXZzcLK40RkToCX6pdwb8nzgEsTbdCXmsqLalM5RqkoWne1?= =?us-ascii?Q?lrtFsiRyXLaL4e/d75xzfN1vdbKnfDTjpau3H2VHOWWKhMr4acED+YsXi6VH?= =?us-ascii?Q?/18LlScE+GM8ELMw749RHQ9/9DXMz68/qCnQzpQl3qqXYMlyDHGx7t8RyLmg?= =?us-ascii?Q?mlqaq89bqiYPiqULjAfQvfBtGZg8qoLhxqa7eS1/uIQcuDZRNEC/wrv2Yotf?= =?us-ascii?Q?hpd7YzUxTAT/muZX0tXEyo6W/AnYbdGyR7GsB5MYkHTqMxBaEFi2LKNwf+xo?= =?us-ascii?Q?VpNfmuETcI9EdhdsbEHOGf9rGtn7bx8I598jwq/DLtlSGGveiv4ymXr2WGv7?= =?us-ascii?Q?8SoQzcQHSH+IyaIGE0sCMie1guOO8elYlK/9vhwb1a9VIN9UAUNQOOOJsVA2?= =?us-ascii?Q?OOHFMUqTuLOP+tEYorgnJ+ChoIEKIU2Y4KCQ5nSR4VJVZxRkfjkIvcy6EktY?= =?us-ascii?Q?PFwhsosQ3Q=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea3ba44-b897-464c-fddc-08da3cac17e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 11:05:06.0364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UnWtzINtMdg6Jf96kZiIDUqG7MNQofJ2gvW9bQyFQgf8W8BnoeYU0r9jwQ3xlPiOFxFkP8V1qWyCRsZ3SphH1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8765 On 23.05.2022 13:00, Jan Beulich wrote: > On 23.05.2022 12:07, Roger Pau Monn=C3=A9 wrote: >> Likewise the __ORDER_{BIG,LITTLE}_ENDIAN__ defines would be better >> placed in byteswap.h itself if possible IMO, since it's not strictly >> related to the compiler. >=20 > These need to live in per-arch headers, i.e. asm/byteorder.h. Or rather not. __BYTE_ORDER__ looks to come from the compiler, so #define-ing respective constants in compiler.h would seem quite reasonable to me. Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 11:09:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 11:09:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335836.560039 (Exim 4.92) (envelope-from ) id 1nt5wH-0004Hl-NP; Mon, 23 May 2022 11:09:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335836.560039; Mon, 23 May 2022 11:09:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5wH-0004He-Il; Mon, 23 May 2022 11:09:29 +0000 Received: by outflank-mailman (input) for mailman id 335836; Mon, 23 May 2022 11:09:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5wG-0004HX-NK for xen-devel@lists.xenproject.org; Mon, 23 May 2022 11:09:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf972e26-da88-11ec-837e-e5687231ffcc; Mon, 23 May 2022 13:09:27 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-RFa2wGnkN8KHH2UFQSCeYQ-1; Mon, 23 May 2022 13:09:23 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4594.eurprd04.prod.outlook.com (2603:10a6:208:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 11:09:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 11:09:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf972e26-da88-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653304167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dnZoSPwy+gnzOQAbNFy5J4GpHhb1nV8TUO/EjW/tHfk=; b=YVqg3ifSKwkf/WBGLrZe9hQEqQQIZYWJElrfo25M/KFsFERDpRWnQ7mcam2A3JI5/aVdoc /hDUih6TTCtreOTCRnvoWKTOHBYApIJiYpMRi6RHGY8+/HNhS8GvkKsgbdP60yYEDOTNBt r10eGFQStPDOPHxYnwNI2qUKzjv1geg= X-MC-Unique: RFa2wGnkN8KHH2UFQSCeYQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O44PVkPBYRQNZ4NzB/pqgCxuKh8hzlGZVUUIGLS6H0V9U2bNAv9XsMaoCmaH8YSP2QqPuq5/bQ4r3VvLiRfeNCDhB1+c04TvSA1miYOmdPcXTHRNVo9TfvcEnspnMw7tFHv58hWhB8tbz6Crm4YgDtN8aj0/mf3aTg7wcdzT9cRyClmWgsRgKdJETVPol1pORyegY4I7N1qL7cZRNklQ782i3KvvPD4YjbqdXnIgN/w922q4w7uVGCoBDtWuVpoaSMNKRknKJ7ETDjCWcxAIyBPVN0EN2A/Cc65A2RFA135rbZ64DM1mus+L1WYk/f6HGth3TSHqAh86gca3Kgl9BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnZoSPwy+gnzOQAbNFy5J4GpHhb1nV8TUO/EjW/tHfk=; b=lwgNp0axxkKYD6zpS/ratacyFJ8Z1elvYKKWvhO73qXTifXhUbr6buFYPGnRDLcEeCXGvT04vyHuRp1jyA5qE0QNCSYVMnmOKo6LRB+t5AP2Wcw5btX+8leSj9P2nyntqYPlDq7u4fkDgta9Cg7vF5gQUlWnbt9TJYVoJM8TQ/x+fc54csvunLM1vpVihEAN/CSb+BGTyIvlmZHIg8wDBgEn96gPxNhDxX2UxMd1T31133ODanP5KFU78nxGOCw4vE03jwYjOsNPq0o2WDUMirO1dG98s2I0IY3RpdGT9dkSJmudfpcCeb66aBFUZCls7LGjAIDKR6/Qd72rYxATKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8f78b5be-93f5-8d9d-6b67-5d8b70f8019e@suse.com> Date: Mon, 23 May 2022 13:09:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 4/6] xen: Switch to byteswap Content-Language: en-US To: Julien Grall , Lin Liu Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0143.eurprd04.prod.outlook.com (2603:10a6:20b:48a::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86123aa6-7f06-428e-da6e-08da3cacaf47 X-MS-TrafficTypeDiagnostic: AM0PR04MB4594:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3BtLhjfQFEPxw3i5iErFdwVPuJAv8sOJM0/goDRDX+nn/PhdUue18XWPfgK2vR7bNI7AoeIGfBVlP2m6OaIjZoWU1AOuLC8YWmvx6lX5zPgI0HoF+NFLHkEACvqoBGUfBibz+xl2kRSJ/5DtMRb/6VKz9naSGFPjqnW5A1znHu0Dhm8iZYtWwzzN09GPx61wlpdsIJdEriHE3Sz2UZ+T+8OGVlzBGPR40+nbluwWeapZXawYp3VZr4UWSc/COVdMhARXJq+Pft53cDZ5Bra/PzlZjBkK9OJXR6Yyi3oxEjVszlVaOX28wFX1WwWI6GdLW0Fa4MZMWZ7dZm+GfDDlsIK5iVCAKLJC77Aqy49pcXX1iSfIKGo13o0BDUy+BBBN36hUkCbUtAzbFxRAPItTofFKLbNFeabygzq3AJB0iGqHQxdk/+AevY5gL2J2zk4TbF1QNQU64Eee4pKpjqAb/57sQpXcJWpB8HWG9we2rRxST4OW9PLDCGwt3O9KIjwEfmB07M7BeCVuANADouk/f/os5MVydMkib5jjwTcS3tcNo7+zRWyBz0Gswz5tAA4ZGSlFNlkmDb8Zy+SsyUChPayPcWigrM+D7wmd9Rpx+KdlQTj2v02xeeFpdJ95Qn7l4tJ4AAvlHOTU4n7Z8RZUUVht/4GcwevtdQdNEd3YdUXMVrBUU5rH+3qaZ8lZiHYGRttBDUUnT0etCRrhC6uErwbURBa5X8trKQyWhVy9GrGrjPQvH0tY5z149D5Z+Rwx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(53546011)(2906002)(6486002)(83380400001)(26005)(6512007)(36756003)(186003)(508600001)(6506007)(2616005)(66476007)(66556008)(66946007)(5660300002)(4326008)(54906003)(31696002)(316002)(38100700002)(8936002)(31686004)(110136005)(8676002)(4744005)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWh1dU9mc3BtVitWbXFISFpZaWVYcXNHL0UzV0M1RUVGcUtIZW1oR3BicmtV?= =?utf-8?B?T0R6UnJSTGJjemxaY0FWTE81U3FLMlV6S0lBaDFIemJUMGN0Wkt5V24zWG9Q?= =?utf-8?B?anM2SlFFa3JkWUErdCtsTWRuczIvY0RZMmpUMFdRenVTRGlFY1dTYU1CU3FN?= =?utf-8?B?bWdteDR6ZkZUM1MxcjhGN25vL2JObS9kVkZxaTBTU212c1puRGNpclZSN2VC?= =?utf-8?B?VjJPMTRvT2xRT1JsYlhNU2pCYTgvSTZnTDVORXlPRG42Y1J5T0J6RUluQXlk?= =?utf-8?B?SkJOVTFwQ21qdzdnUkJkcVVHWGNjc05VR2NoazhNbStZNWh4RFdKbjRtSW5Y?= =?utf-8?B?Ti93ZDhGZmdpVWRodGxxb3NuQkk4clhHOXhOMDZ6cHBqa05SWllWRnNlaWRE?= =?utf-8?B?NnlqVmsyNXF1VkVmQjllK3VNWUE0enNvY0dLc1lFU1FqcUhIQ2xEOEV0TFNG?= =?utf-8?B?aUlPVll5TFNyYTBOcUtyc0xZWVNyOWlNa0FUeU10QWlMOUlXN09QSUZsZVBQ?= =?utf-8?B?cDVIWmd4SkNNazZlVUpJVGtyc1RZU2NacWlsQjVpQkZGSjZTeUhia212RWdo?= =?utf-8?B?Zkkrc1pYbDhoOU5XS3phSTFNb2p4UEdGbnJDcU9CcitqN2lLdkJRRXBzSVlN?= =?utf-8?B?NmRCbHExaDB2TzB4Z0srSVpCaTZldjFsSHMzN3hpakhqQ1RpSTc0WmVXNVpo?= =?utf-8?B?NzFIMVNlRjNXUnhWSncrc21TTEV6T3JybmJMakdsa1hPK3RyaTVwZXNWa2U2?= =?utf-8?B?Y21SZ0R5dWRVY29PelRZamtpNlpHMy9YRTVib2RSZGhzMExpTzNVMThpRUlH?= =?utf-8?B?N2FpN1BWZFoxSUNmQ0pscU1raFlMSGUvZEJRMCtFei9LckhsY0IyUjlJeklM?= =?utf-8?B?eUlEMlZRTzNyK05UTzhHWmZjeFFRMmYxb1F0ZWxWWGQ5cjJneHAwejhVZUFt?= =?utf-8?B?SHBFQnZCTEpRSnNteFFZK1FLdktIT1RwejFRNUhNQlhtQi9FK1d5ZFpnMTFx?= =?utf-8?B?Vk1RdVkwQ0dvZ1E5TkhoTW55RlFZWnJtNG9weXZTOUlIWGVsQ3hHRkdxZUFJ?= =?utf-8?B?cm5xQ2ZiMGdHa1R4SldBTzF0WW5acnRmelFOcDVZS2tRdVF6QUNFTDJmU1N0?= =?utf-8?B?R2dTSWlMMGIzaFN4cU0yQnh4cTFsdXdLL1B4WGNGWHFXamlNWnloMEJMUmo2?= =?utf-8?B?d0Z2dmExNWlwenZ6djkyZ0hrMXE0b1Ixc0dJOVh6eGFGeHVyY1RlRHRhbXow?= =?utf-8?B?UkxxOCtoQWtxQzBWS1duUzdHU2NxMnlCbytjbk5KQnJ5bDNxaDNPOXNtby8z?= =?utf-8?B?TlBuRC9TaTduTnlvNllzUXpUcmRkdGl4dFNGVVF3Z0lTZitiWTcyMmlLanRv?= =?utf-8?B?MEJHeWUzNFZCR002SXphcHRDYnhOL2k5Yjd3amRSZjlkSk93RTRVc1dTdkE4?= =?utf-8?B?ZnlMOUZLQUQ2Y0Z2RElaMlVSQ3NlazJjTzRscXNlaVJ6V282ZnFwMGFiaXlQ?= =?utf-8?B?dXYzRHM0WmtIRE5xay9TWkFmbFpLRkJZeVYxUitvOE5oUk9pYjVNRlZxcWgv?= =?utf-8?B?V2RQaXRPYmxFT2RrOUxNZGF3SkNjSHRuajZPbDJEZERlTFFwZFl0RmFrdktB?= =?utf-8?B?QURQaUZmS0JZVU5MdVNKUjVpZFMrcEp4OEZ4SjB0WkJqZUxkd1dnS0U2RHV2?= =?utf-8?B?VlVLbDZsU1NSOFMvUzNsYlVDZkNmb3FWclRhYVNpcXNiVUpRL1MwZGQxZksw?= =?utf-8?B?YlBheUp5c2E4SHdUMWh4bUVOOVN4ZmtpeDI0RTd5azF0SC9kSHZTaHFCUG1y?= =?utf-8?B?VDBnN1QrYWkySklnczdxeUo4SHRTS0pnOGRISFFaZ3R5Qyt0RkZRYkhLVGU3?= =?utf-8?B?RTJ5MkxIaWgzTktQemNlZUdlU0RrazA2S3crckZjelBUVTF4OXN5UThLTWNv?= =?utf-8?B?MjFrMXZTbXJMSWdMSHhpVEZJL3Z2T0l5Z09KcXZ1SFVKcXhybU55dkhZTjRL?= =?utf-8?B?a2UzcWxzeld2S0Q2VHVGaFhPbWd0NzhPL3JtQlVneVdLcnNhVEJrMS8zL25u?= =?utf-8?B?dmg2SjlKRVRxSlVyc21yMmVITmp5SDBNSEJMZDFWSW9tWEdwWnl3TENqc3pY?= =?utf-8?B?b29ZeThlVVpFT2lFcjRqVzZpaGE0TWFOc2lkTkVZSW9yWmNDdTNybVFtcnd4?= =?utf-8?B?NmpKVzREMTlYekpwYlpRMUFBNFpBRVVrNUJZTDhVRFlhS1lvV1hUNHZxV2Zz?= =?utf-8?B?NkRVMWw5cWVXZHk1OTBVMFJMTW1nVWZNTSs5S3VSWlM1T01yd013d0FtREp1?= =?utf-8?B?Y2RCMXFqc1NwbDI0TUdEMitISjE0NE5neUNBZHE5WWpHNGJNYStMQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86123aa6-7f06-428e-da6e-08da3cacaf47 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 11:09:20.0203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BXKTkKBvML1xhLl0xfgN2huxsnhEIdnw5TtWJq5QBq+DtnGwqM+DphZ+NBzS40SPTQfwZHoma5xqN2ZcSehI4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4594 On 23.05.2022 12:12, Julien Grall wrote: > On 23/05/2022 10:52, Lin Liu wrote: >> Update to use byteswap to swap bytes. > > I am still objecting on switching from be*_to_cpup() to be*_to_cpu(). And I agree. Especially the cast to explicitly aligned types in get_unaligned_*() is rather unhelpful (and kind of a lie) imo. Jan > I will not Nack, however the strict minimum is to explain why you want > to replace the helpers as I think the reason that was currently provided > is incorrect. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon May 23 11:11:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 11:11:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335844.560050 (Exim 4.92) (envelope-from ) id 1nt5xn-0005bc-1m; Mon, 23 May 2022 11:11:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335844.560050; Mon, 23 May 2022 11:11:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5xm-0005bV-V2; Mon, 23 May 2022 11:11:02 +0000 Received: by outflank-mailman (input) for mailman id 335844; Mon, 23 May 2022 11:11:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt5xl-0005bF-IG for xen-devel@lists.xenproject.org; Mon, 23 May 2022 11:11:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06eac531-da89-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 13:11:00 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-29-TU8B1xhYNoeYEmIo9DhNyw-1; Mon, 23 May 2022 13:10:56 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4594.eurprd04.prod.outlook.com (2603:10a6:208:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 11:10:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 11:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06eac531-da89-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653304260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7fPPiBlgOPs6P6JF+blXy1krqzPMpVTVaSWtLH9QW94=; b=Tb/AQQQcWWW9XA+S/U8VLaKRtZi8iyj+ptrQ8UrIrLWjZrcN3qm+gA7iWH5RNAES5ZzTfN yvuzaOa8x1lc58JKN4jLgG+Oqk3jIbBvaALv+mutBJM9exNaTtYFwHMQ1/bQHMW+cw2J/E c6gPmnC4uMMAdlXeZyIgd5SUoh8pP58= X-MC-Unique: TU8B1xhYNoeYEmIo9DhNyw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljXMtkR+XpfZw4dwNvzd9XfdAq1YI6dFC42VUP3i1cA+bAr9XDjHkeZmGJUoimB1tkrdrzYpnwfXl6R6ws0RaZpnrepGQlAi2t42poB+qrh8rD9l1MfsKCGN6tLu922UApBG5aqOESoWpKrnpPQiV8m0Iy9KAtZ5Z+f//tnULVQ0NW+UB69Tt+EeI+VALbwxBJuIK+ptkAWFZMby8sUAgYeMlaDqVQ1lDpCrS6FuA5OiDnL7OWG+ZDGsnIc5P89CD2p3N5onks901VGrOdYc84UFXEKL6amtnHHo9RBmok4s9KcHpIgfCpzjCqbghXYmkgcl69789+09PaM5XZYAEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7fPPiBlgOPs6P6JF+blXy1krqzPMpVTVaSWtLH9QW94=; b=Dja7mO19nj2Er8lvq1xoS3DAY1+ioNKQG6sScSaOOhG/F0S17su7TLmQFdHI/p4L3lCzeEwB9f9qOCuMZ0qb2Su0JCfglyrb9LNM5rE9n1ikFFTHRk1D+jYNlRQaoRYXUEVLUfw/LI26wIqNFDK3YASe7QCu2SwRTC8ihxBWoR2NFpj2mfHEeMKC4j0+/1t8b7G30Sw5MBnRXf/2caj8Xw54AWeqslFMjNuLZ7zoiQJEDKjTOG61IMZWKPmn/cCZQpOVlQNNPpMFY+aE+0Yi7XkVno7cyQuHuggz65Oo/LGgtmqioAqZgvB2hcVWQLWWgAEJZouhIQZxdeYVh2ET+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 23 May 2022 13:10:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Content-Language: en-US To: Lin Liu Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0210.eurprd06.prod.outlook.com (2603:10a6:20b:45d::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e10e87fb-b18d-4c37-8c5b-08da3cace7eb X-MS-TrafficTypeDiagnostic: AM0PR04MB4594:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EvVM1zqLsDM7CREDkXBHQ4i5LJT6du6diM8ST8NvqXSxqrqHlmGQBKeNTs/QlZlFXyjRpEZmJpRv0/Yl/S4poqjoajkrLLjusc3uZDxkl0JlvV3Z5Hz/NFmVLv62/H8EBRO7xXhTc8WFEyNp1WDU8y5laqr6PIsRNabhOahPL4fzD3h0EmnlOBkvDKoQKiz3PdiAY4aBIoN6DKoqR6G3+cemFCCPKHBSj3DBw+kQdHB/2bD56030Dsw8WSrlOZfvJlSTNYGmO9zvOBmALjCCKt3FIA7UMPvflLihRmf+VSkGv88PFL0nn1PpGwDzGlCpqa2ryO+jVDEgtTDikxb9jGDbLd/up3aMzbxid5xDEgd+QQGiBOrr50zX42arm7IyYqwSyvuWU6iV1YV6+46p4QtZIPYkXJMUyIe1AquOgAc1AQjO1QwWeIEo6BE6WzvFURR/23w1dO/EMeP6VxophEeTPlH7LMUJttE0yM9AlK3vA5Jn2LuZJraaJ6OIVX1RmnJ5QWIMz1eFrWfnMxTyEb4QRfcriMS+APY1V5Eo43DUR57dCjtTcg7rCCcj0HFQbjZEg3kJoaSEmsSCl3XefVTayayyIlbcOAYIS00K7VpQu0pJdk+sepMmIchkxF03HMn4Usik1Fpn1Xw5Yq3FJ1LZpNAiAnNI7l3h3RUQZOWT2ljeKtD8/dwmn8Zt/iLGJiYDJCn99fxZJZYl8kORxWTLrujKlsd53ORtVge2cCj86lzC1q07Mctbd2lj5799 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(2906002)(6486002)(26005)(6512007)(36756003)(186003)(508600001)(6506007)(2616005)(66476007)(66556008)(66946007)(5660300002)(4326008)(54906003)(31696002)(316002)(6916009)(38100700002)(8936002)(31686004)(8676002)(4744005)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG5pamRDTDJXVUFMVTczSHlOWmU2YllHMXBVYWZ5a2JXUS9QeVN5blM4N1ZZ?= =?utf-8?B?ZE93dDk1a3doTmpPNW9Db0xMeEJybWpQQzlza2RjMlhOWEViNnZpM1FrQkJD?= =?utf-8?B?N1QyemZYS2FQRktRc1lrWS9DaXlkK3BnSjJPQ2xsT2lRWjBtYVNvN0tITUJW?= =?utf-8?B?RW85ZDR5dDN4bHJXSmtNaTZEUytCVGFCSUZHbTUrSlRRVGl0V0pwck01NURh?= =?utf-8?B?SCtMNnFUYlA1ZXhhOFhuMU1rY0dsWDFYWW9OUVJFNWtqWldXZXptUW9VOG0y?= =?utf-8?B?Y05vcTAwWnBONThKWkNZWVpUV2lwdUVVTDYwYlNwMCtMMmxTUlNjYTVJNWNY?= =?utf-8?B?YVZiVFcvazUyeXg4WWVDQ1k3TjVhZU9vVmFZSWIyMW9LcmlTTXBsejIyVmg0?= =?utf-8?B?NlVRVjB4bGxGVWlxd3BBalk1aGNtZ1VnaXAzYlJIT2IvYVNBOU1IZUdlbTRJ?= =?utf-8?B?a0l5dHpzbUJzdmNLQ2U2NXBFNXN5eWw3eHNqdlJpRWhJdmpHOWpqT3ZZblFE?= =?utf-8?B?S1Z3Rk9ybW5raStOOUl3UzZVaWo4ZWJkeW4rSTlyTEo4dGpsb2pQSjVZaGNT?= =?utf-8?B?OXE3emt2bTRtWjdYbmhCakd1SStQNzBOSk1SaGdkcGF4Q25mV3ByUXJWOFFU?= =?utf-8?B?dGRPN0RmTi9Kc1hHd3hpb29SR25TNnp6d2JTclZtMU9LM3dyUVRTQ0tGSDY2?= =?utf-8?B?STBJazVic1VTSElKTUFnUTBLenpDbDRWU2U2OFVjV1FhbmZDRHlpRnZSemtF?= =?utf-8?B?YWx0VlVQYXhVTDBySXdNZUg5Tlp2RVNCWkF2TkhVT1U5d1dVQjhxTEhxREFr?= =?utf-8?B?aE9JSFdOZ1ZzTlhjanh5anArSHBHaktjRWFiTERmSDVEbS93clFDSlVad3ll?= =?utf-8?B?U1VtemhXeDFydm1LQVN1WHk1dkhOUWJ0QVpIUWtuUnhkUHNIQ3NDV21XKzky?= =?utf-8?B?WEZ2WGl6RFlwV0hhNUlPT1lXdW8rTmYvL0lPcGVJWmw3VnNVT1hBNTU1MDVp?= =?utf-8?B?QUIwSUZ4N293a29kU2UrWjJtOXVTZW96WGY5WlpyVVNQZFE0QUdkVVRkUlRN?= =?utf-8?B?ZlNoeXZTU2ovamNmbytDYW5GRTAzUE82a3VQSVhzaUlPK3ZRMkg3RzdwUUsz?= =?utf-8?B?ZlJkTU1HQTIyeHlhRmdrNHVpMG1rY3k1Vytmam5SWUJVaVJ1dnhsUXZNdGRp?= =?utf-8?B?MUVERlNhZWpmdnk4ckFXcW8zRFgwMUxQY0NLYy90YjA0VTBqbVJMSER2Znk1?= =?utf-8?B?ZUtOOVhnbFRTamJ1UDhXekZhS3JBYmcrUGNpQVJObVh4c0JLRVNzV1VIbDlB?= =?utf-8?B?RlVhZUw0VUQ2WXcycGNka1luK2dMSXg2Ni9qOVVKeWxrbVNIRkdQMXdYTzB0?= =?utf-8?B?K1pHbHBJNitRM1JoMXlZMUM5dEE5WlpGM3FCZStIb3dGUFZ1L0EzLy9JSkpH?= =?utf-8?B?aSt0L1VaL25nTjZOSWZKOWpRNTF4VGRxOTJzZDZQeHFOcldHZkZNOUpqem8x?= =?utf-8?B?QzhWelZRbGcrV1NLeElDeE10aGdNdmJjWUtGb1RnUFAyeFRLN3NzVzVrbnJT?= =?utf-8?B?Z3lxOTRUenRmOUF0TGRDelhUOEhTY1BNK2xOcnA3clJ2UjA1K0ZjQ0J5YzRv?= =?utf-8?B?bXJ3dW9XNURVZURpNC81a3FtOVNEMjVTSXZsWlVoSDFvSDRCMGlIaUN4ejIx?= =?utf-8?B?TjdyMFNPOXh5amZiQ2pzRW1Ea0ZLVjIwUVVhaGJ6Q09IL0ZyeDIvOHJsVTM4?= =?utf-8?B?dC93SXFDWlZIeDhNTzloOXBXZ3QxcUU2SEVJRlBOOXc4Q01lVDgzNTQ1a0lw?= =?utf-8?B?Qk0xRSswMGpRdm52a1pwRXZ2VkRBeVhzcGVkMnlEeEthVHJaKyt1bkVZRDlX?= =?utf-8?B?Wlh0K3dhNTdVNDh5WkM3YjZkQVB3VXVxekpJVHUvdW9oVEd1ZlRDajNKZVVU?= =?utf-8?B?V3d1cVN5Z0tyVHFJWmIrOWEyakFHUUg0REtwMDRMV3VyYUgrSkl0bzArQ01a?= =?utf-8?B?TC9oZEVLMEFIZWgzVmFHT2l4R29xaGhDL0VIaVdyTkl6UGlIanF2UkoxYjUr?= =?utf-8?B?OGExZHg0N0x2Mi8yaUo2RXM2WVB0NzJvd0d0OW9kN2hkdktvL040M09TSXVZ?= =?utf-8?B?L3dzUGFVSEZ4OTIyWHlFQ3IwMnptUUQxTlhrZHFYY3NwcHdRaU1Ia2E5a2JF?= =?utf-8?B?MXRrNGU5ZXU0RmYxOTRoOTZzWEdxQlh2ZTR5d1VMSFk4b1U3WmdxVGRwRXFO?= =?utf-8?B?VlBFd1FsTlNFUnJveTRlYjBmckhBK0I2c0gwMlhkZWhBNEZydUR1OVVSb3BX?= =?utf-8?B?WVBpOVJIODFxaTZCenF4WHMyVWdMWlBJdDRBT05CdVpqRDkyU1RQQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e10e87fb-b18d-4c37-8c5b-08da3cace7eb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 11:10:55.0924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rQuicLxbTuajfbVLRE1r0ckK0kUPkhSo3+qoWzWr/MWwYurx+7rNDIKiNA5qcEBCs86ERKEAPkuqkDuaX4w6pA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4594 On 23.05.2022 11:52, Lin Liu wrote: > --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c > +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c > @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) > return cpu_to_le32(*p); > } > > +static inline u32 le32_to_cpu(u32 val) > +{ > + return le32_to_cpup((const u32 *)&val); > +} Why the cast? And why not uint32_t? Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 11:58:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 11:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335854.560061 (Exim 4.92) (envelope-from ) id 1nt6hF-0001Z0-WB; Mon, 23 May 2022 11:58:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335854.560061; Mon, 23 May 2022 11:58:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt6hF-0001Yt-Sg; Mon, 23 May 2022 11:58:01 +0000 Received: by outflank-mailman (input) for mailman id 335854; Mon, 23 May 2022 11:58:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt6hE-0001Yj-W7; Mon, 23 May 2022 11:58:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt6hE-0006hz-Te; Mon, 23 May 2022 11:58:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt6hE-0002Sk-FQ; Mon, 23 May 2022 11:58:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt6hE-0006ON-Ew; Mon, 23 May 2022 11:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Dy0enWTOTUIlyHQ83KE0FNwyBksGMibQL0agJWNqqw=; b=c/Gz53ftu3halYVfEGV/dEf41n rUcc3AamiR6yclDFB8vhyby6IOyVTb1WlibvgvyLwzlGs5hzEKq2nr+7NNabrVFC4Yk8WfYTKMcsl jgMOqV/Y5x55k2lyHaBxG9Um0WQpJMxiMLX3oUOX/v5JAN2k60yWXPxfzV89CdDJJE00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170700: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 11:58:00 +0000 flight 170700 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170700/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1187 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 75 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 12:36:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 12:36:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335872.560071 (Exim 4.92) (envelope-from ) id 1nt7IN-00061x-BT; Mon, 23 May 2022 12:36:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335872.560071; Mon, 23 May 2022 12:36:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt7IN-00061q-8l; Mon, 23 May 2022 12:36:23 +0000 Received: by outflank-mailman (input) for mailman id 335872; Mon, 23 May 2022 12:36:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt7IM-00061g-78; Mon, 23 May 2022 12:36:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt7IM-0007NZ-61; Mon, 23 May 2022 12:36:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt7IL-0003HP-NV; Mon, 23 May 2022 12:36:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt7IL-0004Yr-My; Mon, 23 May 2022 12:36:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Eu0ggiCBR4HcF8maZ+e8ixs0kiiw9nJtJkXUAmr14DE=; b=nOhWq5NOCKT/LrE5K1t+vpnqQ/ 2CANgjrxeT2LVoktN4VSxpfjooVJXPnc3cZCJsfWMe96+ayD6LLdc9kaifhgUlB1T5VobyvpyL4Tx d6hA9q/DGCc1sfowdQLSJpoK0zzBX7dWJMQTXJKYyyyzEd+JFQbDBX/DHQy24ZdMD4h8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170701: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 12:36:21 +0000 flight 170701 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170701/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1188 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 76 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 13:37:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 13:37:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335882.560082 (Exim 4.92) (envelope-from ) id 1nt8FK-0003fW-U8; Mon, 23 May 2022 13:37:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335882.560082; Mon, 23 May 2022 13:37:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt8FK-0003fN-Ph; Mon, 23 May 2022 13:37:18 +0000 Received: by outflank-mailman (input) for mailman id 335882; Mon, 23 May 2022 13:37:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt8FJ-0003fD-Ga; Mon, 23 May 2022 13:37:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt8FJ-0008N7-Eg; Mon, 23 May 2022 13:37:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt8FI-0006m1-Tf; Mon, 23 May 2022 13:37:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt8FI-00054I-TD; Mon, 23 May 2022 13:37:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+cU9Yvm4CDo01R0DbsMwTcKErGeuXvcoYVT6pcEazBA=; b=QZQo+QsG0HfF2yMx8OUwjpMWNn 66hv6uS4Pa0uH6BEJVnk3FNgqHgNeA77FVhQUJE7ZhCVnxgSDjbYqjwFuFHlHxzSakNEc0fYtI/bV JH6Z97djWwCqZxJy/+N62UWjtWx3oF8JAZA97M+6DV4HNiALntYLm2QVMhIxjNTVYOws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170702: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 13:37:16 +0000 flight 170702 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170702/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1189 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 77 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 14:26:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:26:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335895.560094 (Exim 4.92) (envelope-from ) id 1nt915-0000Za-Qe; Mon, 23 May 2022 14:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335895.560094; Mon, 23 May 2022 14:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt915-0000ZT-NP; Mon, 23 May 2022 14:26:39 +0000 Received: by outflank-mailman (input) for mailman id 335895; Mon, 23 May 2022 14:26:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt914-0000ZJ-Jr; Mon, 23 May 2022 14:26:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt914-0000tw-HN; Mon, 23 May 2022 14:26:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt914-0001K3-1D; Mon, 23 May 2022 14:26:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt914-0005hc-0f; Mon, 23 May 2022 14:26:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OM8Nfg66ia2CpWchrKgQP1Fxh96qdYQ3mlYL13CTUow=; b=QYdueniuTI3uExtSKpF7XITJlL INZyRHhhl6w/SMSTxHENQnDvbNRk1ReCZBua9wJS5YdjX9+6gNn1Fm15MxkCqJ4tiviA6+ySzFk3z hPgvA/C1B3llalWxGwFcrkGWFcQh9m89XunxcTMr4acqskgyf7KQsymxSjAOL31fiPyY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170703: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 14:26:38 +0000 flight 170703 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170703/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1190 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 78 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 14:38:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:38:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335905.560105 (Exim 4.92) (envelope-from ) id 1nt9C0-00027O-Sg; Mon, 23 May 2022 14:37:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335905.560105; Mon, 23 May 2022 14:37:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9C0-00027H-PF; Mon, 23 May 2022 14:37:56 +0000 Received: by outflank-mailman (input) for mailman id 335905; Mon, 23 May 2022 14:37:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9By-000278-VZ for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:37:55 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb822438-daa5-11ec-837e-e5687231ffcc; Mon, 23 May 2022 16:37:51 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 10:37:48 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3110.namprd03.prod.outlook.com (2603:10b6:910:54::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 14:37:36 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Mon, 23 May 2022 14:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb822438-daa5-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653316671; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ykIWMxp9S/25JW1KhJzZmsAmJp57CxXQWyf1K7UkVvE=; b=MZ4ovHK0W0gdoZoxIJc+7LEOFoj8BolCVqxnJhkjm8ywJy6W/2pVRQtR RFExFskVmTeskYnJUNilerRNaOUIew21wVm06WFe42R6/u8K0dOWzJ0i5 GdoIGaR1pr66FPaA4zrXmhzYZd8MQ7S6+UB4ewCqBQGzFEU2TSyF2/bV0 I=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 71960180 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:K7wCVKnBEZJKiHiP2efxMMHo5gz0J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcUD+HPvnbNGD3fdFxPYqy8UhSv5HVn4BhHAZk/yg2FyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWVjV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYERYmHP2VisIhTyJfCixvJr0Y05D7CC3q2SCT5xWun3rE5dxLVRtzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOUu5kEhF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IB+QzN/Ppvi4TV5AxDgLznMZnVQd2PW/4WpUSx/ CXauGusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/R/FyfD21dFDpZMoR67IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLTMZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:t3g80K2k6kr/wmj5T7cNSgqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71960180" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWuThzWFEo55aF/dx5FzZ4jPUjxy+WOy8hnRSyUP4pEvrYTJjIYmxumb2gxLIPOouN2mcH3+LhuMvpI/mAkjEIx1eJHiqm+X7CRWf2CqE5AmZ36D/WWgxrcc5icfkpQ9kpGpMdp2a4U+hPdLwFgovG9gEOEs/7cXELXzIyUleaOIyPQ1abbbM6+n8LOE5ZbGd6Ot7PCobf45HvZfRm5A1LIWdFm+ajLN3WDaNIK0+SYA/T0OGD/R4hqYmqQ5ZJjVcb6jEcnK5lBhzQ7Y2eObvDRWgZwI4Rg9bdvlXMte+rtCxaP0Nbxx3Mv5hlBqaKfMXAcLA4VD3P9ce5wLpwshtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2ACdcgDh55CBtYDnC2JEEp/kSVONdmEgJM7SZUQMlo=; b=K6gw/5zVRHR87B32M8p94aEmjn5bQz6se99cGN+foUFIIpBafndOgUs0DNH2aXLQNUVefUxlqDDIMatRhL1Nj90itHHoSbw/3FP2qZDw9XW9nS2IPECJXLMOoW7g1CBffE8lI4scDLyZX9mfKrIEOWLv4VixAn086z86ODERE70vMVf4aMKRB1AYOc9UQtl9E6Psmne9u6vKbEAjZ3g6wvDgsTMCv0w5pFtEmzHBYyI9S76tNrh7FGuutzi3kzUsf92alGqgh6y9trbBewPAhtfQgIFmUYWJu7uuhTNVyAls1iB2gbqMuFZekX6HyDQrtVuCqKXmYZZfBljKPflUcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2ACdcgDh55CBtYDnC2JEEp/kSVONdmEgJM7SZUQMlo=; b=YJBdDaG1kXRzQn0gsRoEDyKEk+d7RIRaQaSqTMk34uQxIaF24fptSVA9KNI/Q4Q1VagkYxCx3CfjBTBXzh6P33Ps36REy0MudWvjcWhDtnxW7wbDhbJkboFnDJKoU/ST8QaUJGkZjxpF39hUevyKcAWw8MMTQgwNaWbdpn0579k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 16:37:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220516143116.28602-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0161.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73fe121f-5d47-4bc0-b85c-08da3cc9c762 X-MS-TrafficTypeDiagnostic: CY4PR03MB3110:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: idLofqqP98PkPjvascG22wTx8uVF7aVhtCga8iBtlf6naAt5zGrEbyOZyoUsgua0Qsfk9H2gwyuTbNa0RaSG4zEvR2UNc9vtj65nB0M9f8wK/StnKg+zG5NYyl48l8yf7CEJTb1qmUjla2IkByDc+MsILbCAviaAcGhaA42Rmj4pDM0ttbuaY4um7ZNawbtSLRAZ348D8WEuVSxFI9qbt5CgNXVM+ICJt5yHpUXpYOvlnEWik3m/Jvij/6lpSoKf/tmZWFMe/BVAMS4Z6ITL6zgTu4CoMFkUY8GJLHK60NE6w3eEMc8A/h5daG3ePz+JKlJorywgTwedn+7tNPG8xd/yobUrgJkAWQWRBrFCT5YDIAqSJpxqbz9SrTTbpvOs8sk0EZsa9uT6WMwFGxJ74JV2iZH5u3INcsic4YnJU9UvjZdRn+qDh0gdlwFRoJiR6eC89pbCO5t/4rzdpAj0Ujk1t7sUeYVP0gyVn4FTgM5v52eYlaO17IGaQw3YQvLUdo7/vjUgtrne1NeUNDCqXj2yKOSjoXdU/9RHuX/R5vdsBw9QvSimbtwBrImNsOeceqHjjQtSbuPEOUZOe1iv1ktZM7xUfvrm1MBj83fR0leLoN5FlewcB6XEhIEoS76Ak1xO192c+oOlT9m/Qnl6Cg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66476007)(8676002)(66946007)(86362001)(316002)(4326008)(66556008)(38100700002)(6916009)(6486002)(508600001)(54906003)(186003)(6666004)(8936002)(5660300002)(82960400001)(85182001)(6512007)(26005)(2906002)(53546011)(6506007)(33716001)(9686003)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE1aczJtYkpYaDdPeXNzNVkwM3FVYnArY2tIWTdtSHc0N3lSbG1BTU5aYVRs?= =?utf-8?B?OXhrQkpuYjZ1MVNuL0p5eVhkc01ucjI5OUJMV3BDbURleUhhallod0dlM1c5?= =?utf-8?B?NU9hMjU0VFN2NWROUEhHM2wraDVzLysrQjBIMHk4bDMzZndORGpaS3hrdkN4?= =?utf-8?B?aTY5WU9WMWNsbUZQcTFoMXo0TkF1RGhXNjRQbjh5dDY3WEhjeEF2U056ajRt?= =?utf-8?B?dU5WVGdCN0VRSERjZXh3U2Y0TFhRZ3FkMDljWHhlUFQ1VFd6bmhLOTA2QlUy?= =?utf-8?B?VE8wMU5DTGMrbEIwUFFnNG9XMExzd0FCRUNPSzNBRThmazVZVUNLLzRPY1pB?= =?utf-8?B?S09iSm1JcWNRUEtFby8xNUMyaVlyZVpadlZMNVVCSkN0RXJMc2NlNEQxK1A2?= =?utf-8?B?UW10OFFRN3RHcFFzWVlkeTdQcTRXbXRkWDRSTis3TVNaMTI2cWVDTjkvMFFz?= =?utf-8?B?RXhkSHM4Q3JmbnA3aCs3VFlBYnFtUkFMdWdhRlJvWk5kM1doZFBRcWJ1WEV0?= =?utf-8?B?Zks2eU9vbkRFS3JzVGNKZDZ6UG11Y242b2hwS0o1Y3ZIbWtwbEZYdEV0ajh4?= =?utf-8?B?eTVmTzRYOGFFQ0tITHVOa1RxYkN5WDlFME5jUWxyaFAxMHZNcU9sM3BOV0Zq?= =?utf-8?B?c2w1TFpDQjFhMExteldYK3dWb2tPMkRJK1Z3cEhpWTQ3Q2hpRERxcjc4TVkx?= =?utf-8?B?WWtoSms3azdIVXBqdHVpeGpkRjMxTjJNcUNSdlJJWW5WYzlpWkFVbkNvbVVq?= =?utf-8?B?dlpNMWtWSVJlZ3JsRStpWnphU2lpU2s0YzlnOUFqNGEyaEdXbEtnK3R2TzAv?= =?utf-8?B?eWY1N3Bsa3h4WlE1Qlo5dWcyNDAzWS82YTZPc0FIYTNVaFZKaXIzVFhoYzNi?= =?utf-8?B?MU1zRFhmWDZEWDExeTZVY3lidzlSTUtQV245ZktZa0JGeGtuUWFkT1QxUFlC?= =?utf-8?B?R1NuNXRZS1NxTTVjTytDck9YN0ZERDlOV3pGK0Z0MzZvdFR4MGc1dTBaVCtF?= =?utf-8?B?V1d0d05YQUR0SThoZWdtMnVmWEVxSTIzZ0Y0MHEzUWk0cXV5ZUtLRlNmNldk?= =?utf-8?B?ek4wbjJJL0c0QWFURnlyT0NxdUJyN1prdW1NMG5McEFyQU4rRVJXem1OdnQy?= =?utf-8?B?Y1YwbnFIWDBvbVJLS2hBcHY5YlJTZlplMEEzb1NmWTdJemY0Z0RLdlJSaEFm?= =?utf-8?B?dG9pblpCRXZBNjZ3QVhXNFZUVTM1elAreEF0N0E0cklreitTQWhla0pBY0xZ?= =?utf-8?B?YVdNZ3hFM21OQURwRUdQS09RQlR2bzhzTG41Z2tjcXZpOXdaajZuZkptZkR3?= =?utf-8?B?bkM0QXV4TmZ3UmNaYk43K3RvMExDUGhyZ1ZnNkZZN0JnVkxZRFNIZ1JCWXpY?= =?utf-8?B?dGdIOGhoUUkrY1I1akJkRTNWYjRUbXd0K1BIQ2swZjZOa1dLTXh3NCthUWVw?= =?utf-8?B?QzBXRzBYT1E3V2tDZ205dStlUVpZbUEzT1E2T25NNVBSazlUcHIrRlU1eldx?= =?utf-8?B?aUZYU2dHZ2sxLzJJVVpBOTRQcHRZbHZQT21mUXREcmJTSXVBczJOL3c3YkNu?= =?utf-8?B?SlVlVGdNbUFZWHFIMXlTVU5YVW1PYTg0Y2xxWUcrdXBoSFIzMWtZVURDbVB3?= =?utf-8?B?dExHYW5YbW96ajdUdG51NmZITEQxSXpkWUpTVC9zMzBQRFVqZkJIc3d4dlU2?= =?utf-8?B?OFhzelFpZnNqMExFaG5DdXAxZGVNRnFjTmxyK01kY0pPdEErdVpmKy9OV0ZO?= =?utf-8?B?a2o3MzNXRkI1TDk5Q1dHQTExaEtoODVybCt0aGtlem1pWmpIdThGRmYxVExU?= =?utf-8?B?R1R6b3MrdVcrdkFBdEdMYUlLa09zYnpmcGZNTUptOXF3STRiTzR6b0Q5eEZz?= =?utf-8?B?TlFFL1lVNGtvYVJWbmtEYmtKRmJNMklya203b1hiN3cxaDlmamtOQ2w4L1NQ?= =?utf-8?B?alZlM29MdmhDQ1VWemNPdmxJaDJtc2NDYm1QcllhWkdDMVVQeDBWYkxDangr?= =?utf-8?B?em93cFVGaUwyalc4UVczSFl4d1QxUTY4OWZ1V2IyQm9ZTnFYdDdya3lKR3F1?= =?utf-8?B?NnM5VHZMb3YrME1EZHlqMWt2b3lnM29IM3JGSGFmelNjdU9EaGtJcDRXSkE4?= =?utf-8?B?dU9FcnpGMVVJSzZZTHlPcGJNMXlNU2lrWVNRNUxYMXorR1c5ekVWWENHc0Nw?= =?utf-8?B?RXIxY0ptMGpTZmVNT2NZallmVllaUjJXdXBnc0MrU01PZ2lncm5hbUhWdXp3?= =?utf-8?B?TjRjTFNQMUhDV1p1OVJhOFo0a3FvQXFWS3hSKzU0RXJ2V25jZWE2dTlIbGZ0?= =?utf-8?B?UzFBU25BcVc3dFJxdFh5MHFFbk5UcmpGMGU5V0FuZHZldEVud2NEQT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73fe121f-5d47-4bc0-b85c-08da3cc9c762 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 14:37:35.9918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aul2ait6i622QdG8/9AMphBYdZc+kjQOoVQFhtbwWUZiZrh1bb+tmOr47MtCaKfCqoWTxxZxVwdXhleAo3ZUOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3110 On Wed, May 18, 2022 at 10:49:22AM +0200, Jan Beulich wrote: > On 16.05.2022 16:31, Roger Pau Monne wrote: > > --- a/xen/arch/x86/include/asm/flushtlb.h > > +++ b/xen/arch/x86/include/asm/flushtlb.h > > @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); > > #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) > > > > /* Flush all CPUs' TLBs/caches */ > > -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) > > +#define flush_area(va, flags) \ > > + flush_area_mask(&cpu_online_map, (const void *)(va), flags) > > I have to admit that I would prefer if we kept the "_all" name suffix, > to continue to clearly express the scope of the flush. I'm also not > really happy to see the cast being added globally now. But there where no direct callers of flush_area_all(), so the name was just relevant for it's use in flush_area(). With that now gone I don't see a need for a flush_area_all(), as flush_area_mask() is more appropriate. > > --- a/xen/arch/x86/smp.c > > +++ b/xen/arch/x86/smp.c > > @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > > { > > unsigned int cpu = smp_processor_id(); > > > > - ASSERT(local_irq_is_enabled()); > > + /* Local flushes can be performed with interrupts disabled. */ > > + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); > > Further down we use cpumask_subset(mask, cpumask_of(cpu)), > apparently to also cover the case where mask is empty. I think > you want to do so here as well. Hm, yes. I guess that's cheaper than adding an extra: if ( cpumask_empty() ) return; check at the start of the function. > > if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && > > cpumask_test_cpu(cpu, mask) ) > > I suppose we want a further precaution here: Despite the > !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to > extend what c64bf2d2a625 ("x86: make CPU state flush requests > explicit") and later changes (isolating uses of FLUSH_VCPU_STATE > from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE > for the local CPU altogether. If we really want to exclude the use of FLUSH_VCPU_STATE for the local CPU, we might wish to add this as a separate ASSERT, so that such checking doesn't depend on !local_irq_is_enabled(): ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu)); ASSERT(!cpumask_subset(mask, cpumask_of(cpu)) || !(flags & FLUSH_VCPU_STATE)); > That's because if such somehow made > it into the conditional below here, it would still involve an IPI. Sorry, I'm confused by this: if the mask is empty there should be no IPI involved at all? And we shouldn't even get into the second conditional on the function. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335917.560125 (Exim 4.92) (envelope-from ) id 1nt9P1-0004ca-PT; Mon, 23 May 2022 14:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335917.560125; Mon, 23 May 2022 14:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P1-0004bG-KN; Mon, 23 May 2022 14:51:23 +0000 Received: by outflank-mailman (input) for mailman id 335917; Mon, 23 May 2022 14:51:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P0-0004UL-29 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:22 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd6b1d2c-daa7-11ec-837e-e5687231ffcc; Mon, 23 May 2022 16:51:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd6b1d2c-daa7-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317480; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xDBs1qvtAAesTvfkL22O/NufwMBzfR3Q3oNmyxwcExk=; b=UVQpQwynsMAJv9ke8E5L4YEDGUuOSn1LqZH/VkgA/r7XH+BqRP1IDtSv HJaoFAZQhpCGkvoSKXQ7YI2CJZa+RittcA1wPxGbjfuAMaedPj0GIFXQU AP6nhtkgwIsiqdsI56Fn/fGoe9NnH4lO6tOGpZK/qFZi4Pk0St9KNDsno k=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72354466 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:AFcgL6uZnqFwQTjLo6xaRkJNDufnVMFeMUV32f8akzHdYApBsoF/q tZmKTqAOfnYYmr9fYtybom19klVsJGGmoA3TgA4+CxhE3lE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X4 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8ibvXgg8okDSNnCjglEbV22LvMLkKw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllkzDefCfc7aZvCX7/L9ZlT2zJYasVmQqyFO pZFN2QHgBLoUUxDNUwPFbQFouKW3H2ubRhyjwq2uv9ii4TU5FMoi+W8WDbPQfSRXtlclEuco mPA/kz6DwscOdjZziCKmlqvgenVlC+9R4MWF5W/7PdhhFDVzWsWYDUoUl+8rei8m1SJcdtVI EwJ+QIjtaE3skesS7HVQBmQsHOC+BkGVLJ4EfA+6QyL4rrZ5UCeHGdsZjRMcsA8vck6Azkjz EaUnsjBDCZq9raSTBq1+riYoDyoMAAJPGQCYmkCVgJD7N79yKkjgxSKQtt9HaqditzuBSq20 z2MtDI5hbgYkYgMzarT1VzfmDetupjhRxY4/BnKRXmi6h5lZYmjfMqj7l2zxfRKIZudT1KBl GMZgMXY5+cLZbmMiy6lUOgLBKuu5fuOLHvbm1EHInU6323zoTj5J9kWuWwgYhcyWioZRdP3S ESD4S9KyqYNBkSzdPRbe7KRD88l96e1QLwJScvogspyjolZLVHap3s1NR7LhQgBg2B3z/hhZ M7zndKESC9DVP85lGfeq/I1i+dD+8wo+Y/EqXkXJTyD2KHWWnOaQKxt3LCmPrFgt/PsTOk4H r9i2yq2J/Z3CrSWjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdE+xfgJyr6Sp ijtMqO99LYYrSSaQThml1g5MO+/NXqBhSxT0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNGPPtYtJ 8Tpj/6oW6wVIhyeomx1RcCk/ORKKUXw7SrTbnXNXdTKV8M5L+A/0oS8LlWHGehnJnffiPbSV JX5iVqLEMJeGl04ZCsUAdr2p26MUbEmsLoadyP1zhN7IS0ALKACx/TNs8IK IronPort-HdrOrdr: A9a23:dXNYoap33mr80oql5D7tcYQaV5oleYIsimQD101hICG8cqSj9v xG+85rsyMc6QxhP03I9urwW5VoLUmyyXcX2/h0AV7BZniFhILAFugLhuGOrwEIcxeOj9K1vp 0BT0ERMrPN5CBB/KPH3DU= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="72354466" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , Daniel De Graaf , "Daniel P. Smith" , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Bertrand Marquis , "Konrad Rzeszutek Wilk" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Ross Lagerwall , "Stefano Stabellini" , Volodymyr Babchuk , Wei Liu Subject: [PATCH v5 0/6] Implement byteswap and update references Date: Mon, 23 May 2022 10:50:45 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Lin Liu (6): xen: implement byteswap crypto/vmac: Simplify code with byteswap arm64/find_next_bit: Remove ext2_swab() xen: Switch to byteswap tools: Use new byteswap helper byteorder: Remove byteorder .../libs/guest/xg_dom_decompress_unsafe_xz.c | 5 + .../guest/xg_dom_decompress_unsafe_zstd.c | 3 +- xen/arch/arm/arm64/lib/find_next_bit.c | 36 +--- xen/arch/arm/include/asm/byteorder.h | 6 +- xen/arch/x86/include/asm/byteorder.h | 34 +--- xen/common/device_tree.c | 44 ++--- xen/common/libelf/libelf-private.h | 6 +- xen/common/xz/private.h | 2 +- xen/crypto/vmac.c | 76 +------- xen/include/xen/byteorder.h | 56 ++++++ xen/include/xen/byteorder/big_endian.h | 102 ---------- xen/include/xen/byteorder/generic.h | 68 ------- xen/include/xen/byteorder/little_endian.h | 102 ---------- xen/include/xen/byteorder/swab.h | 183 ------------------ xen/include/xen/byteswap.h | 52 +++++ xen/include/xen/compiler.h | 20 ++ xen/include/xen/unaligned.h | 12 +- 17 files changed, 184 insertions(+), 623 deletions(-) create mode 100644 xen/include/xen/byteorder.h delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h create mode 100644 xen/include/xen/byteswap.h -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335916.560121 (Exim 4.92) (envelope-from ) id 1nt9P1-0004Xo-H8; Mon, 23 May 2022 14:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335916.560121; Mon, 23 May 2022 14:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P1-0004XP-C0; Mon, 23 May 2022 14:51:23 +0000 Received: by outflank-mailman (input) for mailman id 335916; Mon, 23 May 2022 14:51:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9Oz-0004UL-A6 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:21 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd60a81d-daa7-11ec-837e-e5687231ffcc; Mon, 23 May 2022 16:51:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd60a81d-daa7-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317479; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JOv8AP/EVeQyHro0H8u2Y2X1FdOCStAhJyvYflWqHuI=; b=HoMgGVJIkHfuNanzi89ENyoXhRgt0vgUUxv/FQ6fJzKclgi2qqE8R19k z1VgJg/Zdf0J0fbl/DYI/ibTolCwbvdJGVXT70jUNkNRvhJJZRgL/5UUX H6bVWYmWL6eMpmxtBnfd1tSBL63XolLCMQDrobmrV5vgRa2+KDkGsBc17 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71961684 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:EZo7ZqNM+UmN7qLvrR2Rl8FynXyQoLVcMsEvi/4bfWQNrUpxgTQBx jEdDG7SO/ffZ2L0KopyPd618hkAuZTRzdFiSAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NUw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2 MtUmaWRciETN+7tmbtHaTd2IiN5BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYABjWlp2JASdRrYT +FGQxE1MCrDXyxwKGo0A5Qsrem6nUCqJlW0r3rK/PFqsgA/1jdZ0rLgLd7UcdyiXthOkwCTo Weu12bkBhAXMvSPxDzD9Wij7sfQmQvrVYRUE6e3ntZUh1mUyn0WGQchf1KxqvmkiWazQ9tab UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6CHXQNRDNFbN0gtec1SCYs2 1vPmMnmbRRlvaeJU3ub+vGRpCmrJCkOBWYYYGkPSg5t3jX4iNht1FSVFI8lSfPryI2ucd3t/ 9yUhDggnpkqrPUt7az43FGY2QiCiKnLSTdgs207QVmZAhNFiJ+NPtL1sgKAvaYbdu51XXHa4 iFaxpH2APQmSMjUyXfTGLhl8KSBva7tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj KM+VGpsCH5v0JiCN/Yfj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhV3y/1jZ c7BKZ/8ZZr/NUiA5GPrL9rxLJdxnnxurY8tbc6TI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A P4GX/ZmPy53CbWkCgGOqNZ7BQlTfRATWMGtw+QKJ7HrH+aTMDx4YxMn6eh5K9INcmU8vrqgw 0xRrWcBlwOv1CWadFzQAp2hAZu2NatCQbsAFXREFT6VN7ILOO5DMI93m0MLQIQa IronPort-HdrOrdr: A9a23:p9o3WKo1bE4XVxsHXXyN1cQaV5oTeYIsimQD101hICG8cqSj+f xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71961684" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , "Jan Beulich" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v5 1/6] xen: implement byteswap Date: Mon, 23 May 2022 10:50:46 -0400 Message-ID: <4d5b36ffc215d954e40ba8f6f3bf11402c015b87.1653316202.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit swab() is massively over complicated and can be simplified by re-implementing using compiler builtins. The compilers provide builtin function to swap bytes. * gcc: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html * clang: https://clang.llvm.org/docs/LanguageExtensions.html This patch introduces a new byteswapping infrastructure in terms of compiler builtins and bswapXX(), so the swab() infrastructure can be retired. Signed-off-by: Lin Liu Reviewed-by: Andrew Cooper --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Cc: "Roger Pau Monné" Changes in v5: - Move `PASTE` back to xen/lib.h - Define `PASTE` for tools in xen-tools/libs.h Changes in v4: - Move `PASTE` definition to xen/compiler.h to support tools - Revert emacs magics Changes in v3: - Check __has_builtin instead of GNUC version Changes in v2: - Add fallback for compilers without __builtin_bswap - Implement with plain C instead of macros --- tools/include/xen-tools/libs.h | 4 ++ xen/arch/arm/include/asm/byteorder.h | 6 ++- xen/arch/x86/include/asm/byteorder.h | 34 ++--------------- xen/include/xen/byteorder.h | 56 ++++++++++++++++++++++++++++ xen/include/xen/byteswap.h | 44 ++++++++++++++++++++++ xen/include/xen/compiler.h | 20 ++++++++++ 6 files changed, 132 insertions(+), 32 deletions(-) create mode 100644 xen/include/xen/byteorder.h create mode 100644 xen/include/xen/byteswap.h diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h index a16e0c3807..fc12ac84c6 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/libs.h @@ -63,4 +63,8 @@ #define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1)) #endif +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_(a, b) a ## b +#define PASTE(a, b) PASTE_(a, b) + #endif /* __XEN_TOOLS_LIBS__ */ diff --git a/xen/arch/arm/include/asm/byteorder.h b/xen/arch/arm/include/asm/byteorder.h index 9c712c4788..b6a33b23c0 100644 --- a/xen/arch/arm/include/asm/byteorder.h +++ b/xen/arch/arm/include/asm/byteorder.h @@ -1,9 +1,11 @@ #ifndef __ASM_ARM_BYTEORDER_H__ #define __ASM_ARM_BYTEORDER_H__ -#define __BYTEORDER_HAS_U64__ +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -#include +#include #endif /* __ASM_ARM_BYTEORDER_H__ */ /* diff --git a/xen/arch/x86/include/asm/byteorder.h b/xen/arch/x86/include/asm/byteorder.h index 1f77e502a5..82aadee7bd 100644 --- a/xen/arch/x86/include/asm/byteorder.h +++ b/xen/arch/x86/include/asm/byteorder.h @@ -1,36 +1,10 @@ #ifndef __ASM_X86_BYTEORDER_H__ #define __ASM_X86_BYTEORDER_H__ -#include -#include +#ifndef __BYTE_ORDER__ + #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#endif -static inline __attribute_const__ __u32 ___arch__swab32(__u32 x) -{ - asm("bswap %0" : "=r" (x) : "0" (x)); - return x; -} - -static inline __attribute_const__ __u64 ___arch__swab64(__u64 val) -{ - union { - struct { __u32 a,b; } s; - __u64 u; - } v; - v.u = val; - asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" - : "=r" (v.s.a), "=r" (v.s.b) - : "0" (v.s.a), "1" (v.s.b)); - return v.u; -} - -/* Do not define swab16. Gcc is smart enough to recognize "C" version and - convert it into rotation or exhange. */ - -#define __arch__swab64(x) ___arch__swab64(x) -#define __arch__swab32(x) ___arch__swab32(x) - -#define __BYTEORDER_HAS_U64__ - -#include +#include #endif /* __ASM_X86_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteorder.h b/xen/include/xen/byteorder.h new file mode 100644 index 0000000000..2ec434e6a6 --- /dev/null +++ b/xen/include/xen/byteorder.h @@ -0,0 +1,56 @@ +#ifndef __XEN_BYTEORDER_H__ +#define __XEN_BYTEORDER_H__ + +#include + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ + +# ifndef __LITTLE_ENDIAN +# define __LITTLE_ENDIAN 1234 +# endif + +# ifndef __LITTLE_ENDIAN_BITFIELD +# define __LITTLE_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) (x) +# define le64_to_cpu(x) (x) +# define cpu_to_le32(x) (x) +# define le32_to_cpu(x) (x) +# define cpu_to_le16(x) (x) +# define le16_to_cpu(x) (x) +# define cpu_to_be64(x) bswap64(x) +# define be64_to_cpu(x) bswap64(x) +# define cpu_to_be32(x) bswap32(x) +# define be32_to_cpu(x) bswap32(x) +# define cpu_to_be16(x) bswap16(x) +# define be16_to_cpu(x) bswap16(x) + +#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ + +# ifndef __BIG_ENDIAN +# define __BIG_ENDIAN 4321 +# endif + +# ifndef __BIG_ENDIAN_BITFIELD +# define __BIG_ENDIAN_BITFIELD +# endif + +# define cpu_to_le64(x) bswap64(x) +# define le64_to_cpu(x) bswap64(x) +# define cpu_to_le32(x) bswap32(x) +# define le32_to_cpu(x) bswap32(x) +# define cpu_to_le16(x) bswap16(x) +# define le16_to_cpu(x) bswap16(x) +# define cpu_to_be64(x) (x) +# define be64_to_cpu(x) (x) +# define cpu_to_be32(x) (x) +# define be32_to_cpu(x) (x) +# define cpu_to_be16(x) (x) +# define be16_to_cpu(x) (x) + +#else +# error "Unknown Endianness" +#endif /* __BYTE_ORDER__ */ + +#endif /* __XEN_BYTEORDER_H__ */ diff --git a/xen/include/xen/byteswap.h b/xen/include/xen/byteswap.h new file mode 100644 index 0000000000..d2e371fbe7 --- /dev/null +++ b/xen/include/xen/byteswap.h @@ -0,0 +1,44 @@ +#ifndef __XEN_BYTESWAP_H__ +#define __XEN_BYTESWAP_H__ + +#include +#include + +#if !__has_builtin(__builtin_bswap16) +static always_inline uint16_t __builtin_bswap16(uint16_t val) +{ + return ((val & 0x00FF) << 8) | ((val & 0xFF00) >> 8); +} +#endif + +#if !__has_builtin(__builtin_bswap32) +static always_inline uint32_t __builtin_bswap32(uint32_t val) +{ + return ((val & 0x000000FF) << 24) | + ((val & 0x0000FF00) << 8) | + ((val & 0x00FF0000) >> 8) | + ((val & 0xFF000000) >> 24); +} +#endif + +#if !__has_builtin(__builtin_bswap64) +static always_inline uint64_t __builtin_bswap64(uint64_t val) +{ + return ((val & 0x00000000000000FF) << 56) | + ((val & 0x000000000000FF00) << 40) | + ((val & 0x0000000000FF0000) << 24) | + ((val & 0x00000000FF000000) << 8) | + ((val & 0x000000FF00000000) >> 8) | + ((val & 0x0000FF0000000000) >> 24) | + ((val & 0x00FF000000000000) >> 40) | + ((val & 0xFF00000000000000) >> 56); +} +#endif + +#define bswap16(x) __builtin_bswap16(x) +#define bswap32(x) __builtin_bswap32(x) +#define bswap64(x) __builtin_bswap64(x) + +#define bswap_ul(x) PASTE(bswap,BITS_PER_LONG)(x) + +#endif /* __XEN_BYTESWAP_H__ */ diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index 933aec09a9..6d77da8a68 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -185,4 +185,24 @@ # define CLANG_DISABLE_WARN_GCC_COMPAT_END #endif +#ifndef __has_builtin +/* + * Backwards compatibility for GCC < 10. + * All supported versions of Clang support __has_builtin + * */ +#define __has_builtin(x) GCC_has ## x + +#define GCC_has__builtin_bswap16 (CONFIG_GCC_VERSION >= 40800) +#define GCC_has__builtin_bswap32 (CONFIG_GCC_VERSION >= 40400) +#define GCC_has__builtin_bswap64 (CONFIG_GCC_VERSION >= 40400) +#endif + +#ifndef __ORDER_LITTLE_ENDIAN__ +# define __ORDER_LITTLE_ENDIAN__ 1234 +#endif + +#ifndef __ORDER_BIG_ENDIAN__ +# define __ORDER_BIG_ENDIAN__ 4321 +#endif + #endif /* __LINUX_COMPILER_H */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335918.560136 (Exim 4.92) (envelope-from ) id 1nt9P2-0004q4-Eo; Mon, 23 May 2022 14:51:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335918.560136; Mon, 23 May 2022 14:51:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P2-0004mp-62; Mon, 23 May 2022 14:51:24 +0000 Received: by outflank-mailman (input) for mailman id 335918; Mon, 23 May 2022 14:51:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P1-0004UL-2B for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce0dc41e-daa7-11ec-837e-e5687231ffcc; Mon, 23 May 2022 16:51:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce0dc41e-daa7-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317480; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fEkEMnPb+q1gLdgxKH7ndanRPUKwGzgXMdy6eBWVxBI=; b=DXrPC4QOCwOElkYATr/Js0+vp8foDbv3mXC2e8FsZDQgIwn11qGYvhqP 9xGx7J7HokoduwJR//7dSxAaRsa+KyFen0rBaV4hYdETcTWCJbs2w38Hu m7UZJ8/6GAX88IXOn/wWjDFhAHhA+d9dUFqS0uvm47ngSpNHAUNH6hfuJ s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71952261 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:j3VJc6C6VHKExRVW/33jw5YqxClBgxIJ4kV8jS/XYbTApD0i0DFVm GMdWGrXb6yCZmWmeNojbNjg8EgOu5+GxtRlQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj2dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh9k +hdqZ+BbT0uEZ33ltkyY0JXTQpXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwnLc+tOIICknph0SvYHbAtRpWrr6DiuoYJgW1q2Jkm8fD2O escQmpXUxT8fl5Ka0YIIqwbgsuRvyyqG9FfgA3M/vdmi4TJ9yRz36LqK8H9YcGRSINemUPwj n3C13T0BFcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOGTeKR0xDkHYgFc gpNp3Ro/fNaGFGXosfVU0aFsGKHjzomXPVgKOMHxzHWxfT/ylPMboQbdQKteODKpedvG2Fxj ATZz4izbdB8mObLECzAr994uRv3YHFIdjFaOEfoWCNfu7HeTJcPYgUjpzqJOIq8lZXLFD752 FhmRwBu1uxI3abnO0hWlG0rYg5ARbCTF2bZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt 3Vss5HAsbtUUc3RzXbVGbVl8FSVCxGtaWC0vLKSN8N5q2TFF4CLI+i8Hw2S1G82a51ZKFcFk WfYuB9L5Y87AZdZRfYfXm5FMOxzlfKIPY28Dpj8N4MeCrAsJVTv1Hw/OiatM5XFzRFEfVcXY s/LL65BzB8yVMxa8dZBb75CiO96nn1jnDm7qFKS503P7IdyrUW9Ed8tWGZipMhghE9YiG05K +piCvY= IronPort-HdrOrdr: A9a23:r2IBQ6nroQw9VA7sluCIaLrjjkLpDfIU3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7gr5OUtQ4exoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO VbAsxD4bXLfCFHZK3BgTVQfexO/DD+ytHLudvj X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71952261" From: Lin Liu To: CC: Lin Liu , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v5 5/6] tools: Use new byteswap helper Date: Mon, 23 May 2022 10:50:50 -0400 Message-ID: <334994153a7321e733b4234f9d587fc75549c0a0.1653314499.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Include new header to use new byteswap helper No functional change. Signed-off-by: Lin Liu --- Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross --- tools/libs/guest/xg_dom_decompress_unsafe_xz.c | 5 +++++ tools/libs/guest/xg_dom_decompress_unsafe_zstd.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c index fc48198741..493427d517 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) return cpu_to_le32(*p); } +static inline u32 le32_to_cpu(u32 val) +{ + return le32_to_cpup((const u32 *)&val); +} + #define __force #define always_inline diff --git a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c index 01eafaaaa6..b06f2e767f 100644 --- a/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c +++ b/tools/libs/guest/xg_dom_decompress_unsafe_zstd.c @@ -31,7 +31,8 @@ typedef uint64_t __be64; #define __BYTEORDER_HAS_U64__ #define __TYPES_H__ /* xen/types.h guard */ -#include "../../xen/include/xen/byteorder/little_endian.h" +#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ +#include "../../xen/include/xen/byteorder.h" #define __ASM_UNALIGNED_H__ /* asm/unaligned.h guard */ #include "../../xen/include/xen/unaligned.h" #include "../../xen/include/xen/xxhash.h" -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335915.560116 (Exim 4.92) (envelope-from ) id 1nt9P1-0004Ui-76; Mon, 23 May 2022 14:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335915.560116; Mon, 23 May 2022 14:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P1-0004Ub-36; Mon, 23 May 2022 14:51:23 +0000 Received: by outflank-mailman (input) for mailman id 335915; Mon, 23 May 2022 14:51:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9Oz-0004UK-4P for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccbd1f19-daa7-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 16:51:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccbd1f19-daa7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317478; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ENKGHyqakgatMFXhjwFCV+ZEI5TqFZ1FQ890jq+2cI4=; b=dpP7Eo9MVxA1Eki06dwzhQKcMsEkIQhngjqfTSP8QlB/ujtrCCVxyC1P IUrwmbOZQOPfh0iUQF9wWGLedU/yORnmh76MXGvR1+F7prJSwoGAlioTA hEVR3EffCOQ2C9TMP3O7smimcDQSaexMJDeoDt9oulURIBD9TyJYQXibK o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71813473 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:M9Lx6KqtT/uefQaSo9LVY+lyAKheBmIIZRIvgKrLsJaIsI4StFCzt garIBmFP63cYTP3eY0jOoW380IAvp6DyYc2TQY5/300E3kX95uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 4iq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBIIPRt/o0fEFhETBAGrEFqIWdZnezrpnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIyTDfS/InXLjIQrnQ5M8e1zA17ixLNamHN 5NCNWU0BPjGSzxleWUMVcMQpd6HoFmuVTN5tl+spLVitgA/yyQuieOwYbI5YOeiXt5Jl0yVo mbH+WXRARwAMtGbjz2f/RqEhPLLnC79cJIfEvu/7PECqEKX7nweDlsRT1TTiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZjRMcsA8vck6Azkjz EaUnsjBDCZq9raSTBqgGqy89G3of3JPdClbOHFCHVBtD8TfTJ8bkDzSYchKP/aMjMzLPi2zk wrQ6ycymOBG5SIU7JlX7Wwrkhr1+MWSFFVltl6NNo62xlgnPdD4PuRE/XCetK8dd9jBEzFtq VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sx28za67ogRezP CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKM4EUPsQtLVXfpXEGiausM4fFyRVErE3CE c3DLZbE4YgyV8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7FZtTCf9dFvxC3PXNrpRxPrd+G39q o8PX+PXmk43eLCvPUHqHXs7cAliwY4TXsim9aS6t4erf2JbJY3WI6aOmONwI9E4xv49eyWh1 ijVZ3K0AWHX3RXvQThmoFg5AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:29xbca0mcaqog/mtes5oewqjBIgkLtp133Aq2lEZdPRUGvb4qy nIpoVj6faUskdrZJhOo6HiBEDtexzhHNtOkO0s1NSZLW/bUQmTXeNfBOLZqlWKcUCTygce79 YGT0EXMqyJMbEQt6bHCWeDferIuOP3lZyVuQ== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71813473" From: Lin Liu To: CC: Lin Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: [PATCH v5 6/6] byteorder: Remove byteorder Date: Mon, 23 May 2022 10:50:51 -0400 Message-ID: <1b9957326f5018c38ce6c523e3e5ab67f012ac00.1653314499.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain include/xen/byteswap.h has simplify the interface, just clean the old interface No functional change Signed-off-by: Lin Liu Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Bertrand Marquis Cc: Stefano Stabellini Cc: Wei Liu --- xen/include/xen/byteorder/big_endian.h | 102 ------------ xen/include/xen/byteorder/generic.h | 68 -------- xen/include/xen/byteorder/little_endian.h | 102 ------------ xen/include/xen/byteorder/swab.h | 183 ---------------------- 4 files changed, 455 deletions(-) delete mode 100644 xen/include/xen/byteorder/big_endian.h delete mode 100644 xen/include/xen/byteorder/generic.h delete mode 100644 xen/include/xen/byteorder/little_endian.h delete mode 100644 xen/include/xen/byteorder/swab.h diff --git a/xen/include/xen/byteorder/big_endian.h b/xen/include/xen/byteorder/big_endian.h deleted file mode 100644 index 40eb80a390..0000000000 --- a/xen/include/xen/byteorder/big_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_BIG_ENDIAN_H__ -#define __XEN_BYTEORDER_BIG_ENDIAN_H__ - -#ifndef __BIG_ENDIAN -#define __BIG_ENDIAN 4321 -#endif -#ifndef __BIG_ENDIAN_BITFIELD -#define __BIG_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)___constant_swab64((x))) -#define __constant_le64_to_cpu(x) ___constant_swab64((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)___constant_swab32((x))) -#define __constant_le32_to_cpu(x) ___constant_swab32((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)___constant_swab16((x))) -#define __constant_le16_to_cpu(x) ___constant_swab16((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)__swab64((x))) -#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)__swab32((x))) -#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)__swab16((x))) -#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)(__u64)(x)) -#define __be64_to_cpu(x) ((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)(__u32)(x)) -#define __be32_to_cpu(x) ((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)(__u16)(x)) -#define __be16_to_cpu(x) ((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)__swab64p(p); -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)__swab32p(p); -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)__swab16p(p); -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return __swab16p((__u16 *)p); -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)*p; -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return (__force __u64)*p; -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)*p; -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return (__force __u32)*p; -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)*p; -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return (__force __u16)*p; -} -#define __cpu_to_le64s(x) __swab64s((x)) -#define __le64_to_cpus(x) __swab64s((x)) -#define __cpu_to_le32s(x) __swab32s((x)) -#define __le32_to_cpus(x) __swab32s((x)) -#define __cpu_to_le16s(x) __swab16s((x)) -#define __le16_to_cpus(x) __swab16s((x)) -#define __cpu_to_be64s(x) do {} while (0) -#define __be64_to_cpus(x) do {} while (0) -#define __cpu_to_be32s(x) do {} while (0) -#define __be32_to_cpus(x) do {} while (0) -#define __cpu_to_be16s(x) do {} while (0) -#define __be16_to_cpus(x) do {} while (0) - -#include - -#endif /* __XEN_BYTEORDER_BIG_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/generic.h b/xen/include/xen/byteorder/generic.h deleted file mode 100644 index 8a0006b755..0000000000 --- a/xen/include/xen/byteorder/generic.h +++ /dev/null @@ -1,68 +0,0 @@ -#ifndef __XEN_BYTEORDER_GENERIC_H__ -#define __XEN_BYTEORDER_GENERIC_H__ - -/* - * Generic Byte-reordering support - * - * The "... p" macros, like le64_to_cpup, can be used with pointers - * to unaligned data, but there will be a performance penalty on - * some architectures. Use get_unaligned for unaligned data. - * - * The following macros are to be defined by : - * - * Conversion of XX-bit integers (16- 32- or 64-) - * between native CPU format and little/big endian format - * 64-bit stuff only defined for proper architectures - * cpu_to_[bl]eXX(__uXX x) - * [bl]eXX_to_cpu(__uXX x) - * - * The same, but takes a pointer to the value to convert - * cpu_to_[bl]eXXp(__uXX x) - * [bl]eXX_to_cpup(__uXX x) - * - * The same, but change in situ - * cpu_to_[bl]eXXs(__uXX x) - * [bl]eXX_to_cpus(__uXX x) - * - * See asm-foo/byteorder.h for examples of how to provide - * architecture-optimized versions - */ - -#define cpu_to_le64 __cpu_to_le64 -#define le64_to_cpu __le64_to_cpu -#define cpu_to_le32 __cpu_to_le32 -#define le32_to_cpu __le32_to_cpu -#define cpu_to_le16 __cpu_to_le16 -#define le16_to_cpu __le16_to_cpu -#define cpu_to_be64 __cpu_to_be64 -#define be64_to_cpu __be64_to_cpu -#define cpu_to_be32 __cpu_to_be32 -#define be32_to_cpu __be32_to_cpu -#define cpu_to_be16 __cpu_to_be16 -#define be16_to_cpu __be16_to_cpu -#define cpu_to_le64p __cpu_to_le64p -#define le64_to_cpup __le64_to_cpup -#define cpu_to_le32p __cpu_to_le32p -#define le32_to_cpup __le32_to_cpup -#define cpu_to_le16p __cpu_to_le16p -#define le16_to_cpup __le16_to_cpup -#define cpu_to_be64p __cpu_to_be64p -#define be64_to_cpup __be64_to_cpup -#define cpu_to_be32p __cpu_to_be32p -#define be32_to_cpup __be32_to_cpup -#define cpu_to_be16p __cpu_to_be16p -#define be16_to_cpup __be16_to_cpup -#define cpu_to_le64s __cpu_to_le64s -#define le64_to_cpus __le64_to_cpus -#define cpu_to_le32s __cpu_to_le32s -#define le32_to_cpus __le32_to_cpus -#define cpu_to_le16s __cpu_to_le16s -#define le16_to_cpus __le16_to_cpus -#define cpu_to_be64s __cpu_to_be64s -#define be64_to_cpus __be64_to_cpus -#define cpu_to_be32s __cpu_to_be32s -#define be32_to_cpus __be32_to_cpus -#define cpu_to_be16s __cpu_to_be16s -#define be16_to_cpus __be16_to_cpus - -#endif /* __XEN_BYTEORDER_GENERIC_H__ */ diff --git a/xen/include/xen/byteorder/little_endian.h b/xen/include/xen/byteorder/little_endian.h deleted file mode 100644 index 4955632793..0000000000 --- a/xen/include/xen/byteorder/little_endian.h +++ /dev/null @@ -1,102 +0,0 @@ -#ifndef __XEN_BYTEORDER_LITTLE_ENDIAN_H__ -#define __XEN_BYTEORDER_LITTLE_ENDIAN_H__ - -#ifndef __LITTLE_ENDIAN -#define __LITTLE_ENDIAN 1234 -#endif -#ifndef __LITTLE_ENDIAN_BITFIELD -#define __LITTLE_ENDIAN_BITFIELD -#endif - -#include -#include - -#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __constant_cpu_to_be64(x) ((__force __be64)___constant_swab64((x))) -#define __constant_be64_to_cpu(x) ___constant_swab64((__force __u64)(__be64)(x)) -#define __constant_cpu_to_be32(x) ((__force __be32)___constant_swab32((x))) -#define __constant_be32_to_cpu(x) ___constant_swab32((__force __u32)(__be32)(x)) -#define __constant_cpu_to_be16(x) ((__force __be16)___constant_swab16((x))) -#define __constant_be16_to_cpu(x) ___constant_swab16((__force __u16)(__be16)(x)) -#define __cpu_to_le64(x) ((__force __le64)(__u64)(x)) -#define __le64_to_cpu(x) ((__force __u64)(__le64)(x)) -#define __cpu_to_le32(x) ((__force __le32)(__u32)(x)) -#define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) -#define __cpu_to_le16(x) ((__force __le16)(__u16)(x)) -#define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) -#define __cpu_to_be64(x) ((__force __be64)__swab64((x))) -#define __be64_to_cpu(x) __swab64((__force __u64)(__be64)(x)) -#define __cpu_to_be32(x) ((__force __be32)__swab32((x))) -#define __be32_to_cpu(x) __swab32((__force __u32)(__be32)(x)) -#define __cpu_to_be16(x) ((__force __be16)__swab16((x))) -#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x)) - -static inline __le64 __cpu_to_le64p(const __u64 *p) -{ - return (__force __le64)*p; -} -static inline __u64 __le64_to_cpup(const __le64 *p) -{ - return (__force __u64)*p; -} -static inline __le32 __cpu_to_le32p(const __u32 *p) -{ - return (__force __le32)*p; -} -static inline __u32 __le32_to_cpup(const __le32 *p) -{ - return (__force __u32)*p; -} -static inline __le16 __cpu_to_le16p(const __u16 *p) -{ - return (__force __le16)*p; -} -static inline __u16 __le16_to_cpup(const __le16 *p) -{ - return (__force __u16)*p; -} -static inline __be64 __cpu_to_be64p(const __u64 *p) -{ - return (__force __be64)__swab64p(p); -} -static inline __u64 __be64_to_cpup(const __be64 *p) -{ - return __swab64p((__u64 *)p); -} -static inline __be32 __cpu_to_be32p(const __u32 *p) -{ - return (__force __be32)__swab32p(p); -} -static inline __u32 __be32_to_cpup(const __be32 *p) -{ - return __swab32p((__u32 *)p); -} -static inline __be16 __cpu_to_be16p(const __u16 *p) -{ - return (__force __be16)__swab16p(p); -} -static inline __u16 __be16_to_cpup(const __be16 *p) -{ - return __swab16p((__u16 *)p); -} -#define __cpu_to_le64s(x) do {} while (0) -#define __le64_to_cpus(x) do {} while (0) -#define __cpu_to_le32s(x) do {} while (0) -#define __le32_to_cpus(x) do {} while (0) -#define __cpu_to_le16s(x) do {} while (0) -#define __le16_to_cpus(x) do {} while (0) -#define __cpu_to_be64s(x) __swab64s((x)) -#define __be64_to_cpus(x) __swab64s((x)) -#define __cpu_to_be32s(x) __swab32s((x)) -#define __be32_to_cpus(x) __swab32s((x)) -#define __cpu_to_be16s(x) __swab16s((x)) -#define __be16_to_cpus(x) __swab16s((x)) - -#include - -#endif /* __XEN_BYTEORDER_LITTLE_ENDIAN_H__ */ diff --git a/xen/include/xen/byteorder/swab.h b/xen/include/xen/byteorder/swab.h deleted file mode 100644 index b7e30f0503..0000000000 --- a/xen/include/xen/byteorder/swab.h +++ /dev/null @@ -1,183 +0,0 @@ -#ifndef __XEN_BYTEORDER_SWAB_H__ -#define __XEN_BYTEORDER_SWAB_H__ - -/* - * Byte-swapping, independently from CPU endianness - * swabXX[ps]?(foo) - * - * Francois-Rene Rideau 19971205 - * separated swab functions from cpu_to_XX, - * to clean up support for bizarre-endian architectures. - */ - -/* casts are necessary for constants, because we never know how for sure - * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable way. - */ -#define ___swab16(x) \ -({ \ - __u16 __x = (x); \ - ((__u16)( \ - (((__u16)(__x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(__x) & (__u16)0xff00U) >> 8) )); \ -}) - -#define ___swab32(x) \ -({ \ - __u32 __x = (x); \ - ((__u32)( \ - (((__u32)(__x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(__x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(__x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(__x) & (__u32)0xff000000UL) >> 24) )); \ -}) - -#define ___swab64(x) \ -({ \ - __u64 __x = (x); \ - ((__u64)( \ - (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) )); \ -}) - -#define ___constant_swab16(x) \ - ((__u16)( \ - (((__u16)(x) & (__u16)0x00ffU) << 8) | \ - (((__u16)(x) & (__u16)0xff00U) >> 8) )) -#define ___constant_swab32(x) \ - ((__u32)( \ - (((__u32)(x) & (__u32)0x000000ffUL) << 24) | \ - (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ - (((__u32)(x) & (__u32)0x00ff0000UL) >> 8) | \ - (((__u32)(x) & (__u32)0xff000000UL) >> 24) )) -#define ___constant_swab64(x) \ - ((__u64)( \ - (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) | \ - (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) | \ - (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) << 8) | \ - (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >> 8) | \ - (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) | \ - (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) | \ - (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) )) - -/* - * provide defaults when no architecture-specific optimization is detected - */ -#ifndef __arch__swab16 -# define __arch__swab16(x) ({ __u16 __tmp = (x) ; ___swab16(__tmp); }) -#endif -#ifndef __arch__swab32 -# define __arch__swab32(x) ({ __u32 __tmp = (x) ; ___swab32(__tmp); }) -#endif -#ifndef __arch__swab64 -# define __arch__swab64(x) ({ __u64 __tmp = (x) ; ___swab64(__tmp); }) -#endif - -#ifndef __arch__swab16p -# define __arch__swab16p(x) __arch__swab16(*(x)) -#endif -#ifndef __arch__swab32p -# define __arch__swab32p(x) __arch__swab32(*(x)) -#endif -#ifndef __arch__swab64p -# define __arch__swab64p(x) __arch__swab64(*(x)) -#endif - -#ifndef __arch__swab16s -# define __arch__swab16s(x) do { *(x) = __arch__swab16p((x)); } while (0) -#endif -#ifndef __arch__swab32s -# define __arch__swab32s(x) do { *(x) = __arch__swab32p((x)); } while (0) -#endif -#ifndef __arch__swab64s -# define __arch__swab64s(x) do { *(x) = __arch__swab64p((x)); } while (0) -#endif - - -/* - * Allow constant folding - */ -#if defined(__GNUC__) && defined(__OPTIMIZE__) -# define __swab16(x) \ -(__builtin_constant_p((__u16)(x)) ? \ - ___swab16((x)) : \ - __fswab16((x))) -# define __swab32(x) \ -(__builtin_constant_p((__u32)(x)) ? \ - ___swab32((x)) : \ - __fswab32((x))) -# define __swab64(x) \ -(__builtin_constant_p((__u64)(x)) ? \ - ___swab64((x)) : \ - __fswab64((x))) -#else -# define __swab16(x) __fswab16(x) -# define __swab32(x) __fswab32(x) -# define __swab64(x) __fswab64(x) -#endif /* OPTIMIZE */ - - -static inline __attribute_const__ __u16 __fswab16(__u16 x) -{ - return __arch__swab16(x); -} -static inline __u16 __swab16p(const __u16 *x) -{ - return __arch__swab16p(x); -} -static inline void __swab16s(__u16 *addr) -{ - __arch__swab16s(addr); -} - -static inline __attribute_const__ __u32 __fswab32(__u32 x) -{ - return __arch__swab32(x); -} -static inline __u32 __swab32p(const __u32 *x) -{ - return __arch__swab32p(x); -} -static inline void __swab32s(__u32 *addr) -{ - __arch__swab32s(addr); -} - -#ifdef __BYTEORDER_HAS_U64__ -static inline __attribute_const__ __u64 __fswab64(__u64 x) -{ -# ifdef __SWAB_64_THRU_32__ - __u32 h = x >> 32; - __u32 l = x & ((1ULL<<32)-1); - return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h))); -# else - return __arch__swab64(x); -# endif -} -static inline __u64 __swab64p(const __u64 *x) -{ - return __arch__swab64p(x); -} -static inline void __swab64s(__u64 *addr) -{ - __arch__swab64s(addr); -} -#endif /* __BYTEORDER_HAS_U64__ */ - -#define swab16 __swab16 -#define swab32 __swab32 -#define swab64 __swab64 -#define swab16p __swab16p -#define swab32p __swab32p -#define swab64p __swab64p -#define swab16s __swab16s -#define swab32s __swab32s -#define swab64s __swab64s - -#endif /* __XEN_BYTEORDER_SWAB_H__ */ -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335919.560160 (Exim 4.92) (envelope-from ) id 1nt9P8-0005dX-JP; Mon, 23 May 2022 14:51:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335919.560160; Mon, 23 May 2022 14:51:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P8-0005dJ-Fd; Mon, 23 May 2022 14:51:30 +0000 Received: by outflank-mailman (input) for mailman id 335919; Mon, 23 May 2022 14:51:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P6-0004UK-Hj for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:28 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d17a142d-daa7-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 16:51:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d17a142d-daa7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317487; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PIpXZNS/tomnFn9AY0+D+Gnk6UU+fhiL/46ZWzyvQm8=; b=MGRhAP5OXJt6xl8G2bK6la+M9DHKvTaWzwkhH4xkWey3xb4dmw+2u+KA HeSOAzAS3zSO7TCbT5xeZckeWmhePcSLlzu4o2kSqbx/pkccnae273QjZ fuvcbQ4xg64EViT8NbYzzvqum2M28hd++otTvakhfJ6ngVr1Yva9jir+I A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74471696 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ofaYo6s6elBj5PFadrhYDeEoHOfnVEZeMUV32f8akzHdYApBsoF/q tZmKTiGPv/eMTb1c9F1PoS/oUoHsMeEn4U2SAs5qis9QnkS+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X4 ouryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi83BqnmnO4lSSJDGn1wJ5Jk35GWeEig5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllkzDefCfc7aZvCX7/L9ZlT2zJYasVmQqqCO JNHOGQHgBLoWz1gOnctJpUEvqTxi2bbahlHuXLKnP9ii4TU5FMoi+W8WDbPQfSRXtlclEuco mPA/kz6DwscOdjZziCKmlqum+vOkCXTSI8UUrqi+ZZCn1m71mEVThoMWjOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwAsRDNbdMYvssNwQDUwz 0KIhPvgHzkpu7qQIU9x7Z/N82n0Y3JMazZfO2lUFmPp/uUPvqktthblStxbCpWuh4H7Aw7S5 B7b9Rgh0uB7YdEw60mrwbzWq2vy+8OTFV5lvV+/snGNtV0gOtP8D2C8wR2CtKsbct7EJrWUl CJc8/Vy+tziGn1keMalZOwWVI+k6P+eWNE3qQ4+RsJxn9hBFpPKQGyx3N2dDB0wWir8UWW1C HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66JNYASPsQoLlferEmCgHJ8OEi0zSARfVwXY 8/HIa5A815EYUiY8NZGb7hEiuJ6rszP7WjSWYr633yaPUm2PRaopUM+GALWNIgRtfrcyC2Mq oY3H5bbkH13DbyhChQ7BKZOdDjm21BgXcCowyGWH8beSjdb9JYJUqCIkeJ5JtE8xcy4VI7gp xmAZ6OR83Kn7VWvFOlAQisLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:JlnEpqrzAzBKtB1aWuE10fsaV5oReYIsimQD101hICG8cqSj9v xG+85rrCMc6QxhI03I9urwW5VoLUmyyXcx2/h0AV7AZniBhILLFvAB0WKK+VSJcEeSmtK1l5 0QFJSWYOeAdWSS5vyb3ODXKbgdKaG8gcWVuds= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="74471696" From: Lin Liu To: CC: Lin Liu , Jan Beulich , "Andrew Cooper" , George Dunlap , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: [PATCH v5 2/6] crypto/vmac: Simplify code with byteswap Date: Mon, 23 May 2022 10:50:47 -0400 Message-ID: <7ba7fbb253220fd35d343490108245471ef4e735.1653314499.git.lin.liu@citrix.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This file has its own implementation of swap bytes. Clean up the code with xen/byteswap.h. No functional change. Signed-off-by: Lin Liu Acked-by: Jan Beulich Reviewed-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Bertrand Marquis Cc: Stefano Stabellini Cc: Wei Liu ---- xen/crypto/vmac.c | 76 ++--------------------------------------------- 1 file changed, 3 insertions(+), 73 deletions(-) diff --git a/xen/crypto/vmac.c b/xen/crypto/vmac.c index 294dd16a52..acb4e015f5 100644 --- a/xen/crypto/vmac.c +++ b/xen/crypto/vmac.c @@ -8,6 +8,7 @@ /* start for Xen */ #include +#include #include #include #include @@ -50,7 +51,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ * MUL64: 64x64->128-bit multiplication * PMUL64: assumes top bits cleared on inputs * ADD128: 128x128->128-bit addition - * GET_REVERSED_64: load and byte-reverse 64-bit word * ----------------------------------------------------------------------- */ /* ----------------------------------------------------------------------- */ @@ -68,22 +68,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({uint64_t x; \ - asm ("bswapq %0" : "=r" (x) : "0"(*(uint64_t *)(p))); x;}) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && __i386__) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint64_t x; \ - uint32_t *tp = (uint32_t *)(p); \ - asm ("bswap %%edx\n\t" \ - "bswap %%eax" \ - : "=A"(x) \ - : "a"(tp[1]), "d"(tp[0])); \ - x; }) /* ----------------------------------------------------------------------- */ #elif (__GNUC__ && __ppc64__) @@ -103,37 +87,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #define PMUL64 MUL64 -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ppc__ || __PPC__)) -/* ----------------------------------------------------------------------- */ - -#define GET_REVERSED_64(p) \ - ({ uint32_t hi, lo, *_p = (uint32_t *)(p); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(lo) : "b%"(0), "r"(_p) ); \ - asm volatile ("lwbrx %0, %1, %2" : "=r"(hi) : "b%"(4), "r"(_p) ); \ - ((uint64_t)hi << 32) | (uint64_t)lo; } ) - -/* ----------------------------------------------------------------------- */ -#elif (__GNUC__ && (__ARMEL__ || __ARM__)) -/* ----------------------------------------------------------------------- */ - -#define bswap32(v) \ -({ uint32_t tmp,out; \ - asm volatile( \ - "eor %1, %2, %2, ror #16\n" \ - "bic %1, %1, #0x00ff0000\n" \ - "mov %0, %2, ror #8\n" \ - "eor %0, %0, %1, lsr #8" \ - : "=r" (out), "=&r" (tmp) \ - : "r" (v)); \ - out;}) - /* ----------------------------------------------------------------------- */ #elif _MSC_VER /* ----------------------------------------------------------------------- */ @@ -154,11 +107,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ (rh) += (ih) + ((rl) < (_il)); \ } -#if _MSC_VER >= 1300 -#define GET_REVERSED_64(p) _byteswap_uint64(*(uint64_t *)(p)) -#pragma intrinsic(_byteswap_uint64) -#endif - #if _MSC_VER >= 1400 && \ (!defined(__INTEL_COMPILER) || __INTEL_COMPILER >= 1000) #define MUL32(i1,i2) (__emulu((uint32_t)(i1),(uint32_t)(i2))) @@ -219,24 +167,6 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ } #endif -#ifndef GET_REVERSED_64 -#ifndef bswap64 -#ifndef bswap32 -#define bswap32(x) \ - ({ uint32_t bsx = (x); \ - ((((bsx) & 0xff000000u) >> 24) | (((bsx) & 0x00ff0000u) >> 8) | \ - (((bsx) & 0x0000ff00u) << 8) | (((bsx) & 0x000000ffu) << 24)); }) -#endif -#define bswap64(x) \ - ({ union { uint64_t ll; uint32_t l[2]; } w, r; \ - w.ll = (x); \ - r.l[0] = bswap32 (w.l[1]); \ - r.l[1] = bswap32 (w.l[0]); \ - r.ll; }) -#endif -#define GET_REVERSED_64(p) bswap64(*(uint64_t *)(p)) -#endif - /* ----------------------------------------------------------------------- */ #if (VMAC_PREFER_BIG_ENDIAN) @@ -247,9 +177,9 @@ const uint64_t mpoly = UINT64_C(0x1fffffff1fffffff); /* Poly key mask */ #if (VMAC_ARCH_BIG_ENDIAN) # define get64BE(ptr) (*(uint64_t *)(ptr)) -# define get64LE(ptr) GET_REVERSED_64(ptr) +# define get64LE(ptr) bswap64(*(uint64_t *)(ptr)) #else /* assume little-endian */ -# define get64BE(ptr) GET_REVERSED_64(ptr) +# define get64BE(ptr) bswap64(*(uint64_t *)(ptr)) # define get64LE(ptr) (*(uint64_t *)(ptr)) #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:51:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:51:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335920.560171 (Exim 4.92) (envelope-from ) id 1nt9PA-0005uW-20; Mon, 23 May 2022 14:51:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335920.560171; Mon, 23 May 2022 14:51:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P9-0005u2-Th; Mon, 23 May 2022 14:51:31 +0000 Received: by outflank-mailman (input) for mailman id 335920; Mon, 23 May 2022 14:51:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9P7-0004UK-Hv for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:29 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1f66eb9-daa7-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 16:51:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1f66eb9-daa7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317487; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xftiHzs7Jai+N95D/Ytak8PcUxB9RjC+60CW9p0z8zA=; b=PmOehN+UD6MgEJWkx69zxO/dGVJIKo6k0AJGrXfKYA/0g0p1S5Hm/mDo d7jWA1UaHhJC1TCiXU2LYiZWmgzpAbGLdlx8K7rCjO2UgtiqUK/PcYbKu n3IFj6q867o+mpf6AyIfFEdd/8e59dFRo/tuVcdVOMdSTvNHrnae/cf4j U=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71813510 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XlamKKKKTXOvhUUFFE+RwZUlxSXFcZb7ZxGr2PjKsXjdYENS3mQOx 2VMXmCBaf+PZmLwKoojbYjloEMFuZ/dm9I1SAtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Qz2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Ph0qaWuUlcKBerRmcAGDRplLi9xHLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBM3qOsUbu2xIxjDFF/c2B5vERs0m4PcHhWdp3Z0XRZ4yY eInOCBSbgrLfyRweXhLUJgS29b4pWfgJmgwRFW9+vNsvjm7IBZK+LrnPcfRe9eKbd5IhUver WXDl0z7HxUbOdq32TeDtHW2iYfngifTSI8UUrqi+ZZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSwVcX0VRC8pH+CvzYfVsBWHul87xuCooLe7hyFHGECQnhEYcY/qc4tbTUw0 xmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZSY8/+D9u9EQtVXST/J4Tq2Is9P6OC6ll lhmsxMCa6UvYd8jjvvmpgqc02L3/PAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9k4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/W7T4i5CqmONoMeCnSUSONg1HgzDXN8Iki3yBR8+U3BE cnznTmQ4YYyVv08kWveqxY12r433CEurV4/triipylLJYG2PSbPIZ9caQPmRrlgvMus/VSOm /4CZpTi9vmqeLCnCsUh2dVLfQ5iwLlSLc2elvG7gcbafVM2STl8VqaLqV7jEqQ895loei7z1 inVcidlJJDX3hUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:nZQ1pqGQKXrPNy73pLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71813510" From: Lin Liu To: CC: Lin Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v5 4/6] xen: Switch to byteswap Date: Mon, 23 May 2022 10:50:49 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Update to use byteswap to swap bytes be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter one explictly No functional change. Signed-off-by: Lin Liu --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Wei Liu Changes in v5: - Add git message to explain be*to_cpu helper Changes in v4: - Revert the __force in type casting Changes in v3: - Update xen/common/device_tree.c to use be32_to_cpu - Keep const in type cast in unaligned.h --- xen/common/device_tree.c | 44 +++++++++++++++--------------- xen/common/libelf/libelf-private.h | 6 ++-- xen/common/xz/private.h | 2 +- xen/include/xen/unaligned.h | 12 ++++---- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4aae281e89..70d3be3be6 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -171,7 +171,7 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, if ( !val || len < sizeof(*out_value) ) return 0; - *out_value = be32_to_cpup(val); + *out_value = be32_to_cpu(*val); return 1; } @@ -264,7 +264,7 @@ int dt_property_read_variable_u32_array(const struct dt_device_node *np, count = sz; while ( count-- ) - *out_values++ = be32_to_cpup(val++); + *out_values++ = be32_to_cpu(*val++); return sz; } @@ -490,7 +490,7 @@ static int __dt_n_addr_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#address-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_ADDR_CELLS_DEFAULT; @@ -507,7 +507,7 @@ int __dt_n_size_cells(const struct dt_device_node *np, bool_t parent) ip = dt_get_property(np, "#size-cells", NULL); if ( ip ) - return be32_to_cpup(ip); + return be32_to_cpu(*ip); } while ( np->parent ); /* No #address-cells property for the root node */ return DT_ROOT_NODE_SIZE_CELLS_DEFAULT; @@ -660,7 +660,7 @@ static void dt_bus_pci_count_cells(const struct dt_device_node *np, static unsigned int dt_bus_pci_get_flags(const __be32 *addr) { unsigned int flags = 0; - u32 w = be32_to_cpup(addr); + u32 w = be32_to_cpu(*addr); switch((w >> 24) & 0x03) { case 0x01: @@ -1077,7 +1077,7 @@ dt_irq_find_parent(const struct dt_device_node *child) if ( parp == NULL ) p = dt_get_parent(child); else - p = dt_find_node_by_phandle(be32_to_cpup(parp)); + p = dt_find_node_by_phandle(be32_to_cpu(*parp)); child = p; } while ( p && dt_get_property(p, "#interrupt-cells", NULL) == NULL ); @@ -1110,7 +1110,7 @@ unsigned int dt_number_of_irq(const struct dt_device_node *device) intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1241,7 +1241,7 @@ int dt_for_each_irq_map(const struct dt_device_node *dev, imaplen -= addrsize + intsize; /* Get the interrupt parent */ - ipar = dt_find_node_by_phandle(be32_to_cpup(imap)); + ipar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1358,8 +1358,8 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, int match, i; dt_dprintk("dt_irq_map_raw: par=%s,intspec=[0x%08x 0x%08x...],ointsize=%d\n", - parent->full_name, be32_to_cpup(intspec), - be32_to_cpup(intspec + 1), ointsize); + parent->full_name, be32_to_cpu(*intspec), + be32_to_cpu(*(intspec+1)), ointsize); ipar = parent; @@ -1471,7 +1471,7 @@ static int dt_irq_map_raw(const struct dt_device_node *parent, dt_dprintk(" -> match=%d (imaplen=%d)\n", match, imaplen); /* Get the interrupt parent */ - newpar = dt_find_node_by_phandle(be32_to_cpup(imap)); + newpar = dt_find_node_by_phandle(be32_to_cpu(*imap)); imap++; --imaplen; @@ -1565,7 +1565,7 @@ int dt_device_get_raw_irq(const struct dt_device_node *device, intlen /= sizeof(*intspec); dt_dprintk(" using 'interrupts' property\n"); - dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpup(intspec), intlen); + dt_dprintk(" intspec=%d intlen=%d\n", be32_to_cpu(*intspec), intlen); /* Look for the interrupt parent. */ p = dt_irq_find_parent(device); @@ -1676,7 +1676,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, * If phandle is 0, then it is an empty entry with no * arguments. Skip forward to the next entry. * */ - phandle = be32_to_cpup(list++); + phandle = be32_to_cpu(*list++); if ( phandle ) { /* @@ -1745,7 +1745,7 @@ static int __dt_parse_phandle_with_args(const struct dt_device_node *np, out_args->np = node; out_args->args_count = count; for ( i = 0; i < count; i++ ) - out_args->args[i] = be32_to_cpup(list++); + out_args->args[i] = be32_to_cpu(*list++); } /* Found it! return success */ @@ -1826,7 +1826,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, int has_name = 0; int new_format = 0; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag != FDT_BEGIN_NODE ) { printk(XENLOG_WARNING "Weird tag at start of node: %x\n", tag); @@ -1919,7 +1919,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, u32 sz, noff; const char *pname; - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); if ( tag == FDT_NOP ) { *p += 4; @@ -1928,8 +1928,8 @@ static unsigned long __init unflatten_dt_node(const void *fdt, if ( tag != FDT_PROP ) break; *p += 4; - sz = be32_to_cpup((__be32 *)(*p)); - noff = be32_to_cpup((__be32 *)((*p) + 4)); + sz = be32_to_cpu(*(__be32 *)(*p)); + noff = be32_to_cpu(*(__be32 *)((*p) + 4)); *p += 8; if ( fdt_version(fdt) < 0x10 ) *p = ROUNDUP(*p, sz >= 8 ? 8 : 4); @@ -1956,13 +1956,13 @@ static unsigned long __init unflatten_dt_node(const void *fdt, (strcmp(pname, "linux,phandle") == 0) ) { if ( np->phandle == 0 ) - np->phandle = be32_to_cpup((__be32*)*p); + np->phandle = be32_to_cpu(*(__be32*)*p); } /* And we process the "ibm,phandle" property * used in pSeries dynamic device tree * stuff */ if ( strcmp(pname, "ibm,phandle") == 0 ) - np->phandle = be32_to_cpup((__be32 *)*p); + np->phandle = be32_to_cpu(*(__be32 *)*p); pp->name = pname; pp->length = sz; pp->value = (void *)*p; @@ -2034,7 +2034,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, *p += 4; else mem = unflatten_dt_node(fdt, mem, p, np, allnextpp, fpsize); - tag = be32_to_cpup((__be32 *)(*p)); + tag = be32_to_cpu(*(__be32 *)(*p)); } if ( tag != FDT_END_NODE ) { @@ -2086,7 +2086,7 @@ static void __init __unflatten_device_tree(const void *fdt, /* Second pass, do actual unflattening */ start = ((unsigned long)fdt) + fdt_off_dt_struct(fdt); unflatten_dt_node(fdt, mem, &start, NULL, &allnextp, 0); - if ( be32_to_cpup((__be32 *)start) != FDT_END ) + if ( be32_to_cpu(*(__be32 *)start) != FDT_END ) printk(XENLOG_WARNING "Weird tag at end of tree: %08x\n", *((u32 *)start)); if ( be32_to_cpu(((__be32 *)mem)[size / 4]) != 0xdeadbeef ) diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h index 47db679966..6062598fb8 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -31,9 +31,9 @@ printk(fmt, ## args ) #define strtoull(str, end, base) simple_strtoull(str, end, base) -#define bswap_16(x) swab16(x) -#define bswap_32(x) swab32(x) -#define bswap_64(x) swab64(x) +#define bswap_16(x) bswap16(x) +#define bswap_32(x) bswap32(x) +#define bswap_64(x) bswap64(x) #else /* !__XEN__ */ diff --git a/xen/common/xz/private.h b/xen/common/xz/private.h index 511343fcc2..97131fa714 100644 --- a/xen/common/xz/private.h +++ b/xen/common/xz/private.h @@ -28,7 +28,7 @@ static inline void put_unaligned_le32(u32 val, void *p) #endif -#define get_le32(p) le32_to_cpup((const uint32_t *)(p)) +#define get_le32(p) le32_to_cpu(*(const uint32_t *)(p)) #define false 0 #define true 1 diff --git a/xen/include/xen/unaligned.h b/xen/include/xen/unaligned.h index 0a2b16d05d..56807bd157 100644 --- a/xen/include/xen/unaligned.h +++ b/xen/include/xen/unaligned.h @@ -20,7 +20,7 @@ static inline uint16_t get_unaligned_be16(const void *p) { - return be16_to_cpup(p); + return be16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_be16(uint16_t val, void *p) @@ -30,7 +30,7 @@ static inline void put_unaligned_be16(uint16_t val, void *p) static inline uint32_t get_unaligned_be32(const void *p) { - return be32_to_cpup(p); + return be32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_be32(uint32_t val, void *p) @@ -40,7 +40,7 @@ static inline void put_unaligned_be32(uint32_t val, void *p) static inline uint64_t get_unaligned_be64(const void *p) { - return be64_to_cpup(p); + return be64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_be64(uint64_t val, void *p) @@ -50,7 +50,7 @@ static inline void put_unaligned_be64(uint64_t val, void *p) static inline uint16_t get_unaligned_le16(const void *p) { - return le16_to_cpup(p); + return le16_to_cpu(*(const uint16_t *)p); } static inline void put_unaligned_le16(uint16_t val, void *p) @@ -60,7 +60,7 @@ static inline void put_unaligned_le16(uint16_t val, void *p) static inline uint32_t get_unaligned_le32(const void *p) { - return le32_to_cpup(p); + return le32_to_cpu(*(const uint32_t *)p); } static inline void put_unaligned_le32(uint32_t val, void *p) @@ -70,7 +70,7 @@ static inline void put_unaligned_le32(uint32_t val, void *p) static inline uint64_t get_unaligned_le64(const void *p) { - return le64_to_cpup(p); + return le64_to_cpu(*(const uint64_t *)p); } static inline void put_unaligned_le64(uint64_t val, void *p) -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 14:53:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:53:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335941.560182 (Exim 4.92) (envelope-from ) id 1nt9RA-00085g-ML; Mon, 23 May 2022 14:53:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335941.560182; Mon, 23 May 2022 14:53:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9RA-00085Z-JN; Mon, 23 May 2022 14:53:36 +0000 Received: by outflank-mailman (input) for mailman id 335941; Mon, 23 May 2022 14:53:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9R9-00085R-Kc for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:53:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9R9-0001P6-6v; Mon, 23 May 2022 14:53:35 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt9R9-0001n6-0s; Mon, 23 May 2022 14:53:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=HdwD5SuMdAwhB0DIrwyTgw36j7IgCNM2z0RXEMW9OWw=; b=NN8W641OvcNrhElmWAaGRWNzWU UK6LbMtbDVM8/BjKDFaWSzwoyDGjjBRPU72A4yUF1kcOieznSJVsIF5TLQWl5GEsMP4g3t/MZypGN 4dPIEyUeNS69If7FCgv53O8CxaIBXok08NHmMarF5/9ECkdo6Z1UhcVe8u3UlIAOeRos=; Message-ID: <1075e4a2-eb7c-6441-28c4-7dbc871f844d@xen.org> Date: Mon, 23 May 2022 15:53:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 3/6] arm64/find_next_bit: Remove ext2_swab() To: Lin Liu , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 15:50, Lin Liu wrote: > ext2 has nothing to do with this logic. You have again not addressed my comment. If you don't understand my comment then please ask. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 14:56:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 14:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335955.560192 (Exim 4.92) (envelope-from ) id 1nt9Tm-0000Kj-3x; Mon, 23 May 2022 14:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335955.560192; Mon, 23 May 2022 14:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9Tm-0000Kc-1N; Mon, 23 May 2022 14:56:18 +0000 Received: by outflank-mailman (input) for mailman id 335955; Mon, 23 May 2022 14:56:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9Tk-0000KW-K1 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:56:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9Tk-0001TX-93; Mon, 23 May 2022 14:56:16 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt9Tk-00025r-35; Mon, 23 May 2022 14:56:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=iJkepqmZ5jpiO45Di6uGR4/U9LUNay4+STQVDF2pqHU=; b=ET4aRH3SOIf6meU9RpREeuKxvA pWG9RJU8oAb9WxLXSznahz3FYxmQFUeRsIF56HdZD1ciUk+4hyRJZjc7aW+rsbPd/q3aYrdxje/Zy umaxjNR6472ihiBJKDNxbRrPM1ZIpTmVIkHeXXHv1JvEGynbMNYK9LmCR28GhRXCdda0=; Message-ID: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> Date: Mon, 23 May 2022 15:56:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 4/6] xen: Switch to byteswap To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 15:50, Lin Liu wrote: > Update to use byteswap to swap bytes > be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter > one explictly But why? I really don't have a suggestion on the comment because I disagree (and AFAICT Jan as well) with the approach. In any case, I think it would be helpful if you participate in the discussion rather than sending a new version quickly. This would make sure you don't spend time on resending with unfinished discussion. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 15:01:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 15:01:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335963.560204 (Exim 4.92) (envelope-from ) id 1nt9YY-0001lP-Mg; Mon, 23 May 2022 15:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335963.560204; Mon, 23 May 2022 15:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9YY-0001lI-JS; Mon, 23 May 2022 15:01:14 +0000 Received: by outflank-mailman (input) for mailman id 335963; Mon, 23 May 2022 15:01:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9YW-0001lB-HN for xen-devel@lists.xenproject.org; Mon, 23 May 2022 15:01:12 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d0a9c15-daa9-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 17:01:09 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nt9XQ-00GTti-N1; Mon, 23 May 2022 17:00:05 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d0a9c15-daa9-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=keKJrvyQ/+r75XOnYYRl19FO+VGyiPJcwICfZxDBkqs=; b=O+C3jDB0Vwu4Y/gkTmW/RCmTwy kNqD2emzzlOs/8A7J1xO/TSH5qapt6sCckUwfqeKLJwoCrpUi4pUQfOKCsbI70QtSFMdfNTmFr+H0 NXT6Oh9iPuG4hVKz84ZvxHpmEirVLNSMQMza54o3VmB+D23FpdTtf7JnpYZ61zk10z8NLp053Dtmb 5G5TvLT8W+VF+imYpIQccZx+LAQHhkmqjWgwAULVFomENEWSpKhN5UeAVPt+Y1vZC04/4FyRoMtUE OHqcld4S4ftUjXzRb6CJS95k+7T+FIlHKMRNj13Qcs75Xk/j3Ix2WaTpEwsP72+2bzr+hEFsSu6v0 WUJ5ifAA==; Message-ID: <0fac8c71-6f18-d15c-23f5-075dbc45f3f9@igalia.com> Date: Mon, 23 May 2022 11:56:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Content-Language: en-US To: Scott Branden , Petr Mladek , Sebastian Reichel , Florian Fainelli , Desmond yan Cc: David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/05/2022 16:20, Scott Branden wrote: > [...] >> Hi Scott / Desmond, thanks for the detailed answer! Is this adapter >> designed to run in x86 only or you have other architectures' use cases? > The adapter may be used in any PCIe design that supports DMA. > So it may be possible to run in arm64 servers. >> >> [...] >> With that said, and given this is a lightweight notifier that ideally >> should run ASAP, I'd keep this one in the hypervisor list. We can >> "adjust" the semantic of this list to include lightweight notifiers that >> reset adapters. > Sounds the best to keep system operating as tested today. >> >> With that said, Petr has a point - not always such list is going to be >> called before kdump. So, that makes me think in another idea: what if we >> have another list, but not on panic path, but instead in the custom >> crash_shutdown()? Drivers could add callbacks there that must execute >> before kexec/kdump, no matter what. > It may be beneficial for some other drivers but for our use we would > then need to register for the panic path and the crash_shutdown path. > We notify the VK card for 2 purposes: one to stop DMA so memory stop > changing during a kdump. And also to get the card into a good state so > resets happen cleanly. Thanks Scott! With that, I guess it's really better to keep this notifier in this hypervisor/early list - I'm planning to do that for V2. Unless Petr or somebody has strong feelings against that, of course. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Mon May 23 15:09:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 15:09:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.335996.560215 (Exim 4.92) (envelope-from ) id 1nt9g3-0002Zu-Ft; Mon, 23 May 2022 15:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335996.560215; Mon, 23 May 2022 15:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9g3-0002Zn-CG; Mon, 23 May 2022 15:08:59 +0000 Received: by outflank-mailman (input) for mailman id 335996; Mon, 23 May 2022 15:08:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9PU-0004UK-4w for xen-devel@lists.xenproject.org; Mon, 23 May 2022 14:51:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dfcb9243-daa7-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 16:51:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfcb9243-daa7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653317511; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=52aGEXz6/L0mi8JKOaEZHZV/EuUs/IK0pCYUytUMr38=; b=XvdNwfClTCQTj+z12XyHP3lB7BbPFHrQ9ywhGRSz8hUaacYcRR3b6bEg AS3sujEK6x33oKkcI9V5H6AsueoLAp7a0Uy8HXUZhZQORGFc0556qflbt VGFWKmiF4QPSLJiShm9LVtBTjGlmw36lY9sTIVdWhpOPNNO5NbWNYamKR g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71325017 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:FNmRQKN3Yb9CelXvrR2Gl8FynXyQoLVcMsEvi/4bfWQNrUoh1z0Bm zdLUT2PPPneZmT9Kt4ibd6ypE0F7JPVn9UxTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NUw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0 +Qd67/pEVsTJ+7CiPQ5agNpGRpAFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALKMjteocep1lrzC3DDOZgSpfGK0nPzYABh21t3pkRdRrYT 5JGYxxhRirfXy10Jw4lK55npPitlmaqJlW0r3rK/PFqsgA/1jdZ0qXpMdfTUsyHQ4NShEnwj mjL5XjjCxcWctmW0yOY82mEj/XK2yj8Xeo6Krq88fJ7hUyJ8UYaAhYWSFiTrOGwjwi1XNc3A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mlyKXO6gKdLmEBRyxGbpots8pebScxy laDktftBDpumL6YU3SQ8vGTtzzaBMQOBTZcP2leF1JDuoS95tFo5v7Scjp9OLWE3oPWQGms+ SnJojguo4wJvMQw6YzuqDgrnAmQSoj1oh8dv1uKBTj+vlMiPuZJdKTztwGFsK8owJKxCwDY4 SNaw5X2APUmV8nlqcCbfAka8FhFDd6hOSaUv1NgFoJJG9+Fqy/6JtA4DN2TyS5U3ic4ldzBO ha7Vft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlLcpn0yORfKhzm9+KTJrU3YE c7GGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PXBt3VGJis+V2Pm /4GbpPi40wGAIXWP3iMmaZOfA9iEJTOLc2vwyChXrXbclQO9aBII6K5/I7NjKQ8wP0Fx7+Vo yjnMqKaoXKm7UD6xcyxQigLQNvSsVxX9ChT0fAEVbpw50UeXA== IronPort-HdrOrdr: A9a23:ForCf66yyJ9tLQO/ZgPXwPDXdLJyesId70hD6qhwISY6TiX+rb HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71325017" From: Lin Liu To: CC: Lin Liu , Julien Grall , "Andrew Cooper" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v5 3/6] arm64/find_next_bit: Remove ext2_swab() Date: Mon, 23 May 2022 10:50:48 -0400 Message-ID: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain ext2 has nothing to do with this logic. Clean up the code with xen/byteswap.h which now has an unsigned long helper. No functional change. Signed-off-by: Lin Liu Acked-by: Julien Grall Reviewed-by: Andrew Cooper --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk --- xen/arch/arm/arm64/lib/find_next_bit.c | 36 +++++--------------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/xen/arch/arm/arm64/lib/find_next_bit.c b/xen/arch/arm/arm64/lib/find_next_bit.c index 8ebf8bfe97..e3b3720ff4 100644 --- a/xen/arch/arm/arm64/lib/find_next_bit.c +++ b/xen/arch/arm/arm64/lib/find_next_bit.c @@ -161,30 +161,6 @@ EXPORT_SYMBOL(find_first_zero_bit); #ifdef __BIG_ENDIAN -/* include/linux/byteorder does not support "unsigned long" type */ -static inline unsigned long ext2_swabp(const unsigned long * x) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64p((u64 *) x); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32p((u32 *) x); -#else -#error BITS_PER_LONG not defined -#endif -} - -/* include/linux/byteorder doesn't support "unsigned long" type */ -static inline unsigned long ext2_swab(const unsigned long y) -{ -#if BITS_PER_LONG == 64 - return (unsigned long) __swab64((u64) y); -#elif BITS_PER_LONG == 32 - return (unsigned long) __swab32((u32) y); -#else -#error BITS_PER_LONG not defined -#endif -} - #ifndef find_next_zero_bit_le unsigned long find_next_zero_bit_le(const void *addr, unsigned long size, unsigned long offset) @@ -199,7 +175,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp |= (~0UL >> (BITS_PER_LONG - offset)); if (size < BITS_PER_LONG) goto found_first; @@ -217,7 +193,7 @@ unsigned long find_next_zero_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp |= ~0UL << size; if (tmp == ~0UL) /* Are any bits zero? */ @@ -226,7 +202,7 @@ found_middle: return result + ffz(tmp); found_middle_swap: - return result + ffz(ext2_swab(tmp)); + return result + ffz(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_zero_bit_le); #endif @@ -245,7 +221,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned size -= result; offset &= (BITS_PER_LONG - 1UL); if (offset) { - tmp = ext2_swabp(p++); + tmp = bswap_ul(*p++); tmp &= (~0UL << offset); if (size < BITS_PER_LONG) goto found_first; @@ -264,7 +240,7 @@ unsigned long find_next_bit_le(const void *addr, unsigned } if (!size) return result; - tmp = ext2_swabp(p); + tmp = bswap_ul(*p); found_first: tmp &= (~0UL >> (BITS_PER_LONG - size)); if (tmp == 0UL) /* Are any bits set? */ @@ -273,7 +249,7 @@ found_middle: return result + __ffs(tmp); found_middle_swap: - return result + __ffs(ext2_swab(tmp)); + return result + __ffs(bswap_ul(tmp)); } EXPORT_SYMBOL(find_next_bit_le); #endif -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 15:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 15:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336005.560225 (Exim 4.92) (envelope-from ) id 1nt9kX-000426-0L; Mon, 23 May 2022 15:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336005.560225; Mon, 23 May 2022 15:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kW-00041z-Tl; Mon, 23 May 2022 15:13:36 +0000 Received: by outflank-mailman (input) for mailman id 336005; Mon, 23 May 2022 15:13:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kW-00041n-68; Mon, 23 May 2022 15:13:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kW-0001ni-3k; Mon, 23 May 2022 15:13:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kV-0004UJ-NE; Mon, 23 May 2022 15:13:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nt9kV-00081V-Ml; Mon, 23 May 2022 15:13:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U7E3eX7xLvKQPkQGWlhlYBa4xQBLrtb86z4YWr50N7k=; b=SSPHueBm79swcXJbDDPP2JvHld 1dk/fuxjiHkuCm7/0vLvHTO5xNlm2R1Oi1aqVzuk3JOjeboX0dPrSAHIZdtIV/mhiSskSkwUxpKVS Jgq+NsSpjH2SeB89bjw6EEqoDhqrGFlAvRSUxov0U6MBEOkjLFYZ8GbY5PUUv5qoBz4M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170704: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 15:13:35 +0000 flight 170704 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170704/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1191 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 79 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 15:14:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 15:14:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336011.560237 (Exim 4.92) (envelope-from ) id 1nt9kv-0004Tm-AT; Mon, 23 May 2022 15:14:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336011.560237; Mon, 23 May 2022 15:14:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kv-0004Tf-7V; Mon, 23 May 2022 15:14:01 +0000 Received: by outflank-mailman (input) for mailman id 336011; Mon, 23 May 2022 15:13:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt9kt-0004Rn-EY for xen-devel@lists.xenproject.org; Mon, 23 May 2022 15:13:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7c4cb45-daaa-11ec-837e-e5687231ffcc; Mon, 23 May 2022 17:13:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-fZSaZS9OPjmlM-B40smmjg-1; Mon, 23 May 2022 17:13:47 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8555.eurprd04.prod.outlook.com (2603:10a6:20b:436::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 15:13:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 15:13:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7c4cb45-daaa-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653318837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wAeXhl9rUP7k5yOLCNPBnDbnaRaBQg8ZExaw776RI7k=; b=augNFWIjfqpoFr/Y3NOIES+3q3jeLjc2STOvOopgxSmyLJjNK6ugbIIf8RbHfs2CWu3hR+ GtWb6Bs6+lsSNuOUJtJ8keqHIaiWidGbwoWOxYOgZLGGugwWfBbzRsMM5ibZ8/ZkYWU5zn QwtnEF6G4x7o7TqK8YnVyLtJ6UY0ohM= X-MC-Unique: fZSaZS9OPjmlM-B40smmjg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ghbKid/uU1TnCK0cUdBSeJNdPFfz194pqNNePo8mN/6xK/M5RoTL8p7B4iAyH/C0vRTmHtU42Qod+vx2zrZ3nMLbLeDfGLP73IhwC/W56QmpWRvAMKS3mnYa1tN3gWL1J+RkiPszssn92AvroHyPN098zj0C/cFDhDJO3eLbrGlSQsKWLuOqL4jt/4aHnB76EeY57JSOafapTjskip6MxWupFbs18EMPpeV+I/1OVwpJSQWCl5pRQc+kJxcqXUrlmVqDmxhc+L/CfAQcZbjQ/A006zOI7iVc2YNMnNuaJyf/85LJazvJpdrzwjBKFLWck0b/dFKChlziT6loPdIUcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7TXJmOV+99O6agW/06WIbgw5UHvtfY8m2zwF4rajotc=; b=iPYAFPOyafcLhRn15wk8EO4T3LujPS7pbm8wB9biZr4PRNlP27TxGctKR7rKoZ0Sgtc+k9aVQlkyQL6GjYn3EGyAb0FA1X8OkrmmacMR8Kk4M6x4/pQz+LIZQitdrbUfWj2K4JtUeS5tCB1HTBMkeaSmIpA9fan3s0zBlvKuw7tVBpMEpcTzCvWSGfpPjYuHzB879N6WrF7m/OqFDsf+UXgkUWzdGKOJt95h1BxHEdsCzIlJ7nybmRtsMqBfZRVimvGRwREiYqZgKXt8Z3cFpcYIZAdpsFvIns7PTL4rLwbX0njcC23GtAR87DjL+kpbTxUzhc0FXB3ON+SyD6TGDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> Date: Mon, 23 May 2022 17:13:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220516143116.28602-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0134.eurprd06.prod.outlook.com (2603:10a6:20b:467::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68accd37-ccb5-4dc7-c080-08da3cced490 X-MS-TrafficTypeDiagnostic: AM9PR04MB8555:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rlBuPofIgDtovP6TCI144bETJpCpjTC7noVQY5eY32QCX78Drqtt7uJZ63wdP9Y9i8lV1jHgjshKA5F2m1m6pwrT85Yu0MNSSaDhbWzYJyJIwnOMefxQSC1qpKPTWs/LLrnhdc3dswYsuQ7t5o7Mhrot9shjq4mDOSlWETavLiMo9GfsTeC7TAb0c+FdNlG3g6kcB4hgHKVBAyAXIw/RePK5LngsjRG6erWJbnTj0ERZwfsozJHXb5WDVxYuNMlt5wWR3MndtCFCQMxvRGtMIEHLn/61R81wiPeFfBPOtarHqPQ/Do8/1w+dfvpbm6qn5MWIHuURciWLte3iwNqVPbU7UMlq+e4+wHn7dOkt4fqEdWOuQh4IXKGlLLh+AmcfdkRTTJYj+gtxYnWXXSMqRYwNpMH18me4eL/f9UCHYQ619kVz/9Fdf6D70SBo+XQqJrINXsBCc6fmidnEkkUisIbqHchKrodSVzrbE3d/TmwTR19k4smWh7qrY3QWhMOnFc8WwVUj8zr6JaOiPOUVOveWEwe7wL0uIjjclyGrjdTtJryMEhxfOQvgVDAIovtVOXr3Q3mTt6KaqLTZeS0/X2j4XAzBd8UEJYeC+jfUzsEV1OBHfMc0s3io+GEC1qErftxhzK/EzIfTnJebpHh9gFEzfSqrlODV7pvJbhLHY+F+URvJETDUiNYvZHZdACPJ6k4WWkZG2UXp/4siW0Ugrvb6qdfKsp/FGyJAJf5/JAY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(66556008)(66946007)(186003)(53546011)(6506007)(2616005)(6512007)(8676002)(4326008)(316002)(31686004)(6916009)(54906003)(8936002)(83380400001)(5660300002)(26005)(38100700002)(2906002)(6486002)(508600001)(36756003)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fRcjx6vxOg4xxOyNDaAY/D/PcBBVAxzBknAzTBWZXDDojHGiuGSMn4gLqfRx?= =?us-ascii?Q?OxI7PHUP+qL+qsg8e7ntv+nSeLQsg7vpdLq6pwoEywu766DbFoHFyyzbqqox?= =?us-ascii?Q?xUNxJjGe2qQCiCKTlJO4LMpsaJbr8Uc9LyB4WScqIpGDYyUVEpXB75C8ACS7?= =?us-ascii?Q?ZfwaNZdhKfFrtsCSP/rgpW8AjW40ZS1YShamZXLapB57RF3lpsEaks1XHP73?= =?us-ascii?Q?SfdsP3Qg3QZLUU+v/ykqARNeOrbpZg4pP9RPYry/4StTQHZKviGmsVb2d5zk?= =?us-ascii?Q?x/2CXIrze1dq//HEkLc3JkXRRlNnrRgNPyH8uHn9VRnO5Wf/xcoyEj/sdzMt?= =?us-ascii?Q?jplFeBuxm3J+72Gbh1ElL+9qOsYiSuiyvQh4HIQ5AUfuPZ1AWu1/yEw9W8QV?= =?us-ascii?Q?MAkmSsqAX9DgOsOcuzHa+PXJ+tWtk8fAnTEaj1pg0qznb1i74Pk2Scs+8aZc?= =?us-ascii?Q?8dXHgx4q7IrUCsB/wsIyfgxB5oROWO/C3klfPuaabJ43mePQenAqoUax3U0M?= =?us-ascii?Q?2DCIXFGBFgt4f/V2XyLwoXcQ0eWer8izkn1jmYaYmkMk6A2hBi7b1srXPw3P?= =?us-ascii?Q?z/EMLU+WQN5CpnqvAoT/xYSwQ+6EgyvMt8aC3zs0Z0yA2uB8B6aYvczaq4mC?= =?us-ascii?Q?jh/1KM/Ux+Gc0VI4e1Wh9q41N2g5WlS7JpNIuULWUjD098pa3VZi/etL0mwp?= =?us-ascii?Q?3iM1vpV6KMRgG77DtbBq8x5Hy82QX5yjs9Lb8zik5ECGir5154uTPcFp8O5O?= =?us-ascii?Q?ja12Ib+/t7V9OZmZN2GLH+G6YsPzyULiGKEdDSPfbUcv+gbL0HUjpyFaHpGH?= =?us-ascii?Q?YF9Ppa/tcxB30ENtr/Wqv8VnMgV+H94ds2dqhWDt5GF/1U37BhUFQTHXKBHa?= =?us-ascii?Q?VpYceTScpIgEA0LNwfmtpw3RIezpEbRZnkNR1IAIMa/TsB4VTUi/L865+tsi?= =?us-ascii?Q?isLf+9VqoI8OhOxslfo8ypaH8yGxmew0Y8Oq2sbEc/IzkqxrTLitCF7Lw+DA?= =?us-ascii?Q?6wjYmk2mFPI837UoaoFxUbYDQryxiiQnI0aslI5Hopu//kJbzKTG2G8YMgMG?= =?us-ascii?Q?UjYMwGz667CqbTRPI96qfs2NCkhJdQzZL5Wa/z6zRALKXpV4YU+lWcGGi+lU?= =?us-ascii?Q?4j57hsYBF2zokHFlXmtU0M5K0g4g3PDypt4iQYel8u8uSne5h6LoU/TbBDDr?= =?us-ascii?Q?016+MgTWiqbXyXEHcNZ1oPHfgi41fRBM1p/gEkleaphm+r8cQ0Xc3bbzyBxu?= =?us-ascii?Q?hw/tGAzWP0XjauYhW3J7YfuSW5ZtdxUFdNTGz2vOZXcGh3BLq6D9OlRm+A4S?= =?us-ascii?Q?oT6Pdo3lKSAMC4FddP9hHmVW8lonG52QGSp1FhmtJSa6erHjTRXJDrdSHcnV?= =?us-ascii?Q?YjzskZiECMpEU1HHtDFbA9q7r5pV//lnsI3T4qTjABovz33wAqWT3Enpr13O?= =?us-ascii?Q?mhEJFJJHlVPKlDrpFvVvCiGI9cUbw5BwxUaUt3YrjpVkfV6qRVAQIZrtq06x?= =?us-ascii?Q?81q2T9HTRf/4QNWjESTbycqJ3eqPECFBflJZcqaFT2TlWxzLlTnYTwB+u5al?= =?us-ascii?Q?bauoFxrJb08clMc/74WexPP1WEmZpPSnGjCYGEtGLBBsotKET+GRBDQlinsI?= =?us-ascii?Q?vuN69PRvwBGxIOOPEMwk10crzNOeHzitxBsJFp2Cs/Fnab1BDiuylmcpovNE?= =?us-ascii?Q?MOketVctEkO9zVBKOj5MltldXdQoNQlC5WbWzXbEcGWKELD9MyBqpqj6JlmG?= =?us-ascii?Q?svp59e9sIw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68accd37-ccb5-4dc7-c080-08da3cced490 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 15:13:45.5875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3i9xy9/KGSgb9a967JIdN2/D1W5uFgrQ70j+g6siA7K0uiMhEbpuFE+GXxnJXleZSzdXuhhe5/PePAkYchL0Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8555 On 23.05.2022 16:37, Roger Pau Monn=C3=A9 wrote: > On Wed, May 18, 2022 at 10:49:22AM +0200, Jan Beulich wrote: >> On 16.05.2022 16:31, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/flushtlb.h >>> +++ b/xen/arch/x86/include/asm/flushtlb.h >>> @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void = *va, unsigned int flags); >>> #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) >>> =20 >>> /* Flush all CPUs' TLBs/caches */ >>> -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va,= flags) >>> +#define flush_area(va, flags) \ >>> + flush_area_mask(&cpu_online_map, (const void *)(va), flags) >> >> I have to admit that I would prefer if we kept the "_all" name suffix, >> to continue to clearly express the scope of the flush. I'm also not >> really happy to see the cast being added globally now. >=20 > But there where no direct callers of flush_area_all(), so the name was > just relevant for it's use in flush_area(). With that now gone I > don't see a need for a flush_area_all(), as flush_area_mask() is more > appropriate. And flush_area_all() is shorthand for flush_area_mask(&cpu_online_map, ...)= . That's more clearly distinguished from flush_area_local() than simply flush_area(); the latter was okay-ish with its mm.c-only exposure, but imo isn't anymore when put in a header. >>> --- a/xen/arch/x86/smp.c >>> +++ b/xen/arch/x86/smp.c >>> @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const v= oid *va, unsigned int flags) >>> { >>> unsigned int cpu =3D smp_processor_id(); >>> =20 >>> - ASSERT(local_irq_is_enabled()); >>> + /* Local flushes can be performed with interrupts disabled. */ >>> + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cp= u))); >> >> Further down we use cpumask_subset(mask, cpumask_of(cpu)), >> apparently to also cover the case where mask is empty. I think >> you want to do so here as well. >=20 > Hm, yes. I guess that's cheaper than adding an extra: >=20 > if ( cpumask_empty() ) > return; >=20 > check at the start of the function. >=20 >>> if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && >>> cpumask_test_cpu(cpu, mask) ) >> >> I suppose we want a further precaution here: Despite the >> !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to >> extend what c64bf2d2a625 ("x86: make CPU state flush requests >> explicit") and later changes (isolating uses of FLUSH_VCPU_STATE >> from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE >> for the local CPU altogether. >=20 > If we really want to exclude the use of FLUSH_VCPU_STATE for the local > CPU, we might wish to add this as a separate ASSERT, so that such > checking doesn't depend on !local_irq_is_enabled(): >=20 > ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu)); > ASSERT(!cpumask_subset(mask, cpumask_of(cpu)) ||=C2=A0!(flags & FLUSH_VCP= U_STATE)); >=20 >=20 >> That's because if such somehow made >> it into the conditional below here, it would still involve an IPI. >=20 > Sorry, I'm confused by this: if the mask is empty there should be no > IPI involved at all? And we shouldn't even get into the second > conditional on the function. Should perhaps have made more explicit that "somehow" means a hypothetical way, perhaps even as a result of some further breakage somewhere. Jan From xen-devel-bounces@lists.xenproject.org Mon May 23 15:38:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 15:38:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336024.560247 (Exim 4.92) (envelope-from ) id 1ntA8n-0007A0-Cu; Mon, 23 May 2022 15:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336024.560247; Mon, 23 May 2022 15:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntA8n-00079t-9p; Mon, 23 May 2022 15:38:41 +0000 Received: by outflank-mailman (input) for mailman id 336024; Mon, 23 May 2022 15:38:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntA8l-00079n-FU for xen-devel@lists.xenproject.org; Mon, 23 May 2022 15:38:39 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64d9ea18-daae-11ec-837e-e5687231ffcc; Mon, 23 May 2022 17:38:30 +0200 (CEST) Received: from mail-dm3nam07lp2046.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 11:38:27 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5555.namprd03.prod.outlook.com (2603:10b6:208:29b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Mon, 23 May 2022 15:38:25 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.022; Mon, 23 May 2022 15:38:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64d9ea18-daae-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653320316; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0th3acWlvmeJ7eA6A4XDR4zJeEt6USaJWRfKMgTsRxM=; b=I0i2X7GzGwU0mTx5B5Ru+Neulo7RTWDESWE81I+RPfNPP0qlEcLyTUEx fN7dvV+KkczVgnRQ4+9Sy9agZTg6dRxTPQj0yx6LGWb1kdMsmyISPLDru 9POMWTqTlk1qzHfq+VjOG8KmAL0H0UOmqg3dv+iasxlfCf7kNK+IGfJGY 8=; X-IronPort-RemoteIP: 104.47.56.46 X-IronPort-MID: 74477978 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pZlYp64eucWVihihYYfoYgxRtArGchMFZxGqfqrLsTDasY5as4F+v mBOWjrTOviDY2GneogkPIvlpkNXsZLQm4RrQANv/yg0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS+FTYzE/TIid87dCJnSzN6ZrBeyIb+dC3XXcy7lyUqclPK6tA2VgQaGNZd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4MGtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK+fZovDmMnGSd1pDPbf6OfcWpGPlJvU295 Wzsw2/THkgjYYn3JT2ttyjEavX0tSHmXIMfEpWo+/gsh0ecrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwajvHeOsxoYWtxRO+438geAzuzT+QnxLmIJVCJbYdoq8so/XyU31 0ShlsnsQzdotdW9S3iQ67OVpjOaIjUOICkJYipsZRQBy8nupsc0lB2nczp4OKu8j9mwFTSrx TmP9Hc6n+9L0ZBN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLpm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:P101dqEUs6NKD3swpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="74477978" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kzbio585ZMSDylgFkZKq+LfgH8IUk0wt5wfXaCmUpjdyZFaOkK+XZFvB+Id1x7zNr9oQkKAkFa+8Dn09h2C4xWgl3yBNqP3EbzOSolqcpJ2E/o4eVUIHQ/aJGAxHAYlziht91rA5gJwx72im2TQweVtTLvEkIJiRyXZAdlWoF0gY8CRgiRFVm0JFefrYGsPGRAGfYrVR8vSRQXo3HxNRfpYktZI3seIiSVqFPbceEplOCyQRxUE4JIu+6zOuQoG4eyDrK7a5DSaz+qIT4UYZrnPtO5O7I4b+Kk+PX1zYXWYYCMnnfyOwnVpWLBc+tmDiHZ45HAlj87uDNYxkr5rYig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0th3acWlvmeJ7eA6A4XDR4zJeEt6USaJWRfKMgTsRxM=; b=B0O04L5cO+QdAwy+HZw6MbqFDs0NWBQJfFGIHofXgyLozUJW0qNtSvLo3z9X0ID+TVaXEYIJY2dTmiWNucMC6lYdsHwOW/1Qo24fkDckJ6t4hxZLlN0iM3og+SAjjrAL2ccU138KXZdNXS/LKSXZKL4FUxIIn6lGSKIRlGp/Cw0hl9TCrkhxpqAuDPOTR8jT4m8oWJFOpnjeodmZASuL0yBdOt1UskYppaYApfqxrvGUMEyVBGQpuE2L50/HArgTYv4lpqyF0oKoSk2XtMe5SrXspOZMpr2pefLLMUxvxTWT7y+z+TGj3YXQm5WUCH85brcaqWB8c2zqzLxTE8QNoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0th3acWlvmeJ7eA6A4XDR4zJeEt6USaJWRfKMgTsRxM=; b=OUM6zx4aqaHtUGjCBxwJ/kEgDyQjGoMklC15/Kn2TMAjMr07SXL0biR6L6KRRsAz5MxcSrzTT9TKCv/9YjfaOUwd6NdigZgRr+q3Oi6M3Vc31Bt/POtqXmm/h8ItkoDkB6h8cevpJJEjbWt723jZcPkjEUFty5P14uqpISB1zYI= From: Andrew Cooper To: Julien Grall , =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v5 4/6] xen: Switch to byteswap Thread-Index: AQHYbrSoBny5rzyC0E2y+TdaF5bLfK0sjRSAgAALyQA= Date: Mon, 23 May 2022 15:38:24 +0000 Message-ID: References: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> In-Reply-To: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0929dd7a-6b64-4085-c25d-08da3cd24689 x-ms-traffictypediagnostic: BLAPR03MB5555:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yGHbscSnTp8Pp/9Np8bujI2SDOAME3Aa6WdltSkn/G/qKwtcD0KPmds9X+YouvYqNG71pYiKll/Im+iWx/nzUgLSDmoL7nolsrDcbpfU0xScowfRjUdU+2mt8TUiD2GPtAhDPj4FVCJGj9XGJ7QC9bQRMgCiGQv68QpWX8JEMYsfe2Cuh1uWPc5PpmuE5/GzbzjLe0v9c9+u039vPqQGSIGEaa3fhDgVQmeyahpopSEhysFR1BpshBQSEiIgmmqJOllLKjslr82X8RiC7ZaPQyyT6QjSjPKRnoaChSpUWlHNx7cNoTBdCNo/s1ViAWWpc/IL4tpBfg4BDV+MARNkSfJf3eluIVUl9dnYj1DBnZL5fvB/b+QIXZcPurOWAh49FsFHbzw05WcpJSzKQCVJp8iimoPW1DqEj5pfC7eJt5PsolIbACY4zFOgMsbV1SAxTaF0l6sesOLvzCF7PZpBW2Gvuutxo4R6JpylpSQTjGXrqiqttrTDkvP1FmYbvtuWfLkULiTYjiwp809qgUYYbn9gu39hICEtQHPvL7jnjoNZKCjwVReNnZDIMHnaIH4mlhFoi66TJo3xajWpiNbLjrXMUWh/wmR6Jg6PMxK7LRKaH4oHKVEz6G2S01yPtRELPZMdEsH5B8LwxEXxT7fj/7U3pZ8E8mN06gyihVLpIR7EFxYoc4QrKxb58llm1C3bO03CXhtRjgeEoS/uSDZ8hyHsRyggykjfLGXcVFkOG9EiDvbBrGQ5TLKaPaPz+e2ZzBKLurNrHm3u9v3COMexUQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(6512007)(54906003)(110136005)(186003)(6506007)(2616005)(53546011)(26005)(31686004)(508600001)(6486002)(36756003)(76116006)(83380400001)(316002)(2906002)(8936002)(4744005)(5660300002)(66446008)(64756008)(66946007)(66556008)(8676002)(4326008)(66476007)(91956017)(82960400001)(38070700005)(31696002)(86362001)(38100700002)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S0tRMmQyRE9za3NMWW9nblYvQ01rUi9XWTRqbHhzSjE2ODlGS3RoZTNiZ0pa?= =?utf-8?B?WjZpTSt0M0xseDBYc0NvMkxRbjMrbk1UWk5Ja3dkdmF5eUxlYVdVczV1Y2o5?= =?utf-8?B?S2NERVVUNE8rTlpOc05UYU85ZklVWEtGdkdGdmg3NXBXOXRNQ1VsR1Y0T2Uz?= =?utf-8?B?QisydkxTL2VrNk9ERlF2bmdQQ0ZCZkdBMXRxN1pFbmhlQ0V3UzlZbjMyTCtE?= =?utf-8?B?cEI0Z0NnZEpzN3d6OWtwN1ZubTRVV1hIdzBmNDNtL0x3US9MSVJMbVc0MUkz?= =?utf-8?B?Rmx3Q3dNUUJjN1ZUU0txUjJxQ3ZPYklFV3ZtZ3B5bHR5NmN0dE9ka1Y0dDRa?= =?utf-8?B?Q2J0enpmcks3dkJ4YUlHUTdDNTB1WG16b0tJQVNWOGRsOUIzeWFDK3VZS0Vx?= =?utf-8?B?MXpqNTdDNEllaDVoVmx6R2VBWVU4c0s5cGc4aVA1dVdOL2tKUTlVNWFYb28z?= =?utf-8?B?cmkyZ0xWbkRSaER5VjFXblFDdmZ4eHVwdUxPKzBVT09BN3lGVTZ1djM2dnBW?= =?utf-8?B?Q3o5MDRQM1B3WkNESGxaejEycVdlTkVuODU3SjRxRzBpZnVSLzBBc294c2VJ?= =?utf-8?B?UFJOTEErOWdLTk9DV3ExT0Z5b0ZhMGRkM1krejFGYlIwdGt0MjhlUk1PVUJW?= =?utf-8?B?YUgzUi9jemVCczBzR1ZIT0szTHZUT0s3NzJCeEZjQmlOM1RycVF6T3d1SGs4?= =?utf-8?B?Skg5RjlZNzh0VzF4VGNzdjVHM2hYeUh0endoRWZNMjUrOWdYUmRydjA1U0VQ?= =?utf-8?B?YTdzL2NZZG9qZkRGYzc3SW1zS2pSMnRVTThkN3RaRHd5dUpsYXJWRVdXUmUw?= =?utf-8?B?UGgyUk5Lc2gzc3ZmNGVqUWVyTnNEZEwwUDcwdXdmMWpiNFIxem51eXFlUXoz?= =?utf-8?B?RDJrN3lsSXJvUk1tOW1PMFBUb1VkQXBzYWhSZDRyWE1XbXlOeWk0aHViRERW?= =?utf-8?B?ZmVraEgxeEVFTVdHdVplUHNMWWsxSjd1Ui9qZ1lpSGdiaGgzZzV6R3dqVmxP?= =?utf-8?B?b2lIdUg0NmRqMEhQQzRHU2JEVkxiZnRZTlFwU3pDOFgyeWxwUUFsQXFBNUFG?= =?utf-8?B?SjJoM2E1U3pXTU5BdXRZYWtYM1hPNXp5NWlyWmc3UWpic3dPWTc3WFAvUkdv?= =?utf-8?B?QnVHNFVNbTF0NWJ2RjZJeEpodnZONnVGemFuanpzd0V6V3NHZDRXZTNWdUpG?= =?utf-8?B?WnUwRUhSYjdxNnlBc3E4TVQ0em9sM2NGSEVFY21VeDREWERsbjRGcGhPdm5w?= =?utf-8?B?dDk2KzVxVnpjS2c0YU9FSzVjeFloYmhwQkVhMEU5UWk3RHZRYzBuV2tyK2lG?= =?utf-8?B?WVBqRi82dE5XdGh1K0pHTnFlbGNDYUxxWjZacjZBTEt1aXN3VC8zY3g5RjNW?= =?utf-8?B?aVorWVJjeDZJdUpKb1R1MTNyd293L2d5dUxWNGwxRzNDSVBlVFhsSnhLK05j?= =?utf-8?B?NU1xRXV2Y21ZRFVDNitTUDJsZXdsWDhpeVZCZGZEdUgzZUd0Q3pZbThqYzZS?= =?utf-8?B?MWs1ZHh2aU00Wk1HREdka285c3pPeFJJbmhqYm9NMWFUZFRucnlNWkNsdno1?= =?utf-8?B?UVdPWk5HQXoxbDA0dzA0Nkp0U0lXZG01RkUxQjNHVGc1SDdWdy9XeFVRdEcv?= =?utf-8?B?UjFDNmwySVdZdmx4V3BoaHM2NWRldVpGb0Rrdk9YOVhISG5yaHVSR3k5WHJU?= =?utf-8?B?Q1Fya1RraUpnZjBCRzJsc1BRa2tIQmJzSGRvdnpDRHlDbi9XWkYvRXIrTE1X?= =?utf-8?B?YW1aaXhYbG1nVWZucHJyazZGaUlFU2ptaUprWnUrN2JCTW4xMmpGM2thL0Va?= =?utf-8?B?N2hRWURZT1NFNXQyNFBwUy9EdHN1K3pwK2pBWHBFTVhrK3E1Q2Z1TWNReDgz?= =?utf-8?B?aisrOXJyQXg5MjQ1SzV5NC9OSWl2UC9aTnRWZ280TzFOYkpKM2wwMHlvQ3lD?= =?utf-8?B?c29FOGtiQlZxL2pEa2ZGWWEybFpCVmZUUEt1RWkwY0pZOUloUTY5RGhwWW1Y?= =?utf-8?B?eWNMSWhrNnVzODBuRG95THBRQW9EcDNzNlduMHBHQkFjTUNVU0Y4VURYeGcr?= =?utf-8?B?N1lPenpNTml6ckx5SmhZbUlzYVdkNE5QQjRLS2REVlBjVUIrcWszeG1oRUVS?= =?utf-8?B?b3NDNGh1WHl6c0lsM214ZFE3eTFoUXlFNXlPd3ZBRzRhc0dvUzlQVFJXcVJv?= =?utf-8?B?SGpmOGNiVmN0d0RPb05MZDVQZG13WWpuWW9ZS0wwWE1TTW54M05XWFdGODJF?= =?utf-8?B?dzBvV1Erc2tGWllMMXU5UTd2bElKRXBxenFTSzQrVzVXWVg0blRZb043Y0dn?= =?utf-8?B?VXpGYU9UVUl6aktQeStsZzBTWi8zMUowQmI0TzQ1bTIzR3pjSUY0bDdLOWp1?= =?utf-8?Q?7E69buyc4WNZaPJI=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0929dd7a-6b64-4085-c25d-08da3cd24689 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 15:38:24.9797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JKSFL4nLgvO/g/KIFBmbJwq+eKxWxyYIWvk+JCQizWDgJPvnF8+9rov4NWzpLU642nYrpZAeHlmjESzdppfqXx3KkMhJOoKD9WNwnYE8UZk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5555 T24gMjMvMDUvMjAyMiAxNTo1NiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g MjMvMDUvMjAyMiAxNTo1MCwgTGluIExpdSB3cm90ZToNCj4+IFVwZGF0ZSB0byB1c2UgYnl0ZXN3 YXAgdG8gc3dhcCBieXRlcw0KPj4gYmUqX3RvX2NwdXAocCkgaXMgc2hvcnQgZm9yIGJlKnRvX2Nw dSgqcCksIHVwZGF0ZSB0byB1c2UgbGF0dGVyDQo+PiBvbmUgZXhwbGljdGx5DQo+DQo+IEJ1dCB3 aHk/DQoNCkJlY2F1c2UgZGVsZXRpbmcgY29kZSBvYmZ1c2NhdGlvbiBjb25zdHJ1Y3RzICppcyog dGhlIHBvaW50IG9mIHRoZSBjbGVhbnVwLg0KDQo+IEkgcmVhbGx5IGRvbid0IGhhdmUgYSBzdWdn ZXN0aW9uIG9uIHRoZSBjb21tZW50IGJlY2F1c2UgSSBkaXNhZ3JlZQ0KPiAoYW5kIEFGQUlDVCBK YW4gYXMgd2VsbCkgd2l0aCB0aGUgYXBwcm9hY2guDQoNCkRyb3BwaW5nIHRoZSBvYmZ1c2NhdGlv biBoYXMgdW5jb3ZlcmVkIHByZS1leGlzdGluZyBidWdzIGluIHRoZQ0KaHlwZXJ2aXNvci7CoCBU aGUgc2VyaWVzIHN0YW5kcyBvbiBpdHMgb3duIG1lcml0Lg0KDQpXaGlsZSBJIGNhbid0IGhlbHAg aWYgeW91IGxpa2UgaXQgb3Igbm90LCBpdCByZWFsbHkgZG9lcyBicmluZyBhbg0KaW1wcm92ZW1l bnQgdG8gY29kZSBxdWFsaXR5IGFuZCBsZWdpYmlsaXR5Lg0KDQpJZiB5b3UgaGF2ZSBubyB0ZWNo bmljYWwgb2JqZWN0aW9ucywgYW5kIG5vIHN1Z2dlc3Rpb25zIGZvciBob3cgdG8gZG8gaXQNCmRp ZmZlcmVudGx5IHdoaWxlIHJldGFpbmluZyB0aGUgcXVhbGl0eSBhbmQgbGVnaWJpbGl0eSBpbXBy b3ZlbWVudHMsDQp0aGVuICJJIGRvbid0IGxpa2UgaXQiIGRvZXNuJ3QgYmxvY2sgaXQgZ29pbmcg aW4uDQoNCkkgc3BlY2lmaWNhbGx5IGRvIGxpa2UgdGhpcyBjaGFuZ2UsIGJlY2F1c2UgaXQgZG9l cyBpbXByb3ZlIHRoZSBjb2RlYmFzZS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon May 23 16:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 16:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336029.560259 (Exim 4.92) (envelope-from ) id 1ntAYb-0002Yo-Fw; Mon, 23 May 2022 16:05:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336029.560259; Mon, 23 May 2022 16:05:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntAYb-0002Yh-DB; Mon, 23 May 2022 16:05:21 +0000 Received: by outflank-mailman (input) for mailman id 336029; Mon, 23 May 2022 16:05:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntAYa-0002YI-7r for xen-devel@lists.xenproject.org; Mon, 23 May 2022 16:05:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntAYZ-0003Cc-SJ; Mon, 23 May 2022 16:05:19 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntAYZ-0006dd-Lk; Mon, 23 May 2022 16:05:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KbkzlDtxUkKxdwqqoTjcWACsHCE88PfRN4/a2QFirhE=; b=FUe9tIaEOPl1EUFucYst88dcxf cOUUmrU/miN7iy6nuU5S0QKLGTKc+ExCzalI89Ep3ZOQdKtkSaldOZfYycJKBjdbbOODSyVCd32rR BWd/BfMjyUto1gwT0Ptdo6oHc9Uc+POoHjMrdHXJlWore67MhBZrx+XHzYiJn6J/jvI8=; Message-ID: <1c7342ed-63af-e420-4f3a-938cb93021c7@xen.org> Date: Mon, 23 May 2022 17:05:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 4/6] xen: Switch to byteswap To: Andrew Cooper , =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , George Dunlap , Jan Beulich , Wei Liu References: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 23/05/2022 16:38, Andrew Cooper wrote: > On 23/05/2022 15:56, Julien Grall wrote: >> Hi, >> >> On 23/05/2022 15:50, Lin Liu wrote: >>> Update to use byteswap to swap bytes >>> be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter >>> one explictly >> >> But why? > > Because deleting code obfuscation constructs *is* the point of the cleanup. > >> I really don't have a suggestion on the comment because I disagree >> (and AFAICT Jan as well) with the approach. > > Dropping the obfuscation has uncovered pre-existing bugs in the > hypervisor.  The series stands on its own merit. I am guessing you mean that we don't handle unaligned access? If so, yes I agree this helped with that. > > While I can't help if you like it or not, it really does bring an > improvement to code quality and legibility. > > If you have no technical objections, and no suggestions for how to do it > differently while retaining the quality and legibility improvements, > then "I don't like it" doesn't block it going in. And you don't like the existing code :). I am willing to compromise, but for that I need to understand why the existing code is technically not correct. So far, all the arguments you provided in v3 was either a matter of taste or IMHO bogus. Your taste is nor better nor worse than mine. At which, we need someone else to break the tie. If I am not mistaken, Jan is also objecting on the proposal. At which point, we are 2 vs 1. So there are three choices here: 1) You find two others maintainers (including on Arm maintainer) to agree with you 2) You provide arguments that will sway one of us in your side 3) We keep be32_cpu*() (they are simple wrapper and I am willing to write the code). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 17:02:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 17:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336035.560270 (Exim 4.92) (envelope-from ) id 1ntBRn-0000DF-St; Mon, 23 May 2022 17:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336035.560270; Mon, 23 May 2022 17:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBRn-0000D8-Pb; Mon, 23 May 2022 17:02:23 +0000 Received: by outflank-mailman (input) for mailman id 336035; Mon, 23 May 2022 17:02:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBRm-0000Cy-TS; Mon, 23 May 2022 17:02:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBRm-0004BR-SL; Mon, 23 May 2022 17:02:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBRm-0008De-Gt; Mon, 23 May 2022 17:02:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntBRm-00010z-GN; Mon, 23 May 2022 17:02:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HLBbMI0tZqvZfWBqzwQ6mdhyOkjc36tc32qTJLrvq0c=; b=6HUulds+vQ6goOHMGTgLeAdsKw 38kUjKuS8me106sIZ4HGRJB9m9E8QXBa/b5nOkw3yIDIoBZGqq3TzJB68VyhHbQUAfoZBa5Yg2YtU gaPGKef16ZYx6y2oXyipnwK+f3Xyzrqh47JY1SRYPbxXOxaMI54hcfnrm9H6xhyT0t5U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170706: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 17:02:22 +0000 flight 170706 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170706/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1192 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 80 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 17:30:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 17:30:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336042.560281 (Exim 4.92) (envelope-from ) id 1ntBsv-0003VP-8e; Mon, 23 May 2022 17:30:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336042.560281; Mon, 23 May 2022 17:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBsv-0003VI-4c; Mon, 23 May 2022 17:30:25 +0000 Received: by outflank-mailman (input) for mailman id 336042; Mon, 23 May 2022 17:30:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntBsu-0003VC-DB for xen-devel@lists.xenproject.org; Mon, 23 May 2022 17:30:24 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 068a3799-dabe-11ec-bd2c-47488cf2e6aa; Mon, 23 May 2022 19:30:23 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id i23so18055981ljb.4 for ; Mon, 23 May 2022 10:30:23 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id f11-20020a05651232cb00b004786243ab08sm1229661lfg.108.2022.05.23.10.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 10:30:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 068a3799-dabe-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=mPzl0IxVpOBD7BXqIA/dVHyw+aKjOBb3ATUZ7spN2qg=; b=YBXi34/97S1J6MVRP9bjFSy6nwf8akZPAOC/SZxPbaoEJt38sG+LmdKjzh08RriLXa /82hF+iabCGUoXkCr++jGmyKd2eu0EPfZuPLmIYT2uuXAE1b2qAPOVGDak/cGhL4fEjO W4MPf0p9X1zgwnrLxftV+Tzaxe6/boss5X1KQb5kPEawpyIt6kV100rXzWTZveBjJutc wwFm+vv8k1hjJztqFZhroiNW32+bzO04NNPPf6PlnO8Z7YvGXEx3+RnfTBTFsaE0aTVf hjech1zrcYaDw6PSWg8f9wOaMmC4Qn28WLbCEyYpLmkNv0YwawmXEPOS1JUsFnuEqS14 hz2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mPzl0IxVpOBD7BXqIA/dVHyw+aKjOBb3ATUZ7spN2qg=; b=gC01Nix32hiTFyQIcj68/8m8k2goNjwDb8xHqQLzVchYtqL//nZu03dQy4TP4eXwnS 7tj4JUoyCj2tjH580Fj29Jce3y73YJ+KzqoPgomhu39zMzRibLwaTIF5+0wHFFXkeBal MUFtxuyW2Dq4rwKdVTG7tQrC0ObF7rSjcY/ZzKBka0wQrV0zGhxhcgDP75knvoYg0IQa Clz6bvKSxo7P1X55P0d3XMoc1ucFhwPbV7xDOrTFKPj6ijc/MofN8G7VZBpfGL4cLBZj m557RG/dr7TklngORbymcyufLB9QtR9tk4J6091TpGmZ0WIoSQMNTIoTcaW8CRBfDqW1 5BLg== X-Gm-Message-State: AOAM532yEYJYIxqJLvRD/BuB/3pbQdNeiFOH6kpFxJ42Fw1Eh+e76vv6 kcHW+H7je7AlQaaTGs4q52w= X-Google-Smtp-Source: ABdhPJzwZfozEnQDt+CrjQ7uTvPbLWypALeKVlqUmFxBKfIWsyPw8Alci4bEMHh/m6nHITXZtcC2TA== X-Received: by 2002:a2e:7a0d:0:b0:253:decb:be0f with SMTP id v13-20020a2e7a0d000000b00253decbbe0fmr9414809ljc.525.1653327022433; Mon, 23 May 2022 10:30:22 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops From: Oleksandr To: Stefano Stabellini , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM Cc: Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> Message-ID: <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> Date: Mon, 23 May 2022 20:30:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 19.05.22 09:03, Oleksandr wrote: Hello Stefano, all > > On 19.05.22 04:06, Stefano Stabellini wrote: > > > Hello Stefano, all > >> On Thu, 19 May 2022, Oleksandr wrote: >>>> On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: >>>>> On 18.05.22 17:32, Arnd Bergmann wrote: >>>>>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko >>>>>> wrote: >>>>>>     This would mean having a device >>>>>> node for the grant-table mechanism that can be referred to using the >>>>>> 'iommus' >>>>>> phandle property, with the domid as an additional argument. >>>>> I assume, you are speaking about something like the following? >>>>> >>>>> >>>>> xen_dummy_iommu { >>>>>       compatible = "xen,dummy-iommu"; >>>>>       #iommu-cells = <1>; >>>>> }; >>>>> >>>>> virtio@3000 { >>>>>       compatible = "virtio,mmio"; >>>>>       reg = <0x3000 0x100>; >>>>>       interrupts = <41>; >>>>> >>>>>       /* The device is located in Xen domain with ID 1 */ >>>>>       iommus = <&xen_dummy_iommu 1>; >>>>> }; >>>> Right, that's that's the idea, >>> thank you for the confirmation >>> >>> >>> >>>>    except I would not call it a 'dummy'. >>>>   From the perspective of the DT, this behaves just like an IOMMU, >>>> even if the exact mechanism is different from most hardware IOMMU >>>> implementations. >>> well, agree >>> >>> >>>>>> It does not quite fit the model that Linux currently uses for >>>>>> iommus, >>>>>> as that has an allocator for dma_addr_t space >>>>> yes (# 3/7 adds grant-table based allocator) >>>>> >>>>> >>>>>> , but it would think it's >>>>>> conceptually close enough that it makes sense for the binding. >>>>> Interesting idea. I am wondering, do we need an extra actions for >>>>> this >>>>> to work in Linux guest (dummy IOMMU driver, etc)? >>>> It depends on how closely the guest implementation can be made to >>>> resemble a normal iommu. If you do allocate dma_addr_t addresses, >>>> it may actually be close enough that you can just turn the grant-table >>>> code into a normal iommu driver and change nothing else. >>> Unfortunately, I failed to find a way how use grant references at the >>> iommu_ops level (I mean to fully pretend that we are an IOMMU >>> driver). I am >>> not too familiar with that, so what is written below might be wrong >>> or at >>> least not precise. >>> >>> The normal IOMMU driver in Linux doesn’t allocate DMA addresses by >>> itself, it >>> just maps (IOVA-PA) what was requested to be mapped by the upper >>> layer. The >>> DMA address allocation is done by the upper layer (DMA-IOMMU which >>> is the glue >>> layer between DMA API and IOMMU API allocates IOVA for PA?). But, >>> all what we >>> need here is just to allocate our specific grant-table based DMA >>> addresses >>> (DMA address = grant reference + offset in the page), so let’s say >>> we need an >>> entity to take a physical address as parameter and return a DMA >>> address (what >>> actually commit #3/7 is doing), and that’s all. So working at the >>> dma_ops >>> layer we get exactly what we need, with the minimal changes to guest >>> infrastructure. In our case the Xen itself acts as an IOMMU. >>> >>> Assuming that we want to reuse the IOMMU infrastructure somehow for >>> our needs. >>> I think, in that case we will likely need to introduce a new >>> specific IOVA >>> allocator (alongside with a generic one) to be hooked up by the >>> DMA-IOMMU >>> layer if we run on top of Xen. But, even having the specific IOVA >>> allocator to >>> return what we indeed need (DMA address = grant reference + offset >>> in the >>> page) we will still need the specific minimal required IOMMU driver >>> to be >>> present in the system anyway in order to track the mappings(?) and >>> do nothing >>> with them, returning a success (this specific IOMMU driver should >>> have all >>> mandatory callbacks implemented). >>> >>> I completely agree, it would be really nice to reuse generic IOMMU >>> bindings >>> rather than introducing Xen specific property if what we are trying to >>> implement in current patch series fits in the usage of "iommus" in >>> Linux >>> more-less. But, if we will have to add more complexity/more >>> components to the >>> code for the sake of reusing device tree binding, this raises a >>> question >>> whether that’s worthwhile. >>> >>> Or I really missed something? >> I think Arnd was primarily suggesting to reuse the IOMMU Device Tree >> bindings, not necessarily the IOMMU drivers framework in Linux (although >> that would be an added bonus.) >> >> I know from previous discussions with you that making the grant table >> fit in the existing IOMMU drivers model is difficult, but just reusing >> the Device Tree bindings seems feasible? > > I started experimenting with that. As wrote in a separate email, I got > a deferred probe timeout, > > after inserting required nodes into guest device tree, which seems to > be a consequence of the unavailability of IOMMU, I will continue to > investigate this question. I have experimented with that. Yes, just reusing the Device Tree bindings is technically feasible (and we are able to do this by only touching grant-dma-ops.c), although deferred probe timeout still stands (as there is no IOMMU driver being present actually). [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ignoring dependency [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks (2.10 GB/1.95 GiB) Below the working diff (on top of current series): diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c index da9c7ff..6586152 100644 --- a/drivers/xen/grant-dma-ops.c +++ b/drivers/xen/grant-dma-ops.c @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = {  bool xen_is_grant_dma_device(struct device *dev)  { +       struct device_node *iommu_np; +       bool has_iommu; +         /* XXX Handle only DT devices for now */         if (!dev->of_node)                 return false; -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, "xen,grant-dma"); +       of_node_put(iommu_np); + +       return has_iommu;  }  void xen_grant_setup_dma_ops(struct device *dev)  {         struct xen_grant_dma_data *data; -       uint32_t domid; +       struct of_phandle_args iommu_spec;         data = find_xen_grant_dma_data(dev);         if (data) { @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev)         if (!dev->of_node)                 goto err; -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", &domid)) { -               dev_err(dev, "xen,backend-domid property is not present\n"); +       if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", +                       0, &iommu_spec)) { +               dev_err(dev, "Cannot parse iommus property\n"); +               goto err; +       } + +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || +                       iommu_spec.args_count != 1) { +               dev_err(dev, "Incompatible IOMMU node\n"); +               of_node_put(iommu_spec.np);                 goto err;         } +       of_node_put(iommu_spec.np); +         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);         if (!data)                 goto err; -       data->backend_domid = domid; +       /* +        * The endpoint ID here means the ID of the domain where the corresponding +        * backend is running +        */ +       data->backend_domid = iommu_spec.args[0];         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,                         GFP_KERNEL))) { (END) Below, the nodes generated by Xen toolstack:         xen_grant_dma {                 compatible = "xen,grant-dma";                 #iommu-cells = <0x01>;                 phandle = <0xfde9>;         };         virtio@2000000 {                 compatible = "virtio,mmio";                 reg = <0x00 0x2000000 0x00 0x200>;                 interrupts = <0x00 0x01 0xf01>;                 interrupt-parent = <0xfde8>;                 dma-coherent;                 iommus = <0xfde9 0x01>;         }; I am wondering, would be the proper solution to eliminate deferred probe timeout issue in our particular case (without introducing an extra IOMMU driver)? > > > > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Mon May 23 17:36:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 17:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336045.560292 (Exim 4.92) (envelope-from ) id 1ntByr-0004Hp-4W; Mon, 23 May 2022 17:36:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336045.560292; Mon, 23 May 2022 17:36:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntByr-0004Hi-1N; Mon, 23 May 2022 17:36:33 +0000 Received: by outflank-mailman (input) for mailman id 336045; Mon, 23 May 2022 17:36:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntByq-0004HY-1h; Mon, 23 May 2022 17:36:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntByp-0004j7-VT; Mon, 23 May 2022 17:36:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntByp-0000V3-E9; Mon, 23 May 2022 17:36:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntByp-0003dv-Dh; Mon, 23 May 2022 17:36:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZUDmqQAs8tAvnGlX8MF5h7FPgjSmw4OlTnvLWL/LFhw=; b=4L5Oj+HLBVbbjOgDYGOQKeKq5Z fLJz6/H4OhvbS6XQezkujLkzN5naZBFAmNxwsCRnNEnZks0xH0VLScSUEuFJmJoo9wtQdMs8Kdnm0 V+vWsMKLiNcZj6VOkd1j8Qd5m3mre+F2Eif2q4LxKwYBCPx9hR7EHf+CLzVRw4oD4ubg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170708: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 17:36:31 +0000 flight 170708 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170708/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1193 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 81 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 18:08:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 18:08:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336052.560305 (Exim 4.92) (envelope-from ) id 1ntCTj-0007nW-Li; Mon, 23 May 2022 18:08:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336052.560305; Mon, 23 May 2022 18:08:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntCTj-0007nP-Iw; Mon, 23 May 2022 18:08:27 +0000 Received: by outflank-mailman (input) for mailman id 336052; Mon, 23 May 2022 18:08:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntCTh-0007n9-QM; Mon, 23 May 2022 18:08:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntCTh-0005Jg-PY; Mon, 23 May 2022 18:08:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntCTh-0001GR-Dp; Mon, 23 May 2022 18:08:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntCTh-0006R9-DO; Mon, 23 May 2022 18:08:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0ESnUK4+Ww8GUGBcV0s1I+sZQWE+voaI8Ydr5c5ff5w=; b=16fnz+tcSMahlAUvLPVxXxwmIi pGIbDkDwk918So0CQNdp6tG7YxnVJdT2jl97btDxhk/zYOsQdeuZI+El4xuDnvxidygx3vyoLBfc/ sjU+13gM1898QEzSXfXhWi/5HJjgWvGl/nq+hrLvqFdE5s9vZBK9oRIk9M/ynLS3GLgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170709: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 18:08:25 +0000 flight 170709 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170709/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 168254 build-i386 6 xen-build fail REGR. vs. 168254 build-i386-xsm 6 xen-build fail REGR. vs. 168254 build-amd64-xsm 6 xen-build fail REGR. vs. 168254 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1194 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 82 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 6968 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 23 19:46:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 19:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336060.560317 (Exim 4.92) (envelope-from ) id 1ntE0l-0000k3-Pm; Mon, 23 May 2022 19:46:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336060.560317; Mon, 23 May 2022 19:46:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE0l-0000jw-Kv; Mon, 23 May 2022 19:46:39 +0000 Received: by outflank-mailman (input) for mailman id 336060; Mon, 23 May 2022 19:46:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE0k-0000jq-D5 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 19:46:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE0k-00077F-0d; Mon, 23 May 2022 19:46:38 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntE0j-0007yJ-Ob; Mon, 23 May 2022 19:46:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=rjASqJUHRe0yAa+O5gTpo5HUVHFXyOJL+EcFbD9hG5M=; b=l/5uqy CvDDAnvApNCvjgAFcbXvVZDfXUI0okKqWj04ApfusK/GS6naW1oMl/rsw4TyefjAWGhwGvI3nYQKl 2IV4R8QNbnFZhbpDOZg8FK57bqpjVn79SkzH363ob8nIeAMuzhyTkja0R/BdKY4u9NGarqfOnwzww re5pN/y93uY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: michal.orzel@arm.com, Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: setup: nr_banks should be unsigned int Date: Mon, 23 May 2022 20:46:31 +0100 Message-Id: <20220523194631.66262-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is not possible to have a negative number of banks. So switch to unsigned int. The type change is also propagated to any users of nr_banks that were using "int" (there are not that many). Note that fdt_num_mem_rsv() can actually returns a negative value in case of an error. So the return should be checked before assigning the result to an unsigned variable. Signed-off-by: Julien Grall --- xen/arch/arm/domain_build.c | 9 +++++---- xen/arch/arm/efi/efi-dom0.c | 4 ++-- xen/arch/arm/include/asm/setup.h | 6 +++--- xen/arch/arm/setup.c | 17 +++++++++++++---- 4 files changed, 23 insertions(+), 13 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index aa777741bdd0..6ecb6673a3cd 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -111,7 +111,8 @@ static bool __init insert_11_bank(struct domain *d, struct page_info *pg, unsigned int order) { - int res, i; + unsigned int i; + int res; mfn_t smfn; paddr_t start, size; @@ -264,7 +265,7 @@ static void __init allocate_memory_11(struct domain *d, const unsigned int min_order = get_order_from_bytes(MB(4)); struct page_info *pg; unsigned int order = get_allocation_size(kinfo->unassigned_mem); - int i; + unsigned int i; bool lowmem = true; unsigned int lowmem_bitsize = min(32U, arch_get_dma_bitsize()); @@ -1022,8 +1023,8 @@ static int __init make_memory_node(const struct domain *d, int addrcells, int sizecells, struct meminfo *mem) { - int res, i; - int reg_size = addrcells + sizecells; + unsigned int i; + int res, reg_size = addrcells + sizecells; int nr_cells = 0; /* Placeholder for memory@ + a 64-bit number + \0 */ char buf[24]; diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c index 494420eaa23e..aae0f979112a 100644 --- a/xen/arch/arm/efi/efi-dom0.c +++ b/xen/arch/arm/efi/efi-dom0.c @@ -34,14 +34,14 @@ /* Constant to indicate "Xen" in unicode u16 format */ static const CHAR16 xen_efi_fw_vendor[] = {0x0058, 0x0065, 0x006E, 0x0000}; -size_t __init estimate_efi_size(int mem_nr_banks) +size_t __init estimate_efi_size(unsigned int mem_nr_banks) { size_t size; size_t est_size = sizeof(EFI_SYSTEM_TABLE); size_t ect_size = sizeof(EFI_CONFIGURATION_TABLE); size_t emd_size = sizeof(EFI_MEMORY_DESCRIPTOR); size_t fw_vendor_size = sizeof(xen_efi_fw_vendor); - int acpi_mem_nr_banks = 0; + unsigned int acpi_mem_nr_banks = 0; if ( !acpi_disabled ) acpi_mem_nr_banks = bootinfo.acpi.nr_banks; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 7a1e1d67989c..2bb01ecfa88f 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -30,7 +30,7 @@ struct membank { }; struct meminfo { - int nr_banks; + unsigned int nr_banks; struct membank bank[NR_MEM_BANKS]; }; @@ -93,7 +93,7 @@ extern domid_t max_init_domid; void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); -size_t estimate_efi_size(int mem_nr_banks); +size_t estimate_efi_size(unsigned int mem_nr_banks); void acpi_create_efi_system_table(struct domain *d, struct membank tbl_add[]); @@ -109,7 +109,7 @@ void create_dom0(void); void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, - void (*cb)(paddr_t, paddr_t), int first); + void (*cb)(paddr_t, paddr_t), unsigned int first); size_t boot_fdt_info(const void *fdt, paddr_t paddr); const char *boot_fdt_cmdline(const void *fdt); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index db1768c03f03..b30bccbaa7df 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -201,9 +201,17 @@ static void __init processor_id(void) static void __init dt_unreserved_regions(paddr_t s, paddr_t e, void (*cb)(paddr_t, paddr_t), - int first) + unsigned int first) { - int i, nr = fdt_num_mem_rsv(device_tree_flattened); + unsigned int i, nr; + int rc; + + rc = fdt_num_mem_rsv(device_tree_flattened); + if ( rc < 0 ) + panic("Unable to retrieve the number of reserved regions (rc=%d)\n", + rc); + + nr = rc; for ( i = first; i < nr ; i++ ) { @@ -249,7 +257,8 @@ static void __init dt_unreserved_regions(paddr_t s, paddr_t e, } void __init fw_unreserved_regions(paddr_t s, paddr_t e, - void (*cb)(paddr_t, paddr_t), int first) + void (*cb)(paddr_t, paddr_t), + unsigned int first) { if ( acpi_disabled ) dt_unreserved_regions(s, e, cb, first); @@ -693,7 +702,7 @@ static void __init setup_mm(void) paddr_t ram_start, ram_end, ram_size, e; unsigned long ram_pages; unsigned long heap_pages, xenheap_pages, domheap_pages; - int i; + unsigned int i; const uint32_t ctr = READ_CP32(CTR); if ( !bootinfo.mem.nr_banks ) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 19:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 19:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336065.560328 (Exim 4.92) (envelope-from ) id 1ntE3z-0001LW-8O; Mon, 23 May 2022 19:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336065.560328; Mon, 23 May 2022 19:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE3z-0001LP-5S; Mon, 23 May 2022 19:49:59 +0000 Received: by outflank-mailman (input) for mailman id 336065; Mon, 23 May 2022 19:49:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE3x-0001LH-G9 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 19:49:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE3w-00079t-Sy; Mon, 23 May 2022 19:49:56 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntE3w-000898-Kk; Mon, 23 May 2022 19:49:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=ZNEcq2NxMdfHEm/PUmR8yWlF5yI6apHFA8EExXukUo0=; b=XlM/M3 jkOGf/sPWDFgnHitzi1ej4KgQwwtMqC0urhQJsUEvggbI4F4WfduSZHsquE2TB/51jLsnkBv819fv ko3GA76S6C+3+vVlDXvFqYw3GaIi3O5IGov1dipcwLvwGCeqS2UTS359XT8cXWmoMhZ9D2xzMGSef Jx2YR5oe5N0=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Date: Mon, 23 May 2022 20:49:53 +0100 Message-Id: <20220523194953.70636-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, *_VIRT_END may either point to the address after the end or the last address of the region. The lack of consistency make quite difficult to reason with them. Furthermore, there is a risk of overflow in the case where the address points past to the end. I am not aware of any cases, so this is only a latent bug. Start to solve the problem by removing all the *_VIRT_END exclusively used by the Arm code and add *_VIRT_SIZE when it is not present. Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE for better consistency and use _AT(vaddr_t, ). Signed-off-by: Julien Grall ---- I noticed that a few functions in Xen expect [start, end[. This is risky as we may end up with end < start if the region is defined right at the top of the address space. I haven't yet tackle this issue. But I would at least like to get rid of *_VIRT_END. --- xen/arch/arm/include/asm/config.h | 18 ++++++++---------- xen/arch/arm/livepatch.c | 2 +- xen/arch/arm/mm.c | 13 ++++++++----- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 3e2a55a91058..66db618b34e7 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -111,12 +111,11 @@ #define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) #define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) -#define BOOT_FDT_SLOT_SIZE MB(4) -#define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE) +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) #ifdef CONFIG_LIVEPATCH #define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) -#define LIVEPATCH_VMAP_END (LIVEPATCH_VMAP_START + MB(2)) +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) #endif #define HYPERVISOR_VIRT_START XEN_VIRT_START @@ -132,18 +131,18 @@ #define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) #define VMAP_VIRT_START _AT(vaddr_t,0x10000000) +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) #define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) -#define XENHEAP_VIRT_END _AT(vaddr_t,0x7fffffff) -#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) -#define DOMHEAP_VIRT_END _AT(vaddr_t,0xffffffff) +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) -#define VMAP_VIRT_END XENHEAP_VIRT_START +#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) #define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ /* Number of domheap pagetable pages required at the second level (2MB mappings) */ -#define DOMHEAP_SECOND_PAGES ((DOMHEAP_VIRT_END - DOMHEAP_VIRT_START + 1) >> FIRST_SHIFT) +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) #else /* ARM_64 */ @@ -152,12 +151,11 @@ #define SLOT0_ENTRY_SIZE SLOT0(1) #define VMAP_VIRT_START GB(1) -#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1)) +#define VMAP_VIRT_SIZE GB(1) #define FRAMETABLE_VIRT_START GB(32) #define FRAMETABLE_SIZE GB(32) #define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) -#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) #define DIRECTMAP_VIRT_START SLOT0(256) #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c index 75e8adcfd6a1..57abc746e60b 100644 --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -175,7 +175,7 @@ void __init arch_livepatch_init(void) void *start, *end; start = (void *)LIVEPATCH_VMAP_START; - end = (void *)LIVEPATCH_VMAP_END; + end = start + LIVEPATCH_VMAP_SIZE; vm_init_type(VMAP_XEN, start, end); diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index be37176a4725..0607c65f95cd 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -128,9 +128,11 @@ static DEFINE_PAGE_TABLE(xen_first); /* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ static DEFINE_PER_CPU(lpae_t *, xen_pgtable); #define THIS_CPU_PGTABLE this_cpu(xen_pgtable) -/* xen_dommap == pages used by map_domain_page, these pages contain +/* + * xen_dommap == pages used by map_domain_page, these pages contain * the second level pagetables which map the domheap region - * DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */ + * starting at DOMHEAP_VIRT_START in 2MB chunks. + */ static DEFINE_PER_CPU(lpae_t *, xen_dommap); /* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ static DEFINE_PAGE_TABLE(cpu0_pgtable); @@ -476,7 +478,7 @@ mfn_t domain_page_map_to_mfn(const void *ptr) int slot = (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; unsigned long offset = (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; - if ( va >= VMAP_VIRT_START && va < VMAP_VIRT_END ) + if ( (va >= VMAP_VIRT_START) && ((VMAP_VIRT_START - va) < VMAP_VIRT_SIZE) ) return virt_to_mfn(va); ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); @@ -570,7 +572,8 @@ void __init remove_early_mappings(void) int rc; /* destroy the _PAGE_BLOCK mapping */ - rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END, + rc = modify_xen_mappings(BOOT_FDT_VIRT_START, + BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, _PAGE_BLOCK); BUG_ON(rc); } @@ -850,7 +853,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) void *__init arch_vmap_virt_end(void) { - return (void *)VMAP_VIRT_END; + return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); } /* -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Mon May 23 19:51:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 19:51:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336070.560339 (Exim 4.92) (envelope-from ) id 1ntE5L-0002kr-NP; Mon, 23 May 2022 19:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336070.560339; Mon, 23 May 2022 19:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE5L-0002kk-K8; Mon, 23 May 2022 19:51:23 +0000 Received: by outflank-mailman (input) for mailman id 336070; Mon, 23 May 2022 19:51:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE5K-0002kK-HB for xen-devel@lists.xenproject.org; Mon, 23 May 2022 19:51:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntE5K-0007Cl-6M; Mon, 23 May 2022 19:51:22 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntE5K-0008BN-01; Mon, 23 May 2022 19:51:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3xvucrrkCcZAhvNjpP2wC+OQkX4sm9SUeF55V65PEuY=; b=2e6qTLSLGjPgC+hnfxd/WanEK9 6gJ7iPQgfPuKnNfJd+U66ijBYutOyJ4XdigBhg/UX6y0zC39gTLgXdo9/zekWzCmfQIWCVbvum7NS GuAb46DDO9okK6t30KMIO3laT0XG8wccYSbYROWrXFmWix5WgbRjC26AgLothNFmkcao=; Message-ID: Date: Mon, 23 May 2022 20:51:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-14-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/05/2022 08:28, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 20.05.2022 14:09, Julien Grall wrote: >> From: Julien Grall >> >> In a follow-up patch, we will want to populate the boot allocator >> separately for arm64. The code will end up to be very similar to the one >> on arm32. So move out the code in a new helper populate_boot_allocator(). >> >> For now the code is still protected by CONFIG_ARM_32 to avoid any build >> failure on arm64. >> >> Take the opportunity to replace mfn_add(xen_mfn_start, xenheap_pages) with >> xenheap_mfn_end as they are equivalent. >> >> Signed-off-by: Julien Grall >> >> --- >> >> Changes in v4: >> - Patch added >> --- >> xen/arch/arm/setup.c | 90 +++++++++++++++++++++++++------------------- >> 1 file changed, 51 insertions(+), 39 deletions(-) >> >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index d5d0792ed48a..3d5a2283d4ef 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -637,10 +637,58 @@ static void __init init_staticmem_pages(void) >> } >> >> #ifdef CONFIG_ARM_32 >> +/* >> + * Populate the boot allocator. All the RAM but the following regions >> + * will be added: >> + * - Modules (e.g., Xen, Kernel) >> + * - Reserved regions >> + * - Xenheap >> + */ >> +static void __init populate_boot_allocator(void) >> +{ >> + unsigned int i; > Shouldn't this be an int (as it was previously) because ... >> + const struct meminfo *banks = &bootinfo.mem; >> + >> + for ( i = 0; i < banks->nr_banks; i++ ) > ... nr_banks is int ? Hmmm... AFAIK banks->nr_banks never hold a negative value, so I am not sure why it was introduced as an "int". Looking through the code, we seem to have a mix of "unsigned int" and "int". There seem to be less on the latter, so I have sent a patch to switch nr_banks to "unsigned int" [1]. This is based on this series thought and I would like to keep the "unsigned int" here. > > Apart from that: > Reviewed-by: Michal Orzel Thanks! Please let me know if this reviewed-by hold. Cheers, [1] https://lore.kernel.org/xen-devel/20220523194631.66262-1-julien@xen.org -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 20:00:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 20:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336077.560350 (Exim 4.92) (envelope-from ) id 1ntEEN-0004Mg-JF; Mon, 23 May 2022 20:00:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336077.560350; Mon, 23 May 2022 20:00:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEEN-0004MZ-Fv; Mon, 23 May 2022 20:00:43 +0000 Received: by outflank-mailman (input) for mailman id 336077; Mon, 23 May 2022 20:00:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEEM-0004MT-64 for xen-devel@lists.xenproject.org; Mon, 23 May 2022 20:00:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEEL-0007SA-Ol; Mon, 23 May 2022 20:00:41 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntEEL-0000Sk-Hq; Mon, 23 May 2022 20:00:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wRY8tqA1hCi8XCRT4NmiiUUUX/HPYmvPuBsmr1ycrnk=; b=wKrPjBNHgNHZgPetjAwdsTPAZo kDA3cjmNIPE/3elbgCY3gAL5jeSbwNkKvgIY5ENiVcp8dLeWSGWFYxukOu4Ydb8R6lOxoiJfTs2Xr WD48jJbdpHQ/emMrLg5CeD/RnO5Hp2ytEV03VVnfkAA/dGF48lsZYidZdz2xRx1L9PFw=; Message-ID: <3236e8e6-c25d-1733-9315-e0363cc73f84@xen.org> Date: Mon, 23 May 2022 21:00:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/05/2022 11:21, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 23.05.2022 12:05, Julien Grall wrote: >> Hi, >> >> On 23/05/2022 10:13, Michal Orzel wrote: >>> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >>> the number of CPUs to activate. >> >> The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. >> >> Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. >> >> >> So what's your use-case/target? >> > - use cases where we have no big little (although even on big.LITTLE limiting this number makes sense if we do not care about the types) This may make sense in debug build, but for prod I think you need some certainty how which CPUs you are going to use. So I would like a warning in the documentation "maxcpus" that in big.LITTLE system, there are no guarantee on which types will be used. This is technically a lie, but I don't want a user to start relying on how Xen will parse the DT. > - debug cases where we want to set maxcpus=1 Thanks for the clarification. I would be happy to add my tag with a warning in the documentation. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 20:01:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 20:01:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336082.560361 (Exim 4.92) (envelope-from ) id 1ntEFN-0004y1-Sp; Mon, 23 May 2022 20:01:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336082.560361; Mon, 23 May 2022 20:01:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEFN-0004xu-PN; Mon, 23 May 2022 20:01:45 +0000 Received: by outflank-mailman (input) for mailman id 336082; Mon, 23 May 2022 20:01:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEFM-0004xo-ST for xen-devel@lists.xenproject.org; Mon, 23 May 2022 20:01:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntEFM-0007Sx-Lu; Mon, 23 May 2022 20:01:44 +0000 Received: from [54.239.6.190] (helo=[192.168.27.218]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntEFM-0000UT-GV; Mon, 23 May 2022 20:01:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Wg9acVRVFvLwk0Cib3XG4OodNOG67zsICariUlF4cUE=; b=EwO1dPt4gG9RvoIl6jvjGtlZt4 PG+e+4g3Exh+gUgKQuNVSsvud4Hfjjds2UgdMw63D/dE9dJWbJfItCF/9D5w84cGiFcQF4HlL9PAV f2+vX3ygdByJE1yzXgodR7nyMdW5HwUfc+4DeY9cMmwi6/uEPzc+gMIuI5SM9SdSSE4s=; Message-ID: Date: Mon, 23 May 2022 21:01:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini References: <20220522165900.83104-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/05/2022 08:00, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 22.05.2022 18:59, Julien Grall wrote: >> From: Julien Grall >> >> xsm_deasign_dtdevice() will indicate whether the caller is allowed > s/deasign/deassign/ Good spot! I will fix it on commit unless there are any objections. > >> to issue the operation. So the return value has to be checked. >> >> Spotted by clang static analyzer. >> >> Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") >> Signed-off-by: Julien Grall > > Apart from that: > Reviewed-by: Michal Orzel Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 23 20:10:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 23 May 2022 20:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336086.560372 (Exim 4.92) (envelope-from ) id 1ntENI-0005g9-Mo; Mon, 23 May 2022 20:09:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336086.560372; Mon, 23 May 2022 20:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntENI-0005g2-Jl; Mon, 23 May 2022 20:09:56 +0000 Received: by outflank-mailman (input) for mailman id 336086; Mon, 23 May 2022 20:09:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntENG-0005fs-Uu; Mon, 23 May 2022 20:09:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntENG-0007Zl-SO; Mon, 23 May 2022 20:09:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntENG-00041p-Al; Mon, 23 May 2022 20:09:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntENG-0003qk-AH; Mon, 23 May 2022 20:09:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=43RbAhRGkg4V4qm/wDSzj53iH3zDFhjnRqJeEAW/UCQ=; b=a5MtEB9V4bp7F3PrsqmlPg8lPQ keCiBYDjLllOXqLR7Qd9puhAEGAp3Xo9GU1BsYcCl9XLaXTzYnN+JdI4W0PuHym+tZyVvF13o737h tG67TiJ5RQDGICTUgUH+yz7pByUeGceBM6ytv1e/d7DL98OOyYZ08TI7HqjnVtZHvQhA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170710: all pass - PUSHED X-Osstest-Versions-This: ovmf=a21a3438f795deecb24e1843c1636f95c485017c X-Osstest-Versions-That: ovmf=b1b89f9009f2390652e0061bd7b24fc40732bc70 From: osstest service owner Date: Mon, 23 May 2022 20:09:54 +0000 flight 170710 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170710/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a21a3438f795deecb24e1843c1636f95c485017c baseline version: ovmf b1b89f9009f2390652e0061bd7b24fc40732bc70 Last test of basis 168254 2022-02-28 10:41:46 Z 84 days Failing since 168258 2022-03-01 01:55:31 Z 83 days 1195 attempts Testing same since 170593 2022-05-20 06:42:41 Z 3 days 83 attempts ------------------------------------------------------------ People who touched revisions under test: Abdul Lateef Attar Abdul Lateef Attar via groups.io Abner Chang Akihiko Odaki Anthony PERARD Bandaru, Purna Chandra Rao Bo Chang Ke Bob Feng Chao Li Chao, Zhuoran Chen Lin Z Chen, Christine Chen, Lin Z Corvin Köhne Dandan Bi dann frazier Dun Tan duntan Feng, Bob C Gerd Hoffmann Gua Guo Guo Dong Guomin Jiang Hao A Wu Heng Luo Hua Ma Huang, Li-Xia Jagadeesh Ujja Jake Garver Jake Garver via groups.io Jason Jason Lou Jiewen Yao Ke, Bo-ChangX Ken Lautner Kenneth Lautner Kun Qin Kuo, Ted Laszlo Ersek Lean Sheng Tan Leif Lindholm Li, Yi1 Li, Zhihao Liming Gao Liu Liu Yun Liu Yun Y Liu, Zhiguang Lixia Huang Lou, Yun Ma, Hua Mara Sophie Grosch Mara Sophie Grosch via groups.io Matt DeVillier Michael D Kinney Michael Kubacki Michael Kubacki Min M Xu Min Xu Oliver Steffen Patrick Rudolph Peter Grehan Purna Chandra Rao Bandaru Ray Ni Rebecca Cran Rebecca Cran Sami Mujawar Sean Rhodes Sean Rhodes sean@starlabs.systems Sebastien Boeuf Sunny Wang Tan, Dun Ted Kuo Tom Lendacky Wenyi Xie wenyi,xie via groups.io Xiaolu.Jiang Xie, Yuanhao Yi Li yi1 li Yu Pu Yuanhao Xie Yuwei Chen Zhiguang Liu Zhihao Li Zhuoran Chao jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b1b89f9009..a21a3438f7 a21a3438f795deecb24e1843c1636f95c485017c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 24 01:07:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 01:07:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336093.560383 (Exim 4.92) (envelope-from ) id 1ntJ1D-0007rb-Mt; Tue, 24 May 2022 01:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336093.560383; Tue, 24 May 2022 01:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntJ1D-0007rU-JG; Tue, 24 May 2022 01:07:27 +0000 Received: by outflank-mailman (input) for mailman id 336093; Tue, 24 May 2022 01:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntJ1C-0007r5-0W for xen-devel@lists.xenproject.org; Tue, 24 May 2022 01:07:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ddd19dcf-dafd-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 03:07:24 +0200 (CEST) Received: from AS9PR06CA0067.eurprd06.prod.outlook.com (2603:10a6:20b:464::26) by VI1PR08MB5439.eurprd08.prod.outlook.com (2603:10a6:803:13b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 24 May 2022 01:07:18 +0000 Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::19) by AS9PR06CA0067.outlook.office365.com (2603:10a6:20b:464::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 01:07:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 01:07:17 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Tue, 24 May 2022 01:07:17 +0000 Received: from 88e382616667.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 91DD7381-2227-449F-A968-F84F68140F39.1; Tue, 24 May 2022 01:07:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 88e382616667.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 01:07:08 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB4327.eurprd08.prod.outlook.com (2603:10a6:20b:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 01:07:04 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Tue, 24 May 2022 01:07:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddd19dcf-dafd-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RGtmHxPrpVmv1a5V+RKyWVhLtf4STmBHvBO1sPRvHKgaWxtbWz3TZ9Ka7aG6SQ22g9jok2tebX3pWPqS/9NZei61O1apyVv2LSx9YB8fK+lxboYFNGU9kU3T4gCFk/enPG7Q+l2wavn7Agtd68aNarampI+UX1Z6VU38eTGpzxMqp2ZG4G4w7oLD4e9DKll+pVqfjOV8oeygKzmFTbqybne1iut0Igb5leog8I6DNMxC/BEhhdW+ycdoa9SuHFC9FsTzmfuLGpg16vOMVCJKn5QMOSnecWYjQzid/8fxe01gTAtwJ++pgb3kvH7HbJvTQU26CfnS9lFI/9QSzxhlHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LYzxOUjOLbqe1e4CwOaHvw457RqSw57OYffXqwCDFb4=; b=Q5ljafge0kBYeifk8TkJKrB0DBDMzFs1NlHxW+BllHAqOsY/d9ogh9xhMeSh0q6S13k5Hz2ZuPsx+qqzG3LYs9wsrce2eVAr42CsxF1Ynz93NsbvRflig0xhzvJxATjOm8YwapLLbfchlzNi8MfhB1T5O8RejS8XyVWPlMO0ykRN1Vtptu1z8OevdEE53iA3SuMczywdEmcwoM0bysEsG8kjWwyndReo0/DQKKQa7nBmrWYP46DmamcDbpQhssOjIZVYzRtD/UsB9u0U0VAMLBGcEhEG9J08QCKG1OL6TA0yj6TZGFrqhV6Q/GgGksFyKH5zbzf2zP6uOyE20KHHEQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYzxOUjOLbqe1e4CwOaHvw457RqSw57OYffXqwCDFb4=; b=SDHDhFaezGcH4SNFNq/sSWL0eQPbFehtRG7AA6r8vTixvt5OvidkNUXocvVKrbC/Zdnvqg+ZdUE/l/diCivb2qdVtaCtbL0xO5Kgkf/AsJ+zfll27bVwh91WFdpoDLqt9bWjS70qsseX1ZOuxqzdLpM05YjmnZJMbRvia9+fuLg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql51eOi3LOrcdG9m/9zbJz0YfV+sKUY0dcxrk+ifIEuUzPLUmAkGm/lT8bTJufe2W9aiZ8kOyU9PAFK6+R08QdZmrZklrQTZPYqFk5avguYZo2KUUaVO0NFQl8Ht9FHmRjIbPpUDGAhoCmOIUb2m7de6i2+//dUSD6MT/bblk3eu7nAJaMg+vzsp4JWr1qqTV+KKo2gZQalWDgNb2XtH4++DfAPp2+Ykp2oof13nB3h6WGMpDcoiGxwjGFO2SwjSC4NatkCJR0nyn0PXVjXzjgwd7pATC8zblQ2QoGu/CBMMaA7oKrmDFcvDawclRCKa1Pequ2pje381UE80zzOX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LYzxOUjOLbqe1e4CwOaHvw457RqSw57OYffXqwCDFb4=; b=B17AUycGTJQ7F3y4gvu8bzVeSvnMHNYcYLMMn6AQFY8zRCorNapCV9PPTkPQqFxpdTu8qTQlKlvib1Hswv3ECy/09RAIJRjwkJG0P6Idhg54ruq3HmToWdYt4PKAwQERtdCbiG4AGowHuINCS6NIEkOnc5IvQHHZq0dXzJreJNLiyoaKIrU9byLGAzyilPCy4lI/bBMbmxCc1IpTN94bBQ3IpXsTt5u62iX8XZ2yFrKeBIiBtl21AuTPi+/SaWijq/PqNfl0Ck4OYkW6+ikvtlTmFDNV08rbkL6AVRQciLOha3e0odWfDjWPxolSwES/Sjq9tGV3zf41hGYJpSsy4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYzxOUjOLbqe1e4CwOaHvw457RqSw57OYffXqwCDFb4=; b=SDHDhFaezGcH4SNFNq/sSWL0eQPbFehtRG7AA6r8vTixvt5OvidkNUXocvVKrbC/Zdnvqg+ZdUE/l/diCivb2qdVtaCtbL0xO5Kgkf/AsJ+zfll27bVwh91WFdpoDLqt9bWjS70qsseX1ZOuxqzdLpM05YjmnZJMbRvia9+fuLg= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Michal Orzel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH] xen/arm: setup: nr_banks should be unsigned int Thread-Topic: [PATCH] xen/arm: setup: nr_banks should be unsigned int Thread-Index: AQHYbt36sziAOg4NNEauktgt4qmeGq0tNzTA Date: Tue, 24 May 2022 01:07:03 +0000 Message-ID: References: <20220523194631.66262-1-julien@xen.org> In-Reply-To: <20220523194631.66262-1-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9261E93E4A65DD4E8AAB7B79CC5EE8A3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a8319b6e-d137-49fa-1cd8-08da3d21bf67 x-ms-traffictypediagnostic: AM6PR08MB4327:EE_|VE1EUR03FT028:EE_|VI1PR08MB5439:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: w2jEI5eMR6by1kRKsMmOknNfJHlN2NTYRC8aimvtBtQYukrsYGP1sZRI5qxlwJSu+YJYOT/1NHqlm9dQnrle4RlXsg17nz0wtXoEkMoKOjm287HmtmRZQzcNz+TbNDyQhU7lRG2dshyNokcmp4tH4yDH44ZHduGAxwqVsK5V9dDTme0ou4ddrf+3Qfope4EVwmIIfXpjEL8EYVvyVals39mLIXCPndK8BPSCL1pVTzJPznjRVmW1apV/eUaLNSs2yB5lI4jK2sBobf4cqPN9/H9frfd+8nm4xIZGwKCeWfOZ5mcERpcbYeyR0USASCfMekA0aOcESD47beGnpOoVln/L4zhdLp+wCzF4E0/3NawiTgfKVkXgaAhV+gYK1yqjZXDpY5xbtDivbvBGMOk7YA+l4zOm5U0j/0ToIPr2WxoPWWH9Bqipq604NnUqZ3Ys/OJNaHIaX1Lv2Zs2uDtHI+3Ed2eZ/CHYe7Z/awppv73E9G7W1hh/Fn+9giUl/HTeaERHGPlo+BOIsCxn2LB88uBl2LF9b5/FGND7LRoqHVRDcNKIbhCxI6WOLSy1L+Y0uC5iqi+SjuATMM4+8ncEx+SQQiHC2A3480Z5HDfxJn+DTafuLk9Ve8h7hSccATWaIp2GEmLzU3qnC5GqcZ6OSwN3SIevvGn/TWT3tEMBVvw7NEV9IqAWMtojSinBf58EUSmV269ebNFv5NhVhrHCTA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66476007)(110136005)(66446008)(38070700005)(64756008)(66556008)(2906002)(316002)(33656002)(83380400001)(76116006)(54906003)(8676002)(66946007)(4326008)(71200400001)(122000001)(38100700002)(6506007)(186003)(53546011)(508600001)(7696005)(5660300002)(8936002)(52536014)(55016003)(26005)(9686003)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4327 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c339136a-b4ab-4871-02a7-08da3d21b6ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zRNiVGthbBrSCYDAz/r1dgIjoBwUHomylQMaWexwd+dCmUk/sweFQIsbi7vj4hvscps1xv9MsUR/yPrjDNT+V9dQifFQNvQs7sLMn2b3XVM0Q7BgQY7HPuPmoLJwD1EGXCuMrKUX7zPprcCzzdgzWsnJssVQ5aL/PPbx5JVETWsRFWEPIkKKrYHU+kqkouXObtLypNElI+UKBKy6AcHtKTXtxisnqHLjRt+6Kfr3O9RjMUXUXiTifVaqYoRw8TtYG+VgjRkiHDlLcCUwr4mTYULwLnGgUWJmUL63rH2U+EXC62hBT3XhqEgZjGsfSCIVdsQyckbRrj7+79DEIWJY4XU1raVXZh12ttunVoRWxwYHVR742uHH+gqOgwOnRYFg3ujz45EKczQkMvPHioNu6+5uOk8h6bdPgpfvAZUOdSACsvWl3rCFOPCY1dOwFnYuiCDDA/2x/AvPksqZISjsjNZkCi1Pvx7xyRSMv85XbLJU+dy0idLnG/OaCS0GhNQnQebMxi/kENuTxjHhRZm8zr4+2KkiuZES2eGSaEc1eEXsV7rJ7dFULSAWopiOG0R1D6WsqXjMYwMeNamS+dTkAIkshs+LR4sHi0zVw2YjVN6FqhtIhRgM8UCvYx1SylckSn69clSaefYnu3+p8p0ScrnXZ4U7a972bY8XD9AINfi2u6X++1H3HBUkiMqgqzkz X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(81166007)(82310400005)(316002)(47076005)(53546011)(54906003)(70586007)(70206006)(186003)(336012)(107886003)(52536014)(356005)(7696005)(8936002)(4326008)(8676002)(33656002)(110136005)(508600001)(9686003)(86362001)(26005)(6506007)(36860700001)(5660300002)(83380400001)(55016003)(2906002)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 01:07:17.9324 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8319b6e-d137-49fa-1cd8-08da3d21bf67 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5439 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhlbi1k ZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBP Zg0KPiBKdWxpZW4gR3JhbGwNCj4gU2VudDogMjAyMsTqNdTCMjTI1SAzOjQ3DQo+IFRvOiB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IE1pY2hhbCBPcnplbCA8TWljaGFsLk9y emVsQGFybS5jb20+OyBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPjsNCj4gU3RlZmFu byBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxp ZW5AeGVuLm9yZz47DQo+IEJlcnRyYW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNv bT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4g U3ViamVjdDogW1BBVENIXSB4ZW4vYXJtOiBzZXR1cDogbnJfYmFua3Mgc2hvdWxkIGJlIHVuc2ln bmVkIGludA0KPiANCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4g DQo+IEl0IGlzIG5vdCBwb3NzaWJsZSB0byBoYXZlIGEgbmVnYXRpdmUgbnVtYmVyIG9mIGJhbmtz LiBTbyBzd2l0Y2gNCj4gdG8gdW5zaWduZWQgaW50Lg0KPiANCj4gVGhlIHR5cGUgY2hhbmdlIGlz IGFsc28gcHJvcGFnYXRlZCB0byBhbnkgdXNlcnMgb2YgbnJfYmFua3MgdGhhdA0KPiB3ZXJlIHVz aW5nICJpbnQiICh0aGVyZSBhcmUgbm90IHRoYXQgbWFueSkuDQo+IA0KPiBOb3RlIHRoYXQgZmR0 X251bV9tZW1fcnN2KCkgY2FuIGFjdHVhbGx5IHJldHVybnMgYSBuZWdhdGl2ZSB2YWx1ZQ0KPiBp biBjYXNlIG9mIGFuIGVycm9yLiBTbyB0aGUgcmV0dXJuIHNob3VsZCBiZSBjaGVja2VkIGJlZm9y ZSBhc3NpZ25pbmcNCj4gdGhlIHJlc3VsdCB0byBhbiB1bnNpZ25lZCB2YXJpYWJsZS4NCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IC0tLQ0K PiAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAgICAgfCAgOSArKysrKy0tLS0NCj4gIHhl bi9hcmNoL2FybS9lZmkvZWZpLWRvbTAuYyAgICAgIHwgIDQgKystLQ0KPiAgeGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL3NldHVwLmggfCAgNiArKystLS0NCj4gIHhlbi9hcmNoL2FybS9zZXR1cC5j ICAgICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKy0tLS0NCj4gIDQgZmlsZXMgY2hhbmdlZCwg MjMgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVu L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ IGluZGV4IGFhNzc3NzQxYmRkMC4uNmVjYjY2NzNhM2NkIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJj aC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j DQo+IEBAIC0xMTEsNyArMTExLDggQEAgc3RhdGljIGJvb2wgX19pbml0IGluc2VydF8xMV9iYW5r KHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c3RydWN0IHBhZ2VfaW5mbyAqcGcsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IG9yZGVyKQ0KPiAgew0KPiAtICAgIGludCByZXMsIGk7DQo+ICsgICAg dW5zaWduZWQgaW50IGk7DQo+ICsgICAgaW50IHJlczsNCj4gICAgICBtZm5fdCBzbWZuOw0KPiAg ICAgIHBhZGRyX3Qgc3RhcnQsIHNpemU7DQo+IA0KPiBAQCAtMjY0LDcgKzI2NSw3IEBAIHN0YXRp YyB2b2lkIF9faW5pdCBhbGxvY2F0ZV9tZW1vcnlfMTEoc3RydWN0IGRvbWFpbiAqZCwNCj4gICAg ICBjb25zdCB1bnNpZ25lZCBpbnQgbWluX29yZGVyID0gZ2V0X29yZGVyX2Zyb21fYnl0ZXMoTUIo NCkpOw0KPiAgICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOw0KPiAgICAgIHVuc2lnbmVkIGludCBv cmRlciA9IGdldF9hbGxvY2F0aW9uX3NpemUoa2luZm8tPnVuYXNzaWduZWRfbWVtKTsNCj4gLSAg ICBpbnQgaTsNCj4gKyAgICB1bnNpZ25lZCBpbnQgaTsNCj4gDQo+ICAgICAgYm9vbCBsb3dtZW0g PSB0cnVlOw0KPiAgICAgIHVuc2lnbmVkIGludCBsb3dtZW1fYml0c2l6ZSA9IG1pbigzMlUsIGFy Y2hfZ2V0X2RtYV9iaXRzaXplKCkpOw0KPiBAQCAtMTAyMiw4ICsxMDIzLDggQEAgc3RhdGljIGlu dCBfX2luaXQgbWFrZV9tZW1vcnlfbm9kZShjb25zdCBzdHJ1Y3QNCj4gZG9tYWluICpkLA0KPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgYWRkcmNlbGxzLCBpbnQgc2l6 ZWNlbGxzLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgbWVt aW5mbyAqbWVtKQ0KPiAgew0KPiAtICAgIGludCByZXMsIGk7DQo+IC0gICAgaW50IHJlZ19zaXpl ID0gYWRkcmNlbGxzICsgc2l6ZWNlbGxzOw0KPiArICAgIHVuc2lnbmVkIGludCBpOw0KPiArICAg IGludCByZXMsIHJlZ19zaXplID0gYWRkcmNlbGxzICsgc2l6ZWNlbGxzOw0KPiAgICAgIGludCBu cl9jZWxscyA9IDA7DQo+ICAgICAgLyogUGxhY2Vob2xkZXIgZm9yIG1lbW9yeUAgKyBhIDY0LWJp dCBudW1iZXIgKyBcMCAqLw0KPiAgICAgIGNoYXIgYnVmWzI0XTsNCj4gZGlmZiAtLWdpdCBhL3hl bi9hcmNoL2FybS9lZmkvZWZpLWRvbTAuYyBiL3hlbi9hcmNoL2FybS9lZmkvZWZpLWRvbTAuYw0K PiBpbmRleCA0OTQ0MjBlYWEyM2UuLmFhZTBmOTc5MTEyYSAxMDA2NDQNCj4gLS0tIGEveGVuL2Fy Y2gvYXJtL2VmaS9lZmktZG9tMC5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9lZmkvZWZpLWRvbTAu Yw0KPiBAQCAtMzQsMTQgKzM0LDE0IEBADQo+ICAvKiBDb25zdGFudCB0byBpbmRpY2F0ZSAiWGVu IiBpbiB1bmljb2RlIHUxNiBmb3JtYXQgKi8NCj4gIHN0YXRpYyBjb25zdCBDSEFSMTYgeGVuX2Vm aV9md192ZW5kb3JbXSA9IHsweDAwNTgsIDB4MDA2NSwgMHgwMDZFLA0KPiAweDAwMDB9Ow0KPiAN Cj4gLXNpemVfdCBfX2luaXQgZXN0aW1hdGVfZWZpX3NpemUoaW50IG1lbV9ucl9iYW5rcykNCj4g K3NpemVfdCBfX2luaXQgZXN0aW1hdGVfZWZpX3NpemUodW5zaWduZWQgaW50IG1lbV9ucl9iYW5r cykNCj4gIHsNCj4gICAgICBzaXplX3Qgc2l6ZTsNCj4gICAgICBzaXplX3QgZXN0X3NpemUgPSBz aXplb2YoRUZJX1NZU1RFTV9UQUJMRSk7DQo+ICAgICAgc2l6ZV90IGVjdF9zaXplID0gc2l6ZW9m KEVGSV9DT05GSUdVUkFUSU9OX1RBQkxFKTsNCj4gICAgICBzaXplX3QgZW1kX3NpemUgPSBzaXpl b2YoRUZJX01FTU9SWV9ERVNDUklQVE9SKTsNCj4gICAgICBzaXplX3QgZndfdmVuZG9yX3NpemUg PSBzaXplb2YoeGVuX2VmaV9md192ZW5kb3IpOw0KPiAtICAgIGludCBhY3BpX21lbV9ucl9iYW5r cyA9IDA7DQo+ICsgICAgdW5zaWduZWQgaW50IGFjcGlfbWVtX25yX2JhbmtzID0gMDsNCj4gDQo+ ICAgICAgaWYgKCAhYWNwaV9kaXNhYmxlZCApDQo+ICAgICAgICAgIGFjcGlfbWVtX25yX2Jhbmtz ID0gYm9vdGluZm8uYWNwaS5ucl9iYW5rczsNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9p bmNsdWRlL2FzbS9zZXR1cC5oDQo+IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3NldHVwLmgN Cj4gaW5kZXggN2ExZTFkNjc5ODljLi4yYmIwMWVjZmE4OGYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRl L2FzbS9zZXR1cC5oDQo+IEBAIC0zMCw3ICszMCw3IEBAIHN0cnVjdCBtZW1iYW5rIHsNCj4gIH07 DQo+IA0KPiAgc3RydWN0IG1lbWluZm8gew0KPiAtICAgIGludCBucl9iYW5rczsNCj4gKyAgICB1 bnNpZ25lZCBpbnQgbnJfYmFua3M7DQo+ICAgICAgc3RydWN0IG1lbWJhbmsgYmFua1tOUl9NRU1f QkFOS1NdOw0KPiAgfTsNCj4gDQo+IEBAIC05Myw3ICs5Myw3IEBAIGV4dGVybiBkb21pZF90IG1h eF9pbml0X2RvbWlkOw0KPiANCj4gIHZvaWQgY29weV9mcm9tX3BhZGRyKHZvaWQgKmRzdCwgcGFk ZHJfdCBwYWRkciwgdW5zaWduZWQgbG9uZyBsZW4pOw0KPiANCj4gLXNpemVfdCBlc3RpbWF0ZV9l Zmlfc2l6ZShpbnQgbWVtX25yX2JhbmtzKTsNCj4gK3NpemVfdCBlc3RpbWF0ZV9lZmlfc2l6ZSh1 bnNpZ25lZCBpbnQgbWVtX25yX2JhbmtzKTsNCj4gDQo+ICB2b2lkIGFjcGlfY3JlYXRlX2VmaV9z eXN0ZW1fdGFibGUoc3RydWN0IGRvbWFpbiAqZCwNCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdHJ1Y3QgbWVtYmFuayB0YmxfYWRkW10pOw0KPiBAQCAtMTA5LDcgKzEwOSw3 IEBAIHZvaWQgY3JlYXRlX2RvbTAodm9pZCk7DQo+IA0KPiAgdm9pZCBkaXNjYXJkX2luaXRpYWxf bW9kdWxlcyh2b2lkKTsNCj4gIHZvaWQgZndfdW5yZXNlcnZlZF9yZWdpb25zKHBhZGRyX3Qgcywg cGFkZHJfdCBlLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAoKmNiKShwYWRk cl90LCBwYWRkcl90KSwgaW50IGZpcnN0KTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg IHZvaWQgKCpjYikocGFkZHJfdCwgcGFkZHJfdCksIHVuc2lnbmVkIGludA0KPiBmaXJzdCk7DQo+ IA0KPiAgc2l6ZV90IGJvb3RfZmR0X2luZm8oY29uc3Qgdm9pZCAqZmR0LCBwYWRkcl90IHBhZGRy KTsNCj4gIGNvbnN0IGNoYXIgKmJvb3RfZmR0X2NtZGxpbmUoY29uc3Qgdm9pZCAqZmR0KTsNCj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zZXR1cC5jIGIveGVuL2FyY2gvYXJtL3NldHVwLmMN Cj4gaW5kZXggZGIxNzY4YzAzZjAzLi5iMzBiY2NiYWE3ZGYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9h cmNoL2FybS9zZXR1cC5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+IEBAIC0yMDEs OSArMjAxLDE3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcm9jZXNzb3JfaWQodm9pZCkNCj4gDQo+ ICBzdGF0aWMgdm9pZCBfX2luaXQgZHRfdW5yZXNlcnZlZF9yZWdpb25zKHBhZGRyX3QgcywgcGFk ZHJfdCBlLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lk ICgqY2IpKHBhZGRyX3QsIHBhZGRyX3QpLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbnQgZmlyc3QpDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmaXJzdCkNCj4gIHsNCj4gLSAgICBpbnQgaSwgbnIg PSBmZHRfbnVtX21lbV9yc3YoZGV2aWNlX3RyZWVfZmxhdHRlbmVkKTsNCj4gKyAgICB1bnNpZ25l ZCBpbnQgaSwgbnI7DQo+ICsgICAgaW50IHJjOw0KPiArDQo+ICsgICAgcmMgPSBmZHRfbnVtX21l bV9yc3YoZGV2aWNlX3RyZWVfZmxhdHRlbmVkKTsNCj4gKyAgICBpZiAoIHJjIDwgMCApDQo+ICsg ICAgICAgIHBhbmljKCJVbmFibGUgdG8gcmV0cmlldmUgdGhlIG51bWJlciBvZiByZXNlcnZlZCBy ZWdpb25zDQo+IChyYz0lZClcbiIsDQo+ICsgICAgICAgICAgICAgIHJjKTsNCj4gKw0KPiArICAg IG5yID0gcmM7DQo+IA0KPiAgICAgIGZvciAoIGkgPSBmaXJzdDsgaSA8IG5yIDsgaSsrICkNCj4g ICAgICB7DQo+IEBAIC0yNDksNyArMjU3LDggQEAgc3RhdGljIHZvaWQgX19pbml0IGR0X3VucmVz ZXJ2ZWRfcmVnaW9ucyhwYWRkcl90IHMsDQo+IHBhZGRyX3QgZSwNCj4gIH0NCj4gDQo+ICB2b2lk IF9faW5pdCBmd191bnJlc2VydmVkX3JlZ2lvbnMocGFkZHJfdCBzLCBwYWRkcl90IGUsDQo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAoKmNiKShwYWRkcl90LCBwYWRk cl90KSwgaW50IGZpcnN0KQ0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZv aWQgKCpjYikocGFkZHJfdCwgcGFkZHJfdCksDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IGZpcnN0KQ0KPiAgew0KPiAgICAgIGlmICggYWNwaV9kaXNh YmxlZCApDQo+ICAgICAgICAgIGR0X3VucmVzZXJ2ZWRfcmVnaW9ucyhzLCBlLCBjYiwgZmlyc3Qp Ow0KPiBAQCAtNjkzLDcgKzcwMiw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9tbSh2b2lk KQ0KPiAgICAgIHBhZGRyX3QgcmFtX3N0YXJ0LCByYW1fZW5kLCByYW1fc2l6ZSwgZTsNCj4gICAg ICB1bnNpZ25lZCBsb25nIHJhbV9wYWdlczsNCj4gICAgICB1bnNpZ25lZCBsb25nIGhlYXBfcGFn ZXMsIHhlbmhlYXBfcGFnZXMsIGRvbWhlYXBfcGFnZXM7DQo+IC0gICAgaW50IGk7DQo+ICsgICAg dW5zaWduZWQgaW50IGk7DQo+ICAgICAgY29uc3QgdWludDMyX3QgY3RyID0gUkVBRF9DUDMyKENU Uik7DQo+IA0KPiAgICAgIGlmICggIWJvb3RpbmZvLm1lbS5ucl9iYW5rcyApDQoNClJldmlld2Vk LWJ5OiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCg0KPiAtLQ0KPiAyLjMyLjANCj4gDQoN Cg== From xen-devel-bounces@lists.xenproject.org Tue May 24 01:36:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 01:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336099.560393 (Exim 4.92) (envelope-from ) id 1ntJT1-0002qS-5U; Tue, 24 May 2022 01:36:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336099.560393; Tue, 24 May 2022 01:36:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntJT1-0002qL-2i; Tue, 24 May 2022 01:36:11 +0000 Received: by outflank-mailman (input) for mailman id 336099; Tue, 24 May 2022 01:36:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntJSz-0002qF-Jd for xen-devel@lists.xenproject.org; Tue, 24 May 2022 01:36:09 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dd1304f7-db01-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 03:36:01 +0200 (CEST) Received: from mail-mw2nam08lp2176.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 21:35:55 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by MN2PR03MB5168.namprd03.prod.outlook.com (2603:10b6:208:1ec::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 01:35:52 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 01:35:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd1304f7-db01-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653356161; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AMjGSYoSDr1II+HY6tjfoYblKWLPY8jO4mHfz7mwE80=; b=dPeNJbABdfp0cqxhKFrOlnNxQGqJHT25gP/5YkmzWPKA5KyXVk0bJcgV YZ0Fdv1diY9SjJ3WeSg3iAKft1fHV3aHzYqXewf95EnayuaxuC+aC9P6k 5gam9J6/UjnpaMNHXsWI2H/oPgEdXRSUkscEOUr0aRmrYQ+SB/9jSTb0R w=; X-IronPort-RemoteIP: 104.47.73.176 X-IronPort-MID: 71861221 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NlnHxK0pNU7maOB8N/bD5Rdwkn2cJEfYwER7XKvMYLTBsI5bp2YFx mJLXT2AbqyONGf1f4x0aIyw8U1SsJLTyIJgGVdvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /0c7KOpbgUlOpf9u7ohFANENS97BKRvreqvzXiX6aR/zmXgWl60n7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+YBfyVu7e03x9p7ixKNfLfY YwdaCdHZxXceRxffFwQDfrSmc/33ymhKmcC8Tp5o4IuuTX351JY+oL2PdXsJ/KWf8AEt2iX8 zeuE2PRR0ty2Mak4TiY9nOhgMffkCW9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN woT4CVGhao97kWvSvH0WhSqp3jCtRkZM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3Oc8SCY2z FaPk5XsDCZ2rbyOYXuH8/GfqjbaERYSKWgOdCoVVzwv6tPooJwwph/XR9MlG6mw5uAZAhn1y jGO6S0h3bMaiJZb073hpA+ZxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTUKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:HfjKi6kAxDeqULwbYbMYQqRkyYLpDfOHimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WBjB8bZYOCAghrkEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIX+rIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLokCs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlawkEyzzYJLiJaYfy/gzdk9vfrWrCV+ O85yvICv4DqE85uFvF5icFlTOQlgrGoEWStGNwyUGT3fARAghKRPapzLgpDSfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE6EbKvNRj+EC3a7FuHoO5bLZvj399AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2HwqT+GLErQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.91,247,1647316800"; d="scan'208";a="71861221" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKU3cwlVJIU6/ww7FWru0X/f1wGqV6qoi8nU/iAWK4FUAsJ/0jfmapWd7GJMztEMcwucZIFEA53xiLK96heR7m5LfRb7DxgWy+7/9cU/dxA2uvA2cu7LjufPKM9MP1xOF501qu1QW4r/VYEdktYZanwS8/tpAi07QBNDP5uc7uc3TUUAXKuQ2onG6cRDLU/sFNPPz1fyFAPkGT9GjBlGiJvFyewqvIV5NEM0wPiZfLk6sghKlLR0v78SlWTUjcXEu5UZG2hKwODskFK9TWbA4sYQB1BV+sqONrmR/ojBjU+TmREJHKDGvFA7e16eD+dKDsABEOt1rDt1hUFBNzviOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMjGSYoSDr1II+HY6tjfoYblKWLPY8jO4mHfz7mwE80=; b=YkHzIeCwJZbc9b5VQkp3Y8QtDFGfMethtOqQOuo0uE03/S/9jK8cIa+ravd5rEwshaWxkEd/LO7BdGHKMw08WnbhJUuOPKQGVN7HqXlIEqRA6mvnK73iokR2kr7DC0CCq/EPJmeqZ4uIncJ6dkxlwYELsnh36TxEipK6jJdrkCjl8bGJVL/q38+FRf+4Qnb0wCoFJqQ9GvS8l12EAeAzugLMjYvQT4ZYDldXLBEKcow1QeMKpZKhDxneX5rjWpNTFHJZhjVwMBiiuu7hRKVlq3IOYPUf3Gmf+thwezJ1gLszzPjkwJ4zhd1g8FtY5SkS13omVx1owjuV93NOy2dN9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMjGSYoSDr1II+HY6tjfoYblKWLPY8jO4mHfz7mwE80=; b=tNshsmzT2EUoBjf8oiQ2z37v8/HYrm4FDubhugfOZJkSlD1mUcgUt1DzeDnXOUgfqy3edMefndZWZzDdqXiOWWR4/sRHxsjPbxf/f2kJXszDcVXaJLBpLpTXgpmPde1wcO6Dgn8trZTJD6LKLw9ZbZZbZLkWTr5SB8+IeUXRJ6g= From: =?utf-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Andrew Cooper , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: =?utf-8?B?5Zue5aSNOiBbUEFUQ0ggdjUgMy82XSBhcm02NC9maW5kX25leHRfYml0OiBS?= =?utf-8?Q?emove_ext2=5Fswab()?= Thread-Topic: [PATCH v5 3/6] arm64/find_next_bit: Remove ext2_swab() Thread-Index: AQHYbrSR+VEcpV6Pq0W55D1/KvsQ560sjFQAgACyefA= Date: Tue, 24 May 2022 01:35:51 +0000 Message-ID: References: <1075e4a2-eb7c-6441-28c4-7dbc871f844d@xen.org> In-Reply-To: <1075e4a2-eb7c-6441-28c4-7dbc871f844d@xen.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f0b6972-a3fe-4171-bad1-08da3d25bcee x-ms-traffictypediagnostic: MN2PR03MB5168:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g7K0VT7h6I5SlBO7ay2y9vQXo/pdfKihGcVJjQ9sKKIy6dm6LiO9l81Ct518vUhS2wPVvJ14XBJFKaZCjFGuaq2ZyGbozlTmW0NgebCB4U/pjxXCQLDzroop9tYAi4hjuS+qJjynGY9WzHTHNZgcFEMWkjx2YpOgYKrrCqNH6XqexUQ+BKmkXBiipEvUXbLRe9C8E7vgn0P6a3wygNDfH1bnGmR5IoQYOon9BtRviCPjcsLJhgbmnYlPLbLn/8M9DCMwEnyylSk7CIPulV3tWPK3fwfDAyZFLVuc2nijudCeNSos/eYSH70mSzyC1+mL50xo8rmt7m71qOAYbnRC3aETSChs9tdB+Oz1OnNfreh2sCbH9fRyKd9XMcK5qYEkOL1M0wpNOvX8p0TA+hytzGAwk/BR07FRTOusYKQYCRQGYMaYo6pegOkFPrAaiD7B8dfiLlXzAJCALfTaLdBaSY1KPbO0f/ILRqzyK9gykuCoUeI7JBNcbJkFnzUBsb59RmV0ja8lKlLgihlVLVcxDLYwcB+rF9EbO3GCHtMxv/2EdXryDv5SX8haXFeBE3xc2f5TTtvyGGH/gae+wA6ZXRFMg4rtaBBT9G1XZ90WY5cKIrRkYiZ+vaX2tizLWezNK1O9VZLaMjeCBbuEVliAskiSZn7+wsaRFdXHGuBCNH3vxXAxYRJZgTXCWLQdsYxrZwVPGptKvzubeIMdGeVpvA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(71200400001)(2906002)(9686003)(26005)(224303003)(110136005)(82960400001)(316002)(85182001)(54906003)(38070700005)(52536014)(186003)(38100700002)(8936002)(4326008)(122000001)(33656002)(55016003)(5660300002)(7696005)(508600001)(4744005)(6506007)(86362001)(83380400001)(64756008)(76116006)(66446008)(66946007)(66476007)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SlUzckRaRDRwRnRSQ3FjR0l6dzBsRk1Ka09vdEtlL2hxblQ2TlU1TGp0MDVO?= =?utf-8?B?QXhDTExwTVZuTGVFRFh2VGxzanNVdEZyYXpsN0tGWjA2dXYvUGt6eE1EYnMy?= =?utf-8?B?UDBKNkJTMHR4SW1iT2JQeWFvbU41UGQ1dHpHdTlHaDYySG9oM0NmQTlzQi9H?= =?utf-8?B?RXJodzlFdlcvdm5WdU90TFcvbTJvRGVyUEx2SmsrUVJ6dUxLcFR2cTI5Vk9v?= =?utf-8?B?YUhVZXd2dCthZG9UeGZhY254TTBxWXpqdzh4TDViYzNSZDVuZk9CYUF0aFpE?= =?utf-8?B?a3RMK1BWZHRPdUFaUXZBZDk3UnFFSmRaZXZUQXI3Yk5GODJDbGdlaVhlS3BX?= =?utf-8?B?VGZyNjhsK0swZExnSmxxZnBUZXp3QjltUlgzUzhmMUUveENGQk0xTWVwRmsr?= =?utf-8?B?RzRjdGlZVnhOM1prakVNZitOMzhHR0R3TWlmTWQwVGw1bW1oM3hNdVZ1NjM4?= =?utf-8?B?WWhjUU50dGNhc1cwUEpXcG00MlNnYlNOQUlsa0JXbTlLWkcxTTlEMHEwN21v?= =?utf-8?B?Q3RYQWNYOTdKRzdpemtEL3IrTGdPb0ZkcEVzQzBXV3B2T3RPem9XWlpaRmkr?= =?utf-8?B?eDY1U2t5REZtM1YyMnovQ2tqckw3SDVKcktxT3RUck5lcmQ1dlNBQkRFbXhT?= =?utf-8?B?akJLMk1zUU9veGF2K091Y1RYWUxjYUQydk8wUnQ3Rkg4UFJkNFBWZVd4U0xN?= =?utf-8?B?aDZxMzRvT1NFTGlwNWhLdnkvcEV0VmxWOU13cjl0NzhsQ0pobWNuRWt2SC93?= =?utf-8?B?UDFRb3EyRWQ1MmlBOXNCWDVTdS9raTlXMDF2WDBPSE1mNzRBaEhIWDZLS2VK?= =?utf-8?B?T3hQdERGcTVCWVRGNHBNM3hXdWhPZnZKSW1lVmN2NWpnNjNUTVNnR2ZQL1Fa?= =?utf-8?B?TmI5c0hlVThuazgvVDZwY0p6OHNZdzJKUWxPZEwyWlNYcU5kYi82UlIyc3Zh?= =?utf-8?B?OTk4azMydkNGZ1JPQ2w0d29wT2pnSGYyaDBmWjkzYjduTDJhUUJkd0ZBQUdU?= =?utf-8?B?NUR6TUhMenhuYmtnd01hMXVFdjVvTnZ0bEFJMlV2R2IvcXpKbmlTcGFhRU1J?= =?utf-8?B?Z014dFV2RTBBQmZ6MG1ENmxQdktkcVZFZnJjdkZJc0ovSU1BN1BTVU5Ibldv?= =?utf-8?B?QXZmSUR1UjhsTU5kWjZPZzJ1VW50SjVPUXcwQ1F4OWhITkN4NFNtVjdnT1No?= =?utf-8?B?OUJUYWZ3eUZESkpGa1Z0TlVqRnk5R1FDNXpzYzFYVDdPcVNDYk9aM2dzU3dk?= =?utf-8?B?N0xYWkhBRXBkRERpd0kvR2FoL05qc0tVcERZbjNHdWEveXhNVWJFUTZGdDAx?= =?utf-8?B?YWtKSXlUWktFUXJHeWh3bkVjVG0ycU5oWmx5N2poSml2ZmhVQjhLaXRiOGNI?= =?utf-8?B?L0pMaXh4ckk1ODhRY2VzZXVYd09DblB1VnFTemU5b1pkSGNLb3JFUmp0NTNa?= =?utf-8?B?bGVJQWJVcFhpcUUrYmpWMG1CVzB0eC9iV1Rib2tOVGl2aHZzK0VvcFROTFUz?= =?utf-8?B?M2w2bGtmcEF2bE44WlhsWFduTHZBOXRhVUJjQkhPdHBvWUIzWjZFMFJHbjF2?= =?utf-8?B?b0NTbVdIT3pDVFh0Umw0K1ByMUdidVNmMStSQnlPdW16MTZpMmpPRDYxZHVE?= =?utf-8?B?RDhQZmFpUWNBOGNIRXBWUjZyL0V4djc1R0lXVGk5Vkt4cGh0cDlyTXVSUTdm?= =?utf-8?B?azRTQjZnUTF0VkI0RVU2NEgyQ2FWdENtUnowZmlremFlRmR0ZEYvS2M0L0VF?= =?utf-8?B?K05PZ2VXa0w1UlQzcnRhVEExZVh3d1ZDVHFBOG5jUi9GUWxWWmFkK0h3dkJI?= =?utf-8?B?ZzF6NExtY0RGUnJLdktSYlQydGllbjllWkVWNEdXN2NUQk1tWEc0cytnZlR0?= =?utf-8?B?OEQwcWNtcjY1MDEwM0x1dDRrLzJwSklSOUtHeWIrcFJqVjBYQWFoZFpMZVJr?= =?utf-8?B?RjJZYUVrdjRiK0RoT25jUkJ1NDUxZXZNSENEVXdOeFdrK2tZUlNFZmxBdExC?= =?utf-8?B?V1pmZUQvQnl2VDIwZGV5aHZDSXlEUzNDNFFzL0UxOVpLdnRnZ1UwdCs1QXBH?= =?utf-8?B?QkM2dktVdEtnYncvYXVwMUh3VW1kWlYwVmRvUmk4cWs5SlR5MElMWGFuYXJ0?= =?utf-8?B?Y3hMSENNSU9yRUlCM0E1RjI5U3dnSTJlazdlL2JmZy9pYXFycm83eG1ZSkNt?= =?utf-8?B?QVhaVEtqTjgyend4UEhYNmUra1dQcmVvTkhCc0NTR2plS3BtZHpNU1B3SDBQ?= =?utf-8?B?cU9yMnBRckFMcTdMdFV2NXl4cDhHR2l3cWRvWHNod2lIaEZ3S3VJaUxoeGxF?= =?utf-8?B?aTI3ZlpYZStHODY0aEQ2SXBxdS9NMXlNZ3h0WFFmQXdQRGtjRkUyUT09?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0b6972-a3fe-4171-bad1-08da3d25bcee X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 01:35:51.8723 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f53xjCusWAB3eFDsMffeDJiNjJh5t30TNbQ4bV31saWQ4R4gKgrd31H5rrOdHq7B5SGYQaG12sMr+tvYfhnEWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5168 DQo+PkhpLA0KDQo+Pk9uIDIzLzA1LzIwMjIgMTU6NTAsIExpbiBMaXUgd3JvdGU6DQo+ID5leHQy IGhhcyBub3RoaW5nIHRvIGRvIHdpdGggdGhpcyBsb2dpYy4NCg0KPllvdSBoYXZlIGFnYWluIG5v dCBhZGRyZXNzZWQgbXkgY29tbWVudC4gSWYgeW91IGRvbid0IHVuZGVyc3RhbmQgbXkgY29tbWVu dCB0aGVuIHBsZWFzZSBhc2suDQoNCj5DaGVlcnMsDQoNCj4tLQ0KPkp1bGllbiBHcmFsbA0KDQpT b3JyeSBJIG1pc3NlZCB0aGlzIG9uZSBhcyBJIHNhdyB0aGlzIHBhdGNoIGFscmVhZHkgZ290IGFu IHNvbWUgdGFncywgIEkgc3VwcG9zZSB5b3VyIGNvbW1lbnQgcmVxdWlyZXMgY29tbWl0IG1lc3Nh Z2UgdXBkYXRlLCANCldpbGwgdXBkYXRlIGl0IGlmIGEgbmV3ZXIgdmVyc2lvbiBpcyByZXF1aXJl ZC4gDQoNCkNoZWVycywNCkxpbg0K From xen-devel-bounces@lists.xenproject.org Tue May 24 02:11:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 02:11:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336106.560404 (Exim 4.92) (envelope-from ) id 1ntK1C-0007Qb-1h; Tue, 24 May 2022 02:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336106.560404; Tue, 24 May 2022 02:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntK1B-0007QU-V2; Tue, 24 May 2022 02:11:29 +0000 Received: by outflank-mailman (input) for mailman id 336106; Tue, 24 May 2022 02:11:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntK1A-0007QO-7h for xen-devel@lists.xenproject.org; Tue, 24 May 2022 02:11:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061c.outbound.protection.outlook.com [2a01:111:f400:fe0c::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf8d07a3-db06-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 04:11:25 +0200 (CEST) Received: from AS9PR06CA0399.eurprd06.prod.outlook.com (2603:10a6:20b:461::12) by GV1PR08MB7988.eurprd08.prod.outlook.com (2603:10a6:150:9c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Tue, 24 May 2022 02:11:19 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::7c) by AS9PR06CA0399.outlook.office365.com (2603:10a6:20b:461::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 02:11:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 02:11:18 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 02:11:18 +0000 Received: from 51f33537193e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 154F6ED0-4A91-4840-93A3-BBE308A154F3.1; Tue, 24 May 2022 02:11:11 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 51f33537193e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 02:11:11 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB3026.eurprd08.prod.outlook.com (2603:10a6:208:65::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 02:11:10 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Tue, 24 May 2022 02:11:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf8d07a3-db06-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O+i2jnSqgdmkpqRO0EnZ7tRe+ZZKk+0EeSyWMqcAznB26xdhKPeUDx8x1tHIdFFgaq+EzeTjU/YHoP54l5ex4ZLSnrshUu8gFs42/BCkWcy1MHz4MjLpo0fNLSKpsj9XadlWcMdfYHOh7NnEDLj7VKeA8x7KLLQW1lNbU8KduFn85Xy62mX8ol29MYeMRVoDUzaAyLRzcWrsxaRjtvvR96IrdKIHEfLv+XPdcoQYnPdc6W83Yh0XJarQ2Joso9PHFmWuOkmMGkpELbnIkT8sd1p7VqLtyEEYFrqmZM0zXmWj8DwJ4HrNpRQwfdR8Pnrm1+Px6TUfGyrjEHE5uCDtSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=we4sp6FJIc8sUnN1oES1diycTTvQaCrLF7fG1CLbc/A=; b=kzwKYR6JPjmlCMAzscoYYkpmqbgHOGYuY4mDl9/Cjf/wua3SYyfQAV23l6K1zHWTwY5HMMRKlIOwj1AlBOGarPEydisMmIVpGzEaOVuO4Z6Na2sZiJ23fq8TyMhHx8kQ8zwTKLdnHNtaOWIBUozcSoHLmmCkAzoobhTNy9w7mpTgMzoTDMfmIlpbC+V+oSeCpyrt0XvnXGwRTDxYZD7ErdLIm6gq3R3yMobReiPb9CgDqs3dX8QuuCYIYaP44wFHEIvz59917cymyFWs690LnWVEoKAT3JVqtRnacK0htDeLJ7g6bnjPW0Uug8ykZiVT/8G0MmXTUZTaGWIxEGUbfw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=we4sp6FJIc8sUnN1oES1diycTTvQaCrLF7fG1CLbc/A=; b=mbHC+V6+IaeTi5sRj0LXeC1CepJyGIohM/Ndye06F2plzl/x6YFDn+MpZuqrWb41eb9JVmnqf9IAzmxqkaVyNdsrQhZ4itBtsLaJPUxS5eBkURYxwIprp2P3TP2KknmpwuBadQEtR8X/nlaWL+9fCCaCr1yUhMEIRezvs57fVtM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 781e0a48dea9fc09 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2jvKRWhbswJII42e3iZvNdzHwiQlRaHQucCbOmRSPaFsGHsBGy8h1eGYoMyqoSqSU5FSilENcWwZlvEQ9hvlLEg5ETfKG7g4j1P9FWGkHF9IO5pmDK7t1oiwDpgUIkKBK9A2H2iNSIOtR9wMIgltRgMdQUUaZFaSpsD4IBcYlJs2Yyeh+E0Py6xL4kM1UH35mBYv7LhrRmoHqPUG8vscVNkRqluKRBGqVKU2Xvgp01Z7dIGIiYlrK68fVs/BNpEjKeImKKjybt6SVChluLL33xf3K4BQGceEJPOInsl96nhapsOkiJpT4iYcY2nAak0grfEFjdXPELxV5F6lqaViQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=we4sp6FJIc8sUnN1oES1diycTTvQaCrLF7fG1CLbc/A=; b=Spu5ewnuEPtrQoWqLuYE9CdPoou7dN8Zsd05OQjRZ68IEQKJEOysLpn3TOGxKcbXLqM24GISTIGKuXxpPgaaAfwrkHg2LDdtoAouK/CvkeHm+XUZEow0mcNz1oBWeoh6FbNN/E9OBWFaQ3GdamJVvmVEsmVT0qUSRY1Xc2vIm2YiLnUld3/XrgCtapdjy0qK4vgMJe42zlVq8bSxVdj7JJkDY/aoKqqE8pG48fTxlQjSRCm0XXhiBJAsXedMIReJlAl1NONMX74DrdGy32KXFXjNAPrEi5WuxQVebIeymgdzr7bTlB68O41usu9BWQVKGTDzYMuFlElJ6abKThzcXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=we4sp6FJIc8sUnN1oES1diycTTvQaCrLF7fG1CLbc/A=; b=mbHC+V6+IaeTi5sRj0LXeC1CepJyGIohM/Ndye06F2plzl/x6YFDn+MpZuqrWb41eb9JVmnqf9IAzmxqkaVyNdsrQhZ4itBtsLaJPUxS5eBkURYxwIprp2P3TP2KknmpwuBadQEtR8X/nlaWL+9fCCaCr1yUhMEIRezvs57fVtM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Tue, 24 May 2022 10:11:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-11-julien@xen.org> From: Wei Chen In-Reply-To: <20220520120937.28925-11-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0157.apcprd01.prod.exchangelabs.com (2603:1096:4:28::13) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8ea0b0c1-e1e6-44fa-06d0-08da3d2ab0a6 X-MS-TrafficTypeDiagnostic: AM0PR08MB3026:EE_|AM5EUR03FT061:EE_|GV1PR08MB7988:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CTzRaM4ks2RTm42pyxKeobhyE6650wHRbD6etlCT4ooU2ni2PnYS821wousq15EgOGfNO+DtkMr+gndOW8abAdRRE8W4fmMzPr7t4QLVRuu03TZS3/9oUworxeH3mC4sBXtpCt5IOHDk5A9SE8CRATnCalKtQDSLEbep73jOh0J5/1gRs4kE0g6OlQwaOS/edMLpCvKXoo4AarTtFzsVYfd5T7nv6BFWcFHxqOiQblZShybjvkJiB8bEiE/6k4f3/w7rAitXLlRSqax1lXQLY7vYRHCF++BQCdgjBk/qfLLbDbdulP4gtpNThKtXTRrhH9ZjJJmsZR39GPOivQa/dzBtilOT555Ih37ZQ2P74HraoxbckqHguB6U1OzZ6SQYn2AEBLbePeqby6HUy2Ol/F4KmjsF38c4tMwVeoHe+xiNbFi9yrDcM/Nel7eDUrlBVHgvJzJWgPC2V0nndHMEZiYO5gav3rVtT8cocfHOeChBS7D25Ujpkh2gs8lC503xW13MO0mgc7NvK/9OESQkXnYrGBvDjZgyJp0wBGzZpEtPFOTX6p0hYXMLSZZA/jy+yzTuYRQhaiBXyByM9+28/I9kiRaRJ5V5iyhFCZOyaknD1smG0QfPCMvRoq+vGvXCKxigP0P5OcXKIaFuaQYl7KyxMdohNXf9uNjQr0xQURSsuNQVaeXlqsC1WU3jzV0hMpYnOmEIb3cB3smK5dzdoMhMSmNEyik0S3mCYxgogV0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(8676002)(26005)(6512007)(8936002)(53546011)(66476007)(316002)(31696002)(66946007)(66556008)(186003)(36756003)(31686004)(86362001)(6506007)(5660300002)(83380400001)(6486002)(2906002)(508600001)(38100700002)(30864003)(7416002)(54906003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3026 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1325f35e-bb63-421d-8855-08da3d2aab4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hk/tcNYhAESXWYb3TlVsx5XSfoYu+8QpISi0XwvoLzG2nRVEZJu/VUHUNHqOD5aa11slQOLAa75hlf1mPqdoIHxKJQ3/7hMO0UCFsqRtVYBr8UqbdcVOZ/yXXfvF7+G4QNqjQGWCKDQuzvWuhWcUfO4fta4jzQHYCQsacjC7kMMIO0DFhypWDn/mpAybjFHQjEpayvpca/gV23Qwj4nLcZKFQ0rjOn/hTp2SHoY25RstZ2pMG2K+tdOGQMET5NbMMN0R+NoGtVQo7V0ka8fymKuabRN5nBn6LyzefIHJUbSEV27geJ2FHuw/M6SVO8L+GLuk7V/csCvqenKN05Vw9y1g7O+BQQChjIob7RlO7/RabpI4FUNFU2YUXX1E7o941GNybbJDuuLgUoUJbqwH5hWXcnYgyEGA+fuONTsv7eggyBUdYv1FF001T9WcqyH4EsFQh36A+nU3b8x2VQdju3mp0avIwn9/2yzVhXUBcnd2OcBoyeryc8gJGiU4l+LBTtqfJuFz035H1eRqSwlESvlzBBnyzykDr/w7FPyT6Y+PWkOs3x8RHcJGFPkQ9IRyc61G/2a2HKTUy1aZhDbeDz3StvExki8ybFAqvOMzHjQfYD7eDgljIKUfGDZBnQT9oBsQWofawytgaey+3hsEOpSfqdxXFEocm/FAh8rg7VoxPE/i5JgnlWBZY/mkSiAg6mNdO/qfciW9NsHW7b6ktA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(31686004)(6506007)(36860700001)(26005)(30864003)(82310400005)(6512007)(31696002)(54906003)(316002)(40460700003)(508600001)(5660300002)(186003)(2616005)(336012)(4326008)(8676002)(53546011)(36756003)(47076005)(86362001)(2906002)(83380400001)(6486002)(70206006)(70586007)(356005)(107886003)(81166007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 02:11:18.7159 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea0b0c1-e1e6-44fa-06d0-08da3d2ab0a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7988 Hi Julien, On 2022/5/20 20:09, Julien Grall wrote: > From: Wei Liu > > The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We > pre-populate all the relevant page tables before the system is fully > set up. > > We will need it on Arm in order to rework the arm64 version of > xenheap_setup_mappings() as we may need to use pages allocated from > the boot allocator before they are effectively mapped. > > This infrastructure is not lock-protected therefore can only be used > before smpboot. After smpboot, map_domain_page() has to be used. > > This is based on the x86 version [1] that was originally implemented > by Wei Liu. > > The PMAP infrastructure is implemented in common code with some > arch helpers to set/clear the page-table entries and convertion > between a fixmap slot to a virtual address... > > As mfn_to_xen_entry() now needs to be exported, take the opportunity > to swich the parameter attr from unsigned to unsigned int. > > [1] > > Signed-off-by: Wei Liu > Signed-off-by: Hongyan Xia > [julien: Adapted for Arm] > Signed-off-by: Julien Grall > > --- > Changes in v4: > - Move xen_fixmap in fixmap.h and add a comment about its usage. > - Update comments > - Use DECLARE_BITMAP() > - Replace local_irq_{enable, disable} with an ASSERT() as there > should be no user of pmap() in interrupt context. > > Changes in v3: > - s/BITS_PER_LONG/BITS_PER_BYTE/ > - Move pmap to common code > > Changes in v2: > - New patch > > Cc: Jan Beulich > Cc: Wei Liu > Cc: Andrew Cooper > Cc: Roger Pau Monné > --- > xen/arch/arm/Kconfig | 1 + > xen/arch/arm/include/asm/fixmap.h | 24 +++++++++++ > xen/arch/arm/include/asm/lpae.h | 8 ++++ > xen/arch/arm/include/asm/pmap.h | 32 ++++++++++++++ > xen/arch/arm/mm.c | 7 +-- > xen/common/Kconfig | 3 ++ > xen/common/Makefile | 1 + > xen/common/pmap.c | 72 +++++++++++++++++++++++++++++++ > xen/include/xen/pmap.h | 16 +++++++ > 9 files changed, 158 insertions(+), 6 deletions(-) > create mode 100644 xen/arch/arm/include/asm/pmap.h > create mode 100644 xen/common/pmap.c > create mode 100644 xen/include/xen/pmap.h > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index ecfa6822e4d3..a89a67802aa9 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -14,6 +14,7 @@ config ARM > select HAS_DEVICE_TREE > select HAS_PASSTHROUGH > select HAS_PDX > + select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > > config ARCH_DEFCONFIG > diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h > index 1cee51e52ab9..365a2385a087 100644 > --- a/xen/arch/arm/include/asm/fixmap.h > +++ b/xen/arch/arm/include/asm/fixmap.h > @@ -5,20 +5,44 @@ > #define __ASM_FIXMAP_H > > #include > +#include > > /* Fixmap slots */ > #define FIXMAP_CONSOLE 0 /* The primary UART */ > #define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ > #define FIXMAP_ACPI_BEGIN 2 /* Start mappings of ACPI tables */ > #define FIXMAP_ACPI_END (FIXMAP_ACPI_BEGIN + NUM_FIXMAP_ACPI_PAGES - 1) /* End mappings of ACPI tables */ > +#define FIXMAP_PMAP_BEGIN (FIXMAP_ACPI_END + 1) /* Start of PMAP */ > +#define FIXMAP_PMAP_END (FIXMAP_PMAP_BEGIN + NUM_FIX_PMAP - 1) /* End of PMAP */ > + > +#define FIXMAP_LAST FIXMAP_PMAP_END > + > +#define FIXADDR_START FIXMAP_ADDR(0) > +#define FIXADDR_TOP FIXMAP_ADDR(FIXMAP_LAST) > > #ifndef __ASSEMBLY__ > > +/* > + * Direct access to xen_fixmap[] should only happen when {set, > + * clear}_fixmap() is unusable (e.g. where we would end up to > + * recursively call the helpers). > + */ > +extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES]; > + > /* Map a page in a fixmap entry */ > extern void set_fixmap(unsigned map, mfn_t mfn, unsigned attributes); > /* Remove a mapping from a fixmap entry */ > extern void clear_fixmap(unsigned map); > > +#define fix_to_virt(slot) ((void *)FIXMAP_ADDR(slot)) > + > +static inline unsigned int virt_to_fix(vaddr_t vaddr) > +{ > + BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START); > + > + return ((vaddr - FIXADDR_START) >> PAGE_SHIFT); > +} > + > #endif /* __ASSEMBLY__ */ > > #endif /* __ASM_FIXMAP_H */ > diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h > index aecb320dec45..fc19cbd84772 100644 > --- a/xen/arch/arm/include/asm/lpae.h > +++ b/xen/arch/arm/include/asm/lpae.h > @@ -4,6 +4,7 @@ > #ifndef __ASSEMBLY__ > > #include > +#include > > /* > * WARNING! Unlike the x86 pagetable code, where l1 is the lowest level and > @@ -168,6 +169,13 @@ static inline bool lpae_is_superpage(lpae_t pte, unsigned int level) > third_table_offset(addr) \ > } > > +/* > + * Standard entry type that we'll use to build Xen's own pagetables. > + * We put the same permissions at every level, because they're ignored > + * by the walker in non-leaf entries. > + */ > +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); > + > #endif /* __ASSEMBLY__ */ > > /* > diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h > new file mode 100644 > index 000000000000..74398b4c4fe6 > --- /dev/null > +++ b/xen/arch/arm/include/asm/pmap.h > @@ -0,0 +1,32 @@ > +#ifndef __ASM_PMAP_H__ > +#define __ASM_PMAP_H__ > + > +#include > + > +#include > + > +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) > +{ > + lpae_t *entry = &xen_fixmap[slot]; > + lpae_t pte; > + > + ASSERT(!lpae_is_valid(*entry)); > + Sometimes it is very difficult for me to determine whether to use ASSERT or fixed check in this situation. In debug=n config, is there any risk of pte override of arch_pmap_map should be prevented? IMO, it's better to provide a return value for this function and use a fixed check here. > + pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW); > + pte.pt.table = 1; > + write_pte(entry, pte); > +} > + > +static inline void arch_pmap_unmap(unsigned int slot) > +{ > + lpae_t pte = {}; > + We have checked lpae_is_valid() in arch_pmap_map. So can we add a !lpae_is_valid check here and return directly? > + write_pte(&xen_fixmap[slot], pte); > + > + flush_xen_tlb_range_va_local(FIXMAP_ADDR(slot), PAGE_SIZE); > +} > + > +void arch_pmap_map_slot(unsigned int slot, mfn_t mfn); > +void arch_pmap_clear_slot(void *ptr); > + > +#endif /* __ASM_PMAP_H__ */ > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 52b2a0394047..bd1348a99716 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -305,12 +305,7 @@ void dump_hyp_walk(vaddr_t addr) > dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); > } > > -/* > - * Standard entry type that we'll use to build Xen's own pagetables. > - * We put the same permissions at every level, because they're ignored > - * by the walker in non-leaf entries. > - */ > -static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr) > +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) > { > lpae_t e = (lpae_t) { > .pt = { > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index d921c74d615e..5b6b2406c028 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -49,6 +49,9 @@ config HAS_KEXEC > config HAS_PDX > bool > > +config HAS_PMAP > + bool > + > config HAS_SCHED_GRANULARITY > bool > > diff --git a/xen/common/Makefile b/xen/common/Makefile > index b1e076c30b81..3baf83d527d8 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -29,6 +29,7 @@ obj-y += notifier.o > obj-y += page_alloc.o > obj-$(CONFIG_HAS_PDX) += pdx.o > obj-$(CONFIG_PERF_COUNTERS) += perfc.o > +obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o > obj-y += preempt.o > obj-y += random.o > obj-y += rangeset.o > diff --git a/xen/common/pmap.c b/xen/common/pmap.c > new file mode 100644 > index 000000000000..9355cacb7373 > --- /dev/null > +++ b/xen/common/pmap.c > @@ -0,0 +1,72 @@ > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +/* > + * Simple mapping infrastructure to map / unmap pages in fixed map. > + * This is used to set the page table before the map domain page infrastructure > + * is initialized. > + * > + * This structure is not protected by any locks, so it must not be used after > + * smp bring-up. > + */ > + > +/* Bitmap to track which slot is used */ > +static __initdata DECLARE_BITMAP(inuse, NUM_FIX_PMAP); > + > +void *__init pmap_map(mfn_t mfn) > +{ > + unsigned int idx; > + unsigned int slot; > + > + ASSERT(system_state < SYS_STATE_smp_boot); > + ASSERT(!in_irq()); > + > + idx = find_first_zero_bit(inuse, NUM_FIX_PMAP); > + if ( idx == NUM_FIX_PMAP ) > + panic("Out of PMAP slots\n"); > + > + __set_bit(idx, inuse); > + > + slot = idx + FIXMAP_PMAP_BEGIN; > + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); > + > + /* > + * We cannot use set_fixmap() here. We use PMAP when the domain map > + * page infrastructure is not yet initialized, so map_pages_to_xen() called > + * by set_fixmap() needs to map pages on demand, which then calls pmap() > + * again, resulting in a loop. Modify the PTEs directly instead. The same > + * is true for pmap_unmap(). > + */ > + arch_pmap_map(slot, mfn); > + > + return fix_to_virt(slot); > +} > + > +void __init pmap_unmap(const void *p) > +{ > + unsigned int idx; > + unsigned int slot = virt_to_fix((unsigned long)p); > + > + ASSERT(system_state < SYS_STATE_smp_boot); > + ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); > + ASSERT(in_irq()); > + Why this condition is in_irq? Is it for TLB operation in arch_pmap_unmap? Cheers, Wei Chen > + idx = slot - FIXMAP_PMAP_BEGIN; > + > + __clear_bit(idx, inuse); > + arch_pmap_unmap(slot); > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/include/xen/pmap.h b/xen/include/xen/pmap.h > new file mode 100644 > index 000000000000..93e61b10870e > --- /dev/null > +++ b/xen/include/xen/pmap.h > @@ -0,0 +1,16 @@ > +#ifndef __XEN_PMAP_H__ > +#define __XEN_PMAP_H__ > + > +/* Large enough for mapping 5 levels of page tables with some headroom */ > +#define NUM_FIX_PMAP 8 > + > +#ifndef __ASSEMBLY__ > + > +#include > + > +void *pmap_map(mfn_t mfn); > +void pmap_unmap(const void *p); > + > +#endif /* __ASSEMBLY__ */ > + > +#endif /* __XEN_PMAP_H__ */ From xen-devel-bounces@lists.xenproject.org Tue May 24 02:13:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 02:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336112.560415 (Exim 4.92) (envelope-from ) id 1ntK33-00088V-Lm; Tue, 24 May 2022 02:13:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336112.560415; Tue, 24 May 2022 02:13:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntK33-00088O-Ip; Tue, 24 May 2022 02:13:25 +0000 Received: by outflank-mailman (input) for mailman id 336112; Tue, 24 May 2022 02:13:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntK32-00088D-L5 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 02:13:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14ded635-db07-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 04:13:22 +0200 (CEST) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 22:13:19 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by BN7PR03MB3793.namprd03.prod.outlook.com (2603:10b6:408:22::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.21; Tue, 24 May 2022 02:13:16 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 02:13:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14ded635-db07-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653358402; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=ETI5lgl/3m9IUCtgiWyuJwF8JNLOeeWfyETpf3qEOIk=; b=KAE0qUnXFSbuiynnNRftLHNF+Gzh14/l7yCwhiPomMU7vlAXnxjax+sp yH8q70NjJP6Hisn4aZaXcBS+BBTMOOjIIRNZwHD59vPOPZawjarbls2Ot N6STCVUsIErrw+2OvjqmBnOZtfsHlWD4Dnug89iWQ7yPZi7Yvlrism9In s=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 72010556 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:E+mWe63wH40rcZZ3nvbD5dZwkn2cJEfYwER7XKvMYLTBsI5bpzMAx jdOWG6FaKzZNDfye9skOoTn9RgB6pTcz9I1TQFppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Cl6OqExYqfZfho9UUVh9zSH15EJ1JreqvzXiX6aR/zmXgWl61m7BEKh5zOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B8+bBfySube03x9p7ixKNfLfY YwdaCdHZxXceRxffFwQDfrSmc/33CGmK2AF9jp5o4Iv4lTr3gMr1oHOPeLnVf/NdPV6hxex8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ1hHWDy2pVDwcZPXO5ruO+kVWWQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsSzdAbJksspAwTDlzj luRxYqxWXporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9kDSW517YRY36piG IronPort-HdrOrdr: A9a23:mzuTlaHzzu39Ta2opLqFXZHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8ATeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFr9dQnGlq/1vitR5zyJSLsZ4J0upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyJS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHOpALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDfRHXJ9upGpH 3saiIoiYdpQTORNSSn5uw6zjndBGOgQD/q1sZSo5Bkp7yUfsuYDRG+ X-IronPort-AV: E=Sophos;i="5.91,247,1647316800"; d="scan'208,217";a="72010556" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B3K3f+v3TPWmEg0xYNQE9hwEkp8TRX1Cnv534BCMQeByo3EL9zVZUG3vaJkPwcIx0bqT0Qr/xVry3/+zcKc4FfisXUJNcdDcEnO5BG3lxpttX12ybc1tBTKY+MOJGYRSIrpS3hiCC5ehCp8DX9zJigaaELs4sk3LIg5QpFma+H2PShbGsv9+K5Jd5vv1LRHiwgzNSqL2j2TTEf6ekjNk4v69d2U+pu9LxK4EVWY21W+BPijIAGIDiSF/N22zqDud+uxlpZqzvh2q10wJs7arlz4gL0WlHy8lnzry8ZyA5PJtHq+BlYqZtxteFXPrzf06GQbikyoD66wxml32d7VtQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EyxD1VU65ez7Qp9e4oA/6H0iqQo9B+47QKdSXP4oZy0=; b=C7AfdZkuKC+fWio78GDB+I2ibc9HC+Y9HR7uCY29LVFbSXo4ZMbCsMuq3zf71dTeL1sxJQIcnx50+jtDjCNtMytzC4V8nU22EGPlR434riq/wHcK9nTYUDHMXziLSJkoztYsvn5IWoP9peHWmA2gT3+vqHKqJNuaxzs25zKuh/vCVDfnbvNUhmQhUoRofcDqe+vORVjTnXbJhw+K+POVZmJtbhX4MfAVNSCtVh0uJZq84QsF4JQwrl10bkTQVipTDeBYP1V/pLa8t1Mv3D+M8Cil2yX4FmQx2Uw2xazhruA0AdSsBrkKzkwSfRYObyMJ02jwaYs/v7/tDLie9jEgOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EyxD1VU65ez7Qp9e4oA/6H0iqQo9B+47QKdSXP4oZy0=; b=fUHlM6foKiipwLVauvtva3QQ6wfxm4wHkD8cSW4QguardBsKxC+sQgEXn6dIapZVaMjNR4sZOjAgVWfOw2xKgNa99ILpBpnXV+H9yvHtYabEXcMY1hyGbR+Rgdt7AhQwCPljixPf/WcNHtiy5oafNH8ol1BsUfSIHZYIlsgjTeU= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Jan Beulich CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Topic: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Index: AQHYbordwufrrqV0k06ypnfJmfxjlq0sTnKAgAD4X1E= Date: Tue, 24 May 2022 02:13:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6bf2c8ee-d0d6-4607-bea1-08da3d2af67e x-ms-traffictypediagnostic: BN7PR03MB3793:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4QDzZw7PTF24vZJeXjQCW40FLnKJbaS7C9cGbOXcTpAxQgz5B7P6uGV6Kw1OMwyyyheDeAZ0hLZUgGkXzecgER+WlZYRsdJxB+jPoXGS5wPEAtYdQb9r8tL6+x0BHYUHbhLyfRM9xMdA7i1ehF9DFc8BREuewZ1+n1PhtMDWiIgT4VgOS1cFqdO1dK8jDjFOSD66J3zmjCx8gCUP0QmyEOA5nu5s+gaTX/y+Ebd3uXd8JRqcUBw+dZmxCfM/VtJ4tP5OPOWn7/Y4Zu9V43ICKGYBdRV2e8cQPBiGk9D/AI57DARL+H3A/KBruX80VirO6RxAhKll1uVyLeyvMfTkzw7GH3Aga/teAwaxFp7WqGkEgVX0DBChZ6KJDdYvIIXmjm8X4Mvc0KqOObh44xDJtDewGv+EboDNafj4Y0APy613MXlWI6bJot69l8Mr4AM2aCxaOco1IUPnbtVtIGnNch0KYaou+CohyHEABs60EUZfk31syDxl4vJib4p/tpueI4954C3iyK5aACdr0pdiAaKo2TI6RVbHiti/ukZO69tlRL0hDZsXLgOqgL68E1cJo1xfyY17iDuBQ6689oN2d8tTi8xkbSW28vF8sAS6VcT//pc15GbP/ZVSdM2lVSSBIF1ubQKoZIzQ1hJSuAYDZ7vOzV1jDpOoBSeKlJNOOdo6SjRtfSqY4MvODehXdjZR44qEUgdqc0i1mYgp74vtFw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2906002)(86362001)(6916009)(33656002)(316002)(508600001)(54906003)(55016003)(38100700002)(76116006)(4744005)(66946007)(122000001)(71200400001)(82960400001)(8676002)(186003)(9686003)(7696005)(6506007)(38070700005)(8936002)(64756008)(66556008)(26005)(85182001)(52536014)(53546011)(66476007)(66446008)(5660300002)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?SlRIYVBOcHhPM1BlSEdQeWNxeGsyRkhiVW1BdEp6TW8yVkZ4N3hQUWdzZVlC?= =?gb2312?B?T0RTbWI4cjBTRGtSOFdIelJ3elNJbnZsaklxR2x6bWpOTEMwSytDbFd4amJh?= =?gb2312?B?UnpmMG1idUpCRG1JN1NpVkFINDAxZFdic0VJeGk1a3AwdW9sNmk1Y2tpSjRC?= =?gb2312?B?ZW04T1MrQkpPTkVoRVh1aVhjZWdsWkJpd0gwU3RDS3VjcmZZSm1mV3FGMnVB?= =?gb2312?B?UXBYeHhuOSt2Zlp0bG9xeGhXd2lyQ1c5Q3dZaGhoZGRIK3FSS0ViYXlVaFpO?= =?gb2312?B?ZEVEbHV1c2U1Wmk3WHpLNUlhMmxUYUExVGs4L3RUSmR5dVpGdmV4aHNOUHJl?= =?gb2312?B?UzVrK0VoRHdzN295bExVNjFPN1lvaml0a0E3YXJmb2M0aHpZTlpaT0c1RVpU?= =?gb2312?B?Y2FpSzdzMlI5MFZ6b0hzRC9pbUxmcHhta1gvN2lzRU4yU21ZTHJ1OERTQ3l2?= =?gb2312?B?aFdtbm5tTkhLZmVUbzJrejgraEcyQjNYT1U4S3hxWHVib2hUS0FucUk2cnkr?= =?gb2312?B?TjgwWFl1a0FDTS9yWFBFZWVvdmNkNHVhQnozMHh3M1NPaStUZ2hwaXMxS2w0?= =?gb2312?B?QzdWM1Y3a2JQL1JtOWZ6Wk5WZDJlRDMwaG9aQlo0WkpGRklkbHdNVDZFSEd0?= =?gb2312?B?TGVNV3NmRWs1TDZabldOS2g5aE13UDZEQkhhbjRBdkhmdlJSS25wZ2pYb21p?= =?gb2312?B?RXpWZHN4V1R1eko1ZVhRcUU3RXBUY1oxaFB2dk9mWVYxMWNxT0xneWk4bFA5?= =?gb2312?B?RkpWKzliSkYzL2JkelpHUS9qalpvelU0QlFDeUNGVXkrTXFEVE1ldGR5NDQ2?= =?gb2312?B?dnQ3eFoxZ0g1enVhKzRQTDNXQjRFS05yNmVoc1FSaW8vaVB4bkNvM0loUEow?= =?gb2312?B?QlpENm45cEdYOWMzSWk1MHQ0cDdvU21zcEY1ajlOdnJtaFp6UHNyUjN3SFh4?= =?gb2312?B?NnVmTDlGTjVQOVd4T1AxTVV1NzVWRzBCVFZhT0xmSFh2TndXaTQ0VXNjVGVP?= =?gb2312?B?Wm95SGV1SzZBNmFSUDg2RThyU1N1WjVXdUEvdm9OdkxHNjBTVGFyT3VCOHg0?= =?gb2312?B?RDFneXVPZmFZMG4veTYyOG1VUGZkS25oOTI0a3YxcU9IWTI4VjVjbzhYaXlT?= =?gb2312?B?cmhrbnRiMzdHZ1R4cm4yM2ZlM1Y3dTRZVUpEU2NuaU9LYmFIVTFyUk9CTmhy?= =?gb2312?B?VEQ0dnhZK0FQbkxqeCtlK0Q2dVZuNzZDN3dBUzJ0Q0MyNkVvTTdLOEVUSDdr?= =?gb2312?B?Z0ZrMGxkdGRNM3Rpb2E4VjFDR3NYcGNUU0JWUXRTYmRYaFFRQWNTSjFNam1T?= =?gb2312?B?QWdBWnd5eklJMEZuc3RoZEhkZ09QY0xHSVN3TVJrSFZ6bXVyVkFVbUFOUUhs?= =?gb2312?B?SVBubnVxQWIxSzBzbWwrdnZGdmFoSGpmdndkcjMva1NJYzNWSG1md3hlcG9i?= =?gb2312?B?elI4YkdCRHl3MFRuTnZxbEtVc2YyL2xmVEJHRkk2bU5XaDI3cnpFQW83TVRI?= =?gb2312?B?bS93NlNtWUxjYytIU2VrdEx5Z1VPWThDNTJFVUs0UWc2aVV3ODhoU0YvRXRH?= =?gb2312?B?Z0V5b2tweXovMGNhT1NoblE5c0cxMXhMYWdvU1c0OEx1WkpxLzRqd1htZ0E5?= =?gb2312?B?M3RMaFRZTEo1SUN3TVFRUWtPMjFReE95RlNxVmxxOURLTW5yWW5IdWRKNUIy?= =?gb2312?B?b3p3d1JtdHdRaEw0K1FwbnpkQ1ppS2ZWTlVPMUFibktYT2JqTktiSDE3ZWtP?= =?gb2312?B?elZMZ2tKTE1HaW1EL1ZTWmVWNTQrTEEzaEVTS1Jqay92aXZycG45VVVvQ3M0?= =?gb2312?B?MGs3QVE1WU5LNHI1TEswT0t3NGdsZE41RjFlU0ZLZlp4VGZYUEVrQTNzQ0xp?= =?gb2312?B?SFNXQ0lqclNFcFNuaFBLMWdqeGxxMkVUdjRMYlNrd0lRSEJKeUo2eUpWZXpY?= =?gb2312?B?RC9wQ2RyamJMU3Jsem95UEFaN04wSHliSUFaNVY4R01ERFpjdTR1MUoxSm9U?= =?gb2312?B?ZGlQMyt1Skw5QkM4TUY3UllNVTFEcW5zZnMyVktHdUsyWjFsWE9tWThxbENp?= =?gb2312?B?czZBTjhaOWdYMTVVdGdlVFo2K3lnOVdZYWg4a0hyQTRFdGZJYkVtT0FFUW5o?= =?gb2312?B?cUZ6Zm55eHZIOVJHeUdKNms3ZmdFd3VyVmcwSVBYUFl4aWNpeHRSMW5OZFdF?= =?gb2312?B?NXZXQUNQRUZ3ZHVaWlJCQUF0ZFZBeEVVSUJQQmpZcEl0NnQ5UGtxYWlUazJZ?= =?gb2312?B?UVFWUXpIZDB4aC80dytybDdRdS8vdVQyKy9YclZkVlRFVkdpYkpQdGFsL1dT?= =?gb2312?B?R3hPVVFJTzFMYmY0eG9laFBzdWNlM1BzcytjeGk2enJmQWxEQk5Pdz09?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB5405CF5CC73882FF523134C69DD79SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf2c8ee-d0d6-4607-bea1-08da3d2af67e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 02:13:15.9143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nuu7OM8fXYimsoKYuBgj2qZ6wGZnvDIWuPSkmZe4HTFztfDNqSgOLMZdDUwai3xth6KsWBkwo7tw8v9wVYmPDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3793 --_000_SJ0PR03MB5405CF5CC73882FF523134C69DD79SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 T24gMjMuMDUuMjAyMiAxMTo1MiwgTGluIExpdSB3cm90ZToNCj4+IC0tLSBhL3Rvb2xzL2xpYnMv Z3Vlc3QveGdfZG9tX2RlY29tcHJlc3NfdW5zYWZlX3h6LmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMv Z3Vlc3QveGdfZG9tX2RlY29tcHJlc3NfdW5zYWZlX3h6LmMNCj4+IEBAIC0zNCw2ICszNCwxMSBA QCBzdGF0aWMgaW5saW5lIHUzMiBsZTMyX3RvX2NwdXAoY29uc3QgdTMyICpwKQ0KPj4gICAgICAg IHJldHVybiBjcHVfdG9fbGUzMigqcCk7DQo+PiAgfQ0KPj4NCj4+ICtzdGF0aWMgaW5saW5lIHUz MiBsZTMyX3RvX2NwdSh1MzIgdmFsKQ0KPj4gK3sNCj4+ICsgICByZXR1cm4gbGUzMl90b19jcHVw KChjb25zdCB1MzIgKikmdmFsKTsNCj4+ICt9DQo+DQo+V2h5IHRoZSBjYXN0PyBBbmQgd2h5IG5v dCB1aW50MzJfdD8NCj4NCj5KYW4NCg0KbGUzMl90b19jcHVwIGhhcyBmb2xsb3dpbmcgcHJvdG90 eWUgYW5kIGRlZmluaXRpb24NCg0Kc3RhdGljIGlubGluZSB1MzIgbGUzMl90b19jcHVwKGNvbnN0 IHUzMiAqcCkNCnsNCiAgICAgICAgcmV0dXJuIGNwdV90b19sZTMyKCpwKTsNCn0NCg0KeGdfZG9t X2RlY29tcHJlc3NfdW5zYWZlX3h6LmMgcmVkZWZpbmUgYW5kIHVzZSB1MzIsIHVzZSB1MzIgdG8g a2VlcCBjb25zaXN0ZW50DQp0eXBlZGVmIHVpbnQzMl90IHUzMjsNCg== --_000_SJ0PR03MB5405CF5CC73882FF523134C69DD79SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

On 23.05.2022 11:52, Lin Liu wrote:=

>> --- a/tool= s/libs/guest/xg_dom_decompress_unsafe_xz.c

>> +++ b/tool= s/libs/guest/xg_dom_decompress_unsafe_xz.c

>> @@ -34,6 += 34,11 @@ static inline u32 le32_to_cpup(const u32 *p)

>>  = ;      return cpu_to_le32(*p);

>>  }

>> 

>> +static in= line u32 le32_to_cpu(u32 val)

>> +{

>> + &nb= sp; return le32_to_cpup((const u32 *)&val);

>> +}

> 

>Why the cast? A= nd why not uint32_t?

> 

>Jan<= /span>

 

le32_to_cpup has fo= llowing prototye and definition

 

static inline u32 l= e32_to_cpup(const u32 *p)

{=

   &= nbsp;    return cpu_to_le32(*p);

}=

 

xg_dom_decompress_u= nsafe_xz.c redefine and use u32, use u32 to keep consistent

typedef uint32_t u3= 2;

--_000_SJ0PR03MB5405CF5CC73882FF523134C69DD79SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 24 02:42:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 02:42:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336120.560427 (Exim 4.92) (envelope-from ) id 1ntKVD-00034D-Vj; Tue, 24 May 2022 02:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336120.560427; Tue, 24 May 2022 02:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntKVD-000346-Sm; Tue, 24 May 2022 02:42:31 +0000 Received: by outflank-mailman (input) for mailman id 336120; Tue, 24 May 2022 02:42:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntKVC-000340-GF for xen-devel@lists.xenproject.org; Tue, 24 May 2022 02:42:30 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 258d2c41-db0b-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 04:42:28 +0200 (CEST) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 22:42:25 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by DM6PR03MB3609.namprd03.prod.outlook.com (2603:10b6:5:b0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 02:42:22 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 02:42:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 258d2c41-db0b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653360148; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=a3EYxop9xFB3YlPo5wYiD2gcP9bL1SMloLGnyuaK6AY=; b=Hue7R8DOtkLP76YZAXbfLxkkPwr8xkLS301dmLn28sYm12KbaXEJDKVm yNkBbTJXivQZjAj7KjChdSAlbmJzqj4dY1WQidW2TJe7Ng9jScyYyXbyp yx274FVfzZIa9c4U2vlIISrrsbPPGhYOCriQ8lChtzNi0WPwxTMbQdxmB c=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 72403662 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:vg7flaCuWHSHgRVW/xziw5YqxClBgxIJ4kV8jS/XYbTApD8m0jwGm jAZXD/TPK3cajT9eNx1aoy2px4OsMTczdE1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj2dYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh3y +lIv72TWT55BarSoO4tdSRTNiVhaPguFL/veRBTsOS15mifKT7J/K8rC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6h4B8ydK0nJzYYwMDMYgsFIW/Lfe uISaCZ1bQSGaBpKUrsSIM1kwL/z2CelG9FegFbO/LIHzFHa9TNSjeX2GdPqeoOoaOwAyy50o UqDpQwVGCoyNsGbyDeD2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ CQ84TEypKI/8EiqSNjVXBCipnOA+BkGVLJ4GeAg9BuEzKaS5g+DH3UFVRZIctlgv8gzLRQo3 FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakc5oRAt5tDipMQ2kUjJR9M6Sqqt1IWpR3f33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:7P0+Mq5TYlscS1if7APXwX2BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP2ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdkyNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDJnfKk4Xid7N9p0Q6v9bbQuwqdneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2KIoM3R3am+a/hRrDvDnZPiq59hs1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a gpfGkoxFLaIXied/Fm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA== X-IronPort-AV: E=Sophos;i="5.91,247,1647316800"; d="scan'208,217";a="72403662" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaNYl8sI1bO5ibrjpwo5pEpCnzlSwUO/nEYXNOGS6I81YBlLPDcfQk6psIwyKAtJCirdIimdebaSNncP8DO3Cona/9AA6+9aoJXaqYmhanIxAdJh1FZ1M4tOLN9bSZ0G1x0as9OSSlW9a+z+D2SmpUJhr7bBl5xIc4qQHfOkJvEJ4FPqY3KkspFTCMHB9wTE2S41M15fYsDhFZJpzP2Bg8LlriansYeSs3hKWm8qehVzC6QWWir7bpP8o/E2C0CjTI8dkhYAAnOqFFtVR2smCu2HKHwwx0PZyn9mqV84U3+aFcs+hCiZD57E50ulUQSq34P685MmsCQKYKUlcw1JRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btQu1+JhWRACZ6gKW1IZmt0eOUl+jSSrhbLd3Y9cRRU=; b=fBD59Q5agODuWtIQ3E4HdBvgPE6c6AO9c/ogyMTwjWGwBb5FhJefDOWgQL9tvIZXfP/p9tcaRZNBo1rCc570zd7M+8EgNHPHEj+3vP/IPV7/T+LmUniIdS3rO26Kw9DaJ+0Vyaqoq9hZ4ZYrP2oiMZ31m4hdrlZ0kjCCIoKn8o2kTz1zTXSHckNYr/MVI6hvORXC7qEYv3/6kpMrR5F2R0Uo8gkpzC8iRt1hexpMLpansyPsW0167kPuypvoKPFUbKUPLC3eP2mJQbiP6yCq5TBd6nXl2owSZRCZSMZyKCTvekDCrh9AW4VTGBz6YZVWkLIiGwPNAAvvqC7+TA++JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btQu1+JhWRACZ6gKW1IZmt0eOUl+jSSrhbLd3Y9cRRU=; b=JUL4pCOAI8cEDdY0ywG6h7cfnBRy5xmX2RvtYTAy1SL+G2W9FGBFhhDKF3RwzqnxLQFzz3O/Xx2mSlCgZMERw0gx120iUq24+ZhcXs2myda8K3PI4Ma81Pumo5Ck77VKA8vwQK4Rk2LLBKDY2R48hek+IV/oXXubWw6X5Ewc+go= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Julien Grall , Andrew Cooper , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v5 4/6] xen: Switch to byteswap Thread-Topic: [PATCH v5 4/6] xen: Switch to byteswap Thread-Index: AQHYbrSjsRt5f6mJt0SG0aSZHEYt8q0sjRSAgAALyQCAAAeDgIAAsawQ Date: Tue, 24 May 2022 02:42:22 +0000 Message-ID: References: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> <1c7342ed-63af-e420-4f3a-938cb93021c7@xen.org> In-Reply-To: <1c7342ed-63af-e420-4f3a-938cb93021c7@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0bb3d509-b543-463d-d510-08da3d2f079f x-ms-traffictypediagnostic: DM6PR03MB3609:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Cg8gHGO1SxRocznV+rGBDNnV/PU0ZXmjGzacxZ4krrlsP8OahZ1yGVQTOScqdAJF7ts13iaLL8YfyjmkhXh78+kdIHt84pk4/K7s27axc+byBScqRXUpCOqSCnlyr18T8K2bVlmfxUswxfT91HmoSk/TJJu/rcIfqtSs2g2PlSPng+D9ofmdw2Db1OpxVmbcICWPHA1Gcrui7Fen8cr3UPK2FT8JUgUfD18Szh1W1izW0FA7eQZUwpPh7QUFYKFNdB/L5luVn3ueN8BajbEsEduD8EDWouS2gPoiEFFg+5670lFv8EruEm5BcT7+B3uJxj5+DdNsvYiHdoW+ReQLZnLcBWB7ohTswDzTw2hMnWeInHm5I1RuKjQvvEuryp4Jn6EVU/Rcil6jbqpsxQAUIrUyX+2BJhzSn2qeod9OKFVfRQvJB+Xg10ix7+0DiJeIVvQthdhvD5UXIgxWaYtMIkawi91kwqrBgTr0eFTJVDRFgoHxJ2fF1Ujrb2WwdGJKm3bbmyAADojwqRHHoQdPD8oy1c9n02Dh0sy4P6mBpA4VDNwAAbTnx3SEIErmgtju1wrpYNWEFRBL88OizbJ1mQ/SZiOPuT61pA/TopIwpYvwEtxzokcUujQUxd1yPtroTrdTZ8kfZQKdjL2UXOVJa0YrA7R23P2rXtsCx8W4a47Y3iwOR7nmSul1F133qZFSb8rEsYSJH7WghVpqXU5sxw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(53546011)(83380400001)(508600001)(186003)(9686003)(6506007)(86362001)(38100700002)(38070700005)(316002)(110136005)(64756008)(54906003)(66446008)(66556008)(76116006)(66946007)(66476007)(71200400001)(26005)(8676002)(4326008)(91956017)(2906002)(85182001)(5660300002)(8936002)(33656002)(55016003)(122000001)(82960400001)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?R0NnQXlkNURxWHJjVmFZM2NaMm5sMzhtRHJuK2trZnRyOWNNc3l6NlE3Q2JP?= =?gb2312?B?M1k1ejU0c0RZRDlhRHJHTFc0TWIxOVNWSndyN2I2OWV0M2hHYktNT21OMkVH?= =?gb2312?B?T3FTcGRaTWhCTUFjNFRqSTFHUG96RFB0VDBINUNPZnMrTWNDdGFvV2d1c051?= =?gb2312?B?K3hHZnVnVGppT0M4SEludUNUd0Y3bHgyRzRwalpzM1VZOE1zK1F3RnVMU0Y3?= =?gb2312?B?Znp6QnpLQ2ltQkthRzNTSWR3aWlRMUJFWTZkNzhabldsZ1gweEN5NXd3ekV2?= =?gb2312?B?ZDhRSlVMa2N0L1JwVGZ3Wlg5UGljMVhyVFlNaTZPZ2U0Y2t2NFFOU0xMMnBn?= =?gb2312?B?b2xpUnJodGJWM0grWUdFcWZpQWp6L3lwemwrbTRQWGhiWFk5QkIyc2trQUJa?= =?gb2312?B?NnFsTGhJM3pRVWYwUnorRmFlakVObStEcTdpVlFoQkNYK0ZQRFVob05udHNK?= =?gb2312?B?eGllZGNWcXlMOVhDM2w5eWRpSHhkNXZKV3dVWlRWY2RoS0Q2SnVXbzhKYzhW?= =?gb2312?B?dG1meS9sRjNIT2FNZnV4WEFLanJSTmdUMlUzZHVwTkVDSTVFemNHMHNsSzM4?= =?gb2312?B?RVpTOVdUdlhHQmtScEtCQU1MaFlWMDFjYUlYTi9pUFR0ZGxmTFJEb05DR3Iy?= =?gb2312?B?dzBSTnc3ZW5laFdSTVdmeU0xME5CWHRoZjcwaFJiQzlxaHBad0xVZTVkejRP?= =?gb2312?B?V05ZM2VUZWl5bFJxOTVHdXlsUWgvOU03ZkphbG93bXpQQmJWajM4N2prYmRG?= =?gb2312?B?L0UzL1pwbVpxL1JiUHliUHdtcWVRTDNTZDJyUHNWNjZTa0llQmp5RzZMTlIz?= =?gb2312?B?WE1MTVBXT2RZdVE0dnRRVHVqNDRrUGc4Q0VxekEweGpWbi9tUGpDY2trVWlR?= =?gb2312?B?MkRpNnJsdnE2RUpYcnVmT3hsTGRCTjlUYVptRU1tVFI1M3Bwb2RGWnZHaW55?= =?gb2312?B?cU03RXRUMDM3Tlk5b1RLWlNZVFI2K3ZwRUo1Rll0QXhRTnB2WUxxM3hQWitw?= =?gb2312?B?S1Q0ekxwa3ZWTGxpQjFqKzZteldqU085Z2M4RTNLd1MxY29vc3A1dGN2VnRl?= =?gb2312?B?ZEFiNGpnQzBpcDdWcDR0R01yVkh4bmwvWUtFM2UzN2RBMXVxdUxRSHRtdmdM?= =?gb2312?B?MlVlWEZXYURKbHJSMSsvaUxLbmYrZHoralhJV0o0N1Y0MjQrYi9oQ1BSaWxw?= =?gb2312?B?Z0IxVHBMQ3VzN3FmNUZ4ZmVzdmNUWDRqT0RRVlVha2lmTkRNUTVpbk5hb1NU?= =?gb2312?B?UFB2bDg4TW83TllmbGk3a3FXK2lOMFFhVTNad3ZSNERjemJlS3RRWmtEcEtj?= =?gb2312?B?aGtRZ2QxbDBLYUgwQ2V4UExDN05penNSR1YyVHljTm9LNHNraTRlTXFYK1RP?= =?gb2312?B?OTlOR2JOVTI0VWh4ZW05Z3U3cVJ2RW80c2NFSEhLS3hRTStPcGJjTnl0QWhR?= =?gb2312?B?Y3dZdkFxamRzbmJNZFpDV1F5OWQ0bDdlcXM5cVJ3STdUdGJvNEN3a0pBaFVF?= =?gb2312?B?M05Xb2tSTXB2em1aKzRRbnd0Mlg2bk9UR3BBTW5sRC9BSTBUM1BEQWd1cHc5?= =?gb2312?B?SUM3RjNHTkRYL2V2d1VsKytyR3o1ZWFpeDdhNFlDWWtqN3hWQVFZUjU1VC9T?= =?gb2312?B?Wk1DS1h1eTF0Si9NQWtpRHJPNkdQZTRVUDlHZnZ3RURTcGE1QUthamxOOC80?= =?gb2312?B?cFROTkhWMnJIQzBCekUybm8vQW5OczJqaGh3M0dEamloTVpDRzU1U281Wm9x?= =?gb2312?B?YWs4M2MvYUJ2MzAvUTdjRTlzbFFiUC83WHNTUTloR0tVUmpOb29Lb1JlVGdM?= =?gb2312?B?WVVTc2hMdWpvNkR2YjFwWXZ4Mmd5dmdxMm14OE51VDMzQUNWL3E3cmtiRE1I?= =?gb2312?B?a292cUNESWI1bjdXR0FJZVNjQUsvOHRrb3JlaEk1cHI2U24xSlhQeCtVMkVG?= =?gb2312?B?MWZnZy9FWlUrUnp6RWpsaEpCZ05qVnlmWmw5S2VkeCtMamkwMEZBQXVqaEdB?= =?gb2312?B?SlNiR1hBRURYR2d2NytsTCt1K1FIc1Z5bU1KeVdOWE5Da1MrNnNWOEJNRzdM?= =?gb2312?B?VXlDME51bm1uYUt4ZDVYZG5Kbm5LRG1nNm80TngvVmhnblVsdGVKd3VRVnZh?= =?gb2312?B?Q1NxOVlZOE9kL29xVU5LUFFLQmlManA3WTFobnB0UDh0MFpWZGVHWUNiUnFw?= =?gb2312?B?aXBkMEtJZFFyd0lERDFtOW9FK3A3UWpNenlMa2tkbzA3QVcwRi9zaUR6eGtk?= =?gb2312?B?RE42bUFwSFNqU2RiMkhPUTNlTWR6Tm53dURMOG4rV0dvOHE2NlF4dnJES2N1?= =?gb2312?B?YUV4ZkR0cWlZRmhhWWxLMVdIdjAyTGp0aUZ6VUhScTMwNGZEdjNiNW12a3Rw?= =?gb2312?Q?wPy39RtdpX7wDw34=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB5405D2D60515EE9C02761FE79DD79SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb3d509-b543-463d-d510-08da3d2f079f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 02:42:22.6863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DYYWhUf5d2B2fwk7N1NqGQMaG70VKUhzEC7bH1TsWshE0aleXOeYPuMjyOQKm6CEaoKS7kAeQp4OrfZh4r0lOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3609 --_000_SJ0PR03MB5405D2D60515EE9C02761FE79DD79SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 PkhpIEFuZHJldywNCj4NCj5PbiAyMy8wNS8yMDIyIDE2OjM4LCBBbmRyZXcgQ29vcGVyIHdyb3Rl Og0KPj4gT24gMjMvMDUvMjAyMiAxNTo1NiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpLA0K Pj4+DQo+Pj4gT24gMjMvMDUvMjAyMiAxNTo1MCwgTGluIExpdSB3cm90ZToNCj4+Pj4gVXBkYXRl IHRvIHVzZSBieXRlc3dhcCB0byBzd2FwIGJ5dGVzDQo+Pj4+IGJlKl90b19jcHVwKHApIGlzIHNo b3J0IGZvciBiZSp0b19jcHUoKnApLCB1cGRhdGUgdG8gdXNlIGxhdHRlcg0KPj4+PiBvbmUgZXhw bGljdGx5DQo+Pj4NCj4+PiBCdXQgd2h5Pw0KPj4NCj4+IEJlY2F1c2UgZGVsZXRpbmcgY29kZSBv YmZ1c2NhdGlvbiBjb25zdHJ1Y3RzICppcyogdGhlIHBvaW50IG9mIHRoZSBjbGVhbnVwLg0KPj4N Cj4+PiBJIHJlYWxseSBkb24ndCBoYXZlIGEgc3VnZ2VzdGlvbiBvbiB0aGUgY29tbWVudCBiZWNh dXNlIEkgZGlzYWdyZWUNCj4+PiAoYW5kIEFGQUlDVCBKYW4gYXMgd2VsbCkgd2l0aCB0aGUgYXBw cm9hY2guDQo+Pg0KPj4gRHJvcHBpbmcgdGhlIG9iZnVzY2F0aW9uIGhhcyB1bmNvdmVyZWQgcHJl LWV4aXN0aW5nIGJ1Z3MgaW4gdGhlDQo+PiBoeXBlcnZpc29yLiAgVGhlIHNlcmllcyBzdGFuZHMg b24gaXRzIG93biBtZXJpdC4NCj4NCj5JIGFtIGd1ZXNzaW5nIHlvdSBtZWFuIHRoYXQgd2UgZG9u J3QgaGFuZGxlIHVuYWxpZ25lZCBhY2Nlc3M/IElmIHNvLCB5ZXMNCj5JIGFncmVlIHRoaXMgaGVs cGVkIHdpdGggdGhhdC4NCj4NCj4+DQo+PiBXaGlsZSBJIGNhbid0IGhlbHAgaWYgeW91IGxpa2Ug aXQgb3Igbm90LCBpdCByZWFsbHkgZG9lcyBicmluZyBhbg0KPj4gaW1wcm92ZW1lbnQgdG8gY29k ZSBxdWFsaXR5IGFuZCBsZWdpYmlsaXR5Lg0KPj4NCj4+IElmIHlvdSBoYXZlIG5vIHRlY2huaWNh bCBvYmplY3Rpb25zLCBhbmQgbm8gc3VnZ2VzdGlvbnMgZm9yIGhvdyB0byBkbyBpdA0KPj4gZGlm ZmVyZW50bHkgd2hpbGUgcmV0YWluaW5nIHRoZSBxdWFsaXR5IGFuZCBsZWdpYmlsaXR5IGltcHJv dmVtZW50cywNCj4+IHRoZW4gIkkgZG9uJ3QgbGlrZSBpdCIgZG9lc24ndCBibG9jayBpdCBnb2lu ZyBpbi4NCj4NCj5BbmQgeW91IGRvbid0IGxpa2UgdGhlIGV4aXN0aW5nIGNvZGUgOikuIEkgYW0g d2lsbGluZyB0byBjb21wcm9taXNlLCBidXQNCj5mb3IgdGhhdCBJIG5lZWQgdG8gdW5kZXJzdGFu ZCB3aHkgdGhlIGV4aXN0aW5nIGNvZGUgaXMgdGVjaG5pY2FsbHkgbm90DQo+Y29ycmVjdC4NCj4N Cj5TbyBmYXIsIGFsbCB0aGUgYXJndW1lbnRzIHlvdSBwcm92aWRlZCBpbiB2MyB3YXMgZWl0aGVy IGEgbWF0dGVyIG9mDQo+dGFzdGUgb3IgSU1ITyBib2d1cy4NCj4NCj5Zb3VyIHRhc3RlIGlzIG5v ciBiZXR0ZXIgbm9yIHdvcnNlIHRoYW4gbWluZS4gQXQgd2hpY2gsIHdlIG5lZWQgc29tZW9uZQ0K PmVsc2UgdG8gYnJlYWsgdGhlIHRpZS4NCj4NCj5JZiBJIGFtIG5vdCBtaXN0YWtlbiwgSmFuIGlz IGFsc28gb2JqZWN0aW5nIG9uIHRoZSBwcm9wb3NhbC4gQXQgd2hpY2gNCj5wb2ludCwgd2UgYXJl IDIgdnMgMS4NCj4NCj5TbyB0aGVyZSBhcmUgdGhyZWUgY2hvaWNlcyBoZXJlOg0KPiAgIDEpIFlv dSBmaW5kIHR3byBvdGhlcnMgbWFpbnRhaW5lcnMgKGluY2x1ZGluZyBvbiBBcm0gbWFpbnRhaW5l cikgdG8NCj5hZ3JlZSB3aXRoIHlvdQ0KPiAgIDIpIFlvdSBwcm92aWRlIGFyZ3VtZW50cyB0aGF0 IHdpbGwgc3dheSBvbmUgb2YgdXMgaW4geW91ciBzaWRlDQo+ICAgMykgV2Uga2VlcCBiZTMyX2Nw dSooKSAodGhleSBhcmUgc2ltcGxlIHdyYXBwZXIgYW5kIEkgYW0gd2lsbGluZyB0bw0KPndyaXRl IHRoZSBjb2RlKS4NCg0KUGVyc29uYWx5LCBJIGFncmVlIHdpdGggQW5kcmV3IENvcHBlciB0byBy ZW1vdmUgdGhlIGJlKl90b19jcHVwIGhlbHBlcnMgYXMgY3VycmVudA0KaW1wbGVtZXRhdGlvbiBp cyBqdXN0IGEgd3JhcHBlciwgbGlrZQ0KDQojaWZuZGVmIF9fYXJjaF9fc3dhYjE2cA0KIyAgZGVm aW5lIF9fYXJjaF9fc3dhYjE2cCh4KSBfX2FyY2hfX3N3YWIxNigqKHgpKQ0KI2VuZGlmDQoNCldp dGggYmUqX3RvX2NwdXAgYmVlbiByZW1vdmVkLCB0aGUgaW50ZXJmYWNlIGtlZXBzIHNpbXBsZSBh bmQgY2xlYXIsIGFuZCBjYWxsZXJzDQphcmUgZGVyZWZlcmVuY2UgdGhlIHBvaW50ZXIgZXhwbGlj dGx5Lg0KDQpJIGFtIHZlcnkgaGFwcHkgdG8gc2VlIHRoZSB0aHJlZSBjaG9pY2VzLCBob3BlIHdl IGNhbiByZWFjaCBhbiBhZ3JlZW1lbnQgYWJvdXQgdGhpcyBzb29uLg0KDQpDaGVycnMsDQotLS0N Ckxpbg0K --_000_SJ0PR03MB5405D2D60515EE9C02761FE79DD79SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

>Hi Andrew,

> 

>On 23/05/2022 1= 6:38, Andrew Cooper wrote:

>> On 23/05/2= 022 15:56, Julien Grall wrote:

>>> Hi,

>>>&n= bsp;

>>> On 23/= 05/2022 15:50, Lin Liu wrote:

>>>> Up= date to use byteswap to swap bytes

>>>> be= *_to_cpup(p) is short for be*to_cpu(*p), update to use latter

>>>> on= e explictly

>>>&n= bsp;

>>> But wh= y?

>>

>> Because de= leting code obfuscation constructs *is* the point of the cleanup.

>>

>>> I real= ly don't have a suggestion on the comment because I disagree

>>> (and A= FAICT Jan as well) with the approach.

>>

>> Dropping t= he obfuscation has uncovered pre-existing bugs in the

>> hypervisor= .  The series stands on its own merit.

> 

>I am guessing y= ou mean that we don't handle unaligned access? If so, yes

>I agree this he= lped with that.

> 

>>

>> While I ca= n't help if you like it or not, it really does bring an

>> improvemen= t to code quality and legibility.

>>

>> If you hav= e no technical objections, and no suggestions for how to do it

>> differentl= y while retaining the quality and legibility improvements,

>> then "= ;I don't like it" doesn't block it going in.

> 

>And you don't l= ike the existing code :). I am willing to compromise, but

>for that I need= to understand why the existing code is technically not

>correct.

> 

>So far, all the= arguments you provided in v3 was either a matter of

>taste or IMHO b= ogus.

> 

>Your taste is n= or better nor worse than mine. At which, we need someone

>else to break t= he tie.

> 

>If I am not mis= taken, Jan is also objecting on the proposal. At which

>point, we are 2= vs 1.

> 

>So there are th= ree choices here:

>   1)= You find two others maintainers (including on Arm maintainer) to

>agree with you<= o:p>

>   2)= You provide arguments that will sway one of us in your side

>   3)= We keep be32_cpu*() (they are simple wrapper and I am willing to

>write the code)= .

 

Personaly, I agree = with Andrew Copper to remove the be*_to_cpup helpers as current<= /span>

implemetation is ju= st a wrapper, like

 

#ifndef __arch__swa= b16p

#  define __ar= ch__swab16p(x) __arch__swab16(*(x))

#endif

 

With be*_to_cpup be= en removed, the interface keeps simple and clear, and callers

are dereference the= pointer explictly.

 

I am very happy to = see the three choices, hope we can reach an agreement about this soon.=

 

Cherrs,<= /span>

---

Lin

--_000_SJ0PR03MB5405D2D60515EE9C02761FE79DD79SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 24 02:48:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 02:48:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336127.560437 (Exim 4.92) (envelope-from ) id 1ntKbA-0003oP-Pr; Tue, 24 May 2022 02:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336127.560437; Tue, 24 May 2022 02:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntKbA-0003oI-My; Tue, 24 May 2022 02:48:40 +0000 Received: by outflank-mailman (input) for mailman id 336127; Tue, 24 May 2022 02:48:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntKb9-0003oC-L3 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 02:48:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7d00::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 027d7021-db0c-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 04:48:37 +0200 (CEST) Received: from DB6P18901CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::32) by AM6PR08MB3319.eurprd08.prod.outlook.com (2603:10a6:209:4e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 24 May 2022 02:48:33 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::38) by DB6P18901CA0022.outlook.office365.com (2603:10a6:4:16::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13 via Frontend Transport; Tue, 24 May 2022 02:48:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 02:48:32 +0000 Received: ("Tessian outbound 42cead292588:v119"); Tue, 24 May 2022 02:48:32 +0000 Received: from 4ce827f12034.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5EFC986E-A1C3-417A-BF02-4A83025A160C.1; Tue, 24 May 2022 02:48:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4ce827f12034.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 02:48:26 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by DB7PR08MB3130.eurprd08.prod.outlook.com (2603:10a6:5:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 02:48:23 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::8f2:f748:5da2:6278]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::8f2:f748:5da2:6278%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 02:48:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 027d7021-db0c-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bugvHtssbj4tgW+zCgBpxDMLUG0FJQIOhok12yNSrVS1q5duKkYiR4JvfQyJ2jVwLFbkiV89iDYGFS8ILTojtLYOQo3R/yqHCtlWtzKXYTlcasTrUApJwzlN69ymc/XP6FY/hAgv/pGkzi9FmcZOBtfc5ejgP+zTrJS3UE28OI8EcHOhcqkfepYuNA1Jq/KnbreEZbfNe1gUU3eniwyu0xt+gy5jJjzEMZZIGny0VqygmimFTt+lJwkYpr+M7HEM0b/5I5/wVESGa0/lrgmcCPWlKhW5Q0i4eh/n1anF9mRAcy9iurv9l3/Fxn7SYLZzAeBodHVoB+xoijtiL2g0hg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TTRk+wrtTgygeKt4VD6Wbky4AhGgyD829LwcQKQ2GnU=; b=k2lc7tycDjnlllimdsrsEVi5lKKyX8EgLPXtTs2eQ/qevQtizXfVeYhP6vwpbJa50X0Kv3wlUFF3xIs/UmJysWlDph8mOSvexq62ZHZYieWVfpqEw0WtDk+MVjINBCgUB7otnPpep0HtbqrmCuhGrBdRQtHi5Aw+fMNqJsrSzqXQi8UoQIOtWp5mTM/6V6eL+YLNDteCAR6Z6qXb3BaEO6F4EpZ+UocszZYUMmWZGlkcfExkA8c4Ere/iYJJAtcLDPKmaJVSJ9SIn8nrMxLu1OYSuTBqb6ARKOe+hT1OqwD1zsNHYlIG9Iwt5J0ktZ72aAHxs0OS954smoB7E86wVg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TTRk+wrtTgygeKt4VD6Wbky4AhGgyD829LwcQKQ2GnU=; b=tL/ywDNHrhT7n8wbfJ8mmDzZx1dksPbYunOlLLAQbIZ6r4uVJxyHEhhnSMY9NPfbvHu3NNO+ncCdAeYPDOjLQn1/LaCC7I5WQSgzM10nyHju6ovMt9Q/cbhZ54Tpyv11+t67QhWy7zTzwveEYMM4DdG1lI3cyElf7+EZZciF6Mk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IQB4r2rkk+gcQ45v30mJn5y006EtlDgSYL3xuLufHsTd/X1Darac7dKLP9SkwKp9lLLBOjoV4wHaRyObEOs/ow6JLSGRQWInjQR7ngkLoNLQ4Jo007o5yYmpJw/3Tb8/e8udSX6ufKK4P8QoBQb9C+xm5QHWNepb54R5kCHhiMp+fQKd7TnwJxVnVcQLqMhUw7+qrRK6ls0/k1NkdZ84IoLxU3FYkqjDQLaNDz0Rfy2BDljpOgQ0RKrFXY26e/5Gq/1Xb+kXe1kUGEGOyMjto34ZMeljiSC1CTuicmAnlAM7KGIj4vQaeZe4tKNwIeMqg97gj6N7DFZUevi9y2kqbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TTRk+wrtTgygeKt4VD6Wbky4AhGgyD829LwcQKQ2GnU=; b=d5ZEyeV/04PmLu8SgSh64qHxIylWjchQXZFeFNXwQY0omhrdx/Q0psyM39G2kMFEncGZ7KMQrWmfJ59iF6dH4gw2Sj/tk7+LFndgeSjPOQOu7b6sDlAx1Qf8qRFDWw6iXrbraX8cv/9/oiyiNK9mOlP61R0MyJwHdvSzrqmjCOfk7V77yGFa8fydGTNhgLmeHSz4Eyqc9dKrohMhGmx2Td7lRJjg1JR/Smn4yZKyR9fzJYQqpRi8ZSmLaV6staXRAplv9qBEInogihrNZ/1WIBnCjVkExpu8ZV0OUMNEKHpVjZsfI1Cnwdh+7LTzAGuMtpST8dRi7QMPmMOsdUUbwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TTRk+wrtTgygeKt4VD6Wbky4AhGgyD829LwcQKQ2GnU=; b=tL/ywDNHrhT7n8wbfJ8mmDzZx1dksPbYunOlLLAQbIZ6r4uVJxyHEhhnSMY9NPfbvHu3NNO+ncCdAeYPDOjLQn1/LaCC7I5WQSgzM10nyHju6ovMt9Q/cbhZ54Tpyv11+t67QhWy7zTzwveEYMM4DdG1lI3cyElf7+EZZciF6Mk= From: Jiamei Xie To: Lin Liu , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v5 6/6] byteorder: Remove byteorder Thread-Topic: [PATCH v5 6/6] byteorder: Remove byteorder Thread-Index: AQHYbrSkdBLA7e8+Uk2zs3km3pRUja0tUgJg Date: Tue, 24 May 2022 02:48:23 +0000 Message-ID: References: <1b9957326f5018c38ce6c523e3e5ab67f012ac00.1653314499.git.lin.liu@citrix.com> In-Reply-To: <1b9957326f5018c38ce6c523e3e5ab67f012ac00.1653314499.git.lin.liu@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A1F37E1FA9D1A143A28F7E2862DA5396.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 89c6328b-65f7-4c7d-85e2-08da3d2fe422 x-ms-traffictypediagnostic: DB7PR08MB3130:EE_|DBAEUR03FT062:EE_|AM6PR08MB3319:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qz4POKlAhAxueUohVyvBcLqGvewgICzdF92mLytS+Z9kYuC8aEmVxexpd9cIyC3QkgkB11bdyUrZNZYWEf5mtL3l3WcRXWxh8pWq/dnGAbPEFM6t+O3doaDSCmr+CaRnU9wBxg4pUOOJneGMVp34zVayccHRIZ2hbHlwJ9MJVwQqCsUKLDY93HUyGyPDaTryWfOG4MoeL4DxFP20e3dw0JDe5jUUFiKl0eKx1kfr6iUv46L5AgHG6B0N2a9JaoyJWTOmD96nyMPkodkut6h9IhXVMUJgKrsNxRfpFfbKyIGNGup5/qxdWrj9k1v0uHZ31lD+ljK2pmzEifuhwsF++wmMlO0hSoKcknj+S7odWSScAkgo5G34IJs/C3BlniQSVu78nbn6vKsUsCLNqACh8uO88bO1wbl1t3wXDv4UHw1uZZ7ruMHr7Otd8Abcmo9uVkIrblhQAw/y0vr4MeGhoNGF3KN7BsWErwN/wUXuaz+B9HiopHPGy8zqELJv8T5NFTg2+BHMo67HCYojsmS0gnplRV+cxRkoIw7qwd826MWUFaJlPy1miWehwkDwZW1nAHuGDFWPSMZhdo6OeFNyER7j6IPyno14LykgYWlOAkY+3JcoCD9kHfXYgvTRwuLn8M9dL0OoGNL86xxWR+uuLicAljgyESS34pONKG6vtAZSIm7l9Rqtjapfbghn7Gf//NQpo8wLcMRDwstiZsKu8w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(86362001)(76116006)(5660300002)(33656002)(83380400001)(110136005)(64756008)(8676002)(66556008)(4326008)(316002)(186003)(7696005)(66476007)(66446008)(122000001)(6506007)(66946007)(30864003)(38100700002)(54906003)(8936002)(38070700005)(508600001)(26005)(2906002)(53546011)(55016003)(9686003)(71200400001)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3130 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 97151f63-4acf-4f49-008c-08da3d2fde81 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gxBMN+5Z513/N7B9Tc5qleYRto+b3GmXpG3l5V2/34zvMDsBQE3ZytiwU6/mwUJpYloP/AlBfLhGBL9zyfR+bHYJp/QRPRz1xxN5/yJkzEXCcS3WVAF1GsWNqwZDYCvhVwjCm4fN2KwIb8sUswQPQbL2qccaBC5Uyq3PB4Cz0NJDq2W4CL7f4jrDSAnzCX9OeFd7tVDcwvw7YRefd+51a2/vLGicb4JFqp8BMfrKZ22TAasFVudZ42u3Nq+d4uclgx/OxOUgr7ogXo2aKXS3EU0GSJ1LPYlSh8Jsi18fNQJhL4gmvlToDHbziBurSEIkRmDQX+aGldXNWkSw/MQdg6jJM1MTDZBJNXykgCMvUW0pbtcbU7lNyCPy02uw4QDv2ZTv43UF4OkIomdnKdIC4x7K/chAxp+mvW4EcbxNcTnBFqeoef8+viHo0A5r9HsV78RDuJsHtFtDSUJYA82R1DKmcbinDi138u+DiYkdyPZYGMiRsjxJFAm3PB7wkMd/n3F5glJOPljhomVG9WiJdtHsPZbdiYTeamF/L4ROY66vHeZ0Scl+voD8zZIsTL6EcJWeNs1NKwrJeFOoFIojytgekn2hJPweaJx1SlUwvd8qyrMceoKKJbH3wjqyTvb9LJszHOynWPdklvf+x56d+CNDcUAWk3Xo+meTugOlKZtIKLFlVjPSaUYsf4rPRxle X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(54906003)(110136005)(40460700003)(83380400001)(8676002)(356005)(36860700001)(4326008)(82310400005)(70206006)(186003)(70586007)(86362001)(30864003)(9686003)(47076005)(336012)(508600001)(55016003)(26005)(81166007)(8936002)(53546011)(33656002)(6506007)(7696005)(2906002)(52536014)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 02:48:32.6415 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89c6328b-65f7-4c7d-85e2-08da3d2fe422 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3319 Hi Lin, > -----Original Message----- > From: Xen-devel On Behalf Of Lin > Liu > Sent: 2022=1B$BG/=1B(B5=1B$B7n=1B(B23=1B$BF|=1B(B 22:51 > To: xen-devel@lists.xenproject.org > Cc: Lin Liu ; Andrew Cooper > ; George Dunlap ; > Jan Beulich ; Julien Grall ; Bertrand > Marquis ; Stefano Stabellini > ; Wei Liu > Subject: [PATCH v5 6/6] byteorder: Remove byteorder >=20 > include/xen/byteswap.h has simplify the interface, just clean > the old interface There is a typo. s/ simplify/simplified /. Best wishes Jiamei Xie >=20 > No functional change >=20 > Signed-off-by: Lin Liu > Reviewed-by: Andrew Cooper > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Julien Grall > Cc: Bertrand Marquis > Cc: Stefano Stabellini > Cc: Wei Liu > --- > xen/include/xen/byteorder/big_endian.h | 102 ------------ > xen/include/xen/byteorder/generic.h | 68 -------- > xen/include/xen/byteorder/little_endian.h | 102 ------------ > xen/include/xen/byteorder/swab.h | 183 ---------------------- > 4 files changed, 455 deletions(-) > delete mode 100644 xen/include/xen/byteorder/big_endian.h > delete mode 100644 xen/include/xen/byteorder/generic.h > delete mode 100644 xen/include/xen/byteorder/little_endian.h > delete mode 100644 xen/include/xen/byteorder/swab.h >=20 > diff --git a/xen/include/xen/byteorder/big_endian.h > b/xen/include/xen/byteorder/big_endian.h > deleted file mode 100644 > index 40eb80a390..0000000000 > --- a/xen/include/xen/byteorder/big_endian.h > +++ /dev/null > @@ -1,102 +0,0 @@ > -#ifndef __XEN_BYTEORDER_BIG_ENDIAN_H__ > -#define __XEN_BYTEORDER_BIG_ENDIAN_H__ > - > -#ifndef __BIG_ENDIAN > -#define __BIG_ENDIAN 4321 > -#endif > -#ifndef __BIG_ENDIAN_BITFIELD > -#define __BIG_ENDIAN_BITFIELD > -#endif > - > -#include > -#include > - > -#define __constant_cpu_to_le64(x) ((__force > __le64)___constant_swab64((x))) > -#define __constant_le64_to_cpu(x) ___constant_swab64((__force > __u64)(__le64)(x)) > -#define __constant_cpu_to_le32(x) ((__force > __le32)___constant_swab32((x))) > -#define __constant_le32_to_cpu(x) ___constant_swab32((__force > __u32)(__le32)(x)) > -#define __constant_cpu_to_le16(x) ((__force > __le16)___constant_swab16((x))) > -#define __constant_le16_to_cpu(x) ___constant_swab16((__force > __u16)(__le16)(x)) > -#define __constant_cpu_to_be64(x) ((__force __be64)(__u64)(x)) > -#define __constant_be64_to_cpu(x) ((__force __u64)(__be64)(x)) > -#define __constant_cpu_to_be32(x) ((__force __be32)(__u32)(x)) > -#define __constant_be32_to_cpu(x) ((__force __u32)(__be32)(x)) > -#define __constant_cpu_to_be16(x) ((__force __be16)(__u16)(x)) > -#define __constant_be16_to_cpu(x) ((__force __u16)(__be16)(x)) > -#define __cpu_to_le64(x) ((__force __le64)__swab64((x))) > -#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x)) > -#define __cpu_to_le32(x) ((__force __le32)__swab32((x))) > -#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) > -#define __cpu_to_le16(x) ((__force __le16)__swab16((x))) > -#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) > -#define __cpu_to_be64(x) ((__force __be64)(__u64)(x)) > -#define __be64_to_cpu(x) ((__force __u64)(__be64)(x)) > -#define __cpu_to_be32(x) ((__force __be32)(__u32)(x)) > -#define __be32_to_cpu(x) ((__force __u32)(__be32)(x)) > -#define __cpu_to_be16(x) ((__force __be16)(__u16)(x)) > -#define __be16_to_cpu(x) ((__force __u16)(__be16)(x)) > - > -static inline __le64 __cpu_to_le64p(const __u64 *p) > -{ > - return (__force __le64)__swab64p(p); > -} > -static inline __u64 __le64_to_cpup(const __le64 *p) > -{ > - return __swab64p((__u64 *)p); > -} > -static inline __le32 __cpu_to_le32p(const __u32 *p) > -{ > - return (__force __le32)__swab32p(p); > -} > -static inline __u32 __le32_to_cpup(const __le32 *p) > -{ > - return __swab32p((__u32 *)p); > -} > -static inline __le16 __cpu_to_le16p(const __u16 *p) > -{ > - return (__force __le16)__swab16p(p); > -} > -static inline __u16 __le16_to_cpup(const __le16 *p) > -{ > - return __swab16p((__u16 *)p); > -} > -static inline __be64 __cpu_to_be64p(const __u64 *p) > -{ > - return (__force __be64)*p; > -} > -static inline __u64 __be64_to_cpup(const __be64 *p) > -{ > - return (__force __u64)*p; > -} > -static inline __be32 __cpu_to_be32p(const __u32 *p) > -{ > - return (__force __be32)*p; > -} > -static inline __u32 __be32_to_cpup(const __be32 *p) > -{ > - return (__force __u32)*p; > -} > -static inline __be16 __cpu_to_be16p(const __u16 *p) > -{ > - return (__force __be16)*p; > -} > -static inline __u16 __be16_to_cpup(const __be16 *p) > -{ > - return (__force __u16)*p; > -} > -#define __cpu_to_le64s(x) __swab64s((x)) > -#define __le64_to_cpus(x) __swab64s((x)) > -#define __cpu_to_le32s(x) __swab32s((x)) > -#define __le32_to_cpus(x) __swab32s((x)) > -#define __cpu_to_le16s(x) __swab16s((x)) > -#define __le16_to_cpus(x) __swab16s((x)) > -#define __cpu_to_be64s(x) do {} while (0) > -#define __be64_to_cpus(x) do {} while (0) > -#define __cpu_to_be32s(x) do {} while (0) > -#define __be32_to_cpus(x) do {} while (0) > -#define __cpu_to_be16s(x) do {} while (0) > -#define __be16_to_cpus(x) do {} while (0) > - > -#include > - > -#endif /* __XEN_BYTEORDER_BIG_ENDIAN_H__ */ > diff --git a/xen/include/xen/byteorder/generic.h > b/xen/include/xen/byteorder/generic.h > deleted file mode 100644 > index 8a0006b755..0000000000 > --- a/xen/include/xen/byteorder/generic.h > +++ /dev/null > @@ -1,68 +0,0 @@ > -#ifndef __XEN_BYTEORDER_GENERIC_H__ > -#define __XEN_BYTEORDER_GENERIC_H__ > - > -/* > - * Generic Byte-reordering support > - * > - * The "... p" macros, like le64_to_cpup, can be used with pointers > - * to unaligned data, but there will be a performance penalty on > - * some architectures. Use get_unaligned for unaligned data. > - * > - * The following macros are to be defined by : > - * > - * Conversion of XX-bit integers (16- 32- or 64-) > - * between native CPU format and little/big endian format > - * 64-bit stuff only defined for proper architectures > - * cpu_to_[bl]eXX(__uXX x) > - * [bl]eXX_to_cpu(__uXX x) > - * > - * The same, but takes a pointer to the value to convert > - * cpu_to_[bl]eXXp(__uXX x) > - * [bl]eXX_to_cpup(__uXX x) > - * > - * The same, but change in situ > - * cpu_to_[bl]eXXs(__uXX x) > - * [bl]eXX_to_cpus(__uXX x) > - * > - * See asm-foo/byteorder.h for examples of how to provide > - * architecture-optimized versions > - */ > - > -#define cpu_to_le64 __cpu_to_le64 > -#define le64_to_cpu __le64_to_cpu > -#define cpu_to_le32 __cpu_to_le32 > -#define le32_to_cpu __le32_to_cpu > -#define cpu_to_le16 __cpu_to_le16 > -#define le16_to_cpu __le16_to_cpu > -#define cpu_to_be64 __cpu_to_be64 > -#define be64_to_cpu __be64_to_cpu > -#define cpu_to_be32 __cpu_to_be32 > -#define be32_to_cpu __be32_to_cpu > -#define cpu_to_be16 __cpu_to_be16 > -#define be16_to_cpu __be16_to_cpu > -#define cpu_to_le64p __cpu_to_le64p > -#define le64_to_cpup __le64_to_cpup > -#define cpu_to_le32p __cpu_to_le32p > -#define le32_to_cpup __le32_to_cpup > -#define cpu_to_le16p __cpu_to_le16p > -#define le16_to_cpup __le16_to_cpup > -#define cpu_to_be64p __cpu_to_be64p > -#define be64_to_cpup __be64_to_cpup > -#define cpu_to_be32p __cpu_to_be32p > -#define be32_to_cpup __be32_to_cpup > -#define cpu_to_be16p __cpu_to_be16p > -#define be16_to_cpup __be16_to_cpup > -#define cpu_to_le64s __cpu_to_le64s > -#define le64_to_cpus __le64_to_cpus > -#define cpu_to_le32s __cpu_to_le32s > -#define le32_to_cpus __le32_to_cpus > -#define cpu_to_le16s __cpu_to_le16s > -#define le16_to_cpus __le16_to_cpus > -#define cpu_to_be64s __cpu_to_be64s > -#define be64_to_cpus __be64_to_cpus > -#define cpu_to_be32s __cpu_to_be32s > -#define be32_to_cpus __be32_to_cpus > -#define cpu_to_be16s __cpu_to_be16s > -#define be16_to_cpus __be16_to_cpus > - > -#endif /* __XEN_BYTEORDER_GENERIC_H__ */ > diff --git a/xen/include/xen/byteorder/little_endian.h > b/xen/include/xen/byteorder/little_endian.h > deleted file mode 100644 > index 4955632793..0000000000 > --- a/xen/include/xen/byteorder/little_endian.h > +++ /dev/null > @@ -1,102 +0,0 @@ > -#ifndef __XEN_BYTEORDER_LITTLE_ENDIAN_H__ > -#define __XEN_BYTEORDER_LITTLE_ENDIAN_H__ > - > -#ifndef __LITTLE_ENDIAN > -#define __LITTLE_ENDIAN 1234 > -#endif > -#ifndef __LITTLE_ENDIAN_BITFIELD > -#define __LITTLE_ENDIAN_BITFIELD > -#endif > - > -#include > -#include > - > -#define __constant_cpu_to_le64(x) ((__force __le64)(__u64)(x)) > -#define __constant_le64_to_cpu(x) ((__force __u64)(__le64)(x)) > -#define __constant_cpu_to_le32(x) ((__force __le32)(__u32)(x)) > -#define __constant_le32_to_cpu(x) ((__force __u32)(__le32)(x)) > -#define __constant_cpu_to_le16(x) ((__force __le16)(__u16)(x)) > -#define __constant_le16_to_cpu(x) ((__force __u16)(__le16)(x)) > -#define __constant_cpu_to_be64(x) ((__force > __be64)___constant_swab64((x))) > -#define __constant_be64_to_cpu(x) ___constant_swab64((__force > __u64)(__be64)(x)) > -#define __constant_cpu_to_be32(x) ((__force > __be32)___constant_swab32((x))) > -#define __constant_be32_to_cpu(x) ___constant_swab32((__force > __u32)(__be32)(x)) > -#define __constant_cpu_to_be16(x) ((__force > __be16)___constant_swab16((x))) > -#define __constant_be16_to_cpu(x) ___constant_swab16((__force > __u16)(__be16)(x)) > -#define __cpu_to_le64(x) ((__force __le64)(__u64)(x)) > -#define __le64_to_cpu(x) ((__force __u64)(__le64)(x)) > -#define __cpu_to_le32(x) ((__force __le32)(__u32)(x)) > -#define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) > -#define __cpu_to_le16(x) ((__force __le16)(__u16)(x)) > -#define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) > -#define __cpu_to_be64(x) ((__force __be64)__swab64((x))) > -#define __be64_to_cpu(x) __swab64((__force __u64)(__be64)(x)) > -#define __cpu_to_be32(x) ((__force __be32)__swab32((x))) > -#define __be32_to_cpu(x) __swab32((__force __u32)(__be32)(x)) > -#define __cpu_to_be16(x) ((__force __be16)__swab16((x))) > -#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x)) > - > -static inline __le64 __cpu_to_le64p(const __u64 *p) > -{ > - return (__force __le64)*p; > -} > -static inline __u64 __le64_to_cpup(const __le64 *p) > -{ > - return (__force __u64)*p; > -} > -static inline __le32 __cpu_to_le32p(const __u32 *p) > -{ > - return (__force __le32)*p; > -} > -static inline __u32 __le32_to_cpup(const __le32 *p) > -{ > - return (__force __u32)*p; > -} > -static inline __le16 __cpu_to_le16p(const __u16 *p) > -{ > - return (__force __le16)*p; > -} > -static inline __u16 __le16_to_cpup(const __le16 *p) > -{ > - return (__force __u16)*p; > -} > -static inline __be64 __cpu_to_be64p(const __u64 *p) > -{ > - return (__force __be64)__swab64p(p); > -} > -static inline __u64 __be64_to_cpup(const __be64 *p) > -{ > - return __swab64p((__u64 *)p); > -} > -static inline __be32 __cpu_to_be32p(const __u32 *p) > -{ > - return (__force __be32)__swab32p(p); > -} > -static inline __u32 __be32_to_cpup(const __be32 *p) > -{ > - return __swab32p((__u32 *)p); > -} > -static inline __be16 __cpu_to_be16p(const __u16 *p) > -{ > - return (__force __be16)__swab16p(p); > -} > -static inline __u16 __be16_to_cpup(const __be16 *p) > -{ > - return __swab16p((__u16 *)p); > -} > -#define __cpu_to_le64s(x) do {} while (0) > -#define __le64_to_cpus(x) do {} while (0) > -#define __cpu_to_le32s(x) do {} while (0) > -#define __le32_to_cpus(x) do {} while (0) > -#define __cpu_to_le16s(x) do {} while (0) > -#define __le16_to_cpus(x) do {} while (0) > -#define __cpu_to_be64s(x) __swab64s((x)) > -#define __be64_to_cpus(x) __swab64s((x)) > -#define __cpu_to_be32s(x) __swab32s((x)) > -#define __be32_to_cpus(x) __swab32s((x)) > -#define __cpu_to_be16s(x) __swab16s((x)) > -#define __be16_to_cpus(x) __swab16s((x)) > - > -#include > - > -#endif /* __XEN_BYTEORDER_LITTLE_ENDIAN_H__ */ > diff --git a/xen/include/xen/byteorder/swab.h > b/xen/include/xen/byteorder/swab.h > deleted file mode 100644 > index b7e30f0503..0000000000 > --- a/xen/include/xen/byteorder/swab.h > +++ /dev/null > @@ -1,183 +0,0 @@ > -#ifndef __XEN_BYTEORDER_SWAB_H__ > -#define __XEN_BYTEORDER_SWAB_H__ > - > -/* > - * Byte-swapping, independently from CPU endianness > - * swabXX[ps]?(foo) > - * > - * Francois-Rene Rideau 19971205 > - * separated swab functions from cpu_to_XX, > - * to clean up support for bizarre-endian architectures. > - */ > - > -/* casts are necessary for constants, because we never know how for sure > - * how U/UL/ULL map to __u16, __u32, __u64. At least not in a portable w= ay. > - */ > -#define ___swab16(x) \ > -({ \ > - __u16 __x =3D (x); \ > - ((__u16)( \ > - (((__u16)(__x) & (__u16)0x00ffU) << 8) | \ > - (((__u16)(__x) & (__u16)0xff00U) >> 8) )); \ > -}) > - > -#define ___swab32(x) \ > -({ \ > - __u32 __x =3D (x); \ > - ((__u32)( \ > - (((__u32)(__x) & (__u32)0x000000ffUL) << 24) | \ > - (((__u32)(__x) & (__u32)0x0000ff00UL) << 8) | \ > - (((__u32)(__x) & (__u32)0x00ff0000UL) >> 8) | \ > - (((__u32)(__x) & (__u32)0xff000000UL) >> 24) )); \ > -}) > - > -#define ___swab64(x) = \ > -({ = \ > - __u64 __x =3D (x); = \ > - ((__u64)( = \ > - (__u64)(((__u64)(__x) & (__u64)0x00000000000000ffULL) << 56) | = \ > - (__u64)(((__u64)(__x) & (__u64)0x000000000000ff00ULL) << 40) | = \ > - (__u64)(((__u64)(__x) & (__u64)0x0000000000ff0000ULL) << 24) | = \ > - (__u64)(((__u64)(__x) & (__u64)0x00000000ff000000ULL) << 8) | = \ > - (__u64)(((__u64)(__x) & (__u64)0x000000ff00000000ULL) >> 8)= | \ > - (__u64)(((__u64)(__x) & (__u64)0x0000ff0000000000ULL) >> 24) | = \ > - (__u64)(((__u64)(__x) & (__u64)0x00ff000000000000ULL) >> 40) | = \ > - (__u64)(((__u64)(__x) & (__u64)0xff00000000000000ULL) >> 56) ));= \ > -}) > - > -#define ___constant_swab16(x) \ > - ((__u16)( \ > - (((__u16)(x) & (__u16)0x00ffU) << 8) | \ > - (((__u16)(x) & (__u16)0xff00U) >> 8) )) > -#define ___constant_swab32(x) \ > - ((__u32)( \ > - (((__u32)(x) & (__u32)0x000000ffUL) << 24) | \ > - (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \ > - (((__u32)(x) & (__u32)0x00ff0000UL) >> 8) | \ > - (((__u32)(x) & (__u32)0xff000000UL) >> 24) )) > -#define ___constant_swab64(x) = \ > - ((__u64)( = \ > - (__u64)(((__u64)(x) & (__u64)0x00000000000000ffULL) << 56) | = \ > - (__u64)(((__u64)(x) & (__u64)0x000000000000ff00ULL) << 40) | = \ > - (__u64)(((__u64)(x) & (__u64)0x0000000000ff0000ULL) << 24) | = \ > - (__u64)(((__u64)(x) & (__u64)0x00000000ff000000ULL) << 8) | = \ > - (__u64)(((__u64)(x) & (__u64)0x000000ff00000000ULL) >> 8) |= \ > - (__u64)(((__u64)(x) & (__u64)0x0000ff0000000000ULL) >> 24) | = \ > - (__u64)(((__u64)(x) & (__u64)0x00ff000000000000ULL) >> 40) | = \ > - (__u64)(((__u64)(x) & (__u64)0xff00000000000000ULL) >> 56) )) > - > -/* > - * provide defaults when no architecture-specific optimization is detect= ed > - */ > -#ifndef __arch__swab16 > -# define __arch__swab16(x) ({ __u16 __tmp =3D (x) ; ___swab16(__tmp); }= ) > -#endif > -#ifndef __arch__swab32 > -# define __arch__swab32(x) ({ __u32 __tmp =3D (x) ; ___swab32(__tmp); }= ) > -#endif > -#ifndef __arch__swab64 > -# define __arch__swab64(x) ({ __u64 __tmp =3D (x) ; ___swab64(__tmp); }= ) > -#endif > - > -#ifndef __arch__swab16p > -# define __arch__swab16p(x) __arch__swab16(*(x)) > -#endif > -#ifndef __arch__swab32p > -# define __arch__swab32p(x) __arch__swab32(*(x)) > -#endif > -#ifndef __arch__swab64p > -# define __arch__swab64p(x) __arch__swab64(*(x)) > -#endif > - > -#ifndef __arch__swab16s > -# define __arch__swab16s(x) do { *(x) =3D __arch__swab16p((x)); } while= (0) > -#endif > -#ifndef __arch__swab32s > -# define __arch__swab32s(x) do { *(x) =3D __arch__swab32p((x)); } while= (0) > -#endif > -#ifndef __arch__swab64s > -# define __arch__swab64s(x) do { *(x) =3D __arch__swab64p((x)); } while= (0) > -#endif > - > - > -/* > - * Allow constant folding > - */ > -#if defined(__GNUC__) && defined(__OPTIMIZE__) > -# define __swab16(x) \ > -(__builtin_constant_p((__u16)(x)) ? \ > - ___swab16((x)) : \ > - __fswab16((x))) > -# define __swab32(x) \ > -(__builtin_constant_p((__u32)(x)) ? \ > - ___swab32((x)) : \ > - __fswab32((x))) > -# define __swab64(x) \ > -(__builtin_constant_p((__u64)(x)) ? \ > - ___swab64((x)) : \ > - __fswab64((x))) > -#else > -# define __swab16(x) __fswab16(x) > -# define __swab32(x) __fswab32(x) > -# define __swab64(x) __fswab64(x) > -#endif /* OPTIMIZE */ > - > - > -static inline __attribute_const__ __u16 __fswab16(__u16 x) > -{ > - return __arch__swab16(x); > -} > -static inline __u16 __swab16p(const __u16 *x) > -{ > - return __arch__swab16p(x); > -} > -static inline void __swab16s(__u16 *addr) > -{ > - __arch__swab16s(addr); > -} > - > -static inline __attribute_const__ __u32 __fswab32(__u32 x) > -{ > - return __arch__swab32(x); > -} > -static inline __u32 __swab32p(const __u32 *x) > -{ > - return __arch__swab32p(x); > -} > -static inline void __swab32s(__u32 *addr) > -{ > - __arch__swab32s(addr); > -} > - > -#ifdef __BYTEORDER_HAS_U64__ > -static inline __attribute_const__ __u64 __fswab64(__u64 x) > -{ > -# ifdef __SWAB_64_THRU_32__ > - __u32 h =3D x >> 32; > - __u32 l =3D x & ((1ULL<<32)-1); > - return (((__u64)__swab32(l)) << 32) | ((__u64)(__swab32(h))); > -# else > - return __arch__swab64(x); > -# endif > -} > -static inline __u64 __swab64p(const __u64 *x) > -{ > - return __arch__swab64p(x); > -} > -static inline void __swab64s(__u64 *addr) > -{ > - __arch__swab64s(addr); > -} > -#endif /* __BYTEORDER_HAS_U64__ */ > - > -#define swab16 __swab16 > -#define swab32 __swab32 > -#define swab64 __swab64 > -#define swab16p __swab16p > -#define swab32p __swab32p > -#define swab64p __swab64p > -#define swab16s __swab16s > -#define swab32s __swab32s > -#define swab64s __swab64s > - > -#endif /* __XEN_BYTEORDER_SWAB_H__ */ > -- > 2.27.0 >=20 From xen-devel-bounces@lists.xenproject.org Tue May 24 03:25:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 03:25:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336134.560449 (Exim 4.92) (envelope-from ) id 1ntLA8-0008F9-Qk; Tue, 24 May 2022 03:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336134.560449; Tue, 24 May 2022 03:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLA8-0008F2-Nb; Tue, 24 May 2022 03:24:48 +0000 Received: by outflank-mailman (input) for mailman id 336134; Tue, 24 May 2022 03:24:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLA7-0008Es-Dw; Tue, 24 May 2022 03:24:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLA7-0005fP-9h; Tue, 24 May 2022 03:24:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLA6-0000oZ-Nr; Tue, 24 May 2022 03:24:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntLA6-0008U5-NQ; Tue, 24 May 2022 03:24:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MrFK0+HN/KPhe5WSLPmNE+xHJe49mGAsPmqIjJ4roG8=; b=3kku0WEuGXqUrnrn0DpFmUnYM4 dOcsQUri8IYsxZqyHq2UIsS2joYbD4N2oa+/NTidPgRL7jBKok0Xom3PsZRu7USuxXuPMUZZPvFdX EZ825s0w0f6tKYZJlQdzDVH+nRUeWDlYWN94aJVXArwcy5i6S1rPAoyUATz/8Q8U4etc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170711: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1e57930e9f4083ad5854ab6eadffe790a8167fb4 X-Osstest-Versions-That: linux=4b0986a3613c92f4ec1bdc7f60ec66fea135991f From: osstest service owner Date: Tue, 24 May 2022 03:24:46 +0000 flight 170711 linux-linus real [real] flight 170713 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170711/ http://logs.test-lab.xenproject.org/osstest/logs/170713/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170713-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170684 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170684 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170684 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170684 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170684 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170684 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170684 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170684 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 1e57930e9f4083ad5854ab6eadffe790a8167fb4 baseline version: linux 4b0986a3613c92f4ec1bdc7f60ec66fea135991f Last test of basis 170684 2022-05-23 00:41:51 Z 1 days Testing same since 170711 2022-05-23 19:39:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akira Yokosawa Alexander Aring Ammar Faizi Ard Biesheuvel Bagas Sanjaya Baskov Evgeniy Chunwei Lu David Vernet Dov Murik Eric Dumazet Frederic Weisbecker Hyeonggon Yoo <42.hyeyoo@gmail.com> Jan Kiszka Javier Martinez Canillas Kalesh Singh kernel test robot Kyle Lin Linus Torvalds Lukas Bulwahn Lulu Wang Masami Hiramatsu Neeraj Upadhyay Padmanabha Srinivasaiah Palmer Dabbelt Paul E. McKenney Paul Menzel Peter Jones Peter Zijlstra (Intel) Sebastian Andrzej Siewior Sunil V L Uladzislau Rezki (Sony) Uladzislau Rezki Valentin Schneider Willy Tarreau Zhouyi Zhou Zqiang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4b0986a3613c..1e57930e9f40 1e57930e9f4083ad5854ab6eadffe790a8167fb4 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue May 24 03:39:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 03:39:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336140.560460 (Exim 4.92) (envelope-from ) id 1ntLOW-0001Zy-4y; Tue, 24 May 2022 03:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336140.560460; Tue, 24 May 2022 03:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLOW-0001Zr-1p; Tue, 24 May 2022 03:39:40 +0000 Received: by outflank-mailman (input) for mailman id 336140; Tue, 24 May 2022 03:39:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntLOU-0001Zf-Lm for xen-devel@lists.xenproject.org; Tue, 24 May 2022 03:39:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7e1b::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 217f06b7-db13-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 05:39:36 +0200 (CEST) Received: from AM7PR03CA0020.eurprd03.prod.outlook.com (2603:10a6:20b:130::30) by DB9PR08MB6377.eurprd08.prod.outlook.com (2603:10a6:10:259::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 03:39:32 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::e2) by AM7PR03CA0020.outlook.office365.com (2603:10a6:20b:130::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Tue, 24 May 2022 03:39:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 03:39:31 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 03:39:31 +0000 Received: from 345f871bd50d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E12282F-37BB-449F-954A-FBA8D07442A1.1; Tue, 24 May 2022 03:39:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 345f871bd50d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 03:39:21 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB6758.eurprd08.prod.outlook.com (2603:10a6:20b:39a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Tue, 24 May 2022 03:39:18 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Tue, 24 May 2022 03:39:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 217f06b7-db13-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SZtki8n0Q5iSYvCKDtVErz83ns6FQ+03uEJRr3wadO/f9fh1IGiStOjnc1xaRdtIsRQDSs6KpaKEtt1ltjsnGGMZiT7tOL8wOIJhTr53YgakVAdHfWMiHdypJcFNLvw/ckh2gUVz85LMTjhlzQ3StCvntRI3keHV16NO1MN3bUOQOeZPAKMlhpCCQfNGMRnzHT8FnUC2GaAX7e74emdl969LYAvRW6l0uKdZsVl1tjAYw5PfLPmoYCBvy9KNGPWgFg2u6wFhce3pqOIewVrQks/mNXPZdT8cfTnVDZd14L5KmUvsZry25Dn+yiHKZX8+FLUq5W4wEbBtOez7GZ5fHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7j5+e8nvvx8Iz1kQEQ2og9dWLYJPFNkP1BWFq1A/U+U=; b=d6nSELZf/JT/XCQKfrtbiUctQWoY+orW1XowE6COLVDL7VrtKTB3DZUquBH+4uEGyyoieLKmUiW/WbQy7VagWbzI25tZXh35vTyS26lhLWJeANV7QBFnOClkdCAun/9Zf1H5DimUn4CK79NX29lw9Zmb5Vn8ksD1E0w06wZzxKK+39WSUo6sMdFjrPC/1t4q/xUZHqNshR0/0itelca3znNvVogVPlhfMJ6zXst93TtQa1dNk/FdeJQ83hbwkoWWOdWx6XHSSk0Yo5iP3/aKGka6lnOoI2BNNPWe5RaN27K8+ThkQ1MGFMh6BdQsfFy32nzw1QSki8TBvj8i/IH2Hg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7j5+e8nvvx8Iz1kQEQ2og9dWLYJPFNkP1BWFq1A/U+U=; b=F97IPcuXnA7mMuDQv7Pyze4qQUoA2aWNlMFC2mV1C17cewKgh9XZjN54O1KLv7QYUv6S/skKOGr4+4THJ5W65acN4xBxL6hq79be65uCGCVJqsg4FbSNUMbuGzKJwjeNLkE3k0OwjYLr+UnaSj6qdMs2jjGt2ql2UbqDjIkIz6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uxh1PmNhwEk7KtcnSulwAD4eUXpl21qGdkqsoaBXI8IDcOTuD0aEjrtBBvMxn+8qLLk+h+96ZSsZt63B9dfPbpYlkIfos03eKMQ+Az+mNPz8tvsVzMJhYQqkxc5cGxYx6top1eloIsfSwg7k0l+IAB65e04ChZfvqKhlT0DKwI6Tj6I4jxSSoiXIUtvH6v4Pci+pSOukUMR36eoxime00SYk6K2HNZB0PxZcvf+C1wTeeKqRDUbROxR1QDha0eWCM7ESW1dxx3mYsi7SpI/NNSfSeB/oPzgaWvIErVLPKM1lk7ethsoqOsbfNchrnBu92TBh/5MyX/E60CTZr3nhww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7j5+e8nvvx8Iz1kQEQ2og9dWLYJPFNkP1BWFq1A/U+U=; b=j9XAsFp6tB6eSK7I6qLKrBsaW4ohVmXrNegqVb3+4r0opOuWzjNEUiONjjp8fhNHWcEIbKcKky3ED4FES4GbLPIrFpbCWMugkp+AmEpLpR5FuDG1XO3zA0wy6UFEyYWiqQPvMyILuNPOXNnINn/l+ctNz2t8bs5DfSglWEKIONe7CnA9AiQtaiDBHi2T6tgMp9Bgq/3ehth5r4o26Ga5LrlHzLWKsZjmwZxfzv0GB4ruEv8Tz/CNVFjyS0828AHFtAHM1aTHoQVjHRIgbOeQOAcG2eLig6KG0z+7hozomQr7W84MOfsJ5/7ahJs9b6NOVrRhA4qV3int6ENFe4UziA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7j5+e8nvvx8Iz1kQEQ2og9dWLYJPFNkP1BWFq1A/U+U=; b=F97IPcuXnA7mMuDQv7Pyze4qQUoA2aWNlMFC2mV1C17cewKgh9XZjN54O1KLv7QYUv6S/skKOGr4+4THJ5W65acN4xBxL6hq79be65uCGCVJqsg4FbSNUMbuGzKJwjeNLkE3k0OwjYLr+UnaSj6qdMs2jjGt2ql2UbqDjIkIz6c= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: RE: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYbt50tGidbD5g50ygNS2KCABD4q0tYcLA Date: Tue, 24 May 2022 03:39:18 +0000 Message-ID: References: <20220523194953.70636-1-julien@xen.org> In-Reply-To: <20220523194953.70636-1-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F6B82C075C64124CAC9065EA26B05892.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b0fd1fd7-b27a-44ae-8e3d-08da3d370367 x-ms-traffictypediagnostic: AS8PR08MB6758:EE_|VE1EUR03FT052:EE_|DB9PR08MB6377:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RtbvKUGGj9r6Tpn3Ul6tpTiO7W30au/5G/Dox5gyHfINboGCnGdziCKx7l1sx+ojI9dceLZEgIOqpJ+y6dqbb7Tfc0H5znJT0uCSQ/1ym352qCYaaHpWipkZncNAasY4I0pGq6/A1RkhNGKwCY2U//fI/bmzjTwVRpwKJKrl1dIR5SUQEuCsGRpSQZkxfGukNgpJhMyg3SopWg88WXqATb9i6gXJWUrvkLZas/AUZOYEeJ6Bd1BRm13nFxeJJ2ZpeRQCjnns8x3cYC4/WI5/y9DIwkAi2u+9r6ONZyTV0zHZ7zGPmVqeBRl47EbBw0t4TpWknK13V0LgTDdp1488MPGsQUIimieN8IN+EM2cyOKjJsTbIiGJyAZqZ/PowI+vOvkxgMM1LsHvIA3Lc9Ud1+mYs26syD/AYhZN477QrT21TnANQIO3o6DICu5jrAoEM2CABD4zc0T5nEi2ohYwEAN/hQ+skbL2Q0VQ3b5MSWQtGXzkxUkf0N9eqXBTtBx9ZlyLH+Htez+eN07tqKRzMmPnZLotiiOBdI+vO11YMi3N9eZB3pAFpukmEIt5XuJvGoXObZhbxT+f/fj2iB0oOfSbNZkeYBN626wWelAwRozn3fkIuABRzqIBJjpOcz8oSalNEAKfO2BvnKOGfzbXbSP6ig1SnJeHqqreI2Zupdv6QzZfQLuevIWNqzZPpdwF9t3qNlOapBTqWPgkSayyzQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(9686003)(316002)(122000001)(4326008)(54906003)(52536014)(8936002)(5660300002)(38100700002)(110136005)(8676002)(64756008)(66556008)(66476007)(66946007)(66446008)(38070700005)(86362001)(53546011)(76116006)(6506007)(2906002)(33656002)(55016003)(83380400001)(7696005)(71200400001)(508600001)(26005)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6758 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 53fd10c2-ea02-4639-7c00-08da3d36fb9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SP9LrtQRCYrv9+BCooExU2NfGp9NYBxV2iPieKKahCNBQvhjmjKAppu+5QmZY6b+alhJOssWjut8jhy7GvHbC2wl95x/YIgYIUQPcarE99Svuux/ZaGVWlvnFJ1gDejyAfEES2JE7+X9mBfiJlFdDQOkHum6yUB4TJ1nvpdYT+fl6eqEiKYsXa76Z8DsFHHhlC14eOFqqfjcY+/F3ED8gQaD/qJ7vHCgHCpsaS/W7khqvXXL/ccItUP+strVYklYdDtl3G7dcbQd/P93F4QTtFYnqEu/R5cZosRy+TnUPIonERoWP1ZWnqU6tqWC1fbQX/0C995WrIO15BaF+prcP1ZXEnyQG5oWDxube2AbasF/tP2OhPDKVpkEkPTSucTVaVB3nHIBFqEfdITAOsg4L6thMuhi4GS9t+glXDrn2hZ5fiaLYky1+qBaLVignSBLnaJOJfeEac+B/K5Pe/Uh+2waFrN37W/0P/NKnLQeGp6FHtwRZ36cZpUADFIOrk7GmMkKfv9jMYyyTfkrrf0f9ycu+FJq/uGd9U8Vvn0a5Ws4EmoYnIWb4tf94GEfFA0AAUszkF0VdmsiTUzpXGmY5rhAyoNVnXlDHwog5Lw7v5qOUCsqiCBs2iT2HjnH/i1wp3l1u+8NR3qU0PqOLZruESEHeY9bkhgATCiMLZKg6h4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70586007)(70206006)(110136005)(336012)(52536014)(83380400001)(8936002)(508600001)(53546011)(82310400005)(186003)(55016003)(6506007)(33656002)(2906002)(81166007)(107886003)(5660300002)(8676002)(4326008)(356005)(26005)(316002)(9686003)(40460700003)(7696005)(86362001)(36860700001)(47076005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 03:39:31.4512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0fd1fd7-b27a-44ae-8e3d-08da3d370367 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6377 KHJlc2VuZCBhZ2Fpbiwgc2VlbXMgdGhlIGZpcnN0IG9uZSBpcyBmYWlsZWQpDQoNCj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRldmVsIDx4ZW4tZGV2ZWwtYm91bmNl c0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+IEp1bGllbiBHcmFsbA0KPiBT ZW50OiAyMDIyxOo11MIyNMjVIDM6NTANCj4gVG86IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZw0KPiBDYzoganVsaWVuQHhlbi5vcmc7IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5j b20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0 cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFi Y2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBLb25yYWQgUnplc3p1dGVrIFdpbGsN Cj4gPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+OyBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndh bGxAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIXSB4ZW4vYXJtOiBSZW1vdmUgbW9zdCBv ZiB0aGUgKl9WSVJUX0VORCBkZWZpbmVzDQo+IA0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGpncmFs bEBhbWF6b24uY29tPg0KPiANCj4gQXQgdGhlIG1vbWVudCwgKl9WSVJUX0VORCBtYXkgZWl0aGVy IHBvaW50IHRvIHRoZSBhZGRyZXNzIGFmdGVyIHRoZSBlbmQNCj4gb3IgdGhlIGxhc3QgYWRkcmVz cyBvZiB0aGUgcmVnaW9uLg0KPiANCj4gVGhlIGxhY2sgb2YgY29uc2lzdGVuY3kgbWFrZSBxdWl0 ZSBkaWZmaWN1bHQgdG8gcmVhc29uIHdpdGggdGhlbS4NCj4gDQo+IEZ1cnRoZXJtb3JlLCB0aGVy ZSBpcyBhIHJpc2sgb2Ygb3ZlcmZsb3cgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIGFkZHJlc3MNCj4g cG9pbnRzIHBhc3QgdG8gdGhlIGVuZC4gSSBhbSBub3QgYXdhcmUgb2YgYW55IGNhc2VzLCBzbyB0 aGlzIGlzIG9ubHkgYQ0KPiBsYXRlbnQgYnVnLg0KPiANCj4gU3RhcnQgdG8gc29sdmUgdGhlIHBy b2JsZW0gYnkgcmVtb3ZpbmcgYWxsIHRoZSAqX1ZJUlRfRU5EIGV4Y2x1c2l2ZWx5IHVzZWQNCj4g YnkgdGhlIEFybSBjb2RlIGFuZCBhZGQgKl9WSVJUX1NJWkUgd2hlbiBpdCBpcyBub3QgcHJlc2Vu dC4NCj4gDQo+IFRha2UgdGhlIG9wcG9ydHVuaXR5IHRvIHJlbmFtZSBCT09UX0ZEVF9TTE9UX1NJ WkUgdG8gQk9PVF9GRFRfVklSVF9TSVpFDQo+IGZvciBiZXR0ZXIgY29uc2lzdGVuY3kgYW5kIHVz ZSBfQVQodmFkZHJfdCwgKS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdy YWxsQGFtYXpvbi5jb20+DQo+IA0KPiAtLS0tDQo+IA0KPiBJIG5vdGljZWQgdGhhdCBhIGZldyBm dW5jdGlvbnMgaW4gWGVuIGV4cGVjdCBbc3RhcnQsIGVuZFsuIFRoaXMgaXMgcmlza3kNCj4gYXMg d2UgbWF5IGVuZCB1cCB3aXRoIGVuZCA8IHN0YXJ0IGlmIHRoZSByZWdpb24gaXMgZGVmaW5lZCBy aWdodCBhdCB0aGUNCj4gdG9wIG9mIHRoZSBhZGRyZXNzIHNwYWNlLg0KPiANCj4gSSBoYXZlbid0 IHlldCB0YWNrbGUgdGhpcyBpc3N1ZS4gQnV0IEkgd291bGQgYXQgbGVhc3QgbGlrZSB0byBnZXQg cmlkDQo+IG9mICpfVklSVF9FTkQuDQo+IC0tLQ0KPiAgeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2NvbmZpZy5oIHwgMTggKysrKysrKystLS0tLS0tLS0tDQo+ICB4ZW4vYXJjaC9hcm0vbGl2ZXBh dGNoLmMgICAgICAgICAgfCAgMiArLQ0KPiAgeGVuL2FyY2gvYXJtL21tLmMgICAgICAgICAgICAg ICAgIHwgMTMgKysrKysrKystLS0tLQ0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25z KCspLCAxNiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5j bHVkZS9hc20vY29uZmlnLmgNCj4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgN Cj4gaW5kZXggM2UyYTU1YTkxMDU4Li42NmRiNjE4YjM0ZTcgMTAwNjQ0DQo+IC0tLSBhL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWcuaA0KPiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVk ZS9hc20vY29uZmlnLmgNCj4gQEAgLTExMSwxMiArMTExLDExIEBADQo+ICAjZGVmaW5lIEZJWE1B UF9BRERSKG4pICAgICAgICAoX0FUKHZhZGRyX3QsMHgwMDQwMDAwMCkgKyAobikgKiBQQUdFX1NJ WkUpDQo+IA0KPiAgI2RlZmluZSBCT09UX0ZEVF9WSVJUX1NUQVJUICAgIF9BVCh2YWRkcl90LDB4 MDA2MDAwMDApDQo+IC0jZGVmaW5lIEJPT1RfRkRUX1NMT1RfU0laRSAgICAgTUIoNCkNCj4gLSNk ZWZpbmUgQk9PVF9GRFRfVklSVF9FTkQgICAgICAoQk9PVF9GRFRfVklSVF9TVEFSVCArIEJPT1Rf RkRUX1NMT1RfU0laRSkNCj4gKyNkZWZpbmUgQk9PVF9GRFRfVklSVF9TSVpFICAgICBfQVQodmFk ZHJfdCwgTUIoNCkpDQo+IA0KPiAgI2lmZGVmIENPTkZJR19MSVZFUEFUQ0gNCj4gICNkZWZpbmUg TElWRVBBVENIX1ZNQVBfU1RBUlQgICBfQVQodmFkZHJfdCwweDAwYTAwMDAwKQ0KPiAtI2RlZmlu ZSBMSVZFUEFUQ0hfVk1BUF9FTkQgICAgIChMSVZFUEFUQ0hfVk1BUF9TVEFSVCArIE1CKDIpKQ0K PiArI2RlZmluZSBMSVZFUEFUQ0hfVk1BUF9TSVpFICAgIF9BVCh2YWRkcl90LCBNQigyKSkNCj4g ICNlbmRpZg0KPiANCj4gICNkZWZpbmUgSFlQRVJWSVNPUl9WSVJUX1NUQVJUICBYRU5fVklSVF9T VEFSVA0KPiBAQCAtMTMyLDE4ICsxMzEsMTggQEANCj4gICNkZWZpbmUgRlJBTUVUQUJMRV9WSVJU X0VORCAgICAoRlJBTUVUQUJMRV9WSVJUX1NUQVJUICsgRlJBTUVUQUJMRV9TSVpFIC0NCj4gMSkN Cj4gDQo+ICAjZGVmaW5lIFZNQVBfVklSVF9TVEFSVCAgICAgICAgX0FUKHZhZGRyX3QsMHgxMDAw MDAwMCkNCj4gKyNkZWZpbmUgVk1BUF9WSVJUX1NJWkUgICAgICAgICBfQVQodmFkZHJfdCwgR0Io MSkgLSBNQigyNTYpKQ0KPiANCj4gICNkZWZpbmUgWEVOSEVBUF9WSVJUX1NUQVJUICAgICBfQVQo dmFkZHJfdCwweDQwMDAwMDAwKQ0KPiAtI2RlZmluZSBYRU5IRUFQX1ZJUlRfRU5EICAgICAgIF9B VCh2YWRkcl90LDB4N2ZmZmZmZmYpDQo+IC0jZGVmaW5lIERPTUhFQVBfVklSVF9TVEFSVCAgICAg X0FUKHZhZGRyX3QsMHg4MDAwMDAwMCkNCj4gLSNkZWZpbmUgRE9NSEVBUF9WSVJUX0VORCAgICAg ICBfQVQodmFkZHJfdCwweGZmZmZmZmZmKQ0KPiArI2RlZmluZSBYRU5IRUFQX1ZJUlRfU0laRSAg ICAgIF9BVCh2YWRkcl90LCBHQigxKSkNCj4gDQo+IC0jZGVmaW5lIFZNQVBfVklSVF9FTkQgICAg WEVOSEVBUF9WSVJUX1NUQVJUDQo+ICsjZGVmaW5lIERPTUhFQVBfVklSVF9TVEFSVCAgICAgX0FU KHZhZGRyX3QsMHg4MDAwMDAwMCkNCj4gKyNkZWZpbmUgRE9NSEVBUF9WSVJUX1NJWkUgICAgICBf QVQodmFkZHJfdCwgR0IoMikpDQo+IA0KPiAgI2RlZmluZSBET01IRUFQX0VOVFJJRVMgICAgICAg IDEwMjQgIC8qIDEwMjQgMk1CIG1hcHBpbmcgc2xvdHMgKi8NCj4gDQo+ICAvKiBOdW1iZXIgb2Yg ZG9taGVhcCBwYWdldGFibGUgcGFnZXMgcmVxdWlyZWQgYXQgdGhlIHNlY29uZCBsZXZlbCAoMk1C DQo+IG1hcHBpbmdzKSAqLw0KPiAtI2RlZmluZSBET01IRUFQX1NFQ09ORF9QQUdFUyAoKERPTUhF QVBfVklSVF9FTkQgLSBET01IRUFQX1ZJUlRfU1RBUlQgKw0KPiAxKSA+PiBGSVJTVF9TSElGVCkN Cj4gKyNkZWZpbmUgRE9NSEVBUF9TRUNPTkRfUEFHRVMgKERPTUhFQVBfVklSVF9TSVpFID4+IEZJ UlNUX1NISUZUKQ0KPiANCj4gICNlbHNlIC8qIEFSTV82NCAqLw0KPiANCj4gQEAgLTE1MiwxMiAr MTUxLDExIEBADQo+ICAjZGVmaW5lIFNMT1QwX0VOVFJZX1NJWkUgIFNMT1QwKDEpDQo+IA0KPiAg I2RlZmluZSBWTUFQX1ZJUlRfU1RBUlQgIEdCKDEpDQo+IC0jZGVmaW5lIFZNQVBfVklSVF9FTkQg ICAgKFZNQVBfVklSVF9TVEFSVCArIEdCKDEpKQ0KPiArI2RlZmluZSBWTUFQX1ZJUlRfU0laRSAg IEdCKDEpDQo+IA0KPiAgI2RlZmluZSBGUkFNRVRBQkxFX1ZJUlRfU1RBUlQgIEdCKDMyKQ0KPiAg I2RlZmluZSBGUkFNRVRBQkxFX1NJWkUgICAgICAgIEdCKDMyKQ0KPiAgI2RlZmluZSBGUkFNRVRB QkxFX05SICAgICAgICAgIChGUkFNRVRBQkxFX1NJWkUgLyBzaXplb2YoKmZyYW1lX3RhYmxlKSkN Cj4gLSNkZWZpbmUgRlJBTUVUQUJMRV9WSVJUX0VORCAgICAoRlJBTUVUQUJMRV9WSVJUX1NUQVJU ICsgRlJBTUVUQUJMRV9TSVpFIC0NCj4gMSkNCj4gDQo+ICAjZGVmaW5lIERJUkVDVE1BUF9WSVJU X1NUQVJUICAgU0xPVDAoMjU2KQ0KPiAgI2RlZmluZSBESVJFQ1RNQVBfU0laRSAgICAgICAgIChT TE9UMF9FTlRSWV9TSVpFICogKDI2NS0yNTYpKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt L2xpdmVwYXRjaC5jIGIveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jDQo+IGluZGV4IDc1ZThhZGNm ZDZhMS4uNTdhYmM3NDZlNjBiIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vbGl2ZXBhdGNo LmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jDQo+IEBAIC0xNzUsNyArMTc1LDcg QEAgdm9pZCBfX2luaXQgYXJjaF9saXZlcGF0Y2hfaW5pdCh2b2lkKQ0KPiAgICAgIHZvaWQgKnN0 YXJ0LCAqZW5kOw0KPiANCj4gICAgICBzdGFydCA9ICh2b2lkICopTElWRVBBVENIX1ZNQVBfU1RB UlQ7DQo+IC0gICAgZW5kID0gKHZvaWQgKilMSVZFUEFUQ0hfVk1BUF9FTkQ7DQo+ICsgICAgZW5k ID0gc3RhcnQgKyBMSVZFUEFUQ0hfVk1BUF9TSVpFOw0KPiANCj4gICAgICB2bV9pbml0X3R5cGUo Vk1BUF9YRU4sIHN0YXJ0LCBlbmQpOw0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9t bS5jIGIveGVuL2FyY2gvYXJtL21tLmMNCj4gaW5kZXggYmUzNzE3NmE0NzI1Li4wNjA3YzY1Zjk1 Y2QgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9tbS5jDQo+ICsrKyBiL3hlbi9hcmNoL2Fy bS9tbS5jDQo+IEBAIC0xMjgsOSArMTI4LDExIEBAIHN0YXRpYyBERUZJTkVfUEFHRV9UQUJMRSh4 ZW5fZmlyc3QpOw0KPiAgLyogeGVuX3BndGFibGUgPT0gcm9vdCBvZiB0aGUgdHJpZSAoemVyb2V0 aCBsZXZlbCBvbiA2NC1iaXQsIGZpcnN0IG9uIDMyLQ0KPiBiaXQpICovDQo+ICBzdGF0aWMgREVG SU5FX1BFUl9DUFUobHBhZV90ICosIHhlbl9wZ3RhYmxlKTsNCj4gICNkZWZpbmUgVEhJU19DUFVf UEdUQUJMRSB0aGlzX2NwdSh4ZW5fcGd0YWJsZSkNCj4gLS8qIHhlbl9kb21tYXAgPT0gcGFnZXMg dXNlZCBieSBtYXBfZG9tYWluX3BhZ2UsIHRoZXNlIHBhZ2VzIGNvbnRhaW4NCj4gKy8qDQo+ICsg KiB4ZW5fZG9tbWFwID09IHBhZ2VzIHVzZWQgYnkgbWFwX2RvbWFpbl9wYWdlLCB0aGVzZSBwYWdl cyBjb250YWluDQo+ICAgKiB0aGUgc2Vjb25kIGxldmVsIHBhZ2V0YWJsZXMgd2hpY2ggbWFwIHRo ZSBkb21oZWFwIHJlZ2lvbg0KPiAtICogRE9NSEVBUF9WSVJUX1NUQVJULi4uRE9NSEVBUF9WSVJU X0VORCBpbiAyTUIgY2h1bmtzLiAqLw0KPiArICogc3RhcnRpbmcgYXQgRE9NSEVBUF9WSVJUX1NU QVJUIGluIDJNQiBjaHVua3MuDQo+ICsgKi8NCj4gIHN0YXRpYyBERUZJTkVfUEVSX0NQVShscGFl X3QgKiwgeGVuX2RvbW1hcCk7DQo+ICAvKiBSb290IG9mIHRoZSB0cmllIGZvciBjcHUwLCBvdGhl ciBDUFUncyBQVHMgYXJlIGR5bmFtaWNhbGx5IGFsbG9jYXRlZA0KPiAqLw0KPiAgc3RhdGljIERF RklORV9QQUdFX1RBQkxFKGNwdTBfcGd0YWJsZSk7DQo+IEBAIC00NzYsNyArNDc4LDcgQEAgbWZu X3QgZG9tYWluX3BhZ2VfbWFwX3RvX21mbihjb25zdCB2b2lkICpwdHIpDQo+ICAgICAgaW50IHNs b3QgPSAodmEgLSBET01IRUFQX1ZJUlRfU1RBUlQpID4+IFNFQ09ORF9TSElGVDsNCj4gICAgICB1 bnNpZ25lZCBsb25nIG9mZnNldCA9ICh2YT4+VEhJUkRfU0hJRlQpICYgWEVOX1BUX0xQQUVfRU5U UllfTUFTSzsNCj4gDQo+IC0gICAgaWYgKCB2YSA+PSBWTUFQX1ZJUlRfU1RBUlQgJiYgdmEgPCBW TUFQX1ZJUlRfRU5EICkNCj4gKyAgICBpZiAoICh2YSA+PSBWTUFQX1ZJUlRfU1RBUlQpICYmICgo Vk1BUF9WSVJUX1NUQVJUIC0gdmEpIDwNCj4gVk1BUF9WSVJUX1NJWkUpICkNCj4gICAgICAgICAg cmV0dXJuIHZpcnRfdG9fbWZuKHZhKTsNCj4gDQo+ICAgICAgQVNTRVJUKHNsb3QgPj0gMCAmJiBz bG90IDwgRE9NSEVBUF9FTlRSSUVTKTsNCj4gQEAgLTU3MCw3ICs1NzIsOCBAQCB2b2lkIF9faW5p dCByZW1vdmVfZWFybHlfbWFwcGluZ3Modm9pZCkNCj4gICAgICBpbnQgcmM7DQo+IA0KPiAgICAg IC8qIGRlc3Ryb3kgdGhlIF9QQUdFX0JMT0NLIG1hcHBpbmcgKi8NCj4gLSAgICByYyA9IG1vZGlm eV94ZW5fbWFwcGluZ3MoQk9PVF9GRFRfVklSVF9TVEFSVCwgQk9PVF9GRFRfVklSVF9FTkQsDQo+ ICsgICAgcmMgPSBtb2RpZnlfeGVuX21hcHBpbmdzKEJPT1RfRkRUX1ZJUlRfU1RBUlQsDQo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJPT1RfRkRUX1ZJUlRfU1RBUlQgKyBCT09UX0ZE VF9WSVJUX1NJWkUsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9QQUdFX0JMT0NL KTsNCj4gICAgICBCVUdfT04ocmMpOw0KPiAgfQ0KPiBAQCAtODUwLDcgKzg1Myw3IEBAIHZvaWQg X19pbml0IHNldHVwX2ZyYW1ldGFibGVfbWFwcGluZ3MocGFkZHJfdCBwcywNCj4gcGFkZHJfdCBw ZSkNCj4gDQo+ICB2b2lkICpfX2luaXQgYXJjaF92bWFwX3ZpcnRfZW5kKHZvaWQpDQo+ICB7DQo+ IC0gICAgcmV0dXJuICh2b2lkICopVk1BUF9WSVJUX0VORDsNCj4gKyAgICByZXR1cm4gKHZvaWQg KikoVk1BUF9WSVJUX1NUQVJUICsgVk1BUF9WSVJUX1NJWkUpOw0KDQpJdCBzZWVtcyB5b3UgcHJl ZmVyIHRvIHBvaW50IF9lbmQgdG8gdGhlIGFkZHJlc3MgYWZ0ZXIgdGhlIGVuZC4gRXZlbg0KdGhv dWdoIHdlIGdvdCByaWQgb2YgdGhlIG1hY3JvIGRlZmluaXRpb24gb2YgX0VORC4gQnV0IHdlIGRp ZG4ndCBhZ3JlZQ0Kb24gaG93IHRvIHVzZSBpdC4gRm9yIG1lLCB3aGVuIEkgZmlyc3Qgc2F3DQoi ZW5kID0gc3RhcnQgKyBMSVZFUEFUQ0hfVk1BUF9TSVpFIiBJIHN1YmNvbnNjaW91c2x5IHRoaW5r IHRoZSAtMSBpcw0KbWlzc2luZyBoZXJlLiBJIGV2ZW4gYWRkZWQgYSBjb21tZW50LCBidXQgcmVt b3ZlZCBpdCB3aGVuIEkgcmVhY2hlZA0KdG8gdGhpcyBsaW5lIDogKQ0KTWF5IGJlIGl0J3MgYmV0 dGVyIHRvIHBsYWNlIHNvbWUgY29kZSBndWlkZSBmb3IgRU5EIGluIGNvZGUgY29tbWVudA0KaW4g dGhlIFNJWkUgZGVmaW5pdGlvbiwgb3RoZXJ3aXNlLCB3ZSBtYXkgaGF2ZSBkaWZmZXJlbnQgcG9p bnQgYWRkcmVzc2VzDQpvZiBfZW5kIGZ1bmN0aW9ucy4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0K PiAgfQ0KPiANCj4gIC8qDQo+IC0tDQo+IDIuMzIuMA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Tue May 24 04:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 04:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336147.560470 (Exim 4.92) (envelope-from ) id 1ntM8m-0007oC-QT; Tue, 24 May 2022 04:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336147.560470; Tue, 24 May 2022 04:27:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntM8m-0007o5-NF; Tue, 24 May 2022 04:27:28 +0000 Received: by outflank-mailman (input) for mailman id 336147; Tue, 24 May 2022 04:27:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntM8l-0007nz-2Q for xen-devel@lists.xenproject.org; Tue, 24 May 2022 04:27:27 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf3eb72d-db19-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 06:27:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 889E4613CA; Tue, 24 May 2022 04:27:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id EB8F8C36AE5; Tue, 24 May 2022 04:27:22 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id D5F42F03938; Tue, 24 May 2022 04:27:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf3eb72d-db19-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653366443; bh=YWdB8/Incye7PGPIuU1l6D/SUgnj0rEJksuUsdYNgS0=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=gfJIFSv0Pi9cG72ePpJcDJ+SNwz6qGj3HuHRzyAOlfHuvvegNXPnxmFcgnQuFv7lo iURcDll5Xe+3ZC8z64aw+Id70rjqYQ5ituWzRKQqrdmMrdzGwkWNR6Czb8IAzRmVlO 9VcC7r7e4ww8zb6P/B0nb/ldh0ICz3mbAfeAD/Ttr77LtoGUoDd0hDe16Q+RLKotym hXjeLs3sBkGGjy+xsp0/olD+RbOpOuFUXmbV8HN+GmjRs8OY52qhZ0aOmo16hljl5o FJyu8ilnPaGRRmdBjQYozS8lOdc2EE3ox4rcReBizocoT7bjosjToxBLkfSFroH0A3 PAGkQDRnq09QQ== Subject: Re: [GIT PULL] xen: branch for v5.19-rc1 From: pr-tracker-bot@kernel.org In-Reply-To: <20220523053104.22814-1-jgross@suse.com> References: <20220523053104.22814-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20220523053104.22814-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19-rc1-tag X-PR-Tracked-Commit-Id: 5b3353949e89d48b4faf54a9cc241ee5d70df615 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: d61306047533eb6f63a7bd51dfa7f868503bf0ba Message-Id: <165336644287.29742.1454436360715375036.pr-tracker-bot@kernel.org> Date: Tue, 24 May 2022 04:27:22 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Mon, 23 May 2022 07:31:04 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d61306047533eb6f63a7bd51dfa7f868503bf0ba Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Tue May 24 06:13:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 06:13:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336152.560482 (Exim 4.92) (envelope-from ) id 1ntNmm-0002BX-Cp; Tue, 24 May 2022 06:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336152.560482; Tue, 24 May 2022 06:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntNmm-0002BQ-86; Tue, 24 May 2022 06:12:52 +0000 Received: by outflank-mailman (input) for mailman id 336152; Tue, 24 May 2022 06:12:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntNml-0002BK-OE for xen-devel@lists.xenproject.org; Tue, 24 May 2022 06:12:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8958a853-db28-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 08:12:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B91B23A; Mon, 23 May 2022 23:12:48 -0700 (PDT) Received: from [10.57.2.178] (unknown [10.57.2.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B07CC3F66F; Mon, 23 May 2022 23:12:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8958a853-db28-11ec-bd2c-47488cf2e6aa Message-ID: Date: Tue, 24 May 2022 08:12:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-14-julien@xen.org> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23.05.2022 21:51, Julien Grall wrote: > > > On 23/05/2022 08:28, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> >> On 20.05.2022 14:09, Julien Grall wrote: >>> From: Julien Grall >>> >>> In a follow-up patch, we will want to populate the boot allocator >>> separately for arm64. The code will end up to be very similar to the one >>> on arm32. So move out the code in a new helper populate_boot_allocator(). >>> >>> For now the code is still protected by CONFIG_ARM_32 to avoid any build >>> failure on arm64. >>> >>> Take the opportunity to replace mfn_add(xen_mfn_start, xenheap_pages) with >>> xenheap_mfn_end as they are equivalent. >>> >>> Signed-off-by: Julien Grall >>> >>> --- >>> >>>      Changes in v4: >>>          - Patch added >>> --- >>>   xen/arch/arm/setup.c | 90 +++++++++++++++++++++++++------------------- >>>   1 file changed, 51 insertions(+), 39 deletions(-) >>> >>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >>> index d5d0792ed48a..3d5a2283d4ef 100644 >>> --- a/xen/arch/arm/setup.c >>> +++ b/xen/arch/arm/setup.c >>> @@ -637,10 +637,58 @@ static void __init init_staticmem_pages(void) >>>   } >>>     #ifdef CONFIG_ARM_32 >>> +/* >>> + * Populate the boot allocator. All the RAM but the following regions >>> + * will be added: >>> + *  - Modules (e.g., Xen, Kernel) >>> + *  - Reserved regions >>> + *  - Xenheap >>> + */ >>> +static void __init populate_boot_allocator(void) >>> +{ >>> +    unsigned int i; >> Shouldn't this be an int (as it was previously) because ... >>> +    const struct meminfo *banks = &bootinfo.mem; >>> + >>> +    for ( i = 0; i < banks->nr_banks; i++ ) >> ... nr_banks is int ? > > Hmmm... AFAIK banks->nr_banks never hold a negative value, so I am not sure why it was introduced as an "int". > > Looking through the code, we seem to have a mix of "unsigned int" and "int". There seem to be less on the latter, so I have sent a patch to switch nr_banks to "unsigned int" [1]. That's great, thanks. > > This is based on this series thought and I would like to keep the "unsigned int" here. > >> >> Apart from that: >> Reviewed-by: Michal Orzel > > Thanks! Please let me know if this reviewed-by hold. Definitely yes. > > Cheers, > > [1] https://lore.kernel.org/xen-devel/20220523194631.66262-1-julien@xen.org > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 24 07:18:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336160.560493 (Exim 4.92) (envelope-from ) id 1ntOnk-00005Y-8T; Tue, 24 May 2022 07:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336160.560493; Tue, 24 May 2022 07:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntOnk-00005R-3I; Tue, 24 May 2022 07:17:56 +0000 Received: by outflank-mailman (input) for mailman id 336160; Tue, 24 May 2022 07:17:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntOni-00005I-Oo for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:17:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d0d815c-db31-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 09:17:51 +0200 (CEST) Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 03:17:31 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by CO2PR03MB2312.namprd03.prod.outlook.com (2603:10b6:102:f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.21; Tue, 24 May 2022 07:17:29 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 07:17:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d0d815c-db31-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653376671; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=tPTtfBngsBJNCa6FSVVck9zGbD4fS21cE+XTrh4m/ZU=; b=EuJkua7enw8+yAyE9vWfQS3RWRPnwYcMYFGT3wXZdhwCWc5CNP1gzfoP iwmAikPebtBevrS1wyap2qa4uqPYsG7cMLDWUiLZ9R8czLKrEmIYMIr+L oUKKUdern/c5KpD2Iz2ap2WnqVeaXUmjm1F44L36W5nmFxsUUE1QDPZhv Y=; X-IronPort-RemoteIP: 104.47.58.170 X-IronPort-MID: 72018911 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gomSK6+Mamdu2wOEafMiDrUDhH+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2UZDG3SP6qDamH8et90O4q+oE4DsMLUzdZiSFZvqXw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3ILlW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnYfvRSxyDPGLod02UQtWTj1gGLxh5KCSdBBTseTLp6HHW13F5qw3SWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIAAtNszrpkm8fL2Y 8sfLz5ucTzLYgFVO0dRA5U79AutrialK2QI+QvMzUYxy2LPi1FAgKrTCof6dYbQGsdbhRe4g X2TqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqEKX7nweDlsRT1TTifu2kEmlQPpEN lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWblXoVRZEYd0i8cUwFToj0 wbQm8uzXGM39rqIVXia67GY6yuoPjQYJnMDYilCShYZ597ko8c4iRenostfLZNZR+bdQVnYq w1mZgBn2t3/UeZjO32HwG36 IronPort-HdrOrdr: A9a23:AzDw86y0AD+zLEOKw2yDKrPxmeskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LPEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77W3ADvXzJmZXf3CP0AwfeC8o/g9ieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou W1bLp1jx9CR6u1M7zx4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208,217";a="72018911" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lvfRtHLKM3M0nsfN7nlop8umOOUChC5XIZJAmNVkXX9LTg2TmhVkiMpdsj76DVyqEqUBXvQcBGBLL2DMYnfrg8kWNjacdzcqgvN9Arbpp4oIShGU6DJUikV9JntMRUZ8WiSqiSGPmMbuTOBkGWpfBJTP2qEiytjx9ucadySI6fmIfRgk+7HvZezkJVReXJafZj4U31w95OGrwqNP6+enR0NFOiuaqs0hx/nTEEloLatxRvLzuEeiw+KJz53+kMywuSRMq+3kxhpgUoC2q0RUUUw9oeFAtxzg6EuchUXPa6YrFH97+XbTdmAw30zd/JNbtvqdKmSNv9Bn7ieaa7jHBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0izKH5PMYIealPbWPMgRyf/l66qfZwBknEdH22WkKk=; b=nN/Bvi21cMnDYStDydYDjxlh7IO8v6+/XtzpliLlzgDqwjUt85uFU1gczzI0UlOrryklXAXoPFTwVHuoQIihUaBdUTiql4YW14kpWq8rcNwGbmOlKSQQb0/ZDtVXviT4Kkh918fvnxvdos1qvOSYHZBOhT8nFgRyr1/4FMWEw6vK2Aqpmjki9A2h2FmAMb13ugAK1dq+Y/hpc8oG/+7o2aodNsQ+9hooVH5U8GomV8VRtrGGeVPrjOMZUEW5PMBItAr8FvF/4iZwF0we2qcqnmnmptgoC84nXKmL9Sh1gH70FLfSQxZlq/nnqQCe1Wywntjhmzi2K3zyJ5lnbFK8LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0izKH5PMYIealPbWPMgRyf/l66qfZwBknEdH22WkKk=; b=ToDprqXWgSOHiFtq85qoZA3R2UHgLlxTheK+jhGo8TTiZb3cJZ59x9uH2OArZBK8g7jyAqHvyyMCVIznCR1QVENHbj/gy7dSS3lcbus6YFyyxtLunrx3NgTfWmaWZoGo+msdsqXSwcyFgtgJYG94QvNSofuuyugCRSdgC7RYNUA= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Jan Beulich CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Topic: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Index: AQHYbordwufrrqV0k06ypnfJmfxjlq0sTnKAgAD4X1GAAEYaAIAAC20qgAAB0QCAAAVLzA== Date: Tue, 24 May 2022 07:17:29 +0000 Message-ID: References: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> <75055009-5053-0d4f-9174-3dd69add7c8a@suse.com> In-Reply-To: <75055009-5053-0d4f-9174-3dd69add7c8a@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebf97768-ec01-439c-24fd-08da3d557662 x-ms-traffictypediagnostic: CO2PR03MB2312:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u/mpEAGXqqFrYTN45FAIwMgMr5XfMs884GKmjsmOrWSx5M8yc03lTyPW7XvqcJnxB89zeMIFrWgJrBjZ7uslGTQtAbjq+UU5TbVGu3xfF0PLGkzQTSibhNbnTYeNu/Nh7DSp/d8YGhd2Nh/VXltVudKZxdq60MToqFHpe3p1SUpzZsdJFz14L+LlG65gxWJK3MNGZL13VwcwCOpItsdq/p6rL2xqhN/gM2Vtyyp3QrpSBrl0Yzwd1GXc3SjMsG9Qjfl3ytE2GPSyWg3MEa/P1FV32Fn8Ldj4f3N4J3UI+poxMhD8eKrOqFnDkvSm14spasKFiPY9F/lVHtOIEzARSshxk4T0UePUsx3gBZg/i+QcxlnH+g6sBB+4XTUpfjUn8iNs4ZHJU1Tjo2W68kZoMPryx2vfBSKL4T0Eg6i1OsGwOT4lwnknmiGllvW3a5z+kH9GFpCYffROxUsT3V/cPqmKJ41U6/x+pZIxMVL4+P+AvN/Lh0bAvPgQGsjJfM7x1TB2kuqBn5VI233HkyOkgt5578x/iUgka/ngktnHIDWvvwS+E1Nx82DZp883yYwxZSIOqQ9Dp6DrlvWBzeJUGTPMehKEy4e7DY3EJk8Nx/fuxXKtNFWNBm8BDtpPSKGpjcNgHplQienrCCXRWQEyN9qYHR/RJfgD40SMauO0j8rNACfEAjWp5nh2BaXkDSGVZ2xBL7yBkUSe1U214KTG3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(6916009)(122000001)(316002)(8676002)(4326008)(66556008)(54906003)(66446008)(33656002)(85182001)(64756008)(91956017)(76116006)(66946007)(5660300002)(52536014)(66476007)(8936002)(6506007)(2906002)(7696005)(9686003)(82960400001)(26005)(186003)(71200400001)(86362001)(83380400001)(55016003)(38070700005)(53546011)(508600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?b1VSSUJNYTJ5azBQakQ5Mjd0ZHNBSE9yNVVZdE8yNkE4bzdkaUJwNlEwUTRJ?= =?gb2312?B?YkVDSzB6eUoxbVBjWUtPNm1KV1VFeGZFd0xTdGlySDFPaEpUU3JtcHk4RFpK?= =?gb2312?B?YmRVc2RLOGZ1N2dpZnNPRG5RcXZqdVlUTkI1VEFpSk8rMFN2Sm5rVnlUcjcx?= =?gb2312?B?bWw4UGNJWDlzb1JXSGRTeGZyZHpvNHhPNW9TM1NMb0l4cUZrZ2lUdlBNcUU4?= =?gb2312?B?WTBYYkNQdmUyZ3gwb0gwVG5WZWRoYmt3aVJwZXAwMEVZOUhyWkwxK0xsczNj?= =?gb2312?B?bEJiTHZlVWFJNXZNd3ZWS0lSb1UrcThSMkZneGhNOW5rWXF2S0JRZUgrRXNJ?= =?gb2312?B?MnYvSG1lM0ZQMWN3b3NjLzVYUkFVajdHS3NMaXMwUzlETk4wd2RWcThCN01x?= =?gb2312?B?TlBIUTk5Q0pIMDMwSEc1YnFLcTE1UzRkejBYamM2Qzk4Zk56MUg0M2JTUkFH?= =?gb2312?B?R2ZRL0JnVStEeVhwRXROM0VJY0VKUEtzcVkxODVUR3NiM1l2UnRoSGI2OWpI?= =?gb2312?B?dk9tYkdmMFRRTlkvb0xmajFkVGFobmc0Z28wemZsTkhndm9LUmFXb0xYdlRC?= =?gb2312?B?L0JRSG5YTCtRMDU2WEJ6dVRZb3JyZVhWK0ExcU1lVHN4WllML1ZzQ1JWOFQ4?= =?gb2312?B?YmZkdXdTT2dYRDM4TzM3alhlSkNMSnJwYjJHTjJrS0E1TWtqMFhzR1VhcU1k?= =?gb2312?B?bUFuYTUxUVIxWHJHODB1c08zZVBFYWNjQjUxUFZBTFhmZDZYRUV4MVl2OElT?= =?gb2312?B?bHFFVGNmNjFBb3lxb291bXRjSFcrN2p2VmR3dlhNQ00yQ0I0UTIzbzFIYWdR?= =?gb2312?B?cXJwMUlLVHdna2FEMGRuaVVZbWs1NktJd28zYU5Tb0Y4KzRiTTd1V0U0bUk2?= =?gb2312?B?UE5OTHpwMXhHSFJabmZHWDZ0R3NzbHJOQUE3ckRyUk4wZlFkT3ZnVHk2WGNa?= =?gb2312?B?Q2szQWtPSk1XK2xzOTI3dWlEaVpkNS8zM0ZDRnFxdDNaeEFxeUowZFpFK0dn?= =?gb2312?B?OEJIOGFaTkF4TCtKQUVuQWE1YlNzanBCQmtOYVpIbmtyTnRzRUc1eG84SVVY?= =?gb2312?B?bDhtNkdzdElnSjkvKyt6ZkJhc2RzWlJGNXNpQXN5VHNFeS9ZeWZBUWxuQTVv?= =?gb2312?B?VXFEUVRPZ2ZIK1RWVlh0bStLZjY5bjczT2diVmtoZ3NvaFR1Z0JrV2NTQzBU?= =?gb2312?B?dDhGbnBVbFYxcWJIQ3FteVN1ZGtnWVlLMlVvTmwxamNORHFaVkxNdjVRckg1?= =?gb2312?B?eEVjNDcwSTgxcndKUFNwQ2Qyc2E1citubHBHWWEwUElDQlhSY2JjK0JFM3ZG?= =?gb2312?B?bkJUSWFqd3lMc2FxU1VKMTBNMFlXc0NnNnRuN1JmY2F1d3BZVnQwZUJaVjFL?= =?gb2312?B?YWNuNHY3RDdYSmxsQTEvZzBZT2JZN0ZHN3FJVG9EWXl4ckdvaERKUHlMWlRs?= =?gb2312?B?Wk5uNEY1NGRYQkZqanZJTHRDTStjWkVjSmNRSG5tTXJlMUJtVjJHVkh2TERl?= =?gb2312?B?SFg0N1RUditFYVRIMkJ5Y1NVZzFLeU95azg3NU40V1ptTi9veEZIekVZUnBz?= =?gb2312?B?MG9xVUp5NVJBVzd1bm1kWWtzN2x2cGdjUGpSSVhLbjkvdkYrbjlEN1dzclc4?= =?gb2312?B?ZTF0WTVpNzN0b3dpTGVEUVpaS0w3L2lTZ0RiOGQ3aGxoVXlpdnM3cmx6dUJF?= =?gb2312?B?REpCSEdiUG9HTCtJYzBwcE1HNURmUEtWdlhyK0QwY3l6OG5xRFBiWkRYQmNh?= =?gb2312?B?MS9NVDJTTTdUTG1WbkNEc2JPRTVyUjJYSEV4RjNlTFc1aVF1MkhFdjJCejNH?= =?gb2312?B?ZkMvc01zU0E0b2hoNEUzSm9KOWdoeU1OMFI4bzdVdm5rcXFkMmcwOERscmM0?= =?gb2312?B?MDk4U0ZTSG90NW9UaStNQXd1NXFHcWt0TFI4bEU3TnhOaEpPOUZUZ1paZU9l?= =?gb2312?B?S2pSWFcvWGN6dmtYMlFLTHJaM1VPRW9QUU9nOGtZdjFPVEpDbDhMc3gyby8w?= =?gb2312?B?VGpFYTcxQmZULzFtTmZ1V1dlREpZRk92ZHZYS3pIeW9VYnQ5L2VhWGpjbHJm?= =?gb2312?B?ZWdHb0RTNE5zWUlNNFk1ZldGUUxxUkVCK1J0Q0thRUdWWlMyNUtIMk9GZ1RE?= =?gb2312?B?Z1c5QkkxWmdaeUVHaENUVllVK0VKZzBtbEpZZ1NyTzBWTnY1M0FvYzExdmRR?= =?gb2312?B?ZlQrM1BWNjVIdU5FK2g3VUk0UThid005MjY1aDgxTWlLNGQ2YWxEd1JiTW8w?= =?gb2312?B?UTFySlBZamIydXp4ODAxZTlPOGlWMEovWGNYdUFxMGdVWFdXelNDSllVTUR5?= =?gb2312?B?YkZ0em5RenB6d2Qzdko0RmlwbXUyY1c5RFdlb29kZW9rYjBOZGVLdlRLZk9k?= =?gb2312?Q?MctJePyNn08vcm2E=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB540542A4BCB2496BD1F49A769DD79SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebf97768-ec01-439c-24fd-08da3d557662 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 07:17:29.3848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oo4SdqGa2GE1Yg24oMpeAgUZruXQHpkaxC9g0QkBsYtv1jt7koTongXMwdkAAaKAU4zi9SIUcLcb4Nzlh35gfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2312 --_000_SJ0PR03MB540542A4BCB2496BD1F49A769DD79SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Pj4+PiBPbiAyMy4wNS4yMDIyIDExOjUyLCBMaW4gTGl1IHdyb3RlOg0KPj4+Pj4+IC0tLSBhL3Rv b2xzL2xpYnMvZ3Vlc3QveGdfZG9tX2RlY29tcHJlc3NfdW5zYWZlX3h6LmMNCj4+Pj4+PiArKysg Yi90b29scy9saWJzL2d1ZXN0L3hnX2RvbV9kZWNvbXByZXNzX3Vuc2FmZV94ei5jDQo+Pj4+Pj4g QEAgLTM0LDYgKzM0LDExIEBAIHN0YXRpYyBpbmxpbmUgdTMyIGxlMzJfdG9fY3B1cChjb25zdCB1 MzIgKnApDQo+Pj4+Pj4gICAgICAgIHJldHVybiBjcHVfdG9fbGUzMigqcCk7DQo+Pj4+Pj4gIH0N Cj4+Pj4+Pg0KPj4+Pj4+ICtzdGF0aWMgaW5saW5lIHUzMiBsZTMyX3RvX2NwdSh1MzIgdmFsKQ0K Pj4+Pj4+ICt7DQo+Pj4+Pj4gKyAgIHJldHVybiBsZTMyX3RvX2NwdXAoKGNvbnN0IHUzMiAqKSZ2 YWwpOw0KPj4+Pj4+ICt9DQo+Pj4+Pg0KPj4+Pj4gV2h5IHRoZSBjYXN0PyBBbmQgd2h5IG5vdCB1 aW50MzJfdD8NCj4+Pj4+DQo+Pj4+PiBKYW4NCj4+Pj4NCj4+Pj4gbGUzMl90b19jcHVwIGhhcyBm b2xsb3dpbmcgcHJvdG90eWUgYW5kIGRlZmluaXRpb24NCj4+Pj4NCj4+Pj4gc3RhdGljIGlubGlu ZSB1MzIgbGUzMl90b19jcHVwKGNvbnN0IHUzMiAqcCkNCj4+Pj4gew0KPj4+PiAgICAgICAgIHJl dHVybiBjcHVfdG9fbGUzMigqcCk7DQo+Pj4+IH0NCj4+Pj4NCj4+Pj4geGdfZG9tX2RlY29tcHJl c3NfdW5zYWZlX3h6LmMgcmVkZWZpbmUgYW5kIHVzZSB1MzIsIHVzZSB1MzIgdG8ga2VlcCBjb25z aXN0ZW50DQo+Pj4+IHR5cGVkZWYgdWludDMyX3QgdTMyOw0KPj4+DQo+Pj4gVGhpcyBhbnN3ZXJz IG5laXRoZXIgcGFydCBvZiBteSBxdWVzdGlvbi4gRm9yIHUzMiB2cyB1aW50MzJfdCwgcGxlYXNl DQo+Pj4gYWxzbyBzZWUgLi9DT0RJTkdfU1RZTEUuDQo+Pg0KPj4gVHlwZSBjYXN0IGlzIHVubmVj ZXNzYXJ5LCB3aWxsIGJlIHJlbW92ZWQgaW4gbmV4dCB2ZXJzaW9uIG9mIHBhdGNoDQo+PiBDT0RJ TkdfU1RZTEUgZW5jb3VyYWdlIHVpbnQzMl90IGluc3RlYWQgb2YgdTMyLA0KPj4gSG93ZXZlciwg Q3VycmVudCB4Z19kb21fZGVjb21wcmVzc191bnNhZmVfeHouYyBhbHJlYWR5IHVzZSB1MzIgaW5z dGVhZCBvZiB1bml0MzJfdCwgc28gSQ0KPj4gdXNlIHUzMiB0byBrZWVwIGNlbnNpc3RlbnQsIG90 aGVyd2lzZSwgdGhlIGNvZGUgbG9vayBzdHJhbmdlDQo+DQo+U3RyYW5nZSBvciBub3QsIHRoYXQn cyB0aGUgb25seSB3YXkgdG8gcGhhc2Ugb3V0IGNlcnRhaW4gdGhpbmdzIHdpdGhvdXQNCj51c2lu ZyBnaWdhbnRpYyBwYXRjaGVzIC8gc2VyaWVzIHRvdWNoaW5nIHRoZSBlbnRpcmUgdHJlZSBhdCBv bmUgdGltZS4NCj5OZXcgY29kZSBzaG91bGQgbm90IHVzZSB0aGVzZSBkZXByZWNhdGVkIChmb3Ig b3VyIHB1cnBvc2VzKSB0eXBlcw0KPmFueW1vcmUuIE5vdGUgaG93IHRoZSBmaWxlIHlvdSBhZGp1 c3QgaGVyZSBhbHJlYWR5IGhhcyB0byBpbnRyb2R1Y2UNCj50aGVzZSB0eXBlIGFsaWFzZXMgZm9y IHRoaW5ncyB0byBidWlsZC4gVGhlc2UgdHlwZWRlZnMgcmVhbGx5IHdhbnQgdG8NCj5nbyBhd2F5 LCBhbmQgYW55IG5ldyB1c2Ugb2YgdGhvc2UgdHlwZXMgaXMgYW5vdGhlciBoaW5kcmFuY2UgaW4g ZG9pbmcNCg0Kd2VsbCwgeW91IGNvbnZpbmNlZCBtZSB0byB1c2UgdWludDMyX3QgaW5zdGVhZCBv ZiB1MzIuDQpIb3dldmVyLCBUaGlzIHBhdGNoIHdpbGwgbm90IHVwZGF0ZSBvdGhlciB1MzIocykg dG8gZ2V0IGZvY3VzLg0KSSBjYW4gcmFpc2UgYW5vdGhlciBwYXRjaCB0byB1cGRhdGUgcGFydHMg aWYgbmVjZXNzYXJ5Lg0KDQpDaGVlcnMsDQpMaW4NCg== --_000_SJ0PR03MB540542A4BCB2496BD1F49A769DD79SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

>>>> On 23.05.2022 11:52, Lin = Liu wrote:

>>>>>= ;> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>>>= ;> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>>>= ;> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p)<= /o:p>

>>>>>= ;>        return cpu_to_le32(*p);

>>>>>= ;>  }

>>>>>= ;> 

>>>>>= ;> +static inline u32 le32_to_cpu(u32 val)

>>>>>= ;> +{

>>>>>= ;> +   return le32_to_cpup((const u32 *)&val);<= /span>

>>>>>= ;> +}

>>>>>= ; 

>>>>>= ; Why the cast? And why not uint32_t?

>>>>>= ; 

>>>>>= ; Jan

>>>> 

>>>> le= 32_to_cpup has following prototye and definition

>>>> 

>>>> st= atic inline u32 le32_to_cpup(const u32 *p)

>>>> {<= o:p>

>>>>&nb= sp;        return cpu_to_le32(*p);<= /o:p>

>>>> }<= o:p>

>>>> 

>>>> xg= _dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep consisten= t

>>>> ty= pedef uint32_t u32;

>>>&n= bsp;

>>> This a= nswers neither part of my question. For u32 vs uint32_t, please<= /span>

>>> also s= ee ./CODING_STYLE.

>>

>> Type cast = is unnecessary, will be removed in next version of patch<= /p>

>> CODING_STY= LE encourage uint32_t instead of u32,

>> However, C= urrent xg_dom_decompress_unsafe_xz.c already use u32 instead of unit32_t, s= o I

>> use u32 to= keep censistent, otherwise, the code look strange

> 

>Strange or not,= that's the only way to phase out certain things without<= /p>

>using gigantic = patches / series touching the entire tree at one time.

>New code should= not use these deprecated (for our purposes) types

>anymore. Note h= ow the file you adjust here already has to introduce

>these type alia= ses for things to build. These typedefs really want to

>go away, and an= y new use of those types is another hindrance in doing

 

well, you convinced= me to use uint32_t instead of u32.

However, This patch= will not update other u32(s) to get focus.

I can raise another= patch to update parts if necessary.

 

Cheers,<= /span>

Lin

--_000_SJ0PR03MB540542A4BCB2496BD1F49A769DD79SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 24 07:32:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336167.560504 (Exim 4.92) (envelope-from ) id 1ntP1p-0002aE-Jy; Tue, 24 May 2022 07:32:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336167.560504; Tue, 24 May 2022 07:32:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP1p-0002a7-GU; Tue, 24 May 2022 07:32:29 +0000 Received: by outflank-mailman (input) for mailman id 336167; Tue, 24 May 2022 07:32:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP1n-0002a1-Rc for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:32:28 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a783321a-db33-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 09:32:26 +0200 (CEST) Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 03:32:22 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by MN2PR03MB5328.namprd03.prod.outlook.com (2603:10b6:208:1e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 07:32:19 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 07:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a783321a-db33-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653377545; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=DJPI6nT9lNiSBOnsC/zslK8lor/L3YsvuIrjuGviS4M=; b=EwJcV35UNOKZ347RZWm/qISH8Ukdm6f3vQZAqBKrCmnYQJJSbUPjC71I udgjvAr/ZqeDqyqJOrrcwoToCOZKjlv3aMJ4gd3XIVkoVY/Y9j+IkrYhS FyRiaI/biwc6TxTyO+EzzU3Uusi0URXkzmYVEWBpOv5cvZ4dJNFmf/8/u o=; X-IronPort-RemoteIP: 104.47.56.168 X-IronPort-MID: 72029938 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hHB8ka6avmWM+cGsUXi/VQxRtEzGchMFZxGqfqrLsTDasY5as4F+v jccDWCPOqqONDDyfYx+O4Tj9U0Hup7RyYRiSVQ//yw0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjX1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSWcyACJLTXkdgceCNSKRtuB40Z/rL+dC3XXcy7lyUqclPK6tA3VQQdGtRd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4YGjF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IC8AjE9PFni4TV5AZ82ZLXHvzMRt2Xd9tcnGaBi 3nB9k2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/f5F+fD21dFzpZMoV45IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:qfk6CaBPf5rkdQ7lHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj4lLYIk7zI9HakGOuh5Dt T/Q9pVfY51P78rhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="72029938" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E2b/ws60VaLYFRTi4EnELJXWRC4/wbuMWHXsVqCZtC0/dlgZ6HaNDKOLKN4snL5U2LqbmYUN2/XwXfWgSct/FHSKjLglnOlBreUrWkN3vrBa2M4CGEcMHKCcRLMaPBD8CSGIclKsu+8XfnpqMqRxFSuHp0PiVSxKjiXCXAhjEToGFkJf1UmZUrVfGJns0Cp1plTTJjYuZi3m+aMwjRM9ADyfPhBp8jgVC9VUxuZ3KtI60B2lsBTKyKDECwyPeKqAK6DyDtKR7eCCGxI//TpRMyE9oDIqvHAgHlIz0HS60UGf8wzqrjR0Wclrab0PG/gCP4x6E+5iK3U30LQpZfrnGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snC/EjOA4P7q5xYAAD3bWY+4o6HvQJRs6ynm7sTmHtQ=; b=FyGcO1UKsxQ4nGw8lQwIW4duhdBai5PKr038jDwjoj55vKhxQi2cKBb3Z5E+jO6QHjYwOQ67oCGiCIdkpGkQNuNpvODlmgZqx7y8LkxuYqN9VGWV5BlAVnoJnRUfqYStckzHIH2hNxVM2EiOawLoxbrunvo3I/nEGmbWtYIQYuO6eRy9U6gwV/ZPSikvAuI17s6637vNJ4rJaxDV93tsx+S5e7AuhzwMj/eRB7l5GhSESa3Fd2ALVy4BbB3tWvROoK6emMT5C02cYvE2U2ycoLqn8qizXAaREmpyeTvD1wp68hQc1qYR9eI3MDreQ83N2QvZ3UD8MRN918xQ29QOXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snC/EjOA4P7q5xYAAD3bWY+4o6HvQJRs6ynm7sTmHtQ=; b=KZTN2NOedSjIm1nA6ytl9sXENIDvHpqwGgSqQ2QU5vReCwhbI49XOTCWcAbXG/BGa0nCkcE44S8Y4IXHSuo/dbgFrWvOBM3zsNPEGraEecJBLdwmuJIESTaz33TxFJfjUFuAXi7eyY1W9id+b+6N99ZvSpVJjfbbe1Gpws5ufCc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 24 May 2022 09:32:13 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220516143116.28602-1-roger.pau@citrix.com> <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> X-ClientProxiedBy: MR2P264CA0130.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8bba2a1-d217-48b3-e133-08da3d578876 X-MS-TrafficTypeDiagnostic: MN2PR03MB5328:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EggFfT1fgbzQx4TUhJnK6NrC920jZNosNq9tfAB8AWGw7at8SPv54qBRiadM6V4QK846Uq6XxGT1M1ZCM+/kUjnsJpc19JttdNpPgStyjIw6EwK3fPj/5FXdUHoUlCKCk91uod38iRc7vY8ClYdK3Eial/+TAXOPtZhfnB02E1Bi8/GLobtvefkvsThN0yMmv0bGiFr/9YHGtdc+zWMuq31CfnceGKkoAl1VaU4wefdxzJZMmbyxX9CH8gfAf09llKdBbH79sztFHCfivGE5Yvw1QYTpyZaTxiMHMLQ8iOxm09bf3qVTO/B3gnho8kPQunvydSHtGfFsmr76r3JIqmNvFx4qyGKorc1vIEySKFaJzyOy2uGF/8+oii3SJNV4bCedBLmjK853ICtc+3k5lDZ+8OsoTfhU5GjIkDDyJhk9GaxG9gNd2WeX6VDcm/7R6v1c0c7E51MOf4cLdu4U60DkTd0ZqT+yJyovU41Lm3xSLCGgymnefu3mTeEIWHFQT7EUFWMAeN0KNu3bTqS8xmckR98g3d9yMWzCbY8NIQGOH9qm/JsHMn30g/cqN6IGeAg4K+XFFHE02LdDd598x5A4VoJAr4d5HBJRGhCOIDGzFo/vgSL9l3lsIbjGhb79KNhdSfAUIVXkZLdjT3n2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(6916009)(316002)(54906003)(82960400001)(5660300002)(85182001)(8676002)(4326008)(83380400001)(186003)(66476007)(66946007)(66556008)(86362001)(6486002)(508600001)(26005)(6512007)(9686003)(33716001)(6666004)(8936002)(6506007)(53546011)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDZDNTZqTFR3Z2RMSGtBdE5mV1c0akRCY3BOUG56Q2ozc0NLRjVJNFE4Y1hY?= =?utf-8?B?aG45WXRKd0d3Z2hGUTVPYVlEOXZCb0lSaUpmYk10OTlJVjk4QXhzZHpRV2xT?= =?utf-8?B?RytnVjJ4a0k4YWNIZnF1TFhPRngzWmd1YTJlUHRvenViREt6aHBZK1VVUVZX?= =?utf-8?B?ZG5TSktPdUhjY3N5dktHc2Q0ajY2VFdMb2V4VlJGTVQzNEkranpYYThrRTkw?= =?utf-8?B?eGtNb1RIK25NUXk0ckVYdER5ZWZPek1uR3pNR0I5ZmxiUUFUY3NTYXhac3Rj?= =?utf-8?B?UTBvdTUyQ2FIcC9DQW9QU3p4cG9ybFZwalFnOEJLWStWdmhVcktzSCthazlk?= =?utf-8?B?Ynd3T3RGOG94MklLNUJmUDBvbjd0M0p1WWhZNVBNKzJZOUNteDZTWnN6N3V0?= =?utf-8?B?dm9XUENFM2RzeEwrOXhpelZPNXhyNXJFZ0s2MXJETHBaUzROMVlaUEpwL3cy?= =?utf-8?B?Y3ZkTUtOcysraStjTURoUDBDOXQrQkYrMlQ3cm9RQ3hXUG54S29NUnhUSUVp?= =?utf-8?B?WStCSWdEZlk0S1R3NDFzNkdNa0VrUm9TYVF1ZkJJUFlhZyt6bm5sRUt5R2Ns?= =?utf-8?B?SXBiYXFwVDBNd1BtNzVOVUNWNW9IeDk1Q1NMbzZrKzRsVloyZE94YnFvVzcz?= =?utf-8?B?VEVFMXJUbmxnRE9ZTzlVUEpsOXpGOFBLUGFocFcrUzdEMCtlbEVyZkJrcCt1?= =?utf-8?B?bFBJNTN3Mk52OFM2WkJzQ3pldXdYaUtBdDhRTTBUM1pqRWJaWExDSFh2Nzlp?= =?utf-8?B?T0d1d2wzME5Nb2Voc2pHdDdOWEJ0bTRKU0FmMVNJd3hlQlkrRnNNaDkzSElY?= =?utf-8?B?cnR0ZDUvNml3ZitjaDl4OHNIeW9EeDFvNU1GK1RTK29OdURrQTN4R0Y1OEpK?= =?utf-8?B?c0ZPUkZzVmt0SVZJNkh3UU1IVzNkQ0Vtc0RwYXJISWpLOUhEd21kWEFpN09L?= =?utf-8?B?ZXYyTjhscDlWd3dORnlmYVF0TS9Sb0lOYnZOMEI0TnNPY2c0cFluZVkzdjlm?= =?utf-8?B?VDMrbExVV3RKSm1nNUxnLzBzcy9Vc1U0TTVwZlFST3ZPUTRBLyt5U3Rsakc4?= =?utf-8?B?NEtNRzRzcVgyK3dwaTBlM1FGdFUyc0UvWWdWcDlvd1ZDQzhPblpZSk9YeTFD?= =?utf-8?B?eUVVbkdxYVM1cCtZcmFsbWpXTERiVWpTeTVtK0JKNGJGVUUrREJHV21lK003?= =?utf-8?B?cHFsWUhaWlFpWGxxVzVQTHNYSEh4cmNhbEY1SWZZclRjKzBpbjA1cllyR1Yw?= =?utf-8?B?V1Z2Mnh3Rk1YSW5sazFqYVpaMjZCQVR6VWJWa1VzZEZ2R0kwUXRjcDZMMklU?= =?utf-8?B?aG9jeGVDb2NxRTZEa3lMdmYwcEgwRU9YRVZhNUk5R1ZpSGg5VUxFTTZlOElN?= =?utf-8?B?aExPbXJuSVpxZjBYVXB5ak9mUDJLUjdWcU5OQnNYUWNlN1lNN1NMcGs5KzY5?= =?utf-8?B?eVIrS0Z3b0dlZjk0Z0VRNTl0bVpnRUhvRGFScWNrT1ZtaXBBV3pkM2pqeXRV?= =?utf-8?B?eUN1OS81QklZSFBRUUZLdWltUy9ML2hQeGZyQ0pMQldRZFRpMHZlcHRMVDJo?= =?utf-8?B?WGxUenRyU3hFbXNmbVB6YmlsajNnVElKV3k4V0FaRk5ib1hIOXVoc3FFOGV3?= =?utf-8?B?QXRmQUVieTVUVXR1a2pzVXdPQW5aVDkzelU3M3VObFhLVnh5OW1sbTJTTXhL?= =?utf-8?B?VFk4Vnk3dENNTk9jOVFLUjFsUE02T1ZTc2lSYXlHSEwyZjRNd1YrNk1JV2Fr?= =?utf-8?B?YUpwaDdSZk5WMlVCL0tzOXN3aHc0Vk1rbWh2a0REV0FEcDBNNUYzeVNiTHMz?= =?utf-8?B?dzVFaW5CVHNsT3Y4ckhrUk5OWjFvZ2FnMnpDMGVyM2lVQVhpNU9wcnYzR0Vu?= =?utf-8?B?Vkdpb1BmWUNOOERFRGQ3UFZFeFVPQ3RmaEFtbHlWa09haHJQUWRVWk5ja0Iz?= =?utf-8?B?Z3dpLy93ZXFuOGgwb1ZoU1llaUJaODdNdWZnNWF3Q3dJNWJzUFlBN2VZMTQ1?= =?utf-8?B?RFZOTWNIS09OSC8ySmlGTnQyVFRHSGtjMzBpdkNRcTgxdkdNcjhub0Y0eUVt?= =?utf-8?B?TkV3bVJxRFRkOWYvbjdYbmxRVWNTRndIYWhTWm9QQ045K0FKeW4xYzBYRG45?= =?utf-8?B?Zkg3cGdGVFpJV0c2YXZ4L1lUNWwxc0ViSDBtZ2VCcUpRREtabFppdmROakJN?= =?utf-8?B?dm5UcThHcWZjZ25MSkJhRDNJVTBCTms3Qk5XRkZoRXNsTDZrenpSTDRxSXNH?= =?utf-8?B?djJpR3ZVQ3cvVHY1UWFuaWZnSUdiN0FoWU1hWHM0MnZaejAyd2x1d1Uwa2RQ?= =?utf-8?B?MmkxZ0pzaEo3c295eEp0L29ycUZLZndyVlFSZWxjRGVtWGZhckVoNkZSRlN3?= =?utf-8?Q?bwqMvMgGtE6gDA0M=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8bba2a1-d217-48b3-e133-08da3d578876 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 07:32:18.9162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ITnMa6DB2W/ct4VKiDYxlRuVQoLFL3UgfcYRXLejD39zPRJLXUWAnLX63U4SOEs8piyMGInkiBFcoqM6Z8CQ4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5328 (trying to send again, as I've replied yesterday but the email never reached xen-devel). On Mon, May 23, 2022 at 05:13:43PM +0200, Jan Beulich wrote: > On 23.05.2022 16:37, Roger Pau Monné wrote: > > On Wed, May 18, 2022 at 10:49:22AM +0200, Jan Beulich wrote: > >> On 16.05.2022 16:31, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/flushtlb.h > >>> +++ b/xen/arch/x86/include/asm/flushtlb.h > >>> @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); > >>> #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) > >>> > >>> /* Flush all CPUs' TLBs/caches */ > >>> -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) > >>> +#define flush_area(va, flags) \ > >>> + flush_area_mask(&cpu_online_map, (const void *)(va), flags) > >> > >> I have to admit that I would prefer if we kept the "_all" name suffix, > >> to continue to clearly express the scope of the flush. I'm also not > >> really happy to see the cast being added globally now. > > > > But there where no direct callers of flush_area_all(), so the name was > > just relevant for it's use in flush_area(). With that now gone I > > don't see a need for a flush_area_all(), as flush_area_mask() is more > > appropriate. > > And flush_area_all() is shorthand for flush_area_mask(&cpu_online_map, ...). > That's more clearly distinguished from flush_area_local() than simply > flush_area(); the latter was okay-ish with its mm.c-only exposure, but imo > isn't anymore when put in a header. OK, so you would prefer to replace callers to use flush_area_all() and drop flush_area() altogether. I can do that. > >>> --- a/xen/arch/x86/smp.c > >>> +++ b/xen/arch/x86/smp.c > >>> @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > >>> { > >>> unsigned int cpu = smp_processor_id(); > >>> > >>> - ASSERT(local_irq_is_enabled()); > >>> + /* Local flushes can be performed with interrupts disabled. */ > >>> + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); > >> > >> Further down we use cpumask_subset(mask, cpumask_of(cpu)), > >> apparently to also cover the case where mask is empty. I think > >> you want to do so here as well. > > > > Hm, yes. I guess that's cheaper than adding an extra: > > > > if ( cpumask_empty() ) > > return; > > > > check at the start of the function. > > > >>> if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && > >>> cpumask_test_cpu(cpu, mask) ) > >> > >> I suppose we want a further precaution here: Despite the > >> !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to > >> extend what c64bf2d2a625 ("x86: make CPU state flush requests > >> explicit") and later changes (isolating uses of FLUSH_VCPU_STATE > >> from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE > >> for the local CPU altogether. > > > > If we really want to exclude the use of FLUSH_VCPU_STATE for the local > > CPU, we might wish to add this as a separate ASSERT, so that such > > checking doesn't depend on !local_irq_is_enabled(): > > > > ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu)); > > ASSERT(!cpumask_subset(mask, cpumask_of(cpu)) || !(flags & FLUSH_VCPU_STATE)); > > > > > >> That's because if such somehow made > >> it into the conditional below here, it would still involve an IPI. > > > > Sorry, I'm confused by this: if the mask is empty there should be no > > IPI involved at all? And we shouldn't even get into the second > > conditional on the function. > > Should perhaps have made more explicit that "somehow" means a hypothetical > way, perhaps even as a result of some further breakage somewhere. Oh, OK, then I wasn't so confused after all :). Given your lack of comments I assume you are fine with the addition of a separate ASSERT to cover the usage of FLUSH_VCPU_STATE. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336197.560521 (Exim 4.92) (envelope-from ) id 1ntPAk-000491-Ru; Tue, 24 May 2022 07:41:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336197.560521; Tue, 24 May 2022 07:41:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAk-00048a-LL; Tue, 24 May 2022 07:41:42 +0000 Received: by outflank-mailman (input) for mailman id 336197; Tue, 24 May 2022 07:41:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6v-0003DA-0x for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2522fdc-db2e-11ec-837e-e5687231ffcc; Tue, 24 May 2022 08:58:15 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-eXmNr-YEO1OhbWO6T4u9GA-1; Tue, 24 May 2022 08:58:12 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7633.eurprd04.prod.outlook.com (2603:10a6:20b:2d9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 06:58:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 06:58:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2522fdc-db2e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653375495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iry2ScJHFHGazf7Zegk+CDHfc4Vr4GlJWSfF8kTN5fI=; b=OTkfKZAtyWgMWobmht7/t2Y4zhhYIvO2Wx8EVHFwtxEhJS86g9UzixuumkfWAgDqXI57IT JDU9Gr10BScDZtpWqvlcZYmgxCDYSHkq1b1hjz44m4zh8hiVDhGl26W1gQHSXUMvsSCOtt qUG6rEL77ElFddiF/gnDmBLhbiEEtoM= X-MC-Unique: eXmNr-YEO1OhbWO6T4u9GA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYh3a3TZM0+sliuyNdqpcdQ779YLQ6gID35Lx+IWKOwBKQKoz/3Uc+vgMI+teN2MAwEbV9cHPBzrXNJ2zYN9+fAu9j4uCTQhw7MvUqkyYK+Td8t3LAdFTQLK0t28E4Tnm7UoZ5lrPVQMyiXdCbSwlWijUHEvxZg7hm/5i+rY6n7+gUORisBFmnrP9/2q7oak0wZVjH3hg9eT3iieSj1OlwGcFVnIdD5odj+E67ZKmhl4c/oslaaGzwrMEJ0Ik5pTICc8khSqnlTB2ssdAhSZHiGh8Kpmi98FOSNEZhNrIQv4qjlPrQrLtek8UWcxvj1xmpea1fJfxwaqGiizpb58+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UzPQLR2jxPKcOw2m44MccYVdL5mUZ6h1/S/n0FIIsro=; b=UJxbtDZ3a7x45bq1qJ0vebB789vofgrBEW6B2zEEI3tCkaas6Ins9VA1KEyhpe1+iOJtj1CGodCObqKMl1KUdTvuHJphV2YxSdQ4gHMKPg5kjDeyMrGoRsWBhMjnHg31S0Shj8we8bb3uz9H/cK806WTLQYYbuCQM+0KUNBVqjo1a54Vwie4RFCVn5C3ajUK/qaVoe57nE1QF9AhPPYD23ok6sygGQ+fe3gpAxJW+QLZcWiGZGRVaBkTjrP1g2DqPUx5v8vAXCA4onV5CdxAky+VnOrM+zl//9aPymXE+AwTUS4Ptkmyv+hwunknzwbJGAGF5zi5iN3YgJlD899fYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <75055009-5053-0d4f-9174-3dd69add7c8a@suse.com> Date: Tue, 24 May 2022 08:58:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Content-Language: en-US To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" References: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23008568-d23a-4b91-fe9f-08da3d52c370 X-MS-TrafficTypeDiagnostic: AM9PR04MB7633:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J/1lmYo9xP8aGRSGU83P2O8txWRAcHzI+I1sINKkGMOKeoCiUclHL1BUhdNEyyL9Z/gxXF2EKxDhXZ1kiNukETM1IKh3I1QJ29uAqarw0qXl/NaguuMOxm2dckQQ469tmGsf1Ws+bayqF2k+83eAM8ATacPJy6YITCytHwg99KP/GwpWHRxZpCZnkjR+wWf+aqr1bqBpfm6+uBnbAebQECSD18LXIY+htMB5a6VsTp4H1geAUt1ia9q8NAg7OMmDgWIPm9zp2unPL3b2Py2cY7R0sAydFGlSb5q4zDis1v4OTx1slDUQVfCBPjYkTQDvPEAoM4KK4XEpgi4Tb0QJKjXFmgX8pI/tvYrLi16YjnKyz01I/lXhXm3aBOoj5Liqv4F6BuKSkEr+U0jQtFfcZP0rHeURQQiKEDqAhgHEWnnBEc/jWT8+HF/7zxgRKRmG68W4w2hvInhKm+bD69dqYGTIpbA8bwiVNylSTGCKn1FW2KiLqweUFClIUIe/EyyFMRUOwxX4VUDwcLIO6+tcvhij8uuTyX98TqS3Cfe03X2CkoE/7mvoMw6dIj6d6cXbRIN3GjgPIJpJkcJKWTbyP2rINQljEBC89a3SeWIQNfDcCjylPG2DW1P6IxU3txAc0+SahxTi2H9LwmSolRhLyWGH7NMK2JzooyecSUis5jBFNSMMAafSGn/0+HaaGauTxHF4UvhUX9TF9urrQpzJNNhlFKEcRtI2Q4gqjlJBSpe0RqISkU+Yb8xsPRw1uXv2c1ubVa0KexOMY9GilITyYXJbTBhjrPmjDDC1JfVI3Lk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(86362001)(6512007)(8936002)(53546011)(6486002)(186003)(6506007)(508600001)(31686004)(2906002)(38100700002)(5660300002)(66946007)(4326008)(2616005)(8676002)(26005)(316002)(6916009)(66476007)(66556008)(31696002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EXbtl324+CVr9koHHHr5hW8kD/xZn2FHXGoWIXbutpHPGdNxN/xmjlCYSX9V?= =?us-ascii?Q?zBDarjYUKTQ0lOMdyD53ivRrQlzg/VkOyItw+NXeAqRsb5AzkcFWSh0E6cZ4?= =?us-ascii?Q?eIasHYP8mdAGxtrxrmTSyztDuMegzpocqg3hDrEic1fASQ5fOqg/vuVuorFs?= =?us-ascii?Q?c9nJuiSnBPdsTCgrGvk7Iduc3z2ILnoa8HCJkG9Ow+DYk5ZzH3hbx+vtqZKQ?= =?us-ascii?Q?hI8RdcG0WbM6E5dUBK2FxXgF+lKQzc0msCYvMjamStC7hI5GIInIjr92QQZw?= =?us-ascii?Q?EWNmkv8NwzM7LJNU6EdSwNqBeaFbWExkNEGo6RtP0kZVhBqgCHob96fXHLRH?= =?us-ascii?Q?PxSsGToHrxEHEpFPFGhEm9pGnTQibcLYwzCvKK6kV/cMlcvQngjeylMvtwM2?= =?us-ascii?Q?I5wuxu/MvhE8dcY5hrjwjc1toG/KMOeJe9hD13YiH7dQrcWXcUT0c6vhZBAX?= =?us-ascii?Q?a0RyUAcJ9k/U7HZ6NoQxZDi6dtlp5D6Oi6ylG2bIX57CFH02DEEu+wuDQ966?= =?us-ascii?Q?HLiJw+TJBMDjKFB5lKdbbsvmviiW0o5y0RHrqOqmavDxz0Pl/nc6k2dKBPcF?= =?us-ascii?Q?iKtUANOBLPds06swCyDtdChrJr7KsqkFRIGTWV4QyseQtGg5ffVNhnckXOvD?= =?us-ascii?Q?VJhavNaPcYTgLro9/f0CypTBll5SchbpTNmAD86+PhF83LyV8G7VN6S2ARi8?= =?us-ascii?Q?JQptQEYwHhIJ7jwbLM+p/Zy30EQpQVEx28W6nvaJUmb7S1YqDV/29PyWJork?= =?us-ascii?Q?CJ1ZcMvXHaEwDywSfnGWbKpJYYEjMxTIEFXGbFZDen8ZLSBJoS3YGraYdkHy?= =?us-ascii?Q?NA8rBQGnbRdZR6Jh6aBI5JubRZULO7wemys9NPgHoO4lpIVz+EkzK+s8PN2z?= =?us-ascii?Q?6y64TC5WAV0bmsbkJ4wQLTpBtgXws5OjM40I1XQcj3hX7Iq6ugLbv3/kv80B?= =?us-ascii?Q?zkj+1QU+7DlPxERVjXClAkB8L1LIxIMdRcm6v+pQBfNaUdnWGozOuYA/bMCu?= =?us-ascii?Q?9mtSJ07EpbqkKrBemXIt1sx7eaQzTDFzkb4qOzEVovZMkk/DbFqkjTqe0Ju2?= =?us-ascii?Q?UY6yzKKKcp6VJQ6hxycAOWfV7OtKT+6hCWUIXtOI5xGehj4OY2RY478RNY5i?= =?us-ascii?Q?cUfJeuGky+nZNOw2O6/UeAux0uA000zm+nvv9l6jeOzd+4zdMG0I5QNlD+UJ?= =?us-ascii?Q?5fltjCnN1dmKK0bfKQ/nht/CwkXwYOfmnEJcZLLp6XPUOHtUvqWcyo3ajblN?= =?us-ascii?Q?I9RBBdm5i/6sdRItl8Z8YGw+iakiUWirtGYynXiceu4zP9lJbSool/Nleqj/?= =?us-ascii?Q?ePC9AdGx3bd01Z37VB6NPEGIHZoyROETn1Z3uy19YV6WLKQAbWFxTu0Q1lk9?= =?us-ascii?Q?VGSAtr3MY73+1Xy8yWOTyXwXHy2Sn/u13ECyfcPkBPGuYLl7qdcnWFqeGJrU?= =?us-ascii?Q?v7nz9JPJGI3sFJrTsbh2rC28Cee9L6JHjsmDrnHic3q10l0t99BChq5bJRIb?= =?us-ascii?Q?Qw+7RTWYIXZ/8OsXNxgJC0/9KO0Kwfkj/Ucyb0Ozc1LlMuJxJmXKkJ+S4117?= =?us-ascii?Q?Jpfx2Ot/jFKRkojiy+CuPgpOSlwjfCyIuV+R+/vO0ljU0X1rHP+wFv3WWEw4?= =?us-ascii?Q?NNbZBMY3t3igY4mCnoUuAjg80fBb5L9n8GoxeG0nKK/F9+SgWSC0ZbzWKmci?= =?us-ascii?Q?noBJ+p+5kDeEUXxqfMFC0uOSwR9fu94eC5Vis6XQ/mHakkxM7Y2r4KSxzouD?= =?us-ascii?Q?Mgab9vYE2g=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23008568-d23a-4b91-fe9f-08da3d52c370 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 06:58:10.3327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XaN6puyJxgP1ysU//pBZcMaXx/aMUqxb7fRwrlnTSwNm59ID/gRT8cY9DLNr2kYopILVGvIP0bVUv/RqvkkFUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7633 On 24.05.2022 08:52, Lin Liu =EF=BC=88=E5=88=98=E6=9E=97=EF=BC=89 wrote: >>> On 23.05.2022 11:52, Lin Liu wrote: >>>>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>>>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>>>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) >>>>> return cpu_to_le32(*p); >>>>> } >>>>> >>>>> +static inline u32 le32_to_cpu(u32 val) >>>>> +{ >>>>> + return le32_to_cpup((const u32 *)&val); >>>>> +} >>>> >>>> Why the cast? And why not uint32_t? >>>> >>>> Jan >>> >>> le32_to_cpup has following prototye and definition >>> >>> static inline u32 le32_to_cpup(const u32 *p) >>> { >>> return cpu_to_le32(*p); >>> } >>> >>> xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep con= sistent >>> typedef uint32_t u32; >> >> This answers neither part of my question. For u32 vs uint32_t, please >> also see ./CODING_STYLE. >=20 > Type cast is unnecessary, will be removed in next version of patch > CODING_STYLE encourage uint32_t instead of u32, > However, Current xg_dom_decompress_unsafe_xz.c already use u32 instead of= unit32_t, so I > use u32 to keep censistent, otherwise, the code look strange Strange or not, that's the only way to phase out certain things without using gigantic patches / series touching the entire tree at one time. New code should not use these deprecated (for our purposes) types anymore. Note how the file you adjust here already has to introduce these type aliases for things to build. These typedefs really want to go away, and any new use of those types is another hindrance in doing so. Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336194.560515 (Exim 4.92) (envelope-from ) id 1ntPAk-00045X-GJ; Tue, 24 May 2022 07:41:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336194.560515; Tue, 24 May 2022 07:41:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAk-00045Q-Cf; Tue, 24 May 2022 07:41:42 +0000 Received: by outflank-mailman (input) for mailman id 336194; Tue, 24 May 2022 07:41:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6E-0003DA-QQ for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:02 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id abe7e49f-daae-11ec-837e-e5687231ffcc; Mon, 23 May 2022 17:40:30 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653320431089155.22680033498602; Mon, 23 May 2022 08:40:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abe7e49f-daae-11ec-837e-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653320432; cv=none; d=zohomail.com; s=zohoarc; b=QuXS1HEj0dvBJR2U8ihqk8BbN7rGuPNp/rtmwBU+gH2/qXMXK5PT76NWyjeLHhuQZBbZbpBDFfoSODSLdAiIQjTy24l35m5/Fm0cWbMipDhAw4anJj1yB94Ni/n9h5tFse0yTg1l8zLQ+mqwjmn57fgVtt8oP+VUCavy4GI8VoM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653320432; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=98v0UwvujcfL6C9tx4e5oAX1065dOOeYtIhzPpau0Tw=; b=kZeAUtQNwaAvJEu13sFORdPqc7Soy50h7EmXs3G5DlLoaqHnIqTzoBRxueR7g71kFGpO/BMdYIvkii1aoJP/gbCWj7xkItT95rz8h3SnWbpnR4bTvikCQJacAqvVWaZxRr1QowMYBpOcTYBnsPAW9q1ffD7QmK3syozF1biZlmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653320432; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=98v0UwvujcfL6C9tx4e5oAX1065dOOeYtIhzPpau0Tw=; b=BQKPur29NhqC4YNELGVJO0XHUthYhshfF2F2vX5d8boDvAexBYDFDGJULF95kyca yNBi92rvLbiI4/ssoIs0fIOtq6TSjLT6ZOFw76bQd5a+BrW4uzeWmnrOSCQXNPnPEdA V2iyTrkldPiZbwX/EnZNICAywEd94uXHdo0o8Yas= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf Subject: [PATCH] xsm: refactor and optimize policy loading Date: Mon, 23 May 2022 11:40:24 -0400 Message-Id: <20220523154024.1947-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It is possible to select a few different build configurations that results in the unnecessary walking of the boot module list looking for a policy module. This specifically occurs when the flask policy is enabled but either the dummy or the SILO policy is selected as the enforcing policy. This is not ideal for configurations like hyperlaunch and dom0less when there could be a number of modules to be walked or unnecessary device tree lookups This patch does two things, it moves all policy initialization logic under the xsm_XXXX_policy_init() functions and introduces the init_policy flag. The init_policy flag will be set based on which enforcing policy is selected and gates whether the boot modules should be checked for a policy file. Signed-off-by: Daniel P. Smith --- xen/xsm/xsm_core.c | 30 +++++++++++++++++++----------- xen/xsm/xsm_policy.c | 21 +++++++++++++++++++-- 2 files changed, 38 insertions(+), 13 deletions(-) diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..0dfc970283 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -55,19 +55,35 @@ static enum xsm_bootparam __initdata xsm_bootparam = XSM_BOOTPARAM_DUMMY; #endif +static bool __initdata init_policy = +#ifdef CONFIG_XSM_FLASK_DEFAULT + true; +#else + false; +#endif + static int __init cf_check parse_xsm_param(const char *s) { int rc = 0; if ( !strcmp(s, "dummy") ) + { xsm_bootparam = XSM_BOOTPARAM_DUMMY; + init_policy = false; + } #ifdef CONFIG_XSM_FLASK else if ( !strcmp(s, "flask") ) + { xsm_bootparam = XSM_BOOTPARAM_FLASK; + init_policy = true; + } #endif #ifdef CONFIG_XSM_SILO else if ( !strcmp(s, "silo") ) + { xsm_bootparam = XSM_BOOTPARAM_SILO; + init_policy = false; + } #endif else rc = -EINVAL; @@ -80,14 +96,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { const struct xsm_ops *ops = NULL; -#ifdef CONFIG_XSM_FLASK_POLICY - if ( policy_size == 0 ) - { - policy_buffer = xsm_flask_init_policy; - policy_size = xsm_flask_init_policy_size; - } -#endif - if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { printk(XENLOG_ERR @@ -148,11 +156,11 @@ int __init xsm_multiboot_init( printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( init_policy && XSM_MAGIC ) { ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); - if ( ret ) + if ( ret != 0 ) { bootstrap_map(NULL); printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); @@ -176,7 +184,7 @@ int __init xsm_dt_init(void) printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( init_policy && XSM_MAGIC ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..0e32418999 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -8,7 +8,7 @@ * Contributors: * Michael LeMay, * George Coker, - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = (void *)xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif + /* * Try all modules and see whichever could be the binary policy. * Adjust module_map for the module that is the binary policy. @@ -61,6 +68,7 @@ int __init xsm_multiboot_policy_init( _policy_len,_policy_start); __clear_bit(i, module_map); + rc = 0; break; } @@ -79,7 +87,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) paddr_t paddr, len; if ( !mod || !mod->size ) +#ifdef CONFIG_XSM_FLASK_POLICY + { + *policy_buffer = (void *)xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; return 0; + } +#else + /* No policy was loaded */ + return -ENOENT; +#endif paddr = mod->start; len = mod->size; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336206.560537 (Exim 4.92) (envelope-from ) id 1ntPAp-0004fT-7Y; Tue, 24 May 2022 07:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336206.560537; Tue, 24 May 2022 07:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAp-0004fI-2y; Tue, 24 May 2022 07:41:47 +0000 Received: by outflank-mailman (input) for mailman id 336206; Tue, 24 May 2022 07:41:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP67-0003DA-Rt for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7d00::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5aa0c78c-db04-11ec-837e-e5687231ffcc; Tue, 24 May 2022 03:53:49 +0200 (CEST) Received: from AM6PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:20b:6e::26) by VI1PR0802MB2382.eurprd08.prod.outlook.com (2603:10a6:800:9f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 01:53:45 +0000 Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::fb) by AM6PR02CA0013.outlook.office365.com (2603:10a6:20b:6e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22 via Frontend Transport; Tue, 24 May 2022 01:53:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 01:53:44 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 01:53:44 +0000 Received: from f55584042583.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BDE99E5A-EDDC-412E-84E1-31C7A7729BCC.1; Tue, 24 May 2022 01:53:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f55584042583.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 01:53:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB7168.eurprd08.prod.outlook.com (2603:10a6:20b:3de::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 01:53:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d%4]) with mapi id 15.20.5273.022; Tue, 24 May 2022 01:53:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5aa0c78c-db04-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iDmA2awDW/nZqOfMJveuIetBwLN+/YzZ2XwFaNr9YQVhKAjD60JcMREvyGgzYNqFfZlwq2NZOaJjgc94W5P8S1Bameo50heRGyUhpMur0sabANZpMK6+yYxsg61wmz9mAmk7J82Ac9YybhpHo6dtz1cTPd84gaI+EaGGlUXwkZkwPLDYUqU8NNvbKwvzjXwdxTD4bBerRQXVyZ7NNQ4dJ5spO+5q0tnTqVcH+kghqs678ht1+MMaqqOo/10Zm6XrohDqnrH+JMDeendP+ZH2UrTq+kBSHUDS9nlX5xu+8H4/5mzcVcPIE+BVP2toADxETpdeAiM2neL2yBFp55VLSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbfsLqG6kt3nCXdCjZQaJuK5vul4eNOGgwf/vjiIsus=; b=bNKmSNQzVLhJp+Ml4TMuTAhf+n/0+0OSrGqvkBLGFn4YI0ggjs2dyvFdPUw4xCXnFPB6Wv40UWaMQyEEsxSSKS7/nd2h3s/VSJBQe9jHabU77bdp92itYTq1YqYDeGaxFBGRb+cfjirD2RyY/rigo/Qd7ZqmogKK2dc6IblpsVv5ucIr2D8Wvikd8GwyrpmAoMj2zEi4qLNrI0uCpCrUr2MLcYAPr3Wy/mELW1XTTFo5IgkIvqPXpcUvN+WCMS2gwggmc3IRgl27HGoC1PQhU5PwdOG6f9gkmuFJXEQjSbXmxRuxeJezuBOlmokWhzLPWJZVui/dQVkhl5QJQKnrCw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbfsLqG6kt3nCXdCjZQaJuK5vul4eNOGgwf/vjiIsus=; b=IZv4ul91Eq1Ft2LpA1t79MB0P9oQkdFR0hIH6iDkiPv0p6MR+JRsqK7AvwfgnPxOfa0718cmL0Y36n4wCR3AsNJg5kHYHfFvE9GtVt8T/Djv80+WC7tKHCuqr2Lmh9NAIvrwC5TgRcnZf9gNmIY/919jCvVsLWCadviS4y9St2w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keRRVUOwfAkEE51Rhz0eegPl93vhoGP9LNz4YUtKIhUiKr3TFMhQqjml7AhYbT5TZsu0ddQvzZ4tap+Ei8FeBrGL5q204tB5jY2YvEjCBEvfRJMZHKX8/kGxj6QLYmPPfyV+GfoCwkUivSJAegBG3ODjE16NRfsd3A3vqS4uhL9rLR2OqNbIpi++0XErhrQnxMO6GnKd4KM2aN44VNxdOLGbMZhDfWpa50QvlXKvNEJzdE3eUiGK7VujJ2woIRg67s/t4BrULfpGbQFRXhTnd4vNt2YLJuP3H2wJR7qDjDnfa5mb0fxM5vMiAQMJUcrI18sJATy2LGsm/RGCFCN+0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbfsLqG6kt3nCXdCjZQaJuK5vul4eNOGgwf/vjiIsus=; b=a/6AtzCDhiBWQnb//UzwNZH9Gg0yh2q8onj7RROemlZJ+tti31mMd3CbJ9blrrOBvYLrZ+nTgFGIXo2e0+R3Sr8yNTgw1glwPwsYBNwk6E6kcobHPPcOqZhZMFXo95f6kGV36oCCdLd7XolG3EfD0kcFmcN0Nx3Ud/8msXAkC2DdUnSyBVzo201mHzCgdrgC29rwV01io2Euitw+X2SmyEPSW6ergG/+V2flAhbXp18oT5lI05A9tHB1e989Csb5uoNfEPYiYsB3vxd6f41ZUeQymK+R+NT2f2BTLyzjPrfq6TrMrdKb6KVVBr/Tx6Qk6SB/QmV4aZcY29HhDoA58A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbfsLqG6kt3nCXdCjZQaJuK5vul4eNOGgwf/vjiIsus=; b=IZv4ul91Eq1Ft2LpA1t79MB0P9oQkdFR0hIH6iDkiPv0p6MR+JRsqK7AvwfgnPxOfa0718cmL0Y36n4wCR3AsNJg5kHYHfFvE9GtVt8T/Djv80+WC7tKHCuqr2Lmh9NAIvrwC5TgRcnZf9gNmIY/919jCvVsLWCadviS4y9St2w= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Wei Chen , Julien Grall Subject: RE: [PATCH v3 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Topic: [PATCH v3 2/2] xen/common: Use enhanced ASSERT_ALLOC_CONTEXT in xmalloc() Thread-Index: AQHYYb3lzX/A67bY90iFDVxfuK8rvK0f3b6AgA1/p8A= Date: Tue, 24 May 2022 01:53:30 +0000 Message-ID: References: <20220507025434.1063710-1-Henry.Wang@arm.com> <20220507025434.1063710-3-Henry.Wang@arm.com> <5c0e81f1-fac4-f14f-f4a1-2a00f6d16f47@xen.org> In-Reply-To: <5c0e81f1-fac4-f14f-f4a1-2a00f6d16f47@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4A4F9E7E0330D9429564DC01FC518ECD.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a86f032f-e948-4d61-2fb2-08da3d283c86 x-ms-traffictypediagnostic: AM9PR08MB7168:EE_|VE1EUR03FT061:EE_|VI1PR0802MB2382:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 441D9BRNCR52EROnkDUQDEbctPXyAKnNzHolWJGSrlRtfQ4BzGhBeG2NBz+9ULjWKRigSZ2Pl6SMnSsWtAmljmVtphlbYkqCBD7MIe4a4if2rABc20afv7WnkngwELBz1/OYBF5zTIjncQe/BFpDrzFPIsyB42Z15CNaVwqFl/1UeIxhK8+oBlN0IS02ei5gnWb7wIMv16LRquiKQY1HRlwUh8xBWV7dEtRa6y3RZSUUx0V2TpwWdZ5H4sGx0Xvkja3wuo4kgIAoGNweo3199Hi1LyJQOSajKiEjsshOOfKsRR659T/GQrJ6bPnmHjnzDcNiYj9Cm+Mq2Ljz2h11048OnyBqGhki5F90sh//zuDo9WgkNln9efzLbMooZNHUR2RbAsA5stxmic5VMAyu1eNcvznmy5mjJyJ6vwXA2sadF26k5er5fO0n/49AdpoM8sM22qhgDuKUSaNg2YSDzvYLihBIPP2b0ZnZBUQOYZULa97WJhWky3BVISKspsWL9U9YGC21xMurkTgnzokzxgH7l5Y2Qlbb1KHJhSXmF0doWMzuKNFtq0HPEwRD50+UobhXH7a31KWSl4wtlfX9YShSLgK7A5dOdSacmQyf80xdvVcvQnJYEDCxNU20Xu4mJRHafV1lgbhNNvL6iqlbnLpT/CiGPOtN42kzci5OsF4atEGMbk/P2XFesqDpN6SdWgEhYWL/IZzR07bWTqUq1Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(76116006)(66946007)(66446008)(8676002)(86362001)(66556008)(66476007)(122000001)(64756008)(54906003)(7696005)(38070700005)(110136005)(71200400001)(4326008)(508600001)(316002)(186003)(8936002)(83380400001)(38100700002)(53546011)(6506007)(26005)(5660300002)(52536014)(33656002)(2906002)(55016003)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7168 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 13812071-4b2a-444c-273e-08da3d2833a8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ndZ0QxZvJucq5QTCD11Kt6QEBj0OubnMKhfYTUq7A3+R7BxyoQbalAGJPflaYpXNQUKDMasniBLvGmKs8BxWa85olbJZhUSXeZ0+fD0wSh5Qr7OeRcdKpEVynxT5uNvxyUr7QvKaqYXSVD9y5ilOR1o802U/bDbBs7r++QBd7tF7Kp1wvzb0/nJ1FiWbFpNiMprJTieD3o3/XqiYgfXmXf/1SNyc2yJgpT424EDV5nePBp9tEFt08P2yP7gXwuwP8fEgKFsKUjGX6eW8gcyYf1umgnJWhA4TPRcqqKq9y3XEUcbWQBKyqSWLXKZiQF4Cp3hexv1UuLspR8IW7N7FTiGPmusB/DWKJDEZAE3fyt52oFSf+IEp7wvgamojDBGd5+aK/ut4ZHeyC9g7L/Wp13TC7uTihoGafU2JRUqiW+MGOaw1i8+qKL/5SEp7jV4rkPOZubHEGl9TlhUOeV+TrEXp3z8oEeJ11rHtsrkFJwYetR1yep33Cpa0UsF40Y0ci5vbHCVt+klCjP+m6mbSYpVvOe3Yp7EFI5fiAgiFicghRF4C1QskeVp+WDw87myeMEgSYGD2z+bFqCbM8e6In73EDBVAN+XjOcCwyF11Kd/Xf3imGHIGLc6N25cIjT5JQSw0tN3H8EEgrThPnN5BfyVOwvIPweW1iqhFzvdUuGsGYRVDPutfNouJeSLUVAbH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(2906002)(82310400005)(110136005)(356005)(8676002)(33656002)(86362001)(54906003)(316002)(81166007)(36860700001)(53546011)(9686003)(26005)(70206006)(70586007)(40460700003)(55016003)(6506007)(4326008)(107886003)(7696005)(508600001)(83380400001)(8936002)(5660300002)(336012)(52536014)(186003)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 01:53:44.8691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a86f032f-e948-4d61-2fb2-08da3d283c86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2382 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgMi8yXSB4 ZW4vY29tbW9uOiBVc2UgZW5oYW5jZWQNCj4gQVNTRVJUX0FMTE9DX0NPTlRFWFQgaW4geG1hbGxv YygpDQo+IA0KPiBIaSwNCj4gDQo+IE9uIDA3LzA1LzIwMjIgMDM6NTQsIEhlbnJ5IFdhbmcgd3Jv dGU6DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vcGFnZV9hbGxvYy5jIGIveGVuL2NvbW1v bi9wYWdlX2FsbG9jLmMNCj4gPiBpbmRleCBlODY2ZTBkODY0Li5lYTU5Y2QxYTRhIDEwMDY0NA0K PiA+IC0tLSBhL3hlbi9jb21tb24vcGFnZV9hbGxvYy5jDQo+ID4gKysrIGIveGVuL2NvbW1vbi9w YWdlX2FsbG9jLmMNCj4gPiBAQCAtMTYyLDEzICsxNjIsNiBAQA0KPiA+ICAgc3RhdGljIGNoYXIg X19pbml0ZGF0YSBvcHRfYmFkcGFnZVsxMDBdID0gIiI7DQo+ID4gICBzdHJpbmdfcGFyYW0oImJh ZHBhZ2UiLCBvcHRfYmFkcGFnZSk7DQo+ID4NCj4gPiAtLyoNCj4gPiAtICogSGVhcCBhbGxvY2F0 aW9ucyBtYXkgbmVlZCBUTEIgZmx1c2hlcyB3aGljaCBtYXkgcmVxdWlyZSBJUlFzIHRvIGJlDQo+ ID4gLSAqIGVuYWJsZWQgKGV4Y2VwdCB3aGVuIG9ubHkgMSBQQ1BVIGlzIG9ubGluZSkuDQo+ID4g LSAqLw0KPiA+IC0jZGVmaW5lIEFTU0VSVF9BTExPQ19DT05URVhUKCkgXA0KPiA+IC0gICAgQVNT RVJUKCFpbl9pcnEoKSAmJiAobG9jYWxfaXJxX2lzX2VuYWJsZWQoKSB8fCBudW1fb25saW5lX2Nw dXMoKSA8PQ0KPiAxKSkNCj4gPiAtDQo+IEZZSSwgdGhlIHBhdGNoIGludHJvZHVjaW5nIEFTU0VS VF9BTExPQ19DT05URVhUKCkgaGFzIGJlZW4gcmV2ZXJ0ZWQuIEkNCj4gaW50ZW5kIHRvIHJlLWlu dHJvZHVjZSBpdCBvbmNlIHlvdXIgcHJldmlvdXMgcGF0Y2ggYW5kIHRoZSBvbmUgZml4aW5nDQo+ IHRoZSBJVFMgKG5vdCB5ZXQgZm9ybWFsbHkgc2VudCkgaGF2ZSBiZWVuIGNvbW1pdHRlZC4NCg0K VGhhbmtzIGZvciB0aGUgaW5mb3JtYXRpb24hIElJVUMgdGhlIHBhdGNoOg0KInhlbi9hcm06IGdp Yy12My1scGk6IEFsbG9jYXRlIHRoZSBwZW5kaW5nIHRhYmxlIHdoaWxlIHByZXBhcmluZyB0aGUg Q1BVIg0KaXMgbWVyZ2VkLiBTbyBJIGd1ZXNzIGJvdGggInBhZ2VfYWxsb2M6IGFzc2VydCBJUlFz IGFyZSBlbmFibGVkIGluIGhlYXAgYWxsb2MvZnJlZSINCmFuZCB0aGlzIHBhdGNoIGNhbiBiZSBy ZS1pbnRyb2R1Y2VkIGlmIGV2ZXJ5b25lIGlzIGhhcHB5IHdpdGggdGhlIHBhdGNoPw0KDQo+IA0K PiBJIGhhdmUgYWxzbyBjaGVja2VkIHRoYXQgbm9uZSBvZiB0aGUgQVNTRVJUcygpIHdvdWxkIGJl IHRyaWdnZXJlZCBvbiBteQ0KPiB4ODYgc2V0dXAuIFNvOg0KPiANCj4gVGVzdGVkLWJ5OiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiBBY2tlZC1ieTogSnVsaWVuIEdyYWxsIDxq Z3JhbGxAYW1hem9uLmNvbT4NCg0KVGhhbmsgeW91IHZlcnkgbXVjaCBmb3IgYm90aCB0ZXN0aW5n IGFuZCBhY2tpbmcgdGhpcyBwYXRjaCENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4g T24gYSBzaWRlIG5vdGUgKG5vIGFjdGlvbiBleHBlY3RlZCBmb3IgeW91KSwgSSBub3RpY2VkIHRo YXQgdGhlDQo+IEFTU0VSVCgpcyB3b3VsZCBvbmx5IHRyaWdnZXIgZnJvbSBDUFUyIGFuZCBvbndh cmRzIGF0IGxlYXN0IGZvciBBcm0uDQo+IFRoaXMgaXMgYmVjYXVzZSBudW1fb25saW5lX2NwdXMo KSB3b3VsZCBzdGlsbCBiZSAxIHdoZW4gYnJpbmdpbmctdXAgQ1BVMS4NCj4gDQo+IEkgd2VudCB0 aHJvdWdoIHRoZSBvcmlnaW5hbCBkaXNjdXNzaW9uIGFuZCBJIGFtIG5vdCBzdXJlIHdoeSB3ZSBz d2l0Y2hlZA0KPiBmcm9tIDwgU1lTX1NUQVRFX3NtcF9ib290IHRvIG51bV9vbmxpbmVfY3B1cygp IChhc2lkZSB0aGF0IEFybQ0KPiBkb2Vzbid0DQo+IHNldCBpdCkuIEF5bndheSwgdGhpcyBpcyBu b3QgYSBtYWpvciBpc3N1ZSBoZXJlIGFzIHRoaXMgaXMgYW4gQVNTRVJUKCkuDQo+IA0KPiBDaGVl cnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336211.560548 (Exim 4.92) (envelope-from ) id 1ntPAq-0004vJ-Gv; Tue, 24 May 2022 07:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336211.560548; Tue, 24 May 2022 07:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAq-0004v1-B8; Tue, 24 May 2022 07:41:48 +0000 Received: by outflank-mailman (input) for mailman id 336211; Tue, 24 May 2022 07:41:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP5u-0003DA-Nd for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:45 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b34d2f76-dad8-11ec-837e-e5687231ffcc; Mon, 23 May 2022 22:41:21 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1ntEr0-00Gje9-7b; Mon, 23 May 2022 22:40:38 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b34d2f76-dad8-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LG2HkLvcft3PZ/5y+RaNtcoQpztQykGkc8EQp8pxJfI=; b=fPCMiuZns16FgBzoGF9Je3OLkO LL4L2QHAG/wGtiXgEhS21zRsWqE1LMzGwwDxe6f9KpfZaY9eV7CGD4vwhcqTRNInSSR1HDaLnpPpS miMpU8/+9j0GmfawjCEu88Tqk7uAI9V6UbtlRLQsT2Paj7KpRr9Eexx/1nt9uyC0/PRdqZ6qso//5 331flFwFw5rYDxq1lD4s7YGntuImz8x8p2XDCS463SY8sQhksTBKudAp4pKnME8DpTbZ4fGAvbQxT wafY442u8mSqR6x/cwniP7CEUq4fd8W+eVImWzP4xrptC52doj1jXiLwbdsJQSnWbw0nF1P7Xd8f/ wPYC4mSw==; Message-ID: <0dda86c0-3a54-8c70-d1e7-18bbb4d41bab@igalia.com> Date: Mon, 23 May 2022 17:40:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 12/30] parisc: Replace regular spinlock with spin_trylock on panic path Content-Language: en-US To: Helge Deller Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, pmladek@suse.com, bhe@redhat.com, akpm@linux-foundation.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, "James E.J. Bottomley" References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-13-gpiccoli@igalia.com> <6a7c924a-54a9-c5ea-8a9d-3ea92987b436@gmx.de> From: "Guilherme G. Piccoli" In-Reply-To: <6a7c924a-54a9-c5ea-8a9d-3ea92987b436@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/04/2022 13:55, Helge Deller wrote: > [...] > You may add: > Acked-by: Helge Deller # parisc > > Helge Hi Helge, do you think would be possible to still pick this one for v5.19 or do you prefer to hold for the next release? I'm working on V2, so if it's merged for 5.19 I won't send it again. Thanks, Guilherme From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336215.560559 (Exim 4.92) (envelope-from ) id 1ntPAr-0005ES-PN; Tue, 24 May 2022 07:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336215.560559; Tue, 24 May 2022 07:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAr-0005EH-Km; Tue, 24 May 2022 07:41:49 +0000 Received: by outflank-mailman (input) for mailman id 336215; Tue, 24 May 2022 07:41:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP5s-0003DA-NU for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9d17c108-db2b-11ec-837e-e5687231ffcc; Tue, 24 May 2022 08:34:51 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42E531FB; Mon, 23 May 2022 23:34:50 -0700 (PDT) Received: from [10.57.2.178] (unknown [10.57.2.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 004563F66F; Mon, 23 May 2022 23:34:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d17c108-db2b-11ec-837e-e5687231ffcc Message-ID: <06dbe73a-a14f-4b9f-4839-9c97829303ff@arm.com> Date: Tue, 24 May 2022 08:34:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> <3236e8e6-c25d-1733-9315-e0363cc73f84@xen.org> From: Michal Orzel In-Reply-To: <3236e8e6-c25d-1733-9315-e0363cc73f84@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, On 23.05.2022 22:00, Julien Grall wrote: > > > On 23/05/2022 11:21, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> >> On 23.05.2022 12:05, Julien Grall wrote: >>> Hi, >>> >>> On 23/05/2022 10:13, Michal Orzel wrote: >>>> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >>>> the number of CPUs to activate. >>> >>> The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. >>> >>> Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. >>> >>> >>> So what's your use-case/target? >>> >> - use cases where we have no big little (although even on big.LITTLE limiting this number makes sense if we do not care about the types) > > This may make sense in debug build, but for prod I think you need some certainty how which CPUs you are going to use. My conviction was that using big.LITTLE by enabling hmp-unsafe is not really used in the production systems (after all it's called *unsafe*) as it may easily end up in an insecure/unstable platform without specifying the cpu affinity (which must be done carefully). > > So I would like a warning in the documentation "maxcpus" that in big.LITTLE system, there are no guarantee on which types will be used. I'm fully ok with adding this warning. **WARNING: On Arm big.LITTLE systems, when `hmp-unsafe` option is enabled, this command line option does not guarantee on which CPU types will be used.** > > This is technically a lie, but I don't want a user to start relying on how Xen will parse the DT. > >> - debug cases where we want to set maxcpus=1 > > Thanks for the clarification. I would be happy to add my tag with a warning in the documentation. > Does it mean you want to do this on commit or should I handle it in v2? > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336219.560570 (Exim 4.92) (envelope-from ) id 1ntPAv-0005bY-5h; Tue, 24 May 2022 07:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336219.560570; Tue, 24 May 2022 07:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAu-0005bE-WD; Tue, 24 May 2022 07:41:53 +0000 Received: by outflank-mailman (input) for mailman id 336219; Tue, 24 May 2022 07:41:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6G-0003DA-Qx for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:05 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b71cd5b5-db0e-11ec-837e-e5687231ffcc; Tue, 24 May 2022 05:08:01 +0200 (CEST) Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 23:07:55 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by DM6PR03MB4697.namprd03.prod.outlook.com (2603:10b6:5:187::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 03:07:52 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 03:07:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b71cd5b5-db0e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653361682; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=hNlEnTzWezV0G3prfGmrmRasyQNBCWKc8lZzdRKhSP8=; b=FpXPpfVQIEktU559+EpIwmIoGg+5g5AISz25S75GG7WXyZukpo0zMpPI 7yuaKEz6ht/KdNaUs+tZVbxK4H2I9OOsPpoaJx/si0uRiNeFeBYZK1b9D 0ZDlGQTBA2rTkIZ/LQJQkZmg1AEHVGxskE5x5N0tLsWQKIy+SBd47nay6 M=; X-IronPort-RemoteIP: 104.47.58.109 X-IronPort-MID: 71866064 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IVMPDKxUByCouOxiyYZ6t+f3xyrEfRIJ4+MujC+fZmUNrF6WrkUPz jAeC2DTMqvcZmameYp2YY6x9E0H7JKEzdNrG1FppCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY124PhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl9sCCe1t1BvP2h7pMdURhVBFlA6J09+qSSZS/mZT7I0zuVVLJmq0rIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeE+OTvY4wMDQY36iiGd7aZ sxfbTtyRB/BfwdOKhEcD5dWcOKA2SCvLWMA9g79Sawf33bs9R5R3J3UN/2Ee5uFaNdYmXugq TeTl4j+KlRAXDCF8hKn83upi+6JrSL2cIsIEfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDTNPwQhm5q36spQMHVpxbFOhSwAOQzqvZ5S6JC25CSSROAPQMudUqXzUs2 hmslsnwGD10mLSPTDSW8bL8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nZslnOL64iJvyAz6Y/ tyRhC03hrFWgctV0ay+pAjDm2j1/smPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:7926XqowXS8T8D3+Gisv3WMaV5ueL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7CZnithILMFu1fBOTZslrd8kHFl9K1kJ 0QC5SWa+eAQGSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O UkZS1Qe/ibpUmhOV1d6iGdpjUImAxel0MKj2XozUcL6PaJOw4SGo5Pg5lUfQDe7FdltNZg0L hT12bcrJZPCwjc9R6NruQgeisa4XZcm0BS59L7TkYvIrc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFUgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCfefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve8PcV T6ISZlXEIJCjPT4Je1reN2Gzj2MRWAdCWozN1C7J5kvbC5TKb3MES4OSITr/c= X-IronPort-AV: E=Sophos;i="5.91,247,1647316800"; d="scan'208,217";a="71866064" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQtL2KQHw1b1oa4kYclDU6sHhjd8GWYPD6G8687R7rvEfQ73AY23E9biRuCANFu1fbxaj3B/W0uLVibRpCrDAUQOvLjCAgDdvmMG+k1KPlqQimRalPJiQEmWJvE5Kq+ehlB7vvT8SDoKUiD29N3DX6AmWzJjEZySgmNzIkN+cQgl6ZbmEjKTsOstN2UByDUOCq/xxziR4D71QQsOC6Oy+mgiWPiH42bYbDnPuwbypHQMRtMt5a6/jkMcstEozgq6tfghhPsYfeQy3Aj36P+BjVjGHyatzFKxnhbV6BAPlIJb6kqj9ycTUs0g6oq1JheqV3QfYRbFcBm9FIhwsjGyBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XLrG1aIGjmGm10Nmgd6WP4qWMEf7/3BJnSd3QIT9hCY=; b=fgvG7vdgzS3fTd0jY53jFBE9H45PQcx7qc+y+MyBW81CjMOmCKN0VZlVXPprB6dbQZg3slOnMIgJF0LtorTQ4+w1uOLf0Kubf6M3W+iBID3wzaAjy+LeR8+4t3g1HJVzC93YkkWDAZF5sYN2+sxvMiGNE6RcXayvAHnzQ14r9G3XnpIgzqSKxYi6UGOUuQtCM95wiYm2GtoTDjrFKRUTN7/1fwpa/U1+D4IFw+en++KwtpqLz0JPPEGVWjuyX4QrIgAdNAskoc5FvkjL2dtKOtbglNi0ZIo+SrV46qcixKuB8gOP72N9t0NkeBWVWpmzsIPXvGgVzKNq9EK9+xuTig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XLrG1aIGjmGm10Nmgd6WP4qWMEf7/3BJnSd3QIT9hCY=; b=qjdDD3GYkQo0rK8wTscBeq70yhayj2QXkfAuzntvN/X6K6V5H/MBAp/sgqN7exHO1Eg0Whe9Yhvo/TZxiXORyMpD4AkZMlWkPu2hUVPrbpTS/a5MMxeNBIESZwNh6f2qn/aafYt2HanzcdttdwWfE3cNMizLgAdv6jy1R3gRbuw= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Bertrand Marquis , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v5 6/6] byteorder: Remove byteorder Thread-Topic: [PATCH v5 6/6] byteorder: Remove byteorder Thread-Index: AQHYbrSc++uK2cN+REiJWQQiDNiVmq0tVA6AgAAEzpI= Date: Tue, 24 May 2022 03:07:52 +0000 Message-ID: References: <1b9957326f5018c38ce6c523e3e5ab67f012ac00.1653314499.git.lin.liu@citrix.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15575864-f835-48ff-6de2-08da3d32976e x-ms-traffictypediagnostic: DM6PR03MB4697:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 52L4F7qU++IIbg8p1fVY8UqKHYGVO91ngVJt7/ijmCEUfzhAZ5O9l3zHJWvMpYMssF7q2HMWIcEE0zmfCtWcNdaqnUGPWYOJ6ZI10sgXARUVkSP14Hp/bAxc+2GpjPXA7wqrEGvHhg9QcEu4dwja38z9OfStf/nJNIMFtA0AamczBbSWjmdbSPM2IZISXFvL2Fs2pU9WyFpp1aHWszqs6c9xZ0qWOxeQoZUaGCVgk8dAAVxKz6dJpFkn452XtnVgI6j51taL2dt/z9lP+wLH5pR5oO9oR0FijGmokom+KMpFA15ttDu3SqsRQ/22MJJl3VC0vbX2LUck6qw8FI6AOWketbArOZ6H4YDSI0JvBoXUDazxSICZ3m1ygfjIqEdscaVuit8YLfmcDzZRYf/c8m0MOuHXtobLYMN2MMEO1Qi6tAVaFw2xHTIm2Bp2ig2lSIWnhBwSUFyIJpEwDjVPIurEiGJv7Y9ULTVB0Elm3WBhaA5bEFG+uM6ch8bttIc2BTvrvmwSlJdGQ3dnPuZ5nlCBVzD3BvDroXAnkRmJxNQXDXEpSCLcwt68edxiTUxo/RJMmE0bHbGcCLl947mPE/NoQJDitpGTjsMpt27UcghylrVIEPTD3YN8X068uvSqKKeR5JxHDl38Eac7BvBhrEjWv+IybWig/gWd5cECVBIDF/tRSR+z+rI8rATd4pcQUOTeBdlcfU29uaAe5+1tvw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(316002)(5660300002)(55016003)(83380400001)(7696005)(33656002)(38070700005)(38100700002)(8936002)(54906003)(186003)(52536014)(110136005)(2906002)(66476007)(26005)(66556008)(82960400001)(64756008)(66446008)(86362001)(4326008)(76116006)(8676002)(85182001)(66946007)(91956017)(9686003)(122000001)(558084003)(6506007)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?cVVLWlhxOVZkTzVyL1ZrRExZdDhJYURYL1BkOFQrWWoveFFOMEdHbnczRkNh?= =?gb2312?B?K3o5cEFtRFdIbGRHTk9TajBCdmpJcmFqNmg2QXROd3Bhd1hycUZGRDhSWnEz?= =?gb2312?B?MmxIbklXNFJRSGtYc0hUTmQyNGQ1MHZNd0Q0Q1VhNFNjME1qZ3QrUEFxWVNJ?= =?gb2312?B?WmVpbElvU01pTWx0ejk4dDFXTG9mYlZtL0wyR3lrSnduYk55V1JhM0lhNGdw?= =?gb2312?B?anpwaEFYVTJIY1krYVNQMktIa0pDdWY5SmJGeTRzWmdNcW5IbDNSQ21iQWRj?= =?gb2312?B?Y0hBZHR2TWtCSnFPNkR6cTRlUkVmZXpiRzhZbnNwTm9mK2NScFNseFJiRW8y?= =?gb2312?B?QlRXOXJEanVsVHlTQU9iV0h5Y0pLWFU0NHJjM3RwWEowVVdQTWlPNHoxUnIy?= =?gb2312?B?c1NBNUxCa09rWHVjVE1nMkcxVWwyWTNTMlRWSXJod3NHVjlUcXJLM2xFUkJ0?= =?gb2312?B?STNFR1RoalVCd0EySGQrZ0diQnlzRzdoellYemdTYlNRN3RuWkd0MXE5d1FF?= =?gb2312?B?VVdzRks2OTBmcjNIRXRSdENyRlF6VDhtM0ZmT0lNeExNUEFzaUZEc2pvNE9P?= =?gb2312?B?Q0NmOFgwdVdiaGNFc2pHZDA5YVJqQ0dyZjJ0cTNEQmJFWklFMC9QVHVRSkhI?= =?gb2312?B?dnR4YklUQWNUUEdEODdxdmxWZHhvaFBpZ2RNM1R1OFl1VXV1eDFlMTFXVzZp?= =?gb2312?B?Tjc1aU5ZYmdjMVMza1RPWnErZ1dqcmFkZmpoZGJ5ZTl1UFJqaVVpZEEzUUxj?= =?gb2312?B?V2RqTmp2K1MxV04zS0ppNGlDZWpYdmxOZUtJc1g1U1U2OXArOXVyNHBMU0dW?= =?gb2312?B?c3dzQnZSSjJzSkhyMGROcjdhNCsxQ0hGQ1drWkdtMlVZbkpHN0pQUVBjQjNC?= =?gb2312?B?L2UvNzNUTGo4cy9Ca2M3RFUyMFQwQ3pBME9iRHhjc21PaUZia3dxenJaUk1I?= =?gb2312?B?R3JhK0QrV3BHR1lTbmNMY0dSZWlBQ0lBbWtSVGpDUDcvQVNQZ0RodHduYnRk?= =?gb2312?B?RHA4WXNTTTZldTVlNXFoU0R3R2o4N3J3aDlwUTZ2TSsrOCtOR2c3Nkd6WEdi?= =?gb2312?B?KzRXMzZENDc0TDU5Q1BFYjh6NXRxT08zOUlTRDhFRUhEejI5bGo4ZGNPaFND?= =?gb2312?B?bzJCV3RDSDdpSFMwUEFaZmpaSyt3eURKeFFRYnRKb2dlTEdmUjBCVlVPSVkz?= =?gb2312?B?WXVoMERnOXMyejJWbk9ZRnpON1J0emVHQmJxa2VVcUYxWnZDY2tDV0w0alRU?= =?gb2312?B?YXVRZHZoVmV6emsyY0NZRmc4TFpGWDIxVlU2cjR1TjhZYTJ0WFFraGZJYW1G?= =?gb2312?B?UkIwRnR2L0lWOCtqc3JoeXNiUVhQZ0tBamtvdGk5QmxQUlpEdThlOWJjUDcy?= =?gb2312?B?QkVTakFibzZLRXdNK0RLdFluNm1RbGtQWXNzT0VOZkp1akJUY003REo4YlpH?= =?gb2312?B?ZmZMOVhoSmFISEFFY0FUakxPVDFzdC9WRWkzNXdzYW53akJhRTRmQ0NCME9k?= =?gb2312?B?eGZuUjR1cjZnMVd4djBCQXZqR1ZGRDZRLzNmdlQxY2ZsV2VDek5JVmcvY0tM?= =?gb2312?B?aWs2ZnVxbWgwSnNBc1MwS092TzdwdW4xbTBIOTlRU2NlZzZtWCtaWS94ZXll?= =?gb2312?B?cENHVGFwaG1ERlo3ZmxsY3VBZkdzU0h4N1BqL2Y0cHBtNHh3Q0pEM2lJTFU1?= =?gb2312?B?TUZQNHFDR283S1JSUmtuSzZkbzlKT0NzK01QVDQ2QktYNENBbU9GczB3cVJH?= =?gb2312?B?YkY2STNmYzhZRytKMWlPSTM2VEhFSFJaOUFreEFJZkoxL2tObWhuWU9xQmUr?= =?gb2312?B?N0lKMTZGaS9MdERQUjh5Um85dVBmOWVoOGRtcVVhWmQrY3JLUFRQdjgvWlJQ?= =?gb2312?B?dCtvQlR0d1g0alorWlduVUdXQmtiajQyejZ0dGxGTTU0UElRK1pUUnF4NXU1?= =?gb2312?B?QjJSY3EwWmd3cWpDcTlYeHZMYkJkclhkRWVHMUU0WDR6MlRTbVhFNC9vU25L?= =?gb2312?B?S0plaGhvcWMwLytLbWptSWtwUHlKNk9lSkdHSEpLamtSbG50dHR2czNJczFx?= =?gb2312?B?SFJVcTdaQytmbGk5cXk4MVlVTEw5cEFxbjI4cXd1S2dqY3NSUG02SDZFNU03?= =?gb2312?B?bzk5UmdqbUs4TGZBSjh4T3ZDS3RZNG5jMlJwbGFZR3BsVHNOU3JEb2FJTEZK?= =?gb2312?B?K25CSVBSYXI5QUJGZ0VtcWF2SGpGWEdaTVlvNHBaZW9qSjA4cW9BOXVXV0VF?= =?gb2312?B?L0xUQTJ1LytVTExZTVhDaTRxUDFpQkdWT0FaUzZFRWJrbEVOVXd2NXFpTE4x?= =?gb2312?B?OTVRZmJwMy96dFBlYVVONUl4ZHE0RGNwNi8zNjZibTBoWmMwM3QvY0I0SFBI?= =?gb2312?Q?BIPh5N/6AogdvASg=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB540555E8E75BECC3E693F0ED9DD79SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15575864-f835-48ff-6de2-08da3d32976e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 03:07:52.4133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h5gD+7uCyMVFFLTfqTrB4dhZgxJck1GEBj7hV1vsWK+x+3ke4IYxgiT/2Ww4CuHXVyuzMmd8yyxNbtiMLV8KOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4697 --_000_SJ0PR03MB540555E8E75BECC3E693F0ED9DD79SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Pj4gU3ViamVjdDogW1BBVENIIHY1IDYvNl0gYnl0ZW9yZGVyOiBSZW1vdmUgYnl0ZW9yZGVyDQo+ Pg0KPj4gaW5jbHVkZS94ZW4vYnl0ZXN3YXAuaCBoYXMgc2ltcGxpZnkgdGhlIGludGVyZmFjZSwg anVzdCBjbGVhbg0KPj4gdGhlIG9sZCBpbnRlcmZhY2UNCj5UaGVyZSBpcyBhICB0eXBvLiAgIHMv IHNpbXBsaWZ5L3NpbXBsaWZpZWQgLy4NCg0KVGhhbmtzIGZvciBwb2ludGluZyB0aGlzIG91dCwg d2lsbCB1cGRhdGUgaW4gbmV4dCBwYXRjaA0KDQpDaGVycnMsDQotLS0NCkxpbg0K --_000_SJ0PR03MB540555E8E75BECC3E693F0ED9DD79SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

>> Subject: [= PATCH v5 6/6] byteorder: Remove byteorder

>>

>> include/xe= n/byteswap.h has simplify the interface, just clean

>> the old in= terface

>There is a = ; typo.   s/ simplify/simplified /.

 

Thanks for pointing= this out, will update in next patch

 

Cherrs, =

---

Lin

--_000_SJ0PR03MB540555E8E75BECC3E693F0ED9DD79SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 24 07:41:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336223.560580 (Exim 4.92) (envelope-from ) id 1ntPAz-000669-Mv; Tue, 24 May 2022 07:41:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336223.560580; Tue, 24 May 2022 07:41:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPAz-00065q-IR; Tue, 24 May 2022 07:41:57 +0000 Received: by outflank-mailman (input) for mailman id 336223; Tue, 24 May 2022 07:41:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP5z-0003DA-OU for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:47 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa6e2c68-db04-11ec-837e-e5687231ffcc; Tue, 24 May 2022 03:58:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A009B8171B; Tue, 24 May 2022 01:58:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0355CC385AA; Tue, 24 May 2022 01:58:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa6e2c68-db04-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653357495; bh=Cv9XZBa4Hc/gWPaETmcVdmUQuN7p5/VU3A7uzoNojTk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OSoLdx+BBzfvf8wv36fAozO82JJNlzeO9vQ1p/JEsvOCSYSnJbw2wtgCh19TDHhHy /BPY1AY423sAwNT2orpFJ7slTyygINF1MK+6dQeA2VOBmNEVvw+sI6H8xvHjtaYd3f FDur2l6Rz7WLduTHmfvb6RfgBdvBctbshDJHwVVMXV7gspqB1IwzwQpz4UWL9C30UF XztCByCNAXI3IayBHiVgxFrl7fDtalsqMYnoNzg3pQsnBsA6r4tMGYyYD/FF00nHNF 5sGFu13IN/UVYghw9VbrG7c44KSxvwomO+GDHsxawwTtbB6PgXN3IJWMIFX/u5Up1k obVnFHYKI18kQ== Date: Mon, 23 May 2022 18:58:13 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr cc: Stefano Stabellini , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops In-Reply-To: <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-279637414-1653357495=:1905099" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-279637414-1653357495=:1905099 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 23 May 2022, Oleksandr wrote: > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > > > > > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > > > > > > > wrote: > > > > > > >     This would mean having a device > > > > > > > node for the grant-table mechanism that can be referred to using > > > > > > > the > > > > > > > 'iommus' > > > > > > > phandle property, with the domid as an additional argument. > > > > > > I assume, you are speaking about something like the following? > > > > > > > > > > > > > > > > > > xen_dummy_iommu { > > > > > >       compatible = "xen,dummy-iommu"; > > > > > >       #iommu-cells = <1>; > > > > > > }; > > > > > > > > > > > > virtio@3000 { > > > > > >       compatible = "virtio,mmio"; > > > > > >       reg = <0x3000 0x100>; > > > > > >       interrupts = <41>; > > > > > > > > > > > >       /* The device is located in Xen domain with ID 1 */ > > > > > >       iommus = <&xen_dummy_iommu 1>; > > > > > > }; > > > > > Right, that's that's the idea, > > > > thank you for the confirmation > > > > > > > > > > > > > > > > >    except I would not call it a 'dummy'. > > > > >   From the perspective of the DT, this behaves just like an IOMMU, > > > > > even if the exact mechanism is different from most hardware IOMMU > > > > > implementations. > > > > well, agree > > > > > > > > > > > > > > > It does not quite fit the model that Linux currently uses for > > > > > > > iommus, > > > > > > > as that has an allocator for dma_addr_t space > > > > > > yes (# 3/7 adds grant-table based allocator) > > > > > > > > > > > > > > > > > > > , but it would think it's > > > > > > > conceptually close enough that it makes sense for the binding. > > > > > > Interesting idea. I am wondering, do we need an extra actions for > > > > > > this > > > > > > to work in Linux guest (dummy IOMMU driver, etc)? > > > > > It depends on how closely the guest implementation can be made to > > > > > resemble a normal iommu. If you do allocate dma_addr_t addresses, > > > > > it may actually be close enough that you can just turn the grant-table > > > > > code into a normal iommu driver and change nothing else. > > > > Unfortunately, I failed to find a way how use grant references at the > > > > iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I > > > > am > > > > not too familiar with that, so what is written below might be wrong or > > > > at > > > > least not precise. > > > > > > > > The normal IOMMU driver in Linux doesn’t allocate DMA addresses by > > > > itself, it > > > > just maps (IOVA-PA) what was requested to be mapped by the upper layer. > > > > The > > > > DMA address allocation is done by the upper layer (DMA-IOMMU which is > > > > the glue > > > > layer between DMA API and IOMMU API allocates IOVA for PA?). But, all > > > > what we > > > > need here is just to allocate our specific grant-table based DMA > > > > addresses > > > > (DMA address = grant reference + offset in the page), so let’s say we > > > > need an > > > > entity to take a physical address as parameter and return a DMA address > > > > (what > > > > actually commit #3/7 is doing), and that’s all. So working at the > > > > dma_ops > > > > layer we get exactly what we need, with the minimal changes to guest > > > > infrastructure. In our case the Xen itself acts as an IOMMU. > > > > > > > > Assuming that we want to reuse the IOMMU infrastructure somehow for our > > > > needs. > > > > I think, in that case we will likely need to introduce a new specific > > > > IOVA > > > > allocator (alongside with a generic one) to be hooked up by the > > > > DMA-IOMMU > > > > layer if we run on top of Xen. But, even having the specific IOVA > > > > allocator to > > > > return what we indeed need (DMA address = grant reference + offset in > > > > the > > > > page) we will still need the specific minimal required IOMMU driver to > > > > be > > > > present in the system anyway in order to track the mappings(?) and do > > > > nothing > > > > with them, returning a success (this specific IOMMU driver should have > > > > all > > > > mandatory callbacks implemented). > > > > > > > > I completely agree, it would be really nice to reuse generic IOMMU > > > > bindings > > > > rather than introducing Xen specific property if what we are trying to > > > > implement in current patch series fits in the usage of "iommus" in Linux > > > > more-less. But, if we will have to add more complexity/more components > > > > to the > > > > code for the sake of reusing device tree binding, this raises a question > > > > whether that’s worthwhile. > > > > > > > > Or I really missed something? > > > I think Arnd was primarily suggesting to reuse the IOMMU Device Tree > > > bindings, not necessarily the IOMMU drivers framework in Linux (although > > > that would be an added bonus.) > > > > > > I know from previous discussions with you that making the grant table > > > fit in the existing IOMMU drivers model is difficult, but just reusing > > > the Device Tree bindings seems feasible? > > > > I started experimenting with that. As wrote in a separate email, I got a > > deferred probe timeout, > > > > after inserting required nodes into guest device tree, which seems to be a > > consequence of the unavailability of IOMMU, I will continue to investigate > > this question. > > > I have experimented with that. Yes, just reusing the Device Tree bindings is > technically feasible (and we are able to do this by only touching > grant-dma-ops.c), although deferred probe timeout still stands (as there is no > IOMMU driver being present actually). > > [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ignoring > dependency > [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks (2.10 > GB/1.95 GiB) > > > Below the working diff (on top of current series): > > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c > index da9c7ff..6586152 100644 > --- a/drivers/xen/grant-dma-ops.c > +++ b/drivers/xen/grant-dma-ops.c > @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = { > >  bool xen_is_grant_dma_device(struct device *dev) >  { > +       struct device_node *iommu_np; > +       bool has_iommu; > + >         /* XXX Handle only DT devices for now */ >         if (!dev->of_node) >                 return false; > > -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); > +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); > +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, > "xen,grant-dma"); > +       of_node_put(iommu_np); > + > +       return has_iommu; >  } > >  void xen_grant_setup_dma_ops(struct device *dev) >  { >         struct xen_grant_dma_data *data; > -       uint32_t domid; > +       struct of_phandle_args iommu_spec; > >         data = find_xen_grant_dma_data(dev); >         if (data) { > @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) >         if (!dev->of_node) >                 goto err; > > -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", &domid)) { > -               dev_err(dev, "xen,backend-domid property is not present\n"); > +       if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", > +                       0, &iommu_spec)) { > +               dev_err(dev, "Cannot parse iommus property\n"); > +               goto err; > +       } > + > +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || > +                       iommu_spec.args_count != 1) { > +               dev_err(dev, "Incompatible IOMMU node\n"); > +               of_node_put(iommu_spec.np); >                 goto err; >         } > > +       of_node_put(iommu_spec.np); > + >         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); >         if (!data) >                 goto err; > > -       data->backend_domid = domid; > +       /* > +        * The endpoint ID here means the ID of the domain where the > corresponding > +        * backend is running > +        */ > +       data->backend_domid = iommu_spec.args[0]; > >         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, >                         GFP_KERNEL))) { > (END) > > > > Below, the nodes generated by Xen toolstack: > >         xen_grant_dma { >                 compatible = "xen,grant-dma"; >                 #iommu-cells = <0x01>; >                 phandle = <0xfde9>; >         }; > >         virtio@2000000 { >                 compatible = "virtio,mmio"; >                 reg = <0x00 0x2000000 0x00 0x200>; >                 interrupts = <0x00 0x01 0xf01>; >                 interrupt-parent = <0xfde8>; >                 dma-coherent; >                 iommus = <0xfde9 0x01>; >         }; Not bad! I like it. > I am wondering, would be the proper solution to eliminate deferred probe > timeout issue in our particular case (without introducing an extra IOMMU > driver)? In reality I don't think there is a way to do that. I would create an empty skelethon IOMMU driver for xen,grant-dma. --8323329-279637414-1653357495=:1905099-- From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336232.560591 (Exim 4.92) (envelope-from ) id 1ntPB1-0006KC-Ph; Tue, 24 May 2022 07:41:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336232.560591; Tue, 24 May 2022 07:41:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPB1-0006JQ-6F; Tue, 24 May 2022 07:41:59 +0000 Received: by outflank-mailman (input) for mailman id 336232; Tue, 24 May 2022 07:41:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6f-0003DA-VE for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:30 +0000 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55a081ad-dac2-11ec-837e-e5687231ffcc; Mon, 23 May 2022 20:01:14 +0200 (CEST) Received: by mail-qt1-f170.google.com with SMTP id g21so4644559qtg.5 for ; Mon, 23 May 2022 11:01:14 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id y2-20020ac85242000000b002f39b99f6c4sm4573161qtn.94.2022.05.23.11.01.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 11:01:12 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id x2so26474862ybi.8 for ; Mon, 23 May 2022 11:01:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a081ad-dac2-11ec-837e-e5687231ffcc X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N4rBBcobCQCpRnDX0N4E6NWTW64w3K1pdJQpMj8qNhc=; b=y6RadUp4wQj9jBXhaazYsxG8oQiK1rVeHfq1ev4q9Sx/EI9maaq9kY2cK6bRMhPCSP 5+eQzPyNEM48nHEBzkDGY4d63x1qzxpwZoW/tVpE1gFKDEkPsEOnytD1B1uUF1Oed9SO QvXQ01o9JVy8bn4uQMZhX5skN9ra/Ku76CqCltsHh6q3TvEwMJOIGdPfrMIZD8O4Y6mP 1tmMd+ZCGwmK+LOJ/cMdRg93dpHtIozfgRc5Pb3zNxhRmymrTzyAVmD+145FzmZXJuN+ 9OsTuKs/2NJzR2tsC47NxfFrxzi+n2e+0QrZv71rMghBBK/3LSW8S3kkF3hxYdV7SkGJ Vg6g== X-Gm-Message-State: AOAM531foEnqPeKnrAiS3iysvjrsPRActHN9B0CZpT3H/iNGvqi4gKMI sbz1Sn0BKKSx9kj99Aeb5nvs/aIyvHFYecxktV0= X-Google-Smtp-Source: ABdhPJxrgCQkt4YlApx/X3lW/cYTC6wPuP0E3c2ZnkOjLSK7XFEkMXiNvVCk4FPEaF7nnwvCpEVvSw== X-Received: by 2002:ac8:5dcf:0:b0:2f9:15de:2e40 with SMTP id e15-20020ac85dcf000000b002f915de2e40mr15295924qtx.526.1653328872813; Mon, 23 May 2022 11:01:12 -0700 (PDT) X-Received: by 2002:a81:ad11:0:b0:2fe:fb00:a759 with SMTP id l17-20020a81ad11000000b002fefb00a759mr24887559ywh.283.1653328860919; Mon, 23 May 2022 11:01:00 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 23 May 2022 20:00:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 00/27] Introduce power-off+restart call chain API To: "Rafael J. Wysocki" Cc: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra Content-Type: text/plain; charset="UTF-8" Hi Rafael, On Wed, May 18, 2022 at 4:46 PM Rafael J. Wysocki wrote: > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > wrote: > > m68k: Switch to new sys-off handler API Sorry, I didn't realize this was going to interact with the new m68k virtual machine support, which is included in the m68k pull request for v5.19. > However, I'm going to send a pull request with it in the second half > of the merge window, after the majority of the other changes in the > subsystems touched by it have been integrated. And presumably you will have to merge in v5.19-rc1, too? I've sent a fix. It should appear at https://lore.kernel.org/r/20220523175520.949681-1-geert@linux-m68k.org soon. Can you please include that in your PR? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336237.560594 (Exim 4.92) (envelope-from ) id 1ntPB2-0006Rn-A9; Tue, 24 May 2022 07:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336237.560594; Tue, 24 May 2022 07:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPB2-0006Pk-1h; Tue, 24 May 2022 07:42:00 +0000 Received: by outflank-mailman (input) for mailman id 336237; Tue, 24 May 2022 07:41:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP65-0003DA-PM for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43e1c0ab-db28-11ec-837e-e5687231ffcc; Tue, 24 May 2022 08:10:52 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-iegNRE-0OPed9pyZqiSXbg-1; Tue, 24 May 2022 08:10:50 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4278.eurprd04.prod.outlook.com (2603:10a6:209:4f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 06:10:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 06:10:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43e1c0ab-db28-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653372652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oiiin2fQMQS4EZaMXnr26yzo2cSHCgsSDTPD0QPCSl8=; b=Bn1O0knBK5upumSLzryL05ND6tR8QiXUCl5X9/czxU/rjFD0tABxyASe3ze+8kqhZx2zKl KSbBr/jB+1YPTnlikl4+C0zGXqtn00ylcU/Mq3pTPrh1vFXQZbmFlyWhplbaxtU2G5qnp3 zPzA33lWN0u5r31wGYsJdf/j4n50mcg= X-MC-Unique: iegNRE-0OPed9pyZqiSXbg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaqDKiA2sPpaCaFeWaVXkZ49ol+RWUsL8Hs3Sn5hvHBgm56SdDubJrhGm4n9WK6ysUSNEpxUiXxz7HFFZyCe76JrqYuzhvPBEQEGwwMPvu8RxYgyMwqeLo1RcnbHHsAXzZ11gouhl9dg68wrwn184A4oEqpAJppGF/DjTEmckFPevyhEGJMPwcbkSBQmgFFpsLc2Sdbop6faNffKYuKoMz2aWyZrM4/997vYMISyFrXVwB5hc2m61vWiy1pO/4XQVdhT+h9XQ4k2hfLVvg6hTeaZGQXs2yLP28bD+lmaIB9YiN6BHLqPeQtvIO4POHmQGZUnR0bjNxx0AKspuDfrsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tn4hMaJcCrqE7Eqs0AynlLT1KQMGQksU5uGKvluQd6k=; b=JZLdPjNzpgyaqKeg8DTg5J7RSBQ8PKLVwBOxZ7uEbQjCf871/IquIHDiuK/bR39PC0XT8E4oGixmUI6ii8f8zS9jcYtBzadWWii6v/OS6n+us5iEiYhyoi5t9Y6pdhqrSyGp/0Xi8kHiMWzM4eV7Cgbwnl7qWVzMqOPTf5RPquvLBh8Zz5VLmNyKgRQl/k9bwEtBE0pZ41iQVz7+duUnU8ASCDOGVaj7LoEHtCoX1eXmpS9hBmQhVq1G8V+hLdEUfuhWuKh1V22f/ZqY6vAfXF77XkVf5wNq+LPnjUcl+QHKkC/mcH10p4t3zLU5+BmU4dNlI9RcX0gMQuv+x+onDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> Date: Tue, 24 May 2022 08:10:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Content-Language: en-US To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0395.eurprd06.prod.outlook.com (2603:10a6:20b:461::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1f68bce-ade7-498f-af04-08da3d4c2512 X-MS-TrafficTypeDiagnostic: AM6PR04MB4278:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nYg26GWmj0rKjeGN3G/5BRYLpOQ0R3mHSi3WAMiPGZ73uB5CCNui6+UZiNMIPuDSfQTxXN1fAAkxQo2YdSJjSgWJBz6vDu8i2XoZR6sJlsnL/9SAItsvftS46fPOwYpFB//a908TNxy4DXCRrgEwtGOs7Ue9g22KF+fm/yIS84iBypFC9tA1uhSiWP2PO8dusfbdx9lmJokFIVzSRfGRdoZ2sQTDTwa99wrWcIR6wd3E4GFjmTBW1f0l/ObahUBnWFfI/iqF1TIkcYbfTnVqyrrJZMNUAjjYjDE4LnjhmWeZzk/6F/M6Wzy3NLYxP/Z3nVQVKn2xfvls5J5Q1gYakSBdz2lJuPvPq2UBcgIXLq94WKEG85Db70ssJxcn3B8SzHGqmDzng2N4GDyI29pNK5iFepgj1hEZyx9GwyxK9qoB+1YUbAHn7V6ZC/lZuyN40iXRAMMDl0l3YeE/82bkF+/48W5QvyZMyoldD1WZUbRuSx2auTDTRMqTIxgGI2juxQqu3FQN/Uo98nKWPcLS8cPp1JJ3WPvm49yFHZGA6xxI690QBlOGgcKKIwms2aHaC5tBzGYiTgKKvwYgZf3lQvNqS6+/zSg/OqrwltSRTPyNQ1ZBKWI2DLrY49UuNm1alOU0PRD8JQwdLsU72lql0N2RjlHp3swUulgWgBCndyqsH4OEPvQ9QIbvtp5Lz/cKq88I01O1vTImxWyDAXfUtj1J4i9YckzBH01JqcbxCKc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(4326008)(8676002)(66556008)(2906002)(6666004)(66946007)(54906003)(5660300002)(4744005)(66476007)(6916009)(8936002)(316002)(86362001)(31696002)(6512007)(6486002)(508600001)(26005)(6506007)(186003)(31686004)(53546011)(36756003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Mh2XvWzYHSKpWAN+mn+8VvoHdPXuqe3DjOavlAIe+/DU4ABF6fFXYRxwdyDi?= =?us-ascii?Q?6ktUttdACP+rmRXh8pv4xDG3G0RxEHsN5Mf+2bLyW6AGuViPnIvGWzx8R4oJ?= =?us-ascii?Q?aq76A69RsnadDtMENpRvE9jYH8CFdffJC20iuM6GKWfB/ddh4MaS6pTQYkI7?= =?us-ascii?Q?itGT9lk3cITU9m3C6YiT2D32LGjyszT/OTMsWCIcaMxrRaUE7CTWt8a6ovsL?= =?us-ascii?Q?TcarrfGMal28lfehmduEvywE7kK6NpkAEMWJvwzs7CS5oSNv5xs/bGPByXuW?= =?us-ascii?Q?xnR8RL0TS1+DXtnfbq6Ih3RjntoSDBoiw7v/v54Lz3VSVRlTPF781pTZrRuM?= =?us-ascii?Q?s9QfhbEJPnf8/GCtNA+BPNvkdwW2PkWsAACPBzCH4QVFezNfGSAiwzDHnsbQ?= =?us-ascii?Q?TodRsfjGTRuG4fM1f0ERq5GWqct4yjFjoqU7fEmVmOT1TAl09JZF8z5V4kCx?= =?us-ascii?Q?yElHgeNdenvV4n5UvB1+yAiByk4Qg1Ts7V+NmtmvKCtGinBLL1gBbZs6UGYa?= =?us-ascii?Q?B8/2/Ca58rUYKSL4+q9EUnzl4nZGaz66ARFykV25EEUv9GPnggC/g+d1u1tU?= =?us-ascii?Q?OyyoBoyVy6tHzGYZpNE4u/f857wbPwmZTY4Q/QF/gWaEuKfhijdSKcE3+YAK?= =?us-ascii?Q?FB+IQZu4vXDknvyLIyadXLezzdFmNc770gpnmi7zX0VyUrh21xt+9vDZNuTO?= =?us-ascii?Q?Qd5uxf+GWDEwPWWwgXsLgs/lm4qbsn+tv/P7oWpuAzNhAVvY63y8EPdwqa1R?= =?us-ascii?Q?WXEDN8dS3+rApZRa8/CoLfA38xiZviSFqoOODbI6j4d0/49BjVMS6bSWbAEO?= =?us-ascii?Q?gpaSHhth12TkabYrgPyR1rEvJcE7qcaMxuNCHaFxbDYoF2J6omjyM7dRRx8j?= =?us-ascii?Q?DEyEvTAFhGMovLp/OmEX15zap0dzaHozLMPIO4/L7k4W0bX1mwWIT++QkY/4?= =?us-ascii?Q?Cwx6JBVqzKJ7WAFlz22tstUIo66fjQ7NwUHBJGrR4K1+UlWFzGnortE1TJuH?= =?us-ascii?Q?eRKxsi1zTknNnp04aVOXUekTiWeYbCNuopw+Rzi00ZjSX4YOqYv0lSAMCE9h?= =?us-ascii?Q?lcmtd1BBdIa6FYn7ABq2U4ZzGX31IcQAC0o4LqRDqppWSmE0mG/XPWu7gyMe?= =?us-ascii?Q?bcLbnPzUolPmowcwKurX58slpsvUiGj3/rHf7+64nJq/wf+eIllH9okvErIN?= =?us-ascii?Q?78BnoHJTEYUPGprPQ9DqS3rH4HzHCXOb8RNvD6PnQUYeR+JNG6U89v5pstwY?= =?us-ascii?Q?+Dg7qSQEWBZgLaaRjYnwvLcs/dO5Qnq6nyaNHlb0l3BZdp6EhSyC9FQNeOkg?= =?us-ascii?Q?LlzkQ1yDVDn67wmmnStj7b74sphf32WoN/eNeriQdF4ibk/K/SbgSydPReYT?= =?us-ascii?Q?tMdc5hvKR0IQFZ9+g8/cWmAPa6AZZrZyzznHSe5WR9wteW3NWtsJZya+FnSh?= =?us-ascii?Q?uOGs4vfInoIXyQNAaRBTJcv0L4wzY4K7ovOQWtjY8XyKb309GIH6LbzW05NF?= =?us-ascii?Q?Y+hwPxqEQX8JfzqdzJIoPfLgElhcIL8CC4kcgYirONdzEDWWMM9blJjRMggG?= =?us-ascii?Q?PZs0e3CfYJDGO6/ApguGGcpW+bT56xGpZcoTG9iPU3SRVs7AFavj4VwZtLkm?= =?us-ascii?Q?GIaafARkYIQ9MqzfTwKPvi+PkbSf/REBvXj5m/kfJ2MsxUyfd1Nj4QSuaybU?= =?us-ascii?Q?QIw8UnS0DrVV97ScZXUVq0RZs7t3lN1GpZtLDxup+ha6YPmQZc+nP3bsavVn?= =?us-ascii?Q?8Ozyw41ykA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1f68bce-ade7-498f-af04-08da3d4c2512 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 06:10:47.8574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RTduTwkzk9GXn6ReCfp8lpbdtwc5Dww3r89+ApmGbVjV7DBUa71WfdEBkKfSXpSzeVQeCTHX0hXveQXZ6O/NsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4278 On 24.05.2022 04:13, Lin Liu =EF=BC=88=E5=88=98=E6=9E=97=EF=BC=89 wrote: > On 23.05.2022 11:52, Lin Liu wrote: >>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) >>> return cpu_to_le32(*p); >>> } >>> >>> +static inline u32 le32_to_cpu(u32 val) >>> +{ >>> + return le32_to_cpup((const u32 *)&val); >>> +} >> >> Why the cast? And why not uint32_t? >> >> Jan >=20 > le32_to_cpup has following prototye and definition >=20 > static inline u32 le32_to_cpup(const u32 *p) > { > return cpu_to_le32(*p); > } >=20 > xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep consi= stent > typedef uint32_t u32; This answers neither part of my question. For u32 vs uint32_t, please also see ./CODING_STYLE. Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336250.560612 (Exim 4.92) (envelope-from ) id 1ntPB7-0007NS-AM; Tue, 24 May 2022 07:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336250.560612; Tue, 24 May 2022 07:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPB7-0007Ma-2D; Tue, 24 May 2022 07:42:05 +0000 Received: by outflank-mailman (input) for mailman id 336250; Tue, 24 May 2022 07:42:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6H-0003DA-RA for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:06 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de2b116f-dab4-11ec-837e-e5687231ffcc; Mon, 23 May 2022 18:24:51 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 23 May 2022 12:24:54 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3474.namprd03.prod.outlook.com (2603:10b6:406:ce::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Mon, 23 May 2022 16:24:52 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Mon, 23 May 2022 16:24:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de2b116f-dab4-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653323097; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=56GxmM2qFD8J5GQjUa8U7rFpoV6kXeXZByDyeP76XJs=; b=Cmdote/kvP4L7G2AteaCkSPuoiXEAxcZ1Boqj3uUybp3CmrNIkb9T6vM ItyOQC+CDVZb7yl6rBOQxnT3QVm2lxgNSmlFO7qB52UfyT911RCSaBOC0 wQMsHy5/UWHnwvF3yDuaZ03kSZQ4hEyjC6y5gZdjJ3oYY7fP6WAmtFNKc M=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 71972025 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rERlL6DB/i6y7hVW/13iw5YqxClBgxIJ4kV8jS/XYbTApGkqgzIPz mdMD2yHaP2KMGv3f4ogPY3j/R4Eu5WEz99qQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj2dYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPg2m MQTkpy+bz1qFYmTut9ASzhWLgFXaPguFL/veRBTsOS15mifKz7J/K8rC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t7B8mbE80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx1yalK2cFwL6TjY50xDbh7gAh657sd8XzS9ygeNhJl0nN8 woq+Ey8WHn2Lue3yzCI73atje/nhj7gVcQZE7jQ3uFuqE2ewCoUEhJ+fUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxa5UgU0XtNRF6g/91uLw6+NuwKBXDFcHnhGdcAss9IwSXoyz FiVktj1BDtp9rqIVXaa8bTSpjS3UcQIEVI/ieY/ZVNty7HeTEsb13ojkv4L/HaJs+DI IronPort-HdrOrdr: A9a23:saGVOq/fJlA5yDunvMVuk+FKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81nOdUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInhy6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXgIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6X9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFz9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcwa+d FVfYDhDcttABOnhyizhBgt/DXsZAV/Iv6+eDlNhiTPuAIm3kyQzCMjtbkidzk7hdcAoqJ/lp X525RT5c9zp/AtHNJA7cc6MLyK4z/2MGTx2Fz7GyWVKIg3f1TwlrXQ3JIZoMmXRb1g9upBpH 2GaiITiVIP X-IronPort-AV: E=Sophos;i="5.91,246,1647316800"; d="scan'208";a="71972025" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGQpWWFnnDN0UWnKigWniGC8PCHxJXuaNT2fgZ2MOsHtLGjO2lXhCrsP6+8bVilBoI/DOCrQC1Thzr4YzjhATdJvg9BRnp0OpIkIlW93u/AkwgVvmG0NaxRARi46CgrR9kVR4ctF5QG9uJjM4Hkork48mXQtTICLEhzi/6VX4sOMnyCETD7OHuu80xckY7ko8TWK1p1LmelgoTLxGR8LsOJcbj+NLuo8FJsa5+kXwnB9F5mXyuxlYxYiz1c5eobOFKgelO6ZJAWIQ8c/75oJp3d20ZIz6IYWEwBwhnYvhxr1GWTVbJrAhlCHIEmOR/LWvRBwfZ6WqjEPPDl3LLKMow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XDo5fc7VXEjbUfTZbfKOT5Mxq0ouupMZ5lhrcZpiRBU=; b=aUhBT0rbffOh0ygZ2TtnQTweJ4e93Q1sCGEG+rlBu5AYVwN7oati0zi3zkkAor+bhKQD6V85lVwPF3oTbfzmeaKBfex2+xt5EHE/mRrGVWnb+XUzv07pCPH6AxSqS7V4pk83bOAjBhMJAxGA04p0pqV94VFgKOJOLBYnZdGpXpBSmXS3MB4OlJoWBq82uyhl/AmgnmNxoLzxGz6152JmzpRECewnhicDl1gQnhSkeReOFzGy2osZWjTae2HVPykgUgzsv/29TFmTO8uS54W07OFZPPeb4jI4pf8v5mnxHsEj4TuBUSNjUZzjUFPuq2jnz2cEmDqpkYnkrjtsGmgMtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XDo5fc7VXEjbUfTZbfKOT5Mxq0ouupMZ5lhrcZpiRBU=; b=nY6YZtGDyoSlTnyolUw9LR5mXNhbG9j9ixw6sRNopBB98uaqbXZGk/tdMXgGvwVEeMen1hKRc3QrmwJ2VoMHzlVCqzutaNkgE956BQUy4z3SM3e6lHVOitoMOu/rRORTX+GCKyyodsDo4FuDLrUFsrXJEt46xQwiZEZi0GM2BXY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 23 May 2022 18:24:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220516143116.28602-1-roger.pau@citrix.com> <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> X-ClientProxiedBy: LO2P265CA0073.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e07aab0f-c707-4cb3-d0c7-08da3cd8c3d1 X-MS-TrafficTypeDiagnostic: BN7PR03MB3474:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IsQI7ZxKaGvJgjOIuern0H6PR156DNR1gojB9sReEoO48h7xh/kbGnFPdh3mnmXJVglIzm43jgK+O7ryM8NZAmZn+WtWPvVL1AD2/9jtQgux+3tFGbGNKEG94LK67nvp/CYoFvAazs0w1PpCHvwW33rVuAtoyZxBruVaQgD/des2eXiKkWnB9TfZ7CL3wTSJnStqLLSLL7ImZN3gbkhm0hccaUBSoyPhXCTXpcyHH82gP0WI/zkiNH0c0Sne6OBBkrrMjQBOXFRIV4RBVjiIR2IOce/H0Jl8+9s4hYn+sIgeKJDK1pGdVkxFa3qjlQdbl491qzDn3trHozF79zhAZimUL0NMXo7Ef2KGNqvE9QMNIRIXSjmEbuHhwyedF/EarTJ7PfZFzU2ig7+kRhk4xmMVCCLn95+NnrKUHqgMJ/7S/p/wVf6KKxcvvgCt0iz/dYMW/L07ksrj9rQoMrt/XNjgQb6zqZuvbo39+eW47dMGueYT8Oz7/ho19B1kZWt32CyjN+0lG4/wPn0y0LKSkTTTjpJ3p3Zc6KLZDD29TZiuIS4dkeepi6tpFrpJ7x0aedBgWDeIB6HWfhcPpk+Kh4qQlMDIiPJTx67VhzMfG4DK6fihW6bH+qhVQc6W2FdDozenRQPXBn6SSrlAlEWZFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(83380400001)(2906002)(508600001)(6916009)(54906003)(316002)(6666004)(26005)(66946007)(38100700002)(6512007)(9686003)(86362001)(82960400001)(33716001)(85182001)(53546011)(6506007)(5660300002)(8676002)(8936002)(66556008)(66476007)(186003)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clBldEk3dVc5WUFRZ0REcG8rbXduajZtVGFLZGtDbE5FU0hsVXYva2p3ZXc5?= =?utf-8?B?N3dXbVQ0NjdUODdac0NBQ3l4VWpRM0pLcnpEekhwTGZ5d0FEZGFmS0ozc3Ay?= =?utf-8?B?VnFVd0RXRlV6M0t3WVJkUDRIakNRcEpmbnBISTNJZURZYU5WL2lQWSt5aXQx?= =?utf-8?B?WGNxQmR5bldEL0tIaEQ2MlY3RWxhM21lRnpuNFNOS0gveUx0ZFJEbFdGSjZT?= =?utf-8?B?KzZOSFd1eTdMN0hva3l5RTZnaVpqUDRPZWxQbHVaQ01HQ1B5QmZMWlcwV2xk?= =?utf-8?B?ZGpXTzdIV1hMb0JvYmNUbkUvUHhmK2NpcWNFYmhrd0crRHVDRHJEYXpMaUlN?= =?utf-8?B?aVFrM3ZQdXZpVTI4REFqWjV5K1hzTTRHczRLTWJhNGxjdVNRNVhrdjN5cGR4?= =?utf-8?B?eHMrR1dERTM4SyszbWs0M0tNcEhsdEJnWGRQM24vTXZMbmIxTjg0UVhFb2Rh?= =?utf-8?B?YU9uYms4WEQvWXBHV1JTQVJqRVUzc3JON3FVK3NWa1pYRGdaMGR5dHNCZzFw?= =?utf-8?B?MmtKR3JyZFVsMjVpekNGK2RwczlKc1VZSFlTb0ZvV0QrVHVOdUlJNThDbWIw?= =?utf-8?B?M2R0Y3lOWGMrNGs2WldPaXdDb2lnMWRSc2ZyRjdhbjhPa090MWVXRURuUzE2?= =?utf-8?B?YS80Vlg0b0JuaU9ScFYwRFU0UjdReXcwZXNndWRHeU5wV0hUTXhDdktnVWht?= =?utf-8?B?VlNKa3dReVNQVDR5UldLK3AwV0M1TXJLSVRKSzZ2T3lLSkJtQ0NQbTVveEtk?= =?utf-8?B?SStWRGFQODVkb1JZSk1DcWM2c0xJYW5SS0EyUjdscUFieXAxTzhYZ0tPcFZT?= =?utf-8?B?d0M4VmIwV3I1TzNkYm0xNTBOVmR1YXAwZEdXdnFLczJoK1ZjK0ZVNjJxWmha?= =?utf-8?B?bUpmZGdMemI4V2hDVmVuUkp3Z3piUzBZOXc3dmVrUVJEeGl6SlJTbVFYWVhT?= =?utf-8?B?TTFXVytwbFNIM2VBQkova004K3U0NU5MZFNwdVRGdDNMZWhWZm1nSC9WVitz?= =?utf-8?B?TGRUZ2hGdmNiMzVZcW5JdzNGdlpuZ1FDMlNONzcxSFVwTjI3MU10SW9reWx0?= =?utf-8?B?bDlibjY3a3NrOEcvRDdvN0Rlay81Tm16eWpxeXZmckpXYkRZRjJuU0dRRTVI?= =?utf-8?B?SG50VVJrR05wT0tta0hSWUNDclN2elpNbmFLdUxETEtBRkRzODR5ai9HN08z?= =?utf-8?B?bHFQK0JKSjYvcVIrS2UvWWJsMTdWZnpVeE9vNVp3elphTWVrNE95WEpWWTE0?= =?utf-8?B?RkoyTmc4N0Vlc3pxbnFNMzVjNVc5ZFVUdkVZZ0M3aEZ6L1M1dmJMVXpMWU1H?= =?utf-8?B?ZFBYYXZkbTRoOGMyTTBiKy8ycjQ1N1NXMzVUNXJ4OEg0MGdzREZrVm5vKzl1?= =?utf-8?B?ZEVrdDUya3pQWGdPK0lLVU1taFUwb2xORUdobVJzTGFCVGpqZ2pJd3hIaC84?= =?utf-8?B?YjdMRnptdzVOVUxtWDdPUUNpZ2REWmhEMjVYRU9YUWJoanB4dzhuTVVRSTZk?= =?utf-8?B?dWpCZVdJOWRSdVhUaFJxTFVLcHF1VXR0cGlhRUpMeU1LeDFUN3BQOUVONFVG?= =?utf-8?B?LzBrOXlBMTFUWjIrRklWQTgvY2x6NEYweWx5MFk0ODVPSTA2bGhrQXhoOUdj?= =?utf-8?B?c2w3ZVhBYlRvV2F3d0RuQmpnNk9YR0RvL0RHZE9hc0EvYzlaMzcyQmt4RFpm?= =?utf-8?B?OURGRnF3Vm83UmIzNXlGbnpxeS94ckhhN21sUzJpUWIvS2Uxb2kxcXAzbWtL?= =?utf-8?B?Rk14bmFSUE9jQXc3dnRuL1dOVWVPSkwyM204ditlS25XRlNJQTJKZjUrYUUr?= =?utf-8?B?bzFPaWRjeGhBM0xCNmtrU3RabXFRQnhOdFBuMzlkak5WZzI4M0JkcUtBeTVL?= =?utf-8?B?M1Fkd1dHRXZwZjF6S0ZXVHJSc2F5Zmg0TnVsL2h5RGhuZ1J1V2llWExNaG52?= =?utf-8?B?TXJ2UXJabHkrWHl4MTVldVRNcWNFd1dqcS9Cc2tTOXF1ZEdYR29CcFhUcFpL?= =?utf-8?B?RUM0Rmo2eGR5TnVSNWFlSEc0WDMvcjRSTldxMmdLZFZNQlp3QXBscDVadGt3?= =?utf-8?B?YmNNcHZTanY4cFV4WjJXVlo0YWhpakVaUlFiV2ZiYVU4azVYZk4zdDRneE9K?= =?utf-8?B?RC9SeTZPSWxoV0hOc2t5SEVJTmE1MU5yVGJlblAzTitYZXdEY0k2UndFTWhL?= =?utf-8?B?akY0Rm1SaDh6aWlaQzh4cXJHVTd2Uzllb3Y5dUtrY1pEbkE4QlljVXZMeUJk?= =?utf-8?B?R3doemdXK21pYVFFV1ZBQnVyM1ZBS1Q5SVlmNGZsV1BwZ2QwRUpvK0ZaQytE?= =?utf-8?B?clJQQWZlZ0pwVE9DMUVIV3B3RmtzN25NQS85Vm5RdDkrRDhZdStHWFVxeTVh?= =?utf-8?Q?sfNfG6A7fxnt0b68=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e07aab0f-c707-4cb3-d0c7-08da3cd8c3d1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 16:24:52.3974 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +lHxSq7BbFrnn2IBXi96eXPw+XHuJoqaB+Go5RfjCh5rDwIK5AfYP3vW+U+OBn2Qt2LyE7AN2o9hkQvSHXbFRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3474 On Mon, May 23, 2022 at 05:13:43PM +0200, Jan Beulich wrote: > On 23.05.2022 16:37, Roger Pau Monné wrote: > > On Wed, May 18, 2022 at 10:49:22AM +0200, Jan Beulich wrote: > >> On 16.05.2022 16:31, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/flushtlb.h > >>> +++ b/xen/arch/x86/include/asm/flushtlb.h > >>> @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); > >>> #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) > >>> > >>> /* Flush all CPUs' TLBs/caches */ > >>> -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) > >>> +#define flush_area(va, flags) \ > >>> + flush_area_mask(&cpu_online_map, (const void *)(va), flags) > >> > >> I have to admit that I would prefer if we kept the "_all" name suffix, > >> to continue to clearly express the scope of the flush. I'm also not > >> really happy to see the cast being added globally now. > > > > But there where no direct callers of flush_area_all(), so the name was > > just relevant for it's use in flush_area(). With that now gone I > > don't see a need for a flush_area_all(), as flush_area_mask() is more > > appropriate. > > And flush_area_all() is shorthand for flush_area_mask(&cpu_online_map, ...). > That's more clearly distinguished from flush_area_local() than simply > flush_area(); the latter was okay-ish with its mm.c-only exposure, but imo > isn't anymore when put in a header. OK, so you would prefer to replace callers to use flush_area_all() and drop flush_area() altogether. I can do that. > >>> --- a/xen/arch/x86/smp.c > >>> +++ b/xen/arch/x86/smp.c > >>> @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > >>> { > >>> unsigned int cpu = smp_processor_id(); > >>> > >>> - ASSERT(local_irq_is_enabled()); > >>> + /* Local flushes can be performed with interrupts disabled. */ > >>> + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); > >> > >> Further down we use cpumask_subset(mask, cpumask_of(cpu)), > >> apparently to also cover the case where mask is empty. I think > >> you want to do so here as well. > > > > Hm, yes. I guess that's cheaper than adding an extra: > > > > if ( cpumask_empty() ) > > return; > > > > check at the start of the function. > > > >>> if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && > >>> cpumask_test_cpu(cpu, mask) ) > >> > >> I suppose we want a further precaution here: Despite the > >> !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to > >> extend what c64bf2d2a625 ("x86: make CPU state flush requests > >> explicit") and later changes (isolating uses of FLUSH_VCPU_STATE > >> from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE > >> for the local CPU altogether. > > > > If we really want to exclude the use of FLUSH_VCPU_STATE for the local > > CPU, we might wish to add this as a separate ASSERT, so that such > > checking doesn't depend on !local_irq_is_enabled(): > > > > ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu)); > > ASSERT(!cpumask_subset(mask, cpumask_of(cpu)) || !(flags & FLUSH_VCPU_STATE)); > > > > > >> That's because if such somehow made > >> it into the conditional below here, it would still involve an IPI. > > > > Sorry, I'm confused by this: if the mask is empty there should be no > > IPI involved at all? And we shouldn't even get into the second > > conditional on the function. > > Should perhaps have made more explicit that "somehow" means a hypothetical > way, perhaps even as a result of some further breakage somewhere. Oh, OK, then I wasn't so confused after all :). Given your lack of comments I assume you are fine with the addition of a separate ASSERT to cover the usage of FLUSH_VCPU_STATE. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336265.560623 (Exim 4.92) (envelope-from ) id 1ntPBA-0007uy-8r; Tue, 24 May 2022 07:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336265.560623; Tue, 24 May 2022 07:42:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPB9-0007tN-UC; Tue, 24 May 2022 07:42:07 +0000 Received: by outflank-mailman (input) for mailman id 336265; Tue, 24 May 2022 07:42:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6C-0003DA-QL for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:01 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0612.outbound.protection.outlook.com [2a01:111:f400:fe0d::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04b4b6bc-db01-11ec-837e-e5687231ffcc; Tue, 24 May 2022 03:29:56 +0200 (CEST) Received: from AM5PR0701CA0064.eurprd07.prod.outlook.com (2603:10a6:203:2::26) by AS8PR08MB7078.eurprd08.prod.outlook.com (2603:10a6:20b:34f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 01:29:53 +0000 Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::57) by AM5PR0701CA0064.outlook.office365.com (2603:10a6:203:2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 24 May 2022 01:29:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 01:29:53 +0000 Received: ("Tessian outbound 6580ae46f51e:v119"); Tue, 24 May 2022 01:29:53 +0000 Received: from 080f1eea5f03.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A76D633-24D3-480B-A53A-636F068C8440.1; Tue, 24 May 2022 01:29:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 080f1eea5f03.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 01:29:47 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB3794.eurprd08.prod.outlook.com (2603:10a6:208:103::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 01:29:45 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Tue, 24 May 2022 01:29:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04b4b6bc-db01-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AXDpMCjSZFlo/X1OcQJre39TYmpK6Y4Yuj9um61iMAjhVGpBuVOrV3Yb5y6kp4+N7X0llzcX4OlWbFPASuPaMFtsaGT7L/PEzrrCoAH9h0lzl0/8EvCRt3V+AnWoHc5Fiw07EBwq6qDTEl5zk5glOahcLiQ6D7OsWar50DZZcNAFGAhKNYLaXbiNHwc0zHGIEi67cR74CY3Z3lY2NOvRQs8Mhd6YOlDGDf0Mf8KZBuOu28AZ/LUsV1cigvdUtR1Lxal78253xHLfZG+065nUbbllS2GSZwlIB3pNwA0z0ZL0fmyFgFKF8cabSZMQSeIBVW63Lgp2QxZ4Wtd8RDOHYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ZDIpbazrLIVydwaymOJleXlcNrmOGpvsZl7vO967WM=; b=dV2tZaDI2RfqIrQdbrnobvp/9xFlLP7kyA82y6PJVDVcv++pWfa7CMh83bXi5JGbzF5c4g7+uHO6iObKfHSFHkUded4VTHQP4H0pC5hzbwGVXG7v3NzI3465fNuJNtdkZ3T7YVcpLeaNRqWwmQs1Vlb+29I9I73kD5aWWp6FpcXaGabR7yX1TjImJH5XTKgzixCueVNVEj1wU+yyluSdYq0SKUul3Gz16wg38qH0O5C1fAkZkK67/kKu5i1mpou51GvEgKVCQw1oPnz9ir1jEJPZEZ/8+GakLXrEGVlyg7C0ZtjRbP+GERpoYYSruOgHrXNK6Poy+UdSRN/UEEDt9g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ZDIpbazrLIVydwaymOJleXlcNrmOGpvsZl7vO967WM=; b=2N6Q324d2rFXghGAkvj8YtPWXrfFTbCwNq6Dt59jtUeUPLVJRct50yQnll4x1Y6iiLFypBHvfhePOpA96QYwGbu8BJSTPbaHkPWQ4UhIAPYcxjOsryyRtZuZnTnrHtMkrklwwsUZ47tw2gLCECRvdkui7h5bj80/4EATv6DnlBU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQSDmTPUABCoGE+C1qVdRbKLijgdit3Zj7397q9+xVhPhbnoNFHo5HbGSnnOf83imOiEU/ldJtwOvkWMiaJwIom5jDhCIS+F66yMDSqKcNPRw2C9LU6SiC9Xcv6tbYMH3cqNq3XzRpsDvIvTxuttJJbtaeJHCKcIGQbrawyoS2jewnvi5ZJ4C6+oeBVFRjeKGOxEiD81GwukNxF+E+jnGErLEZfS9Mh5RQDZzKJD0M0lG/A2VpeB0824CTitghbEprYd5E1u0qNvYQBPFxD4Vzy1a19KzuydNt0/HFxGU6G7OC+QQzdTiq3gop5ETV8TCujypm7qz+MmdoAqyx9qQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ZDIpbazrLIVydwaymOJleXlcNrmOGpvsZl7vO967WM=; b=l2mXYPsvp0pzZcIo6qFcyYHQ6fxzCoMVb8vkEE9pNwGPDzJkjKfNJkSu6aFpsMUaZMfOfsEsUQAj4amVfzjHzXc1SaD6Wa9wPxfyCVM91QeBbaK9xACGuGgwAY8bIg//iESBTCi5XXcG1g1tHmZ7dJ6+Gy7hHgGQuVequPY6yU2FBdT85+dV0aJIKp7u4LqIDk6yYvhTJ+/ZyIXHCe0AECpV4vKEU18h9RLw0FfPO12FCM20l2BeTVRSArrI1lWv7uV2qvA69kDWsAoU+NHIktwoFSeeuZaRaXxOjNumuFnYt7gZGvguAIPRWsszMNuw7qAynbbU96YX+waGvP4NJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ZDIpbazrLIVydwaymOJleXlcNrmOGpvsZl7vO967WM=; b=2N6Q324d2rFXghGAkvj8YtPWXrfFTbCwNq6Dt59jtUeUPLVJRct50yQnll4x1Y6iiLFypBHvfhePOpA96QYwGbu8BJSTPbaHkPWQ4UhIAPYcxjOsryyRtZuZnTnrHtMkrklwwsUZ47tw2gLCECRvdkui7h5bj80/4EATv6DnlBU= From: Wei Chen To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: RE: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYbt50tGidbD5g50ygNS2KCABD4q0tOEpA Date: Tue, 24 May 2022 01:29:45 +0000 Message-ID: References: <20220523194953.70636-1-julien@xen.org> In-Reply-To: <20220523194953.70636-1-julien@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EC8BED42FB57A247B8897D089C7F2DC0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 73afc49c-6415-4d33-4431-08da3d24e72e x-ms-traffictypediagnostic: AM0PR08MB3794:EE_|AM5EUR03FT023:EE_|AS8PR08MB7078:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Lcyf5Bh9ONQhKmwJ3xC8ziLBpQp44rn/5fIIk2wYAN28mAIT9eJgcocq4xz7p3jRRcM3q44UtNdwI64KE2vYGYqBXPMBA+N9ew857BUnQNulY1bGqY+j45SChWZZ1hdaJjdlfXMVcrO5ZXrfcH2hi1DgDlDR2AHowohzu4Qlv0TeGQ3yrDdpKcRaBVE+TUYR1Kzl8peMHKDJqAVwkLYhdqRsMD53HExWGqORKSayLiEhobL3oVhAD3+40G67leVNKsR7R2PZW/mmVTwRb9hjZmnKd8DIWC7+Jd+eR63cHjIYNDz/YmlbdeLpjYlKatAc1G3XzqllgHPBuBPIUHJMHebiNpQvnlz61+/mLpVgHJY3j4FCzZwgL4E+XvV2uEGNJilsSnNuAA6gQTnPQbPRppQjMHQvil0WuIMI2ZC2nNhpp23R/Dkr4umeQ2WjKlAa9Dgqj9fxZhFSZWKxjfhiyMFDHER3acJtwpVbheRlaR4agMZzYxzUZ8J1eoZjqW9TbEK1iUmxOWRIZAP/tjWpAJcdZWfX45Xvk4Jd4YIhjsWSCT2OQo5QWjpsZ+rcOG6p9S4iUuZWqzY5rlBZ4mFEgfk/TzRfOQdU8rACCASiYBeO8bMKTGFm1x54qudqsF6Yg08VrDL3jIfXGdTKfU1BE09Td/sa1rpxV0ddStXYf7MIKun8XY4SQE/dyPFOg9b0V4nNbq8v0BbJsrWJCTnixQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(55016003)(122000001)(83380400001)(38070700005)(38100700002)(110136005)(316002)(8936002)(54906003)(66946007)(66556008)(86362001)(76116006)(8676002)(66446008)(66476007)(64756008)(4326008)(2906002)(26005)(71200400001)(33656002)(6506007)(53546011)(52536014)(9686003)(5660300002)(7696005)(186003)(508600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3794 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 13f1c433-2f78-41c7-d01f-08da3d24e268 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ps6rm/E3H6GWpSnT5CQMJEfeBMJXBb8NepdyJDiyCzK305VZoDlAw/smk66lCRSW4vSps/2lSxfcQ4nYJaYFrwQf3K2c4u66UT7AJmq24RTxqSG6gGWAsvmbHday3lNqKLyVDKTyHbMKDo0rqJtbmO2PYhq8PQGvMri/kdXa35XQwk/AL5cF0Y+D/l9A1id/MUWvZT3BEZDEZtTZ1YasreL0hXT1DTSGvqsbz0bII68riNmsmu1oRHt9JtB6RnLzM5bc9xtAtOeCOlQP30HWD6evOt6XWMZJuTj5GSCzDazYfs1W5/Cb8tRZIvhhJrr7n8Cl4LrtuABzh0m8V0+snIenuf0cQn6DeKTXFzPc4kgYVf7mFoYB7ByCB4jk2UrN3ZQGBzq82YjCgk9r7rD4UskTSrIIciexE+N27/kEXFEN5AHk9Bdx04tyODz/JLCaF7nXLUT+GqrAgViHaxfNrdIzpY5WZP/qbJtHY23fXYQjfHtvDjcFh1J0epHPsD6vQltq6EIg0mCm3gpYff1xlw91JK0VwVgwdVouKG/ZOc5j9UHf710zSd19kR+YI/ve4kjjGb0OP2uu/UmYLAYcpduEe7a8PHuFwavgsGrc66bssYLfPKDDlKbPzF/d4kUUQRxA8nHOrjhdZOfylnhvx6RQ0TuCr9baUW7MgIggAqC2e1fWiWVcQoYDjW6L9HvC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(2906002)(36860700001)(8936002)(81166007)(5660300002)(8676002)(4326008)(70206006)(86362001)(70586007)(52536014)(356005)(55016003)(316002)(336012)(107886003)(110136005)(53546011)(6506007)(26005)(9686003)(186003)(82310400005)(7696005)(40460700003)(33656002)(54906003)(508600001)(83380400001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 01:29:53.2251 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73afc49c-6415-4d33-4431-08da3d24e72e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7078 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhlbi1k ZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBP Zg0KPiBKdWxpZW4gR3JhbGwNCj4gU2VudDogMjAyMsTqNdTCMjTI1SAzOjUwDQo+IFRvOiB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IGp1bGllbkB4ZW4ub3JnOyBKdWxpZW4g R3JhbGwgPGpncmFsbEBhbWF6b24uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVs bGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0u Y29tPjsNCj4gVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsg S29ucmFkIFJ6ZXN6dXRlayBXaWxrDQo+IDxrb25yYWQud2lsa0BvcmFjbGUuY29tPjsgUm9zcyBM YWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSF0g eGVuL2FybTogUmVtb3ZlIG1vc3Qgb2YgdGhlICpfVklSVF9FTkQgZGVmaW5lcw0KPiANCj4gRnJv bTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gDQo+IEF0IHRoZSBtb21lbnQs ICpfVklSVF9FTkQgbWF5IGVpdGhlciBwb2ludCB0byB0aGUgYWRkcmVzcyBhZnRlciB0aGUgZW5k DQo+IG9yIHRoZSBsYXN0IGFkZHJlc3Mgb2YgdGhlIHJlZ2lvbi4NCj4gDQo+IFRoZSBsYWNrIG9m IGNvbnNpc3RlbmN5IG1ha2UgcXVpdGUgZGlmZmljdWx0IHRvIHJlYXNvbiB3aXRoIHRoZW0uDQo+ IA0KPiBGdXJ0aGVybW9yZSwgdGhlcmUgaXMgYSByaXNrIG9mIG92ZXJmbG93IGluIHRoZSBjYXNl IHdoZXJlIHRoZSBhZGRyZXNzDQo+IHBvaW50cyBwYXN0IHRvIHRoZSBlbmQuIEkgYW0gbm90IGF3 YXJlIG9mIGFueSBjYXNlcywgc28gdGhpcyBpcyBvbmx5IGENCj4gbGF0ZW50IGJ1Zy4NCj4gDQo+ IFN0YXJ0IHRvIHNvbHZlIHRoZSBwcm9ibGVtIGJ5IHJlbW92aW5nIGFsbCB0aGUgKl9WSVJUX0VO RCBleGNsdXNpdmVseSB1c2VkDQo+IGJ5IHRoZSBBcm0gY29kZSBhbmQgYWRkICpfVklSVF9TSVpF IHdoZW4gaXQgaXMgbm90IHByZXNlbnQuDQo+IA0KPiBUYWtlIHRoZSBvcHBvcnR1bml0eSB0byBy ZW5hbWUgQk9PVF9GRFRfU0xPVF9TSVpFIHRvIEJPT1RfRkRUX1ZJUlRfU0laRQ0KPiBmb3IgYmV0 dGVyIGNvbnNpc3RlbmN5IGFuZCB1c2UgX0FUKHZhZGRyX3QsICkuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiANCj4gLS0tLQ0KPiANCj4g SSBub3RpY2VkIHRoYXQgYSBmZXcgZnVuY3Rpb25zIGluIFhlbiBleHBlY3QgW3N0YXJ0LCBlbmRb LiBUaGlzIGlzIHJpc2t5DQo+IGFzIHdlIG1heSBlbmQgdXAgd2l0aCBlbmQgPCBzdGFydCBpZiB0 aGUgcmVnaW9uIGlzIGRlZmluZWQgcmlnaHQgYXQgdGhlDQo+IHRvcCBvZiB0aGUgYWRkcmVzcyBz cGFjZS4NCj4gDQo+IEkgaGF2ZW4ndCB5ZXQgdGFja2xlIHRoaXMgaXNzdWUuIEJ1dCBJIHdvdWxk IGF0IGxlYXN0IGxpa2UgdG8gZ2V0IHJpZA0KPiBvZiAqX1ZJUlRfRU5ELg0KPiAtLS0NCj4gIHhl bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWcuaCB8IDE4ICsrKysrKysrLS0tLS0tLS0tLQ0K PiAgeGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jICAgICAgICAgIHwgIDIgKy0NCj4gIHhlbi9hcmNo L2FybS9tbS5jICAgICAgICAgICAgICAgICB8IDEzICsrKysrKysrLS0tLS0NCj4gIDMgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0t Z2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+IGIveGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+IGluZGV4IDNlMmE1NWE5MTA1OC4uNjZkYjYxOGIzNGU3 IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gKysr IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+IEBAIC0xMTEsMTIgKzExMSwx MSBAQA0KPiAgI2RlZmluZSBGSVhNQVBfQUREUihuKSAgICAgICAgKF9BVCh2YWRkcl90LDB4MDA0 MDAwMDApICsgKG4pICogUEFHRV9TSVpFKQ0KPiANCj4gICNkZWZpbmUgQk9PVF9GRFRfVklSVF9T VEFSVCAgICBfQVQodmFkZHJfdCwweDAwNjAwMDAwKQ0KPiAtI2RlZmluZSBCT09UX0ZEVF9TTE9U X1NJWkUgICAgIE1CKDQpDQo+IC0jZGVmaW5lIEJPT1RfRkRUX1ZJUlRfRU5EICAgICAgKEJPT1Rf RkRUX1ZJUlRfU1RBUlQgKyBCT09UX0ZEVF9TTE9UX1NJWkUpDQo+ICsjZGVmaW5lIEJPT1RfRkRU X1ZJUlRfU0laRSAgICAgX0FUKHZhZGRyX3QsIE1CKDQpKQ0KPiANCj4gICNpZmRlZiBDT05GSUdf TElWRVBBVENIDQo+ICAjZGVmaW5lIExJVkVQQVRDSF9WTUFQX1NUQVJUICAgX0FUKHZhZGRyX3Qs MHgwMGEwMDAwMCkNCj4gLSNkZWZpbmUgTElWRVBBVENIX1ZNQVBfRU5EICAgICAoTElWRVBBVENI X1ZNQVBfU1RBUlQgKyBNQigyKSkNCj4gKyNkZWZpbmUgTElWRVBBVENIX1ZNQVBfU0laRSAgICBf QVQodmFkZHJfdCwgTUIoMikpDQo+ICAjZW5kaWYNCj4gDQo+ICAjZGVmaW5lIEhZUEVSVklTT1Jf VklSVF9TVEFSVCAgWEVOX1ZJUlRfU1RBUlQNCj4gQEAgLTEzMiwxOCArMTMxLDE4IEBADQo+ICAj ZGVmaW5lIEZSQU1FVEFCTEVfVklSVF9FTkQgICAgKEZSQU1FVEFCTEVfVklSVF9TVEFSVCArIEZS QU1FVEFCTEVfU0laRSAtDQo+IDEpDQo+IA0KPiAgI2RlZmluZSBWTUFQX1ZJUlRfU1RBUlQgICAg ICAgIF9BVCh2YWRkcl90LDB4MTAwMDAwMDApDQo+ICsjZGVmaW5lIFZNQVBfVklSVF9TSVpFICAg ICAgICAgX0FUKHZhZGRyX3QsIEdCKDEpIC0gTUIoMjU2KSkNCj4gDQo+ICAjZGVmaW5lIFhFTkhF QVBfVklSVF9TVEFSVCAgICAgX0FUKHZhZGRyX3QsMHg0MDAwMDAwMCkNCj4gLSNkZWZpbmUgWEVO SEVBUF9WSVJUX0VORCAgICAgICBfQVQodmFkZHJfdCwweDdmZmZmZmZmKQ0KPiAtI2RlZmluZSBE T01IRUFQX1ZJUlRfU1RBUlQgICAgIF9BVCh2YWRkcl90LDB4ODAwMDAwMDApDQo+IC0jZGVmaW5l IERPTUhFQVBfVklSVF9FTkQgICAgICAgX0FUKHZhZGRyX3QsMHhmZmZmZmZmZikNCj4gKyNkZWZp bmUgWEVOSEVBUF9WSVJUX1NJWkUgICAgICBfQVQodmFkZHJfdCwgR0IoMSkpDQo+IA0KPiAtI2Rl ZmluZSBWTUFQX1ZJUlRfRU5EICAgIFhFTkhFQVBfVklSVF9TVEFSVA0KPiArI2RlZmluZSBET01I RUFQX1ZJUlRfU1RBUlQgICAgIF9BVCh2YWRkcl90LDB4ODAwMDAwMDApDQo+ICsjZGVmaW5lIERP TUhFQVBfVklSVF9TSVpFICAgICAgX0FUKHZhZGRyX3QsIEdCKDIpKQ0KPiANCj4gICNkZWZpbmUg RE9NSEVBUF9FTlRSSUVTICAgICAgICAxMDI0ICAvKiAxMDI0IDJNQiBtYXBwaW5nIHNsb3RzICov DQo+IA0KPiAgLyogTnVtYmVyIG9mIGRvbWhlYXAgcGFnZXRhYmxlIHBhZ2VzIHJlcXVpcmVkIGF0 IHRoZSBzZWNvbmQgbGV2ZWwgKDJNQg0KPiBtYXBwaW5ncykgKi8NCj4gLSNkZWZpbmUgRE9NSEVB UF9TRUNPTkRfUEFHRVMgKChET01IRUFQX1ZJUlRfRU5EIC0gRE9NSEVBUF9WSVJUX1NUQVJUICsN Cj4gMSkgPj4gRklSU1RfU0hJRlQpDQo+ICsjZGVmaW5lIERPTUhFQVBfU0VDT05EX1BBR0VTIChE T01IRUFQX1ZJUlRfU0laRSA+PiBGSVJTVF9TSElGVCkNCj4gDQo+ICAjZWxzZSAvKiBBUk1fNjQg Ki8NCj4gDQo+IEBAIC0xNTIsMTIgKzE1MSwxMSBAQA0KPiAgI2RlZmluZSBTTE9UMF9FTlRSWV9T SVpFICBTTE9UMCgxKQ0KPiANCj4gICNkZWZpbmUgVk1BUF9WSVJUX1NUQVJUICBHQigxKQ0KPiAt I2RlZmluZSBWTUFQX1ZJUlRfRU5EICAgIChWTUFQX1ZJUlRfU1RBUlQgKyBHQigxKSkNCj4gKyNk ZWZpbmUgVk1BUF9WSVJUX1NJWkUgICBHQigxKQ0KPiANCj4gICNkZWZpbmUgRlJBTUVUQUJMRV9W SVJUX1NUQVJUICBHQigzMikNCj4gICNkZWZpbmUgRlJBTUVUQUJMRV9TSVpFICAgICAgICBHQigz MikNCj4gICNkZWZpbmUgRlJBTUVUQUJMRV9OUiAgICAgICAgICAoRlJBTUVUQUJMRV9TSVpFIC8g c2l6ZW9mKCpmcmFtZV90YWJsZSkpDQo+IC0jZGVmaW5lIEZSQU1FVEFCTEVfVklSVF9FTkQgICAg KEZSQU1FVEFCTEVfVklSVF9TVEFSVCArIEZSQU1FVEFCTEVfU0laRSAtDQo+IDEpDQo+IA0KPiAg I2RlZmluZSBESVJFQ1RNQVBfVklSVF9TVEFSVCAgIFNMT1QwKDI1NikNCj4gICNkZWZpbmUgRElS RUNUTUFQX1NJWkUgICAgICAgICAoU0xPVDBfRU5UUllfU0laRSAqICgyNjUtMjU2KSkNCj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9saXZlcGF0Y2guYyBiL3hlbi9hcmNoL2FybS9saXZlcGF0 Y2guYw0KPiBpbmRleCA3NWU4YWRjZmQ2YTEuLjU3YWJjNzQ2ZTYwYiAxMDA2NDQNCj4gLS0tIGEv eGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9saXZlcGF0Y2gu Yw0KPiBAQCAtMTc1LDcgKzE3NSw3IEBAIHZvaWQgX19pbml0IGFyY2hfbGl2ZXBhdGNoX2luaXQo dm9pZCkNCj4gICAgICB2b2lkICpzdGFydCwgKmVuZDsNCj4gDQo+ICAgICAgc3RhcnQgPSAodm9p ZCAqKUxJVkVQQVRDSF9WTUFQX1NUQVJUOw0KPiAtICAgIGVuZCA9ICh2b2lkICopTElWRVBBVENI X1ZNQVBfRU5EOw0KPiArICAgIGVuZCA9IHN0YXJ0ICsgTElWRVBBVENIX1ZNQVBfU0laRTsNCj4g DQo+ICAgICAgdm1faW5pdF90eXBlKFZNQVBfWEVOLCBzdGFydCwgZW5kKTsNCj4gDQo+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC9hcm0vbW0uYyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+IGluZGV4IGJl MzcxNzZhNDcyNS4uMDYwN2M2NWY5NWNkIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vbW0u Yw0KPiArKysgYi94ZW4vYXJjaC9hcm0vbW0uYw0KPiBAQCAtMTI4LDkgKzEyOCwxMSBAQCBzdGF0 aWMgREVGSU5FX1BBR0VfVEFCTEUoeGVuX2ZpcnN0KTsNCj4gIC8qIHhlbl9wZ3RhYmxlID09IHJv b3Qgb2YgdGhlIHRyaWUgKHplcm9ldGggbGV2ZWwgb24gNjQtYml0LCBmaXJzdCBvbiAzMi0NCj4g Yml0KSAqLw0KPiAgc3RhdGljIERFRklORV9QRVJfQ1BVKGxwYWVfdCAqLCB4ZW5fcGd0YWJsZSk7 DQo+ICAjZGVmaW5lIFRISVNfQ1BVX1BHVEFCTEUgdGhpc19jcHUoeGVuX3BndGFibGUpDQo+IC0v KiB4ZW5fZG9tbWFwID09IHBhZ2VzIHVzZWQgYnkgbWFwX2RvbWFpbl9wYWdlLCB0aGVzZSBwYWdl cyBjb250YWluDQo+ICsvKg0KPiArICogeGVuX2RvbW1hcCA9PSBwYWdlcyB1c2VkIGJ5IG1hcF9k b21haW5fcGFnZSwgdGhlc2UgcGFnZXMgY29udGFpbg0KPiAgICogdGhlIHNlY29uZCBsZXZlbCBw YWdldGFibGVzIHdoaWNoIG1hcCB0aGUgZG9taGVhcCByZWdpb24NCj4gLSAqIERPTUhFQVBfVklS VF9TVEFSVC4uLkRPTUhFQVBfVklSVF9FTkQgaW4gMk1CIGNodW5rcy4gKi8NCj4gKyAqIHN0YXJ0 aW5nIGF0IERPTUhFQVBfVklSVF9TVEFSVCBpbiAyTUIgY2h1bmtzLg0KPiArICovDQo+ICBzdGF0 aWMgREVGSU5FX1BFUl9DUFUobHBhZV90ICosIHhlbl9kb21tYXApOw0KPiAgLyogUm9vdCBvZiB0 aGUgdHJpZSBmb3IgY3B1MCwgb3RoZXIgQ1BVJ3MgUFRzIGFyZSBkeW5hbWljYWxseSBhbGxvY2F0 ZWQNCj4gKi8NCj4gIHN0YXRpYyBERUZJTkVfUEFHRV9UQUJMRShjcHUwX3BndGFibGUpOw0KPiBA QCAtNDc2LDcgKzQ3OCw3IEBAIG1mbl90IGRvbWFpbl9wYWdlX21hcF90b19tZm4oY29uc3Qgdm9p ZCAqcHRyKQ0KPiAgICAgIGludCBzbG90ID0gKHZhIC0gRE9NSEVBUF9WSVJUX1NUQVJUKSA+PiBT RUNPTkRfU0hJRlQ7DQo+ICAgICAgdW5zaWduZWQgbG9uZyBvZmZzZXQgPSAodmE+PlRISVJEX1NI SUZUKSAmIFhFTl9QVF9MUEFFX0VOVFJZX01BU0s7DQo+IA0KPiAtICAgIGlmICggdmEgPj0gVk1B UF9WSVJUX1NUQVJUICYmIHZhIDwgVk1BUF9WSVJUX0VORCApDQo+ICsgICAgaWYgKCAodmEgPj0g Vk1BUF9WSVJUX1NUQVJUKSAmJiAoKFZNQVBfVklSVF9TVEFSVCAtIHZhKSA8DQo+IFZNQVBfVklS VF9TSVpFKSApDQo+ICAgICAgICAgIHJldHVybiB2aXJ0X3RvX21mbih2YSk7DQo+IA0KPiAgICAg IEFTU0VSVChzbG90ID49IDAgJiYgc2xvdCA8IERPTUhFQVBfRU5UUklFUyk7DQo+IEBAIC01NzAs NyArNTcyLDggQEAgdm9pZCBfX2luaXQgcmVtb3ZlX2Vhcmx5X21hcHBpbmdzKHZvaWQpDQo+ICAg ICAgaW50IHJjOw0KPiANCj4gICAgICAvKiBkZXN0cm95IHRoZSBfUEFHRV9CTE9DSyBtYXBwaW5n ICovDQo+IC0gICAgcmMgPSBtb2RpZnlfeGVuX21hcHBpbmdzKEJPT1RfRkRUX1ZJUlRfU1RBUlQs IEJPT1RfRkRUX1ZJUlRfRU5ELA0KPiArICAgIHJjID0gbW9kaWZ5X3hlbl9tYXBwaW5ncyhCT09U X0ZEVF9WSVJUX1NUQVJULA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCT09UX0ZE VF9WSVJUX1NUQVJUICsgQk9PVF9GRFRfVklSVF9TSVpFLA0KPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBfUEFHRV9CTE9DSyk7DQo+ICAgICAgQlVHX09OKHJjKTsNCj4gIH0NCj4gQEAg LTg1MCw3ICs4NTMsNyBAQCB2b2lkIF9faW5pdCBzZXR1cF9mcmFtZXRhYmxlX21hcHBpbmdzKHBh ZGRyX3QgcHMsDQo+IHBhZGRyX3QgcGUpDQo+IA0KPiAgdm9pZCAqX19pbml0IGFyY2hfdm1hcF92 aXJ0X2VuZCh2b2lkKQ0KPiAgew0KPiAtICAgIHJldHVybiAodm9pZCAqKVZNQVBfVklSVF9FTkQ7 DQo+ICsgICAgcmV0dXJuICh2b2lkICopKFZNQVBfVklSVF9TVEFSVCArIFZNQVBfVklSVF9TSVpF KTsNCg0KSXQgc2VlbXMgeW91IHByZWZlciB0byBwb2ludCBfZW5kIHRvIHRoZSBhZGRyZXNzIGFm dGVyIHRoZSBlbmQuIEV2ZW4NCnRob3VnaCB3ZSBnb3QgcmlkIG9mIHRoZSBtYWNybyBkZWZpbml0 aW9uIG9mIF9FTkQuIEJ1dCB3ZSBkaWRuJ3QgYWdyZWUNCm9uIGhvdyB0byB1c2UgaXQuIEZvciBt ZSwgd2hlbiBJIGZpcnN0IHNhdw0KImVuZCA9IHN0YXJ0ICsgTElWRVBBVENIX1ZNQVBfU0laRSIg SSBzdWJjb25zY2lvdXNseSB0aGluayB0aGUgLTEgaXMNCm1pc3NpbmcgaGVyZS4gSSBldmVuIGFk ZGVkIGEgY29tbWVudCwgYnV0IHJlbW92ZWQgaXQgd2hlbiBJIHJlYWNoZWQNCnRvIHRoaXMgbGlu ZSA6ICkNCk1heSBiZSBpdCdzIGJldHRlciB0byBwbGFjZSBzb21lIGNvZGUgZ3VpZGUgZm9yIEVO RCBpbiBjb2RlIGNvbW1lbnQNCmluIHRoZSBTSVpFIGRlZmluaXRpb24sIG90aGVyd2lzZSwgd2Ug bWF5IGhhdmUgZGlmZmVyZW50IHBvaW50IGFkZHJlc3Nlcw0Kb2YgX2VuZCBmdW5jdGlvbnMuDQoN CkNoZWVycywNCldlaSBDaGVuDQoNCj4gIH0NCj4gDQo+ICAvKg0KPiAtLQ0KPiAyLjMyLjANCj4g DQoNCg== From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336284.560636 (Exim 4.92) (envelope-from ) id 1ntPBK-0000lE-Se; Tue, 24 May 2022 07:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336284.560636; Tue, 24 May 2022 07:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPBK-0000l7-Oj; Tue, 24 May 2022 07:42:18 +0000 Received: by outflank-mailman (input) for mailman id 336284; Tue, 24 May 2022 07:42:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP5p-0003DA-NB for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:36:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 705b9b97-dab3-11ec-837e-e5687231ffcc; Mon, 23 May 2022 18:14:36 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-BWfENAyBMZS-q3CNKJWKtw-1; Mon, 23 May 2022 18:14:40 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5558.eurprd04.prod.outlook.com (2603:10a6:20b:9a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 16:14:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 16:14:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 705b9b97-dab3-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653322482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FpquWPTdkPs4vboyT6efgqWfGQrZ9In3hkbUO+6Myso=; b=BZUZ+WP7OKNrrKhUwFCFKNFGigl5JtF2uRx3dqVzp0ptJ5ov1VMSZia8xR4PPZnUtC3IUP FMuYiMA9eUNepKl3oQueRtmXiexl0M/szcW2zwHXXs7i1QmJDAqm9T7ugFDqWkeiP5Ldse BmaQoBQyFAQ4kx1e2BOszd3kfGZiDsU= X-MC-Unique: BWfENAyBMZS-q3CNKJWKtw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vxoi64KltvzFHpLirVPFfpkCmAw6YeAIMP0/F/2q06xeM+vgAV46OaMeDh9RmbD6R2butQZXapt1uOQvdlCbud6CrOAZ24X39OYgiLHICNZ4tZ6+C9utHv/2xK4+9NW9vNqLo18b810csWW3G9J4iSyi+4ll9MZjiBYn3o1WxLCufrZFwxD9wCxLY34J0Xy0XoCXOkn061/1k9bKUv9SsG1ZxSlnAYgxrigZ+MNHRy/reWwVp81d/uxhD+3fUwS7Ea5Y72At1jvnR90D5kZxDSZJ17em7M6fQ55+mkx3/vumjFQRcMGcGvVJw9GWqtTcSOKDKFuRRLgcpDJ/mlueEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FpquWPTdkPs4vboyT6efgqWfGQrZ9In3hkbUO+6Myso=; b=I2Wj7P5mXVi/xOWv+wwwAscP4bHJ3NHFRL9luN2MCaIhVTJHmVNN7jtGDkAs6PRVtstlIxuLoZmhoeiainYfSPfLbDSjuScK/8GBXrwwrX35kqrvnYOeCZlcUenj1pkVsqDDmyQxiFooibz5sWDSy3QpXke3G/5TWkzcdwsKZ5+67qeWDD4fjgWvC3pi/tfklZYqcY9VcOplOD4eVqa1iKfX15QZagmCwP2IFu6DjUMKyLjkB1eBlCVivgEym0udBBwodVpn/22wFUBpaDgiQeX084L8TtVn13KLSS6/krAyIsEa25dpS1gLH0qgNDt1eLhNk4ccgfKDVKUXBPSUNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7225c9cb-8cca-9f84-6b8b-13b6675b8919@suse.com> Date: Mon, 23 May 2022 18:14:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 4/6] xen: Switch to byteswap Content-Language: en-US To: Andrew Cooper Cc: Stefano Stabellini , Bertrand Marquis , George Dunlap , Wei Liu , Julien Grall , =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" References: <8fcd30a6-9b93-6687-a0f5-1e035fa5f789@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0701CA0052.eurprd07.prod.outlook.com (2603:10a6:203:2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdb69cf5-9c2e-410f-75a2-08da3cd75623 X-MS-TrafficTypeDiagnostic: AM6PR04MB5558:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q7kSE5jCl8r1JRj6Xobi61yYBIKtH3NU6dBn0ztAGlACsG/9Z5kzG2gXBtxnuNJIW/264ooiTj3xn7zRHETSHcEGCaaKAiU6Q4AIYhP5rEScOPeYBCNJ8QfoD/9gB+/tyvrtVp71fJj00lOCWwkMefVvwzinMZz+Wm22UFr3gUemYk+TMbmJ7otyjcFTFxVHACWKz4TjAqMRx9HINwzFBLhL1aJr1461ZCDzTc3bx/cXeuyDpaHjydtZUTyrh2ahIFbEGSH3sAy2+EVUUdjU9F17vAPkoKNxaKXETzTQb128/d9XGO4R+bedIRPe1KTtZmb/F0hBW/j0mirNobmh33xLJruYDuaN6AWQ5TRNzUE7qfb+N14mnY9rcHBU0EA8NQJToDS0nWiVpd6RWdXBMOnjBotgcDdA8YFOUA9+Pc0Zc28HRpSXpQioL4xxg/oFsD2Yu744P6psR55AFpS9pRresmtwx6oiLpt3WweogCeS2LJkmjrtQQeyBZxSv5SQ5KgJFzYN/NWDGIJuBjkPsc01ZHkqujmZW7Q2p07GZmojQrZiyPjbJkT1C74HH5oqPq9X8c6nZ/vx25stLYbzzSF+wkjeqgYG1gXAn2OPT6Yxh8Cr0nvArXb3JmvSFDufs9Z84EFEQ2JKD0nYGlvQqaTmBTxTywWrbmPqSBV6LfYd5cS8CoruuR3v6c2jfI8IXXL6bGD7quFxKyMWSF52R9kXHsdPDQgF+c5Fp/ZDUG0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6512007)(26005)(6506007)(508600001)(36756003)(2616005)(83380400001)(6486002)(53546011)(6916009)(186003)(31686004)(4326008)(316002)(66476007)(4744005)(31696002)(66556008)(38100700002)(5660300002)(8676002)(86362001)(8936002)(2906002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1M4eFV3MDF5MHRmNGZKd3RZZnVZQzRUQityVktkRFE3ZDlONjBpcFkrNDBy?= =?utf-8?B?RHJvTzVZMmZHYVlmSzJQQVF1S0JrSWdNL1FBakIxSjcwNDFBSEJnQjJoU0t2?= =?utf-8?B?Vm5QeUdEWnZEY1hHSFJRMWVQT0poSXR2WjlGMDFXVFRaSzhPb2ZiUU1HTDlO?= =?utf-8?B?S2I2Y1pHZkJRcWs3WEdIUDBlNGd1SisxUDNWWldDTDNEVzFsQmVvdW04bnkx?= =?utf-8?B?cCt3OTBRVEhWOVdaOXJYckZtaDZxTWwvVjJjeVB4cC9IeGxxc1Z3R3RLZTV2?= =?utf-8?B?SEJPM21QS1JDekJqTzM2aGVYNEVVbjVaMnVDc0hielBjVG5palVlclZ6cmJn?= =?utf-8?B?YU1kMEdxalZMVTZCREdUYkVTN2hSTnlQOWFZUWhXd3BPb3hWVFlJTEpmRVNU?= =?utf-8?B?dG1nZjdoV2daSXYrYXVBaS9MMXF4SEpNemdqTlVUVzJnSFZRcndTMmFQTFk1?= =?utf-8?B?UWkzZ1dqTWdTSDUxZlBoNWVaNllYVkk3emNKYjhBSW9nWm1LNUxZRjVuQVNY?= =?utf-8?B?Nm04ZVNlRTJBTk1uSmkzWm1PQjZUa2FpMGx0ZHViU2tNRjVlTjNGaVU2UVFm?= =?utf-8?B?M0dSRU1QOUU5M1g3VUh2cDVrRDRrQWNXZHF6Z3g2OUc3U1EwYnJmRWlibjZm?= =?utf-8?B?Q2w4d3k2Q1l4Y2JoWkRZTWdKc1FIZ0FmT3ArNUNYeS9qOTB1TWxPMnJ5ajB2?= =?utf-8?B?MTE1b1FocW5BVWh5eXVNSEtuQWNvTkFmczFNWDZOMmNnbEpYWTNOWWdVdGJk?= =?utf-8?B?eHdYZFk5cDlLcDV4ZGFnSmdTeFlIVElIcEFZUDM3Sys2N0FWeWozRGRPZGsy?= =?utf-8?B?MDJ2TFJ2eDlKZVZoQ2tRRUtBbWE4eXhTYk5TcDQ1M1FoeFU1akRFRFIrcnVI?= =?utf-8?B?UVQyS1A5S25SaEhMOWhlMGc3elY4SFlldUsxQ2VGdDRSUGMyenU2OFVDVEJL?= =?utf-8?B?dnAvWTROd05lYlROYVBRQXBHRmtEenBNV2Y2anZoMXdXN1VWVUZtOFNRTzVJ?= =?utf-8?B?M3RScnB3dkc3RlJqUDFhZnMzUWNBMEV5ZGVMbGt4MUV0cmp4UzFYZU42dkFk?= =?utf-8?B?UEVLb2RLcHB3a21aYWNoY3NQWC9wbmE0cC84RWhTR0xHWElSeWwrblFSYmVD?= =?utf-8?B?WXBoeloxSC9Qc0tpUEU3aUg2NWJjZkMxejdpcmljM0gyTEVwSXpVakJlNitk?= =?utf-8?B?VkIwR0dxNmlNVmc3eHdZRTRzbXJ6TUk1RjAyZzNRNlNmWWluNWczUWZuWGJu?= =?utf-8?B?MFNCWnd4Z09INTJHUXNVQS9hd21EOU90YlZWOUtsT1FYL0l2cXUxVnZXSmIr?= =?utf-8?B?dXZTZ1FDR256V1VZcGlrU3RrYWd0a2t2bzVyWHQ0QTNnZkNOV2l0ck9iUFhB?= =?utf-8?B?WEVJTjNhNWN0YmNYZWtJa3VkNFJjRGJRSDZiU2lmQjVnY3VKNXlPNytqUVY5?= =?utf-8?B?c1VaSFJBWUVJZnJraVBJQkxYdHdKUm5WY1ZkR05xVjQwdWloanYxWmNBcDZw?= =?utf-8?B?TVQzcE9wQVNzUXlpd3daU201c3FUbnJmOUc2blB0Zjg0VUkwYnliUEVrOTZO?= =?utf-8?B?WDJud0MwcFNZN3lkLzRTTGgrVStNTy9QenZleWhhSnhGTVJ1U3pkT2ViaHNa?= =?utf-8?B?bGpZSnNVOURmdW9qOWJwTkdmNFVjV1Qxc2Y5NFdEbkNDZ1M2cmUrMVBGSVg5?= =?utf-8?B?WnU2RFEyRFJnSDB0UUNtOUZSYkphRndtaWM5ZStrZmpMNHpmcGRhQkJpVFFB?= =?utf-8?B?WC9DYUFkb1R1UVRJUCtLdlZvTGhYR0U3Wmdaa2NGWHE3OHhOVkJFS2Y3SkdO?= =?utf-8?B?UzlDWGtwelhieHFrOW4rRnNON2U5TUZsUDhWYk0zdmJyeDQwSm4vSnFNTURo?= =?utf-8?B?SGRqeWNPb05hc216MUtGdksxT1JjUDRSVzdySFUxaDBpc094TUVwRzdCMmFy?= =?utf-8?B?SUVmQU91N0F4Mmc5R3diQ3BnQjgvdkpLRVBDTm5sNytLWU5lcm5qVll0NkN1?= =?utf-8?B?Q0JVcFlJb3JoeTZ3ZnJTRHM1MFR5NXpFb0NPS2RySHUydCtRTVpoeWR5aWZ2?= =?utf-8?B?MEVvdWp1VnozRTRBS2REZTVrNUNTQ0JKUTkzWUpHa3RhdC8yWFljbUIvMWQz?= =?utf-8?B?a1BIUytucXdKUktndjRYT1B1NWhpZ2pCQjZubFp3NTFOTGZUbWN2QnRUQU5m?= =?utf-8?B?Y3Blc2F6R284QysybHlsN0lHSnFiR2FVRzRHQ3FUT1k0UHpDckkxbzJObzRP?= =?utf-8?B?VFozczNSeEpYb1ZPa3EyOHViUGhkWUtoU2JjaXV1UTRnQ1luWk1xK1Q0VGtY?= =?utf-8?B?MS9lV2dpdmo0bWdyckhMNUQvVk9JL2c5d1lCY0kvVnRGL1Vib3N5UT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdb69cf5-9c2e-410f-75a2-08da3cd75623 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 16:14:38.8708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nYA2S5/qbdqluVk3I4rtwmE3B02N6H5iiFfExwFPMhxWsmdXaDh76GoDHKhc21rhlgOhGSDWToe3CkPAKw/Dfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5558 On 23.05.2022 17:38, Andrew Cooper wrote: > On 23/05/2022 15:56, Julien Grall wrote: >> On 23/05/2022 15:50, Lin Liu wrote: >>> Update to use byteswap to swap bytes >>> be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter >>> one explictly >> >> But why? > > Because deleting code obfuscation constructs *is* the point of the cleanup. It's obfuscation only as long as not implemented correctly, i.e. dealing with unaligned data. Then "be*_to_cpup(p) is short for be*to_cpu(*p)" no longer applies. Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 07:42:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:42:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336285.560641 (Exim 4.92) (envelope-from ) id 1ntPBL-0000pI-7q; Tue, 24 May 2022 07:42:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336285.560641; Tue, 24 May 2022 07:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPBL-0000oW-1P; Tue, 24 May 2022 07:42:19 +0000 Received: by outflank-mailman (input) for mailman id 336285; Tue, 24 May 2022 07:42:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntP6P-0003DA-Sf for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:37:13 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17592183-db2e-11ec-837e-e5687231ffcc; Tue, 24 May 2022 08:52:36 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 02:52:33 -0400 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com (2603:10b6:a03:286::9) by SJ0PR03MB6675.namprd03.prod.outlook.com (2603:10b6:a03:38d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 06:52:32 +0000 Received: from SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0]) by SJ0PR03MB5405.namprd03.prod.outlook.com ([fe80::871:4ab8:9b74:1cf0%4]) with mapi id 15.20.5273.023; Tue, 24 May 2022 06:52:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17592183-db2e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653375156; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=zk2mZpUlxkSyWF7bF7XclHWxrpHIywvG2VFlvPQCO4I=; b=blchsjMUTNRr3wCKh/fX0V3JeeziXsiz3geNY/YDOwD1q0jFw4ZErbGs hkcFEWIma1SIQ2I12ttiuQxS0d+fYMTixRUqdTe83Zmx5CRmewjwiJwrN wHtauwUnDjXCSd8eteH3LcwnRduvbFWRCRbAiM4eYzd+XLwTiXrrQAgk2 g=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 72027380 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FfduP6i6zloNWQAQGMu1QwlnX161ZREKZh0ujC45NGQN5FlHY01je htvCGjQPKyDambzKdF+bY+w/EwG6pPdxoNlGVM6/ns3RSgb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnR4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVs5G43MouclaiZjTAZ0eo5r8o/cDmfq5KR/z2WeG5ft69NHKRhveKY/o6NwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEehWhr7ixNNa+2i 84xbTtpKhDBfjVEO0sNCYJ4l+Ct7pX6W2IC8AjK/vpvi4TV5C9B9eizYMX4QfHJY89YgHa3h DKd8U2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRokyxQdVEM GQP5zEj66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/Qjvc4yADctj 1mAmoqwASQ16eLOD3WA6r2TsDW+fzAPKnMPbjMFSg1D5MT/pIY0jVTESdML/LOJs+AZ0ArYm 1iixBXSTZ1K5SLX/81XJWz6vg8= IronPort-HdrOrdr: A9a23:Q9nVaK58FhneAEQFpQPXwX2BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP2ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdkyNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDJnfKk4Xid7N9p0Q6v9bbQuwqdneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2KIoM3R3am+a/hRrDvDnZPiq59hs1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a gpfGkoxFLaIXied/Fm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA== X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208,217";a="72027380" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2EybRfkPzkjfmQI94R1a+EJuI5PZY/MXcZgNjdV/24HRQFHghX1JoMFRysKmXOVnDehySvYENdTWPRLaG6EPhnC9h5wgvd6od7k/X3LhDcUYN2FE3S7+UDVmgH3vYg/a53lFI87U8h50ZnRmjs5VNmLvVWPfkqJuMgyYE7etA3QUOM62K1ZtcTB4lex/xoRkYBrmx2v8EZwhTTN/V79EtZdwfoNLuYDG7jbUlDyZkU+VYqr/jViK91pEh09yEnWgBsVdtNwSo4ZUqc5kE+ReNuunZKIiQW9OjLXnrZDvOvGx97thf5KzDYNE7q6/R0a4rAGl5AfDCw6C2TasF9pBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JBesWdDLE7XH0mMmKBbgrgVOHPAfiXnfq6JIlvEC5FU=; b=jrbBRAtGFO6GwcUpSCtsl/rKsojCpw1wBCm314kYFGkhKiH02mOgnLnlrgSZ8mbtVjbzQo/6b7a2Nll6obqsaw97XBNZmiAKpf8XPk+HfXwhMXd4L3VS50NH+XBDrhLsdwsm4mRh0ZUzeG2inYeF/igTp8fPdL2NgDZOfMQhTcl2gt/MP8LPjzY/973Ap0km0pdWIKibyjeC0etWnjhh5mM15bkuqNk1itVyD9JfT5gL4VOeBOAavx2RI9k5YwhBQ18kuGtuoldF3JVO4L2TCc6q6LwvEErR6tBjoyrRyRuGQNKMuOTkbxBNrqsPrYy0w6sheGrqvZinkRhWflCwmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JBesWdDLE7XH0mMmKBbgrgVOHPAfiXnfq6JIlvEC5FU=; b=ncW+JjsS6/gAmeo1VNckF6SUh/hg9EzfFNAqauIyA2HT8+2lAk7q3UltdpQnHYoDH5MozF6CffZZZ6o0qS2rX8nQEmRikKgvyQ/Za++8qdqbu7rqmT2XQ1B4YJDWr0qIRJKXV07YSBgatzfKWiXblQvrqvMKgSFxGWQ1YYe2E9Y= From: =?gb2312?B?TGluIExpdSCjqMH1wdajqQ==?= To: Jan Beulich CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Topic: [PATCH v4 5/6] tools: Use new byteswap helper Thread-Index: AQHYbordwufrrqV0k06ypnfJmfxjlq0sTnKAgAD4X1GAAEYaAIAAC20q Date: Tue, 24 May 2022 06:52:31 +0000 Message-ID: References: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> In-Reply-To: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c02853d-f138-4bf6-50e4-08da3d51f9d7 x-ms-traffictypediagnostic: SJ0PR03MB6675:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PDi9cTm7ZauPm0Q6PJbi3OG/jmdSPdAIuW0Grxs+dl0QoxjNg03jwpejMZYrTGvEQRU+vgNGCL0FG6AidGpg+N02EnkeUEgwe17kwzdO/Bd01wrcSe8hcHl+JNsnL8+hDj64yYOCr4iDTk6B2FOSgYWll5kSKYp7R09FZckF7GvJBa7BED/yPAzCHHBcm2npygjuUqSKcw46RefXACzZd3AioDSTBexshwjXaF6MGGD+5ZpJiJdu+a21idiLOUgWH5F6b3Fmv1LTB78015t/mC90JHYZ+JRdRsUbT+qtN0/7gvygFlIIHpJA5CeLaC+0KvkE4kqYCczxbW9YtEk0QjTGVg1MiwF0r8Qz2X/LZYzeAd5jv3IVtrbFdjiP4zB8V5Y4lF0KEOWWRuoCMvDgkZcM7yo1kufa11MJ8rPT0ME/Jw7GNDIw6pf8ElYmSgdJk2KQuYXlqBqTViZJUOJlWnCO1Jc93vW9IbdiZEj+nd/ANsz4TFOhsaopkt0ZdYjNDY5t7SiMvUMQxaHg5vbWVbOjiYnO2LJcgDQYzDUnvW7ibTwEIhkZQzIIOhMfnVDdEzZ5hzNm89MowA7SsG8vx7vqHeWyGBuoTsp8i2ipHHTUJqBLrlDrYkxOFfimO2DzUUX1uCmkg8qzzL2vWLOCUx/OAKctE+42STLh+OvAfO/k7EZA6d5Rt90imJPzV4XmTQikSTGLIg1VEPf+1BQs8w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5405.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(6506007)(86362001)(9686003)(2906002)(76116006)(7696005)(38100700002)(122000001)(53546011)(82960400001)(66946007)(186003)(6916009)(33656002)(54906003)(316002)(4326008)(55016003)(66446008)(5660300002)(52536014)(8676002)(91956017)(66476007)(85182001)(8936002)(64756008)(71200400001)(66556008)(508600001)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?gb2312?B?b0NqNTcwY0Zqckg5SS82ak5TajBiSmp6ck01akRlM1hWa3dzSndiOVJ1VEdh?= =?gb2312?B?TkJTSThsQ0lWU1FrWThZMEdCbkdCOXliUm1XekZxMzIvZ05ldFhVTVVleldM?= =?gb2312?B?VE1aNmQ4TXZabHo3ck1KLzRTbnA5RHZyRWRzMWRYbHhYblhIQVhwY2ZXbitz?= =?gb2312?B?cjVUZkVnSnJ4c2Z6M2tQSG9lekhCeGxVYUEweUFZM3RUNVV2bjBjNnc5M0JK?= =?gb2312?B?M0lYOHFtMWZRQStndlZ1NW8xUjNnYzJWeDM5dnVkcStyQkpqZmNNeEZsUEkz?= =?gb2312?B?SDE4L05NakE5MnBreU9VRDV2OS9BdWFlWjNtT0FYbVJzb1JPUWFqaC8zQTRW?= =?gb2312?B?WncrajZFc0wvTnM4WjZ5VXJvUGFUM1h1dGJCcGswZ0RYbzRCU3B3TlJVODhx?= =?gb2312?B?NnQ4WjVUWjNibUduNWsxZFh0QS9oaUJVYVBnaWhJZG95L2wzUXNhdnl6UEcr?= =?gb2312?B?OERMWUF4RnlrZlVwTUpMWGpubGxFam1Pc3JIbko1TXVqMGpvYllCYlF2TXNa?= =?gb2312?B?ZElaVUNMaGllNmtFa2JBVlBwbm9YaDFvSWQ0aGJnbklrMmVaR2NiUEVVbzNI?= =?gb2312?B?K2pUaGxzQ2Vjdnp3RUZRSy9rMzliOWdLbVRZRUc0RDBQV3dFd0VabFFoNzdX?= =?gb2312?B?bXVJRFEreUt3NzFYakF4UThZVGVlR01KYk44VFlnWm5ZNGhXQk56L1RYampP?= =?gb2312?B?d1ZTZXV6NlU5SWdHdElncm5SaWRMNWZiMjVjY1p1UTRPeW9Sb2ovVmpyYnN3?= =?gb2312?B?aW5BbExyZ1BCRjVPM3BHL0RKaE5KWnNVRnZDdW1PczV1RHZWcW8ydTBKYWhR?= =?gb2312?B?SDYwWjZHRGFNb1RmN1hNSnZ5bHdHVVFQWjJSUWIyU3VrSzNDR044d1BkcTIw?= =?gb2312?B?RDFpR3VPaWhjTkNmSXdJZC9MKzBrYlRGNFF0clM4M1ZnaUs2N0ZVbTZUUFEy?= =?gb2312?B?U0FHTDkrVUdUSndVbUJ4Wi90K2thMWloSXdIaGVmU1MrQ2J1VzhSeGdOV3Ar?= =?gb2312?B?NUtjTU9RUkh4cnhYT2JmN1cvbGdmUlBEb2JJSDN4clJmYjFzdjNFZUlZWElG?= =?gb2312?B?ak9VeHNXaTM3d0h3dDE1MzVMbmxkbndtcFV4VVQyOEp3UFAvaXY4WVcraFBD?= =?gb2312?B?d1pHZHJDMTFYZXcwUW04Q3lwdTZYQklrTVo3RHdCeTVhSDFqSklGQWFCb3lY?= =?gb2312?B?Qjhnb1pjYkRaeUVCRGtBdTl6emRtWFFLb2k1Ly9RSG1WMTc0SkM0ZXVtbHRL?= =?gb2312?B?L1Mvbzc5dnBoeWZVNW9Hd2ZCQUpWZTRYL1dOSVZFanlnV1RSNy9lZTJUUWFh?= =?gb2312?B?eFFNV1ozUjJJSTQ5QlJyeE5nOVUyeE9pY2RVSFFBQytoaS9YZEVpWGljTEk1?= =?gb2312?B?cTIwMWEyQjdlbUp0VjVUc3dYaDR0RE9Sam1NR3lORWk5NXUwQjNmc0pFNlFH?= =?gb2312?B?QlloWjVPN2pOUXR5UytRRmRIcWNYbXoyenVCVG8ydTc0RFFOY0RLeEVFaUMv?= =?gb2312?B?WDlFeXhBVEpRL0ZDZHZPZ2lqR3ZLUUFMNGgydWFzOGRzbUt1WS9IVXI4eUh6?= =?gb2312?B?SzM3WjE3SWt0dTlheU4yRUpuNFg1TjlmUGJtd0xGeWlUc3pKSkw0N2tMbGd3?= =?gb2312?B?NFVVWUpEeklXcUd3L2s3V0ZKYmJUYjc1aHpSYXRpM09OTlkvU2lNMVJqWlE4?= =?gb2312?B?S3oxbTJQcmY0ZDlSMUxCODA5WmVvbWhpOXhMU29xbS9ibGtRNEFrUm1JNjhH?= =?gb2312?B?SU9pcTBJZ1E4V2VRYW1LbWo3VGZ5cVAwSDYySm1NS2g4TEtmb0Y5NmJzODVw?= =?gb2312?B?TzdKQjNaNHM5NEtKMU9kZkQvWnJCanVaY1hhM21NbjkwMUROaWJNekVROXlW?= =?gb2312?B?TkxzbmFwaE5VUHNKSWYzeFVReHFjaTRSTlpGdXdQcEZNOXBrM0NqOE1YME5G?= =?gb2312?B?d052UUlVdytRSXVSRGlKaGRvaGk5dnp1Q2FHWXhYVTRkVjg1S2lsSXhsb2NH?= =?gb2312?B?d1BDTlB0Q3Y0dUM2YVpkenFwY2FRVlpWVnpxaWxPK2cyWTZ6UnpNeUxFamxa?= =?gb2312?B?c0VJcTRBR1RlMmZDSk1zWVBRd3BzWVprU2hkWnpHN2ViaW5wQmp1Z3orTEZI?= =?gb2312?B?ckRORjNhd1oyU1FZRnlkZjlCVUd4bEVXck14d1pYcWxIY0tzbEJkbUliQzJj?= =?gb2312?B?Y0dQbjNVc2FiZm9sR1h0ZEtHMDFSTGh2aDdZaGVUMzlTcHRrcDNsTFJHSFFr?= =?gb2312?B?dm9NRDZEcGR6TG5xT1NzSytQNnVFVUhpU25xZGdLcDNKZ3E0NGh0clZiRUcx?= =?gb2312?B?R05QcFMyeks1N3ZKWlJrcXhmNWZzUmJRZVVHcVdXajJjK0xaeWtzcVpCZkha?= =?gb2312?Q?aaVKi6EX2s2gOWjs=3D?= Content-Type: multipart/alternative; boundary="_000_SJ0PR03MB5405B465EDA6717EF1F83A9B9DD79SJ0PR03MB5405namp_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5405.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c02853d-f138-4bf6-50e4-08da3d51f9d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 06:52:31.9160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nEuf9x77s4ys0QqHX5PWibCgavoaTLfzJ/zCpXImx6cGKdM0PumXs8W02yDxiFLv7R1Jki/v/qlAOsu/R0rzSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6675 --_000_SJ0PR03MB5405B465EDA6717EF1F83A9B9DD79SJ0PR03MB5405namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Pj4gT24gMjMuMDUuMjAyMiAxMTo1MiwgTGluIExpdSB3cm90ZToNCj4+Pj4gLS0tIGEvdG9vbHMv bGlicy9ndWVzdC94Z19kb21fZGVjb21wcmVzc191bnNhZmVfeHouYw0KPj4+PiArKysgYi90b29s cy9saWJzL2d1ZXN0L3hnX2RvbV9kZWNvbXByZXNzX3Vuc2FmZV94ei5jDQo+Pj4+IEBAIC0zNCw2 ICszNCwxMSBAQCBzdGF0aWMgaW5saW5lIHUzMiBsZTMyX3RvX2NwdXAoY29uc3QgdTMyICpwKQ0K Pj4+PiAgICAgICAgcmV0dXJuIGNwdV90b19sZTMyKCpwKTsNCj4+Pj4gIH0NCj4+Pj4NCj4+Pj4g K3N0YXRpYyBpbmxpbmUgdTMyIGxlMzJfdG9fY3B1KHUzMiB2YWwpDQo+Pj4+ICt7DQo+Pj4+ICsg ICByZXR1cm4gbGUzMl90b19jcHVwKChjb25zdCB1MzIgKikmdmFsKTsNCj4+Pj4gK30NCj4+Pg0K Pj4+IFdoeSB0aGUgY2FzdD8gQW5kIHdoeSBub3QgdWludDMyX3Q/DQo+Pj4NCj4+PiBKYW4NCj4+ DQo+PiBsZTMyX3RvX2NwdXAgaGFzIGZvbGxvd2luZyBwcm90b3R5ZSBhbmQgZGVmaW5pdGlvbg0K Pj4NCj4+IHN0YXRpYyBpbmxpbmUgdTMyIGxlMzJfdG9fY3B1cChjb25zdCB1MzIgKnApDQo+PiB7 DQo+PiAgICAgICAgIHJldHVybiBjcHVfdG9fbGUzMigqcCk7DQo+PiB9DQo+Pg0KPj4geGdfZG9t X2RlY29tcHJlc3NfdW5zYWZlX3h6LmMgcmVkZWZpbmUgYW5kIHVzZSB1MzIsIHVzZSB1MzIgdG8g a2VlcCBjb25zaXN0ZW50DQo+PiB0eXBlZGVmIHVpbnQzMl90IHUzMjsNCj4NCj5UaGlzIGFuc3dl cnMgbmVpdGhlciBwYXJ0IG9mIG15IHF1ZXN0aW9uLiBGb3IgdTMyIHZzIHVpbnQzMl90LCBwbGVh c2UNCj5hbHNvIHNlZSAuL0NPRElOR19TVFlMRS4NCg0KVHlwZSBjYXN0IGlzIHVubmVjZXNzYXJ5 LCB3aWxsIGJlIHJlbW92ZWQgaW4gbmV4dCB2ZXJzaW9uIG9mIHBhdGNoDQpDT0RJTkdfU1RZTEUg ZW5jb3VyYWdlIHVpbnQzMl90IGluc3RlYWQgb2YgdTMyLA0KSG93ZXZlciwgQ3VycmVudCB4Z19k b21fZGVjb21wcmVzc191bnNhZmVfeHouYyBhbHJlYWR5IHVzZSB1MzIgaW5zdGVhZCBvZiB1bml0 MzJfdCwgc28gSQ0KdXNlIHUzMiB0byBrZWVwIGNlbnNpc3RlbnQsIG90aGVyd2lzZSwgdGhlIGNv ZGUgbG9vayBzdHJhbmdlDQo= --_000_SJ0PR03MB5405B465EDA6717EF1F83A9B9DD79SJ0PR03MB5405namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

>> On 23.05.2022 11:52, Lin Liu wrot= e:

>>>> --= - a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>> ++= + b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>> @@= -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p)

>>>>&nb= sp;       return cpu_to_le32(*p);<= /span>

>>>>&nb= sp; }

>>>> 

>>>> +s= tatic inline u32 le32_to_cpu(u32 val)

>>>> +{=

>>>> +&= nbsp;  return le32_to_cpup((const u32 *)&val);

>>>> +}=

>>>&n= bsp;

>>> Why th= e cast? And why not uint32_t?

>>>&n= bsp;

>>> Jan

>>

>> le32_to_cp= up has following prototye and definition

>>

>> static inl= ine u32 le32_to_cpup(const u32 *p)

>> {

>>  = ;       return cpu_to_le32(*p);

>> }

>>

>> xg_dom_dec= ompress_unsafe_xz.c redefine and use u32, use u32 to keep consistent

>> typedef ui= nt32_t u32;

> 

>This answers ne= ither part of my question. For u32 vs uint32_t, please

>also see ./CODI= NG_STYLE.

 

Type cast is unnecessary, will be removed in next version of patch

CODING_STYLE encour= age uint32_t instead of u32,

However, Current xg= _dom_decompress_unsafe_xz.c already use u32 instead of unit32_t, so I<= /o:p>

use u32 to keep cen= sistent, otherwise, = the code look strange

--_000_SJ0PR03MB5405B465EDA6717EF1F83A9B9DD79SJ0PR03MB5405namp_-- From xen-devel-bounces@lists.xenproject.org Tue May 24 07:55:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:55:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336360.560658 (Exim 4.92) (envelope-from ) id 1ntPNd-0004eM-NX; Tue, 24 May 2022 07:55:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336360.560658; Tue, 24 May 2022 07:55:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPNd-0004eF-JQ; Tue, 24 May 2022 07:55:01 +0000 Received: by outflank-mailman (input) for mailman id 336360; Tue, 24 May 2022 07:55:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPNc-0004e2-Sm for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:55:01 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on060b.outbound.protection.outlook.com [2a01:111:f400:fe05::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf8637b9-db36-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 09:55:00 +0200 (CEST) Received: from AS9PR04CA0099.eurprd04.prod.outlook.com (2603:10a6:20b:50e::22) by PAXPR08MB6910.eurprd08.prod.outlook.com (2603:10a6:102:132::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Tue, 24 May 2022 07:54:58 +0000 Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::fe) by AS9PR04CA0099.outlook.office365.com (2603:10a6:20b:50e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23 via Frontend Transport; Tue, 24 May 2022 07:54:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 07:54:56 +0000 Received: ("Tessian outbound 9a0893f586e2:v119"); Tue, 24 May 2022 07:54:56 +0000 Received: from 98c5cdd63b57.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FDC5B9E4-1F08-48EE-BC04-DA0092F08C9C.1; Tue, 24 May 2022 07:54:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 98c5cdd63b57.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 07:54:50 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB6851.eurprd08.prod.outlook.com (2603:10a6:20b:305::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Tue, 24 May 2022 07:54:49 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 07:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf8637b9-db36-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b6L8jXnHLpL5vKq/GYxvuphxjOJNbOFpi7iCwga1FoxBtDS1cdzEXw/oXuqTOEAWOhqJDPZAJ92RkA/4Fjmk/KqKkKgWwET/6TGOxI/5IC8wpvt5zgP8mqmmvWjHi2QnwCrlExz9pPvtnmDjDHxDc6r1o5HldbY3vcE2NKMreFzUAWwHCHZSGctHqR8qREFi043pScneD1g02W4OGmbgJo7M+yLoaUnkMEUlKoH7mK+/uH+X+HNCk97uZnZRAEI2/00hcAMmeShU4oS3h7IuASib1ZvJxAPqCgLWyxWIQNtRTJu1M3S9atAz9vRDop9A905PMjFa0XySWlSDqpJEdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=UQFLv5FnmANDvughLj0L1QF4qocGLMK47iS+daKgK7mW3MBML4NDn15/RRzwoGU0g/gGBuYSxBsW0h3d+VxugSkVc6lHY3nk2EFot9uUjqhlLr77tZtMOdfWuxEgVHfxDT7zgw/ZFsps3XN2lMhHM+OM0jvkWzYVk8mfCofEHC8fxyHX2+kVh2KCqg/MAooU3rdbDpc6oL4eHaxE3o2F12sPJ3XJ6A3AWxN24gyiIU08ELxwTssfN5QKFurHH1b7g5ntw2mKAb+QEYnjPDlzVuc0RbQqc30I8N9bNieInOrc+cQCTH/MbQ+VlWVJr3ed8aqYiYHVUkhB+g6sleZGPA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=EP4llLCzmdgc8l9ulxgEY0sleJ0IThkLbQXkhdtM+HTdGNitjUeWw1kXiUiPgxyfByw3yB9kMZpYJJqUiQ2dmDq78BxLRnPa8m0aYKVkZhVc6OHX2wGg4KDvs/bM+sjyXLlj3Qkbkq9lsiy0lHqagruAFEjfPf4XXuOn+Ec814E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com;dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 491f5a1e2d897338 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ONseBJqNOrKzGGzzhXMagDlR9SmXR8grM7OeHq3GPsP1cGD4SEGnNDgcDzEB5nyXO4AetiS3PGpLjWCidS25vU5ngIiR1bTBTgSc12jPEa6RMVohZU3/HHe72UXJ/IWpjU2FAevm2YrHmJ10uTVyhamAnARbHzHsYTS83PfdADBqWpCKxrMmnM/IeaRqZBYzxkJ/e109EPH740hRfyP2gcXMeSsd7ezwIP0BmvJC5okk7ENDjfoyS3gDFERnChdVtfm9j1LiUqF3R2xrBrOj0CwjIxtbh4QqDExU6PRSUtoL8f1gc5gsjPD6zBPYY5Wgefke+RAplVyQ5/oj/0Rlaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=lGh2+bG0gBX0ZV7vOx6r69Xe5wtsgOrkA8LgEZxn4MHR9UcSheSTKzJ/b2MEr+grJ+xA2S/9ePAoNGN6XMgl7PchCyvh6tcVNRI89YUQZwrJhuuAIEHmKmWpwFT9kyJJCxD0PNXyVkTeK6n/4jCrB69EYu80GJbzWCAOOg7O8fBSC9NWT0BbhsPScCIO6TrqqSFJw/08mUSOdygHLIS3DYxOO+9BtrsbSqSmKjBkSd9cp6ZIHyQ73WkX88+6665vddFI6EUyves9XXSGwsEMyfrQWxrGtZA9VX59d5KM4Vke0+kOKxRkmDPKjtISiNDO+h9a7T0kKQ1JZSSdPnlQzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=EP4llLCzmdgc8l9ulxgEY0sleJ0IThkLbQXkhdtM+HTdGNitjUeWw1kXiUiPgxyfByw3yB9kMZpYJJqUiQ2dmDq78BxLRnPa8m0aYKVkZhVc6OHX2wGg4KDvs/bM+sjyXLlj3Qkbkq9lsiy0lHqagruAFEjfPf4XXuOn+Ec814E= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini Subject: Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() Thread-Topic: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() Thread-Index: AQHYbf1I/4cyEYG0EkCW5QIQgj3DOK0tqxkA Date: Tue, 24 May 2022 07:54:49 +0000 Message-ID: References: <20220522165900.83104-1-julien@xen.org> In-Reply-To: <20220522165900.83104-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5ebfd2b1-e7ef-49b7-a9df-08da3d5ab216 x-ms-traffictypediagnostic: AM9PR08MB6851:EE_|AM5EUR03FT051:EE_|PAXPR08MB6910:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7buXZEDYrCjCc8QUfS1lh+wzF9U4EX4gdL7mVoNjCseUBhuiDXZ/09z/ek8+Pbejjb/NI3UTUBqlj4LpUX50abZSW5zTtrQmmnY3PGvrLJLWAwOuZ8Dg39nv5r7pSuFYWgDaHLf8pgiaF8m9HhUZ82OV5hoQVTN9ZADrkt7TeMuAoHqlsbLt4sdKDNRvo/cGqfDeqP+yK2fAQvxqhpD5q9gfVmQUsukKAdHldvhdOPHU6AehtzZ0JPYkDD4/J9jlVzHGSScTL8zn02lecPUPIItI1D+O+US3ktTJsxeuDA8x1oYVyAA5YFz8A8PREUbrTOoawnJ2IXRrvoRXRbL0plXLTC8KWSOS/t71Omt0hc15G7VqoII8g4t10gsdE+d86ldFotsUP8HLscpCVb8m6PXV9uCQTWXxNW8TH22zeBFhYm3ATw9UK2T2uH4coudIEgMqGaO2dNUvodJfOgMiMCmKtJFtIgAAWhBH//00mBx53aIzRFTD5G885tGU5yxrGVWudibtbgxoU28QTW7/fowohHW9vVJTgLIndgIgbNKIn1AekRFhGSvfDBrVZMsgf8pxlHFoyZLEZRodR+m3XeGjVk1zfEO0uZVATl/LtaSmOvGCBbrnlVNS8AEcPEE8201Fc/DyTi0YZzzGuV/ixiMOFKybuPMDEwWJ/RxLXOGC2TZ3dw95cuKbkQ+F+vB7Rw9hVwf1RLUEzmI9zw7Q8nAGGojymSQNE/fAAkpJnrfa/SjjyO7fUbU0lKTfHpZN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(66446008)(6506007)(53546011)(86362001)(5660300002)(64756008)(66476007)(66946007)(38070700005)(54906003)(6916009)(508600001)(122000001)(316002)(71200400001)(6486002)(186003)(2616005)(83380400001)(2906002)(36756003)(38100700002)(76116006)(6512007)(66556008)(33656002)(26005)(8676002)(4326008)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <0731EF46F44DEF40973568AEF9C60819@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6851 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 11e53d1f-5ef9-4653-b021-08da3d5aad88 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Na356/+GfXADQc29ADwqX8JlOBO71K6sOjPQ7e1QAg3uvKi/LEfcHoSJdSfvP9BY+TLy7qPYn4UldGPqC29xM9b6whBh+zCZWd3wrGTQWEEih5+ddIAUmNGyxN3n2NUwsgKm2Nn8yHU5Mkc/ql9nI0a3GL5BiUilUvr+ORuzbjzgqh2xpztxOlOpSmQkQlPXc637mRMAzkoBO0RMHoQaM34OUmbQuanVvQ2UlTsuQQ9iJUgvsEPYpsdO9+RLnt1cYtMBGnNRg+6Tbh2BHQ9tWudRpdkiYAOc9UWaq3QdeglWuBgH+/VIIx5FccBz+t4HUho/QI4TpHwu16ryQcvI15bjr3Fj4B9ILV2EwCJKa1D3bTV8pg1ljqZ4TK06/45sRRWcF67pWr+4BN4tqsBgVQommx75yFyMLMx64Bab+ygVnJxaBC215Z5OWnPUMPw8mtbeKNS7XbzZLfuLUQvuwRvmqTMdyrUppNUunu1fus2z4h0CntDc/LP0KWpvUcaZRaKiJWEGc+pJ52ho9zxhMjUFZ+XvsjwbpB3Yf2AVoS8Z/81esOxwkJVaVCFQvsMcss+NUyTf8QmGvOJaGZDUadzhAwU4ToIysUR1dZF/iPkrT+ej0b+DizrZh1JI6JgE9Z5gaYBc8lAiE3LI5QGRwjQwfft3ZyG5J/aq0XeqLQG6z3f2aUEW8jxTfp3BpHt X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(6486002)(6512007)(2906002)(70586007)(70206006)(54906003)(316002)(26005)(53546011)(33656002)(86362001)(107886003)(8936002)(36756003)(5660300002)(2616005)(4326008)(8676002)(6862004)(40460700003)(82310400005)(81166007)(336012)(47076005)(186003)(83380400001)(6506007)(356005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 07:54:56.9993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebfd2b1-e7ef-49b7-a9df-08da3d5ab216 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6910 Hi Julien, > On 22 May 2022, at 17:59, Julien Grall wrote: >=20 > From: Julien Grall >=20 > xsm_deasign_dtdevice() will indicate whether the caller is allowed > to issue the operation. So the return value has to be checked. >=20 > Spotted by clang static analyzer. >=20 > Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device t= o support DT device") > Signed-off-by: Julien Grall With the typo spotted by Michal solved (can be done on commit): Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > Platform device-passthrough is not security supported. Hence why this is > sent directly to xen-devel. > --- > xen/drivers/passthrough/device_tree.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthro= ugh/device_tree.c > index 98f2aa0dad68..1c32d7b50cce 100644 > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -269,6 +269,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, str= uct domain *d, > break; >=20 > ret =3D xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev)= ); > + if ( ret ) > + break; >=20 > if ( d =3D=3D dom_io ) > return -EINVAL; > --=20 > 2.32.0 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue May 24 07:57:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 07:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336368.560669 (Exim 4.92) (envelope-from ) id 1ntPPt-0005Dp-71; Tue, 24 May 2022 07:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336368.560669; Tue, 24 May 2022 07:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPPt-0005Di-2f; Tue, 24 May 2022 07:57:21 +0000 Received: by outflank-mailman (input) for mailman id 336368; Tue, 24 May 2022 07:57:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPPs-0005Dc-3A for xen-devel@lists.xenproject.org; Tue, 24 May 2022 07:57:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0d::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21f9bd4d-db37-11ec-837e-e5687231ffcc; Tue, 24 May 2022 09:57:19 +0200 (CEST) Received: from DB8PR06CA0009.eurprd06.prod.outlook.com (2603:10a6:10:100::22) by VI1PR08MB5502.eurprd08.prod.outlook.com (2603:10a6:803:12f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 07:57:16 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::ec) by DB8PR06CA0009.outlook.office365.com (2603:10a6:10:100::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 07:57:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 07:57:16 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 07:57:16 +0000 Received: from b4f563890f9e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D5B12D5E-CD91-4A21-8CD6-055CC1D98ADF.1; Tue, 24 May 2022 07:57:10 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4f563890f9e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 07:57:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3454.eurprd08.prod.outlook.com (2603:10a6:803:88::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 07:57:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 07:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21f9bd4d-db37-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Rv8IqnQFB4cQPQZByAlCIMpXbMWBaECc5VVPRoNfdggsqdcz1ay5JrZfu9EkkxW7xE9TRDyljI/zrLh2bosq2kd4lCJhEZgHsBVYMTqUb7VgPpysGQWx/xuzJCawfiovNk9iw6kkllHpxs0jhQB3lr7KSnIUw161YemdqqRK9dHfdhskrGpuBDWwMADnRjfbZK2n+oUWU0M5QO+kkfw8LWlB53UaO6WAnn2X9fz/E4V+6PB5pa0H1ei7PHcvltvcJsWXXYiEpJ6rySyVrXhsqAsZPGbZ6rSS+NRGdeLl+ZHwHUedzFg8yX3reAndP0tHIrenLr29qxVbliJ98BKgtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0qOPSP/92e9WvU4SB1dIpIgF+8Pln2gu2b2iLIzsRc=; b=Sdw/LTMWWS1L6TTowA934KiwFuXApBlTwdi3crfI9BhpJYe6ks8qVJRaRpMPlXmGk59TPODlUmtrAM4zIPCxIBb7Kqu9F++p7822YTyOAL5ObsRvQm1jKRwR/jLVZa4/VXlJsz7DsomoHkbQXEGLKx4Cq7MGA2QInX8mfc3F8kmhQwAcFp4y4IXmOqAL8LPuUZPeHOQiPjO4sykiJvmkIY6Nz17ihrVpFhCZs+3GW3AYFeBJ5SAAKdfi4uTPKaIM9vR2XLXpSVFNib8+ymOLIAhwF3ZUozIITfMcevwPfIlpLZwN/squmzcacMHa91teJBQE39DJUHBu8SpQWxmoWA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W0qOPSP/92e9WvU4SB1dIpIgF+8Pln2gu2b2iLIzsRc=; b=TlTS3vpRDiYXbBJo6fBs1xAbg4Xb+CwjzXKRRTcZXpIX0i+bgzcjxFjMZZkzjVaAvjrLqrIGx/wLDreEV6LVsCeJvLYIh5omdFXDywfFe88PGSKxBCE5zO/DMMWRZHOmFK7GQbXvuNVY1jJ9ibdaVF6liq0OArj1FaSKGWcKXk4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 927ff6147aa514fa X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TkM5yv0S+1TT25tp/ADlXE1unjN611043EgnSM0KhABBsjB4bLn8RFHdlz+D12L/iR4IJfjYLKTUfyKw1fDoNHH1Bte8LmEgvOiH552iSo+5JS3z36D/Zpv1/cBFgtwQbpgPZ7Z5xBQHVCrf55vbscUI4DOgXT+ScAdeEVpH1L3ej1Z+9fOgQFW08BeNt1w3KX7wxGjiqn3ltas5pa1ycAS0BVDVvK1h8vRsk4JEHz5oet0pHD0ETxx3pXX9DK5KwbvYWgPuFy72IjZSPOGMDpdpPVhStui53IXalGYbKAyau0nh/c9BwHZ3eZc0Nb6VdsO3sQSTiebH2E8Z4yXXfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0qOPSP/92e9WvU4SB1dIpIgF+8Pln2gu2b2iLIzsRc=; b=Tr0CMC2AUSd3/MLMD+bBETXQeDX1igQRLMgFrLzCTPgsuqI+RBMwhxngsVbQOh1kbuoo03l1u2TxV7s1fGuyuFdZI5lbvOirFAZdHJOB39YFSpEoEau04by8D0WdBcyU/XQBF3KMo8NcAdgyH7HV5hOaUzch01Iyk4ntFfM8Pqf1JBJkBq04JlZVzEPVEUG9vy0Kva/lFvWBiDgqKLvsA22rQMo5U2ACuQiasLZs8qC3YnO9xdizd6jusjja9swyaAx7UG++k7Hq0A6yNeusWSr6pvBGBqyR6g8NGbNkF12wz/2em+p+bgjm90B/uIb329xn4Rtvq0naaslXG24Rkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W0qOPSP/92e9WvU4SB1dIpIgF+8Pln2gu2b2iLIzsRc=; b=TlTS3vpRDiYXbBJo6fBs1xAbg4Xb+CwjzXKRRTcZXpIX0i+bgzcjxFjMZZkzjVaAvjrLqrIGx/wLDreEV6LVsCeJvLYIh5omdFXDywfFe88PGSKxBCE5zO/DMMWRZHOmFK7GQbXvuNVY1jJ9ibdaVF6liq0OArj1FaSKGWcKXk4= From: Bertrand Marquis To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator Thread-Topic: [PATCH 13/16] xen/arm32: setup: Move out the code to populate the boot allocator Thread-Index: AQHYbEM1B6bUo5tusEemzGRhWNTewq0trzOA Date: Tue, 24 May 2022 07:57:07 +0000 Message-ID: <30311664-70B5-49BE-B893-9BBF38B5A48E@arm.com> References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-14-julien@xen.org> In-Reply-To: <20220520120937.28925-14-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fb34ba86-c391-470a-b8bf-08da3d5b052b x-ms-traffictypediagnostic: VI1PR08MB3454:EE_|DBAEUR03FT039:EE_|VI1PR08MB5502:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9A9WiKTNXT5dQj/kkmUzVvnWOs3sywSOKXXtpH6/ceHtIdFfB/+C4BGQbaF452BVVsZXRGa8G1HqigWNBsJSVMsLLdLzYFSlyYxhrhiMosCzVJ+7TGcTdOwOzXhfuj36HEt2Tx2Ico9gj+gbMd3kQIoWHu52Vv5zLPJF9+ysINU1baAZoDMVep2pLvwqy26kcrDuM+nlb28Rzez3M//DxiOXOydOozFdJIMRzeZvapoQSEuMmjc0PV4Rdbe1OA4yFLnL88A3lcynjeIEyB0Xc7SzPpfNaeLkZNvBHMH00bzhjtYRGqTLp8wFbsO3QT61me6MS2/dzzPJyTbhOIuMvqdoO3FrzoGLTr88JAL/vDlifvl8N8iGnexboZS0IMU1viFQEcR5f24fqXsP8RkTMlvspwIcahtx0QjtmjGoDdyv1WIKM5Jy5hevG5uRN6hi+KNHV9o1fSM8w+Ay/fvxARHymxRUGjQKLO/CijBNLo5su8j19GhKYaQd7n3l4MguHSFjFCRRiC4pev3Ct3yC9kW2MGxjpjUjkMmCYp2qarrQle9NGIBchAudMycZ4Jtd+ArMb6hV8q3A9FpwcE18MRrlJOfCK2bGTSmzwa0odsWsv+IjaCNh/RSrP2r++HSpq+Ev9grnf0g12+0S9euQHkInIxveCx4XL3RHT9tz3EFRIxAdrob6M8Ov+LqxB0tv2bvPL1ctlo0al9h+o58hZHbYKICGcmcJv7TqGAXgPdc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(2616005)(38100700002)(186003)(83380400001)(6506007)(53546011)(5660300002)(6512007)(86362001)(2906002)(26005)(508600001)(33656002)(6486002)(54906003)(6916009)(8676002)(316002)(64756008)(66556008)(66446008)(66476007)(91956017)(76116006)(66946007)(122000001)(36756003)(38070700005)(71200400001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <446603C0117B38459A1C1A37C81A46B8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3454 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9d571ae9-90d0-44f8-c939-08da3d5b0012 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3mGNHXvDMO6O4K/I5ImwwLFzlpNrMl6ODEloEm5lqvKfMWfYH4IFkWcbh0Wkzv0NEnbvP0/H3BVguSYh6ks6TiuD4YPoCvEBJsbaN4U1pjOUZ6qsZsY+MDQVuOHzgz4S3Fm0DvgXwFcJHi21RkIf4mf5//kGKYSE0H5qc7BUEflLMQM8rjDveprjRhq4onjnbvbrPZVSc5aI1JqX+dlSXm/Wsoi1C2yRr4E6hMyUyckW9AO/O0iy7O/dgp11At57Yixu25gjm5Iz/uhoj73JWQYP4tuPwpKDNhoiJznyImyvLxGy17HnxgOg1kRG61fYREn9r8DXZlq+S5tBGL0z6TRUzjzIzDAmioNPhYbM/wgP9RagGp1kWINc3Qi+E74VXb7pKH8+0TXD6+EiwJbOj8HpmeOtVsU8S6pZTQbiFs4DXunnilLH77umra2ApLbH/YFWfu8SRFKXGBAVqLLrKT8Ovu6+b3BMK/HS+x/KlSSN2fURWGzsY7Ppdlupep5/CxNbiDV11HeDEROKZmhv4DfdX1eCvGluvihPkASSRg6yVkSmsj5wEMPS+yzCIe2/6pEaLtK2juAvjCl17iKjg/CxPhraxtH8FJb0yIx3SksPrbhDK2pGjL27v1BhJftIEqolqwoI3tN5nzz0yXSrblq8ZWj4ORc+ykeoCfWzS/DzjwoihNK3ICnRCKmvdOu2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(26005)(2616005)(107886003)(40460700003)(83380400001)(81166007)(6506007)(53546011)(33656002)(2906002)(6512007)(5660300002)(82310400005)(8936002)(36756003)(54906003)(6862004)(70206006)(4326008)(70586007)(8676002)(356005)(86362001)(186003)(508600001)(47076005)(6486002)(316002)(36860700001)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 07:57:16.4259 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb34ba86-c391-470a-b8bf-08da3d5b052b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5502 Hi Julien, > On 20 May 2022, at 13:09, Julien Grall wrote: >=20 > From: Julien Grall >=20 > In a follow-up patch, we will want to populate the boot allocator > separately for arm64. The code will end up to be very similar to the one > on arm32. So move out the code in a new helper populate_boot_allocator(). >=20 > For now the code is still protected by CONFIG_ARM_32 to avoid any build > failure on arm64. >=20 > Take the opportunity to replace mfn_add(xen_mfn_start, xenheap_pages) wit= h > xenheap_mfn_end as they are equivalent. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --- >=20 > Changes in v4: > - Patch added > --- > xen/arch/arm/setup.c | 90 +++++++++++++++++++++++++------------------- > 1 file changed, 51 insertions(+), 39 deletions(-) >=20 > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed48a..3d5a2283d4ef 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -637,10 +637,58 @@ static void __init init_staticmem_pages(void) > } >=20 > #ifdef CONFIG_ARM_32 > +/* > + * Populate the boot allocator. All the RAM but the following regions > + * will be added: > + * - Modules (e.g., Xen, Kernel) > + * - Reserved regions > + * - Xenheap > + */ > +static void __init populate_boot_allocator(void) > +{ > + unsigned int i; > + const struct meminfo *banks =3D &bootinfo.mem; > + > + for ( i =3D 0; i < banks->nr_banks; i++ ) > + { > + const struct membank *bank =3D &banks->bank[i]; > + paddr_t bank_end =3D bank->start + bank->size; > + paddr_t s, e; > + > + s =3D bank->start; > + while ( s < bank_end ) > + { > + paddr_t n =3D bank_end; > + > + e =3D next_module(s, &n); > + > + if ( e =3D=3D ~(paddr_t)0 ) > + e =3D n =3D bank_end; > + > + /* > + * Module in a RAM bank other than the one which we are > + * not dealing with here. > + */ > + if ( e > bank_end ) > + e =3D bank_end; > + > + /* Avoid the xenheap */ > + if ( s < mfn_to_maddr(xenheap_mfn_end) && > + mfn_to_maddr(xenheap_mfn_start) < e ) > + { > + e =3D mfn_to_maddr(xenheap_mfn_start); > + n =3D mfn_to_maddr(xenheap_mfn_end); > + } > + > + fw_unreserved_regions(s, e, init_boot_pages, 0); > + s =3D n; > + } > + } > +} > + > static void __init setup_mm(void) > { > - paddr_t ram_start, ram_end, ram_size; > - paddr_t s, e; > + paddr_t ram_start, ram_end, ram_size, e; > unsigned long ram_pages; > unsigned long heap_pages, xenheap_pages, domheap_pages; > int i; > @@ -718,43 +766,7 @@ static void __init setup_mm(void) > setup_xenheap_mappings((e >> PAGE_SHIFT) - xenheap_pages, xenheap_pag= es); >=20 > /* Add non-xenheap memory */ > - for ( i =3D 0; i < bootinfo.mem.nr_banks; i++ ) > - { > - paddr_t bank_start =3D bootinfo.mem.bank[i].start; > - paddr_t bank_end =3D bank_start + bootinfo.mem.bank[i].size; > - > - s =3D bank_start; > - while ( s < bank_end ) > - { > - paddr_t n =3D bank_end; > - > - e =3D next_module(s, &n); > - > - if ( e =3D=3D ~(paddr_t)0 ) > - { > - e =3D n =3D ram_end; > - } > - > - /* > - * Module in a RAM bank other than the one which we are > - * not dealing with here. > - */ > - if ( e > bank_end ) > - e =3D bank_end; > - > - /* Avoid the xenheap */ > - if ( s < mfn_to_maddr(mfn_add(xenheap_mfn_start, xenheap_pag= es)) > - && mfn_to_maddr(xenheap_mfn_start) < e ) > - { > - e =3D mfn_to_maddr(xenheap_mfn_start); > - n =3D mfn_to_maddr(mfn_add(xenheap_mfn_start, xenheap_pa= ges)); > - } > - > - fw_unreserved_regions(s, e, init_boot_pages, 0); > - > - s =3D n; > - } > - } > + populate_boot_allocator(); >=20 > /* Frame table covers all of RAM region, including holes */ > setup_frametable_mappings(ram_start, ram_end); > --=20 > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Tue May 24 08:01:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:01:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336382.560680 (Exim 4.92) (envelope-from ) id 1ntPTi-0007FG-6Z; Tue, 24 May 2022 08:01:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336382.560680; Tue, 24 May 2022 08:01:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPTi-0007F9-1w; Tue, 24 May 2022 08:01:18 +0000 Received: by outflank-mailman (input) for mailman id 336382; Tue, 24 May 2022 08:01:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPTf-0007Ex-UP for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:01:15 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aef0a2cf-db37-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 10:01:14 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 15D07219F1; Tue, 24 May 2022 08:01:14 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8ADCF2C141; Tue, 24 May 2022 08:01:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aef0a2cf-db37-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653379274; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YfQDkbqSOT+1qjQjuAj/jCMAhUotd54M/3ml94s/xOo=; b=PgXddxLSPksORjL/S6Twz65MXnqRLkhNWsZMkeMCJl5txCWJEZdmdegZfTAX/9coTEEbNM 8MuciDtA/meSONuDDeUgJuaMT6sJm3SP6OoP4PPs2H8u+yjTfPOAegS/VmQ3g6ca5OFCQB kRtlLyoJ6CAvfuEa9KvE4DbHA1Jh8JI= Date: Tue, 24 May 2022 10:01:12 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Baoquan He , "michael Kelley (LINUX)" , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <20220519234502.GA194232@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 2022-05-20 08:23:33, Guilherme G. Piccoli wrote: > On 19/05/2022 20:45, Baoquan He wrote: > > [...] > >> I really appreciate the summary skill you have, to convert complex > >> problems in very clear and concise ideas. Thanks for that, very useful! > >> I agree with what was summarized above. > > > > I want to say the similar words to Petr's reviewing comment when I went > > through the patches and traced each reviewing sub-thread to try to > > catch up. Petr has reivewed this series so carefully and given many > > comments I want to ack immediately. > > > > I agree with most of the suggestions from Petr to this patch, except of > > one tiny concern, please see below inline comment. > > Hi Baoquan, thanks! I'm glad you're also reviewing that =) > > > > [...] > > > > I like the proposed skeleton of panic() and code style suggested by > > Petr very much. About panic_prefer_crash_dump which might need be added, > > I hope it has a default value true. This makes crash_dump execute at > > first by default just as before, unless people specify > > panic_prefer_crash_dump=0|n|off to disable it. Otherwise we need add > > panic_prefer_crash_dump=1 in kernel and in our distros to enable kdump, > > this is inconsistent with the old behaviour. > > I'd like to understand better why the crash_kexec() must always be the > first thing in your use case. If we keep that behavior, we'll see all > sorts of workarounds - see the last patches of this series, Hyper-V and > PowerPC folks hardcoded "crash_kexec_post_notifiers" in order to force > execution of their relevant notifiers (like the vmbus disconnect, > specially in arm64 that has no custom machine_crash_shutdown, or the > fadump case in ppc). This led to more risk in kdump. > > The thing is: with the notifiers' split, we tried to keep only the most > relevant/necessary stuff in this first list, things that ultimately > should improve kdump reliability or if not, at least not break it. My > feeling is that, with this series, we should change the idea/concept > that kdump must run first nevertheless, not matter what. We're here > trying to accommodate the antagonistic goals of hypervisors that need > some clean-up (even for kdump to work) VS. kdump users, that wish a > "pristine" system reboot ASAP after the crash. Good question. I wonder if Baoquan knows about problems caused by the particular notifiers that will end up in the hypervisor list. Note that there will be some shuffles and the list will be slightly different in V2. Anyway, I see four possible solutions: 1. The most conservative approach is to keep the current behavior and call kdump first by default. 2. A medium conservative approach to change the default default behavior and call hypervisor and eventually the info notifiers before kdump. There still would be the possibility to call kdump first by the command line parameter. 3. Remove the possibility to call kdump first completely. It would assume that all the notifiers in the info list are super safe or that they make kdump actually more safe. 4. Create one more notifier list for operations that always should be called before crash_dump. Regarding the extra notifier list (4th solution). It is not clear to me whether it would be always called even before hypervisor list or when kdump is not enabled. We must not over-engineer it. 2nd proposal looks like a good compromise. But maybe we could do this change few releases later. The notifiers split is a big change on its own. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 24 08:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336390.560691 (Exim 4.92) (envelope-from ) id 1ntPXD-0007wC-M9; Tue, 24 May 2022 08:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336390.560691; Tue, 24 May 2022 08:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPXD-0007w5-Ix; Tue, 24 May 2022 08:04:55 +0000 Received: by outflank-mailman (input) for mailman id 336390; Tue, 24 May 2022 08:04:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPXC-0007vs-CQ for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:04:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30d95257-db38-11ec-837e-e5687231ffcc; Tue, 24 May 2022 10:04:52 +0200 (CEST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C6A001F8B8; Tue, 24 May 2022 08:04:52 +0000 (UTC) Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A47272C141; Tue, 24 May 2022 08:04:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30d95257-db38-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653379492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+HrTVIvXJDgrzNQFl8Mhx0wGW/HWHO1IHY/NT0Ch0wc=; b=cmANZ9kaIvAGzRMHaeCxB0LLBkrlXozlKGlr2MQNHSGuBkVg9GZ4ULppK80AYEMbn3sHQ3 SRCkpAxtJlotC4dIBTUf4LWabWRfn+CV2iXTLVzyyBDKp8B9onijAa8QBBUxy4R2DAxIkT C3aqZP5pWFL7HdTOLlEm50sKDepVyxc= Date: Tue, 24 May 2022 10:04:51 +0200 From: Petr Mladek To: "Guilherme G. Piccoli" Cc: Scott Branden , Sebastian Reichel , Florian Fainelli , Desmond yan , David Gow , Evan Green , Julius Werner , bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, akpm@linux-foundation.org, bhe@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Alexander Gordeev , Andrea Parri , Ard Biesheuvel , Benjamin Herrenschmidt , Brian Norris , Christian Borntraeger , Christophe JAILLET , "David S. Miller" , Dexuan Cui , Doug Berger , Haiyang Zhang , Hari Bathini , Heiko Carstens , Justin Chen , "K. Y. Srinivasan" , Lee Jones , Markus Mayer , Michael Ellerman , Mihai Carabas , Nicholas Piggin , Paul Mackerras , Pavel Machek , Shile Zhang , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Tianyu Lan , Vasily Gorbik , Wang ShaoBo , Wei Liu , zhenwei pi Subject: Re: [PATCH 19/30] panic: Add the panic hypervisor notifier list Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-20-gpiccoli@igalia.com> <81878a67-21f1-fee8-1add-f381bc8b05df@broadcom.com> <0fac8c71-6f18-d15c-23f5-075dbc45f3f9@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0fac8c71-6f18-d15c-23f5-075dbc45f3f9@igalia.com> On Mon 2022-05-23 11:56:12, Guilherme G. Piccoli wrote: > On 19/05/2022 16:20, Scott Branden wrote: > > [...] > >> Hi Scott / Desmond, thanks for the detailed answer! Is this adapter > >> designed to run in x86 only or you have other architectures' use cases? > > The adapter may be used in any PCIe design that supports DMA. > > So it may be possible to run in arm64 servers. > >> > >> [...] > >> With that said, and given this is a lightweight notifier that ideally > >> should run ASAP, I'd keep this one in the hypervisor list. We can > >> "adjust" the semantic of this list to include lightweight notifiers that > >> reset adapters. > > Sounds the best to keep system operating as tested today. > >> > >> With that said, Petr has a point - not always such list is going to be > >> called before kdump. So, that makes me think in another idea: what if we > >> have another list, but not on panic path, but instead in the custom > >> crash_shutdown()? Drivers could add callbacks there that must execute > >> before kexec/kdump, no matter what. > > It may be beneficial for some other drivers but for our use we would > > then need to register for the panic path and the crash_shutdown path. > > We notify the VK card for 2 purposes: one to stop DMA so memory stop > > changing during a kdump. And also to get the card into a good state so > > resets happen cleanly. > > Thanks Scott! With that, I guess it's really better to keep this > notifier in this hypervisor/early list - I'm planning to do that for V2. > Unless Petr or somebody has strong feelings against that, of course. I am fine with it because we do not have a better solution at the moment. It might be a good candidate for the 5th notifier list mentioned in the thread https://lore.kernel.org/r/YoyQyHHfhIIXSX0U@alley . But I am not sure if the 5th list is worth the complexity. Best Regards, Petr From xen-devel-bounces@lists.xenproject.org Tue May 24 08:05:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336397.560702 (Exim 4.92) (envelope-from ) id 1ntPY4-0008Vs-Vl; Tue, 24 May 2022 08:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336397.560702; Tue, 24 May 2022 08:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPY4-0008Vj-T3; Tue, 24 May 2022 08:05:48 +0000 Received: by outflank-mailman (input) for mailman id 336397; Tue, 24 May 2022 08:05:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPY3-0007vs-Fc for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:05:47 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on060f.outbound.protection.outlook.com [2a01:111:f400:fe08::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50dc81b9-db38-11ec-837e-e5687231ffcc; Tue, 24 May 2022 10:05:46 +0200 (CEST) Received: from AM5PR0402CA0007.eurprd04.prod.outlook.com (2603:10a6:203:90::17) by DB4PR08MB8029.eurprd08.prod.outlook.com (2603:10a6:10:38b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Tue, 24 May 2022 08:05:45 +0000 Received: from VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::df) by AM5PR0402CA0007.outlook.office365.com (2603:10a6:203:90::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23 via Frontend Transport; Tue, 24 May 2022 08:05:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT034.mail.protection.outlook.com (10.152.18.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:05:44 +0000 Received: ("Tessian outbound 42cead292588:v119"); Tue, 24 May 2022 08:05:44 +0000 Received: from 0f4f214dbc1c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A84BC0EC-5C27-4073-8557-7B5A8FA3DD0D.1; Tue, 24 May 2022 08:05:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f4f214dbc1c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 08:05:36 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VE1PR08MB5871.eurprd08.prod.outlook.com (2603:10a6:800:1ae::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Tue, 24 May 2022 08:05:34 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 08:05:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50dc81b9-db38-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VJD5RoN2m1Pkvm/9pS03WbM+PHY7H8gbxfWmUgLzBJLJSG3JzGgqmlPu/bP48VEBEPyLH/x3Je09vqOHX3TTt6NELlKd2fTwG+KQ6QHb/3oNPWaFLY4s380rPY0ZbrzM+3YBmFew3IOj+VF3K4gJn3keS1/9JnweDfVwIUGN3SBRx16mJSJk8VzLgYxknPkcFUMv1ieFDFG3EULhAM1vrJZwCseDTyLuFhqol7+5jw9vCWEOplHUQIqsPyr1SxpyxR2Fp6esMHcQeFE2Yl+1F66tZ035jlOxQX9jPXhmzLZIJXrTZIkl81FprWuBe64ytO8002gtzeZffqUta4PAwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0V/0EKDU4QbvIsakOyVn8J9zQAXeEYdpiceoXmiTHA=; b=nf/pJ8jeQgQv1uD7HP/eGqfIlWa6QkeCCV60NGBftJRL8GOx9m0WMnKiJu9CCcmqnxF6fjcAKcaOViB3ACL7sVlK80vPmQDyM91nol9e0PRR9x+D4cxwLRuG5znmnFWE49sbNGkCwQrnvq2WM0Ukx5+XAPdlr9LGUC+muos5ZfIZvV0PinIaRuW1YH3Oz9k9FJ7dOZI2GHh5S8dFCLcoSPnCMdhYR/ejzrL+Dyq25vEVf78Kv1z7XHBiXb+HDRJJ3pU6FmBKGnhhbbJ+iaRWeBzURsyQ4pSvNhem0IJOmT4JJWwuLsQdMrNR039+7vJCZJe/KsxKKEzL1s28wt9VXA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0V/0EKDU4QbvIsakOyVn8J9zQAXeEYdpiceoXmiTHA=; b=EKKJ2fMEQJpmh3yoDQz+i0+xWE4DCsqvaR0JWXsFUmGbCG8WmvVfZfqyVp85nX2fGe080uGnSD7Yp3+JSKUt27Tcg1dLfZuVzgn9YQCWlwWtIco88w6lMwtRsK0zgvUq2t4xtAe3FPTIfieCvxmibyFUxxgu6fX8zhQUNHKhGT0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dbda18aa1b180e9c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+54EepMqXWJ0I90wBcuEXj7cMsStKMaWQxVukDO05FRxhLJKKyJ7GUD0i89MMSVhIFdIDscA70QPys9QrgLR9EBYY02zJBtghR4WA0hTvuaViOo/47JjeMpm/qH8AvUY0VMPQqfhnvUAwScDtsrG30IkEf3GMnSdDYeLJVwse7MeS9rMeasMiPnXzy58/515+ERCj+MNmoxNAUO15qAPKPCOwiyKKKDelHWOWwzru3qWKDXxphCayL0YPhwhQDxtuOoOT5tho6JmgY9gniXL/kCli8cnfYomOlSHd3wnsdxdshHnFCKWA4qWXOV34QgLq6y1xNFlCvPeFCfrTzENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0V/0EKDU4QbvIsakOyVn8J9zQAXeEYdpiceoXmiTHA=; b=U0B+mw/84B61kkx+PSb2LzYtEMo2UsDHELGUN7irUj5VxFrgF2mitJFU7VWSEr9r00azfE08v8C8Fyx1YPF+OAS8fo2/l+YitlxIKMZemwqo9syOj5lALhCYz2TjCEgeKUleQVbR/gqelMETnutuR0n+IJHvAEYQ2u9ZlolpCs3yZTOhyY1gsPI2FbvNkk0azYAkkarn7HWcNMkESMuCqSikufNCVDFie3OA3ZJW1FAXKq7DagV8m3kgreDE+I/lzNTbLCjB2JmAWo3Ny5ikrEDKmzuzjahOmSNP2Z9irGVPUcx/5Hzywia8JBKeo9w7ZSWbAP5xGXXb7FcSUOPKQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0V/0EKDU4QbvIsakOyVn8J9zQAXeEYdpiceoXmiTHA=; b=EKKJ2fMEQJpmh3yoDQz+i0+xWE4DCsqvaR0JWXsFUmGbCG8WmvVfZfqyVp85nX2fGe080uGnSD7Yp3+JSKUt27Tcg1dLfZuVzgn9YQCWlwWtIco88w6lMwtRsK0zgvUq2t4xtAe3FPTIfieCvxmibyFUxxgu6fX8zhQUNHKhGT0= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYbt5OQ+9i9MqGEE+kzOfwd/8WE60trFiA Date: Tue, 24 May 2022 08:05:34 +0000 Message-ID: References: <20220523194953.70636-1-julien@xen.org> In-Reply-To: <20220523194953.70636-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: bbcdfd4e-3a36-41da-210d-08da3d5c3407 x-ms-traffictypediagnostic: VE1PR08MB5871:EE_|VE1EUR03FT034:EE_|DB4PR08MB8029:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8F7BNQtNyPz7EsacUQhZT2nyq+BcUSFV4h3PE1mkSUZP8uzUfcSij539YYjPK9KOPZ1TJDaTSUwjc/WFs9fDY1dw1PYeXllDwLT3pSP5GqlO+WLHQK9JebQ/vdGgZxEnXxGTUFq/4FPQZbr/bDFFX1r5E6XtqIHyEJedufhrW72ZtzvbaDEsRdmmy8n4Q2pX7UAixRvrvu1uDZaUWGf+yNC25eyWKRM2osZyeB1EKHOUToFvnNe+jiJSROLGYWDniBCei6o569mVMp6gE+luStiyZu8XAsr3+0wH7U3BgDu1+onxqmDXRTQA6jRfo3VpNyW6P02BrKBTiWGdcNiHzeIYe0EqHk52ZfuTlaeOTP6ycsKAenARmFduXIG8g539z6eD/Yz2H2b5uT9BSTjdfa+Gzf1yOPmTCVqu6srUu0OSLc0Ox6dIUbD6qWF5PAYrQStuxuS7vPzqP8IXIO8x0aL7AAWRiV26iXjkIJjiPRNjQr25rcJV5yaDqJiZaq30DFMX0xGh1G/eko/W7iX4lITxpmf8P9KRRWmRYJh9h5kLUWyvtAfjTDsNtmOp+TDO5YscswFDEAyV93EzFG80kaw+l4RU36x6wdI+aRXXZoBMUR5G+xibAlymytMmBSsYrkQDtYFcfg8H5pc6l+yRICul14QpKVF+f7H/hMG1PfWk1obKw0TBY0RoZbBc1+s87W/FinA+i+WY2tMFpo00apu5/hLYUOhcforxHXH8o/xwn51OeQVVJVWES526w1jy X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66946007)(8676002)(2616005)(4326008)(38070700005)(5660300002)(33656002)(38100700002)(122000001)(2906002)(86362001)(316002)(26005)(6916009)(64756008)(91956017)(66446008)(66556008)(66476007)(36756003)(6512007)(54906003)(76116006)(83380400001)(6486002)(186003)(6506007)(8936002)(71200400001)(508600001)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5871 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a7bfc055-cc57-4af8-4c4c-08da3d5c2ddd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HJkThgCNDdxhh8SCBbKJ6m2dc48g4k7+HNm9Oa0bvuO2p9UXt8DajnquEMC8oMek20dmGkxBQNDB1GEghrlpnv35TeTiJV9Xq4Xm25q4elVasZxWwyqIVyXoP9FgxxI7fuQcULfBq/12uQYzx/u6I2g3qpVo3uBuCaAr7OlEV2rynD2GRYQX10ihS4w1barfoVrURAvRdg+sbqxtKORfD4EY/cxJKnV9EtAi7a92nV/oPdILsz8nwQIcoZP7vAoUXJQ5kxdlcIQ36zDxaLMFuqgDc8nEX6T/FCFNK5mvM85ZBwmKbFibMC+Ev3eEvy/AFuLC14AFHNl/DVlzcfBIFEjAm455frb+sPD1ud/XszOfAgrb/yhEMMPeMsED77c+99L2Wd4oEexkEN9ldvTJRqd5/ujA+w+wOXsLd/YiNivDGU2cJ3phgEDS3UsIHM7MrX/L0qKgj1YBA5n7BW3d801BXdonGQOG1QY3Ibc63l+gu8rBF3nt2lbFSKKLesE6OkUknVmKk8lK0CVbg1ZYqSgi9IzKqkgt/KbZUAU9hfb04FeQAtnHnp3uJK+E/5IN/P4r7FFT+KyN6zVANXxGMKy5Tc1xmMPoEMhfYVkXbjHRGagdS7VHb8OpYkwu1GUBcx20ZVxZrocqJ3WLC4IQ32Vj893ApM6NTh30M1v76H9Sl0TSyBwiA9ZNNi/Fo8u1 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(53546011)(2616005)(6506007)(70206006)(6862004)(107886003)(2906002)(86362001)(82310400005)(316002)(36756003)(70586007)(4326008)(8676002)(54906003)(36860700001)(356005)(5660300002)(33656002)(508600001)(26005)(6512007)(186003)(83380400001)(40460700003)(8936002)(47076005)(336012)(6486002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 08:05:44.4108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbcdfd4e-3a36-41da-210d-08da3d5c3407 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8029 Hi Julien, > On 23 May 2022, at 20:49, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, *_VIRT_END may either point to the address after the end > or the last address of the region. >=20 > The lack of consistency make quite difficult to reason with them. >=20 > Furthermore, there is a risk of overflow in the case where the address > points past to the end. I am not aware of any cases, so this is only a > latent bug. >=20 > Start to solve the problem by removing all the *_VIRT_END exclusively use= d > by the Arm code and add *_VIRT_SIZE when it is not present. >=20 > Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE > for better consistency and use _AT(vaddr_t, ). Thanks to have remembered this one :-) >=20 > Signed-off-by: Julien Grall >=20 > ---- >=20 > I noticed that a few functions in Xen expect [start, end[. This is risky > as we may end up with end < start if the region is defined right at the > top of the address space. >=20 > I haven't yet tackle this issue. But I would at least like to get rid > of *_VIRT_END. > --- > xen/arch/arm/include/asm/config.h | 18 ++++++++---------- > xen/arch/arm/livepatch.c | 2 +- > xen/arch/arm/mm.c | 13 ++++++++----- > 3 files changed, 17 insertions(+), 16 deletions(-) >=20 > diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm= /config.h > index 3e2a55a91058..66db618b34e7 100644 > --- a/xen/arch/arm/include/asm/config.h > +++ b/xen/arch/arm/include/asm/config.h > @@ -111,12 +111,11 @@ > #define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) >=20 > #define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) > -#define BOOT_FDT_SLOT_SIZE MB(4) > -#define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE= ) > +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) >=20 > #ifdef CONFIG_LIVEPATCH > #define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) > -#define LIVEPATCH_VMAP_END (LIVEPATCH_VMAP_START + MB(2)) > +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) > #endif >=20 > #define HYPERVISOR_VIRT_START XEN_VIRT_START > @@ -132,18 +131,18 @@ > #define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE -= 1) >=20 > #define VMAP_VIRT_START _AT(vaddr_t,0x10000000) > +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) This looks a bit odd, any reason not to use MB(768) ? If not then there might be something worse explaining with a comment here. >=20 > #define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) > -#define XENHEAP_VIRT_END _AT(vaddr_t,0x7fffffff) > -#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) > -#define DOMHEAP_VIRT_END _AT(vaddr_t,0xffffffff) > +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) >=20 > -#define VMAP_VIRT_END XENHEAP_VIRT_START > +#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) > +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) >=20 > #define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ >=20 > /* Number of domheap pagetable pages required at the second level (2MB ma= ppings) */ > -#define DOMHEAP_SECOND_PAGES ((DOMHEAP_VIRT_END - DOMHEAP_VIRT_START + 1= ) >> FIRST_SHIFT) > +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) >=20 > #else /* ARM_64 */ >=20 > @@ -152,12 +151,11 @@ > #define SLOT0_ENTRY_SIZE SLOT0(1) >=20 > #define VMAP_VIRT_START GB(1) > -#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1)) > +#define VMAP_VIRT_SIZE GB(1) >=20 > #define FRAMETABLE_VIRT_START GB(32) > #define FRAMETABLE_SIZE GB(32) > #define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) > -#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE = - 1) >=20 > #define DIRECTMAP_VIRT_START SLOT0(256) > #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) > diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c > index 75e8adcfd6a1..57abc746e60b 100644 > --- a/xen/arch/arm/livepatch.c > +++ b/xen/arch/arm/livepatch.c > @@ -175,7 +175,7 @@ void __init arch_livepatch_init(void) > void *start, *end; >=20 > start =3D (void *)LIVEPATCH_VMAP_START; > - end =3D (void *)LIVEPATCH_VMAP_END; > + end =3D start + LIVEPATCH_VMAP_SIZE; >=20 > vm_init_type(VMAP_XEN, start, end); >=20 > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index be37176a4725..0607c65f95cd 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -128,9 +128,11 @@ static DEFINE_PAGE_TABLE(xen_first); > /* xen_pgtable =3D=3D root of the trie (zeroeth level on 64-bit, first on= 32-bit) */ > static DEFINE_PER_CPU(lpae_t *, xen_pgtable); > #define THIS_CPU_PGTABLE this_cpu(xen_pgtable) > -/* xen_dommap =3D=3D pages used by map_domain_page, these pages contain > +/* > + * xen_dommap =3D=3D pages used by map_domain_page, these pages contain > * the second level pagetables which map the domheap region > - * DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */ > + * starting at DOMHEAP_VIRT_START in 2MB chunks. > + */ Please just mention that you also fixed a comment coding style in the commi= t message. > static DEFINE_PER_CPU(lpae_t *, xen_dommap); > /* Root of the trie for cpu0, other CPU's PTs are dynamically allocated *= / > static DEFINE_PAGE_TABLE(cpu0_pgtable); > @@ -476,7 +478,7 @@ mfn_t domain_page_map_to_mfn(const void *ptr) > int slot =3D (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; > unsigned long offset =3D (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; >=20 > - if ( va >=3D VMAP_VIRT_START && va < VMAP_VIRT_END ) > + if ( (va >=3D VMAP_VIRT_START) && ((VMAP_VIRT_START - va) < VMAP_VIR= T_SIZE) ) > return virt_to_mfn(va); >=20 > ASSERT(slot >=3D 0 && slot < DOMHEAP_ENTRIES); > @@ -570,7 +572,8 @@ void __init remove_early_mappings(void) > int rc; >=20 > /* destroy the _PAGE_BLOCK mapping */ > - rc =3D modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END, > + rc =3D modify_xen_mappings(BOOT_FDT_VIRT_START, > + BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, > _PAGE_BLOCK); > BUG_ON(rc); > } > @@ -850,7 +853,7 @@ void __init setup_frametable_mappings(paddr_t ps, pad= dr_t pe) >=20 > void *__init arch_vmap_virt_end(void) > { > - return (void *)VMAP_VIRT_END; > + return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); > } >=20 > /* > --=20 > 2.32.0 >=20 Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 24 08:07:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:07:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336405.560713 (Exim 4.92) (envelope-from ) id 1ntPZR-0000jd-EB; Tue, 24 May 2022 08:07:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336405.560713; Tue, 24 May 2022 08:07:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPZR-0000jW-BN; Tue, 24 May 2022 08:07:13 +0000 Received: by outflank-mailman (input) for mailman id 336405; Tue, 24 May 2022 08:07:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPZP-0000jM-N4 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:07:11 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1b::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 82f2325a-db38-11ec-837e-e5687231ffcc; Tue, 24 May 2022 10:07:10 +0200 (CEST) Received: from DB6PR07CA0190.eurprd07.prod.outlook.com (2603:10a6:6:42::20) by DBAPR08MB5717.eurprd08.prod.outlook.com (2603:10a6:10:1ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 08:07:07 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::f8) by DB6PR07CA0190.outlook.office365.com (2603:10a6:6:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.7 via Frontend Transport; Tue, 24 May 2022 08:07:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:07:07 +0000 Received: ("Tessian outbound 42cead292588:v119"); Tue, 24 May 2022 08:07:06 +0000 Received: from a0fafbd3df2f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 405CC274-4556-4DB9-BADF-75250D376570.1; Tue, 24 May 2022 08:07:01 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a0fafbd3df2f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 08:07:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3983.eurprd08.prod.outlook.com (2603:10a6:803:e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Tue, 24 May 2022 08:06:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 08:06:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82f2325a-db38-11ec-837e-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=U4I5YGLOIQobneJi2EBqLt4JqBJiay+bt4HNkRmP+HBEldomUozP/Su7/girURBFYozjhjraZnVwwLP9scaV0WKWJjto++6tZz9BXBUjxPX/Blt6th1/HnVU1sf/+WOXHBkenKvoApFUklJQvpVEHbzMb0C7YgzAnItXUe3oemGiQJxwTBSRry+d0++9J2VjEmW4AbYPAmtN0jH8aARCOQMN04usFZInbgXQTdpVdsPz/oKndRrG0YiI1eOduGRlbhl6lPDmlb+3s++jDW6B8G5EX8FdpYmnQcnIQHYBrP6/YNf80yMZsYyrxBg1P0EdMt9nwLules3hvPT8QgypPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yJrjdjqvnYyzaOCe7H4G7tGSWPjbTwijcGopXXKvIQ=; b=TUS5L1u04WWa7m3SrRekJE+BtIEEpXs8aygv4l48lLIA3GJK87BK0RNfm+/sSwJEVeYFd/n63wv4PL8hAu7HoYg62l3jK9ZM0zXxxtZONzLCFCzsE9xnXey83p/rah7V6SZxjULkOUL/tZQov0InwqpgBXJ/x0sEu5eE0WtR1w0oBzr25e/dqjnm/HNUONqHIdcTr651zBqcg1OJJj17YD822V/eMibhQQy2VpwxCYLVb1Cvm2ySTw7ZuRzp94+ljXGrDLtQjLc51phsVjdhzL2CA8gvOzaiaymUdNAK5TDqOhYlXXSBJnD0ST+JgL7rd+i9JQ20GuyiRKmWYnSCgg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/yJrjdjqvnYyzaOCe7H4G7tGSWPjbTwijcGopXXKvIQ=; b=YazUQYlmI1mnysB766znBtf779QFR1ab6wKo9x8zbqrs6VXK/yhBT3uifhi6uXVmMOPtncDE7/nveA0CqXHFYezWsHY2IJZI3e8w+Hp0McTCfoBBn35ZYY60gwFiWIOMOT7yJfBh6H0sdm5mlJi2Gis/qQWK/D9XhMozxB9xg28= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 93d21a852ea32afb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k58c62vdc6QX9y9KqIN17o6EX14dMnY2w+NjSS2rP2ysPXzSYWsi/BJkQFn/RdtXcXEPfgcWMaEHGBwDtMGImk/So5sbfc2gXnFIOn8RIAG6DUOQMkM4vOf8X/f0DzrPPXLTF+n8KRbxaw7xv9foLetXyh8oa+rkJAOJQkxKdkfI2r6qyzdCmKnk8ShPr/yNGE+7scF+ttOubpzVlVX5wjJLJzip4QvCjYoeeUfUqM2D0WU4jP0y8yKLd2hXqCKeUbIpKPnlH2a+qxVOVf4a1u30XCeGbVe4gJ2HQLB/aQ1ZMyf562YO3lE9TrhOjRZiARMHk8Mp59jwBL0LxnucGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yJrjdjqvnYyzaOCe7H4G7tGSWPjbTwijcGopXXKvIQ=; b=mxnLabzpIiRIdhlpLgJ1fcHdeL3nxojsaOJAh8lN11aP8q3Pz1qvWacS6UvJnikjTw6ZAJ1zuDkm3eQquWcKyT/Xlh7rvrHm6dR/YpSwv0IHpppq1ZSYT4XaWPBZ6CDdk0pCElg+7TjMLC48gKUnwEFDc/K4qaHnbUKvIuQQShSeCpOoinGUq88DXmtEG5IpW4U4dwyDG3RZlu56m4llJ3sj6uvV/pLJWm/cy8uczj4QHlpI2zSTYC6k6FBWMUj4byWI3q2q5oZiPVH0yTmeF96PxC0iz8QR4MdVTaB8oJjlaWoKKZsC6ahFFsNNDtaKm8qCiLo8Teng1kzjhVDZKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/yJrjdjqvnYyzaOCe7H4G7tGSWPjbTwijcGopXXKvIQ=; b=YazUQYlmI1mnysB766znBtf779QFR1ab6wKo9x8zbqrs6VXK/yhBT3uifhi6uXVmMOPtncDE7/nveA0CqXHFYezWsHY2IJZI3e8w+Hp0McTCfoBBn35ZYY60gwFiWIOMOT7yJfBh6H0sdm5mlJi2Gis/qQWK/D9XhMozxB9xg28= From: Bertrand Marquis To: Wei Chen CC: Julien Grall , "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYbt5OQ+9i9MqGEE+kzOfwd/8WE60tPcKAgABu+QA= Date: Tue, 24 May 2022 08:06:57 +0000 Message-ID: <21E706F6-0625-489B-AA19-278B58CD3537@arm.com> References: <20220523194953.70636-1-julien@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c6d96dd1-0685-4759-f35d-08da3d5c653f x-ms-traffictypediagnostic: VI1PR08MB3983:EE_|DBAEUR03FT024:EE_|DBAPR08MB5717:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2TXCLLVhWRDmc5i6C+jmeFV2lPqdlFF6+j3WL1mBXQPHB6nuGIfesVBqde3h9bOlfg/pWLKxyi6wknsQjT6PX68o1o+udDbhqDFhhOvGNe0TFTsQd+RxdwpzxHLCKTwN1s6EfLa8oygU7GpYXrfhMlr6fQZV0u00m8+ko/VD99Kt8rXb5etQCWzAMvx/0ULLHXpxdBWI9ut2usF3b3WJTLJpIcVEBtLRKUx+jwoB0yu5U7bcH0GjfJdHY+zsfiJW3GAGB9iMZFSl8w8X+DgdLxrOTTQjRk4xW8qu5ppgIZ1Tr7AaByoi4dhMrVW4P3ZQPNYNkauLNNPTyLehIQ3RIxLNyEibBCX4RfQ6ywiXXthi/kOtzk/rmgQ9VymIJkfQaAfwVthqMW9xofBwZB1y/KHv8EVIg12sDSLIhmSAJjOS9xYxBnItK+o4tJKu7Nx2wyYbKJLNVrRQpMsLaOLQGFo6v1JyndeWF7eBer09BtUv3lYlCbfgjDEdb783uOMASu7mhwtnp6fJtGDq3ViH6x5PKqaD5pTtvyvRmwGI82/UFib9pCLwotyti/e5FS3oj/M8CgPhGi+sfhtKrLHdid7WmAMP7AdnBxYqNqWlv7FWMk7W65Q9aNoGt2dHdPgWf18ehZYP+6T5BVCjsvNJgycg9cK7cojoJqiWYkQDcz4FrU6CNz5PLr8BLgrmSSxNwKK3S+4dbmg1/o0yJHR6DuC3n8bsjeek53WDZSvG6ccNREi6S5Yw0zfuXQJvLFDO X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(2616005)(37006003)(6506007)(53546011)(38100700002)(33656002)(83380400001)(6486002)(36756003)(71200400001)(186003)(316002)(26005)(6512007)(508600001)(6636002)(2906002)(76116006)(6862004)(86362001)(8676002)(66476007)(66556008)(4326008)(64756008)(66446008)(66946007)(8936002)(5660300002)(91956017)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3983 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f5e5736f-22a0-4210-4b9a-08da3d5c5f79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODleFBg8Jla2wR334Qh6NtCEzc32e3rjm3jJxQ2MnrtvRXJ1oDpDCp0EyfAKAdOOndoKd/5ffKdZ2sJne+QZjhDXScXhLRqedHiMoQ4kFQdyRSY4w8EqpJfvZwq5tUokKV0LDm2SRebV7AEK4NFSVlAOqKGI2BmdJNFVNOV1j1xRswS4JNjc8SlX5fo2X9Ae0s2l53qWxYJBHQ11vicCouGi0drjNA/kZSuqw5RnqCm7d+6juHHVGZJslW7EgQ8JBcPz7BTEtThxpfgncsJMfY7/dsDipn38adt4t47dw7/hCvJaMZxYW82jkAiloLK8JBJLsZ4HVbfxRndyUzbGF/nHCLUOcHaHYb6fAYPisxIOBLEX4GNSZ5LqwanEjlMbniUamGILJQRXwdRRaFxiIzvB4fG+9cJixn2tNzhMJk2jgp/XYrC9K8lgXAVQjuJCh5whg5oxWiYOKFnPl5shDyL622dW37AQAMkcTNszhp5SULDtp5t1QSvLWEsJEsV4sNWRhxKZeu3ARgmMUKJgfnFU0JJoBFVTysCo++sQi2MQEnSP5g63Yde8MfE3a7692U7WkhlSh8WHoFHQplBxcpdtBtFt1mjU0Bz8LZHCBqz8o5z/yFHM4d+iDr5g/t7nHmK9tP6J8f+us8Rc0vay2BkAgZp3FNUlXnOUdAJ9pIic6aqKXMqxUMlJFLIUr1xK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36756003)(82310400005)(54906003)(83380400001)(508600001)(6636002)(2616005)(37006003)(316002)(336012)(47076005)(107886003)(6512007)(26005)(86362001)(186003)(40460700003)(6506007)(81166007)(6486002)(53546011)(8936002)(8676002)(70206006)(6862004)(2906002)(5660300002)(36860700001)(356005)(33656002)(4326008)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 08:07:07.1321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6d96dd1-0685-4759-f35d-08da3d5c653f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5717 SGkgV2VpLA0KDQo+IE9uIDI0IE1heSAyMDIyLCBhdCAwMjoyOSwgV2VpIENoZW4gPFdlaS5DaGVu QGFybS5jb20+IHdyb3RlOg0KPiANCj4gSGkgSnVsaWVuLA0KPiANCj4+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3Rz LnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YNCj4+IEp1bGllbiBHcmFsbA0KPj4gU2VudDog MjAyMuW5tDXmnIgyNOaXpSAzOjUwDQo+PiBUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnDQo+PiBDYzoganVsaWVuQHhlbi5vcmc7IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5j b20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVy dHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4+IFZvbG9keW15ciBC YWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEtvbnJhZCBSemVzenV0ZWsgV2ls aw0KPj4gPGtvbnJhZC53aWxrQG9yYWNsZS5jb20+OyBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdl cndhbGxAY2l0cml4LmNvbT4NCj4+IFN1YmplY3Q6IFtQQVRDSF0geGVuL2FybTogUmVtb3ZlIG1v c3Qgb2YgdGhlICpfVklSVF9FTkQgZGVmaW5lcw0KPj4gDQo+PiBGcm9tOiBKdWxpZW4gR3JhbGwg PGpncmFsbEBhbWF6b24uY29tPg0KPj4gDQo+PiBBdCB0aGUgbW9tZW50LCAqX1ZJUlRfRU5EIG1h eSBlaXRoZXIgcG9pbnQgdG8gdGhlIGFkZHJlc3MgYWZ0ZXIgdGhlIGVuZA0KPj4gb3IgdGhlIGxh c3QgYWRkcmVzcyBvZiB0aGUgcmVnaW9uLg0KPj4gDQo+PiBUaGUgbGFjayBvZiBjb25zaXN0ZW5j eSBtYWtlIHF1aXRlIGRpZmZpY3VsdCB0byByZWFzb24gd2l0aCB0aGVtLg0KPj4gDQo+PiBGdXJ0 aGVybW9yZSwgdGhlcmUgaXMgYSByaXNrIG9mIG92ZXJmbG93IGluIHRoZSBjYXNlIHdoZXJlIHRo ZSBhZGRyZXNzDQo+PiBwb2ludHMgcGFzdCB0byB0aGUgZW5kLiBJIGFtIG5vdCBhd2FyZSBvZiBh bnkgY2FzZXMsIHNvIHRoaXMgaXMgb25seSBhDQo+PiBsYXRlbnQgYnVnLg0KPj4gDQo+PiBTdGFy dCB0byBzb2x2ZSB0aGUgcHJvYmxlbSBieSByZW1vdmluZyBhbGwgdGhlICpfVklSVF9FTkQgZXhj bHVzaXZlbHkgdXNlZA0KPj4gYnkgdGhlIEFybSBjb2RlIGFuZCBhZGQgKl9WSVJUX1NJWkUgd2hl biBpdCBpcyBub3QgcHJlc2VudC4NCj4+IA0KPj4gVGFrZSB0aGUgb3Bwb3J0dW5pdHkgdG8gcmVu YW1lIEJPT1RfRkRUX1NMT1RfU0laRSB0byBCT09UX0ZEVF9WSVJUX1NJWkUNCj4+IGZvciBiZXR0 ZXIgY29uc2lzdGVuY3kgYW5kIHVzZSBfQVQodmFkZHJfdCwgKS4NCj4+IA0KPj4gU2lnbmVkLW9m Zi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4+IA0KPj4gLS0tLQ0KPj4g DQo+PiBJIG5vdGljZWQgdGhhdCBhIGZldyBmdW5jdGlvbnMgaW4gWGVuIGV4cGVjdCBbc3RhcnQs IGVuZFsuIFRoaXMgaXMgcmlza3kNCj4+IGFzIHdlIG1heSBlbmQgdXAgd2l0aCBlbmQgPCBzdGFy dCBpZiB0aGUgcmVnaW9uIGlzIGRlZmluZWQgcmlnaHQgYXQgdGhlDQo+PiB0b3Agb2YgdGhlIGFk ZHJlc3Mgc3BhY2UuDQo+PiANCj4+IEkgaGF2ZW4ndCB5ZXQgdGFja2xlIHRoaXMgaXNzdWUuIEJ1 dCBJIHdvdWxkIGF0IGxlYXN0IGxpa2UgdG8gZ2V0IHJpZA0KPj4gb2YgKl9WSVJUX0VORC4NCj4+ IC0tLQ0KPj4geGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZy5oIHwgMTggKysrKysrKyst LS0tLS0tLS0tDQo+PiB4ZW4vYXJjaC9hcm0vbGl2ZXBhdGNoLmMgfCAyICstDQo+PiB4ZW4vYXJj aC9hcm0vbW0uYyB8IDEzICsrKysrKysrLS0tLS0NCj4+IDMgZmlsZXMgY2hhbmdlZCwgMTcgaW5z ZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+PiANCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJj aC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4+IGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt L2NvbmZpZy5oDQo+PiBpbmRleCAzZTJhNTVhOTEwNTguLjY2ZGI2MThiMzRlNyAxMDA2NDQNCj4+ IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWcuaA0KPj4gKysrIGIveGVuL2Fy Y2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+PiBAQCAtMTExLDEyICsxMTEsMTEgQEANCj4+ ICNkZWZpbmUgRklYTUFQX0FERFIobikgKF9BVCh2YWRkcl90LDB4MDA0MDAwMDApICsgKG4pICog UEFHRV9TSVpFKQ0KPj4gDQo+PiAjZGVmaW5lIEJPT1RfRkRUX1ZJUlRfU1RBUlQgX0FUKHZhZGRy X3QsMHgwMDYwMDAwMCkNCj4+IC0jZGVmaW5lIEJPT1RfRkRUX1NMT1RfU0laRSBNQig0KQ0KPj4g LSNkZWZpbmUgQk9PVF9GRFRfVklSVF9FTkQgKEJPT1RfRkRUX1ZJUlRfU1RBUlQgKyBCT09UX0ZE VF9TTE9UX1NJWkUpDQo+PiArI2RlZmluZSBCT09UX0ZEVF9WSVJUX1NJWkUgX0FUKHZhZGRyX3Qs IE1CKDQpKQ0KPj4gDQo+PiAjaWZkZWYgQ09ORklHX0xJVkVQQVRDSA0KPj4gI2RlZmluZSBMSVZF UEFUQ0hfVk1BUF9TVEFSVCBfQVQodmFkZHJfdCwweDAwYTAwMDAwKQ0KPj4gLSNkZWZpbmUgTElW RVBBVENIX1ZNQVBfRU5EIChMSVZFUEFUQ0hfVk1BUF9TVEFSVCArIE1CKDIpKQ0KPj4gKyNkZWZp bmUgTElWRVBBVENIX1ZNQVBfU0laRSBfQVQodmFkZHJfdCwgTUIoMikpDQo+PiAjZW5kaWYNCj4+ IA0KPj4gI2RlZmluZSBIWVBFUlZJU09SX1ZJUlRfU1RBUlQgWEVOX1ZJUlRfU1RBUlQNCj4+IEBA IC0xMzIsMTggKzEzMSwxOCBAQA0KPj4gI2RlZmluZSBGUkFNRVRBQkxFX1ZJUlRfRU5EIChGUkFN RVRBQkxFX1ZJUlRfU1RBUlQgKyBGUkFNRVRBQkxFX1NJWkUgLQ0KPj4gMSkNCj4+IA0KPj4gI2Rl ZmluZSBWTUFQX1ZJUlRfU1RBUlQgX0FUKHZhZGRyX3QsMHgxMDAwMDAwMCkNCj4+ICsjZGVmaW5l IFZNQVBfVklSVF9TSVpFIF9BVCh2YWRkcl90LCBHQigxKSAtIE1CKDI1NikpDQo+PiANCj4+ICNk ZWZpbmUgWEVOSEVBUF9WSVJUX1NUQVJUIF9BVCh2YWRkcl90LDB4NDAwMDAwMDApDQo+PiAtI2Rl ZmluZSBYRU5IRUFQX1ZJUlRfRU5EIF9BVCh2YWRkcl90LDB4N2ZmZmZmZmYpDQo+PiAtI2RlZmlu ZSBET01IRUFQX1ZJUlRfU1RBUlQgX0FUKHZhZGRyX3QsMHg4MDAwMDAwMCkNCj4+IC0jZGVmaW5l IERPTUhFQVBfVklSVF9FTkQgX0FUKHZhZGRyX3QsMHhmZmZmZmZmZikNCj4+ICsjZGVmaW5lIFhF TkhFQVBfVklSVF9TSVpFIF9BVCh2YWRkcl90LCBHQigxKSkNCj4+IA0KPj4gLSNkZWZpbmUgVk1B UF9WSVJUX0VORCBYRU5IRUFQX1ZJUlRfU1RBUlQNCj4+ICsjZGVmaW5lIERPTUhFQVBfVklSVF9T VEFSVCBfQVQodmFkZHJfdCwweDgwMDAwMDAwKQ0KPj4gKyNkZWZpbmUgRE9NSEVBUF9WSVJUX1NJ WkUgX0FUKHZhZGRyX3QsIEdCKDIpKQ0KPj4gDQo+PiAjZGVmaW5lIERPTUhFQVBfRU5UUklFUyAx MDI0IC8qIDEwMjQgMk1CIG1hcHBpbmcgc2xvdHMgKi8NCj4+IA0KPj4gLyogTnVtYmVyIG9mIGRv bWhlYXAgcGFnZXRhYmxlIHBhZ2VzIHJlcXVpcmVkIGF0IHRoZSBzZWNvbmQgbGV2ZWwgKDJNQg0K Pj4gbWFwcGluZ3MpICovDQo+PiAtI2RlZmluZSBET01IRUFQX1NFQ09ORF9QQUdFUyAoKERPTUhF QVBfVklSVF9FTkQgLSBET01IRUFQX1ZJUlRfU1RBUlQgKw0KPj4gMSkgPj4gRklSU1RfU0hJRlQp DQo+PiArI2RlZmluZSBET01IRUFQX1NFQ09ORF9QQUdFUyAoRE9NSEVBUF9WSVJUX1NJWkUgPj4g RklSU1RfU0hJRlQpDQo+PiANCj4+ICNlbHNlIC8qIEFSTV82NCAqLw0KPj4gDQo+PiBAQCAtMTUy LDEyICsxNTEsMTEgQEANCj4+ICNkZWZpbmUgU0xPVDBfRU5UUllfU0laRSBTTE9UMCgxKQ0KPj4g DQo+PiAjZGVmaW5lIFZNQVBfVklSVF9TVEFSVCBHQigxKQ0KPj4gLSNkZWZpbmUgVk1BUF9WSVJU X0VORCAoVk1BUF9WSVJUX1NUQVJUICsgR0IoMSkpDQo+PiArI2RlZmluZSBWTUFQX1ZJUlRfU0la RSBHQigxKQ0KPj4gDQo+PiAjZGVmaW5lIEZSQU1FVEFCTEVfVklSVF9TVEFSVCBHQigzMikNCj4+ ICNkZWZpbmUgRlJBTUVUQUJMRV9TSVpFIEdCKDMyKQ0KPj4gI2RlZmluZSBGUkFNRVRBQkxFX05S IChGUkFNRVRBQkxFX1NJWkUgLyBzaXplb2YoKmZyYW1lX3RhYmxlKSkNCj4+IC0jZGVmaW5lIEZS QU1FVEFCTEVfVklSVF9FTkQgKEZSQU1FVEFCTEVfVklSVF9TVEFSVCArIEZSQU1FVEFCTEVfU0la RSAtDQo+PiAxKQ0KPj4gDQo+PiAjZGVmaW5lIERJUkVDVE1BUF9WSVJUX1NUQVJUIFNMT1QwKDI1 NikNCj4+ICNkZWZpbmUgRElSRUNUTUFQX1NJWkUgKFNMT1QwX0VOVFJZX1NJWkUgKiAoMjY1LTI1 NikpDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jIGIveGVuL2FyY2gv YXJtL2xpdmVwYXRjaC5jDQo+PiBpbmRleCA3NWU4YWRjZmQ2YTEuLjU3YWJjNzQ2ZTYwYiAxMDA2 NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9saXZlcGF0Y2guYw0KPj4gKysrIGIveGVuL2FyY2gv YXJtL2xpdmVwYXRjaC5jDQo+PiBAQCAtMTc1LDcgKzE3NSw3IEBAIHZvaWQgX19pbml0IGFyY2hf bGl2ZXBhdGNoX2luaXQodm9pZCkNCj4+IHZvaWQgKnN0YXJ0LCAqZW5kOw0KPj4gDQo+PiBzdGFy dCA9ICh2b2lkICopTElWRVBBVENIX1ZNQVBfU1RBUlQ7DQo+PiAtIGVuZCA9ICh2b2lkICopTElW RVBBVENIX1ZNQVBfRU5EOw0KPj4gKyBlbmQgPSBzdGFydCArIExJVkVQQVRDSF9WTUFQX1NJWkU7 DQo+PiANCj4+IHZtX2luaXRfdHlwZShWTUFQX1hFTiwgc3RhcnQsIGVuZCk7DQo+PiANCj4+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbW0uYyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+PiBpbmRl eCBiZTM3MTc2YTQ3MjUuLjA2MDdjNjVmOTVjZCAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2Fy bS9tbS5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vbW0uYw0KPj4gQEAgLTEyOCw5ICsxMjgsMTEg QEAgc3RhdGljIERFRklORV9QQUdFX1RBQkxFKHhlbl9maXJzdCk7DQo+PiAvKiB4ZW5fcGd0YWJs ZSA9PSByb290IG9mIHRoZSB0cmllICh6ZXJvZXRoIGxldmVsIG9uIDY0LWJpdCwgZmlyc3Qgb24g MzItDQo+PiBiaXQpICovDQo+PiBzdGF0aWMgREVGSU5FX1BFUl9DUFUobHBhZV90ICosIHhlbl9w Z3RhYmxlKTsNCj4+ICNkZWZpbmUgVEhJU19DUFVfUEdUQUJMRSB0aGlzX2NwdSh4ZW5fcGd0YWJs ZSkNCj4+IC0vKiB4ZW5fZG9tbWFwID09IHBhZ2VzIHVzZWQgYnkgbWFwX2RvbWFpbl9wYWdlLCB0 aGVzZSBwYWdlcyBjb250YWluDQo+PiArLyoNCj4+ICsgKiB4ZW5fZG9tbWFwID09IHBhZ2VzIHVz ZWQgYnkgbWFwX2RvbWFpbl9wYWdlLCB0aGVzZSBwYWdlcyBjb250YWluDQo+PiAqIHRoZSBzZWNv bmQgbGV2ZWwgcGFnZXRhYmxlcyB3aGljaCBtYXAgdGhlIGRvbWhlYXAgcmVnaW9uDQo+PiAtICog RE9NSEVBUF9WSVJUX1NUQVJULi4uRE9NSEVBUF9WSVJUX0VORCBpbiAyTUIgY2h1bmtzLiAqLw0K Pj4gKyAqIHN0YXJ0aW5nIGF0IERPTUhFQVBfVklSVF9TVEFSVCBpbiAyTUIgY2h1bmtzLg0KPj4g KyAqLw0KPj4gc3RhdGljIERFRklORV9QRVJfQ1BVKGxwYWVfdCAqLCB4ZW5fZG9tbWFwKTsNCj4+ IC8qIFJvb3Qgb2YgdGhlIHRyaWUgZm9yIGNwdTAsIG90aGVyIENQVSdzIFBUcyBhcmUgZHluYW1p Y2FsbHkgYWxsb2NhdGVkDQo+PiAqLw0KPj4gc3RhdGljIERFRklORV9QQUdFX1RBQkxFKGNwdTBf cGd0YWJsZSk7DQo+PiBAQCAtNDc2LDcgKzQ3OCw3IEBAIG1mbl90IGRvbWFpbl9wYWdlX21hcF90 b19tZm4oY29uc3Qgdm9pZCAqcHRyKQ0KPj4gaW50IHNsb3QgPSAodmEgLSBET01IRUFQX1ZJUlRf U1RBUlQpID4+IFNFQ09ORF9TSElGVDsNCj4+IHVuc2lnbmVkIGxvbmcgb2Zmc2V0ID0gKHZhPj5U SElSRF9TSElGVCkgJiBYRU5fUFRfTFBBRV9FTlRSWV9NQVNLOw0KPj4gDQo+PiAtIGlmICggdmEg Pj0gVk1BUF9WSVJUX1NUQVJUICYmIHZhIDwgVk1BUF9WSVJUX0VORCApDQo+PiArIGlmICggKHZh ID49IFZNQVBfVklSVF9TVEFSVCkgJiYgKChWTUFQX1ZJUlRfU1RBUlQgLSB2YSkgPA0KPj4gVk1B UF9WSVJUX1NJWkUpICkNCj4+IHJldHVybiB2aXJ0X3RvX21mbih2YSk7DQo+PiANCj4+IEFTU0VS VChzbG90ID49IDAgJiYgc2xvdCA8IERPTUhFQVBfRU5UUklFUyk7DQo+PiBAQCAtNTcwLDcgKzU3 Miw4IEBAIHZvaWQgX19pbml0IHJlbW92ZV9lYXJseV9tYXBwaW5ncyh2b2lkKQ0KPj4gaW50IHJj Ow0KPj4gDQo+PiAvKiBkZXN0cm95IHRoZSBfUEFHRV9CTE9DSyBtYXBwaW5nICovDQo+PiAtIHJj ID0gbW9kaWZ5X3hlbl9tYXBwaW5ncyhCT09UX0ZEVF9WSVJUX1NUQVJULCBCT09UX0ZEVF9WSVJU X0VORCwNCj4+ICsgcmMgPSBtb2RpZnlfeGVuX21hcHBpbmdzKEJPT1RfRkRUX1ZJUlRfU1RBUlQs DQo+PiArIEJPT1RfRkRUX1ZJUlRfU1RBUlQgKyBCT09UX0ZEVF9WSVJUX1NJWkUsDQo+PiBfUEFH RV9CTE9DSyk7DQo+PiBCVUdfT04ocmMpOw0KPj4gfQ0KPj4gQEAgLTg1MCw3ICs4NTMsNyBAQCB2 b2lkIF9faW5pdCBzZXR1cF9mcmFtZXRhYmxlX21hcHBpbmdzKHBhZGRyX3QgcHMsDQo+PiBwYWRk cl90IHBlKQ0KPj4gDQo+PiB2b2lkICpfX2luaXQgYXJjaF92bWFwX3ZpcnRfZW5kKHZvaWQpDQo+ PiB7DQo+PiAtIHJldHVybiAodm9pZCAqKVZNQVBfVklSVF9FTkQ7DQo+PiArIHJldHVybiAodm9p ZCAqKShWTUFQX1ZJUlRfU1RBUlQgKyBWTUFQX1ZJUlRfU0laRSk7DQo+IA0KPiBJdCBzZWVtcyB5 b3UgcHJlZmVyIHRvIHBvaW50IF9lbmQgdG8gdGhlIGFkZHJlc3MgYWZ0ZXIgdGhlIGVuZC4gRXZl bg0KPiB0aG91Z2ggd2UgZ290IHJpZCBvZiB0aGUgbWFjcm8gZGVmaW5pdGlvbiBvZiBfRU5ELiBC dXQgd2UgZGlkbid0IGFncmVlDQo+IG9uIGhvdyB0byB1c2UgaXQuIEZvciBtZSwgd2hlbiBJIGZp cnN0IHNhdw0KPiAiZW5kID0gc3RhcnQgKyBMSVZFUEFUQ0hfVk1BUF9TSVpFIiBJIHN1YmNvbnNj aW91c2x5IHRoaW5rIHRoZSAtMSBpcw0KPiBtaXNzaW5nIGhlcmUuIEkgZXZlbiBhZGRlZCBhIGNv bW1lbnQsIGJ1dCByZW1vdmVkIGl0IHdoZW4gSSByZWFjaGVkDQo+IHRvIHRoaXMgbGluZSA6ICkN Cj4gTWF5IGJlIGl0J3MgYmV0dGVyIHRvIHBsYWNlIHNvbWUgY29kZSBndWlkZSBmb3IgRU5EIGlu IGNvZGUgY29tbWVudA0KPiBpbiB0aGUgU0laRSBkZWZpbml0aW9uLCBvdGhlcndpc2UsIHdlIG1h eSBoYXZlIGRpZmZlcmVudCBwb2ludCBhZGRyZXNzZXMNCj4gb2YgX2VuZCBmdW5jdGlvbnMuDQoN CkkgdGhpbmsgaXQgaXMgcXVpdGUgY29tbW9uIHRvIGhhdmUgc2l6ZSBiZWluZyB0aGUgYWN0dWFs IHNpemUgYW5kIG5vdCBzaXplIC0xLg0KRU5EIGlzIGNsZWFybHkgdGhlIGxhc3QgYWRkcmVzcyBv ZiB0aGUgYXJlYSBidXQgU0laRSBzaG91bGQgYmUgdGhlIG51bWJlcg0Kb2YgYnl0ZXMgaW4gdGhl IGFyZWEgc28gSSB0aGluayBKdWxpZW4gaGVyZSBpcyByaWdodC4NCg0KQ2hlZXJzDQpCZXJ0cmFu ZA0KDQo+IA0KPiBDaGVlcnMsDQo+IFdlaSBDaGVuDQo+IA0KPj4gfQ0KPj4gDQo+PiAvKg0KPj4g LS0NCj4+IDIuMzIuMA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue May 24 08:16:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336414.560724 (Exim 4.92) (envelope-from ) id 1ntPif-0002JR-DB; Tue, 24 May 2022 08:16:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336414.560724; Tue, 24 May 2022 08:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPif-0002JK-9q; Tue, 24 May 2022 08:16:45 +0000 Received: by outflank-mailman (input) for mailman id 336414; Tue, 24 May 2022 08:16:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPid-0002JE-I7 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:16:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1b::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d777216b-db39-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 10:16:41 +0200 (CEST) Received: from AM5PR0601CA0044.eurprd06.prod.outlook.com (2603:10a6:203:68::30) by DB9PR08MB7130.eurprd08.prod.outlook.com (2603:10a6:10:2c8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 08:16:39 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::d) by AM5PR0601CA0044.outlook.office365.com (2603:10a6:203:68::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:16:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 08:16:37 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Tue, 24 May 2022 08:16:37 +0000 Received: from 7add157299b2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 580ADE7E-2AC5-4E8C-AFF3-34AC6270CBCA.1; Tue, 24 May 2022 08:16:27 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7add157299b2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 24 May 2022 08:16:27 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB7192.eurprd08.prod.outlook.com (2603:10a6:20b:407::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 08:16:25 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::d007:5582:9bbe:425e%3]) with mapi id 15.20.5273.022; Tue, 24 May 2022 08:16:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d777216b-db39-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QtTNyeZ/vrtPVHxljrDvu1nBfa3xiqaUBw3wriJAO50WFMgm9kvxEAKFL/zwBOG6Z09dR2P1Ups6hsDUFJwIFYeThgfhVOCuKbV+UVE7QuYzInWLMByyyYSDzCSyxBa7A7tycwGBPDwPnsYd+2YLdLSl0Rc44Eee/Xtqm7bdMgA8CKpkrX07pISvicorMPzdWZbOSLFsH1SbiBDkM3CxRPKeviulIfnEt9ECD9ADJyep4D3P9+sq0EZca8+9QvqKdytmmKxriaCZD+8tINJcUVG+6wqAuFm33f1jIIOjUdy9hDOOev+rW6tk1EOIkeitEkqYiaymG/ZeSK6meOrHVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CRslCaqkSmqLBeZbFT77UwCcA7zwOMZv3Cw2FbW97zw=; b=ATpmxHOiPjvCKmTyj14jiElSYAI+4AsdtwuqprYJ4G+4L9noif0M9rmpOnc5CwWG4Xt/AlpGqMFQSRcCFCDHfDwN0Kjb/Gdnrg/FosFPia9PAiQ70hUn5LxeGFp5p9iU+Kq9GJuKqhEic5B7wusxSfsrtBvVS0AY4QYKvtlMP8lq1JzuV+ZQZRBdeGeH/9EQqCmWVAY3+ISdh3IG82eVXq6wwttyaR99DCaZihDPn128nMYT6/WWABKyNPk95hfLFQC2RvwFp+gC1lV62W6AL7p5canV2uRspfYeZocxXo/oLBzdwxsju9e6nEwOncTTZlzlpCKgBMoEZpJLrMwlFw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CRslCaqkSmqLBeZbFT77UwCcA7zwOMZv3Cw2FbW97zw=; b=73NUCyv0a1Q2vxcUayDXQx4jEBAAF6tXo9BpUY6YJNnSX6DhLS1qmYkWh0ZHDtpolLvi+I4ZY+79U4vuC5mifkHf+axvtky+cGwXPZeszrfMkYmD2jYFxCVcVDC9nFrPogJT7Q8T7I15iT1HWycdQKylGog8BLug3IHdmrrFeB4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RXFnH+fCZzEaFDByLLikQShktGIb2X5TikFi3G3jmHPjhpScuNR2l5rFBSqXWyIV4aLf7N+jcA8Yms5FmRgQKqonByhx5RU6qKM3iCHzyzzEl/KRa7ki+AeqpB9MB6nqX1eNCmuwEG6QjEDcG9bzsr9nPBdJ37wVQPvqPNneYpJJ4P24RD7pHdpNwtHoMeGLISbUeyis0VQ9zVVZMUbuSt2tF8BH52Z0ZJQEIqrEUP0swmDu6L/XvGUfChkIvgDJHifowebz88WwI0oRIbs4uwJQonTaSFVuInZlC2HwtKCkN7AXXsf3DQIAbsLw7HgeViP0m2kN/YZ+Hnt+xtGEcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CRslCaqkSmqLBeZbFT77UwCcA7zwOMZv3Cw2FbW97zw=; b=Em8qPG9mgaibtAXNw9M74Ljyi4KvmXmxmMCBFUEPeD1DIAI/XdSvDCi0ZtcokyWz7VOStsC9A1J/vXKmoPXregiJ4jd+RQuBOLwOGGLHa91hg7I6+J1afmz9K40PTU1jdb5EFVxJgKgVefsfxUDnqQPjAC4tIfO9ku2w25x6VWzu10/QrOYfuum0/4tUvuxEtHE5yFpTjtnFSFWL4TJWsN86UI7UbNjxF3OJGRuzp4oUCCtTdXmNV+XBPlb9suFInnfjl0Q5TU4GGwMhoTmc9DIyWoWm9cEnV7EbP/HCQqXp96I+CDpOscJiexzbJTPxqCqv57GLdbD7hGM0FCPd/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CRslCaqkSmqLBeZbFT77UwCcA7zwOMZv3Cw2FbW97zw=; b=73NUCyv0a1Q2vxcUayDXQx4jEBAAF6tXo9BpUY6YJNnSX6DhLS1qmYkWh0ZHDtpolLvi+I4ZY+79U4vuC5mifkHf+axvtky+cGwXPZeszrfMkYmD2jYFxCVcVDC9nFrPogJT7Q8T7I15iT1HWycdQKylGog8BLug3IHdmrrFeB4= From: Wei Chen To: Bertrand Marquis CC: Julien Grall , "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: RE: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYbt50tGidbD5g50ygNS2KCABD4q0tOEpAgAB0coCAAADVMA== Date: Tue, 24 May 2022 08:16:25 +0000 Message-ID: References: <20220523194953.70636-1-julien@xen.org> <21E706F6-0625-489B-AA19-278B58CD3537@arm.com> In-Reply-To: <21E706F6-0625-489B-AA19-278B58CD3537@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 467E833A5D19644D91BF935DF49D9FB8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0a7d87b6-a5ea-4512-d7ba-08da3d5db996 x-ms-traffictypediagnostic: AS8PR08MB7192:EE_|VE1EUR03FT030:EE_|DB9PR08MB7130:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: t5pgg+qMEtfRClay8j2DsVYS9SxLdu6dOWF2i5HMFrllqTs9u7ybfzklmdgj8UTififHu0vkET8kK7BQm/KNgQg5uSy7UbfDw6ve/r0bLspmGXv7XlkW9IXd2ObX5QaVdUkRPkrZuTmSSEYMjepZZToGAaG7EXsTpTUBbFcfn0ev3zjR+K/KM2TbIwhlC1/1DNbfe0TKK9AD7pS3c55TNzNP19Z1UNfSpIiiANo/ag/duiriSJaM49OuZVrv1w91l5eujAQ6OX0Cp3CZGsH/0T5zO948mnrJQZpLxTMXgPq+C3giRBDdwQVvcDQsyM72CWAUHyuTf43VJeWlnjx6MgKlcdBpO3fKwgJV8juqCm3WHuGsaA49jUgR8TS7A7TrHYmPrsYclh5br0o7iSh58kKYtKgtk++0hgCGNYKUoN2NxH36neWA5C/yWtJmD/3LQLjG2y+G+q/FZB0jSFA982dDlVDfA67sOSPcRp/6VmB18XOPY0MylG1c/tAJjo+fHm60sn38kODCYK4DrmY5COm4gDcX2xkcF9f4X4xQhwDfXapvp0ZTHl6I3xQ5mPkZXZcuC6gjGsEt4lqJqS/VSCZh1vzpTnQCR6RWRUzrE6TZsZ4laj1tnVtEZA2IyLGHhFkF5pkacUwxNsAC9pePXPM6bKnQz0/zyADBJYTKm/4R5qYkDkEHgCbxSK3AejcxCCT0mfBO6nkpFV8ObIfiJNO47XbXdBeuataMqfRKcAI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(52536014)(38070700005)(53546011)(83380400001)(5660300002)(8936002)(26005)(38100700002)(6506007)(9686003)(66946007)(6862004)(76116006)(4326008)(54906003)(66556008)(8676002)(66476007)(64756008)(66446008)(508600001)(2906002)(33656002)(6636002)(122000001)(86362001)(316002)(7696005)(71200400001)(55016003)(21314003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7192 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 28c9f03f-1b1e-4e32-4007-08da3d5db1dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V4lWTzUevC+wHiFVGSupiqFMOBCCvdyBQEDgQj9Eouu9h73yLdRT7exLy4SjU4KXs28QBsJ8+A5XY7u+8tOgscE3LuiUUR/UaxQ8qPvTY3GSpqk1lplZq7+cSy6dxM0go1/oH+z6YEV/iXMNtMEKeUMAuMxlljJzI/FN768ZZ60Pw5Ref8fZ75kd989aqvZcXrWOzC7UrofY6CMOh5+65KdRD87PF1HEzWGDMJtDQbU2II6P/gn8KBkZtrjnl4mPPyAGr4RRHOplYlKoZ00Urt40LgxiYYFCMg+S/GqVoxaEDlsTH8tN1bC6VbXb7ghW3qvAE+HlRygxykmw92cokwJM7Z3hOR5MtVhe6S0TidentDrAGNfQ2LdeEg33TVlo94E2bcgKzsEdIeqRkU2LyRIPi3qffaROXA5iu/pgkVZKej5KsjSHbSE+2M0vLTyoJgcFst+NPnMHc/o9zqgsVvaP9LlUY5Rv5Dj6OzqsqKV+65BK4MpAqI2JkBKfaOY97Vam5hJUmBvcAVmodJN1+YMvm1iEJbrRbqVQuBtz2Jl8SUuSFg//tyaSM28Br8YQmplX5bTgWSj36kCVGwqNqr+hT64dfm7JDJeme3hYPi24c80tGJBI3bheit2KtdHGXSFNBCPyYJIijSroOZIFfZLGUZAXhxix1UUu8CMrYh5cszO8c6Dk7gesF/kemPys X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(70586007)(70206006)(8936002)(186003)(107886003)(82310400005)(6862004)(5660300002)(53546011)(52536014)(83380400001)(336012)(8676002)(4326008)(33656002)(7696005)(36860700001)(6506007)(316002)(54906003)(9686003)(356005)(55016003)(508600001)(26005)(6636002)(2906002)(47076005)(81166007)(86362001)(40460700003)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 08:16:37.9863 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7d87b6-a5ea-4512-d7ba-08da3d5db996 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7130 SGkgQmVydHJhbmQsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmVy dHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPg0KPiBTZW50OiAyMDIy5bm0 NeaciDI05pelIDE2OjA3DQo+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6 IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEp1bGllbg0KPiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+OyBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9s b2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBLb25yYWQgUnplc3p1dGVrIFdpbGsNCj4gPGtvbnJh ZC53aWxrQG9yYWNsZS5jb20+OyBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4 LmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0geGVuL2FybTogUmVtb3ZlIG1vc3Qgb2YgdGhl ICpfVklSVF9FTkQgZGVmaW5lcw0KPiANCj4gSGkgV2VpLA0KPiANCj4gPiBPbiAyNCBNYXkgMjAy MiwgYXQgMDI6MjksIFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPiB3cm90ZToNCj4gPg0KPiA+ IEhpIEp1bGllbiwNCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBG cm9tOiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBP biBCZWhhbGYgT2YNCj4gPj4gSnVsaWVuIEdyYWxsDQo+ID4+IFNlbnQ6IDIwMjLlubQ15pyIMjTm l6UgMzo1MA0KPiA+PiBUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4+IENj OiBqdWxpZW5AeGVuLm9yZzsgSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT47IFN0ZWZh bm8NCj4gU3RhYmVsbGluaQ0KPiA+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5k IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+ID4+IFZvbG9keW15ciBCYWJj aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEtvbnJhZCBSemVzenV0ZWsgV2lsaw0K PiA+PiA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT47IFJvc3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vy d2FsbEBjaXRyaXguY29tPg0KPiA+PiBTdWJqZWN0OiBbUEFUQ0hdIHhlbi9hcm06IFJlbW92ZSBt b3N0IG9mIHRoZSAqX1ZJUlRfRU5EIGRlZmluZXMNCj4gPj4NCj4gPj4gRnJvbTogSnVsaWVuIEdy YWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gPj4NCj4gPj4gQXQgdGhlIG1vbWVudCwgKl9WSVJU X0VORCBtYXkgZWl0aGVyIHBvaW50IHRvIHRoZSBhZGRyZXNzIGFmdGVyIHRoZSBlbmQNCj4gPj4g b3IgdGhlIGxhc3QgYWRkcmVzcyBvZiB0aGUgcmVnaW9uLg0KPiA+Pg0KPiA+PiBUaGUgbGFjayBv ZiBjb25zaXN0ZW5jeSBtYWtlIHF1aXRlIGRpZmZpY3VsdCB0byByZWFzb24gd2l0aCB0aGVtLg0K PiA+Pg0KPiA+PiBGdXJ0aGVybW9yZSwgdGhlcmUgaXMgYSByaXNrIG9mIG92ZXJmbG93IGluIHRo ZSBjYXNlIHdoZXJlIHRoZSBhZGRyZXNzDQo+ID4+IHBvaW50cyBwYXN0IHRvIHRoZSBlbmQuIEkg YW0gbm90IGF3YXJlIG9mIGFueSBjYXNlcywgc28gdGhpcyBpcyBvbmx5IGENCj4gPj4gbGF0ZW50 IGJ1Zy4NCj4gPj4NCj4gPj4gU3RhcnQgdG8gc29sdmUgdGhlIHByb2JsZW0gYnkgcmVtb3Zpbmcg YWxsIHRoZSAqX1ZJUlRfRU5EIGV4Y2x1c2l2ZWx5DQo+IHVzZWQNCj4gPj4gYnkgdGhlIEFybSBj b2RlIGFuZCBhZGQgKl9WSVJUX1NJWkUgd2hlbiBpdCBpcyBub3QgcHJlc2VudC4NCj4gPj4NCj4g Pj4gVGFrZSB0aGUgb3Bwb3J0dW5pdHkgdG8gcmVuYW1lIEJPT1RfRkRUX1NMT1RfU0laRSB0byBC T09UX0ZEVF9WSVJUX1NJWkUNCj4gPj4gZm9yIGJldHRlciBjb25zaXN0ZW5jeSBhbmQgdXNlIF9B VCh2YWRkcl90LCApLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGpn cmFsbEBhbWF6b24uY29tPg0KPiA+Pg0KPiA+PiAtLS0tDQo+ID4+DQo+ID4+IEkgbm90aWNlZCB0 aGF0IGEgZmV3IGZ1bmN0aW9ucyBpbiBYZW4gZXhwZWN0IFtzdGFydCwgZW5kWy4gVGhpcyBpcw0K PiByaXNreQ0KPiA+PiBhcyB3ZSBtYXkgZW5kIHVwIHdpdGggZW5kIDwgc3RhcnQgaWYgdGhlIHJl Z2lvbiBpcyBkZWZpbmVkIHJpZ2h0IGF0IHRoZQ0KPiA+PiB0b3Agb2YgdGhlIGFkZHJlc3Mgc3Bh Y2UuDQo+ID4+DQo+ID4+IEkgaGF2ZW4ndCB5ZXQgdGFja2xlIHRoaXMgaXNzdWUuIEJ1dCBJIHdv dWxkIGF0IGxlYXN0IGxpa2UgdG8gZ2V0IHJpZA0KPiA+PiBvZiAqX1ZJUlRfRU5ELg0KPiA+PiAt LS0NCj4gPj4geGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NvbmZpZy5oIHwgMTggKysrKysrKyst LS0tLS0tLS0tDQo+ID4+IHhlbi9hcmNoL2FybS9saXZlcGF0Y2guYyB8IDIgKy0NCj4gPj4geGVu L2FyY2gvYXJtL21tLmMgfCAxMyArKysrKysrKy0tLS0tDQo+ID4+IDMgZmlsZXMgY2hhbmdlZCwg MTcgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+ID4+DQo+ID4+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gPj4gYi94ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vY29uZmlnLmgNCj4gPj4gaW5kZXggM2UyYTU1YTkxMDU4Li42NmRiNjE4YjM0 ZTcgMTAwNjQ0DQo+ID4+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWcuaA0K PiA+PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gPj4gQEAgLTEx MSwxMiArMTExLDExIEBADQo+ID4+ICNkZWZpbmUgRklYTUFQX0FERFIobikgKF9BVCh2YWRkcl90 LDB4MDA0MDAwMDApICsgKG4pICogUEFHRV9TSVpFKQ0KPiA+Pg0KPiA+PiAjZGVmaW5lIEJPT1Rf RkRUX1ZJUlRfU1RBUlQgX0FUKHZhZGRyX3QsMHgwMDYwMDAwMCkNCj4gPj4gLSNkZWZpbmUgQk9P VF9GRFRfU0xPVF9TSVpFIE1CKDQpDQo+ID4+IC0jZGVmaW5lIEJPT1RfRkRUX1ZJUlRfRU5EIChC T09UX0ZEVF9WSVJUX1NUQVJUICsgQk9PVF9GRFRfU0xPVF9TSVpFKQ0KPiA+PiArI2RlZmluZSBC T09UX0ZEVF9WSVJUX1NJWkUgX0FUKHZhZGRyX3QsIE1CKDQpKQ0KPiA+Pg0KPiA+PiAjaWZkZWYg Q09ORklHX0xJVkVQQVRDSA0KPiA+PiAjZGVmaW5lIExJVkVQQVRDSF9WTUFQX1NUQVJUIF9BVCh2 YWRkcl90LDB4MDBhMDAwMDApDQo+ID4+IC0jZGVmaW5lIExJVkVQQVRDSF9WTUFQX0VORCAoTElW RVBBVENIX1ZNQVBfU1RBUlQgKyBNQigyKSkNCj4gPj4gKyNkZWZpbmUgTElWRVBBVENIX1ZNQVBf U0laRSBfQVQodmFkZHJfdCwgTUIoMikpDQo+ID4+ICNlbmRpZg0KPiA+Pg0KPiA+PiAjZGVmaW5l IEhZUEVSVklTT1JfVklSVF9TVEFSVCBYRU5fVklSVF9TVEFSVA0KPiA+PiBAQCAtMTMyLDE4ICsx MzEsMTggQEANCj4gPj4gI2RlZmluZSBGUkFNRVRBQkxFX1ZJUlRfRU5EIChGUkFNRVRBQkxFX1ZJ UlRfU1RBUlQgKyBGUkFNRVRBQkxFX1NJWkUgLQ0KPiA+PiAxKQ0KPiA+Pg0KPiA+PiAjZGVmaW5l IFZNQVBfVklSVF9TVEFSVCBfQVQodmFkZHJfdCwweDEwMDAwMDAwKQ0KPiA+PiArI2RlZmluZSBW TUFQX1ZJUlRfU0laRSBfQVQodmFkZHJfdCwgR0IoMSkgLSBNQigyNTYpKQ0KPiA+Pg0KPiA+PiAj ZGVmaW5lIFhFTkhFQVBfVklSVF9TVEFSVCBfQVQodmFkZHJfdCwweDQwMDAwMDAwKQ0KPiA+PiAt I2RlZmluZSBYRU5IRUFQX1ZJUlRfRU5EIF9BVCh2YWRkcl90LDB4N2ZmZmZmZmYpDQo+ID4+IC0j ZGVmaW5lIERPTUhFQVBfVklSVF9TVEFSVCBfQVQodmFkZHJfdCwweDgwMDAwMDAwKQ0KPiA+PiAt I2RlZmluZSBET01IRUFQX1ZJUlRfRU5EIF9BVCh2YWRkcl90LDB4ZmZmZmZmZmYpDQo+ID4+ICsj ZGVmaW5lIFhFTkhFQVBfVklSVF9TSVpFIF9BVCh2YWRkcl90LCBHQigxKSkNCj4gPj4NCj4gPj4g LSNkZWZpbmUgVk1BUF9WSVJUX0VORCBYRU5IRUFQX1ZJUlRfU1RBUlQNCj4gPj4gKyNkZWZpbmUg RE9NSEVBUF9WSVJUX1NUQVJUIF9BVCh2YWRkcl90LDB4ODAwMDAwMDApDQo+ID4+ICsjZGVmaW5l IERPTUhFQVBfVklSVF9TSVpFIF9BVCh2YWRkcl90LCBHQigyKSkNCj4gPj4NCj4gPj4gI2RlZmlu ZSBET01IRUFQX0VOVFJJRVMgMTAyNCAvKiAxMDI0IDJNQiBtYXBwaW5nIHNsb3RzICovDQo+ID4+ DQo+ID4+IC8qIE51bWJlciBvZiBkb21oZWFwIHBhZ2V0YWJsZSBwYWdlcyByZXF1aXJlZCBhdCB0 aGUgc2Vjb25kIGxldmVsICgyTUINCj4gPj4gbWFwcGluZ3MpICovDQo+ID4+IC0jZGVmaW5lIERP TUhFQVBfU0VDT05EX1BBR0VTICgoRE9NSEVBUF9WSVJUX0VORCAtIERPTUhFQVBfVklSVF9TVEFS VCArDQo+ID4+IDEpID4+IEZJUlNUX1NISUZUKQ0KPiA+PiArI2RlZmluZSBET01IRUFQX1NFQ09O RF9QQUdFUyAoRE9NSEVBUF9WSVJUX1NJWkUgPj4gRklSU1RfU0hJRlQpDQo+ID4+DQo+ID4+ICNl bHNlIC8qIEFSTV82NCAqLw0KPiA+Pg0KPiA+PiBAQCAtMTUyLDEyICsxNTEsMTEgQEANCj4gPj4g I2RlZmluZSBTTE9UMF9FTlRSWV9TSVpFIFNMT1QwKDEpDQo+ID4+DQo+ID4+ICNkZWZpbmUgVk1B UF9WSVJUX1NUQVJUIEdCKDEpDQo+ID4+IC0jZGVmaW5lIFZNQVBfVklSVF9FTkQgKFZNQVBfVklS VF9TVEFSVCArIEdCKDEpKQ0KPiA+PiArI2RlZmluZSBWTUFQX1ZJUlRfU0laRSBHQigxKQ0KPiA+ Pg0KPiA+PiAjZGVmaW5lIEZSQU1FVEFCTEVfVklSVF9TVEFSVCBHQigzMikNCj4gPj4gI2RlZmlu ZSBGUkFNRVRBQkxFX1NJWkUgR0IoMzIpDQo+ID4+ICNkZWZpbmUgRlJBTUVUQUJMRV9OUiAoRlJB TUVUQUJMRV9TSVpFIC8gc2l6ZW9mKCpmcmFtZV90YWJsZSkpDQo+ID4+IC0jZGVmaW5lIEZSQU1F VEFCTEVfVklSVF9FTkQgKEZSQU1FVEFCTEVfVklSVF9TVEFSVCArIEZSQU1FVEFCTEVfU0laRSAt DQo+ID4+IDEpDQo+ID4+DQo+ID4+ICNkZWZpbmUgRElSRUNUTUFQX1ZJUlRfU1RBUlQgU0xPVDAo MjU2KQ0KPiA+PiAjZGVmaW5lIERJUkVDVE1BUF9TSVpFIChTTE9UMF9FTlRSWV9TSVpFICogKDI2 NS0yNTYpKQ0KPiA+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jIGIveGVu L2FyY2gvYXJtL2xpdmVwYXRjaC5jDQo+ID4+IGluZGV4IDc1ZThhZGNmZDZhMS4uNTdhYmM3NDZl NjBiIDEwMDY0NA0KPiA+PiAtLS0gYS94ZW4vYXJjaC9hcm0vbGl2ZXBhdGNoLmMNCj4gPj4gKysr IGIveGVuL2FyY2gvYXJtL2xpdmVwYXRjaC5jDQo+ID4+IEBAIC0xNzUsNyArMTc1LDcgQEAgdm9p ZCBfX2luaXQgYXJjaF9saXZlcGF0Y2hfaW5pdCh2b2lkKQ0KPiA+PiB2b2lkICpzdGFydCwgKmVu ZDsNCj4gPj4NCj4gPj4gc3RhcnQgPSAodm9pZCAqKUxJVkVQQVRDSF9WTUFQX1NUQVJUOw0KPiA+ PiAtIGVuZCA9ICh2b2lkICopTElWRVBBVENIX1ZNQVBfRU5EOw0KPiA+PiArIGVuZCA9IHN0YXJ0 ICsgTElWRVBBVENIX1ZNQVBfU0laRTsNCj4gPj4NCj4gPj4gdm1faW5pdF90eXBlKFZNQVBfWEVO LCBzdGFydCwgZW5kKTsNCj4gPj4NCj4gPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tbS5j IGIveGVuL2FyY2gvYXJtL21tLmMNCj4gPj4gaW5kZXggYmUzNzE3NmE0NzI1Li4wNjA3YzY1Zjk1 Y2QgMTAwNjQ0DQo+ID4+IC0tLSBhL3hlbi9hcmNoL2FybS9tbS5jDQo+ID4+ICsrKyBiL3hlbi9h cmNoL2FybS9tbS5jDQo+ID4+IEBAIC0xMjgsOSArMTI4LDExIEBAIHN0YXRpYyBERUZJTkVfUEFH RV9UQUJMRSh4ZW5fZmlyc3QpOw0KPiA+PiAvKiB4ZW5fcGd0YWJsZSA9PSByb290IG9mIHRoZSB0 cmllICh6ZXJvZXRoIGxldmVsIG9uIDY0LWJpdCwgZmlyc3Qgb24NCj4gMzItDQo+ID4+IGJpdCkg Ki8NCj4gPj4gc3RhdGljIERFRklORV9QRVJfQ1BVKGxwYWVfdCAqLCB4ZW5fcGd0YWJsZSk7DQo+ ID4+ICNkZWZpbmUgVEhJU19DUFVfUEdUQUJMRSB0aGlzX2NwdSh4ZW5fcGd0YWJsZSkNCj4gPj4g LS8qIHhlbl9kb21tYXAgPT0gcGFnZXMgdXNlZCBieSBtYXBfZG9tYWluX3BhZ2UsIHRoZXNlIHBh Z2VzIGNvbnRhaW4NCj4gPj4gKy8qDQo+ID4+ICsgKiB4ZW5fZG9tbWFwID09IHBhZ2VzIHVzZWQg YnkgbWFwX2RvbWFpbl9wYWdlLCB0aGVzZSBwYWdlcyBjb250YWluDQo+ID4+ICogdGhlIHNlY29u ZCBsZXZlbCBwYWdldGFibGVzIHdoaWNoIG1hcCB0aGUgZG9taGVhcCByZWdpb24NCj4gPj4gLSAq IERPTUhFQVBfVklSVF9TVEFSVC4uLkRPTUhFQVBfVklSVF9FTkQgaW4gMk1CIGNodW5rcy4gKi8N Cj4gPj4gKyAqIHN0YXJ0aW5nIGF0IERPTUhFQVBfVklSVF9TVEFSVCBpbiAyTUIgY2h1bmtzLg0K PiA+PiArICovDQo+ID4+IHN0YXRpYyBERUZJTkVfUEVSX0NQVShscGFlX3QgKiwgeGVuX2RvbW1h cCk7DQo+ID4+IC8qIFJvb3Qgb2YgdGhlIHRyaWUgZm9yIGNwdTAsIG90aGVyIENQVSdzIFBUcyBh cmUgZHluYW1pY2FsbHkgYWxsb2NhdGVkDQo+ID4+ICovDQo+ID4+IHN0YXRpYyBERUZJTkVfUEFH RV9UQUJMRShjcHUwX3BndGFibGUpOw0KPiA+PiBAQCAtNDc2LDcgKzQ3OCw3IEBAIG1mbl90IGRv bWFpbl9wYWdlX21hcF90b19tZm4oY29uc3Qgdm9pZCAqcHRyKQ0KPiA+PiBpbnQgc2xvdCA9ICh2 YSAtIERPTUhFQVBfVklSVF9TVEFSVCkgPj4gU0VDT05EX1NISUZUOw0KPiA+PiB1bnNpZ25lZCBs b25nIG9mZnNldCA9ICh2YT4+VEhJUkRfU0hJRlQpICYgWEVOX1BUX0xQQUVfRU5UUllfTUFTSzsN Cj4gPj4NCj4gPj4gLSBpZiAoIHZhID49IFZNQVBfVklSVF9TVEFSVCAmJiB2YSA8IFZNQVBfVklS VF9FTkQgKQ0KPiA+PiArIGlmICggKHZhID49IFZNQVBfVklSVF9TVEFSVCkgJiYgKChWTUFQX1ZJ UlRfU1RBUlQgLSB2YSkgPA0KPiA+PiBWTUFQX1ZJUlRfU0laRSkgKQ0KPiA+PiByZXR1cm4gdmly dF90b19tZm4odmEpOw0KPiA+Pg0KPiA+PiBBU1NFUlQoc2xvdCA+PSAwICYmIHNsb3QgPCBET01I RUFQX0VOVFJJRVMpOw0KPiA+PiBAQCAtNTcwLDcgKzU3Miw4IEBAIHZvaWQgX19pbml0IHJlbW92 ZV9lYXJseV9tYXBwaW5ncyh2b2lkKQ0KPiA+PiBpbnQgcmM7DQo+ID4+DQo+ID4+IC8qIGRlc3Ry b3kgdGhlIF9QQUdFX0JMT0NLIG1hcHBpbmcgKi8NCj4gPj4gLSByYyA9IG1vZGlmeV94ZW5fbWFw cGluZ3MoQk9PVF9GRFRfVklSVF9TVEFSVCwgQk9PVF9GRFRfVklSVF9FTkQsDQo+ID4+ICsgcmMg PSBtb2RpZnlfeGVuX21hcHBpbmdzKEJPT1RfRkRUX1ZJUlRfU1RBUlQsDQo+ID4+ICsgQk9PVF9G RFRfVklSVF9TVEFSVCArIEJPT1RfRkRUX1ZJUlRfU0laRSwNCj4gPj4gX1BBR0VfQkxPQ0spOw0K PiA+PiBCVUdfT04ocmMpOw0KPiA+PiB9DQo+ID4+IEBAIC04NTAsNyArODUzLDcgQEAgdm9pZCBf X2luaXQgc2V0dXBfZnJhbWV0YWJsZV9tYXBwaW5ncyhwYWRkcl90IHBzLA0KPiA+PiBwYWRkcl90 IHBlKQ0KPiA+Pg0KPiA+PiB2b2lkICpfX2luaXQgYXJjaF92bWFwX3ZpcnRfZW5kKHZvaWQpDQo+ ID4+IHsNCj4gPj4gLSByZXR1cm4gKHZvaWQgKilWTUFQX1ZJUlRfRU5EOw0KPiA+PiArIHJldHVy biAodm9pZCAqKShWTUFQX1ZJUlRfU1RBUlQgKyBWTUFQX1ZJUlRfU0laRSk7DQo+ID4NCj4gPiBJ dCBzZWVtcyB5b3UgcHJlZmVyIHRvIHBvaW50IF9lbmQgdG8gdGhlIGFkZHJlc3MgYWZ0ZXIgdGhl IGVuZC4gRXZlbg0KPiA+IHRob3VnaCB3ZSBnb3QgcmlkIG9mIHRoZSBtYWNybyBkZWZpbml0aW9u IG9mIF9FTkQuIEJ1dCB3ZSBkaWRuJ3QgYWdyZWUNCj4gPiBvbiBob3cgdG8gdXNlIGl0LiBGb3Ig bWUsIHdoZW4gSSBmaXJzdCBzYXcNCj4gPiAiZW5kID0gc3RhcnQgKyBMSVZFUEFUQ0hfVk1BUF9T SVpFIiBJIHN1YmNvbnNjaW91c2x5IHRoaW5rIHRoZSAtMSBpcw0KPiA+IG1pc3NpbmcgaGVyZS4g SSBldmVuIGFkZGVkIGEgY29tbWVudCwgYnV0IHJlbW92ZWQgaXQgd2hlbiBJIHJlYWNoZWQNCj4g PiB0byB0aGlzIGxpbmUgOiApDQo+ID4gTWF5IGJlIGl0J3MgYmV0dGVyIHRvIHBsYWNlIHNvbWUg Y29kZSBndWlkZSBmb3IgRU5EIGluIGNvZGUgY29tbWVudA0KPiA+IGluIHRoZSBTSVpFIGRlZmlu aXRpb24sIG90aGVyd2lzZSwgd2UgbWF5IGhhdmUgZGlmZmVyZW50IHBvaW50IGFkZHJlc3Nlcw0K PiA+IG9mIF9lbmQgZnVuY3Rpb25zLg0KPiANCj4gSSB0aGluayBpdCBpcyBxdWl0ZSBjb21tb24g dG8gaGF2ZSBzaXplIGJlaW5nIHRoZSBhY3R1YWwgc2l6ZSBhbmQgbm90IHNpemUNCj4gLTEuDQo+ IEVORCBpcyBjbGVhcmx5IHRoZSBsYXN0IGFkZHJlc3Mgb2YgdGhlIGFyZWEgYnV0IFNJWkUgc2hv dWxkIGJlIHRoZSBudW1iZXINCj4gb2YgYnl0ZXMgaW4gdGhlIGFyZWEgc28gSSB0aGluayBKdWxp ZW4gaGVyZSBpcyByaWdodC4NCj4gDQoNCk1heWJlIEkgZGlkbid0IGRlc2NyaWJlIGl0IGNsZWFy bHkgOiApDQpJIGFncmVlIHdpdGggdGhlIFNJWkUgdGhhdCBKdWxpZW4gaGFzIGRvbmUuIE15IGNv bmNlcm4gaXMgdGhhdCwgc2hvdWxkIHdlDQpuZWVkIGEgZ3VpZGUgbGluZSBmb3IgaG93IHRvIHVz ZSB0aGUgU0laRSB0byBjYWxjdWxhdGUgRU5EPw0KRm9yIGV4YW1wbGUsIGluIHRoaXMgcGF0Y2gs IEp1bGllbiBpcyB1c2luZyBFTkQ9U1RBUlQrU0laRSwgdGhlbiBFTkQgaXMNCnBvaW50aW5nIHRv IHRoZSBhZGRyZXNzIGFmdGVyIHRoZSBlbmQuIEJ1dCBmb3IgbWUsIEkgaW50ZW5kIHRvIHVzZQ0K RU5EPVNUQVJUK1NJWkUtMSwgYmVjYXVzZSBJIHdhbnQgdGhlIEVORCBwb2ludCB0byB0aGUgbGFz dCBhZGRyZXNzLg0KDQpPdmVyIHRpbWUsIHdoZW4gdGhlcmUgYXJlIGEgbG90IG9mIGdldF94eHhf ZW5kIGZ1bmN0aW9ucyBpbiB0aGUgY29kZSwNCnRoZWlyIGFjdHVhbCBtZWFuaW5ncyB3aWxsIGJl IGRpZmZlcmVudCwganVzdCBhcyBjb25mdXNpbmcgYXMgdGhlIHByZXZpb3VzDQptYWNybyBkZWZp bml0aW9ucw0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IENoZWVycw0KPiBCZXJ0cmFuZA0KPiAN Cj4gPg0KPiA+IENoZWVycywNCj4gPiBXZWkgQ2hlbg0KPiA+DQo+ID4+IH0NCj4gPj4NCj4gPj4g LyoNCj4gPj4gLS0NCj4gPj4gMi4zMi4wDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue May 24 08:32:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:32:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336423.560735 (Exim 4.92) (envelope-from ) id 1ntPxi-0004qS-V5; Tue, 24 May 2022 08:32:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336423.560735; Tue, 24 May 2022 08:32:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPxi-0004qL-Rk; Tue, 24 May 2022 08:32:18 +0000 Received: by outflank-mailman (input) for mailman id 336423; Tue, 24 May 2022 08:32:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntPxh-0004qF-Rc for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:32:18 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 02b81a1a-db3c-11ec-837e-e5687231ffcc; Tue, 24 May 2022 10:32:14 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-48-GCnb1baRM8qQLgvBsjrHmA-1; Tue, 24 May 2022 04:32:11 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE3C73C01D91; Tue, 24 May 2022 08:32:09 +0000 (UTC) Received: from localhost (ovpn-13-156.pek2.redhat.com [10.72.13.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7602F2026D6A; Tue, 24 May 2022 08:32:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02b81a1a-db3c-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653381133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e85r4r+pHFKTSezhh+x5QBd1PQ0NIYybBUBi1C3eVdc=; b=cZmHilPa2kbOELYmoGtcqZNJVXlRK6+olA3pPYQBnreha6u82wujsso8LR6Sq0VO2/FlcI hwdNPzfrXor6YbPgrQ0tlDKVEvy5Q9xqlNXw/OWbsGg31EumM1dIWYGN9T4LTqZJofFB99 wltawbWZorc7y8PrG8vHS/FqLCieAK0= X-MC-Unique: GCnb1baRM8qQLgvBsjrHmA-1 Date: Tue, 24 May 2022 16:32:03 +0800 From: Baoquan He To: "Guilherme G. Piccoli" Cc: Petr Mladek , "michael Kelley (LINUX)" , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <20220519234502.GA194232@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 On 05/20/22 at 08:23am, Guilherme G. Piccoli wrote: > On 19/05/2022 20:45, Baoquan He wrote: > > [...] > >> I really appreciate the summary skill you have, to convert complex > >> problems in very clear and concise ideas. Thanks for that, very useful! > >> I agree with what was summarized above. > > > > I want to say the similar words to Petr's reviewing comment when I went > > through the patches and traced each reviewing sub-thread to try to > > catch up. Petr has reivewed this series so carefully and given many > > comments I want to ack immediately. > > > > I agree with most of the suggestions from Petr to this patch, except of > > one tiny concern, please see below inline comment. > > Hi Baoquan, thanks! I'm glad you're also reviewing that =) > > > > [...] > > > > I like the proposed skeleton of panic() and code style suggested by > > Petr very much. About panic_prefer_crash_dump which might need be added, > > I hope it has a default value true. This makes crash_dump execute at > > first by default just as before, unless people specify > > panic_prefer_crash_dump=0|n|off to disable it. Otherwise we need add > > panic_prefer_crash_dump=1 in kernel and in our distros to enable kdump, > > this is inconsistent with the old behaviour. > > I'd like to understand better why the crash_kexec() must always be the > first thing in your use case. If we keep that behavior, we'll see all > sorts of workarounds - see the last patches of this series, Hyper-V and > PowerPC folks hardcoded "crash_kexec_post_notifiers" in order to force > execution of their relevant notifiers (like the vmbus disconnect, > specially in arm64 that has no custom machine_crash_shutdown, or the > fadump case in ppc). This led to more risk in kdump. Firstly, kdump is not always the first thing. In any use case, if kdump kernel is not loaded, it's not the first thing at all. Not to mention if crash_kexec_post_notifiers is specified. if kdump kernel is loaded, kdump has been executing firslty, since it was added into kenrel/panic(); Until 2014, Masa added crash_kexec_post_notifiers kernel parameter to make panic notifiers be able to execute before kdump if specified. commit dc009d92435f99498cbc579ce76bf28e837e2c14 Author: Eric W. Biederman Date: Sat Jun 25 14:57:52 2005 -0700 [PATCH] kexec: add kexec syscalls commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 Author: Masami Hiramatsu Date: Fri Jun 6 14:37:07 2014 -0700 kernel/panic.c: add "crash_kexec_post_notifiers" option for kdump after panic_notifers Changing this will cause regression. During these years, nobody ever doubt kdump should execute firstly if crashkernel is reserved and kdump kernel is loaded. That's not saying we can't change this, but need a convincing justification. Secondly, even with the notifiers' split, we can't guarantee people will absolutely add notifiers into right list in the future. Letting kdump execute behind lists by default will put kdump into risk. For example, you replied to Hatamata saying you have been working with kdump in the last 3, 4 years, and you have have been working on these panic notifiers refactoring issue in the recent months. However, in your refactoring patches of introducing hypervisor/info/pre-reboot, I noticed you acked the suggestion from Petr that several notifiers need be moved to correct position. So even you can't make sure these, how can other people be able to recognize which list should be 100% appropriate when they try to register one notifier for their sub-component? At last, I am wondering why fadump matters. I don't know in which case people wants to load kdump kernel, but expect to trigger crash fadump. Power people need consider this carefully and makes some change. Fadump just borrows the crashkernel reservation mechanism. If fadump would rather take risk to run all panic notifiers, whether fadump really needs them or not, then execute crash_fadump(), that's powerpc's business. As for Hyper-V, if it enforces to terminate VMbus connection, no matter it's kdump or not, why not taking it out of panic notifiers list and execute it before kdump unconditionally. Below is abstracted from Michael's words. https://lore.kernel.org/all/MWHPR21MB15933573F5C81C5250BF6A1CD75E9@MWHPR21MB1593.namprd21.prod.outlook.com/T/#u ======= I looked at the code again, and should revise my previous comments somewhat. The Hyper-V resets that I described indeed must be done prior to kexec'ing the kdump kernel. Most such resets are actually done via __crash_kexec() -> machine_crash_shutdown(), not via the panic notifier. However, the Hyper-V panic notifier must terminate the VMbus connection, because that must be done even if kdump is not being invoked. See commit 74347a99e73. ======= > > The thing is: with the notifiers' split, we tried to keep only the most > relevant/necessary stuff in this first list, things that ultimately > should improve kdump reliability or if not, at least not break it. My > feeling is that, with this series, we should change the idea/concept > that kdump must run first nevertheless, not matter what. We're here > trying to accommodate the antagonistic goals of hypervisors that need > some clean-up (even for kdump to work) VS. kdump users, that wish a > "pristine" system reboot ASAP after the crash. > > Cheers, > > > Guilherme > From xen-devel-bounces@lists.xenproject.org Tue May 24 08:35:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:35:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336431.560746 (Exim 4.92) (envelope-from ) id 1ntQ10-0005T2-F3; Tue, 24 May 2022 08:35:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336431.560746; Tue, 24 May 2022 08:35:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQ10-0005Sv-A3; Tue, 24 May 2022 08:35:42 +0000 Received: by outflank-mailman (input) for mailman id 336431; Tue, 24 May 2022 08:35:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQ0y-0005Sl-NJ; Tue, 24 May 2022 08:35:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQ0y-0003pi-9R; Tue, 24 May 2022 08:35:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQ0x-0002I5-RX; Tue, 24 May 2022 08:35:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntQ0x-0004dI-R7; Tue, 24 May 2022 08:35:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T2rbJG3qZLxeb921zzaNpwSf4iy5QDsGR3V1t+NqNzY=; b=G3phgNcAZzUsI+t+CSaAByq2gm fvFpyJxmldpK6RwmJgaadtugnj8emqLSqOi7ZOibjHUAHSR/BsyhSV+cLz9SrwtYporsaXSJBjjoI FF+x+MQXfYDfAnTqZuJNM2TROCggLwkDwWun5bzwYfHtgoUQ3DtW9CVQFeEpgT55P2HI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170712: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Tue, 24 May 2022 08:35:39 +0000 flight 170712 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170712/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170687 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170687 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170687 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170687 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170687 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170687 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170687 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170687 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170687 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170687 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170687 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170687 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170712 2022-05-24 01:53:07 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue May 24 08:53:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:53:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336442.560756 (Exim 4.92) (envelope-from ) id 1ntQHl-0007zQ-2o; Tue, 24 May 2022 08:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336442.560756; Tue, 24 May 2022 08:53:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQHk-0007zJ-WD; Tue, 24 May 2022 08:53:01 +0000 Received: by outflank-mailman (input) for mailman id 336442; Tue, 24 May 2022 08:52:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQHj-0007zD-An for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:52:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e896e02f-db3e-11ec-837e-e5687231ffcc; Tue, 24 May 2022 10:52:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-1SOHDyLwM6qYI0eJLKda6Q-1; Tue, 24 May 2022 10:52:55 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB9001.eurprd04.prod.outlook.com (2603:10a6:20b:408::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 08:52:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 08:52:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e896e02f-db3e-11ec-837e-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653382377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62UMJp0c4qml2nb0e3hC8MJQlTFQY/FkHKTAo1fpFPk=; b=LDEY+KrBzGNCtbBKivIq16duP0c6J/miOeUjXwSsEgY1WxySP7T0IiPQ4vol3+8VRH43CD DRRK/+Ebych1iPRz7FuKqC3fuOu62+5Oe7uoPUmYa819JPmhoL2QTcTITrEWp/Kgw75dl5 BvXf9g1VKUWVovrZd9LR3OeuJ8KPYPM= X-MC-Unique: 1SOHDyLwM6qYI0eJLKda6Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKpWvYrXjUCCWfAxi2zz7kcLj7xJqNuaLB7aKxd4D36rbcVYEHtwIbwVyFKUVvPGNowR84VzlrvTH1u9z1VoH67RfckewYO0eni72J6yem8brTkVOJ9jgQVonw2BPVX4oe9Od5CNb+luYhL3JJpnx9b8Wy9GN67y0Sc9oOuKrGB90Q0zg+ED+kSfC0kCI2pEYcRTrdMD/+DLlVq4VG0oIUnGc0i8mONuZLnLz2t2aHK7A8J9wjyAIrHunnqPijxECsWHtC563/qzju/jP7OAVsVeAttf3foM7PGBzjZ0TuPqeDi8iT7SneBXXU1I+dLbA1CuYKhjkotBqBmp7NK/SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JYhlPfxJU8JWZKcAUbgUoEi7RGSaKhIV1YsDbm84Vpc=; b=ZCwJrr2ML3KVZfoByFJGNcNoNLgqaZwmsnwRT9a1TVqL82zhHz7CgFs9SB7ueS/RZSkncfifLMRJeR0GLDWYxsfKjDjZw6n0dxQZy/JO5rV/e5GL7tzbs9kGJUvxR1hZLpztCjIxUcvD2hrg2PmpdUXEoUZF1LbaQHOIITrfq5XsxYZamGWpS2gosW2mGoLF701DwKYZM7+lwzzwDpfNNeXDgBRrb1zi+fnQoNacue1lrwpUpHwF16J4jFoobIryYbtOkmabMZJy/eVw1vpfFaJ2JGd6uE224Wi4Uz3er4XmXmv5j11Vca6OLEGl3YlHdB2qvwSHLkjT5X3Eh7fzBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c502e5f-9458-0194-0254-47ce39142df7@suse.com> Date: Tue, 24 May 2022 10:52:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 5/6] tools: Use new byteswap helper Content-Language: en-US To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= CC: Wei Liu , Anthony Perard , Juergen Gross , "xen-devel@lists.xenproject.org" References: <7312f3ee-bd0e-9183-922d-c9c82cd003db@suse.com> <75055009-5053-0d4f-9174-3dd69add7c8a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f00e96b3-30cc-4b3e-755e-08da3d62ca72 X-MS-TrafficTypeDiagnostic: AM9PR04MB9001:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sWIS38VucSOiWq70W0D+e3S9m4g7Z9c3TvpUmvFLnTmItQH8IiziH5Tbw7rZblrowl6LhHDh6MmK7vBRU0f2/+WW2KcY1xpkVKV11QeZMcTl+uITnw54dnHsUxYyHJhEmwyyRuRYyibSNfoiwX5rVBm7C6FK6M1nkNLMVzd3znzucagaMRKdUPp+Sr8gpeyVjcjdYu/GgJ2yt5ZhK5rW3wmCiKkqZ0GiiW7x8WTQDiYW7PrYl9HX1i1EBxYkCQgUFx1Ikv3lvuSGZDs8o9TvRzH3rnzQrqdj+nrau6ImelnZUlaoVCzo6RPXA2UQ4+lzb3PIgwFMpShNEg5E/k3D6QpEPGkbgxEtPRQeZ6cIGLxu6m8NryFeyE9h7/dU5Tr6Z9IwhBHU1u2jNVFEgy6uglVZwzJc7xPHK56XcfG55OH46fv6P6nJCbmBRV7tniW+xxq1HE4tLW9vy2MZ4rl48IggqbsJ6h2hDNCQ1rYXFhWFXn1QZfH4IhkZH9n4JkvWpxej+R1/j3sDHnooXqeRDfjJqDcPKzrgwPMXpJYAVveW8x8EquSu9dgPk7fFz0xpIYYCy42y23UW3TtsPMkVB9U7Xg+UfG4CpIrB6QxULemeh+QIyATR5rolFY1aQsb1OA6CtlnN8/rGs4XhPeLWquK9myKeLAUKTC3ul+jrE+tbx8envx6dClBP0VDQHEYn2aGjpDjhg2Fm60dSmHeo7zHvJZDTVMjIdlVyU553OZjl92y3W8xy1BUk/yigC2+D X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(8676002)(4326008)(31686004)(186003)(83380400001)(86362001)(8936002)(36756003)(2906002)(5660300002)(66946007)(316002)(66556008)(66476007)(6486002)(6512007)(2616005)(54906003)(6506007)(53546011)(26005)(508600001)(38100700002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g1qyxV48VjMwaIcCirDTkkYdAH0yPvTtTBGkLxmw7McfEXKIYox8nEEhvZ8f?= =?us-ascii?Q?q6DlGWS8RTqfR2y6O/xVwf5tCyVvHGrDiihskUVgwVNRTdTSjNIOBLEYYD27?= =?us-ascii?Q?0I+EPuzyKrNooTZafqfVbWtcsCQGcY95E5kMgjAkIY2iTIgbRd3ClEvpaw9L?= =?us-ascii?Q?v8xmTpz4kXd/HTAYI4uvJwRmuOYyjMXeEQ0iu8uZfHCO/uMYy2jC0mftIRBC?= =?us-ascii?Q?ZWl6fbL2eXQw1DrS+ks9250qNAYNduNJh/mZLZ8+dU/TTrorpmabZDQQkLUE?= =?us-ascii?Q?ZBh1oI3qvl1DHyZaGXGsao5E9HXle5pTKw2hiYI6CBsT6Kh/py4mFfBw/XMv?= =?us-ascii?Q?Ygf2ie5TDLoUYkTh46xj/Pl56XB3FVmpbDPPLqSLxuJVItCSik8IPH/ABIfI?= =?us-ascii?Q?SnMXvIegAG1dR5BUL/k4fq6phu80KiVmJye/Ox2PIZmkoWeYiq1a5Z533e6E?= =?us-ascii?Q?/fxxk9wCzuwcsn+ch3flss+t847NLBvEDZrn3xEHwwllD0klLfHbYB4crDQF?= =?us-ascii?Q?p/jDHrbx6gPylQ+NnK8aucuAL4LxamRJc1j+vHE7Dqi3QLEcUjUfb6wxApJO?= =?us-ascii?Q?EwPT9xIJ/f4GJRqFiWakHx0UC/HynDZcyQCwbd5CAN+Z/JlBnNC6XiDi8rRx?= =?us-ascii?Q?46EL+zrNq2GjEoBOsbWG55QuqJop+AndR8cPhG7AhgvfWf9kTS0FmNJjGs3G?= =?us-ascii?Q?h4pXCq2EMHkqhTU52wSjfZ5Chc5afmKR5y1KfVyQcWpQSEI3Ly34ZMPaR83S?= =?us-ascii?Q?PiuzXMsfP0/Hqa4fFQ+2baFbEnP/TZMIci6Zci9YYNAPpFbZefN6eYujPpdJ?= =?us-ascii?Q?mWY35l3rryVVjKdkEjzxDaHVphuEw9aMIk73E0xb04h2qFZgaSkujt5amulG?= =?us-ascii?Q?NvqsoskLszrvCt3SIHCGYF12gU2r6XpM9Ab25UeX4sEATqDm/IWG1wY1/0rl?= =?us-ascii?Q?RXAPkMSZZlbq8Ifyw1I0wAoIWcMSgRi2VEV+p2+KaIxteN9Y1hNc8LttuLbk?= =?us-ascii?Q?hL7mD8g7kHqHQfJUkfNQvQsk6tfUPKHhyCS44/RQCVij/wkqDn/C5u5HRw9N?= =?us-ascii?Q?iBJ/vp0P6cigNMJe1RhntsTuRDzXf0YdkhEE5rDxCqGyEc3GnOla3OXLM+AZ?= =?us-ascii?Q?q8f8hGE0Yur+7ZwTzDPgU4AAkXmE9qrXoBlq7CJJcuxJZfDXvj6s48Dvzhcd?= =?us-ascii?Q?uvxmgr1LnUZutvgyp7GIjBqd5Ga1NxcKcZREYKyY5gMMLOwaIqYB3KbrtmDb?= =?us-ascii?Q?kR7ymaijpyDhztJI0z+xPWuw/H8it6KFJw70sWjvq6TR+pHGJZDMVhXiuztd?= =?us-ascii?Q?zad4lEo8I/nBvSGOcVXxyCqwcitvIIBqSZlEK6T5AVeiNg+cSLW8ktK41VmB?= =?us-ascii?Q?s5Qip6tGQngYqO08xfmT7/3fc7vGFW5H5RIoUp45jTbpSqcss2aOGAfjAE8w?= =?us-ascii?Q?K3sRX4/umD7vHuwBV+OPDo9bJ31aCzWT2yDQD2sQUlae56iyxP++AS/LxnTh?= =?us-ascii?Q?Ret91rROidkO+RI1qj1xL8w0DyJ31o44dva/BuZL3uM4G0aCnGDqWWZH8XTP?= =?us-ascii?Q?hl3carhB2Llnq6dMlHsmUnabcfPjvVpsTLWMDIn16zqvW9fK5viHurpZl1YM?= =?us-ascii?Q?FllQ+1S77omNBD1p4hkTgk29J6GPCqhTorfo3hFZFm9WuUWvbAj7vro/geFU?= =?us-ascii?Q?rQe9uV9uLLA0ss4VyNBuiEhk5yxg3b1YibpT/t3ijsZr/vAaoasrJLg7KAbV?= =?us-ascii?Q?zuk8p8H5qw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f00e96b3-30cc-4b3e-755e-08da3d62ca72 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 08:52:54.0497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FAXlFUDlITcZZLt8RE20SUadYvrLIrZPykj7Wblb/nSprP9DYTrzLexv/bYAiZncxjY1c7laPHri0WbLyWrq8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB9001 On 24.05.2022 09:17, Lin Liu =EF=BC=88=E5=88=98=E6=9E=97=EF=BC=89 wrote: >>>>> On 23.05.2022 11:52, Lin Liu wrote: >>>>>>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>>>>>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c >>>>>>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p) >>>>>>> return cpu_to_le32(*p); >>>>>>> } >>>>>>> >>>>>>> +static inline u32 le32_to_cpu(u32 val) >>>>>>> +{ >>>>>>> + return le32_to_cpup((const u32 *)&val); >>>>>>> +} >>>>>> >>>>>> Why the cast? And why not uint32_t? >>>>>> >>>>>> Jan >>>>> >>>>> le32_to_cpup has following prototye and definition >>>>> >>>>> static inline u32 le32_to_cpup(const u32 *p) >>>>> { >>>>> return cpu_to_le32(*p); >>>>> } >>>>> >>>>> xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep c= onsistent >>>>> typedef uint32_t u32; >>>> >>>> This answers neither part of my question. For u32 vs uint32_t, please >>>> also see ./CODING_STYLE. >>> >>> Type cast is unnecessary, will be removed in next version of patch >>> CODING_STYLE encourage uint32_t instead of u32, >>> However, Current xg_dom_decompress_unsafe_xz.c already use u32 instead = of unit32_t, so I >>> use u32 to keep censistent, otherwise, the code look strange >> >> Strange or not, that's the only way to phase out certain things without >> using gigantic patches / series touching the entire tree at one time. >> New code should not use these deprecated (for our purposes) types >> anymore. Note how the file you adjust here already has to introduce >> these type aliases for things to build. These typedefs really want to >> go away, and any new use of those types is another hindrance in doing >=20 > well, you convinced me to use uint32_t instead of u32. > However, This patch will not update other u32(s) to get focus. Of course, that's fine. > I can raise another patch to update parts if necessary. FTAOD: This would certainly be appreciated, but is by no means a requirement here. Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 08:58:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 08:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336450.560768 (Exim 4.92) (envelope-from ) id 1ntQNH-0000Dw-P7; Tue, 24 May 2022 08:58:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336450.560768; Tue, 24 May 2022 08:58:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQNH-0000Dp-L5; Tue, 24 May 2022 08:58:43 +0000 Received: by outflank-mailman (input) for mailman id 336450; Tue, 24 May 2022 08:58:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQNG-0000Dj-F7 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 08:58:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQNG-0004CQ-2m; Tue, 24 May 2022 08:58:42 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntQNF-00031Q-Sk; Tue, 24 May 2022 08:58:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yUFvOZsBAYd/S1QmUNeocJgopa2THC7rTOTfgT3dz5U=; b=ZuKxGzjImQkcLAbp1nZyZBRiIG ZHvVtdzl56YEijHXrsjxAwFNotnxWFf+yC03kRvsUBzfvn+jAiRIdzoCYKNv2BSaukoVmS7jobEri 98WxtXCtdHR8sPk/L14ufhvQ9hZ0v+Z7rhxxFKqNqaXCurhTxC5GVJvWg0PQcfMhODog=; Message-ID: <4d2a550b-feb8-0a61-1742-dfa3489b9b5b@xen.org> Date: Tue, 24 May 2022 09:58:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure To: Wei Chen , xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-11-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24/05/2022 03:11, Wei Chen wrote: > Hi Julien, Hi Wei, >> diff --git a/xen/arch/arm/include/asm/pmap.h >> b/xen/arch/arm/include/asm/pmap.h >> new file mode 100644 >> index 000000000000..74398b4c4fe6 >> --- /dev/null >> +++ b/xen/arch/arm/include/asm/pmap.h >> @@ -0,0 +1,32 @@ >> +#ifndef __ASM_PMAP_H__ >> +#define __ASM_PMAP_H__ >> + >> +#include >> + >> +#include >> + >> +static inline void arch_pmap_map(unsigned int slot, mfn_t mfn) >> +{ >> +    lpae_t *entry = &xen_fixmap[slot]; >> +    lpae_t pte; >> + >> +    ASSERT(!lpae_is_valid(*entry)); >> + > > Sometimes it is very difficult for me to determine whether to > use ASSERT or fixed check in this situation. In debug=n config, > is there any risk of pte override of arch_pmap_map should be > prevented? There is always a risk :). In this case, this would be a programming error if the slot contains a valid entry. Hence why an ASSERT() (They tend to be use for programming error). > IMO, it's better to provide a return value for this > function and use a fixed check here. As I wrote above, arch_pmap_map() is not meant to be called in such situation. If we return an error, then there are a lot more churn necessary (pmap_map() would now need to return NULL...) for something that is never meant to happen. > >> +    pte = mfn_to_xen_entry(mfn, PAGE_HYPERVISOR_RW); >> +    pte.pt.table = 1; >> +    write_pte(entry, pte); >> +} >> + >> +static inline void arch_pmap_unmap(unsigned int slot) >> +{ >> +    lpae_t pte = {}; >> + > > We have checked lpae_is_valid() in arch_pmap_map. So can we add a > !lpae_is_valid check here and return directly? The code below can work with invalid entry and this function is not meant to be called in such case. So to me this is sounds like an unnecessary optimization. >> +void __init pmap_unmap(const void *p) >> +{ >> +    unsigned int idx; >> +    unsigned int slot = virt_to_fix((unsigned long)p); >> + >> +    ASSERT(system_state < SYS_STATE_smp_boot); >> +    ASSERT(slot >= FIXMAP_PMAP_BEGIN && slot <= FIXMAP_PMAP_END); >> +    ASSERT(in_irq()); >> + > > Why this condition is in_irq? This should be !in_irq(). > Is it for TLB operation in arch_pmap_unmap? No. pmap_{map, unmap} are not re-entreant. So we have two choices here: 1) Forbid the helpers to be used in IRQ context 2) Use local_irq_{disable, enable} I originally used the caller but given that are no users in IRQ contexts, I went with 1. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 24 09:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 09:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336458.560778 (Exim 4.92) (envelope-from ) id 1ntQaY-0002eM-U9; Tue, 24 May 2022 09:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336458.560778; Tue, 24 May 2022 09:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQaY-0002eF-Qx; Tue, 24 May 2022 09:12:26 +0000 Received: by outflank-mailman (input) for mailman id 336458; Tue, 24 May 2022 09:12:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQaX-0002e9-VA for xen-devel@lists.xenproject.org; Tue, 24 May 2022 09:12:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntQaX-0004Si-0i; Tue, 24 May 2022 09:12:25 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntQaW-00046J-OZ; Tue, 24 May 2022 09:12:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MzH95oDZYTsAKKn6ZcxU+KBX1+vhfMcysbq/pqPhNSg=; b=BEUREnV7mCTYpfMqwwxuOVC6VM 45T5n6VL8L6bcGemO9rBivv8sy3pUgQQn7FMf6NMT+MqhCxOW7sOm6Cf6YggIYF9j7tGCFVJdDano 1m1zAZjt37HIoHQ5uedKtWiTzaJALRB+8eZPY4gkiscwe+EsVFrVz+sFftgQXv1ePnpU=; Message-ID: <83c37d80-50fe-a68a-e0c0-529588b2e842@xen.org> Date: Tue, 24 May 2022 10:12:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] xen/arm: Remove most of the *_VIRT_END defines To: Wei Chen , Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall References: <20220523194953.70636-1-julien@xen.org> <21E706F6-0625-489B-AA19-278B58CD3537@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 24/05/2022 09:16, Wei Chen wrote: >>> It seems you prefer to point _end to the address after the end. Even >>> though we got rid of the macro definition of _END. But we didn't agree >>> on how to use it. For me, when I first saw >>> "end = start + LIVEPATCH_VMAP_SIZE" I subconsciously think the -1 is >>> missing here. I even added a comment, but removed it when I reached >>> to this line : ) >>> May be it's better to place some code guide for END in code comment >>> in the SIZE definition, otherwise, we may have different point addresses >>> of _end functions. >> >> I think it is quite common to have size being the actual size and not size >> -1. >> END is clearly the last address of the area but SIZE should be the number >> of bytes in the area so I think Julien here is right. >> > > Maybe I didn't describe it clearly : ) > I agree with the SIZE that Julien has done. My concern is that, should we > need a guide line for how to use the SIZE to calculate END It is not possible to have a guideline at the moment because we are not consistent how "END" is defined in Xen. This is also why I want to get rid of "END" completely. It is more difficult (to not say impossible) to interpret (start, size) differently. As I wrote in the commit message, I haven't yet addressed the common part (there work is a lot more consequent). But I wanted at least to start to get rid of some and push the use of "end" as far as possible. > For example, in this patch, Julien is using END=START+SIZE, then END is > pointing to the address after the end. But for me, I intend to use > END=START+SIZE-1, because I want the END point to the last address. Same here. > > Over time, when there are a lot of get_xxx_end functions in the code, > their actual meanings will be different, just as confusing as the previous > macro definitions My plan is to get rid of get_XXX_end completely and instead return start, size. This is only the first part of the work. I need this one start reshuffling the memory layout because I want to be able to use (start, size) consistently in the layout. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 24 10:18:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 10:18:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336468.560790 (Exim 4.92) (envelope-from ) id 1ntRbp-0000ju-Uf; Tue, 24 May 2022 10:17:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336468.560790; Tue, 24 May 2022 10:17:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRbp-0000jn-Rc; Tue, 24 May 2022 10:17:49 +0000 Received: by outflank-mailman (input) for mailman id 336468; Tue, 24 May 2022 10:17:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRbo-0000jd-IH; Tue, 24 May 2022 10:17:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRbo-0005eE-DJ; Tue, 24 May 2022 10:17:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRbn-0004yn-RX; Tue, 24 May 2022 10:17:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntRbn-0003Td-R6; Tue, 24 May 2022 10:17:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HrJvTv8Me4qC1kHh/ilQ19JnyQqMT2Hp+ve1w/wMLKU=; b=z7aMb4OIkyLg8gXe3qKJaTok81 oaEBE49zGjDioSwzrelNpd0wfbHMrybTUcvMl0uEJSZgvI8s4dMblUMJoeQ1b0Khnvv+6nXP+j0On NFYqDPz08HgOqnvadTc3qG8wgdzmu+6cEoixe1DXi+D57QAsujCbmpmbb+IdZh6MIgeo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170715: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a46ff977621aef81ec0490181004b6b614b9b7bb X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 24 May 2022 10:17:47 +0000 flight 170715 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170715/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt a46ff977621aef81ec0490181004b6b614b9b7bb baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 683 days Failing since 151818 2020-07-11 04:18:52 Z 682 days 664 attempts Testing same since 170715 2022-05-24 04:19:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 109323 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 24 10:19:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 10:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336479.560801 (Exim 4.92) (envelope-from ) id 1ntRdJ-0001Mm-I4; Tue, 24 May 2022 10:19:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336479.560801; Tue, 24 May 2022 10:19:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRdJ-0001Mf-DX; Tue, 24 May 2022 10:19:21 +0000 Received: by outflank-mailman (input) for mailman id 336479; Tue, 24 May 2022 10:19:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntRdH-0001MT-PD for xen-devel@lists.xenproject.org; Tue, 24 May 2022 10:19:19 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2005299-db4a-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 12:19:09 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-13-cdRBusv8OiWHr2Ge-bjGGw-1; Tue, 24 May 2022 06:19:03 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7889A101A52C; Tue, 24 May 2022 10:19:00 +0000 (UTC) Received: from localhost (ovpn-13-156.pek2.redhat.com [10.72.13.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2727240E7F0C; Tue, 24 May 2022 10:18:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2005299-db4a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653387547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5hjdGDxm/5eb7UZfehykEkfZZM041fRa5GaKQ9lwQHI=; b=QP8XEYiQpdw2m0Bi+5HKhlIdXybjK9P1gUFNMesuon6e+ubvn8Qi0JmCA+ryrBhx53bB41 SXSlee0wBwakyjVXOKPgHbVTMQdytwlA+tWVxpuRIF6ZjoMTlmmQcRI6uCba4HMW8Iaz4S TYJxJPpcYQqI6/8NAsJ/q5uMbQ5W7AE= X-MC-Unique: cdRBusv8OiWHr2Ge-bjGGw-1 Date: Tue, 24 May 2022 18:18:55 +0800 From: Baoquan He To: Petr Mladek Cc: "Guilherme G. Piccoli" , "michael Kelley (LINUX)" , Dave Young , d.hatayama@jp.fujitsu.com, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org Subject: Re: [PATCH 24/30] panic: Refactor the panic path Message-ID: References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <20220519234502.GA194232@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 On 05/24/22 at 10:01am, Petr Mladek wrote: > On Fri 2022-05-20 08:23:33, Guilherme G. Piccoli wrote: > > On 19/05/2022 20:45, Baoquan He wrote: > > > [...] > > >> I really appreciate the summary skill you have, to convert complex > > >> problems in very clear and concise ideas. Thanks for that, very useful! > > >> I agree with what was summarized above. > > > > > > I want to say the similar words to Petr's reviewing comment when I went > > > through the patches and traced each reviewing sub-thread to try to > > > catch up. Petr has reivewed this series so carefully and given many > > > comments I want to ack immediately. > > > > > > I agree with most of the suggestions from Petr to this patch, except of > > > one tiny concern, please see below inline comment. > > > > Hi Baoquan, thanks! I'm glad you're also reviewing that =) > > > > > > > [...] > > > > > > I like the proposed skeleton of panic() and code style suggested by > > > Petr very much. About panic_prefer_crash_dump which might need be added, > > > I hope it has a default value true. This makes crash_dump execute at > > > first by default just as before, unless people specify > > > panic_prefer_crash_dump=0|n|off to disable it. Otherwise we need add > > > panic_prefer_crash_dump=1 in kernel and in our distros to enable kdump, > > > this is inconsistent with the old behaviour. > > > > I'd like to understand better why the crash_kexec() must always be the > > first thing in your use case. If we keep that behavior, we'll see all > > sorts of workarounds - see the last patches of this series, Hyper-V and > > PowerPC folks hardcoded "crash_kexec_post_notifiers" in order to force > > execution of their relevant notifiers (like the vmbus disconnect, > > specially in arm64 that has no custom machine_crash_shutdown, or the > > fadump case in ppc). This led to more risk in kdump. > > > > The thing is: with the notifiers' split, we tried to keep only the most > > relevant/necessary stuff in this first list, things that ultimately > > should improve kdump reliability or if not, at least not break it. My > > feeling is that, with this series, we should change the idea/concept > > that kdump must run first nevertheless, not matter what. We're here > > trying to accommodate the antagonistic goals of hypervisors that need > > some clean-up (even for kdump to work) VS. kdump users, that wish a > > "pristine" system reboot ASAP after the crash. > > Good question. I wonder if Baoquan knows about problems caused by the > particular notifiers that will end up in the hypervisor list. Note > that there will be some shuffles and the list will be slightly > different in V2. Yes, I knew some of them. Please check my response to Guilherme. We have bug to track the issue on Hyper-V in which failure happened during panic notifiers running, haven't come to kdump. Seems both of us sent mail replying to Guilherme at the same time. > > Anyway, I see four possible solutions: > > 1. The most conservative approach is to keep the current behavior > and call kdump first by default. > > 2. A medium conservative approach to change the default default > behavior and call hypervisor and eventually the info notifiers > before kdump. There still would be the possibility to call kdump > first by the command line parameter. > > 3. Remove the possibility to call kdump first completely. It would > assume that all the notifiers in the info list are super safe > or that they make kdump actually more safe. > > 4. Create one more notifier list for operations that always should > be called before crash_dump. I would vote for 1 or 4 without any hesitation, and prefer 4. I ever suggest the variant of solution 4 in v1 reviewing. That's taking those notifiers out of list and enforcing to execute them before kdump. E.g the one on HyperV to terminate VMbus connection. Maybe solution 4 is better to provide a determinate way for people to add necessary code at the earliest part. > > Regarding the extra notifier list (4th solution). It is not clear to > me whether it would be always called even before hypervisor list or > when kdump is not enabled. We must not over-engineer it. One thing I would like to notice is, no matter how perfect we split the lists this time, we can't gurantee people will add notifiers reasonablly in the future. And people from different sub-component may not do sufficient investigation and add them to fulfil their local purpose. The current panic notifers list is the best example. Hyper-V actually wants to run some necessary code before kdump, but not all of them, they just add it, ignoring the original purpose of crash_kexec_post_notifiers. I guess they do like this just because it's easy to do, no need to bother changing code in generic place. Solution 4 can make this no doubt, that's why I like it better. > > 2nd proposal looks like a good compromise. But maybe we could do > this change few releases later. The notifiers split is a big > change on its own. As I replied to Guilherme, solution 2 will cause regression if not calling kdump firstly. Solution 3 leaves people space to make mistake, they could add nontifier into wrong list. I would like to note again that the panic notifiers are optional to run, while kdump is expectd once loaded, from the original purpose. I guess people I know will still have this thought, e.g Hatayama, Masa, they are truly often use panic notifiers like this on their company's system. From xen-devel-bounces@lists.xenproject.org Tue May 24 10:49:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 10:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336487.560811 (Exim 4.92) (envelope-from ) id 1ntS63-0005qJ-R1; Tue, 24 May 2022 10:49:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336487.560811; Tue, 24 May 2022 10:49:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntS63-0005qC-Ni; Tue, 24 May 2022 10:49:03 +0000 Received: by outflank-mailman (input) for mailman id 336487; Tue, 24 May 2022 10:49:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntS63-0005q6-87 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 10:49:03 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e8e2f87-db4f-11ec-837f-e5687231ffcc; Tue, 24 May 2022 12:49:01 +0200 (CEST) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 06:48:57 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB4996.namprd03.prod.outlook.com (2603:10b6:408:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 24 May 2022 10:48:56 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 10:48:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e8e2f87-db4f-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653389341; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+CB5XIBTxl9KpqOWXK8UUMxWOY2QOatU/TBa81i8ESI=; b=evQIjKhOn8GXslzS8bqVgiLd9svFQ3xy/kJLHPKlbm94VfNsELXQDXEQ r770cggqP6EBUKEK3tgxyn44mQloZo0ACLibJGemZ3iici82qNzYYaDyv 5Q1zsAq+p6z8zY3Xdg1ESd8aNxvRd2KX2lBKTHH+stoDscun/XVW8DWCU U=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 74553686 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:P5zaLK7emVpsYGy0/5zMigxRtEzGchMFZxGqfqrLsTDasY5as4F+v jYbXG/TbPjZM2SjLY8jaIuxo04EvZGDm9BmSQc5rC1jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjX1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS2YloDOYGSnd4RCTZiEypsFIJX2+/IdC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YHgF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IE9Q/O+/ppi4TV5BFf2eXHN8TzQOGDAuRvo0qDu mnbo3usV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/e5VafD21dFDpZMoV56IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:KIAjpaM4bcLGecBcT1P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa Dsr/Zvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolSs2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RE4GqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUITwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJunfwivZv20voz6hNOqWs19 60TJiAq4s+PvP+TZgNc9vpEvHHfFAkf3r3QRGvCGWiMp07EFTwjLOyyIkJxYiRCe41Jd0J6d 78bG8= X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="74553686" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lmemz62kWwu9+lRpPU0fvE3q8fxVBXSb6U2yTbpTsImKBSB63oxo5pxVHoPL4R9B8wxjiLfYD3whOf7a9qQp+lSVmRUi2ivJhKJrss1fIqitaxY+UGXDe4a1OIJOdo6iHi5yJAx4t0opWGrEq7Ot2l0QxUf1gw1S1CJu09DWTFgW0glKR4LeLyld75/b3c49eFUon3cK7bzBtgy0De4cug0t4vjQcC6o2RThMvuZLQXJUMjsktZMQtWjZE0gYZHYki19al0PZ+83q331Ip/P0Q8xkXDGTAYo8qoF36UnTvsBG03o36GCipwb56wOXLH0ezkKLzRDfDpnXUqQ3sghOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZkkL8uFAuJ6LjMwJxMrbILLKOgiqgw1iWo7SKl6Jy/U=; b=DVSok2xyoH3GRNA5Nsm/dsWA6rsUktd8KKulXKTU8HoRUKG5ocTuv6/sCEd1smI4wfNO40DKCXv2Hqk3HG7+FgGuPGxyv9GVxRs98r0N7yssorB0H6kXAu7CbK5hAI51oRmox0QiJB9rJn37sqHG33JjVbA9lRu4dJ6/hwhw5NuzzN4efeTKavMeRRC/ln0oLfl5Biru1CKf4F89s1zEjIZkih3qfvOJ0JD2ZqbLhx1+7IpeCG7aUU77iI++OTvExUv/mRZGSi7RBcRDhkiyDZvHeIZ9rOgUuePn14U7PKrtxcmITvQtZSm+HBB6x1Xmuv0YUQQY4LzshPUnJqRlUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZkkL8uFAuJ6LjMwJxMrbILLKOgiqgw1iWo7SKl6Jy/U=; b=liEyap+wpWFCmBAP90WT2+S+xc9hicJpnjsgymP5oT6zHHiez2vVWWFDkJfbnEezoXvdmVh44nb+7t1O32hCQOhMTaWh1lHO9zixExUOyV7MipGag8M8S9Mbqe8ghsy1bVq6jMHJdtybMzWHUajatn7hH+ib7p23TYi30AYZtcw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 24 May 2022 12:48:51 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220516143116.28602-1-roger.pau@citrix.com> <4b025fee-8f7e-1849-184e-1be8fb99442b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0429.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::33) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a371d541-9217-488b-00d2-08da3d73001b X-MS-TrafficTypeDiagnostic: BN8PR03MB4996:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GczZVGx6UJsMGFeoHP3oZshVdAf1748xO6WnjZ0jlh2xEbGQ4Vsj8YOnNyZ22rt97eUdB+fR+aMz9rKSzVfjjytVCrmqYKykJhl0IoQD5cd8CbNbpSAFbBAjRU5Z2/TNEdMKDudIRiu7jyw8TVM7g7rCULv9as/Id64thKizh3t3Gvk6+nQR8F6CN+1BdGUnmgsxb8fMIPhJloWXWE5+H0nIkg0EzUdh+jNHrsH3V6iSpOzB+aINGqUQJwUBb1mjyZbtIJcAPuquJNKn5vUPs+Q8ASYz2Ft1i3HIsa0PpbJZSYSZWmfw6Ujssw2X9a74jkfIc0yjMwlzfwrAo2wnD+1IuoIVW91iXrq09cTTpZ19nar93+hjC8bLTBBuakXTCaig50YIEYdBiLiPlEcLUMt+wc2Jh4ZZuO+ep3TY7e4sJtA8ZPv9BbEjsFTAlkyYQfxqNL3MyBCrDW+bZrvIF0jE1bMha4fV8ymAGBgWBw1sWY3HF+lveU7uQyeiGJCXbPtVWai5FPz6SYtPWqfCBfJdt67P8+xC0LOZld2MnwEjZEdqhO1n+2pYHwgG1+llApMKBG2eoFFl46DAxkub/FlIq7/z3evCBcN2/WZxOHUryfO7zuS0tDtdHEnuObJLZ5WEOpYP0zpWxp2vzSi02w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6512007)(6916009)(54906003)(186003)(83380400001)(26005)(6506007)(53546011)(9686003)(85182001)(508600001)(6486002)(8936002)(5660300002)(2906002)(66556008)(66946007)(8676002)(4326008)(66476007)(82960400001)(6666004)(33716001)(316002)(86362001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WS9wcTZ1ZWtEdjFCQWdjNWE1N2FxTGRrYUF1dVZGZ2wvM3FNcEFmK3JHR2Jw?= =?utf-8?B?R0ZTMzlzMWloL1MzL0c2Wi95NmVpYUtBd0NDd2RDWTlwYStFY1UzUzRoYTJC?= =?utf-8?B?b2gxN1NLbllZU1kwdmlJalZ5dEtBa1Y5aXA4elphTGVwTEtER3NQSU1DNitt?= =?utf-8?B?UndxQUU1YWQ0TzF0aW5VQmc1ZitpbjRPbXBPaDZDSkNPU1F6RkJrNEhGM1ll?= =?utf-8?B?czZtREtKTmIwU2ZOelZKYUxSREJGUlVTa2lRb3JLNXprL1M4SnpjWjBWVmhn?= =?utf-8?B?cUlJeWJxaHdjSWRjekFHU0VZTFQ0N1RHK051SHgzdEMzYWZTNENGWERwbEl5?= =?utf-8?B?ZUpZaUNPMlNwTXBselRKN2liNzNGcFU4VlVwMk9iWkZ1OHh2Nk9DWU5Vd1RS?= =?utf-8?B?N1dVT2Nic3QvdjhmNmFPZE03bjNIeEs2TGpHMUxjQ2dNZHlOOGdaaUJ0cWNm?= =?utf-8?B?TFN5Uy9uaG1jZGRRL3FvZU8wbGFzaHViL1hQekVlQUdnSDM1Y052SEZmMEJT?= =?utf-8?B?M3pmQkF1bDVLdzlyZHpOKzk5S3Q5SUNPZG1nbXYveExLaGg4dWtuMURSVVll?= =?utf-8?B?V3RJWlBFVWhtNStkZitNcGpzTDVoSEtGVVpsdEw5MHNnRFFUWjRHVnUzeXh4?= =?utf-8?B?MTFHUlBsWU1UMTNOS29RRi9kSUFvREFNb2Y2ODJ0TDJSdkR3RkJ5SWk4bUlp?= =?utf-8?B?c0tNM2dwOHl4T2pwZmZaNHQzV3RsbTJZQ2M0SWRtQjJlNkhONXNxMUF3ank5?= =?utf-8?B?NVZaSjk5bDI4ZlRwK0ZITEZNcEl0Qm5LQXFpNUlmOERnd1Y1b3hEOVE3d2Vh?= =?utf-8?B?ZHYzZW92eSs0d1JsdHdSV2pTWDhHMXZhUlk3ZHI1ck9Fb1QyOHJQWC9wOTNz?= =?utf-8?B?OVdFbWZ2ZzhGWWtLSk5jb0pYMnpBbmR6RzZuRTAxTkhqWGtEYmN1cng5VXRO?= =?utf-8?B?RitYSTdTVFJQbHFXY0hHYy80bzV1WnFsUWRWeUwrejA1Rll1OGtqRDQrNWtO?= =?utf-8?B?bDE5TlNJcVZlOWxqelRPSXZSNWNzL29IYTA0Tzl5RSt4Q3lWblZ6SHY0VVB5?= =?utf-8?B?N0Fvb3FscXMwTlMzdnpNbFAzLzlBN2tKWHRRVDFIS2xaWGxwelhhSHFIcFAv?= =?utf-8?B?ZnU4aTdXT1k1S3ltTXJOVmFnVklKRFhUZW4wZjVGam5MaDIwaTZLQ2FNQjQx?= =?utf-8?B?Sld3N2FDOUhCZ3hFUm1uMitHWFBVUExUTW1FZE1CNU1Gck9pRGpqU1ZsZ3k1?= =?utf-8?B?cU9vU0k1ZEVVeFpSMGJ5UDVNUFZ5akFDbVJkMEY4N2dVNyt2R0N6YVM2ZUdQ?= =?utf-8?B?a0R5S3ZzbzJoWmEwL0s1MDQydWplV3NMT1Z2bXY4V2VVdXZYblZhV0J0a1Y2?= =?utf-8?B?b2FqbUdlb0RvMzNCNmc0VVdMcFJRaEZsdm52VENkeW40WFM0QWRqTFZDejRs?= =?utf-8?B?bzhHU3pyQXdYWHZVVTZWSlZBbTEwWGZzZFIyUitCaEdoWTFzQ1d0bVpmWjdQ?= =?utf-8?B?OXM1d2tUalVvQnZRenEybkc1Q3cwdms1VGx6S0dLOHdjTGZGMHpnUFZaT09w?= =?utf-8?B?L0tlak9WR081SDBteElDMkpnWi9wNGlpOFBiQVlXMnpWb0N6TzZMZHRiQXVQ?= =?utf-8?B?NnhPZEs2TWt6ZG1yaTRNMlRST3pZM3FyamhxUXgvWklXeHl4L0RRUVFKTkNi?= =?utf-8?B?OW1hNzRuZ2p2MU51RFM2STcvRGJsc2lkMllsem5BS3ZkKzhtTW1vRmJ1cnc2?= =?utf-8?B?TGFGMElLVWlaMzd3SEo2RGJXYWVxUGRJSWF3cTNFejU1d25FOUwrTFNFcndx?= =?utf-8?B?TFl3OS8yUkN4NzFlS3F6cXlEVVlINEUvcG5IL3ptMENpdGFzc3ZGdXNOMWtk?= =?utf-8?B?TmN5allLay9aM29rajFZWndYK25BTnpSam4zRkNORU5nbGhaN3M2Sm9zRGxi?= =?utf-8?B?V3lmK2hKamJlc1g1dmExWGpXWU52MHBUS1VpelQ1R3ZoZjM4ZVg4dndva2dQ?= =?utf-8?B?eTFnOW5HcHNIa0k3N3JNR1dCNTRaQUVKMjR4YlUrOEhCMFFIbmR1SGVMejlw?= =?utf-8?B?bW9BWjA5cjNQa0JLYVoxNWI1b0p5YjBzRHdIK2ppbzFuUWpHeU1MVVdLTDhp?= =?utf-8?B?S3laZzFVUFo2aVZGSU8xS1hmTGl0NHZ3OHFPZGE1WGNEZkUxS2RCYnJ0blcv?= =?utf-8?B?dDBVM2tiME1JcWt6QzRHdGdiRUo2WUE0VVNCMENkM3hjb0p6TzhZRnBmdGlU?= =?utf-8?B?NUlPNy9UTHFaUU5IYWtMSUFRS05GSjV2QWRJOW9Ed20rL2tYYnNvVTdaSG1M?= =?utf-8?B?d1ZPTmlONzdxNHJYRWpFS1hQY2s3TnlnL3ZTUWxUb0hmNWpUdFUvZVoya3JU?= =?utf-8?Q?eGzqXrj93yxb6wWg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a371d541-9217-488b-00d2-08da3d73001b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 10:48:56.0524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EzkxdSv+Wv96GDEVR6VwLrIXU86npwFId2erxXQKZF4NVQZgb1KWNx0qqPKvS7pfi/BaUqzW3H38bRvuJjHrZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4996 On Mon, May 23, 2022 at 06:24:48PM +0200, Roger Pau Monné wrote: > On Mon, May 23, 2022 at 05:13:43PM +0200, Jan Beulich wrote: > > On 23.05.2022 16:37, Roger Pau Monné wrote: > > > On Wed, May 18, 2022 at 10:49:22AM +0200, Jan Beulich wrote: > > >> On 16.05.2022 16:31, Roger Pau Monne wrote: > > >>> --- a/xen/arch/x86/smp.c > > >>> +++ b/xen/arch/x86/smp.c > > >>> @@ -262,7 +262,8 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > > >>> { > > >>> unsigned int cpu = smp_processor_id(); > > >>> > > >>> - ASSERT(local_irq_is_enabled()); > > >>> + /* Local flushes can be performed with interrupts disabled. */ > > >>> + ASSERT(local_irq_is_enabled() || cpumask_equal(mask, cpumask_of(cpu))); > > >> > > >> Further down we use cpumask_subset(mask, cpumask_of(cpu)), > > >> apparently to also cover the case where mask is empty. I think > > >> you want to do so here as well. > > > > > > Hm, yes. I guess that's cheaper than adding an extra: > > > > > > if ( cpumask_empty() ) > > > return; > > > > > > check at the start of the function. > > > > > >>> if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && > > >>> cpumask_test_cpu(cpu, mask) ) > > >> > > >> I suppose we want a further precaution here: Despite the > > >> !cpumask_subset(mask, cpumask_of(cpu)) below I think we want to > > >> extend what c64bf2d2a625 ("x86: make CPU state flush requests > > >> explicit") and later changes (isolating uses of FLUSH_VCPU_STATE > > >> from other FLUSH_*) did and exclude the use of FLUSH_VCPU_STATE > > >> for the local CPU altogether. > > > > > > If we really want to exclude the use of FLUSH_VCPU_STATE for the local > > > CPU, we might wish to add this as a separate ASSERT, so that such > > > checking doesn't depend on !local_irq_is_enabled(): > > > > > > ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu)); > > > ASSERT(!cpumask_subset(mask, cpumask_of(cpu)) || !(flags & FLUSH_VCPU_STATE)); Actually, it would seem even more accurate to use: ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 10:51:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 10:51:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336495.560823 (Exim 4.92) (envelope-from ) id 1ntS8X-0007DR-9I; Tue, 24 May 2022 10:51:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336495.560823; Tue, 24 May 2022 10:51:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntS8X-0007DK-6S; Tue, 24 May 2022 10:51:37 +0000 Received: by outflank-mailman (input) for mailman id 336495; Tue, 24 May 2022 10:51:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntS8V-0007DE-Uo for xen-devel@lists.xenproject.org; Tue, 24 May 2022 10:51:36 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 793eb684-db4f-11ec-837f-e5687231ffcc; Tue, 24 May 2022 12:51:34 +0200 (CEST) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 06:51:31 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB4996.namprd03.prod.outlook.com (2603:10b6:408:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Tue, 24 May 2022 10:51:29 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 10:51:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 793eb684-db4f-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653389494; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=g4+j8U8TBjBAQVO7fIRSanIHLfBm1pa13uJ6y1NSEKY=; b=JsnjiBQqm0eLy/4VwDXV2v9IpC6FMURyppHIApeCTpBuW51/A1qraBok fdUSwvSwkrkXWGnRD5H10hUovGj/L26x0wUTtwsO99yawt3B1l2eWilHN SugpptPjzQgSXX0DJHmstJuy8IfqDWPS1xDfLyOW4TeOhypDmxdjCTJWv I=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 71404634 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:o3ZJG6lX/9dIEEc5reaGqALo5gz1J0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJDGzTbquLZWHwc4ojaI3i8UMD68XQn9M3QVRvqX0xECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWV/V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYEg0nP43AuLomU1pyPA15ZZMbw6GcGC3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhG9YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8Q7N+fRsvwA/yiRw4YrBEPWOR+WOQNkIxWCHg nngvELQV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN kgV8SoGtrUp+QqgSdyVdwK8iG6JuFgbQdU4LgEhwASEy66R5hnDAGEBF2ZFcIZ/7JdwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:EyIH0q+mFacnuU15s2huk+E+db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsjaKdgLNhRItKOTOLhILGFvAH0WKP+V3d8k7Fh5NgPN lbAs9D4bTLZDAV7PoSiDPIaerIq+P3lZxA692urEuEGmpRGtpdBkpCe3GmO3wzYDMDKYsyFZ Ka6MYCjz28eU4PZsD+InUeReDMq/DCiZqjOHc9dlcawTjLqQntxK/xEhCe0BtbezRTwY06+W yAtwDi/K2sv9yy1xeZ/W7O6JZ9nsfn17J4dbqxo/lQDg+pphejZYxnVbHHlDcpoNu34FJvq9 XIqwdIBbUA11rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1bkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMEjgYdq3MMiFX5uYdk99HqQ0vFnLA AuNrCW2B9uSyLXU5iD1VMfgOBFXRwIb2S7qwY5y4+oOgNt7Q9EJnsjtbAid0g7hewAouF/lo L524RT5cRzp5wtHNZA7Nloe7rHNkX9BTTxDUm1HXPLUIk6BlOlke+G3Fxy3pDjRKA1 X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="71404634" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMNMTybpOQC3ALUhEQ9X96+gp1C1R5Fcp9v6MS1Uc64D6M6GEEMeDPx6xBrR4+S01qh9rErfx0vaYQCcxBtKqRPhNTnk7dprwBm/GqjFpyPnTcquEzh5lz7XyklUOj94mtu5xBgNmwD6mKi/B8Qc4GyljBLkQO+Ds81lgeVz1qzrjubGQFKFHByyIQOnV/6G0tWnFkaQV9eAc86LjidsrpRdmz4O4GGEVqTA85fwMMVEhmqb4v2GP63NugzlIuQJLLuzBongMssByDcYWu9AOzF/w3TUi0FJ8bEx0X1A/+HMGWR3Jqun6Vg4tOImAKx4RPcpo5LY+wZQn2oraesjQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cybg82+tSXW9GZoMvvUXlCaNCT87z5QGSCbDcrZvh5Q=; b=XD4Ajtyq/NS8EwRgoxkTJTfM/mv3C2hcOU+ZIdIj98LQdiO6Tl5pJBELZ8piUKRYV4T9T+z8gVK30Jywkrvk2fdIM62EB99VBEvPlbKQ6R0HU4QUafVUjw6RwvVWV/zBYWGbL7RWamEdpAOSa3HFP1NNCO/PQEs/PJBQBebtRJb2/fXHTq5cexWKK1n9KX49WKBMY6XzAC2ZURIrRQ5UW0r6i4fWZTmjYPR7skZ5pOF/wQopIuHYrEZpv2sohEqoQRdPthry3geltS4Z679x/G4p7zUbKSVxIGI1Gpbm3WXh6Cil7lnh1La7jf3fqaX5KNOv0/fCNeD8HiSG6EtZEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cybg82+tSXW9GZoMvvUXlCaNCT87z5QGSCbDcrZvh5Q=; b=pFmY7n1JQLjkbFXLZHG0/cYuEgffa8nkiP7b2fYF5ls9NQr/XWzzNbEk6XGHptQ+GbCPIRkb6/WxEzsMTPbZAZwKsaRK9Asz423IYXVp45UxagnGaoWw5G9b4EVlug5Z8AM+2tTbIzSZAwlB+GNApJX4XIT0OtGVnDu/gJbh8zI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2] x86/flushtlb: remove flush_area check on system state Date: Tue, 24 May 2022 12:50:52 +0200 Message-Id: <20220524105052.5210-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0484.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1bf97e5-54d8-4491-f713-08da3d735baa X-MS-TrafficTypeDiagnostic: BN8PR03MB4996:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t4EmSKrWuMHdkUHfn3QySuqdE8tQXXRG09kC0WDd+PFuu54A8EHhRdgmCudiKSOuGrr18qeR+rfP0Wr+3aT2d147pWxzGNp0hNCDSkYlnkWJ580Ly13SvqasO94LNfErWDLDy6m19FFAWRZy4yN+1PWdFBAkxuOI0VxXFbUCPc+Tb6VlzIznIB9Tus8tL10XzlcvZnhRNyxB2YjXQU7ZwnEWlVzMROoqyDIhEUijmyOTrDmBo3QAQr6HKUZ0yRZXA0pOcHeELUN3fUm3fWDEIpFPDFYHmIBC1LtqP5ll9nywIRGM1zB7gk/VBubLxUK6+wkS/UIkr3Wje6krsMZY391l2vaAyEgiVyLIZew9cld8ObKeNAItsNiqFjzBRo4coB6rAQUtFG8nnKTBqSLHJUPvDB1qgLVrXPZFsHpXecjMjHmHQ6rSN6c4uRcWy2pZYf/2uDQx2CJLVgIukHPMXl+4wG3ReYV3UHzXzhmMauYyonvijt6P4EC5lEAh5kePW5odIMnefnMRffwZwGprjGaH/fVmB2U60aQC/f+3i9Lfborvnd59YI4kFmU1NfVCSa/r5LEP5pw2qpQHm4dnwso13iffL74K+ZhSuWz3pfgNdebqVnxpNQeOkk0DRArNTd5LaolvXjePZkNwqgVIXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(6916009)(54906003)(186003)(83380400001)(26005)(6506007)(2616005)(1076003)(508600001)(6486002)(8936002)(5660300002)(2906002)(66556008)(66946007)(8676002)(4326008)(66476007)(82960400001)(6666004)(316002)(86362001)(36756003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkxYVkQ1NXE3L1U4Y2YraWVhM25relFUTzFTVFZ5VXN4SmZtd2g1RWMyMUNh?= =?utf-8?B?Ylc2cS8xeUxzMTd6MEo1ZTBtU3ZvWWhqZFNGeTd4aWJid0RNVndFWjBpN3E3?= =?utf-8?B?aE9ON3Q1SzlSbGJXOWhqcDU4UlRGd3RzdjU5SVYwNkNkTGZUMDMzZmQxOG5z?= =?utf-8?B?N1c1dEdLbUp1TC9PRlRXWnkyYVNoM3Q0K0tZeVNha1c5L3p0ZmNLRmhpOEh1?= =?utf-8?B?YlR4TitNYWg4Z0RFK2FOT1ZyUDNtRGFEcmN0U1VibE5XaXhnb212dEVQYmY4?= =?utf-8?B?dld2N1FRanZOcGx6SjMrUVB3U2llYy9UVFVoVnA3Z2RqV21BRVVmLzRINFhM?= =?utf-8?B?V2w5dUQwVk8vSW84Y1NCRWt3bmN2aGdhZlJuNCtIRDRxRXJmQnRCTm13OW5M?= =?utf-8?B?NTZvYk5hYzVreGRtKzNoTFowQkhIUlZIc3krMjVMMmVoYkUwN2lDdUNVNFhI?= =?utf-8?B?U2VtUDdaS3RKeWRUZFNZZjZRUC9MQ2Z4Y3EvcTJ0bTVOYXlTMFBsQ0JtTTU0?= =?utf-8?B?TjJxMm9TL1M4UWZiNjV0TmRlRU5acnBtVlFsQlo0UFhYVEhPZm9VS3JVWkFw?= =?utf-8?B?QWwyTEErUkx4TlZoekpKUDdRaVdxcWZmWEd5SWtBak9PY0FvNFJuMzkxb0hJ?= =?utf-8?B?TmZJV3VaNG9URjI0M3dGZnNNUHB2R3VhbnBQU0JuRWk2SzN1TFlBalVLQWYy?= =?utf-8?B?Sm1BRlpId1crSlloZjVYNXJRaFllK2FkRVRtMVhvZEpxWE9IYkgwbFBjL01J?= =?utf-8?B?VWJNN2tZc1hiR1ZHZkVRd1FSR2FOTmZ0cGw5ejFhUzE0NVptUXhLS21XMTFS?= =?utf-8?B?RGxtVDh2ZHhMZGFhczBtdHZUQU9PWDBkWEcvV3hNWUxmdzFPK200NXdsOFVs?= =?utf-8?B?dXdqR2JUcUVYOVIvc2VmNFo1bWIvZ3NTZGt0UWR5c2grNEo2UW9qRFkxTWJ5?= =?utf-8?B?MTdEaTVwZDhPY1RTM1FKQldjUUFQSENKV1V2RjlDMzFDOS9MS2VIT3hxVXNo?= =?utf-8?B?RFJqSEdlTlRsbUFzY2s1Z1RkbVljRlNuZ3N3Rm43LzlLS3NvRFpWVStKeEpJ?= =?utf-8?B?em4xL2oxV1FpdWZncXk4SFh0OXc5eVFCS1JtU3ZvZGljMk5seW5NdVUrbEU1?= =?utf-8?B?d2dwZXZNK2c0Y2lldkczT0F1MGZ2RHVpL3dCbncwL1BzV1dlRWQzSmd4eXhl?= =?utf-8?B?eGNGRDUrbnJnMExIL1d2RWtObWV3SVZNaDcvaXVETHArS2VwU011ZUI2WWJN?= =?utf-8?B?cDhGb1p1OUhxc21GNE9sZ3ljckM4UzJNQ2lXU1c0SVBJVHBlL3ZTcXB5bEVq?= =?utf-8?B?eHNEOUtUODJ5QXRUenFGMHRZbUtkRDhhOXRxTUlqREd6ZjY2aE5ISmJZdGdG?= =?utf-8?B?d2NPeks3cURNU3pVcmNGSm5NWlVYNlgzSzJOV3J3ZVVCMnpnWHU3UnNnSlZM?= =?utf-8?B?UDNhK1pGa282RG1Xa3cxVmJUVGxjWElRVFQ2NG1HZ3hiam1jU2RDenRSMytH?= =?utf-8?B?V1dPVGdrY3pldU5IK0JzWWEyVjVZVDFkVkJNWklVbHhSNWpEU0MrL1JDcXF4?= =?utf-8?B?SXJJSHFwYlFMQ1hocVlka2NIanh3OE41RHh1WGQ0WlY0SkdXZ1hBQUdIMnRJ?= =?utf-8?B?R1JHVlF4bmlvRFpSNU5oT2VUcHJqek51SFFpaU1uaWNISTlnSUpFTVN0aFZC?= =?utf-8?B?ajVCNVFyRDRHTERITGZYSHdUVmU1SUJxV2xUSFoyU2NnRzFyWVMzdjR0WFRx?= =?utf-8?B?SXBhQkxPZWRsM0RDWGx4di9iYzZITjVKc1lWRGdXZUtXVGRGcG1vcVFFTW1O?= =?utf-8?B?ZUdCL1V5S2VnM3l3VExtdlJEOS9QWEtZUlhLenJyVkdmZnhsOFpodGt0YjE0?= =?utf-8?B?UlEzRFBKdTNEQmhkbXRnSmpQR3hIZW1xZkRwWUUxV3QzSHdyYzhQUU1wRU9X?= =?utf-8?B?V1JQUVVaekQ3a0trc2crYzlZY29ITitoM0JSRDNKV0gzVWtBSkFrdy9uKzkx?= =?utf-8?B?NFZ0WlRCaVE5V01FVlNVOEs3RmR3Z1dtbk8vWnZRbHUwVDlMalpMdjBXZ2RL?= =?utf-8?B?d05uWmpxQ3diYXRnWWpZK1RndzB6bHdYa0FGeWhSR1c0TzRPSnRHSTgyWE9T?= =?utf-8?B?V2U3aXRZQWRFT2Z3V2RZbkcrdm5sSThlT1F2ZmNOSWsza2xpd1ExQ2xKYVMz?= =?utf-8?B?ZWRsaW1rUFN1TUF5L29KS281MXFNU2F3V1F1cUc1b2dZdWpsNUtqU0I1eFR1?= =?utf-8?B?Zk41angwSFJWMDJ3aFBuM3ZSVHFsWWRLUEtyZXl0YXFpVlZlVzdydUhzeTJu?= =?utf-8?B?WXBKVGFNUk5mSEo2cTh4VnY3VlA4V2V0OWFleXVQK2pjVS9DSFBobGFMbkFY?= =?utf-8?Q?hRC0XxMxJbMCXzy8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1bf97e5-54d8-4491-f713-08da3d735baa X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 10:51:29.6373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q2q/F0kXFJeZ3Y9+XrQ2QbydqKZTF7035DeqEeJeZOa+Qht7P1iIBqraf04P73/mLm6oWTLa8xF694lWVTH04w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4996 Booting with Shadow Stacks leads to the following assert on a debug hypervisor: Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- CPU: 0 RIP: e008:[] flush_area_mask+0x40/0x13e [...] Xen call trace: [] R flush_area_mask+0x40/0x13e [] F modify_xen_mappings+0xc5/0x958 [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 [] F alternative_branches+0xf/0x12 [] F __start_xen+0x1ef4/0x2776 [] F __high_start+0x94/0xa0 This is due to SYS_STATE_smp_boot being set before calling alternative_branches(), and the flush in modify_xen_mappings() then using flush_area_all() with interrupts disabled. Note that alternative_branches() is called before APs are started, so the flush must be a local one (and indeed the cpumask passed to flush_area_mask() just contains one CPU). Take the opportunity to simplify a bit the logic and intorduce flush_area_all() as an alias for flush_area_mask(&cpu_online_map...), taking into account that cpu_online_map just contains the BSP before APs are started. This requires widening the assert in flush_area_mask() to allow being called with interrupts disabled as long as it's strictly a local only flush. The overall result is that a conditional can be removed from flush_area(). While there also introduce an ASSERT to check that a vCPU state flush is not issued for the local CPU only. Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to local only') Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v1: - Add an extra assert. - Rename flush_area() to flush_area_all(). --- xen/arch/x86/include/asm/flushtlb.h | 3 ++- xen/arch/x86/mm.c | 32 +++++++++++------------------ xen/arch/x86/smp.c | 5 ++++- 3 files changed, 18 insertions(+), 22 deletions(-) diff --git a/xen/arch/x86/include/asm/flushtlb.h b/xen/arch/x86/include/asm/flushtlb.h index 18777f1d4c..f0094bf747 100644 --- a/xen/arch/x86/include/asm/flushtlb.h +++ b/xen/arch/x86/include/asm/flushtlb.h @@ -146,7 +146,8 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); #define flush_mask(mask, flags) flush_area_mask(mask, NULL, flags) /* Flush all CPUs' TLBs/caches */ -#define flush_area_all(va, flags) flush_area_mask(&cpu_online_map, va, flags) +#define flush_area_all(va, flags) \ + flush_area_mask(&cpu_online_map, (const void *)(va), flags) #define flush_all(flags) flush_mask(&cpu_online_map, flags) /* Flush local TLBs */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 72dbce43b1..96d95a07cd 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5070,14 +5070,6 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) #define l1f_to_lNf(f) (((f) & _PAGE_PRESENT) ? ((f) | _PAGE_PSE) : (f)) #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f)) -/* - * map_pages_to_xen() can be called early in boot before any other - * CPUs are online. Use flush_area_local() in this case. - */ -#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ? \ - flush_area_local((const void *)v, f) : \ - flush_area_all((const void *)v, f)) - #define L3T_INIT(page) (page) = ZERO_BLOCK_PTR #define L3T_LOCK(page) \ @@ -5213,7 +5205,7 @@ int map_pages_to_xen( if ( l3e_get_flags(ol3e) & _PAGE_PSE ) { flush_flags(lNf_to_l1f(l3e_get_flags(ol3e))); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); } else { @@ -5236,7 +5228,7 @@ int map_pages_to_xen( unmap_domain_page(l1t); } } - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); for ( i = 0; i < L2_PAGETABLE_ENTRIES; i++ ) { ol2e = l2t[i]; @@ -5310,7 +5302,7 @@ int map_pages_to_xen( } if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); free_xen_pagetable(l2mfn); } @@ -5336,7 +5328,7 @@ int map_pages_to_xen( if ( l2e_get_flags(ol2e) & _PAGE_PSE ) { flush_flags(lNf_to_l1f(l2e_get_flags(ol2e))); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); } else { @@ -5344,7 +5336,7 @@ int map_pages_to_xen( for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ ) flush_flags(l1e_get_flags(l1t[i])); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); unmap_domain_page(l1t); free_xen_pagetable(l2e_get_mfn(ol2e)); } @@ -5415,7 +5407,7 @@ int map_pages_to_xen( } if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); free_xen_pagetable(l1mfn); } @@ -5430,7 +5422,7 @@ int map_pages_to_xen( unsigned int flush_flags = FLUSH_TLB | FLUSH_ORDER(0); flush_flags(l1e_get_flags(ol1e)); - flush_area(virt, flush_flags); + flush_area_all(virt, flush_flags); } virt += 1UL << L1_PAGETABLE_SHIFT; @@ -5481,7 +5473,7 @@ int map_pages_to_xen( l1f_to_lNf(flags))); if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(virt - PAGE_SIZE, + flush_area_all(virt - PAGE_SIZE, FLUSH_TLB_GLOBAL | FLUSH_ORDER(PAGETABLE_ORDER)); free_xen_pagetable(l2e_get_mfn(ol2e)); @@ -5532,7 +5524,7 @@ int map_pages_to_xen( l1f_to_lNf(flags))); if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(virt - PAGE_SIZE, + flush_area_all(virt - PAGE_SIZE, FLUSH_TLB_GLOBAL | FLUSH_ORDER(2*PAGETABLE_ORDER)); free_xen_pagetable(l3e_get_mfn(ol3e)); @@ -5784,7 +5776,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) l2e_write_atomic(pl2e, l2e_empty()); if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(NULL, FLUSH_TLB_GLOBAL); /* flush before free */ + flush_area_all(NULL, FLUSH_TLB_GLOBAL); /* flush before free */ free_xen_pagetable(l1mfn); } else if ( locking ) @@ -5829,7 +5821,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) l3e_write_atomic(pl3e, l3e_empty()); if ( locking ) spin_unlock(&map_pgdir_lock); - flush_area(NULL, FLUSH_TLB_GLOBAL); /* flush before free */ + flush_area_all(NULL, FLUSH_TLB_GLOBAL); /* flush before free */ free_xen_pagetable(l2mfn); } else if ( locking ) @@ -5837,7 +5829,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) } } - flush_area(NULL, FLUSH_TLB_GLOBAL); + flush_area_all(NULL, FLUSH_TLB_GLOBAL); #undef FLAGS_MASK rc = 0; diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c index 0a02086966..b42603c351 100644 --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) { unsigned int cpu = smp_processor_id(); - ASSERT(local_irq_is_enabled()); + /* Local flushes can be performed with interrupts disabled. */ + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))); + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && cpumask_test_cpu(cpu, mask) ) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Tue May 24 11:05:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 11:05:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336504.560834 (Exim 4.92) (envelope-from ) id 1ntSM7-0000X0-Ml; Tue, 24 May 2022 11:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336504.560834; Tue, 24 May 2022 11:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSM7-0000Wt-Jn; Tue, 24 May 2022 11:05:39 +0000 Received: by outflank-mailman (input) for mailman id 336504; Tue, 24 May 2022 11:05:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSM6-0000Wj-GU; Tue, 24 May 2022 11:05:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSM6-0006Uj-CA; Tue, 24 May 2022 11:05:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSM5-00063l-Sp; Tue, 24 May 2022 11:05:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntSM5-0007ws-SP; Tue, 24 May 2022 11:05:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4JhKSqPHcu0XcHJUB6jDwyAmdQ+0mN5+/GY1fKr3E9w=; b=qqPGz/DtnUpA1F2LtFksKzxrHm zUxTaMU51YefSzxJq1bXo65rcr/YPKFXns3Ba9NOr/CM+pGbdbttxJhE9TZ4chDFb/ppxbhkauomU mNcOUV7cJz2xg0i4+rnYvA5kqd0EKkvStv4JohVgmJwf3yBSRcX2Pw97syoplpksyd0o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170714: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d6ecaa0024485effd065124fe774de2e22095f2d X-Osstest-Versions-That: linux=1e57930e9f4083ad5854ab6eadffe790a8167fb4 From: osstest service owner Date: Tue, 24 May 2022 11:05:37 +0000 flight 170714 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170714/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170711 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170711 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170711 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170711 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170711 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170711 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170711 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170711 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux d6ecaa0024485effd065124fe774de2e22095f2d baseline version: linux 1e57930e9f4083ad5854ab6eadffe790a8167fb4 Last test of basis 170711 2022-05-23 19:39:57 Z 0 days Testing same since 170714 2022-05-24 03:27:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "yukuai (C)" Almog Khaikin Alviro Iskandar Setiawan Ammar Faizi Andi Kleen Andy Lutomirski Anna-Maria Behnsen Anuj Gupta Ard Biesheuvel Arnd Bergmann Baoquan He Bart Van Assche Boris Ostrovsky Borislav Petkov Brian Gerst Brijesh Singh Cai Huoqing Carlos Bilbao Catalin Marinas Chaitanya Kulkarni Changhui Zhong Chao Yu Chengming Zhou Christian Brauner Christian Brauner Christoph Böhmwalder Christoph Böhmwalder [drbd] Christoph Hellwig Christophe Leroy Colin Ian King Coly Li Coly Li [bcache] Damien Le Moal Dan Williams Daniel Thompson Darrick J. Wong Dave Hansen David S. Miller David Sloan David Sterba David Sterba [btrfs] Diego Viola Dmitry Osipenko # crosvm Dongli Zhang Doug Smythies Dylan Yudaken Enze Li Eric DeVolder Eric Dumazet Fanjun Kong Florian Fainelli Florian Weimer Geert Uytterhoeven Goldwyn Rodrigues Guenter Roeck Guo Ren Guoqing Jiang Hao Xu Haowen Bai Heming Zhao Ira Weiny Isaku Yamahata Jack Wang Jaegeuk Kim [f2fs] Jakob Koschel Jakub Kicinski Jan Höppner [s390] Jan Kara Jens Axboe Jiapeng Chong Joerg Roedel John Garry John Stultz Josh Poimboeuf Josh Poimboeuf Julia Lawall Kanchan Joshi Kees Cook Keith Busch Kirill A. Shutemov Krzysztof Kozlowski Kuppuswamy Sathyanarayanan Kurt Kanzenbach Kyle Smith Lad Prabhakar Lai Jiangshan Laibin Qiu Linus Torvalds Logan Gunthorpe Longpeng(Mike) Lucas Stach Lukas Bulwahn Lv Ruyi Maciej W. Rozycki Marc Zyngier Marek Szyprowski Mariusz Tkaczyk Mark Rutland Mark Rutland [arm64] Martin K. Petersen Matthieu Baerts Max Filippov Max Gurtovoy Michael Ellerman Michael Ellerman (powerpc) Michael Roth Michal Orzel Michal Simek Mike Snitzer Mike Travis Ming Lei Minghao Chi Muralidhara M K Nathan Rossi Naveen Krishna Chatradhi Nicholas Piggin Nikolai Zhubr Pali Rohár Pascal Hambourg Paul E. McKenney Paul Gortmaker Pavel Begunkov Peter Gonda Peter Zijlstra (Intel) Peter Zijlstra Phillip Lougher Phillip Potter Rafael J. Wysocki Randy Dunlap Ricardo Cañuelo Rob Herring Robin Murphy Ryusuke Konishi Ryusuke Konishi [nifs2] Samuel Holland Scott Wood Sean Christopherson Sean Christopherson Sebastian Andrzej Siewior Sergey Shtylyov Sherry Sun Shuai Xue Shubhrajyoti Datta Smita Koralahalli Smith, Kyle Miller (Nimble Kernel) Song Liu Stefan Roesch Stefan Roese Stephen Boyd Steve Wahl Steven Price Steven Rostedt (Google) Sven Schnelle # s390 syzbot+6479585dfd4dedd3f7e1@syzkaller.appspotmail.com tangmeng Tejun Heo Tetsuo Handa Thierry Reding Thomas Gleixner Tom Lendacky Tom Rix Tom Yan Tony Luck Tyler Hicks Uladzislau Rezki (Sony) Vasily Averin Wan Jiabing Wolfgang Bumiller Xiao Yang Xiaomeng Tong Xie Yongji Yang Yingliang Yazen Ghannam Yu Kuai YueHaibing Yury Norov Zhihao Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 1e57930e9f40..d6ecaa002448 d6ecaa0024485effd065124fe774de2e22095f2d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue May 24 11:20:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 11:20:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336514.560845 (Exim 4.92) (envelope-from ) id 1ntSZq-00027Y-U1; Tue, 24 May 2022 11:19:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336514.560845; Tue, 24 May 2022 11:19:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSZq-00027R-R6; Tue, 24 May 2022 11:19:50 +0000 Received: by outflank-mailman (input) for mailman id 336514; Tue, 24 May 2022 11:19:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntSZp-00027L-Cv for xen-devel@lists.xenproject.org; Tue, 24 May 2022 11:19:49 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a4cbde0-db53-11ec-837f-e5687231ffcc; Tue, 24 May 2022 13:19:45 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id s28so25090320wrb.7 for ; Tue, 24 May 2022 04:19:45 -0700 (PDT) Received: from horizon.home (amontsouris-681-1-27-236.w90-87.abo.wanadoo.fr. [90.87.147.236]) by smtp.gmail.com with ESMTPSA id i5-20020a05600c290500b00397381a7ae8sm1772915wmd.30.2022.05.24.04.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 04:19:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a4cbde0-db53-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGPt0T0MFxBcd/BjqjNUsvr4d51XY+PJmgSjprAWMDQ=; b=UnA2moS6CyM+EPmOmKGglmZB2XmV2J7r6hski81FP0TNZUzk+siAnsX3IgCFReWbEV G/GqEs9EcQSZL2V5BaxrM5rDL06L51g2tbOLUHUtZn1L+8T3S0W7q0CNFTac1dLArJo7 PtXDgV5/n+qkyonr9oduG1BitLhWrhAYovJHpS9v7oEKaN+91GxjIF71c1pVkpZ44iAm LkLue8gGtALJ52Km+ugDiVv8JEFTkKmwhWClNvyxOsmZB7PPWBeDzBrNcYkNTCaWPi/a q+ZpFX/ko+O4gbXalXfv6tS5DTYIH9f7lA6tNx3zE5dNm8MktJHq9ClXlJTgsG2QDz0X lWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGPt0T0MFxBcd/BjqjNUsvr4d51XY+PJmgSjprAWMDQ=; b=G7JQsPt1f0oiHsDsTJwULhXRuhA7eN1MHcHfY6prqJoTP50OxM4KVvONVkJfhtxTXg T5RjYWvJe420fyZu6PT3OVSz9nAOuYQsScTIGbr7g8QRkpOwUTwpZghqav1stT1yTxkK AXDeakt2P17GKg7R5AH15k+WmY19fISBAwVmPeirdYM2O+SRpkRpdA+0ovm1wX9D5WO1 FBFmmqI7Yv8lgfb0ADPNjPndzC3g9QGp/EQ8JOWdZnyieY27LzVvUKmL0xpxiU2qjm/O Y9GHvpyyrpZJWG+AqIEwTiZJHtegMlZWtpCwzQX/Qf/iID7QudNUWMJveNeZfkMgmocg lZvw== X-Gm-Message-State: AOAM532gvUvIQv4vHFaLMUcemkb++FKk3tDHnsnb6uEuv9/j646kogGL 40G2A78E/F8gcQQfmck9KC08/kHuc/J02g== X-Google-Smtp-Source: ABdhPJzFycfqg4WCve+xFYi4eXYhaj7uVysEJXGWKCFOhN6Nr1HkjCxQ9kIHlDLDTLBqVdBJ8Vol6w== X-Received: by 2002:adf:f6cd:0:b0:20e:673a:a3e6 with SMTP id y13-20020adff6cd000000b0020e673aa3e6mr22244017wrp.694.1653391184594; Tue, 24 May 2022 04:19:44 -0700 (PDT) From: Matias Ezequiel Vara Larsen X-Google-Original-From: Matias Ezequiel Vara Larsen To: xen-devel@lists.xenproject.org Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH] xen/docs: Document acquire resource interface Date: Tue, 24 May 2022 13:19:30 +0200 Message-Id: <324b2ea5b95ef5233202aa8eed2085c665259753.1653390261.git.matias.vara@vates.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit creates a new doc to document the acquire resource interface. This is a reference document. Signed-off-by: Matias Ezequiel Vara Larsen --- RFC: The current document still contains TODOs. I am not really sure why different resources are implemented differently. I would like to understand it better so I can document it and then easily build new resources. I structured the document in two sections but I am not sure if that is the right way to do it. --- .../acquire_resource_reference.rst | 337 ++++++++++++++++++ docs/hypervisor-guide/index.rst | 2 + 2 files changed, 339 insertions(+) create mode 100644 docs/hypervisor-guide/acquire_resource_reference.rst diff --git a/docs/hypervisor-guide/acquire_resource_reference.rst b/docs/hypervisor-guide/acquire_resource_reference.rst new file mode 100644 index 0000000000..a9944aae1d --- /dev/null +++ b/docs/hypervisor-guide/acquire_resource_reference.rst @@ -0,0 +1,337 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +Acquire resource reference +========================== + +Acquire resource allows you to share a resource between a domain and a dom0 pv +tool. Resources are generally represented by pages that are mapped into the pv +tool memory space. These pages are accessed by Xen and they may or may not be +accessed by the DomU itself. This document describes the api to build pv tools. +The document also describes the software components required to create and +expose a domain's resource. This is not a tutorial or a how-to guide. It merely +describes the machinery that is already described in the code itself. + +.. warning:: + + The code in this document may already be out of date, however it may + be enough to illustrate how the acquire resource interface works. + + +PV tool API +----------- + +This section describes the api to map a resource from a pv tool. The api is based +on the following functions: + +* xenforeignmemory_open() + +* xenforeignmemory_resource_size() + +* xenforeignmemory_map_resource() + +* xenforeignmemory_unmap_resource() + +The ``xenforeignmemory_open()`` function gets the handler that is used by the +rest of the functions: + +.. code-block:: c + + fh = xenforeignmemory_open(NULL, 0); + +The ``xenforeignmemory_resource_size()`` function gets the size of the resource. +For example, in the following code, we get the size of the +``XENMEM_RESOURCE_VMTRACE_BUF``: + +.. code-block:: c + + rc = xenforeignmemory_resource_size(fh, domid, XENMEM_resource_vmtrace_buf, vcpu, &size); + +The size of the resource is returned in ``size`` in bytes. + +The ``xenforeignmemory_map_resource()`` function maps a domain's resource. The +function is declared as follows: + +.. code-block:: c + + xenforeignmemory_resource_handle *xenforeignmemory_map_resource( + xenforeignmemory_handle *fmem, domid_t domid, unsigned int type, + unsigned int id, unsigned long frame, unsigned long nr_frames, + void **paddr, int prot, int flags); + +The size of the resource is in number of frames. For example, **QEMU** uses it +to map the ioreq server between the domain and QEMU: + +.. code-block:: c + + fres = xenforeignmemory_map_resource(xen_fmem, xen_domid, XENMEM_resource_ioreq_server, + state->ioservid, 0, 2, &addr, PROT_READ | PROT_WRITE, 0); + + +The third parameter corresponds with the resource that we request from the +domain, e.g., ``XENMEM_resource_ioreq_server``. The seventh parameter returns a +point-to-pointer to the address of the mapped resource. + +Finally, the ``xenforeignmemory_unmap_resource()`` function unmaps the region: + +.. code-block:: c + :caption: tools/misc/xen-vmtrace.c + + if ( fres && xenforeignmemory_unmap_resource(fh, fres) ) + perror("xenforeignmemory_unmap_resource()"); + +Sharing a resource with a pv tool +--------------------------------- + +In this section, we describe how to build a new resource and share it with a pv +too. Resources are defined in ``xen/include/public/memory.h``. In Xen-4.16, +there are three resources: + +.. code-block:: c + :caption: xen/include/public/memory.h + + #define XENMEM_resource_ioreq_server 0 + #define XENMEM_resource_grant_table 1 + #define XENMEM_resource_vmtrace_buf 2 + +The ``resource_max_frames()`` function returns the size of a resource. The +resource may provide a handler to get the size. This is the definition of the +``resource_max_frame()`` function: + +.. code-block:: c + :linenos: + :caption: xen/common/memory.c + + static unsigned int resource_max_frames(const struct domain *d, + unsigned int type, unsigned int id) + { + switch ( type ) + { + case XENMEM_resource_grant_table: + return gnttab_resource_max_frames(d, id); + + case XENMEM_resource_ioreq_server: + return ioreq_server_max_frames(d); + + case XENMEM_resource_vmtrace_buf: + return d->vmtrace_size >> PAGE_SHIFT; + + default: + return -EOPNOTSUPP; + } + } + +The ``_acquire_resource()`` function invokes the corresponding handler that maps +the resource. The handler relies on ``type`` to select the right handler: + +.. code-block:: c + :linenos: + :caption: xen/common/memory.c + + static int _acquire_resource( + struct domain *d, unsigned int type, unsigned int id, unsigned int frame, + unsigned int nr_frames, xen_pfn_t mfn_list[]) + { + switch ( type ) + { + case XENMEM_resource_grant_table: + return gnttab_acquire_resource(d, id, frame, nr_frames, mfn_list); + + case XENMEM_resource_ioreq_server: + return acquire_ioreq_server(d, id, frame, nr_frames, mfn_list); + + case XENMEM_resource_vmtrace_buf: + return acquire_vmtrace_buf(d, id, frame, nr_frames, mfn_list); + + default: + return -EOPNOTSUPP; + } + } + +Note that if a new resource has to be added, these two functions need to be +modified. These handlers have the common declaration: + +.. code-block:: c + :linenos: + :caption: xen/common/memory.c + + static int acquire_vmtrace_buf( + struct domain *d, unsigned int id, unsigned int frame, + unsigned int nr_frames, xen_pfn_t mfn_list[]) + { + +The function returns in ``mfn_list[]`` a number of ``nr_frames`` of pointers to +mfn pages. For example, for the ``XENMEM_resource_vmtrace_buf`` resource, the +handler is defined as follows: + +.. code-block:: c + :linenos: + :caption: xen/common/memory.c + + static int acquire_vmtrace_buf( + struct domain *d, unsigned int id, unsigned int frame, + unsigned int nr_frames, xen_pfn_t mfn_list[]) + { + const struct vcpu *v = domain_vcpu(d, id); + unsigned int i; + mfn_t mfn; + + if ( !v ) + return -ENOENT; + + if ( !v->vmtrace.pg || + (frame + nr_frames) > (d->vmtrace_size >> PAGE_SHIFT) ) + return -EINVAL; + + mfn = page_to_mfn(v->vmtrace.pg); + + for ( i = 0; i < nr_frames; i++ ) + mfn_list[i] = mfn_x(mfn) + frame + i; + + return nr_frames; + } + +Note that the handler only returns the mfn pages that have been previously +allocated in ``vmtrace.pg``. The allocation of the resource happens during the +instantiation of the vcpu. A set of pages is allocated during the instantiation +of each vcpu. For allocating the page, we use the domheap with the +``MEMF_no_refcount`` flag: + +.. What do we require to set this flag? + +.. code-block:: c + + v->vmtrace.pg = alloc_domheap_page(s->target, MEMF_no_refcount); + +To access the pages in the context of Xen, we are required to map the page by +using: + +.. code-block:: c + + va_page = __map_domain_page_global(page); + +The ``va_page`` pointer is used in the context of Xen. The function that +allocates the pages runs the following verification after allocation. For +example, the following code is from ``vmtrace_alloc_buffer()`` that allocates +the page for vmtrace for a given vcpu: + +.. Why is this verification required after allocation? + +.. code-block:: c + + for ( i = 0; i < (d->vmtrace_size >> PAGE_SHIFT); i++ ) + if ( unlikely(!get_page_and_type(&pg[i], d, PGT_writable_page)) ) + /* + * The domain can't possibly know about this page yet, so failure + * here is a clear indication of something fishy going on. + */ + goto refcnt_err; + +The allocated pages are released by first using ``unmap_domheap_page()`` and +then using ``free_domheap_page()`` to finally release the page. Note that the +releasing of these resources may vary depending on how there are allocated. + +Acquire Resources +----------------- + +This section briefly describes the resources that rely on the acquire resource +interface. These resources are mapped by pv tools like QEMU. + +Intel Processor Trace (IPT) +``````````````````````````` + +This resource is named ``XENMEM_resource_vmtrace_buf`` and its size in bytes is +set in ``d->vmtrace_size``. It contains the traces generated by the IPT. These +traces are generated by each vcpu. The pages are allocated during +``vcpu_create()``. The pages are stored in the ``vcpu`` structure in +``sched.h``: + +.. code-block:: c + + struct { + struct page_info *pg; /* One contiguous allocation of d->vmtrace_size */ + } vmtrace; + +During ``vcpu_create()``, the pg is allocated by using the per-domain heap: + +.. code-block:: c + + pg = alloc_domheap_pages(d, get_order_from_bytes(d->vmtrace_size), MEMF_no_refcount); + +For a given vcpu, the page is loaded into the guest at +``vmx_restore_guest_msrs()``: + +.. code-block:: c + :caption: xen/arch/x86/hvm/vmx/vmx.c + + wrmsrl(MSR_RTIT_OUTPUT_BASE, page_to_maddr(v->vmtrace.pg)); + +The releasing of the pages happens during the vcpu teardown. + +Grant Table +``````````` + +The grant tables are represented by the ``XENMEM_resource_grant_table`` +resource. Grant tables are special since guests can map grant tables. Dom0 also +needs to write into the grant table to set up the grants for xenstored and +xenconsoled. When acquiring the resource, the pages are allocated from the xen +heap in ``gnttab_get_shared_frame_mfn()``: + +.. code-block:: c + :linenos: + :caption: xen/common/grant_table.c + + gt->shared_raw[i] = alloc_xenheap_page() + share_xen_page_with_guest(virt_to_page(gt->shared_raw[i]), d, SHARE_rw); + +Then, pages are shared with the guest. These pages are then converted from virt +to mfn before returning: + +.. code-block:: c + :linenos: + + for ( i = 0; i < nr_frames; ++i ) + mfn_list[i] = virt_to_mfn(vaddrs[frame + i]); + +Ioreq server +```````````` + +The ioreq server is represented by the ``XENMEM_resource_ioreq_server`` +resource. An ioreq server provides emulated devices to HVM and PVH guests. The +allocation is done in ``ioreq_server_alloc_mfn()``. The following code partially +shows the allocation of the pages that represent the ioreq server: + +.. code-block:: c + :linenos: + :caption: xen/common/ioreq.c + + page = alloc_domheap_page(s->target, MEMF_no_refcount); + + iorp->va = __map_domain_page_global(page); + if ( !iorp->va ) + goto fail; + + iorp->page = page; + clear_page(iorp->va); + return 0; + +The function above is invoked from ``ioreq_server_get_frame()`` which is called +from ``acquire_ioreq_server()``. For acquiring, the function returns the +allocated pages as follows: + +.. code-block:: c + + *mfn = page_to_mfn(s->bufioreq.page); + +The ``ioreq_server_free_mfn()`` function releases the pages as follows: + +.. code-block:: c + :linenos: + :caption: xen/common/ioreq.c + + unmap_domain_page_global(iorp->va); + iorp->va = NULL; + + put_page_alloc_ref(page); + put_page_and_type(page); + +.. TODO: Why unmap() and free() are not used instead? diff --git a/docs/hypervisor-guide/index.rst b/docs/hypervisor-guide/index.rst index e4393b0697..961a11525f 100644 --- a/docs/hypervisor-guide/index.rst +++ b/docs/hypervisor-guide/index.rst @@ -9,3 +9,5 @@ Hypervisor documentation code-coverage x86/index + + acquire_resource_reference -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 24 11:22:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 11:22:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336523.560856 (Exim 4.92) (envelope-from ) id 1ntScn-0003dQ-Fb; Tue, 24 May 2022 11:22:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336523.560856; Tue, 24 May 2022 11:22:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntScn-0003dJ-CJ; Tue, 24 May 2022 11:22:53 +0000 Received: by outflank-mailman (input) for mailman id 336523; Tue, 24 May 2022 11:22:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntScl-0003dD-VD for xen-devel@lists.xenproject.org; Tue, 24 May 2022 11:22:51 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7122abd-db53-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 13:22:49 +0200 (CEST) Received: from mail-dm6nam08lp2042.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 07:22:43 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6221.namprd03.prod.outlook.com (2603:10b6:a03:3ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 11:22:39 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 11:22:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7122abd-db53-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653391369; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=M2JuA1N9OR8zm6eU6YwbpiA9m4oveJM1/JQpVnCw8WY=; b=KxvpTJYQXUml3HEPJALCG35hatjuE7RmS1kgyht7OxBeLDGWqoVFW2zh jSf+eHXvvrPRp6LRPywLiF4ESSMKWZ5YQ4/FHLVQHClevtcLtDybEAmQO jig8CFRCtDTwiwyEHmH64Uc0t9Qsf36hH7E7t4JcOKmUJweGRPoDSyMhz 8=; X-IronPort-RemoteIP: 104.47.73.42 X-IronPort-MID: 71406459 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:JOWFo6jsJc1nN6kjHKTMVxw/X161FREKZh0ujC45NGQN5FlHY01je htvX2uFPqqOZDb1fNAjOYy28EIPuZWEz9RmHFZlqn0xFiob9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnR4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YUQWO4LOp8MfaT5zUChbepdW877KJlHq5KR/z2WeG5ft69NHKRlqeKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuoQegG1YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8Q7N+/ZqsgA/yiRS77W3H8T3ZOabZusKngGJt 2vc+zTmV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWdhSN kgV8SoGtrUp+QqgSdyVdwK8iG6JuFgbQdU4LgEhwASEy66R7wPHAGEBFm5FcIZ+6JVwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:CYi1QqqUYXh3pMkCg2D/m9UaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/ Gnl7d6TnebCD0qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPwf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0amSwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7tvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WvAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa VT5fnnlbdrmG6hHjDkVjEF+q3uYp1zJGbKfqE6gL3a79AM90oJjXfxx6Qk7wI9HdwGOtx5Dt //Q9VVfYF1P7ErhJ1GdZc8qOuMexvwqEH3QRSvyWqOLtB1B1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="71406459" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EjJGWhzhkoYMAdjMJj3N12dd1PiRA0Dsgx8Ag7B7S3LGK7SuVQUyH5RmS2cWnH2nw0PZZkRMC/Qaj+SBzh/6dSS2bVXsJmXzbExm59gzOew5NMVR7EeJuFCBBckgaO/42th0Ac+VkS7gycfvp+Te7gI9m8nkuLJrY+kf49+qsI8bO+RH1qMCLvP8nK90q64nYc6G10cAX5mDG4Czv94YxRxKpF8akLtIanxsLNLXWhPBiS8tUEybj193zKPe40dhbaHYvPhUt/gwdy6ry3Dzob52xnzS6QuiJtqQnuGvsL4x3GZIWj3AAtuyX7FxlgNmTCrlHI3P8fIsyK0gKe5oQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=190ePyfk/4uCuF7tGnBdsg0JDGZmwp0H30+6B2ZVhvs=; b=cp/+cI6HarU0hypS2vUAeYSP4cRR56+kSdtOzGVwGkWE4j6FrHh2Yns+W0/YJ0NvOMjnGntia+TBw8EswftkqWcCo5OXALWkPunPC5GqhsVT5gJ76Ri+tbl+m7mBgu2QdUmq7VH0YuErz76AmqK08x9OKo2Qya834PL9bFQa5VNyKIqgwG8412pGtVFLiDLdpXF/ivLwX0qWJBJ84bu9eBL2qUBEyWOaVmDdphNRM9aBoONUahP/WjfC8/XO4tTYuZ9W1cRROqarIA861aMk48lq0Mr/0Ny9c8qeyXdPf0R5uXEjUSCfw0t+FBpk08wrVSRlblHy0ss+CXSzwKDrrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=190ePyfk/4uCuF7tGnBdsg0JDGZmwp0H30+6B2ZVhvs=; b=qs8Q9FpMpUxTFHnw/GkEgvVowG9DcPFO9etfgQ4rR0HIXe5R+ruqs9IzGoQBQ6qH/hOBFadK745mpgLUxJp1V5PspdmbufwBfi8Khw2W6eN6r/20ZMRNK3hVAV1qEQoyCzp+g5buLd2LK1L8bwsVE5j8qrY2An3w7elIxqzahxg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 24 May 2022 13:22:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jane Malalane Cc: Xen-devel , Jan Beulich , Andrew Cooper , Wei Liu Subject: Re: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID Message-ID: References: <20220518132714.5557-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220518132714.5557-1-jane.malalane@citrix.com> X-ClientProxiedBy: LO2P265CA0458.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53bf2849-8536-43be-ae7d-08da3d77b5c5 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6221:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dLbEsCADaq75WZENDKvdDZoh1CPQGyHIN+HF/E2jrEayDJg4gVTOG4GpH80B+KqecfT2/NU1Nstpf7LWNHCcMZWb80ZBBRoJRxezRiqhoGNm1cip4TvrhCQz7wKsaQaw2gXiMMsImxOPjTUnJFYTr/FRLfEIGpoKXkDyOEuwGiOP2vNp54UUR2j90vQYr9mddTuQA66+WbyKDoewNb3UrQ8yV37kTd33/30+gVQd5IoFprzrW0ReyUA6lRirwOo1nAgoGHJ5XYfKnFqwUix472FSpxc6zMRmKupZWqW3NGtUAmRJovIDRDSh8zGng3ORWoOXcVWeju2YHayq5RJ6EQR+mYEVuyD5welD5jKvw/BN3p+g4fB/gvNG4LdSdfHNI97KoetUvHbcaBsElKsfkHL/mUj+Zq2Eqs66h2q+mEXWnX4XPX/8aslv6rRo5XKYGTouTaSj0/bTD0IbgBcBL7F/l6+Lr6cpQa7biRdv50mq7KOGtUzgfRaoTJWLDGkJXsKC1zdK8hLshNVEPTv4eTlx/TbAokZt51jHAix/i7Q/3oiAWV0vgouHDrVe5F/ojcgpxp980IkLE3O74IM0HLPKR2MfSTKzSFYTpl2tucS0Xl+S6Bd5EVfCE7/MB1QcZLNgU+eWPQh6n2GIUnbWpw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(8676002)(186003)(5660300002)(66476007)(83380400001)(6512007)(8936002)(82960400001)(86362001)(54906003)(9686003)(6506007)(26005)(6636002)(316002)(33716001)(38100700002)(66556008)(2906002)(508600001)(85182001)(66946007)(4326008)(6862004)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWMrV09WTXd1cWJ3TkJuWjh4ekxiZ3NCbi9kc2dYa1d2c3ZQTXpNSFJEWjdN?= =?utf-8?B?MXVEanVaRUd4clJ5VFQxRURmS0lmMzFPd09CczBvbWpWK2x5eldiOVMzdEJ1?= =?utf-8?B?UFQ4TzRzNSt2L0dDTkxJdW82WlRQS1l6UDFiOXBrZk05T1czM0JjTVVBbnc5?= =?utf-8?B?K3NzcDI2L3RIOGFSZk1JVGR2NUtQbUpmNXB0NytPSGdtbHM5NmNleUJ2YVdN?= =?utf-8?B?eUVWUXZURVFoazVVU25JMFRoc3QrcUh1RjlmdDFVLy9tWE1tb2NVc0xkSTJB?= =?utf-8?B?OFRVYkdQdkh5S2hIZmIvZHEyM09lZk1zSlZLOEhlR2tqVVd5Yi9GVnZnSGVE?= =?utf-8?B?T2hEUDdMdEVrMitueDZVcnE0ZzQ1ZlIvYi9xU0JpWDJHdHJUMXpPejNwVzZh?= =?utf-8?B?V1ZkcmhpMlhtei9EZzJBckVEa3p0aTErZ0phOG14TWt0MngrL3pMSnlOS3Fz?= =?utf-8?B?dXcyNnRSaHNacjhEOGVRNFprZnMwdjZvUlIwUEtOOEMwbTQ0T2FVd3RKdzFV?= =?utf-8?B?ZDJOekNKWk9uWTZ0YkV5dmxESkFLWUpOQ1RPOVNVcit1UTRtTVd3bU1BWTkx?= =?utf-8?B?SzNiL002V1RlRUdZRFVWREZ4T2k2M0FLQVpKdHd4VCszWGw1YlNlcnJYT0Z6?= =?utf-8?B?WE9CcGZOVlVLc1labXNnS2tTT2JQdXcxeC8yZm1wVG5idmNnMmhsNCt5amVJ?= =?utf-8?B?UWt0ZE9ySkVXYnBJU09XT2ZMcnM4R3lEdGRSWEZCTXhOalJFRU9mWExQNVJj?= =?utf-8?B?MGZhS1FWazBvUlVBUkYvWTJvQVY1WDFucDBzV2dQd2swbk9zdjdnY3Q0L2JO?= =?utf-8?B?VHFnY3EwQlhmemhaMEpsTkZpdFhJTXYwZy9IL2FneElDQS9kOStsTys3cHlR?= =?utf-8?B?REdCc3ZqSjlFc2FOVkJBcWxJTWhrTzh0eWo1U0tJTm5qT0FIeU5pdGczNDgw?= =?utf-8?B?RTFFdzFvKzV5dEt6UmRheS9aYm16QURXTTZoL3kzZVByRkdLRERiQ1g2NHNF?= =?utf-8?B?cGZvdm1ta05GUlhkWnBYVzV2VkNlMkU0WWZFdGpJNlRiMzZGL1ZBV0ZaaXdU?= =?utf-8?B?SnNieDlzRVNnd1haNGZPR0J1ZFZ5MVovUWtPbWlRQlp6NDR2QXVndkkxVDdN?= =?utf-8?B?QXNqNGt1Z1gxNGRxcTNnWG9oRzcwdVMzNmp0RGdtQkg1cDRycFVNdDFZb3k3?= =?utf-8?B?V2E2SDR1c1lpN0RXVDJPVjNDcHcvcTdNbjV2S1F1YnAyTWJ1djhZK3lwQUd3?= =?utf-8?B?ZlAyQm5hQUd4dVJGRDc3Z1lyQ2dWdkdZZnc1a01wbUZwbmRPQWxRVHI2VUJX?= =?utf-8?B?SDBOdk9qSTZwMkNzNDJNbjEvMUR2OHdSZXMvdkQ3Z3ozTUttaEhjT0VNWUdU?= =?utf-8?B?U1FBWkRGeGgxZVJHaGhCbVU2TEpmVEN2cm9xa01WNWhaekViYnhXa2I0NUpH?= =?utf-8?B?bWgwaFp2TVFXNHFJejdXVlVUcXVzU2ZNUkcrUDIzdUtxZ1Y1SDExRlpoWjg3?= =?utf-8?B?WEh0NUVuTnJ3eFFHWG85YjRXNVdQbUxXYWxEcWJNNWMyR0NJOUdLaSt4c3kx?= =?utf-8?B?ZzlJSHhzZ3pMWDFaZTA3Z3Z1dnRDcUJjWDMxV1RBVjd2NjM0YWs0QWdCMXZ5?= =?utf-8?B?V3JNQ04rWko3eW1SVFJwclRvdXp5MENnQU9sRUVOOHNFSGV2QmJSV0VlSzNZ?= =?utf-8?B?RVRpOVJGSHpBYVpyT244L1hQSGE0U2hNYXc4QVJiaGFZOEMzejJqeW9KU2l0?= =?utf-8?B?U1JyRkNiOThpRWV3TTBLNFVKTWNFbDNmdENuYTBUY0F3V3BZVzBWTTRKeTNx?= =?utf-8?B?RklzQXVZMWdIZllzUlRoejF1WkJQZmZPbld3SzRQZy9ESGxQQ3NDQ3JyQ0gw?= =?utf-8?B?RTRZT2xoakpRK0ZTYmtWSGZIUEJPZWhzcEZ2d2tXTXBzdlJUSTQ2Wnl3TnBr?= =?utf-8?B?L1BWb3VrK2xYSmVtcGp5MHFjbGU2SDFMczdJRmNuTXFpYVlYbENjcVhGdVQx?= =?utf-8?B?dHVpdThyaW15MWcyQzhLTzk3em1mb2VHYXhVZzBRWE5MaEIwV0k2S3Q1NEJq?= =?utf-8?B?aTRITHNOcHFJV09zWW5DbUhFMWRxUHRrRUJWdno0WW5WaU52WVdkRWVxNDJS?= =?utf-8?B?a2cwR1B0b2ljTnVoYklhTXljM3cvZ3NoMncvQnJESmxnZXZCU2QyRjVjdlUw?= =?utf-8?B?cEd5TSs0U2hPSUdGaTYzSmhvckVRak1NOFRVeGlRL1VLUURaT2ZvM0l4S0xi?= =?utf-8?B?YWxFRWdDMWZzcDNxd2prL0VudnZSTmVoOXJoeTNuYXdOM0NGbUN1TUYvZFJv?= =?utf-8?B?eEN1Tzk3V0V4NWFWK3FTREU4azhnYTNlOURoWU1uN0IwOUV6Ty9JbVdnbDhB?= =?utf-8?Q?3WeEXkgO/mpU0pYs=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53bf2849-8536-43be-ae7d-08da3d77b5c5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 11:22:38.8426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sj7DFEayAMKBB0ku3wuCiVPx5EoAoe7R33UrY/jBlsiR6JI3y6vDbjkwILQHnloyebX/cuNyx3JmTh48kOwxzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6221 Subject could a little shorter I think: x86/hvm: fix upcall vector usage with PIRQs on event channels On Wed, May 18, 2022 at 02:27:14PM +0100, Jane Malalane wrote: > Have is_hvm_pv_evtchn_domain() return true for vector callbacks for > evtchn delivery set up on a per-vCPU basis via > HVMOP_set_evtchn_upcall_vector. > > is_hvm_pv_evtchn_domain() returning true is a condition for setting up > physical IRQ to event channel mappings. > > Therefore, a CPUID bit is added so that guests know whether the check > in is_hvm_pv_evtchn_domain() will fail when using > HVMOP_set_evtchn_upcall_vector. This matters for guests that route > PIRQs over event channels since is_hvm_pv_evtchn_domain() is a > condition in physdev_map_pirq(). > > The naming of the CPUID bit is quite generic about upcall support > being available. That's done so that the define name doesn't become > overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some > such. I think you can drop the "... like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some such." That's maybe too informal for a commit message log. > > A guest that doesn't care about physical interrupts routed over event > channels can just test for the availability of the hypercall directly > (HVMOP_set_evtchn_upcall_vector) without checking the CPUID bit. > > Signed-off-by: Jane Malalane Reviewed-by: Roger Pau Monné (I think the above can be fixed on commit if the committer agrees) One thing that worries me is how to differentiate between callbacks setup with HVM_PARAM_CALLBACK_TYPE_VECTOR vs using HVMOP_set_evtchn_upcall_vector in writing. We usually use 'callback vector' to refer to the former and 'upcall vector' to refer to the later. Hope that's clearer enough. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 12:42:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 12:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336532.560867 (Exim 4.92) (envelope-from ) id 1ntTr6-0003dc-JK; Tue, 24 May 2022 12:41:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336532.560867; Tue, 24 May 2022 12:41:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTr6-0003dV-EZ; Tue, 24 May 2022 12:41:44 +0000 Received: by outflank-mailman (input) for mailman id 336532; Tue, 24 May 2022 12:41:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTr4-0003dL-G3 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 12:41:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db71daf9-db5e-11ec-837f-e5687231ffcc; Tue, 24 May 2022 14:41:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 638751F91B; Tue, 24 May 2022 12:41:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D158713AE3; Tue, 24 May 2022 12:41:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id STa9MYLSjGIsYQAAMHmgww (envelope-from ); Tue, 24 May 2022 12:41:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db71daf9-db5e-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653396099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Nq8e6f4kvt4191MArCN5QGRmiKuJD49xJ37K0fCPnN8=; b=mr4YLtsg9QoC4R9USdVqdIMnC8BnrPfzLohdM5yiGV7fDP2brJD9ab0LBDZLqW/4pe6Tct heXdZ4mhGSPCvH/D7UBEHaZYl9W5VEg67tRVFPWkl2rLNysqvxrTJ8K7EIkZWPj2aL8WSU mcItI6WDNehrbAlw08k94g4b/Y9u/R4= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, v9fs-developer@lists.sourceforge.net Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Axboe , Dmitry Torokhov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Jan Beulich Subject: [PATCH] xen: switch gnttab_end_foreign_access() to take a struct page pointer Date: Tue, 24 May 2022 14:41:37 +0200 Message-Id: <20220524124137.10021-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of a virtual kernel address use a pointer of the associated struct page as second parameter of gnttab_end_foreign_access(). Most users have that pointer available already and are creating the virtual address from it, risking problems in case the memory is located in highmem. gnttab_end_foreign_access() itself won't need to get the struct page from the address again. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross --- drivers/block/xen-blkfront.c | 6 +++--- drivers/input/misc/xen-kbdfront.c | 4 ++-- drivers/net/xen-netfront.c | 7 +++---- drivers/xen/gntalloc.c | 9 +++------ drivers/xen/gntdev-dmabuf.c | 2 +- drivers/xen/grant-table.c | 8 ++++---- drivers/xen/pvcalls-front.c | 6 +++--- drivers/xen/xen-front-pgdir-shbuf.c | 2 +- drivers/xen/xenbus/xenbus_client.c | 2 +- include/xen/grant_table.h | 6 +++--- net/9p/trans_xen.c | 8 ++++---- 11 files changed, 28 insertions(+), 32 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 55e004d03ced..a88ce4426400 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1221,7 +1221,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) list_del(&persistent_gnt->node); if (persistent_gnt->gref != INVALID_GRANT_REF) { gnttab_end_foreign_access(persistent_gnt->gref, - 0UL); + NULL); rinfo->persistent_gnts_c--; } if (info->feature_persistent) @@ -1244,7 +1244,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) rinfo->shadow[i].req.u.rw.nr_segments; for (j = 0; j < segs; j++) { persistent_gnt = rinfo->shadow[i].grants_used[j]; - gnttab_end_foreign_access(persistent_gnt->gref, 0UL); + gnttab_end_foreign_access(persistent_gnt->gref, NULL); if (info->feature_persistent) __free_page(persistent_gnt->page); kfree(persistent_gnt); @@ -1259,7 +1259,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo) for (j = 0; j < INDIRECT_GREFS(segs); j++) { persistent_gnt = rinfo->shadow[i].indirect_grants[j]; - gnttab_end_foreign_access(persistent_gnt->gref, 0UL); + gnttab_end_foreign_access(persistent_gnt->gref, NULL); __free_page(persistent_gnt->page); kfree(persistent_gnt); } diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c index 1fc9b3e7007f..8d8ebdc2039b 100644 --- a/drivers/input/misc/xen-kbdfront.c +++ b/drivers/input/misc/xen-kbdfront.c @@ -481,7 +481,7 @@ static int xenkbd_connect_backend(struct xenbus_device *dev, error_evtchan: xenbus_free_evtchn(dev, evtchn); error_grant: - gnttab_end_foreign_access(info->gref, 0UL); + gnttab_end_foreign_access(info->gref, NULL); info->gref = -1; return ret; } @@ -492,7 +492,7 @@ static void xenkbd_disconnect_backend(struct xenkbd_info *info) unbind_from_irqhandler(info->irq, info); info->irq = -1; if (info->gref >= 0) - gnttab_end_foreign_access(info->gref, 0UL); + gnttab_end_foreign_access(info->gref, NULL); info->gref = -1; } diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 65ab907aca5a..8c0b9546d5a2 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1386,7 +1386,7 @@ static void xennet_release_tx_bufs(struct netfront_queue *queue) queue->tx_skbs[i] = NULL; get_page(queue->grant_tx_page[i]); gnttab_end_foreign_access(queue->grant_tx_ref[i], - (unsigned long)page_address(queue->grant_tx_page[i])); + queue->grant_tx_page[i]); queue->grant_tx_page[i] = NULL; queue->grant_tx_ref[i] = INVALID_GRANT_REF; add_id_to_list(&queue->tx_skb_freelist, queue->tx_link, i); @@ -1418,8 +1418,7 @@ static void xennet_release_rx_bufs(struct netfront_queue *queue) * foreign access is ended (which may be deferred). */ get_page(page); - gnttab_end_foreign_access(ref, - (unsigned long)page_address(page)); + gnttab_end_foreign_access(ref, page); queue->grant_rx_ref[id] = INVALID_GRANT_REF; kfree_skb(skb); @@ -1760,7 +1759,7 @@ static void xennet_end_access(int ref, void *page) { /* This frees the page as a side-effect */ if (ref != INVALID_GRANT_REF) - gnttab_end_foreign_access(ref, (unsigned long)page); + gnttab_end_foreign_access(ref, virt_to_page(page)); } static void xennet_disconnect_backend(struct netfront_info *info) diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c index 55acb32842a3..a15729beb9d1 100644 --- a/drivers/xen/gntalloc.c +++ b/drivers/xen/gntalloc.c @@ -175,8 +175,6 @@ static int add_grefs(struct ioctl_gntalloc_alloc_gref *op, static void __del_gref(struct gntalloc_gref *gref) { - unsigned long addr; - if (gref->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { uint8_t *tmp = kmap_local_page(gref->page); tmp[gref->notify.pgoff] = 0; @@ -190,10 +188,9 @@ static void __del_gref(struct gntalloc_gref *gref) gref->notify.flags = 0; if (gref->gref_id) { - if (gref->page) { - addr = (unsigned long)page_to_virt(gref->page); - gnttab_end_foreign_access(gref->gref_id, addr); - } else + if (gref->page) + gnttab_end_foreign_access(gref->gref_id, gref->page); + else gnttab_free_grant_reference(gref->gref_id); } diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c index 91073b4e4a20..940e5e9e8a54 100644 --- a/drivers/xen/gntdev-dmabuf.c +++ b/drivers/xen/gntdev-dmabuf.c @@ -524,7 +524,7 @@ static void dmabuf_imp_end_foreign_access(u32 *refs, int count) for (i = 0; i < count; i++) if (refs[i] != INVALID_GRANT_REF) - gnttab_end_foreign_access(refs[i], 0UL); + gnttab_end_foreign_access(refs[i], NULL); } static void dmabuf_imp_free_storage(struct gntdev_dmabuf *gntdev_dmabuf) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 1a1aec0a88a1..1b9b28bc3228 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -430,13 +430,13 @@ int gnttab_try_end_foreign_access(grant_ref_t ref) } EXPORT_SYMBOL_GPL(gnttab_try_end_foreign_access); -void gnttab_end_foreign_access(grant_ref_t ref, unsigned long page) +void gnttab_end_foreign_access(grant_ref_t ref, struct page *page) { if (gnttab_try_end_foreign_access(ref)) { - if (page != 0) - put_page(virt_to_page(page)); + if (page) + put_page(page); } else - gnttab_add_deferred(ref, page ? virt_to_page(page) : NULL); + gnttab_add_deferred(ref, page); } EXPORT_SYMBOL_GPL(gnttab_end_foreign_access); diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index e254ed19488f..1826e8e67125 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -238,8 +238,8 @@ static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, spin_unlock(&bedata->socket_lock); for (i = 0; i < (1 << PVCALLS_RING_ORDER); i++) - gnttab_end_foreign_access(map->active.ring->ref[i], 0); - gnttab_end_foreign_access(map->active.ref, 0); + gnttab_end_foreign_access(map->active.ring->ref[i], NULL); + gnttab_end_foreign_access(map->active.ref, NULL); free_page((unsigned long)map->active.ring); kfree(map); @@ -1117,7 +1117,7 @@ static int pvcalls_front_remove(struct xenbus_device *dev) } } if (bedata->ref != -1) - gnttab_end_foreign_access(bedata->ref, 0); + gnttab_end_foreign_access(bedata->ref, NULL); kfree(bedata->ring.sring); kfree(bedata); xenbus_switch_state(dev, XenbusStateClosed); diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c index b6433761d42c..bef8d72a6ca6 100644 --- a/drivers/xen/xen-front-pgdir-shbuf.c +++ b/drivers/xen/xen-front-pgdir-shbuf.c @@ -135,7 +135,7 @@ void xen_front_pgdir_shbuf_free(struct xen_front_pgdir_shbuf *buf) for (i = 0; i < buf->num_grefs; i++) if (buf->grefs[i] != INVALID_GRANT_REF) - gnttab_end_foreign_access(buf->grefs[i], 0UL); + gnttab_end_foreign_access(buf->grefs[i], NULL); } kfree(buf->grefs); kfree(buf->directory); diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index d6fdd2d209d3..d5f3f763717e 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c @@ -439,7 +439,7 @@ void xenbus_teardown_ring(void **vaddr, unsigned int nr_pages, for (i = 0; i < nr_pages; i++) { if (grefs[i] != INVALID_GRANT_REF) { - gnttab_end_foreign_access(grefs[i], 0); + gnttab_end_foreign_access(grefs[i], NULL); grefs[i] = INVALID_GRANT_REF; } } diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index 7d0f2f0037b8..527c9907f99c 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -101,10 +101,10 @@ int gnttab_end_foreign_access_ref(grant_ref_t ref); * Eventually end access through the given grant reference, and once that * access has been ended, free the given page too. Access will be ended * immediately iff the grant entry is not in use, otherwise it will happen - * some time later. page may be 0, in which case no freeing will occur. + * some time later. page may be NULL, in which case no freeing will occur. * Note that the granted page might still be accessed (read or write) by the * other side after gnttab_end_foreign_access() returns, so even if page was - * specified as 0 it is not allowed to just reuse the page for other + * specified as NULL it is not allowed to just reuse the page for other * purposes immediately. gnttab_end_foreign_access() will take an additional * reference to the granted page in this case, which is dropped only after * the grant is no longer in use. @@ -112,7 +112,7 @@ int gnttab_end_foreign_access_ref(grant_ref_t ref); * gnttab_end_foreign_access() are done via alloc_pages_exact() (and freeing * via free_pages_exact()) in order to avoid high order pages. */ -void gnttab_end_foreign_access(grant_ref_t ref, unsigned long page); +void gnttab_end_foreign_access(grant_ref_t ref, struct page *page); /* * End access through the given grant reference, iff the grant entry is diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index 77883b6788cd..833cd3792c51 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -279,13 +279,13 @@ static void xen_9pfs_front_free(struct xen_9pfs_front_priv *priv) grant_ref_t ref; ref = priv->rings[i].intf->ref[j]; - gnttab_end_foreign_access(ref, 0); + gnttab_end_foreign_access(ref, NULL); } free_pages_exact(priv->rings[i].data.in, 1UL << (priv->rings[i].intf->ring_order + XEN_PAGE_SHIFT)); } - gnttab_end_foreign_access(priv->rings[i].ref, 0); + gnttab_end_foreign_access(priv->rings[i].ref, NULL); free_page((unsigned long)priv->rings[i].intf); } kfree(priv->rings); @@ -353,10 +353,10 @@ static int xen_9pfs_front_alloc_dataring(struct xenbus_device *dev, out: if (bytes) { for (i--; i >= 0; i--) - gnttab_end_foreign_access(ring->intf->ref[i], 0); + gnttab_end_foreign_access(ring->intf->ref[i], NULL); free_pages_exact(bytes, 1UL << (order + XEN_PAGE_SHIFT)); } - gnttab_end_foreign_access(ring->ref, 0); + gnttab_end_foreign_access(ring->ref, NULL); free_page((unsigned long)ring->intf); return ret; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue May 24 12:43:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 12:43:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336540.560878 (Exim 4.92) (envelope-from ) id 1ntTsq-0004DL-Tk; Tue, 24 May 2022 12:43:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336540.560878; Tue, 24 May 2022 12:43:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTsq-0004DE-Qc; Tue, 24 May 2022 12:43:32 +0000 Received: by outflank-mailman (input) for mailman id 336540; Tue, 24 May 2022 12:43:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTsp-0004Cy-MY for xen-devel@lists.xenproject.org; Tue, 24 May 2022 12:43:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c7c044e-db5f-11ec-837f-e5687231ffcc; Tue, 24 May 2022 14:43:30 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-xJjodX4yMc-LC26ReejQ4A-1; Tue, 24 May 2022 08:43:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73D978041A1; Tue, 24 May 2022 12:43:24 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D4841410DD5; Tue, 24 May 2022 12:43:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c7c044e-db5f-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653396208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GvjonPMdU3Q2Eys184azXHIieZoVxARFVSVOm508iYw=; b=SKklheyTcLq1hOwqOobpWD/IbevuLhHfMiM6b2mJM69moMLWwjTaDuXcdfAX4gGKsPrvyL GHI1OsJgFt5288Biz1vm7/Iou2Bfp8zkBseX2jDp4wUEUrnT80UnPzgXi+spLWxijhHYoO mVByhiIWqj9kL9pDvfe9V0hKE4JGKiA= X-MC-Unique: xJjodX4yMc-LC26ReejQ4A-1 Date: Tue, 24 May 2022 14:43:16 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Paul Durrant , Stefano Stabellini , John Snow , Paolo Bonzini , "Michael S. Tsirkin" , xen-devel@lists.xenproject.org, qemu-block@nongnu.org, Fam Zheng , Anthony Perard , Hanna Reitz , Coiby Xu , Xie Yongji Subject: Re: [PATCH] block: get rid of blk->guest_block_size Message-ID: References: <20220518130945.2657905-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518130945.2657905-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Am 18.05.2022 um 15:09 hat Stefan Hajnoczi geschrieben: > Commit 1b7fd729559c ("block: rename buffer_alignment to > guest_block_size") noted: > > At this point, the field is set by the device emulation, but completely > ignored by the block layer. > > The last time the value of buffer_alignment/guest_block_size was > actually used was before commit 339064d50639 ("block: Don't use guest > sector size for qemu_blockalign()"). > > This value has not been used since 2013. Get rid of it. > > Cc: Xie Yongji > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin From xen-devel-bounces@lists.xenproject.org Tue May 24 12:48:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 12:48:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336548.560889 (Exim 4.92) (envelope-from ) id 1ntTxC-0004rT-Ig; Tue, 24 May 2022 12:48:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336548.560889; Tue, 24 May 2022 12:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTxC-0004rM-EM; Tue, 24 May 2022 12:48:02 +0000 Received: by outflank-mailman (input) for mailman id 336548; Tue, 24 May 2022 12:48:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntTxB-0004rG-Nk for xen-devel@lists.xenproject.org; Tue, 24 May 2022 12:48:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be6991ce-db5f-11ec-837f-e5687231ffcc; Tue, 24 May 2022 14:48:00 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-LDAEgRCaNIiuYaxYtl2O2w-2; Tue, 24 May 2022 14:47:56 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8143.eurprd04.prod.outlook.com (2603:10a6:102:1c4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 12:47:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 12:47:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be6991ce-db5f-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653396480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=piYehuOsPHEH3zcOkVaVfcREcZg+X8jXeRT8GGUo2jk=; b=GSBIBQ6vkhl6yStFvf2sxhxBJWa1hOECmRtaCOf+owHz6gUmjK+xJ+/W6BDWv99vwdzcyz UQfDF3TZOOGwaPxQWK/nExp67HXRb5+IQdpYMh/L59vHYyKF6FwVxkqKlsfKcdLTmcTxll 8dCcdB3mPLxgSp1lZ7Jsr6J0m61m0Vo= X-MC-Unique: LDAEgRCaNIiuYaxYtl2O2w-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JYp9DuZx+47WrOxKYbUYYXlc48Hn97mr25dKP584ke40vF0rL9SBDQ5CEfGB5k1Q476pdIkwjnyWVmMLOJvrnYNdW1BaMXcOauyu+VFyTyXkwSdFIs9kM5DRDPZDd8D30fqYqDldQvXtEnCq8I9IiQaH47Vf6cJ6oPCuR56hTLQfsNHcTDfQoZEIvQyrDdgX4g465cMs1yWco0E5EsPUr/zux42LNVBjb2cHLLcoQIrVOENs5BHO4ZJnpagq3W4jKbKb6a8TLxmLxzHug2rRogdcraqDjru7gHssLHl182pPoSYNKjqiaxpFIAKEkvqBOXX1bYBqjdsRDmcb8ija6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=piYehuOsPHEH3zcOkVaVfcREcZg+X8jXeRT8GGUo2jk=; b=UQkdw0NBuNrLfsFx88NMEqrKEjIsdxTr1MipJE3PWtXIgRPY5e8isuEkhvcvyb0cnNv8M6lAa8qjpSOQ3we6eRt6PGpzhwobuwlc6C8Gbsu5Shny/AaQw8I6j8tQUAj1ESsBB7CAPa1WuJinSi43MmKmhTSvl0u+1PDrIh7m71vNAJc0q230CWKh9x1qcv91cd8RdEDaDFzYZYrZJsCjQmR5P77xQWqPYY36DO3YOG1In1E7dkfVKCGTK+qhR6Etf8lJdFlhn84u5QCTwFULho5qS+8LeOqldbYPbtK8aTXxnc40tAIoxKuTCJGgOB0jlQewwMVw7X4Cg0+ATZL/TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 24 May 2022 14:47:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen: switch gnttab_end_foreign_access() to take a struct page pointer Content-Language: en-US To: Juergen Gross Cc: Boris Ostrovsky , Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe , Dmitry Torokhov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, v9fs-developer@lists.sourceforge.net References: <20220524124137.10021-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220524124137.10021-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0202CA0005.eurprd02.prod.outlook.com (2603:10a6:203:69::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc1c3adc-de93-477b-a47c-08da3d839e85 X-MS-TrafficTypeDiagnostic: PAXPR04MB8143:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QsLbAR8stLSSmZfvID9XqngfmmnrXiBCUf8JuyEq4YCDxMrYmnvUDbEjl1/P2XzT21JcqxXU/xMqSJXYbzp/h777jpVF/Lk8e3UfgoVynIqksEjr9kAE10Dzs2PkrF8xPg414oif+OJ9rtlDFibqR3AvSI837Y97FLTRTOnSelgf79+GZt6Fi2gTwxL8pffvpaUVqkA83+hsnBHd/jbg8eLARgiD9Px6ENsfxPuLBbvgi4RDY3MNB1IdxmPJIsiM6blSY6jYnT3EbFH/41oK5AoVnKiK3E+puvmtGidJ9yncLD5C9tSkz/5cexQsLtK8orP5tLNTrAU05cOC5dO0AwtAHNI6txclF0fMDQAkcSl/d16jWc8RqSGZbJdRMbZZg+07TMtsgR5aTTCixNt3mWdy/e3+G/QNy+WQvEBfRMzDmByviEuYXQ68Xw5VZPQ7P2Cf57k6qKmAHuicnZtiRcLCVfetlrsdlIltORLLvhgjOkqPlAjnhVyrUbB/kvVnO+5z3omegRohvvQcSY2caLwhWPcOYRM7XZpdjtknpdY7ybcvAKncegnE3Ah/a76J3uJ37jEN9/I/tBbS5wYTTV29WN0JapgX1e4JROkP5gpL5YVEBWqGwwRNkbCo1kDqYHzxk1pTSpDtwACZ5AdsnRJbOs0CVoXxzfUV6OKba3PGC4j8uCCYzzeXZHxyXFJwhr8aXA/6CX4o7iQOOcW/RbXL+pMwA9YvEKa+H6nIAg/wk1BPIyZkzMQH24f2adUN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(31696002)(2906002)(2616005)(38100700002)(316002)(6636002)(54906003)(36756003)(37006003)(186003)(5660300002)(6486002)(8676002)(6862004)(4326008)(508600001)(7416002)(66946007)(8936002)(66556008)(66476007)(31686004)(26005)(6506007)(6512007)(4744005)(53546011)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU9URGdjZDF6NnVpNmFyUEJOMHpzUnRGa3FTc0hkYWVvam54djFiOXNxRHRs?= =?utf-8?B?cDBGUS9udHdSVElOZ21tbVpBeHVYZTh4MmpRb0gyT2J4NEtTd09HTGdCM3Bo?= =?utf-8?B?eHlnbkhlMm5JUVlXakFUVHJINEhTNGtVdHBjOTYzcEc3TkJoUElzY2d2UUIr?= =?utf-8?B?ai9xK2QzTStHOEVCckV6MFVOQ05mNWk5eXY5ck9CaHVwMXlHek5ZZnVpQVE2?= =?utf-8?B?WDkwb0k0WnF4VTF4Zjh3Z3RKREtaQldPRTRmNUdUbFZ4enNsZWtSeXZGWTVB?= =?utf-8?B?REdVa1Qyb2FZZWVOaEp6SmY5ZktKdUsyMFh6WWZReURjeWsxV2hXWnM4ZTdt?= =?utf-8?B?QTlkalhIbzRST3lVNWk2VFM2UXdCV2VJUDQxV2x6cGhSem1wOThKVmtzUlZx?= =?utf-8?B?Y3JyRlJIdFlaSC9JbnB5RVI5TGQyeGh6L0FBMklIUExDRFlvZGJzM2ZHMExW?= =?utf-8?B?a3F0MTBSRXRUWDhpcnovbndXVm10VXB4M0N6and6NXpTU2tyKzBwRC9aWnI0?= =?utf-8?B?ck9URXBPMHVQaXQvQjg3TENWNCtuK2FmV3E2Nm12MUpKMHdwYm9ORzdvLytE?= =?utf-8?B?Y21ZL29ncjNzM3N1bTRrRUFwOGFvQW5qT3BiUU0vbjY4b1A3YzNFVVlHeU1V?= =?utf-8?B?ZDNWYzNBSU15VHl0aWh0QlJiS2JqQmxzc0FNdDAvbzRXa1ZvK3lyck1zaGVF?= =?utf-8?B?TUpiT2VMVnRyWGV3bEtTTmJSTVdqR3JrV01HQktFSURVa1ZqalkzcHI5TkxY?= =?utf-8?B?RTVYeU1DblMrMFhaNU11NXdhcnFndTE4M1pYRDc5eWNaUDZFSk8wQXgxQmFz?= =?utf-8?B?V2RKRkxGOXJTOHNXOExVY3ZuWVZ6RUw3WUZxMnlNVmhxMlRScFhlUUhsK2JZ?= =?utf-8?B?SHlSOUJpOWtPS0RPYy9yU1ZaYTJMT2xGblJzcDYzRld6ZVNaTTZWMmNLZGpF?= =?utf-8?B?dUNPYjhxQ3Z4WUFSSlZTRm9IMUNrTnNuTHVwUDZoZEduZm81NG4vZmhaTUlj?= =?utf-8?B?Y2tBYUhoTUg1SGRTcnhxb3lDU2QySmZ0V2YzYlRuUm5Qc0l0TThGWE90Qm40?= =?utf-8?B?MTNBb1BaWElRRXpOYTF5Y1FGNzBMc08xYUVZT0E3Q2pLVGJsNGhxaU5UbnBq?= =?utf-8?B?OVJVbE5HbWlFN2EySGJpK2EyaGVjWWpPejAyTGJLVlRPbEpHRGNmV29RNlhB?= =?utf-8?B?bGRKVXl0NVdYTERBWXRQRTQ3Z1lSRno1UEZtbm5hQnBXY084U21sQkl5eGZ0?= =?utf-8?B?ZWZNTG9oSUxLYVJmTTFBR00xS2Q5ZTg3bE12RGVHVDNrbTVmNHUzaDA2RVZt?= =?utf-8?B?S21BUjRXbFJRQmc1V0M4ZGNtWlF4ZWI4OGcrMEFMWlRUK1RQOFo0REdoZW9C?= =?utf-8?B?Q1ZlalhBT3lwdGhoVyt0YjZTUmp5ZFk4Q0tVQWpNTHpIcHlCc1c0dzhvTVRV?= =?utf-8?B?bXN4MUd1VE9sNm81aWQxMks4YmVIYXNsdCtXUU1wTzhzb0hBMHI0clhmT0lE?= =?utf-8?B?WVBmL0lMaFQyUHN4eHVXbkdjU3M1MUNpa2IxbG5CVWJvT1Voc2VRNm5wamZJ?= =?utf-8?B?NUpvS0NROFRMM0xwVCtwM2JRVndtSGZrZG5GNjVjSVJWbzNkUVJsL3pQSE16?= =?utf-8?B?NExSeDNpMkpFNU1vZHZhWGVoZnFjYkxCeitwejRXVEg2dlRpV0dBYnVMMlVx?= =?utf-8?B?QUpaVmV6ZEpWYjUwTE40b25hNmY5UUtJWXR4bmkzc0dYZHFqbk9icXF5N09Z?= =?utf-8?B?aTJpaEU5b2RyWVpmNEtIWVd0YzBJNURMREFndUExWDVKUnlLclVDZTEzYUls?= =?utf-8?B?ZU05bFQ5d2NHclVlRFFwQWw0WExTMGxIcTlrMjBWYnoxOFllVG8yZnJjQ3NH?= =?utf-8?B?RXBhT1FQa1Bodm5vMWNLV0puRXNrRHF6RStnb04vdGJ4U00zY0NrdDFUcGNo?= =?utf-8?B?eTU1bXJyNmQ2RXdPcENaeUNtbGRPM1YxL2p1YW5mMEdJQXZGTGxLZHdSVWJT?= =?utf-8?B?L0NscW5ObFlBbUJDaHFUVU1jdEdzYzJGTnYzS2ZIb2xMRWJ2NmVUNzhrQXYy?= =?utf-8?B?N2pIT24zWFQ2ampMMEJmSnBNNWhOVWtBcHY3aGxTMWhmQm5CZ2M1N2U1UFJ1?= =?utf-8?B?RklUYTZ6NjZyb29BdVlqSUgxN3N3Ti9saVRRTG9ZMEVIVzFYT0FML0c1am0w?= =?utf-8?B?OTQxUTAwTFhUVWZLNmVEV3FtNENyN0g5UHE4emJvNmJxTVNYR2h6WVFqUTZj?= =?utf-8?B?VmhybEpndzFOWVl1N3NQbWU5WCtsMklKdWZSV2g2Nk9kSC9uUXZSbHhBYks4?= =?utf-8?B?cTlVLzZYRGJqRE5yMDNxeEZUWk9JWndiNWlvUEJzTmFDZFExZW1rdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc1c3adc-de93-477b-a47c-08da3d839e85 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 12:47:53.7633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bcH45iaFIUCEJO+WopRz49xyOoiV+veTUrgHkbMsiaHEswqlWnikUg5gQ+JkfkjQ+6s5G/c855867/5FZ/Kwog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8143 On 24.05.2022 14:41, Juergen Gross wrote: > Instead of a virtual kernel address use a pointer of the associated > struct page as second parameter of gnttab_end_foreign_access(). > > Most users have that pointer available already and are creating the > virtual address from it, risking problems in case the memory is > located in highmem. > > gnttab_end_foreign_access() itself won't need to get the struct page > from the address again. > > Suggested-by: Jan Beulich > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue May 24 13:15:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 13:15:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336557.560900 (Exim 4.92) (envelope-from ) id 1ntUNc-0008PE-TQ; Tue, 24 May 2022 13:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336557.560900; Tue, 24 May 2022 13:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUNc-0008P7-Q6; Tue, 24 May 2022 13:15:20 +0000 Received: by outflank-mailman (input) for mailman id 336557; Tue, 24 May 2022 13:15:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUNb-0008P1-Ar for xen-devel@lists.xenproject.org; Tue, 24 May 2022 13:15:19 +0000 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e00fba1-db63-11ec-837f-e5687231ffcc; Tue, 24 May 2022 15:15:18 +0200 (CEST) Received: by mail-vk1-f180.google.com with SMTP id m203so8446394vke.13 for ; Tue, 24 May 2022 06:15:17 -0700 (PDT) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com. [209.85.222.42]) by smtp.gmail.com with ESMTPSA id o13-20020ab02a0d000000b003629ce160f9sm1014482uar.29.2022.05.24.06.15.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 06:15:15 -0700 (PDT) Received: by mail-ua1-f42.google.com with SMTP id x11so6251056uao.2 for ; Tue, 24 May 2022 06:15:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e00fba1-db63-11ec-837f-e5687231ffcc X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S/pNo5ypsj8sjqbjG1l1gWrym6AVA3NFtAtotZSuvpI=; b=zN2QoBd3ZJC+qgjGqhih4YSiUTctWXw3yl65rv5juiDBki8CVMiVEK4nZWwoZuMLR9 exttk0D6c2kwjttQb/Jkdat8L5Zw95AbSLOhMYbhJC569/lsuJmWYrVoR6OICYi2/S+f q+XxD9sWaNVCT5S9voPvcfkQIPRUP/2Eop1aZFKVEhjtbC0h5uLPZSJwJDsabh/gOW4v PEZ585HHviANhJEG7/F892Azo6Q8KBKtRby6Mxzu8ATsyRzum3JH8eVWG3iZaR6YfEkO un2YjswxC87Nxf8WRWiAaZp2Z2j8herPBrxtEEcskZ0Wm2sUNetEMWn2jQvB+7SbBBEC uucA== X-Gm-Message-State: AOAM530vAGSikAH0Knrq6lLurDBn38EJ7ELaSMbBjAeNfVWjnffws5xi lxm3HyGpc+VBvHVpc7OOsQyHwRq+tt2Orm1iD4g= X-Google-Smtp-Source: ABdhPJxBdwXSMoc0F/VcD+OmPpfb/yYEjQM0Tz9uMFPhfs8pTC10BOL+1aG06zLeRqfJtZ8vsryjtQ== X-Received: by 2002:a05:6122:8d5:b0:356:deb3:3c50 with SMTP id 21-20020a05612208d500b00356deb33c50mr9550423vkg.28.1653398116554; Tue, 24 May 2022 06:15:16 -0700 (PDT) X-Received: by 2002:a25:e7ce:0:b0:64d:6028:96b9 with SMTP id e197-20020a25e7ce000000b0064d602896b9mr25151338ybh.365.1653398104009; Tue, 24 May 2022 06:15:04 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-8-dmitry.osipenko@collabora.com> In-Reply-To: <20220509233235.995021-8-dmitry.osipenko@collabora.com> From: Geert Uytterhoeven Date: Tue, 24 May 2022 15:14:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off() To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Hi Dmitry, On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko wrote: > Add kernel_can_power_off() helper that replaces open-coded checks of > the global pm_power_off variable. This is a necessary step towards > supporting chained power-off handlers. > > Signed-off-by: Dmitry Osipenko Thanks for your patch, which is now commit 0e2110d2e910e44c ("kernel/reboot: Add kernel_can_power_off()") in pm/linux-next. This causes the "poweroff" command (Debian nfsroot) to no longer cleanly halt the system on arm32 systems, but fail with a panic instead: -reboot: System halted +reboot: Power down +Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 +CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 5.18.0-rc7-shmobile-00007-g0e2110d2e910 #1274 +Hardware name: Generic R-Car Gen2 (Flattened Device Tree) + unwind_backtrace from show_stack+0x10/0x14 + show_stack from dump_stack_lvl+0x40/0x4c + dump_stack_lvl from panic+0xf4/0x330 + panic from do_exit+0x1c8/0x8e4 + do_exit from __do_sys_reboot+0x174/0x1fc + __do_sys_reboot from ret_fast_syscall+0x0/0x54 +Exception stack(0xf0815fa8 to 0xf0815ff0) +5fa0: 004e6954 00000000 fee1dead 28121969 4321fedc f0d94600 +5fc0: 004e6954 00000000 00000000 00000058 befa0c78 00000000 befa0c10 004e56f8 +5fe0: 00000058 befa0b6c b6ec8d45 b6e4a746 +---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 ]--- On arm64, "poweroff" causes a clean "reboot: Power down" before/after. On both arm32 and arm64, the same handlers are registered: - SYS_OFF_MODE_POWER_OFF_PREPARE: legacy_pm_power_off_prepare - SYS_OFF_MODE_POWER_OFF: legacy_pm_power_off On both arm32 and arm64, legacy_pm_power_off_prepare() is called. On both arm32 and arm64, legacy_pm_power_off() does not seem to be called. On arm32, both pm_power_off_prepare and pm_power_off are NULL. On arm64, pm_power_off_prepare is NULL, and pm_power_off is psci_sys_poweroff. Do you have a clue? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From xen-devel-bounces@lists.xenproject.org Tue May 24 13:41:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 13:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336566.560911 (Exim 4.92) (envelope-from ) id 1ntUn2-0003Pq-49; Tue, 24 May 2022 13:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336566.560911; Tue, 24 May 2022 13:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUn1-0003Pj-V8; Tue, 24 May 2022 13:41:35 +0000 Received: by outflank-mailman (input) for mailman id 336566; Tue, 24 May 2022 13:41:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUn0-0003PK-GX for xen-devel@lists.xenproject.org; Tue, 24 May 2022 13:41:34 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 385134c3-db67-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 15:41:32 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id DC3DB1F442E3 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 385134c3-db67-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653399691; bh=qpTUo3+rCDoRa3ZgqFQh1I4V9k0JzWGh76jPDBVw0m4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hRMXxgmEZeDfWxnLgiCfIjezbE8Yst9du0UI+7few0qFS4O6SzexhgUtNR81+UMa0 KYtGAP7WoJvvCbjb1r9vYJeBeLntuikTxHhQ2xX4GkSM65ZWF51SWtZtKkvG2GsFyp ee6wNZ4HuinXH/33e8XTqRPnuFRbKCyO2LU4lEig5MXDWQ8Ifwaf0vGosGA3FpGoOu ZY9sVSFR31S/Hc7aRsnDGFMQGEBGJznHN/aWQ9jbnVbO6PcOxcFGWQQ7E0fiyfa2yi ZaixIuXh19f/Vi/OJQtn0gKlBU/bhD2aoxUDefuGeAsRvNKuYRcUhucApE0L9xde3E WNH0ic23yweUA== Message-ID: Date: Tue, 24 May 2022 16:41:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off() Content-Language: en-US To: Geert Uytterhoeven Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra , Linux-Renesas References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-8-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/24/22 16:14, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > wrote: >> Add kernel_can_power_off() helper that replaces open-coded checks of >> the global pm_power_off variable. This is a necessary step towards >> supporting chained power-off handlers. >> >> Signed-off-by: Dmitry Osipenko > > Thanks for your patch, which is now commit 0e2110d2e910e44c > ("kernel/reboot: Add kernel_can_power_off()") in pm/linux-next. > > This causes the "poweroff" command (Debian nfsroot) to no longer > cleanly halt the system on arm32 systems, but fail with a panic > instead: > > -reboot: System halted > +reboot: Power down > +Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 > +CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted > 5.18.0-rc7-shmobile-00007-g0e2110d2e910 #1274 > +Hardware name: Generic R-Car Gen2 (Flattened Device Tree) > + unwind_backtrace from show_stack+0x10/0x14 > + show_stack from dump_stack_lvl+0x40/0x4c > + dump_stack_lvl from panic+0xf4/0x330 > + panic from do_exit+0x1c8/0x8e4 > + do_exit from __do_sys_reboot+0x174/0x1fc > + __do_sys_reboot from ret_fast_syscall+0x0/0x54 > +Exception stack(0xf0815fa8 to 0xf0815ff0) > +5fa0: 004e6954 00000000 fee1dead 28121969 4321fedc f0d94600 > +5fc0: 004e6954 00000000 00000000 00000058 befa0c78 00000000 befa0c10 004e56f8 > +5fe0: 00000058 befa0b6c b6ec8d45 b6e4a746 > +---[ end Kernel panic - not syncing: Attempted to kill init! > exitcode=0x00000000 ]--- > > On arm64, "poweroff" causes a clean "reboot: Power down" before/after. > > On both arm32 and arm64, the same handlers are registered: > - SYS_OFF_MODE_POWER_OFF_PREPARE: legacy_pm_power_off_prepare > - SYS_OFF_MODE_POWER_OFF: legacy_pm_power_off > > On both arm32 and arm64, legacy_pm_power_off_prepare() is called. > On both arm32 and arm64, legacy_pm_power_off() does not seem to > be called. > > On arm32, both pm_power_off_prepare and pm_power_off are NULL. > On arm64, pm_power_off_prepare is NULL, and > pm_power_off is psci_sys_poweroff. > > Do you have a clue? > Thanks! Thank you, Geert! I see the problem, the kernel_can_power_off() checks whether power-off handler is registered, but it's always registered because legacy_pm_power_off is registered unconditionally. So it causes trouble for platforms that don't have power-off handler installed at all. All platforms that I tested have a power-off handler, so now wonder that I didn't notice this before. This change should fix the problem, please give it a try: --- 8< --- diff --git a/kernel/reboot.c b/kernel/reboot.c index 0bdc64ecf4f6..2d55b8bdb444 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -569,22 +569,6 @@ static int legacy_pm_power_off(struct sys_off_data *data) return NOTIFY_DONE; } -/* - * Register sys-off handlers for legacy PM callbacks. This allows legacy - * PM callbacks co-exist with the new sys-off API. - * - * TODO: Remove legacy handlers once all legacy PM users will be switched - * to the sys-off based APIs. - */ -static int __init legacy_pm_init(void) -{ - register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_DEFAULT, - legacy_pm_power_off, NULL); - - return 0; -} -core_initcall(legacy_pm_init); - static void do_kernel_power_off_prepare(void) { blocking_notifier_call_chain(&power_off_prep_handler_list, 0, NULL); @@ -670,6 +654,18 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd, if (ret) return ret; + /* + * Register sys-off handler for the legacy PM callback. This allows + * legacy PM callbacks co-exist with the new sys-off API. + * + * TODO: Remove legacy handler once all legacy PM users will be + * switched to the sys-off based APIs. + */ + if (pm_power_off) + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_DEFAULT, + legacy_pm_power_off, NULL); + /* Instead of trying to make the power_off code look like * halt when pm_power_off is not set do it the easy way. */ -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Tue May 24 13:43:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 13:43:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336574.560922 (Exim 4.92) (envelope-from ) id 1ntUor-00040X-ED; Tue, 24 May 2022 13:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336574.560922; Tue, 24 May 2022 13:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUor-00040Q-Af; Tue, 24 May 2022 13:43:29 +0000 Received: by outflank-mailman (input) for mailman id 336574; Tue, 24 May 2022 13:43:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntUop-00040K-Mh for xen-devel@lists.xenproject.org; Tue, 24 May 2022 13:43:27 +0000 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c774b8f-db67-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 15:43:26 +0200 (CEST) Received: by mail-yb1-f170.google.com with SMTP id i187so28712163ybg.6 for ; Tue, 24 May 2022 06:43:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c774b8f-db67-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gF0TUV/f1EYPh7LzpbylOlyjLRvO0rS2Z8aSd7vESdM=; b=qM4lZocGU2K6t7Ms+LTa2tCi9Zklc9U8BLDgE9f6yXJqKyJBMo4ZwJ5sP/jlomghAX j/rHiu5H+e0dEPX8M2VBneQZ1YMYH6gGriIDoMEX7NVPgfk5FtAo9cnQNDFXvVuW9X6q Nn4j7W8JYz8VYDQaKzlAmT+LO3YsE4qRwfstI6AG0XY8PVdE37qOgIyNgszLqNIVxgu6 14bEwBsoF0WlyfomXFYozc2xfAFhyJQa50zL5gx30UfI+Z+dcjmEb4k6K5aT49g2xM8F MHzywNRrA1QYeKPhawepZQKWRlRZKEzebU67ZgRTasie/XASsuri85MRVGRDiU0FnYp7 2RkQ== X-Gm-Message-State: AOAM530Hf2qbTcJ9cysDFQ+lmMIqnIlTl65qPg5zuTEnb/8I9qDHWKxy nxBEUc4SVTL7hCxS0uqbyiVCknWW9dzEgezaO4A= X-Google-Smtp-Source: ABdhPJxrx+4PyTpojs6STJF90N5O3lVotlMS1F5ewlefJhltMPRleCLQ6INTFZNdlhzglSskVKU04pl4oHllKVWle+Q= X-Received: by 2002:a05:6902:100a:b0:64f:44ec:13ff with SMTP id w10-20020a056902100a00b0064f44ec13ffmr24477246ybt.137.1653399805346; Tue, 24 May 2022 06:43:25 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 24 May 2022 15:43:14 +0200 Message-ID: Subject: Re: [PATCH v8 00/27] Introduce power-off+restart call chain API To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra Content-Type: text/plain; charset="UTF-8" Hi Geert, On Mon, May 23, 2022 at 8:08 PM Geert Uytterhoeven wrote: > > Hi Rafael, > > On Wed, May 18, 2022 at 4:46 PM Rafael J. Wysocki wrote: > > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > > wrote: > > > > m68k: Switch to new sys-off handler API > > Sorry, I didn't realize this was going to interact with the new m68k > virtual machine support, which is included in the m68k pull request > for v5.19. > > > However, I'm going to send a pull request with it in the second half > > of the merge window, after the majority of the other changes in the > > subsystems touched by it have been integrated. > > And presumably you will have to merge in v5.19-rc1, too? I will merge this series on top of the Linus' merges of my pull requests sent yesterday (assuming that he pulls them, that is). > I've sent a fix. It should appear at > https://lore.kernel.org/r/20220523175520.949681-1-geert@linux-m68k.org > soon. > > Can you please include that in your PR? I will. Thanks! From xen-devel-bounces@lists.xenproject.org Tue May 24 14:45:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 14:45:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336583.560933 (Exim 4.92) (envelope-from ) id 1ntVmi-00024I-3z; Tue, 24 May 2022 14:45:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336583.560933; Tue, 24 May 2022 14:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntVmh-00024B-W0; Tue, 24 May 2022 14:45:19 +0000 Received: by outflank-mailman (input) for mailman id 336583; Tue, 24 May 2022 14:45:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntVmg-000245-LZ for xen-devel@lists.xenproject.org; Tue, 24 May 2022 14:45:19 +0000 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1eda62a8-db70-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 16:45:15 +0200 (CEST) Received: from in02.mta.xmission.com ([166.70.13.52]:50104) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1ntVmV-00DpX9-Vh; Tue, 24 May 2022 08:45:08 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:39208 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1ntVmS-0094Va-C7; Tue, 24 May 2022 08:45:07 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1eda62a8-db70-11ec-bd2c-47488cf2e6aa From: "Eric W. Biederman" To: "Guilherme G. Piccoli" Cc: akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, coresight@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> Date: Tue, 24 May 2022 09:44:26 -0500 In-Reply-To: <20220427224924.592546-25-gpiccoli@igalia.com> (Guilherme G. Piccoli's message of "Wed, 27 Apr 2022 19:49:18 -0300") Message-ID: <87fskzuh11.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1ntVmS-0094Va-C7;;;mid=<87fskzuh11.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1/YIqCVMgJ0BHYh5BEcp/n0JQZMG5Y7fCg= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: ***** X-Spam-Status: No, score=5.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMNoVowels,XM_B_Investor, XM_B_SpammyWords,XM_SPF_SoftFail autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.0 XM_B_Investor BODY: Commonly used business phishing phrases * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; Body=1 Fuz1=1 Fuz2=1] * 0.2 XM_B_SpammyWords One or more commonly used spammy words * 2.5 XM_SPF_SoftFail SPF-SoftFail X-Spam-DCC: XMission; sa05 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *****;"Guilherme G. Piccoli" X-Spam-Relay-Country: X-Spam-Timing: total 2873 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 12 (0.4%), b_tie_ro: 9 (0.3%), parse: 3.2 (0.1%), extract_message_metadata: 37 (1.3%), get_uri_detail_list: 18 (0.6%), tests_pri_-1000: 25 (0.9%), tests_pri_-950: 1.44 (0.1%), tests_pri_-900: 1.38 (0.0%), tests_pri_-90: 252 (8.8%), check_bayes: 248 (8.6%), b_tokenize: 43 (1.5%), b_tok_get_all: 22 (0.8%), b_comp_prob: 8 (0.3%), b_tok_touch_all: 167 (5.8%), b_finish: 1.21 (0.0%), tests_pri_0: 2378 (82.8%), check_dkim_signature: 1.08 (0.0%), check_dkim_adsp: 2.8 (0.1%), poll_dns_idle: 143 (5.0%), tests_pri_10: 2.3 (0.1%), tests_pri_500: 154 (5.4%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 24/30] panic: Refactor the panic path X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) "Guilherme G. Piccoli" writes: > The panic() function is somewhat convoluted - a lot of changes were > made over the years, adding comments that might be misleading/outdated > now, it has a code structure that is a bit complex to follow, with > lots of conditionals, for example. The panic notifier list is something > else - a single list, with multiple callbacks of different purposes, > that run in a non-deterministic order and may affect hardly kdump > reliability - see the "crash_kexec_post_notifiers" workaround-ish flag. > > This patch proposes a major refactor on the panic path based on Petr's > idea [0] - basically we split the notifiers list in three, having a set > of different call points in the panic path. Below a list of changes > proposed in this patch, culminating in the panic notifiers level > concept: > > (a) First of all, we improved comments all over the function > and removed useless variables / includes. Also, as part of this > clean-up we concentrate the console flushing functions in a helper. > > (b) As mentioned before, there is a split of the panic notifier list > in three, based on the purpose of the callback. The code contains > good documentation in form of comments, but a summary of the three > lists follows: > > - the hypervisor list aims low-risk procedures to inform hypervisors > or firmware about the panic event, also includes LED-related functions; > > - the informational list contains callbacks that provide more details, > like kernel offset or trace dump (if enabled) and also includes the > callbacks aimed at reducing log pollution or warns, like the RCU and > hung task disable callbacks; > > - finally, the pre_reboot list is the old notifier list renamed, > containing the more risky callbacks that didn't fit the previous > lists. There is also a 4th list (the post_reboot one), but it's not > related with the original list - it contains late time architecture > callbacks aimed at stopping the machine, for example. > > The 3 notifiers lists execute in different moments, hypervisor being > the first, followed by informational and finally the pre_reboot list. > > (c) But then, there is the ordering problem of the notifiers against > the crash_kernel() call - kdump must be as reliable as possible. > For that, a simple binary "switch" as "crash_kexec_post_notifiers" > is not enough, hence we introduce here concept of panic notifier > levels: there are 5 levels, from 0 (no notifier executes before > kdump) until 4 (all notifiers run before kdump); the default level > is 2, in which the hypervisor and (iff we have any kmsg dumper) > the informational notifiers execute before kdump. > > The detailed documentation of the levels is present in code comments > and in the kernel-parameters.txt file; as an analogy with the previous > panic() implementation, the level 0 is exactly the same as the old > behavior of notifiers, running all after kdump, and the level 4 is > the same as "crash_kexec_post_notifiers=Y" (we kept this parameter as > a deprecated one). > > (d) Finally, an important change made here: we now use only the > function "crash_smp_send_stop()" to shut all the secondary CPUs > in the panic path. Before, there was a case of using the regular > "smp_send_stop()", but the better approach is to simplify the > code and try to use the function which was created exclusively > for the panic path. Experiments showed that it works fine, and > code was very simplified with that. > > Functional change is expected from this refactor, since now we > call some notifiers by default before kdump, but the goal here > besides code clean-up is to have a better panic path, more > reliable and deterministic, but also very customizable. > > [0] https://lore.kernel.org/lkml/YfPxvzSzDLjO5ldp@alley/ I am late to this discussion. My apologies. Unfortunately I am also very grouchy. Notifiers before kexec on panic are fundamentally broken. So please just remove crash_kexec_post notifiers and be done with it. Part of the deep issue is that firmware always has a common and broken implementation for anything that is not mission critical to motherboards. Notifiers in any sense on these paths are just bollocks. Any kind of notifier list is fundamentally fragile in the face of memory corruption and very very difficult to review. So I am going to refresh my ancient NACK on this. I can certainly appreciate that there are pieces of the reboot paths that can be improved. I don't think making anything more feature full or flexible is any kind of real improvement. Eric > > Suggested-by: Petr Mladek > Signed-off-by: Guilherme G. Piccoli > --- > > Special thanks to Petr and Baoquan for the suggestion and feedback in a previous > email thread. There's some important design decisions that worth mentioning and > discussing: > > * The default panic notifiers level is 2, based on Petr Mladek's suggestion, > which makes a lot of sense. Of course, this is customizable through the > parameter, but would be something worthwhile to have a KConfig option to set > the default level? It would help distros that want the old behavior > (no notifiers before kdump) as default. > > * The implementation choice was to _avoid_ intricate if conditionals in the > panic path, which would _definitely_ be present with the panic notifiers levels > idea; so, instead of lots of if conditionals, the set/clear bits approach with > functions called in 2 points (but executing only in one of them) is much easier > to follow an was used here; the ordering helper function and the comments also > help a lot to avoid confusion (hopefully). > > * Choice was to *always* use crash_smp_send_stop() instead of sometimes making > use of the regular smp_send_stop(); for most architectures they are the same, > including Xen (on x86). For the ones that override it, all should work fine, > in the powerpc case it's even more correct (see the subsequent patch > "powerpc: Do not force all panic notifiers to execute before kdump") > > There seems to be 2 cases that requires some plumbing to work 100% right: > - ARM doesn't disable local interrupts / FIQs in the crash version of > send_stop(); we patched that early in this series; > - x86 could face an issue if we have VMX and do use crash_smp_send_stop() > _without_ kdump, but this is fixed in the first patch of the series (and > it's a bug present even before this refactor). > > * Notice we didn't add a sysrq for panic notifiers level - should have it? > Alejandro proposed recently to add a sysrq for "crash_kexec_post_notifiers", > let me know if you feel the need here Alejandro, since the core parameters are > present in /sys, I didn't consider much gain in having a sysrq, but of course > I'm open to suggestions! > > Thanks advance for the review! > > .../admin-guide/kernel-parameters.txt | 42 ++- > include/linux/panic_notifier.h | 1 + > kernel/kexec_core.c | 8 +- > kernel/panic.c | 292 +++++++++++++----- > .../selftests/pstore/pstore_crash_test | 5 +- > 5 files changed, 252 insertions(+), 96 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 3f1cc5e317ed..8d3524060ce3 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -829,6 +829,13 @@ > It will be ignored when crashkernel=X,high is not used > or memory reserved is below 4G. > > + crash_kexec_post_notifiers > + This was DEPRECATED - users should always prefer the > + parameter "panic_notifiers_level" - check its entry > + in this documentation for details on how it works. > + Setting this parameter is exactly the same as setting > + "panic_notifiers_level=4". > + > cryptomgr.notests > [KNL] Disable crypto self-tests > > @@ -3784,6 +3791,33 @@ > timeout < 0: reboot immediately > Format: > > + panic_notifiers_level= > + [KNL] Set the panic notifiers execution order. > + Format: > + We currently have 4 lists of panic notifiers; based > + on the functionality and risk (for panic success) the > + callbacks are added in a given list. The lists are: > + - hypervisor/FW notification list (low risk); > + - informational list (low/medium risk); > + - pre_reboot list (higher risk); > + - post_reboot list (only run late in panic and after > + kdump, not configurable for now). > + This parameter defines the ordering of the first 3 > + lists with regards to kdump; the levels determine > + which set of notifiers execute before kdump. The > + accepted levels are: > + 0: kdump is the first thing to run, NO list is > + executed before kdump. > + 1: only the hypervisor list is executed before kdump. > + 2 (default level): the hypervisor list and (*if* > + there's any kmsg_dumper defined) the informational > + list are executed before kdump. > + 3: both the hypervisor and the informational lists > + (always) execute before kdump. > + 4: the 3 lists (hypervisor, info and pre_reboot) > + execute before kdump - this behavior is analog to the > + deprecated parameter "crash_kexec_post_notifiers". > + > panic_print= Bitmask for printing system info when panic happens. > User can chose combination of the following bits: > bit 0: print all tasks info > @@ -3814,14 +3848,6 @@ > panic_on_warn panic() instead of WARN(). Useful to cause kdump > on a WARN(). > > - crash_kexec_post_notifiers > - Run kdump after running panic-notifiers and dumping > - kmsg. This only for the users who doubt kdump always > - succeeds in any situation. > - Note that this also increases risks of kdump failure, > - because some panic notifiers can make the crashed > - kernel more unstable. > - > parkbd.port= [HW] Parallel port number the keyboard adapter is > connected to, default is 0. > Format: > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h > index bcf6a5ea9d7f..b5041132321d 100644 > --- a/include/linux/panic_notifier.h > +++ b/include/linux/panic_notifier.h > @@ -10,6 +10,7 @@ extern struct atomic_notifier_head panic_info_list; > extern struct atomic_notifier_head panic_pre_reboot_list; > extern struct atomic_notifier_head panic_post_reboot_list; > > +bool panic_notifiers_before_kdump(void); > extern bool crash_kexec_post_notifiers; > > enum panic_notifier_val { > diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > index 68480f731192..f8906db8ca72 100644 > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -74,11 +74,11 @@ struct resource crashk_low_res = { > int kexec_should_crash(struct task_struct *p) > { > /* > - * If crash_kexec_post_notifiers is enabled, don't run > - * crash_kexec() here yet, which must be run after panic > - * notifiers in panic(). > + * In case any panic notifiers are set to execute before kexec, > + * don't run crash_kexec() here yet, which must run after these > + * panic notifiers are executed, in the panic() path. > */ > - if (crash_kexec_post_notifiers) > + if (panic_notifiers_before_kdump()) > return 0; > /* > * There are 4 panic() calls in make_task_dead() path, each of which > diff --git a/kernel/panic.c b/kernel/panic.c > index bf792102b43e..b7c055d4f87f 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -52,14 +51,23 @@ static unsigned long tainted_mask = > static int pause_on_oops; > static int pause_on_oops_flag; > static DEFINE_SPINLOCK(pause_on_oops_lock); > -bool crash_kexec_post_notifiers; > + > int panic_on_warn __read_mostly; > +bool panic_on_taint_nousertaint; > unsigned long panic_on_taint; > -bool panic_on_taint_nousertaint = false; > > int panic_timeout = CONFIG_PANIC_TIMEOUT; > EXPORT_SYMBOL_GPL(panic_timeout); > > +/* Initialized with all notifiers set to run before kdump */ > +static unsigned long panic_notifiers_bits = 15; > + > +/* Default level is 2, see kernel-parameters.txt */ > +unsigned int panic_notifiers_level = 2; > + > +/* DEPRECATED in favor of panic_notifiers_level */ > +bool crash_kexec_post_notifiers; > + > #define PANIC_PRINT_TASK_INFO 0x00000001 > #define PANIC_PRINT_MEM_INFO 0x00000002 > #define PANIC_PRINT_TIMER_INFO 0x00000004 > @@ -109,10 +117,14 @@ void __weak nmi_panic_self_stop(struct pt_regs *regs) > } > > /* > - * Stop other CPUs in panic. Architecture dependent code may override this > - * with more suitable version. For example, if the architecture supports > - * crash dump, it should save registers of each stopped CPU and disable > - * per-CPU features such as virtualization extensions. > + * Stop other CPUs in panic context. > + * > + * Architecture dependent code may override this with more suitable version. > + * For example, if the architecture supports crash dump, it should save the > + * registers of each stopped CPU and disable per-CPU features such as > + * virtualization extensions. When not overridden in arch code (and for > + * x86/xen), this is exactly the same as execute smp_send_stop(), but > + * guarded against duplicate execution. > */ > void __weak crash_smp_send_stop(void) > { > @@ -183,6 +195,112 @@ static void panic_print_sys_info(bool console_flush) > ftrace_dump(DUMP_ALL); > } > > +/* > + * Helper that accumulates all console flushing routines executed on panic. > + */ > +static void console_flushing(void) > +{ > +#ifdef CONFIG_VT > + unblank_screen(); > +#endif > + console_unblank(); > + > + /* > + * In this point, we may have disabled other CPUs, hence stopping the > + * CPU holding the lock while still having some valuable data in the > + * console buffer. > + * > + * Try to acquire the lock then release it regardless of the result. > + * The release will also print the buffers out. Locks debug should > + * be disabled to avoid reporting bad unlock balance when panic() > + * is not being called from OOPS. > + */ > + debug_locks_off(); > + console_flush_on_panic(CONSOLE_FLUSH_PENDING); > + > + panic_print_sys_info(true); > +} > + > +#define PN_HYPERVISOR_BIT 0 > +#define PN_INFO_BIT 1 > +#define PN_PRE_REBOOT_BIT 2 > +#define PN_POST_REBOOT_BIT 3 > + > +/* > + * Determine the order of panic notifiers with regards to kdump. > + * > + * This function relies in the "panic_notifiers_level" kernel parameter > + * to determine how to order the notifiers with regards to kdump. We > + * have currently 5 levels. For details, please check the kernel docs for > + * "panic_notifiers_level" at Documentation/admin-guide/kernel-parameters.txt. > + * > + * Default level is 2, which means the panic hypervisor and informational > + * (unless we don't have any kmsg_dumper) lists will execute before kdump. > + */ > +static void order_panic_notifiers_and_kdump(void) > +{ > + /* > + * The parameter "crash_kexec_post_notifiers" is deprecated, but > + * valid. Users that set it want really all panic notifiers to > + * execute before kdump, so it's effectively the same as setting > + * the panic notifiers level to 4. > + */ > + if (panic_notifiers_level >= 4 || crash_kexec_post_notifiers) > + return; > + > + /* > + * Based on the level configured (smaller than 4), we clear the > + * proper bits in "panic_notifiers_bits". Notice that this bitfield > + * is initialized with all notifiers set. > + */ > + switch (panic_notifiers_level) { > + case 3: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + break; > + case 2: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + > + if (!kmsg_has_dumpers()) > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + break; > + case 1: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + break; > + case 0: > + clear_bit(PN_PRE_REBOOT_BIT, &panic_notifiers_bits); > + clear_bit(PN_INFO_BIT, &panic_notifiers_bits); > + clear_bit(PN_HYPERVISOR_BIT, &panic_notifiers_bits); > + break; > + } > +} > + > +/* > + * Set of helpers to execute the panic notifiers only once. > + * Just the informational notifier cares about the return. > + */ > +static inline bool notifier_run_once(struct atomic_notifier_head head, > + char *buf, long bit) > +{ > + if (test_and_change_bit(bit, &panic_notifiers_bits)) { > + atomic_notifier_call_chain(&head, PANIC_NOTIFIER, buf); > + return true; > + } > + return false; > +} > + > +#define panic_notifier_hypervisor_once(buf)\ > + notifier_run_once(panic_hypervisor_list, buf, PN_HYPERVISOR_BIT) > + > +#define panic_notifier_info_once(buf)\ > + notifier_run_once(panic_info_list, buf, PN_INFO_BIT) > + > +#define panic_notifier_pre_reboot_once(buf)\ > + notifier_run_once(panic_pre_reboot_list, buf, PN_PRE_REBOOT_BIT) > + > +#define panic_notifier_post_reboot_once(buf)\ > + notifier_run_once(panic_post_reboot_list, buf, PN_POST_REBOOT_BIT) > + > /** > * panic - halt the system > * @fmt: The text string to print > @@ -198,32 +316,29 @@ void panic(const char *fmt, ...) > long i, i_next = 0, len; > int state = 0; > int old_cpu, this_cpu; > - bool _crash_kexec_post_notifiers = crash_kexec_post_notifiers; > > - if (panic_on_warn) { > - /* > - * This thread may hit another WARN() in the panic path. > - * Resetting this prevents additional WARN() from panicking the > - * system on this thread. Other threads are blocked by the > - * panic_mutex in panic(). > - */ > - panic_on_warn = 0; > - } > + /* > + * This thread may hit another WARN() in the panic path, so > + * resetting this option prevents additional WARN() from > + * re-panicking the system here. > + */ > + panic_on_warn = 0; > > /* > * Disable local interrupts. This will prevent panic_smp_self_stop > - * from deadlocking the first cpu that invokes the panic, since > - * there is nothing to prevent an interrupt handler (that runs > - * after setting panic_cpu) from invoking panic() again. > + * from deadlocking the first cpu that invokes the panic, since there > + * is nothing to prevent an interrupt handler (that runs after setting > + * panic_cpu) from invoking panic() again. Also disables preemption > + * here - notice it's not safe to rely on interrupt disabling to avoid > + * preemption, since any cond_resched() or cond_resched_lock() might > + * trigger a reschedule if the preempt count is 0 (for reference, see > + * Documentation/locking/preempt-locking.rst). Some functions called > + * from here want preempt disabled, so no point enabling it later. > */ > local_irq_disable(); > preempt_disable_notrace(); > > /* > - * It's possible to come here directly from a panic-assertion and > - * not have preempt disabled. Some functions called from here want > - * preempt to be disabled. No point enabling it later though... > - * > * Only one CPU is allowed to execute the panic code from here. For > * multiple parallel invocations of panic, all other CPUs either > * stop themself or will wait until they are stopped by the 1st CPU > @@ -266,73 +381,75 @@ void panic(const char *fmt, ...) > kgdb_panic(buf); > > /* > - * If we have crashed and we have a crash kernel loaded let it handle > - * everything else. > - * If we want to run this after calling panic_notifiers, pass > - * the "crash_kexec_post_notifiers" option to the kernel. > + * Here lies one of the most subtle parts of the panic path, > + * the panic notifiers and their order with regards to kdump. > + * We currently have 4 sets of notifiers: > * > - * Bypass the panic_cpu check and call __crash_kexec directly. > + * - the hypervisor list is composed by callbacks that are related > + * to warn the FW / hypervisor about panic, or non-invasive LED > + * controlling functions - (hopefully) low-risk for kdump, should > + * run early if possible. > + * > + * - the informational list is composed by functions dumping data > + * like kernel offsets, device error registers or tracing buffer; > + * also log flooding prevention callbacks fit in this list. It is > + * relatively safe to run before kdump. > + * > + * - the pre_reboot list basically is everything else, all the > + * callbacks that don't fit in the 2 previous lists. It should > + * run *after* kdump if possible, as it contains high-risk > + * functions that may break kdump. > + * > + * - we also have a 4th list of notifiers, the post_reboot > + * callbacks. This is not strongly related to kdump since it's > + * always executed late in the panic path, after the restart > + * mechanism (if set); its goal is to provide a way for > + * architecture code effectively power-off/disable the system. > + * > + * The kernel provides the "panic_notifiers_level" parameter > + * to adjust the ordering in which these notifiers should run > + * with regards to kdump - the default level is 2, so both the > + * hypervisor and informational notifiers should execute before > + * the __crash_kexec(); the info notifier won't run by default > + * unless there's some kmsg_dumper() registered. For details > + * about it, check Documentation/admin-guide/kernel-parameters.txt. > + * > + * Notice that the code relies in bits set/clear operations to > + * determine the ordering, functions *_once() execute only one > + * time, as their name implies. The goal is to prevent too much > + * if conditionals and more confusion. Finally, regarding CPUs > + * disabling: unless NO panic notifier executes before kdump, > + * we always disable secondary CPUs before __crash_kexec() and > + * the notifiers execute. > */ > - if (!_crash_kexec_post_notifiers) { > + order_panic_notifiers_and_kdump(); > + > + /* If no level, we should kdump ASAP. */ > + if (!panic_notifiers_level) > __crash_kexec(NULL); > > - /* > - * Note smp_send_stop is the usual smp shutdown function, which > - * unfortunately means it may not be hardened to work in a > - * panic situation. > - */ > - smp_send_stop(); > - } else { > - /* > - * If we want to do crash dump after notifier calls and > - * kmsg_dump, we will need architecture dependent extra > - * works in addition to stopping other CPUs. > - */ > - crash_smp_send_stop(); > - } > + crash_smp_send_stop(); > + panic_notifier_hypervisor_once(buf); > > - /* > - * Run any panic handlers, including those that might need to > - * add information to the kmsg dump output. > - */ > - atomic_notifier_call_chain(&panic_hypervisor_list, PANIC_NOTIFIER, buf); > - atomic_notifier_call_chain(&panic_info_list, PANIC_NOTIFIER, buf); > - atomic_notifier_call_chain(&panic_pre_reboot_list, PANIC_NOTIFIER, buf); > + if (panic_notifier_info_once(buf)) { > + panic_print_sys_info(false); > + kmsg_dump(KMSG_DUMP_PANIC); > + } > > - panic_print_sys_info(false); > + panic_notifier_pre_reboot_once(buf); > > - kmsg_dump(KMSG_DUMP_PANIC); > + __crash_kexec(NULL); > > - /* > - * If you doubt kdump always works fine in any situation, > - * "crash_kexec_post_notifiers" offers you a chance to run > - * panic_notifiers and dumping kmsg before kdump. > - * Note: since some panic_notifiers can make crashed kernel > - * more unstable, it can increase risks of the kdump failure too. > - * > - * Bypass the panic_cpu check and call __crash_kexec directly. > - */ > - if (_crash_kexec_post_notifiers) > - __crash_kexec(NULL); > + panic_notifier_hypervisor_once(buf); > > -#ifdef CONFIG_VT > - unblank_screen(); > -#endif > - console_unblank(); > - > - /* > - * We may have ended up stopping the CPU holding the lock (in > - * smp_send_stop()) while still having some valuable data in the console > - * buffer. Try to acquire the lock then release it regardless of the > - * result. The release will also print the buffers out. Locks debug > - * should be disabled to avoid reporting bad unlock balance when > - * panic() is not being callled from OOPS. > - */ > - debug_locks_off(); > - console_flush_on_panic(CONSOLE_FLUSH_PENDING); > + if (panic_notifier_info_once(buf)) { > + panic_print_sys_info(false); > + kmsg_dump(KMSG_DUMP_PANIC); > + } > > - panic_print_sys_info(true); > + panic_notifier_pre_reboot_once(buf); > > + console_flushing(); > if (!panic_blink) > panic_blink = no_blink; > > @@ -363,8 +480,7 @@ void panic(const char *fmt, ...) > emergency_restart(); > } > > - atomic_notifier_call_chain(&panic_post_reboot_list, > - PANIC_NOTIFIER, buf); > + panic_notifier_post_reboot_once(buf); > > pr_emerg("---[ end Kernel panic - not syncing: %s ]---\n", buf); > > @@ -383,6 +499,15 @@ void panic(const char *fmt, ...) > > EXPORT_SYMBOL(panic); > > +/* > + * Helper used in the kexec code, to validate if any > + * panic notifier is set to execute early, before kdump. > + */ > +inline bool panic_notifiers_before_kdump(void) > +{ > + return panic_notifiers_level || crash_kexec_post_notifiers; > +} > + > /* > * TAINT_FORCED_RMMOD could be a per-module flag but the module > * is being removed anyway. > @@ -692,6 +817,9 @@ core_param(panic, panic_timeout, int, 0644); > core_param(panic_print, panic_print, ulong, 0644); > core_param(pause_on_oops, pause_on_oops, int, 0644); > core_param(panic_on_warn, panic_on_warn, int, 0644); > +core_param(panic_notifiers_level, panic_notifiers_level, uint, 0644); > + > +/* DEPRECATED in favor of panic_notifiers_level */ > core_param(crash_kexec_post_notifiers, crash_kexec_post_notifiers, bool, 0644); > > static int __init oops_setup(char *s) > diff --git a/tools/testing/selftests/pstore/pstore_crash_test b/tools/testing/selftests/pstore/pstore_crash_test > index 2a329bbb4aca..1e60ce4501aa 100755 > --- a/tools/testing/selftests/pstore/pstore_crash_test > +++ b/tools/testing/selftests/pstore/pstore_crash_test > @@ -25,6 +25,7 @@ touch $REBOOT_FLAG > sync > > # cause crash > -# Note: If you use kdump and want to see kmesg-* files after reboot, you should > -# specify 'crash_kexec_post_notifiers' in 1st kernel's cmdline. > +# Note: If you use kdump and want to see kmsg-* files after reboot, you should > +# be sure that the parameter "panic_notifiers_level" is more than '2' (the > +# default value for this parameter is '2') in the first kernel's cmdline. > echo c > /proc/sysrq-trigger From xen-devel-bounces@lists.xenproject.org Tue May 24 15:03:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 15:03:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336593.560943 (Exim 4.92) (envelope-from ) id 1ntW4Z-0004hT-M7; Tue, 24 May 2022 15:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336593.560943; Tue, 24 May 2022 15:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntW4Z-0004hM-JP; Tue, 24 May 2022 15:03:47 +0000 Received: by outflank-mailman (input) for mailman id 336593; Tue, 24 May 2022 15:03:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntW4Y-0004hE-Ua for xen-devel@lists.xenproject.org; Tue, 24 May 2022 15:03:46 +0000 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4f77fe7-db72-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 17:03:45 +0200 (CEST) Received: by mail-qt1-f170.google.com with SMTP id x7so11698642qta.6 for ; Tue, 24 May 2022 08:03:45 -0700 (PDT) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com. [209.85.219.181]) by smtp.gmail.com with ESMTPSA id b84-20020ae9eb57000000b006a35ac236c4sm6328388qkg.113.2022.05.24.08.03.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 08:03:42 -0700 (PDT) Received: by mail-yb1-f181.google.com with SMTP id v26so3064515ybd.2 for ; Tue, 24 May 2022 08:03:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4f77fe7-db72-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xvY3YRGz6Q5JdIA0GD3/2z1w0vgXjW2K3nWPGIL58cE=; b=l0lRcPUICIZ8JDuZ92d1Dm1MQxdI68Gu2fqad8tgtRc5ygknRRmkvf1blmcdLdsabH qNVkpl7d/zf0I+K4TF4QTaTYQ9MZ5yUuRNQ3V+5h+LpxVetHUq0bZMwZpZ/F1SIo1ZNL cbx/G6C0qg9TJv1JRG17VPYjkOIErFdstsGJOkQ28BcWG/5z1WwBAggEPZpTLYY+Lu3M P5S5fVl8NwqvUho4ilM+/POLdnXb75IUwQf2B82VoV5FInk/tk0A1kBJFRHJie5NZc7F k/wrxPxWShuR066K1UaNW3WMRD0yBFVW1pZ9RH0c+bOBG7xJEDSdweSM32vrp7Rw9ffM gdmQ== X-Gm-Message-State: AOAM530J0JQpuJiRDzF4kjTOHAPxOFihbs664J24rc6Ph173va4PgKan HDEW6Ua1mPIZ5v/t370W22gmszFro3zlGaQ1 X-Google-Smtp-Source: ABdhPJx5Ucq0yhsG1V8gn7d4NwKO0a9Ja3zJgx7Tkmpskrt2PNGCV3iO4qNS/HKBqh8KZfKf40jiow== X-Received: by 2002:a05:622a:144a:b0:2f3:bd33:5a1f with SMTP id v10-20020a05622a144a00b002f3bd335a1fmr20179797qtx.96.1653404624065; Tue, 24 May 2022 08:03:44 -0700 (PDT) X-Received: by 2002:a81:2143:0:b0:2fb:1274:247e with SMTP id h64-20020a812143000000b002fb1274247emr28501106ywh.384.1653404610585; Tue, 24 May 2022 08:03:30 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-8-dmitry.osipenko@collabora.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 24 May 2022 17:03:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off() To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dmitry, On Tue, May 24, 2022 at 3:41 PM Dmitry Osipenko wrote: > On 5/24/22 16:14, Geert Uytterhoeven wrote: > > On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko > > wrote: > >> Add kernel_can_power_off() helper that replaces open-coded checks of > >> the global pm_power_off variable. This is a necessary step towards > >> supporting chained power-off handlers. > >> > >> Signed-off-by: Dmitry Osipenko > > > > Thanks for your patch, which is now commit 0e2110d2e910e44c > > ("kernel/reboot: Add kernel_can_power_off()") in pm/linux-next. > > > > This causes the "poweroff" command (Debian nfsroot) to no longer > > cleanly halt the system on arm32 systems, but fail with a panic > > instead: > > > > -reboot: System halted > > +reboot: Power down > > +Kernel panic - not syncing: Attempted to kill init! exitcode=3D0x00000= 000 > > +CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted > > 5.18.0-rc7-shmobile-00007-g0e2110d2e910 #1274 > > +Hardware name: Generic R-Car Gen2 (Flattened Device Tree) > > + unwind_backtrace from show_stack+0x10/0x14 > > + show_stack from dump_stack_lvl+0x40/0x4c > > + dump_stack_lvl from panic+0xf4/0x330 > > + panic from do_exit+0x1c8/0x8e4 > > + do_exit from __do_sys_reboot+0x174/0x1fc > > + __do_sys_reboot from ret_fast_syscall+0x0/0x54 > > +Exception stack(0xf0815fa8 to 0xf0815ff0) > > +5fa0: 004e6954 00000000 fee1dead 28121969 4321fedc f= 0d94600 > > +5fc0: 004e6954 00000000 00000000 00000058 befa0c78 00000000 befa0c10 0= 04e56f8 > > +5fe0: 00000058 befa0b6c b6ec8d45 b6e4a746 > > +---[ end Kernel panic - not syncing: Attempted to kill init! > > exitcode=3D0x00000000 ]--- > > > > On arm64, "poweroff" causes a clean "reboot: Power down" before/after. > > > > On both arm32 and arm64, the same handlers are registered: > > - SYS_OFF_MODE_POWER_OFF_PREPARE: legacy_pm_power_off_prepare > > - SYS_OFF_MODE_POWER_OFF: legacy_pm_power_off > > > > On both arm32 and arm64, legacy_pm_power_off_prepare() is called. > > On both arm32 and arm64, legacy_pm_power_off() does not seem to > > be called. > > > > On arm32, both pm_power_off_prepare and pm_power_off are NULL. > > On arm64, pm_power_off_prepare is NULL, and > > pm_power_off is psci_sys_poweroff. > > > > Do you have a clue? > > Thanks! > > Thank you, Geert! I see the problem, the kernel_can_power_off() checks wh= ether power-off handler is registered, but it's always registered because l= egacy_pm_power_off is registered unconditionally. So it causes trouble for = platforms that don't have power-off handler installed at all. All platforms= that I tested have a power-off handler, so now wonder that I didn't notice= this before. > > This change should fix the problem, please give it a try: Thank you, that fixes the problem for me! Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From xen-devel-bounces@lists.xenproject.org Tue May 24 15:14:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 15:14:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336602.560955 (Exim 4.92) (envelope-from ) id 1ntWEo-0006Fc-Ks; Tue, 24 May 2022 15:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336602.560955; Tue, 24 May 2022 15:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWEo-0006FV-Hx; Tue, 24 May 2022 15:14:22 +0000 Received: by outflank-mailman (input) for mailman id 336602; Tue, 24 May 2022 15:14:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWEn-0006FP-6M for xen-devel@lists.xenproject.org; Tue, 24 May 2022 15:14:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f579f18-db74-11ec-837f-e5687231ffcc; Tue, 24 May 2022 17:14:20 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-dzMBTvfZPbG0OjXOJxZV5A-1; Tue, 24 May 2022 17:14:16 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3158.eurprd04.prod.outlook.com (2603:10a6:6:c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Tue, 24 May 2022 15:14:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 15:14:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f579f18-db74-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653405259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iIqgFGSr9cVe7EoazhtwtVTPJiaYpK3y3sv9moeCmK0=; b=Pa2EjoZezPLVRCecGXIPFuiJE9ptUupxbSml6TE5lgrkDpRVM5v7KC9RIXs/UMDj28yT6Y FZ5+qQrCnXdGphGcMsrwmVWl9+noJ+KP/7mcWI+ypGJF24NDK6X9TboBnqMDzijZifyA7p BpGqTH9hdvOj3qKRYVDYr1Q06t2eMf4= X-MC-Unique: dzMBTvfZPbG0OjXOJxZV5A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akBO7pQtHAJK23qV68IsMTB5UyktpxmJ5ieQCCnTtO+zmYAtN0hYOSM3bPyaKNJwYlxGiaJ+bpotUCnF/8peifQfIca7pv8rkWOP26z+3MxOEFLoR0AXRz/QE0WXS1rF3P9ns25Abvre9yTRvZKt+UpCKtcvo00HJL/gYeBy3NdsvqpiC3nY9CvvhzOhlo9k0o9fv8wDXJAIOWSrp1RjKfftP1sGA/p7XVYlw48WyKpmNaRUTHCT2VVlijaVBXv/mWbBeK41+gBKCm/JgutUwXZ0HzwqK34nz3J5mYxCLgVs2+/npgjmhpM+WVYQOoqhkeiD8UPwsDPZH8JrU7FQwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIqgFGSr9cVe7EoazhtwtVTPJiaYpK3y3sv9moeCmK0=; b=cikT9eMox7XNiOK22Vg9F999ME6OKTS4kM5EqJrIsRs+VP0Enofcekpw2gBDlxoX++DGMarsJMqFP46Dej26uJwoEeKW0BkjlRj1pwfqDYxWiCeT0OQm/s2Iy1lNw6FzrT+9SklX3TnNZnYtdE9DuGSgdtMzxmDoTJR5NM1jUZZue8JHStM2/JsT2sZLhqyIMgOMo8ty1Fe83pd6N3y/v79JyxPmT8/U8Vtv26K0OSKpNQsT4mJkPgNZX0wSUrpdzlcLblOAkTg0vHLqHY9fu+90MYGNkowPTbCzaDanYM4QwA16hpLWwvi7NahsNJGGkSwbF3T1ICREpoEx9Q7Vaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <27a9ae9e-07fa-8300-d5b9-f9a88e4a1754@suse.com> Date: Tue, 24 May 2022 17:14:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID Content-Language: en-US To: Jane Malalane Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220518132714.5557-1-jane.malalane@citrix.com> From: Jan Beulich In-Reply-To: <20220518132714.5557-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:20b:469::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a02677b-7354-4798-1208-08da3d981083 X-MS-TrafficTypeDiagnostic: DB6PR04MB3158:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ekr2Nn7AoVpfe0JzIR3pQVAn+IFThMxdt+mjWu2l4FO6JcsDOZTt/LbL5YpsHYlYcLm7A2uQEdSCY7h5gNGr91Rmw5eRh9pIKjlljl96iCQZHaChCj81CabMMgc32NyK1CR/Wc7wZ+Pm2w3IYyMt435kwO6yL+f/JDLT0DatA49VMflfQKsfSOq3ZDhxrqELj4jvm0BCcmWncXFi/ZR712fMAeJ6D5PH1gx7wJdwBLhcRDguyAMmLxcdGJ2EUZEtg4AUY24Kv20qkjyB6cB4rOOaprkbVO4+FJv5oU5g0RypDAfTR0ZchinT7SNAGUBJFN90SlphF/7H2lgQ8ByY5jktefz7/gWOI7Si6iHp0uhV4E6KH3L8OXtlbpnlyvNx2UT55UMvjzbyRMKoYFJaQu8zRqjT8698j8jf67Ki7Edu1C5j0/OszVK+A2jFjEeOnk/iE+9jnfbLYPlBUQTZO11xNfxUKHTg8n9vkfrU16X8wrJqxrQCr1c8DvcYI09Z3eq4Ref4EkzQkXSpwaPVTqI8DKq4WIdevSZPxMok8buWtLVS3hx0tfILYNlE7AXgbr9EMND3L1/lTHrrktHhIVXZ2J0T+0VkgUGaFvCgHMF8FxgKhT/dwMoK9w9B8idM2ofMUBm/763g5oiuIzwZN93+S3BeSBl6L7YxBXkTrNVrIa3+NsOFb+QKQ5nEhLUW7bkorLv42B0s9/HBMUGRFFlHAjmiDoDdK/cyAhNjdX4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(38100700002)(6666004)(6916009)(86362001)(31696002)(36756003)(6486002)(54906003)(6512007)(53546011)(4744005)(8936002)(5660300002)(6506007)(4326008)(2616005)(8676002)(83380400001)(186003)(26005)(508600001)(66946007)(66476007)(66556008)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUJMSHN4aFNxbURibzA4MkZDVU5ISFZta3AydXdUcGdpd1k1VFpDTkVNeGdG?= =?utf-8?B?K2tKbVVvODFVQ2xLOUU1NnRHRUU1RUlNT1psV3UwVEpBbUZKcDlJbVFBRUVM?= =?utf-8?B?cDY1MnZHWThYUTcwOVlUc2FkLzhTZkh4Q3BxenArZTQvQ2N5ejFUWG9DekFn?= =?utf-8?B?bDllODZmdVZscnlKaTQvV1dXUjV4eER5S2Q3YUYzVlIyRXFEYkwzY1BPYmp0?= =?utf-8?B?N1dKaGhWaVdKMjBiVHVrTlQrVmw2Z3hRMGJBSUZnZUZXNHcvZVJTYzNTYk04?= =?utf-8?B?djJ1RTM3K3ZhbEVqYTdQR3VrSFcrRFMxUG00RCt0SnBOb0xYZVBmVXBDYjNi?= =?utf-8?B?c1VqOEFwNXBsRDJ4WFhXWmhqM0FvcE5BRWZHdW5MV3Y3dlFtaUVIYzRtOFZT?= =?utf-8?B?MTVYRlBjcUtZVEMrdzlXSTVJQnV3bFVUUHhNTlRmV25hSlVWSUw1SUJ3dk9u?= =?utf-8?B?SnlLOVRFOTNpN2Via1VqaHZVd0VqNjhTcVdyYVFlcTJlWEUvNXU5QXVMQ1R2?= =?utf-8?B?Z2taSW5CVGtWeDdtMExpbUlIb2pkbGh5WGNuRjlTNnp1MHJ2OUV6Yit5QnZ2?= =?utf-8?B?Nkhwc3NOeHhCLytCSzFCLzdUUjAvd3ZuNjc0UUJQTDZZbVU3QUpUN0NvNElS?= =?utf-8?B?dVhDeFRHZVBpMVduOXNsWndON2VUSUNrU3AxZDZ0VWxKZ2F6YVQyWVM3MFc0?= =?utf-8?B?YUh5S0Q0aExqRDhGeE9sdFBJSHNmSERMaDhmZm9kL3dtUEtLQzlHMjU5UWJp?= =?utf-8?B?bXdDTnB4a01lZDVsaElRN211ditvLzRMQ3QrRU5NVkJjVHNnR3pYQ21KckZu?= =?utf-8?B?b2RNcUVKdkhqZW9sSFJpMGhQZHdhYUwzdEJDN2FKVFpFRnN2cUwySk9LRjYv?= =?utf-8?B?NHJzR0NtbGo2V3ZOcjhHeTZLSWJBaGNkMnNXYk4yazdacHlQQzdtUUlYMjFN?= =?utf-8?B?SitrbThLTldhSFJEMnh4ODRvVjBGZXdYQnlHMThNeFdZYjRnKy9kTk5IbFh0?= =?utf-8?B?eFdNL0pSc0UvVk1jSVpHZ04vbGhnK0sxNW44alBsVUpEQURpWW1QeGRXdHhP?= =?utf-8?B?YnNGRzhVRXZBRXBpVll3K0hsbkxpb3FNS1RSTjFCTWFRcVJQcTB4OTd6YlRE?= =?utf-8?B?ZS9COFBWZUJLYm00TnF5K0x2TGtHWmtJWHhPOVdUeCtHNTE2U2hTbEM0bk9N?= =?utf-8?B?b2FQYkMxMEppdjAzS1pFYzRpb3ZXR1N2QzFRMktLOGpRL0FGYVd1c1FiWmYr?= =?utf-8?B?dTNTeTUrS05GR3Zsem9TZHBuU29vQmJmZmNTTTJuVVZoYzZUaDM1akxxL01T?= =?utf-8?B?U0I5aE9lQXdpa3V5bHBTWkVSYnBoSVZPNWxUb1BhUXl4M0NmbkxQWTlYVlJj?= =?utf-8?B?TER1OG96b1lDMmVLWFNoRE1OTVFuZXl3N3lHR3k5S0pJSTczVnhFNmJna3hx?= =?utf-8?B?ay84dWVOY1hqdEh3dUNmNHZsUnUwL3VoSXk1Q0V2UUNxVzJlU09Ua3lUaGdn?= =?utf-8?B?UVl3Z2pnbkxaVkhIbEY2cVIxNEdSS3YwM0hmWCtyazlWUVZ1L0xKaDFVVHFy?= =?utf-8?B?WDlxb0VFbHJVRURhNi9USm5FMHZMOHlqQ2pOVEZWeHJISjZoa0kzaG9Gbldh?= =?utf-8?B?YlBrWmVOSlllZ2llUFRtUytyUXlwTy9td3JQNk55NHNtM0lTbG9sekpsR3Nr?= =?utf-8?B?aWpWbjEvcngxbkpvV1RheDZlbzI1OW5OR0Jud1ptNkRlQjI3MWV0dzd0TUxP?= =?utf-8?B?T1U2VXo1QzQrOHI4amc5MHFUQ1JYcUVEd1FwNUhLT3lVZXhablRwOFVObEdZ?= =?utf-8?B?eldTdEVrdTl1N1VHRDdDOFlOTlg2LzBQNElSMG0xWU5oY1dWWjI5dEF2K1pz?= =?utf-8?B?UXhOSVN6NW54T2xuTFg0UEcrUFplVkRpelF1dEE3d1hUdDNhMTNieXVUSitr?= =?utf-8?B?czZnQWhjRWNrOTdIdVB1cXVNdEl0UG9jL2tsemNqNDJObllhWHJVQkJtNGpR?= =?utf-8?B?SFIyU2EyMWFtWlBmYmllMHlrUWk2SThtSVcvaTYwZTIvYmhQZXQ4VDBzTS9o?= =?utf-8?B?Szg2Z2c5blArbGc5UGVFazQrNnpqVEUwZ0IrSDNhbnRsVTRERUpTOGU1cWk0?= =?utf-8?B?UitiTHhEUzZPZDg4NURLQmtwZkUzNHErOXhBcmlFK1p1cGpDbXBLRmMzY0dU?= =?utf-8?B?TnpmK2k5aGFDaGlaUDBSam9oVTVZZlVyRm9DVFljZmJNQ3B2RklFUWZxUTRp?= =?utf-8?B?cW0vT0M5RDFBczd6ekt3RVlubExlWXU5T1kyYXJIQmxmalVLOWFUSlFJZmc2?= =?utf-8?B?RmF3Z1Bzd0h6SldQK2w0cDNoUnNoZmhzcFJMRjF2a0FyaWNoVTBEQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a02677b-7354-4798-1208-08da3d981083 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:14:14.9410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ELRItQbni5kHvNHcaZt/H0DwJ0CechuONZ5t4rQCoDEKsDnG0OPew7+o/ykflRtwk/Drawx2CEQ6S0qK86672A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3158 On 18.05.2022 15:27, Jane Malalane wrote: > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x86/include/asm/domain.h > @@ -14,8 +14,14 @@ > > #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) > > +/* > + * Set to true if either the global vector-type callback or per-vCPU > + * LAPIC vectors are used. Assume all vCPUs will use > + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. > + */ > #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ > - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) > + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ > + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) I continue to think that with the vCPU0 dependency added to is_hvm_pv_evtchn_domain(), is_hvm_pv_evtchn_vcpu() should either be adjusted as well (to check the correct vCPU's field) or be deleted (and the sole caller be replaced). Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 15:27:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 15:27:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336610.560966 (Exim 4.92) (envelope-from ) id 1ntWRi-0007qw-RD; Tue, 24 May 2022 15:27:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336610.560966; Tue, 24 May 2022 15:27:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWRi-0007qp-NT; Tue, 24 May 2022 15:27:42 +0000 Received: by outflank-mailman (input) for mailman id 336610; Tue, 24 May 2022 15:27:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWRh-0007qj-8O for xen-devel@lists.xenproject.org; Tue, 24 May 2022 15:27:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bfeb602-db76-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 17:27:39 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-PwKQD3DuN4ODNTMmzeTALQ-1; Tue, 24 May 2022 17:27:38 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8953.eurprd04.prod.outlook.com (2603:10a6:20b:408::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 15:27:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 15:27:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bfeb602-db76-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653406059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=29N3yclwzPgKiRCnJIOY0AYd2tH9ld7ttxwK87jtz7E=; b=DvjbFHDqo6bsNYWOxNeno97GDK50i3g1sJeimWEJkbBCx14OrUWWuqSCJhsX0BlYbcRir8 CUaxySolA1uCjm0wjH9b/EZP72aB3PhJDGJfUWrcOagkkVi5od6j58UFTv7dNEMUI69Df2 mjAkZP/0J59r6bVh/NbQnqaprnpQw8Q= X-MC-Unique: PwKQD3DuN4ODNTMmzeTALQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SBP2/fKoEqW24Ugu8yRPkOIlXQqT/X/oVOlMoVvx6OzN2H77wcrJYG5N/rB8wY4Gj3ce5govw/AD0XcgekeCD1Q2Q91X9+uZUNGiI7Y52SGbcyTUlCbZKUBD+Lw6ymb5+U5LoxABvBnhZbrwFre+sW3G3DPzZhz5oa7lDyQhuaawSx1t2wXTCWRLyBtAFbv8hAue5o6Fw8mAFOPMlt4Ti3ahcM5Jq/aTnFNaNXQdXAUoucjA7eBH60+gzfUHemrqy792raK71SLUEww/pN3HbzyorsfIvVXQYW45Lz7z3sSgMgkj7/ttpLvNh/Prnhx9F1vJizYMS9vfCs1Gu/r1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=29N3yclwzPgKiRCnJIOY0AYd2tH9ld7ttxwK87jtz7E=; b=UIOMqOQ0VIo7H6kn50k0JYwiE6GuaZZiRxuCMBSxAm596Ra1o6uO2UMuh0yke+lRShQqh65Dsehc//4IsFxHjVgIT/rCxyfI34HwPNYw2TTpGaL1L9qbW3KFkabkK2xac+KL0H6yNRy3nUc/vaMmhyHclaKUgYqCOVy6YpH1+iII+NFdwR+iL+ihSLACJUwySPNHKiHsS4wFyAaINbwRUYk8sgnNWokfgHmB82zaCrL79n25anH++vcdVGqgwr3gBT24eIEo36qF5bjZwR7oaD8fqzZo+fARh/ZknprkTlauZZYDynRnnR761I4Ya76+QQPqIzVqJwUBJLlrIL5qTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> Date: Tue, 24 May 2022 17:27:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220524105052.5210-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220524105052.5210-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0010.eurprd04.prod.outlook.com (2603:10a6:20b:92::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a559a7c1-1dde-41ce-b372-08da3d99eea1 X-MS-TrafficTypeDiagnostic: AM9PR04MB8953:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yo63s0Tq3HX/slEiCnMLO2j7RwKglubXscHs8IMtasa1Ht1KFIRQxoN+zqUmjyLawFChfX82cDGyZ+fSLMxdDoyTGf8EdXpIQ/ZRgFiAMPxLqWJy2ZlXu8ocd+2+BMxw8eVbGnAQ9riWpaT1rxRg553cub1/wPwI0v06Jkbhb5hGTIRFXRi76cCgA8g+2o46WRFgJchKE3zbdSff72iqynwNEvcepgjKxgmWbAiMno0Hf7JJgkF8aq0BlKPSdVTJGW4evh5VHxA1AIQ3kTm1+D7fTJSiTmtKwkYGZZ8tl/yG3aASvKwFHX1C/BkNWdr+XlKT/4JvlpqSAf5Icb6F8RsErDIX/quWZC1k9iTK2UFXvrRngdPNf7nTnQrDrJVHgiDfcRFT8g9ntKrta5EVooaL21v8xqr4yE130omBazPNFst651oMCs7U4gZUlWkUrxVxfAWqaHMqbEmOV+HaN9AZujX+K+jk3liv71gxIWZPxQ6lGPYk3XyHaSm/jRvUj+foDrI1pUb1FipuU+Ykl0oOCQKqBAEETDpbF1rSFi/gMvoBSLx4sXHI4Bgy3B/8joryZfTBFeAmxP2OkFS+3xN6sxqC1yxx+GY8Tw5cKRaqmB6FdlZTJ4KUKWknrz3lB0aDFDe2s7SxtPW+M61XLyWkZYBFDc0sPoQBgGQd/TmRGZ9SGerNbZF+ZTbkb/nyaotl4SmofsgqsGxyROqmR1otVCatcI0z0LeGMHJMXlbcKKzJwYN3ErZewpK52HPp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(4326008)(66946007)(6512007)(8676002)(86362001)(38100700002)(26005)(66476007)(31696002)(6506007)(36756003)(31686004)(53546011)(316002)(508600001)(6486002)(6916009)(8936002)(54906003)(186003)(83380400001)(2906002)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUNSRktSdFBwSnNUZnJnRnM1a3h2dzFPSGpUb3ZWS1E1V2lwNWdDU3VqSUk4?= =?utf-8?B?ZXN1TWo4bzNoRmR5cDZocnIvYm0zLzh5bXdZdHU2d0pqUE1zYlZyck0rT0U1?= =?utf-8?B?eTB0ZEtrQTlkV0l1VWs2VmhEYXU1djBGaWNVdjlTazdSTm5pZjRiR3RCRUsz?= =?utf-8?B?dm5CTGhTeWdUT0NTTkdkWUt5UmQrZExaRlJRSzJVanVtaHRBYnVSWjVHcGQw?= =?utf-8?B?cllPb0R6aTFnbXVWTndVWTFnV29zWU5UblBzb0xDN1NIeUZkUTZGWmxFK2F6?= =?utf-8?B?RmpobHdJdkMvRWZoQzhCZFltaHgrdTcvRURRalAwNEp1VnB2WkJmdTFLbURy?= =?utf-8?B?bi8yZzVUWHcyNmFHalpRQXlMdUJMZnloc29wNytWUVJFcFgyRlRQMXpzaHRG?= =?utf-8?B?MmtJcEYyMXNNd3RpUXVLelN3aWVqNENGSmlzNHBGY1VXZHZGLzFoNDN3QlVS?= =?utf-8?B?N0JOSGxxL2RtTjJsZmRGUS85YzdkQThOdWNDU01zUHVPWWJLZ3B1L2RObUNP?= =?utf-8?B?SHJPejEvQlFpVGJOTkNCUzhoSGJmams4RDluaFZaWWxhcnFFN2dEWWZ3STVS?= =?utf-8?B?MVZmNUlES3dOaUphNzVvelNBY3lEOTRmMFZjSCtWMnA1eEc5NWlJUXkvbXFs?= =?utf-8?B?QkU3eEVWWStuMTU4azZOcUw2UjV6dnJrQjFYMW43dHNkZVUzVERmOFR1eE1k?= =?utf-8?B?a2NWdnpCUkp6NlRrVXp4eWZaN0FhWGVsWXd4MjdxZ1YzT2V6MzAzM0VoaHda?= =?utf-8?B?cUJaVEMxd0F5Y05uKytQVjU3TFhndm0wOGFrSVBjL3NYN3lyZkxHWEdhaUF4?= =?utf-8?B?d3RHSDB3b2hwcGNocTUrTS9vTFFjcXR3a2V6aTBqd0Y2RkJkM2N4NFlMUzdB?= =?utf-8?B?dU1IWlQyNUprR2V2VDdJRG9yT3lhRnNLOTBxa0ZXUmpVVEVodkJpZ2pibk1H?= =?utf-8?B?TElPZXBORTdpVm11N2lmMmdYcktZdUR1N2RSUFF5M3FtRFZQUVBIWXI0cmJo?= =?utf-8?B?bG9nRnZvc2RRSlFRWmwySjdSdU1zdE40SGU0dm1maXdDUzdkV0FvZ2RRazdN?= =?utf-8?B?TEhaUDdpWjA2UDNERkVvK085U3lqcmZIbWY5dmZkU3ZvMVg2M2h4STBsY1RC?= =?utf-8?B?dzVGdjZhU01BMTZ4di9hMHZ0alA3cWNYMmxQVkVvckh5bzdpTStQNzIwNHlX?= =?utf-8?B?VlVxV0c1WUhLMDJHQUVuSDVsNlUvMlFjSWJFenZYcFlzVnpaeGxldmtGemdF?= =?utf-8?B?Y2pqMDFic3AxbDhxWnRyMzg2bVdhNHk4eUNnRFZ4TXVrOTh4Z2swNFgzUVJY?= =?utf-8?B?Y3p4RVlSWDZIQXlRcjV3T0lnVlJ5SlFWMjQzSTJMSVRpZmF5Z0R6T2s2ZXha?= =?utf-8?B?RVlQZHNuNGRTU1RITTNFa2c0YmQ3QWhUUy9TNEsxVDR2bzlwT1dOMlR2WTkx?= =?utf-8?B?NDZUeWRMZGxhdXBsTkc0b3UwVzRrbXFoOW9wUW5HMUZhTjEzTDJMcm1sQTkx?= =?utf-8?B?NWp5RlQ3UG9SV2U3K3VmQXhtbUZ0ZlJONFZmRDZvWnFYOUV2OTZyVGpqTnpx?= =?utf-8?B?N3M2Y3lsdGpucStzanBVREY4c1M5VjBPZllOa2phbmwrTnpoRTdpOHBDV3JB?= =?utf-8?B?dkRBNGgyUWxhTDNINjJZemM1cHRaRXFxTkhKWklrbmdobEVyRUFSeXVBbEJx?= =?utf-8?B?S0lTRS85RjVlcXB5MFN0U2dHTldpWmcydFZESlpoK1ZsVE8rTjg2bEI3SFNW?= =?utf-8?B?bzVXdG1iVGkySURoT2ZqbzdCYUpMSTJYb2VrTXNhRmdJT29ueDcySTdlM3Uy?= =?utf-8?B?cjNIRnFUSTlOTGE5UndST0lZTmhmU1laUmx1R2dkekhIZGg5TStEbzJRaCt4?= =?utf-8?B?YlMrcWhtT1BJSHVybUUwMVFuRnU3US9BR3lSSFFhUzlTMEF0ZkVFODRFQVBI?= =?utf-8?B?SFlYMjlQWHlFSHlIbEdlblhUelNWWW5hbGV1a2FOby9GcEtrYVRwQU9teUdx?= =?utf-8?B?bVMwaXJZVkJQaWdvQitJaE1KSEkwYnkvZXN6ZEw2MERzaC9BMGZWSG8zc2NR?= =?utf-8?B?ckZEbWV4cnhxQllhbjJzOUU3aGp6SXhTNDNkbGJCTjlOeUFQOXBGeDZSYWNh?= =?utf-8?B?dzZRSVhUMkpiazdiaWVXSU1uS2Z1MU1zcExRRGYySGd6OVJ4bER6YlBJLys2?= =?utf-8?B?TzRJb1VDREcvbDF1ZVZtREJ3QkNvUnRMSUZPUkxXYUd2cys1dU43cE1tdkwy?= =?utf-8?B?aExCek9ocUhRZHFzWGttUTIxYXZvNnBob084WXBPZXpSZnEvRVhuMG9hRGdJ?= =?utf-8?B?Nm8vY1BORDF3aGtFV2Irem5UOTZFV1BqZUNDMDk0Y1dDUkIrTytFQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a559a7c1-1dde-41ce-b372-08da3d99eea1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:27:37.0617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EQBUZMek4jmknDaxW8HWGABoQC9NYTv/Aq7f8IsIfMJmoIJOBH1VSSY2VwC7AJS0vkqbOAFLx9LfowC5/FCcOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8953 On 24.05.2022 12:50, Roger Pau Monne wrote: > Booting with Shadow Stacks leads to the following assert on a debug > hypervisor: > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- > CPU: 0 > RIP: e008:[] flush_area_mask+0x40/0x13e > [...] > Xen call trace: > [] R flush_area_mask+0x40/0x13e > [] F modify_xen_mappings+0xc5/0x958 > [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 > [] F alternative_branches+0xf/0x12 > [] F __start_xen+0x1ef4/0x2776 > [] F __high_start+0x94/0xa0 > > > This is due to SYS_STATE_smp_boot being set before calling > alternative_branches(), and the flush in modify_xen_mappings() then > using flush_area_all() with interrupts disabled. Note that > alternative_branches() is called before APs are started, so the flush > must be a local one (and indeed the cpumask passed to > flush_area_mask() just contains one CPU). > > Take the opportunity to simplify a bit the logic and intorduce > flush_area_all() as an alias for flush_area_mask(&cpu_online_map...), This is now stale - you don't introduce flush_area_all() here. Sadly nothing is said to justify the addition of a cast there, which - as said before - I think is a little risky (as many casts are), and hence would imo better be avoided. > --- a/xen/arch/x86/smp.c > +++ b/xen/arch/x86/smp.c > @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > { > unsigned int cpu = smp_processor_id(); > > - ASSERT(local_irq_is_enabled()); > + /* Local flushes can be performed with interrupts disabled. */ > + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))); > + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ > + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); What about FLUSH_FORCE_IPI? This won't work either with IRQs off, I'm afraid. Or wait - that flag's name doesn't really look to force the use of an IPI, it's still constrained to remote requests. I think this wants mentioning in one of the comments, not the least to also have grep match there then (right now grep output gives the impression as if the flag wasn't consumed anywhere). Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 15:51:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 15:51:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336619.560977 (Exim 4.92) (envelope-from ) id 1ntWoJ-0002nk-VM; Tue, 24 May 2022 15:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336619.560977; Tue, 24 May 2022 15:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWoJ-0002nd-R5; Tue, 24 May 2022 15:51:03 +0000 Received: by outflank-mailman (input) for mailman id 336619; Tue, 24 May 2022 15:51:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWoI-0002nX-Mi for xen-devel@lists.xenproject.org; Tue, 24 May 2022 15:51:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4efe00a7-db79-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 17:51:01 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-jCpPxoJCNx-HI-Em7NwCKQ-2; Tue, 24 May 2022 17:50:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4180.eurprd04.prod.outlook.com (2603:10a6:208:5d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Tue, 24 May 2022 15:50:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5273.023; Tue, 24 May 2022 15:50:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4efe00a7-db79-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653407460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8ExjgSwA7dRiOPzPOEtjjhk7KUDe/c7dT4XCf5Fh3M=; b=aA7t69YiKurRa9XtuH0WcS3zurSTBM/wGy+vmozUv2XuVR+SYx9zGEYokbR66OcWR8SV5J +nehJyjJZnwB4I0VCsCxYXx00wTqkWLDu5kJQNiQNhe3Sk0bElu78ULL20iI5UFN0vNUsO 0vCsGcO4yMZPAHJTg5LFE62W7PuyW18= X-MC-Unique: jCpPxoJCNx-HI-Em7NwCKQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBfAH8q7aUFjyTwMJpAStqeZThOvCcqtbLN6HOCA4sBcgh/LjUmhzhXiaubyEikNas0INzuu3EutklNsXfxN54oxXGJc6+cur1PqSlwYi2PrPDi3Ms6B4g/XRel6OM1QjJIsG6uUFNTg1gjT649lM7w2fcP1oHzS+FWsEF7O7ylGPSRFFqmBPsUnmYpO53RvQPpNLDzO811PfT9BDyLd4aGHHK8IhyEEa3FIhZw/fPrdVoagzLNwl3BKYq2RNhI7xPyOq4yDX0cIMsEnzc4NEYVeuLm5DaXkTxwUD7MdOPLT0PVAV6FjEqU4DJgMSsZST64n4QZHdMCN1MMUyrivFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8ExjgSwA7dRiOPzPOEtjjhk7KUDe/c7dT4XCf5Fh3M=; b=Z0rXC/b6oe8zhsojtz/dcCmMCa2KakeGce9SNl04amzzB6VA2EJKLjdXCCu2aJytmlYE9t55m497LW8RjjNrGTL6iZkOYnrv+iuJ0bQiUZnAm6oeDsPizd5cRgcAyxVbbabMJ5lr5VPikBrqIT/kpVorRk2TbzET++4z32h3oXHhuTp/BeergGlgLZJRn7VTiXanrL3AoyPvXdnl0F5tCtbJwZ9dLuk4ek+mrBXQTO1eUnnY3sqNqyD3x1yIW8/tp0mEtxqejDR2v7GiQdhB+JE53bOYfA6tkKSF7K9vmdHl1vw8O+4aoNSyvLZ12xDmDbnfDO0vuaD0lL+mX7qANA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 24 May 2022 17:50:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xsm: refactor and optimize policy loading Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220523154024.1947-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220523154024.1947-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P194CA0001.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a69afbd8-fcf4-48e9-8a0c-08da3d9d312c X-MS-TrafficTypeDiagnostic: AM0PR04MB4180:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gBzetiBL/mn2K0R0azN9tDHazQkdBjZlAsTlk5hVsgmXB+ht8uXwkaa8y9/UvsC1V58eedI1Z+1AnynNWeIzByfta28vXq8fXCM1rO+KVRFRCPs38Ft0JyctnrKtM/ceyvL1clHoHmL2fPxXIjCdn/pWW3SeHDOxTxagdYP2sdHtKeZnNvWGerNLCq6fhQ0weN3HiXhQOQEvoWxBVDqyF+Gi7yCpcR4e/CZ68yp/BqFd43Hw+Ut09Eo7TUxhLIajHdI86asuQCDDsR6EGESfppX91+AxiNf2UCgqFGW2pyDDUk4fMVgezjC/pm0BkveXQv7BvyrLhFMGlGnzSJ2S2k852Q2yLkJEQ7DEHSwjZnLhSS22ADHPWkZxlA4wNl2Lfs7f29+L+lk5cbtCRo11HvqdPpWsTePXlm3bB4G78qT1k2CEFNui3FwFkJsXXFsRwutrclSeR5TzYUwdl25/eiJ064eL393fi7HMCuiIUp8AevU9z/U6WnqRYyX/pMq06Mda7XY06tkoPxJP8LYOe7gTmccuk7ejniZMpurPadSIPwGvj5u4kCaYVwL1Jv/tqJGXisxBkxBST6dLbDc3CXRKLvU/aE2KdfDZhpmVr7rQxazOz58cFoDWF9lX9TqpZRv+4AMpDcbDrITDd6EKUE75ZwxeekWj+1CbaSwW+XCwD0DjnsiwqjN4V1FgdLd41NPN3/uSbpGHSEdF7FiHBEgzQiNDrnywQMa3P/2jVyupZPuk4b1AM9jqt1ehYDGE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(66476007)(86362001)(6486002)(66946007)(4326008)(8676002)(66556008)(508600001)(38100700002)(316002)(6916009)(186003)(6506007)(6512007)(26005)(53546011)(2616005)(36756003)(5660300002)(8936002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWQ1ZjBMQ2ltaHJGZkZEdFlzK0hJY1R3S3hPTXl6TTNZNVNUT3NhYW9rckMw?= =?utf-8?B?VkxQenVlVWg4eEVoOWVabUFFS2xodVpYdm1TK0hDK2ZoQTcxQkJhYnp4NlhL?= =?utf-8?B?NHRHajVYTjR2WlB2cTM4Rm93aTg3TFZvTUNSTFM4OE9ZMlk4WERiN2RFNml2?= =?utf-8?B?b0JwQ0RZVng4OWVYUU5XR3l0YjFKblBObS8xakJlVitmVkFZbDFiSExrZEFj?= =?utf-8?B?TFVobmw5UlZ2TU5vcXZLdjJmK1ZCT1ZvWnFaUjRkK0Y5Q1JQdkp3aDJ3UGpH?= =?utf-8?B?VGVZL0JjcTlvQU9DU0FaaGlpRXF1OXJjU0Y1V1dtN0xqMm42ZFIzN3lGOGJO?= =?utf-8?B?M040azZCK0EwaFhxcVRxSGVJaDQ3UjVTRFFRVnZtQjV0UUgzblNPNGVyLzB1?= =?utf-8?B?cXkzU2VsNFdCTnNJK2xMa2NjR3M0QitsL2ZiY0Iybm4rUS9VYXo1eVp3RzMy?= =?utf-8?B?L2V5b3JZVmlrTk5xcFJWdURFeUM5K3FQVDlWeCtZbC9JbHRVdk44bzMweTlJ?= =?utf-8?B?cE1MaTdVUmRyMzFuMlZ5YWxFTnpyTUlmdGFOT1FBM3MrbzBZNG1DTHgwMXdh?= =?utf-8?B?Q1pHd0ZsdmY5YkxQWTNKalkyQVBpcFNGcFgrNnlEaVRZcHlGZGhzUTV0a1Jw?= =?utf-8?B?ZFBVRUdnVnRUSGdnUFJJbG9pZk5mbU0rb2ErdjE1cWE4NHlMa3V1aWRWZTdp?= =?utf-8?B?YlJUQ0IvN2JXbmZWVjVxRVlNVmE5VTVJQTFGczhoei9tT01uSzhvdXZST0FB?= =?utf-8?B?QTZJQXpURy9rUnVIdDlVU3JPaDN3amdmbmhhcXJkWGU3blZCUnprWXFPNk9m?= =?utf-8?B?a2tmNk5jZ0cwYjdNLzh3eU8zRyszcW9XWk14MWlzZjlqMDZXSTZuYUFNT3Ja?= =?utf-8?B?ZnVYTFRpRDEyRDVRckc5S0Q1cDVuM0dnUnhvVFBhOWQ2SDIzREIxajBWR3dn?= =?utf-8?B?NDBhM2xlU0Y2ZmcrMHlsbm1ORnI5V0lINzUzLzZBd3B3WW1ueGRkeC9oeFZ3?= =?utf-8?B?bnRTeTA4ai9QeThPcmdST1FVek03UkgzL2RHZi9OOXlxeU9mMEc2WXZ4TjF6?= =?utf-8?B?UHBYSUpqVXFRdWJyeVkyRk5Ed3N3bFhNdmhISFdVZVJFcFM1L1R1NXVUMFI3?= =?utf-8?B?N25XaHFwVENjdHhiSmVIZnFpSi9Fd3FrdWpmcjgvM2xGMUJkUEVoRGlHYVla?= =?utf-8?B?aUlSamZkamZmK3FRMldobTNpRzdyUTZHQ1FmTThrd2J2R2I3UTJrV21QcVZt?= =?utf-8?B?QTc2QURITTdqTDQ5cEtiTGI2YllveklpWm42ZldqMkQxcW1YMWtWOGVtQ05u?= =?utf-8?B?OTE2TkVxajBVUXNNY1pNblR6U1k4RkdEVmRyNVdabEUyWVlkb242NlZmMkRC?= =?utf-8?B?WG81ZUpUQzlsK1dXalAyR2tXTVJET2w3U1NsdGc2c1RPSkUwVmtKZW5xbDcv?= =?utf-8?B?elNINExVOGdjTkFZTlRWZ21LcmJWMy9aZzN6NGdsS2g5aU1kSVpmeGNhUTF3?= =?utf-8?B?cTZkL3U0d3I0dm5WV3VYWmdJT0ZTMnN5MEE4Sk50UTJJa2JiQmJKVFY2YTBs?= =?utf-8?B?N2VJd2NDaEVKMzlFNk5pakU3WEU5V3lndFN2VXU5U09uZUtDcTVkYTFUcXJ3?= =?utf-8?B?YkVzZFZYUVhOYXdGSTV1Ti9KQXdPMklHMkE2R3kvSjZ2dmR6QittYkhEVWt0?= =?utf-8?B?Q1I3VXhsVnlZMEZuMWFhNDc1cjlCZFBEeEhlUnphbU9YelBWZkxKbXJrMHIr?= =?utf-8?B?cDRNV2JtSlR5TThodmpuYVhyZCt4OTlBRitwemNVa2M1aVZBR1VOVmM4YlZk?= =?utf-8?B?K001R0ZTNW45WVJmaEQ4VDU2cGVRQXlzZ3M1eWdOczNQTk1NVHZxV2ZwMjZY?= =?utf-8?B?alZmQUV2QVpNRklkV2pUSUVSWXkxN3Z5aThKTHdyN1BQZFprMU02RHZMekN3?= =?utf-8?B?cGhLSEFOOXE2WTlPSUlWTWk0NE9aaHVoNVNKc0grRTZYdUhtVjh4cVA2eSsw?= =?utf-8?B?WWVHRU5PWXNvRkU2dm5sd1pQQlFtOXNTN0RmTWs0enpqMWtHZDRnY21MWXZW?= =?utf-8?B?N0JtbzRLU3pQVXBjVENQMWFxa1dFOWx3bkUvdk80QU11MFEwT0U0UEtjNTFl?= =?utf-8?B?aFhrMGUvaUFoeVliVzJaemVyd1FiaWNQckV3azRFSnQ3bmdyOTF4MGM2c0cx?= =?utf-8?B?cVRjSGFqNTJ5UXpRd3hSQTg3WkJ3M01FTTFYeC85MXIxdUZrOG5XSTR1YTh3?= =?utf-8?B?U3dwSVpUUitqUFZPWW1TazREUGtpRnk5VnMrdCt4bU8vNTVYaTVuOURhbHQy?= =?utf-8?B?WmF5YnNQaUJtckkzZTRzZjgxd2JpYUI4cWljYTNPdVJqSjJjR1c5Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a69afbd8-fcf4-48e9-8a0c-08da3d9d312c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:50:57.2383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: naXtPGujtExBuHnzxWahv2DZOasAtR1FlIX9AKO+9R8wJj8Los6vuWo8+dCmOtUq77w4cJJNbd5aBxIWJ5kMMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4180 On 23.05.2022 17:40, Daniel P. Smith wrote: > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -55,19 +55,35 @@ static enum xsm_bootparam __initdata xsm_bootparam = > XSM_BOOTPARAM_DUMMY; > #endif > > +static bool __initdata init_policy = > +#ifdef CONFIG_XSM_FLASK_DEFAULT > + true; > +#else > + false; > +#endif Simply IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT) without any #ifdef-ary? > @@ -148,11 +156,11 @@ int __init xsm_multiboot_init( > > printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); > > - if ( XSM_MAGIC ) > + if ( init_policy && XSM_MAGIC ) > { > ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, > &policy_size); > - if ( ret ) > + if ( ret != 0 ) Nit: Stray change? > @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( > { > int i; > module_t *mod = (module_t *)__va(mbi->mods_addr); > - int rc = 0; > + int rc = -ENOENT; I'm afraid I can't easily convince myself that this and the other -ENOENT is really relevant to this change and/or not breaking anything which currently does work (i.e. not entirely benign). Please can you extend the description accordingly or split off this adjustment? > @@ -79,7 +87,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) > paddr_t paddr, len; > > if ( !mod || !mod->size ) > +#ifdef CONFIG_XSM_FLASK_POLICY > + { > + *policy_buffer = (void *)xsm_flask_init_policy; I don't think we want a cast here, especially not when it discards "const". Instead the local variables' types want adjusting in xsm_{multiboot,dt}_init() as well as the types of the respective parameters of xsm_{multiboot,dt}_policy_init(). > + *policy_size = xsm_flask_init_policy_size; > return 0; > + } > +#else > + /* No policy was loaded */ > + return -ENOENT; > +#endif I think this is easier to read if you put the braces there unconditionally and have the #if / #else inside. And if you wanted to I think you could get away without any #else then. Jan From xen-devel-bounces@lists.xenproject.org Tue May 24 16:01:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:01:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336627.560987 (Exim 4.92) (envelope-from ) id 1ntWyZ-00050U-UZ; Tue, 24 May 2022 16:01:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336627.560987; Tue, 24 May 2022 16:01:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWyZ-00050N-Rn; Tue, 24 May 2022 16:01:39 +0000 Received: by outflank-mailman (input) for mailman id 336627; Tue, 24 May 2022 16:01:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntWyY-00050H-So for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:01:39 +0000 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca1c0e4e-db7a-11ec-837f-e5687231ffcc; Tue, 24 May 2022 18:01:37 +0200 (CEST) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-edeb6c3642so22791638fac.3 for ; Tue, 24 May 2022 09:01:37 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s12-20020a0568301c6c00b006060322125esm5217753otg.46.2022.05.24.09.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 09:01:35 -0700 (PDT) Received: (nullmailer pid 3883217 invoked by uid 1000); Tue, 24 May 2022 16:01:34 -0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca1c0e4e-db7a-11ec-837f-e5687231ffcc X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6jzGflikaNvQlRBg9TN37pKT3uRBxsEEX4IWek2qFQw=; b=ud6bfSHCbhJ4XYjrNJAXtoPs/uwzrms2mvEehhWRCySEBSeMtzJtRgU72GLnu9pSAD NtEvSc4etBF0BTTSZby00iskuPSLAwr0op4vVTXZuI6yldZzk3XLy1fT7vQ1KngFhmZI ydXKSP+wAD5Js/93QjspCWSfdnh1CgrZdQeYEwYdsSPqckrUgF38REr9lF/HCciDOSWr fPwc7ZWjk1nvNk3z7/474gWpK4CrdiD+TAbEHGAHvBQlqs8IEU1bT4BPjBleko8WnAAO 5HG/kp9sE0WTEvImKBLAlf2mp4mjAnvAv92UvS1q+LaDpsxIOSCumoR4FUBf66XoICfv IPLg== X-Gm-Message-State: AOAM532+HY8qOTcCfVxGe/+aPb+XyWCKYtvszKOcCpIs+NqAXd0SeENl F6JrHqZuPmIX3J/ccbCFNQ== X-Google-Smtp-Source: ABdhPJzH8Fdg6RlKojwWxDTyu4yBCyschwGc8rMrHO3T48dxy5qyReCvUbV6SsubRECLF0EBuNxexg== X-Received: by 2002:a05:6870:a40a:b0:f1:9240:2776 with SMTP id m10-20020a056870a40a00b000f192402776mr2835469oal.140.1653408095924; Tue, 24 May 2022 09:01:35 -0700 (PDT) Date: Tue, 24 May 2022 11:01:34 -0500 From: Rob Herring To: Stefano Stabellini , Saravana Kannan Cc: Oleksandr , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops Message-ID: <20220524160134.GE3730540-robh@kernel.org> References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: +Saravana On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: > On Mon, 23 May 2022, Oleksandr wrote: > > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: > > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > > > > > > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > > > > > > > > wrote: > > > > > > > >     This would mean having a device > > > > > > > > node for the grant-table mechanism that can be referred to using > > > > > > > > the > > > > > > > > 'iommus' > > > > > > > > phandle property, with the domid as an additional argument. > > > > > > > I assume, you are speaking about something like the following? > > > > > > > > > > > > > > > > > > > > > xen_dummy_iommu { > > > > > > >       compatible = "xen,dummy-iommu"; > > > > > > >       #iommu-cells = <1>; > > > > > > > }; > > > > > > > > > > > > > > virtio@3000 { > > > > > > >       compatible = "virtio,mmio"; > > > > > > >       reg = <0x3000 0x100>; > > > > > > >       interrupts = <41>; > > > > > > > > > > > > > >       /* The device is located in Xen domain with ID 1 */ > > > > > > >       iommus = <&xen_dummy_iommu 1>; > > > > > > > }; > > > > > > Right, that's that's the idea, > > > > > thank you for the confirmation > > > > > > > > > > > > > > > > > > > > >    except I would not call it a 'dummy'. > > > > > >   From the perspective of the DT, this behaves just like an IOMMU, > > > > > > even if the exact mechanism is different from most hardware IOMMU > > > > > > implementations. > > > > > well, agree > > > > > > > > > > > > > > > > > > It does not quite fit the model that Linux currently uses for > > > > > > > > iommus, > > > > > > > > as that has an allocator for dma_addr_t space > > > > > > > yes (# 3/7 adds grant-table based allocator) > > > > > > > > > > > > > > > > > > > > > > , but it would think it's > > > > > > > > conceptually close enough that it makes sense for the binding. > > > > > > > Interesting idea. I am wondering, do we need an extra actions for > > > > > > > this > > > > > > > to work in Linux guest (dummy IOMMU driver, etc)? > > > > > > It depends on how closely the guest implementation can be made to > > > > > > resemble a normal iommu. If you do allocate dma_addr_t addresses, > > > > > > it may actually be close enough that you can just turn the grant-table > > > > > > code into a normal iommu driver and change nothing else. > > > > > Unfortunately, I failed to find a way how use grant references at the > > > > > iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I > > > > > am > > > > > not too familiar with that, so what is written below might be wrong or > > > > > at > > > > > least not precise. > > > > > > > > > > The normal IOMMU driver in Linux doesn’t allocate DMA addresses by > > > > > itself, it > > > > > just maps (IOVA-PA) what was requested to be mapped by the upper layer. > > > > > The > > > > > DMA address allocation is done by the upper layer (DMA-IOMMU which is > > > > > the glue > > > > > layer between DMA API and IOMMU API allocates IOVA for PA?). But, all > > > > > what we > > > > > need here is just to allocate our specific grant-table based DMA > > > > > addresses > > > > > (DMA address = grant reference + offset in the page), so let’s say we > > > > > need an > > > > > entity to take a physical address as parameter and return a DMA address > > > > > (what > > > > > actually commit #3/7 is doing), and that’s all. So working at the > > > > > dma_ops > > > > > layer we get exactly what we need, with the minimal changes to guest > > > > > infrastructure. In our case the Xen itself acts as an IOMMU. > > > > > > > > > > Assuming that we want to reuse the IOMMU infrastructure somehow for our > > > > > needs. > > > > > I think, in that case we will likely need to introduce a new specific > > > > > IOVA > > > > > allocator (alongside with a generic one) to be hooked up by the > > > > > DMA-IOMMU > > > > > layer if we run on top of Xen. But, even having the specific IOVA > > > > > allocator to > > > > > return what we indeed need (DMA address = grant reference + offset in > > > > > the > > > > > page) we will still need the specific minimal required IOMMU driver to > > > > > be > > > > > present in the system anyway in order to track the mappings(?) and do > > > > > nothing > > > > > with them, returning a success (this specific IOMMU driver should have > > > > > all > > > > > mandatory callbacks implemented). > > > > > > > > > > I completely agree, it would be really nice to reuse generic IOMMU > > > > > bindings > > > > > rather than introducing Xen specific property if what we are trying to > > > > > implement in current patch series fits in the usage of "iommus" in Linux > > > > > more-less. But, if we will have to add more complexity/more components > > > > > to the > > > > > code for the sake of reusing device tree binding, this raises a question > > > > > whether that’s worthwhile. > > > > > > > > > > Or I really missed something? > > > > I think Arnd was primarily suggesting to reuse the IOMMU Device Tree > > > > bindings, not necessarily the IOMMU drivers framework in Linux (although > > > > that would be an added bonus.) > > > > > > > > I know from previous discussions with you that making the grant table > > > > fit in the existing IOMMU drivers model is difficult, but just reusing > > > > the Device Tree bindings seems feasible? > > > > > > I started experimenting with that. As wrote in a separate email, I got a > > > deferred probe timeout, > > > > > > after inserting required nodes into guest device tree, which seems to be a > > > consequence of the unavailability of IOMMU, I will continue to investigate > > > this question. > > > > > > I have experimented with that. Yes, just reusing the Device Tree bindings is > > technically feasible (and we are able to do this by only touching > > grant-dma-ops.c), although deferred probe timeout still stands (as there is no > > IOMMU driver being present actually). > > > > [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ignoring > > dependency > > [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks (2.10 > > GB/1.95 GiB) > > > > > > Below the working diff (on top of current series): > > > > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c > > index da9c7ff..6586152 100644 > > --- a/drivers/xen/grant-dma-ops.c > > +++ b/drivers/xen/grant-dma-ops.c > > @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = { > > > >  bool xen_is_grant_dma_device(struct device *dev) > >  { > > +       struct device_node *iommu_np; > > +       bool has_iommu; > > + > >         /* XXX Handle only DT devices for now */ > >         if (!dev->of_node) > >                 return false; > > > > -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); > > +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); > > +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, > > "xen,grant-dma"); > > +       of_node_put(iommu_np); > > + > > +       return has_iommu; > >  } > > > >  void xen_grant_setup_dma_ops(struct device *dev) > >  { > >         struct xen_grant_dma_data *data; > > -       uint32_t domid; > > +       struct of_phandle_args iommu_spec; > > > >         data = find_xen_grant_dma_data(dev); > >         if (data) { > > @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) > >         if (!dev->of_node) > >                 goto err; > > > > -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", &domid)) { > > -               dev_err(dev, "xen,backend-domid property is not present\n"); > > +       if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", > > +                       0, &iommu_spec)) { > > +               dev_err(dev, "Cannot parse iommus property\n"); > > +               goto err; > > +       } > > + > > +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || > > +                       iommu_spec.args_count != 1) { > > +               dev_err(dev, "Incompatible IOMMU node\n"); > > +               of_node_put(iommu_spec.np); > >                 goto err; > >         } > > > > +       of_node_put(iommu_spec.np); > > + > >         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > >         if (!data) > >                 goto err; > > > > -       data->backend_domid = domid; > > +       /* > > +        * The endpoint ID here means the ID of the domain where the > > corresponding > > +        * backend is running > > +        */ > > +       data->backend_domid = iommu_spec.args[0]; > > > >         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, > >                         GFP_KERNEL))) { > > (END) > > > > > > > > Below, the nodes generated by Xen toolstack: > > > >         xen_grant_dma { Nit: iommu { > >                 compatible = "xen,grant-dma"; > >                 #iommu-cells = <0x01>; > >                 phandle = <0xfde9>; > >         }; > > > >         virtio@2000000 { > >                 compatible = "virtio,mmio"; > >                 reg = <0x00 0x2000000 0x00 0x200>; > >                 interrupts = <0x00 0x01 0xf01>; > >                 interrupt-parent = <0xfde8>; > >                 dma-coherent; > >                 iommus = <0xfde9 0x01>; > >         }; > > Not bad! I like it. > > > > I am wondering, would be the proper solution to eliminate deferred probe > > timeout issue in our particular case (without introducing an extra IOMMU > > driver)? > > In reality I don't think there is a way to do that. I would create an > empty skelethon IOMMU driver for xen,grant-dma. Does it have to be an empty driver? Originally, IOMMU 'drivers' were not drivers, but they've been getting converted. Can that be done here? Short of that, I think we could have some sort of skip probe list for deferred probe. Not sure if that would be easiest as IOMMU specific or global. Rob From xen-devel-bounces@lists.xenproject.org Tue May 24 16:07:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:07:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336636.560999 (Exim 4.92) (envelope-from ) id 1ntX3u-0005eV-Kb; Tue, 24 May 2022 16:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336636.560999; Tue, 24 May 2022 16:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX3u-0005eO-FN; Tue, 24 May 2022 16:07:10 +0000 Received: by outflank-mailman (input) for mailman id 336636; Tue, 24 May 2022 16:07:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX3t-0005eE-IH; Tue, 24 May 2022 16:07:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX3t-0003rB-EL; Tue, 24 May 2022 16:07:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX3s-0006Lt-Tu; Tue, 24 May 2022 16:07:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntX3s-0007Kk-TO; Tue, 24 May 2022 16:07:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fuh7K30UbNnP9Y9S9DWo3NflL+ftuzOIi3H3zAttRTY=; b=hZBQ2Xb3ajr1BfUUs7ud95JJ2q 4+VJiXo2KDZrSAn8pYcmqgG0A9M4g76hpI6bai+2VuKtN7q2X0FcFZrsR9H/tw5NkSG4WHwOzcHU8 F+vmKZ7kiHBtqLoKH8yu5vqt2SGvuaWc4f/T8WJIOfEozjb+xPdJcx1YxcogdWWNtu5Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170716: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=143a6252e1b8ab424b4b293512a97cca7295c182 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Tue, 24 May 2022 16:07:08 +0000 flight 170716 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170716/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 143a6252e1b8ab424b4b293512a97cca7295c182 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 0 days Testing same since 170716 2022-05-24 11:12:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Alexander Egorenkov Alexander Gordeev Alexandre Belloni Alexandru Elisei Andre Przywara Anshuman Khandual Ard Biesheuvel Baolin Wang Baoquan He Borislav Petkov Catalin Marinas Chen Zhongjin Chen Zhou Chengming Zhou Dan Carpenter Daniel Beer Daniel Lezcano Darryn Anton Jordan Dave Hansen Dave Kleikamp David Arcari David E. Box David Sterba Deyan Wang Frank Crawford Gabriele Mazzotta Geert Uytterhoeven Geert Uytterhoeven Greg Kroah-Hartman Guilherme G. Piccoli Guo Ren Guo Ren Guo Zhengkui Haitao Huang Hans de Goede Haowen Bai Harald Freudenberger Hector Martin Heikki Krogerus Heiko Carstens Ilkka Koskinen Ilya Leoshkevich Jakob Koschel Jarkko Sakkinen Jason Wang Jithu Joseph John Donnelly Jorge Lopez Juerg Haefliger Juerg Haefliger Juergen Gross Julia Lawall Kefeng Wang Laurent Vivier Linu Cherian Linus Torvalds Linus Walleij Luca Miccio Luca Stefani Madhavan T. Venkataraman Marc Zyngier Marco Elver Marek Szyprowski Mario Limonciello Mark Brown Mark Pearson Mark Pearson Mark Rutland Masahiro Yamada Matteo Croce Max Filippov Maximilian Heyne Maximilian Luz Michael Niewöhner Michael Schmitz Michael Shych Michal Orzel Minghao Chi Naresh Kamboju Nathan Chancellor Naveen Krishna Chatradhi Nick Desaulniers Nick Hawkins Niklas Schnelle Oleksandr Tyshchenko # Arm64 only Pali Rohár Palmer Dabbelt Paul Gortmaker Peter Collingbourne Peter Oberparleiter Peter Zijlstra (Intel) Peter Zijlstra Pingfan Liu Prarit Bhargava Qi Liu Randy Dunlap Reinette Chatre Ren Yu Ren Zhijie Rob Herring Robin Murphy Roger Pau Monné Russell King (Oracle) Sebastian Andrzej Siewior SeongJae Park Shaokun Zhang Srinivas Pandruvada Stefano Stabellini Steven Rostedt (Google) Suma Hegde Sumanth Korikkar Sven Schnelle Tanmay Jagdale Thomas Huth Thomas Richter Thomas Weißschuh Tom Rix Tong Tiangen Tony Luck Valentin Schneider Vasily Gorbik Wan Jiabing Wang Kefeng Will Deacon Yang Li Yi Yang Zhen Lei jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7627 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 24 16:11:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336647.561010 (Exim 4.92) (envelope-from ) id 1ntX8M-00077S-AJ; Tue, 24 May 2022 16:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336647.561010; Tue, 24 May 2022 16:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX8M-00077L-6o; Tue, 24 May 2022 16:11:46 +0000 Received: by outflank-mailman (input) for mailman id 336647; Tue, 24 May 2022 16:11:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntX8K-000779-S2 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:11:45 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33c37b81-db7c-11ec-837f-e5687231ffcc; Tue, 24 May 2022 18:11:43 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id u23so31646335lfc.1 for ; Tue, 24 May 2022 09:11:43 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id r5-20020a19ac45000000b0047255d21167sm2602292lfc.150.2022.05.24.09.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 09:11:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c37b81-db7c-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qm9weLaNL4nn8FQertxYN6C+mkrhTu3vRp9alXEDss4=; b=C3hl1VyjK6sleZh5X3NsN4HkcpazdnD3DvB91rml+7SI+bM/M9WlbinHobisvAdCDx TIFsLkor6QMpQ+FOcvltP6Y7vjOIApbqfERArF1rBmpDxNUuwx3fmpXDfcy1X6WJZ1og H6LBMwkKrwG7NZRW7NvQL17o1gKB/CEveeaG+/NsUinUz1IQJ2lOgsAm2oLcM9shofvf To0dJAOR5lz51Pr9hSJZi6WTUIs5PHuUhUWSAW33LrcpoG/AfTRe7fR2ArBOLDc+GaWJ WEvDxgUBgJqU4u56STpTuQ0nSE3Y18JCw5qNaFyUpBmtM610Ul9uM7WhuYgYqw7rD9G3 ABzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qm9weLaNL4nn8FQertxYN6C+mkrhTu3vRp9alXEDss4=; b=M3TMPesK4jdSTDexTSj3vZPA4d/cbTe8pvAi4yx4v4OspnGE3oQlMZWMGqOZha0+fj pirrteXOHBA7CVEZNvJKQaJUYuoHmm0S+lzV/702z1nGRxV/8iwemyq16lIT6h4WE+z8 RXuk1P7++p+flpL6b+D8vNI6s4GqfDcz+k8+WmuBu6z8jyZ0fM56mNft6KsBhWAP9bjR MOCOBI2H69LBe3wU0FzMkgM6PoEPc0kWXtz0CuVW6Oh7vsGSJBu6y3VxOwE3ayJT9qap hOXPlcFNr4n1QguXrEcxSSLbvrK7+krb19Tn8IHRfnR4lIgVadDEZ9Y56e+xlSLAWLVw SMdg== X-Gm-Message-State: AOAM532RcDZS3oSDyCd0c1rajn8PvKpMBtpf6oOHEJcQkq+BZv9Wdidz jdy1k5pf5ap/iluhprfitF4= X-Google-Smtp-Source: ABdhPJymEImVNMQVJEQurd3WYXxyCnU02Ld7OWJwHzzYYlnnKByiq/YpRyTQbxag9jFDkQ9qyPIpBA== X-Received: by 2002:a05:6512:1316:b0:473:fda3:8dc8 with SMTP id x22-20020a056512131600b00473fda38dc8mr20057105lfu.529.1653408702637; Tue, 24 May 2022 09:11:42 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Stefano Stabellini Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> From: Oleksandr Message-ID: <606dfdcc-ec10-0c4a-04e9-72cd73ee6676@gmail.com> Date: Tue, 24 May 2022 19:11:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 24.05.22 04:58, Stefano Stabellini wrote: Hello Stefano, all > On Mon, 23 May 2022, Oleksandr wrote: >>>> On Thu, 19 May 2022, Oleksandr wrote: >>>>>> On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: >>>>>>> On 18.05.22 17:32, Arnd Bergmann wrote: >>>>>>>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko >>>>>>>> wrote: >>>>>>>>     This would mean having a device >>>>>>>> node for the grant-table mechanism that can be referred to using >>>>>>>> the >>>>>>>> 'iommus' >>>>>>>> phandle property, with the domid as an additional argument. >>>>>>> I assume, you are speaking about something like the following? >>>>>>> >>>>>>> >>>>>>> xen_dummy_iommu { >>>>>>>       compatible = "xen,dummy-iommu"; >>>>>>>       #iommu-cells = <1>; >>>>>>> }; >>>>>>> >>>>>>> virtio@3000 { >>>>>>>       compatible = "virtio,mmio"; >>>>>>>       reg = <0x3000 0x100>; >>>>>>>       interrupts = <41>; >>>>>>> >>>>>>>       /* The device is located in Xen domain with ID 1 */ >>>>>>>       iommus = <&xen_dummy_iommu 1>; >>>>>>> }; >>>>>> Right, that's that's the idea, >>>>> thank you for the confirmation >>>>> >>>>> >>>>> >>>>>>    except I would not call it a 'dummy'. >>>>>>   From the perspective of the DT, this behaves just like an IOMMU, >>>>>> even if the exact mechanism is different from most hardware IOMMU >>>>>> implementations. >>>>> well, agree >>>>> >>>>> >>>>>>>> It does not quite fit the model that Linux currently uses for >>>>>>>> iommus, >>>>>>>> as that has an allocator for dma_addr_t space >>>>>>> yes (# 3/7 adds grant-table based allocator) >>>>>>> >>>>>>> >>>>>>>> , but it would think it's >>>>>>>> conceptually close enough that it makes sense for the binding. >>>>>>> Interesting idea. I am wondering, do we need an extra actions for >>>>>>> this >>>>>>> to work in Linux guest (dummy IOMMU driver, etc)? >>>>>> It depends on how closely the guest implementation can be made to >>>>>> resemble a normal iommu. If you do allocate dma_addr_t addresses, >>>>>> it may actually be close enough that you can just turn the grant-table >>>>>> code into a normal iommu driver and change nothing else. >>>>> Unfortunately, I failed to find a way how use grant references at the >>>>> iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I >>>>> am >>>>> not too familiar with that, so what is written below might be wrong or >>>>> at >>>>> least not precise. >>>>> >>>>> The normal IOMMU driver in Linux doesn’t allocate DMA addresses by >>>>> itself, it >>>>> just maps (IOVA-PA) what was requested to be mapped by the upper layer. >>>>> The >>>>> DMA address allocation is done by the upper layer (DMA-IOMMU which is >>>>> the glue >>>>> layer between DMA API and IOMMU API allocates IOVA for PA?). But, all >>>>> what we >>>>> need here is just to allocate our specific grant-table based DMA >>>>> addresses >>>>> (DMA address = grant reference + offset in the page), so let’s say we >>>>> need an >>>>> entity to take a physical address as parameter and return a DMA address >>>>> (what >>>>> actually commit #3/7 is doing), and that’s all. So working at the >>>>> dma_ops >>>>> layer we get exactly what we need, with the minimal changes to guest >>>>> infrastructure. In our case the Xen itself acts as an IOMMU. >>>>> >>>>> Assuming that we want to reuse the IOMMU infrastructure somehow for our >>>>> needs. >>>>> I think, in that case we will likely need to introduce a new specific >>>>> IOVA >>>>> allocator (alongside with a generic one) to be hooked up by the >>>>> DMA-IOMMU >>>>> layer if we run on top of Xen. But, even having the specific IOVA >>>>> allocator to >>>>> return what we indeed need (DMA address = grant reference + offset in >>>>> the >>>>> page) we will still need the specific minimal required IOMMU driver to >>>>> be >>>>> present in the system anyway in order to track the mappings(?) and do >>>>> nothing >>>>> with them, returning a success (this specific IOMMU driver should have >>>>> all >>>>> mandatory callbacks implemented). >>>>> >>>>> I completely agree, it would be really nice to reuse generic IOMMU >>>>> bindings >>>>> rather than introducing Xen specific property if what we are trying to >>>>> implement in current patch series fits in the usage of "iommus" in Linux >>>>> more-less. But, if we will have to add more complexity/more components >>>>> to the >>>>> code for the sake of reusing device tree binding, this raises a question >>>>> whether that’s worthwhile. >>>>> >>>>> Or I really missed something? >>>> I think Arnd was primarily suggesting to reuse the IOMMU Device Tree >>>> bindings, not necessarily the IOMMU drivers framework in Linux (although >>>> that would be an added bonus.) >>>> >>>> I know from previous discussions with you that making the grant table >>>> fit in the existing IOMMU drivers model is difficult, but just reusing >>>> the Device Tree bindings seems feasible? >>> I started experimenting with that. As wrote in a separate email, I got a >>> deferred probe timeout, >>> >>> after inserting required nodes into guest device tree, which seems to be a >>> consequence of the unavailability of IOMMU, I will continue to investigate >>> this question. >> >> I have experimented with that. Yes, just reusing the Device Tree bindings is >> technically feasible (and we are able to do this by only touching >> grant-dma-ops.c), although deferred probe timeout still stands (as there is no >> IOMMU driver being present actually). >> >> [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ignoring >> dependency >> [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks (2.10 >> GB/1.95 GiB) >> >> >> Below the working diff (on top of current series): >> >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c >> index da9c7ff..6586152 100644 >> --- a/drivers/xen/grant-dma-ops.c >> +++ b/drivers/xen/grant-dma-ops.c >> @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = { >> >>  bool xen_is_grant_dma_device(struct device *dev) >>  { >> +       struct device_node *iommu_np; >> +       bool has_iommu; >> + >>         /* XXX Handle only DT devices for now */ >>         if (!dev->of_node) >>                 return false; >> >> -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); >> +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); >> +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, >> "xen,grant-dma"); >> +       of_node_put(iommu_np); >> + >> +       return has_iommu; >>  } >> >>  void xen_grant_setup_dma_ops(struct device *dev) >>  { >>         struct xen_grant_dma_data *data; >> -       uint32_t domid; >> +       struct of_phandle_args iommu_spec; >> >>         data = find_xen_grant_dma_data(dev); >>         if (data) { >> @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) >>         if (!dev->of_node) >>                 goto err; >> >> -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", &domid)) { >> -               dev_err(dev, "xen,backend-domid property is not present\n"); >> +       if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", >> +                       0, &iommu_spec)) { >> +               dev_err(dev, "Cannot parse iommus property\n"); >> +               goto err; >> +       } >> + >> +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || >> +                       iommu_spec.args_count != 1) { >> +               dev_err(dev, "Incompatible IOMMU node\n"); >> +               of_node_put(iommu_spec.np); >>                 goto err; >>         } >> >> +       of_node_put(iommu_spec.np); >> + >>         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); >>         if (!data) >>                 goto err; >> >> -       data->backend_domid = domid; >> +       /* >> +        * The endpoint ID here means the ID of the domain where the >> corresponding >> +        * backend is running >> +        */ >> +       data->backend_domid = iommu_spec.args[0]; >> >>         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, >>                         GFP_KERNEL))) { >> (END) >> >> >> >> Below, the nodes generated by Xen toolstack: >> >>         xen_grant_dma { >>                 compatible = "xen,grant-dma"; >>                 #iommu-cells = <0x01>; >>                 phandle = <0xfde9>; >>         }; >> >>         virtio@2000000 { >>                 compatible = "virtio,mmio"; >>                 reg = <0x00 0x2000000 0x00 0x200>; >>                 interrupts = <0x00 0x01 0xf01>; >>                 interrupt-parent = <0xfde8>; >>                 dma-coherent; >>                 iommus = <0xfde9 0x01>; >>         }; > > Not bad! I like it. Good. > > >> I am wondering, would be the proper solution to eliminate deferred probe >> timeout issue in our particular case (without introducing an extra IOMMU >> driver)? > In reality I don't think there is a way to do that. I would create an > empty skelethon IOMMU driver for xen,grant-dma. Ok, I found yet another option how we can avoid deferred probe timeout issue. I am not sure whether it will be welcome. But it doesn't really require introducing stub IOMMU driver or other changes in the guest. The idea is to make IOMMU device unavailable (status = "disabled"), this way of_iommu_configure() will treat that as success condition also. https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L31 https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L149         xen_grant_dma {                 compatible = "xen,grant-dma";                 #iommu-cells = <0x01>;                 phandle = <0xfde9>;                 status = "disabled";         };         virtio@2000000 {                 compatible = "virtio,mmio";                 reg = <0x00 0x2000000 0x00 0x200>;                 interrupts = <0x00 0x01 0xf01>;                 interrupt-parent = <0xfde8>;                 dma-coherent;                 iommus = <0xfde9 0x01>;         }; I have checked, this "fixes" deferred probe timeout issue. Or we indeed need to introduce stub IOMMU driver (I placed it to driver/xen instead of driver/iommu, also we can even squash it with grant-dma-ops.c?). This stub driver also results in NO_IOMMU condition (as "of_xlate" callback is not implemented). diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index a7bd8ce..35b91b9 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -335,6 +335,10 @@ config XEN_UNPOPULATED_ALLOC           having to balloon out RAM regions in order to obtain physical memory           space to create such mappings. +config XEN_GRANT_DMA_IOMMU +       bool +       select IOMMU_API +  config XEN_GRANT_DMA_OPS         bool         select DMA_OPS @@ -343,6 +347,7 @@ config XEN_VIRTIO         bool "Xen virtio support"         depends on VIRTIO         select XEN_GRANT_DMA_OPS +       select XEN_GRANT_DMA_IOMMU         help           Enable virtio support for running as Xen guest. Depending on the           guest type this will require special support on the backend side diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 1a23cb0..c0503f1 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -40,3 +40,4 @@ xen-privcmd-y                         := privcmd.o privcmd-buf.o  obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)    += xen-front-pgdir-shbuf.o  obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)    += unpopulated-alloc.o  obj-$(CONFIG_XEN_GRANT_DMA_OPS)                += grant-dma-ops.o +obj-$(CONFIG_XEN_GRANT_DMA_IOMMU)      += grant-dma-iommu.o diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c new file mode 100644 index 00000000..b8aad8a --- /dev/null +++ b/drivers/xen/grant-dma-iommu.c @@ -0,0 +1,76 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Stub IOMMU driver which does nothing. + * The main purpose of it being present is to reuse generic device-tree IOMMU + * bindings by Xen grant DMA-mapping layer. + */ + +#include +#include +#include + +struct grant_dma_iommu_device { +       struct device *dev; +       struct iommu_device iommu; +}; + +/* Nothing is really needed here */ +static const struct iommu_ops grant_dma_iommu_ops; + +static const struct of_device_id grant_dma_iommu_of_match[] = { +       { .compatible = "xen,grant-dma" }, +       { }, +}; + +static int grant_dma_iommu_probe(struct platform_device *pdev) +{ +       struct grant_dma_iommu_device *mmu; +       int ret; + +       mmu = devm_kzalloc(&pdev->dev, sizeof(*mmu), GFP_KERNEL); +       if (!mmu) +               return -ENOMEM; + +       mmu->dev = &pdev->dev; + +       ret = iommu_device_register(&mmu->iommu, &grant_dma_iommu_ops, &pdev->dev); +       if (ret) +               return ret; + +       platform_set_drvdata(pdev, mmu); + +       return 0; +} + +static int grant_dma_iommu_remove(struct platform_device *pdev) +{ +       struct grant_dma_iommu_device *mmu = platform_get_drvdata(pdev); + +       platform_set_drvdata(pdev, NULL); +       iommu_device_unregister(&mmu->iommu); + +       return 0; +} + +static struct platform_driver grant_dma_iommu_driver = { +       .driver = { +               .name = "grant-dma-iommu", +               .of_match_table = grant_dma_iommu_of_match, +       }, +       .probe = grant_dma_iommu_probe, +       .remove = grant_dma_iommu_remove, +}; + +static int __init grant_dma_iommu_init(void) +{ +       struct device_node *iommu_np; + +       iommu_np = of_find_matching_node(NULL, grant_dma_iommu_of_match); +       if (!iommu_np) +               return 0; + +       of_node_put(iommu_np); + +       return platform_driver_register(&grant_dma_iommu_driver); +} +subsys_initcall(grant_dma_iommu_init); I have checked, this also "fixes" deferred probe timeout issue. Personally I would prefer the first option, but I would be also happy to use second option in order to unblock the series. What do the maintainers think? -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue May 24 16:16:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:16:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336655.561021 (Exim 4.92) (envelope-from ) id 1ntXCS-0007q4-Te; Tue, 24 May 2022 16:16:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336655.561021; Tue, 24 May 2022 16:16:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXCS-0007px-P1; Tue, 24 May 2022 16:16:00 +0000 Received: by outflank-mailman (input) for mailman id 336655; Tue, 24 May 2022 16:16:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXCR-0007pr-SN for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:15:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cab1d78f-db7c-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 18:15:58 +0200 (CEST) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 12:15:52 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CY4PR03MB3047.namprd03.prod.outlook.com (2603:10b6:903:133::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Tue, 24 May 2022 16:15:49 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 16:15:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cab1d78f-db7c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653408958; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eaZAWNBt51mFZ4D+UaLNPDlrcyvuFhdGRBRYioRc9BY=; b=fmVFMb1UzjVs2DjlaGrg8NVtwlmYsWNu9UbPFrPvPwog65epZtZWjic8 n8XliGlNySE6UIR7TvwN/qAM6aRW+d+0pG+tEQjAw4LJZWtBK/GlqQLob C9uZIa/FeTxOZy4NTfwJ78tc2pRCVCD/GP0ImU2yRhUrxlPUfkM8OVkJC 4=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 71438674 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aO2UualzXFJkSo/PFGbQ0xro5gz1J0RdPkR7XQ2eYbSJt1+Wr1Gzt xJNXzqOPa6LMzP9e4t1Ooi1oxxQuJ7dxtEwQQFo+y48ECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWV/V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYZAcXEqLuh+4mVCJGSBh3E5JM9ufIGC3q2SCT5xWun3rE5dxLVRhzFqpBv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kBg21YasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8Q7O9fRovwA/yiRP/bLLNOTMQeaQVMhqlHeUh GOf0172V0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwASEy66R6AHAAGEBF2dFcIZ/65VwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPXdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:AFRMHa6PPVc/hcgliwPXwVSBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJYq a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLbhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqnzd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7k16xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXavoJBiKprzPLd MeTf01vJ1tABOnhjHizyNSKeWXLzsO9kzseDlAhiSXuwIm7kyRgXFohvD3pU1wiq7Ve6M0mN gsDZ4Y5Y2mbvVmGZ6VV91xNvdeNAT2MGLxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="71438674" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXFwxV1iBVQxFMpCU3h7ufqtsM2KzLP09GmXFHvS8zvLHoQDZvBEB4f0dpbM4ersNrJiGCPmo39d5bDBmkf3R3ivzNfIxd3F7ice39prx9QzFgGzZaPoaltEuSE8uNqmENDuhqfhZW88LmIoh4GGHUC8upJBNbBVsgZhhU/d/LmDi+UKFkSwNXb6Pw6zM3BkeFKeaFlMbWMZnR4oGPpPUX8jQhHeCW0ZLFObCMoJNS8AHBT6cj8myk/jr1ISTxv79YYIaYoU1qasPI4JUHJEc9rfX2IxMBPIxzTLpQvLuegjBT/JyzV+IWos/HBtEc8qLN8+PkKErUEDJF9FMXNojg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bic+FVCBiOdBeEsuUkPpsfdFF/0ZeMDB1NQpH7jaHwM=; b=Ia1NuBlK7M3Yx3xPHybeKRvKpPdR+Glfwvw8FjNpwOoO7QxZybHp1ri+3Fzn0BVFFW8DB1OiGR14HPMFbYwZXDQ+uSfL+6FUw46e0kYdzdAjzc89JOtYOPyhyz28IU9R5IpaTT7OB7GmcKuTI1lqNTytY1YbaN/gMf2ogG3k+hRNzHKPGBP3AbbSzn6pLkkoQosYp9wmnInKNVT4RaCuWM7CxsM/up2HsIuMd9h1NMrrOdAnO4IDNC032diUdsUkiEZkf5MKGR/jk9YsjGwILJHICqauatPd0dmYjurj9RPD1FsQA8Z7c2FawCR/u9mqrOKnt+mHKknvOev2g+9O4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bic+FVCBiOdBeEsuUkPpsfdFF/0ZeMDB1NQpH7jaHwM=; b=NOpc8L5litV8KDmw/xjgaSVguMSurZ152gYzqLXW7pQk5jmlYY7L2tPANMIpsRDZSNB0zYvqIdZntpo68z5f2h5tHSAyV+OsiOxGdRTy3412xVC1/+0eNDcvC0LgjF0dGY5WZK0YrMe2QO3D7dA961aG6OYoPgmC3+kFQccSQmM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 24 May 2022 18:15:45 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich , Jane Malalane Cc: Andrew Cooper , Wei Liu , Xen-devel Subject: Re: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID Message-ID: References: <20220518132714.5557-1-jane.malalane@citrix.com> <27a9ae9e-07fa-8300-d5b9-f9a88e4a1754@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <27a9ae9e-07fa-8300-d5b9-f9a88e4a1754@suse.com> X-ClientProxiedBy: LO2P265CA0470.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::26) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58b3b855-c25a-4b57-1ce1-08da3da0aaa7 X-MS-TrafficTypeDiagnostic: CY4PR03MB3047:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sSflwjl2Popu1XqWArNR1jHKYJDI6/njUQtD4BKKz+E2Xy7SebngfuEgqqoHO+NRCqhzgDhb2jyskE0k5PCviGOz5sEfpCZhw+gEU/WTYl5uAaDwhMsm1r3c4Tx2Gs82WYXa70dCoT27p8zXi8PUN72QuP2r5cnu6BF0TgIKDqJ1d3KPoSw8FBgPiageXPvRFOCkLUlp3qmc6AXNgfObr+pNI6Caa06sXvdr9to6DypS814R2fnSqxRvEpQPGTEY0L9DVHajjjSFByf/vNyTMrBmdhenUyTjijaN8DZki/ViwU6by1Geykb9rv0s3KSZaMXkC0HUODWbG6R/ZEMOIRGvOHwJz9UQ1BLBih4fAkgwnTtXHynCUAIukQCmiN9IIh/E0+FTwCpUAOl3ah7h3T7Wl4ZwPRDyo/sI60TYmrpG+U2IKHWCLqqwBEhx6b7V+CwAS6wBPZNRMPwcdZPj8YISMY4RpHYClqv5a7wIpgqFEpi3af0gNl5E3r7tpn921Nt6qvSLMwNoUcxW1NapOEl9wf8WPr9BYZqDExFC5dYWUhLbQaKzZ8aHs63Fflh7Vkc+To0XJmbm7aG4it3+g7WrTc7hw2Im7FH6cR6wORCwZVQHupGbnFnU1beISArVdb5qjopjFLMYRztI3pz4Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(85182001)(508600001)(6486002)(33716001)(38100700002)(6636002)(316002)(186003)(83380400001)(110136005)(54906003)(6666004)(4326008)(9686003)(6506007)(26005)(2906002)(82960400001)(6512007)(5660300002)(66556008)(66946007)(66476007)(8936002)(53546011)(86362001)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cG5xMVFzSnREZlVVbzN5cWUvaXQrUkhNcXFUM1NaUWM3QXBuOE9EVndZSTIv?= =?utf-8?B?ZzVKQTljUFA1UGZYc09pNEwzUlpNVWxuQTZaVTZUcE9QNGNGL1JobjJTOWpU?= =?utf-8?B?bmNGb1MzMGJVcG5MUVZxcG84QjVGeXRBdWhqNFdxSHhpaHY1SC9oWmtKVVps?= =?utf-8?B?K2pEemxEQnI2ZWpCL1Y4LzNEQUNaYi9CNjAvY0JvRU03QlVSYmF6S21RSnBR?= =?utf-8?B?ZWJZems2Q0dic0QzaFdXL0J6RXhoRkNxUDA5anYwQjNyTlc3Y1diVkx6Ylho?= =?utf-8?B?MzlPN3NhbUN4N2xRRWFGYmdxM0N3TDlFcFl6V3R6NUNqVkNXOHVlYWNRU1Yv?= =?utf-8?B?VU4zNDRkbExyMGVJN2RzbmM1TjFiS1QyNnBnTUppelZmWmpmdGkxYlpueHFy?= =?utf-8?B?SEVSZk9UWnlNVnZZbitublZWMmZOa0tDa2tsNUdFbXFxaElPTzk5K0c2OWx6?= =?utf-8?B?S0tJL2dWZ1AwMzViZjVDRHUzNTNsUCsvLzRFWk1wSVJNUUc5djhRVWoxb0tB?= =?utf-8?B?ck1zK09STGJyL2hCZk1qbDBxS3QzUG15SVVBWG9GWXZROHV6V0orYnlOa2NF?= =?utf-8?B?eVlEajN2Ui9vQmcreWVSclpTNWdMRU9VOEV6WmFRQ0pjVzRFV25FOHBMSm5J?= =?utf-8?B?eWg4N2Z6ZndCTmJVc2cwZjQzek43eXRCMzBnZC9uYnZnSnBqeDgyU3NvN1BL?= =?utf-8?B?ckNud1lTL1d0U1hac2F2SmRiWDJaTituMEZ5RXEzZFUyek1BSWlXd1NLbGJo?= =?utf-8?B?VmtVTTVlNGZGOVg0R3A2Y0MzWkxuSnY0cGt3eVVCMkJRcHV1clBTKzRTUGFr?= =?utf-8?B?SVRwY3JMRVRSNndtaWFPazY4Q0F1US9BNkwxNXZ6bkxQK2ZpTjVRa0d6OVlU?= =?utf-8?B?ZEsrbld2Rmt3UGVNZ1M4YzRXUEVjWE1mK0Q0aGRyLzJWWTVZR3hTSlhtSW5V?= =?utf-8?B?SSt1OUFRbTNRYmFBNkxJNWJvVSt3RHZHazUwMUxXT3VReXp2dElVUGhCUW83?= =?utf-8?B?eGh0UWFXei91VnkxSXZkT0IyNnhQZmd0MUROem1URFFuTm5TeTlzTFgraVNx?= =?utf-8?B?cmc2bkhEcHZvcjBzM1lSZ05uRTZ2ZjNoUVdNZ0NZbGlzVnRQeGpuMnEvVEJv?= =?utf-8?B?NWIzSjkzdVBtbVNkdHdWbjRqckRkcWJXN3VQa1AvcHVPSnRJWVNCL05lUzdy?= =?utf-8?B?MHhEYzZoU2JSdVZIU1d5MGpxUlg5TEFHODk4V1hLTWluVXpVYkk3UXRrQi9u?= =?utf-8?B?NDc3aEhXdVFQeG5HSUh1eEtPVjdMM2J3RHREeHBJMHczNWZ1THBZMkdMQ0FT?= =?utf-8?B?S0p1Ynl5enBmVUdROFZJaHVnY0F1L2sxb2FQczRhOXZqaVJTZ09qbnVvdTBW?= =?utf-8?B?YXViUTVDUi8rNlIrTHpEMzRrdjdCTmhCenl0RUtVdytZeTRUeUJ0ZlR2MDlF?= =?utf-8?B?amxmS1J6K1E4TmdoYmVEYW1qcnVXYTExQW9QZUNaQW5Kb1Brd0d2Z0xxaEFB?= =?utf-8?B?OWU0WTNmdVowVk5nb2ZYUkNpeWdkM0ZMOVZzYUNKTUxKeWNzNFY0Y2VLN2pP?= =?utf-8?B?eE55QjBzN2RYMDRoSU01TVNEMEhlbnoxakh6QWhNNFQ1dkk2UjNoR012aEph?= =?utf-8?B?THRRYmdSckZVWnRsZG5KcDVjdjlWWlhlZ25RVk5lanR0OGJ5VkNRL2cxbVhQ?= =?utf-8?B?a1A0STBCSUV1VWhuK2d3bCtaWW9IUldoZzRzbHhNZXdDTGVDRjBwdWdTWS95?= =?utf-8?B?aDRDd1o5Nnp5VnhaVThlTWk3VHZJdzhPQlhKTVdJSERpcVd1WE5xWEFISkNw?= =?utf-8?B?d0lwM2d6YlZPVndwckRYYlFCNGdFaWxsQXdWc2Fha2hBQWdpYXI0THVJdDZL?= =?utf-8?B?TlBCUjg4TXM3a2xOYlRNbVlHQ29nNnh5ZnNIMUtya2Z6VUVkK2FKQTdIY3Vm?= =?utf-8?B?bHkzNENqR2lNQ2s4aU4wanRtTUp6VFR0bUhoZnJneGEwVE02UGZ2Z1BpTHNi?= =?utf-8?B?dmdrUDJLcW9wUVNMTW9PZ2grNy9qRGhKVzZVNk1ubWNGVkRpd1pUKzJKL20w?= =?utf-8?B?NDluenFyRGVUUHc3Rll6OFc3alFicUxLYVBITXQ3ckRpa2s4UHlNVGNWR2Mv?= =?utf-8?B?K3FKRW8ybGJhMit2U3BqbjdkZXp0cUhJRllEbCtNZkx5RENYd3UwK2JCZGtF?= =?utf-8?B?RzZqbTFidWYxYjdvZGE1MG9pZlhRK1I2K3ptTXpiK3BWNjVQSHNmY1ZIbm5L?= =?utf-8?B?MjhnMmtJcC9sbmZBbUcrS29jR3NKajZ4b2lId3BBK250V1lUOFpXRkltdlFJ?= =?utf-8?B?Wm1CamhrR1N2ditBTzZ0ZUlWMU9KN01HQVBuakptUnY5S1UxcFJHV3hRWHNu?= =?utf-8?Q?BLf20UAYJvs/3Ys0=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58b3b855-c25a-4b57-1ce1-08da3da0aaa7 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 16:15:49.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5KpHvPOSHEq0DwI78E00nW3J96BbADHeAxgKAQLjhrWnklGAUOEL5ZHVO2q+caLnFrY6wjFsPpNIu/mN0fYyKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3047 On Tue, May 24, 2022 at 05:14:12PM +0200, Jan Beulich wrote: > On 18.05.2022 15:27, Jane Malalane wrote: > > --- a/xen/arch/x86/include/asm/domain.h > > +++ b/xen/arch/x86/include/asm/domain.h > > @@ -14,8 +14,14 @@ > > > > #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo) > > > > +/* > > + * Set to true if either the global vector-type callback or per-vCPU > > + * LAPIC vectors are used. Assume all vCPUs will use > > + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does. > > + */ > > #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \ > > - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector) > > + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \ > > + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector)) > > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) > > I continue to think that with the vCPU0 dependency added to > is_hvm_pv_evtchn_domain(), is_hvm_pv_evtchn_vcpu() should either > be adjusted as well (to check the correct vCPU's field) or be > deleted (and the sole caller be replaced). I would be fine with replacing, the sole caller of is_hvm_pv_evtchn_vcpu(v) is never reached if the upcall vector is in use. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 16:17:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:17:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336664.561032 (Exim 4.92) (envelope-from ) id 1ntXDx-0008T7-Ek; Tue, 24 May 2022 16:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336664.561032; Tue, 24 May 2022 16:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXDx-0008T0-Bn; Tue, 24 May 2022 16:17:33 +0000 Received: by outflank-mailman (input) for mailman id 336664; Tue, 24 May 2022 16:17:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXDv-0008Sr-VX for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:17:32 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 03066982-db7d-11ec-837f-e5687231ffcc; Tue, 24 May 2022 18:17:31 +0200 (CEST) Received: by mail-lf1-x12c.google.com with SMTP id t25so31652130lfg.7 for ; Tue, 24 May 2022 09:17:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03066982-db7d-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k099nDBtGace6sjCooD+aLLT0GH+QzaCjURhwuSBBe8=; b=bNoUFohODtLlGn/8i384Z202NzQkh2BWsrS9Qxo4+Ja1Oihf0f+r/9tuXTXb4aPvp/ 0LZ6YfsP3y5XE3USGgXbPkjgyCnqe0s9DdLTpOmjwhhhWLDZTlBTI1yN6ExT71DLZRqr 8hb+1aPUF79wGA3bHTFjOSWl9FJgfOCfPTDhj4UbOAMzAOmI4WBU64K5aj7njd91bsnG YYQdDJ3rqp3hI0Tkqb/Nxg7dEd0PYyBQc/Xf7jtKnLigCEZjMpVGWk75gkQL7okcsg29 SXT0aDAt+VQbS4Uv9e2PFYPLk4O40nEih/Uf8irteIwDMZSQIKqVEjXh6j5OYYrRyJzL c9Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k099nDBtGace6sjCooD+aLLT0GH+QzaCjURhwuSBBe8=; b=nBDWiP0wDZ8F7aIqerYT+06RGUuPM6GBNs2c2CWXFgyLvInBBYAUWwzzfbyP8xEu5Z rU9fKZrTsK3g6KSc5O3i4Rg20rC1mPvRKqi6ZKlDT+vUILn2+FXHylf5wrOyIjLMeH/T 56DCm3x0FvxZuN/UVAiaK973/I8FL8RUOPgEbB+J0WgYZRe+Jn3OP3IkqeRKZF0KCESQ gSqPRvYwfq50CZm3+QqtCePxDWb+phSS81kPQxb3hcy5twcAf7ysQmMYp0clhYrJgvnz c40qY9Uv5cfq0QdKxo76+UWbwQM4HC7YtEiX5j2wkNHSxEdE8m56db2FE+35/9fVheeI AL0Q== X-Gm-Message-State: AOAM531LFr71M+HnIpbj36HwAmORKc4kDbtTAob0r+wPCABAPL1AoqAJ JXG5g6SaRos0YIHwJPA1faqEIsq7kv154sQkHippZGZddU0= X-Google-Smtp-Source: ABdhPJzpkf/nHXWx/CF680RPX4UDXIIKw9cgIAmr8mhWTkOFlxuv4mRWaKBg8J38LqYJAEKPYPodaVfE7aPwGBEiqcA= X-Received: by 2002:a05:6512:a88:b0:473:e080:40e8 with SMTP id m8-20020a0565120a8800b00473e08040e8mr20263087lfu.359.1653409050495; Tue, 24 May 2022 09:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20220523154024.1947-1-dpsmith@apertussolutions.com> In-Reply-To: <20220523154024.1947-1-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Tue, 24 May 2022 12:17:18 -0400 Message-ID: Subject: Re: [PATCH] xsm: refactor and optimize policy loading To: "Daniel P. Smith" Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Daniel De Graaf Content-Type: text/plain; charset="UTF-8" On Mon, May 23, 2022 at 11:40 AM Daniel P. Smith wrote: > > It is possible to select a few different build configurations that results in > the unnecessary walking of the boot module list looking for a policy module. > This specifically occurs when the flask policy is enabled but either the dummy > or the SILO policy is selected as the enforcing policy. This is not ideal for > configurations like hyperlaunch and dom0less when there could be a number of > modules to be walked or unnecessary device tree lookups > > This patch does two things, it moves all policy initialization logic under the > xsm_XXXX_policy_init() functions and introduces the init_policy flag. The > init_policy flag will be set based on which enforcing policy is selected and > gates whether the boot modules should be checked for a policy file. I can see the use of init_policy to skip the search. (I'm not the biggest fan of the name, need_policy/uses_policy/has_policy?, but that's not a big deal). That part seems fine. I don't care for the movement of `policy_buffer = xsm_flask_init_policy;` since it replaces the single location with two locations. I prefer leaving the built-in policy fallback in xsm_core_init since it is multiboot/devicetree agnostic. i.e. the boot-method specific code passes a policy if it finds one, and xsm_core_init can fallback to the built-in policy if none is supplied. Since a built-in policy is flask specific, it could potentially be pushed down in flask_init. Is there a need for the xsm_flask_init_policy movement I am missing? Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue May 24 16:32:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336672.561043 (Exim 4.92) (envelope-from ) id 1ntXS6-0002SC-OX; Tue, 24 May 2022 16:32:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336672.561043; Tue, 24 May 2022 16:32:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXS6-0002S5-Kx; Tue, 24 May 2022 16:32:10 +0000 Received: by outflank-mailman (input) for mailman id 336672; Tue, 24 May 2022 16:32:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXS5-0002Rz-JS for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:32:09 +0000 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [2607:f8b0:4864:20::82d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0db5171a-db7f-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 18:32:08 +0200 (CEST) Received: by mail-qt1-x82d.google.com with SMTP id m13so9118911qtx.0 for ; Tue, 24 May 2022 09:32:08 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:232b:a469:f1f6:e2d7]) by smtp.gmail.com with ESMTPSA id g15-20020ae9e10f000000b0069fc13ce1e9sm6033213qkm.26.2022.05.24.09.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 09:32:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0db5171a-db7f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1IiIg1GUmt3YDROQNKNSyomdlx2ySFqe/mHdIetvhtE=; b=oC0VFc9uHh9mymKMaP5faNbOHnwnLvvX832lHHpiJwSHb+eCZio1WCdkEi7oCQG/xV ZQxKbqSq4QPagfc4ex8FPi7Hs2mw2t3G9R4BUl2tBLXvlmCoV5AWdoVlSrgzm/ee5QBc +l3bGbBIXlc1mI6Q+ARr4jrANUy1SqoaZvA6zWRENK4DLzedP2o0u8kCXSviuWI3EusT rmlkqPjlWD1sg1adWoiltVdksRvYGuKuTd1q7OyCrNrSg4oIBZnaeEgXkhqD0uUApFd+ wXzZNWpETvNAM4w/biWqO9PegwOPXIuOEcT1HOTqc4xxk9n1oM/EHSJuOJLhxat7PjU8 Q5UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1IiIg1GUmt3YDROQNKNSyomdlx2ySFqe/mHdIetvhtE=; b=wqXG+1cCUwtVS3eqQG00LglsmaHzKQSiRwAxecDqwPkXAcM5Rd5HzvGVP5bIkNH+UG bFQT7woaAHqzgWELe8esXCrq4OZmvq8GIGHU9S5qb/gHKEimbtlZuD1f5Qoj5baXuqV4 8qL2k+K9aEoXrXF9gMgTgUHERNepkRaHBt2wlPH4BW/aOxEA+pmTvJMBhep8oLbfIFjo d8bx002oFEfJk9VKjeIpLpJ3oDnJowLVvF0GwWJhe0/+WYnM9j3+OsaYSEDpCHwZL2nx SnK02EKTxZ33e9YmLRCw+Vc5C94DmMqJCHz3IwHJ6XwULoCK789SkcZ9yBssF/kt+Twu mgcQ== X-Gm-Message-State: AOAM533+NXr75tFb1udakWb7h2XvGe1HaSobxobBVVgZ8IzYrMPwyFcK /Te8VtSqYXfercVTHbjFapJm9I+n6oo= X-Google-Smtp-Source: ABdhPJzKVoEJP7TcrJvimtfz434njRxStBzaFIY4PU9EcyzGjESpIOvVo0EiDu+yvcvwKKx+1CvtHQ== X-Received: by 2002:a05:622a:650:b0:2f3:facf:d11a with SMTP id a16-20020a05622a065000b002f3facfd11amr21034914qtb.109.1653409927034; Tue, 24 May 2022 09:32:07 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH] libxl: Don't leak self pipes Date: Tue, 24 May 2022 12:31:52 -0400 Message-Id: <20220524163152.19948-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit libxl is leaking self pipes to child processes. These can be seen when running with env var _LIBXL_DEBUG_EXEC_FDS=1: libxl: debug: libxl_aoutils.c:593:libxl__async_exec_start: forking to execute: /etc/xen/scripts/vif-bridge online [Detaching after fork from child process 5099] libxl: execing /etc/xen/scripts/vif-bridge: fd 4 is open to pipe:[46805] with flags 0 libxl: execing /etc/xen/scripts/vif-bridge: fd 13 is open to pipe:[46807] with flags 0 libxl: execing /etc/xen/scripts/vif-bridge: fd 14 is open to pipe:[46807] with flags 0 libxl: execing /etc/xen/scripts/vif-bridge: fd 19 is open to pipe:[48570] with flags 0 libxl: execing /etc/xen/scripts/vif-bridge: fd 20 is open to pipe:[48570] with flags 0 (fd 3 is also open, but the check only starts at 4 for some reason.) For xl, this is the poller created by libxl_ctx_alloc, the poller created by do_domain_create -> libxl__ao_create, and the self pipe for libxl__sigchld_needed. Set CLOEXEC on the FDs so they are not leaked into children. Signed-off-by: Jason Andryuk --- Maybe the setting wants to move into libxl__pipe_nonblock()? Poller & sigchld are the only callers of that function. --- tools/libs/light/libxl_event.c | 3 +++ tools/libs/light/libxl_fork.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/tools/libs/light/libxl_event.c b/tools/libs/light/libxl_event.c index c8bcd13960..8d24613921 100644 --- a/tools/libs/light/libxl_event.c +++ b/tools/libs/light/libxl_event.c @@ -1800,6 +1800,9 @@ int libxl__poller_init(libxl__gc *gc, libxl__poller *p) rc = libxl__pipe_nonblock(CTX, p->wakeup_pipe); if (rc) goto out; + libxl_fd_set_cloexec(CTX, p->wakeup_pipe[0], 1); + libxl_fd_set_cloexec(CTX, p->wakeup_pipe[1], 1); + return 0; out: diff --git a/tools/libs/light/libxl_fork.c b/tools/libs/light/libxl_fork.c index 676a14bb28..b13659d231 100644 --- a/tools/libs/light/libxl_fork.c +++ b/tools/libs/light/libxl_fork.c @@ -387,6 +387,8 @@ int libxl__sigchld_needed(libxl__gc *gc) /* non-reentrant, idempotent */ if (CTX->sigchld_selfpipe[0] < 0) { rc = libxl__pipe_nonblock(CTX, CTX->sigchld_selfpipe); if (rc) goto out; + libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[0], 1); + libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[1], 1); } if (!libxl__ev_fd_isregistered(&CTX->sigchld_selfpipe_efd)) { rc = libxl__ev_fd_register(gc, &CTX->sigchld_selfpipe_efd, -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Tue May 24 16:46:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336680.561054 (Exim 4.92) (envelope-from ) id 1ntXfg-0004yU-01; Tue, 24 May 2022 16:46:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336680.561054; Tue, 24 May 2022 16:46:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXff-0004yN-Sa; Tue, 24 May 2022 16:46:11 +0000 Received: by outflank-mailman (input) for mailman id 336680; Tue, 24 May 2022 16:46:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXfd-0004yH-Sz for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:46:10 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcea5f7a-db80-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 18:46:01 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 0A3DC3200063; Tue, 24 May 2022 12:45:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 24 May 2022 12:45:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 May 2022 12:45:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcea5f7a-db80-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1653410756; x=1653497156; bh=Z8fSYjEyoO yGRxhE+YCeBF0cIAtqOwl1QptR41zfw5M=; b=j2AVTIUb880/fsAsaQu2+eNfa9 z8SBnLwhrZfuMvSLObCZKQAwy/cRatE2JacltIMeeRrSepSiC9+t0T4T0Fp7czWX 5/gYxi9o+Od3AlUnFVJhwR5XrtpJVfDk8MjNqECgkmtBH0R7TWpvhfLhkpEzYltk wCRkSLgy8nLWSxhsSl4B3GccBywZn5U5qJv/pe5SFIr/x7dt67ZUFNV4/J2ZnnA5 Ykh+vX66SVvCzz8h0jkrDrkDlhlihaKp+tslZx2rVX3nVzFm82QQ8+g8EnlMZEDK 7BsBKl6by6qOca/xf0ArXYfZtfm8iwyLg++rTnI6sVTXLEfCzSlQg6pwP65g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653410756; x= 1653497156; bh=Z8fSYjEyoOyGRxhE+YCeBF0cIAtqOwl1QptR41zfw5M=; b=V LXNwXJvPqjGmGshDviCRtm8ALWpp1riaUMePmb+2tXQvriq8Ia0ab9QaGOL1xq6+ CTm7/1m9Mnj9gx4cvGmarm/Ane8X7vJ87006LfX240CxMUOqm/IG3UVYBYg5rRpv 6LRaHb7W8e6fqhDV2itPZqm7twJNdfMesh63rDaIFB/WRHQyZ7QfMgP51UcWvWLD xotywFdOV2HLpu58Ek9iCJXGQMRfcWhgrBnFnYA7ZB/ec4ugnkDGbu4htvbp533o R5xcpcrNS78pfc7c3dGJ0m+iKxgT22CHiZeaXvydKz3SD4lzgvRe4lWEedyzvtkL GLNkwQMKnw0TjJdycv++Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeefgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugesghdtreertddtvdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepteekvefggeeivdffleehudejveevfeeg vdeghfeigfdvgffgudeuueefveeuveefnecuffhomhgrihhnpehgihhthhhusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 24 May 2022 12:45:51 -0400 From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iCJBjnzIorPsAmSw" Content-Disposition: inline --iCJBjnzIorPsAmSw Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 24 May 2022 12:45:51 -0400 From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(). Replace this with WARN_ON()s where errors are detected. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are stil= l in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour --- drivers/xen/gntdev-common.h | 4 ++ drivers/xen/gntdev.c | 82 ++++++++++++++++++------------------- 2 files changed, 45 insertions(+), 41 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 20d7d059dadb..a6e2805ea2ce 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -16,6 +16,7 @@ #include #include #include +#include =20 struct gntdev_dmabuf_priv; =20 @@ -73,6 +74,9 @@ struct gntdev_grant_map { /* Needed to avoid allocation in gnttab_dma_free_pages(). */ xen_pfn_t *frames; #endif + + /* Needed to avoid allocation in __unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; =20 struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int co= unt, diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 59ffea800079..670d800e4a89 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -62,8 +62,8 @@ MODULE_PARM_DESC(limit, =20 static int use_ptemod; =20 -static int unmap_grant_pages(struct gntdev_grant_map *map, - int offset, int pages); +static void unmap_grant_pages(struct gntdev_grant_map *map, + int offset, int pages); =20 static struct miscdevice gntdev_miscdev; =20 @@ -349,61 +349,65 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *m= ap) return err; } =20 -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err =3D 0; - struct gntab_unmap_queue_data unmap_data; - - if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { - int pgno =3D (map->notify.addr >> PAGE_SHIFT); - if (pgno >=3D offset && pgno < offset + pages) { - /* No need for kmap, pages are in lowmem */ - uint8_t *tmp =3D pfn_to_kaddr(page_to_pfn(map->pages[pgno])); - tmp[map->notify.addr & (PAGE_SIZE-1)] =3D 0; - map->notify.flags &=3D ~UNMAP_NOTIFY_CLEAR_BYTE; - } - } - - unmap_data.unmap_ops =3D map->unmap_ops + offset; - unmap_data.kunmap_ops =3D use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages =3D map->pages + offset; - unmap_data.count =3D pages; - - err =3D gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; + int i; + struct gntdev_grant_map *map =3D data->data; + int offset =3D data->unmap_ops - map->unmap_ops; =20 - for (i =3D 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err =3D -EINVAL; + for (i =3D 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); pr_debug("unmap handle=3D%d st=3D%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE; if (use_ptemod) { - if (map->kunmap_ops[offset+i].status) - err =3D -EINVAL; + WARN_ON(map->kunmap_ops[offset+i].status); pr_debug("kunmap handle=3D%u st=3D%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); map->kunmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE; } } - return err; } =20 -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) +{ + if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { + int pgno =3D (map->notify.addr >> PAGE_SHIFT); + + if (pgno >=3D offset && pgno < offset + pages) { + /* No need for kmap, pages are in lowmem */ + uint8_t *tmp =3D pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + + tmp[map->notify.addr & (PAGE_SIZE-1)] =3D 0; + map->notify.flags &=3D ~UNMAP_NOTIFY_CLEAR_BYTE; + } + } + + map->unmap_data.unmap_ops =3D map->unmap_ops + offset; + map->unmap_data.kunmap_ops =3D use_ptemod ? map->kunmap_ops + offset : NU= LL; + map->unmap_data.pages =3D map->pages + offset; + map->unmap_data.count =3D pages; + map->unmap_data.done =3D __unmap_grant_pages_done; + map->unmap_data.data =3D map; + + gnttab_unmap_refs_async(&map->unmap_data); +} + +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) { - int range, err =3D 0; + int range; =20 pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); =20 /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { + while (pages) { while (pages && map->unmap_ops[offset].handle =3D=3D INVALID_GRANT_HANDLE) { offset++; @@ -416,12 +420,10 @@ static int unmap_grant_pages(struct gntdev_grant_map = *map, int offset, break; range++; } - err =3D __unmap_grant_pages(map, offset, range); + __unmap_grant_pages(map, offset, range); offset +=3D range; pages -=3D range; } - - return err; } =20 /* ------------------------------------------------------------------ */ @@ -473,7 +475,6 @@ static bool gntdev_invalidate(struct mmu_interval_notif= ier *mn, struct gntdev_grant_map *map =3D container_of(mn, struct gntdev_grant_map, notifier); unsigned long mstart, mend; - int err; =20 if (!mmu_notifier_range_blockable(range)) return false; @@ -494,10 +495,9 @@ static bool gntdev_invalidate(struct mmu_interval_noti= fier *mn, map->index, map->count, map->vma->vm_start, map->vma->vm_end, range->start, range->end, mstart, mend); - err =3D unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); =20 return true; } --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --iCJBjnzIorPsAmSw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKNC8MACgkQsoi1X/+c IsHAJRAAjtDopK0KF9LmKELwrNytKtSheNA1qaQAT4GYCdiQfBh/BUKH+SLULH39 picN4dJb62xrkRQNAuwc3uzObotjRFAOHsvUMKMfrj761fjmm9LfFmIRyVOo2Kny 9VLUB2kPgmphv9NtSHms7XwzINYjipyon0wUIvAmP2CbHyzcTniibIafHPY+jlL4 qB5JI6yjg/B3XXbW5LeVCW7yN9hF1FJpPt1ndhNSytXm/RkUivoRKQ16B3FqNRJx w1N6PrLfjiSIOIQaS+0JQHak7jWQ89Dit1GPVzOzkvk1DpfiaNK7gttMcADyyDPD TMoeKq/ozU/IGOyK1PAij/k+6iZBwo4hQdpcYCr8hmj4yJxCVzKsQV+yL/HmehtK edzbfH7JwF8Z1ap3xugTEr89biFnPy+/VsCha10L/tm/3xh0RtQt+7FId6jBVdi6 G9dKOd7gu4f4BbwFDYEGJuVDYdNTqV9LV7/tkQeit7j2/y4MS9fClQKrFSvN8QoV iMpGc3RvwZfz9EZE8ABPFKA1fhIRCPk6ebzagLynOQ4Pn65LjjTOZqaFXXUxFEIp FkrwFARyo7pv14q5CJfDCwyz+hlGHqEHYyc3HxSm2HU21lbNxn9VBzjNZFNcFuvs Ep4ZBSkl2obWuIG5TcXToIHxuqAo9ufsl6DZPlYFj5GA2ob5cmM= =FXH8 -----END PGP SIGNATURE----- --iCJBjnzIorPsAmSw-- From xen-devel-bounces@lists.xenproject.org Tue May 24 16:47:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 16:47:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336689.561065 (Exim 4.92) (envelope-from ) id 1ntXgZ-0005Tr-Au; Tue, 24 May 2022 16:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336689.561065; Tue, 24 May 2022 16:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXgZ-0005Tk-7B; Tue, 24 May 2022 16:47:07 +0000 Received: by outflank-mailman (input) for mailman id 336689; Tue, 24 May 2022 16:47:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntXgX-0004yH-UE for xen-devel@lists.xenproject.org; Tue, 24 May 2022 16:47:06 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2349336e-db81-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 18:47:04 +0200 (CEST) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 May 2022 12:46:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2980.namprd03.prod.outlook.com (2603:10b6:404:10f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 16:46:56 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 16:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2349336e-db81-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653410824; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GCMfGFX18MxrK68W+4tBrU5JqQ72zQrhqRF/3YxJ0Q4=; b=FuJSkybD0N9OnnwyOeM/VtAg45r/loFTZL5inWh9gwDxK3878l9mRwNe mmnNANFC10q8BrBT3s493YURq49nxln4a8DKKCF6a3kfC6QHNyu3O4wy5 b57PNBiG0ew3+HBPR0D75IdNL4IIIzipNmulqVDwDJuX1hwtFbaU8h1S6 s=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 71441734 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:jqgqNq1qzhWdBTpVnvbD5adwkn2cJEfYwER7XKvMYLTBsI5bpzcCy WofXDqEP/vfYzbzfIh0btvn8E0Au5XSmNI1HgFppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMy3YDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1ViraeTBo0P5bnv9svfSN0I2JcEq5JreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfyStLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutriamL2EB9wnJzUYxy1KM6g11+eGqCuv+JuyMGZx6nxi8i kuTqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqEKX7nweDlsRT1TTiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4FuQ77ESI1fDS6gPAXmwcFGcZOZohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:MCLJP64lb6GVeCs7kgPXwVSBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcV2/hpAV7GZmXbUQSTTL2KgbGSoAEIXheOjdK1tp 0QD5SWaueAamSS5PySiGfYLz9j+qjgzEnBv5ai854Hd3APV0gP1XYaNu7NeXcGPjWuSKBJYq a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLbhJavmnhnQYseuv4FElnJ 3lpAohBd167zfrcmS8sXLWqnzd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ g7k16xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXavoJBiKprzPLd MeTf01vJ1tABOnhjHizyNSKeWXLzsO9kzseDlAhiSXuwIm7kyRgXFohvD3pU1wiq7Ve6M0mN gsDZ4Y5Y2mbvVmGZ6VV91xNvdeNAT2MGLxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g= X-IronPort-AV: E=Sophos;i="5.91,248,1647316800"; d="scan'208";a="71441734" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cY1kC9EuCMMeHiVuuAmCzphQilkkwtm/yKsJyx7NIT2Q9IfBnpIc4AJegOwW4TyI/GHcTZkI/I0hOjZ3QaM8zAaiiKGwaAr1Wtv2dh0JK9ocA+jBy1pmjxYKYPPviB7PjG9B6AQN2IgL+HiIPIqAQEDQkl3r0AYNuGk6weHAaVwJz6Nn15475gF+u2sJbvjfkRmA3Fw5qS9nenPvc60qmPKaGsPKewLZkwM02kV5Yypp/Y7vNDiLfRU6Rc2hoPHi1EWiGVrhwuTqRN///d8VgABnRD3PJ9xe4CVI+XK020VyjtIcYcU8IrEjDgIEH4tJ5sNpk4u4+7qDBMIBSfu00Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EdmlYp/o88PZafQydtFsxqPmm47chu1blBI1ttF7+q8=; b=h6kMtHpEdJGmXbConJurJrZkbnmJ/TUYLMm5Qm8wWo9S3sXcq7mIeKap1sEWPont/+mIS5G+VZMVPB7TBoGelSoNg/3BuHmU81ukYmr68zIg0qaC6aj8VmT/T3wps/hF8qACNCQFWBrVMkaMDVZtu7bypSzVOyxESldLBlPPNwUKYijXtvFCoKdRy6nFFOatbeAix4qRLIo2CvYSc6K/WqKb+ewY+9nDRDIlpIVr/K46jpqrxZIzjpaOiPNstZxDtcah3rTDG1kwQPSb15W/D8UI2ECTFMmIlFHDzC7D6NvVRO8e9RkrNv354AFAUeGr6uaFLN613z0KmnUuOJ7nxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EdmlYp/o88PZafQydtFsxqPmm47chu1blBI1ttF7+q8=; b=FkC5J8+LWtUS266GHYR8m7PdXg457QLInnvHsGDbHarSqdG5D1EfMm5Ctf10cly/l6FwbpHS9PV9uOs972Wku/eJO6dpTlDv3IkxoO19z/8fCn7WbxjCVUdEEG+c6EENnVZnlFT/aCyBk4QYfStSBGyRuQRv1ts8/GjacjYdUX0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 24 May 2022 18:46:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> X-ClientProxiedBy: LO4P123CA0293.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23869fdf-1835-4ec4-1db9-08da3da5034d X-MS-TrafficTypeDiagnostic: BN6PR03MB2980:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bajMHMf1Gl0cTMVyvGIdTsGTJDYP4M6fbOmwADMGXucWGCJe2ugOszcvMq9jCatUMpnoqasPcD+b38kOdbTVA3PX9kwqHvsuFpeQrjGoLKVE8X1yGsQyXs5ykKDrV3+2YTOaH+Qh30Gxcc+tz0gDyYn9TubKojMlMyPgdP5KCnSBrEVLYp2qCY00Q+Q6L+psMu8Qzxv/AHSbXOSjUieY6z+zDeSzfLbmn6fXp4Y3jHfsuUJTnr5UFH1nLWAQ/tEeiH8wpVT7OrpsDARSQdlQhKG9UX7PduQjSq4bL35KnQ/4tUgxICIn7xViVTAmDiJRHuesHlnmxGShP7KM81brI+IUlLKwJX99mzncbIpD2Vwii/Lm9EEY7ue7UAYKRb0UQfg+iTBa9XulBw28NeOxKKvJdMfXcBd0Auf8GNvLWDMN12QX1bTyn2tnkXm1scX37T2RcTv2gADWEC+2PGhEFjtupC6+PzE8iR2DV9l5B4AEZptF2K+ICTznKXNPG5HBvt2MJgTpOouUvAc8puB5o2EpT/V2Q6oo2ssxfwngNo0Vj9RSOgfdURFW1wbbYMYrikVmZe8jK+GYcr/EB7KvrQ8tUpDn4KoPUMtXXw+cV/OF5hySRcYh8zlb2xP08sxBOKLzZ7SLlS7PXaUgcb0jSw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(66946007)(316002)(4326008)(6486002)(9686003)(8936002)(83380400001)(8676002)(66556008)(66476007)(53546011)(38100700002)(54906003)(6666004)(26005)(6506007)(6512007)(6916009)(82960400001)(86362001)(508600001)(85182001)(186003)(33716001)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1pJWi9aNlF2eUFXcGZEL2dUajJCbWx2d0VQK0ZLTGxoVHlCU2hMdk5LRTMr?= =?utf-8?B?QlBWczAzLzE3WUZyVVVoSWNBa3hXc09YKzBBQ3ZKSWJ0ZGk1N1hiVUdESjRl?= =?utf-8?B?ZkwxbTlyNEJKck9OdWdVOW80SHVrb3lIaWRqVHg5QnZIM3FEK09VYjErM2w3?= =?utf-8?B?NDhEWE9maml6TnByRU0raEhoQU51NS93TnBrcUJuMWpQUnRUVFRWelpkZFB4?= =?utf-8?B?N3FqcmlJNnJSM2R3QTRFWk4wNmdsUnBmQWl0UStYOGsxdUY0eEs3ZlhWaVd2?= =?utf-8?B?N3pTcjZwSTZhaXR5UER1OThZbXNabWhHMk9IcUpYYm1MVFdrbjNzNFlrd0J5?= =?utf-8?B?dmpROUFGV0pCUFo3MUtsbUJ2RzVuSnlIYjltU1hPck12Mkc0TmdZWFgybTZU?= =?utf-8?B?VE5Ecm85QXZncFpYbC9obnlTa1QxNndKc09tWWl5eG1Pa0F0YXF6OXVTUzNZ?= =?utf-8?B?VHA0VmFtRFQ0bFJsR3I1TldyNW4vWW9VOEFmZ1ltNUYxdHhXQ0F1TTQ4WXRF?= =?utf-8?B?cVVCc2FYV1o0NHJsR01ZbGNUOVVaZ1VYN1hKMjY0YzRrYWVNVVk3ZzdRZUFR?= =?utf-8?B?Wm1nYm92TEZPVE9zT0tUTGg2Z201TjVzUjlROEdlcVNGNWIvSWtEdFhYazNN?= =?utf-8?B?QS9icVZVVUVwR1hHeUJId01hZkkramVXYlJHbWgxN0NDR05yQzkxK3IySVE4?= =?utf-8?B?eFBvU3hBUmg1TVg2N0JKaVVCalAzaGFQL0h6VjkzSU1KdnlxcGRoZjk3cUZr?= =?utf-8?B?STBkVUsrM1MxUldlWVpQeUVaZ2RDV0dISVpJZERvZnU2aHhNalFsOTNzZG90?= =?utf-8?B?SmRRaXdoUXJ6cUhacDl3bW44WTF5SGpkVVd2dzkyWEdsYjNrZ0lkT1FUMXpD?= =?utf-8?B?OE84VE4yWVlzektKV05ldWVGd0VoMlBnVE9KMGJROEJ3U2ZUY1pla0oxSWNE?= =?utf-8?B?SWxKZ1gyeGhOMmhZVlh0WTlYWjQyR3VKWWVzNkFoSXZWYmxWZWtVTTJGU1dJ?= =?utf-8?B?OVhjWE9ZR1dNY0duZ3liazJSSW9FL2J3ZzZpMFN3emp6UFFJdFU5dzFpeHZp?= =?utf-8?B?SDJWVzl3UGlFK3dMREpFWUI1NmtFamtRMmZLS2ZoYTdVbVVkYWZEa3ZmZXVQ?= =?utf-8?B?M1JiVGtIbDZhNWNYRVVBVy83aEtjQWlLRE5pTEtXeWVHaGVCZDVxRmg5dWpR?= =?utf-8?B?TDl1cDlBdTZDUzkwWmorVzlJenlTSVR1NmVSaG5DZlMwNXpKSGJZWEt2KzBj?= =?utf-8?B?bzRJelpiWUJpbTdYUlpqd0M5WTBTYXFtakx5OEhCMElXb3BkNzNnYXN0OGRw?= =?utf-8?B?THJIMU5xbGJubUlrVC8xNWZ0Z29mMWpJbjlWOHkyTk4rY09DajV4U0pzMHpZ?= =?utf-8?B?bFc0U2drS0x1MTdZU0JVeW5BeFZ0c0xNT01WNE9wNVVQcldKallwYmo5QndH?= =?utf-8?B?TWd6Q1ZDYkpvNVdRaUhvT3ltaHpKaGZGWjNJMGRhUno1d016U1NVMFV4eTFm?= =?utf-8?B?d01VYzJ6UDh6MTd3NWRNS002L0tTNWhvSDFQNzlrUGcrcVpOMnpGVjBkUWMy?= =?utf-8?B?bHNZWHEvQ25xWTVLcmZYa1hidWtidUI3a3lpRmJ4T0FlMzZXNmpUbE96QUhX?= =?utf-8?B?Sjg5TWRlZlNyeFdxTXpteTl2TCsrU3VBSXBWVmRSMUQ0cVpXMEFQM0IyN1pL?= =?utf-8?B?K2hXQm1SbU9OWnJnVGM3Qm44Qit5K3N6QUdaWExvTGtWMzhpb2EyMkx5ZHdt?= =?utf-8?B?ckxSOS9rVmZ2end2ek5mL0hybGo2a2JFcmxleUVkUXYydDEzaUdnNmE4SXBW?= =?utf-8?B?VkpRd1Y1R3JUY2lqMnl1UXMwVEk2NysxdEtySTFYdkt3RHRSajNZRU9UbHJR?= =?utf-8?B?d3dGSXBpTGQzYm5yVFhxZ1VveXRKdG1CeFovV3dqb2pqd2h4Tit3L1lSRjhP?= =?utf-8?B?TWRRRDhMRC9zS2lzL2M4aytGUm0xNWltTjBCMVRTMHFVU0F4cVA1Mnl1VUdv?= =?utf-8?B?UkV3STNyNzZHdlVoUEdhMDJSS1VqbTVjYy83NjMyRit0Y3JOSTBraHVJTGZX?= =?utf-8?B?eVFaYUNGMUZJTUVqOE01NEhmVGY0NktsdDQrVjhrcTQwRDZwWFRhYUYwWnFo?= =?utf-8?B?THNnVFFLN2UwaVplVHJkYU5Lb2MwVDdTcGVTYlE2eTZuaTBqcFJQbFo5a29r?= =?utf-8?B?TzMzYjlVUHdKZm9IeXZ5S1BGQjFoK3QxbUVOLzR0Q2U2TUNDYjliZURXREg0?= =?utf-8?B?bVN5NFNHeWdJa2F6dUpHMzgrLzEyVS8vUmU3NHpqRklqeFZmd1VUL3RkcVNt?= =?utf-8?B?TGdJZUV4aDNzQUVhdUxXSWt0bzVhemRyT09mam5nNm9sYTU3cXQrTmxHM0xa?= =?utf-8?Q?w5Uh5M0tdWmDKNuo=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23869fdf-1835-4ec4-1db9-08da3da5034d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 16:46:56.1879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OneHY/Fe5qqfFJAmLHOzcB/5x/5EuGYUezcSk0HAfukkPhxO+cqYeLL9Oen8vSJzhtRZHUODU5LY3qA6NPD0bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2980 On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: > On 24.05.2022 12:50, Roger Pau Monne wrote: > > Booting with Shadow Stacks leads to the following assert on a debug > > hypervisor: > > > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > > ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- > > CPU: 0 > > RIP: e008:[] flush_area_mask+0x40/0x13e > > [...] > > Xen call trace: > > [] R flush_area_mask+0x40/0x13e > > [] F modify_xen_mappings+0xc5/0x958 > > [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 > > [] F alternative_branches+0xf/0x12 > > [] F __start_xen+0x1ef4/0x2776 > > [] F __high_start+0x94/0xa0 > > > > > > This is due to SYS_STATE_smp_boot being set before calling > > alternative_branches(), and the flush in modify_xen_mappings() then > > using flush_area_all() with interrupts disabled. Note that > > alternative_branches() is called before APs are started, so the flush > > must be a local one (and indeed the cpumask passed to > > flush_area_mask() just contains one CPU). > > > > Take the opportunity to simplify a bit the logic and intorduce > > flush_area_all() as an alias for flush_area_mask(&cpu_online_map...), > > This is now stale - you don't introduce flush_area_all() here. > Sadly nothing is said to justify the addition of a cast there, > which - as said before - I think is a little risky (as many > casts are), and hence would imo better be avoided. So prior to this change there are no direct callers to flush_area_all(), and hence all callers use flush_area() which has the cast. Now that I remove flush_area() and modify callers to use flush_area_all() directly it seems natural to also move the cast there. While I agree that having casts is not desirable, I wouldn't consider this change as adding them. Merely moving them but the result is that the callers get the cast like they used to do. > > > --- a/xen/arch/x86/smp.c > > +++ b/xen/arch/x86/smp.c > > @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > > { > > unsigned int cpu = smp_processor_id(); > > > > - ASSERT(local_irq_is_enabled()); > > + /* Local flushes can be performed with interrupts disabled. */ > > + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))); > > + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ > > + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); > > What about FLUSH_FORCE_IPI? This won't work either with IRQs off, > I'm afraid. Or wait - that flag's name doesn't really look to > force the use of an IPI, it's still constrained to remote > requests. I think this wants mentioning in one of the comments, > not the least to also have grep match there then (right now grep > output gives the impression as if the flag wasn't consumed > anywhere). Would you be fine with adding: Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as it's main purpose is to prevent the usage of the hypervisor assisted flush if available, not to force the sending of an IPI even for cases where it won't be sent. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 24 17:44:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 17:44:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336698.561076 (Exim 4.92) (envelope-from ) id 1ntYZz-0003k7-QR; Tue, 24 May 2022 17:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336698.561076; Tue, 24 May 2022 17:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYZz-0003k0-NF; Tue, 24 May 2022 17:44:23 +0000 Received: by outflank-mailman (input) for mailman id 336698; Tue, 24 May 2022 17:44:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYZy-0003ju-M5 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 17:44:22 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22eecb57-db89-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 19:44:20 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653414252524943.2521548260714; Tue, 24 May 2022 10:44:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22eecb57-db89-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653414256; cv=none; d=zohomail.com; s=zohoarc; b=KD/HqGqVuGRB1Z+b176S8SwEsv+fXrLemoXHGCNvOgDb9uwqk/IenNgWsbnyzF7tmHjwxa78W2ivRY4dlQcOYkYTlfr67/spdYWPdwqJ90ZFJlVdY/z9iPFBwH3DglkoJQDRkTMmDNVPJdLOkIdLTiX22FIUa6Wb6myXCoUi8Dw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653414256; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=bKjqYZonshurFqMRr3m4RylHY46Cv2/mFfaws+RMeUo=; b=nKrlLNDKN3oUdMssfOAy23BWQYvicReuFcWEs5DBH1kAC+gWsLUW/hsPNiHlFCkk0EGYxL4X2kjYgWBGy6oiFB4h5N8vWYiw9lBU2y+QXbfciqT/BImuUvGWXn8kh1NoeSves6dJiKMke7LPj/n8eybEbmbincJ2Aq73zgAyqCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653414256; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=bKjqYZonshurFqMRr3m4RylHY46Cv2/mFfaws+RMeUo=; b=esOuY+97MJiIdnmTOJxJOWuFBj/SHTr5nsmZTgmGbW8NO+s8iRRyNlreuL43TCeV j7oPJo9EqR2LggcjQLIouDCMTUdSc5jm9NlKglexpcjo3XiHC2yDcwF/Yf3K3P8IsLS yIHDrG75wEsPKm1O7DXIC3D4RFMPusI4uI4yg1qE= Message-ID: Date: Tue, 24 May 2022 13:42:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220523154024.1947-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xsm: refactor and optimize policy loading In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/24/22 11:50, Jan Beulich wrote: > On 23.05.2022 17:40, Daniel P. Smith wrote: >> --- a/xen/xsm/xsm_core.c >> +++ b/xen/xsm/xsm_core.c >> @@ -55,19 +55,35 @@ static enum xsm_bootparam __initdata xsm_bootparam = >> XSM_BOOTPARAM_DUMMY; >> #endif >> >> +static bool __initdata init_policy = >> +#ifdef CONFIG_XSM_FLASK_DEFAULT >> + true; >> +#else >> + false; >> +#endif > > Simply IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT) without any #ifdef-ary? Ack, didn't even think of that. Thanks! >> @@ -148,11 +156,11 @@ int __init xsm_multiboot_init( >> >> printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); >> >> - if ( XSM_MAGIC ) >> + if ( init_policy && XSM_MAGIC ) >> { >> ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, >> &policy_size); >> - if ( ret ) >> + if ( ret != 0 ) > > Nit: Stray change? Yep, I twiddled with the if statement while testing/debugging all the permutations of enabled policies, default policy, built-in policy, and cmdline selected policy. Will clean up. >> @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( >> { >> int i; >> module_t *mod = (module_t *)__va(mbi->mods_addr); >> - int rc = 0; >> + int rc = -ENOENT; > > I'm afraid I can't easily convince myself that this and the other > -ENOENT is really relevant to this change and/or not breaking > anything which currently does work (i.e. not entirely benign). > Please can you extend the description accordingly or split off > this adjustment? Let me expand the commit explanation, and you can let me know how much of this detail you would like to see in the commit message. When enabling CONFIG_XSM_FLASK today, the XSM_MAGIC variable becomes defined as a non-zero value. This results in xsm_XXXX_policy_init() to be called regardless of the XSM policy selection, either through the respective CONFIG_XSM_XXXXX_DEFAULT flags or through the cmdline parameter. Additionally, the concept of policy initialization is split between xsm_XXXX_policy_init() and xsm_core_init(), with the latter being where the built-in policy would be selected. This forces xsm_XXXX_policy_init() to have to return successful for configurations where no policy loading was necessary. It also means that the situation where selecting XSM flask, with no built-in policy, and failure to provide a policy via MB/DT relies on the security server to fault when it is unable to load a policy. What this commit does is moves all policy buffer initialization to xsm_XXXX_policy_init(). As the init function, it should only return success (0) if it was able to initialize the policy buffer with either the built-in policy or a policy loaded from MB/DT. The second half of this commit corrects the logical flow so that the policy buffer initialization only occurs for XSM policy modules that consume a policy buffer, e.g. flask. I would note the opening of the commit message notes dom0less and hyperlaunch because I came across this while finalizing the first hyperlaunch patch series focused on fully integrating hyperlaunch's bootmodule structure, which will also will enable commonality with dom0less' bootmodule structure, into x86 MB1/MB2/EFI startup paths. I figured this change should just go alone and not with hyperlaunch bootmodule work. >> @@ -79,7 +87,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) >> paddr_t paddr, len; >> >> if ( !mod || !mod->size ) >> +#ifdef CONFIG_XSM_FLASK_POLICY >> + { >> + *policy_buffer = (void *)xsm_flask_init_policy; > > I don't think we want a cast here, especially not when it discards > "const". Instead the local variables' types want adjusting in > xsm_{multiboot,dt}_init() as well as the types of the respective > parameters of xsm_{multiboot,dt}_policy_init(). True, will fix. >> + *policy_size = xsm_flask_init_policy_size; >> return 0; >> + } >> +#else >> + /* No policy was loaded */ >> + return -ENOENT; >> +#endif > > I think this is easier to read if you put the braces there > unconditionally and have the #if / #else inside. And if you wanted > to I think you could get away without any #else then. Ack. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 24 18:00:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 18:00:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336706.561087 (Exim 4.92) (envelope-from ) id 1ntYp7-0005Me-4W; Tue, 24 May 2022 18:00:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336706.561087; Tue, 24 May 2022 18:00:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYp7-0005MX-1S; Tue, 24 May 2022 18:00:01 +0000 Received: by outflank-mailman (input) for mailman id 336706; Tue, 24 May 2022 17:59:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYp5-0005MP-PM for xen-devel@lists.xenproject.org; Tue, 24 May 2022 17:59:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 523a22c0-db8b-11ec-837f-e5687231ffcc; Tue, 24 May 2022 19:59:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2408B819B1; Tue, 24 May 2022 17:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F4ACC34100; Tue, 24 May 2022 17:59:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 523a22c0-db8b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653415194; bh=O23kCg5BjIoTnjoGWgJg0oMLdYIrdRRC0baQ4M1oVo0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jR9SsuMxiuG5xTMQ18/B5Pk9RuJXhUp2GIykcRgSKtpFkfBWCCD06o05bZ3GHZtkh VTfe9vGuqrXoxL7Jl6KJhbN2kHKrhzYexW/2hHOOmqpEQ6ZmCZ5C2pn+Ud1uurTAvg 57f39vFTXq5TMwAp9fkRrkIJe4h/OvMtbh9NZQ1ZI2eFTTv2weGir+6HKkQgIVQVyW EmqU5mn0/Lb0t2CXL/h4sXjdtwGhYHFQjxQFXczaWTs8oFrG+Fi910JO9fYfE+u6/2 NsM6uDBXYkGZCvVp9/u8M7vIISP8K6mMBdC5TPIaWiPv5Z9sffeLDGNWiolccS9L3T IVBkU5NfndtBA== Date: Tue, 24 May 2022 10:59:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr cc: Stefano Stabellini , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops In-Reply-To: <606dfdcc-ec10-0c4a-04e9-72cd73ee6676@gmail.com> Message-ID: References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> <606dfdcc-ec10-0c4a-04e9-72cd73ee6676@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1170483708-1653415194=:1905099" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1170483708-1653415194=:1905099 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 24 May 2022, Oleksandr wrote: > > On Mon, 23 May 2022, Oleksandr wrote: > > > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr > > > > > > > wrote: > > > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > > > > > > > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > > > > > > > > > wrote: > > > > > > > > >     This would mean having a device > > > > > > > > > node for the grant-table mechanism that can be referred to > > > > > > > > > using > > > > > > > > > the > > > > > > > > > 'iommus' > > > > > > > > > phandle property, with the domid as an additional argument. > > > > > > > > I assume, you are speaking about something like the following? > > > > > > > > > > > > > > > > > > > > > > > > xen_dummy_iommu { > > > > > > > >       compatible = "xen,dummy-iommu"; > > > > > > > >       #iommu-cells = <1>; > > > > > > > > }; > > > > > > > > > > > > > > > > virtio@3000 { > > > > > > > >       compatible = "virtio,mmio"; > > > > > > > >       reg = <0x3000 0x100>; > > > > > > > >       interrupts = <41>; > > > > > > > > > > > > > > > >       /* The device is located in Xen domain with ID 1 */ > > > > > > > >       iommus = <&xen_dummy_iommu 1>; > > > > > > > > }; > > > > > > > Right, that's that's the idea, > > > > > > thank you for the confirmation > > > > > > > > > > > > > > > > > > > > > > > > >    except I would not call it a 'dummy'. > > > > > > >   From the perspective of the DT, this behaves just like an > > > > > > > IOMMU, > > > > > > > even if the exact mechanism is different from most hardware IOMMU > > > > > > > implementations. > > > > > > well, agree > > > > > > > > > > > > > > > > > > > > > It does not quite fit the model that Linux currently uses for > > > > > > > > > iommus, > > > > > > > > > as that has an allocator for dma_addr_t space > > > > > > > > yes (# 3/7 adds grant-table based allocator) > > > > > > > > > > > > > > > > > > > > > > > > > , but it would think it's > > > > > > > > > conceptually close enough that it makes sense for the binding. > > > > > > > > Interesting idea. I am wondering, do we need an extra actions > > > > > > > > for > > > > > > > > this > > > > > > > > to work in Linux guest (dummy IOMMU driver, etc)? > > > > > > > It depends on how closely the guest implementation can be made to > > > > > > > resemble a normal iommu. If you do allocate dma_addr_t addresses, > > > > > > > it may actually be close enough that you can just turn the > > > > > > > grant-table > > > > > > > code into a normal iommu driver and change nothing else. > > > > > > Unfortunately, I failed to find a way how use grant references at > > > > > > the > > > > > > iommu_ops level (I mean to fully pretend that we are an IOMMU > > > > > > driver). I > > > > > > am > > > > > > not too familiar with that, so what is written below might be wrong > > > > > > or > > > > > > at > > > > > > least not precise. > > > > > > > > > > > > The normal IOMMU driver in Linux doesn’t allocate DMA addresses by > > > > > > itself, it > > > > > > just maps (IOVA-PA) what was requested to be mapped by the upper > > > > > > layer. > > > > > > The > > > > > > DMA address allocation is done by the upper layer (DMA-IOMMU which > > > > > > is > > > > > > the glue > > > > > > layer between DMA API and IOMMU API allocates IOVA for PA?). But, > > > > > > all > > > > > > what we > > > > > > need here is just to allocate our specific grant-table based DMA > > > > > > addresses > > > > > > (DMA address = grant reference + offset in the page), so let’s say > > > > > > we > > > > > > need an > > > > > > entity to take a physical address as parameter and return a DMA > > > > > > address > > > > > > (what > > > > > > actually commit #3/7 is doing), and that’s all. So working at the > > > > > > dma_ops > > > > > > layer we get exactly what we need, with the minimal changes to guest > > > > > > infrastructure. In our case the Xen itself acts as an IOMMU. > > > > > > > > > > > > Assuming that we want to reuse the IOMMU infrastructure somehow for > > > > > > our > > > > > > needs. > > > > > > I think, in that case we will likely need to introduce a new > > > > > > specific > > > > > > IOVA > > > > > > allocator (alongside with a generic one) to be hooked up by the > > > > > > DMA-IOMMU > > > > > > layer if we run on top of Xen. But, even having the specific IOVA > > > > > > allocator to > > > > > > return what we indeed need (DMA address = grant reference + offset > > > > > > in > > > > > > the > > > > > > page) we will still need the specific minimal required IOMMU driver > > > > > > to > > > > > > be > > > > > > present in the system anyway in order to track the mappings(?) and > > > > > > do > > > > > > nothing > > > > > > with them, returning a success (this specific IOMMU driver should > > > > > > have > > > > > > all > > > > > > mandatory callbacks implemented). > > > > > > > > > > > > I completely agree, it would be really nice to reuse generic IOMMU > > > > > > bindings > > > > > > rather than introducing Xen specific property if what we are trying > > > > > > to > > > > > > implement in current patch series fits in the usage of "iommus" in > > > > > > Linux > > > > > > more-less. But, if we will have to add more complexity/more > > > > > > components > > > > > > to the > > > > > > code for the sake of reusing device tree binding, this raises a > > > > > > question > > > > > > whether that’s worthwhile. > > > > > > > > > > > > Or I really missed something? > > > > > I think Arnd was primarily suggesting to reuse the IOMMU Device Tree > > > > > bindings, not necessarily the IOMMU drivers framework in Linux > > > > > (although > > > > > that would be an added bonus.) > > > > > > > > > > I know from previous discussions with you that making the grant table > > > > > fit in the existing IOMMU drivers model is difficult, but just reusing > > > > > the Device Tree bindings seems feasible? > > > > I started experimenting with that. As wrote in a separate email, I got a > > > > deferred probe timeout, > > > > > > > > after inserting required nodes into guest device tree, which seems to be > > > > a > > > > consequence of the unavailability of IOMMU, I will continue to > > > > investigate > > > > this question. > > > > > > I have experimented with that. Yes, just reusing the Device Tree bindings > > > is > > > technically feasible (and we are able to do this by only touching > > > grant-dma-ops.c), although deferred probe timeout still stands (as there > > > is no > > > IOMMU driver being present actually). > > > > > > [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, > > > ignoring > > > dependency > > > [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks > > > (2.10 > > > GB/1.95 GiB) > > > > > > > > > Below the working diff (on top of current series): > > > > > > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c > > > index da9c7ff..6586152 100644 > > > --- a/drivers/xen/grant-dma-ops.c > > > +++ b/drivers/xen/grant-dma-ops.c > > > @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = > > > { > > > > > >  bool xen_is_grant_dma_device(struct device *dev) > > >  { > > > +       struct device_node *iommu_np; > > > +       bool has_iommu; > > > + > > >         /* XXX Handle only DT devices for now */ > > >         if (!dev->of_node) > > >                 return false; > > > > > > -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); > > > +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); > > > +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, > > > "xen,grant-dma"); > > > +       of_node_put(iommu_np); > > > + > > > +       return has_iommu; > > >  } > > > > > >  void xen_grant_setup_dma_ops(struct device *dev) > > >  { > > >         struct xen_grant_dma_data *data; > > > -       uint32_t domid; > > > +       struct of_phandle_args iommu_spec; > > > > > >         data = find_xen_grant_dma_data(dev); > > >         if (data) { > > > @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) > > >         if (!dev->of_node) > > >                 goto err; > > > > > > -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", > > > &domid)) { > > > -               dev_err(dev, "xen,backend-domid property is not > > > present\n"); > > > +       if (of_parse_phandle_with_args(dev->of_node, "iommus", > > > "#iommu-cells", > > > +                       0, &iommu_spec)) { > > > +               dev_err(dev, "Cannot parse iommus property\n"); > > > +               goto err; > > > +       } > > > + > > > +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || > > > +                       iommu_spec.args_count != 1) { > > > +               dev_err(dev, "Incompatible IOMMU node\n"); > > > +               of_node_put(iommu_spec.np); > > >                 goto err; > > >         } > > > > > > +       of_node_put(iommu_spec.np); > > > + > > >         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > > >         if (!data) > > >                 goto err; > > > > > > -       data->backend_domid = domid; > > > +       /* > > > +        * The endpoint ID here means the ID of the domain where the > > > corresponding > > > +        * backend is running > > > +        */ > > > +       data->backend_domid = iommu_spec.args[0]; > > > > > >         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, > > > data, > > >                         GFP_KERNEL))) { > > > (END) > > > > > > > > > > > > Below, the nodes generated by Xen toolstack: > > > > > >         xen_grant_dma { > > >                 compatible = "xen,grant-dma"; > > >                 #iommu-cells = <0x01>; > > >                 phandle = <0xfde9>; > > >         }; > > > > > >         virtio@2000000 { > > >                 compatible = "virtio,mmio"; > > >                 reg = <0x00 0x2000000 0x00 0x200>; > > >                 interrupts = <0x00 0x01 0xf01>; > > >                 interrupt-parent = <0xfde8>; > > >                 dma-coherent; > > >                 iommus = <0xfde9 0x01>; > > >         }; > > Not bad! I like it. > > > Good. > > > > > > > > I am wondering, would be the proper solution to eliminate deferred probe > > > timeout issue in our particular case (without introducing an extra IOMMU > > > driver)? > > In reality I don't think there is a way to do that. I would create an > > empty skelethon IOMMU driver for xen,grant-dma. > > Ok, I found yet another option how we can avoid deferred probe timeout issue. > I am not sure whether it will be welcome. But it doesn't really require > introducing stub IOMMU driver or other changes in the guest. The idea is to > make IOMMU device unavailable (status = "disabled"), this way > of_iommu_configure() will treat that as success condition also. > > https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L31 > https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L149 > >         xen_grant_dma { >                 compatible = "xen,grant-dma"; >                 #iommu-cells = <0x01>; >                 phandle = <0xfde9>; >                 status = "disabled"; >         }; >         virtio@2000000 { >                 compatible = "virtio,mmio"; >                 reg = <0x00 0x2000000 0x00 0x200>; >                 interrupts = <0x00 0x01 0xf01>; >                 interrupt-parent = <0xfde8>; >                 dma-coherent; >                 iommus = <0xfde9 0x01>; >         }; > > I have checked, this "fixes" deferred probe timeout issue. > > > Or we indeed need to introduce stub IOMMU driver (I placed it to driver/xen > instead of driver/iommu, also we can even squash it with grant-dma-ops.c?). > This stub driver also results in NO_IOMMU condition (as "of_xlate" callback is > not implemented). > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index a7bd8ce..35b91b9 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -335,6 +335,10 @@ config XEN_UNPOPULATED_ALLOC >           having to balloon out RAM regions in order to obtain physical memory >           space to create such mappings. > > +config XEN_GRANT_DMA_IOMMU > +       bool > +       select IOMMU_API > + >  config XEN_GRANT_DMA_OPS >         bool >         select DMA_OPS > @@ -343,6 +347,7 @@ config XEN_VIRTIO >         bool "Xen virtio support" >         depends on VIRTIO >         select XEN_GRANT_DMA_OPS > +       select XEN_GRANT_DMA_IOMMU >         help >           Enable virtio support for running as Xen guest. Depending on the >           guest type this will require special support on the backend side > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 1a23cb0..c0503f1 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -40,3 +40,4 @@ xen-privcmd-y                         := privcmd.o > privcmd-buf.o >  obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)    += xen-front-pgdir-shbuf.o >  obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)    += unpopulated-alloc.o >  obj-$(CONFIG_XEN_GRANT_DMA_OPS)                += grant-dma-ops.o > +obj-$(CONFIG_XEN_GRANT_DMA_IOMMU)      += grant-dma-iommu.o > diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c > new file mode 100644 > index 00000000..b8aad8a > --- /dev/null > +++ b/drivers/xen/grant-dma-iommu.c > @@ -0,0 +1,76 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Stub IOMMU driver which does nothing. > + * The main purpose of it being present is to reuse generic device-tree IOMMU > + * bindings by Xen grant DMA-mapping layer. > + */ > + > +#include > +#include > +#include > + > +struct grant_dma_iommu_device { > +       struct device *dev; > +       struct iommu_device iommu; > +}; > + > +/* Nothing is really needed here */ > +static const struct iommu_ops grant_dma_iommu_ops; > + > +static const struct of_device_id grant_dma_iommu_of_match[] = { > +       { .compatible = "xen,grant-dma" }, > +       { }, > +}; > + > +static int grant_dma_iommu_probe(struct platform_device *pdev) > +{ > +       struct grant_dma_iommu_device *mmu; > +       int ret; > + > +       mmu = devm_kzalloc(&pdev->dev, sizeof(*mmu), GFP_KERNEL); > +       if (!mmu) > +               return -ENOMEM; > + > +       mmu->dev = &pdev->dev; > + > +       ret = iommu_device_register(&mmu->iommu, &grant_dma_iommu_ops, > &pdev->dev); > +       if (ret) > +               return ret; > + > +       platform_set_drvdata(pdev, mmu); > + > +       return 0; > +} > + > +static int grant_dma_iommu_remove(struct platform_device *pdev) > +{ > +       struct grant_dma_iommu_device *mmu = platform_get_drvdata(pdev); > + > +       platform_set_drvdata(pdev, NULL); > +       iommu_device_unregister(&mmu->iommu); > + > +       return 0; > +} > + > +static struct platform_driver grant_dma_iommu_driver = { > +       .driver = { > +               .name = "grant-dma-iommu", > +               .of_match_table = grant_dma_iommu_of_match, > +       }, > +       .probe = grant_dma_iommu_probe, > +       .remove = grant_dma_iommu_remove, > +}; > + > +static int __init grant_dma_iommu_init(void) > +{ > +       struct device_node *iommu_np; > + > +       iommu_np = of_find_matching_node(NULL, grant_dma_iommu_of_match); > +       if (!iommu_np) > +               return 0; > + > +       of_node_put(iommu_np); > + > +       return platform_driver_register(&grant_dma_iommu_driver); > +} > +subsys_initcall(grant_dma_iommu_init); > > I have checked, this also "fixes" deferred probe timeout issue. > > Personally I would prefer the first option, but I would be also happy to use > second option in order to unblock the series. > > What do the maintainers think? I don't think it is a good idea to mark the fake IOMMU as disabled because it implies that there is no need to use it (no need to use dma_ops) which is a problem. If we don't want the skelethon driver then Rob's suggestion of having a skip list for deferred probe is better. I think the skelethon driver also is totally fine. --8323329-1170483708-1653415194=:1905099-- From xen-devel-bounces@lists.xenproject.org Tue May 24 18:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 18:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336707.561097 (Exim 4.92) (envelope-from ) id 1ntYpN-0006ZK-EW; Tue, 24 May 2022 18:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336707.561097; Tue, 24 May 2022 18:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYpN-0006ZD-BU; Tue, 24 May 2022 18:00:17 +0000 Received: by outflank-mailman (input) for mailman id 336707; Tue, 24 May 2022 18:00:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntYpM-0005MP-Mj for xen-devel@lists.xenproject.org; Tue, 24 May 2022 18:00:16 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c6f1f52-db8b-11ec-837f-e5687231ffcc; Tue, 24 May 2022 20:00:15 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653415195405721.5775292220314; Tue, 24 May 2022 10:59:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c6f1f52-db8b-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653415213; cv=none; d=zohomail.com; s=zohoarc; b=WBK6L3Nel+O6afU+R/ZpE0N5PK/NOQEv56faR79y+sm8o3HadX8Y30hZGQT2IHrhe4h9Z4CFmCK8Oe4h2d6pJLubUMmUt2eEW/zchNEIQfF63lGSz/ZlSqpg5K3ymGvnCFNvBRDWEcG6aKd1LmKGJ0L3rFteAQ5ggt49N2pSF7Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653415213; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=A0NTTAo1SuOkAyNJpRscid4Uxwkm6A6JVfaNhMYraAc=; b=MBhQv8sUsuQCAM2OE+Y8tUVmg2TqUoKNrD0+Oo4+nOa9H4V9C0gKlBaAX9p+Cx6NLszCQynxCrePUjrBVZtDkI9pXw4VJ9Cy8ApKQHt1klWvEhAmFJ7Th7SLasv/zoWHSyp2C5ljclWJ0PmtktoIogf6hum3uCudBP5QbgVl5P4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653415213; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=A0NTTAo1SuOkAyNJpRscid4Uxwkm6A6JVfaNhMYraAc=; b=oElyvfoYTOfAwEqwk3QNciI4MzxmkYw16D2pKgQl+SqVFsHJlniRd+B4PVxjGvqC FcuciLnyMWQye4y8SpFsMGpt/kX2WNgtD0ZDp35E0WBaeAW4501g6/VPhNoFsi5kXoA Z8ZG4GnbvzZMVMUbSonfcMGN5GR9wGmDKL1VNrLM= Message-ID: Date: Tue, 24 May 2022 13:58:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Jason Andryuk Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Daniel De Graaf References: <20220523154024.1947-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xsm: refactor and optimize policy loading In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/24/22 12:17, Jason Andryuk wrote: > On Mon, May 23, 2022 at 11:40 AM Daniel P. Smith > wrote: >> >> It is possible to select a few different build configurations that results in >> the unnecessary walking of the boot module list looking for a policy module. >> This specifically occurs when the flask policy is enabled but either the dummy >> or the SILO policy is selected as the enforcing policy. This is not ideal for >> configurations like hyperlaunch and dom0less when there could be a number of >> modules to be walked or unnecessary device tree lookups >> >> This patch does two things, it moves all policy initialization logic under the >> xsm_XXXX_policy_init() functions and introduces the init_policy flag. The >> init_policy flag will be set based on which enforcing policy is selected and >> gates whether the boot modules should be checked for a policy file. > > I can see the use of init_policy to skip the search. (I'm not the > biggest fan of the name, need_policy/uses_policy/has_policy?, but > that's not a big deal). That part seems fine. Yep, I went through that and several other variations trying to find the one that would "read" best at the places it was set and checked. If anyone has a strong stance for a preferred naming, I have no objections. > I don't care for the movement of `policy_buffer = > xsm_flask_init_policy;` since it replaces the single location with two > locations. I prefer leaving the built-in policy fallback in > xsm_core_init since it is multiboot/devicetree agnostic. i.e. the > boot-method specific code passes a policy if it finds one, and > xsm_core_init can fallback to the built-in policy if none is supplied. > Since a built-in policy is flask specific, it could potentially be > pushed down in flask_init. > > Is there a need for the xsm_flask_init_policy movement I am missing? I would be willing to bet that the de-duplication is the reason it was initially done this way. But as I explained in the response to Jan, doing so means that xsm_XXXX_policy_init() will have to return success even if it did not successfully initialize the policy buffer. I considered making a static inline function to point the policy buffer at the built-in policy, but quickly walked back from it. The reason being is that it is not any real logic duplications, just two lines of variable setting. IMHO a single repeat of setting a pair of variables is better than the bifurcating of the policy buffer initialization. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 24 18:32:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 18:32:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336722.561109 (Exim 4.92) (envelope-from ) id 1ntZKn-00029Z-5Z; Tue, 24 May 2022 18:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336722.561109; Tue, 24 May 2022 18:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntZKn-00029S-1z; Tue, 24 May 2022 18:32:45 +0000 Received: by outflank-mailman (input) for mailman id 336722; Tue, 24 May 2022 18:32:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntZKl-00029M-5e for xen-devel@lists.xenproject.org; Tue, 24 May 2022 18:32:43 +0000 Received: from sonic317-20.consmr.mail.gq1.yahoo.com (sonic317-20.consmr.mail.gq1.yahoo.com [98.137.66.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e347393a-db8f-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 20:32:40 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Tue, 24 May 2022 18:32:37 +0000 Received: by hermes--canary-production-ne1-5495f4d555-xgn59 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f18826b5cd811627c8ace28c66b17372; Tue, 24 May 2022 18:32:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e347393a-db8f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653417157; bh=bWdvczIx7ry7wZOALAI1wr+HsImsxjNz7PtVMvZvtj8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=lBrYG59B4NAY+zeSFmHe92QcF1AtKxVljoQibxCKbJeGAH6xT4wrcxRqmVgG+ZOnF/NwJnyx2D2jrxTQFFqcrnsNlQGzqyBr5FBJqtk4pi20bJU2LWH5nt4WpEOYVPfuX/21cWrYreqcQWzIW3bKDCN1zS/9lbxTnCbXPvnX3ZjxQ+R/5bhf6v7zWSSZK5o9Lmxj2GTwf3/bdDZH9StPsPqz35Mce5ne2lTmyWvajx/dMfqjTw4Pj0lYyatwW5y/sJEvGh1y0rOGiz3cyRN3KY927n2ZsoCD++cxgFVxAB7Aa0L9w+gA+GQUMTzOEf1asJoeqnEjrBV3QOonXUDNAw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653417157; bh=s3RpZhgR4s9uWwhVoE5EIzWfLL3MAfA6mE5D7/0OW9A=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=XrB1Ps2zvpEsObxvQNaMgTqSxGlBkUGvkxRXCc3LJIL9Ix9+giBk514R43WYLmzpvcT5yUIeaeMertglYe0cAsiPxgqXTudWefTGZVv0eZ30RFj1BMIubkW5z362+2jITR0lCNEhFCMWOVm1b7Diio8crHcxT3hUT1uXvdGPOuMzi12PmZ/KNzkksfLObxZNgb8mNiuLxXB2xOV2ysRLkuI6OKzAq6zaS7NP064Ao4o8x+Y7nVk5NQIdd1IYsv8hbUYkpv7YvVUw8bju8kc5/IknnI7C5gDhpfuZwR892FeSehs4tQqExb0gJ94bzSVw6FFnyVrupqGThIPulLOE2g== X-YMail-OSG: J42Z.mEVM1mppfHkyqWoRpCGB0mXn4dGsrlfQrFalIJjwaJPzLD9X6PbJIQodNc I1oX7Jwl3xDkSLGmOgC5IpFTFwncYKvZWjVHTKDLXTLUvGnVEZkhM.cT1_Qe32_VHoIQ3K7QhF_T fs2bSdHo8POl2vloU_or9Ynxo84f3n.pglT46gC4Q4zpaZHmvPUxNn0LpHNAkoLizYif2vDzLkDN L2J.leqIbGq61xTEGg37LZLVNmrLtecDoe_l80EkYfKzUGob7bKDek3tx3HXFvq4XeZGmXPVBRgI x04Y0LzovydetX11xkm9BEmp9VplSympKgWB_sopf7ndo2VPviGMVxPCkUTzdGzmQTHZeuHK0baM nwY95HLmK1tKFLfmUIyfsOf5Sh.SoTzGFP6KNI5prw3OwnfgXTEb2Xvn5VkHva.Lbb_hWgKRBi8G QY5avLVfQkfBm6rlcpDdAyoFgVQg91OsH0xDDQmw.JUiU_h3O39Vdw6GHo1Z6CSnKa.8mHrCZ2_K oC4Ic26g68biMyU7QCQJLoQO3td.jifMKrUOMzd4Yqnl2nus4HtKD5tlFy6mZVRiIQwkfhYnZuHf Uh_bh0hSTs6dE5rb7ionVmwIdwcxkEeLN_s_jFj8.TDWfS4oWJGG5yGmLBstw4rdPrCnx9tMoote F_KQxur7Sj9Ruo1OK0xckP0ZgJ3f0v.CEkt7kSE0j_ScNJ1v3Q553xBBj6PlyTXa41Q1hTBLmCnl wbhkOGD92YNzz.4nG5x2jfC7L2nwVlXI8RAUlPQTj1eqK1Qys5ECNU10auqEMFbXQDaNUdYJQ4tY udzuQWNh4CMSf93DwYXh7cOuc5rmERY7rfYkGnbmn2y4MeTBJmyFFo03_p.DSotwbJUAsDBxYdXR HeH30PSe8o3Ni0rcOFixzqo8jA3bZ27ISECfahxR1842QNS.3j_Bw7.kyikWGTxKZza03bcbF_re s8Hs9syqWwy37LhyVfe1Clm.rCIN1QHsWR2hxOMwERAHqL4DDCO4MMe8LrgGRJWdTwZdxyuNYSBB 8CNU65ORiE5idkjg44.En3efNoi06JYJRY9h3r8eULAFVTUr.MO3XCxmsipHeIlxx4a8PYp9DU15 F0Gm_CiSgul2mWQzUs.nE0FRzMnU6BjZ4d2WU7k6UKNpp79v1QfKy4DCjPzNnAiBS793Mdd6IBCu WHkQmdAT.VgfAfi7pJvHVWH_iZu5fV1rJT7l1Rx.2heRhzdabGeZPi0QbUcG4wbKybegpH_EACkF vOgMlKG6W5vcpNztXUerPYCueShA1SWGTgpz5bnwoqo2GbZOMjo.IR8Ynb.AYp5Flc.iKINKy4s_ X911QoCXMBQzNfz9An9pQfeZuVFZJBripjQQ50X3v4tOn0rlSMMZZSXSpoVY2x6iFkyAof0PfENZ tHSP8r8ssIS.y8Fmj_9gc._SeczNxPHfThrqEluHwUQf35vlYvTfh6XHJKGzuECWx5uNgsuNWsqj 0f_S.WJHzmAJ9URgVJQlIzI_pHXQt9nPBoXkmz_7c6PsZRN9cJniMmvaf68QUryyFy5V36_LDfHo SdxQy7829U58fbic2I.iEfnQ3hh8KCaMUqihkmRXOSZlHxxqRjNin4eFDoi_qSAqFB7o1h6YSwSS .sm9dDBiw1C_sJSRJLUYxCKJPxkkFb3NsgDodKxcUVAN3nBzY6QW9JkRLTfXIhZ7SMrrmknSQhw1 Dzhd6yHj4lcrd_4VFOFi5lMKOMsLdD6ydUpoWhwkCt.vDH8OJbd4Nk0ruPBOscAbBl0MJgzAMjEs zvO3sePr.8oHBgzNEw2wYX5u9Y7ykffC_YtgPSLRg.HAZxlWLMGVDWT4a5UKhsPuoHpX_Xf19WGf UdAqS6bb7MlA_K_coB3EGR3.CvJst2VQD5ewL5XK0s7NWI28ks1WbdmImZr9yQE3dkHLe7YYmq2t SS90c4vme4OWiiEokiOsIIb94tvgpAUhGXsVSu9Cp9Cjv_hr9ImPppkeec9Fjv944GfzlIQ2a18w P1eeVMx2c2mRgA3n0r8aq.LnmhxnQ3Ee2CFIPGpkb1ptoJ3mdELhzQiQ3wdzcwJhSAzoTPoQY4V. YBEK7no8jP6Ftxfj9Gh1k9rgPy9qGCbS9iJpa3bdVmnahP7gkZ244Pn0W6lEHIt7.RGpVG1lkkL9 mZhwuqB4VikkxukFkcgJR6rdy99.nUF.0YiAAf8kMksIXv0sT.YrlDYaraSWuXayrHTSNnURDwu4 0 X-Sonic-MF: Message-ID: <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> Date: Tue, 24 May 2022 14:32:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Thorsten Leemhuis , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 10859 On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: > On 20.05.22 16:48, Chuck Zmudzinski wrote: >> On 5/20/2022 10:06 AM, Jan Beulich wrote: >>> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>>> >>>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>>> those want >>>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>>> inspect them >>>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>>> observe the >>>>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() >>>>>>>>>>> as the >>>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>>> earlier >>>>>>>>>>> patch, in >>>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>>> to be >>>>>>>>>>> the >>>>>>>>>>> problematic one, which you leave alone. >>>>>>>>>> Oh, I missed that one, sorry. >>>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>>> >>>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>>> least >>>>>>>>>> the >>>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>>> >>>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>>> should not override that, >>>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>>> an override would affect only the single domain where the >>>>>>>> kernel runs; other domains could take their own decisions. >>>>>>>> >>>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>>> (but tell us "don't do that then"). >>>>>> Actually I just did a test with the last official Debian kernel >>>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>>> normally on both the bare metal and on the Xen hypervisor. >>>>>> That means your presumption (and the presumption of >>>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>>> had no effect on my system with Linux 5.16. So after doing these >>>>>> tests, I am against the aggressive approach of breaking the i915 >>>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>>> nopat did not break the i915 driver. Why break it now? >>>>> Because that's, in my understanding, is the purpose of "nopat" >>>>> (not breaking the driver of course - that's a driver bug -, but >>>>> having an effect on the driver). >>>> I wouldn't call it a driver bug, but an incorrect configuration of the >>>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>>> i915 driver >>> The driver ought to work fine without PAT (and hence without being >>> able to make WC mappings). It would use UC instead and be slow, but >>> it ought to work. >>> >>>> and therefore the driver should refuse to disable >>>> it if the user requests to disable it and instead warn the user that >>>> the driver did not disable the feature, contrary to what the user >>>> requested with the nopat option. >>>> >>>> In any case, my test did not verify that when nopat is set in Linux >>>> 5.16, >>>> the thread takes the same code path as when nopat is not set, >>>> so I am not totally sure that the reason nopat does not break the >>>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>>> returns true even when nopat is set. I could test it with a custom >>>> log message in 5.16 if that is necessary. >>>> >>>> Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) >>>> to return true in 5.16 when the user requests nopat? >>> No, I'm not saying that. It was wrong for this construct to be used >>> in the driver, which was fixed for 5.17 (and which had caused the >>> regression I did observe, leading to the patch as a hopefully least >>> bad option). >>> >>>> I think that is >>>> just permitting a bad configuration to break the driver that a >>>> well-written operating system should not allow. The i915 driver >>>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>>> because that option is not compatible with the hardware the >>>> i915 driver is trying to initialize and setup at boot time. At least >>>> that is my understanding now, but I will need to test it on 5.16 >>>> to be sure I understand it correctly. >>>> >>>> Also, AFAICT, your patch would break the driver when the nopat >>>> option is set and only fix the regression introduced by bdd8b6c98239 >>>> when nopat is not set on my box, so your patch would >>>> introduce a regression relative to Linux 5.16 and earlier for the >>>> case when nopat is set on my box. I think your point would >>>> be that it is not a regression if it is an incorrect user configuration. >>> Again no - my view is that there's a separate, pre-existing issue >>> in the driver which was uncovered by the change. This may be a >>> perceived regression, but is imo different from a real one. > Sorry, for you maybe, but I'm pretty sure for Linus it's not when it > comes to the "no regressions rule". Just took a quick look at quotes > from Linus > https://www.kernel.org/doc/html/latest/process/handling-regressions.html > and found this statement from Linus to back this up: > > ``` > One _particularly_ last-minute revert is the top-most commit (ignoring > the version change itself) done just before the release, and while > it's very annoying, it's perhaps also instructive. > > What's instructive about it is that I reverted a commit that wasn't > actually buggy. In fact, it was doing exactly what it set out to do, > and did it very well. In fact it did it _so_ well that the much > improved IO patterns it caused then ended up revealing a user-visible > regression due to a real bug in a completely unrelated area. > ``` > > He said that here: > https://www.kernel.org/doc/html/latest/process/handling-regressions.html > > The situation is of course different here, but similar enough. > >> Since it is a regression, I think for now bdd8b6c98239 should >> be reverted and the fix backported to Linux 5.17 stable until >> the underlying memory subsystem can provide the i915 driver >> with an updated test for the PAT feature that also meets the >> requirements of the author of bdd8b6c98239 without breaking >> the i915 driver. > I'm not a developer and I'm don't known the details of this thread and > the backstory of the regression, but it sounds like that's the approach > that is needed here until someone comes up with a fix for the regression > exposed by bdd8b6c98239. > > But if I'm wrong, please tell me. You are mostly right, I think. Reverting bdd8b6c98239 fixes it. There is another way to fix it, though. The patch proposed by Jan Beulich also fixes the regression on my system, so as the person reporting this is a regression, I would also be satisfied with Jan's patch instead of reverting bdd8b6c98239 as a fix. Jan posted his proposed patch here: https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ The only reservation I have about Jan's patch is that the commit message does not clearly explain how the patch changes what the nopat kernel boot option does. It doesn't affect me because I don't use nopat, but it should probably be mentioned in the commit message, as pointed out here: https://lore.kernel.org/lkml/bd9ed2c2-1337-27bb-c9da-dfc7b31d492c@netscape.net/ Whatever fix for the regression exposed by bdd8b6c98239 also needs to be backported to the stable versions 5.17 and 5.18. Regards, Chuck Zmudzinski > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > reports and sometimes miss something important when writing mails like > this. If that's the case here, don't hesitate to tell me in a public > reply, it's in everyone's interest to set the public record straight. > >> The i915 driver relies on the memory subsytem >> to provide it with an accurate test for the existence of >> X86_FEATURE_PAT. I think your patch provides that more accurate >> test so that bdd8b6c98239 could be re-applied when your patch is >> committed. Juergen's patch would have to touch bdd8b6c98239 >> with new functions that probably have unknown and unintended >> consequences, so I think your approach is also better in that regard. >> As regards your patch, there is just a disagreement about how the >> i915 driver should behave if nopat is set. I agree the i915 driver >> could do a better job handling that case, at least with better error >> logs. >> >> Chuck >> >>>> I respond by saying a well-written driver should refuse to honor >>>> the incorrect configuration requested by the user and instead >>>> warn the user that it did not honor the incorrect kernel option. >>>> >>>> I am only presuming what your patch would do on my box based >>>> on what I learned about this problem from my debugging. I can >>>> also test your patch on my box to verify that my understanding of >>>> it is correct. >>>> >>>> I also have not yet verified Juergen's patch will not fix it, but >>>> I am almost certain it will not unless it is expanded so it also >>>> touches i915_gem_object_pin_map() with the fix. I plan to test >>>> his patch, but expanded so it touches that function also. >>>> >>>> I also plan to test your patch with and without nopat and report the >>>> results in the thread where you posted your patch. Hopefully >>>> by tomorrow I will have the results. >>>> >>>> Chuck From xen-devel-bounces@lists.xenproject.org Tue May 24 20:17:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 20:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336741.561125 (Exim 4.92) (envelope-from ) id 1ntaxZ-00059Z-W2; Tue, 24 May 2022 20:16:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336741.561125; Tue, 24 May 2022 20:16:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntaxZ-00059S-SN; Tue, 24 May 2022 20:16:53 +0000 Received: by outflank-mailman (input) for mailman id 336741; Tue, 24 May 2022 20:16:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntaxY-00059M-0V for xen-devel@lists.xenproject.org; Tue, 24 May 2022 20:16:52 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71689bf3-db9e-11ec-837f-e5687231ffcc; Tue, 24 May 2022 22:16:50 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id F2E871F447A6 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71689bf3-db9e-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653423409; bh=zYjjoQPSRD28QTzcQmCkF+0zDUTSRxsuI5oi8F0+rRQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fWA1AifiGfpu5zAody+hWBW74K5h5PJY4o9syShHoFUvcDbGztdgO0rxpFXKrmy2Y v+m0QvVaF2TMOM3FrIQn4vCIIUWVeH9erQlS971HHUB5axW0nhIjNhf2t83dRltpj5 F+MJuBOytIM400P1utntTu0dMtY0yhe0QZvOmzJR1Di7UCyoNz6N/1CjkNfHCg26JH 3c5z3Ze+AYN7fowyq3Sq6g1iqMrOvzo1fQihDQtpwVaXvHM7BJiRY1axu6Kqy3ixZu ZneM8hZeXSfA/wa0YX+aUD23BvnxfaiuWymTABWNglyXpsDZsuQOqKpz07ThIMgq+Y y0ERqGVUsfdJQ== Message-ID: <72eceb0c-8654-6c63-f1c4-c9374f99dfb3@collabora.com> Date: Tue, 24 May 2022 23:16:41 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 07/27] kernel/reboot: Add kernel_can_power_off() Content-Language: en-US To: Geert Uytterhoeven Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra , Linux-Renesas References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-8-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/24/22 18:03, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Tue, May 24, 2022 at 3:41 PM Dmitry Osipenko > wrote: >> On 5/24/22 16:14, Geert Uytterhoeven wrote: >>> On Tue, May 10, 2022 at 1:33 AM Dmitry Osipenko >>> wrote: >>>> Add kernel_can_power_off() helper that replaces open-coded checks of >>>> the global pm_power_off variable. This is a necessary step towards >>>> supporting chained power-off handlers. >>>> >>>> Signed-off-by: Dmitry Osipenko >>> >>> Thanks for your patch, which is now commit 0e2110d2e910e44c >>> ("kernel/reboot: Add kernel_can_power_off()") in pm/linux-next. >>> >>> This causes the "poweroff" command (Debian nfsroot) to no longer >>> cleanly halt the system on arm32 systems, but fail with a panic >>> instead: >>> >>> -reboot: System halted >>> +reboot: Power down >>> +Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 >>> +CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted >>> 5.18.0-rc7-shmobile-00007-g0e2110d2e910 #1274 >>> +Hardware name: Generic R-Car Gen2 (Flattened Device Tree) >>> + unwind_backtrace from show_stack+0x10/0x14 >>> + show_stack from dump_stack_lvl+0x40/0x4c >>> + dump_stack_lvl from panic+0xf4/0x330 >>> + panic from do_exit+0x1c8/0x8e4 >>> + do_exit from __do_sys_reboot+0x174/0x1fc >>> + __do_sys_reboot from ret_fast_syscall+0x0/0x54 >>> +Exception stack(0xf0815fa8 to 0xf0815ff0) >>> +5fa0: 004e6954 00000000 fee1dead 28121969 4321fedc f0d94600 >>> +5fc0: 004e6954 00000000 00000000 00000058 befa0c78 00000000 befa0c10 004e56f8 >>> +5fe0: 00000058 befa0b6c b6ec8d45 b6e4a746 >>> +---[ end Kernel panic - not syncing: Attempted to kill init! >>> exitcode=0x00000000 ]--- >>> >>> On arm64, "poweroff" causes a clean "reboot: Power down" before/after. >>> >>> On both arm32 and arm64, the same handlers are registered: >>> - SYS_OFF_MODE_POWER_OFF_PREPARE: legacy_pm_power_off_prepare >>> - SYS_OFF_MODE_POWER_OFF: legacy_pm_power_off >>> >>> On both arm32 and arm64, legacy_pm_power_off_prepare() is called. >>> On both arm32 and arm64, legacy_pm_power_off() does not seem to >>> be called. >>> >>> On arm32, both pm_power_off_prepare and pm_power_off are NULL. >>> On arm64, pm_power_off_prepare is NULL, and >>> pm_power_off is psci_sys_poweroff. >>> >>> Do you have a clue? >>> Thanks! >> >> Thank you, Geert! I see the problem, the kernel_can_power_off() checks whether power-off handler is registered, but it's always registered because legacy_pm_power_off is registered unconditionally. So it causes trouble for platforms that don't have power-off handler installed at all. All platforms that I tested have a power-off handler, so now wonder that I didn't notice this before. >> >> This change should fix the problem, please give it a try: > > Thank you, that fixes the problem for me! > > Tested-by: Geert Uytterhoeven Great! I'll send the proper patch soon. -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Tue May 24 21:44:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 21:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336749.561136 (Exim 4.92) (envelope-from ) id 1ntcKb-0006MD-D2; Tue, 24 May 2022 21:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336749.561136; Tue, 24 May 2022 21:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntcKb-0006M6-9H; Tue, 24 May 2022 21:44:45 +0000 Received: by outflank-mailman (input) for mailman id 336749; Tue, 24 May 2022 21:44:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntcKa-0006Lw-9c; Tue, 24 May 2022 21:44:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntcKa-0001Hh-3F; Tue, 24 May 2022 21:44:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntcKZ-0007Op-DG; Tue, 24 May 2022 21:44:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntcKZ-0000B5-Cp; Tue, 24 May 2022 21:44:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=s5s42NHHBRuOhW5mhKPPEt9/gxr9mWpImwCsFe67wFM=; b=lJEaaL+fHasHynqAwVAsL0/+hD Tb5gOVKPBGze4LWAESTtyO7surRWJYmfQPLj7eYqU4TDHg2f+SXNY/bwDhkytEuM/7bCiRl9joUI6 cYuUq6sYmJ/5x1FYZUVet+HnEaqy+ke6oPXgG/2bthr+0TvfjgKmtddmBEutOT5itNlc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170717: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=143a6252e1b8ab424b4b293512a97cca7295c182 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Tue, 24 May 2022 21:44:43 +0000 flight 170717 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170717/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 143a6252e1b8ab424b4b293512a97cca7295c182 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 0 days Testing same since 170716 2022-05-24 11:12:06 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Alexander Egorenkov Alexander Gordeev Alexandre Belloni Alexandru Elisei Andre Przywara Anshuman Khandual Ard Biesheuvel Baolin Wang Baoquan He Borislav Petkov Catalin Marinas Chen Zhongjin Chen Zhou Chengming Zhou Dan Carpenter Daniel Beer Daniel Lezcano Darryn Anton Jordan Dave Hansen Dave Kleikamp David Arcari David E. Box David Sterba Deyan Wang Frank Crawford Gabriele Mazzotta Geert Uytterhoeven Geert Uytterhoeven Greg Kroah-Hartman Guilherme G. Piccoli Guo Ren Guo Ren Guo Zhengkui Haitao Huang Hans de Goede Haowen Bai Harald Freudenberger Hector Martin Heikki Krogerus Heiko Carstens Ilkka Koskinen Ilya Leoshkevich Jakob Koschel Jarkko Sakkinen Jason Wang Jithu Joseph John Donnelly Jorge Lopez Juerg Haefliger Juerg Haefliger Juergen Gross Julia Lawall Kefeng Wang Laurent Vivier Linu Cherian Linus Torvalds Linus Walleij Luca Miccio Luca Stefani Madhavan T. Venkataraman Marc Zyngier Marco Elver Marek Szyprowski Mario Limonciello Mark Brown Mark Pearson Mark Pearson Mark Rutland Masahiro Yamada Matteo Croce Max Filippov Maximilian Heyne Maximilian Luz Michael Niewöhner Michael Schmitz Michael Shych Michal Orzel Minghao Chi Naresh Kamboju Nathan Chancellor Naveen Krishna Chatradhi Nick Desaulniers Nick Hawkins Niklas Schnelle Oleksandr Tyshchenko # Arm64 only Pali Rohár Palmer Dabbelt Paul Gortmaker Peter Collingbourne Peter Oberparleiter Peter Zijlstra (Intel) Peter Zijlstra Pingfan Liu Prarit Bhargava Qi Liu Randy Dunlap Reinette Chatre Ren Yu Ren Zhijie Rob Herring Robin Murphy Roger Pau Monné Russell King (Oracle) Sebastian Andrzej Siewior SeongJae Park Shaokun Zhang Srinivas Pandruvada Stefano Stabellini Steven Rostedt (Google) Suma Hegde Sumanth Korikkar Sven Schnelle Tanmay Jagdale Thomas Huth Thomas Richter Thomas Weißschuh Tom Rix Tong Tiangen Tony Luck Valentin Schneider Vasily Gorbik Wan Jiabing Wang Kefeng Will Deacon Yang Li Yi Yang Zhen Lei jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7627 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 24 23:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 23:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336768.561171 (Exim 4.92) (envelope-from ) id 1nte2z-0001Hp-Vx; Tue, 24 May 2022 23:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336768.561171; Tue, 24 May 2022 23:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte2z-0001Hi-SL; Tue, 24 May 2022 23:34:41 +0000 Received: by outflank-mailman (input) for mailman id 336768; Tue, 24 May 2022 23:34:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte2y-0001HM-E5 for xen-devel@lists.xenproject.org; Tue, 24 May 2022 23:34:40 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1266aa72-dbba-11ec-837f-e5687231ffcc; Wed, 25 May 2022 01:34:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id EC4B9CE1BC1; Tue, 24 May 2022 23:34:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1359C34100; Tue, 24 May 2022 23:34:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1266aa72-dbba-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653435273; bh=7x77m0lmq569NxhePN9/OdYwzLfoyhfSqs84CUo+gK8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=BCGM9EIIabsiIOMMg+/Vdmxi1v+XFf9nRKNcCZkGmP2rPb7SRzw/mbMI0O/WuOiH7 heZPzdAaozpT7vHj38sFKd2Fh6J5n/oDUrOABUB+kWn1JcpZFryqIblmwGGbyMUqMd wfOIc+idIma/WHXKKjy/qYTNDAZ4bZYpWB/RGkWkf56JtdH54Lb8d9qyNPIqyVeQeH mpkDyHOmDG/CPtSbLeHgPNtKYyw/jxz08sMUCd4C0oeoqWcBEMEnKh1s1y+vrZgosZ 8qXbIr51v2XI+9ngL5Im0rNsiW0OrGBsmpxaUsi1b/mOF3LsPd79wzkPkWGbzkyCS8 ZlZffdS4uFlAg== Date: Tue, 24 May 2022 16:34:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, jgross@suse.com, Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, Luca Miccio , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: Re: [PATCH v7 6/7] tools: add example application to initialize dom0less PV drivers In-Reply-To: <6ef42026-8b14-c16f-175c-5b3d9ca55f99@xen.org> Message-ID: References: <20220513210730.679871-6-sstabellini@kernel.org> <6ef42026-8b14-c16f-175c-5b3d9ca55f99@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sat, 14 May 2022, Julien Grall wrote: > On 13/05/2022 22:07, Stefano Stabellini wrote: > > diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c > > new file mode 100644 > > index 0000000000..3e7ad54da7 > > --- /dev/null > > +++ b/tools/helpers/init-dom0less.c > > @@ -0,0 +1,345 @@ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "init-dom-json.h" > > + > > +#define XENSTORE_PFN_OFFSET 1 > > +#define STR_MAX_LENGTH 64 > > Sorry, I should have spotted this earlier. Looking at the nodes below, the > node control/platform-feature-multiprocessor-suspend would result to 63 > characters without even the domid: > > 42sh> echo -n '/local/domain//control/platform-feature-multiprocessor-suspend' > | wc -c > 62 > > So I think it would be wiser to bump the value to 128 here. > > > +static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, > > + domid_t domid, char *path, char *val) > > +{ > > + char full_path[STR_MAX_LENGTH]; > > + struct xs_permissions perms[2]; > > + > > + perms[0].id = domid; > > + perms[0].perms = XS_PERM_NONE; > > + perms[1].id = 0; > > + perms[1].perms = XS_PERM_READ; > > + > > + if (snprintf(full_path, STR_MAX_LENGTH, > > + "/local/domain/%u/%s", domid, path) < 0) > > The issue I mentionned above would not have been spotted because you only > check the value is negative. From glibc version 2.1, > snprintf() returns the number of character (excluding the NUL bytes) it would > have written if the buffer is big enough. > > So to avoid writing a truncated node, you will want to check the return value > is > 0 && < (STR_MAX_LENGTH - 1). > > Looking at the code below, there are a few wrong use of snprintf(). To avoid > another round (we are at v7 already), I would be OK if they are dealt after so > long we bump the size of the buffer. > > The rest of the code looks ok: > > Acked-by: Julien Grall Thank you that is very reasonable. I committed the series with STR_MAX_LENGTH set to 128. I'll send a separate patch to improve the snprintf checks. From xen-devel-bounces@lists.xenproject.org Tue May 24 23:35:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 23:35:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336776.561181 (Exim 4.92) (envelope-from ) id 1nte47-0001oq-9V; Tue, 24 May 2022 23:35:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336776.561181; Tue, 24 May 2022 23:35:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte47-0001oj-6q; Tue, 24 May 2022 23:35:51 +0000 Received: by outflank-mailman (input) for mailman id 336776; Tue, 24 May 2022 23:35:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte46-0001oZ-0u for xen-devel@lists.xenproject.org; Tue, 24 May 2022 23:35:50 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3db5dc0c-dbba-11ec-837f-e5687231ffcc; Wed, 25 May 2022 01:35:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41DD1B81A53; Tue, 24 May 2022 23:35:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 791B2C34100; Tue, 24 May 2022 23:35:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3db5dc0c-dbba-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653435347; bh=7DErTVC3Qto9OYEfJdEWlpFYnmp5DQk7O15Ux8KLGsc=; h=From:To:Cc:Subject:Date:From; b=iPe5TTySUUYnWKeqnBVwlzhjyMTOeFs/2VbEg62UaZ4Bx6Pm5EMHo5YC+TcuIWUEY nKsCLmlWj9JF7uMqgyIBI1sS83zeMEh3cNFSb5YsBJjgcMu5H+QUH7RWwsBI/T+cle mjwL9sjCZkGpLoxmBVoVO8Irf+j7fIsmeehVkFEd8osYo8QSZYkhy+NOF9pzdC4iHi HOmy1XQFlmLt1nWYrKcx52Hi9pjKQjZj7VIlI7V5d+jkk03iMpJSUMVOQvnoED1MV7 /pISwsVLE9F/vWHEzCSUa6gfTN/xFFfeP3K1TJ/5m9CAExOjWO2XMEWb1iuxIRp51p 1WG/PhFG6GFYA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, lucmiccio@gmail.com, anthony.perard@citrix.com, wl@xen.org, Stefano Stabellini Subject: [PATCH] init-dom0less: better snprintf checks Date: Tue, 24 May 2022 16:35:44 -0700 Message-Id: <20220524233544.245741-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini snprintf returns the number of characters printed. A return value of size or more means that the output was truncated. Add a check for that in init-dom0less. Signed-off-by: Stefano Stabellini --- tools/helpers/init-dom0less.c | 38 ++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index 42e74c4153..4c90dd6a0c 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -48,14 +48,16 @@ static bool do_xs_write_dom(struct xs_handle *xsh, xs_transaction_t t, { char full_path[STR_MAX_LENGTH]; struct xs_permissions perms[2]; + int rc; perms[0].id = domid; perms[0].perms = XS_PERM_NONE; perms[1].id = 0; perms[1].perms = XS_PERM_READ; - if (snprintf(full_path, STR_MAX_LENGTH, - "/local/domain/%u/%s", domid, path) < 0) + rc = snprintf(full_path, STR_MAX_LENGTH, + "/local/domain/%u/%s", domid, path); + if (rc < 0 || rc >= STR_MAX_LENGTH) return false; if (!xs_write(xsh, t, full_path, val, strlen(val))) return false; @@ -66,9 +68,11 @@ static bool do_xs_write_libxl(struct xs_handle *xsh, xs_transaction_t t, domid_t domid, char *path, char *val) { char full_path[STR_MAX_LENGTH]; + int rc; - if (snprintf(full_path, STR_MAX_LENGTH, - "/libxl/%u/%s", domid, path) < 0) + rc = snprintf(full_path, STR_MAX_LENGTH, + "/libxl/%u/%s", domid, path); + if (rc < 0 || rc >= STR_MAX_LENGTH) return false; return xs_write(xsh, t, full_path, val, strlen(val)); } @@ -77,9 +81,11 @@ static bool do_xs_write_vm(struct xs_handle *xsh, xs_transaction_t t, libxl_uuid uuid, char *path, char *val) { char full_path[STR_MAX_LENGTH]; + int rc; - if (snprintf(full_path, STR_MAX_LENGTH, - "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path) < 0) + rc = snprintf(full_path, STR_MAX_LENGTH, + "/vm/" LIBXL_UUID_FMT "/%s", LIBXL_UUID_BYTES(uuid), path); + if (rc < 0 || rc >= STR_MAX_LENGTH) return false; return xs_write(xsh, t, full_path, val, strlen(val)); } @@ -115,35 +121,35 @@ static int create_xenstore(struct xs_handle *xsh, return -errno; rc = snprintf(start_time_str, STR_MAX_LENGTH, "%jd.%02d", (intmax_t)start_time.tv_sec, (int)start_time.tv_usec / 10000); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; domid = info->domid; rc = snprintf(id_str, STR_MAX_LENGTH, "%u", domid); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(dom_name_str, STR_MAX_LENGTH, "dom0less-%u", domid); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(uuid_str, STR_MAX_LENGTH, LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(vm_val_str, STR_MAX_LENGTH, "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memkb); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->current_memkb); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", (GUEST_MAGIC_BASE >> XC_PAGE_SHIFT) + XENSTORE_PFN_OFFSET); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; rc = snprintf(xenstore_port_str, STR_MAX_LENGTH, "%u", xenstore_port); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) return rc; retry_transaction: @@ -163,7 +169,7 @@ retry_transaction: if (!do_xs_write_dom(xsh, t, domid, "cpu", "")) goto err; for (i = 0; i < info->vcpu_max_id; i++) { rc = snprintf(cpu_str, STR_MAX_LENGTH, "cpu/%u/availability/", i); - if (rc < 0) + if (rc < 0 || rc >= STR_MAX_LENGTH) goto err; rc = -EIO; if (!do_xs_write_dom(xsh, t, domid, cpu_str, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 24 23:41:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 24 May 2022 23:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336784.561192 (Exim 4.92) (envelope-from ) id 1nte9O-0003HC-TG; Tue, 24 May 2022 23:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336784.561192; Tue, 24 May 2022 23:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte9O-0003H5-QT; Tue, 24 May 2022 23:41:18 +0000 Received: by outflank-mailman (input) for mailman id 336784; Tue, 24 May 2022 23:41:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nte9O-0003Gz-0S for xen-devel@lists.xenproject.org; Tue, 24 May 2022 23:41:18 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 00c2014e-dbbb-11ec-837f-e5687231ffcc; Wed, 25 May 2022 01:41:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2ABF4B81A50; Tue, 24 May 2022 23:41:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C2EEC34100; Tue, 24 May 2022 23:41:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00c2014e-dbbb-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653435673; bh=+XlkY9Fk1WHUNFVByRCydMFytj1Rt3Snpl9APTbb2sM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Gtq/0YAIgsev6AEjR0XWT29sDwuf/6xvkMQoZNXv1U7NWqHsV8Qm59nRPn8x7khnP 2dzTZgG3ItyzV9S50+j6rPW5kM31/FtIoLLwcS0gLxJnlPpBfNURYzWO81C+wPWfR6 G07oFW+tSlHnfR04yWG820PvVbI+oEnzzjvEheOwLWnRLDvoK5dv2ZYkrYcyO3Bm57 ox4evRC9Q46QO7d/YN1Y/BdPFZMx2htTkclhEcbYQKE6r00n7F4TpbvHwzojGpdis5 AIksxkRvzmOtZjWEseM5B7WFqgod66hMoxr+ZkK6PAF0Z0eOnKQdNkzgdat0hvvfdd M7jFKV13FM12g== Date: Tue, 24 May 2022 16:41:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: Julien Grall , "xen-devel@lists.xenproject.org" , Michal Orzel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH] xen/arm: setup: nr_banks should be unsigned int In-Reply-To: Message-ID: References: <20220523194631.66262-1-julien@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-796825587-1653435673=:1905099" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-796825587-1653435673=:1905099 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 24 May 2022, Wei Chen wrote: > Hi Julien, > > > -----Original Message----- > > From: Xen-devel On Behalf Of > > Julien Grall > > Sent: 2022年5月24日 3:47 > > To: xen-devel@lists.xenproject.org > > Cc: Michal Orzel ; Julien Grall ; > > Stefano Stabellini ; Julien Grall ; > > Bertrand Marquis ; Volodymyr Babchuk > > > > Subject: [PATCH] xen/arm: setup: nr_banks should be unsigned int > > > > From: Julien Grall > > > > It is not possible to have a negative number of banks. So switch > > to unsigned int. > > > > The type change is also propagated to any users of nr_banks that > > were using "int" (there are not that many). > > > > Note that fdt_num_mem_rsv() can actually returns a negative value > > in case of an error. So the return should be checked before assigning > > the result to an unsigned variable. > > > > Signed-off-by: Julien Grall > > --- > > xen/arch/arm/domain_build.c | 9 +++++---- > > xen/arch/arm/efi/efi-dom0.c | 4 ++-- > > xen/arch/arm/include/asm/setup.h | 6 +++--- > > xen/arch/arm/setup.c | 17 +++++++++++++---- > > 4 files changed, 23 insertions(+), 13 deletions(-) > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index aa777741bdd0..6ecb6673a3cd 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -111,7 +111,8 @@ static bool __init insert_11_bank(struct domain *d, > > struct page_info *pg, > > unsigned int order) > > { > > - int res, i; > > + unsigned int i; > > + int res; > > mfn_t smfn; > > paddr_t start, size; > > > > @@ -264,7 +265,7 @@ static void __init allocate_memory_11(struct domain *d, > > const unsigned int min_order = get_order_from_bytes(MB(4)); > > struct page_info *pg; > > unsigned int order = get_allocation_size(kinfo->unassigned_mem); > > - int i; > > + unsigned int i; > > > > bool lowmem = true; > > unsigned int lowmem_bitsize = min(32U, arch_get_dma_bitsize()); > > @@ -1022,8 +1023,8 @@ static int __init make_memory_node(const struct > > domain *d, > > int addrcells, int sizecells, > > struct meminfo *mem) > > { > > - int res, i; > > - int reg_size = addrcells + sizecells; > > + unsigned int i; > > + int res, reg_size = addrcells + sizecells; > > int nr_cells = 0; > > /* Placeholder for memory@ + a 64-bit number + \0 */ > > char buf[24]; > > diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c > > index 494420eaa23e..aae0f979112a 100644 > > --- a/xen/arch/arm/efi/efi-dom0.c > > +++ b/xen/arch/arm/efi/efi-dom0.c > > @@ -34,14 +34,14 @@ > > /* Constant to indicate "Xen" in unicode u16 format */ > > static const CHAR16 xen_efi_fw_vendor[] = {0x0058, 0x0065, 0x006E, > > 0x0000}; > > > > -size_t __init estimate_efi_size(int mem_nr_banks) > > +size_t __init estimate_efi_size(unsigned int mem_nr_banks) > > { > > size_t size; > > size_t est_size = sizeof(EFI_SYSTEM_TABLE); > > size_t ect_size = sizeof(EFI_CONFIGURATION_TABLE); > > size_t emd_size = sizeof(EFI_MEMORY_DESCRIPTOR); > > size_t fw_vendor_size = sizeof(xen_efi_fw_vendor); > > - int acpi_mem_nr_banks = 0; > > + unsigned int acpi_mem_nr_banks = 0; > > > > if ( !acpi_disabled ) > > acpi_mem_nr_banks = bootinfo.acpi.nr_banks; > > diff --git a/xen/arch/arm/include/asm/setup.h > > b/xen/arch/arm/include/asm/setup.h > > index 7a1e1d67989c..2bb01ecfa88f 100644 > > --- a/xen/arch/arm/include/asm/setup.h > > +++ b/xen/arch/arm/include/asm/setup.h > > @@ -30,7 +30,7 @@ struct membank { > > }; > > > > struct meminfo { > > - int nr_banks; > > + unsigned int nr_banks; > > struct membank bank[NR_MEM_BANKS]; > > }; > > > > @@ -93,7 +93,7 @@ extern domid_t max_init_domid; > > > > void copy_from_paddr(void *dst, paddr_t paddr, unsigned long len); > > > > -size_t estimate_efi_size(int mem_nr_banks); > > +size_t estimate_efi_size(unsigned int mem_nr_banks); > > > > void acpi_create_efi_system_table(struct domain *d, > > struct membank tbl_add[]); > > @@ -109,7 +109,7 @@ void create_dom0(void); > > > > void discard_initial_modules(void); > > void fw_unreserved_regions(paddr_t s, paddr_t e, > > - void (*cb)(paddr_t, paddr_t), int first); > > + void (*cb)(paddr_t, paddr_t), unsigned int > > first); > > > > size_t boot_fdt_info(const void *fdt, paddr_t paddr); > > const char *boot_fdt_cmdline(const void *fdt); > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > > index db1768c03f03..b30bccbaa7df 100644 > > --- a/xen/arch/arm/setup.c > > +++ b/xen/arch/arm/setup.c > > @@ -201,9 +201,17 @@ static void __init processor_id(void) > > > > static void __init dt_unreserved_regions(paddr_t s, paddr_t e, > > void (*cb)(paddr_t, paddr_t), > > - int first) > > + unsigned int first) > > { > > - int i, nr = fdt_num_mem_rsv(device_tree_flattened); > > + unsigned int i, nr; > > + int rc; > > + > > + rc = fdt_num_mem_rsv(device_tree_flattened); > > + if ( rc < 0 ) > > + panic("Unable to retrieve the number of reserved regions > > (rc=%d)\n", > > + rc); > > + > > + nr = rc; > > > > for ( i = first; i < nr ; i++ ) > > { > > @@ -249,7 +257,8 @@ static void __init dt_unreserved_regions(paddr_t s, > > paddr_t e, > > } > > > > void __init fw_unreserved_regions(paddr_t s, paddr_t e, > > - void (*cb)(paddr_t, paddr_t), int first) > > + void (*cb)(paddr_t, paddr_t), > > + unsigned int first) > > { > > if ( acpi_disabled ) > > dt_unreserved_regions(s, e, cb, first); > > @@ -693,7 +702,7 @@ static void __init setup_mm(void) > > paddr_t ram_start, ram_end, ram_size, e; > > unsigned long ram_pages; > > unsigned long heap_pages, xenheap_pages, domheap_pages; > > - int i; > > + unsigned int i; > > const uint32_t ctr = READ_CP32(CTR); > > > > if ( !bootinfo.mem.nr_banks ) > > Reviewed-by: Wei Chen Acked-by: Stefano Stabellini and committed --8323329-796825587-1653435673=:1905099-- From xen-devel-bounces@lists.xenproject.org Wed May 25 00:35:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 00:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336794.561219 (Exim 4.92) (envelope-from ) id 1ntezY-0001f4-EW; Wed, 25 May 2022 00:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336794.561219; Wed, 25 May 2022 00:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezY-0001ex-Aw; Wed, 25 May 2022 00:35:12 +0000 Received: by outflank-mailman (input) for mailman id 336794; Wed, 25 May 2022 00:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezX-0001N9-Gh for xen-devel@lists.xenproject.org; Wed, 25 May 2022 00:35:11 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 889b80e3-dbc2-11ec-837f-e5687231ffcc; Wed, 25 May 2022 02:35:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CF817B81BBD; Wed, 25 May 2022 00:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7D1DC34100; Wed, 25 May 2022 00:35:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 889b80e3-dbc2-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653438908; bh=5xZ+kaGEO4k/xwRCqA5XePrkd+GNdWNbh3kA/sS07Qo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fVMx/qmcDeO5SD61bgr1oBWbp9f3tqdI/O1GT0MQWqmPDLJyMgq3gvAegR3lakIIa rvIcqCOnZuMyb2YtHRFyNdhGKPYXGcRTq4Zv0zgl0aH2L7szzYYjq1N+QzB7V2a/DZ ZJDhWyeDWv4qlsc4EnSoiEy07tIrhapgd2VVdni6C0dNBCE12+NMw8UJilVWmNR++o sMK/s9Gc1rSIuCtWY4X8OjZzoQfYjlKMDGduHIBTof/pdFdCmfTLU9dW6beZB8ujfG Z6cTDsYfQIwGM/7LfdCcCup6pELsRVl8HoH08d8HYRaskEaL7d/zcfb/AOTNzZQ5xA BkbDh+DK9btug== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , Bertrand Marquis Subject: [PATCH 1/2] docs/misra: introduce rules.rst Date: Tue, 24 May 2022 17:35:04 -0700 Message-Id: <20220525003505.304617-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Introduce a list of MISRA C rules that apply to the Xen hypervisor. The list is in RST format. Add a mention of the new list to CODING_STYLE. Signed-off-by: Bertrand Marquis Signed-off-by: Stefano Stabellini --- CODING_STYLE | 6 ++++ docs/misra/rules.rst | 65 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 docs/misra/rules.rst diff --git a/CODING_STYLE b/CODING_STYLE index 9f50d9cec4..1ef35ee8d0 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -235,3 +235,9 @@ callstack between the initial function call and the failure, no error is returned. Using domain_crash() requires careful inspection and documentation of the code to make sure all callers at the stack handle a newly-dead domain gracefully. + +MISRA C +------- + +The Xen Project hypervisor follows the MISRA C coding rules and +directives listed under docs/misra/rules.rst. diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst new file mode 100644 index 0000000000..c0ee58ab25 --- /dev/null +++ b/docs/misra/rules.rst @@ -0,0 +1,65 @@ +===================== +MISRA C rules for Xen +===================== + +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the +MISRA Consortium Limited and used with permission. + +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for +licensing options for other use of the rules. + +The following is the list of MISRA C rules that apply to the Xen Project +hypervisor. + +- Rule: Dir 2.1 + - Severity: Required + - Summary: All source files shall compile without any compilation errors + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c +- Rule: Dir 4.7 + - Severity: Required + - Summary: If a function returns error information then that error information shall be tested + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c +- Rule: Dir 4.10 + - Severity: Required + - Summary: Precautions shall be taken in order to prevent the contents of a header file being included more than once + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_10.c +- Rule: Dir 4.14 + - Severity: Required + - Summary: The validity of values received from external sources shall be checked + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_14.c +- Rule: Rule 1.3 + - Severity: Required + - Summary: There shall be no occurrence of undefined or critical unspecified behaviour + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_01_03.c +- Rule: Rule 3.2 + - Severity: Required + - Summary: Line-splicing shall not be used in // comments + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c +- Rule: Rule 6.2 + - Severity: Required + - Summary: Single-bit named bit fields shall not be of a signed type + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_02.c +- Rule: Rule 8.1 + - Severity: Required + - Summary: Types shall be explicitly specified + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_01.c +- Rule: Rule 8.4 + - Severity: Required + - Summary: A compatible declaration shall be visible when an object or function with external linkage is defined + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_04.c +- Rule: Rule 8.5 + - Severity: Required + - Summary: An external object or function shall be declared once in one and only one file + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_05_2.c +- Rule: Rule 8.6 + - Severity: Required + - Summary: An identifier with external linkage shall have exactly one external definition + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_06_2.c +- Rule: Rule 8.8 + - Severity: Required + - Summary: The static storage class specifier shall be used in all declarations of objects and functions that have internal linkage + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_08.c +- Rule: Rule 8.12 + - Severity: Required + - Summary: Within an enumerator list the value of an implicitly-specified enumeration constant shall be unique + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_12.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 25 00:35:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 00:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336795.561230 (Exim 4.92) (envelope-from ) id 1ntezZ-0001vY-S9; Wed, 25 May 2022 00:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336795.561230; Wed, 25 May 2022 00:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezZ-0001vR-Of; Wed, 25 May 2022 00:35:13 +0000 Received: by outflank-mailman (input) for mailman id 336795; Wed, 25 May 2022 00:35:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezY-0001N9-Gp for xen-devel@lists.xenproject.org; Wed, 25 May 2022 00:35:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88d94eac-dbc2-11ec-837f-e5687231ffcc; Wed, 25 May 2022 02:35:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6C75FB81BFC; Wed, 25 May 2022 00:35:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A360FC34118; Wed, 25 May 2022 00:35:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88d94eac-dbc2-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653438909; bh=sjKpMtPk4Pg6387GmnH2YJdsLfcRs7y+YGW+mPOUkgk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vJdcQN7MwlXt9tsknTo8xOee3y5rmdsilSBNvEh/0YyNXk8MxoG7nV56eEeSSXox/ 9MUswDFQC5tFX+p+/vQrwxjdMTny7VeNBmtY/gl6eLpJDNyndUAGgWq9U+2tIMIfd/ eEY24rinh9YJKSwWYQgo0EXVQrgfzKKmPa25gBlLNR1NkZILAgKa6xGgbrek1LfqF4 XJexjMv+QiAM9rPx3e19xqi72uMH+4pxC1AQkvATQ2cQ2yw+HomsalX8RInPLP+jm/ guj3CjZxOqCIOO809mpE30nJ8/if5mL6o/Wy1gmzfuPoElKenu0Aq0kMUMFJTPIp8r ZqEnwlYUzGz6g== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini Subject: [PATCH 2/2] docs/misra: add Rule 5.1 Date: Tue, 24 May 2022 17:35:05 -0700 Message-Id: <20220525003505.304617-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Add Rule 5.1, with the additional note that the character limit for Xen is 63 characters. The max length identifiers found by ECLAIR are: __mitigate_spectre_bhb_clear_insn_start domain_pause_by_systemcontroller_nosync Both of them are 40 characters long. A limit of 63 characters work for the existing code. Signed-off-by: Stefano Stabellini --- docs/misra/rules.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index c0ee58ab25..6052fc6309 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -35,6 +35,11 @@ hypervisor. - Severity: Required - Summary: Line-splicing shall not be used in // comments - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c +- Rule: Rule 5.1 + - Severity: Required + - Summary: External identifiers shall be distinct + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_05_01_2.c + - Note: the Xen characters limit for identifiers is 63 - Rule: Rule 6.2 - Severity: Required - Summary: Single-bit named bit fields shall not be of a signed type -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed May 25 00:35:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 00:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336793.561208 (Exim 4.92) (envelope-from ) id 1ntezO-0001NR-5v; Wed, 25 May 2022 00:35:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336793.561208; Wed, 25 May 2022 00:35:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezO-0001NK-1O; Wed, 25 May 2022 00:35:02 +0000 Received: by outflank-mailman (input) for mailman id 336793; Wed, 25 May 2022 00:35:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntezM-0001N9-7z for xen-devel@lists.xenproject.org; Wed, 25 May 2022 00:35:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8071f897-dbc2-11ec-837f-e5687231ffcc; Wed, 25 May 2022 02:34:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FF5A615B1; Wed, 25 May 2022 00:34:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0238CC34100; Wed, 25 May 2022 00:34:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8071f897-dbc2-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653438895; bh=z6rZJmg35HTbcLY6xC8GV/XUKS+KBk9uUWKRQMRZZoU=; h=Date:From:To:cc:Subject:From; b=k3AEw6UojlF+K/aq3V079hAIDieSNXTyOcxC0ycuCTDSLGGVSYhvcXPEP+f2yqNMP +tl8IT7+9nrf5zhUbWPlLQXP/SEBdR3phdwxPUFferIX6uT98cfkJVC6qVVdz7bUJP /T5k01u589lgUdcaAMdq3xpDMlHxqf6B+J+XEm81Axe3nitQZYh8gCFduA13kGUpvO nd6p2fHMhY2z0ll53sXK0pKe/SUMN4ZaNGOT8NLVWOfHaQXKtNWonyPJozfYZUo4uA OCMdC+YgUj41ErTt2D53xk8wgfZFq+CTMCKDUYPO2qaft7kNOFTTCgXe9UZ1T88eV6 kHvfdSiR+3yjA== Date: Tue, 24 May 2022 17:34:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com Subject: [PATCH 0/2] introduce docs/misra/rules.rst Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This patch series is a follow-up from the MISRA C meeting last Thursday, when we went through the list of MISRA C rules on the spreadsheet and agreed to accept into the Xen coding style the first ones, starting from Dir 2.1 up until Rule 5.1 (except for Rule 2.2) in descending popularity order. This is the full list of accepted rules so far: Dir 2.1 Dir 4.7 Dir 4.10 Dir 4.14 Rule 1.3 Rule 3.2 Rule 5.1 Rule 6.2 Rule 8.1 Rule 8.4 Rule 8.5 Rule 8.6 Rule 8.8 Rule 8.12 This short patch series add them as a new document under docs/misra as a list in rst format. The file can be used as input to cppcheck using a small python script from Bertrand (who will send it to the xen-devel separately.) Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Wed May 25 03:46:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 03:46:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336820.561241 (Exim 4.92) (envelope-from ) id 1nthyZ-0003kO-LJ; Wed, 25 May 2022 03:46:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336820.561241; Wed, 25 May 2022 03:46:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nthyZ-0003kH-IK; Wed, 25 May 2022 03:46:23 +0000 Received: by outflank-mailman (input) for mailman id 336820; Wed, 25 May 2022 03:46:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nthyY-0003k7-UQ; Wed, 25 May 2022 03:46:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nthyY-0006Sc-Sa; Wed, 25 May 2022 03:46:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nthyY-0002gL-D0; Wed, 25 May 2022 03:46:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nthyY-0000uB-CW; Wed, 25 May 2022 03:46:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JlGQsiZ298vhyXNiWhDqdHR980bYWcd6kWqLEDOZygE=; b=lvMuyvAdRRIxvUe7J5jpb9ba0N 8rnirHrM7yZYdKYj6+eMFylBbbGQOG1ItGV/NGGfTTXCsTPsgmgVwpEPL4v3UBp53yFSSw+KXW0iO Jrq5KOCKl7weseyEkYn8weq7dHoB8OFlUQrjV0pCV6SLzcNgKOYgD+YWxevvimC4Qfsc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170719: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49399b101e38fb2c11478c849ffdaaace8e318a8 X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Wed, 25 May 2022 03:46:22 +0000 flight 170719 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170719/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 49399b101e38fb2c11478c849ffdaaace8e318a8 baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170599 2022-05-20 11:00:25 Z 4 days Testing same since 170719 2022-05-25 00:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Luca Miccio Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ec0cce125b..49399b101e 49399b101e38fb2c11478c849ffdaaace8e318a8 -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 25 04:42:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 04:42:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336730.561252 (Exim 4.92) (envelope-from ) id 1ntiqi-00021E-T1; Wed, 25 May 2022 04:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336730.561252; Wed, 25 May 2022 04:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntiqi-000217-Pv; Wed, 25 May 2022 04:42:20 +0000 Received: by outflank-mailman (input) for mailman id 336730; Tue, 24 May 2022 18:34:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntZMk-0002kb-Dt for xen-devel@lists.xenproject.org; Tue, 24 May 2022 18:34:46 +0000 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [2607:f8b0:4864:20::1135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e6c81c7-db90-11ec-bd2c-47488cf2e6aa; Tue, 24 May 2022 20:34:44 +0200 (CEST) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-2ff7b90e635so125488907b3.5 for ; Tue, 24 May 2022 11:34:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e6c81c7-db90-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iBrJdmkYhyMKFfjatCCnMuBZLCB3cSo3begeOpY/XW0=; b=jQIgotbIxIKwjqP3Ytx/1zmEQiJy3GUwR7pfzJzuQ/KNfOg9PR/sWrGJ023UbG/uEJ 0xHi7ypEjCWhSd1ukgWYWGlnvThWteDRtlCWJv6EwBcHPCHUF0gN51dFNaneKpRvLncC LAXz+ixBiY8+lJSiou2TBEtzqWwsF+sdxbMw+SGtJlzI8mpNUayyZg+RK+H05IOmfbpr 18EPXakonYulEUB0y9ZdDRRUGcB2xuPIMwPd4c762ozCaW8xPw7dAv4F22pjDNoljNGN kz24YuRjs0EGn0LFKcaoPpxJnGG7K4Vf26j6JMQgIaOaoESDRviYMUu9J5qo74/Woa/W MWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iBrJdmkYhyMKFfjatCCnMuBZLCB3cSo3begeOpY/XW0=; b=u2bfiP5Wsj1p0W+4NcVtPdoRL7UZDZ1Vlsr0uAZ9HC6zE2+3EgEidiGpYuwJr/+LxR Qv4EK1Q/IhVAZIj2ExjWVM+Z7MlQOU1+6O2u0+a9NGbq2TXGfvbXWEKOw2Cy3T/lF7AI NeVDA66AEU1DeO0dhTHVlc+f8TvjnASGNsnyzA6ETjf++M88gBudEpbZZqXw2HQCiOe0 aGsgmMsvs9ADIhWiKw7rlY09gnjFUOIx1KhTsmfMyitCbO79ysdY6mvODOOiDahQj+D2 b1C6cPjpfkhe6fQFw79lndXVPRaHhkvg8YLDVnPyrTiSwTPeiuiCNhiz3y2vb+wtbnXE 79og== X-Gm-Message-State: AOAM532eQXdceagtgvh/6G++48nc2ZGhDW3Hl7jmBiV+B9l/FOY7RFhG +DIeDzHeEm6qfKTpH3r3kNihjZAGjePDcvDz57phoA== X-Google-Smtp-Source: ABdhPJyY/JYhlZXxoEKO5HYVCNG5z/yk9AUUyQrAuiHIkRvGXWuoudF873m2e4tA4dlfQtDUZsLjJfE9Xq/pklwwrWc= X-Received: by 2002:a81:72c5:0:b0:300:7d0:a642 with SMTP id n188-20020a8172c5000000b0030007d0a642mr8927907ywc.80.1653417283496; Tue, 24 May 2022 11:34:43 -0700 (PDT) MIME-Version: 1.0 References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> <20220524160134.GE3730540-robh@kernel.org> In-Reply-To: <20220524160134.GE3730540-robh@kernel.org> From: Saravana Kannan Date: Tue, 24 May 2022 11:34:07 -0700 Message-ID: Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Rob Herring Cc: Stefano Stabellini , Oleksandr , xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable " On Tue, May 24, 2022 at 9:01 AM Rob Herring wrote: > > +Saravana > > On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: > > On Mon, 23 May 2022, Oleksandr wrote: > > > > > On Thu, 19 May 2022, Oleksandr wrote: > > > > > > > On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: > > > > > > > > On 18.05.22 17:32, Arnd Bergmann wrote: > > > > > > > > > On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko > > > > > > > > > wrote: > > > > > > > > > This would mean having a device > > > > > > > > > node for the grant-table mechanism that can be referred t= o using > > > > > > > > > the > > > > > > > > > 'iommus' > > > > > > > > > phandle property, with the domid as an additional argumen= t. > > > > > > > > I assume, you are speaking about something like the followi= ng? > > > > > > > > > > > > > > > > > > > > > > > > xen_dummy_iommu { > > > > > > > > compatible =3D "xen,dummy-iommu"; > > > > > > > > #iommu-cells =3D <1>; > > > > > > > > }; > > > > > > > > > > > > > > > > virtio@3000 { > > > > > > > > compatible =3D "virtio,mmio"; > > > > > > > > reg =3D <0x3000 0x100>; > > > > > > > > interrupts =3D <41>; > > > > > > > > > > > > > > > > /* The device is located in Xen domain with ID 1 */ > > > > > > > > iommus =3D <&xen_dummy_iommu 1>; > > > > > > > > }; > > > > > > > Right, that's that's the idea, > > > > > > thank you for the confirmation > > > > > > > > > > > > > > > > > > > > > > > > > except I would not call it a 'dummy'. > > > > > > > From the perspective of the DT, this behaves just like an I= OMMU, > > > > > > > even if the exact mechanism is different from most hardware I= OMMU > > > > > > > implementations. > > > > > > well, agree > > > > > > > > > > > > > > > > > > > > > It does not quite fit the model that Linux currently uses= for > > > > > > > > > iommus, > > > > > > > > > as that has an allocator for dma_addr_t space > > > > > > > > yes (# 3/7 adds grant-table based allocator) > > > > > > > > > > > > > > > > > > > > > > > > > , but it would think it's > > > > > > > > > conceptually close enough that it makes sense for the bin= ding. > > > > > > > > Interesting idea. I am wondering, do we need an extra actio= ns for > > > > > > > > this > > > > > > > > to work in Linux guest (dummy IOMMU driver, etc)? > > > > > > > It depends on how closely the guest implementation can be mad= e to > > > > > > > resemble a normal iommu. If you do allocate dma_addr_t addres= ses, > > > > > > > it may actually be close enough that you can just turn the gr= ant-table > > > > > > > code into a normal iommu driver and change nothing else. > > > > > > Unfortunately, I failed to find a way how use grant references = at the > > > > > > iommu_ops level (I mean to fully pretend that we are an IOMMU d= river). I > > > > > > am > > > > > > not too familiar with that, so what is written below might be w= rong or > > > > > > at > > > > > > least not precise. > > > > > > > > > > > > The normal IOMMU driver in Linux doesn=E2=80=99t allocate DMA a= ddresses by > > > > > > itself, it > > > > > > just maps (IOVA-PA) what was requested to be mapped by the uppe= r layer. > > > > > > The > > > > > > DMA address allocation is done by the upper layer (DMA-IOMMU wh= ich is > > > > > > the glue > > > > > > layer between DMA API and IOMMU API allocates IOVA for PA?). Bu= t, all > > > > > > what we > > > > > > need here is just to allocate our specific grant-table based DM= A > > > > > > addresses > > > > > > (DMA address =3D grant reference + offset in the page), so let= =E2=80=99s say we > > > > > > need an > > > > > > entity to take a physical address as parameter and return a DMA= address > > > > > > (what > > > > > > actually commit #3/7 is doing), and that=E2=80=99s all. So work= ing at the > > > > > > dma_ops > > > > > > layer we get exactly what we need, with the minimal changes to = guest > > > > > > infrastructure. In our case the Xen itself acts as an IOMMU. > > > > > > > > > > > > Assuming that we want to reuse the IOMMU infrastructure somehow= for our > > > > > > needs. > > > > > > I think, in that case we will likely need to introduce a new sp= ecific > > > > > > IOVA > > > > > > allocator (alongside with a generic one) to be hooked up by the > > > > > > DMA-IOMMU > > > > > > layer if we run on top of Xen. But, even having the specific IO= VA > > > > > > allocator to > > > > > > return what we indeed need (DMA address =3D grant reference + o= ffset in > > > > > > the > > > > > > page) we will still need the specific minimal required IOMMU dr= iver to > > > > > > be > > > > > > present in the system anyway in order to track the mappings(?) = and do > > > > > > nothing > > > > > > with them, returning a success (this specific IOMMU driver shou= ld have > > > > > > all > > > > > > mandatory callbacks implemented). > > > > > > > > > > > > I completely agree, it would be really nice to reuse generic IO= MMU > > > > > > bindings > > > > > > rather than introducing Xen specific property if what we are tr= ying to > > > > > > implement in current patch series fits in the usage of "iommus"= in Linux > > > > > > more-less. But, if we will have to add more complexity/more com= ponents > > > > > > to the > > > > > > code for the sake of reusing device tree binding, this raises a= question > > > > > > whether that=E2=80=99s worthwhile. > > > > > > > > > > > > Or I really missed something? > > > > > I think Arnd was primarily suggesting to reuse the IOMMU Device T= ree > > > > > bindings, not necessarily the IOMMU drivers framework in Linux (a= lthough > > > > > that would be an added bonus.) > > > > > > > > > > I know from previous discussions with you that making the grant t= able > > > > > fit in the existing IOMMU drivers model is difficult, but just re= using > > > > > the Device Tree bindings seems feasible? > > > > > > > > I started experimenting with that. As wrote in a separate email, I = got a > > > > deferred probe timeout, > > > > > > > > after inserting required nodes into guest device tree, which seems = to be a > > > > consequence of the unavailability of IOMMU, I will continue to inve= stigate > > > > this question. > > > > > > > > > I have experimented with that. Yes, just reusing the Device Tree bind= ings is > > > technically feasible (and we are able to do this by only touching > > > grant-dma-ops.c), although deferred probe timeout still stands (as th= ere is no > > > IOMMU driver being present actually). > > > > > > [ 0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ig= noring > > > dependency > > > [ 0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blo= cks (2.10 > > > GB/1.95 GiB) > > > > > > > > > Below the working diff (on top of current series): > > > > > > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.= c > > > index da9c7ff..6586152 100644 > > > --- a/drivers/xen/grant-dma-ops.c > > > +++ b/drivers/xen/grant-dma-ops.c > > > @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_o= ps =3D { > > > > > > bool xen_is_grant_dma_device(struct device *dev) > > > { > > > + struct device_node *iommu_np; > > > + bool has_iommu; > > > + > > > /* XXX Handle only DT devices for now */ > > > if (!dev->of_node) > > > return false; > > > > > > - return of_property_read_bool(dev->of_node, "xen,backend-domid= "); > > > + iommu_np =3D of_parse_phandle(dev->of_node, "iommus", 0); > > > + has_iommu =3D iommu_np && of_device_is_compatible(iommu_np, > > > "xen,grant-dma"); > > > + of_node_put(iommu_np); > > > + > > > + return has_iommu; > > > } > > > > > > void xen_grant_setup_dma_ops(struct device *dev) > > > { > > > struct xen_grant_dma_data *data; > > > - uint32_t domid; > > > + struct of_phandle_args iommu_spec; > > > > > > data =3D find_xen_grant_dma_data(dev); > > > if (data) { > > > @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev= ) > > > if (!dev->of_node) > > > goto err; > > > > > > - if (of_property_read_u32(dev->of_node, "xen,backend-domid", &= domid)) { > > > - dev_err(dev, "xen,backend-domid property is not prese= nt\n"); > > > + if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iomm= u-cells", > > > + 0, &iommu_spec)) { > > > + dev_err(dev, "Cannot parse iommus property\n"); > > > + goto err; > > > + } > > > + > > > + if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") = || > > > + iommu_spec.args_count !=3D 1) { > > > + dev_err(dev, "Incompatible IOMMU node\n"); > > > + of_node_put(iommu_spec.np); > > > goto err; > > > } > > > > > > + of_node_put(iommu_spec.np); > > > + > > > data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > > > if (!data) > > > goto err; > > > > > > - data->backend_domid =3D domid; > > > + /* > > > + * The endpoint ID here means the ID of the domain where the > > > corresponding > > > + * backend is running > > > + */ > > > + data->backend_domid =3D iommu_spec.args[0]; > > > > > > if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)de= v, data, > > > GFP_KERNEL))) { > > > (END) > > > > > > > > > > > > Below, the nodes generated by Xen toolstack: > > > > > > xen_grant_dma { > > Nit: iommu { > > > > compatible =3D "xen,grant-dma"; > > > #iommu-cells =3D <0x01>; > > > phandle =3D <0xfde9>; > > > }; > > > > > > virtio@2000000 { > > > compatible =3D "virtio,mmio"; > > > reg =3D <0x00 0x2000000 0x00 0x200>; > > > interrupts =3D <0x00 0x01 0xf01>; > > > interrupt-parent =3D <0xfde8>; > > > dma-coherent; > > > iommus =3D <0xfde9 0x01>; > > > }; > > > > Not bad! I like it. > > > > > > > I am wondering, would be the proper solution to eliminate deferred pr= obe > > > timeout issue in our particular case (without introducing an extra IO= MMU > > > driver)? > > > > In reality I don't think there is a way to do that. I would create an > > empty skelethon IOMMU driver for xen,grant-dma. > > Does it have to be an empty driver? Originally, IOMMU 'drivers' were not > drivers, but they've been getting converted. Can that be done here? > > Short of that, I think we could have some sort of skip probe list for > deferred probe. Not sure if that would be easiest as IOMMU specific or > global. Hi Oleksandr, If you do fw_devlink.strict=3D1, you'll notice that the consumers of this "iommu" won't probe at all or will delay the boot by some number of seconds. The eventual goal is to go towards fw_devlink.strict=3D1 being the default. >From a fw_devlik perspective, please implement a driver. Ideally a real one, but at least an empty one. The empty one doesn't need to be an IOMMU driver, but at least just do a return 0 in the probe function. Also, if it's not a device, why even have a "compatible" property (removing it won't necessarily remove the deferred probe timeout issue you see)? Will any code be using "xen,grant-dma" to look up the node? If so, that driver could be the one that probes this device. At least from a fw_devlink perspective, it just needs to have a driver that binds to this device. Also, if we aren't going to implement a driver and have the supplier ("xen,grant-dma") behave like a device (as in, have a driver that probes), I'd rather that the iommu binding not be used at all as this would be an exception to how every other iommu device behaves. -Saravana From xen-devel-bounces@lists.xenproject.org Wed May 25 05:33:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 05:33:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336840.561263 (Exim 4.92) (envelope-from ) id 1ntjeQ-0007u8-S1; Wed, 25 May 2022 05:33:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336840.561263; Wed, 25 May 2022 05:33:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntjeQ-0007u1-Ou; Wed, 25 May 2022 05:33:42 +0000 Received: by outflank-mailman (input) for mailman id 336840; Wed, 25 May 2022 05:33:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntjeP-0007tr-5M; Wed, 25 May 2022 05:33:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntjeP-0000KJ-2a; Wed, 25 May 2022 05:33:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntjeO-0001sj-Ji; Wed, 25 May 2022 05:33:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntjeO-00010Z-J6; Wed, 25 May 2022 05:33:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bBNVKI8qnzTl+4PeXbCeOjb/Vr2JvKzl9aMF2rvdGwU=; b=f0aIqNx2BZmO2pcfStdnGDyE5X pQeUH2hF+oy48B9/eAnYQ5FfGVCMEDD7O2LPLyfEhA3AUs/mxxes2say7NRHXi2QnIZnCIKzl2SQA fotVZsajbmL8Blmqv6vdj7ltkDVioDLHmK7Hxd6WPookhY2nnymfyxYo1LKhaE1m1K7c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170718: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=0350785b0a092c99c5ddd2ace0260dbe7b3f919f X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Wed, 25 May 2022 05:33:40 +0000 flight 170718 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170718/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 0350785b0a092c99c5ddd2ace0260dbe7b3f919f baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 1 days Failing since 170716 2022-05-24 11:12:06 Z 0 days 3 attempts Testing same since 170718 2022-05-24 22:12:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Aditya Garg Ahmad Fatoum Alexander Egorenkov Alexander Gordeev Alexandre Belloni Alexandru Elisei Andre Przywara Andreas Rammhold Anshuman Khandual Ard Biesheuvel Baolin Wang Baoquan He Barry Song Bill Wendling Borislav Petkov Casey Schaufler Catalin Marinas Chen Zhongjin Chen Zhou Chengming Zhou Christian Göttsche Christoph Hellwig Colin Ian King Dan Carpenter Daniel Beer Daniel Lezcano Daniel Thompson Darryn Anton Jordan Dave Hansen Dave Kleikamp David Arcari David E. Box David Sterba David Yang Deyan Wang Dietmar Eggemann Dinh Nguyen Dmitry Vyukov Eric Biggers Eric W. Biederman Frank Crawford Frederic Weisbecker Gabriele Mazzotta Geert Uytterhoeven Geert Uytterhoeven Greg Kroah-Hartman Greg Ungerer Guilherme G. Piccoli Guo Ren Guo Ren Guo Zhengkui GUO Zihua Hailong Liu Haitao Huang Hans de Goede Hao Jia Haowen Bai Harald Freudenberger Hector Martin Heikki Krogerus Heiko Carstens Helge Deller Hyeonggon Yoo <42.hyeyoo@gmail.com> Ilkka Koskinen Ilya Leoshkevich Ingo Molnar Jakob Koschel Jakub Kicinski Jann Horn Jarkko Sakkinen Jason A. Donenfeld Jason Wang Jens Axboe Jes B. Klinke Jithu Joseph Johannes Berg Johannes Holland Johannes Weiner John Donnelly John Ernberg # iMX8QXP John Johansen Jorge Lopez Josh Poimboeuf Josh Poimboeuf Juerg Haefliger Juerg Haefliger Juergen Gross Julia Lawall Kan Liang Kees Cook Kefeng Wang Kuniyuki Iwashima Laurent Vivier Linu Cherian Linus Torvalds Linus Walleij Luca Miccio Luca Stefani Maciej W. Rozycki Madhavan T. Venkataraman Marc Zyngier Marco Elver Marek Szyprowski Mario Limonciello Mark Brown Mark Pearson Mark Pearson Mark Rutland Masahiro Yamada Matt Turner Matteo Croce Matthew Wilcox (Oracle) Matthias Schiffer Max Filippov Maximilian Heyne Maximilian Luz Michael Ellerman Michael Niewöhner Michael Schmitz Michael Shych Michael Walle Michael Walle # on ls1028a (non-E and E) Michal Orzel Michal Orzel Mickaël Salaün Mickaël Salaün Mikulas Patocka Mimi Zohar Minghao Chi Namhyung Kim Naresh Kamboju Nathan Chancellor Naveen Krishna Chatradhi Nick Desaulniers Nick Hawkins Niklas Cassel Niklas Schnelle Oleksandr Tyshchenko # Arm64 only Pali Rohár Palmer Dabbelt Pankaj Gupta Patrice Chotard Paul Gortmaker Paul Moore Peter Collingbourne Peter Oberparleiter Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek # for vsprintf.c Pingfan Liu Prarit Bhargava Qais Yousef Qi Liu Randy Dunlap Ravi Bangoria Reinette Chatre Ren Yu Ren Zhijie Rob Herring Robin Murphy Roger Pau Monné Russell King (Oracle) Sami Tolvanen Sandipan Das Sargun Dhillon Sebastian Andrzej Siewior SeongJae Park Shaokun Zhang Srinivas Pandruvada Stafford Horne Stefan Berger Stefan Mahnke-Hartmann Stefano Stabellini Steffen Trumtrar Stephane Eranian Stephen Brennan Steven Rostedt (Google) Suma Hegde Sumanth Korikkar Sumit Garg Suren Baghdasaryan Sven Schnelle Tanmay Jagdale Tao Zhou Tetsuo Handa Theodore Ts'o Thomas Bogendoerfer Thomas Gleixner Thomas Huth Thomas Richter Thomas Weißschuh Tiezhu Yang Tim Harvey Tom Rix Tong Tiangen Tony Luck Tycho Andersen Uros Bizjak Uwe Kleine-König Valentin Schneider Valentin Schneider Vasily Gorbik Vladimir Murzin # ARM Waiman Long Wan Jiabing Wang Kefeng Will Deacon Will Deacon # arm64 Xiu Jianfeng Yang Guang Yang Jihong Yang Li Yi Yang Yuanzheng Song zgpeng zgpeng Zhang Jianhua Zhen Lei Zucheng Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 14800 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 25 06:02:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 06:02:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336851.561273 (Exim 4.92) (envelope-from ) id 1ntk6G-0002uN-92; Wed, 25 May 2022 06:02:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336851.561273; Wed, 25 May 2022 06:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntk6G-0002uG-6K; Wed, 25 May 2022 06:02:28 +0000 Received: by outflank-mailman (input) for mailman id 336851; Wed, 25 May 2022 06:02:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntk6E-0002uA-W6 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 06:02:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f1c13be-dbf0-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 08:02:25 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-G-nqwHc-PWK6X0ThgCLLKA-1; Wed, 25 May 2022 08:02:20 +0200 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB8753.eurprd04.prod.outlook.com (2603:10a6:20b:42c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 06:02:19 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e%7]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:02:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f1c13be-dbf0-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653458543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OgoLh87IBEZhZUbyi+RYO04yA9DwelZVbh0liG4/7iE=; b=BPDD+IvVM+lcT2dawguYit8Yt5AYCBJyjc2b8LidaNMawSDoN0kuwQ6uvMr6C3ucgAYRc0 jyArw42BhpZ6MOWKoCilTYxKkpTYsE3zx/hDZl+ygEAdQSxRysOzYznXY3dbO/K3Lah6bX QlSJBchvNVxPiX4DhU1vxB5Iu+D2fos= X-MC-Unique: G-nqwHc-PWK6X0ThgCLLKA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwdeRwGzelQTLbPJwRdSPhXibcC9afsCUKUtbn16DsflQxSyvD/hgzxe8b788gWR7m/s68iDuC7vgm/TmIsZD1hZxK1qT1aJ9nsemZrCGH5S4CPAPcfhSzqqW0IJAkKiDF6IdHqIgqQklobOM2EyhRbQnRe/8TzzA6qukjtYRZ0c1alNEC5TA7EscV4esIFX+n09ARkE02v7lc0+zo24ULy0mmhAWgI5Wzdf6u94hClv3hPL+YprN6CN4sjd2XSZkXluJOn9xJ4OdNn8NzlHgv7NKrNTeArtj7qNJStQS2C09faDC7xZUciM8SJFWOSqOnAArYhUruBre2ylrq+oJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Noj3KK3nSzUgBcc6nC9rQgxRTm0VWrtL+J8ZkvoFO9c=; b=efnXhtMwMC/C8cR90KC+meb9cynYGWGG7LiAC73wBWlu+JNWqdM2INhgzXIi8ouA5g/O/tlg9e9NWMdY1MrwhCls/wqFiii6svobEypwEx3Wpf3ptxr1pcqLpmZ3kSx7tP61xBq4T8H4eygZ7deUkoEuEfT8ZOOplExG2ZD0KsZv/CsTXoLDBagwmDLw5bc55fpw2oox6ai9QFIMnt/EF5fYAqZ0TwTqbNJGFrdYS3xBzjB4vy3F9jBBW/MLQDzFjyYCC0oSbECubjCJnsPuJcDD8NjOESEfrFEN+LjAVT2ih298vT8F7E5SmoKGRS3qHVTHzKwTiVgMzCaG2p95bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 08:02:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P192CA0024.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::37) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7aa51d5-1194-48f9-c258-08da3e142085 X-MS-TrafficTypeDiagnostic: AS8PR04MB8753:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /bSoIsXfkkhZL4tvBMLpiP911wYATIiRN2NpbsWz6DWdezDkfedJ3ZVI2hdWRIwdVm5DhUnM3jUDK74syJusMSVXkr0enDDWTmTEHKNXRGh4E566IhoVaAVlj7/04gjg51+ZkT4RaAZeOTH1Qyac5ZfxwhInHdPdKStYTBNDOFV76gaqceMl2u06vtCpS+yT6sSJ2XUNreFnaX2oKsg0C4dKBnwYtIBOd1blzZx7KRW1bCIyWT3OAppORzPmAvf729dTLPuWPgcr2K8OdVZEV9pTmpacPJZDzjkKaZeBvOHw+LZ/0l6D0VyU2JFoMlAm1NMmXjvtAorYjbB87S//lWetaVFbMtBj366XOv9jRy6mgGjXH9ObkkSoIAiykQWBm3jlIpaJUOdaeUjNr0un6YWGTyw8z8hO2xrL44US7wODhz9/6JJjpm6bxSLmz6ZYztdzau5yrxlkSkNgJmx8h9/4gczVM4KZcyyZptD7n4akXPvYhXgrSTzCJEPMjuUr4+FoLlvpoA+KTVnZez0nB/eqZQKLLpDsyUK7h/ybTYHMfwZTgbAXHpe2odfO9vtcjsckg8r8yQbiLolMnw8f7YuXoHcQDuv/dvA5gXdubv9f+TTVnYdxYuWJNGiFELmAcSbw1ArAk5O8u5FansCKYRA7+/rQwhRo1eg11Q4FN4kNWTvnO+6NvsDOt+eRACeAec/QcY1X7oyCMX+LcqdI9VvEcDarvQEK3cigfesxJwI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(8936002)(31686004)(31696002)(316002)(4326008)(66476007)(66556008)(2906002)(38100700002)(186003)(5660300002)(8676002)(36756003)(6486002)(66946007)(83380400001)(508600001)(6506007)(2616005)(6512007)(53546011)(26005)(54906003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZHrcg5Kjv0Yb1lkOEHyE5eXWs/XsyI7U/ivtF9rKP7VBxdDGYav7EzorKhWU?= =?us-ascii?Q?58LbeFCF9y8kO+OavidZhnTcYkzdVI+7KgNMKFDa9b/RzKcBLx2mhj5Apu8n?= =?us-ascii?Q?jqhacViEPUZSKnD8vDwgpSxdFyM9mlOfDzDPLw42HBsGS+xMOiyTtt+9sXVp?= =?us-ascii?Q?/HwSYnBDp+HbtXXxq8BR0d5G1k02LrTteAuKZtjcDEMaFEo/2E/j3FHdTfbV?= =?us-ascii?Q?/S6BB/nM4Mwe+IAK9kwB3tg0+mYvkjulTrMPYMaPonOfrarvSpkKmdYxUuCR?= =?us-ascii?Q?e9pP/DpWX17gd9W/9+gUiZXdujczuCWG2sw8hT1hr1UVg0ifs6w9OhgfFc3B?= =?us-ascii?Q?lULQqrmivDz3dHRjBny1YGiLKBwfbJ0Ad5un9t/xodh1QmrsJGWLmN+LMFsN?= =?us-ascii?Q?tjGkMEY923j7aqPbrOO1ZTURxpq5yngkwM1cYNmb9bU8qkp8B3dRE5ko9IhZ?= =?us-ascii?Q?IFAtHSSDRCyTUk6P/BE8jS4BG1VW6dVLZNTazvyx1VbHU6V2FRzsnPZbKEXj?= =?us-ascii?Q?vtATWLfZg1huz/cZf3gi7WcbmowW5S4VA+rdjFRvChCSLLXFN4MNlOAv96pC?= =?us-ascii?Q?ZuM/40mPBp4ZZsgPdlCFns3Xu3y58c0QeTg4lC4Pk7z0rHwMpYU4fDto97Fb?= =?us-ascii?Q?vuZ9QscsTXF3fMaUAA3L4OD8mRO8p1BgFwYFtHSrr+vbLN2F0rMhiP0p2M7u?= =?us-ascii?Q?NpDXC0X0Ruq4C33qni2U9FvNCaAj7pzJdVUs45Jkzj4Afv4t9T0mi1HdiD0N?= =?us-ascii?Q?/NBP7FCE8tW/FJ74Tnk8TewDjhImWbxiPz93lrJ1w5scdWPhfQALZTidgFZI?= =?us-ascii?Q?6kDm5bo6nE9vJV521fFfgsiG80hPLA84BY/5DG8UzIfviyB/kKwfzlWNyIL/?= =?us-ascii?Q?+V+jo81mypsqlT1cF8Y3abQjuvFmLfWUfBYhUwDHQuazu7n0J1K05i7rJAec?= =?us-ascii?Q?0/JNEzSHMGYrhnvNKilM9kVQQNKNSQemqZuf77207Ty8Lgq+5ZeTciQ1wYca?= =?us-ascii?Q?/wurDhDyq/O/N4jK7Vz8S3DLAhPYx8R295mwA038TChl/pGGZIbSFtCHZz9o?= =?us-ascii?Q?OJIiurxN0/kpO+34AqTWUkgUANjhqWBIGE5PflpYvKUYw7phJB/5WNVEgcer?= =?us-ascii?Q?kEBJ2UAAQv6lbw/5Zzc+W5mXYoRZY1/+f3ON7UbPGVO4clGMJKXz26NPVPpr?= =?us-ascii?Q?aoyi0v+0nB3Slrw24JMUvmxArXNIPNVOzvp8V9N1Lu5Jz9G0nYSCRqQJn0Yd?= =?us-ascii?Q?4M982D0MpoMRuqKW75mD2Ju7V2G1euW+LAUKm8lKxn8L6c/xyCwPt5hQWPNc?= =?us-ascii?Q?A3JgdOUcJeJ0ncbOC9FUGQZxczFsxsBGF7dPgLxqiqk5B3uLJ4DjaVyjgiCU?= =?us-ascii?Q?ByI+YZIDIh1K1hKf4usBid7FD315k8QI5zROH7HRV1ciUoDagagnuRZCSd6/?= =?us-ascii?Q?6/lNyFlMCgReTsb259oHgNHqvECZzC4QFKpUyJa02Ds3OCjIgYpyOBDPxmsh?= =?us-ascii?Q?AdpeAoXc21WtFqUGuC+pywtanYjOu+NWjvgooL+v+nVYFfu20uEYwB+qVqVn?= =?us-ascii?Q?4LIJVfHpEHI21DlpYnUnntBcchsMkd3+l9XLlikUaULQ5QvFM78yI2NsXA64?= =?us-ascii?Q?lZKjePuIw1kGv8gdiyarkr3DjzF98PCGIIbhYQTdXqklJF7f/pL8Xn8vWFtq?= =?us-ascii?Q?o4GQjA0//LkxbUADH5n/FlADzODHd3a+oJGwDOF7Urzk2DAVjahToaXxMMVv?= =?us-ascii?Q?IvGw4IuxtQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7aa51d5-1194-48f9-c258-08da3e142085 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 06:02:19.3657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kpsRI1Zt9stG6pMZzQNhY/BfFnxkLxncKPfyD9IWcLCndI23rT58OMfNxK0xOxCHnvfvW//w2N5ZqM2dFIfZ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8753 On 24.05.2022 18:46, Roger Pau Monn=C3=A9 wrote: > On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: >> On 24.05.2022 12:50, Roger Pau Monne wrote: >>> Booting with Shadow Stacks leads to the following assert on a debug >>> hypervisor: >>> >>> Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 >>> ----[ Xen-4.17.0-10.24-d x86_64 debug=3Dy Not tainted ]---- >>> CPU: 0 >>> RIP: e008:[] flush_area_mask+0x40/0x13e >>> [...] >>> Xen call trace: >>> [] R flush_area_mask+0x40/0x13e >>> [] F modify_xen_mappings+0xc5/0x958 >>> [] F arch/x86/alternative.c#_alternative_instructi= ons+0xb7/0xb9 >>> [] F alternative_branches+0xf/0x12 >>> [] F __start_xen+0x1ef4/0x2776 >>> [] F __high_start+0x94/0xa0 >>> >>> >>> This is due to SYS_STATE_smp_boot being set before calling >>> alternative_branches(), and the flush in modify_xen_mappings() then >>> using flush_area_all() with interrupts disabled. Note that >>> alternative_branches() is called before APs are started, so the flush >>> must be a local one (and indeed the cpumask passed to >>> flush_area_mask() just contains one CPU). >>> >>> Take the opportunity to simplify a bit the logic and intorduce >>> flush_area_all() as an alias for flush_area_mask(&cpu_online_map...), >> >> This is now stale - you don't introduce flush_area_all() here. >> Sadly nothing is said to justify the addition of a cast there, >> which - as said before - I think is a little risky (as many >> casts are), and hence would imo better be avoided. >=20 > So prior to this change there are no direct callers to > flush_area_all(), and hence all callers use flush_area() which has the > cast. Now that I remove flush_area() and modify callers to use > flush_area_all() directly it seems natural to also move the cast > there. While I agree that having casts is not desirable, I wouldn't > consider this change as adding them. Merely moving them but the > result is that the callers get the cast like they used to do. I'd agree with all of this if the change was local to mm.c. As I'd like to see the macro in flushtlb.h left unchanged, did you consider retaining flush_area() as a wrapper in mm.c, reduced to merely invoking flush_area_all() with the cast added? That would also reduce the code churn of the patch. >>> --- a/xen/arch/x86/smp.c >>> +++ b/xen/arch/x86/smp.c >>> @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const = void *va, unsigned int flags) >>> { >>> unsigned int cpu =3D smp_processor_id(); >>> =20 >>> - ASSERT(local_irq_is_enabled()); >>> + /* Local flushes can be performed with interrupts disabled. */ >>> + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(c= pu))); >>> + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ >>> + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)= ); >> >> What about FLUSH_FORCE_IPI? This won't work either with IRQs off, >> I'm afraid. Or wait - that flag's name doesn't really look to >> force the use of an IPI, it's still constrained to remote >> requests. I think this wants mentioning in one of the comments, >> not the least to also have grep match there then (right now grep >> output gives the impression as if the flag wasn't consumed >> anywhere). >=20 > Would you be fine with adding: >=20 > Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as > it's main purpose is to prevent the usage of the hypervisor assisted > flush if available, not to force the sending of an IPI even for cases > where it won't be sent. Hmm, yes, that's even more verbose than I would have expected it to be. Just one point: I'm not sure about "main" there. Is there really another purpose? Of course an alternative would be to rename the flag to properly express what it's for (e.g. FLUSH_NO_HV_ASSIST). This would then eliminate the need for a comment, afaic at least. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 06:33:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 06:33:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336859.561285 (Exim 4.92) (envelope-from ) id 1ntkaI-0006Ar-PE; Wed, 25 May 2022 06:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336859.561285; Wed, 25 May 2022 06:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntkaI-0006Ak-MD; Wed, 25 May 2022 06:33:30 +0000 Received: by outflank-mailman (input) for mailman id 336859; Wed, 25 May 2022 06:33:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntkaH-0006Ae-Sy for xen-devel@lists.xenproject.org; Wed, 25 May 2022 06:33:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9304c092-dbf4-11ec-837f-e5687231ffcc; Wed, 25 May 2022 08:33:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93DDB1FB; Tue, 24 May 2022 23:33:25 -0700 (PDT) Received: from [10.57.7.249] (unknown [10.57.7.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9884A3F73D; Tue, 24 May 2022 23:33:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9304c092-dbf4-11ec-837f-e5687231ffcc Message-ID: <4d440f82-4583-4438-bf82-ca8bab5d1189@arm.com> Date: Wed, 25 May 2022 08:33:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] init-dom0less: better snprintf checks Content-Language: en-US To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, julien@xen.org, Volodymyr_Babchuk@epam.com, lucmiccio@gmail.com, anthony.perard@citrix.com, wl@xen.org, Stefano Stabellini References: <20220524233544.245741-1-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20220524233544.245741-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Stefano, On 25.05.2022 01:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > snprintf returns the number of characters printed. snprintf does not print anything but instead stores a composed string into a buffer. To be more correct, I would suggest to write: "snprintf returns the number of characters that would have been written to the final string if enough space had been available". > > Add a check for that in init-dom0less. > > Signed-off-by: Stefano Stabellini Apart from that: Reviewed-by: Michal Orzel Cheers, Michal From xen-devel-bounces@lists.xenproject.org Wed May 25 06:37:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 06:37:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336868.561296 (Exim 4.92) (envelope-from ) id 1ntke6-0006m8-9U; Wed, 25 May 2022 06:37:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336868.561296; Wed, 25 May 2022 06:37:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntke6-0006m1-6E; Wed, 25 May 2022 06:37:26 +0000 Received: by outflank-mailman (input) for mailman id 336868; Wed, 25 May 2022 06:37:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntke4-0006lv-S9 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 06:37:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2082757b-dbf5-11ec-837f-e5687231ffcc; Wed, 25 May 2022 08:37:20 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-GuqOURPIOb6mUAa6bvgZ8w-1; Wed, 25 May 2022 08:37:22 +0200 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR04MB4225.eurprd04.prod.outlook.com (2603:10a6:208:59::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 06:37:20 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::85f7:b203:1f7c:c78e%7]) with mapi id 15.20.5273.023; Wed, 25 May 2022 06:37:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2082757b-dbf5-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653460643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hrj6j6ByazHfv9sYruDhV7Ai8DxTHdaXfhYH1rTQORw=; b=AbTcUg+QXBlA2Dp0h1vvcFRfNd9wiAtGXVQ73Jv/nuuv0BgtWHbDrMhbhZj+bYJjSHpUKx ArvRo0GFGyc4+l3wnoRwoiONo4TOS8xa02zXYsyOftMgrJXn34i1rqMkItAfHQKrjhaffm LfOON8mFVQh03YiKfcwL2CPATJLv7sM= X-MC-Unique: GuqOURPIOb6mUAa6bvgZ8w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ni0mx2Mb/Cv1Cjc56TQuxv9z20tWSKmixi2ed7j9QHNs0ftzEMbKSwV0JmNAZdGsW9g2m4LL6RV01iwO2dscmeCP5Tl8ywutf5yJEKSoR3ykFb+q3jmc1Xkyhzg2Si0geyqEwxZ6Az3WfMIudE94ubYsNQ/LnpEH5ulhVlAFGP2uzBjx8yqfcvRZ+HhTGIa175/mTGElV3FmiZKQNPwe+VMsYmNmQqvP6W00QVMjEw6wR3I1SRUpvDIeOBUVPdiF0zm4VmPi8mSYfyxLzhq16In0UXSlLWjlD76Hb73TeFQOER/OQKy/8tIOz0X84UbrPDtCUkr1jQfUJ0VrVnPH3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hrj6j6ByazHfv9sYruDhV7Ai8DxTHdaXfhYH1rTQORw=; b=M/fycyJyx8IeANKIRHMok/bPCpqmnriCbSveKddsOAeaaMCDPgtx/wbsC5ouLqfZN5wyD2gXbH+KGI6yfgEZPUSlZAmF3VUJMbIyB9eViTu1IFfUaxVIQUrmBV6AJDfprWccRZkRKMGEj3j0fAnOEfk55VocAl20Z027/Esrna0vwTL2yrJbm7VVoOyljieWFpv47M14nL1z//ihVh/2V+s/bkO253oQ0lbKdMq73hdnzH/95H4c9wDFGzzvfM2ddbmTRBFoWpP8wmJ761NM/8fijIK97XUsHDl9aUaemXGJfCbRbX8J7FxP5HK6vdJEhqbeZ3rc9Kh0gR7pR1vDdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8aebc234-e870-9435-9f60-3c06013421d9@suse.com> Date: Wed, 25 May 2022 08:37:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xsm: refactor and optimize policy loading Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220523154024.1947-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0542.eurprd06.prod.outlook.com (2603:10a6:20b:485::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b23346ec-8c55-45a9-fc51-08da3e190512 X-MS-TrafficTypeDiagnostic: AM0PR04MB4225:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: thuwmuiF6+vq766BQ3ygYJHIyWLZiDLPML3CQlrN+VvqrjuImCpih8tUXKt+vZehXk8PzhSeHWGnY7+nbWNmKQqRY1yPhKIDAPeKgVwps0EKKfAxErvb3slOFZrZzoD7wKoFLkGX/af2S8wfbcYWVNScOt63/oUDuxT6LK0Bmcjp890uV++Jm4eydvBsMKwAUZhYaJobGfrDIj/kbFdxxSNrL9rMZmvrZ1ZE2521Azi/gS+pUyuM8OZhzSSM19LSeXSYN8jE6xhOQ53nVKWApAUHPr7noEGcgIeEhRyOS2CPBoSPl9kYfmopUPuAkgRhJ/zAsEU8A7nxBVSFauUMI6kxy63W1IFADFmSsXO+vjnmkXByvrwNBRUq6mRWPBybuUhYSkflz1RX/f4WrAnbnv+8ctlZbH8dSumriYsAqFlw5Kko9NUJdADo62V71yAI4uLxOPT99slpORgDoYxV3wuE5Md5RJ3knYYtc5csgGsTJQKWtCmCEPStnt4BEssGskO6HQ1vsgKclml+sTS2RjWsm1fP23rWJDVmOmLXtH+osMJ/RxKRlbw/O7uz5jLu3BfwgmByey020B5YyewYmjnJ/+Yqa6dipkANn/9sPtkU7/ijQ/yxqxIu92yZfe/vnTiHLuu5WpEF7QLnbko3VYmeMuMVt/FQ+76pC9/fN7hINgdNgKXsCEXfJsaG6PaqLk6yFUMKw4SacXcDtpmJ1vJT99hm3A8GF731fGq0LtiWS0fqWoAG2u8kjAA4l1o9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(83380400001)(31686004)(53546011)(6486002)(508600001)(186003)(38100700002)(316002)(6916009)(31696002)(4326008)(5660300002)(6512007)(66946007)(6506007)(26005)(8936002)(8676002)(36756003)(86362001)(2616005)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGw5bzB4S2pmMEF5T25TSEg2aEU3MjFqQjRDcVpBa2RTUGd2SGpqZjNaNW4x?= =?utf-8?B?Y3dOL1NUbmRLcUdQYkd6YVBDSm9YNk1ucXdhT0lxTHVjU0U5OGJIeWVGcitF?= =?utf-8?B?Z2hrd25OWTVpQXlBaEo3TkYwZVhZaFMrR1pxL2lKU2hhbDFqSWVTL1BrNW8w?= =?utf-8?B?R1duOXBGcjdjQzF3RlBnVFVEVmRLNWFoN29mUDJEc05EMEpoYklWUWc4WjB5?= =?utf-8?B?SmxlVURsdkFtYmt1bUp4RnJ2eWQwTXM3NnprVXBoemJNWEZHelNpWm45a2di?= =?utf-8?B?UjVpUXhNRG9xL3gzbG1NM2M0ZE5OM2tSdE85WjlldFQ0QVI1YmplVVFkZXJx?= =?utf-8?B?TmYwQ3BQVTdBZmx0c1VkTk9Ed1B3dVpnbXFISVBOcEdIZzJpbVJybjNKUHNG?= =?utf-8?B?M01JU1Mwd2pZUFpvNVpCWHZKNWYzWVErYVAwbzNBTzNOSU5LYVppYzlmbGRK?= =?utf-8?B?cEt6WFRuSGF4a3MyaGU4cGMyTkVyWVVIcTA4OE1od3psV1dxZzd4bk9ja3lZ?= =?utf-8?B?eHJuYnNnR1pKNkZjUFg4dDdJZE5oanRUcnJqZkVZSEpRNzF2cEhiZ0RZbTVN?= =?utf-8?B?bUpWWWZEMFNYTVY0UDNodkZ0V2lqYjYxaU91WGxsTmJIejZ3Wmp1VUVPWW9H?= =?utf-8?B?endpK0NhSkNETkx6Tk15MXRadDFwVXVaMlRlMFZRZ1FPdDUxMFl4ZFZpTTZ4?= =?utf-8?B?SG5SN1VRZ3UxSEtCclN2ZG5tb2UzSXhvdEQ3cjRDU1FleUpsRWJzS1d1Rnl3?= =?utf-8?B?amVmY0o5U25heHZEWktsVzZJb1ltY3VFd0h0dkNYY1M3RjFudXFrOFlaRFE0?= =?utf-8?B?TXc2aGtVRHU2cmVGQTl4QVdybHVnMWFUZktSNTNvNld6enZPc1hySUhkMVdx?= =?utf-8?B?eUR1aC9WcEFTQkE5ZjREYmUzbGZPT2Q3TVk0bVNnaStodkRzb3ZTMi9EeUZr?= =?utf-8?B?Z0hyWHNDSjhlN05zMEhEbCtWQzNuVkFuS3lqQmpTWS9ORFNEU0FRYzhLTjZs?= =?utf-8?B?S3RKWURKbWw2WXFqb0hvWnpzVjdJaXFCRFFuZ0RCdXVoU3U5dDZ5ZzBqbm4v?= =?utf-8?B?RHpzR1M5RHRjTitoV3VqaGd6QlNEeEtHcXlhR3p0OGpIb251UTBLMzZuTjNz?= =?utf-8?B?QW9GNG14NUxkNlNFaHZTR1A0SVhVbW1nUW1uVldqNVpJMWJ1Z1JOSVIzUllW?= =?utf-8?B?ZFdMZWYzRUhJVjJYNS9qbk8vZ0cxOFFNdEZwRDRrcWFLdHVialp6NTRueVo2?= =?utf-8?B?dlFkU0ZneHlQWi9HZXhpbVZsYjk5NGdDUzdnNDZKMTh1bmdQb0pBSTl2RmNP?= =?utf-8?B?U1lZSmpxdnVSSG01dzRPbHlBT0t4WUd6RXZEZitORmVkc0FoL2lNTXRXb1ov?= =?utf-8?B?dDc0T1FjWDYvWEoxbmFpM2dvTHRUN2JtMUNWTjE1OWF4M2VTWVlCdVp4cnZU?= =?utf-8?B?VWtWeW5BWVYvWGFQRUs4Nk5HMW1wQjVZbmRIbnVZci9FMTExYlREanV4dytr?= =?utf-8?B?UGRWaTFKWnh5TzdZNnYwdzBzNGJZWmM0QkwrSW1QNmRTQlZrZ1lNWmtSamlZ?= =?utf-8?B?STJieldSMmxyVHJ5OFR6Y2EzT1pzNHNtcEUyZnB5V0dhWHZQYWZmUTJZUUdu?= =?utf-8?B?S0lwa203RUQyeTZUdFExRVhPSStKWW80VUVxY3YrRG50U1FNb3ZUdHhDTFBY?= =?utf-8?B?b2NRRWRLS2M2bFNnOWlHZnZPVkxGUFdZNk9OTlFjT3l1NkFjeGVrQzF2bml3?= =?utf-8?B?N3NyS1JBYkZDWk54NW5wZU96MWtlOUFZZ2dPWTdlQ1o2S0I4c3dxbytUWUtO?= =?utf-8?B?T1BCTXRkQkp6enZPa282OWs1RjhrODVZVWt6V09sZUN4Wmt5RExoU2NGWEZk?= =?utf-8?B?RTRwL29YNXIwNHhVMTdGNzZjVmpiWWF6UGFTdHZOeFcwMnB1aWJEdlBDRHR6?= =?utf-8?B?dUIvODdtQk5DMjVLbTJYNFowTDBhdkVIYjcwcW9kS1l3MFlBazdXdXNQcTBN?= =?utf-8?B?TG5CbkVQSFBVSUhzMHNCQTBSMml6NThtUVFiU21WVTR5TXpTem43ZnFDaWpj?= =?utf-8?B?WEp4UjFHL3FtaWc5NjF2UjZUVi9qMWdwelVPY1htOE9SRm5FbHRUbUwxRmF2?= =?utf-8?B?bThZMVlycW9OakpRbG00NFVacFNVaGxxeHNQUnFITTNBVDZPRzhkMFI1N2JY?= =?utf-8?B?R2pFNWFuclFKUUhtZVU5bEhJWUJjOE5lWGdZNEVUckRUTTYwLzBYY1BVN3B5?= =?utf-8?B?RzN3T3cyUU9ldEI2MDA5WTkwcHJheFBwYmhXTVh0ejEvMlpCd3B5RTAwdWJn?= =?utf-8?B?bEwxL1VNc3BXVkRWSFYrK1IxNEoycFpnVlhZTGF5alFRQWhTdGM2Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b23346ec-8c55-45a9-fc51-08da3e190512 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 06:37:20.7987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W93GnizHbVdNgAVk7uiis2D3XuCkM6lUfni0tQpp04EDjs4XDQJoFeiewzCXOTVg/e4FXV7++vPDyKhtoBgZCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4225 On 24.05.2022 19:42, Daniel P. Smith wrote: > On 5/24/22 11:50, Jan Beulich wrote: >> On 23.05.2022 17:40, Daniel P. Smith wrote: >>> @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( >>> { >>> int i; >>> module_t *mod = (module_t *)__va(mbi->mods_addr); >>> - int rc = 0; >>> + int rc = -ENOENT; >> >> I'm afraid I can't easily convince myself that this and the other >> -ENOENT is really relevant to this change and/or not breaking >> anything which currently does work (i.e. not entirely benign). >> Please can you extend the description accordingly or split off >> this adjustment? > > Let me expand the commit explanation, and you can let me know how much > of this detail you would like to see in the commit message. > > When enabling CONFIG_XSM_FLASK today, the XSM_MAGIC variable becomes > defined as a non-zero value. This results in xsm_XXXX_policy_init() to > be called regardless of the XSM policy selection, either through the > respective CONFIG_XSM_XXXXX_DEFAULT flags or through the cmdline > parameter. Additionally, the concept of policy initialization is split > between xsm_XXXX_policy_init() and xsm_core_init(), with the latter > being where the built-in policy would be selected. This forces > xsm_XXXX_policy_init() to have to return successful for configurations > where no policy loading was necessary. It also means that the situation > where selecting XSM flask, with no built-in policy, and failure to > provide a policy via MB/DT relies on the security server to fault when > it is unable to load a policy. > > What this commit does is moves all policy buffer initialization to > xsm_XXXX_policy_init(). As the init function, it should only return > success (0) if it was able to initialize the policy buffer with either > the built-in policy or a policy loaded from MB/DT. The second half of > this commit corrects the logical flow so that the policy buffer > initialization only occurs for XSM policy modules that consume a policy > buffer, e.g. flask. I'm afraid this doesn't clarify anything for me wrt the addition of -ENOENT. There's no case of returning -ENOENT right now afaics (and there's no case of you dealing with the -ENOENT anywhere in your changes, so there would look to be an overall change in behavior as viewed from the outside, i.e. the callers of xsm_{multiboot,dt}_init()). If that's wrong for some reason (and yes, it looks at least questionable on the surface), that's what wants spelling out imo. A question then might be whether that's not a separate change, potentially even a fix which may want to be considered for backport. Of course otoh the sole caller of xsm_multiboot_init() ignores the return value altogether, and the sole caller of xsm_dt_init() only cares for the specific value of 1. This in turn looks at least questionable to me. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 07:21:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336878.561307 (Exim 4.92) (envelope-from ) id 1ntlKq-0003KR-Ov; Wed, 25 May 2022 07:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336878.561307; Wed, 25 May 2022 07:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlKq-0003KK-JQ; Wed, 25 May 2022 07:21:36 +0000 Received: by outflank-mailman (input) for mailman id 336878; Wed, 25 May 2022 07:21:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlKo-0003KE-MW for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:21:34 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c80b25a-dbfb-11ec-837f-e5687231ffcc; Wed, 25 May 2022 09:21:32 +0200 (CEST) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 03:21:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DS7PR03MB5574.namprd03.prod.outlook.com (2603:10b6:5:2c1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 07:21:10 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 07:21:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c80b25a-dbfb-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653463292; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=QQnsyEN8QuvHi/UPd5m0NCTZVJEsdvY2UEljIOmbMXM=; b=cSs7Tjq9NN6f/1jcUiwpJ5SCQliHPOlzjQ2MukZ/xHM3g5cO90DXh3WX lG/M6NOjTmUqBtSy2YfJBJZ1CFOUdOTGpXMDCasM8Ou+Oht7NQQH/jLxy B6zoB3JP4yWGf14koh3Q+wxRsdu7T6TUym8Uy1ZLxWmp7wdj/lB545k4Z 0=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 72129261 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zg0u56JmJDkJHkdtFE+RpZQlxSXFcZb7ZxGr2PjKsXjdYENS02RSz GoXDWCHPvaKMGr8etsjOoqy9ENQvJGAzoAxHAdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Q12YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 IVsu4WLaFgKBPHVk7UWfj9mARFSMKITrdcrIVDn2SCS52vvViK1ht5JVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM6FGvqWjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SOmKWwC9gv9Sawf3U/5zxQh85rXNcuOQPqxXddplHTfj zeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCn1m71mEVThoMWjOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPJVGuw+rQqKk6zd5l/AAnBeF2EdLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqUJjq/OMZZVuHIJAw= IronPort-HdrOrdr: A9a23:e9ONcqGdulAhouVgpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72129261" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOOVSITyhiNrLlf9CH6kz8gwZwilJgIK8zbgieQ+TyQ+GT4qoQNkc6OxsvTDS5NVjIAfZuF3eQMCFlwGpS163tONFvShpLY6F/jebcaMQzb/2iuIsrUbrpixG1R0msbyv+bdaWe6Vrobj0c4LPTixaa7ITvVgxy3TczSpEFuyAswFEkZLUXZ/rxJw6HeWGicmpVJE+bsyB0wJscqiCElY4BXJXl5PkGPFI53uTerbM1eHyQe6iWpSJEgLgD0LqWlJ15M/LvL3eMNNoaH6r37vYTSMvpm7R/r6L+DYl82vgbG9DOx5JG0CxI7YN9KqvbalumGM0DO1DT+lX15Vj8iZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZC01VVS1t9xrA2x0htIo3j/g4vkU3ZSRw9LLcQir1ps=; b=J+5qGK6QsNCSYCZzFfGJDL/J+zAVR8ZL18CpxAKI0yWth9MLJyHR+f+nYPZkqKwLeq+GY9iiqNFNVjHNasVn/ZKSxVvEQTu/ZZnD+86DMvggsElIdpoBHOgAq25M1ahZLsbt8Z1jZRoJApTEhv6mt2TLxTRsP7kS8OkO5bRNXRf9d+IsvReGAOlaDCSPa+5YuCsQO6BdQWP0jIQ60bR7IS4P8yVR4Y54u4HCbkeCREJdA00U6gfeYNcOwvS579EvCyZJwllCL5CcoTePoLaZr75ZO+ouO1CjOwOerzZW3G62mSy9zUswD+HCkthvtKlqCgMR7FZiZXk9j2PAIXNs6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZC01VVS1t9xrA2x0htIo3j/g4vkU3ZSRw9LLcQir1ps=; b=HN0mkg32THw2SWUkyjba1qju8b+bDHiaepTMWJ3BSdmYwkqbGwsIrXowDqLbTvuhmYGwXyJseE/ptZzXCuXhE4lcrFziHw5ySng7FNIbjcGyAZyD+P6eu3nCd28Z/q9V7u7wFNKDAIc+3Yed6uXeL9EYcYOQWt7FfdSb189sP+Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 25 May 2022 09:21:06 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0070.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a740121-5866-4aaf-8793-08da3e1f2473 X-MS-TrafficTypeDiagnostic: DS7PR03MB5574:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PdDSKrlhFiXCLOJYQ1DgMlq2wbPiXBeM2Sz2elZ3q+4p0ALqLDvex86B2j6yhi+Su9uuyUjMOSPXtZJzQC0TAx+p7nwe+QQbOf3WEdwfj3OKQt6LFq0IsT2Hhs38TiOf8Eu4/uAcOGRuMubfFq5he7ruxtymK7v36TQ8H8ksd5/FMbJ/5J6/lInzURh+baxgu8LVwxamhWyTpzX9KkySlhiH0VEqRmAbWURD3yGM1NG3rUCuLGv3VKf3/9IcRh5Zf9we+5DTDDyJpOXNbIf6C0t9T9zWc4N52zPZf+Lw1K3S86l+DJl8QxussE6cjjhBQv4lJlQ7sR3v16UK1X2alfO7Yta7OvnsOakGLQ6WkpKw8J0W7fcDsSnseyvlBb/3ER1SlIloUXNbj1rFuPc6T8NeB7wMsgynOZQ307D1TO8vIyUSuaPZYpbYHC4Fqp6Tn5AmwbBwI9EycOx+Hhxr/GoRzGrY7Sc/jHABavYEmcllEjjC3Me+g7W4yFxbuEb38RzkZdzlcQyTf8+PKkFZcRuyhywA/x4b/rqG2iQAuA9uoXBRab8o7YwkDjwU7FnwuqQ7eESYIS7O7AxzccUOdwggb0mAGeDEBeR5YuID6PckR40VOjZ/6BQ438pYAOQBX23hd0ryFwFVOd9rFhSydg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(6486002)(5660300002)(6666004)(508600001)(2906002)(8936002)(85182001)(186003)(33716001)(83380400001)(82960400001)(86362001)(316002)(53546011)(6506007)(6916009)(54906003)(8676002)(66946007)(66556008)(66476007)(4326008)(38100700002)(26005)(6512007)(9686003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFpRQmQ3ODNiVzFQektMRGJxRjlKOTZhWEFkV0JhUnZqUGxKdGVsdmhIVVlU?= =?utf-8?B?c2dNTFRMVlh1aUJVYVdIb0FDaW1yNEpDbHZkMFhFS1h4VW95MWZXbG5lSjJ6?= =?utf-8?B?VjNROEl5R1d2dnpLYWMwbWZIWlNMKy9BVFg5aVhkcmpDQnYvSzNZMkQ1MWdX?= =?utf-8?B?TlpJSFRYNHR5NzN3UlBHaUR1ODUyMER5alF5bTZKZ2xsUkVSbkR5c3dKRVRv?= =?utf-8?B?SXNXM0JtUkU3azZ5bDgwR3V4VVhlNWdtb21LbmJUR0lPanI2aGpJREFMSDdv?= =?utf-8?B?dVJmdTVoNnp5K3J4RW00bzhjVUhBNUR6ZGdMczB6TEo1NDg5L21mN2lWZjdU?= =?utf-8?B?UWlZb1NsNG9WYXI1aWcvd0x1aHRiQnpjYkpCeG1uUzl3aGt3dHhjem42SWhP?= =?utf-8?B?UThtUGhEWmdtcGVXRWVTTDdodjl5bTRjMVV0cC9HZGRlTjZWSGVDTlFFRHBj?= =?utf-8?B?TlpWVzh3ZDlqYys2S3N4a3JKcmlmdnBDdDFnbWhFeGxuZ0lGdGs4bEcvMWRM?= =?utf-8?B?L0dFYWxEWS9XZXcrU0dscDR6QlprSVM1ZHBCUFNzb2JmUWlIV3JrQS9PY05D?= =?utf-8?B?bkIzQ0NLTU9MWmxRSnFtdm4yT2dvZ2RnTmswZ2dsekdjazN1NjY3TDdFUlZo?= =?utf-8?B?MHZkL2dOdzdneDg3clY0MFprMFkvRjNuRUhscVk4dmhNRnNmbVJ3WjBnZmFN?= =?utf-8?B?ZXVrSFBkVXBxa1FneEcwOWFCYitZemtONldXTG9LWXpjRTJoUjRpUzBIQ1Rq?= =?utf-8?B?ZXhxZDBNT2svbEYwc3JQbmxzOGI5ZjI4RnN4Z3hLUXhkc1ErUjMrQ2JpUWNW?= =?utf-8?B?cncwaEZIVHNuYjlkWjBJR3V6LzBBcUVrL05QL0trMFFkZmFJQU5JMG1zd21n?= =?utf-8?B?Y1BHWHIyL3RRLzZwako3WUZtMlZvVC9lN2IxQnl4UFB1dkQ0OUlmNEFwL2lr?= =?utf-8?B?eHI3NnJDcmFpTkNQc204b0JIY2lYMit3V21EUldTWjdzZVpWbVp6bEFBcmNm?= =?utf-8?B?YjZDSktXUVVUaUp1di9jdHg5YXVnb1QwYkNGcm9uYnNqejFQbG5LMzEwVmM3?= =?utf-8?B?VFZlRVRtRzNKRkxNRExubUdtOVM3ZHdqYlF5SU44MGZyT1BRYzA3RnJmU0hU?= =?utf-8?B?VGIxZTJDbklZem12VXFCZVBDU2ZyU0c4ZVBaVHE3eGphUENsbFd4djNsMU5w?= =?utf-8?B?ZmdEb2NkVGU1OXZ2WGtIdjFvamhrMjNJOVhSNUM4YTV6anFRVEVWL3hHcE8y?= =?utf-8?B?R1pIeGp1TG1EM1lFN0pGVkZzM3dmSTRyb1MwSGZHWkZ1dndvMTE4anFwdWUv?= =?utf-8?B?dmJkQ1hza3VpKzFrZ3AzU2hvRWdPRko1OU1sdWxSdkNqWlNURHh1eVIwMmVI?= =?utf-8?B?RndUSHJSNENBdzA3TzBLRE9aekdHUEM2K00rWUtsOFJFWnVCeFlKUThwSVRP?= =?utf-8?B?TnRLaUVNV1B6TnpOU041ZGdLbDg4ZUVQdGZzalV6ekRFaW5CQzRXSE1rbG9n?= =?utf-8?B?VlNkZkxTanluOHFKOVFBb2cwQzREQkN4V09XdVh0LzhZaHhlbXo3eW9tNDVZ?= =?utf-8?B?MGpTSlg1ZTQyaHlxaStqSmtkd21aRHRQZFdJc3AxaGNoRUF2S2VwRXUyak0v?= =?utf-8?B?THVCS1Z6OFBrMEFJeGZ5ZWM5Zm9nTXdrU2VEdnRLbEk1RWJ6bzRvY3FGSG54?= =?utf-8?B?QnpMaUN3TXpsQUJTa3g1cFJsMUxyMFZOSnMrc3F3RmZuVnJnMFVYaUpIYjdD?= =?utf-8?B?ZnpyZEttQklsTklaUTJTbUlNZ2QwWUxrSDdpVGFzUWlHd1g4MDJMdGppdEsz?= =?utf-8?B?NFhBemFGcHB5dzNudFRaR01lRFdGZjlIWW1hakJlVExlWnFtRkRuS2c1ZDc3?= =?utf-8?B?dGVlMFdJcmtPcklQczZzN1k5cG96NHR4ZG9WS3ZpNDQ4OHZqY0plNi9QaXFr?= =?utf-8?B?d3drclBnUE0zY1dFUGd4N1dMejUxemh5ZG9pR1ErYWw2UlB5L3JNeldrMktR?= =?utf-8?B?OGtEbmt4T3YwMHBlenBmczlRZ3VNKzVPQlFhMjllOE5mbkF0dzlZUXJMQ09Q?= =?utf-8?B?andRbjcyWU0zb2haNUxwYmRjajRoSW1TYWs5RnI2SS9BbFozS3A5b1hUQkw3?= =?utf-8?B?bkZoOVpWMURVM0taRmNCbExjREl4MVhySVdXT29oWWF5WTcvT0xTdEpTR3lq?= =?utf-8?B?RjhyVC9EWHJmOFpIKzNIQmxrMitPNlJ4MC8rYi9mMVc4c282Q0xjNjBvSnlF?= =?utf-8?B?KzZublB2cVVSNllQMTNwdi9vclh2ZmRpaUlLdk1IanE2R0lncHFwYURjS0Q5?= =?utf-8?B?WkMzNkE3ZERVclJrL3pQSG0zVzkzYTY5bmlBNi9ROGpCemdrdTZDaVlJUzEw?= =?utf-8?Q?oxnlfngA6JrOwFlU=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a740121-5866-4aaf-8793-08da3e1f2473 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 07:21:10.4069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q/h4DjCxtLTZY/b/QAjQyKTPLuEWHekwvp+Enb/pWlAOmMJBHflrh63imF65oaUpaphwDu8OnO51f11lhFRrdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5574 On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > On 24.05.2022 18:46, Roger Pau Monné wrote: > > On Tue, May 24, 2022 at 05:27:35PM +0200, Jan Beulich wrote: > >> On 24.05.2022 12:50, Roger Pau Monne wrote: > >>> Booting with Shadow Stacks leads to the following assert on a debug > >>> hypervisor: > >>> > >>> Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > >>> ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- > >>> CPU: 0 > >>> RIP: e008:[] flush_area_mask+0x40/0x13e > >>> [...] > >>> Xen call trace: > >>> [] R flush_area_mask+0x40/0x13e > >>> [] F modify_xen_mappings+0xc5/0x958 > >>> [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 > >>> [] F alternative_branches+0xf/0x12 > >>> [] F __start_xen+0x1ef4/0x2776 > >>> [] F __high_start+0x94/0xa0 > >>> > >>> > >>> This is due to SYS_STATE_smp_boot being set before calling > >>> alternative_branches(), and the flush in modify_xen_mappings() then > >>> using flush_area_all() with interrupts disabled. Note that > >>> alternative_branches() is called before APs are started, so the flush > >>> must be a local one (and indeed the cpumask passed to > >>> flush_area_mask() just contains one CPU). > >>> > >>> Take the opportunity to simplify a bit the logic and intorduce > >>> flush_area_all() as an alias for flush_area_mask(&cpu_online_map...), > >> > >> This is now stale - you don't introduce flush_area_all() here. > >> Sadly nothing is said to justify the addition of a cast there, > >> which - as said before - I think is a little risky (as many > >> casts are), and hence would imo better be avoided. > > > > So prior to this change there are no direct callers to > > flush_area_all(), and hence all callers use flush_area() which has the > > cast. Now that I remove flush_area() and modify callers to use > > flush_area_all() directly it seems natural to also move the cast > > there. While I agree that having casts is not desirable, I wouldn't > > consider this change as adding them. Merely moving them but the > > result is that the callers get the cast like they used to do. > > I'd agree with all of this if the change was local to mm.c. As I'd > like to see the macro in flushtlb.h left unchanged, did you consider > retaining flush_area() as a wrapper in mm.c, reduced to merely > invoking flush_area_all() with the cast added? That would also > reduce the code churn of the patch. Hm, yes, didn't consider this, but could do. I didn't want to keep flush_area() globally, but adding to mm.c only could be OK in order to limit the cast. > >>> --- a/xen/arch/x86/smp.c > >>> +++ b/xen/arch/x86/smp.c > >>> @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) > >>> { > >>> unsigned int cpu = smp_processor_id(); > >>> > >>> - ASSERT(local_irq_is_enabled()); > >>> + /* Local flushes can be performed with interrupts disabled. */ > >>> + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))); > >>> + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ > >>> + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); > >> > >> What about FLUSH_FORCE_IPI? This won't work either with IRQs off, > >> I'm afraid. Or wait - that flag's name doesn't really look to > >> force the use of an IPI, it's still constrained to remote > >> requests. I think this wants mentioning in one of the comments, > >> not the least to also have grep match there then (right now grep > >> output gives the impression as if the flag wasn't consumed > >> anywhere). > > > > Would you be fine with adding: > > > > Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as > > it's main purpose is to prevent the usage of the hypervisor assisted > > flush if available, not to force the sending of an IPI even for cases > > where it won't be sent. > > Hmm, yes, that's even more verbose than I would have expected it to > be. Just one point: I'm not sure about "main" there. Is there really > another purpose? Right, I should remove main. > Of course an alternative would be to rename the flag to properly > express what it's for (e.g. FLUSH_NO_HV_ASSIST). This would then > eliminate the need for a comment, afaic at least. I think it's likely that we also require this flag if we make use of hardware assisted flushes in the future, and hence it would better stay with the current name to avoid renaming in the future. Whether the avoidance of sending the IPI is due to hardware or hypervisor assistance is of no interest to the caller, it only cares to force a real IPI to be sent to remote processors. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 25 07:34:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:34:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336887.561318 (Exim 4.92) (envelope-from ) id 1ntlXV-0004tL-W2; Wed, 25 May 2022 07:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336887.561318; Wed, 25 May 2022 07:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlXV-0004tE-TM; Wed, 25 May 2022 07:34:41 +0000 Received: by outflank-mailman (input) for mailman id 336887; Wed, 25 May 2022 07:34:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlXV-0004t8-0Q for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:34:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 224e0a3d-dbfd-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 09:34:39 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-xdvVpxnKM1KxJn26HvTb6w-1; Wed, 25 May 2022 09:34:35 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5074.eurprd04.prod.outlook.com (2603:10a6:208:cf::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 07:34:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 07:34:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 224e0a3d-dbfd-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653464078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u9XT3BA+4vUTTAX40MIGeXkp8Zfnj6fkA9USR6HPqXE=; b=Fh8+yqYa3dCd2uBp2PRho9zyoQ5UMv5GkiQO1pPHsKFbBuYjiD90u2bvO245PtlWavf0az yJ0b+RKgdqzYG5xPC3J0Jzf0Q2Q9LRNj1CdHnywYyLwBhzO96zIFGcr9K60rvAsPOi0nBC HwHJ0nSwL+V5H1hq4fXpFRJ87bBv720= X-MC-Unique: xdvVpxnKM1KxJn26HvTb6w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2SOm8gBXWh9ai/8orp/H/q/tjjGso0nX7qAt5qcjjPVENLFwJx4O6f2/vCSqqDe4glNdrUnNI0odpbMku/ujIfX1qsQwY3wmrY9zBiRzqhe3UXP2KGe0T722CH06siO1/dsofx6S6DyVwcu0MAUHH7uNLGEPKKTWxopIJQUWfAFNY4G/s17hBHVtbp9WAuiID6ygGidgK3J6ep7ujsxxx7LuF1XuqOBIW0EL0wUoVJWb+Ecp+O9/ZGBB4EHHRdXvam/RJEbgcWEEebEHQLLyi+cb+XBQcEIu3KhjoidryYUFZQaIlIQcdN/C3B9jq3UP8Uel2C1YT+gmzSBNEXbfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqW6WifE+JclFIX6Pe5SaWbVsI1V6porN+qdVcQ0erw=; b=ANrbHIfxti1JLyA4JXlgKGSwpNM1W+rxN2/NidvePmyhHC5f8/ocuJxg6ybJ1LZSLnyEb80QmN8bGCqR1fK3qLecJb8wnGoYVsFJN3bNC60gvutABVvzYr0+b8JEUsGShykgAEILrUAI4G87eZPbFuJk/vTLKrsfBoXlSrk5yjoUiBh75nVRics5YO0Xhn2eePNCvexYfXwc/O2Edi9VJ5i9lCGrHvlUku4oZ3M8iW3sxRwmJslGSVcvHl4tppVcfkvXfn8EDtt/l6huDgUyA6p6WjuW+phj9sdcnENBWlSXf1HrYR48BF17dASP368MdP96RDFMHQ2zPVy6TE6eiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 09:34:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR05CA0047.eurprd05.prod.outlook.com (2603:10a6:20b:489::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6463d22b-e88e-4fac-e608-08da3e21037c X-MS-TrafficTypeDiagnostic: AM0PR04MB5074:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9yXRRWN/oTUdOIqN028YIzXGQq1Vw/hPa+dE5AlvYSvczK1cd8DB3GlBnkc0iuuBZAffksjGu/U7RmffvdtTLS1HIcULXChmFwhO8Ln+ewmzORbZc8aigWtH/dsPsPQ12x4QLPgCCghcRfmpk3DsVqU1nUTVrRdCBD2CNDmQK8Lw7x8DmCg8ZIEOen8xAVrQfkmbNyVak+iepZ+GbNztyhCmiwqucVUz3Z5YCgX0W9QO7LwJEHNSyGOPvZeqG0/M7Am9kmafEV0fj//qNzlpL/1yAHoK/5v3AB9DwU+/PaHiX1ETz+hpE1rXWEwRJK+C0pU3v91IU7Gv6719JqRgexEeZaUqKHlUhR6UuwvE2rwLyjlENTeAcKECpm0bp4YEHIdKSXRKPY+tI9kPxk7TzNDzw+FBEXECbEUL4mXBXqUNhlwXJUnQTBYOb9Gc3uvIsApbct15N9Y64Zz1pxq5lk6SSYYNF7f0gkjWih0BKNzIgcTVzmukpxL5OV2r7dGux4S6016dfDwGCDLfBDX5ZFSnVOOpUM8ahpKZCQ484NPLtLSgLbVQI9+VUvK3LqZg7lHmtAUF6csvn5uxcWOLu8XIL08fq/EmOgAefdpnP0046jevqdQbEaSbwD1cBHxc7Jv+UoXUKg76k1tPU+wKrUCzn0kOyqTV3KUIx/HPqcYWXWITd1yIRXfRtEBjWmGYkMUq/OA6Ii5ktJgWpjjT2lfzwg5/wo80ueuutkasiehiUGn0cyEGu63v3+9vMKDX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(54906003)(2906002)(53546011)(86362001)(6916009)(186003)(2616005)(31686004)(38100700002)(26005)(8936002)(66946007)(5660300002)(4326008)(66556008)(6512007)(66476007)(8676002)(6506007)(316002)(6486002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FmR70wQn9rlVErGdNELScfq7TAOAmrTWCl5+iYVshTAMmmQnUIlV4VapTQFX?= =?us-ascii?Q?L3uAdIE5vkqKtlr9zAjAvYcZQWOJOSroTmEjYH8WFBejgMb070dGn07XkVKj?= =?us-ascii?Q?+ykkjBW6icMrL3pxLHIEfYJnzpOviLErcXuZItjF0e1iVbuteplJiVEkqXjb?= =?us-ascii?Q?HAhiJE8Zn3MG+oDupvgIQ5UZvvGNrqCpQTLxH4C7Fs6b9tQls1B2enKzf6I4?= =?us-ascii?Q?+d2BQDqUNiBBvrUReZMn5wOLnoJi6oHjaKY+wwwvAPhpm0mmpddRAVuEYndJ?= =?us-ascii?Q?bMzT+clrDD4XN4N8dTK25zYEiV5tU+7cCdHgAIJOVDp9wt/Otb/u+5gmMp5L?= =?us-ascii?Q?DCJj4ynxTBU4X03rCQFwJ4cvRn92dXkd13QyNdFQpYeezqoXxFZmznc5gOEt?= =?us-ascii?Q?MnvVgjCA6/eXx3KC+R7XUES3awVX9/qnpXof4EkCs6J3OkX3oBSWSrxm8A+7?= =?us-ascii?Q?ZCOnPYieC6dmGNsAMQqZ4Qocl5z/zejOCVy7lIXhoRi6KAPGmhmAluQ8Jyre?= =?us-ascii?Q?K3vfepy5Va5d4AbLa8z+TvW+i7MbD5daxt23pATDQesMpJe+V1dwhLJJUlyh?= =?us-ascii?Q?4wDrs33ABScLoDjbbljYnxVQc2S8sbqRLhA1mwvoNG35oI4lnbl4Tlo7KO7M?= =?us-ascii?Q?O1vz61UIU3GqURS+Qw9QJZTswiA2vI4EX9afM2+i+61iTcRAPBSyx1jBGczq?= =?us-ascii?Q?k57Uwkya1CZYDWBH9Qkg2d2irSbnBHzOCKQrGmzBzObDmBi+7WKETfZN2j3n?= =?us-ascii?Q?82pQtLrQ0EbwYfAvfLQ5sV0+2wsC3/Sa513YXBpQJHC5VDinNrq4z8W1L2R2?= =?us-ascii?Q?dNGHOw3aqm4kDgmEnnh/qCTeZqc6V/e+I+k2reo82JdsR9jJGRq3vi+oQQz/?= =?us-ascii?Q?uikLgcqeTTSt0uv8T2TKM4GW/+ONJPm0i4vh8felSeM3OTPxxDIwyS42+9A8?= =?us-ascii?Q?3Ijxjs1FSM3s2rAHwW//MYeVHSd2WQApP+rnwBMGsg3cyeOr2g7LGd3VcoPK?= =?us-ascii?Q?4HpTRoGPWK4fvC2ilVPOXnjmQJJZ0AeMnqRqhuT3tl7kh5GqLQrSkGxVT7Zv?= =?us-ascii?Q?je0bON3WaxQ5/s0PCanObxgcC5pPvs+7yllHBZ5rGTTTLWgzaHckorK+dwFI?= =?us-ascii?Q?srExi6VFWHWqNW+gkpdmXWKJtGkpDgTIKsimElPG9F+jkAx+iszmt4vFZRGm?= =?us-ascii?Q?DbUDQwtca/j8wF5toTTRRqK3CwL32ffjAESqn7P92RxeJkGJ1irO8uXVmUtZ?= =?us-ascii?Q?0PS9WKv/nDQqwpnPQZvzFelmdADImsIgYljCG8Xrv3p9RZ2nWW3Q7QBT6ckz?= =?us-ascii?Q?Q5L7Z/b4Y35n3UhP4mwXA63F0qsNiMWFhboy2JoNA8WwJnjvHf+U3Mn8C6Gu?= =?us-ascii?Q?IkErTqO+x8AepMR7PeXXUuEbdE67XTPj/EgXlQvlvmQmJkynhhUKMd8BlDkv?= =?us-ascii?Q?qsXmkCrXoqp1iRJah/oB+TjU0yFjcGifgdukiZ/jq2Zgi7N6hTHCRleI7EF5?= =?us-ascii?Q?fgWdz38fsiBpaEvJa6F68i8Hj2HO+2Lh48k6VXcP0GRZ7yf+q9Ou81HGkjzq?= =?us-ascii?Q?JNr1+PgQxDVymn1YmHEJ9emvC1LFUGyft8is2Nk2DV/EGz/0bx+TVPpWxgO7?= =?us-ascii?Q?NrMCep0jD0MTCDOxxs7WsHXjDBqrNpsYK2YQsTfHjnNgpLR1oe8B+vsCP23B?= =?us-ascii?Q?jmIMGPY64xRYL5LxGtYOhK9BmFGq/qTb94N8S4CHbplDuOSfazKbPEQHVuuf?= =?us-ascii?Q?Vk8smlN9PQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6463d22b-e88e-4fac-e608-08da3e21037c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 07:34:34.0800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nfD++wMM11t9Ek8Doawj55FzPvK/7ldYjrHBs7KFM1KizMLTm+xfmtB76MlO5uVvp+mrAmQAJ0+WFr+E/AFNGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5074 On 25.05.2022 09:21, Roger Pau Monn=C3=A9 wrote: > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: >> On 24.05.2022 18:46, Roger Pau Monn=C3=A9 wrote: >>> Would you be fine with adding: >>> >>> Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as >>> it's main purpose is to prevent the usage of the hypervisor assisted >>> flush if available, not to force the sending of an IPI even for cases >>> where it won't be sent. >> >> Hmm, yes, that's even more verbose than I would have expected it to >> be. Just one point: I'm not sure about "main" there. Is there really >> another purpose? >=20 > Right, I should remove main. >=20 >> Of course an alternative would be to rename the flag to properly >> express what it's for (e.g. FLUSH_NO_HV_ASSIST). This would then >> eliminate the need for a comment, afaic at least. >=20 > I think it's likely that we also require this flag if we make use of > hardware assisted flushes in the future, and hence it would better > stay with the current name to avoid renaming in the future. >=20 > Whether the avoidance of sending the IPI is due to hardware or > hypervisor assistance is of no interest to the caller, it only cares > to force a real IPI to be sent to remote processors. Well, then it could still be named FLUSH_NO_ASSIST, since as said (and as you look to agree with) there's no IPI being forced in the general case. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 07:39:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:39:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336895.561328 (Exim 4.92) (envelope-from ) id 1ntlc3-0005Wh-HV; Wed, 25 May 2022 07:39:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336895.561328; Wed, 25 May 2022 07:39:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlc3-0005Wa-En; Wed, 25 May 2022 07:39:23 +0000 Received: by outflank-mailman (input) for mailman id 336895; Wed, 25 May 2022 07:39:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlc2-0005WU-MS for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:39:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlc2-0002Y2-17; Wed, 25 May 2022 07:39:22 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntlc1-0002JF-Rc; Wed, 25 May 2022 07:39:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=oUH2ecaO3iWv8aqf8ra77g7svJJ6cDPr/F5SoO3rEWY=; b=jLshUGYRcrz7Q1WetZgaIHD7Je +y9IAhss75DvPWV8AavolMiGokP8Iu7DKOH8A3yaMNwMWRZSKnXJGDG+iFoEJ3E7pKNml+XV7dUxl /ZSsljOxUoU4CFsSb+y84BzXrlHtQIGXM4UbqW3gGPagiIWuU/aTKf840qDQQ84CLFIk=; Message-ID: Date: Wed, 25 May 2022 08:39:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> From: Julien Grall Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: <20220525003505.304617-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 25/05/2022 01:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > Introduce a list of MISRA C rules that apply to the Xen hypervisor. The > list is in RST format. > > Add a mention of the new list to CODING_STYLE. > > Signed-off-by: Bertrand Marquis > Signed-off-by: Stefano Stabellini NIT: I was under the impression that the first Signed-off-by is usually author. But the From doesn't match. > --- > CODING_STYLE | 6 ++++ > docs/misra/rules.rst | 65 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 docs/misra/rules.rst > > diff --git a/CODING_STYLE b/CODING_STYLE > index 9f50d9cec4..1ef35ee8d0 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -235,3 +235,9 @@ callstack between the initial function call and the failure, no error > is returned. Using domain_crash() requires careful inspection and > documentation of the code to make sure all callers at the stack handle > a newly-dead domain gracefully. > + > +MISRA C > +------- > + > +The Xen Project hypervisor follows the MISRA C coding rules and > +directives listed under docs/misra/rules.rst. > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > new file mode 100644 > index 0000000000..c0ee58ab25 > --- /dev/null > +++ b/docs/misra/rules.rst > @@ -0,0 +1,65 @@ > +===================== > +MISRA C rules for Xen > +===================== > + > +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > +MISRA Consortium Limited and used with permission. > + > +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for > +licensing options for other use of the rules. > + > +The following is the list of MISRA C rules that apply to the Xen Project > +hypervisor. I was under the impression that we would still allow deviations on those rules in some cases. In particular... > + > +- Rule: Dir 2.1 > + - Severity: Required > + - Summary: All source files shall compile without any compilation errors > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > +- Rule: Dir 4.7 > + - Severity: Required > + - Summary: If a function returns error information then that error information shall be tested > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c ... this one. We are using (void) + a comment when the return is ignored on purpose. This is technically not-compliant with MISRA but the best we can do in some situation. With your proposed wording, we would technically have to remove them (or not introduce new one). So I think we need to document that we are allowing deviations so long they are commented. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 07:40:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:40:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336903.561339 (Exim 4.92) (envelope-from ) id 1ntldU-0006r8-T9; Wed, 25 May 2022 07:40:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336903.561339; Wed, 25 May 2022 07:40:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntldU-0006r1-QW; Wed, 25 May 2022 07:40:52 +0000 Received: by outflank-mailman (input) for mailman id 336903; Wed, 25 May 2022 07:40:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntldT-0006qr-A1 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:40:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntldS-0002aq-Kc; Wed, 25 May 2022 07:40:50 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntldS-0002O6-Ek; Wed, 25 May 2022 07:40:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FbqPwK/F59CJPJU/xH7emql9on3Xx84dOcWQmx5jnOk=; b=uR71a27Kiv8gju7cxjnBqj0/n+ gpm+26p5fxlMtUU3nfUaZVQ0D7AZk26cVvKUs0K9B0bHlzPtNpZohfUn84pWGQtoBmL+lj7P/r8a3 b2AMpAsLItfKOj1EAfgashuqN6o6SBNKMj27NicMP5WMZiCXNPGtsHU1HhhD9xu7VQ4M=; Message-ID: Date: Wed, 25 May 2022 08:40:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini References: <20220525003505.304617-2-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220525003505.304617-2-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 25/05/2022 01:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > Add Rule 5.1, with the additional note that the character limit for Xen > is 63 characters. 63 is a bit an odd numbers. Why not 64? > > The max length identifiers found by ECLAIR are: > > __mitigate_spectre_bhb_clear_insn_start > domain_pause_by_systemcontroller_nosync > > Both of them are 40 characters long. A limit of 63 characters work for > the existing code. > > Signed-off-by: Stefano Stabellini Regardless what I wrote above: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 07:46:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:46:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336911.561350 (Exim 4.92) (envelope-from ) id 1ntlis-0007Wu-H6; Wed, 25 May 2022 07:46:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336911.561350; Wed, 25 May 2022 07:46:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlis-0007Wn-EE; Wed, 25 May 2022 07:46:26 +0000 Received: by outflank-mailman (input) for mailman id 336911; Wed, 25 May 2022 07:46:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntliq-0007Wh-OU for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:46:24 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5764627-dbfe-11ec-837f-e5687231ffcc; Wed, 25 May 2022 09:46:22 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1ntliT-0002eu-2o; Wed, 25 May 2022 09:46:01 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5764627-dbfe-11ec-837f-e5687231ffcc Message-ID: Date: Wed, 25 May 2022 09:45:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Chuck Zmudzinski , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> From: Thorsten Leemhuis In-Reply-To: <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1653464782;5dcfc996; X-HE-SMSGID: 1ntliT-0002eu-2o On 24.05.22 20:32, Chuck Zmudzinski wrote: > On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >> On 20.05.22 16:48, Chuck Zmudzinski wrote: >>> On 5/20/2022 10:06 AM, Jan Beulich wrote: >>>> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>>>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>>>> >>>>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>>>> those want >>>>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>>>> inspect them >>>>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>>>> observe the >>>>>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() >>>>>>>>>>>> as the >>>>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>>>> earlier >>>>>>>>>>>> patch, in >>>>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>>>> to be >>>>>>>>>>>> the >>>>>>>>>>>> problematic one, which you leave alone. >>>>>>>>>>> Oh, I missed that one, sorry. >>>>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>>>> >>>>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>>>> least >>>>>>>>>>> the >>>>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>>>> >>>>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>>>> should not override that, >>>>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>>>> an override would affect only the single domain where the >>>>>>>>> kernel runs; other domains could take their own decisions. >>>>>>>>> >>>>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>>>> (but tell us "don't do that then"). >>>>>>> Actually I just did a test with the last official Debian kernel >>>>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>>>> normally on both the bare metal and on the Xen hypervisor. >>>>>>> That means your presumption (and the presumption of >>>>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>>>> had no effect on my system with Linux 5.16. So after doing these >>>>>>> tests, I am against the aggressive approach of breaking the i915 >>>>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>>>> nopat did not break the i915 driver. Why break it now? >>>>>> Because that's, in my understanding, is the purpose of "nopat" >>>>>> (not breaking the driver of course - that's a driver bug -, but >>>>>> having an effect on the driver). >>>>> I wouldn't call it a driver bug, but an incorrect configuration of the >>>>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>>>> i915 driver >>>> The driver ought to work fine without PAT (and hence without being >>>> able to make WC mappings). It would use UC instead and be slow, but >>>> it ought to work. >>>> >>>>> and therefore the driver should refuse to disable >>>>> it if the user requests to disable it and instead warn the user that >>>>> the driver did not disable the feature, contrary to what the user >>>>> requested with the nopat option. >>>>> >>>>> In any case, my test did not verify that when nopat is set in Linux >>>>> 5.16, >>>>> the thread takes the same code path as when nopat is not set, >>>>> so I am not totally sure that the reason nopat does not break the >>>>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>>>> returns true even when nopat is set. I could test it with a custom >>>>> log message in 5.16 if that is necessary. >>>>> >>>>> Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) >>>>> to return true in 5.16 when the user requests nopat? >>>> No, I'm not saying that. It was wrong for this construct to be used >>>> in the driver, which was fixed for 5.17 (and which had caused the >>>> regression I did observe, leading to the patch as a hopefully least >>>> bad option). >>>> >>>>> I think that is >>>>> just permitting a bad configuration to break the driver that a >>>>> well-written operating system should not allow. The i915 driver >>>>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>>>> because that option is not compatible with the hardware the >>>>> i915 driver is trying to initialize and setup at boot time. At least >>>>> that is my understanding now, but I will need to test it on 5.16 >>>>> to be sure I understand it correctly. >>>>> >>>>> Also, AFAICT, your patch would break the driver when the nopat >>>>> option is set and only fix the regression introduced by bdd8b6c98239 >>>>> when nopat is not set on my box, so your patch would >>>>> introduce a regression relative to Linux 5.16 and earlier for the >>>>> case when nopat is set on my box. I think your point would >>>>> be that it is not a regression if it is an incorrect user >>>>> configuration. >>>> Again no - my view is that there's a separate, pre-existing issue >>>> in the driver which was uncovered by the change. This may be a >>>> perceived regression, but is imo different from a real one. >> Sorry, for you maybe, but I'm pretty sure for Linus it's not when it >> comes to the "no regressions rule". Just took a quick look at quotes >> from Linus >> https://www.kernel.org/doc/html/latest/process/handling-regressions.html >> and found this statement from Linus to back this up: >> >> ``` >> One _particularly_ last-minute revert is the top-most commit (ignoring >> the version change itself) done just before the release, and while >> it's very annoying, it's perhaps also instructive. >> >> What's instructive about it is that I reverted a commit that wasn't >> actually buggy. In fact, it was doing exactly what it set out to do, >> and did it very well. In fact it did it _so_ well that the much >> improved IO patterns it caused then ended up revealing a user-visible >> regression due to a real bug in a completely unrelated area. >> ``` >> >> He said that here: >> https://www.kernel.org/doc/html/latest/process/handling-regressions.html >> >> The situation is of course different here, but similar enough. >> >>> Since it is a regression, I think for now bdd8b6c98239 should >>> be reverted and the fix backported to Linux 5.17 stable until >>> the underlying memory subsystem can provide the i915 driver >>> with an updated test for the PAT feature that also meets the >>> requirements of the author of bdd8b6c98239 without breaking >>> the i915 driver. >> I'm not a developer and I'm don't known the details of this thread and >> the backstory of the regression, but it sounds like that's the approach >> that is needed here until someone comes up with a fix for the regression >> exposed by bdd8b6c98239. >> >> But if I'm wrong, please tell me. > > You are mostly right, I think. Reverting bdd8b6c98239 fixes > it. There is another way to fix it, though. Yeah, I'm aware of it. But it seems... > The patch proposed > by Jan Beulich also fixes the regression on my system, so as > the person reporting this is a regression, I would also be satisfied > with Jan's patch instead of reverting bdd8b6c98239 as a fix. Jan > posted his proposed patch here: > > https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ ...that approach is not making any progress either? Jan, can could provide a short status update here? I'd really like to get this regression fixed one way or another rather sooner than later, as this is taken way to long already IMHO. > The only reservation I have about Jan's patch is that the commit > message does not clearly explain how the patch changes what > the nopat kernel boot option does. It doesn't affect me because > I don't use nopat, but it should probably be mentioned in the > commit message, as pointed out here: > > https://lore.kernel.org/lkml/bd9ed2c2-1337-27bb-c9da-dfc7b31d492c@netscape.net/ > > > Whatever fix for the regression exposed by bdd8b6c98239 also > needs to be backported to the stable versions 5.17 and 5.18. Sure. BTW, as you seem to be familiar with the issue: there is another report about a regression WRT to Xen and i915 (that is also not making really progress): https://lore.kernel.org/lkml/Yn%2FTgj1Ehs%2FBdpHp@itl-email/ It's just a wild guess, but bould this somehow be related? Ciao, Thorsten >>> The i915 driver relies on the memory subsytem >>> to provide it with an accurate test for the existence of >>> X86_FEATURE_PAT. I think your patch provides that more accurate >>> test so that bdd8b6c98239 could be re-applied when your patch is >>> committed. Juergen's patch would have to touch bdd8b6c98239 >>> with new functions that probably have unknown and unintended >>> consequences, so I think your approach is also better in that regard. >>> As regards your patch, there is just a disagreement about how the >>> i915 driver should behave if nopat is set. I agree the i915 driver >>> could do a better job handling that case, at least with better error >>> logs. >>> >>> Chuck >>> >>>>> I respond by saying a well-written driver should refuse to honor >>>>> the incorrect configuration requested by the user and instead >>>>> warn the user that it did not honor the incorrect kernel option. >>>>> >>>>> I am only presuming what your patch would do on my box based >>>>> on what I learned about this problem from my debugging. I can >>>>> also test your patch on my box to verify that my understanding of >>>>> it is correct. >>>>> >>>>> I also have not yet verified Juergen's patch will not fix it, but >>>>> I am almost certain it will not unless it is expanded so it also >>>>> touches i915_gem_object_pin_map() with the fix. I plan to test >>>>> his patch, but expanded so it touches that function also. >>>>> >>>>> I also plan to test your patch with and without nopat and report the >>>>> results in the thread where you posted your patch. Hopefully >>>>> by tomorrow I will have the results. >>>>> >>>>> Chuck > > From xen-devel-bounces@lists.xenproject.org Wed May 25 07:47:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336920.561362 (Exim 4.92) (envelope-from ) id 1ntlja-00087g-0K; Wed, 25 May 2022 07:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336920.561362; Wed, 25 May 2022 07:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntljZ-00087Z-T5; Wed, 25 May 2022 07:47:09 +0000 Received: by outflank-mailman (input) for mailman id 336920; Wed, 25 May 2022 07:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntljZ-0007Wh-6n for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:47:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfd6fda8-dbfe-11ec-837f-e5687231ffcc; Wed, 25 May 2022 09:47:08 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 03:47:05 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4597.namprd03.prod.outlook.com (2603:10b6:a03:12c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Wed, 25 May 2022 07:47:04 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 07:47:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfd6fda8-dbfe-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653464827; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=hS4YLAXu/RTpGVjZ78b7M85S0/0+iBOSG3LpdXZWH7s=; b=YNy0xZ7iSCEd45TUVgHgy+EiZmzDnhLqcqvfLjsximH9admKXZjABqIV fF8rkHB8mBXhmcbxgbqE06BcRHX1iZXOwhkFwsX7AQcTfTFmPeL2orInB cfmXrZ+YOSoPUn5AYPejAlCkhK0B07OavSK/VXJgDy3NeeKCGNAx0dr3F Q=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 72130438 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NeODuKuUUcLiY4p1FWZoqijfA+fnVCJfMUV32f8akzHdYApBsoF/q tZmKTiPOqyCNGWkfdAja4218kkH75HWyNNjHAFupCAxEHwa+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X5 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8DMfaXiM1AayB3KDAiEqR214btLUGG5Jn7I03uKxMAwt1IJWRvZcg9xbwyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IFmm5o26iiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3P/PFvvzODpOB3+JzrHsLJaOy7f8JMx2WAi ljexFyjWx5PYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUHBBqlz6PV50OcGTICRzsYMNg+7pZuGHoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1bUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:ERyDt61d3RbFxeY08pv7oAqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60Q5iApIs+MPP+UpgNdNvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34= X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72130438" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUClUZ29/zg4Hd7cz+20JW/1swBFdsvof49VRL98VwkncPE18oK6nFW1wL817rqzCkQxmnHm4+Av4z6mIWO17xYGSBKLchHQXH2R/MuCV8adT2bFkS4pRxDQ6PDkhf3fZpkdifnn7J1AhFGxfZwwxu+Ybxu49wOj+rzHapy8qDAXaXA79t04Cp4Gw6kaYLDSD92RfZeNIXkIdcWuRiNP6VVsC4CDTJExF6L7Xo3jwU1kMQSYzzx2DlzAw7bmqEUH7gVCioW6JF41avWKwvIH1GPXUXjZCoD4tAtt43p67mVGDBY5dX52TmlpoDdrugKbJVuRVVZADXYDTUnYwy+11w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yk7BwE3MJDhX0p2WgrTH4mJUB7QRY2Mq8AnPr34qITg=; b=guHqXRbJqB20NtSnnqReLC3whbXo0opNThyjFssXvl0JrFiKheWZRHHUaskQxOj+BIeZvelMh8lrDoHVwcm96YCD2EyIA3uvhB1CgHKTfgzS0OEBTN5PuFq+36CKZsezDPKcpilLhdtwYq+VHIXmXXXgZIcX7HUDLKh/v0PCjMoOXDd6/JPPLJHYYszml5VnvKzwC1hyOmfta1jhtiFLfwpk9uzYItMuI685TWi9YjGp5uK2OCr3eLo4ZbabHx/kAMGU7iiKhPdLZM/Aq1TAicUlz7OPTMwXsVhZ8a8SzyAa2EiXMG1YXZxDosQjNnWEsiv8PNg3ySsQfcO+JU2ybg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yk7BwE3MJDhX0p2WgrTH4mJUB7QRY2Mq8AnPr34qITg=; b=poWjuEkvzUbi8VefKaVz6AVVlKUnBdbVZYHfyCjhP6CyzxYhKoyz+oUsnpwXuBUESNWz6Or5D7GEbUCXwQXqGvJFnry4v1mlhBXid88G6GLKmtQSYWmQC0JlYDVzISIBO07G8UeFQBJCKvZi6q+QS0cSY5alP2Jb1cce6cQjfTU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 25 May 2022 09:46:59 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0252.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24da7932-9147-4342-49e9-08da3e22c248 X-MS-TrafficTypeDiagnostic: BYAPR03MB4597:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qHdlQ25sc705+cB4xbhj9Jj8XQ36QWtMyKy/VTWSMW9uZxKWl+9pAKBNVsbmeA40zQpVNftyMBsWJVkzu0LJGAKUYpDXdT5B/vWyMVFAgfVH6Q2aq9gfhP4AzZQxJ6JSXE2eSB6CE6IBAglrDjVusnIUkOUdX1OMbpQwSthCxvyLb4Gk66Hk+IyiIJgoWQBtvZBkeahy8th6LSw5GOqOqdf4vR/z48PDr/eIknshGxEEodzcgsgdMcZ4aRAb2VXJwQ3z/ySsTFfB247XunHRIXS3T6A/jBF1oaBiaxlViL/ciavQ7L0SbWK/jlauFvK4L9peG4wdJMQeSQ6LSzKXLFgNuV4Ux4YuXS/RnyerninKJRyt5zQeIRJFl7NHZz1E62cTiV/owx2sf9b7hAX5nrD7DtEVzzIt65t+O5NFCSu/Q6VCD3mXBklsDC18tEjuPJdFUiVXCzCs/gJ+m+ShKawZagvDis0siLxmUGupREi7SA6m9Lu1LHE7b988QQXWRzhPQThBchiQmrEYZ9D94bd/3JDTlLK7UsO2j4wU9asEmbPpiUkrq/gnNNPrAvasRMajeuiz7Igoi1Wu9J5b4B0PVQ1nFjunOCZNMkIS578wVqnFTBTFEBKbd2uqzt1NHSL3e9QXjq7wEZsmDTh2WQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(38100700002)(66476007)(66556008)(66946007)(4326008)(53546011)(2906002)(82960400001)(86362001)(26005)(5660300002)(6916009)(6506007)(8936002)(85182001)(9686003)(6512007)(54906003)(33716001)(6486002)(6666004)(508600001)(186003)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGJrNXNkNTkxMXJFaEdvRXJjdXRDQkwvS3ZYV0pFQTY2M2R0Zk9NbGJETkFx?= =?utf-8?B?cXBVMmN3OEMrTDlDeGRlN3dLT1hMVEljYktzUXhhQ2dFV3daMlVUcyttY0lU?= =?utf-8?B?d1VhK2cyNkdtd1F3bTF2TlFkRXJxRm80WWVETEZ4eTNjVWQ2b1Q0a0MyUkEy?= =?utf-8?B?N3hucllaaFdkZGljdEFuVkFzdm9IeGJoeTVyajZ3RVNuYzBpczlZZ1UrbUhp?= =?utf-8?B?UVR3bSs5a2JlVXZTSnRqSUp1eGovVU4yZDFZVUNFZ2lvck5zRkJWRFViQUpY?= =?utf-8?B?MmgrVjRmSDBiZEpUdyszS3ZnZ0FIdGdySzZqNWJJNzVQUVgvNzJwUm9YSDRR?= =?utf-8?B?UnlNb0JpVklvZzU2WkRscFhGVVBhcytTbFlSS1JKRmJVaVRwTms5MnZHN2tH?= =?utf-8?B?ODBnc1pDVThvTFdUT0lVeU9SSEJYRlpMOTNDdVJZV0JkVjVzUE9VMEx5R1FT?= =?utf-8?B?V1N3Wkh1U2VLeG4xYktNMkFBY21GQm96eGNFdHUyaldzT0pLRU15aVF3QU85?= =?utf-8?B?YnVhV1RtajJDS1pKTDdjcmg4dk51TWtNWnNteHRFWjZoMkx0VVdyZTJrcEts?= =?utf-8?B?TWQwREx3cHNid0NpVDZTT2Q4UXBlQmZFMTBNREtzQUV4K0JpbTY2V0o1ZVVV?= =?utf-8?B?eWU4K1UxQnpuWkpmcnFaMGM2Ynhqazhxdmw4MWRHRjgzUjBNU3U1bE81a0Y2?= =?utf-8?B?VC9KQ3NWVGp3T3ZFOWpkMU5sZWRreTIwV3dvWk1ZUGRWTWxRQ1VXZlBHRWhr?= =?utf-8?B?ODdNdDkrRzdBZU83RjU4bmdhWXlSSkdwMkUyRjU3LzFKUVdycE11cEViOEZJ?= =?utf-8?B?K3VpUW8wWlc2YWR6MUxUMlBXMFkvVGhBZi9jSzdhNnNyR1grY2prWXV4WkNp?= =?utf-8?B?a1hmMXYyTnZLMmZ1VTFxYVc2Z3V3NFJZZUx3Vm9HNm96Nkk5UmU0dy9zSmpq?= =?utf-8?B?eG1yWXRtRkl4K0ZlcHlQalpjV0RLSE5oU1E5OHc1WFRmWGJWUHJFYm03a1Q4?= =?utf-8?B?eE00MzJ1ZE1ZTUZ3MlJCdmhhZmh1Rm13a0VIZVdPbWU4RGQ0Z29pcStTNHhl?= =?utf-8?B?QnZmcmVmekw5eHlRQlJuV0p0V2d4citzNWZQeTVDRFZPZFBYYWxiS2xORlVW?= =?utf-8?B?MFEvRHZ4NDBDeWpZV055TVBEczV6Wlh0NnRsME1IYmg3dm1WaXYwUEYxUS9z?= =?utf-8?B?VjI2aFlDRTNjNTFDcnZ3eWFDd2xjK1NoOXEzWCt1Mk5DejlMd0xjQ3Y3Zmxw?= =?utf-8?B?aUJVUTVxdGs5V3BjR0lvclRoV1FaRWFVT0dTckI1ckdQRDl3YXM3aEFwSDMx?= =?utf-8?B?b0N6OTB2ekJJUGdTYVp0YXNMYzZxYXhJZUxvelJqcWZXUEUyQ0M1d2dmMDVU?= =?utf-8?B?RGlqaFBJSkVzZHJJVUtyWUh4TVpTSnlnQW5RaUhOMGJXMUo0eDkzTEtUV2x6?= =?utf-8?B?WmhmM1pOdWdZUzlmdE9aOWs0WDRaQ280dlQ1T2NzRkRoaUxTZnhiRlhEMmtz?= =?utf-8?B?eUE2MWtaYWhRL0JPUlNjcFQ0VjhQNmdWWnBWbWlVcGFPRWJMbGF4ajFyUnF6?= =?utf-8?B?bGFhZ25BSlNma05TTnVUTG04d3RPK2w1a2xXTWdFYzdhV3VJdkFzVDlFeGRa?= =?utf-8?B?OWlycmJtN1ZzNHN2WGYrb0xUQmxhVmVHU21tNUZ2M09XNFgzTjNtNjBaWnAv?= =?utf-8?B?WWJQVmlTNXIxMGR5V3BUQXcwTDdXVWEydy9yUmlkNEJqMWhwdFY0V1ZyQXN4?= =?utf-8?B?TmlkaFo1b2tWMkF6c1JrelJHREF0ZURMMzhXb3dGVm45aGZEa1B0WUFjbERH?= =?utf-8?B?bytyUVE1THcxSm5SdnlnUU1PQUhkTkNmc2FoeGVPSHZKTWpuWE4yU3diNlRq?= =?utf-8?B?Q0xVVllvbndtVDhzbFFqS2dEcGF4OHcwZTd0dk5vOGowc2tuNGVSWVVqL004?= =?utf-8?B?SkcyRUhFM250TkNCSXJTSjRGOEFSMytBbjZyd3E2WG5RbWtJcS90OEVrVTJZ?= =?utf-8?B?WFY5a0ZPQmdJNm5ibWNzczNOQktETXN1cDUyazZDa1JMeFFHY1JKcXR0ZExR?= =?utf-8?B?ODR3SG93Y3dLZWZwNUxla3lKWDhkVitnVURaRUsvcFdmYzZvUFZndjRUVUdP?= =?utf-8?B?TkM2SDNxcEw5RjNBWkxDZDVlREcxNVFucXVHUGxqVzlZL25zbE92YlpRTTZ3?= =?utf-8?B?MUJDKy91bXhRUEtDS0g3djFvMVErNmJxdm1VVmxpVytDa1JaZ0d5cDNqUzNy?= =?utf-8?B?ZHdTajh3V3ptNm5kMG1EVDd0Qzh2L1BWVU1IZndSaGtxRGdhSi8xaDNiZ2FK?= =?utf-8?B?YkFPZllNWnk3cDRuZDZWcmFyUlNXWlVPa0ZxY28xWU9zelZ4YlEzRitERFdC?= =?utf-8?Q?7ykHKe0qyp1UahLQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24da7932-9147-4342-49e9-08da3e22c248 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 07:47:03.8173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2G6eqTAYV4hSSeUrbjOQAxh5i66P65qmZMulwv1ydLU9piBYYCbDhcN0Wq5pTb7N14D2wuSI8J5UumkwvV0b6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4597 On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: > On 25.05.2022 09:21, Roger Pau Monné wrote: > > On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: > >> On 24.05.2022 18:46, Roger Pau Monné wrote: > >>> Would you be fine with adding: > >>> > >>> Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as > >>> it's main purpose is to prevent the usage of the hypervisor assisted > >>> flush if available, not to force the sending of an IPI even for cases > >>> where it won't be sent. > >> > >> Hmm, yes, that's even more verbose than I would have expected it to > >> be. Just one point: I'm not sure about "main" there. Is there really > >> another purpose? > > > > Right, I should remove main. > > > >> Of course an alternative would be to rename the flag to properly > >> express what it's for (e.g. FLUSH_NO_HV_ASSIST). This would then > >> eliminate the need for a comment, afaic at least. > > > > I think it's likely that we also require this flag if we make use of > > hardware assisted flushes in the future, and hence it would better > > stay with the current name to avoid renaming in the future. > > > > Whether the avoidance of sending the IPI is due to hardware or > > hypervisor assistance is of no interest to the caller, it only cares > > to force a real IPI to be sent to remote processors. > > Well, then it could still be named FLUSH_NO_ASSIST, since as said > (and as you look to agree with) there's no IPI being forced in the > general case. That would be fine but I don't think it's OK to do in this patch. Could do as a prereq if you want, but we should keep in mind the patch under discussion is fixing a boot regression, the fact that it doesn't trigger in osstest is just because there's no hardware with CET Shadow Stacks support in the colo. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 25 07:48:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:48:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336926.561373 (Exim 4.92) (envelope-from ) id 1ntlkR-0000Gd-CO; Wed, 25 May 2022 07:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336926.561373; Wed, 25 May 2022 07:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlkR-0000GW-88; Wed, 25 May 2022 07:48:03 +0000 Received: by outflank-mailman (input) for mailman id 336926; Wed, 25 May 2022 07:48:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlkQ-0000GN-6R for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:48:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlkP-0002k3-8r; Wed, 25 May 2022 07:48:01 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntlkP-0002x6-17; Wed, 25 May 2022 07:48:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ojJv09GjFU+wZyEZssVEgnBPHP8i8DHpfraehRPv8zs=; b=L9TsFPkHrIZaDYGVwDEOTmUIza mAbXDhwm63ZKQgj1hwNUaYEqEI0gwkL/eZYjtE5rE3f6ZT4feZnjm1sxIt1FtgmlwrdHCEMuobKJv +gyM1E9bviP1YuAxfHVhDiQMxfF2lXt3TCcts06Cs1Uo8CYLthMdaq41S2WnFz75qfI0=; Message-ID: <990378d9-4926-ce37-ba44-cf1878e12fdd@xen.org> Date: Wed, 25 May 2022 08:47:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] init-dom0less: better snprintf checks To: Stefano Stabellini , xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Volodymyr_Babchuk@epam.com, lucmiccio@gmail.com, anthony.perard@citrix.com, wl@xen.org, Stefano Stabellini References: <20220524233544.245741-1-sstabellini@kernel.org> From: Julien Grall In-Reply-To: <20220524233544.245741-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 25/05/2022 00:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > snprintf returns the number of characters printed. A return value of > size or more means that the output was truncated. > > Add a check for that in init-dom0less. > > Signed-off-by: Stefano Stabellini Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 07:52:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:52:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336937.561383 (Exim 4.92) (envelope-from ) id 1ntloF-0001jS-TB; Wed, 25 May 2022 07:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336937.561383; Wed, 25 May 2022 07:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntloF-0001jL-QI; Wed, 25 May 2022 07:51:59 +0000 Received: by outflank-mailman (input) for mailman id 336937; Wed, 25 May 2022 07:51:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntloE-0001jF-TK for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:51:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d2c5d4e-dbff-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 09:51:57 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-wLnLSTpmO9eJUtMQ4unHWg-1; Wed, 25 May 2022 09:51:56 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5105.eurprd04.prod.outlook.com (2603:10a6:208:c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 07:51:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 07:51:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d2c5d4e-dbff-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653465117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pn9rtXE42ijJYNgTY9Rj6MHE2GKtk7QSXn3pCApUFp4=; b=JjVcvaeInc0TO/gq2PFj5zEw1g4012yN2nmjCN5zjd3WOOjHmdaOQAK404TtKfmn4fAeys FVTwSiF9lH4x/Q88vKmnOlWsYMpq4++UACgqY3ObMyiIqNaAJeiArmXezuiJdIxpPk5y3a SNaXLsV7diXxK3osotIDuwV9gayjsbE= X-MC-Unique: wLnLSTpmO9eJUtMQ4unHWg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4EyOO7l/QyWERSbE1PkKrbetKeFv9CqkP03UFOazBFzua3veM12MgmHI+5w/kA5cDgv7xilok0uuHgoJoT8AMTafy2/IMD+wIVlU3rq4mu/npWI4gHmEOFfAaLG0ehJbFs/zznrNB7W7OEK/g0R5Z+vxswbSFDqcqmk496Qji16SYIEgMoOt0NtGhuti/O+iX8nMsH6Uzj0Ma8yFeFGqIPYe12UOF2bqKXuHCVPNSUl2EttaknBbJULO7bO5EMbyvjoYY4uP+cw2cwch8OZvpmHLvI5wbHegzpOLO1pnaBLrne83t6m/640jgyKso9gWOWkLWyGcnuZKlShPMyK4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HNhs6ubdAZz+cSCatdMToC3lcz9U6UQA5mJlDDIeuj8=; b=H61C+a2nEdTpGaAX8RYS2Os0Kh8TvxjNYO7fhmbPKfrtAw7UrT8MmERAQzQfQTdtDDhz+6biGjZKs7wDI4IzDaiflKOAv5gXBMyVBaw50xWvt9i6Qs1i/1DN88vSQQOBrcWx18MgUlvTz/GxPh3Fe795mAt5IA4TRhwbZU2Lp4kj92bldrAm3+ti+B3be/VIgaIWwmu2EP/YuV9HVAgzQFUICfQOSpGTujQKzDSNEjFfTBfUsgx3ZriEz6ynZl3lW13vURUFhI9VcgSUK1ISqg6K5eOWEFDll2ifQKkQYA6G5xqQ7OXjGFnduxbsrS1j+5j+hRDhPWtF7NTXQiAxtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 09:51:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220524105052.5210-1-roger.pau@citrix.com> <1b0b643b-a906-13ba-d414-feedc98428d3@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6812e1a7-e24a-4b01-9065-08da3e236ff3 X-MS-TrafficTypeDiagnostic: AM0PR04MB5105:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lLJnUQquq+iqp+Ys+ToWIV53mBH/9V3uAJlWjMOiQ1Yr/lHghHZYA2X57Vy1C6odkRNSXHjR6tAXoJLauqcp3miMeLGhjTFYNnF/ks8NZAwshbKUuEKKwMxtW3oIPJbOeB+DTrfEhPVMVovRXXZjLlXR3mTA90Ccf0F6zSlaGL4ye7lMU1M3wSdWJgq0bGsHBAYgQO0TT+dMkePcpcwm4UCJwMx2EEFT1o5AXt5VF98Ih4vVqlcf8g3ZbksxL1u1vHNGsJNs+K0w8o+9rZpdnG4ctim3aq1/Wp6ILeh43zIAqiittyOujFnnv5XM/Jz5VRb6NyljSvGoMYH4tDBFrOy0g6eNuXhxVz50tJYmHe5x5Jn2x/C+ww/vxlI9xsemL0l+CuE+RF4oTdsdkcpq/YODYL3SWqOleEzD8j/TrEUiWXHuYYgYWBscKuIBR34LDblffbCbn3NgVSDiWNbeIvAUUh9AuvWnTUu8QIWp+wRpjdTdrA617reEoX/FKDeWV6dAuRaFBwMyXb/StvRYzlfBIfh/mF0GYh+MMMzn76eAfwuG1UsapC5hIy5y9ohjnSEpDBfrIhpedi3dErQ+eztvL5ZT29TrFyZJFpotpBKM3EVLkpeRHsKQLDw9wT79gzZEoQFWHxXCPV/PwzuIBRHP4iRmaI8P88RB0YRxLmp4FmJ0z09+2bXgw46sw15Gd3Y6MRiauWIkj7PUqhyCRwFah9xY/Hq+xJKgZHE/1kTHeByix+C1CLikEBvQCxgG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(54906003)(2906002)(86362001)(53546011)(186003)(6916009)(2616005)(31686004)(38100700002)(26005)(8936002)(66946007)(5660300002)(4326008)(66556008)(6512007)(66476007)(8676002)(6506007)(316002)(6486002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sqvlkIdk1NWgLwh/mnbMLGU2P/3mbXjuWqrksXG9SiJdptbzLW1wgqj4wo3J?= =?us-ascii?Q?EaYMMbYs2ebCVXguU/I2PgRjz/RJZAkTL/k4arBjWMMDS8V77j01PeLif/vK?= =?us-ascii?Q?2Fno+nQXFTX5Y/p7E0hKQabWPnMxTGuyJkF4pOcvRvlbAJub6LWZA0T+Ea2k?= =?us-ascii?Q?eGwIRxOXwhbfUngY+hkMFXfUyiDxKQ5898E+7SCI2CK+sVZgQw0Tu0Efyjio?= =?us-ascii?Q?A9gTv+z0KJJAE3pKkdXyPnoOE8D4w9E+N41O1WlGOmERIUz7IWSN6V5FGZIQ?= =?us-ascii?Q?+VAE7EGhPUJd8vJ145sBZea+WF1DFNM0dnWXuKMtT4KLcVve2oKUsYffpgE0?= =?us-ascii?Q?pbYvIRcNsABRYnbmUyEugquBeBqUvVY83BKAKWmIL86HXTbUomZT0CPLk5zo?= =?us-ascii?Q?Xluxa9nJp4yYAzK1l5Ur6dV/Mc7NqHobvzmLLtyNNcnXIUAAHEi4Kr7R6uWS?= =?us-ascii?Q?ytRtF73SEO5dCv1tF+gorMBFLQHp6ITTgSQ9aKo3EEKGHnocJRTAAEwff4Lr?= =?us-ascii?Q?Y4ZM792zKugmxE+HEx/2Rfg6SlDwjxveDlADP+zYpHCIy0ITn3IPjz4oxiE6?= =?us-ascii?Q?34Jw4gLcSrl+7lvaq/EjZ6RWnAeUMKn1GYFn7LHyhw3bUEX+QNyOo52eh17b?= =?us-ascii?Q?XwzQST1YLzMNGku/9o4GUOvvAtQRgJY7LNYqza+bXsN/H59FEqHFKV9maZKX?= =?us-ascii?Q?zT8rYDPm3O0xwGvWoC51eV3psMWJqIzX8+B7DLskfG57gwKAZna4O85Qli+c?= =?us-ascii?Q?VTw3WhBs9k3PdZB9MHveU5sC6fR9owcqDdYV+V0V9stsdVwxBOFs6VfV2LgW?= =?us-ascii?Q?WagjVAuae/hTYVsEMjgEg+oHtD9b55usCCid6NA7T+G8HGc/8FlpG4PgQU+Z?= =?us-ascii?Q?l2Da2qqlAvk97UA2WUR8F5zhRNYOom5S1dS+qr0yM83yvYvwaPHVSI41hniE?= =?us-ascii?Q?mQ1LmiVV5XLB1BfxMbfOcFFF7o3LYeuNC3CwwAPfaLxVz4UEx9tfIqJqP5X1?= =?us-ascii?Q?3xxuZOp4ApvTm9zyqYgOq3Ymgg1FnzrizdZ1VQBTykT23KcLnbh5Z58qRtEi?= =?us-ascii?Q?Y2rXJ5Ke7lELwvrlQvioVm3ddrpqZSNljPzIZYiNHJE78pP3EqvUGIgcW9bf?= =?us-ascii?Q?DSmV168orY1OeB+/3+iL3SicmEvSqA+4Ep+QrLxhYyISfqdrnJXdT7RTV5e5?= =?us-ascii?Q?K3vvdTKj0J+JfXxshsL8tUknvT9BOEF0EVPq1sCVCglFtTY6li7tGvjzh5RW?= =?us-ascii?Q?1N02noFCnU5qaEoFMtdyh/3zW9oeSSlXOiQsax8OPQIfWR+BvaOufClA5H/U?= =?us-ascii?Q?pcMd0A0oRYBFR8ww+dxv9JAamaCVT7Q1QYDyzMw7dzMUnWTtmxl61UJcwoy6?= =?us-ascii?Q?RjSYkZENJovgKkGJOVRq3w28a8gxqhCmBjMJ+11dpgUiNKJG6OiY2eE3zkrr?= =?us-ascii?Q?HB4posk9HuSx9KiyxYst/C+Y7K7VH15r/o+wu7yMU4isEjAwJT64I1gagdBC?= =?us-ascii?Q?TO6V2QX3jZ5Yi1+1S2km3tzR5Inwimz5+nE4sT8zg7L/db4RxtvEWGiIz68p?= =?us-ascii?Q?Dhx0EBYKWHfrKHn1Mh2QNY6s8ogU9IhLq/m1jXVnnBod6hKNAgGuR1exRnPG?= =?us-ascii?Q?+dbvO8RcI0voth7YepFQJh3HECbuiYHAk8xz602vZg0diByEdTV/K5mC/PT6?= =?us-ascii?Q?6bB3SN9gvHdNL2WRi4unekEuDxO6NTxNsZqoVQvGSuilUBX/8FBsyID9PHp2?= =?us-ascii?Q?vVqetT0QsA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6812e1a7-e24a-4b01-9065-08da3e236ff3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 07:51:55.0138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8+ydYnSnze/yMs1yXizfXik9HTtePhLg2VOVm4sv79BsgOp3BC88lNUIQ0BXAR8T/bFRTQ99FF8cHMR3dxmD0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5105 On 25.05.2022 09:46, Roger Pau Monn=C3=A9 wrote: > On Wed, May 25, 2022 at 09:34:32AM +0200, Jan Beulich wrote: >> On 25.05.2022 09:21, Roger Pau Monn=C3=A9 wrote: >>> On Wed, May 25, 2022 at 08:02:17AM +0200, Jan Beulich wrote: >>>> On 24.05.2022 18:46, Roger Pau Monn=C3=A9 wrote: >>>>> Would you be fine with adding: >>>>> >>>>> Note that FLUSH_FORCE_IPI doesn't need to be handled explicitly, as >>>>> it's main purpose is to prevent the usage of the hypervisor assisted >>>>> flush if available, not to force the sending of an IPI even for cases >>>>> where it won't be sent. >>>> >>>> Hmm, yes, that's even more verbose than I would have expected it to >>>> be. Just one point: I'm not sure about "main" there. Is there really >>>> another purpose? >>> >>> Right, I should remove main. >>> >>>> Of course an alternative would be to rename the flag to properly >>>> express what it's for (e.g. FLUSH_NO_HV_ASSIST). This would then >>>> eliminate the need for a comment, afaic at least. >>> >>> I think it's likely that we also require this flag if we make use of >>> hardware assisted flushes in the future, and hence it would better >>> stay with the current name to avoid renaming in the future. >>> >>> Whether the avoidance of sending the IPI is due to hardware or >>> hypervisor assistance is of no interest to the caller, it only cares >>> to force a real IPI to be sent to remote processors. >> >> Well, then it could still be named FLUSH_NO_ASSIST, since as said >> (and as you look to agree with) there's no IPI being forced in the >> general case. >=20 > That would be fine but I don't think it's OK to do in this patch. >=20 > Could do as a prereq if you want, but we should keep in mind the patch > under discussion is fixing a boot regression, the fact that it > doesn't trigger in osstest is just because there's no hardware with > CET Shadow Stacks support in the colo. Sure - I'll be okay either way, with a preference to the rename over the addition of a comment. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 07:53:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 07:53:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336945.561395 (Exim 4.92) (envelope-from ) id 1ntlq0-0002KT-8B; Wed, 25 May 2022 07:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336945.561395; Wed, 25 May 2022 07:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlq0-0002KM-5E; Wed, 25 May 2022 07:53:48 +0000 Received: by outflank-mailman (input) for mailman id 336945; Wed, 25 May 2022 07:53:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlpy-0002Ju-If for xen-devel@lists.xenproject.org; Wed, 25 May 2022 07:53:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntlpy-0002qc-8S; Wed, 25 May 2022 07:53:46 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntlpy-0003Cv-0P; Wed, 25 May 2022 07:53:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6XRMyhjASiEEJfB1poaas4uLIGf9hJxiZhNXLOC21UI=; b=wHfYe5rm3H2ZNk482w5SSfekrr /IClC61VEcgpNle4LiDEujwjD/SHUf1kQW1TZql8uwyI0QWjILYMds/yNpOHKNOgLgXNPJ7a2XScV aSr1fJCorO+NoMSKuEU+Iux27cE5KFbhqGbXq0OcFMohSMDcM9soRV5U6AsdhmMtFb9w=; Message-ID: Date: Wed, 25 May 2022 08:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIHY1IDMvNl0gYXJtNjQvZmluZF9uZXh0?= =?UTF-8?B?X2JpdDogUmVtb3ZlIGV4dDJfc3dhYigp?= To: =?UTF-8?B?TGluIExpdSDvvIjliJjmnpfvvIk=?= , "xen-devel@lists.xenproject.org" Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <1075e4a2-eb7c-6441-28c4-7dbc871f844d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 24/05/2022 02:35, Lin Liu （刘林） wrote: > >>> Hi, > >>> On 23/05/2022 15:50, Lin Liu wrote: >>> ext2 has nothing to do with this logic. > >> You have again not addressed my comment. If you don't understand my comment then please ask. > >> Cheers, > >> -- >> Julien Grall > > Sorry I missed this one as I saw this patch already got an some tags, For smaller changes, we tend to provide the Reviewed-by/Acked-by at the same time. The comments may then be addressed on commit (if the committer is happy with that) or you could handle them on a respin. > I suppose your comment requires commit message update, Yes. I would like the first sentence to be dropped or reworked. > Will update it if a newer version is required. Thanks! I would have committed now but AFAIU it depends on previous patches. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 08:04:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336958.561406 (Exim 4.92) (envelope-from ) id 1ntm0U-0004Qc-Kt; Wed, 25 May 2022 08:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336958.561406; Wed, 25 May 2022 08:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm0U-0004QV-HR; Wed, 25 May 2022 08:04:38 +0000 Received: by outflank-mailman (input) for mailman id 336958; Wed, 25 May 2022 08:04:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm0T-0004QP-NL for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:04:37 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50ec3c8f-dc01-11ec-837f-e5687231ffcc; Wed, 25 May 2022 10:04:36 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D242821A2C; Wed, 25 May 2022 08:04:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A0E913ADF; Wed, 25 May 2022 08:04:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ecAVARLjjWLhKAAAMHmgww (envelope-from ); Wed, 25 May 2022 08:04:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50ec3c8f-dc01-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653465874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u54F3tBmZy4oEFFTEii/zsvHbSaqW5NzYzMHIue11NU=; b=qr6HgqRj4PEUo3/fXiBQRoD33u8fWnrhW12UNFY0flwr/f0PC+eeIwANzVMPLYDLxw4M6q CkU02Yg+tyBQxTDJvYfOQl1nFeR4HAW8Zd2zHYWB0JCB8Av5oZg0twLhSs6hru2kDPKZxI 6sYDAUrljLpfA0C8y4T4zmOpbZ5cXEA= Message-ID: <1cb5b845-a326-ce60-3a08-c2e13fe6d4ad@suse.com> Date: Wed, 25 May 2022 10:04:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Thorsten Leemhuis , Chuck Zmudzinski , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> From: Juergen Gross Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BfyGk3XKVACj6W41lAYZo2BD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BfyGk3XKVACj6W41lAYZo2BD Content-Type: multipart/mixed; boundary="------------53G0UGMnr335AXWugItqKkAF"; protected-headers="v1" From: Juergen Gross To: Thorsten Leemhuis , Chuck Zmudzinski , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: <1cb5b845-a326-ce60-3a08-c2e13fe6d4ad@suse.com> Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> In-Reply-To: --------------53G0UGMnr335AXWugItqKkAF Content-Type: multipart/mixed; boundary="------------1JYoJE0gc0gGkSGQBbWTf8g3" --------------1JYoJE0gc0gGkSGQBbWTf8g3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjUuMDUuMjIgMDk6NDUsIFRob3JzdGVuIExlZW1odWlzIHdyb3RlOg0KPiANCj4gDQo+ IE9uIDI0LjA1LjIyIDIwOjMyLCBDaHVjayBabXVkemluc2tpIHdyb3RlOg0KPj4gT24gNS8y MS8yMiA2OjQ3IEFNLCBUaG9yc3RlbiBMZWVtaHVpcyB3cm90ZToNCj4+PiBPbiAyMC4wNS4y MiAxNjo0OCwgQ2h1Y2sgWm11ZHppbnNraSB3cm90ZToNCj4+Pj4gT24gNS8yMC8yMDIyIDEw OjA2IEFNLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IE9uIDIwLjA1LjIwMjIgMTU6MzMs IENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4+Pj4gT24gNS8yMC8yMDIyIDU6NDEgQU0s IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+PiBPbiAyMC4wNS4yMDIyIDEwOjMwLCBDaHVj ayBabXVkemluc2tpIHdyb3RlOg0KPj4+Pj4+Pj4gT24gNS8yMC8yMDIyIDI6NTkgQU0sIENo dWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4+Pj4+Pj4gT24gNS8yMC8yMDIyIDI6MDUgQU0s IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+Pj4+PiBPbiAyMC4wNS4yMDIyIDA2OjQzLCBD aHVjayBabXVkemluc2tpIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4gT24gNS80LzIyIDU6MTQgQU0s IEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+Pj4+Pj4+Pj4gT24gMDQuMDUuMjIgMTA6MzEs IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4+PiBPbiAwMy4wNS4yMDIyIDE1OjIy LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4+PiAu Li4gdGhlc2UgdXNlcyB0aGVyZSBhcmUgc2V2ZXJhbCBtb3JlLiBZb3Ugc2F5IG5vdGhpbmcg b24gd2h5DQo+Pj4+Pj4+Pj4+Pj4+IHRob3NlIHdhbnQNCj4+Pj4+Pj4+Pj4+Pj4gbGVhdmlu ZyB1bmFsdGVyZWQuIFdoZW4gcHJlcGFyaW5nIG15IGVhcmxpZXIgcGF0Y2ggSSBkaWQNCj4+ Pj4+Pj4+Pj4+Pj4gaW5zcGVjdCB0aGVtDQo+Pj4+Pj4+Pj4+Pj4+IGFuZCBjYW1lIHRvIHRo ZSBjb25jbHVzaW9uIHRoYXQgdGhlc2UgYWxsIHdvdWxkIGFsc28gYmV0dGVyDQo+Pj4+Pj4+ Pj4+Pj4+IG9ic2VydmUgdGhlDQo+Pj4+Pj4+Pj4+Pj4+IGFkanVzdGVkIGJlaGF2aW9yIChv ciBlbHNlIEkgY291bGRuJ3QgaGF2ZSBsZWZ0IHBhdF9lbmFibGVkKCkNCj4+Pj4+Pj4+Pj4+ Pj4gYXMgdGhlDQo+Pj4+Pj4+Pj4+Pj4+IG9ubHkgcHJlZGljYXRlKS4gSW4gZmFjdCwgYXMg c2FpZCBpbiB0aGUgZGVzY3JpcHRpb24gb2YgbXkNCj4+Pj4+Pj4+Pj4+Pj4gZWFybGllcg0K Pj4+Pj4+Pj4+Pj4+PiBwYXRjaCwgaW4NCj4+Pj4+Pj4+Pj4+Pj4gbXkgZGVidWdnaW5nIEkg ZGlkIGZpbmQgdGhlIHVzZSBpbiBpOTE1X2dlbV9vYmplY3RfcGluX21hcCgpDQo+Pj4+Pj4+ Pj4+Pj4+IHRvIGJlDQo+Pj4+Pj4+Pj4+Pj4+IHRoZQ0KPj4+Pj4+Pj4+Pj4+PiBwcm9ibGVt YXRpYyBvbmUsIHdoaWNoIHlvdSBsZWF2ZSBhbG9uZS4NCj4+Pj4+Pj4+Pj4+PiBPaCwgSSBt aXNzZWQgdGhhdCBvbmUsIHNvcnJ5Lg0KPj4+Pj4+Pj4+Pj4gVGhhdCBpcyB3aHkgeW91ciBw YXRjaCB3b3VsZCBub3QgZml4IG15IEhhc3dlbGwgdW5sZXNzDQo+Pj4+Pj4+Pj4+PiBpdCBh bHNvIHRvdWNoZXMgaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoKSBpbg0KPj4+Pj4+Pj4+Pj4g ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX3BhZ2VzLmMNCj4+Pj4+Pj4+Pj4+ DQo+Pj4+Pj4+Pj4+Pj4gSSB3YW50ZWQgdG8gYmUgcmF0aGVyIGRlZmVuc2l2ZSBpbiBteSBj aGFuZ2VzLCBidXQgSSBhZ3JlZSBhdA0KPj4+Pj4+Pj4+Pj4+IGxlYXN0DQo+Pj4+Pj4+Pj4+ Pj4gdGhlDQo+Pj4+Pj4+Pj4+Pj4gY2FzZSBpbiBhcmNoX3BoeXNfd2NfYWRkKCkgbWlnaHQg d2FudCB0byBiZSBjaGFuZ2VkLCB0b28uDQo+Pj4+Pj4+Pj4+PiBJIHRoaW5rIHlvdXIgYXBw cm9hY2ggbmVlZHMgdG8gYmUgbW9yZSBhZ2dyZXNzaXZlIHNvIGl0IHdpbGwgZml4DQo+Pj4+ Pj4+Pj4+PiBhbGwgdGhlIGtub3duIGZhbHNlIG5lZ2F0aXZlcyBpbnRyb2R1Y2VkIGJ5IGJk ZDhiNmM5ODIzOQ0KPj4+Pj4+Pj4+Pj4gc3VjaCBhcyB0aGUgb25lIGluIGk5MTVfZ2VtX29i amVjdF9waW5fbWFwKCkuDQo+Pj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+Pj4gSSBsb29rZWQgYXQg SmFuJ3MgYXBwcm9hY2ggYW5kIEkgdGhpbmsgaXQgd291bGQgZml4IHRoZSBpc3N1ZQ0KPj4+ Pj4+Pj4+Pj4gd2l0aCBteSBIYXN3ZWxsIGFzIGxvbmcgYXMgSSBkb24ndCB1c2UgdGhlIG5v cGF0IG9wdGlvbi4gSQ0KPj4+Pj4+Pj4+Pj4gcmVhbGx5IGRvbid0IGhhdmUgYSBzdHJvbmcg b3BpbmlvbiBvbiB0aGF0IHF1ZXN0aW9uLCBidXQgSQ0KPj4+Pj4+Pj4+Pj4gdGhpbmsgdGhl IG5vcGF0IG9wdGlvbiBhcyBhIExpbnV4IGtlcm5lbCBvcHRpb24sIGFzIG9wcG9zZWQNCj4+ Pj4+Pj4+Pj4+IHRvIGEgaHlwZXJ2aXNvciBvcHRpb24sIHNob3VsZCBvbmx5IGFmZmVjdCB0 aGUga2VybmVsLCBhbmQNCj4+Pj4+Pj4+Pj4+IGlmIHRoZSBoeXBlcnZpc29yIHByb3ZpZGVz IHRoZSBwYXQgZmVhdHVyZSwgdGhlbiB0aGUga2VybmVsDQo+Pj4+Pj4+Pj4+PiBzaG91bGQg bm90IG92ZXJyaWRlIHRoYXQsDQo+Pj4+Pj4+Pj4+IEhtbSwgd2h5IHdvdWxkIHRoZSBrZXJu ZWwgbm90IGJlIGFsbG93ZWQgdG8gb3ZlcnJpZGUgdGhhdD8gU3VjaA0KPj4+Pj4+Pj4+PiBh biBvdmVycmlkZSB3b3VsZCBhZmZlY3Qgb25seSB0aGUgc2luZ2xlIGRvbWFpbiB3aGVyZSB0 aGUNCj4+Pj4+Pj4+Pj4ga2VybmVsIHJ1bnM7IG90aGVyIGRvbWFpbnMgY291bGQgdGFrZSB0 aGVpciBvd24gZGVjaXNpb25zLg0KPj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+PiBBbHNvLCBmb3Ig dGhlIHNha2Ugb2YgY29tcGxldGVuZXNzOiAibm9wYXQiIHVzZWQgd2hlbiBydW5uaW5nIG9u DQo+Pj4+Pj4+Pj4+IGJhcmUgbWV0YWwgaGFzIHRoZSBzYW1lIGJhZCBlZmZlY3Qgb24gc3lz dGVtIGJvb3QsIHNvIHRoZXJlDQo+Pj4+Pj4+Pj4+IHByZXR0eSBjbGVhcmx5IGlzIGFuIGVy cm9yIGNsZWFudXAgaXNzdWUgaW4gdGhlIGk5MTUgZHJpdmVyLiBCdXQNCj4+Pj4+Pj4+Pj4g dGhhdCdzIG9ydGhvZ29uYWwsIGFuZCBJIGV4cGVjdCB0aGUgbWFpbnRhaW5lcnMgbWF5IG5v dCBldmVuIGNhcmUNCj4+Pj4+Pj4+Pj4gKGJ1dCB0ZWxsIHVzICJkb24ndCBkbyB0aGF0IHRo ZW4iKS4NCj4+Pj4+Pj4+IEFjdHVhbGx5IEkganVzdCBkaWQgYSB0ZXN0IHdpdGggdGhlIGxh c3Qgb2ZmaWNpYWwgRGViaWFuIGtlcm5lbA0KPj4+Pj4+Pj4gYnVpbGQgb2YgTGludXggNS4x NiwgdGhhdCBpcywgYSBrZXJuZWwgYmVmb3JlIGJkZDhiNmM5ODIzOSB3YXMNCj4+Pj4+Pj4+ IGFwcGxpZWQuIEluIGZhY3QsIHRoZSBub3BhdCBvcHRpb24gZG9lcyAqbm90KiBicmVhayB0 aGUgaTkxNSBkcml2ZXINCj4+Pj4+Pj4+IGluIDUuMTYuIFRoYXQgaXMsIHdpdGggdGhlIG5v cGF0IG9wdGlvbiwgdGhlIGk5MTUgZHJpdmVyIGxvYWRzDQo+Pj4+Pj4+PiBub3JtYWxseSBv biBib3RoIHRoZSBiYXJlIG1ldGFsIGFuZCBvbiB0aGUgWGVuIGh5cGVydmlzb3IuDQo+Pj4+ Pj4+PiBUaGF0IG1lYW5zIHlvdXIgcHJlc3VtcHRpb24gKGFuZCB0aGUgcHJlc3VtcHRpb24g b2YNCj4+Pj4+Pj4+IHRoZSBhdXRob3Igb2YgYmRkOGI2Yzk4MjM5KSB0aGF0IHRoZSAibm9w YXQiIG9wdGlvbiB3YXMNCj4+Pj4+Pj4+IGJlaW5nIG9ic2VydmVkIGJ5IHRoZSBpOTE1IGRy aXZlciBpcyBpbmNvcnJlY3QuIFNldHRpbmcgIm5vcGF0Ig0KPj4+Pj4+Pj4gaGFkIG5vIGVm ZmVjdCBvbiBteSBzeXN0ZW0gd2l0aCBMaW51eCA1LjE2LiBTbyBhZnRlciBkb2luZyB0aGVz ZQ0KPj4+Pj4+Pj4gdGVzdHMsIEkgYW0gYWdhaW5zdCB0aGUgYWdncmVzc2l2ZSBhcHByb2Fj aCBvZiBicmVha2luZyB0aGUgaTkxNQ0KPj4+Pj4+Pj4gZHJpdmVyIHdpdGggdGhlICJub3Bh dCIgb3B0aW9uIGJlY2F1c2UgcHJpb3IgdG8gYmRkOGI2Yzk4MjM5LA0KPj4+Pj4+Pj4gbm9w YXQgZGlkIG5vdCBicmVhayB0aGUgaTkxNSBkcml2ZXIuIFdoeSBicmVhayBpdCBub3c/DQo+ Pj4+Pj4+IEJlY2F1c2UgdGhhdCdzLCBpbiBteSB1bmRlcnN0YW5kaW5nLCBpcyB0aGUgcHVy cG9zZSBvZiAibm9wYXQiDQo+Pj4+Pj4+IChub3QgYnJlYWtpbmcgdGhlIGRyaXZlciBvZiBj b3Vyc2UgLSB0aGF0J3MgYSBkcml2ZXIgYnVnIC0sIGJ1dA0KPj4+Pj4+PiBoYXZpbmcgYW4g ZWZmZWN0IG9uIHRoZSBkcml2ZXIpLg0KPj4+Pj4+IEkgd291bGRuJ3QgY2FsbCBpdCBhIGRy aXZlciBidWcsIGJ1dCBhbiBpbmNvcnJlY3QgY29uZmlndXJhdGlvbiBvZiB0aGUNCj4+Pj4+ PiBrZXJuZWwgYnkgdGhlIHVzZXIuwqAgSSBwcmVzdW1lIFg4Nl9GRUFUVVJFX1BBVCBpcyBy ZXF1aXJlZCBieSB0aGUNCj4+Pj4+PiBpOTE1IGRyaXZlcg0KPj4+Pj4gVGhlIGRyaXZlciBv dWdodCB0byB3b3JrIGZpbmUgd2l0aG91dCBQQVQgKGFuZCBoZW5jZSB3aXRob3V0IGJlaW5n DQo+Pj4+PiBhYmxlIHRvIG1ha2UgV0MgbWFwcGluZ3MpLiBJdCB3b3VsZCB1c2UgVUMgaW5z dGVhZCBhbmQgYmUgc2xvdywgYnV0DQo+Pj4+PiBpdCBvdWdodCB0byB3b3JrLg0KPj4+Pj4N Cj4+Pj4+PiBhbmQgdGhlcmVmb3JlIHRoZSBkcml2ZXIgc2hvdWxkIHJlZnVzZSB0byBkaXNh YmxlDQo+Pj4+Pj4gaXQgaWYgdGhlIHVzZXIgcmVxdWVzdHMgdG8gZGlzYWJsZSBpdCBhbmQg aW5zdGVhZCB3YXJuIHRoZSB1c2VyIHRoYXQNCj4+Pj4+PiB0aGUgZHJpdmVyIGRpZCBub3Qg ZGlzYWJsZSB0aGUgZmVhdHVyZSwgY29udHJhcnkgdG8gd2hhdCB0aGUgdXNlcg0KPj4+Pj4+ IHJlcXVlc3RlZCB3aXRoIHRoZSBub3BhdCBvcHRpb24uDQo+Pj4+Pj4NCj4+Pj4+PiBJbiBh bnkgY2FzZSwgbXkgdGVzdCBkaWQgbm90IHZlcmlmeSB0aGF0IHdoZW4gbm9wYXQgaXMgc2V0 IGluIExpbnV4DQo+Pj4+Pj4gNS4xNiwNCj4+Pj4+PiB0aGUgdGhyZWFkIHRha2VzIHRoZSBz YW1lIGNvZGUgcGF0aCBhcyB3aGVuIG5vcGF0IGlzIG5vdCBzZXQsDQo+Pj4+Pj4gc28gSSBh bSBub3QgdG90YWxseSBzdXJlIHRoYXQgdGhlIHJlYXNvbiBub3BhdCBkb2VzIG5vdCBicmVh ayB0aGUNCj4+Pj4+PiBpOTE1IGRyaXZlciBpbiA1LjE2IGlzIHRoYXQgc3RhdGljX2NwdV9o YXMoWDg2X0ZFQVRVUkVfUEFUKQ0KPj4+Pj4+IHJldHVybnMgdHJ1ZSBldmVuIHdoZW4gbm9w YXQgaXMgc2V0LiBJIGNvdWxkIHRlc3QgaXQgd2l0aCBhIGN1c3RvbQ0KPj4+Pj4+IGxvZyBt ZXNzYWdlIGluIDUuMTYgaWYgdGhhdCBpcyBuZWNlc3NhcnkuDQo+Pj4+Pj4NCj4+Pj4+PiBB cmUgeW91IHNheWluZyBpdCB3YXMgd3JvbmcgZm9yIHN0YXRpY19jcHVfaGFzKFg4Nl9GRUFU VVJFX1BBVCkNCj4+Pj4+PiB0byByZXR1cm4gdHJ1ZSBpbiA1LjE2IHdoZW4gdGhlIHVzZXIg cmVxdWVzdHMgbm9wYXQ/DQo+Pj4+PiBObywgSSdtIG5vdCBzYXlpbmcgdGhhdC4gSXQgd2Fz IHdyb25nIGZvciB0aGlzIGNvbnN0cnVjdCB0byBiZSB1c2VkDQo+Pj4+PiBpbiB0aGUgZHJp dmVyLCB3aGljaCB3YXMgZml4ZWQgZm9yIDUuMTcgKGFuZCB3aGljaCBoYWQgY2F1c2VkIHRo ZQ0KPj4+Pj4gcmVncmVzc2lvbiBJIGRpZCBvYnNlcnZlLCBsZWFkaW5nIHRvIHRoZSBwYXRj aCBhcyBhIGhvcGVmdWxseSBsZWFzdA0KPj4+Pj4gYmFkIG9wdGlvbikuDQo+Pj4+Pg0KPj4+ Pj4+IEkgdGhpbmsgdGhhdCBpcw0KPj4+Pj4+IGp1c3QgcGVybWl0dGluZyBhIGJhZCBjb25m aWd1cmF0aW9uIHRvIGJyZWFrIHRoZSBkcml2ZXIgdGhhdCBhDQo+Pj4+Pj4gd2VsbC13cml0 dGVuIG9wZXJhdGluZyBzeXN0ZW0gc2hvdWxkIG5vdCBhbGxvdy4gVGhlIGk5MTUgZHJpdmVy DQo+Pj4+Pj4gd2FzLCBpbiBteSBvcGluaW9uLCBjb3JyZWN0bHkgaWdub3JpbmcgdGhlIG5v cGF0IG9wdGlvbiBpbiA1LjE2DQo+Pj4+Pj4gYmVjYXVzZSB0aGF0IG9wdGlvbiBpcyBub3Qg Y29tcGF0aWJsZSB3aXRoIHRoZSBoYXJkd2FyZSB0aGUNCj4+Pj4+PiBpOTE1IGRyaXZlciBp cyB0cnlpbmcgdG8gaW5pdGlhbGl6ZSBhbmQgc2V0dXAgYXQgYm9vdCB0aW1lLiBBdCBsZWFz dA0KPj4+Pj4+IHRoYXQgaXMgbXkgdW5kZXJzdGFuZGluZyBub3csIGJ1dCBJIHdpbGwgbmVl ZCB0byB0ZXN0IGl0IG9uIDUuMTYNCj4+Pj4+PiB0byBiZSBzdXJlIEkgdW5kZXJzdGFuZCBp dCBjb3JyZWN0bHkuDQo+Pj4+Pj4NCj4+Pj4+PiBBbHNvLCBBRkFJQ1QsIHlvdXIgcGF0Y2gg d291bGQgYnJlYWsgdGhlIGRyaXZlciB3aGVuIHRoZSBub3BhdA0KPj4+Pj4+IG9wdGlvbiBp cyBzZXQgYW5kIG9ubHkgZml4IHRoZSByZWdyZXNzaW9uIGludHJvZHVjZWQgYnkgYmRkOGI2 Yzk4MjM5DQo+Pj4+Pj4gd2hlbiBub3BhdCBpcyBub3Qgc2V0IG9uIG15IGJveCwgc28geW91 ciBwYXRjaCB3b3VsZA0KPj4+Pj4+IGludHJvZHVjZSBhIHJlZ3Jlc3Npb24gcmVsYXRpdmUg dG8gTGludXggNS4xNiBhbmQgZWFybGllciBmb3IgdGhlDQo+Pj4+Pj4gY2FzZSB3aGVuIG5v cGF0IGlzIHNldCBvbiBteSBib3guIEkgdGhpbmsgeW91ciBwb2ludCB3b3VsZA0KPj4+Pj4+ IGJlIHRoYXQgaXQgaXMgbm90IGEgcmVncmVzc2lvbiBpZiBpdCBpcyBhbiBpbmNvcnJlY3Qg dXNlcg0KPj4+Pj4+IGNvbmZpZ3VyYXRpb24uDQo+Pj4+PiBBZ2FpbiBubyAtIG15IHZpZXcg aXMgdGhhdCB0aGVyZSdzIGEgc2VwYXJhdGUsIHByZS1leGlzdGluZyBpc3N1ZQ0KPj4+Pj4g aW4gdGhlIGRyaXZlciB3aGljaCB3YXMgdW5jb3ZlcmVkIGJ5IHRoZSBjaGFuZ2UuIFRoaXMg bWF5IGJlIGENCj4+Pj4+IHBlcmNlaXZlZCByZWdyZXNzaW9uLCBidXQgaXMgaW1vIGRpZmZl cmVudCBmcm9tIGEgcmVhbCBvbmUuDQo+Pj4gU29ycnksIGZvciB5b3UgbWF5YmUsIGJ1dCBJ J20gcHJldHR5IHN1cmUgZm9yIExpbnVzIGl0J3Mgbm90IHdoZW4gaXQNCj4+PiBjb21lcyB0 byB0aGUgIm5vIHJlZ3Jlc3Npb25zIHJ1bGUiLiBKdXN0IHRvb2sgYSBxdWljayBsb29rIGF0 IHF1b3Rlcw0KPj4+IGZyb20gTGludXMNCj4+PiBodHRwczovL3d3dy5rZXJuZWwub3JnL2Rv Yy9odG1sL2xhdGVzdC9wcm9jZXNzL2hhbmRsaW5nLXJlZ3Jlc3Npb25zLmh0bWwNCj4+PiBh bmQgZm91bmQgdGhpcyBzdGF0ZW1lbnQgZnJvbSBMaW51cyB0byBiYWNrIHRoaXMgdXA6DQo+ Pj4NCj4+PiBgYGANCj4+PiBPbmUgX3BhcnRpY3VsYXJseV8gbGFzdC1taW51dGUgcmV2ZXJ0 IGlzIHRoZSB0b3AtbW9zdCBjb21taXQgKGlnbm9yaW5nDQo+Pj4gdGhlIHZlcnNpb24gY2hh bmdlIGl0c2VsZikgZG9uZSBqdXN0IGJlZm9yZSB0aGUgcmVsZWFzZSwgYW5kIHdoaWxlDQo+ Pj4gaXQncyB2ZXJ5IGFubm95aW5nLCBpdCdzIHBlcmhhcHMgYWxzbyBpbnN0cnVjdGl2ZS4N Cj4+Pg0KPj4+IFdoYXQncyBpbnN0cnVjdGl2ZSBhYm91dCBpdCBpcyB0aGF0IEkgcmV2ZXJ0 ZWQgYSBjb21taXQgdGhhdCB3YXNuJ3QNCj4+PiBhY3R1YWxseSBidWdneS4gSW4gZmFjdCwg aXQgd2FzIGRvaW5nIGV4YWN0bHkgd2hhdCBpdCBzZXQgb3V0IHRvIGRvLA0KPj4+IGFuZCBk aWQgaXQgdmVyeSB3ZWxsLiBJbiBmYWN0IGl0IGRpZCBpdCBfc29fIHdlbGwgdGhhdCB0aGUg bXVjaA0KPj4+IGltcHJvdmVkIElPIHBhdHRlcm5zIGl0IGNhdXNlZCB0aGVuIGVuZGVkIHVw IHJldmVhbGluZyBhIHVzZXItdmlzaWJsZQ0KPj4+IHJlZ3Jlc3Npb24gZHVlIHRvIGEgcmVh bCBidWcgaW4gYSBjb21wbGV0ZWx5IHVucmVsYXRlZCBhcmVhLg0KPj4+IGBgYA0KPj4+DQo+ Pj4gSGUgc2FpZCB0aGF0IGhlcmU6DQo+Pj4gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2Mv aHRtbC9sYXRlc3QvcHJvY2Vzcy9oYW5kbGluZy1yZWdyZXNzaW9ucy5odG1sDQo+Pj4NCj4+ PiBUaGUgc2l0dWF0aW9uIGlzIG9mIGNvdXJzZSBkaWZmZXJlbnQgaGVyZSwgYnV0IHNpbWls YXIgZW5vdWdoLg0KPj4+DQo+Pj4+IFNpbmNlIGl0IGlzIGEgcmVncmVzc2lvbiwgSSB0aGlu ayBmb3Igbm93IGJkZDhiNmM5ODIzOSBzaG91bGQNCj4+Pj4gYmUgcmV2ZXJ0ZWQgYW5kIHRo ZSBmaXggYmFja3BvcnRlZCB0byBMaW51eCA1LjE3IHN0YWJsZSB1bnRpbA0KPj4+PiB0aGUg dW5kZXJseWluZyBtZW1vcnkgc3Vic3lzdGVtIGNhbiBwcm92aWRlIHRoZSBpOTE1IGRyaXZl cg0KPj4+PiB3aXRoIGFuIHVwZGF0ZWQgdGVzdCBmb3IgdGhlIFBBVCBmZWF0dXJlIHRoYXQg YWxzbyBtZWV0cyB0aGUNCj4+Pj4gcmVxdWlyZW1lbnRzIG9mIHRoZSBhdXRob3Igb2YgYmRk OGI2Yzk4MjM5IHdpdGhvdXQgYnJlYWtpbmcNCj4+Pj4gdGhlIGk5MTUgZHJpdmVyLg0KPj4+ IEknbSBub3QgYSBkZXZlbG9wZXIgYW5kIEknbSBkb24ndCBrbm93biB0aGUgZGV0YWlscyBv ZiB0aGlzIHRocmVhZCBhbmQNCj4+PiB0aGUgYmFja3N0b3J5IG9mIHRoZSByZWdyZXNzaW9u LCBidXQgaXQgc291bmRzIGxpa2UgdGhhdCdzIHRoZSBhcHByb2FjaA0KPj4+IHRoYXQgaXMg bmVlZGVkIGhlcmUgdW50aWwgc29tZW9uZSBjb21lcyB1cCB3aXRoIGEgZml4IGZvciB0aGUg cmVncmVzc2lvbg0KPj4+IGV4cG9zZWQgYnkgYmRkOGI2Yzk4MjM5Lg0KPj4+DQo+Pj4gQnV0 IGlmIEknbSB3cm9uZywgcGxlYXNlIHRlbGwgbWUuDQo+Pg0KPj4gWW91IGFyZSBtb3N0bHkg cmlnaHQsIEkgdGhpbmsuIFJldmVydGluZyBiZGQ4YjZjOTgyMzkgZml4ZXMNCj4+IGl0LiBU aGVyZSBpcyBhbm90aGVyIHdheSB0byBmaXggaXQsIHRob3VnaC4NCj4gDQo+IFllYWgsIEkn bSBhd2FyZSBvZiBpdC4gQnV0IGl0IHNlZW1zLi4uDQo+IA0KPj4gVGhlIHBhdGNoIHByb3Bv c2VkDQo+PiBieSBKYW4gQmV1bGljaCBhbHNvIGZpeGVzIHRoZSByZWdyZXNzaW9uIG9uIG15 IHN5c3RlbSwgc28gYXMNCj4+IHRoZSBwZXJzb24gcmVwb3J0aW5nIHRoaXMgaXMgYSByZWdy ZXNzaW9uLCBJIHdvdWxkIGFsc28gYmUgc2F0aXNmaWVkDQo+PiB3aXRoIEphbidzIHBhdGNo IGluc3RlYWQgb2YgcmV2ZXJ0aW5nIGJkZDhiNmM5ODIzOSBhcyBhIGZpeC4gSmFuDQo+PiBw b3N0ZWQgaGlzIHByb3Bvc2VkIHBhdGNoIGhlcmU6DQo+Pg0KPj4gaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvbGttbC85Mzg1ZmE2MC1mYTVkLWY1NTktYTEzNy02NjA4NDA4Zjg4YjBAc3Vz ZS5jb20vDQo+IA0KPiAuLi50aGF0IGFwcHJvYWNoIGlzIG5vdCBtYWtpbmcgYW55IHByb2dy ZXNzIGVpdGhlcj8NCj4gDQo+IEphbiwgY2FuIGNvdWxkIHByb3ZpZGUgYSBzaG9ydCBzdGF0 dXMgdXBkYXRlIGhlcmU/IEknZCByZWFsbHkgbGlrZSB0bw0KPiBnZXQgdGhpcyByZWdyZXNz aW9uIGZpeGVkIG9uZSB3YXkgb3IgYW5vdGhlciByYXRoZXIgc29vbmVyIHRoYW4gbGF0ZXIs DQo+IGFzIHRoaXMgaXMgdGFrZW4gd2F5IHRvIGxvbmcgYWxyZWFkeSBJTUhPLg0KPiANCj4+ IFRoZSBvbmx5IHJlc2VydmF0aW9uIEkgaGF2ZSBhYm91dCBKYW4ncyBwYXRjaCBpcyB0aGF0 IHRoZSBjb21taXQNCj4+IG1lc3NhZ2UgZG9lcyBub3QgY2xlYXJseSBleHBsYWluIGhvdyB0 aGUgcGF0Y2ggY2hhbmdlcyB3aGF0DQo+PiB0aGUgbm9wYXQga2VybmVsIGJvb3Qgb3B0aW9u IGRvZXMuIEl0IGRvZXNuJ3QgYWZmZWN0IG1lIGJlY2F1c2UNCj4+IEkgZG9uJ3QgdXNlIG5v cGF0LCBidXQgaXQgc2hvdWxkIHByb2JhYmx5IGJlIG1lbnRpb25lZCBpbiB0aGUNCj4+IGNv bW1pdCBtZXNzYWdlLCBhcyBwb2ludGVkIG91dCBoZXJlOg0KPj4NCj4+IGh0dHBzOi8vbG9y ZS5rZXJuZWwub3JnL2xrbWwvYmQ5ZWQyYzItMTMzNy0yN2JiLWM5ZGEtZGZjN2IzMWQ0OTJj QG5ldHNjYXBlLm5ldC8NCj4+DQo+Pg0KPj4gV2hhdGV2ZXIgZml4IGZvciB0aGUgcmVncmVz c2lvbiBleHBvc2VkIGJ5IGJkZDhiNmM5ODIzOSBhbHNvDQo+PiBuZWVkcyB0byBiZSBiYWNr cG9ydGVkIHRvIHRoZSBzdGFibGUgdmVyc2lvbnMgNS4xNyBhbmQgNS4xOC4NCj4gDQo+IFN1 cmUuDQo+IA0KPiBCVFcsIGFzIHlvdSBzZWVtIHRvIGJlIGZhbWlsaWFyIHdpdGggdGhlIGlz c3VlOiB0aGVyZSBpcyBhbm90aGVyIHJlcG9ydA0KPiBhYm91dCBhIHJlZ3Jlc3Npb24gV1JU IHRvIFhlbiBhbmQgaTkxNSAodGhhdCBpcyBhbHNvIG5vdCBtYWtpbmcgcmVhbGx5DQo+IHBy b2dyZXNzKToNCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC9ZbiUyRlRnajFFaHMl MkZCZHBIcEBpdGwtZW1haWwvDQo+IA0KPiBJdCdzIGp1c3QgYSB3aWxkIGd1ZXNzLCBidXQg Ym91bGQgdGhpcyBzb21laG93IGJlIHJlbGF0ZWQ/DQoNCk5vLCBkb2Vzbid0IHNlZW0gc28u DQoNCkknbSBqdXN0IHJldmlld2luZyB0aGUgc3VnZ2VzdGVkIGZpeDoNCg0KaHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvbGttbC9ZbzBMd21WVURTQlpiNDRLQGl0bC1lbWFpbC8NCg0KDQpK dWVyZ2VuDQo= --------------1JYoJE0gc0gGkSGQBbWTf8g3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1JYoJE0gc0gGkSGQBbWTf8g3-- --------------53G0UGMnr335AXWugItqKkAF-- --------------BfyGk3XKVACj6W41lAYZo2BD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKN4xEFAwAAAAAACgkQsN6d1ii/Ey+J awf/UGRdyZzPs0sv6p9bQhiaqdyYojQ0J5NbXM0b9Ib3Tt9fZU8sd+mMbYBi7mFpZjUeHcd9BuN6 7YMWPs0HlVJQOzww9nfd9pbwOndzbll8JmYLDGhRCOC2uffROxp6mxGBraNNPUdFxYZ7piwMdPwB NRvAr8E6HGriaiA6t1y3iiTtkMHNZmKAe1ILof4mIBNFOwVacGHKiDU1FOrKFHqjYfncSOh+p6Hn XskdgoFUNP8G2KUM1xehwvk1bFWk+m59+hWoHmJqomTYCkn6PogPpbkJiRBe5B3tUcmuIED0VOPY tjJMPtkkk97jswLdC2BSjp3XIbXSMmqs3uFFtk5NfQ== =rhGD -----END PGP SIGNATURE----- --------------BfyGk3XKVACj6W41lAYZo2BD-- From xen-devel-bounces@lists.xenproject.org Wed May 25 08:08:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336966.561417 (Exim 4.92) (envelope-from ) id 1ntm4Q-00053m-7G; Wed, 25 May 2022 08:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336966.561417; Wed, 25 May 2022 08:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm4Q-00053f-39; Wed, 25 May 2022 08:08:42 +0000 Received: by outflank-mailman (input) for mailman id 336966; Wed, 25 May 2022 08:08:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm4O-00053Z-J7 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:08:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e23d22dd-dc01-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:08:39 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-15-lEM-exwRObW-1JXcvb0JmQ-1; Wed, 25 May 2022 10:08:34 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5095.eurprd04.prod.outlook.com (2603:10a6:20b:a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Wed, 25 May 2022 08:08:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:08:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e23d22dd-dc01-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653466118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zTa4xJIqbw+9NUeJ00BUAhQdmBU4jn5bKML4SzZSjPI=; b=NL1Phjg+me4nA27PX+21AfZxxnCXDiWs3qWdANzr3+B90Fos34myODu9KQm+H2FfYYvQps pHha9LobUYqMxjCRgUqwuxIhDooWP/VfhJmqCsbN39c1Es3XABn/0p7KmseJyFfXSYmuSX GqBWz78H2glG4snzNmcDcblj2htoqx0= X-MC-Unique: lEM-exwRObW-1JXcvb0JmQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAI7zRfj+GBZ3JsW+Ns7LSzpMX/PrrLHA4AILad7z4cJ1q6DCGiBtZEotMUgGvNTzAWaBhZFpKzxpAFftywkDBNonyPcf7D61ubdZPhbcqLqSuAd70uJDN3VpVp4fxofOYjpHRt4FmLWruBt8W8iKV4sFv8gKgA6bQ79X6rY2DfRCPgvgaRcXLJuhE5tgkHT0d7ecP8Ho4boM/1/7ORxaaDdVw+dEyIgHrahW9gBlm8Up+parmOpyUEcmfe54U5kZ4NfI6VPnYnBf6IluWNw/SejAQa6d9sHrBoqw1EYLLHK7BOormn0VV97lTy1a9Y2YeK7kJb/JEuWmmQhxQj+1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zTa4xJIqbw+9NUeJ00BUAhQdmBU4jn5bKML4SzZSjPI=; b=BrHPRQCT7bfHaxl81jX9EWXV9GSe0QX1PBnQrrf4yiQhReOC4Q7gFlP/Fm5+br0L+DOv+ha3prdhNh3z3HLYqIanE7SuHdtbZZPFJv4Ho7e/HZY9RnIQgLfoAUjYq/VkzNVESHKvVyDbABfFA7ceGvmi6zy8dcTSBBZAbKt+yHDxjxzNzN+BBJbgfrB+pES1MwbX5izHKt/mqjPhfJnmRsdRx6z0qcAdHyEVo+MJ4lHYD7WpjQBrwgeLOJrffNOSwUzLXry/BMsf7DtJh1ucp8ukNI9nwhAphkLsqd47ZOb5kry0jt05FD+h6z+SzC+FeOmnUJEVJD/+H2IPEyzFZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> Date: Wed, 25 May 2022 10:08:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220525003505.304617-2-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20220525003505.304617-2-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0502CA0038.eurprd05.prod.outlook.com (2603:10a6:20b:56::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b96c073e-afdc-4b65-6327-08da3e25c2e8 X-MS-TrafficTypeDiagnostic: AM6PR04MB5095:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3cXZgIs6GUihl1jzJRWsI0ApglEpNwXacQPoXHxYtyjZJcAu+O3c+3Baplcy9z/8fpUDwhPfeJIiS45qx3Gj+9sNK0/ZSj6FWcWiznNoh/Ew834E4Fhj/RznNTICtH7qPoNQ9l66MpxaWBswMN8rA6rJA2/ErW+xQ89KLF8Xh3rQeRUuAyILZOIdxBwyYByyuGRKC2hRpYcNGE2oSWeLHSluquk0IjYotdQuja/YJQPC+grqfUuO++1ecEgBNWU5n7WJ0Cb3vmj2N3m3TzehVf3vWxFbpHUofyqO5/sKZjwQxhvJ0pd/EtQPvwSO5QeXCUzxqQaEcE1V2QUPLUXCrvLiHtHitBce4lzVL7rRRLvHwGLP3VWbW8PkmbZuDvyJ30nB5bl2RVdYNJYDTGHVoVHipGdYxVDykSjjuNuv6JiKlSodiKX9DeGl0EZPTyuOe9MsSGe8oaT1xcZpFAeewY1e99aXWILrWvGUY4l7+O9ZWM3gM6p3wD3YmIv2zWZsh9Ne3CwuselDLmPlCeUCq1nJ+ne+VemT39l0Owf6d7fDKZmTnPVOfV/d5xyTbyXzoN8IINRU4GzqG8mGIQvCX8O279lLYLMPAvK+zjh3o0US+z8PaVyKp0dVtoeRweaap499uRr8IRS4daFICUFwJWg14EQ/4gptI8IGtv/vb6nlx/V8NIh09sMd018nD7xjJKBHA9WBGpOfiLTqHyBf+RVoX0uhRAFydPuHMfk2pDzbjT6O5CzDPUTsowl7lJma X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(86362001)(31696002)(4326008)(83380400001)(66476007)(66556008)(8676002)(186003)(8936002)(2906002)(38100700002)(6916009)(6506007)(5660300002)(508600001)(6486002)(316002)(6512007)(31686004)(26005)(36756003)(53546011)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0NYWnpKU1JvZWh6b0owNEZYWW9EWlJpNGNyRUZnb25LbGtjeEVaSEdyT0hv?= =?utf-8?B?SzhyK1VFQ0NoUXhNVk13akVOOVBybjFxMnpUK3dOTHJhQTFvZHdQM1RIQzZv?= =?utf-8?B?aHFNUXNzaUZWOGVoRUlXbExhYXFUZTY5WWxwT0EzZzJrUjhtTzZvYVFrU0dP?= =?utf-8?B?ZS9zZlpmL21iY0dTOEFCOFc3UkxVdEplUmQzL0xUWFdrWmdOdDRITDQrY1hL?= =?utf-8?B?QUwxQjFMSWZLRFprTXh6OW8wbDdDNSsvT25zbTZMWHFtVXIxSUo1Vk53cXkx?= =?utf-8?B?QzgxaFk0YXZERVRjc2V6RmlYTEx2VEV2VFlHTDVZNUhXSjVueVFmd2dXeXBu?= =?utf-8?B?dVJ2eFhLTVhWby8vc3FzTmVzdTZkL1Y0K2UvYU41WlJXNDltYVFGWFJidjJM?= =?utf-8?B?ZmtkaC9VaXVPK3pMVkV0NG9BY3R6Y0xvZGFQUjV1cVRZeFczUGRhZUhPUEYw?= =?utf-8?B?azh4SFF4bWxuWW1aZExYOUJKYmx4RWVhdC90ZGhYbm54ZzhwK3Vtek94bFJN?= =?utf-8?B?RmQ2SHhPV1NXYTZGT2lYTk1ralFXWnA4NU1IekYzMWg2M0srcktyZXVvczRs?= =?utf-8?B?Nk1PNlFUa1hRSEVyUzNFcUFEN0ZlZ2o4dWZLMDI2dGRBWjBsSzRwUXVpRzdi?= =?utf-8?B?dlBMMm5UWFlhdXBRV2F5enBJeXJua2RXS2pDTXcyS1lIdXFDbElGaXMvdm9N?= =?utf-8?B?bndGTnhNWnNZY3hrNzFQaUxqNDNmWko1c2d6cFdaRTVlWWIvaE5TQXoyZUd1?= =?utf-8?B?bjhwZnFKUUNGd3JwdlEzcGNYSkIwMGk5MHVjRUt5d3BuZVlNMzRFK3dZV1kz?= =?utf-8?B?a3BCK2lVcjJtMW1DbFIrbHdZYnUvVHlhNzZvaHFjZFo5NXplM0FqdHVOR2p4?= =?utf-8?B?YnhlZXdzellXV0NGM295eHVFSUdpd3NKRkExam5tdGsxbm9zQ2FZNFpvUkEy?= =?utf-8?B?bTdJR0tRZWZDY2pOMWxuZ2NZTkw1N1c2bDA4U3ZwSDFMbFN5TzBxMDBSUndY?= =?utf-8?B?SmEzSDFyTlRBTHo3NGxaWlk2S1huNkU1QUt4b0N2cWJBcXB5ck5OVWwvcHB3?= =?utf-8?B?UVdMRlVnOHVQK1hmRHhjeUJlZGJ1d2o0cHFvaWN3YW9MbWRJbms0SGhOdElR?= =?utf-8?B?enJmd2hVMnVtYXdpeGZHYW1sVi9tL0lWWEk3RDh3YWx5REdPU2JyWGhGN212?= =?utf-8?B?Rmc4RmtoR3dFM0E5TjZ0blBqc3I3dnM3YUNob3dBR1FERmIwVDhMQ2xJa01M?= =?utf-8?B?SnhpTWhKRWlRWXE2UjNDcjFMM05qeHZaa1dza3JjckhMblMzSVN4MlQxdEFs?= =?utf-8?B?cUljT2VmVFFzSmU2SSs0d0I5NlI0Q2ZSZ1o0UFZKbnhBbEhiNjFHV1g5eWll?= =?utf-8?B?aThLMUpLNlNNK1FPQVVrVUZ2R3JoK0dqUWRsZmRLLzFOUUNOMWJNSzRYRm9K?= =?utf-8?B?TmtnYVZEUUEwRU1VV05zcjJkRnIzR1FDejcwNnlqTVFpU3FQMjFaWUY0Y0dS?= =?utf-8?B?VnpWMEZXUVcyYmhmcElwK09BdDloSTA2OTBoeVBwWW5UUm1ySjNGWGEwZlpM?= =?utf-8?B?OEhhZ3E4RWJ6USt1RTFYc3R6bktuWkpkWWJSaU44R1c5RDRGejRnL2psNXlq?= =?utf-8?B?ZzQ5T0RYaGlaMnhONHpnYUM2clZ3clphc3lSdm00ZVdTSVFqdnZES3YzUXF6?= =?utf-8?B?WkJOaFRTMFB5QW9sVXZpZXJsNEN2SzBaRW5OUjh5OVdCVTAzU1NKK21GR1Mx?= =?utf-8?B?eGpZekRvZ0QzOFQ4K0ZKOW5ra0pQSDBqbjVvbHpqSFQwK3RWbEpKdmZqUVhn?= =?utf-8?B?bkFOdXN2Mk1OVXVTcVJYcEFQVlBrNEJQczduR1ZzaDgydzVCTUpiSm9TYTll?= =?utf-8?B?ODdLaGNrNHhWNS9INzJod01rWDg1RUE4ZDZCVWxOQytsY1gzNjVEb0l3OXhl?= =?utf-8?B?ZVdVSVFrRnA4QjNBYnVoczA4QXI2TEgxelZ5Mjk0ckV5dDlHZkZ5cG4rYXBx?= =?utf-8?B?MlRNWmc0K2xnd2w0ZDQvdTR3MGNKdVF2dVMyNHhHOHRENThCQTJiS1Babith?= =?utf-8?B?M2MrMFlTUTB3ZnFIejI3YzgxejR4M1J3Mk1XdjZPNFp1YVlxYjdqbHd4Zjdh?= =?utf-8?B?dDM3Vldkdy9kQXlQTldPZTFaazNvN0ZSSlorS0trM1QxT09uYUN2ZWU2VGlP?= =?utf-8?B?TWtYT3hyL1J0TC9SdU40S09qdnBUbkNaTWRVMFp1MDBBMFpwQWVXUEEvZnEx?= =?utf-8?B?NEF4ajB1UHlYWjZGdmxRVHhKNWoxR3FFbGZXOXhUd2VlV0xTb0FnSGYzNTZS?= =?utf-8?B?bXZvRHdLU1BxdEpXeTVSbFo4YUtzR29UTWl2UGFXY040LzhHc2lEZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b96c073e-afdc-4b65-6327-08da3e25c2e8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:08:33.2161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fXn0tNLyuhUeaFWsj/pbeCln8TV8hbmej+9qj1miL6ZpjgRj+AtZqPoeb/v6yUfQuvj7eQW1H6t9Zarsee881g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5095 On 25.05.2022 02:35, Stefano Stabellini wrote: > From: Stefano Stabellini > > Add Rule 5.1, with the additional note that the character limit for Xen > is 63 characters. > > The max length identifiers found by ECLAIR are: > > __mitigate_spectre_bhb_clear_insn_start > domain_pause_by_systemcontroller_nosync > > Both of them are 40 characters long. A limit of 63 characters work for > the existing code. I have to admit that it hasn't become clear to me why we want to permit (if not to say encourage) the use of such long identifiers. If 40 is the longest we've got, why not limit it to 40 for now with a goal of further reducing? A 40-char symbol plus some indentation will already pose problems with 80-char line length. Otoh, as said on the call, I think the public headers want mentioning explicitly here in some way. Part of them (most or all of what's under io/) aren't used when building Xen, so won't be seen by Eclair (aiui). Yet they are a formal part of the code base, and e.g. ring.h has some pretty long names (albeit still below 40 chars as it looks). So once we're able to go down to e.g. 32 for the bulk of the code base, public headers should imo still be explicitly allowed to use longer identifiers. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 08:13:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336976.561434 (Exim 4.92) (envelope-from ) id 1ntm97-0006bM-Bf; Wed, 25 May 2022 08:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336976.561434; Wed, 25 May 2022 08:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm97-0006bD-5c; Wed, 25 May 2022 08:13:33 +0000 Received: by outflank-mailman (input) for mailman id 336976; Wed, 25 May 2022 08:13:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm96-0006XY-As for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:13:32 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f05a45e-dc02-11ec-837f-e5687231ffcc; Wed, 25 May 2022 10:13:30 +0200 (CEST) Received: from mail-bn8nam11lp2170.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 04:13:21 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN2PR03MB2384.namprd03.prod.outlook.com (2603:10b6:804:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:13:19 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 08:13:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f05a45e-dc02-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653466410; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=i0DHl/Fggy3s8e4om9UV0iV14j+LgxQomjRyTUyxx1Y=; b=PDjMn5T3RBJUokCO0iJFOUWM6gi4srBbCBC7Tk57OVovsC8c4AI+cQrN HuonYakEGPlSMFfobn0LywTfiQpsIL1qxO/PtCR3yRDhMbIJM5pBSa8jf 2MKEBkpfWhDg347H6bAzxmrviA8u/AnsyMP7dkkvWE+iADZlH5fTYYeUh s=; X-IronPort-RemoteIP: 104.47.58.170 X-IronPort-MID: 71982223 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ca1TrqBQCq55GhVW/13iw5YqxClBgxIJ4kV8jS/XYbTApD0j3mMEm zcYCmyCOPuCZGLxLdtyYYi1oBsFupSDnNVnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Nj39Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhIl It9iZGzVD4TGbHLmqdMcShgGQZHaPguFL/veRBTsOS15mifKj7G5aUrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mcG80m5vcBtNs0rtpJEvvEI dIQdBJkbQjaYg0JMVASYH47tLjx1ymlKWcDwL6TjbIu8TXr0zMh6beuMOjLKoSqf+5ou3/N8 woq+Ey8WHn2Lue32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPXO5q/Skjk+1W/pEN lcZvCEpqMAa60iDXtT7GRqirxa5UgU0XtNRF6gw7lGLw6+NugKBXDFbFnhGdcAss9IwSXoyz FiVktj1BDtp9rqIVXaa8bTSpjS3UcQIEVI/ieY/ZVNty7HeTEsb1Hojkv4L/HaJs+DI IronPort-HdrOrdr: A9a23:JrSOS68Co61nfkoFrpFuk+E+db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsjaKdgLNhRItKOTOLhILGFvAH0WKP+V3d8k7Fh5NgPN lbAs9D4bTLZDAV7PoSiDPIaerIq+P3lZxA692urEuEGmpRGtpdBkpCe3GmO3wzYDMDKYsyFZ Ka6MYCjz28eU4PZsD+InUeReDMq/DCiZqjOHc9dlcawTjLqQntxK/xEhCe0BtbezRTwY06+W yAtwDi/K2sv9yy1xeZ/W7O6JZ9nsfn17J4dbqxo/lQDg+pphejZYxnVbHHlDcpoNu34FJvq9 XIqwdIBbUA11rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1bkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMEjgYdq3MMiFX5uYdk99HqQ0vFnLA AuNrCW2B9uSyLXU5iD1VMfgOBFXRwIb2S7qwY5y4+oOgNt7Q9EJnsjtbAid0g7hewAouF/lo L524RT5cRzp5wtHNZA7Nloe7rHNkX9BTTxDUm1HXPLUIk6BlOlke+G3Fxy3pDjRKA1 X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="71982223" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BvGufHWOHvubzJLqI7wJN0pgfyI8vlC4OIbV2q5I21HXaFnirodD8cNCEldAt3RPjsf6m57ESpNpTWXM6ZQyKjqHzuToThun/cMEZJfX8MYA8g6OQrF337lyPBy/TKoSive8JfrZOaKTKlzpcYWe2iMmS3ihQK5cp/G043AMgiUp9Sxos1iY1qMInkC/R+GPGk/ATZSFL7uCCNNGpYO/AmDE6em9X71MdjZ8CUs8kE8F0oUXWwK0jmkXFqN15TiJVMA4lTaUhBieWUE4oODd57IIHyn8j7QzyyG4s8Umne887LpVadY4bC59be9+07hquiUw9Mhe/JWqfYvx1KIUHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VfoDn3oJE1llxFj9p3Nd8P/WEBh+QYk/xyl4xWf42+g=; b=ChqJNEbTh6woPGxag6OhCu90QRlC7ONfJsAh9n1KhyiZJ3Qcn97N6wFf0Xj5KfTpiCzMlMYtuu5fDGaGXfl+4ALRKujgXPCBBQAkyzpEsg6/gfEu04spASnelIjLBpjuK3Nwbtn0p6y1H0ZvbmZuwU5OnNIppLNrxgd8Y4fNBXGKb9o35uw4pQT4dLjMaVW+HvezAYctYieBzJwDOtqxyLTk/GT8yiPil0CNCnV4vsfbAaiAWtB03z5wJk42ivIDeMU+1bcIUULlm7rC8VvgoyO380ZTofz7MgqfNTp8yIjfJBNhITU7fv7ukuyK/CrNrtEyGvslx06Gsla8qZPUnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VfoDn3oJE1llxFj9p3Nd8P/WEBh+QYk/xyl4xWf42+g=; b=ETXQGZNYiSrtO18ZsEoLKRVje/82GGp3tX9uJrbxblHoIPopdEgj0ALu3agqMCV1ReEz6pP+ho8rZQfx1Rs2vGXesYM8CJayNqfSsQYAsF5ZD2g9Ob/J8P9jcei+Wa7HZ7AsCagn+oLUTY/qNpLuJX4b/Ov3MxNuwsWjumqhkSc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 0/2] x86/mm: fix regression when booting with CET-SS Date: Wed, 25 May 2022 10:13:09 +0200 Message-Id: <20220525081311.13416-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0081.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 32c1a7c0-6e3f-44b3-d806-08da3e266d5d X-MS-TrafficTypeDiagnostic: SN2PR03MB2384:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c+/bkiXJxphM75ftgzSf3owrHBIgKtKxJbfQuZxeL/aSe89+M5+1wyiyNBwfEoJtjcD6E3r/rXR+rk+puIM6NY6PnR7izhMn1ff2+DLDhVjbGH3ILJAe9+axAoCephCFp5QlGMlIFnarddqPXXWaV1yAb9m8fAkqMp6vr5yImcpigrLk3Mpt/tpPOE1QVP1a9bVCmV2r0p4L0gD9HTGiINBa3C99Ux5Cq5JNrIxdjFtvVck3CXTjwT6qJQJnAPm5/NGt2mftqlIqiTc4df2WE+Mqf5jWNSkY1fCmhaImbHHRoTVwIEVBBf1M3Sxk/CzRdpRTuny7BhSswjdPR9Pzp1C2+YlEmVkKcl4ytedGGFNBCTjZlnnuFasnR/aL+kmIhn0biSMvEXTTWLf1pGWQf6eUikHSJ5Jf2xsMGoRconPWRmP5jY/faQC6F7xub/FJD3p6qrsgFqeJEMK0K2l1czO1UR5XSXgc6ZAqzBP5RjPHjRyxXWQ+bvX3V8hlOscQjr/BphpTRsYnGlTiyoxI/ft/6jJQtfq/1ZGdz3ZZE+bKFNGeN44F8LrK0vtI/HiyVcsYzqItpm2UGkxlpH2XBeyoorLlwqiYEfv2HaaLlc0WnaPsqhUvNMHAaJL4Lzk+g8u2XDq1JOjaEOb2901scA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(4744005)(66476007)(6506007)(4326008)(26005)(6512007)(8676002)(82960400001)(86362001)(5660300002)(508600001)(83380400001)(8936002)(6486002)(1076003)(2906002)(38100700002)(316002)(2616005)(6666004)(36756003)(186003)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WC9CR0g4VVRmdVBQSDZyQ3pQTm9qN0doZW1MMlpoOGVuN0Y1SjRhTXFBbVR2?= =?utf-8?B?Um93YTM5ZWREaG5NQ3JxZzVZWjltdTZpMEpQRVJLWk9BQXhUOVlvV3RWdFZ6?= =?utf-8?B?RytlaW50ZGFobm1CMXMwWEZoN1hsd0NFSmVuRUJvRUdhTXBabmdFY2srTngr?= =?utf-8?B?OEpadzJoS1NNSk5iMjV0MFpJY09BcEk2QjVFYVFHTHZCV3U0Y2ZRNE8yUndn?= =?utf-8?B?VldmcjFCakQ4MlVnNEhlR2cyaUluQmgwRmlFUzk4NVZFWmFlU3pHZEZ1cDYw?= =?utf-8?B?UHJaVjZWUTBINnlIZGYxM0xhaXZrcCtMdi9FVjVXV1dhcytvakZUQ1JjMGVp?= =?utf-8?B?NmZGci9tRFBjdGR1N2VJc1crK1BQdmwrYXp0S3RQK0V5Qms4b2JQOW16YjlH?= =?utf-8?B?bm1tYzUwcXV5djZERi9SaHdCL252S3JFQSszMUI2WjQ3RStYVi8wZFB6VW8r?= =?utf-8?B?TWx6K0ZWdlp5VWtrQnRWZnM3VUpzTFpUaWY5OHRYTXhKMjFMMUFsUWVTSnFL?= =?utf-8?B?cXhnamxkQkdHNzlneE44WUJ5WWpwSlowL1lYcndZdW1WVGszYktsVk5BWkQr?= =?utf-8?B?UWZWdjBIZkNwdmsrSncwU3JPZ0VKQ0h0L3VyNVVwK2QwVllYWEk1ZXV1dUI0?= =?utf-8?B?bVFhNGxUc09TTHk2T3pLRTFZd3JsSmRkUFB6L1RZWnp5NEUycWhvWTRDMUg5?= =?utf-8?B?ZnJSQXNhMEttNjYybnFqNW5UaEVqVEF6UVFUdVFGNmRSc2lud2N0ZjNKMkdG?= =?utf-8?B?eUNrc0hZdGFJM1hXNnFPVG9VNGFvdllXTUxZRlRiUUF3S0l0NzIrbmJ2ZmdC?= =?utf-8?B?L0toa0ZRUFZONU9ud2lSOHlocEI3eEg5K3FuMDdtcVI5d2Q4dzR5cTh6Uy9m?= =?utf-8?B?bzNMb2l5cnJSanR0eDB6R0dEY2xMV2lCc0Z2QVRXc01EOXR5bXErdzA2Rkxh?= =?utf-8?B?NXp0NG44ZE1JbHJjeFhBSnh0eEEzQUxaZDdMZTMvelJRYWNyZHhGNXZzRWFs?= =?utf-8?B?TkhZdjBzclhSdDJJV01QVHBjYmtNVmRkMml6UXBaTkhPTTNoZ2NqK3NmZ0dE?= =?utf-8?B?NzBxK0hQVkNsc2lsVHV0RG9FVjlBRFNOejFmU04vOGdDMDJha1JhTnk3WlNE?= =?utf-8?B?UzhnWElLQ1FmU3RYT0k4UUJUR0xDR0s1ZGc5VTI3ZzdvZ1gxTXUyNFlMODNu?= =?utf-8?B?MUVFdjBHWjNRZTdYUGFYTENLUEVaSzFTZkc1aXJhSFhxU2pYRDljd0ZmbnZO?= =?utf-8?B?Ym9LdlNudStoeEpTZ2xmd2V0UXpJY2VNbDdQcktzc1BaeXphRjJweVNXeUxB?= =?utf-8?B?ZTdxZDM3d040WVVndllzM21WdmRiTTd6RWJBQVgvcCtLWDN4ditvTjB2Skxw?= =?utf-8?B?Z085WS9zREFRV1N0L2JvZHBmUlkwWmV1ZHBuZkVuOWN2bjF6a2hPSlNTZGFF?= =?utf-8?B?Ym9ZRTlEWklhckRJc1BEb2Y0V0M5aGJUV2p1MytsbURaMmU1NnBTRWd4ZXpQ?= =?utf-8?B?RTF6QzQ3K25xRFF2Y3hlY3RRWDJES1pnS0VZT0VSeGxvck84a2lDM28yNzEy?= =?utf-8?B?VGZSb0NrQVhGZ2tCUGdZU0hsZVNzSFlEN2hGMi8vQXkwTU0xTzg2Wk82RzVZ?= =?utf-8?B?NjIwWHprVUxqZlluQzZnQ3RkUHZKMjRjTTVaMWg2Y1ZzRy9sVHRKUVNZOElm?= =?utf-8?B?RHVqU3duclNuVHhDT1BqWU9ucm5GRkFydWNWSlYwaG5qbXBzZ0N5eUVENzh6?= =?utf-8?B?SkxVTDg2d2pDSGI2NFNUd3FjOEtHRHV6QytVaXpCSy91NDc3aW9FZWZQRGpn?= =?utf-8?B?c1pqdC9hUHpnQ1ppSWZIbEM4cjYvZXk5RG5TTFNoYXNQaUpSbU1OM21GU2t6?= =?utf-8?B?czJWT1lETm00b1B2Z2dQQzQ0RER4ZTVLdzhWQVpxeWYrMDlaSEdvdVZmSnlY?= =?utf-8?B?UEdONTc4aklpWlFKMzA5emtDTCsxWmdDblNiZ2luT0lOMHl3T3pjWVRLbFNt?= =?utf-8?B?S0cxbTBPOVZMSjk4M1ZPbHBaTHJ4bVpvQnpIVkhYaEtiTlFkMit1QWhhREdG?= =?utf-8?B?ODNhSGpIVEpEdmREMnl1Nks0RTgxdDU3U0M0UVN1Vk5YeXY4a0wvNTh3UGE5?= =?utf-8?B?ekJXUzUveDlaT2RaYXIzejR0UDBCMDZuS2lIMjFWQXBFeUdBMUFlaGZqRDNy?= =?utf-8?B?cUlRaW5ubTVZSTBRSVpmbDRGRDYwWnZTbmp6UVVFeEtVMHQ3aUw0dkR0YUpF?= =?utf-8?B?Z04yY3B3R0ZMRjJIR2ladk1GVGZ4T0szeDFEWVBOQ2szS1pNV0NCdm44VWNv?= =?utf-8?B?aVZUZFBjT1VjcGM0bXd3QmN3U0FVUnE1YkxTZ2Rxak1wcnVwM0NvdXJxMDJ2?= =?utf-8?Q?FDI5Lch0jN4Ngvrc=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32c1a7c0-6e3f-44b3-d806-08da3e266d5d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:13:19.1829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PnccXT8FP8SF4dzaM+/E8+PHzEVoXkQ5YEZR3s/6Tu998p/5hQpWN4lNIIl9EPNmE7b/O1lajbaYeHp4vgKUIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2384 Hello, Following series aim to fix a regression when booting with CET shadow stacks enabled. First patch is a pre-req non-functional change, second patch is the actual fix. Thanks, Roger. Roger Pau Monne (2): x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST x86/flushtlb: remove flush_area check on system state xen/arch/x86/include/asm/flushtlb.h | 16 ++++++++-------- xen/arch/x86/mm.c | 11 +++-------- xen/arch/x86/smp.c | 5 ++++- 3 files changed, 15 insertions(+), 17 deletions(-) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Wed May 25 08:13:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336975.561428 (Exim 4.92) (envelope-from ) id 1ntm96-0006Xl-UH; Wed, 25 May 2022 08:13:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336975.561428; Wed, 25 May 2022 08:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm96-0006Xe-RC; Wed, 25 May 2022 08:13:32 +0000 Received: by outflank-mailman (input) for mailman id 336975; Wed, 25 May 2022 08:13:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm95-0006XS-Er for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:13:31 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e054db6-dc02-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:13:30 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 04:13:26 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN2PR03MB2384.namprd03.prod.outlook.com (2603:10b6:804:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:13:24 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 08:13:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e054db6-dc02-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653466410; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=POv1bx7iLdSJsiqqXLREhhkckNI2R8ta4CoCgLlMJAo=; b=GxtGRH/71K4d9ap1vUH76g5Y+NJWjnQ86HnIUS94HhKmP73R3lZfnaL2 JkKbFsRpA0pQM2lzHKruQRcxF9QjpR92e5cb2STbhvHkeF8N8cQAZJNhv /VARbbcGyS0xXYwrGFG1/zbsahZ0lDBaKiYoPJoX30bf9Js+3+5nYHGdQ o=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 72524842 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gWf8N6z476+KTl2bQiZ6t+dDxyrEfRIJ4+MujC+fZmUNrF6WrkVVm jEcUWCEO/fcNmb3KNt1a9vl9B8Ovp+HzdAxTlNt+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY124XhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplmKGcTC55Joj1k99HA0BgDwNbL/F/9+qSSZS/mZT7I0zuVVLJmqwrJmdmeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeE+OTuoIwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKWAC9ALJ/8Lb5UD/kB4o++PHHOCJe+LaT8VImB2en 0TvqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZsb5dw21pjiDpBF0ZjZLO+gz6QXIwKyE5Q+cXzEAVmQYN4Fgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZo8L/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:p3yZ9Kyiar+6fFHZ+uFMKrPwFb1zdoMgy1knxilNoH1uA7Wlfq WV9sjzuiWE7Qr5NEtQ++xofZPwIk80lqQV3WByB8bHYOCOggLBR72Kr7GD/9SKIVyYygcy79 YHT0G8MrHN5JpB4PoSLDPWLz/o+re6zJw= X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72524842" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxDXUsvm66e47gMMiMemaWD2VJdj8k6lXhMIRMp5okaFYwmx8GRljMvlCwnCV+m2+sjoLe7QbFuK208Yte0AxP/Xr3/tQxjLX+WvmO6F+sqrpncFz7po6SUfAZo1JQCd1owWTomYg7wveAslVX5ha8ZvposqSX0T53kdhwy1/bT3VRUCCCXu/CIzt4rMuw5mJO6jMqH3KN6Ym8kFf5Jw2CSRE5KXbjHabQez6nI8IIHCaS/uZSjgU2s08WpZIjGCSUssiTw90lBn/3S7sUSP7oCyS5y4JJBKBGwyNLoqvMA1loVSmNhR+3K4O172bG+CxGLxNZgIVqO4Boh+ZIBZ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv4o2EB645bspSYKdAOEJYy3+IXNe5d0keMtqwzqBBs=; b=XoHVZyFQaAslN+Vsq6/7vDKjzzFytUhFRGxEYwz2l7yqOjKuW11F186AIv2Gy0FM+9Y6+lAf34XkIzD6jCAjZji055Ug/QNhoD6Ew+O8vZbpNyFBtD0ArH7TOcHNxbtZ/9LaLPdkTotrF2FvhFsAuZkw9LMVIKBaMTkv0CuYF03nJqril8mmhiHIHQXBoGDamHMHqxIblW3wfVAXvX9/izJO4eagq0qp7MfCVjkTbcgHzTB2C+PsKf+CRjI9NYv54492t+mk4w0n3FH0kyanr0V6PY9dlGQtP9tdtAfCUNWm351XE9KT8e3bDlPs4gHxcmBOb+/ZSQVk36JDcfFZ2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pv4o2EB645bspSYKdAOEJYy3+IXNe5d0keMtqwzqBBs=; b=xJ6Dd3ldkjn6gMC7uRru43S411gHiYa9N/mLSt8Trbb+UGqL6NnPLsctVGyTKWX8kXQIY3bL/7b/vADaj5wqI8rzwtpSpjvEYYZ4Igau80YClqwhoPCnubY/yMlEu6LUDnnT0rSRFSQzJQaM6dZZ6YuZmpJxPEGKTUoLzqaDatw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Date: Wed, 25 May 2022 10:13:10 +0200 Message-Id: <20220525081311.13416-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220525081311.13416-1-roger.pau@citrix.com> References: <20220525081311.13416-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0379.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c25b9bf1-0dc4-40e3-c153-08da3e26702b X-MS-TrafficTypeDiagnostic: SN2PR03MB2384:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oGdZVQgL8YveeSzbuWPpZ8ulCvnDyHMFcb4Ijx7W37impbPc2/SdUBxdGVGGahULzopoGR4sLGzaYTJxs9MKIpG73MieFOwS0Z1jG+6Rvb2V90kw7Mm55tDF63BRHNn/iTmMEq0htHAm+m3GIwMplPkxZ6CkVa4PAjmh51OjR8kOiA1BFD9QcCaZYiGONkK3bzURumBLjtMiQn2OqipRSLKwttMwZxqG3cSalFxYgoHAiv8bnBhQ44CGHGCkIuqySYcx6LQ6uytxSfcgzSygG7hXniP5y2+/8B/mHv8FH8QPyMqJqZ/fsaf5w28bp4MT1z8U2S6UJSmAA+Pn7N35XaORvn4/MF9PC1DrEZcwlsUyBu2yetalxevHz4cgEKtK53OUUfI+5FwiOpBXzuckIO3azk92L6ijQAJd5GjxJEA9LUH3O67WUTxCeHhnZTvdgqC26+FqBwXVtvpb219iYisYENwdgN7EN8sSSp3uj6S44ZTVpFpyg24VK5TOSh8RVnsTEhyXZl2K676ugMNJqIuNMKLAfjtUUy8HVBANqfFlHfYufR+JrnjjfBhL5/ZamNYPvIB/D1cWyXJ8zlvxCl66h0vfs8T5ON/smKBxETVWbpWt9JTNqo0pvgrc8YIHJXghJxpCpQsvW38Vc7Vrbg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(66476007)(6506007)(4326008)(26005)(6512007)(8676002)(82960400001)(86362001)(5660300002)(508600001)(83380400001)(8936002)(6486002)(1076003)(2906002)(38100700002)(316002)(2616005)(6666004)(36756003)(186003)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RStWbGIzbUEySEpCZGV3ajRkYVEvOXVwUXFoOE1TWnJhTithVjJiNm9nMFV0?= =?utf-8?B?TlNUZ25WR1dteVRKWEwzSGo2Qm56Vm16c05aNHpYMjh6WkFJTGlSQmJibUQx?= =?utf-8?B?d05EcVg1TERSVDJueVNucGsvZFJJci9WVnBhSk9qTXpibURBWWhLd0tKSUll?= =?utf-8?B?dUh0SHJFaVhzQ3FJSG1sbzVQcWdTRXVWNXo2ZllxbmlYQUZyOG51V0V1V09X?= =?utf-8?B?NWgzVktlbU5wcldObFNSSVJtU01SL0tBTUN1TnBxQVROaTlmMCs4bDJua01h?= =?utf-8?B?QzFkUHlIbGZPTHk2TkY1UGx5MitWSGtCRTRocS9wN2NrNTJXWXU5eFpUcGVD?= =?utf-8?B?MWxndng3TnBaUFFVcE4yV1pTeWxpSkJVb01KazJrZzRvdGZrY1RBRmU5OE9h?= =?utf-8?B?dklsZWhsbWdBN0JvQWh4NloxOXdqZHJlWmZPbEltdjJkYmRlaXo5OVE2VXg1?= =?utf-8?B?SDlDSEJWZWMvNjAyRGhDV3N0b2p5dGQwcW1TMWlmbEVXcTNBMW9jcU5iUXMv?= =?utf-8?B?QXRrT0FSWW1mQXJ0TkNOZU84SzRUTU5tQU8yOWpGMWhCM0JNaDk2THhub1hl?= =?utf-8?B?dEJySGlMbUdqVXYvVXloVE9FbHF1SUhWNERsTk1FOVZrTEQ5ZVA2VmN5WklI?= =?utf-8?B?VGg2eUtzckNHOGRYTnJpWnZHSWdNckU0VUJpYWl6cGpCWXExV21qM1RVUVlK?= =?utf-8?B?bENMakZUbjg2MDNXQlc0MHFablNwRkNnV1phVENRaldyTmx0TmU5NkZXTFFL?= =?utf-8?B?YmZjWlRQVEV0MnJRRXJHM0NUczJNZ01mWWNqWjd3YjVVaElXZEhMVXR3Q3lk?= =?utf-8?B?MCsxNlB4aWVXQXo0YW9ON1RvNjdJbElwOVlTTm1JVFJXbUZCaTI2WUFUVmNn?= =?utf-8?B?dHc3NFJxd2M1aWFrWFFYU2duVkZvWmlpRzlzZ2Q4K3EzSThuanhBem5mZkZw?= =?utf-8?B?L0FFZGV2aFRwTmN4UnZkUm1PU2ppRHFUa2dPYWFxcWx6a1dsdjIxbUJUd1RR?= =?utf-8?B?b25IcVZWNU5yWTBYcUEyQmhqYi9tWFBUZlhxRlpFUXY2M3hqYnZuQnVpMHpa?= =?utf-8?B?cklvc3JwN2RxWFRXUzQ0Mkh6ZnRyMVBBRGU1NW56ZWZ3K0hzT1VHUnF1RUtX?= =?utf-8?B?Z2xVcEsxMFBZbktQek83OG5zbUEvUkhUV2dBSkNqdUl3OGdGa01hTnZKeXRp?= =?utf-8?B?cmtkS3o5QnBnMzVFOVFpaTNWUDE3V0I5Qkh3NjhDOHdOTzJWdXhtNy95Zk9D?= =?utf-8?B?L2EvTmc2NXAzQk1JMGhvajdnVHpucjhHbkl3MDVwWG5SWVVVRndzMjkrU2h1?= =?utf-8?B?WDIyL2kzeU04ME0ySmVzQTBLOVJMV3lRNDFuOUJnMGRUT25VK1pJSGtPeE5h?= =?utf-8?B?UjdieWF3YlhqWi9ZL1JCZFZyV3lWbDBkb2tucVVCVTViZ0NMK3h6U0ZHNXg2?= =?utf-8?B?eG04Wm9UM0lFTTZOcUNHdmZRUGVIWjdncVVMUG5sK2dFU0VZTnRpdFpGcTdH?= =?utf-8?B?MjdteU5TUHVlczBqYmpmSVAwdFcvZzNTb3J0aTBMY1d1T0szWlpDMExqUWVa?= =?utf-8?B?MlVoaDl6eXBiQ0l5QUNyL1FXY3pnQjkrN3RDYWlaZVZPaHRDUklvWUc2cEtZ?= =?utf-8?B?RkxEMjlJZC9JT0I1aGI3S0pxNk5hS3Q2RmkrTit2dlRHNGpFQWs2WkN5OENQ?= =?utf-8?B?NnlrYUM1UDFCcXBMRFpPYTRLUllUZEJPUXZVYjZwamR6QVNaTGN5QWNBUmM2?= =?utf-8?B?dkVuQ2JrY2hwd3lpVGJTb1E4WGNKYkRRTFpIQTNlNDdxY3dWWW5kZkk0Zkky?= =?utf-8?B?NEE1UzdXeVVKUHovZXBxL3c3MXNucDV6TVcvWWl3NnhPU0JBMXhDRk4rTXJN?= =?utf-8?B?cVdGZmtTZkNqajhaTG5FcDFaZElxaXpKTjJwWG1iL3k3N0Y2VE9ycHB5eUVM?= =?utf-8?B?djJvTFdPcWg3SlcwNGFpSlhQR01QTi9MUXBaZ01mUVA2RDBERXB2R052aEZJ?= =?utf-8?B?ZU9obFFEd0VRRDBQVVVIenZRb012UXpRajBCaFRkNWJpdHJFMWNIMXI3MFhq?= =?utf-8?B?MU5zRmplbWl2Y0p4MXU1UHBTUW1kc2VlckdhU05jOXBDNFphdUV1YndCTkJM?= =?utf-8?B?ZVFIc0E4WEJFS3F5dDl3ZFhEUHpUdUZPQzlvdzhoenFxYXN3THYzMXJISUtX?= =?utf-8?B?bVpXc1gxZVdwVGowMUZyNm8xa1ZJTC9uWWVpTEM4dG45QXBxSjNZM05WcTFn?= =?utf-8?B?MU5aTG9DU3BFSlM0RUJKWWt1Y3V4QVNkTC9TUGJaYzhCOFdEcU1rblA4Qngr?= =?utf-8?B?OStXT2FaRGhaMjJZVjRPQnhHWWpWbXMxeTRrN2h4Z21XWHN3ZVh2WUZTU3FY?= =?utf-8?Q?aTd7evUBfiYChJZ8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c25b9bf1-0dc4-40e3-c153-08da3e26702b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:13:23.9203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bv2HdBE6MOvPW7xXsW9XTBZu9RVBEaokQYVBW0TZsjnUj/5naqfF9saYFoy1mSRHnitxEWSGJ7LaYZ3oF56zJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2384 Rename the flag to better note that it's not actually forcing any IPIs to be issued if none is required, but merely avoiding the usage of TLB flush assistance (which itself can avoid the sending of IPIs to remote processors). No functional change expected. Requested-by: Jan Beulich Signed-off-by: Roger Pau Monné --- Changes since v2: - New in this version. --- xen/arch/x86/include/asm/flushtlb.h | 16 ++++++++-------- xen/arch/x86/mm.c | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/include/asm/flushtlb.h b/xen/arch/x86/include/asm/flushtlb.h index 18777f1d4c..a461ee36ff 100644 --- a/xen/arch/x86/include/asm/flushtlb.h +++ b/xen/arch/x86/include/asm/flushtlb.h @@ -128,13 +128,12 @@ void switch_cr3_cr4(unsigned long cr3, unsigned long cr4); #endif #if defined(CONFIG_PV) || defined(CONFIG_SHADOW_PAGING) /* - * Force an IPI to be sent. Note that adding this to the flags passed to - * flush_area_mask will prevent using the assisted flush without having any - * other side effect. + * Adding this to the flags passed to flush_area_mask will prevent using the + * assisted flush without having any other side effect. */ -# define FLUSH_FORCE_IPI 0x8000 +# define FLUSH_NO_ASSIST 0x8000 #else -# define FLUSH_FORCE_IPI 0 +# define FLUSH_NO_ASSIST 0 #endif /* Flush local TLBs/caches. */ @@ -162,11 +161,12 @@ void flush_area_mask(const cpumask_t *, const void *va, unsigned int flags); flush_area_mask(mask, (const void *)(v), FLUSH_TLB|FLUSH_ORDER(0)) /* - * Make the common code TLB flush helper force use of an IPI in order to be - * on the safe side. Note that not all calls from common code strictly require + * Make the common code TLB flush helper disallow the usage of any flush + * assistance in order to be on the safe side and interrupt remote processors + * requiring a flush. Note that not all calls from common code strictly require * this. */ -#define arch_flush_tlb_mask(mask) flush_mask(mask, FLUSH_TLB | FLUSH_FORCE_IPI) +#define arch_flush_tlb_mask(mask) flush_mask(mask, FLUSH_TLB | FLUSH_NO_ASSIST) /* Flush all CPUs' TLBs */ #define flush_tlb_all() \ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 72dbce43b1..bbb834c3fb 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2988,7 +2988,7 @@ static int _get_page_type(struct page_info *page, unsigned long type, flush_mask(mask, (x & PGT_type_mask) && (x & PGT_type_mask) <= PGT_root_page_table - ? FLUSH_TLB | FLUSH_FORCE_IPI + ? FLUSH_TLB | FLUSH_NO_ASSIST : FLUSH_TLB); } -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Wed May 25 08:13:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.336977.561450 (Exim 4.92) (envelope-from ) id 1ntm98-00072w-Jw; Wed, 25 May 2022 08:13:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 336977.561450; Wed, 25 May 2022 08:13:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm98-00072Z-Ee; Wed, 25 May 2022 08:13:34 +0000 Received: by outflank-mailman (input) for mailman id 336977; Wed, 25 May 2022 08:13:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntm96-0006XS-Mv for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:13:32 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9041dd70-dc02-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:13:31 +0200 (CEST) Received: from mail-bn8nam11lp2173.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 04:13:30 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN2PR03MB2384.namprd03.prod.outlook.com (2603:10b6:804:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:13:28 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 08:13:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9041dd70-dc02-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653466411; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=8F7EfaoMWpTNFHcKmBPjZ/vxeH0S1RpTiRruL/e6XuI=; b=I3VcSb9weGC1vaMZDePovtTOQ6ZtVi6d5VDYgFVKooqsq26Q5aj6VWjl zAuoUHM4w/t1QeEOl/sDfYGEX9kigfiyGfiiyXsGta680gai9Y/ty8tuq Nd++r3vicsxEEqF4LCywpnTBSYlIdnKP2VAJMzPeD1AF3x3T+ucZVwEmn A=; X-IronPort-RemoteIP: 104.47.58.173 X-IronPort-MID: 72524846 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8Ay8EqvDwx6n5ip6Qzbj3d43Z+fnVCJfMUV32f8akzHdYApBsoF/q tZmKTuEOf2CYzP1f95xPou39k4P7MXdx4dgTQo6pX81EStG+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X5 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi92GqrJw7o3fSUGTSZ7B5MYp+7iIyKW5Jn7I03uKxMAwt1IJWRvZMgy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5v3aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3P+PBrszSNpOB3+LrmF+rrYv26fOt2t2udj 0DI70inByhPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQv3qsrhMaHd1KHIUHBBqlz6PV50OTADgCRzsYMdg+7pZpHnoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1bUZxRmYL +i2kRUD IronPort-HdrOrdr: A9a23:PYK6yKsqmZF4n5WVfE4BMqud7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ== X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72524846" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FdCTcHnhrys4QppJRE05fjAi4Vb3Hr4iSZ21awdJoz60fzthZrnoJz8nTsbmsyu2m/veezDGm0Um0mx/ctgSo6pyfcxbicHybxn4NxnxRPvpz82r4j+vT+RXCFHxkgCF+1DCim3ViYxisgmFW6Yz/0H8ct2wxGjyLjaRAD3NuK8MmF4srvFKVjo0rX4mw1Yd2C11IijtGSDyqlNOLsALO1o/e87M9s+M1TJf3xhLFDQ6A4uHjTFBBd3s+hwAGWzEcDisVRGy04i5tKSeqUMnuTqh0BXNvHFHZWL31ezGD86OY6EtySlT25ZkbTJ4akwmwKI+AFt3x5cfIOrU4L2IuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QuFt592UrrbYEvjJPFgpDXuLgHLJ3o7mGGCCs3x5yqg=; b=AaGuv3qoijmUAvXzxRFD8MJi1ekeGChpTXQdxiPd33iPRh8ddhO/dWp2A1zgIUim1vkny+lUOBvtYVan05CXT0BBQz4t9q7WVGkYVJQ7owvw2yE0sDWHkRzojI74baysYhkfWCreuF/TDlojinPOu7Hh0Q8j7chpbGRAwQIkKAJpEg283fIl4xMeZO11Gymt1ZN1RJwtuBPf7Lp0IMBcr7sAdWNQa6M1yicYwwRYxhLC9p2XUpiPESK/XFLIadDHLHzMI657ZOOvT70hbDHM0jOfQtDLFGAeurPioSlGYQ1HUIhnRhCVtB7kdXXwT86pnlSR5jUw2i2/ImgzRfusjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QuFt592UrrbYEvjJPFgpDXuLgHLJ3o7mGGCCs3x5yqg=; b=a9PFeflKCZUswGNDiwe2mS2MXBY976k6ayVUhIO82DAq/vJPD/rR/DOvNTPqXeRsocMcNT4RPTRlLBLW5GBQv9pMOwKIYjqvCH/YzGIJqV2BHxkHA/a6fWbg/7KITfZAEhECYkyQGnXj8JVdtK5UNSpfhxuzedeDxak7mGVJbOQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state Date: Wed, 25 May 2022 10:13:11 +0200 Message-Id: <20220525081311.13416-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220525081311.13416-1-roger.pau@citrix.com> References: <20220525081311.13416-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0020.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5b8d78e-8596-4c36-6a85-08da3e2672a1 X-MS-TrafficTypeDiagnostic: SN2PR03MB2384:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5z9g20HgFkjv5Ki2FLNo+Cjodi08bd77CofPYM9HRIursp6yichgLPAdTVF6awbNSWZ/0McWl6Q2iex59c9CdF2szeEAJXlDVtSXDWEgquaNtkfGQZYX663dS/znvGEt0gA6jAiktLLUwzYWouC2FIdqV7YbGxbBcZ8Xckf8cuLaPif6lJSOtbb4rjgptKfFfAZBLwS3wqnj9ogjkxiUXZj7OvRENu/VbYXFdrbKOwDPs1rwxV4Ti2qGaTSz/cn0SmDkQF0nhHiFlC+MA2z9wQTdf38Y0nb0dc2VCutOs2Y/GcKnyozKtKlOG+IP6IcTW9ezMXB/Zu+B9tYfPcm9OMby6I5mOPhlxiuysbfYCLQembR28EMv6eblxam4lZTfJu9UKolg5ZmNDyLBQmfNl24vmCCJfzL0z75QmT4ziGiiSh1yRZkLSohYdFJBUgREHhDY9GMv9NcdxOguRLwKZ0sr0535JidQoiuAnlkHVpgZvUBW9zXOlHYi4oKWgl6LWwngH/D8mwkgbH5YKVhcUxh7C4Wl/ydryA/163WZwJyZrS25gfq/8AKrxHqMeX5SR1TyNn6ld0Kxhc1tvky/Or6ejPehVHMm4zMWbjZh5aDe6LcQamuahgBtz5BJO0rgjx2nrR2axCQNVB/NTAeY8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(66946007)(66476007)(6506007)(4326008)(26005)(6512007)(8676002)(82960400001)(86362001)(5660300002)(508600001)(83380400001)(8936002)(6486002)(1076003)(2906002)(38100700002)(316002)(2616005)(6666004)(36756003)(186003)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1lnZmJnWi93UzJ4bjZyYlpQV3dKSlpEMWgvSDdPOEhTT0JUbG9GWGFQWnVV?= =?utf-8?B?T0tBQlVkcTUvSGxyM0N4emNES240VE1XaVdRQmwrWi9WSGZacWhPMXU4NkFl?= =?utf-8?B?a1k4UkEzUm9DRmpVTWZqcTdrM2R3TlQ0WkNoQkhnc1J2VC9xYUxtZWFKcWRq?= =?utf-8?B?QzdUc3RucXNORzAxOWp2Z0loeXRiYnVvU2t5S25XT2tvRDkyUXNCWGhxVS9T?= =?utf-8?B?VFZVbi9HMHdoY1lXcmlNdFJGZEJvaUJFWktUcWl2cUJtMllWMjlkWDZJdXQw?= =?utf-8?B?SDU2ZjluOTdrMGVPejhKQ3psRnY4ckx5aXJTbzNqeWQxZnQ2ekhRYnRyU2Jr?= =?utf-8?B?U2NKbXVDZ0g2VTB3R3BDTUE2VXdIRWdGMlFtWm41RmREYVpUNHRnK21kMWFB?= =?utf-8?B?YVZ3RHBzR3dvZnhxS21qN3hnYUJrd1ZKWitmbExWeWxjMDBaOER2YzR6dzVE?= =?utf-8?B?aTNnaTZFeVlCcm1Ra21yMGNPMlhVeHBMdEhML2xSelZxTFhFbGF2UE1pODZ6?= =?utf-8?B?dkdHRkxGT3Q5ZjNPNFlnV2Z3clNiajhDME81di9NdDEyRkdoUjdzajNOQ2RW?= =?utf-8?B?Q3M4MW9ZL3lrckVsUy81KzhnWThOZVNKV051THM4VXdqN3JuT0Y1YzdTMnB0?= =?utf-8?B?eVZmOWRwWGhVK0NWVGJnRUN6dUl4ZmIyekkrOW1lNmhCNUdvclpFT05WZmFK?= =?utf-8?B?UzdXckxrbExhWmZWbWttV0V6N1Y3Tm1MOVY1NHc2KzZNQWJsYXlXVXIxeEk4?= =?utf-8?B?SXZDenE1ZGtiK3Z5eG9FMEpkd1lxa09xS3FaL1hIeUxLY1c4YlRJcU9PUDdH?= =?utf-8?B?bFdKalkzZG1ySU53MjM5UytkQjVkZDN5YnZ2Kzk3ZGRLMEI5RmNkaS9XKzVJ?= =?utf-8?B?RXlTMkdLWmNrQ0hXcG9IekRpbWxCTGkrVDI1TnpscDRZUTBJOU1nVW5HblVK?= =?utf-8?B?VVhQS25CajZuZXJaeHBWQ2RJQnA2ektLZWdYRHMxTGFtL0ZRWGZXMloweE4x?= =?utf-8?B?ZnBRREFxQzJwanYxY0VTd2NGdGtpQXEyVVN6akhBN3N6MU1nemdSTlpNWEJo?= =?utf-8?B?akcxdHloYk9xdk5vV1V5RnBhZWNRSlFQOWNuR1JRbWdsVHpmeFhrMjFLVzdO?= =?utf-8?B?K1dRTGlndER2d1lMK3dzaHphazNmQlNHZEM1S3ZSdGdsU2dNcFl4T2N1TldY?= =?utf-8?B?NEorU3llay84dnZvLzhYZVR6aTFSM2JZMVUvcjBkSXlINncyTS9ieFFsY3ZV?= =?utf-8?B?dTAwOXVNa3RVM01NK2RXUHgyQXpjdE9pUmVEZVlwN1RKU3NzdnRtV04vcTBS?= =?utf-8?B?ZVRJRmkxbUp6Q3hyZ3lybFhrSVdMei9ES01FNTU1aGRMbHBjWW85YlpVbmEx?= =?utf-8?B?d25zdkQyQUJPSDlySS9HdXhUSkVqVUlBQU1nc0dOTEI1Z2ZCakNTQjdlNjZy?= =?utf-8?B?c1lrMWllMkViazBrekxjVmdYdTQ3UWp1MHlhQXUzWU1kenJmUStEM2NoZWh3?= =?utf-8?B?RTMxV0s2THpXcEJXK240TXgrTVJKeVNXV2VoZWpTUW5PaW9sK3JrcTJXYzc1?= =?utf-8?B?aGx3MlN5TTJ1ZjB2cFRwYzE1ZWlNcDAwOTU3VnZ6eUYyTndPZ3NCWkNaTHNn?= =?utf-8?B?K3ZYb1d5TTVPUXgzLzRLaC9XQmY1TzFSZGxNZWVOZHAzQU15WjI0bmg2MlE0?= =?utf-8?B?eTBkdnh6NE52WHViRE5nSXRybnFMTGVkOVRpcmJLbGpuOTNhRVg0ZlkxV25U?= =?utf-8?B?VDEyWFpJcVhla3phcC92OUlDaU5iTFdRUU51YWxiN1lvQjhhbE9LZXphYW54?= =?utf-8?B?UEVxRGxrTmx2VjNWL3NsT0ZhNFhhNzBia0U5MExLTXh5UklORzhBQU5tekY5?= =?utf-8?B?aHFHZnJHSmtCR05kL1Y3ZThzVC9CcTFUOTBtMUZCZ3VlOVROeHF4R1h2VDFZ?= =?utf-8?B?MkIwa3RUY0ZZZ282SjVmU0xxTFI1ZS92QnlSVnFiK1pUYU93dm05RUNvMjJW?= =?utf-8?B?YXRtT3FpcnZZVnZKRjlTOFMvTGV6dFZHNUFoTXBaNFczTm1PZTY5b0hMVUdu?= =?utf-8?B?VkJnZytJUzAwMHBnTXpNU3IvVU5rTks3ek1HT1JvalRhQ0MyTkZhejcrVC8w?= =?utf-8?B?elZnY3lxeDZCY2pCQzcvVGNzcmlQdmJySDNJN0VMdmdKS0JsOWVSd2oxK1hy?= =?utf-8?B?Y1BBeEhoL240OWUvOTNXTGQ5eFB4aVcwM0xFOG16NDd1U1Q5SkxDVGkwczlv?= =?utf-8?B?eVRqd1lIRk9idUY2VlgrenQ0Z0V2OUE0Qi84Sjl0RXhNS0xhZG9BY0xSSjR0?= =?utf-8?B?QUhrOFJmemtuZjRtMGNkRTcxbWpUT3lORE93cEloc0dKSmJ1U1VlRXdXaW9X?= =?utf-8?Q?1dogFr/1mQrwbgSY=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5b8d78e-8596-4c36-6a85-08da3e2672a1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:13:28.0925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 61YIBSJK7dWjfKR3+7YDhdrKu9OgCa3HPi9L8HxLZKwWU0ELIA/h1EfsuBfNrkYlul2EgaEME86bWHdT8FxF6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2384 Booting with Shadow Stacks leads to the following assert on a debug hypervisor: Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- CPU: 0 RIP: e008:[] flush_area_mask+0x40/0x13e [...] Xen call trace: [] R flush_area_mask+0x40/0x13e [] F modify_xen_mappings+0xc5/0x958 [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 [] F alternative_branches+0xf/0x12 [] F __start_xen+0x1ef4/0x2776 [] F __high_start+0x94/0xa0 This is due to SYS_STATE_smp_boot being set before calling alternative_branches(), and the flush in modify_xen_mappings() then using flush_area_all() with interrupts disabled. Note that alternative_branches() is called before APs are started, so the flush must be a local one (and indeed the cpumask passed to flush_area_mask() just contains one CPU). Take the opportunity to simplify a bit the logic and make flush_area() an alias of flush_area_all() in mm.c, taking into account that cpu_online_map just contains the BSP before APs are started. This requires widening the assert in flush_area_mask() to allow being called with interrupts disabled as long as it's strictly a local only flush. The overall result is that a conditional can be removed from flush_area(). While there also introduce an ASSERT to check that a vCPU state flush is not issued for the local CPU only. Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to local only') Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v2: - Fix commit message. - Keep flush_area() in mm.c and reduce code churn. Changes since v1: - Add an extra assert. - Rename flush_area() to flush_area_all(). --- xen/arch/x86/mm.c | 9 ++------- xen/arch/x86/smp.c | 5 ++++- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index bbb834c3fb..038f71ecf4 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5070,13 +5070,8 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) #define l1f_to_lNf(f) (((f) & _PAGE_PRESENT) ? ((f) | _PAGE_PSE) : (f)) #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f)) -/* - * map_pages_to_xen() can be called early in boot before any other - * CPUs are online. Use flush_area_local() in this case. - */ -#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ? \ - flush_area_local((const void *)v, f) : \ - flush_area_all((const void *)v, f)) +/* flush_area_all() can be used prior to any other CPU being online. */ +#define flush_area(v, f) flush_area_all((const void *)v, f) #define L3T_INIT(page) (page) = ZERO_BLOCK_PTR diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c index 0a02086966..b42603c351 100644 --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -262,7 +262,10 @@ void flush_area_mask(const cpumask_t *mask, const void *va, unsigned int flags) { unsigned int cpu = smp_processor_id(); - ASSERT(local_irq_is_enabled()); + /* Local flushes can be performed with interrupts disabled. */ + ASSERT(local_irq_is_enabled() || cpumask_subset(mask, cpumask_of(cpu))); + /* Exclude use of FLUSH_VCPU_STATE for the local CPU. */ + ASSERT(!cpumask_test_cpu(cpu, mask) || !(flags & FLUSH_VCPU_STATE)); if ( (flags & ~(FLUSH_VCPU_STATE | FLUSH_ORDER_MASK)) && cpumask_test_cpu(cpu, mask) ) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Wed May 25 08:25:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:25:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337001.561461 (Exim 4.92) (envelope-from ) id 1ntmKb-0000oZ-R0; Wed, 25 May 2022 08:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337001.561461; Wed, 25 May 2022 08:25:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmKb-0000oS-Nm; Wed, 25 May 2022 08:25:25 +0000 Received: by outflank-mailman (input) for mailman id 337001; Wed, 25 May 2022 08:25:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmKa-0000oM-Ik for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:25:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 385025b1-dc04-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:25:22 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-2ZnN6_5-PDWemgx08xxTqQ-2; Wed, 25 May 2022 10:25:21 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4476.eurprd04.prod.outlook.com (2603:10a6:5:36::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Wed, 25 May 2022 08:25:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:25:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 385025b1-dc04-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653467122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I2me7tb3mSHiU9YqXajMUu0sxh+Usbk71xw8ljT6BIE=; b=g40DBMqRhtIsDbG5JV0TRfdfnBUBL7XUb8/YdfULbYALcvveYzT4zia7pvghk93xWxHveg L/phMBvCv67lAu1oUEHGiRuW/X8SZ/gjrjx1QAJR2kfkXZAD6ytlZkc66RHEXWOlseybWN Fpgdn5a0zTQRJfCnaXYUX5VqhG50/Rw= X-MC-Unique: 2ZnN6_5-PDWemgx08xxTqQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OhYa+r/Rnmf/pPtfJKgq33JuoGwV4bXL1MCpFG5CvEsPxazyerLUdE4CbDDP+Mzt+Pu6BZRZqrEtATEsoN4GnZsIS35Q4XpnjuYWi077h5VBRbdNnNyAxXby6Qjdi8jTcDvaKP3PChFSKo5ngQ1ictwjgpj/oG02mlMiOQaMwnIsoWTHHJ1Rig+QKHxV+3KniPFrUSoRzd+uqNbTzMWJKvq8BgbVbIRzSgXuD+qs35VOq+jCySc+Ppc7p43Yk92Q39dQlyI62ja5x+Y9N9vaY5vGiyF+LjlCW/LG0ZAfrJFnSNXi1U068oNwj6fFGm38TIrLjyne0tr+fBGqSlpHQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I2me7tb3mSHiU9YqXajMUu0sxh+Usbk71xw8ljT6BIE=; b=cBYE1193XpQB5LY11/FiS3SjO6Ui89Xem9YtBabJZP0EvT0HXuenTCS5pNIBIY1muy+wazvEAxkIGhVsrYRsTetsePq/UAF13fA2HKlkSrj/FjaBJB+bDy72FYq4QSDqq4Hq08lPxxG2agFX+lPBgeBoqOLD/iuRVzZYUgLzxdeKk/D05/gWyYIVajbfEE2KfFwsIjYTdoZn7Kac6egCHKpPENpVkmlo5MEZf7G1Q5/+Gd1dYkz0BR5K4j6gcz4vA3DH3q5ZLKaQWKy9qswwTzf3VUaPEHo5XahG3Ti+EVTamByf1lBI4eDilxMaYm5uY/duz5vdqVXYOQcboLScyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <62f142e3-02c7-22e0-3917-3a29fa2630b1@suse.com> Date: Wed, 25 May 2022 10:25:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220525003505.304617-1-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20220525003505.304617-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0027.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::40) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f4a2303-ef84-4642-45b0-08da3e281a66 X-MS-TrafficTypeDiagnostic: DB7PR04MB4476:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yO38tytYm7pjRuFfuTPo9Eqv5hsfTW5YM0NnwRvpuk4/TQNY04gTtLsC0Cgk+qRlIS0y/s1pl5yOq9ghp+iCi93mp/Pq2RvgPEil4bEmUL7SjEBqTR3s8Y33PKDGm8jAWz52djQLMtZGhUTW2K+yAVIvn+yfHiEwBK0i9nejP3EamzX67VtOd9UZRhn457PGRBJirdk1dr11gL4sarWDXXtHYacUmzpHos5aq/rLdGOKdYhVC/2GpqgR+RGj7/AcQ70DkahfSYEaum1aNVbMpFLdUoA/3vnU9l6pUHbA0s5M5PwOnQYwkTJurZJHN7H6lo5zpSd47qfTqLfKCkqqaof05plQmqnGtvpdSOKdYqeTNtuhmx/3q1TzPhwQWnyTJT3DThEfHiqZ21PccjXSIYNSGDh231vOcesZ0RyoKs4iWygpajlbkhxu9Lm1d1uoS7Immo2Y3HEycEw8waw5S86wbEWi54nekgBl3Zlr5juhs1qLJalrDoT9/DbdlvrIpRRZJRCnWqHu/C5FTg68aS4ymC1EAa9PeH1HmYO9aSyUYmov8gBw7wMxi1lPq6yweJd5LWm0nka+Cc3v6HJfnmSWQVsdYX4t8nvFh/jiF+kSvNwwz+XYKBwWoBdAG30DbQ7Zh00Q1TeSlUWdOsSK1+HNELMhq8Go7F/jXDAuItW9vyuavrs7RtkowwGbJqPzIvZA+CsJEsJ7VDslMSfPu45J7jsva9SmmGNIbgPw/NUQP5dNoSharuYkK4D0ergBTy+ljihAI+7jTyH0tSezsu1xHyPFmR0nMUxTJ2A0zti63t9n993G+pQcfW9j1T9RN0cxzwfZKFK8t5OFmWYZ4Fyj1JavDg+YiP987PaIfx0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(2616005)(31686004)(36756003)(2906002)(66476007)(6506007)(6512007)(26005)(966005)(8936002)(6486002)(5660300002)(53546011)(508600001)(316002)(83380400001)(31696002)(38100700002)(6916009)(186003)(8676002)(4326008)(86362001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2QxY2xBT3lFaW9VNnJYbHA1cThoTEFDUWczSDVjQkJKRlVGNkVXSXVUVERH?= =?utf-8?B?ejFVTDMwWm9YMlNCV0UyUXhFOGY5bGlObWoyK09zcXdhdFFndlBwbHRaekE3?= =?utf-8?B?bDV1UUNYODBqR290QjBZOUJheHJYMzg5bEEyRXQ1bDAvbGREVWdNWG05eGdZ?= =?utf-8?B?MWNFRWIvS0NLd2Jyb2JLQUpnZllYRjVWOUtXZEgzWGZRc1gydnVLTVhvbkZN?= =?utf-8?B?YlJ4Q2JsOGcwaTlwSE9OU3RML1ZrM01vZ2lrcnZnellhQThDeTZhdU11akZO?= =?utf-8?B?Q2pTYXpPaklwN2FtZHFodG5oK29PNW1UZUxBZlp3MjMwbjBYMmVPNGhvVzF6?= =?utf-8?B?RHVsbU9lN1ZhK2ltWHZaQmhlY1ROYkl5L1BocklHT0R0ZXZsOXBaNTcrNXJz?= =?utf-8?B?M2tDVGtyc3dJeWFrbGw1QnlrVzFzNVBoeEJoSjRXOXhENUJETkFTREZlSVYz?= =?utf-8?B?TG95WlpsRnlxajhIQ0pyMTQ1ZVJ1WlBpaFk1SGVPbkVhMkEvWmhGY3Q4RGxI?= =?utf-8?B?ZHZSYXpNbGdnaFB6REJybEVEeDRPcExnMWpoUnpFak9zeG95MTR2Tlp1N1RZ?= =?utf-8?B?QlpJWXI3Nzd3NXF4NWRsVmQwWWZaZXRoREV0a3kxZkZubUZyYXFieFlwYXln?= =?utf-8?B?azNOTjBNclRYc2lHVzZSbDBsbDVEeUhweWd0cExQNThXK2NSa1EydGhHV3l0?= =?utf-8?B?dE5IVzY2K3pYRjR3SjZDYzRQTUlwZVlCTXd0dWNET0E1QW9wNGF3eU14dUdB?= =?utf-8?B?Z3ZFZGhGSnlPWUkxelZ4MWt2dkFadStvY2tuVjFUOGtXcDhOM3kzQ2JqYmNW?= =?utf-8?B?c0MveU4rTTdIb1pycFJoVWI5R3pualBPY0dWVFZrQkVXRFRhT0NjcHRIOE9D?= =?utf-8?B?YU5Qd2FHVzMrZ1pKNWZnR2FEenUvcko4TTlnWUJJRDF5Q1pDVFhWTTZzMGwx?= =?utf-8?B?aXR0akhIK3ZNS1dnSHZwRGpvUWhHUW1NNGp0bXMvbDVTYThVbkNvdnpLblYy?= =?utf-8?B?MDQ5aEEydndpdUNIazV0Sno2NUJpOVhublQ2TzRnVzIrQXptSGsrSVpKUmNE?= =?utf-8?B?bGVhb2xlbFJUaHdXOGg2Vk1Ob2FHWTFDMHNpcUlBRnA5L3dmQnhRVFBNUEg1?= =?utf-8?B?RlhaR0NIWkY4eHNMZ1ZEVm92RjFmSU00Q2VmTGRlZlU3VFE5ZGVralBXM29l?= =?utf-8?B?Vm9Oamd0OTJVTzZEUEU0YnBvVjI0UGtoVVAyaWwrcHFqR0c3UStQM0IzU0ZU?= =?utf-8?B?N0sweStJWUJvWm1mdmp4R3R1TXZhNVNMU3FhTGJPUU45NXBoTWhrWFJVVWUy?= =?utf-8?B?YmZHTkpJUFlTZW9mMVVDazlaWDFIcFZ4dmx4S0F0QXQyTnlaVVRjV2NlSFV2?= =?utf-8?B?TC9wNjU5QkVLSHNrNGNWWWZJVndnSi9IWHNkMXZtdURrOUhkU3E0WlFDaFEy?= =?utf-8?B?SXU1NlhOeWFIWG1EWFJFQXBQZFFDKzZpTkJrYWFTS3Z4QVRFNWZCdWVhSG5B?= =?utf-8?B?bmtHUDZwcHV3Zm1jNEM4WTliSGZNc3lmdXdEeTN3alNocnlWYTFTWitKUmN5?= =?utf-8?B?b0MxcFBJZkhubFJsOFVYUFJlZExBNnZwNHgxSExMUndSUElNRWx4eHgrYlY3?= =?utf-8?B?eGRIK05xalNRY05GZVpqTlJydDMrYjNSQXc5R280VDRXTm1jMEE0RU82L2RP?= =?utf-8?B?dHpjWUt0SkMvQmhXekk0K0Z6azgvZFpQcXAybEM3UkhQOExlYitRYURXSE5a?= =?utf-8?B?QS9HdXUrcXU5WCs3VDJwVXdGaGRZdEM5Q2QxYnVXR1NzQ1JOemoxVUkxNmFH?= =?utf-8?B?Y284S3gzWUMxTTYwcllzYThpMTV4cHB5SE15WjhZcmIwVUhWdkpxTnRFYmlM?= =?utf-8?B?ZlBMTjJMczZqSGs4RUNKelpVb3FEMHVMdVp0Sjc2M2dkZzY2bmJSdUkrb3gz?= =?utf-8?B?S2N6QjFTRWFKcktIOTcvWThWcmgrOVN6eVZaakxIWjZ0dUcyb05hZzVYaHRQ?= =?utf-8?B?cHdQV2FMT09CaDJxYlgvU2pJejdCRjBPN0JpSUU0djVRendDR25lb01yNTFM?= =?utf-8?B?dVg2Y0NTSmR5Z1pyUVFkd3Z3MGk2ZzdaRW4rNFNmWGxrSnZ6ZmJVYTRiMk50?= =?utf-8?B?UkR6NnJhRFpzZGdIRHFTdVE3NjZidHJUTkhORnFDakFsNWdmQ0xnWk5HNzBl?= =?utf-8?B?eUgyVGl5WTEvd1gyeEh3L0dOdVl2dGRlWUZiM2dMZ3hHYUY2MENwTXlNbENk?= =?utf-8?B?ZnhKemdLSFJoVmNuKzBqNVlIMzlIUUM0bHloM3RXenZ2ZSthUndSMnMzNmFw?= =?utf-8?B?N2d0cVhLL013TE9KbnYrTVh5NTZhOU5WSVc5K0oxYzVKNElLTkFnUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4a2303-ef84-4642-45b0-08da3e281a66 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:25:18.9964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n/ADdFwQYGrRbJUvWQpsaKTO46axcY4PjcWbyr47+yfwt55gzMWN+3X9JL3h47bV71zwrWpcoyI8vE5JvYWMfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4476 On 25.05.2022 02:35, Stefano Stabellini wrote: > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -235,3 +235,9 @@ callstack between the initial function call and the failure, no error > is returned. Using domain_crash() requires careful inspection and > documentation of the code to make sure all callers at the stack handle > a newly-dead domain gracefully. > + > +MISRA C > +------- > + > +The Xen Project hypervisor follows the MISRA C coding rules and > +directives listed under docs/misra/rules.rst. Putting this at the very bottom isn't helpful, I'm afraid. I'd rather see this go directly after the initial paragraphs, before "Indentation". > --- /dev/null > +++ b/docs/misra/rules.rst > @@ -0,0 +1,65 @@ > +===================== > +MISRA C rules for Xen > +===================== > + > +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > +MISRA Consortium Limited and used with permission. > + > +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for > +licensing options for other use of the rules. > + > +The following is the list of MISRA C rules that apply to the Xen Project > +hypervisor. > + > +- Rule: Dir 2.1 > + - Severity: Required > + - Summary: All source files shall compile without any compilation errors > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > +- Rule: Dir 4.7 > + - Severity: Required > + - Summary: If a function returns error information then that error information shall be tested > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > +- Rule: Dir 4.10 > + - Severity: Required > + - Summary: Precautions shall be taken in order to prevent the contents of a header file being included more than once > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_10.c Like Julien has already pointed out for 4.7, this and perhaps other ones also want clarifying somewhere that we expect certain exceptions. Without saying so explicitly, someone could come forward with a patch eliminating some uses (and perhaps crippling the code) just to satisfy such a rule. This would then be a waste of both their and our time. > +- Rule: Dir 4.14 > + - Severity: Required > + - Summary: The validity of values received from external sources shall be checked > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_14.c > +- Rule: Rule 1.3 > + - Severity: Required > + - Summary: There shall be no occurrence of undefined or critical unspecified behaviour > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_01_03.c > +- Rule: Rule 3.2 > + - Severity: Required > + - Summary: Line-splicing shall not be used in // comments > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c To aid easily looking up presence of a rule here, I think the table wants sorting numerically. > +- Rule: Rule 6.2 > + - Severity: Required > + - Summary: Single-bit named bit fields shall not be of a signed type > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_02.c > +- Rule: Rule 8.1 > + - Severity: Required > + - Summary: Types shall be explicitly specified > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_01.c > +- Rule: Rule 8.4 > + - Severity: Required > + - Summary: A compatible declaration shall be visible when an object or function with external linkage is defined > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_04.c > +- Rule: Rule 8.5 > + - Severity: Required > + - Summary: An external object or function shall be declared once in one and only one file > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_05_2.c > +- Rule: Rule 8.6 > + - Severity: Required > + - Summary: An identifier with external linkage shall have exactly one external definition > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_06_2.c I don't think this was uncontroversial, as we've got a lot of uses of declarations when we expect DCE to actually take out all uses. There are also almost a thousand violations, which - imo - by itself speaks against adoption. Jan > +- Rule: Rule 8.8 > + - Severity: Required > + - Summary: The static storage class specifier shall be used in all declarations of objects and functions that have internal linkage > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_08.c > +- Rule: Rule 8.12 > + - Severity: Required > + - Summary: Within an enumerator list the value of an implicitly-specified enumeration constant shall be unique > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_12.c From xen-devel-bounces@lists.xenproject.org Wed May 25 08:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337009.561471 (Exim 4.92) (envelope-from ) id 1ntmWp-0002IY-Vb; Wed, 25 May 2022 08:38:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337009.561471; Wed, 25 May 2022 08:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmWp-0002IR-SP; Wed, 25 May 2022 08:38:03 +0000 Received: by outflank-mailman (input) for mailman id 337009; Wed, 25 May 2022 08:38:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmWo-0002IL-Rv for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:38:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc5b282f-dc05-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:38:01 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-OJKHBF5LPNilveXCpqcp-w-1; Wed, 25 May 2022 10:37:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4049.eurprd04.prod.outlook.com (2603:10a6:208:67::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:37:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:37:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc5b282f-dc05-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653467880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbpT3yZcSXHDw7MmrRliht8SFh4l2ZuEudQzP1kWPus=; b=f16lBcr8AZwncP7uL6qlyhtIk+OLk80/pH/PlN1Zn9OqYQhi/083ANilFPv9/qN8kVeu/D HY/ptw+gsu1m4Q2i6WGtRlq5mhCTiSDP/GmCbmHYA/MTABrTz4WOzbHs3v/JemxYs4/+A5 qD+q7D/+cJWPv2jxgu5OfXdPI2yFCJ4= X-MC-Unique: OJKHBF5LPNilveXCpqcp-w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDHn91MkUeMT7Z811TnbqoY3xgwJ/diKP/6ICZAOXUq5iqkGxqiOD2PZhv+X3/JiDlsHJ0D/3PM6vFvR1kho6nsONSesRAzTXAeX/Xnl0WGsJet/8fck8wc7G+oGvo6Aw/hjGNJ0HMHdAn5MVXAj84m4e1Pq5frPFHpn5P6A9QQ0DOE0sKhhp16D780pzPZsWKE4YAqFNuyD+fO35NRTStIbLBc1NjyTvyBk6LCKSlSCK6vGcmXZRXCgjNTQZrh3NlLaNwV0KXXTWDC6+H6Ht2kEsj/WwXWSUYRf/W2Nt8y1lAxMmkpg77dUcRTr7ume5W3SVJQVC3guqBJYz4YRuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vbpT3yZcSXHDw7MmrRliht8SFh4l2ZuEudQzP1kWPus=; b=itxqXOC9z4YLGXePcTIjHujw+iXw/cfnEXKHhx+SWSpvaC5hjLYeMj/o7UKIwBN2KM8U5qShDvkSOyzZciY9RS2RN1FD33Fzpdeekw8Wh12tl+YQDUvTYNCzqrGhXN0pTmji3EIQZo9OLKjh+47P07rAm6lCox3Nm/LmQMdTGaiFUuJZKYKoowyorXtqOETH+4TS46MYGO0Sw1dUq/N9o5tkT4wY7vpRsZbPlfIqJV85odNtgWqKMQX4LzfiDIB08TdAvgOujhypBS9cTrbiGkzagU3TOqnUCFOqe5VnTEElZcABFpyyst+7jDhHTYjS2B9v5/k4cTEcNlw5pDv1Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83cbd5ce-7f00-9121-44b3-5d1b94d66f02@suse.com> Date: Wed, 25 May 2022 10:37:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Thorsten Leemhuis Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross , Chuck Zmudzinski , regressions@lists.linux.dev, stable@vger.kernel.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0510.eurprd06.prod.outlook.com (2603:10a6:20b:49b::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3166e3b-759d-43af-31dd-08da3e29dde5 X-MS-TrafficTypeDiagnostic: AM0PR04MB4049:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WwP78UU8d82jS9vXHiR3ZCG96ajbYTjupxiVv4m99p/gARtERhenblFCHo2cLpbRz6OkO0qyN7AxPsgvlkWuTcREX+bfTfiP8auotCRL/1tE9GKPJO24/bApUJQsrxiWK3aXd9dp5mhDy5JdTX9ePIY+B4JC2kBS9A1KQ91+SZrcgASCinKddr0Z2Gwc0sbqrN5sFUEyU4mo/0HN8i1yqu2G7ivMO01zh6lC/qRhXXNbM0klEu4nmcsaPa7Hs7cpmGlVeyxoHH4VHc+QvCjiWAm3SJevs9xw+j4leOQWTm1+wNy85R+koIoOh5PgcO/jKGRXaesev824veXCIrMtfUza9UfhqnrkRzXMd+fs3Pdoh82YARACIgWeiCanlzWAG6FcjjK8ymPLV2JJ96V51vxO7nnLLD6Y+s+KTvwBA2Nke9Ju73lBukSR2NapEl6EIFfZ+nTC0hu0nGyp9jfKOVxqbwfXIwJhYaHx+QF1nxzArUpwrN6hW1+f4WocyiTfKen3POprwbjU2skCzgmsnkEE4SG435Idoi2cel1H0QXNrnWPCzp3AmYkbRR1VvWnQySU5K7ZN5M7qc4XYuSnsYJQXhoMGKjze+nB7/BekL/Zb9x/r6vakOf8NkFRS5Uaxf8ymA2L6vqmaa8huUZOMZOdN96ZVmBiLLAvC6UXfmFDkfrUrXo8Tdfts3FVW76zV00ltbv4yN+JrdCMiaNEZnHvL4iA9ZiidBM8TUxPZWIBRMrcSLBtHmilRN8ktg/RgV240xP8tb4K73TShlJj7+PEK7GSDycFOe7IiqgnGgVC7T3nMWB9AMS7rK7XYNdt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(36756003)(53546011)(8936002)(5660300002)(54906003)(7416002)(83380400001)(508600001)(6506007)(66946007)(4326008)(66556008)(66476007)(6512007)(26005)(31686004)(8676002)(966005)(186003)(6916009)(31696002)(2616005)(2906002)(86362001)(6486002)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVBYaXc4Zm9SSlVsRytvWGZVRE9raWVNSlpOOWM3Nkt1Znc4MVR1d0xuUWxv?= =?utf-8?B?dTlpL0tQbC9XaFAva2d3UGkyS2swVFU2M3ZiRW54ZmlDakpublE4dTdMb2h3?= =?utf-8?B?eWtab1NUc1RYaERsZjRYTVlkbm1DWkJ1eHZTUzNuQ1FDV0VFajNJektnMkw0?= =?utf-8?B?WVBmRlBUV0hKTVFVcGpWNk5hV0V6anBuYUlSQTE5QTd3TzNFT0VGdmxJbCt3?= =?utf-8?B?Q0pwOFVLQ3RLdFZZTDJFQnQ4RjZLVG9kd1BMcDdKQ3hMS29rSUhWYnZjZktq?= =?utf-8?B?cUIxMUNUZlZyYmg1VGhGVW91NXRUS1RqaFR6NEg1R3JZVVhNUEk0anBMNkdB?= =?utf-8?B?UktjU1NFM1JpRC84aFFSWGRYZGxKZjd0anFkWUN0U05ZeWxjRHlXbHRXeUZy?= =?utf-8?B?NTEveG5TTHI5QTRpc1VkdFN2MWRiQzRhMUxBMGxOVzBKTldmNkRzdHFPaHdH?= =?utf-8?B?UzFTUFZLQ0h3WVBQWkRWMXUrYm1GWEpURkt4VWp6N0ZxS0xwdFdhNXZ4My9P?= =?utf-8?B?MzJBcWtEQUZBSXpibXBmUWYvSWw3MFdLcXpPQ01ocEhrRmR4REpQRXVZaEhk?= =?utf-8?B?R010MkVWVDR6ampiN0N5bVVENE1HcGdXeTNDbDBhUEJmMU1NR25kdXBScmlz?= =?utf-8?B?Z3R0cElraElyaHB4eWxHMFgwOWVMajB6czZBM1VxUzgrelEvU3Fid3VvaTY0?= =?utf-8?B?dG9pK2puTHpqckloRDdtaVRjcExVbXR0L29VWHdJT1VLUi9JTXBieFJXdnZL?= =?utf-8?B?eklnTUlXT0N5NHhDejdDNEFJazl4VXBqd1dzcnFBUFRxa0NYU0xyK0h3bjZl?= =?utf-8?B?cHFIaVQ1REw4amE3MEpnRjBHTnM3VGNCOTZnUmZNOVA1ODNoUERReGx6clA3?= =?utf-8?B?SFRTRUNiUVB0RW5lODFlNWFlbGJWY29QdFkzYTRsNjJTL2lscDFyMFZDZ1Ir?= =?utf-8?B?ajlER3k0ZzZ0SktVSWs0WnFmQTd2Yzd0cTVndERpbTd0WU9ZT3Ewcm9wWEFJ?= =?utf-8?B?N05US2UzeE94cU84bXVvWnFqTmZ4VUphMEVnbmFKb0FQaVlpb01HOHpnTFJn?= =?utf-8?B?NUluSE1ZdVhUTVJZYnFqdVJOQ1ZJNzRtK0ZpcUs4UFpkR1FlMS8yT0RVeTBS?= =?utf-8?B?M0xBSTJVb2VXQXB0enlrcUlkWk5ZbXRWR0N5MklCNkovUXlHRnNZc0JPbWo4?= =?utf-8?B?YXpEN3pTZDZJWVhKYWlRbE5SRFZjS2tNSEJjQXlvNnhGWVRpU2h4NmNXUGpp?= =?utf-8?B?bVR1dmdSNm8weHUvY0djaDFWRXR4cE9ObjduVXVJcmdjaTljeVc1RzRMMHpO?= =?utf-8?B?RkNPSGJuWnVHRndlTktTM0plbmVCdis4b2lnekdQVm5tRkl2VGlBWmEwd3Bm?= =?utf-8?B?dDNpZUJHR09lK2VGbnJuNFRDcUQ0ank3K2xGZEx4VVFEU0xrYmo3cUxIQm1o?= =?utf-8?B?R2dwaGJ2U3hUVndiNEZRYTB6V1BjYkRuenkwVW1jTjZSVzM4RnFiSjlNd2U0?= =?utf-8?B?VHphWVloT3ZOb2hWa0dWc1V6SHU3MnQ5ck1Va01ZcExJYk9Nc1ZlSUljWXBQ?= =?utf-8?B?WVJhT0I0S2k5c0lhQTVVTjd5RFdZUG82V21WUzUrblk4RnhGT3Q1djBLS282?= =?utf-8?B?RDdoOHQvTDhQN0d1eXpNVmhiWXhJSHM1RU1qSTJ6eUNSelJwTzZNNHZpbm9j?= =?utf-8?B?RDZtNWRBU2l5UEt0eE8yNUREcmdqQTBlc1ZOVXlrci9rMUd0Q2hMb1d5M3R4?= =?utf-8?B?NWlUblhvcDlFMG5USXNGMXlHWEMvU1VyMlZnVVRzNytpajFDS1h4Y010UTRU?= =?utf-8?B?dWtLRTcybzA0cmZoRVI1bVp3UFd3b3UyN2hpVjRQNkViTkM1NVJ0N3crS0dP?= =?utf-8?B?cFF5UmlkQTNVc2hrRlAwRmw4T2FnRTVoSEc0RTFlWlJtWVpmd2l1dW1OdmJm?= =?utf-8?B?SjZIMFhxZk13QXozKzVrcXVSNEZJUUJLN0pIdzJtL3BtQnQra3Qvd3FUTDEx?= =?utf-8?B?SVFBdlJXWWprNXRjMThwVXRweGJLckQzVzRmclpxT1lIWEVvRjJaUTllZHRx?= =?utf-8?B?YzdMd3VkWGRsWXlKQWlYanpvdjBFcDhzcnhmVXVrMHdvVEdXenVXbzBBbFFF?= =?utf-8?B?S2xCOE43SUQ2UWlVdnh4a0w5UElSVjVVeDVMNlJFQS9sbGEwRW1ZdUFBMGh1?= =?utf-8?B?d0xzK3JuekNqdEFhMmh2VEtHVTlZUkpxMUMrV3VWNmh1Q3ZxL3Q0Sk13Tmtq?= =?utf-8?B?V2t0b0lhNXZ2U1FBUlJES2tibGpaV2pSclZ1S1diR0pCd0t1VS9EZlNyMm9m?= =?utf-8?B?Vk1HMEYrWkd3L2NCSmlSVDlhZkc5MHBVNnZpVUFSOWNEQ0Q1WWxMUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3166e3b-759d-43af-31dd-08da3e29dde5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:37:56.5119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SfUW3x+gPRKMK0LNQNnVKDS/effpSJ33cfgbsPov83HWtlAev8dRsI5IeW0bkWf7OHtetBI2KRXKSKq7NwUOzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4049 On 25.05.2022 09:45, Thorsten Leemhuis wrote: > On 24.05.22 20:32, Chuck Zmudzinski wrote: >> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >>> I'm not a developer and I'm don't known the details of this thread and >>> the backstory of the regression, but it sounds like that's the approach >>> that is needed here until someone comes up with a fix for the regression >>> exposed by bdd8b6c98239. >>> >>> But if I'm wrong, please tell me. >> >> You are mostly right, I think. Reverting bdd8b6c98239 fixes >> it. There is another way to fix it, though. > > Yeah, I'm aware of it. But it seems... > >> The patch proposed >> by Jan Beulich also fixes the regression on my system, so as >> the person reporting this is a regression, I would also be satisfied >> with Jan's patch instead of reverting bdd8b6c98239 as a fix. Jan >> posted his proposed patch here: >> >> https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ > > ...that approach is not making any progress either? > > Jan, can could provide a short status update here? I'd really like to > get this regression fixed one way or another rather sooner than later, > as this is taken way to long already IMHO. What kind of status update could I provide? I've not heard back from anyone of the maintainers, so I have no way to know what (if anything) I need to do. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 08:40:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:40:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337017.561483 (Exim 4.92) (envelope-from ) id 1ntmYd-0002tq-Be; Wed, 25 May 2022 08:39:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337017.561483; Wed, 25 May 2022 08:39:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmYd-0002tj-8b; Wed, 25 May 2022 08:39:55 +0000 Received: by outflank-mailman (input) for mailman id 337017; Wed, 25 May 2022 08:39:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmYc-0002tW-Ge for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:39:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f51b35a-dc06-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:39:53 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-xAFwCiZjNKSXJ43OqhbeHA-1; Wed, 25 May 2022 10:39:52 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4049.eurprd04.prod.outlook.com (2603:10a6:208:67::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:39:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:39:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f51b35a-dc06-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653467993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZOJ8d7N/5mjhYGaP5sUR9KkiDPtelkSIVEfX/iOrLko=; b=kq3JqiwbFueNObY8IHugH/PxY6xz6Jikjgp3pYE1bmR8jqcX3OSvhCIYhwofRAyMwzgc23 v1hsWYcGVPKN9cBBH84qZ+FCRrw5Zg2k2B/rP7yhwCKPpISkB8jl0195HSjF8OBDAEzp8Q RWvPTqEUX6oZCtGfO83YA504DhLcSg0= X-MC-Unique: xAFwCiZjNKSXJ43OqhbeHA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g//74Lc/ypWlMpyz52uqo5P56tTulrckGHNqh5Jr0N4Odb7VMcz8JMJkqu0/NyDt+5BwYTRga1WV5IAsqJ3tHm26xbGjGzgQivlLOzDo6GObdyDqczaBHk3tAbqrOFVd9PBBnNoRyuuZY1s65EGtu5wNXQxZEnQEKhJWXXqduHnzRO10xaVgySBXvNF69Nb+YundhFmxDP0KxTVOOwC7JMTafv8Npvg7ZiZOnfckKP9nR3/qlwCByftG2JVnGd/HxxNdC5F6SAc+N1Swr5gBZir6WwgyrXRsG/nB2wO5GP+0JZBdwoUmloW7TCIPHpCCx9TFCy4Y4HDlSr/AL/sKMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ROppEHIVTwCrJkO18n0PDdJK3kF7A2IE6j+5PiHkcdQ=; b=ET1tc8iOeZBlv/5kYUbgzdziY1ACx0z4zYdfsMJ+eXGi3Aw5fE/FQhALED7cXiSwXDy4tDZ8ucxEluTIN6kGltJn4hjUh0t+LockIzj4ZbeNSYkTyQtia4iW9w4zUMPBGPpe/B8gssrsoBNXsaT6KQVdn7n+gf6n0fUv2AQQmMm3UxPSelw8pwmNSikVHnJb4K7i6mursY/yp6A+5tNbh6hPPopEh8ZALisnd/qegZyw9z7KX/WHXkymFiW5kUtXlMATRDr4GTbZx4GgiICdxWqYS/xVuo2eXfmla2P2+kK6s5Z7w0y84l0BY9HnCF7EtL+Ba0Ipw8sTunRe0DWslQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f158346-07d5-89d3-f043-a7e5d71839c9@suse.com> Date: Wed, 25 May 2022 10:39:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220525081311.13416-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR05CA0014.eurprd05.prod.outlook.com (2603:10a6:20b:311::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9daf7a32-df60-43ca-0bcb-08da3e2a2215 X-MS-TrafficTypeDiagnostic: AM0PR04MB4049:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ya33Zv46ZwSEo0YuLa9LiF8Ryqh9hy8HVl6r//iFGFtk6wPEiM2wTvsMT0RuoUWIkRsjh9e//lWbe+JmmpTNUKVutEKSN0OgLc3JWHLq5wsQt7H2wdfkJI202n8ihgTDoiHmiuEI8CdQDd2FWCMx2cN9diPyNvDAAr9XbRipxrpCqdXTBuNElQM6i59mhpSvnrLhcbm33lQWNntaVaH1AgDIJPAiWZdAWhMKrc7w0gTFw4b7sJcZ6nu+IAxq/JOKCbUFt8Ra5LKohVXONEjdrWgD8Hsyx/AO/VL5hhywYiMqnUNi9gZnGaCAqsYXsYHFP2OTFwHL9mly9SNhxBrF74P3x1je/A5s3gxObBgOCRXFBXJRXNkrnv1J28oLTG/GrPkpSMVUk5dfIBA6njfLpB4Mu7rtP8V46b2/1qkCBor4bt03CtyQ9uo8KQSpSEcRa4zfNMRB5oA/AZZjOD6euXko76Ck4aaYo9WUrUqN8sVJWXfCBObEunkm0PMoUCamCLhHMm5d/zXO4aFJsXz8CCdd0JqKtDJGqRncrYjHGFtOungu8CaDb6zUBo7AVf+Tzi/OsLTeBpbycrzXY3iq0CBq8T/eeL0nmbbDcZX4CEv+ojvak/g99MveA4/noT+3rjHJkDKEFVGWiHEUiuVoA7XJvmqXGQ/w7UaAlszGgWcemxKvb/PBUOj1qdZz8MXUyT5OhJqZStMsQodTmlWfBSQBAYfvhH/wodU9pDGVxBbx6nRW1tg2YHjGqq53OJnv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6666004)(36756003)(53546011)(8936002)(5660300002)(54906003)(83380400001)(508600001)(6506007)(66946007)(4326008)(66556008)(66476007)(6512007)(26005)(31686004)(8676002)(4744005)(186003)(6916009)(31696002)(2616005)(2906002)(86362001)(6486002)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nyUZCO/udz4ep06jxLAklH49jFzv4mBHXw9f18IbGs6AwxttJmFT4IkIIVES?= =?us-ascii?Q?VwIYBsqJ50+L4HTD8wS86wnsI2/Bxp8N4IeES+ZwbcSZkJIhgl0JXHUX3TKj?= =?us-ascii?Q?oHW55i6GHsbCvxoI3Ja3isJP3Fh1o0izsLpK/e3Di74i3wpRFiYpVWJhk6R8?= =?us-ascii?Q?LLKWQpXlTyoOsrpbPGjQEpj/ZcbXFraSFsniSWIrlRJBnw7FuqcYFt+kGdk5?= =?us-ascii?Q?HIsuK8+th0eo78BTykzOoMT7MauUHo40FqLfmYqc7Y4V1XgaZnpaHaahV8kd?= =?us-ascii?Q?9UpeT2/oHA89axtUSbF+48D8XFMYUFDL0aiSkfbG8xwe/FbUO444NXIH5T9e?= =?us-ascii?Q?guqe9FbmN1D4RFfYmqhfz8FNC2cxf3/Fnxw48kJiOy+z5xK/GGJLsuQxXt3W?= =?us-ascii?Q?lDi1Ex/jpi/51i8coTbsyl5QoqPlFJwauedsIiSyziA9jc+26NqrHx2rnODj?= =?us-ascii?Q?g0z4m3bNZ8TcTw+CmX30fz//IULGkCLseQYlxpp3B85vv0cH9l9ZYFhb91MN?= =?us-ascii?Q?kubaOBbQ6pdaXRsOg/xGpr9355UpW8YMw9DRe6IaEUndAYk3zjFR0uGRmzLB?= =?us-ascii?Q?HHkrOQRHqHnjRsq+hSUWjjZDZUqcYLPVMYutGgC/CZQIT3m2LLEwo+ydVuwR?= =?us-ascii?Q?ogPwZ5VjFNCTprR8xHMjrEMu5HOf/A5mzuX5h5aUMi/OsHMmtg+pmbSSCdPX?= =?us-ascii?Q?AmFvK/fxEMOoZ5cbSC1gabrSyj/Q4iaxFNSt8E83APMyNJMOTSy+p74tyLsV?= =?us-ascii?Q?voeCnQEK5ScNU+tn5uqYZji5rXQ9J6hQidUMeauFtnp94BBJNcZyHdurxLwV?= =?us-ascii?Q?yE0FuCSSj0Wx1UBElQ2g7SCQiZpM+Wbs0nDaa+uPxyOfp9FimDVH0vYv/t6q?= =?us-ascii?Q?K1N3dOWgj5zmOZvqeqNdddBBdi5NZbU9LLaE3SeNTGdizw2X4mhRl6yA9HHe?= =?us-ascii?Q?tRR14lutclOWf31/ZA2IxxJ0xxwygrWe5ed2cVsOqQce7111TwBhAisxSys7?= =?us-ascii?Q?Z7w7nTl12fP3WAS5uzt+pYDDb4nPDUgmNrxPv3XamaM28CTTF6jQmLHsDJd+?= =?us-ascii?Q?bs8z6ABhlwbjKrC5KIC5WnsmRyuZ9nHk4UptGem61L1SWAgAo5aZS1MsUC3z?= =?us-ascii?Q?Bjt7N65Whgzt1yVUs/AAO7DbjphQt2gOuopxarGIzywM5VKQ4SaoZ+owQR2T?= =?us-ascii?Q?EJHaTYiFdXc5+Od4UKnMoU0soxjioxUV9ww0s957ymwULoqSAFZe/gs3EhFH?= =?us-ascii?Q?clm1EZLy3iMmlzJ/Olw/XoppTF3OtRZSrYdyS3a95Nfq/MP6dqPywOjIGseW?= =?us-ascii?Q?rimHX1/h6pUg7cglzKbN+IkxZ1XlR091+rM3vt1MnISggIyxquYXrC7VLiX3?= =?us-ascii?Q?W+tSFeS0am2CdR8aOyyDW+OerB8KCN7CIDMeIlbk5Cg/qU8SUuRyeMCsjl+a?= =?us-ascii?Q?6XAt8wvfgZwZklDqc+eiKb1PLZBAS0B897q7IjHNYrBWV3qwuGRDn6ETZOJC?= =?us-ascii?Q?ADiEHJZZJ+wAqc7605Bgd38ZwpY1VRfxNjz+pAqwkWLZJyanCbE343yVqR3B?= =?us-ascii?Q?Q9XgNkWVqh1DiQ4NyQVxd2m1A+GbgIgxElXy5FhYFvdwYK78mZhfz9/uEjcM?= =?us-ascii?Q?Fk3OtfpmuBRB42pd2DjB2LfU6AdrZfKHIDzxjjrE445p5mN6bkv1D6wBfIbH?= =?us-ascii?Q?90dr4gOIA0po69XSm4qW0rJShpArvLcePcSjKveojaPSq0sBdE+vzWRi7zHb?= =?us-ascii?Q?5QW/qrS6Fw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9daf7a32-df60-43ca-0bcb-08da3e2a2215 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:39:50.9105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8tJpObdEDwmt5P8s5eed8Bpk2I1ew538Xh7Sxics3POzyr6d/X/4j8od4eW1CZwSp26YxVNGSMFjQVj/yS9L6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4049 On 25.05.2022 10:13, Roger Pau Monne wrote: > Rename the flag to better note that it's not actually forcing any IPIs > to be issued if none is required, but merely avoiding the usage of TLB > flush assistance (which itself can avoid the sending of IPIs to remote > processors). >=20 > No functional change expected. >=20 > Requested-by: Jan Beulich > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed May 25 08:42:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337026.561494 (Exim 4.92) (envelope-from ) id 1ntmad-0004KA-Sz; Wed, 25 May 2022 08:41:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337026.561494; Wed, 25 May 2022 08:41:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmad-0004K3-Pz; Wed, 25 May 2022 08:41:59 +0000 Received: by outflank-mailman (input) for mailman id 337026; Wed, 25 May 2022 08:41:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmac-0004Jv-Bc for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:41:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8933c8cf-dc06-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:41:57 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-J740Ea8ePgOW6uwEgJJLIQ-1; Wed, 25 May 2022 10:41:55 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8425.eurprd04.prod.outlook.com (2603:10a6:102:1c7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.23; Wed, 25 May 2022 08:41:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:41:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8933c8cf-dc06-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653468117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y3zvJ+3CbKfVe5BuvouP2HmiIFmU+zLfOcH4Jg3T4Cg=; b=iDEUb81pMwI3BFzKJ+IJeF0Jl90mIjUvb2AIlvv+tlOvwp3hbvokHKNoh1aZaTqGLrg5R6 /EfZnai98MHXxLrtwQADhMuwJWoNN8tE4ThTB0QVjnCSnH0jjg/UaptUo3ALJ9Ehxay5cR h9oi+UDEU4FCr3xlCENqRT4RKbWOOc0= X-MC-Unique: J740Ea8ePgOW6uwEgJJLIQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X2MveAswbsFe0dwOaRER8HEPkA7avgQ/ihtX+aWIYrFGj15uxViJcfFWB+GUViL17ACeNWcSMKuPa4Fu2J0zviOlobZnF0GLrtTLqZTfEMTqRsmk1UBW6+tteGHrwl94XlHbbCiwFIRW7oLGeRNq9qAS3ZL/tQ5Doat8qmDCDtBskFjXKs43ew/Vk8oEiUke27KC+q4NtZD0XITV2Dd6rrqsEars1CQq7E3ZKeKYEhRa/3f2AH6A+b1gVkshy/g+3cfgHunFsjzfWztGUIsBRfkzxafiBacPesWTpmt2hQah2FCX2Kd7E4dfQasfc3wKFmsIo7+x7YjacAw+Mz8XoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QDjnvdxJLioNfy/x/qT7aOKTN9KZ8mSz1GaRpPQ9z0o=; b=nR4crWXQconKDYEz230n/YdkcMPjg9ftdm6m8tZRtIbcFOFaf+YsY3hu332t3aMn8flMWB7Vvd7Yl3IrALRg8C69gcbgcVr0dgIMumofWuTtirh4oQKZCrypHriep/D3+UX/3i68NbuxsEaNRt/u1s5cZY/VAOqhvbpYJVFe66R426K56yiyFlBS+KiqElINZck6+6zaCbtqEb4PBKQJcznke2MEgdoZYnMPavmkfPrGTcMoBaJWtYhdhI7EiWWuw/jn38zUHkH3U5a5K0BJw9sUyXIQMnz8em03kTKLdE6WLr6pPLBMFSxeQGkiugVO6CjBwYpTWsqS5AXhz13IYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f030cf7-fbba-6ae9-b797-f695221ee081@suse.com> Date: Wed, 25 May 2022 10:41:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220525081311.13416-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0502CA0021.eurprd05.prod.outlook.com (2603:10a6:203:91::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fce41658-b27c-48d2-2bfa-08da3e2a6b1a X-MS-TrafficTypeDiagnostic: PAXPR04MB8425:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UDpAz37K99swBEPNIeLNQLWrlUVtKx9hTFC/jgmi9PuwSZaOXBVdxFcD7A2ZAupVw3r405CJVoJ+IqkWbsb7y50OiSWHCqNioeq8Gu9mnvPxR1IFnSQmeTElS+cuZxNTg7BuJWUiWVyZY+SJjNUwZAPjh0IAIDjKhRoIcUJ+VdKaNrTfMhzdx4EgraCS3N9hDZErYU4RsFT3rdAevqypzoNPLSaFtySfhQCm5E4YX65b3YuV8SgVLmxWl6znGNid4jKvAyTJNhhdHWla844E7acafFa9KiuVRfTBxh8nb2lxV5cNYhZvs5JuE8CW5kXeYbj9p0xqkJK8LMLUUReG+MA1tAaavqkb8smBbUgM+tZwWlZKsjNQUu69oEkScV8JxgniEtQtVsznlLL4vlRegaxX5LXpirE5ZqDV/U7MLUPOJi2xNh/rAc4XcnTHg2CwZ2EyyXotWeEtiOV9K9g5pfbLO2SIof5DNncFmfkRTDoSryQzhKq0qEZizhJ7OfXXl/USiJN6Prht0L2Dc2KJ2PirL+7m/NiR0J0Wq8O93MotG8/EFjtuautf86Z9y5V+jdaHSaE0bZGMpxsBxwwVmiCY689YoD4v5LyQ2BOBE9NYGITIYPXoRs5XLKrTXk1BMmHdxPu26uipiFIeEx//mJROn0j3BTncEEI/XwM8YnCaaECJmSMlqZgnKPkgez0MowJAyYOHIsG8WmJFJbjcEwSQsnFZSzQDiMoPi89WLgNMSn6ZmHNuG2omh7683bgW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(86362001)(31696002)(6512007)(26005)(66556008)(66476007)(8676002)(4326008)(66946007)(508600001)(54906003)(6916009)(5660300002)(83380400001)(316002)(6506007)(6486002)(2616005)(38100700002)(36756003)(31686004)(2906002)(186003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LKWE/VCP3Cr3l32HbtlvPjx4aDCcWA6PGS+SOMlgm1Ioxwief2Pq/GaJZ5T2?= =?us-ascii?Q?FCcdTymSsaDtAz9noQYSNAsuwL7UiUjpM31FWDw2YUXRvMl/IXSKlPh8qtxb?= =?us-ascii?Q?53BnANie/f2gYZ0H2CvyPGwinodoxI6mSp5SIlLqbA6mAdi3+4fr5tyqULjB?= =?us-ascii?Q?BzeiaU5rSthXz4CGEJa3pDswSzK6tyCM2ARMJzU/J+1gvTfjIAbx599Q9oVa?= =?us-ascii?Q?JseUlcCRti9vbe8ekm3QbYCALySm7Vgp6dsMjEo4nrBBT+RvmeJfsjnfbO1v?= =?us-ascii?Q?ImSAjtv6DUpOxPBdBGEY1NUX+L5ZiW3Uz8L5ZZ3WUqO9iJMx0O2JuYxA4r+k?= =?us-ascii?Q?JTKlRzBUkbQtQPDqtQvQNRLnoUMmSXzcICbZxRZ/EexJ3etiXOWPhXnuJWzs?= =?us-ascii?Q?M7RDi/Nyf9Rkrkq90tN1R1OZT3vprsdAizzaQlWvdYgKCWw/sKtmU3llLOi2?= =?us-ascii?Q?DH6baln6fx9Q+21qXrK7eBeotJeE3dIZlzW3//z0jRrcReL+/bv5xoDiSm5N?= =?us-ascii?Q?nQvxMuu/x9287vW3f0giLn23AJEFuJYbmJLz+zNgvWbhPdrXejNojy4dz1Xz?= =?us-ascii?Q?wmGUW/3byh/JDStM7iOFJevkCLhAeVSSQ11CDsPPdgpunJ1m8zGQg6Q9WVhN?= =?us-ascii?Q?YwCVhDmmhDhs8AkGyqrZd7i0wDQI7KqCeZRAQQ7RcFAyw6OppRkVYTGm1338?= =?us-ascii?Q?G9aEFK7DZGKGHNt1NXQs8H+Wq4Qx2mj75M0e7WaTO94HJSE+cAI2gLVXb2s3?= =?us-ascii?Q?UI8DE4GlZCk8w/A4Q8whYdF0QmslexRXK1Behbe1qAXiDoJYUvcYVz4cpq/k?= =?us-ascii?Q?8LPXJjkUu+w126gjTduaF4xeIPvFlWruEbWDnHEAiT9jcGtExlgN1Xpqfz2X?= =?us-ascii?Q?bVz/w8cuaDaARDOZ2pw63XSRvQcs/vrM8O1qt83PC1oIsNnAw5BuNOYajrMV?= =?us-ascii?Q?vgb7+DFyD0ABSY/TKwjyqaAkOwr5O8QS25mKA5BLMANqI0AsrvpuXQmJYChT?= =?us-ascii?Q?6nNsXLfPGD9KLr6QwumAQqCbNnj49rPFo9NnP+/dgLOGM4tnWRYmG1/4Lr7H?= =?us-ascii?Q?uvoNhlPwumZGRCls25y2d5czMD8L2YEcU2W7sPFZ/7LgrQiyRhBN58X45nEm?= =?us-ascii?Q?V0oL/LyBiVNLKJ/4YnFujbYm98g8Z0LQ6OtHbVja1B4eq3amnGAM0oDSR7z/?= =?us-ascii?Q?rmsQAenumgj2EWMstTboF/ByNnN4pcc66ypcNvoGhodj1DbdvN8fcqu4Iy9M?= =?us-ascii?Q?nqPcfFemeFsAk4Ge/8X25AO0qXr5jV2CVyuJgxyxUkSjCLiePASw5DsSLsa4?= =?us-ascii?Q?3+ZDUvXm2tNalGmOHiVm/cA0i148BjxoBX3hoB7B3rPdL35KgfJTe1Ufb3K5?= =?us-ascii?Q?I8bLbmHNmn064U6xdPQFoacU4dVfmd6bUq9mTX+lsBZk1/bUfF1QZPt9stnT?= =?us-ascii?Q?kZ4nEEZKUVXhOBnbtERRN+lTBPebHyNG+91bGWfvKjkD1IwySKbpX8NqkmsL?= =?us-ascii?Q?pzgaqOMY9juChaebHVPIBBx+NmX9r2Ttu06i20sICf7iJrxfsxQ8JgMCoJIi?= =?us-ascii?Q?vn3tR9O76Yulm/T5v/mNG5BItuX6DsH3z3FqfBHJy7FI5zHrurJSQpf0ziZE?= =?us-ascii?Q?sCuvOLVHxrx/+okjSKussGMZNy89gqVjn/5bfp+rHqkpvFH4HcfF/AQAHgCF?= =?us-ascii?Q?a9t4c7v6pz0C0JUeys7B2wyjKLcRhaLXfnrk/DJw9DF3xrvFnG01GtFojatm?= =?us-ascii?Q?Pnpkf5Hysw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fce41658-b27c-48d2-2bfa-08da3e2a6b1a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:41:53.3866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UK01YIWr8+9M+iQAdBkyUsDw3xJ5Bj5kiv6NS4NSLqUmTnHTKh6VE1xsmOaFagVzGZeGzaBochm3aT2EfSvPVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8425 On 25.05.2022 10:13, Roger Pau Monne wrote: > Booting with Shadow Stacks leads to the following assert on a debug > hypervisor: >=20 > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > ----[ Xen-4.17.0-10.24-d x86_64 debug=3Dy Not tainted ]---- > CPU: 0 > RIP: e008:[] flush_area_mask+0x40/0x13e > [...] > Xen call trace: > [] R flush_area_mask+0x40/0x13e > [] F modify_xen_mappings+0xc5/0x958 > [] F arch/x86/alternative.c#_alternative_instruction= s+0xb7/0xb9 > [] F alternative_branches+0xf/0x12 > [] F __start_xen+0x1ef4/0x2776 > [] F __high_start+0x94/0xa0 >=20 > This is due to SYS_STATE_smp_boot being set before calling > alternative_branches(), and the flush in modify_xen_mappings() then > using flush_area_all() with interrupts disabled. Note that > alternative_branches() is called before APs are started, so the flush > must be a local one (and indeed the cpumask passed to > flush_area_mask() just contains one CPU). >=20 > Take the opportunity to simplify a bit the logic and make flush_area() > an alias of flush_area_all() in mm.c, taking into account that > cpu_online_map just contains the BSP before APs are started. This > requires widening the assert in flush_area_mask() to allow being > called with interrupts disabled as long as it's strictly a local only > flush. >=20 > The overall result is that a conditional can be removed from > flush_area(). >=20 > While there also introduce an ASSERT to check that a vCPU state flush > is not issued for the local CPU only. >=20 > Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to = local only') > Suggested-by: Andrew Cooper > Signed-off-by: Roger Pau Monn=C3=A9 Reviewed-by: Jan Beulich with ... > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5070,13 +5070,8 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) > #define l1f_to_lNf(f) (((f) & _PAGE_PRESENT) ? ((f) | _PAGE_PSE) : (f)) > #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f)) > =20 > -/* > - * map_pages_to_xen() can be called early in boot before any other > - * CPUs are online. Use flush_area_local() in this case. > - */ > -#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ? \ > - flush_area_local((const void *)v, f) : \ > - flush_area_all((const void *)v, f)) > +/* flush_area_all() can be used prior to any other CPU being online. */ > +#define flush_area(v, f) flush_area_all((const void *)v, f) ... v properly parenthesized here as the code is being touched anyway: One less Misra-C violation. This surely can be done while committing. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 08:51:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:51:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337034.561505 (Exim 4.92) (envelope-from ) id 1ntmkC-0005oQ-Rx; Wed, 25 May 2022 08:51:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337034.561505; Wed, 25 May 2022 08:51:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmkC-0005oJ-On; Wed, 25 May 2022 08:51:52 +0000 Received: by outflank-mailman (input) for mailman id 337034; Wed, 25 May 2022 08:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmkA-0005oD-To for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:51:50 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9ed7f4e-dc07-11ec-837f-e5687231ffcc; Wed, 25 May 2022 10:51:49 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1ntmjl-0003D1-IO; Wed, 25 May 2022 10:51:25 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ed7f4e-dc07-11ec-837f-e5687231ffcc Message-ID: <5334d001-af50-eacb-8845-dd83df35be56@leemhuis.info> Date: Wed, 25 May 2022 10:51:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross , Chuck Zmudzinski , regressions@lists.linux.dev, stable@vger.kernel.org References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> <83cbd5ce-7f00-9121-44b3-5d1b94d66f02@suse.com> From: Thorsten Leemhuis In-Reply-To: <83cbd5ce-7f00-9121-44b3-5d1b94d66f02@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1653468709;3e2fd205; X-HE-SMSGID: 1ntmjl-0003D1-IO On 25.05.22 10:37, Jan Beulich wrote: > On 25.05.2022 09:45, Thorsten Leemhuis wrote: >> On 24.05.22 20:32, Chuck Zmudzinski wrote: >>> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >>>> I'm not a developer and I'm don't known the details of this thread and >>>> the backstory of the regression, but it sounds like that's the approach >>>> that is needed here until someone comes up with a fix for the regression >>>> exposed by bdd8b6c98239. >>>> >>>> But if I'm wrong, please tell me. >>> >>> You are mostly right, I think. Reverting bdd8b6c98239 fixes >>> it. There is another way to fix it, though. >> >> Yeah, I'm aware of it. But it seems... >> >>> The patch proposed >>> by Jan Beulich also fixes the regression on my system, so as >>> the person reporting this is a regression, I would also be satisfied >>> with Jan's patch instead of reverting bdd8b6c98239 as a fix. Jan >>> posted his proposed patch here: >>> >>> https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ >> >> ...that approach is not making any progress either? >> >> Jan, can could provide a short status update here? I'd really like to >> get this regression fixed one way or another rather sooner than later, >> as this is taken way to long already IMHO. > > What kind of status update could I provide? I've not heard back from > anyone of the maintainers, so I have no way to know what (if anything) > I need to do. That is perfectly fine as a status update for me (I track a lot of regression and it's easy to miss updated patches, discussion in other places, and things like that). Could you maybe send a reminder to the maintainer that this is a fix for regression that is bothering people and needs to be handled with high priority? Feel free to tell them the Linux kernel regression tracker is pestering you because things are taken so long. :-D Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Wed May 25 08:54:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337043.561516 (Exim 4.92) (envelope-from ) id 1ntmmG-0006Px-8r; Wed, 25 May 2022 08:54:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337043.561516; Wed, 25 May 2022 08:54:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmmG-0006Pq-5L; Wed, 25 May 2022 08:54:00 +0000 Received: by outflank-mailman (input) for mailman id 337043; Wed, 25 May 2022 08:53:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmmF-0006Pk-Ki for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:53:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmmF-0004Tu-Ca; Wed, 25 May 2022 08:53:59 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.21.168]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntmmF-0007B7-6L; Wed, 25 May 2022 08:53:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=WjHLldIN5NReoGm9OZ9ZGcfla+l9akKwDIiD4nEg/7M=; b=tPGw+YBr5ldfVwP2ZOXoGO2dDL eGLGtTOeNd4ooegAXyhMnXuUgnNNz2ZO4ALC1pw+w2XDnr5Wret4sdBhAX04YtTOxClNF1a9HXIrX CuFFWvWhMuKO3tuQWV6PUX8Ksxebc6MBd0VCPJv98cFXy6MpWFOyItO8Piw8wGjV4Cng=; Message-ID: <7959ff38-53e3-761b-7792-0ea2526c51ff@xen.org> Date: Wed, 25 May 2022 09:53:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini References: <20220522165900.83104-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/05/2022 08:54, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 22 May 2022, at 17:59, Julien Grall wrote: >> >> From: Julien Grall >> >> xsm_deasign_dtdevice() will indicate whether the caller is allowed >> to issue the operation. So the return value has to be checked. >> >> Spotted by clang static analyzer. >> >> Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") >> Signed-off-by: Julien Grall > > With the typo spotted by Michal solved (can be done on commit): > Reviewed-by: Bertrand Marquis I fixed the typo and committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 08:55:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 08:55:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337052.561531 (Exim 4.92) (envelope-from ) id 1ntmnv-000736-LV; Wed, 25 May 2022 08:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337052.561531; Wed, 25 May 2022 08:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmnv-00072z-Ih; Wed, 25 May 2022 08:55:43 +0000 Received: by outflank-mailman (input) for mailman id 337052; Wed, 25 May 2022 08:55:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntmnu-00072p-Hy for xen-devel@lists.xenproject.org; Wed, 25 May 2022 08:55:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 743ccb8a-dc08-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 10:55:41 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-0tnFSb3aPIejMTwIfyS0Xw-1; Wed, 25 May 2022 10:55:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7382.eurprd04.prod.outlook.com (2603:10a6:10:1ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 08:55:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 08:55:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 743ccb8a-dc08-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653468940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTR9Yx/HbeSF5EVcNf6OID05W1togWox6q4GWfB34ks=; b=WpSEC9ita79QjAzK/rqDRMbnyyBDz2Jnz1CySWuKlow03Ui5RkZRYwkpfi9/RNBXV9wIGQ NmW3utQcvD5r3Cx3AuhE8lDh56b3UD+aM9cHZg5cWspBYeAkhdkKaBSHJcGhDDWFskzcGE gWM/21d8HjvBQVWBWBw/RJ9qgY+fBHs= X-MC-Unique: 0tnFSb3aPIejMTwIfyS0Xw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KbAUAAaK87wjQJSEh8TQ+PhDvqKgZGWOzZqeIdYNCm/y4IfzlJgY4iDlJAjlaoT1s1SYQKeDCV7pi/V/Bap3LPGVDPPfnZb+gx/Kq5V8nlnKK241TeJRuHG4PFMYvuKOPzFLmJvk0hsOM34bZIolUng2O9VTJPxZbiqY/Tj5upkUouVomFREZxU0XJXYEmuwkzy9wjV7caxNnNcOFS/Xlxr5Eas/CislUPdk9T4/miSndqW/Jhf9mWbwkriZZKHTuJ2kt/Lm993oMWuOM1Mcvybaqx1gkFj7w5Ybm4Gcx++/A+ea3OOco9v5xOs7H+OByMUxX7jcStkZYnHDLmMZqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yTR9Yx/HbeSF5EVcNf6OID05W1togWox6q4GWfB34ks=; b=YHxXvqOxlA3/YSD3IMXG/nEAOX27ZGC5sPn/R6TsRUp9OWVUAeWobcill3xAOhqSOPZYJiFKY56BueaR4eUgaOdIOmmYZ2iEz/wGX7lb3LWlPznQc7L8YcDocLwhfLhkxG9wonnp6Wzcnneu+5D9HXalpECPTsF3PVAHBIvVaXJ2xtfxzIiY++IT5W8Wiss6c6F4wdvCa9k19Uie+wSxPKqi709h6mp+9tsstSmA3tQLlkfYOCO789qd+tZKHd24dl7Iy/84RKU9gZb+inhn9SNTI4WFf0GfNaRIsHdtOvjU+DNNnRNX8O/IA/Tb9BYqdplRGNyGh6vpCIQOGnnRkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 10:55:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US From: Jan Beulich To: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" , Thorsten Leemhuis References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> In-Reply-To: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0050.eurprd04.prod.outlook.com (2603:10a6:20b:46a::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 980393e4-9679-43a8-3e59-08da3e2c5640 X-MS-TrafficTypeDiagnostic: DBAPR04MB7382:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fN6VQqSkdIO9q8AdEhJJoj7HsjnUN48LHgH/JnSEiF57ZDa8p12ZYXrPFL8Yfb1LmYx/XQLo46H8I+hzEKjeO9Ns6Fu9Lyi1LxB5DTnr1HkNvoLHHS6RXx3ENi52WfSHmmD8HYkVJqgL6sq8lQjx9G7U1xcWX9q6+6jkoAkG3LJv5hy+odp/7NrOrvaL+321np5VZwSYIaV2tZmR4s+vwLwSIUJaowU5IHO6vuzWzp40BTBArKL4193gPCWE9kBduKj2ZsUiqL7gLbWzFYL4A1+lew7btMufN/3OijPcGItXJ26MQTXeFIie/pJWvgghCas7hVDDlrG3xiYUZp2a34DyiXaL4242ixfBBCEK8jeJS+UhPJW2Ikxqfzvg9hFoelYdN/Usfy4qNP8OSmrDI0rQcRDGTyl4UwiUK7cobEMbyxRQupSlashf1E1KO0MiGk4JOJoaZZzJZhzfRvqY8fkmpUpl4hlKvaZHz/fhsxDMSUISrFk7UJl0+xrojfoc4uu6dJpuFTFCjPEdjexl17GVgCXRg3aiNwGMKrZt1zW8L7U+6s02QlGoPqlJY5iPwY5FQAVvRMfMhziRTGOdC7AYlzUL2aD/hpzf8W95FLy2wywL3CaWbOXpL2GB45giHI4fXdNoLP519tAx15pHiAh9s035uCxUr98VIl/l++QedZJRK6DsWQLFQr6ySbLqVoctDB+kjUPId4cqIEbI6emOwhuAypZMsH62DDSpaAHE+KHbDZrJ1aXBVhZu593I X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66476007)(186003)(66556008)(38100700002)(4326008)(66946007)(36756003)(8936002)(5660300002)(110136005)(6666004)(6506007)(54906003)(316002)(26005)(6486002)(6512007)(53546011)(31696002)(86362001)(508600001)(83380400001)(8676002)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUZIcDAwWUJUdytMK0FVbjA3a2w1NFJsSmF0eFNkNk9hcjVGVzJHUEU4Q2VC?= =?utf-8?B?ZStmcSs4eG00K2xuZGFlNktIWXZkT09hRlpxUG9GSmxuL001eVlhUVo3MUla?= =?utf-8?B?ZjVHNk5OOXVqenVQOFZZVlExeHJlcCt4WEpoUytjSXhlYk02OHNTL2JHdysz?= =?utf-8?B?SDI1ZkxUdmFpWm05UkpSTUJWeDI1SFpHSzRLOU1oelR6eE4vZ0YyWDV1a2FR?= =?utf-8?B?TldSQ09xMmtNTGVEL2xqMGdVVmtrdlBUWUMxRDM3UFJZdXJhT3NqdmRSY2NI?= =?utf-8?B?U29BMmxQcTBBTm9CRUtWSnJmblMzZ1pyNXdtQlpUVVl2Y2FJa0I0YVh6QUxK?= =?utf-8?B?dytPNk03SEF0VjZSekpNUitiZVpEVlRDNDg3d1ZYSDhZcGR2NnBJWWFGdlhz?= =?utf-8?B?RGFhRmJ5c0lrZmZ4SGxjVXNMcmt3SVVqckV2VWdobWptdzF6ZVpiU3E4UkxL?= =?utf-8?B?NHZReEY2K2JUMmgvc0FrNnFzWlhweSthZzFZV05tdUpzSENYNXhDN3c2bDQ0?= =?utf-8?B?dldRcGtYdFo0cmgycjNtUUdXSW5vNHAvcWNQaE4vRW9BRXIwLytQVGMrSXBx?= =?utf-8?B?OXd1NWxCS0ltZ09CaFFPUUR2Sy9mcU81cVp3Ny8yQ09pZTNNbVBWUkVtV0xo?= =?utf-8?B?aDIyTUV6dWZkWmQyc1E2Z0xjb0VmVi9qUHlWTFhpMWVOUldNQjhmSHk5RXpF?= =?utf-8?B?RitUc2xyaXp3NS8rS2EyU2dFbkVFekpMY3hGV3FFZFFYRTRaclp4NjBHcWZN?= =?utf-8?B?VXVhc0pmb0J3dm1uK082bWNtR1BXMnZ1M1VEZGliL1ZIZ2pyeXVSUDF3biti?= =?utf-8?B?L2JmSGZWK0dYVUlOSmRWU3BQdUdHclhpZ2lSYkJBTGY5UWFHVHExdmdlUWRv?= =?utf-8?B?Y2xtcHdDOGxEODlNWW5kWi8zTENNdEc3dFFDUVFsOVhpZDFBLzlqY1RzeEpj?= =?utf-8?B?cjRhOUUwK09JVXlqaTNGc0FnRUY4U1lHZW9BV0ZRRmlMSnI2ejRROStOdjJO?= =?utf-8?B?WUl2LzRsWFVGaXZkbmNUUm8vYmxOdERDditsT3pQdFlvQWh1NGhxd3g1Nk1y?= =?utf-8?B?eEp4MjlHOWhja3JRVytTUmZFeGI1OXExdTVUSnJiR2NTOHR2d3ZhejMwQ0xB?= =?utf-8?B?M3NZdjNwdHJKcUpwVjBaWEg3enZlSU5saTM0UEFtYVJzZnVQaVk4aXFGQTZp?= =?utf-8?B?UDg1Z01kZTJlYjJQRzUyQm5pOWJhU2I0RFFtN2ZlYk9SRWZaM2FUd2ZQNjIx?= =?utf-8?B?bnB2OFVzZDJQcnNKaTZKWHBSUVhQbU9mWWgwam1qVDJ6WlJOdUloL1RrOHJK?= =?utf-8?B?YTJ3bmJubzZrdzBBV0U5NEphQU10aUUyczNWUmVlNzNNS1VZQVkyT0VXZFJm?= =?utf-8?B?QmMyOUp5ZHlhd3M3T25zOExFdVF3cU9iTTFJcjdXbXBVMytyeGFObEk3dE1X?= =?utf-8?B?V1krUGcwdWdtSVlQb3FVZkQzMnkrZnNtQUMzMm9EQUJpYkF0WVlrNUVPUzA1?= =?utf-8?B?QW0zUGFhUHJVcUQ5VGpoM0Q2NmRZdEM2STZENVRtUTNUZmV1a3BUOHJYbk1u?= =?utf-8?B?VVN0YmFSWC9UTzBBNGQ5b2VXcHZlaGVrV2VuV2xBUUloaHB1UzcwcVhxTXI0?= =?utf-8?B?REU3cFZtZGVHeE9nUFdGdURiaFQ5M3BVWkF6R0dDeHFScVBoZjNwcU1iT2k4?= =?utf-8?B?c2lZRHpyenNhMXowS2ZyeGVzaE82dG0rcnkxUFVnQzNnWXA0aW5vc3BuQWxZ?= =?utf-8?B?aS9vZUtsVzk2Q2FUR2FLaFhObW9YczhHOGdaMys0dzlaeDdPeGQzYTBReEtX?= =?utf-8?B?UlZvREMwZVE3d1QvR2ZNaGZUdDkxM2hQZnMrWk5Kd0dYUTZqVjNPaFNtOUFK?= =?utf-8?B?clNYK1hQYnNrQ3BBWVgzeERyMlJvS3pEVnZvNU8rdjFnODVOMmpVYWwxWTVN?= =?utf-8?B?d1lqSk5SN3JtWVlzY2xoUG9QK3RPNGlEUkcvb0p1RUI0TnBhY3ZFUzY0KzRM?= =?utf-8?B?THJ6SjQ4OXNHOVJ1T21KQm03ZEFqeDJaQ3JXUjVnUFdQMHFPTDdsZlQwSzcw?= =?utf-8?B?UUc0Zms2bDU3a2VpaTJsREw2d2NjeGhnbW92Zmd5bVFnM0xXZ0Yrdy83Vklz?= =?utf-8?B?YjRRVlZVdjdmcUZpME95WEgzZi81NVpFNW95T3dFd0tOZ0t1ZDViMWphYllj?= =?utf-8?B?clFpcjJTckc3T1BHMXJSelNpd1luTTdNUHg0a2kwR3VtbzFrcjhlRHhuMmdi?= =?utf-8?B?TVBtc2ZlbVAybmNkNmp5UGRlelR2U0Fad3J3UFhpWFk0ditDSGEwN2t3K1Q5?= =?utf-8?B?dXJVTEZyYk1sYURJMEJZcG9zbnJEV2ZEVm9aeXlmR0VjYnp6azQrZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980393e4-9679-43a8-3e59-08da3e2c5640 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 08:55:37.4286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fj//y2YqhxQJpBwrApsy2m2MFexxJrHrY8cAKkLlMCgtUi/gJfs59yV1pSIbwMQIaMnYgjtjVF7OFZcV1nkf9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7382 On 28.04.2022 16:50, Jan Beulich wrote: > The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > with pat_enabled()") pat_enabled() returning false (because of PAT > initialization being suppressed in the absence of MTRRs being announced > to be available) has become a problem: The i915 driver now fails to > initialize when running PV on Xen (i915_gem_object_pin_map() is where I > located the induced failure), and its error handling is flaky enough to > (at least sometimes) result in a hung system. > > Yet even beyond that problem the keying of the use of WC mappings to > pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > graphics frame buffer accesses would have been quite a bit less > performant than possible. > > Arrange for the function to return true in such environments, without > undermining the rest of PAT MSR management logic considering PAT to be > disabled: Specifically, no writes to the PAT MSR should occur. > > For the new boolean to live in .init.data, init_cache_modes() also needs > moving to .init.text (where it could/should have lived already before). > > Signed-off-by: Jan Beulich The Linux kernel regression tracker is pestering me because things are taking so long (effectively quoting him), and alternative proposals made so far look to have more severe downsides. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 09:13:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 09:13:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337065.561558 (Exim 4.92) (envelope-from ) id 1ntn4r-0001DI-GG; Wed, 25 May 2022 09:13:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337065.561558; Wed, 25 May 2022 09:13:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn4r-0001DB-CH; Wed, 25 May 2022 09:13:13 +0000 Received: by outflank-mailman (input) for mailman id 337065; Wed, 25 May 2022 09:13:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn4q-0001D1-BG; Wed, 25 May 2022 09:13:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn4q-0004sv-8o; Wed, 25 May 2022 09:13:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn4p-0006lq-My; Wed, 25 May 2022 09:13:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntn4p-0007Ly-Ks; Wed, 25 May 2022 09:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RLVmedNeE26YQX81O9xhYolFiRxtmkjhJWolAQGTZ1E=; b=RmJkVt5jisdb1eOhB+NWf2UuuB npNBuE5lkP+GvpCJ5Ox1JaMLgj5hg53e6PRW4sJFsUxFZOC49iZhTkAwV4bUtKotmatfAoRmWq/ZS RXqdDLu8uPHO3OgO1CqaXSlm2kWrz4ri3ucHKmv4H0yeK4l3WpQSKVTdVwBtxPaZiRLM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170720: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:host-ping-check-xen:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Wed, 25 May 2022 09:13:11 +0000 flight 170720 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170720/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 170712 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail pass in 170712 test-armhf-armhf-libvirt-raw 10 host-ping-check-xen fail pass in 170712 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 170712 like 170687 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 170712 never pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 170657 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170712 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170712 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170712 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170712 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170712 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170712 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170712 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170712 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170712 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170712 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170712 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170720 2022-05-25 01:53:12 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed May 25 09:17:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 09:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337075.561569 (Exim 4.92) (envelope-from ) id 1ntn9E-0001qb-2O; Wed, 25 May 2022 09:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337075.561569; Wed, 25 May 2022 09:17:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn9D-0001qU-Uq; Wed, 25 May 2022 09:17:43 +0000 Received: by outflank-mailman (input) for mailman id 337075; Wed, 25 May 2022 09:17:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntn9C-0001qO-6Q for xen-devel@lists.xenproject.org; Wed, 25 May 2022 09:17:42 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 869d4e42-dc0b-11ec-837f-e5687231ffcc; Wed, 25 May 2022 11:17:40 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1581F219C5; Wed, 25 May 2022 09:17:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B46F013487; Wed, 25 May 2022 09:17:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yGUQKjP0jWKyTQAAMHmgww (envelope-from ); Wed, 25 May 2022 09:17:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 869d4e42-dc0b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653470260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SYs6622U9AXr3OUSE/634zqYOcUn33HnjDgHhQkQ6v4=; b=qkbxDJH2xCbUHXkTx/XvmY2XJ3MxXzJxWjFRI6NWqZJJfjzYPAPQfielzsaqGtKGpegLd7 maY/RhRsVmrAh6MHRsRgwSCqoeK9UnHfD8CuDrSuk5TNUQMBvowrfsg7ztiabtVh6sT1m/ MR1j2/pkZ7WNfpgH6D1Cw1X2q7QC0o8= Message-ID: <36489ed0-d2ec-92bc-6a15-b423118f8af2@suse.com> Date: Wed, 25 May 2022 11:17:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Demi Marie Obenour , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: From: Juergen Gross Subject: Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YIISMi4lxaTHiovuYVDaIN07" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YIISMi4lxaTHiovuYVDaIN07 Content-Type: multipart/mixed; boundary="------------aX5RY1OxQNbipAK57nTzcAk0"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <36489ed0-d2ec-92bc-6a15-b423118f8af2@suse.com> Subject: Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() References: In-Reply-To: --------------aX5RY1OxQNbipAK57nTzcAk0 Content-Type: multipart/mixed; boundary="------------D8xMTnyA4O1BHY5gfVG0PJz6" --------------D8xMTnyA4O1BHY5gfVG0PJz6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDUuMjIgMTg6NDUsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gdW5tYXBf Z3JhbnRfcGFnZXMoKSBjdXJyZW50bHkgd2FpdHMgZm9yIHRoZSBwYWdlcyB0byBubyBsb25n ZXIgYmUgdXNlZC4NCj4gSW4gaHR0cHM6Ly9naXRodWIuY29tL1F1YmVzT1MvcXViZXMtaXNz dWVzL2lzc3Vlcy83NDgxLCB0aGlzIGxlYWQgdG8gYQ0KPiBkZWFkbG9jayBhZ2FpbnN0IGk5 MTU6IGk5MTUgd2FzIHdhaXRpbmcgZm9yIGdudGRldidzIE1NVSBub3RpZmllciB0bw0KPiBm aW5pc2gsIHdoaWxlIGdudGRldiB3YXMgd2FpdGluZyBmb3IgaTkxNSB0byBmcmVlIGl0cyBw YWdlcy4gIEkgYWxzbw0KPiBiZWxpZXZlIHRoaXMgaXMgcmVzcG9uc2libGUgZm9yIHZhcmlv dXMgZGVhZGxvY2tzIEkgaGF2ZSBleHBlcmllbmNlZCBpbg0KPiB0aGUgcGFzdC4NCj4gDQo+ IEF2b2lkIHRoZXNlIHByb2JsZW1zIGJ5IG1ha2luZyB1bm1hcF9ncmFudF9wYWdlcyBhc3lu Yy4gIFRoaXMgcmVxdWlyZXMNCj4gbWFraW5nIGl0IHJldHVybiB2b2lkLCBhcyBhbnkgZXJy b3JzIHdpbGwgbm90IGJlIGF2YWlsYWJsZSB3aGVuIHRoZQ0KPiBmdW5jdGlvbiByZXR1cm5z LiAgRm9ydHVuYXRlbHksIHRoZSBvbmx5IHVzZSBvZiB0aGUgcmV0dXJuIHZhbHVlIGlzIGEN Cj4gV0FSTl9PTigpLiAgUmVwbGFjZSB0aGlzIHdpdGggV0FSTl9PTigpcyB3aGVyZSBlcnJv cnMgYXJlIGRldGVjdGVkLg0KDQpOb3QgYWxsIGNhbGxlcnMgb2YgdW5tYXBfZ3JhbnRfcGFn ZXMoKSBhcmUgaXNzdWluZyBhIFdBUk5fT04oKS4gQXJlIHlvdQ0Kc3VyZSB0aGF0IHRoaXMg Y2hhbmdlIGNhbid0IHJlc3VsdCBpbiBhIGZsb29kIG9mIFdBUk4oKXM/DQoNClBsZWFzZSBu b3RlIHRoYXQgeW91IGFyZSBtb2RpZnlpbmcgdGhlIHNlbWFudGljcyBpbiBjYXNlIG9mIGFu IHVubWFwDQpvcGVyYXRpb24gcmV0dXJuaW5nIGFuIGVycm9yLiBQcmV2aW91c2x5IHRoZXJl IHdlcmUgbm8gZnVydGhlciB1bm1hcHMNCmRvbmUgaW4gdGhpcyBjYXNlLCB3aGlsZSBub3cg eW91IGFyZSBiYXNpY2FsbHkgY29udGludWUgdW5tYXBwaW5nIGV2ZW4NCmFmdGVyIGhpdHRp bmcgYW4gZXJyb3IuIFRoaXMgc2VlbXMgdG8gYmUgZmluZSwgYnV0IGlzIHdvcnRoIG1lbnRp b25pbmcNCmluIHRoZSBjb21taXQgbWVzc2FnZS4NCg0KPiANCj4gRml4ZXM6IDc0NTI4MjI1 NmM3NSAoInhlbi9nbnRkZXY6IHNhZmVseSB1bm1hcCBncmFudHMgaW4gY2FzZSB0aGV5IGFy ZSBzdGlsbCBpbiB1c2UiKQ0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KPiBTaWdu ZWQtb2ZmLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlAaW52aXNpYmxldGhpbmdzbGFi LmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy94ZW4vZ250ZGV2LWNvbW1vbi5oIHwgIDQgKysN Cj4gICBkcml2ZXJzL3hlbi9nbnRkZXYuYyAgICAgICAgfCA4MiArKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tDQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRp b25zKCspLCA0MSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hl bi9nbnRkZXYtY29tbW9uLmggYi9kcml2ZXJzL3hlbi9nbnRkZXYtY29tbW9uLmgNCj4gaW5k ZXggMjBkN2QwNTlkYWRiLi5hNmUyODA1ZWEyY2UgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv eGVuL2dudGRldi1jb21tb24uaA0KPiArKysgYi9kcml2ZXJzL3hlbi9nbnRkZXYtY29tbW9u LmgNCj4gQEAgLTE2LDYgKzE2LDcgQEANCj4gICAjaW5jbHVkZSA8bGludXgvbW11X25vdGlm aWVyLmg+DQo+ICAgI2luY2x1ZGUgPGxpbnV4L3R5cGVzLmg+DQo+ICAgI2luY2x1ZGUgPHhl bi9pbnRlcmZhY2UvZXZlbnRfY2hhbm5lbC5oPg0KPiArI2luY2x1ZGUgPHhlbi9ncmFudF90 YWJsZS5oPg0KPiAgIA0KPiAgIHN0cnVjdCBnbnRkZXZfZG1hYnVmX3ByaXY7DQo+ICAgDQo+ IEBAIC03Myw2ICs3NCw5IEBAIHN0cnVjdCBnbnRkZXZfZ3JhbnRfbWFwIHsNCj4gICAJLyog TmVlZGVkIHRvIGF2b2lkIGFsbG9jYXRpb24gaW4gZ250dGFiX2RtYV9mcmVlX3BhZ2VzKCku ICovDQo+ICAgCXhlbl9wZm5fdCAqZnJhbWVzOw0KPiAgICNlbmRpZg0KPiArDQo+ICsJLyog TmVlZGVkIHRvIGF2b2lkIGFsbG9jYXRpb24gaW4gX191bm1hcF9ncmFudF9wYWdlcyAqLw0K PiArCXN0cnVjdCBnbnRhYl91bm1hcF9xdWV1ZV9kYXRhIHVubWFwX2RhdGE7DQo+ICAgfTsN Cj4gICANCj4gICBzdHJ1Y3QgZ250ZGV2X2dyYW50X21hcCAqZ250ZGV2X2FsbG9jX21hcChz dHJ1Y3QgZ250ZGV2X3ByaXYgKnByaXYsIGludCBjb3VudCwNCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMveGVuL2dudGRldi5jIGIvZHJpdmVycy94ZW4vZ250ZGV2LmMNCj4gaW5kZXggNTlm ZmVhODAwMDc5Li42NzBkODAwZTRhODkgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL2du dGRldi5jDQo+ICsrKyBiL2RyaXZlcnMveGVuL2dudGRldi5jDQo+IEBAIC02Miw4ICs2Miw4 IEBAIE1PRFVMRV9QQVJNX0RFU0MobGltaXQsDQo+ICAgDQo+ICAgc3RhdGljIGludCB1c2Vf cHRlbW9kOw0KPiAgIA0KPiAtc3RhdGljIGludCB1bm1hcF9ncmFudF9wYWdlcyhzdHJ1Y3Qg Z250ZGV2X2dyYW50X21hcCAqbWFwLA0KPiAtCQkJICAgICBpbnQgb2Zmc2V0LCBpbnQgcGFn ZXMpOw0KPiArc3RhdGljIHZvaWQgdW5tYXBfZ3JhbnRfcGFnZXMoc3RydWN0IGdudGRldl9n cmFudF9tYXAgKm1hcCwNCj4gKwkJCSAgICAgIGludCBvZmZzZXQsIGludCBwYWdlcyk7DQo+ ICAgDQo+ICAgc3RhdGljIHN0cnVjdCBtaXNjZGV2aWNlIGdudGRldl9taXNjZGV2Ow0KPiAg IA0KPiBAQCAtMzQ5LDYxICszNDksNjUgQEAgaW50IGdudGRldl9tYXBfZ3JhbnRfcGFnZXMo c3RydWN0IGdudGRldl9ncmFudF9tYXAgKm1hcCkNCj4gICAJcmV0dXJuIGVycjsNCj4gICB9 DQo+ICAgDQo+IC1zdGF0aWMgaW50IF9fdW5tYXBfZ3JhbnRfcGFnZXMoc3RydWN0IGdudGRl dl9ncmFudF9tYXAgKm1hcCwgaW50IG9mZnNldCwNCj4gLQkJCSAgICAgICBpbnQgcGFnZXMp DQo+ICtzdGF0aWMgdm9pZCBfX3VubWFwX2dyYW50X3BhZ2VzX2RvbmUoaW50IHJlc3VsdCwN Cj4gKwkJc3RydWN0IGdudGFiX3VubWFwX3F1ZXVlX2RhdGEgKmRhdGEpDQo+ICAgew0KPiAt CWludCBpLCBlcnIgPSAwOw0KPiAtCXN0cnVjdCBnbnRhYl91bm1hcF9xdWV1ZV9kYXRhIHVu bWFwX2RhdGE7DQo+IC0NCj4gLQlpZiAobWFwLT5ub3RpZnkuZmxhZ3MgJiBVTk1BUF9OT1RJ RllfQ0xFQVJfQllURSkgew0KPiAtCQlpbnQgcGdubyA9IChtYXAtPm5vdGlmeS5hZGRyID4+ IFBBR0VfU0hJRlQpOw0KPiAtCQlpZiAocGdubyA+PSBvZmZzZXQgJiYgcGdubyA8IG9mZnNl dCArIHBhZ2VzKSB7DQo+IC0JCQkvKiBObyBuZWVkIGZvciBrbWFwLCBwYWdlcyBhcmUgaW4g bG93bWVtICovDQo+IC0JCQl1aW50OF90ICp0bXAgPSBwZm5fdG9fa2FkZHIocGFnZV90b19w Zm4obWFwLT5wYWdlc1twZ25vXSkpOw0KPiAtCQkJdG1wW21hcC0+bm90aWZ5LmFkZHIgJiAo UEFHRV9TSVpFLTEpXSA9IDA7DQo+IC0JCQltYXAtPm5vdGlmeS5mbGFncyAmPSB+VU5NQVBf Tk9USUZZX0NMRUFSX0JZVEU7DQo+IC0JCX0NCj4gLQl9DQo+IC0NCj4gLQl1bm1hcF9kYXRh LnVubWFwX29wcyA9IG1hcC0+dW5tYXBfb3BzICsgb2Zmc2V0Ow0KPiAtCXVubWFwX2RhdGEu a3VubWFwX29wcyA9IHVzZV9wdGVtb2QgPyBtYXAtPmt1bm1hcF9vcHMgKyBvZmZzZXQgOiBO VUxMOw0KPiAtCXVubWFwX2RhdGEucGFnZXMgPSBtYXAtPnBhZ2VzICsgb2Zmc2V0Ow0KPiAt CXVubWFwX2RhdGEuY291bnQgPSBwYWdlczsNCj4gLQ0KPiAtCWVyciA9IGdudHRhYl91bm1h cF9yZWZzX3N5bmMoJnVubWFwX2RhdGEpOw0KPiAtCWlmIChlcnIpDQo+IC0JCXJldHVybiBl cnI7DQo+ICsJaW50IGk7DQoNCk1pbmQgdXNpbmcgdW5zaWduZWQgaW50IGluc3RlYWQ/DQoN Cj4gKwlzdHJ1Y3QgZ250ZGV2X2dyYW50X21hcCAqbWFwID0gZGF0YS0+ZGF0YTsNCj4gKwlp bnQgb2Zmc2V0ID0gZGF0YS0+dW5tYXBfb3BzIC0gbWFwLT51bm1hcF9vcHM7DQo+ICAgDQo+ IC0JZm9yIChpID0gMDsgaSA8IHBhZ2VzOyBpKyspIHsNCj4gLQkJaWYgKG1hcC0+dW5tYXBf b3BzW29mZnNldCtpXS5zdGF0dXMpDQo+IC0JCQllcnIgPSAtRUlOVkFMOw0KPiArCWZvciAo aSA9IDA7IGkgPCBkYXRhLT5jb3VudDsgaSsrKSB7DQo+ICsJCVdBUk5fT04obWFwLT51bm1h cF9vcHNbb2Zmc2V0K2ldLnN0YXR1cyk7ID4gICAJCXByX2RlYnVnKCJ1bm1hcCBoYW5kbGU9 JWQgc3Q9JWRcbiIsDQo+ICAgCQkJbWFwLT51bm1hcF9vcHNbb2Zmc2V0K2ldLmhhbmRsZSwN Cj4gICAJCQltYXAtPnVubWFwX29wc1tvZmZzZXQraV0uc3RhdHVzKTsNCj4gICAJCW1hcC0+ dW5tYXBfb3BzW29mZnNldCtpXS5oYW5kbGUgPSBJTlZBTElEX0dSQU5UX0hBTkRMRTsNCj4g ICAJCWlmICh1c2VfcHRlbW9kKSB7DQo+IC0JCQlpZiAobWFwLT5rdW5tYXBfb3BzW29mZnNl dCtpXS5zdGF0dXMpDQo+IC0JCQkJZXJyID0gLUVJTlZBTDsNCj4gKwkJCVdBUk5fT04obWFw LT5rdW5tYXBfb3BzW29mZnNldCtpXS5zdGF0dXMpOw0KPiAgIAkJCXByX2RlYnVnKCJrdW5t YXAgaGFuZGxlPSV1IHN0PSVkXG4iLA0KPiAgIAkJCQkgbWFwLT5rdW5tYXBfb3BzW29mZnNl dCtpXS5oYW5kbGUsDQo+ICAgCQkJCSBtYXAtPmt1bm1hcF9vcHNbb2Zmc2V0K2ldLnN0YXR1 cyk7DQo+ICAgCQkJbWFwLT5rdW5tYXBfb3BzW29mZnNldCtpXS5oYW5kbGUgPSBJTlZBTElE X0dSQU5UX0hBTkRMRTsNCj4gICAJCX0NCj4gICAJfQ0KPiAtCXJldHVybiBlcnI7DQo+ICAg fQ0KPiAgIA0KPiAtc3RhdGljIGludCB1bm1hcF9ncmFudF9wYWdlcyhzdHJ1Y3QgZ250ZGV2 X2dyYW50X21hcCAqbWFwLCBpbnQgb2Zmc2V0LA0KPiAtCQkJICAgICBpbnQgcGFnZXMpDQo+ ICtzdGF0aWMgdm9pZCBfX3VubWFwX2dyYW50X3BhZ2VzKHN0cnVjdCBnbnRkZXZfZ3JhbnRf bWFwICptYXAsIGludCBvZmZzZXQsDQo+ICsJCQkgICAgICAgaW50IHBhZ2VzKQ0KPiArew0K PiArCWlmIChtYXAtPm5vdGlmeS5mbGFncyAmIFVOTUFQX05PVElGWV9DTEVBUl9CWVRFKSB7 DQo+ICsJCWludCBwZ25vID0gKG1hcC0+bm90aWZ5LmFkZHIgPj4gUEFHRV9TSElGVCk7DQo+ ICsNCj4gKwkJaWYgKHBnbm8gPj0gb2Zmc2V0ICYmIHBnbm8gPCBvZmZzZXQgKyBwYWdlcykg ew0KPiArCQkJLyogTm8gbmVlZCBmb3Iga21hcCwgcGFnZXMgYXJlIGluIGxvd21lbSAqLw0K PiArCQkJdWludDhfdCAqdG1wID0gcGZuX3RvX2thZGRyKHBhZ2VfdG9fcGZuKG1hcC0+cGFn ZXNbcGdub10pKTsNCj4gKw0KPiArCQkJdG1wW21hcC0+bm90aWZ5LmFkZHIgJiAoUEFHRV9T SVpFLTEpXSA9IDA7DQo+ICsJCQltYXAtPm5vdGlmeS5mbGFncyAmPSB+VU5NQVBfTk9USUZZ X0NMRUFSX0JZVEU7DQo+ICsJCX0NCj4gKwl9DQo+ICsNCj4gKwltYXAtPnVubWFwX2RhdGEu dW5tYXBfb3BzID0gbWFwLT51bm1hcF9vcHMgKyBvZmZzZXQ7DQo+ICsJbWFwLT51bm1hcF9k YXRhLmt1bm1hcF9vcHMgPSB1c2VfcHRlbW9kID8gbWFwLT5rdW5tYXBfb3BzICsgb2Zmc2V0 IDogTlVMTDsNCj4gKwltYXAtPnVubWFwX2RhdGEucGFnZXMgPSBtYXAtPnBhZ2VzICsgb2Zm c2V0Ow0KPiArCW1hcC0+dW5tYXBfZGF0YS5jb3VudCA9IHBhZ2VzOw0KPiArCW1hcC0+dW5t YXBfZGF0YS5kb25lID0gX191bm1hcF9ncmFudF9wYWdlc19kb25lOw0KPiArCW1hcC0+dW5t YXBfZGF0YS5kYXRhID0gbWFwOw0KDQpJIHRoaW5rIHlvdSBuZWVkIHRvIGNhbGwgcmVmY291 bnRfaW5jKCZtYXAtPnVzZXJzKSBoZXJlIGFuZCBkbyB0aGUgcmVsYXRlZA0KZ250ZGV2X3B1 dF9tYXAoKSBjYWxsIGluIF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9uZSgpLiBPdGhlcndpc2Ug eW91IGFyZSByaXNraW5nDQp0byBoYXZlIG1hcCBmcmVlZCBiZWZvcmUgdGhlIGFzeW5jIG9w ZXJhdGlvbiBoYXMgZmluaXNoZWQuDQoNCj4gKw0KPiArCWdudHRhYl91bm1hcF9yZWZzX2Fz eW5jKCZtYXAtPnVubWFwX2RhdGEpOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgdm9pZCB1bm1h cF9ncmFudF9wYWdlcyhzdHJ1Y3QgZ250ZGV2X2dyYW50X21hcCAqbWFwLCBpbnQgb2Zmc2V0 LA0KPiArCQkJICAgICAgaW50IHBhZ2VzKQ0KPiAgIHsNCj4gLQlpbnQgcmFuZ2UsIGVyciA9 IDA7DQo+ICsJaW50IHJhbmdlOw0KPiAgIA0KPiAgIAlwcl9kZWJ1ZygidW5tYXAgJWQrJWQg WyVkKyVkXVxuIiwgbWFwLT5pbmRleCwgbWFwLT5jb3VudCwgb2Zmc2V0LCBwYWdlcyk7DQo+ ICAgDQo+ICAgCS8qIEl0IGlzIHBvc3NpYmxlIHRoZSByZXF1ZXN0ZWQgcmFuZ2Ugd2lsbCBo YXZlIGEgImhvbGUiIHdoZXJlIHdlDQo+ICAgCSAqIGFscmVhZHkgdW5tYXBwZWQgc29tZSBv ZiB0aGUgZ3JhbnRzLiBPbmx5IHVubWFwIHZhbGlkIHJhbmdlcy4NCj4gICAJICovDQo+IC0J d2hpbGUgKHBhZ2VzICYmICFlcnIpIHsNCj4gKwl3aGlsZSAocGFnZXMpIHsNCj4gICAJCXdo aWxlIChwYWdlcyAmJg0KPiAgIAkJICAgICAgIG1hcC0+dW5tYXBfb3BzW29mZnNldF0uaGFu ZGxlID09IElOVkFMSURfR1JBTlRfSEFORExFKSB7DQo+ICAgCQkJb2Zmc2V0Kys7DQo+IEBA IC00MTYsMTIgKzQyMCwxMCBAQCBzdGF0aWMgaW50IHVubWFwX2dyYW50X3BhZ2VzKHN0cnVj dCBnbnRkZXZfZ3JhbnRfbWFwICptYXAsIGludCBvZmZzZXQsDQo+ICAgCQkJCWJyZWFrOw0K PiAgIAkJCXJhbmdlKys7DQo+ICAgCQl9DQo+IC0JCWVyciA9IF9fdW5tYXBfZ3JhbnRfcGFn ZXMobWFwLCBvZmZzZXQsIHJhbmdlKTsNCj4gKwkJX191bm1hcF9ncmFudF9wYWdlcyhtYXAs IG9mZnNldCwgcmFuZ2UpOw0KPiAgIAkJb2Zmc2V0ICs9IHJhbmdlOw0KPiAgIAkJcGFnZXMg LT0gcmFuZ2U7DQo+ICAgCX0NCj4gLQ0KPiAtCXJldHVybiBlcnI7DQo+ICAgfQ0KPiAgIA0K PiAgIC8qIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLSAqLw0KPiBAQCAtNDczLDcgKzQ3NSw2IEBAIHN0YXRpYyBi b29sIGdudGRldl9pbnZhbGlkYXRlKHN0cnVjdCBtbXVfaW50ZXJ2YWxfbm90aWZpZXIgKm1u LA0KPiAgIAlzdHJ1Y3QgZ250ZGV2X2dyYW50X21hcCAqbWFwID0NCj4gICAJCWNvbnRhaW5l cl9vZihtbiwgc3RydWN0IGdudGRldl9ncmFudF9tYXAsIG5vdGlmaWVyKTsNCj4gICAJdW5z aWduZWQgbG9uZyBtc3RhcnQsIG1lbmQ7DQo+IC0JaW50IGVycjsNCj4gICANCj4gICAJaWYg KCFtbXVfbm90aWZpZXJfcmFuZ2VfYmxvY2thYmxlKHJhbmdlKSkNCj4gICAJCXJldHVybiBm YWxzZTsNCj4gQEAgLTQ5NCwxMCArNDk1LDkgQEAgc3RhdGljIGJvb2wgZ250ZGV2X2ludmFs aWRhdGUoc3RydWN0IG1tdV9pbnRlcnZhbF9ub3RpZmllciAqbW4sDQo+ICAgCQkJbWFwLT5p bmRleCwgbWFwLT5jb3VudCwNCj4gICAJCQltYXAtPnZtYS0+dm1fc3RhcnQsIG1hcC0+dm1h LT52bV9lbmQsDQo+ICAgCQkJcmFuZ2UtPnN0YXJ0LCByYW5nZS0+ZW5kLCBtc3RhcnQsIG1l bmQpOw0KPiAtCWVyciA9IHVubWFwX2dyYW50X3BhZ2VzKG1hcCwNCj4gKwl1bm1hcF9ncmFu dF9wYWdlcyhtYXAsDQo+ICAgCQkJCShtc3RhcnQgLSBtYXAtPnZtYS0+dm1fc3RhcnQpID4+ IFBBR0VfU0hJRlQsDQo+ICAgCQkJCShtZW5kIC0gbXN0YXJ0KSA+PiBQQUdFX1NISUZUKTsN Cj4gLQlXQVJOX09OKGVycik7DQo+ICAgDQo+ICAgCXJldHVybiB0cnVlOw0KPiAgIH0NCg0K SnVlcmdlbg0K --------------D8xMTnyA4O1BHY5gfVG0PJz6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D8xMTnyA4O1BHY5gfVG0PJz6-- --------------aX5RY1OxQNbipAK57nTzcAk0-- --------------YIISMi4lxaTHiovuYVDaIN07 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKN9DMFAwAAAAAACgkQsN6d1ii/Ey/r ngf/c22JbFjlWlARUSz+fRpnuXNAJtorYX6HeUI9TWiI4AfxO+856y56HS7Ci+L8DaReAF/EkpG6 ec/VnvKKNOfT+5XK1WMDdlRG0SWZzX6PagKDh4ZUDTafcQIoDzN6NYq1Z6dMAh/QQ7/DHe2crqxf wYITawaifnFc/HSkISMB7FLXsE+OusOA0x2eFYTU9evsRDMQROMzldC6Aul5b7hdvSl/zM2FTptv ids4fOn+Caq7sSzcNK3CvZjyBP+L6S7ppn4p13hWNhdx34jcy5Gyej45S8amKrKGV8m+zg3UbCBc Zy8MAnFto+advVzo/T+s+Z3+oyWt+LpVdHOLKvOqbA== =HQNQ -----END PGP SIGNATURE----- --------------YIISMi4lxaTHiovuYVDaIN07-- From xen-devel-bounces@lists.xenproject.org Wed May 25 09:21:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 09:21:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337084.561580 (Exim 4.92) (envelope-from ) id 1ntnCw-0003Io-OZ; Wed, 25 May 2022 09:21:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337084.561580; Wed, 25 May 2022 09:21:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnCw-0003Ih-Kj; Wed, 25 May 2022 09:21:34 +0000 Received: by outflank-mailman (input) for mailman id 337084; Wed, 25 May 2022 09:21:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnCw-0003Ib-5U for xen-devel@lists.xenproject.org; Wed, 25 May 2022 09:21:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1144198c-dc0c-11ec-837f-e5687231ffcc; Wed, 25 May 2022 11:21:33 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-11-myzmzlp_M4yGbMhB5r8Kew-2; Wed, 25 May 2022 11:21:30 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9488.eurprd04.prod.outlook.com (2603:10a6:102:2af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Wed, 25 May 2022 09:21:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 09:21:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1144198c-dc0c-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653470492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K6mMRAyFZPIyZS8j1LVxkRGwTbXHbG0OT1PgxAKolD0=; b=SvJqSrs8qgTx7uKnazREDYhgnW8vl8j5CkjsmtVCsum0AC4nrrYBLPrJaodUYl0KtYEK4x oKR1F4VlG477Xd4yt9a3c9zNm8Oep2yDAH5bYhincDRDP2rY06HISMjeEe6roTecfJ9+rW 3+XLxm7J55IngR4MvgALf+2F82HFyMI= X-MC-Unique: myzmzlp_M4yGbMhB5r8Kew-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dN517Ms4UAdGLv9NYVQeDRnSpEPgzawRPstFtSeceg1WaQg2kBvkRIlro+b3yd/Zb7I1Tj7FZkayxPRvYdKKk+qSWM7o1Nr6tiWbVUWI3O/RwJFdWNVBgX3bfNYAAzCaCqGo6eC7v6hkqwWjEHipW2DSIGNfwLSUeX+mTjQ63dqT9uuBOG7r2D6eAFAUoP02bkMx1+fe2w3Bxf66blg6e6B3MHo2Th4kSTcIxEOyLQPLQZsY8ZZibkznMqS88vJBDyodzj4fOECHAuebq+4MbQDLUxoXFzJQHBQVWAFIGSzVm3g7cumB1JrnPGEQD/Uz64H0ARkSxqWB0gDsgu5yFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K6mMRAyFZPIyZS8j1LVxkRGwTbXHbG0OT1PgxAKolD0=; b=NcUhEEjs+R1ifosnt+593mtlRt2Z6cCkw4F4hDy1s+U4jVq2u0VinQ2bSG+WjOig5Dh+rvmYcZDFIMGnlyri8ZNAt+9HDEHnyo9Bvb7EDvy+hfl8geKULNfqgEqayJvOoY5+Ifm9d0NVA0W+++NDscCtdtaIpEaULMZBnOKLAXAWWIQPL7Dy2BSbuLy+iKjs/jS3sLPm5cZbbNWOQaEbEYLVYUWBbJyBGVmlbqdq9ywpkNPtte0z4Xo6j/MxH00uqfYUWDWoTCSkhb7IRryo1JMQq0E2E/4Ipk63L++Z0Ec6BH0X+RVbMJNIB0Ly4WDSBcvVl3QEL0VmVXmi3IvYKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> Date: Wed, 25 May 2022 11:21:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Jan Beulich Subject: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0028.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::41) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82bf2375-4bcb-430a-c9e9-08da3e2ff31f X-MS-TrafficTypeDiagnostic: PA4PR04MB9488:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GbRzK5eCyuQi0tqlxn2zHcXM55+6LO89Y7M08NUtY9noaFQxGAqzxEr8jbrFjio1mZw9WulkFP22k+2cbmfpbfEqOBDJ3OH86j9a08zQA1eotMNQRE4k3hCV+vD9dQEiba93ViO5LmTgC7e5yMAB57344YNPPOKXKG4rMzuRK3LlDKPJNj8uoQTg9LxZDe+cTEp4DujnmBkiGQw0/qnUyqVPmb0ffbkyYWwwA2aj6V6+aq5/ZhFUgjyTsv39+hj7vAUvOzlZlleeFMXZdK9jTasaR5DR14qrWrZCMIklM/TurzdA/t9Zn86oLlM02XV9YPPGJUu7pNAHUKvNwYR4VAPkOkqtfDB72upWy1bVbn2Bc2pH32YCJcSL6txi7WJlK/rlEvhQdjq797Sff8OeodCxA6yqPvFAX/psQclwUJ+Vd6OVAiKReVVAyUNT8W/XARp4VfHyDPj8+raUeZvkB4Xpa6aKZ65xxxXNwtSjp0SZ5p0h2/BosCeasJSEobg6u6RAwm3dsxjoMlofZW1e1xcY3+2+4LfqHdGzwNKY4Kac8XmeXDKcR0sUya0UPgaJ09Cu/2bqRaO8zi4y9tT3u870/pUYGspEGxX9a+3jyb9X/fD/mM1BgYE6zE32qAwDnJudnidlVuIN56UDsqwmQEYtW0NKxWEEu/se5SHEpcAFjvFFZ/+cYA2EZCzsXgwSkHPkj7XrLjnJM7u/dcYm1Ym7U/aacJzbj/HE2fNcwNtr5Nmx2t3Hr7GidW4i4MzHdy/QiqDTOkxd8WEHtcI2yYN7vih3PhzoYJvQ58CBl2nvpP3wpsRgBHIyith/Nh3s X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(186003)(54906003)(6916009)(83380400001)(316002)(6506007)(4326008)(36756003)(15650500001)(66556008)(66946007)(66476007)(31686004)(26005)(8676002)(5660300002)(6512007)(38100700002)(966005)(8936002)(6486002)(86362001)(508600001)(31696002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3JZMmRWWEhJejIxK2VLcHYrQkRoMForRlJyWEVIQ2ZicmlNelpia3Qva0VU?= =?utf-8?B?cy9rd3Z4VGFQTHFnT3lUcXgzOUtGbnY5NWd4WWM3V0p2WTlFOUR0aHVCTmtk?= =?utf-8?B?WnBka0hDbGRHN2lhRUVGYng2SnNQSzhwa05uZlgwamdZUENPb0hPc2ZsbDRk?= =?utf-8?B?K3NOUzhoQ3lEc3BGNGFqWXNKQlJXWk5XajhHU0djQUV5aFRaYlhMNk5mZkhr?= =?utf-8?B?bkRIdUJRbUdhZVNJZUowb3h5OFRnQzk1VE1wRVR1REtsb0dNOEdtMUR4bjJo?= =?utf-8?B?QU56NngwRDBhSXliWTM3NWpsUnBHNEFSM2ZnZ0pXTVJHb3RIUndwZkk3SlMv?= =?utf-8?B?UGtLY0t5RFN2R2p5L3RTVm9zMGk1RkQ4cXk2VzNQUndPYnBLd3lRVWs4SWpt?= =?utf-8?B?U21LdlFLam9KckJYS3J2MTE5MkV5RnFqZGVJM1ZKZnNaVzBncjdmcllWc3JS?= =?utf-8?B?c21CdDVONVAwYTY0QkZEMnBKcG4xUUpod3FZSHhZUWluQUYzT0N5RmptSmtD?= =?utf-8?B?UHhzdkhLSTl6eEJPSGFKM252YU1URzhNZGpreU9TcUZ5d1kyOVZHUGtsOFpw?= =?utf-8?B?R2R6MDIvMkFPTzZOZVFCZnVWcTRXeU5YaVdiVmRDZGU0QXN2RTFVSWczQm44?= =?utf-8?B?VzBkNXIyQk5tMDJFQXVZeSt3dk5NSC90MUw1bnFGS1RtR2cvVjZnaUNHZElI?= =?utf-8?B?NzJja1QrMCtKSXRkQ3VFZ0k0eVczSkk0V085RUlFdko5YWNXaURHeUJmOGpo?= =?utf-8?B?ZG9Va2dRTDJoN1FMMTRqOWZkRjV3WlFQVTVQQ0JvcTROVFZFdGk1dEFNMDE4?= =?utf-8?B?L3doeXI2UVVVanpJaWRrUXMwREkxaW1lODBPbVlKM3FZU3BYbS8wWldQUFlP?= =?utf-8?B?c1NWWFlaT1ZWOHJSSFN1eDlwTklDSUtLM1oxTkEwZjBIbXA5L1pQT3kybGFX?= =?utf-8?B?eHFyQU45OUxtb2RaczBEcEJjSnJXQThEWjBSWnUyUzk5SlNmWWhVbVZEUDBx?= =?utf-8?B?bjNJZ1JIQkVSR1dCMTZwZkxRZWh0ZnVPLzZPRGp6dHlJWXZ2dnEyT0RJeTZw?= =?utf-8?B?VzlJMDVxdnhTdUl6YmNjcXBJeWJNang4WFNzMkt0aGplbXhjRm9VeWI2UmF1?= =?utf-8?B?eTIwSzlpYVRmWVdUZDJMOWk3c3JObGxEYXRRTVNpMjc3SHVKTHNUL0lMR0J2?= =?utf-8?B?TzRTblRZVERvOWcvRzlZSWUxSHRnRmhsdzlPSVRXOGU2Nmh4UlRkSG1Wancv?= =?utf-8?B?K0w4RmZHVmcybThSaTR4eCs2OEZ3QTRhTDl4VHNIaUt4cjdjQWVTNjFwS3Rt?= =?utf-8?B?SEo0V1ViMmsyaGh2UXRZanlLdTliOE1aUG5MRXFmN1REOFQwdGx6SmNuWVNC?= =?utf-8?B?YWsyOVhzMGNsNEcrZ2lSTjRWN25TL2MwYmh5SDZIbktxYVFVdlNZVjc4K3lC?= =?utf-8?B?ZDJ2VkR0NFNTeTVLekZyRElOVmRQWXAyTUovTm9FQVF3OGJEdHU3a3VBdFhm?= =?utf-8?B?OHoyVW95dFNSbWNHNFRBMmNJY2NlRmlaMElDRHJid3NoclRNakZDOWhvT3Y2?= =?utf-8?B?QVpvRlByQ0FoTUtGVFFxV0dxMXFXZUtKQU8wSHhOUlF0c01EZE96bUhDblU2?= =?utf-8?B?OENoZG9SdXRKMXJYamRwOThTK1RuTWhWdmd3cGUvSVh3ZXVJSFl5dE5pWEJJ?= =?utf-8?B?U1Rxc05Tb3RRSVZKUjNmaEIyL3FqZXVzcExXc1QyQUUrek5OL1BzS1BBU3Qr?= =?utf-8?B?SFFBbzQxVzRJWkpyTXFtK2J2TC83L1JuV3VySmNMK0dTOFpiSTlpK1M5MXVp?= =?utf-8?B?eHB5S3FxUmtodHBha2luUlBNU2xENW11MTBKYmFjRW45UUpwK3BwaGt5Mk4r?= =?utf-8?B?b2RwcCs1L3dZWEpuQXR4aXpKY2ZPNVJRV29jM2dxd1FZeHh0dGhCQ0E5UEV2?= =?utf-8?B?b3BtbUpVQnFPb1VuTmxCdlEvZk5mU05BRVo4dnhhdVowa2h0NGtPM1pPR0xL?= =?utf-8?B?c0NuMno1cDFLNFAzbVZPbjFMWXBoeG1HbTI1MlB0Szlmc0JLTFVBZmx4STZB?= =?utf-8?B?OEJaSDZEVGswTXNWMVNCVlB4bGJsV0E3RVcyTE9JYVB4WHQzWldxZkVmejh6?= =?utf-8?B?Mmx4bno1c2ozOGNEejZ4SkcwOEZKR0dVUDFlbzh3Mit3UGhBT2dwcm54Nkpa?= =?utf-8?B?bVNmeGlCV2p5eUFheXlOamFzQng1MkhVT3k2dGtjSy9GQTdOdkozRDMxa1lL?= =?utf-8?B?Qm5td1Jmek51Vi91T01SSHZCWWZxbnhPL1Jjek54anJzRUduKzcxMVc1b1hL?= =?utf-8?B?WXdVKzJaaHMydzZ1TkRWLzBFRitRdFR2OXZFVjMwMmN3a0JCRTZKQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82bf2375-4bcb-430a-c9e9-08da3e2ff31f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 09:21:29.1084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: APBX3XOtg2RXoSs+aHRjbz7Vhjvn+w8MrKCPRW28BdQ46XqT+KldfdI8eJC+2R2S4pwvvhCc1wdMzq7V5HHwCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9488 c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very much memory"), as a result of XSA-385, restricted security support to 8 TiB of host memory. While subsequently further restricted for Arm, extend this to 12 TiB on x86, putting in place a guest restriction to 8 TiB (or yet less for Arm) in exchange. A 12 TiB x86 host was certified successfully for use with Xen 4.14 as per https://www.suse.com/nbswebapp/yesBulletin.jsp?bulletinNumber=150753. This in particular included running as many guests (2 TiB each) as possible in parallel, to actually prove that all the memory can be used like this. It may be relevant to note that the Optane memory there was used in memory-only mode, with DRAM acting as cache. Signed-off-by: Jan Beulich --- v2: Rebase over new host limits for Arm. Refine new guest values for Arm. --- a/SUPPORT.md +++ b/SUPPORT.md @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra ### Physical Memory - Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. + Status, x86: Supported up to 12 TiB. Hosts with more memory are supported, but not security supported. Status, Arm32: Supported up to 12 GiB Status, Arm64: Supported up to 2 TiB @@ -121,6 +121,17 @@ ARM only has one guest type at the momen Status: Supported +## Guest Limits + +### Memory + + Status, x86: Supported up to 8 TiB + Status, Arm64: Supported up to 1 TiB + Status, Arm32: Supported up to 32 GiB + +Guests with more memory, but less than 16 TiB, are supported, +but not security supported. + ## Hypervisor file system ### Build info From xen-devel-bounces@lists.xenproject.org Wed May 25 09:32:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 09:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337092.561591 (Exim 4.92) (envelope-from ) id 1ntnNg-0004lb-Ok; Wed, 25 May 2022 09:32:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337092.561591; Wed, 25 May 2022 09:32:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnNg-0004lU-Lb; Wed, 25 May 2022 09:32:40 +0000 Received: by outflank-mailman (input) for mailman id 337092; Wed, 25 May 2022 09:32:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnNf-0004lK-5u for xen-devel@lists.xenproject.org; Wed, 25 May 2022 09:32:39 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c20d1cf-dc0d-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 11:32:37 +0200 (CEST) Received: from mail-sn1anam02lp2048.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 05:32:33 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO1PR03MB5684.namprd03.prod.outlook.com (2603:10b6:303:95::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 25 May 2022 09:32:29 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 09:32:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c20d1cf-dc0d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653471156; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=WnxaBOSI52SZYg4bEBjuuPTOoY5SytdFDfqFF76kiVE=; b=Z9hev3uvdRt+7MFPT273SaPqEBtq3rDBWoXUGn8BILpv8OQulKqucCC+ gWrbTXAf2+3GGz131nUrWtIS+3dLziqCUCxsaFLO64Bb2VuAiV0TSAedv XFHw8zOcszow8rL9+b0nMSPv+7Whql/N8WjINtEj1ttyt3Gn/LMwH4iQ3 o=; X-IronPort-RemoteIP: 104.47.57.48 X-IronPort-MID: 72529723 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tkyuia7ZQZkCwv2cIVy00wxRtEzGchMFZxGqfqrLsTDasY5as4F+v mMfWm2Ga/ncYWSgKtt+b961/E9QsMfczIIxSVRpqC9mHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjXlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSiSEQMM4yVwt1DTh5GAh1PDY9dxaH+dC3XXcy7lyUqclPK6tA2VgQNG9Rd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiVo4MItNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGcF8gPK//FfD277/gta4anKPYTpPfuxXsAPwE23p VPW4DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW72Wg7GBAQE1yhrpGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMU/4QCJj7HSug+fD21cFDpZMoR65IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:2ItyOqkQcfJDgcION0JY6C/8Et/pDfO+imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH42GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC P4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR4Xue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqWneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpf1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY3hDc5tABKnhk3izylSKITGZAVxIv7GeDlOhiWt6UkZoJgjpHFohvD2nR87hecAotd/lq H5259T5cBzp/8tHNxA7dg6MLuK40z2MGXx2TGpUCLa/J9uAQO/l7fHpJMI2cqNRLskiLMPpb WpaiIriYd1QTOlNfGz X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72529723" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YmG3NzyBnOuxEx2uAFk7ulP3ozQA7PEYFe1lvkMy/G2gPJr89h7qaE5rbsQ27bUSTLjQhyP5vSYMXtH2QJnIhJNfC2d9Qf37NAMlSrdWzRz5koNi/xTbUqG5W6sutmfFJOcwsOyg4JVjB9ehMPypF8l6TeAkxQLoWVsWLy5r/i0vZDr5jT1h9Eq4YFiX+8JJjsDtq1uaQVO60f6A744SrCoHO7qIMKvpbvEXrYHMUynp7SH0q6aK5DWEBe96OkiWEx2msoQR1sD/trju9+KLYWWWvE/w8Yf6o0Y2HgIwNYeTnpwORRtPSgFiokkup/YTkEt0fHf8UW30EenkwtnYQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kch/SKVWSwIN4uB0vHx2zrSytidkUMUy1vMrs1Nj9y0=; b=CW7bthVtRDA4tXSIOcnRNAxdLSLpCOAK4eVyWf/qk6/1JldCMIAWMfb0rtKman8E2jInwd3geXtYAPKQCxjiDTGWMr0rqe3O7m0owY1G/yzIkWyfYhg4Jr10tT2u0zBHnAqvl42IQsyiWFj0OODt5jSLX4Zsnukv75Co9CHgY4gCR1kkYi+1PDM9Wiq54ITw0Efw1RdMBVe9+w4SPqOUNXCyhZF1QMY4LNKe5OQHt3TJk91N/CkozcIuhRAWdv4feW53/HTmxDKHfz4/YPIuUXU4lj/YwSGf9BcuW1ecp3zqnJbkea+F1XeIC/oPK+Sm7BJzBAjzTBnwdDiRk8HF6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kch/SKVWSwIN4uB0vHx2zrSytidkUMUy1vMrs1Nj9y0=; b=ORMoD7sic1IzoE1virsdFUarWWKDfk6KSMOXP2QyyJzEC84037/L7084weLzWuThWI9BEue4XdP1VqtrI3Hjaru0qLjUjU3mtYgjcH1Thfr/1puqbqSeov2T0tvkzcyGu/1BdYy8zpCTMqYLSobijIPqx1y79f6Z9Sl2J5J1r7Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 25 May 2022 11:32:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 2/2] x86/flushtlb: remove flush_area check on system state Message-ID: References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-3-roger.pau@citrix.com> <2f030cf7-fbba-6ae9-b797-f695221ee081@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2f030cf7-fbba-6ae9-b797-f695221ee081@suse.com> X-ClientProxiedBy: LO2P123CA0097.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb12cb91-7fc1-4d5e-e9a6-08da3e317c53 X-MS-TrafficTypeDiagnostic: CO1PR03MB5684:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p2SbgwI4qn5afl0Zu4psnZbuMv2xc+H+oa4b3CmZUiSOs5M5r/yr6+n7NkdbEjiB05ojTg3EJpOpGOJW2NhkXq97iWAepkX1Hvjo8Ql39oMXM/U1mlWsFG08VmpnI4QSrhIg3L+50aoN3u2sx1ArZ6v0zlJQkWJSkdDgolwHQlgPRRKJ/3YHhavms8JnHV0LiMzMtUPAegRuYSsCKF0CGucUHxp/pVdvKzeQtqgQrEsrj4o++fWojV7Cr4KHDBiCOboGoWv9oqVTHUsg2HDurYHj75QCVD6uWD3Fd+XFHpTO1XRO/CDZzgB5yXvEsDNPfOoHBGO3+uJ4ggE5yE7FhM9gkzvnOc/BS//Ub0m5PMQjSQrzvA6XyGazEvwt3yzFAtgrciIjFFqUNgh3z80BvdG0w6GaAbWfDE92XP2fzpFrisNyMvTbd+kXaYskjzLA+rXPb7S0bQy9o/LiSCQep55iajBHEFc1CTiX3ZP8nngCoHlnel4KrWj4zbmoMARRbpJg5YM1M/rZ+CXE5hsCBvfhd846iCVaw4GACcjmlYhTpNzv1V227C3FtL5tt5FKwDJDEsfUpXaXzatc15CszECeHxQxvCE13eoLV3pdlI1buNRemcCP0qLDiTKPbfGBz3rsf+MQcBovYsuYXulmAA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6486002)(9686003)(6512007)(26005)(2906002)(33716001)(186003)(6916009)(82960400001)(85182001)(316002)(54906003)(38100700002)(8936002)(4326008)(5660300002)(53546011)(6506007)(508600001)(86362001)(83380400001)(8676002)(66946007)(6666004)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amhjQVRBdkQxTUk5T0VnbG95bHVMa1M2elg5NXVSejVmeE1tdGNDRGZCTGFo?= =?utf-8?B?MXBsREhxcFZQYTlUTW83dmJxT2ZRNS9kVEc1WUlQckZ6MThwbG94dFZsdlJP?= =?utf-8?B?aUcvaTUwL0tVdndGSnlvRSsrQUQzZ1FoUHI2KytWeHRWa25VcVR0V2dDbGpN?= =?utf-8?B?Skd1azZRSUFjK2xNdVVaOTdXZFdkcGp1TnRUT3ZJRjQ2UTF0aTJIcHVVQkxR?= =?utf-8?B?Q3Z1dkV2NDJ1ME5xT0QwbXNsRU1TZnF1cmJkSVhSNW5QMG9sUlh6WFVqNFZt?= =?utf-8?B?UXZZOWxPWUczUldGOWdzSXVaeDFaNnMwQTUyM0xmZUFxWmVhUnB6WFVJVGI0?= =?utf-8?B?KzhXL055WFFtTFZDNnQxZ3BVS000RDJXaHkwV3JTRnpWc1JuK2lROWZuTjJB?= =?utf-8?B?eTVsZ0xNN0xneEN2TEJtOXhUZWliV00vaXovZVJiOW0veVR5S0tzV0JtU0NY?= =?utf-8?B?QVRYTWJCMFBuUHhlbGdqS1RtY0hLZDJlb3FkVnlRaFkvZXl4QXZlVFIxQldH?= =?utf-8?B?OVFWK2l3YjhKcDRZb2dUY2RUdGNZNU9YVVFnT1dCK0hmbTFGMEZrOEdnallW?= =?utf-8?B?T2hSMEsyOWN1anRMK2N4d3N5Rit4NTd1VlR5WEN3Mk8zS2xXRlowem1KQzF1?= =?utf-8?B?RHVNV0ZodllPQlNDOGtrdUpkc3ZNeTRvSFNGR2c1Sm5Dc3k1Y2pqb21LYlUw?= =?utf-8?B?K1BHRy9rQmlkMVBnOUl0YVlLRm5EWXJrU0RreDE2QXEvUVhDLzE1K0hIWEg1?= =?utf-8?B?dlJ0dlJyYmVpdUtnQnl3RnNnT29RSnB1cTBITm5oa3loN2VzWnNvWGc2QXhQ?= =?utf-8?B?ZUwwRkZka01YZmxkMjV5TUYrcUxPV3J2RDh1RWdIRTdVUWJDaExPVXdnRHBT?= =?utf-8?B?ek90RXZ0L1o1ajVvdDJpTWNSS2Z4YXZtWlFiVUpvUE1RaWNyVExaajhxOW5h?= =?utf-8?B?MHBYcXNoK2Eva0ZvQ0hXSlgwTFBpMmFnRm42VGR3OXlmdTJEVTZTbHdhZlg3?= =?utf-8?B?cDNnbngxMkI1U1BXSCt4aG1PRFU1VTBFbmdUZDQrK2VTeVhqSGY2TUJNUXI3?= =?utf-8?B?dmJkZkpwR1hrSUNGYTl4L24vcWIxdE5KUElRN2RMaWEwT0l3eDlSRTQ1aFlM?= =?utf-8?B?MXROdVdlSzZDRDQ5UVExVGhsYi9PaUxRZ1hTUE05RlByR1V4eHFUdDAyZHFD?= =?utf-8?B?WUR4OGFaSWQ1UmNlMUluWnZONFZHVGJNWVhnRGhsMDBTaEtJM0NISm1lWDBn?= =?utf-8?B?cTkxamdzZm40VXFWNUlBM1JIOGtCVUtwaTBmYXpwWjhlVC8wcHIwZHJaVjE4?= =?utf-8?B?d3FyZk5yZEJwZ0F4RlhyaC9LQ1dhWnBqY1BLUXNDMTJLRkltSEFodFYxc0Z1?= =?utf-8?B?OVJsTnRvQmRoSWNNZVlGQUg4aWY5b3YwMG1VVFNyOSthN2FrVEk1SmpGQVAx?= =?utf-8?B?Sm4vNlM2WnlJWjFNbDZ6NGtuZTRTY0h6QjdWeEUzc09Ienh1MHFxSndUV0xW?= =?utf-8?B?SlBEUmtmeTdDcTg1NUozSG13QUhiUFVYeXF3MHBjWklUTWZMTnRvYXhBS0ZB?= =?utf-8?B?OW16ZnFQMGZCbHhCRWk4Y1FqVEZVcXloOWFBNHBST2NHUVhKdllqVXVRdzQx?= =?utf-8?B?eGhDYytVa25GaXc2VnhkR2lCV0RpYjNROFBkaHE4aC94YURvOXZiR1k5VWxk?= =?utf-8?B?WnZrSVlrSmtrMFpyOUdWd21jRTFRZkZVL2ZERzBMSDVna3NWRWd1SFNpYVVI?= =?utf-8?B?Wk0yQXdVcFhzbThlYnlCOE1MRmlvRTZUMzYya1RFZytTVTdVNktrNHFldjZ0?= =?utf-8?B?OTVnblRaQmhVeDRzRFVaVmFOOFFYcjVzR2liNmlzRG9iOGNyaHovbUhNZ001?= =?utf-8?B?YUFoU0ZqUXhOTzRKOWtCNzYxT1l3dEpwMDBZWFY1dzNjeWc1d3ZKbVhGK2E0?= =?utf-8?B?aFQyNGdvVCtrZk1qd3I0c2RwdjRhR0pQVzF4eTJMUDNUS2I2THByRFdubElw?= =?utf-8?B?TjVNSy96TTJ3TmljY0gyUi9RK2NpQTM4MThYbkhLUHd0Q2NvRDN5ajVOOU56?= =?utf-8?B?bGJvSU00djQvYzN2UFNrSjJqVDhWdkduSUhWM2xIcU4wQzY4aVRvTmdnT0pB?= =?utf-8?B?eTBld2pDUG05SlkxMnBEdUpxcnkvdVRZYnRnekRoNzdkdUZ3SUpnYnZMOFR3?= =?utf-8?B?SlVaSlVLVXNsRFRYTHFncGRnSVBmRXBoS3ZrVHR5TDZpY3ZLazBzbzZKUCs3?= =?utf-8?B?RHdTYWJBZ1E2MjhIM1pDVnZIQUNzeFR4clRUTWpHWDJoNWpWODltZVVpOUhL?= =?utf-8?B?ZnoySlk0VUVOVjJCOUhkZ0JFQ1BnMHV0ejc3cFFxeHEzM2YrOFhMS3o4dHdK?= =?utf-8?Q?APiuianuMu9VESC8=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb12cb91-7fc1-4d5e-e9a6-08da3e317c53 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 09:32:28.8102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zkd4ETuivNUopiSygGg2bMlRkqVSFLdT6PpMQ1EpfKH1HeKGrHqkrYR0MZpJY7Cvq+R9/HBEln4jXeup9Qj0Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5684 On Wed, May 25, 2022 at 10:41:51AM +0200, Jan Beulich wrote: > On 25.05.2022 10:13, Roger Pau Monne wrote: > > Booting with Shadow Stacks leads to the following assert on a debug > > hypervisor: > > > > Assertion 'local_irq_is_enabled()' failed at arch/x86/smp.c:265 > > ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted ]---- > > CPU: 0 > > RIP: e008:[] flush_area_mask+0x40/0x13e > > [...] > > Xen call trace: > > [] R flush_area_mask+0x40/0x13e > > [] F modify_xen_mappings+0xc5/0x958 > > [] F arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9 > > [] F alternative_branches+0xf/0x12 > > [] F __start_xen+0x1ef4/0x2776 > > [] F __high_start+0x94/0xa0 > > > > This is due to SYS_STATE_smp_boot being set before calling > > alternative_branches(), and the flush in modify_xen_mappings() then > > using flush_area_all() with interrupts disabled. Note that > > alternative_branches() is called before APs are started, so the flush > > must be a local one (and indeed the cpumask passed to > > flush_area_mask() just contains one CPU). > > > > Take the opportunity to simplify a bit the logic and make flush_area() > > an alias of flush_area_all() in mm.c, taking into account that > > cpu_online_map just contains the BSP before APs are started. This > > requires widening the assert in flush_area_mask() to allow being > > called with interrupts disabled as long as it's strictly a local only > > flush. > > > > The overall result is that a conditional can be removed from > > flush_area(). > > > > While there also introduce an ASSERT to check that a vCPU state flush > > is not issued for the local CPU only. > > > > Fixes: (78e072bc37 'x86/mm: avoid inadvertently degrading a TLB flush to local only') > > Suggested-by: Andrew Cooper > > Signed-off-by: Roger Pau Monné > > Reviewed-by: Jan Beulich > with ... > > > --- a/xen/arch/x86/mm.c > > +++ b/xen/arch/x86/mm.c > > @@ -5070,13 +5070,8 @@ l1_pgentry_t *virt_to_xen_l1e(unsigned long v) > > #define l1f_to_lNf(f) (((f) & _PAGE_PRESENT) ? ((f) | _PAGE_PSE) : (f)) > > #define lNf_to_l1f(f) (((f) & _PAGE_PRESENT) ? ((f) & ~_PAGE_PSE) : (f)) > > > > -/* > > - * map_pages_to_xen() can be called early in boot before any other > > - * CPUs are online. Use flush_area_local() in this case. > > - */ > > -#define flush_area(v,f) (system_state < SYS_STATE_smp_boot ? \ > > - flush_area_local((const void *)v, f) : \ > > - flush_area_all((const void *)v, f)) > > +/* flush_area_all() can be used prior to any other CPU being online. */ > > +#define flush_area(v, f) flush_area_all((const void *)v, f) > > ... v properly parenthesized here as the code is being touched anyway: > One less Misra-C violation. This surely can be done while committing. Indeed. I had my addition properly parenthesized, but forgot to do it here when moving the line. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 25 10:12:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 10:12:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337100.561602 (Exim 4.92) (envelope-from ) id 1ntnzf-0000WA-SX; Wed, 25 May 2022 10:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337100.561602; Wed, 25 May 2022 10:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnzf-0000W3-P5; Wed, 25 May 2022 10:11:55 +0000 Received: by outflank-mailman (input) for mailman id 337100; Wed, 25 May 2022 10:11:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntnze-0000Vx-CI for xen-devel@lists.xenproject.org; Wed, 25 May 2022 10:11:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1743abc8-dc13-11ec-837f-e5687231ffcc; Wed, 25 May 2022 12:11:51 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 06:11:45 -0400 Received: from CO1PR03MB5665.namprd03.prod.outlook.com (2603:10b6:303:94::6) by BLAPR03MB5572.namprd03.prod.outlook.com (2603:10b6:208:292::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 10:11:43 +0000 Received: from CO1PR03MB5665.namprd03.prod.outlook.com ([fe80::1d9e:d2a0:5b4d:6374]) by CO1PR03MB5665.namprd03.prod.outlook.com ([fe80::1d9e:d2a0:5b4d:6374%2]) with mapi id 15.20.5293.013; Wed, 25 May 2022 10:11:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1743abc8-dc13-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653473511; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=iQ+9ZYvrMVv0q3VmwDIkOlF738TxWHq4oav8OSQcZtE=; b=NFJ+YJHKyzneVKdXaSfAjk+9NhNBpCiEcNO+oK37KF7BXhdtVG4ItkRl SRw0EXd6fnvcCRxiMNSsbVaRTJGBvXHP9SQU9aOC2jU3/NgT165S+a4M+ rZ46P8nsH0BzdOCc7dRqFjX7F7sT/LAzkQgbDJ5BSDxVThzXL81ln4z8P 8=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 71499162 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:j/jlPKh7UkOBBv21QQLtrvZ2X1616BEKZh0ujC45NGQN5FlGYwSy9 lOraxnFY6jUMyawOYxoOc7lxf41ycTSzd5qSgVtpHowFnsXpcTJXISSdRz6YS7Nd5WfFh42v swQY9fKd5psHnKBrEqma7S6p3cjiv7WS7H3Vb7IY3gZqWOIMMsEoUsLd7kR3t446TTAPz6wh D/SnyH+EAP8izIrPmhN4viK90hksav/5D5Ct1djOvsT4gGHziFPXc4Tfa2/ESD1E9JedgKYq 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1DI0BK6YoD66vR4jnVaPp0TabxNMC+7tx3Tx4ork IgX6MTpIesUFvakdNo1AkEw/x5WZcWqyJefSZRomZXOp6FuWyKEL8RGVCnaD6VBkgpEKTgmG cgjACIMdni+a9eem9pXfAXOavMLd6EHNKtH0p1pIKqw4fwOGfgvSI2SjTNUMatZammj0p8ya uJAAQeDYigsbDUTYg1HKaoimtuwn3XxbCdmgQLKp4Eetj27IAxZiNABMfLzU/nTH4B/uBbdo WjLuWPkHhsdKdqTjyKf9W6hjfPOmiW9X58OELq/9bhhh1j7Km47UUVKEwfk56TkzBfgC7qzK GRNksYqhYc/81akQ5/RQhu8qWastR8AQdtAVeY97Wlhz4KLulrIVzFaFFatbvR+jYxvdAJ09 mTYgoPjGjwzoOelZk20o+L8QTSafHJ9wXU5TS0OQBYB4tLjiJoulR+JRdFmeIalg9uwFTzuz jSiqCklm65VncMNz7+8/13Mn3SrvJehZgwo4gTaWEq14wU/Y5SqD6Sz8kTS5/tEKIefT3GCs WIClszY6/oBZbmSkASdTeNLG6umj8tpKxXZiF9rWpMnpzKk/if5eZgKuW8uYkB0LswDZDnlJ lfJvh9c74NSO33sarJrZ4W2CIIhyq2I+cnZa804p+FmOvBZHDJrNgk3DaJM9wgBSHQRrJw= IronPort-HdrOrdr: A9a23:uvVQUqHptlpBa/sopLqFRJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhcItKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuRD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlAawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontVrcZrau5t+7f63+4oowwbX+0OVjUNaKvm/VQUO0aKSAZAR4Z 7xSlkbToJOAjjqDxyISFPWqnXdOXAVmjDfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFv9dLSU3am2a/hGrDvDnZMZq59bs5Wfa/ptVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV4Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r9NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC76 gpkGkowVLaV3ieefFmhqc7gywlaF/NLgjF24VZ+4VzvKH6Sf7iLTCDIWpe5vednw== X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="asc'?scan'208";a="71499162" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RBzB3X2g/mqYw+rcTTlrcKljR3CIH7zh11qmMFCL2TKMwj770uTYjSsWJbPgLSnSOU6OqPG4D7D4Tik+GS8cMDqHohGhXn+OM/lAz68/5dg7k9d5cn/j7Wj0y+PnavY/wK24TArpmBTiWa7BzJA/b3yvZEx//2wipLIvRq55N4jMpsXxFreXMsNvViGLpyigvywFOcFzstcwplRKhG470Frhyf8t/a1RcUhxlOWanaheiSiNw5NebpufEMwOJZZ4LQhm9KB50UQLdjTgLnAvd3QXWyIrL2ndwXZL4bUWXFhJGMd+QYKw+HE+W4qpCVrxEtN1rFmtfoQKYZwi3tfgQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1sMPRpRtdJlwn+FvFZMBvAovNRw+WBr4Wwzqhk1Xic=; b=J3FVHmbX69MbKmRlvhA7jUFpULAyzikawicOSTottVLzrC3KpjY0D62LWLHsIao9uUT+GfBGflJVI43kildjrXI46gveO0ElSq9+IHjkxY/ioXoesXkTFd6+ZGKIECjBF/iHzTqkXxT70yE1QNSsac4mpBJjQkmXNV6mUsa+fG03CSeJkwRkxiLPedXgl5nhYND8t6vGKMrTi/g6s+Cw/YRhwZEDohTijgnZesT2OY+pBX+9EI/QXUV+7qGSOTo20R6aBNBf/X8dsBtFkg7uoWutatzkGRkcHjUr9z187tpJK7TZaDAeBZ5kDCv5QYwVSRgj39wHU0ib8MjpgvOmrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1sMPRpRtdJlwn+FvFZMBvAovNRw+WBr4Wwzqhk1Xic=; b=Z3uSUJRniAzdfCR8X+4eRYQ1zIv7wsT5DdgMY8UKelFso+2xqed1DlTfJdj9wRfLPQf1t64QCIOeccoe0ltO3+hN1UZhFSGg6h06OpupoLioTTKeKSPQJAhZY3zdGKLOpYy2+EHlWtygB+ytSD4N0nDRoQehmVAdi8oyqKaXGA0= From: George Dunlap To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory Thread-Topic: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory Thread-Index: AQHYcBjWfPzTxGjMZkmAolCxhSaQOa0vX3IA Date: Wed, 25 May 2022 10:11:42 +0000 Message-ID: <1958AF4F-8DF0-43BC-B31A-38C2A1835A78@citrix.com> References: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> In-Reply-To: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8081ea24-5ccd-42f4-2a16-08da3e36f79c x-ms-traffictypediagnostic: BLAPR03MB5572:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mfyg9IbEaG/P710z+4dHMP1BO/P30wgxICMPaZgVuUgJDDGfoiDvJPBxOfheBLQ+z/TaSQfzmSEpWWa+w6d2PRcOLDbcQEW0PcHhnXflxOjdG8T51d9l5f7Yt8DHgfeGQKsQBaNgJVoZKdsgCSuXPX3rKBG3iOuLVq6cNuxr7IH7cCjJv57DQVPf/Dn3fvjs3N//kmZjuCUoPEvdOLbXoe/9B56NRoMzpFup7K5B8HDfvF8IauBJuTdfDq7IcNVaPqRjHbFY9kQooCkGP7CgSYqT8HQrpfLoyM53RIJWh8anQe7598dwu0Y6dKNyJ09NC4cfqRg9iwFSm4TFghoEKQLUjI3IsiYBELUUl1hCypMRjhhuZfUqFvCaJR6IO6b6YkFHmwHrNroJNKvxgwz0yBz5BWgYHXQE9x2y3zSanqTwW6Gw+3/4iOzmPdq/cifK1Nx7uQiTePJ8613i7Nabcl/Cj4eKig846ApeA0lI7xjhaRHeFUDgyWmgR16LOs/NTbuka1JuymAMDCz8w3ym/uONts89K0R7f4C8iYIiNGRBc56wYdCaeYoKa+2uNYxU6bM8Z3EyLvrC98Ha+AYQDxkrlMdQxjU2QXiF43ggbWLS47cm57QHQPCa2pJsE83O0YDklg6UxtQOMkZ73NN0n4CjvjmF0cG2W2OJYJVgnExh9/g4fvF71gC7U62G38PDQ+QWkM2H6sWBZdDtBdY9LWFHV+5vMmE50EzbDuTXWMufxDXmAmYCxm2i0LKbk6msXJEPWX5xEt7/J8te4ZSGA2zbsd0DAgb2gOd25PwWSCe+bRjh62PqygTefs9nTtstwi6FooU5p6TRe1MqS+r9nA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR03MB5665.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(66556008)(66946007)(64756008)(6512007)(26005)(6506007)(8676002)(66476007)(4744005)(15650500001)(76116006)(99936003)(91956017)(82960400001)(86362001)(71200400001)(508600001)(33656002)(5660300002)(83380400001)(6486002)(4326008)(966005)(122000001)(38100700002)(2906002)(316002)(8936002)(2616005)(38070700005)(36756003)(6916009)(53546011)(54906003)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NEc1bWFPbEJxemNZOUI1Y2FsaldGbGVUUVJsQUl5dmxYT0RyS21sTlYzYXRT?= =?utf-8?B?ODJzMElwQWM3WWZMWDR1aE5lRlE3bS91VWZOaE80OGo3REV0am43RnhpUnl6?= =?utf-8?B?Nm1oRk5PRFF6NDZlTlVBNUVmSktwRndCc2xpRUxGOGRPNFAwM1l1YnBkQUsz?= =?utf-8?B?aUp5Qks1cVFyOHVVUXhzZHZDd09wNHNwV0VZTTN3WVNWRm1LT2cxaHM0eGVl?= =?utf-8?B?dWZGVklVY3lMcmw3RUN3OE1kVzlxTC9wRThXNys2a09DcVR5OWZxaTNZUmNG?= =?utf-8?B?eXpkR2E5eDQ3L3I1d0piNHBXY0NVV3lVcnRxZys3OVdkWWEyOGpXSWREWmxV?= =?utf-8?B?UDhGV0dDK2hoSjlwM0NQOXBKbHVlZVR4REJxSWN3NklpNG9BYzZ4d3pkbi9X?= =?utf-8?B?R25qcEY3dVNLNEM4bE8wQU5QSUM2Z0xtZDRvNktWcldFNlVvYnJXaWhPYTFo?= =?utf-8?B?RVBJU2dNSUJLVU9JNnBBZ0ZUZkJJTHYza2YxVlVERTlpR0tVTm84b2pSaitp?= =?utf-8?B?Z2U4YVU4Z2N3czlPanBQRmtWMHV2czdZUlhpaUtYdmlKclZHeHpVVitibG5w?= =?utf-8?B?RUxKTU5rdm9kd0RxbnBYS0lrK1pTWlRIR1BsckY4elAweFZZRm41NTFrRzN1?= =?utf-8?B?RE1EU21sc2ducncySUhPZHhmS0h2UTRlWVVYcW54bTh5eEIxQTQ5QjlZdFFq?= =?utf-8?B?VDEvOWxQdkRNcWhMNVVGWStqQk9OK3pESWh4Sk42ZGxncERreGs0c3RFYXFy?= =?utf-8?B?MGtPUFdmMG1IOXlTUGJSZFJmcnN1NjQzVjRkNGlwUWE3NG1MVDhjUkJlTnJL?= =?utf-8?B?ZEFhMlM4OExWNkdORVJwR2dMMnA2ekdPQzFLWXlrQW00bjl5Z1RqQ1ZQTFFq?= =?utf-8?B?TFphcVZFUTc4d0pFY2ZSYVZCdmRFbGNzZG9rR2lQcXBhNEVvbFJOamFHdkkx?= =?utf-8?B?VzVhZEoySlB3YXIxc3graTduelN0alArSWhXQ2EraGFYelgwUXFncmNSUVgw?= =?utf-8?B?ZnVsckw4RmNLbnI3a1RrMVhMcER5dUJzZTlwenl6QUI2U3BxSGc0MjlqbW1h?= =?utf-8?B?WlRBbVpCMS9PQTJudy9GR04wc01oMjZvaUZlY2x3WDRQUW1kVEtoenJJTDVS?= =?utf-8?B?VnlhYjRGZkV3K3JmVDlrN0ZPZ0ZXMmNSLzlDTHhxanhXbi91R1pVWTJWcHdy?= =?utf-8?B?c0dSTjFyRzd1T0sxQ3NWUk9TWjRjYVdWS25aTWx5OTM5VUd2K3BQK2V5dmJv?= =?utf-8?B?a3FYaHpLSFVhZU8vcHBiNXNKSExrZnBqQ2FOL0xCczJzNFQvclFXR09QT2ty?= =?utf-8?B?K0Q4ZFlnNUxiOWM3WndteFhaTHI0UFRyNUw4UXZ6T0JKcjg4TUp3Tk9CNzI0?= =?utf-8?B?UDRoQTI2SEZ2RTVzYjU2L3NUODZVVDlHMTN2UkVwb3V5cW1OdVVCaVlCOTdP?= =?utf-8?B?c0pKWHN1Zm9ndWpKNTF6VWpGS0h3bnpJUnQwRU1QdVloVkNFV2tQRTNTMVNL?= =?utf-8?B?ZGwzbzFUMzVIaDdFL1BIb0ZHcVp2a1QzeHFZMVE3VFhxR3RzQUNwVnlLa016?= =?utf-8?B?QVloakgwZk9tNDNvbi9keGZ1dmZWajBmVHFWMDhuTjhSTWRUWlN2aGZhUGht?= =?utf-8?B?ZW9NYTByTjJrWmE4WlNPZjVFbmxJdHpvWWl5TjIxSXZQUndqb0dxTWtNVDUr?= =?utf-8?B?bEY4NmhCQytZL3M2VGVrbmtWUFpoSzhvUUJFVGVTb05oMndnUjFqekZDcEhI?= =?utf-8?B?Zkd2djMwcVVZcmU5NTd6OWhhZVBXRzFJMzZCdkRRVDhPdVpTUUg4L2d6bExP?= =?utf-8?B?WE5WZVQ1SmRDdzZaZzNWeWJsKzJSaEY2SUtQcXV4YURqajBzNmczOG5KdTV3?= =?utf-8?B?ZFA4VVRWc20rdnVrRzJxYWptelE2dHFRRTVuQU9CN2RvUHlpaXNlWmlzMkpS?= =?utf-8?B?MjhJOGcrVXlkVXIyM3Q0Vi9HaDROVEVrZ3NpbEZSWkxCVVlEZ2VUT21YbkQw?= =?utf-8?B?VGNwaGRnYUZDQXBHczIvV1VYclVWZjVhQlhjTzRUekgvRmhPMDlNeUJZZWxB?= =?utf-8?B?MFlPbEwybGVMSHJBeXE4djBZaFhDRnc4dkFzMGJhN0xhWnBrcjAvdXo5L1Iv?= =?utf-8?B?cnhwc2tUMEFjZ2txYVNTL0NFb0VZOXdyc3QveFFCbzEwQkc4RG1HckdxekdS?= =?utf-8?B?TUtxaU1qNjVBTzNLSjlVeDFOdzVETFBpQ3IyWFpKcHJwcFBsUnBDaVBFUnkr?= =?utf-8?B?RnUrbW0yQXQ3aHBrSG5zYUhPejROL0JLU3RTRjFlemVNVEkxc05WU0ZvbEQ0?= =?utf-8?B?RXowdWJOZDRZc3ZqTVo4UkVQVHJzNDhjNnBLaS9RWUlKWllOdGVTLzhhWFl2?= =?utf-8?Q?oHC4F68Ox57zyLZI=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_63A6192B-B54A-438A-B4E0-CDA5ABF4C499"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR03MB5665.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8081ea24-5ccd-42f4-2a16-08da3e36f79c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 10:11:42.9240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TjinqYdzw6x9yCipe1n5krNAUocuZneTyUg5r9UGR9EYOqGA/NX6B6sZ/1KGr18yxfiOWU+Nj6YbYvUVM1zozlpz2roTbh/oSNdt8HFKxb4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5572 --Apple-Mail=_63A6192B-B54A-438A-B4E0-CDA5ABF4C499 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 25, 2022, at 10:21 AM, Jan Beulich wrote: >=20 > c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very > much memory"), as a result of XSA-385, restricted security support to > 8 TiB of host memory. While subsequently further restricted for Arm, > extend this to 12 TiB on x86, putting in place a guest restriction to > 8 TiB (or yet less for Arm) in exchange. >=20 > A 12 TiB x86 host was certified successfully for use with Xen 4.14 as > per = https://www.suse.com/nbswebapp/yesBulletin.jsp?bulletinNumber=3D150753. > This in particular included running as many guests (2 TiB each) as > possible in parallel, to actually prove that all the memory can be = used > like this. It may be relevant to note that the Optane memory there was > used in memory-only mode, with DRAM acting as cache. >=20 > Signed-off-by: Jan Beulich I haven=E2=80=99t been following the discussion, but the form &c LGTM: Acked-by: George Dunlap --Apple-Mail=_63A6192B-B54A-438A-B4E0-CDA5ABF4C499 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmKOANoACgkQshXHp8eE G+1ElggAsYmdsZWPrxYtF/23LHtpQfN3CIx6kFHEfAbG2t14a4EwUuWzvL9TTM/X SyT9UILMXxnThrtIIp7u6D3sqeVI9VcW+Q70fYAdC6k6K/8ILplVY5H55ERaxm5I U4nTBkqnp8yXxfPshqy4JLcjElSgHf4IafN43aN4LyXs8jjnOQZybwFqGoVVsT2S 5X2mvHvreerg6KrTXp/FcKsyetov1pauvrqotp29GwRRw6vsoBeC4luvR9buIDco O5TtUALooPAM54PbgRSoN5drXqI679fPYqvnK6t7N2IQS+znp1TUsn4mU/2hKDVm rR0f2NQOBqZzoX7GIHvx3CR0C82YmA== =VNR3 -----END PGP SIGNATURE----- --Apple-Mail=_63A6192B-B54A-438A-B4E0-CDA5ABF4C499-- From xen-devel-bounces@lists.xenproject.org Wed May 25 10:53:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 10:53:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337109.561613 (Exim 4.92) (envelope-from ) id 1ntodP-0004g0-6v; Wed, 25 May 2022 10:52:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337109.561613; Wed, 25 May 2022 10:52:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntodP-0004ft-3q; Wed, 25 May 2022 10:52:59 +0000 Received: by outflank-mailman (input) for mailman id 337109; Wed, 25 May 2022 10:52:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntodO-0004fn-Ei for xen-devel@lists.xenproject.org; Wed, 25 May 2022 10:52:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4ad8316-dc18-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 12:52:56 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 06:52:51 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN7PR03MB3426.namprd03.prod.outlook.com (2603:10b6:406:c8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Wed, 25 May 2022 10:52:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 10:52:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4ad8316-dc18-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653475976; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=x1btQ+fYTf0FYETmvwAIv7s8JzV+qrhowIJ762Rxuw0=; b=VIOmaQQsxxcg3OZlw7oLAQ0blGgtALyaBySOQDbGCWL4E9WMmBjZAT94 7npPEpgswRXP3M2Flwu9cazJ5qcmZw9m155zm8omltW6k3B7Zw1JrpWgk EXFedBe7VyN2tj+5snV+R4L3uPczWzXUSkkZAYPSjjw1Aby3E01shb0Un 8=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 74656847 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XEI12ag09trqPqPHjqmEvBb7X161ExEKZh0ujC45NGQN5FlHY01je htvXGHQM/zbN2WmL98lbtnno0sA7JLVz9YwQAprriAzFigb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnQ4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQYZFLfhmtg0aTV/Sh9yApdCxLbEJ3fq5KR/z2WeG5ft69NHKRhveKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIAehWlg7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJovzaOklwtj9ABNvLzSsaxZcpKhX2Ki XL34EvHGkkYb4KmnG/tHnWEw7WncTnAcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ CQ8+CAjsKwz/0yDVcTmUluzp3vslgEYc8pdFas98g7l90bPywOQB2xBQjsfbtUj7ZYyXWZzi A/PmM71DztytrHTUWia6rqfsTK1P24SMHMGYigHCwAC5rEPvb0Os/4Gdf47eIbdszE/MWiYL +yixMTmu4gusA== IronPort-HdrOrdr: A9a23:2YZZB6iv9QDQdFqWG5w2wQZY/XBQX4N23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gYsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJ7iJGofy/gzdktvfrGrCo+ O85CvI+P4DrU85S1vF5CcFHTOQiQrGpUWSkWNwykGT3PARDAhKd/apw7gpMycxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfdsRKEkjTVo+a07bWvHAUEcYZ tTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYYit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tXKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG7fIx8Z0WY9ihz3ekIhlSnfsubDcSqciFcr+Kw5/MCH8bcR/ G/fJpLHv6LFxqaJbp0 X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="74656847" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRFQTRbHZ8fIwTj0W9sdYptzkebgcfMhGBGSRhVEQBcXMQEqkjjlMowQFcy0vENqrSbPNXgBGvGgTlvrhPunIMibkq+nC5MoT9U8UDhegibpPQd9VlsZ7Hwwyzaitplb+ROi/IKvR+yMi5/E7ntLhDte/6DxAa0TLLxmNXX8LFpEJHsqo7X0T4zyT6eMtHzwcxJXHKSADEFhe6i+/JfKHeEL0Pszyo5gUrEz9bJ7B6GPVQH8vGP82Vg4qpmIogaYLWbDz60UO/GEAE0yHCGokf2mC4DZAkxc49l0bDRxohJujxPbMV+mhGEf28UNo2GXS6JV+4XG8OEfxdEkF163Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1btQ+fYTf0FYETmvwAIv7s8JzV+qrhowIJ762Rxuw0=; b=ck7RpdPcD9yvlPqpC7bC+Y2+7WqSh0eOCzFKORSH7NG9K6RVA2jMz8nl6pmEWV6II7HPu3JRYbNPLLiJCOmUFeWiv+qiIbZO9jJA1ggugfU39Lv4taBao2wvv9vp0ERIlWyCf1jYG/cV0pybj6gEOGjT/1h3HIlUtXC0fJTU8cLXHcxiI9WiFf/NiTPKMWX4QCxbDJps32nCnOL/wL9IyPiGI05DG39T4QH0lSNRvONiviTR/smX+ZakWhwtA5nem5EPbXJgO6Hyko5ejdK3DX6tFzQdn6FKfSDD7Yzh/sCJGchXezL4EVIflkYaczP8gYouA2WbTlcysflqBNat6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x1btQ+fYTf0FYETmvwAIv7s8JzV+qrhowIJ762Rxuw0=; b=TMWCuLkJ5JRT5P3Ee+8tiMI1kGqMEt/5XnQIYSD1iLQNG6Z7RKvmYut3fHvlmQitUou6coqo7ok5Mk43uq6r6BhoDjAXbgxw3ns9aOWnSNLuyziB50EGVoDYsCJ747Rp3Utav3TiAVyQUfTEGjvHF/TiXXE8b46iOmLYkx9RolI= From: Andrew Cooper To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Wei Liu Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Thread-Topic: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Thread-Index: AQHYcA9OnQ9W6lKd/EmmrY4D8odolq0vawYA Date: Wed, 25 May 2022 10:52:48 +0000 Message-ID: <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> In-Reply-To: <20220525081311.13416-2-roger.pau@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9aea7e4d-821d-4bf2-33d5-08da3e3cb583 x-ms-traffictypediagnostic: BN7PR03MB3426:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mdZLqld/+eMA41E1izC858Ue5CJP6cRjpmelFtGYd2hZty907jU/8kPXpf2fORr8BUlxc28vwe1DmTNRpkrdddKfyz0qq/nNRlMEF0Bzf0C5WV0VdlB78stUq6GxfKk2SCxXHry6GLC81a5X/nz7wrZJJNyPne4nwnStmjce2vr3rb10ixdagmgjSgvWlvbLYhocA/pL+hNgQyeHToB8VGFXSKH34K99Ws2yIhtFeIWGntm+x9KDOTAtbXWMfJ/uVxWCkJasnGFeZy/ykhpuXQgfVdzhJiyvqTqNWTHLUtVRFWZY8fQ1OJryVgaIXO+4Ac8CVfZnERI2AE35McOtJr7bW71eRWmHa2KMQIFu1OhYg5/0v2KDSENemghTjAqQ+ct/FtOOF7ljaW2mPKv4ZD4p3onfl72c8+2i+RqMUBQQGalPZWAGTLopkSL8I2dEFzayxDKSdKqBkUDpqkdRxakkfDvh9nEO+M+ve7eZsSRjjDGiI6tE4FMbWozS0gKRrMZAE90pIXm0N2oKyrAsEraF5HBr5ButI6+zBg6LLurGWgAZGa0GZBeXHNHvyy0T/Shc+5ghhjCliLPWb77Uep1FJxHvE4TPM1E1cheTgPZw6+tC2tw31t+2kdjNKaQAxUHmCfaBQDSlrPAWJxJl7lrwPEufhe74HYrCYPWRNjl4hc1JePmScPcH1W4HXouOQDLSWAJiJ2ZEkZJj0X/ljcDUToWQMSaRJjEfVdfJ30OQ13oBg7BEzP7ZXdloy7LifbGaHa7reBSvlbdX+fNm6Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(6506007)(6512007)(31686004)(53546011)(6486002)(38100700002)(66446008)(26005)(508600001)(36756003)(82960400001)(38070700005)(2906002)(83380400001)(64756008)(186003)(8936002)(2616005)(5660300002)(86362001)(54906003)(316002)(71200400001)(76116006)(31696002)(91956017)(66476007)(110136005)(4326008)(66946007)(8676002)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R01XR0tHRWdCa3FEWlBId2JrRVBpY1B5T1Y3WEJtcXVXbTBFWmk2S0hFb1dR?= =?utf-8?B?dERYcWYzRlFveGZKV0pSdEVCY010N3lkMXBwRFphWVBwNmRyeHFFT1puZ3VP?= =?utf-8?B?SzA4UVdCZzZjMnpwVzhkNm5SSTJ5NTZuV2ZCLzNJZ1RxMTQrSnF5ejZGL1lz?= =?utf-8?B?S1M5U2xjRyt0N1ArRU1JZFFPZHZudWFjMFhtbUVRZTZCaVNKbkozNkNhdCtk?= =?utf-8?B?eTlTYjRQY3B0YUF6WkFXWnZqZTQwOE1JaDdYUG9aRjlzMXNaOGpuMDd1Wk8r?= =?utf-8?B?bHRNUElNVmFQcHU3cFZnNDIyYUhqckxnNGs1Y21OVldXNnF6bWJwZVBnYkJT?= =?utf-8?B?WmExTk1oMW1vVDBWTGpUbEJTb2xiUU4ySkY4UUErd0xDdE1GTTRXZEZBVzEv?= =?utf-8?B?Y3gzbzFsdnNyMkpxT0ZjOFNaWDRDVUJ6Um42TTV0dlJOaWUrcjRxV3lVaFFO?= =?utf-8?B?cE9KWjh2MERrWDZmQzFHWFBYK2dmMkMvbERid3dxbjFQUC9TeHUrS0FPNUU1?= =?utf-8?B?dllJZElNbGZpZmt2NXRwenRGM1FwS0N2K0plV1dsT0pCNldOa0NCSk01MWs4?= =?utf-8?B?SGlJZjFBUjE3Q0RzNVdyK3hJSFIzRWdMS1BuVjdUNFQxcDQ0M1JKS1V6Rzl5?= =?utf-8?B?ZW5jQXlGekIvRE50V0s2dTRrRXZFTlVDekI3M1VLajlIVUNFV21jL01NcHEx?= =?utf-8?B?MEVheE1JdmppMDVYOXZFMTgzTjIyT3pVQkUyamRnK3BRc0JkbTgxNU9PR2lP?= =?utf-8?B?eFNyc05iN3FiczU1V3FQRVRrV254Wjd3OGNRSFF4eWRBeVp1SU0xMklVbm43?= =?utf-8?B?amdtWWFZeXNTUmJ3NE1Samk3OUU5dThvaGM3WFlMUCsvN01PTXRmazVISzBD?= =?utf-8?B?UE0xUGVVMmZEMnM4WjEvbjVwSUVCLzBqSjA4d3ZYVjdCbDZKK3BoQVkxVnhN?= =?utf-8?B?TUhWYW5vbVN0SXBDOTJFRmduUWYzVEg0OWVIWGlMdlV1aDJxQmFQd1lwbHFC?= =?utf-8?B?akRGenJnMTFTY2FBQ3dYajQyRjBDUVB1dmNMcmFrS2NCRmFtRWwzZHpIcVl5?= =?utf-8?B?aHdvVVlnb0w5YnhIVmNHSWoyVWE1Sk9EN0d4aFh2OU5hQ1hFTnNxSWFLN2tG?= =?utf-8?B?MDJlT2pjd0t2Q1RaL3VFNmJxV3h6RnFtNk1WanlkajJzUjBnZ1RON0V2NjUv?= =?utf-8?B?OGpmU09sZjg0ellMUTZrMUJueFJSMkRveVFES2cvOEFUNW1leTFXODNNSFAy?= =?utf-8?B?UUdKU1BpSmtWaVNXdW9jcU9zZFJNMUNvVnZnUys0Q05zcnhjOWNWcFU1UzZl?= =?utf-8?B?QlFVby92KzJDckd4YUlodEpZMW5XUkxsdmJwMHI4OVMzNGFKWEVpaUJQUGFz?= =?utf-8?B?cGVXUzhrdFZTdFhkMTRwQVowSjdjU2VIVlowczF4Qm9IUDdYOUIrbmtzOVhr?= =?utf-8?B?VjZIVW82YnovS2tHNUhNcVBSaWhNUk1raURzV3JhdDNpWURtdHpPcnVXdzI0?= =?utf-8?B?Mjd5NG1tMjV6WndMN3k1dStCQTlyMGY0Sjh6RENVbFp0ZGxVWlJVYjh6Rk05?= =?utf-8?B?Vld5RzFTMEhpZS9vR2pYR0FQeWFMdXZlM2N5RVM0RjNjQWEzOUtNTlBIbDlZ?= =?utf-8?B?UnJEK0U5b0U2R1RXMWVTanVJVzJkaE9lYzhnT2o1OWNjbE4yQXdyQzRkUE1p?= =?utf-8?B?eXdkL3BEL2ZkOFBHYUdOdWN2VzJoaUJRZGNJMkdma3pmUVNobVpkQmd0V3NQ?= =?utf-8?B?MWZqcURLSGFuY25DQklFcy9JNVNUd0tuRGl6c3ExamdmalpObkQvYkFka1pw?= =?utf-8?B?bGZTSVpzbFdnOC82dlhHL3d3dEJRUzBvaXk2WStsT0cyVHpTM2ZVOVp2Rm40?= =?utf-8?B?MDVTUVhUc3ArOTI4azJWL1dya3NKYXNidG9qeVdQL2I0QXRLZ1JDR1pSWjdx?= =?utf-8?B?VUJlc2RwbjRWTDB4T256d0RmZUl3eU05cmFBN0hWdEt0cTBIL0lSeU5iN05h?= =?utf-8?B?QzAwaTdaWVRndnlEU3FtbUZKd1hXMlE5MGRzTWNVbWlmMHhvdWpEQ1ZpelpU?= =?utf-8?B?VnJpeXRHV2xwY1VPd0FSc0xKSzhwcnI2OHNXZE9Gd2xnR3Z3Vm1jT0orbE93?= =?utf-8?B?WUVrNXFPWkZNbWhMQmt4MWR3WndjdkpucGlBSlZtV1dnNTFMc0xNQVp3ZFhS?= =?utf-8?B?ZVBadDdxSU5EV2NLZ2lOTmJCK1lMZW11RFA1eDVOVnhVTHpEbUR5N3F3Vzdn?= =?utf-8?B?WU83L2l1NnY3Uy9WN0ZsdFphZ0REMStBT253bjRzR3E0ZkhOeFFjamRVcFZK?= =?utf-8?B?RXUxSWJVY2NMVGl0ZnJuMkRUUTBCZVFoeUV0QlBTbkYvamlXbHRwYk1aYmRG?= =?utf-8?Q?cnFvkXEkZ5iuZal4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <7C12444471F2064DB1F23B591496EAAB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aea7e4d-821d-4bf2-33d5-08da3e3cb583 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 10:52:49.0112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 162Fnqt/icP9vk/LkZf1GODP5sa3LdPj7wRvkO0RB9NWI6KaSXqZH+6x4Sbezgl6diREPPzyFAOYS28fyS9Qme7ww/sOxRJW9ojJ7NMLZ40= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3426 T24gMjUvMDUvMjAyMiAwOToxMywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBSZW5hbWUgdGhl IGZsYWcgdG8gYmV0dGVyIG5vdGUgdGhhdCBpdCdzIG5vdCBhY3R1YWxseSBmb3JjaW5nIGFueSBJ UElzDQo+IHRvIGJlIGlzc3VlZCBpZiBub25lIGlzIHJlcXVpcmVkLCBidXQgbWVyZWx5IGF2b2lk aW5nIHRoZSB1c2FnZSBvZiBUTEINCj4gZmx1c2ggYXNzaXN0YW5jZSAod2hpY2ggaXRzZWxmIGNh biBhdm9pZCB0aGUgc2VuZGluZyBvZiBJUElzIHRvIHJlbW90ZQ0KPiBwcm9jZXNzb3JzKS4NCj4N Cj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UgZXhwZWN0ZWQuDQo+DQo+IFJlcXVlc3RlZC1ieTogSmFu IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gLS0tDQo+IENoYW5nZXMgc2luY2UgdjI6 DQo+ICAtIE5ldyBpbiB0aGlzIHZlcnNpb24uDQoNCjoowqAgVGhpcyBuZWVkcyByZXZlcnRpbmcu DQoNCkl0IGlzIHNwZWNpZmljIHRvIElQSXMsIGJlY2F1c2Ugb2Ygb3VyIGN1cnJlbnQgY2hvaWNl IG9mIGFsZ29yaXRobSBmb3INCmZyZWVpbmcgcGFnZXRhYmxlcy4NCg0KIm5vIGFzc2lzdCIgZXhj bHVkZXMgaXBpLWhlbHBlciBoeXBlcmNhbGxzIHdoaWNoIGludm9rZQ0KSU5WQUxJREFURV9UTEJf VkVDVE9SLsKgIFN1Y2ggaHlwZXJjYWxscyBkbyBleGlzdCBhbmQgc3BlY2lmaWNhbGx5IHdvdWxk DQpiZSBpbXByb3ZlbWVudCB0aGF0IHdlIG91Z2h0IHRvIHVzZS4NCg0KRnVydGhlcm1vcmUsIHdl IGRvIHdhbnQgdG8gd29yayBhcm91bmQgdGhlIGxpbWl0YXRpb24gdGhhdCBjcmVhdGVkDQpGTFVT SF9GT1JDRV9JUEksIGJlY2F1c2Ugd2UgYWJzb2x1dGVseSBkbyB3YW50IHRvIGJlIGFibGUgdG8g dXNlDQpoeXBlcmNhbGxzL3JlbW90ZSBUTEIgZmx1c2hpbmcgY2FwYWJpbGl0aWVzIHdoZW4gYXZh aWxhYmxlLg0KDQpJIGFjY2VwdCB0aGF0IEZPUkNFX0lQSSBwZXJoYXBzIGlzbid0IGEgcGVyZmVj dCBuYW1lLCBidXQgaXQncyBhIHdob2xlDQpsb3QgbGVzcyBiYWQgdGhhbiBOT19BU1NJU1QuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed May 25 10:55:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 10:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337117.561624 (Exim 4.92) (envelope-from ) id 1ntogE-0005Ht-Lg; Wed, 25 May 2022 10:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337117.561624; Wed, 25 May 2022 10:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntogE-0005Hm-IV; Wed, 25 May 2022 10:55:54 +0000 Received: by outflank-mailman (input) for mailman id 337117; Wed, 25 May 2022 10:55:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntogD-0005Hg-BA for xen-devel@lists.xenproject.org; Wed, 25 May 2022 10:55:53 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e477cb4-dc19-11ec-837f-e5687231ffcc; Wed, 25 May 2022 12:55:52 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C53631F94C; Wed, 25 May 2022 10:55:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9818F13ADF; Wed, 25 May 2022 10:55:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dO6sIzcLjmKefgAAMHmgww (envelope-from ); Wed, 25 May 2022 10:55:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e477cb4-dc19-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653476151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ckeYyo67212NXGIzF5GamiYsJLXQg8ru+tyMx+nMhEo=; b=A4QjohEWkQQhIsF2iQsc1aG/DEI8folCL/+4Zp8e9PT3WxN5QSaxLczTAY760earxK3elZ /g9MzYBC9Yy1w4wK9HmbvjJ5yZP+CaBElyEcBkgsIkViiPMp37DKlVF+Rsr94E1bJLTXkg C9jalbtm8BqF2vH4gq/uc2BR0IHb1yA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstore: fix event sending in introduce_domain() Date: Wed, 25 May 2022 12:55:49 +0200 Message-Id: <20220525105549.30184-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") introduced a potential NULL dereference in case of Xenstore live update. Fix that by adding an appropriate check. Coverity-Id: 1504572 Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_domain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index de88bf2a68..ead4c237d2 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -493,9 +493,11 @@ static struct domain *introduce_domain(const void *ctx, /* Now domain belongs to its connection. */ talloc_steal(domain->conn, domain); - /* Notify the domain that xenstore is available */ - interface->connection = XENSTORE_CONNECTED; - xenevtchn_notify(xce_handle, domain->port); + if (!restore) { + /* Notify the domain that xenstore is available */ + interface->connection = XENSTORE_CONNECTED; + xenevtchn_notify(xce_handle, domain->port); + } if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL, -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed May 25 10:58:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 10:58:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337125.561635 (Exim 4.92) (envelope-from ) id 1ntoii-0005vP-4R; Wed, 25 May 2022 10:58:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337125.561635; Wed, 25 May 2022 10:58:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoii-0005vI-1T; Wed, 25 May 2022 10:58:28 +0000 Received: by outflank-mailman (input) for mailman id 337125; Wed, 25 May 2022 10:58:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoig-0005v6-Cx for xen-devel@lists.xenproject.org; Wed, 25 May 2022 10:58:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoif-0006jz-L4; Wed, 25 May 2022 10:58:25 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.21.168]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntoif-0006aY-Ey; Wed, 25 May 2022 10:58:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wb21tvMwamgQVXjHLuXLsmVqCbuV0KapQD8Yu8rT6Tk=; b=V0MyhWuRGKVFmJWhQRy7KfoiZC TmIk6ZArrAsxAg7Iz6Ta7mXx/V83FnxqdLxKHOrLP1TflaW3+wVswkY0jLQfCGGySrJ+aKYy+Sw8W zxq6Z3BY9isTVhkfsHqoJcHbDN5XL3TGv26ixh47ThOFnW1e7qtE+oA8F/TtenOtBWdU=; Message-ID: <6f333841-17e3-c9ac-580a-fc89f1741596@xen.org> Date: Wed, 25 May 2022 11:58:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> From: Julien Grall In-Reply-To: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 25/05/2022 10:21, Jan Beulich wrote: > c49ee0329ff3 ("SUPPORT.md: limit security support for hosts with very > much memory"), as a result of XSA-385, restricted security support to > 8 TiB of host memory. While subsequently further restricted for Arm, > extend this to 12 TiB on x86, putting in place a guest restriction to > 8 TiB (or yet less for Arm) in exchange. > > A 12 TiB x86 host was certified successfully for use with Xen 4.14 as > per https://www.suse.com/nbswebapp/yesBulletin.jsp?bulletinNumber=150753. > This in particular included running as many guests (2 TiB each) as > possible in parallel, to actually prove that all the memory can be used > like this. It may be relevant to note that the Optane memory there was > used in memory-only mode, with DRAM acting as cache. > > Signed-off-by: Jan Beulich > --- > v2: Rebase over new host limits for Arm. Refine new guest values for > Arm. > > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra > > ### Physical Memory > > - Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. > + Status, x86: Supported up to 12 TiB. Hosts with more memory are supported, but not security supported. > Status, Arm32: Supported up to 12 GiB > Status, Arm64: Supported up to 2 TiB > > @@ -121,6 +121,17 @@ ARM only has one guest type at the momen > > Status: Supported > > +## Guest Limits > + > +### Memory > + > + Status, x86: Supported up to 8 TiB > + Status, Arm64: Supported up to 1 TiB > + Status, Arm32: Supported up to 32 GiB IIRC, the max the architecture would allow us is 16 Gib. Here we are limited with how much physical memory is supported by Xen. So this wants to be 12 GiB. > + > +Guests with more memory, but less than 16 TiB, are supported, > +but not security supported. On Arm32, we definitely can't support up to 16 TiB. On Arm64, we would need some work to support it. So I would move this sentence in the "Status, x86" section. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 10:59:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 10:59:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337133.561646 (Exim 4.92) (envelope-from ) id 1ntojb-0006TT-Fi; Wed, 25 May 2022 10:59:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337133.561646; Wed, 25 May 2022 10:59:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntojb-0006TM-C5; Wed, 25 May 2022 10:59:23 +0000 Received: by outflank-mailman (input) for mailman id 337133; Wed, 25 May 2022 10:59:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoja-0006T4-9L for xen-devel@lists.xenproject.org; Wed, 25 May 2022 10:59:22 +0000 Received: from ppsw-40.csi.cam.ac.uk (ppsw-40.csi.cam.ac.uk [131.111.8.140]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9d0e379-dc19-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 12:59:20 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44360) by ppsw-40.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1ntojS-000hX1-jR (Exim 4.95) (return-path ); Wed, 25 May 2022 11:59:14 +0100 Received: from [10.80.3.190] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CC9E21FB2E; Wed, 25 May 2022 11:59:13 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9d0e379-dc19-11ec-bd2c-47488cf2e6aa X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <21392cc6-55b6-647e-08eb-c818d6229603@srcf.net> Date: Wed, 25 May 2022 11:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] tools/xenstore: fix event sending in introduce_domain() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Julien Grall , Anthony PERARD , Luca Miccio , Stefano Stabellini References: <20220525105549.30184-1-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20220525105549.30184-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/05/2022 11:55, Juergen Gross wrote: > Commit fc2b57c9af46 ("xenstored: send an evtchn notification on > introduce_domain") introduced a potential NULL dereference in case of > Xenstore live update. > > Fix that by adding an appropriate check. > > Coverity-Id: 1504572 > Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") > Signed-off-by: Juergen Gross Reviewed-by: Andrew Cooper seeing as I've just looked at the Coverity report too. CC'ing the others involved in the original patch just so they're aware it was broken. ~Andrew > --- > tools/xenstore/xenstored_domain.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index de88bf2a68..ead4c237d2 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -493,9 +493,11 @@ static struct domain *introduce_domain(const void *ctx, > /* Now domain belongs to its connection. */ > talloc_steal(domain->conn, domain); > > - /* Notify the domain that xenstore is available */ > - interface->connection = XENSTORE_CONNECTED; > - xenevtchn_notify(xce_handle, domain->port); > + if (!restore) { > + /* Notify the domain that xenstore is available */ > + interface->connection = XENSTORE_CONNECTED; > + xenevtchn_notify(xce_handle, domain->port); > + } > > if (!is_master_domain && !restore) > fire_watches(NULL, ctx, "@introduceDomain", NULL, From xen-devel-bounces@lists.xenproject.org Wed May 25 11:12:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337143.561661 (Exim 4.92) (envelope-from ) id 1ntovp-0000P6-Lw; Wed, 25 May 2022 11:12:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337143.561661; Wed, 25 May 2022 11:12:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntovp-0000Oz-HK; Wed, 25 May 2022 11:12:01 +0000 Received: by outflank-mailman (input) for mailman id 337143; Wed, 25 May 2022 11:12:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntovp-0000Ot-4t for xen-devel@lists.xenproject.org; Wed, 25 May 2022 11:12:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ef2d81b-dc1b-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 13:11:59 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-5llw674mNH-5WLkeuizahw-1; Wed, 25 May 2022 13:11:56 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 11:11:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 11:11:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ef2d81b-dc1b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653477119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NhJ/hkYyGjiLhb/bgpOLzeT3CNP2lxqvZcaKsWBYCmQ=; b=Zhw45anblBuv43IU+smBMPfvj+YOny3b809cc7R6CykoAoDif2z68lJ7L49hlUg2jtMTYJ Rr782/3AQUucdcd7cBZyzQTQYa6Twfv239SpnJ0LlTiPbBvgTrrGS05VmImd0uio4gI497 Gg2BKEC6ZbIDlKBJVC8F4Ky/6DhAZss= X-MC-Unique: 5llw674mNH-5WLkeuizahw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Msw8hEt/TckhbKF2BmBhCZtQKmyhbVQQB5dYEheCk845rziJ0e6gUXr/GlBEE3z3c4rupRmFIz3xkEGBMR02/+2ClANhHacGj+HiKbMWRzuej2tWzMw2m3Q3OGJfeAZeyWFHz4tc+Y1OdECCfblVvfwgrJx7rGnuVznZNJT0450IDyhH+wE0pP0HdkN5Hnp2e9JSoPkmUu4AoL5OS7NDNgRSpVCwzyEEL1TrMm5O/RLV2C8fSBZWSWiesrehkzJKWnGpaHxIdT1zE2AuT/lSLo2Vyyr20WlEp8y+hat1qMy34cKKWoUcuoQEIW0tWtTbDpUAiGciDoWIkmJeiUmqFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NhJ/hkYyGjiLhb/bgpOLzeT3CNP2lxqvZcaKsWBYCmQ=; b=nuxb6ds3DT8XcdZ5mxMsORRoTrXFLnD3GTFG2v9TElaWeMOeYD6wYI2ZVWFd3stGKfb3TAZGrglMMzrpVNnunH9QZnQssc2Wnd3CYM1U/PLivSGynlDN33GX/a+G3Bwk9gu3wv8pRl8uo3lHXuSkG6K1JRCQ3YFlbYx3psqVxeY0gIsw0Aqd3eeQoak3FX6VHqwwkDoLhAVYH8XGVYd8zIV7m6fUgeckZvlv2sj+6Nu54E/pP+oZplmBIXaOcJWOgAh9sGtduOS8Zg74LOvFMm+QimyRGy6CuTjsgDVa6KaB0Yzl6bQEmv6YzaHNstkKoOCTeNJBjG6FgBq5yoaeIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ad659cd-826a-4393-777b-f4103d02af77@suse.com> Date: Wed, 25 May 2022 13:11:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> <6f333841-17e3-c9ac-580a-fc89f1741596@xen.org> From: Jan Beulich In-Reply-To: <6f333841-17e3-c9ac-580a-fc89f1741596@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0081.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b065c1c0-c8ba-4490-1e4b-08da3e3f6040 X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nORVIgqOm/sq852/Amk7rTyHK728Bexdq1aoqGGFBDNvL6/8J7gipzQ9Z1jBpFEmgLFwymJqtH2NCeP3axDTvHl1cEtZnfGZ3bQqDUr2cZwpPP9T4yjW4kb6RYch5RsolQYtEKlr23JDlWnImyixoJIN71sKn/nt00vFa4noZx0Ct/9KuzupWIntCfETzVybcCPCy8zCavPIe16P4VqtaQJFSif226zgqxBOf6YlAWdhdpXRIzewn5nJ55If+DenmR3sHQ3LhRYIGq0ik6QHgnjNsAH6NHcBSOGdiGy4kXSjAkmjklo7z4BojhtPgpr4IaAUaAQNZmgyzqOq/sXac7nurmLgDSU2G5ykCijKIWe6n3yd6WwBDb/KJL5yKfXWVyg0DwZKgmBDXDD4iaGbT7/hoYFra2dscLOPzJX2xx4uOmjGoX1Ta4p0Wz/YNryIrJRBkxbdnWUVM17TyqFQoZAVGkC7XiuWq13Kkcl2sBLNGReIr7XbTwsOuP4VEU+bSRuPdmnLxV0L2tkxYkajnWTSjxu03Zpnsjjt+WqvO+UAtlzAknzpVl7LlJSalBPSQJ6q5eu57WESXetYt8jxGVRu5nm1ADbP2NNkahafo1Mdv+z/TpyARPt80CgLNUdhUOKYbQhxim9d/CE53KznAdeSHZwTIrAj6f9TjhIs+Bkjc9h4lgtSW7rzOQBKrjUdL5ihnSLZ2OWMhBf036fdlJQCW3wG2nY1cRahp/6+WtA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(15650500001)(6486002)(2906002)(6506007)(316002)(8936002)(31686004)(86362001)(4326008)(66556008)(53546011)(8676002)(66946007)(26005)(508600001)(6512007)(5660300002)(66476007)(54906003)(2616005)(6916009)(38100700002)(83380400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm9xcTV1SER3UThiOERqSm0wQTUrVkYvY0F6K1VHODYyS2RMVEZFYjJ4bEUz?= =?utf-8?B?Q2U3WndQam01bFdrbkNUTlRkY3BKZUwzTUZGTjRTY2VVT1d5M1BxbDNPbHpT?= =?utf-8?B?M2JxRnhiN1VGREhaemNlcGM3WFc4N3RuVjVXeno3OGVVenZYVEg2WSt0R0Qv?= =?utf-8?B?cklsL21BdTZTa0JoSnc3VkFQUDh4L0cxZ1VuM2NMVUMxRlJUK2JBMVZQOTdC?= =?utf-8?B?d3lCRjR3UnVkNFdUNkZ2U2N4NThuKytNOXI5bEpPbHlUd3VSUGI3Y2htWjc2?= =?utf-8?B?dXlLYU1mK2pRaEt1V25DbC85eFFWY0o0VG1mTzVQR2tiRTdveUFHQzhRUU5P?= =?utf-8?B?dzJVR3Y1bk8ySFVVZlB0a1NCdVlyY1l5eVJGcTNLc3E2T01mY3NTZTZhMEV5?= =?utf-8?B?aXQrd0d1L25wZThKcW9aenZDaHUyaUhyNUdoMkdRZHdlTUF1eWtrd2lLWVk1?= =?utf-8?B?ZHFkL2MwQnVWQTY4dWNtWUZWYXhnN0FiaEd6S0RnZG50eFdNUjkvY3lpRG9O?= =?utf-8?B?dGVkYkd6cnMrTGk3KzI3TTlFZjVRMk9oem9tcmFWdFh0OTdTQWQzLzFZd1Rq?= =?utf-8?B?TFZaU0RHZ2J3L3FzcEZxOHFnN3ZTaTdYOHZKR1g2QjB0TU9oYTRZemNBVUlh?= =?utf-8?B?elhuNkNmbld5L1hmMVQrekFxYlMxTWtmVjAydjQ4RXFSUDEzWnBxMGdIb2k0?= =?utf-8?B?TEprc3Q1QWhmUXRlcHZwU3gweGc3d3A4a0lBYWJjNlhxelowYmY5akJUZDkx?= =?utf-8?B?a0RsUFJYT2hOMkxuWERRVUNaRDFCdkYrdDhBUjZMeTNTelc3OFRQb0FwN0dx?= =?utf-8?B?TTNzSXd4enA1U0pyeFkrSUNlakxRYzRrbGNnQzY0Q0ZNRlVwTkNISmgxaWlN?= =?utf-8?B?Ujc5c3JUd1hacVBjb1M4bGNVUHpURWl4MlE0dHhjUStiREJVS3V1NnF4eitn?= =?utf-8?B?SHMyWWtVZ1JDWUJaUUZJYmFuVEdURFJURTQzTVh4cllKV0xaVDZRdzE5RWY4?= =?utf-8?B?SlMyanp2TDhHN3laaGhJWTdFbEZ2SHBlU3UwQW9PeFFGeWNDM2M3U3BXaDFU?= =?utf-8?B?ZlNMbjR4OGZ5d3B2b2VMbzhsajNEWUpiRm5RakV0cGRXL2kzeHZOSW05WTlU?= =?utf-8?B?dktCellOS0VWQTlwUXM0bnhwU3prLzY2ZURseUtZV0xmVlBXNThnZlRYRFlN?= =?utf-8?B?OGhYVjVWY3NsbkMxdjU4am9CbGZRRlhNVVBDUUc2RzBlUjRMVUxHT243Zk12?= =?utf-8?B?NE9zTkdYRzJIUVIwc3p2Z0RBSExtVVl4WGNQOEtnUitiTXpWOC9wMzFId3lD?= =?utf-8?B?ZDB5enhsVm0rZXVqMDVDWEp0cmdmZUd0ais2L0hhaFJqWEJvSU40SmFTQzdm?= =?utf-8?B?a3JHZWYyQWNmTC91TlBoRFFDNmFFUDIvUUNiaDJYSmRRMkVjSC8yenk1N2dM?= =?utf-8?B?M1VLNVMxdjgvTjdqVENpcTJjNlZGR3ZVYVBBend0NmpnOU0wdHNnNm8vQUg3?= =?utf-8?B?OTgrbmFIWW93SkxRQ2dLaFRzOEE3TmRFL3ZWdmJsSHJTZ3pBVlAzSHdIbWxT?= =?utf-8?B?dmZRNDcxd0Y5bUY3M29EamtXYmphUzZKWG9ZRWl0THAwd3c2aTNsNko2YmFE?= =?utf-8?B?SkM2SEZKVXBqZE9JdTl1K2xvT0ZjK0NLcVBpTCswbHpYSnVQU2VmdFlLZ2NN?= =?utf-8?B?Um9LZFArRzZQaGdPdGpiUHhYNVMycU9qLzVKUGVDeGZNMjNOdTdOZGF3eDIx?= =?utf-8?B?eUVRUUxNYWlpMFlJQzJYSUM4V1hPd0dwVHRweW1ieUQ4ZFZJQTZScnFaQ3VE?= =?utf-8?B?NkVVa3BPdUJ3c05sajJuS1YyM2hEQnRVNm44b3Z6Z3N0bHdYSHZ0dFJOQmNE?= =?utf-8?B?c2xRbElYQ2h0Z1pOUmQ1d01SSFptTEM3UTdlb1J2VEgvdVFLMEFJTnV4em41?= =?utf-8?B?UVZPNG1uZWxCR0NhV2RxRHR6eE9aUVFEcFlWS0VURkZJb1lPTlNiYjMrL0cy?= =?utf-8?B?ZjIwd3BEN0psSDU2bWNIZ2luUG83dFh3eVlHMWJkai80VXhVeG1CTHFXSUla?= =?utf-8?B?TkxuM2tMbSsxTmMvR3psaFRmeHBvcnd0amlzRld5SWljMkc4dHZpRWRMRTFa?= =?utf-8?B?eXZjTmk5Q1hoMkg3YXFzbllJYWRjT3dRVnI1NXlQb1FtTnFMMjR4U2NPODlq?= =?utf-8?B?dUYxQlBaU0JibW8yYVo5SG1OeDZqWDVucVBycTNVWWUrMTdXMlJFc1ZIUHRL?= =?utf-8?B?dUtpWGhNR3duN3hJNnhjMHdXWVFWV3o1WFBnUnZRaHhiVk0rbW1hSHhISi9t?= =?utf-8?B?YVpVMnpqTkVJQ01wQzEvTGFHSnRQeERRM1FjdU9LeDNFNmVXTGsvUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b065c1c0-c8ba-4490-1e4b-08da3e3f6040 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 11:11:54.6741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DAm/O6Lf6W+Yd77yGjkZ/QyYdAgmZDN4SO4Y+UbPsRubCAqGe/1ldvGTQhrQtcQgORUlvrbxq/S2HuXQnNNZDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 On 25.05.2022 12:58, Julien Grall wrote: > On 25/05/2022 10:21, Jan Beulich wrote: >> --- a/SUPPORT.md >> +++ b/SUPPORT.md >> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra >> >> ### Physical Memory >> >> - Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. >> + Status, x86: Supported up to 12 TiB. Hosts with more memory are supported, but not security supported. >> Status, Arm32: Supported up to 12 GiB >> Status, Arm64: Supported up to 2 TiB >> >> @@ -121,6 +121,17 @@ ARM only has one guest type at the momen >> >> Status: Supported >> >> +## Guest Limits >> + >> +### Memory >> + >> + Status, x86: Supported up to 8 TiB >> + Status, Arm64: Supported up to 1 TiB >> + Status, Arm32: Supported up to 32 GiB > > IIRC, the max the architecture would allow us is 16 Gib. Here we are > limited with how much physical memory is supported by Xen. So this wants > to be 12 GiB. Hmm, while I don't know where I took the 32 from, it was you who suggested (in reply to v1) I put 16 here. Though yes, with the host limit now set to just 12, putting more here would be odd. I didn't cross check the numbers, I'll admit. >> + >> +Guests with more memory, but less than 16 TiB, are supported, >> +but not security supported. > > On Arm32, we definitely can't support up to 16 TiB. On Arm64, we would > need some work to support it. So I would move this sentence in the > "Status, x86" section. Sure, I can do that. Would have been nice if you had said so right on v1. As to Arm64 though - the host limit is 2 TiB. Going beyond that being impossible (without becoming at least unsupported), is the uniform upper bound of 16 TiB really a problem here (IOW do guests really only function up to 1 TiB)? For Arm32 it would be even less of an issue, as hosts with more than 12 GiB are unsupported. (I'm trying to avoid moving the line up not the least because it'll be even more of a line length violation than what was necessary to accept for the host limits.) Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 11:14:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337152.561672 (Exim 4.92) (envelope-from ) id 1ntoyC-00014O-7x; Wed, 25 May 2022 11:14:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337152.561672; Wed, 25 May 2022 11:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoyC-00014H-4W; Wed, 25 May 2022 11:14:28 +0000 Received: by outflank-mailman (input) for mailman id 337152; Wed, 25 May 2022 11:14:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoyB-00014B-ER for xen-devel@lists.xenproject.org; Wed, 25 May 2022 11:14:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoy8-00073o-Qa; Wed, 25 May 2022 11:14:24 +0000 Received: from 54-240-197-238.amazon.com ([54.240.197.238] helo=[192.168.21.168]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntoy8-0007lJ-KK; Wed, 25 May 2022 11:14:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ibyxt/qh4JAYU6oqiQUUqcfgl9La7uGb3Fo1HqRisRk=; b=KPTAx0SoG8CJk2qwA22VVjEk6C bXzJduLp/TYyCROdnb2W6MeMCN4SRhwKhnP4sc0EY1o0ne8z8dqTfK4fDuBuiDXkklkuLaYLO2/W0 LVYbSNoTrWjTxioGAheBq1i5pbaezPoKRscimSQV4TRchi79OtVzMYcMnA5rhpWstgFs=; Message-ID: <34e4bba1-688d-effe-e648-c4ab9439fd1f@xen.org> Date: Wed, 25 May 2022 12:14:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] tools/xenstore: fix event sending in introduce_domain() To: Andrew Cooper , Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , Luca Miccio , Stefano Stabellini References: <20220525105549.30184-1-jgross@suse.com> <21392cc6-55b6-647e-08eb-c818d6229603@srcf.net> From: Julien Grall In-Reply-To: <21392cc6-55b6-647e-08eb-c818d6229603@srcf.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 25/05/2022 11:59, Andrew Cooper wrote: > On 25/05/2022 11:55, Juergen Gross wrote: >> Commit fc2b57c9af46 ("xenstored: send an evtchn notification on >> introduce_domain") introduced a potential NULL dereference in case of >> Xenstore live update. >> >> Fix that by adding an appropriate check. >> >> Coverity-Id: 1504572 >> Fixes: fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") >> Signed-off-by: Juergen Gross Committed. > > Reviewed-by: Andrew Cooper seeing as I've b4 will end up to pick "seeing as I've": 42sh> b4 am 21392cc6-55b6-647e-08eb-c818d6229603@srcf.net Looking up https://lore.kernel.org/r/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net Grabbing thread from lore.kernel.org/all/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net/t.mbox.gz Analyzing 2 messages in the thread Checking attestation on all messages, may take a moment... --- ✓ [PATCH] tools/xenstore: fix event sending in introduce_domain() + Reviewed-by: Andrew Cooper seeing as I've --- ✓ Signed: DKIM/suse.com --- Total patches: 1 --- Link: https://lore.kernel.org/r/20220525105549.30184-1-jgross@suse.com Base: applies clean to current tree git am ./20220525_jgross_tools_xenstore_fix_event_sending_in_introduce_domain.mbx I don't think this is fixable in b4 because we allow to have additional information after the tag (e.g. # arm). So would you be able to avoid adding words after the tags that are not meant to committed? This would reduce the amount of manual work when committing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 11:14:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:14:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337153.561683 (Exim 4.92) (envelope-from ) id 1ntoyE-0001Kf-Fa; Wed, 25 May 2022 11:14:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337153.561683; Wed, 25 May 2022 11:14:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoyE-0001KW-Ca; Wed, 25 May 2022 11:14:30 +0000 Received: by outflank-mailman (input) for mailman id 337153; Wed, 25 May 2022 11:14:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntoyD-00014b-34 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 11:14:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d732e111-dc1b-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 13:14:27 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-aGUgnSNAPNyKduO_T0bkNg-1; Wed, 25 May 2022 13:14:23 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 11:14:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 11:14:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d732e111-dc1b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653477267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n6DK+tzO8rP86G/geBqHgX9OpuwxJNAe5Nnc00egIcA=; b=UN1m+knTOlR+e2x/2+fB9hIilqdTLljHAWfVpLNnL0wCv/542pou3+r+NKJM90q6BUJYJ9 2BLpNTXllVLtg2snbJJ1utbM1FSUsyrIm3ZBA1/udtduX82AYjFUPGAxZhwYpSGIz4tVIn heeZZFXjiDStszcQ3LDt3ifzfbIm0/w= X-MC-Unique: aGUgnSNAPNyKduO_T0bkNg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYlD14nYrGP7zYs8h+RtNgTtR4BoBOLwxt6L65eAFAshXwVkM/CnFq/CQjMUByoZcmT6mSBmZpwT/7rsULlQAPYnyfLScwHCJeUTY2u7jJOC2Ew3X0iahcjIQ5k/c+YymiFIXPjT9Fvwmx3KNHwqJ4+WLHo5nGy9imfni8GS/4aBAT8OdzCLQjxoGYLwJQEHFVEcE5Q84k0kzwszslePJ4qHeF9AFGGWfXjThvDURog3OKg3wCfPA40MTt/+v1X8i9WElsujQqJD+7sElsXHWaNEfnleWfxqKw4zzFLdEiSzRXC0aPKtc4aFd5D/QxT3/Y54Ohimt3vRi6/WFzw8Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ynjWuKvzvrgYqBsbeVJslEQHd2T5p+jjmq3xYWfbf0=; b=mTTiPHKnAa9BRDBbqrGTn/pn13kadYmhXx13p3t2FUkkTJWh/xb0H1Xwx+J56QhyPnP7AqUv9a8ylm4QU7nJrYDDHBymQSFfkEKRCGh1c1IzHUbfYKDtCCpwienSywrtVBsgtQLKUilxWNLDUYaQ+3QLaE+mmZ8hfWMQ1cEWPXT4+RoLdXF0xmxYnOXwao3HWh3rtpS9oFndqTxxyzi9DF8JMaeGfSr8bdOSmRYYLPnLZkFoB2zNlAAKk3+HQQdluouGBQjgFE6HQB8AxH3FlfYgLpjV+yxR/WCxQOY00MfHz+IytOEpMYWUs/QmLeXGniAYht5YBCYzLpEiM5OLwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 13:14:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Content-Language: en-US To: Andrew Cooper CC: Wei Liu , "xen-devel@lists.xenproject.org" , Roger Pau Monne References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> From: Jan Beulich In-Reply-To: <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM7PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:20b:100::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0962ce5a-f6fa-4765-65a9-08da3e3fb85b X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /xKeqau5KvYMlha8MjQYecqtPjoqPOGaY8dcW+P7sKEUFu1JtIz8eKhQdoWqGAjWzmViJYIyq/335V7hjVpNHBiJJESclegHcJhdBVL1FNNlgtZB3bRyTvnQ8Znil+eLxi0LHNYzrX/N3hX5Zh91iq4NEWDkpm6MRWY29EgW5syhynlsTl6KHwgyV0oLDuAXxexQ7pCwUkLe05cp2Ejd0J8cLhRbv7P0SHkujZ+5PPIfPdj9tylMEp/2FK/RpI81SqaVkcDCMP/MKIlkXMR9UpQYSdhaJv0uvidV+gdltjOLm3TRp7isMMn7rfkh9ABdMdMwrhzhktRYmqwb6paoWvc8pkjBdp2odKQFFISVfNlujFvKUunUbHwlhH3Fyph7kFgNfYNtlnRNUffk73sBsf1LlRtexvrtRg+gWjAdMVUudYu3IrAUrqT276r35vRSmMZM7bEQTaUDhlu/s2NtwyqAwrZ5U6EP8ZdN25VCxAkfGcR/6ATYm3YzahSR2fdFQfAGRnnx9sShQmE0PvlGAHAF2O8lroIlAxyQPL5zkuVaQ8WHZwZVTSmvHs4tdhn8pp4JFLf3uV82TakC6a3W2k3ARaXladOONvpogTfccRTEochOkZJwOoOyKZfnloTxPVp11B58VrueG3t6rJ7qOcRZ3TcHyqcaxq5vnNfklszOyNgXKzNQPWGXFoXmrmmBSv7ofpoA6JUY1ruH/OjJ65Cey8Ir8vKqQoGbaWEfZik= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(36756003)(6486002)(2906002)(6506007)(316002)(8936002)(31686004)(86362001)(4326008)(66556008)(53546011)(8676002)(66946007)(26005)(508600001)(6512007)(5660300002)(66476007)(54906003)(2616005)(6916009)(38100700002)(83380400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q7BfXRuwVvBufZ0Ch5qmqDAHEJgDdEaZ7v1D6Lpl/gGYWVxxpmE4iLqL/aTr?= =?us-ascii?Q?BX0W18ebLtIMtWqS1cR2ETHWEY0VTeJdsf08G01+hWH6PDOhYKcFX7Eb/Dq+?= =?us-ascii?Q?jX0ELNyOOVgdj5cFr/ANvHETaFLxUyTKMrH/OgjBBrReO8BiP9b5Z1zfPC3U?= =?us-ascii?Q?UQkgg0UZ7pPt122S8XrOC/yc478rUlpp/a3ERHw+l74xcUP+1ioz4L+ZcvA/?= =?us-ascii?Q?tQZ8RiCcfpJlAOAyWf47ky/8lZYUcuvU3bXbned8RHgCW8dAeGjd0eISi7fh?= =?us-ascii?Q?CT+g2bc6w9F8Z8r/6pbpnoL73IelBbL4TvZI5zPeOW3dWjhlwJ7y+o63NAZk?= =?us-ascii?Q?pX0WB5sMwL92wQFE6DqHh9c/c79BgHB7KoMUcJuG2tppVuhTX7rz20Pa/wVh?= =?us-ascii?Q?Xf+bIjpiZcaInZeNJhx1ABwzZycgQo2HCaoO8YEAqvgpsg+Cjw3BSnvG8A6q?= =?us-ascii?Q?oKtSGI7cmM1A/urSHtpD4uPb/rIq+tE+5wdQq0dU5DjGUuHl44Ug+oXo/vlf?= =?us-ascii?Q?ZN3y/odLdT0d2d7iesEoaQdY4KhCvEg+IXm1WKeQdPsX4NrxLI58dIgaHjJJ?= =?us-ascii?Q?iFgDLQqBkWkD8SalVvrYa8vF0Rg5y8cH/uQk4xgjGDeRzLV02Ab5pMsNiByI?= =?us-ascii?Q?dpJAmBb/tkbiZClMffA17ZZMSw3Bl/WE2do/NO8hwx4mdSvmOF6nh1kJCHSn?= =?us-ascii?Q?AIyQ1UYfWLXbKRz2btqFOsUZOf9ImFq1NfapxfUGPguFfQ8U/SYwQ2L5IruV?= =?us-ascii?Q?Y71U8VkV2ypcGJG7m4Z/NfWCII8W2HX/qI5skzxDtHeVgCrq1XHqQ+rLUokd?= =?us-ascii?Q?q4c2Am9bBBLKYVlWRCc3osngPJfktCXgetOi8ckGy0F9APzbKdtIBlhMbsi6?= =?us-ascii?Q?DJ3IzOc9V8cdTVx0YYTeZA1c3luQ9ke5w1nSn1zytR/oIDMChrO61LxqkyA3?= =?us-ascii?Q?aEWt37w/znHvLGGlfWqCuaJ58DZKRyGXySnYIqd8thNkSGrAYE5kazBh8PhY?= =?us-ascii?Q?ShLIn1gAIyi1ZErHyLKHPf30+uwNgMeniIgcfw5p0FqUywLyO5jDkNUf1YlR?= =?us-ascii?Q?h/UkqNrrylyBUvdI4qLTmghit5ccbdLYpd0HV0NNpyJuPoTpNOJQ8kNUWVxJ?= =?us-ascii?Q?MffpeTQ99Zpj3heZqjlhb/1EFGq065VzvU2qJU4PQFBUOwzHwoRyOUncVYIL?= =?us-ascii?Q?YozoOFYXZ3FiScDKCQ+UOkDTv9vcLc5qLSTzR90gyQvCzHgS5BLvhG+VUh6V?= =?us-ascii?Q?Jgtri/F3qwKeIbbsOIbbjq7V6PW20qxJSlXHLZsVzO3b4VU6UuclVO0Uzoj5?= =?us-ascii?Q?GLUuIBMYrIkN68qLxBHRoYbvkn51X2KMyUyKP40N2iXzSasVwVYEgX0LoU+a?= =?us-ascii?Q?grgfusd28JXSirATWnhGWZGsxZevLB51gf7mTWpXdx7nqOA4A/PFBiW+l/rP?= =?us-ascii?Q?dJYFalL/ajSsyO4bjtt/CyQYtpAZoBXLw1IMlTR9OjsPUF0OZRuWuFctzRnU?= =?us-ascii?Q?tDwM709RzEuBOINbG04waxxO7q9zpIUnqtoxDVqJvZfh+PUfd4J9C7XUV1bZ?= =?us-ascii?Q?ucD6vqd8W8jwU0jw35Gx3q1cm36qSf7bHL3q/ALHjIlJNAyGTaSOSONZa46V?= =?us-ascii?Q?HG2v69sVoxSfw+BtKGdH6dXsZamF2lISOddoJ7EM6sLSCzwlOmO/I35AKBSq?= =?us-ascii?Q?9c8tTwohK1LYqVKdfY1Twm0W0pEPwaWoIDJD42PbLlA6RAxaBSu3uJ9IZGFs?= =?us-ascii?Q?8Hl5d4goPQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0962ce5a-f6fa-4765-65a9-08da3e3fb85b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 11:14:22.4768 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MaQ3ljkEt4kPxTaWBg3VJUPINhlwpVAEzK3dr/58N0vnPW26yvPSuRx2XZk3/lYlu8H5L1q0Z0DFoa0xuNNBWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 On 25.05.2022 12:52, Andrew Cooper wrote: > On 25/05/2022 09:13, Roger Pau Monne wrote: >> Rename the flag to better note that it's not actually forcing any IPIs >> to be issued if none is required, but merely avoiding the usage of TLB >> flush assistance (which itself can avoid the sending of IPIs to remote >> processors). >> >> No functional change expected. >> >> Requested-by: Jan Beulich >> Signed-off-by: Roger Pau Monn=C3=A9 >> --- >> Changes since v2: >> - New in this version. >=20 > :(=C2=A0 This needs reverting. >=20 > It is specific to IPIs, because of our current choice of algorithm for > freeing pagetables. >=20 > "no assist" excludes ipi-helper hypercalls which invoke > INVALIDATE_TLB_VECTOR.=C2=A0 Such hypercalls do exist and specifically wo= uld > be improvement that we ought to use. >=20 > Furthermore, we do want to work around the limitation that created > FLUSH_FORCE_IPI, because we absolutely do want to be able to use > hypercalls/remote TLB flushing capabilities when available. >=20 > I accept that FORCE_IPI perhaps isn't a perfect name, but it's a whole > lot less bad than NO_ASSIST. But FORCE_IPI has caused actual confusion while reviewing patch 2. If NO_ASSIST doesn't suit you and FORCE_IPI is also wrong, can you suggest a better name fitting both aspects? Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 11:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337167.561694 (Exim 4.92) (envelope-from ) id 1ntozB-0002B1-ST; Wed, 25 May 2022 11:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337167.561694; Wed, 25 May 2022 11:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntozB-0002As-Nv; Wed, 25 May 2022 11:15:29 +0000 Received: by outflank-mailman (input) for mailman id 337167; Wed, 25 May 2022 11:15:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntozA-0001gs-C3 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 11:15:28 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa96d988-dc1b-11ec-837f-e5687231ffcc; Wed, 25 May 2022 13:15:26 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id h10so2770192ljb.6 for ; Wed, 25 May 2022 04:15:26 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id v14-20020a2e990e000000b00253cc665797sm3059951lji.14.2022.05.25.04.15.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 04:15:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa96d988-dc1b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=rPxl8EkhMMu+QvnTQcsLCQ39ZkFGiBXennA9WmD/9Xs=; b=Sev4dNUIIq6/hOqo3rTmmqxntKAU4xaF+48cF3pp7VSmzkTmwTqSR9zZzHKe/hCgs5 BjINnYkT2EtLp+pZ4hPkapj8D2zAJ7Uv/S3/mm8ZpHQGKczqqvbTFw821a2hzfjdplS8 MOxEqVBpC01I8sUvgzqiwV/YX1Gf5s7krK3xt0y/FFpww6ebrrkodExkj2vCAWc0LST5 zpOFcHGLPw0VjkhJDNdpGaHEjDBLdS6rKI+aE5jJMTv486tQgYNyLzt6d4vJcd9fZ7gu dlD/b91ezj5/qIrnUOsA4wpGgj5wQBGJH1Vnfi1HJnEaUEeJTWucfWhfl9ECZcNrcKfD GjwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=rPxl8EkhMMu+QvnTQcsLCQ39ZkFGiBXennA9WmD/9Xs=; b=BONulh9pmaOLWT2N9T1DH/Hdrg0MoYPUz6d2BiPg94mSf6ERc3LJtn/VLNfWKt+CLQ CH2Qs64RHfrczOxB8N/15xkY29rmqMzRTxCZo22JrI8cjGIfqAHoCjF6e79MgZU5cgI5 h1J20+vgNYWqGUNgEc9thAYukMubYpN1vyB8pPEMqroyygadTX/0cuH6AjtqmovwuF1Y qXJU2/SQOMAjYBmkpSS5lsNcDiBDalcDYmpt4ax/iGkea16r5sIK8zr6hv+xPsK68zuf Lvaea+PlpZgQRvzZ5SYMuCeiOXjPcQ4MzSqYzsSqEOfKw/32p7mhtCBz9dnZDIgU0F7Z ouxw== X-Gm-Message-State: AOAM531ycxa6lBDDias9UyfV5NDBALZs8n9QL4D8Hoxxr9SFsosz/Ucj 1qNtvQ/G/3Q2u9c71qXSevo= X-Google-Smtp-Source: ABdhPJwp7kkMcPxnXQqJwdXUyiWS1oOxGDDYvKQD945JkwJmUXqWkwd/51bNu6XAoe39FG4SvK20tw== X-Received: by 2002:a2e:981:0:b0:253:d97f:9686 with SMTP id 123-20020a2e0981000000b00253d97f9686mr17016016ljj.227.1653477326120; Wed, 25 May 2022 04:15:26 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Stefano Stabellini Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> <606dfdcc-ec10-0c4a-04e9-72cd73ee6676@gmail.com> From: Oleksandr Message-ID: Date: Wed, 25 May 2022 14:15:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 24.05.22 20:59, Stefano Stabellini wrote: Hello Stefano > On Tue, 24 May 2022, Oleksandr wrote: >>> On Mon, 23 May 2022, Oleksandr wrote: >>>>>> On Thu, 19 May 2022, Oleksandr wrote: >>>>>>>> On Wed, May 18, 2022 at 5:06 PM Oleksandr >>>>>>>> wrote: >>>>>>>>> On 18.05.22 17:32, Arnd Bergmann wrote: >>>>>>>>>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko >>>>>>>>>> wrote: >>>>>>>>>>     This would mean having a device >>>>>>>>>> node for the grant-table mechanism that can be referred to >>>>>>>>>> using >>>>>>>>>> the >>>>>>>>>> 'iommus' >>>>>>>>>> phandle property, with the domid as an additional argument. >>>>>>>>> I assume, you are speaking about something like the following? >>>>>>>>> >>>>>>>>> >>>>>>>>> xen_dummy_iommu { >>>>>>>>>       compatible = "xen,dummy-iommu"; >>>>>>>>>       #iommu-cells = <1>; >>>>>>>>> }; >>>>>>>>> >>>>>>>>> virtio@3000 { >>>>>>>>>       compatible = "virtio,mmio"; >>>>>>>>>       reg = <0x3000 0x100>; >>>>>>>>>       interrupts = <41>; >>>>>>>>> >>>>>>>>>       /* The device is located in Xen domain with ID 1 */ >>>>>>>>>       iommus = <&xen_dummy_iommu 1>; >>>>>>>>> }; >>>>>>>> Right, that's that's the idea, >>>>>>> thank you for the confirmation >>>>>>> >>>>>>> >>>>>>> >>>>>>>>    except I would not call it a 'dummy'. >>>>>>>>   From the perspective of the DT, this behaves just like an >>>>>>>> IOMMU, >>>>>>>> even if the exact mechanism is different from most hardware IOMMU >>>>>>>> implementations. >>>>>>> well, agree >>>>>>> >>>>>>> >>>>>>>>>> It does not quite fit the model that Linux currently uses for >>>>>>>>>> iommus, >>>>>>>>>> as that has an allocator for dma_addr_t space >>>>>>>>> yes (# 3/7 adds grant-table based allocator) >>>>>>>>> >>>>>>>>> >>>>>>>>>> , but it would think it's >>>>>>>>>> conceptually close enough that it makes sense for the binding. >>>>>>>>> Interesting idea. I am wondering, do we need an extra actions >>>>>>>>> for >>>>>>>>> this >>>>>>>>> to work in Linux guest (dummy IOMMU driver, etc)? >>>>>>>> It depends on how closely the guest implementation can be made to >>>>>>>> resemble a normal iommu. If you do allocate dma_addr_t addresses, >>>>>>>> it may actually be close enough that you can just turn the >>>>>>>> grant-table >>>>>>>> code into a normal iommu driver and change nothing else. >>>>>>> Unfortunately, I failed to find a way how use grant references at >>>>>>> the >>>>>>> iommu_ops level (I mean to fully pretend that we are an IOMMU >>>>>>> driver). I >>>>>>> am >>>>>>> not too familiar with that, so what is written below might be wrong >>>>>>> or >>>>>>> at >>>>>>> least not precise. >>>>>>> >>>>>>> The normal IOMMU driver in Linux doesn’t allocate DMA addresses by >>>>>>> itself, it >>>>>>> just maps (IOVA-PA) what was requested to be mapped by the upper >>>>>>> layer. >>>>>>> The >>>>>>> DMA address allocation is done by the upper layer (DMA-IOMMU which >>>>>>> is >>>>>>> the glue >>>>>>> layer between DMA API and IOMMU API allocates IOVA for PA?). But, >>>>>>> all >>>>>>> what we >>>>>>> need here is just to allocate our specific grant-table based DMA >>>>>>> addresses >>>>>>> (DMA address = grant reference + offset in the page), so let’s say >>>>>>> we >>>>>>> need an >>>>>>> entity to take a physical address as parameter and return a DMA >>>>>>> address >>>>>>> (what >>>>>>> actually commit #3/7 is doing), and that’s all. So working at the >>>>>>> dma_ops >>>>>>> layer we get exactly what we need, with the minimal changes to guest >>>>>>> infrastructure. In our case the Xen itself acts as an IOMMU. >>>>>>> >>>>>>> Assuming that we want to reuse the IOMMU infrastructure somehow for >>>>>>> our >>>>>>> needs. >>>>>>> I think, in that case we will likely need to introduce a new >>>>>>> specific >>>>>>> IOVA >>>>>>> allocator (alongside with a generic one) to be hooked up by the >>>>>>> DMA-IOMMU >>>>>>> layer if we run on top of Xen. But, even having the specific IOVA >>>>>>> allocator to >>>>>>> return what we indeed need (DMA address = grant reference + offset >>>>>>> in >>>>>>> the >>>>>>> page) we will still need the specific minimal required IOMMU driver >>>>>>> to >>>>>>> be >>>>>>> present in the system anyway in order to track the mappings(?) and >>>>>>> do >>>>>>> nothing >>>>>>> with them, returning a success (this specific IOMMU driver should >>>>>>> have >>>>>>> all >>>>>>> mandatory callbacks implemented). >>>>>>> >>>>>>> I completely agree, it would be really nice to reuse generic IOMMU >>>>>>> bindings >>>>>>> rather than introducing Xen specific property if what we are trying >>>>>>> to >>>>>>> implement in current patch series fits in the usage of "iommus" in >>>>>>> Linux >>>>>>> more-less. But, if we will have to add more complexity/more >>>>>>> components >>>>>>> to the >>>>>>> code for the sake of reusing device tree binding, this raises a >>>>>>> question >>>>>>> whether that’s worthwhile. >>>>>>> >>>>>>> Or I really missed something? >>>>>> I think Arnd was primarily suggesting to reuse the IOMMU Device Tree >>>>>> bindings, not necessarily the IOMMU drivers framework in Linux >>>>>> (although >>>>>> that would be an added bonus.) >>>>>> >>>>>> I know from previous discussions with you that making the grant table >>>>>> fit in the existing IOMMU drivers model is difficult, but just reusing >>>>>> the Device Tree bindings seems feasible? >>>>> I started experimenting with that. As wrote in a separate email, I got a >>>>> deferred probe timeout, >>>>> >>>>> after inserting required nodes into guest device tree, which seems to be >>>>> a >>>>> consequence of the unavailability of IOMMU, I will continue to >>>>> investigate >>>>> this question. >>>> I have experimented with that. Yes, just reusing the Device Tree bindings >>>> is >>>> technically feasible (and we are able to do this by only touching >>>> grant-dma-ops.c), although deferred probe timeout still stands (as there >>>> is no >>>> IOMMU driver being present actually). >>>> >>>> [    0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, >>>> ignoring >>>> dependency >>>> [    0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks >>>> (2.10 >>>> GB/1.95 GiB) >>>> >>>> >>>> Below the working diff (on top of current series): >>>> >>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c >>>> index da9c7ff..6586152 100644 >>>> --- a/drivers/xen/grant-dma-ops.c >>>> +++ b/drivers/xen/grant-dma-ops.c >>>> @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = >>>> { >>>> >>>>  bool xen_is_grant_dma_device(struct device *dev) >>>>  { >>>> +       struct device_node *iommu_np; >>>> +       bool has_iommu; >>>> + >>>>         /* XXX Handle only DT devices for now */ >>>>         if (!dev->of_node) >>>>                 return false; >>>> >>>> -       return of_property_read_bool(dev->of_node, "xen,backend-domid"); >>>> +       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); >>>> +       has_iommu = iommu_np && of_device_is_compatible(iommu_np, >>>> "xen,grant-dma"); >>>> +       of_node_put(iommu_np); >>>> + >>>> +       return has_iommu; >>>>  } >>>> >>>>  void xen_grant_setup_dma_ops(struct device *dev) >>>>  { >>>>         struct xen_grant_dma_data *data; >>>> -       uint32_t domid; >>>> +       struct of_phandle_args iommu_spec; >>>> >>>>         data = find_xen_grant_dma_data(dev); >>>>         if (data) { >>>> @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) >>>>         if (!dev->of_node) >>>>                 goto err; >>>> >>>> -       if (of_property_read_u32(dev->of_node, "xen,backend-domid", >>>> &domid)) { >>>> -               dev_err(dev, "xen,backend-domid property is not >>>> present\n"); >>>> +       if (of_parse_phandle_with_args(dev->of_node, "iommus", >>>> "#iommu-cells", >>>> +                       0, &iommu_spec)) { >>>> +               dev_err(dev, "Cannot parse iommus property\n"); >>>> +               goto err; >>>> +       } >>>> + >>>> +       if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || >>>> +                       iommu_spec.args_count != 1) { >>>> +               dev_err(dev, "Incompatible IOMMU node\n"); >>>> +               of_node_put(iommu_spec.np); >>>>                 goto err; >>>>         } >>>> >>>> +       of_node_put(iommu_spec.np); >>>> + >>>>         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); >>>>         if (!data) >>>>                 goto err; >>>> >>>> -       data->backend_domid = domid; >>>> +       /* >>>> +        * The endpoint ID here means the ID of the domain where the >>>> corresponding >>>> +        * backend is running >>>> +        */ >>>> +       data->backend_domid = iommu_spec.args[0]; >>>> >>>>         if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, >>>> data, >>>>                         GFP_KERNEL))) { >>>> (END) >>>> >>>> >>>> >>>> Below, the nodes generated by Xen toolstack: >>>> >>>>         xen_grant_dma { >>>>                 compatible = "xen,grant-dma"; >>>>                 #iommu-cells = <0x01>; >>>>                 phandle = <0xfde9>; >>>>         }; >>>> >>>>         virtio@2000000 { >>>>                 compatible = "virtio,mmio"; >>>>                 reg = <0x00 0x2000000 0x00 0x200>; >>>>                 interrupts = <0x00 0x01 0xf01>; >>>>                 interrupt-parent = <0xfde8>; >>>>                 dma-coherent; >>>>                 iommus = <0xfde9 0x01>; >>>>         }; >>> Not bad! I like it. >> >> Good. >> >> >> >>> >>>> I am wondering, would be the proper solution to eliminate deferred probe >>>> timeout issue in our particular case (without introducing an extra IOMMU >>>> driver)? >>> In reality I don't think there is a way to do that. I would create an >>> empty skelethon IOMMU driver for xen,grant-dma. >> Ok, I found yet another option how we can avoid deferred probe timeout issue. >> I am not sure whether it will be welcome. But it doesn't really require >> introducing stub IOMMU driver or other changes in the guest. The idea is to >> make IOMMU device unavailable (status = "disabled"), this way >> of_iommu_configure() will treat that as success condition also. >> >> https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L31 >> https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L149 >> >>         xen_grant_dma { >>                 compatible = "xen,grant-dma"; >>                 #iommu-cells = <0x01>; >>                 phandle = <0xfde9>; >>                 status = "disabled"; >>         }; >>         virtio@2000000 { >>                 compatible = "virtio,mmio"; >>                 reg = <0x00 0x2000000 0x00 0x200>; >>                 interrupts = <0x00 0x01 0xf01>; >>                 interrupt-parent = <0xfde8>; >>                 dma-coherent; >>                 iommus = <0xfde9 0x01>; >>         }; >> >> I have checked, this "fixes" deferred probe timeout issue. >> >> >> Or we indeed need to introduce stub IOMMU driver (I placed it to driver/xen >> instead of driver/iommu, also we can even squash it with grant-dma-ops.c?). >> This stub driver also results in NO_IOMMU condition (as "of_xlate" callback is >> not implemented). >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index a7bd8ce..35b91b9 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -335,6 +335,10 @@ config XEN_UNPOPULATED_ALLOC >>           having to balloon out RAM regions in order to obtain physical memory >>           space to create such mappings. >> >> +config XEN_GRANT_DMA_IOMMU >> +       bool >> +       select IOMMU_API >> + >>  config XEN_GRANT_DMA_OPS >>         bool >>         select DMA_OPS >> @@ -343,6 +347,7 @@ config XEN_VIRTIO >>         bool "Xen virtio support" >>         depends on VIRTIO >>         select XEN_GRANT_DMA_OPS >> +       select XEN_GRANT_DMA_IOMMU >>         help >>           Enable virtio support for running as Xen guest. Depending on the >>           guest type this will require special support on the backend side >> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile >> index 1a23cb0..c0503f1 100644 >> --- a/drivers/xen/Makefile >> +++ b/drivers/xen/Makefile >> @@ -40,3 +40,4 @@ xen-privcmd-y                         := privcmd.o >> privcmd-buf.o >>  obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF)    += xen-front-pgdir-shbuf.o >>  obj-$(CONFIG_XEN_UNPOPULATED_ALLOC)    += unpopulated-alloc.o >>  obj-$(CONFIG_XEN_GRANT_DMA_OPS)                += grant-dma-ops.o >> +obj-$(CONFIG_XEN_GRANT_DMA_IOMMU)      += grant-dma-iommu.o >> diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c >> new file mode 100644 >> index 00000000..b8aad8a >> --- /dev/null >> +++ b/drivers/xen/grant-dma-iommu.c >> @@ -0,0 +1,76 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Stub IOMMU driver which does nothing. >> + * The main purpose of it being present is to reuse generic device-tree IOMMU >> + * bindings by Xen grant DMA-mapping layer. >> + */ >> + >> +#include >> +#include >> +#include >> + >> +struct grant_dma_iommu_device { >> +       struct device *dev; >> +       struct iommu_device iommu; >> +}; >> + >> +/* Nothing is really needed here */ >> +static const struct iommu_ops grant_dma_iommu_ops; >> + >> +static const struct of_device_id grant_dma_iommu_of_match[] = { >> +       { .compatible = "xen,grant-dma" }, >> +       { }, >> +}; >> + >> +static int grant_dma_iommu_probe(struct platform_device *pdev) >> +{ >> +       struct grant_dma_iommu_device *mmu; >> +       int ret; >> + >> +       mmu = devm_kzalloc(&pdev->dev, sizeof(*mmu), GFP_KERNEL); >> +       if (!mmu) >> +               return -ENOMEM; >> + >> +       mmu->dev = &pdev->dev; >> + >> +       ret = iommu_device_register(&mmu->iommu, &grant_dma_iommu_ops, >> &pdev->dev); >> +       if (ret) >> +               return ret; >> + >> +       platform_set_drvdata(pdev, mmu); >> + >> +       return 0; >> +} >> + >> +static int grant_dma_iommu_remove(struct platform_device *pdev) >> +{ >> +       struct grant_dma_iommu_device *mmu = platform_get_drvdata(pdev); >> + >> +       platform_set_drvdata(pdev, NULL); >> +       iommu_device_unregister(&mmu->iommu); >> + >> +       return 0; >> +} >> + >> +static struct platform_driver grant_dma_iommu_driver = { >> +       .driver = { >> +               .name = "grant-dma-iommu", >> +               .of_match_table = grant_dma_iommu_of_match, >> +       }, >> +       .probe = grant_dma_iommu_probe, >> +       .remove = grant_dma_iommu_remove, >> +}; >> + >> +static int __init grant_dma_iommu_init(void) >> +{ >> +       struct device_node *iommu_np; >> + >> +       iommu_np = of_find_matching_node(NULL, grant_dma_iommu_of_match); >> +       if (!iommu_np) >> +               return 0; >> + >> +       of_node_put(iommu_np); >> + >> +       return platform_driver_register(&grant_dma_iommu_driver); >> +} >> +subsys_initcall(grant_dma_iommu_init); >> >> I have checked, this also "fixes" deferred probe timeout issue. >> >> Personally I would prefer the first option, but I would be also happy to use >> second option in order to unblock the series. >> >> What do the maintainers think? > > > I don't think it is a good idea to mark the fake IOMMU as disabled > because it implies that there is no need to use it (no need to use > dma_ops) which is a problem. I got your point. You are right, this indeed sounds weird. I expected this simple solution wouldn't be welcome. > > If we don't want the skelethon driver then Rob's suggestion of having a > skip list for deferred probe is better. I am not sure I understand the idea completely. Does it mean that we will need new command line option (?) to pass some string (I assume, the "compatible" for IOMMU device) to not defer probe if corresponding driver is missing, but just return NO_IOMMU right away? > > I think the skelethon driver also is totally fine. ok, thank you for the feedback. -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 25 11:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337176.561705 (Exim 4.92) (envelope-from ) id 1ntp1t-0002uX-F5; Wed, 25 May 2022 11:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337176.561705; Wed, 25 May 2022 11:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntp1t-0002uQ-B5; Wed, 25 May 2022 11:18:17 +0000 Received: by outflank-mailman (input) for mailman id 337176; Wed, 25 May 2022 11:18:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntp1s-0002tT-66; Wed, 25 May 2022 11:18:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntp1s-00079j-1m; Wed, 25 May 2022 11:18:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntp1r-00065U-7e; Wed, 25 May 2022 11:18:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntp1r-0003IW-6w; Wed, 25 May 2022 11:18:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NbJRB8I8qsQqg8zkAd4GewzgLzAFF3j0p66R3NIddws=; b=DpGBciYPdzncyiFY6bOrlN3Cyx Wh+zG2VvC/JMFhrD9mBkEraYffz4Rf0YmRwwkcY1laFxzVsM5jsbfEyCpiX7COdE07kdulIuFaiY1 uFJumaH4q+CtZOaQn88jv7q728QZ9CyWKySfLmMrZbaFDUupfl8gDeJYWeaEEU0Po67s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170721: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0cac736e73723850a99e5142e35d14d8f8efb232 X-Osstest-Versions-That: qemuu=3757b0d08b399c609954cf57f273b1167e5d7a8d From: osstest service owner Date: Wed, 25 May 2022 11:18:15 +0000 flight 170721 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170721/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170635 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170635 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170635 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170635 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170635 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170635 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170635 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170635 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 0cac736e73723850a99e5142e35d14d8f8efb232 baseline version: qemuu 3757b0d08b399c609954cf57f273b1167e5d7a8d Last test of basis 170635 2022-05-21 10:03:04 Z 4 days Testing same since 170721 2022-05-25 03:38:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anup Patel Atish Patra Bernhard Beschow Bin Meng Dylan Reid Dylan Reid eop Chen eopXD Frank Chang Hongren (Zenithal) Zheng Jiatai He Junqiang Wang Richard Henderson Tsukasa OI Weiwei Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 3757b0d08b..0cac736e73 0cac736e73723850a99e5142e35d14d8f8efb232 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed May 25 11:31:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:31:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337188.561716 (Exim 4.92) (envelope-from ) id 1ntpE6-0005Ax-Id; Wed, 25 May 2022 11:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337188.561716; Wed, 25 May 2022 11:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpE6-0005Aq-Fg; Wed, 25 May 2022 11:30:54 +0000 Received: by outflank-mailman (input) for mailman id 337188; Wed, 25 May 2022 11:30:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpE5-0005Ak-Pp for xen-devel@lists.xenproject.org; Wed, 25 May 2022 11:30:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpE2-0007Ni-Uf; Wed, 25 May 2022 11:30:50 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.21.168]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntpE2-00007h-OD; Wed, 25 May 2022 11:30:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nmx40bZKQoNr8efyxTXmHeM1D6kreB5aaKQ7qYw+4IE=; b=NZpPMbXVM1aTZgLJITJVI8HFLb i7uwdwcVImBGYauKzyuODu5ywQCMLlUuv8d+flKm6GINnTIPQXK+hBhoACDp4eEHjYTS7ZLCWZsTz jTkdIR8ZONI1a8bOHzTIXi+FnhhtqXFfmKdJ42lJPBGqnI1lvUa+zh4cD+JcULj2036M=; Message-ID: Date: Wed, 25 May 2022 12:30:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] SUPPORT.md: extend security support for x86 hosts to 12 TiB of memory To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <5835df1e-8f92-79ce-94c5-1b5df9c9ff65@suse.com> <6f333841-17e3-c9ac-580a-fc89f1741596@xen.org> <5ad659cd-826a-4393-777b-f4103d02af77@suse.com> From: Julien Grall In-Reply-To: <5ad659cd-826a-4393-777b-f4103d02af77@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 25/05/2022 12:11, Jan Beulich wrote: > On 25.05.2022 12:58, Julien Grall wrote: >> On 25/05/2022 10:21, Jan Beulich wrote: >>> --- a/SUPPORT.md >>> +++ b/SUPPORT.md >>> @@ -50,7 +50,7 @@ For the Cortex A57 r0p0 - r1p1, see Erra >>> >>> ### Physical Memory >>> >>> - Status, x86: Supported up to 8 TiB. Hosts with more memory are supported, but not security supported. >>> + Status, x86: Supported up to 12 TiB. Hosts with more memory are supported, but not security supported. >>> Status, Arm32: Supported up to 12 GiB >>> Status, Arm64: Supported up to 2 TiB >>> >>> @@ -121,6 +121,17 @@ ARM only has one guest type at the momen >>> >>> Status: Supported >>> >>> +## Guest Limits >>> + >>> +### Memory >>> + >>> + Status, x86: Supported up to 8 TiB >>> + Status, Arm64: Supported up to 1 TiB >>> + Status, Arm32: Supported up to 32 GiB >> >> IIRC, the max the architecture would allow us is 16 Gib. Here we are >> limited with how much physical memory is supported by Xen. So this wants >> to be 12 GiB. > > Hmm, while I don't know where I took the 32 from, it was you who > suggested (in reply to v1) I put 16 here. Hmmm... I am pretty sure I wrote 16 in v1 [1]. > Though yes, with the > host limit now set to just 12, putting more here would be odd. > I didn't cross check the numbers, I'll admit. > >>> + >>> +Guests with more memory, but less than 16 TiB, are supported, >>> +but not security supported. >> >> On Arm32, we definitely can't support up to 16 TiB. On Arm64, we would >> need some work to support it. So I would move this sentence in the >> "Status, x86" section. > > Sure, I can do that. Would have been nice if you had said so right > on v1. I only spotted this oddity now. Sorry. > As to Arm64 though - the host limit is 2 TiB. Going beyond > that being impossible (without becoming at least unsupported), is > the uniform upper bound of 16 TiB really a problem here (IOW do > guests really only function up to 1 TiB)? The guest memory layout has only been defined for up to 1TB. Hopefully this is the only place where the assumption is baked. But as I don't have such machine in hand, I can't easily confirm it. So I think we need to clarify that the 16TB limit only applies to x86. > For Arm32 it would be > even less of an issue, as hosts with more than 12 GiB are > unsupported. This is only obvious if you know that Xen doesn't support memory overcommitting. Admittely, this could be considered as basic Xen knowledge. Cheers, [1] https://lore.kernel.org/xen-devel/6ec0e3d9-374c-1caa-9889-f091dcf894e3@xen.org/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed May 25 11:42:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 11:42:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337196.561726 (Exim 4.92) (envelope-from ) id 1ntpPg-0006fo-Lc; Wed, 25 May 2022 11:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337196.561726; Wed, 25 May 2022 11:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpPg-0006fh-If; Wed, 25 May 2022 11:42:52 +0000 Received: by outflank-mailman (input) for mailman id 337196; Wed, 25 May 2022 11:42:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpPe-0006fX-Tf; Wed, 25 May 2022 11:42:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpPe-0007a6-QK; Wed, 25 May 2022 11:42:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntpPe-0007Er-8a; Wed, 25 May 2022 11:42:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntpPe-0004f5-86; Wed, 25 May 2022 11:42:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8bWGE18wr9fI071XfkA6b/BPwbhlILxEHtuLGi2KtnM=; b=7CJ8IsZ19X+BHMfH/0nk67lEMG DckoTGdSxHyo9aPTn8ZHI8/3ShvTCyA3xeFxKd8VEf8HK0Ld0NqG+4DUosYBw0CjfAcsDJ4qmoqqS gD4KhxDuVmmkyZO1pdZ+aeKNS1blgEONLKXuROYyFwPRivtXJqZIqnKlTvmDoIpf6K44=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170722: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=e79bfda145a69d6ba72daa46b0af187f9dacc8d0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 25 May 2022 11:42:50 +0000 flight 170722 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170722/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt e79bfda145a69d6ba72daa46b0af187f9dacc8d0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 684 days Failing since 151818 2020-07-11 04:18:52 Z 683 days 665 attempts Testing same since 170722 2022-05-25 04:19:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 109848 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 25 12:21:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 12:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337209.561738 (Exim 4.92) (envelope-from ) id 1ntq0x-0002Rn-V0; Wed, 25 May 2022 12:21:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337209.561738; Wed, 25 May 2022 12:21:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntq0x-0002Rg-S0; Wed, 25 May 2022 12:21:23 +0000 Received: by outflank-mailman (input) for mailman id 337209; Wed, 25 May 2022 12:21:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntq0v-0002Ra-QH for xen-devel@lists.xenproject.org; Wed, 25 May 2022 12:21:22 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 275ab625-dc25-11ec-837f-e5687231ffcc; Wed, 25 May 2022 14:21:08 +0200 (CEST) Received: from mail-dm3nam07lp2043.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 08:21:16 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB4569.namprd03.prod.outlook.com (2603:10b6:5:10c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Wed, 25 May 2022 12:21:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 12:21:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 275ab625-dc25-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653481279; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LRKICtsLLPt+yG34fs/Zlwu61EhRNr9vBmK9Wjs05gE=; b=VUNlft9H3c+8Niyh4kR3EVDCybpFdOOkboyKlZMYiGo6y9WHiNarfLro q46lZWp7GHndS4FfsrcjBW6gd/Iq4EYXTDZ8ytYmW47BvUP2euD3raEHy fC6TjcRDJjEdIuz5Dqfj2iyc9tNcuZeCNh9XTnApvwLdD9Diu6J9dUXTw w=; X-IronPort-RemoteIP: 104.47.56.43 X-IronPort-MID: 72541190 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:02Yiyqhn5qKuiu22cVdZD11/X161rxEKZh0ujC45NGQN5FlHY01je htvWmmPOK6LZGD1L95wbIux8BxUsJTVzt5lSABrqiFnQygb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnQ4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVciIafpx/Y6bzAbShxDO/dh/Ib3L3fq5KR/z2WeG5ft69NHKRlseKE9oaNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEegGxYasNmRJ4yY +IwbzZ1YQuGSBpIIloNU7o1nfuyh2m5eDpdwL6QjfVtvjSKlV0puFTrGMuPa4GgGspop2yRv 2fJ9VzyLDMwbuXKnFJp9Vrp3IcjhxjTQ5kOHbe18vprhly7xWEJDhASE1yhrpGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1ZpasEitcIwbSwn0 BmOhdyBLRZiqqGPQHSRsJKdtyqvODM9JHUHIyQDSGMt+MXurog1iVTUUt9pHaqxj9v0MSHxx zGMvG41gLB7sCIQ/6Cy/FSCjzf3oJHMFlEx/l+PAjnj6R5lbom4YYDu8ULc8ftLMIeeSB+Go WQAnM+dqusJCPlhiRCwfQnEJ5nxj97tDdEWqQUH80UJn9h1x0OeQA== IronPort-HdrOrdr: A9a23:nEEHZ6+yn3PiHEV6Yzpuk+G5dr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQMdcBW7Sd+9qADnhOtICOgqTPaftWzd1FdAQ7sSk7fK7wfJIjb5/OJGz6 tsGpIOUeEYYWIK9voSpTPIYOrIo+P3sJxA592uvkuFJDsCA84PnmQJaHfjYzVLqRF9ZabRVq DslvavzwDQO0j/Bf7Le0XtKtKz2OEj46iWHSLuaSRXkjVmuQnYrYLSIly1zx0aWzNKzawC93 LZnwHC5qulu+ym0RPHk0ve9Y5fltfZ0d1ICNaXhsV9EESIti+YIKhxUbiLvDQ4u8Gq8U0rl8 TlqQohOcMb0QK2QkiF5Tf90Qzp0DIj8F/n0ESZhmbHqdH0QzgrYvAx4r5xQ1/0+kAktNF53L lzxGSJp79eEB/GljSV3amta/gmrDvvnZLs+dRjwUB3YM87Uvt8vIYf9ERaHNMpGz/70pkuFK 1UAMTV9J9tAB6nhySyhAhS6e3pek52MgaNQ0AEtMDQ+SNRhmpFw0wRw9Fatmsc9bomIqM0tN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnLqcaIHjAwqSHsInd3NvaKqDg8aFCxq gpEWko6lLaQnieVfFmCac7oywkQw2GLH7QI49lltsJ74EVgtLQQGm+oRsV4r+dSs4kc4Tmsy zaAuMRPxbSFxqoJW8A5XyIZ3BzEwhHbCRHgKdhZ7p5yvi7ZbEDiITgAb3uzE2EK0dpZoq4OA pfYNHaHrQJ0nyW X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72541190" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mptxkxz1c58ML8TZymVqYOhd1URt7X8AkqaWPOZuh0SfcMIkvKJEHFqXkuo5rh6p3E5B3EBWRDD81aYUeIC5ujtcgRv5WzZgwRSl5kMYDJXpvW7sKc/ThF0suG4NheL95InuDyEJI2slwwo6CLVJzgxjQpujNaY+nzEBfBaQt75GWsr5QR6wIK+esj3Ecub4EvDxmuRHF+f3HujC8cIPQYjRIDS8Ykkdgx1TKuKi3GzUwLpcUARyOtqWEKHusr03rztURDBBbK80KgbX5n9Nk+Sy5vox+5WmYlglZUDhjOQAeiE1bhc3/LTao+ny4Fbr0pISt5w6lwsmYkCGkOckWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LRKICtsLLPt+yG34fs/Zlwu61EhRNr9vBmK9Wjs05gE=; b=RTNr54eurAwegZawLv3gvy56U/00+Wdm/79QL7Y3FHQGO7cQTFOrwf+imCmSUQtu+tPSwXm9r+NOTxg/M+E6GZdtwyz1EG59nBu2EACfuxGyd/WP+pqKYMD+5RrXa9/rZK62JfqhYKsk+hYvyQ6tx7hePKUZ3tYO+EXUpGKAWXLVaFiMY6QnxDHUZMjnR9vig0iHVqEoxEkrWv2Qv7QDBhq74XAPIX7pJKsq0CKubTB0ZBZn7RP5h4cx0VNh3fzO4zNHas/XksQ0edxfrXcWNQdcUahcGNvVx0y20jqdmttDejfxNs4gZVPqpNyaKWX3UFg1kx/kw48SoTeBWZcQhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LRKICtsLLPt+yG34fs/Zlwu61EhRNr9vBmK9Wjs05gE=; b=n4I5klgBJDb3FJoKhKFZY9HBARxYNU1d+PdM1TpivSzL+eQZYBK7h6huF7FHBJZWyOtIWp3ycDZxr+MkTl6Z6wdGf+ta1N8sElt4MCf6KHorWYQsbwr8AUveka6fDIo1Hd/fOVs7aHDVAot8p4uawvuQwvztPWLzCqR6PsFUgOQ= From: Andrew Cooper To: Stefano Stabellini , "xen-devel@lists.xenproject.org" CC: "jbeulich@suse.com" , Roger Pau Monne , "julien@xen.org" , "Bertrand.Marquis@arm.com" , George Dunlap , Stefano Stabellini Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Topic: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Index: AQHYb89OVlMbfNQEIke7o99YDeB9D60vhDsA Date: Wed, 25 May 2022 12:21:14 +0000 Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> In-Reply-To: <20220525003505.304617-1-sstabellini@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88058cfc-7afc-479a-f8f2-08da3e490fdb x-ms-traffictypediagnostic: DM6PR03MB4569:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mgwAbrCFS0qKYX1cCI32ZJq+OEEKRuEVQcrTMn8XOVpCmvLw7IkIGQMtpYhxlykj2jopk+KT3KPkE5YEKb3vMj8QpgA6MspwHUz/hCbsBsCGDtzKGJ0GDMmod9cNCdYNhYWoqA5SCG60AoKRN4UVXOZeZsUi4hSNlzu0cyCM2YaT+dX8Kl4OWYbVxTRmA+FyA5tYyH2L1TTpOryAyTEmYjUkkSqkaaEki2D1jIB2wzr91SQZw5rkb4LuCUZV7ZpqxvIhkSP2HR0jPiE3tja13cdjlSN2/eZ2dZaDR9nkdHj3p9P/b1rGyUKklkU7jPu5OSkzG7ZPUe6cVpTa7N8xqwjrp9jQn/lzXsCcaltm2QLFfPAxP4NnwJmt5bSPHarg2+w9Lt9IfO3ySTlV3keeDZWU43tJvTp422er4/sm2s4tK9bYNBf33jnF2OCvSIYIdc542bC1vqBO0u6417B6d+rfofUxWRdMv1luaQYAxKU7iM1Y16t+t0NE/sITuFNFsY0msuCE4nrCH7QxoDI53V9rG6891Aov/MlQiMhc0daIZeBW71c79skahF5wtkPuGKBdaGrnTm0pZBOPE+vJ33EjfJd7y3aDwCvMotkvhurBlsShRAdKWp1Qfk8d/U92vCA4lU3APVJKncULJhYc5h3Ja7aDsV7+LF16eeVdfSno2Vae9Tphg3HdfSzNzTEf4M14kC+HCvz1oSfCp2h4Tngjw/l0hILISkwpjkWOWNKDwAQuz9BzuV+mdnl8ssWYZcYiKt4XID0LlIaTcuIXZMov4fWlFwXlzJb/9mlCBIKKBfvutSUfkiyrKFfEYAjWb4Q5fQqiF1Jv1gTCj89zNW48KgpRDy+eHC5JPXERFfZTjftABtK2LXyy+A2nnvT9hIVroK71uWba/xsIpo7G4w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(83380400001)(8936002)(508600001)(82960400001)(2906002)(66946007)(966005)(6486002)(5660300002)(54906003)(38100700002)(38070700005)(110136005)(2616005)(53546011)(316002)(26005)(91956017)(4326008)(66556008)(31696002)(64756008)(66476007)(66446008)(76116006)(8676002)(6512007)(31686004)(36756003)(86362001)(6506007)(71200400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MGo0UW1uM3hHZHV2bk82OU5nYmNsb0tBKzZmUTNrV0dXQzNHS3VyNUtobFZ0?= =?utf-8?B?aXYycDIweVB2QURNMVBWdVZVREpyazFmL3lOSHoxbEtPZmp2QXU3K01ZTlo0?= =?utf-8?B?T1dJMUNwSEd2RnFRYUFnSDA4dTIrci9HTXVSNktmN2VFV3NKNTVib1VkVXAz?= =?utf-8?B?Rm1kS3dzNXBJK1UvdHMxT0U3ckRSR1hBajRwTWhkNG5rd2pKa1o2YzNWVzRn?= =?utf-8?B?Zm1wcUxrTjBrOWsrdWhKdEE1OGpWcGlFdHdKR2N0Z0JiLzlGTjJkbDRpS1ZK?= =?utf-8?B?R3NyeE80Y1daaHVzOThEN3BkVDZXcTdCNnU4d2RTRnNMQ1Y5RkVjNGt6bmhX?= =?utf-8?B?Q2dkZVAwbDRKdzA0VDZHazhUNjd3SDdPWW52K2o0MHdDWW5zN1BoeUN6aUU0?= =?utf-8?B?QnNxci9oMi81ZUxqYytjbkxsZm9UV3V3aGcyL1h0Ulovak5nOWt4bW13OU05?= =?utf-8?B?VUJJRitJZG9ZUkNJNVErTGdjUmFySkNtOUJHTlVsMkV2RW1yelpYQ1NLaWZj?= =?utf-8?B?N1ZUcmcraVNyVEgyZ2xIaVRXRzlacFhLcmRrazJOYzlwenA5emVqNmY0Tisr?= =?utf-8?B?eW1vUGNKL0dpcUFKWHZvY2VpcDRMdGR4RE9mQ3FhSFIyeCt5bitaV0w4cjVt?= =?utf-8?B?RFRHeDFtWHd2blkwd3RjcjRUdVVTUFQvaGNMT0lQNmRLZGZWbkZwMXdwZFVX?= =?utf-8?B?N29tQ3BQbE56QWI5Qk9pczB1aXVGdDlQMitpWUc3bk9GSTVURVRwOTN6dVIw?= =?utf-8?B?THMwZjlHbVRBbkIzODBiM25Gdm9zdE9ybG5CMWx0YWRCK2JJSkFSSEtoMUVj?= =?utf-8?B?ZlVGM0tJNERZcXorMkc2Ui80Tk54SlpTWEg4aGs5dFM1NmFSaHJJaXlzS3Rs?= =?utf-8?B?a1lORjY5N0VndCtZSVkwbExDYTdtVUk4djdkekJRQyttNkx5dlRHRTRxNnpq?= =?utf-8?B?NWRxZERldUR6WUJIMjZ0MHIyWDVTVjRsK2tLRm1uR08xb0psaW9Nb0lOTHEw?= =?utf-8?B?eENIQ2F2dUdPZy8yVndIR3J3emV2RVFNNDAzOEZyVkM4V2V3WDhxZU90ai95?= =?utf-8?B?WmIrcU9YV0cySFc0ZEF0Ti9QbkZ0SCt5M1JiUjk0ek93NW1sRFB0cUljZmdO?= =?utf-8?B?Mk91R000TUxNMXVqY0xzc3U3bjc2dHMyK05FeTlEcEs3N1BpZHJTVzAvOEZn?= =?utf-8?B?L2k1ZEw0WC8wN1hVZDRlbFZmZ1JrQnRPT1BWdWl3VzFnVGFpTUl2bC9WWFF2?= =?utf-8?B?WW05OVdlNndNQklMM2xTczJPV0M5QzZVZWp1Z3orMStPdTEwNXFnRzdoV2dH?= =?utf-8?B?OEdiOTU0Zmtzc0pDMit3eUlSTFBtd3FYTTNsdldvMWdFbStjSytzb2U0VzJU?= =?utf-8?B?QjlQVHNwcUJZRnZ2S2x6Mnp5bjdlUHpidEZGMEZ1ZUpTNEY5WUI1RWJGSkpq?= =?utf-8?B?NWI4bFlsNXZtQ2JiL3lLSlUvdEs5aTgyT0NJU2VCeDZvdlZYT2xMNGZIanRC?= =?utf-8?B?SGF0am0rTFhDcFY0cFN3R3oxWHV0eEQrUGswVmhmWC9JV1JkL2NHMGl1QU5r?= =?utf-8?B?ZWlja2FrbjNkU05xaXllL3I1bU5MNG5SVUFmZ09WTkRGK1Bhb3hjZWpQdmtl?= =?utf-8?B?SWdhcXlvS2JlL3AxdFdac0ZyZUcvY3g5RjI4SnppL21ydUMxZElYM1AwbU1v?= =?utf-8?B?SGJNYmhNekFQL0ZjSzJXdTl4Q0dUNnAzWHVpNUtLa3RENm9JZlEraEZBTzA3?= =?utf-8?B?NHkvQ3hHbW5RYWVQZ2JheEp5dE82dSs0RjBVdENIMUUyaVJlUnB6eDhCUTAv?= =?utf-8?B?VW1XeVhkNURTVW91TGJvS3owWnUwWFNFeDlzV1loWU1RN0lXT2lzYndCanJE?= =?utf-8?B?aG1pUGlDNCsrQ2g4MHIxTnkrWVNDbDE3ZktLYjBEYzQrY0t6QmxPanFRMHJS?= =?utf-8?B?RFg5bHpyR291QVkydWNHc2FiTUNBQ2tLdkpPcmRMTTJ5amN6OU4yTWlqc0U5?= =?utf-8?B?U0pQcjhZcENEM1E0dC9weWhqTURURFViUWhnVUswYjJtY001MTNHT0dncDRP?= =?utf-8?B?dFdBaWtxdHhCVVN6d1c2dTFKSjRQMmdrMmQ1cytSS0NSM0c1cDFzRWc1R3ly?= =?utf-8?B?ZDdlM1JZVThma0x4bnFFa2Z2YkpvYU1OTnBhbUIzL2t1TU00QjExRkwxZzJI?= =?utf-8?B?NXVQc1p3eXdpOWdYRDFiOTB0czQ5cXNjUkxXRDFRUkM3RlkrbS9KczNYVzdr?= =?utf-8?B?YmJBc2NKN2xDQk5qQXdBTnY3c213SU9Pbm1KWkFwTWdpYkV6TExBY2t0Wlkw?= =?utf-8?B?TWFRckdyTHA5ajlodjU3YUJWYkJsWmFZOUUwVlRLMFpPSkdLb000a2FpWHM2?= =?utf-8?Q?9SSh2m+jcugJ5hMU=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <51ECA361125213469120BF7DE05691ED@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88058cfc-7afc-479a-f8f2-08da3e490fdb X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 12:21:14.5330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xR/f9Zcov1YEnauEuZukpdBzywyaMo1d1WA4RDGlObl/dKyqtRwKnzQgPmysCqWc7aCYbOEW1tZJgln7iY7i2mujvui7WcE3lQK+CaQsMgE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4569 T24gMjUvMDUvMjAyMiAwMTozNSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiBGcm9tOiBT dGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0KPg0KPiBJ bnRyb2R1Y2UgYSBsaXN0IG9mIE1JU1JBIEMgcnVsZXMgdGhhdCBhcHBseSB0byB0aGUgWGVuIGh5 cGVydmlzb3IuIFRoZQ0KPiBsaXN0IGlzIGluIFJTVCBmb3JtYXQuDQo+DQo+IEFkZCBhIG1lbnRp b24gb2YgdGhlIG5ldyBsaXN0IHRvIENPRElOR19TVFlMRS4NCj4NCj4gU2lnbmVkLW9mZi1ieTog QmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29tPg0KPiBTaWduZWQtb2Zm LWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0K DQpTb21lIGNvbW1lbnRzIG9uIHN5bnRheC9sYXlvdXQsIHVucmVsYXRlZCB0byB0aGUgc3BlY2lm aWMgY29udGVudC4NCg0KWW91IGNhbiBjaGVjayB0aGUgcmVuZGVyZWQgY29udGVudCB3aXRoIGVp dGhlciBgbWFrZSAtQyBkb2NzDQpzcGhpbngtaHRtbGAgbG9jYWxseSwgb3IgYnkgcG9pbnRpbmcg cmVhZHRoZWRvY3MgYXQgeW91ciByZXBvLsKgIChlLmcuDQpodHRwczovL2FuZHJld2Nvb3AteGVu LnJlYWR0aGVkb2NzLmlvL2VuL2RvY3MtZGV2ZWwvIGlzIGEgdmVyeSBvdXQgb2YNCmRhdGUgV0lQ IGJyYW5jaCBvZiBzb21lIGluLWRldmVsb3BtZW50IGNvbnRlbnQuKQ0KDQpXaGF0ZXZlciBnZXRz IGNvbW1pdHRlZCB3aWxsIGJlIHJlbmRlcmVkIGF0DQpodHRwczovL3hlbmJpdHMueGVuLm9yZy9k b2NzL2xhdGVzdC8gb25jZSB0aGUgY3JvbmpvYiBjYXRjaGVzIHVwLg0KDQo+IC0tLQ0KPiAgQ09E SU5HX1NUWUxFICAgICAgICAgfCAgNiArKysrDQo+ICBkb2NzL21pc3JhL3J1bGVzLnJzdCB8IDY1 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQoNCkF0IG1pbmlt dW0gdGhlcmUgbmVlZHMgdG8gYmUgYW4gYWRkaXRpb24gdG8gYSB0b2N0cmVlIGRpcmVjdGl2ZSBp biBvbiBvZg0KdGhlIGV4aXN0aW5nIGluZGV4LnJzdCdzDQoNCkJ1dMKgIHRoaXMgbG9va3MgbGlr ZSBpdCBvdWdodCB0byBiZSBwYXJ0IG9mIHRoZSBoeXBlcnZpc29yIGd1aWRlID8NCg0KPiAgMiBm aWxlcyBjaGFuZ2VkLCA3MSBpbnNlcnRpb25zKCspDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZG9j cy9taXNyYS9ydWxlcy5yc3QNCj4NCj4gZGlmZiAtLWdpdCBhL0NPRElOR19TVFlMRSBiL0NPRElO R19TVFlMRQ0KPiBpbmRleCA5ZjUwZDljZWM0Li4xZWYzNWVlOGQwIDEwMDY0NA0KPiAtLS0gYS9D T0RJTkdfU1RZTEUNCj4gKysrIGIvQ09ESU5HX1NUWUxFDQo+IEBAIC0yMzUsMyArMjM1LDkgQEAg Y2FsbHN0YWNrIGJldHdlZW4gdGhlIGluaXRpYWwgZnVuY3Rpb24gY2FsbCBhbmQgdGhlIGZhaWx1 cmUsIG5vIGVycm9yDQo+ICBpcyByZXR1cm5lZC4gIFVzaW5nIGRvbWFpbl9jcmFzaCgpIHJlcXVp cmVzIGNhcmVmdWwgaW5zcGVjdGlvbiBhbmQNCj4gIGRvY3VtZW50YXRpb24gb2YgdGhlIGNvZGUg dG8gbWFrZSBzdXJlIGFsbCBjYWxsZXJzIGF0IHRoZSBzdGFjayBoYW5kbGUNCj4gIGEgbmV3bHkt ZGVhZCBkb21haW4gZ3JhY2VmdWxseS4NCj4gKw0KPiArTUlTUkEgQw0KPiArLS0tLS0tLQ0KPiAr DQo+ICtUaGUgWGVuIFByb2plY3QgaHlwZXJ2aXNvciBmb2xsb3dzIHRoZSBNSVNSQSBDIGNvZGlu ZyBydWxlcyBhbmQNCj4gK2RpcmVjdGl2ZXMgbGlzdGVkIHVuZGVyIGRvY3MvbWlzcmEvcnVsZXMu cnN0Lg0KDQpJIHRoaW5rIHRoaXMgd291bGQgYmUgY2xlYXJlciB0byBmb2xsb3cgYXM6DQoNCiJU aGUgWGVuIEh5cGVydmlzb3IgZm9sbG93cyBzb21lIE1JU1JBIEMgY29kaW5nIHJ1bGVzLsKgIFNl ZSAuLi4gZm9yDQpkZXRhaWxzLiINCg0KYmVjYXVzZSBvdGhlcndpc2UgdGhlcmUgaXMgYW4gaW1w bGljYXRpb24gdGhhdCB3ZSBmb2xsb3cgYWxsIHJ1bGVzLsKgDQpBbHNvLCAiWGVuIFByb2plY3Qi IG1pZ2h0IGJlIHRoZSBuYW1lIG9mIG91ciBsZWdhbCBlbnRpdHkgbmFtZSwgYnV0IHRoZQ0KaHlw ZXJ2aXNvcidzIG5hbWUgaXMgWGVuLCBub3QgIlhlbiBQcm9qZWN0Ii4NCg0KPiBkaWZmIC0tZ2l0 IGEvZG9jcy9taXNyYS9ydWxlcy5yc3QgYi9kb2NzL21pc3JhL3J1bGVzLnJzdA0KPiBuZXcgZmls ZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi5jMGVlNThhYjI1DQo+IC0tLSAvZGV2 L251bGwNCj4gKysrIGIvZG9jcy9taXNyYS9ydWxlcy5yc3QNCj4gQEAgLTAsMCArMSw2NSBAQA0K DQpBbGwgU3BoaW54IGNvbnRlbnQgbmVlZHMgdG8gYmUNCg0KLi4gU1BEWC1MaWNlbnNlLUlkZW50 aWZpZXI6IENDLUJZLTQuMA0KDQpzbyBpdCBzcGVjaWZpY2FsbHkgY2FuIGJlIHZlbmRvcmVkL3Rh aWxvcmVkIGJ5IGRvd25zdHJlYW0gZW50aXRpZXMuDQoNCj4gKz09PT09PT09PT09PT09PT09PT09 PQ0KPiArTUlTUkEgQyBydWxlcyBmb3IgWGVuDQo+ICs9PT09PT09PT09PT09PT09PT09PT0NCg0K QW5kIHRoZSBwcmV2YWlsaW5nIHN0eWxlIGlzIHdpdGhvdXQgdGhlID09PSBvdmVybGluZS4NCg0K PiArDQo+ICsqKklNUE9SVEFOVCoqIEFsbCBNSVNSQSBDIHJ1bGVzLCB0ZXh0LCBhbmQgZXhhbXBs ZXMgYXJlIGNvcHlyaWdodGVkIGJ5IHRoZQ0KPiArTUlTUkEgQ29uc29ydGl1bSBMaW1pdGVkIGFu ZCB1c2VkIHdpdGggcGVybWlzc2lvbi4NCj4gKw0KPiArUGxlYXNlIHJlZmVyIHRvIGh0dHBzOi8v d3d3Lm1pc3JhLm9yZy51ay8gdG8gb2J0YWluIGEgY29weSBvZiBNSVNSQSBDLCBvciBmb3INCj4g K2xpY2Vuc2luZyBvcHRpb25zIGZvciBvdGhlciB1c2Ugb2YgdGhlIHJ1bGVzLg0KDQouLiBub3Rl OjoNCg0KYW5kIHRoZW4gd2l0aCB0aGUgdHdvIHBhcmFncmFwaHMgaW5kZW50ZWQgdG8gYmUgYSBw YXJ0IG9mIHRoZSBub3RlIGJsb2NrLg0KDQo+ICsNCj4gK1RoZSBmb2xsb3dpbmcgaXMgdGhlIGxp c3Qgb2YgTUlTUkEgQyBydWxlcyB0aGF0IGFwcGx5IHRvIHRoZSBYZW4gUHJvamVjdA0KPiAraHlw ZXJ2aXNvci4NCj4gKw0KPiArLSBSdWxlOiBEaXIgMi4xDQo+ICsgIC0gU2V2ZXJpdHk6ICBSZXF1 aXJlZA0KPiArICAtIFN1bW1hcnk6ICBBbGwgc291cmNlIGZpbGVzIHNoYWxsIGNvbXBpbGUgd2l0 aG91dCBhbnkgY29tcGlsYXRpb24gZXJyb3JzDQo+ICsgIC0gTGluazogIGh0dHBzOi8vZ2l0bGFi LmNvbS9NSVNSQS9NSVNSQS1DL01JU1JBLUMtMjAxMi9FeGFtcGxlLVN1aXRlLy0vYmxvYi9tYXN0 ZXIvRF8wMl8wMS5jDQoNClRoaXMgd2FudHMgdG8gYmUgLi4gbGlzdC10YWJsZTo6wqAgU2VlDQpk b2NzL2d1ZXN0LWd1aWRlL3g4Ni9oeXBlcmNhbGwtYWJpLnJzdCBmb3IgYW4gZXhhbXBsZS4NCg0K QWxzbywgdGhlIFVSTCB3YW50cyB0byB1c2UgdGhlIGV4dC1saW5rcyBwbHVnaW4uwqAgU2VlDQpo dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAxOTEwMDMyMDU2MjMuMjA4MzktNC1h bmRyZXcuY29vcGVyM0BjaXRyaXguY29tLw0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed May 25 12:27:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 12:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337218.561749 (Exim 4.92) (envelope-from ) id 1ntq6O-00036J-JG; Wed, 25 May 2022 12:27:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337218.561749; Wed, 25 May 2022 12:27:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntq6O-00036C-GB; Wed, 25 May 2022 12:27:00 +0000 Received: by outflank-mailman (input) for mailman id 337218; Wed, 25 May 2022 12:26:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntq6N-000366-Jl for xen-devel@lists.xenproject.org; Wed, 25 May 2022 12:26:59 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f109ce91-dc25-11ec-837f-e5687231ffcc; Wed, 25 May 2022 14:26:47 +0200 (CEST) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 08:26:54 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN6PR03MB3486.namprd03.prod.outlook.com (2603:10b6:805:44::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 12:26:53 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 12:26:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f109ce91-dc25-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653481617; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=g+ltSAf0hNsTH42IPXobA/Xf5mHRQIriahmyN3iiPhk=; b=XSHL03MONo4TChZe7TCK0T4UmDmV6jLnUn1Fl1LQppZ3r7ciwlihT6dY ezNhxCKvU8LnsKZpHPThjVShWFQbHO3FzYHJYjVYDNmViiEaQ8dwxDCis RwhJ2WvZh/kvp+olvy5RKtfGO5MeRBoiGAGDKmFeCiPm7lu7CtZ5iwN5F Q=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 72138993 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:NDWApawNakRQJ80cnFd6t+f4xyrEfRIJ4+MujC+fZmUNrF6WrkVUz TceD2qGbquMZTbxc9siaoyypxsEu5/Wy9IwTgporSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY124XhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplkZWqRhoKBP31iuE+dRt+Lh4iHIhs5+qSSZS/mZT7I0zuVVLJmq8rKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtadHeOWure03x9p7ixKNd/Ya 9AUdnxEaxPYbgcUElwWFIg/jKGjgXyXnzhw9wjM/vpmsjO7IApZgYD3Ntb8XNa2X59Ohledv T3/9E/fDURPXDCY4X/fmp62vcfNgCf6VYQ6BLC+sPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0 zehtd7zGSZmtrHTbHuH76qVthu7Iy1TJmgHDQcfUQYL6t/k5povhxjCStJiFq+dntzxGDfgh TuNqUADa647iMcK0+C+4grBijf1/JzRFFZpuUPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytalUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:VmSI7qnKhx+AyMHNACXCdl1Q1C7pDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe q1NdZfH+LjRFGebLp04w== X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72138993" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5k9i+/o7tH8ImyXFmOb1ZgsFqQGFymI04YHU3LL+m4q71l3P82TMoh3BMbf5EN+scSoXmbspMYy9oD1aCjFoyce799VlWq0aP7MayQW998ZRatvY3wIgrplG4owMehQ6QkU6QKWHmNVFTgWNZO3moE5WE2xlFM9nlZgG+JPrBxH3lfGg80uBfVPiFTRNegf8r2oursaGuNHximk5yOCa7+Sr0Z64umAZ8eiPoLR3UNaejgIa4SeetoS7x9bQl0Dhz+Tcrkdlp43vp3AsvZZHaFzWPQJbCaXOnHyI9cJ2Ekwaa/c5f1xlwKB+Wyyl0zYnuiOOMj0NtVwMmOMJltiqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g+ltSAf0hNsTH42IPXobA/Xf5mHRQIriahmyN3iiPhk=; b=cola90yrugN5ZiImIVAGNy8c2l8et5MgDFiKC4pBhe/+yFN7AoA+CpvgGqG9WH3iHupRoNl04B5MVYgpag3NunkwB8oKjz5mkCEWOS9x9MMjH6+hulUf/wbso071IWtElsca0hz77gRK6nyllDFSuKKfSqsSyUQ9vonmBqmN2qGdvK2R4TmJehFJuRC5vco8k3Hxyc/+E/RbdGqiUDljagMsiI7pDHEOvKUIitdtTeVyyYkCvP4fMr9sybrnGm6LalFDWQXshRl8Ay+y0yy2CfgtNWVyOV495xWaK/5G43Nd82rnEz/1TpQYQrmT14ZIEjBuFluT+pseOFSkxfHjTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g+ltSAf0hNsTH42IPXobA/Xf5mHRQIriahmyN3iiPhk=; b=v8zdGRCw+PWn6MsJxp6IBw/dF0FAwrcPD1FAVzZKVoq4ZKdP1t/rSfuyAS48/Oa0+KM4iLJRSgC/dhBMDdki11CgY0SZDQyh+A8zI8LfexJmV220S8HfcszDPQVgbOIwYflxKfYu/fp4iq8lPwpvfUeJDC3iT9LKs/7nk+TWoHs= From: Andrew Cooper To: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" CC: "jbeulich@suse.com" , Roger Pau Monne , "Bertrand.Marquis@arm.com" , George Dunlap , Stefano Stabellini Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 Thread-Topic: [PATCH 2/2] docs/misra: add Rule 5.1 Thread-Index: AQHYb89TxrziQNGv2kS6zZB5pXc3gq0vNeEAgABP7QA= Date: Wed, 25 May 2022 12:26:53 +0000 Message-ID: <875b1cc9-acd1-1790-c2b4-065421e1ed78@citrix.com> References: <20220525003505.304617-2-sstabellini@kernel.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 18ad12bf-82d1-4af9-e85a-08da3e49d9ab x-ms-traffictypediagnostic: SN6PR03MB3486:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srQkCaJKrmhgCNxp8hIx13jY3jslA2+uPxxkOduuore+lqTE56JBuSWyDb0quC/2NkzygJuLFd1TCdevrUZdimpM9HKbH9UpdeYgLxscHVfX64WvACy3LDroeDg34Y17w3pcUuNucQ3p9TW13kseReU54ot1zIHZV2mEGVwC9HhKI3G/XN4pBEDrBwrBl+izImBk2JioZiUThI3Ca+iStBPrKhnLlt9otqbkUpPsgScgF8KiisH7XDaiVcbA3Fdg9i9kncxuYF6SVWj3SxUOT0IxX2IGjt6mA/SKC+a6IPawW9wyU86dEA2HsMdr0Dcy48NJpOUCzzd0fHLZn5pWP+lmJBYF2bVL0n9SofsBOAQCJGvTG9dCHT56M6s2Cp9alXJkIY6TNaqw5Mhrnlo9qXRDhV8N0pz/EphRbTG0fZBwTNA4RJu6BC9o7gu3nNYSzzRZTr0kDy4D74M8191OdoFEuL68sFxa5IsyDcBlGMouphqMst/U/RswHdKIhY1llo8h1zpz6cKTyoYPLP4QIccFRYyopwd2AESVJ02UyiqOdpSMEZfFXPdOSEx/SZx7Y/6oO28O1rgExlAwp/mmrg5bRNLtpy1c4kcYgDdn2zgAi4iZEzpncxLYl0rda8nfg4z7I+EimkKIPw0x7HJZ2VIeTV+3ZsNN9RxdHZzI84BhrCWOEN2IhVS/zRHlqSJdwMxc+vpmOvwyFX1mohCReAPWhqsZ4HCNN70aUcVC6Cg2VFoPeEP3GO5Eebc02PeSkonT5ZqDxO/4i0me8yJp5Uhz6cqv8mnQzNibRnif8p22e09hrdizS2nvbHnEhFSw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(53546011)(83380400001)(186003)(26005)(2616005)(4326008)(6506007)(4744005)(5660300002)(508600001)(8936002)(6486002)(38070700005)(86362001)(31686004)(36756003)(6512007)(66946007)(66476007)(64756008)(66446008)(76116006)(91956017)(8676002)(71200400001)(122000001)(2906002)(38100700002)(31696002)(316002)(82960400001)(110136005)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZFNUbDByZ1g0bjk5aUtFTXRFNTlaamxmYVczWlFWcU5JQzBMbElyQ3VrVko4?= =?utf-8?B?SzRzbWw4QUlFQk0rTjJIK2dHenB5dlVtUmRxakcwbGI2d1RUZk5rRnhGd0xQ?= =?utf-8?B?NU45V3YvSkY5ZXdVQzJ6TEFNL1JMRlVzdXdrclcreUdoZkp2eDg2cThvMmlo?= =?utf-8?B?b2xVRktlc0RoOStVMXhUNkowcUR4VFJPNjlvb25zVUoyV2krQXNMa0JyeFd6?= =?utf-8?B?WEE0MW9leEhVQUI3S3habTBEd3NNUWZWWWxaYVd1bC9lM2E1MnducExmbFFC?= =?utf-8?B?OFV2N3NKQ0poMGJZRzRJZjF3N0hMQno1bGh5eUZCMTFVNnZ4SVpMeVd5UkVs?= =?utf-8?B?c2tTdWVCRkE1Q3ljaXNacDlwaG1Jd1MzS3B2UFZnZGZEdU5OWmI2V2svOHFS?= =?utf-8?B?cFNnSk1iL1pidmJCZjFpU1duZUxJVGJVdWJXVFVlQlQyMlovWTBjbGpZMDl2?= =?utf-8?B?emFvb255LzA1K0NvK1NUblRLMjFsMDMveWJkY1pUOFJpcVN1eXd2U2xGRU9w?= =?utf-8?B?eDBYOVQ3d2ZPeXV2YnBFYVhDa3FKRWQxYkl0aXp6NXMvb0gvOTdVdW1zRXB2?= =?utf-8?B?OWlPQVRYL3BFNEtXblFSRmE1Unl6c3VtcGpKcThUbzNLUXBuaGJlckJOYmN2?= =?utf-8?B?SUs0S2tLMENScXZSamUvNVR0RlFoSDZRVlNlblhJSXg2ZEwrd0w2TGhVYzhQ?= =?utf-8?B?OXFzUTJWcHVSQWhPbElCbkN2WmpCc3NjNkxjREF4ZWgvYWJhdEtyVDByaWYv?= =?utf-8?B?c0NyUVlvY1pRaGRGQ01mSTdxSk1MZ0lDVkNjQlVOT1ZyK3NDN2kwVVN3UEFG?= =?utf-8?B?QnRVTjMzejMzdFNqQWF6WWlpWS9QSkFOQ1orbTVmdXVLV1N5Und0WTR2dFJv?= =?utf-8?B?NHE2L1laOVpVYlpJT28rMXNiNWwrOHkxTnZ2VUtIZHJRSisranZWUnA1b0wr?= =?utf-8?B?WUNoQktkL0lVRUpvanV4TlVhbUNWQjNmWHd2Z1dQcUtlRDl5cHNHem9NNTZn?= =?utf-8?B?OVJHWjEwa1g0VDljR3ByL2JYOVphK2VMM2pBOFlCUTZNREhvdnJsZ2V3eTZB?= =?utf-8?B?Q0wxZDdWL295R2JUM0RsSk9tR29zUklqcHBqR1UvREVmclViU2FxeTVZZjll?= =?utf-8?B?eDFldWZ2RURMYzExVHJaZTVZZjdXQ0ZnaS83YzRmZ3FuSWtCZVhwaXJub0ph?= =?utf-8?B?L0VDL2RRK1JyS2oyMHBQNHpnaGRCL1dwWDZ5ZGI1c3YxWm9yK0JUZW1OZXpk?= =?utf-8?B?Yy8yUTVkYnptTklwZDJXd1NNcnZzNzk3MThEZHh4TDJNQVYvZ0djeEFuY3Uz?= =?utf-8?B?WndPd3NrWHlpSkYzOUJWSFpXZjFaVHp1ZVFLLzFsY0R6a1Nqd1hUM2hKNzkv?= =?utf-8?B?RnB0c0FQQnVjcSsxL3ppU0lIWVdQeDBIeDFLdlIxK0p6NnRwQTRnaVFVQXhh?= =?utf-8?B?Mm9nZ1J2T0doUVIvU2RGQmluOHFTS0JWMjBSVmFSZi96alEwVHhFRE9jMzZz?= =?utf-8?B?Rk4wU1NEYTFtNXZFbjJSQmhmako2S3JnYkhLZHNRbFd1UXFsRk42U1pQVXc5?= =?utf-8?B?Z0ROUUc3VVpya2JQUFNHcEpLNlgyNFJsZThqdThIWG9WY0xiQTBKWGUzak50?= =?utf-8?B?Rm9DQjJmVndxSFovMnFxQ01Na0l1L3Y0d2ZqR2dDdWYwVnlwV2JWS3pEMGhu?= =?utf-8?B?K1U4OXN5RHNXVEZ6YW9JY0hOT2o5d0ZtVm16dUJXYTZWUnp0dVdacFVrditO?= =?utf-8?B?dkJBdTdoWnQrbVlWVmlJSmRsanNOUW9jSXFnYVpSY0c3Si83SzBOM2M1cG13?= =?utf-8?B?Tjh5cXd3NUl4UEsvZ0tKTzlMbGFiODZqQ3dYYVhOeVBUZkdzeEFEL2hFR0JB?= =?utf-8?B?Ykk5RmlNSjdxeW11ZjAvY29Pb3NaL3Jibm0vSjd6Mms1QU9XemU5Ri9sNTlm?= =?utf-8?B?T0VqejJNU2p2VkpqclJ5bk1TNUF4cE5DNEorWmt0WmV4L0w0L2t5TEJSdm56?= =?utf-8?B?UEo0V3RFd201RjNsYUxER1piYzhkWWd5Vld3ODJHVEd5eG5LamdvUkszOW9a?= =?utf-8?B?V3ZFcVByUmNkSk96TEJ6ZWJkV2Q5dUxDTnB6eHR2K1VvU21LcDQrNEx2Sk1k?= =?utf-8?B?My91LzJyMnA5azM1VWVsV0xxeHRGWWhjSFgxZHIzc202STl0RG5OQkt2UE1T?= =?utf-8?B?bzVERzZjenlDa1RtZ1BoT1JqK0FycWJTbkM4VnpYOUlFZnV1aVlobEpIQThR?= =?utf-8?B?WWV5Q3Q2UjF1Qm90RXFJSHFGbHFWdlg0WXg0OTZXNjNZNll2U3dySERYWGhN?= =?utf-8?B?eXQ1T25Hd0U5YVFrWktyTXpXemI2ZG5KbFQ1YysrcEorUXQrcmJIcUlZMmNx?= =?utf-8?Q?1qxQVVV0t+KIKKn0=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18ad12bf-82d1-4af9-e85a-08da3e49d9ab X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 12:26:53.1334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wdxDsXgTvpaJhFrbEQEQv3T3zx19ekkw0H8T45UVA39mTfAp8coeMtNn66rCEtAYMfuJnJFB8ca6Fvk50bS/XLUsyyGqdEq+D1OuO5JW7/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3486 T24gMjUvMDUvMjAyMiAwODo0MCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSwNCj4NCj4gT24g MjUvMDUvMjAyMiAwMTozNSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4gRnJvbTogU3Rl ZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4+DQo+PiBB ZGQgUnVsZSA1LjEsIHdpdGggdGhlIGFkZGl0aW9uYWwgbm90ZSB0aGF0IHRoZSBjaGFyYWN0ZXIg bGltaXQgZm9yIFhlbg0KPj4gaXMgNjMgY2hhcmFjdGVycy4NCj4NCj4gNjMgaXMgYSBiaXQgYW4g b2RkIG51bWJlcnMuIFdoeSBub3QgNjQ/DQoNCkJlY2F1c2Ugb2YgdGhlIE5VTCB0ZXJtaW5hdG9y IGluIGEgcG93ZXItb2YtMiBidWZmZXIgaW4gdGhlIGNvbXBpbGVyLsKgDQpUaGF0J3Mgd2h5IGFs bCBvZiB0aGVzZSBzcGVjIGxpbWl0cyBleGlzdCBpbiB0aGUgZmlyc3QgcGxhY2UuDQoNCn5BbmRy ZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed May 25 13:16:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 13:16:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337228.561759 (Exim 4.92) (envelope-from ) id 1ntqsE-0008Bu-G3; Wed, 25 May 2022 13:16:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337228.561759; Wed, 25 May 2022 13:16:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntqsE-0008Bn-Ck; Wed, 25 May 2022 13:16:26 +0000 Received: by outflank-mailman (input) for mailman id 337228; Wed, 25 May 2022 13:16:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntqsC-0008Bd-Ou; Wed, 25 May 2022 13:16:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntqsC-0000oF-LW; Wed, 25 May 2022 13:16:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntqsC-00041Z-5b; Wed, 25 May 2022 13:16:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntqsC-0007oG-5B; Wed, 25 May 2022 13:16:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2XGzYoC4w2HeQK0cMSBA4/uyTBhE1pSDcTzb0OX0zb0=; b=k/fG0vBhxiSEShEiiV+26qpF0U rHTeeRT86nXZR7GSAv6tzhxKXTpJHcQ5QJdfLJ5zyOJm2jz1VUwEeTbUIkySxy2IwJk1QHYtmz6Zv lAo8NtCneoemlzxPi9W/TjmGuwkLCiNJ+3YyciIwRL9s9E4zNoC31VHfL9efTrGZM2gY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170725: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b22db3fcba1a5b4f9e563b58d402f1d5c434209f X-Osstest-Versions-That: xen=49399b101e38fb2c11478c849ffdaaace8e318a8 From: osstest service owner Date: Wed, 25 May 2022 13:16:24 +0000 flight 170725 xen-unstable-smoke real [real] flight 170727 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170725/ http://logs.test-lab.xenproject.org/osstest/logs/170727/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail REGR. vs. 170719 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b22db3fcba1a5b4f9e563b58d402f1d5c434209f baseline version: xen 49399b101e38fb2c11478c849ffdaaace8e318a8 Last test of basis 170719 2022-05-25 00:00:26 Z 0 days Testing same since 170725 2022-05-25 09:01:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b22db3fcba1a5b4f9e563b58d402f1d5c434209f Author: Julien Grall Date: Wed May 25 09:52:38 2022 +0100 xen/iommu: dt: Check the return value of xsm_deassign_dtdevice() xsm_deassign_dtdevice() will indicate whether the caller is allowed to issue the operation. So the return value has to be checked. Spotted by clang static analyzer. Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to support DT device") Signed-off-by: Julien Grall Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed May 25 14:13:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 14:13:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337239.561773 (Exim 4.92) (envelope-from ) id 1ntrl1-0005fe-T0; Wed, 25 May 2022 14:13:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337239.561773; Wed, 25 May 2022 14:13:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntrl1-0005fX-Om; Wed, 25 May 2022 14:13:03 +0000 Received: by outflank-mailman (input) for mailman id 337239; Wed, 25 May 2022 14:13:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntrl0-0005fR-Dy for xen-devel@lists.xenproject.org; Wed, 25 May 2022 14:13:02 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c71b5a5a-dc34-11ec-837f-e5687231ffcc; Wed, 25 May 2022 16:13:00 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653487972668809.1500672546416; Wed, 25 May 2022 07:12:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c71b5a5a-dc34-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653487976; cv=none; d=zohomail.com; s=zohoarc; b=iaUX9h7pEagIRwWB744cH8QK8Z4IwVm1QIMe6aAPey8kA0e53FtEYYX7tG0Vd02uEn8hPgyLaD3BpiG4My4UzFgkEnSzV5DvAQRRXfFQrnHzu91BBm7wWHyQQwDrtRUIZfK6OPogf669ujYEd3vNwYNXmit76nbRV/35k8mZiz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653487976; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=nnn6qdW5xichgRN3JAFkNZ4sj2skJaVWwMhoN/+fSpk=; b=agu/rkp6Lq7krhzdyGkv7n71Xjk2GVN5g6nqW3sfG+Jiqry1ALIlDD3vErLYtMbqdT7bpk1R7dVr25j/ucgExSnWigJdZPMZZ3cb9XHL0rNnIycUOBnBFex0BHmowV6bs7V5A5Al3MP6DqPUgd6DnEh5jxHvs7XR4kvCU7nD650= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653487976; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=nnn6qdW5xichgRN3JAFkNZ4sj2skJaVWwMhoN/+fSpk=; b=BmLeMaHFP3v0+BmC+KoeWq1XFIqV/H/qiOxPrcPAxjeKExdfb9B+jWLJebA/XzO2 3/XjW29yh6/W5TGX+UXU3fraRuj8FsT17r38zU2+j4INTylj02r0wbu5Ti7uxBBjDom S8dLhrnB9cckgs9eEpgDPH/2alOp4/IcHXvC02/8= Message-ID: <4d3a8914-a505-230c-5807-8ca295c3b60a@apertussolutions.com> Date: Wed, 25 May 2022 10:11:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220523154024.1947-1-dpsmith@apertussolutions.com> <8aebc234-e870-9435-9f60-3c06013421d9@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH] xsm: refactor and optimize policy loading In-Reply-To: <8aebc234-e870-9435-9f60-3c06013421d9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/25/22 02:37, Jan Beulich wrote: > On 24.05.2022 19:42, Daniel P. Smith wrote: >> On 5/24/22 11:50, Jan Beulich wrote: >>> On 23.05.2022 17:40, Daniel P. Smith wrote: >>>> @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( >>>> { >>>> int i; >>>> module_t *mod = (module_t *)__va(mbi->mods_addr); >>>> - int rc = 0; >>>> + int rc = -ENOENT; >>> >>> I'm afraid I can't easily convince myself that this and the other >>> -ENOENT is really relevant to this change and/or not breaking >>> anything which currently does work (i.e. not entirely benign). >>> Please can you extend the description accordingly or split off >>> this adjustment? >> >> Let me expand the commit explanation, and you can let me know how much >> of this detail you would like to see in the commit message. >> >> When enabling CONFIG_XSM_FLASK today, the XSM_MAGIC variable becomes >> defined as a non-zero value. This results in xsm_XXXX_policy_init() to >> be called regardless of the XSM policy selection, either through the >> respective CONFIG_XSM_XXXXX_DEFAULT flags or through the cmdline >> parameter. Additionally, the concept of policy initialization is split >> between xsm_XXXX_policy_init() and xsm_core_init(), with the latter >> being where the built-in policy would be selected. This forces >> xsm_XXXX_policy_init() to have to return successful for configurations >> where no policy loading was necessary. It also means that the situation >> where selecting XSM flask, with no built-in policy, and failure to >> provide a policy via MB/DT relies on the security server to fault when >> it is unable to load a policy. >> >> What this commit does is moves all policy buffer initialization to >> xsm_XXXX_policy_init(). As the init function, it should only return >> success (0) if it was able to initialize the policy buffer with either >> the built-in policy or a policy loaded from MB/DT. The second half of >> this commit corrects the logical flow so that the policy buffer >> initialization only occurs for XSM policy modules that consume a policy >> buffer, e.g. flask. > > I'm afraid this doesn't clarify anything for me wrt the addition of > -ENOENT. There's no case of returning -ENOENT right now afaics (and > there's no case of you dealing with the -ENOENT anywhere in your > changes, so there would look to be an overall change in behavior as > viewed from the outside, i.e. the callers of xsm_{multiboot,dt}_init()). > If that's wrong for some reason (and yes, it looks at least questionable > on the surface), that's what wants spelling out imo. A question then > might be whether that's not a separate change, potentially even a fix > which may want to be considered for backport. Of course otoh the sole > caller of xsm_multiboot_init() ignores the return value altogether, > and the sole caller of xsm_dt_init() only cares for the specific value > of 1. This in turn looks at least questionable to me. Okay, let me change the view a bit. The existing behavior is for xsm_{multiboot,dt}_init() to return 0 if they did not locate a policy file for initializing the policy buffer. It did so because it expected later that xsm_core_init() would just set it to the built-in policy. BUT, it also served the purpose of succeeding if it were called when either the dummy or SILO, neither of which needs the policy buffer initialized, is the enforcing policy. This change starts with moving the lines that set the policy buffer to the built-in policy into xsm_{multiboot,dt}_init() respectively and only return success if it was able to populate the policy buffer. In other words, if there is not a built-in policy and a policy file was not able to be loaded, it returns -NOENT to represent it was not able to find a policy file. This change makes these functions do as their name suggests, to initialize the policy buffer either from MB or DT with a fallback to the built-in policy otherwise fail. Upon making the function behave correctly, it exposes a valid set of conditions that under the current behavior succeeds but will fail under the correct behavior for xsm_{multiboot,dt}_init(). With flask enabled in the build but not the built-in policy and either dummy or SILO is the enforcing policy, then xsm_{multiboot,dt}_init() will be called and fail. This is where the second half of the change comes into effect, which is to introduce a gating that will only attempt to initialize the policy buffer if the enforcing XSM policy requires a policy file. With this gating in place, under the above set of conditions xsm_{multiboot,dt}_init() will not be called and XSM initialization will succeed as it should. Now to your question of whether these changes could be split and given a focused explanation in their respective commits. Yes, I can split it into two separate commits. While the gating of the call to xsm_{multiboot,dt}_init() is an independent change, the change to xsm_{multiboot,dt}_init() itself is not and must proceed after the gating change. This means it is possible to backport the first commit, gating, independently. If the desire is to backport the second commit, xsm_{multiboot,dt}_init() behavior, then it would require both commits to be backported. I hope this helps better clarify my reasoning and if you would like to see the changes split how I highlighted, just let me know. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed May 25 14:33:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 14:33:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337247.561785 (Exim 4.92) (envelope-from ) id 1nts4e-00081o-Hy; Wed, 25 May 2022 14:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337247.561785; Wed, 25 May 2022 14:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nts4e-00081h-FB; Wed, 25 May 2022 14:33:20 +0000 Received: by outflank-mailman (input) for mailman id 337247; Wed, 25 May 2022 14:33:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nts4c-00081b-JU for xen-devel@lists.xenproject.org; Wed, 25 May 2022 14:33:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c23a575-dc37-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 16:33:16 +0200 (CEST) Received: from mail-dm6nam08lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 10:33:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN7PR03MB3794.namprd03.prod.outlook.com (2603:10b6:408:2f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Wed, 25 May 2022 14:33:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.023; Wed, 25 May 2022 14:33:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c23a575-dc37-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653489196; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=AOo5nijY1u8TBtG0yW8aJXoOG2wZlRWmGERCTzrYVec=; b=QFBJFMTEk6Oo0Ofvn55d6EvtGM1Xl+3KdUpOu41zWdZKtVfIXD9oiATI kk/lXwvzre6gW08I1w3kg4I+4AaKTnDsryQPIxLtrrHUwv8d1HLsxmRZB SVnjLejaCKwrv4Rz5M+DzDTkKOVfWlsJ4r760iW/0wGV7d6h32LnH1Be3 w=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 74677368 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ul2OxqvdWUshDPN6/PCy4iGeROfnVCZfMUV32f8akzHdYApBsoF/q tZmKT3TM66JMzf3e98lPt+0oBwBvJODyIUwGVFoqi5kRS0a+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17X5 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8pMZPWpcMyCyV9MH5UJYF20rvfEUWW5Jn7I03uKxMAwt1IJWRuYcg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4ADmmtr7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJovzaMk1cvgNABNvL4Q8C3dcF0xH/F+ G6bxXzrXiMmBuCQnG/tHnWEw7WncTnAcIAYGaC89/VqqEaO3WFVAxoTPXOkpdGph0j4XMhQQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l90bPywOQB2xBQjsfbtUj7J8yXWZyi gTPmM71DztytrHTUWia6rqfsTK1P24SMHMGYigHCwAC5rEPvb0Os/4Gdf47eIbdszE/MWuYL +yixMTmu4gusA== IronPort-HdrOrdr: A9a23:POXz9quBj7srALf0VZiYYe8e7skCL4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPuftXrdyRGVxeZZnMTfKlzbamDDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjIzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIO/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfqWG0hYczBgNkGmpDq1L8Yqq iKn/7mBbU015rlRBDxnfIq4Xi47N9h0Q679bbSuwqfnSWwfkNHNyMGv/MZTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIIO5gLZvin+9Kq1wVR4SKbpXYt VGHYXZ/rJbYFmaZ3fWsi1mx8GtRG06GlODTlIZssKY3jBKlDQhpnFojvA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVbHMX6UI17gCKYbUki94KLf8fEw/qWnaZYIxJw9lN DIV05Zr3c7fwb0BciHzPRwg2fwqaWGLEDQI+1lluhEU+fHNcvW2AW4OSMTutrlpekDCcvGXP v2MI5KApbYXB7TJbo= X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="74677368" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wbp6pdtb3k6bCtop+bDTBZfXzn0vpoCHT//GmvNO1Jlmj42CkoEd1eJEKFCC2Ek75RYYGqMQ5PYRSzai4KZRqlGD77YJglY6btrrbUgvbG3hnudOdwwz8+DZ9LV1yBxxo1ZbanZv0nWJzOR+m/SGN/doSLe0QuvbxpcWSPAB4RW3OfS5s3leIzdEeDQJOeGPcjN2GGSNrTtksGtnnsTk+13/qyb7DQNTZMW5WmHtQrHDs6eTyKnCzHhdtr5RbMYqRL4M7TXLqM5FI7z6GIXDDH8GMpv3j27iv5Hs8PLRLNqr2u4mm2c6qfa4IDPU1GsD4qy3iq+9U//tJ13zbmXv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AOo5nijY1u8TBtG0yW8aJXoOG2wZlRWmGERCTzrYVec=; b=GNg6oz3DJSxxqM9gMhoolCYlPMxAiKsHXd9P9VPAen4vA+vuJPcVQBjHCoO0PF4QrCM/ZwHjmM8s0VmpxQ9rTfak6qQ4V+KzIJ1ym9Vqw/8d+7mDqI/FwZ7KroX61QE0K44PVk8usV+CejueqTqce9dqG1TIAj1PB63VDHVe7esmbIlxjy7uPua/eWRnf8WNw5eJJ3fF/Fa3MFpP2G4XGF75efye76XSubeSqc5FIv19Kec0NkxjVoJWn9rcBZZ7ebbUDOv908nZnI7tpVtKaKp+1tBlMS5EaaHsTciF6g2pY5HNC6nYWCzXIgUv42BS+3aEcNlxoc5uTbL0rc1J8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AOo5nijY1u8TBtG0yW8aJXoOG2wZlRWmGERCTzrYVec=; b=UvKXga5e0xtqscM4p25puQh6gWb1lu/gGRovQNtIQH/elCcH8GdViUT3aVsZh6qAhu6nN8vzSnPTiCMU3CkeGfkf/zEmF7HvooYez5oBZeW+naeTzI6l57ZJvwnSn3vwq8bmYjmVnEBOZ4NLNHD/RrC1ctwJI2FGZHbqB7ss1iQ= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , "xen-devel@lists.xenproject.org" , Roger Pau Monne Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Thread-Topic: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Thread-Index: AQHYcA9OnQ9W6lKd/EmmrY4D8odolq0vawYAgAAGBACAADeDgA== Date: Wed, 25 May 2022 14:33:01 +0000 Message-ID: <4bd5d8b5-80a2-8f7c-c117-5c027d8e8f34@citrix.com> References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b92a31ca-77f7-4547-4a4f-08da3e5b78fe x-ms-traffictypediagnostic: BN7PR03MB3794:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ilWUpOKVOVuvRES3kOosoA5EEq51r9yJIjORNy4gj2y8aZm9Frwsu+lnA8i+vW0U/2KYirfEDbv8YjvRSPxfniKRuNAAPzqiAlAeM/X32YZTtSDPJYf1htRQV6iBdHphoqvjxpWD1FmL209IisPlto9PGcnXWPdTtNxVuY9N8FgKj0VBgORBw1QYnSQUhXkCg6xn+FSZPHt3ZLP0S9NqdhxpZG0B8CEYdYL/thsKABij8a7dvFL9MKtMQYCEXZNL4lBnukGIHsOPzpmQ2JUSkfkVjKJ8Q9TJYmnMvVa4A7VMYWqJnRtpX62wzog1XegRYq24Yz0p/J4UX1OheEhQoRYIGviCDKib1CcJFASs/1unPouwdoBd1k9VAyYtBEb1y6rFcaItuvJzG67yoLbPhuKMiBh0h6vdOWKJVSKtFIxZHHnKU00vXrgjzIBEd4w3m1QMHnJxnRjAn/Yu3sqypfUSNzrkegfIe4qNQDE7t0RpQCCnDYOvGVMMZjRF7fzDgrLxTbrp/yWwtPd1sp3xqFGfBTcpHLlpkuJIDmVOtvWdXjO260oYyMRnxzHxqKKVotJNNYKvxZctbjejNX71UMNOEDgecX6DRQzQi51XpBD9aEbd1CWqxA3M2yq2uDMywJSPmBy7NOLseAgl3Y/0gXsBeZjhFqB656jg+r7D0UJtpbWFgTmHY2WI4v0dYgULDP/sSsObFC6GYKRFuru7BsGWRE6Ier40isN6RAUP/lnlAfHuQZV8m9L7Y3tekPkfz6O16LZzHlwtUKFjWKkkzA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(26005)(53546011)(38100700002)(31686004)(6486002)(6512007)(64756008)(508600001)(36756003)(82960400001)(4326008)(122000001)(38070700005)(2906002)(83380400001)(66446008)(186003)(8936002)(2616005)(5660300002)(316002)(6916009)(86362001)(54906003)(31696002)(71200400001)(76116006)(107886003)(66476007)(66556008)(91956017)(66946007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VkRZdThPZWJvek42bTBKb1g1V01sbGtlVnMxaHJHQlNmSHdGcWFPNDl5U0pv?= =?utf-8?B?NlZwVWtFYWJEYkxLWE8yVEtlRHpwcDExR3V3OGJZT3l5azRqY0t6emJ1SCth?= =?utf-8?B?dkVEdFpUTTVwTVVrcVhyN3VZb2xpMWZQaGQxbm9pQlQ3RTlPbU9IcmRoU2NJ?= =?utf-8?B?U1JvK2tQcUd3alVxaWJYSUFXQUVLeHBQK1ByRDNtSklCcEdsbXdpTnplRjEz?= =?utf-8?B?c01QWWpwUUlZMVZEdzJ6V2hBR09wYzZrUU0vd2U0R1QrS1E0dkR6Wi8rSFBH?= =?utf-8?B?Zk1jb2NZYzNNMFpPaDNETXhkelBDMUNjMnd1cGdEWllBZFFKODc0dXp1MEFX?= =?utf-8?B?RXVhMGJmeE1OTlpXbG56Y2o1SWx1dHd0OHZzbG5MRFdRQ3JORXhWQzJ2MU9F?= =?utf-8?B?SEF0S3NHVDF6dFNaYnB1NUsyMEhaWXdkT0xqRVE0dzZjU3ZDTHM3aWViNkJu?= =?utf-8?B?aUtmTlRZeG9LS2cvZk9aRFpVL0ZJdTdpQW9FT3RveGgraEZaZ1JNbjQwbGli?= =?utf-8?B?UFB6OGNkWmxkL2pTVGRDL0dzdVpLWkV2Mk1QSXdwV0xrMjZWQkJDT2cxNkNn?= =?utf-8?B?eWZaNlliR0JhNmJhYXhzMXp6azk5M0U4T0NmZURNRWl0UW4wZjhMWkZselpo?= =?utf-8?B?UGN1OXViUzJURU1TK252OXdUSUxiQ1o0UCthZ3hISGhEUm9ubEpuV1NIWGFF?= =?utf-8?B?UXNqTm1seDUrMFN1YnJncmt1dmx0em5ERnJIZ3JyRnFTcnU2UzM0eHRtQnRn?= =?utf-8?B?dmhPR3ZxSThMenJ1TlU4ekFTc201Wk9kbVFteEJ0Zmp4dW9OTDVkQ3FUeHdR?= =?utf-8?B?cHIxZCt0d1V6c3dFRVVZL3lSZy9wdVArTEJhWGFRdStpMkQ1YTk4SFJjYnNt?= =?utf-8?B?MWpvTTZ1TXNQeHRlYlU1SlhJblg2dm9XTm5kZHU1QlZRR3Y5VTJ6L3pFcWhi?= =?utf-8?B?YXFCUVU1WnZhM3VxemVRU1JveFVJMzV5QUVYMmt6MHhUNkVRSFN0SVcvYm5z?= =?utf-8?B?MEUvenIyTHk5SVJuVzl5aEVsRXZ5ZFJRZENZMkQ3ZFdkcmgwK0NJbHR2bDEz?= =?utf-8?B?cy9QZllnaUxJSHV3M3JieXF3c0IyWHJYMG11ajNwK0ZwbXlsMUVYbXBONnNp?= =?utf-8?B?RmNSUzNLdVo0SWxYUlFsOEYrSVI5WXJKREc4Uzh5c0tNZVpFdWd5TkRzaW42?= =?utf-8?B?Z0dySGJud3cxejEvdWR1M000SFZheFJuYlErU25GaklKc09aVzdIQXgzZGdJ?= =?utf-8?B?YUNRdFh6M2lud0dVTkprRUF3MFhwNjB2ZmVBaGEzUEVnMnF0L2pPbFBDSjUv?= =?utf-8?B?WVgrYzlQUVZWZmpKMzkwaVl4emgvdWxvL21yR2x2Vm5DVmQzd0lLQll2cEx0?= =?utf-8?B?bHBJQlphdUZSeUpUSm5sdnVlVkxpMmVJWERFRWxsdzBqbVJXSU1KMnJWOGFN?= =?utf-8?B?Q2ZjVytKRXpoRlB0RDBPUC9iRktJWVlERUl4bnpKb3Rnd3ZYOU10ekxsUHdW?= =?utf-8?B?cEYvV3EvbGRFT0NDeElieU00RG5DaXJrVzJtNzNRb2FtcVdHRW50QU5UWS9T?= =?utf-8?B?TzFycWlrV1BRNy93VXNHYlQ4WWNDRXNZSTNLRm9vOFdCaFBMbTl1WGo3dTYr?= =?utf-8?B?blhqaHhWdWNta05nMEQ4TngvU08xQjFDWjVsSUhrQU5QaEdia2ZVOWNSbzQ1?= =?utf-8?B?djNvU01ySDZ0dUtmbzJDRzlEY3RRaXJ3T3BvNFVYU2FPNTY4VmJZQzU5RXR3?= =?utf-8?B?MmxWMFA4U25zNkV6RmJrYkVKOW54RktVbTlSaXRhenRkTFZrN0htNGhFbVVC?= =?utf-8?B?eVVCalk2cE01RnBMWmRMOVc0M0c0YSsrbGFmamw2QUhMaHhqaklFeVVQaWd1?= =?utf-8?B?L2tQRTlVMGJuTmlKY0gwS1UxbFhnNkhxYlZtYnpQalhmbWtnZ0hnRjdNZ3JO?= =?utf-8?B?d1NDVDFHeU5OazNmT0M1Q0VDSDRuNS9TbFRnWkYxNXpUZlBibDBSVFByc0d6?= =?utf-8?B?Q0VSdEM5T0VKRWptRnFkM1lXWGxTSWp2UzBxc3JhYWNoZTNzL0N0TXRzakFM?= =?utf-8?B?bmZDcncxYkVWRTcwa2FTaFlQdm1tZGE4R0tCNmVGSjNuVERMOXpjWUhqRkFI?= =?utf-8?B?cENzd1JFMGUrNGQxZXg1MjlYMFhhOVd4cjNnREZXdmlqeDczdUlCTkVFVklt?= =?utf-8?B?UElWWWRzTytWS054LzBsamM5UldjK0FzRHdIMjRDRVFCQUVLbVlVT0hCUlFJ?= =?utf-8?B?Q0d5S0FKT0Fub0tmNVZzd1FxK0JPc1daRVh3QnBDR2dyaEdGM3RmdnlRUFkw?= =?utf-8?B?alI2bHQ4T2FUczFiMU43TWYzcGhjY2VqbTlhWjA2RHNPNnZrYlprb1JIeHpz?= =?utf-8?Q?zuIF88Oz8UsZGcS0=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <8C3D23CCCC32944DB7155A7C5F2F5EB8@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b92a31ca-77f7-4547-4a4f-08da3e5b78fe X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 14:33:01.8911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SBxMw779dyOwt6N5TSstcjXAoY/0tndImJFBNUM+oYYcziObSgPAkzGMuRr2rg4ldLqmKvszUyM+V6/JgiCUPEEudyeZ/Y2jAHKfmp7hf+4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3794 T24gMjUvMDUvMjAyMiAxMjoxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI1LjA1LjIwMjIg MTI6NTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyNS8wNS8yMDIyIDA5OjEzLCBSb2dl ciBQYXUgTW9ubmUgd3JvdGU6DQo+Pj4gUmVuYW1lIHRoZSBmbGFnIHRvIGJldHRlciBub3RlIHRo YXQgaXQncyBub3QgYWN0dWFsbHkgZm9yY2luZyBhbnkgSVBJcw0KPj4+IHRvIGJlIGlzc3VlZCBp ZiBub25lIGlzIHJlcXVpcmVkLCBidXQgbWVyZWx5IGF2b2lkaW5nIHRoZSB1c2FnZSBvZiBUTEIN Cj4+PiBmbHVzaCBhc3Npc3RhbmNlICh3aGljaCBpdHNlbGYgY2FuIGF2b2lkIHRoZSBzZW5kaW5n IG9mIElQSXMgdG8gcmVtb3RlDQo+Pj4gcHJvY2Vzc29ycykuDQo+Pj4NCj4+PiBObyBmdW5jdGlv bmFsIGNoYW5nZSBleHBlY3RlZC4NCj4+Pg0KPj4+IFJlcXVlc3RlZC1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4+IC0tLQ0KPj4+IENoYW5nZXMgc2luY2UgdjI6DQo+ Pj4gIC0gTmV3IGluIHRoaXMgdmVyc2lvbi4NCj4+IDoowqAgVGhpcyBuZWVkcyByZXZlcnRpbmcu DQo+Pg0KPj4gSXQgaXMgc3BlY2lmaWMgdG8gSVBJcywgYmVjYXVzZSBvZiBvdXIgY3VycmVudCBj aG9pY2Ugb2YgYWxnb3JpdGhtIGZvcg0KPj4gZnJlZWluZyBwYWdldGFibGVzLg0KPj4NCj4+ICJu byBhc3Npc3QiIGV4Y2x1ZGVzIGlwaS1oZWxwZXIgaHlwZXJjYWxscyB3aGljaCBpbnZva2UNCj4+ IElOVkFMSURBVEVfVExCX1ZFQ1RPUi7CoCBTdWNoIGh5cGVyY2FsbHMgZG8gZXhpc3QgYW5kIHNw ZWNpZmljYWxseSB3b3VsZA0KPj4gYmUgaW1wcm92ZW1lbnQgdGhhdCB3ZSBvdWdodCB0byB1c2Uu DQo+Pg0KPj4gRnVydGhlcm1vcmUsIHdlIGRvIHdhbnQgdG8gd29yayBhcm91bmQgdGhlIGxpbWl0 YXRpb24gdGhhdCBjcmVhdGVkDQo+PiBGTFVTSF9GT1JDRV9JUEksIGJlY2F1c2Ugd2UgYWJzb2x1 dGVseSBkbyB3YW50IHRvIGJlIGFibGUgdG8gdXNlDQo+PiBoeXBlcmNhbGxzL3JlbW90ZSBUTEIg Zmx1c2hpbmcgY2FwYWJpbGl0aWVzIHdoZW4gYXZhaWxhYmxlLg0KPj4NCj4+IEkgYWNjZXB0IHRo YXQgRk9SQ0VfSVBJIHBlcmhhcHMgaXNuJ3QgYSBwZXJmZWN0IG5hbWUsIGJ1dCBpdCdzIGEgd2hv bGUNCj4+IGxvdCBsZXNzIGJhZCB0aGFuIE5PX0FTU0lTVC4NCj4gQnV0IEZPUkNFX0lQSSBoYXMg Y2F1c2VkIGFjdHVhbCBjb25mdXNpb24gd2hpbGUgcmV2aWV3aW5nIHBhdGNoIDIuDQo+IElmIE5P X0FTU0lTVCBkb2Vzbid0IHN1aXQgeW91IGFuZCBGT1JDRV9JUEkgaXMgYWxzbyB3cm9uZywgY2Fu IHlvdQ0KPiBzdWdnZXN0IGEgYmV0dGVyIG5hbWUgZml0dGluZyBib3RoIGFzcGVjdHM/DQoNCkkg ZG9uJ3QgYWN0dWFsbHkgYWdyZWUgdGhhdCBGT1JDRV9JUEkgaXMgdW5jbGVhciB0byBiZWdpbiB3 aXRoLg0KDQpUaGUgc2FmZXR5IHByb3BlcnR5IHJlcXVpcmVkIGlzICJpZiB5b3UgbmVlZCB0byBj b250YWN0IGEgcmVtb3RlIENQVSwgaXQNCm11c3QgYmUgYnkgSVBJIHRvIGludGVybG9jayB3aXRo IFhlbidzICNQRiBoYW5kbGVyIi4NCg0KRk9SQ0VfSVBJIGlzIHZlcnkgY2xvc2UgdG8gbWVhbmlu ZyB0aGlzLsKgIElmIGFueXRoaW5nIGVsc2UgaXMgdW5jbGVhciwNCml0IGNhbiBiZSBjbGFyaWZp ZWQgaW4gdGhlIGFkamFjZW50IGNvbW1lbnQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed May 25 14:40:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 14:40:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337256.561795 (Exim 4.92) (envelope-from ) id 1ntsBL-00014G-C7; Wed, 25 May 2022 14:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337256.561795; Wed, 25 May 2022 14:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsBL-000149-91; Wed, 25 May 2022 14:40:15 +0000 Received: by outflank-mailman (input) for mailman id 337256; Wed, 25 May 2022 14:40:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsBK-000142-63 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 14:40:14 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94bfc7f7-dc38-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 16:40:12 +0200 (CEST) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 May 2022 10:40:10 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2836.namprd03.prod.outlook.com (2603:10b6:404:10e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 14:40:06 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.013; Wed, 25 May 2022 14:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94bfc7f7-dc38-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653489612; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=AOenDSg54VBBAiUpCZJk0I1KTXaQwU1VR4zCNFs7/4E=; b=Hia0gV1wGsZ2JSbIRwu25L+PXNnW822TDOnhXKc3ymUige9WMoPru1BY SNiDPty2SMziP5T8OAm6HEp7dJ/FGqLbf6ymffkUUHFNsvv194olq8zsj 6cKnbahWHjG8LHX6ZodBO9dJBwSa+chMU9mTQydFIJdXGQ3dyBAsyGPXK Q=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 72160967 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8j5WAarnlmo6iqJ3joVFyTgSaDheBmJsZBIvgKrLsJaIsI4StFCzt garIBmPa6yINGOmeosnPY7ipE9Tu8XXyNQyTFRkr30yRSkb+JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 46q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBDJKPsb9CaEdjLx4uOPIe37DNPWCGrpnGp6HGWyOEL/RGKmgTZNdd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFgXFp2Zwm8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK//NpuzmNk2Sd1pD1DIL7U8WWH/x1m2G7l 0PizyfTOFYjYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K UYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJS1e2W4q/d4gLcDG5USDdEMYYirJVvGmBs0 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poed9e3Yq 9xSkBUDug== IronPort-HdrOrdr: A9a23:7sH3zaEtCulqVWiEpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,250,1647316800"; d="scan'208";a="72160967" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXgTY7h8AqkNpDQFRTOOUshVE0Ok5Jr0z7wOHIzB8XsO39sVTPfGZ1YTL5JOkZ/kH3igV7T7kpAeB80hBnmNr6nkZ1r8kxuxiMslGDldHPdgU/Khp0q7JXa6vLKTizpIxwY2X8RfArPUBYpn6wbUdsZAo2wu8ZAH0wCrud8ffL/daPxjrSxrTxOd60XfilaAVPrQEpZkx+mYNxIDfKTFYE1lQncghYXtpyU+NXOlghAue1l1Y5SQTvEMshS0oiFMSK8Ozi3LsJhfOqRaM980Jm3g6yUejpHxi26BJbFSfx8bRd4s7v/j4tfpZbEzW4YH9W5X8J3jQqxcnl7umnoBXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=//DGViIIewRqUuL+1svWGp0U9ClJsjRCLLvTMRLhMZ4=; b=gVpTuKGPlKegg3CBcoDbBBW/leYfKmynm019Czg458nOaJ5pvl5GvG3B9GuiCq++zTi1MXsv3y9bJozfaFpGC1SYFoeF3oUsl5BTpEoBjopUlPakELHqTeMh7mFA7rql0nMki7HGj51dPbkJiIpAFThvt23NzEU/wsglJofuv6ElaTPDF1A2aZ6a/QGW2NyM0an3fx9TiT9ENgoITqX49vYxzuucMca8xLPEe5Iu/I0cA/jDQ46xWQ/yf2prgsg2d01nBw2ed7GA+fBA1zXMImHh+GvOJGQ11THLI5zmSmqY7YQxDFCzKqaxdeHQdYEuL4Is6R02JbsJ32ZrYHZyLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//DGViIIewRqUuL+1svWGp0U9ClJsjRCLLvTMRLhMZ4=; b=Tq+FrMxeC/LtEoOWtUpkFaSca7pSeHWfhUNi1XMiRJxgbZNE8q1IyuCEwfIXK+ivYlrlO0zqS4jVLAhyh2RQLb+TszXFH5Ty4TJJFysV5i4tQhblP1xOAhD3v7S5UucTalz7Xmh6NBJeVaQcPWMSCM1zJ3eratK4JLidsJWYUwA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Wed, 25 May 2022 16:40:00 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Message-ID: References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> X-ClientProxiedBy: LO4P123CA0484.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::21) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b9a009b9-c01d-4d2f-e5a4-08da3e5c7585 X-MS-TrafficTypeDiagnostic: BN6PR03MB2836:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ypOR4EanwrIEy3V8WN1gQfb9669eMfQZ+QkkG6MurE5BNyeHztRuv/rB72dk7B4vPHahlds2MWFQvnxLnk45GbqFFR38UDm63ifxeyrbHgofHpYK2FsJPNWwp915bc42IC2pb984WvC7Up8V84iUz+04g4F81V15oiEhbYB/xgqq10b61RBnB2hrjTufSSLKYwAwW25OwGwBJQasw441t2SQiS/7UXp7+tM7/YhRG9afJ+UT88lLWl0f1OQrnG3eEWlQz+pyK0GlxoG6ra3b7etIgKI0LsVR272ARkGs0OoOCHXy8g22N6BtJAszJePkoukZc/GTXgWSorTFkAoFbLEAfONhwI9qJ6K9bcfIFcupbxZGDJJqcjDxKS2HKfQb8KVtGjfe2UnXnl0ciAp91Ts+/qcRDCrmTwebutNK3Bhqkr9pwg8PfmboamQwJECqmDuD1DAwp0TwzrY4gTU3sIEdsnfXTGME42opOZQ/FK4JvBVz9vITKF7LSptPq5newJ+bIzlLCatX74wVMefRdHzQr9X0rGP+aQLO1MzNuOEcNf8A9hD1212RwDlBA04YITrDTd3I+oX+xJcTHXKNx/dF5lmuJju1UI+PIARHS4fOhhji3gm88rEzojgPMezZjR+VFX3VK8Fz+n9cVUmd4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(66946007)(66476007)(4326008)(8676002)(6862004)(8936002)(66556008)(5660300002)(186003)(6636002)(316002)(2906002)(54906003)(6486002)(508600001)(38100700002)(83380400001)(33716001)(86362001)(6512007)(9686003)(6506007)(53546011)(6666004)(26005)(82960400001)(85182001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk04RVhUdVdqMU16SkVhM2Y0R091T0QvTklDR3hmUXFXRzRuT3M0bmx1Uk1W?= =?utf-8?B?SnltN0NreGNXSk94dmt1b1dTcVdGVWo0bjJMZlV5S1l4OTJueWJLSDdza3Z6?= =?utf-8?B?OWQyKzVSVUNtOVV6QXZuYUNUSVA5RXh3KzBzOWovNk5xWTUvUXFOTTNXK05G?= =?utf-8?B?c0dRRDZpbVlvR0dycFBmNWFVUDZTai9URFRHc3lCZGdpcVdmUURvdjVvSDdv?= =?utf-8?B?Ui9PUHVwZE9uUzhOMWxMTTh1K3ljLzhyaUJsdFVSSTRmRmRNMEtySi9ISzZ6?= =?utf-8?B?RklPeVFXdWRQazVmQXY2K3RnKzNsMGRQSjcybm5jYUpjMXVTOTRZTFJjaXAy?= =?utf-8?B?d2w0bEt5Zm15NXptbXNMWVJrdW5NWkduWmJ6UkVPNTdtejdTc1ZSWVRHYmY3?= =?utf-8?B?TnhpaFEwUElYS0lKcktkSXdwZzFvbVJyRU5BMFBIUndockxsbnlXRGFyV1Qx?= =?utf-8?B?RzFSYVN2ajVXejFUb1VJdnlISThZeWtVWUpWSWhyR0lvRmhNelJ6TkllYm5P?= =?utf-8?B?UjBMWkhQdUltWmZ3UUliRTJrZWtoZDhCVDJ1dFhOaXNjZWswZm9pRnIzc0hU?= =?utf-8?B?am1SZUZiVzd5bm1qeU84dS8wT0VRL2VoWFF1VlBvVk9vTjRVZkk1R2JSRnJN?= =?utf-8?B?UnpXTmt3VVByei9tekw2NWZLcFNSRGdsQk1ZMXVIdm9hUVB3Ymw1R2dMMXky?= =?utf-8?B?Rllqc0RKKzlKZTlVS3hLdWlVN1p0dlNzSnBqUXJOUjJEbC9QMllmQ3o2cHQr?= =?utf-8?B?a2hyWU9Ud1NxeW82VFlSa1BGL1hadllZTEtEL3hlNEdkeEdzWXZIbkRxeEho?= =?utf-8?B?Wk9ad0xONlg4VjhRUWJ0Sk5LbmZUUy9ITDk5aG5CRmtlKzZmNjBwMC9xZU53?= =?utf-8?B?blhjdVlyd29SVkpLcFBxeVJxUXhvRjV5NUpodUMzSnhieHdubFNibmtzM0h5?= =?utf-8?B?T0NVK1NCS2M5T3pBa29ZYW1KNXlUcXN3RDlqYm5tb3QzaTdlRDVPN2xlOHVJ?= =?utf-8?B?bkdUSHo3bXYrUGRBTUpnY0JJNUFKSWtKbEh5alUxeVJhbXlvZXdubm55TTVH?= =?utf-8?B?VWV0Y0RNNStEWUZJNkhwZ0hvRGFGWnp2ZzIyNElyRzJTR3RZZnVLN1FnTWNB?= =?utf-8?B?alJ6bmNNd2ZRTnZLMFRmY0NXajBsblM5alZ2QWQyUnNuRDRXcm5yVGJUT01S?= =?utf-8?B?VFcyRmJxVFA3WTBnWFZmTkNXYUh3U0w0Y0RzdU8rWHlSanY0bTRIMGJFalJD?= =?utf-8?B?cHlEN3o1UnljMGIvbGpOQ0JuRjA3V1I2S3RNRlpiN1pQVm1GVit0WjJySDFB?= =?utf-8?B?QlRxbThETitId2Q4U0QxQlZvcStzVkswNEVHclc3aGt2K21yZmFERWV4cUpY?= =?utf-8?B?dGZVV0FRem9jRGU3NWFHQlZjMEhNNkdTTjFMdElaZFlmbmhwTUJEek42NDhw?= =?utf-8?B?YTcvNUZIVVR3bm5MV0VST3V6eU9iMlRubWVIWng1NjNOakd3TWFaZVZwblhZ?= =?utf-8?B?Y21UTHFQeUVWVVNYbHpVVkVUMjhIaTBOcStySXk1c1d4ZGhiT083cGJ5QjhY?= =?utf-8?B?K3VhNk9kbW1iQlNHbHBuU0VCcHRuNDk2MFFRKzVjcjR0aGdZOHluV1hQaUIz?= =?utf-8?B?SWh3K1NaMHN2anJHNVg2NnZPd09HVUZjSWpGczh5ZnlHTGZOZnp3NlNHVEE4?= =?utf-8?B?cm5rMVdFNmIzdDJWSkMybmVnSEtEbmoxMUxrdlJtN3A5Z1lxZkNhYk9GTXQ5?= =?utf-8?B?YW54d0VYWk1PaUZkUVZ3S1ZRdlVJdXpxcHJoUzlPMHdQVThxZ2RFRm5CWmRS?= =?utf-8?B?RDRyYkxtMzZuWXRUU2w0VEt3UjFGWllraEZBM0pFYWpLZGJhVVpCVGtwU1k0?= =?utf-8?B?aTkxbUNKdjZ4TFJLWHozM0xzSGZnNlNURWVhRTdkV251bTIxdExaMWErdXhn?= =?utf-8?B?dlU0REd6Zk9kb0ttOEdEMGtlKzFMbmJVVmlKRVJ0OEdsVzlnTWJmZVlQQUhz?= =?utf-8?B?OVFxVnlWOFpKNWtvVmpwWCs0WWNtN1pONUZsNGhUei8vN2l2eTNHOGtKRHFr?= =?utf-8?B?M0laTXhhVDh2MzhwS1NVWWswbElWQnUrMC9wZmZmY0RKYjMxMlgrelVqRHdM?= =?utf-8?B?cTlobXdjZUREaFB1aHZiRTQwN0Jqekxtb1pMaHdZUXlQdUJCbjRwTERXZVEz?= =?utf-8?B?ZG1jZmMxNng5S3hzR1JlRDlnMForaUFRamh6YkxwVEJIcEZIUEQ3YjR6MG0y?= =?utf-8?B?S0xqd0gzZkd0R3N2MFJQcDFRWTdUeCt5ckhreXExWmswMExocmNGUlhsSTc0?= =?utf-8?B?YllTSS9LdVAwaFpNWXF5c1NreFNIajB4cE9YYTNxaWtCVnlISEtDdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9a009b9-c01d-4d2f-e5a4-08da3e5c7585 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 14:40:06.0968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 04Nd3ZroelEnb2xUY96EgRhytWwbR984Q/toz+wTSDa/TYEsDaRQhG54bpcFylJZB0s2W6B5XKfV9X+UbDyR6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2836 On Wed, May 25, 2022 at 10:52:48AM +0000, Andrew Cooper wrote: > On 25/05/2022 09:13, Roger Pau Monne wrote: > > Rename the flag to better note that it's not actually forcing any IPIs > > to be issued if none is required, but merely avoiding the usage of TLB > > flush assistance (which itself can avoid the sending of IPIs to remote > > processors). > > > > No functional change expected. > > > > Requested-by: Jan Beulich > > Signed-off-by: Roger Pau Monné > > --- > > Changes since v2: > > - New in this version. > > :(  This needs reverting. > > It is specific to IPIs, because of our current choice of algorithm for > freeing pagetables. > > "no assist" excludes ipi-helper hypercalls which invoke > INVALIDATE_TLB_VECTOR.  Such hypercalls do exist and specifically would > be improvement that we ought to use. So the improvement of that mechanism is that you can pass a cpumask parameter to an hypercall in order to avoid having to issue repeated wrmsrs (or APIC MMIO accesses) to send IPIs to different vCPUs? But that could be seen as generic assistance for triggering the execution of remote IDT handlers, and as such won't be restricted by the NO_ASSIST flag (also because it would be implemented in send_IPI_mask() rather than flush_area_mask() IMO). > Furthermore, we do want to work around the limitation that created > FLUSH_FORCE_IPI, because we absolutely do want to be able to use > hypercalls/remote TLB flushing capabilities when available. I agree, we need to get rid of FLUSH_FORCE_IPI. > I accept that FORCE_IPI perhaps isn't a perfect name, but it's a whole > lot less bad than NO_ASSIST. I'm happy for you and Jan to decide on a different name that you both agree. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed May 25 14:42:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 14:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337264.561807 (Exim 4.92) (envelope-from ) id 1ntsD2-0001eI-PX; Wed, 25 May 2022 14:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337264.561807; Wed, 25 May 2022 14:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsD2-0001eB-M7; Wed, 25 May 2022 14:42:00 +0000 Received: by outflank-mailman (input) for mailman id 337264; Wed, 25 May 2022 14:41:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsD1-0001e5-7i for xen-devel@lists.xenproject.org; Wed, 25 May 2022 14:41:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d41e0284-dc38-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 16:41:57 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36--17EBT2XOVWOX3Y_Jpzl2Q-2; Wed, 25 May 2022 16:41:54 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6021.eurprd04.prod.outlook.com (2603:10a6:20b:b3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 14:41:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 14:41:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d41e0284-dc38-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653489717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pU0MyUUYqIdpI4MUku3xG1BLdpnI7oaOFFDtuNWwMfQ=; b=iEFQ8lrAxodwXdPdrzqSQ3AWpqCMu6s4RDd3hWn/RqYKhP/W590Hlowigbmz+R5RCYcp4M kY6BJ0CXUdyp6F1m0BF5Uyr6ZLuO1oBoDSIAXBbfNuxSdUkNPaq9UOdWi8vc4BVfq4pRyV RFp+VHFyX9XRNfjstSO22hIfl7dX8mU= X-MC-Unique: -17EBT2XOVWOX3Y_Jpzl2Q-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gp6aZP5t6ge+mQdkW++RTddksijSPz7fh3EBx1ATOTwVW+IhLFf1o3lZCz65jvtvg1UzD7jfzJHHroTKW/HwoPnhwGe5vuDDQ1+Q+BcIUFWGoOvF/HIMwTkYmZcz0/fzHjJVdwJHbnrbZqhSZ+lXVbGgoYlHCGdYobZTfggPUBH4C8kp0XOvmF+P7ayNc+K/jpMLRfjRr/9s5AAUMLc0rOmG0buPKIS3c4MUXskLbU21cCKdABTYFFprG8W9lYrEmq26LvxK2OjomYt+biyER5CH7Turm1koJgzv3g4pSGDp5CZHSpQ0+OmicnDhNrU4x41n7TFgSHy7Vq9Ah7Bdag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ayw2X1hAczj0AAK6zkbFFj87xksdKcNXGzvJn8aVHTo=; b=UcIzv9kHnG7hjM+nEhSvKxj7/8FqBQ4pJYHgFM/CKrDFceJIre3EMYvQiQeQndPeWHoXeZ4BoqyPuwcVKaOnbdx3TV/1b2OP0zegxzMIGA+sUB/epOc7nxlG1Cy+heUTsM7dDrF/X9N+hqnfeNuJuQ4pqYEQpelTw8QPB/3muv2V1ZEdf+wMyB6FHhta8R5hrl+AyAdqE6dAR6yhgo9yaLkYo1CQ12ne4GDIDKYomDX2RaPQqnZoetfjtvY7EBrjR0a86fI+C13iRY67uXo5mUnYqaj48N/tns8eCJMIbRNJ3sF5L7R66QCT7TdINfu62fAEI7FCeQrH+qCd1Sq1TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <130a3f3c-0128-dfa2-2604-11a966aac8f8@suse.com> Date: Wed, 25 May 2022 16:41:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/2] x86/mm: rename FLUSH_FORCE_IPI to FLUSH_NO_ASSIST Content-Language: en-US To: Andrew Cooper CC: Wei Liu , "xen-devel@lists.xenproject.org" , Roger Pau Monne References: <20220525081311.13416-1-roger.pau@citrix.com> <20220525081311.13416-2-roger.pau@citrix.com> <58aa1cc1-3a67-60d4-6f8e-6c5746b05614@citrix.com> <4bd5d8b5-80a2-8f7c-c117-5c027d8e8f34@citrix.com> From: Jan Beulich In-Reply-To: <4bd5d8b5-80a2-8f7c-c117-5c027d8e8f34@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0170.eurprd04.prod.outlook.com (2603:10a6:20b:331::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f60b704-6805-491d-2ea7-08da3e5cb4a0 X-MS-TrafficTypeDiagnostic: AM6PR04MB6021:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s7/MYBCyhvFp+ZkJQ8pV66etj/MCoxLz6EZMyJ1vZASrOY5SP+VW+wOryx7HVdQ7f4NH+9/s1O69pLcRvCURGBplXYTH65C6EUFq3HruYktOXsySF1SzaFYbKDCU2iQKL4QEwHmn6pK6RaFcBWCoytGMv1FmA0NFfC8QUrxOiqsdKrYII2asyqy7YtZsa/e/fJFIrPKvmAO061PO55gXDzitEHHn7lBO2FdxWsQHagXJf40K/QFbU5PQUnCCv85Q1lEL+bvA5cNUpsObWsIKnUkCH6fgGjIdmEqQR66Op77fNd5fA0Xg45yMpnPntx9jq6vhG9ViJ9G+y73MDDL2I4/gzSpGOpRXchmFJ2h5hw0w9wIFzCdcSI1Df7HNFz2bUEZS1IqEVcDV7k9ybKEtkX7Q/GMgXnmTUdoKHhYdYg5XgmqDYgnQ7jO4KHQtaeWq6LXgrCWxlnxbxI8O8+0Fldz32zQKr0G+UiOcYCZjkvLQpNLSu+l+kleTX1zYOcyQGeK7fO8FjR8yyujPdhg8kimiRqjp0IG3EAJ5S3zaqjD3toxC8ZHNzHLagibRDSqxYsI8IcMuitMQ4V6PqT7tlHnpamlH/yo7V4LpBIL+7oi2i1+ayYEl8UIgUGTT1YF6TwqqWaN+LorTYwn2MK5euKJs02dSvRnbx9WCzrjdwC/6ZtX2o6M2c3D2THdREzcaUwYbWUFeUATtGFREI6WI8QzRP40aXW8cNeiBCTN74jw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(38100700002)(508600001)(8676002)(66476007)(4326008)(66556008)(83380400001)(66946007)(36756003)(6512007)(6506007)(53546011)(316002)(6486002)(26005)(2906002)(8936002)(6916009)(186003)(54906003)(86362001)(31696002)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mP7zyAv+saxzZsCmgTncXxs7r4/xBD5Z0NPL8R1aRVAOux77Ooh8dDJWYDu9?= =?us-ascii?Q?8cTZwZaNmulHkn1b0GB3SdXAutQhX+13w7IVFqUme7rUXUz8HgZt8uwUD6mT?= =?us-ascii?Q?d0nbQ44Ca4jnpbEvFm3DTJIoE9yrdXBHq+7K8yrbhNDZQHsZgYwXeNxN6vKa?= =?us-ascii?Q?WecEgpfO1nqPtZVaxZKwbAwuECWsrVaLgRX6h2IDe4sxXm29gleDZiGckb3b?= =?us-ascii?Q?VeAZKDr/Dn0K0UG1F4fPyxQzn3e/DaZYZ0UKdrcLEup4P+OgldXepgomzYK/?= =?us-ascii?Q?VdVv27lU/6Jlcai726bmEZrvou2vtg/7b6AABpWtfAMIPSbuApOVnIApupLR?= =?us-ascii?Q?YOco+Y9caGCHRgmUAiNeY4pTIm9mPIEfXx5IKqZNfvQtQ/SpEE6qyXRPR28H?= =?us-ascii?Q?BZ7MBt5wYaIPisxSeg1MlSwQw8eBAZPx3gj4CbdDcc9YbKIEdC87mVWsFCx7?= =?us-ascii?Q?oHr/a9scjgKT+glMVYYok0tzuyO8Vq05v+12+9Xjp5lUk9jj9gGok6vThCJo?= =?us-ascii?Q?LVVChQ3IEsVCjZS8o3CnFBrd11udVrnU1CaPSYDHXTQVBqodKEPyYt9khXBn?= =?us-ascii?Q?TOT1SXA/EGkLnNSPuS4Hr+pNWpNr32NcuKG1Vwa2UtWPnFKfafey/BGmmoS6?= =?us-ascii?Q?ibGDJK68VYA5+Uu02w+Ew+FMfkk8buZy3XBbGnbtdDVrvEnK0NWkpjFezGYg?= =?us-ascii?Q?xgI3dlYV4v555kohvHIW54uTYckB4BZ2pGM85WcEUmQrmEFQlr1qbv4vItjw?= =?us-ascii?Q?/len9U56MwI3u7zv/bstcBEom6oVk1swP1zUSsrvuRnnfDNdbhgZIJWMVblJ?= =?us-ascii?Q?CJzyuJG6Ghqb5MUQIh3dltqTlBJ3olkQ6tMEoO/OPPFHDQ+lO+retBpByBV8?= =?us-ascii?Q?7f4Ldz3a702oxZipsX6z8NMicYj/GdzjZ/dF1fuoFGrq2UcQImlJkLQLcwhN?= =?us-ascii?Q?c9QxCeerB9zsUkF/1TvtZ6S903HGSW25SIoJ/5K/zkdIlf8VFqUyh6PTdQqS?= =?us-ascii?Q?FHFWWA8VXrL3M1muAm69x1PlDMYKTX8cVTW1MSmZEMHstTLyAkvtHFzZVoqJ?= =?us-ascii?Q?XSyiCfay3O4XSSFd0CI1Y9Mad0Ghvr3AbtkmJSvTNI0MRfd3CMdcSDuNjmzC?= =?us-ascii?Q?QCgG3tkH7nV/4jT9s7MTNCr9aU3QzYg3l3lAWnN3enKCeDqrq2K8vK4vWJrE?= =?us-ascii?Q?YVeyqk46aT36L4Ku/O1UWP+3y5RNAC1e3Uj0cYyIvXgSuvOMogU9hzSxbvmZ?= =?us-ascii?Q?dtvM0jDee0mbLz8jqgILByUNm4hh6fH+DCgYAfqnN6KmNpGZdSYL/OsY935s?= =?us-ascii?Q?kTa5Zs0EkAnqmZetM1+jSxHwK7SNMKd+CovuujE6aWWxJUSxFBiNrjkC8kYZ?= =?us-ascii?Q?IfCNVnwZdBMaWKa8SAd6eVkR6xomf77kyK2kyX53wUHn9GEMEppVBhqjs1bj?= =?us-ascii?Q?ce4MvA8D0hQ6Ccke3dGnqwfrYvO1Or4eEItxfAkAVXd6ipzmmUkDCH3GXSft?= =?us-ascii?Q?JHkqUxF1zeON1N7g2canzZvW+7NoVS46mlBny/lCh8HNKQXH3b6vu3x7FU3X?= =?us-ascii?Q?Fgssl1qPPYmeI5TNFH6GZZuJNXSrT2nu6n36fA9lf1V3vBZBmdGGwoXNblEW?= =?us-ascii?Q?mmyFm5b0bJIhNloOmSg4trG4IrtkzHetj1DtjOYEtgjGn9J9yU+sRmaetX50?= =?us-ascii?Q?3/f8pxv6UMRKltYETWwST5zc35vh3dPszc6IMAZtPvFySRIJIalGh6kHhVpE?= =?us-ascii?Q?mj5iQs/e3Q=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f60b704-6805-491d-2ea7-08da3e5cb4a0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 14:41:51.5906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yOzm5lji9v95mBBupVYAndEYoeaRq5tCixDUoYWXdtweibVEKOsTRPUzDRsM9u/EOouJxW+tdcpu8Nn0QhQ/tA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6021 On 25.05.2022 16:33, Andrew Cooper wrote: > On 25/05/2022 12:14, Jan Beulich wrote: >> On 25.05.2022 12:52, Andrew Cooper wrote: >>> On 25/05/2022 09:13, Roger Pau Monne wrote: >>>> Rename the flag to better note that it's not actually forcing any IPIs >>>> to be issued if none is required, but merely avoiding the usage of TLB >>>> flush assistance (which itself can avoid the sending of IPIs to remote >>>> processors). >>>> >>>> No functional change expected. >>>> >>>> Requested-by: Jan Beulich >>>> Signed-off-by: Roger Pau Monn=C3=A9 >>>> --- >>>> Changes since v2: >>>> - New in this version. >>> :(=C2=A0 This needs reverting. >>> >>> It is specific to IPIs, because of our current choice of algorithm for >>> freeing pagetables. >>> >>> "no assist" excludes ipi-helper hypercalls which invoke >>> INVALIDATE_TLB_VECTOR.=C2=A0 Such hypercalls do exist and specifically = would >>> be improvement that we ought to use. >>> >>> Furthermore, we do want to work around the limitation that created >>> FLUSH_FORCE_IPI, because we absolutely do want to be able to use >>> hypercalls/remote TLB flushing capabilities when available. >>> >>> I accept that FORCE_IPI perhaps isn't a perfect name, but it's a whole >>> lot less bad than NO_ASSIST. >> But FORCE_IPI has caused actual confusion while reviewing patch 2. >> If NO_ASSIST doesn't suit you and FORCE_IPI is also wrong, can you >> suggest a better name fitting both aspects? >=20 > I don't actually agree that FORCE_IPI is unclear to begin with. You did see the earlier communication with Roger, didn't you? To me the name pretty clearly suggests "always IPI" (hence "force"), i.e. ... > The safety property required is "if you need to contact a remote CPU, it > must be by IPI to interlock with Xen's #PF handler". ... not in any way limited to remote CPUs. Yet patch 2 is about cases where things are safe because no IPI will be needed (not even a self-IPI). > FORCE_IPI is very close to meaning this.=C2=A0 If anything else is unclea= r, > it can be clarified in the adjacent comment. I'm afraid I don't think a comment is what would help here. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 14:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 14:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337272.561818 (Exim 4.92) (envelope-from ) id 1ntsJL-0002Kw-Fa; Wed, 25 May 2022 14:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337272.561818; Wed, 25 May 2022 14:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsJL-0002Kp-Cb; Wed, 25 May 2022 14:48:31 +0000 Received: by outflank-mailman (input) for mailman id 337272; Wed, 25 May 2022 14:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntsJJ-0002Kj-83 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 14:48:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc6e02e9-dc39-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 16:48:27 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-nV7BKBFiNMOZ4g5pt7STPw-1; Wed, 25 May 2022 16:48:26 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6031.eurprd04.prod.outlook.com (2603:10a6:803:102::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 14:48:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Wed, 25 May 2022 14:48:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc6e02e9-dc39-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653490107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VoLg7KkUvN4T6plljhmP/C3HAVtKOnA771k1gixyZaI=; b=nqAMzsoddcd5xFlLgPZV+jmUQizGYGxOqzoZcQPwBIbHb94rggBPX0W2bko/7WKuNEuqSE R5E+WTap4SSaP/HuiWFnw3KVf/Wx5QTvXej0eE4RS04GwOFa3+cXPQzoIaLBAcRzHN5iww zl3jw/pNZQlvo0kymI/YfKQhh31/g08= X-MC-Unique: nV7BKBFiNMOZ4g5pt7STPw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU/8kShQOOdFkJ5LbDL6tpj9FagSLXnZXgPd4wCJ91IHQH78qunYTTOvC14wsh8Xvk60/b8SfmfsvbJtjrEDydZ00rJl3Co4TxyCCupFdaxrrQE9kgquuoY3oDbiQbXwENQWl8m+zLUES1VI7FuYrHemT8LreXTAAC5xdZJ8MSH+s2vC06DfsA+0VVXfIvrLRiP7z7iT5KP7n7Ye7gpdcBVKSNMplamZla2545tKLHU96lSf90D3t8UnSEYlMN23PVuF5w1grtBo0N6nvgpmWkfaaFv38AAttElJpap6GhftWyJmTlc8lZj/5BDMpUHtOmiiX09Icf9ufK/m4QY6tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VoLg7KkUvN4T6plljhmP/C3HAVtKOnA771k1gixyZaI=; b=BJOMsUCrIlDP34tBUsxC5lpR8LzfV3uxpQkN+skDPW9qtG6Dd09FQ325Nex5F0XJI4SaDOfNIKhXUGWkcrsw4l7J507Eu+N2VUpzuWWSAXsLiq/RqCKgTSGRwEibkikShduWXqHnBSMTiD2mr19JSVuTzFUrXUyXSMB0uNhGzeXdxxxO1k842tH4Kz06X8zidpEujSGby5VuSaWBqwukpkU91S9U0ocuvRBSRu45n7GS5F3S30Pn9mdNUyOAjvPke1VhZjVPpIIZJpoMqt6KXqSRiGei3BJSyQvQXyK7FdH7sD4aMNVVScdvI6qkvQp3OFG8g1gETVL+GbwqiQEbCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 25 May 2022 16:48:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xsm: refactor and optimize policy loading Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220523154024.1947-1-dpsmith@apertussolutions.com> <8aebc234-e870-9435-9f60-3c06013421d9@suse.com> <4d3a8914-a505-230c-5807-8ca295c3b60a@apertussolutions.com> From: Jan Beulich In-Reply-To: <4d3a8914-a505-230c-5807-8ca295c3b60a@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0062.eurprd06.prod.outlook.com (2603:10a6:20b:464::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3883268-3697-4abf-d4a6-08da3e5d9e80 X-MS-TrafficTypeDiagnostic: VI1PR04MB6031:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GiN6r3XMKOr4Cr+gYjablkAgjPnhDvxRF8iFH11n+1ajTrt9qbuTZOctkoraivrknpch9fqZsOyM4eoCgh/7Zd4rcu8kA0Ib0hcPsttLQdBJzknDeAqFIFhbcTtlZC6VUGI7/Odtmq9CfuYwgguwyRf5yu6DUgB5pah+CkpL74Rj0h9TkzavZdLT/+q6SnWzMtJwbLqLR1jQQOpq822zecCo6D0O+S1+vFBATP3IlrT6p+AQMen/F342REw74EelBCtWCdFx/bbQblkUExAsOKlRvtta9Zih5tmqHQRo6V/Z8Y4RiP44sAyo8tBJkoN3eyGUe2i6iuLyzO8hmuKBqSYgi9xnlPlRW/e+zgK10f1cQ0/W6PrzR6fXeO/wDhvwrSlrPzR+MKaNyHSyFZEJZyWs7W9AjxrtNqxjEsfRWWvKGW7FWypYTfRlPW307J95DzYZicwkGXF3XH+O3/bQf3dbRolyUeK0liwZVdvph/Uj7HbkFWgf4twIiwj7r7BYaevzKIXizMsRT1T95mrTJkP0SLmwvuoR9s5VW9srftuexX3xwrl5FraLHXx4/LZN0jN2EWTMWmfuiwQT6CCRQfEuDj3KTeE0ywHnZXO2ivEc08Kb6GXzf3ZTMI4olSCVDFcqppxBXBlB3RrTqLcyB385EytaMJe+YnQYt/yZUiOm5ySndSdz+wugYkWyXyT3ZWhOTBf2CB0h+g91LQaHB1T1Z+CL2rIuLT0/gUEc+qELF6Sv6Gn7o2NusY2KUow9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(86362001)(26005)(6506007)(31686004)(2616005)(6486002)(31696002)(316002)(6512007)(508600001)(6916009)(2906002)(5660300002)(38100700002)(36756003)(4326008)(83380400001)(53546011)(8676002)(66556008)(66946007)(66476007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGtkRk9UZDFHdkRPVUQ2aCtSUTByNVJESVFLaTQ2Tk5QWTNnQ2xuemZKa1VB?= =?utf-8?B?amw0Q0psU0k1aEpram1pT2tKeHdWQlpOUVZ2SE5tc01pcmRRM3lIb3VtUXQ2?= =?utf-8?B?UkRvRXVNQlNmRkNIRjdKa0RNUi9hQnBEaGhqaVNjMm0ySVh6Q2hUTElST2h4?= =?utf-8?B?YXdFd3dPeklFdnhCak1QNDJMM0pkYXZnZERsWHBTWW9uRDdHZHgxMWZZcmM1?= =?utf-8?B?c3dHSVBld3VpSzFIaVV1bGZ1WjcrQ1ZneHMwakIyRmR6Z3FGMjhnYWVDaWVP?= =?utf-8?B?QlIwQVZyM0tSaXM0WXNHVjAyT3BHRXluSy9KRm1KVlFxQ1hhMC9mY2kvelZr?= =?utf-8?B?WDRzajBTa3Q2anE2Y1FoTVZoa2dBdGd3amNmYnl0ejFFRXlGQnNRN2FsKzFP?= =?utf-8?B?Rm12cENsY1A4NkVicjdQV1pvbTlHdUwyMHhDOUxyV0tlZDZqWklOcGNrdDVM?= =?utf-8?B?akVrL1ZnZkh2T2d0N1BEMFI0cU1SZkEyMEMreGRQZEhMaUt0akUvYTgwM1Ir?= =?utf-8?B?SGZ1M0RZblN6dG9paGZ5N0dpVzh6RzVtZ3N6ZjZPTUVmUTcxZnZNODhOa2Rn?= =?utf-8?B?Z25HSE9SYUZ3aVFZYndKL3V2blRnT3NBNXBTbENLUjNUeUMydVVKUEhhYkNX?= =?utf-8?B?N1VBemp4ek91eEZtS1QyY2ZnaEVEK1dBczRJanFsMWMyS3NsN0c1d3dybi9L?= =?utf-8?B?QU05L1NxQ0tia21talpHL2VpRVRZUFhlYVNmR3ZydmVBc2p1c1R4U05IYlBI?= =?utf-8?B?VEpJTDdSNkkvN29IYXhzWmpEUjQwRGZnRmhBNmNQUUZQelczS0RETUpQcG11?= =?utf-8?B?d29PakJ5U0VQVDAwcFZUYlcvZmFrRVJQVUM2Tnd0OE1OUUVRbllRU1pLaFRC?= =?utf-8?B?cGw0dGI2QXAxdXZiUEIrZG4yWnVQVDNEa3NsYVNQN0VZR2FJcXRwSVlqNm8y?= =?utf-8?B?TnB4anQvTWwrbGVvMUQ0Q1lmYzhMMk0zWUM4UlBNb1RvbTljQkpyQTRXUFdr?= =?utf-8?B?S0R4SGlnYm9EaW91Zm8wSC9YM2ZkZGpwWUN1aEhJNGxud0hBZWx1K0oyak9v?= =?utf-8?B?ZEpSRHpkeUxCK29wUU5oNk9kbkhlbGNEcXdHekdBeGRwSThJdzZ1OHNaV2U2?= =?utf-8?B?QU1NUVQzNzdnL2lxUnRsT1ZRUlExK1JMdU00Rm5qZFlJVHRDSjVrY1k4RGlR?= =?utf-8?B?TGRkaFpPSXhPMlJoVnB6R1IzUEorQmtXSHp5MU9WYzVmenNwS3NwNnpIVUQx?= =?utf-8?B?VmJ4V3RUTDBONEV4U0V5MXJuUGI3a3ExbXhsa2M1ekUvM2s5VUFMdjdVa3dK?= =?utf-8?B?V2U0K0ZiZXFHR09maENCZnN3eW5ud3lIZmdyNEc1bEY0L0N2bXJIRFdtaGFi?= =?utf-8?B?ZERJSWZackRHTG9qUlJvTnBFYU1lUERUbWU2aEg5R3FqUHNRVjdJbGFCV0cy?= =?utf-8?B?Nk9mWEtnNjlZMGNPWGNPbWlmbXFXWlMydWp0VzN4RXRybGt4N1pnaE16eGhU?= =?utf-8?B?R2dWZGo1YTNjdVFFRmdRNWh1dlZIQ3hzNnNUZUJPdGtTYlYrZFgrbkhFQzd0?= =?utf-8?B?MDhTTE15c2M3dm4yZGtHWitPQTJhWXlKaWxrZGJWbU1YSUpHTjZYSlYxMXZC?= =?utf-8?B?clZHNTR1MHVUVDFtdU5KRHFwZFZpRHVjS3pmRW42OHZaTWYvWGJQOGRGS3FM?= =?utf-8?B?YXFsRlk4NTZRNldXQ2hGNHZNczgxekxtUURxSXF3djA0RStMbFRPcGtKU3R2?= =?utf-8?B?WHN0c1JpR2E5b1l2d0pobTk2a2VRajZISVFMaEh6ODhnV0Q0SVcyUjJqaGNz?= =?utf-8?B?a0wzL01Qa2Jod2xBNnZkQTNZSnZubFFGRFNEYXlDQzhpZHN0bnRpdEZCdUYv?= =?utf-8?B?NHNmMk9YbkJReFpJMW50RDEvdExwMXRtcm1mcVRCRlFjb016SHNDMk5BSHNh?= =?utf-8?B?OWMwMWVlNDdEWTgxck95Ylg4VnVZbmZqWVVlR20vOWlKSzZJVUFBZU1KNjRP?= =?utf-8?B?RjNHTmxodkczNm1yc2l4Y1hHWnNnWUsyUUlnd2V2QnJEbi9jSlJlbWRkOS81?= =?utf-8?B?OU93MlR5Y1c3YlUvVVprZ3ZMN3o5cEVZT3B6YnczSDVxc3dXcEJHUkRFNkty?= =?utf-8?B?MzFaUTNVRzlNbVhnbytOaWJFVE1JYUtnUlM4TnU5WHYvazl3eXBTdTdTeU5l?= =?utf-8?B?TGJESmlaTFVCV3Z4emVhYXNBVlhjVzVRY0d5RythaThsaFY1ZTZYVzNWdDRu?= =?utf-8?B?T0xldmtGREY3MXVSRlZ6S0dHUGViK2NnRzArUkdCSHRCa2hleTIxazJoaVpD?= =?utf-8?B?THAyQjhkL1FBalZXVmY0dWw0ZStYYkJYREI2Z1NsVlJRZjNVMnAxdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3883268-3697-4abf-d4a6-08da3e5d9e80 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 14:48:23.9720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ekXACo4k9oypjARm0jDj1Ev/2K5cYaPomMybHybv1J3yzYb/9eHTFIOIa2QJnBifWiBpEUDt/xeClQwDMttLhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6031 On 25.05.2022 16:11, Daniel P. Smith wrote: > On 5/25/22 02:37, Jan Beulich wrote: >> On 24.05.2022 19:42, Daniel P. Smith wrote: >>> On 5/24/22 11:50, Jan Beulich wrote: >>>> On 23.05.2022 17:40, Daniel P. Smith wrote: >>>>> @@ -36,10 +36,17 @@ int __init xsm_multiboot_policy_init( >>>>> { >>>>> int i; >>>>> module_t *mod = (module_t *)__va(mbi->mods_addr); >>>>> - int rc = 0; >>>>> + int rc = -ENOENT; >>>> >>>> I'm afraid I can't easily convince myself that this and the other >>>> -ENOENT is really relevant to this change and/or not breaking >>>> anything which currently does work (i.e. not entirely benign). >>>> Please can you extend the description accordingly or split off >>>> this adjustment? >>> >>> Let me expand the commit explanation, and you can let me know how much >>> of this detail you would like to see in the commit message. >>> >>> When enabling CONFIG_XSM_FLASK today, the XSM_MAGIC variable becomes >>> defined as a non-zero value. This results in xsm_XXXX_policy_init() to >>> be called regardless of the XSM policy selection, either through the >>> respective CONFIG_XSM_XXXXX_DEFAULT flags or through the cmdline >>> parameter. Additionally, the concept of policy initialization is split >>> between xsm_XXXX_policy_init() and xsm_core_init(), with the latter >>> being where the built-in policy would be selected. This forces >>> xsm_XXXX_policy_init() to have to return successful for configurations >>> where no policy loading was necessary. It also means that the situation >>> where selecting XSM flask, with no built-in policy, and failure to >>> provide a policy via MB/DT relies on the security server to fault when >>> it is unable to load a policy. >>> >>> What this commit does is moves all policy buffer initialization to >>> xsm_XXXX_policy_init(). As the init function, it should only return >>> success (0) if it was able to initialize the policy buffer with either >>> the built-in policy or a policy loaded from MB/DT. The second half of >>> this commit corrects the logical flow so that the policy buffer >>> initialization only occurs for XSM policy modules that consume a policy >>> buffer, e.g. flask. >> >> I'm afraid this doesn't clarify anything for me wrt the addition of >> -ENOENT. There's no case of returning -ENOENT right now afaics (and >> there's no case of you dealing with the -ENOENT anywhere in your >> changes, so there would look to be an overall change in behavior as >> viewed from the outside, i.e. the callers of xsm_{multiboot,dt}_init()). >> If that's wrong for some reason (and yes, it looks at least questionable >> on the surface), that's what wants spelling out imo. A question then >> might be whether that's not a separate change, potentially even a fix >> which may want to be considered for backport. Of course otoh the sole >> caller of xsm_multiboot_init() ignores the return value altogether, >> and the sole caller of xsm_dt_init() only cares for the specific value >> of 1. This in turn looks at least questionable to me. > > Okay, let me change the view a bit. > > The existing behavior is for xsm_{multiboot,dt}_init() to return 0 if > they did not locate a policy file for initializing the policy buffer. It > did so because it expected later that xsm_core_init() would just set it > to the built-in policy. BUT, it also served the purpose of succeeding if > it were called when either the dummy or SILO, neither of which needs the > policy buffer initialized, is the enforcing policy. > > This change starts with moving the lines that set the policy buffer to > the built-in policy into xsm_{multiboot,dt}_init() respectively and only > return success if it was able to populate the policy buffer. In other > words, if there is not a built-in policy and a policy file was not able > to be loaded, it returns -NOENT to represent it was not able to find a > policy file. This change makes these functions do as their name > suggests, to initialize the policy buffer either from MB or DT with a > fallback to the built-in policy otherwise fail. > > Upon making the function behave correctly, it exposes a valid set of > conditions that under the current behavior succeeds but will fail under > the correct behavior for xsm_{multiboot,dt}_init(). With flask enabled > in the build but not the built-in policy and either dummy or SILO is the > enforcing policy, then xsm_{multiboot,dt}_init() will be called and > fail. This is where the second half of the change comes into effect, > which is to introduce a gating that will only attempt to initialize the > policy buffer if the enforcing XSM policy requires a policy file. With > this gating in place, under the above set of conditions > xsm_{multiboot,dt}_init() will not be called and XSM initialization will > succeed as it should. > > Now to your question of whether these changes could be split and given a > focused explanation in their respective commits. Yes, I can split it > into two separate commits. While the gating of the call to > xsm_{multiboot,dt}_init() is an independent change, the change to > xsm_{multiboot,dt}_init() itself is not and must proceed after the > gating change. This means it is possible to backport the first commit, > gating, independently. If the desire is to backport the second commit, > xsm_{multiboot,dt}_init() behavior, then it would require both commits > to be backported. > > I hope this helps better clarify my reasoning and if you would like to > see the changes split how I highlighted, just let me know. I'd like to leave to you whether to split. All I'm after is that from the description it becomes clear what the (intended) effect of the added -ENOENT errors is, which didn't exist before. Now that we're about to start adopting some Misra-C rules, this may even need to extend to cover the case of so far missing error checks potentially being added up the call tree. Jan From xen-devel-bounces@lists.xenproject.org Wed May 25 16:30:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 16:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337288.561838 (Exim 4.92) (envelope-from ) id 1nttth-0004m1-57; Wed, 25 May 2022 16:30:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337288.561838; Wed, 25 May 2022 16:30:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nttth-0004lu-28; Wed, 25 May 2022 16:30:09 +0000 Received: by outflank-mailman (input) for mailman id 337288; Wed, 25 May 2022 16:30:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntttf-0004hU-D9 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 16:30:07 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eefb7727-dc47-11ec-837f-e5687231ffcc; Wed, 25 May 2022 18:30:05 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id p22so36816771lfo.10 for ; Wed, 25 May 2022 09:30:05 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id u11-20020ac25bcb000000b0047889d37464sm1095708lfn.196.2022.05.25.09.30.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 09:30:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eefb7727-dc47-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+i+Dct5KOGPoWYK+pPUyiAaWMirerzarztidBbbxZ50=; b=ZIDsYUSjntwVSYs3vZQiv9wBkNSJozZuXgBa82+HoJAikAvCUlWvwBZNMfLB8/l1Tm 0g8Ybm/2mCAzS/JaKwQQ5C+kFvbo63EBpqb16lOVY7GjHFiZSlpxQ8/fTC7SqBl9J81l 0Mn0B4qqJFUyvMmFoq1MFCJllsjSVlPVbwaC+n8wEZ94iMJ5/NcLE6Of3GvQsVKWP61a 0rTaKU/Zkoecq05tbn/hqd+yYZTJQ4yWzUX8Uv6y906biVx6pDeW+5bPszd36lDbjem0 lfVpRgdweA45U4nONp+eJEabdVTwV7SQg4QVujaFP7nMdse/KWFd1zvtLl6x0jT7ddlS sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+i+Dct5KOGPoWYK+pPUyiAaWMirerzarztidBbbxZ50=; b=BqM1D1129fKfkB7aOIwSJylMgQY9EjdRUUGTUyySZaHIqfYJx9YygPyxopzqmn/WYi rcUT88PwspDCCItO/VuRRKfum24UJoE6WW8X1Syq1GNFUH4axJZNJOmr8Hyes3lnWm8M 9+HW5wm4nafmf/LbQ1o0hLIkglKa9BntWJcUuUPDNHOdx6AesgbzAOvwposauCd+kwu/ e58OG2f7fGNP6U1teDDDW9A8sU5EePkB+A3zkq84WLF5CHUbtgmz6sEAgjonm27GqQeh mpqzRErtJPXNujhJABX5u+ib5F0eoY6QCQA68s3N7YVnnchZA/NFfQqQcqu2UwAzUcXk bDpw== X-Gm-Message-State: AOAM5320hIW86XhjFqSOBvgUJC20dmKLhfiwWrd34saea1D3DpMGWulT NpwXR4eZl8IehHbAUGBa2zU= X-Google-Smtp-Source: ABdhPJyRJqRI3QzG8Wbqpo4lLfYsbAk6Wd5A09iq3QQCnhw2JyTAn6EmWhKwHvIjEqXcFQbDcFfXTA== X-Received: by 2002:a05:6512:1051:b0:478:8351:6665 with SMTP id c17-20020a056512105100b0047883516665mr7696489lfb.390.1653496204674; Wed, 25 May 2022 09:30:04 -0700 (PDT) Subject: Re: [PATCH V2 5/7] dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops To: Saravana Kannan , Rob Herring , Stefano Stabellini Cc: xen-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , DTML , Linux Kernel Mailing List , Linux ARM , Arnd Bergmann , Oleksandr Tyshchenko , Jason Wang , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig , Jean-Philippe Brucker References: <1651947548-4055-1-git-send-email-olekstysh@gmail.com> <1651947548-4055-6-git-send-email-olekstysh@gmail.com> <56e8c32d-6771-7179-005f-26ca58555659@gmail.com> <460a746c-6b61-214b-4653-44a1430e314d@gmail.com> <6f469e9c-c26e-f4be-9a85-710afb0d77eb@gmail.com> <390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com> <20220524160134.GE3730540-robh@kernel.org> From: Oleksandr Message-ID: Date: Wed, 25 May 2022 19:30:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 24.05.22 21:34, Saravana Kannan wrote: Hello all > " > > On Tue, May 24, 2022 at 9:01 AM Rob Herring wrote: >> +Saravana >> >> On Mon, May 23, 2022 at 06:58:13PM -0700, Stefano Stabellini wrote: >>> On Mon, 23 May 2022, Oleksandr wrote: >>>>>> On Thu, 19 May 2022, Oleksandr wrote: >>>>>>>> On Wed, May 18, 2022 at 5:06 PM Oleksandr wrote: >>>>>>>>> On 18.05.22 17:32, Arnd Bergmann wrote: >>>>>>>>>> On Sat, May 7, 2022 at 7:19 PM Oleksandr Tyshchenko >>>>>>>>>> wrote: >>>>>>>>>> This would mean having a device >>>>>>>>>> node for the grant-table mechanism that can be referred to using >>>>>>>>>> the >>>>>>>>>> 'iommus' >>>>>>>>>> phandle property, with the domid as an additional argument. >>>>>>>>> I assume, you are speaking about something like the following? >>>>>>>>> >>>>>>>>> >>>>>>>>> xen_dummy_iommu { >>>>>>>>> compatible = "xen,dummy-iommu"; >>>>>>>>> #iommu-cells = <1>; >>>>>>>>> }; >>>>>>>>> >>>>>>>>> virtio@3000 { >>>>>>>>> compatible = "virtio,mmio"; >>>>>>>>> reg = <0x3000 0x100>; >>>>>>>>> interrupts = <41>; >>>>>>>>> >>>>>>>>> /* The device is located in Xen domain with ID 1 */ >>>>>>>>> iommus = <&xen_dummy_iommu 1>; >>>>>>>>> }; >>>>>>>> Right, that's that's the idea, >>>>>>> thank you for the confirmation >>>>>>> >>>>>>> >>>>>>> >>>>>>>> except I would not call it a 'dummy'. >>>>>>>> From the perspective of the DT, this behaves just like an IOMMU, >>>>>>>> even if the exact mechanism is different from most hardware IOMMU >>>>>>>> implementations. >>>>>>> well, agree >>>>>>> >>>>>>> >>>>>>>>>> It does not quite fit the model that Linux currently uses for >>>>>>>>>> iommus, >>>>>>>>>> as that has an allocator for dma_addr_t space >>>>>>>>> yes (# 3/7 adds grant-table based allocator) >>>>>>>>> >>>>>>>>> >>>>>>>>>> , but it would think it's >>>>>>>>>> conceptually close enough that it makes sense for the binding. >>>>>>>>> Interesting idea. I am wondering, do we need an extra actions for >>>>>>>>> this >>>>>>>>> to work in Linux guest (dummy IOMMU driver, etc)? >>>>>>>> It depends on how closely the guest implementation can be made to >>>>>>>> resemble a normal iommu. If you do allocate dma_addr_t addresses, >>>>>>>> it may actually be close enough that you can just turn the grant-table >>>>>>>> code into a normal iommu driver and change nothing else. >>>>>>> Unfortunately, I failed to find a way how use grant references at the >>>>>>> iommu_ops level (I mean to fully pretend that we are an IOMMU driver). I >>>>>>> am >>>>>>> not too familiar with that, so what is written below might be wrong or >>>>>>> at >>>>>>> least not precise. >>>>>>> >>>>>>> The normal IOMMU driver in Linux doesn’t allocate DMA addresses by >>>>>>> itself, it >>>>>>> just maps (IOVA-PA) what was requested to be mapped by the upper layer. >>>>>>> The >>>>>>> DMA address allocation is done by the upper layer (DMA-IOMMU which is >>>>>>> the glue >>>>>>> layer between DMA API and IOMMU API allocates IOVA for PA?). But, all >>>>>>> what we >>>>>>> need here is just to allocate our specific grant-table based DMA >>>>>>> addresses >>>>>>> (DMA address = grant reference + offset in the page), so let’s say we >>>>>>> need an >>>>>>> entity to take a physical address as parameter and return a DMA address >>>>>>> (what >>>>>>> actually commit #3/7 is doing), and that’s all. So working at the >>>>>>> dma_ops >>>>>>> layer we get exactly what we need, with the minimal changes to guest >>>>>>> infrastructure. In our case the Xen itself acts as an IOMMU. >>>>>>> >>>>>>> Assuming that we want to reuse the IOMMU infrastructure somehow for our >>>>>>> needs. >>>>>>> I think, in that case we will likely need to introduce a new specific >>>>>>> IOVA >>>>>>> allocator (alongside with a generic one) to be hooked up by the >>>>>>> DMA-IOMMU >>>>>>> layer if we run on top of Xen. But, even having the specific IOVA >>>>>>> allocator to >>>>>>> return what we indeed need (DMA address = grant reference + offset in >>>>>>> the >>>>>>> page) we will still need the specific minimal required IOMMU driver to >>>>>>> be >>>>>>> present in the system anyway in order to track the mappings(?) and do >>>>>>> nothing >>>>>>> with them, returning a success (this specific IOMMU driver should have >>>>>>> all >>>>>>> mandatory callbacks implemented). >>>>>>> >>>>>>> I completely agree, it would be really nice to reuse generic IOMMU >>>>>>> bindings >>>>>>> rather than introducing Xen specific property if what we are trying to >>>>>>> implement in current patch series fits in the usage of "iommus" in Linux >>>>>>> more-less. But, if we will have to add more complexity/more components >>>>>>> to the >>>>>>> code for the sake of reusing device tree binding, this raises a question >>>>>>> whether that’s worthwhile. >>>>>>> >>>>>>> Or I really missed something? >>>>>> I think Arnd was primarily suggesting to reuse the IOMMU Device Tree >>>>>> bindings, not necessarily the IOMMU drivers framework in Linux (although >>>>>> that would be an added bonus.) >>>>>> >>>>>> I know from previous discussions with you that making the grant table >>>>>> fit in the existing IOMMU drivers model is difficult, but just reusing >>>>>> the Device Tree bindings seems feasible? >>>>> I started experimenting with that. As wrote in a separate email, I got a >>>>> deferred probe timeout, >>>>> >>>>> after inserting required nodes into guest device tree, which seems to be a >>>>> consequence of the unavailability of IOMMU, I will continue to investigate >>>>> this question. >>>> >>>> I have experimented with that. Yes, just reusing the Device Tree bindings is >>>> technically feasible (and we are able to do this by only touching >>>> grant-dma-ops.c), although deferred probe timeout still stands (as there is no >>>> IOMMU driver being present actually). >>>> >>>> [ 0.583771] virtio-mmio 2000000.virtio: deferred probe timeout, ignoring >>>> dependency >>>> [ 0.615556] virtio_blk virtio0: [vda] 4096000 512-byte logical blocks (2.10 >>>> GB/1.95 GiB) >>>> >>>> >>>> Below the working diff (on top of current series): >>>> >>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c >>>> index da9c7ff..6586152 100644 >>>> --- a/drivers/xen/grant-dma-ops.c >>>> +++ b/drivers/xen/grant-dma-ops.c >>>> @@ -272,17 +272,24 @@ static const struct dma_map_ops xen_grant_dma_ops = { >>>> >>>> bool xen_is_grant_dma_device(struct device *dev) >>>> { >>>> + struct device_node *iommu_np; >>>> + bool has_iommu; >>>> + >>>> /* XXX Handle only DT devices for now */ >>>> if (!dev->of_node) >>>> return false; >>>> >>>> - return of_property_read_bool(dev->of_node, "xen,backend-domid"); >>>> + iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); >>>> + has_iommu = iommu_np && of_device_is_compatible(iommu_np, >>>> "xen,grant-dma"); >>>> + of_node_put(iommu_np); >>>> + >>>> + return has_iommu; >>>> } >>>> >>>> void xen_grant_setup_dma_ops(struct device *dev) >>>> { >>>> struct xen_grant_dma_data *data; >>>> - uint32_t domid; >>>> + struct of_phandle_args iommu_spec; >>>> >>>> data = find_xen_grant_dma_data(dev); >>>> if (data) { >>>> @@ -294,16 +301,30 @@ void xen_grant_setup_dma_ops(struct device *dev) >>>> if (!dev->of_node) >>>> goto err; >>>> >>>> - if (of_property_read_u32(dev->of_node, "xen,backend-domid", &domid)) { >>>> - dev_err(dev, "xen,backend-domid property is not present\n"); >>>> + if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", >>>> + 0, &iommu_spec)) { >>>> + dev_err(dev, "Cannot parse iommus property\n"); >>>> + goto err; >>>> + } >>>> + >>>> + if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || >>>> + iommu_spec.args_count != 1) { >>>> + dev_err(dev, "Incompatible IOMMU node\n"); >>>> + of_node_put(iommu_spec.np); >>>> goto err; >>>> } >>>> >>>> + of_node_put(iommu_spec.np); >>>> + >>>> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); >>>> if (!data) >>>> goto err; >>>> >>>> - data->backend_domid = domid; >>>> + /* >>>> + * The endpoint ID here means the ID of the domain where the >>>> corresponding >>>> + * backend is running >>>> + */ >>>> + data->backend_domid = iommu_spec.args[0]; >>>> >>>> if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, >>>> GFP_KERNEL))) { >>>> (END) >>>> >>>> >>>> >>>> Below, the nodes generated by Xen toolstack: >>>> >>>> xen_grant_dma { >> Nit: iommu { >> >>>> compatible = "xen,grant-dma"; >>>> #iommu-cells = <0x01>; >>>> phandle = <0xfde9>; >>>> }; >>>> >>>> virtio@2000000 { >>>> compatible = "virtio,mmio"; >>>> reg = <0x00 0x2000000 0x00 0x200>; >>>> interrupts = <0x00 0x01 0xf01>; >>>> interrupt-parent = <0xfde8>; >>>> dma-coherent; >>>> iommus = <0xfde9 0x01>; >>>> }; >>> Not bad! I like it. >>> >>> >>>> I am wondering, would be the proper solution to eliminate deferred probe >>>> timeout issue in our particular case (without introducing an extra IOMMU >>>> driver)? >>> In reality I don't think there is a way to do that. I would create an >>> empty skelethon IOMMU driver for xen,grant-dma. >> Does it have to be an empty driver? Originally, IOMMU 'drivers' were not >> drivers, but they've been getting converted. Can that be done here? >> >> Short of that, I think we could have some sort of skip probe list for >> deferred probe. Not sure if that would be easiest as IOMMU specific or >> global. > Hi Oleksandr, > > If you do fw_devlink.strict=1, you'll notice that the consumers of > this "iommu" won't probe at all or will delay the boot by some number > of seconds. The eventual goal is to go towards fw_devlink.strict=1 > being the default. ok, I got it. Let's me please explain our particular case in details, sorry I may repeat some information which I have already mentioned elsewhere, but it maybe better to keep the whole context here. We have Xen grant DMA-mapping layer added by previous commit [1]. For it to operate properly we need a way to communicate some per-device information using device-tree, and this information is Xen specific. This is what the current commit is doing by introducing new binding to describe that. The next commit [2] will use that new binding to retrieve required information. There was a suggestion to consider reusing generic device-tree IOMMU bindings to communicate this specific information instead of introducing a custom property. Although it requires more effort for the Xen toolstack (instead of adding a code to insert a single "xen,backend-domid" property, we need to generate fake IOMMU node, reserve phandle for it, etc), from the device tree PoV it looks indeed good (we reuse endpoint ID to pass the ID of the domain where the corresponding backend is running), and resulting code to retrieve this information in our DMA-mapping layer also looks simple enough [3]. Using generic device-tree IOMMU bindings:          iommu {                  compatible = "xen,grant-dma";                  #iommu-cells = <0x01>;                  phandle = <0xfde9>;          };          virtio@2000000 {                  compatible = "virtio,mmio";                  reg = <0x00 0x2000000 0x00 0x200>;                  interrupts = <0x00 0x01 0xf01>;                  interrupt-parent = <0xfde8>;                  dma-coherent;                  iommus = <0xfde9 0x01>;          }; Using Xen specific property:          virtio@2000000 {                  compatible = "virtio,mmio";                  reg = <0x00 0x2000000 0x00 0x200>;                  interrupts = <0x00 0x01 0xf01>;                  interrupt-parent = <0xfde8>;                  dma-coherent;                  xen,backend-domid = <0x01>;          }; The main problem is that idea doesn't quite fit into how Linux currently behaves for the "iommus" property. Of course, just reusing IOMMU bindings (without having a corresponding driver) leads to the deferred probe timeout issue afterwards, because the IOMMU device never becomes available. From my understanding, our DMA-mapping layer we are consider to reuse IOMMU bindings for, *cannot* be converted into the proper IOMMU driver. Sure, we will need to find a way how to deal with it, if we really want to reuse the IOMMU bindings. And yes, one idea was to just implement stub IOMMU driver for that purpose, I have rechecked, it works fine with that stub driver [4]. > > From a fw_devlik perspective, please implement a driver. Ideally a > real one, but at least an empty one. The empty one doesn't need to be > an IOMMU driver, but at least just do a return 0 in the probe > function. If I got things right, I am afraid, for the "of_iommu" case the empty driver is not enough. The driver should at least register iommu_ops, but the "of_xlate" callback should be *not* implemented. In that case, we will get NO_IOMMU (>0 : there is no IOMMU, or one was unavailable for non-fatal reasons) which is also a success condition, so -EPROBE_DEFER won't be returned. https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L32 Otherwise, of_iommu_xlate() will call driver_deferred_probe_check_state(). https://elixir.bootlin.com/linux/v5.18/source/drivers/iommu/of_iommu.c#L43 > Also, if it's not a device, why even have a "compatible" > property (removing it won't necessarily remove the deferred probe > timeout issue you see)? Will any code be using "xen,grant-dma" to look > up the node? Yes > If so, that driver could be the one that probes this > device. At least from a fw_devlink perspective, it just needs to have > a driver that binds to this device. Agree > > Also, if we aren't going to implement a driver and have the supplier > ("xen,grant-dma") behave like a device (as in, have a driver that > probes), I'd rather that the iommu binding not be used at all as this > would be an exception to how every other iommu device behaves. Agree Saravana, thank you for the explanation. To summarize, as I understand, we have three options (the first two are clear enough, the third is unclear yet): 1. Do not try to reuse IOMMU bindings for current xen-virtio enabling work, use "xen,backend-domid" property. 2. Reuse IOMMU bindings, for that purpose introduce stub IOMMU driver. It is a standalone entity in my example, but it can be a part of grant-dma-ops.c which actually uses "xen,grant-dma" compatible to look up a node. 3. Try to find other options how to reuse IOMMU bindings but *without* introducing stub IOMMU driver, such as skip list for deferred probe, etc. What do the maintainers think regarding the option to go forward? [1] https://lore.kernel.org/xen-devel/1651947548-4055-4-git-send-email-olekstysh@gmail.com/ [2] https://lore.kernel.org/xen-devel/1651947548-4055-7-git-send-email-olekstysh@gmail.com/ [3] https://lore.kernel.org/xen-devel/390ba7bb-ee9e-b7b7-5f08-71a7245fa4ec@gmail.com/ [4] https://lore.kernel.org/xen-devel/606dfdcc-ec10-0c4a-04e9-72cd73ee6676@gmail.com/ > > -Saravana -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed May 25 17:03:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 17:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337296.561849 (Exim 4.92) (envelope-from ) id 1ntuPo-00086A-Ne; Wed, 25 May 2022 17:03:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337296.561849; Wed, 25 May 2022 17:03:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntuPo-000863-KG; Wed, 25 May 2022 17:03:20 +0000 Received: by outflank-mailman (input) for mailman id 337296; Wed, 25 May 2022 17:03:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntuPn-00085t-KX; Wed, 25 May 2022 17:03:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntuPn-0005Go-Ei; Wed, 25 May 2022 17:03:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntuPn-0006AY-26; Wed, 25 May 2022 17:03:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntuPn-00047y-1h; Wed, 25 May 2022 17:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Jii++R8PwQPm7iRuQq3G6svGFcO6zmR9i2r8tW/gEWg=; b=XC0TlMfUnjVVLYvEEfBeatZaZr kKRbtmoqh5ntPka/Z7Ev8d0a5D5vMcE65sTA25dqh8MnqHE1VUw3+hIoYPdT+KUIU2U+Rq+mxzAeE yLvuy+FiNd6Pyy1tED/eu8EExWKmzXPlfR5fGdZHTuFMmwlweUAxhcEUgIuRq9bgb14Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170728: all pass - PUSHED X-Osstest-Versions-This: ovmf=9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a X-Osstest-Versions-That: ovmf=a21a3438f795deecb24e1843c1636f95c485017c From: osstest service owner Date: Wed, 25 May 2022 17:03:19 +0000 flight 170728 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170728/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a baseline version: ovmf a21a3438f795deecb24e1843c1636f95c485017c Last test of basis 170710 2022-05-23 18:12:51 Z 1 days Testing same since 170728 2022-05-25 12:40:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Isaku Yamahata jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git a21a3438f7..9c733f0b90 9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed May 25 17:33:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 17:33:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337306.561860 (Exim 4.92) (envelope-from ) id 1ntusL-0002r8-5K; Wed, 25 May 2022 17:32:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337306.561860; Wed, 25 May 2022 17:32:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntusL-0002r1-10; Wed, 25 May 2022 17:32:49 +0000 Received: by outflank-mailman (input) for mailman id 337306; Wed, 25 May 2022 17:32:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntusJ-0002qr-QZ; Wed, 25 May 2022 17:32:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntusJ-0005lX-OB; Wed, 25 May 2022 17:32:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntusJ-00071q-Ev; Wed, 25 May 2022 17:32:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntusJ-0007Tf-EW; Wed, 25 May 2022 17:32:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UabrJf7BKrKzFP/7ats1DPPoLoP9l4yBG19SfznrJwM=; b=sIB3Lfy7KBrmaNR2uaY+Wgv0to aN5FGpzKB1zAXOjiFmWZjznIbcqAX+OJA8AYTTBmrfYy2Y9Eo3Wbe8x87Glw8gmuGVHCnROWCJiMO DY0eHKPxPoHPooYcfGUSYwiss8ezLZZigkQUnWg2QCsN1a4KziSxUhrsJwm+j+V9WqYE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 170730: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49399b101e38fb2c11478c849ffdaaace8e318a8 From: osstest service owner Date: Wed, 25 May 2022 17:32:47 +0000 flight 170730 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/170730/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49399b101e38fb2c11478c849ffdaaace8e318a8 Last test of basis 170719 2022-05-25 00:00:26 Z 0 days Failing since 170725 2022-05-25 09:01:46 Z 0 days 2 attempts Testing same since 170730 2022-05-25 14:01:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Elliott Mitchell Jan Beulich Juergen Gross Julien Grall Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 49399b101e..49dd52fb13 49dd52fb1311dadab29f6634d0bc1f4c022c357a -> smoke From xen-devel-bounces@lists.xenproject.org Wed May 25 17:50:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 17:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337317.561871 (Exim 4.92) (envelope-from ) id 1ntv9o-0005FA-QY; Wed, 25 May 2022 17:50:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337317.561871; Wed, 25 May 2022 17:50:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntv9o-0005F3-Mm; Wed, 25 May 2022 17:50:52 +0000 Received: by outflank-mailman (input) for mailman id 337317; Wed, 25 May 2022 17:50:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntv9m-0005Ex-Pd for xen-devel@lists.xenproject.org; Wed, 25 May 2022 17:50:51 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34ae5900-dc53-11ec-837f-e5687231ffcc; Wed, 25 May 2022 19:50:48 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AEEE1320096D; Wed, 25 May 2022 13:50:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 25 May 2022 13:50:45 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 13:50:43 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34ae5900-dc53-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653501044; x= 1653587444; bh=f9VnyOtZqXUWrMce84m2QLDpjEOWiin85RMdEmMsHp8=; b=a 7bv2qZ6iWdEj2TDkEISuYBy5DdbvXzQTyTw6KTz/0WSHUF7jMXg1RMhVXcqkEc2K USk5mGL1IVMgv0fa7Mgf36IbVX9YBrEF96gSw1DCZA5T9Ryifszb4jD+f92ZBXV1 6aufdEbYFZHf8uqbok9924B98mtRtwOtVrjyPF4nEqYncwpizJfGnERiP2oTSd9k B0hBcEg1BfJXsM8uPW5ESx8HY9Wv9MOeZwgD12OLUQzihwLLBdpZm3fcHJRH+0JD msxpOxJcj7eFwAifayC/ETxpFN5+4eOrRPLBgBE2yXWz0aDqgJo3ns0B9mlJBYPO w87c+R3niKCxNqjjOfDLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653501044; x=1653587444; bh=f9VnyOtZqXUWrMce84m2QLDpjEOW iin85RMdEmMsHp8=; b=sEggMZwAaFSpgNwQr7oCW9cOkluGqzEYG5geF8GSCJgx qn1Friddm1VSoPbv2CEaoisuNMDrKGg26QgQXlbPQPivm6pJQ9hQsJaI562dNNC2 ss+fnYkuxe3o/S7yipm0WBys7dUJir2JWXP9v49CGtzx5CJ1ZFf/bMaoyxycQrbB 24QmEZxLsw1cc3BllswG5E3vAPlhhXnpud/vYwA76QLjcZNI3BDgMBc8Crjbu1lk 33Dd8WBvZe8mjNkRCD0qNYsREA3uxVfLG6zlCljH1X+ew1iW99qIMF3+UsLa24T1 k70X7qQiiuNZSCT8aKQGuwU97Vo1+oLs5HZPVejxhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeehgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeuvdekffffieduhedtkeevkedu fedvkeeiheffvdegueetteehgfefieetudfgnecuffhomhgrihhnpehgihhthhhusgdrtg homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 25 May 2022 13:50:37 -0400 From: Demi Marie Obenour To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() Message-ID: References: <36489ed0-d2ec-92bc-6a15-b423118f8af2@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tH1jpdVHmorgFwLg" Content-Disposition: inline In-Reply-To: <36489ed0-d2ec-92bc-6a15-b423118f8af2@suse.com> --tH1jpdVHmorgFwLg Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 25 May 2022 13:50:37 -0400 From: Demi Marie Obenour To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , David Vrabel Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/gntdev: Avoid blocking in unmap_grant_pages() On Wed, May 25, 2022 at 11:17:39AM +0200, Juergen Gross wrote: > On 24.05.22 18:45, Demi Marie Obenour wrote: > > unmap_grant_pages() currently waits for the pages to no longer be used. > > In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a > > deadlock against i915: i915 was waiting for gntdev's MMU notifier to > > finish, while gntdev was waiting for i915 to free its pages. I also > > believe this is responsible for various deadlocks I have experienced in > > the past. > >=20 > > Avoid these problems by making unmap_grant_pages async. This requires > > making it return void, as any errors will not be available when the > > function returns. Fortunately, the only use of the return value is a > > WARN_ON(). Replace this with WARN_ON()s where errors are detected. >=20 > Not all callers of unmap_grant_pages() are issuing a WARN_ON(). Are you > sure that this change can't result in a flood of WARN()s? It probably can, but for a different reason. Since the actual unmap is now asynchronous, the handle is set to INVALID_GRANT_HANDLE too late to prevent double unmaps. I will fix this by using a separate bool array in v2. Another option is to (ab)use the paddding bits in the hypercall struct, but that seems too fragile. > Please note that you are modifying the semantics in case of an unmap > operation returning an error. Previously there were no further unmaps > done in this case, while now you are basically continue unmapping even > after hitting an error. This seems to be fine, but is worth mentioning > in the commit message. Will fix in v2, thanks. > > Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are = still in use") > > Cc: stable@vger.kernel.org > > Signed-off-by: Demi Marie Obenour > > --- > > drivers/xen/gntdev-common.h | 4 ++ > > drivers/xen/gntdev.c | 82 ++++++++++++++++++------------------- > > 2 files changed, 45 insertions(+), 41 deletions(-) > >=20 > > diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h > > index 20d7d059dadb..a6e2805ea2ce 100644 > > --- a/drivers/xen/gntdev-common.h > > +++ b/drivers/xen/gntdev-common.h > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > struct gntdev_dmabuf_priv; > > @@ -73,6 +74,9 @@ struct gntdev_grant_map { > > /* Needed to avoid allocation in gnttab_dma_free_pages(). */ > > xen_pfn_t *frames; > > #endif > > + > > + /* Needed to avoid allocation in __unmap_grant_pages */ > > + struct gntab_unmap_queue_data unmap_data; > > }; > > struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, i= nt count, > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c > > index 59ffea800079..670d800e4a89 100644 > > --- a/drivers/xen/gntdev.c > > +++ b/drivers/xen/gntdev.c > > @@ -62,8 +62,8 @@ MODULE_PARM_DESC(limit, > > static int use_ptemod; > > -static int unmap_grant_pages(struct gntdev_grant_map *map, > > - int offset, int pages); > > +static void unmap_grant_pages(struct gntdev_grant_map *map, > > + int offset, int pages); > > static struct miscdevice gntdev_miscdev; > > @@ -349,61 +349,65 @@ int gntdev_map_grant_pages(struct gntdev_grant_ma= p *map) > > return err; > > } > > -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offse= t, > > - int pages) > > +static void __unmap_grant_pages_done(int result, > > + struct gntab_unmap_queue_data *data) > > { > > - int i, err =3D 0; > > - struct gntab_unmap_queue_data unmap_data; > > - > > - if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { > > - int pgno =3D (map->notify.addr >> PAGE_SHIFT); > > - if (pgno >=3D offset && pgno < offset + pages) { > > - /* No need for kmap, pages are in lowmem */ > > - uint8_t *tmp =3D pfn_to_kaddr(page_to_pfn(map->pages[pgno])); > > - tmp[map->notify.addr & (PAGE_SIZE-1)] =3D 0; > > - map->notify.flags &=3D ~UNMAP_NOTIFY_CLEAR_BYTE; > > - } > > - } > > - > > - unmap_data.unmap_ops =3D map->unmap_ops + offset; > > - unmap_data.kunmap_ops =3D use_ptemod ? map->kunmap_ops + offset : NUL= L; > > - unmap_data.pages =3D map->pages + offset; > > - unmap_data.count =3D pages; > > - > > - err =3D gnttab_unmap_refs_sync(&unmap_data); > > - if (err) > > - return err; > > + int i; >=20 > Mind using unsigned int instead? Not at all. I used int because that is what the original code used, but an unsigned type is definitely better. > > + struct gntdev_grant_map *map =3D data->data; > > + int offset =3D data->unmap_ops - map->unmap_ops; > > - for (i =3D 0; i < pages; i++) { > > - if (map->unmap_ops[offset+i].status) > > - err =3D -EINVAL; > > + for (i =3D 0; i < data->count; i++) { > > + WARN_ON(map->unmap_ops[offset+i].status); > pr_debug("unmap hand= le=3D%d st=3D%d\n", > > map->unmap_ops[offset+i].handle, > > map->unmap_ops[offset+i].status); > > map->unmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE; > > if (use_ptemod) { > > - if (map->kunmap_ops[offset+i].status) > > - err =3D -EINVAL; > > + WARN_ON(map->kunmap_ops[offset+i].status); > > pr_debug("kunmap handle=3D%u st=3D%d\n", > > map->kunmap_ops[offset+i].handle, > > map->kunmap_ops[offset+i].status); > > map->kunmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE; > > } > > } > > - return err; > > } > > -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, > > - int pages) > > +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offs= et, > > + int pages) > > +{ > > + if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { > > + int pgno =3D (map->notify.addr >> PAGE_SHIFT); > > + > > + if (pgno >=3D offset && pgno < offset + pages) { > > + /* No need for kmap, pages are in lowmem */ > > + uint8_t *tmp =3D pfn_to_kaddr(page_to_pfn(map->pages[pgno])); > > + > > + tmp[map->notify.addr & (PAGE_SIZE-1)] =3D 0; > > + map->notify.flags &=3D ~UNMAP_NOTIFY_CLEAR_BYTE; > > + } > > + } > > + > > + map->unmap_data.unmap_ops =3D map->unmap_ops + offset; > > + map->unmap_data.kunmap_ops =3D use_ptemod ? map->kunmap_ops + offset = : NULL; > > + map->unmap_data.pages =3D map->pages + offset; > > + map->unmap_data.count =3D pages; > > + map->unmap_data.done =3D __unmap_grant_pages_done; > > + map->unmap_data.data =3D map; >=20 > I think you need to call refcount_inc(&map->users) here and do the related > gntdev_put_map() call in __unmap_grant_pages_done(). Otherwise you are ri= sking > to have map freed before the async operation has finished. Whoops, good catch. Will fix in v2. > > + > > + gnttab_unmap_refs_async(&map->unmap_data); > > +} > > + > > +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, > > + int pages) > > { > > - int range, err =3D 0; > > + int range; > > pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pa= ges); > > /* It is possible the requested range will have a "hole" where we > > * already unmapped some of the grants. Only unmap valid ranges. > > */ > > - while (pages && !err) { > > + while (pages) { > > while (pages && > > map->unmap_ops[offset].handle =3D=3D INVALID_GRANT_HANDLE) { > > offset++; > > @@ -416,12 +420,10 @@ static int unmap_grant_pages(struct gntdev_grant_= map *map, int offset, > > break; > > range++; > > } > > - err =3D __unmap_grant_pages(map, offset, range); > > + __unmap_grant_pages(map, offset, range); > > offset +=3D range; > > pages -=3D range; > > } > > - > > - return err; > > } > > /* ------------------------------------------------------------------= */ > > @@ -473,7 +475,6 @@ static bool gntdev_invalidate(struct mmu_interval_n= otifier *mn, > > struct gntdev_grant_map *map =3D > > container_of(mn, struct gntdev_grant_map, notifier); > > unsigned long mstart, mend; > > - int err; > > if (!mmu_notifier_range_blockable(range)) > > return false; > > @@ -494,10 +495,9 @@ static bool gntdev_invalidate(struct mmu_interval_= notifier *mn, > > map->index, map->count, > > map->vma->vm_start, map->vma->vm_end, > > range->start, range->end, mstart, mend); > > - err =3D unmap_grant_pages(map, > > + unmap_grant_pages(map, > > (mstart - map->vma->vm_start) >> PAGE_SHIFT, > > (mend - mstart) >> PAGE_SHIFT); > > - WARN_ON(err); > > return true; > > } --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --tH1jpdVHmorgFwLg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKObHMACgkQsoi1X/+c IsELJhAAuIAx7uIeEyQhBZBAzwtSmYh5IdUkfopnk1jPiGmuJPbj5010dCgT98/G k7+U58vCM6YhJRvTQxBF4BU3UCMJ8/Zgtp9DgUAk86tq8eR//sg8TM367N0EzISi mFN2mZTShVwxQa/aL5y9GazQd9x2afoWNhb5+0ygHpnbL+Ik+iFf0G4etjFKcnU4 EBnQXxBrVSMoYauyNxYdTHpVJmAr89+xvFcuhFxPX0RatzoIBk76NydBguBVSkIK K7apSkRx12sOVN7rJmm7gVw3xA9YaEZGsLaXH414cuMgl2rZmekpYx3VsXD+XtBO snUZcFuRWwHbjSEBJBpYhicqdPXZXTqZVd0yNpjaZ89Nt5HAECyJum4mddRA2h4H VFcLzwkyG3JgWd8QX0aP7QxhHxWDuGATBJDQGKo5/7BxwB7HMO2jHYEioLUhlvRx Gfjpx7Jmz29xwfYjr/KNm405LtazRWFtXSD2r/uw0E0e69UCc7LrrjAI4Sgw1u11 n0Rsf63IOL7HatEPklfEpO9nKRJAPb35JRpUMXc8I2sOleVkXekX1MhhP/t4bzxw bH2/uVczKGWh6u+7OTAxhv+Al//Gj898j7BL4VVN9T0IqbD1vFYeVo+OooJBn0rj tPs58kNVGs+fkh3K4x/kKRR/l+4AblzKtyTmW1TAqdDgWDJQY9U= =7NB2 -----END PGP SIGNATURE----- --tH1jpdVHmorgFwLg-- From xen-devel-bounces@lists.xenproject.org Wed May 25 18:27:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 18:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337326.561882 (Exim 4.92) (envelope-from ) id 1ntvj6-0000C4-JO; Wed, 25 May 2022 18:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337326.561882; Wed, 25 May 2022 18:27:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvj6-0000Bx-G3; Wed, 25 May 2022 18:27:20 +0000 Received: by outflank-mailman (input) for mailman id 337326; Wed, 25 May 2022 18:27:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvj5-0000Bn-AZ; Wed, 25 May 2022 18:27:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvj5-0006lw-6T; Wed, 25 May 2022 18:27:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvj4-00019X-Rr; Wed, 25 May 2022 18:27:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntvj4-0005oM-RP; Wed, 25 May 2022 18:27:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M3Oq3EncCKyRByNgMXoYGxNz2JSFBsFnrONWAyZLoL4=; b=d9QZIrhn4Mprn/hyz0Kc94j9V7 MJ7O4f8GzYAoMuCZKgiELxhmvAY8BQUNkoCg/G38Y9dInUZkmGVaC8bIcmx4KFsVsa48D9pRoDJn0 S4L8mFZ5iFLDdQcllBXzHB4zHTSkZEUu4bs2NnNOG3g8JuIwK1DTco0v9YsR0ClFPvCw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170724: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=04b092e4a01a3488e762897e2d29f85eda2c6a60 X-Osstest-Versions-That: linux=0187300e6aa6246e9cebb22e2afbbc0d395839ee From: osstest service owner Date: Wed, 25 May 2022 18:27:18 +0000 flight 170724 linux-5.4 real [real] flight 170734 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170724/ http://logs.test-lab.xenproject.org/osstest/logs/170734/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 170532 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170532 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170532 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170532 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170532 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170532 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170532 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170532 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170532 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170532 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170532 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 04b092e4a01a3488e762897e2d29f85eda2c6a60 baseline version: linux 0187300e6aa6246e9cebb22e2afbbc0d395839ee Last test of basis 170532 2022-05-18 08:13:22 Z 7 days Testing same since 170724 2022-05-25 07:43:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abel Vesa Al Viro Alexandre Belloni Andrew Lunn Andrew Morton Anna Schumaker Anton Eidelman Anton Eidelman Ard Biesheuvel Arnaldo Carvalho de Melo Bartosz Golaszewski Benson Leung Bjorn Helgaas Christian König Christoph Hellwig Christophe JAILLET Codrin Ciubotariu David Gow David Howells David S. Miller Denis Efremov Dmitry Torokhov Duoming Zhou Felix Fietkau Florian Fainelli Gleb Chesnokov Grant Grundler Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Gwendal Grignou Haibo Chen Hangyu Hua Harini Katakam Herbert Xu Hulk Robot Ido Schimmel Jae Hyun Yoo Jakob Koschel Jakub Kicinski Jason Wang Jeff LaBundy Jens Axboe Jiasheng Jiang Joel Stanley Johannes Berg Juergen Gross Jérôme Pouiller kafs-testing+fedora34_64checkkafs-build-496@auristor.com Kai-Heng Feng Kevin Mitchell Khalid Masum Lin Yujun Linus Torvalds Linux Kernel Functional Testing linyujun Luis Chamberlain Lyude Paul Marek Vasut Mario Limonciello Markus Boehme Markus Suvanto Martin K. Petersen Maxim Mikityanskiy Meena Shanmugam Michael S. Tsirkin Michal Simek Ming Lei Miroslav Benes Mohammad Athari Bin Ismail Nicolas Dichtel Nikolay Aleksandrov Oleksandr Natalenko Ondrej Mosnacek Ovidiu Panait Paolo Abeni Paolo Bonzini Paul Greenwalt Peter Zijlstra (Intel) Peter Zijlstra Philippe Schenker Radhey Shyam Pandey Rafael J. Wysocki Raul E Rangel Richard Weinberger Russell King (Oracle) Ryusuke Konishi Saeed Mahameed Sasha Levin Sean Christopherson Shawn Guo Shuah Khan Steffen Klassert Stephen Boyd Sudip Mukherjee Takashi Iwai Tan Tee Min Thiébaud Weksteen Thomas Bogendoerfer Thomas Richter Tony Nguyen Trond Myklebust Tzung-Bi Shih Ulf Hansson Uwe Kleine-König Vincent Whitchurch Willy Tarreau Wolfram Sang Wong Vee Khee Xiaoke Wang Yang Yingliang Zheng Yongjun Zixuan Fu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2030 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 25 18:42:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 18:42:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337338.561896 (Exim 4.92) (envelope-from ) id 1ntvxd-0002YH-2B; Wed, 25 May 2022 18:42:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337338.561896; Wed, 25 May 2022 18:42:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvxc-0002YA-VX; Wed, 25 May 2022 18:42:20 +0000 Received: by outflank-mailman (input) for mailman id 337338; Wed, 25 May 2022 18:42:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntvxc-0002Y4-6i for xen-devel@lists.xenproject.org; Wed, 25 May 2022 18:42:20 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65de278b-dc5a-11ec-837f-e5687231ffcc; Wed, 25 May 2022 20:42:16 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 324F55C00F1; Wed, 25 May 2022 14:42:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 25 May 2022 14:42:15 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 14:42:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65de278b-dc5a-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm1; t=1653504135; x= 1653590535; bh=IzC1Lf6nigMRWiB9U/JcQwb9cl+2WkqbqCQ8B2xwhgQ=; b=s 6ZP5jmjsZIoyBGP4epU3kxEFo1+la+txzb8Lwu9EpCUdo67NzNiBGyMBKb2qNVXG 580T5/EfIsj1IAM5AZHSBDarEsdGz0fVu5O4CoLnNlqksMJeGR0tdgEHx/9t+I/t xJz6gvWdCX7GS/IFCRJdoUAlU3oaJ832DWq8AGOgE6+p8iOtkYuto5Vx2QRBUkiU VCI2g6ea6rnz6Q+CftOvlp938vebEW9kP/SI2kN1siwxSycKilfpam1mbU6va3+4 2WBN6val8LlLbtZTH6nfuwHU+gFNNHPYesjh4jLbhV9nhcxdbqbKWndeX/gTb+Lu nfR4VzcYpxdUaWLNx6apQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1653504135; x=1653590535; bh=IzC1Lf6nigMRWiB9U/JcQwb9cl+2WkqbqCQ 8B2xwhgQ=; b=hgYCk+9L+3wKSB7dO0pFs73z2RoYenuk8rByPFtDwl2EIrJz+qH loluingXVrThMudBibrCFJNkkCWTi/TqNNVWpreTArOfWUUpNXg8jBSubnL4qSUp UwlMYuqvgHrC7bHZkzgtEDxBYwPr7Ad/5a2TNnaf1cSkheqo/bR2tp02yG7C6Q+a hbU+YSP6ZCCrZzscu5Ej+d9aOWZtlkfprXaeM9mfce5A1LQENwp4913lA1FYhDxP 43sKka8D3ULAP6VFyOvPoSL6kGEpOsrNrUAsNrGbfRq2j+aWxUzKYCGh96BsWv8c 3K6ahDga19tUCb++gFPcfDpP0EwhFMTbxuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeehgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepieejgedufeeukeeijedukefgueekvdeg iedtudefhfdtffehffeuveefvdfglefgnecuffhomhgrihhnpehgihhthhhusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Jennifer Herbert , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Wed, 25 May 2022 14:41:53 -0400 Message-Id: <20220525184153.6059-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour --- drivers/xen/gntdev-common.h | 5 ++ drivers/xen/gntdev.c | 100 +++++++++++++++++++----------------- 2 files changed, 59 insertions(+), 46 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 20d7d059dadb..a268cdb1f7bf 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -16,6 +16,7 @@ #include #include #include +#include struct gntdev_dmabuf_priv; @@ -56,6 +57,7 @@ struct gntdev_grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; @@ -73,6 +75,9 @@ struct gntdev_grant_map { /* Needed to avoid allocation in gnttab_dma_free_pages(). */ xen_pfn_t *frames; #endif + + /* Needed to avoid allocation in __unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 59ffea800079..90bd2b5ef7dd 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include @@ -62,8 +63,8 @@ MODULE_PARM_DESC(limit, static int use_ptemod; -static int unmap_grant_pages(struct gntdev_grant_map *map, - int offset, int pages); +static void unmap_grant_pages(struct gntdev_grant_map *map, + int offset, int pages); static struct miscdevice gntdev_miscdev; @@ -120,6 +121,7 @@ static void gntdev_free_map(struct gntdev_grant_map *map) kvfree(map->unmap_ops); kvfree(map->kmap_ops); kvfree(map->kunmap_ops); + kvfree(map->being_removed); kfree(map); } @@ -140,10 +142,13 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, add->unmap_ops = kvmalloc_array(count, sizeof(add->unmap_ops[0]), GFP_KERNEL); add->pages = kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kvcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; if (use_ptemod) { add->kmap_ops = kvmalloc_array(count, sizeof(add->kmap_ops[0]), @@ -349,79 +354,84 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) return err; } -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; - - if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { - int pgno = (map->notify.addr >> PAGE_SHIFT); - if (pgno >= offset && pgno < offset + pages) { - /* No need for kmap, pages are in lowmem */ - uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); - tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; - map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; - } - } - - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; - - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; + unsigned int i; + struct gntdev_grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - if (map->kunmap_ops[offset+i].status) - err = -EINVAL; + WARN_ON(map->kunmap_ops[offset+i].status); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; } } - return err; + + /* Release reference taken by __unmap_grant_pages */ + gntdev_put_map(NULL, map); } -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) +{ + if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { + int pgno = (map->notify.addr >> PAGE_SHIFT); + + if (pgno >= offset && pgno < offset + pages) { + /* No need for kmap, pages are in lowmem */ + uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; + map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; + } + } + + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + refcount_inc(&map->users); /* to keep map alive during async call below */ + + gnttab_unmap_refs_async(&map->unmap_data); +} + +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) { - int range, err = 0; + int range; pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && - map->unmap_ops[offset].handle == INVALID_GRANT_HANDLE) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset + range].handle == - INVALID_GRANT_HANDLE) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -473,7 +483,6 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn, struct gntdev_grant_map *map = container_of(mn, struct gntdev_grant_map, notifier); unsigned long mstart, mend; - int err; if (!mmu_notifier_range_blockable(range)) return false; @@ -494,10 +503,9 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn, map->index, map->count, map->vma->vm_start, map->vma->vm_end, range->start, range->end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); return true; } -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed May 25 19:24:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 19:24:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337347.561907 (Exim 4.92) (envelope-from ) id 1ntwcl-0006jQ-7w; Wed, 25 May 2022 19:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337347.561907; Wed, 25 May 2022 19:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwcl-0006jJ-4J; Wed, 25 May 2022 19:24:51 +0000 Received: by outflank-mailman (input) for mailman id 337347; Wed, 25 May 2022 19:24:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwcj-0006j9-G3; Wed, 25 May 2022 19:24:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwcj-0007jL-Cp; Wed, 25 May 2022 19:24:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwcj-0004Tm-00; Wed, 25 May 2022 19:24:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntwci-0001Ym-Vn; Wed, 25 May 2022 19:24:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IVLW4RXolkT/RNNgL0bYO9vufXKOaEz/c2OojVE6tFM=; b=FQE/mEq01Hydw69otkYQD7xKdU FcE11vmyNtZneqOqElCZWiUpgp1O2zIEEkoYOLTZu8FxHy84Eo6SJXsu9CPzYVmaAJ4QuJlL0+qTX e0t/KHjjxx/QxBIWK2er1nLpxF+fYTcT6eFKO5sElBZojyIM4M49W4+kdRcdzI61uIAg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170723: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:leak-check/basis(11):fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=fdaf9a5840acaab18694a19e0eb0aa51162eeeed X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Wed, 25 May 2022 19:24:48 +0000 flight 170723 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170723/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 11 leak-check/basis(11) fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux fdaf9a5840acaab18694a19e0eb0aa51162eeeed baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 1 days Failing since 170716 2022-05-24 11:12:06 Z 1 days 4 attempts Testing same since 170723 2022-05-25 05:36:40 Z 0 days 1 attempts ------------------------------------------------------------ 552 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 40627 lines long.) From xen-devel-bounces@lists.xenproject.org Wed May 25 19:26:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 19:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337358.561918 (Exim 4.92) (envelope-from ) id 1ntwdw-0007LL-O7; Wed, 25 May 2022 19:26:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337358.561918; Wed, 25 May 2022 19:26:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwdw-0007LE-Kp; Wed, 25 May 2022 19:26:04 +0000 Received: by outflank-mailman (input) for mailman id 337358; Wed, 25 May 2022 19:26:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntwdt-000759-J7 for xen-devel@lists.xenproject.org; Wed, 25 May 2022 19:26:02 +0000 Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80d74aef-dc60-11ec-bd2c-47488cf2e6aa; Wed, 25 May 2022 21:25:59 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Wed, 25 May 2022 19:25:57 +0000 Received: by hermes--canary-production-bf1-856dbf94db-flf4d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 71f1d64437d4ce01e2d3c39def3c457f; Wed, 25 May 2022 19:25:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80d74aef-dc60-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1653506757; bh=CqSeobj0+5OSFGPYrNmN6IIV1PtHre5LbZFH1gf5kWY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=MYrUvxfXbRz/ymusizK41DG+kcUNIndp8n+3lwgzUH5HQEdnrnGrGlcCH7VgUXyMVuqo+8z2r95iFLiqExFxTWLaJwQt0GKK9risua060H6lNvRLsBeRZXGzZxXpJsW5oftiYFjssDGdH85aCVBujiEEtsCZUonXNC2T4ZFfxV0CLR0FprYRfvP8zmxLOFO/Y0lhSP6KJZs/0u346LG0rfAnau85B6CF/+BC8iGhoXcW8XXGtxKl98OaZjeBgBFEKIS3ZePxLCi8XjH0cKnZIr4A7aTsx1h1KFDntXvuHLNJOjetG/iDGtcWQ0Pe3hMciytfsp069otjj6hLAqs28w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653506757; bh=wZXN4K6+z3p6ahdKNw4lPDfOu4i/i67NYSfuSnzPXqK=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ddBm+EQa5x7yx+2Dsf8D8h6rcJXoXoBJqQJ+zPYeWmqfKZGkasM3mXyci7cpLaOSjkZzG11galPEgq3Ymj2u9jNv56oiS2cM6IcgckTEe7uvl7L+jIhDWQ8XkFxcJ0MlSRVVl0wwv0Z4TZytVcu4bhFuad2S6ZGrC8t0y5rlOVaFWt3GlNK36cngcv7a9UCjXpb2GDxJ1+fP0ISSFriS/a9SCmF2UtGJBoOCAjCE7z0+A8zI9WwK9t1MAEffCHJKpiE3L4JmsocefQWnN/k7CQzdJt6bs3Jd2cCcK+KR7e+P9klNh7/bNZodedYShmA9eTO78l3xIqpsAWUAd66MWg== X-YMail-OSG: bG1wjyQVM1kgs5ozPVs6xfKrqT7Xxx9Lwqs6A0PdCa9mHjR4sgvMH2a8gWk7lEf pJfMk1EoiwTwnMxEQynVYO5VOOiZdvw265ZUVeAgY3Xd3iXU9sGCx6.fsm3ZKjmgUBlHQtBoLhDZ M0LZ8_MepTQ__dwrxobBmoufx7qdjhcn6qlpF9mGFqvXPQMQC4u6sQII9_xf3fGPL_C0DMvnjh5y ImiZ94nwCEHiwTLbxAkP.qwdvyDKGN4fqigSCoz_wU9KSg9_mW44TdFlZ2L6Z9fbp9yRuhEJRouQ 9A3pBzoXNSw9wbYM.8YcIgF8EK6gcuIfTywqRkeyClMGsKUcsk0ZHFkzqtQVW6oGaj7CAA24pIAq 6wVyr9uckZ2uNAuaP2ccrgvVWPqQGqW7jZnRWE.UBlnCSncj56KvW7nkkxMgi.FDFy1m1xPVsh9y 3dDxq2ox9f7oRbrVeeihuupDwZPEWh0VAL0KX5mfh4YTcBvi5oBTaJT8QAHZhicuYXDpRZ8gsJ3T vAVSLwy.J0D4mj7h0kYQwg6hel4ULy.pwzzPgbjd8ZkKQ4im9FWBDG8j.9HvnvOyC4ivXpQAQFvH mHXXQeOQP9VXkUL8kXM7bRfZQSkiV4q36BC14WLuxeDhva1h5RxNOO9z3C_3BaPc3DXmU4zPAER9 sK2fGGLGrzhcQrXq.B2lflhPeHXVBpD7sxzSGZYzHm0YxtADqCEX3D4pFh71_3OX3Ga22PAND_9p WSaOorVbZqITmt6fxpQuAs2vku4nKrz_g0IpCKejbGEyCjAzqoJ0JYlorxMXTbA1fDd6k4obdGBJ FB8ogdTr5484.g4m8jeBoLSxFRBwP3NRKCBs4pXAPSa3sF6FEqLR7i9BBcxL_jmk_X6hH7xXcEtH T7RrqY4OGuIOeTU_gFclTML2pFzmk2vY6vBjKw.crk8MpBpIrNBh3sqHq3.ABRTvEFR6FudPulbB B3M_Vq1rmnATHcyklZgKHpiLi__VOemJDANdTX0qP.MyFSFj30u2ACGSf6qKQ_dcfMpVT7rArU7D ygX.0pYgB.Au46qjr5yzlTc8I9FZNkz6OS7qC_cb_xcQzMjZLMnNY_p9ztbyrMNHKIY4R6Rd04Pa CTIYN4CmGr7zWO4NEz62OFVdiEAHRgKCEFy5GDSwIcBi01PKZTAJdAKTfXf95EIHR.JvRkZ2L44w uyR_zZdo0rDx9Gk3cE4_EfZvARqXDB0NiCIW5.p7Cos_H3LjzsRHBh2PzF1cCfAJ_z9q5spzZDMl nKz2oJhbQuG8ct9r0.IFonDYDWSM94xWQrWTL4PchTfXRNTBnDObo_6Ool3rAwjWgK2ay_iL7cjI x924Gb0TNaIJHYQcdbYpg4Ar27qEBUNv48ujpQnC2H2i4XeowzOpy6puXSjbRJtZfG5jx4kIohxc 4N3SL5pLSGVn7yMjsUKBxWsOFmczf2d8ANCb.qAmc8wT2.DBteg7P0vKzUQOg1RrPizuBR7vFapD XaqGEP63LcCSisysvM8f_0sfj1eMrwSUQQGqzPoIJMh4kjT4SAJUiQ7S0UWFEXUyAVKbV2VLat78 .BcMothVtvGIYYrYn6kIyzwEjRtzrBCe52uhDDObwCebkODL1HcCVJJEFj9lgj86tKXbfdvk5H6z 770LiPVxm.08K4AaMPKNrsvJV7DhESNx9IaXZoV7CIuHYl7MVfHcPVKvW.jRio5jWV5qGeZj0s.d BE_8JAEjDwrj35X.v2Y8lq1By0fXlrNoh9qBy5EM_c_rePqqYSbd3KPUX_b72SpHY1i_Rt92Uu.v Lo4fqZuwit9Zp3nSw1RASZgWCWvJv5xKtjlSzaYIJG0GRENiSfgHvUvAMPWyaAuDcTzsJL2eAa_Y htCXSKsUXTc3.IUM0EXt2s5QpHqHoVRV5w2RwqjMmKpeAQ2YbSBpsMg0AK0R2DTBvZZHyNU8O6rt lzhHguC_nR2Tl4ptalLpm7ks2d5mtBxyZAoQh80CdFQi_vYgPn_WAXKzs64EEbpCo3QW_wKEwl5S X0XO5cv8S_Kl5iB2A.J9eUoJ2pBWt4M1IkcQJM7gyKP_.atmuehdHkoXiV9kkMtzCE6ixnNTcIeX XqqyRudrgRz8Lo_2G46B7_kZXj3MFO2vDu2SDOpactByeIAkBpLjy7sMQ492NDDlSnx3UY4vzlEy mttTpT01FKuu1hXwTGrV82mKFzbJINW49gprb1.HcO2Bt948cy1f2jtANKDwCm1ZhrZMTTUFdpgD 9y6KaJTb5.Vs- X-Sonic-MF: Message-ID: Date: Wed, 25 May 2022 15:25:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] x86/pat: add functions to query specific cache mode availability Content-Language: en-US To: Thorsten Leemhuis , Jan Beulich , regressions@lists.linux.dev, stable@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Juergen Gross References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-3-jgross@suse.com> <1d86d8ff-6878-5488-e8c4-cbe8a5e8f624@suse.com> <0dcb05d0-108f-6252-e768-f75b393a7f5c@suse.com> <77255e5b-12bf-5390-6910-dafbaff18e96@netscape.net> <8b1ebea5-7820-69c4-2e2b-9866d55bc180@netscape.net> <3bff3562-bb1e-04e6-6eca-8d9bc355f2eb@suse.com> <3ca084a9-768e-a6f5-ace4-cd347978dec7@netscape.net> <9af0181a-e143-4474-acda-adbe72fc6227@suse.com> <3fc70595-3dcc-4901-0f3f-193f043b753f@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 10254 On 5/25/2022 3:45 AM, Thorsten Leemhuis wrote: > On 24.05.22 20:32, Chuck Zmudzinski wrote: >> On 5/21/22 6:47 AM, Thorsten Leemhuis wrote: >>> On 20.05.22 16:48, Chuck Zmudzinski wrote: >>>> On 5/20/2022 10:06 AM, Jan Beulich wrote: >>>>> On 20.05.2022 15:33, Chuck Zmudzinski wrote: >>>>>> On 5/20/2022 5:41 AM, Jan Beulich wrote: >>>>>>> On 20.05.2022 10:30, Chuck Zmudzinski wrote: >>>>>>>> On 5/20/2022 2:59 AM, Chuck Zmudzinski wrote: >>>>>>>>> On 5/20/2022 2:05 AM, Jan Beulich wrote: >>>>>>>>>> On 20.05.2022 06:43, Chuck Zmudzinski wrote: >>>>>>>>>>> On 5/4/22 5:14 AM, Juergen Gross wrote: >>>>>>>>>>>> On 04.05.22 10:31, Jan Beulich wrote: >>>>>>>>>>>>> On 03.05.2022 15:22, Juergen Gross wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> ... these uses there are several more. You say nothing on why >>>>>>>>>>>>> those want >>>>>>>>>>>>> leaving unaltered. When preparing my earlier patch I did >>>>>>>>>>>>> inspect them >>>>>>>>>>>>> and came to the conclusion that these all would also better >>>>>>>>>>>>> observe the >>>>>>>>>>>>> adjusted behavior (or else I couldn't have left pat_enabled() >>>>>>>>>>>>> as the >>>>>>>>>>>>> only predicate). In fact, as said in the description of my >>>>>>>>>>>>> earlier >>>>>>>>>>>>> patch, in >>>>>>>>>>>>> my debugging I did find the use in i915_gem_object_pin_map() >>>>>>>>>>>>> to be >>>>>>>>>>>>> the >>>>>>>>>>>>> problematic one, which you leave alone. >>>>>>>>>>>> Oh, I missed that one, sorry. >>>>>>>>>>> That is why your patch would not fix my Haswell unless >>>>>>>>>>> it also touches i915_gem_object_pin_map() in >>>>>>>>>>> drivers/gpu/drm/i915/gem/i915_gem_pages.c >>>>>>>>>>> >>>>>>>>>>>> I wanted to be rather defensive in my changes, but I agree at >>>>>>>>>>>> least >>>>>>>>>>>> the >>>>>>>>>>>> case in arch_phys_wc_add() might want to be changed, too. >>>>>>>>>>> I think your approach needs to be more aggressive so it will fix >>>>>>>>>>> all the known false negatives introduced by bdd8b6c98239 >>>>>>>>>>> such as the one in i915_gem_object_pin_map(). >>>>>>>>>>> >>>>>>>>>>> I looked at Jan's approach and I think it would fix the issue >>>>>>>>>>> with my Haswell as long as I don't use the nopat option. I >>>>>>>>>>> really don't have a strong opinion on that question, but I >>>>>>>>>>> think the nopat option as a Linux kernel option, as opposed >>>>>>>>>>> to a hypervisor option, should only affect the kernel, and >>>>>>>>>>> if the hypervisor provides the pat feature, then the kernel >>>>>>>>>>> should not override that, >>>>>>>>>> Hmm, why would the kernel not be allowed to override that? Such >>>>>>>>>> an override would affect only the single domain where the >>>>>>>>>> kernel runs; other domains could take their own decisions. >>>>>>>>>> >>>>>>>>>> Also, for the sake of completeness: "nopat" used when running on >>>>>>>>>> bare metal has the same bad effect on system boot, so there >>>>>>>>>> pretty clearly is an error cleanup issue in the i915 driver. But >>>>>>>>>> that's orthogonal, and I expect the maintainers may not even care >>>>>>>>>> (but tell us "don't do that then"). >>>>>>>> Actually I just did a test with the last official Debian kernel >>>>>>>> build of Linux 5.16, that is, a kernel before bdd8b6c98239 was >>>>>>>> applied. In fact, the nopat option does *not* break the i915 driver >>>>>>>> in 5.16. That is, with the nopat option, the i915 driver loads >>>>>>>> normally on both the bare metal and on the Xen hypervisor. >>>>>>>> That means your presumption (and the presumption of >>>>>>>> the author of bdd8b6c98239) that the "nopat" option was >>>>>>>> being observed by the i915 driver is incorrect. Setting "nopat" >>>>>>>> had no effect on my system with Linux 5.16. So after doing these >>>>>>>> tests, I am against the aggressive approach of breaking the i915 >>>>>>>> driver with the "nopat" option because prior to bdd8b6c98239, >>>>>>>> nopat did not break the i915 driver. Why break it now? >>>>>>> Because that's, in my understanding, is the purpose of "nopat" >>>>>>> (not breaking the driver of course - that's a driver bug -, but >>>>>>> having an effect on the driver). >>>>>> I wouldn't call it a driver bug, but an incorrect configuration of the >>>>>> kernel by the user.  I presume X86_FEATURE_PAT is required by the >>>>>> i915 driver >>>>> The driver ought to work fine without PAT (and hence without being >>>>> able to make WC mappings). It would use UC instead and be slow, but >>>>> it ought to work. >>>>> >>>>>> and therefore the driver should refuse to disable >>>>>> it if the user requests to disable it and instead warn the user that >>>>>> the driver did not disable the feature, contrary to what the user >>>>>> requested with the nopat option. >>>>>> >>>>>> In any case, my test did not verify that when nopat is set in Linux >>>>>> 5.16, >>>>>> the thread takes the same code path as when nopat is not set, >>>>>> so I am not totally sure that the reason nopat does not break the >>>>>> i915 driver in 5.16 is that static_cpu_has(X86_FEATURE_PAT) >>>>>> returns true even when nopat is set. I could test it with a custom >>>>>> log message in 5.16 if that is necessary. >>>>>> >>>>>> Are you saying it was wrong for static_cpu_has(X86_FEATURE_PAT) >>>>>> to return true in 5.16 when the user requests nopat? >>>>> No, I'm not saying that. It was wrong for this construct to be used >>>>> in the driver, which was fixed for 5.17 (and which had caused the >>>>> regression I did observe, leading to the patch as a hopefully least >>>>> bad option). >>>>> >>>>>> I think that is >>>>>> just permitting a bad configuration to break the driver that a >>>>>> well-written operating system should not allow. The i915 driver >>>>>> was, in my opinion, correctly ignoring the nopat option in 5.16 >>>>>> because that option is not compatible with the hardware the >>>>>> i915 driver is trying to initialize and setup at boot time. At least >>>>>> that is my understanding now, but I will need to test it on 5.16 >>>>>> to be sure I understand it correctly. >>>>>> >>>>>> Also, AFAICT, your patch would break the driver when the nopat >>>>>> option is set and only fix the regression introduced by bdd8b6c98239 >>>>>> when nopat is not set on my box, so your patch would >>>>>> introduce a regression relative to Linux 5.16 and earlier for the >>>>>> case when nopat is set on my box. I think your point would >>>>>> be that it is not a regression if it is an incorrect user >>>>>> configuration. >>>>> Again no - my view is that there's a separate, pre-existing issue >>>>> in the driver which was uncovered by the change. This may be a >>>>> perceived regression, but is imo different from a real one. >>> Sorry, for you maybe, but I'm pretty sure for Linus it's not when it >>> comes to the "no regressions rule". Just took a quick look at quotes >>> from Linus >>> https://www.kernel.org/doc/html/latest/process/handling-regressions.html >>> and found this statement from Linus to back this up: >>> >>> ``` >>> One _particularly_ last-minute revert is the top-most commit (ignoring >>> the version change itself) done just before the release, and while >>> it's very annoying, it's perhaps also instructive. >>> >>> What's instructive about it is that I reverted a commit that wasn't >>> actually buggy. In fact, it was doing exactly what it set out to do, >>> and did it very well. In fact it did it _so_ well that the much >>> improved IO patterns it caused then ended up revealing a user-visible >>> regression due to a real bug in a completely unrelated area. >>> ``` >>> >>> He said that here: >>> https://www.kernel.org/doc/html/latest/process/handling-regressions.html >>> >>> The situation is of course different here, but similar enough. >>> >>>> Since it is a regression, I think for now bdd8b6c98239 should >>>> be reverted and the fix backported to Linux 5.17 stable until >>>> the underlying memory subsystem can provide the i915 driver >>>> with an updated test for the PAT feature that also meets the >>>> requirements of the author of bdd8b6c98239 without breaking >>>> the i915 driver. >>> I'm not a developer and I'm don't known the details of this thread and >>> the backstory of the regression, but it sounds like that's the approach >>> that is needed here until someone comes up with a fix for the regression >>> exposed by bdd8b6c98239. >>> >>> But if I'm wrong, please tell me. >> You are mostly right, I think. Reverting bdd8b6c98239 fixes >> it. There is another way to fix it, though. > Yeah, I'm aware of it. But it seems... > >> The patch proposed >> by Jan Beulich also fixes the regression on my system, so as >> the person reporting this is a regression, I would also be satisfied >> with Jan's patch instead of reverting bdd8b6c98239 as a fix. Jan >> posted his proposed patch here: >> >> https://lore.kernel.org/lkml/9385fa60-fa5d-f559-a137-6608408f88b0@suse.com/ > ...that approach is not making any progress either? Jan's approach does fix it on my system. There was some debate about what the kernel nopat option should do, though. I don't have a strong opinion on that and would accept Jan's patch as a fix. > > Jan, can could provide a short status update here? I'd really like to > get this regression fixed one way or another rather sooner than later, > as this is taken way to long already IMHO. I hope something is done soon also. > >> The only reservation I have about Jan's patch is that the commit >> message does not clearly explain how the patch changes what >> the nopat kernel boot option does. It doesn't affect me because >> I don't use nopat, but it should probably be mentioned in the >> commit message, as pointed out here: >> >> https://lore.kernel.org/lkml/bd9ed2c2-1337-27bb-c9da-dfc7b31d492c@netscape.net/ >> >> >> Whatever fix for the regression exposed by bdd8b6c98239 also >> needs to be backported to the stable versions 5.17 and 5.18. > Sure. > > BTW, as you seem to be familiar with the issue: there is another report > about a regression WRT to Xen and i915 (that is also not making really > progress): > https://lore.kernel.org/lkml/Yn%2FTgj1Ehs%2FBdpHp@itl-email/ > > It's just a wild guess, but bould this somehow be related? It could be, but I do not run a GUI in my Xen Dom0, so I have not seen that issue. Best regards, Chuck From xen-devel-bounces@lists.xenproject.org Wed May 25 20:16:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 20:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337366.561929 (Exim 4.92) (envelope-from ) id 1ntxQf-00041F-LC; Wed, 25 May 2022 20:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337366.561929; Wed, 25 May 2022 20:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntxQf-000418-IN; Wed, 25 May 2022 20:16:25 +0000 Received: by outflank-mailman (input) for mailman id 337366; Wed, 25 May 2022 20:16:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntxQe-00040y-Hd; Wed, 25 May 2022 20:16:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntxQe-0000IX-GS; Wed, 25 May 2022 20:16:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ntxQe-0007kf-5s; Wed, 25 May 2022 20:16:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1ntxQe-0001Da-5T; Wed, 25 May 2022 20:16:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hcNIdoNOX/UvS4gPAAlK7owjefwML92+gAr63F+2+3I=; b=djeNhM58BFANUsrADG4OTpErCq PKf7qETZcLVZoH4WvS+8j+RS7IZu5uTOo6kfmRtfzelZfe4F/jMHJAlgfJcs3Fz63wVGMhL1cF5J0 NM1AB6OG+Po7ycXNv4mAI3q4/se+zIXX4xeZJXP+WMKoqAHwSlOJMDHfXknI73kcKVqs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170733: all pass - PUSHED X-Osstest-Versions-This: ovmf=07c0c2eb0a5970db614ebce1060fc79d6904bdfd X-Osstest-Versions-That: ovmf=9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a From: osstest service owner Date: Wed, 25 May 2022 20:16:24 +0000 flight 170733 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170733/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 07c0c2eb0a5970db614ebce1060fc79d6904bdfd baseline version: ovmf 9c733f0b90b31a7e3711f60da314f2a5cfe5fe8a Last test of basis 170728 2022-05-25 12:40:37 Z 0 days Testing same since 170733 2022-05-25 17:10:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9c733f0b90..07c0c2eb0a 07c0c2eb0a5970db614ebce1060fc79d6904bdfd -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed May 25 23:07:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 25 May 2022 23:07:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337382.561946 (Exim 4.92) (envelope-from ) id 1nu05l-0002sU-3h; Wed, 25 May 2022 23:07:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337382.561946; Wed, 25 May 2022 23:07:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu05l-0002sN-0e; Wed, 25 May 2022 23:07:01 +0000 Received: by outflank-mailman (input) for mailman id 337382; Wed, 25 May 2022 23:06:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu05j-0002sD-Fl; Wed, 25 May 2022 23:06:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu05j-0003Aq-90; Wed, 25 May 2022 23:06:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu05i-0001xm-Ru; Wed, 25 May 2022 23:06:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nu05i-0004h7-RP; Wed, 25 May 2022 23:06:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5h3pE3QY+LHCIH8NkHfFFvg3CIJb07v6/yEP3SE9JWI=; b=6oEBh5seGVOoctRBNls+RMDN29 QkjEqEiJRdGbBA9tkZUUd7jzvd+2JMDlML2M/hPujnLP3wS8rEMoNAdDpw1vECH+ejjF540wM1jRr arlOJJikQBkS09S7KsOiiOy4At/UJVKR2fqk4eNNz8vVx7IFfClSZMmBki+sOeVM6bzM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170726: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-i386-examine:xen-install:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49399b101e38fb2c11478c849ffdaaace8e318a8 X-Osstest-Versions-That: xen=ec0cce125b8b9fccde3fa825b8ee963083b5de3b From: osstest service owner Date: Wed, 25 May 2022 23:06:58 +0000 flight 170726 xen-unstable real [real] flight 170738 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170726/ http://logs.test-lab.xenproject.org/osstest/logs/170738/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 170738-retest test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail pass in 170738-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170720 Tests which did not succeed, but are not blocking: test-amd64-i386-examine 6 xen-install fail like 170616 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170712 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170720 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170720 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170720 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170720 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170720 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170720 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170720 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170720 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170720 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170720 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170720 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49399b101e38fb2c11478c849ffdaaace8e318a8 baseline version: xen ec0cce125b8b9fccde3fa825b8ee963083b5de3b Last test of basis 170720 2022-05-25 01:53:12 Z 0 days Testing same since 170726 2022-05-25 09:40:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall Luca Miccio Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ec0cce125b..49399b101e 49399b101e38fb2c11478c849ffdaaace8e318a8 -> master From xen-devel-bounces@lists.xenproject.org Thu May 26 01:03:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 01:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337400.561985 (Exim 4.92) (envelope-from ) id 1nu1tp-0004yd-QO; Thu, 26 May 2022 01:02:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337400.561985; Thu, 26 May 2022 01:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu1tp-0004yD-K4; Thu, 26 May 2022 01:02:49 +0000 Received: by outflank-mailman (input) for mailman id 337400; Thu, 26 May 2022 01:02:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu1to-0004y7-Iu for xen-devel@lists.xenproject.org; Thu, 26 May 2022 01:02:48 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d12b603-dc8f-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 03:02:46 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ACA461719; Thu, 26 May 2022 01:02:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 410E0C385B8; Thu, 26 May 2022 01:02:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d12b603-dc8f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653526963; bh=oK/GYxneCttxB/Z22skpAPjw2uxLN3rffqB0E+kgtA0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XnPu2X2AG8YOpW9RntHniiLv9ptrNL2i/IFsOObKJY/LvogjKFlR1V3aUvWt36P2R TReYOtUeKFyoyvo8COm1eIkNfSYma+SytHmrJ2ETSeFrvV8zXF2pbQFb9ff0HMwS4y eFw5njA9Ijk1cBNCLmQRunqk5nqcUJFHCaNcAWm8tektCrmfD7fpHHc6cm9n9cX9tC 4LDqoyBy+tfBY1TePXLA6m5yhcVRpRbmjQB3DkfRBv0N6+yjRz7KSaj0b5bI+vnjcj cHpZcsIvlOIA8YBvpAvSjWiFpc9IJBax66FM3HY7wOkYaWNpwHYSyJYg01MHF8wZHB JFE1KIVwcLSkA== Date: Wed, 25 May 2022 18:02:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, jbeulich@suse.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 May 2022, Julien Grall wrote: > Hi Stefano, > > On 25/05/2022 01:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Introduce a list of MISRA C rules that apply to the Xen hypervisor. The > > list is in RST format. > > > > Add a mention of the new list to CODING_STYLE. > > > > Signed-off-by: Bertrand Marquis > > Signed-off-by: Stefano Stabellini > > NIT: I was under the impression that the first Signed-off-by is usually > author. But the From doesn't match. > > > --- > > CODING_STYLE | 6 ++++ > > docs/misra/rules.rst | 65 ++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 71 insertions(+) > > create mode 100644 docs/misra/rules.rst > > > > diff --git a/CODING_STYLE b/CODING_STYLE > > index 9f50d9cec4..1ef35ee8d0 100644 > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -235,3 +235,9 @@ callstack between the initial function call and the > > failure, no error > > is returned. Using domain_crash() requires careful inspection and > > documentation of the code to make sure all callers at the stack handle > > a newly-dead domain gracefully. > > + > > +MISRA C > > +------- > > + > > +The Xen Project hypervisor follows the MISRA C coding rules and > > +directives listed under docs/misra/rules.rst. > > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > > new file mode 100644 > > index 0000000000..c0ee58ab25 > > --- /dev/null > > +++ b/docs/misra/rules.rst > > @@ -0,0 +1,65 @@ > > +===================== > > +MISRA C rules for Xen > > +===================== > > + > > +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > > +MISRA Consortium Limited and used with permission. > > + > > +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or > > for > > +licensing options for other use of the rules. > > + > > +The following is the list of MISRA C rules that apply to the Xen Project > > +hypervisor. > I was under the impression that we would still allow deviations on those rules > in some cases. In particular... > > +- Rule: Dir 2.1 > > + - Severity: Required > > + - Summary: All source files shall compile without any compilation errors > > + - Link: > > https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > > +- Rule: Dir 4.7 > > + - Severity: Required > > + - Summary: If a function returns error information then that error > > information shall be tested > > + - Link: > > https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > > > ... this one. We are using (void) + a comment when the return is ignored on > purpose. This is technically not-compliant with MISRA but the best we can do > in some situation. > > With your proposed wording, we would technically have to remove them (or not > introduce new one). So I think we need to document that we are allowing > deviations so long they are commented. Absolutely yes. All of these rules can have deviations as long as they make sense and they are commented. Note that we still have to work out a good tagging system so that ECLAIR and cppcheck can recognize the deviations automatically but for now saying that they need to be commented is sufficient I think. So I'll add the following on top of the file: """ It is possible that in specific circumstances it is best not to follow a rule because it is not possible or because the alternative leads to better code quality. Those cases are called "deviations". They are permissible as long as they are documented with an in-code comment. """ From xen-devel-bounces@lists.xenproject.org Thu May 26 01:12:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 01:12:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337408.561996 (Exim 4.92) (envelope-from ) id 1nu23J-0006QU-Mq; Thu, 26 May 2022 01:12:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337408.561996; Thu, 26 May 2022 01:12:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu23J-0006QN-JE; Thu, 26 May 2022 01:12:37 +0000 Received: by outflank-mailman (input) for mailman id 337408; Thu, 26 May 2022 01:12:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu23I-0006QG-6V for xen-devel@lists.xenproject.org; Thu, 26 May 2022 01:12:36 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec40b790-dc90-11ec-837f-e5687231ffcc; Thu, 26 May 2022 03:12:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97807B81EB7; Thu, 26 May 2022 01:12:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6CD7C385B8; Thu, 26 May 2022 01:12:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec40b790-dc90-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653527552; bh=EuAA4/ALIXULFw4CT6MK/y3YySWi72e1tUl+4aO/eDs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XqSNXJr/J5NQUIekR622nKqTyIv1ziY1wogio9Y1/hE+WqDnXftOCpfxMzDAwNY2c 5pUBHX6SqSBX7kL+QdBLHerDgwLKU119qk1zcHhXr2ywgJ6JB9qfPGNbwJ9nPr9GI8 GU/Pvo3Tk0FnEOKseAtrf/FIaQWAC0kWQxA67+CXJHjNpex14Y8CVKzssz4hsxam8j fUVHPscnyDp9IA6XdzOA59f21JDdBefFgNpsiJk2+VqA0n3KBKvndcv20jIKe03EGg CNVplDHf9kzl0HZkWWl5syiF8Nno9eus+JXtl4I8lzU0pmnwIHdANggdtqGdOAojtk BcgeWy6K8uqKQ== Date: Wed, 25 May 2022 18:12:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: <62f142e3-02c7-22e0-3917-3a29fa2630b1@suse.com> Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <62f142e3-02c7-22e0-3917-3a29fa2630b1@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 May 2022, Jan Beulich wrote: > On 25.05.2022 02:35, Stefano Stabellini wrote: > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -235,3 +235,9 @@ callstack between the initial function call and the failure, no error > > is returned. Using domain_crash() requires careful inspection and > > documentation of the code to make sure all callers at the stack handle > > a newly-dead domain gracefully. > > + > > +MISRA C > > +------- > > + > > +The Xen Project hypervisor follows the MISRA C coding rules and > > +directives listed under docs/misra/rules.rst. > > Putting this at the very bottom isn't helpful, I'm afraid. I'd rather > see this go directly after the initial paragraphs, before "Indentation". I can do that > > --- /dev/null > > +++ b/docs/misra/rules.rst > > @@ -0,0 +1,65 @@ > > +===================== > > +MISRA C rules for Xen > > +===================== > > + > > +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > > +MISRA Consortium Limited and used with permission. > > + > > +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for > > +licensing options for other use of the rules. > > + > > +The following is the list of MISRA C rules that apply to the Xen Project > > +hypervisor. > > + > > +- Rule: Dir 2.1 > > + - Severity: Required > > + - Summary: All source files shall compile without any compilation errors > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > > +- Rule: Dir 4.7 > > + - Severity: Required > > + - Summary: If a function returns error information then that error information shall be tested > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > > +- Rule: Dir 4.10 > > + - Severity: Required > > + - Summary: Precautions shall be taken in order to prevent the contents of a header file being included more than once > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_10.c > > Like Julien has already pointed out for 4.7, this and perhaps other ones > also want clarifying somewhere that we expect certain exceptions. Without > saying so explicitly, someone could come forward with a patch eliminating > some uses (and perhaps crippling the code) just to satisfy such a rule. > This would then be a waste of both their and our time. Yes, and also Julien pointed out something similar. I'll add a statement at the top of the file to say that there can be deviations as long as they are commented. I wouldn't go as far as adding a note to each specific rule where we expect deviations because I actually imagine that many of them will end up having at least one deviation or two. It would be easier to mark the ones where we expect to have 100% compliance and intend to keep it that way (once we reach 100% compliance). We are still in the early days of this process. For now, what about adding the following statement at the top of the file (in addition to the one saying that deviations are permissible): """ The existing codebase is not 100% compliant with the rules. Some of the violations are meant to be documented as deviations, while some others should be fixed. Both compliance and documenting deviations on the existing codebase is work-in-progress. """ > > +- Rule: Dir 4.14 > > + - Severity: Required > > + - Summary: The validity of values received from external sources shall be checked > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_14.c > > +- Rule: Rule 1.3 > > + - Severity: Required > > + - Summary: There shall be no occurrence of undefined or critical unspecified behaviour > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_01_03.c > > +- Rule: Rule 3.2 > > + - Severity: Required > > + - Summary: Line-splicing shall not be used in // comments > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c > > To aid easily looking up presence of a rule here, I think the table wants > sorting numerically. They are sorted numerically, first the "Dir" (directives) then the "Rules". > > +- Rule: Rule 6.2 > > + - Severity: Required > > + - Summary: Single-bit named bit fields shall not be of a signed type > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_02.c > > +- Rule: Rule 8.1 > > + - Severity: Required > > + - Summary: Types shall be explicitly specified > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_01.c > > +- Rule: Rule 8.4 > > + - Severity: Required > > + - Summary: A compatible declaration shall be visible when an object or function with external linkage is defined > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_04.c > > +- Rule: Rule 8.5 > > + - Severity: Required > > + - Summary: An external object or function shall be declared once in one and only one file > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_05_2.c > > +- Rule: Rule 8.6 > > + - Severity: Required > > + - Summary: An identifier with external linkage shall have exactly one external definition > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_06_2.c > > I don't think this was uncontroversial, as we've got a lot of uses of > declarations when we expect DCE to actually take out all uses. There > are also almost a thousand violations, which - imo - by itself speaks > against adoption. Ah yes, good catch. We spoke about DCE in the context of Rule 2.1, not this one. My preference would be to keep Rule 8.6 with a note allowing DCE: - Note: declarations without definitions are allowed (specifically when the definition is compiled-out or optimized-out by the compiler) But if this is controversial, I can move it to be discussed later together with Rule 2.1. From xen-devel-bounces@lists.xenproject.org Thu May 26 01:18:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 01:18:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337416.562007 (Exim 4.92) (envelope-from ) id 1nu28d-00074E-A8; Thu, 26 May 2022 01:18:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337416.562007; Thu, 26 May 2022 01:18:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu28d-000747-6M; Thu, 26 May 2022 01:18:07 +0000 Received: by outflank-mailman (input) for mailman id 337416; Thu, 26 May 2022 01:18:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu28c-000741-37 for xen-devel@lists.xenproject.org; Thu, 26 May 2022 01:18:06 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0326c86-dc91-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 03:18:04 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F34B16178B; Thu, 26 May 2022 01:18:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5099C385B8; Thu, 26 May 2022 01:18:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0326c86-dc91-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653527881; bh=f1ROh0jhdngz8xUjuNAgmHCnrQqW6Evn0tfcS/9eO5g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oaPwo+k4ixEd4tAiXUXTQv9kRD37r8hywS4gnu1EJ/eR1pi2+9XCVJgITx24pBuQK R6PnsdquOtL7Iv13ZasyA/g+X/24HjKBSgN1w4xJqpZ8WxnnBsuy7+RKX2JvJUVK0f tyrbtZo/EqYzRX8oDb4nrl6khvaOlmTdjCACm0/B5SH25B631Zc6JhiVwJYDj1F+ow Fwt+Xh/ezcfLWGBXRuvMDodVYiJeMW1aQIlqxKWDgqvecvYNRv53axnevfPR0J9i6O gMcukPgqdMTe1sgLOU8O7BZDS2iHYZJdHpkjFjpzX1h8RuZw/k3CwZIbyLqMRPhqyJ WkNKSxDWoukag== Date: Wed, 25 May 2022 18:18:00 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 In-Reply-To: <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> Message-ID: References: <20220525003505.304617-2-sstabellini@kernel.org> <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 May 2022, Jan Beulich wrote: > On 25.05.2022 02:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Add Rule 5.1, with the additional note that the character limit for Xen > > is 63 characters. > > > > The max length identifiers found by ECLAIR are: > > > > __mitigate_spectre_bhb_clear_insn_start > > domain_pause_by_systemcontroller_nosync > > > > Both of them are 40 characters long. A limit of 63 characters work for > > the existing code. > > I have to admit that it hasn't become clear to me why we want to > permit (if not to say encourage) the use of such long identifiers. > If 40 is the longest we've got, why not limit it to 40 for now > with a goal of further reducing? A 40-char symbol plus some > indentation will already pose problems with 80-char line length. We can go lower than 63 if we want to. I chose the closest power-of-two length -1 for the NUL terminator. But it doesn't have to be a power-of-two. So we could go with "41" if we want to. Anyone in favor of that? I am happy with any number between 41 and 63. > Otoh, as said on the call, I think the public headers want > mentioning explicitly here in some way. Part of them (most or all > of what's under io/) aren't used when building Xen, so won't be > seen by Eclair (aiui). Yet they are a formal part of the code > base, and e.g. ring.h has some pretty long names (albeit still > below 40 chars as it looks). So once we're able to go down to e.g. > 32 for the bulk of the code base, public headers should imo still > be explicitly allowed to use longer identifiers. Actually I thought about writing something for the public header but I wasn't sure what to write. What about: - Note: the Xen characters limit for identifiers is 41. Public headers (xen/include/public/) are allowed to retain longer identifiers for backward compatibility. From xen-devel-bounces@lists.xenproject.org Thu May 26 01:57:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 01:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337424.562017 (Exim 4.92) (envelope-from ) id 1nu2l1-0002kA-Ck; Thu, 26 May 2022 01:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337424.562017; Thu, 26 May 2022 01:57:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2l1-0002k3-A1; Thu, 26 May 2022 01:57:47 +0000 Received: by outflank-mailman (input) for mailman id 337424; Thu, 26 May 2022 01:57:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2kz-0002jx-UG for xen-devel@lists.xenproject.org; Thu, 26 May 2022 01:57:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3afef0c3-dc97-11ec-837f-e5687231ffcc; Thu, 26 May 2022 03:57:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 581A161830; Thu, 26 May 2022 01:57:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DC77C34113; Thu, 26 May 2022 01:57:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3afef0c3-dc97-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653530261; bh=noBuLfnEfqstfqk1d/Cax29+AR4MGTO/yzggDEsvn7Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JiciWRWHflBIBbfVY7iqKRsP3LNAwqXupCitTvkfPurnzq1wnujB7GMUwTs0xoDJn 6X7J0/yja/ChfdaLlNKh8gyeOruBnZCNOFRU4aWZLfCfDj4YJncl8iRmwvEUub0q3U yq4W/dhI+2GJeHDHQ3yAEjMwGfBkM6RfSvmTIi9eu/cc5HAgVCJVWTHBupKaRymXHD QxGGgOR7bOTLP8NB7mwjZ2BdvsGPzFzNJukNburrogXtHuauqFS0NWwbYEb09MqTwM 0yLLecC/suwmjtMcpOsNZvN/TvEhXSqzR94mcl+cPnLaeHpyV+v87QlsRczFH55/41 PFSbPmAy5Xu6Q== Date: Wed, 25 May 2022 18:57:40 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "jbeulich@suse.com" , Roger Pau Monne , "julien@xen.org" , "Bertrand.Marquis@arm.com" , George Dunlap , Stefano Stabellini Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-914675212-1653528626=:1905099" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-914675212-1653528626=:1905099 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 25 May 2022, Andrew Cooper wrote: > On 25/05/2022 01:35, Stefano Stabellini wrote: > > From: Stefano Stabellini > > > > Introduce a list of MISRA C rules that apply to the Xen hypervisor. The > > list is in RST format. > > > > Add a mention of the new list to CODING_STYLE. > > > > Signed-off-by: Bertrand Marquis > > Signed-off-by: Stefano Stabellini > > Some comments on syntax/layout, unrelated to the specific content. > > You can check the rendered content with either `make -C docs > sphinx-html` locally, or by pointing readthedocs at your repo.  (e.g. > https://andrewcoop-xen.readthedocs.io/en/docs-devel/ is a very out of > date WIP branch of some in-development content.) Thanks I did that and I can see that the layout needs a lot of improvements. > Whatever gets committed will be rendered at > https://xenbits.xen.org/docs/latest/ once the cronjob catches up. > > > --- > > CODING_STYLE | 6 ++++ > > docs/misra/rules.rst | 65 ++++++++++++++++++++++++++++++++++++++++++++ > > At minimum there needs to be an addition to a toctree directive in on of > the existing index.rst's > > But  this looks like it ought to be part of the hypervisor guide ? I would keep the actual MISRA files in their own top-level directory under docs/ but we can certainly link to them from docs/index.rst or from hypervisor guide. What about the following added to docs/index.rst: MISRA C coding guidelines ------------------------- MISRA C rules and directive to be used as coding guidelines when writing Xen hypervisor code. .. toctree:: :maxdepth: 2 misra/rules > > 2 files changed, 71 insertions(+) > > create mode 100644 docs/misra/rules.rst > > > > diff --git a/CODING_STYLE b/CODING_STYLE > > index 9f50d9cec4..1ef35ee8d0 100644 > > --- a/CODING_STYLE > > +++ b/CODING_STYLE > > @@ -235,3 +235,9 @@ callstack between the initial function call and the failure, no error > > is returned. Using domain_crash() requires careful inspection and > > documentation of the code to make sure all callers at the stack handle > > a newly-dead domain gracefully. > > + > > +MISRA C > > +------- > > + > > +The Xen Project hypervisor follows the MISRA C coding rules and > > +directives listed under docs/misra/rules.rst. > > I think this would be clearer to follow as: > > "The Xen Hypervisor follows some MISRA C coding rules.  See ... for > details." > > because otherwise there is an implication that we follow all rules.  > Also, "Xen Project" might be the name of our legal entity name, but the > hypervisor's name is Xen, not "Xen Project". Yep, I can do that > > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > > new file mode 100644 > > index 0000000000..c0ee58ab25 > > --- /dev/null > > +++ b/docs/misra/rules.rst > > @@ -0,0 +1,65 @@ > > All Sphinx content needs to be > > .. SPDX-License-Identifier: CC-BY-4.0 > > so it specifically can be vendored/tailored by downstream entities. > > > +===================== > > +MISRA C rules for Xen > > +===================== > > And the prevailing style is without the === overline. > > > + > > +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > > +MISRA Consortium Limited and used with permission. > > + > > +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for > > +licensing options for other use of the rules. > > .. note:: > > and then with the two paragraphs indented to be a part of the note block. > > > + > > +The following is the list of MISRA C rules that apply to the Xen Project > > +hypervisor. > > + > > +- Rule: Dir 2.1 > > + - Severity: Required > > + - Summary: All source files shall compile without any compilation errors > > + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > > This wants to be .. list-table::  See > docs/guest-guide/x86/hypercall-abi.rst for an example. Ah yes, thank you > Also, the URL wants to use the ext-links plugin.  See > https://lore.kernel.org/xen-devel/20191003205623.20839-4-andrew.cooper3@citrix.com/ It looks like that patch didn't make it upstream? But I can just use the following format and it works with make -C docs sphinx-html: * - `Dir 2.1 `_ - Required - All source files shall compile without any compilation errors - the format is `description `_ --8323329-914675212-1653528626=:1905099-- From xen-devel-bounces@lists.xenproject.org Thu May 26 02:00:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 02:00:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337432.562029 (Exim 4.92) (envelope-from ) id 1nu2nc-0004UK-Ri; Thu, 26 May 2022 02:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337432.562029; Thu, 26 May 2022 02:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2nc-0004UD-Nb; Thu, 26 May 2022 02:00:28 +0000 Received: by outflank-mailman (input) for mailman id 337432; Thu, 26 May 2022 02:00:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2na-0004U1-Vq; Thu, 26 May 2022 02:00:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2na-00053t-TC; Thu, 26 May 2022 02:00:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu2na-0000mo-Bw; Thu, 26 May 2022 02:00:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nu2na-0000U7-BG; Thu, 26 May 2022 02:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qxtZWga+8PAkJh2ovyDa6I/GVJf02f4yvFngRxD1k5s=; b=uXMKkjEoR4Obs7zR8zDCpPyvIf QRb+roS7Ye64P1gV1q1uGSuiBlk3UbosMnjbrGQUu6XpZijkFTWoiwDnZjYaVgoSssGzqXz+63KKf Riqb+apHRqhxYuyddtf1ONTAOozhcFE9qnl6XNMaENBo7S5W16d/IRtbEYX9wukgA02c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170732: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ffae6d9585dc9353c2776944b862bda126dd87ea X-Osstest-Versions-That: qemuu=0cac736e73723850a99e5142e35d14d8f8efb232 From: osstest service owner Date: Thu, 26 May 2022 02:00:26 +0000 flight 170732 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170732/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170721 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170721 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170721 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170721 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170721 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170721 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170721 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170721 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu ffae6d9585dc9353c2776944b862bda126dd87ea baseline version: qemuu 0cac736e73723850a99e5142e35d14d8f8efb232 Last test of basis 170721 2022-05-25 03:38:27 Z 0 days Testing same since 170732 2022-05-25 17:06:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Kostiuk luzhipeng Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0cac736e73..ffae6d9585 ffae6d9585dc9353c2776944b862bda126dd87ea -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 26 04:20:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 04:20:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337449.562052 (Exim 4.92) (envelope-from ) id 1nu4zO-0001MW-DQ; Thu, 26 May 2022 04:20:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337449.562052; Thu, 26 May 2022 04:20:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu4zO-0001MP-AH; Thu, 26 May 2022 04:20:46 +0000 Received: by outflank-mailman (input) for mailman id 337449; Thu, 26 May 2022 04:20:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu4zN-0001MF-Q3; Thu, 26 May 2022 04:20:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu4zN-0007vf-Lu; Thu, 26 May 2022 04:20:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu4zN-0002qh-4e; Thu, 26 May 2022 04:20:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nu4zN-0006k1-4D; Thu, 26 May 2022 04:20:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1Rdqa/j+sDT1ZeKAo481rvOy5Y8w7sm4MvWncDNcoBc=; b=mlHCGM5b5N/OO0XHEoUk5PzKng 2GYjZvFcuTr6HzUkTZl/mTOIV6T+SUVFde+sZq1E5M2uOl7Wr4Egd8Md/2ttGbOyJMHglFzju5/Wo 9QguRvqUe6UFc9/dHOV++LOZafjI9x/6JsgqEOFj0aMZP88ib0IimfGEYlXCalaqwZss=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 170736: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=04b092e4a01a3488e762897e2d29f85eda2c6a60 X-Osstest-Versions-That: linux=0187300e6aa6246e9cebb22e2afbbc0d395839ee From: osstest service owner Date: Thu, 26 May 2022 04:20:45 +0000 flight 170736 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/170736/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 170724 pass in 170736 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail pass in 170724 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 170724 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170532 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 170724 like 170532 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 170724 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170532 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170532 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170532 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170532 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170532 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170532 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170532 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170532 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170532 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 04b092e4a01a3488e762897e2d29f85eda2c6a60 baseline version: linux 0187300e6aa6246e9cebb22e2afbbc0d395839ee Last test of basis 170532 2022-05-18 08:13:22 Z 7 days Testing same since 170724 2022-05-25 07:43:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Abel Vesa Al Viro Alexandre Belloni Andrew Lunn Andrew Morton Anna Schumaker Anton Eidelman Anton Eidelman Ard Biesheuvel Arnaldo Carvalho de Melo Bartosz Golaszewski Benson Leung Bjorn Helgaas Christian König Christoph Hellwig Christophe JAILLET Codrin Ciubotariu David Gow David Howells David S. Miller Denis Efremov Dmitry Torokhov Duoming Zhou Felix Fietkau Florian Fainelli Gleb Chesnokov Grant Grundler Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Gwendal Grignou Haibo Chen Hangyu Hua Harini Katakam Herbert Xu Hulk Robot Ido Schimmel Jae Hyun Yoo Jakob Koschel Jakub Kicinski Jason Wang Jeff LaBundy Jens Axboe Jiasheng Jiang Joel Stanley Johannes Berg Juergen Gross Jérôme Pouiller kafs-testing+fedora34_64checkkafs-build-496@auristor.com Kai-Heng Feng Kevin Mitchell Khalid Masum Lin Yujun Linus Torvalds Linux Kernel Functional Testing linyujun Luis Chamberlain Lyude Paul Marek Vasut Mario Limonciello Markus Boehme Markus Suvanto Martin K. Petersen Maxim Mikityanskiy Meena Shanmugam Michael S. Tsirkin Michal Simek Ming Lei Miroslav Benes Mohammad Athari Bin Ismail Nicolas Dichtel Nikolay Aleksandrov Oleksandr Natalenko Ondrej Mosnacek Ovidiu Panait Paolo Abeni Paolo Bonzini Paul Greenwalt Peter Zijlstra (Intel) Peter Zijlstra Philippe Schenker Radhey Shyam Pandey Rafael J. Wysocki Raul E Rangel Richard Weinberger Russell King (Oracle) Ryusuke Konishi Saeed Mahameed Sasha Levin Sean Christopherson Shawn Guo Shuah Khan Steffen Klassert Stephen Boyd Sudip Mukherjee Takashi Iwai Tan Tee Min Thiébaud Weksteen Thomas Bogendoerfer Thomas Richter Tony Nguyen Trond Myklebust Tzung-Bi Shih Ulf Hansson Uwe Kleine-König Vincent Whitchurch Willy Tarreau Wolfram Sang Wong Vee Khee Xiaoke Wang Yang Yingliang Zheng Yongjun Zixuan Fu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0187300e6aa6..04b092e4a01a 04b092e4a01a3488e762897e2d29f85eda2c6a60 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu May 26 06:10:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 06:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337462.562063 (Exim 4.92) (envelope-from ) id 1nu6h2-0002uV-9z; Thu, 26 May 2022 06:09:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337462.562063; Thu, 26 May 2022 06:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu6h2-0002uO-78; Thu, 26 May 2022 06:09:56 +0000 Received: by outflank-mailman (input) for mailman id 337462; Thu, 26 May 2022 06:09:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu6h0-0002u9-Ky; Thu, 26 May 2022 06:09:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu6h0-0001er-IK; Thu, 26 May 2022 06:09:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu6h0-0007hh-6C; Thu, 26 May 2022 06:09:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nu6h0-0008Qx-5i; Thu, 26 May 2022 06:09:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uzxjuUOHlkz+5D44oKupj8ona8RrKpIS/22o3cGN4Ok=; b=BaKIrl1WlOrxitc+ZhWsGc5s7A 0oCW2AkXc/gRkveBaFhdquc0k8QRQUDfbqFdBhHlER07OB8kOCFsd1QrkcsjOzx4fKx33EHS1ZDgl 0InAzHNIYitC2WCW4YgAKXYczuLb52RllyOCpmUXr1Yx4seneGnt7aad/9XALxkLl8UI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170737: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=7e062cda7d90543ac8c7700fc7c5527d0c0f22ad X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Thu, 26 May 2022 06:09:54 +0000 flight 170737 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 7e062cda7d90543ac8c7700fc7c5527d0c0f22ad baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 2 days Failing since 170716 2022-05-24 11:12:06 Z 1 days 5 attempts Testing same since 170737 2022-05-25 19:42:37 Z 0 days 1 attempts ------------------------------------------------------------ 999 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 87101 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 26 08:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 08:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337480.562076 (Exim 4.92) (envelope-from ) id 1nu8bv-000794-U9; Thu, 26 May 2022 08:12:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337480.562076; Thu, 26 May 2022 08:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu8bv-00078x-RF; Thu, 26 May 2022 08:12:47 +0000 Received: by outflank-mailman (input) for mailman id 337480; Thu, 26 May 2022 08:12:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu8bu-00078r-Dr for xen-devel@lists.xenproject.org; Thu, 26 May 2022 08:12:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9de4a670-dccb-11ec-837f-e5687231ffcc; Thu, 26 May 2022 10:12:45 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45DF21474; Thu, 26 May 2022 01:12:42 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A89793F70D; Thu, 26 May 2022 01:12:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9de4a670-dccb-11ec-837f-e5687231ffcc From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, andrew.cooper3@citrix.com, Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH] tools/libxl: optimize domain creation skipping domain cpupool move Date: Thu, 26 May 2022 09:12:30 +0100 Message-Id: <20220526081230.3194-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 Commit 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") introduced a way to start a domain directly on a certain cpupool, adding a "cpupool_id" member to struct xen_domctl_createdomain. This was done to be able to start dom0less guests in different pools than cpupool0, but the toolstack can benefit from it because it can now use the struct member directly instead of creating the guest in cpupool0 and then moving it to the target cpupool. Suggested-by: Andrew Cooper Signed-off-by: Luca Fancellu --- tools/libs/light/libxl_create.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 69ec405858a8..2339f09e95a6 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -633,6 +633,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, .max_maptrack_frames = b_info->max_maptrack_frames, .grant_opts = XEN_DOMCTL_GRANT_version(b_info->max_grant_version), .vmtrace_size = ROUNDUP(b_info->vmtrace_buf_kb << 10, XC_PAGE_SHIFT), + .cpupool_id = info->poolid, }; if (info->type != LIBXL_DOMAIN_TYPE_PV) { @@ -757,13 +758,6 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, */ assert(libxl_domid_valid_guest(*domid)); - ret = xc_cpupool_movedomain(ctx->xch, info->poolid, *domid); - if (ret < 0) { - LOGED(ERROR, *domid, "domain move fail"); - rc = ERROR_FAIL; - goto out; - } - dom_path = libxl__xs_get_dompath(gc, *domid); if (!dom_path) { rc = ERROR_FAIL; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Thu May 26 09:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 09:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337489.562088 (Exim 4.92) (envelope-from ) id 1nu9dg-0004hy-Tp; Thu, 26 May 2022 09:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337489.562088; Thu, 26 May 2022 09:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9dg-0004hr-QT; Thu, 26 May 2022 09:18:40 +0000 Received: by outflank-mailman (input) for mailman id 337489; Thu, 26 May 2022 09:18:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9df-0004hl-0l for xen-devel@lists.xenproject.org; Thu, 26 May 2022 09:18:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d1bbdbed-dcd4-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 11:18:37 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A4E21474; Thu, 26 May 2022 02:18:34 -0700 (PDT) Received: from [10.57.7.92] (unknown [10.57.7.92]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7E1F63F73D; Thu, 26 May 2022 02:18:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1bbdbed-dcd4-11ec-bd2c-47488cf2e6aa Message-ID: <455173fb-139a-879f-a0b5-f2404f94a710@arm.com> Date: Thu, 26 May 2022 11:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Content-Language: en-US From: Michal Orzel To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> <3236e8e6-c25d-1733-9315-e0363cc73f84@xen.org> <06dbe73a-a14f-4b9f-4839-9c97829303ff@arm.com> In-Reply-To: <06dbe73a-a14f-4b9f-4839-9c97829303ff@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Julien, Gentle ping asking to reply to my previous mail. On 24.05.2022 08:34, Michal Orzel wrote: > Hi Julien, > > On 23.05.2022 22:00, Julien Grall wrote: >> >> >> On 23/05/2022 11:21, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> >>> On 23.05.2022 12:05, Julien Grall wrote: >>>> Hi, >>>> >>>> On 23/05/2022 10:13, Michal Orzel wrote: >>>>> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >>>>> the number of CPUs to activate. >>>> >>>> The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. >>>> >>>> Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. >>>> >>>> >>>> So what's your use-case/target? >>>> >>> - use cases where we have no big little (although even on big.LITTLE limiting this number makes sense if we do not care about the types) >> >> This may make sense in debug build, but for prod I think you need some certainty how which CPUs you are going to use. > My conviction was that using big.LITTLE by enabling hmp-unsafe is not really used in the production systems (after all it's called *unsafe*) > as it may easily end up in an insecure/unstable platform without specifying the cpu affinity (which must be done carefully). > >> >> So I would like a warning in the documentation "maxcpus" that in big.LITTLE system, there are no guarantee on which types will be used. > I'm fully ok with adding this warning. > > **WARNING: On Arm big.LITTLE systems, when `hmp-unsafe` option is enabled, this command line > option does not guarantee on which CPU types will be used.** > >> >> This is technically a lie, but I don't want a user to start relying on how Xen will parse the DT. >> >>> - debug cases where we want to set maxcpus=1 >> >> Thanks for the clarification. I would be happy to add my tag with a warning in the documentation. >> > Does it mean you want to do this on commit or should I handle it in v2? > >> Cheers, >> > > Cheers, > Michal > From xen-devel-bounces@lists.xenproject.org Thu May 26 09:36:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 09:36:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337498.562099 (Exim 4.92) (envelope-from ) id 1nu9vB-00070t-DE; Thu, 26 May 2022 09:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337498.562099; Thu, 26 May 2022 09:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9vB-00070m-AT; Thu, 26 May 2022 09:36:45 +0000 Received: by outflank-mailman (input) for mailman id 337498; Thu, 26 May 2022 09:36:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9v9-00070g-66 for xen-devel@lists.xenproject.org; Thu, 26 May 2022 09:36:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58f35319-dcd7-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 11:36:41 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2172.outbound.protection.outlook.com [104.47.51.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-W8lZ0ma_MtWVww-Enc-wUQ-1; Thu, 26 May 2022 11:36:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7703.eurprd04.prod.outlook.com (2603:10a6:20b:23c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:36:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 09:36:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58f35319-dcd7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653557800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WTWnOnCCxRJdUmzhd0yegnSe2HliVI7Uh5L4Y6nV/Qo=; b=QQPnWrKns83SohrbeMLYP//rgOOf8MgUOs30hByss5085+cAqc0SXQf9tF2oxpLM3KAdkf Nk4TiuVm7nOlY20lDTV6Ki/ynTGSvkVwvsVZCr8AVl74nxTmF/GZ9Dtrnumguhbp+67gNV a07uuXXN7y9yLje5BYvg3CAL7roB/oE= X-MC-Unique: W8lZ0ma_MtWVww-Enc-wUQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tj84rQGGDzJi3/jkzmzlh4E0IBy1Yk0yfGIvGVkwFAgelxsadZ5hhZyGuG3AQEdL6CmtNbsdwfaP6QtU7dEazEjPq9xdvNUdQ8iSROhw3faz7S9hc7yZGwRMzANsAUJRW/DNmgmFVoLf0z6UiWlVbGFAREGfksv2sBQBRudHL1FVzqw062ZZe0FStQxVo0a9EUBoPD4WxTgk9b/UCV7ZYDETxGLE6FcKpEol+yiYSqcn+O27XhNU+sy0R842LQwknxZ1DGadUaW6RqihXWLPICrqnmMIBH25tr5yYGBTpI4+vl+m+VDEbTBfqBDTp6kug4eeDHMqjOmn2wpaGATyeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WTWnOnCCxRJdUmzhd0yegnSe2HliVI7Uh5L4Y6nV/Qo=; b=J7X/VFwcCvuVctGuJWjfBOACukDnxLbB7uM/mwkcMbaLhvoXDdfL5YdujKzrhbtJbRcLsLDEKrJbwIloApB1FmXNt9xLub/v99YMdEnv1g1IPHO/RqU9OBQJJZI722YIql1qH/fKR4/EgnRNwVoFbv7FgpjXaXqFG7fX9PwSSkilmBkhoLJbDAZtoh39gniP5Wdehhd5RG6ioLdc6xqXYTOBZpjd5XApw/6f9GayvpsJuVRRJSO9vSBLKn2/2mEsyC0Nc4x/dkF5ZP2e2v4O+3g1RH/l6c35S6ztOOzmNI3w/8hmA/bGms042txEXQfle4+y4Zw8CPf426xKYpLN2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0d71af01-dbfa-d5ab-c55c-faa3693674bc@suse.com> Date: Thu, 26 May 2022 11:36:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220525003505.304617-1-sstabellini@kernel.org> <62f142e3-02c7-22e0-3917-3a29fa2630b1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0052.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0490881-6108-4a0a-d932-08da3efb3ab3 X-MS-TrafficTypeDiagnostic: AS8PR04MB7703:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KOGU7PaSxD3d6b2skAS1P/WMic7hfQpMALEXyYLIrINiabhA2oQx+NPmCtjCn15zsHgValIkxuzp4kVpg+NiuEM0JNo+O245zsagmL642BOt1yRVUZ4PiKyD6Wlbhv+RjD5406Hfb8alDX+Z8KDTSZGsUD8jzwr6Qu6JJCJsqG+mhn+/XYC5ENhe612im67Ql52OjWCL2AcdV3Mzxy/mfMluzv55zw562AyFElhpnU2parH0Jx8nnZ41aDhwwgd7MYAJKyWF3bGCFj1qV+Zw/fFv8JkaDeUpWtMjazEOji+rhf+nYgQO6K248QbC805zaBB1/exUmAkvfIjUFXkvGOp13Y3EE0yh4vvIaUwHu78Q9TSOSjzS9J05TOHTQkguchmf89sikzs+DuEHzmme/hZo1nlU4vMuGNAczP/gLznOedHsqEjGYBmwAWih5avQhvpIrSoKes0Ga2gwxf77E27gqCNmVhQnb202M55NdLxmm76Ede3UFaBoZGSCnfmtusJDZAfTHbPOipEHziKg8oHFMNvdtorBTFC76L4uo6fKlmEoR9FtokYWvrtIDCjCtkp5+MMN24rg2KQe7DTlckLzhxPPVjik5v53W1VvopRpGztlEFBah+C7zq7baJPxTovQoRN1s1+OnfFAF928T7GoxCHUOQSmq0op6GnooXNO+SDOdy34xVDSwR+fYJ0oVmWvKJm3YiwAqfh3klepoTXp1r4DVRzQZz1kcylPropMaiHomWJPZ8djxtIRvFuerHQ8G1+wxZW1bP9Wuli7HAnZ2ToUyQU7rld+6UdEX6+cE+2Z4r0cLsuC7Lp9HN9IM5TfUVbu/w1qAMTmlAQXadZW3KHnXk2X7LD1QkaBkaA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(966005)(508600001)(6486002)(86362001)(8676002)(4326008)(66476007)(66946007)(66556008)(6512007)(6916009)(316002)(83380400001)(186003)(5660300002)(2906002)(53546011)(2616005)(38100700002)(8936002)(31696002)(6506007)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1lIVWJUOEZUd011cWFWSzg2MUcrVHIram5iakoxNW8yRU9XeE5XbmZPejZ5?= =?utf-8?B?cFRKUUNIZW5hcEJMOGk1NXhXTVc0R0RKYTFvYzB3OUlrbEVYSzdWdXllRFhp?= =?utf-8?B?Z3BsUzlmVnVBNk02NElTdVZmSnBBM3owUTMxWGRMTndtQXVhQ21KMVBudGhs?= =?utf-8?B?bm1rZmg3MTJwQnpCenNRRHhNVXhsUE5FUUQvVkphdmJjZXVvSGo3c3lFRUxM?= =?utf-8?B?WTEvOXJ2bjV3cWltSklSVFF3VTlOWkppU1U5WGpQSHZBSTk0L3ZKck9WRis1?= =?utf-8?B?bWZ2NmhqR1AzRjNudmJWQ1FHNWVwY2xXS0VvaVZjTVQrTkVBVXg2a1I0QzY5?= =?utf-8?B?NDM2YmJRcDNqQ0hvQ3JQOWxwdk5lcllOaEtsQjRxcmVua0x4UVN2ZXdQS3V3?= =?utf-8?B?V2pCdU5vbkY4RjBSb3FjK1JzOGxEQVlsc0hLaGtOamdmL2VDMWlrZzYvd0pz?= =?utf-8?B?cUZtKy9Iald1OVhvNE1PTk1heW5WdU91M3NhMGx2NEx6UVJhQVJSQXk2Mlhm?= =?utf-8?B?M0xGV25YZVNCVDdRYTk4b2lzSHBQYjRBb013K1VSeFlvRXFtTUo4dk5HOFFL?= =?utf-8?B?ZlNFUUNMdzllRGUyVmNhWmkzMlRQTlhlU2hsUStQdEpUK0lVQXhSbGNFUzJF?= =?utf-8?B?eTFpdHV4Sm84STBPL3BFTUNNS1dzQnRZNzFjb0lXWHN2bUg5UnNjdStaaEg3?= =?utf-8?B?OC84ME8veDdEZXZrZGZNYjRXRXJUUE04U2NTRy8yTFZiMW5LZXc2RE40Q1Zi?= =?utf-8?B?WTVWTE94ZW5tNzJBQlVEU00vQlQvQnFYdHhRa3lROWVBeW1ITmFrOWUydEJF?= =?utf-8?B?elpqZTloc3EyZThtV2tWTnVQbXhxcXpjWDRnM1ZKaStyVmxCS2FKQUJoVnFF?= =?utf-8?B?VWRUVkE0WGdsRmVJQm13d2w0WUJQZXduaDdXVm9paG9OcXpLMkRYZk10cnky?= =?utf-8?B?L1hHTm1melFLYVYzMnI3cHJGZ0J6Z3pCOWs0dWRSQ09mMVRmRDg1OCtKSVVt?= =?utf-8?B?MVJYRkxqQXdoR3FEZ3F2d3pBNkNyM20xMlBSNG5jL2VZTVRiOFpyWTNtWlo0?= =?utf-8?B?WjcrQTFqNDljY0M1SmR5MHZpbTc1UDZ0UWpOeHZVb3ZxMlJUOTRSc2xlcjZj?= =?utf-8?B?Wm1xUG03VVBuNWVhMHZkQUJuYnFGbjVRQmwvcnBVZWNzZGRXVnExaW5qRGpo?= =?utf-8?B?Rk9NZ0k3OXlqN285cjQ5bENNODEreUU3TG13NDVYZVI1dDNiSzBsUkpKcUV4?= =?utf-8?B?WXlseTdZUElXT0d0Q2dtcFZnRnB5VGpNcWdhZjBjTmNxUFMzSXZ0V2Z5WDNq?= =?utf-8?B?V1I0aUVpczFvZzlmY0FGdWpIVndPRFB1dVpDbFNVMFRGeHluR3NUdzBmd3Zi?= =?utf-8?B?V3B6NWczcFVrZDZIUy9EZnlxNFFNRENqajk4b24xSHVHU1BrTFgyVnFZWklB?= =?utf-8?B?cVlqZ0k2L3AyVmJhZzF5YnprQk56VHB1YlU4alVURHowNm9jV296TW0va01F?= =?utf-8?B?a1NERS9MN2RHSlYyc2Rzd1U5MDR6WkVPeEVMRnpnTTRLejgzS3VCemFaVURw?= =?utf-8?B?NVQ3eG5EVE02RFBxRWNNeHVIYzladmNQeWx1Q3dBbmU0ZzFDNTg2SWw4Vlg5?= =?utf-8?B?b2x4K3cvckdKMFUwNGpPZ1dXNk1QaEdUTVRqT3REbE5PbnJqS2tuZVZZMkJW?= =?utf-8?B?NmJWRCswZzdHZHUwVURSaXN1NW81R1FLeXRLV0FsdWhoREN1Wi82UDMwV0FT?= =?utf-8?B?MTN4NEJSekRCbDdpSDdidW9FclhEVWhCY1cwdXFCL1pNRmJNNFA1MGMvbWpH?= =?utf-8?B?R04rRDRkMmRueU9Tek8waUxhL0pqZFNwVTNnZG9HNXV5RHVUcVJqREE3elJU?= =?utf-8?B?TTlZNFp5dUp5NU0yWmtPMWwrWmowQnVFOUdMcjd2dmhYd09teU5JQWhjMlBP?= =?utf-8?B?U2JreGF2a0ltL1ZrN0h0ZGpqR2NETkFSN0dTemNGVnRJdzZJMEJDMWhtNS8r?= =?utf-8?B?cExvOWdmODNNRVoyeEdMQzR4aCtqV0hnZDBxbGlLU3o5SEFJVXhnMTFCbWVN?= =?utf-8?B?clVIT1RvTW9yRE5lWW9na0pVcXZ1YUFVaU1xeW5tQlJJUEYyUHdrSW5INVdn?= =?utf-8?B?WFBiZlZyVXd3S1JydWpwY3JiYVhrRERSaWY5UEZnY1FPSHdSM2tZaTZzYUJC?= =?utf-8?B?cnZjbEdlOGxuaS9xMnVSOHdBbHlUY2Y4SUdKTlFEN3FQUWx3STVDKzNBZXpC?= =?utf-8?B?Y29MNDhrOXVNczBoQnBCcHZMZGIxbURkVGdubTMwZHJUL2sxVnpscmRjdDVH?= =?utf-8?B?dkxNNm43aTVETjd5a0VkSE9PTVZEcmF1ZmVHODJ0ajJQdHdDbDAzcTBmeG0w?= =?utf-8?Q?BifJR1XeiHv3CRx0wRk4kjw1Oi6I5zU87Rp/LLCyK3XZg?= X-MS-Exchange-AntiSpam-MessageData-1: rR/lrdNRG4pXmA== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0490881-6108-4a0a-d932-08da3efb3ab3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 09:36:37.0331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xx8AzuB2+5uJbjREgTTUrBB5eyFgZ19E9K9/ga42/jm6k56FxfQ+Rw2+e10VJN70Nb717t6Acso4DYqIyLW3qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7703 On 26.05.2022 03:12, Stefano Stabellini wrote: > On Wed, 25 May 2022, Jan Beulich wrote: >> On 25.05.2022 02:35, Stefano Stabellini wrote: >>> --- /dev/null >>> +++ b/docs/misra/rules.rst >>> @@ -0,0 +1,65 @@ >>> +===================== >>> +MISRA C rules for Xen >>> +===================== >>> + >>> +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the >>> +MISRA Consortium Limited and used with permission. >>> + >>> +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for >>> +licensing options for other use of the rules. >>> + >>> +The following is the list of MISRA C rules that apply to the Xen Project >>> +hypervisor. >>> + >>> +- Rule: Dir 2.1 >>> + - Severity: Required >>> + - Summary: All source files shall compile without any compilation errors >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c >>> +- Rule: Dir 4.7 >>> + - Severity: Required >>> + - Summary: If a function returns error information then that error information shall be tested >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c >>> +- Rule: Dir 4.10 >>> + - Severity: Required >>> + - Summary: Precautions shall be taken in order to prevent the contents of a header file being included more than once >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_10.c >> >> Like Julien has already pointed out for 4.7, this and perhaps other ones >> also want clarifying somewhere that we expect certain exceptions. Without >> saying so explicitly, someone could come forward with a patch eliminating >> some uses (and perhaps crippling the code) just to satisfy such a rule. >> This would then be a waste of both their and our time. > > Yes, and also Julien pointed out something similar. I'll add a statement > at the top of the file to say that there can be deviations as long as > they are commented. We need to determine where such comments are to go. I hope you don't mean code comments on each and every instance of similar-kind deviations. > I wouldn't go as far as adding a note to each specific rule where we > expect deviations because I actually imagine that many of them will end > up having at least one deviation or two. It would be easier to mark the > ones where we expect to have 100% compliance and intend to keep it that > way (once we reach 100% compliance). > > We are still in the early days of this process. For now, what about > adding the following statement at the top of the file (in addition to > the one saying that deviations are permissible): > > """ > The existing codebase is not 100% compliant with the rules. Some of the > violations are meant to be documented as deviations, while some others > should be fixed. Both compliance and documenting deviations on the > existing codebase is work-in-progress. > """ > > >>> +- Rule: Dir 4.14 >>> + - Severity: Required >>> + - Summary: The validity of values received from external sources shall be checked >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_14.c >>> +- Rule: Rule 1.3 >>> + - Severity: Required >>> + - Summary: There shall be no occurrence of undefined or critical unspecified behaviour >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_01_03.c >>> +- Rule: Rule 3.2 >>> + - Severity: Required >>> + - Summary: Line-splicing shall not be used in // comments >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c >> >> To aid easily looking up presence of a rule here, I think the table wants >> sorting numerically. > > They are sorted numerically, first the "Dir" (directives) then the > "Rules". Oh, I see. I didn't recognize the distinction. Maybe have a visual separator between the two classes? >>> +- Rule: Rule 6.2 >>> + - Severity: Required >>> + - Summary: Single-bit named bit fields shall not be of a signed type >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_02.c >>> +- Rule: Rule 8.1 >>> + - Severity: Required >>> + - Summary: Types shall be explicitly specified >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_01.c >>> +- Rule: Rule 8.4 >>> + - Severity: Required >>> + - Summary: A compatible declaration shall be visible when an object or function with external linkage is defined >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_04.c >>> +- Rule: Rule 8.5 >>> + - Severity: Required >>> + - Summary: An external object or function shall be declared once in one and only one file >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_05_2.c >>> +- Rule: Rule 8.6 >>> + - Severity: Required >>> + - Summary: An identifier with external linkage shall have exactly one external definition >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_06_2.c >> >> I don't think this was uncontroversial, as we've got a lot of uses of >> declarations when we expect DCE to actually take out all uses. There >> are also almost a thousand violations, which - imo - by itself speaks >> against adoption. > > Ah yes, good catch. We spoke about DCE in the context of Rule 2.1, not > this one. My preference would be to keep Rule 8.6 with a note allowing > DCE: > > - Note: declarations without definitions are allowed (specifically when > the definition is compiled-out or optimized-out by the compiler) I'd be fine with that. Jan From xen-devel-bounces@lists.xenproject.org Thu May 26 09:40:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 09:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337506.562110 (Exim 4.92) (envelope-from ) id 1nu9yV-0008OT-T8; Thu, 26 May 2022 09:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337506.562110; Thu, 26 May 2022 09:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9yV-0008OM-Q0; Thu, 26 May 2022 09:40:11 +0000 Received: by outflank-mailman (input) for mailman id 337506; Thu, 26 May 2022 09:40:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu9yV-0008OC-0J for xen-devel@lists.xenproject.org; Thu, 26 May 2022 09:40:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d560deff-dcd7-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 11:40:10 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2172.outbound.protection.outlook.com [104.47.51.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-UmvOOUKVPrGYAsMC7KhIig-2; Thu, 26 May 2022 11:40:08 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7703.eurprd04.prod.outlook.com (2603:10a6:20b:23c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:40:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 09:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d560deff-dcd7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653558009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W61iktpzTnKmgSm6nbbdsEvacfyQfreBrED76hKaPIQ=; b=au6LowMFNxrIHBlsWumxvR7ruh+PfFXVzY9vjjP3Lyrh+2gj7rq4MmyvbipHzbI2Xpu7rQ 5I9vbmjfw0SCw8bftYh4dWQzNkCS3G+m5M6upYljgozzWo/cyxjEvbv9r1/EMOb/JiCOsj EGX9jBYxJIL8SkxdTc5Gl5kG1MMtfZw= X-MC-Unique: UmvOOUKVPrGYAsMC7KhIig-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+2zil9uEW4JN0btdLIbMXpdG1f4L9l0E2rBjW14uYTm6BhM4YmxpBHjHQbp5AzmKbemNUgNFtMynLYCtbjkDW5FLnLDA4ldsoXpH4gvS1uGJBXGYnIZrqx9I1zHBg826YJPN5C79EGGh8FtJQTG6OFo5d94E7FsPKw6SiCR0oR85Zmop75dI2f3FUJtZuZXrga4LnB70wJLtuGuSpnOoE2QBQhg0e5xBZpsVIt1Zyx4iUQyPq6bCZng/pARNqhA5EljyDn4PP5UD6ZV/IHmj7pIlm9bNHbJVveIK0I0uNjNgXOBgRE+hYZ/O6c3/Ysh/dWrHZAtBU4xQGPlB8qqGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W61iktpzTnKmgSm6nbbdsEvacfyQfreBrED76hKaPIQ=; b=DKEKM2S1dOu20JEj8KXOhRABxBnefKV6nZi7D4ZnIjciKDVHDgzGJgRsk4OFTP+O6aEQw2tenmo2PL6LEqqSPRax0F822Ai/Ausa7pUzdIZswWIzig6MP/cBq6baMVO8y1MqGdIx/SW27aB1dujUd72Z6SiiVJSZ021tymUtnb6lZIqFtnAHGXhoUj6KGYj6zx0yo8jhjKyhBRVNQOQbLwg0VhosyBKMA9Pl1uQp4Ngi37XeFLG1c4vPfWr17ZK+TZl19X9rYhUObWi1NawQhUV2U4ctXQconrcJ0N/E4UsEAstPgcAHxZuzpxEYAo3BCtD6zAqI+nbZWBXe+xWj5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <39c930ba-f5b4-14a4-ec48-19dba9a21509@suse.com> Date: Thu, 26 May 2022 11:40:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220525003505.304617-2-sstabellini@kernel.org> <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:20b:310::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60b2d460-d7e4-4eae-ecf0-08da3efbb80c X-MS-TrafficTypeDiagnostic: AS8PR04MB7703:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxOsrg3dLoUX336/iJrlB651SIZ0i7q0zXB7R4TcbB+CJPqRphEDnxrA4JS5VPz9MI6RbwSu8KLCM3Xbq1UQuU/wImB6D08g/Hk/rXq4ZLY14u3CvmBoyja4cOAzuSsqWBCEctX1mt4z4CrB7jPosmVXmXdP/L7DJZ1xsfltlVM8qoTUYuOrMbn3xIq6dWnLAVecnx4gT6UexKJcJzWK0RJcHerYaYmDbJ9QfKeUVXSY7X/zOeLRx/GYjhW2K5+18aZYVr8CbwaHljVDgG8uH8oiJIINLYasVqi+sQD9DLCidzg28GJ+sVHJ8syArMZBvx86F41RSzt8kCbDVjouhOplnnPouEVsAgNgxGmWR9dwcu9EHKwAHuSZh59+i2Mt1RQ2eMVB/sVb0EAcm+opHVzZL8uqU9zUTqCJmb9NGjl6310reg943XXqvKMKKSmj3LgD8wueoRpAvSDJ/JkUNDrqfvoeRbd2/s9yE4keutYbSssUgfHffPBO/G82gNRHxp0v21/ssCpsZErAOQClvOqOovET8FvXzLzfB+n//enxO99veHXoD7tu48tJkLOIVGZKMGrTq4tVrck3QDGrrXNETfGGho1Q2vnYwtlnfcJyAmm/OgzGKM1qXeSnKKjeESbojd92jAXgRnzprP40syAHj1ODb0tTSaAQFGJS2B482gFimV3TGc13oOPEh5EHSGzT1VhfpN5v4eBpdX1QU9BR4f5LL1FjhDynS7bYpMI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6486002)(86362001)(8676002)(4326008)(66476007)(66946007)(66556008)(6512007)(6916009)(316002)(83380400001)(186003)(5660300002)(2906002)(53546011)(2616005)(38100700002)(8936002)(31696002)(6506007)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mms4enlqNmluMG0yTzgvZHBjMk1IU0g4VE1oaXlWa0trYmtqTmZ1OTJmK0sx?= =?utf-8?B?bXpVYU1MWkdEblhMWXgrUFo5c0xMUVNwSWhhZ1F6UHBmcWx1am5WQmEwMGU1?= =?utf-8?B?aXRwTU5iZktyMXU5OWNyVjN1aDRIaDR2ZDZYOVFTOWYwNTRYOGMxK09QOFNL?= =?utf-8?B?UnpqRW9ZVWUzNytnMXlZemg2WEc5L2grayt4SVRRaTRPamRaQWFSdDhIY3NI?= =?utf-8?B?WGd1U3lneTFlaldORzc1bC80NkNrQ2h4SEFqSUt5dFZUbXBzeXllNDdFVVor?= =?utf-8?B?YjJGaXZtZmYxbC9PZlVvMlZFODFxTWJtMkJOcEVpU3NYMDliSTBka1NlejhW?= =?utf-8?B?OXJYY2p6ZTZpdXJjZFdoVjQrRXdRckhMMWFXcTZCOENjK295ckY4ekh4eWRW?= =?utf-8?B?L0c1N2xiY210QjVwSDkxS1l2Rlp3S3krcmx5bGhSdXlneWx1eWdCaFZvVWxK?= =?utf-8?B?TnFaYjBxdlRSSlc2VzhxZnRxVWYxcHVwSmFkNVZkUkpDQUNvL3JrRUw3T0FN?= =?utf-8?B?VXRXU3RmSmZoZ1NRaVNZd1pEaXR1SVpmWmZZc0ZDWHlCbjRHbkhERHIzalZp?= =?utf-8?B?eTZzbzAyWU1DQXlSZmIyVXN4a09EaEpQWU5BVW9RYnZVSDBUWjA4Zml0cDl4?= =?utf-8?B?Sy95WVpvSlovMms4d0FXa0FPZHNHNzd5d3RZZkwvSWxqa1lXcDQ3dTJrTGFv?= =?utf-8?B?R2hYMXNzK3lLditaYzBrM2VUN0ZWOWtkanRvcUdBaXNHV2tTbXpJNDN5c2I0?= =?utf-8?B?ajNxZk1DeVk5aTdwSENQaWZJRFNUbW9QZUlTbFYxekc1TDRRTkl4eU01a1or?= =?utf-8?B?TE9IQU9zcm9HY29nelcwWmluVnNTUlQ2QmZGWEtacXJzK2t1THJUMjNSMGRD?= =?utf-8?B?TTc2eUZHQ1VOTmVLMGk4UFVYdzlURlhGekI3U2NhZWlpRGIzV3ZjY1IwR0c2?= =?utf-8?B?cnVnUjNSOEd6ZVo0N3BVd0pTMExabWtMWm1FTVNjWi90Qmpnam4zS2ljdTZ6?= =?utf-8?B?bElIUFNWbklHb0llYjFqWitBLzdVUkdLRzVNdDdOR0hJeDNXaVRSSFFFYlB0?= =?utf-8?B?RVQxKzk0WWxpMWZwVllsQzlvanllS293YStFRG1Da05iZWtWQzk0c2VDVmtM?= =?utf-8?B?WXR5K05mQ1Q2T1lNU0RPaTd5VGZ2NjBzcE1JbjdtMDVIaVl6bjkxR01MZDF0?= =?utf-8?B?LytpVm45S2NpZ1FMVjJubENabEU1OGpUcmkyQW52dDB3YWoycFZtOXkrV1FH?= =?utf-8?B?cjVnYVo1NVRZNHlVRXY4L0JHVDBsZ21EVm9TTUtxNHBHUEkrNGphbEV0d3ha?= =?utf-8?B?SkE1UFF0ZjZQUlBHN24rRmpsQTFnd0U0REJ2di9BejF1dTZkbHpEbXVudkF6?= =?utf-8?B?Wk1xQ2FoUlcyVXMvcXlleFNOR0l6TTVnSmVEKzUxUktGZXN0T0xSVzhCRHFX?= =?utf-8?B?NWlKZ3NNeTgxZlVpTUx3eTZVbnd5Y0ZaMWdDN2FjODZKWVFWNmd6NFZNQ3hy?= =?utf-8?B?c1ZTSFl3Q3A3VzJobWVRdTFuQWlBajN6b0llZWkyYitsWnN4OUx1c0EwU0pk?= =?utf-8?B?ckhCUVg0SWpCQUhPaUVZZEppWVJ1dHk0R0pkUHhId29TYlJRTW1SYk9pOUE2?= =?utf-8?B?U21MZE1BaVY2ZXVBSWVqL25XdVVBVGtvenYwaEJ3eVRLdXZCVG5KR2lwZ0Rs?= =?utf-8?B?WkNvWW9QaW9pMUEwUk1sMFcvcGhIVEtSN01SZVhRT0s5M1NPOGtDSDQxQXJ0?= =?utf-8?B?Yld3b3JRTElqb3JVVERiTHhtano2R2l0U1hVVytYOFBEVk4xektRVEgwLzJv?= =?utf-8?B?QmMwblY2V1RKTERmam1neGh1UVZEdHd2ZEw0aEJGTTk1cGtFaHFuVjhubXFL?= =?utf-8?B?ODUxbnBIZjBKRzlyQ0FwMHNhNUxWUG9MbHN5WW1hU2NVVTRxZWxFUFdmRVRm?= =?utf-8?B?Vy9EK1VNbjQrNXhSSHY1N0xMODVsUW9aakJRUlRIZ1FvQnBRYisveWw4VWNy?= =?utf-8?B?dTZmeDR1MGNoQVlBcTJ3Q01OckhWd2VLZWYya1NLQ2cwWkJTYUo5MmR4Nkc0?= =?utf-8?B?eklZY2xRYlJjQTFIajdKU3AzbXQ3V2hQMkN4WGdTN3ZvbmExSUM0cnNsYThO?= =?utf-8?B?SWhDU3VIcU5NMU1jeEpzV0pRaWZUVHFHc09LR1FYUWxia2JvNnRtOXJmUit2?= =?utf-8?B?R2lmd3lhcXRuRDNibkdMSExKeklwZkZiUGRRcFByZlNMMldRT3FiaGNndS9P?= =?utf-8?B?ZlYwZFByNDJPckhwSXBjdVhZWTdXamxSMzBKK3NrQjJSQnVLTkRzamN0TGhu?= =?utf-8?B?NllKU2Z3YWNjNlBXOG56WXFBOXQvNnNuOTR5L3BXOEErZUh0NGR0OW8ySHlz?= =?utf-8?Q?B6DCF/aZKphUE4N+7ieXAOBp+SI2qsh4ujpi0RGlzEkts?= X-MS-Exchange-AntiSpam-MessageData-1: PA1rdajFYQZnEA== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60b2d460-d7e4-4eae-ecf0-08da3efbb80c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 09:40:07.3164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GmE88wGmv7Lap+Pb1wOZ+Azc11eU8etk0443AyY1lJpfXdJWhKaYpR0SR+XAXPWensFl4236B57tHXy0ii4+HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7703 On 26.05.2022 03:18, Stefano Stabellini wrote: > On Wed, 25 May 2022, Jan Beulich wrote: >> On 25.05.2022 02:35, Stefano Stabellini wrote: >>> From: Stefano Stabellini >>> >>> Add Rule 5.1, with the additional note that the character limit for Xen >>> is 63 characters. >>> >>> The max length identifiers found by ECLAIR are: >>> >>> __mitigate_spectre_bhb_clear_insn_start >>> domain_pause_by_systemcontroller_nosync >>> >>> Both of them are 40 characters long. A limit of 63 characters work for >>> the existing code. >> >> I have to admit that it hasn't become clear to me why we want to >> permit (if not to say encourage) the use of such long identifiers. >> If 40 is the longest we've got, why not limit it to 40 for now >> with a goal of further reducing? A 40-char symbol plus some >> indentation will already pose problems with 80-char line length. > > We can go lower than 63 if we want to. I chose the closest power-of-two > length -1 for the NUL terminator. But it doesn't have to be a > power-of-two. So we could go with "41" if we want to. > > Anyone in favor of that? I am happy with any number between 41 and 63. Why 41, not 40? 41 seems yet more arbitrary to me than e.g. 40. >> Otoh, as said on the call, I think the public headers want >> mentioning explicitly here in some way. Part of them (most or all >> of what's under io/) aren't used when building Xen, so won't be >> seen by Eclair (aiui). Yet they are a formal part of the code >> base, and e.g. ring.h has some pretty long names (albeit still >> below 40 chars as it looks). So once we're able to go down to e.g. >> 32 for the bulk of the code base, public headers should imo still >> be explicitly allowed to use longer identifiers. > > Actually I thought about writing something for the public header but I > wasn't sure what to write. What about: > > - Note: the Xen characters limit for identifiers is 41. Public headers > (xen/include/public/) are allowed to retain longer identifiers for > backward compatibility. Fine with me, except I wonder in how far going forward we actually need to play by that limit there. Proper name-spacing is particularly important in the public headers, so may warrant a higher limit for certain (unusual?) circumstances. Jan From xen-devel-bounces@lists.xenproject.org Thu May 26 09:44:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 09:44:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337515.562120 (Exim 4.92) (envelope-from ) id 1nuA29-0000fs-Gz; Thu, 26 May 2022 09:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337515.562120; Thu, 26 May 2022 09:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuA29-0000fl-EA; Thu, 26 May 2022 09:43:57 +0000 Received: by outflank-mailman (input) for mailman id 337515; Thu, 26 May 2022 09:43:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuA28-0000ff-Af for xen-devel@lists.xenproject.org; Thu, 26 May 2022 09:43:56 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ba3a333-dcd8-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 11:43:55 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2051.outbound.protection.outlook.com [104.47.1.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-6GY9GHbCPRiq5fIJIkfYhQ-1; Thu, 26 May 2022 11:43:53 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7166.eurprd04.prod.outlook.com (2603:10a6:800:121::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:43:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 09:43:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ba3a333-dcd8-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653558234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rNLzXGPzEDdIGxLiFrm3a0H/HsUlejL2fZQ/rIXKN64=; b=Mqs2fU1xKj+Rvyvi/3jA+EU57lztZYLRkZzf5P987OYFXqslwvIci1N5pX8tWd9muQ35uR L2doOzgkDMI+21KF1XzOxz1dH+8MIwx1lEnkBw5+Jyl37SCUgRwNYX9aJJVaUpLafwu/XT hvXbmDzH4raKMyylARNb4jw7orELZQc= X-MC-Unique: 6GY9GHbCPRiq5fIJIkfYhQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6f4AU1aD8MdO5DsNt0flMRvnx25m7dkgQpiFiDfQTd3IOFlH8bY2m0HTkkfRK5CAP+TsKV3I0NJOPrJ8ZEg4Le0hW05eFiU/RyspZQlb5Imun96fRhvJCeEw1R/8djggszpOf+xps9Kujmq4pzCEbm1DrPV/qJanTwtGIOW2201+HxWT01jTYeKT1DtRDYH84jE7O5uVcvUzpSCwW4yd+/lTZFqZKclg4GFOyG/0QZdd1yOgXhPRGY5l/Y2p4siXqc5u6XqGctNK0BvaRMATYlP8WSq5APVM/zApzE3g33RK5pTe7jAy/0Ijk21gCLL4ZXKEH+PfYP6jTnS53NvkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNLzXGPzEDdIGxLiFrm3a0H/HsUlejL2fZQ/rIXKN64=; b=I3Q7qgvZkkMsVU0EGnMK7moFkUJx/BWxdFm1V2zu3ltBT4mfLIv0gxKGpfNls6xYeL1vOBTGdAbd1fuCM7Kp5g2d4VqkDwaq8KEKCs/YaFnEP5cFihW4CWmCR1zmfb+CR7qBzekesa4TqoD9xH4lNbdm8n7oqZHnj0wNG/wG/YnO84jzlRScvlAH9hVYGpRq/GKkaivzSnilSftY832fXJBhtRt0Sw7expSl9cd9ES2y4faHjaXkss1huST/CgZFmNR0U2D1ziEZvYAmNakQR8IuY1K8LXoV7PXKw5iKyNUYg6cBWosFYP9V7scn607qk68Ge5SPELjGowG75cHHew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> Date: Thu, 26 May 2022 11:43:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, roger.pau@citrix.com, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , Julien Grall References: <20220525003505.304617-1-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0023.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::36) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41535932-8609-449e-2f63-08da3efc3e60 X-MS-TrafficTypeDiagnostic: VI1PR04MB7166:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /aOwbNjpOj7l8/Q15cP0Bye84xSZpD5/PEpJfzUA+A75UEpUA/4HST2sfvxrPBC00MeMuT6S0MVwtu9aYXkj2Z7EETbTGLkdi1PVPLSFNxr55EljGMmbOdioqaXL7fGatLAJjDfDGXLiK3aaLQWUshAtpvGzu/R7CzD49d8trQXaxvPlpm+r+J1mvBb7KdlP4bTOKkp4BOVhV6r9JG++yXzfgcoqwILyBqfGjj3QJl4JWeJFr711G3UucUaq1eK4CIK2UN15ju5f+tCEO84BpKe6IXzHADNreVv83ExKLqp2E4hmqr9AAk351WngjR7hAXysG0Id2Jsl8h+9qNVn7HFuZKK+nCSJPUjM+DmFNsW4/2nXC8Bacw5gODF+4OHPlByxGTV7Lu+s8m5TYA0QRiqw/PJTxGr89WBdDnV6yg2rUC4BrKNm/m01wCERiMK0y8jNZdt8Aahj/4PQzSUsiEKIgGg6WC2luZOnAW8YN+15h63zgsWuwI/bsuqpwY0uj8emrIoFK26Ee7R1RKFsdIRuCj/wklLHLJ+zU9G6Kl8PJTUvMu5TPRCKycW7MVEB2gO7Lel3OR5SlpMGFqfZHAWCT7P3KQeOOR4CPrrSh/IdGKhAonVU8um2lp/uhYpf6r5sl2/JTnQUbUxhuz0DGym4NYsoIMDDfC+HbHUzopqXDEwKwOZRPZ3DHL5bM8f3eNUEiJNKmQQ1gI1a5B77du3nTXmrz4jfTOi94wyztibtQ83u2uIK3fkyIXZF35XdzweJoIhmhrg+BjmROJE+EFHNa97Ug0wTA2W8heOTeowfSWK26Kk2ih+xNJBQIqLS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(8676002)(6512007)(4326008)(5660300002)(8936002)(66556008)(66946007)(508600001)(6486002)(966005)(6506007)(316002)(38100700002)(36756003)(31696002)(6916009)(186003)(54906003)(86362001)(2906002)(53546011)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?andwdDVSalJVeFZiSzdiSS81eE83OWxvbTVReDdnL0gzNFdnQXBtZXU2amtC?= =?utf-8?B?ekZHaURzc0Q1eEYvRjJmWGlxSm1hOWlHZnJSc1YrUitoYTl0ZlBVRzdMT2ti?= =?utf-8?B?VVJWRlJpc041OU5WRVNsNFZKOHF6Y3hYUnlFcFo2SmZZb1NqdHlFaG8zZmZ4?= =?utf-8?B?bFU1ekM2amVhZzkybUtXVEI2RzRoSE1OL1RvTEhndnc5dXF1SXNsNkNLWGZw?= =?utf-8?B?LysvNzVsR3YrUE1teWtKRjBSUnVkUkkrOUdKdXY4M0loblVrTE9SZUhEcmk5?= =?utf-8?B?MHd2TWFOajd3ZUtwT1JaS3VrT084RlAyR0pRSkJIaDgvOTNmaFhxeTVha2hh?= =?utf-8?B?Yk8vSkYrQ2w1M3RkOGlDUy9YV0tBc3RLUkxJcGVvZlRSc1psbTVOemRuYWpw?= =?utf-8?B?Mk52TXA1d1hsdzVNTFJtYVZDQU1hZ1N4Z0RBd2R5Q3d3V2VVbGJ1YVpmNjNr?= =?utf-8?B?Z2M3bDM2UEhjb3F6MFZmSDdzVU03bFIxSWdGUzRqL3dZd0djMm1YYzFqNVVP?= =?utf-8?B?am5EaUV5MVNVRkVYWitPWFJ2K2w2dUd6ZjNXT29RQldXeTU0TnREU1NsaG5v?= =?utf-8?B?ck1ZWmM4UjJFTXVTVTNCZVhNUXBZdmZ1a3EzMU4xM2JKNTBqR1BtQVlhb0ZT?= =?utf-8?B?cjdLbkF1ckQ5VUJJWFkybHBjSE1ReksrZHB2TXZPN0x1VlVDNVEyRXFNcW5j?= =?utf-8?B?M0dGVTZoQjRTbmlPT2NYb3RXSHNMOHY4SE9Bc05OTzM0UWk4UmdlcFpCN1NE?= =?utf-8?B?N2FqN0t0WHdEMkhadVNMTVJwOUMxUE40dFJIcURtakdPV1hIc2FkcjJacnI3?= =?utf-8?B?NFkwQjlqVTR1Z1pTM0dXR0hHOEo0OGdPTGFybHVlbTJuV09CZHBrOEZoL1Uy?= =?utf-8?B?K2YrLzgrV3BBRXIvMi9Kb1B5TGdFaWZHREt1dnlsMlJueW1kL2Q3NE5wd1dM?= =?utf-8?B?V0ZkSlZRejJKbU5GZXpXUmo4cDVIT2xucGlVWi9YS1JMMWRMTmlja2JWbWV6?= =?utf-8?B?S2hrSWJVQ3JCZjh4ZDZIOFlTdzRTczVuQjB3b2dIZ1R6RVZROENoRE5vcUl0?= =?utf-8?B?QUxKcTBjWTZvNzRNL1NCcU0yYWFBWUt6S1MrYk1sc0o2UThQcjN0SU15YnZz?= =?utf-8?B?OGVjbUxVL2N4TGc5d2JTR0w0VHp6anBuUjBHdHJaWFc5eEV4eTVLL1FhdkpN?= =?utf-8?B?UkJLejlURkJ4SmxxbWxrQ0ZBTGJDWllSQVVwMm04a040WmwrY0VXb0N0R3pL?= =?utf-8?B?MDZGbk9Makc5dzdvbUIvcHlVRjFpVkhZM2w2VHJvcjErN2Z4YzZ5eVhBZUxr?= =?utf-8?B?VEpWNzlsTDdKM1pqVFNTZmVpbG5zeW5QMDYvYXExMTd2RUJxbHo5aE43bEtE?= =?utf-8?B?bjkxb1BZZUNwTjdTT0FHczROTHU3R3hReVR4Q3RzR0ZRbzNIS0ZwcndYYmFD?= =?utf-8?B?OENrQ012MGtFNmNaT3N4ZzBTc2tPOFRNanpqbkV1aFBKRDFMc2VFb3JHMkRa?= =?utf-8?B?OHJNTWw4bHN0cVU1U1lUbjdSWElXbzhBNXI3YXJlWjJpUXowbW9JdUpnemtM?= =?utf-8?B?S09oOWFDeFhZTm1DR0owOVNNQmpGNURhYXp2a2tIenV3eEdyUkpFcGM4SVVK?= =?utf-8?B?YXROWjhjNTl2SU5zYlpGOEh0ZkNXRHJJVHdTbGxaeXVrRkJvRGg2ODFFL2pQ?= =?utf-8?B?b3U5OUFmVm5hSDJsb09rZXFRTTlwY21QMm1DNjhJOER1TFJENjlRblRzbFFV?= =?utf-8?B?TU43UkRVd3A4WHRWL1EzV2s5ekhZSEtmVHgvVVlHRG53b21LVXN5S3Vwd3Zj?= =?utf-8?B?ZkhCRnRici9NZUgyRWlLbHNUOVNVSVhpekYvVnlxWjVBQ05NeXpaaVJnaHJ4?= =?utf-8?B?bFU3K3ROdGNNTDZnMGxUZzdiZUZqVTFKTHhoVWVoRDBkVWhqTXhUaG9mU2Q0?= =?utf-8?B?Nk9EOXlmbmJvZUthOE1ZVHF5cWlDK3RiZWZoR0o4RWlSMUI5MXRNcldRUFlF?= =?utf-8?B?U0tKNWs2cVNxbWNIZHlyeUtieURpUEdaN3NtWGNVNm10WThxZ0hqRnlvaW5D?= =?utf-8?B?K1FtNHI4M2RFbFBrR2dZWFNNcW5lR3NSZEsyd2lsMSs2RlFETWJNM2d1cFRW?= =?utf-8?B?RCtVNHJvWXFmTmtIcENkbHZtWnRaVXNraFdHcTlkOW11N0YvNlNOdDI0TzRj?= =?utf-8?B?bG1uNDcyZWl4Z1d6eTlrTUlVQjViYWlwazRDYXpwcjhBMDVNd1RpMmlWYlhP?= =?utf-8?B?anRqTlNKNEhLaVBzWFVsdUx6MmJBK21QU3ZhSFB6WERQTUphR3owN0kyWlBT?= =?utf-8?B?blFDbkRockNuMEE5T0luOU9rVFdmd0hrdkxZNm01d3ZUZ2Z3RVU3bjVoeDBU?= =?utf-8?Q?0ttOneHUiSGjdAI7U7cJNQ9iI+RLzx1gV+1DXNBZjHXBI?= X-MS-Exchange-AntiSpam-MessageData-1: RvSrD0rrfgDzTw== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41535932-8609-449e-2f63-08da3efc3e60 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 09:43:52.7080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3W7YCXhTgz+uPqDtSd4tkbjQmHJEcMLT3KVHsVY8OAWNYUhygWTZFFXFv33UrAsNWZqaLWj8iryiofwlm7FylQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7166 On 26.05.2022 03:02, Stefano Stabellini wrote: > On Wed, 25 May 2022, Julien Grall wrote: >> On 25/05/2022 01:35, Stefano Stabellini wrote: >>> +- Rule: Dir 4.7 >>> + - Severity: Required >>> + - Summary: If a function returns error information then that error >>> information shall be tested >>> + - Link: >>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c >> >> >> ... this one. We are using (void) + a comment when the return is ignored on >> purpose. This is technically not-compliant with MISRA but the best we can do >> in some situation. >> >> With your proposed wording, we would technically have to remove them (or not >> introduce new one). So I think we need to document that we are allowing >> deviations so long they are commented. > > Absolutely yes. All of these rules can have deviations as long as they > make sense and they are commented. Note that we still have to work out > a good tagging system so that ECLAIR and cppcheck can recognize the > deviations automatically but for now saying that they need to be > commented is sufficient I think. > > So I'll add the following on top of the file: > > """ > It is possible that in specific circumstances it is best not to follow a > rule because it is not possible or because the alternative leads to > better code quality. Those cases are called "deviations". They are > permissible as long as they are documented with an in-code comment. > """ Hmm, so you really mean in-code comments. I don't think this will scale well (see e.g. the DCE related intended deviation), and it also goes against the "no special casing for every static analysis tool" concern I did voice on the call. Jan From xen-devel-bounces@lists.xenproject.org Thu May 26 09:55:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 09:55:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337523.562132 (Exim 4.92) (envelope-from ) id 1nuACu-00028U-J0; Thu, 26 May 2022 09:55:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337523.562132; Thu, 26 May 2022 09:55:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuACu-00028N-FI; Thu, 26 May 2022 09:55:04 +0000 Received: by outflank-mailman (input) for mailman id 337523; Thu, 26 May 2022 09:55:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuACt-00028H-BP for xen-devel@lists.xenproject.org; Thu, 26 May 2022 09:55:03 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0614.outbound.protection.outlook.com [2a01:111:f400:fe06::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e89a3141-dcd9-11ec-837f-e5687231ffcc; Thu, 26 May 2022 11:55:01 +0200 (CEST) Received: from AS8PR04CA0080.eurprd04.prod.outlook.com (2603:10a6:20b:313::25) by VI1PR08MB3583.eurprd08.prod.outlook.com (2603:10a6:803:84::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:54:59 +0000 Received: from AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::8e) by AS8PR04CA0080.outlook.office365.com (2603:10a6:20b:313::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 09:54:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT056.mail.protection.outlook.com (10.152.17.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 09:54:58 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Thu, 26 May 2022 09:54:58 +0000 Received: from 9729db715e0e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 78A15CF0-13FB-497C-A18D-F5F1CEDEF94C.1; Thu, 26 May 2022 09:54:51 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9729db715e0e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 09:54:51 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3271.eurprd08.prod.outlook.com (2603:10a6:209:47::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 09:54:49 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Thu, 26 May 2022 09:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e89a3141-dcd9-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UTnInzmY4CjohdmRkhTcoCmFBLUCnJe6sOji6cHEFXX4jVvnAH2tOz4JYMn/mRdQuXWxsaV/t7oN2g/pXXUI6Y2bI4g7r0sRUuhWhtx6xgL/AmLLpE836fSo2BRZQPxP+snO+LwC5MR4FBsrr8QDA/39TVxV2K2EpJi9vN1+GE0oy7A0VbE80MCwkhm9uEDnlIIBESKcNGpVtGpAHlvdAQpWyX1WqADv7i8Ih+fNxc0mcSdYKc9JEYa/2eHb8h/vYeG6scN36xea8wNPzuihsNcD7Gb685MNsQx4+ikfuQ7kp9oz2inLAnObzz+mNp7DqaY5kuQgNpPS9Xvoi23lXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vk+Xz2ZDOYww1LHn7f8Zc2Tquf5nZ/LkVCi1pMSo9QA=; b=B/ZODfXYO8WKyeQ8EgnMCoqIOYY3RSrheryrW3XzC35r/rQiiDU0ovntPF/GR30B6btliPShvDUmhkGBGCMz5S7XoeiiWzJUvXxZhYGuIbq9NbMIYFZcf1VSWE/XlA33YtPX5Y64AtTx8VfDBgGCuEYHNhpdenayLrq0iTRoZfPkfAydGASxJRveiYyRG1EimTwAhXOfu4LJbztaqVQhz7T5rXBLrnB6vTMuUW3KZHjyEstqsBy0P3Z7HEnNB7EJ8j/d9Bc9OskxUmUju0lZu+lVvRBj4VOArPV/jhPk/4WtpUMi0EkTJvUSSJUj11AR6nPwDXpha7amR6jkPdu4NQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vk+Xz2ZDOYww1LHn7f8Zc2Tquf5nZ/LkVCi1pMSo9QA=; b=hM5oQQH5UwWbk8N567S65tAYul78WpJzHbQl65PdN3oaR/9aulLU12wOejsYBnZLGZb1NKOrlJ7Cz3GpAEbiBplZFBPQ69QA1oRQB/rWmt7Qa3FRakXpCrAeMhA9XZ7D3vsmjRZUyplhQ9aM68d/dp5QRPoR4WSd62sGlgf3nXA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c170fa962041cf3a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l3JTltLb9N0zSlCQ8UrlC6L1ljMJJ0lZ9RCdKv7idBRaUZO/ZfSkEPD6XMQ2dWFZXz6Sa2hvOAzksOZrd+5z6omzhcg2HMpLCK73Bxhca+mI3JFQsAt79v0NvCTsrLhGHASrOp9f3N39FetKC4O6j7VM+pxryzYywoV69KrBSRPAPsdHdx9N8B9gB06lG7h9ZUwfcyhZSynjjvoo7Ffec3wXxJZaTIqw+eSXmlJxBOhRe++eq2VoBrihrtblsJ8FZBXNJfnoq96lzwJyNCjJF26MWl/s3R7AbpOn42lH1iGXnRFzzFw4cbnIzrhVPfhiitypTx87bABCnB1ELafhLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vk+Xz2ZDOYww1LHn7f8Zc2Tquf5nZ/LkVCi1pMSo9QA=; b=MmF84hpXWL1M1qVy+0lGNhkJt35xF+acP+IU1wTMdBmaqN2cfbnlGcMV+EUCzAw/URyeSFmAb/EfEaM9/uMC8Fea740zEAWEhMR3r5z8uqoymbaTcPLK5GEa+0YPO+rWcbAb+T7bHOOuGSZw0azBHvlneyyZ2p/DkXYcNfPXGKP91jRmKwYRHJtR3qw2o0QWR/8rUFJAA+Xj6PgDWJWo0wiyijs4WtmRT7v0kGgmhppWCRJi7Kk4JzA3TnVn2lpWjYcGHcDudTAbqNkvdKWeYVahYWYLUR2LNElWR/6p9JvaUs4nxijYz3CxOj5b66AtOyQX/U1kEvQJmPeHahtuAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vk+Xz2ZDOYww1LHn7f8Zc2Tquf5nZ/LkVCi1pMSo9QA=; b=hM5oQQH5UwWbk8N567S65tAYul78WpJzHbQl65PdN3oaR/9aulLU12wOejsYBnZLGZb1NKOrlJ7Cz3GpAEbiBplZFBPQ69QA1oRQB/rWmt7Qa3FRakXpCrAeMhA9XZ7D3vsmjRZUyplhQ9aM68d/dp5QRPoR4WSd62sGlgf3nXA= From: Bertrand Marquis To: Jan Beulich CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Topic: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Index: AQHYb89Ql1y5oYxB8EW1dQIiqL2u/a0vNXYAgAEjhQCAAJGbAIAAAxAA Date: Thu, 26 May 2022 09:54:49 +0000 Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> In-Reply-To: <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5b36d0be-6193-4988-0821-08da3efdcb86 x-ms-traffictypediagnostic: AM6PR08MB3271:EE_|AM5EUR03FT056:EE_|VI1PR08MB3583:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bfRbJyyQCHO94fjw4JxwWyodWkTcpNKRU6SLjIHIghvYx0zZfJsj+NrHDlUomzQK0kbC6gUa3AnL8UUOsxBQZNs0qLsRkQUYqY7e35GoNAlKTd+W9YVQMe3F0D/onnveziHPzb7yF1cEkskDLLww2DUTQOy5pxr1ffdWRNpVKQvOsEP2MJj6OrVu6q5iDcsje5TEJShQ5YVtUiwAEyyqzLO9uSB1LqTd+17S6hx/WFZg7ng/vxHDjLe8UCgGeQCpaGpQv2hMYRs3k4/Ef03wTWCWwYxxbFpPhUDYc6dvZRUaJ1nSC6p0RbfAVBqdOpZWwbgxrA3RMGMEUmle1Keo8zAHz99HNRQWe42lucgI21w3vYDmZBrbFQftNaTYtXn3wbboLiMa9NSpF8nOfExQtllFqXMIshiUmCr7Ho2qvxf+BWDwsQAJZcktuBmdHA12/schyN+UMOin0ywL4AVaxTB5SyC2VtobE3rKUSX8sdt+1UHbXi5wgsx6s39FGuiHXQQ1WLtY0VOc3dvb3XcmWAVG7dUnZ2BESmZoVWmbkHo68LI8jBDQCd97cMM5LJPii/xpLKIo+LIAXKbQXQzGo2LD1XD4pd6Bh0s3Ak7c7B8B/u8sn6zL9W8ZqyPyNNiYjYMTdbB0WyzCg3jUugu8CpDUJ4iLv7r06u9zXkGgBJ9hmayEryXDIadkYfc8IbA/lCd00h4RUQIStNTnbpw6EG9mZVNa5R6Soey7f2yo8s5gsZWQu3/fP/NdvasPcWVsM/xxshX3U+HJE6TFScFQoSb3d44Dehf4050pHG0lvmhF6LNCU3CpdR1PwwlF8Rt9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(6486002)(316002)(86362001)(508600001)(91956017)(76116006)(66946007)(54906003)(64756008)(66446008)(66476007)(66556008)(6916009)(38070700005)(71200400001)(122000001)(8676002)(186003)(966005)(6512007)(38100700002)(53546011)(26005)(6506007)(2616005)(2906002)(33656002)(8936002)(5660300002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <03650940D99F4F43A3FC178EB2ED9056@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3271 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 307d03bd-5a42-4207-cbea-08da3efdc5b9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SuIzghKQkbCwJ4snOOejSbK5KN63Z5Kax2YWot7HZrCS2zsd8NgeoY7c5hVCSf1geQR2zIDiTKt94bs7xxGi6jpNk7Rmq1RZ75mMlDVtB3SmfLbG0xUKfYUvkPAPzXBjTe+vK+hBe5jr/wNUXiXWZyz9zjtqNsj9w6hUYSAvmGPtVUQXKj4FMGdOgQbE42aoE16cylTt1HFggUPNPAOcEK0RBoh9uRcRsavYf5/D/5DorTsCq9p/u/vx4GJSTTOtWsn5xFDP9i4C+nnB5c7Yia7edIE/2FTYG87FZdv4w7inU0D/LC8DBT4ITzCPXbWbt6YrrzVJpMPa6NjeAPpGcNBpsfy04O9nqGZCAURBOygY0d8KjvzkQhbZxrkSCYOjVbdVgf6ypye+B9J7pVA4aNnuIkXWVfWw7lcYiIAckV1W1qPX6zXcAHSoQySuMDs9q926wZqOW8k6t6AmBVU3TdcUTpW9+szwXck/CvKiHVZCSMKXyKeUo7pCeAya+CxwRbtbrgNXEMd9lIOy5KdVPgv06reqmM+7iECLavErB4CYGGulkkY2fvQl153dKoYmZgdB547v5JRTOuZmH4pzbMK6v1rs3uZ9rjdzBiK7oZnK2zgsHUE/xZjIUxv6jkoarsu3vpTHZqSSK52XJ9pWbjfjeKN+X4pQAC3F01ZIYOKlU52t4kcc/H9PHv6ldpg32gQhCXfHFidMKCfaQ28rm8/i7AhoZxSkqhLl5Gb+K7AF3fC03ZB91a5F68Wn7JQPE8uSO4QScJ70RR95AdFjHw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(86362001)(5660300002)(40460700003)(81166007)(8936002)(356005)(53546011)(6506007)(8676002)(2616005)(316002)(54906003)(82310400005)(6512007)(186003)(6486002)(966005)(508600001)(36860700001)(70586007)(70206006)(336012)(4326008)(47076005)(6862004)(36756003)(33656002)(2906002)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 09:54:58.7928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b36d0be-6193-4988-0821-08da3efdcb86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3583 SGkgSmFuLA0KDQo+IE9uIDI2IE1heSAyMDIyLCBhdCAxMDo0MywgSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDI2LjA1LjIwMjIgMDM6MDIsIFN0ZWZhbm8g U3RhYmVsbGluaSB3cm90ZToNCj4+IE9uIFdlZCwgMjUgTWF5IDIwMjIsIEp1bGllbiBHcmFsbCB3 cm90ZToNCj4+PiBPbiAyNS8wNS8yMDIyIDAxOjM1LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6 DQo+Pj4+ICstIFJ1bGU6IERpciA0LjcNCj4+Pj4gKyAtIFNldmVyaXR5OiBSZXF1aXJlZA0KPj4+ PiArIC0gU3VtbWFyeTogSWYgYSBmdW5jdGlvbiByZXR1cm5zIGVycm9yIGluZm9ybWF0aW9uIHRo ZW4gdGhhdCBlcnJvcg0KPj4+PiBpbmZvcm1hdGlvbiBzaGFsbCBiZSB0ZXN0ZWQNCj4+Pj4gKyAt IExpbms6DQo+Pj4+IGh0dHBzOi8vZ2l0bGFiLmNvbS9NSVNSQS9NSVNSQS1DL01JU1JBLUMtMjAx Mi9FeGFtcGxlLVN1aXRlLy0vYmxvYi9tYXN0ZXIvRF8wNF8wNy5jDQo+Pj4gDQo+Pj4gDQo+Pj4g Li4uIHRoaXMgb25lLiBXZSBhcmUgdXNpbmcgKHZvaWQpICsgYSBjb21tZW50IHdoZW4gdGhlIHJl dHVybiBpcyBpZ25vcmVkIG9uDQo+Pj4gcHVycG9zZS4gVGhpcyBpcyB0ZWNobmljYWxseSBub3Qt Y29tcGxpYW50IHdpdGggTUlTUkEgYnV0IHRoZSBiZXN0IHdlIGNhbiBkbw0KPj4+IGluIHNvbWUg c2l0dWF0aW9uLg0KPj4+IA0KPj4+IFdpdGggeW91ciBwcm9wb3NlZCB3b3JkaW5nLCB3ZSB3b3Vs ZCB0ZWNobmljYWxseSBoYXZlIHRvIHJlbW92ZSB0aGVtIChvciBub3QNCj4+PiBpbnRyb2R1Y2Ug bmV3IG9uZSkuIFNvIEkgdGhpbmsgd2UgbmVlZCB0byBkb2N1bWVudCB0aGF0IHdlIGFyZSBhbGxv d2luZw0KPj4+IGRldmlhdGlvbnMgc28gbG9uZyB0aGV5IGFyZSBjb21tZW50ZWQuDQo+PiANCj4+ IEFic29sdXRlbHkgeWVzLiBBbGwgb2YgdGhlc2UgcnVsZXMgY2FuIGhhdmUgZGV2aWF0aW9ucyBh cyBsb25nIGFzIHRoZXkNCj4+IG1ha2Ugc2Vuc2UgYW5kIHRoZXkgYXJlIGNvbW1lbnRlZC4gTm90 ZSB0aGF0IHdlIHN0aWxsIGhhdmUgdG8gd29yayBvdXQNCj4+IGEgZ29vZCB0YWdnaW5nIHN5c3Rl bSBzbyB0aGF0IEVDTEFJUiBhbmQgY3BwY2hlY2sgY2FuIHJlY29nbml6ZSB0aGUNCj4+IGRldmlh dGlvbnMgYXV0b21hdGljYWxseSBidXQgZm9yIG5vdyBzYXlpbmcgdGhhdCB0aGV5IG5lZWQgdG8g YmUNCj4+IGNvbW1lbnRlZCBpcyBzdWZmaWNpZW50IEkgdGhpbmsuDQo+PiANCj4+IFNvIEknbGwg YWRkIHRoZSBmb2xsb3dpbmcgb24gdG9wIG9mIHRoZSBmaWxlOg0KPj4gDQo+PiAiIiINCj4+IEl0 IGlzIHBvc3NpYmxlIHRoYXQgaW4gc3BlY2lmaWMgY2lyY3Vtc3RhbmNlcyBpdCBpcyBiZXN0IG5v dCB0byBmb2xsb3cgYQ0KPj4gcnVsZSBiZWNhdXNlIGl0IGlzIG5vdCBwb3NzaWJsZSBvciBiZWNh dXNlIHRoZSBhbHRlcm5hdGl2ZSBsZWFkcyB0bw0KPj4gYmV0dGVyIGNvZGUgcXVhbGl0eS4gVGhv c2UgY2FzZXMgYXJlIGNhbGxlZCAiZGV2aWF0aW9ucyIuIFRoZXkgYXJlDQo+PiBwZXJtaXNzaWJs ZSBhcyBsb25nIGFzIHRoZXkgYXJlIGRvY3VtZW50ZWQgd2l0aCBhbiBpbi1jb2RlIGNvbW1lbnQu DQo+PiAiIiINCj4gDQo+IEhtbSwgc28geW91IHJlYWxseSBtZWFuIGluLWNvZGUgY29tbWVudHMu IEkgZG9uJ3QgdGhpbmsgdGhpcyB3aWxsIHNjYWxlDQo+IHdlbGwgKHNlZSBlLmcuIHRoZSBEQ0Ug cmVsYXRlZCBpbnRlbmRlZCBkZXZpYXRpb24pLCBhbmQgaXQgYWxzbyBnb2VzDQo+IGFnYWluc3Qg dGhlICJubyBzcGVjaWFsIGNhc2luZyBmb3IgZXZlcnkgc3RhdGljIGFuYWx5c2lzIHRvb2wiIGNv bmNlcm4NCj4gSSBkaWQgdm9pY2Ugb24gdGhlIGNhbGwuDQoNCk9uIHRoaXMgc3ViamVjdCB0aGUg aWRlYSB3YXMgbW9yZSB0byBkZWZpbmUgYSDigJx4ZW7igJ0gd2F5IHRvIGRvY3VtZW50DQpkZXZp YXRpb25zIGluIHRoZSBjb2RlIGFuZCBkbyBpdCBpbiBhIHdheSBzbyB0aGF0IHdlIGNvdWxkIGVh c2lseSBzdWJzdGl0dXRlDQp0aGUg4oCcZmxhZ+KAnSB0byBhZGFwdCBpdCBmb3IgZWFjaCBhbmFs eXNlciB1c2luZyB0b29scyBvciBjb21tYW5kIGxpbmUgb3B0aW9ucy4NCg0KQmVydHJhbmQNCg0K PiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 26 10:10:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 10:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337531.562142 (Exim 4.92) (envelope-from ) id 1nuARe-0004UO-SU; Thu, 26 May 2022 10:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337531.562142; Thu, 26 May 2022 10:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuARe-0004UH-Pa; Thu, 26 May 2022 10:10:18 +0000 Received: by outflank-mailman (input) for mailman id 337531; Thu, 26 May 2022 10:10:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuARd-0004UB-Kh for xen-devel@lists.xenproject.org; Thu, 26 May 2022 10:10:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1b::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a3cefd3-dcdc-11ec-837f-e5687231ffcc; Thu, 26 May 2022 12:10:16 +0200 (CEST) Received: from DB6PR0202CA0027.eurprd02.prod.outlook.com (2603:10a6:4:a5::13) by AM0PR08MB4609.eurprd08.prod.outlook.com (2603:10a6:208:101::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Thu, 26 May 2022 10:10:15 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::21) by DB6PR0202CA0027.outlook.office365.com (2603:10a6:4:a5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 10:10:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 10:10:14 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Thu, 26 May 2022 10:10:14 +0000 Received: from a68071cc5754.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24D95180-D7BA-4E82-9182-3F945E1F99F6.1; Thu, 26 May 2022 10:10:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a68071cc5754.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 10:10:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB6853.eurprd08.prod.outlook.com (2603:10a6:20b:39e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 10:10:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Thu, 26 May 2022 10:10:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a3cefd3-dcdc-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d5W7e+DjeOq7gz3sM7b6MDSuIgzFZz6pwBPT675x7t/Npbf7ohZH3qE0TbFEuENudThCxXV5nL7CynDs+CfFwc4Cu4yWavwDzBVrgveHJhFKcknlMnvNOv4aTsoy8akRoDs6BFGXGtNLeAZXXWu3FwVfablgcgXDgl7UtXEMlZjZY++PJR9uJlhIWqZEKkhFG2N0mc9z8DAhuDEK9O6pzZBgJhoBsbqF5IdzDKBCoyzds0Zcn6xN/e6yF1ioHSNMGGgcgzajauhSMRjUNiVxSI+ktMd3clyOSFRBtc/x03vbVhVmBCLKYDNSVI2PTdkIYx2hNx03ks32KkD0GizDVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i8UITn91FnvY8HhDxe5rHXOeAambHx3RHnejjSQpW1c=; b=J91DtUON7yvcZyrxhtRgGQsUAmZkgLvCOtravpvOjeBiWZr7m2TrtOAMS/8g9A1rx4DZ9lTcKlwhscz5/D0OWZZzL5yKGgELlcZqRJzV7ip5nhfJ4vCZrkfKmInAWi2B3pEUmY85lOXn8vtWtXFnyRq+jAj+MoGpB1opOD7BndsTDjivaB4jgGComurKz7M9oTPDRx9FU4cd1gXIoB9NvNybvVsOO9/DyqwguzYWM5g25XzXlqF3ufuuz2EX7w0mu9xVc2C0w2OOUwHIeI+kK42rJiKg8S8GbzVSKu0kqWkKu1hizaJpihQyOoiTzDRCVca90yXkNcz89f6KHlCzWw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i8UITn91FnvY8HhDxe5rHXOeAambHx3RHnejjSQpW1c=; b=Jh4eOy/Q6ByEm/aghdPG6B/jW65YBh+hiVILNyLhzxdBkqAF9TvbDWoPaOtrrpef0Ysr30O19gVXKZtEvEGhHuW/4Po0KzN/NGPv8enrGu8R2e4yQHVwVD2Rk8GQU9qpNUYlP7tiftO4kZ0kWiiqx00GeMMmnxOUEWJCta55dM0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: de5437d9066eac02 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V6msmo87+pPxbdmNhTbhLqxvqFEnzIAwGfniQ0/f9N6sd30su9eKzH+mWCipjtyIVyAEx41nl879aNtCvsWicRvi15mBwLbfUdIcVF9GTsGPSbeLtIh5lDTn6GBKMBcFe29l5Fc00xdoqUQVCSpOy2OrsuIbu2exXQwT8zAyA8rEmaSheBWJOXEUNVDzCJh0jva/VMi/J70y5pat93qdeOxebUofnJfT+HBptlOLi8ysP71UYFbH4Q5ty9Fh1KWSUOHRRqbd8Bk0bXYd1pSbx0kU77QVVf0GnRT33ZIU4Zt4Sg+jn7PCFi9hU/OVzsuf5H3Ooz4syQkRDZiOeDybPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i8UITn91FnvY8HhDxe5rHXOeAambHx3RHnejjSQpW1c=; b=Lvej6QQ46X1tlF+YYeOknQsUuYP7ITV3JAKlGPbWwdfV+NlbQ83aH76wI6OtPMbUHI4f7u72WHnaajlXxnv+34UbsACCrAB6nVPbdzdNAjEb3IpJ4cgFLoY9OsSjBSn34SBNLwt5Z/zC/gQmsJ7iNe5QsHidAiqnDY96QRxPVFXaaAJoPnnZ3hRbprf6cxeZ350pDjlVn9n2FK0LyVlwZmn0wUW5+xRZRsYM63p9KywdPMZypjLIoz/lw8Pf3aEsgQmN+BJDOAMdJEywXBazTu4ZO6OEMxryPXruRQrNHC85SycBUr1Ke3Yx8DmxcqGIcL02dy8x7vNJu9bisCS1dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i8UITn91FnvY8HhDxe5rHXOeAambHx3RHnejjSQpW1c=; b=Jh4eOy/Q6ByEm/aghdPG6B/jW65YBh+hiVILNyLhzxdBkqAF9TvbDWoPaOtrrpef0Ysr30O19gVXKZtEvEGhHuW/4Po0KzN/NGPv8enrGu8R2e4yQHVwVD2Rk8GQU9qpNUYlP7tiftO4kZ0kWiiqx00GeMMmnxOUEWJCta55dM0= From: Bertrand Marquis To: Jan Beulich CC: Stefano Stabellini , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "julien@xen.org" , "George.Dunlap@citrix.com" , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 Thread-Topic: [PATCH 2/2] docs/misra: add Rule 5.1 Thread-Index: AQHYb89RqYcZa7uXSUe8aa9iaX1mVK0vPZ+AgAEfowCAAIxHgIAACGKA Date: Thu, 26 May 2022 10:10:05 +0000 Message-ID: References: <20220525003505.304617-2-sstabellini@kernel.org> <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> <39c930ba-f5b4-14a4-ec48-19dba9a21509@suse.com> In-Reply-To: <39c930ba-f5b4-14a4-ec48-19dba9a21509@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 594eb094-8bba-44bc-8c7e-08da3effed55 x-ms-traffictypediagnostic: AS8PR08MB6853:EE_|DBAEUR03FT018:EE_|AM0PR08MB4609:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lorGMc5B03LaDaM7b4ZZCSLwU2gdicbMCCmPxRqBBSoRts6rIGzPoCI0hxZhF+k0dTOntVOoL9Q3q0Nl7Nr0WPy9w9ju78NtOTw3cfJ8lwqycr4rTOfWu7G3K3ETU736Zi235hvHAuMLmXrGXofVdRNyUB8bTskDzTQGrxwCBUbO1C+82ibJL3kOk8RlNNR6U5R08DEkvWJcvv10TxMa2CXDghbnc8hyLwoxGt/zRKpRKOhNKh+3XjRj9lU74S6Gkx+t82hG0bf75tHBDgX1Rkz+Ejy1cgG7vEJV7Dg+zyYOm7YKsHyH4gmbt1L5usWOh8Z4KzGCXx7Iyeby/NEdr+wKoLAEMCkTZpTyQIXPqSAjAdF0Uaql90ka4kMfny7puEdE7niZU3bCC+QHJcGFFTd5TtC600PHoAZ3OM/fprRASLIpFAV+425hRjsHll4TnWtFVJV/kBfDiujAn8+Ys4K4Xn3f0qZiiymS8zHV5DrOyRbUHWlkStTZBej5SvYwIdguxoXG+6OO5tAx7mF9JGo7SfV8bAPjZ7/3US/E/ZPRUHKE3f2rceaKq6KMzu3MWYR23EheMqeyJ5eQOSXT+RVtiY+3kty2Ss5iYqr8BJdYPXKeP4um87ojB+t+y2MVffLH5W2JxICf4GMiFaS7A0yLw3ct0Dqkxx+MO1UaopcqcSi7XaT0JN2Qppvp47i9oVVakkR5FWsc2+r4jEklWoyXa+Mhsz+TW2YjML6g73HOkBgSBLtPMJxmjBPNg84O X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(2906002)(508600001)(6506007)(71200400001)(6512007)(5660300002)(33656002)(186003)(91956017)(38100700002)(83380400001)(36756003)(8936002)(54906003)(122000001)(38070700005)(26005)(316002)(86362001)(8676002)(4326008)(53546011)(66446008)(66476007)(64756008)(76116006)(6916009)(2616005)(66556008)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6853 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8abb25f-5049-4ef4-8f2c-08da3effe801 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kg7MsJ5b2gYgwxXmFfZgfxEcB+Xd6Lx7BtGDTaXgV92XUpIlXXRUhPoOpx9VS+up3VY81ttrMv8tzDZfPGYqA/FWe34WRhuOJkPjeORLiqG33xhiyy42U0jvXhQ7HSp8vC3YDphJ0LFL4iJEn965o1xqyb90QcTnhUfl8W7WclGb9NPREiW3d5uWQHB87O8Yv80CT9Z4fOSl22Dq6fAR2G5RZ9sR78hFggPgGwwJn6aSmgY+QOO8pPTi+wsXAmgKhL44ib2noDoSyv5daIsMNE3wGt5IsUD/FRtb5VH65MEfwYJb1KqFA4UZ3hi5B+UcLaSWNllW9lOBYR4J0lYx/Hc62FmYY+PsZJm3AXW4EdkFDpbiMq4Nl2EfTmLEnJJyqcgTDwTA8kuFtRJb3REzsdGvBzXs8oB18GTySzFuZHVo4yYNAqIVY3CssRHb/3J1VtY+0RxcnZ12Y+uMBdDRmIeCm6iri33CU5kNFcq5QjgzbkY+R8phQtg8aszp3dHxfnoDazc+I+Oh9Y8LXFHxL2XFHq+2MFFckeuKF1ajt/FONo2KLYeuqcdvGMIp3YDtjxolJYW6tJ/pnhzzalm29E1m5uz/IXIV3QUulzeEW2cKiKjkBmQJvz4YEZU9wGL+JVvkoB8rz0Mqjhn+GqNdS9Vnc8SHsYlGfoewAUGY14PmBZp/nXfWHF98XfDIHE0E X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(70586007)(81166007)(53546011)(6862004)(2906002)(4326008)(6486002)(6506007)(8676002)(8936002)(33656002)(508600001)(356005)(36860700001)(5660300002)(316002)(86362001)(83380400001)(2616005)(54906003)(47076005)(36756003)(336012)(82310400005)(186003)(40460700003)(6512007)(26005)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 10:10:14.5735 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 594eb094-8bba-44bc-8c7e-08da3effed55 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4609 DQoNCj4gT24gMjYgTWF5IDIwMjIsIGF0IDEwOjQwLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjYuMDUuMjAyMiAwMzoxOCwgU3RlZmFubyBTdGFiZWxs aW5pIHdyb3RlOg0KPj4gT24gV2VkLCAyNSBNYXkgMjAyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ Pj4gT24gMjUuMDUuMjAyMiAwMjozNSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+PiBG cm9tOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPg0K Pj4+PiANCj4+Pj4gQWRkIFJ1bGUgNS4xLCB3aXRoIHRoZSBhZGRpdGlvbmFsIG5vdGUgdGhhdCB0 aGUgY2hhcmFjdGVyIGxpbWl0IGZvciBYZW4NCj4+Pj4gaXMgNjMgY2hhcmFjdGVycy4NCj4+Pj4g DQo+Pj4+IFRoZSBtYXggbGVuZ3RoIGlkZW50aWZpZXJzIGZvdW5kIGJ5IEVDTEFJUiBhcmU6DQo+ Pj4+IA0KPj4+PiBfX21pdGlnYXRlX3NwZWN0cmVfYmhiX2NsZWFyX2luc25fc3RhcnQNCj4+Pj4g ZG9tYWluX3BhdXNlX2J5X3N5c3RlbWNvbnRyb2xsZXJfbm9zeW5jDQo+Pj4+IA0KPj4+PiBCb3Ro IG9mIHRoZW0gYXJlIDQwIGNoYXJhY3RlcnMgbG9uZy4gQSBsaW1pdCBvZiA2MyBjaGFyYWN0ZXJz IHdvcmsgZm9yDQo+Pj4+IHRoZSBleGlzdGluZyBjb2RlLg0KPj4+IA0KPj4+IEkgaGF2ZSB0byBh ZG1pdCB0aGF0IGl0IGhhc24ndCBiZWNvbWUgY2xlYXIgdG8gbWUgd2h5IHdlIHdhbnQgdG8NCj4+ PiBwZXJtaXQgKGlmIG5vdCB0byBzYXkgZW5jb3VyYWdlKSB0aGUgdXNlIG9mIHN1Y2ggbG9uZyBp ZGVudGlmaWVycy4NCj4+PiBJZiA0MCBpcyB0aGUgbG9uZ2VzdCB3ZSd2ZSBnb3QsIHdoeSBub3Qg bGltaXQgaXQgdG8gNDAgZm9yIG5vdw0KPj4+IHdpdGggYSBnb2FsIG9mIGZ1cnRoZXIgcmVkdWNp bmc/IEEgNDAtY2hhciBzeW1ib2wgcGx1cyBzb21lDQo+Pj4gaW5kZW50YXRpb24gd2lsbCBhbHJl YWR5IHBvc2UgcHJvYmxlbXMgd2l0aCA4MC1jaGFyIGxpbmUgbGVuZ3RoLg0KPj4gDQo+PiBXZSBj YW4gZ28gbG93ZXIgdGhhbiA2MyBpZiB3ZSB3YW50IHRvLiBJIGNob3NlIHRoZSBjbG9zZXN0IHBv d2VyLW9mLXR3bw0KPj4gbGVuZ3RoIC0xIGZvciB0aGUgTlVMIHRlcm1pbmF0b3IuIEJ1dCBpdCBk b2Vzbid0IGhhdmUgdG8gYmUgYQ0KPj4gcG93ZXItb2YtdHdvLiBTbyB3ZSBjb3VsZCBnbyB3aXRo ICI0MSIgaWYgd2Ugd2FudCB0by4NCj4+IA0KPj4gQW55b25lIGluIGZhdm9yIG9mIHRoYXQ/IEkg YW0gaGFwcHkgd2l0aCBhbnkgbnVtYmVyIGJldHdlZW4gNDEgYW5kIDYzLg0KPiANCj4gV2h5IDQx LCBub3QgNDA/IDQxIHNlZW1zIHlldCBtb3JlIGFyYml0cmFyeSB0byBtZSB0aGFuIGUuZy4gNDAu DQo+IA0KPj4+IE90b2gsIGFzIHNhaWQgb24gdGhlIGNhbGwsIEkgdGhpbmsgdGhlIHB1YmxpYyBo ZWFkZXJzIHdhbnQNCj4+PiBtZW50aW9uaW5nIGV4cGxpY2l0bHkgaGVyZSBpbiBzb21lIHdheS4g UGFydCBvZiB0aGVtIChtb3N0IG9yIGFsbA0KPj4+IG9mIHdoYXQncyB1bmRlciBpby8pIGFyZW4n dCB1c2VkIHdoZW4gYnVpbGRpbmcgWGVuLCBzbyB3b24ndCBiZQ0KPj4+IHNlZW4gYnkgRWNsYWly IChhaXVpKS4gWWV0IHRoZXkgYXJlIGEgZm9ybWFsIHBhcnQgb2YgdGhlIGNvZGUNCj4+PiBiYXNl LCBhbmQgZS5nLiByaW5nLmggaGFzIHNvbWUgcHJldHR5IGxvbmcgbmFtZXMgKGFsYmVpdCBzdGls bA0KPj4+IGJlbG93IDQwIGNoYXJzIGFzIGl0IGxvb2tzKS4gU28gb25jZSB3ZSdyZSBhYmxlIHRv IGdvIGRvd24gdG8gZS5nLg0KPj4+IDMyIGZvciB0aGUgYnVsayBvZiB0aGUgY29kZSBiYXNlLCBw dWJsaWMgaGVhZGVycyBzaG91bGQgaW1vIHN0aWxsDQo+Pj4gYmUgZXhwbGljaXRseSBhbGxvd2Vk IHRvIHVzZSBsb25nZXIgaWRlbnRpZmllcnMuDQo+PiANCj4+IEFjdHVhbGx5IEkgdGhvdWdodCBh Ym91dCB3cml0aW5nIHNvbWV0aGluZyBmb3IgdGhlIHB1YmxpYyBoZWFkZXIgYnV0IEkNCj4+IHdh c24ndCBzdXJlIHdoYXQgdG8gd3JpdGUuIFdoYXQgYWJvdXQ6DQo+PiANCj4+IC0gTm90ZTogdGhl IFhlbiBjaGFyYWN0ZXJzIGxpbWl0IGZvciBpZGVudGlmaWVycyBpcyA0MS4gUHVibGljIGhlYWRl cnMNCj4+ICh4ZW4vaW5jbHVkZS9wdWJsaWMvKSBhcmUgYWxsb3dlZCB0byByZXRhaW4gbG9uZ2Vy IGlkZW50aWZpZXJzIGZvcg0KPj4gYmFja3dhcmQgY29tcGF0aWJpbGl0eS4NCj4gDQo+IEZpbmUg d2l0aCBtZSwgZXhjZXB0IEkgd29uZGVyIGluIGhvdyBmYXIgZ29pbmcgZm9yd2FyZCB3ZSBhY3R1 YWxseQ0KPiBuZWVkIHRvIHBsYXkgYnkgdGhhdCBsaW1pdCB0aGVyZS4gUHJvcGVyIG5hbWUtc3Bh Y2luZyBpcyBwYXJ0aWN1bGFybHkNCj4gaW1wb3J0YW50IGluIHRoZSBwdWJsaWMgaGVhZGVycywg c28gbWF5IHdhcnJhbnQgYSBoaWdoZXIgbGltaXQgZm9yDQo+IGNlcnRhaW4gKHVudXN1YWw/KSBj aXJjdW1zdGFuY2VzLg0KDQpJIHRoaW5rIHdlIGNhbiBoYXZlIGEg4oCcZ2xvYmFs4oCdIGRldmlh dGlvbiBmb3IgcHVibGljIGhlYWRlcnMgd2l0aCBhbiBoaWdoZXINCmxpbWl0IGJ1dCB0aGVyZSBz aG91bGQgc3RpbGwgYmUgYSBsaW1pdC4NCg0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 26 10:15:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 10:15:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337540.562154 (Exim 4.92) (envelope-from ) id 1nuAWM-0005Cf-M1; Thu, 26 May 2022 10:15:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337540.562154; Thu, 26 May 2022 10:15:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuAWM-0005CY-Hf; Thu, 26 May 2022 10:15:10 +0000 Received: by outflank-mailman (input) for mailman id 337540; Thu, 26 May 2022 10:15:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuAWL-0005CS-HQ for xen-devel@lists.xenproject.org; Thu, 26 May 2022 10:15:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b82b6b98-dcdc-11ec-837f-e5687231ffcc; Thu, 26 May 2022 12:15:08 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-47xxy-5vOJeYPLkgM8HvTg-1; Thu, 26 May 2022 12:15:06 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6291.eurprd04.prod.outlook.com (2603:10a6:208:13c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 10:15:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 10:15:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b82b6b98-dcdc-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653560108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZBYc84n2HpSCJ8I/f0P9KwHpsJrFQtDFaetXxsVnro=; b=Hvn3jKn1+noye9AcL2LpL/TDel6UkmaeQERBiBlJaAgSzwCvVjIG9Tgc3HUPvtvGRR8tAb LvHPWgXU+6xI9Ss60utNsIM35YUC7pUQNJ3D433xXBJMNzVwn6I9PCHf/IcNbq7rn+SmLP 6uEPFfvvrAdJGqkbkkQPuHoc3QjoZlE= X-MC-Unique: 47xxy-5vOJeYPLkgM8HvTg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+dgnRmmVlZRserBWSodveC/SNVgyMDPscp0VplqRZNkRRu1aaa0GYx+nmY1RS+PGX0eBGHJE0fLjoTKuQEOimZ9zqFtsZoG58Lzdg7YEK3lbSw8EQCcRFfJkhZGdX5C2s4GwH5LnZjXkRJUpQGUBuZv24UtwEDilC6wErgbETmKIpgVIaNbXKVgZ4g0Xp7SnTW0+Gw4nZFVbOLyzu3B0IxDOs7KZ0B+6s4Ljfwwj8QYijlIaeidnnj31yRbaBQXWtIZyissq65CJEOJ34ph24VJMBFeJwKKGdwrXh5+FUx5g/qoNDp5cawFk7/yIqVzbFHW2QCQ7vt+66KFPIVlSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EtY+Ge1WLqy+YFusYrJZ2rj6wWLQgqpFp9BYYuuWpgM=; b=KY2hoGk0CB51cx+BqV9Np9QIHaq28kXoKTD5dmf+EaKzjAjCJNppRkRdVkUR5DEBopFYgMFu77V7+AD3/vmHLdW1rEOL+sM8ObPe20jKSSXZ1rGzH62S1ZHbMZMIjhyA8Hax3x/jGeIarbKGKDGLjSlxD2BEkgw/wRtw/2nYxJ3oQfZ9AmFytfJHonIRDWnFNTCbl2GtEDm8775tibvDTd2/J5S9fHrszVnQpRMz8+idhDwy/Q/VE3xZFmFjhKg1mfbQtPNbgovD/oLq/T8FnXMLIWsnE59ed0nW9kyFXHPq3yebOzbpy+x1KakIlWrOmPJpHYdZuoNfAFYwxZIY8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 26 May 2022 12:15:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Bertrand Marquis CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0105.eurprd04.prod.outlook.com (2603:10a6:20b:31e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1786ebf1-5e2d-41ee-48c4-08da3f009a2b X-MS-TrafficTypeDiagnostic: AM0PR04MB6291:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qwIVw8oVY2SJgjkILa4XlIUu6PcKN1sMeq/oW59/aQtqzyZI68UAdurc6OtTIPCpQZBl+Pghe0JxI0vo8eEBbgA+LrW9+TJAh0kKV5+sHvf9+NLDz7tgh3oycsNt6HkSMYdAzL+SkZ+qLjwrczLoBwOfNo6xdNulxQTJI2HSsPs4QvxCNSM4TA9TPGKe6vy2NGGGg02i00jl3ejXcXMKMx47ijPhrmJKHsvK+TB9En+NCPvGEIO1uCKzhLLA5xCjKzXb9ZHdZNp/s9XC3H5ntjIti6Wzh/rMMnab3qb370OFmwXMNFM4LSG6woVr911OhBIsig8maEggbHfIXIFRDIKeRQSVUXtRRKONOIZd0p7oNjfsDkzdV47lCCmPOPgIg3g1abD7Krzn7uHEyQOGMVyApZkMR/HIz7+NfTd0FkwMqC+krRYkM/9KhOT+WN4xb+ssc2viwiOFwgKAiXLI7oYVWMp9hfqFuw7v20b02CvwXLJ/qoGkiqyu8Pcn5WRrDpUAOsLCyG2zFuDkrfAJJiYN6ET13WBRgDOMK7wAjLkmrAnXrW4R9ExzrHx59g7riGx2Co4onnu5RgON3aZZrIHMh7WLAt7ywhIKYOY3oeas+O7b7Bbj7z5mOu7HRhW1No2ODARBU5M+3MpqeoqcQqY5xjPwylUJ6XHm6kVtdhqmNuUuT/34Jk8Rm2Lbi1fSuve830VMYQcMmHyhv1yvqY7OyZx0GrNSm6VZ+YkFcNEgDDjNKWC6jU/MMdkX14rS+MaDw3oiRxdL3t1iDq3kdhdGWFUpar9xw3E1XBfE5xqOuI5pvNAiFQSdTH7lt+rE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(316002)(6486002)(6506007)(6512007)(966005)(54906003)(6916009)(186003)(31696002)(2616005)(86362001)(8936002)(2906002)(36756003)(508600001)(38100700002)(5660300002)(66946007)(8676002)(66476007)(66556008)(4326008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BRbsMzH6nbYoyDBVCX7744cV9rfMkm4pAgDQnuYu63GRnMxbqXcbzGU39f/X?= =?us-ascii?Q?KDFqFAZ5zD42ViMUKJucbmD9rt8dCVWtPXMUXBm1J36PfsBUFwfMUcSuxc5F?= =?us-ascii?Q?ieg0f+5kTdWq2RUsynv8CY4CgLWw83BGpDwmMP/TqNOySE0kvaxsvxg7Q+o9?= =?us-ascii?Q?eNjGf6Zx427ic8Mi1qrCz1SZd7tMFpBboLsWLFYsv7ZBA+8x/MZeNWAhwFjA?= =?us-ascii?Q?Iq64qPn9gISSPC8oUI+zElv/elmOhg8jkeNeDLpvThO8Qo2duhvW30/SQ7d+?= =?us-ascii?Q?3dtq+ccaQnFdQH9jKwYWS71BlyN1yyVk8P/7xUPm5VmP4x4nohCgdMnqfkUq?= =?us-ascii?Q?rB3PrcBLvIMj0Ptj708cXY5o17GVII9iJ2vJ675KSZbQ4L+0cw9/ZEB4FmPW?= =?us-ascii?Q?2my6AkJ/27lkW7j3zPRYGRiB7/ZrHTcy1zzPsXoNoiouQ7hcOZNj6Cfg1bNE?= =?us-ascii?Q?4BZggpDvT06eS8pmNLeEj4XikQVeTfMdCTZVk/dgX31NqU7lEoEOWotH3wJh?= =?us-ascii?Q?oZQBfV7DYvlau08FLKgiSPO/z9ayixQX0a6Nzyow5C2vhtx1qlPiN6U4gwB2?= =?us-ascii?Q?DqF5S0wWyc+mygDEh2aLuQ5sYvsJrRDeI7kGQs0GwvF4A98AXfANNmc0qgJz?= =?us-ascii?Q?pgHYrBAQIBP3IXcECJU9ZUTm9+olBazOnTPuud+oJg+O3vf7X3F5saaFgNBh?= =?us-ascii?Q?CBcRFqOsI802fYZQ/6+tYf9FQgJj1SMY1BTNEMhGVL49vyL4/aHcTBRMFz6s?= =?us-ascii?Q?gfmbfh+KyuMUSaZ+0d/ju3VTwy1ae68VjWvxSV3LB67oGxHxDMNmPLFbXe7x?= =?us-ascii?Q?dtszIiqW/gJKl7AdFJ6QGFlIY6ibsLcxwbzmc+QvJqHFjY1bZo7UzRgcosX5?= =?us-ascii?Q?PFKPxTc6pTsOq6yM3M1U61zFRuWKaWyRn7LdYh+/dBVo7KSBwq8YALpOO5QT?= =?us-ascii?Q?daefQT+vWDtiPiEl2vDrogESitsKkeAmdIiQsYW6J5L2bMjA54VoAZi6bigl?= =?us-ascii?Q?sdx0URxr2NIKuwQusHZQtnvl4soB4JIH6kUcfNkPgm5WtTEBgrTVRJj5uw+p?= =?us-ascii?Q?DzijjA+k66uw34oTrSf3ZEZWTPxtvbQhjGxWxedP6Qqj0BR/Nxadj8Hrkycz?= =?us-ascii?Q?GcyF75S3796P1RSHpoxTyEjGvk+z5atZE3ChElLDIKrrH0ppytBgLBfyv8Ji?= =?us-ascii?Q?/M0qtEzMpvfHxSQeV74fJBQ8MSTQ0F5vsveiqcWUD3lmlFkX/0Jkyt8XK44M?= =?us-ascii?Q?OazgkFTbTNBlEmQI5Bn1rkp9xgLKBDZAEZKKnTJqZGff0Du6d6FXluvgaHcD?= =?us-ascii?Q?tm1XXQgRI/9m3Drkq/BrdRzQ/pQK1xMQNOTYZYIEF4yEtTmf27TbVIM+Pq18?= =?us-ascii?Q?KUDTubkiAw7Q5nz1kOAuySGuoC1OMEh6j1O3CD/dSqzDP90bsS1vWpEIUD8L?= =?us-ascii?Q?+Ipu/W31BzkZztLFpkeRr/EQSz77UYB1kRNQSHhJunH+Jgp9RLtcEyuRqupp?= =?us-ascii?Q?VXZuJNuf0o73it8/MP9qp1bTIlmvXaHDld42QNDS03QbUMnwI0515bOtJomF?= =?us-ascii?Q?4B7MgJK4pH4moyFK9W8bmDbmPiM5uqWK8nlRSsk24DPLTXfOXXTDzEDogamc?= =?us-ascii?Q?EEu9uayCj8gDmvIPB4wB0N1JHZFl+gPqxA2O91/V7wzZ+ydtvYIpHGTV5MQD?= =?us-ascii?Q?rxQlFu0Vo3u7qVwopsqc4/b0FuPT4ZMv1q2sd4md6AcgqLNQ92pUSFAn5r31?= =?us-ascii?Q?lsS2mys7THKFIC7E7qNkjNG6RVpj9gtgBSWyOaYHq0/Ud6gxtbmMol7MEs4K?= X-MS-Exchange-AntiSpam-MessageData-1: SUXNIUQQLLwL3w== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1786ebf1-5e2d-41ee-48c4-08da3f009a2b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 10:15:04.6674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mJbIZ09Qj6sdaRMb00IUo6nbwEk2uTqGatAs+fqNVNL+xqGOBlp0o3boSdMhX2nOpfl2zqXX8l4faPz8E6e3Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6291 On 26.05.2022 11:54, Bertrand Marquis wrote: > Hi Jan, >=20 >> On 26 May 2022, at 10:43, Jan Beulich wrote: >> >> On 26.05.2022 03:02, Stefano Stabellini wrote: >>> On Wed, 25 May 2022, Julien Grall wrote: >>>> On 25/05/2022 01:35, Stefano Stabellini wrote: >>>>> +- Rule: Dir 4.7 >>>>> + - Severity: Required >>>>> + - Summary: If a function returns error information then that error >>>>> information shall be tested >>>>> + - Link: >>>>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/ma= ster/D_04_07.c >>>> >>>> >>>> ... this one. We are using (void) + a comment when the return is ignor= ed on >>>> purpose. This is technically not-compliant with MISRA but the best we = can do >>>> in some situation. >>>> >>>> With your proposed wording, we would technically have to remove them (= or not >>>> introduce new one). So I think we need to document that we are allowin= g >>>> deviations so long they are commented. >>> >>> Absolutely yes. All of these rules can have deviations as long as they >>> make sense and they are commented. Note that we still have to work out >>> a good tagging system so that ECLAIR and cppcheck can recognize the >>> deviations automatically but for now saying that they need to be >>> commented is sufficient I think. >>> >>> So I'll add the following on top of the file: >>> >>> """ >>> It is possible that in specific circumstances it is best not to follow = a >>> rule because it is not possible or because the alternative leads to >>> better code quality. Those cases are called "deviations". They are >>> permissible as long as they are documented with an in-code comment. >>> """ >> >> Hmm, so you really mean in-code comments. I don't think this will scale >> well (see e.g. the DCE related intended deviation), and it also goes >> against the "no special casing for every static analysis tool" concern >> I did voice on the call. >=20 > On this subject the idea was more to define a =E2=80=9Cxen=E2=80=9D way t= o document > deviations in the code and do it in a way so that we could easily substit= ute > the =E2=80=9Cflag=E2=80=9D to adapt it for each analyser using tools or c= ommand line options. I think the basic scheme of something like this would want laying out before doc changes like the one here actually go in, so that it's clear what the action is if a new deviation needs adding for whatever reason (and also allowing interested people to start contributing patches to add respective annotations). Jan From xen-devel-bounces@lists.xenproject.org Thu May 26 10:22:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 10:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337445.562165 (Exim 4.92) (envelope-from ) id 1nuAdJ-0006c1-F2; Thu, 26 May 2022 10:22:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337445.562165; Thu, 26 May 2022 10:22:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuAdJ-0006bu-AU; Thu, 26 May 2022 10:22:21 +0000 Received: by outflank-mailman (input) for mailman id 337445; Thu, 26 May 2022 03:45:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nu4R1-0005fa-E7 for xen-devel@lists.xenproject.org; Thu, 26 May 2022 03:45:15 +0000 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3eca1fc0-dca6-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 05:45:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q2Ah6I003208; Wed, 25 May 2022 20:44:57 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g9jap3ssk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 20:44:57 -0700 Received: from DM6PR18MB3193.namprd18.prod.outlook.com (2603:10b6:5:1c4::10) by CY4PR18MB1174.namprd18.prod.outlook.com (2603:10b6:903:112::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 03:44:55 +0000 Received: from DM6PR18MB3193.namprd18.prod.outlook.com ([fe80::7411:dbb2:1f0e:9aa3]) by DM6PR18MB3193.namprd18.prod.outlook.com ([fe80::7411:dbb2:1f0e:9aa3%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 03:44:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3eca1fc0-dca6-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uy4kEPGyz+Z3UrherOABT6wROvGty6tC+ouubyTSvaPSopyAngNs1ixZ7WEOJZ6ld8Z1CVm+SMfsDhyyv0DH9JeFSuBxMUxCOwrjk9imU6K8qHywcEqfOiBZCTgZD1/cVsRBTmJeN9RDNmwAFKSG1C1SvHcqjdUBYqlbTCRmC+LTEoBwbMLtre/YgcbpPUvOwks2+RnCn0h9DpJ81ed30v8lO4illR4t1EIAYjMdCjml4GpABMN5UoWk4Eh6k6RRMRzJMhAk4JVWF/Zv3cDcIelb7IUzHwLqFvo7Gdqq4Ke4f/0u8dLku4gobxrFkIDi4nsqYmP5I3n5FStrwP2jdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=puJc2WkDHXx0g8CNdp9f2Rp58BxwGQ4zGWdF61McxOg=; b=SGVnVOx0ekj/0fPHK+jSSwUC3MWy/OZeNCugdh3laBC+SAOrLQV1GsYqY/3WYqa0oClTeFA51HXA5QXxOHtd7FCdwM4cvQpCcm1NeW9QBlR5Vn2SO5gZKst7jyU7h6XkRaSE6kMQvFwgrtMAZecYo9EQDLNzOvzof1Fw8Rs2KHsIz8rMDUlXKOFpz/I6nPCuRwN2ieRz3rC+gV+WUDLq1zE/u1Bq7ZVlL6zIULbNf8in1M0f27qqrzonfWZ58NOHGCjsUu5hKp+DI3rSbCB/UA72+Uv728AUDQqjJZJSl/AkT92m5L67tDLVK4F4z8VGy6Vu1BKVssbKMW2gG+O1DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puJc2WkDHXx0g8CNdp9f2Rp58BxwGQ4zGWdF61McxOg=; b=S9ZzAXFAKFPO1vylj0J9Xf02V4PVZErTz78d1X0bNFcV3DeLdtwD6zQsddmqfbNBmb7kINN79asFb+hYno9ovsbYojffuy9ypFrgDybibHdxDc51co7vkndt0FBdjgp8xu3eyLf5KKJLBBx+E//PQ6MnIpQ1Yc2mj7/zYrhda0s= From: Naresh Bhat To: Stefano Stabellini , "jbeulich@suse.com" , "andrew.cooper3@citrix.com" , "julien@xen.org" , "Bertrand.Marquis@arm.com" , "roger.pau@citrix.com" CC: "george.dunlap@citrix.com" , "xen-devel@lists.xenproject.org" , "Artem_Mygaiev@epam.com" Subject: Re: [EXT] Xen MISRA C meeting Thread-Topic: [EXT] Xen MISRA C meeting Thread-Index: AQHYWRY+8umpp9wdok+1YiKJDVeK4q0wsn2E Date: Thu, 26 May 2022 03:44:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: f863fcf5-d396-ccbd-d08f-c84ebc140f1b x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 742ea29d-cd1b-4ec6-30ae-08da3eca194b x-ms-traffictypediagnostic: CY4PR18MB1174:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OZgrqA7608nxC0sgEgbMetP0ZMfy+8xL5Z6LDcLeNXdsPICvVtqGE+BQOWKAxlY/rSa0xak6oZ+mvAl2BKzF1/9bBhywf4vj44qP0yj0HP5YXzmfy/qs3OagWmHnFNQVGDQZFHsDouOXtZORFR3nmbcVqNmc8RJ5iY5sfr0prR1JJUmFqn11ZCYlFGtoxo2l0vN9pjVhA9/sd42daCP4AVM+m5Scugo/HI5daoM/OwBTXRO5rTj9WpzhkT38mffywSZMKHMUf3zmgRnlBBhQTkEF1tzrFLBqa8I6GsO+plhRU/LGVOLvYSOYnnsECxF7zjTWXCsvVho/8gJGq0OcsRq0HqR9Yg/ty5M6sAs1cARP7hd8nQljwe16T94cVQWfRQz1vlFd6/xQ5HJvlWpU+YUMF5sLHzCrScm2+b+//bEOvbsv26Y9UYqPqX7idCCDSWKPJV6QDWEv+guOLLUERikjovcWDfkE214qGi8TODN9lfHcVZK5XigcjoidFTsbq7hG5kSLkgJwrX90YAAqnrw+Ybbf3Y+tLRkMsR7ybd4IohZZ6lEDgLWtVpJ9SgdPktkotPUsQr14IQdlbtXG36cuzJtzXkaBDff6zxiH4SV3U7d98euMt+rTVyyAGO73OQDF4wdxkXtBdEh82vZyNt0FqlhRQ6CX8MBVxbWTyYzOxAA32YHM3NgUhfp4Gi0e6czH53XeTeV/x7xVQRI6jVSvGuGZNYmLtxJr5lrQN1sn3QL87v5JnhIhrZjzVtt5jGi3c/7b2EzNKXnNBpxUBp6TL2lQpJmfq9F4+gfzAWA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR18MB3193.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(53546011)(54906003)(7696005)(110136005)(26005)(9686003)(76116006)(6506007)(86362001)(38100700002)(2906002)(71200400001)(38070700005)(91956017)(66476007)(8676002)(66556008)(122000001)(4326008)(66446008)(66946007)(64756008)(966005)(508600001)(5660300002)(166002)(52536014)(8936002)(33656002)(55016003)(186003)(19627405001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fSr1r1Ls0Io9ww5JSiOoJApt3P12tVBauIYpj1ZccbFb32ITfnIMuQ5cvIkX?= =?us-ascii?Q?Xz0iolKMTFj1jAEW43o9Mre94UWR+OSprj+8zWpP/eAgnhhM4uOf2Ycw9Xef?= =?us-ascii?Q?FGl3we3XbAlA7wYygPfImRDs92tgx1AOhHx5YGiZ5sc8VJtY1g2IeI9+6vk9?= =?us-ascii?Q?1NOY3LMOR7cmc5htYFTie248d1jk7u+i3hfYaip3x4NLeSu7cT9qLzpT2Hjv?= =?us-ascii?Q?7lMBHjajKGzmtrIMta/MG2hT0v9cI5Cn4RhsBMVgu5Pr+bglQrVollyYArnv?= =?us-ascii?Q?jT7OnPq8Qo1COQj84fXzLKZwgNfYPhIanPBmQ3ZmmhxIt9iIWLTplmYunmL6?= =?us-ascii?Q?xHtzK/ZJiSaKGZT8IzMBB7v1LKjLEOlj1PeEaIMO4BcjZ/TXko6+TUePXnPh?= =?us-ascii?Q?oRVbqpegI3bZ50EtGYJCmCGQMRpwmNnz+OmEeZnTOLjHBrcGI1QDb2waL2h6?= =?us-ascii?Q?2oRflI58DZg5Y08R31zdQtHEA+CrUHUw8HY3zZ08HmgK6U53pTcXd/VBwfEV?= =?us-ascii?Q?Z9LWxe3Le4Mfuw2Wt9SVqJbomn6lI6ZogB7PMP+Sbj7tBNjddim6zWxgi1Vs?= =?us-ascii?Q?SUSX5KsRcNxt4zyhce/gNLwPMQYJOOb/YmpfGkipsERYp1207y05mJ5RsAHC?= =?us-ascii?Q?+QGk3JBTcF4Jw8071tUKl7FMGPUMloj1bIAhYCTeOCoM737qPpGnm9rppOrI?= =?us-ascii?Q?9LRpJNgSyuT9X8ahfeep0MPAUGyGxo3zvbUSDy6Pb+I9bi/LWwKzjbtW2emW?= =?us-ascii?Q?hU3qZXhZLoa3kj9X1LDm1KW6CM5iWi59ZPcZrkzHh5Fh+oJJfn82Ow24p5rs?= =?us-ascii?Q?3KgvfiU3eJFAGrUxRMqLx66PrUUUOvQTVowtD0yjH7C3GM8Sdzfm56zX680/?= =?us-ascii?Q?G8c4mrPVWBFUy7Pp7z4ivvnCPjq+jNMENuhfLvjTOPjaHbwXwxu8kAJYKpIA?= =?us-ascii?Q?EQf02W5A1edWVSfgkYCAd8m437REIGP3sEhFJnLxDqsCNXH6DkyJs/eGY3Ty?= =?us-ascii?Q?m46K+0fFfvA1Ui0m07jb4xZ91wTodPB50xWa9i3QCQ59KkUj0Ljuqj4QKKkl?= =?us-ascii?Q?mwHVL9HZVAkQzG6q5443hIGLm15Y2NmYSLIWd3cTlgd3LSvenQNCipRje0+4?= =?us-ascii?Q?6Z1A5J7lFR7NICOMpNQAEv09LcXA58SMXYV9lveimeIoSeNqs8Xf81QYwC48?= =?us-ascii?Q?7ky7wolXbOosM9Tt8Zv+5sj0mZvl6Te5P9X3/Q/zJ/G6GzFXeZtJSAWveKTE?= =?us-ascii?Q?NYwIjOqeqv2uYRsAs/w6Pp+MlChQ2K++oM4zLp5Bd8oOlF6/OWhgZwlLAP/r?= =?us-ascii?Q?KmEsqkK4gqeXMBKz8611WlT6J9+PGOj5J2gQAoKxoI8lGG/bfzHAm0kDbHuG?= =?us-ascii?Q?n9xyAhsDgxDFTXuZGqOdWJipjYs5wvHO/NHy9igTXY+tklpfZnWxrax1F7rM?= =?us-ascii?Q?Lrv8rXKfER7jRxqpIOAP8xfYJ5dPtOkE9Ce5mEntLs7P8QQJTQb8WLSOdc+y?= =?us-ascii?Q?9hNTLXYguKC91MeSPtbKgO5OKgNTleRprxeOWv27Ax84nT5ZNBxLG3vv6OmZ?= =?us-ascii?Q?l05bUjLhQqCl8ICjDUGD3w1yNi0q0eJ7atRr6pgbtd15DoTbSKvWUGO/Nnbq?= =?us-ascii?Q?G/gtcBRtP8GAnzHs9u9BtZHoqSANsfVnm1GHNk9cGLqdNFzeS3jn1XWjl8Qw?= =?us-ascii?Q?kfaCLS7n7b/NOq1CvRcZ0xfysgGgTdXXljk7aDqn4cU0otReIgPDmDMQOtPw?= =?us-ascii?Q?IRTzrQxORg=3D=3D?= Content-Type: multipart/alternative; boundary="_000_DM6PR18MB3193122699AA7888B8765E44B9D99DM6PR18MB3193namp_" MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3193.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 742ea29d-cd1b-4ec6-30ae-08da3eca194b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 03:44:55.4395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: etnFBumkaAx4LJTqCw+dcCHUMZhmAkZbxslWIB63DrrQylrMw1uazq9QO//qq1qQuSWhkGSIN0L/W9QlC0UmjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1174 X-Proofpoint-GUID: xGnh0DaxzA8VAoyIbigEATb_74f24I6h X-Proofpoint-ORIG-GUID: xGnh0DaxzA8VAoyIbigEATb_74f24I6h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_01,2022-05-25_02,2022-02-23_01 --_000_DM6PR18MB3193122699AA7888B8765E44B9D99DM6PR18MB3193namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi All, Can someone please share the "MISRA C Rules For Xen" read-only excel sheet = link? Thanks and Regards -Naresh Bhat ________________________________ From: Xen-devel on behalf of Stefa= no Stabellini Sent: 26 April 2022 08:04 To: jbeulich@suse.com ; andrew.cooper3@citrix.com ; julien@xen.org ; Bertrand.Marquis@ar= m.com ; roger.pau@citrix.com Cc: sstabellini@kernel.org ; george.dunlap@citrix.c= om ; xen-devel@lists.xenproject.org ; Artem_Mygaiev@epam.com Subject: [EXT] Xen MISRA C meeting External Email ---------------------------------------------------------------------- Hi all, I would like to schedule a meeting to discuss Xen and MISRA C with the Xen community. I have a proposal on how to make progress in terms of MISRA C adoption in Xen and I would like to get your feedback on it. The meeting is open to anybody. The Xen x86 and ARM maintainers' input is required to make progress, please fill the Doodle poll by the end of Wed Apr 27 if possible. https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__doodle.com_meeting_p= articipate_id_elY67vja&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DRXJFzROO9n= XScR8aaDkNU6ZCmkfPIaIv0GMuOJ1P5rM&m=3DqEY_7qRui0kIvfEnpRFfdtfI2fE12_6V8maCM= Kbla1KKnepLZFDxyEWmawRDbWrf&s=3D_S_U8vNb535pEdAHS77PMn-zepxQNH_2gRu-qFht_ls= &e=3D If no slots work in the Doodle poll for everyone we could consider re-using the Xen Community call slot (it is one of the Doodle poll slots). Cheers, Stefano --_000_DM6PR18MB3193122699AA7888B8765E44B9D99DM6PR18MB3193namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi All,

Can someone please share the "MISRA C Rules For Xen" read-only ex= cel sheet link?

Thanks and Regards
-Naresh Bhat
From: Xen-devel <xen-dev= el-bounces@lists.xenproject.org> on behalf of Stefano Stabellini <sst= abellini@kernel.org>
Sent: 26 April 2022 08:04
To: jbeulich@suse.com <jbeulich@suse.com>; andrew.cooper3@citr= ix.com <andrew.cooper3@citrix.com>; julien@xen.org <julien@xen.org= >; Bertrand.Marquis@arm.com <Bertrand.Marquis@arm.com>; roger.pau@= citrix.com <roger.pau@citrix.com>
Cc: sstabellini@kernel.org <sstabellini@kernel.org>; george.du= nlap@citrix.com <george.dunlap@citrix.com>; xen-devel@lists.xenprojec= t.org <xen-devel@lists.xenproject.org>; Artem_Mygaiev@epam.com <Ar= tem_Mygaiev@epam.com>
Subject: [EXT] Xen MISRA C meeting
 
External Email

----------------------------------------------------------------------
Hi all,

I would like to schedule a meeting to discuss Xen and MISRA C with the
Xen community. I have a proposal on how to make progress in terms of
MISRA C adoption in Xen and I would like to get your feedback on it.

The meeting is open to anybody. The Xen x86 and ARM maintainers' input
is required to make progress, please fill the Doodle poll by the end of
Wed Apr 27 if possible.

https://urldefense.proofpoint.com= /v2/url?u=3Dhttps-3A__doodle.com_meeting_participate_id_elY67vja&d=3DDw= IBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DRXJFzROO9nXScR8aaDkNU6ZCmkfPIaI= v0GMuOJ1P5rM&m=3DqEY_7qRui0kIvfEnpRFfdtfI2fE12_6V8maCMKbla1KKnepLZFDxyE= WmawRDbWrf&s=3D_S_U8vNb535pEdAHS77PMn-zepxQNH_2gRu-qFht_ls&e=3D

If no slots work in the Doodle poll for everyone we could consider
re-using the Xen Community call slot (it is one of the Doodle poll
slots).

Cheers,

Stefano

--_000_DM6PR18MB3193122699AA7888B8765E44B9D99DM6PR18MB3193namp_-- From xen-devel-bounces@lists.xenproject.org Thu May 26 11:12:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 11:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337557.562197 (Exim 4.92) (envelope-from ) id 1nuBPs-0003iU-VV; Thu, 26 May 2022 11:12:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337557.562197; Thu, 26 May 2022 11:12:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPs-0003iN-Rk; Thu, 26 May 2022 11:12:32 +0000 Received: by outflank-mailman (input) for mailman id 337557; Thu, 26 May 2022 11:12:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPr-0003PI-Hy for xen-devel@lists.xenproject.org; Thu, 26 May 2022 11:12:31 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb814efc-dce4-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 13:12:30 +0200 (CEST) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 May 2022 07:12:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6527.namprd03.prod.outlook.com (2603:10b6:510:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:12:27 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb814efc-dce4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653563550; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=PBMWe2e5tnSEdJ6Bv9dpHzpzqoZNTScW7UnwX7GdXCc=; b=AE+kmoaam++d7ygjxWOp5M+kelb3goE+19yt3GD+b8uaQyIFXVVPr5fA ApOyLWJ1GxDjVx5gRiUrIEXVB7qgowGm5lhWyRLm5THnpgzaPPlz8rz5T gZ9Sy+zMB3qZ1UT13TfAgoX+Bg0dQI3rlbokimj2YGJBoxlGMV8o/xRrt I=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 72630641 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iNNw7qkzJIOpRukJDxFHDjXo5gybJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfC2uFOfnYMWqgKIh1YNzg9B8D7MeAztNmTwdopXo9ECMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWV3V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYFlonbpT+nckkfTJRMQpmHJUb9YDCLi3q2SCT5xWun3rE5dxLVRhzFqpBv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXu5kBgmZYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8gzO/fRrugA/yiRS14CyPcfZQOa0YuYJxhiIt yGd0U3mV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWc9Zb Uod+SMsrK073E2tUtT5GRa/pRasvRMCWtwWD+wz7imMzLbZ50CSAW1sZjxLZcEitcQ2bSc3z VLPlNTsbRRwtJWFRHTb8a2bxQ5eIgAQJG4GICQDFA0M5oC6pJlp10yeCNF+DKSyk9v5Xynqx CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb8D2B0wTA3Ncp9Ebs= IronPort-HdrOrdr: A9a23:OKsqgaudjBiRXfPL0vLFpIZk7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.91,252,1647316800"; d="scan'208";a="72630641" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVWWVI1/eWU1EoO1flrPBYmt2KOI82+nHJu1GiEsU8jbBA6G0qnLDnDJExQm4tW4TFHgfIopS0KQCqunUHYEtBYJFfuKxQp4AkPmoHxb6k2wuIKNRXRbWwzDldXRUtgsj7b3azKtvR6GMpjHfNXdFPIUMQjXjT6kNaZtJ8gRTv0LjLnYzmAEpJCKl89XJCdFhPD/dSdDvNBW4UffYCHTMsSMDXhH+AqOun1fsiiRbIcJwAAtY1B/q3cc0uuPISlKt+/GcuGXrAaFllsbV4UHRnyfou1Ysfhk6Z7GiYH06kVvncvit5lfWGwX8NF2qNADhvNRgNRoSSoxjLcix5JFrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+B7jXwaQnmE/NSaDWI4p/4Ntnz7GpbMI32FmcxFI1dg=; b=Wzilfgy+UBiWaaoOjQojBobMfW6DQ2m2uTjtQFPTwKzDVlOXhBb/VuDlRNc/bH707hKrTTgGJ8N8IHfgjtU2bC1GUyO4herJ/onxCeRoDxY5c1aGBx5+p/DIpe/n2yGg8ecZVBp8cgygHZ11bgj4Fp9wnLthtvQrFTnnZUgJWZUHsak1EKCrcwFWdk2NnM71XBmg+E2oQ28gxIHdO2LHYLLRlLhJRzb82/RZF5IZBet4p53Sd4M47vbff1uzeOeyjp+mcliAdxiIJncfsXc77BLIPjhjpVpMofZVK2hQiMI+VSkKItvwnWk8nBKRkOlbGGodxeJ2kU7DCvbf/ScQWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+B7jXwaQnmE/NSaDWI4p/4Ntnz7GpbMI32FmcxFI1dg=; b=V9eOqVAxRYcFQIElI88n3GxmHbKI0rrAZQGwfSftIZdqwRXGUB6zYTk/BsLbYvTt8338rU0+zACnIFEhgq9/d4r4mvlpi/ep3jr3pEOhUdOysgErkNzKw4CB5fTiCyyefS0C1nmjUxGefTxuqcx4ThmYmLcPW2NA/YoMQszgelU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI Date: Thu, 26 May 2022 13:11:56 +0200 Message-Id: <20220526111157.24479-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220526111157.24479-1-roger.pau@citrix.com> References: <20220526111157.24479-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0084.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42d24729-1ae0-4802-f36f-08da3f089e16 X-MS-TrafficTypeDiagnostic: PH0PR03MB6527:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXZt2q4SEoFqqxfRL7n++shMOb0AWEQaoNkX0MvxafZRym3oXFNJF9UteMFsSobiBE35wGp79+LVZJNRZZglUVjM57euUfA1Lgy7fUwcwrGNAmm1oHu1xlNnhhI3zkr5GaQty0CmPf2a8MBXI/fvx5tx/YbHUyL5qmxmGshWTfDp1Iuut1QCKPkESPZdIk6bG4S8ULrZIz/VQXUE5I0IKunhQWjzX+RnGzjF28Oq2gwD5ZIFwEhvkebS6gkn6BN/hmq2Kvu0clHUe1eFo3kUSLfYNuHC3uxZv47dZbTZfVM7cW3HV0kk2bXMkHb9J9TJZpFOpu1v+WAIPYxBP3/6I3O45nymF3b/odx9I07Zm2rhPCuPiF74lt16Cxj+PVvTAybDSUPgRKBJesfXM5yjoMTItt81WP80dvGJ8ugwKOTAZoM+gHE6amyt9AEMbklyMW774bwfALzcdiWLWZSNc0VZHW3XeaTk0A4v9VpmldAS9XmHBCmxcspQlioi8FrorLQ9Aaygmlu21ZwOqbCrpDBculeylF0Vo7o15TfMXZxN/KfTzjaVzN16Qncits/2qIh41wrpybaJLB9b6uHfM+XyM1z0la0DAtud+UHg4VDxnQplGLHsxiYbDLSY1TC5L7aEDfbGupgXnM3kDZOFTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(86362001)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(54906003)(316002)(6916009)(38100700002)(1076003)(6506007)(82960400001)(6512007)(26005)(6486002)(83380400001)(6666004)(186003)(508600001)(36756003)(2906002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFR2SncvbXMxK1RpUjM5SFhvMHJSUFdOb3QvbENPMGM1czVkb3llRTdaM3R0?= =?utf-8?B?R3V0RVNCbEZvOXE1cGlIR0QrRG51cEhBMEhNNDJ1VlRpdjY1TW5UK3pMSFhD?= =?utf-8?B?bWdXQlozTWc3d2J2SEloU2VSSHlNdU5ReTFCSnJ3dVRnMmZiVk15N3UzbStl?= =?utf-8?B?RHZPQnMzdDk2aUtwZEVYVmM5bzJXREVBSURvSXlZeXYxWTZMQ1pwLzRlUWNF?= =?utf-8?B?ZU9sMVVTa01Gcnp0VHNGOGFxSnNZT20rRUtZSVFDek1GMkR5SzhhQjFEaWhk?= =?utf-8?B?bVhWd2djZGZQYUwxQ05taDUwRXRXMDh4ckUvMUh3MkxvMHJzOXB4c1ZSaVZL?= =?utf-8?B?blBIS0FYV3BJb1l2eWFHZDFoWEFQSFFLR0pKemFxVHlGNkVaVUtoUVJCcGVR?= =?utf-8?B?cmZqN29XYytFNlNZSG1MUWI2N3hONUV2VVAraWlOcTd1dnVOWUdaNEV6eWlN?= =?utf-8?B?NSt3SWJZQitvQ3Y0YithZUk2RHVMaGlzTkNrTk4rQnZNY3ZBTkxNcitZSkNS?= =?utf-8?B?VU5xcVFXbUpJSDBhQkhDZHlEWDFWcEQybFBMcGcydlVNN2tUemwwdjJWL3hU?= =?utf-8?B?ZlJLVFBIaitGMW40RUxTa2tvYXc2ajhlQk5VRHJHMTZJak5IR2Uvd3R5a3pR?= =?utf-8?B?K25DaG1HeE12YjBVd3NNQ1ZxQ3M2N1FDREdOV0gyc21raGZraXFqcU5nRHdO?= =?utf-8?B?cWVwSUZsOUpHOVVVWjN1MVpmNVRrcDVDNVdkem5meWt2QVNIc2gxalBQcUVT?= =?utf-8?B?REVMY29CMWw5MVdoRkswM1AzQnBHd1NuTlY3Nm4zTi9YYzRib3JRZjJCdmw3?= =?utf-8?B?M1BJZWdMY3JqNzNQSkV5ODBFc0hVTFdUMjhWcEFrN0d2ZFZuN3pxZVI1b3JC?= =?utf-8?B?TkZmelFFalJTeGRiSlRjOW5GWVFnbmxVL0pZWFloMUdDYlI2VDBLK3FGblJv?= =?utf-8?B?alQ0V3lPc1dqODlyM1lXZGJpSXkwTDY4MklvbmhwdzJ6SGxqaVRWQ1IrdnRa?= =?utf-8?B?VnhqemxYaVBLNjlHSGlFYUkzblFUeERVaUFkUUlTT0pwMWxmZWEyNmJaeFR1?= =?utf-8?B?T3BhVXhRdzlOdDAwbmZoSWErVkF0a3pLMTJrNitkeUxwOVlibFBvMWY1cngz?= =?utf-8?B?MysxVmlSUjJwZ1BKb2R0MWZzek9lRXNJTGpaYWtNbStqQVAyaGJhZDBFZ2xk?= =?utf-8?B?N0pWa0Q3MTZNNDB6ZjV5eHY2dERhNGpvZE80NlBBNHpBQXYxbGZ4cUU3KzFo?= =?utf-8?B?SmRiZ0ZXVzJ4SjZQTGlSdzI2bXhvN3JhcGhPTmphTTdUSFQzODlzbnN5Tm93?= =?utf-8?B?bno2Y0FRbFNOKy9yRElMZzFJdW1vS0NodGxnRlcxNzB4Z0RhK0twYi96Q2pp?= =?utf-8?B?bDNCcW8yQnlod3F3UmdseHd0YzlDLzArWjZRVWp6Q3cvdENFNmttSkRUaG03?= =?utf-8?B?L2RCdXNpd2Y1ejJjTUl6OSsyRE9NQWRNa3V3R1NjUVBtS1h3Ni9SUHpqK3Vz?= =?utf-8?B?LzV0YVdqeldwUndhWEt0OTFVK3pBR1d1aDcwZWhYTTNaNEF2cCs3ZEpoeHFi?= =?utf-8?B?QkJzSUptTmh3M1ZBaHcwRTZHL2NuL1VIWlJhWGFHNngyMEYycEdEYWlmNzFG?= =?utf-8?B?UHpXRkpJSHdrVFViek9vb0dLWXZUNWFHWWgxKy9lN0hDODVsYmVId2pkeGtD?= =?utf-8?B?Y1pLbnlnYmhjcVk5MkNrNWhvSTJROFA0NGxvQTYyS3cvVVQ0MUR6aEVYbnp3?= =?utf-8?B?Qjk4MWNYbU9YOWF5cytjeC9HUmRkWGNwbmhYUkJqNDBvb2drV3lSQXhBZXla?= =?utf-8?B?WGRWZlh2YnpEWFZkUUN1OWtuaUlrUFlOS3lBVVU2bC9EZU9JRjhSV2J2SDFF?= =?utf-8?B?SVlNc0ZiUnZQdk9sTERVU0NzcmVkbGxxaXExVnRwRkZmZHRzU3RoSHJSaVJ2?= =?utf-8?B?bjBuKzBOMWg4MHFMZVJld0dkeVgzUVNtanNZR2tuN0JRRFR6VXB5d2FqVzRD?= =?utf-8?B?dE9sZkdxeU5VOWlndlpIYmdiVUJpWGl5RVZIYUFxZ3dLSElpdVloZmV1OXR3?= =?utf-8?B?Vk50c1czNjBZMkZSTE5UWmE2M016UVRsYzh3NUVIamI2UXF6ZGt2cjUvbVJj?= =?utf-8?B?RVpuY0RkdEJzUjM5N01ac3kyQU1ZTUVleVl4eW1ySVJ2WW55cGhrU1gvT25K?= =?utf-8?B?bUxMMUZaOFk0bjJjSUFucXBlcktxcmVzOGJmaEt5TjhmeTZZcjFXNkp5bHhl?= =?utf-8?B?b2IzWWJjdUxLbUd6d1UzQTc0OC94WWc2VlJsTHBRZ2R2YzloNFZ0Y0p1c005?= =?utf-8?B?WWhmZEc0WW0yM1g1WUQ1a05NQVlEYlJBcGZtSkpzZmtXQjZXMHU4Zi9EVUFQ?= =?utf-8?Q?tycQoEs+Z9r77QVk=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42d24729-1ae0-4802-f36f-08da3f089e16 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 11:12:27.2177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tKMUVbZtqd37nEprMYaRp/PSP9DkpN3tdxhyNYHOoURE6YNbkXoIs7ppefQ6UOHZKE/2IUz/6/o/UW4RRZ1/XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6527 Introduce a small helper to OR VMX_INTR_SHADOW_NMI in GUEST_INTERRUPTIBILITY_INFO in order to help dealing with the NMI unblocked by IRET case. Replace the existing usage in handling EXIT_REASON_EXCEPTION_NMI and also add such handling to EPT violations and page-modification log-full events. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v1: - New in this version. --- xen/arch/x86/hvm/vmx/vmx.c | 28 +++++++++++++++++++------- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 3 +++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 476ab72463..69980c8e31 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3935,6 +3935,15 @@ static int vmx_handle_apic_write(void) return vlapic_apicv_write(current, exit_qualification & 0xfff); } +static void undo_nmis_unblocked_by_iret(void) +{ + unsigned long guest_info; + + __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, + guest_info | VMX_INTR_SHADOW_NMI); +} + void vmx_vmexit_handler(struct cpu_user_regs *regs) { unsigned long exit_qualification, exit_reason, idtv_info, intr_info = 0; @@ -4139,13 +4148,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) if ( unlikely(intr_info & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && !(idtv_info & INTR_INFO_VALID_MASK) && (vector != TRAP_double_fault) ) - { - unsigned long guest_info; - - __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, - guest_info | VMX_INTR_SHADOW_NMI); - } + undo_nmis_unblocked_by_iret(); perfc_incra(cause_vector, vector); @@ -4511,6 +4514,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) __vmread(GUEST_PHYSICAL_ADDRESS, &gpa); __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && + !(idtv_info & INTR_INFO_VALID_MASK) ) + undo_nmis_unblocked_by_iret(); + ept_handle_violation(exit_qualification, gpa); break; } @@ -4555,6 +4563,12 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) break; case EXIT_REASON_PML_FULL: + __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && + !(idtv_info & INTR_INFO_VALID_MASK) ) + undo_nmis_unblocked_by_iret(); + vmx_vcpu_flush_pml_buffer(v); break; diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 03995701a1..bc0caad6fb 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -225,6 +225,9 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) /* * Interruption-information format + * + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification + * field under some circumstances. */ #define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ #define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 26 11:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 11:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337555.562176 (Exim 4.92) (envelope-from ) id 1nuBPo-0003C8-9X; Thu, 26 May 2022 11:12:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337555.562176; Thu, 26 May 2022 11:12:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPo-0003C1-5l; Thu, 26 May 2022 11:12:28 +0000 Received: by outflank-mailman (input) for mailman id 337555; Thu, 26 May 2022 11:12:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPm-0003Bv-EX for xen-devel@lists.xenproject.org; Thu, 26 May 2022 11:12:26 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b70454ce-dce4-11ec-837f-e5687231ffcc; Thu, 26 May 2022 13:12:24 +0200 (CEST) Received: from mail-mw2nam10lp2108.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 May 2022 07:12:20 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6527.namprd03.prod.outlook.com (2603:10b6:510:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:12:19 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:12:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b70454ce-dce4-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653563543; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=jaxpZDw1gFbF6UtZnOXAikGrvXO74Ch76SFZtNvfnlg=; b=T2C7b0KMEl9te44/g2YAVLUetP5lfuJ7hJo6lmkXheoM5mP9L3QgGQgC jrd/zUheJQQgPl1k1xvjY7hlYZlkzkPLGL6RdQZiDcEjIdQ0IHlG+wnW6 B+sExrErz1Whl/CqliglM3R6YMv14g34jCj/HDq5MjWzZBvzuHcv4zvZc E=; X-IronPort-RemoteIP: 104.47.55.108 X-IronPort-MID: 72229428 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cqtbe6lGR2eqRJRx1r4vl9Xo5gxDJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdXjrSM6rZNDD0LdxyPYvg908A7ZDRyd42HlFp/yFnEiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkWV3V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYaiQMH/zup8MhCRRKAh9hBJMYqJ34Li3q2SCT5xWun3rE5dxLVRlzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBhGdYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8gjP9PZtswA/yiR03IbXYNntfuapH8EMjEyV/ T30/3j2V0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWWc9Zb Uod+SMsrK073E2tUtT5GRa/pRasvRMCWtwWD+wz7imMzLbZ50CSAW1sZjxLZcEitcQ2bSc3z VLPlNTsbRRwtJWFRHTb8a2bxRuwJCwUIGkqdSICCwwf7LHLu5ovhxjCStJiFq+djdDvHzz0h TeQo0ADa647iMcK0+C+4grBijf1/pzRFFdttkPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytalUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:U5b6M69l08CWe8qNkHZuk+FFdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwWpVoJkmsjaKdgLNhRItKOTOLhILGFvAH0WKP+V3d8k7Fh5NgPN lbAs9D4bTLZDAV7PoSiDPIaerIq+P3lZxA692urEuEGmpRGtpdBkpCe3Cm+gocfng2ObMJUL 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Lh1JfKVzyjmjsOWTJGxrkvtU DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESkti+YIKBaH5GStjE8p++irH4sjd n3uh8le/9+7nvAF1vF1CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAx7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1TwKpsKuZPIMvG0vFnLA E3Z/uspMq+MGnqJUwxh1Mfj+BFBR8Ib1S7qktrgL3m79EZpgE686Ii/r1hop4xzuNAd3B63Z W7Dk0RrsApciY3V9MIOA5Te7rBNoTyKSi8QF66EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06 j8bA== X-IronPort-AV: E=Sophos;i="5.91,252,1647316800"; d="scan'208";a="72229428" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8qNZK3YxgrASUR1X28PqrJYu7bPPAEBTAbv5W3OHe6fxM1Igs09C2q5GMsvhg5r95UpgBhu8RHWeyCnNLhNUfqGwcwvovPGwPq/J6u64gagAeXyDAfq/p6hrEPogXFgHNZ5t7eyeRtp44HOpmNMdyz3dKO9AGZPaIsNjARgpIyumyviP2F8gqDAqL9m3evomx/kANltjCaXPD9Z3n3u5hOdsQ4neTimXcpejJBNC8T2ao3uB911GXYfe8IXqCWh4SxYaVQCn+3F88YXDlzZKxumjFOU8a5w/5DjD2yP4USLtMW5A7GHB4Bfm9Tiyvx30hVIokXyJYJxbA2/PdI+LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4j998d+wKI+B5c8Q4Pu6YwrODgFxmp/+EKuzijI1YW4=; b=e3YHuPgTVetaaZfxFP3fltBi0XTOvnmnqkmU2IKqNr8nufhH6f7Nz6N3mFSKwd3c8iiSTHk8yiVLJi5O/sHs0Zw+I7itFg5qQDn9R2yqOqwdFjR7kzdLOL41HI5e73FJHjBj7QVlSGVS1oEyneW2CnsODQyam1amZcYG4osRSnn2TUxgJ5hoKOl7CKtwanvNSakqU+vEBnx5xXMk9KMcKWMX/BP7S0wHoWFZFkq9Qqv7Fxfif7NCJlDGgmDIKmc2/BQ2Y1SsFjMUNmN9wS9btwtDm/QiruxWXHCbgZ4t4wJiCptXl2W51OpEEgnzI+huCikjrRdli5CGWUqgZzPWcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4j998d+wKI+B5c8Q4Pu6YwrODgFxmp/+EKuzijI1YW4=; b=DfbillU2PWBe0ZYUKsMq0g66axgdYvLyxufTr07OTW5ViEH6LHWA07ApgQEqkhpPB/04v1K1TJN9cZRur2aHpXv6CLv3b41HQJE0pByBljeJ+fcwBX/EI8XxH/L/qfOdkY6SsaS9SVhRysGnCsk5R+SP/g1jQFj1MwHo8j06ar8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 0/3] x86/vmx: implement Bus Lock and VM Notify Date: Thu, 26 May 2022 13:11:54 +0200 Message-Id: <20220526111157.24479-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0042.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::30) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 962d15a4-da63-42c3-0daa-08da3f08991e X-MS-TrafficTypeDiagnostic: PH0PR03MB6527:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k9y5zYjArhUOG8JaqK45ZGj5AExWANfXdGXwxT+oCGaj/anAflCnJzuPv/aUSKSXjyzDUS6hq3XMxxlHvuWz6NEM3t9/i/yoGWcq1/ECvC2+6gzuWtZT9FjrCqlbH0VKfc7Ei7tEB8Q1C6ZEHYP9IHZSPE3gVnShb8+bEPxc76+WmiAG+f8/JM73I5ouyPlMu9TcYE2xYfFyhgNMrhG7QvHZC2ZMtRjwreHahoQcqBiVgjdsfX+TySZe74Ch7/kh4HC/QVldRakP1QHiIEr66fKxqOHdS+vgFiVEkEuynuIGJ/8YvQCyJzIul75P91twd4idGb/SRBKVrkUJSFw0KsB6NKgwdXCQmrNou53wsyA//xTLJxFWV7th0+Jbx0gLz/+C7lPUKdDn4Ns/gTaytrGRmpvktvbGgIfwpa4JTWmtyO+aJRDGIoeHlCtWD9sIy7frKKuDReTHZcIo9E6uDsYAx0J6gnqqiBpENlkDkh32gQzoM3FxPaNqaAo/QESoQYGoWOYyC5MkepZJz6hxAJdjgu4FKo2XpxqAkYME6s2j+rEwF9POj40lEIfJtZXdiTCFlASoAVcRsQMEryO1gXOZRrrk/MBL5rgE2wG2v9KsL8nm5TPmCM5ymZkXG/XFBylFLWkzMdpY2hJAUMSs/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4744005)(5660300002)(86362001)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(54906003)(316002)(6916009)(38100700002)(1076003)(6506007)(82960400001)(6512007)(26005)(6486002)(83380400001)(6666004)(186003)(508600001)(36756003)(2906002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUhvS0ZVLzNuNDNVNzRTN3BKbUZ1WUxQTlpKeWlWbnBOSVJRcEliV2I1RzQ0?= =?utf-8?B?ejJXYXl0bFI4NkJsSEpiVWtsaGJ1a0JuVTlsRFBTRm9JOVFvTnJFM2pBRGxK?= =?utf-8?B?bnhmb0tKR3JOdHp2R1JQSzhVaVJOcGlnNnFtUk9zQUoySFB3K1JaeDNtQnIz?= =?utf-8?B?V256YjZYemRFa1dVWmlocFFVcFZJNTNYeks4UXRnaCtUa0t2a0pSVFRPTDJo?= =?utf-8?B?WDFEZFpQN3NnZS9LSlgyN3oyRjRWY3p2LzVBL3FxQ3FUTENEMzhtVFZ3VVdz?= =?utf-8?B?bEE5b04zZ1lKY1BLVHpmMVVFNm40d1Z2V2dERjNTclpTbTZHTG1VSlVzRXZu?= =?utf-8?B?NTdmV0NjZ09VaVVkUys1dlMxUUV0amxhdUhISHJ3Q3hPTUdwclFsM0hzMVBK?= =?utf-8?B?bmtmUWdrbk9JYlNPUTFFWGlQRkdvTkVBNkhnMGdEZHJOSVRjMUZJbFlSaG95?= =?utf-8?B?Yzhic1BOOWdKeU5BbGp2YTA5dlgwYkthU0JuVEdjaE5ybS93alpPT0dNZ1J5?= =?utf-8?B?WDFKY2VKcjFtTWVHOVBxVnpzVml5cVlPVkdNa0liWUxzNUEvRFE5VytkYytM?= =?utf-8?B?eXZHWnR6R1ZQZ0VxR0QvZnArOVBwVGlINHFpZ1FublVxTXI1OWFpQW4vejla?= =?utf-8?B?Mk1TVFduNXFLNlBWb1c4aG5EZ1l2UktsQkZINmwzU3BKK2oyWVhrOWorU0JM?= =?utf-8?B?a3RiZEZqL2RpczQ5eFRZSWRsS0tKbEZ1Z2xlL2NCSXk1WWpMRHJkbkIwUWs0?= =?utf-8?B?T20wUkErRHhlUmpaazJLdzdIRy8zTGxJK2N1ZzdPeDZSOTI1MDhiM3RpQWRm?= =?utf-8?B?dDNKK3kvKzlYbzB5T0ZwTTBjVUNDcW5KZkhoWUJ0bE5vektobURYeFV3Y3Vz?= =?utf-8?B?b0tGQmpBODY1VEdmSmFMdHJndmswaGR2S1JjdGE2U1lJUTFHSjN5UGZ1M3BQ?= =?utf-8?B?eHlZN2V2OXBzWHBGVjlqWjdseDRScDZPbkttSCtjUWNSUDlRU1VVUVpacmZo?= =?utf-8?B?WU56d20yU1ZLeFZoS3VMZUJqTUpQS0x0ZW9vdWJZWk1JVW9XV05lU05SeWND?= =?utf-8?B?K1hsTWpGS2RPejMvcUtTbFRybUJNd2ZjVUlVcm0yeCttcnYyZFF5RXd1dkdv?= =?utf-8?B?Rjh5VlQzN2hzemJWV2UxVXBQOVhTU2kwNERabjVhMWZEaHViaHVyUGdBZnEz?= =?utf-8?B?YWp5aHNaRGl0UHI3MytWQW9DNFpkQnJBZGlkY3lTWGEzWERFblJLeXZsMkNE?= =?utf-8?B?TjE0ZDFLWEZQK3UxN1RPU2hsaWxHaGx3cTNJUWlXOGdpWE45TW1mSHczTExu?= =?utf-8?B?NXE5UUh2bDVTTC9qaEYrbmg0UExwMlppbEFBTWN1b20vdXhQRzZOU0JCSEhu?= =?utf-8?B?Z1BjQlloWFR6UDFvMHFkdzhqQjA4aEY1L1A2SXQxNkdjZWEwcUpHOHozVmEw?= =?utf-8?B?VTdDQkVhaWVYaHNHQThTWWxHem9kdmp0MExadUQyelBIZnFOU20xK2NaWTEy?= =?utf-8?B?b3N1TnpTL1h4L0FsYkxwOWg0aGJZSkU4dEhzRXpsL280T21rSkNuK2hTOWdQ?= =?utf-8?B?RXE0YVNad2VZQ2ZKQlNmZmRFcXRoZnozdk4xd2RTT0NOQXREbXpSakJIZGE5?= =?utf-8?B?dVRIWU92b2pMMVlLbUVKVDZoZVlYZlI5ZnFYdDludUdZcWV6RUJ6V213TXVW?= =?utf-8?B?elNxbmc0dGRUelRTVlh2M1JFVUdwWTJBZ0FBL01Cd3BQR2dWU1M1cG1TazVL?= =?utf-8?B?VmFYbWp0UkFrRDJCZXlEWjRVWTFoamVzMmRValVPRkhNc2RuNXNJVEF6elB3?= =?utf-8?B?RzVjT1o5ekk2cWVnNmN6NGk5aDg1VEhaVXFpWnhqUFJsSlI0ZVRoOCtMUStL?= =?utf-8?B?L2ZJWW1zcENZdmZ3SXZuMlgvaVR6Zk1USVZFSTEwRU5Fdk52ME5yUnhwVy95?= =?utf-8?B?MEFLOG8yc3dNOXEvKzlYNWdhU1VKc2JJZmt4UWJCcnV6SjA1WjI5SHpTV2ZO?= =?utf-8?B?blNoUUgvS3RXbnR6bU45MmJvek1DSE5sNGRHNWt4cndteE83VTJyZUp6N1BC?= =?utf-8?B?S20vbjZ0amVBSEVFOXMxR1IyQTBubHhQRkFVbG5lRURUbFphS1BCSGNhMmI1?= =?utf-8?B?eXhVQmh0cmtkQ2poN0tBY3JVemNrSkhKVVBCZituOGJMZkZrUnNnbDIyckh2?= =?utf-8?B?dE40Um5KdVRoRElvdkFmZnVzVG8xSlZnZHQ3SFVudHk4YnhTdE8wTDcvYkdw?= =?utf-8?B?aXBlYzlVVFdBS2lZNUhTL3l2NlNxY3R0RXFrL0h4NC9NOUJmUWlzdXMrV0JW?= =?utf-8?B?UkIzZG4xQ2RBL01VQ1Y0YURiaG10VjBqbkpFeXVwbTU1NGxxeVExdFBSVVky?= =?utf-8?Q?T9tedj7lvxCUbJCw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 962d15a4-da63-42c3-0daa-08da3f08991e X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 11:12:18.8611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TtWii/eP8raGsjsxay5b41xL1EPBpSrN09q7SwYsItkxmaJuYxY5qJfdMlFqKwqz+UdbH/d9rTIJoYlvQMqlzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6527 Hello, Following series implements support for bus lock and notify VM exit. Patches are not really dependent, but I've developed them together by virtue of both features being in Intel Instructions Set Extensions PR Chapter 9. Thanks, Roger. Roger Pau Monne (3): x86/vmx: implement Bus Lock detection x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI x86/vmx: implement Notify VM Exit docs/misc/xen-command-line.pandoc | 11 ++++ xen/arch/x86/hvm/vmx/vmcs.c | 23 +++++++- xen/arch/x86/hvm/vmx/vmx.c | 78 ++++++++++++++++++++++--- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 7 +++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 11 ++++ xen/arch/x86/include/asm/perfc_defn.h | 5 +- 6 files changed, 124 insertions(+), 11 deletions(-) -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 26 11:12:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 11:12:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337556.562186 (Exim 4.92) (envelope-from ) id 1nuBPq-0003Rt-Ky; Thu, 26 May 2022 11:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337556.562186; Thu, 26 May 2022 11:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPq-0003Rm-I7; Thu, 26 May 2022 11:12:30 +0000 Received: by outflank-mailman (input) for mailman id 337556; Thu, 26 May 2022 11:12:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBPp-0003PI-Hg for xen-devel@lists.xenproject.org; Thu, 26 May 2022 11:12:29 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b946a42a-dce4-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 13:12:27 +0200 (CEST) Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 May 2022 07:12:25 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6527.namprd03.prod.outlook.com (2603:10b6:510:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:12:23 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:12:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b946a42a-dce4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653563547; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=IjSmW8a1Um+GGMYx28eSmPuDoMRq2A1WoAd0TjwqTSk=; b=J1wkBp5nfK8DjKcJOJPvUvAqrW1aKf/f5v37pVy3zWUJ/3o1etHL3dC8 POSPTV4cpYfFhFxAZdALYwgkLb5w7dmeVR3TwPGVAixl/kGqDQohbA52i +Lf1IL9qCfLMAx/nOEwaEPpJXChb6Ttewm0w7ySPLBviAlo5NSJobobF+ w=; X-IronPort-RemoteIP: 104.47.55.107 X-IronPort-MID: 72630640 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2yE1f6+oXuqEo7YpKA+aDrUDmn+TJUtcMsCJ2f8bNWPcYEJGY0x3y 2pOXD3SPKyIZTP0Ldp2OYS2/RtTupLXnIRlQVNsrn88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3ILnW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbuiCisTYqzupMc6dEVYITw9OIsb/LCSdBBTseTLp6HHW13F5qw2SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHviMvIcHtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGcG8wrL+fJfD277wit207TIDOLpPePRd8JvowWHh G3C8DGsav0dHJnFodafyVq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRokyjXZRZI k8d+CsrpIAz8lCmSp/2WBjQiH2JoB8aHcZRGusS6QeRx66S6AGcbkAGRDNcbN0ttOctWCcnk FSOmrvBGjhHoLCTD3WH+d+pQSiaPCEUKSoHenUCRA5cu937+thr0VTIU8ppF7OzgpvtAzbsz juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPeZJu6TABYDn0Mt9 IronPort-HdrOrdr: A9a23:lW59pavwSjrciKMZFBR1BMFk7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A== X-IronPort-AV: E=Sophos;i="5.91,252,1647316800"; d="scan'208";a="72630640" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oZTsr2ihrAEUmvE3vLt102ZtesSSmuVPWN1lszmUZkQQnblr2976XIxdyNGV98ntKEJt+pSpeJrxDqwcZo+P7VJ3FZTCb5iir0LAlfezy64JoLAZ7juqjb3xX6zwOc07/KkjtQ6KdggE2V+hdVmDuNsO5Be1DvTHljagjuge703NdBVt10q0PBWX73fLp2LBY2EhGZHZ8zWP7gsDerrnmOgvK7zGbmgJGGoE5sESMnlAeriJADkKYeSmCbBS2AIVY8lzJnMZDJtvSnKfKJet0euqj3W5ifAPa+7YCe/HtUAgZYwm3xpKfVVG8+bRpyPRmhCIpiekt/ua7jaPThsuCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lk51GUgUWIAXFPTQpLQYHdKMy/7fDVifoFw+Du1GkSU=; b=IoVD4iHAwT0dRCdY4PbKfTcCeBBsaNpsArhyIVWCbfbxlqFPWR0gIY4CxkUEoYRaEmducvzRqtV6vSnTBk+RN1wy9gCR8HUZv//jmcwfWXmJWNKzJEVKjWiOBZ0AdDiUwXJonT4HlxaFSXz+aWYYo/igakArWUwmN5dxjGlF5xPqRr9IEp8fUX3OiW5KnD8FBjJC0IEGB1ehBtRSCc3t0GZATnIa/blcDVw+i0bVW9Bo09LTCJXuxfPfmW5uJSmTfDBLO8ZrzryQg0RANy7eKIDH49cOIIpHt6+GmMVQF9bd+nLWpJIL9QoHA3zEcBqQGWfsfe2G5CQmeKpsYfoftA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lk51GUgUWIAXFPTQpLQYHdKMy/7fDVifoFw+Du1GkSU=; b=k0vSU3nu51WbGrE5TP2MwqI3mQq/ihEJgSwXg0/Ox9jbe/gXMTkPFzbSVZOG1JGKUYxM/lZGQK5kQu4ZWCUYCuy3f4vGjTabEp8HQNs4CzDZ07oIJMQdIxQCpkRgffDKPaMGtBgdsjGYcNXMHVaiXwFWmLBPlQDInW0f4y2XGz4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v2 1/3] x86/vmx: implement Bus Lock detection Date: Thu, 26 May 2022 13:11:55 +0200 Message-Id: <20220526111157.24479-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220526111157.24479-1-roger.pau@citrix.com> References: <20220526111157.24479-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0472.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::28) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84c91296-d62f-4b61-6c93-08da3f089bc2 X-MS-TrafficTypeDiagnostic: PH0PR03MB6527:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8FdQy/bgXTeZ8ARRoWXDk2Nh/pUAdUL6TVVI+hst4EedvK8OXnnPQwM6poc3ZDzrcwCZdGY77R4aLOTjtOXwhJETvEaZ5/zdLuWywz9kf6pcDAAIKDgszyrJV4+2QnJ0ran5hmBH62aTo2xibF8wJSGHvNshMKtAxydPpLpQcksfqV8etb3k3I3tL4EUUtCJF4EiRtUiUZm37B3GswPTW1UZop84V9q/Y8yYCJAV8rYFc863NkB4xA/JzRgprU1TKv4fKaKwt7RvyfIqljfJdMV3sSYyQ6ICYXmyb2CO9FjhS344v6tE+1lcBbCtTXPZbSuQxMimPdRBGrg8jmN/ZUeye/OGeqKnsxI76c4RRFXdOpoma1hf0JAsJntBXrBc0oy6kvthpJzeyOqn+Zgg9flny8TMjFCxhnYnQmDWkOHANYJ7yfhN7VA0/5287Jj9cdeag5MJSnfbPabL7EzH15NF4MvCW9d+USDhG0n/VvBN2L47tewXJCU3f91nuDJL/JEX++Z1WZMy9LqftUAycMx8+pj5PpS5ecLazu9c7TfoYvpvuQzyw5DugXW9pff+wPxnYdudoi1hrHIExgpnPKusVKtwWGmjykqyGirUJMVcbRgPTqtXj0W+Br9xKYBC7nyGFO+pxF8TSZ04uydSfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(86362001)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(54906003)(316002)(6916009)(38100700002)(1076003)(6506007)(82960400001)(6512007)(26005)(6486002)(83380400001)(6666004)(186003)(508600001)(36756003)(2906002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVZwOTlNS1RqVE1aQ3JWOExvT1RNQ255WUNWZVRwTEM4eFVOejFnSHZHazRF?= =?utf-8?B?SWl5TFhJeVI3RWJPWGJ3bmJkQVVtYWFMSlJBYXhValZaamJoOWtTbGdWeXFX?= =?utf-8?B?TmkvRTkxQVkxTG9JTml6b1NwQy83eWVXMUlOVkIwaHhnTmZQaWxWSm9NeWRD?= =?utf-8?B?dk1YN2VVZExIQ3Bkb1B5dXV1cktSbmJFOFVDeDQxY000dDJtNDdrKzFKU3A1?= =?utf-8?B?TVh3U3hkTGNhc0tUdlR0RWN6OFB0WUdPcUpkaDBYVDNVeld6RXlqclhPNlVS?= =?utf-8?B?TW1SUmlRTXZvZSs0czFMbTczOEdIWVN4ekI5eGw4a3lOR2JseXcrTDlOSW1p?= =?utf-8?B?eXFZa0VLTmtVL2dQN1RoOVh5TmcvLzlzQ2Q3czFKTkM3YXpsKzZIMFJJMjl6?= =?utf-8?B?S25OcG1ZUncxYTRSaDJzY1FRRDZMTkN4WE92MUFzRCtiYXZra05qMmp3dU4w?= =?utf-8?B?Mzh3cW4xU0JDN2pUUkZ4dmpNRkd1OTVzY29QZ0lmaldieTl3TWRQWDgvbnFw?= =?utf-8?B?RlRUU3VaVGhCNGdQTFpsc1pTTTBhWW9MY3YzcFNvNVA3MDI3NS9KL0RIRmFT?= =?utf-8?B?Z3RwUW4yWWlWZWxjSkZHalZBZkQ4WEVGUUhNTjlVeWxYeFdadzQ3YVp1ZXB1?= =?utf-8?B?OEJDZmhDak15UGh0bktubWpQY2FERW1vNXAvUWhiUCtieFBMRWZmeGJmSFdB?= =?utf-8?B?WktrTEtkRG83dEZPaW0rWFczME9sTEliK0dzM1F0aVdHdStHbHFuMmZjeVJR?= =?utf-8?B?ampqM1dCWEF6azI0V0RNNUlzUmgybUFRLzlpRU5HeVdLR1JuS3VlZnFHbkZT?= =?utf-8?B?MTl2VnNnY1I2RUI1cm9UUk0rK0ZWT25wdFhMUGEwWkdDVGs1cC9uZzhwMlI4?= =?utf-8?B?QnhDeDVISGZ3aFQ3dHp4aVFZckxCcHFTTEROb1FPeVNCamJac1RPTFBJcmdh?= =?utf-8?B?NWxUK2k1NXJFTXQ1Rkd2Ymw0Q25BSExBQzlxYk5YY1k5S1pUb0xuajBzbG9D?= =?utf-8?B?OGdqeUdrekFOREdBSkpTWWdwQ3R5Z0RwZTNoZDMyVVB5d0srMHNudzFNTnVs?= =?utf-8?B?OFBKbThTRzExTVk4andjdjI4cXlhajNZUWlRSVlGbmlJR1BMcTd1WGdrMGVl?= =?utf-8?B?THhIWU5Gak1OTkM2cWdtU1ZIbXlUN0hic2NUbkJtZjhUS0F4UTNRUEQ3My92?= =?utf-8?B?cTJvQ2E0WVFYTGhldk5ySDFlVzhuTDRpU0NhL0lZdjBRQzg0TGtBT3pCOGdx?= =?utf-8?B?aWFodCt1dkx1OXBaTVMwVXFnZy9DS3cvcWk3aDdncHUzRFJiVWJvWE1JR0ZT?= =?utf-8?B?R0ppRnhvWmZuYjlvN3RpMnIzb0lkcDdJcG9iKzl0ZE1tbk1YeW14bFRQMXJu?= =?utf-8?B?OTZJS09ZVS9BaGlFWmhISDB1Y2NLSXVXenZrd3NXcDFUejNYelYrRXBLdnhw?= =?utf-8?B?andtNUlBcmdkSlVuVGNhQnhDdy8rVUxmcE1GYmN2QTYwTFQyWlNwdXRoOWNq?= =?utf-8?B?ZUkrOGpPN29zMTNZbWlCYjRVYWFZbDg4aGg2M29mQzdYWVQ0RDA0SXY0bFpz?= =?utf-8?B?dmtRd0ZaYVpRRCsrbzlxYzRLM2JvUnZvSFdFUkd5cWl6MzJ3OFZQelpxMFgx?= =?utf-8?B?RHZoOXZzZUphcXRKUnJuVGtCR1p4TEJsNXlGYWNmU3c5bldERmxibzNXa0Vh?= =?utf-8?B?c1BSSWd3REtMU0xxMUtnVTh1RGYweGZJb2VucndWYXU2eTlZOHpyTWJJb28w?= =?utf-8?B?RGc3NzR0OWo2V3NHc3pOci9PekdobkdSSTVodmRtK0pFVkFFVWRiYjlPd1U0?= =?utf-8?B?UkhJbzFxRmltQ3l3d1JTdXdsaGljb0l0MHVBYm9yY1QxY3NXWGVFM3paZ1ZU?= =?utf-8?B?eXRiWlptTVpIdk9GVjYvU1Fka1JGUDVJUGZDTWRlYVVlN3lUT3hUS1dJczM3?= =?utf-8?B?K1dWbDk3aEp1SGppMk1lZzczWXR0dnlEVzk0RlY1RE1Wa0hFZDN5UUtpR1hP?= =?utf-8?B?ckVBbzVFWWxLa0VTem9pbmNRajlsWWVZajEvNkthZFY0TGZvV3Zkcld0d2tJ?= =?utf-8?B?Rit2ck9OR0pZWVQ3b0hXeFV0VEVwM3hvNFY1Zk1kRURVQWRCSjRxWTRjdzRy?= =?utf-8?B?ZlhPZGo3RUUyazVVKzFpRkxJMFJFUHB3RzV2WEJEeENyaFNTWFJnbzBOVnM2?= =?utf-8?B?Q2o3R3YxUkZRSkFERmN1TW1JdXpveHFidXBQTWxnam9IZHAwWlZYK3hwcE11?= =?utf-8?B?UXVmSDF6WlVFbExnM3l0OE9BbnBTQWxJUU11UzFZWFRxNnZHR2ZDcmR2TnB2?= =?utf-8?B?U0d5USs4cXovT0xwVEErYnoxaVdFazNQdzcwQkFpRTEvWEV3ZzQyMGE3U05N?= =?utf-8?Q?FheAvB8KWyCVqvvA=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84c91296-d62f-4b61-6c93-08da3f089bc2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 11:12:23.3094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tfwr3fYZuh+tbeBpJzMNMUOmGmTleqFLZSW2Ni3hDecWMqVc5Oj3xu8wpGTG+lXLc8gkuXvoPhHeMNGI3K8rFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6527 Add support for enabling Bus Lock Detection on Intel systems. Such detection works by triggering a vmexit, which ought to be enough of a pause to prevent a guest from abusing of the Bus Lock. Add an extra Xen perf counter to track the number of Bus Locks detected. This is done because Bus Locks can also be reported by setting the bit 26 in the exit reason field, so also account for those. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v1: - Adjust commit message. --- xen/arch/x86/hvm/vmx/vmcs.c | 4 +++- xen/arch/x86/hvm/vmx/vmx.c | 18 ++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 3 +++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 ++ xen/arch/x86/include/asm/perfc_defn.h | 4 +++- 5 files changed, 29 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 56fed2db03..d388e6729c 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -209,6 +209,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_virt_exceptions, "Virtualisation Exceptions"); P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); + P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); #undef P if ( !printed ) @@ -318,7 +319,8 @@ static int vmx_init_vmcs_config(bool bsp) SECONDARY_EXEC_ENABLE_VM_FUNCTIONS | SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES | - SECONDARY_EXEC_TSC_SCALING); + SECONDARY_EXEC_TSC_SCALING | + SECONDARY_EXEC_BUS_LOCK_DETECTION); if ( _vmx_misc_cap & VMX_MISC_VMWRITE_ALL ) opt |= SECONDARY_EXEC_ENABLE_VMCS_SHADOWING; if ( opt_vpid_enabled ) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index f08a00dcbb..476ab72463 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4065,6 +4065,16 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) return vmx_failed_vmentry(exit_reason, regs); + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) + { + /* + * Delivery of Bus Lock VM exit was pre-empted by a higher priority VM + * exit. + */ + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; + if ( exit_reason != EXIT_REASON_BUS_LOCK ) + perfc_incr(buslock); + } if ( v->arch.hvm.vmx.vmx_realmode ) { @@ -4561,6 +4571,14 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) vmx_handle_descriptor_access(exit_reason); break; + case EXIT_REASON_BUS_LOCK: + perfc_incr(buslock); + /* + * Nothing to do: just taking a vmexit should be enough of a pause to + * prevent a VM from crippling the host with bus locks. + */ + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 9119aa8536..5d3edc1642 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -266,6 +266,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS 0x00040000 #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 +#define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -345,6 +346,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_XSAVES) #define cpu_has_vmx_tsc_scaling \ (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) +#define cpu_has_vmx_bus_lock_detection \ + (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) #define VMCS_RID_TYPE_MASK 0x80000000 diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 8eedf59155..03995701a1 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -159,6 +159,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) * Exit Reasons */ #define VMX_EXIT_REASONS_FAILED_VMENTRY 0x80000000 +#define VMX_EXIT_REASONS_BUS_LOCK (1u << 26) #define EXIT_REASON_EXCEPTION_NMI 0 #define EXIT_REASON_EXTERNAL_INTERRUPT 1 @@ -219,6 +220,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_PML_FULL 62 #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 +#define EXIT_REASON_BUS_LOCK 74 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index b07063b7d8..d6eb661940 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 65 +#define VMX_PERF_EXIT_REASON_SIZE 75 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -125,4 +125,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") +PERFCOUNTER(buslock, "Bus Locks Detected") + /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 26 11:12:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 11:12:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337558.562209 (Exim 4.92) (envelope-from ) id 1nuBQ3-00049n-ET; Thu, 26 May 2022 11:12:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337558.562209; Thu, 26 May 2022 11:12:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBQ3-00049c-AZ; Thu, 26 May 2022 11:12:43 +0000 Received: by outflank-mailman (input) for mailman id 337558; Thu, 26 May 2022 11:12:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBQ1-0003PI-76 for xen-devel@lists.xenproject.org; Thu, 26 May 2022 11:12:41 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c05d9a1e-dce4-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 13:12:39 +0200 (CEST) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 May 2022 07:12:33 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6527.namprd03.prod.outlook.com (2603:10b6:510:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:12:31 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:12:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c05d9a1e-dce4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653563559; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=h0uFhd5dy2NQgfu+ARn99X6LxjDQPABc4PMm+Xx5S+A=; b=fRs8gOkUYuCIlqslAZmUDQ1v0MNZQNiH1vLH4l+4f/playskxWSrQbUu YbiaddQkrJ0m1kjezsYBJnkXSDku0h3fecx5tjLLRovdXTZoi9trNnC8l 5PzsIuB0VQy5xE5UDiTofzKobHiB+dan6nurIgojcXy3t7PDsbTvaaZvU k=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 72087942 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YSfgf6Lg7piz4muwFE+RE5QlxSXFcZb7ZxGr2PjKsXjdYENSg2QCy GIaXmmHP/2CamD8L9wjb4qy/BxUuJHTxtNqSwplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Q22YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MVdtpqMdVgnAo73sfggaTYDNgEhZaITrdcrIVDn2SCS52vvViK1ht5JVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM6FGvqRjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SOnI2IJ9Aj9Sawf8kWLllEh2uTRLf35fuLWV99pgWC0q TeTl4j+KlRAXDCF8hKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTifuzh1O6WtlfA 1cJ4Sdopq83nGSpU938UhuQsHOC+BkGVLJ4CPYm4QuAzq7V5QexBWUeSDNFLts8u6ceWjgCx lKP2dTzClRHsqCTD3SU9b6WrDa7ESkTMWIGIyQDSGMt4NT9oYd1khPGSP5iFrK4ipv+HjSY/ tyRhC03hrFWhslS0ay+pAnDm2j1+cOPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:0FlOsaz028ys3BEqSXcKKrPxpeskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vV2iIBzADQCkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6kvouqhND6Ws3N 60Q5iApIs+MPP+UpgNdNvpOfHHbFAlYSi8Rl56cm6XXZ3uBRr22uzKyYRwwt2WU7o167Z3sK j9cTpjxBsPkgTVeICz4KE= X-IronPort-AV: E=Sophos;i="5.91,252,1647316800"; d="scan'208";a="72087942" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FbmZSxdYTfn8Zvb8yIRbonm+MFX3UpPv9HiqYoz3hNCcIcZ32qcu4qig+LMkYvKXFBQk/VVcaxyH7X8vOHG86TMSq5TmY0xiAWMuGu39Xg6/CXPat05Dn1SjQ+Wc36IwsRaU/DZ7S8Mz/8mkBQgdV2EPgZun7ZnyURWxcbj1uikjJWDC6hJmyTX0fMbOjtzznnttYcb0NOZlcH8rcwusEkYIeVKyYCZV0fxwWJCE5vYlGWAdNtQzMgvt/a11TNQ7R6yJWlGxXyR0K6dD+0itLVEFv8YviU1p4ue6Y0iBZslhoOknXLUHU8E+MPUFi8oaXS05a+naYU/vRmlzOSV4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZghJ9fryPIa1AdgB3JRhsQ84q95rsW5MylO7wo4jpQ=; b=KTMgwgrznYk931H/JkQwm1q3xTaIFhs6auCkD8Naqa276ExqAa4uaPnn77BmHAjE2QiAR26wxS6GHiqFP+BzLcuJkM8mkOcw6ixk5SDenU85NhhERCKSQeBnzwdTL/MXF7xc5dAZnqgu3QLZ1JMShK8FezhH4dxBU16PL2x5+KNNqYMqzjcfwBCQlJPVHRtWIpaKzVDrz5SL1IOF+C9voh+rtAAxLucc9XHZjZhcOjjCBaeZr8JfqrZrmqeT61XxB95scefahvtZeQelL8DqsxtqB89zGm3/sFzewVXnnQXW9i34Sf8q5TTT+lHbFhdymv9F+vbthby3PFJYV1K4yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mZghJ9fryPIa1AdgB3JRhsQ84q95rsW5MylO7wo4jpQ=; b=oqrTTQ12kHdF7KhnuI7CPbJvrOzIpjQdDnYudDdfTMQhKRo7qiw+02k1qy2c5O+Uv63jS9EIh5gUlrHSSlTphFRbf38aTdHyLzdhgRWDQhuDZ48mG9SX87Y14S8HuBV4msgNtxOIjhwLxicOZnk2QqFFxyUaMiwhbwOOhRBMLLQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v2 3/3] x86/vmx: implement Notify VM Exit Date: Thu, 26 May 2022 13:11:57 +0200 Message-Id: <20220526111157.24479-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220526111157.24479-1-roger.pau@citrix.com> References: <20220526111157.24479-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0198.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::23) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12ca42e3-2f33-45b7-ada2-08da3f08a074 X-MS-TrafficTypeDiagnostic: PH0PR03MB6527:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6nS0DZcUCc9cEhlR81kAleL8vNOZNR1tyqp/QXis91rOPTls6vgrqMFxyk0b3l0eVCK6Ls9MxuaQpI/JI+DQSwZrdYkENLmVRcoIbk6FqNzYlImG0SE/dJNClljfqGbSEpLHCDjGJLrknYh9uyq+GaOav5oqaUBHnTGtzqYk2ddr3+gZgsEKXn+uokZDEw09xJxj2E6n8wESTjGgurzvBAPcECTLOfZtM/KulslJBwogeH7z5RWO1mkwYDWlvpwIkhCLMYYgVKGxCe6S7DKvI9DxhJN16IlrXV9qU25OaHEUNb5Ck4VSNIMkoGdeLnB4Oes+dkifZKmDTgaiEXN7AiRXPZ+qiwbHCKYizNDoDmcdEXHQ3pgtVEBGi10md1wKicSD6XkyMWpJZM9hyz928l/zfF0kY5Li6srLysvXbDTq/WNBsquVgul2Pz6Y47LLxSgl4uRV89j6spz4Dqtumkv/v+YKR3cl/j0BhvqfWxOFNFhImGv182K2eiDTl197RAUTsCb6ReOwpGnfSITxvq/guvEZ5l7PaE+0luitE86XyxuL3cFh7ZaZmW1Ok0ZvJP4a8YDRXDcDTz/8RGT1PwLFXd/N6m2ndIV2YH1C31LF7CQvI4s+qm6qgRTUS0+nUYUkGTblc/YexoMRJRxXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(86362001)(4326008)(66476007)(66556008)(66946007)(8676002)(8936002)(54906003)(316002)(6916009)(38100700002)(1076003)(6506007)(82960400001)(6512007)(26005)(6486002)(83380400001)(6666004)(186003)(508600001)(36756003)(2906002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGwyQytkYjQ2UWk3eEJCdFBFYmVMczErQWEvTGo4TkhraUFJWkgrQzRkZjI0?= =?utf-8?B?MmQwSE5wSmpEY21vUVcySytrTXkva29QalVINmlVSm1UWk5BTmNVWHVZa1d4?= =?utf-8?B?WXFoNGYzbnVialJnbHI0b2RGZHpyTXJ6YVBkdHNPQ1JrZ0txZERqVEZoa1Fy?= =?utf-8?B?ZGlsN25LaHUyYmQ3ekxwVkxCZitjei9ycUhJM3JXTWJub2U4OUplbmNtbGVu?= =?utf-8?B?alRpL1dZZmRWWjhUUytqSFd1SE1aWSt3MmpJRTRjS3BDQW13SVJxSk90aXEz?= =?utf-8?B?b0VuelhCUkNXTnBuY3ZGZUFFMEZ2aXhkN2ZRS0IxOG4vU1JUNmwvcnFjSGdu?= =?utf-8?B?ampLSEVENndRSmNvWFVob3VuV2FvTnYyVkswWlV0ZUphbXJVYys5YTRNS2ZL?= =?utf-8?B?NjI2ZWZUdm5XYm1RejdBMDQyd0g1WElLU3hNbS9BdWRnL2h0ZFJ1Y0cwM3Jn?= =?utf-8?B?YS9mWGdlNjNTQTQwS0VoRkwzYUovWnQ3YzBwRExSSHM3MGRNWUZsdHZ5ZEFT?= =?utf-8?B?VkxLRmdOVk5rOFExVEFEc1hPclVoU05FM0ltRFFIVWJOVU1ESWtXOEdhU3Ji?= =?utf-8?B?M1Zuanoxd3l5Ky9xeHRBbWFCU0t4NkRIckh4b2NPMmo4UU5rSHJqcGUvckkz?= =?utf-8?B?UXhZUDdlcTd0ajdVNjU1NzZwWkFoYWdvYkdsNktQdHpQNVhvZ09KWkpmZEpl?= =?utf-8?B?OXQ0d3FSYlFnenVDdHNENDVzVERla1ovWWtydUVqUjFFMytyWkpRcVdQcjRr?= =?utf-8?B?WjhvVUtOaDh2WUgzeUtZejZBMytMVmxLNm5NNGx4L0t2MEdnbDB6NkRGZUtt?= =?utf-8?B?WnRtaHZlQzlHWGRjZURlWVY4NE9Ua3lNL0plcGhYZGE1amE4UFkxQitMY0xr?= =?utf-8?B?NnM1NExXb1IvQWtaVVJnZjh5UTdxY0FobDZwLzVZcGxudDBsenhKRTFzRVRt?= =?utf-8?B?dFAzSEJCZXFvRFdQSVZORy9UbEtlbDhNL3Y2QjR2MC81NkR2c0R4RXN0My9i?= =?utf-8?B?cFRRdmZSWUdUU2x1eE52ejE5WHhyN2xMOTlqeXc5ZjRsRTJrc3RLYkorSGdi?= =?utf-8?B?elJwcjJYZFNTRUxwRFN1UmU0KzBjbXJxTnNzNTdKVjduQS9hSUNDTU50Zm9i?= =?utf-8?B?cy82L3hpeFhYZ1F2NmdkeDIyUnRBZkZkc0NzVmZxVm1LSEJ2elNsZTB1N0VE?= =?utf-8?B?eEZ3L09qWWdySkxER1djZnRDYXhqYi8wMHh1aTZDRFBDNi9kSHZZWEJrYzBv?= =?utf-8?B?M2Y0aGc1K09Vd0FWV2RvK2JPOUhaS3B3Wmg4ZGVCT2lLL0phV2lUWEJnMjFN?= =?utf-8?B?MFUyd0hzcElzWHR3WFlJNVZNSmlQNlg2c0k2VXJOcm16Y0hidnBNUlAwajh4?= =?utf-8?B?WWxtYStTYlU3SHpLODBldHZTbzIwVlNIU3o5dVQvbUtEYVYvLysvVHl5SllX?= =?utf-8?B?RFNCcFJmLzlITVFTVkxIc1JXV2FtZVZWWWVkbjFtdjdlaGtBZ3FkVFlnNVpr?= =?utf-8?B?TllRb0pMbG95UmlvWCtpYVFpcVVnM3llQzBUazd0dHZ1YXRxeFNCWlVoUUN2?= =?utf-8?B?OGx6ZGQvT28wRXhsbksvcmdhdUlUNUxGTUdKT01HRnNoRGRCb0JzcTM1K2Jz?= =?utf-8?B?Ykp0aDNYdk56aldkNnE4NlZ5WWlscFBOWE10K0xNR09VS3N0WWwxZzhUWlF3?= =?utf-8?B?S1RiV1I4dlVZTGdqbjJ0c3lIZ05hbmttWVpBVnhHdS9SRmE0Ky96TnZSYUUw?= =?utf-8?B?QWdjNnUwVzRBRHJMS2hlMmQ4Q3JpaEV0NmxwYzdQazJoMG5PUHo3TjJraWpQ?= =?utf-8?B?bHFLdjlxemMwUUZMcDgrbC9PSWtEUlFmVFJFL3Zid1dzdEVFa2tIWGpFbnpM?= =?utf-8?B?a2Z6VHVqUUd5L0ljNjdnQnBRRG5WREZFSkpNNWhra2RrK1RDTHB1MnFGSmdD?= =?utf-8?B?Rk8rakprVmxpZXFjU0l6YVV1T3A2a25HWElGdEF2dCsxNmpXaHE3cEdKeW1y?= =?utf-8?B?Z0daVEs3T3ZvODFvODNjRVpZWko5Zy84ZkhBK2pOY2RGekhiRGtFdk9aQ3dH?= =?utf-8?B?V3FJMmllNnhDVzdWdG0xMGVXakVZYWZpN041WFB6dVRXMElEMEZyb0lTZlZI?= =?utf-8?B?aXhFMWthcGg3WXAveExzNGM4ekRYbUJyZWdQSm50UXRRaGg4QmI1amt4Wk5P?= =?utf-8?B?d2tGUFlMUmZXWkdnejFrR0Z4OTlwcHlZS3lNbUJ3L3RuczJOYmorMUdHZmNU?= =?utf-8?B?SXhDd3MrRjZSaWFBOTk1elNIWnZubWNRTzhOOHo4TFBJWCtVWWxmL0w2SjJy?= =?utf-8?B?N1pDdlVsc1JSUjJPYjR6ZTNGYTZ0SkpjVktZblNUNXFRUncrbXMzdFBWSHpS?= =?utf-8?Q?uUQpoMddwGGF1P9U=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12ca42e3-2f33-45b7-ada2-08da3f08a074 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 11:12:31.2042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8i0ex93hCohlQNPjEICGZBhMqGCjDu+UeuKyDnOJQtgzpGqi8zNnBKk0kuIgIgyFXz4Vw4v55avqGuAhDCQD/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6527 Under certain conditions guests can get the CPU stuck in an unbounded loop without the possibility of an interrupt window to occur on instruction boundary. This was the case with the scenarios described in XSA-156. Make use of the Notify VM Exit mechanism, that will trigger a VM Exit if no interrupt window occurs for a specified amount of time. Note that using the Notify VM Exit avoids having to trap #AC and #DB exceptions, as Xen is guaranteed to get a VM Exit even if the guest puts the CPU in a loop without an interrupt window, as such disable the intercepts if the feature is available and enabled. Setting the notify VM exit window to 0 is safe because there's a threshold added by the hardware in order to have a sane window value. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v1: - Properly update debug state when using notify VM exit. - Reword commit message. --- This change enables the notify VM exit by default, KVM however doesn't seem to enable it by default, and there's the following note in the commit message: "- There's a possibility, however small, that a notify VM exit happens with VM_CONTEXT_INVALID set in exit qualification. In this case, the vcpu can no longer run. To avoid killing a well-behaved guest, set notify window as -1 to disable this feature by default." It's not obviously clear to me whether the comment was meant to be: "There's a possibility, however small, that a notify VM exit _wrongly_ happens with VM_CONTEXT_INVALID". It's also not clear whether such wrong hardware behavior only affects a specific set of hardware, in a way that we could avoid enabling notify VM exit there. There's a discussion in one of the Linux patches that 128K might be the safer value in order to prevent false positives, but I have no formal confirmation about this. Maybe our Intel maintainers can provide some more feedback on a suitable notify VM exit window value. I've tested with 0 (the proposed default in the patch) and I don't seem to be able to trigger notify VM exits under normal guest operation. Note that even in that case the guest won't be destroyed unless the context is corrupt. --- docs/misc/xen-command-line.pandoc | 11 +++++++++ xen/arch/x86/hvm/vmx/vmcs.c | 19 +++++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 32 +++++++++++++++++++++++-- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 6 +++++ xen/arch/x86/include/asm/perfc_defn.h | 3 ++- 6 files changed, 72 insertions(+), 3 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 1dc7e1ca07..ccf8bf5806 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2544,6 +2544,17 @@ guest will notify Xen that it has failed to acquire a spinlock. , and must be integers. The values will be encoded in guest CPUID 0x40000002 if viridian enlightenments are enabled. +### vm-notify-window (Intel) +> `= ` + +> Default: `0` + +Specify the value of the VM Notify window used to detect locked VMs. Set to -1 +to disable the feature. Value is in units of crystal clock cycles. + +Note the hardware might add a threshold to the provided value in order to make +it safe, and hence using 0 is fine. + ### vpid (Intel) > `= ` diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index d388e6729c..6cb2c6c6b7 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); static unsigned int __read_mostly ple_window = 4096; integer_param("ple_window", ple_window); +static unsigned int __ro_after_init vm_notify_window; +integer_param("vm-notify-window", vm_notify_window); + static bool __read_mostly opt_ept_pml = true; static s8 __read_mostly opt_ept_ad = -1; int8_t __read_mostly opt_ept_exec_sp = -1; @@ -210,6 +213,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); + P(cpu_has_vmx_notify_vm_exiting, "Notify VM Exit"); #undef P if ( !printed ) @@ -329,6 +333,8 @@ static int vmx_init_vmcs_config(bool bsp) opt |= SECONDARY_EXEC_UNRESTRICTED_GUEST; if ( opt_ept_pml ) opt |= SECONDARY_EXEC_ENABLE_PML; + if ( vm_notify_window != ~0u ) + opt |= SECONDARY_EXEC_NOTIFY_VM_EXITING; /* * "APIC Register Virtualization" and "Virtual Interrupt Delivery" @@ -1333,6 +1339,19 @@ static int construct_vmcs(struct vcpu *v) rc = vmx_add_msr(v, MSR_FLUSH_CMD, FLUSH_CMD_L1D, VMX_MSR_GUEST_LOADONLY); + if ( cpu_has_vmx_notify_vm_exiting ) + { + __vmwrite(NOTIFY_WINDOW, vm_notify_window); + /* + * Disable #AC and #DB interception: by using VM Notify Xen is + * guaranteed to get a VM exit even if the guest manages to lock the + * CPU. + */ + v->arch.hvm.vmx.exception_bitmap &= ~((1U << TRAP_debug) | + (1U << TRAP_alignment_check)); + vmx_update_exception_bitmap(v); + } + out: vmx_vmcs_exit(v); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 69980c8e31..d3c1597b3e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1419,10 +1419,19 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) void vmx_update_debug_state(struct vcpu *v) { + unsigned int mask = 1u << TRAP_int3; + + if ( !cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) + /* + * Only allow toggling TRAP_debug if notify VM exit is enabled, as + * unconditionally setting TRAP_debug is part of the XSA-156 fix. + */ + mask |= 1u << TRAP_debug; + if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + v->arch.hvm.vmx.exception_bitmap |= mask; else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + v->arch.hvm.vmx.exception_bitmap &= ~mask; vmx_vmcs_enter(v); vmx_update_exception_bitmap(v); @@ -4155,6 +4164,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) switch ( vector ) { case TRAP_debug: + if ( cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) + goto exit_and_crash; + /* * Updates DR6 where debugger can peek (See 3B 23.2.1, * Table 23-1, "Exit Qualification for Debug Exceptions"). @@ -4593,6 +4605,22 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) */ break; + case EXIT_REASON_NOTIFY: + __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) + { + perfc_incr(vmnotify_crash); + gprintk(XENLOG_ERR, "invalid VM context after notify vmexit\n"); + domain_crash(v->domain); + break; + } + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) ) + undo_nmis_unblocked_by_iret(); + + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 5d3edc1642..0961eabf3f 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -267,6 +267,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 #define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 +#define SECONDARY_EXEC_NOTIFY_VM_EXITING 0x80000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -348,6 +349,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) #define cpu_has_vmx_bus_lock_detection \ (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) +#define cpu_has_vmx_notify_vm_exiting \ + (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) #define VMCS_RID_TYPE_MASK 0x80000000 @@ -455,6 +458,7 @@ enum vmcs_field { SECONDARY_VM_EXEC_CONTROL = 0x0000401e, PLE_GAP = 0x00004020, PLE_WINDOW = 0x00004022, + NOTIFY_WINDOW = 0x00004024, VM_INSTRUCTION_ERROR = 0x00004400, VM_EXIT_REASON = 0x00004402, VM_EXIT_INTR_INFO = 0x00004404, diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index bc0caad6fb..e429de8541 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -221,6 +221,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 +#define EXIT_REASON_NOTIFY 75 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* @@ -236,6 +237,11 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ #define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 +/* + * Exit Qualifications for NOTIFY VM EXIT + */ +#define NOTIFY_VM_CONTEXT_INVALID 1u + /* * Exit Qualifications for MOV for Control Register Access */ diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index d6eb661940..c6b601b729 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 75 +#define VMX_PERF_EXIT_REASON_SIZE 76 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -126,5 +126,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") PERFCOUNTER(buslock, "Bus Locks Detected") +PERFCOUNTER(vmnotify_crash, "domains crashed by Notify VM Exit") /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.36.0 From xen-devel-bounces@lists.xenproject.org Thu May 26 11:24:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 11:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337589.562220 (Exim 4.92) (envelope-from ) id 1nuBb9-0006Ye-Fx; Thu, 26 May 2022 11:24:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337589.562220; Thu, 26 May 2022 11:24:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBb9-0006YX-Bi; Thu, 26 May 2022 11:24:11 +0000 Received: by outflank-mailman (input) for mailman id 337589; Thu, 26 May 2022 11:24:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBb7-0006YN-Pq; Thu, 26 May 2022 11:24:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBb7-0007mk-LW; Thu, 26 May 2022 11:24:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuBb7-0002H1-6k; Thu, 26 May 2022 11:24:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuBb7-0002f0-6J; Thu, 26 May 2022 11:24:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LsRm3Ua5C4eBPqSfcV8v6t4LxHKEulWXhJvphk2ItC0=; b=KRdSv63cXd9w77gIaLPCJuix72 ryBUQ7dILK6qN4iCzlGO7LbTZC8ArCIX22zAAaqF/agIYdHHgxhYODE29vcVZNFHnFK7p6RLrzZxn ea/LQqnnqJEyal8y8soFf6wdCRA0XQKgDJS2gs2KegxU4I1d6aUUytwSRJQPgNXrCtPI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170744: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=c781b025c099bf74e3808f518e8f53a4e4082607 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 26 May 2022 11:24:09 +0000 flight 170744 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170744/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt c781b025c099bf74e3808f518e8f53a4e4082607 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 685 days Failing since 151818 2020-07-11 04:18:52 Z 684 days 666 attempts Testing same since 170744 2022-05-26 04:22:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 109913 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 26 12:11:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 12:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337604.562247 (Exim 4.92) (envelope-from ) id 1nuCL0-0003L7-GK; Thu, 26 May 2022 12:11:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337604.562247; Thu, 26 May 2022 12:11:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCL0-0003Kz-D7; Thu, 26 May 2022 12:11:34 +0000 Received: by outflank-mailman (input) for mailman id 337604; Thu, 26 May 2022 12:11:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCKz-0003K2-HZ; Thu, 26 May 2022 12:11:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCKz-0000AX-FB; Thu, 26 May 2022 12:11:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCKz-0003fZ-3R; Thu, 26 May 2022 12:11:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuCKz-0007ea-2w; Thu, 26 May 2022 12:11:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2gI4Y7lkdpRICDZseU289oK7iRr6nNF7oLPjs5P0A98=; b=iTKGmVWO/RZNpkKtVpph6tOY/n 2uFV7g9X4gVCifoImfnU8+5m2DN+7mmGh+OORqiGmeh+ODd4iTAirGCayNN9dl0o7dNkIhmLiXRVN Y6m7uqlbyku7I855ybY/m952c7cBXG8FwtSl/Hop+iqyKMJmmBCl0JNVoefNwIcmsVrc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170740: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49399b101e38fb2c11478c849ffdaaace8e318a8 From: osstest service owner Date: Thu, 26 May 2022 12:11:33 +0000 flight 170740 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170740/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 170726 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170726 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170726 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170726 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170726 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170726 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170726 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170726 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170726 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170726 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170726 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170726 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170726 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170726 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49399b101e38fb2c11478c849ffdaaace8e318a8 Last test of basis 170726 2022-05-25 09:40:00 Z 1 days Testing same since 170740 2022-05-25 23:38:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Elliott Mitchell Jan Beulich Juergen Gross Julien Grall Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 49399b101e..49dd52fb13 49dd52fb1311dadab29f6634d0bc1f4c022c357a -> master From xen-devel-bounces@lists.xenproject.org Thu May 26 12:16:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 12:16:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337616.562266 (Exim 4.92) (envelope-from ) id 1nuCQ5-00045u-7l; Thu, 26 May 2022 12:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337616.562266; Thu, 26 May 2022 12:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCQ5-00045n-52; Thu, 26 May 2022 12:16:49 +0000 Received: by outflank-mailman (input) for mailman id 337616; Thu, 26 May 2022 12:16:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCQ3-00045d-EH; Thu, 26 May 2022 12:16:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCQ3-0000IY-C9; Thu, 26 May 2022 12:16:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuCQ2-0003pJ-PB; Thu, 26 May 2022 12:16:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuCQ2-0001ap-Om; Thu, 26 May 2022 12:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MUTzg/V+m7JwgtoM9fwjNWnOcrNoexO1m6XPTMkZS8s=; b=pkcjMAMWI0fnDDcof7nuZF5Uo6 9f2/yTzInjsUmXvFSbYAAJZUDHtElGaEw/hCATaOiD3yrvOcrcdIM351ZDDP2FcnWNr2SbYhc0VU8 kpgFJU1Z8G9nUeyplHPmy2s9EivfhFJUfb0IsWRCdmG0MUYWs4tGsO/2nCZ77gGWJpIY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170746: all pass - PUSHED X-Osstest-Versions-This: ovmf=16779ede2d366bfc6b702e817356ccf43425bcc8 X-Osstest-Versions-That: ovmf=07c0c2eb0a5970db614ebce1060fc79d6904bdfd From: osstest service owner Date: Thu, 26 May 2022 12:16:46 +0000 flight 170746 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170746/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 16779ede2d366bfc6b702e817356ccf43425bcc8 baseline version: ovmf 07c0c2eb0a5970db614ebce1060fc79d6904bdfd Last test of basis 170733 2022-05-25 17:10:19 Z 0 days Testing same since 170746 2022-05-26 10:11:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jehl Theo Rebecca Cran Theo Jehl jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 07c0c2eb0a..16779ede2d 16779ede2d366bfc6b702e817356ccf43425bcc8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu May 26 13:05:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 13:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337626.562276 (Exim 4.92) (envelope-from ) id 1nuDAw-0000g2-UT; Thu, 26 May 2022 13:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337626.562276; Thu, 26 May 2022 13:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuDAw-0000fv-RQ; Thu, 26 May 2022 13:05:14 +0000 Received: by outflank-mailman (input) for mailman id 337626; Thu, 26 May 2022 13:05:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuDAv-0000fp-BB for xen-devel@lists.xenproject.org; Thu, 26 May 2022 13:05:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061a.outbound.protection.outlook.com [2a01:111:f400:fe0c::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79aee57e-dcf4-11ec-837f-e5687231ffcc; Thu, 26 May 2022 15:05:12 +0200 (CEST) Received: from DU2PR04CA0054.eurprd04.prod.outlook.com (2603:10a6:10:234::29) by VE1PR08MB5869.eurprd08.prod.outlook.com (2603:10a6:800:1b2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 13:05:08 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::3b) by DU2PR04CA0054.outlook.office365.com (2603:10a6:10:234::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 13:05:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 13:05:07 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Thu, 26 May 2022 13:05:07 +0000 Received: from 93ea2d3eefb9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7AA5356A-0180-45D4-8C9B-CA5F1955BC7C.1; Thu, 26 May 2022 13:05:01 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 93ea2d3eefb9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 13:05:01 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3166.eurprd08.prod.outlook.com (2603:10a6:803:42::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Thu, 26 May 2022 13:04:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5273.023; Thu, 26 May 2022 13:04:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79aee57e-dcf4-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a+Li1gpV1JX4wx8Rl9pipUBBg9iyBXfA88gktk3+OipbniDDMws0hpkQ3mh/XCnt1xGVSnHP9JXsGxeeFUD5bB/bOZHv6eTA6sZRq+0K/qYGldOEd4b3kgJGd+0/aeafyhg+pUU8zFOwuwTW6vbAksAKOWVOGQ1oqjusMWutv2StG//pDIzIoFsHpiL+u+Ss7gs2vakHBl7AyOgbhYn6f/mcK5dycYKosaaSer3NUUW7YR5wJIP5PuG1f0gWtrZLYqHOzmOBR8sRlnnc4C34/NC18M9Bv+Ca8tcK+nin3o1Wc2LUQ38xQGbkpO24ObuUZID4RDvVxwAMpFAYT+AAJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jay3+7lyNDMyBDzDj/eGQXTyToY8fHMYY10srTpnBY=; b=JAq/PTFYBx3lJtBGh0NsXe0O3zyRGGq87Sf7a04qw5oxD4V/l6aBLWE5tFXrOJ/QOxtwn8YsICbSu4iXe0lAEMocH+MPKX7iiA2Qg2YO6s97lmDJy+gYHzlic7hX+CVZYc+OqQdYY44fUbVeLo5zrUPEes6c1JmkQfp9/JGB4u87j7DFkdBXdpQJm4KGGvRltEGGLtQoOdv98rKbnEtgX5WGLojBS0U3CQH7YVt68TQfu4mNK/zKQjJRAGAL54RYFIC5slepJ7pOmDjnrupDhQBaOWk7Myo+hCdputfS/MS5kGEnusyRXuNMXUL865XTrhL6aKIZXr1WCl7Ps86Tqw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jay3+7lyNDMyBDzDj/eGQXTyToY8fHMYY10srTpnBY=; b=Ro5WTmTB7nbnc5zoHUrZlNuoTozq1DHCm5H7gNsg4uq/PZvDUgsrlCVRqd3iNN/aNEpzTNElyRtK8+KC2vT5jSzQ45ezqy7o2m/8SGmNHJNwtacsdBXZx3xPgkqDVAqPF294G24gf/Y7tJhx/N8lRedRo0c5FVODVFcEoHntVuY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a8cb319dfa5a5d28 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGqQ/SMISuo5BXWNGl3VbmJL8bjcuhywdAnNLCjYOg/m/JUTKWGctxSJlTWkE2yRE9qxwStWqqB5J368NssQUdvgzLypd1Y1vfwHnh9UERVvlB7AYMn4khStYa8J6zkY5WklmcFj9ReBcFRfdGWYgTsE8VkjfaXdG00l6rpn1hv8FNbRSsGLV5jUr9jt1eae6o9GU/QFR5+JTeyGrBCI3s9vuTVKGoFY0yoLRmTbif3aplQOa2dfI/NiR0CSH//62VqhRrBBDDCIY0s+GL78TWXuaAg031AsdcsEhCOLGhFwSNzAyftsGFXredFAuK8/2OY3PlYnyZUAaUXiI3Y0ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jay3+7lyNDMyBDzDj/eGQXTyToY8fHMYY10srTpnBY=; b=RQ73MFKATlijdIGlxOO7MmKY6M/Q1aIfyT2sD7gGSik/JS7WAomZkLuJD9wfBKtwC70wr2yjGnDdUUU7Amo5M2IQQgFKVjzrpJC4HMbtvJ5fyYgCULHpDN97Eyp1sXAeJQxCitt4ep/TX1YJxmtTzLpPWJiZlw0xwOJh/t1TNVLAmkFg/qPD8G/zGy5m4668TpB37n7idDrUSmF61g9RR6ULo1RdmEH0sNEixlCrFuq9xPoQ0OC5rvtCd34nCMQD3EZq2mSJ1NFcqPS9hZMHyBbqXhg65+dz25l9czjU3N042rjSSwrU7sKpx43oTzzvQBT8VGDeRqGNJdhG7OYXeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jay3+7lyNDMyBDzDj/eGQXTyToY8fHMYY10srTpnBY=; b=Ro5WTmTB7nbnc5zoHUrZlNuoTozq1DHCm5H7gNsg4uq/PZvDUgsrlCVRqd3iNN/aNEpzTNElyRtK8+KC2vT5jSzQ45ezqy7o2m/8SGmNHJNwtacsdBXZx3xPgkqDVAqPF294G24gf/Y7tJhx/N8lRedRo0c5FVODVFcEoHntVuY= From: Bertrand Marquis To: Jan Beulich CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Topic: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Index: AQHYb89Ql1y5oYxB8EW1dQIiqL2u/a0vNXYAgAEjhQCAAJGbAIAAAxAAgAAFpwCAAC97AA== Date: Thu, 26 May 2022 13:04:58 +0000 Message-ID: <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 08fcf54b-e2ee-4323-bc2f-08da3f185ba7 x-ms-traffictypediagnostic: VI1PR08MB3166:EE_|DBAEUR03FT038:EE_|VE1PR08MB5869:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SiNqW169BjW3+h05qGKLyKoz7ZuDdmU7raaVASauII1mdSQ6KAoOrvZqikeUGyFxksH/rTkixhuemfxiiuhe/k9779eTwbhtjPHWh4qokkaa6gEM3mRzTNc4yrzZNifP9QdcZ1UVXoiGnpnEUjhoNFGoIUVR7RUfy9A4TUvcAVI6ieeTmKIe7tInvB4C6yL/3+xyL3s0zPv4CCLzeya9svT0af9eO6MdVIyK9JzTnM5EWLItYE5XxyUQLzmO3VyDUKtneD1jznmrnKjB8m5suy+XzTIud/SFu0MOwQQIR8rLbFrwO6ttdtSsMNYEZMfEToMT6TmLgk1h0jykz4sOaydeOToT8nO9sQ53STR4CjW0U5ZbNG4rXc5dUESUENIzw1wfSJKC2s9U4xGAptXVbV8p8mxLTF/auTqmtNYE5RyoJO9aAXYYCFPN++AfwFEcnhebmSXdFpBSCuRYYFpz0rsRcVi7hGKpB+xkfQjCGjUOH0q7u1hhUb/GcWzem3hvOcHo4UT2jZp3+7lAXhVdy+c3Tb+K8hzfw9zEPQB+1MKIm6AwIfDDCdqut4lamtXzVpjDyYJk7KVusKq1t92G5SubBsR7uw8LLP/eoCr6PTl9N9bvfOXouLWOLWw4CWelIeXe1qlCsk/kUFBI3CHVoH5229ba6vJNfHeAdLmHiQbUanBGXPZEbPLyRxJX8zuJ7y0+XvE1d+sj0tVUSgr50HrJbAbUJvf3Xz+XIUi/F7kWVIVNYOETmDRBSD3AYaH79UoYzRrRDQa2jlPw3K1YnrZZ2K/EkIEdFglMByFTUOIrrL9PyudGUYasrgY53IXo X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6512007)(53546011)(6506007)(186003)(86362001)(2616005)(2906002)(6916009)(54906003)(316002)(33656002)(66446008)(91956017)(76116006)(66556008)(4326008)(66946007)(64756008)(66476007)(8676002)(8936002)(5660300002)(122000001)(83380400001)(38070700005)(38100700002)(26005)(508600001)(6486002)(966005)(36756003)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <4AB0B17C1B79A5469ACB56C4E1EBCAB6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3166 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e03dff5d-b94a-4c37-ea6d-08da3f185689 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HOTDr+q0MEfdiBOIqwXjFYbbUyJC1WPvGXZATPcYLsbrAaeSOY9gPnDNFi40dJLsnl7ZuoRG4dNsf2Fc0yKsoLKBoUVtowpvEqK2b0PDg6eqKJvKAQLFobR/jUXRcw4zMWJ5mthjdCMbzz6Ktji0JQybrTawDn1sMfEURPTWTtZUTaLV1TWlgXqqbKmx+d73nCjX1Z48dWJ3kLApUsNntdw5w7DcEnBZXH5f2ihgswm1JJE97qAW3qDFJU4XeYqXI9bZTPMyp/WPCfiICBoyjtPXBmP0ei3lr8or5NYKwatbNeunC5kyRmyRVcx7zVDpImIlMKcVh+UGb45YUPGdWe2gWKJQP43qKjhuPjARc2MXqxNgNEK7AgjRTSjqsCB+0hUp2FjJr0PJ/QNlpJFOJdG1MDvr37g2GiqNM52nn53RKzHPr0jCArQkkyajNeXolKL9KsoT9cYciJy/TWylfmy7x+CnipUDcIxKeT0xb75WM64EZecdIprtaPQDzOmm2ymTDs7cjYS38CUWVIxXxU/zm/e3WpXNltMSRGCBXmmAc04Vikd3c0kXVUrbVWIrp2BQIs2VgZQ9pqpYc9NWal7HkiySIIkW8rYTE7IgjRWWje7evhpYh9WtpE3NnWD2BXGASlS+wKQoa18IobQ4PQdGbcP14MLrSLHUGcEEx5cQFZ0fwIIbATrnVK80pNyn4yx3bky1qvqOWfmiifQhDsj/RQbr/tpFpnEkb4FLneRh8whwxZtTw/yP4ulUF1uUUvztgqgRf9KxxlMtUFAS2Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6862004)(8676002)(47076005)(40460700003)(70206006)(5660300002)(70586007)(4326008)(6512007)(8936002)(356005)(36860700001)(508600001)(83380400001)(33656002)(6486002)(81166007)(966005)(6506007)(316002)(53546011)(186003)(86362001)(54906003)(36756003)(82310400005)(2906002)(26005)(2616005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 13:05:07.5830 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08fcf54b-e2ee-4323-bc2f-08da3f185ba7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5869 SGkgSmFuLA0KDQo+IE9uIDI2IE1heSAyMDIyLCBhdCAxMToxNSwgSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDI2LjA1LjIwMjIgMTE6NTQsIEJlcnRyYW5k IE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKYW4sDQo+PiANCj4+PiBPbiAyNiBNYXkgMjAyMiwgYXQg MTA6NDMsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g T24gMjYuMDUuMjAyMiAwMzowMiwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+PiBPbiBX ZWQsIDI1IE1heSAyMDIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+PiBPbiAyNS8wNS8yMDIy IDAxOjM1LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+Pj4+Pj4gKy0gUnVsZTogRGlyIDQu Nw0KPj4+Pj4+ICsgLSBTZXZlcml0eTogUmVxdWlyZWQNCj4+Pj4+PiArIC0gU3VtbWFyeTogSWYg YSBmdW5jdGlvbiByZXR1cm5zIGVycm9yIGluZm9ybWF0aW9uIHRoZW4gdGhhdCBlcnJvcg0KPj4+ Pj4+IGluZm9ybWF0aW9uIHNoYWxsIGJlIHRlc3RlZA0KPj4+Pj4+ICsgLSBMaW5rOg0KPj4+Pj4+ IGh0dHBzOi8vZ2l0bGFiLmNvbS9NSVNSQS9NSVNSQS1DL01JU1JBLUMtMjAxMi9FeGFtcGxlLVN1 aXRlLy0vYmxvYi9tYXN0ZXIvRF8wNF8wNy5jDQo+Pj4+PiANCj4+Pj4+IA0KPj4+Pj4gLi4uIHRo aXMgb25lLiBXZSBhcmUgdXNpbmcgKHZvaWQpICsgYSBjb21tZW50IHdoZW4gdGhlIHJldHVybiBp cyBpZ25vcmVkIG9uDQo+Pj4+PiBwdXJwb3NlLiBUaGlzIGlzIHRlY2huaWNhbGx5IG5vdC1jb21w bGlhbnQgd2l0aCBNSVNSQSBidXQgdGhlIGJlc3Qgd2UgY2FuIGRvDQo+Pj4+PiBpbiBzb21lIHNp dHVhdGlvbi4NCj4+Pj4+IA0KPj4+Pj4gV2l0aCB5b3VyIHByb3Bvc2VkIHdvcmRpbmcsIHdlIHdv dWxkIHRlY2huaWNhbGx5IGhhdmUgdG8gcmVtb3ZlIHRoZW0gKG9yIG5vdA0KPj4+Pj4gaW50cm9k dWNlIG5ldyBvbmUpLiBTbyBJIHRoaW5rIHdlIG5lZWQgdG8gZG9jdW1lbnQgdGhhdCB3ZSBhcmUg YWxsb3dpbmcNCj4+Pj4+IGRldmlhdGlvbnMgc28gbG9uZyB0aGV5IGFyZSBjb21tZW50ZWQuDQo+ Pj4+IA0KPj4+PiBBYnNvbHV0ZWx5IHllcy4gQWxsIG9mIHRoZXNlIHJ1bGVzIGNhbiBoYXZlIGRl dmlhdGlvbnMgYXMgbG9uZyBhcyB0aGV5DQo+Pj4+IG1ha2Ugc2Vuc2UgYW5kIHRoZXkgYXJlIGNv bW1lbnRlZC4gTm90ZSB0aGF0IHdlIHN0aWxsIGhhdmUgdG8gd29yayBvdXQNCj4+Pj4gYSBnb29k IHRhZ2dpbmcgc3lzdGVtIHNvIHRoYXQgRUNMQUlSIGFuZCBjcHBjaGVjayBjYW4gcmVjb2duaXpl IHRoZQ0KPj4+PiBkZXZpYXRpb25zIGF1dG9tYXRpY2FsbHkgYnV0IGZvciBub3cgc2F5aW5nIHRo YXQgdGhleSBuZWVkIHRvIGJlDQo+Pj4+IGNvbW1lbnRlZCBpcyBzdWZmaWNpZW50IEkgdGhpbmsu DQo+Pj4+IA0KPj4+PiBTbyBJJ2xsIGFkZCB0aGUgZm9sbG93aW5nIG9uIHRvcCBvZiB0aGUgZmls ZToNCj4+Pj4gDQo+Pj4+ICIiIg0KPj4+PiBJdCBpcyBwb3NzaWJsZSB0aGF0IGluIHNwZWNpZmlj IGNpcmN1bXN0YW5jZXMgaXQgaXMgYmVzdCBub3QgdG8gZm9sbG93IGENCj4+Pj4gcnVsZSBiZWNh dXNlIGl0IGlzIG5vdCBwb3NzaWJsZSBvciBiZWNhdXNlIHRoZSBhbHRlcm5hdGl2ZSBsZWFkcyB0 bw0KPj4+PiBiZXR0ZXIgY29kZSBxdWFsaXR5LiBUaG9zZSBjYXNlcyBhcmUgY2FsbGVkICJkZXZp YXRpb25zIi4gVGhleSBhcmUNCj4+Pj4gcGVybWlzc2libGUgYXMgbG9uZyBhcyB0aGV5IGFyZSBk b2N1bWVudGVkIHdpdGggYW4gaW4tY29kZSBjb21tZW50Lg0KPj4+PiAiIiINCj4+PiANCj4+PiBI bW0sIHNvIHlvdSByZWFsbHkgbWVhbiBpbi1jb2RlIGNvbW1lbnRzLiBJIGRvbid0IHRoaW5rIHRo aXMgd2lsbCBzY2FsZQ0KPj4+IHdlbGwgKHNlZSBlLmcuIHRoZSBEQ0UgcmVsYXRlZCBpbnRlbmRl ZCBkZXZpYXRpb24pLCBhbmQgaXQgYWxzbyBnb2VzDQo+Pj4gYWdhaW5zdCB0aGUgIm5vIHNwZWNp YWwgY2FzaW5nIGZvciBldmVyeSBzdGF0aWMgYW5hbHlzaXMgdG9vbCIgY29uY2Vybg0KPj4+IEkg ZGlkIHZvaWNlIG9uIHRoZSBjYWxsLg0KPj4gDQo+PiBPbiB0aGlzIHN1YmplY3QgdGhlIGlkZWEg d2FzIG1vcmUgdG8gZGVmaW5lIGEg4oCceGVu4oCdIHdheSB0byBkb2N1bWVudA0KPj4gZGV2aWF0 aW9ucyBpbiB0aGUgY29kZSBhbmQgZG8gaXQgaW4gYSB3YXkgc28gdGhhdCB3ZSBjb3VsZCBlYXNp bHkgc3Vic3RpdHV0ZQ0KPj4gdGhlIOKAnGZsYWfigJ0gdG8gYWRhcHQgaXQgZm9yIGVhY2ggYW5h bHlzZXIgdXNpbmcgdG9vbHMgb3IgY29tbWFuZCBsaW5lIG9wdGlvbnMuDQo+IA0KPiBJIHRoaW5r IHRoZSBiYXNpYyBzY2hlbWUgb2Ygc29tZXRoaW5nIGxpa2UgdGhpcyB3b3VsZCB3YW50IGxheWlu ZyBvdXQNCj4gYmVmb3JlIGRvYyBjaGFuZ2VzIGxpa2UgdGhlIG9uZSBoZXJlIGFjdHVhbGx5IGdv IGluLCBzbyB0aGF0IGl0J3MgY2xlYXINCj4gd2hhdCB0aGUgYWN0aW9uIGlzIGlmIGEgbmV3IGRl dmlhdGlvbiBuZWVkcyBhZGRpbmcgZm9yIHdoYXRldmVyIHJlYXNvbg0KPiAoYW5kIGFsc28gYWxs b3dpbmcgaW50ZXJlc3RlZCBwZW9wbGUgdG8gc3RhcnQgY29udHJpYnV0aW5nIHBhdGNoZXMgdG8N Cj4gYWRkIHJlc3BlY3RpdmUgYW5ub3RhdGlvbnMpLg0KDQpXZSB3aWxsIHdvcmsgb24gdGhhdCBi dXQgaWYgd2Ugd2FpdCBmb3IgZXZlcnl0aGluZyB0byBiZSBzb2x2ZWQgd2Ugd2lsbA0KbmV2ZXIg cHJvZ3Jlc3MuDQpJIGhhdmUgYSB0YXNrIG9uIG15IHNpZGUgKGllIGF0IGFybSkgdG8gd29yayBv biB0aGF0IGFuZCBMdWNhIEZhbmNlbGx1DQp3aWxsIHN0YXJ0IHdvcmtpbmcgb24gaXQgbmV4dCBt b250aC4NCk5vdyBJIGRvIG5vdCB0aGluayB0aGF0IHRoaXMgc2hvdWxkIGJsb2NrIHRoaXMgcGF0 Y2gsIGFncmVlaW5nIG9uIHJ1bGVzIGRvZXMNCm5vdCBtZWFuIHdpbGwgcmVzcGVjdCBhbGwgb2Yg dGhlbSBpbiB0aGUgc2hvcnQgdGVybSBzbyB3ZSBjYW4gd2FpdCBhIGJpdCBhcyBJDQpkZWZpbml0 ZWx5IHRoaW5rIHRoYXQgaG93IHRvIGRvY3VtZW50IHZpb2xhdGlvbnMgaW4gdGhlIGNvZGUgYW5k IGluIGdlbmVyYWwNCndpbGwgYmUgYSB3b3JrIHBhY2thZ2Ugb24gaXRzIG93biBhbmQgd2lsbCBy ZXF1aXJlIHNvbWUgZGlzY3Vzc2lvbi4NCg0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu May 26 15:29:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 15:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337635.562288 (Exim 4.92) (envelope-from ) id 1nuFPo-0005Ml-7D; Thu, 26 May 2022 15:28:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337635.562288; Thu, 26 May 2022 15:28:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFPo-0005Me-46; Thu, 26 May 2022 15:28:44 +0000 Received: by outflank-mailman (input) for mailman id 337635; Thu, 26 May 2022 15:28:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFPl-0005MY-UC for xen-devel@lists.xenproject.org; Thu, 26 May 2022 15:28:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062f.outbound.protection.outlook.com [2a01:111:f400:7e1b::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84801eff-dd08-11ec-837f-e5687231ffcc; Thu, 26 May 2022 17:28:39 +0200 (CEST) Received: from AM6P195CA0016.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::29) by VI1PR08MB3216.eurprd08.prod.outlook.com (2603:10a6:803:3d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 26 May 2022 15:28:36 +0000 Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::7e) by AM6P195CA0016.outlook.office365.com (2603:10a6:209:81::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 15:28:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 15:28:35 +0000 Received: ("Tessian outbound 361d68419a2f:v119"); Thu, 26 May 2022 15:28:35 +0000 Received: from 32ee17437866.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F782911-7C36-4FF0-A278-13940F2BAD92.1; Thu, 26 May 2022 15:28:29 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32ee17437866.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 15:28:29 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM0PR08MB5204.eurprd08.prod.outlook.com (2603:10a6:208:161::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 15:28:27 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5293.013; Thu, 26 May 2022 15:28:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84801eff-dd08-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MRsFpK0KPCBQ9DnN8JnDthpTy76XxHOGqngO7IAt6DNxRaTjBmQYCFSSiT+GKJCQ3WkGQ/amiQeV2N1YKVbs8DBQQTuIVfp+mefJViFUjC5EjDKu6Kns5XM7FC6y6N2OfmTrLbxIh2Q2X+NVCmKUWTvJVLV9S3knosLHD3zMMuSFp6t+8E8GWHY9vuxinwy0TZj0opX3a7ygNtAqBhDFvOseY/a3StNF/eXJ6Kq1hUcAfqwk+rYewlzvqn/Oxd9lXfq3sZxlFrdPKvMiqDVim+l2s7saS/n4PYJT8WvagOH+Aif2a6K13c9UIQpwReKIllfK6RuhUKHW1h+pjZXGSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=FtD9idBfiPPwkLwsYLSBsVQJo6hO5aOhmSRxfo130KaJ88pwoHccLNDxxnFji2SFW54ig7apQnrdwdrEn5XxZ8FJcSyeo6OEMIo4/oKF4yDnbt/rHk56YY5mhx/Ddrpsz6xeqh9iHQ3jff7gg/ww8Qt3s/Naysez2NeN8jfsYrwN1M9yzpzFr5LAXeB0CNROfxg/VkYOe8UvlHTaoruJ0tnMrxaaKtGnuvyZlMc+75HDkc/qn39dF6LXvs+7d66dC9O5kYBizfEakUCrNj/t7bdWDchtXYP04L+Wfrkbq66VM1PqK7nqCDsf6A1e6jGQB+jnRiCQ6VzN874e7oysoA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=Z7gt8dIm8DeOHiWm+a8/s+FzJICn1KFcfkgHSS42xBi7G1mmRbG4/3YK4wiO6to48AJfHCeoMZh+tf3w+iYhC6n8XPxVphQI2NWTpNyAdzVMyTPO+B8engny6TaBD2hn3UL8cJCeOIV9DVa+jMI6BYiOKuvrMR1D+YNdpYWZd0M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d9c1373760a22933 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXQ6IbxqVie+hmKkxzmENGh+HU43SgAUbYKKLLVFpqKyCvC1f9VNMxAOzM7t2KRS2lGHCm7PaRNnPLZEyVlElDSEqTvpp0qsFI/onDFTbKoFA6vqyOWMT/Q1IkQmHznsyZ6Pm9REVc4F5wbRo9F1i5pc+t3cKF8a+P9cl2ykaID3HUG5Asz936ya1WoD4ogJ2XKS7zXiCu1AnPSeRswOElIxXajWYwvjcjMdN1P/Efu+DKX9GFfdIW16vVt2w6n48X8TI+U51OXudSDRoCG7o1ivuxR0cA4yKybsM+dDwQaQV4QLCAqBdm9qq2crC0N69vVsRi9XDMi18HIj7R0u+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=FnVi8NfiAx8v+s2BPSuUzjEaJS1+L39DzozmjDo0OEq8DRAD+7o+9zfrqskTAMXVpH8spoxZCTmIGpMPIZh2aeqxEz8ntVd4IvXWL8oT2gWxXuLXpJtzkAv6O+YDk9ab70ePp7AXD3p8py5fbAzlc7EUN7B52epksFO/JTzPq56LLq2uGeyTqRut3MlW2LKBs+am7SK3FgoxOXlZAzWotYQ7nRMYPtCVI1KGJRMo/NarTlwdmyGhTkd4RhARHPizdylqElepGiptu+jz+/y/0siWFyOPVFRqkPjPR7EgR7pd/Q+/SvrzNWz7TI90hSLYFnF89oYXRa8NIemhWK6Daw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/dZO9F/JpceSmK/6Dk5FDFn8mBgGPLxpqcatbNoNdHs=; b=Z7gt8dIm8DeOHiWm+a8/s+FzJICn1KFcfkgHSS42xBi7G1mmRbG4/3YK4wiO6to48AJfHCeoMZh+tf3w+iYhC6n8XPxVphQI2NWTpNyAdzVMyTPO+B8engny6TaBD2hn3UL8cJCeOIV9DVa+jMI6BYiOKuvrMR1D+YNdpYWZd0M= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted Thread-Topic: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted Thread-Index: AQHYbEKl21ixnwqV4kWdLSxbd0iWW60xUfcA Date: Thu, 26 May 2022 15:28:27 +0000 Message-ID: References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-4-julien@xen.org> In-Reply-To: <20220520120937.28925-4-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2b919042-3b78-41a4-ad8b-08da3f2c66ad x-ms-traffictypediagnostic: AM0PR08MB5204:EE_|AM5EUR03FT017:EE_|VI1PR08MB3216:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g5EqyBDvSQiWKwrcvkCujLs7hnWzuiwvBkdr5GpODUmSyQMw8vF0YV4WU23uDp2YZ4CFedJAAlkg3IdodSDo7K82txjnTxU+MCEP6XkcKZK1Vqjo4iplVkYfSvfBiAQa+HrgJcQPIeTEFnlbrM51wRcC0JPZxJNAvAW/YY904cAzJsePHevz7G7oVzQmOVfGnaQzVNzFmbaouKL+dkGG9CXvxrIbEmKgnDEkt+ULFqwJ2sYt6yx4LsqnysmfsXFwHYpILHFf9ynpAaf7XRYEqINLj1N7AM4HWcjITiuxGoTNpFYpVRB+z2s1o4jAFZDdRnJaifS/O3pj7gRQ6Z+pRwtcXURcKfoje4jKi97NIPjjQIvJyiQfbr4ezrxn+WGpcmFhHfaV9NJ19OSCSunYTfDi75viuWkItyDloO0mewhoxOHHDHA5TsPHjvLUOWT70wGzP5mfhzMk6c2yaGxlgduberIbKn+Z4ZSGVl5gUaCjFbNdXHbPUpcv81wB38jRRoea9oK5qpg1wpNbx2af22n3epUzyFjTtwAMuDfrv483r0hdHG936PnKzcBWouG5168fSeZCD75oqFifIeiotGV68tUFYoWOlIuNM+UeKJiQxxy0KDOlLiiCp6eTlN8Vpod4AquVAdhmkqjE/xF8e9WTGKPf5+8/LkjADgtegn9M4Bknmb942bQHWIFVWI44CiPri9YpO0XyPjV8athWMs87i3majl7OJ+eF83ISsssgM4v+TlQNjHWfMb0wgUKB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(186003)(6486002)(2906002)(33656002)(4744005)(26005)(6512007)(36756003)(66476007)(66446008)(66946007)(66556008)(76116006)(91956017)(4326008)(83380400001)(64756008)(54906003)(6916009)(38100700002)(38070700005)(86362001)(5660300002)(8676002)(2616005)(71200400001)(316002)(122000001)(53546011)(8936002)(6506007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5204 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0660c5af-4b12-4247-239a-08da3f2c6183 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mLab9X2ki2DQxedaKODhAwdMeUBlnnOcnqIIP/y73QPAhD7cjmiL5YW17jOLiQIIVXQExugkB5wFiQzDM6srye2ArVYyv9BaIoJqxwQYyXttTewepO8ZsLdFdELiLcwGjFG3varBzygq8KZTURVewdOsIhyNXqPRfFbTq6jP67pyBKcvjYxN197kTpn88Pc/n2YxwG0r2bICIEW7YKd6xEve2tMdDJxnsVVdRPbe6TdlOgnjvp7B6L5GrvEdVAz3iEI4VK4FAdQqjNTa5kh/8lQwuNuDcvxLevGEO9HV6amg8JsM6SodgMEVJlY9PAOTEh6x1a0WhCIgnQ9UoDYwVaYlb7V36VP4GjcoHEYb4b4MxsTWiNy0Z4lQGDhleJIafuMyri7XkRgz9zzWm+2Pa9sYwhomD6SdQ74xzI3hwWcq7DYxeUVEJrQIXsC8tJQ/a1QndKtUQotkdhXhXdlDeqswPQrqKibgbdyN2cjmF9QZVucQbaSNegafxqpQeID9PlpQDl+EBoBhwinozCYc2cJCqJQmxr6FuMEjfzEq8BzprxRoT6hFvWYoc8L5aePRCAW8tWxLnEssg9fPcmIK8oTFHn5JW/56U+yAZrYbTjIMaiUXNhEeQb/Yg7KuOdpmavBx2DfCPuDGZC2UkAQOAAD/DiQCWZz3aPOduW8RtQSMmTOTaxX29s26iMZq6xA2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(83380400001)(356005)(33656002)(53546011)(2906002)(6486002)(107886003)(36860700001)(40460700003)(2616005)(54906003)(8936002)(316002)(4326008)(82310400005)(70586007)(70206006)(8676002)(6512007)(26005)(6862004)(86362001)(36756003)(47076005)(336012)(6506007)(186003)(5660300002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 15:28:35.9490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b919042-3b78-41a4-ad8b-08da3f2c66ad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3216 DQoNCj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjA5LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ DQo+IA0KPiBDdXJyZW50bHksIHRoZSBmdW5jdGlvbiB4ZW5fcHRfdXBkYXRlKCkgd2lsbCBmbHVz aCB0aGUgVExCcyBldmVuIHdoZW4NCj4gdGhlIG1hcHBpbmdzIGFyZSBpbnNlcnRlZC4gVGhpcyBp cyBhIGJpdCB3YXN0ZWZ1bCBiZWNhdXNlIHdlIGRvbid0DQo+IGFsbG93IG1hcHBpbmcgcmVwbGFj ZW1lbnQuIEV2ZW4gaWYgd2Ugd2VyZSwgdGhlIGZsdXNoIHdvdWxkIG5lZWQgdG8NCj4gaGFwcGVu IGVhcmxpZXIgYmVjYXVzZSBtYXBwaW5nIHJlcGxhY2VtZW50IHNob3VsZCB1c2UgQnJlYWstQmVm b3JlLU1ha2UNCj4gd2hlbiB1cGRhdGluZyB0aGUgZW50cnkuDQo+IA0KPiBBIHNpbmdsZSBjYWxs IHRvIHhlbl9wdF91cGRhdGUoKSBjYW4gcGVyZm9ybSBhIHNpbmdsZSBhY3Rpb24uIElPVywgaXQN Cj4gaXMgbm90IHBvc3NpYmxlIHRvLCBmb3IgaW5zdGFuY2UsIG1peCBpbnNlcnRpbmcgYW5kIHJl bW92aW5nIG1hcHBpbmdzLg0KPiBUaGVyZWZvcmUsIHdlIGNhbiB1c2UgYGZsYWdzYCB0byBkZXRl cm1pbmUgd2hhdCBhY3Rpb24gaXMgcGVyZm9ybWVkLg0KPiANCj4gVGhpcyBjaGFuZ2Ugd2lsbCBi ZSBwYXJ0aWN1bGFybHkgaGVscCB0byBsaW1pdCB0aGUgaW1wYWN0IG9mIHN3aXRjaGluZw0KPiBi b290IHRpbWUgbWFwcGluZyB0byB1c2UgeGVuX3B0X3VwZGF0ZSgpLg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KSGkgSnVsaWVuLA0KDQpJ dCBsb29rcyBvayB0byBtZS4gSeKAmXZlIGFsc28gdGVzdGVkIGl0IHN0YXJ0aW5nLCBjb25zb2xl LWluZywgZGVzdHJveWluZyBmZXcgZ3Vlc3RzDQphbmQgSeKAmXZlIGdvdCBubyBwcm9ibGVtDQoN ClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQpUZXN0 ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0K From xen-devel-bounces@lists.xenproject.org Thu May 26 15:31:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 15:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337643.562299 (Exim 4.92) (envelope-from ) id 1nuFS9-0006go-Kv; Thu, 26 May 2022 15:31:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337643.562299; Thu, 26 May 2022 15:31:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFS9-0006gh-Gp; Thu, 26 May 2022 15:31:09 +0000 Received: by outflank-mailman (input) for mailman id 337643; Thu, 26 May 2022 15:31:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFS8-0006gJ-LF for xen-devel@lists.xenproject.org; Thu, 26 May 2022 15:31:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc83fbb1-dd08-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 17:31:07 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-36-dm5yD9K5MhKnRmsJl_-Szw-1; Thu, 26 May 2022 17:31:03 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8827.eurprd04.prod.outlook.com (2603:10a6:20b:40a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 15:31:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 15:31:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc83fbb1-dd08-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653579067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W82GIxvujUZKFBMLSIORS/H4mpxmXUxgQqKM7j010fM=; b=KorI4h9vMiJZK9HxMSc+yK3+j90LespqCpZV7IStiW6lmFrHuqmlJIl88IDmvy5EM4Iw8x K9yo3oRrvx6Q4qW7adS/stukxamS8e3rdXisKKpgxrZXlljAcBIuzboXHU1ynyQTk4BM4r S1djPyPYQmWkl+9N2w+JxgQbGOurIX8= X-MC-Unique: dm5yD9K5MhKnRmsJl_-Szw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpY8oyAdsLJnBC8/4DDlxqtjrhoy2WxMGfIZIfIwezSn1n+URAUAE+v2WFJfqzH6fhTtf0TaAOUQ1i5b4JO1t3PpmVIIRuEbcd4IBNHoojXAtxjFE36+kTIAZBmtO6sVmciplQIm1DmUlvQdcMtvqBDIK1TpQ9HARn5M8eCsN+QykuGHjzncjmNKKwAVlJi1UeoINRYDgMoq8xMD3ej5fJdPtvv0YtycgKhzWFdraMgZ1OfAQSgo+avQg4Fsw4cjhZmkVH9sKVpdFKS+jn7+E/uXXKsuarXhnVZA0nPgtB0cXJgNZtcP9hUXYIrU6jqMnTvUmAwC/FIBky24ofrH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W82GIxvujUZKFBMLSIORS/H4mpxmXUxgQqKM7j010fM=; b=Wx/V4t8oOy9OqaN0QwdSQl2eRIOgFPtD6XvG+MOAtX4zQUXgcVNJeNjjwYZbK3PWD0Ms/IH2nSfiISqiit+wPzuFM2Atop6mBap4DrTNcev6hH2B4bjiv3YDCUBwrzMAA/2DepXkNIHFtk1prctzULfefac1+qWcsSfk+3dFNpafFvQjQ3zwyoGkx/07k8PcyrjjSyP6GGfZ12bF3Pn6R3rj98FFykyVoBAaSdwjIRMQhKEus4fW7U4ZaJDyQNLZE77Pvb51+ZvAJgHBTr8Hqzr0bx6qL5RytZZQil9q9uOdxVqxM0HTspVZoI4ouk8ZrVH/9j26at/vL0Lwh6x7ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 26 May 2022 17:31:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e() Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220427140400.20152-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220427140400.20152-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0020.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc35ad06-a96f-47b2-90af-08da3f2cbddb X-MS-TrafficTypeDiagnostic: AM9PR04MB8827:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z5GMQHjefHhNrz5E0QVGv+TW35aME7GVagkuPCZ72kc57mR1VY1rV9EiU7hQG/ZjW6LkXRCXJHlBZafCeE4P9BHxjd74O6PJetZ0dk+vuYlUs2Jm1IVpLpqPYfUf5GrufZg+sqYsBlwDN8QwegbkyGYJmDWRn8ryfgJWkU3TZAkx003d5WsRPhkO9NYUfIZdyxzY0/QU0q2VrRY1z5+74UJxnFfbKVuo5MSuX2C3FpfC4aDaddtPJyQJ8ZIkGARsRKpgqOfZfq8/aveyabZ1Luen+BGzDBINKS+BvWFQJsGyw2V5yUYYlhpXJIYvohDYlulezZg74eUqEGcHciwKxm3I2qrO2CdJBnAjVM220zbNWChNWmgPEklD7QIu42DZjrW6K26xUbtOkmUVVwqNg1Ek1jgSWaSH7nsAVEyok9fLQj+ssJ+LPtH645atoFLTmHxBETgncAoL/ZIJKFbsHoUOXGgXUyq6bIUgWnxnym+Sitct575fD6XQFWkZk4KohKGCBBSsR+uBzLSlGiQzHjHU7zz9iLPzMT+gZ+hgiNrX/8YFj+Se3xWK3+x+5lZom6hoi7pRHgp9V9cedeY0DLXFHsN10TXTjVNMLW/dmI3RXosNPFzAo18yVRc2IKtew6gJ7gTjtj+LTbC0lxEvsL0KU0fj++EfKKPEBA/pvfXC1CO8g0mhedeUyCnPwjh/MbS4TRb2eFH6qvVVuIG4nWRpmoKzcF7waJ/QslnbueA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(38100700002)(2616005)(8936002)(83380400001)(6486002)(2906002)(316002)(36756003)(54906003)(186003)(6916009)(66946007)(66476007)(66556008)(31696002)(53546011)(8676002)(6512007)(6506007)(86362001)(5660300002)(508600001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djVWU2g0elZBNzVtdmp4UEdqci9jRkRFVXZ0eE9tVmMrWWYxaFBEQmYzVk5j?= =?utf-8?B?NC9GT1FBYXF6elR4czloOExLZkxWSkJrMHlwU0NrV1h6UWNuRUJUM0lJYnEx?= =?utf-8?B?eHBhMnpoNzE2eEkyNVg4bWRxVGt0cWhZV1UxLzFYUDJwcndJaERRVFRrMS8w?= =?utf-8?B?aHg0c2JCNUNpNSt5MGpTeWwvY0ZXSWcySjdwOHZ3TEdmQ3MxNDBMejAyRmZP?= =?utf-8?B?MktnR2xYRmQxcXpUeHlua2JOWmptWDQ1aE9xN1lXYXpaQVppbGlXY1RCVllM?= =?utf-8?B?K1RYUS92THVJd1czZXNIUXJXRXJyL0xJa3h2SjlURnNTRjVVb1hiM2JiVkVW?= =?utf-8?B?TW0xR2JHMEpnQ3JaVGg2bm8zekVkbzlQakpvZHk5ei9Qb1ZVdXdIcDYzb1pW?= =?utf-8?B?M3YwNmhOM0VXVXY2T2M1bGFFM3JwTHZXS1VCNThaQmhObDdteUMvUEkrMmEx?= =?utf-8?B?TldUa2JkdTZzSkFGTG1HRDFyTllyVDRVMXUxeVg3T2NZaGxiRFlHVzVPVzU0?= =?utf-8?B?UHdXMnM4UFd0UHhLVTZkU2QrZld5QjV1VGtsVXA4V1Z0Ti8wRmZlZ3pmaHpC?= =?utf-8?B?a1B2K3hpdzAvQnQ1R0VMS1RDaGxhRXozZEJrMnhKdTBjS1gwdjVtWk1kRjMr?= =?utf-8?B?MVRQY21kZDJVK1dJMVB4ZTZob3JJam9UNXYvZ0FYMFBIVFMxOXBQdUtZOTVZ?= =?utf-8?B?aEpnYXFybitRenBFemcwLzBLS0ZaNlQxYks5bUI0TFA2MU1yTmhlZ01UeTYz?= =?utf-8?B?a0dDS2laNExURHNQVnlVY0Nqc3RvZnR5cnpoZG5TdGdjMmh5c2puMFlYVVlN?= =?utf-8?B?cDRuUEtjbHJJU3VOamI1QUZzZS9DanVHYXVxdnBnYTh1a0pTVkI3T3J4QUsx?= =?utf-8?B?Y0RyQk9Ud2IzdjcxcnMzVGUvVHZab1BnRFNMZEhZNGJnRlJra2s3b1ltTnF1?= =?utf-8?B?clhTM2M0Z1I3VjFFL2x3cDVqMXV1ZW02Sm1abXlCakVwTWljV09nalhUME95?= =?utf-8?B?ZlBFb0ljdFpka2Y2ZnRHYzhUaFowTDdvYVMzUGdpZFNPb2pxVTE0QzZSRGF2?= =?utf-8?B?cldZOUJvQUkwZTBuQXFndExrZWpoaVFrUndLRzNrLytuWDZNeEVmMGpmZWxy?= =?utf-8?B?Y2FjQkZTeUc5UmNpcy9kVGs5amphSk1EcEFrODArNFdxYVVtT1Y1VjZ1Tzhs?= =?utf-8?B?Z3JBR3QwSW1pUHlvUHpwZ2dGWUR6SWp1Rk52Wkt3ZnBoZlVWYnBlQkNrMFJs?= =?utf-8?B?M2NUcDdyY2duZ2dBbTd1Zkx5SmZGbmJNK0tmMkttczB5WFZWNjI3bEduSW9K?= =?utf-8?B?SnR5YXJmOE9UVnlpT2NXblFHRjE5d0J2QzArS3pVM3ZwYkxqam0wazQzVit4?= =?utf-8?B?OUUzNWFhTWEyamhINEJCWVA4aExWOTB2TytsK0tXalEwVDBXa3ZJSjlkZ09D?= =?utf-8?B?Q2ZmKzV6bWVhc2NHQ0ZwcC9HOXpKcy9IdStXMVNZUzB3NVJDNDAzOVR0ekFM?= =?utf-8?B?QldFYVlGcC9wZFFqL0FvMTdrdlkvcDZQQk5OZU5yUnZFODRGTGVaWWp5NXBW?= =?utf-8?B?aFQ4VDhFR3lNUmdjSUNHNk5mOVFhYS8vUzBnYVN1a3pXdU5nUEFXelhKLzVQ?= =?utf-8?B?a0tQZVRUalhUUXpQWStzTHdyTHhNLzA4TFFsWWZMc2o1Z0t6U21QY3JhOWsx?= =?utf-8?B?ZTJRNHptN0RhdEU1QWkybjdENHF0b2RXYitsUEpBcmo1TlVXcDFrOFRDa1ZE?= =?utf-8?B?c1JvUlZNcUV3bkZrcXMxamhOa1RUdEtxbnRNZEZCMXJEc3J3RGNsVFRkdTc2?= =?utf-8?B?T0lENGs4VlZIa3p1N3RRcGtTRE90ZnBHb3VseXdyS1BmRFdVZXpjYTNZUnR0?= =?utf-8?B?Vjl0dFE0NVhCUFV3N2h1M1ViM2UzVHBRbHpaRGJwZHlkQTRYREJzUWR4Yk0z?= =?utf-8?B?MFcxemQ4TDBISDA0WEt5NzlwRDhJU1BQNHZqWlphL1FncEJTVm5FMURsQ2JE?= =?utf-8?B?ZG1sZzR6b3FDZEpFQzZsa0w2U0VWRDhNRkJrQ2orUlNFM2wvSFZ2SnJsK05q?= =?utf-8?B?aXlEV0diMnJHRDV3dXlGTUIweHVpS05oaXRyVWVTYktMZW9NVVFOaUFEek9m?= =?utf-8?B?VGp1ZXNyTmQ2SzlvSFF6cXA0T2lQU0tieVcrOXY3aTJYQnFDZFZFZEROWVZR?= =?utf-8?B?d3U2OHhxZmdxVm9DYXpXeFduV3o2dkh6T3VkZllvZ1RVTVhpZ1p1VWxCemFP?= =?utf-8?B?a3JrZGdxa24vdS9OYWlQbnU4UHZtckYxUXNGL2NpbWxVaWI0RmdVNGhKdjlX?= =?utf-8?B?cmNKSTFLSUhkSmd1QnE2RkdYY0VhY25BQ3krN0dmaldrbW83R09EVGJ0SlJD?= =?utf-8?Q?Q3Dcr9YHFrtXiw64ospHvLS08cKQ8t3fAirunB5++QJjo?= X-MS-Exchange-AntiSpam-MessageData-1: yjOMKc1E5pEkLw== X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc35ad06-a96f-47b2-90af-08da3f2cbddb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 15:31:02.4146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qRqjwZrkX5V81024kfb8vkRVvCR2uSK/4U74j6yvrppIyqNTutH7KZZ447r8jTXHWwIQzg1+aYVsrUJjBbtQmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8827 On 27.04.2022 16:04, Andrew Cooper wrote: > mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for > speculative defence. Avoid calling it redundantly, and just store the result > of the first call. Since it took quite some time for this to actually be committed, I did notice it among more recent commits, and I've grown a question: Isn't the latching of the result in a local variable undermining the supposed speculative defense? It's not as if I could point out a particular gadget here, but it feels like the adjustment should have specifically justified the speculative safety ... But I guess my understanding of all of this might still be somewhat flaky? Jan > @@ -902,13 +902,15 @@ get_page_from_l1e( > return -EINVAL; > } > > - if ( !mfn_valid(_mfn(mfn)) || > + valid = mfn_valid(_mfn(mfn)); > + > + if ( !valid || > (real_pg_owner = page_get_owner_and_reference(page)) == dom_io ) > { > int flip = 0; > > /* Only needed the reference to confirm dom_io ownership. */ > - if ( mfn_valid(_mfn(mfn)) ) > + if ( valid ) > put_page(page); > > /* DOMID_IO reverts to caller for privilege checks. */ From xen-devel-bounces@lists.xenproject.org Thu May 26 15:32:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 15:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337651.562310 (Exim 4.92) (envelope-from ) id 1nuFSz-0007FT-UU; Thu, 26 May 2022 15:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337651.562310; Thu, 26 May 2022 15:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFSz-0007FM-RJ; Thu, 26 May 2022 15:32:01 +0000 Received: by outflank-mailman (input) for mailman id 337651; Thu, 26 May 2022 15:32:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFSy-0007F9-LD; Thu, 26 May 2022 15:32:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFSy-00040I-IJ; Thu, 26 May 2022 15:32:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFSy-00061e-0D; Thu, 26 May 2022 15:32:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuFSx-0005ke-Vp; Thu, 26 May 2022 15:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vtUhV0K8EDyftqla/HDtuP36Xg0rXHwp/vEtsAqBzxw=; b=gpalEhbHvr0D+HAG2XrAkYN4v0 X/Gx6eO/Ix4Q1vtxsgu8Qd0cr+8JRVbK6YVXegD1GHMdWWkwEKUHwU6aie6bw6eGEAh6q4ZYUbupJ uPBCtFLPOQGCd/AU4Ta5Wo3nfPhaGrwx4NDEk/bhWG1S4GO/fgW7hhVb+038YSV2Oreo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170741: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=58b53669e87fed0d70903e05cd42079fbbdbc195 X-Osstest-Versions-That: qemuu=ffae6d9585dc9353c2776944b862bda126dd87ea From: osstest service owner Date: Thu, 26 May 2022 15:31:59 +0000 flight 170741 qemu-mainline real [real] flight 170748 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170741/ http://logs.test-lab.xenproject.org/osstest/logs/170748/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 170748-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 170748-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170732 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170732 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170732 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170732 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170732 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170732 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170732 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170732 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 58b53669e87fed0d70903e05cd42079fbbdbc195 baseline version: qemuu ffae6d9585dc9353c2776944b862bda126dd87ea Last test of basis 170732 2022-05-25 17:06:57 Z 0 days Testing same since 170741 2022-05-26 02:04:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: BALATON Zoltan Cédric Le Goater Fabrice Fontaine Howard Chiu Ilya Leoshkevich Iris Chen Jamin Lin Jaroslav Jindrak Laurent Vivier Lev Kujawski Liu Yiding Maciej S. Szmigiero Paolo Bonzini Peter Delevoryas Philippe Mathieu-Daudé Richard Henderson Stefan Hajnoczi Thomas Huth Viktor Prutyanov Vitaly Kuznetsov Vivek Goyal Yang Weijiang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ffae6d9585..58b53669e8 58b53669e87fed0d70903e05cd42079fbbdbc195 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu May 26 15:56:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 15:56:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337662.562320 (Exim 4.92) (envelope-from ) id 1nuFqb-0001MA-5B; Thu, 26 May 2022 15:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337662.562320; Thu, 26 May 2022 15:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFqb-0001M3-2E; Thu, 26 May 2022 15:56:25 +0000 Received: by outflank-mailman (input) for mailman id 337662; Thu, 26 May 2022 15:56:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFqZ-0001Lx-F6 for xen-devel@lists.xenproject.org; Thu, 26 May 2022 15:56:23 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062c.outbound.protection.outlook.com [2a01:111:f400:fe1f::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62ce3e67-dd0c-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 17:56:21 +0200 (CEST) Received: from AS9PR0301CA0050.eurprd03.prod.outlook.com (2603:10a6:20b:469::19) by PAXPR08MB6640.eurprd08.prod.outlook.com (2603:10a6:102:dd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 15:56:18 +0000 Received: from VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::7e) by AS9PR0301CA0050.outlook.office365.com (2603:10a6:20b:469::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 15:56:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT018.mail.protection.outlook.com (10.152.18.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 15:56:18 +0000 Received: ("Tessian outbound 42cead292588:v119"); Thu, 26 May 2022 15:56:09 +0000 Received: from 48e420b08127.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DACA84EB-00F0-4BD8-95FE-FF9490316E18.1; Thu, 26 May 2022 15:55:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 48e420b08127.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 15:55:58 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by PR2PR08MB4825.eurprd08.prod.outlook.com (2603:10a6:101:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Thu, 26 May 2022 15:55:55 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5293.013; Thu, 26 May 2022 15:55:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62ce3e67-dd0c-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mbk7Axgw41GF60bdsgue8zvv/4O4pHRDFZENMjNAuHxeTsvf6z5xlTVy9wqPqQJ051Zg+QgFUTLizYN/4XffGk3kkVh3CC97h4TS+qmzKWJ6WdKvHXVwgjow0SArEapQwuoA7UC2QtyxMpTkRUwTII1SK47KQFszHH5FB5JyNK3Zwt3lJGq4lpOrk4447Xg3ehMKgd5QE2XSZL/Ekdiq3APjrd7qD6No96dpvGwFfU6FT4ZakMGvG3BZvVtQYsgFAo7dPnX3HDBPM6WPKMDUVLWS66mpeF5P868nbQ+7koMk4FbKj1kWX9vtl6hEHOh+LuE757HkAPxdMFt3rcvJrw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ka290vH7/1CdVyNLnTdw0mQvae0dOqEEjhyaFbnoAUQ=; b=VC1azwtbhkX3GKvEhtoPNlDqVzpywOwlSQnZxLntxjvj2WLpqrg1rtLeeD65GQjOpmbJkDYtLf41mTqXMi6mNnPMtIKM6x4pJaCl2X478Wq4iniOXQBfldpZM8cmShInBL4gCVCbXhGvAcLJGtOhee/HDi0EJCsz4hmH+e1o1r6k6570+Mj3x+KAj4vf7NNyMnxFwQBLnx2Nw/yTrBnpHGsvwY9pfgAW0mLHPXb933SflYr4ekoyQDc8H/ECYiQl/ZiTJu3uPK/yHJwnfQ6/P8f/dAg4qXX9zaliQWbxTczepIYJ4XzSIkd+xXnwK1UOlCBwo4Wp63nt72HimTW+hA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ka290vH7/1CdVyNLnTdw0mQvae0dOqEEjhyaFbnoAUQ=; b=ujzdyj3iymKqTLYhUkD76BhGKyfYXDQjDXtVR1v7d9JZcubOCttz7w/bjJIcSYjv169aQkRv4pQCD3alJd83PwTgfJyeSq7J+CPBly3sLXY2rBM6HnPAhVFRMPW8c8KsQUFgm3F+Vuj6P7yqpxWv2V7SRWcu0oAhiWmi6/Cx+NE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 24b8fd44a1107ba6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mjspp9EXZeEMNiMD8wjkhsnMGdTaIJMmRMHIwEaNoq5uj77Eu9x6oIIufeiE/1vgWehqFVyeFkgOKbkuFq0NEdmMDm9K/+iNkdaFG3jWy2dJO7SM6Cnq6DPgiKSDi1hDdKNB738miM5eOFaibXWyNxVfuahd6uuDbr2C/NlDAiZ+gzjQZsB8nT07tAG0Ouu7ntY59+ialZvgLyi8DzUVxu/79mNU6QHbhWybu8oxq4O8ojiDWGPP5iXhVYBlsvK5m0kHWDnDlKuYRlxCL9XTPEytN9f/wiqt6QxVGCtPnUKVpbmOa++EXM7ZMUgSO+KSFhgtzL2dd3P9E/BcThG/jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ka290vH7/1CdVyNLnTdw0mQvae0dOqEEjhyaFbnoAUQ=; b=ZvrTWKLvr0WOLWty3M0UVgzrLWwheyXb2CO3uLusNK0XQDqX5NmNyE/9XFL12Gr0dvru9uKCUNvdO9z82niyt2H89klSBI7RiWBA+orpp22RMx6llZ/kZ1BssgybH69tpA8OBAKgJpoYHkbpTTzvxX1r9U7ArrrQmXCgHzrJSrcUnUqmITLfpyNEUUFqGY7/0zT8pRL8pO0tw9Znp2Zw/h7DGGx2sYrt+V8ciL06jmiuOMowS4jBtUp1FldVuWSEIC1ZFJr1I20wBuIANqTc69KwGcP4Q9MClKJSd5SkzixwAJNi7VkLsXIROCrVcgWLSEjECV6kRNvywnnaPwkafA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ka290vH7/1CdVyNLnTdw0mQvae0dOqEEjhyaFbnoAUQ=; b=ujzdyj3iymKqTLYhUkD76BhGKyfYXDQjDXtVR1v7d9JZcubOCttz7w/bjJIcSYjv169aQkRv4pQCD3alJd83PwTgfJyeSq7J+CPBly3sLXY2rBM6HnPAhVFRMPW8c8KsQUFgm3F+Vuj6P7yqpxWv2V7SRWcu0oAhiWmi6/Cx+NE= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Wei Liu , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Hongyan Xia , Julien Grall , Jan Beulich , Wei Liu , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure Thread-Topic: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure Thread-Index: AQHYbENHzKAKTdKMX0qFkL1GWjFhOq0xWaOA Date: Thu, 26 May 2022 15:55:55 +0000 Message-ID: References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-11-julien@xen.org> In-Reply-To: <20220520120937.28925-11-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 598b13ee-ddc8-433b-ebbf-08da3f304587 x-ms-traffictypediagnostic: PR2PR08MB4825:EE_|VE1EUR03FT018:EE_|PAXPR08MB6640:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VNhIwxmW5UI1zp7CxZzWWj7+iZA72YuC1lo1bb2uLviaFLLp+ijTmP3f8wFCgHGjxghGBnwXimW8k+zxrkXVN16Rnul7dcoH2HmjY70m+UJMgLMRvjmHssQXNhfneeBIonrP1KRoY15teSSzhxjKaYh3W7Ct6POGVE62NM/krY+uBlb1VMeTl3F/2xB0xgzWMgSU+Yq/N4vqSSTZAEe8RqSzFnPBtryaleIciuc9980+ciGNVa5MErMW++j8wcbujOOXDL1Db6QZPeEoMrLNzwwYHIk99XRgJ89l+okvxVpynuiG7VeLokvhXKcK1Nb3Ep1W0EunMka1rY2JkKIeC0i7V1WHZLr2qwVtIgsl5EmPKfAstfQIYaoiG6qtWrlNsKoG3ieHCK4Z/gzn2B6ackVXG1DTrOlwp3ubi03nb4+Ap0xyjpVQc02S9IcmJWuRXdcXbmCtx+WVFZt9fVk59GdMUfickLaZtYxGAP2/usOY1BH8r27cehCB0wUIc0CbTxXnV+w0Accgi5gvusGurw9KkcVGsuRAYJqV68OM1Hqzh9kzsbwu2BAyxVOELTjS5MgS9G04dAVIk8XEz8OCBjRkudMX0nZFiSbkxA1eFahpVFV1ivI/RVz6BIsPfb+z2AhCZIIPhDCf5jp8SUm+CTgeqR42RFwiW4ApyPRqA27aYKuTqwihWxvNfR2+oML1l/pwP9RTa06GjCj/NXKkW2MQ0ZtRZ5Ofb40NTxLLeHBi+2zzl68/0vBq6pNSdfZN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(2616005)(6506007)(6486002)(53546011)(8936002)(7416002)(36756003)(5660300002)(33656002)(2906002)(64756008)(54906003)(66946007)(66446008)(76116006)(8676002)(4326008)(91956017)(86362001)(66556008)(38070700005)(508600001)(66476007)(122000001)(71200400001)(83380400001)(38100700002)(6512007)(186003)(26005)(6916009)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <872E6A0A4228014FA5AA7F70A2283B9A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4825 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6992807f-0e8d-4bec-8662-08da3f3037f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jo62tqBbiZ6NzXBgZSJdy9luJ5Zr7xLxLBF6Hqte2SfHJaJU1PP9S1sf2+ptfoBICmpm2sdUiP1PzfRZ7IUgTImxOtUKTeatdQvHqVH2bXy2uIJXP/cCtKVgIvPYHK/5aIPK3Mc+RnO8yfVVPYUESsofAiR6bAuZMCN+vWMnBIgvGXKR4iq5pz3EmyfZWo9rIt3BvqZEIcpf7gewyE4a66/4NyZBhYnkAt86kgb+OjnnSnAHq03VlSu4ltWwcUC/8TSAknh9BbS33RCGpax2fT13vPljW4EDnJkN47Ivtw2x+z1J1M4AnLZOgqfUyy8qYfyvFaAqSZ6JvpaKpj90nSy3uo2zsEXDRWV8/cNZWUoXTLjJfK2ELEAAVDqRmgUQFRVziEGQtwTEQB8frkfxuikDsmAcR8f9wq3wIYuuhttF3/BLgE1hcAkJQ1RlxQdnskLABFnRMOiC3g7gkLR2kf+KHl0RE5IlXLa2WGnX5yV2M3kKXHUUGHtP87O10gAfF5d+8KeMAPEnTc9qPSlLupHLk7YZj8InL44RqtUN5KSQUoc3DVT12UwFW+r+sRmo2/QDl1nedrGBWU8D7e300bDNrP4VcgWNkV9WMvPI19/wAjrLYjjQYSvn576CVDDrZnZ0TkSS5BprBKTELxCuRD6n+ca/ZaYRkLJGrg8j2hZw/XMLqEukOP1yewh6FEOv X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36756003)(6486002)(40460700003)(81166007)(2906002)(86362001)(316002)(6506007)(8936002)(70586007)(70206006)(4326008)(8676002)(6862004)(53546011)(26005)(6512007)(508600001)(47076005)(107886003)(5660300002)(336012)(356005)(33656002)(54906003)(36860700001)(2616005)(83380400001)(186003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 15:56:18.2456 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 598b13ee-ddc8-433b-ebbf-08da3f304587 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6640 DQoNCj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjA5LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+DQo+ IA0KPiBUaGUgYmFzaWMgaWRlYSBpcyBsaWtlIFBlcnNpc3RlbnQgS2VybmVsIE1hcCAoUEtNQVAp IGluIExpbnV4LiBXZQ0KPiBwcmUtcG9wdWxhdGUgYWxsIHRoZSByZWxldmFudCBwYWdlIHRhYmxl cyBiZWZvcmUgdGhlIHN5c3RlbSBpcyBmdWxseQ0KPiBzZXQgdXAuDQo+IA0KPiBXZSB3aWxsIG5l ZWQgaXQgb24gQXJtIGluIG9yZGVyIHRvIHJld29yayB0aGUgYXJtNjQgdmVyc2lvbiBvZg0KPiB4 ZW5oZWFwX3NldHVwX21hcHBpbmdzKCkgYXMgd2UgbWF5IG5lZWQgdG8gdXNlIHBhZ2VzIGFsbG9j YXRlZCBmcm9tDQo+IHRoZSBib290IGFsbG9jYXRvciBiZWZvcmUgdGhleSBhcmUgZWZmZWN0aXZl bHkgbWFwcGVkLg0KPiANCj4gVGhpcyBpbmZyYXN0cnVjdHVyZSBpcyBub3QgbG9jay1wcm90ZWN0 ZWQgdGhlcmVmb3JlIGNhbiBvbmx5IGJlIHVzZWQNCj4gYmVmb3JlIHNtcGJvb3QuIEFmdGVyIHNt cGJvb3QsIG1hcF9kb21haW5fcGFnZSgpIGhhcyB0byBiZSB1c2VkLg0KPiANCj4gVGhpcyBpcyBi YXNlZCBvbiB0aGUgeDg2IHZlcnNpb24gWzFdIHRoYXQgd2FzIG9yaWdpbmFsbHkgaW1wbGVtZW50 ZWQNCj4gYnkgV2VpIExpdS4NCj4gDQo+IFRoZSBQTUFQIGluZnJhc3RydWN0dXJlIGlzIGltcGxl bWVudGVkIGluIGNvbW1vbiBjb2RlIHdpdGggc29tZQ0KPiBhcmNoIGhlbHBlcnMgdG8gc2V0L2Ns ZWFyIHRoZSBwYWdlLXRhYmxlIGVudHJpZXMgYW5kIGNvbnZlcnRpb24NCj4gYmV0d2VlbiBhIGZp eG1hcCBzbG90IHRvIGEgdmlydHVhbCBhZGRyZXNzLi4uDQo+IA0KPiBBcyBtZm5fdG9feGVuX2Vu dHJ5KCkgbm93IG5lZWRzIHRvIGJlIGV4cG9ydGVkLCB0YWtlIHRoZSBvcHBvcnR1bml0eQ0KPiB0 byBzd2ljaCB0aGUgcGFyYW1ldGVyIGF0dHIgZnJvbSB1bnNpZ25lZCB0byB1bnNpZ25lZCBpbnQu DQo+IA0KPiBbMV0gPGU5MmRhNGFkNjAxNWI2MDg5NzM3ZmNjY2JhM2VjMWQ2NDI0NjQ5YTUuMTU4 ODI3ODMxNy5naXQuaG9uZ3l4aWFAYW1hem9uLmNvbT4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFdl aSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEhvbmd5YW4gWGlh IDxob25neXhpYUBhbWF6b24uY29tPg0KPiBbanVsaWVuOiBBZGFwdGVkIGZvciBBcm1dDQo+IFNp Z25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQoNCkhpIEp1bGll biwNCg0Kd2l0aCBBU1NFUlQoIWluX2lycSgpKSBpbiBwbWFwX3VubWFwKGNvbnN0IHZvaWQgKnAp IGFzIHlvdSBwcmV2aW91c2x5IHNheS4NCg0KUmV2aWV3ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1 Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KSeKAmXZlIGFsc28gdGVzdGVkIHBhdGNoZXMgdXAgdG8g dGhpcyBvbmUsIHN0YXJ0L2Rlc3Ryb3lpbmcvY29ubmVjdGluZy10byBmZXcgZ3Vlc3RzDQphbmQg bm8gcHJvYmxlbS4NCg0KVGVzdGVkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFy bS5jb20+DQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu May 26 16:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 16:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337670.562332 (Exim 4.92) (envelope-from ) id 1nuGKl-000575-KC; Thu, 26 May 2022 16:27:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337670.562332; Thu, 26 May 2022 16:27:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuGKl-00056y-HK; Thu, 26 May 2022 16:27:35 +0000 Received: by outflank-mailman (input) for mailman id 337670; Thu, 26 May 2022 16:27:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuGKk-00056s-Et for xen-devel@lists.xenproject.org; Thu, 26 May 2022 16:27:34 +0000 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd71bfac-dd10-11ec-837f-e5687231ffcc; Thu, 26 May 2022 18:27:32 +0200 (CEST) Received: from 200-161-159-120.dsl.telesp.net.br ([200.161.159.120] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1nuGJf-002CG3-Fu; Thu, 26 May 2022 18:26:28 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd71bfac-dd10-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=g5u06r/Xg87j4V8Rg6/UfqgEi7DYXSrP5RmkrTIzh/Q=; b=iCgAR296S3LSbLmOpR3LkrCpsK y7YGr6I7yByIEwTjZ2WtYRzzbyBvMDTQTR3zmmZ44zuVyZpeJqajxLL5P1xpJLJTb2dMh5pJztl3L 0g1AqEeOs5c1YhSNaGywDAZ/a8oRKFkwwQklOk+HDjN8XleGQXFDshk4Tc2fywUvD+bO6YJpDVBxc VZ4/e0yO80afyjzEwVVVSVn0AWE9cNQ3TmY2LMY1cD3yxOgLWBpjPGf2UcUw/gYnz7ZNSKeZGhrc7 DZJCm/pzdYk71lBIOpedohq49XSnuibFm3AYgqR1AYHFLSTcilBkitlJTKPhazpNWpAJ8ROQUyMS/ zY22U5mQ==; Message-ID: <0d084eed-4781-c815-29c7-ac62c498e216@igalia.com> Date: Thu, 26 May 2022 13:25:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 24/30] panic: Refactor the panic path Content-Language: en-US To: bhe@redhat.com, d.hatayama@jp.fujitsu.com, "Eric W. Biederman" , Mark Rutland , mikelley@microsoft.com, pmladek@suse.com, vkuznets@redhat.com Cc: akpm@linux-foundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-leds@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, rcu@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, will@kernel.org References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-25-gpiccoli@igalia.com> <87fskzuh11.fsf@email.froward.int.ebiederm.org> From: "Guilherme G. Piccoli" In-Reply-To: <87fskzuh11.fsf@email.froward.int.ebiederm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hey folks, first of all thanks a lot for the reviews / opinions about this. I imagined that such change would be polemic, and I see I was right heh I'll try to "mix" all the relevant opinions in a single email, since they happened in different responses and even different mail threads. I've looped here the most interested parties based on the feedback received, such as Baoquan (kdump), Hatayama (kdump), Eric (kexec), Mark (arm64), Michael (Hyper-V), Petr (console/printk) and Vitaly (hyper-v / kvm). I hope we can discuss and try to reach some consensus - my apologies in advance for this long message! So, here goes some feedback we received about this change and correlated feedback from arm64 community - my apologies if I missed something important, I've tried to collect the most relevant portions, while keeping the summary "as short" as possible. I'll respond to such feedback below, after the quotes. On 24/05/2022 05:32, Baoquan He wrote: >> [...] >> Firstly, kdump is not always the first thing. In any use case, if kdump >> kernel is not loaded, it's not the first thing at all. Not to mention >> if crash_kexec_post_notifiers is specified. >> [...] >> Changing this will cause regression. During these years, nobody ever doubt >> kdump should execute firstly if crashkernel is reserved and kdump kernel is >> loaded. That's not saying we can't change >> this, but need a convincing justification. >> [...] >> Secondly, even with the notifiers' split, we can't guarantee people will >> absolutely add notifiers into right list in the future. Letting kdump >> execute behind lists by default will put kdump into risk. >> [...] >> As for Hyper-V, if it enforces to terminate VMbus connection, no matter >> it's kdump or not, why not taking it out of panic notifiers list and >> execute it before kdump unconditionally. On 24/05/2022 05:01, Petr Mladek wrote: >> [...] >> Anyway, I see four possible solutions: >> >> 1. The most conservative approach is to keep the current behavior >> and call kdump first by default. >> >> 2. A medium conservative approach to change the default default >> behavior and call hypervisor and eventually the info notifiers >> before kdump. There still would be the possibility to call kdump >> first by the command line parameter. >> >> 3. Remove the possibility to call kdump first completely. It would >> assume that all the notifiers in the info list are super safe >> or that they make kdump actually more safe. >> >> 4. Create one more notifier list for operations that always should >> be called before crash_dump. >> >> Regarding the extra notifier list (4th solution). It is not clear to >> me whether it would be always called even before hypervisor list or >> when kdump is not enabled. We must not over-engineer it. >> >> 2nd proposal looks like a good compromise. But maybe we could do >> this change few releases later. The notifiers split is a big >> change on its own. On 24/05/2022 07:18, Baoquan He wrote: >>[...] >> I would vote for 1 or 4 without any hesitation, and prefer 4. I ever >> suggest the variant of solution 4 in v1 reviewing. That's taking those >> notifiers out of list and enforcing to execute them before kdump. E.g >> the one on HyperV to terminate VMbus connection. Maybe solution 4 is >> better to provide a determinate way for people to add necessary code >> at the earliest part. >> [...] >>> >>> Regarding the extra notifier list (4th solution). It is not clear to >>> me whether it would be always called even before hypervisor list or >>> when kdump is not enabled. We must not over-engineer it. >> >> One thing I would like to notice is, no matter how perfect we split the >> lists this time, we can't gurantee people will add notifiers reasonablly >> in the future. And people from different sub-component may not do >> sufficient investigation and add them to fulfil their local purpose. >> >> The current panic notifers list is the best example. Hyper-V actually >> wants to run some necessary code before kdump, but not all of them, they >> just add it, ignoring the original purpose of >> crash_kexec_post_notifiers. I guess they do like this just because it's >> easy to do, no need to bother changing code in generic place. >> >> Solution 4 can make this no doubt, that's why I like it better. >> [...] >> As I replied to Guilherme, solution 2 will cause regression if not >> calling kdump firstly. Solution 3 leaves people space to make mistake, >> they could add nontifier into wrong list. >> >> I would like to note again that the panic notifiers are optional to run, >> while kdump is expectd once loaded, from the original purpose. I guess >> people I know will still have this thought, e.g Hatayama, Masa, they are >> truly often use panic notifiers like this on their company's system. On 24/05/2022 11:44, Eric W. Biederman wrote: > [...] > Unfortunately I am also very grouchy. > > Notifiers before kexec on panic are fundamentally broken. So please > just remove crash_kexec_post notifiers and be done with it. Part of the > deep issue is that firmware always has a common and broken > implementation for anything that is not mission critical to > motherboards. > > Notifiers in any sense on these paths are just bollocks. Any kind of > notifier list is fundamentally fragile in the face of memory corruption > and very very difficult to review. > > So I am going to refresh my ancient NACK on this. > > I can certainly appreciate that there are pieces of the reboot paths > that can be improved. I don't think making anything more feature full > or flexible is any kind of real improvement. Now, from the thread "Should arm64 have a custom crash shutdown handler?" (link: https://lore.kernel.org/lkml/427a8277-49f0-4317-d6c3-4a15d7070e55@igalia.com/), we have: On 05/05/2022 08:10, Mark Rutland wrote: >> On Wed, May 04, 2022 at 05:00:42PM -0300, Guilherme G. Piccoli wrote: >>> [...] >>> Currently, when we kexec in arm64, the function machine_crash_shutdown() >>> is called as a handler to disable CPUs and (potentially) do extra >>> quiesce work. In the aforementioned architectures, there's a way to >>> override this function, if for example an hypervisor wish to have its >>> guests running their own custom shutdown machinery. >> >> What exactly do you need to do in this custom shutdown machinery? >> >> The general expectation for arm64 is that any hypervisor can implement PSCI, >> and as long as you have that, CPUs (and the VM as a whole) can be shutdown in a >> standard way. >> >> I suspect what you're actually after is a mechanism to notify the hypervisor >> when the guest crashes, rather than changing the way the shutdown itself >> occurs? If so, we already have panic notifiers, and QEMU has a "pvpanic" >> device using that. See drivers/misc/pvpanic/. OK, so it seems we have some points in which agreement exists, and some points that there is no agreement and instead, we have antagonistic / opposite views and needs. Let's start with the easier part heh It seems everybody agrees that *we shouldn't over-engineer things*, and as per Eric good words: making the panic path more feature-full or increasing flexibility isn't a good idea. So, as a "corollary": the panic level approach I'm proposing is not a good fit, I'll drop it and let's go with something simpler. Another point of agreement seems to be that _notifier lists in the panic path are dangerous_, for *2 different reasons*: (a) We cannot guarantee that people won't add crazy callbacks there, we can plan and document things the best as possible - it'll never be enough, somebody eventually would slip a nonsense callback that would break things and defeat the planned purpose of such a list; (b) As per Eric point, in a panic/crash situation we might have memory corruption exactly in the list code / pointers, etc, so the notifier lists are, by nature, a bit fragile. But I think we shouldn't consider it completely "bollocks", since this approach has been used for a while with a good success rate. So, lists aren't perfect at all, but at the same time, they aren't completely useless. Now, to the points in which there are conflicting / antagonistic needs/views: (I) Kdump should be the first thing to run, as it's been like that since forever. But...notice that "crash_kexec_post_notifiers" was created exactly as a way to circumvent that, so we can see this is not an absolute truth. Some users really *require to execute* some special code *before kdump*. Worth noticing here that regular kexec invokes the drivers .shutdown() handlers, while kdump [aka crash_kexec()] does not, so we must have a way to run code before kdump in a crash situation. (II) If *we need* to have some code always running before kdump/reboot on panic path (like the Hyper-V vmbus connection unload), *where to add such code*? Again, conflicting views. Some would say we should hardcode this in the panic() function. Others, that we should use the custom machine_crash_shutdown() infrastructure - but notice that this isn't available in all architectures, like arm64. Finally, others suggest to...use notifier lists! Which was more or less the approach we took in this patch. How can we reach consensus on this? Not everybody will be 100% happy, that's for sure. Also, I'd risk to say keep things as-is now or even getting rid of "crash_kexec_post_notifiers" won't work at all, we have users with legitimate needs of running code before a kdump/reboot when crash happens. The *main goal* should be to have a *simple solution* that doesn't require users to abuse parameters, like it's been done with "crash_kexec_post_notifiers" (Hyper-V and PowerPC currently force this parameter to be enabled, for example). To avoid using a 4th list, especially given the list nature is a bit fragile, I'd suggest one of the 3 following approaches - I *really appreciate feedbacks* on that so I can implement the best solution and avoid wasting time in some poor/disliked solution: (1) We could have a helper function in the "beginning" of panic path, i.e., after the logic to disable preemption/IRQs/secondary CPUs, but *before* kdump. Then, users like Hyper-V that require to execute stuff regardless of kdump or not, would run their callbacks from there, directly, no lists involved. - pros: simple, doesn't mess with arch code or involve lists. - cons: header issues - will need to "export" such function from driver code, for example, to run in core code. Also, some code might only be required to run in some architectures, or only if kdump is set, etc., making the callbacks more complex / full of if conditionals. (2) Similarly to previous solution, we could have a helper in the kexec core code, not in the panic path. This way, users that require running stuff *before a kdump* would add direct calls there; if kdump isn't configured, and if such users also require that this code execute in panic nevertheless, they'd need to also add a callback to some notifier list. - pros: also simple / doesn't mess with arch code or involve lists; restricts the callbacks to kdump case. - cons: also header issues, but might cause code duplicity too, since some users would require both to run their code before a kdump and in some panic notifier list. (3) Have a way in arm64 (and all archs maybe) to run code before a kdump - this is analog to the custom machine_crash_shutdown() we have nowadays in some archs. - pros: decouple kdump-required callbacks from panic notifiers, doesn't involve lists, friendly to arch-dependent callbacks. - cons: also header issues, might cause code duplicity (since some users would also require to run their code in panic path regardless of kdump) and involve changing arch code (some maintainers like Mark aren't fond about that, with good reasons!). So, hopefully we can converge to some direction even if not 100% of users are happy - this problem is naturally full of trade-offs. Thanks again for the reviews and the time you're spending reading these long threads. Cheers, Guilherme From xen-devel-bounces@lists.xenproject.org Thu May 26 16:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 16:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337684.562349 (Exim 4.92) (envelope-from ) id 1nuGix-0008Sh-T2; Thu, 26 May 2022 16:52:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337684.562349; Thu, 26 May 2022 16:52:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuGix-0008Sa-Q3; Thu, 26 May 2022 16:52:35 +0000 Received: by outflank-mailman (input) for mailman id 337684; Thu, 26 May 2022 16:52:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuGiw-0008SU-IC for xen-devel@lists.xenproject.org; Thu, 26 May 2022 16:52:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b48cb07-dd14-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 18:52:32 +0200 (CEST) Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 May 2022 12:52:29 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN6PR03MB3026.namprd03.prod.outlook.com (2603:10b6:404:116::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 16:52:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5273.023; Thu, 26 May 2022 16:52:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b48cb07-dd14-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653583952; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=D1iy85bGt0AMepCcoTnsVf4tZhW+lfptrVVB8EvquZI=; b=PBCC69kzwJnh80nr2/7IwYjjsW5dFK/qJmvyluvo45DOxTieShfMgryN WLrkr1TAsq1fMBoZGhpUMAwchKfl5fS1jhkKLhaVt6qf576HJd5N4/lJZ 8ev5IIPBq2h/50+m7qyi1ALfVlgFn8o7MMFyki7kdkvYu+X09/msjSK6c I=; X-IronPort-RemoteIP: 104.47.56.171 X-IronPort-MID: 72662236 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6NKigKP3sd3ezDHvrR3WlsFynXyQoLVcMsEvi/4bfWQNrUp01WZRn zcfUDvSbPeIZ2P8L4hwbt63pEkF7J7WnNcxQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2NAw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+ YsXpbfgawESYqzltvw6bQkBNQtTBPgTkFPHCSDXXc276WTjKiKp6NI3SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7H9aaHPyiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IC9gzP//Fpi4TV5AIg1KHBIMLLQdqxZPdwtWiIv jydpXusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/f5F+fD21dFzpZMoV57YkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:sxtivqmdPO5mT2PjC2cEzYjD/6LpDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe q1NdZfH+LjRFGebLp04w== X-IronPort-AV: E=Sophos;i="5.91,252,1647316800"; d="scan'208";a="72662236" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dth5Ugn2ZdVh7iCOC4x+qgus7DNseEfddRwZlqIBMARMnLdBh8X5n3EFjI2McixrUl+PRMaJKFPJoxRxrNl4AjgpLoqWsxOBsGv1hm9D1rHxKxLbXXIwLhLLet2Nc/8sOEnl88aOnNb/QXU7Iogim8AQGoBoVBUAVcr2m9VLQ1F9nukWYfo6HqFYUzyoHdsrYHmtRQPKmaMG1fmSns/AQXmN65Y5Pf7+n6TCGpKZUiv6Ue9cG7DILfnQtA2MLWWINf/kmv+MQnmwO6Tyexy32EWtXyQdu1lRdZfbDohYihPnYVWq8W71oGHfz4yzDYUUG4KQuOM5n9vURPKsPPLftQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D1iy85bGt0AMepCcoTnsVf4tZhW+lfptrVVB8EvquZI=; b=U6c3jdGrwBKR0FgTsXUrJvbiY92dQ96dHMn3EH65hFXBBG5vAw0wEUkRpCdxL4NSD+yFBgRAUOGCVZu0CdJRYPUAvtw0nhyzE+prhGuSGFRn2cyNrEyf9QRkmDfaRU+0ZWopOOiJlos6+M57ZBwnZ1Qf79AcKbMUC4ra/OX+1lCSZ0XKqKIqkcMhZPh+RcMpVEsVr4y7H0jLlz+jpjEcykg1QOsk8jS5nSSohCwCVFDv4JsL/FcpXKfy4iIB+TjcGnmeAHkKwWPnBiWh5iLE6jSbAJMcuXCQz+Pyiplh4umV6FQwpbDgn29Se/NJKL4+VkOzLuTDeGIVvmrpgL3VjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D1iy85bGt0AMepCcoTnsVf4tZhW+lfptrVVB8EvquZI=; b=veeGb9ewe47gg70FqeabkHCVIcNnjPi+E+iuzLWObNXqj33zZfBpL/rFNPw4ln1wm7VblIC3f1UBO1M6qjh7hzFaMYOoR7Tc5hv1NfPIkB9tEhO9AqxYyyUTBDgUZ0YF3shaUkcZ6VFi4gYjSaw1oN6hXT4b05+7+KfWcMIELXo= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e() Thread-Topic: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e() Thread-Index: AQHYWj++Z1s5A5v8NEKWGg6sIKRPsq0xdrWAgAAWwAA= Date: Thu, 26 May 2022 16:52:26 +0000 Message-ID: <0a02d325-db7f-7201-819e-cb842d714571@citrix.com> References: <20220427140400.20152-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d9c52a4a-36ef-4092-376f-08da3f381d17 x-ms-traffictypediagnostic: BN6PR03MB3026:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YajB9qTLaKTkUgkxgB9edrl6a1vEFo9oUQBUbG+INCAiYJBs2FJe/N1rio5Q+Yk2zWlpUVPY9gfS4DsrkpvTr97+4x60Mcb7+UX+UlyukWMYjWSCV1JAtTQG9oCHG1Q9FybqmUygYj84UJsozVI4Fh7Z2NzNiAj9UX9s4LRRlYgsiYu2tBE0g8OfGepjoERnBfWIzbb/aWwC6pCkmKReDgLSKq4d1lC6BUnMS72kzg/qSAxBZCZ6II5SGGh+Vv/kL8XxRZeWAKx4Q6Xv1sx7+Y+a1w7+E8yl/lDEbZkmKxdLDIDKTvLoFZYvAQNK/Hv+qXfyk738mxOUvwZcMX1psW0IGtCVK7t5njEkVT3RRROOoOu7Uabwn4/t9qtBQNfcY3+vGy9zVPDQz/fpnGMUJkf6j4ITQ9Q+H5pnHUya0v1fthiFTtbmgW5Xpqp7IGbtECwYRpUQCClRtjfxIQHklhlRUBZmaNfKCJuKISGmCETamT1HhIrwoN5LbMXoM4qLaRpGj6dUIU1fsDmdcJUbwmkuCRfEMaKZhfZPk1ViRXHT2Vdg9hBMvb+3T9t2E9M24G5V/CRCiBvBGb8TuKF8EPudU8jmkAnNmeCXwvueU72vO8szI6fhil47CG4gqc86Lqfi6QyR27YAzjM9PebsCPiAmBcwfrVjeha0MBESo4ZZn8cf+uHKbzLtG1IJAnomcjqGCcfiiwWlflvhc6aT9BA30xYDeEilIGc4OZpbHk0LBqfcCd7Jq49ZkMPTf8cgFo8Q4xcgm6tBblGDdtqjJw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(8936002)(31696002)(2616005)(82960400001)(36756003)(38100700002)(54906003)(6916009)(316002)(53546011)(6486002)(66476007)(26005)(6506007)(186003)(86362001)(6512007)(66556008)(4326008)(91956017)(66946007)(66446008)(122000001)(76116006)(64756008)(8676002)(38070700005)(508600001)(2906002)(5660300002)(83380400001)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cFBNRGRiazUxcTlnaldSOE1ES1Z2NVh1U0syNzBmajBWRndlNUl3THJ2ZDg3?= =?utf-8?B?UlhxRWpvRzFhU2piVWxOb2tRbHo5U1VIa2lJQTlNbjdsRjYrWWthYWo2ZHBL?= =?utf-8?B?eVA4OEVTcHNaTWxFV1B3akthcUZYN2JvbVAzdkdQY0dZWDFzS01FTkJFQ2pm?= =?utf-8?B?aEtwMlRCeTIxQnIrcXNodC8zaG1yaGczQXlNUld6VDd0Yi96N0xRRGtCMmFI?= =?utf-8?B?a1JYTW9LZTN2cXM5M2VXSllCV0o4ZDFUUGxGeU9pWmo4UnI1dlZDRk56TnU0?= =?utf-8?B?cFZiSFdyS1lPSzhmVkUrc1FGODIrSngwNWdpUkhkZjZqd2VIWG81RnR5SzhG?= =?utf-8?B?aWRCbjFKVlJZQVdacFpUbFByQURZeHNjMTlRa0lCM3BvZGZDaGNud3ZtQnpx?= =?utf-8?B?L3V3bVhhM2pna05vTmR2WjUyTk9vQ0tlRU53RjhUUW1QUytBOXVVN0FHdENs?= =?utf-8?B?RExoaTRjdEdTbkJuOEpqZXVWWWZXRU00SjlzT0FsNis5by84dU5lRXNKVkVZ?= =?utf-8?B?enlSUUk2YjF3UWRXT2gzU0x1V3VhcU5reTdPUmttc0tLNzRwc2oza1daMDhF?= =?utf-8?B?QmFZRGtZQXQyVkl0SHNSYmNzMzJJRm9VWUNFZHVqTExBU3pILzBiSTEyZXVE?= =?utf-8?B?TEVVamU0bHVTMFBWK2pMcDVHdEpKS3VyeGpqYm9XbmVURUtpWnowd0RMNkNy?= =?utf-8?B?R3ZVeHQ3WitnK2xrdlhaS2JaZlIyTm8vcVdqSUdEU3NpaDQrMHU5UGVlZ2gy?= =?utf-8?B?TkFlYjlaWlZBVUpNV3hIVkUyWTVxekFpYzIxb3FvV2FkeW82TTNBWER2WjY1?= =?utf-8?B?dmtCMnppL0NkUnNpeUpuZkF6cERPM2J4NWU3YVl3eExwbFlCZkU5eU5MaWV2?= =?utf-8?B?bDhpeGVEUWhIMkFwbmZGdkk1VWF5SXhuazl6WXE3ejI1R1NsQUc0R1VEb0cx?= =?utf-8?B?VmlTb3JFY25ka1B1TFhKcy9CUXFDNDQzN000U09paHdLQnVaVTZXN3JIUVc0?= =?utf-8?B?ZGZGSjZxVzFuL3l1S3lOKzFBOTVQVHZ1Y3BzNXlab2FZOHprcGR4c0JlTlMx?= =?utf-8?B?NGs2WGhib0tHdks4S0FqNkYwM0hvYlFwdnVUMnNoUmxCREQ0UnZxVmdFaHVy?= =?utf-8?B?aytlUEcxVFdHUkZ2UHNSTDd4ZEVaLzNFTm1taUhvMGpMRURMckN1U0RCKzg5?= =?utf-8?B?MVVwenhJVEYza0t4T1pqUjZLUzNkQ0REeXNEazEzWTllbnNNWkRiRHZsbk1k?= =?utf-8?B?R0JOSnJpdVpPVk9yWTZMTE9tMkJjV3RjSG00cEh2VlpncVB1d1MrQWw2aVN5?= =?utf-8?B?ZWEwVk5UNG0rcVpaTjFyK0IvYngvUFY3UEIvNTJhdFlyalN0K2FTYkkrTnFK?= =?utf-8?B?Y0dmaGIySHJpWnhkOU9oZWh3S3FWOEV6REN2MHhBVjBmWllVSGgxdWJlWlFJ?= =?utf-8?B?NkhYU3RTbFZPa2t5cFhvWmExRG9KaXZmSlpLN2VoZThTeDRqd1FXQTN0dUFn?= =?utf-8?B?NzVxeVlXaStrN3k0ejRiSGsyMW0xMHFiL2haRXd3Uk9EUEEyaXE4TzFyS01W?= =?utf-8?B?ZGxxc3ZheDQ2V1lrWGhvSkNaUklydGgrVTg4bmFLbUxJQVk2eGloYndmTkxs?= =?utf-8?B?eXpwelhrWkpwSnNnbnl0OWk1T0JFN05STEtWNTNxbU9rN3dNNjRzWUNYblRs?= =?utf-8?B?cHdaVHZRR1Rwb1Q5cGlYWUs2aXFsWDRzQXdGWHhzRVNlNUgrQXlXamw4OU5M?= =?utf-8?B?MzZLOHk0SjgxTmVQaHhCSkNUTEkxb3R5V3BmaERCZlkyMkpEYUcvaE5ZNkJM?= =?utf-8?B?ekltZkprSjFtU0dMM3l1aS9aVkY3Y2FNUUhzc1dNamRZVnFhdkYxTXQ0SS9K?= =?utf-8?B?dCtsNmczdHk0bS9wcGhkdTNPeGxrRHcxVXRjWVhLaEVJNk93dDYwcGlnUm96?= =?utf-8?B?Y0p2YWx6ZFpsY2FhTGorZ1E2ZnJPbmJRSElWUXJQWEliT3pOdGF6N1pXaHJn?= =?utf-8?B?VjhJbGFBdThGQkZHb2g3T3d1YWZ2Y1Fpb1NJUWh1QkZzbEFESEJremRRbnNa?= =?utf-8?B?dVU2YU95WGpmOVFBWUhMdkgvVkpiN3JoR2lzMmtNVGUrR2xSbmxmdHhRREw0?= =?utf-8?B?dlh5UFF6RTNNdWVQNzlFL3ZGSlBCVHdTZzBHZ3loL2RKMUVCUjZ3b01jZEV3?= =?utf-8?B?M0w4UFIycnk1cy9NUDI5T2c1dm5MZXhZZTNIcE9YempRamZ2ZThrVzdVUjE3?= =?utf-8?B?dVpEVUFzRldaNktkM25pMEZ6MVhKVThXbGY2eG0xU3NxUUk2eGxtMFNLUkxu?= =?utf-8?B?WGVCQkh5aXNwRzRjRE55TXdqSlMvcm5wMlE3U1AvRWo4WjN5ek9XVDBCcjlV?= =?utf-8?Q?Q5pz1SfyDgs1hPIo=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <6E0D07C57114D449A236F1AC795BABC5@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9c52a4a-36ef-4092-376f-08da3f381d17 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 16:52:26.4813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J17PjGZaNQXdXzCb3Er5grir5nVE9rcF8Lz0r+fV3tYKtNr5uFhkyp8dywkD6ZNWw92Cfe+xA5xxd/pMsj4rT2TBDId2ITZ4gEH2IRMr4Uk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3026 T24gMjYvMDUvMjAyMiAxNjozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI3LjA0LjIwMjIg MTY6MDQsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBtZm5fdmFsaWQoKSBpcyBub3QgYSB0cml2 aWFsbHkgc2ltcGxlLCBhbmQgY29udGFpbnMgYW4gZXZhbHVhdGVfbm9zcGVjKCkgZm9yDQo+PiBz cGVjdWxhdGl2ZSBkZWZlbmNlLiAgQXZvaWQgY2FsbGluZyBpdCByZWR1bmRhbnRseSwgYW5kIGp1 c3Qgc3RvcmUgdGhlIHJlc3VsdA0KPj4gb2YgdGhlIGZpcnN0IGNhbGwuDQo+IFNpbmNlIGl0IHRv b2sgcXVpdGUgc29tZSB0aW1lIGZvciB0aGlzIHRvIGFjdHVhbGx5IGJlIGNvbW1pdHRlZCwgSSBk aWQNCj4gbm90aWNlIGl0IGFtb25nIG1vcmUgcmVjZW50IGNvbW1pdHMsIGFuZCBJJ3ZlIGdyb3du IGEgcXVlc3Rpb246IElzbid0DQo+IHRoZSBsYXRjaGluZyBvZiB0aGUgcmVzdWx0IGluIGEgbG9j YWwgdmFyaWFibGUgdW5kZXJtaW5pbmcgdGhlIHN1cHBvc2VkDQo+IHNwZWN1bGF0aXZlIGRlZmVu c2U/IEl0J3Mgbm90IGFzIGlmIEkgY291bGQgcG9pbnQgb3V0IGEgcGFydGljdWxhcg0KPiBnYWRn ZXQgaGVyZSwgYnV0IGl0IGZlZWxzIGxpa2UgdGhlIGFkanVzdG1lbnQgc2hvdWxkIGhhdmUgc3Bl Y2lmaWNhbGx5DQo+IGp1c3RpZmllZCB0aGUgc3BlY3VsYXRpdmUgc2FmZXR5IC4uLiBCdXQgSSBn dWVzcyBteSB1bmRlcnN0YW5kaW5nIG9mDQo+IGFsbCBvZiB0aGlzIG1pZ2h0IHN0aWxsIGJlIHNv bWV3aGF0IGZsYWt5Pw0KDQpUaGUgZXZhbF9ub3NwZWMoKSBpbiBtZm5fdmFsaWQoKSBpcyB0byBh dm9pZCBhIHNwZWN1bGF0aXZlIG92ZXItcmVhZCBvZg0KcGR4X2dyb3VwX3ZhbGlkW10uDQoNCkl0 IGRvZXMgbm90IHByb3ZpZGUgYW55IHByb3RlY3Rpb24gZm9yIGFueSBvdGhlciBsb2dpYy4NCg0K SW4gcGFydGljdWxhciwgaXQgZG9lcyBub3QgcHJvdmlkZSBhbnkgc2FmZXR5IHdoYXRzb2V2ZXIg aW4NCmdldF9wYWdlX2Zyb21fbDFlKCkgYmVjYXVzZSB0aGUgbGZlbmNlIGlzIHRoZSB3cm9uZyBz aWRlIG9mIHRoZQ0KY29uZGl0aW9uYWwganVtcC7CoCBpLmUuIHlvdSd2ZSBnb3Q6DQoNCsKgwqDC oCAuLi4NCsKgwqDCoCBjYWxsIG1mbl92YWxpZCAvLyBsZmVuY2UgaW4gaGVyZQ0KwqDCoMKgIHRl c3QgJWFsLCAlYWwNCsKgwqDCoCBqZSAxZg0KwqDCoMKgIC4uLsKgwqDCoCDCoMKgwqAgwqDCoMKg IMKgwqDCoCDCoMKgwqAgLy8gbGZlbmNlIG1pc3NpbmcgZnJvbSBoZXJlDQoxOg0KwqDCoMKgIC4u LsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8vIGFuZCBoZXJlDQoNCg0K VGhlIGNoYW5nZSBJJ3ZlIG1hZGUgaXMgc2ltcGx5IENTRSB0aGF0IGEgY29tcGlsZXIgY291bGQg ZG8NCmF1dG9tYXRpY2FsbHkuIGlmIGl0IGNvdWxkIGJlIHBlcnN1YWRlZCB0aGF0IF9fbWZuX3Zh bGlkKCkgd2FzIHB1cmUNCih3aGljaCBpdCBsb2dpY2FsbHkgaXMuKQ0KDQpJZiBsb2dpYyBpbiBn ZXRfcGFnZV9mcm9tX2wxZSgpIG5lZWRzIFNwZWN0cmUgcHJvdGVjdGlvbnMgZm9yIGFueQ0KcmVh c29uLCBpdCBuZWVkcyBpdHMgb3duIGV2YWxfbm9zcGVjKCkvYXJyYXlfYWNjZXNzX25vc3BlYygp L2V0YyBiZWNhdXNlDQppdCBpcyBzcGVjaWZpY2FsbHkgbm90IHNhZmUgdG8gcmVseSBvbiBpbmNp ZGVudGFsIGxmZW5jZSdzIGZyb20NCnVucmVsYXRlZCBwcm90ZWN0aW9ucy4NCg0KfkFuZHJldw0K DQpQLlMuIEkgbmVlZCB0byBhZGQgdGhpcyB0byB0aGUgbGlzdCBvZiByZWFzb25zIG9mIHdoeSB3 ZSBuZWVkIGEgImNvZGluZw0KJiBzcGVjdWxhdGlvbiBzYWZldHkiIGRvYyBpbiB0aGUgdHJlZS4N Cg== From xen-devel-bounces@lists.xenproject.org Thu May 26 17:11:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 17:11:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337692.562360 (Exim 4.92) (envelope-from ) id 1nuH0j-0002OZ-EQ; Thu, 26 May 2022 17:10:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337692.562360; Thu, 26 May 2022 17:10:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuH0j-0002OS-BT; Thu, 26 May 2022 17:10:57 +0000 Received: by outflank-mailman (input) for mailman id 337692; Thu, 26 May 2022 17:10:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuH0h-0002OM-Ht for xen-devel@lists.xenproject.org; Thu, 26 May 2022 17:10:55 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0606.outbound.protection.outlook.com [2a01:111:f400:fe07::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc3ac233-dd16-11ec-837f-e5687231ffcc; Thu, 26 May 2022 19:10:52 +0200 (CEST) Received: from AM6P192CA0051.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::28) by PAXPR08MB7381.eurprd08.prod.outlook.com (2603:10a6:102:22b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 17:10:51 +0000 Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::38) by AM6P192CA0051.outlook.office365.com (2603:10a6:209:82::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 17:10:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 17:10:50 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Thu, 26 May 2022 17:10:50 +0000 Received: from f4fbc7838ef5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A533AAAA-24D4-48E1-94C7-42343DA66F13.1; Thu, 26 May 2022 17:10:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4fbc7838ef5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 17:10:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by VI1PR08MB3023.eurprd08.prod.outlook.com (2603:10a6:803:4e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Thu, 26 May 2022 17:10:42 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5293.013; Thu, 26 May 2022 17:10:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc3ac233-dd16-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QotCX9UJ6L+witQgMtSnwAljFP5agSW/iMsD7ncCIz7QgakIOPh6UH3EBEfcEumHFO009n01ahQPyhyYNMQz8Bt/MwPOq9wPRJ69lQvYRjq772J+H+5pggtgWf3qNa09CnMb2V1UE2jKGo4iy5fvmUe2Arb6BYlrsEMJcnqdbAm/s9m0xjX1Yywdn2Xxxzjw1w+JyWIZFTi1P66szAmwjuERuVwutVp4YTcElfYFmHIqt3hlqrOoECYr8VJzzUD5hg7X5kAF22KrH4n9Rdbw10RDIvnfLnB9By9MfRQtrPOre4lW21R2SCsuWXHfzRfjqIJKvjsqZql5XulFSker4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=T6UG6EpCRaio0+dMP0a5Z5dCPGdaQN9vYiU/K2FtYYuS9T8mQSS+f54xIWP4Lrf7d5QwQqI9O6CTWKxqlJJqHPgD0UqJh8QJJX0o5yvY/8pYUUEFyJkBQqvjXos82pomlbFW0rxhVZAIRsQhdHlTvylha/3xnXMzVI0UPJu72Nbad40QEeFtcjhYtbwmF/mS+e+0LU5lD2goHdoAAsNw96jkCMCjAb4lGatRcc6IlCupthriju+InOvLyvKGDCnPzlsVhM/Gc1lWaOmmdQz/62KIy6M4NG89biJAXozcEzGsOQxGRJqaW6iSB2sQT5/EGm3LbYOlJBhUrL3IRGgviw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=3AsNMhHPjr+TP6kquio6Jsg6QPTWygzTDn/9uHEtL86jQk+mrgf6XIGEm2+x+/nRdBHBKpTYzOjdmgh1V7eha5ZFazEox72nBHa0LBa6DIWUHH3u3WPls6EYgh4zEiamCdDO8fU0/LcR3zTBv6w+hfSFI/oXxNVecdkVJXsWWTI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 11788fa01fdad42e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GuCwCsAEpYxAitZWds6aQU73i0ULoVxS6TpD8z0mOXyx467NkyVm82n6BT7fHJXZgHYgHwxh0X0NDjow9A/HiE2T1k1wZ1PoSXbmc+F8bIPrMxuCKJH9GOuKoFtROpL8G/15mGTHnVfKWjvzd8KFr2WUu0t0C57uysJDfyghgEg0M1sp8P73P2Jk5hLtDL1tEIP8RuTRJ+/cyBnT4PDXpWcYGdmz84foCZ8FFqy/l8xAFpnxEez9r143yjB7GTYNNlNz6cp4SCSRD2csoKcZN8Mr6pVg3fwfUcbr3FYFgjfWVytJq1f4jW88zmfaUKaTj6FdbXgv7e9rSnQfaYNJxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=Vs4SmI45QAUqc1Cd6OkERIz6lVxoV4KmwOeAH0PgfZl+usniFfFxdk7HYgvNNKke4oRu2YLvs3tP3Bzo6W703vUI/Ghs7brCFCMjhrA1brUSm0GpSoDNbcTYoRaFLBB27hCkwQQAeNwmSwdVIZY2E/PsqRRJ9eEw+tisdMyoCeZZkELl6vhLnGQ/lsvZtx/C4tu2E093/6uOLyk522aezNmPshVYfFqZPu8b1CbxemDgyQeM0PxC8YCwvUdhUx/DkyQT2MFfEQu9qUexnzh7TTLVxW60Yxxk89ijS57OTDGFnEzlIN5NZlME2KSF3krB8v9x5v0ZfpWtiknpoIrOjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpvzNHiD8VClRALkv4375mtkPFgx7vVjAUEl46ExAYw=; b=3AsNMhHPjr+TP6kquio6Jsg6QPTWygzTDn/9uHEtL86jQk+mrgf6XIGEm2+x+/nRdBHBKpTYzOjdmgh1V7eha5ZFazEox72nBHa0LBa6DIWUHH3u3WPls6EYgh4zEiamCdDO8fU0/LcR3zTBv6w+hfSFI/oXxNVecdkVJXsWWTI= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first Thread-Topic: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first Thread-Index: AQHYbENEz/LzQKbbT0SYYuE1BYAePK0xboeA Date: Thu, 26 May 2022 17:10:41 +0000 Message-ID: References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-15-julien@xen.org> In-Reply-To: <20220520120937.28925-15-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7a2539aa-2ad8-40b6-3dfa-08da3f3aaf0d x-ms-traffictypediagnostic: VI1PR08MB3023:EE_|AM5EUR03FT026:EE_|PAXPR08MB7381:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7vKtined+Edi214nLq6HjOkhuH2KoQOIr1129TQy1MqIMd50ckDoXIMVtAYBg3lTMxHgo2ysx1NCo0Du1X+ll5y4Mhe8LGqJg8AmL6TM+AxlD7sFMsZkzWY2aL/xYZEbPQOeNZLN9iYuC9ZJKIpaUTOtdkyXmpO39sr52UpAZiZvbmzzUI9fXSEnR+Xt8gnAVX8zgdShaRb8QvbxJ1Q+dZV+TqSCpxACbR4zMArKXBnV3uT294MLmASclIjnj0AmykXi+ffBOJrRxNdmigOE3aII5lxC4WFEY/QoBUOvktdQBgx/2RrxTDICfyiOfi/E/2dkgYLdmQ2uV6edOMbIRxZ4BOVU41vZeNsvnItp5PxRmv9ZbsdHZ6ll427R0vtKytmUKNWlo3olUrixKlOn3oCyEPU+CoJrxNiCd5cLnoEkhpCSiSc8xSWqXuFvn1GNaJI6VCC01fLvk3FXulXGRkyRlCCoX1s1ZllQ/g5nX26yLiqFnEo1KG30u65kwcCZPlCKo1SfPE1dBv/kjrQmDx0gbe9pP0ENl1BgbDNFCi7wrV6IA+hTpyuxwcOO5Dgg7sT/sNH1WvVeuJhrHZvue42aYqOkXnU4v+2EE5Hs08mfMGsL0A4P6dhWgv4xrAB/wXvztAOkqdyBiDBBaX8ublYTKfC8jAZ5qfAA2bcmwJeIzr+faTu91iUp3DaGkWfbDJoUqN3Ov16SFKitXDP8IOc2g3CcHtrzDFobAH4cAOW1H3d05DdoerAMrgIVzpoR X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(33656002)(86362001)(66446008)(66556008)(508600001)(6916009)(54906003)(91956017)(71200400001)(8676002)(4326008)(66946007)(76116006)(122000001)(66476007)(8936002)(36756003)(5660300002)(316002)(64756008)(26005)(6512007)(6506007)(53546011)(2906002)(38100700002)(38070700005)(2616005)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <893A45DEF6D75448BA134B1FE5FC77EA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3023 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5339612b-20bb-4830-66e4-08da3f3aaa00 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kcr8/Z4HEw1tNRgz97qDUTEP80PFNxl9XkS8jwQKWwslguSaJiuWoclMoRJqqNrHvFDF+gRJ0Yacd4P2RM357L0J1eILJUj3PruBIcMVaN1MzhoXMBh/QVxNgJ01PWiWcOoJWttAvkc6vDD2GWkCvGFXuqA+M2H7vILlN7gjARaQhC32YisRKASNyC3Er8swk8/Fq0Gtab0kShgQd7YWb8SdTcLt9vPULE6sHbDiWFe4rTWtiL2YICnvkbgFN5VIHpd3kA/DhnAGhxd89HNDNayq1UYXEp2q/CiB/d0TE2Kb9+qVa/kn9KsKluXKkNVPH4fzSkoZ/UepRcuG373kuZkVUY0xOeZayphcPBH2CGgW8DkSN6XR6NQpb+pX2oridCrvr7ip3paRDk2r+OHOdbVTFp8YYgjnQ7KrtTHSpsUFBgMdU1OuMfmYN/SZmp6tIuwUWpoPcdDh95An673sdzs20C4tUmy5x1Js9hFLikKUR7/BXZ0Z+PWB717iH8SvZMZDeC2Eh6PVUL7syndgAgcmwFVo7EYSU23jENLzws6JvCQpLjz3JRkdyZOvhEOPV7/wpmmPVkuByQu5ugGT7l3TSdrixKS+e0vzCevYeicWLkQXHcJ+ludlC3xmEg39EN3KvJi74CBKeGTQgXJ/feyBzYrZfEBFO4Dv/2yhTdlq1ankJaC4kyWU2kjFlLOA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(86362001)(54906003)(36756003)(82310400005)(2906002)(186003)(2616005)(336012)(107886003)(53546011)(26005)(8936002)(70586007)(40460700003)(4326008)(5660300002)(47076005)(70206006)(6512007)(6862004)(8676002)(6506007)(81166007)(316002)(36860700001)(356005)(6486002)(33656002)(508600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 17:10:50.3255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a2539aa-2ad8-40b6-3dfa-08da3f3aaf0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7381 DQoNCj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjA5LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ DQo+IA0KPiBDdXJyZW50bHksIG1lbW9yeSBpcyBhZGRlZCB0byB0aGUgYm9vdCBhbGxvY2F0b3Ig YWZ0ZXIgdGhlIHhlbmhlYXANCj4gbWFwcGluZ3MgYXJlIGRvbmUuIFRoaXMgd2lsbCBicmVhayBp ZiB0aGUgZmlyc3QgbWFwcGluZyBpcyBtb3JlIHRoYW4NCj4gNTEyR0Igb2YgUkFNLg0KPiANCj4g SW4gYWRkaXRpb24gdG8gdGhhdCwgYSBmb2xsb3ctdXAgcGF0Y2ggd2lsbCByZXdvcmsgc2V0dXBf eGVuaGVhcF9tYXBwaW5ncygpDQo+IHRvIHVzZSBzbWFsbGVyIG1hcHBpbmdzIChlLmcuIDJNQiwg NEtCKS4gU28gaXQgd2lsbCBiZSBuZWNlc3NhcnkgdG8gaGF2ZQ0KPiBtZW1vcnkgaW4gdGhlIGJv b3QgYWxsb2NhdG9yIGVhcmxpZXIuDQo+IA0KPiBPbmx5IGZyZWUgbWVtb3J5IChlLmcuIG5vdCBy ZXNlcnZlZCBvciBtb2R1bGVzKSBjYW4gYmUgYWRkZWQgdG8gdGhlIGJvb3QNCj4gYWxsb2NhdG9y LiBJdCBtaWdodCBiZSBwb3NzaWJsZSB0aGF0IHNvbWUgcmVnaW9ucyAoaW5jbHVkaW5nIHRoZSBm aXJzdA0KPiBvbmUpIHdpbGwgaGF2ZSBubyBmcmVlIG1lbW9yeS4NCj4gDQo+IFNvIHdlIG5lZWQg dG8gYWRkIGFsbCB0aGUgZnJlZSBtZW1vcnkgdG8gdGhlIGJvb3QgYWxsb2NhdG9yIGZpcnN0DQo+ IGFuZCB0aGVuIGFkZCBkbyB0aGUgbWFwcGluZ3MuDQo+IA0KPiBQb3B1bGF0aW5nIHRoZSBib290 IGFsbG9jYXRvciBpcyBuZWFybHkgdGhlIHNhbWUgYmV0d2VlbiBhcm0zMiBhbmQNCj4gYXJtNjQu IFRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgb24gdGhlIGZvcm1lciB3ZSBuZWVkIHRvIGV4Y2x1ZGUg dGhlDQo+IHhlbmhlYXAgZm9yIHRoZSBib290IGFsbG9jYXRvci4gR2F0ZSB0aGUgZGlmZmVyZW5j ZSB3aXRoIENPTkZJR19BUk1fMzINCj4gc28gdGhlIGNvZGUgYmUgcmUtdXNlZCBvbiBhcm02NC4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+ IA0KDQpIaSBKdWxpZW4sDQoNClNlZW1zIG9rIHRvIG1lIQ0KDQpSZXZpZXdlZC1ieTogTHVjYSBG YW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQpJ4oCZdmUgYWxzbyB0ZXN0ZWQgb24g YXJtNjQgcGF0Y2hlcyB1bnRpbCB0aGlzIG9uZSBhbmQgbm8gcHJvYmxlbS4NCg0KVGVzdGVkLWJ5 OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu May 26 17:25:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 17:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337700.562370 (Exim 4.92) (envelope-from ) id 1nuHET-0003ux-LL; Thu, 26 May 2022 17:25:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337700.562370; Thu, 26 May 2022 17:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuHET-0003uq-IG; Thu, 26 May 2022 17:25:09 +0000 Received: by outflank-mailman (input) for mailman id 337700; Thu, 26 May 2022 17:25:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuHER-0003uk-Ry for xen-devel@lists.xenproject.org; Thu, 26 May 2022 17:25:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061a.outbound.protection.outlook.com [2a01:111:f400:fe02::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c8e6f81d-dd18-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 19:25:06 +0200 (CEST) Received: from AM5PR1001CA0019.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::32) by VI1PR0801MB1967.eurprd08.prod.outlook.com (2603:10a6:800:8c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Thu, 26 May 2022 17:25:02 +0000 Received: from AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::f6) by AM5PR1001CA0019.outlook.office365.com (2603:10a6:206:2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 17:25:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT053.mail.protection.outlook.com (10.152.16.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 17:25:02 +0000 Received: ("Tessian outbound 32b886dfa5b9:v119"); Thu, 26 May 2022 17:25:02 +0000 Received: from 9473e4dcd9f3.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA800B6A-56E8-4C76-B935-FB6560F4EE2E.1; Thu, 26 May 2022 17:24:55 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9473e4dcd9f3.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 17:24:55 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB7168.eurprd08.prod.outlook.com (2603:10a6:20b:3de::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 17:24:53 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::1017:8b09:6681:c914%5]) with mapi id 15.20.5293.013; Thu, 26 May 2022 17:24:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8e6f81d-dd18-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NYRzfJfCPllLhDCUp1CCKc8YSohgh7F8rQNaJ+C0YXbYB4MD4QU0PRspkZCSnZZ/socih7f6Iwdj7ARXxaR8OYdyEJt+XXWwbZ7DPY57I7g04SDieSeHBhgxgpLsZkihYQqWHbOcKbzhv0GCSMogPHlR6wnvrjPKW7Ec12OecYLe6WBZTyzXh1MxN4FJ8eNgkPa6DH+7+hJbP288kYmJb3C6GU1VDDV2qeJLWmbmOFEXCA7bD0y/jry9ASsEs4m+jtTdGoepS9fSeloAKLc2UkBC93Zsima3Bx/PW19WPd/bIKRMO627toO8MOhMNe1BbMLpjp04lt4HlWMzRWQc8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PCSEX0nBERCzualkpGiO0HyVt6CrU3P8gN63a6EwR6A=; b=FJglSwtmGhzpTwHN/BvFQS+zl1fut4PaBUiv1DikioneyMkYBbaf0HLJU/zQMq16d4qgiV9cg53RbStm3J6XmjcHDeBTQ7NbVy4c9QwKneJa3oPDkJGMeOntwKQpP3H1hgbYmoINaqJlMK5l5n4lqV2O8cD2C2CtEuq2cw3FHjyo4cQLZvBT2yWoVXa1CSHnjH4OB1NrwoeInrB0wvoS//68NSNaYCb4ELvJBe/fmnLlQdrcBomUX+F85i0udnKMnuZeaLiccxQ9RUC5AkFMA4IAj6Q3yfum4/+AGGm3Bc2HGupwnK6guWZbuKPDwa65VetQ8ZQCRSdjvRCQeyDmFg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PCSEX0nBERCzualkpGiO0HyVt6CrU3P8gN63a6EwR6A=; b=ZjMjvhtFr08UCg02PgvxV8iW0rWon7WcMEFVCEI3XdaDSaSmpbRM13jfpm4sG+XxNjEPT2ZJhW0WIi11tZYVLGMvTphjmhNFXH1smT29/sK8FAmsdkFxZ+JeB0p7fRMOiuOh4r0zaYIq37NZIXgJQ5vmipvZ40YgjEIFvPzgx5U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e25b8f619eaff8d4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MnofBquD/N7NWUPZX5WNlyOB/G8RAbIXu+kAkZru51mSVNyLk1JIifRSO+KR563eJoV/BcEMd2PoXTaVUWlif5zBxUAtZBPFmpU2LLjop0Yhn4xthg0c4IHfGbHLjFo4p4/T2I0L12NzYgqIq5zlfG3fw9ZwCAjhAagMzJGsZtaGrIhGkNEjHX6YApT9YzwlBeNDGwHpl1fpkYTZghB9jpc6xGquGbUgY123S1rLEo0e7MKU2+U79rZNI0fO6jwsm0lVnbrz4pO3fvNcKfh4e19ozp2CAGxPHmFQyv16EPVky+VDUeDQv7aXpUIIBQ9IRQftK5IqK5gfWn26OvmpYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PCSEX0nBERCzualkpGiO0HyVt6CrU3P8gN63a6EwR6A=; b=LVIkHMBKs1uwRUX/LGu1IHsh4NyFNW6+QqyO5wVfrFdOU9aFVXoYWYKXjmWozY1nPi6WawoixUqRozYeKTiuJvNp5G9rimiEXfY20IcRcAADt4iAPnew7xi9924K04j4NwJhLUbTA+agc1Bc4AKV6HgJqlf/UFCMoGV3f5afVJtweVRdzyh/j/rUe3WgvCYd11bqrCxXJTc1SGS/1QUmHurfExs6witFR774psOp4xx5eeJbeaxYejMVmsqEW5vwm1VuAG0N8eLDbb6sEwNu/FMposPiR0ic7/GbK3Gk4iRkjh5W6ucZrgpD/oh36HNJab7fhHUHU/wJ7R4ZlYnn7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PCSEX0nBERCzualkpGiO0HyVt6CrU3P8gN63a6EwR6A=; b=ZjMjvhtFr08UCg02PgvxV8iW0rWon7WcMEFVCEI3XdaDSaSmpbRM13jfpm4sG+XxNjEPT2ZJhW0WIi11tZYVLGMvTphjmhNFXH1smT29/sK8FAmsdkFxZ+JeB0p7fRMOiuOh4r0zaYIq37NZIXgJQ5vmipvZ40YgjEIFvPzgx5U= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH 16/16] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen() Thread-Topic: [PATCH 16/16] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen() Thread-Index: AQHYbEM/BMBjdfN7F0Sb3zQIEpLBR60xcn+A Date: Thu, 26 May 2022 17:24:53 +0000 Message-ID: References: <20220520120937.28925-1-julien@xen.org> <20220520120937.28925-17-julien@xen.org> In-Reply-To: <20220520120937.28925-17-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 545ef682-97ed-4e08-6f3a-08da3f3caaf6 x-ms-traffictypediagnostic: AM9PR08MB7168:EE_|AM5EUR03FT053:EE_|VI1PR0801MB1967:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a0YS1RiAo4i+aVSOi4GajDvKEBTxY8VpU1VXrUds2f1PRzFITZjO+gUNvLsAOW8CebjMLjRRSyPt6audI2GBLuz7vAHg5RCdP7o/bQOAUMZEqmz9k6PhzwDfT/YQFjxZlO47Nxwt4B3khvYpudti4kVLhAaJJBdSOMc/neMWbrIbV7gCoNqCgnGPhAQHIC3W9Fhe7SjKBd8iIKM20gZFN5hZ5DrV16uTE961DPhlzaoNMMkRKb5iQkfok0xHo5nn9L48meQLbBjCBIo0ODYGovNZ/Po4NiCQat6RWftnLCpprNPlwZIXxahcO2bwjKwuwMIgztwsonxXXrUjsHwZOY2XymUi6XPjLXkoS2QU8jt7IsFNHpzgMwLEUO4NKrxmKKmx7y27fqxGe7sVWdGP70fA+RWn10hUiZHFE3vuumzSt3s6tbHex9CkXdE5KZ8//Hb1Pqp3fPNz2jtFLfM8y62/A+NXtw2trVXLex5f6sB7gP1WqTAIRKIGu3Oeh8SVIjSbZ0Z/xXws9zrm2bW0eqjWl/CmWfa4gTfNYn6KeOh6bvmpenM6DQ4n3BjB2ejkmmvdImkTd7rvs+zvKLx6z55Cdu58c4ypAzcbRyiGJndqs90ZRiQnCZvZeE6dRN60x7HU1VjtTONBNeE84q4MRMD0bF1gu5vlIqAG0elvND1X6iC0FR5LUe05mqRjQE+fZZXnngeNE5/al3qxtyEzapXrA2ffMe7mZWqe/xjyXXKOS8ft7dqc+FT7hfppOvQ/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(4744005)(8936002)(33656002)(71200400001)(5660300002)(26005)(6506007)(508600001)(53546011)(6512007)(66446008)(8676002)(66476007)(4326008)(66556008)(64756008)(91956017)(86362001)(66946007)(2906002)(38100700002)(122000001)(38070700005)(2616005)(186003)(54906003)(36756003)(6916009)(316002)(76116006)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5E1FD8C06BB1744285ED31A2D9EF5238@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7168 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1720b0e8-0f0b-473a-42a4-08da3f3ca5d2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4J9f4q3h45C/bigdDVKxL7FjegH590y0Pa2R0iRUt+CHssL2QXjDQy20jefUDf8zYPfi+4DM654/EAzXYV+Car7OlKhEMMD01dUN8dPk3zWlAbU1jFBT3zJsKnisO3TzybDnbahy6V3VwbG6Hcrm9pVBXBx7wyNQrojbzKKOL3cvaNpmLUt0aob93J/awJ1IxVNt75Je7v75+b25L/0SUPqXw8MpOzxrfKZ/o//c13AQcZAX/0nLUF8uKLuvUpSnazSaouEMtP31foJtVbnLUXgETjflqxEfk8dnkz0P8N5pnzPe4+OT2Iy1QavnL26/B6vLLv8LxQIFxnxCY+D2dAgLpcdsbkSFcBvKvPTIIBEW1F0Y/DwVWCX7PAYW4rhUcp1pYINx5SiwBWtl+KZ9QLWohmWi73QYAQzMcxSnkOQ7tzx2/GEFtYVzToNTm9baKFGUdbaXfcG7nxnKErSS8fY8alm2tACayRpXrXaBDDYUTzW1Facjn30LYAxRDjotudmYP3r4ymg3XzanEqXUaF4G1wSi4ODtwa/gv5vvB3Vqw1lqrQceRpZ9U5EPLnAZk8FxIsCqINA6Nn7tgURsPo2sjIJHQ8/KbRYvXLjmkeJAXE7nGzFrAEhKJEiYhZ4wLNi4NjaQK6UPExvi/mS+SaMqFcVeZz0VVmddEzOOnlNQ2xvkY1pWBtnaJJi1AsPc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(186003)(47076005)(82310400005)(81166007)(54906003)(336012)(36756003)(36860700001)(6506007)(356005)(70206006)(6486002)(40460700003)(508600001)(316002)(53546011)(70586007)(2906002)(2616005)(107886003)(26005)(8676002)(6862004)(4326008)(5660300002)(4744005)(33656002)(8936002)(6512007)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 17:25:02.4586 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 545ef682-97ed-4e08-6f3a-08da3f3caaf6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1967 DQoNCj4gT24gMjAgTWF5IDIwMjIsIGF0IDEzOjA5LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5j b20+DQo+IA0KPiBOb3cgdGhhdCBtYXBfcGFnZXNfdG9feGVuKCkgaGFzIGJlZW4gZXh0ZW5kZWQg dG8gc3VwcG9ydCAyTUIgbWFwcGluZ3MsDQo+IHdlIGNhbiByZXBsYWNlIHRoZSBjcmVhdGVfbWFw cGluZ3MoKSBjYWxsIGJ5IG1hcF9wYWdlc190b194ZW4oKSBjYWxsLg0KPiANCj4gVGhpcyBoYXMg dGhlIGFkdmFudGFnZSB0byByZW1vdmUgdGhlIGRpZmZlcmVuY2VzIGJldHdlZW4gMzItYml0IGFu ZA0KPiA2NC1iaXQgY29kZS4NCj4gDQo+IExhc3RseSByZW1vdmUgY3JlYXRlX21hcHBpbmdzKCkg YXMgdGhlcmUgaXMgbm8gbW9yZSBjYWxsZXJzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVu IEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdy YWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gDQoNCkhpIEp1bGllbiwNCg0KUmV2aWV3ZWQtYnk6 IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KSeKAmXZlIGFsc28gdGVz dGVkIGFsbCBwYXRjaGVzIGluY2x1ZGluZyB0aGlzIG9uZSBvbiBhcm02NCwgYm9vdGluZyBYZW4r RG9tMA0KYW5kIHN0YXJ0aW5nIGZldyBndWVzdHMsIGNvbm5lY3RpbmcgY29uc29sZXMsIGRlc3Ry b3lpbmcsIGRvaW5nIG5ldHdvcmtpbmcsDQpubyBwcm9ibGVtIHNvIGZhci4NCg0KVGVzdGVkLWJ5 OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu May 26 18:46:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 18:46:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337709.562381 (Exim 4.92) (envelope-from ) id 1nuIUd-0003Ps-Ni; Thu, 26 May 2022 18:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337709.562381; Thu, 26 May 2022 18:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuIUd-0003Pl-Kk; Thu, 26 May 2022 18:45:55 +0000 Received: by outflank-mailman (input) for mailman id 337709; Thu, 26 May 2022 18:45:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuIUc-0003PZ-Po; Thu, 26 May 2022 18:45:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuIUc-000819-Gn; Thu, 26 May 2022 18:45:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuIUb-0006yo-VM; Thu, 26 May 2022 18:45:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuIUb-0003DE-Ut; Thu, 26 May 2022 18:45:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2gV+E5Jk9MXqQRK3Li7Gmcs9TE/gNCaa5UuQWCAzV6Y=; b=z+iNfGFZSzcGSeU/7N1h8MuTOM PLRI3TFRp+gtb+akJ1ch8hczibKYrxHhPcyw1Rety0e3si9tXip1H2CTJQAbY9SbHOqqk/HEosTn6 zOQf5AyVVog6fNyR4Cmms7/EbAW+MQV/SdNS/ddQLGYUUQbrF/JaHYM2GKOaXPKQWY1c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170745: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=babf0bb978e3c9fce6c4eba6b744c8754fd43d8e X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Thu, 26 May 2022 18:45:53 +0000 flight 170745 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux babf0bb978e3c9fce6c4eba6b744c8754fd43d8e baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 2 days Failing since 170716 2022-05-24 11:12:06 Z 2 days 6 attempts Testing same since 170745 2022-05-26 06:14:59 Z 0 days 1 attempts ------------------------------------------------------------ 1436 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 144324 lines long.) From xen-devel-bounces@lists.xenproject.org Thu May 26 19:24:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 19:24:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337719.562393 (Exim 4.92) (envelope-from ) id 1nuJ5q-0007cH-QL; Thu, 26 May 2022 19:24:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337719.562393; Thu, 26 May 2022 19:24:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJ5q-0007cA-MO; Thu, 26 May 2022 19:24:22 +0000 Received: by outflank-mailman (input) for mailman id 337719; Thu, 26 May 2022 19:24:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJ5p-0007c4-AO for xen-devel@lists.xenproject.org; Thu, 26 May 2022 19:24:21 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 706d43fb-dd29-11ec-837f-e5687231ffcc; Thu, 26 May 2022 21:24:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BEC73B821FE; Thu, 26 May 2022 19:24:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3206EC385A9; Thu, 26 May 2022 19:24:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 706d43fb-dd29-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653593057; bh=FaQJZ2JMQvTP42Xv4Qw4xG99LJs/Cl0cyg56TOhbd2M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=b7e/ZpHl21quwhMedu0UPNtWDxSCDpKyMCdfjjxuo4G58HcYume7sLZ5s0C+HEpkE E79q5Bopj87d90gsb0R8DTjrb5AxW93SpQiJdxrjeB+q2Ek1C8aHp/a9aNvIDwgc3A g1KI/TvMNN28nGb4U1mcMk4iXg8sHDUlmto/6qpLOD8wzaLPLG/jd2JDJzbUx1HfUY k+83B+3qaR0OWodglDbL6Tvt9rA0YiWSTKXHKcvA61YZ6bo+TqK+yAaRy5M3AuHwmR MgYkUbKWdqaT7qTy62PsuHfzlLz5xeNfXzh99hTnF/pF/52p4SoNW+LQs/P0Rp6Rz9 Q1H+hZX2XTMJA== Date: Thu, 26 May 2022 12:24:13 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Naresh Bhat cc: Stefano Stabellini , "jbeulich@suse.com" , "andrew.cooper3@citrix.com" , "julien@xen.org" , "Bertrand.Marquis@arm.com" , "roger.pau@citrix.com" , "george.dunlap@citrix.com" , "xen-devel@lists.xenproject.org" , "Artem_Mygaiev@epam.com" Subject: Re: [EXT] Xen MISRA C meeting In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1670394745-1653593057=:1905099" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1670394745-1653593057=:1905099 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Here you go: https://cryptpad.fr/sheet/#/2/sheet/view/D+wMnbxNO7Acp1NbXEFrJtcQoOJxpuxZMTXXl+w31og/ On Thu, 26 May 2022, Naresh Bhat wrote: > Hi All, > > Can someone please share the "MISRA C Rules For Xen" read-only excel sheet link? > > Thanks and Regards > -Naresh Bhat > > ___________________________________________________________________________________________________________________________________________ > From: Xen-devel on behalf of Stefano Stabellini > Sent: 26 April 2022 08:04 > To: jbeulich@suse.com ; andrew.cooper3@citrix.com ; julien@xen.org ; > Bertrand.Marquis@arm.com ; roger.pau@citrix.com > Cc: sstabellini@kernel.org ; george.dunlap@citrix.com ; xen-devel@lists.xenproject.org > ; Artem_Mygaiev@epam.com > Subject: [EXT] Xen MISRA C meeting   > External Email > > ---------------------------------------------------------------------- > Hi all, > > I would like to schedule a meeting to discuss Xen and MISRA C with the > Xen community. I have a proposal on how to make progress in terms of > MISRA C adoption in Xen and I would like to get your feedback on it. > > The meeting is open to anybody. The Xen x86 and ARM maintainers' input > is required to make progress, please fill the Doodle poll by the end of > Wed Apr 27 if possible. > > https://urldefense.proofpoint.com/v2/url?u=https-3A__doodle.com_meeting_participate_id_elY67vja&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=RXJFzR > OO9nXScR8aaDkNU6ZCmkfPIaIv0GMuOJ1P5rM&m=qEY_7qRui0kIvfEnpRFfdtfI2fE12_6V8maCMKbla1KKnepLZFDxyEWmawRDbWrf&s=_S_U8vNb535pEdAHS77PMn-zepxQNH > _2gRu-qFht_ls&e= > > If no slots work in the Doodle poll for everyone we could consider > re-using the Xen Community call slot (it is one of the Doodle poll > slots). > > Cheers, > > Stefano > > > --8323329-1670394745-1653593057=:1905099-- From xen-devel-bounces@lists.xenproject.org Thu May 26 19:57:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 19:57:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337727.562404 (Exim 4.92) (envelope-from ) id 1nuJc4-0002WD-E5; Thu, 26 May 2022 19:57:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337727.562404; Thu, 26 May 2022 19:57:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJc4-0002W6-Aq; Thu, 26 May 2022 19:57:40 +0000 Received: by outflank-mailman (input) for mailman id 337727; Thu, 26 May 2022 19:57:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJc2-0002Vw-Hp for xen-devel@lists.xenproject.org; Thu, 26 May 2022 19:57:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1674e34f-dd2e-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 21:57:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE2CC618EC; Thu, 26 May 2022 19:57:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3FE4C385A9; Thu, 26 May 2022 19:57:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1674e34f-dd2e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653595054; bh=mjbEiFlqfvN+ed8od2LCKNRZ1yCNibfLU700yFG6aOk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LV+CC89jKUn9TVfsrJLE+1lp5NSlBLfljb2guhPUUUgatZwMItgxr+DoGebDQaZhe gqaOx6u1dU40wKgyf0LM/TE1ns3VoEj5tJ0sc9XXf9gdTFvNKOCd7vl7o2r6pXHMQm EECZl9TLKfUUzgDEEY6/8IxP1yEXdFcyXdwQjrUn7lYxExZw0JkmSB6QJdX3ecIB7q VlaFdbIndNCQoDxpga9HTcXqUR6rwJhp9LL89/lup/3wBiMX8NB3fF+1chKkwGCjr0 Kc5e4HWIxX/NwoMxj8jQVICsySreg3Wm2IYKWT/Q0MPvJZ2QdP0aY6Htdfmo4QSUKj 6nMAhH4Gr4HmA== Date: Thu, 26 May 2022 12:57:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Jan Beulich , Stefano Stabellini , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1293857561-1653593990=:1905099" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1293857561-1653593990=:1905099 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 26 May 2022, Bertrand Marquis wrote: > > On 26 May 2022, at 11:15, Jan Beulich wrote: > > On 26.05.2022 11:54, Bertrand Marquis wrote: > >>> On 26 May 2022, at 10:43, Jan Beulich wrote: > >>> On 26.05.2022 03:02, Stefano Stabellini wrote: > >>>> On Wed, 25 May 2022, Julien Grall wrote: > >>>>> On 25/05/2022 01:35, Stefano Stabellini wrote: > >>>>>> +- Rule: Dir 4.7 > >>>>>> + - Severity: Required > >>>>>> + - Summary: If a function returns error information then that error > >>>>>> information shall be tested > >>>>>> + - Link: > >>>>>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > >>>>> > >>>>> > >>>>> ... this one. We are using (void) + a comment when the return is ignored on > >>>>> purpose. This is technically not-compliant with MISRA but the best we can do > >>>>> in some situation. > >>>>> > >>>>> With your proposed wording, we would technically have to remove them (or not > >>>>> introduce new one). So I think we need to document that we are allowing > >>>>> deviations so long they are commented. > >>>> > >>>> Absolutely yes. All of these rules can have deviations as long as they > >>>> make sense and they are commented. Note that we still have to work out > >>>> a good tagging system so that ECLAIR and cppcheck can recognize the > >>>> deviations automatically but for now saying that they need to be > >>>> commented is sufficient I think. > >>>> > >>>> So I'll add the following on top of the file: > >>>> > >>>> """ > >>>> It is possible that in specific circumstances it is best not to follow a > >>>> rule because it is not possible or because the alternative leads to > >>>> better code quality. Those cases are called "deviations". They are > >>>> permissible as long as they are documented with an in-code comment. > >>>> """ > >>> > >>> Hmm, so you really mean in-code comments. I don't think this will scale > >>> well (see e.g. the DCE related intended deviation), and it also goes > >>> against the "no special casing for every static analysis tool" concern > >>> I did voice on the call. > >> > >> On this subject the idea was more to define a “xen” way to document > >> deviations in the code and do it in a way so that we could easily substitute > >> the “flag” to adapt it for each analyser using tools or command line options. > > > > I think the basic scheme of something like this would want laying out > > before doc changes like the one here actually go in, so that it's clear > > what the action is if a new deviation needs adding for whatever reason > > (and also allowing interested people to start contributing patches to > > add respective annotations). > > We will work on that but if we wait for everything to be solved we will > never progress. > I have a task on my side (ie at arm) to work on that and Luca Fancellu > will start working on it next month. > Now I do not think that this should block this patch, agreeing on rules does > not mean will respect all of them in the short term so we can wait a bit as I > definitely think that how to document violations in the code and in general > will be a work package on its own and will require some discussion. Right. In general, we'll need to document these deviations and ideally they would be documented as in-code comments because they are easier to keep in sync with the code. But we won't be able to do that in all cases. We'll also need a special TAG to mark the deviation. Nobody wants multiple tagging systems for different tools (ECLAIR, cppcheck, Coverity, etc.) We'll come up with one tagging system and introduce conversion scripts as needed. Roberto offered to help on the call to come up with a generic tagging system. In some cases in-code comments for every deviation would be too verbose. We'll want to handle it in another way. It could be a document somewhere else, or simply disabling the Rules check in ECLAIR/cppcheck (but that partially defeats the purpose.) We'll have to see. I think it is going to be on a case by case basis. In short, I don't think we have all the info and expertise to come up with a good deviation system right now. We need to make more progress and analize a few specific examples before we can do that. But to gain that expertise we need to agree on a set of rules we want to follow first, which is this patch series. So, I think this is the best way we can start the process. We can clarify further with the comment on top of this file, and we could even remove the specific part about the "in-code comment" with an open-ended statement until we come up with a clear deviation strategy. For instance: """ It is possible that in specific circumstances it is best not to follow a rule because it is not possible or because the alternative leads to better code quality. Those cases are called "deviations". They are permissible as long as they are documented. The existing codebase is not 100% compliant with the rules. Some of the violations are meant to be documented as deviations, while some others should be fixed. Both compliance and documenting deviations on the existing codebase is work-in-progress. """ --8323329-1293857561-1653593990=:1905099-- From xen-devel-bounces@lists.xenproject.org Thu May 26 19:58:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 19:58:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337732.562415 (Exim 4.92) (envelope-from ) id 1nuJcT-0002yL-TM; Thu, 26 May 2022 19:58:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337732.562415; Thu, 26 May 2022 19:58:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJcT-0002yB-OK; Thu, 26 May 2022 19:58:05 +0000 Received: by outflank-mailman (input) for mailman id 337732; Thu, 26 May 2022 19:58:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJcS-0002Vw-Rz for xen-devel@lists.xenproject.org; Thu, 26 May 2022 19:58:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 266d9046-dd2e-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 21:58:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 245EC6190F; Thu, 26 May 2022 19:58:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39735C385A9; Thu, 26 May 2022 19:58:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 266d9046-dd2e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653595081; bh=8mWw/udNPF+/YboPCcEbCt+13wWFw7sK6GoYz4NxL14=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=RyF/CYQSPcMbwnxgaRLIVj/W0vKN4O1WLUzvC2Ls98YooEKSSsQeTFKA6hIFSQsAC NERvHoiiy4osTE0uKbPOgCd/BX3J9wslRkp+z1CnCiJTgSFkRUh9cXIRMDgJFi2nCO QZSX9OJKLp89qo7a1eiAGpYu+kd2mvnXbJduP/rsWseUYzrSXp62XTmGvl4gcGdfKN DF3p8DkuhP6wjwIr5QYeNv6ILTZci6dvxfy0ON9wMnabtPnQRFXYosEitQTpqqpgNe UNaHq1t3V9Zw5I+aF27zyinP50l1iFzJSzlKCse/3oMuG38yJD+PXbAbtEHkBh6Pkw asqf5+KqdxWlg== Date: Thu, 26 May 2022 12:57:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: <0d71af01-dbfa-d5ab-c55c-faa3693674bc@suse.com> Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <62f142e3-02c7-22e0-3917-3a29fa2630b1@suse.com> <0d71af01-dbfa-d5ab-c55c-faa3693674bc@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 26 May 2022, Jan Beulich wrote: > On 26.05.2022 03:12, Stefano Stabellini wrote: > > On Wed, 25 May 2022, Jan Beulich wrote: > >> On 25.05.2022 02:35, Stefano Stabellini wrote: > >>> --- /dev/null > >>> +++ b/docs/misra/rules.rst > >>> @@ -0,0 +1,65 @@ > >>> +===================== > >>> +MISRA C rules for Xen > >>> +===================== > >>> + > >>> +**IMPORTANT** All MISRA C rules, text, and examples are copyrighted by the > >>> +MISRA Consortium Limited and used with permission. > >>> + > >>> +Please refer to https://www.misra.org.uk/ to obtain a copy of MISRA C, or for > >>> +licensing options for other use of the rules. > >>> + > >>> +The following is the list of MISRA C rules that apply to the Xen Project > >>> +hypervisor. > >>> + > >>> +- Rule: Dir 2.1 > >>> + - Severity: Required > >>> + - Summary: All source files shall compile without any compilation errors > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_02_01.c > >>> +- Rule: Dir 4.7 > >>> + - Severity: Required > >>> + - Summary: If a function returns error information then that error information shall be tested > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > >>> +- Rule: Dir 4.10 > >>> + - Severity: Required > >>> + - Summary: Precautions shall be taken in order to prevent the contents of a header file being included more than once > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_10.c > >> > >> Like Julien has already pointed out for 4.7, this and perhaps other ones > >> also want clarifying somewhere that we expect certain exceptions. Without > >> saying so explicitly, someone could come forward with a patch eliminating > >> some uses (and perhaps crippling the code) just to satisfy such a rule. > >> This would then be a waste of both their and our time. > > > > Yes, and also Julien pointed out something similar. I'll add a statement > > at the top of the file to say that there can be deviations as long as > > they are commented. > > We need to determine where such comments are to go. I hope you don't > mean code comments on each and every instance of similar-kind > deviations. I'll reply to this in the other thread. > > I wouldn't go as far as adding a note to each specific rule where we > > expect deviations because I actually imagine that many of them will end > > up having at least one deviation or two. It would be easier to mark the > > ones where we expect to have 100% compliance and intend to keep it that > > way (once we reach 100% compliance). > > > > We are still in the early days of this process. For now, what about > > adding the following statement at the top of the file (in addition to > > the one saying that deviations are permissible): > > > > """ > > The existing codebase is not 100% compliant with the rules. Some of the > > violations are meant to be documented as deviations, while some others > > should be fixed. Both compliance and documenting deviations on the > > existing codebase is work-in-progress. > > """ > > > > > >>> +- Rule: Dir 4.14 > >>> + - Severity: Required > >>> + - Summary: The validity of values received from external sources shall be checked > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_14.c > >>> +- Rule: Rule 1.3 > >>> + - Severity: Required > >>> + - Summary: There shall be no occurrence of undefined or critical unspecified behaviour > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_01_03.c > >>> +- Rule: Rule 3.2 > >>> + - Severity: Required > >>> + - Summary: Line-splicing shall not be used in // comments > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c > >> > >> To aid easily looking up presence of a rule here, I think the table wants > >> sorting numerically. > > > > They are sorted numerically, first the "Dir" (directives) then the > > "Rules". > > Oh, I see. I didn't recognize the distinction. Maybe have a visual > separator between the two classes? I'll try but the layout changed significantly to become "proper RST" following Andrew's comments. I'll see if I can come up with something. If not, I could create two tables. First Dir, then Rules. > >>> +- Rule: Rule 6.2 > >>> + - Severity: Required > >>> + - Summary: Single-bit named bit fields shall not be of a signed type > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_02.c > >>> +- Rule: Rule 8.1 > >>> + - Severity: Required > >>> + - Summary: Types shall be explicitly specified > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_01.c > >>> +- Rule: Rule 8.4 > >>> + - Severity: Required > >>> + - Summary: A compatible declaration shall be visible when an object or function with external linkage is defined > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_04.c > >>> +- Rule: Rule 8.5 > >>> + - Severity: Required > >>> + - Summary: An external object or function shall be declared once in one and only one file > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_05_2.c > >>> +- Rule: Rule 8.6 > >>> + - Severity: Required > >>> + - Summary: An identifier with external linkage shall have exactly one external definition > >>> + - Link: https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_08_06_2.c > >> > >> I don't think this was uncontroversial, as we've got a lot of uses of > >> declarations when we expect DCE to actually take out all uses. There > >> are also almost a thousand violations, which - imo - by itself speaks > >> against adoption. > > > > Ah yes, good catch. We spoke about DCE in the context of Rule 2.1, not > > this one. My preference would be to keep Rule 8.6 with a note allowing > > DCE: > > > > - Note: declarations without definitions are allowed (specifically when > > the definition is compiled-out or optimized-out by the compiler) > > I'd be fine with that. Cool, I'll add it in. From xen-devel-bounces@lists.xenproject.org Thu May 26 19:58:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 26 May 2022 19:58:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337740.562426 (Exim 4.92) (envelope-from ) id 1nuJco-0003Zd-7C; Thu, 26 May 2022 19:58:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337740.562426; Thu, 26 May 2022 19:58:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJco-0003ZW-3U; Thu, 26 May 2022 19:58:26 +0000 Received: by outflank-mailman (input) for mailman id 337740; Thu, 26 May 2022 19:58:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuJcn-0002Vw-2L for xen-devel@lists.xenproject.org; Thu, 26 May 2022 19:58:25 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 335921c1-dd2e-11ec-bd2c-47488cf2e6aa; Thu, 26 May 2022 21:58:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92B25B821FC; Thu, 26 May 2022 19:58:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACDDDC385A9; Thu, 26 May 2022 19:58:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 335921c1-dd2e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653595102; bh=Ez1QX1kYxUxJ3eXuS5EaRUH8QqC/sTVOQQGMhzr/wvM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=So2PcIQli4r+ZeqPk3IAvK+Fl96OvbIs1PhW75g7I+wcEhSKwg496XN88CaeH0fVE wVyQid4sJTSfTTBjyB8cW8Xb4RvrgpqIYi9IP4/cJoU6HX7UdlkOOu6PXWjibGbpKl 62D5w6TcN5unQW5CcxugH8aLihXK8snqFYN/Le0M8NcZSiHV3zX61d2NIWRnIT8ak9 UlqWPE8NCUV14egPjf2lZ5JF4Nhrqy5oh4n7GWNwQJhOvciCUp5wyUs1tywe4AMg2A T7y8ar9UE4Ud4qERL1KqoLdP/m0CjVFmlqRe1nHPM8huF9r4OpDDiC+XBJ6OP7WAcI P1dSstzohVqfQ== Date: Thu, 26 May 2022 12:58:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, Bertrand.Marquis@arm.com, George.Dunlap@citrix.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] docs/misra: add Rule 5.1 In-Reply-To: <39c930ba-f5b4-14a4-ec48-19dba9a21509@suse.com> Message-ID: References: <20220525003505.304617-2-sstabellini@kernel.org> <6604372a-67a1-6ad2-bbcf-d6b4337a4bf0@suse.com> <39c930ba-f5b4-14a4-ec48-19dba9a21509@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 26 May 2022, Jan Beulich wrote: > On 26.05.2022 03:18, Stefano Stabellini wrote: > > On Wed, 25 May 2022, Jan Beulich wrote: > >> On 25.05.2022 02:35, Stefano Stabellini wrote: > >>> From: Stefano Stabellini > >>> > >>> Add Rule 5.1, with the additional note that the character limit for Xen > >>> is 63 characters. > >>> > >>> The max length identifiers found by ECLAIR are: > >>> > >>> __mitigate_spectre_bhb_clear_insn_start > >>> domain_pause_by_systemcontroller_nosync > >>> > >>> Both of them are 40 characters long. A limit of 63 characters work for > >>> the existing code. > >> > >> I have to admit that it hasn't become clear to me why we want to > >> permit (if not to say encourage) the use of such long identifiers. > >> If 40 is the longest we've got, why not limit it to 40 for now > >> with a goal of further reducing? A 40-char symbol plus some > >> indentation will already pose problems with 80-char line length. > > > > We can go lower than 63 if we want to. I chose the closest power-of-two > > length -1 for the NUL terminator. But it doesn't have to be a > > power-of-two. So we could go with "41" if we want to. > > > > Anyone in favor of that? I am happy with any number between 41 and 63. > > Why 41, not 40? 41 seems yet more arbitrary to me than e.g. 40. I was adding +1 to account for the NUL terminator, but actually I already added it before (__mitigate_spectre_bhb_clear_insn_start and domain_pause_by_systemcontroller_nosync are 39 characters). So yes we can go with 40. > >> Otoh, as said on the call, I think the public headers want > >> mentioning explicitly here in some way. Part of them (most or all > >> of what's under io/) aren't used when building Xen, so won't be > >> seen by Eclair (aiui). Yet they are a formal part of the code > >> base, and e.g. ring.h has some pretty long names (albeit still > >> below 40 chars as it looks). So once we're able to go down to e.g. > >> 32 for the bulk of the code base, public headers should imo still > >> be explicitly allowed to use longer identifiers. > > > > Actually I thought about writing something for the public header but I > > wasn't sure what to write. What about: > > > > - Note: the Xen characters limit for identifiers is 41. Public headers > > (xen/include/public/) are allowed to retain longer identifiers for > > backward compatibility. > > Fine with me, except I wonder in how far going forward we actually > need to play by that limit there. Proper name-spacing is particularly > important in the public headers, so may warrant a higher limit for > certain (unusual?) circumstances. Keep in mind that the rules are general guidelines and good defaults. There can be always special cases, and that is especially true for "unusual circumstances". From xen-devel-bounces@lists.xenproject.org Fri May 27 00:26:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 00:26:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337752.562436 (Exim 4.92) (envelope-from ) id 1nuNoA-0004HW-KO; Fri, 27 May 2022 00:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337752.562436; Fri, 27 May 2022 00:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuNoA-0004HP-HT; Fri, 27 May 2022 00:26:26 +0000 Received: by outflank-mailman (input) for mailman id 337752; Fri, 27 May 2022 00:26:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuNo8-0004HJ-7z for xen-devel@lists.xenproject.org; Fri, 27 May 2022 00:26:24 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a193cf52-dd53-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 02:26:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7D83617CC; Fri, 27 May 2022 00:26:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73FB5C385A9; Fri, 27 May 2022 00:26:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a193cf52-dd53-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653611178; bh=k3BnoH3YPVaB5WBNL0FO8rMooIsjEgBVxJrhnW3sFFc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FB9iFeInqypsuXHxbKpVR6bFO2GR59Bpu9ZenH+Jfr6JjAKPMF16vkCLfMkPIzzZZ z1n5XB2DuTaABC1yVcOiXI1pyEi1AJbTz6MHBc8/fpRnVbJzCubAqTX3zbHMOi/L0D Bc4Oaxbye9xtT6xzjwOGc05gFBrOpv7M6Jp0VwA+Qhps2Q/qHQ+2+Rezr7H6S96JI0 RbhBM5PvzqPGipS5aScTiF2TraBurGou/OhjToXG4UZUNrZiwi0XWPZpXyW/XbvAno IzB48Bg0hfRBkNgLPQMxsj/OkQLg8Hl/7jUbL45zN+lt+kG42mYneE/0h6c8aWnhCU x5KAzLnmME4Lw== Date: Thu, 26 May 2022 17:26:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated In-Reply-To: <20220517090529.3140417-6-Penny.Zheng@arm.com> Message-ID: References: <20220517090529.3140417-1-Penny.Zheng@arm.com> <20220517090529.3140417-6-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 17 May 2022, Penny Zheng wrote: > Borrower domain will fail to get a page ref using the owner domain > during allocation, when the owner is created after borrower. > > So here, we decide to get and add the right amount of reference, which > is the number of borrowers, when the owner is allocated. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v4 changes: > - no change > --- > v3 change: > - printk rather than dprintk since it is a serious error > --- > v2 change: > - new commit > --- > xen/arch/arm/domain_build.c | 62 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 59591e3c6e..3a20247836 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -794,6 +794,34 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > > } > > +static int __init acquire_nr_borrower_domain(struct domain *d, > + paddr_t pbase, paddr_t psize, > + unsigned long *nr_borrowers) > +{ > + unsigned long bank; > + > + /* Iterate reserved memory to find requested shm bank. */ > + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > + { > + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; > + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; > + > + if ( pbase == bank_start && psize == bank_size ) > + break; > + } > + > + if ( bank == bootinfo.reserved_mem.nr_banks ) > + return -ENOENT; > + > + if ( d == dom_io ) > + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain; > + else > + /* Exclude the owner domain itself. */ > + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_domain - 1; > + > + return 0; > +} > + > /* > * Func allocate_shared_memory is supposed to be only called > * from the owner. > @@ -805,6 +833,8 @@ static int __init allocate_shared_memory(struct domain *d, > { > mfn_t smfn; > int ret = 0; > + unsigned long nr_pages, nr_borrowers, i; > + struct page_info *page; > > dprintk(XENLOG_INFO, > "Allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > @@ -819,6 +849,7 @@ static int __init allocate_shared_memory(struct domain *d, > * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. > * It sees RAM 1:1 and we do not need to create P2M mapping for it > */ > + nr_pages = PFN_DOWN(psize); > if ( d != dom_io ) > { > ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, PFN_DOWN(psize)); > @@ -830,6 +861,37 @@ static int __init allocate_shared_memory(struct domain *d, > } > } > > + /* > + * Get the right amount of references per page, which is the number of > + * borrow domains. > + */ > + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); > + if ( ret ) > + return ret; > + > + /* > + * Instead of let borrower domain get a page ref, we add as many > + * additional reference as the number of borrowers when the owner > + * is allocated, since there is a chance that owner is created > + * after borrower. > + */ > + page = mfn_to_page(smfn); > + for ( i = 0; i < nr_pages; i++ ) > + { > + if ( !get_page_nr(page + i, d, nr_borrowers) ) > + { > + printk(XENLOG_ERR > + "Failed to add %lu references to page %"PRI_mfn".\n", > + nr_borrowers, mfn_x(smfn) + i); > + goto fail; > + } > + } > + > + return 0; > + > + fail: > + while ( --i >= 0 ) > + put_page_nr(page + i, nr_borrowers); > return ret; > } > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri May 27 00:48:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 00:48:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337760.562448 (Exim 4.92) (envelope-from ) id 1nuO8y-0006i9-D0; Fri, 27 May 2022 00:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337760.562448; Fri, 27 May 2022 00:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuO8y-0006i2-9x; Fri, 27 May 2022 00:47:56 +0000 Received: by outflank-mailman (input) for mailman id 337760; Fri, 27 May 2022 00:47:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuO8x-0006ht-0w for xen-devel@lists.xenproject.org; Fri, 27 May 2022 00:47:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3a8b7fd-dd56-11ec-837f-e5687231ffcc; Fri, 27 May 2022 02:47:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1421661C77; Fri, 27 May 2022 00:47:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ABF0C385B8; Fri, 27 May 2022 00:47:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3a8b7fd-dd56-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653612471; bh=37t8qg7G7P6R9CN2WQp/8N9NaGse1K4pIwg2eUJdGX8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XpHhihGvPsjrHKSbShVW9FHC4LSVqf/Gu7wZdKrw9NvcCdj8po2iWneZdOX4pIZl8 hBfmwro59SMfhL73nc8VdgLtJ02NW6lAedal07kHCYGSmcXD708oHTre/xRDwwDAWU nfwMmbTpeXdaOPPZEKfZvk7bZ7C6I1Ps73mO9k+1EhXyJQBDKUNuURxd+thP0vbAqZ oOwnV4yP6WjCdYoWjAzH481Mn1VFWbKw7qvy6JB9q36PhB97s0KoiwU//fEEpREvJt HpSz5W8LuwpqOZRIku+W+tedBFkVjoPGKMxqGrQt42/L7kvq5KCqJ4BzBhRDqsblaE tyi0rishHAzXw== Date: Thu, 26 May 2022 17:47:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v4 4/8] xen/arm: introduce put_page_nr and get_page_nr In-Reply-To: <20220517090529.3140417-5-Penny.Zheng@arm.com> Message-ID: References: <20220517090529.3140417-1-Penny.Zheng@arm.com> <20220517090529.3140417-5-Penny.Zheng@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 17 May 2022, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-consuming. > > To save the loop time, this commit introduces a set of new helpers > put_page_nr() and get_page_nr() to increment/drop the page reference by nr. > > Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini > --- > v4 changes: > - make sure that the right equation return is at least equal to n > - simplify the underflow > --- > v3 changes: > - check overflow with "n" > - remove spurious change > - bring back the check that we enter the loop only when count_info is > greater than 0 > --- > v2 change: > - new commit > --- > xen/arch/arm/include/asm/mm.h | 4 ++++ > xen/arch/arm/mm.c | 42 +++++++++++++++++++++++++++-------- > 2 files changed, 37 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 424aaf2823..c737d51e4d 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -347,6 +347,10 @@ void free_init_memory(void); > int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, > unsigned int order); > > +extern bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr); > +extern void put_page_nr(struct page_info *page, unsigned long nr); > + > extern void put_page_type(struct page_info *page); > static inline void put_page_and_type(struct page_info *page) > { > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7b1f2f4906..8c8a8f6378 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1537,21 +1537,29 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) > return 0; > } > > -struct domain *page_get_owner_and_reference(struct page_info *page) > +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, > + unsigned long nr) > { > unsigned long x, y = page->count_info; > struct domain *owner; > > + /* Restrict nr to avoid "double" overflow */ > + if ( nr >= PGC_count_mask ) > + { > + ASSERT_UNREACHABLE(); > + return NULL; > + } > + > do { > x = y; > /* > * Count == 0: Page is not allocated, so we cannot take a reference. > * Count == -1: Reference count would wrap, which is invalid. > */ > - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) > + if ( unlikely(((x + nr) & PGC_count_mask) <= nr) ) > return NULL; > } > - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); > + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); > > owner = page_get_owner(page); > ASSERT(owner); > @@ -1559,14 +1567,19 @@ struct domain *page_get_owner_and_reference(struct page_info *page) > return owner; > } > > -void put_page(struct page_info *page) > +struct domain *page_get_owner_and_reference(struct page_info *page) > +{ > + return page_get_owner_and_nr_reference(page, 1); > +} > + > +void put_page_nr(struct page_info *page, unsigned long nr) > { > unsigned long nx, x, y = page->count_info; > > do { > - ASSERT((y & PGC_count_mask) != 0); > + ASSERT((y & PGC_count_mask) >= nr); > x = y; > - nx = x - 1; > + nx = x - nr; > } > while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); > > @@ -1576,19 +1589,30 @@ void put_page(struct page_info *page) > } > } > > -bool get_page(struct page_info *page, const struct domain *domain) > +void put_page(struct page_info *page) > +{ > + put_page_nr(page, 1); > +} > + > +bool get_page_nr(struct page_info *page, const struct domain *domain, > + unsigned long nr) > { > - const struct domain *owner = page_get_owner_and_reference(page); > + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); > > if ( likely(owner == domain) ) > return true; > > if ( owner != NULL ) > - put_page(page); > + put_page_nr(page, nr); > > return false; > } > > +bool get_page(struct page_info *page, const struct domain *domain) > +{ > + return get_page_nr(page, domain, 1); > +} > + > /* Common code requires get_page_type and put_page_type. > * We don't care about typecounts so we just do the minimum to make it > * happy. */ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Fri May 27 01:07:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 01:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337769.562459 (Exim 4.92) (envelope-from ) id 1nuORw-0007RI-5N; Fri, 27 May 2022 01:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337769.562459; Fri, 27 May 2022 01:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuORw-0007RB-25; Fri, 27 May 2022 01:07:32 +0000 Received: by outflank-mailman (input) for mailman id 337769; Fri, 27 May 2022 01:07:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuORu-0007R1-C5; Fri, 27 May 2022 01:07:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuORu-0004cA-7C; Fri, 27 May 2022 01:07:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuORt-0004Ak-MB; Fri, 27 May 2022 01:07:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuORt-00081b-LY; Fri, 27 May 2022 01:07:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K5+rcT0AKNV5jy6d1QOWJqCd4M0SVSrGEXph9KIHmDQ=; b=puNzXuacEguKokBvFPkuTp6lKp qERCgTa2zdWRMNyTgoTC3vPR62kH0SNMZRzXwtEjBpPWdWmxH2WS3ZtXWH2ZFLCu77KKlpjsKjoUc X42XY+/SQ/JaYzdJwEGz4HMhnhof/GPf4UulCOmL7gqDaRX/qgWoE82c3N+j8h7pYqmQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170747: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Fri, 27 May 2022 01:07:29 +0000 flight 170747 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170747/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 170740 pass in 170747 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail pass in 170740 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170740 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170740 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170740 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170740 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170740 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170740 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170740 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170740 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170740 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170740 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170740 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170740 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170740 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170747 2022-05-26 12:13:49 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 27 02:51:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 02:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337781.562470 (Exim 4.92) (envelope-from ) id 1nuQ4V-0001co-QM; Fri, 27 May 2022 02:51:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337781.562470; Fri, 27 May 2022 02:51:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuQ4V-0001ch-NE; Fri, 27 May 2022 02:51:27 +0000 Received: by outflank-mailman (input) for mailman id 337781; Fri, 27 May 2022 02:51:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuQ4T-0001cX-Vj; Fri, 27 May 2022 02:51:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuQ4T-0006r1-NK; Fri, 27 May 2022 02:51:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuQ4T-0007Nx-6w; Fri, 27 May 2022 02:51:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuQ4T-00030C-6X; Fri, 27 May 2022 02:51:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HuApcGktUeyu9HNB9TPCqkD9sOPlw4TalEN2hLwdXjM=; b=xW3ou/CmlDi6tnkJrxErKyy8kk 3PiEbAtg+lrh5UzHaKFya/3PdqevYoJ9pRJetEN9CiALEw1p3Jqu380L+FCOfMR0z4F2V9RqHLsjX hW1LsFikwRApvI8nhYS+JSpKcHKkZKn5Rmnw8FydwL/biWBw/81LtSAjIZ8odLtzUXPI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170749: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=2417cbd5916d043e0c56408221fbe9935d0bc8da X-Osstest-Versions-That: qemuu=58b53669e87fed0d70903e05cd42079fbbdbc195 From: osstest service owner Date: Fri, 27 May 2022 02:51:25 +0000 flight 170749 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170749/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 170741 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170741 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170741 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170741 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170741 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170741 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170741 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170741 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170741 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 2417cbd5916d043e0c56408221fbe9935d0bc8da baseline version: qemuu 58b53669e87fed0d70903e05cd42079fbbdbc195 Last test of basis 170741 2022-05-26 02:04:13 Z 1 days Testing same since 170749 2022-05-26 16:39:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Lei He Richard Henderson zhenwei pi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 58b53669e8..2417cbd591 2417cbd5916d043e0c56408221fbe9935d0bc8da -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri May 27 06:41:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 06:41:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337792.562481 (Exim 4.92) (envelope-from ) id 1nuTee-00070W-MM; Fri, 27 May 2022 06:41:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337792.562481; Fri, 27 May 2022 06:41:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTee-00070P-JZ; Fri, 27 May 2022 06:41:00 +0000 Received: by outflank-mailman (input) for mailman id 337792; Fri, 27 May 2022 06:40:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTed-00070F-0P; Fri, 27 May 2022 06:40:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTec-000305-Ns; Fri, 27 May 2022 06:40:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTec-0002ae-7t; Fri, 27 May 2022 06:40:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuTec-0001a2-7Q; Fri, 27 May 2022 06:40:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wciqhU9Ze63DduxXVM1+BoIJAg6o657lYzlRGXvITcI=; b=FYADUT4kMRg2fa6S3Uu/At32Hb fVE/UlvW2KnqU4gz/i80UKDkFxpPH6FK364gcnCt77CydGv2QdDi0hFKtRWmfiIo8KapC5+ymxW1o 7yrNqyPnIqZzxeSws++HyquOv8HJVr5Ttrm+cKwIPOJMsl1RP5v/ZkeBbYbaoNKeMvjk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170750: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:host-ping-check-xen:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=16477cdfefdb494235a675cc80563d736991d833 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Fri, 27 May 2022 06:40:58 +0000 flight 170750 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170750/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 10 host-ping-check-xen fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 16477cdfefdb494235a675cc80563d736991d833 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 3 days Failing since 170716 2022-05-24 11:12:06 Z 2 days 7 attempts Testing same since 170750 2022-05-26 19:13:16 Z 0 days 1 attempts ------------------------------------------------------------ 1586 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 164439 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 27 06:57:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 06:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337802.562492 (Exim 4.92) (envelope-from ) id 1nuTuA-00007V-5w; Fri, 27 May 2022 06:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337802.562492; Fri, 27 May 2022 06:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTuA-00007O-1k; Fri, 27 May 2022 06:57:02 +0000 Received: by outflank-mailman (input) for mailman id 337802; Fri, 27 May 2022 06:57:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuTu7-00007I-Ut for xen-devel@lists.xenproject.org; Fri, 27 May 2022 06:57:00 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 339b0762-dd8a-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 08:56:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-43-Qj9Y8v9IOka3HoK6pX9kJg-1; Fri, 27 May 2022 08:56:56 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4314.eurprd04.prod.outlook.com (2603:10a6:5:23::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 06:56:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 06:56:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 339b0762-dd8a-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653634618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zAp+DimYRCk64mdvDT7DD2A8Gi/9KBisBv0i4JsKJQ=; b=iu0g47pA6XYOiX3lNPHkHybzd0Jq/v5pnprpsf+zfhiXKy28CRwrGsYbSPvjAbXo8nSHbx hrHwG+YS0EyhDwhkaWjCzvNHCe9+TudaPpkknudWzUO58AQ1X24vgdKGFLiBO8MQsFgCkc oNreQWH3cATmJoJPl0MwF08EAoqD6aI= X-MC-Unique: Qj9Y8v9IOka3HoK6pX9kJg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kznVJxRkxE7uOgho4264b0IfXu7qb7Pl4MsNpo1u9f887UJmskbL9wFb5zOTT8Z21JDNrNXvyLFNl2o0e83MPCGrkk5ZIaoHoBSimqwTJQuVWLHLE4Vy5GkkwoCKjudblfILQIJv+p5j6Qt74lALCfqqgARoCo7lEVf02HALiCP8P15jQwVEq5RjTQkQt60bG8c5aA28ig9xPouVhc3P4hjsvH2GB6VSAECFGTpIbeC0oJGy9QC36+4QwFQnei2mHwq22zvQMjgkX0F//ft8mwCbww3KDByClnxKKalLPZFpMyMc4OqGMv6kqramWAzexvrA5aHth2RKZcOc/0PMrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LHiqODxADRijnQT3dCOpOYDLozy5qTE8HhY8u7iQdT4=; b=bqukQkiz03kGS8XXU+FOtkzVGcURehSKmLAEe7oDR7di+W2vwBJRkZn/UpGxD0fw7z9rj7F//LDrmBWQOqgLNI5OMKPsHOL9RYkslmj6j3axg4aj4ifIEZ2LlwVcd8a0ikuAcO3DmXRW8NoXECVEbHftm7zIolykmczuwoz9pG8HIrTBBDj67eYoYt8qzGG1RgugdOz/wDEKqD5E56RZ+dh18rIPrxIx3QPu+fGEYpBD2Nfa47j9tvT55K5B7fr/TzFcH+N78lUfFvlRVN2ahF+EbnTdU+MKft20ejt4ictJWCi6DvVl78mS+YrvuzZbQdm4lJeOEJxmDVm/UTEVFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 08:56:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Stefano Stabellini , Bertrand Marquis CC: "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8P189CA0012.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 368d7a09-4f9e-438d-af6f-08da3fae1583 X-MS-TrafficTypeDiagnostic: DB7PR04MB4314:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1dANA44ZIUOgS9L22GS9x5bk1wu/HMJuFfOUrwKL+DzQRABPYKu7saOFOhndXm0jhDcxwQgmGTQuz9oemn2U6Hbz/4JuT9vDWowJgv5tRBnraafZv5iRto1tt2axrs2g54lcj6ZfJB07gvbwzmIbolgfjdfhwDDm/iDG++oq4eeJtqJBrDIROlAWNNaNHCMYevm0xFHiACMxTBfdNPF39PcejXgwdwU7qBE9lyPCCTZl2hiyPkNLKKT/PuggZNCSMLb24an+/dq+sX30nZ5eMRxrDwnNupnJNOj+HrRqoiKhsolN2Yd2K6tFcMnLTUGW6YTDYf7dOEjCUSZR5HPCuubD5ZPKY8Uj/bc13Vh3+TRj3MZItoPDYR1JFzpaNk4Si5ikthl3XXEclON7haCQKj5DjIZIFxIt5DZvhKvb2ySm9jx3FNG1ylLqUMXMVcsYHBAm1lLor/aFH83kDygJJOjPJx0xQ1r7w6YISGBLtDg0YXMsHBWrmEk4wXV/lU9Si6plZF62E3ZVnfLZ7qXx6P3dowiIn1dvUt0fUtsc/0Lv1aL2XD251J/AZiYU9yoxQicCRy97qwbSiax96ofCh4r1f3b8VwQra1pTtFYObvMIADz3rSfqBQmgtJGEncbBl+VT5wEGM0bLCecPYrki301hjtW1gm1mz0wGV3WocyCOX1zLjiTuxkt4h1t7ILk6LbB7MtcjNmO2R+c4XJMEuMQVyD4aHmY3jxI2JpiANmG8JEFIpzniXt0qes8Jbbe7ZsrZHjkts0n+VsJB9uQ6Z8WlUBQtDJMcNU4fMSQR0fjcyCJhnsBtPFIhkcFvEq4R X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(110136005)(316002)(53546011)(6512007)(54906003)(2616005)(26005)(5660300002)(2906002)(6486002)(8936002)(86362001)(31696002)(508600001)(4326008)(8676002)(38100700002)(83380400001)(66556008)(66476007)(66946007)(31686004)(36756003)(186003)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?trrE1Cn+8hQiIcqmaTsO5gLyJoi2V5+KYE56PNO80KMiHOZWQ06Apa/x4rbt?= =?us-ascii?Q?9M25cX4gfsSrQFiTFZtKir1svoPUDVyenWlYRCCIa9W4e6HPUDDvxG+KGHvT?= =?us-ascii?Q?i/yE/GBWXHi0vFRQ7ZSiSQtyBFUg46NAiSvZFoIKKr2ZP1vgMlYT5DiFzbaZ?= =?us-ascii?Q?MEkVcskM4tgvv5CJkw78Xbwi01ABUhjWCxpv5aJS8dvhAa9u99n7JD03zsJ4?= =?us-ascii?Q?6qE6E+jQls19p8U0OSOuAUeQTQ/TfqCZl7rmmCC5IHkZPqxLiLP11wF3HnYq?= =?us-ascii?Q?O3ksghfP179aoMpzLJp6hU2MzTddaWuLhbOMERuR6Y0V7SWH5ZtilIRC25Va?= =?us-ascii?Q?K3sEU437xZ54ryVDRbRQ06Baq6FGlZAsGouGopJEen10FsJ2zB2RSkFwylyL?= =?us-ascii?Q?73TTPs3vKwX0bnTbAtHh2xgsKfku/UYp+IQqEU22gtb0WmJXw+vQs4YLv4fb?= =?us-ascii?Q?hF594whddEQydDAG6DoA5XFIU+wgr33XCF/Ip9q7FvxjGa0mvDrHmzYZYsXv?= =?us-ascii?Q?bC9T64iy/zX6toMK4ZstZCuEJIQtwErSWYYR1Zk6fG5SgZTl14r3wr+8EhMx?= =?us-ascii?Q?vPGObb8WC5bAfQdatq7zsJeMbRBgUgHK0gNB928CgxLMcqnra6/HcSU7JQLf?= =?us-ascii?Q?n1W8QqGk/OgEUeHnMfR6T5gPHYMfD9XTjYkYY/QsS1VcldLT+7yX4lMB49b9?= =?us-ascii?Q?LV5hZ7HALKJcl+c4eIM0ZoNKBoRPniFfUp8+yz0sOhRy2q5cossx6zKmWkl1?= =?us-ascii?Q?42zcbG8IknIoB6iFcpRn0cHd10udsn7b6UaiENumdbqb3He1rXEscDZBsBn4?= =?us-ascii?Q?PBJMUbX2HRI4Jl2fo/5RweQLtJHeC+dIGLP3zllVWKZLqr3k2KWrVR9JNNf7?= =?us-ascii?Q?AsJNGOXu+lPfrnHhPNCv2eZvN9WNkSgfriPA3rUDEDuk7YMEFf1/424404wr?= =?us-ascii?Q?/28baa9ety8sZJaDWn+P8Y1PWWz1epbcWXjNPCZGdHZDpvzrOKyCZNXcS4cY?= =?us-ascii?Q?aRQK32Us7q9GGRTAUnpWYpqHl5SCXE18UPst1QhhO1/xbFmqXbLoHhhCC1RY?= =?us-ascii?Q?/e/l110bUx9lKCKiR1zSbvga++VHGx5oE3YKgLryoj6UpPAohRwKopEEK+XG?= =?us-ascii?Q?RiGzIq5D3+bpP+yqb84ch6AkCo2lnoJDC5eH+plnVtwrKqs6m3FgNOnjf54C?= =?us-ascii?Q?HfFEShnKJy4Rn4dB20/fZeNkouiWHG68y6D94QrPbZ9nYp4sA0i+5Zl4VRae?= =?us-ascii?Q?qV4Je7/3n/IVL/Fd02EFoYZpaRh3yhs/YKxMQ06TonNBKOEshtyRZim03WCX?= =?us-ascii?Q?hbo+agaX4oxiRSkXNDDi0104ocHD8RjGcSNs7pGQByixiLn8miVfHUutaE25?= =?us-ascii?Q?zpR2IFxyc1f69qUSbfAaAcV7M5aBX7B8EhhCPa5acYvXqNO8zmR1R2ZI/q+5?= =?us-ascii?Q?baeSvOg1oi3DUBlg6M9VyxqqcIormc/5NnnGpbwPrICq2sN4IvMNars9WWR0?= =?us-ascii?Q?P75hMyEnla2eDVjVETCiNE9AAtnoAEXONwMcqcTEPbbmaxdIllrSTkaIgjp1?= =?us-ascii?Q?pyhmpraodRzSQjm7lskMOOXkpVDQKYafWAb9oowqeWazgOa+PG5H2IcLxDmA?= =?us-ascii?Q?lDVjrs4qjVOxgnu+VdQPn0GzkrnhLVhNEg0/MavhlpVjHzZxTX9vSsCwQF0L?= =?us-ascii?Q?RWHaohB1OrPQLGYVtFWFhD+EZtip6Z4Y4unPtm2uvNWCnf8sDxP2XYqJMmzb?= =?us-ascii?Q?mzb4E6Jrcg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 368d7a09-4f9e-438d-af6f-08da3fae1583 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 06:56:54.6344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /F4JTJX2VslPJOnspQ4Za+GPNOgX4bm2OcyRtoq8hFSQpQ50NjrA8YtVXpphRCzecFBlAoqOxGFrTUHDICWo2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4314 On 26.05.2022 21:57, Stefano Stabellini wrote: > On Thu, 26 May 2022, Bertrand Marquis wrote: >>> On 26 May 2022, at 11:15, Jan Beulich wrote: >>> On 26.05.2022 11:54, Bertrand Marquis wrote: >>>>> On 26 May 2022, at 10:43, Jan Beulich wrote: >>>>> On 26.05.2022 03:02, Stefano Stabellini wrote: >>>>>> On Wed, 25 May 2022, Julien Grall wrote: >>>>>>> On 25/05/2022 01:35, Stefano Stabellini wrote: >>>>>>>> +- Rule: Dir 4.7 >>>>>>>> + - Severity: Required >>>>>>>> + - Summary: If a function returns error information then that err= or >>>>>>>> information shall be tested >>>>>>>> + - Link: >>>>>>>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob= /master/D_04_07.c >>>>>>> >>>>>>> >>>>>>> ... this one. We are using (void) + a comment when the return is ig= nored on >>>>>>> purpose. This is technically not-compliant with MISRA but the best = we can do >>>>>>> in some situation. >>>>>>> >>>>>>> With your proposed wording, we would technically have to remove the= m (or not >>>>>>> introduce new one). So I think we need to document that we are allo= wing >>>>>>> deviations so long they are commented. >>>>>> >>>>>> Absolutely yes. All of these rules can have deviations as long as th= ey >>>>>> make sense and they are commented. Note that we still have to work o= ut >>>>>> a good tagging system so that ECLAIR and cppcheck can recognize the >>>>>> deviations automatically but for now saying that they need to be >>>>>> commented is sufficient I think. >>>>>> >>>>>> So I'll add the following on top of the file: >>>>>> >>>>>> """ >>>>>> It is possible that in specific circumstances it is best not to foll= ow a >>>>>> rule because it is not possible or because the alternative leads to >>>>>> better code quality. Those cases are called "deviations". They are >>>>>> permissible as long as they are documented with an in-code comment. >>>>>> """ >>>>> >>>>> Hmm, so you really mean in-code comments. I don't think this will sca= le >>>>> well (see e.g. the DCE related intended deviation), and it also goes >>>>> against the "no special casing for every static analysis tool" concer= n >>>>> I did voice on the call. >>>> >>>> On this subject the idea was more to define a =E2=80=9Cxen=E2=80=9D wa= y to document >>>> deviations in the code and do it in a way so that we could easily subs= titute >>>> the =E2=80=9Cflag=E2=80=9D to adapt it for each analyser using tools o= r command line options. >>> >>> I think the basic scheme of something like this would want laying out >>> before doc changes like the one here actually go in, so that it's clear >>> what the action is if a new deviation needs adding for whatever reason >>> (and also allowing interested people to start contributing patches to >>> add respective annotations). >> >> We will work on that but if we wait for everything to be solved we will >> never progress. >> I have a task on my side (ie at arm) to work on that and Luca Fancellu >> will start working on it next month. >> Now I do not think that this should block this patch, agreeing on rules = does >> not mean will respect all of them in the short term so we can wait a bit= as I >> definitely think that how to document violations in the code and in gene= ral >> will be a work package on its own and will require some discussion. >=20 > Right. >=20 > In general, we'll need to document these deviations and ideally they > would be documented as in-code comments because they are easier to keep > in sync with the code. But we won't be able to do that in all cases. >=20 > We'll also need a special TAG to mark the deviation. Nobody wants > multiple tagging systems for different tools (ECLAIR, cppcheck, > Coverity, etc.) We'll come up with one tagging system and introduce > conversion scripts as needed. Roberto offered to help on the call to > come up with a generic tagging system. >=20 > In some cases in-code comments for every deviation would be too verbose. > We'll want to handle it in another way. It could be a document > somewhere else, or simply disabling the Rules check in ECLAIR/cppcheck > (but that partially defeats the purpose.) We'll have to see. I think > it is going to be on a case by case basis. >=20 >=20 > In short, I don't think we have all the info and expertise to come up > with a good deviation system right now. We need to make more progress > and analize a few specific examples before we can do that. But to gain > that expertise we need to agree on a set of rules we want to follow > first, which is this patch series. >=20 >=20 > So, I think this is the best way we can start the process. We can > clarify further with the comment on top of this file, and we could even > remove the specific part about the "in-code comment" with an open-ended > statement until we come up with a clear deviation strategy. For > instance: >=20 > """ > It is possible that in specific circumstances it is best not to follow a > rule because it is not possible or because the alternative leads to > better code quality. Those cases are called "deviations". They are > permissible as long as they are documented. >=20 > The existing codebase is not 100% compliant with the rules. Some of the > violations are meant to be documented as deviations, while some others > should be fixed. Both compliance and documenting deviations on the > existing codebase is work-in-progress. > """ This is better, yes, yet I'm still concerned of "existing codebase": Without it being clear how to deal with deviations, what would we do with new additions of deviations? We need to be able to say something concrete in review comments, and prior to getting any review comments people should at least stand a chance of being able to figure out what's expected of them. Jan From xen-devel-bounces@lists.xenproject.org Fri May 27 07:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337811.562502 (Exim 4.92) (envelope-from ) id 1nuUKn-0003Ut-J7; Fri, 27 May 2022 07:24:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337811.562502; Fri, 27 May 2022 07:24:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKn-0003Um-GJ; Fri, 27 May 2022 07:24:33 +0000 Received: by outflank-mailman (input) for mailman id 337811; Fri, 27 May 2022 07:24:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKm-0003UV-4X for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:24:32 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c4e4fa6-dd8e-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 09:24:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D4C6C21A80; Fri, 27 May 2022 07:24:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9AE88139C4; Fri, 27 May 2022 07:24:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7YtuJK18kGJLIgAAMHmgww (envelope-from ); Fri, 27 May 2022 07:24:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c4e4fa6-dd8e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653636269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=47WCpd+EZFhSVapU9H5XzQiUPnz5KW9QIdGGZN/8BNo=; b=qsJlQQO4WSjfUrCHX4WRRp4u57eejI5VXFfV8wv5ocTJGpecYM9D0IZqh4OHe7IUHkoimS eNvRhCVSQkqhl603t23I1iUF3y7dEM0CTJuvzZZ2J3LVzPBBBmWeVSoyk6nSguxOEbAGk4 dfNcV+RXVEZpmk9lU9FY7NWLHeDv59E= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation Date: Fri, 27 May 2022 09:24:23 +0200 Message-Id: <20220527072427.20327-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the past there have been spotted some shortcomings in the Xenstore interface, which should be repaired. Those are in detail: - Using driver domains for large number of domains needs per domain Xenstore quota [1]. The feedback sent was rather slim (one reply), but it was preferring a new set of wire commands. - XSA-349 [2] has shown that the current definition of watches is not optimal, as it will trigger lots of events when a single one would suffice: for detecting new backend devices the backends in the Linux kernel are registering a watch for e.g. "/local/domain/0/backend" which will fire for ANY sub-node written below this node (on a test machine this added up to 91 watch events for only 3 devices). This can be limited dramatically by extending the XS_WATCH command to take another optional parameter specifying the depth of subdirectories to be considered for sending watch events ("0" would trigger a watch event only if the watched node itself being written). - New features like above being added might make migration of guests between hosts with different Xenstore variants harder, so it should be possible to set the available feature set per domain. For socket connections it should be possible to read the available features. - The special watches @introduceDomain and @releaseDomain are rather cumbersome to use, as they only tell you that SOME domain has been introduced/released. Any consumer of those watches needs to scan all domains on the host in order to find out the domid, causing significant pressure on the dominfo hypercall (imagine a system with 1000 domains running and one domain dying - there will be more than 1000 watch events triggered and 1000 xl daemons will try to find out whether "their" domain has died). Those watches should be enhanced to optionally be specific to a single domain and to let the event carry the related domid. As some of those extensions will need to be considered in the Xenstore migration stream, they should be defined in one go (in fact the 4th one wouldn't need that, but it can easily be connected to the 2nd one). As such extensions need to be flagged in the "features" in the ring page anyway, it is fine to implement them independently. Add the documentation of the new commands/features. [1]: https://lists.xen.org/archives/html/xen-devel/2020-06/msg00291.html [2]: http://xenbits.xen.org/xsa/advisory-349.html Changes in V2: - added new patch 1 - remove feature bits for dom0-only features - get-features without domid returns Xenstore supported features - get/set-quota without domid for global quota access Juergen Gross (4): tools/xenstore: modify feature bit specification in xenstore-ring.txt tools/xenstore: add documentation for new set/get-feature commands tools/xenstore: add documentation for new set/get-quota commands tools/xenstore: add documentation for extended watch command docs/misc/xenstore-ring.txt | 10 ++++---- docs/misc/xenstore.txt | 47 ++++++++++++++++++++++++++++++++++--- 2 files changed, 50 insertions(+), 7 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri May 27 07:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337813.562515 (Exim 4.92) (envelope-from ) id 1nuUKo-0003fA-Bd; Fri, 27 May 2022 07:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337813.562515; Fri, 27 May 2022 07:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKo-0003do-5l; Fri, 27 May 2022 07:24:34 +0000 Received: by outflank-mailman (input) for mailman id 337813; Fri, 27 May 2022 07:24:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKm-0003UV-T7 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:24:32 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c920126-dd8e-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 09:24:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9EC531F937; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66C4B139C4; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YETfF658kGJLIgAAMHmgww (envelope-from ); Fri, 27 May 2022 07:24:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c920126-dd8e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653636270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LXfNj/iGT8On9btajkRJiSegeiqr4EifmedQT5zKgB8=; b=MRnjpdNTuiaij2HtIBz/4giFm4JwphAzSH2SPbn7zst2jXfoBve17Sd9qyvqpmoBq7FtSs lF/sak4APgN9ydnGx9ixg3D4mEOxpHhZ/hWW2ChlzDqrWGw/2uDB4A60UWTd3PZhSWU9bm K6XTSfDxuvvFrxvrQI76f+IKohN+lEs= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 3/4] tools/xenstore: add documentation for new set/get-quota commands Date: Fri, 27 May 2022 09:24:26 +0200 Message-Id: <20220527072427.20327-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220527072427.20327-1-jgross@suse.com> References: <20220527072427.20327-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add documentation for two new Xenstore wire commands SET_QUOTA and GET_QUOTA used to set or query the global Xenstore quota or those of a given domain. Signed-off-by: Juergen Gross --- Note that it might be a good idea to add support to the Xenstore migration protocol to transfer quota data (global and/or per domain). V2: - remove feature bit (Julien Grall) - add possibility to access global quota and to query supported quotas --- docs/misc/xenstore.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 00f6969202..49b05e3c9a 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -345,6 +345,23 @@ SET_FEATURE || xenstored prevents the use of GET_FEATURE and SET_FEATURE other than by dom0. +GET_QUOTA [[|]|] | +SET_QUOTA [|]|| + Returns or sets a quota value for the domain being specified by + . Omitting will return or set the global quota + values, which are the default values for new domains. is + one of "nodes", "watches", "transactions", "node-size", + "permissions", or any other implementation defined value. For + GET_QUOTA it is possible to omit the parameter together + with the parameter, which will return a single string of + all supported values separated by blanks. is a + decimal number specifying the quota value, with "0" having the + special meaning of quota checks being disabled. The initial quota + settings for a domain are the global ones of Xenstore. + + xenstored prevents the use of GET_QUOTA and SET_QUOTA other + than by dom0. + ---------- Miscellaneous ---------- CONTROL |[|] -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri May 27 07:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337814.562524 (Exim 4.92) (envelope-from ) id 1nuUKo-0003pR-Rk; Fri, 27 May 2022 07:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337814.562524; Fri, 27 May 2022 07:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKo-0003nC-JM; Fri, 27 May 2022 07:24:34 +0000 Received: by outflank-mailman (input) for mailman id 337814; Fri, 27 May 2022 07:24:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKn-0003UV-TP for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:24:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c4e4fb1-dd8e-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 09:24:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 216D721A82; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD257139C4; Fri, 27 May 2022 07:24:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ONqkNK18kGJLIgAAMHmgww (envelope-from ); Fri, 27 May 2022 07:24:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c4e4fb1-dd8e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653636270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k6QNfdHoQpClTtcFyNorgKp8JNEjHOV3+KrUm17Tu6g=; b=D9GSqwx0VyC/4JZtvww3XF3dFTWmEL6cxsGI9xzMNMYJ0t2qpehEw9/csEaWr7S/ow79XU NGGsgFWUlz/CQyQlZZqQj99aH9vKSkcqtYgnnTmNTrWSwshJScV8ZDCYugq/Abt9EuIcBr rf56Sb2c4Jm/jP9Xe/uuCL06NVJ8Kmk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/4] tools/xenstore: modify feature bit specification in xenstore-ring.txt Date: Fri, 27 May 2022 09:24:24 +0200 Message-Id: <20220527072427.20327-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220527072427.20327-1-jgross@suse.com> References: <20220527072427.20327-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of specifying the feature bits in xenstore-ring.txt as a mask value use bit numbers. This will make the specification easier to read when adding more features. Signed-off-by: Juergen Gross --- V2: - new patch (triggered by Julien Grall) --- docs/misc/xenstore-ring.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt index f3d6ca4264..2792d13530 100644 --- a/docs/misc/xenstore-ring.txt +++ b/docs/misc/xenstore-ring.txt @@ -62,12 +62,13 @@ the server feature bitmap. The server features are offered to the guest; it is up to the guest whether to use them or not. The guest should ignore any unknown feature bits. -The following features are defined: +The following features are defined (bit number 0 is equivalent to a mask +value of 1): -Mask Description +Bit Description ----------------------------------------------------------------- -1 Ring reconnection (see the ring reconnection feature below) -2 Connection error indicator (see connection error feature below) +0 Ring reconnection (see the ring reconnection feature below) +1 Connection error indicator (see connection error feature below) The "Connection state" field is used to request a ring close and reconnect. The "Connection state" field only contains valid data if the server has -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri May 27 07:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337815.562547 (Exim 4.92) (envelope-from ) id 1nuUKr-0004WG-6d; Fri, 27 May 2022 07:24:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337815.562547; Fri, 27 May 2022 07:24:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKr-0004W5-14; Fri, 27 May 2022 07:24:37 +0000 Received: by outflank-mailman (input) for mailman id 337815; Fri, 27 May 2022 07:24:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKo-0003UV-Tk for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:24:35 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cb93622-dd8e-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 09:24:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD5501F945; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A53CD139C4; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sP8tJ658kGJLIgAAMHmgww (envelope-from ); Fri, 27 May 2022 07:24:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cb93622-dd8e-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653636270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+SUmV11tds+ppSwEyJnfHL4XIHvPoscWfM4Hj0mYrg=; b=i+mJb0wqBZEFW+3y5/4of/g4Mt0FA2xAv7LPJOuWePAK7Nv+7XbpUex2kYg2hhafQx4TmF ec0x7Uo9pLTc2dXI4wWDzUTQAXctdEBhRB1jH+l/KRWYMgYcMhFubaI2Tvioa2N+Sf8lP3 /tlz3TCMG+ARSeYtBJ8pRVWvpjPRFZI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 4/4] tools/xenstore: add documentation for extended watch command Date: Fri, 27 May 2022 09:24:27 +0200 Message-Id: <20220527072427.20327-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220527072427.20327-1-jgross@suse.com> References: <20220527072427.20327-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add documentation for an extension of the WATCH command used to limit the scope of watched paths. Additionally it enables to receive more information in the events related to special watches (@introduceDomain or @releaseDomain). Signed-off-by: Juergen Gross --- This will probably need an extension of the Xenstore migration protocol, too. --- docs/misc/xenstore-ring.txt | 1 + docs/misc/xenstore.txt | 16 +++++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/misc/xenstore-ring.txt b/docs/misc/xenstore-ring.txt index 2792d13530..dbc7335e24 100644 --- a/docs/misc/xenstore-ring.txt +++ b/docs/misc/xenstore-ring.txt @@ -69,6 +69,7 @@ Bit Description ----------------------------------------------------------------- 0 Ring reconnection (see the ring reconnection feature below) 1 Connection error indicator (see connection error feature below) +2 WATCH can take a third parameter limiting its scope The "Connection state" field is used to request a ring close and reconnect. The "Connection state" field only contains valid data if the server has diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 49b05e3c9a..e2daf2eef8 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -187,7 +187,7 @@ SET_PERMS ||+? ---------- Watches ---------- -WATCH ||? +WATCH ||[|]? Adds a watch. When a is modified (including path creation, removal, @@ -198,7 +198,11 @@ WATCH ||? matching watch results in a WATCH_EVENT message (see below). The event's path matches the watch's if it is an child - of . + of . This match can be limited by specifying (a + decimal value of 0 or larger): it denotes the directory levels + below to consider for a match ("0" would not match for + a child of , "1" would match only for a direct child, + etc.). can be a to watch or @. In the latter case may have any syntax but it matches @@ -209,7 +213,13 @@ WATCH ||? shutdown, and also on RELEASE and domain destruction events are sent to privileged callers or explicitly - via SET_PERMS enabled domains only. + via SET_PERMS enabled domains only. The semantics for a + specification of differ for generating + events: specifying "1" will report the related domid by using + @/ for the reported path. Other + values are not supported. + For @releaseDomain it is possible to watch only for a specific + domain by specifying @releaseDomain/ for the path. When a watch is first set up it is triggered once straight away, with equal to . Watches may be triggered -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri May 27 07:24:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:24:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337812.562508 (Exim 4.92) (envelope-from ) id 1nuUKn-0003Xx-S0; Fri, 27 May 2022 07:24:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337812.562508; Fri, 27 May 2022 07:24:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKn-0003XC-Oh; Fri, 27 May 2022 07:24:33 +0000 Received: by outflank-mailman (input) for mailman id 337812; Fri, 27 May 2022 07:24:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUKm-0003UW-HH for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:24:32 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c6e98e2-dd8e-11ec-837f-e5687231ffcc; Fri, 27 May 2022 09:24:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6019B21A85; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28F57139C4; Fri, 27 May 2022 07:24:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8IatCK58kGJLIgAAMHmgww (envelope-from ); Fri, 27 May 2022 07:24:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c6e98e2-dd8e-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653636270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6zy0H1QLcikhT3nJW6R/zDsHVZ2kOQtMcpCnXKd1Ms=; b=DrsrayzqmPCppEAAobwVZV/l/JkmprzER9r2PN4rky3JrC2ejxKrJ0sY1fusvlWsT3Hftt Z6oRaJbTi+Ty8LS56YoEWxxArV3oHuaz0rgkSHOc1jhhN+S/MG7cZyBKH5patYd/DiRLvI EaMLzXA33J9w/IB1ca8ourPK3L4Q2ro= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/4] tools/xenstore: add documentation for new set/get-feature commands Date: Fri, 27 May 2022 09:24:25 +0200 Message-Id: <20220527072427.20327-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220527072427.20327-1-jgross@suse.com> References: <20220527072427.20327-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add documentation for two new Xenstore wire commands SET_FEATURE and GET_FEATURE used to set or query the Xenstore features visible in the ring page of a given domain. Signed-off-by: Juergen Gross --- Do we need support in the migration protocol for the features? V2: - remove feature bit (Julien Grall) - GET_FEATURE without domid will return Xenstore supported features (triggered by Julien Grall) --- docs/misc/xenstore.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index a3d3da0a5b..00f6969202 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -331,6 +331,20 @@ SET_TARGET || xenstored prevents the use of SET_TARGET other than by dom0. +GET_FEATURE [|] | +SET_FEATURE || + Returns or sets the contents of the "feature" field located at + offset 2064 of the Xenstore ring page of the domain specified by + . is a decimal number being a logical or of the + feature bits as defined in docs/misc/xenstore-ring.txt. Trying + to set a bit for a feature not being supported by the running + Xenstore will be denied. Providing no with the + GET_FEATURE command will return the features which are supported + by Xenstore. + + xenstored prevents the use of GET_FEATURE and SET_FEATURE other + than by dom0. + ---------- Miscellaneous ---------- CONTROL |[|] -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri May 27 07:41:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:41:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337851.562558 (Exim 4.92) (envelope-from ) id 1nuUaq-00085o-K4; Fri, 27 May 2022 07:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337851.562558; Fri, 27 May 2022 07:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUaq-00085h-HD; Fri, 27 May 2022 07:41:08 +0000 Received: by outflank-mailman (input) for mailman id 337851; Fri, 27 May 2022 07:41:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUao-00085b-Lh for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:41:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5bfc308f-dd90-11ec-837f-e5687231ffcc; Fri, 27 May 2022 09:41:03 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-34-AcT_CfHVMpmY7Fs2hV4vlQ-1; Fri, 27 May 2022 09:41:00 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2868.eurprd04.prod.outlook.com (2603:10a6:203:99::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 07:40:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 07:40:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bfc308f-dd90-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653637262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Db3R6GsmcTxUumRvQ+t3EVrPw3UPI0xvjpYk2TTyieI=; b=hxmp36E5JmDOGaLvYkiId9Mi1DNZRZD33esmRg3FVRptZb1WU2pnovu6pImw9pgyatHSiy QD96F2FxsJ47pVXO4/9Dt47lR0mWjcQrVV6pmvG6xQNEyUpwNVNC/hSaLn412YDaTIPzyw 0SZ7oPscYmjGicV85/s1YahMGJi6FQg= X-MC-Unique: AcT_CfHVMpmY7Fs2hV4vlQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dP0jRmOuC5laHJi1vHMSzEDpM54wPXeEC1ZcuK5MP8NiuaH0fo38caZhGHSPV42QdztuYnm1Leqrquai3LiFBXj7sZWg+mCuV5/kS0LUO0prXdxySQHGltTvGH/oA6r3gTLFt0lRY+k0rKRrYSwiXMtkZnKZvaKbqmnsTY69lbrI6tGV9WsvEP0+sCH1tUSHpSzxPtv4hAu2SGMbqfscJRGTT6/7LYSy8Jy2A+Z6w93pcIjU4NYPm6sOs9bs6OedVLywlMKjhw+trxhKSzO/PxE1rZbZY+vwQNTwQZ/qbhmL3/AQ0TrnbDmQ9P5Klbbkom0S2chNUPyusFqOKaXjvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3yddbvIOnhvFgG3s8kT9/LJSggHOBAOP5aOkDuNh54=; b=C2ykw9p3kJGR+IIhjgRuyNcJYn9/HnkKJ4t4PqJPOu96VkXVirG0xJkYrgEl5DOip53gVeONKHhNNc1UiDvdE3uPn1ucSnKgJN0vCEqQbDJ8H0uQPguhyqhtmalUq1HqvOrRyXOwGoa4j2NXDYe4qXfDZIDHyWkynWGAWnGx6LlZ1wAMKoQ06aO64obxcVcrULgwKDJ+ciP3iNq8lFG4MIh8EvvyKR7sJutHaegdyoxBaFaqFNOwckrrkznl/dnjIkBqyFyr6A7cPYpyfRS1fGWSx0D7t88Mivo/xJsGpRCMb8J7/C0TEju1W1icUdpi86i3oj26JNlzRd0YDtCjhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 09:40:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian References: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR05CA0016.eurprd05.prod.outlook.com (2603:10a6:20b:311::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fe8483b-bd84-41ca-7c45-08da3fb43d50 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2868:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d3BIyq7ttsVWlLgmVXBsTgXF5rOFMVXdVU9NIc7XCzV9dhEP996RfoncJw22G2QjBVgiupK3VN4BHxH57pMLFmAykBwY5g0aMD3o5xpQJFxwM82yRBMbOcpzKl4lZCgLtBtbC76TnXkcctxU8Mx3skzD4Jk4Q4L5ytDS4c2qMbMhvqSKdnSaGBTZiYDkx6GIe6XWPv5oiL+zfRuG6E8s6GtSJvFsYNQ9nuUScdeE09pn9x5b1GYqBSvxva66QwzG5C38LmNaUdHOVN9kB+UvAJIcTDVV5DfLPLuHLmLGNC+BHgc9iBwSmX2YZf36fhL14rXxWG8wL0EdvuVqc76wJi4MFZBdIWofXfpzugeeX1qn3kh5wbPLrPNOYhZwNLuKDwtzvCLkt0+4wAUBGB8smRLTwE9WXoIeclNMHJmgOksf36uD6tg537PGAV6L0YBZFi5IYzCtckz+6DwD9uZQoi3TdqLnr4EG8sX6V7jk91FUeZw0ziqMef3yc4dFlLE0QPkQ5q13jzQSw6H8NgphcxBWyh7o/XXxzyAXh4t4LRsvNLXds427dsQrp/TEi6y4GJhgEEqCArEvf2JsFyCmBw/lvrqY6eGmHsxIMbSODsiDS+/9JKM0P8s/KL3VdCn+LSetKdZ65JC8Gw1K5QLuQBi52Rk/ZXFfPncKJFk+qc/OTIONuglEL7cifrDwPZFXGTpMcF22J14ZEJWWlrMxLoc88dmjBDkJp5ZMTz7hR24= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(316002)(8676002)(54906003)(6916009)(5660300002)(2906002)(31696002)(4326008)(86362001)(83380400001)(31686004)(66556008)(66946007)(6486002)(66476007)(6506007)(6512007)(36756003)(186003)(53546011)(26005)(2616005)(508600001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uUW71NMt1p0wa+PQDxonjWKpf546PgIoG5yn3zm2w0UmCJna9Y4naskJwOJL?= =?us-ascii?Q?bUTHG+A9GHW4Ns0wEwvpKNGGyr5NmkUklOEV3aCjJScnWFGmr2DCL9OkY6al?= =?us-ascii?Q?9IxFr0NqTbvVDbWZhfptblcLioZb93ZqfGspIhCVMxTLbVzxTEdcTWZ8KfZT?= =?us-ascii?Q?U8FPL81/d9hW8DNWNJifbeuER93ACpNdH1IdvzkcsFjwzExitRiISPL4UmsA?= =?us-ascii?Q?FgvEckLfNWeWqvA0vIEuF7Kse5qcjDjwozmLC9lIm7cSQQ6WJ+W8bhPD6YYX?= =?us-ascii?Q?qf/rON0rRe+l46fraynkOrrQq8jtxRTfKR0e4Gy80GDyT5A1xmXjlZr6iyRp?= =?us-ascii?Q?RbiPfMrYMJCH54+dVDuybcM5pr7Qs2z1v5oQlDDB98a0zatnrity28pGEc1X?= =?us-ascii?Q?sLqB4ZWe58N0zqKb5G464lLBoSc57XjTOaOgnQwlucuRcxtbNukMvSowzWxv?= =?us-ascii?Q?NFT2tbYVSVTWQAwiDGonMMkA809+mC6x5cLKTEahdp3d6sVX2c+JS7jqPcr2?= =?us-ascii?Q?iHnGieDXDEBXNInlkDbIQcGCYYnC7t7tiBKp4uGw8oTdo7gjIkai9ZiBEgrw?= =?us-ascii?Q?0QCVqYQQWuclqWVCSaQ8ukjEscRGOBMO4TC8DtBAqJ4Dev30qHMq3VqllwpF?= =?us-ascii?Q?qnKsvRfbtIeXhELdLxrgDK+MnMiaLoRWjf18QQfSFTDR8ybdFIjsRyaSYp2J?= =?us-ascii?Q?Tuzy6rCkdXRw1kxbU/M5vZk+dWGKUszW5224EcrDXNnLRN0M2MhbvT3H5gtS?= =?us-ascii?Q?yfmwjNTC9G2AkpmU4Z06h+kbNO7hTQSy77olSSWpAMGg3joAY/WPEfBCOnMs?= =?us-ascii?Q?v4W6fC5lc17CnPRD8qVw7Wr4FxILt6WUh1h+wNE3j3Ktoy7UXvPqqJMxEfy9?= =?us-ascii?Q?XLyFQlYJRQoNz9zAuP8mP1XW6A860aWd/O4wjunHrKO6vsOJhx7bfcf7PjOz?= =?us-ascii?Q?X+2sMzl5Cy6wmlrFzrFxcF+aPNraWk/hS4eOQvomwHFn5u1DE3XA5//loeCH?= =?us-ascii?Q?OcDbXVmsKwsXjuntnbsdaRF3GKdKoE0A8E0tq+h3bcb53S6+LXDbuCx832pK?= =?us-ascii?Q?894FkV5jbjxruTNwNLoJxfYYNxO6MJwBoxehbGgmxKdpwyw5AdLrBKMhqjQO?= =?us-ascii?Q?M9PmOt/v7NR46gNB4/Y0DRs2X6t8m5bFcD1XJ8HHIcVSoK4xh/hjFtIoBOiL?= =?us-ascii?Q?gSOxWikGIKlzgjhmmeywARri2ZBZto8R3P0dk9Z1Jl/P8DT2iobFikB8om2C?= =?us-ascii?Q?jb97fY9Yu5wdIlpiaqUL89fn2ja6gi/gX0W5zaA3GKjbB3srHWgRxvpJWqGS?= =?us-ascii?Q?0Q9cuWj7380pkPGu+Rp/Ij/qNiM+a5WF5eZx2vxN6WuU8fkzQcbuBjttFOqC?= =?us-ascii?Q?WOPIuVX7EzvnLkAws1LsxzA/a9hxfEVheHK8xWuAQQV6bGHNc9EKECoycVYZ?= =?us-ascii?Q?wkmNzOKZMOuVZOK/+Nu7edknd92V9Hc2ss69gHzmxBQaBaXPvYWGYlkXeo6+?= =?us-ascii?Q?odO3M4Ae0C8ojRD5BZ/zcEhrvjrxwMgw3g9dyCZJ7iCqE6X+fLzd7IsDLU7s?= =?us-ascii?Q?i02lNsrZZ00RepLmokLg5n5bO7t7lR1GioptQufEuUsG0zh7Mkz4Kf0ka8bC?= =?us-ascii?Q?R/29aw5IEOjKeXdYstLr7s8wAJp6QZjFdi+Oinviosj5chLEOCJKH775k0ou?= =?us-ascii?Q?Oczj7abqZanZy8UYOQbvpOPtoSJlJGLGfdV3a6bR6sBTvgAiirHgkZJMhMTe?= =?us-ascii?Q?RfuQIjmgqQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fe8483b-bd84-41ca-7c45-08da3fb43d50 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 07:40:58.3256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qFeLOQyKK3CEanawRvZLUseZ+dBw4uwNsHSIVLaVlTeSuh9GgCxUfDrl9P5l85RlkjF9y4f1tfmDo0cbo7UrLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2868 On 20.05.2022 13:13, Roger Pau Monn=C3=A9 wrote: > On Wed, May 18, 2022 at 12:26:03PM +0200, Jan Beulich wrote: >> On 10.05.2022 16:30, Roger Pau Monn=C3=A9 wrote: >>> On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: >>>> @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma >>>> =20 >>>> old =3D *pte; >>>> dma_clear_pte(*pte); >>>> + iommu_sync_cache(pte, sizeof(*pte)); >>>> + >>>> + while ( pt_update_contig_markers(&page->val, >>>> + address_level_offset(addr, level= ), >>>> + level, PTE_kind_null) && >>>> + ++level < min_pt_levels ) >>>> + { >>>> + struct page_info *pg =3D maddr_to_page(pg_maddr); >>>> + >>>> + unmap_vtd_domain_page(page); >>>> + >>>> + pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flus= h_flags, >>>> + false); >>>> + BUG_ON(pg_maddr < PAGE_SIZE); >>>> + >>>> + page =3D map_vtd_domain_page(pg_maddr); >>>> + pte =3D &page[address_level_offset(addr, level)]; >>>> + dma_clear_pte(*pte); >>>> + iommu_sync_cache(pte, sizeof(*pte)); >>>> + >>>> + *flush_flags |=3D IOMMU_FLUSHF_all; >>>> + iommu_queue_free_pgtable(hd, pg); >>>> + } >>> >>> I think I'm setting myself for trouble, but do we need to sync cache >>> the lower lever entries if higher level ones are to be changed. >>> >>> IOW, would it be fine to just flush the highest level modified PTE? >>> As the lower lever ones won't be reachable anyway. >> >> I definitely want to err on the safe side here. If later we can >> prove that some cache flush is unneeded, I'd be happy to see it >> go away. >=20 > Hm, so it's not only about adding more cache flushes, but moving them > inside of the locked region: previously the only cache flush was done > outside of the locked region. >=20 > I guess I can't convince myself why we would need to flush cache of > entries that are to be removed, and that also point to pages scheduled > to be freed. As previously said - with a series like this I wanted to strictly be on the safe side, maintaining the pre-existing pattern of all modifications of live tables being accompanied by a flush (if flushes are needed in the first place, of course). As to moving flushes into the locked region, I don't view this as a problem, seeing in particular that elsewhere we already have flushes with the lock held (at the very least the _full page_ one in addr_to_dma_page_maddr(), but also e.g. in intel_iommu_map_page(), where it could be easily moved past the unlock). If you (continue to) think that breaking the present pattern isn't going to misguide future changes, I can certainly drop these not really necessary flushes. Otoh I was actually considering to, subsequently, integrate the flushes into e.g. dma_clear_pte() to make it virtually impossible to break that pattern. This would imply that all page table related flushes would then occur with the lock held. (I won't separately reply to the similar topic on patch 18.) >>>> @@ -2182,8 +2210,21 @@ static int __must_check cf_check intel_i >>>> } >>>> =20 >>>> *pte =3D new; >>>> - >>>> iommu_sync_cache(pte, sizeof(struct dma_pte)); >>>> + >>>> + /* >>>> + * While the (ab)use of PTE_kind_table here allows to save some w= ork in >>>> + * the function, the main motivation for it is that it avoids a s= o far >>>> + * unexplained hang during boot (while preparing Dom0) on a Westm= ere >>>> + * based laptop. >>>> + */ >>>> + pt_update_contig_markers(&page->val, >>>> + address_level_offset(dfn_to_daddr(dfn), = level), >>>> + level, >>>> + (hd->platform_ops->page_sizes & >>>> + (1UL << level_to_offset_bits(level + 1)= ) >>>> + ? PTE_kind_leaf : PTE_kind_table)); >>> >>> So this works because on what we believe to be affected models the >>> only supported page sizes are 4K? >> >> Yes. >> >>> Do we want to do the same with AMD if we don't allow 512G super pages? >> >> Why? They don't have a similar flaw. >=20 > So the question was mostly whether we should also avoid the > pt_update_contig_markers for 1G entries, because we won't coalesce > them into a 512G anyway. IOW avoid the overhead of updating the > contig markers if we know that the resulting super-page is not > supported by ->page_sizes. As the comment says, I consider this at least partly an abuse of PTE_kind_table, so I'm wary of extending this to AMD. But if you continue to think it's worth it, I could certainly do so there as well. Jan From xen-devel-bounces@lists.xenproject.org Fri May 27 07:53:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 07:53:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337860.562569 (Exim 4.92) (envelope-from ) id 1nuUmT-0001Fv-RY; Fri, 27 May 2022 07:53:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337860.562569; Fri, 27 May 2022 07:53:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUmT-0001Fo-OU; Fri, 27 May 2022 07:53:09 +0000 Received: by outflank-mailman (input) for mailman id 337860; Fri, 27 May 2022 07:53:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuUmS-0001Ff-Jn for xen-devel@lists.xenproject.org; Fri, 27 May 2022 07:53:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b94bc6c-dd92-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 09:53:07 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-Bewh6a0SPey-B_CE2LgD-Q-1; Fri, 27 May 2022 09:53:05 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3693.eurprd04.prod.outlook.com (2603:10a6:803:18::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 07:53:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 07:53:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b94bc6c-dd92-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653637986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G9C1HRqc1iVS2s5tgGNBJQHT0+CjR0l3XVIp0LNrG/U=; b=hhj+XiauBnCz4+q78Pda8oyGbhFbUvs2ILKEYWhzfKutdjYTwgjn1kPiAfNNA0qhG67+YD ferl+iUGTVDXJjV9iE68LK77NQ6qGfQwmtf34dAqzjluCgLRf6Vc2XIZmDh4ftwBnxfFBY Odpl5I7yKyaRG1HtYESUgDYy3JRrDyg= X-MC-Unique: Bewh6a0SPey-B_CE2LgD-Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YW5rkfpyj17XMAC+dZ1UvtfFXJhXVPNpyqJ5FHjls2n2ZMFMjYubCUiR8/A55DLvO8HaXwHzs7jr5cc3CL7q0yShyB8/5cjeGqx7Kb47ABtcUBrHcfeQfpW1SymGaBetl4tJDusMazZXhGCNqycUL4LPU5ZOwZj5ETN8je7/QektG7Mjx66m/O8tzRSvi3piT29QBL5TTiOuBdMBOZkTGm8o4Gm7PFewZfN2AoO6OljbPyorA4SNSeD5DAkNJuBHEeCYjhkilGp97jotYMAjsI1EISfz6IEh/lUEffPHof6O2CJYhXuQEbfa6B2CJmeT5snERy7Z4aZYLFOiioUZIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VSvPm7R1X0XleUpi6y49OWGYaku6iZiDPSjq4GztORo=; b=e4OsjCDFxmKfjC1/ipyOF33psOpdbRAmMX90Xvh8BAbQtLV9YFdG4KLp/a9I34q1mwPePJghkh7FRyeQOlhTaMpuEINHmziK1BFRWjvFE4N9eJRS58UmDdIe/sns0up7gIjeVNxCK2gdn9xWV98ZLQfA4MEho+4cMr0zagO/cdrib0x6FvXB89n002QWRLalZAjAwfuKMdCDkF7sE99MisN6UQv5I7ivfHVG2MMzjQsjD1ETkrKTnqBdYr4pGOVRkMRld16A5hKRlOtxzEej0Zzr9qAIC+J7DHvUa6Yx6Kk7gQAnbPuHud7yOskez1silTbLXLAWNZpOd1gsnSscSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <91536f56-a94f-273c-4364-cfd5a24078e2@suse.com> Date: Fri, 27 May 2022 09:53:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Content-Language: en-US From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian References: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P194CA0105.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::46) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2762a93-c0ef-4a80-29bd-08da3fb5ed81 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3693:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WXnQCcQ3/efUPmRcR7X3i+0uCfavbkaZzeOSogkyfIXhJGxN8+dh49nnUV31gZ765I6e1cfW0pYgXAqKTn8GWtEcjq8JMVpmZz/BNSGpKezrH5Us5QL02GEBbmmKf/T6XnolIMnDj3gMvnUAUCOFG0Se2XdBEeHEz9NyqANPMfJfl6ic3AVAhRbA1pxuvck0VLaRQutYgpbKLThoIpqdVdYRs+XNFqSE5yrfaT6wQO4M5dI943Fp8LUjSNVJVKNvQ27IpXaHa8aABub0A63fdgYBjX8xqazOJeNEk7jLKljmL8P/rw5npX39ca0w11giYAC33emrZnsvMV8mmYyyUTzsaohgs3mQk2hqcj5ZZ+H9QkN1G5s6/Np7xsH8VvzQ0sH4gs6NBRTSs3qyvYnFbuKpUpiIZxCy8+EbW2a+2JiXIpqZintmZOA9B7WNK2kRGIjK+i5VdlYWP8f89N/6nRfCGs49wcQ+mHVnmeEn2Y7mTULK1T33zXxwYawdaS69fAdQ+PxLKX8Mayv5bhDRYJZa6iPivNNvNIm34hf6kccnGmPjuZhDSopm+mAWm6TIIrZ+wIcKvXU7gzmMtFbOi2/8iuTkUxwi/WjBBxv1bk5TOjijYJkngDNiG1OOafhe6BAIUIMamCtWV+5Nxt8sWthsQQBnCEiHX135o42GD9AdU3yDp6LsbWhcOFNOSiMBasEShSgdYjwW9ocqPgQbWvBKhA4QTjGmKRXsLJLQheObt3w5hap8s46htxd1rEAi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(186003)(66946007)(66476007)(66556008)(4326008)(8676002)(31696002)(2616005)(2906002)(86362001)(5660300002)(38100700002)(8936002)(31686004)(6512007)(36756003)(6506007)(316002)(53546011)(26005)(6486002)(508600001)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dLI2Is47n/xf2smmkxpI83piagEYrbtHJav2qfuPHqcqra7rjHFzBK86o+WK?= =?us-ascii?Q?avjaTDeOF1puOWV8uAMHgHk+zBn5p4LWWgqmwafVOkU3XbXPH0D3bEZ4dPYV?= =?us-ascii?Q?ATF0O8XDkhq4VF1ljakNKqfX08o1SRRO3VMhmrxRTR+fn4TtZN6KX0WVctrA?= =?us-ascii?Q?hC9MIg810eQ+JlV5TZwjZ8oJ+IbQVRlwutr5EOfAEjhNCSHkL15qHYayoHda?= =?us-ascii?Q?U91UAJcW9AvUr53hb7ypPtEok/IVZRO0/SUZ2KFVGMEQfk2ljE5pPPW9Ri+c?= =?us-ascii?Q?Nt4BwjVRDOBPUSCH+OZ3Es3zdHSdlz3qH7HZLLvHiMmgr5sYA09UrPwUrK6y?= =?us-ascii?Q?uEq+hs9I60xca0i0eAh+uLWCd+iCMS1VVNaq7xE5WlqM1NYvJjjNXBEoSxhk?= =?us-ascii?Q?SN+2HTT9gEyeBo/5Eo8WjgGjoiOmJTsRZG8Se1hW1D3YpAwm0J7MBK4ULjkW?= =?us-ascii?Q?Hh9cGI/th1jKZt8+CREnVT30i2e06fIBndDTp8L1e3hjc35OhiLEzQCwJKQ0?= =?us-ascii?Q?utxRuwtOEikOn4ZPoNAwpeHrTYh/2EUIy7vusQV93jDLTSi5rjwKkEHb7Prg?= =?us-ascii?Q?U57qhODlaJ+FeGKhXUiczK4I8VV45kSPKs5rxpa5UdBuXOBgqIzgLBCHey9c?= =?us-ascii?Q?RZPlrVPc4EN5kQ/gJ1jqa0Kbk74qUNwrgZTDUynMET38Ika82cIZbkHInmbz?= =?us-ascii?Q?JjcDUI3aaw+Z9xO5CJlroA3D6E6OeFxF2vn/kS1uCoCrxF0PrGXbp+SV1mPd?= =?us-ascii?Q?0f1YmmRvZT1FMYCmVyBCXb3SdckCh5TRNMBPlRH2V+csF0p3mDc5hgyygB1J?= =?us-ascii?Q?Xlat+PP9SpAkjvoNM6nRAMwuLAd36qjBw7GuT6Q5x2ZlKiMC/E4DbS70i8Xe?= =?us-ascii?Q?kStkt2uoN7DSl56S5/TM7Z3aDPGqKJYk2JBmgOIWXPDH3oW5U/Rk28S6qVMw?= =?us-ascii?Q?TEPzIxLdSFnRCSi7kGHX1DjTVrYDDvMT6UBZk9C4jntT3GBRr12Gto7AvX3E?= =?us-ascii?Q?HBfBUSan0AxnC6bVFbYhBcrAJmdvDL64wDZjpeRicCmFvMmiplm0bKEpVq17?= =?us-ascii?Q?O08W8YBjtMKQ06kmIKnteU56L3FQjPS6hgq5pMVXAf4YxsCKPmrRvHYSBgvJ?= =?us-ascii?Q?fy4fPGt4ILmNhmRWCKxU3iuMv63bGIsSkxZdxIDzsuy+Nv22EPLtqLG3qAwz?= =?us-ascii?Q?JdYzejqPdIZ6zGCJEUVcBaNCb/UTFpZG2GGok27QJtt3+V7+JYyLawFI7BHL?= =?us-ascii?Q?4JUcu+Jcm6dfiMvgM9lSBm9GZpWZTV5AdUBGLKM72O58+KZvLvjN97QLdqbT?= =?us-ascii?Q?RwE0Q/5w5n+bkWQgQrlOcMgUKA0pcpciYlha/J8l7x0lMgGsMtN7+BnR6u2N?= =?us-ascii?Q?mSa/ZWKhXYli3SI8nQzBKK7IP3i81sfGSjuXabTLCpTEHcOlXZxfv3YLhsmR?= =?us-ascii?Q?gbmgMzrsc2SweCPzB0wZsPoI0Vi25kprXCKdSRF+yeEJ4vJkVukCtol/G9fJ?= =?us-ascii?Q?pCtyIqMpwW7hHQjHjoGoY3KQVy7N2WDKXWbr0dBltYnOr8dkRBU+XzxOCXMR?= =?us-ascii?Q?dolUF0DufJ9kv8+HwZHLQ+3uhkk5oqE7Kjs1+hMR0BqsZFJm1YrBmZBPK7CV?= =?us-ascii?Q?Z9NumcFz0j8RT50uz6oZBjeBxqSlrSgnMtUv5FethQBae0Vpkeh7EDqxKFPf?= =?us-ascii?Q?xZSeDkNethsvXT6BpnWq18ClX+mHTsJoYhQ2Yyz9KlYbx9oT7LYtPvVUMt5K?= =?us-ascii?Q?OJz8VonlMw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2762a93-c0ef-4a80-29bd-08da3fb5ed81 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 07:53:03.4516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X7lQyN+jhQpTB05IdDbyVvPHZALEBLjdW2OAqCEHlyrdm3KGkiGNTrx051sf/7tGtNxkhkjCDydQlWRO2XKKnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3693 On 27.05.2022 09:40, Jan Beulich wrote: > On 20.05.2022 13:13, Roger Pau Monn=C3=A9 wrote: >> On Wed, May 18, 2022 at 12:26:03PM +0200, Jan Beulich wrote: >>> On 10.05.2022 16:30, Roger Pau Monn=C3=A9 wrote: >>>> On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: >>>>> @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma >>>>> =20 >>>>> old =3D *pte; >>>>> dma_clear_pte(*pte); >>>>> + iommu_sync_cache(pte, sizeof(*pte)); >>>>> + >>>>> + while ( pt_update_contig_markers(&page->val, >>>>> + address_level_offset(addr, leve= l), >>>>> + level, PTE_kind_null) && >>>>> + ++level < min_pt_levels ) >>>>> + { >>>>> + struct page_info *pg =3D maddr_to_page(pg_maddr); >>>>> + >>>>> + unmap_vtd_domain_page(page); >>>>> + >>>>> + pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flu= sh_flags, >>>>> + false); >>>>> + BUG_ON(pg_maddr < PAGE_SIZE); >>>>> + >>>>> + page =3D map_vtd_domain_page(pg_maddr); >>>>> + pte =3D &page[address_level_offset(addr, level)]; >>>>> + dma_clear_pte(*pte); >>>>> + iommu_sync_cache(pte, sizeof(*pte)); >>>>> + >>>>> + *flush_flags |=3D IOMMU_FLUSHF_all; >>>>> + iommu_queue_free_pgtable(hd, pg); >>>>> + } >>>> >>>> I think I'm setting myself for trouble, but do we need to sync cache >>>> the lower lever entries if higher level ones are to be changed. >>>> >>>> IOW, would it be fine to just flush the highest level modified PTE? >>>> As the lower lever ones won't be reachable anyway. >>> >>> I definitely want to err on the safe side here. If later we can >>> prove that some cache flush is unneeded, I'd be happy to see it >>> go away. >> >> Hm, so it's not only about adding more cache flushes, but moving them >> inside of the locked region: previously the only cache flush was done >> outside of the locked region. >> >> I guess I can't convince myself why we would need to flush cache of >> entries that are to be removed, and that also point to pages scheduled >> to be freed. >=20 > As previously said - with a series like this I wanted to strictly be > on the safe side, maintaining the pre-existing pattern of all > modifications of live tables being accompanied by a flush (if flushes > are needed in the first place, of course). As to moving flushes into > the locked region, I don't view this as a problem, seeing in > particular that elsewhere we already have flushes with the lock held > (at the very least the _full page_ one in addr_to_dma_page_maddr(), > but also e.g. in intel_iommu_map_page(), where it could be easily > moved past the unlock). >=20 > If you (continue to) think that breaking the present pattern isn't > going to misguide future changes, I can certainly drop these not > really necessary flushes. Otoh I was actually considering to, > subsequently, integrate the flushes into e.g. dma_clear_pte() to > make it virtually impossible to break that pattern. This would > imply that all page table related flushes would then occur with the > lock held. >=20 > (I won't separately reply to the similar topic on patch 18.) Oh, one more (formal / minor) aspect: Changing when to (not) flush would also invalidate Kevin's R-b which I've got already for both this and the later, similarly affected patch. Jan From xen-devel-bounces@lists.xenproject.org Fri May 27 09:17:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 09:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337876.562580 (Exim 4.92) (envelope-from ) id 1nuW5k-0001Fb-8m; Fri, 27 May 2022 09:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337876.562580; Fri, 27 May 2022 09:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuW5k-0001FU-50; Fri, 27 May 2022 09:17:08 +0000 Received: by outflank-mailman (input) for mailman id 337876; Fri, 27 May 2022 09:17:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuW5j-0001FK-D5; Fri, 27 May 2022 09:17:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuW5j-0006Md-6f; Fri, 27 May 2022 09:17:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuW5i-0002Kn-T2; Fri, 27 May 2022 09:17:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuW5i-0003DL-SX; Fri, 27 May 2022 09:17:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZVeHql1EH8ewazErP5OZnUr5lOWMowFEoSZrPxGnrRo=; b=GAjOyqHx2Zx4CHEnZlPCvf73RG J6qAUcRXVVvENEvaPEYtBeCpoZNf9WdXB0U5vW0VxFagu0OBQwcrnx2hq7kT5pFMwnxfSPZmlzDrh nDRPzULf1EzVD1edTNALdkYjVjv20A8cHtdLpjd9zHSmjhcILIA3Gh7C3e6eXT8TmZVE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170752: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=be1d39f6bd9162f9273a1857ce93aa77f2272b61 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 27 May 2022 09:17:06 +0000 flight 170752 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170752/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt be1d39f6bd9162f9273a1857ce93aa77f2272b61 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 686 days Failing since 151818 2020-07-11 04:18:52 Z 685 days 667 attempts Testing same since 170752 2022-05-27 04:20:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 110042 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 27 09:22:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 09:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337888.562591 (Exim 4.92) (envelope-from ) id 1nuWAc-0002ko-1r; Fri, 27 May 2022 09:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337888.562591; Fri, 27 May 2022 09:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuWAb-0002kh-TH; Fri, 27 May 2022 09:22:09 +0000 Received: by outflank-mailman (input) for mailman id 337888; Fri, 27 May 2022 09:22:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuWAb-0002kb-80 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 09:22:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a1c3c19-dd9e-11ec-837f-e5687231ffcc; Fri, 27 May 2022 11:22:07 +0200 (CEST) Received: from mail-bn8nam11lp2175.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 May 2022 05:22:05 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CH0PR03MB5985.namprd03.prod.outlook.com (2603:10b6:610:e0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 09:22:02 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.015; Fri, 27 May 2022 09:22:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a1c3c19-dd9e-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653643327; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Y7cnfL49MxddWrHgfBeUq8LqIlaN9rLv+4akuf/mndg=; b=ftIk2OtF+qLOCk4bGOaK2eYL9crLD8kJUXrwUNpib3O0YOaDmC5lY479 PfwkgR02krx4HHl8pfqQ3BOwLe7w9hWnzKOmbKoU9StAfydzMYnruLh/7 L3qgCmx7Yjn944HXHCgJMqb4MrZClYPuADs0IhQQdto3TEDmm7T5OUtn0 Q=; X-IronPort-RemoteIP: 104.47.58.175 X-IronPort-MID: 72710212 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:k4VWMKoymdjey0MQcCZUTFgCNvVeBmIUZBIvgKrLsJaIsI4StFCzt garIBmGaf2LY2PzLo92bIqx8ktSucPRxtY1GgNtqH00Fy1D8ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 4yq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBPPXTxtYHdCNhLzhvF7EFwJaeHVa0vpnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2Z0m8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK//VuuzKKlmSd1pDdasjHR4SjAv5eh0vFq E3b3FreAj0VYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiGaNoxo0S9dWVeog52mlyafK4gDfGmkNSBZAbsArsIk9QjlC6 7OSt9bgBDgqurvFT3uYr+6QtWnrZnVTKnIebygZSwdD+8PkvIw4khPISJBkDbKxidr2Xzr3x lhmsRQDulnatuZTv43TwLwNq2vESkThJuLt2jjqYw== IronPort-HdrOrdr: A9a23:bMrMfai31jK5basUEcwJtjPz4HBQX1N13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJvhSQRI+Lpv+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lwdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNMN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wSJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABynhkjizylSKeGXLzcO9k/seDlBhiXV6UkboJlB9TpY+CRF9U1wsa7USPF/lp D52+pT5fVzp/QtHNNA7dc6MLWK41P2MGLx2UKpUCLa/fI8SjvwQ6Ce2sRG2MiaPLo18bAVpL PtFHtliE9aQTOaNSTJ5uwHzizw X-IronPort-AV: E=Sophos;i="5.91,255,1647316800"; d="scan'208";a="72710212" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EIS1UOhZAfDTBSzwYgvmdQOK4jj9PTBbOBtYn22mt3EsX/B2LVXr2mm92M/X2uJIq1P762/gzEK9/A3NVDe2N+qilDpzhZGBixkWB1G24Y6hJmglbnXXygLaBWsQN16a2W/6rzHKJyvRMftNLmb0rKfRf11XDvO6tdyKlBZ14XQ/ynBXERFXztC/cwKSwfq49OhkBY2xzzvRyPUWsuT0DbATrNHocnACI1hKyo54qP9MnIpUJrzNJzlpVU4nVovXCO9UG3U8hsiGlLNsKhwuOLOssdN1nm/P7gLr2bCrR8O3fSZlT/hrmxpwHHm5FatqvycY6xz+bRNhIveRz71vUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+/c0EVtgr0egF1R26PpifX+1MWhvkpqtba00TRrCMDM=; b=kHjkX6tRPdoraIT2ixNnuYz+0m1+BKwotuelXP0v1VFq++dll/RwEb4i8LfqzoTFv7IeCMlG9Rcv4xwd+WwmJNo2qesH4Ip7Saz9J7W8w1blLlnDUxykJqr6NNtaNheCvIskp3Z/m3N8PMae6z2c041mMGOws2NTpHPCZrDLfSsrqIxUbTszu/FtvUcjhYfceGgQISI1yevBlzxi05q2MDRw3nGsjZcovWgK9s7LExEbQkBaqH17xXJBs2rQqwrbnWWjq3fjJUgBOFDNFjT23i7o+GtCBnuCz9hq3fVr8p6Wn66PzNYpSCNgTiwALWV1doxon6CE/wcDV30+qxwD2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+/c0EVtgr0egF1R26PpifX+1MWhvkpqtba00TRrCMDM=; b=b+FO/xy+s7RlQkJiThbd8uNUV8gUmCl2s6cCCOM/LKbCRXCJmd4kjruFB/xMBO7/d6jHYVP+LGwfzi7JNVGQL+MJJWe9hehKdwBHiACkHeFZ/6wkcpNN+bE1lXoVabn2sQ/LbiEkjIUVFJAZn+6qSE5wDdxON/cO9rdJNGWrIHA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 27 May 2022 11:21:57 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Kevin Tian Subject: Re: [PATCH v4 16/21] VT-d: free all-empty page tables Message-ID: References: <597c3630-b69f-e885-bb08-a52d2c6e7f92@suse.com> <91536f56-a94f-273c-4364-cfd5a24078e2@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91536f56-a94f-273c-4364-cfd5a24078e2@suse.com> X-ClientProxiedBy: LNXP123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 233512b0-4dc5-44be-40c6-08da3fc25ba4 X-MS-TrafficTypeDiagnostic: CH0PR03MB5985:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ozf3vTKBjg6dns6et0wXwIiRCAbR8A5b3+iC/d9uQlgjZI9OCkDCapZXPXXeYAe246Cq04Nun01rdZIVGLJGL+3FMhCsj9wQQw6NMLaBndILlqhhfPEO7OjdUg9IQ4STkDaDSRw7IwCte6pA9+HrOuaVfvJ8Fdcgc7yJBPq+MlZc07XlCoTNd5rio+0kS9XrvlGm3eAo+K1sKpCD0//qKyiIsOFcKd/ITByHM7wghTP0wwFwkc6wrcJlZiFkxsBTxQvL748qJJqYZz0TTAbhPwmgX4qvJN5QYOJOufB8u5IR34Me6gubUrYRhHXnWcp9HbCS1EGbIsyh6SNsHwkZLCfYZu0UhvAWEFzdnieIYJJ+XaYDVdVZb79SyIHfhuFNY5GxMB+2vbq6t3WYuq93aBMV7m2Sy28VL36tBjgR+g6Y5Gkw/tlWPRP3RbqaqAkeeGMbagGydT3m0IYFD667AkNxMXnmKOb69NabhAJRUTcT1e39pElFBp7LntghmnyOACQI/bxFaL65FMxhKSeFvSeYrnZkz1Qk5zwdobqHxUZFDVJBAhRAwXlbdPP4W5Xh3qJKzSvh1/t1GIkZMBaQceuln3irgerEnVsvbR+RkH/MeHzSs/O97FP8bIux7CGZRRCezIulSnsk7fC6nNkNMlNNIKx3VrUE2WGAeBFp47GX5J8MrYJ4/xeDBsoom6PBpYeMc9XnsAiVIfsnMcnIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(508600001)(2906002)(82960400001)(8936002)(5660300002)(86362001)(6486002)(6666004)(38100700002)(53546011)(83380400001)(6506007)(26005)(9686003)(6512007)(4326008)(85182001)(186003)(6916009)(54906003)(66556008)(66476007)(33716001)(66946007)(8676002)(316002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmNUckNLMWxoUmlsY2F0MlJjZ2NobE5ONGRCSnF6cllZM2owSXZCUm9tSDRH?= =?utf-8?B?TUcxaDA3OFpEcE52aUpDbVVRWDUzNTQ1Mnp2dUpXcjZyOVZ5aFZ1T3k2TXZT?= =?utf-8?B?NFhhK0sySjE1OG8vZ2tXb0VSNi9ISkRIME4vZVZDZ0RLY3NnRFY1eGlxcDN0?= =?utf-8?B?U2tGeHlJMVVkOGc4clE5MzJ3YTB3emV0bTRkMjYwUUlMZGxuWkh6cjdnOXpS?= =?utf-8?B?RjRLL3RDVTU3RUZKclN3WGtMT1N5UE8vVW5qRDNieVo0QUVIZWVMaUxwZkxo?= =?utf-8?B?WThsckh1QjJwaVZLOFhXaUk4NjE5M1Nad0dkUkxpNkVKajZwM1oweUc5Vk1X?= =?utf-8?B?WnpMTkpJN0JUME04WDZYS1A2LzVhUDFEMWJsZU41S2cwK3VZOXZVaVp0SHRK?= =?utf-8?B?cjBMTjVBNE5iVmZsODg2UC9XOHN6SEZIakJsdE1BYjRjTjVTUTM2ZnZ0dS9w?= =?utf-8?B?ZFdTdTlRcEE1UkVSQkJWZWlWL21TTk5wOHZLeTlpanhxVk52SWEyNnVDUzly?= =?utf-8?B?VWdXaUh2cnVkUVhaTTRkZXk1aTNyb09va2gxaytqM3Z4bVZFOHZqV1g5bUhh?= =?utf-8?B?VytNQi9TV2xIbzhpY29PSzkyNTNheExibVlsbGl5WlNGZjkyYmk2cXA2NjlR?= =?utf-8?B?RWVlZ2tOUmJVeHdYZFgyS1Q2NUVoN0hic08xWG9Ha0VIZUVtOGxGTTkwcndH?= =?utf-8?B?NG44RWx1bXpWV2UxZHptazh4cEo2aUxnQ0JWWTVaQ25mZEtobk5yNTNvcTg5?= =?utf-8?B?WkxzMS9FNzYvQUs2WHVSS2dLc1NuYlpoVlBQbStjcUtrVXhvdmV2SXVxWVhP?= =?utf-8?B?YXpESUNVY1p1K1lLU25hcG5tV1hQUU1yb0pqcWNtcU5lSy9nVzNtNEtzeEpz?= =?utf-8?B?WUV1WFV1eWpDOEhEL1ZwUXQ5V1oxWjRURW16ZU5meEJNcE5obXZsOWRzdWdx?= =?utf-8?B?OHJLZjZmcHp0dmxSRUNuSSs1L3RySHUrUGhSRDNzUzFDcHcrQTJWLzBrdmxx?= =?utf-8?B?Ym85K1p4ZWM2L2dwRUlrYzhyd0hKa0RUcEVraXMwMzl3L001dUxrOXQrUUlU?= =?utf-8?B?MjhoOFZ0b3UrcThtVGF5OTB4eFpUa1FseEFBb09XRUxnRUd0bjRDaEdscTJ4?= =?utf-8?B?OWY3ZjFjT2xFMW5ORVd5WUVZTkpEaFV0WmNxUU8vSHRrS054TUFwS3M3a3ho?= =?utf-8?B?S0EwUTB2SXFMNUl0a3B0Rjd0L0ZyK2J1ayt6OWtGY1lVNkdReHUvZHRDVFVj?= =?utf-8?B?NkduTkViVE1aVWdBMXR2NnI4MnBIRG10c3UrR205WVBDV3F3bnRkYmREbklK?= =?utf-8?B?eUZFcitzcjNyemlHaXZNS3QvYW5BcThhZGdJcWVVbWRBN3RuV3VTb00vMWZL?= =?utf-8?B?bUtxSFZRMW1jamE5TG4yV05WZC9UMTNtYlpOdDBpb1hGaEtObHZHMVA5aFk2?= =?utf-8?B?TWpranIxQlBWNHgxMTRJRXBDL3BxbWQzS01pZmE2Rmgxc2xtbEJVVi9obHdB?= =?utf-8?B?b0ZuL1lSS0kvRklWaUZlVEdsWVowdXo4OENSRW82U1FLVWs2SFpyVEhSOXdM?= =?utf-8?B?T1NwY3daNHQ1bGlBZ2Riam1sQXVKcjFqNTJJTjFXM1RjMitxM1o0Sms1Snl6?= =?utf-8?B?SWQ4RWN0Y3d5TGkxUXJlSlRSUHU1dkxLNzhnVWJ2Mlg1R1ZCblVlTE9saE1n?= =?utf-8?B?aUl4M2JhTnQ2R3owWVd0eEdjS3hqUGxLVGhFLzM5aVVkWHhpVUg2VDl3WUFm?= =?utf-8?B?a25jTHpkVjNuYytqYisxRmtoNkRqR2JlOVNQaytXY2JpRzNFZkJaUjNGaGJF?= =?utf-8?B?enhyc2NBRC8zVFZZWGNlaWhVTVRpZ1NBWEkxbHBHUGZ2dStuRk9TRUlVWGhj?= =?utf-8?B?YlgvQ3QwVUxtVjJScVhqVnlSQXpUWHdpREU3RXBjOURYUXlRMllnbVlSaVVO?= =?utf-8?B?Q2ZIQWRSeDAvajZlaFJ4ZWNuRkRCMlJSZVA1NnMxVHNKbnU4UjVjTTJzYVFu?= =?utf-8?B?blllUmFIT0l3aTdYZG11RVpvOGdyWUdPTHNWQzJlZEo1KzZyTjJOWVdqYXUv?= =?utf-8?B?alFsT3E5UDZtUkU4UG92cHFPWWRjbWlnNVlZMklSZDhDaWRsazFYblR3Nkg5?= =?utf-8?B?K0pqQ2ZzOUptZnBjbnJPNERCOVlmUzlRd2grbWFtZUVyYXNDamUrSXZveXlD?= =?utf-8?B?VE9RY25jQWxkdTB6ekJ3VjdkMlFZZjc2bG9nR1V6RkkvdEgvbmdxZHpxa3Zu?= =?utf-8?B?YjB6eSsxSEM1ZS9SVXE2d0g5YnU0REc2UXg2a094TEtjOFlkeXhLSW94MGtT?= =?utf-8?B?SVZjSzdmUzZ1Q1o5VzdvNG5JcE9VN2UrSWMyZGlQb2Jram50blJ4WUVvajA5?= =?utf-8?Q?2MAGZvyZh/HrJwTQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 233512b0-4dc5-44be-40c6-08da3fc25ba4 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 09:22:02.1773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mKTz0HT3HWz5KXW7KmUI5LAtkU2bz5L5W2kBW+ZdLZglDzkBSN6CWZ3gFnqrMU8yDMSJ1+eb4rdTEgHgYS+kKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5985 On Fri, May 27, 2022 at 09:53:01AM +0200, Jan Beulich wrote: > On 27.05.2022 09:40, Jan Beulich wrote: > > On 20.05.2022 13:13, Roger Pau Monné wrote: > >> On Wed, May 18, 2022 at 12:26:03PM +0200, Jan Beulich wrote: > >>> On 10.05.2022 16:30, Roger Pau Monné wrote: > >>>> On Mon, Apr 25, 2022 at 10:42:50AM +0200, Jan Beulich wrote: > >>>>> @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma > >>>>> > >>>>> old = *pte; > >>>>> dma_clear_pte(*pte); > >>>>> + iommu_sync_cache(pte, sizeof(*pte)); > >>>>> + > >>>>> + while ( pt_update_contig_markers(&page->val, > >>>>> + address_level_offset(addr, level), > >>>>> + level, PTE_kind_null) && > >>>>> + ++level < min_pt_levels ) > >>>>> + { > >>>>> + struct page_info *pg = maddr_to_page(pg_maddr); > >>>>> + > >>>>> + unmap_vtd_domain_page(page); > >>>>> + > >>>>> + pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, > >>>>> + false); > >>>>> + BUG_ON(pg_maddr < PAGE_SIZE); > >>>>> + > >>>>> + page = map_vtd_domain_page(pg_maddr); > >>>>> + pte = &page[address_level_offset(addr, level)]; > >>>>> + dma_clear_pte(*pte); > >>>>> + iommu_sync_cache(pte, sizeof(*pte)); > >>>>> + > >>>>> + *flush_flags |= IOMMU_FLUSHF_all; > >>>>> + iommu_queue_free_pgtable(hd, pg); > >>>>> + } > >>>> > >>>> I think I'm setting myself for trouble, but do we need to sync cache > >>>> the lower lever entries if higher level ones are to be changed. > >>>> > >>>> IOW, would it be fine to just flush the highest level modified PTE? > >>>> As the lower lever ones won't be reachable anyway. > >>> > >>> I definitely want to err on the safe side here. If later we can > >>> prove that some cache flush is unneeded, I'd be happy to see it > >>> go away. > >> > >> Hm, so it's not only about adding more cache flushes, but moving them > >> inside of the locked region: previously the only cache flush was done > >> outside of the locked region. > >> > >> I guess I can't convince myself why we would need to flush cache of > >> entries that are to be removed, and that also point to pages scheduled > >> to be freed. > > > > As previously said - with a series like this I wanted to strictly be > > on the safe side, maintaining the pre-existing pattern of all > > modifications of live tables being accompanied by a flush (if flushes > > are needed in the first place, of course). As to moving flushes into > > the locked region, I don't view this as a problem, seeing in > > particular that elsewhere we already have flushes with the lock held > > (at the very least the _full page_ one in addr_to_dma_page_maddr(), > > but also e.g. in intel_iommu_map_page(), where it could be easily > > moved past the unlock). > > > > If you (continue to) think that breaking the present pattern isn't > > going to misguide future changes, I can certainly drop these not > > really necessary flushes. Otoh I was actually considering to, > > subsequently, integrate the flushes into e.g. dma_clear_pte() to > > make it virtually impossible to break that pattern. This would > > imply that all page table related flushes would then occur with the > > lock held. Hm, while I agree it's safer to do the flush in dma_clear_pte() itself, I wonder how much of a performance impact does this have. It might be not relevant, in which case I would certainly be fine with placing the flush in dma_clear_pte(). > > (I won't separately reply to the similar topic on patch 18.) > > Oh, one more (formal / minor) aspect: Changing when to (not) flush > would also invalidate Kevin's R-b which I've got already for both > this and the later, similarly affected patch. OK, so let's go with this for now. I don't have further comments: Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri May 27 10:21:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 10:21:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337906.562607 (Exim 4.92) (envelope-from ) id 1nuX5f-0000XD-K4; Fri, 27 May 2022 10:21:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337906.562607; Fri, 27 May 2022 10:21:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuX5f-0000X6-HI; Fri, 27 May 2022 10:21:07 +0000 Received: by outflank-mailman (input) for mailman id 337906; Fri, 27 May 2022 10:21:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuX5e-0000X0-90 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 10:21:06 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5412e50-dda6-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 12:21:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4DC8A1F936; Fri, 27 May 2022 10:21:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3F7213A84; Fri, 27 May 2022 10:21:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TScpNgymkGLIagAAMHmgww (envelope-from ); Fri, 27 May 2022 10:21:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5412e50-dda6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653646861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xAM3Ec0PKi3Ngq/xxr1XceNguttOrlHFme46602QGLY=; b=YsbUSIhDUXjWsYbpBNMVvCyZukqf8EvB0zvuQ4yH+d7GjCleieDYelNA2cGP0F//99s+Ue ToJ6FTLSJ6VFOkq4EfPNrmAKWkNgVS027oCLQFUyL7simZTXq/XJz9Po5YWhud2gVobnVm 4zcqgJ+yoLudnYatHInVTsfIpHwYYFw= Message-ID: <520d410e-7e71-971e-d21b-2c6dba20cd54@suse.com> Date: Fri, 27 May 2022 12:21:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp() Content-Language: en-US To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: jbeulich@suse.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-2-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220503132207.17234-2-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MkRkfbgkkUf00fAmq0kPBdET" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MkRkfbgkkUf00fAmq0kPBdET Content-Type: multipart/mixed; boundary="------------yEQlXVLdARc0U5tAjrkATLvX"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: jbeulich@suse.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Message-ID: <520d410e-7e71-971e-d21b-2c6dba20cd54@suse.com> Subject: Re: [PATCH 1/2] x86/pat: fix x86_has_pat_wp() References: <20220503132207.17234-1-jgross@suse.com> <20220503132207.17234-2-jgross@suse.com> In-Reply-To: <20220503132207.17234-2-jgross@suse.com> --------------yEQlXVLdARc0U5tAjrkATLvX Content-Type: multipart/mixed; boundary="------------TQoYAv19500hJH39vxNvHQJG" --------------TQoYAv19500hJH39vxNvHQJG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 UGluZz8NCg0KT24gMDMuMDUuMjIgMTU6MjIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IHg4 Nl9oYXNfcGF0X3dwKCkgaXMgdXNpbmcgYSB3cm9uZyB0ZXN0LCBhcyBpdCByZWxpZXMgb24g dGhlIG5vcm1hbA0KPiBQQVQgY29uZmlndXJhdGlvbiB1c2VkIGJ5IHRoZSBrZXJuZWwuIElu IGNhc2UgdGhlIFBBVCBNU1IgaGFzIGJlZW4NCj4gc2V0dXAgYnkgYW5vdGhlciBlbnRpdHkg KGUuZy4gQklPUyBvciBYZW4gaHlwZXJ2aXNvcikgaXQgbWlnaHQgcmV0dXJuDQo+IGZhbHNl IGV2ZW4gaWYgdGhlIFBBVCBjb25maWd1cmF0aW9uIGlzIGFsbG93aW5nIFdQIG1hcHBpbmdz Lg0KPiANCj4gRml4ZXM6IDFmNmY2NTVlMDFhZCAoIng4Ni9tbTogQWRkIGEgeDg2X2hhc19w YXRfd3AoKSBoZWxwZXIiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv c3NAc3VzZS5jb20+DQo+IC0tLQ0KPiAgIGFyY2gveDg2L21tL2luaXQuYyB8IDMgKystDQo+ ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiAN Cj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L21tL2luaXQuYyBiL2FyY2gveDg2L21tL2luaXQu Yw0KPiBpbmRleCBkOGNmY2UyMjEyNzUuLjcxZTE4MmViY2VkMyAxMDA2NDQNCj4gLS0tIGEv YXJjaC94ODYvbW0vaW5pdC5jDQo+ICsrKyBiL2FyY2gveDg2L21tL2luaXQuYw0KPiBAQCAt ODAsNyArODAsOCBAQCBzdGF0aWMgdWludDhfdCBfX3B0ZTJjYWNoZW1vZGVfdGJsWzhdID0g ew0KPiAgIC8qIENoZWNrIHRoYXQgdGhlIHdyaXRlLXByb3RlY3QgUEFUIGVudHJ5IGlzIHNl dCBmb3Igd3JpdGUtcHJvdGVjdCAqLw0KPiAgIGJvb2wgeDg2X2hhc19wYXRfd3Aodm9pZCkN Cj4gICB7DQo+IC0JcmV0dXJuIF9fcHRlMmNhY2hlbW9kZV90YmxbX1BBR0VfQ0FDSEVfTU9E RV9XUF0gPT0gX1BBR0VfQ0FDSEVfTU9ERV9XUDsNCj4gKwlyZXR1cm4gX19wdGUyY2FjaGVt b2RlX3RibFtfX2NhY2hlbW9kZTJwdGVfdGJsW19QQUdFX0NBQ0hFX01PREVfV1BdXSA9PQ0K PiArCSAgICAgICBfUEFHRV9DQUNIRV9NT0RFX1dQOw0KPiAgIH0NCj4gICANCj4gICBlbnVt IHBhZ2VfY2FjaGVfbW9kZSBwZ3Byb3QyY2FjaGVtb2RlKHBncHJvdF90IHBncHJvdCkNCg0K --------------TQoYAv19500hJH39vxNvHQJG Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TQoYAv19500hJH39vxNvHQJG-- --------------yEQlXVLdARc0U5tAjrkATLvX-- --------------MkRkfbgkkUf00fAmq0kPBdET Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKQpgwFAwAAAAAACgkQsN6d1ii/Ey+f pgf+O+x9fAmzNw6KOMEcBnXM36W9TO48WOHg93MQ/X/sOJRjoFGE5FO6HlhjSRagWLRi8pY2WBqm JuyvszHZSzBmyq683HgFmz6x+2GuXQM9AO39NFHILOe8MgaW1BcKxi/sjgtMHT6El/A/0NNRtheA LtDuZKaLgU/Sny0wCpXn/1VvBkXwcXTg6X0SG+1qWyUhbL9rzl6rfLDP5HjlbBEg6zmDiwfWb4rs pr1NYDeUeQcXMUlfn6B7CTx4zJO7+dS5ufmITV5oeFH6pzd0rpr/lYHu/tpfhWOEYa0sM3Zskhg+ /BxBPHiBPiU5jKQWIwPGnXKcWl5kG8zrPJqU3/Fpkg== =p1bd -----END PGP SIGNATURE----- --------------MkRkfbgkkUf00fAmq0kPBdET-- From xen-devel-bounces@lists.xenproject.org Fri May 27 10:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 10:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337914.562618 (Exim 4.92) (envelope-from ) id 1nuXLU-000276-2M; Fri, 27 May 2022 10:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337914.562618; Fri, 27 May 2022 10:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXLT-00026z-Vi; Fri, 27 May 2022 10:37:27 +0000 Received: by outflank-mailman (input) for mailman id 337914; Fri, 27 May 2022 10:37:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXLR-00026t-Ng for xen-devel@lists.xenproject.org; Fri, 27 May 2022 10:37:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe9b9cac-dda8-11ec-837f-e5687231ffcc; Fri, 27 May 2022 12:37:24 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37-Pi2FyFHRORK2MLdp7yIvMA-1; Fri, 27 May 2022 12:37:22 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7241.eurprd04.prod.outlook.com (2603:10a6:102:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 10:37:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 10:37:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe9b9cac-dda8-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653647843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8+5igBLA9ZoMo2HNVasHs47ydOx4rNXZyhVpZWkZAM4=; b=KRgyD/YmmdwKQQtPhgF/EILbrL+0ruTNOll3vDT3PbwaT6WLs/rRy4S/U4omMciRZWfpfp 8iujP5MWYE40pwVbfEI1WUfywVTs0rBEkB6Gvfzrk7lkcnL78E7FuPqQZyMNL0QDcR/4UA bjh+vkG9hUqEpWgAmAsxk4cjc4uQW4U= X-MC-Unique: Pi2FyFHRORK2MLdp7yIvMA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=na8FeBdEJWBJhR5bfiTxgFfGrmLoMD2fsJMFuTtPKn7S+vG9FlOfeLU6Q6QLFZfWHb9O0daiftmBYc+rBdoF5fmVHovpoJOoCRGU9KI/he4CyuXXKvbswEccgvdGvJY6EO5F2JTC4sPv/+XnBYYMJs8BB8kmintYm7CaLujlhXN/3mT/8uRHQB64uTKkqiODDqreWT3dIhAU3u6HYn0looQ/umyvDDOdjmkM8JAPevAIagD8d+nge55pneHIzKDW9Wcc7hppp6AbkiGfh37gY5unz6hl6S0bMF7Dk9U7zzoFKIOphpqdiptpVgKtCqRwInmbG6yEzrcyQ58/iRv1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8+5igBLA9ZoMo2HNVasHs47ydOx4rNXZyhVpZWkZAM4=; b=HmjESJPIIvf+lPw7Wuy0f8BjEfPBs1f/vDKtB5sMIITheQAap8t6n1n4p9jLmN05M06RS7yXL0Sm/6nRVYbLei38Nl1TaKLIpLIwijYjsIzROyERr2ddazNQfWwNYvi7kThR04/gi0+8mSz7INgc80nAs0fn1ZHPKPBVEMVbnYVZTNf3wBV5bv3Pk+s4J0yOyNwyKTDK13m5nScTiBUBJNnY18ajkWOf/iuZ4tt6D1eCasvKN4Qn+3lXqsSYT1iTpIx+Qlnr4a1tqmnHJyMDk9ikRyYz+a4NIgE85Fry8WYZjsj21raZTk14MEe2FGabSfwIND9pO6wZ6Zs0wLOyGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52090c8d-fa21-6f53-c33b-776c12338f62@suse.com> Date: Fri, 27 May 2022 12:37:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper From: Jan Beulich Subject: [PATCH] IOMMU/x86: work around bogus gcc12 warning in hvm_gsi_eoi() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f831479-cbe5-41b1-334f-08da3fcce11b X-MS-TrafficTypeDiagnostic: PR3PR04MB7241:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oZru3mudzt5GPMd/07mUMW70CNsGAXHAHGdIP7bgHXQyoeJF7nWr7tr9tHzN4xIZ5++IOaKI6/1O+9/mf0lvd3AQkzI6K1rHqcmNHV+5ruerajZSwq9SXz4odBdaBbGr0U3Fx2IxYkTKzdzrj4dBSaHZCJWYhf3w2VYzhnh6w+V5MFp51Jbsyf4YjFlEagceSH8hvuW2OObCAamR6ekROGRLGRK26xccj1TnPZLxc4gQJ+AaLU3MK3D5qu/UEyn+1r6DP9Ysp2I6TiyvGCPe1O9Qf7mwafzrXb/eFUHhKyGYB+sSsVg6ACgoufVNxI6d8PZMj2t/lnZzls8M0QhJL3Wxb3bACZQmjGofCK+I14JhIL05EFxx2hhnTvEj//ajVe+w537WrJ8qqZPiuA3NGlgCPus1v8Itn/lucLKtVKDSKX/JyP53pTwOZoRNHVpbb9l0GEQM4Js0+bX/ji1phaFXmxIVJss3NnM8FqS8gdB3L1fBedine6HFOg87KJ+hhoZ0EtZBslQOa9P4xNh4blOpOZQUNmi23tnzC31tgnJOVlR1LpPu70XYfKYUIgxh5HXy9kYoUxemgj90CkKvAmHet3km5wpCuETos063eoDzHXH9HKkmpsdfTYpSZJ30qPXvcq6ZhkXbKS57FzYYuirbVdilpWf4M2LHQijot3A+h5YEGppRwtqmGCmZnuyPJhYTw1iUcnavsiUp1C9VffDgBXrBmXbnrEmH3t9ZZmwJpScYHpOdCrZ+lvSTXR4zilSBlmtFvO++y5Eaj+ZaUkYdcUaL/pykm6XkXyJgE9ptsnrQR6Wd1+pyOkz5/K8XAXK1gMYVO2AdG4HUapSFGnP/IqeZ62S4Ju38eAmRQsH6QiJtoRr/YkdEEvYMaPS3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(966005)(316002)(54906003)(508600001)(6916009)(36756003)(4326008)(6486002)(66476007)(66946007)(66556008)(38100700002)(8936002)(6506007)(26005)(6512007)(83380400001)(31686004)(2616005)(86362001)(31696002)(186003)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2s5dnoya0ZTaWVXKzhlZm9oMEg0anBPVFRaNXNiNEtQQlR5bXh0NnVSVHpR?= =?utf-8?B?SnQvRGRTdDRhSlMyR1c5MnlJRk53ZnRWSG9OdDlSTHVObXFWN2dwQ1dWdElF?= =?utf-8?B?RHZmcXNUQlNTSHlrOGZnRlV3SnRwV2dqRk5IMEZkMFJzaVdpdkR4eWNIb3hO?= =?utf-8?B?ZE5qSVQvRmFuZDBjaVl3L1lWVHBydjdiVFZTaDh4Z2R3a3Frd21QbThFR0pX?= =?utf-8?B?aTJZeGYzSE54MGtDU3NKWE12YWovc2hBT3dYTWJUd1NDZEJ3OXB5MVArcnhJ?= =?utf-8?B?VldwMmtIenY4TW43UDJwK29WUjBrd2FBc3d4Mm4vVnJ4dFlKcXhTUktHelVJ?= =?utf-8?B?d2hSd1EvdFVVV2dhcHVMMFVKN1ZxeGQ3UE52WU1WUm55Tjc0UFJ5ZWVzODNQ?= =?utf-8?B?NERsM1Ixc1BxbjdQRnRKWSs5TEd6b2x3UFZKOHVrbnpKd0JQbEY1bkw2dEpK?= =?utf-8?B?NmhWUnRUR2k3enhlN0xEVU9wMkpnbSt6Z1RwVnpRNnRleFU5MDdHcUYxYVJK?= =?utf-8?B?ZTVtVFdqUjFyYWVlUWZEd0hDS3dueHdHRGdXK1BoTDZsRjJvb09ocDJLQ0ZH?= =?utf-8?B?cmlOa1g3Zi9IQWUrbmlOK3NHQjZCYnhzUy9IOXlEam9CcDNzQkYyMUZnNDFI?= =?utf-8?B?SVRwOVVaY0xid0V2c1lxNWZiWlB0UWZCcmdnTEowSXh0TGZyV1FlcHYvMFcz?= =?utf-8?B?L1BTa2JnU1BxWCt4akYwRnhNcnNPaHBYZEEyM0R3WFUrTzlBYnRXMGRVR2o1?= =?utf-8?B?eitUL1BWZEZWM3hiR256K3pJSkNncVRIS1kxeU5vcDRRVTZYeVVkODVVUC9k?= =?utf-8?B?WTRQR2kxQ3JPVXhadEw4OFk0SDlsMWpuWGs0dnI2N1ZUSXphanJFcmdyZlVh?= =?utf-8?B?aElaVm5HaHRaTzNZMzhhdnVGakk5S0MxY253V05EZ0d1NTZzaEU5Y1hwdGM1?= =?utf-8?B?MW9hR05mTnQ2Smc5cldIVGNZayttektDN1pVZzQ0dkNDUVFHakx4UkhMSXpP?= =?utf-8?B?OWV1MXJ6TWxVZUpBU292Ymc4M1ViTmNGcmdrNFRTNFJTVkpUaE10UlBNclZn?= =?utf-8?B?Mk8wT0pmTHE4bWk0Y01sSmFQMVRJZXYyWWF6QXE1M1p1NWhNb2JlcnVWZm81?= =?utf-8?B?bEFFK1lSQnRid1BRc0xIemlhUjJ2MUJQTEQwTDMrTjJVeVYrdlhzbWdTNDdu?= =?utf-8?B?Y2JRakZWSkI4RWJpczJUV1VkS3BtU0R1TlNOcEZCZmlQQlM2dGNTRnlKVnkz?= =?utf-8?B?cEZOYW1XaElzbW1tc2NlaFhIR2M1ck5pWVpZbDRBVHVVWXdkaWJzK0V0ZGc2?= =?utf-8?B?bGhKci9TUkhkcHdxS1VkcHRXb2FOSzVMWTZpUUM4NSt3blRma2ljVnY3dTdQ?= =?utf-8?B?MzZNSjA0SjJzUmtPTWZTbE50dVBWd1NkQWNsYkdGNmxDRW05NGUwZEtJNnNV?= =?utf-8?B?ZGdvb1hObFJhREk5VDVNNVFFbmFNVHJBQ3NjOXpHRlJCNDdIWDREc2NacW9t?= =?utf-8?B?cFFoUW1udWNJSVFtNlNLVE9mWGc2VGNoZEFLTjJZZ1dsK3NlN21zYlFnRUt3?= =?utf-8?B?TWVEaXBJalpIelBxYjdEUnUxSmFsb00zQURoeElSNTZvT2dUWGNhcXlwbEx6?= =?utf-8?B?bk84V254MEwrelMvVGlySXNzWC9tNnE2NExTaFQyTVVrRmV5S3FpY29MTzk1?= =?utf-8?B?N0tRTlVXOEZMM09yaVFIL2s2MjBma3VIdTdyWXB1NlNEN1d1TVpoZ0d0STBr?= =?utf-8?B?c3VGK3ZNNXA5NVhOV3UzYllGb094ejRTVzQrbTNLY1RnYWtQdnlmTlRjNzJp?= =?utf-8?B?MTNwRzlOenMvZ3BiWWZYZFB2N1h1RC9CaDRVUXNhZVBRUFRUN01VUk1adGRn?= =?utf-8?B?STBrSUNVYWxnMUh0UkE4NVVEUFowS3hFc1hjdnIvRFVPMnJNOEJra0JWeHZl?= =?utf-8?B?YTluVERLVjVicmFtNnBlNkc2dXM2MnZaOXY2MHV5aDgxdWNlZkM5VTE1YTVF?= =?utf-8?B?QkVYS0dzZHM1alNnY29oc1UyZHFnZ3Y3c0dRQURqTEFvd3Vqc1RIV25MYm8x?= =?utf-8?B?ZVlXTUJQMUljREYwL3JhVE1CNG54RnZtcnVSQ28xSE1GUE9MdlZmZDIxZ3hX?= =?utf-8?B?ZmdQbkp0eDZod3FIREU1c2Y0cVFMRnQxc3dJcDcrcDQ4MTlNTURURlNOa1Vj?= =?utf-8?B?VGxFRWhIMzhnS21BTG9OVGhtWHFoZjE0Vmh1bnFvQ2VzMFNwNGEwQ29uR2JT?= =?utf-8?B?bSttUENOS21HTXNnd3Q0aVpKbThVT0FVSDZDc25mbXVmZzdiblFjWTQ2Q3Q0?= =?utf-8?B?bFQzMTBBZTRuQUFPRmtBWnJHOTA1N0wrMVhNdWhzK3dpa1dMeVBXdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f831479-cbe5-41b1-334f-08da3fcce11b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 10:37:21.0599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A0n04QOmjtWDpeAQayXM1cuXKC/SUcA8DmnLYmhg2DNLcq++4BNoIY+HoSzuljQBv2g+A8K7rhETEhimkKmKtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7241 As per [1] the expansion of the pirq_dpci() macro causes a -Waddress controlled warning (enabled implicitly in our builds, if not by default) tying the middle part of the involved conditional expression to the surrounding boolean context. Work around this by introducing a local inline function in the affected source file. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102967 --- This is intended to replace an earlier patch by Andrew [2], open-coding and then simplifying the macro in the one problematic place. Note that, with pirq_dpci() presently used solely in the one file being changed here, we could in principle also remove the #define and use just an inline(?) function in this file. But then the macro would need reinstating as soon as a use elsewhere would become necessary. As to the inline - I think it's warranted here, but it goes against our general policy of using inline only in header files. Hence I'd be okay to drop it to avoid controversy. [2] https://lists.xen.org/archives/html/xen-devel/2021-10/msg01635.html --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -25,6 +25,18 @@ #include #include +/* + * Gcc12 takes issue with pirq_dpci() being used in boolean context (see gcc + * bug 102967). While we can't replace the macro definition in the header by an + * inline function, we can do so here. + */ +static inline struct hvm_pirq_dpci *_pirq_dpci(struct pirq *pirq) +{ + return pirq_dpci(pirq); +} +#undef pirq_dpci +#define pirq_dpci(pirq) _pirq_dpci(pirq) + static DEFINE_PER_CPU(struct list_head, dpci_list); /* From xen-devel-bounces@lists.xenproject.org Fri May 27 10:55:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 10:55:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337923.562629 (Exim 4.92) (envelope-from ) id 1nuXd1-0004ZS-PS; Fri, 27 May 2022 10:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337923.562629; Fri, 27 May 2022 10:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXd1-0004ZL-LZ; Fri, 27 May 2022 10:55:35 +0000 Received: by outflank-mailman (input) for mailman id 337923; Fri, 27 May 2022 10:55:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXd1-0004ZB-32; Fri, 27 May 2022 10:55:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXd0-00087o-Vv; Fri, 27 May 2022 10:55:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXd0-0004el-Kw; Fri, 27 May 2022 10:55:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuXd0-0003pO-KT; Fri, 27 May 2022 10:55:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0nCdeBauvf0ATZibfcNqAhdOOGja/PNUWUlDrHt9L5k=; b=Bo4ZHcHTBAtwPWHttj59/X5eX6 oCuJQ7ijOobmQQ1iYN9L66LCIn1eV/A2Zy7R9d/e/vj21h3LfqtnxhNftaWLpYj9pH2JzdmC3/9I/ 4Xrkyd8CPfOsAlDGKK/NS1uZFJnl6M1JcsLU2Pgw0qTu7oDjUTwNLMMB6Eolt8WDNCvM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170751: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Fri, 27 May 2022 10:55:34 +0000 flight 170751 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170751/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 170747 pass in 170751 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 170747 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170747 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170747 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170747 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170747 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170747 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170747 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170747 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170747 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170747 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170747 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170747 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170747 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170747 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170751 2022-05-27 01:54:24 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri May 27 11:11:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:11:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337933.562640 (Exim 4.92) (envelope-from ) id 1nuXrz-0006u8-4h; Fri, 27 May 2022 11:11:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337933.562640; Fri, 27 May 2022 11:11:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXrz-0006u1-1X; Fri, 27 May 2022 11:11:03 +0000 Received: by outflank-mailman (input) for mailman id 337933; Fri, 27 May 2022 11:11:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXrx-0006tv-FF for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:11:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b06d8856-ddad-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:11:00 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-9-gl5RAaT1Np2diHjYQyAzWg-1; Fri, 27 May 2022 13:10:58 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:10:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b06d8856-ddad-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653649860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kRgdUu7r+CGdFGvK45sc/1oPVXgC4QLEIO84+JJ5ybI=; b=gNgDEdaM6iV6bWzCuF44Bv/mOjs+hF2dgLaiKVZVWkMWP4RYaC/31lb5+mRjXOKZCKyI4q 6fHx0bOdbVrne29A5xRGAFXR0r9PdFOC75sJyI3R8G0pYhED+T87vO6TWUyExcks4lS8w6 D1uTJMZjl4QhgfXg3ySsqSrFZCLN29g= X-MC-Unique: gl5RAaT1Np2diHjYQyAzWg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWlNZfREXEmi14NSCMcyhBnjjbWBlDZa9m+768rUJTHxNa8/L0k1YXzwxFZ+NROdUfluqIk8zSWFKUF7EuD2icAHq4/9Y+9vCX2tGdwOkZQQtFOfnKXVWcTHpvJq9IyF7LMH7QtBZIB/uU9QP7TMIAquxL2WSIn2ccCYSGcdXXbeNMgexbJV/L9C2h20w6X56+hqRotiW9FtSHBhW02W7ccgpsFg/6x+tvGMF8w2dvbw7rNMhEQjVLx60tXLIwx6fXdSvZVoDn9pB/D+iFvuR6ZiooJyyAWIPy6DtjB28/SWGbg9XJMdDCd124mMQBAER7adstEAOf/ctCR2Ovs2Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRgdUu7r+CGdFGvK45sc/1oPVXgC4QLEIO84+JJ5ybI=; b=eNcrXuDPXTRNvEmGFdH6EsXX8VD5Jp9EQq5PUINBOL9rOvvpfUAjvw4MxbSttLPfHStUh9FnhhDd1L2OfjRUcwYDwVCUc2gFJcTMEsrJdVW12OACLuhqHkzqMObKetDPGheeSVUmt+er3LSGEKqwhCxvKsB83a7m5Jg+7XFQnbuo1DxiqKo8G1IKEK31Ogj89hRTjZpkyRp7l6ZiVq+niQ1onyzC7qrJP3FBiCJryxwtCGS6Nf0nwYxbygXHsH00gC4xat9fNoBPjFLMdvBQPdVLrvFC3JgAutaeBCGg+GG4xULTCuX2+lB+FYP+MaQHpL9sQCf26h15EpxVEgSZgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Date: Fri, 27 May 2022 13:10:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Jan Beulich Subject: [PATCH v5 00/15] IOMMU: superpage support when not sharing pagetables To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0065.eurprd04.prod.outlook.com (2603:10a6:20b:48b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fa3e2f9-8a84-4678-c7e5-08da3fd19324 X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9jzH2C+1sL14wOrwxOGoGtp27cPNSDvjDENXbCB/K6GpGBdcKKUMweKMik6zUziw5GFCERQcbkqsYjU/NIgemh1vx+ePpOdZQ9Byy6bw2RZ0lK1nthTwGFBGtsWYWZFngVocTygaiU0nY/E9RE2qc7sLMkxKJyC55t98ESoTsFrMyPL49pN8/mBWLWDL5L8xKadXY+apYGSr7rilRv81OwiJ4pd/Alm7b4yNSgfBxBmFDST4kRryOmUTK3WqoKpZFubRItwTIl3dMVzaeVDCaSwJMsJTgloShMsqRDqQLVKOdZV/X+JQvKOwQu4vUYI4kh+o0xxM8Dt8jT3iQ6qhlv7GRlTiQ9ERmoBwu1ru5mSwb+L9TVSc9Hoy6Nu34iOGDQa5O1IQ5hUsVY+wPCze+JlAWCViUpwv9u93E7Ti8vfcE5O7x4j3dDaQqTwL6MbqzvL1LjY2ZM5MUIxbEmeZVcAxSge0DGA4TfrIlPHagsnltG7INyL3b8mMX9dRf6O0YoPfjegdoF8m304SxiZeyz8f5QStBt5FiAwxTJ8Nwi6Ab/VvCdoK++oqWcshKMUBeM+wPA4s0R+YGzpnZYDxfrJ2z7pv8hr3t+xycf/d2yVcY4arNu4HdFyLbE3Xo14QlQkoR5zsbDZ23Y1ZKwmWpj8MRcjPAqg3yBpqSQOiMzePX88I3C6ca4HoANVLBbXWa7nnvxxS9QSesud8I/ySq200iTS8q9GKKGSK5z9NKZrXywDCwBbc2ElukmC/if6Ifj6Vczhyj19vSNMnsCVaAlGCyaKKKEO+ynFNazA0RnC/X+jBltdH2qUnIl95yxU9/3/WKvFih8NnRkQTf2dm2g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(966005)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjAvTEFyd3QweUd3NzFRN1Fzb2lOMG04VFl2cjZMOUtMd0cwd3JTS08wVE5T?= =?utf-8?B?bVdFVDNUT2U1T2RsM3VsVHBZdXI0Q0tsZTJtYTM4ZFVSWXJiVXNNMTd4TG4r?= =?utf-8?B?TmpDOG4yWVRwOEpBOUtTZENiRzB5bXpQaHJ6Z2JEQ1BFVVQ2TGZDTHdQQ2k4?= =?utf-8?B?cUxRbmlmUGFkSnhMUWpoRjBobGtLaExuZ01LcmNhZURvM1FMSEJqYTFSRlpn?= =?utf-8?B?emRzbVVwV2JnUDRDUnJ2RnFWRGVXZVd2dlM3ZElld0ZMZFkyaHhWVmJSZTlj?= =?utf-8?B?MHF1Zzh3Y1hhSXVaVmgyMzcwU2ExYnJrcjRoaUhWU2tTRCsxM29lbklIN0d6?= =?utf-8?B?MnhkdFZYbngxVWNzU216UGFZSWFlemJBblZOWWNZd3haU2NiNFhiaEhyUGly?= =?utf-8?B?MTV0dm54ZDBFMGE0YW4vbDhjbFRnVVhNSS9VMUZDWUpYQXlCMlpSYVNKMytx?= =?utf-8?B?QnhOT2RJVFljUDRZWjR3OXd3UjhSNFJKbUFFSDZRUVZXSVNOa3MrcFBLMFhy?= =?utf-8?B?RkdQZFM1VmtqbHNMaUYzdnVOU3hTZVkvTFRCdDNJUDM2SENXSnV4eXI4UTdK?= =?utf-8?B?elRCcjFRYTlyK3NEeldObXA0OWU5bGd2V1RKU3JsYzIwNVVuK2Z0bUhUalQ0?= =?utf-8?B?Smt5MGtmdXlEa1ZScnFBYXd5N0hCc2RuemhHRExFMEVRZVQ0cjZSZE1BQXRL?= =?utf-8?B?c1RBalE0T290V1RUYlB3dGZjRzJ2RkVvS0JrZ1pnVis1MmowaDAwN2ZCcmF5?= =?utf-8?B?ZkFOM0NCSUlUd1dkS2dONGxydU5heVhBclBhL2h5c2lMVU5TYWcyWmozdjUr?= =?utf-8?B?ckgvcXVpczg1V1Fydm9JVlZsTUxUUzZiV3BaTVUrM2V1R1E5bHAwZTQ0TmYv?= =?utf-8?B?TGlVSVA3OW1TQmFFaTJBVHRNZzJZOU0vdks4aUR4SDNndUN5bXBTUVdsL3dE?= =?utf-8?B?N3BwcE8zOVBrckpCdEszNWpqWnVnZFpwZGVqWTNtS3pzZUpaaU5XM2RvWEg2?= =?utf-8?B?UHJteHBYZzZhbEgvUFRYS2JtQjJRckw0T0o1R1Ntb1NuR3FNWUNjSjd0d3VL?= =?utf-8?B?MElwdWt3VmpDN3VLSGF4T2Jodnhjd0ptNW5PaGRtYTJhRFlubnFFdTJNOU4y?= =?utf-8?B?SmVkN3BseDR3NitQZzFsRE5GeEtYR0lIOEpLOVpkY01GVVlZVUtMZDI3WHoy?= =?utf-8?B?bmRjcUpNVWNpcWRNYk9iQXRNNUVFSjBaVGpXZi9xSlNGUVBoUXFjREdsYndk?= =?utf-8?B?dFBqRHduQllVOWhDVi9LTHlZRHlCWXMySlNWalhWMk1XaWk0WWdsUnB2WmlV?= =?utf-8?B?WDdQZXdiTDU4Q2tDL0JSdmxWbGZWbU1DMVBxSC9tY2Uwek5jQzloQm8vend6?= =?utf-8?B?M2NHUEJCU0Z6OGhMRlY1NkRMS05uQ3hxS1oraE02QkVjcnBXVHkyclRYdEov?= =?utf-8?B?R091NXg1S0VYbjQ5ZW9SY1pTOXFleVJWd3FlbU1uNEZtYVhsMEk5dDEzYUhG?= =?utf-8?B?VFV3RzAzcGFpaFdhSmhBdnRRVTFLNmQ4NVN3TzZqQ1dyRTArOGRKaWlKSVVS?= =?utf-8?B?VWpZRWxPYjBEbGV3ekJpMnp4L1JnNkZqSFN0U1pIYTBIZWRIeHYxUStITG85?= =?utf-8?B?VjBMQ1BsMFFSaVVzNCszWFp1TTROdWR2VnlpRUpoTWJ3YW8ybHBEQUtVaFZ4?= =?utf-8?B?dDhjRkthU1p0M3BvVWR4RlhKOGxEUTR1T2I4VGNBRkZjUWhPSzUydFRtazgr?= =?utf-8?B?L0FkdDB1LzNJODVrSjBhOE5vZHBQRUVUeHljTVMxamVZalhEUVJuRFR6ODEw?= =?utf-8?B?MnNBVEZ6b2FONFpDSlVMQmNRbDRoOTMvK3V0VHNNaFYwYVRHVXRKSDJsaEhG?= =?utf-8?B?bzFCK0d2Tml5TTVkemgrTjVVZlRlOG1mVzVLU1d0M0ZEdktMZWM2Qis1ajA3?= =?utf-8?B?U1dHa01sQVFTSDRWWGhVUzluci9mOWI0U2NMeGQzbVU1VVpYenRjZEJDNlkz?= =?utf-8?B?TEE0MEdGVVdzWVEvclJxbFQySkpqRTVWMGN2WmRUbHpFVWlTbVcrRURwN0tv?= =?utf-8?B?ZjRuS1l5UzBZdGFZTUM5Nk5SQmNCaEplbytSaXkzWit3RHNyeFg2OHQ2Rng1?= =?utf-8?B?T1RJWjNYS2FOejNvb01zZWY2bVVqS0tRcnIyMC9hQVNaclVTTFk1WWpSRU9k?= =?utf-8?B?bnRjdUdCNkY0RUwxZ3RQb25UenZSQWpEVDg5MytKampGV3kwMHZYVGowTlc5?= =?utf-8?B?UjQyTE8vcXRSWGt2ZUN6WDdqQXNXYjl2ckpod1ExeTlTQ2R6V0Q0R1Z6SFBU?= =?utf-8?B?eDMrTWhNUmYwL0ovK01Pbklmbk9qcDYxdFV5cjVBUWFpNFh0bmFzQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa3e2f9-8a84-4678-c7e5-08da3fd19324 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:10:57.7597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4UifLCFnepMQ4LBorh0lmcPF2aT7xf0ScsMZj+oevi7TZyg/NULjpM/Lz5vimH3fbhp3XVfh7irMLUgkMNrQQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 For a long time we've been rather inefficient with IOMMU page table management when not sharing page tables, i.e. in particular for PV (and further specifically also for PV Dom0) and AMD (where nowadays we never share page tables). While up to about 3.5 years ago AMD code had logic to un-shatter page mappings, that logic was ripped out for being buggy (XSA-275 plus follow-on). This series enables use of large pages in AMD and Intel (VT-d) code; Arm is presently not in need of any enabling as pagetables are always shared there. It also augments PV Dom0 creation with suitable explicit IOMMU mapping calls to facilitate use of large pages there. Depending on the amount of memory handed to Dom0 this improves booting time (latency until Dom0 actually starts) quite a bit; subsequent shattering of some of the large pages may of course consume some of the saved time. Known fallout has been spelled out here: https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html I'm inclined to say "of course" there are also a few seemingly unrelated changes included here, which I just came to consider necessary or at least desirable (in part for having been in need of adjustment for a long time) along the way. See individual patches for details on the v5 changes. 01: IOMMU/x86: restrict IO-APIC mappings for PV Dom0 02: IOMMU/x86: perform PV Dom0 mappings in batches 03: IOMMU/x86: support freeing of pagetables 04: AMD/IOMMU: allow use of superpage mappings 05: VT-d: allow use of superpage mappings 06: IOMMU: fold flush-all hook into "flush one" 07: x86: introduce helper for recording degree of contiguity in page tables 08: IOMMU/x86: prefill newly allocate page tables 09: AMD/IOMMU: free all-empty page tables 10: VT-d: free all-empty page tables 11: AMD/IOMMU: replace all-contiguous page tables by superpage mappings 12: VT-d: replace all-contiguous page tables by superpage mappings 13: IOMMU/x86: add perf counters for page table splitting / coalescing 14: VT-d: fold iommu_flush_iotlb{,_pages}() 15: VT-d: fold dma_pte_clear_one() into its only caller While not directly related (except that making this mode work properly here was a fair part of the overall work), at this occasion I'd also like to renew my proposal to make "iommu=dom0-strict" the default going forward. It already is not only the default, but the only possible mode for PVH Dom0. Jan From xen-devel-bounces@lists.xenproject.org Fri May 27 11:12:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:12:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337942.562650 (Exim 4.92) (envelope-from ) id 1nuXt7-0007XK-L0; Fri, 27 May 2022 11:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337942.562650; Fri, 27 May 2022 11:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXt7-0007XD-Hm; Fri, 27 May 2022 11:12:13 +0000 Received: by outflank-mailman (input) for mailman id 337942; Fri, 27 May 2022 11:12:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXt5-0006tv-El for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:12:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da520db6-ddad-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:12:10 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-eiF3JyVZPQa2T0-rr7aKNA-1; Fri, 27 May 2022 13:12:09 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:12:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:12:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da520db6-ddad-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653649930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9E1G4wR+PqEH6Q/fpL7fSV+Z1/ahzOqCt4WvVVI8szc=; b=XrTJi1g73F3wZ3FuE34P/wvSEDVxbew+cTrHk3SNizB2G+3vfzAjVIJU6HDSFsBolptW07 ueCy8WNR9UfzvYOhB72bphMiQQcDk70wNAzke+bBd6NotIzzEL6Dg7pWbr5llS7pw4UOrn 1eQPlRnUZax0rHnznrypiM+gB1rTkcw= X-MC-Unique: eiF3JyVZPQa2T0-rr7aKNA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z9/u5YLxd2PRcf4XKD/GEcir5aRLl5iNzJcFJcEHc/G7JkowlSLwcTQFtEjxU6VZUsIm2u73wqvWCxQNoVDQgCr0zo0XLZq1xmw3+rqp+pDcvvS5O32SjCpzT4AnGGOCq/59xZE7Zc2/E7JGnTgdK2abZg9T2yBr7OYX0mwjnoGhs4YiWCcMTBt6e+UNOTQ7TlRzuDCSuJIraIqRNkQ0jTVn7HtRnVahA8nBE6DT74lPowk21s6FTNtE3LH0RUygZ0kk6GlPPIC1Gxbr6XfBXp56y7wDTaP7q5wZUqa2xmqhIyn71vCcafOehWXpnTWsJSRki/dK1mdKWxOw9A0tQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9E1G4wR+PqEH6Q/fpL7fSV+Z1/ahzOqCt4WvVVI8szc=; b=Lk8OLdLx3u0XAiYVHV/uwp+4R4ZL31IJtUMA6zaqhsnB9hhaodQJ1blw3AlzVK5FSutjS4gxFh4BHp5By9pwDpUbqdMHcts9CapBM/jUP+RiTUfHA1cnqJOBKFcrin3P8Pq/Rc3MyCmag08h1oBlcwYCFiTyKUnA99Dzm2gYxn+/BY33qZyyYFGAHOjt1uPXiDQmOe6CVk/svoC7OD6anTWMPRsJT57B7uNk0f/2+UEyj8JAOKHiz5hnaI6oHQlwRrS1G5fMTA1Pmyjv0Ac77KPqEd0+drcYqDQQ8jxy4gRGCGZdhim9gu4jKS6OoEkRTQididf3Lv3DOFiTttvUlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1de2cc0a-e89c-6be9-9d6e-a10219f6f9aa@suse.com> Date: Fri, 27 May 2022 13:12:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 01/15] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0005.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9446ce4b-94c1-4d15-1622-08da3fd1bd14 X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4JnqS3xQm+MpDtJwOEXOotAtiA1CfGoRlxKEGfIcvTHRVg2xbd3rm9eJUg4D5RIj/2mAdMmFRtpItWdACjbjXBm66xHsKpJYgDOpUZHJDAQOpmqhcos3qnfqs+dxzr9o6xbQrIOigymw7EEKa7uMffgxfUkkVLcTQdr8hQCRED5OYLZeR1ElxVL6qzffTEXTdWqlStu1SRxfEZaoc4kZ7V9CkDzfwOx3dhxqzTk6J4J5GQs8YE46e4qcEtygWMbmFJeAf+X10K+L4555Ex6DTM/cekCjdAJkn38fqhYK57+3rWu2+KUYf2QWA1XPTiXE5i+b13nBWWhmBy1/Qs9Ve4YTlYEr/9RvR8sESUo+F8z39nGgqcmOqKvmcYX+XEh8BzIjyj9W8YMak2MBkPezvu/rpvcQA8gRunqoOSVua/LNUe8RZR3vhbMKYVUBMoSnpe8wPnqkD0A1C0g4HaStBgr2iso/rubCMy+KH2+H97S8ldCIrSMxV2yxFRPLRaD+cZrAy+MZ67OT/udhEGx4Kdn5BEEWNrS6Xz+XbcIRUtzM4bazI891YXgnhW8kD3oMWgXxQofznOHHWJ/qu+tfeKy7L+5WCaco/uwZvivtz9BvU1eY4JVBCPgYEuJTsYmC6IcPpOYiD2CCjQtaFGssjONxkUrTYwf5H09uZMvDlBwFodxtmI2KothtJHmB6xmytvd3+a1KbMectfJZ6RUfE0dInFuHfxhjERMt0aaEHFk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWNkbVFYbXY4UTN3cWZoYVkrQ2h0RlVkdS85bUZOY2VIbVZYK1VIMzU1ZFVN?= =?utf-8?B?UXYzYU4rbEhueXdFSVdkdXdqbHhJNVM0aWpjbDNnc3FXNGpnLy9oVVhjQ2Nz?= =?utf-8?B?MGdaS1N1anY5Mm9wNHBNTlgxaTloMFB5ZS9qekRVWm5KMTBQOFlvd2tqTHVl?= =?utf-8?B?cExzV1FzckI1cVlIczdaWTR2S1JXNVlwbHloWXR4MlZVVk1oSEQxcDFKeU8y?= =?utf-8?B?Tzc3TTNYOXZCcWlXV25odUhRbmRmZ1JXM3htL0t0Z25MVlJPQlljak04WVJ1?= =?utf-8?B?VktTMjVjalJlMHZHcm5iRjhaQVU3eXhlNFVBS1NNTTdtc3NaMkdEc0thZEhW?= =?utf-8?B?NVNZZ240QVJHZ2RibHBsT2RFeGFCcW1FS2M3WkV4ajg5clQ5T1VxbnFCMWVk?= =?utf-8?B?dWpaQVVTN0c3dWlJdVJwaGFrLzRhTlBTVXhodnJrVkxXS2xPUklIUFcwMnNY?= =?utf-8?B?MFJURUcybUJEY0IrTjVzb3ArTzJ1MmgvbjdLZy94TE5uUzAvcGRyMmRQQTNV?= =?utf-8?B?QUpDZ0VpNktwOW83Z3BNazJ6cE1IdmdkbTBGQUN1VE1yU0YxRjRPUGpSbEUr?= =?utf-8?B?TVU5NWZ2MmNOZlNLTVQzYk9kU1ZkTHNCY1Y5dlRQak5tS1JGSVdkUzNJZXNs?= =?utf-8?B?VnR2NDQyUEd2RzFMTGs2ZE5jZzJFU0hNc1ljeHo3NFh2R0JycjNielBJTThx?= =?utf-8?B?T1pJUTY2clljZXYyVk9McVJ2OVZLNWUrblpxNk1aNWlaY21MYk5Wa0tJQTk4?= =?utf-8?B?c2haL3hSOHdaM29STzNKWWpJT1c1enloblBxclBUdnRNaVdpZzVzYjgyV040?= =?utf-8?B?Y1d6emlzaFNQQ3ZselZiMDVVL1dsTlFnZXRUVDUxdWgxQXZscVk0SGtpdzRU?= =?utf-8?B?eVA0aVljU3h4S2hMeEFqL1NqSC9sVDlsaFV1OTlKdk5acGdzK1R5VGxtVVl3?= =?utf-8?B?dTgwTlIwRTd3R1ZobnBaZEZtTGFMK0V1R2FkczVyNlRQT3BJYWNmVGJMVnMx?= =?utf-8?B?QzJxRGhJQXBsdFZCbUxiVlBZTU5IS1IwMVhkYVJlc1M5Y0sraGdBZWFDMHlv?= =?utf-8?B?RE5CRTBLbUdRdUplMWkxMDBqNEo1QVdQVzcvRzZsNm9FaGsra2ZkRDVGVSti?= =?utf-8?B?QUUzVHcvM3hEb0xSOFRGb0JPUWQrL1RiQzdRNGVPT2N0ZGdSZDBVMjJYZmRn?= =?utf-8?B?SjVZS0pTdnNBK1FIdVZ0Q2dHOWwwOStCRjFUemdob0haVVJ6NTFDcHJ6MVlH?= =?utf-8?B?RlV0eHNZL2Uwb2FUekVERUJmUjNSODdiKzRkRnlYMmRwQml6SnZaUkNUalJP?= =?utf-8?B?NkpvVGs1WG9oMDVSRTJ5VHdXMkllbkNLL0djRzhSUXJUc01QeWptMkNtdmlC?= =?utf-8?B?R3p6bkVNQjYzeFJxWWJteHJKZnF4ZEhCejEvMHNMbXFIUkRKbjQwZExNbGVP?= =?utf-8?B?VWM0QWlKVGVkaFgvdHVsQWdobFQ1VEp1WnE1aTZTRTdhejdGTFcxSzU2WmRM?= =?utf-8?B?TEMzVWUya1BNVlI1eWZiSkRydmxNSFVJSXArZWd2MFFsWEdjQUVOS1pacWdG?= =?utf-8?B?V3hOWEhWdTNEQ3lVRDdoanEyNEYwaGtFdkt0c0RTM3dGeG43QkVVYUlBQTVS?= =?utf-8?B?aGdHQ3ZTVmJqanF6UXB3R2d0Tnl2RVVERzBEMUtUelkrRVk3WU84aTJZSWJT?= =?utf-8?B?dXR3SE1udno4L21zMlFxT2hEcWFXaUh0WE0reTlSVVhlWVZwR0FzUWZtK3hY?= =?utf-8?B?Q2RJQTRRN081dk1XOU9wZ2RBNjQ2ZCtFM0xScGRqb3F5WWluU2EyWlJhMVVC?= =?utf-8?B?Rlc2LzhTWGxIV2s4dEJHTHMvRTgxSzlUVm9tUXhUNnNlMDBncnBwM1pLb0My?= =?utf-8?B?emxSdll1eGVEK3kzMUJCM1owVW1BYlpUaDhTNkZ4dVozVFpXcHlxWlBIYjBD?= =?utf-8?B?Nm1zK1NzSEZtSXJGSkhFb1pvbUhWdSttcVRFTzlEL0FZTkJhWWZ1bHVzRjVr?= =?utf-8?B?R0xRTXg4WnYyak5MSGdNbHJsZUYzeU1LVDRXMnlITHNGbmJUY0VNZUdWOEFN?= =?utf-8?B?a1FMVWM5UHZVcHJERkVFK2tINzB6bURPYWRHNWwxUlpnbXNSVDlYUmRyODlW?= =?utf-8?B?YTE2ZzAySGMxdC9rMXBybTFHSXcwYkZxVUpSL1BmTlFucUhhRlVpTlVpNzFq?= =?utf-8?B?UUVHVWNLeS9jN1Y2bWVBUW16WXhDcDBPNXdkWmVNU1J0Y0FQVTllbHlQZHNL?= =?utf-8?B?UGRlNW5wUUtmOU91M2tFTUdLSi92dzJHakllcjBPZk5YbHQwNXdQSVYyZVFC?= =?utf-8?B?RjYyOXpPUUF4VExPMkRaTzY0dXVSbjRSNk5ra3d3N28yRng5YW0ydz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9446ce4b-94c1-4d15-1622-08da3fd1bd14 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:12:08.0833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5x0Juf9oxVOlfdbMv15/uHfN4vdP92LPP9inOqf8PIn55yS3LsZxzVLIh59tNaC3MB9wB41L1DZfbs3S+a1zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 While already the case for PVH, there's no reason to treat PV differently here, though of course the addresses get taken from another source in this case. Except that, to match CPU side mappings, by default we permit r/o ones. This then also means we now deal consistently with IO-APICs whose MMIO is or is not covered by E820 reserved regions. Signed-off-by: Jan Beulich --- v5: Extend to also cover e.g. HPET, which in turn means explicitly excluding PCI MMCFG ranges. [integrated] v1: Integrate into series. [standalone] v2: Keep IOMMU mappings in sync with CPU ones. --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -13,6 +13,7 @@ */ #include +#include #include #include #include @@ -275,12 +276,12 @@ void iommu_identity_map_teardown(struct } } -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, - unsigned long pfn, - unsigned long max_pfn) +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d, + unsigned long pfn, + unsigned long max_pfn) { mfn_t mfn = _mfn(pfn); - unsigned int i, type; + unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable; /* * Set up 1:1 mapping for dom0. Default to include only conventional RAM @@ -289,44 +290,75 @@ static bool __hwdom_init hwdom_iommu_map * that fall in unusable ranges for PV Dom0. */ if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) - return false; + return 0; switch ( type = page_get_ram_type(mfn) ) { case RAM_TYPE_UNUSABLE: - return false; + return 0; case RAM_TYPE_CONVENTIONAL: if ( iommu_hwdom_strict ) - return false; + return 0; break; default: if ( type & RAM_TYPE_RESERVED ) { if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) - return false; + perms = 0; } - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) - return false; + else if ( is_hvm_domain(d) ) + return 0; + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) + perms = 0; } /* Check that it doesn't overlap with the Interrupt Address Range. */ if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) - return false; + return 0; /* ... or the IO-APIC */ - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) - return false; + if ( has_vioapic(d) ) + { + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) + return 0; + } + else if ( is_pv_domain(d) ) + { + /* + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o + * ones there (also for e.g. HPET in certain cases), so it should also + * have such established for IOMMUs. + */ + if ( iomem_access_permitted(d, pfn, pfn) && + rangeset_contains_singleton(mmio_ro_ranges, pfn) ) + perms = IOMMUF_readable; + } /* * ... or the PCIe MCFG regions. * TODO: runtime added MMCFG regions are not checked to make sure they * don't overlap with already mapped regions, thus preventing trapping. */ if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) ) - return false; + return 0; + else if ( is_pv_domain(d) ) + { + /* + * Don't extend consistency with CPU mappings to PCI MMCFG regions. + * These shouldn't be accessed via DMA by devices. + */ + const struct acpi_mcfg_allocation *cfg = pci_mmcfg_config; + + for ( i = 0; i < pci_mmcfg_config_num; ++i, ++cfg ) + if ( pfn >= PFN_DOWN(cfg->address) + PCI_BDF(cfg->start_bus_number, + 0, 0) && + pfn <= PFN_DOWN(cfg->address) + PCI_BDF(cfg->end_bus_number, + ~0, ~0)) + return 0; + } - return true; + return perms; } void __hwdom_init arch_iommu_hwdom_init(struct domain *d) @@ -368,15 +400,19 @@ void __hwdom_init arch_iommu_hwdom_init( for ( ; i < top; i++ ) { unsigned long pfn = pdx_to_pfn(i); + unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); int rc; - if ( !hwdom_iommu_map(d, pfn, max_pfn) ) + if ( !perms ) rc = 0; else if ( paging_mode_translate(d) ) - rc = p2m_add_identity_entry(d, pfn, p2m_access_rw, 0); + rc = p2m_add_identity_entry(d, pfn, + perms & IOMMUF_writable ? p2m_access_rw + : p2m_access_r, + 0); else rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, - IOMMUF_readable | IOMMUF_writable, &flush_flags); + perms, &flush_flags); if ( rc ) printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n", From xen-devel-bounces@lists.xenproject.org Fri May 27 11:12:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:12:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337948.562662 (Exim 4.92) (envelope-from ) id 1nuXtl-000847-VX; Fri, 27 May 2022 11:12:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337948.562662; Fri, 27 May 2022 11:12:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXtl-00083z-Rm; Fri, 27 May 2022 11:12:53 +0000 Received: by outflank-mailman (input) for mailman id 337948; Fri, 27 May 2022 11:12:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXtl-0007su-6L for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:12:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2fff49c-ddad-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:12:52 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-v_-qEy5CNiC5Ki2ODG4WqQ-1; Fri, 27 May 2022 13:12:50 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:12:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:12:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2fff49c-ddad-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653649971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jci9rQkWPMy6ohkXdrpyJreaPBMSTK/7GbgkwVczOus=; b=Lr6j5J+MkNnIirJwHFN6STnhsN2vx9SLW9NjvONB89vv455tn39Yu2FhidoRf7xcPaxi9o 4VDmaF06GH/7SHxqdCr+1vfRKgGdRohZEuHmFwGtxEFj+zPXAFoRacb43EVzIml0hjXvEK Lpbue+IIaOxzBiDggbkxZHg2HMGkwQs= X-MC-Unique: v_-qEy5CNiC5Ki2ODG4WqQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AO7suNExYLdn6OVAfJjW7iPGd+a0KkFG3dQ+/mDCuKlS6uo7X7leS6ruKeU4n5XgzWhkvgaaqQH44IEM2Nq9dE3istpTYl58c3TdG4AZDC0UpzhyQ/x79OzKUEIv00Fm4B7ZHNaHr3kSHQ+Geq9i3TW6TMpW9bXRScfd3oeDOE/ElRqYP0sKzQb7DVHKnEeJkuun+LBWZt0soKRZp2mH6ZV9cdT5AFPnMuRQ8lBKVE89zGJVrzlFpLr1PtBMYrnqXzQ/qgnguWN4PlSt7XhIbS8NWE5eqtJn44ph7K/nW0P7hCFDjAan/wgK5fpeKARvdvjZVvLFUa6EwOMhnLSPQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jci9rQkWPMy6ohkXdrpyJreaPBMSTK/7GbgkwVczOus=; b=YrHYl5pIpRlY0AI6mCjJZG+NDJ+0EaYI9WyAB0t+7kvMwyxEX3ZiIqr3IYFKOt5KfUKakRwysdgaiEEUF4WwgrHQDLL308RCHiSkbyIc42OAe64x5UOM5zTw69GWZQpLQj7h2Q43+p9KEDo/GiIQGYOxTIFHEUQSw8T3h6cjzE7NXtqi2AUHqMjC8TWJ1s6VUK/DWO8t+lxV1addpBZ1Y0g/L1uyJO45CwVR/fuSd+ZTt0umg+m/yWe+jXTTbJO5uJ97fCjBnZsbBWBWlPdOD8UPkm6JpgUDbu4HLPV20CRiAbWq7sJkZUYyeWAmXzvKJx2VZeFXGwV0OuzfFQPuig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <67fd1ed1-4a62-c014-51c0-f547e33fb427@suse.com> Date: Fri, 27 May 2022 13:12:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 02/15] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0003.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eabe028b-169d-4df5-8973-08da3fd1d5e5 X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MRW8tla3aMYvXRm9dgtv4TCjdZInXqGokV+Cmh+Aigcq6M9Sy9fX8E+R+zyoPWNz8/Ssr2a+hCvtiTNiSNd/HLRlzRAafWpwfacWti74dI027NG25V/OC6NoYFKehz0qYfFM0PbG/CI7Xlx6wi5A0zY6RIJIBaw+BuVm2MmWC6fbPCvGE62065jretALuvCcEIYBwhQqfGn2x+/aKjV+i53xJoEBF75JG8NdyJ6pzjGXiVuMEmUSIHXS/qIdqvklZ/sY58gAAaQ/JdrAb2KhqPijFrg0MTxI2pEeTRaUh8m/oYa+VOTr5BBmsKG5bXW+YhM9wx6sad/bDxoDvV6MxCSdE1dyczqQQJmfiMbRwr6v/ln5ktaEEqWBm4sZz/GQ/wkiUNtTUjjuUHQ/TS1f2x3cIEYNwfieAl4YLbMXvnPkSgOUdnFrUBTZd+HSI/eO31hozOI7ToyJcj2+6Gx/la/Hetg0B6gX/fzuU5vd2H7TkbxL/5mbknt2JnmvzpnLYEZtnnR28wrEHkG3zCr6XIKcTugJLU+jvk6XCylf3UDvFvZN6GYCW90pR2SVfaXyoKIlUNhMitMR15mbDmgt/jbNJGZ5GYdv4EcT7omOyrltVwEhjHKskFqiUlaYJYdsn7cJMmMfKa6IwW11pCG9rbazVpLLs62gVzmWf4tdFLmYp8Dt8Htf/jjutb8bX0OZVqrByX8VmYunQxqNkMaBAgO12XYfZIYisapgu5QZT6XVfnucCHlac0z8b9pkkUzu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(30864003)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWlqSU1qQVVaY3IvT2hVNVJZdlUrWTV3eENxZXFEUWdNeXlKaE5jUFJ3dHFT?= =?utf-8?B?UGl4bVlXUmQzMEkvNkFJaU9PRjNqdFZJOWthVHBGRnBoVCtHTTJiQTRqd3ZF?= =?utf-8?B?UXRaM0dsNElJUlYxbmlkS0xweHF0YjZrSEtLcFUyM2NrZ1lveW9iTEpNbW5X?= =?utf-8?B?VE9KYkJmQUowbDBlWmFpQVRlMksvRngwZVVZN09UY3BsT1k2c3phSVhpaXFD?= =?utf-8?B?TG9GSktnT1FEWUcwekwvWE5GTU8wMnE3TzEwMGhCcUZ1Z2RwMUY1VlNJQ3Mw?= =?utf-8?B?alMrWGtjQmFsV3pvZTF6K0FwNGlyOWQ2OUhoblIwcGRaTTBRb3RZcXNHaWtU?= =?utf-8?B?bDI4Q3ZVRjBLSlFCcytqS3Nialg2WGJlTzRaeGlrTW5TR3NWQ3BPbEVLQnBG?= =?utf-8?B?cnBiMGdIT1l0UG0yNjk3N08xcmh6RE5vZklScGRhS2dFS0VybnlDWlI0K25u?= =?utf-8?B?eU5xTExnMm9IVjdXK1V5dmJPajhjR0tTNjMvUjhXeFlBeWt0M0l5anNSbkxL?= =?utf-8?B?Q0xWLy84ZXJjQjdRNmZSdFE4cmdFN0dZV0ZzMzVPRml0a00xc0xJVk9iUEV5?= =?utf-8?B?WjhmYm9RVGFmV25MUVZGWU0ydzVxTU1Dc3VGVTcyZFVkd3lRZDQrMkU2VUVu?= =?utf-8?B?cTBJWnNOSUwrTXZsYmF5T0ZxWExVaStLalZGWlFNRHRuc1QwTXRpMTMxQ0FZ?= =?utf-8?B?bWdaSTUzcyt2ZjlLVWhnOGFzR1lYNlE0ZEFRLzM3ZzQrNk5OOWRYbEJLUHlk?= =?utf-8?B?MXk4aEZKT2Fzb0U1MHYvTmh6SWQycUIzK2R3L1VTbjVWV2xoUXJnWGluNXZG?= =?utf-8?B?M1FVUHFxcjRyKzZ4MGgwVVVFMGdZSVV4SU5oRU9lcWVBMzVicDM2MWFkQW1C?= =?utf-8?B?ajczOVlHZ2g1VXNyWXFzVVYzQnRCL3l6SzZHK0NVREtVZFN5ZmFDNG51Nk1m?= =?utf-8?B?c2ovam1UK0RxcUVielpaUzExRHppTDRnNjk4UkdKNmNQZmpFZGVpNWZJbExu?= =?utf-8?B?T3d0ZjRSenpQS3YxdFU1WUQ5ZGtsSXVEalQrbHBLOHZvVjJSY0FleU95RFh4?= =?utf-8?B?cndzM0JLd09vOEZzNDRGZHhjZnZHcWE2b0hXaUx6Y2N2cENZRUVzWUdQTits?= =?utf-8?B?M0gxbHZCV2huT3VTUng5eTI5MjhXSFgwTnBVVk9tT2R1TWFEWmhsMStCZERa?= =?utf-8?B?N25lbCs2S1Q3Y2VEYmVnWVhITFZ2dDlVeG16TW0vL1M3KzFFc2hWYzAvMVBv?= =?utf-8?B?RTEyTjNGM1BKUXQ2MmFnUW9QMHZJdE1DNngrVmVGaExJTUlleDZ4eTVMWUVn?= =?utf-8?B?c0EyMVEwZ1lNVk9GUVRoek1DcHI0OWRTV0NsNHl6VzI4Z2hIaGUyWFYxNXpT?= =?utf-8?B?V2plT3h6NTkyeC9zMGpzNU5ka2ZCbkpwUjl2M2w5Z21wdUtyMFZzY1pWQVB3?= =?utf-8?B?cXVFbmkzMmF5akE4a3gyLy94Wit6ZlhOUTFQTzFVRGZyaFE1Tytjc3JpckQz?= =?utf-8?B?R3ByVGRqeUttbWlOM2MvWHZKVFJXVjMwTG1UZ3hiaCtyVFRJOXFrNTRNR0ZJ?= =?utf-8?B?aFQ3ZXhmeVpKZHNxZ1p1V1FkSlZkd2ZteE9Nb1hqTDJ3bkkzckxSV2ppOUJs?= =?utf-8?B?WEtzeWpIc25kN3VqQmhhTnM0c1pOSFcrMmpVdzlBVHZXTHZnUlErWVBTb2p1?= =?utf-8?B?cmZOaGdDak1JTTlaeHhUaUJpckt2NnQvNHdrQkFieG01anBKbWNjWE1tYU9J?= =?utf-8?B?N1ErZ1Zyb0psdGtnL3BsY0tyMU5FMVBTNUQyc0MyeWZ6dGczSEYyS2Y2eWFw?= =?utf-8?B?akd4OGdCTE1Ea044S09GcWoyUXFGenp1ZU9hMXJFaE1SbFgzOTVTd2dTWGNU?= =?utf-8?B?N2djcUcxMHVZWitvZzViZk1vYnp6dlliV0xUQXhOR2NPTWVGMk9ZK0pyME5z?= =?utf-8?B?d0pBYnJlTGNqQ0FqR2Nsa2JWSjR0clRERTdSZW11MzEvcmhZeWM5Z255a1BR?= =?utf-8?B?VitLSHBHekhxUEJ5czExcjA3aWtSc1B5NGtrY0JXTkwwR011MlBWellESU1P?= =?utf-8?B?MTYrQm9IVm5xdDkvS0FkREhPVTdORVRia2RlcE1wTXErOG1RT1lLZTlUWkR5?= =?utf-8?B?WDloRnVQWlhnODVzL2gwai94aERDcXRGalp4Qjg4YU1qTi9MTzd1aWo2U3NK?= =?utf-8?B?QUlPcXFSeFg0T2VBaWRhWGw4ZWo4ZVZqRXh4ZEdLRE50QnA5QkJZWnNXcGhk?= =?utf-8?B?aHZBRnZvNWpEbU5melFkelpiWUhGWnkrNkdCcUxFdU9QeWlVWUhzRG1zVytk?= =?utf-8?B?dUlkS3FiWTFydCtlRzBkN2k0bWVFS21jWUFZWVo0Q2xFckNHaFNSUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eabe028b-169d-4df5-8973-08da3fd1d5e5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:12:49.7057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cU3QR5Goi97FAvExfwXPCDTPTaeKAXVbcB9SO7MLINsSe6K5PuO82TE8ohB5ck+xnKcyDeasgarLfZ0ZZlHrQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 For large page mappings to be easily usable (i.e. in particular without un-shattering of smaller page mappings) and for mapping operations to then also be more efficient, pass batches of Dom0 memory to iommu_map(). In dom0_construct_pv() and its helpers (covering strict mode) this additionally requires establishing the type of those pages (albeit with zero type references). The earlier establishing of PGT_writable_page | PGT_validated requires the existing places where this gets done (through get_page_and_type()) to be updated: For pages which actually have a mapping, the type refcount needs to be 1. There is actually a related bug that gets fixed here as a side effect: Typically the last L1 table would get marked as such only after get_page_and_type(..., PGT_writable_page). While this is fine as far as refcounting goes, the page did remain mapped in the IOMMU in this case (when "iommu=dom0-strict"). Signed-off-by: Jan Beulich --- Subsequently p2m_add_identity_entry() may want to also gain an order parameter, for arch_iommu_hwdom_init() to use. While this only affects non-RAM regions, systems typically have 2-16Mb of reserved space immediately below 4Gb, which hence could be mapped more efficiently. Eventually we may want to overhaul this logic to use a rangeset based approach instead, punching holes into originally uniformly large-page- mapped regions. Doing so right here would first and foremost be yet more of a change. The installing of zero-ref writable types has in fact shown (observed while putting together the change) that despite the intention by the XSA-288 changes (affecting DomU-s only) for Dom0 a number of sufficiently ordinary pages (at the very least initrd and P2M ones as well as pages that are part of the initial allocation but not part of the initial mapping) still have been starting out as PGT_none, meaning that they would have gained IOMMU mappings only the first time these pages would get mapped writably. Consequently an open question is whether iommu_memory_setup() should set the pages to PGT_writable_page independent of need_iommu_pt_sync(). I didn't think I need to address the bug mentioned in the description in a separate (prereq) patch, but if others disagree I could certainly break out that part (needing to first use iommu_legacy_unmap() then). Note that 4k P2M pages don't get (pre-)mapped in setup_pv_physmap(): They'll end up mapped via the later get_page_and_type(). As to the way these refs get installed: I've chosen to avoid the more expensive {get,put}_page_and_type(), favoring to put in place the intended type directly. I guess I could be convinced to avoid this bypassing of the actual logic; I merely think it's unnecessarily expensive. Note also that strictly speaking the iommu_iotlb_flush_all() here (as well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be needed: Actual hooking up (AMD) or enabling of translation (VT-d) occurs only afterwards anyway, so nothing can have made it into TLBs just yet. --- v3: Fold iommu_map() into (the now renamed) iommu_memory_setup(). Move iommu_unmap() into mark_pv_pt_pages_rdonly(). Adjust (split) log message in arch_iommu_hwdom_init(). --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -46,7 +46,8 @@ void __init dom0_update_physmap(bool com static __init void mark_pv_pt_pages_rdonly(struct domain *d, l4_pgentry_t *l4start, unsigned long vpt_start, - unsigned long nr_pt_pages) + unsigned long nr_pt_pages, + unsigned int *flush_flags) { unsigned long count; struct page_info *page; @@ -71,6 +72,14 @@ static __init void mark_pv_pt_pages_rdon ASSERT((page->u.inuse.type_info & PGT_type_mask) <= PGT_root_page_table); ASSERT(!(page->u.inuse.type_info & ~(PGT_type_mask | PGT_pae_xen_l2))); + /* + * Page table pages need to be removed from the IOMMU again in case + * iommu_memory_setup() ended up mapping them. + */ + if ( need_iommu_pt_sync(d) && + iommu_unmap(d, _dfn(mfn_x(page_to_mfn(page))), 1, flush_flags) ) + BUG(); + /* Read-only mapping + PGC_allocated + page-table page. */ page->count_info = PGC_allocated | 3; page->u.inuse.type_info |= PGT_validated | 1; @@ -107,11 +116,43 @@ static __init void mark_pv_pt_pages_rdon unmap_domain_page(pl3e); } +static void __init iommu_memory_setup(struct domain *d, const char *what, + struct page_info *page, unsigned long nr, + unsigned int *flush_flags) +{ + int rc; + mfn_t mfn = page_to_mfn(page); + + if ( !need_iommu_pt_sync(d) ) + return; + + rc = iommu_map(d, _dfn(mfn_x(mfn)), mfn, nr, + IOMMUF_readable | IOMMUF_writable, flush_flags); + if ( rc ) + { + printk(XENLOG_ERR "pre-mapping %s MFN [%lx,%lx) into IOMMU failed: %d\n", + what, mfn_x(mfn), mfn_x(mfn) + nr, rc); + return; + } + + /* + * For successfully established IOMMU mappings the type of the page(s) + * needs to match (for _get_page_type() to unmap upon type change). Set + * the page(s) to writable with no type ref. + */ + for ( ; nr--; ++page ) + { + ASSERT(!page->u.inuse.type_info); + page->u.inuse.type_info = PGT_writable_page | PGT_validated; + } +} + static __init void setup_pv_physmap(struct domain *d, unsigned long pgtbl_pfn, unsigned long v_start, unsigned long v_end, unsigned long vphysmap_start, unsigned long vphysmap_end, - unsigned long nr_pages) + unsigned long nr_pages, + unsigned int *flush_flags) { struct page_info *page = NULL; l4_pgentry_t *pl4e, *l4start = map_domain_page(_mfn(pgtbl_pfn)); @@ -177,6 +218,10 @@ static __init void setup_pv_physmap(stru L3_PAGETABLE_SHIFT - PAGE_SHIFT, MEMF_no_scrub)) != NULL ) { + iommu_memory_setup(d, "P2M 1G", page, + SUPERPAGE_PAGES * SUPERPAGE_PAGES, + flush_flags); + *pl3e = l3e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE); vphysmap_start += 1UL << L3_PAGETABLE_SHIFT; continue; @@ -203,6 +248,9 @@ static __init void setup_pv_physmap(stru L2_PAGETABLE_SHIFT - PAGE_SHIFT, MEMF_no_scrub)) != NULL ) { + iommu_memory_setup(d, "P2M 2M", page, SUPERPAGE_PAGES, + flush_flags); + *pl2e = l2e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE); vphysmap_start += 1UL << L2_PAGETABLE_SHIFT; continue; @@ -311,6 +359,7 @@ int __init dom0_construct_pv(struct doma unsigned long initrd_pfn = -1, initrd_mfn = 0; unsigned long count; struct page_info *page = NULL; + unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; void *image_base = bootstrap_map(image); @@ -573,6 +622,9 @@ int __init dom0_construct_pv(struct doma BUG(); } initrd->mod_end = 0; + + iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)), + PFN_UP(initrd_len), &flush_flags); } printk("PHYSICAL MEMORY ARRANGEMENT:\n" @@ -606,6 +658,13 @@ int __init dom0_construct_pv(struct doma process_pending_softirqs(); + /* + * Map the full range here and then punch holes for page tables + * alongside marking them as such in mark_pv_pt_pages_rdonly(). + */ + iommu_memory_setup(d, "init-alloc", mfn_to_page(_mfn(alloc_spfn)), + alloc_epfn - alloc_spfn, &flush_flags); + mpt_alloc = (vpt_start - v_start) + pfn_to_paddr(alloc_spfn); if ( vinitrd_start ) mpt_alloc -= PAGE_ALIGN(initrd_len); @@ -690,7 +749,8 @@ int __init dom0_construct_pv(struct doma l1tab++; page = mfn_to_page(_mfn(mfn)); - if ( !page->u.inuse.type_info && + if ( (!page->u.inuse.type_info || + page->u.inuse.type_info == (PGT_writable_page | PGT_validated)) && !get_page_and_type(page, d, PGT_writable_page) ) BUG(); } @@ -719,7 +779,7 @@ int __init dom0_construct_pv(struct doma } /* Pages that are part of page tables must be read only. */ - mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages); + mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages, &flush_flags); /* Mask all upcalls... */ for ( i = 0; i < XEN_LEGACY_MAX_VCPUS; i++ ) @@ -794,7 +854,7 @@ int __init dom0_construct_pv(struct doma { pfn = pagetable_get_pfn(v->arch.guest_table); setup_pv_physmap(d, pfn, v_start, v_end, vphysmap_start, vphysmap_end, - nr_pages); + nr_pages, &flush_flags); } /* Write the phys->machine and machine->phys table entries. */ @@ -825,7 +885,9 @@ int __init dom0_construct_pv(struct doma if ( get_gpfn_from_mfn(mfn) >= count ) { BUG_ON(compat); - if ( !page->u.inuse.type_info && + if ( (!page->u.inuse.type_info || + page->u.inuse.type_info == (PGT_writable_page | + PGT_validated)) && !get_page_and_type(page, d, PGT_writable_page) ) BUG(); @@ -841,8 +903,12 @@ int __init dom0_construct_pv(struct doma #endif while ( pfn < nr_pages ) { - if ( (page = alloc_chunk(d, nr_pages - domain_tot_pages(d))) == NULL ) + count = domain_tot_pages(d); + if ( (page = alloc_chunk(d, nr_pages - count)) == NULL ) panic("Not enough RAM for DOM0 reservation\n"); + + iommu_memory_setup(d, "chunk", page, domain_tot_pages(d) - count, + &flush_flags); while ( pfn < domain_tot_pages(d) ) { mfn = mfn_x(page_to_mfn(page)); @@ -857,6 +923,10 @@ int __init dom0_construct_pv(struct doma } } + /* Use while() to avoid compiler warning. */ + while ( iommu_iotlb_flush_all(d, flush_flags) ) + break; + if ( initrd_len != 0 ) { si->mod_start = vinitrd_start ?: initrd_pfn; --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -363,8 +363,8 @@ static unsigned int __hwdom_init hwdom_i void __hwdom_init arch_iommu_hwdom_init(struct domain *d) { - unsigned long i, top, max_pfn; - unsigned int flush_flags = 0; + unsigned long i, top, max_pfn, start, count; + unsigned int flush_flags = 0, start_perms = 0; BUG_ON(!is_hardware_domain(d)); @@ -395,9 +395,9 @@ void __hwdom_init arch_iommu_hwdom_init( * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid * setting up potentially conflicting mappings here. */ - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; - for ( ; i < top; i++ ) + for ( i = start, count = 0; i < top; ) { unsigned long pfn = pdx_to_pfn(i); unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); @@ -406,20 +406,41 @@ void __hwdom_init arch_iommu_hwdom_init( if ( !perms ) rc = 0; else if ( paging_mode_translate(d) ) + { rc = p2m_add_identity_entry(d, pfn, perms & IOMMUF_writable ? p2m_access_rw : p2m_access_r, 0); + if ( rc ) + printk(XENLOG_WARNING + "%pd: identity mapping of %lx failed: %d\n", + d, pfn, rc); + } + else if ( pfn != start + count || perms != start_perms ) + { + commit: + rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms, + &flush_flags); + if ( rc ) + printk(XENLOG_WARNING + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n", + d, pfn, pfn + count, rc); + SWAP(start, pfn); + start_perms = perms; + count = 1; + } else - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, - perms, &flush_flags); + { + ++count; + rc = 0; + } - if ( rc ) - printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n", - d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc); - if (!(i & 0xfffff)) + if ( !(++i & 0xfffff) ) process_pending_softirqs(); + + if ( i == top && count ) + goto commit; } /* Use if to avoid compiler warning */ From xen-devel-bounces@lists.xenproject.org Fri May 27 11:13:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:13:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337955.562673 (Exim 4.92) (envelope-from ) id 1nuXu8-0000CD-Ah; Fri, 27 May 2022 11:13:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337955.562673; Fri, 27 May 2022 11:13:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXu8-0000C6-7Y; Fri, 27 May 2022 11:13:16 +0000 Received: by outflank-mailman (input) for mailman id 337955; Fri, 27 May 2022 11:13:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXu6-0007su-Nw for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:13:14 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 000aced3-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:13:13 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2171.outbound.protection.outlook.com [104.47.51.171]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-1QpSct_ePjua-SOYLNkHqw-1; Fri, 27 May 2022 13:13:12 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:13:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:13:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 000aced3-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653649993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwR4uJvcM3qrVCLzIeP2CVCTgiXaow7zHN5BzR104SM=; b=EnhP/dpcHTRxWZiJjF2cuP8Zmu24lizho1YZ86AxI+HVuK31nNlf6GIzcz23UUT7Gi4tlT EOsQV1vkHnZ/3w+THLTBOtOSE8OvidVqkWV7ESeLe2MZ3JGLza6a170/5ZiwkBrD51guNf WyhQOayhA7u3LW5wli4tMZgiWw44Ht4= X-MC-Unique: 1QpSct_ePjua-SOYLNkHqw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UW0aKbEr0PgBv+J3viEw8PVACE+OLI2m8h2Af7C1VD5Tu4gelkB4S+cAMyu0cZuyApgzAVmiMgHsc5WDMpiBhlnKEUcT3BaqZxUqHTr6eFKCUbeYsQ1nTrzI1EhUvuHV2nnd4u/o1YSVlNg9vGxHDAu606347pXR4Mmp/cTUxaxoqaWsyuRssDICp/wj9m+J2lWxtYz3yEffusrwfDFKhEClhe2nIhwgjQ1qD6DzN7lRM0rKOdqEK599UYGKzvIiSh9X++wu3/nPXwWRDCBrfPvUWZws5IEe7FLywrpRsAEluje7xDekwdHTf7ZMBoqlK6OuCvWOtFM2pFHewtVwww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CwR4uJvcM3qrVCLzIeP2CVCTgiXaow7zHN5BzR104SM=; b=V2MbilDINZdogmHtx/isqzIuw8M85hgopi6syu0t61LE9Yc/3iW7QCDdogIs7CjUvFJieiffrbgfISy8+LWKXxkIzvTFol+3dX8WvZHsxQYArbrQJxG7JHZbLBBjaHCz9RMjYPwowVjLUmwHCH3TKNCk4s6GVaGcOCSV1ADLyXIlZABzkjV3fE+kKUtC5fpM52NlkevWtOkrp8RyTv9SO7xCAfqq4bxvUqZsr2BsKoMUhytn5oeKrPfWHWQUJyMxGNpYaJn66CnASFS8k8CwSnH2ixthPSs2Q0wBIPhaiN9eBP/2fhhCvKxHLc6kGLDWQe14K8j3EdORCiB4WuVDaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <614413d8-5043-f0e3-929b-f161fa89bb35@suse.com> Date: Fri, 27 May 2022 13:13:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 03/15] IOMMU/x86: support freeing of pagetables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0089.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 944c75ec-6132-4d5d-9366-08da3fd1e2d2 X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OLQHv9i5XNduo5s2Fnt6mz/HqWTdcpmjzijsEnRg1o728tT+D960uHUCMKXJ0ZDfU3VeU723zRBaxAgmOsUdGKTXedQ2LOm/xb89eFzuJToil++7OqNa++skLbHOwx7pv8uJZVQAwSy7Bh/RMM4ie0H87p+J7ol90xbLE+RDJtxKKrrknI/D1brVzKNVPpvcLaYUTITFqL7oy9yEUQXEDEehQHs+9XYlGfchpZaXiCAixLhHuuWvEVquBCUDdmkoBWLCgpBDdBacM6OCXWjKK4RiJaphHI+8GYntuFDLO8bh2bI0XanPv3hF225xIepN+tIY75VK1WGHk15G6rq5t5/SWPUUsdNzfqNEqOmN2Ka16GDyD3HWTbEwHwGWDjWCFIi3eAK8UPqIuWKMd02+BhKhsUwlrE1LqDvBgB96a/OT5oeMvnFDQLZ6oqmCamB+XGZvgiGqesqdZuGvmcSSuZn5jxUVcgTfYk3d9do2MM0UEBu5Ecweru8n2SpP6N6bfppaPRjWwDVUw4VWejhtyXuv9AV+Vg7UYeiVHgr8egHiS2N3C+PW1DlrNBd2hFdRyNx2jU4lTWx5ymUHepQGb+uDAbY0kCvixa5N/Bl8EgX6WyYnYcipLZtjameHvhEjRNfQBLF2qnrpBPG+hL78h8p9jX2Yu8x+cYlQNDsBznjuRk7wJjoVuOespFkY7S8D20/BUAMXOzUF5GIVewU1IHD414VZs3VG9OsEOnGjuJ18CVGhjE8o8NYNyvcOWtYxCdV4PFARIzqIQj7bA6VvxlGXQQt3C8ofZFP2QfKTZj9+o+mqjcQREymHglO/bAux X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0dZdjk0S3dUeDE2dVlHbEk2VUkvQTlUSU8rNDJaWHpaWVZEcnJxSE1hdmRh?= =?utf-8?B?OHo4ZHVHcEtkWE90cC80ZWc3aldLblp6a1FXUkhwQ2d3dEhmMlFVNTNWNzlU?= =?utf-8?B?RHVNcDRoU1NpTWlTdEdaRlFJMXR6a3hoT0NoZE9CWEQ5R0kxNGFudVNmUUVX?= =?utf-8?B?MDV0SWo3cTJBRXhZWEVTdDFOSmp6dlNETDhWZ3FzRUZ2cE1yY3k5Qnk2Y2Zy?= =?utf-8?B?WnpjR1VFZGRaUDVNVzEyUmFMaFJBV0hZcmdHdzAxWU5zMVBKcmZKNnBoN2Zz?= =?utf-8?B?Z1ZTWEIvVmNPWTFwTnA0WUxCYmtpc241NHkvSVNjM09YYjFZbjdnNit2cCt5?= =?utf-8?B?TmQ4WUVxa3BIT1pOcmN4TzhhcG5mTmxqODVrRGxPMzhiMnFmOS9sZnQwL2lm?= =?utf-8?B?d3ZMRU1UN010WE9aSUdvODZHeDFUTkNSRm9XZCsxbnhuNmZ4QmtNcXl4WkJJ?= =?utf-8?B?YVJ0MEtZajRxRldlaXRkRy8yeU5VOVZDOHhPOWdDYjl4dGNsUnpDeWZUeFN6?= =?utf-8?B?Vkt2SmQ0NFFLcGFnNUhlUnZnK25GbTZSQ1llTGVtSzd6amtQZkZuK1dBak04?= =?utf-8?B?WFBGSWlkcWg2OGZlU1NjeTJjS1VqZnB4c3pKV0MrK3YzcDNPdE5KcTY0d2h1?= =?utf-8?B?LzRKYzRXYzdxYUJxZzZJRHVMMzRTTDdtV2RwT0NUNndrT2dqNmJjZk9MTFMx?= =?utf-8?B?blc4djVSNWNHQXg5ckxLT2t3N0xUWkg1YTJZaUVya2t5QWRTR0R2WGZEZ21k?= =?utf-8?B?cUxyd3NxQU5wMTFzTzhQRlpiR2IzWmRBMnpsSmNYTkZTVjBuSWZrU3NxU29W?= =?utf-8?B?aWVFSWdzVjduWEx3OFBEVkVxZjF0MWJKZmhkaVZ0Nm9yNWorSlY2VTVwWFBk?= =?utf-8?B?bU05OUNaTm4wUmFNcFViUjRDbXRPN3VtVjJlVVJCSTlOalpNSGpKR2RQMitu?= =?utf-8?B?SzFza0YvTUsweC9qamVNZldiVjhQMXBQSmdQSkFRay9GdzB6SHBEZVJzRFN1?= =?utf-8?B?enFxVk9LYnFncnAvdDVQM2htRzA4MHdDSEx6eHl6RkxDVVJScHdldlZMd0ps?= =?utf-8?B?cFBWQXJIWWZrMXRJa3gyNm9pbWp5a0Znc0xkbXBUS291RmlYcnBLU05CcmE0?= =?utf-8?B?U2pXcDYzbTNXTGRZMDJZeVo4NFZWbzhsdm82SEFEK2kyMU9RRkZseFBWTWhM?= =?utf-8?B?NnYxdUl0Z2RnMXdkMlE4aHU4VndpU05VT1cwQldiN0UyTDVqVmtMUUVUUHRB?= =?utf-8?B?UXV2RDJraFBwaXFnK2wrUkpKYVhBZjZ4VEtoZEs5UGsxK1ZOQVliZ2dUWmZv?= =?utf-8?B?QkE2ekF1UlByalVUWXdiSExyN3lnSHFDcCtiMWJob3MyMzVQaG5CbE90SXNa?= =?utf-8?B?ZlNYcElHZDEzcVJKdkdUNW1OWGZwNC9pQXMyb2E3d3hUZHRGSGs1K2IvVWI0?= =?utf-8?B?QStPZmxBeE1zVnNFeG1sYW1GRjAvaGVkT3hGRHFMR1VQM1p2VlZOU2dMbnIz?= =?utf-8?B?aGMxbjFzK2h1VnFva3NSVlFLdS84TEVhSGxyQjZYMHViNnFlMUh1VDYwL0Jm?= =?utf-8?B?TDhQUTN2K0k5QUpQNDhRNmFPT3BLWk1OV2hwOE9MV1Rvc2s5MTZTd3IrOVRM?= =?utf-8?B?bmFlOVdxbk8ySEtWTkNPYkhaWUlKSXlzODNQRjV0a2hQT3JXSG1qOWVYZXB4?= =?utf-8?B?R3NKLzU2VVhlZ2gxSy9xSHhqVG5pTERtZnVHYTFDRHUyVjllNXNzZ1pidmZx?= =?utf-8?B?VnVjNVhLcjBQNzUzSFZJdjR0WU13QTE2YmRPMHNnWWtDdmpFSmVXT3FGdWhp?= =?utf-8?B?SjR5SDYwWmtGMEFoZE9wWmo2Vk1OWG0zbk9hN3Y3THdGblJPVW1aandTY2lv?= =?utf-8?B?bkxkUzl1QWR3OGJOcExVbWt6ekIveHQvZXY0VThiQXJ5SkcrZzNBa1Y2Yjd4?= =?utf-8?B?SmM2czZtWi9ieFRKajFYKzlIT000R25aUEhJaVR4dS9jQnBQZXVsSHR4NFVo?= =?utf-8?B?a2RTSUNkU0RtbGZYTlVXaGIvcC9yeVkxbGdUUWdldVBmM0MwclUzRUd3Unc2?= =?utf-8?B?V0ttTEFXNDkvSmVCTWVyUVhzNWgrN1pHbFpOam43UjdpUEl2Ym5oUVU3Smd0?= =?utf-8?B?NlFaRTlyVVJTY0NtNUM3Tkt2enlkK0xDdWNMS0IzV2MrU3RMelhETDJVMTVs?= =?utf-8?B?N0d3MXF3NFVVN3EzdjgvcGxsVDZvZ0hGd2t0QXJ6V2M5aFl0ZVBxeHNzbWFu?= =?utf-8?B?MXFNZWpmdWpVTjVnd3pmckVFanZrUjZ5cWRob0dFeE5QSW9KSDVrbmV6TEdi?= =?utf-8?B?ZTJjWEdrVnRUWXJuVzRyQzRuYlUvN2F3QTJQT2xTNmZ5aE1BZWNZdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 944c75ec-6132-4d5d-9366-08da3fd1e2d2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:13:11.3918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zzhVvwcenFqUYNbNfQZt8g7UTFQ0+Hlq4+O5A6QWkvXQs8V0/s7aPPH8s7/a3pm3jr+mlOhWtqqJzczjKT/ydQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 For vendor specific code to support superpages we need to be able to deal with a superpage mapping replacing an intermediate page table (or hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is needed to free individual page tables while a domain is still alive. Since the freeing needs to be deferred until after a suitable IOTLB flush was performed, released page tables get queued for processing by a tasklet. Signed-off-by: Jan Beulich --- I was considering whether to use a softirq-tasklet instead. This would have the benefit of avoiding extra scheduling operations, but come with the risk of the freeing happening prematurely because of a process_pending_softirqs() somewhere. --- v5: Fix CPU_UP_PREPARE for BIGMEM. Schedule tasklet in CPU_DOWN_FAILED when list is not empty. Skip all processing in CPU_DEAD when list is empty. v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base. v3: Call process_pending_softirqs() from free_queued_pgtables(). --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns int __must_check iommu_free_pgtables(struct domain *d); struct domain_iommu; struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); #endif /* !__ARCH_X86_IOMMU_H__ */ /* --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -12,6 +12,7 @@ * this program; If not, see . */ +#include #include #include #include @@ -566,6 +567,98 @@ struct page_info *iommu_alloc_pgtable(st return pg; } +/* + * Intermediate page tables which get replaced by large pages may only be + * freed after a suitable IOTLB flush. Hence such pages get queued on a + * per-CPU list, with a per-CPU tasklet processing the list on the assumption + * that the necessary IOTLB flush will have occurred by the time tasklets get + * to run. (List and tasklet being per-CPU has the benefit of accesses not + * requiring any locking.) + */ +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); + +static void free_queued_pgtables(void *arg) +{ + struct page_list_head *list = arg; + struct page_info *pg; + unsigned int done = 0; + + while ( (pg = page_list_remove_head(list)) ) + { + free_domheap_page(pg); + + /* Granularity of checking somewhat arbitrary. */ + if ( !(++done & 0x1ff) ) + process_pending_softirqs(); + } +} + +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg) +{ + unsigned int cpu = smp_processor_id(); + + spin_lock(&hd->arch.pgtables.lock); + page_list_del(pg, &hd->arch.pgtables.list); + spin_unlock(&hd->arch.pgtables.lock); + + page_list_add_tail(pg, &per_cpu(free_pgt_list, cpu)); + + tasklet_schedule(&per_cpu(free_pgt_tasklet, cpu)); +} + +static int cf_check cpu_callback( + struct notifier_block *nfb, unsigned long action, void *hcpu) +{ + unsigned int cpu = (unsigned long)hcpu; + struct page_list_head *list = &per_cpu(free_pgt_list, cpu); + struct tasklet *tasklet = &per_cpu(free_pgt_tasklet, cpu); + + switch ( action ) + { + case CPU_DOWN_PREPARE: + tasklet_kill(tasklet); + break; + + case CPU_DEAD: + if ( !page_list_empty(list) ) + { + page_list_splice(list, &this_cpu(free_pgt_list)); + INIT_PAGE_LIST_HEAD(list); + tasklet_schedule(&this_cpu(free_pgt_tasklet)); + } + break; + + case CPU_UP_PREPARE: + INIT_PAGE_LIST_HEAD(list); + fallthrough; + case CPU_DOWN_FAILED: + tasklet_init(tasklet, free_queued_pgtables, list); + if ( !page_list_empty(list) ) + tasklet_schedule(tasklet); + break; + } + + return NOTIFY_DONE; +} + +static struct notifier_block cpu_nfb = { + .notifier_call = cpu_callback, +}; + +static int __init cf_check bsp_init(void) +{ + if ( iommu_enabled ) + { + cpu_callback(&cpu_nfb, CPU_UP_PREPARE, + (void *)(unsigned long)smp_processor_id()); + register_cpu_notifier(&cpu_nfb); + } + + return 0; +} +presmp_initcall(bsp_init); + bool arch_iommu_use_permitted(const struct domain *d) { /* From xen-devel-bounces@lists.xenproject.org Fri May 27 11:14:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:14:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337963.562684 (Exim 4.92) (envelope-from ) id 1nuXv3-0000ty-Kn; Fri, 27 May 2022 11:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337963.562684; Fri, 27 May 2022 11:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXv3-0000tr-Hh; Fri, 27 May 2022 11:14:13 +0000 Received: by outflank-mailman (input) for mailman id 337963; Fri, 27 May 2022 11:14:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXv2-0008SK-19 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:14:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22274aad-ddae-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:14:11 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-27-fmljMXHfPk-f5mcWokOwhw-1; Fri, 27 May 2022 13:14:09 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:14:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:14:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22274aad-ddae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qr+KZP5Q4gC1/YO9J87FKq30YhywATFS4ksFiE6GDtE=; b=hPSwJ3iYlUtUzgluIMOnZMRrUXfKi/6cNcNmWwUaAjrz83+uGak1X8K5RlXk1jQO5fRSTv /Yt/Zpw9eDmBhkpl0LcTe7mk9teLpGEj6F3P5lhDgDtsrIyAXoT6Zjnz/8dj7n+AvBydT2 oThSMZtoFKdqW0KQgK8bk5yDMF1JIZU= X-MC-Unique: fmljMXHfPk-f5mcWokOwhw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9m7/WYFjm7m5/zAK8CUrPo/Ovs8K7xHl+tCNJC2MfqGmP1LRizO/KsTFBZ/aMyP6tUqM+Ybp6Qf6/LuYZQl6DdEHrYU7gAWmtPy2cTU1L5GoJuTMqZHKj+PpNEdZ9wCBV1C/f38A1y2JICLfd9F/buMPRz7oNm6PgGkzXhTGyYXYSYvukWvlUsgZH1ucCr+L8gU0gHdYYl/3/qTdJsiluiVXnjgvnrElPjGcnUupgz90JghhJRM/iUyMvQMMMbKK7QFV6ougYiCSo/NUgrbx2JsQ+zonQXHFm6R5nXGUu3ebwuek1Wdj5OFrKH2FMrtbceNb9dr2V7Wl17MDqNpTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+qwjWOHPpUCurQ63u+c7grNKTN+vnNpokZN1aH+eg0=; b=SIoCQIN/cCq7IIW2Ga/2B7dfP+O6K2LrNQMGYUvkl0TE9/TuD5Z+q/nrppDuHq/eEhx21myKlabl2grXxBnWRVpiRQ5cwUMpUplqoNI03cgcFUetaCdvfJEU6qKt9tSOYla1EMamFkRkFOOe+W1bFxExCfb00y3R9y1JB1SAi8AGNcSg9vNS0fFySyjd2TNTP708sMyGxFdJN2g9DIMmJ7S8kLbYbOZKkdE1+2J4IzKMO7cws/GTJJ1pWqZ3O7msOrkVIvx8oG42RPwAZFKKDdttK9y+MLiVHiOakUmID4qzJOlrn7t4eS4lw9G4w4Z0ch/4CM5v7qtjzIOTZep/cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <108ae661-147e-c107-c826-1db67e0f0e5b@suse.com> Date: Fri, 27 May 2022 13:14:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 05/15] VT-d: allow use of superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0375.eurprd06.prod.outlook.com (2603:10a6:20b:460::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44ad1ae0-ccc4-47ba-381a-08da3fd204dc X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: APk5CsImZyV4iHiy+CsXo/pqpfwe7q9fK8CN8jydj/aqQeLkkFDKfAE8dkmoStRpFqB3WSD7aIuns4UQjtTW3o0IFdhVodVFqu4OoMLuPBRS06O+GCz35zwgWCjbX403GGA0wx3ugdPlcPYjdNS53J5mDqDQL0y9g21+/0J3cua1FH0yrzannacUlypmItqm9FvGD/li20yoDqnWDymKOJH8wf0taTI2XiWqFRxwK3QrUApOGgaWbBSj5BdLbjrOfpuCXlm8ksBu1431YrwWz7K3tYKXke2XGIJSEd6IPtM5ceNfbv2vet0VraPDmSXzsPwUlBLkA8RBMgQC9ifqLGZUBwimNGydXMgI8xeRK05bIzDQfxjM8Xs9uvHhCbAyNUs1UU607sC0HeOYq3rOahK73wplfj5xBokZb44fPda+gCbXq9l591kgIIcFlFDTUXpte4j6RN+rePi9e9QLyqcOpYOsVeyhjTe9psty6RxMjiPxPngUh1dy/bT/gG0xgknFk2WwhfwyndZoAPfaRVWAe/TYRwqlGOEpnpgTJub09ByRuz+9FR7118M3645pgncEJmQ65wCCzN/f2JAJBct+fe9Y/VW6dAq9NOX9vPLGVZalWBs0fNNNmhwPlBF8gdrZDE/BHxxzVXu7X/NZiS8lKolMXj1OcKoDETSD9Ac3DMB9wSEzzglBg/2ElaVI2ajdBOf97eV3Veo3OA0mQ3isxk6qW2EePz5Be8qunv1xjoDDcidDHT+yWbiWDp6b X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UL6SuA47fxEt9dHrRcLtF7R9Eow6uKVxuEzpV0ULyeUHKY59wjMhLPtEo59n?= =?us-ascii?Q?632xhuDPLs1Wn8Jn2EYEoZKjo42APdCC6JmCehE0morsQHnFM/5n8uJ3KCYm?= =?us-ascii?Q?3xUCjv14yz9WAlEP9z3l6KsUK1BPE0AW1GGjDJrqEkLrhxBDwRtwebS4u3RX?= =?us-ascii?Q?5Nsqp1+pNMXIhKayQ7Z6xkx0CdXoKPENBaehBmFG30my8V3izDjfNutIO2BU?= =?us-ascii?Q?Sn6+unPGhfoAmKgiYicMWys6olOPqfBXJN6lAajp1wgSKnoP96mB6w1DlUDB?= =?us-ascii?Q?0f77nNT/bA0ypaj7r7c868Q4dfTQgNGSkAly/9Po4edzvBiz9f4/+SGULl6o?= =?us-ascii?Q?//CLhXZEZR3BCEVErx7efn6uohI43nJB2o2SV1aC5MrP2TaFlmxU8UEem78i?= =?us-ascii?Q?JwagwUuQA6HlemqB6dR2Nv7lY3LouJVuE7GWevMmjEt0RBnVL+EmoZVoEcgj?= =?us-ascii?Q?ndC3UTLLw5OQ2EvDpatzCXdmQri1PmZkInn6s4HmWeZaPkfZqyuBkZYO6cK/?= =?us-ascii?Q?TjZWbguDHdh94tgo3xuLb/UQxSWikDP94cdV4lH3Ol3N81k5U1bQMhRj9Sva?= =?us-ascii?Q?s7MFHdLynBntHdAjRBCuOcQgjShHw2lQvpNUMjnkxM9E3byFMLKhsmNIln8b?= =?us-ascii?Q?4JytYZTBj5ypPBBhYN+hIuzTX0TGDpOYQU74nfsqAHZWgUwvBwNGQDdqMDcn?= =?us-ascii?Q?Sdx3ZKM/ZTDLegx7vkSEgvtVQFWLRXEXUB70c7Ha38tA2YRsk/ZDmvb2OOKL?= =?us-ascii?Q?Y+/4tEINc/3uguDk9gVeRnnWR+psUE2ZZW34ULVMfNsQ6ORCUK6ZRG0XsLVi?= =?us-ascii?Q?HJiycQEvoza2sM9pdZuKZUyc8KfFyB/gvrCpebT+lbigWJYUc+nwlptwMTaa?= =?us-ascii?Q?JvFgNx00yn3C3aKhkUE2J8IsJTpCQJm3EE9n5lTqlzDEAl1Lvvy4EWBo3OLu?= =?us-ascii?Q?pda2IZCt9G6Et9Q2sx0FyvOUQpfRXgSBDE7tkHOSwLtysHplZq6aXtJkiycD?= =?us-ascii?Q?474vEPAmPe/vUtrDXA9IgLku4JQeTMtzDbRZruh96d6tMKDG06zGxeEI/GE9?= =?us-ascii?Q?QrWUFHUbommxisvtAJK8gV+mK4BjrDvP+0wsNZkJBJvO6aYDMF1HDmUQgoM7?= =?us-ascii?Q?llp7jaw666o/8zAWtr2PXSIX8wDs9Z+GoGkdLmjvmvWQZGTeZNSzPp/+iu6u?= =?us-ascii?Q?OqfABWz4moxKkcI3XhLhHZMBSF8MxH1EzXFeoiDDiQJGjNlLupahjQ04Y+VA?= =?us-ascii?Q?wb2uybHALmSmbykHh4KUuBn1IEFyOmoBv1AL2eyCIHHV+pjWhuyEUu0hDjgo?= =?us-ascii?Q?M7GRCrSSztJ6ylQ5b5ONaiTXLCiKcsv9cfxyjnPWykB9KbB6eJIf8eiN2jKL?= =?us-ascii?Q?qhzKk1Bn/PwrMHvEL+RaePdYBvW9rszX0ftQrmxi+GytrQCo5h89MhaCehO4?= =?us-ascii?Q?35qv0s5ZlwdoNeXug+rcEOhO4E9vaJoEF6TM//6/fEAAYEP8NQ5iDfjtYwNe?= =?us-ascii?Q?+Vv12hSCtTuRkOicglcn67gOlG9nKETZiYZLcrCHPn7IU9UuQjDWjpxHbhbT?= =?us-ascii?Q?A0I1/emsm8WuFWGEUr+D8Fi7bhZEZ8MR6xXLZW/nEE9dqZCxqM3lVivKJ8rI?= =?us-ascii?Q?HFt9d9jwqXahMDBfDP97rN6coj6/Ua6tz2T/tVMsM+38PgCXvT2hkhG7hgky?= =?us-ascii?Q?5ABfaINFF94UW94sDuUhmoyacf9xZwnVnVfKpn3wn5a4oqnqphBSLN0HeMXi?= =?us-ascii?Q?SJ6EfCZ25A=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44ad1ae0-ccc4-47ba-381a-08da3fd204dc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:14:08.5444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4V45kra9gd3xz7dKR++5pMJh1GI2dkk25mYNQpwz9vUq5ZSge1MRyvygP/3vNOIfqGTb4+C0cKB/19mtAWLkFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 ... depending on feature availability (and absence of quirks). Also make the page table dumping function aware of superpages. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monn=C3=A9 --- v5: In intel_iommu_{,un}map_page() assert page order is supported. v4: Change type of queue_free_pt()'s 1st parameter. Re-base. v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks where possible. Tighten assertion. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -784,18 +784,37 @@ static int __must_check cf_check iommu_f return iommu_flush_iotlb(d, INVALID_DFN, 0, 0); } =20 +static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int= level) +{ + if ( level > 1 ) + { + struct dma_pte *pt =3D map_domain_page(mfn); + unsigned int i; + + for ( i =3D 0; i < PTE_NUM; ++i ) + if ( dma_pte_present(pt[i]) && !dma_pte_superpage(pt[i]) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(pt[i])), + level - 1); + + unmap_domain_page(pt); + } + + iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); +} + /* clear one page's page table */ static int dma_pte_clear_one(struct domain *domain, daddr_t addr, unsigned int order, unsigned int *flush_flags) { struct domain_iommu *hd =3D dom_iommu(domain); - struct dma_pte *page =3D NULL, *pte =3D NULL; + struct dma_pte *page =3D NULL, *pte =3D NULL, old; u64 pg_maddr; + unsigned int level =3D (order / LEVEL_STRIDE) + 1; =20 spin_lock(&hd->arch.mapping_lock); - /* get last level pte */ - pg_maddr =3D addr_to_dma_page_maddr(domain, addr, 1, flush_flags, fals= e); + /* get target level pte */ + pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flush_flags, = false); if ( pg_maddr < PAGE_SIZE ) { spin_unlock(&hd->arch.mapping_lock); @@ -803,7 +822,7 @@ static int dma_pte_clear_one(struct doma } =20 page =3D (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte =3D page + address_level_offset(addr, 1); + pte =3D &page[address_level_offset(addr, level)]; =20 if ( !dma_pte_present(*pte) ) { @@ -812,14 +831,20 @@ static int dma_pte_clear_one(struct doma return 0; } =20 + old =3D *pte; dma_clear_pte(*pte); - *flush_flags |=3D IOMMU_FLUSHF_modified; =20 spin_unlock(&hd->arch.mapping_lock); iommu_sync_cache(pte, sizeof(struct dma_pte)); =20 unmap_vtd_domain_page(page); =20 + *flush_flags |=3D IOMMU_FLUSHF_modified; + + if ( order && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + order / LEVEL_STRIDE); + return 0; } =20 @@ -2097,8 +2122,12 @@ static int __must_check cf_check intel_i struct domain_iommu *hd =3D dom_iommu(d); struct dma_pte *page, *pte, old, new =3D {}; u64 pg_maddr; + unsigned int level =3D (IOMMUF_order(flags) / LEVEL_STRIDE) + 1; int rc =3D 0; =20 + ASSERT((hd->platform_ops->page_sizes >> IOMMUF_order(flags)) & + PAGE_SIZE_4K); + /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) return 0; @@ -2121,7 +2150,7 @@ static int __must_check cf_check intel_i return 0; } =20 - pg_maddr =3D addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), 1, flush_fla= gs, + pg_maddr =3D addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), level, flush= _flags, true); if ( pg_maddr < PAGE_SIZE ) { @@ -2130,13 +2159,15 @@ static int __must_check cf_check intel_i } =20 page =3D (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte =3D &page[dfn_x(dfn) & LEVEL_MASK]; + pte =3D &page[address_level_offset(dfn_to_daddr(dfn), level)]; old =3D *pte; =20 dma_set_pte_addr(new, mfn_to_maddr(mfn)); dma_set_pte_prot(new, ((flags & IOMMUF_readable) ? DMA_PTE_READ : 0) | ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0)); + if ( IOMMUF_order(flags) ) + dma_set_pte_superpage(new); =20 /* Set the SNP on leaf page table if Snoop Control available */ if ( iommu_snoop ) @@ -2157,14 +2188,26 @@ static int __must_check cf_check intel_i =20 *flush_flags |=3D IOMMU_FLUSHF_added; if ( dma_pte_present(old) ) + { *flush_flags |=3D IOMMU_FLUSHF_modified; =20 + if ( IOMMUF_order(flags) && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + IOMMUF_order(flags) / LEVEL_STRIDE); + } + return rc; } =20 static int __must_check cf_check intel_iommu_unmap_page( struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_f= lags) { + /* + * While really we could unmap at any granularity, for now we assume u= nmaps + * are issued by common code only at the same granularity as maps. + */ + ASSERT((dom_iommu(d)->platform_ops->page_sizes >> order) & PAGE_SIZE_4= K); + /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) return 0; @@ -2519,6 +2562,7 @@ static int __init cf_check vtd_setup(voi { struct acpi_drhd_unit *drhd; struct vtd_iommu *iommu; + unsigned int large_sizes =3D PAGE_SIZE_2M | PAGE_SIZE_1G; int ret; bool reg_inval_supported =3D true; =20 @@ -2561,6 +2605,11 @@ static int __init cf_check vtd_setup(voi cap_sps_2mb(iommu->cap) ? ", 2MB" : "", cap_sps_1gb(iommu->cap) ? ", 1GB" : ""); =20 + if ( !cap_sps_2mb(iommu->cap) ) + large_sizes &=3D ~PAGE_SIZE_2M; + if ( !cap_sps_1gb(iommu->cap) ) + large_sizes &=3D ~PAGE_SIZE_1G; + #ifndef iommu_snoop if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) ) iommu_snoop =3D false; @@ -2632,6 +2681,9 @@ static int __init cf_check vtd_setup(voi if ( ret ) goto error; =20 + ASSERT(iommu_ops.page_sizes =3D=3D PAGE_SIZE_4K); + iommu_ops.page_sizes |=3D large_sizes; + register_keyhandler('V', vtd_dump_iommu_info, "dump iommu info", 1); =20 return 0; @@ -2964,7 +3016,7 @@ static void vtd_dump_page_table_level(pa continue; =20 address =3D gpa + offset_level_address(i, level); - if ( next_level >=3D 1 )=20 + if ( next_level && !dma_pte_superpage(*pte) ) vtd_dump_page_table_level(dma_pte_addr(*pte), next_level, address, indent + 1); else From xen-devel-bounces@lists.xenproject.org Fri May 27 11:16:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:16:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337971.562694 (Exim 4.92) (envelope-from ) id 1nuXxK-0001cx-4q; Fri, 27 May 2022 11:16:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337971.562694; Fri, 27 May 2022 11:16:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXxK-0001cq-24; Fri, 27 May 2022 11:16:34 +0000 Received: by outflank-mailman (input) for mailman id 337971; Fri, 27 May 2022 11:16:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXxI-0001ck-9J for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:16:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7576a164-ddae-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:16:30 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-31-B9DPddiIN52f1adwB54yWw-1; Fri, 27 May 2022 13:16:29 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:16:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:16:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7576a164-ddae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bM6AKT2K8jEmZRUNQZbq7buu+njl5MQC2zWp1UMeQTk=; b=baKMvUM1JDVOsxLPJuIQw7pas24OnCSdA7ZzK3oMz3xBFnVfVGNQ+/hSgiXOVnfsVvMGix oy7Zq/Hxh9MndqVSEatz7AhvH0a9Gk1/j/tuU65vdbvU+AwAFoMYZ8TvedhBkGGqdoC0zN UEnbNuVloUh6HsCnsousrAiGyYMO+c4= X-MC-Unique: B9DPddiIN52f1adwB54yWw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edGC8k8OfY+4mXs+IRiHqfqsiaWtdBltJ7KU6Mk9NrxOGGtSwcAbU5hboRRGgcrf421L4ACrKVqdK8KFygokU4/3GbRX+/DDh5/U64SWE3iNpk7QDU39armjdmlvDBt5HWdDEHglv2K8CLyYROIIed3qwuhz5B008wbvyvB61BeClGpmI9il4d55L9qN3/5ulKpilp5yU50WwugEHYW6m6oEFnwQmqACCYmrSbCBDQpDNWOPz3YQJScwtSQWChChG4xMYdk5eGu77GPRPUZNtP2LZsF5cXjmuzvOKuktGGHIsjc/fXlyc9AItrl4pX+atOTXCSviXD61pDCn9v5rJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ffLWJC6aWwnaCLPYH0Qbww7Cy6DESc8jbX3Bj63/FiM=; b=f0m1nj8lAmd/8yWL8YJj7Got8Cb0hri6BxfRS/qzi8uFdyJQwl7jphJZQkRp4HOaB8lYTn81n02rdEOU8jVfUh+mGGR12sqol44PMFpIYi2P3AFzEAYeLd1fl1A1l8BVuy/Ns57iJsahZ5/fXScDM2O3GlOWlS/YzO+e0jqFvcrtb6/FFNKRphPm+WB4MBEyk6dIO6/m0NGBmbUf9E3ic7x1y2+kDO8dfdE5AQjCHZEih8xyDU2amA8eo0OmagEpopK4zeSnujSj4yFt02ZH6zb+cjSsxmINvYBzHGSxfonEgVU9VmBVNdGIB6fgy9D6Ve/QpUbw/d0aFeIsUQoxiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2807d8c3-054d-81a4-172d-9a08f023d300@suse.com> Date: Fri, 27 May 2022 13:16:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 06/15] IOMMU: fold flush-all hook into "flush one" Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Rahul Singh , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:20b:311::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d1abd8a-c1b4-4791-6fc7-08da3fd2578e X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Brywkv2oRW/XHE/tfRdtEQCvd68Lfk6eQTLHsJDeI0mcd4tQhpUBaNwjbMYxF8feX3R5cZrda8+dwfJZl1ZvpcuTtTcwRnyanuqO9T/EvQ54a6hUvQtXXg1NQuchriRaJuN/u+8ueQbqMuDlrA62NkJ+ZNxq3+fCfkoyMIhwzLTtNCBQxHq6/xBWesdDTKFYYL8jSkpNg6DWE7gHB3GGimIYz96sAEYv3mX7tMUFrRv9te8LVwNC2W4WM2lxPPHs5JLwoGZpkXSbE4UHXL5aAoOnoPLaOZls4Mfx7YiDoPctMIgwla30tijAPobIRHwqNoXzedWi3lMTG0dVOs1ewIiqZl+z6eK4dB/rhbo3sjbL8e4AAlM2j/KpIClU+iHYU1bHNeVSmPmLYvAqpTnUlNFTpQEbC0E8bLN/SguO3ojtaw3sMjXeO2FqTcp3XA9WuSuJXBmzPc4gIhij7mv9vMaNtng9+LQoGLh0y8B6KuDKy/tzbx1kau/OWfXqHAc3qIPi2ceYEhjT9cmtfkiDildgiWgTsKzTNFTpQdQrgTrDsI5rTo48GXtOM/y2IwL1FrNg/hg4Q2b1+FRWw4VHu5HITgEQArg6v4aRdFYWSPzh74ifYTfL534k4M9KlQfnFcsPIfgHFiwyaHBZ25AMwV8paDqbinUISYK19cwYeqEhoz60lseZB1vEeY25qykDB6MRtMhwl2PL57+cf4QvWPHn+lOcbxWbiSXWNidr8uMST4SBua1+UcgUTe1jLvbq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(6666004)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wWIDvZvDsSY76jAYGPsRY7YJR94ywwYnIwjZTgPEVB9uyy1sJKcOl+u7PzvR?= =?us-ascii?Q?UzcYS+MT/oYaz+BGVhiOiNK3hBp8aPUKKFtS/Jch5j2JlD/m+jCq1T0qqQ/J?= =?us-ascii?Q?U21vJoZPJFBnsZt654BtcAPOgys5j1JGdYFo4G+dxUwXs+zq0RCwVnG7g32n?= =?us-ascii?Q?aeB8tgAo79ielTEEX7oPgqdYs3l+rDQEM1ESJT02pqWMzy2n9SSA4M4Lor2w?= =?us-ascii?Q?wNudCzr06sztwVJkoFsHMsa9Mb+d+/DO9ne0ZIFdL3a+mjfRvSLGwUT0BsXg?= =?us-ascii?Q?KEoOPJ9/UL3eqiAQQWma+k2gcyd0pZmF6gy8K8bLejHhPbudWHJXXv+La5LJ?= =?us-ascii?Q?L3M+8CFQ4n3KV39fDrNOjv6LlRbD5UuEGpaCpIXX+7lkqmZPXelroUXGgnme?= =?us-ascii?Q?iJyvrNu3PUhArOZDtzr+mh76joQwB8g1mVHndgNEh39NUjzOr+nJPHsjFPGr?= =?us-ascii?Q?9j6EIG6Es8k8T3vgLWSsYdIW+OZtLJRqc/0k56nULIJOYNp6RAgOAupvsF3m?= =?us-ascii?Q?w0a2ATgAZc8tfIs5+Xe6hM12yhJIEDCc30HLanOde2bWJ09RPeu9/UCkuSjv?= =?us-ascii?Q?pEoxFvP7dtTH/yTXaCD3T5zl1FIvRqRuWHcWNC+8B+F5lr6ciJw9dHm8Zq+Z?= =?us-ascii?Q?7SqCOjyQsi9SYhbxoc6t5lpwsgL5x4msl45q61VV7uRcmm8Dsi1V9bAn6dBw?= =?us-ascii?Q?Z6f5x4c0J9XTfDYdhHRoMwiJxMenXh7TLGvKmbtE/RHNaVYpReOAngvEwaC3?= =?us-ascii?Q?Erx3ziV7nLl6Osax+lzSgH+cgMI1AkWBmadky46SaEw8earESTAvZp4Gw3uA?= =?us-ascii?Q?zRFpL+zS0kH7hW2YvO5/ALBHIzi5t8MNFIt4cwLEqpQBan6misHGxvTDP56L?= =?us-ascii?Q?3yfV+FMm0TMMwr0lMi0nHp+XwLJoO2rp+wDUjsGuuSoH4jz1UThZxkWsoysv?= =?us-ascii?Q?WiPH0D3ERDnLaQjrdv+cWhYBSADL4bbUweOnztkZ3BiYsCdia9ZX+GT96UNQ?= =?us-ascii?Q?RAk8yjGyodwvnaCmVf9wxFONqlJMvw6GUwNaaeYgrpLxMHnB4mW5WAtFVr1H?= =?us-ascii?Q?atKoCG8A8lm4j4qX1QB5Dg7ZDnaDdjPrg0O7xrUlq8KB33wLsEfBc9qR+Fhv?= =?us-ascii?Q?3/KZLuXgfQYl3F1QlVhNYUlq3Gr+N8Cf9eK+DE1i/3ZaKmCuHPBfoS3TTrf+?= =?us-ascii?Q?wUrHUQxW5ErkRzJVG1TEWgS1V9BcPBoglRxpSXEeIHgBj0yuzk2KABqUYAOl?= =?us-ascii?Q?ftyVkaL4vi4AGkIg+A0XQ+KLQZ6ozwkoLVVTIMj8gf0NiBr8MVyol/5jG9i2?= =?us-ascii?Q?Rs6zRmDAvvPY1GUibgF4Yy17b3pilq9AlzTrVGpCSVyHp6sV9+tq1Tfu7Mz/?= =?us-ascii?Q?l0MpJqo5PEjXvJyUtUDmvjOWVRzZT/nVZ+57ns9ZGZVij+f6xJCOqencKK9M?= =?us-ascii?Q?S3JsufKnvNpo1ukFRbB0IWCZOs33YxL5n+f6AA6xz2P+WtziubTBYfwY1wUU?= =?us-ascii?Q?WqQP2zQCMLn9bi8DrQSLrY0nRU3WNSuygGkJJg6wQRBee+QuPLkfb8+7q5dD?= =?us-ascii?Q?4YePyK0qbvOlO+pryu2+wkbx2AYinKcvvXRK+c0yei3oUTD3oQum5XGfHMhh?= =?us-ascii?Q?twquUy1+v9nykelud8hTNMupJ+2QwiKXAP9OcR+wEKpoISwt0j/1EMXo8v2V?= =?us-ascii?Q?EOoH/levEC0xUNRv9HCx9Yy8j5t2E7+gQVy3n38+nmlDYSFj7JOLKYWzuS/w?= =?us-ascii?Q?xCNHpOKxOg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d1abd8a-c1b4-4791-6fc7-08da3fd2578e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:16:27.3637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tj3ua4thj8HHTjvhKUnoBOgOS2PaUfhIs8BryJxABJRc0lGjsIOSLTWDSDzPWfgLjkQkDiTOTfpMoHcz75wdaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 Having a separate flush-all hook has always been puzzling me some. We will want to be able to force a full flush via accumulated flush flags from the map/unmap functions. Introduce a respective new flag and fold all flush handling to use the single remaining hook. Note that because of the respective comments in SMMU and IPMMU-VMSA code, I've folded the two prior hook functions into one. For SMMU-v3, which lacks a comment towards incapable hardware, I've left both functions in place on the assumption that selective and full flushes will eventually want separating. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 Reviewed-by: Oleksandr Tyshchenko # IPMMU-V= MSA, SMMU-V2 Reviewed-by: Rahul Singh # SMMUv3 Acked-by: Julien Grall # Arm Reviewed-by: Kevin Tian --- TBD: What we really are going to need is for the map/unmap functions to specify that a wider region needs flushing than just the one covered by the present set of (un)maps. This may still be less than a full flush, but at least as a first step it seemed better to me to keep things simple and go the flush-all route. --- v4: Re-base. v3: Re-base over changes earlier in the series. v2: New. --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -258,7 +258,6 @@ int cf_check amd_iommu_get_reserved_devi int __must_check cf_check amd_iommu_flush_iotlb_pages( struct domain *d, dfn_t dfn, unsigned long page_count, unsigned int flush_flags); -int __must_check cf_check amd_iommu_flush_iotlb_all(struct domain *d); void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int d= ev_id, dfn_t dfn); =20 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -548,15 +548,18 @@ int cf_check amd_iommu_flush_iotlb_pages { unsigned long dfn_l =3D dfn_x(dfn); =20 - ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); - ASSERT(flush_flags); + if ( !(flush_flags & IOMMU_FLUSHF_all) ) + { + ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); + ASSERT(flush_flags); + } =20 /* Unless a PTE was modified, no flush is required */ if ( !(flush_flags & IOMMU_FLUSHF_modified) ) return 0; =20 - /* If the range wraps then just flush everything */ - if ( dfn_l + page_count < dfn_l ) + /* If so requested or if the range wraps then just flush everything. *= / + if ( (flush_flags & IOMMU_FLUSHF_all) || dfn_l + page_count < dfn_l ) { amd_iommu_flush_all_pages(d); return 0; @@ -581,13 +584,6 @@ int cf_check amd_iommu_flush_iotlb_pages =20 return 0; } - -int cf_check amd_iommu_flush_iotlb_all(struct domain *d) -{ - amd_iommu_flush_all_pages(d); - - return 0; -} =20 int amd_iommu_reserve_domain_unity_map(struct domain *d, const struct ivrs_unity_map *map, --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -759,7 +759,6 @@ static const struct iommu_ops __initcons .map_page =3D amd_iommu_map_page, .unmap_page =3D amd_iommu_unmap_page, .iotlb_flush =3D amd_iommu_flush_iotlb_pages, - .iotlb_flush_all =3D amd_iommu_flush_iotlb_all, .reassign_device =3D reassign_device, .get_device_group_id =3D amd_iommu_group_id, .enable_x2apic =3D iov_enable_xt, --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -1000,13 +1000,19 @@ out: } =20 /* Xen IOMMU ops */ -static int __must_check ipmmu_iotlb_flush_all(struct domain *d) +static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn, + unsigned long page_count, + unsigned int flush_flags) { struct ipmmu_vmsa_xen_domain *xen_domain =3D dom_iommu(d)->arch.priv; =20 + ASSERT(flush_flags); + if ( !xen_domain || !xen_domain->root_domain ) return 0; =20 + /* The hardware doesn't support selective TLB flush. */ + spin_lock(&xen_domain->lock); ipmmu_tlb_invalidate(xen_domain->root_domain); spin_unlock(&xen_domain->lock); @@ -1014,16 +1020,6 @@ static int __must_check ipmmu_iotlb_flus return 0; } =20 -static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned long page_count, - unsigned int flush_flags) -{ - ASSERT(flush_flags); - - /* The hardware doesn't support selective TLB flush. */ - return ipmmu_iotlb_flush_all(d); -} - static struct ipmmu_vmsa_domain *ipmmu_get_cache_domain(struct domain *d, struct device *dev= ) { @@ -1360,7 +1356,6 @@ static const struct iommu_ops ipmmu_iomm .hwdom_init =3D arch_iommu_hwdom_init, .teardown =3D ipmmu_iommu_domain_teardown, .iotlb_flush =3D ipmmu_iotlb_flush, - .iotlb_flush_all =3D ipmmu_iotlb_flush_all, .assign_device =3D ipmmu_assign_device, .reassign_device =3D ipmmu_reassign_device, .map_page =3D arm_iommu_map_page, --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -2648,11 +2648,17 @@ static int force_stage =3D 2; */ static u32 platform_features =3D ARM_SMMU_FEAT_COHERENT_WALK; =20 -static int __must_check arm_smmu_iotlb_flush_all(struct domain *d) +static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn, + unsigned long page_count, + unsigned int flush_flags) { struct arm_smmu_xen_domain *smmu_domain =3D dom_iommu(d)->arch.priv; struct iommu_domain *cfg; =20 + ASSERT(flush_flags); + + /* ARM SMMU v1 doesn't have flush by VMA and VMID */ + spin_lock(&smmu_domain->lock); list_for_each_entry(cfg, &smmu_domain->contexts, list) { /* @@ -2669,16 +2675,6 @@ static int __must_check arm_smmu_iotlb_f return 0; } =20 -static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn, - unsigned long page_count, - unsigned int flush_flags) -{ - ASSERT(flush_flags); - - /* ARM SMMU v1 doesn't have flush by VMA and VMID */ - return arm_smmu_iotlb_flush_all(d); -} - static struct iommu_domain *arm_smmu_get_domain(struct domain *d, struct device *dev) { @@ -2863,7 +2859,6 @@ static const struct iommu_ops arm_smmu_i .add_device =3D arm_smmu_dt_add_device_generic, .teardown =3D arm_smmu_iommu_domain_teardown, .iotlb_flush =3D arm_smmu_iotlb_flush, - .iotlb_flush_all =3D arm_smmu_iotlb_flush_all, .assign_device =3D arm_smmu_assign_dev, .reassign_device =3D arm_smmu_reassign_dev, .map_page =3D arm_iommu_map_page, --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -3416,7 +3416,6 @@ static const struct iommu_ops arm_smmu_i .hwdom_init =3D arch_iommu_hwdom_init, .teardown =3D arm_smmu_iommu_xen_domain_teardown, .iotlb_flush =3D arm_smmu_iotlb_flush, - .iotlb_flush_all =3D arm_smmu_iotlb_flush_all, .assign_device =3D arm_smmu_assign_dev, .reassign_device =3D arm_smmu_reassign_dev, .map_page =3D arm_iommu_map_page, --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -478,15 +478,12 @@ int iommu_iotlb_flush_all(struct domain const struct domain_iommu *hd =3D dom_iommu(d); int rc; =20 - if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush_all || + if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush || !flush_flags ) return 0; =20 - /* - * The operation does a full flush so we don't need to pass the - * flush_flags in. - */ - rc =3D iommu_call(hd->platform_ops, iotlb_flush_all, d); + rc =3D iommu_call(hd->platform_ops, iotlb_flush, d, INVALID_DFN, 0, + flush_flags | IOMMU_FLUSHF_all); if ( unlikely(rc) ) { if ( !d->is_shutting_down && printk_ratelimit() ) --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -772,18 +772,21 @@ static int __must_check cf_check iommu_f struct domain *d, dfn_t dfn, unsigned long page_count, unsigned int flush_flags) { - ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); - ASSERT(flush_flags); + if ( flush_flags & IOMMU_FLUSHF_all ) + { + dfn =3D INVALID_DFN; + page_count =3D 0; + } + else + { + ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); + ASSERT(flush_flags); + } =20 return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified, page_count); } =20 -static int __must_check cf_check iommu_flush_iotlb_all(struct domain *d) -{ - return iommu_flush_iotlb(d, INVALID_DFN, 0, 0); -} - static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int= level) { if ( level > 1 ) @@ -3197,7 +3200,6 @@ static const struct iommu_ops __initcons .resume =3D vtd_resume, .crash_shutdown =3D vtd_crash_shutdown, .iotlb_flush =3D iommu_flush_iotlb_pages, - .iotlb_flush_all =3D iommu_flush_iotlb_all, .get_reserved_device_memory =3D intel_iommu_get_reserved_device_memory= , .dump_page_tables =3D vtd_dump_page_tables, }; --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -147,9 +147,11 @@ enum { _IOMMU_FLUSHF_added, _IOMMU_FLUSHF_modified, + _IOMMU_FLUSHF_all, }; #define IOMMU_FLUSHF_added (1u << _IOMMU_FLUSHF_added) #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified) +#define IOMMU_FLUSHF_all (1u << _IOMMU_FLUSHF_all) =20 int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned long page_count, unsigned int flags, @@ -281,7 +283,6 @@ struct iommu_ops { int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn, unsigned long page_count, unsigned int flush_flags); - int __must_check (*iotlb_flush_all)(struct domain *d); int (*get_reserved_device_memory)(iommu_grdm_t *, void *); void (*dump_page_tables)(struct domain *d); =20 From xen-devel-bounces@lists.xenproject.org Fri May 27 11:17:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:17:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337978.562705 (Exim 4.92) (envelope-from ) id 1nuXxz-0002A7-DV; Fri, 27 May 2022 11:17:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337978.562705; Fri, 27 May 2022 11:17:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXxz-00029y-Al; Fri, 27 May 2022 11:17:15 +0000 Received: by outflank-mailman (input) for mailman id 337978; Fri, 27 May 2022 11:17:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXxy-0001xA-Ha for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:17:14 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ef28913-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:17:13 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-39-dBmytWmVNeSxHDLZLFECnA-1; Fri, 27 May 2022 13:17:11 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:17:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:17:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ef28913-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkjYnsuJuIkyi038qFhXwji2/Rxpp4JG0amuTKIuhJU=; b=FYDjvmFsXTb2LDfTo+Wfp+gP6bbl9LChp6S3wnzMHnqiCBWTcTDhIgzzmeembQrnQaapWk 3A1XGTujwxTBoEWmQN+YXIjRjqKkC7LRVBi3flmWGfrV4NtGBZo1jIXxtAQrU0kCL0NhiF HKuptOrvVBklbrXHTpcryCZJGK0+yow= X-MC-Unique: dBmytWmVNeSxHDLZLFECnA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GaiVRM7IsofcFjdsYnr/lvCCJ2LKSMJcB1TSnm7OWgBWE9dgispmLhM2/DJMTRB8TKmLJ98e8V/xn3YXuzAwkis8LEciMRRxhI1I2cfwK4KutMZuXdclPMOtsNIuJyO4O9C11JAR9l1ZeVvyGN9GxVVJA7AENiNkB1iX/fuKi2PieCijDrnGw0FGBfglfbFqjrRvcB23yTjOozGiHEUIrIs0H9HFzJ0TqXfYmatPoWym3snI6swZFsAfdMUTvQnfyVL3sIz8mM2sI4tBqReXEjpJXj8+xL6U78j/0wn9Hh2w7QASxwgGDzliGnUH8K4InQ2VcIAYTw/TrThIlHanJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RkfpNnHTVuEAPWGDCPWVLqkwh9PtWcL+B3weEOaUpQY=; b=lFAHPueMCaUYBOdm9GM43qgC7pk9uslA+VmHteOjHVpgfm4AMLpummoEBFHtw+TTh77NYgQ+8FKZaDuCHx6h06gJOJwc9ZlUd7uT7/E7HCuVLD1gXEAuCW/+TP5g+k95QX7MG5osptpUv7RCONr9aa/oJ2b0gkDkeqbSd5AUr85nCBhcp++FGZySFEV5FcTjEOcI6R+/lQR2K6SDrvDqQ2pzgCj1JoFFyGP+XxTl4KVaRwRPU5hcOUkytBIvkbx6cBIycln3BjW9jj5cTxxeRK4YSUUJut++fHQ1vTkIf/OOfTa5BHpoFTate0Jsjih1ht655C8xaW0ILR8shbL1nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1fec512a-8c7b-69b5-40bf-88b42e9ecb7d@suse.com> Date: Fri, 27 May 2022 13:17:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 07/15] x86: introduce helper for recording degree of contiguity in page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR05CA0020.eurprd05.prod.outlook.com (2603:10a6:20b:311::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d999bae7-e061-4c62-c6b6-08da3fd270e7 X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x2aP4wBf3Asdk8nuF2D3A7UefiwMF/84sheBRy3YoZpDJRgKCyZGrvNxmC9+W2inPTpip0sd8rijs/OmRWiyvTe6StmhQ83k8tJJssSQzWN1HD9RhoVvaww4A/r/qtaLfSzyTXBXge7FXEo+0ngg+c5h5Y6FTR2/yWBEPSrwN0NA6UeuEewNv4THS0VDSpX9FWMvUt7hfr3wZe+H7D4/slFvyFoIpSGG3DzsB+AEqTI9fafSGlYxKmCIODJIdliQ9YI82q+gKjesx85aZ2iHTYCkqAPd35eLodPMku4XAZWriKG9RkbqB3v/VN+PzlVTS+rgyr/2T4sM/8e9hCDV02Slhk+AcYZ/4PTckkkP+4yZZeg3xGbharO35w/Wz2wvU+XIec5PbgGyy3/UUrZpdZxOlHnw6h7MnJf7hCZGcIprJACUgXCNFmn6+Q/oXijH4eMemYVPwZn8HjZlgh1492mRkS3+qCmfRf2ZQFwGoWJJLr2vgNBA1iNIUyIBkVm1TrWyahY64id6lou468cHyeZ8k6RtHk2EHuUQaH25UHsAk0C7rpwDhsFfhOUjbYPJXss/KxcvCzLUju2UvvEsNh+MwZBo34BvbyuWhzsZ2peS1ZpdQaA9jwBOdvtmQyNUKA4n6A7la8Y62+bcICTd0IZeaWnWp2j8KodgmU+WS4WjQVIPSbdk8qnQP0U0eUTbkRsHpiDWhHO1s1UcuhhdJsCODgUPNYXNRUhcKNVjjrUV/oog9OIFCge2q32HMuEC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lpnYAR/1UiEYox+o/8FG7fJd210Tsl/sW23QRdqypYJ9a3cQUYuOCXabIVCB?= =?us-ascii?Q?Us7Re7KxfLAGNk8ZaWQ0SvDqmfLy6vDZDuVKwJ14Eb64yOYj14G5utPDguKB?= =?us-ascii?Q?at08KH6UqMTse/zo1sRmZ2ER2Lb76jKs3/Bi9c3GorEkWmLzvUr0a2YQdp2y?= =?us-ascii?Q?K1f9JuqtAFKjnBlzAeeDUUgmEOsc3ZLD40fpIYlLCdt5ndKM0mPVo1d7wGae?= =?us-ascii?Q?+CP6XWA/qKwk/euYQhCATBSiOi6OQOADC2OV5/gzu+G8JlMICuum5dX4L/Ex?= =?us-ascii?Q?I5m/4eCGVK97Au5GwOpIiqwa/RHkP6894not3ezpYtZsiSGcN/zBf9Ew55a/?= =?us-ascii?Q?zoHwnKmUSOFRC5zIWqb7JcpXU7NZolAU21txuEuHD2iOxtQim+FP9CAbzm6S?= =?us-ascii?Q?3NZJOGLadX4C2egbVZIDRNjauFsRtZgC+6JWcAIPTbYqPQ4t7rIUSiR6P+1H?= =?us-ascii?Q?081l2dELJ59z3phbIRVLgT9czSjArqSuSHqFqFhKjUwVInyUtiFvBjoIpr2A?= =?us-ascii?Q?UO+EekunRyRnqekymFB00ehE0uCMEf+4PfM2YqrVCRFY3yrEYNhBgkdLDkrH?= =?us-ascii?Q?XxhmEsIBwyhX7hqRW22MgBDSePzLBvUCCgg/D9qCK9PRnEgU4dhXCHHsJOrQ?= =?us-ascii?Q?Zfw9TwcU/XENy43DrUlC8yMmK+ud33jxKCaV7QxCLyctb3fHrVyCygGfbXZa?= =?us-ascii?Q?/O0rQzEKZEIwnVTDtriQn0BYHpUYrM/sThLqtFkEet5pKXlGcLIVdhghB6sH?= =?us-ascii?Q?5y1Mqf/LS/bVnZe6OHl+NxcVI1ypPiQfOy0lOwWiCbZcjjQ2qbOa767W/IkL?= =?us-ascii?Q?A2+2ERdS6ShC5iTfTTgLBTMD91uNq3x6U8y9KBOp6E1PLYJbhPVRJlPg5MbL?= =?us-ascii?Q?d72CEsKhRxPeXF6EXtR5UOa/uVQQl0p9lcF6yzDKxdpxYLfR3fua1sCDQw1k?= =?us-ascii?Q?bWpSLoTPLjvX1zrEqJA7awEvAl656s5TXeKUz65MFnUnbzUzHb38FAICXrJy?= =?us-ascii?Q?cUeUrELJbGEMuXWdKsJ+MA1SjcGV9HhcHMBIwb7q7UYNk6ygtpq+rMXJfuDw?= =?us-ascii?Q?Jpwz9oSiKG5EN6h4y9IcPTp+ZOgFsEbdkZhy4vNMHeR1pnjpPTL6S64Q/mdU?= =?us-ascii?Q?7+IRYUaii2hiDF944ZoLF1Ei7ygA7KD1n/UawaU5wk1w3aktvMH66Q1yy5Zm?= =?us-ascii?Q?9d6ooILis5vpmbbyFwYTROQtnvfJoN+zl15I57pPM6T9vOMCv3ii5SZPyC05?= =?us-ascii?Q?eoc7+3tXG3cua7ellMV9XDsCoQ2tMctbk97mt4sR7UOHQbOzuezbGKqPlp38?= =?us-ascii?Q?qzFgkxLBf5urwmVowF/yoWnWaaRsd/uzDEe5H9dFQKcSItaR9oAr0LTS8r5v?= =?us-ascii?Q?NS0UFjNeA774aIa8kbPnEGPP6V2Fo+H0krnBfZhp7juK/m0PSsskRpZFekaJ?= =?us-ascii?Q?oc7uBJmFAsxjoTOhYnTR+nR4vv36vxFUeCEvnvm2gsL72EjDJxrFOVu9TNKq?= =?us-ascii?Q?aPpto4xCXgxtRbtTuyeuneak6wdymva5G77uMELR/rdcSGOts3EC6uhuYog7?= =?us-ascii?Q?oVBiqlDx3i2FmjXZmvjKdzQIKZGNI/H3RfwDxZ+Eqff1Th/hAOOyPJnxgjhA?= =?us-ascii?Q?6XFTQYYidU/ZjuUrbWN+rqaXkvphkSNc+4HpGTWIlBMb4+zt/oHZ0N6K7AHc?= =?us-ascii?Q?o9mqKBoct+BGfQ+PE8d0OTKKjcaURlb2ZOtJkLh21fX0dA/5WBiCYeOFD8PG?= =?us-ascii?Q?MiaNwQLY0Q=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d999bae7-e061-4c62-c6b6-08da3fd270e7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:17:09.7672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: znrazilBfjJYgAwkY3rO3/hQTUHWvi2dn6/2sLX9NHq0giw6Ga3hK+mTl0zJLAc2VhsJ86b5AQNuw0FpLVnX6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 This is a re-usable helper (kind of a template) which gets introduced without users so that the individual subsequent patches introducing such users can get committed independently of one another. See the comment at the top of the new file. To demonstrate the effect, if a page table had just 16 entries, this would be the set of markers for a page table with fully contiguous mappings: index 0 1 2 3 4 5 6 7 8 9 A B C D E F marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 "Contiguous" here means not only present entries with successively increasing MFNs, each one suitably aligned for its slot, but also a respective number of all non-present entries. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- @Roger: I've retained your R-b, but I was on the edge of dropping it. --- v5: Bail early from step 1 if possible. Arrange for consumers who are just after CONTIG_{LEVEL_SHIFT,NR}. Extend comment. v3: Rename function and header. Introduce IS_CONTIG(). v2: New. --- /dev/null +++ b/xen/arch/x86/include/asm/pt-contig-markers.h @@ -0,0 +1,110 @@ +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H +#define __ASM_X86_PT_CONTIG_MARKERS_H + +/* + * Short of having function templates in C, the function defined below is + * intended to be used by multiple parties interested in recording the + * degree of contiguity in mappings by a single page table. + * + * Scheme: Every entry records the order of contiguous successive entries, + * up to the maximum order covered by that entry (which is the number of + * clear low bits in its index, with entry 0 being the exception using + * the base-2 logarithm of the number of entries in a single page table). + * While a few entries need touching upon update, knowing whether the + * table is fully contiguous (and can hence be replaced by a higher level + * leaf entry) is then possible by simply looking at entry 0's marker. + * + * Prereqs: + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 + * contiguous bits (ignored by hardware), before including this file (or + * else only CONTIG_LEVEL_SHIFT and CONTIG_NR will become available), + * - page tables to be passed to the helper need to be initialized with + * correct markers, + * - not-present entries need to be entirely clear except for the marker. + */ + +/* This is the same for all anticipated users, so doesn't need passing in.= */ +#define CONTIG_LEVEL_SHIFT 9 +#define CONTIG_NR (1 << CONTIG_LEVEL_SHIFT) + +#ifdef CONTIG_MASK + +#include +#include +#include + +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK) +#define SET_MARKER(e, m) \ + ((void)((e) =3D ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK))) + +#define IS_CONTIG(kind, pt, i, idx, shift, b) \ + ((kind) =3D=3D PTE_kind_leaf \ + ? (((pt)[i] ^ (pt)[idx]) & ~CONTIG_MASK) =3D=3D (1ULL << ((b) + (shif= t))) \ + : !((pt)[i] & ~CONTIG_MASK)) + +enum PTE_kind { + PTE_kind_null, + PTE_kind_leaf, + PTE_kind_table, +}; + +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, + unsigned int level, enum PTE_kind kin= d) +{ + unsigned int b, i =3D idx; + unsigned int shift =3D (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT; + + ASSERT(idx < CONTIG_NR); + ASSERT(!(pt[idx] & CONTIG_MASK)); + + /* Step 1: Reduce markers in lower numbered entries. */ + while ( i ) + { + b =3D find_first_set_bit(i); + i &=3D ~(1U << b); + if ( GET_MARKER(pt[i]) <=3D b ) + break; + SET_MARKER(pt[i], b); + } + + /* An intermediate table is never contiguous with anything. */ + if ( kind =3D=3D PTE_kind_table ) + return false; + + /* + * Present entries need in-sync index and address to be a candidate + * for being contiguous: What we're after is whether ultimately the + * intermediate table can be replaced by a superpage. + */ + if ( kind !=3D PTE_kind_null && + idx !=3D ((pt[idx] >> shift) & (CONTIG_NR - 1)) ) + return false; + + /* Step 2: Check higher numbered entries for contiguity. */ + for ( b =3D 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b ) + { + i =3D idx | (1U << b); + if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != =3D b ) + break; + } + + /* Step 3: Update markers in this and lower numbered entries. */ + for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b ) + { + i =3D idx ^ (1U << b); + if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != =3D b ) + break; + idx &=3D ~(1U << b); + } + + return b =3D=3D CONTIG_LEVEL_SHIFT; +} + +#undef IS_CONTIG +#undef SET_MARKER +#undef GET_MARKER +#undef CONTIG_MASK + +#endif /* CONTIG_MASK */ + +#endif /* __ASM_X86_PT_CONTIG_MARKERS_H */ From xen-devel-bounces@lists.xenproject.org Fri May 27 11:17:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:17:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337986.562717 (Exim 4.92) (envelope-from ) id 1nuXyR-0002li-Qm; Fri, 27 May 2022 11:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337986.562717; Fri, 27 May 2022 11:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXyR-0002lb-Nq; Fri, 27 May 2022 11:17:43 +0000 Received: by outflank-mailman (input) for mailman id 337986; Fri, 27 May 2022 11:17:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXyQ-0001xA-G4 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:17:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f73572c-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:17:41 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-U5vlanUjPPKZrKiI8f-M4g-1; Fri, 27 May 2022 13:17:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:17:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:17:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f73572c-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yOmd6nlV3KqMUXfqufTnFOwdi1OjszdzmaKj6+ae9bI=; b=co63amCtMSIcFcYCVdR0FBOQz7md9iwAmFLWYa7UPtoq+8oOFdZEHp9baaZXFqw1cwnvcl +7RJyJT7L3wyEMuJQrd8EJ2Mls5ddIDlTfeRiKWguclzOeoak1GJryAASXs5J5kXajYhmV FM1DVY2nxDpRKbWo54Yvidhxzwyh2LY= X-MC-Unique: U5vlanUjPPKZrKiI8f-M4g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cycgSMFvQJJguyJomSb4NqgXvqeY+u/O30zML15NWW5Glux3Y8sfj6ReU5ZgdDAj1Q2flBeC/HmYfAokeM/hVwLA/ZbRU0pXa36UGXxwTSWGS18b/R8n+KbrJmGH4ND5XMB9d4kp3BXDOJ9bKmTN99a6op2w7K09XsPOQ43rggXOjS+4gbyhJWMif8Xuwu5CIkyKvgHoMQG+s2f2FlFZIA27TpLAeW/Wjh/gshWP3z3VaOVtUvYg44fixX+aK19UZwazgqjY3jEu94OdekKWWhCmJGFOSEpqkdq14YiN8oIfXzu5cpiXdyg9ExkaVm2ac1oEfmCSnMvhCR0z+SYq1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yOmd6nlV3KqMUXfqufTnFOwdi1OjszdzmaKj6+ae9bI=; b=Oj7xDNdwkx7zT/+mG8fJQS6gKGyWDmGPk1FFfMmv4qvGrH7ZQUPCseG+EyfjliPlcjdpMMJ1ALW7ka6776izvPYke3BXc5KbLNUeXaLNVHXQ0jK86fbJoKXEhmbpqFwa6kWmsNuUU4ZepSSBJhOY0fqC7L0r64ag1bxp/Y4UuPo0pjg1emqqepywphrxiOLxNibLA5NdEpY/jCxJfr8gN8Xt+0rGI8Pvv3qhKx1vCaauK1OqchVzdPXT5/ofQ6kksnPaXplOl0fbJrH3SY6VSr8weaTwskvLGohyN4iLIxapuin3GkRMzoSHJ4Uvv4zF+vBVQ1UV3UzxLQgpIOOEyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1df469a9-ddf2-2036-105a-f303f0554f06@suse.com> Date: Fri, 27 May 2022 13:17:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 08/15] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0125.eurprd04.prod.outlook.com (2603:10a6:20b:531::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c85d85b-2366-4447-e41b-08da3fd28184 X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DCW/+L1wfhFMsE1TCd+QyiYZjHhlmKkANqwjQywJ6vex93MOk7PteQcygzBqzluK30h5p0illniaC2v4vbhoJH5AvwKaItTxBXHqdzSw1XTnVlcy7FxZire6oYEHofhCjWshkrfWhXyY0hx5cQ8E/CLTK7dDqyF+36sOVpwuyVho4yx2LTpgc4nUvk1RTc34eEYYpJSRIORAeeyZPhDN5Ek+wMyAY9vzdr/nyuiA49IumpGDGTiN+45r2YOujR3lboAWxZVwWJGXAboZM0vcCOgM1/yPN9GBeqSLt5o+NfJJjA88Y/SDdYuTpm0Wj4iF2mhhtbjOWrHlsUBpcv/KTgkM3xnCz6/Ix8RL93a2IZDSmUnJhtE1p5oH6d79mx4vdswAGKPhvxuQKiwuX1CATs5FdQ1s+eBn6UrpB3lZA9YuAona+4w5lkziGG2fZHeXckYZPTvlN9b3FnB++s3wjt9xP5Pux7BRMOcI2eEtyCWmJGpz5jgEGS9rMhokbiaigQQ+PN3pMQ/iyn1etDVkeh6fr1mO5KvXCHeFrGkiASCNOa6onuupXAVtRdGbTpp7Wy6f9nd8QZy41mZa+kYfRfa+Hyh/mjSZMY0KU3OcPdxYE0vSepPSte9m5dbc29CtyzzGdsp9D66nD/sEtFGWib9kPZA2n2y+3YPk47OMUekfvEttgPPZEOGE6LGsMNQRsMgP4guph4FjrrocUQQR1/8aBTy/vCNBQgYCiYcsqiGdDvdP+t4gGIG9dXOizKSZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFZETWUwY05oS3VZaWhQSTJMdHpYMEJUWjVWQndQYkYxZjhSaTBCMDRjYVlY?= =?utf-8?B?TTc2WjRYZy9IZmJLTDVlTHZLL2s0T3RmcGVaa1UxeU5hcWNSOTZXZmx3VkhF?= =?utf-8?B?d3IycjRuVXc1azRWR0hLb3AxUXBscFlIN2xRcVYrTHNOdWIvVjRDVmhnSU0w?= =?utf-8?B?V1J3ZldEbEgxTHl0RTYrN3FZRmNneGpkZWU2TmVxcG85OHJ6QWVuZUl6Z2M1?= =?utf-8?B?UDQ2WW51SUJtSW1jak4zajNlVmYzU3pOM3FIbWs3SnpwNWJSUXhyQmtyS2t6?= =?utf-8?B?UTJPUFhOVWZxK3pKL2NGM005b0gyUkhBV0pYbWRrWmFEaWV5RGlYK2NHQnhM?= =?utf-8?B?ckVQeG5tYWttdk9rbmFobUxEUEFYWFBsekR6a1B3MzFNZS9Ddm01VnhmVVBq?= =?utf-8?B?eVZhUVVVZEdBN0QxeGtHVldVUkpQNlp5ZVJaSUVZRzVWc0NTaWtZa05rVWYx?= =?utf-8?B?WEVxNnl5RzdBUXhQck9pcHRYVlV0OWhLeVpoWkdSZm1aZDQyb3BpZFkwdFB0?= =?utf-8?B?K2RQVVk5SnlOVnBMcWE1M29YYkp4ZlFDcW5Ha3FVZEFJUnl6WEFNd2p6anVk?= =?utf-8?B?bXB0bkFZcDNtajRyMkF4Q0dYdmMxUnJKNVJxS0VxZk5nbVRJZmsxZ0xNYnBm?= =?utf-8?B?WE15UW0wa3h5cjNLM2ltT25MTWczdk91UVhPUEd4OWI0WGp0N2RTbUF6QmRX?= =?utf-8?B?Uzc1TC91T2xlMVZDWHJwL2JxM3E5ZUh6RUczZjVlWW16bWZ0R2FWMVNUYVZT?= =?utf-8?B?TnNKaTBENXdGNGpHL3FZWHNHdU1sRXYyMGM4T0NITGRiUXZMQUZJR0hyNFhw?= =?utf-8?B?RXljRmFrUzMzeWMxVUk0SGg4Q25vZWtsQnN6a0x5UzF3bGVGKzdsbFYzTHVX?= =?utf-8?B?VExPVmhHVDVsZU51Y0JLNWtPMzhiV2pRMGpDU2VVclhCM25jRDRXNVhRdVdu?= =?utf-8?B?UC90ZFJ1S01VLy9SbHZ6NmRFWi8rVDh6cUthTWhGV3BzcmljMFBmYSs3cDJE?= =?utf-8?B?UHdtbHdCS3dSSXEydklZSmZZM21ScmVENklON1h6ZWtJZHQyTzlHbEFYUldP?= =?utf-8?B?VEVkNVJWUFNuMk41eXZEUEpQdHNVY201N0tYQ29QRlNkeDMxaUgvamhiZm5D?= =?utf-8?B?OWh1K0NEeWtNdk9UK2FSTlVtZENqc1NvOUdwKzhHdFBrTEZYWGREei9CRzAr?= =?utf-8?B?M1BPZWMzTWFMWWhkTXQ5bjZ4UU16MW1HQ2xGTmtEZFZOSzNwMk5ETG0vZU93?= =?utf-8?B?Yi9ONnM3WFpGMjgreHM2aXdjMklUT0I4TFF6MVduUW1UeVlZODhGVEFpK3JQ?= =?utf-8?B?WVZEUzZBNVl2SjhLZjN5YjljL3VMRFJEazZ1bi9Gem0rWDRCL1oxOHdPTjdm?= =?utf-8?B?Q3dPcW9TL2Vxb1lWR3lwU25tQnMyYmlseldRVlJRamlwZDgzKzk2dnFSWGFU?= =?utf-8?B?T1hkRWZFRElKclliWGZwa3VlRThmWkVvQjVlSTJRc1VkeWNUWCtmVEFSbWRx?= =?utf-8?B?d0RnUmJiaG0vSkhRaDVoZTI5YUxpcnRVSWI1eFpCM09lckFsUDVJQUY0N0s2?= =?utf-8?B?NGk0R0VTMEx6d1prM25abGRtUXBQL0pVVXdQcWQwM1lnc3BPQmwyQWVRT0xk?= =?utf-8?B?Wk53Q05NUXdzYVlUcU4wRDFrdWJoMFJkOFU0c3doZVl3R1NWU3JHSmp4Q3Qy?= =?utf-8?B?QWxTUTZUU1htYy9oU0FPY1J2NDkxR2FlNi8zb0RVR0UzaHZWWDNRWXBJNVov?= =?utf-8?B?UkRveHlHS1JDbkgwRWt0czkvR1dnUnpMVkpOQzErSFhjWnl0Sm93a1JaSisx?= =?utf-8?B?Rjg0NWJUS0o4MGY0Y0FMWFJ6MTVXdzVKdTlQRUdLU0JtTjREOXV0M1g3VzEw?= =?utf-8?B?UDUrNkl0ZWhBbEtWOEZheEp0VGhFK0E4bklaaXdjY1RhL1IvRHNWeDFzVkV0?= =?utf-8?B?cmxHWXp2OHZIQjNXbzhtSG9SUHMzRU1MMEJoc0ZldWl0WXZVcHhzOXdPVzdY?= =?utf-8?B?LzlDNG83YlVEQVJhTVJJa0JYOHI2d1FHSUgyT3g3Uk13NnpRamJNa2lia2oz?= =?utf-8?B?UWZLMndVYWhtMGpzMVg0NndtdjVvYkVveG9yUzUyNlg3emdjS3RiNysrZERL?= =?utf-8?B?b1ZUNlprVm8xS2ViY2lDejhCSmR4ZHNwRWRoR2doOGUrNTF4ZUpZRHBwaGZL?= =?utf-8?B?RVV4eG05YU14YzdkbUdsWm5yL1VPaXRJZ0pWUTFQeHIyaHZac3BZL2lSa09M?= =?utf-8?B?ajllV2tYT2JWOG16NGpFM1JidXFxTlRmSjN2MG9wRXBCZlVPbmV2THVPTEZB?= =?utf-8?B?SlRZWW9kdndUcnl0bzUrcCtxMmx1M1BtcnNxRG5XOGJPdktuNHRBQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c85d85b-2366-4447-e41b-08da3fd28184 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:17:37.6248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xen5K9JNHfQeTxp7SGpY3wvV6jDteF7P5UormBq3gGRLo/EfYSc2d+KrrXbeCIxYDk2DbC9Yoq4qx+BgarlPbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 Page tables are used for two purposes after allocation: They either start out all empty, or they are filled to replace a superpage. Subsequently, to replace all empty or fully contiguous page tables, contiguous sub-regions will be recorded within individual page tables. Install the initial set of markers immediately after allocation. Make sure to retain these markers when further populating a page table in preparation for it to replace a superpage. The markers are simply 4-bit fields holding the order value of contiguous entries. To demonstrate this, if a page table had just 16 entries, this would be the initial (fully contiguous) set of markers: index 0 1 2 3 4 5 6 7 8 9 A B C D E F marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 "Contiguous" here means not only present entries with successively increasing MFNs, each one suitably aligned for its slot, and identical attributes, but also a respective number of all non-present (zero except for the markers) entries. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- An alternative to the ASSERT()s added to set_iommu_ptes_present() would be to make the function less general-purpose; it's used in a single place only after all (i.e. it might as well be folded into its only caller). While in VT-d's comment ahead of struct dma_pte I'm adjusting the description of the high bits, I'd like to note that the description of some of the lower bits isn't correct either. Yet I don't think adjusting that belongs here. --- v5: Assert next_mfn is suitably aligned in set_iommu_ptes_present(). Use CONTIG_LEVEL_SHIFT in favor of PAGE_SHIFT-3. v4: Add another comment referring to pt-contig-markers.h. Re-base. v3: Add comments. Re-base. v2: New. --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -146,7 +146,8 @@ void iommu_free_domid(domid_t domid, uns int __must_check iommu_free_pgtables(struct domain *d); struct domain_iommu; -struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); +struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd, + uint64_t contig_mask); void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); #endif /* !__ARCH_X86_IOMMU_H__ */ --- a/xen/drivers/passthrough/amd/iommu-defs.h +++ b/xen/drivers/passthrough/amd/iommu-defs.h @@ -446,11 +446,13 @@ union amd_iommu_x2apic_control { #define IOMMU_PAGE_TABLE_U32_PER_ENTRY (IOMMU_PAGE_TABLE_ENTRY_SIZE / 4) #define IOMMU_PAGE_TABLE_ALIGNMENT 4096 +#define IOMMU_PTE_CONTIG_MASK 0x1e /* The ign0 field below. */ + union amd_iommu_pte { uint64_t raw; struct { bool pr:1; - unsigned int ign0:4; + unsigned int ign0:4; /* Covered by IOMMU_PTE_CONTIG_MASK. */ bool a:1; bool d:1; unsigned int ign1:2; --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -21,6 +21,8 @@ #include "iommu.h" +#include + /* Given pfn and page table level, return pde index */ static unsigned int pfn_to_pde_idx(unsigned long pfn, unsigned int level) { @@ -113,9 +115,23 @@ static void set_iommu_ptes_present(unsig return; } + ASSERT(!(next_mfn & (page_sz - 1))); + while ( nr_ptes-- ) { - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); + ASSERT(!pde->next_level); + ASSERT(!pde->u); + + if ( pde > table ) + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); + else + ASSERT(pde->ign0 == CONTIG_LEVEL_SHIFT); + + pde->iw = iw; + pde->ir = ir; + pde->fc = true; /* See set_iommu_pde_present(). */ + pde->mfn = next_mfn; + pde->pr = true; ++pde; next_mfn += page_sz; @@ -295,7 +311,7 @@ static int iommu_pde_from_dfn(struct dom mfn = next_table_mfn; /* allocate lower level page table */ - table = iommu_alloc_pgtable(hd); + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); if ( table == NULL ) { AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); @@ -325,7 +341,7 @@ static int iommu_pde_from_dfn(struct dom if ( next_table_mfn == 0 ) { - table = iommu_alloc_pgtable(hd); + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); if ( table == NULL ) { AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); @@ -726,7 +742,7 @@ static int fill_qpt(union amd_iommu_pte * page table pages, and the resulting allocations are always * zeroed. */ - pgs[level] = iommu_alloc_pgtable(hd); + pgs[level] = iommu_alloc_pgtable(hd, 0); if ( !pgs[level] ) { rc = -ENOMEM; @@ -784,7 +800,7 @@ int cf_check amd_iommu_quarantine_init(s return 0; } - pdev->arch.amd.root_table = iommu_alloc_pgtable(hd); + pdev->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); if ( !pdev->arch.amd.root_table ) return -ENOMEM; --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -342,7 +342,7 @@ int amd_iommu_alloc_root(struct domain * if ( unlikely(!hd->arch.amd.root_table) && d != dom_io ) { - hd->arch.amd.root_table = iommu_alloc_pgtable(hd); + hd->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); if ( !hd->arch.amd.root_table ) return -ENOMEM; } --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -334,7 +334,7 @@ static uint64_t addr_to_dma_page_maddr(s goto out; pte_maddr = level; - if ( !(pg = iommu_alloc_pgtable(hd)) ) + if ( !(pg = iommu_alloc_pgtable(hd, 0)) ) goto out; hd->arch.vtd.pgd_maddr = page_to_maddr(pg); @@ -376,7 +376,7 @@ static uint64_t addr_to_dma_page_maddr(s } pte_maddr = level - 1; - pg = iommu_alloc_pgtable(hd); + pg = iommu_alloc_pgtable(hd, DMA_PTE_CONTIG_MASK); if ( !pg ) break; @@ -388,12 +388,13 @@ static uint64_t addr_to_dma_page_maddr(s struct dma_pte *split = map_vtd_domain_page(pte_maddr); unsigned long inc = 1UL << level_to_offset_bits(level - 1); - split[0].val = pte->val; + split[0].val |= pte->val & ~DMA_PTE_CONTIG_MASK; if ( inc == PAGE_SIZE ) split[0].val &= ~DMA_PTE_SP; for ( offset = 1; offset < PTE_NUM; ++offset ) - split[offset].val = split[offset - 1].val + inc; + split[offset].val |= + (split[offset - 1].val & ~DMA_PTE_CONTIG_MASK) + inc; iommu_sync_cache(split, PAGE_SIZE); unmap_vtd_domain_page(split); @@ -2176,7 +2177,7 @@ static int __must_check cf_check intel_i if ( iommu_snoop ) dma_set_pte_snp(new); - if ( old.val == new.val ) + if ( !((old.val ^ new.val) & ~DMA_PTE_CONTIG_MASK) ) { spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); @@ -3064,7 +3065,7 @@ static int fill_qpt(struct dma_pte *this * page table pages, and the resulting allocations are always * zeroed. */ - pgs[level] = iommu_alloc_pgtable(hd); + pgs[level] = iommu_alloc_pgtable(hd, 0); if ( !pgs[level] ) { rc = -ENOMEM; @@ -3121,7 +3122,7 @@ static int cf_check intel_iommu_quaranti if ( !drhd ) return -ENODEV; - pg = iommu_alloc_pgtable(hd); + pg = iommu_alloc_pgtable(hd, 0); if ( !pg ) return -ENOMEM; --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -253,7 +253,10 @@ struct context_entry { * 2-6: reserved * 7: super page * 8-11: available - * 12-63: Host physcial address + * 12-51: Host physcial address + * 52-61: available (52-55 used for DMA_PTE_CONTIG_MASK) + * 62: reserved + * 63: available */ struct dma_pte { u64 val; @@ -263,6 +266,7 @@ struct dma_pte { #define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE) #define DMA_PTE_SP (1 << 7) #define DMA_PTE_SNP (1 << 11) +#define DMA_PTE_CONTIG_MASK (0xfull << PADDR_BITS) #define dma_clear_pte(p) do {(p).val = 0;} while(0) #define dma_set_pte_readable(p) do {(p).val |= DMA_PTE_READ;} while(0) #define dma_set_pte_writable(p) do {(p).val |= DMA_PTE_WRITE;} while(0) @@ -276,7 +280,7 @@ struct dma_pte { #define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE) #define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K) #define dma_set_pte_addr(p, addr) do {\ - (p).val |= ((addr) & PAGE_MASK_4K); } while (0) + (p).val |= ((addr) & PADDR_MASK & PAGE_MASK_4K); } while (0) #define dma_pte_present(p) (((p).val & DMA_PTE_PROT) != 0) #define dma_pte_superpage(p) (((p).val & DMA_PTE_SP) != 0) --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -26,6 +26,7 @@ #include #include #include +#include #include const struct iommu_init_ops *__initdata iommu_init_ops; @@ -538,11 +539,12 @@ int iommu_free_pgtables(struct domain *d return 0; } -struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd) +struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd, + uint64_t contig_mask) { unsigned int memflags = 0; struct page_info *pg; - void *p; + uint64_t *p; #ifdef CONFIG_NUMA if ( hd->node != NUMA_NO_NODE ) @@ -554,7 +556,29 @@ struct page_info *iommu_alloc_pgtable(st return NULL; p = __map_domain_page(pg); - clear_page(p); + + if ( contig_mask ) + { + /* See pt-contig-markers.h for a description of the marker scheme. */ + unsigned int i, shift = find_first_set_bit(contig_mask); + + ASSERT((CONTIG_LEVEL_SHIFT & (contig_mask >> shift)) == CONTIG_LEVEL_SHIFT); + + p[0] = (CONTIG_LEVEL_SHIFT + 0ull) << shift; + p[1] = 0; + p[2] = 1ull << shift; + p[3] = 0; + + for ( i = 4; i < PAGE_SIZE / 8; i += 4 ) + { + p[i + 0] = (find_first_set_bit(i) + 0ull) << shift; + p[i + 1] = 0; + p[i + 2] = 1ull << shift; + p[i + 3] = 0; + } + } + else + clear_page(p); iommu_sync_cache(p, PAGE_SIZE); From xen-devel-bounces@lists.xenproject.org Fri May 27 11:18:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:18:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337992.562727 (Exim 4.92) (envelope-from ) id 1nuXzW-0003QQ-3v; Fri, 27 May 2022 11:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337992.562727; Fri, 27 May 2022 11:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXzW-0003QJ-1B; Fri, 27 May 2022 11:18:50 +0000 Received: by outflank-mailman (input) for mailman id 337992; Fri, 27 May 2022 11:18:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXzV-0003Q5-00 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:18:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c72a2f96-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:18:47 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-45-XwqzWwDnOiq6zlJXvt8Egg-1; Fri, 27 May 2022 13:18:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:18:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:18:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c72a2f96-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=56Ikp8kYb60S5Ww1u1UKlg6+iuxYU2FuDji0p2qDOgI=; b=eHfCWYLvp5PdKGmrPpOYIaGsIF2WXotqVYHeP2y7w6+L/gedNqkNfDA9zPEi/DbGPveq2w x7csRtHh5MrCaVtmkki57px/g/frNt5RcQS2JQ1NJIMUgfkKqr0Z4vMdnpfxTvBX5o5HMq 7429nOqpxgfS4gpfYqPDf8sJDn9UKUI= X-MC-Unique: XwqzWwDnOiq6zlJXvt8Egg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQ1jIvc5l9Tv/CeQtecHdQ8E7lGXuclAN7bJWF+PruSxY3que6ueVvGnYZ+aVgpXhxmn99wB8VppE56/vyGZQn6FaVO4l26y+RkCPr7lOCM16Yu6bj+KLyohvJ+QM0f6fY/jHAz/vFtEE7wtnvvnnQq+4Jn2sEEjdYKv2cRzCZBugYGwm6aRjQ12NoKgPdxIycfkenVTsSy5EtpBm8KA5s1nrj9NmdCXtJYuhwcVZujUXKBeLg89NFq2+chuPUn3teIQehfcmY538qEHloMXSVYt+7sSm8NwRWSTr4MnxSZt5EUdsr05HQLO8dxXUpafVVH5qR5pir8LRCEZNhSkSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i1SRbMZ5vtUn4A75NysmPVCeWEjl1KBkL8Pu3NNkQeY=; b=M7fWYVj5h67HGeunumVuSpEDuQJLlblXqTV5AF6qd0iJdl3Gd5pRr6tVu23xUnj2y1X5lh7t+gOnLRbXieLyIkEdK5ZyB0cEPVWpejcrRh02Boi8CGzZHPXXmoIWhEMmOzpec2xDnagIXhK4WcG2t5hMhiCYfKyX2sJTY+ADGg4JNyfpnoeAQd80DhW3ooJVtF1FgYZlSz6Ao99p7NvnWjCym2uPgpk5A2of/WPpSR5bgk2aW6/BtS3g9y7PPHPNdc+EsOaACbqwAwcNTCqUGYGDFqEmae5BlpleODJWoEN3VA9Qkze3f4RUJ0S2vjJpavOvY8PfdmueU8Dk/CaAOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:18:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 09/15] AMD/IOMMU: free all-empty page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P195CA0048.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 636a0464-50b8-4d97-14f7-08da3fd2a989 X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9PkAyeijGi6cEcXwQ9DvWJ3Ri26IejewGqboGyjNIMd9jHTKkkoL3qGjleOdrbD0j4uNzzkrCXLDYnaMfhCi1rZqFXbbRL1P9DzewWxno8d7WbYaZmCN8YaieAo3oOJVy/zaCLH9hfSNrQiEUSkpMZ+J92cibPuUC/LJqIKjfrwf0ueydF/MjEnZMrX0EL1bxTsHuhFeZXdnK33bXSBkleYqGHy3EJ6Y4N8pYb22iZAuC2HgGkfe6yMX62pSZyU3Sd1E1fDeqCbvH5b6htS9/Vc1EhOnFDzmImGYIlsJwgG9gComX4FK0XIz2zDlpoA3Y+gmsCHFM1FkhrkSBkQvdmqrsIskyqelKIUFbRJ7hE81py3bRcvafkqqo8vzXAT236T0Ue4LadE91lSlHpHeOQcD0Nak/8ebK5UcfyrCHxVLXtzWmis6FBgoQvCPvpU6Mw3mo6i9nwFzJCutXgIhV+qJuaQQRwBrngdhDxwq7zGZ3+nRVV40B02iTdYk4U6nv184colaVoBBvThEcwQ5nFY7RHZXCshLkLzPfolUOFMYkW2fzsttQV4+M1ECWWdnW/aREB1v88i4a2ZJeeMKLsdlgLGRn+62qw448H3BZYda0a746RHRg8+uc8PUhDS2kn3aIES37uditkzr+bUbsLh+GnIXULa+cROnwgSomxaxNj0G+hqZIZbdRlZBNfEm4aKj60FaR95UAmjsj41I0/Poj206g/lIM5q24+QMjVE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pmCCWHymAv7iWq2CxkCpIZyhnSEjQ9RZ7lU0y06Cn8UX96+KFUjEB1GRmc7D?= =?us-ascii?Q?G7tJUM/Pzos0bc9CvDUT0kzS1JH3KDVONWFIphkaqv4veiguiYV3LAx9rC8r?= =?us-ascii?Q?oVXfGoA1aAL0g7AgfLAWY6kxUMt5ULOK+pGB2OKkf6jUZw3uC5p9P+4v3LuE?= =?us-ascii?Q?q72q4cZzrZ9X4XocRY+JgReDqucEySIRqLKNwCv+2yoZdRhzj996GtRao8M4?= =?us-ascii?Q?IJ6weWbiXka803NGk+fTyrolId0i5I16o3k++LV3awxCiuaItaRcZodtMVBs?= =?us-ascii?Q?Xn8NX1HzNQXxgQhO3IrZVxftYK6ZcWqoBPCTimAcnT7edClzSz0GGFbUIj7Y?= =?us-ascii?Q?g50knkoWQdVjU7pLJT2+FI5bbZ6mREAk9OQ1H7/c3Vr8mWck3ulLu+3yc6QQ?= =?us-ascii?Q?FO7EcwN0rbliNoYe+fGAuHx/XL5QHDeM18SZdHp9NAFlWqFzerU0ShJOPrxm?= =?us-ascii?Q?Q9KJ0f0ynJqo//f+H7MZ7PYTQCFrKPcCchCvuf7rPJVzSWxQ5Tx67NMAZVip?= =?us-ascii?Q?RyBnQqtc1n6H/1JlAhabXjE0Ke7wgug8GV4o7OcH6BCRpCpfwvlm6SREhVrW?= =?us-ascii?Q?6cuy3RKGjQVnNMJA2SnBC19c8VSEmtB6dap/O3mSVSQtyvP1Eb0Dg/qQ+Y4U?= =?us-ascii?Q?IwDt8a6EXecQtDKPIw2T5vg1OCfDUnk/M9SSlL7jjvKcUG7c/z5eDlxLOB0+?= =?us-ascii?Q?6MS6sSA8jLT0NUKEqnqRhKSJv+6YRCToqOo62Bl9I73E3eavb1cTQR0Oj+Nv?= =?us-ascii?Q?XsVU6sQrn/oVDVHX06Q+Wpf5LKj0Dwe9iHCsIzRU2QELhVY8BbmFdf+2zWg9?= =?us-ascii?Q?mZqgZph71kuGj2gz544G9z8IvnFhHrfRoU9Z7HrBTaojKdpgU3kCtpteUXaK?= =?us-ascii?Q?r0SmVUVJRh4bsuS8HOAtZFj568SxMI57btlmGkCEX9uukfjN0hLaVQHRSt4J?= =?us-ascii?Q?aMdFaeFj0ggNfDVt1z1Zn20AgMPSOuInVulcG0z4PfW2u/waBjz5148jCyDb?= =?us-ascii?Q?MPYuUHIhy+y2Td3kuGlPF6xYHlBMGEBqcVN9EYALtrvQ6vL4oaU95VLAttVK?= =?us-ascii?Q?ZdA3PBqWiUxLudDDOIx9EM9ZdeIK481AMTc7bGTQjHHkorSDwB0iBQ7+w0n3?= =?us-ascii?Q?ClPrM4qLn6yi17SwoUUNosoSWxV2/CNDhU0pTnl2Qb2EdGf+8WwOVBanVXWj?= =?us-ascii?Q?8Ho0CVKMYxBcFEZzYeqScyn2tDJhM2tSkNgpK+Lll8+zNOprZtk9OojwTVpU?= =?us-ascii?Q?aQWCkg5MMLnnm9nFQJqe2NjKetOc/LdrTEfhFjePcnF1nrAMCOrhdGKJnoaE?= =?us-ascii?Q?IJ96ZD4nAcs/4TctJgMRbZ7mTVXtV7R7rgnefucBt5uGosQDN/RJkEEJGEfz?= =?us-ascii?Q?uOT+54Lo8m0tGIwh+JRGuCXa13z+WhykK6y64RDUTYYbzD4rsOu2tvraDqq/?= =?us-ascii?Q?cUV9z0yDjrg7Yi31roZkBbLhdTWJ1cTYTuPf6na4eNDddkimknZfnPNOuvVi?= =?us-ascii?Q?Hiy+lMXoo3NpprgS5Roxi4J8idCLhg0b9fj6JMNdpfR4VjEJQALo+zKa610c?= =?us-ascii?Q?6KYSmn28YzN+VSh7iyrbkMW6OUF1cvCyBdy4EPHVsqEmjlpsLtqW0+hAzvNW?= =?us-ascii?Q?WVbfdOjpd3PaOujFNkA2Uwac6e8i3tl1b8wjr5BiUYp6c5Fm+1Ypb4O3G++y?= =?us-ascii?Q?jbXhmbwJNLvFiwaSe/swKpxYiXAtfFpFstdUnqVbWvwpF5bO0dYqaTekpD99?= =?us-ascii?Q?LCvNrmM2iQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 636a0464-50b8-4d97-14f7-08da3fd2a989 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:18:44.8236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7/E1biq/NjL2zz/1494dgbf/cWWAgfn6rr6S5txm2FvQm2XDIrUJYPFJFe+G36K/i5C+GYtZ5iCpSp7AXaWTfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all places where entries get updated, not just the one where entries get cleared. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v5: Re-base over changes earlier in the series. v4: Re-base over changes earlier in the series. v3: Re-base over changes earlier in the series. v2: New. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -21,6 +21,7 @@ =20 #include "iommu.h" =20 +#define CONTIG_MASK IOMMU_PTE_CONTIG_MASK #include =20 /* Given pfn and page table level, return pde index */ @@ -35,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig =20 static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, unsigned long dfn, - unsigned int level) + unsigned int level, + bool *free) { union amd_iommu_pte *table, *pte, old; + unsigned int idx =3D pfn_to_pde_idx(dfn, level); =20 table =3D map_domain_page(_mfn(l1_mfn)); - pte =3D &table[pfn_to_pde_idx(dfn, level)]; + pte =3D &table[idx]; old =3D *pte; =20 write_atomic(&pte->raw, 0); =20 + *free =3D pt_update_contig_markers(&table->raw, idx, level, PTE_kind_n= ull); + unmap_domain_page(table); =20 return old; @@ -87,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte if ( !old.pr || old.next_level || old.mfn !=3D next_mfn || old.iw !=3D iw || old.ir !=3D ir ) + { set_iommu_pde_present(pde, next_mfn, 0, iw, ir); + pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), + level, PTE_kind_leaf); + } else old.pr =3D false; /* signal "no change" to the caller */ =20 @@ -326,6 +335,9 @@ static int iommu_pde_from_dfn(struct dom smp_wmb(); set_iommu_pde_present(pde, next_table_mfn, next_level, true, true); + pt_update_contig_markers(&next_table_vaddr->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_table); =20 *flush_flags |=3D IOMMU_FLUSHF_modified; } @@ -351,6 +363,9 @@ static int iommu_pde_from_dfn(struct dom next_table_mfn =3D mfn_x(page_to_mfn(table)); set_iommu_pde_present(pde, next_table_mfn, next_level, tru= e, true); + pt_update_contig_markers(&next_table_vaddr->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_table); } else /* should never reach here */ { @@ -487,8 +502,24 @@ int cf_check amd_iommu_unmap_page( =20 if ( pt_mfn ) { + bool free; + /* Mark PTE as 'page not present'. */ - old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); + old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); + + while ( unlikely(free) && ++level < hd->arch.amd.paging_mode ) + { + struct page_info *pg =3D mfn_to_page(_mfn(pt_mfn)); + + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, + flush_flags, false) ) + BUG(); + BUG_ON(!pt_mfn); + + clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); + *flush_flags |=3D IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } } =20 spin_unlock(&hd->arch.mapping_lock); From xen-devel-bounces@lists.xenproject.org Fri May 27 11:19:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:19:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.337996.562739 (Exim 4.92) (envelope-from ) id 1nuXzr-0003y1-Fy; Fri, 27 May 2022 11:19:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 337996.562739; Fri, 27 May 2022 11:19:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXzr-0003xu-CY; Fri, 27 May 2022 11:19:11 +0000 Received: by outflank-mailman (input) for mailman id 337996; Fri, 27 May 2022 11:19:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXzp-0003Q5-LU for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:19:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d39886e6-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:19:08 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-32-VrqiV7sxN8aZYJhd7ghbZw-1; Fri, 27 May 2022 13:19:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:19:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:19:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d39886e6-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VvZXvUCO2HfiLDgA+1pEGxziHFCsDEOEbqjxz7fQFbQ=; b=dSXAWTASJpjEMXgq9T2h3PHFHKDrHbxZGTiC4hKEmyHvNGeDCOQOFIdPLYD5xdo1ujSx0z gOKdUfty0v0xm+cL8LKfWOwp9u/rtX3dtg1Acry5+YOYd+URky05zyq52TImYlfsITyTid CG+mVRFHVSI9efGlB7TjoeUKXSEQsHU= X-MC-Unique: VrqiV7sxN8aZYJhd7ghbZw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTiudUoFpZDE0DFCI96KtvMkY11r5WmBm4yroTSZEDNlg+vO+WqCbQE3UNjsZFVFS9X1tHJv3r9FL9+vQR2xgyu4qY701d+KIyaD+YTOZkZpFJpmoSpi5SJHn1QoyznSvSTT4Oq23iImmv9NbeCYq20SbMfyV9G073iWpUsK4oMl1xUozaggp0AeMQShsIqtMUBISHPtmYbBeUBQa+T2zsmVkOnMx9NdmX0SwtOkYTYwDz7XLVXLqnzlxFsw/HOpi+gHUBaxyFF5Oye0EBnzVDuu5/fNsKi6mSC6AlB5KLiQEGUaSWjVOK1pED2HLxa43G/refx6nR6ABn4QnMtl3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gp73oXP7vi27KdOxrBUVp9LMt+daZO3hrpdzDy50sao=; b=ZEPXErJ2tJB753rl9dkuc+dSj6q3BB3e4aTcjMXTJbuPb/5UC2mHLL/1nUaUqf0m42XVIPElYqyuZoJj9449Fjcsb9T69fqkmb3Gl6RYyL+SSaARRPKnqma9F2mXnP9VB8qSj9bre0CUvc8+tmqlG0rS7VBNVtx3Cv+PuSe6IpkrGGOFEhkCQwM6aPgpxkMAME/ATApVMjgS6rV7IEwJnBk+8yA2N5IpVqKOoYWNYQP1ngWDKYkK1ez3b2Ff6y4g3bvLqLNZgn6ZzGz++VsePbzr/8Ukgv9t8NmuSb0TBs0kQnPWx3MxmqnOHgqgPT0sSWZKQjoskO+1KAzF1lBJNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:19:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 10/15] VT-d: free all-empty page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P195CA0054.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 214a9375-7521-48c5-e73c-08da3fd2b63c X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F8h3UrV/HMqPmEJJSV6VQTVY0PiN3EUfjhstZKsSjA7n/RbwvPD418RcrOEw+UqN+tT4NkFXdUS1JI2fzwOwh/8FYHXqoZ1C1hjqZLyNco9+azXzHIVNEq/JOOK2fxBZwvxixLQkYkPzFvV0MD/5WTEEUxKqqPcAWL6lhtYMqYvxxdhhDjIuMN7z+sbrcY7ndITjBhkbc0ilJGHrqMg5zZFWoJqsCEHxX7tiZ+oXNjGBl5PNe/fv1TezxN4/EmqRsY4VeAKHIdBSAt6D1/0S9oCkcG6vDPOO7PufVMM6bfou3hP2nBM5L980SJFkWn9IDdD5v/Cq+0r5XViQ1lkHP0Xkigz7jtlbXc3dpM9lgFjEcwrOub3sd639t2WohOg1SHaIP52DNAsoERDjK3p+Y37P5rlein8vHVo+F278JYAFdJ4U6dVee0AOAAc6WKtJhRRAzHFcXlEKdPKceFAa2w+3z8SevWOPShtYqM8g1yYMlXdhNQorZwyVPTz+x8aqFg971o7ZwJ4hWLYGJ+bss0+ewDgJoTZRfVfMjefPR16LPKPe4YrQwj1i4Hna9Isf7S32DbvKLhVdkLYpQGdXto6VQZjyWi25MRw/k+lg0dk7n8q9N1qkTmGpyEQs7UTrMy1qKXQ7Ygn/pfnDQvxCIGimkMu9R4ZAnsbjc340ZYybf3Q8LsMM1YCRZeoewtqyGWpnM3QzN9xV2dQRuhqJBtIJKY/pUvhjhIqJ5Qc6W64= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IngeTXIAHkSvlcCwf4TFlFFobT9cos0+tPO+itz50RXk0kPRQ3u0ubTGR7g0?= =?us-ascii?Q?cOk/OX2WGNC0gIGPEa8i+Pp7B6xAWJAeAIVPHLD5WifL4HhyUbK1bHKBw5Cj?= =?us-ascii?Q?Jr3D5K+g83koXjr0MJsKPsBaT/37uKeNK9LSfwtY8mVJmiRBqVwqWhzCEU/O?= =?us-ascii?Q?XqVsiGEgIe/2CrMkzik2gDM8tGq8SK8IoDv8KGi/+dz45jzZcksHqtpc/pKv?= =?us-ascii?Q?H4uTHEuFi15vOAnzpfwDdOc0yntww8Okd+OXaZPW5SVQo9JAJ9/Juya7VVCe?= =?us-ascii?Q?6OPDe8fmJEEfQViavwdJuapVcAjNIQyLx/dXXW76MAYiGDv6TRKXk4BRbc/G?= =?us-ascii?Q?ebyl4/39jeEjXyw0uttJqv03k7rqoAh9f4uzgV0PcEhwD63a0oT62PL0DUwQ?= =?us-ascii?Q?Lr/EVJqstpNHTB/eWuHwSGR3VHviXaUiUWb1FohKxetpbrLloh0u+dlw1yK0?= =?us-ascii?Q?yMJ1SUDCgI5qmXV27XnyFpdMojaqby0XYZ/kkPXm6vujsTFur3OHyAq6D9dM?= =?us-ascii?Q?WQ5yNiNanOHjqvYuEZJONOaQm5TEOpW3r4AFUpsCMj2a8S/lHM12nhPtCjpM?= =?us-ascii?Q?HBXqNnmpPqnnbSyz8zkkok1/4JdmfVc2sGM7kYfFyNcaCHgRHgziB3tSdOPS?= =?us-ascii?Q?yIyC5rQ5zXZYzbpdn42Bh8AhsV1MCMqOgZmc4lGmTmOfJ9Bry5VdqJWmZz2B?= =?us-ascii?Q?yDL51P4aUgYthqM3GMudaNIpRJQol11YL+nibYVNTkSniyJP89TbqbtLJHgq?= =?us-ascii?Q?P8XWSHuDaABMefcOvqO9uqkiynGokupyYVca7R8znP264LQBKL8Da6OpMei0?= =?us-ascii?Q?gkbjhIi/B8ilhKPcDGvowfSDYaXOHZaoj1U9oMi0eWL0rpYLGQ27VFiYZ4pY?= =?us-ascii?Q?IdLY/SMOqoSOqsx2ecjy93288t7s1+2Vu02NmNDnf1GpsajCkdXOXV3DBzfz?= =?us-ascii?Q?VJsizGYSrOx+OXLKyROD9Uhu9rc02z+S5O2f/xaEKqbwjZjBwVEitHu9QWMN?= =?us-ascii?Q?yPjJsfgEZkJ+ADNFvbmEQ/e7Fx7WXGGi2eZ5G9EGqNulVbmxEppRSUIUc3yF?= =?us-ascii?Q?RdUW36FyRiwjC88MYh4zgrNJmn9DoruT0XuKRPVLfejVYjOKW6K1yXmMhtTc?= =?us-ascii?Q?KYyOK5AaTKPRW1qcE6MDXI/MC4a297TJJNctPjolOD4gz+IvPhYmqORICt6E?= =?us-ascii?Q?eJVkfYmqCS9jX3Goymvyqv5CXjFy1+MX8IphjBs1oK5qoHYANKcb7OdIWy/o?= =?us-ascii?Q?qrvDPiS2QSXmtuMff+hOLrwY5w4y/Px0j3wDi27zM0hvPQm+etKoWImmKnq/?= =?us-ascii?Q?Y+PQKgwm6L+BQqBR6Vadc/RC6A19Xi3chvp6VmiyIbuuZXkRHemyFVI1F0I1?= =?us-ascii?Q?hqjunJlTVNs2joqTEuxqBAKtEYUzFgdOzMcxwPR0I9yhe7+RDLNRLFlDP7UW?= =?us-ascii?Q?WfU5hBZRybZDTTSfHA3Mledz5oH7dzGmc1lnKwzDzy8p2X3i3OZqJ7Ye3+nE?= =?us-ascii?Q?wDMEqgjF6J8ChdOCKMIBR8bUTq3+z3QC9leuDJ/eYqCNXf1Z4e8aNfW9qC/a?= =?us-ascii?Q?KIKSj2OmIyVFL6sBKgURZtvMw+Tzroe6rC6w8EcigdKdrnwqPcioXc1MC3hX?= =?us-ascii?Q?7qBsp3uzewzoza1KSSk9dBiuiosxiE+NOcAHHk+Br39iqkSEmwVVW31l7Zsa?= =?us-ascii?Q?rAcJFBSNVTJHFdug0BrzbixwIYJ/fHwggzg3jAoFYjC7ndNzTSEKg8zI56AP?= =?us-ascii?Q?q5rZDm8tZQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 214a9375-7521-48c5-e73c-08da3fd2b63c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:19:06.0879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JT9xBbFubXtuG9LNEJnHd5u8sCtEIUqHhGnmqKl2nLJrFMHf+ZNIpSPb6/dkaZLf3FnSArP/YkXv2JPeEhUjyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all places where entries get updated, not just the one where entries get cleared. Note further that while pt_update_contig_markers() updates perhaps several PTEs within the table, since these are changes to "avail" bits only I do not think that cache flushing would be needed afterwards. Such cache flushing (of entire pages, unless adding yet more logic to me more selective) would be quite noticable performance-wise (very prominent during Dom0 boot). Also note that cache sync-ing is likely more strict than necessary. This is both to be on the safe side as well as to maintain the pattern of all updates of (potentially) live tables being accompanied by a flush (if so needed). Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monn=C3=A9 --- v4: Re-base over changes earlier in the series. v3: Properly bound loop. Re-base over changes earlier in the series. v2: New. --- The hang during boot on my Latitude E6410 (see the respective code comment) was pretty close after iommu_enable_translation(). No errors, no watchdog would kick in, just sometimes the first few pixel lines of the next log message's (XEN) prefix would have made it out to the screen (and there's no serial there). It's been a lot of experimenting until I figured the workaround (which I consider ugly, but halfway acceptable). I've been trying hard to make sure the workaround wouldn't be masking a real issue, yet I'm still wary of it possibly doing so ... My best guess at this point is that on these old IOMMUs the ignored bits 52...61 aren't really ignored for present entries, but also aren't "reserved" enough to trigger faults. This guess is from having tried to set other bits in this range (unconditionally, and with the workaround here in place), which yielded the same behavior. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -43,6 +43,9 @@ #include "vtd.h" #include "../ats.h" =20 +#define CONTIG_MASK DMA_PTE_CONTIG_MASK +#include + /* dom_io is used as a sentinel for quarantined devices */ #define QUARANTINE_SKIP(d, pgd_maddr) ((d) =3D=3D dom_io && !(pgd_maddr)) #define DEVICE_DOMID(d, pdev) ((d) !=3D dom_io ? (d)->domain_id \ @@ -405,6 +408,9 @@ static uint64_t addr_to_dma_page_maddr(s =20 write_atomic(&pte->val, new_pte.val); iommu_sync_cache(pte, sizeof(struct dma_pte)); + pt_update_contig_markers(&parent->val, + address_level_offset(addr, level), + level, PTE_kind_table); } =20 if ( --level =3D=3D target ) @@ -837,9 +843,31 @@ static int dma_pte_clear_one(struct doma =20 old =3D *pte; dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + while ( pt_update_contig_markers(&page->val, + address_level_offset(addr, level), + level, PTE_kind_null) && + ++level < min_pt_levels ) + { + struct page_info *pg =3D maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flush_fla= gs, + false); + BUG_ON(pg_maddr < PAGE_SIZE); + + page =3D map_vtd_domain_page(pg_maddr); + pte =3D &page[address_level_offset(addr, level)]; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |=3D IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } =20 spin_unlock(&hd->arch.mapping_lock); - iommu_sync_cache(pte, sizeof(struct dma_pte)); =20 unmap_vtd_domain_page(page); =20 @@ -2185,8 +2213,21 @@ static int __must_check cf_check intel_i } =20 *pte =3D new; - iommu_sync_cache(pte, sizeof(struct dma_pte)); + + /* + * While the (ab)use of PTE_kind_table here allows to save some work i= n + * the function, the main motivation for it is that it avoids a so far + * unexplained hang during boot (while preparing Dom0) on a Westmere + * based laptop. + */ + pt_update_contig_markers(&page->val, + address_level_offset(dfn_to_daddr(dfn), level= ), + level, + (hd->platform_ops->page_sizes & + (1UL << level_to_offset_bits(level + 1)) + ? PTE_kind_leaf : PTE_kind_table)); + spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); =20 From xen-devel-bounces@lists.xenproject.org Fri May 27 11:19:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:19:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338005.562750 (Exim 4.92) (envelope-from ) id 1nuY0G-0004ZP-P0; Fri, 27 May 2022 11:19:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338005.562750; Fri, 27 May 2022 11:19:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY0G-0004ZG-LH; Fri, 27 May 2022 11:19:36 +0000 Received: by outflank-mailman (input) for mailman id 338005; Fri, 27 May 2022 11:19:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY0F-0003mu-Ql for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:19:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e342c681-ddae-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:19:35 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-MUXn2TkgO1CFstY9F908aA-1; Fri, 27 May 2022 13:19:33 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:19:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:19:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e342c681-ddae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUFaGQ6IIZ0mSnkSmdZGDLADzXQZSEblHdc1xu2R4MQ=; b=m9baytdMN1j7lHF/gkt3ZtUaM9AsF3eN0OpXLj2uMK70ClJmYXHnDczZHF52hLZEax0sfn ty/k1Uji5uvA1jHlLic0kRNYNIdweMLjlt4QE2Fz4YrGPvd7VM5xctzYm7iP7Omboz/qHQ edmJwcHSqlxK96gHgsWZ3vBBIDN9SMg= X-MC-Unique: MUXn2TkgO1CFstY9F908aA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHpu0BtdT1Lw1BCzvt3xSSnNYvdrC9UH/PbGr/CnpBRWurOdXNqs0A2ivbae1brsWWtHlOw3biUxPDD5KlHUvgbkLs7wm3I8tsIwechTbKrTbYdCVxCLyslZjBplyYcgyDwJFuzptBDkzu1cnW2E8zT/mfNaxTfPheYHf/Dudu1rIIFr1gURz6klT7fsITKXe2Aeb1FKLGau2/hXWvVm/44W9Lw//9Ql86aQHYpjgNq++xgutkIi1UYQ0VlgEhNp8t50MMzQR3DrBTyQqRzA4tI9fCWiexejUwdfdSrf7Vnw2kJasAwnzjO5PVv8os3HyyTsCDO6ivH+G2vo5bQfIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpBKX8iKhA8N8952sSDbijOunJ7uuUUiGIDbjZy4Htk=; b=Jd4oL0qUyEBkZl6TKbncabZ8064FdzykCRMXzzO3uVg5alcAVA8X9Q8QL/m6VFKoK3ZJnWV5jIomxU3PdREBJ3pPwNyYi0hQgSE93F2JTkEksh0ClzOq/YLg1LzDRGZrqvzMfsFWW1Wng95aZbTVSpGrCxG+VQ2lCAsFXpJDaQ9xdSPOgyZuvCUMzbl2l3+sOlMuVcTCjTnvABFzLfirS82CXoajNMjbWw0pE+PVWFXSyMa/N+vznzjMilabGiObTlDxmSaaToE25bKbYRAg22HdtDdWdgS4VXz224xhYCIRV7t2MTDniEbunlTgH2YvJ2q2GR8dZ40AFCWCoKNQXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e9c8019-9318-280b-98c4-81c0c1b1d558@suse.com> Date: Fri, 27 May 2022 13:19:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 11/15] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P192CA0102.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::43) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17c3e8c0-0410-4a2d-c737-08da3fd2c48a X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bi9MKv+LLOr4dZATwU/CeF+D3xiTIOV+u+P1S8ZNDISmU8YGmvgivZeCVtpC1G4XvANdJhIiBcZ+FiQ0WCXBH6PRh732wd8oWUC6JZJBkDwx2rG/QMepUSG32whSdTOIRvCt4lcNSSfDGTzyyH6OzFG8cs5Qx79BzH38MDD1BCDopXYX0ZOuv3Fvuu1zGsgJ/kSUX4AF9KgLWB5hJb++FaMLYYLR0fDmrhrVDOBMl3TtRaAJ1Cgw7Ct5SIut+VBlgjNLMtBdFlE0uFiA2r3zZfLdUMfdiMQ/IWdoQBFDbnzHXmTsXq4ix7aRTyKaesqdZZ3ZsuGBqGn4FE9tRVqwRq74Tic0lcu3fgDmQPgz1T6MFGiY1muYMGwhqtwZ7IMzQWUiiCKZvQsGvkWWDA7h/26/Ks180OOfCqdxMBy8CKkFprIU1tgVA5fzzalAKzFJkjtnT87xigWVM6Pio6yVGE0vSqxxAcuzEwJLpS6Y1F3kNXv4U2PLszjB3eb18CmjGWQtj7W387MgpAqR/L9nFOc3Tr/CnW2ze8MYiO8vBK58yzFF8Aq2kqqewkel3ALSK27U2qYpcYU6yHx53x4YRHuULBkrAJgAuB5nRM0GJkJ64llKptWx0cxCw4rHFKAUBCokW/9dWia2mtaNSfjxkNthmGijvXRR0XmpxresdjWZJ+d3XbToDUmaCDUS0hcLdGOkYZ3XeBThxxLYjdW657VkP0jwyhKtYg5bzRPauhkQAZUsQAheOzXwAj2nNxrC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EJHUuHiIagACBR33f8poW0/DOaOqc2jmVyflSq8WA4pTwjlR3Gnxv7WUq8Rb?= =?us-ascii?Q?7Vlks8QWEp8JW15HgA0UDTQpFSrYg3bU2eSX/P8Ofa4acw0h9GD/qXDrOQbm?= =?us-ascii?Q?GtINsWq5fm4KtwpSa4/+39jhyBdyOPGOS9gvSOz6yQqwxY3QVhqT0B1IntQK?= =?us-ascii?Q?o1dC+4ZjnZPh7V8hsGO98nIJYeDQyPx63WPv9xUX7nNy/wUEViS1htrd+6CO?= =?us-ascii?Q?d6aMT3yeNeIQ9wsBONWfnVIWBlcUOOymMq/O0JbiyBSVPZF73N2wpJLzovOJ?= =?us-ascii?Q?YaaVslC2WIHTNx8XXGYHQFVGneUFx1NCO1lpzYcff1CJWGNg92WmX1hfYgja?= =?us-ascii?Q?s+9sZOMAe4asEkNpuRQQsLYkvzkJNt5sATTVV/OnBGoqMNBSs/EhgrWpQAHa?= =?us-ascii?Q?Ni4FhrNAi6G8JBdTJopRlRbjbbkz93k5J8mrEQmRjMtOihZCvNH24qJSebul?= =?us-ascii?Q?d6UPWDHvtnTEraYiW+6P9USULTHJO9j7dQsMfqxP/D8jaRSl3Hj0a3jTEbtf?= =?us-ascii?Q?Mj2703/65u9HWMiBp3G3FMqxHi8XtO/n2zlxGT64OhMV5kUja3CnGnoVU9JP?= =?us-ascii?Q?0D0R4w40QMSGKoKwvO5/TS6Qyal8n/w+7+pS+OFbA0dGUy9ZBQ3o/5knUg4+?= =?us-ascii?Q?aDj4M6iA6pu26dVDlhse10xfJXw2wjf7QwqdflfQOFIgzKfKt0GW6+F67ZRM?= =?us-ascii?Q?Bd7+u82KCwPip6dKf9NuohmREWA//UyppThYSvjlcD2pRncS4vy8XvfTR+F8?= =?us-ascii?Q?e4i+G0RZxQ89/tO9mMr8dH6qsm5RvRuJPR/rAgVkfTZx/MMLbib7kJ8bDbjI?= =?us-ascii?Q?3J/plAxb8MgSrF4c2OWaOKx9qLGrlWRWxSqDnLN7UIy54JCpT87LM3ZsLmy0?= =?us-ascii?Q?rp4uQLC0fhP/wjkEuHFPgW21Bq/IGKygIP4yun3hLiikx5dWLzVJbOi94Ucl?= =?us-ascii?Q?o+3MDUpgpVIKblCUhtLs8yIQZYjLZ+fQiBnT5+6d8KeEFpcMS6gvytD2vS5m?= =?us-ascii?Q?A7h/z9ca29WfG81CVAicshlfadCaeocQkafHI7xBEVFnmrjPec5app/vKMQ4?= =?us-ascii?Q?ugQZXIUQ8Z3oaw5kp4H2QdOTO6E+P7c0E6Ar0Q1+XR0/Z+WW3UD3Mn+ctAaR?= =?us-ascii?Q?hRIYtHwtCYQjNC3p1sBCf0O7VXJiG5AJ+ghIkZw+5+AY50JfmM4RFz5hVFZX?= =?us-ascii?Q?/yr61hy4ftEP4+c1ZIBIKRJ+LXfJ0P419H+eqlGEfYZ1EI0hsRUruzSLG56D?= =?us-ascii?Q?0qnc/Pb5SHq9rcC15su0wRBZoJBYeR8fAVfb9tRhqh1glhysXvfWpIyi0e3o?= =?us-ascii?Q?OMkmy3cxnssH2SCPnYrZWunhcegHUmJLLNxntsmjXdk6vrxVAhb4Gy60bnz+?= =?us-ascii?Q?d17u81JIZ3FFxfFORv1t8QcceuOe/97BfUwcl+y4EUutR6sfms+f0HZwofLl?= =?us-ascii?Q?E4EoNiJlsNkMZZQQr8bA/U2NpcogRKTTgPF96wAq0Vf4RWNhoapIK+/ScJ9D?= =?us-ascii?Q?SxNidHJ9v3V8HsHh4yqwqt3+/h0B/pRg/D6pHOzkx7YNEDps2Im90hjpScCh?= =?us-ascii?Q?mOcW/wqFhkhr9E/yIRrwIbi6aFpCeIJCi8/LSeFXDi73yQJdDvlaOi5UM4Kv?= =?us-ascii?Q?M1iJvEilAV/hLB7mZk+eLjtfTP5bwrZP6kPwUZ0iCugkR5SahT33kRa88yBR?= =?us-ascii?Q?1CzO/vYil5Ttx3m8eJ26RIal8yYarJBrkGxg4lrACz6lbF7bMBiwmCDaLWw3?= =?us-ascii?Q?735JZCLdnQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17c3e8c0-0410-4a2d-c737-08da3fd2c48a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:19:30.0864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CPoaZDDBUz3i6vdr1Dcveaid17xFuxvbsrqoTec0cd4aa4t/rm/Z+8A7DudsWVKhpQXtXHS176mpL6rKg99wMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- Unlike the freeing of all-empty page tables, this causes quite a bit of back and forth for PV domains, due to their mapping/unmapping of pages when they get converted to/from being page tables. It may therefore be worth considering to delay re-coalescing a little, to avoid doing so when the superpage would otherwise get split again pretty soon. But I think this would better be the subject of a separate change anyway. Of course this could also be helped by more "aware" kernel side behavior: They could avoid immediately mapping freed page tables writable again, in anticipation of re-using that same page for another page table elsewhere. --- v4: Re-base over changes earlier in the series. v3: New. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -81,7 +81,8 @@ static union amd_iommu_pte set_iommu_pte unsigned long dfn, unsigned long next_mfn, unsigned int level, - bool iw, bool ir) + bool iw, bool ir, + bool *contig) { union amd_iommu_pte *table, *pde, old; =20 @@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte old.iw !=3D iw || old.ir !=3D ir ) { set_iommu_pde_present(pde, next_mfn, 0, iw, ir); - pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), - level, PTE_kind_leaf); + *contig =3D pt_update_contig_markers(&table->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_leaf); } else + { old.pr =3D false; /* signal "no change" to the caller */ + *contig =3D false; + } =20 unmap_domain_page(table); =20 @@ -409,6 +414,7 @@ int cf_check amd_iommu_map_page( { struct domain_iommu *hd =3D dom_iommu(d); unsigned int level =3D (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1= ; + bool contig; int rc; unsigned long pt_mfn =3D 0; union amd_iommu_pte old; @@ -452,8 +458,26 @@ int cf_check amd_iommu_map_page( =20 /* Install mapping */ old =3D set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level, - (flags & IOMMUF_writable), - (flags & IOMMUF_readable)); + flags & IOMMUF_writable, + flags & IOMMUF_readable, &contig); + + while ( unlikely(contig) && ++level < hd->arch.amd.paging_mode ) + { + struct page_info *pg =3D mfn_to_page(_mfn(pt_mfn)); + unsigned long next_mfn; + + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags= , + false) ) + BUG(); + BUG_ON(!pt_mfn); + + next_mfn =3D mfn_x(mfn) & (~0UL << (PTE_PER_TABLE_SHIFT * (level -= 1))); + set_iommu_pte_present(pt_mfn, dfn_x(dfn), next_mfn, level, + flags & IOMMUF_writable, + flags & IOMMUF_readable, &contig); + *flush_flags |=3D IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } =20 spin_unlock(&hd->arch.mapping_lock); =20 From xen-devel-bounces@lists.xenproject.org Fri May 27 11:21:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338013.562761 (Exim 4.92) (envelope-from ) id 1nuY1l-00060W-47; Fri, 27 May 2022 11:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338013.562761; Fri, 27 May 2022 11:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY1l-00060P-0O; Fri, 27 May 2022 11:21:09 +0000 Received: by outflank-mailman (input) for mailman id 338013; Fri, 27 May 2022 11:21:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY1k-00060H-2E for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:21:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19e57dd7-ddaf-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:21:06 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2177.outbound.protection.outlook.com [104.47.51.177]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-1zjZN68sNRC4HqIvRuFawg-1; Fri, 27 May 2022 13:21:04 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2522.eurprd04.prod.outlook.com (2603:10a6:3:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:21:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:21:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19e57dd7-ddaf-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rr0SXJIhqPFcpvsJUpdSD/Fb1591DtjkDEfmbHUCDiI=; b=F/cRumbzNzCbFN833TDbFSLzxr3W54dszlPH/EYYJTBT6EOmBodRmJ+ht2Y5oE1q5PLz1g VH/SLfYghGTBhVMgRNdLax6YlQkxqPLKT8oxRXjq6trN6/wXVdhrJtYKxPsDi9bqexHf3q ZEVPZPMrHtVU3bm2R1CKNjtJBURSH1I= X-MC-Unique: 1zjZN68sNRC4HqIvRuFawg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gg5GgiQK7GxnOkQBy0ekPu4MajoVvJEV0hZqPj61oyOnlfAw8SUGjztzbKaiiZkWbjkj+q7o/yqqWFcOdVzC22oWYZV0FigGAOK+5NGAflc+lUZZtAgSWrrLYo/ozcScRZkdbEsr7AMUpD6ZnTg7EiH5pMEnd/D9VlIJdQAKjECYIGwB0azW10B0dzai+kQ0WT5FdYeJtG8JLR+vf4nSuy0QcgOuuqWTW9wMrF6yi0trptsV9TpKchhhzcvDfT6Znrm09meiC9eaMcWqK9yYCj15bLchntAlPgLP7arZqbkcF8YZvbo1b3CA45vvYTatZkjOEnMpKgbwUN/+3t5qpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PX82Sk7UOiPch4uhVxxmVUF3Sh6BPeVOjcXNAE8rHco=; b=QPIhT6f5jvDnzNwQejsIhmtXyam2qq8xHit2VlT0uIdtJRC241ZgoTulYURYOn8xf7M27yiZDPORTGRK40ij+0Kc6xNqQGnLef+OLfBVu97fY5Ah3Wjej8MfWWNj6LsnoPz7LDH0LycSg2x0zR14HWGbHMRM/xw+4fiPFo3X5XLDVmZFDfWf9Z8ANGiEeKKUxhHj3mSQ3IAI5TWrkbykEIPufVRHS8tC+Q2OzH/mNkiWRWBtDqhlHARCgbwuBI4harMfZQwGnXm7LguXcSKgAUMNylc8wBezuvVhd8mwi/hPcBlGgWLc+nxLFHZlJ8rB3zZL+5prowiWqVrsufnCfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:20:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 14/15] VT-d: fold iommu_flush_iotlb{,_pages}() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0601CA0056.eurprd06.prod.outlook.com (2603:10a6:206::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc6041e9-9271-47c7-00f6-08da3fd2fac5 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2522:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JGQdM8r22Jw/tfmi6W3x2n6Z6RtW9U86d+8vQ+xEiB9Jp3M7V0/tGGDwn2ga2l62ee6nrSdKpp8yZ+/eFK1nOS421dpHOP6KxwisknegyAkYzpq9CMzi2jPuFyrleYZJMbA3eBolHQwxGioCEcWRHAM8kV/yOswG4xWfjMUZR5FV6Y1wcZDPHJtq4M9HqpepbC/5/snZXJtEsebjEIIYRuS/pMSkUya2Dba17K+OEuKrjW69YoKpHOrISrFGREceOQ02kQ7PPBKwqOrnG02zpADDK7Xr9COACLptoBmSP7bzmDFbAsjur4/L9tlNiOlyNct1fAcgYwJ1WTikkDRyHbIYedw/03mzCI/vlP2Bt/XyKu1MkCfWFLdJsf7Yi94TSaCu/tuNidf8cxMEZvLLhF37iCqfdknZmS21Y6YNl0qIW/cCrenQq6pdTc/L9RM1k7d+e3tlElpPFsFE0TIfaWDjOsKB70+WKBoVsXsDC7z8bQ2CrDYTzA0MQmfinGpd7lQt2LtA80B702+CqXaoEvsG7ZrF3YjkXAzannXG87E0pKtf4G7MVzEBg4ITnRu2Oj6JIMKxYA6Uu8okfOd19wncZgYGeCvhx+ph1nOZ/3C0rKqR5XwaWRVUPZaDZLijoVZF/gFqmkGHFXz2Ep+UriDsdR3uuGn/9ZO9o7sN/4wBBx2R5fbnvgBzxUzueudIn0v5BMfsO03vz2yJyZmiuoEV7GLBPm3ZgVJ45zec7t0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(26005)(6486002)(4326008)(6512007)(66556008)(316002)(66476007)(508600001)(6506007)(54906003)(8676002)(31686004)(2616005)(83380400001)(6916009)(38100700002)(186003)(36756003)(5660300002)(8936002)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dKiQNOXR4eZDvv5LlULs8+oMhayf/w2YR+63S8APNo7JEKozvak+491+3nrQ?= =?us-ascii?Q?noIGsnYo+k9AJf9h2WDZK/7FnsNxzZh/lgBf1LWSpBf1K5MaleynO0zbLfgE?= =?us-ascii?Q?2Nqn0/D7hf6JlbruOe/hicb2Vx1NQxJNnNDSnPqr6YSDtwixxTtaEG0C5zGB?= =?us-ascii?Q?Mg0Y/7M5Er3II0KPBPrYeE+l6MT5JisT52jsbGSnzbLvsv/qPRtA4keuPBDm?= =?us-ascii?Q?e8wQ6NY1grRZOHwh08lDGdHQyQHUmZdNTPKTbiOaa1KMB5mzseLqbRj6DF5E?= =?us-ascii?Q?vZ+t92ymo0s5NvayrtVEVKPiI4Z/MYNqLVh9krYnUP3zC1wBd3bEIX548Pww?= =?us-ascii?Q?QH6+ak13ERX4ySp6kDYXj6G8tklPElJEbnhEEtk6vj2GLnBFRAoeY6Wh7lKq?= =?us-ascii?Q?WvyQuEnAYbXmtkU3gLRGMB3tN63tSTXb0Wj1YdQDqj3E6oq6M3UEMWWyRwlU?= =?us-ascii?Q?h2s2LluyKx8/sBIIlsm3x5Csigt6rBpHGTA0YT2A6/wEmbS3OZjYJ77aebe8?= =?us-ascii?Q?tRehojUnvQ2ToJ+wKdb7KiwqeIRVW/ARghEhPFfpcWGqYpy1tlmnF27oxcNu?= =?us-ascii?Q?iIr4Jp3kgkBaOB7JsL7izhAwCMmHHu9Cpq6Xik7hDOUPNO/QSGj7ULVKIhNk?= =?us-ascii?Q?mBoSu06m+sRu7/N5JNIvh2+QYLMLhKRn2fz/or4ec78JqvuH+0ci0jB/v2Uu?= =?us-ascii?Q?96wb5QWCS05V6eyTKgT60LjqgIBGEMj+GDr9XLTugRSW5Li+SeemN8lS5GsO?= =?us-ascii?Q?7+p66sy49EFzEt8xzx7qhsCsuWpxDuXnbPMVKPDU9eW6q1zEzrfL1FWuTd8w?= =?us-ascii?Q?hdepZ/4vqHfvhl8bGIVhm3ML/7usMTJLb78NN3hrhXxcrMb0rpx0FHLs4PS3?= =?us-ascii?Q?9bJQI/fB03IRxi2zIwt+xDSLEbQFIcd5kg0nHZZd3HXiolVUxvqKaQ4KNQVw?= =?us-ascii?Q?nSkJtfZOv8GLRMFRrE6OjMTCPcR7wSj3DigluxgURlwrQepUrUKYe97zil7H?= =?us-ascii?Q?kTcrzg8UtdgtJqNDRbAop0RWr5Pma4L8iw9npva5LdyhMhI7gJap5NABYrXM?= =?us-ascii?Q?vD7PKjb5xFM9OgG2O6iX5ezGWzRT0ybHSnYiCOxwfpdEMfwy4IWZK2G/By+z?= =?us-ascii?Q?lIkWRYy4d6NwZkSkl2AGBUrCVa7zAVlPBAY9JoXU5KGGyJvM1Q/rzfF+zZJN?= =?us-ascii?Q?nUGhzEA7RVQciAOP196qHcTTJwhAT9nmx5YBapHfSeTaS0Wm7RXOn4z0cUqv?= =?us-ascii?Q?angAvTfghB8JWNu9hHBjRPkDiOxZNX0zYoEcEEPvG1M3qc2QH1cRbaevTv9y?= =?us-ascii?Q?yXd/EGR4fh4TkuN1JXmTOhuap8cjc2NJkJnxXA5Xs8b+XeSy+72pLTVEFoJ5?= =?us-ascii?Q?ed5JM3oYmYDB5id/ViA6hYu7GkkxvDY7hmJ2/gGdeTwFPbJlPRhgiIjMLM7Z?= =?us-ascii?Q?pSJnaDfw1L4H/pYOYXTBPFgmzoCSBsuYaDyt5DSdv4cPf3ZcsasPnd4wUvBF?= =?us-ascii?Q?uPwE8m9vMLQ0XNoVmwhhwphZeDjjBkshODkBrqNSpb8b50RzM8B3x6r3QK48?= =?us-ascii?Q?Lt2fOaO7LdJwSnqh+ATUdKK684Zeb1ZzQt2xIVDNriR/6VRYgwrf1/ZmW2LF?= =?us-ascii?Q?0u42cbROInt2oon/p8lxPFOFxUZdgxobIZtXAs6S4vLA/UCEZEYHlCwy3Wx+?= =?us-ascii?Q?04IQD8sp5QxYHqb2IuHdaoMCTXUJQSUzrAMsOLDqZqyy8fjAhwTHH0vcLS9o?= =?us-ascii?Q?SbLXncSdRg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc6041e9-9271-47c7-00f6-08da3fd2fac5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:21:01.0493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6/m1hy7JSQQDdrgO/ndP6seZWS2YMqSzgbJe71DfsVA3tBk9r8y2Xdlpgnf2YYP2ysYQTgvc+kRBAaLra8PmwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2522 With iommu_flush_iotlb_all() gone, iommu_flush_iotlb_pages() is merely a wrapper around the not otherwise called iommu_flush_iotlb(). Fold both functions. No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monn=C3=A9 --- v4: New. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -728,9 +728,9 @@ static int __must_check iommu_flush_all( return rc; } =20 -static int __must_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, - bool_t dma_old_pte_present, - unsigned long page_count) +static int __must_check cf_check iommu_flush_iotlb(struct domain *d, dfn_t= dfn, + unsigned long page_coun= t, + unsigned int flush_flag= s) { struct domain_iommu *hd =3D dom_iommu(d); struct acpi_drhd_unit *drhd; @@ -739,6 +739,17 @@ static int __must_check iommu_flush_iotl int iommu_domid; int ret =3D 0; =20 + if ( flush_flags & IOMMU_FLUSHF_all ) + { + dfn =3D INVALID_DFN; + page_count =3D 0; + } + else + { + ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); + ASSERT(flush_flags); + } + /* * No need pcideves_lock here because we have flush * when assign/deassign device @@ -765,7 +776,7 @@ static int __must_check iommu_flush_iotl rc =3D iommu_flush_iotlb_psi(iommu, iommu_domid, dfn_to_daddr(dfn), get_order_from_pages(page_count), - !dma_old_pte_present, + !(flush_flags & IOMMU_FLUSHF_modifi= ed), flush_dev_iotlb); =20 if ( rc > 0 ) @@ -777,25 +788,6 @@ static int __must_check iommu_flush_iotl return ret; } =20 -static int __must_check cf_check iommu_flush_iotlb_pages( - struct domain *d, dfn_t dfn, unsigned long page_count, - unsigned int flush_flags) -{ - if ( flush_flags & IOMMU_FLUSHF_all ) - { - dfn =3D INVALID_DFN; - page_count =3D 0; - } - else - { - ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN)); - ASSERT(flush_flags); - } - - return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified, - page_count); -} - static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int= level) { if ( level > 1 ) @@ -3266,7 +3258,7 @@ static const struct iommu_ops __initcons .suspend =3D vtd_suspend, .resume =3D vtd_resume, .crash_shutdown =3D vtd_crash_shutdown, - .iotlb_flush =3D iommu_flush_iotlb_pages, + .iotlb_flush =3D iommu_flush_iotlb, .get_reserved_device_memory =3D intel_iommu_get_reserved_device_memory= , .dump_page_tables =3D vtd_dump_page_tables, }; From xen-devel-bounces@lists.xenproject.org Fri May 27 11:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338023.562783 (Exim 4.92) (envelope-from ) id 1nuY2B-0006tT-QV; Fri, 27 May 2022 11:21:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338023.562783; Fri, 27 May 2022 11:21:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY2B-0006tE-MX; Fri, 27 May 2022 11:21:35 +0000 Received: by outflank-mailman (input) for mailman id 338023; Fri, 27 May 2022 11:21:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY0j-0003mu-8i for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:20:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f366a85b-ddae-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:20:02 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-44-_zmL6YhwNZuTX0hg1el-9g-1; Fri, 27 May 2022 13:19:58 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:19:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f366a85b-ddae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ccB0FqtHHL8l/2emiNG86bYyLELu/eicE503PEmq7h8=; b=WjtNNSvpY6yp+prMCXRILKROyfcjL4tXe0VB+hPcTFVjkTfW3jdXuirSKVghZEHoVdLFEg UuR0EDWa/+0kZOF7OeZ2LpfkQbiMMG8w/DHlw9iqs/nfoI+M7T+eF4M13DCjKer//l75pu 6idjsOhCierLIjThgA8W+F2hsmxW3UY= X-MC-Unique: _zmL6YhwNZuTX0hg1el-9g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hqcgB5aCd9CfB+WL5HOGL6Ua+tmEhP2YNYTgvtbV4alIZ+OZcYK3mUBuy8Hqd+3zhjB/b8PfCnGg7rZlkOTVDJucdOPfJMeK611Oq7DFaJA3zEn2jTj8cs5E1mgLbwLS+Zs8zgVo7BEJzQ+EpKZ83rRZnVyXHSknd/czI9joQB74mg2x4gqsT3hC84oati0FtEiKSVeVxNfIViMnjW3lHXLZ3k8Htk1GXw6814704dd4NEcIdZ72teIv8kQ5dlg2+1SBxPltuolMTCFD9rQHhC3OzyP/zzgPpruh4LhdKfmtEpd5vQUBizyN+PGlcWBkHo6Wi9+3seum3afkSfKYGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ccB0FqtHHL8l/2emiNG86bYyLELu/eicE503PEmq7h8=; b=nR2wIqM8czn0wSh7TaziZ3IEC04OaQprfOliqW78kHzM2XWN3CTwdZIBs1ygUI0Q0YOFiEEA9JYB+aGkAyx5t3zIz6F91ydM4NhL9lrvnvYMKBIUxsXDS/72BpNy5WOE1D6g6g8rTrhNfQi0AKveXbOsyfk4Lx+cLAsJ/HtdKxCuQ2yEN/ptzP8g7mbdMLZdmkDGBZkUFjm/77br35ZOmBhTsxcK2vZLiKs3qMI+JNuu/z1Ah1oscZEer4J6rC+0FjIFKSWkaJnNIYm5ElvCe4+kvb7kkFs0T5kqFgZ4lmB8pEkDeNp1FgEqWcTlyyLf7WHxO3yIu6d7H4v8n2b0kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:19:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 12/15] VT-d: replace all-contiguous page tables by superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0249.eurprd06.prod.outlook.com (2603:10a6:20b:45f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d92381c6-47a4-4cb9-8c1b-08da3fd2d48a X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W44r6fVakDa+hkDWyb6nmGlaZsN51S5U0drRzYW05Np8DYGEmw6yRUDhKLxyguTCq0YV0+5z/3IOD7CPdRGWVTqIuJJAQw+DYtns5Lejd3zPt1yLgE4S3CwndfdeD1rxfvtBuw/Kld+iXG9Sp4HmF5iKaKEhrzhaWPQDA5xLXRzJu7yRdoGcV9OzT5R04gsOfPgRvJBlNmMMfh7gn5E4C66Fla9s7l6iP74/gf+HITnsQNzZ2ylij4OF2r1jYZsCqX7k2FdPrAy+gM7q2pIp0NgLpKk7iXjh9G3HtGVzzIZgx5T8YfvxC3HhKXJEKLktZ+mdKWjcJGf1ZlsUiFCfwsUJqIG5fo7LXcO/HudW8XItA8j3bL00PEFu+HgsCLlnL8VGNiP12qLI58oTrRJxGvpsufDVdMcJQWutRE6Rv3lRDAoj28qoE6Hn4519gQKJ8mp8SQCEZkaOCLoFvkxoROIa/pCycHIu09kHIEU/G+b/9C39TlFUmToe/3Jnew2M9TJkSbCF/VXJ71w5VAKq4a+TsvODxkn9mntGTBdmUrWcpD622bSyZdNOEK0Zwxb1K5oAjsKoLg996bHMy7zu3lEKoX8zjhmve6RsP/cwzw23fybi0R11ob+eUNcyEUgYePKAieTI2mpV4mj/N99oaAss5mYo2FkHBK6PyC7hjkh5nN8ZnRMofqFydXCGePB7JnOmgQdYq9lpxdcsDS0S27K9mJb1rIsdxoeICNOGGZF1U//db7NVWgJRu2/dOQpI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGNOWnZzTXY1TDF2a0NGNUJickNMcE9YQXhTRGpqUTJieHE4RWdOYllRSHhG?= =?utf-8?B?cUdWc3JnVFBpQVprVGNMaDR3ZEpQb05hd29UZEVYbnhOd0p6TVVqQldYL0pu?= =?utf-8?B?QUF2ejM2SUVMWWFHY3RyYjQvb2t4NnlXd3FFRE96RWJjaUxvaGd6cUhSVkp1?= =?utf-8?B?MjFqZVd6SnpJRTA1NjBxSktIdGhGZXNTMWtXd28vN1RBNUd3a1FESkVZSU92?= =?utf-8?B?dzQxbkZMM2lqa3RPTzkwUWJ3YlR3dDIzcitTNTMxall1MndoSGRZR0RZYXdy?= =?utf-8?B?OU4wYjE0aCtGWVhXbDRBRmRjYnRXNjhJMi9oTmx3c0JWdzQzZ1JCUFdoV2Ev?= =?utf-8?B?U2o4NTZ1eWEwQndwVlcrVStQeGdBN0N2UERRamhzb1hBTklnRllsRUNBd3A1?= =?utf-8?B?VElHamJocHY5d2R4akg5YkVVaUppRG9yTGNjQS8wWE1VaFkxYWVYdkNDOFFV?= =?utf-8?B?Z3JsUzVuYWJpMXFLeHBjaVoxNHFady9Pb0JWSUw5djJJbVIzbDc3dlljWjh6?= =?utf-8?B?RWdIVnR2SGpsODNTWlZtd2trcnJwVFZrQUR4WUhtL0JNTm1aV1BYU3lpTC84?= =?utf-8?B?Z3lZSlUwYWp3eGhLbk41dzkrREhJVXRVcTJaY3JKUzV0NWlScXl1S2dLWWhS?= =?utf-8?B?NzFsMDJGUlQ4ZnNDbmZJYVJNTzVKM0pGMGxGbkNCdFRTSExzR1Q5Nm5OLzUy?= =?utf-8?B?Mjh6RDdKN2RwWERST09LRkRyaWVuemI2d2t6M2hSckNoVEZkSjlhTjgydnFr?= =?utf-8?B?a1ZFazYvWEtEcjIrRTZ1VUo1OXFHdkNxbGVjVU1lYjBtaXArOSt2NkM0WTRQ?= =?utf-8?B?cWlQNnlFQm5sUUx2MXZMQ1BZRkNYNzZKOXVBREdmbVFkc2U2ZS9ma2wwNGhw?= =?utf-8?B?WDZEQ2QzWHRYUDloTTFzZk1DTlZqWEh1ckt6SjM0RU9hS0hXa3NGL0FNZ0p0?= =?utf-8?B?ZUQ0S0VOODA5bGVjdHdJNHNSOGhzNTBNME5oNXR4WFdqajdYeitGYlFIUTdC?= =?utf-8?B?dVczVTM1Q1YreG5qdDVoeENvdUY3ZUxIbjlUN2NIUkN5b2Y2K0F3YlF4SmFl?= =?utf-8?B?bzJrbWVSZjdHbEtPeDAzYk8xQmZxazNpZWtIRDZybnFyZkxLU0NFWXNBeFBh?= =?utf-8?B?by8weHB2Q3BRUGtmaUNVU1llSE0rZ0NXSi90MmFVZ2VmWmZtc2xQQVA0U2Ni?= =?utf-8?B?MFByRTdrNEM3MHQzQUNNbjg1N0MvKzBENGlSc05oYjh4SWY4dEhWZlhyYlNS?= =?utf-8?B?RTZtZ3dscTB6VnFHZFd0ZXlXM3JEL3lHaXFCWEJ4TFU4aE1IZlhOZHl0cnF1?= =?utf-8?B?dlpBRkEwNjBwL2tGRFlpVEYvQnpkWnc2Zjh3bElUejd1L0d4SzZBYWZRRk4r?= =?utf-8?B?RDhIN2FCdU1DSWI5QStSYWxYMzRmY1pTRVR6cmkzWVl1bk9QNlJ2TU50Um50?= =?utf-8?B?ditMdDV6dWVpOW5DTEcreFQ0OThOT0ZIeE56My95WjlQYnA0ampOMklVSzA4?= =?utf-8?B?eXlIWG5MSEF6ZGpBR1h5UGVKZUFicXVIZlQrNUphMTl1bFZNMmNmN0VOWENu?= =?utf-8?B?UFZkdDJueVM5Z2lhODErVXo5d25iaFZYck1XajBRS2wwaU5uRDhObnNrVFJx?= =?utf-8?B?OC9WV1gyNGh4VkMyNEt2WTBkOEFDUTFSSUlJOUc4eUtnWG5WUzNoZ3NOTkkv?= =?utf-8?B?YXNoZGtsaHlWYlZQckQ3VHptR2QwR0hvcytjSmxaT2FyZXRxYWsvOEVWcU5t?= =?utf-8?B?SGhPZis1cVRWYmwvemV6Q3FVY3VrQ0ZaRDFvenl0RXF2bUJUVW5BUWhMdWxR?= =?utf-8?B?Z0ZBcXFxVFphMDZQaU8vaUdUTndCdEVBZ0FyUWhsNjRTdU0xNVNRdVlrZDY0?= =?utf-8?B?Tkh1RXIyNFVZVEtkdzU3RDNIZzdxcWFpcWdmWHUxOXdMdFNkTDRzaXdacWZO?= =?utf-8?B?ekVTVFg0UGNZL1ZsdXZxelFRanJkVFdmRDBCd3Bzb3Vvam5sOEY3KzQ0SzRD?= =?utf-8?B?Z3BubUUzbW5UeTZKVDduTHIydkZxOFViYytsTWZsa3dBb3JRSGZWai9HUFJG?= =?utf-8?B?MktTVGU4WnlFZjlLZEVUbXlic1A2TjFSa2xOWVRFa1FaY0FnTWcrUHJvOFd4?= =?utf-8?B?VFRQckFtbTI4bkR6Nk9wTk5tTGZCY1dJaXdwbmhYUy9zTWJmMVNmY3BPOHRK?= =?utf-8?B?L2V4Y1pDbEpYL2FtM2g1TTVCU0xIY1d4d1JXUWkyQ3RWYVBQWkN4TTNlUkF2?= =?utf-8?B?bnphUVZYeSswSDU4ZnZzNVNFcXRmN0ZNNlJMRmhDZHdiQWNMd1oxODBHSUVm?= =?utf-8?B?TEN2ZDhNQ09DeDRMZDVJZEcxRzNVMW9UdHdaUlV1aU0zWWNTTjVTUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d92381c6-47a4-4cb9-8c1b-08da3fd2d48a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:19:56.9284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0eIXHQ41+V/iIoSnDGdl0bfuYbSg5pZi2H/B+o7H0ccnlnE3+CoGnm1PcdQWnEq3R+xppYpntTmnTNSudMnkOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap for whenever we (and obviously hardware) start supporting 512G mappings. Note that cache sync-ing is likely more strict than necessary. This is both to be on the safe side as well as to maintain the pattern of all updates of (potentially) live tables being accompanied by a flush (if so needed). Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- Unlike the freeing of all-empty page tables, this causes quite a bit of back and forth for PV domains, due to their mapping/unmapping of pages when they get converted to/from being page tables. It may therefore be worth considering to delay re-coalescing a little, to avoid doing so when the superpage would otherwise get split again pretty soon. But I think this would better be the subject of a separate change anyway. Of course this could also be helped by more "aware" kernel side behavior: They could avoid immediately mapping freed page tables writable again, in anticipation of re-using that same page for another page table elsewhere. --- v4: Re-base over changes earlier in the series. v3: New. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2219,14 +2219,35 @@ static int __must_check cf_check intel_i * While the (ab)use of PTE_kind_table here allows to save some work in * the function, the main motivation for it is that it avoids a so far * unexplained hang during boot (while preparing Dom0) on a Westmere - * based laptop. + * based laptop. This also has the intended effect of terminating the + * loop when super pages aren't supported anymore at the next level. */ - pt_update_contig_markers(&page->val, - address_level_offset(dfn_to_daddr(dfn), level), - level, - (hd->platform_ops->page_sizes & - (1UL << level_to_offset_bits(level + 1)) - ? PTE_kind_leaf : PTE_kind_table)); + while ( pt_update_contig_markers(&page->val, + address_level_offset(dfn_to_daddr(dfn), level), + level, + (hd->platform_ops->page_sizes & + (1UL << level_to_offset_bits(level + 1)) + ? PTE_kind_leaf : PTE_kind_table)) ) + { + struct page_info *pg = maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + new.val &= ~(LEVEL_MASK << level_to_offset_bits(level)); + dma_set_pte_superpage(new); + + pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), ++level, + flush_flags, false); + BUG_ON(pg_maddr < PAGE_SIZE); + + page = map_vtd_domain_page(pg_maddr); + pte = &page[address_level_offset(dfn_to_daddr(dfn), level)]; + *pte = new; + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -232,7 +232,7 @@ struct context_entry { /* page table handling */ #define LEVEL_STRIDE (9) -#define LEVEL_MASK ((1 << LEVEL_STRIDE) - 1) +#define LEVEL_MASK (PTE_NUM - 1UL) #define PTE_NUM (1 << LEVEL_STRIDE) #define level_to_agaw(val) ((val) - 2) #define agaw_to_level(val) ((val) + 2) From xen-devel-bounces@lists.xenproject.org Fri May 27 11:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338027.562796 (Exim 4.92) (envelope-from ) id 1nuY2C-00077M-RI; Fri, 27 May 2022 11:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338027.562796; Fri, 27 May 2022 11:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY2C-000765-I1; Fri, 27 May 2022 11:21:36 +0000 Received: by outflank-mailman (input) for mailman id 338027; Fri, 27 May 2022 11:21:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuXuY-0007su-AT for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:13:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 106feff7-ddae-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 13:13:41 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-fiwWDwBhOeqP70CORUxCWA-1; Fri, 27 May 2022 13:13:39 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7210.eurprd04.prod.outlook.com (2603:10a6:102:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:13:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:13:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 106feff7-ddae-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DQnfN5ec44h4k+UnrTQoza7hV/xKmWkd1XV4maZZ/38=; b=Bl7pj7CzH293SUnFvkkRxeQeKUm7o5OufbD4xS1ipPXUcaWHMLGCtp3xIwMHthoTeTYXUC 9JRxPzakqtv+3tCZ9QM1sPSyMOne1CxxTquH3olgHMHcViGDdzcoNNkm4wRAOP4fr+6NBH V/KgZgT+Q1bySPzdpfd5WwpG41CY/rA= X-MC-Unique: fiwWDwBhOeqP70CORUxCWA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c69wk1Z0OtpGGq0WBV/4w9KTHO8Gw2kCcehE83d6yGZrzfKv5ZeQDMDZVS9eQFQf4PiULBOAkJGOm+vI9y8IppNuw3Qu1qBKeGcSsZ3y89kfCrFhouCAtIKaFFZo0cdVzxKEWi59Bpqow7Jmk85suSTUrrp2X1l4XUHrChyEdYpp3flqtmECAXIbTL9PVnQlaHs/wXPTFDt1uVQEqKLZfdbsuAdf1zTrSJyi/P7cpjQ/TEmcQWuUo9VPg2PiexUC/UnBWRSRi/r5mFijdE5x6qAmBoFCVWZnQy9LsdWNjAbdLTi7cfwgVEwRSK0xnP30LPLy3SlGFS5eU6ndwPRL9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AxiRfgvA8ZTM896+3sr+fZ7fI2k/BkIKHoJCeGpTy2A=; b=kHfnK7DciwV7yRZpDYXcdKurq014sRybjAgCoZsmzQ4pRvUviPVgaiDnxPzSQCYt1szMW0j2k4DntbY9T/e4R/S4ehhwgInSEd+WZc//+CXQb2eBEKNyPe1FQv4ckspJB/j7FCRJYL/nfeI5tNXEYFXP/5f5Ep2TZxwQmyjLcajGZRyX9hic7fRYKkNo+Q6zApm37XJ7KRrK4qwXQw2bRJVFO9HrNiDvAhGZoW9UOeis0tdk69AHT7i/4zLUgU3U3yNsrZvsF5ei2jRgoxfJ7KIxwMc82LIcxH4J7y302xa1mJ8yLi5xK+kmxIVWUsqL/DzgR9Dk/ytKzO1S7A8k3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:13:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 04/15] AMD/IOMMU: allow use of superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR06CA0325.eurprd06.prod.outlook.com (2603:10a6:20b:45b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: add242b3-37c1-4ea0-04ca-08da3fd1f321 X-MS-TrafficTypeDiagnostic: PR3PR04MB7210:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: frSo6a9Gr0H+ZlkH3dnr2Sx/8n36p60w9l3i5UEmZKKBhHLdX4+2UunpCh3OmylAKcqq9ZP1fABTpkOivl/JqNcgw9Xn4xUAyOzLS0i9/Kg5mDXxb1AHPV07SkED5NHmW/aRNK0tdg/HHFsEXvDkfl3qVMPnKPDf1oZGXxAV/PpAPln7fF8sWZNOibqv4quAPwyyeyucc34NRBEjIF9Poh6Nistxrrodm01U3gc9EBe7vEHLE1Mqix8GFsuVfU5ad0n0tIXU6xtJTsdPAgUbK62PQtWphDz2BIuv67BoNlermTid9ACTB4TI2CyIeSm4RsbnZZLsNzjjYvCCdZ1R7MAKKazLOY0tU3+0eN2jPUQO9Et0H0qXwMbQv1SFslzCmuj6jCYb/n6APTOiEclrGTRjzhBr4hZonx++kWaXXBkuXWwmSWJROfmcdJdAi2ghihugFV7almpTxtNZ01VJmwBp8KaL3/OjRGVahR4irFF7kOWFdoYa7mZsnoObcRFXn41a7u+jKAwJje7b+9TIc0q8CSTzpv4gDgt+lSBKcHbDH9IB058OhHguhFKUtoiQFZ2KTsXX6Ed8c/72LOmyJ/nbi++4HUKTev7g3a3pyIbBk9C3vxWgUQlbeGP3OAXbZ3aOwnPCUhoIRv272heNrispyMBZ7h0A6BzE+wnbbEGmpTyd8gxV3WGGLQfDKFJN8m3XCoHOWFURDCUrGT8H7SKFM/G7tIRKGcYDCfJ0Tq0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(6486002)(8676002)(66476007)(6512007)(83380400001)(8936002)(508600001)(5660300002)(66946007)(66556008)(26005)(38100700002)(2906002)(86362001)(6506007)(186003)(54906003)(316002)(36756003)(6916009)(31686004)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xaz5O0bRRd92b2qVsuWvM67Ldd6oDF3vUq04yULd01RN9S/GeXDCPYY5jmX8?= =?us-ascii?Q?bfDxkyWtMW43N272KSpzGwWPLyQAhtjAq/3S6iHuVZUj86zMsATVhriQ5jR1?= =?us-ascii?Q?2bvzrY86v/YcKGspnIj9/PI9/x0SXVgAVLnY4T/GC3RhLnKI2pBGTmbldcm4?= =?us-ascii?Q?joNXZR2yYm5yxJPsMztSlhhYmG1Xkzst4AJS3LbEuDghCtYCSeGkLC/uz4va?= =?us-ascii?Q?IEUidn2/yqqPPNtegjX8+GceSSQVDywh9p/DWTSRcoNXnMkZpSMpyhluXzKZ?= =?us-ascii?Q?cRQwOIAJ12lt/EtduYDXb66LO99GE6H1fXJtrclEd0QQ5ufLzwlR38NLoh59?= =?us-ascii?Q?V0ii/52EPCBydEw6McEB1a2vUFx+DhOeBTDH/iWXj+oAOqo2mbr4p1fcgqvi?= =?us-ascii?Q?QTDVEboCyY3Q0+zc/sCp2SLkjiki2gCG3eVLYUtCECGIcZC3MndVO6ReLCvv?= =?us-ascii?Q?MapaWuiuto7DcJU+bxeEATBcrFXD5T9vmvtKPekbNdD/bdkAv8RX/Nlqh5fX?= =?us-ascii?Q?OdZjccZQPnauUAG5pSJ8nQSacTPHrGWg2FzeHw3uSQh9KZ2omdeiJt6hlmDK?= =?us-ascii?Q?2JeGau8jePk8y1Lw90WDDaGCQd9bRR8hVPnNfIdyTzgEqK6SWm+OuzAkwTnQ?= =?us-ascii?Q?2J4V3uKeGQg0SkqRcCgVhj9/GU2I22mpNO4fxHQigwWANPZgrz0U1C7XRlC/?= =?us-ascii?Q?u7QNbxbof4SqpmRz2e1pUsUQe/TXIyInqHTIXGfEqkv1erHjNvRzCZDPRDYZ?= =?us-ascii?Q?KhoMl8Wev/OG1KeRtvcatGUWM+ktsgn/c+92kjn088mi76gafLKXWxPWjiwW?= =?us-ascii?Q?vqYcXjxQQg6hq39N1wwuR21d4cSpcWcUEg0+lG3muhlCd7RY26pSOKmvWvyE?= =?us-ascii?Q?Y/fKP7bY5wLaZvfxVoW9cmTbb75C2O8+QDy8z9sZIEb089ac6CaLJ9PQaTJz?= =?us-ascii?Q?FMJbN/hWbHdctFH3TbgqSZVvxAJhHCzSNqwt98B+n1VxD3Ork819kGtq5rWt?= =?us-ascii?Q?/cMh0wdd9fpRvWnSHrfmteP2e0GMkYkvhcmzgdEWoYKbBs6/HVy79zlz+aCc?= =?us-ascii?Q?ag5RjP4x7jYTwZp9L1PcgoyGVPW0rczMiqp9g/f9u/Toy73ShE/yTQ6jt9Af?= =?us-ascii?Q?XWxewzotz9Ej2Ovil29TbXxv+8eVLxCSc9GC+XVbd3okcwSvU1XOql+JPY0b?= =?us-ascii?Q?RpJ9WnvtXWl29NVFoAu0f4U1iAmaP3O2SxX3TkN9ipaC+LjtoLk9+hk3flqq?= =?us-ascii?Q?Ay52KRs1j8YS1DjldU7yIqsfJmPM5xMknwSirlHEMMfRTcd+W/YaKXbXDaoE?= =?us-ascii?Q?qkCE5/BBzMNMJvTE1SPqVA6XhZmMd0TxKhIMJVR8RpxhG4f5BqwN1XLQBDQd?= =?us-ascii?Q?zCfnGqBH/506hIWXP6cU1xdR1j7qqIemgmMWSUXoDS1HO5MiCzTWWXI227d8?= =?us-ascii?Q?LiokVWp+jM1sbjIhFICxpgMLJjajCZiIhdcpH0U/Hi43/VAl0A9YtC9ovyBf?= =?us-ascii?Q?k4oRoeksr32KY3eGxjK3gbZooqlmIbl8w8W6gd+fXoa3OswhVPYl6be1MpvZ?= =?us-ascii?Q?OrbGg9GNvxwYslUd9dqRSkj1OIxgNYI3ZDD99HZkmYb2xDwNX8h0ub9dUJzr?= =?us-ascii?Q?u8lc4T0JgoGeTqZzyOyWKk1WKnMqIDNFRsA4Mpz2WGonCOk1GJ/jPUJE8rSc?= =?us-ascii?Q?UJhIL9w28dyUNtNKN0eDp9Od7PC3AB9aVT2b6CevpZrH/uFlxvp09R0l6IEm?= =?us-ascii?Q?VyTlSbkQ5Q=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: add242b3-37c1-4ea0-04ca-08da3fd1f321 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:13:38.7494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ARsKo5ldFsCbhgjvkkfFOMel/tnf5fG3x6yuqWgsv+4GJsVuxUHaHyeOolESoyMUMfiql+TTla5gyPS21/G13Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7210 No separate feature flags exist which would control availability of these; the only restriction is HATS (establishing the maximum number of page table levels in general), and even that has a lower bound of 4. Thus we can unconditionally announce 2M and 1G mappings. (Via non- default page sizes the implementation in principle permits arbitrary size mappings, but these require multiple identical leaf PTEs to be written, which isn't all that different from having to write multiple consecutive PTEs with increasing frame numbers. IMO that's therefore beneficial only on hardware where suitable TLBs exist; I'm unaware of such hardware.) Note that in principle 512G and 256T mappings could also be supported right away, but the freeing of page tables (to be introduced in subsequent patches) when replacing a sufficiently populated tree with a single huge page would need suitable preemption, which will require extra work. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monn=C3=A9 --- v5: Drop PAGE_SIZE_512G. In amd_iommu_{,un}map_page() assert page order is supported. v4: Change type of queue_free_pt()'s 1st parameter. Re-base. v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks where possible. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -32,12 +32,13 @@ static unsigned int pfn_to_pde_idx(unsig } =20 static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, - unsigned long dfn) + unsigned long dfn, + unsigned int level) { union amd_iommu_pte *table, *pte, old; =20 table =3D map_domain_page(_mfn(l1_mfn)); - pte =3D &table[pfn_to_pde_idx(dfn, 1)]; + pte =3D &table[pfn_to_pde_idx(dfn, level)]; old =3D *pte; =20 write_atomic(&pte->raw, 0); @@ -351,15 +352,39 @@ static int iommu_pde_from_dfn(struct dom return 0; } =20 +static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int= level) +{ + if ( level > 1 ) + { + union amd_iommu_pte *pt =3D map_domain_page(mfn); + unsigned int i; + + for ( i =3D 0; i < PTE_PER_TABLE_SIZE; ++i ) + if ( pt[i].pr && pt[i].next_level ) + { + ASSERT(pt[i].next_level < level); + queue_free_pt(hd, _mfn(pt[i].mfn), pt[i].next_level); + } + + unmap_domain_page(pt); + } + + iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); +} + int cf_check amd_iommu_map_page( struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags, unsigned int *flush_flags) { struct domain_iommu *hd =3D dom_iommu(d); + unsigned int level =3D (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1= ; int rc; unsigned long pt_mfn =3D 0; union amd_iommu_pte old; =20 + ASSERT((hd->platform_ops->page_sizes >> IOMMUF_order(flags)) & + PAGE_SIZE_4K); + spin_lock(&hd->arch.mapping_lock); =20 /* @@ -384,7 +409,7 @@ int cf_check amd_iommu_map_page( return rc; } =20 - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, true) = || + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, tr= ue) || !pt_mfn ) { spin_unlock(&hd->arch.mapping_lock); @@ -394,8 +419,8 @@ int cf_check amd_iommu_map_page( return -EFAULT; } =20 - /* Install 4k mapping */ - old =3D set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), 1, + /* Install mapping */ + old =3D set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level, (flags & IOMMUF_writable), (flags & IOMMUF_readable)); =20 @@ -403,8 +428,13 @@ int cf_check amd_iommu_map_page( =20 *flush_flags |=3D IOMMU_FLUSHF_added; if ( old.pr ) + { *flush_flags |=3D IOMMU_FLUSHF_modified; =20 + if ( IOMMUF_order(flags) && old.next_level ) + queue_free_pt(hd, _mfn(old.mfn), old.next_level); + } + return 0; } =20 @@ -413,8 +443,15 @@ int cf_check amd_iommu_unmap_page( { unsigned long pt_mfn =3D 0; struct domain_iommu *hd =3D dom_iommu(d); + unsigned int level =3D (order / PTE_PER_TABLE_SHIFT) + 1; union amd_iommu_pte old =3D {}; =20 + /* + * While really we could unmap at any granularity, for now we assume u= nmaps + * are issued by common code only at the same granularity as maps. + */ + ASSERT((hd->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); + spin_lock(&hd->arch.mapping_lock); =20 if ( !hd->arch.amd.root_table ) @@ -423,7 +460,7 @@ int cf_check amd_iommu_unmap_page( return 0; } =20 - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, false)= ) + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, fa= lse) ) { spin_unlock(&hd->arch.mapping_lock); AMD_IOMMU_ERROR("invalid IO pagetable entry dfn =3D %"PRI_dfn"\n", @@ -435,14 +472,19 @@ int cf_check amd_iommu_unmap_page( if ( pt_mfn ) { /* Mark PTE as 'page not present'. */ - old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn)); + old =3D clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); } =20 spin_unlock(&hd->arch.mapping_lock); =20 if ( old.pr ) + { *flush_flags |=3D IOMMU_FLUSHF_modified; =20 + if ( order && old.next_level ) + queue_free_pt(hd, _mfn(old.mfn), old.next_level); + } + return 0; } =20 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -747,7 +747,7 @@ static void cf_check amd_dump_page_table } =20 static const struct iommu_ops __initconst_cf_clobber _iommu_ops =3D { - .page_sizes =3D PAGE_SIZE_4K, + .page_sizes =3D PAGE_SIZE_4K | PAGE_SIZE_2M | PAGE_SIZE_1G, .init =3D amd_iommu_domain_init, .hwdom_init =3D amd_iommu_hwdom_init, .quarantine_init =3D amd_iommu_quarantine_init, --- a/xen/include/xen/page-defs.h +++ b/xen/include/xen/page-defs.h @@ -21,4 +21,14 @@ #define PAGE_MASK_64K PAGE_MASK_GRAN(64K) #define PAGE_ALIGN_64K(addr) PAGE_ALIGN_GRAN(64K, addr) =20 +#define PAGE_SHIFT_2M 21 +#define PAGE_SIZE_2M PAGE_SIZE_GRAN(2M) +#define PAGE_MASK_2M PAGE_MASK_GRAN(2M) +#define PAGE_ALIGN_2M(addr) PAGE_ALIGN_GRAN(2M, addr) + +#define PAGE_SHIFT_1G 30 +#define PAGE_SIZE_1G PAGE_SIZE_GRAN(1G) +#define PAGE_MASK_1G PAGE_MASK_GRAN(1G) +#define PAGE_ALIGN_1G(addr) PAGE_ALIGN_GRAN(1G, addr) + #endif /* __XEN_PAGE_DEFS_H__ */ From xen-devel-bounces@lists.xenproject.org Fri May 27 11:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338019.562772 (Exim 4.92) (envelope-from ) id 1nuY27-0006Zh-I2; Fri, 27 May 2022 11:21:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338019.562772; Fri, 27 May 2022 11:21:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY27-0006ZY-Ey; Fri, 27 May 2022 11:21:31 +0000 Received: by outflank-mailman (input) for mailman id 338019; Fri, 27 May 2022 11:21:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY25-0006Ml-NT for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:21:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26c4d764-ddaf-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:21:28 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2172.outbound.protection.outlook.com [104.47.51.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-OMchAvVAOgOd_pNorEldkA-1; Fri, 27 May 2022 13:21:27 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2522.eurprd04.prod.outlook.com (2603:10a6:3:85::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.15; Fri, 27 May 2022 11:21:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:21:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26c4d764-ddaf-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NJESEP16cpa4nN52+FBPmemD9Gs3qUaoc8yPLoMudo=; b=Ier2PKC/NvC2Oxuea+yUJr//WmUt9+YlqOPUBrSMWYh3+gtw8Y7KGHro0CMqgJEZxIIYrL 8pSGsveu2MF8CC8C6e3XJaP7wEhucZY0KLqqFfa4Q20NuDgdY0MoniGPI27Rf9rDVsUne8 Xwos+ZB+mhDDCVgr3QmGWomi27/cSOs= X-MC-Unique: OMchAvVAOgOd_pNorEldkA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOxb/ez4tiKBhV2d9dx84nl6WKyDS6kG+CDrC9ETpGeAfDmTJRSHLF7OLWRFcQGSOA6qTMQuwc2D/LXiaSsj4VepApIfxllf5DGGm5nJ10Uup9P84o+Hg/ggnKLnlMyseBEY8k8zPtSgW6uQLq0j4tG3Bz5/XKo1Zk94or6a6+M2NWnaTCaM7qx5kmdj7Mif5EOzqzJ8FbLGoZ/Uk+qi7iMDUq0fUJ8kz6P1lTbE1BIUOvO+NfPECL7dC2G4buc4sygeGVpxiVxnOOiqu7LclcIWUoiOyIBqL+oMl9JRFA1VrtckCJ4wpcb9Ei/UmwjwvEeSMAPsc6ikm0Suybv3AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aNGQdoucDFou5j3M8E7Hd4miL8kBXhKfjN3w6aHaDIs=; b=eoy/UHqGfBBzqayZJAtVwr9RO1eNVZHfo/3MHfjamIzt76wDAyr5qEyWOcv4PxCMeXG7iTcH2wGkg8mkCMA+cmtK1e/3tlPUHaniiXLwMMy2js9cUPxMyQyhM+mhI2Su8YzszUoER/ZEHmpcfHVFTMdqLEhBlb315iLpU/ZwDj/VpVs+vMf9S9yD8G4hHeQLwRGj6tEdKeg/CaLfzvupL3uSi4m+qttVXeoxd33yPm9DXTH19wj/WzxZ3OkvpnWNubHBFLCDw4qgVdlq8wwOSjJoaues16pHnxXs9PJeN6LDt0+HbCd7VNjQsC9V6t19vrfz/JHNMhBztWMB8ud5jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6f80cf5d-536e-4e4a-5c87-4b55efcac3a5@suse.com> Date: Fri, 27 May 2022 13:21:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 15/15] VT-d: fold dma_pte_clear_one() into its only caller Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS9PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:20b:46a::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8ec8054-aa7a-4057-53d7-08da3fd30947 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2522:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KNMXAsJssjBYFHc9j/v2eLnA8QVQDpqZ88WdRljp3hTSiQnwjJgS+Bnod9oHi+8mENb7+JAEOxERmxwL1ghiqwMhzWyjFbkqLAvQMYO68LRep1mrOWMApFKNv2AmRJus48iDzdpaIxk+WrvFgkpKPJyK6asii8mG4WN/5JZkNX60m/QROKquy7TBfJotmSmBZmxwtgMMnIekcboNBwWHicI6/Mnjlqy3aj4RZTZ3pTvoHysVwEnRiph6pwNx9u2spPjQlWawK146S8joBiNTOa3H9c+4dx5tOb9ycid63OaE9JZoL3D1G+1eoGinKk92d3fsaw55p9oH6uTl4qWFVMdcMKsdZKr7+QYE6oCJrUGW2PledSVkMfMjaj6OiNv6uPR4Vq5TuXHpui+m+pu2DnT2cU9W7YZu+dHuApVBv5OCqc15FGD+768xMeLQBx7YaIVJ8uX5bAk1bOzeikYhFpcxJFSAbuwPU9Zps/92LgpSO7osMHH/Ado+4mg5+yWJPTwqvuPSHxdHyGqorEPcKsZ6Opx6l1LFxEdRsIXOAELgq1OfKEvP3NzTrgmtHJGdyIgnoP8Ebn4GKreWdFfXf9kOanJcNTEYdV9xmBVUGGA5ESSwTUePWRz+oj7m87Ay3QRTI29Slkzug8SFffasXyD2jwY2tcJ97+Pr/rHGZAq7jip8vZIleR+O7gOwFWK3Zw+BlFZYfRX9w1BMFPYK3IGJJk8v/OLMoQxWwXcpj/k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2906002)(66946007)(26005)(6486002)(4326008)(6512007)(66556008)(316002)(66476007)(508600001)(6506007)(54906003)(8676002)(31686004)(2616005)(83380400001)(6916009)(38100700002)(186003)(36756003)(5660300002)(8936002)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZcZ2CAZTRS/1Ie39/UD9K3TCjRLkZoj+6i/QPritidV6SDsNjpQx3VOZnpvH?= =?us-ascii?Q?73dnlCGyYqJqfU3cxODOFZFBSaZR5uiydWmpGL/Nu/lm+2DakysmajEGGzdq?= =?us-ascii?Q?Q3+JXzmum8KAHsXYpftDP8O6vyKPg0mf/xZOFVbNpWWYSQUmsRiQPemG/jgJ?= =?us-ascii?Q?VbHxno0EvkMePZAof2GvtqtxzHXtCHKPEggNlU9Me2OKHG5XMmBHOA2TwwwY?= =?us-ascii?Q?drc4vxSn2OjEjl/deJ0iIJxujP3VVX6qyFGm6O5zqSFmdmkycYlXSZXaIrOt?= =?us-ascii?Q?VIDhNlWHjODF+PsJkZVexFpjq+pq5d9EaJrL/F5xdtnTUZjvwPMvhCokjLOS?= =?us-ascii?Q?FrYXgzz1fKKxvxzQEomMWkh0SOtS8e9wJQV3VPlUIJUg2Ca0yJaURlmucz4h?= =?us-ascii?Q?Kntz0TNX8AKs/jmXyLS8gvQnGXZH7gTHtAzqrTHmMs5aid3woGp1qvo1fONu?= =?us-ascii?Q?PlqWzM9bFACcCsfq7ApV3kngpFk7NkVryMc6zSLok5PDTxL4NA9y9OQ1Dhhh?= =?us-ascii?Q?OKw26JzB0mhmiDviPsgXj//u05Xwhr//Zj5TiXHPs6Wwwxe1tWMEe1xEySZV?= =?us-ascii?Q?iNpj4YeDHvOp+Gtic7Uzoyv7k6v/0oY92r6ygE29B/rUVfNoVt++bi/2G2rG?= =?us-ascii?Q?S7VNF5ka0L9pdTzUCv37sXZAHj7AR5/kUbMXCex/St+Up4B8hyer8b9ytJ2E?= =?us-ascii?Q?tiFFlEqBG2F11BTQutoVkOzUheUGdWmEHH9Zpc/yysnf2TgCvBG/lRHldeHD?= =?us-ascii?Q?GHPOBoX7eZnvY/6ky239yQfuhFsJijo7HfmBllVaaIU6Envt5zhPx5CDcUJ5?= =?us-ascii?Q?1StOjC0pDYZvJjSmjA/NnbcH8fxku0RKGERFpiCjUKDK8OCbqKlbnIc9ab6K?= =?us-ascii?Q?AvnuorserEY9kPW4ElRGnalXpHdzmlTubauSHPhnLufUBxbBVGunJkIfnH2/?= =?us-ascii?Q?rJnm4+odgR4v2a3KfqAZ/3Pmreof9Nlilf3i3Y4kZuu2/skLkUnpmKPyj01j?= =?us-ascii?Q?cY25Jc8pqazYpwahGZtdhkomPruxv+6yCyCS8QVI3vsRgM+2Apxt0qsXdL8M?= =?us-ascii?Q?HJ0td0AFdh7ON7KjEq9T3l85Yp+lZT9RFv1AJflPjTDj/H1eLnhIbegi6w5t?= =?us-ascii?Q?w6Y1wtn6gfnNLlM/8T8KpDQVLOZBkfifRKzAT409drMOu2Yv4JjfQfhB+nym?= =?us-ascii?Q?6i8/ct738UIQlPpyxUan8BBlccoNDlgSYCinfJAS0IGGwsrqoR71O2h70gDV?= =?us-ascii?Q?GrJ6/YEeidkwX9nhtwq3i8AzI/PFJ1JvIQCW1FZLmInnCDtLUJ7kOT9ji9hI?= =?us-ascii?Q?KPEjLCXQylqRPSjpnebQ3+qO3TLNQZl8U7iqcJADmZQLNyUmnjGUWFB2bwOp?= =?us-ascii?Q?SehTCnwHRgx7K20H6+3NDYB4FhY9i37SO1TBrgBvkfUSzGjkDEwXz6PgndXO?= =?us-ascii?Q?aHnKO8P6AT6i2XJrSHT8A6hkVXUsnfY3RsHecklB4HwdJlSXXRWEN3Ph59TX?= =?us-ascii?Q?YgqVY4rh6MamkmdICtO0vz3zW7vN/BMh62MGiCg+4U8L+7Jye7o+X3IhT/hJ?= =?us-ascii?Q?lyzD6cQK+4TBweZ0hPum/57c9uQrH4Zm7PYqMXDiMYHIqoKtGjxnIBIKmlRs?= =?us-ascii?Q?K1E90WUP4Dp/Yl+3Ps2Vt51N0h+qq7Lm0cR1qs25BFxJ9oHW33nZ31P24H7u?= =?us-ascii?Q?00zbCNIb6xKalCIFgCyRdEjo1wBGDsUEkOXoLl3R8KV1RX7c6DDfk3HWls0k?= =?us-ascii?Q?t6n5p2S1AQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8ec8054-aa7a-4057-53d7-08da3fd30947 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:21:25.4071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Xsb5gN8ZtoXDIIJAmrPT3D6XymVg9YQo4EopeUZKFDizA+g0u2a8QFVJKnfo8Is42seBgdvObVVh9DDfIyZiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2522 This way intel_iommu_unmap_page() ends up quite a bit more similar to intel_iommu_map_page(). No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monn=C3=A9 --- v5: Re-base of changes earlier in the series. v4: New. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -806,75 +806,6 @@ static void queue_free_pt(struct domain_ iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); } =20 -/* clear one page's page table */ -static int dma_pte_clear_one(struct domain *domain, daddr_t addr, - unsigned int order, - unsigned int *flush_flags) -{ - struct domain_iommu *hd =3D dom_iommu(domain); - struct dma_pte *page =3D NULL, *pte =3D NULL, old; - u64 pg_maddr; - unsigned int level =3D (order / LEVEL_STRIDE) + 1; - - spin_lock(&hd->arch.mapping_lock); - /* get target level pte */ - pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flush_flags, = false); - if ( pg_maddr < PAGE_SIZE ) - { - spin_unlock(&hd->arch.mapping_lock); - return pg_maddr ? -ENOMEM : 0; - } - - page =3D (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte =3D &page[address_level_offset(addr, level)]; - - if ( !dma_pte_present(*pte) ) - { - spin_unlock(&hd->arch.mapping_lock); - unmap_vtd_domain_page(page); - return 0; - } - - old =3D *pte; - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(*pte)); - - while ( pt_update_contig_markers(&page->val, - address_level_offset(addr, level), - level, PTE_kind_null) && - ++level < min_pt_levels ) - { - struct page_info *pg =3D maddr_to_page(pg_maddr); - - unmap_vtd_domain_page(page); - - pg_maddr =3D addr_to_dma_page_maddr(domain, addr, level, flush_fla= gs, - false); - BUG_ON(pg_maddr < PAGE_SIZE); - - page =3D map_vtd_domain_page(pg_maddr); - pte =3D &page[address_level_offset(addr, level)]; - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(*pte)); - - *flush_flags |=3D IOMMU_FLUSHF_all; - iommu_queue_free_pgtable(hd, pg); - perfc_incr(iommu_pt_coalesces); - } - - spin_unlock(&hd->arch.mapping_lock); - - unmap_vtd_domain_page(page); - - *flush_flags |=3D IOMMU_FLUSHF_modified; - - if ( order && !dma_pte_superpage(old) ) - queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), - order / LEVEL_STRIDE); - - return 0; -} - static int iommu_set_root_entry(struct vtd_iommu *iommu) { u32 sts; @@ -2264,11 +2195,17 @@ static int __must_check cf_check intel_i static int __must_check cf_check intel_iommu_unmap_page( struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_f= lags) { + struct domain_iommu *hd =3D dom_iommu(d); + daddr_t addr =3D dfn_to_daddr(dfn); + struct dma_pte *page =3D NULL, *pte =3D NULL, old; + uint64_t pg_maddr; + unsigned int level =3D (order / LEVEL_STRIDE) + 1; + /* * While really we could unmap at any granularity, for now we assume u= nmaps * are issued by common code only at the same granularity as maps. */ - ASSERT((dom_iommu(d)->platform_ops->page_sizes >> order) & PAGE_SIZE_4= K); + ASSERT((hd->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); =20 /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) @@ -2278,7 +2215,62 @@ static int __must_check cf_check intel_i if ( iommu_hwdom_passthrough && is_hardware_domain(d) ) return 0; =20 - return dma_pte_clear_one(d, dfn_to_daddr(dfn), order, flush_flags); + spin_lock(&hd->arch.mapping_lock); + /* get target level pte */ + pg_maddr =3D addr_to_dma_page_maddr(d, addr, level, flush_flags, false= ); + if ( pg_maddr < PAGE_SIZE ) + { + spin_unlock(&hd->arch.mapping_lock); + return pg_maddr ? -ENOMEM : 0; + } + + page =3D map_vtd_domain_page(pg_maddr); + pte =3D &page[address_level_offset(addr, level)]; + + if ( !dma_pte_present(*pte) ) + { + spin_unlock(&hd->arch.mapping_lock); + unmap_vtd_domain_page(page); + return 0; + } + + old =3D *pte; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + while ( pt_update_contig_markers(&page->val, + address_level_offset(addr, level), + level, PTE_kind_null) && + ++level < min_pt_levels ) + { + struct page_info *pg =3D maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + pg_maddr =3D addr_to_dma_page_maddr(d, addr, level, flush_flags, f= alse); + BUG_ON(pg_maddr < PAGE_SIZE); + + page =3D map_vtd_domain_page(pg_maddr); + pte =3D &page[address_level_offset(addr, level)]; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |=3D IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); + } + + spin_unlock(&hd->arch.mapping_lock); + + unmap_vtd_domain_page(page); + + *flush_flags |=3D IOMMU_FLUSHF_modified; + + if ( order && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + order / LEVEL_STRIDE); + + return 0; } =20 static int cf_check intel_iommu_lookup_page( From xen-devel-bounces@lists.xenproject.org Fri May 27 11:21:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 11:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338024.562791 (Exim 4.92) (envelope-from ) id 1nuY2C-0006y6-Ao; Fri, 27 May 2022 11:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338024.562791; Fri, 27 May 2022 11:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY2C-0006w2-0s; Fri, 27 May 2022 11:21:36 +0000 Received: by outflank-mailman (input) for mailman id 338024; Fri, 27 May 2022 11:21:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuY1H-0003mu-Du for xen-devel@lists.xenproject.org; Fri, 27 May 2022 11:20:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 093bed15-ddaf-11ec-837f-e5687231ffcc; Fri, 27 May 2022 13:20:38 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3-_Hr4YX7tPrC7z9jcvVbOHQ-1; Fri, 27 May 2022 13:20:36 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5831.eurprd04.prod.outlook.com (2603:10a6:20b:a8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 11:20:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 11:20:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 093bed15-ddaf-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653650438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2x2jaOdslxN8JhgKIhN6FboWhHnFSS8ihgO/7F5za20=; b=fLpea1hHIl1AJcC4LVowliNBazDORKJAdsOy54mAtsIHmPriUVBuNszJu9rFaKNPY54owF CFz5gWZ6AXLlvTreMC5i/FluRRQ8K4Jtu6dgcqbd4jqsqPr+DjmZTZZ3W+qvzf8ExYlvy6 XPXHalRmoO1us6xIm2g8/NQTLDJa8hU= X-MC-Unique: _Hr4YX7tPrC7z9jcvVbOHQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SAHBHXhTNzCGtLpbO3eN+wtb3Mnm9Cj+8D+hSKZCgiTL7HRaAM0Vc5Z4IMOirQSOooPs/wDX3hzbHbVK9RuBsliOvn1rdVzNxx54lPjvHK1oC94gazzbFU1xC8hcl1hB6XqoV5w1EdjouCQb/XyAaTJnxrAMJOffBUUuBnYxbe2WCtUVKf820Uj2ulHeL9sS0JnILW7Shcmvqjdb0O1EsQRFeVGCUuVkTwcCp2H43aVa1wffoav0pLT2PJY/i/xvnrxOf7zTFy+91Zi4fNm6QwW+2HWlXVd5ileOrYTswpVbkDjth/iU2SCgcLKgQsg5tAqSpgRjgPKRM3kIUh/d9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mp5Lj3VLjBJ96BBU/R2oY/5qvo6N3bduCfhHn2y6m6c=; b=XLJ1LVsjEEexKlz50VwhNDkX8afhgaaAGwWSl2I718CP1BOsSMKdIAXF8rWcuqrAHmXQXpPTnIkRAqVoKk4+7PKfSZLycPlersChNANLQOVSmOOugemvBW/iK/W51eBrDWsJ0PgebZ3mX784bPL2yXHOoZ7mpUGHps8fcqDrRwvKaoZ2NbFHCZ1YdAwTC7n39XAk1nCoyO0a7yCZR1EsMzLUYypx2P+yrJTaLA51hnKN+dxfiOVTIWyfBT9MzJx9pHJM96oqPHQM8XdHieT6nmc8TLWaKKQhzR5G6k+tyPzGq73CQhid3sqDRIdzOBEToCIsoqOjra8pmlVEl1wtZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 27 May 2022 13:20:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: [PATCH v5 13/15] IOMMU/x86: add perf counters for page table splitting / coalescing Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> In-Reply-To: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR08CA0025.eurprd08.prod.outlook.com (2603:10a6:20b:c0::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c9dde31-d382-43e5-ad08-08da3fd2eb18 X-MS-TrafficTypeDiagnostic: AM6PR04MB5831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bey/pb6DnrAQlAGYARc5xJHKLRV5109YobdiTwPu9u/wPNS2inPiE4zUJxfB/GLiaoyDYXG/PW0yzKJ3Ynt0J/9tel0ib7eWWWpR9lN4wVDre0wLsbSvLtJtNr+8p3taBqlhqtbZQqACWUXwllh/KdV8Yz3FM7qgeOFWX981jKijpS1Uk8Hm7Z/opkxt6s7G/1DXC6rSImlWXjzCNp4IDcdXu0vhVZfPVyPFkaZXS4iyzN1mWV2A57yDnARBTd2cSKz5i1SPnl5s86G16CMrbydrIvEXhiTrQCcVLmHV9gqWLOE3uvgqPZlBSA+UmyzfDjXCYnTT39papb8jISVAMKrGH5M+my8KiK9xa8hwgYEc4SLqN2J7JUrZCa609DwCW1RCWmAL/jxOkD0kraRO+E6a/4sQQ2xJ+HSuSeuVUEwsVs5jHW5agDJMH5C0R8yPH6DA6QrM2CeHlnl/l3FvjnplBOHGUSbJyOr8GCr5Q7hm6DLv2XHnyRmiFECL69uJki5FQeYK1mYms7cPFBgHvkXXtBvrwNvhMxdsd8XjNp37olc19ZH1EJfYumjz8p6CzbW++sDbPqjorw7GKXarneUqz+t5G6rcM9vqpX5E7s2zoMU9TKKG6sBY8SEIvmG3OO64dIE5tdyc3+Ta5OHJK7ySDqjIA02Gmna19+6EZICIFnwUGx1kh8m+wtdIcXHNdcTlGYP1d/ysLn8CXJqcc1Vf9dW7vgH7u7tJjXQqhwNu50vCIg9VYNXP0GJ10m8e X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(2616005)(26005)(6506007)(316002)(66556008)(66946007)(54906003)(508600001)(8676002)(4326008)(66476007)(6486002)(86362001)(38100700002)(31696002)(186003)(83380400001)(5660300002)(31686004)(2906002)(8936002)(36756003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6T+WIkT4tAjs80URul34bfBsMP0InLY3OnpQ71chnkJiW3Z/6C6h0skI3vC/?= =?us-ascii?Q?uEhn/6/H1ulOxCbN784bXYJsnlDXKEDzweHFszCUAXUdzYBnrH598ZXmPghD?= =?us-ascii?Q?T3if9YO6zfZL9vDKuUT5yAq4QG3iKMbViIhP/djfIE2c/1miWtElKeWfyg5h?= =?us-ascii?Q?pZabIL6pY8qsYZjevjcwx+kg2oWNImHc0WXAzg2fZADL8fiiXC93TkDBB+30?= =?us-ascii?Q?pkowKTS+XiZBaT5hgZBkOIiXA1x5qt+U0+TpQaIbhupxKNmOLzwsYiSk5YvF?= =?us-ascii?Q?/CY7jE0f6rabzVtZ4ohsSt5JU91nHIusZ2V5GQOEmNNIu4hptJjaEV/AmsMH?= =?us-ascii?Q?0RwB1tdvRpi5AuLIViJ+9TEvh7AKRbsevwl+taH0L0pl4JtUBHnxPZPOwYx+?= =?us-ascii?Q?h3vZAiF6aupcdjeD2esJBpzVuP1/49h2f1xzIN6z2ACuX7HBs6UfF4zTP0GS?= =?us-ascii?Q?O6MXFOQtc1ewpnbtpWCgDMQtlEHwikkdtTT5cX6UUQ30WNyHsZT+T7REgROP?= =?us-ascii?Q?9apLJvsroyxFCWrJjfqjCCoDOZi01fIit/vLnd31ihxOk/BwAeCM4a8SYYt+?= =?us-ascii?Q?eLRj6V7xroWHJ4YZBtzxekquaPQThsmAg3VBZXJFBph1Ir9QEiPbHslpM5xV?= =?us-ascii?Q?Mch7a8fZXBo32aQQONUp1bnr13n6CVvOiM1yvd9KVF18S6c6AsfBV4eAvEfa?= =?us-ascii?Q?fuFWKyv0qn4fD2DrAujcsG45gNcq97US2lvRfBtel3fQJY+hsjWV69fnMTyR?= =?us-ascii?Q?Pjjv4loXfsH8sppTkc/SLVtFrF1afwnRKASvjV+7JxuX7FaHUsqPrjhPcnGf?= =?us-ascii?Q?XMQasHw7BImHlShZdjAM8V3mlF2uSt4UBiFWNyq19uk5m8LW9eWH2Phcrnln?= =?us-ascii?Q?hT4EPptbJ7WYF+78+Ccc56T9CXZTvLvN0LVQ3uFvhRx2NRj6+YEWMvqJ2Na+?= =?us-ascii?Q?yv+r2htA1rv4qiWL42fa11LEd3yI4GPRisayopmBrMZ6GzTBnKSABDmDhFeG?= =?us-ascii?Q?F3g3PR+75UX84/xdqjx2C7jnuVyBdyfQp2F9H5rdWmlA6mhvZrCnbIlTSdOF?= =?us-ascii?Q?29KSZjQvd/gSkkB5ocUgn4ArX+qCkfc0a4gpAa4gVQRC3YGdPID6V1pLGg6v?= =?us-ascii?Q?ZMTv1SyflF4RyD/zCW7muoyJMVfLmYPc4Ak+lTAq7D+KuOl6raxMOfosxsrc?= =?us-ascii?Q?LzxPalt+iurzSUsrrHb5OyFAht5rYOGQEVcBf8V3Zyfn2U3G0nGGigP04CjJ?= =?us-ascii?Q?gqfcwW5eE2zNS5z2BqOyE2AD8OfhsVgvo+2MSL/yJy6+SG7oqNE/1L0XumIW?= =?us-ascii?Q?JjrirT+WnXwR2pxZ2NlTIjS+7lnKSu7di83nI0uxypZ2R3hIKvWszwXPRXZW?= =?us-ascii?Q?qx0cUZSx7tFOay+MRKxdWcFfex9/F0TvJnEn9/glAzDPyaJDyd/eGCF/b3WU?= =?us-ascii?Q?ABQv0x2Nl3gKPQYkpEH91luL08ccqWzNGGlaZ980AqI5qitChEoieGerTB3+?= =?us-ascii?Q?yl3SM4mMs+2BMnQ71V4h7kHwzu4QrtQwYvu58OAOL5H8J5jdfortupyC20d2?= =?us-ascii?Q?u/SwjYF347rnSzgAthuBMSGn/hZ8yMdhdxTJQwtqMs5il4lPUeAr4WVZVLIc?= =?us-ascii?Q?DRtobHHhJqe1JJDcq7xiI8BBf/YfGwRD9jh0/izBd21Y1j2MefB2hFnbm+/A?= =?us-ascii?Q?otKtEJDiDFgtPFHfxWi0ekCgtYmaUksJoJGWFybAaqGyaXVyZIllc7Zbz96P?= =?us-ascii?Q?iP9IVq2vEw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9dde31-d382-43e5-ad08-08da3fd2eb18 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 11:20:34.7385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5x7mui+CpkO441Nuq8AehptNj6Zbs5jF5qN+YisD+BHc7FT7RrbBq48LwbV0u237BSWFZSEysROwofqML03Htw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5831 Signed-off-by: Jan Beulich Reviewed-by: Kevin tian Reviewed-by: Roger Pau Monn=C3=A9 --- v3: New. --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -125,4 +125,7 @@ PERFCOUNTER(realmode_exits, "vmexit =20 PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") =20 +PERFCOUNTER(iommu_pt_shatters, "IOMMU page table shatters") +PERFCOUNTER(iommu_pt_coalesces, "IOMMU page table coalesces") + /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -345,6 +345,8 @@ static int iommu_pde_from_dfn(struct dom level, PTE_kind_table); =20 *flush_flags |=3D IOMMU_FLUSHF_modified; + + perfc_incr(iommu_pt_shatters); } =20 /* Install lower level page table for non-present entries */ @@ -477,6 +479,7 @@ int cf_check amd_iommu_map_page( flags & IOMMUF_readable, &contig); *flush_flags |=3D IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } =20 spin_unlock(&hd->arch.mapping_lock); @@ -543,6 +546,7 @@ int cf_check amd_iommu_unmap_page( clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); *flush_flags |=3D IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } } =20 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -404,6 +404,8 @@ static uint64_t addr_to_dma_page_maddr(s =20 if ( flush_flags ) *flush_flags |=3D IOMMU_FLUSHF_modified; + + perfc_incr(iommu_pt_shatters); } =20 write_atomic(&pte->val, new_pte.val); @@ -865,6 +867,7 @@ static int dma_pte_clear_one(struct doma =20 *flush_flags |=3D IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } =20 spin_unlock(&hd->arch.mapping_lock); @@ -2247,6 +2250,7 @@ static int __must_check cf_check intel_i =20 *flush_flags |=3D IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } =20 spin_unlock(&hd->arch.mapping_lock); From xen-devel-bounces@lists.xenproject.org Fri May 27 13:46:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 13:46:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338071.562816 (Exim 4.92) (envelope-from ) id 1nuaIE-0005Ph-KK; Fri, 27 May 2022 13:46:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338071.562816; Fri, 27 May 2022 13:46:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuaIE-0005Pa-Gz; Fri, 27 May 2022 13:46:18 +0000 Received: by outflank-mailman (input) for mailman id 338071; Fri, 27 May 2022 13:46:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuaIC-0005PR-V8 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 13:46:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60863a8b-ddc3-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 15:46:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 884771F460; Fri, 27 May 2022 13:46:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30ADF139C4; Fri, 27 May 2022 13:46:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id L+OyCSbWkGItTgAAMHmgww (envelope-from ); Fri, 27 May 2022 13:46:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60863a8b-ddc3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653659174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/DlYf7tU7F/Vu2fbHo8Rd3nV/4jGmq37Bvumm1ygGeg=; b=tLztS/TtyBtr0h9Du3Wut/72stfQVml8ZpSX3ZZCQ1qSqtchnMYlLw1yh+9B1iA+rfD+7q /YMUdeb3Ixu/Ck0HDdW9TXfIJy1B6o+MUCHNZyTcM1PQKlTOES0rGiCQrLutjSOiWC2T5X kY4h71QB3jrVGXfmET/dPqdP6HseqPc= Message-ID: <91a372cb-2e4c-e738-a6bd-d65189bcd194@suse.com> Date: Fri, 27 May 2022 15:46:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] tools/libxl: optimize domain creation skipping domain cpupool move Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, andrew.cooper3@citrix.com, Wei Liu , Anthony PERARD References: <20220526081230.3194-1-luca.fancellu@arm.com> From: Juergen Gross In-Reply-To: <20220526081230.3194-1-luca.fancellu@arm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------p2iyBy8O0HkBIDt478YptPQm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------p2iyBy8O0HkBIDt478YptPQm Content-Type: multipart/mixed; boundary="------------p1x56kwc0ip1JhHnMnRqFqxw"; protected-headers="v1" From: Juergen Gross To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, andrew.cooper3@citrix.com, Wei Liu , Anthony PERARD Message-ID: <91a372cb-2e4c-e738-a6bd-d65189bcd194@suse.com> Subject: Re: [PATCH] tools/libxl: optimize domain creation skipping domain cpupool move References: <20220526081230.3194-1-luca.fancellu@arm.com> In-Reply-To: <20220526081230.3194-1-luca.fancellu@arm.com> --------------p1x56kwc0ip1JhHnMnRqFqxw Content-Type: multipart/mixed; boundary="------------mo8eIL20T3s0RXOib0s410JB" --------------mo8eIL20T3s0RXOib0s410JB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDUuMjIgMTA6MTIsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+IENvbW1pdCA5MmVh OWM1NGZjODEgKCJhcm0vZG9tMGxlc3M6IGFzc2lnbiBkb20wbGVzcyBndWVzdHMgdG8gY3B1 cG9vbHMiKQ0KPiBpbnRyb2R1Y2VkIGEgd2F5IHRvIHN0YXJ0IGEgZG9tYWluIGRpcmVjdGx5 IG9uIGEgY2VydGFpbiBjcHVwb29sLA0KPiBhZGRpbmcgYSAiY3B1cG9vbF9pZCIgbWVtYmVy IHRvIHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbi4NCj4gDQo+IFRoaXMgd2FzIGRv bmUgdG8gYmUgYWJsZSB0byBzdGFydCBkb20wbGVzcyBndWVzdHMgaW4gZGlmZmVyZW50IHBv b2xzIHRoYW4NCj4gY3B1cG9vbDAsIGJ1dCB0aGUgdG9vbHN0YWNrIGNhbiBiZW5lZml0IGZy b20gaXQgYmVjYXVzZSBpdCBjYW4gbm93IHVzZQ0KPiB0aGUgc3RydWN0IG1lbWJlciBkaXJl Y3RseSBpbnN0ZWFkIG9mIGNyZWF0aW5nIHRoZSBndWVzdCBpbiBjcHVwb29sMA0KPiBhbmQg dGhlbiBtb3ZpbmcgaXQgdG8gdGhlIHRhcmdldCBjcHVwb29sLg0KPiANCj4gU3VnZ2VzdGVk LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWdu ZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNClJl dmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdl bg0K --------------mo8eIL20T3s0RXOib0s410JB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------mo8eIL20T3s0RXOib0s410JB-- --------------p1x56kwc0ip1JhHnMnRqFqxw-- --------------p2iyBy8O0HkBIDt478YptPQm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKQ1iUFAwAAAAAACgkQsN6d1ii/Ey/A PQgAkEiwfcJjyC3/fAD0DWZHhp8aMslM9fO9WwSBjpPdpYw4O0qBv1crW4oQwoO5ZgdEosZ8/LZg H8d4PBzZLz75LfQbJuCOI7xFGoeMU2899L/cPPZfR1BSd8WTWmewr73U0fQ27We58GbeXd6M/4QI QsxBIJ+xszwOQGWdvcwH/nx30QJETRtNyVCrQ+uA1HkrozWL+gfHS8In+5EliRVf7vd/N5VFMcw6 w74xhmOco63Oyo+/YXhPF5nslfhPHcmol1BVAJrbM4T+V/+WZCopMTiThZEytEWaKDfIKfB1dmax YhnhqcybJiRSS9gYw4Ip8yu298VOONUWwG6vJ+T6Ow== =vxCM -----END PGP SIGNATURE----- --------------p2iyBy8O0HkBIDt478YptPQm-- From xen-devel-bounces@lists.xenproject.org Fri May 27 16:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 16:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338079.562826 (Exim 4.92) (envelope-from ) id 1nud50-0005ul-C3; Fri, 27 May 2022 16:44:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338079.562826; Fri, 27 May 2022 16:44:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nud50-0005ue-9L; Fri, 27 May 2022 16:44:50 +0000 Received: by outflank-mailman (input) for mailman id 338079; Fri, 27 May 2022 16:44:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nud4z-0005uU-5w; Fri, 27 May 2022 16:44:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nud4z-0006QA-0H; Fri, 27 May 2022 16:44:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nud4y-0004Ts-Gm; Fri, 27 May 2022 16:44:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nud4y-0006zu-Fq; Fri, 27 May 2022 16:44:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ruIBAd2OSD3TEOm54PXOv+pz79tgjk2e5ldaQZUJPBs=; b=U9Mnf2htQ8wpQDyFsvuyXLDaCL 32CEyA1PMzHBFGv+6evLpBjOBSV+N4qF0YQX/eanoLKteDf2MidToMv05ERKyOmY4ls7xJQ6bbyeR vGPPTye/mckRnjAhXpq5ogTBC9w4bweUfsE9cFXhCn3xOqRKFiky9+88cqD4CWeLRqmY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170753: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=7e284070abe53d448517b80493863595af4ab5f0 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Fri, 27 May 2022 16:44:48 +0000 flight 170753 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170753/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 build-arm64-pvops 6 kernel-build fail REGR. vs. 170714 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 7e284070abe53d448517b80493863595af4ab5f0 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 3 days Failing since 170716 2022-05-24 11:12:06 Z 3 days 8 attempts Testing same since 170753 2022-05-27 06:45:13 Z 0 days 1 attempts ------------------------------------------------------------ 1755 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 187821 lines long.) From xen-devel-bounces@lists.xenproject.org Fri May 27 17:53:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 17:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338092.562838 (Exim 4.92) (envelope-from ) id 1nue9Z-0004HQ-Hl; Fri, 27 May 2022 17:53:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338092.562838; Fri, 27 May 2022 17:53:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nue9Z-0004HJ-Ed; Fri, 27 May 2022 17:53:37 +0000 Received: by outflank-mailman (input) for mailman id 338092; Fri, 27 May 2022 17:53:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nue9X-0004HB-J9 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 17:53:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nue9W-0007eD-UD; Fri, 27 May 2022 17:53:34 +0000 Received: from [54.239.6.189] (helo=[192.168.12.224]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nue9W-0001q9-MQ; Fri, 27 May 2022 17:53:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hiAfzS9hpjb7rjxSiDDUClDp2xkQqnLRp6Wr+XNmkV0=; b=ZxqczKbpT8Pe9otFwebnF2QzQq UG7V780Pc8k8HhtAswmhf6XXN/kEK10vqaT1q5un64F1OjD3ihyJ3qrofLuDcLWiyt7GJySr95DFN N+2XrvjGWm+4eyPiQGpMJNuLogW5T1jb572rnnvURaJ8nUyvdRaOBUgOgCL2T3axLsgU=; Message-ID: <01f7af22-16c5-bf13-f163-d5aa6560f6e9@xen.org> Date: Fri, 27 May 2022 18:53:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk References: <20220523091324.137350-1-michal.orzel@arm.com> <45054a80-3958-a6b8-1575-02dd5bb17892@xen.org> <3236e8e6-c25d-1733-9315-e0363cc73f84@xen.org> <06dbe73a-a14f-4b9f-4839-9c97829303ff@arm.com> From: Julien Grall In-Reply-To: <06dbe73a-a14f-4b9f-4839-9c97829303ff@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/05/2022 07:34, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 23.05.2022 22:00, Julien Grall wrote: >> >> >> On 23/05/2022 11:21, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> >>> On 23.05.2022 12:05, Julien Grall wrote: >>>> Hi, >>>> >>>> On 23/05/2022 10:13, Michal Orzel wrote: >>>>> Introduce a command line parameter "maxcpus" on Arm to allow adjusting >>>>> the number of CPUs to activate. >>>> >>>> The current definition "maxcpus" is not really suitable for big.LITTLE systems as you have no flexibility to say how many types of each cores you want to boot. >>>> >>>> Instead, Xen will pick-up the first CPUs it parsed from the firmware tables. >>>> >>>> >>>> So what's your use-case/target? >>>> >>> - use cases where we have no big little (although even on big.LITTLE limiting this number makes sense if we do not care about the types) >> >> This may make sense in debug build, but for prod I think you need some certainty how which CPUs you are going to use. > My conviction was that using big.LITTLE by enabling hmp-unsafe is not really used in the production systems (after all it's called *unsafe*) > as it may easily end up in an insecure/unstable platform without specifying the cpu affinity (which must be done carefully). > >> >> So I would like a warning in the documentation "maxcpus" that in big.LITTLE system, there are no guarantee on which types will be used. > I'm fully ok with adding this warning. > > **WARNING: On Arm big.LITTLE systems, when `hmp-unsafe` option is enabled, this command line > option does not guarantee on which CPU types will be used.** NIT: s/on// > >> >> This is technically a lie, but I don't want a user to start relying on how Xen will parse the DT. >> >>> - debug cases where we want to set maxcpus=1 >> >> Thanks for the clarification. I would be happy to add my tag with a warning in the documentation. >> > Does it mean you want to do this on commit or should I handle it in v2? It depends whether there are other comments on the series. If there are none, then I will do it on commit. I will wait until next week to give a chance to Bertrand/Stefano to comment. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri May 27 18:00:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 18:00:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338101.562848 (Exim 4.92) (envelope-from ) id 1nueFk-0004zB-Bd; Fri, 27 May 2022 18:00:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338101.562848; Fri, 27 May 2022 18:00:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nueFk-0004z4-8c; Fri, 27 May 2022 18:00:00 +0000 Received: by outflank-mailman (input) for mailman id 338101; Fri, 27 May 2022 17:59:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nueFi-0004yy-TS for xen-devel@lists.xenproject.org; Fri, 27 May 2022 17:59:59 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0465e15-dde6-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 19:59:56 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24RGA4KE007173; Fri, 27 May 2022 17:59:16 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3g93tdyqhy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 May 2022 17:59:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24RHo4Sm007602; Fri, 27 May 2022 17:59:14 GMT Received: from bostrovs-us.us.oracle.com (bostrovs-us.us.oracle.com [10.152.12.19]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3g93x1xpnr-1; Fri, 27 May 2022 17:59:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0465e15-dde6-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2021-07-09; bh=GwnebTzOd5wOseRW/GGVCpRp/qP0tcU6Vg3nLISbrpI=; b=dBeVkQgnGItGMNHBJL0tjsELF0e8bXbIOqUVfyOImmsOCfxgThk+2JuKYK7JS5vm702S QprPYaXZ6F2iOFs7u9Vz5NfFMfHD3p8Yv7gyLKWJFbeErlIp3X+C+EwlkIgXdAU7nZL/ StXbY81etx7TS19rhA5gP4hRKF1PONehdsrAdMEeyglVncgk5J/QsFTRZTHEgjx6hF5M bZzI1vqOrGwnrNKCoQTOhAQXzc41jjFILuiR6extRG640ZMSA5nRmW1hU/f/35MrBvqF uZEfrJrl3ORTamL52r+iaC7TNxXn7Lk67u9eblY4pMPVGB876b2Z9vBwdZxNthfAD8S8 Pw== From: Boris Ostrovsky To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Subject: [PATCH] MAINTAINERS: Update Xen maintainership Date: Fri, 27 May 2022 13:57:05 -0400 Message-Id: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874 definitions=2022-05-27_05:2022-05-27,2022-05-27 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205270087 X-Proofpoint-GUID: QhWoUm9D1nSCVjvVtXBiIk70L5n3x3dH X-Proofpoint-ORIG-GUID: QhWoUm9D1nSCVjvVtXBiIk70L5n3x3dH Due to time constraints I am stepping down as maintainter. I will stay as reviewer for x86 code (for which create a separate category). Stefano is now maintainer for Xen hypervisor interface and Oleksandr has graciously agreed to become a reviewer. Signed-off-by: Boris Ostrovsky --- MAINTAINERS | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6d879cb0afd..b879c4e6750e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21549,23 +21549,29 @@ F: arch/arm64/include/asm/xen/ F: arch/arm64/xen/ XEN HYPERVISOR INTERFACE -M: Boris Ostrovsky M: Juergen Gross -R: Stefano Stabellini +M: Stefano Stabellini +R: Oleksandr Tyshchenko L: xen-devel@lists.xenproject.org (moderated for non-subscribers) S: Supported T: git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git F: Documentation/ABI/stable/sysfs-hypervisor-xen F: Documentation/ABI/testing/sysfs-hypervisor-xen -F: arch/x86/include/asm/pvclock-abi.h -F: arch/x86/include/asm/xen/ -F: arch/x86/platform/pvh/ -F: arch/x86/xen/ F: drivers/*/xen-*front.c F: drivers/xen/ F: include/uapi/xen/ F: include/xen/ +XEN HYPERVISOR X86 +M: Juergen Gross +R: Boris Ostrovsky +L: xen-devel@lists.xenproject.org (moderated for non-subscribers) +S: Supported +F: arch/x86/include/asm/pvclock-abi.h +F: arch/x86/include/asm/xen/ +F: arch/x86/platform/pvh/ +F: arch/x86/xen/ + XEN NETWORK BACKEND DRIVER M: Wei Liu M: Paul Durrant -- 1.8.3.1 From xen-devel-bounces@lists.xenproject.org Fri May 27 18:22:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 18:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338109.562859 (Exim 4.92) (envelope-from ) id 1nuebd-0008Ee-5j; Fri, 27 May 2022 18:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338109.562859; Fri, 27 May 2022 18:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuebd-0008EX-2t; Fri, 27 May 2022 18:22:37 +0000 Received: by outflank-mailman (input) for mailman id 338109; Fri, 27 May 2022 18:22:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuebb-0008EQ-SQ for xen-devel@lists.xenproject.org; Fri, 27 May 2022 18:22:35 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa88d5df-dde9-11ec-837f-e5687231ffcc; Fri, 27 May 2022 20:22:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 56906B824C9; Fri, 27 May 2022 18:22:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79E6BC385B8; Fri, 27 May 2022 18:22:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa88d5df-dde9-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653675752; bh=UVSKD2w56mlgEfl0ZkR/dT7q4SzsY8P7MtcC6hyVt4I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FBMFjtrTweZvKQFVAxphG1CDiAY+UMSzNV94KtF/E3dlHO1gF7YQRgC/pyOB/2MpA 39zYOT5gwiktxPhHhhFV8TPnU5zVpdSvvGimJHs3Z2uYMQvsU02MqD53OCLr9U+5gc Iot2xVFpU4tjBiEJoirx8TITsWTS+PhdKKen+NDOu84BQvWK1w0kU1VgbJmO7vDte5 Tev+i4n9scPLMjMyCDZ/9Q+My1Q6//r25InI3VHuSEgW/NvE44FKbhn+5ovtvvvIkj sHUx+twY46NE6DLb/vR1DnJaqf0b2ZkiUKylQbogUog1uxQE39kwMKgRuNqVzRIqg1 xBci/c+3xeXFQ== Date: Fri, 27 May 2022 11:22:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Boris Ostrovsky cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> Message-ID: References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 27 May 2022, Boris Ostrovsky wrote: > Due to time constraints I am stepping down as maintainter. I will stay > as reviewer for x86 code (for which create a separate category). > > Stefano is now maintainer for Xen hypervisor interface and Oleksandr has > graciously agreed to become a reviewer. > > Signed-off-by: Boris Ostrovsky Acked-by: Stefano Stabellini > --- > MAINTAINERS | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6d879cb0afd..b879c4e6750e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -21549,23 +21549,29 @@ F: arch/arm64/include/asm/xen/ > F: arch/arm64/xen/ > > XEN HYPERVISOR INTERFACE > -M: Boris Ostrovsky > M: Juergen Gross > -R: Stefano Stabellini > +M: Stefano Stabellini > +R: Oleksandr Tyshchenko > L: xen-devel@lists.xenproject.org (moderated for non-subscribers) > S: Supported > T: git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > F: Documentation/ABI/stable/sysfs-hypervisor-xen > F: Documentation/ABI/testing/sysfs-hypervisor-xen > -F: arch/x86/include/asm/pvclock-abi.h > -F: arch/x86/include/asm/xen/ > -F: arch/x86/platform/pvh/ > -F: arch/x86/xen/ > F: drivers/*/xen-*front.c > F: drivers/xen/ > F: include/uapi/xen/ > F: include/xen/ > > +XEN HYPERVISOR X86 > +M: Juergen Gross > +R: Boris Ostrovsky > +L: xen-devel@lists.xenproject.org (moderated for non-subscribers) > +S: Supported > +F: arch/x86/include/asm/pvclock-abi.h > +F: arch/x86/include/asm/xen/ > +F: arch/x86/platform/pvh/ > +F: arch/x86/xen/ > + > XEN NETWORK BACKEND DRIVER > M: Wei Liu > M: Paul Durrant > -- > 1.8.3.1 > From xen-devel-bounces@lists.xenproject.org Fri May 27 18:28:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 18:28:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338117.562871 (Exim 4.92) (envelope-from ) id 1nuehL-0000Tm-SN; Fri, 27 May 2022 18:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338117.562871; Fri, 27 May 2022 18:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuehL-0000Tf-Op; Fri, 27 May 2022 18:28:31 +0000 Received: by outflank-mailman (input) for mailman id 338117; Fri, 27 May 2022 18:28:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuehK-0000TX-Nc for xen-devel@lists.xenproject.org; Fri, 27 May 2022 18:28:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce0fd6a0-ddea-11ec-bd2c-47488cf2e6aa; Fri, 27 May 2022 20:28:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C5A3F1F855; Fri, 27 May 2022 18:28:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DAE7139C4; Fri, 27 May 2022 18:28:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YUGLGEwYkWIHUAAAMHmgww (envelope-from ); Fri, 27 May 2022 18:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce0fd6a0-ddea-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653676108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=61mrjr5ccqj+zy0+zDS9f8lYD0h+AKlr5nfyVR0ykGw=; b=c2NtiGqwjUp5nc47p5EXiMqdtFFV+zbs9WnzbB8DsY0WZ6jZQ2vtZBTtO+SfZdktyS/gI0 lUL5evmahqcNLCwmzXZCKc8oiursrUwkbS/WOsamM5beuq7wPxVWbT+Xz/CAdIWnygfKkH gIM+WyBox6a1QjgyzBexTybL6XrYYgY= Message-ID: Date: Fri, 27 May 2022 20:28:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership Content-Language: en-US To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> From: Juergen Gross In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6n9mlK7a06XGxuQM57dXnD24" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6n9mlK7a06XGxuQM57dXnD24 Content-Type: multipart/mixed; boundary="------------0DjIufFJWt8ABv44kekpH6j3"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Message-ID: Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> --------------0DjIufFJWt8ABv44kekpH6j3 Content-Type: multipart/mixed; boundary="------------JVGzJTU7EHLZVogaAy0EV5H0" --------------JVGzJTU7EHLZVogaAy0EV5H0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDUuMjIgMTk6NTcsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gRHVlIHRvIHRp bWUgY29uc3RyYWludHMgSSBhbSBzdGVwcGluZyBkb3duIGFzIG1haW50YWludGVyLiBJIHdp bGwgc3RheQ0KPiBhcyByZXZpZXdlciBmb3IgeDg2IGNvZGUgKGZvciB3aGljaCBjcmVhdGUg YSBzZXBhcmF0ZSBjYXRlZ29yeSkuDQo+IA0KPiBTdGVmYW5vIGlzIG5vdyBtYWludGFpbmVy IGZvciBYZW4gaHlwZXJ2aXNvciBpbnRlcmZhY2UgYW5kIE9sZWtzYW5kciBoYXMNCj4gZ3Jh Y2lvdXNseSBhZ3JlZWQgdG8gYmVjb21lIGEgcmV2aWV3ZXIuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPg0KDQpB Y2tlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4N Cg== --------------JVGzJTU7EHLZVogaAy0EV5H0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JVGzJTU7EHLZVogaAy0EV5H0-- --------------0DjIufFJWt8ABv44kekpH6j3-- --------------6n9mlK7a06XGxuQM57dXnD24 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKRGEwFAwAAAAAACgkQsN6d1ii/Ey9V CAf+MaoYJD/rDFAeV4heIpwpxVq8qKItsYujG0PCTeGmPeTa46j0Tw+XSArqQxCbWzLY9FJB+ZmF fNHSjxHLi/Hm0S5Iq3+J7enlkemDhoZQ2zWvCJgsbfHwrukerSjz2jbkkWuGy/Z5cFJFNFDBTKED VBQxruJ0c9VVIwgEoCj0SDN1YIwT5tK2CZCyRttBpZcBcNnhg04I5XN3MoaiCCFerIETt9kE9Vwa 0uzuK9w52S/xfI2FbaE914mLGE0U+6oTZKlYqdQDlUSMG2RbLVJQdgbaPFG/NNmqgdEqZ3b86Lw7 cvOLAreKhZvaGN+zgxox/I9z1Zpdteh5caBZG8/bTw== =rRV2 -----END PGP SIGNATURE----- --------------6n9mlK7a06XGxuQM57dXnD24-- From xen-devel-bounces@lists.xenproject.org Fri May 27 18:43:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 18:43:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338125.562882 (Exim 4.92) (envelope-from ) id 1nuevD-0002kZ-3U; Fri, 27 May 2022 18:42:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338125.562882; Fri, 27 May 2022 18:42:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuevD-0002kS-06; Fri, 27 May 2022 18:42:51 +0000 Received: by outflank-mailman (input) for mailman id 338125; Fri, 27 May 2022 18:42:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuevB-0002kM-M0 for xen-devel@lists.xenproject.org; Fri, 27 May 2022 18:42:49 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce36f315-ddec-11ec-837f-e5687231ffcc; Fri, 27 May 2022 20:42:48 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id t13so6901497wrg.9 for ; Fri, 27 May 2022 11:42:48 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id l6-20020adff486000000b0020c5253d907sm2354149wro.83.2022.05.27.11.42.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 11:42:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce36f315-ddec-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/FfqEuqYsoYBH9BqWPgEI0X7vtMAlkOKI53z/x9ljKA=; b=a2c6NEIN3y/nYEhLsYo11LjIlTVy2FQXsq3C4LB3KwUdq0ld2EjY1vtjMquttnxNPd iewaBFDgbPbLmpffB7oZCVE7kTAnWZSfg8iUSkSXEtPrRUWX5o3wstSCurJ5xjKhgtyw 7FlPNtKgQPSWj1gPOSKfUOi+/y3arR5umOBZg1fE2QuvsENlkFn712csg9+Y5Gz7Hbo0 U5uJ29L/ZDgFN0TDAhs+2RNFVfpnMLSsgZfqE7uERxQMjJwMqDJKsw2q+R5sVm2cxHox 1QSlcrfuvo2Mt+GrFyhsIf8wbrdbCaOK4f1tWekfn5TCW1d25tbMUbCtYwn5she9fghW UmdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/FfqEuqYsoYBH9BqWPgEI0X7vtMAlkOKI53z/x9ljKA=; b=3lX04fxXfElxeRDlRGM9Pu7JF6Fyk4tbXXa4lx+GjFGvPK/1pa2vG7mNOEBRnEwIdK KpQVLzLXP9JtuHn70+USzFedIYAeCu7aFOVMwiNUekopRHc9R/A92kJKsrbJCxxmzwMY hKDt13QLKR/DyRzAhcu0V2SSMhXwIXYZKerUApl8E6JUaNfuvQ6eheqq2Zwn8pcCNehw Hiiusl0u0abHClh6dH7YyKVHlfF+RPUZe7UuE1Op1LZ8Kt9L/9Xi0RkwIOBMT0xr8wm4 utJqMfOn+T2i/vEnBeFuRyvwTxH5LCjmdmmtzFFYXGhYc96VF3v28FKUyHqJ4PT8b5Gd dB+A== X-Gm-Message-State: AOAM530dx1AiipTJj8JwfuRt503zLe1DZ1ZCCkI9ETAYLj3ha1mxVH9l QiqjMYqpVWLXvHnZM1XxJvw= X-Google-Smtp-Source: ABdhPJyU7aV3eXuKoLVF22q8YpyzjY/eyXUYrukOmK/dDtaDK5orO9Scgfdf/5bxWSM/kh24UIuTgg== X-Received: by 2002:a5d:5955:0:b0:20d:4b4:9879 with SMTP id e21-20020a5d5955000000b0020d04b49879mr35386889wri.550.1653676967872; Fri, 27 May 2022 11:42:47 -0700 (PDT) Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership To: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> From: Oleksandr Message-ID: <69716937-59d0-b316-2a42-94194c79320c@gmail.com> Date: Fri, 27 May 2022 21:42:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 27.05.22 20:57, Boris Ostrovsky wrote: Hello Boris > Due to time constraints I am stepping down as maintainter. I will stay > as reviewer for x86 code (for which create a separate category). > > Stefano is now maintainer for Xen hypervisor interface and Oleksandr has > graciously agreed to become a reviewer. > > Signed-off-by: Boris Ostrovsky Acked-by: Oleksandr Tyshchenko > --- > MAINTAINERS | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6d879cb0afd..b879c4e6750e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -21549,23 +21549,29 @@ F: arch/arm64/include/asm/xen/ > F: arch/arm64/xen/ > > XEN HYPERVISOR INTERFACE > -M: Boris Ostrovsky > M: Juergen Gross > -R: Stefano Stabellini > +M: Stefano Stabellini > +R: Oleksandr Tyshchenko > L: xen-devel@lists.xenproject.org (moderated for non-subscribers) > S: Supported > T: git git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > F: Documentation/ABI/stable/sysfs-hypervisor-xen > F: Documentation/ABI/testing/sysfs-hypervisor-xen > -F: arch/x86/include/asm/pvclock-abi.h > -F: arch/x86/include/asm/xen/ > -F: arch/x86/platform/pvh/ > -F: arch/x86/xen/ > F: drivers/*/xen-*front.c > F: drivers/xen/ > F: include/uapi/xen/ > F: include/xen/ > > +XEN HYPERVISOR X86 > +M: Juergen Gross > +R: Boris Ostrovsky > +L: xen-devel@lists.xenproject.org (moderated for non-subscribers) > +S: Supported > +F: arch/x86/include/asm/pvclock-abi.h > +F: arch/x86/include/asm/xen/ > +F: arch/x86/platform/pvh/ > +F: arch/x86/xen/ > + > XEN NETWORK BACKEND DRIVER > M: Wei Liu > M: Paul Durrant -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri May 27 18:47:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 18:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338133.562893 (Exim 4.92) (envelope-from ) id 1nuezu-0003OE-MH; Fri, 27 May 2022 18:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338133.562893; Fri, 27 May 2022 18:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuezu-0003O7-In; Fri, 27 May 2022 18:47:42 +0000 Received: by outflank-mailman (input) for mailman id 338133; Fri, 27 May 2022 18:47:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuezt-0003Nx-PR; Fri, 27 May 2022 18:47:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuezt-0000IF-OW; Fri, 27 May 2022 18:47:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuezt-00035X-7q; Fri, 27 May 2022 18:47:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuezt-0003KK-7N; Fri, 27 May 2022 18:47:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T083oux1Xp3Fnni28Kaxddqgv0e3FZN6YRvc9iqCb8E=; b=eQmzQ4iYcKyIX2XlGUUMBn51YT 7uLF22N1acUq5alnDdJGY7Nxd0J0q2+qcIxH5QDqJhLCxFNoOVxIbOA9OP1wSzv5Kq8A0BWwZD3K3 LzMmpQOhIFm3dDCJop4sAGvRLoFfJe0ROHIKsElRmBvyRtSkw59cLSQvqEFnGBTfMOyM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170755: all pass - PUSHED X-Osstest-Versions-This: ovmf=dac2fc8146e42ef19cd50ecbe32ccb7705b76fa3 X-Osstest-Versions-That: ovmf=16779ede2d366bfc6b702e817356ccf43425bcc8 From: osstest service owner Date: Fri, 27 May 2022 18:47:41 +0000 flight 170755 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170755/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf dac2fc8146e42ef19cd50ecbe32ccb7705b76fa3 baseline version: ovmf 16779ede2d366bfc6b702e817356ccf43425bcc8 Last test of basis 170746 2022-05-26 10:11:57 Z 1 days Testing same since 170755 2022-05-27 16:42:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gua Guo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 16779ede2d..dac2fc8146 dac2fc8146e42ef19cd50ecbe32ccb7705b76fa3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri May 27 23:17:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 23:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338144.562903 (Exim 4.92) (envelope-from ) id 1nujCc-0002lV-T2; Fri, 27 May 2022 23:17:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338144.562903; Fri, 27 May 2022 23:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujCc-0002lO-Pp; Fri, 27 May 2022 23:17:06 +0000 Received: by outflank-mailman (input) for mailman id 338144; Fri, 27 May 2022 23:17:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujCb-0002lI-SU for xen-devel@lists.xenproject.org; Fri, 27 May 2022 23:17:06 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d07d273-de13-11ec-bd2c-47488cf2e6aa; Sat, 28 May 2022 01:17:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8DAB6B82522; Fri, 27 May 2022 23:17:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83B1EC385A9; Fri, 27 May 2022 23:16:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d07d273-de13-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653693419; bh=nSrLvlSQGOWQqyI8E9zo5OQtk5lQb80DCDrGrAvAnuk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Zdx0G3Ug6kTMWmexx/lmsPc7LfD7SdhhWyDBy2im/bkpJTPubVqdxpZoJ0z3e5krK zR8DfvR0B+kRBVf2ig6pJw9h/scrQn9OFbsi78qUMjhgUo7JSCo2ABmwWYWilt0gId qP0FgpkaGoLOsC8mzf1U0VDJa+cMDN32tICruu0SzlEXsZYIvLgeWkkYpAnOykejy3 J+G6zkVcpY3ICyhdV7g2guji3h9hBoFeW+2sYWQEZhIUW6eVbfu4RdzbWUYqvRNcI1 +i9XJ6P4VlCSXBwBIcCelZ10rVUfy1mb2r3X8J15doCk3qn1FFEjXPnMg2WiPP3syv dtM7IbTUk+jSg== Date: Fri, 27 May 2022 16:16:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst In-Reply-To: Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-46585697-1653693419=:1905099" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-46585697-1653693419=:1905099 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 27 May 2022, Jan Beulich wrote: > On 26.05.2022 21:57, Stefano Stabellini wrote: > > On Thu, 26 May 2022, Bertrand Marquis wrote: > >>> On 26 May 2022, at 11:15, Jan Beulich wrote: > >>> On 26.05.2022 11:54, Bertrand Marquis wrote: > >>>>> On 26 May 2022, at 10:43, Jan Beulich wrote: > >>>>> On 26.05.2022 03:02, Stefano Stabellini wrote: > >>>>>> On Wed, 25 May 2022, Julien Grall wrote: > >>>>>>> On 25/05/2022 01:35, Stefano Stabellini wrote: > >>>>>>>> +- Rule: Dir 4.7 > >>>>>>>> + - Severity: Required > >>>>>>>> + - Summary: If a function returns error information then that error > >>>>>>>> information shall be tested > >>>>>>>> + - Link: > >>>>>>>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/D_04_07.c > >>>>>>> > >>>>>>> > >>>>>>> ... this one. We are using (void) + a comment when the return is ignored on > >>>>>>> purpose. This is technically not-compliant with MISRA but the best we can do > >>>>>>> in some situation. > >>>>>>> > >>>>>>> With your proposed wording, we would technically have to remove them (or not > >>>>>>> introduce new one). So I think we need to document that we are allowing > >>>>>>> deviations so long they are commented. > >>>>>> > >>>>>> Absolutely yes. All of these rules can have deviations as long as they > >>>>>> make sense and they are commented. Note that we still have to work out > >>>>>> a good tagging system so that ECLAIR and cppcheck can recognize the > >>>>>> deviations automatically but for now saying that they need to be > >>>>>> commented is sufficient I think. > >>>>>> > >>>>>> So I'll add the following on top of the file: > >>>>>> > >>>>>> """ > >>>>>> It is possible that in specific circumstances it is best not to follow a > >>>>>> rule because it is not possible or because the alternative leads to > >>>>>> better code quality. Those cases are called "deviations". They are > >>>>>> permissible as long as they are documented with an in-code comment. > >>>>>> """ > >>>>> > >>>>> Hmm, so you really mean in-code comments. I don't think this will scale > >>>>> well (see e.g. the DCE related intended deviation), and it also goes > >>>>> against the "no special casing for every static analysis tool" concern > >>>>> I did voice on the call. > >>>> > >>>> On this subject the idea was more to define a “xen” way to document > >>>> deviations in the code and do it in a way so that we could easily substitute > >>>> the “flag” to adapt it for each analyser using tools or command line options. > >>> > >>> I think the basic scheme of something like this would want laying out > >>> before doc changes like the one here actually go in, so that it's clear > >>> what the action is if a new deviation needs adding for whatever reason > >>> (and also allowing interested people to start contributing patches to > >>> add respective annotations). > >> > >> We will work on that but if we wait for everything to be solved we will > >> never progress. > >> I have a task on my side (ie at arm) to work on that and Luca Fancellu > >> will start working on it next month. > >> Now I do not think that this should block this patch, agreeing on rules does > >> not mean will respect all of them in the short term so we can wait a bit as I > >> definitely think that how to document violations in the code and in general > >> will be a work package on its own and will require some discussion. > > > > Right. > > > > In general, we'll need to document these deviations and ideally they > > would be documented as in-code comments because they are easier to keep > > in sync with the code. But we won't be able to do that in all cases. > > > > We'll also need a special TAG to mark the deviation. Nobody wants > > multiple tagging systems for different tools (ECLAIR, cppcheck, > > Coverity, etc.) We'll come up with one tagging system and introduce > > conversion scripts as needed. Roberto offered to help on the call to > > come up with a generic tagging system. > > > > In some cases in-code comments for every deviation would be too verbose. > > We'll want to handle it in another way. It could be a document > > somewhere else, or simply disabling the Rules check in ECLAIR/cppcheck > > (but that partially defeats the purpose.) We'll have to see. I think > > it is going to be on a case by case basis. > > > > > > In short, I don't think we have all the info and expertise to come up > > with a good deviation system right now. We need to make more progress > > and analize a few specific examples before we can do that. But to gain > > that expertise we need to agree on a set of rules we want to follow > > first, which is this patch series. > > > > > > So, I think this is the best way we can start the process. We can > > clarify further with the comment on top of this file, and we could even > > remove the specific part about the "in-code comment" with an open-ended > > statement until we come up with a clear deviation strategy. For > > instance: > > > > """ > > It is possible that in specific circumstances it is best not to follow a > > rule because it is not possible or because the alternative leads to > > better code quality. Those cases are called "deviations". They are > > permissible as long as they are documented. > > > > The existing codebase is not 100% compliant with the rules. Some of the > > violations are meant to be documented as deviations, while some others > > should be fixed. Both compliance and documenting deviations on the > > existing codebase is work-in-progress. > > """ > > This is better, yes, yet I'm still concerned of "existing codebase": > Without it being clear how to deal with deviations, what would we do > with new additions of deviations? We need to be able to say something > concrete in review comments, and prior to getting any review comments > people should at least stand a chance of being able to figure out > what's expected of them. I think you are right that it would be nice to provide a guideline for new patches. Even a simple one. For new patches, if it is not an in-code comment it could be part of the commit message. (Also it is unlikely that a new patch would introduce very many new deviations.) What about the following: """ It is possible that in specific circumstances it is best not to follow a rule because it is not possible or because the alternative leads to better code quality. Those cases are called "deviations". They are permissible as long as they are documented, either as an in-code comment or as part of the commit message. Other documentation mechanisms are work-in-progress. The existing codebase is not 100% compliant with the rules. Some of the violations are meant to be documented as deviations, while some others should be fixed. Both compliance and documenting deviations on the existing codebase are work-in-progress. """ The goal is to provide a basic frame of reference for new patches, while also saying that we are still working on the documentation system. --8323329-46585697-1653693419=:1905099-- From xen-devel-bounces@lists.xenproject.org Fri May 27 23:51:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 27 May 2022 23:51:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338152.562915 (Exim 4.92) (envelope-from ) id 1nujk0-0006oW-Js; Fri, 27 May 2022 23:51:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338152.562915; Fri, 27 May 2022 23:51:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujk0-0006oP-GL; Fri, 27 May 2022 23:51:36 +0000 Received: by outflank-mailman (input) for mailman id 338152; Fri, 27 May 2022 23:51:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujjz-0006oF-17; Fri, 27 May 2022 23:51:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujjy-0005e7-UH; Fri, 27 May 2022 23:51:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nujjy-0003s2-FH; Fri, 27 May 2022 23:51:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nujjy-000078-Eo; Fri, 27 May 2022 23:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jDYmC0za0gYlmHd3UOdocR9MZYetUZh/oTaCYeFBoNM=; b=12NUVl6prp71S5FzmQVmTt4ELu U+GMxQAaZoEZ9esZ3JTsSkoEgqpO6/YT2JONIudbk/+L7SWvqJnfdddGK5Ve8aq+bmRFjQrNFjMBq ey7T2GomI2HTYjj6z7c7vnGpZEjMfaVZVi0VX+/JQcqFai+YZcZSa3oAQrFnFN6+DsHY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170754: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=272be013d3d3a3218ea7800c579d0e144da679ca X-Osstest-Versions-That: qemuu=2417cbd5916d043e0c56408221fbe9935d0bc8da From: osstest service owner Date: Fri, 27 May 2022 23:51:34 +0000 flight 170754 qemu-mainline real [real] flight 170757 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170754/ http://logs.test-lab.xenproject.org/osstest/logs/170757/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 20 guest-start/debian.repeat fail pass in 170757-retest test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 170757-retest test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 170757-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170749 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170749 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170749 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170749 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170749 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170749 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170749 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170749 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 272be013d3d3a3218ea7800c579d0e144da679ca baseline version: qemuu 2417cbd5916d043e0c56408221fbe9935d0bc8da Last test of basis 170749 2022-05-26 16:39:34 Z 1 days Testing same since 170754 2022-05-27 15:39:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Kardashevskiy Bernhard Beschow Daniel Henrique Barboza Frederic Barrat Joel Stanley Leandro Lupori Lucas Mateus Castro (alqotel) Matheus Ferst Murilo Opsfelder Araujo Nicholas Piggin Paolo Bonzini Richard Henderson Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 2417cbd591..272be013d3 272be013d3d3a3218ea7800c579d0e144da679ca -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat May 28 01:46:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 01:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338163.562926 (Exim 4.92) (envelope-from ) id 1nulWv-0007a4-MD; Sat, 28 May 2022 01:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338163.562926; Sat, 28 May 2022 01:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nulWv-0007Zx-Hf; Sat, 28 May 2022 01:46:13 +0000 Received: by outflank-mailman (input) for mailman id 338163; Sat, 28 May 2022 01:46:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nulWt-0007Zn-Gl; Sat, 28 May 2022 01:46:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nulWt-00063H-DT; Sat, 28 May 2022 01:46:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nulWs-0006Le-R6; Sat, 28 May 2022 01:46:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nulWs-00008J-Qg; Sat, 28 May 2022 01:46:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=saSZ/hwI2GnfTsycQH1BUoQryheUjvvlpJH3CUQ5SJY=; b=OOf8NSzpJnUlsApOotEOECQ0ZA geGZXzCdrjkv9T6ev6eSCKgzNlLb6FRlWKp3u863ObULhx3m1uyG/i+TGoOjxLCMMRR9+puv7jAIr seWQK9g6g3HsCLjomJmK0xSpy4wj0a2CPtpRlE9oEcF7dQCNsUgEoYPa/ewX4lG6nLUc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170756: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-armhf-armhf-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=7e284070abe53d448517b80493863595af4ab5f0 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sat, 28 May 2022 01:46:10 +0000 flight 170756 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170756/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 build-arm64-pvops 6 kernel-build fail REGR. vs. 170714 test-armhf-armhf-xl 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 8 xen-boot fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 8 xen-boot fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 7e284070abe53d448517b80493863595af4ab5f0 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 3 days Failing since 170716 2022-05-24 11:12:06 Z 3 days 9 attempts Testing same since 170753 2022-05-27 06:45:13 Z 0 days 2 attempts ------------------------------------------------------------ 1755 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine fail test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 187821 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 28 09:47:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 09:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338178.562937 (Exim 4.92) (envelope-from ) id 1nut2A-0002Ay-Kg; Sat, 28 May 2022 09:46:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338178.562937; Sat, 28 May 2022 09:46:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nut2A-0002Ap-EV; Sat, 28 May 2022 09:46:58 +0000 Received: by outflank-mailman (input) for mailman id 338178; Sat, 28 May 2022 09:46:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nut29-0002Af-Ik; Sat, 28 May 2022 09:46:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nut29-0007OG-FW; Sat, 28 May 2022 09:46:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nut28-0001Cm-Ts; Sat, 28 May 2022 09:46:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nut28-0003Bx-TR; Sat, 28 May 2022 09:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0VGNH5oMEevc3kZXpVHcnA7rhzNoVJAsp+yIdREn2cw=; b=zY5yVlsTg26Wt7ApU3D1zdn5ju P9H17+sLPDDza9uxmjaRFuymKaQcIJrFIJrXcAORJZPq5xIs4n58AtKByv6hkCYs3poe9HprBF1UO ROZMsnnB/aIsd4gF1yURyguHd5J5+n77tYaSC6R0XqBvWaabnkYnHN2NG5b5StpYUguw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170759: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=a9f94826e4bb6402e67f3eb849dee0811f1de6da X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sat, 28 May 2022 09:46:56 +0000 flight 170759 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170759/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 build-armhf-pvops 6 kernel-build fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 build-arm64-pvops 6 kernel-build fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux a9f94826e4bb6402e67f3eb849dee0811f1de6da baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 4 days Failing since 170716 2022-05-24 11:12:06 Z 3 days 10 attempts Testing same since 170759 2022-05-28 01:55:53 Z 0 days 1 attempts ------------------------------------------------------------ 1848 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 199780 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 28 10:28:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 10:28:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338189.562948 (Exim 4.92) (envelope-from ) id 1nutgf-0006RL-Tw; Sat, 28 May 2022 10:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338189.562948; Sat, 28 May 2022 10:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nutgf-0006RE-Qx; Sat, 28 May 2022 10:28:49 +0000 Received: by outflank-mailman (input) for mailman id 338189; Sat, 28 May 2022 10:28:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nutge-0006R4-HN; Sat, 28 May 2022 10:28:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nutge-0008A6-DG; Sat, 28 May 2022 10:28:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nutgd-00025w-Rq; Sat, 28 May 2022 10:28:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nutgd-0006Ft-RO; Sat, 28 May 2022 10:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LpZNkjsN4y+veGLTffUFU9eLO2ItTD59rRGM0N96idg=; b=BeHWfU/TjHcqXKs9j/bdzBBLLs FPZwXKMzWLp45lkwyS7YuZ66wZXJK5nr0VcSBd8ivmAGbXGY0x3RuyKpvj7sa/wbiAFgWp63OKSFE Oc8UHrwlzYmdcU02lxmu0vIk6Ncct+CHJmhatfuf6tu3G8e8S/Gyf5lJUm/5eiK8TrM0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170760: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a5d9c7062162ff6404e62473a5cba7442e188d27 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 28 May 2022 10:28:47 +0000 flight 170760 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170760/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt a5d9c7062162ff6404e62473a5cba7442e188d27 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 687 days Failing since 151818 2020-07-11 04:18:52 Z 686 days 668 attempts Testing same since 170760 2022-05-28 04:20:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 110101 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 28 11:47:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 11:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338199.562959 (Exim 4.92) (envelope-from ) id 1nuuud-0005dg-Ow; Sat, 28 May 2022 11:47:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338199.562959; Sat, 28 May 2022 11:47:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuuud-0005dZ-KS; Sat, 28 May 2022 11:47:19 +0000 Received: by outflank-mailman (input) for mailman id 338199; Sat, 28 May 2022 11:47:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuuuc-0005dP-3V; Sat, 28 May 2022 11:47:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuuub-00016y-R0; Sat, 28 May 2022 11:47:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuuub-0005Ed-7q; Sat, 28 May 2022 11:47:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuuub-0005Cw-7Q; Sat, 28 May 2022 11:47:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MfCELf/pKRPFyHvD72MQUpVFiddqHcpc8vT1nwfJyEg=; b=CRHDtdY2UPBn+ufsVdxV+WNr/N 5iATQhSzRtoLHBZEmv0CL3GNOOwvwRHPu4nzBIYVloPBuefn1zwy/oeMxNdbD4f6fAvBl8MI5SxiF gkUg4zIgofYulQUfqCDtTw8iHV7tuqZx8WBBEFRLr0E78pnfllpx4/X9fnJBiwoVP5Zw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170758: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Sat, 28 May 2022 11:47:17 +0000 flight 170758 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 170751 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 19 guest-start.2 fail blocked in 170751 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 170740 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170751 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170751 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170751 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170751 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170751 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170751 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170751 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170751 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170751 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170751 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170751 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170751 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170758 2022-05-28 01:53:01 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat May 28 14:17:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 14:17:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338214.562973 (Exim 4.92) (envelope-from ) id 1nuxFW-0003VA-NC; Sat, 28 May 2022 14:17:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338214.562973; Sat, 28 May 2022 14:17:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuxFW-0003V3-J1; Sat, 28 May 2022 14:17:02 +0000 Received: by outflank-mailman (input) for mailman id 338214; Sat, 28 May 2022 14:17:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuxFV-0003Ut-Pq; Sat, 28 May 2022 14:17:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuxFV-0003nD-Mi; Sat, 28 May 2022 14:17:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nuxFV-0000aD-D4; Sat, 28 May 2022 14:17:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nuxFV-0002TR-Ch; Sat, 28 May 2022 14:17:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XO0G23eMrjzBKYLS3ZqzxDrKRvefu6un9QDQ16yb2G4=; b=5lh1t0JEC8al8HgALTi5W22MYv EiXt3ydGFsuavaCHIT9fk9TFdrcox7m1MSqRsztpkQJGBPmqN5KRhamnUYiDr1t6HeodOUBjZ5LR8 xKMPZT/ZnTw2Yacey3dsymx9uKCXxCJ5dMb3wOUA3fyWpuHrvUet/IAyFFBNfkOPSy7U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170761: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=9d004b2f4fea97cde123e7f1939b80e77bf2e695 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sat, 28 May 2022 14:17:01 +0000 flight 170761 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170761/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 build-armhf-pvops 6 kernel-build fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 build-arm64-pvops 6 kernel-build fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 9d004b2f4fea97cde123e7f1939b80e77bf2e695 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 4 days Failing since 170716 2022-05-24 11:12:06 Z 4 days 11 attempts Testing same since 170761 2022-05-28 10:12:28 Z 0 days 1 attempts ------------------------------------------------------------ 1850 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 200883 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 28 19:18:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 19:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338225.562984 (Exim 4.92) (envelope-from ) id 1nv1wa-0005ye-5Z; Sat, 28 May 2022 19:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338225.562984; Sat, 28 May 2022 19:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv1wa-0005yX-2l; Sat, 28 May 2022 19:17:48 +0000 Received: by outflank-mailman (input) for mailman id 338225; Sat, 28 May 2022 19:17:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv1wZ-0005yN-AP; Sat, 28 May 2022 19:17:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv1wZ-00016t-7I; Sat, 28 May 2022 19:17:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv1wY-0000an-M0; Sat, 28 May 2022 19:17:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nv1wY-0003PY-La; Sat, 28 May 2022 19:17:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6Qy2HgTbLTENip5Ho0QCg0l1PpSd+E1oBqKanS4Kl9E=; b=4qWN5Xnn8Bdybw6hXCKaQrvBLi pWAMUuRwHCEOtlrQww18CDWgoxm8iYj4n9UFA2+POR9dPqEsa00Vw/w+qlmd9l1YisblOHnuPD5C9 Q/SMXsnCb1J+kAH9QuLMltNerSsnEX+Fwua/X9pOlSGWMsSAYW7mRE74nqHoQo8TGtiI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170763: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=9d004b2f4fea97cde123e7f1939b80e77bf2e695 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sat, 28 May 2022 19:17:46 +0000 flight 170763 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170763/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 build-armhf-pvops 6 kernel-build fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 build-arm64-pvops 6 kernel-build fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 9d004b2f4fea97cde123e7f1939b80e77bf2e695 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 4 days Failing since 170716 2022-05-24 11:12:06 Z 4 days 12 attempts Testing same since 170761 2022-05-28 10:12:28 Z 0 days 2 attempts ------------------------------------------------------------ 1850 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 200883 lines long.) From xen-devel-bounces@lists.xenproject.org Sat May 28 21:24:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 21:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338239.562995 (Exim 4.92) (envelope-from ) id 1nv3uo-0001Gw-JI; Sat, 28 May 2022 21:24:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338239.562995; Sat, 28 May 2022 21:24:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv3uo-0001Gp-Fe; Sat, 28 May 2022 21:24:06 +0000 Received: by outflank-mailman (input) for mailman id 338239; Sat, 28 May 2022 21:24:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv3un-0001Gj-1a for xen-devel@lists.xenproject.org; Sat, 28 May 2022 21:24:05 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f52c325-decc-11ec-837f-e5687231ffcc; Sat, 28 May 2022 23:24:03 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id z17so4435685wmf.1 for ; Sat, 28 May 2022 14:24:03 -0700 (PDT) Received: from ?IPv6:::1? (p200300faaf303d006df08acd6a055550.dip0.t-ipconnect.de. [2003:fa:af30:3d00:6df0:8acd:6a05:5550]) by smtp.gmail.com with ESMTPSA id m7-20020adffe47000000b0020d0b2de858sm4910784wrs.33.2022.05.28.14.24.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 May 2022 14:24:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f52c325-decc-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:references:message-id :mime-version:content-transfer-encoding; bh=zIGHVshfh/VikUqvKrvhXfm7K5EaTaFbPI9k1R3B3QM=; b=Gjof+E9drLhCJstlob0ryE+KdjAqFu1orco5bOHUPfM49537XQd68rMwJbcjhhX0H/ M0yM3xp+PkuXyiTTvaBXWS8bpekqZ0zad7gLdEUu/QfXqDdywXBUoIXrkuxhLYByRjfa wlbe0QLvtxou6rDlpyW3BVmP04hnz6aOt/DHkpN0dcIAB/yagxYB6Ldldfk5gEBIlz3c m22hF+nvtITy3fc9urmarP6a6y2ehC58medtCwWn0aMcL+LoJ/Ai9XtOYxONMN9af07f UIlPFwTTNsbfgF0DuoL1Iw8SNjOaalMhv0gIA+x948VQMmLqsRRO0B5ofDEP1L8RxFmA wsaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=zIGHVshfh/VikUqvKrvhXfm7K5EaTaFbPI9k1R3B3QM=; b=iRT/GO3ZA6KIW4WeaWbNHKgA4qgZcjsWGy881Vp8DX5Zmzz360C3expMinG+88/IA9 EKZdbKkHTr4IVmTpf6WQxDBmGJCWY+Bv+/gsggJJndDByh7HxpFeD8CUcFoO8RsAcUXz jM53lIVVTnPBfMTYpG9Lq/rqXQiNrvSDzzTcjfoPsNHHsqkWQBl8SqL7tWsltBBF1w4d 8yjBJQhOd0xQ2RocKWlUk3NGx54IiOiibqKnQ0s4kb2wwyKlpPcQxWnnYz38xJvrrH56 6hYt74dWJQtgjI3aN9lgSiqUJ+LN9ANHSz0yR82w4VDbRb1VAr4NI3nYlo6HUwBpEA31 J35Q== X-Gm-Message-State: AOAM530FprrPrqEqGMRe8W8g9tuUJkdN8751Y5nDfBrPJ8Zg09f9DE8i MO0sZRdkF6DaCNjpTZ2MVF5X5p0rv+8= X-Google-Smtp-Source: ABdhPJzM9lqK4t3eYGzDQhKxZ49/sjKHJV1WyZZnqIKb08Qqj95EeFlTziQwrbxrhf49U8rQCfjscA== X-Received: by 2002:a05:600c:3ac6:b0:397:7520:c78e with SMTP id d6-20020a05600c3ac600b003977520c78emr12548506wms.23.1653773042858; Sat, 28 May 2022 14:24:02 -0700 (PDT) Date: Sat, 28 May 2022 21:23:57 +0000 From: Bernhard Beschow To: qemu-devel@nongnu.org CC: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 0/3] PIIX3-IDE XEN cleanup In-Reply-To: <20220513180957.90514-1-shentey@gmail.com> References: <20220513180957.90514-1-shentey@gmail.com> Message-ID: <43BCAA1E-7499-4584-AB60-C5004AA0643B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 13=2E Mai 2022 18:09:54 UTC schrieb Bernhard Beschow : >v2: >* Have pci_xen_ide_unplug() return void (Paul Durrant) >* CC Xen maintainers (Michael S=2E Tsirkin) > >v1: >This patch series first removes the redundant "piix3-ide-xen" device clas= s and >then moves a XEN-specific helper function from PIIX3 code to XEN code=2E = The idea >is to decouple PIIX3-IDE and XEN and to compile XEN-specific bits only if= XEN >support is enabled=2E > >Testing done: >'qemu-system-x86_64 -M pc -m 1G -cdrom archlinux-2022=2E05=2E01-x86_64=2E= iso" boots >successfully and a 'poweroff' inside the VM also shuts it down correctly= =2E > >XEN mode wasn't tested for the time being since its setup procedure seems= quite >sophisticated=2E Please let me know in case this is an obstacle=2E > >Bernhard Beschow (3): > hw/ide/piix: Remove redundant "piix3-ide-xen" device class > hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() > include/hw/ide: Unexport pci_piix3_xen_ide_unplug() > > hw/i386/pc_piix=2Ec | 3 +-- > hw/i386/xen/xen_platform=2Ec | 48 +++++++++++++++++++++++++++++++++++++- > hw/ide/piix=2Ec | 42 --------------------------------- > include/hw/ide=2Eh | 3 --- > 4 files changed, 48 insertions(+), 48 deletions(-) > Ping Whole series is reviewed/acked=2E From xen-devel-bounces@lists.xenproject.org Sat May 28 23:33:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 28 May 2022 23:33:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338247.563006 (Exim 4.92) (envelope-from ) id 1nv5wB-0004sj-UI; Sat, 28 May 2022 23:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338247.563006; Sat, 28 May 2022 23:33:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv5wB-0004sc-RL; Sat, 28 May 2022 23:33:39 +0000 Received: by outflank-mailman (input) for mailman id 338247; Sat, 28 May 2022 23:33:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv5wA-0004sS-7z; Sat, 28 May 2022 23:33:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv5wA-0005Y4-4q; Sat, 28 May 2022 23:33:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv5w9-0005DU-JY; Sat, 28 May 2022 23:33:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nv5w9-00068u-J4; Sat, 28 May 2022 23:33:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0IE8x0p4emVBlSabD041geJs/qWx6RG6EftoV1WHu6Y=; b=st55/TCyAwDSaQRTgqT8IQWyOP sMuy70S9aOoKnAZL5DYiAbvrSYPCf2yo21y7oW2+OjonHd5NwJtohWxqMcTqypDVtlN2AUoIe1F64 rq1QFg6rLm/oK8/NWIGtjMkMOW8acwWaB7jF9eGFGz6UPh4hV7s6VVRllN5MPo14Z8gM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170764: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0234342e0ea9411ad032dac61f3d632536bda789 X-Osstest-Versions-That: qemuu=272be013d3d3a3218ea7800c579d0e144da679ca From: osstest service owner Date: Sat, 28 May 2022 23:33:37 +0000 flight 170764 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170764/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170754 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170754 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170754 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170754 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170754 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170754 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170754 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170754 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 0234342e0ea9411ad032dac61f3d632536bda789 baseline version: qemuu 272be013d3d3a3218ea7800c579d0e144da679ca Last test of basis 170754 2022-05-27 15:39:34 Z 1 days Testing same since 170764 2022-05-28 18:38:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Helge Deller Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 272be013d3..0234342e0e 0234342e0ea9411ad032dac61f3d632536bda789 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun May 29 02:22:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 29 May 2022 02:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338257.563016 (Exim 4.92) (envelope-from ) id 1nv8Ys-0002lJ-Dp; Sun, 29 May 2022 02:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338257.563016; Sun, 29 May 2022 02:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv8Ys-0002lC-Aj; Sun, 29 May 2022 02:21:46 +0000 Received: by outflank-mailman (input) for mailman id 338257; Sun, 29 May 2022 02:21:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv8Yr-0002l2-DU; Sun, 29 May 2022 02:21:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv8Yr-0007L0-A5; Sun, 29 May 2022 02:21:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nv8Yq-0000bP-RR; Sun, 29 May 2022 02:21:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nv8Yq-0008P3-R0; Sun, 29 May 2022 02:21:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cVCwwNSUspIGVA7G5KqgCjyU3Nwmy2V2AOrGknISQko=; b=iJIwqTZIUyINRHTBlHDlZ/oiiN /eZ10mTv4qEYcpKDb51jleRvJ8SvNVUkfXzdMCvYseW6gk8gMql2dM9UOe7B9YxsZ2TlpYW1Kz/P3 j0ltSp/lnKTYRl2sWA8E2ODLsTdmC/qRLlWsPwvm80qWtt8mA+E0me5ylIcYyUZllzBQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170765: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=f56dbdda4322d33d485f3d30f3aabba71de9098c X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sun, 29 May 2022 02:21:44 +0000 flight 170765 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170765/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux f56dbdda4322d33d485f3d30f3aabba71de9098c baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 4 days Failing since 170716 2022-05-24 11:12:06 Z 4 days 13 attempts Testing same since 170765 2022-05-28 19:41:19 Z 0 days 1 attempts ------------------------------------------------------------ 1897 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 208598 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 29 10:30:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 29 May 2022 10:30:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338271.563028 (Exim 4.92) (envelope-from ) id 1nvGBu-00064D-5f; Sun, 29 May 2022 10:30:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338271.563028; Sun, 29 May 2022 10:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvGBu-000646-2C; Sun, 29 May 2022 10:30:34 +0000 Received: by outflank-mailman (input) for mailman id 338271; Sun, 29 May 2022 10:30:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvGBs-00063w-LA; Sun, 29 May 2022 10:30:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvGBs-0008L0-I4; Sun, 29 May 2022 10:30:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvGBs-0004Nd-5Q; Sun, 29 May 2022 10:30:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvGBs-0005wA-4y; Sun, 29 May 2022 10:30:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SXDG+WPxseJfe4owz9M6t/h6M+eJMigLFgcp2eDvtXw=; b=Nk0Gp2rLRLNpmeVJnmNeKIdGdD /NhmjjD1pDe1e4ngrOuiCVVzvi3d/jduWdSE4GItyv0U/R4wmx8pPCNoXqPzGp4m4iua7/TnFnsg+ JEDSexaKPFI+qNQmH6H18/gkuuWYyirVRUK6cMq1okEod3TQYeBI9JQ0GzBDQdhHlFcM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170768: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a5d9c7062162ff6404e62473a5cba7442e188d27 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 29 May 2022 10:30:32 +0000 flight 170768 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170768/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt a5d9c7062162ff6404e62473a5cba7442e188d27 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 688 days Failing since 151818 2020-07-11 04:18:52 Z 687 days 669 attempts Testing same since 170760 2022-05-28 04:20:24 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 110101 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 29 11:41:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 29 May 2022 11:41:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338281.563039 (Exim 4.92) (envelope-from ) id 1nvHIV-0004Ta-EP; Sun, 29 May 2022 11:41:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338281.563039; Sun, 29 May 2022 11:41:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvHIV-0004TT-BT; Sun, 29 May 2022 11:41:27 +0000 Received: by outflank-mailman (input) for mailman id 338281; Sun, 29 May 2022 11:41:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvHIT-0004TJ-HK; Sun, 29 May 2022 11:41:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvHIT-000141-DI; Sun, 29 May 2022 11:41:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvHIS-0005x7-N7; Sun, 29 May 2022 11:41:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvHIS-0003C2-Md; Sun, 29 May 2022 11:41:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6d0nH7UGFNEVgHZPc3v1OycFoh7EFhfjR5a1d/f1CLs=; b=CIt1E+eCPTqPv+hyYc/W/1XiLs vyfcjrZ9nggcUt9kvuHuCtQsc2uoDu2wm9CIyp40ADKXaiUK45inrdxytcWfGMMNvF/2p/OAag5cR R2UyBAlPqaH+2l5OOdpPAa5mOMR39LcO9t2Bmff//0CrX0FwzhF5zXLq+lEvAyFnIDx0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170766: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Sun, 29 May 2022 11:41:24 +0000 flight 170766 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170766/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170751 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170758 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170758 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170758 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170758 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170758 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170758 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170758 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170758 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170758 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170758 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170758 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170758 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170766 2022-05-29 01:54:31 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun May 29 12:33:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 29 May 2022 12:33:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338292.563049 (Exim 4.92) (envelope-from ) id 1nvI6U-00019m-Hd; Sun, 29 May 2022 12:33:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338292.563049; Sun, 29 May 2022 12:33:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvI6U-00019f-Ea; Sun, 29 May 2022 12:33:06 +0000 Received: by outflank-mailman (input) for mailman id 338292; Sun, 29 May 2022 12:33:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvI6T-00019V-1Z; Sun, 29 May 2022 12:33:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvI6S-0001uw-Ue; Sun, 29 May 2022 12:33:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvI6S-000765-EW; Sun, 29 May 2022 12:33:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvI6S-0006AW-E2; Sun, 29 May 2022 12:33:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iKh2EP2nNq7syI0iDibvNL9WLPT5OaCGXg/6VkrBoRY=; b=os1lT4rPsn6cmlUzXaqgBEnzzC QoSYHdBs8YJ1gRqrFhCWaa8Bdtml/YeH8JrXoDS73Vvlf7VaEQ+j4L3TkDfDxcC/w2KnjAqzv5y4X XBEh28A19NzwvPSStd6p5MRjyR9e0h51EyI9wiobyAGNb/QLlMYodczJW6ykhj9fxcGk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170767: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=664a393a2663a0f62fc1b18157ccae33dcdbb8c8 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sun, 29 May 2022 12:33:04 +0000 flight 170767 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170767/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 664a393a2663a0f62fc1b18157ccae33dcdbb8c8 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 5 days Failing since 170716 2022-05-24 11:12:06 Z 5 days 14 attempts Testing same since 170767 2022-05-29 02:22:54 Z 0 days 1 attempts ------------------------------------------------------------ 1905 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 209297 lines long.) From xen-devel-bounces@lists.xenproject.org Sun May 29 18:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 29 May 2022 18:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338302.563061 (Exim 4.92) (envelope-from ) id 1nvNlD-0002av-2h; Sun, 29 May 2022 18:35:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338302.563061; Sun, 29 May 2022 18:35:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvNlC-0002ao-Uk; Sun, 29 May 2022 18:35:30 +0000 Received: by outflank-mailman (input) for mailman id 338302; Sun, 29 May 2022 18:35:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvNlB-0002ae-UK; Sun, 29 May 2022 18:35:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvNlB-00008R-RY; Sun, 29 May 2022 18:35:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvNlB-0000A8-8I; Sun, 29 May 2022 18:35:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvNlB-0000dj-7q; Sun, 29 May 2022 18:35:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UrMAttafcPK948i6uPIJpCCQJeAcMWLOFrhw/DPxfkc=; b=hpAQaargyIUvQgNPVBKtno4EAj 4xYLD4uzYBH2Uz03WFEtgCsDFPBljjgrlfzM2eASHOIX7hD9hbcO0HaAhFKpRUypOqC7hltZQIU5v TUeY5Y4nQICcj8wNfwe6CZVO9BNp+sVL4ycppeq4HJi7t0EbIbxqZOqh0yaD3yvA8vo0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170769: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=664a393a2663a0f62fc1b18157ccae33dcdbb8c8 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Sun, 29 May 2022 18:35:29 +0000 flight 170769 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170769/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine-bios 8 reboot fail pass in 170767 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 664a393a2663a0f62fc1b18157ccae33dcdbb8c8 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 5 days Failing since 170716 2022-05-24 11:12:06 Z 5 days 15 attempts Testing same since 170767 2022-05-29 02:22:54 Z 0 days 2 attempts ------------------------------------------------------------ 1905 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 209297 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 00:10:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 00:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338313.563072 (Exim 4.92) (envelope-from ) id 1nvSyq-0007x8-7U; Mon, 30 May 2022 00:09:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338313.563072; Mon, 30 May 2022 00:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvSyq-0007x1-4n; Mon, 30 May 2022 00:09:56 +0000 Received: by outflank-mailman (input) for mailman id 338313; Mon, 30 May 2022 00:09:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvSyo-0007wm-BU; Mon, 30 May 2022 00:09:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvSyo-0006pb-8J; Mon, 30 May 2022 00:09:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvSyn-00015Z-Jp; Mon, 30 May 2022 00:09:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvSyn-0002aE-JJ; Mon, 30 May 2022 00:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4UrlQ02pq6Vs+WoD+OHptd+EpRSSvettdzBLpRYBV3s=; b=DK/0XEXwlUiDcymVoEu2LB4Rks sXqv3gkhKmU0n5yHnusXM/EGDjROKkWsw9ULY+Ztmf7XwhEB/sudxhNZ3IyJdVH2DE1gy7YTNj3+b 1sgKnbdfCUyuxQmOlHhxHbJQMOqwqxkpq+3c8Y8vGD9XJbwMfcQu9xYkyq2MrmnxcohE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170770: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=c3a9a3c5f5590e85da15d6201e415ff636fe5670 X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Mon, 30 May 2022 00:09:53 +0000 flight 170770 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170770/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux c3a9a3c5f5590e85da15d6201e415ff636fe5670 baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 5 days Failing since 170716 2022-05-24 11:12:06 Z 5 days 16 attempts Testing same since 170770 2022-05-29 18:42:07 Z 0 days 1 attempts ------------------------------------------------------------ 1919 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 212358 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 01:47:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 01:47:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338324.563082 (Exim 4.92) (envelope-from ) id 1nvUUg-0007Af-Dk; Mon, 30 May 2022 01:46:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338324.563082; Mon, 30 May 2022 01:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvUUg-0007AY-AX; Mon, 30 May 2022 01:46:54 +0000 Received: by outflank-mailman (input) for mailman id 338324; Mon, 30 May 2022 01:46:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvUUf-0007AS-GJ for xen-devel@lists.xenproject.org; Mon, 30 May 2022 01:46:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e0fb39b-dfba-11ec-837f-e5687231ffcc; Mon, 30 May 2022 03:46:50 +0200 (CEST) Received: from AS9PR06CA0268.eurprd06.prod.outlook.com (2603:10a6:20b:45f::19) by VI1PR08MB2638.eurprd08.prod.outlook.com (2603:10a6:802:1f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Mon, 30 May 2022 01:46:44 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::48) by AS9PR06CA0268.outlook.office365.com (2603:10a6:20b:45f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 01:46:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 01:46:43 +0000 Received: ("Tessian outbound 3314dea8c23c:v119"); Mon, 30 May 2022 01:46:43 +0000 Received: from cb9874afc670.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B9EB1739-4219-49AD-B879-1E001EE9DC3E.1; Mon, 30 May 2022 01:46:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb9874afc670.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 May 2022 01:46:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB7PR08MB3564.eurprd08.prod.outlook.com (2603:10a6:10:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Mon, 30 May 2022 01:46:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d%5]) with mapi id 15.20.5293.019; Mon, 30 May 2022 01:46:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e0fb39b-dfba-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QaCiUhp9l/wTlHr5+/CVEZQod3NwqzOsA+O+WvIBjhRvYCxLgfoC3ywsHPj/0tfobYlaM1rM1csMzbAHgntqy+q1Uh7hXBYHKid7z6Xcdjov1+vHuoV4dEN5Vd245cT90ihuF13Vvt+n/WcFujQtbcL0Lt2ArJhSG98YU1Pa7bK14MO3rgVqjtdiynzVuUrTAauVi7WLecVJtkWtQ88RQwKnK3obhjlS+cXBMHir2SZd0V5oceekrGIq3u4Lc94ApfApNK3Ma8Cjck59k12Hbl8na419rhQGjlbQGra/zFm1ZDjOVaSy4gTE3+ULgnhNgO42/GeJopcFTkVl3lTmZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IygYdjhWRBIlBtx6R14du6juZZZeYS99CvQ/hCkgHLo=; b=BMKN/v7blcikn7vE3TlMFr0sBl86S1dG8O8ZsG6u01Bmea5AI820aG9qHoKfd7FBiv2XeU886RlzUIMgs8+13avJvMgSCJ7/duv9+ArFm89NsQ4swVvdtEbHbT8huaXztnX0zcktnrcp5MSNOGbVy5Kk596CWts1jCh4uM7WMAnQ5nlH62aSq4yKuzNYVeSgSumpPL91olYvOMml7HkfQyRVINe6M7zQUFugvx0JzJjTepdu2yGdMNiVvJknbxtW2S1D34fjLKNv00rMKtw1WbgwJZFCKKpj5KfbW+HS34DoQTCNK/TPuLRKoJ9GuBAdVXp1B8XAYwG+ljafXPDyUA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IygYdjhWRBIlBtx6R14du6juZZZeYS99CvQ/hCkgHLo=; b=jq/NnpwoHVQCFIeO7pu1V+9/gQvkyYcycYOCKAZgL0Zsbuqr+qKuEQgVzmoWLtSNK8SS6V5Vn/sPpt3cOT3HBETioXAktzyWrCiwxMjikk2JpRNWnbSN8lH+k7fqzO6x9fDqMs02Ux0Hp1Y49qy6qgMlLk+TdwC9n3x5KT5Kxfs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frjy8YMUM5ZM9foWZAdi1FYK1F3Aw2JgMOq/d6Mbz8jRzo+SJusYfhiLbgqHv75XvZ8EZC580o3avAfwm4pcoVIIhXg7xTF2Shpj1BSDfyVWqqZwUZOyVpdxGAXYH8Ukc+LdETuQjCzo4xZkVvwEpryLJkUsgaYIpxKtykLfL5P/d8VSq8X30VTdueKRhkM+a2o+hn7bcLXTWjhRzFjWxidn4EexKGZyY57YOSxSMZoQQdgAGFjLYmdiVrZ+UWR5wSeOKKW+bzhnOTrI+PPjTbCpfxQ0XGVtJfBGTx9BhRIFZduEPnyr3e8poLGenbjpyVEG5oGqMZS3Gs63nqr+5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IygYdjhWRBIlBtx6R14du6juZZZeYS99CvQ/hCkgHLo=; b=FqJi9V7cpkscWVSIDYrZbTSqTg8JZFxT/unw95cjAAth0Cd6hJaJ+P9spGLT3cxMlPupUKWT15VK++UDD1bwG6xzATa9CiwxTi4ns3p/7me0fVWsWq21e892h4dK6Q7M1xeHzZp+ckW2N8cIQhyMuzeITyMqPzPvesEinh2YXtMVpb700rEoWsa6pXshbW1XPeYOy2avlYO8X4/y/gefMyKC+M4HEVC8hW9cRFeujJoL29qb7IMk/4eXBEHrBvu2XfxxoXhkguyweLLrHz1W0/bHwqLrzR2dNspW33iKi6QXG1cSKz5qc4mVQYZCTZS7+BQ/NS2HIII8Q3ymI3BdCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IygYdjhWRBIlBtx6R14du6juZZZeYS99CvQ/hCkgHLo=; b=jq/NnpwoHVQCFIeO7pu1V+9/gQvkyYcycYOCKAZgL0Zsbuqr+qKuEQgVzmoWLtSNK8SS6V5Vn/sPpt3cOT3HBETioXAktzyWrCiwxMjikk2JpRNWnbSN8lH+k7fqzO6x9fDqMs02Ux0Hp1Y49qy6qgMlLk+TdwC9n3x5KT5Kxfs= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: nd , Wei Chen , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie Subject: RE: [PATCH v4 7/8] xen/x86: add detection of memory interleaves for different nodes Thread-Topic: [PATCH v4 7/8] xen/x86: add detection of memory interleaves for different nodes Thread-Index: AQHYbm4b7teAW0SaSEyIBxFEWwznXq02r7pg Date: Mon, 30 May 2022 01:46:34 +0000 Message-ID: References: <20220523062525.2504290-1-wei.chen@arm.com> <20220523062525.2504290-8-wei.chen@arm.com> In-Reply-To: <20220523062525.2504290-8-wei.chen@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 66A0B2BC6AAEFD4EBC3AC3B68FBA85A0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: dd48f5fe-2d16-4b2c-e7f7-08da41de401a x-ms-traffictypediagnostic: DB7PR08MB3564:EE_|VE1EUR03FT046:EE_|VI1PR08MB2638:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eijAvzgfscQ0FVsgO6KqrgCxNgK8ZM17uB0d48lAwSgEK4EANQUC3k5jSEnyEpbqFm92DyPYO0mzvLBB13TYpyCP37FaaoDDnOjsk5A1sbbU/EOrQKreZa12YLhkygON2Cmi8x2UYuj5v/7pZPHKL62RD+hf4aJLwSj2Um49RV1Qi/5ZEYdEE/aT8jZHjwBhARtHVXjNL4mJ7MogoGYE+rI0kreqvR0CoyYTws7sp3uBNSgA7dG8Ph1T7TWa1f5TOSNvrGIG5i0Amr/PWOdA6NOorc3PE1dpWXBfXEx6sPybfWaam1r+9lMiFw6Q+4V+dBTwWII9arOJH3ljyzmqr4wL9RU9KDv41PF8iV4EVduB2viacgqiN2K9Bs7bCL++VdUFXNo4g9L5HBCL0YKwK6k7rQpTai01hI+AAZqTXbjVTS6B0voSNkC+CyJTpd529tIAqM/DmERgkFJQJyhUBFOso2kwYblZjegqPcx1WuIEWoL6h+igTEw1DO6QIlBMmXBDMYtA4wmLWYigY2mtxjcxyR8YPrr0qQ0hieZXa6voLWs/1AMo4+EudvQSwKbv1x7zz9j366xEp9XfgbQGS0ixsIKSXE1lk6xH6HZYxu6unkb1gjTxumavQin6TQvWiokIrgQjUO04Kpurh98NoOe7OiMfp+tT/Sa3Y+aW2fMporIjL5V8jp8WYxdGUW5YMQT6wanm+NC3jBPoAfMGzQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(4326008)(76116006)(66946007)(8676002)(64756008)(316002)(66556008)(66446008)(66476007)(5660300002)(508600001)(122000001)(71200400001)(54906003)(6916009)(38070700005)(55016003)(6506007)(26005)(52536014)(8936002)(86362001)(2906002)(33656002)(7696005)(38100700002)(186003)(83380400001)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 249d1424-2b4a-45ec-1ccb-08da41de3a6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v/kHJ6rlHhOVaopdj/Dx0eANjb98DTgLPisjW4ZocHQaJG5LC7w3eIDzxqtaaP3qyeLhJ0GMGboeTWqLWey6Xgz45geEDloqk3uMI9WULARhV+5hKo0e9nFOJ+H+UkavzRrKzFxBn0pHkAZhb2HupGyLuH6IR0GoRZeO+pUxe2tiIDxDN83gyqxuAqLc4m+zXSl3F8OJYiUIPOLBqqPNdgAgeo09kawPzGxd5tCTreMne3bBwZnjVpHJWUTkxIYzoMdObxc/uvnjJpqC/At9VmQj2aq+EY3gHGaPikr35H8wVM1fo3amBfdvR+0rjYz57arDTZKJ9VUzGyWUrsvPhJLjZDpmVi1YCs9oI+WiZ39NrVbgqVsuQdF5BlmNNe0ca4f2RuwrTHWV2UK6wxfJ387+53MoGoq5HanvizlGg819BSdvWFY/Dg2RDzIRzol1EHNpTkrEDzuBbrFAAiMpCQaCAXyC8rnEbkS0rG+jwN3qPJeA8+Flqnx1bzteR2Qs1CpcVJnSwhT/dOzXOJs8s693KoFCPcUE3l64ieILSp/uCcP8Xf3E0xzWCFFXXyEiT1E/vthP3cSjiopOVe+QAcbmbKDo6ufTo6s173J2rS9fpkEW7wnPIIs3LTRD3vJBRvyL0dJyCw8fY9FzKIPasw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(26005)(83380400001)(9686003)(6506007)(5660300002)(4326008)(8936002)(47076005)(82310400005)(8676002)(70586007)(2906002)(55016003)(70206006)(7696005)(52536014)(36860700001)(508600001)(6916009)(316002)(356005)(86362001)(336012)(54906003)(81166007)(186003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 01:46:43.8989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd48f5fe-2d16-4b2c-e7f7-08da41de401a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2638 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBwYXRjaCBpcyB0aGUgb25seSBvbmUgdGhhdCBpcyBu b3QgcHJvcGVybHkgYWNrZWQgYW5kDQpyZXZpZXdlZCBpbiB0aGlzIHNlcmllcy4gU28gdGhpcyBp cyBhIGdlbnRsZSBwaW5nIGFza2luZyBpZiBldmVyeW9uZSBpcyBoYXBweQ0Kd2l0aCB0aGlzIHBh dGNoIG9yIGFyZSB0aGVyZSBhbnkgbW9yZSBhY3Rpb25zIHRoYXQgc2hvdWxkIGJlIHRha2VuIGZy b20gdGhlDQphdXRob3IuIFRoYW5rcyENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0ggdjQgNy84XSB4ZW4veDg2 OiBhZGQgZGV0ZWN0aW9uIG9mIG1lbW9yeSBpbnRlcmxlYXZlcyBmb3INCj4gZGlmZmVyZW50IG5v ZGVzDQo+IA0KPiBPbmUgTlVNQSBub2RlIG1heSBjb250YWluIHNldmVyYWwgbWVtb3J5IGJsb2Nr cy4gSW4gY3VycmVudCBYZW4NCj4gY29kZSwgWGVuIHdpbGwgbWFpbnRhaW4gYSBub2RlIG1lbW9y eSByYW5nZSBmb3IgZWFjaCBub2RlIHRvIGNvdmVyDQo+IGFsbCBpdHMgbWVtb3J5IGJsb2Nrcy4g QnV0IGhlcmUgY29tZXMgdGhlIHByb2JsZW0sIGluIHRoZSBnYXAgb2YNCj4gb25lIG5vZGUncyB0 d28gbWVtb3J5IGJsb2NrcywgaWYgdGhlcmUgYXJlIHNvbWUgbWVtb3J5IGJsb2NrcyBkb24ndA0K PiBiZWxvbmcgdG8gdGhpcyBub2RlIChyZW1vdGUgbWVtb3J5IGJsb2NrcykuIFRoaXMgbm9kZSdz IG1lbW9yeSByYW5nZQ0KPiB3aWxsIGJlIGV4cGFuZGVkIHRvIGNvdmVyIHRoZXNlIHJlbW90ZSBt ZW1vcnkgYmxvY2tzLg0KPiANCj4gT25lIG5vZGUncyBtZW1vcnkgcmFuZ2UgY29udGFpbnMgb3Ro ZXIgbm9kZXMnIG1lbW9yeSwgdGhpcyBpcw0KPiBvYnZpb3VzbHkgbm90IHZlcnkgcmVhc29uYWJs ZS4gVGhpcyBtZWFucyBjdXJyZW50IE5VTUEgY29kZSBvbmx5DQo+IGNhbiBzdXBwb3J0IG5vZGUg aGFzIG5vIGludGVybGVhdmVkIG1lbW9yeSBibG9ja3MuIEhvd2V2ZXIsIG9uIGENCj4gcGh5c2lj YWwgbWFjaGluZSwgdGhlIGFkZHJlc3NlcyBvZiBtdWx0aXBsZSBub2RlcyBjYW4gYmUgaW50ZXJs ZWF2ZWQuDQo+IA0KPiBTbyBpbiB0aGlzIHBhdGNoLCB3ZSBhZGQgY29kZSB0byBkZXRlY3QgbWVt b3J5IGludGVybGVhdmVzIG9mDQo+IGRpZmZlcmVudCBub2Rlcy4gTlVNQSBpbml0aWFsaXphdGlv biB3aWxsIGJlIGZhaWxlZCBhbmQgZXJyb3INCj4gbWVzc2FnZXMgd2lsbCBiZSBwcmludGVkIHdo ZW4gWGVuIGRldGVjdCBzdWNoIGhhcmR3YXJlIGNvbmZpZ3VyYXRpb24uDQo+IA0KPiBDaGFuZ2Ut SWQ6IElhN2ZmOWE5MTI4ZWNiZTNlYjRkZGRkMTMwN2FlOGZiZTY1NTc1Y2NmDQo+IElzc3VlLUlk OiBTQ00tMjI0MA0KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4N Cj4gVGVzdGVkLWJ5OiBKaWFtZWkgWGllIDxqaWFtZWkueGllQGFybS5jb20+DQo+IC0tLQ0KPiB2 MyAtPiB2NDoNCj4gMS4gRHJvcCAiRVJSIiBwcmVmaXggZm9yIGVudW1lcmF0aW9uLCBhbmQgcmVt b3ZlIGluaXQgdmFsdWUuDQo+IDIuIFVzZSAic3dpdGNoIGNhc2UiIGZvciBlbnVtZXJhdGlvbiwg YW5kIGFkZCAiZGVmYXVsdDoiDQo+IDMuIFVzZSAiUFhNIiBpbiBsb2cgbWVzc2FnZXMuDQo+IDQu IFVzZSB1bnNpZ25lZCBpbnQgZm9yIG5vZGUgbWVtb3J5IGJsb2NrIGlkLg0KPiA1LiBGaXggc29t ZSBjb2RlLXN0eWxlIGNvbW1lbnRzLg0KPiA2LiBVc2UgIm5kLT5lbmQiIGluIG5vZGUgcmFuZ2Ug ZXhwYW5zaW9uIGNoZWNrLg0KPiB2MiAtPiB2MzoNCj4gMS4gTWVyZ2UgdGhlIGNoZWNrIGNvZGUg ZnJvbSBhIHNlcGFyYXRlIGZ1bmN0aW9uIHRvDQo+ICAgIGNvbmZsaWN0aW5nX21lbWJsa3MuIFRo aXMgd2lsbCByZWR1Y2UgdGhlIGxvb3ANCj4gICAgdGltZXMgb2Ygbm9kZSBtZW1vcnkgYmxvY2tz Lg0KPiAyLiBVc2UgYW4gZW51bWVyYXRpb24gdG8gaW5kaWNhdGUgY29uZmxpY3QgY2hlY2sgc3Rh dHVzLg0KPiAzLiBVc2UgYSBwb2ludGVyIHRvIGdldCBjb25mbGljdCBtZW1vcnkgYmxvY2sgaWQu DQo+IHYxIC0+IHYyOg0KPiAxLiBVcGRhdGUgdGhlIGRlc2NyaXB0aW9uIHRvIHNheSB3ZSdyZSBh ZnRlciBpcyBubyBtZW1vcnkNCj4gICAgaW50ZXJsZWF2ZXMgb2YgZGlmZmVyZW50IG5vZGVzLg0K PiAyLiBPbmx5IHVwZGF0ZSBub2RlIHJhbmdlIHdoZW4gaXQgcGFzc2VzIHRoZSBpbnRlcmxlYXZl IGNoZWNrLg0KPiAzLiBEb24ndCB1c2UgZnVsbCB1cHBlci1jYXNlIGZvciAibm9kZSIuDQo+IC0t LQ0KPiAgeGVuL2FyY2gveDg2L3NyYXQuYyB8IDEzMiArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwMSBpbnNlcnRpb25zKCsp LCAzMSBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvc3JhdC5j IGIveGVuL2FyY2gveDg2L3NyYXQuYw0KPiBpbmRleCA4ZmZlNDNiZGZlLi5hODMxZGY3NjQ4IDEw MDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvc3JhdC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9z cmF0LmMNCj4gQEAgLTQyLDYgKzQyLDEyIEBAIHN0YXRpYyBzdHJ1Y3Qgbm9kZQ0KPiBub2RlX21l bWJsa19yYW5nZVtOUl9OT0RFX01FTUJMS1NdOw0KPiAgc3RhdGljIG5vZGVpZF90IG1lbWJsa19u b2RlaWRbTlJfTk9ERV9NRU1CTEtTXTsNCj4gIHN0YXRpYyBfX2luaXRkYXRhIERFQ0xBUkVfQklU TUFQKG1lbWJsa19ob3RwbHVnLA0KPiBOUl9OT0RFX01FTUJMS1MpOw0KPiANCj4gK2VudW0gY29u ZmxpY3RzIHsNCj4gKwlOT19DT05GTElDVCwNCj4gKwlPVkVSTEFQLA0KPiArCUlOVEVSTEVBVkUs DQo+ICt9Ow0KPiArDQo+ICBzdGF0aWMgaW5saW5lIGJvb2wgbm9kZV9mb3VuZCh1bnNpZ25lZCBp ZHgsIHVuc2lnbmVkIHB4bSkNCj4gIHsNCj4gIAlyZXR1cm4gKChweG0ybm9kZVtpZHhdLnB4bSA9 PSBweG0pICYmDQo+IEBAIC0xMTksMjAgKzEyNSw0NSBAQCBpbnQgdmFsaWRfbnVtYV9yYW5nZShw YWRkcl90IHN0YXJ0LCBwYWRkcl90IGVuZCwNCj4gbm9kZWlkX3Qgbm9kZSkNCj4gIAlyZXR1cm4g MDsNCj4gIH0NCj4gDQo+IC1zdGF0aWMgX19pbml0IGludCBjb25mbGljdGluZ19tZW1ibGtzKHBh ZGRyX3Qgc3RhcnQsIHBhZGRyX3QgZW5kKQ0KPiArc3RhdGljDQo+ICtlbnVtIGNvbmZsaWN0cyBf X2luaXQgY29uZmxpY3RpbmdfbWVtYmxrcyhub2RlaWRfdCBuaWQsIHBhZGRyX3Qgc3RhcnQsDQo+ ICsJCQkJCSAgcGFkZHJfdCBlbmQsIHBhZGRyX3QgbmRfc3RhcnQsDQo+ICsJCQkJCSAgcGFkZHJf dCBuZF9lbmQsIHVuc2lnbmVkIGludA0KPiAqbWJsa2lkKQ0KPiAgew0KPiAtCWludCBpOw0KPiAr CXVuc2lnbmVkIGludCBpOw0KPiANCj4gKwkvKg0KPiArCSAqIFNjYW4gYWxsIHJlY29yZGVkIG5v ZGVzJyBtZW1vcnkgYmxvY2tzIHRvIGNoZWNrIGNvbmZsaWN0czoNCj4gKwkgKiBPdmVybGFwIG9y IGludGVybGVhdmUuDQo+ICsJICovDQo+ICAJZm9yIChpID0gMDsgaSA8IG51bV9ub2RlX21lbWJs a3M7IGkrKykgew0KPiAgCQlzdHJ1Y3Qgbm9kZSAqbmQgPSAmbm9kZV9tZW1ibGtfcmFuZ2VbaV07 DQo+ICsNCj4gKwkJKm1ibGtpZCA9IGk7DQo+ICsNCj4gKwkJLyogU2tpcCAwIGJ5dGVzIG5vZGUg bWVtb3J5IGJsb2NrLiAqLw0KPiAgCQlpZiAobmQtPnN0YXJ0ID09IG5kLT5lbmQpDQo+ICAJCQlj b250aW51ZTsNCj4gKwkJLyoNCj4gKwkJICogVXNlIG1lbWJsayByYW5nZSB0byBjaGVjayBtZW1i bGsgb3ZlcmxhcHMsIGluY2x1ZGUgdGhlDQo+ICsJCSAqIHNlbGYtb3ZlcmxhcCBjYXNlLg0KPiAr CQkgKi8NCj4gIAkJaWYgKG5kLT5lbmQgPiBzdGFydCAmJiBuZC0+c3RhcnQgPCBlbmQpDQo+IC0J CQlyZXR1cm4gaTsNCj4gKwkJCXJldHVybiBPVkVSTEFQOw0KPiAgCQlpZiAobmQtPmVuZCA9PSBl bmQgJiYgbmQtPnN0YXJ0ID09IHN0YXJ0KQ0KPiAtCQkJcmV0dXJuIGk7DQo+ICsJCQlyZXR1cm4g T1ZFUkxBUDsNCj4gKwkJLyoNCj4gKwkJICogVXNlIG5vZGUgbWVtb3J5IHJhbmdlIHRvIGNoZWNr IHdoZXRoZXIgbmV3IHJhbmdlDQo+IGNvbnRhaW5zDQo+ICsJCSAqIG1lbW9yeSBmcm9tIG90aGVy IG5vZGVzIC0gaW50ZXJsZWF2ZSBjaGVjay4gV2UganVzdA0KPiBuZWVkDQo+ICsJCSAqIHRvIGNo ZWNrIGZ1bGwgY29udGFpbnMgc2l0dWF0aW9uLiBCZWNhdXNlIG92ZXJsYXBzIGhhdmUNCj4gKwkJ ICogYmVlbiBjaGVja2VkIGFib3ZlLg0KPiArCQkgKi8NCj4gKwkgICAgICAgIGlmIChuaWQgIT0g bWVtYmxrX25vZGVpZFtpXSAmJg0KPiArCQkgICAgKG5kX3N0YXJ0IDwgbmQtPnN0YXJ0ICYmIG5k LT5lbmQgPCBuZF9lbmQpKQ0KPiArCQkJcmV0dXJuIElOVEVSTEVBVkU7DQo+ICAJfQ0KPiAtCXJl dHVybiAtMTsNCj4gKw0KPiArCXJldHVybiBOT19DT05GTElDVDsNCj4gIH0NCj4gDQo+ICBzdGF0 aWMgX19pbml0IHZvaWQgY3V0b2ZmX25vZGUoaW50IGksIHBhZGRyX3Qgc3RhcnQsIHBhZGRyX3Qg ZW5kKQ0KPiBAQCAtMjc1LDEwICszMDYsMTMgQEAgYWNwaV9udW1hX3Byb2Nlc3Nvcl9hZmZpbml0 eV9pbml0KGNvbnN0IHN0cnVjdA0KPiBhY3BpX3NyYXRfY3B1X2FmZmluaXR5ICpwYSkNCj4gIHZv aWQgX19pbml0DQo+ICBhY3BpX251bWFfbWVtb3J5X2FmZmluaXR5X2luaXQoY29uc3Qgc3RydWN0 IGFjcGlfc3JhdF9tZW1fYWZmaW5pdHkgKm1hKQ0KPiAgew0KPiArCWVudW0gY29uZmxpY3RzIHN0 YXR1czsNCj4gKwlzdHJ1Y3Qgbm9kZSAqbmQ7DQo+ICsJcGFkZHJfdCBuZF9zdGFydCwgbmRfZW5k Ow0KPiAgCXBhZGRyX3Qgc3RhcnQsIGVuZDsNCj4gIAl1bnNpZ25lZCBweG07DQo+ICAJbm9kZWlk X3Qgbm9kZTsNCj4gLQlpbnQgaTsNCj4gKwl1bnNpZ25lZCBpbnQgaTsNCj4gDQo+ICAJaWYgKHNy YXRfZGlzYWJsZWQoKSkNCj4gIAkJcmV0dXJuOw0KPiBAQCAtMzEwLDQyICszNDQsNzggQEAgYWNw aV9udW1hX21lbW9yeV9hZmZpbml0eV9pbml0KGNvbnN0IHN0cnVjdA0KPiBhY3BpX3NyYXRfbWVt X2FmZmluaXR5ICptYSkNCj4gIAkJYmFkX3NyYXQoKTsNCj4gIAkJcmV0dXJuOw0KPiAgCX0NCj4g Kw0KPiArCS8qDQo+ICsJICogRm9yIHRoZSBub2RlIHRoYXQgYWxyZWFkeSBoYXMgc29tZSBtZW1v cnkgYmxvY2tzLCB3ZSB3aWxsDQo+ICsJICogZXhwYW5kIHRoZSBub2RlIG1lbW9yeSByYW5nZSB0 ZW1wb3JhcmlseSB0byBjaGVjayBtZW1vcnkNCj4gKwkgKiBpbnRlcmxlYXZlcyB3aXRoIG90aGVy IG5vZGVzLiBXZSB3aWxsIG5vdCB1c2UgdGhpcyBub2RlDQo+ICsJICogdGVtcCBtZW1vcnkgcmFu Z2UgdG8gY2hlY2sgb3ZlcmxhcHMsIGJlY2F1c2UgaXQgd2lsbCBtYXNrDQo+ICsJICogdGhlIG92 ZXJsYXBzIGluIHNhbWUgbm9kZS4NCj4gKwkgKg0KPiArCSAqIE5vZGUgd2l0aCAwIGJ5dGVzIG1l bW9yeSBkb2Vzbid0IG5lZWQgdGhpcyBleHBhbmRzaW9uLg0KPiArCSAqLw0KPiArCW5kX3N0YXJ0 ID0gc3RhcnQ7DQo+ICsJbmRfZW5kID0gZW5kOw0KPiArCW5kID0gJm5vZGVzW25vZGVdOw0KPiAr CWlmIChuZC0+c3RhcnQgIT0gbmQtPmVuZCkgew0KPiArCQlpZiAobmRfc3RhcnQgPiBuZC0+c3Rh cnQpDQo+ICsJCQluZF9zdGFydCA9IG5kLT5zdGFydDsNCj4gKw0KPiArCQlpZiAobmRfZW5kIDwg bmQtPmVuZCkNCj4gKwkJCW5kX2VuZCA9IG5kLT5lbmQ7DQo+ICsJfQ0KPiArDQo+ICAJLyogSXQg aXMgZmluZSB0byBhZGQgdGhpcyBhcmVhIHRvIHRoZSBub2RlcyBkYXRhIGl0IHdpbGwgYmUgdXNl ZCBsYXRlciovDQo+IC0JaSA9IGNvbmZsaWN0aW5nX21lbWJsa3Moc3RhcnQsIGVuZCk7DQo+IC0J aWYgKGkgPCAwKQ0KPiAtCQkvKiBldmVyeXRoaW5nIGZpbmUgKi87DQo+IC0JZWxzZSBpZiAobWVt YmxrX25vZGVpZFtpXSA9PSBub2RlKSB7DQo+IC0JCWJvb2wgbWlzbWF0Y2ggPSAhKG1hLT5mbGFn cyAmDQo+IEFDUElfU1JBVF9NRU1fSE9UX1BMVUdHQUJMRSkgIT0NCj4gLQkJICAgICAgICAgICAg ICAgICF0ZXN0X2JpdChpLCBtZW1ibGtfaG90cGx1Zyk7DQo+IC0NCj4gLQkJcHJpbnRrKCIlc1NS QVQ6IFBYTSAldSAoJSJQUklwYWRkciItJSJQUklwYWRkciIpDQo+IG92ZXJsYXBzIHdpdGggaXRz ZWxmICglIlBSSXBhZGRyIi0lIlBSSXBhZGRyIilcbiIsDQo+IC0JCSAgICAgICBtaXNtYXRjaCA/ IEtFUk5fRVJSIDogS0VSTl9XQVJOSU5HLCBweG0sIHN0YXJ0LA0KPiBlbmQsDQo+IC0JCSAgICAg ICBub2RlX21lbWJsa19yYW5nZVtpXS5zdGFydCwNCj4gbm9kZV9tZW1ibGtfcmFuZ2VbaV0uZW5k KTsNCj4gLQkJaWYgKG1pc21hdGNoKSB7DQo+ICsJc3RhdHVzID0gY29uZmxpY3RpbmdfbWVtYmxr cyhub2RlLCBzdGFydCwgZW5kLCBuZF9zdGFydCwgbmRfZW5kLA0KPiAmaSk7DQo+ICsJc3dpdGNo KHN0YXR1cykNCj4gKwl7DQo+ICsJY2FzZSBPVkVSTEFQOg0KPiArCXsNCj4gKwkJaWYgKG1lbWJs a19ub2RlaWRbaV0gPT0gbm9kZSkgew0KPiArCQkJYm9vbCBtaXNtYXRjaCA9ICEobWEtPmZsYWdz ICYNCj4gKw0KPiBBQ1BJX1NSQVRfTUVNX0hPVF9QTFVHR0FCTEUpICE9DQo+ICsJCQkgICAgICAg ICAgICAgICAgIXRlc3RfYml0KGksIG1lbWJsa19ob3RwbHVnKTsNCj4gKw0KPiArCQkJcHJpbnRr KCIlc1NSQVQ6IFBYTSAldSAoJSJQUklwYWRkciItDQo+ICUiUFJJcGFkZHIiKSBvdmVybGFwcyB3 aXRoIGl0c2VsZiAoJSJQUklwYWRkciItJSJQUklwYWRkciIpXG4iLA0KPiArCQkJICAgICAgIG1p c21hdGNoID8gS0VSTl9FUlIgOiBLRVJOX1dBUk5JTkcsIHB4bSwNCj4gc3RhcnQsDQo+ICsJCQkg ICAgICAgZW5kLCBub2RlX21lbWJsa19yYW5nZVtpXS5zdGFydCwNCj4gKwkJCSAgICAgICBub2Rl X21lbWJsa19yYW5nZVtpXS5lbmQpOw0KPiArCQkJaWYgKG1pc21hdGNoKSB7DQo+ICsJCQkJYmFk X3NyYXQoKTsNCj4gKwkJCQlyZXR1cm47DQo+ICsJCQl9DQo+ICsJCQlicmVhazsNCj4gKwkJfSBl bHNlIHsNCj4gKwkJCXByaW50ayhLRVJOX0VSUg0KPiArCQkJICAgICAgICJTUkFUOiBQWE0gJXUg KCUiUFJJcGFkZHIiLSUiUFJJcGFkZHIiKQ0KPiBvdmVybGFwcyB3aXRoIFBYTSAldSAoJSJQUklw YWRkciItJSJQUklwYWRkciIpXG4iLA0KPiArCQkJICAgICAgIHB4bSwgc3RhcnQsIGVuZCwNCj4g bm9kZV90b19weG0obWVtYmxrX25vZGVpZFtpXSksDQo+ICsJCQkgICAgICAgbm9kZV9tZW1ibGtf cmFuZ2VbaV0uc3RhcnQsDQo+ICsJCQkgICAgICAgbm9kZV9tZW1ibGtfcmFuZ2VbaV0uZW5kKTsN Cj4gIAkJCWJhZF9zcmF0KCk7DQo+ICAJCQlyZXR1cm47DQo+ICAJCX0NCj4gLQl9IGVsc2Ugew0K PiArCX0NCj4gKw0KPiArCWNhc2UgSU5URVJMRUFWRToNCj4gKwl7DQo+ICAJCXByaW50ayhLRVJO X0VSUg0KPiAtCQkgICAgICAgIlNSQVQ6IFBYTSAldSAoJSJQUklwYWRkciItJSJQUklwYWRkciIp IG92ZXJsYXBzDQo+IHdpdGggUFhNICV1ICglIlBSSXBhZGRyIi0lIlBSSXBhZGRyIilcbiIsDQo+ IC0JCSAgICAgICBweG0sIHN0YXJ0LCBlbmQsIG5vZGVfdG9fcHhtKG1lbWJsa19ub2RlaWRbaV0p LA0KPiArCQkgICAgICAgIlNSQVTvvJogUFhNICV1OiAoJSJQUklwYWRkciItJSJQUklwYWRkciIp DQo+IGludGVybGVhdmVzIHdpdGggUFhNICV1IG1lbWJsayAoJSJQUklwYWRkciItJSJQUklwYWRk ciIpXG4iLA0KPiArCQkgICAgICAgbm9kZSwgbmRfc3RhcnQsIG5kX2VuZCwNCj4gbm9kZV90b19w eG0obWVtYmxrX25vZGVpZFtpXSksDQo+ICAJCSAgICAgICBub2RlX21lbWJsa19yYW5nZVtpXS5z dGFydCwNCj4gbm9kZV9tZW1ibGtfcmFuZ2VbaV0uZW5kKTsNCj4gIAkJYmFkX3NyYXQoKTsNCj4g IAkJcmV0dXJuOw0KPiAgCX0NCj4gLQlpZiAoIShtYS0+ZmxhZ3MgJiBBQ1BJX1NSQVRfTUVNX0hP VF9QTFVHR0FCTEUpKSB7DQo+IC0JCXN0cnVjdCBub2RlICpuZCA9ICZub2Rlc1tub2RlXTsNCj4g DQo+IC0JCWlmICghbm9kZV90ZXN0X2FuZF9zZXQobm9kZSwgbWVtb3J5X25vZGVzX3BhcnNlZCkp IHsNCj4gLQkJCW5kLT5zdGFydCA9IHN0YXJ0Ow0KPiAtCQkJbmQtPmVuZCA9IGVuZDsNCj4gLQkJ fSBlbHNlIHsNCj4gLQkJCWlmIChzdGFydCA8IG5kLT5zdGFydCkNCj4gLQkJCQluZC0+c3RhcnQg PSBzdGFydDsNCj4gLQkJCWlmIChuZC0+ZW5kIDwgZW5kKQ0KPiAtCQkJCW5kLT5lbmQgPSBlbmQ7 DQo+IC0JCX0NCj4gKwlkZWZhdWx0Og0KPiArCQlicmVhazsNCj4gKwl9DQo+ICsNCj4gKwlpZiAo IShtYS0+ZmxhZ3MgJiBBQ1BJX1NSQVRfTUVNX0hPVF9QTFVHR0FCTEUpKSB7DQo+ICsJCW5vZGVf c2V0KG5vZGUsIG1lbW9yeV9ub2Rlc19wYXJzZWQpOw0KPiArCQluZC0+c3RhcnQgPSBuZF9zdGFy dDsNCj4gKwkJbmQtPmVuZCA9IG5kX2VuZDsNCj4gIAl9DQo+ICsNCj4gIAlwcmludGsoS0VSTl9J TkZPICJTUkFUOiBOb2RlICV1IFBYTSAldSAlIlBSSXBhZGRyIi0NCj4gJSJQUklwYWRkciIlc1xu IiwNCj4gIAkgICAgICAgbm9kZSwgcHhtLCBzdGFydCwgZW5kLA0KPiAgCSAgICAgICBtYS0+Zmxh Z3MgJiBBQ1BJX1NSQVRfTUVNX0hPVF9QTFVHR0FCTEUgPyAiIChob3RwbHVnKSIgOg0KPiAiIik7 DQo+IC0tDQo+IDIuMjUuMQ0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Mon May 30 06:41:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 06:41:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338334.563093 (Exim 4.92) (envelope-from ) id 1nvZ5h-00029e-E4; Mon, 30 May 2022 06:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338334.563093; Mon, 30 May 2022 06:41:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvZ5h-00029X-BV; Mon, 30 May 2022 06:41:25 +0000 Received: by outflank-mailman (input) for mailman id 338334; Mon, 30 May 2022 06:41:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvZ5g-00029R-I8 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 06:41:24 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84d2630f-dfe3-11ec-837f-e5687231ffcc; Mon, 30 May 2022 08:41:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 930081F8A8; Mon, 30 May 2022 06:41:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 526E013AFD; Mon, 30 May 2022 06:41:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mFmPEhFnlGLdXgAAMHmgww (envelope-from ); Mon, 30 May 2022 06:41:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84d2630f-dfe3-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653892881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=71IJN/uvPmtGbzax6AW8Uvan1VSTvj6QtEu8AQf7oeU=; b=RWYOW5ZU7DwS+tbReR7dwWeCaGBMDKJP+lqaYwDDH6LB+b+xa5JRwwW+bBWV/BXYtxgDyd EnrTtu+t0wOUFbBFTYNIcHyW7BCdoY2YPsCfY/Iubmnn8sVPVGUHbq9WPAFQpB+AXdMQC9 TDoE516dUv6LB5IIt2pBO5oyO2Ab7A0= Message-ID: <00c0b10c-a35d-6729-5b4f-424febd9d5a3@suse.com> Date: Mon, 30 May 2022 08:41:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Demi Marie Obenour , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220525184153.6059-1-demi@invisiblethingslab.com> From: Juergen Gross Subject: Re: [PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages() In-Reply-To: <20220525184153.6059-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JsLfkxePRUaQci00CUJuEKC0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JsLfkxePRUaQci00CUJuEKC0 Content-Type: multipart/mixed; boundary="------------4n1k394n10VIXl50CWi9p4Ih"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <00c0b10c-a35d-6729-5b4f-424febd9d5a3@suse.com> Subject: Re: [PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages() References: <20220525184153.6059-1-demi@invisiblethingslab.com> In-Reply-To: <20220525184153.6059-1-demi@invisiblethingslab.com> --------------4n1k394n10VIXl50CWi9p4Ih Content-Type: multipart/mixed; boundary="------------0RU3jj5DFajfimWsnYd00sbd" --------------0RU3jj5DFajfimWsnYd00sbd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjUuMDUuMjIgMjA6NDEsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gdW5tYXBf Z3JhbnRfcGFnZXMoKSBjdXJyZW50bHkgd2FpdHMgZm9yIHRoZSBwYWdlcyB0byBubyBsb25n ZXIgYmUgdXNlZC4NCj4gSW4gaHR0cHM6Ly9naXRodWIuY29tL1F1YmVzT1MvcXViZXMtaXNz dWVzL2lzc3Vlcy83NDgxLCB0aGlzIGxlYWQgdG8gYQ0KPiBkZWFkbG9jayBhZ2FpbnN0IGk5 MTU6IGk5MTUgd2FzIHdhaXRpbmcgZm9yIGdudGRldidzIE1NVSBub3RpZmllciB0bw0KPiBm aW5pc2gsIHdoaWxlIGdudGRldiB3YXMgd2FpdGluZyBmb3IgaTkxNSB0byBmcmVlIGl0cyBw YWdlcy4gIEkgYWxzbw0KPiBiZWxpZXZlIHRoaXMgaXMgcmVzcG9uc2libGUgZm9yIHZhcmlv dXMgZGVhZGxvY2tzIEkgaGF2ZSBleHBlcmllbmNlZCBpbg0KPiB0aGUgcGFzdC4NCj4gDQo+ IEF2b2lkIHRoZXNlIHByb2JsZW1zIGJ5IG1ha2luZyB1bm1hcF9ncmFudF9wYWdlcyBhc3lu Yy4gIFRoaXMgcmVxdWlyZXMNCj4gbWFraW5nIGl0IHJldHVybiB2b2lkLCBhcyBhbnkgZXJy b3JzIHdpbGwgbm90IGJlIGF2YWlsYWJsZSB3aGVuIHRoZQ0KPiBmdW5jdGlvbiByZXR1cm5z LiAgRm9ydHVuYXRlbHksIHRoZSBvbmx5IHVzZSBvZiB0aGUgcmV0dXJuIHZhbHVlIGlzIGEN Cj4gV0FSTl9PTigpLCB3aGljaCBjYW4gYmUgcmVwbGFjZWQgYnkgYSBXQVJOX09OIHdoZW4g dGhlIGVycm9yIGlzDQo+IGRldGVjdGVkLiAgQWRkaXRpb25hbGx5LCBhIGZhaWxlZCBjYWxs IHdpbGwgbm90IHByZXZlbnQgZnVydGhlciBjYWxscw0KPiBmcm9tIGJlaW5nIG1hZGUsIGJ1 dCB0aGlzIGlzIGhhcm1sZXNzLg0KPiANCj4gQmVjYXVzZSB1bm1hcF9ncmFudF9wYWdlcyBp cyBub3cgYXN5bmMsIHRoZSBncmFudCBoYW5kbGUgd2lsbCBiZSBzZW50IHRvDQo+IElOVkFM SURfR1JBTlRfSEFORExFIHRvbyBsYXRlIHRvIHByZXZlbnQgbXVsdGlwbGUgdW5tYXBzIG9m IHRoZSBzYW1lDQo+IGhhbmRsZS4gIEluc3RlYWQsIGEgc2VwYXJhdGUgYm9vbCBhcnJheSBp cyBhbGxvY2F0ZWQgZm9yIHRoaXMgcHVycG9zZS4NCj4gVGhpcyB3YXN0ZXMgbWVtb3J5LCBi dXQgc3R1ZmZpbmcgdGhpcyBpbmZvcm1hdGlvbiBpbiBwYWRkaW5nIGJ5dGVzIGlzDQo+IHRv byBmcmFnaWxlLiAgRnVydGhlcm1vcmUsIGl0IGlzIG5lY2Vzc2FyeSB0byBncmFiIGEgcmVm ZXJlbmNlIHRvIHRoZQ0KPiBtYXAgYmVmb3JlIG1ha2luZyB0aGUgYXN5bmNocm9ub3VzIGNh bGwsIGFuZCByZWxlYXNlIHRoZSByZWZlcmVuY2Ugd2hlbg0KPiB0aGUgY2FsbCByZXR1cm5z Lg0KDQpJIHRoaW5rIHRoZXJlIGlzIGV2ZW4gbW9yZSBzeW5jaW5nIG5lZWRlZDoNCg0KLSBJ biB0aGUgZXJyb3IgcGF0aCBvZiBnbnRkZXZfbW1hcCgpIHVubWFwX2dyYW50X3BhZ2VzKCkg aXMgYmVpbmcgY2FsbGVkIGFuZA0KICAgaXQgaXMgYXNzdW1lZCwgbWFwIGlzIGF2YWlsYWJs ZSBhZnRlcndhcmRzIGFnYWluLiBUaGlzIHNob3VsZCBiZSByYXRoZXIgZWFzeQ0KICAgdG8g YXZvaWQgYnkgYWRkaW5nIGEgY291bnRlciBvZiBhY3RpdmUgbWFwcGluZ3MgdG8gc3RydWN0 IGdudGRldl9ncmFudF9tYXANCiAgIChudW1iZXIgb2YgcGFnZXMgbm90IGJlaW5nIHVubWFw cGVkIHlldCkuIEluIGNhc2UgdGhpcyBjb3VudGVyIGlzIG5vdCB6ZXJvDQogICBnbnRkZXZf bW1hcCgpIHNob3VsZCBiYWlsIG91dCBlYXJseS4NCg0KLSBnbnRkZXZfcHV0X21hcCgpIGlz IGNhbGxpbmcgdW5tYXBfZ3JhbnRfcGFnZXMoKSBpbiBjYXNlIHRoZSByZWZjb3VudCBoYXMN CiAgIGRyb3BwZWQgdG8gemVyby4gVGhpcyBjYWxsIGNhbiBzZXQgdGhlIHJlZmNvdW50IHRv IDEgYWdhaW4sIHNvIHRoZXJlIGlzDQogICBhbm90aGVyIGRlbGF5IG5lZWRlZCBiZWZvcmUg ZnJlZWluZyBtYXAuIEkgdGhpbmsgdW5tYXBfZ3JhbnRfcGFnZXMoKSBzaG91bGQNCiAgIHJl dHVybiBpbiBjYXNlIHRoZSBjb3VudCBvZiBtYXBwZWQgcGFnZXMgaXMgemVybyAoc2VlIGFi b3ZlKSwgdGh1cyBhdm9pZGluZw0KICAgdG8gaW5jcmVtZW50IHRoZSByZWZjb3VudCBvZiBt YXAgaWYgbm90aGluZyBpcyB0byBiZSBkb25lLiBUaGlzIHdvdWxkIGVuYWJsZQ0KICAgZ250 ZGV2X3B1dF9tYXAoKSB0byBqdXN0IHJldHVybiBhZnRlciB0aGUgY2FsbCBvZiB1bm1hcF9n cmFudF9wYWdlcygpIGluIGNhc2UNCiAgIHRoZSByZWZjb3VudCBoYXMgYmVlbiBpbmNyZW1l bnRlZCBhZ2Fpbi4NCg0KDQpKdWVyZ2VuDQo= --------------0RU3jj5DFajfimWsnYd00sbd Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0RU3jj5DFajfimWsnYd00sbd-- --------------4n1k394n10VIXl50CWi9p4Ih-- --------------JsLfkxePRUaQci00CUJuEKC0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKUZxAFAwAAAAAACgkQsN6d1ii/Ey/M nAgAiYz1TCudfsk6bf8+Ckl+7deE9VZbL85q3NM8vev40dbLLD2ranezAEaUT8UgBJxIKtJ4flx9 DuGbA+N58cEHvPNRIg4/E3zzAr92Cnzff6AF4HEGiZ1ZFVI8XASzccv9LLgvo11DkccIfunVKhHU quqf+0cyyK1RhskoYn/qdVGqUr7CG2W3BoiNOrYjndR8rJBh7zhj7Xx1RiHjMSGi/7pXOeK9oPxW s3FhBMdQAdP+ccO6pzGtgt+fecxgZZ1/U/DqN1D0mMzUoNANSwVpELFGqq37pbuFhrCMkVoDa2wM KisFTnpTsv9derB35pOTRV9/rQXc6a7tmmpkmi2SJw== =g5Al -----END PGP SIGNATURE----- --------------JsLfkxePRUaQci00CUJuEKC0-- From xen-devel-bounces@lists.xenproject.org Mon May 30 08:24:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 08:24:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338347.563108 (Exim 4.92) (envelope-from ) id 1nvahe-0003pV-EX; Mon, 30 May 2022 08:24:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338347.563108; Mon, 30 May 2022 08:24:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvahe-0003pO-B6; Mon, 30 May 2022 08:24:42 +0000 Received: by outflank-mailman (input) for mailman id 338347; Mon, 30 May 2022 08:24:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvahd-0003pE-Ib; Mon, 30 May 2022 08:24:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvahd-0006vW-EU; Mon, 30 May 2022 08:24:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvahc-00088F-2Y; Mon, 30 May 2022 08:24:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvahc-0002NE-22; Mon, 30 May 2022 08:24:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TZcoOmSfeh6qL1H1iorZ0t4V4R06409/jYewwDOcmIY=; b=5zfO1wHtxzbnNPQU80Kbbi8vfW 0swer52garaaI49bvVJisGsBEJ87aNOcDoB53/p1Fr+FHmOYlVPvFnMoMXjhGTLQyHZYpo3Wd7gHu 08nUv60cBj4eIFT2qVmKJURlEpxbIzEsw94qAFyFHkCIuQ9CVY95grQalxanGa6Qemz8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170774: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a5d9c7062162ff6404e62473a5cba7442e188d27 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 30 May 2022 08:24:40 +0000 flight 170774 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170774/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt a5d9c7062162ff6404e62473a5cba7442e188d27 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 689 days Failing since 151818 2020-07-11 04:18:52 Z 688 days 670 attempts Testing same since 170760 2022-05-28 04:20:24 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 110101 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 08:26:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 08:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338358.563119 (Exim 4.92) (envelope-from ) id 1nvajX-0004On-Ry; Mon, 30 May 2022 08:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338358.563119; Mon, 30 May 2022 08:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvajX-0004Oe-OO; Mon, 30 May 2022 08:26:39 +0000 Received: by outflank-mailman (input) for mailman id 338358; Mon, 30 May 2022 08:26:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvajW-0004OI-F7 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 08:26:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38e6cf57-dff2-11ec-837f-e5687231ffcc; Mon, 30 May 2022 10:26:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C9C0E1F9D1; Mon, 30 May 2022 08:26:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6B59313AFD; Mon, 30 May 2022 08:26:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 41fwGLx/lGLgEgAAMHmgww (envelope-from ); Mon, 30 May 2022 08:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38e6cf57-dff2-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653899196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yB78K+idfIOhoquiDkc12+zxCwXF1N7eE1XHWyLJ5vM=; b=YJcm463Y7/cO9dzFQpkc+gUhjQ/W8Al+YEIl7aM4VSGo+yG7ynyRFwsOQogzGAAmZVrcW0 fQlKwqd3mHwiL7MEmM2Qb5vC9q7etJjOCqT7fkUqy+r0ApyqxeRqszQCUChv2Sc+OA1vOg +OOdEVeHx0NVPIvbcjLE8cqsPm1ToRI= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Greg Kroah-Hartman , Jiri Slaby , kernel test robot Subject: [PATCH] xen: replace xen_remap() with memremap() Date: Mon, 30 May 2022 10:26:34 +0200 Message-Id: <20220530082634.6339-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xen_remap() is used to establish mappings for frames not under direct control of the kernel: for Xenstore and console ring pages, and for grant pages of non-PV guests. Today xen_remap() is defined to use ioremap() on x86 (doing uncached mappings), and ioremap_cache() on Arm (doing cached mappings). Uncached mappings for those use cases are bad for performance, so they should be avoided if possible. As all use cases of xen_remap() don't require uncached mappings (the mapped area is always physical RAM), a mapping using the standard WB cache mode is fine. As sparse is flagging some of the xen_remap() use cases to be not appropriate for iomem(), as the result is not annotated with the __iomem modifier, eliminate xen_remap() completely and replace all use cases with memremap() specifying the MEMREMAP_WB caching mode. xen_unmap() can be replaced with memunmap(). Reported-by: kernel test robot Signed-off-by: Juergen Gross --- arch/x86/include/asm/xen/page.h | 3 --- drivers/tty/hvc/hvc_xen.c | 2 +- drivers/xen/grant-table.c | 6 +++--- drivers/xen/xenbus/xenbus_probe.c | 8 ++++---- include/xen/arm/page.h | 3 --- 5 files changed, 8 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index 1fc67df50014..fa9ec20783fa 100644 --- a/arch/x86/include/asm/xen/page.h +++ b/arch/x86/include/asm/xen/page.h @@ -347,9 +347,6 @@ unsigned long arbitrary_virt_to_mfn(void *vaddr); void make_lowmem_page_readonly(void *vaddr); void make_lowmem_page_readwrite(void *vaddr); -#define xen_remap(cookie, size) ioremap((cookie), (size)) -#define xen_unmap(cookie) iounmap((cookie)) - static inline bool xen_arch_need_swiotlb(struct device *dev, phys_addr_t phys, dma_addr_t dev_addr) diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index ebaf7500f48f..7c23112dc923 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -253,7 +253,7 @@ static int xen_hvm_console_init(void) if (r < 0 || v == 0) goto err; gfn = v; - info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, XEN_PAGE_SIZE); + info->intf = memremap(gfn << XEN_PAGE_SHIFT, XEN_PAGE_SIZE, MEMREMAP_WB); if (info->intf == NULL) goto err; info->vtermno = HVC_COOKIE; diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 1a1aec0a88a1..2f4f0ed5d8f8 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -632,7 +632,7 @@ int gnttab_setup_auto_xlat_frames(phys_addr_t addr) if (xen_auto_xlat_grant_frames.count) return -EINVAL; - vaddr = xen_remap(addr, XEN_PAGE_SIZE * max_nr_gframes); + vaddr = memremap(addr, XEN_PAGE_SIZE * max_nr_gframes, MEMREMAP_WB); if (vaddr == NULL) { pr_warn("Failed to ioremap gnttab share frames (addr=%pa)!\n", &addr); @@ -640,7 +640,7 @@ int gnttab_setup_auto_xlat_frames(phys_addr_t addr) } pfn = kcalloc(max_nr_gframes, sizeof(pfn[0]), GFP_KERNEL); if (!pfn) { - xen_unmap(vaddr); + memunmap(vaddr); return -ENOMEM; } for (i = 0; i < max_nr_gframes; i++) @@ -659,7 +659,7 @@ void gnttab_free_auto_xlat_frames(void) if (!xen_auto_xlat_grant_frames.count) return; kfree(xen_auto_xlat_grant_frames.pfn); - xen_unmap(xen_auto_xlat_grant_frames.vaddr); + memunmap(xen_auto_xlat_grant_frames.vaddr); xen_auto_xlat_grant_frames.pfn = NULL; xen_auto_xlat_grant_frames.count = 0; diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index d367f2bd2b93..58b732dcbfb8 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -752,8 +752,8 @@ static void xenbus_probe(void) xenstored_ready = 1; if (!xen_store_interface) { - xen_store_interface = xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, - XEN_PAGE_SIZE); + xen_store_interface = memremap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE, MEMREMAP_WB); /* * Now it is safe to free the IRQ used for xenstore late * initialization. No need to unbind: it is about to be @@ -1009,8 +1009,8 @@ static int __init xenbus_init(void) #endif xen_store_gfn = (unsigned long)v; xen_store_interface = - xen_remap(xen_store_gfn << XEN_PAGE_SHIFT, - XEN_PAGE_SIZE); + memremap(xen_store_gfn << XEN_PAGE_SHIFT, + XEN_PAGE_SIZE, MEMREMAP_WB); if (xen_store_interface->connection != XENSTORE_CONNECTED) wait = true; } diff --git a/include/xen/arm/page.h b/include/xen/arm/page.h index 7e199c6656b9..e5c84ff28c8b 100644 --- a/include/xen/arm/page.h +++ b/include/xen/arm/page.h @@ -109,9 +109,6 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) return __set_phys_to_machine(pfn, mfn); } -#define xen_remap(cookie, size) ioremap_cache((cookie), (size)) -#define xen_unmap(cookie) iounmap((cookie)) - bool xen_arch_need_swiotlb(struct device *dev, phys_addr_t phys, dma_addr_t dev_addr); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 30 08:37:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 08:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338368.563130 (Exim 4.92) (envelope-from ) id 1nvatv-0005xc-0k; Mon, 30 May 2022 08:37:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338368.563130; Mon, 30 May 2022 08:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvatu-0005xV-Tz; Mon, 30 May 2022 08:37:22 +0000 Received: by outflank-mailman (input) for mailman id 338368; Mon, 30 May 2022 08:37:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvatt-0005xP-3e for xen-devel@lists.xenproject.org; Mon, 30 May 2022 08:37:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7a7cc1a-dff3-11ec-837f-e5687231ffcc; Mon, 30 May 2022 10:37:19 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-KfyWfLeaMsOU0Obl9lRU1g-1; Mon, 30 May 2022 10:37:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3581.eurprd04.prod.outlook.com (2603:10a6:803:3::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 08:37:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 08:37:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7a7cc1a-dff3-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653899839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NAq7axFy1uwL3aPXQ1FEOEQ5isqaMji9i5BtTMst+j0=; b=VDy1GTfNETXj5a637mKL68GThCyKPMj6bwnDP+J4SEHfMLVoi9NIQ1K6gfWOXZMK68VJAk uOt4yW/aEN0yYZkRfG3UV27bINwq+oPPiuyPLxzm5ywHA2hOEEkl+ALG7rWDo081s1QexZ w/qZUx1qs6Wopaz5bBZ7cCyIvcFsM4Y= X-MC-Unique: KfyWfLeaMsOU0Obl9lRU1g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYZfhEy+5mzzoQi4cQcSgre66kMu68wCtqQUavOMs3wxYpGuKMKrhvjVYhUpx8+I3UUhQuxuYvaxNHRHwwvs9V6bFEgIyTLdkXYDec2EKQqXBSxpzGfqdu++BE6ecrCuMOKFBfiVL/S1pmaVvXgcR/r0EGyAO660OjFzXOQCakVyXRKg4tx97CCmoZJoIQRAqh2tmc7Q6sCgBRk+19qSPFjzBPYKSqyw+eLMjJ1MjOrKjDsnQpdfiioBKy1B3xCGhb2ikgzXdLf9CDu6Yzb5iPuXMol22yJbv/JV33qP42yLGXtXsifAWkYTvxG2Ossy/VVzSP3GIFobXVN9cr7aYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s9y4LooOk5kGk6m4nC9HhEYTZys3Q38fa7CKNuNR9fw=; b=GsqG3O+g00GutsyTgBJXUpyJEwkCwAkH3Qo4mvO40aY5AcSXjEcNXNjEte0AQd/JIHbfRvOYU7Pold7Fk9URhlkXBBchlVcnnL5lj4mxZKbk1Kch/asLIu1nVva/+AUsYHKsiTkU86e0O8OgtuuFOdO7ylBMHspalz8V4T2vYhE6nrKE3sPYAApRyGZ7hQDlMjDmBlBFCfCeIafNM4ItWAO8dtGtTayz1b0mVZQuED7glRoOxYAwi3zKgpxwn1uKld12CghaOK1AU6H4bPzsQkaITPM1QoRuIe4FTwOCa71Cc9W8fEOOZKZeEGtHmlg5pPXUcVAaIZMOddrbcN2KxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <19b99aea-9969-5f64-dce1-474e7f544b1a@suse.com> Date: Mon, 30 May 2022 10:37:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Stefano Stabellini CC: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Julien Grall References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P193CA0122.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b72c243-bf5e-4fe8-c174-08da4217999b X-MS-TrafficTypeDiagnostic: VI1PR0402MB3581:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0rh0YCpcvoX8pb4vHFBWGNM20CppTWlQ2RluQRJ2UQkBkCyN39z6qga8NV5KuLv6ieeZ0R3LoVyhDFZqVAuXhpScKup+SqWC6QaWOmgBjexHv12DUEP1FOF6qhJ7ecoTvAKhWsGWzw7KGuutiMCEwf/zrH9i+jHEQ/48Zi3G0KKc0tjPuvMhs8KfojZKmg1HiJzntFGgQ2kWh74XdZUnNjsyYBAFho+ek1VpVHgA2RuKZg79QnzEaw2pwU+hUo5EHKb0XXvWZU+z/tZT1gdM2MKiuWn/YarqhiGIzLFxsSZY9xHNku2vSQRegDMhY0B8DL+3kPvOMjt4TgTQA4yqjAOi6Azshx6bKvprcCw5EQbu8GijyNmErxdIXY53vqm+udK6EH+OIpwJu1xOEW19yV8YDU+7PoEYTqX6ca58jEEieXW8AIBtJEthe1j+6oaaCORuW4nVklKuS90jer22MsvUYAK0wnw3YjSpI54RN3q6w4uutV4HkMtNOdo9Eo5o32ozL0NxCA9ORyYMaXq+r63TvKAm+i7MGKvfHwh+7aacHY1UDc/aeHnUDjyck096E/MYq2DY/nyOZwA5aTQtANpmwasBPlUeU6nZK6L2usAp5/cMConHTB9WXKDtsK6ImmbLjhh8zwSqfDt3neXhgqAN4NRXp1yZaUJr7HOIgMk4DPLqKFF5OiF8YRq7C7nMgL1p5/26CQRQJ6Z4w+EWWH5mf0JxneRzlk9pwsIyb3s6uYpVCCf1FBS/gaez8lFgR8Py4DN/VMSXUu6dUmO5E+iYzsrHYjZuwofp6bqNtlrkiIA3SI9UiMd2mydHyKyH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(66556008)(53546011)(66946007)(8936002)(6486002)(31696002)(6506007)(86362001)(966005)(6512007)(26005)(2906002)(38100700002)(2616005)(186003)(83380400001)(31686004)(316002)(4326008)(6916009)(8676002)(54906003)(36756003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HIEmSXWOF3XAaLcaSLw3euKtar9Y31w/o2QK/ou1YpyvN74vnz4yBO8gQBdU?= =?us-ascii?Q?IUhlWzwq8ymACt5VW/DOXCkdCY6uaVqA30D8qU4aLdtigFuzoVtiVkgPwfMe?= =?us-ascii?Q?yq6CyIE9yT7qxs0tnKTTUOSg6R67Sd731ebew1rRwac3jJCgIStbnh53lvV7?= =?us-ascii?Q?DSXU/FE5a8UDSxJy64IhERU7u2xP5dM1nypdsDSSEddorlH1iznWeV5gogxt?= =?us-ascii?Q?4V4KgBhV7yjae/lpbnpZgrX5VKziQUjAAvu7qf+mehZQR80ieVdLMJyxLTnk?= =?us-ascii?Q?ahpA/Zy8Sn4s/aQLYk6PKHX9n9vD/Jp+RynKhj1r0+Do1UqMkdXSDO1+M8Im?= =?us-ascii?Q?tuz2XVZd4SAarR3sSCEr3UBdmpXtn2BA3CkncqkFZYweAq2zA4aeZ67XYwIs?= =?us-ascii?Q?/csV3VW0mBzUgIPWdaj+lJxExxdNOd8h/FKQPMAya8SPg0DUK/9s7eoli7Dm?= =?us-ascii?Q?G3+e+dEmCOXFRHrNHJDsxDmi++Eze5nEIlCvgmaspork+KJgKQPtNymkt0HD?= =?us-ascii?Q?Ud9IfBa+7AIVkil93R4+ak0Km0KkGTxf6B1L3rDJV7zU/BJMPy6AbnJpfpbG?= =?us-ascii?Q?aIrFnXKAKXq41U1h4ZGEgiKwjv2FJBxoK5CGS6BlazJ1ugwHym2mTm1rcnHO?= =?us-ascii?Q?iWSno68yOLMHG8EkZ+ctu2jP3pclWIQxqn7NE78w4RA/DOe585nPEPs+vZYh?= =?us-ascii?Q?51NCU39Uk8S5GNeHfBvxHozWvMg8OvNAdsBWoWlU7j1boyZ6Eahwi9yNnRsT?= =?us-ascii?Q?OenW0Kh33av+JA7qdZTH4vgVQoWZQ/2qNji+N37WpVo/T550oG+t5rbRjFok?= =?us-ascii?Q?Of7E4TYZqJ3Bcuru8RIwgk1KmgXW2XAzwOHx2WMi7H0x61Sf36fFd+V/W+bq?= =?us-ascii?Q?TxdKyAlLVMSVNstyqb1W0OB5NK+9GjItBwG9GosQ6Au8zSatswm/xX4dXgCH?= =?us-ascii?Q?04W4EPjclzqWXaRhR4JjX1ZngdDi4Fv59VYIWkS8YJhUAvKkIeo3UreKfksW?= =?us-ascii?Q?dRfejmrs7F/L7JKFs5eo3aSltAvu0jwQSe+Vn3LFGffuMsvj+7AHU94pU0Ou?= =?us-ascii?Q?8xtjp8ya/2Pi/PurH2Kb9l8hc4tA8LPFiQRdFUByhJIeL50Nu919+I/h7gir?= =?us-ascii?Q?rwZKKBWmGSltB4hfsYidKvnr4KUHNkyoQwrk4gjRjw4O9nmRn6m7tPrGhW+0?= =?us-ascii?Q?VKMoNMAYAgiDd9ftIqJywOOidbaBuWfAKUMwXGwVt+8Q/LPy/CUDpqs97amF?= =?us-ascii?Q?t4XHl7wvOWP2w8rKPnkSJJoHA2QGWJPTH3FRWWvKZyGBcV2Xv5kZ8mr2pxN9?= =?us-ascii?Q?c6wLDAq5szyfVt58fwJG0mNRWTl+apMAG/MWJXAvhNm+vSe+HMFQVLpE0ZkV?= =?us-ascii?Q?ByvP4QuUT2IQw6Nl4GK436d8svDF0oaOd8thExq7Crr/lY7W8If6cuWnfc6S?= =?us-ascii?Q?/qvebdT+CS6uoPnfxs9nMosyXQhimDKBKN+G+9j5OI9UmCOfanKjlE6jHIlV?= =?us-ascii?Q?TpOwToeE/V9PBCKS5pf5dweN9nE7S72otV5yCNXHyaoEgKDAa/9VUxnNBAVg?= =?us-ascii?Q?f+06uaj8mOxilaZgZbhnnDGJbTFcruJLvRbBUKxhbyv6uEig32WkMhnPn2oi?= =?us-ascii?Q?2fjwelCdFDdK4XMRX/X3Je4Q6hDSEQXMHzBfjcpjwIamv9VXTW9N/iA4VEY8?= =?us-ascii?Q?olhgXHKXNv+entJoyZ1+2HNaQdnG7mKhyBePn4tMNAN48hJ8XwquiaJempDW?= =?us-ascii?Q?AoBxurMUOA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b72c243-bf5e-4fe8-c174-08da4217999b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 08:37:15.6555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IRK+nMiE8S0q6434Uo3EUAnPODmMtEYiKG/FtvJ0roMi3U2o0exW0AeCC/QKTa7Y+NcYksI6gXfcjclEXcMLpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3581 On 28.05.2022 01:16, Stefano Stabellini wrote: > On Fri, 27 May 2022, Jan Beulich wrote: >> On 26.05.2022 21:57, Stefano Stabellini wrote: >>> On Thu, 26 May 2022, Bertrand Marquis wrote: >>>>> On 26 May 2022, at 11:15, Jan Beulich wrote: >>>>> On 26.05.2022 11:54, Bertrand Marquis wrote: >>>>>>> On 26 May 2022, at 10:43, Jan Beulich wrote: >>>>>>> On 26.05.2022 03:02, Stefano Stabellini wrote: >>>>>>>> On Wed, 25 May 2022, Julien Grall wrote: >>>>>>>>> On 25/05/2022 01:35, Stefano Stabellini wrote: >>>>>>>>>> +- Rule: Dir 4.7 >>>>>>>>>> + - Severity: Required >>>>>>>>>> + - Summary: If a function returns error information then that e= rror >>>>>>>>>> information shall be tested >>>>>>>>>> + - Link: >>>>>>>>>> https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/bl= ob/master/D_04_07.c >>>>>>>>> >>>>>>>>> >>>>>>>>> ... this one. We are using (void) + a comment when the return is = ignored on >>>>>>>>> purpose. This is technically not-compliant with MISRA but the bes= t we can do >>>>>>>>> in some situation. >>>>>>>>> >>>>>>>>> With your proposed wording, we would technically have to remove t= hem (or not >>>>>>>>> introduce new one). So I think we need to document that we are al= lowing >>>>>>>>> deviations so long they are commented. >>>>>>>> >>>>>>>> Absolutely yes. All of these rules can have deviations as long as = they >>>>>>>> make sense and they are commented. Note that we still have to work= out >>>>>>>> a good tagging system so that ECLAIR and cppcheck can recognize th= e >>>>>>>> deviations automatically but for now saying that they need to be >>>>>>>> commented is sufficient I think. >>>>>>>> >>>>>>>> So I'll add the following on top of the file: >>>>>>>> >>>>>>>> """ >>>>>>>> It is possible that in specific circumstances it is best not to fo= llow a >>>>>>>> rule because it is not possible or because the alternative leads t= o >>>>>>>> better code quality. Those cases are called "deviations". They are >>>>>>>> permissible as long as they are documented with an in-code comment= . >>>>>>>> """ >>>>>>> >>>>>>> Hmm, so you really mean in-code comments. I don't think this will s= cale >>>>>>> well (see e.g. the DCE related intended deviation), and it also goe= s >>>>>>> against the "no special casing for every static analysis tool" conc= ern >>>>>>> I did voice on the call. >>>>>> >>>>>> On this subject the idea was more to define a =E2=80=9Cxen=E2=80=9D = way to document >>>>>> deviations in the code and do it in a way so that we could easily su= bstitute >>>>>> the =E2=80=9Cflag=E2=80=9D to adapt it for each analyser using tools= or command line options. >>>>> >>>>> I think the basic scheme of something like this would want laying out >>>>> before doc changes like the one here actually go in, so that it's cle= ar >>>>> what the action is if a new deviation needs adding for whatever reaso= n >>>>> (and also allowing interested people to start contributing patches to >>>>> add respective annotations). >>>> >>>> We will work on that but if we wait for everything to be solved we wil= l >>>> never progress. >>>> I have a task on my side (ie at arm) to work on that and Luca Fancellu >>>> will start working on it next month. >>>> Now I do not think that this should block this patch, agreeing on rule= s does >>>> not mean will respect all of them in the short term so we can wait a b= it as I >>>> definitely think that how to document violations in the code and in ge= neral >>>> will be a work package on its own and will require some discussion. >>> >>> Right. >>> >>> In general, we'll need to document these deviations and ideally they >>> would be documented as in-code comments because they are easier to keep >>> in sync with the code. But we won't be able to do that in all cases. >>> >>> We'll also need a special TAG to mark the deviation. Nobody wants >>> multiple tagging systems for different tools (ECLAIR, cppcheck, >>> Coverity, etc.) We'll come up with one tagging system and introduce >>> conversion scripts as needed. Roberto offered to help on the call to >>> come up with a generic tagging system. >>> >>> In some cases in-code comments for every deviation would be too verbose= . >>> We'll want to handle it in another way. It could be a document >>> somewhere else, or simply disabling the Rules check in ECLAIR/cppcheck >>> (but that partially defeats the purpose.) We'll have to see. I think >>> it is going to be on a case by case basis. >>> >>> >>> In short, I don't think we have all the info and expertise to come up >>> with a good deviation system right now. We need to make more progress >>> and analize a few specific examples before we can do that. But to gain >>> that expertise we need to agree on a set of rules we want to follow >>> first, which is this patch series. >>> >>> >>> So, I think this is the best way we can start the process. We can >>> clarify further with the comment on top of this file, and we could even >>> remove the specific part about the "in-code comment" with an open-ended >>> statement until we come up with a clear deviation strategy. For >>> instance: >>> >>> """ >>> It is possible that in specific circumstances it is best not to follow = a >>> rule because it is not possible or because the alternative leads to >>> better code quality. Those cases are called "deviations". They are >>> permissible as long as they are documented. >>> >>> The existing codebase is not 100% compliant with the rules. Some of the >>> violations are meant to be documented as deviations, while some others >>> should be fixed. Both compliance and documenting deviations on the >>> existing codebase is work-in-progress. >>> """ >> >> This is better, yes, yet I'm still concerned of "existing codebase": >> Without it being clear how to deal with deviations, what would we do >> with new additions of deviations? We need to be able to say something >> concrete in review comments, and prior to getting any review comments >> people should at least stand a chance of being able to figure out >> what's expected of them. >=20 >=20 > I think you are right that it would be nice to provide a guideline for > new patches. Even a simple one. For new patches, if it is not an in-code > comment it could be part of the commit message. (Also it is unlikely > that a new patch would introduce very many new deviations.) >=20 > What about the following: >=20 > """ > It is possible that in specific circumstances it is best not to follow a > rule because it is not possible or because the alternative leads to > better code quality. Those cases are called "deviations". They are > permissible as long as they are documented, either as an in-code comment > or as part of the commit message. Other documentation mechanisms are > work-in-progress. >=20 > The existing codebase is not 100% compliant with the rules. Some of the > violations are meant to be documented as deviations, while some others > should be fixed. Both compliance and documenting deviations on the > existing codebase are work-in-progress. > """ >=20 > The goal is to provide a basic frame of reference for new patches, while > also saying that we are still working on the documentation system. Fine with me for the time being. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 08:48:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 08:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338377.563141 (Exim 4.92) (envelope-from ) id 1nvb4B-0007RD-1W; Mon, 30 May 2022 08:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338377.563141; Mon, 30 May 2022 08:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvb4A-0007R6-Uf; Mon, 30 May 2022 08:47:58 +0000 Received: by outflank-mailman (input) for mailman id 338377; Mon, 30 May 2022 08:47:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvb49-0007R0-01 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 08:47:57 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0613.outbound.protection.outlook.com [2a01:111:f400:fe1f::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32392eb3-dff5-11ec-837f-e5687231ffcc; Mon, 30 May 2022 10:47:54 +0200 (CEST) Received: from DB6PR07CA0202.eurprd07.prod.outlook.com (2603:10a6:6:42::32) by AM9PR08MB6243.eurprd08.prod.outlook.com (2603:10a6:20b:2db::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 08:47:52 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::50) by DB6PR07CA0202.outlook.office365.com (2603:10a6:6:42::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.5 via Frontend Transport; Mon, 30 May 2022 08:47:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 08:47:52 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Mon, 30 May 2022 08:47:52 +0000 Received: from 8f94248d2738.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA7B2195-3F18-4934-B316-2B16E31DC334.1; Mon, 30 May 2022 08:47:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8f94248d2738.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 May 2022 08:47:41 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB7714.eurprd08.prod.outlook.com (2603:10a6:10:3be::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 08:47:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::1d33:77de:5850:383d%5]) with mapi id 15.20.5293.019; Mon, 30 May 2022 08:47:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32392eb3-dff5-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=J1gUNH+yEdcLxtsSAc/zGo+W2x9VJ/K+Lf07U8U8Sb3Nnl2feUz1dEoqTKEXFd9Vrr0oxzS3oX+lg3qyNi9OfoI1ietOrCG00/CU73ujmK5drfp7RPnqqzHb3azAuF8Ml1jRjiTmITAwqMmwhOxU+L7u7tMPrfM/ymJuIyn7uAB2JqQRrvTmFCXtEsCx7CuRl9WJb19xxnWjqa2nkWoCzFpMPJ2BxkPbeR7BBId2IuQYY2vygcLD00RfVRayubNmcjRMxUyrDSU+lkWeuziPqL2ZcQewwJ/4WdSroS9NYwGzCuk8q/TLuIN4FxjoV9mEwNjGV+VjHzEDyGRE4vibRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LL+Kiugkf7vDwypWQeZVd2t84IrJCQL8sjEUKKhmN4=; b=m6DoZawJQyRaGyUgakvTxMoSje85KZrl1i3ZqkfZ2BAEVWhJHwv/XkOKxpe8ElDVZQplsVz9cEJgZ0XRGsCrluWrsIaem7WALk6+R34nS//iY+Cvs4xr+u6mDCk6wfj7ME/e6AZED3ib2o0d3CFvzby3YhkFIPIvorZaAN6WYFx6bl/vI/7gRMzSNDp53o3X5iQsh/0Oi17Kp8LUhtBx7eSG9SQ1wtRC6g6a/QfzxACzM9vpehqe2ZZmKn5Tg8WAm7+6PT2wcCKTtAdaAZYMsG5r91RH6rofiEtYLTCXfeXZveTWszHaHcw33iWXUn9aii0nE13fia/U7B5IoXnEsw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LL+Kiugkf7vDwypWQeZVd2t84IrJCQL8sjEUKKhmN4=; b=sVGNYKZYUl0PDFzbIAsa/p1H7TnqSS9tIxcmXmqebeDOUzrqwsS5hOVAJp9CQV6zxNBF9k1wXMvA6Nl6arSk4NpFXDR/kdlN4hRW4fIkSsfAMz+GDfbYjLNN3PNupSYixTQNKdf8tSlaGB2B14Wah3gHeHKLOKfTG6WPHE4qEnA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuZ6lj9skvYvwJYUHZtK5wfOvk//7bnrkKiFKhY326/K1pW42sOQ9gTkaw/AtRp/xhrgIAdFaIwGOP263idXhnlYrjyvvOgjTFndHxbyRFqRjq+wtbz8Dw0GqIYo25fyyMgU5q3NN6m6IbnzXBQnXmq/Q2W4eNdlKQNcQ/xfUEP6Iji03LiybYIagcPN8OqCD6iSuENuQfjmGsHeK0goPGxkQi7C1fHHhzTiCEgqgVMoYGU+ULWeUiCndVLrKhkr35TjjzB6r+lxYz3zp6JcgqvrrBFJpYgrzrqIKwVpJ+283YnXO95lJipV6uxtvKcSj43r7y4LSAXR1lkpbOQHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3LL+Kiugkf7vDwypWQeZVd2t84IrJCQL8sjEUKKhmN4=; b=gh1x8HcImyEoE1xR5lZirEBQ3Lai9F9r2VPViX3QK4mD+8snCxj4d8bx4lyEWAXW9vCC+jovijOQzetzsPsjgb3g6ees0GOWFtzESDGECHZB1WcVOnNsLfCrOZdmALNbC18aVPn2gEPBoF0KfLIFXBokfFzRCzcZJHWJy+kEURZp1VE08gZxd6mnoJ9ka+bKbpzLwKvNDnXgJ5C/OAa8iU6QcMWdkf6xEhByLwkr/OJYN2Cx6irvBUreSwDydzPwIN0aW/WcsmsoYiow+7nmi4OmJt0jajs9i/VsdxHlVwxrf8WpH9m+QOqp1avr9jaRATP1hUHn0O7m8bUomJq/DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3LL+Kiugkf7vDwypWQeZVd2t84IrJCQL8sjEUKKhmN4=; b=sVGNYKZYUl0PDFzbIAsa/p1H7TnqSS9tIxcmXmqebeDOUzrqwsS5hOVAJp9CQV6zxNBF9k1wXMvA6Nl6arSk4NpFXDR/kdlN4hRW4fIkSsfAMz+GDfbYjLNN3PNupSYixTQNKdf8tSlaGB2B14Wah3gHeHKLOKfTG6WPHE4qEnA= From: Henry Wang To: Demi Marie Obenour CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/4] Grab the EFI System Resource Table and check it Thread-Topic: [PATCH v3 1/4] Grab the EFI System Resource Table and check it Thread-Index: AQHYVAPvZOxRdkFgj0uBaaJ4Rpp1GK0DfWsAgDPbGXA= Date: Mon, 30 May 2022 08:47:39 +0000 Message-ID: References: <0644ecd8-51cc-897a-5555-62d4c9ee9461@suse.com> In-Reply-To: <0644ecd8-51cc-897a-5555-62d4c9ee9461@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C681ADBC422A3744B2248251074ACF4D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 788ca25b-f51e-465b-a55e-08da42191552 x-ms-traffictypediagnostic: DU0PR08MB7714:EE_|DBAEUR03FT028:EE_|AM9PR08MB6243:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8cb5+OQioituo0tQn55AD7Dv0dxmENFs80kROAJU0i21fjveKEIJ7WLge5t0zTb6xMugi8P7B0ii09K8+R2HMSEchG7grZiRpVLugXnu+ulkTG5rN0xkv+nlDUHcp0DC7uKxMtsdmWmovRktvZFMR0l4c08tmDJP2nXCIFTkwzmVC1qB/hPkpp7mNSk4RqH3XEcW4/drxwD4pauH+u2EaEv0tdM9GIO5YKZIxOHFciq1dGTqf56yiTMcRcIEH6vlel939pyYgoGf1OpZ2UfxAZOcqGTMsFNi/CHzPLLoumY2S3wCdFwkVXl4f6AbWsqRBpI4P5Ks3rCptrJEHbiS6uzVcPdau5pOL3cCC3FJlWSF1f97NW5LVbtNU7zMBFlfg5ee3tDQOrsPuu45NGzIPIloSpFl7mpjTGTo3DCo07MZ7zjunrSLaBqJAPJzCtjiWIyrjV0uyIB0Z1d1nXGlMm9Sm/jS0b0sWeFnO2nt+pulGSmzlLz89WYwDraK9huE/sddq0O0fvNgfE1q/CA3pDu4l6+NOzgmLAsKMMHGUSz3fIlG3+az1oKX4v2jOQ9qXamDEFRSADvW4o2LUIDBJa+rwIcnboOk+6EK4YDvRODndUIcNHUQVubQwGR5/YZ3j483Z+vLGHkwUxbLKRp06lQw7d4ppfewJQ5eB6kCTb4OexeixAvBTm8X/ITMtvecaIDf7GdmVegy/rGa+f4VItK2pTQJFH8oeAVn4JSpqN4fQt1dsMAlflnxPE6kjWJrpEERuli9N5tsTE1GJgtWM5/+D3/Hz/Cr37DiQnOK3n9iL3qhNoAcEIawKo5YxdPpdHDsYODU0L3C9a/sKidarA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66446008)(122000001)(55016003)(83380400001)(64756008)(4326008)(8676002)(6916009)(38100700002)(26005)(186003)(66476007)(66946007)(66556008)(76116006)(6506007)(53546011)(54906003)(33656002)(9686003)(7696005)(2906002)(316002)(86362001)(5660300002)(71200400001)(38070700005)(966005)(508600001)(8936002)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7714 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8fecb83-a39c-4dc4-4409-08da42190dbe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Rs4E/0ykjDJP+zV2GPKa7OdWszZFS7Pcn4w+aS0cPxc/pjkSLuRGmJPsEju01EXdmNs1qMUTI2bcvf9q1/0Qi/8eg69d90d/feX1nmYyxOlEAg6AOMGDmilsPcFjfi3r/ODbgUSFjf18vsl0xCykmtzZ3FmNAxaFPshFB46/c/r8tAj75N0W9sjGlmku5spBPUmwncKyRcrg4AyW6od9frE1xO1G9OlISZA9J3kQ7WZZuY7yR9S6Zd3Dce3f0JbBLDL8P1pEpw4G0vqQ/G0YkiAgSBlu+qPiNI/qC6U/jcyxxlq3Q5LkAqyS/fIdkNOqfbZ9A9/uodcWw5FfVf8Zs43zD/lyxUttXFNxoyZlCVR87GcGS0ntEm5o7U5AWyMnxmeR774Ic6hyaq0eUMa/F9ALExeEAeo4ljPzZtKlo5mMKnUrDQ0Nqh74gieEfHcKS04pV8+Z3qBLB35er0v12Dgwtu6Qth19yqnUdQ5YAtqz7iWdRl0Bs9ZzIKvIWaCWRutoBfEt4Ey5584QVGeJP3ytfcT5BRQNgbU4VbZdLnqa4q/UXWSXnOFeQbAn8IckpU2lz6pm0YiJOLdBONVm8NPaoOrP8HquYhkzpnDfC40D0MfffAvQRUzxF4DTLf9yN9VPdQjHpt9kO/el/kbpRG5Y/bxzODomHQjiV/XdYZshoOb1ZYNkRbQuM25wMCHWo3dKkW871q21jKL1o4kx9prAT5l/5mh8xRdmDJ43IAZpOEIe9pDGInzwwD/Dg6dcFfyqUkM/o2A3rMqeqh//fhElF9vywKGb3yDPaJ69ggO2l2fBrmRVDN2aCwjz9eJ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(33656002)(55016003)(316002)(54906003)(9686003)(40460700003)(26005)(5660300002)(356005)(82310400005)(70586007)(70206006)(186003)(336012)(47076005)(8676002)(86362001)(53546011)(6862004)(4326008)(36860700001)(7696005)(6506007)(81166007)(966005)(52536014)(83380400001)(8936002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 08:47:52.5699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 788ca25b-f51e-465b-a55e-08da42191552 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6243 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaXMgc3RhbGUgZm9yIG1vcmUgdGhhbiBv bmUgbW9udGggd2l0aCBtYWludGFpbmVycw0KY29tbWVudHMgZ2l2ZW4gZm9yIFsxXVsyXSBhbmQg c29tZSBkaXNjdXNzaW9ucyBiZXR3ZWVuIG1haW50YWluZXIgYW5kIGF1dGhvcg0KZm9yIFszXS4g U28gdGhpcyBlbWFpbCBpcyBhIGdlbnRsZSByZW1pbmRlciBmb3IgdGhlIGF1dGhvciBhYm91dCB0 aGlzIHNlcmllcyAobm8gaHVycmllcw0KYW5kIHByZXNzdXJlIHRob3VnaCwgcGxlYXNlIHRha2Ug eW91ciB0aW1lIDopICkuIFRoYW5rcyENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KWzFdIGh0 dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvWWw3WDNt QUpoUjVFTlNwbEBpdGwtZW1haWwvDQpbMl0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9w cm9qZWN0L3hlbi1kZXZlbC9wYXRjaC9ZbDdYL2RUMzl2dmhabWhvQGl0bC1lbWFpbC8NClszXSBo dHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3QveGVuLWRldmVsL3BhdGNoL1lsN2FD MmErVHRPYUZ0cVpAaXRsLWVtYWlsLw0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ IE9uIDE5LjA0LjIwMjIgMTc6NDAsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gPiBAQCAt MTA1NiwxOSArMTA5MSwxOSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZWZpX2V4aXRfYm9vdChFRklf SEFORExFDQo+IEltYWdlSGFuZGxlLCBFRklfU1lTVEVNX1RBQkxFICpTeXN0ZQ0KPiA+ICAgICAg RUZJX1NUQVRVUyBzdGF0dXM7DQo+ID4gICAgICBVSU5UTiBpbmZvX3NpemUgPSAwLCBtYXBfa2V5 Ow0KPiA+ICAgICAgYm9vbCByZXRyeTsNCj4gPiAtI2lmZGVmIENPTkZJR19FRklfU0VUX1ZJUlRV QUxfQUREUkVTU19NQVANCj4gPiAgICAgIHVuc2lnbmVkIGludCBpOw0KPiA+IC0jZW5kaWYNCj4g Pg0KPiA+ICAgICAgZWZpX2JzLT5HZXRNZW1vcnlNYXAoJmluZm9fc2l6ZSwgTlVMTCwgJm1hcF9r ZXksDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAmZWZpX21kZXNjX3NpemUsICZtZGVz Y192ZXIpOw0KPiA+IC0gICAgaW5mb19zaXplICs9IDggKiBlZmlfbWRlc2Nfc2l6ZTsNCj4gPiAr ICAgIGluZm9fc2l6ZSArPSA4ICogKGVmaV9tZGVzY19zaXplICsgMSk7DQo+ID4gICAgICBlZmlf bWVtbWFwID0gZWZpX2FyY2hfYWxsb2NhdGVfbW1hcF9idWZmZXIoaW5mb19zaXplKTsNCj4gPiAg ICAgIGlmICggIWVmaV9tZW1tYXAgKQ0KPiA+ICAgICAgICAgIGJsZXhpdChMIlVuYWJsZSB0byBh bGxvY2F0ZSBtZW1vcnkgZm9yIEVGSSBtZW1vcnkgbWFwIik7DQo+ID4NCj4gPiAgICAgIGZvciAo IHJldHJ5ID0gZmFsc2U7IDsgcmV0cnkgPSB0cnVlICkNCj4gPiAgICAgIHsNCj4gPiArICAgICAg ICBlc3J0X2Rlc2MgPSAoY29uc3QgRUZJX01FTU9SWV9ERVNDUklQVE9SDQo+ICopRUZJX0lOVkFM SURfVEFCTEVfQUREUjsNCj4gDQo+IFNvcnJ5LCBvbmUgbW9yZSBxdWVzdGlvbiBoZXJlOiBXaHkg aXMgTlVMTCBub3QgZ29vZCBlbm91Z2g/DQo+IA0KPiBKYW4NCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon May 30 09:03:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:03:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338387.563151 (Exim 4.92) (envelope-from ) id 1nvbJ7-0001QR-Ft; Mon, 30 May 2022 09:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338387.563151; Mon, 30 May 2022 09:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbJ7-0001QK-DH; Mon, 30 May 2022 09:03:25 +0000 Received: by outflank-mailman (input) for mailman id 338387; Mon, 30 May 2022 09:03:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbJ6-0001QA-Ps; Mon, 30 May 2022 09:03:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbJ6-0007bh-O0; Mon, 30 May 2022 09:03:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbJ6-0001PI-As; Mon, 30 May 2022 09:03:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvbJ6-0006vw-AR; Mon, 30 May 2022 09:03:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ioNfCFjnqtg8vVzvxaB9HAYyzqZbzIXYpG9f/ZuIV5s=; b=wXItHsCVGNKdWnafjLtm0gajWV Q5arOqjZwcFVEuXrzqQ3SSIUHQK+tulomhTRUC9Fk5o2UDILXbqdprokahTBgA2KMr5Kg9R4h1+Vh hfeYYEgYQoR0ki5niC/4zkT6IUwtN/ZYXyFctv3QDf552A8k1IVjY6BxBaHLiIX4aXFk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170771: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=b00ed48bb0a7c295facf9036135a573a5cdbe7de X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Mon, 30 May 2022 09:03:24 +0000 flight 170771 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170771/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux b00ed48bb0a7c295facf9036135a573a5cdbe7de baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 6 days Failing since 170716 2022-05-24 11:12:06 Z 5 days 17 attempts Testing same since 170771 2022-05-30 00:40:40 Z 0 days 1 attempts ------------------------------------------------------------ 1928 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 213846 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 09:09:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:09:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338398.563163 (Exim 4.92) (envelope-from ) id 1nvbPL-00024f-8Y; Mon, 30 May 2022 09:09:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338398.563163; Mon, 30 May 2022 09:09:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbPL-00024Y-47; Mon, 30 May 2022 09:09:51 +0000 Received: by outflank-mailman (input) for mailman id 338398; Mon, 30 May 2022 09:09:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbPK-00024S-9y for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:09:50 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7d00::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41db320f-dff8-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 11:09:49 +0200 (CEST) Received: from AS9PR06CA0412.eurprd06.prod.outlook.com (2603:10a6:20b:461::6) by DBAPR08MB5655.eurprd08.prod.outlook.com (2603:10a6:10:1ab::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 09:09:47 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::4b) by AS9PR06CA0412.outlook.office365.com (2603:10a6:20b:461::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 09:09:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 09:09:45 +0000 Received: ("Tessian outbound c1f35bac1852:v119"); Mon, 30 May 2022 09:09:45 +0000 Received: from b656df027a4a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7B48A406-F1D2-4561-B5D0-AC8598C0320E.1; Mon, 30 May 2022 09:09:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b656df027a4a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 May 2022 09:09:33 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB4286.eurprd08.prod.outlook.com (2603:10a6:803:f6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 09:09:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Mon, 30 May 2022 09:09:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41db320f-dff8-11ec-bd2c-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YWSGjsqBo52g8vnF9u4cI3gk/sVFjhmnxztK0uv6vr19VXaOsr5v0zmwjT0yGSpywv4gs2mGhLR5fNrPNlFkSCBapNoaMd9nmq/6oZ7p7p05xzYFa5b5JDC1hb0MO5IHNOkea9lqm8vgVbn1yc/oIbH3Uclrlf9zgdloaZc//z7QCjoLW0JT9ounJMLYx3hkAsPWWIQcJN2ld/JWbZRKyqt+VP4Utbxj39KTo+0nPKLt3/rWTFrzgRBYspJUeyNKc52QZLwe2IYCy8a+3Usha5PyfRvojakCtzGlNbwdySM7dFyLW2wVIvN3f3FM/UQweOlUZ4L34VRMzJyVM7Dnww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e07rWfO/vgqUAvRMOhrmo1yBxYzOVBheNMOYS6KhLxY=; b=gaKH45gGY1en/YVIAZqDEDUOqc8KYY56TKhT8NmpKbm1nD/Fg43MHX2EegfP5fNL01EOJfhbZb2YEe8qRbX4hYsrYgSDW0T1SovQ1Hmj1MBjCXa+WXryR9Q+ArlvpE/LYYsr0MiytkFOcSvhlHxhffvKizyLIm9PPOs5k2NRy9lt8wbRjttoGoId6G6jJkYur8kS10aCbq3bgnw3vCGuqvnI877PlInTO+28fgfxdIGH6yAyrvsdjMuXIiqmTzAUp9b2deCz4jMPDTEKMfI0cRSZ9jUOkf38Cq+Hp+MdgbQEP5bLl6cqcunTHVyFz09WGvKd7d/MnSMEL2L6auf/OQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e07rWfO/vgqUAvRMOhrmo1yBxYzOVBheNMOYS6KhLxY=; b=N8WJ7Lh2f/its3/J2sxpvzb+ekmi21CjVHzn14UAYK5AWdFLIxpwIlKo7WP9o5+/mI8bfqIPOKQDCvYYK96oiv/gF0REnckh3u9MJluXCprMFUmLGfJt1+hYw540dRgTkFZxSpxNZFA8wEU4ueptkBhMTnxs1xVCzLxGm3KwK8A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 79f9c0e9ecbac5a5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsbSplKGxnhkqvOj/zvWgLvEa8dJehjHd+mpP6wLlOH0rR+A3qbCLvNCPHxPwQw3Y/QPu5otMHG1CwNN2N8gWG4m3rIZHu44TMz6LFEGlrBYcQWIM/JtmNgXQKci/n0fpHlIcZmp7d28hkRnRtUFTkZf7jgqV7GVDDwJQgYvJi93ZgPVQBdlBejl9cRKfjfaNrNxSzDmsqHI/BbwgI+/r6sH5J6kN6h0Nh03r6PNSjwc442KCThRM4QVl8iJVnzODfF9Se9wrMHTZAkJ/Ec48G+sxYJAwBDXz/mMSKfR9c4AUv1AWI1X4ZXdkd6nnM/GHtzcSO4cGWvyto9NUSH5Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e07rWfO/vgqUAvRMOhrmo1yBxYzOVBheNMOYS6KhLxY=; b=eks7i/InE57RGKa+l9bJfGr6RsmcwqlpvPnlCvAXkuzrB1EiHixGZUmyzkLJgT29qvq6+O8QX6J609A4+D68ttuGgAC8kuT7PnsJvIQTINnj7B0VMdhy0hKPyVjM78TcYLD4NC+sH0NeQHV6JwFgh48ZQohaxbsmEuryZ4T6uh0so3ALS+JXJwBEYKaBFy5ZZAM8qt384pBcNnc5aoQU0GJac6FhPuVpgXaQl0alNysJGz5gTqnh6plCoTeOPTtrhKUC6yPQyhE67/nko/FiW9vzPe6+BfeLSi0Zwg4ffuerHGUzv9H1o0TkYrkRct9XG9LqxyEWuorhZQWBBWzg0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e07rWfO/vgqUAvRMOhrmo1yBxYzOVBheNMOYS6KhLxY=; b=N8WJ7Lh2f/its3/J2sxpvzb+ekmi21CjVHzn14UAYK5AWdFLIxpwIlKo7WP9o5+/mI8bfqIPOKQDCvYYK96oiv/gF0REnckh3u9MJluXCprMFUmLGfJt1+hYw540dRgTkFZxSpxNZFA8wEU4ueptkBhMTnxs1xVCzLxGm3KwK8A= From: Bertrand Marquis To: Michal Orzel CC: xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Thread-Topic: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime Thread-Index: AQHYboWC3AEIHk6mmEWNblBNSTXfPK03LOIA Date: Mon, 30 May 2022 09:09:28 +0000 Message-ID: References: <20220523091324.137350-1-michal.orzel@arm.com> In-Reply-To: <20220523091324.137350-1-michal.orzel@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f47c748d-5344-4c93-476d-08da421c2425 x-ms-traffictypediagnostic: VI1PR08MB4286:EE_|AM5EUR03FT015:EE_|DBAPR08MB5655:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4wRY9VNNi8/4pDTVF3K5zwZIv3KK1XOCufEL9oDhTHAVe0ZCD+k9V7X49U/LZAtQDx9+DlUulVufbOm8bAktv8JpbksIZWZDbl4WWMJHyNi6NoPoBMgLmaUKqGPGD7ShBpfpfwA9rAnk+JY37uRMzDsrAL9FhTA29X5Zn7lImiKWSuy/Wj2xfyIiQFCgJW50FiTr+WA05TThQn7PYcyUa3N08RHPJqZ/hmLABngt8I+XZbKJV/HteLdPXeJM+LHz4TNh1j6GPkFfueXFXWSHIIuNnD+8g0uwXxseC3PP5MMdRdxQLX6mVeISrZd6cyz5fIOhrPAbBTd6dkKBk7gXLJGBN8JJhKXq306b6/0fX+hTxC1f+Qnk2w5TEbJ41LPmNQIWEqtto61ac9iPzQZ0N6htBU5Ja/U8RRghL9/YhfwXQNf8cKrxmM+iwiO3p09g1VZVKeSROjmWZBsBFn527VHTxu19i7KNXWHfuLbm8UiGrJedZqdOLtFukKyjZhs8s3D3U5b0UtBZZ43/cHiMen14MXkNppFTYmB3NwyMVYaxCQmknJcDLqV306r+ZhtaK2fa7xLPFgK7u6GoHvinI0jXlK4X54y6JbJcpwPq8iLONEXGBQGKN6Q2HLHCI5AvLjdV8/6Ljyy+lxwzXWPh4PBQTQfbdu44aEvuKTouHbJYlaXl7FK/gh3vhIJ8ZWffqZgnAzxW1naSkV2bDELmIFuZGrsQo6yCqoMP/hsiwPzpT+CCM6q33K24QUYaDiE8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(316002)(37006003)(53546011)(26005)(6512007)(6506007)(6636002)(4744005)(8676002)(2616005)(2906002)(33656002)(54906003)(508600001)(6486002)(38070700005)(86362001)(71200400001)(122000001)(186003)(38100700002)(36756003)(83380400001)(8936002)(91956017)(76116006)(64756008)(66476007)(6862004)(66446008)(4326008)(66946007)(5660300002)(66556008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <495BD34E7EFAD34789CE8A3BABFEEE3B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4286 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9fc0d0ff-f13f-44f2-431d-08da421c1a12 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eH8PKlDummJF6rwErfFzMNzQySariuUC4VssW6xJa24XrhpYsE71MSPPWwIR/Xz0oPN2m5ONHKpzSJhW4sx/l60fPodgkrITnTj6YJ4syI0bb5EWe9ROUvPyRlO6io3ryxesuv3LENZL4EnEknOx59y84iRFBpDkIRRZuqkJlUxW0f9vnyh359Wugoe5CRthHP6qJKJnLYY+KXgKhn4ySGuQNm2l6PsYdgWIkbarcpkVnsLUJUtDa+OpKI2016CSZQlq608tdGUYj9oI+5gu/7ye9ooB7D1+NO96rV4lNyU6BMz0M2pVbIw/tKTmoDARBkkVYHNMAt3uXhR8yG7B8+ybJc68IfEKXbzjBh/w9kkMJkyFCRPloUv7H4RNBlgnDchdo7MBTkJYkSeahQk+dHLfeRx/ftb1ctEkTs6RkhJ7IGz7XweZFLDVKceDar67zbEQK5xIs+WGnEGhWLL78uSvgGoaoY5lOhdt5L9RTKc0HFZzIOAUjQvFGcARWxbEHG+9X2nPEwEuPZxy7+BLiAPYlN2lEwQxHPncLVGeGX4uV+FcNvOuMzy9KyvzeaKWlBCPiMVwveO4qYCiaZTzvBYN5ZahETpNxHZnRVFfaMfUxPXOa42YEvYCrtWhMHIvSfmxGe17VQJgPCuKfWpxS9FGZkZlJeN/80sJKqtdYTPBncmEanhdB1v4F9GXDRTN X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(26005)(6486002)(8936002)(83380400001)(508600001)(70586007)(47076005)(6862004)(8676002)(4326008)(40460700003)(6512007)(53546011)(107886003)(2906002)(336012)(2616005)(5660300002)(33656002)(4744005)(6506007)(36756003)(6636002)(316002)(86362001)(37006003)(54906003)(36860700001)(356005)(81166007)(82310400005)(70206006)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 09:09:45.8661 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f47c748d-5344-4c93-476d-08da421c2425 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5655 Hi Michal, > On 23 May 2022, at 10:13, Michal Orzel wrote: >=20 > Introduce a command line parameter "maxcpus" on Arm to allow adjusting > the number of CPUs to activate. Currently the limit is defined by the > config option CONFIG_NR_CPUS. Such parameter already exists on x86. >=20 > Define a parameter "maxcpus" and a corresponding static variable > max_cpus in Arm smpboot.c. Modify function smp_get_max_cpus to take > max_cpus as a limit and to return proper unsigned int instead of int. >=20 > Take the opportunity to remove redundant variable cpus from start_xen > function and to directly assign the return value from smp_get_max_cpus > to nr_cpu_ids (global variable in Xen used to store the number of CPUs > actually activated). >=20 > Signed-off-by: Michal Orzel With the warning added in the documentation (which is ok to do on commit): Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon May 30 09:12:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338408.563174 (Exim 4.92) (envelope-from ) id 1nvbRg-0003Us-R9; Mon, 30 May 2022 09:12:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338408.563174; Mon, 30 May 2022 09:12:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbRg-0003Uk-M9; Mon, 30 May 2022 09:12:16 +0000 Received: by outflank-mailman (input) for mailman id 338408; Mon, 30 May 2022 09:12:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbRf-0003Uc-7t for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:12:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbRc-0007lm-1i; Mon, 30 May 2022 09:12:12 +0000 Received: from [54.239.6.188] (helo=[192.168.9.131]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvbRb-0004Ur-RQ; Mon, 30 May 2022 09:12:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VhJllbICoOYvU7uszbPjzalG2NblU3cZtSur7QWaC3w=; b=U7VUAVVKmvHmwLValKjJ8s1UxS 3fk1SULWS3VoHboZ8G+pzQkiIl6zfC4kGnoJpxV5OKQSY5cNv/TkZ1ebUc6H6hhdmp1uInl6y/jgS 6nripTvhcmKYMgkJ01aU+cMMfDxe9VIQmQ8iE/8uImyi37cJ4+BjEq0aCpp6dC5cHYDw=; Message-ID: <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> Date: Mon, 30 May 2022 10:12:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst To: Stefano Stabellini , Jan Beulich Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 28/05/2022 00:16, Stefano Stabellini wrote: > """ > It is possible that in specific circumstances it is best not to follow a > rule because it is not possible or because the alternative leads to > better code quality. Those cases are called "deviations". They are > permissible as long as they are documented, either as an in-code comment > or as part of the commit message. Other documentation mechanisms are I would drop the "as part of the commit message" because it is a lot more difficult to associate the deviation with a rationale (the code may have been moved and you would need to go through the history). Other than that, the text looks fine. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 30 09:17:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338417.563185 (Exim 4.92) (envelope-from ) id 1nvbWK-00048g-Ep; Mon, 30 May 2022 09:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338417.563185; Mon, 30 May 2022 09:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbWK-00048Z-A9; Mon, 30 May 2022 09:17:04 +0000 Received: by outflank-mailman (input) for mailman id 338417; Mon, 30 May 2022 09:17:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbWJ-00048T-7F for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:17:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43cbfed5-dff9-11ec-837f-e5687231ffcc; Mon, 30 May 2022 11:17:02 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-45-TApxVWC-P0Kv-O93YHiPxQ-1; Mon, 30 May 2022 11:17:00 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4373.eurprd04.prod.outlook.com (2603:10a6:20b:19::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 09:16:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 09:16:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43cbfed5-dff9-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653902221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KvHV05W7r0oNDbvKIvPwBX3cTsKAL6QeC/R0z6RZ6uI=; b=Lvv+Lerc5cHxMRPdk0TQWgSpefI7z5QM1fenIx+jPwhe0cU8fA6gHj4ODNRy/hAaqFSSZH t3OSqUKulMptkykXopPJHgbeO6epwBWMSDuvFD1ZJVqfi0Madr0zH7v4csM/E9GXxxr6zV kuFHZ7NCYA3QRmWpYEykTg4plzDJ1cE= X-MC-Unique: TApxVWC-P0Kv-O93YHiPxQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iE/z9nUAa5MQDRrchdQaNbf89+BvCN25yvizK02XwM1ZNXXLkT3y/Q9ukFCTdM1Da7SxCvTrw6yooTjJH8+t436E0ILl1XN8aKEofG20wEWKTvbOTuo7WGuJRYFG1PRwxrNOatnXQp6zBeE0l5K7B7g546WXuzf1FnL0sG73PXKqIbUlRLwG5I/h7gEZLWf7NIwyIYMbPhvnKvwmVNxpGdl0LLXh2NQyGOvtAWX8ewtcGTmfcEKz1kCH4UB/hv0wN42uSFT0Ed3O0zGg+hskGCLvzEPSIwri34LSGFsL0xQVTuzKadU8EdzlkrCsiFmnLuvNHw0Xy27Omiaddhuotw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KvHV05W7r0oNDbvKIvPwBX3cTsKAL6QeC/R0z6RZ6uI=; b=iZZUvyYQ/ODYvCMws9dsquJJu1eXgnGNK6DFOm4NLB2XnbMvuIg+VNxX4OZDRbiT83/OuFp+PVCjgsoXep6ErTrlyzyHj0tPiTp5pMRZWYROvGHiNqE7sAn6an/un2Lhv4Nw9RdjbmSqnIb1UYiGi0sEtnsEYWlsOnU0ON3LN0PN/jiFdXvsZj1CIok3SteQmdCX4F2ZJthiYYS05zRNOSRDh+aa4AAbAoEb53WG7O6pVqYQSbRX+8OaAopvzOysuht8qvARAureDOhbDTVI/ENKe3kuJ9oaxZyMsmwWBBWXFfIcNSd/3JMVIpVne5xoCjJyTQvaBh6bV+kiXqD+Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> Date: Mon, 30 May 2022 11:16:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Julien Grall Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> From: Jan Beulich In-Reply-To: <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0255.eurprd06.prod.outlook.com (2603:10a6:20b:45f::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 989c32ef-7f87-40c1-2d9a-08da421d25f6 X-MS-TrafficTypeDiagnostic: AM6PR04MB4373:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vMplQPZiqS1wfOCASKwcZRE9wdNBSFSkfED+z5RHGVQ6URvdLVh+Q8k2ypOHz2RbtOsFC6PQfkafsAyYZ8CjRsMVkuTXBdbdA6afHcKnS24L5DR7UlH4CqqlcV+WYZMIUCkE+zc65RNU2Ahgm92pDgELUY7blcXte5pMlJs9DkAliL6dhD3ZJZdWunm0WZqyyi6GMvd/PfendVpVUU4P4gmaOi93WBH/wYTc/v9/9GNGKQABdjG1g67OmJ7vHqIYxPPOtUoPY+YTJ6CMJ1rjB9r0O3jfPU8VUKxJ7/QQ6aVCdpBgrVdl1I8w3rnyXHmfRtow+jNK5ZI72fsfK2RXUDi+3zei7NKMwEjTvieo0nPkC6XYKIlop+i/zMokl6asHm2Zc9iE3hPXjc5fd8ewQExRHCDXsGluLLVGFaNMPOx7HM9fLOZL7fEHXN5xeRm6lNi9mlU7Mv7kmGU6rLRb0SrEgGQ4JpZ3+5mY1s+cWahD9ak56F3p8T0s2s5+0o6wGMvY+Orn5w9p+mgmV6nzSjafmOjMv9c9mgGZ2wPhOd7WAb5+zRCE9LqToIdp5CzzFYWBzCdN3XWdj2rdv2KbmbYHWcESkJ5EYA1bAc8lzPCx5bp9t3ZJJneq/Im9Vjo9b9jaLfwZCgKSL7szesL+ETbNfDcoQL7AKMkFJ46QShIwWlaIbzZSmC2uI7q7BM8oYORDxZtuMtZkO/+ZdUlv5aFCa7hBMh79WuDUelj64Ok= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(186003)(38100700002)(86362001)(66556008)(5660300002)(4326008)(66946007)(66476007)(83380400001)(8936002)(36756003)(2616005)(4744005)(8676002)(54906003)(2906002)(6916009)(316002)(6512007)(6506007)(26005)(53546011)(508600001)(6486002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFFUMXl0bU5wUkdkYlNPSUlwbjJmRFhaYWhjSmlZTzZwL04xcUZ2K0E4NCtt?= =?utf-8?B?UjNhUHdJdHdiVnhBenJvZzVRczdxNnlNZVJaZXhxT3ZOcDlCOEpIYVB5M3Nq?= =?utf-8?B?OTYzMytndjlWazlXNnl5TWdQUDU2WG5YZTNyU21LMnZZR2hIdEs3R1dPTW9W?= =?utf-8?B?aGQvYy9aVm5acmg0Rkd4Sk1pVWtkV0s5eTBWUnJJTmFZUjBQcTcxWVM5WEds?= =?utf-8?B?TmtJMEw3NXN6WUp5bjlGN0hGRzdHenVKVGxlQ0FKRFQwajFDSm8vWHBTRkht?= =?utf-8?B?cWVNVVN3MmQ2Tm9TSjZKdDdwY1AyM3Q5SnU2ZnJ4MFNlY0tDWUcyeXB3K0FV?= =?utf-8?B?Z1A0Mm5Qek5vUEpsR0RneFFTTGttY0pUT0diTzlpQ0ZnMTJRaEY2RTl4Y0NX?= =?utf-8?B?NCtGRHh4ZzgrY3p6Tm9KQm1wNGJZUHNHQXZOVTBuN2xlcXU2RUtWY0JlZlVO?= =?utf-8?B?MXY3Q2tFdFZDM00zL1Z3V2EzcFpBV3pOSDRFemdKYUdNT2FFYVhTN2w1eTNq?= =?utf-8?B?MldFamNmbHkxc3NHNlFrRitFa3ltcVp5c1M0WjNUVzNOam1IVjdaQXErRUor?= =?utf-8?B?ZXFaWlByM00xb29seTNtdUhIMzA2RmxrV1RBOVI1NkwyYklGK0dIK0ZhQ0tB?= =?utf-8?B?M0RXUmQxbHc5RHFKUjFNbkU2ZllidWwvOEN2Z29pOC84UHYwK2JnTEZtVW91?= =?utf-8?B?TCtsdGpwSHBPTXlBamhxZGVEZEJLaDQ3SS9oWmJvNUNwWWpMWG1PaTdSOFBr?= =?utf-8?B?S1dSblZKY25uUUJPVTl0NHVRdkJkNmhGaklJeE05YWh2bXlzVnY0R0YzeG5M?= =?utf-8?B?K1ZNZ0xGRCtLZWk0Zmpsa0ZZYU5vVzVVZXZRTVNtd1RaR0VIdEQ3dmFjNE84?= =?utf-8?B?QnRMM1VYMUkxMkdrUHpaWmF5WDlNZHZydDY5aWYyQ2RNOFpyaHRkeG1GMzBy?= =?utf-8?B?MXRHUUs4a0ZlUllrU3NyZlgwTFAvWVRuSy96S1hsYmI3QStwZS9OTXI5YStE?= =?utf-8?B?Szg2b0xmZVBOaGtNZWxlOVRuejNKYVdaNElHaWMwS29EZU1EZzlaZjRGelBE?= =?utf-8?B?SDFEb242OXdpY2tFTEwvZ2VpSy9DeEl1dUJ4R3R1eFZQVU02TTZacEZLbkdr?= =?utf-8?B?b1ZQdllsK0t2WnMvVHJ3dWFLMm9hcElvSkxRNlpYeURSbW82N1p6K1BqZUZW?= =?utf-8?B?UGpPV29FeldCNVIvdVl6WEo5MDJsUjV1cUVRTkNzemljRmpLTUNoZUdzZFNt?= =?utf-8?B?UTE4eEovZmVvYkRRTkdDM1RGZC9zUStpNDJ5eDFZZzVZcnQ3RmNPdzYyeHRk?= =?utf-8?B?ZzdlYlRUaEpHMFQ4dUhCK0JjZzBEV1FUM25pQTRzUlIwR3ZCR1NjbVRWalNX?= =?utf-8?B?U0c3WUtzU1o2b0tRbjJ1dlc3TjBJcDRlbnorTWlrRzFFak1vbk5KYWJyd3ly?= =?utf-8?B?MGNySzF3YUh0K2VQd1pER0oxTk83ancrOXJRUEd0NmVtTUc4VnFaTTNXWlJG?= =?utf-8?B?alFIUVV5aUloZGRwRitRaDNKby9FUkxYRDFBbnZ1N1JzNStCY0NLVWpwSHF1?= =?utf-8?B?M3hMdkFnQ2ZLekk1R1d1MTRJb1pqcDJEVk1iR1RLbHhwWWNNdTZ5YXVHSkhN?= =?utf-8?B?cjU3b0Z1NExOUEQ4Tm53bWRkdlZ3S0xjS3JlREpySHYrN1hWMkZZbUdCU0FQ?= =?utf-8?B?cExCTjFpNFoyWUlrYU1aYmFUZ3k0WXVKeE1VRmJhK21KOWhwUUJQWkU5WWpz?= =?utf-8?B?Y2dUUVNrZlZwcGVtNngwWkxEQ1VNWGE4ckM3MGdUYUlaVzZ3MncxMUFhcnN4?= =?utf-8?B?cVZObGJMQ3gvbTNjQVRwVmZrRXZFaGw0ZmZqTVl2dTNNb3RVbWp6bFAyQzJ0?= =?utf-8?B?b2xHZmlvNEhFai9UOFI4eTVqQWFWUDh5Rm0yWXJLSUdkSGxYYnhXNVZ5cTNm?= =?utf-8?B?V1U1dUJ6WjRXNGhuc3IyQW5YU3l4cVZmVFBrQW9xcFBqS0svU1BRQVRLZzRO?= =?utf-8?B?RDNWTnpaeGZ5YWRPS2FTajZlK2NqNDJzZjVFYTJkWTFpK09ncERPdTFEQnpw?= =?utf-8?B?RklMK1h1Vm9KaDl3cFVFaExUM0YyZzQ4OFBhRWdQMDVuTzQ5NU1ERjhFd2h2?= =?utf-8?B?T3B6cDU3dlpXRW9yb2hsaURuY3k4OHdCS1ZETXpHOEsxdDhpMXdMdzBmZ3pk?= =?utf-8?B?RmQ0UE81YzdWYUltRDNtTW5EMTBWRXpTRWhKSmNzMFlXN2lpOFJrYmJoZVhI?= =?utf-8?B?ekxWbjFlb0JEMU54ZUV6MXU5WEc0STd0YlFhZmVkTHFlN0lEVEQ1b0tvM3NQ?= =?utf-8?B?TEpYeXhZK0hRUnBEdThZNTZoMjZHc3lybDZOd044WlZCUzZ4TzFRZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 989c32ef-7f87-40c1-2d9a-08da421d25f6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 09:16:58.6440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V/pnp2+UIm4FCaf/3wDF8bxrVxuLmkBTKOE/9sAw7oCfj7yMYHUu/UvUIvNQOdeqcgs/PAfQwRnPY/uwEBzMKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4373 On 30.05.2022 11:12, Julien Grall wrote: > On 28/05/2022 00:16, Stefano Stabellini wrote: >> """ >> It is possible that in specific circumstances it is best not to follow a >> rule because it is not possible or because the alternative leads to >> better code quality. Those cases are called "deviations". They are >> permissible as long as they are documented, either as an in-code comment >> or as part of the commit message. Other documentation mechanisms are > > I would drop the "as part of the commit message" because it is a lot > more difficult to associate the deviation with a rationale (the code may > have been moved and you would need to go through the history). But this was added in response to me pointing out that code comments aren't standardized yet as to their format. The alternative, as said before, would be to come up with a scheme first, before starting to mandate playing by certain of the rules (and hence requiring deviations to be documented). Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 09:27:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338426.563196 (Exim 4.92) (envelope-from ) id 1nvbgB-0005c6-Gm; Mon, 30 May 2022 09:27:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338426.563196; Mon, 30 May 2022 09:27:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbgB-0005bz-DG; Mon, 30 May 2022 09:27:15 +0000 Received: by outflank-mailman (input) for mailman id 338426; Mon, 30 May 2022 09:27:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbgA-0005bt-Sj for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:27:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbg6-00082K-KZ; Mon, 30 May 2022 09:27:10 +0000 Received: from [54.239.6.188] (helo=[192.168.9.131]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvbg6-0005b3-EU; Mon, 30 May 2022 09:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=2gB+KIYvt3AujpSFf2BHkK/P/Unch+Daz3wfH2Pd9ec=; b=D8ij9/zq+bKQBnT+uUdU2h9pxu d1KRUVfqP90jHs8MwX03eDtw+JvKnpZ+q6JamwWeizabW88Vde88WDtlJhNeULzZnjKoPiBc07ZSd YRWnC40yk5Y5rIa6RZ5HWkTtfBGe5fIUvP1j4nepGLPqUN6hKDxDjCWwkByflEukOgeI=; Message-ID: <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> Date: Mon, 30 May 2022 10:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst To: Jan Beulich Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> From: Julien Grall In-Reply-To: <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 30/05/2022 10:16, Jan Beulich wrote: > On 30.05.2022 11:12, Julien Grall wrote: >> On 28/05/2022 00:16, Stefano Stabellini wrote: >>> """ >>> It is possible that in specific circumstances it is best not to follow a >>> rule because it is not possible or because the alternative leads to >>> better code quality. Those cases are called "deviations". They are >>> permissible as long as they are documented, either as an in-code comment >>> or as part of the commit message. Other documentation mechanisms are >> >> I would drop the "as part of the commit message" because it is a lot >> more difficult to associate the deviation with a rationale (the code may >> have been moved and you would need to go through the history). > > But this was added in response to me pointing out that code comments > aren't standardized yet as to their format. The alternative, as said > before, would be to come up with a scheme first, before starting to > mandate playing by certain of the rules (and hence requiring deviations > to be documented). I don't think this is necessary short term. It is easy to rework a comment after the fact. It is a lot more difficult to go through the history and find the rationale. Documenting the deviation in the commit message also makes a lot more difficult to triage issues reported by scanner. With a comment you could just read it from the same "page" (scanner will usually provide context). So overall, I think allowing to document deviations in a commit message is a pretty bad move (the more if it is a short term solution). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 30 09:33:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:33:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338435.563207 (Exim 4.92) (envelope-from ) id 1nvbmb-00073h-7r; Mon, 30 May 2022 09:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338435.563207; Mon, 30 May 2022 09:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbmb-00073a-4y; Mon, 30 May 2022 09:33:53 +0000 Received: by outflank-mailman (input) for mailman id 338435; Mon, 30 May 2022 09:33:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbma-00073T-3w for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:33:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cfc3107-dffb-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 11:33:50 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03lp2176.outbound.protection.outlook.com [104.47.51.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-GpCOlhQvP7WPohdUHj8gfA-1; Mon, 30 May 2022 11:33:49 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4202.eurprd04.prod.outlook.com (2603:10a6:5:25::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Mon, 30 May 2022 09:33:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 09:33:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cfc3107-dffb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653903230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efMemm16pYw5nvgM1bwvH44Sl8mmqjTlIH+wKEAO0CQ=; b=P39P2zNNN98dzLKF1y6jRqA/GKgdLh75SqJNHBpuFR1LNkYLn0pkmU2vjy2JMiO+fx7vxQ yi8kAE062qA9ZWjwXkzsvPl1RZdcOQs6OvMFRVcLDCT3AMrBMzTG39wBshBbcgrzjEuaid HPxhIL+CLkLIvhHfhHXMyHUMcCnn61A= X-MC-Unique: GpCOlhQvP7WPohdUHj8gfA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8hPVtQJ0T1iIj2nMofS2G3VneQusZRumYrsCg44V5x2xPnRwfI46Xlnsds/i+zfFEH0uKb34QV+eA+1kgUxHnHu44Zglot9lVB0kJdzf+AFsSQW8PE2ITlOkYJyOQPWd3i9oNx8hee1xXwfC+HuIbldrfd6R55jL9RzUtVKx5piqeJNTEY7Xt7X7FCxcGB+Z02ByEcLW9qCkzs00C8sg2t2+kJ3tl1FFMHjF/cbjid9AsQs4sXpS9X2Xj2xgHplclX/6aexLZThcDmFoPDZuavH57fYF9MAHoHk96CVCDUWdRJpIEKNhUEcuJv8vCD2QQw8oU+LKM7v4f4Gske6fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=efMemm16pYw5nvgM1bwvH44Sl8mmqjTlIH+wKEAO0CQ=; b=d1Rio3tD9ejE9YcvdpGo8wJZNJZstjroM4ew7b+m8GB7p4LVIZDEhpkoRdU3FtuB9Ix4+Yr29einjeQ3EN9EjFKKUe8G4yDLKpbto146GiSjY6+eha4vV2pENscGUy+zmpSkVdTOqpd5K46EBc9pWTPr7PPgbBFi3zWocd5LqleHu5tj0F+5AzDyPD8dorM/mnkXIsNYN/igyW+eLg2zVxOLjpMd3pcvPSOwYtbS0Qu3zPh254hKjzheN+BhwguYPpjnPiGyLMdDwuvQ1xPtkLdiODh4yuxIQPf5vaKSY3Azm0uuZFt+DIINm2ptCxUqsr6IwY5zMWt+TLZTzmwkFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> Date: Mon, 30 May 2022 11:33:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Julien Grall Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> From: Jan Beulich In-Reply-To: <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0078.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e3640d1-cbf1-4767-4a7f-08da421f7f79 X-MS-TrafficTypeDiagnostic: DB7PR04MB4202:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yCQPnbNHoPsNQhBP+jCHK85nmrfLkFRWNbyG+yF6/ok6zBiykCZP6T4NueL0aB9FaRP/xzO6C/BgC+g5eYhEuksN8KA0xJnbhawbvPBP+TJ8HorraM0BNa4JNwJNpp62Ka9PfhdfrhZ9Dou4ToaRaMRfIH08lm4QD4BnELAbJ69JgD8LZB2aEDhgwLUZm+VaD+3E58ZiWopnKUdNOA401RHBiJ81OlPjeyf3lUona59Z3hFFhZi8qWG6UFJe4UgV/YwKU4LBVhXEMJsNmh8pFwuNNMCHaZMEdg27TxPyTlhBrs153d+5l4n6albwoofzCmBtgmE6/y7Pn4x7qQ0AnEk1RDV2J7zeofMGo8dUf7QpjOXrpTSEygwJMaMQWu0JCnvIrnRf/YiDD6m/Q4XMOUCIFjnAYPEpdoz7ZN5Mtgvl+4pXZ/xD6v69nVdGrEVbfzorABHn0vtB4TRxUW+hKc5RSXrelVRAO9QbTVI366gJVuEb3caYk8hBMXTPE8jKJfYH4wyu4t4i1CwhikZQaE3UIvUmmV3WOwFYdsAvJV73JQ0otmAmmRCDqxk1h1x2LMnBSL7A1IJk1u5WjPlAKqI266qPxExAPoS5zKqJisluAkAQtP/cFhLrcClhEPvJv81BUIN05DLO7ucvi0P8j+A8uyCS6wfmpaNDqzhITD/dKzIsvMom/eutW5FN0Aukkm3hw0yiq0LpkJIYNyKWreTnC0tFdk9BDS4ql/1+eFg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31686004)(83380400001)(2616005)(5660300002)(186003)(4326008)(8676002)(36756003)(8936002)(66476007)(66556008)(66946007)(6486002)(6506007)(6512007)(38100700002)(508600001)(6916009)(316002)(53546011)(54906003)(86362001)(26005)(2906002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RURLeUw1eWp2Yi8wK2tDV0JiOUZURU1PSFVSa2I4SlBIZ2NvUHV4QzB6UEpG?= =?utf-8?B?cG14K2tEQ0RXSVZKSHlKVkh6aTdpSURFQitpVTloS3laQjZDc20wczBDVDNt?= =?utf-8?B?RFdNeEFhd3J3bThRb2Vpb2N3Q0dHZHRJU1ArL29OYW1tVkdSQTZWSktKZjFt?= =?utf-8?B?Z0w3RjV2bjBDT3VuYU1nZmh3U0pzcE9HMlpQWm5HZnhzWUkxR28wemhNWXBT?= =?utf-8?B?bFJKZjljM2ZGM0JUcEZRcEJKRVhxN0JKdjNtWjBZUzRTKzB4YlVQNHcvQTFQ?= =?utf-8?B?YkpZRTRsa3hwQ2VmLzZwS013Sm5MVDdsbFdFU1NCaDNqVStuNXdLZytCNytz?= =?utf-8?B?NmFUdHJPOUFQUnhtL1RCYzJ5b05KUmRHY1BoWXVqeDlwK01Ob1kwT2s1a2Nu?= =?utf-8?B?emtid2gzMTJsbTdvV1poUTkzTDh5WjBYRG9Yak5adFFLRDZWVmp6NkNkYWE5?= =?utf-8?B?VlR3WkFmYzgzbHFFbG9wS3llOGhMSmRZdk82RVNRRzNVcTB3TStNbzVxWW1u?= =?utf-8?B?QkJVTGtmbCtKT3MwVHFLTkdXOHFmVGZzVnBXWU1Wa2RyLzhXVFFJT2FEMXgy?= =?utf-8?B?ODAvQlFNbFduV3lZVXlYTDFjcFppd3NReVRCTE9HRVI0NFp4ZGppZlJFYWRG?= =?utf-8?B?MWdRMTBDbVE1OThRaENnbnBwNzZ1bnNCTmZwVUp2WTZMRklvQUhGaFB2N2I4?= =?utf-8?B?TDlXWFNObEZ4TkpOSnZWWFArZHFLcGU1cDBBcGR0TzRmeWRJVks2U2c1aHBu?= =?utf-8?B?dkJlUmlqSTE5Y05sTlJ2aGljclhXREpJSzlLNmlveXNXMUg0cXVsZFBuNFAr?= =?utf-8?B?WG53YUVTVUpHeDVUd096UnYrSkZBYzRuWGJ6VDlHR2hYWVJuL2V2bEg1ZVVW?= =?utf-8?B?V3JqMmdHR2ZzcUJFZDJNL3EydWxyU3Y3Vy9DSy9EQXMvNzVBSGVRVmN4TlVv?= =?utf-8?B?ZEpkRnJ6Wis0U3hBRVBnTXBIUmkxaktYR0ZxRndKZ3BqQ2padFR5N0NzK2RJ?= =?utf-8?B?Rm85QWZJcDZFTGlncWRjdmd6SXNLcDRUdzFOanM3UmVKNGJHRm1LVmpQejFP?= =?utf-8?B?NEt3U250QXJxRmJaalFXbEJuSE9icDRWeUQveFE2YjE3QU5NRkpiK2YrTFlr?= =?utf-8?B?cDltL2pWZEdNZ3BtZzg0NlE5SGRzeFBSRXMvb05WTU1sUnNMaXBxZ0szSUtw?= =?utf-8?B?N2t3eGJYajBwSFhuVTBXNklIN2JjN2Fib3VBcFk4Ulp3eVhldWt3ekxqRUsy?= =?utf-8?B?RHF3cGhQTkhTMDhDLy80S1VsZjZjNHNUWWpZN3VWM2gxY0FWRVBCL0tMcXlY?= =?utf-8?B?Mnhxdy94dnJyYWNuWmY5VkVaR3hydlVJMTlwbG1zWkZRY1dXRHZiQjZhTDBJ?= =?utf-8?B?S2NwdlR1azI5WWhwSkJ5aUF5d3Q3T0dDUVl6WU9Tb2hMQmtyQmRHaVFST2xX?= =?utf-8?B?QXV3TjdLZE1TaUtRaGhJWkNHRTBXOGROMy9hYjhkclliK0l4RHlIK3pxS2Uv?= =?utf-8?B?dTI5Q3grWTZLZzZtMnMyL1I4d0F6STE2d0NqOFkyUTN4WlRjb2pJSHdhVG1j?= =?utf-8?B?am9lUW9jVk1EUHh2K00rQXBNcDFUZVBFSFd1RmNrck9abEQyR2VkYVNRK2ps?= =?utf-8?B?NjhmVkY1K3c0THJOdTdjNzVGMXR4VVM4R3E5NzIxZnhNRkVRRDhTOFhHTHkr?= =?utf-8?B?Y1J5K0gzUDFSd01ST0xWbDhxRlpZbGdKNldrbFRRbXAwYVZZMGNub090T3hW?= =?utf-8?B?VUVQekdRd05xWVNqdUhLSXI3dlZoQzN6dFVndGlGaFZCQTBHS2FRZ3JQczRI?= =?utf-8?B?Q0NJQUhhbWJwTmxScVk0Y0hTVXZ1TjdXS1IyZDhKWG85TnJtbStnR0RRNTNP?= =?utf-8?B?UWdWUUFZNmU3aDRqY1k5bUtoUlZoOWVjVWRRM0pQUERyL0FHVFZYTTRMTS9W?= =?utf-8?B?dzNSOUpjbUZHWHYwVzc4WXVuOFRZdlhKeFRIcW5LNkc2UFZEUnhhWllyRXdW?= =?utf-8?B?ZWdGVFNTK3RQOCtNSG1YVG0xczdZVVpKd0VhS2p1MWZNNUJrOXM0MENpVGt5?= =?utf-8?B?dDQ4em9wamxkVUk1Z1Bva3V1YjJ5YzVTOWQvWGZ2L3ZadTRlL3RwTTBiMndt?= =?utf-8?B?YlZoWlYzcjhiSXVUTU04WW5STjZnSUVQZTRnem5sRGFDQmRqaWlIcGhvOGpM?= =?utf-8?B?bUVGbllQcHlCZ0hxYjAxS3pxZDlnRXNvRU5jdC82Y2xYUmdoRVVHcEtLWVBP?= =?utf-8?B?M0VMV3Q5amRoQllLd2hUbThURXdGcUV3T1REaUJCazZpZWZZK05oMkRyT2dU?= =?utf-8?B?b042b2hwNUlXR2RFNFRXZnVTUkFHVGtqcmNnZkZSS1hGYk4yQ1piQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e3640d1-cbf1-4767-4a7f-08da421f7f79 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 09:33:47.7983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 59GQvmIy4+BsKto4eWfAgzcSqMAlea66lA5Uwdk/9mz55YY+NezGNZPZwNkPIYO8MJfcTwlX008F8k1bnUdn/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4202 On 30.05.2022 11:27, Julien Grall wrote: > Hi, > > On 30/05/2022 10:16, Jan Beulich wrote: >> On 30.05.2022 11:12, Julien Grall wrote: >>> On 28/05/2022 00:16, Stefano Stabellini wrote: >>>> """ >>>> It is possible that in specific circumstances it is best not to follow a >>>> rule because it is not possible or because the alternative leads to >>>> better code quality. Those cases are called "deviations". They are >>>> permissible as long as they are documented, either as an in-code comment >>>> or as part of the commit message. Other documentation mechanisms are >>> >>> I would drop the "as part of the commit message" because it is a lot >>> more difficult to associate the deviation with a rationale (the code may >>> have been moved and you would need to go through the history). >> >> But this was added in response to me pointing out that code comments >> aren't standardized yet as to their format. The alternative, as said >> before, would be to come up with a scheme first, before starting to >> mandate playing by certain of the rules (and hence requiring deviations >> to be documented). > > I don't think this is necessary short term. It is easy to rework a > comment after the fact. It is a lot more difficult to go through the > history and find the rationale. We all know what "short term" may mean - we may remain in this mode of operation for an extended period of time. It'll potentially be quite a bit of churn to subsequently adjust all such comments which would have accumulated, and - for not being standardized - can't easily be grep-ed for. By documenting things in the commit message the state of the code base doesn't change, and we'll continue to rely on scanners to locate sets of candidates for adjustment or deviation commentary. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 09:41:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338445.563219 (Exim 4.92) (envelope-from ) id 1nvbu6-00008N-6Z; Mon, 30 May 2022 09:41:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338445.563219; Mon, 30 May 2022 09:41:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbu6-00008F-1c; Mon, 30 May 2022 09:41:38 +0000 Received: by outflank-mailman (input) for mailman id 338445; Mon, 30 May 2022 09:41:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbu4-000086-NE for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:41:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvbu2-0008Hx-Ju; Mon, 30 May 2022 09:41:34 +0000 Received: from [54.239.6.188] (helo=[192.168.9.131]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvbu2-0006s1-DK; Mon, 30 May 2022 09:41:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8ECuxcUEJsPakeQD7a/8je9L4xM57YNigTNEb3sLBTo=; b=V7TYZZnm18FByqnnfQjm0L7VwV HzW9RpX0gXfwCzNqqkGsFA9VVrMaQp52P0uPPHhgp9SUSz4nFaB0YYIsvT8HXWaCEDL0ZKaPG5FNU 0ziequGxUM/20p/Cl13HUcJI/earCA/o+D5steeFWct/NbXWZVxNcMc389SZlj/3DotA=; Message-ID: Date: Mon, 30 May 2022 10:41:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst To: Jan Beulich Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> From: Julien Grall In-Reply-To: <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/05/2022 10:33, Jan Beulich wrote: > On 30.05.2022 11:27, Julien Grall wrote: >> Hi, >> >> On 30/05/2022 10:16, Jan Beulich wrote: >>> On 30.05.2022 11:12, Julien Grall wrote: >>>> On 28/05/2022 00:16, Stefano Stabellini wrote: >>>>> """ >>>>> It is possible that in specific circumstances it is best not to follow a >>>>> rule because it is not possible or because the alternative leads to >>>>> better code quality. Those cases are called "deviations". They are >>>>> permissible as long as they are documented, either as an in-code comment >>>>> or as part of the commit message. Other documentation mechanisms are >>>> >>>> I would drop the "as part of the commit message" because it is a lot >>>> more difficult to associate the deviation with a rationale (the code may >>>> have been moved and you would need to go through the history). >>> >>> But this was added in response to me pointing out that code comments >>> aren't standardized yet as to their format. The alternative, as said >>> before, would be to come up with a scheme first, before starting to >>> mandate playing by certain of the rules (and hence requiring deviations >>> to be documented). >> >> I don't think this is necessary short term. It is easy to rework a >> comment after the fact. It is a lot more difficult to go through the >> history and find the rationale. > > We all know what "short term" may mean - we may remain in this mode of > operation for an extended period of time. It'll potentially be quite a > bit of churn to subsequently adjust all such comments which would > have accumulated, and - for not being standardized - can't easily be > grep-ed for. Well... Scanner will likely point out the issues we deviate from. So you we have an easy way to know where the comments need to be adjusted. > By documenting things in the commit message the state of > the code base doesn't change, and we'll continue to rely on scanners > to locate sets of candidates for adjustment or deviation commentary. The part I am missing how documenting the deviations in the commit message help... Can you clarify it? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon May 30 09:55:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 09:55:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338455.563229 (Exim 4.92) (envelope-from ) id 1nvc7U-0001fv-EX; Mon, 30 May 2022 09:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338455.563229; Mon, 30 May 2022 09:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvc7U-0001fo-AF; Mon, 30 May 2022 09:55:28 +0000 Received: by outflank-mailman (input) for mailman id 338455; Mon, 30 May 2022 09:55:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvc7T-0001fi-1m for xen-devel@lists.xenproject.org; Mon, 30 May 2022 09:55:27 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a0ed2b24-dffe-11ec-837f-e5687231ffcc; Mon, 30 May 2022 11:55:25 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-6-wVzK7pjzPCSaW73714e8Gw-1; Mon, 30 May 2022 11:55:24 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5211.eurprd04.prod.outlook.com (2603:10a6:10:1a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 09:55:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 09:55:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0ed2b24-dffe-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653904525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M0j/myxkkkGdoPdEsWqT1KymJQXDepJ7roZwg9grDmY=; b=Jmh9409xT5k2HRcFHtm+9JPQIU4a4Epj8EXmcqyuZ5XFR+QjVX8dnL/6gZyDU1ZaZfuubC lTwqRYfclg++8n3IskQo3KFt13FICwrfAl70I4pFbJ2Zb2Smddc0ya8WCf+/5t4tcG0qe8 NEezsdFzyEo7+EkHTteG1qJ4YanDuj0= X-MC-Unique: wVzK7pjzPCSaW73714e8Gw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXsg3PYIYNo1Nsd5Yuzz8ybHnErsp0WSpY1sBJv55jq15rNqgQ03cXo2wQyqSB9t62zHrs8E4StxLC8cNLWujUBGK9xcVyp2tJNdYdkUj5VULr+PrTb1woOAHd1hOBK+sNghc0smXcVDUwYmzttVYknU8AJTlu2hlzVQ0QCaQblT5KEbLSot9qxayg3usItEkT1/Ufj2CeiChLaKEnvDErPRPS2iV5ltIIXN4sYfHKt+XjbvWSqGNu4gqlWm62dzx0vrAgNEJvrOafF+pQLzwHIkz8VYwIrv9TobZP4WeVzWOFdF5CsVx6sHp9FD5v/lSiRe7GTv3uP2Qff9618CkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0j/myxkkkGdoPdEsWqT1KymJQXDepJ7roZwg9grDmY=; b=Mr3CMj+tPClPOA45DL0ANa4w4ogaUv15C3LizIHoYsnnxMKd9joWqEx+fNvVKhZviO5G+edvGA45qrVvvEvsDbwZPkhIDTQ6t7TNW7EBQ0H7zATw0XknHHUIRYC8GfEYz1NjDyyWFgMeHF6o4mtCZJag7d5U6eUKXN2JUAyVK1itEXFnpPziz19CoxugWJ2oTOVCJ0cLiNUKKpCpd0DXy35gGHDfcpGQn80J9K6bf8knwLmWDDlr0H6ge8X5LSSKBt7ywvClb5DoO6bEApfcvh4mYxcVW/nOTBDerGtdQQ5LYBNZrlNxRL7Onp2bV2MAJkPmy220MJisepTAlUbvmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 30 May 2022 11:55:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Content-Language: en-US To: Julien Grall Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" , "George.Dunlap@citrix.com" , Stefano Stabellini , Stefano Stabellini References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0023.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::36) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f7ad597-4708-4b79-f24a-08da422282fc X-MS-TrafficTypeDiagnostic: DB7PR04MB5211:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LHm1ftGxIj4+GtGBZw6U4R3LoFKAXfeQZ9r8pzAGO39IjcedKtK8MKKUih2vC2LU4mO0y2q78LLn1czCOtHMG71oI6mVQ8SV9AdoMcH3AH4FplELs4vstUnCzIYigXFMpMryj0ZjK2Q2DpypAYjg6jgbAkS2tL16Em+agvnSvcuXs//YPBYQUJGeIPcp1dwacx67zTzY8QgRD7wGfPg8EDPbrJMnq13n9wlAudwIjcdl1NyrAQgoSmO9uKe/BaM7OSvG/X8puGGujSHnVMCb12grtBSg2T+Z0BMUc0RKUcWPVyFaJekwhmXJgZJJH4UpLQbmrLQHbLi+9BiV1wJUEjTy0ldNW0dUeEzEDv68PMN+dGgwFNcn3Q6qPszfkTzfmA9Oe5Ud0TmrOhlRi9gix2XrXMFYSRQAuZMETQKPSBxS1DZuAPeFlFODcTltK3JNi3h/xBCF58MG0kNQaXJbk9gz8JGercRgdU7Rzolb31dgLab1VDHEWHG61uAldZvnXYTcXn4xJc0Sat9cK4Btrkb+NchiwQc0Rv3zutnC+jC+Fl/HhMj0YHpSbTPH0rwemgFFrrwjpgyPn52N5Q56FTq0R6QD7NsAGGyu8Pi+2EgY/xDLSDfx95KF8I7gDVqyrHpPya2SVeG/Y0wQBWvUpJTUzHt8kiYhLhO0utywvWQF23IqVsHXvWszOBIMc4XRG2DRNkKQz99xkcSLNHJLuGU06Urpjemds82Rb4vus98= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6486002)(53546011)(2906002)(508600001)(38100700002)(86362001)(31696002)(8936002)(5660300002)(6506007)(2616005)(6512007)(26005)(36756003)(316002)(6916009)(66556008)(66946007)(66476007)(8676002)(4326008)(31686004)(54906003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2xvSDRuVHJ5bVAxSkpITTFKTUwvb042M2xOOUx2WXZ2RnRPN3c3bDM5b1Bn?= =?utf-8?B?YkVCK1Y5WDl4Y2tEK0xMNkFFUlZMTk83cXB5dFFodnFGVXVMQ0Z2NGJuQ3hi?= =?utf-8?B?RmpGTmQvTDRNbjZYZUVlWjZrTnh1MTM0amF1WG1pVTFwTnM1T1ViTjNKKzZ0?= =?utf-8?B?UVZ4NlhDdUJTeDJOam5odnAyK091Mjcwc21SVm1sa2ZJaE5vTGM4bElvM0Ji?= =?utf-8?B?Z2VSNXpvbG82VVR4Tno3SWNYSitnd3RLemdBbDdnU2QraFd1eVJpTzVGb2RB?= =?utf-8?B?U0NCMldMSU5RSWRxbjVSa3dpNkFVVFNZeDVyeTJDeHRXcnozNE9wdU1haXhx?= =?utf-8?B?cjY1cnhVSnVnNUVpalpQTVpLNEdlRUNWeExsVkZNazVubElCcmorVnBDM2ln?= =?utf-8?B?UEZxaDlId1VVZytyZmFLdjFOVmlDekFZeS9OZ2RER1JCcHRZSXNyaVJmM0Vx?= =?utf-8?B?YzNBb3gyUTdjaUhzWTlGN0t2am5LQXVCTnlpUGlXekYyNnJyd1hiV3hqOE1p?= =?utf-8?B?NjM0WGtxU0xSbE9Wak82VFVtUzNNQk93SHVUN3REWU5sL0t5ZzBCUmJFOXpW?= =?utf-8?B?QXBVQkx5cHNPUUpRS1hHQzhtenRuRnIwZ0hEZmlqYVFjRGxoYzdwV3RNMjF3?= =?utf-8?B?OTVEUlBxUFlZZ0VPWit4SXpacDY4UlRBQ21SS1UwSTl2b2FGdXRWWmgyUTNm?= =?utf-8?B?UGRqQTExNHZ5SnZySTh0WDdNUjlWb3BQSms1TFV2bCttRU9EbWhocTZjMXJZ?= =?utf-8?B?RVVuM1hGYTlyQk51bWMvTTVXNGZRSWtZUjBUdUlWaElBbGVPMnF6MDZCSzUw?= =?utf-8?B?MldZaW12QW5MM3pBV3o2TVZuOGZXQTI0ZXVCSWhHc3BCbzYvSDllWUtCRmN1?= =?utf-8?B?S2lzbUdYakdoWWRkMEhmOGdwU084djk0NFUzTTBLamJZYk9LdGFxd0pWYUxJ?= =?utf-8?B?YmtwN1JlL0FSa1F3QmpUWmI0TnA3MXZYR3ovcVp1dmpMVnl0NUNzb0VFR1Fp?= =?utf-8?B?cFgzd2hncGJ4RG9IcnhsdzN0K1EwaXIxditlNy9FVkdwNWNzaEFDaFEvdGlW?= =?utf-8?B?VDJETG9zOXlmMFdhaEUwaElnYnBXZzNKMGd0cmk2b0ZRUThSbElUbW90UERY?= =?utf-8?B?bXdwaW52eE5JM1VFcmMxMC9mREdQV04ybnZ4QXErRDRnc2UxYUFCUG9UMmo3?= =?utf-8?B?dlJRdjFPRDAzOTdhWFlISzB0N05JQTd1ZmlQU3VRMjJiZUpzM1RaNDBUMGpM?= =?utf-8?B?QkJZcXFya2lReDRuaTYzU2FtREhvcC9mS2FlK2l5YS83MkhTWlIrQ3JyblVh?= =?utf-8?B?VUpSUzBRNG0rRC81NzFkQlhJWVViWFpWakpoMTJOOEg2MDZKL2h1aTIyQXFT?= =?utf-8?B?bG1rUTRIcDFFeS9Xdk0rdlBwcDN6ZVBRbkRLblo4b3BnNURZMFB1T2ErbEFx?= =?utf-8?B?SGJVWWJFa04ydFZDTUpCcFZ2cU5hRlh2clh4K3h1WWtvNUhLblBPMFZtZkJR?= =?utf-8?B?RytCcXhLb2ZmL2ViS3NUaGpvVXdIc0lpM1dzR004dzlwVWl6dEFuWWo2TW13?= =?utf-8?B?V09ZS0YrcXVXbTdpMGEwUWlCUmw5SGlHaWRqN0hCY1NrOUxyQWZ1K083U0Q2?= =?utf-8?B?MWlaMGVFTUJtOHZUL0JQaUthcThwMkgwVThsYjNaYWEwM2drbzJVeUV2Rkpj?= =?utf-8?B?aEdPcnVkbjl2UWxIQWRqS3dWMWl3UE5WaUhWVGkyamRjeDJYZXlXS3kxM3RZ?= =?utf-8?B?Q2dHSTl6R1JHMlJVaERaK0NLQWZKbU9XL1BiSnpzTElhb1dJQ2RMK3RvaGNv?= =?utf-8?B?L1ZaazFHcHB6d2liOFR0OEVGTWU1Z1hRbkVoREJUdXNIWCtKWWdzSWlhTzg4?= =?utf-8?B?cGliUDVDZThUQjZLcmpWbUUyN0JSMXFzNUpTOUpYZk1xMFkrU0JaMFNsNE5y?= =?utf-8?B?cjJxeGZMdHp1SEkva1UxYUg3ZVlFQUlEeGw4SEo3MUlab29SQlJJQytxY2Zk?= =?utf-8?B?Zk1oSzYzcDFlMU1jSmRwT1ZXenRyVXI4bmVhQ1lZSlgyTUlkZHNOZkw3S3ND?= =?utf-8?B?VFBEUFAyT1plWmN1NVZPZmhzQnJoSmJYbkZFRVJtdGp6VVBjNTR2cUxJeUhw?= =?utf-8?B?aFhRWXFLeTlUckIwZWFBVDgvdWlYSHlOUTdjNmlIN3ZwU092WTRsSFowOEZl?= =?utf-8?B?QkNteUkwY3RCUHR2c3ZpSS8zOFlWVlVvWnFwNklaaU0waThXc0dYZWdmRnls?= =?utf-8?B?cDFDV0JaV1hFRkNVWG5qTWpCZFhWeVIyWVJ6ZUo2TU9razdBK2FUM1E5aVFl?= =?utf-8?B?RkVBMHcyTm1VUE1lSlpZU0ZTbk1JUFFCNnFtNkJ4bk5rcHFVRk9rZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f7ad597-4708-4b79-f24a-08da422282fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 09:55:22.2782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +ojL0UC6bY53XS35139uz8Z9tYaVI21ZkGfZDI4W6jfipjoRnd9pGiTQ7o+bvY+UO3SNbNxhgxwXDlBQVJFp6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5211 On 30.05.2022 11:41, Julien Grall wrote: > > > On 30/05/2022 10:33, Jan Beulich wrote: >> On 30.05.2022 11:27, Julien Grall wrote: >>> Hi, >>> >>> On 30/05/2022 10:16, Jan Beulich wrote: >>>> On 30.05.2022 11:12, Julien Grall wrote: >>>>> On 28/05/2022 00:16, Stefano Stabellini wrote: >>>>>> """ >>>>>> It is possible that in specific circumstances it is best not to follow a >>>>>> rule because it is not possible or because the alternative leads to >>>>>> better code quality. Those cases are called "deviations". They are >>>>>> permissible as long as they are documented, either as an in-code comment >>>>>> or as part of the commit message. Other documentation mechanisms are >>>>> >>>>> I would drop the "as part of the commit message" because it is a lot >>>>> more difficult to associate the deviation with a rationale (the code may >>>>> have been moved and you would need to go through the history). >>>> >>>> But this was added in response to me pointing out that code comments >>>> aren't standardized yet as to their format. The alternative, as said >>>> before, would be to come up with a scheme first, before starting to >>>> mandate playing by certain of the rules (and hence requiring deviations >>>> to be documented). >>> >>> I don't think this is necessary short term. It is easy to rework a >>> comment after the fact. It is a lot more difficult to go through the >>> history and find the rationale. >> >> We all know what "short term" may mean - we may remain in this mode of >> operation for an extended period of time. It'll potentially be quite a >> bit of churn to subsequently adjust all such comments which would >> have accumulated, and - for not being standardized - can't easily be >> grep-ed for. > > Well... Scanner will likely point out the issues we deviate from. So you > we have an easy way to know where the comments need to be adjusted. > >> By documenting things in the commit message the state of >> the code base doesn't change, and we'll continue to rely on scanners >> to locate sets of candidates for adjustment or deviation commentary. > > The part I am missing how documenting the deviations in the commit > message help... Can you clarify it? I understood Stefano for this to merely be for the purpose of justifying the deviation (preempting review comments). Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 10:13:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 10:13:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338465.563240 (Exim 4.92) (envelope-from ) id 1nvcOt-00048W-VZ; Mon, 30 May 2022 10:13:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338465.563240; Mon, 30 May 2022 10:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcOt-00048P-SY; Mon, 30 May 2022 10:13:27 +0000 Received: by outflank-mailman (input) for mailman id 338465; Mon, 30 May 2022 10:13:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcOs-000489-Mv; Mon, 30 May 2022 10:13:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcOs-0000UB-J0; Mon, 30 May 2022 10:13:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcOr-00056i-V5; Mon, 30 May 2022 10:13:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvcOr-0002zM-UR; Mon, 30 May 2022 10:13:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dq0vf0qt6RqOXphmcTFq45Sk//Oy1XxV4Hta7uYxL08=; b=n65E2kMIoRRIO7P6CtF1vY8rqq WJpcJi0VEDviHirnMpyvvLIDIxwOPcDKaccFuT4guFzbbIKKC/5Ncd8EyOUVYyT6zkawMjRF1Xku4 Inm5dDj5SOMmfD81s0lp+VZ4BPZSfOXqGp2wGjL4+ycqoE01iCH6v2S5Bf3/dRV7Y/XI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170772: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Mon, 30 May 2022 10:13:25 +0000 flight 170772 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170772/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170766 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 170766 like 170751 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170766 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170766 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170766 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170766 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170766 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170766 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170766 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170766 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170766 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170766 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170766 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170766 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170772 2022-05-30 01:53:14 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon May 30 10:22:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 10:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338477.563251 (Exim 4.92) (envelope-from ) id 1nvcX8-0005dM-UZ; Mon, 30 May 2022 10:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338477.563251; Mon, 30 May 2022 10:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcX8-0005dF-Rc; Mon, 30 May 2022 10:21:58 +0000 Received: by outflank-mailman (input) for mailman id 338477; Mon, 30 May 2022 10:21:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcX7-0005d9-7y for xen-devel@lists.xenproject.org; Mon, 30 May 2022 10:21:57 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 535ff97b-e002-11ec-837f-e5687231ffcc; Mon, 30 May 2022 12:21:55 +0200 (CEST) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 May 2022 06:21:49 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BN7PR03MB3713.namprd03.prod.outlook.com (2603:10b6:406:cb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 10:21:47 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::6149:243e:e6cd:3082%5]) with mapi id 15.20.5293.019; Mon, 30 May 2022 10:21:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 535ff97b-e002-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653906115; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=hxNWiKgoM9uZt2M11yH5/jTUWWtDPCugBCciGv6qVUc=; b=Jn5lbQLjeAcYS0crRwOQdEkenMEBbLKSNWEfby1Pwhlrz4WSL3ccHQzx rdXfXzb2KXtvODwOcMa+BtrpAEmP/dy3i2nqeeKqrOJsXBVg+GEqWay6P +0/4tZ/Ym1fz3YXUBqsod7h2wwgIVe+w0V9b5Z9A51j1dICVSSLQ41i7w 4=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 72294393 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Z9fVlqN6cImmnOTvrR0alsFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem TxOHSzEb+HbITHFz+oGOoXi/EkAsZeHm4NlTABqqX09RSJGpMSYWIvJdh7+NnnNf8PPEhNut 51FYYWfcJA+RCeC+hrxOba49XMhj/jZTdIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl6 N2i88bWYgao1jB9b2lEu/yO8EIx4K/5tWIW4wdia6ga4FOGm3crV59OfqvZw1kU42V38kxWY 86ZkdlVK0uAp09F5uuNy+q9KgtQKlLrFVDmZkB+AsBOuTAf4H1rukoHHKBEMx0P1m7Rx4kZJ Ohl7vRcdy94ZsUgp8xFO/VoO3kW0XpuoeKvzdCX6KR//mWeG5fe66wG4HIeZOX0zt1fE2BWn cH0HRhWBvy1a0Ba95rgIgVkrpxLwMAGp+rzsFk4pd3SJa5OrZwu38wmTDKXtds9rpkmIBrQW yYWQT5hSRDLZUFwBnwwB5AVrOS6mXTtcRQN/Tp5pYJvi4TS5CpY9eG1dfbwJJmNT8gTmVuEr GXb+Wi/GgsdKNGU1TuC9DSrm/PLmiT4HokVEdVU9NYz2AHVmjNVVU1QDAPmyRW6ohfWt9Z3B EET4CUj64Qv8kiiVvH2XgGioW7CtRkZMzZVO7JgslDRkfuPi+qfLk1UcGFEdvM4jcYJdC0D1 3qNjdjgFwU65dV5TlrYrN94twiaOyIYMGsDbi8sVhYe7p/op4RbphDSStduFoalg9uzHiv/q xigoTIinbwVgYgu3r+i4FHcqzu2o97CSQtdzhXaWCep4x10YKahZpe08h7L4PBYNoGbQ1Kd+ n8elKC29/wDA5iLk2qWXOwHEbWt5vCEGC3dhV9pD98q8DHF02W4YYla7TV6JUFoGsUJYznkZ AnUoww52XNIFH6jbKsyb4fvDc0vlPDkDY68Dq2SacdSaJ9scgPB5DtpeUObw2Hqlg4rjL07P pCYN82rCB72FJha8dZ/fM9FuZdD+8z07Tq7qUzTp/h/7YejWQ== IronPort-HdrOrdr: A9a23:MelBEaE1CrxveYEWpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.91,262,1647316800"; d="asc'?scan'208,217";a="72294393" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eIpzxkJ326gm0MeMRiFSrYDlphLpgYJQ1dX7iN2xpi4w/hWjvkHvIxRpGFI2xuI2f/GJr3lqnS8NyyP9EuDe9CHsN4LrxDJIWt2ws+OVPb9dC6ODnP3VoPKo4FGPFtetRtrTQXeYI1ZpS1f32hnqsgAod2CM63lXpI0XUxFqwmgM5W5jgd7c64vJ4UqsJHsQL19++uehdVEElbyUCs+7uMEUH6+YDMBV7CcsrNZAAG6W6l071Jp05mHehi4pDU8mvJfNmu+/nw0btLIq+CW1QxAmlY25fDefTppi9NEntqRM55qCgvFPHFfBoFLufITMFNb34nAGuNKbqp3zg/rk1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5mV+7evD0CmbiOs8GugWlozumwiUqkJm56WZD5Qv4s=; b=DHPum1UdeSRef4NJtfrxITNzjqTnz9VKKw0q5rKrfMGNTxL8JDUw0Y3wT+ol+jXTqBNJR+2HLppHddzNpz7ImN6Rgn1c2p2eawEz8Wgjae8Bmyb36b4LkIMYeL1xaUjgima5+lIx86d999scPEqlNhKdS/w/aE+iaTcbQvgy0zmyUFO98KPBWk/eIhTBZYX2A8NoxsFC+d6pIVzo3bUr75LxWjRIb/LWMI9iW326QW1m364Hj5vBzOS5Yr18FOCTbxkVEYHPZ9X8b7iqE59AtmhJcs5lxTSZS03DLIUloFC9pxNavehtJGv7it7i8t2nrMw1nzUvvJ1TimSu6PNi3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A5mV+7evD0CmbiOs8GugWlozumwiUqkJm56WZD5Qv4s=; b=NKboty/XmSnpjlD2eR0eVH5znSbWBgJNCXUWz2KNVGpJDjFxSY1h2zXOCpmO7UY2AufMUcawCqDic8WOAlFvq1G8WRQ8moc1ytZbJul6PluakPOYRCVPDLVlhBBwUAQK4TYKqG4xus0O/Qab7qHQEyABpLy0tGj7GgvhZXeIHyc= From: George Dunlap To: Jan Beulich CC: Julien Grall , Bertrand Marquis , "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Stefano Stabellini Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Topic: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Index: AQHYb89PX1LGuEcm0kCKHXEgaA2yKq0vNXYAgAEjhQCAAJGbAIAAAxGAgAAFpgCAAC97AIAAc0MAgAC4OQCAARHVgIADyvaAgAABVgCAAALZAIAAAdqAgAACLACAAAPcAIAAB2IA Date: Mon, 30 May 2022 10:21:47 +0000 Message-ID: References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c37e4970-3b06-450f-b710-08da422633fe x-ms-traffictypediagnostic: BN7PR03MB3713:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GcNbCMr0TOxyPxlFGGUw73baSqYUpxHXitBt43JWBoTUO0m4becYx8dQlr5CE0E3uqLdIVDR0QVGA9iJqDk/4BzBqp9K3ujqAo8E1tIZJwbvK3axsQR4Nfv/HcSYEkBU5WFImN3l5d0XKNj5VUTXLElhJ/5VzPP2Zr9hXK9GJtjcnynYOyAioERUDQEQVs9odwwtswTN5Y3cef11QNBd04MDF9zaQtqHOWtZFXT1Ne1x/wXlbJC6ZgD+EPV2k5r1p5gG81tq+z9uXRgUb190dGuWCWMFWi9DnQSfT2efUoLt0AG5uB4Jb/6U+qh1g2x5kHGUFpIChRs2XnCdKdexjVB4a9Q41V3XsEUHFoOIJSszcEJ3qmNIUIrR+Km1SrWUNb4rojyj/mGn08vgdh8GWz22E6BZVStzakgX0m6uLknEOCQ9gzfSPPpRFLLgx9TXGXMmB1jINHaEtNsrYO60qZZSWLODJwgAw4MHeUbvOpHU422eAsheoZrYM0jFMShJBsT6hWXs6CxKpO/nVw/P24uxMoe3NFdQnmKiJcxmZf1LkmeZ+xBqw3V6MPVkrToZ1qk2kFUEp3hZNzoE4eTMDQ0HnMpTGIvSXivC84kAkAW2avCRcV1HJAbqf7cmhcoQl/kyfwz/Bl/eDuoasWQzXR+Ul/UvFxDYkrvNHqjjbWIalxOVKJFUeEH3Hl2+D+h/qH6E/KKZadEf3mosjJ/jqidIWhu8CaXYeX5RDe9co2dbhHVerlQ3jBkFoV+kWlY9 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38070700005)(86362001)(53546011)(316002)(186003)(2906002)(99936003)(33656002)(122000001)(54906003)(6916009)(6486002)(26005)(6512007)(8676002)(66446008)(6506007)(5660300002)(82960400001)(83380400001)(64756008)(36756003)(66946007)(4326008)(91956017)(8936002)(2616005)(76116006)(71200400001)(66476007)(38100700002)(66556008)(508600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T2xGMTlLM21wSkFlZzhkZitob3ZCSkc1dnBsZ1ZYZlVFZWdYTmF4REY2YnV0?= =?utf-8?B?b1VVb1B3N0MzYUgvcTBqMm5rTmR2cWRpdksxQVJORm8wa2Q5L1loamhPQjJU?= =?utf-8?B?N2pXbXlHdklFK0VKaktITTJWVFIzT0JtQmNLQzdacDgxL1V5QVdIMWxzTWlY?= =?utf-8?B?RW93dkhQTnNZd2pBWDlTTUFFZUcyaGtnYVZaVmo2cTkvbGNqV2tHMy9vL0RO?= =?utf-8?B?SWQ2b21DKzVNWjBtT1JCa3d2R3RlUnBFbk10QVVUb0VoMGlLdklLNTNqTkF5?= =?utf-8?B?VVJEL2xZYTQ3ZzlCREp4RjVidDBWZW9pZytjN0s2Y1pMTTlubFJNZjIzcmcy?= =?utf-8?B?a29YOVZvUWtUREV4aTkxMHRVWFR5S21QQkFDZ2xwWUdqOE1BVkltaGZ0cDV3?= =?utf-8?B?LzU2WVB0bUhGc0RjOU1UdmxHMGRBeVFMV2FET1p3c2dZSmN1SEtwMWU1ZnJt?= =?utf-8?B?UkRDOGp0MkQrbU9PVUpTRGt3VjN1NjZ1L1dEaWxsNEdpZEJROU1zSW4wWUl6?= =?utf-8?B?a0JIck8zQlE5NUVTMjU1RVpyWkl0eXloTm9vNFVUcWhsQWplS1VFbm9tK0gz?= =?utf-8?B?QnFGd2wvVXhyL29DUnJ6UlVaSnJzeEUwSU9nRDVMa3U1bGY5aFZDRUhRTmtu?= =?utf-8?B?L0NXQmZKTG14RXNzaEptRUVQY3ozWU5sMVF4Ky9Hdk9iaCtGNEVmQ1I5WmJU?= =?utf-8?B?V1pNbEM5YkVZUEVWcnlwSkFOaGxGbGUrTTFzRS8zNlNod2p5aUp6ZTlTTUN3?= =?utf-8?B?Q055cm1MK1NsVzhzQW4va2IxVUt0b1h3emRBeUl3clNudUFFaUdqTzF3bFJl?= =?utf-8?B?T3FUd3ExWmJic29MVTBzMm52dzRJY0IyTHhKNGtQMW9FSE50MHJ0ZHlDcjBV?= =?utf-8?B?TmZKRFIyYTdJaFFXYlFJaStDVEhrc3BFTnhRZDRyVGlOSTdmYVdoa0pKdFBS?= =?utf-8?B?UHc1cXJGVlltUys3SkRmcGd0ZGh0bjhaa0FNODRKaUZWc2NYZFhLWVI5enVW?= =?utf-8?B?OTloRU9ydDdUNmxMUFF6c0FWNzRhOTF6S0JRd2lyR1ZDQk9FZFU1SEZwdUt5?= =?utf-8?B?UUsvcnEydmdiQTMzalZwcnR1UTdlTWJEanZPSVdWNnB3aHpOZXdKNEVSVzBQ?= =?utf-8?B?ZHVPZHdxTzFpeHNBVEt5dEhyQ1hRQVcxejEzWmJPMDdRSHh5ekVqUkY2SFZE?= =?utf-8?B?THZzK3lkcEN6NTB5RXlPbzlXanRvNXl0dFVKQld2NXlHSUdoQWVhTFlTdVIw?= =?utf-8?B?bmlPbGtnaDBPdGx0SUVKRGM1YzN2NUs4cWw2UGJEZWlLSlpjMlhiMmU3dG8w?= =?utf-8?B?NUpNaVhrUkhWb2liVHpOTGl1WU8ycWNxVFJMMmF2bzRFTWNTYUdXdlhBVHBm?= =?utf-8?B?Wm9kRWRVQy94TWNNZVdSa3MyNnp6YUliOGZzK3BWQ0lXOXdQZHNJYjVxd09l?= =?utf-8?B?aUdnTTRFaFVCcUlGWkNwalo2VFptMzl5TGtEbHV5R0o0SWY0VXFIU3FhRkdX?= =?utf-8?B?WkJBMzUwdStNNis5SlIwSlV5WEtndit5RUNrbmJKbjQ1bUVTN2JnZ3FPMW5l?= =?utf-8?B?dGl1Q2Q2d3FNV0VpVXVVMEFOMmxCZllWaEI4dnUzK0pQQmpsd29pMENwRVdx?= =?utf-8?B?eTZiK2t2ZHhuUnN6WDNyc1ZKL1FKbFE4RW9aU3ptSVF6b3FtZ2lmTGFQbjBF?= =?utf-8?B?b1luZzZXR21wNUM4cmo4UWtaYUdCS3d4M1d6Y0hzZEZFbEV6ekJ4M1NNUDRC?= =?utf-8?B?MnFHWSsxcnB5MmNZOWYrV0lxZFJtQ0x1eEdNOEMrSVpoamtER2JOS1pZc2xp?= =?utf-8?B?THk0bDdUMkNPc0Zxd3JGak54cUJsN1dsRTRxNjFVR1NOMHQ2M1VXbzlRZXVu?= =?utf-8?B?WFpIRktOTVVPOWRMN0JKZGR3bjZTbTluUG9HSUJ1U0ZFa1dTM3lWSXppN0VS?= =?utf-8?B?dHpFaGg1NzU3SGlieS84cENKQkF5cUQ2SldVTFJIcEt3T0pFSHVyWitHUWk3?= =?utf-8?B?VUJ6a1BnOHVTQU8xajFiSjRVWGlXMDllUGxQZlVRVi9mWTVYc05nclpmeHNU?= =?utf-8?B?cG1wbEhxZ1RNL01pRWQwTTBJNVhHYjFXWVFZek1kTDZMMm93UVh1ZkxaYVBY?= =?utf-8?B?c3l2dDN2cUJZbHhwSVE0c1R4Y2hTbUlPQWFaeUd5Nmx5UkJjZ0RZZFNzb0Qv?= =?utf-8?B?c1lHTW54dHk2Tms5dkVIVjlsaktZeXpCM3J2Y0RoWDcwMldGajZuTm9XaTVa?= =?utf-8?B?MnlaV3hMcXFKbFdoOHNJVDhyeEw0cnZxTFZLcmxTT0FFdHc4RHlXRnRpR1B0?= =?utf-8?B?NllPODFLdFhCUWs3OUVLK3QxUDFhMVAvZDZKeFFkTnpPRHp4K3lkTlRrM05X?= =?utf-8?Q?DhB1WLYWabi8CXXg=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_FB269E6E-4FB3-4F9B-ACBD-53D20408D831"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37e4970-3b06-450f-b710-08da422633fe X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 10:21:47.4711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TE3hwkDAAJ3K8ET04Qyf0tG8biNRbqUUSPwlmmn7uAEyjhCBh9rjBjFXhJIfLj7WJfx+OUwsD7CPp/uU+3rvgrgxC8+j3sgfUlC4qM0xPCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3713 --Apple-Mail=_FB269E6E-4FB3-4F9B-ACBD-53D20408D831 Content-Type: multipart/alternative; boundary="Apple-Mail=_AD7493BB-1713-417D-BBD6-EC8A411028D9" --Apple-Mail=_AD7493BB-1713-417D-BBD6-EC8A411028D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 30 May 2022, at 10:55, Jan Beulich > wrote: >=20 > On 30.05.2022 11:41, Julien Grall wrote: >>=20 >>=20 >> On 30/05/2022 10:33, Jan Beulich wrote: >>> On 30.05.2022 11:27, Julien Grall wrote: >>>> Hi, >>>>=20 >>>> On 30/05/2022 10:16, Jan Beulich wrote: >>>>> On 30.05.2022 11:12, Julien Grall wrote: >>>>>> On 28/05/2022 00:16, Stefano Stabellini wrote: >>>>>>> """ >>>>>>> It is possible that in specific circumstances it is best not to = follow a >>>>>>> rule because it is not possible or because the alternative leads = to >>>>>>> better code quality. Those cases are called "deviations". They = are >>>>>>> permissible as long as they are documented, either as an in-code = comment >>>>>>> or as part of the commit message. Other documentation mechanisms = are >>>>>>=20 >>>>>> I would drop the "as part of the commit message" because it is a = lot >>>>>> more difficult to associate the deviation with a rationale (the = code may >>>>>> have been moved and you would need to go through the history). >>>>>=20 >>>>> But this was added in response to me pointing out that code = comments >>>>> aren't standardized yet as to their format. The alternative, as = said >>>>> before, would be to come up with a scheme first, before starting = to >>>>> mandate playing by certain of the rules (and hence requiring = deviations >>>>> to be documented). >>>>=20 >>>> I don't think this is necessary short term. It is easy to rework a >>>> comment after the fact. It is a lot more difficult to go through = the >>>> history and find the rationale. >>>=20 >>> We all know what "short term" may mean - we may remain in this mode = of >>> operation for an extended period of time. It'll potentially be quite = a >>> bit of churn to subsequently adjust all such comments which would >>> have accumulated, and - for not being standardized - can't easily be >>> grep-ed for. >>=20 >> Well... Scanner will likely point out the issues we deviate from. So = you >> we have an easy way to know where the comments need to be adjusted. >>=20 >>> By documenting things in the commit message the state of >>> the code base doesn't change, and we'll continue to rely on scanners >>> to locate sets of candidates for adjustment or deviation commentary. >>=20 >> The part I am missing how documenting the deviations in the commit >> message help... Can you clarify it? >=20 > I understood Stefano for this to merely be for the purpose of = justifying > the deviation (preempting review comments). Right, so at a very minimum, if we say =E2=80=9CThis is a rule now=E2=80=9D= , and a submitter wants a deviation from that rule, then the reviewer = needs to know the justification for the deviation. The commit message = is the obvious place for that. Obviously something *else* we might want is a more convenient way to = keep that rationale for the future, when we start to officially document = deviations. Given that the scanner will point out all the places where = deviations happen, I don=E2=80=99t think an unstructured comment with an = informal summary of the justification would be a problem =E2=80=94 it = seems like it would be a lot easier, when we start to officially = document deviations, to transform comments in the existing codebase, = than to search through the mailing lists and/or git commit history to = find the rationale (or try to work out unaided what the intent was). = But I don=E2=80=99t have strong opinions on the matter. -George --Apple-Mail=_AD7493BB-1713-417D-BBD6-EC8A411028D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 30 May 2022, at 10:55, Jan Beulich <jbeulich@suse.com> = wrote:

On 30.05.2022 11:41, Julien Grall wrote:


On 30/05/2022 10:33, Jan Beulich wrote:
On 30.05.2022 11:27, = Julien Grall wrote:
Hi,

On 30/05/2022 10:16, Jan = Beulich wrote:
On = 30.05.2022 11:12, Julien Grall wrote:
On 28/05/2022 00:16, Stefano Stabellini = wrote:
"""
It is possible that in specific circumstances it is best not = to follow a
rule because it is not possible or because the = alternative leads to
better code quality. Those cases are = called "deviations". They are
permissible as long as they = are documented, either as an in-code comment
or as part of = the commit message. Other documentation mechanisms are

I would drop the "as part of the = commit message" because it is a lot
more difficult to = associate the deviation with a rationale (the code may
have = been moved and you would need to go through the history).

But this was added in response to = me pointing out that code comments
aren't standardized yet = as to their format. The alternative, as said
before, would = be to come up with a scheme first, before starting to
mandate playing by certain of the rules (and hence requiring = deviations
to be documented).
I don't think this is necessary short term. It is easy to = rework a
comment after the fact. It is a lot more = difficult to go through the
history and find the = rationale.

We all know what = "short term" may mean - we may remain in this mode of
operation for an extended period of time. It'll potentially = be quite a
bit of churn to subsequently adjust all such = comments which would
have accumulated, and - for not being = standardized - can't easily be
grep-ed for.

Well... Scanner will likely point = out the issues we deviate from. So you 
we have an = easy way to know where the comments need to be adjusted.
By documenting things = in the commit message the state of
the code base doesn't = change, and we'll continue to rely on scanners
to locate = sets of candidates for adjustment or deviation commentary.

The part I am missing how = documenting the deviations in the commit 
message = help... Can you clarify it?

I understood Stefano for this to merely be for the purpose of = justifying
the deviation (preempting review comments).

Right, so at a very minimum, if we say =E2=80=9CThi= s is a rule now=E2=80=9D, and a submitter wants a deviation from that = rule, then the reviewer needs to know the justification for the = deviation.  The commit message is the obvious place for that.

Obviously something = *else* we might want is a more convenient way to keep that rationale for = the future, when we start to officially document deviations.  Given = that the scanner will point out all the places where deviations happen, = I don=E2=80=99t think an unstructured comment with an informal summary = of the justification would be a problem =E2=80=94 it seems like it would = be a lot easier, when we start to officially document deviations, to = transform comments in the existing codebase, than to search through the = mailing lists and/or git commit history to find the rationale (or try to = work out unaided what the intent was).  But I don=E2=80=99t have = strong opinions on the matter.

 -George
= --Apple-Mail=_AD7493BB-1713-417D-BBD6-EC8A411028D9-- --Apple-Mail=_FB269E6E-4FB3-4F9B-ACBD-53D20408D831 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmKUmroACgkQshXHp8eE G+2j5wf+Ob/aTHvDcDfIt7qrFhjtOfxCz551C0JzGWbA/hpxtZpQTweUCLJXsFVb nfMHsbIkZIwduQSsviX93t/CxJWdJSlIFXt0F4qeDC7zzSz/nVE8ZcjyCNJoAGw3 JioiDP9MbsYEXaqDa/9NDNAhMsnEPoWq1KYlL2hvp55T7wiI/7cVmrwZ3P6A7oh4 3xT/lwp0YVZNgpLr9OMziKRYjeeFKG7WhFcbfDdiEG23spjQ8O5XtPkyGL96+n/N x4/gs0UJWPXg+KSvWigMpUAoXNvmpjGaq/kbXUS+/j8l1+ONhRJ67N5qUWFGEfsN qEuNNdmHmLHb8Nrnn/qVn4JXSOVfgA== =1MZs -----END PGP SIGNATURE----- --Apple-Mail=_FB269E6E-4FB3-4F9B-ACBD-53D20408D831-- From xen-devel-bounces@lists.xenproject.org Mon May 30 10:50:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 10:50:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338487.563262 (Exim 4.92) (envelope-from ) id 1nvcyP-0000SN-6o; Mon, 30 May 2022 10:50:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338487.563262; Mon, 30 May 2022 10:50:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcyP-0000SG-2i; Mon, 30 May 2022 10:50:09 +0000 Received: by outflank-mailman (input) for mailman id 338487; Mon, 30 May 2022 10:50:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvcyN-0000HL-Bk for xen-devel@lists.xenproject.org; Mon, 30 May 2022 10:50:07 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 426ddfe3-e006-11ec-837f-e5687231ffcc; Mon, 30 May 2022 12:50:03 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-zfis8wzPNaO_UIwOyWzctg-1; Mon, 30 May 2022 12:50:02 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB8019.eurprd04.prod.outlook.com (2603:10a6:20b:24b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 10:50:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 10:50:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 426ddfe3-e006-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653907803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/FKC5hZklglj8jT5R2319imn7GAD2On8rEgmbXVx6ac=; b=Z5uBCHvAbrMLAnIUDpkGbfjHAIsIyzza6QYsMKKT5THpS/IwvgHzUa2m8xQYfCgo+mFYzp pvbx7b4dYg9dGWBLET/qrIoYvbZq1ujmlgmGRU2tZdExYObqY2OEgG+kf0Stsrf+kHkASK LagIOlHvzSy9nZFtOj58XhzRqD271TY= X-MC-Unique: zfis8wzPNaO_UIwOyWzctg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYHWgBHhVuByqnopQ11POKU38Rf/7bauHuwjzGJWyZaKjaE7X+A/jhEY4a7YweuJusHBs3Qf/3nMwxd6lUEd5WrlVwO3yuLxC/9XJRQyv/mcwHJW0/vwuvTMbhx1h09RFNhP/0u0Ttn9kMeVF5+0g9V0ezgDb1VxTGdEoDYjyZcfNUEL68EWEZky6r80pK6K3JGpJGTEn38WlxoZ2WqgOezVn1HqllIGuZjWDVAlFRsRQ7GmqGprmlHgZiao5vHQg5FxdGF8JBUxGFdjoFineJ0LnjzdWdX6HVRBmogc8KdjSZ8Dif2Qg5TqMYB9ql3jboIUzw+SQ1xrkHw0FKFMPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/FKC5hZklglj8jT5R2319imn7GAD2On8rEgmbXVx6ac=; b=a0ZI/WzGG1d4rYHXEXM1+3I3jC9cAzg9NEbBI93V4PBsIYNPe23AxjsbbT+3YYsnTpFONj+NOOUqcUhQqgOPha6ulOgc9VM5HpmHrLkYO6IK4Ib+ZVuSuuog3pVSPf+sWWblJ7+SyQxZ3O/dkrXoT674Uxb8KQA5dJeV74SA39gHSvfXh3L2a8Kb8IHLpNxtMn66jUimnDQAeZJno8yv7JJ5PviGNd176/3GPv4OFMkxR9ftYDJOpuI3R0oytZq3EApfKV4D7HBStQx3tY3Aj1i8Xa7Gk83q2xixakiBToX1nyhCSyDPAem4BTEvbFmKseAJA48pG1xMk5PHGonUrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> Date: Mon, 30 May 2022 12:49:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [linux-linus test] 170771: regressions - FAIL Content-Language: en-US To: Juergen Gross References: Cc: osstest service owner , xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:20b:488::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea09d61c-0fcb-49e7-6554-08da422a24ed X-MS-TrafficTypeDiagnostic: AM8PR04MB8019:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3HwYsxEgnzfhOcNHalUUkSgyPOQYXMBVgIckC03rsqzrHv/hWrb8cf57SVCmLSEmmPlXgwFQgF3eKnhp3rgZNheKUnDSHPTOJcAlSamv0yBzHUTfA9GYw3tay07V4qX1kVYQ2bzTH3cmfd1j9c2a6+ycn4wREWvQH8iUCxB1EvQNnH/NBRDx381uB+UE8hzRfsQ7CC/VYfEgBswjE557e9TK821jkKnefBDLdlN4Nyv7QlFHGpVlwmLNx2oSH/2XjlKU+TXOh+Xz6IKpQWU0H/yo+H7QN9yQ9E8iYDgd4e5LhZQyIzQBieZUzrrpaoBxugvCM+FYYYdfEkYkor9g5IBYSeE9znoH+ocwOuKiI8R8I5Ntd8BRx/TSKUywDxzT5/e7VRu/TmB9dfL7Okhs5OiCa/lCJs/j5opONoLEsqvYQqIy2KK8IEea7j0wY2WfSKEPSIS5N5Z65fBzeFfLOlrqnXOxVFySn20+8ezDgdHBL/byU8vaFvGIz8nzCzSLcGhn6NeTu+ga+MPuGrQyxT08E18s56b1T51SjkwDOI0FpiDWcR2G8ikWeNATcWA8wWSPxL2hBsIloRvpBEJQ9qE6tvYw8Hqdrc1teVOQTffHhJPrO9EHa7813NjAYECvo2+CyZSLxxLEYv1Fdf12KBZ6RQkMJf+04eDjg9cIZ2ok97MgMhmbqIx0OdAvg9M4VgE7huJJSIitFfRIFTW6NTHFZ/Hc1+sZ4sbkl+okkoomD/EekwofGPZGDK61jLXuZO7NJvt+yNGerEcWXpO+S5a+AL17MkUlqJ4RTJxDoIs4KhRfwHlN7fw9IYUSogXBoV32HEtrXjkOTJI+ZJr6DQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(36756003)(508600001)(31696002)(66946007)(66476007)(186003)(966005)(83380400001)(4326008)(2616005)(86362001)(2906002)(38100700002)(6862004)(6512007)(26005)(6506007)(31686004)(8936002)(53546011)(6486002)(5660300002)(316002)(6636002)(37006003)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmVlZTNFL1M1WjFWTlpEWDlzb3JSVnZVQXBwQmNCQ0VWeGRwN1RGbzBmWjA3?= =?utf-8?B?S09yeG5uOEhYc3hrV3ZtNHYzbGRVVFMzRWRSajQwSkZ1bkYzVnlLL001dE9P?= =?utf-8?B?MlZtSnJ3ZmZpVWJVU2xORjZIU2t1TXdYcnBqNWpzZGZDblAxdWtIVndlUzlI?= =?utf-8?B?Qko2L09qeW1aM1d5S2dxcTQ2MUhMcDZZMHlpMnEvWVVCcy9GdUVENGJwc09I?= =?utf-8?B?VnJLSmFzMThKTG5TUjhwSUdjMGE4WjQ0cGRmeS9Gc0N6eFhMd3pnQTNhM2FK?= =?utf-8?B?RGV3NjVmTGxOVDZySFpISVVFTS9jbTNZdnczUk5hZysySEdxU0drbzBzMG1S?= =?utf-8?B?U3dSTXZtUDZsam5heCsvTFZYZURWR3llWnBOVGd5ZG05Tit5V2FiYWUrR0w5?= =?utf-8?B?U3Z5SGpiZ1RFcmdPNElub2V0cEtXK0huVk1WUWRUc1FBY0RpSnB4eElSeTFm?= =?utf-8?B?VFlJWDdpVUhpR2cvYW9lLy8vU3l3TnY2MFlKNU5na29SNHZaOTQ2UWphOFFa?= =?utf-8?B?UGhpVVNrNEJlYWhMaER5TUxOMlc2MERSWVRYNVlUbTUyUm11b2hVYTdvc1Fj?= =?utf-8?B?TTVHM0tWNHdWTTVtRnpPZGJ3eG5mUS84U3AxNzV1Yjkrc3RabXZuaDFzeWVR?= =?utf-8?B?SWRiYi9GMFpCOU8xTTBRQ3dyeUFiZG1HRzBJclM4OTZhSUQxenJCNkJmdHFp?= =?utf-8?B?RmhhdnIwU21VdlY5OEhoT0VvdGtQOWw3disvMHZiNFlEeWhwYXJOVDVJZmJ0?= =?utf-8?B?RHBjVGNQOVhSUmtPNENkL3Y2bDlQQ01wUzJYZnFsTVJjZ3JQOEFKQ0FiWjdQ?= =?utf-8?B?bEpHWnR1RjJtSlo2Uy9WRDVXZTM0U0ZSV1N6aUlnNDUwWm5zNVR1bVFlK0Rh?= =?utf-8?B?WW9HM2xZeDVXSXU5MHdGQ09Qd1ZEUDZRSU5EZzg5UG9ZelNnZitOTzNuRXRR?= =?utf-8?B?NGlyRnJNUnFIcXl4Si9aM0xKTnA3cnI2Yk1QVCtPTnA3Y3RJSkUyVmcrSkRO?= =?utf-8?B?QjJWNSs2bzZaSmZjMEwrUGQ3TC9ZYStMU0pmRmpaaGhoRFRWcDJta1dScENl?= =?utf-8?B?K3NHQXVMdnV6VUFaWXlPWmpzb0JZVmlnTWxHVHhsSzUzcEFNTk84QWtTR0gr?= =?utf-8?B?TTNydFJaWURWbGptTHl2SDJudUV5YVErSTRWbTZQcHIzK3Ivblpob2h5ZGVo?= =?utf-8?B?bGExRi9TWE12WW5hYnJXdlAzZzlVcmZLbUZBK0RxMWF4amlJc1RWbmQwZzdG?= =?utf-8?B?aVJaRDF0T0hZYVFKNGFFWS9Pd3NOVjlDSzRsZkhxVUs4TVplYXN2YWNJbklJ?= =?utf-8?B?RmNaWlljbzRvWEVwQzZXMG1QL0k3bG5YS251bGZnLzNPWFpBcmtrTERqOWRm?= =?utf-8?B?N0d4bHBScnZIMWxCN3gxa0dkZkt4ck40Smt3c3NuQkdGcVRqbUVmQ3JOZjlH?= =?utf-8?B?OUc5WUl6RUNGM1NyV1FSQUtLeFFRYy9sVGY5enUzWVNtNklOMU1yZjhXb0J2?= =?utf-8?B?YklOVjVMczdqbHJCVjVuMWxSR2VQbEJSL2srVk04RTZiMDg2cU1sVDVNUk1P?= =?utf-8?B?ZG9vdDhZaGliVG9ldXNtU0x1eVNubU1tRGw2bFNvQ0ZnVWl3VnZuQnFLclc1?= =?utf-8?B?aG1CZHV6elRNUVo5YkhLN1p4WE5VRGNGM3gzMldZZUxjRTV0b0ZXeXlwR0F3?= =?utf-8?B?S1NlK25ZLzQremo0NVNrNlIrc1M3VTl1cTdHV0ZSWThHTUFiOE5hV0pyb3Ar?= =?utf-8?B?QVJ4Y0tZQmxUTVVNdXNsbDdZclVVb3drOHZWdUM4UG5XOHhkNXdlaFZDTTIx?= =?utf-8?B?MTEweWFFWWFuSVNYbERMc2NQUzgwTzhWcThvanlhVklGNEE3bnlMZ3BvZmpY?= =?utf-8?B?TzFMOTNHNlF6b1pUK2diWXNXV3FnZVVoaDR5dER2cThwaGhSeE8zNC9KNkow?= =?utf-8?B?L1cwNkVUTlNkNTlqVEZkdCthSUNJL0U0VEh6QkdmbzlFcWg3OW9IWG9raERn?= =?utf-8?B?VTUraHY5MnZiVXVZRlExUkwyUmQyM1lOSDhnQldEaFZjVHBxS1dNbmM5Tk5V?= =?utf-8?B?UXRJSU9uN1FEam5CeGxmaWtSS0x4WWNIU0haRW1rVWJleE1ra1prRkpQajQv?= =?utf-8?B?UkpidXVMNEM1bGswNGVkSFNHWXVUZzl4UUlQMjYyd3hwY3pZS0MvbDc4YmZS?= =?utf-8?B?cWRXMWFPR1UvZzdhVmpqVXc2WENRa2h6UHlyYmdlZUNCTFlockYyVkk0ZHJL?= =?utf-8?B?bmJzTnVuOE9sLzhxQnJHS3BWT2JtcDdxcVRPblFNNVZqQVJwTlJHMURzOHJn?= =?utf-8?B?ZTR6SUJVSVlDRzh3QlIzQXdoRThhMEJrNWhwSnF0cW9QQ1RMdW1qQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea09d61c-0fcb-49e7-6554-08da422a24ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 10:50:00.3975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +/tgBXPXZr0WJU+Z0jesl0IOemw6f/yvvrQemJ3AhqCA+1cC6Gr1/1hZ4HKDGTusiq4rncMcAAfZVZDgyW6mvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8019 On 30.05.2022 11:03, osstest service owner wrote: > flight 170771 linux-linus real [real] > http://logs.test-lab.xenproject.org/osstest/logs/170771/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 > test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 This vif vif-1-0 vif1.0: Asked for 0 slots but exceeds this limit vif vif-1-0 vif1.0: fatal error; disabling device to me looks like a regression in netfront, considering that there don't look to be any relevant netback changes. I have to admit though that all three recent netfront commits don't have an obvious connection to the slot count going wrong. Or wait - isn't this a result of 6fac592cca60 ("xen: update ring.h") touching only netfront, when netback also has a use of RING_HAS_UNCONSUMED_REQUESTS() (in xenvif_tx_build_gops()) which wants an actual count, not just a boolean? Jan > test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 > test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 > test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 > test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 > test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 > test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 > test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 > test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 > test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 > test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 > test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 > test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 > test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 > test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 > test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 > test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 > test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 > test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 > test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 > test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 > test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 > test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 > test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 > test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 > test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 > test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 > test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 > > Regressions which are regarded as allowable (not blocking): > test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 > test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 > > Tests which did not succeed, but are not blocking: > test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 > test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 > test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 > test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 > > version targeted for testing: > linux b00ed48bb0a7c295facf9036135a573a5cdbe7de > baseline version: > linux d6ecaa0024485effd065124fe774de2e22095f2d > > Last test of basis 170714 2022-05-24 03:27:44 Z 6 days > Failing since 170716 2022-05-24 11:12:06 Z 5 days 17 attempts > Testing same since 170771 2022-05-30 00:40:40 Z 0 days 1 attempts > > ------------------------------------------------------------ > 1928 people touched revisions under test, > not listing them all > > jobs: > build-amd64-xsm pass > build-arm64-xsm pass > build-i386-xsm pass > build-amd64 pass > build-arm64 pass > build-armhf pass > build-i386 pass > build-amd64-libvirt pass > build-arm64-libvirt pass > build-armhf-libvirt pass > build-i386-libvirt pass > build-amd64-pvops pass > build-arm64-pvops pass > build-armhf-pvops pass > build-i386-pvops pass > test-amd64-amd64-xl fail > test-amd64-coresched-amd64-xl fail > test-arm64-arm64-xl fail > test-armhf-armhf-xl fail > test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail > test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail > test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail > test-amd64-amd64-libvirt-xsm fail > test-arm64-arm64-libvirt-xsm fail > test-amd64-amd64-xl-xsm fail > test-arm64-arm64-xl-xsm fail > test-amd64-amd64-qemuu-nested-amd fail > test-amd64-amd64-xl-pvhv2-amd fail > test-amd64-amd64-dom0pvh-xl-amd fail > test-amd64-amd64-xl-qemut-debianhvm-amd64 fail > test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail > test-amd64-amd64-freebsd11-amd64 fail > test-amd64-amd64-freebsd12-amd64 fail > test-amd64-amd64-xl-qemuu-ovmf-amd64 fail > test-amd64-amd64-xl-qemut-win7-amd64 fail > test-amd64-amd64-xl-qemuu-win7-amd64 fail > test-amd64-amd64-xl-qemut-ws16-amd64 fail > test-amd64-amd64-xl-qemuu-ws16-amd64 fail > test-armhf-armhf-xl-arndale fail > test-amd64-amd64-examine-bios fail > test-amd64-amd64-xl-credit1 fail > test-arm64-arm64-xl-credit1 fail > test-armhf-armhf-xl-credit1 fail > test-amd64-amd64-xl-credit2 fail > test-arm64-arm64-xl-credit2 fail > test-armhf-armhf-xl-credit2 fail > test-armhf-armhf-xl-cubietruck fail > test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail > test-amd64-amd64-examine fail > test-arm64-arm64-examine fail > test-armhf-armhf-examine pass > test-amd64-amd64-qemuu-nested-intel fail > test-amd64-amd64-xl-pvhv2-intel fail > test-amd64-amd64-dom0pvh-xl-intel fail > test-amd64-amd64-libvirt fail > test-armhf-armhf-libvirt fail > test-amd64-amd64-xl-multivcpu fail > test-armhf-armhf-xl-multivcpu fail > test-amd64-amd64-pair fail > test-amd64-amd64-libvirt-pair fail > test-amd64-amd64-xl-pvshim fail > test-amd64-amd64-pygrub fail > test-amd64-amd64-libvirt-qcow2 fail > test-armhf-armhf-libvirt-qcow2 fail > test-amd64-amd64-libvirt-raw fail > test-arm64-arm64-libvirt-raw fail > test-armhf-armhf-libvirt-raw fail > test-amd64-amd64-xl-rtds fail > test-armhf-armhf-xl-rtds fail > test-arm64-arm64-xl-seattle fail > test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail > test-amd64-amd64-xl-shadow fail > test-arm64-arm64-xl-thunderx fail > test-amd64-amd64-examine-uefi pass > test-amd64-amd64-xl-vhd fail > test-arm64-arm64-xl-vhd fail > test-armhf-armhf-xl-vhd fail > > > ------------------------------------------------------------ > sg-report-flight on osstest.test-lab.xenproject.org > logs: /home/logs/logs > images: /home/logs/images > > Logs, config files, etc. are available at > http://logs.test-lab.xenproject.org/osstest/logs > > Explanation of these reports, and of osstest in general, is at > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master > > Test harness code can be found at > http://xenbits.xen.org/gitweb?p=osstest.git;a=summary > > > Not pushing. > > (No revision log; it would be 213846 lines long.) > From xen-devel-bounces@lists.xenproject.org Mon May 30 10:54:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 10:54:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338497.563273 (Exim 4.92) (envelope-from ) id 1nvd2i-0001Az-Te; Mon, 30 May 2022 10:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338497.563273; Mon, 30 May 2022 10:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvd2i-0001As-Qq; Mon, 30 May 2022 10:54:36 +0000 Received: by outflank-mailman (input) for mailman id 338497; Mon, 30 May 2022 10:54:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvd2i-0001Am-6E for xen-devel@lists.xenproject.org; Mon, 30 May 2022 10:54:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e41eb70f-e006-11ec-837f-e5687231ffcc; Mon, 30 May 2022 12:54:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8CD8B21B12; Mon, 30 May 2022 10:54:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 667B013AFD; Mon, 30 May 2022 10:54:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bdPQFmqilGKzXwAAMHmgww (envelope-from ); Mon, 30 May 2022 10:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e41eb70f-e006-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653908074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0pGbku6Z22PBIRRwNTCIH0ON8nrpMgI5zWTU/a6LxSI=; b=Ivc5WJ1luFMOWmgq6KIFloSAawotkUmGbP/FNdre/L3L/KZ4QFgDo9vo1M8zp8TQTlUm7k pF9Nui5nL0Q+eEVUBIjR6tRd0QiqZxjKHOyUfHI2GrZDNCYZS4Z92SDUcMySXpcJrNeg0h dnpVAcrqFMg5wqnsZL6ZXApPxeXC+v0= Message-ID: <7041fed6-a0ea-e30e-0292-da0ecf1173c4@suse.com> Date: Mon, 30 May 2022 12:54:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [linux-linus test] 170771: regressions - FAIL Content-Language: en-US To: Jan Beulich Cc: osstest service owner , xen-devel@lists.xenproject.org References: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> From: Juergen Gross In-Reply-To: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1UtL3ACysgQp0M5J2JjS7igO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1UtL3ACysgQp0M5J2JjS7igO Content-Type: multipart/mixed; boundary="------------87csPgSfXQrD0q0MJwCVQOp9"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: osstest service owner , xen-devel@lists.xenproject.org Message-ID: <7041fed6-a0ea-e30e-0292-da0ecf1173c4@suse.com> Subject: Re: [linux-linus test] 170771: regressions - FAIL References: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> In-Reply-To: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> --------------87csPgSfXQrD0q0MJwCVQOp9 Content-Type: multipart/mixed; boundary="------------XkevVCvjE9qX4X2Tj3z0HA0C" --------------XkevVCvjE9qX4X2Tj3z0HA0C Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDUuMjIgMTI6NDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAzMC4wNS4yMDIy IDExOjAzLCBvc3N0ZXN0IHNlcnZpY2Ugb3duZXIgd3JvdGU6DQo+PiBmbGlnaHQgMTcwNzcx IGxpbnV4LWxpbnVzIHJlYWwgW3JlYWxdDQo+PiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5w cm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTcwNzcxLw0KPj4NCj4+IFJlZ3Jlc3Npb25zIDot KA0KPj4NCj4+IFRlc3RzIHdoaWNoIGRpZCBub3Qgc3VjY2VlZCBhbmQgYXJlIGJsb2NraW5n LA0KPj4gaW5jbHVkaW5nIHRlc3RzIHdoaWNoIGNvdWxkIG5vdCBiZSBydW46DQo+PiAgIHRl c3QtYW1kNjQtYW1kNjQtZG9tMHB2aC14bC1hbWQgMTQgZ3Vlc3Qtc3RhcnQgICAgICAgICAg IGZhaWwgUkVHUi4gdnMuIDE3MDcxNA0KPj4gICB0ZXN0LWFtZDY0LWFtZDY0LWRvbTBwdmgt eGwtaW50ZWwgMTQgZ3Vlc3Qtc3RhcnQgICAgICAgICBmYWlsIFJFR1IuIHZzLiAxNzA3MTQN Cj4+ICAgdGVzdC1hbWQ2NC1hbWQ2NC1saWJ2aXJ0LXFjb3cyICA4IHhlbi1ib290ICAgICAg ICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcwNzE0DQo+PiAgIHRlc3QtYW1kNjQtYW1kNjQt bGlidmlydCAgICAgIDggeGVuLWJvb3QgICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMu IDE3MDcxNA0KPj4gICB0ZXN0LWFtZDY0LWFtZDY0LWxpYnZpcnQtcmF3ICA4IHhlbi1ib290 ICAgICAgICAgICAgICAgICBmYWlsIFJFR1IuIHZzLiAxNzA3MTQNCj4+ICAgdGVzdC1hcm02 NC1hcm02NC14bC1zZWF0dGxlICAgOCB4ZW4tYm9vdCAgICAgICAgICAgICAgICAgZmFpbCBS RUdSLiB2cy4gMTcwNzE0DQo+PiAgIHRlc3QtYW1kNjQtYW1kNjQteGwtcHZodjItaW50ZWwg MTQgZ3Vlc3Qtc3RhcnQgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MDcxNA0KPj4gICB0 ZXN0LWFtZDY0LWFtZDY0LXhsICAgICAgICAgIDE0IGd1ZXN0LXN0YXJ0ICAgICAgICAgICAg ICBmYWlsIFJFR1IuIHZzLiAxNzA3MTQNCj4gDQo+IFRoaXMNCj4gDQo+IHZpZiB2aWYtMS0w IHZpZjEuMDogQXNrZWQgZm9yIDAgc2xvdHMgYnV0IGV4Y2VlZHMgdGhpcyBsaW1pdA0KPiB2 aWYgdmlmLTEtMCB2aWYxLjA6IGZhdGFsIGVycm9yOyBkaXNhYmxpbmcgZGV2aWNlDQo+IA0K PiB0byBtZSBsb29rcyBsaWtlIGEgcmVncmVzc2lvbiBpbiBuZXRmcm9udCwgY29uc2lkZXJp bmcgdGhhdCB0aGVyZQ0KPiBkb24ndCBsb29rIHRvIGJlIGFueSByZWxldmFudCBuZXRiYWNr IGNoYW5nZXMuIEkgaGF2ZSB0byBhZG1pdA0KPiB0aG91Z2ggdGhhdCBhbGwgdGhyZWUgcmVj ZW50IG5ldGZyb250IGNvbW1pdHMgZG9uJ3QgaGF2ZSBhbg0KPiBvYnZpb3VzIGNvbm5lY3Rp b24gdG8gdGhlIHNsb3QgY291bnQgZ29pbmcgd3JvbmcuIE9yIHdhaXQgLSBpc24ndA0KPiB0 aGlzIGEgcmVzdWx0IG9mIDZmYWM1OTJjY2E2MCAoInhlbjogdXBkYXRlIHJpbmcuaCIpIHRv dWNoaW5nDQo+IG9ubHkgbmV0ZnJvbnQsIHdoZW4gbmV0YmFjayBhbHNvIGhhcyBhIHVzZSBv Zg0KPiBSSU5HX0hBU19VTkNPTlNVTUVEX1JFUVVFU1RTKCkgKGluIHhlbnZpZl90eF9idWls ZF9nb3BzKCkpIHdoaWNoDQo+IHdhbnRzIGFuIGFjdHVhbCBjb3VudCwgbm90IGp1c3QgYSBi b29sZWFuPw0KDQpPaCwgaW5kZWVkIQ0KDQpUaGFua3MgZm9yIGlkZW50aWZ5aW5nIHRoZSBw cm9ibGVtLg0KDQpJbiBjYXNlIHlvdSBkb24ndCBoYXZlIGEgcGF0Y2ggcmVhZHkgYWxyZWFk eSwgSSdsbCBiZSB3cml0aW5nIG9uZSBsYXRlcg0KdG9kYXkuDQoNCg0KSnVlcmdlbg0K --------------XkevVCvjE9qX4X2Tj3z0HA0C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------XkevVCvjE9qX4X2Tj3z0HA0C-- --------------87csPgSfXQrD0q0MJwCVQOp9-- --------------1UtL3ACysgQp0M5J2JjS7igO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKUomkFAwAAAAAACgkQsN6d1ii/Ey/T 3wf/ZbTdGPIjJQ+/QOtAXDMVnBEeus9H2twTQsuLsF35odSxXY/ARK3iarYHz3JKTUz6vsVN2XTm h6tl7Zb0DpEDiCUsw19LmktEv9W6kgA0la58UcO4+ZGfO+gP5ipMd4ZWuY+cmebZXU9uFPbzwEL5 iMFA4igMOPUiY3vng+szUQvwNsB4KKdsuiXWItfQS3YJSU7wWuJ1cUmlpiMR4y4mQeLqLVidzSCQ xzlyyv/Y8tpK1tfsBdvXhZPg+QW9XOVaY+wUa+j2hefj6fCtc/h8eEyo0+9561AJh06Ztlw4cCNm pHKX/wL7mndi0/Ht/Kmpc7jaZhjojzgx16FOre7xTg== =SAHP -----END PGP SIGNATURE----- --------------1UtL3ACysgQp0M5J2JjS7igO-- From xen-devel-bounces@lists.xenproject.org Mon May 30 11:02:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 11:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338506.563284 (Exim 4.92) (envelope-from ) id 1nvdAC-0002dj-OB; Mon, 30 May 2022 11:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338506.563284; Mon, 30 May 2022 11:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdAC-0002dc-L5; Mon, 30 May 2022 11:02:20 +0000 Received: by outflank-mailman (input) for mailman id 338506; Mon, 30 May 2022 11:02:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdAB-0002dW-JK for xen-devel@lists.xenproject.org; Mon, 30 May 2022 11:02:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8572cd5-e007-11ec-837f-e5687231ffcc; Mon, 30 May 2022 13:02:18 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-45-OYtXvzNeMfit8n1L1YCkgA-1; Mon, 30 May 2022 13:02:17 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6682.eurprd04.prod.outlook.com (2603:10a6:10:10c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Mon, 30 May 2022 11:02:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 11:02:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8572cd5-e007-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653908538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NH+F8tSCrSr3l0tFHnWetIpHjPscCt/xjHBzgzrq8vk=; b=BEELIbRLArpJEmDF0zf2vhtFYKzJ5SGvSs3pjlh5r2e0Qf6YdKLOQ8/TT5NY6HbN6EBn++ 22Nqe3Fs2Rk6uMjVlEsgqoDJxR9e4X5pxXctLmLdzyMzjWnF7wX5Hfhum7aF8CCEqpKb90 xoimZPhCk4KYAZLHWv8yHgrL26cYGbE= X-MC-Unique: OYtXvzNeMfit8n1L1YCkgA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMXBW0ED4NBWiKrFRDd9x9iEtuVVmpzzAwvJtSGwnY9g8E95/dLkg9RWwEwiWtwuLOB1GtfV8cg8+2r/R+t4OJyyZb+QKZbDDAPKj1Hd78vFy/zMBlSdrAbLyUpDd/fw/kSEfRaCAOfXOauYreVvzhpNzGTDBnxOokUgN2ncZz0YOUzDJ1AyeA2/4WETlBkvtrw7EQ+ynP8rg8qe2r4pArk3iR2LumVbLHaa5IoVp14xDnNXG/F3eVeEaLM32/r+14ri70shb+7IAvbG/fo2eONLjLgnXepMPg7OIQCxUg2EsvItYn0r94khaRlcIFkYE3Yoy6T/G3wik0Wni6XARw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NH+F8tSCrSr3l0tFHnWetIpHjPscCt/xjHBzgzrq8vk=; b=SRt+T7pJ3965PVTZhU9tV3BafgTVtJszWi/ziit3OgKesYGbp71Be4pcsiGFU6AKQ5MlQ0pWmw66KKlLCRCAo87aL2kVvnxvbFRHpg7nmvHSVyQpCpJG7Dj92GCznKWmMwh7Yn7aIddzB5L0cHy3y+mKNNphVT/oy5SzJLJ2+D0swBszkyVeDIrTwUhOJHzhTu9ncwWvcJTSkLF8bTTQa53Pd9SW7qqg9axyiaGNy+GCMOBRqoSlCfuSUVF7V7AaRcedQH3xeTjRzXnpRRXRhIZNJaD1VikuCOH2MS7wWkI5oFJcIkoBfuUujPoUP2YGnqVjljGz2qmVUr1Vko6UBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <23ab8323-298a-3649-c484-918c9de148c9@suse.com> Date: Mon, 30 May 2022 13:02:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [linux-linus test] 170771: regressions - FAIL Content-Language: en-US From: Jan Beulich To: osstest service owner Cc: xen-devel@lists.xenproject.org, Juergen Gross References: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> In-Reply-To: <8fb558c5-bc9c-af86-d425-974b8c45768f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0015.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d0416da-4448-4a69-0617-08da422bdb2e X-MS-TrafficTypeDiagnostic: DB8PR04MB6682:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ys2mT4iLmmrCI4LowbCyHZA8mhHhgbjYTc6BOqtKgHqpSwb7vRB9rdhjNdNZbRQ0OhSMub9laANZZyyZL0ea+4ldnO8rlR+WIzMLE00cZnIgbFc5y1L3vXPRy3VF+/TgXpIG+O0mhPrkeZLdWfqF32gUnt2CSK+eKfwK/jnIBHt7eiXbYsRGeZnz7UPTt9Lr9kKAatE1AkV7SWPjc1hX6E5VrUSVAu2jug3dz0oAABq94zTR/1w1VljkWf/TaIIW/dx6MKIDpsvW/BpM5aYW16gHkI1udQQKJJBMdyqYLdSwaWkVdzajsMVYTkEbjJYreT9G9RnV/q+MXPfSXBzCcqTm42Fc6yng5Bc+5tWiD06fkUtffgtZFolu1u8KcpwYM1qTKwMKrAF/G1vjvlf+Px6Q0d4LX+ehujmTrVsfUBWJfoYxfpqGj9bgAmil6orsSwM0m4iibc9OKSje8QQlsPJ0FvcmYKVzqq1ZdcQqB+I9LhVT0QkVSaNB3PWKehEzCVRE9XF2T6B9SwVKoILPRhjw2CfK116iig5tUidf+GdijLOj4pFGWalA5vDRMh7QEl2VdR5kd1vFp6G59PP2esHFI9k7FVhgrSMQYb703Xniv6H+kgqlu962hQgSaXGYrdSAkdtT9Scly/Dkihof3QO2Mn9a4auxX6/+IcWaL4CruELAqUXp1orhOA9CtQBTYp7h9JF/PhwLw2evFR3F6Y31XfAUoscMjbGf1aZ4qwT5Ksyh22SacoLCROZdlly6MTPTH8zlwHBf7aicCmLe5Sms9n3TLsNT6kkoqArzuxdh2inQ2l2dhSWvTkAMka7FPj50HdYOQRPfGz/JIEN3cA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(83380400001)(66556008)(66476007)(38100700002)(186003)(107886003)(316002)(8676002)(4326008)(66946007)(6916009)(36756003)(31686004)(2906002)(86362001)(31696002)(508600001)(6512007)(6506007)(53546011)(26005)(6486002)(966005)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bllXRmQySUpvVlUwaTIrVGJodVliTmdjd3N2azM2VWMyR25keTNCNXpFcnRl?= =?utf-8?B?MTd2K01uM2YrS2I4TXRqQldKakNVM2NpMDhVcGw5ZFhPVi9nZS9JZGc5RnRw?= =?utf-8?B?T0paYW8zRFpWUFpNbDF2TkptNnE3VUNUL0VuK3c4aFVaN2Y5UnRRbHV4QXJU?= =?utf-8?B?TExhbnEzSjVtZTJxdml6U1VMZ3VTNzZyWlo2Zy9ubFRMWTVqQ3BhL2dqVFV3?= =?utf-8?B?UWV6RXR4QWxtY3RZdUJrUkRFTXg4U3Z2QzZxc3Z5b3NoYXFnVTFXdS81TnFN?= =?utf-8?B?a1RoMHlvNDBwRnJBNWppeWFJVjVpcE9oUFBVdFFLR1k2T2FlWmM3RTBMMWp0?= =?utf-8?B?T1RtdmNRUHRNWEhqdFNwSDZNTmVHdkZKdzlhVEFKc2duT2xya2t0djFGV0VO?= =?utf-8?B?blNQMjV4QWJ4Z0RDQ0dRQnluN3VBMGZjYTJoK1BFV0FWRlptZFFHc3E0MzhZ?= =?utf-8?B?eGE5R0xHQTBpTi9WUlJpdTJWUkkxZy9rYmJRWDduRHNVeXZ0aXpsaE1tbnA0?= =?utf-8?B?T0NtaERuMzJ1bWdJNzRQMmYxc0hMY2ZGaWkxaHpqY3dWb0s0dysrNm10T0hN?= =?utf-8?B?eWV2b1M0dkhNYXJIOGFmQ29tYm54RHhvZFB2UExnZ2podlJ2QWpLSnFzTXQ0?= =?utf-8?B?WVZZL3ptZ095VGdxV1B2V2ZYdmNabjdLS0xEWUdHRmRSaEtBUjZRVXQ5Z2Jm?= =?utf-8?B?amV6dTFwSVpRSlRQRnBuZGl1YU5iSndLdVpqdTB4WHRMcm1ocnc4R3paTTk0?= =?utf-8?B?clEzYllTZUtabXF2SFA1QVZXeWhXZk5FSU5xVUhkVWN5bWcxcnVvc2VJMHNJ?= =?utf-8?B?YnY5c2orQkhhOXNNZGtpcHJJTzJEVmtvSGNiZEI1MVRFVjJWV1VwQ0FnZzl2?= =?utf-8?B?OERMMFVkUlo0VkowekR1VFNnRDNyZGozOWhEV1Iyd1JzRkduSHc1U09GWURu?= =?utf-8?B?VzF3bFJJb2ZobFZUcUYwbFFBQkFodUN0bEtObm16bVFDaWF4eFdnNjJyZHUz?= =?utf-8?B?RU8rKzlESUJ3c050blN2MHljYTgxWEdUTStvNzg0ZzhadkpmOU11WTZXaTF1?= =?utf-8?B?bUtoSTkwRExNNFFMZGJMWi9UWFlBdld3N1hwbENtcFJPTGJKeTlYaFkrVFl5?= =?utf-8?B?ZURadUUrS0d0WWV0WEZNZEZUeVY4OUErTXVqTDk4U25BblYyalJqV2RobG9S?= =?utf-8?B?Z1ZmMm5lQU9kMzNPUWhsTjgvdGFDbDBWZ1NQeDRtVmkzRTJHR1B1VkdGNmNC?= =?utf-8?B?UzdrRkUwSlFZZ3FqNW9zYk9VU0Zoa21qd3hKSHBVYlNqM3AwdFA1bWxqZ2lY?= =?utf-8?B?SDIvUW1haUJuQlhaN25Yd1ZoZW5Bd1RZcVZhTkxDdGlCeTJ4RHpad21QVlY0?= =?utf-8?B?ODhoNlNwZVJBRkVaRjY2anZaUGNhTVVHc3J1dlRSK0Y3YkIxelI0VXd3MXBM?= =?utf-8?B?Mks1RTVrWUVJZzkvYlRiRjZ3dVVSTXhGMU1Od1gybWR3andtNkNZL0JTS1NG?= =?utf-8?B?YjdOb2NBemp0bnJpSDd1VFdlMEpxUWg1aHdvc3lCTEV1UEJlMlQ0c0tQRFdB?= =?utf-8?B?MUNhYWUwVnhnck1QczN3aDF6eHNVckY0QWdwb0JHNktQSTNSempxWkE2Mk1x?= =?utf-8?B?TkdxRnh0ZTZiTXhYdUtjQlRObjg4amVubjdsazUwR3NOanpyNVBKeldVcTFV?= =?utf-8?B?ZWpWUXFqa29TTForWFhJaXBMekdxa3dLQXdRWWIvTTZ1SVpaOXJxM2puY1JN?= =?utf-8?B?NGUzOFd5d2IvUHNmZitlYVdvS2JtZis5cU5QN21ESnJ0V3JGTEE5bUdVNG1H?= =?utf-8?B?TnNabzBjam55enAzYmhvUHhLbzdXODBOTUIxc0o3d0I1aHFkMmk4V1N3eElO?= =?utf-8?B?dmc3ZC9adEZtNndDK2NXZHB2aHc1VXNZVVNZampNQVp5RE9MemRGQ2xKNkNE?= =?utf-8?B?NlhMUlQzMExuS1VMdC9OUnowaDdhcjEyMkhDa1pOWUZaUjlKVW1tNzlxcDRk?= =?utf-8?B?UFFMNm9kZmMwVjhlN0pHWkx5aGNvdjJLV2tUSXZFQ1BjL1ZEbnNpbElwQmdu?= =?utf-8?B?L0s0VEgvNDlEeUpBbTZSbUYxN1M2NVZHTUF6NEgwWHVRcWZpZ0k1ZUw2THhk?= =?utf-8?B?UURhdlhXTlFZZWlZb0tqcEJJWk81OFFjai9aZTV4dnFIZm52QktCSVFqWmpp?= =?utf-8?B?MlU1Qy9jelYvc3ZjcUlPUmRUaDVyeWJKS080d2dmMWUycXhmMS9iZnFUV2x5?= =?utf-8?B?Z2QrNkZHTTI1WFR4TnpvcFlVWGZWTHhmMzN2QW4zWWU2bEt4dlpwQWdQTHZT?= =?utf-8?B?WFBwS2RyUmhPc0VsQmJUa3k4a2wvV0FSMkhUSFluK1Y5bGJJK0xkdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d0416da-4448-4a69-0617-08da422bdb2e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 11:02:15.5693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vyiaxog/F/CCBcJ6cjLLJp+Nz3AHCW0dcvnhTz+l1VDCI6iE8OQrHDljY4xqjoqh4ASVgB0sl8SX6skXuGv9Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6682 On 30.05.2022 12:49, Jan Beulich wrote: > On 30.05.2022 11:03, osstest service owner wrote: >> flight 170771 linux-linus real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/170771/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 >> test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 >> test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 >> test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 >> test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 >> test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 >> test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 >> test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 > > This > > vif vif-1-0 vif1.0: Asked for 0 slots but exceeds this limit > vif vif-1-0 vif1.0: fatal error; disabling device > > to me looks like a regression in netfront, considering that there > don't look to be any relevant netback changes. I have to admit > though that all three recent netfront commits don't have an > obvious connection to the slot count going wrong. Or wait - isn't > this a result of 6fac592cca60 ("xen: update ring.h") touching > only netfront, when netback also has a use of > RING_HAS_UNCONSUMED_REQUESTS() (in xenvif_tx_build_gops()) which > wants an actual count, not just a boolean? One more general thing noticed in this context: It isn't very helpful to have both host and guest use the new kernel when wanting to isolate regressions like this one. It would imo be better two have three (host,guest) sets: (old,new), (new,old), and (new,new). I have no idea at all though how feasible it would be to arrange for such. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 11:35:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 11:35:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338515.563295 (Exim 4.92) (envelope-from ) id 1nvdft-0005wT-Cs; Mon, 30 May 2022 11:35:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338515.563295; Mon, 30 May 2022 11:35:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdft-0005wM-95; Mon, 30 May 2022 11:35:05 +0000 Received: by outflank-mailman (input) for mailman id 338515; Mon, 30 May 2022 11:35:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdfr-0005wG-Qs for xen-devel@lists.xenproject.org; Mon, 30 May 2022 11:35:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b21b729-e00c-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 13:35:02 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D410E21B63; Mon, 30 May 2022 11:35:01 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86F9213A84; Mon, 30 May 2022 11:35:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NmJ9H+WrlGLPdQAAMHmgww (envelope-from ); Mon, 30 May 2022 11:35:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b21b729-e00c-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653910501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VtWEzLh+t2xI23/ZsFZwEDqX/MxDCN5dV6zj7JYIqG0=; b=XehnlzPLjv36KTNOB9J4ShMSmsMYHbhrrdLdVbWTzeBLyw+C7WdzQRfn0FE4QjFefjXu+V 9LpbUM5fdnYDbmN8XOeZr5O/vfu9gTM3n57PlUU7GaV/dDb35M/Sxs+tvFZQ772zKoJ726 nP0Rlld/SRDHZdIltFFXqS4Qj1FkTfk= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jan Beulich Subject: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Date: Mon, 30 May 2022 13:34:59 +0200 Message-Id: <20220530113459.20124-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case of RING_HAS_UNCONSUMED_REQUESTS(). Reported-by: Jan Beulich Fixes: 6fac592cca60 ("xen: update ring.h") Signed-off-by: Juergen Gross --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 0f7fd159f0f2..d93814c14a23 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -828,7 +828,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, break; } - work_to_do = RING_HAS_UNCONSUMED_REQUESTS(&queue->tx); + work_to_do = XEN_RING_NR_UNCONSUMED_REQUESTS(&queue->tx); if (!work_to_do) break; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 30 11:41:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 11:41:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338524.563306 (Exim 4.92) (envelope-from ) id 1nvdlk-0007Lv-4g; Mon, 30 May 2022 11:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338524.563306; Mon, 30 May 2022 11:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdlk-0007Lo-1W; Mon, 30 May 2022 11:41:08 +0000 Received: by outflank-mailman (input) for mailman id 338524; Mon, 30 May 2022 11:41:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdli-0007Li-NU for xen-devel@lists.xenproject.org; Mon, 30 May 2022 11:41:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63b54ad6-e00d-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 13:41:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 59BD82199D; Mon, 30 May 2022 11:41:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0795913A84; Mon, 30 May 2022 11:41:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1vmPAFGtlGITeQAAMHmgww (envelope-from ); Mon, 30 May 2022 11:41:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63b54ad6-e00d-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1653910865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=i4LKt8LZNv7O3Wwu1DiLKI3Zd8LxtAGWiwhpXlwpTRU=; b=uSiaXqJKBGwScZ32qFf6c8Gr0kfZ5zQ7IMWOMLz8yYZlkjP6w7ux8Ebr/jpu5M3k/m7nX9 yQkTTaWffg4F9bOlmht+H+K9W4NJ5QNWKiDRpQdAkqYDJoF57sL4Eu1COtrTyxLFAOCwFj DUEwooU54jdHpvSXYHRTmHKg5+d1eRA= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH] xen/netback: do some code cleanup Date: Mon, 30 May 2022 13:41:03 +0200 Message-Id: <20220530114103.20657-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove some unused macros and functions, make local functions static. Signed-off-by: Juergen Gross --- drivers/net/xen-netback/common.h | 12 ------------ drivers/net/xen-netback/interface.c | 16 +--------------- drivers/net/xen-netback/netback.c | 4 +++- drivers/net/xen-netback/rx.c | 2 +- 4 files changed, 5 insertions(+), 29 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index d9dea4829c86..8174d7b2966c 100644 --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -48,7 +48,6 @@ #include typedef unsigned int pending_ring_idx_t; -#define INVALID_PENDING_RING_IDX (~0U) struct pending_tx_info { struct xen_netif_tx_request req; /* tx request */ @@ -82,8 +81,6 @@ struct xenvif_rx_meta { /* Discriminate from any valid pending_idx value. */ #define INVALID_PENDING_IDX 0xFFFF -#define MAX_BUFFER_OFFSET XEN_PAGE_SIZE - #define MAX_PENDING_REQS XEN_NETIF_TX_RING_SIZE /* The maximum number of frags is derived from the size of a grant (same @@ -367,11 +364,6 @@ void xenvif_free(struct xenvif *vif); int xenvif_xenbus_init(void); void xenvif_xenbus_fini(void); -int xenvif_schedulable(struct xenvif *vif); - -int xenvif_queue_stopped(struct xenvif_queue *queue); -void xenvif_wake_queue(struct xenvif_queue *queue); - /* (Un)Map communication rings. */ void xenvif_unmap_frontend_data_rings(struct xenvif_queue *queue); int xenvif_map_frontend_data_rings(struct xenvif_queue *queue, @@ -394,7 +386,6 @@ int xenvif_dealloc_kthread(void *data); irqreturn_t xenvif_ctrl_irq_fn(int irq, void *data); bool xenvif_have_rx_work(struct xenvif_queue *queue, bool test_kthread); -void xenvif_rx_action(struct xenvif_queue *queue); void xenvif_rx_queue_tail(struct xenvif_queue *queue, struct sk_buff *skb); void xenvif_carrier_on(struct xenvif *vif); @@ -403,9 +394,6 @@ void xenvif_carrier_on(struct xenvif *vif); void xenvif_zerocopy_callback(struct sk_buff *skb, struct ubuf_info *ubuf, bool zerocopy_success); -/* Unmap a pending page and release it back to the guest */ -void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx); - static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue) { return MAX_PENDING_REQS - diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 8e035374a370..fb32ae82d9b0 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -69,7 +69,7 @@ void xenvif_skb_zerocopy_complete(struct xenvif_queue *queue) wake_up(&queue->dealloc_wq); } -int xenvif_schedulable(struct xenvif *vif) +static int xenvif_schedulable(struct xenvif *vif) { return netif_running(vif->dev) && test_bit(VIF_STATUS_CONNECTED, &vif->status) && @@ -177,20 +177,6 @@ irqreturn_t xenvif_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -int xenvif_queue_stopped(struct xenvif_queue *queue) -{ - struct net_device *dev = queue->vif->dev; - unsigned int id = queue->id; - return netif_tx_queue_stopped(netdev_get_tx_queue(dev, id)); -} - -void xenvif_wake_queue(struct xenvif_queue *queue) -{ - struct net_device *dev = queue->vif->dev; - unsigned int id = queue->id; - netif_tx_wake_queue(netdev_get_tx_queue(dev, id)); -} - static u16 xenvif_select_queue(struct net_device *dev, struct sk_buff *skb, struct net_device *sb_dev) { diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index d93814c14a23..fc61a4418737 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -112,6 +112,8 @@ static void make_tx_response(struct xenvif_queue *queue, s8 st); static void push_tx_responses(struct xenvif_queue *queue); +static void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx); + static inline int tx_work_todo(struct xenvif_queue *queue); static inline unsigned long idx_to_pfn(struct xenvif_queue *queue, @@ -1418,7 +1420,7 @@ static void push_tx_responses(struct xenvif_queue *queue) notify_remote_via_irq(queue->tx_irq); } -void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx) +static void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx) { int ret; struct gnttab_unmap_grant_ref tx_unmap_op; diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c index dbac4c03d21a..8df2c736fd23 100644 --- a/drivers/net/xen-netback/rx.c +++ b/drivers/net/xen-netback/rx.c @@ -486,7 +486,7 @@ static void xenvif_rx_skb(struct xenvif_queue *queue) #define RX_BATCH_SIZE 64 -void xenvif_rx_action(struct xenvif_queue *queue) +static void xenvif_rx_action(struct xenvif_queue *queue) { struct sk_buff_head completed_skbs; unsigned int work_done = 0; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon May 30 11:53:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 11:53:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338534.563317 (Exim 4.92) (envelope-from ) id 1nvdx5-0000Un-CM; Mon, 30 May 2022 11:52:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338534.563317; Mon, 30 May 2022 11:52:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdx5-0000Ug-9L; Mon, 30 May 2022 11:52:51 +0000 Received: by outflank-mailman (input) for mailman id 338534; Mon, 30 May 2022 11:52:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdx4-0000Ua-By for xen-devel@lists.xenproject.org; Mon, 30 May 2022 11:52:50 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0661ea75-e00f-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 13:52:48 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-17-S-6fYyGaOkayE2rJSvyFRA-1; Mon, 30 May 2022 13:52:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4182.eurprd04.prod.outlook.com (2603:10a6:209:44::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 11:52:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 11:52:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0661ea75-e00f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653911567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GNB21eekDD1mf7Q768nH++K7AKu3rAPFrlwXkWKPKeE=; b=FKOYJ5nejaJ1gQB75ImocSbxSDxnDGvezjHY4fY6/2AI1A1pz10ZCpNSxZbIqPLSD4YE8K 0EefOTLaoACFmmuGOslNlmh6rVXgTPEq4RdTiUaRqM74krts2RhALFPlykCu74K5vgO0Mk pKOZ5+k3eVDQ1Imba95dQihVLv0nNS4= X-MC-Unique: S-6fYyGaOkayE2rJSvyFRA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nse/O5XSfiU1Z3hkzTQjARRH+W1J+dUobt5k0GnGcyqugBUvxASVA5PnmWgHSD6DkPUigIuYG+1e06Gc5Cr6amUIwYX6UFt/RYtb0bUiPBBTzOUdXLsPzEwlQtSZakqixpbYtTgd2gFekjmD83mirF6wvkFFf+SV60Q+s32ZqqvEDCuj9t0z1//v8Bz8GWXCucgLJN5eUbOpRjIf0PYHFAa+iSjE8KuC1MBOfIYryaZJxvYf1YttC7yz8Hbyu+iFTZnqkPFl7JgtNZAHcBxlrT9LQra2LgOyOpLeqZAfs05EiIyrY+ihzt9+1L9P8pBNL+7/eaekhvwG1uEnlxpKaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GNB21eekDD1mf7Q768nH++K7AKu3rAPFrlwXkWKPKeE=; b=gUJp5+4EgCHGfmBfwDKO40lEVP+GEeYroMSXk3UyJKyTsAJj3e9FWDQsciVnmWBq+ko+IByanyvWOgCN375z1yPcgx/RXDrUkuqNo/L7oZvOM5drePj2xnuAMKkv2/Ra5OlNs03HPzwn9/IyI6K1CtCQfPn1IU7HP0vrobocKCHEpmURRBAOg2TPzg/zgVaMw42sZ66dvg2H+o1r4rPji9QiauCMTpZuyl4FIWo3/fg6HHmnN6NkX2qv278Bu0YrO1NAFoIiW/Yu2lhO3vKWBrFQezNY1eFKVsUYsJWf4lE4IsDKm0I7XIqpuXchCAswXtXzQluRAEkQKH6DXj6Vdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <53109b1c-982d-a306-515e-44ea7de2774c@suse.com> Date: Mon, 30 May 2022 13:52:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220530113459.20124-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220530113459.20124-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0039.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c72ea9c-6fc4-4b6c-0288-08da4232e863 X-MS-TrafficTypeDiagnostic: AM6PR04MB4182:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VPLqoj1JLqA19WgmfB5Tm6528uUKvaU/0SrvfOL5ImU+v50W+hyoFhqbRHVjNv/F337Z68DsW3CzNRO/z+F3eqrUVctN65s7W42HfPq3BwUjIT/WG0amiLTRAOQk+94mG3Hqnur3F1wxVmqzqYCeKwyenigndBo2xn4+TY3g3kY7jsNQnEQHpQfVsIi9rKbrM19REPKKxLYeSnFib4Nl7e2RXmbERYOpZAZSWkx91E1najTbHf+lUOwVCmUi0V1OWYGPRzANTOYeRiCXHmenMhGteXu/PKxNYJQhDiydePUdNeUclXGqGwb/TQT5Z8M9N7DaF8Oc2CBpUJjP6NcGI4nC4HCOMcBqSeCFKXRtsaO4RheGyj7/WcITpT6HIFTp8ilDbHR5l1YXJg8z6axl0Dt5MtBnuNWLMUBSTrUxn6hLl+rFXgHXHw2jVIuFMEn0yF1YZ7JysRE7ud1nPKy8MWyDozw5fqf7cDNQbL4ttt/bQtKtc7eSUQHHtLTue8adIOQakN26y8laHo9d2ULQB3+92lE2l08mJM9U3utke9xHHoyFWJVgwgbxQ3KFa52zLZJdAAngVhEoFzqadaymMqabWSKvYwBf9NrpXG4mhJqMQ5rl0CBzZ+FzdK838IUb6x6NxudqaBViYLM+0wi844whxXneOMoRVzXFI7jOU1qji3ZXGOniKbYsXL9C6nHr5KA5y2KMmDYNuQ0pLl9wWz5qqZSP8ij3VcaeqnfGI6eX1vIrPvk/bjJW+CaEWNId X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(5660300002)(4326008)(6862004)(8676002)(66476007)(66556008)(508600001)(186003)(83380400001)(6486002)(8936002)(31696002)(86362001)(26005)(6512007)(38100700002)(4744005)(2616005)(53546011)(6506007)(54906003)(2906002)(37006003)(6636002)(6666004)(36756003)(31686004)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjVjZ1lacU1ZcExsUjZNMGhuSkViSTVMQVBGMjlHOU96emYrcWtZVDJ5VkpN?= =?utf-8?B?cStldkxvbWZMMVR3amtjVEx5WnpVTkxKeXl1L1VCdjJneXhUSWRkakdPbHQy?= =?utf-8?B?a3JWQ09FeE9lYWdrV3JIR29pak5BNTBMdnhMYWdxYWRoMVZFWW90Z2gzVFN6?= =?utf-8?B?ei9tcVMrVURhZEE0MFkvYXZEVjA5QUdzdXJZOGZxMTNpUnJhdjRWTzR2Z0Y1?= =?utf-8?B?ZG1qajQ4dnU0OTFtOXB5UjljRG1wWUlJVEh1MDdvWHRFSXpUVTlEb29BSlRT?= =?utf-8?B?cndrcExTUjdDUzhHNC9tOUl1R3EvVW1aZGpJRnIwMHVEQzFRT3ZSSnpNU0hl?= =?utf-8?B?blFiSHRpSUw3eEtreWhablJMakQ2VXl1bHczM1VpMnE0bjNzVnpVbW5oODU4?= =?utf-8?B?N1grSjk5UGhEMTBXN0RDdXNkQUNDeVF6ZUlZN2w4NmtpMjBXUEpmZUNKTHoy?= =?utf-8?B?TlM0VWtuNzJqRWNVRFVFcDdUYkY3K3Vyd29QbUJFUm96N2lpQVFJdWdDSXZW?= =?utf-8?B?eTkyTUk4T3UwK3VFUzJFTFcvc3lVRDRDNzFZRlhOYmZDYnpQQm5ZWS83L00v?= =?utf-8?B?SC8vb0s3K2ZPOUpldDMzV0F4Wk1lNXkvdlZFdmpmcWpOL1VMRWljN2c5dFRn?= =?utf-8?B?aFF1WlcxZ2dybEx1WGlWeUZtT2NXZnAwLzRwOHIyOGY3SWNZYThOQlcrVUp1?= =?utf-8?B?V1RNTjRocDRyRHFvdDltMFVUQ0wzTm5qR3AwQVpxa01ESXQvTi9ianN4SXFM?= =?utf-8?B?UUZzV2FCVDV5VHVQdEMwcjJ3bVRmSWJiUmFHRjlyUW1oY3l3Ukh4Wi9EaWl2?= =?utf-8?B?OHdXT0NLNWM0U3pPWjFLMUJKanhHczgvZVY5eFRWVHpkZk8wSnprWkgzaWk0?= =?utf-8?B?SmF3a1BEZEh6NTgzSjJYY1dZUkZMWldzajVoc05JdWdMUm9VRU40TXhxZ0VP?= =?utf-8?B?dEJOYmcrUTc5b2Y2TGxTZEt6aUsvdmRKalZmS0c1d2pPNit5amRGL1d3alFi?= =?utf-8?B?d055SUNGb2kvMWI2bUdueDZzVnlyYTY3a1FpWi9CTzJwRm5LZjJUdlJMRlVr?= =?utf-8?B?L1dqNHBub2pXYkM3dFZjUVFPejBtRTdwN1Rrc1dnREVEVEVwN2QxaU5YU1kz?= =?utf-8?B?YnA0WVl5V2R4T21qZzhuN0oxeGhTaEFwUzhkMHlpTDFML1J2UndWcVFyOE8x?= =?utf-8?B?V2NhMEhuWm1XUjMrZzExS2h2c2ZCcnM3MlpqK2FEOWFBd0NzU2xBTDdYOWdI?= =?utf-8?B?a21tNi85MTdMbXRkRlM3dEw3bjM4MjE1bUM5RkJzcVRxZVJ3UDc1aGdFMWxJ?= =?utf-8?B?SEVMbnhjYm5HTHFUcEhDSzN2L1RtQkx5bjBmelNZTVVVTys0UFZ2RzhRQ0Qr?= =?utf-8?B?KzB3ZGNyeHZxcm8vdjFYREI1a2hqZSt4MjJoZ3F0Z1ZTTWtnbVJJaGJveFIr?= =?utf-8?B?UC8wTkZhblhIZkduS3VNd1pmSU5qbWVDOTNYMm9vVHNYNTdyTENjbXd0cjkv?= =?utf-8?B?dWJkUUVzcW42NXpRcEJENzVNTzEvWWNidmFwUWxZbWZZUnl1OS9OZE0vcDR4?= =?utf-8?B?YndDbFd5cUdPdFVLYmtrVUVLeG1MVVNaRG1ZQUNnS2VjT2dOS3dQQW9WaWZa?= =?utf-8?B?ZEN3ajR2RmkxMld0ODBXU0kyTjV5Y3NHM01aZkZDNDBCT3A0c3M1WFhkb2lL?= =?utf-8?B?enBIMVkvcXd5MGVVUUxRRzNZL3FWVkpDQktNUmdKdEtSYWFtdWpDZzhYSkFL?= =?utf-8?B?aFFKVU1LUFZ6ZnJWY3lLLzl4TnZTYllZK0w1RmFqd2RhSW8xQU9NSWdSRU5u?= =?utf-8?B?emVXcmUxYVpHbXN2bFBqNXcrRFdZYWVxandjeDF6OHZJc1NiYU9Nek9BQ3Z5?= =?utf-8?B?QUtDaEg4SXVVRHB3anVxV2pmb3FCWVB6NW5nU1lKSmViZHBIRkRlVEwxc3BC?= =?utf-8?B?YnRUZzEwQ1F3TWFqaWc2MGFPZmJLdituY09CeWhtYU9OUWZSbEFkRFdyeStV?= =?utf-8?B?bnIwb0ZvejFHT3RvTTIrcXAwdzdQZi9aQi9QZ2hXNHE4K3BqRG91a2p1TjBN?= =?utf-8?B?R0duaDhEUkNMd2xmR0hUSzdic2lTUnVXTkl6bEFqUGR4dG9MTzNNazVpeGZr?= =?utf-8?B?YmRTVzFIRFZvbHFzNmNjbWJmRCs1OVF6UVg2eXU2T05WSWN0RS9jY0JOQjFP?= =?utf-8?B?ZmRDbkxUWG5JemY5UmhFMi9yY284c1NIUDAycENlY0xyQncveG1qSDY4NnZP?= =?utf-8?B?TGx4R1hFRzJialFIQWFPY0g4bEszbTlaT3JSRkJ6WGhiYnh4cEV3WTJYeHh1?= =?utf-8?B?RWpFWWxJbFNkNVZOQjNTbHI3Um9WSlFNWUFVYmFDeVJ0ZTBrZnY0dz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c72ea9c-6fc4-4b6c-0288-08da4232e863 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 11:52:44.2353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EAWoHDN/KEWMx6dAcnFd5Z+ogDqdE3mAhiwBBAc8cBPRYsRpQ8xjG949TI81tGcZoJZkhC+630Wm5pNM/1OpJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4182 On 30.05.2022 13:34, Juergen Gross wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon May 30 11:55:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 11:55:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338543.563327 (Exim 4.92) (envelope-from ) id 1nvdzD-00015m-Pv; Mon, 30 May 2022 11:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338543.563327; Mon, 30 May 2022 11:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdzD-00015f-Mw; Mon, 30 May 2022 11:55:03 +0000 Received: by outflank-mailman (input) for mailman id 338543; Mon, 30 May 2022 11:55:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdzC-00015V-RL; Mon, 30 May 2022 11:55:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdzC-0002FG-Nv; Mon, 30 May 2022 11:55:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvdzC-0000Ef-B5; Mon, 30 May 2022 11:55:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvdzC-0003C4-Ae; Mon, 30 May 2022 11:55:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d7SS34zKcpoWKYo4G4vQIVAyjJwQyelxzMLRrgrpZd8=; b=KQ/q7sLjLaEIlkHoqAqvBsMA6J kazPMDGGnDe7o+om1ceK3aGNqMoKLesnJQ/gCT67t7Z3U/AB5he/oyjk0GGvAoxDRrHgvjLTL1q8d Qk7vu8mpaj7AVEiVk/HyF6FY7OuvM7NEZdWE8Qx2DDYExeR027Bm/BQv54CifVE4L7CU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170773: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f7a1ea403e0282a7f57edd4298c4f65f24165da5 X-Osstest-Versions-That: qemuu=0234342e0ea9411ad032dac61f3d632536bda789 From: osstest service owner Date: Mon, 30 May 2022 11:55:02 +0000 flight 170773 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170773/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170764 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170764 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170764 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170764 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170764 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170764 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170764 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170764 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu f7a1ea403e0282a7f57edd4298c4f65f24165da5 baseline version: qemuu 0234342e0ea9411ad032dac61f3d632536bda789 Last test of basis 170764 2022-05-28 18:38:12 Z 1 days Testing same since 170773 2022-05-30 02:06:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marc-André Lureau Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0234342e0e..f7a1ea403e f7a1ea403e0282a7f57edd4298c4f65f24165da5 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon May 30 12:51:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 12:51:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338555.563339 (Exim 4.92) (envelope-from ) id 1nvesA-00079R-5k; Mon, 30 May 2022 12:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338555.563339; Mon, 30 May 2022 12:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvesA-00079K-2m; Mon, 30 May 2022 12:51:50 +0000 Received: by outflank-mailman (input) for mailman id 338555; Mon, 30 May 2022 12:51:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nves8-00079A-P8; Mon, 30 May 2022 12:51:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nves8-0003E6-JS; Mon, 30 May 2022 12:51:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nves8-0001fO-AY; Mon, 30 May 2022 12:51:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nves8-000206-A7; Mon, 30 May 2022 12:51:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xx/ANy0xMjdfOd5GgocSAMOhMjC9KqnWs+VXf1VoFmM=; b=frKLDijgEkh2mamT3zV0+GZt9K RaLlII3Wpi6QEbRhfvxLuKVmVUgZvMmK1X/1QzqdKcWZPuJB4edcffcuIexU18/oX8zyo9XnNYKBp jLeDyOIbmYt9Wb37fTkuRj7Bs0OcVPonvgcGDA/YFActMP6bMrJx54PSOHj6s3e87sKU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170776: all pass - PUSHED X-Osstest-Versions-This: ovmf=3ca7326b37c5d20d9473f47266074e61ea384c5b X-Osstest-Versions-That: ovmf=dac2fc8146e42ef19cd50ecbe32ccb7705b76fa3 From: osstest service owner Date: Mon, 30 May 2022 12:51:48 +0000 flight 170776 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170776/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3ca7326b37c5d20d9473f47266074e61ea384c5b baseline version: ovmf dac2fc8146e42ef19cd50ecbe32ccb7705b76fa3 Last test of basis 170755 2022-05-27 16:42:14 Z 2 days Testing same since 170776 2022-05-30 11:14:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git dac2fc8146..3ca7326b37 3ca7326b37c5d20d9473f47266074e61ea384c5b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon May 30 13:21:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 13:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338566.563349 (Exim 4.92) (envelope-from ) id 1nvfKr-000219-Hv; Mon, 30 May 2022 13:21:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338566.563349; Mon, 30 May 2022 13:21:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfKr-000212-Ew; Mon, 30 May 2022 13:21:29 +0000 Received: by outflank-mailman (input) for mailman id 338566; Mon, 30 May 2022 13:21:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfKq-00020w-1Y for xen-devel@lists.xenproject.org; Mon, 30 May 2022 13:21:28 +0000 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [2607:f8b0:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67112b59-e01b-11ec-837f-e5687231ffcc; Mon, 30 May 2022 15:21:24 +0200 (CEST) Received: by mail-pf1-x435.google.com with SMTP id b135so10547583pfb.12 for ; Mon, 30 May 2022 06:21:25 -0700 (PDT) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id e18-20020a056a001a9200b00518285976cdsm8844811pfv.9.2022.05.30.06.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 06:21:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 67112b59-e01b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1F0uftzI5Q6LjBGSRzse993wSF+4FV1A0f7dXUsc6dA=; b=ShOoUc1jH0YJ887llkMIp4r9G1OQvZuKunf0d5J3ssj2GQG/U4lf6aVa5p4ASdHMH3 kMEIp+qfwQErdBazMQvTDqE6WRJmGdki+olpjhpeQc2uSyZ92rVFRTCxpMlWq6ZATZzo gHmnhJpIrW73tLyg0/dFVn4ygQpi2XN1e6ImKsSQPfDELRLvJjxEOxlZLHgUgvJSVNU4 kvDtu9iljGmE5MIRzPo54dVtHoJpHUqZJD9BK2/9twwA/h80NQaC0i1sHDEhMLkpDbql odYVrnyc604PVVdJS+J1Ja1R2/xttV1060PcRUc28lFV86vH/70JJMrgMEdTr8dY3fdM F31Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1F0uftzI5Q6LjBGSRzse993wSF+4FV1A0f7dXUsc6dA=; b=pjzmoX7FOrRU2cJyNvFp0N1/ZvksRUW0IrphWTA8MYSplor/5u/asUwjIhTUWdciW2 1rKBcSmngVnhw28labwf1UG130+IOZ3wrfo8dsFcapM1ZvzAWcgw/vWLUAaftQN9ukI1 PKYBtRNaMPt+h9N+kyDi9wqYcBlqzLvL3tqCdo5l+lrbYAF7H0pdxEI566ltmulrfITz wyFT8Vp7ptKonm3MWkJGw3bY5RAQV9940wfQZ3Ic5DLbW2EmAvrJ8Rx2RjaUkk7FbyhM xSaMcqsVXobNX/7m59OSyw/rOCRL3HQsvLehJgMIFHznqlPN8LsCOsGyO2TVcO56zw/P XgEA== X-Gm-Message-State: AOAM530cxnErHYmWEGkFXHXouMaUP/Ow2ebHWdjEfksG8BzZqhdJMXfz pBBHPyNIiRzpzb+UydoQzLw= X-Google-Smtp-Source: ABdhPJzD14XGB55/LWH/814vK4zGjVOozs3YEEt8P1fchX5CeSvAYxeGEaHIki53bJ0Uxse4XUBVfA== X-Received: by 2002:a62:be14:0:b0:505:a43b:cf6e with SMTP id l20-20020a62be14000000b00505a43bcf6emr57067489pff.33.1653916884057; Mon, 30 May 2022 06:21:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <5220940a-8b7a-6f09-6270-a138f7281c6d@amsat.org> Date: Mon, 30 May 2022 15:21:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , John Snow , "open list:IDE" References: <20220513180957.90514-1-shentey@gmail.com> <20220513180957.90514-4-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20220513180957.90514-4-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/5/22 20:09, Bernhard Beschow wrote: > This function was declared in a generic and public header, implemented > in a device-specific source file but only used in xen_platform. Given its > 'aux' parameter, this function is more xen-specific than piix-specific. > Also, the hardcoded magic constants seem to be generic and related to > PCIIDEState and IDEBus rather than piix. > > Therefore, move this function to xen_platform, unexport it, and drop the > "piix3" in the function name as well. > > Signed-off-by: Bernhard Beschow > Reviewed-by: Paul Durrant > --- > hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++- > hw/ide/piix.c | 46 ------------------------------------ > include/hw/ide.h | 3 --- > 3 files changed, 47 insertions(+), 50 deletions(-) Reviewed-by: Philippe Mathieu-Daudé From xen-devel-bounces@lists.xenproject.org Mon May 30 13:35:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 13:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338574.563361 (Exim 4.92) (envelope-from ) id 1nvfYJ-0003aC-Ru; Mon, 30 May 2022 13:35:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338574.563361; Mon, 30 May 2022 13:35:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfYJ-0003a5-NU; Mon, 30 May 2022 13:35:23 +0000 Received: by outflank-mailman (input) for mailman id 338574; Mon, 30 May 2022 13:35:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfYI-0003Zy-74 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 13:35:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7d00::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59eef907-e01d-11ec-837f-e5687231ffcc; Mon, 30 May 2022 15:35:21 +0200 (CEST) Received: from DB6PR0601CA0039.eurprd06.prod.outlook.com (2603:10a6:4:17::25) by DU0PR08MB8137.eurprd08.prod.outlook.com (2603:10a6:10:3ec::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Mon, 30 May 2022 13:35:11 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::8a) by DB6PR0601CA0039.outlook.office365.com (2603:10a6:4:17::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 13:35:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 13:35:11 +0000 Received: ("Tessian outbound d3318d0cda7b:v120"); Mon, 30 May 2022 13:35:11 +0000 Received: from de056ea01835.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FB4741A-1A7F-4E96-AF9C-7EE616CFE2BE.1; Mon, 30 May 2022 13:35:04 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de056ea01835.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 May 2022 13:35:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB7PR08MB3372.eurprd08.prod.outlook.com (2603:10a6:10:4f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 13:35:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Mon, 30 May 2022 13:35:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59eef907-e01d-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gXMBOZhs9dKS5fJNXRsW2X+N/+OngxRIwqUDt1jxJbjCcHF2Mr2m47O6U76EpjkdsABdAp3hamHy7w0jJHZndWhjwjiu/PYfSQFS+7JPqmA4LbkOGwl0DgSqOcqJhIt26Ts/Ulx8ZB+umY5YBPp4psjG6KdctPu83K4A29Cyifz/cDmAWIbkQy9n2GDlq4apRn4yMQi5ax+/M97CaPSufV1hxiPu+UWYfuKVS/PDP1lzU1sg5rST5/S+V3dITbTfl5QD7ZuCTql1YT4as3D+qo+YGOCkWDCGmNLQ+wZjh4tnfB5KXirkEeT7XQXXUDuEekgZb6nE57OQntjayQxe8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9H14ODKESzObRYbib1NHPXEfCCsVmJYuV9g5hRVU8Q=; b=X2E6xOJHwhMjhh1OB1ZM5y91EVjkO+Z4toBhS7GItxem+WJqDjOcj3NyhqXZPlYcU9X/zRIEpNq/u+w63+OFQ2n1bYFBYQb5LFEkrFiwZyYoHFCWGi2GdA7mJJCdv2+5BnDsk8jhIMiBH47WP9ProqQ34aX7L6I3DHHuChJ3PPqJfzFeCcOLVeKhomkeQG7jXpRNuXh+/U5qZP6zrcaqw5Ap1SVbKZxwcACLoPfT92HtEXp8CorQ+t7a+ixZBBBeYFWD9mgfWdb/Vgatfi79hSrWekYqd31RdloF+BnMbVkD6WQZjHLN2Byrklh1UdbxOhmXoFfoHVU/o6p7UMFAaQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9H14ODKESzObRYbib1NHPXEfCCsVmJYuV9g5hRVU8Q=; b=z005+Us4UxnF16qcxFX9UguVvYZWg7yZGhWQzj6yZHZMD3mVyeTIUzQgB6OxI18szOSa2DVKWOQOwQJj3X+IFVcLi3d6MPwzuxa2w4fnC1iLp+N5d+d0Zcjc+eQ5l0GAVNv5vKZ5K+9njTqVw7H+NeyYPw/Izyfjx8dQKgbsW6Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d7ae9bbe2e614c85 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kEUM5KZzbuqymaA+aghRdguDkkYq/HNMy3qp8ubU4eyNQv2S97/lsPDaN9ZrJJtic1veMwtzpS0mPBnUxmUFtZ7gHY/uDnsVEdIRov5RTtGZSkQuYupPCxjXVtVnOcAd8Ox6cA05WJsnEHdFmpWaog6QQH5MITOArZMwRy+D/APLdIbIOCk68kCn8o1389xfPm7HGUf1fY9TmpiYlL0Xsrd7UyFX0CobF8uB0DU0OdTYxqNEirznacjM42Oip29yL55/j0m0JS3PM6lfqkQNdNyJ/0ar9XbcFUVKjICO0kDKsmE3qASn/ZgEPaO19e4HjJIEGj+JiRqHnJ0Jz+83ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9H14ODKESzObRYbib1NHPXEfCCsVmJYuV9g5hRVU8Q=; b=dSyYpJkYqcd0prjXqtO6SdfgQWFHVAnMiBwNm3ek6zZklBPdRxcMy9OE83dcxjV6rVs7UVpRUyaWPtpGCM15g3xcYRZtt95/OZhc2MaY1/uFLySRG47fzIUeacbB8MQmKa4obd3R/1BARz1220XD73wzdzSsp9JGBjOUp/UiGv1wRIP5Vwzz0TdaXsnVObFS0/JCkAzHwQ3vd++MAjHUVZj9rLq/pFIZ+N9qwcSYvCWH5yt4x33kTzMYHckBlxecfdqW2gwqfZ4ZT9lqNZVFOdroC4p59aSLZZDRRNoTTQ9moqj3/MFZjMopG2dcUeStUz+DcHKvFmWwB27i1/Vs9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9H14ODKESzObRYbib1NHPXEfCCsVmJYuV9g5hRVU8Q=; b=z005+Us4UxnF16qcxFX9UguVvYZWg7yZGhWQzj6yZHZMD3mVyeTIUzQgB6OxI18szOSa2DVKWOQOwQJj3X+IFVcLi3d6MPwzuxa2w4fnC1iLp+N5d+d0Zcjc+eQ5l0GAVNv5vKZ5K+9njTqVw7H+NeyYPw/Izyfjx8dQKgbsW6Y= From: Bertrand Marquis To: George Dunlap CC: Jan Beulich , Julien Grall , "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Stefano Stabellini Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Topic: [PATCH 1/2] docs/misra: introduce rules.rst Thread-Index: AQHYb89Ql1y5oYxB8EW1dQIiqL2u/a0vNXYAgAEjhQCAAJGbAIAAAxAAgAAFpwCAAC97AIAAc0MAgAC4OQCAARHVgIADyvaAgAABVgCAAALZAIAAAdqAgAACLACAAAPcAIAAB2OAgAA1/YA= Date: Mon, 30 May 2022 13:35:02 +0000 Message-ID: <138D3C39-74A6-46CB-B598-2FC5FAD1E52D@arm.com> References: <20220525003505.304617-1-sstabellini@kernel.org> <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e46885d1-fbd2-4a23-9348-08da4241387c x-ms-traffictypediagnostic: DB7PR08MB3372:EE_|DBAEUR03FT025:EE_|DU0PR08MB8137:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dngJxvO4qmDf/P8Wa8vtVbgXyUWbCisXbXcOMfjGe7yjsMSyp78dgs1JSXzwHEUl8TzuOUg02kKrItALB8xjrb2/tkAHATjNfQF3+9cOFU6HZJLZ9Jf9Zb4SHJLR56TldLvLXLuTO4kUfbT0H3vM5d9xaQlCC2y2tCFPxhTAD9/8tXTnRMSX2sIDKI1PrkfDw0siCjwwEBytY2W4ObcQA/5Wxd0bAqZweXevpUzA1BzYt+K5w5TX2T2xGOwxcF36hxrH3fNIDWz2G8ISLDUNKBa72/ZNgwBlChl9MLgg3F287r9D4Sbc9wsYbr5WT5SBTotO8j4KLBF3XoFv9YEfzagPYXSY33IvDjLVMBuG9av5HniXKI6lIUpxfWi8JiAygtR1kYmLNCObwo5ix4bVY5t9ia/O2Op9ORltsQxhVcew5zVB79nCVIXdz8K3yEefhgh63IH2PEXgqFF3f6iKni+nZzP4f+heGBUWfr3nQnd5iaFFvfyUIZi2NkbY27fgQyqgq0CDRv9yBfDSmo4m+ls2wbWYy3boNUsLwMlulphAQBSPtNCqE/Tzs5PGTVso9NfA7w9CtRpLxN4z4unGd98D1pXEdYprVt99sn0PTX85LpVzNnthp1M9QyS/06obUcX1ESSN1Ad4dHUrBLTBjzZwHtKqnK7kYc63vcCVw6JdN2FpOK5EDPmYmCgMhqdya0SdWpm4uzavWzx/PZG7rpFqf98TN693fzK64syqNpg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(6486002)(5660300002)(33656002)(8936002)(508600001)(6506007)(86362001)(26005)(6512007)(2906002)(122000001)(66556008)(2616005)(66946007)(64756008)(38100700002)(186003)(83380400001)(38070700005)(8676002)(4326008)(316002)(36756003)(6916009)(54906003)(66446008)(76116006)(91956017)(71200400001)(66476007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3372 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 347f028b-783e-406a-d3b3-08da4241335e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0gBy8ie1cSycFtH4KFNHFYwS/L1GEKqkWNzElYgHo6Vd45ws82WrNnDmkmrO2qkHXyuOUtQEsii/3KmDmsrAmX6f+ZR3BEyxU8CcTVLztFyBKiLizT6BaowbzGaTcC4+UhPgQpDiXLpMBMQE8o+f7uBw33vLAmj0CzlrzEVEhda65z2JP/R9kO161YjPPYP66594YqnSl/6kbb65eaWqlXvsL0eEBStEfKVJ2e4GuvKWfbvCcmwZqCA45qstp8BB7DWDCR4yD/trI/UgHafQ68LWNHrV7+4aeWUeuVaSBTOiV4KYFEzlw2wziNIJA+Psi2MC7uNFtY4Qw/YhpLlTywu83XgpfP3rQ8e3SXVtR3uw/ZaAqtXpC/atqZTI90MdJ1ju5IDUiAq5c+Xxf/j+fbxKJunIxKfr/4/QDnEP/4MM6aIkuN729e/uaMVbTASo0JddPQnPEbw2HQ+C7v6+KEfEJ21LUl1u5Ayj0MfTGUXDv3Pb+5M3x5RWNi3AuQ7XPSCp27HzgbRohzCQE8C6OMYGRjwuaCZgT/3MjGS4RGEs8LIfN7lmE7LfHmtrfqOci8WlN5MR1dmPnxeNKUP0F3ZsfubUsZoClcb1cDlrvphkuH8sw6OV0rm4QOMzo4yqP7iCpvNxWVOa9CHuixHTl1wxbu0ttNhQ4WPe6efTx2YijFZfZqT4N4aeF65ERhaL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(81166007)(26005)(6506007)(53546011)(2616005)(107886003)(83380400001)(6512007)(33656002)(36756003)(5660300002)(82310400005)(2906002)(8936002)(6862004)(8676002)(4326008)(70206006)(54906003)(70586007)(356005)(86362001)(186003)(36860700001)(47076005)(336012)(6486002)(508600001)(40460700003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 13:35:11.4342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e46885d1-fbd2-4a23-9348-08da4241387c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8137 SGksDQoNCj4gT24gMzAgTWF5IDIwMjIsIGF0IDExOjIxLCBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gMzAgTWF5IDIwMjIs IGF0IDEwOjU1LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4gDQo+ PiBPbiAzMC4wNS4yMDIyIDExOjQxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gDQo+Pj4gDQo+ Pj4gT24gMzAvMDUvMjAyMiAxMDozMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4+IE9uIDMwLjA1 LjIwMjIgMTE6MjcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+IEhpLA0KPj4+Pj4gDQo+Pj4+ PiBPbiAzMC8wNS8yMDIyIDEwOjE2LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+PiBPbiAzMC4w NS4yMDIyIDExOjEyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+Pj4+IE9uIDI4LzA1LzIwMjIg MDA6MTYsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+Pj4+Pj4+ICIiIg0KPj4+Pj4+Pj4g SXQgaXMgcG9zc2libGUgdGhhdCBpbiBzcGVjaWZpYyBjaXJjdW1zdGFuY2VzIGl0IGlzIGJlc3Qg bm90IHRvIGZvbGxvdyBhDQo+Pj4+Pj4+PiBydWxlIGJlY2F1c2UgaXQgaXMgbm90IHBvc3NpYmxl IG9yIGJlY2F1c2UgdGhlIGFsdGVybmF0aXZlIGxlYWRzIHRvDQo+Pj4+Pj4+PiBiZXR0ZXIgY29k ZSBxdWFsaXR5LiBUaG9zZSBjYXNlcyBhcmUgY2FsbGVkICJkZXZpYXRpb25zIi4gVGhleSBhcmUN Cj4+Pj4+Pj4+IHBlcm1pc3NpYmxlIGFzIGxvbmcgYXMgdGhleSBhcmUgZG9jdW1lbnRlZCwgZWl0 aGVyIGFzIGFuIGluLWNvZGUgY29tbWVudA0KPj4+Pj4+Pj4gb3IgYXMgcGFydCBvZiB0aGUgY29t bWl0IG1lc3NhZ2UuIE90aGVyIGRvY3VtZW50YXRpb24gbWVjaGFuaXNtcyBhcmUNCj4+Pj4+Pj4g DQo+Pj4+Pj4+IEkgd291bGQgZHJvcCB0aGUgImFzIHBhcnQgb2YgdGhlIGNvbW1pdCBtZXNzYWdl IiBiZWNhdXNlIGl0IGlzIGEgbG90DQo+Pj4+Pj4+IG1vcmUgZGlmZmljdWx0IHRvIGFzc29jaWF0 ZSB0aGUgZGV2aWF0aW9uIHdpdGggYSByYXRpb25hbGUgKHRoZSBjb2RlIG1heQ0KPj4+Pj4+PiBo YXZlIGJlZW4gbW92ZWQgYW5kIHlvdSB3b3VsZCBuZWVkIHRvIGdvIHRocm91Z2ggdGhlIGhpc3Rv cnkpLg0KPj4+Pj4+IA0KPj4+Pj4+IEJ1dCB0aGlzIHdhcyBhZGRlZCBpbiByZXNwb25zZSB0byBt ZSBwb2ludGluZyBvdXQgdGhhdCBjb2RlIGNvbW1lbnRzDQo+Pj4+Pj4gYXJlbid0IHN0YW5kYXJk aXplZCB5ZXQgYXMgdG8gdGhlaXIgZm9ybWF0LiBUaGUgYWx0ZXJuYXRpdmUsIGFzIHNhaWQNCj4+ Pj4+PiBiZWZvcmUsIHdvdWxkIGJlIHRvIGNvbWUgdXAgd2l0aCBhIHNjaGVtZSBmaXJzdCwgYmVm b3JlIHN0YXJ0aW5nIHRvDQo+Pj4+Pj4gbWFuZGF0ZSBwbGF5aW5nIGJ5IGNlcnRhaW4gb2YgdGhl IHJ1bGVzIChhbmQgaGVuY2UgcmVxdWlyaW5nIGRldmlhdGlvbnMNCj4+Pj4+PiB0byBiZSBkb2N1 bWVudGVkKS4NCj4+Pj4+IA0KPj4+Pj4gSSBkb24ndCB0aGluayB0aGlzIGlzIG5lY2Vzc2FyeSBz aG9ydCB0ZXJtLiBJdCBpcyBlYXN5IHRvIHJld29yayBhDQo+Pj4+PiBjb21tZW50IGFmdGVyIHRo ZSBmYWN0LiBJdCBpcyBhIGxvdCBtb3JlIGRpZmZpY3VsdCB0byBnbyB0aHJvdWdoIHRoZQ0KPj4+ Pj4gaGlzdG9yeSBhbmQgZmluZCB0aGUgcmF0aW9uYWxlLg0KPj4+PiANCj4+Pj4gV2UgYWxsIGtu b3cgd2hhdCAic2hvcnQgdGVybSIgbWF5IG1lYW4gLSB3ZSBtYXkgcmVtYWluIGluIHRoaXMgbW9k ZSBvZg0KPj4+PiBvcGVyYXRpb24gZm9yIGFuIGV4dGVuZGVkIHBlcmlvZCBvZiB0aW1lLiBJdCds bCBwb3RlbnRpYWxseSBiZSBxdWl0ZSBhDQo+Pj4+IGJpdCBvZiBjaHVybiB0byBzdWJzZXF1ZW50 bHkgYWRqdXN0IGFsbCBzdWNoIGNvbW1lbnRzIHdoaWNoIHdvdWxkDQo+Pj4+IGhhdmUgYWNjdW11 bGF0ZWQsIGFuZCAtIGZvciBub3QgYmVpbmcgc3RhbmRhcmRpemVkIC0gY2FuJ3QgZWFzaWx5IGJl DQo+Pj4+IGdyZXAtZWQgZm9yLg0KPj4+IA0KPj4+IFdlbGwuLi4gU2Nhbm5lciB3aWxsIGxpa2Vs eSBwb2ludCBvdXQgdGhlIGlzc3VlcyB3ZSBkZXZpYXRlIGZyb20uIFNvIHlvdSANCj4+PiB3ZSBo YXZlIGFuIGVhc3kgd2F5IHRvIGtub3cgd2hlcmUgdGhlIGNvbW1lbnRzIG5lZWQgdG8gYmUgYWRq dXN0ZWQuDQo+Pj4gDQo+Pj4+IEJ5IGRvY3VtZW50aW5nIHRoaW5ncyBpbiB0aGUgY29tbWl0IG1l c3NhZ2UgdGhlIHN0YXRlIG9mDQo+Pj4+IHRoZSBjb2RlIGJhc2UgZG9lc24ndCBjaGFuZ2UsIGFu ZCB3ZSdsbCBjb250aW51ZSB0byByZWx5IG9uIHNjYW5uZXJzDQo+Pj4+IHRvIGxvY2F0ZSBzZXRz IG9mIGNhbmRpZGF0ZXMgZm9yIGFkanVzdG1lbnQgb3IgZGV2aWF0aW9uIGNvbW1lbnRhcnkuDQo+ Pj4gDQo+Pj4gVGhlIHBhcnQgSSBhbSBtaXNzaW5nIGhvdyBkb2N1bWVudGluZyB0aGUgZGV2aWF0 aW9ucyBpbiB0aGUgY29tbWl0IA0KPj4+IG1lc3NhZ2UgaGVscC4uLiBDYW4geW91IGNsYXJpZnkg aXQ/DQo+PiANCj4+IEkgdW5kZXJzdG9vZCBTdGVmYW5vIGZvciB0aGlzIHRvIG1lcmVseSBiZSBm b3IgdGhlIHB1cnBvc2Ugb2YganVzdGlmeWluZw0KPj4gdGhlIGRldmlhdGlvbiAocHJlZW1wdGlu ZyByZXZpZXcgY29tbWVudHMpLg0KPiANCj4gUmlnaHQsIHNvIGF0IGEgdmVyeSBtaW5pbXVtLCBp ZiB3ZSBzYXkg4oCcVGhpcyBpcyBhIHJ1bGUgbm934oCdLCBhbmQgYSBzdWJtaXR0ZXIgd2FudHMg YSBkZXZpYXRpb24gZnJvbSB0aGF0IHJ1bGUsIHRoZW4gdGhlIHJldmlld2VyIG5lZWRzIHRvIGtu b3cgdGhlIGp1c3RpZmljYXRpb24gZm9yIHRoZSBkZXZpYXRpb24uICBUaGUgY29tbWl0IG1lc3Nh Z2UgaXMgdGhlIG9idmlvdXMgcGxhY2UgZm9yIHRoYXQuDQoNCkFncmVlDQoNCj4gDQo+IE9idmlv dXNseSBzb21ldGhpbmcgKmVsc2UqIHdlIG1pZ2h0IHdhbnQgaXMgYSBtb3JlIGNvbnZlbmllbnQg d2F5IHRvIGtlZXAgdGhhdCByYXRpb25hbGUgZm9yIHRoZSBmdXR1cmUsIHdoZW4gd2Ugc3RhcnQg dG8gb2ZmaWNpYWxseSBkb2N1bWVudCBkZXZpYXRpb25zLiAgR2l2ZW4gdGhhdCB0aGUgc2Nhbm5l ciB3aWxsIHBvaW50IG91dCBhbGwgdGhlIHBsYWNlcyB3aGVyZSBkZXZpYXRpb25zIGhhcHBlbiwg SSBkb27igJl0IHRoaW5rIGFuIHVuc3RydWN0dXJlZCBjb21tZW50IHdpdGggYW4gaW5mb3JtYWwg c3VtbWFyeSBvZiB0aGUganVzdGlmaWNhdGlvbiB3b3VsZCBiZSBhIHByb2JsZW0g4oCUIGl0IHNl ZW1zIGxpa2UgaXQgd291bGQgYmUgYSBsb3QgZWFzaWVyLCB3aGVuIHdlIHN0YXJ0IHRvIG9mZmlj aWFsbHkgZG9jdW1lbnQgZGV2aWF0aW9ucywgdG8gdHJhbnNmb3JtIGNvbW1lbnRzIGluIHRoZSBl eGlzdGluZyBjb2RlYmFzZSwgdGhhbiB0byBzZWFyY2ggdGhyb3VnaCB0aGUgbWFpbGluZyBsaXN0 cyBhbmQvb3IgZ2l0IGNvbW1pdCBoaXN0b3J5IHRvIGZpbmQgdGhlIHJhdGlvbmFsZSAob3IgdHJ5 IHRvIHdvcmsgb3V0IHVuYWlkZWQgd2hhdCB0aGUgaW50ZW50IHdhcykuICBCdXQgSSBkb27igJl0 IGhhdmUgc3Ryb25nIG9waW5pb25zIG9uIHRoZSBtYXR0ZXIuDQoNCk1heWJlIGFncmVlaW5nIG9u IGEgc2ltcGxlIHRhZyB0byBzdGFydCB0aGF0IGNhbiBsYXRlciBiZSBpbXByb3ZlZCAoTHVjYSBG YW5jZWxsdSBvbiBteSBzaWRlIHdpbGwgc3RhcnQgd29ya2luZyBvbiB0aGF0IHdpdGggdGhlIEZ1 U2EgU0lHIGFuZCBFY2xhaXIgbmV4dCBtb250aCkuDQoNClNvIEkgd291bGQgc3VnZ2VzdDoNCg0K LyoqDQogKiBNSVNSQV9ERVY6IFJ1bGUgSUQNCiAqIHh4eHh4IGp1c3RpZmljYXRpb24NCiAqDQog Ki8NCg0KV2hlbmV2ZXIgd2Ugd2lsbCBoYXZlIGRlZmluZWQgdGhlIGZpbmFsIHdheSwgd2Ugd2ls bCByZXBsYWNlIHRob3NlIGVudHJpZXMgd2l0aCB0aGUgbmV3IHN5c3RlbS4NCg0KV291bGQgdGhh dCBiZSBhbiBhZ3JlZWFibGUgc29sdXRpb24gPw0KDQpSZWdhcmRzDQpCZXJ0cmFuZA0KDQoNCj4g DQo+ICAtR2VvcmdlDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon May 30 13:38:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 13:38:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338583.563372 (Exim 4.92) (envelope-from ) id 1nvfau-0004A1-8H; Mon, 30 May 2022 13:38:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338583.563372; Mon, 30 May 2022 13:38:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfau-00049u-53; Mon, 30 May 2022 13:38:04 +0000 Received: by outflank-mailman (input) for mailman id 338583; Mon, 30 May 2022 13:38:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfat-00049o-Cw for xen-devel@lists.xenproject.org; Mon, 30 May 2022 13:38:03 +0000 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9fcd834-e01d-11ec-837f-e5687231ffcc; Mon, 30 May 2022 15:38:02 +0200 (CEST) Received: by mail-wm1-f45.google.com with SMTP id p5-20020a1c2905000000b003970dd5404dso6461600wmp.0 for ; Mon, 30 May 2022 06:38:02 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id o15-20020a5d58cf000000b0020d02ddf4d0sm8911403wrf.69.2022.05.30.06.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 06:38:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9fcd834-e01d-11ec-837f-e5687231ffcc X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ytl48+gf/9+wU974bliYN68rRr9GC5CbXhv9Mqbfs9Y=; b=YdZaz5w33RPx039qBKJ7d5prxhkCMteIiE0jQXjnrlOPJ3xfWqisgmfOU2qpMv0Vo5 qd8CwG0jRlWHAiRVaKPA2UMVRutRiBIia5QX/o1lvcSkA0lju1D2aIvKQU9RjBR3D4s5 XQe+jedl0E1C8gPF6KYO02eqiljWjyzxo9HHK0YoR7LVcLT8LYO+26JTyknkgks4OWb2 G2PlB1QQmblWoWLEWuF595q4LDQtxoSj+2LiTxh6nrV6EN504w/PHHHVP6SVz3GiBSzd EBeKNkADPkSDCM1essizvRCzCU4KpLHOBLIjZ/x+zBaZqd58rl44p0mwGIbgu7gd46Pj whOQ== X-Gm-Message-State: AOAM532shIGhVpbH9KU+iW0EpdKjDR4HUqkahVlyijhAd2bA6WuZgVBg vepIIA6AHXLpBbTuaF6paWg= X-Google-Smtp-Source: ABdhPJyoFBGlSKlV74jeFHZeQEIiKD71BnJBLmLRXZanLlnEJT/DxNOlAxTa51VmVdIsBUKX2lv0Kg== X-Received: by 2002:a1c:4e19:0:b0:397:7b13:1bc7 with SMTP id g25-20020a1c4e19000000b003977b131bc7mr18980855wmh.114.1653917881735; Mon, 30 May 2022 06:38:01 -0700 (PDT) Date: Mon, 30 May 2022 13:37:59 +0000 From: Wei Liu To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH] xen/netback: do some code cleanup Message-ID: <20220530133759.mpwhh744l7miszbp@liuwe-devbox-debian-v2> References: <20220530114103.20657-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530114103.20657-1-jgross@suse.com> On Mon, May 30, 2022 at 01:41:03PM +0200, Juergen Gross wrote: > Remove some unused macros and functions, make local functions static. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Mon May 30 13:38:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 13:38:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338590.563383 (Exim 4.92) (envelope-from ) id 1nvfbE-0004g3-LG; Mon, 30 May 2022 13:38:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338590.563383; Mon, 30 May 2022 13:38:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfbE-0004f6-Hi; Mon, 30 May 2022 13:38:24 +0000 Received: by outflank-mailman (input) for mailman id 338590; Mon, 30 May 2022 13:38:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvfbD-00049o-93 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 13:38:23 +0000 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6242a71-e01d-11ec-837f-e5687231ffcc; Mon, 30 May 2022 15:38:22 +0200 (CEST) Received: by mail-wm1-f50.google.com with SMTP id v4-20020a1cac04000000b00397001398c0so8412387wme.5 for ; Mon, 30 May 2022 06:38:22 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id u2-20020adfdb82000000b002102e6b757csm5331680wri.90.2022.05.30.06.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 06:38:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6242a71-e01d-11ec-837f-e5687231ffcc X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KsAtagss1zN3OoHQ7StI415A2RqFxEh/FfqiDwV3lwg=; b=EzgFPSO7VN8io8cVTJxOcKTm6zR0nXxsZED7aCFaoDH0yxbW+vYH/F4PUWeGkoRFN9 0bP452jOG1VQIFYSQDWuYPyNQHaGLbXUaBKVYX0+aauposdJ9+KPEADTzzNdEnATnF86 48nBlAZrMQpYzkI6b0LHmYvjKumKwCIi+IzyLqQSRr+QY16nEdVjqHVc0EQi6MFt6uHT ybXZjnt7EzVwBChnykOvc8lzasQB+o1pHdc/lChyAzaemZHmu11kvmSexTNP3aCei4EQ icmwBtiyzah+zMdxjAkE6OCZr7LRA1XmxnN/kKD1L/2R+Jj/W7rdnee8uj6oynVqQ5lO opqA== X-Gm-Message-State: AOAM530XCko0s2ttbl2m4dzcpumkTIC76u5bWKT4hw6B5v/YqnOf95O7 4R+Iz5sKj5y2GcMHOFEZFjY= X-Google-Smtp-Source: ABdhPJyLAdckxSBuBL1xhlfS9GVoNCXS4Kx15kZbX2/pn3pGdm0f8N7kwpIgiWG6jbtRdSs4v7MPfw== X-Received: by 2002:a7b:c1d8:0:b0:397:337a:b593 with SMTP id a24-20020a7bc1d8000000b00397337ab593mr18979837wmj.96.1653917902170; Mon, 30 May 2022 06:38:22 -0700 (PDT) Date: Mon, 30 May 2022 13:38:20 +0000 From: Wei Liu To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jan Beulich Subject: Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Message-ID: <20220530133820.5mbjaavusxdhv25c@liuwe-devbox-debian-v2> References: <20220530113459.20124-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530113459.20124-1-jgross@suse.com> On Mon, May 30, 2022 at 01:34:59PM +0200, Juergen Gross wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross Acked-by: Wei Liu From xen-devel-bounces@lists.xenproject.org Mon May 30 15:00:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:00:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338607.563397 (Exim 4.92) (envelope-from ) id 1nvgsu-00059v-Oz; Mon, 30 May 2022 15:00:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338607.563397; Mon, 30 May 2022 15:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvgsu-00059o-LW; Mon, 30 May 2022 15:00:44 +0000 Received: by outflank-mailman (input) for mailman id 338607; Mon, 30 May 2022 15:00:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvgss-00059i-Rb for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:00:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44c6193c-e029-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 17:00:41 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-0rfaCbR2MTGTPkQr9F_vLQ-1; Mon, 30 May 2022 17:00:37 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7887.eurprd04.prod.outlook.com (2603:10a6:102:c9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 15:00:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 15:00:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44c6193c-e029-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653922839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+eMOcavInhpZ/aGuDRQaMmU0mk+yxn+z1BP4TPQ6TJo=; b=VmYhykWvINVgqxFB9QH8nUxquBFXZVC5NcXhsQooRjckkHN83Ffotih6vADm1EmkYIi4H5 91AKhCmFXEqoRXCtMzLfM0bZSUQ/BNVPOZnzVAPP+3pX8UtLPkednudjhNO49W/QR9NdnZ EQll48im+IsskEhRLS58Pp29tAdmQhY= X-MC-Unique: 0rfaCbR2MTGTPkQr9F_vLQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mcpCnT1E0/yQqr2ozRJ4kbzszNjb75JUZCia/c70rFHO5DBJgzbQUbjwkWt6eUBd3+ggDZQKlcgugfz0sDxZtCn0h42ypB4HX6GyZgIK/hiNXEKPRTqq0wyjqttpfFijScS2yHmoZTOuE0X5JJNm89E0CfHwcFD0eCCyvGiMh2HDchhw8L3OKS+IkQUJ4uC6APBI2S2XywF2WtbKDw3W/x+R+APWt8H3l3Iy54HTeUkuq2gfYKlMsGQqUUlaat07qcdnT5ZesBKU3rTKRjBEbEIq50ItGALAYfLczzyAwE2sVdNy5HRLQJmHonvktKa/g1BRMWXjeafJMJqsxFJGXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aFZnTIPSQmrjSCAVP9r3zLYtol5eD79EffaNGwY4bp4=; b=hjLJ8J1y103P83PI9N2Joizyo8cFEougGtWoqDs+w+l5r4oISHrFX+7pdAOo2J+7M734bX45rHpW5clPgFYnHo8S9mE7pPHkB3nzbGYD8aMA0S35ES+fPsFaHogoxBI6yTcaTlX7ePn9ZHiLhKL5LSfeyMqxQYK9enAfYVdA0IMhvd7oI0cbMOdS0x602D0qwhmg3lpd+Xz6OgVs79FC4g9PCE9JpUTm+K0RlguPhVYrdmJZxy81dv8t6851FTvzYKdhDjGL0cWUYfZtP3rKXM9TrtmJcYNIkcvlR/DlocShapprx4VGYbvcJ9CzeKUzP18monKVBG9DK/t2xd0cWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 30 May 2022 17:00:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/5] x86/ler: use feature flag to check if option is enabled Content-Language: en-US To: Roger Pau Monne CC: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220520133746.66142-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6PR10CA0034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::47) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3edb94e-0947-404c-d513-08da424d2711 X-MS-TrafficTypeDiagnostic: PA4PR04MB7887:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W+Z4hBDWA75YLdjxM04Ux4+j6q3ZTc3sUOQbnKV+hrCHjaYC69lr9rF3r7Ley7M2Mi8dwulXMxNHbJ4Xd9V5vYEphU7mu+nNrn08UEBltt1O7pxrlGTJnT9kXpMvzgXxucV/SLRng6HX6DcypsGhZL+VjTAm7B5yozyHEro7AXQO3ZEt1gPk0RbJY87B7c3AIN3oSN3snpnIUVm/0bjIg5iIOpxFXnCsMXsQOVm2g782DuD7yB/UzXmKdLYjrlwegBsuUeSKgiXPAvu97ez84wxjbjesFXAvXXH/ud5u+IsAvUFWddYn29cJyKM2Dj4NurHunozlTyTsKG+K6TImQpj4hymo8kRNxTxTiang/+XcuAGJMGmt/VYfA2xKIZfnI0oc2Yny+RK1Dm/c2x6HIZ5kc+cRn+5F4XTA93Bql8xYMthqJ44Iy5QI9vkL3vUVyis8VD7eKW3IVfPkJc0cZwx+QUoy/XHlCV3Z1CNqc9sWk7NhHT4rEm/sYaiH8e8Ax9mPBzoZw0oj0B0ZmXwanyxoaSaxEW9oUO9muk4T2XTTCe8FNMe0pANdAQ0XxoEObfpRkGHJR9thAFPqa7Nq+ZooP0bHZ9j+HmSjYZwfoy6yiX1gFv4syKrAwFx9FYVZFz4glQQ4gWqIa7S8rEyPg8Htv+2Nwet7WwteC9/XqzAw+0q3Ckt3RSWZp1oG3e5D0w5AKLFBKYBxfOgCLUafGuIyBW3CuHv3H2EOHp2Vpf43YXA/Mt1buAzh/KGedBh5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(4744005)(5660300002)(53546011)(6486002)(66556008)(66946007)(8936002)(6506007)(86362001)(31696002)(26005)(6512007)(2906002)(38100700002)(2616005)(186003)(31686004)(54906003)(4326008)(36756003)(8676002)(6916009)(316002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rfLpqYMJGKOpk8WSPhV2X3w/MvAg0d/eBZRXINqkrNXQcmQLPjtKccC/krlZ?= =?us-ascii?Q?m4TitewloEQYGsCj84KPJZ1ucr9jQRuDJXUjJFPg1rMCH44r6LJb4dU7a+Vf?= =?us-ascii?Q?/dSVALSoyLlft0QfHfBLMQ4ayI+7NncTEa3LBH8/n+kXGOlRqrKv66RzRHSA?= =?us-ascii?Q?pakypjcrZIzo5Xo4/x/0stgLlyCZb2vuQIIZxh5EAsU5rEnRtXphJfH64Eb6?= =?us-ascii?Q?PBjrMsiFYG5/ubxhNHkSZRSQCJT/mysCOwSwrgKCjyRhVDhomNISOMvE4QEI?= =?us-ascii?Q?MtU3CR0DhMCGOKhF57MT7XSsrIGIDjk1lKvYK5890O+ao6fZjjrbvqd5WTQ2?= =?us-ascii?Q?WjIo+EhUDbxdWiPgiZnGa80Q6hzfgHjwpdDDm8PzPZ39mKi/Kf9ub4SDJ5AD?= =?us-ascii?Q?R/CeP0zftmMYdfkt2XlDcrS9qsVirwKj10l+RqRlySvNnVpB4cLdWSIJdBZn?= =?us-ascii?Q?obQeMIH8Hnz83xDABN1U9YjJs9i+V8APmT1XUlVXTrAbI0XA5ewlgiH08jtZ?= =?us-ascii?Q?HdbidQ38pY8/b3BkQHUTaenaBE6thIK4adab5pmUBzaKXe5LArgrA7ud2Oyt?= =?us-ascii?Q?L7q2NjD2ys8uesj6uyVDwzV2s7Svn0xFuGHDe9iv/+jEfxshmUhEW9sZaFcA?= =?us-ascii?Q?yYnUi6Dr6oQ3uK6BhZsUOpd/haVnwTgoD9XGpq8ijkHtuTZ9wzppuI6xJU4f?= =?us-ascii?Q?RH7+DCMddnF59LEZMmCwNAzC9CT8pM+omfCQYN/cSGkKOOEHA5L0N2TkYOop?= =?us-ascii?Q?j9GWduN62F9xh+2eri2VqH5m3xRQZmCcwEbdTDEFY89mUstDfvjCz0NAFa3y?= =?us-ascii?Q?opW5gzO2O6rpXrKCUqzGAbG28IKm4YFGIQGJLN4bB7k2+l1tjWyvxkCH4HMe?= =?us-ascii?Q?L2zc3y91kk9QyQ0M2Ik3WuilKSwSo28ovx2DxzZ82xJI39FSKneFgInQ5CKI?= =?us-ascii?Q?FLpL8885Z0FTy5UwWlD9iurthN3YR4fcDhD6IxlIvfmWhTSaT+ARqWogZ+M2?= =?us-ascii?Q?BBSvNLVlHkDXOBhtFgsbryqG3zD3UocBR4djJmIDZg1JjzH0mGC8HU6k/Wt8?= =?us-ascii?Q?2DWzfYM250KBvsC0LyZcfhb6H+lHTt5mqgFXOYDQXxCS/ZClUrfvoeQu0QLL?= =?us-ascii?Q?e3ig30TFKmAkNYjTbdMgPTXO7G8OdeOCX/YkEERR1jtePkxWJ6Z24SV2EG7B?= =?us-ascii?Q?NqrrSLSHT4GpRLlblZcG447x+69l+FkXOITpbPS2mm9dVODX5lnOIKzmdDpo?= =?us-ascii?Q?hvdPtwJQ14w/BDRGTLhzwNt8qPCvwgWhtXSdLpHtQIkWj3W5mDe1FlNzljNF?= =?us-ascii?Q?7AlgfkwYoOz+JHgB5KklEtoX7fW5SjvBZcj+oRIRd0S2ixR0jZVUW9WSwiIf?= =?us-ascii?Q?0bGmq4zhHle9bASzA1ntwOKWGiZtOGE+8k+eST6p922KwxaeHushYZum/SpC?= =?us-ascii?Q?DOtK4It0/1E1w154hiEPyxZP8TX7JD1CoD7+DRFNBgfwDcXXyR5EpxkRf8B0?= =?us-ascii?Q?WYRocGrL3kRcZrNoXbS6+V/5ZC7YnaGs2ml6U/PTQVjxbE8niMvB+SQSnsaq?= =?us-ascii?Q?YJeEKqu6j5DNfBWU5hiuR+/W46c1iT4345eR/P+eh4mjAF1S0LNWVWLBvxBL?= =?us-ascii?Q?8gSC22C/RpD+AeuDGdKyX3TzFvG3mrTYMq8z6ypxYLC1+T4b1kUMRolmrfpS?= =?us-ascii?Q?lO1IXdat0Fz0yTi7wAJyjtx4MWWnn5/+xnzzCfSUAeR1fExgI5+qQCOvmmp2?= =?us-ascii?Q?qhDpfybVvA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3edb94e-0947-404c-d513-08da424d2711 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:00:36.3772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O+IiBSNSDdBdRUikaFTHRi55WnfANY/Ucodt5L7F5mq9Z1xnv4JjISiFDM0YmknCdwiGYsgIxbeDyBHujh46Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7887 On 20.05.2022 15:37, Roger Pau Monne wrote: > It's more consistent with the rest of the usages of cpu_has_xen_lbr. >=20 > No functional change intended. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 Acked-by: Jan Beulich I wonder though whether the use as a conditional in percpu_traps_init() wouldn't then better also be replaced, for being consistent. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 15:21:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338616.563407 (Exim 4.92) (envelope-from ) id 1nvhCh-0000rG-E8; Mon, 30 May 2022 15:21:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338616.563407; Mon, 30 May 2022 15:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhCh-0000r9-BJ; Mon, 30 May 2022 15:21:11 +0000 Received: by outflank-mailman (input) for mailman id 338616; Mon, 30 May 2022 15:21:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhCg-0000r0-2R for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:21:10 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20617a68-e02c-11ec-837f-e5687231ffcc; Mon, 30 May 2022 17:21:08 +0200 (CEST) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24UEFH2I029805; Mon, 30 May 2022 15:21:06 GMT Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3gct621q5d-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 May 2022 15:21:06 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by DBAPR03MB6389.eurprd03.prod.outlook.com (2603:10a6:10:195::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 15:21:03 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::31b5:dfd5:2d38:c0b2]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::31b5:dfd5:2d38:c0b2%9]) with mapi id 15.20.5293.019; Mon, 30 May 2022 15:21:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20617a68-e02c-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2CltKxWZkCNhVnxjNdqtO7Pz9X9fo1tq75UJ9Nd8PCmkPFFTVo+zKdHfuzDePkE9XtP9xfLQuXwSr6x8WuLjR6mUtdkgji3FT3RpJy741EyfVKM9Yow15OG5KVi5t7VTy8q6btfz4wxaciPTp+HQ4m6MJypTr1jZIk44gH/m0/ut2GSEBD35YDrLm2984rDWML3QafYJxmKALdWd0ZRRAQy5OlBMOFc8wREQEMUZQSlncguPJaU/DJE2LMVOxXoCI4ZFbgQgBPH7dZd8CqVdDMgQ7FMlrduixqQqAgIzGPttHjpr/YoJlJxvE0dCIJD94amqjw9IGoJSZs9rP1/Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eK9WCHv2vArtOO0GW0SO/fwPV4IVBTjAHIutp6+unPo=; b=a5xxtfWJwWhZHUgNIZOgEY6NUleduD7iTnVchWfbQbKa2ahmbtuN1Niro/vRPWsRCP+MxMbJbGt2bXdZfTZ+UXk6pyhGU0zFtQttRJJD7kVqjmOoN4Uw7TjC4k58isSeOGepqjBFKl2W8khXgJfoY6Zq3Xtc4zmDLrIxbuTNjR5mks5V1csDqz7sgulI8mrWmqlCKYEC99EPSt2F3GODkj+F0dDpCYhv1Po4USPE8yKu4MnuPc2WK48cglKYj8Vwu0/tEIE4yDAVfCogmQX4jzzij2ZFnK4OTAs9TY8s2+pPMkfki9IqkgYez07bmOfXuanwjfXJf9xOBLWWLOlXPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eK9WCHv2vArtOO0GW0SO/fwPV4IVBTjAHIutp6+unPo=; b=I1kCmX3+u3sqMyv60e9IvIOz/+ZbB47O/bYQIdZMeWrWTqAeBlO1l7FX1dFL4SvlRifPJh5ROX+pPlqlysj1CMJULGwvob0PaDI9/OFq7okJcwy4+Iiet7bhYC5Xtrw5+W1HYu0DlooPGAOMRdA6Lop1F6JSNIuB8hcP9MXItiMbYaHG2wTBll6RQp26Fnvv8ajzUgcusDMAbe2jRE8ADoOZ7lVLvEsodT9NQB1N8pT/xlO+R4fdk86XFRxUHNeehS+juNK1gZ3nkbXIduGHgWQXBIBjMu6AMPqSlCs+fbq+VdZSymLf1TxpVmtLbVM0UNFp12hmyLwTGnveNpsQYQ== From: Oleksii Moisieiev To: "xen-devel@lists.xenproject.org" CC: Julien Grall , Peng Fan , Bertrand Marquis , Oleksii Moisieiev Subject: [Xen-devel] SMMU permission fault on Dom0 when init vpu_decoder Thread-Topic: [Xen-devel] SMMU permission fault on Dom0 when init vpu_decoder Thread-Index: AQHYdDjfc3Z/1SeAUE+eDUzXC1OEPQ== Date: Mon, 30 May 2022 15:21:03 +0000 Message-ID: <20220530152102.GA883104@EPUAKYIW015D> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f4172b5-a17f-420a-b2fe-08da42500266 x-ms-traffictypediagnostic: DBAPR03MB6389:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: evJqUCON4+N8dWbtcXDtyThAzei7QJWZLURW5oXjB7aFWOPpq1QtsemeMdxYkBa8ZAzh8I//N0BSzfJuOI/vHtNbxCF3c9LOpIcNenKiq6KUQpxmxwebHE7ucTOA3RvxBKVPQkFvtYM2XBXtBSzrN9AjoOC9qMvBMFab8AZPWk11lS3qFALwqOC9NqjGpwed1Jt19WwRKu413zFUeTJ3ISDXSRzzUGK3eEZXWScUsvoW+TU915fZ4Zqng6zczr1WPtv1yDCLnne+T967h8K1E7NGap61VsoyOyYeOk6F+Wmw7O9EMSAjXSXqmCrGixGEGx1II8h4eWFzIw2RiEGzHKFm5rREjlYykNbXRs1Jg7pPC1ymDQfdsgRpuTTKgRtqONlY/l7NMjjlIl82FQFwLEB2qYJVGP6sMB1QebFmBY9JwqnAmmmnNSjDGWJkX76Vqgt9PMB+GinqMHRF0EN7QThEDA/psvi/5B8j/qHNKWUsYHpcWRPHy3svp9dYRceG/NUgK85RHhWAz+Peq1dXXfjsUVJU/DaHpWtevLWZOqqlLOr86khyCvy/FurQ2LZ7mxtthFzUCdWt//NL8L2P0YiE3KU3TgjeFAn5Uh6Uri57Ut5dtNgwbYSCd6yIWQ0L08frcgVKewykVHIRGzV3OxGUsPtiO7EAntO5CCEN97pzhGgCMPlB95MLBUBK/Jmrtl0szO0ytA+bhdDrBVQ9bWKKw47GhWrYaYLuMSNOcQMZURo2u2f1IQiDVBkmXN8rsOZcrlNgOaFjoRPPezTD9d66zWMlAcH7DRIk9gZIgas= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(186003)(1076003)(107886003)(8676002)(316002)(4326008)(54906003)(6916009)(66476007)(91956017)(76116006)(66446008)(38070700005)(71200400001)(66946007)(64756008)(8936002)(6486002)(86362001)(966005)(6506007)(508600001)(33656002)(5660300002)(33716001)(122000001)(9686003)(6512007)(26005)(66556008)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aP/lH3G2zp/pKTv+5shiqVOPkPIfSGooajfZvUyATFtW65r0Y77Ckgu57iCl?= =?us-ascii?Q?V3AjHrdv74lV5qMzlysI+rtqu1GUakfiGFT7CaJUfQ8tRgfP0ARkn2iW1FBA?= =?us-ascii?Q?nW70Rf42tqKqfw8M9lAvvDNm+4p+Ur/swNRgkN/YMxWiilHH0A63l2ruP/Db?= =?us-ascii?Q?ML6Tz2Mr9C9AV+Co72hXpvimTUcaGacCEUVOaJADCqxprjBf0yVsXr+QYkmQ?= =?us-ascii?Q?T/gWckphJS7qv9nLgQS79LVwloj4ESWsgUhU02MKluVU5+zCgnaCWscHnfEe?= =?us-ascii?Q?qum43PTLcRxguc3Mw/EkSaTriwqeEY4dr6+rOu71vRscSSUNI1p2cIAlJtrG?= =?us-ascii?Q?fHzbTIEr/TYS/iJsci7h2DAdylethrN6ZYJjWANFXU5oC6vtNUr8QK3/zRB7?= =?us-ascii?Q?iQuT5e44FYYFNuaBChHFhUMO+NtNF7umb0k2o8wSnIpEyHxIfKvzpdat1zze?= =?us-ascii?Q?01NJSzkvUG5qAhw3ToASkFzrW+W7cdcd3kFf6c20kLqjfb+/ABj+H38s9eIy?= =?us-ascii?Q?UB/IELqxJli9v0L9JjkY8RGI+bJJ/uSXzqeOk5UNaaz44tlpTCJ+AcK2jRPA?= =?us-ascii?Q?cbEOvJpO9uAJapDeGz2ykLx4/k6Nr8Dj8FHsc13DNNDJcu2RQg6OpBmEXBfL?= =?us-ascii?Q?NXl7kbb6QWAYSlscyd398CNySLTXbDzixabqZV1O4AvMhkWRJR9jEl80rQMR?= =?us-ascii?Q?qxbFCvgB8Bs0szPV/UcYItpONfk25lM7GaK/UXNPgBZ+l2EO/sQscwr7rzxj?= =?us-ascii?Q?F4IQr6IjYW3QKnbRQTDFmrF0FqoxYHdKqO47TpYf7gdGNFa2TCOF9tGV3FQD?= =?us-ascii?Q?X/Z8/8xQ4c+zvP4irhBJ088Ich+NoQ4fjCQ8ut3LdRtrx/BrQlK1rlDIWO2S?= =?us-ascii?Q?a9F7oop80RNcfYtr4z9fSm58hQ6HsJVOf4qn+qU4mTRxOBSNgSGFIUJo6Buf?= =?us-ascii?Q?XJqFY8GdryKaG1I5bwghhwd55GkHAwIONs9YZ29f9LnCsMQAvHZeBOKgByKQ?= =?us-ascii?Q?PiTRcg/UGfjwJIRLa3ejjJiRAspGToic09/eDz06nTrRvpLPMaRpHrD7mLyz?= =?us-ascii?Q?Q56z+E0M5js8mVUCjpY950hhBxEl+1gq+ho1tR5Phe2kKn1Oyq9zulcisXdi?= =?us-ascii?Q?ix/M2xKH/uX9HTpsYjPTQVmKdOUAzu8k1GCCP4wNpdYcag9zEOiOZHMdldv7?= =?us-ascii?Q?p3tMO+AGulWXNtQLCWc8qTZKoGwfIEwAFpoyOHoTLdbVLTyd+hC/OgY3Xp2p?= =?us-ascii?Q?5dMh8Xd0t+Re8Z6djEyYoTEkdLtjho1N5/VwoxkEzePas4+5FTxFKT2xT4Cj?= =?us-ascii?Q?IkhQ+vrgVt9Jluj0CMGRhl+RyEVbK0M6/VxYwEKfwF9/ibigjXukzBZLOopa?= =?us-ascii?Q?68GHBJKWBSFaAOu8gjUUKJZ4UkT65hVeYTTghtrPRKcBlE1ZOLYvYW3oAxuk?= =?us-ascii?Q?Oe246ltAs9F/Ufp3TNxCk6ZeqgHyQewD/kZCS4/YK/IlJqAmtgzkCbYPSXwl?= =?us-ascii?Q?kdQz+T6y0HIO4K8/PXOMx+Lyr0cOneT3XkrJUWTHWs0KR8Ngxjw3oaLdoCxH?= =?us-ascii?Q?GF1qgrFYqpACqM9CReAaeZybkNymbceWZbnh3XpSlTsQ20W3VhsFkvWSTh5c?= =?us-ascii?Q?/DlsdMAVfesH7x4YFO9vHbxIhw3gjBYrZEA2hNEa51oq3WIeJdt6b9dULLnM?= =?us-ascii?Q?EOSpYqMAauJN8/4JgbdUV4ZUfU3kbQMnYZJu8kvyb9X/G+bvbNpK8/qah+DK?= =?us-ascii?Q?5oEwfbvxG+V04kIn9IvCNuY3p4VkKdnkfChDuzERNcUZvRQVGk/0?= Content-Type: text/plain; charset="us-ascii" Content-ID: <74D2542000AD5C4F8A93073705CB4B9D@eurprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f4172b5-a17f-420a-b2fe-08da42500266 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 15:21:03.0979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W2y9A0cCUyl+nL0rl2eHo2eduWwK2hEkUeSbv4qPx661eG+QMBVNVPqiq76g3dxY+2Lncj4Rb9Fj198b19O6tKgWTAJWL3GJ1FoWU1RJKN4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR03MB6389 X-Proofpoint-GUID: sGrL-VupN3GqprkXGjatCGiXWarH4bys X-Proofpoint-ORIG-GUID: sGrL-VupN3GqprkXGjatCGiXWarH4bys X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-30_06,2022-05-30_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205300080 Hello, I'm getting permission fault from SMMU when trying to init VPU_Encoder/Deco= der in Dom0 on IMX8QM board: (XEN) smmu: /iommu@51400000: Unhandled context fault: fsr=3D0x408, iova=3D0= x86000a60, fsynr=3D0x1c0062, cb=3D0 This error appears when vpu_encoder/decoder tries to memcpy firmware image = to 0x86000000 address, which is defined in reserved-memory node in xen device-= tree as encoder_boot/decoder_boot region. I'm using xen from branch xen-project/staging-4.16 + imx related patches, w= hich were taken from https://source.codeaurora.org/external/imx/imx-xen. After some investigation I found that this issue was fixed by Peng Fan in commit: 46b3dd3718144ca6ac2c12a3b106e57fb7156554 (Hash from codeaurora), bu= t only for the Guest domains. It introduces new p2m_type p2m_mmio_direct_nc_x, which differs from p2m_mmio_direct_nc by XN =3D 0. This type is set to the reserved memory reg= ion in map_mmio_regions function. I was able to fix issue in Dom0 by setting p2m_mmio_direct_nc_x type for th= e reserved memory in map_regions_p2mt, which is used to map memory during Dom= 0 creation. Patch can be found below. Based on initial discussions on IRC channel - XN bit did the trick because = looks like vpu decoder is executing some code from this memory. The purpose of this email is to discuss this issue and probably produce gen= eric solution for it. Best regards, Oleksii. --- arm: Set p2m_type to p2m_mmio_direct_nc_x for reserved memory regions This is the enhancement of the 46b3dd3718144ca6ac2c12a3b106e57fb7156554. Those patch introduces p2m_mmio_direct_nc_x p2m type which sets the e->p2m.xn =3D 0 for the reserved-memory, such as vpu encoder/decoder. Set p2m_mmio_direct_nc_x in map_regions_p2mt for reserved-memory the same way it does in map_mmio_regions. This change is for the case when vpu encoder/decoder works in DomO and not passed-through to the Guest Domains. Signed-off-by: Oleksii Moisieiev --- xen/arch/arm/p2m.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index e9568dab88..bb1f681b71 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1333,6 +1333,13 @@ int map_regions_p2mt(struct domain *d, mfn_t mfn, p2m_type_t p2mt) { + if (((long)gfn_x(gfn) >=3D (GUEST_RAM0_BASE >> PAGE_SHIFT)) && + (((long)gfn_x(gfn) + nr) <=3D + ((GUEST_RAM0_BASE + GUEST_RAM0_SIZE)>> PAGE_SHIFT))) + { + p2m_remove_mapping(d, gfn, nr, mfn); + return p2m_insert_mapping(d, gfn, nr, mfn, p2m_mmio_direct_nc_x); + } return p2m_insert_mapping(d, gfn, nr, mfn, p2mt); } =20 --=20 2.27.0 From xen-devel-bounces@lists.xenproject.org Mon May 30 15:26:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338625.563419 (Exim 4.92) (envelope-from ) id 1nvhI3-0001tV-4A; Mon, 30 May 2022 15:26:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338625.563419; Mon, 30 May 2022 15:26:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhI2-0001tO-Vb; Mon, 30 May 2022 15:26:42 +0000 Received: by outflank-mailman (input) for mailman id 338625; Mon, 30 May 2022 15:26:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhI2-0001tE-AZ; Mon, 30 May 2022 15:26:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhI2-0005ww-7Y; Mon, 30 May 2022 15:26:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhI1-0005AX-L6; Mon, 30 May 2022 15:26:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvhI1-0000tA-Kb; Mon, 30 May 2022 15:26:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X9Q9puGkRJ88iV9TEshLLjGhGpqI0Jdu85UMiKH+dWY=; b=ttaidjAckRUBv2ksOgu6AvE/KU RY3Z8Y2g+ov/g7qYmMa9oX0VW2aIn+2jLh5eSiE5Rhxv7GJAdKWocTVfVS8XfgXClfAcUscJnALvW QKh+eoYulKoB8GpElbt7XkVDi4sWo2ceijrzt3p/tmhS5T316W1P700Uw5jXGZcIHosg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170775: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=b00ed48bb0a7c295facf9036135a573a5cdbe7de X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Mon, 30 May 2022 15:26:41 +0000 flight 170775 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170775/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux b00ed48bb0a7c295facf9036135a573a5cdbe7de baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 6 days Failing since 170716 2022-05-24 11:12:06 Z 6 days 18 attempts Testing same since 170771 2022-05-30 00:40:40 Z 0 days 2 attempts ------------------------------------------------------------ 1928 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 213846 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 15:31:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:31:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338637.563430 (Exim 4.92) (envelope-from ) id 1nvhMg-0003MO-PY; Mon, 30 May 2022 15:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338637.563430; Mon, 30 May 2022 15:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhMg-0003MH-Lm; Mon, 30 May 2022 15:31:30 +0000 Received: by outflank-mailman (input) for mailman id 338637; Mon, 30 May 2022 15:31:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhMf-0003MB-DH for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:31:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 926e95e2-e02d-11ec-837f-e5687231ffcc; Mon, 30 May 2022 17:31:28 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-X8e_HYraMCaLo5M6hA1UrQ-1; Mon, 30 May 2022 17:31:25 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5134.eurprd04.prod.outlook.com (2603:10a6:803:5f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 15:31:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 15:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 926e95e2-e02d-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653924687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4LXyEp60Zou1OM8fr0OM9SFCpu3hxAG+y7HtdMn8/n0=; b=KTeRsxxY4iAWI+MDD4D/tBS0RhqjxUvz15/6e+sAHsMLTxcSjQWN7NEI8CuijUYOz1g4QA L1NG1kauUupVQqlMX6qLgXUI6Ld0n+7KNMyfxNr34TzDzFEJFLkxnKdjQpnEa/zO/LWTrf qgYOV+GJdZYBUx6wkHz4CN1ZTJg95iw= X-MC-Unique: X8e_HYraMCaLo5M6hA1UrQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHCxdiwlupQzP/ERqhMZC71xOLzSbHIUSfAI5LlUQ3YSXxKgIvfU+MayIgx/pSeeFp+ZZ8cwh4m4UoWmZ6mqHRseeOKP1pKmgj31AE39CNOs9RVnsswkWXbdyJfsymACgS2KQook27brr1WxG2WchrqWtT33/mWONeByOJjZ7BN6LMMA0Cf0ncC4Wi6d9n/2jtU/wzpmMpqO3gV0kwnBZTAphJ25dQM1bm4PsnaVo9gyFBl3p7aEg+KCFtdXpWoDXi2GALnJL8/TDguBmsJI0/Yuk08tzZUBxsWXKWjrv3zW5/pkRoWqNTEvYIj3Vlr4OPtgVO+GtBbP0dVRQx6pkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LXyEp60Zou1OM8fr0OM9SFCpu3hxAG+y7HtdMn8/n0=; b=bu9UYjvvbJDgjmJW2iPsmYqcW8/Zhs1+qCuZjIFyHq3pGSU58oKbRoNdL+a6d7F5D0Z/FPFGqsygG1udyVgQm47K1dXfFrmceJMCEC5a8mXDCWFHUv96fJVMJLXX1O6FDHfeYbvzwWTxPY0DH+rWjDhYQfFFOaprwAAt0b1fXDGw9eqLFA0Jtas1DNe/7rW7u3AUNGe/qe0hygsiyCvwKuLaqByxXp1H1dGiwYSFz9CGmL99vQhtTq6S+xmBq136q/G3EQ0OO1M4eSwT86j1e+ZlBsJpYcTSp7dKF6GoaDVxNZBENpxZRgudnPEXmxfIJXu6/vXMjWGGcvyScrfDwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4a193fd4-deb3-12c3-2faf-eed33e7b52af@suse.com> Date: Mon, 30 May 2022 17:31:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-3-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220520133746.66142-3-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0475.eurprd06.prod.outlook.com (2603:10a6:20b:49a::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e618d75-08d9-4520-c615-08da42517201 X-MS-TrafficTypeDiagnostic: VI1PR04MB5134:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K2J+Jbn+LeIxviH2cmKqhq+MZZEx3Q0+C6V6Ge+y2LufP6Q/6wGAMR1wMnzdwNEbC03P4sAdH70WObqEUPda2zEAk+hOFrsGNiUdN2Vgk39qOsgkgQnPDxTEa82aJM1lDG6fw4NJ4uFUC9i+4OuawTlBd090F6IXdDmRyx3wI6Hu6RY0TkXDWzJCZua7Uy847+5CDAAqxIt580+M4olfhLO7Oy6SVHDIFAtvEqLl/avIF+AQyA4HJv0oYL1i33XYlvZfzl2qJ9QQezSLYgdsMwxX7QO3wmV9d9c47n1qHW26wVc0RK2GdHgxFAK1q3nsbBiXDzLCRa0yJ7Mhimoc0vG0VruXzdJty7rgGX5Vvfuop53PToj3PyN9KPHMp+L2jUu6eicHH17fNN0QQt16+VbbepD0VyWG5XVb0AZ1u4wlrePCu5iJIWP5nT40M7rC7ipc+F35iLtMSlqU/wns01ze1bCXpoSdaVi61oqAwH37c6PB20f2TQ3QZ6W7nnUlZ7HeZKiSUEGaUstN4vbX4lSVOnW63dS7W2t9pURqf93GOJVbUG13OEJsA0ZQsQy2HPSo93RlW5jMpTpMIZVa2fpN8vC4b0ji0nJL15ebS5eIaym4fXmqWIQo8zY/7N1A4u6QzSOdJiXACRG0yRxKfAbUKnxX+aVir45yktkEIxBoVFPjAAEn6q1CUpGnVNdQFxy9o/Z0Qzeq4eB0cPTH5JW5R0SvpVgwTYK9VNjC2fVreJta9gjOjDsIn5GgjuS7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(83380400001)(66476007)(31686004)(54906003)(8936002)(66946007)(31696002)(186003)(2906002)(2616005)(38100700002)(66556008)(86362001)(8676002)(53546011)(6512007)(26005)(508600001)(6916009)(5660300002)(6486002)(316002)(4326008)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFVBdzBvWnBMNHdTU0JuZE1KTWUwOHh1Zmt0OU4vcGl1UVRDUFpjTDI1aVVN?= =?utf-8?B?MFprSkFWN3RHRXBNODZlZXIxdE94eVRveUNrMmhpazMvbG5HNVBRK1o4SFRk?= =?utf-8?B?dktaZUVyMlJ2UlVvNEhPL2xtbHRXSENBOVV6MHVCSEdKUU5XMmpOK0xRM0ZS?= =?utf-8?B?b3FkUDc5aFdBNG8veGUwM055U1piditCczlRZlpNd1QxdUZvalZ4RDkvT2Qw?= =?utf-8?B?MDgrZEcydm1xaVFXWmhBSmVJeUVIT0hCTWpyUFN0alhsMmNKVlBrUkpadmFi?= =?utf-8?B?VGYyNG5pNUd6WGtyV3lIem41eVlaN1lhYmhDZ1Ixb082bDFWOHd4UVlkdlZ6?= =?utf-8?B?UXB0ZTBoV0pabTNOblNSRng5cTY0UllraGEybUwrbVNxZDdpWm40ZEtlYTZ4?= =?utf-8?B?d01OZlNOUVdWTkNlQ3pTVVdNcGRReG1HTzRxcnN5SDVPZEhuUFd6a0R5WDJZ?= =?utf-8?B?Q1p4UExVT3QrZ2gyQnA3WmxRMHU2M0lVc2ZLNTJIZ2lMc3dQMDNDTTVqQ2Vm?= =?utf-8?B?QTlXWnYyNlpReE50S0F0SjJRNTRMVnY3UWZWVFRyeUkyVXovY3JhSkdrbFNu?= =?utf-8?B?ZzhZb1Z2QUJDM293SlJxWDdPRERzcEZtQ1hiTTQ5QVpYbVZSUW0xQU16UFYz?= =?utf-8?B?akVlZXZTN2hLUlRSNW82Sm9MSjgxNlFrckJsZDh5MFJ1bVM2M2UrOVVPczNU?= =?utf-8?B?alBpb2FKL29pczV5S0MyZ3hTYXdZeFp4a24zRmgyWVdpNHJCYW1ocnRxVzQw?= =?utf-8?B?RC8wZUdKNnR5R1BwZFd0NHFKbnN3WXdta0d5djE2R0JHd041M3dpV240eFMx?= =?utf-8?B?Mm5Fc2o5bkJzRS9JbVMzU2lqVnFkd0ZxU09TQ0ZYUVhLT2pGdmloVGtGZHhw?= =?utf-8?B?QXl4eUt5YmhVUFFSeDl4ZjYvR1h5bXlrMHI2aVpYTEpuZGN1MmJUWEJjT2hZ?= =?utf-8?B?aHdkeUp0RmpaeXFsQXlraE5QME9hbkVFaHpBcUdCa0ZJOE1ZdUlWVVcwZ093?= =?utf-8?B?SzBKNGU1bGl5cDFyb2p5Unl2ZiswOXU5bldzdWovSDhaUkM5UDkvdlFTL3Bj?= =?utf-8?B?ZFFCMFVIU1drWENxTFlqRnRmUW1ReGVDNXBZdEtZS0RlMDBsZWVhWW9sZVZa?= =?utf-8?B?djc1OW9yZ04wTk5DbnV1UUpZcmxVT2JMSm15QWMyemx4MlZIdVloLzBLQ1J2?= =?utf-8?B?UE1tMXNJbWYyQk5zYThtcmdGaHB1R1RweElacGsxTzN0S1lnRm1IdEhTaG4w?= =?utf-8?B?NUE5V1JlUjdOdHp4OFZqREhwN1JWT0lvZ2hVNEcrblRsbkxFNVlxaEgwdHFj?= =?utf-8?B?bjBUWUhmWkRCaHgzdzhDUXZtQmxvNlE4SGpKcnYwSE8yL0pva3V5N1lvc3JG?= =?utf-8?B?M2pNRHpDSEJSeGhROVh5TEZNZzI2SzUza0drWXZTQURNVndSY0Y1RmVZTWRr?= =?utf-8?B?TnoyNVliQW9GaE4vdi9Pcjh4WjBnVUVlOUl1cXg5TzNmWHpiZHZEMTVLOXRB?= =?utf-8?B?NlF0cGN4VVZkWlRzNVJkeWFmdms3ZlQvN0Q1NU13ZDVLb3YyMUJrWkJzRkVZ?= =?utf-8?B?bzBqM1JDUzFYT1FMRzZ0cFkrNmpmVGJYUUtFNkdJcGtlUVNuS2prZkxRNTNY?= =?utf-8?B?UkJZdkdUQWNSNFhGOTIxSHR3Ujd2RTk3c1o5NW12Y3U3U1pPZHBmTkk0TC84?= =?utf-8?B?K0UreHlpRG5idTAyMVV5bUFzQWFrV3RSNyt3SHNtQkh0dnc0Q2RKbnZRMFlq?= =?utf-8?B?dUdOalBIN3VrcHZSbWpudHZPQTU1MWJTY3Q5VnlvY0ppSUR2VnpOOVV4Umhv?= =?utf-8?B?ZmpScE56aW56dVNXQUNzQlVXOFBaU2cvcHBBVXFHR29Ua3MzcTNZVEVFQ3Bl?= =?utf-8?B?TUNkSXNneCtxTU56RzdIM2ZZeXoyZ0o2NG9rNVZkQzhpSkJSZTlUQ0ZVcDl3?= =?utf-8?B?NDhjN1pRcDVXUG1LakpwcHhaRVkwSktqNXFjTThxUE92RUtlclhONzd4WDcz?= =?utf-8?B?R0ZvNmFocFFpK005S0V5QkdCOUwzZHd0b3A1WjRjZ2g3M2dPZUw0L29RNEcr?= =?utf-8?B?bmJyOG5pUmVLV3pqdzBIUWZyaWlQZ3hlR0FNZWdWeWxxY2dBcGxmMnZZQ0VH?= =?utf-8?B?RkRCZDNxalBQbWtVS2E2NFJKZVl1c202bXJwOGtzRGk1NFU5MlpvZ1hoRU50?= =?utf-8?B?QnlNQlhXN2ZwNElzc0hkUEdhRXRaQ3M0UittSWVkM0FmTjRNT0lWcHFLSUhI?= =?utf-8?B?a0xpdktmYlZsUGpvajJ3eU9rdTBQUWN3UmNzeFd3RWYxdnBFZjVRN1pNOVlV?= =?utf-8?B?QlZ2WlNLbU80b0JoUCtkTER5b29EMFVrZW1NaGZrVlpGTjk1WkI3QT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e618d75-08d9-4520-c615-08da42517201 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:31:19.9786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hrKHitJAYeANPmb5QpGY9Vz7FPShSKVBgUgnuNYL0QRPgG5ZZO2CQhZP6BWUBajjlQKjRelp0hl5AqrOvDrpnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5134 On 20.05.2022 15:37, Roger Pau Monne wrote: > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -139,6 +139,24 @@ > #define PASID_PASID_MASK 0x000fffff > #define PASID_VALID (_AC(1, ULL) << 31) > > +#define MSR_ARCH_LBR_CTL 0x000014ce > +#define ARCH_LBR_CTL_LBREN (_AC(1, ULL) << 0) > +#define ARCH_LBR_CTL_OS (_AC(1, ULL) << 1) Bits 2 and 3 also have meaning (USR and CALL_STACK) according to ISE version 44. If it was intentional that you omitted those (perhaps you intended to add only the bits you actually use right away), it would have been nice if you said so in the description. > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -1963,6 +1963,29 @@ void do_device_not_available(struct cpu_user_regs *regs) > #endif > } > > +static bool enable_lbr(void) > +{ > + uint64_t debugctl; > + > + wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > + rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl); > + if ( !(debugctl & IA32_DEBUGCTLMSR_LBR) ) > + { > + /* > + * CPUs with no model-specific LBRs always return DEBUGCTLMSR.LBR > + * == 0, attempt to set arch LBR if available. > + */ > + if ( !boot_cpu_has(X86_FEATURE_ARCH_LBR) ) > + return false; > + > + /* Note that LASTINT{FROMIP,TOIP} matches LER_{FROM_IP,TO_IP} */ > + wrmsrl(MSR_ARCH_LBR_CTL, ARCH_LBR_CTL_LBREN | ARCH_LBR_CTL_OS | > + ARCH_LBR_CTL_RECORD_ALL); > + } > + > + return true; > +} Would it make sense to try architectural LBRs first? > @@ -1997,7 +2020,7 @@ void do_debug(struct cpu_user_regs *regs) > > /* #DB automatically disabled LBR. Reinstate it if debugging Xen. */ > if ( cpu_has_xen_lbr ) > - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > + enable_lbr(); > > if ( !guest_mode(regs) ) > { > @@ -2179,8 +2202,8 @@ void percpu_traps_init(void) > if ( !ler_msr && (ler_msr = calc_ler_msr()) ) > setup_force_cpu_cap(X86_FEATURE_XEN_LBR); > > - if ( cpu_has_xen_lbr ) > - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > + if ( cpu_has_xen_lbr && !enable_lbr() ) > + printk(XENLOG_ERR "CPU#%u: failed to enable LBR\n", smp_processor_id()); > } Isn't enable_lbr() failing a strong indication that we shouldn't have set XEN_LBR just before this? IOW doesn't this want re-arranging such that the feature bit and maybe also ler_msr (albeit some care would be required there; in fact I think this is broken for the case of running on non-{Intel,AMD,Hygon} CPUs [or unrecognized models] but opt_ler being true) remain unset in that case? As there's no good place to ask the VMX-related question, it needs to go here: Aiui with this patch in place VMX guests will be run with Xen's choice of LBR_CTL. That's different from DebugCtl, which - being part of the VMCS - would be loaded by the CPU. Such a difference, if intended, would imo again want pointing out in the description. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 15:44:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:44:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338646.563441 (Exim 4.92) (envelope-from ) id 1nvhZQ-0004yQ-VL; Mon, 30 May 2022 15:44:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338646.563441; Mon, 30 May 2022 15:44:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhZQ-0004yJ-Sn; Mon, 30 May 2022 15:44:40 +0000 Received: by outflank-mailman (input) for mailman id 338646; Mon, 30 May 2022 15:44:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhZP-0004yD-AT for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:44:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhZP-0006Ft-0l; Mon, 30 May 2022 15:44:39 +0000 Received: from [54.239.6.188] (helo=[192.168.9.131]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvhZO-0007iJ-QR; Mon, 30 May 2022 15:44:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CngiKYenE/A3wTJGNFxg6A0Zj0x+QcVFxPIrk5pvBPE=; b=UO19dALJhyxI0m3WnHtC5ZMAtX SUYPl3SO3uqFGjuBuDYW/BNKGvO7euCC/9erVpdcHD0Yd5OX3AC6InelHYEYWqnD/eG4SlNYm8oE1 CRXo9++sbXnTJo0Bwp0YMbtH1wIpWcH/nf4HTWDGN/zCWCAz+vJAnkJz4T0II5a9d6Jc=; Message-ID: Date: Mon, 30 May 2022 16:44:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [Xen-devel] SMMU permission fault on Dom0 when init vpu_decoder To: Oleksii Moisieiev , "xen-devel@lists.xenproject.org" Cc: Peng Fan , Bertrand Marquis , Stefano Stabellini References: <20220530152102.GA883104@EPUAKYIW015D> From: Julien Grall In-Reply-To: <20220530152102.GA883104@EPUAKYIW015D> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+ Stefano) On 30/05/2022 16:21, Oleksii Moisieiev wrote: > Hello, Hi Oleksii, > I'm getting permission fault from SMMU when trying to init VPU_Encoder/Decoder > in Dom0 on IMX8QM board: > (XEN) smmu: /iommu@51400000: Unhandled context fault: fsr=0x408, iova=0x86000a60, fsynr=0x1c0062, cb=0 > This error appears when vpu_encoder/decoder tries to memcpy firmware image to > 0x86000000 address, which is defined in reserved-memory node in xen device-tree > as encoder_boot/decoder_boot region. It is not clear to me who is executing the memcpy(). Is it the device or your domain? If the former, where was the instruction fetch from? The reason I am asking that is, from what you wrote, mempcy() will write to 0x86000000. So the write should not result to a instruction abort. Only an instruction fetch would lead to such abort. > > I'm using xen from branch xen-project/staging-4.16 + imx related patches, which were > taken from https://source.codeaurora.org/external/imx/imx-xen. > > After some investigation I found that this issue was fixed by Peng Fan in > commit: 46b3dd3718144ca6ac2c12a3b106e57fb7156554 (Hash from codeaurora), but only for > the Guest domains. > It introduces new p2m_type p2m_mmio_direct_nc_x, which differs from > p2m_mmio_direct_nc by XN = 0. This type is set to the reserved memory region in > map_mmio_regions function. > > I was able to fix issue in Dom0 by setting p2m_mmio_direct_nc_x type for the > reserved memory in map_regions_p2mt, which is used to map memory during Dom0 creation. > Patch can be found below. > > Based on initial discussions on IRC channel - XN bit did the trick because looks > like vpu decoder is executing some code from this memory. This was a surprise to me that device could also execute memory. From the SMMU spec, this looks a legit things. Before relaxing the type, I would like to confirm this is what's happenning in your case. [...] > --- > arm: Set p2m_type to p2m_mmio_direct_nc_x for reserved memory > regions > > This is the enhancement of the 46b3dd3718144ca6ac2c12a3b106e57fb7156554. > Those patch introduces p2m_mmio_direct_nc_x p2m type which sets the > e->p2m.xn = 0 for the reserved-memory, such as vpu encoder/decoder. > > Set p2m_mmio_direct_nc_x in map_regions_p2mt for reserved-memory the > same way it does in map_mmio_regions. This change is for the case > when vpu encoder/decoder works in DomO and not passed-through to the > Guest Domains. > > Signed-off-by: Oleksii Moisieiev > --- > xen/arch/arm/p2m.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index e9568dab88..bb1f681b71 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -1333,6 +1333,13 @@ int map_regions_p2mt(struct domain *d, > mfn_t mfn, > p2m_type_t p2mt) > { > + if (((long)gfn_x(gfn) >= (GUEST_RAM0_BASE >> PAGE_SHIFT)) && > + (((long)gfn_x(gfn) + nr) <= > + ((GUEST_RAM0_BASE + GUEST_RAM0_SIZE)>> PAGE_SHIFT))) I am afraid I don't understand what this check is for. In a normal setup, we don't know where the reserved regions are mapped. Only the caller may know that. For dom0, this decision could be taken in map_range_to_domain(). For the domU, we would need to let the toolstack to chose the memory attribute. Stefano attempted to do that a few years ago (see [1]). Maybe we should revive it? > + { > + p2m_remove_mapping(d, gfn, nr, mfn); > + return p2m_insert_mapping(d, gfn, nr, mfn, p2m_mmio_direct_nc_x); > + } > return p2m_insert_mapping(d, gfn, nr, mfn, p2mt); > } > Cheers, [1] https://lore.kernel.org/xen-devel/alpine.DEB.2.10.1902261501020.20689@sstabellini-ThinkPad-X260/ -- Julien Gral From xen-devel-bounces@lists.xenproject.org Mon May 30 15:49:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:49:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338655.563452 (Exim 4.92) (envelope-from ) id 1nvhdb-0005bb-HH; Mon, 30 May 2022 15:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338655.563452; Mon, 30 May 2022 15:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhdb-0005bU-E2; Mon, 30 May 2022 15:48:59 +0000 Received: by outflank-mailman (input) for mailman id 338655; Mon, 30 May 2022 15:48:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhdb-0005bO-2O for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:48:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04031bf0-e030-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 17:48:57 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-jq9NEEMyNX-mOzY87rme2Q-2; Mon, 30 May 2022 17:48:55 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4792.eurprd04.prod.outlook.com (2603:10a6:20b:2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 15:48:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 15:48:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04031bf0-e030-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653925737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B+nWreY+WnPK6i+bgNybqgeha/kLJooNellhfaQljnw=; b=VPzmGzugkyGxFQbi4mktpruLI8VjNFB3Hx0arxv2dCsMF3mMgqGkUzlQHKzxYs8TimhJhG Sm88GVcqGfmTIfTJ84sIL6qWQPvIGh/YpKhhioHF761/ghpthKexYD0rrpFC1JiVr5XhFO yX/KkGIRC8OxLq+yMPVZV8yl7CEqcA8= X-MC-Unique: jq9NEEMyNX-mOzY87rme2Q-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EfMQ3DlNN+E+/Wb/zPc9IWWCco1RX9KFpZmxVXot0lAwiFSmiMqgbP/rF3bcrxgtaxBHcCTHllTU3WPCM1ALeAYGy7eK00iINAPA1mqfKsOJMhCV/mgyOEgblCEN39Gh6PwhTXCjcJxRaK5IMIUqKBRjN8VWIaNOUYX2oTg4Q058ThxYht6YJeBYAVOiURnPDRvVmurt5QcOnT6Y6BMmG2jSAJ67TwpODf9jXAZSGGNTH+evk3fyAo9aTsH48a74DXAVDJwA2IboXnATXNZj+q2j6Fb1vEwIKyr3/eOr7dNn5ARuVumrWFSE2UkIc74QwMnmRoPzWx6A8L51B8DLGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+nWreY+WnPK6i+bgNybqgeha/kLJooNellhfaQljnw=; b=f0DeWM2JaYqkHqQ8EBd107G2dqiaiqAQ07/suu46Vzr4AP0cnwhhPXtT1Ae0ivJbQX7G47UkwfhfCIsydqfINIPCMlyApN0rYuncnfElD/+6KnWhbodqO7DavyD872Xq8gvyzRPtyUZF3yGxTPySk7sdo72fvnBzEr9XgXFMbmeRiTqhkr+uT+62BUMAhQ9gN6nlo2+TFiUSkuQ4A7V4fl1P4iclXcXeTzEkwycomg0N2c3uTqwkwssdFyXkZ2XNnjX5v3/fkx9PFGxKx6HW0OguF4+Efln+wpNovo5lQ0/CBoSHITsyEFKx9FqnVv/FzYarPiQfrMET5UMHPEUR8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 30 May 2022 17:48:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: harden use of calc_ler_msr() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0752.eurprd06.prod.outlook.com (2603:10a6:20b:484::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3983341-f833-48b9-4a81-08da4253e608 X-MS-TrafficTypeDiagnostic: AM6PR04MB4792:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6rG6lX1tPOj+t45PRbp3rBohxVnIPT7PXQUzloxlJ72uf3t/6tJrgoxpB9OjCZS7UW0rpiLQt54I7haO1fNqTo04PfzSGhgpOH1K2PbkmptwxnDVXwNBiiKj/FrZAjOt0Rbey6xUoBis2jgSg9XCwKVR+FpcvgM/+yc0jhPAMSnKmcsnC4fZSTVk1dQBs8ZqxMcPFpyoVR/LESBI5Sl+BmvT0czHRoHKNBnfHf/zbhrs4NEWvg+IdK4uC1CdYnzK/8co4Hx8O+lpqfiYxy8fnRAEAPmjt/pjdwSfiESLPBOof7CQJ+0FJ5Z0Q6jrf6tyEnLXuVyMon528fNUsiwCQ2B/2H5X0Zy9RKpFHK5YSZvy3GC/RcZoW+EwSLsfVLth2M9l3PBqBlPl2u0x8cgrhLM+BImKHTaIZUedmzZHMP+Pjt/j28VOr5GjLF+awM72ZMgLRcxUTXw/jwjgdCMZVr0aGr3b8XbJzFysopYOhGTxbmarONny7WtFdJmahaHy3Qce5KKqZgIfGSVz2dNroQODis8JbecsDuMn2mkoDT7jYm0aJxMrHfQObE4YgAoyaq1VfeAF40m6Sc++f1Rdfrb9d2JYv4+X9LjIH6QL+AA3sBsmvdq5m/u9GTNIImyjoaduy3SjidnO7OL/fsfvVM/4bZILA9i9dRYT07wt+RzP8YMcBrZZtbJB1EX/LsnjNCTsEXbbjxLzF16FzuQMvtrrv3b+vdwrTVaCN09b73ogeMyIg0cUBu4su8mMjIsu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(6486002)(6916009)(8676002)(5660300002)(508600001)(316002)(6512007)(26005)(8936002)(38100700002)(66946007)(86362001)(31696002)(6506007)(36756003)(83380400001)(2616005)(2906002)(186003)(31686004)(4326008)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGhybzE3MWlXd3JiYWtLeTJCVUhwZUVvUFE3M2hZbSs4RHdaYmdTbGp0cktH?= =?utf-8?B?RU9ocXRhVk5WUlhsTkxjL0tnak1ja0grRlZtOFh5dndrQk4rYlVITXM4bk1S?= =?utf-8?B?S3E1ZXJ6VERoc28rRnFBSGtxWG9aNjRpbEdmUVIwSElmQ1FpS0RKUWVuR3Fv?= =?utf-8?B?M1RYVzBPSEwzSVE0TTRzQkJrWVdqOHl6dFFQVm03bDQ2R0R0YjVFVjRSeVZ4?= =?utf-8?B?a0p5cjBwRVJCZExRQTIxYWhhWDQvTWFCRnNDTk9uMVpsb3ZxeTQ1K3RoUnow?= =?utf-8?B?NklWbUdPZkd6bHRaTXJpWVgvSkx3cUt6WXlaWUlDRS80bW1USzhSb2p0dGlZ?= =?utf-8?B?LzhmcUhla0Z1dUlVMWorM2t1Zlk5Mk9QNXJVcWN4ajhxbWlobG5IOXJoM3Jw?= =?utf-8?B?U2dhdW1oRGh6YkNmOVBob2dlUFJEV3JCMUdmSUVxZ2tyMFZnd2x3TEJIYk5l?= =?utf-8?B?OWcvbzk5OVhxVWVka2Jzc3ZQNnNOSDNuK3k1K3V2aG9RN2hPb25UbFhheHQy?= =?utf-8?B?Z3BpU29RTnpOWS9mMThXckt2N21qN05MeE0zbms0NGxncTVia3R4MHFJcWNt?= =?utf-8?B?dzViQ3I4S25pMmovNlZJQkJBK3JMSGlUSEtmRjhLUFZRY1cvL2pWMVF1b1BX?= =?utf-8?B?RkQxd21VSTZQeTZYSFRNTHU0aExKdGRVMDZNWEI2UzFvQmV3aWRDc1FmSW5N?= =?utf-8?B?V0M0NWdPM1VGWEhZSGJXK0llcGkwOEFYUThhOTR1TDRsU1BZZnJTYTk4Wk5P?= =?utf-8?B?Z2JWNHhNTm4vb0k3dGJldlI0WTdMYmJMUHBpZUNiNWlIZ0dvcXlwWldteUwx?= =?utf-8?B?cUUxanJMZlBseGlmY2crVnlaQ0lnRzhlb2xpQUliOG1Pa2EzcWVtV1ZuSWNS?= =?utf-8?B?S1dSUXZoVWZTM1VaSnFrVnNXd3A5NlVGSDZmR3NYaDg2Nit5aG80QWFoYi9V?= =?utf-8?B?bnFJaXZ4SkRjLzEvdTk1ZFJ0UGprUlZSRHVEc3dGNFBhM2JSR1RqeVYrNTVL?= =?utf-8?B?M2grb3J3K0x2T0JCRDRzenpFWm14ekJGVW1KTEMwZURLRHhRS2pWTCtINmhK?= =?utf-8?B?L3FBTW5HT3FaaEY5VHNvWXFiOG9ESmdJK0w0OXkrSWlqOWdCNzZTMlJJZkNo?= =?utf-8?B?T3J0RXhjZnRQOUFwN0ZIczBuMGlNd0toZHRqdkJvVVFRdjFneVBuWjAwYnQy?= =?utf-8?B?SHZYOXF5cFJuYWY4SkNxQ2MwSUtndytCZzBuMUE2dXIzTlNSeWd6OGxxQnJ2?= =?utf-8?B?aGxFVG80WWJFNTJmQWxBUS90aWltbktyaTUrR05pSjdQQTZyVTlmczNxQ2dY?= =?utf-8?B?YmI4bHVMWU5GRGxZaFc5ZmZqeUpLZmRWdFRtbEg2WFlHMzZxRGlpNmJVbFU5?= =?utf-8?B?TFBWRWhlbTFDOWROZHhDNE9KbitTSW43aGVHVnFNcGxGTkhrRVNCaTV5bjEx?= =?utf-8?B?ZHlkQitmcHdJdDg4MC9aSFdibk1qQkQreGE1ZE9EbjkrOG1EWnV4cUhPNytW?= =?utf-8?B?NXRFeHVOSEF4Z0tEL1A5TjNMcnJldkxBZTBlMHdOSlZDOFp4QmJpQ3drT3E1?= =?utf-8?B?eGJoVlZUeDJRYzU1eURLRURORkQvaDlLZEl2aEs3UXNVL0hkVjNqUUhlVXQ3?= =?utf-8?B?U1VKNmtGNGtuNVY2YzdiUW5WRTFEYlpmd2RFMHN3OEwxaWswMzE5M2RkUkpJ?= =?utf-8?B?dzFJeW9Rbkcyb3M4L2FhdFpJaVRSMm9oODhWNTF1OHVib1RCYU9lWjQrbHpv?= =?utf-8?B?QlFCWENXZUEwSDBIb1NLWGFYeUFHaDZmUEtRWWJGbkw1T1ZJVkdEVXpzbzN3?= =?utf-8?B?Qm5qbEgvMlh3VGQrNlNMMDZNN0dISy94WmZBTExLK3owbExMcTRJUmRvMktm?= =?utf-8?B?YnRleTFPaU8ycDBMTWIzTHExbUJZUUQ1TVBwQ2cyZFMrdFAycFZRSjYwNjRS?= =?utf-8?B?SzhDWklMSnFnWVdUOXNiU1RHeG5ZV3FIT2Q3VHZlMlljWWtqeVpZR2phOXBL?= =?utf-8?B?cjAwZVlBOGdiOE9Ld3pzQWRuL20zNFovK0YrVTVEVXYrcEMyaUZkbXJ0WDBM?= =?utf-8?B?bHMvcnYyS3dMMHF5VHMzTDR1QURNVjd1QXU5ejhNNktQUERTdmk5TU9jYjk2?= =?utf-8?B?MytjYStzek1EajUzbHZyVTZCeEx4T1hGRnkxL2F6MkkvY0VkVEE5cGtLL0Vs?= =?utf-8?B?OHN4Mm5aZGxpajdWSHVDcWRMQ2V1YzJTR1NzRDVkdisrRXExWk1GZG9kSEtY?= =?utf-8?B?K0QyVDE5ckhuV3J3ZlBlVG1sckxuMEMxSjU2cWtBUVA5cU5QSW5USEVxOERX?= =?utf-8?B?RTVYMzZ4cGx4Qlhaa0VlbkYzNTFjQksvc3lIUWNsWjFPSU1ld1ZVZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3983341-f833-48b9-4a81-08da4253e608 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:48:53.7243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MtTEUDspO5nHE7JbM00u2NfwOvZSEdXma4jOYovewPSRBZuWL9OKVjFzty7Gkxka+pqucCP01FQlWDdGa1xUCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4792 Avoid calling the function more than once, thus making sure we won't, under any unusual circumstances, attempt to enable XEN_LER late (which can't work, for setup_force_cpu_cap() being __init. In turn this then allows making the function itself __init, too. While fiddling with section attributes in this area, also move the two involved variables to .data.ro_after_init. Signed-off-by: Jan Beulich --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -126,11 +126,11 @@ DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_p static int debug_stack_lines = 20; integer_param("debug_stack_lines", debug_stack_lines); -static bool opt_ler; +static bool __ro_after_init opt_ler; boolean_param("ler", opt_ler); /* LastExceptionFromIP on this hardware. Zero if LER is not in use. */ -unsigned int __read_mostly ler_msr; +unsigned int __ro_after_init ler_msr; const unsigned int nmi_cpu; @@ -2133,7 +2133,7 @@ static void __init set_intr_gate(unsigne __set_intr_gate(n, 0, addr); } -static unsigned int calc_ler_msr(void) +static unsigned int noinline __init calc_ler_msr(void) { switch ( boot_cpu_data.x86_vendor ) { @@ -2171,8 +2171,17 @@ void percpu_traps_init(void) if ( !opt_ler ) return; - if ( !ler_msr && (ler_msr = calc_ler_msr()) ) + if ( !ler_msr ) + { + ler_msr = calc_ler_msr(); + if ( !ler_msr ) + { + opt_ler = false; + return; + } + setup_force_cpu_cap(X86_FEATURE_XEN_LBR); + } if ( cpu_has_xen_lbr ) wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); From xen-devel-bounces@lists.xenproject.org Mon May 30 15:58:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 15:58:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338665.563463 (Exim 4.92) (envelope-from ) id 1nvhmb-000794-Jl; Mon, 30 May 2022 15:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338665.563463; Mon, 30 May 2022 15:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhmb-00078x-Fl; Mon, 30 May 2022 15:58:17 +0000 Received: by outflank-mailman (input) for mailman id 338665; Mon, 30 May 2022 15:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhma-000786-Ce for xen-devel@lists.xenproject.org; Mon, 30 May 2022 15:58:16 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f23b5ff-e031-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 17:58:14 +0200 (CEST) Received: from mail-bn8nam11lp2171.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 May 2022 11:58:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SN2PR03MB2336.namprd03.prod.outlook.com (2603:10b6:804:10::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 15:58:08 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Mon, 30 May 2022 15:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f23b5ff-e031-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653926294; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=WHfvbyMRtU38XOD1GEN7akuDaCYkFIbPbS1yfvgNZWo=; b=IfsHxP1daHA0eTnW4IFO1tqEmeIX1IqfoRMViw/qMY5ZLuyC/ZYPz3C8 /HeL0ER7Y+O1FJCoCBLX39cAMsvHFWsEHIiHdqJK2FvBnJ1U0QA40UuBj DliU2gytzs1TLgazypNt1+D9qCkTa6rdpY0eyDC/ZyphZu2EZ2XZzD1CD A=; X-IronPort-RemoteIP: 104.47.58.171 X-IronPort-MID: 72456830 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YI4ghK2RQ7DKOzreBPbD5adwkn2cJEfYwER7XKvMYLTBsI5bpzRRx mQWDDyObKreMWr9Kd8iaIqypxlS657VzIVqQQNtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMz2YDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1fj8eNGCIgLpSS2+lNfSRyOiNiNqBJreqvzXiX6aR/zmXgWl61mrBEKhFzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82TBfyVvLe03x9p7ixKNezZa McDLyJmcTzLYgFVO0dRA5U79AutrialL2AG+AnNzUYxy2LuwhF02ai3CcjuY/+VG/oFmliEt luTqgwVBTlfbrRz0wGt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM UsW9yEy668o+ySDUd3VTxC+5nmesXYht8F4FuQ77ESHzPrS6gPAX2wcFGceMZohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnF76PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:AX1vFaimQuZnO1evhwOKBXmOg3BQX0h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH LKjfA32gZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQP003MwmMG9yUkqp/lWGmLeXLzcO91a9MwU/U/WuonZrdCsT9Tpb+CQd9k1wga7VBaM0ot gsCZ4Y5Y2mfvVmE56VO91xMfdfKla9Ni4kY1jiV2gOKsk8SgHwgq+yxokJz8eXX7FN5KcOuf 36ISFlXCgJCgjTNfE= X-IronPort-AV: E=Sophos;i="5.91,263,1647316800"; d="scan'208";a="72456830" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WmQySVZyGPEdRDTt3YZgsNh9FK8kFisYeyDfHhdy4lVr18ogkZ8ktfN9j0I8r23xArExpePnlDtJrJ1sVr6lyo+/RTEStFBTcB+7U1wmLsheTYSkCZhB/7J9dqnJHfj8AoSnluzPFRc/g7WEdeMYkY7x5y8w1VO/hgZdayWpfVe6QGEViIc0yYLv85Ig1bN547hL4GFRnhwoToEKPXfGnbmQjaliEvokRNd8PlDYOvBB0Z8u2Dp2Jaj917OATc8bIYIz4BzJ34cm1J2ByDaD1rZiZ+Aa6dNFotb3jVzmJ3mK3nqZoulpWCZym8tf1yKqMAWqffRYn9n8wJDptbbhPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGEJv2/xS2r///eJf+EYnL8iSxPU6Q329LiR+covoNw=; b=PuGowA85XHIzXoDe6rQIcUVhcI2V7c+9vS+/yE5jp5wYv+PJ2WeLXRrFl2DXUsiiSy8PymXHKVDyrPqPeJFqNFLCrbuzPepmWPKVG0TMeV6FdHMSlIN2tXhJgkiLHdEGTCrIEpTPW8iGp7P8YHT0VKRV+wurS0nRP/P/r6uO0VUiWQBTE3kYF3bDz5sEjIZm243CRcF6Int91k9erFUVUTnjS2zfm7qOgwoXfvGaj2TzrJa73DEyOLW9kR0dsUn0wDYA4XDfeQFnDWRcmvlkY9+i7ygRybe0OyEqmGEW/mjYokaa7C2DVAqn0XSqhOzv5+ccJ7dNBjhLjN4kAB4IXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGEJv2/xS2r///eJf+EYnL8iSxPU6Q329LiR+covoNw=; b=klnw9+KkGVL4IE2rVhX4lDFroNAxBouyq7CppIPuE3TFbvG331f2cyXmUAXtT06bUOKTLJznkmrTkosad2KdbFygC4bvWMT4u3daySHmK8fgMvmjbDzQaksA2MNt7Chs8CLLRenE3/YQDx5NK5qQZSdxksoSh4oQ3XlcwdqtCKA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 30 May 2022 17:58:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: harden use of calc_ler_msr() Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef5ec7f1-f1c3-4501-1533-08da42553079 X-MS-TrafficTypeDiagnostic: SN2PR03MB2336:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DbNujIlP7mur/KDimtohF7En6lK7PVxTQ4uWRmXLyca2L5FiCR0EwvvAVHG4lM7mPkfx+AWmzZE0ooDV0vyggFscRitG0CoG7XCpoX/Cal3aJlxlyXsNUz49UTVUuIay7PqsuSDbzen88klxxb1DShcpVr/B2lw28LKgPnbnr++3pRdjRK1xj+5YTGbzPBlZhwjPkxq2B97jVV5gPC4uOAT2T18PjHjofoDrCk3jleDL89S2LxNpMf0RDBPMcXTnasVO3hZ9BhN8+um+U7ENIp6hl67qHJHbwkIUWcmEI+VQVqhErmxUY5fiAgWqqdDRr82t2Xbe8EfNLJA7QX4iiXrbU4njoh/5D/zDKnAoWNxgzBj9xEuDVZ4+MenYeMZkEMBEs6Cu7q0FSdLPTOhqsTkF1oj6vzyJrDa8reBRNn4eTuVQXImGZX/V2ZmWDQMMcRkE38UCw2jZ9SHzW3RlGtJlmjPnjWru+W2wJDUrhz0QUj6XLmi0aBv/HWWa2YDohBNlM8eQnwLm+MqdbVhdphhn+xRsHIbC+kgyvsYMxaiilsModaLwYAon89Oq7qY7TOWGROuLM/bY7eCiXi50aQuOy5Oek5ZgoPSVi9CDbFQWJdivLmW9Qfd2v4isnHop9JpfQS+B1oFDzpaewLKk0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(186003)(508600001)(86362001)(5660300002)(33716001)(82960400001)(83380400001)(6486002)(54906003)(2906002)(66556008)(66476007)(8676002)(6512007)(66946007)(9686003)(4326008)(8936002)(38100700002)(316002)(6666004)(6916009)(26005)(85182001)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFljYmFUeXFhOEYrZENkRVFMRWoxamxYZjF2Q2JtWm1zaDZNaG45T2xFVU9U?= =?utf-8?B?aG93N1gwZVo5V2NNY0g4b0phRmhrT3Foa3RYUk1ZVTlsNTREck9TN3NlY0NK?= =?utf-8?B?cjVYSnVnT3c0Zkg0czB4ODcxYllLOUNOT3BDVFhqaE55NFBnTC9BWjRWWnVJ?= =?utf-8?B?M2x3dXFaVGhDeVN1T1pMSDdvUkZsVzFxTFpoWm5FSDlCWjRJM2FHVTF5WHh5?= =?utf-8?B?b2I2Q1I5dmQrTjBJR1krVkR0dzNEOHVzSXRHNGhpWVZiakVzTzZqK1NROGFK?= =?utf-8?B?bkpzMUZFWXg1RG9Bb1FOd09keCt2YUVHaTg1MFhsUi8ya2YxZWVhTkQrcUlo?= =?utf-8?B?K281M2JCTkVKMXN6QWE2U0VweEZ2U0N3WDc4bTlFK2JhOXFsKzBGdThvWHdl?= =?utf-8?B?QzR1NEtidWtya2JDV3QxZTA4UDJaNFJyNitKdlVKQkxoM3QvaGlxKzB6U3pn?= =?utf-8?B?QXUvd0VKRHlvM3AvdHhlZHZZaFpRZ0IyTVk1SUxyMEZSeUUwazZvQWxUTVJV?= =?utf-8?B?dmR1SlplVmxaaDJ6VmpxZ2M5TjdhOFlkNmNjcFNiWXhJUkFETGE2MTlRbGtO?= =?utf-8?B?NlN6cEJMakpObDBBUVhvb05zcC9PR1BZSEhlZVRsVkc3SEJBR2tRQ3BLeis3?= =?utf-8?B?ak1kNUUwRFJzVGlPVHJvd1J3NjJyeHNNb1VsaitpR3RsaVdxcGczRXlpNDJC?= =?utf-8?B?MmRqY2VzRjN4aXlxUmxRRGt4M3ZBV3huNWZSQUpmRUJxZVd2dmRTSklYdE9t?= =?utf-8?B?TGlLczQrZGM1d3hQSkg2dStGWXlVTVBzNzQvRWhHNXNnd0plNENTaGt6QWs1?= =?utf-8?B?YXl4UWlHTll4NHF0aEdINzNEU29OcERhU0Z4YWtxZGhMcUxBZzNpQmJROHRt?= =?utf-8?B?WTB5WWVBbVNyN0JoYk1wMDJUOG9HcTlhVnJYZXcvNW1jclVQS091YUJQMXdi?= =?utf-8?B?Yy93ekYrdVgzZ1lXT1l2eWhaNTh6SWduMWFQUkNDS3NOQVh1WDgyZkhydlps?= =?utf-8?B?dEJWNkZVaVhPWk5RL1JncmNWc1AzSEQ3ZU5TN1JWZXEvODFpLzFuNk5SeXpa?= =?utf-8?B?dzBmQmFFNzNwdFZiVnQ3YURhd3ZQdm4vSlRudFdBM2Rha1VvaVlIZHJ0YVB0?= =?utf-8?B?N1lycStlQ0tJTnltK0ZSbmNXN3dyY25iaU9mUnZSbVN6eW9QZnRkbTZFamhS?= =?utf-8?B?MTB4MTlJdVRqUHpwUm5hby9YQktlU01OVGd4MjRSM3BVU0RkQ3pUOEVlSHIw?= =?utf-8?B?b2xWVFFqVnlpcFliNDg4M3M2azRiUjhMSEE3UXBCMkcybThleEVmeEZDN25P?= =?utf-8?B?TUhFVnQ0bjZ3RkRVcHVpTFZIV0NaV0NCYWNDT1o3aFk4aWlOVXRsVXlZY1l3?= =?utf-8?B?OTlVQVk2d3pBaXN4c3lpelJ2VEtQcG9vdzVFT1RXSkllaFBpOTNEdDBIWVhI?= =?utf-8?B?UVBHKzE4Um1Ob2F2VmlBcFFJL0poTU15V3lnVUNrK0pBRTIrdm1TdSsvNktq?= =?utf-8?B?TCtCTlRJeUc5ZHEvRlNmVVZra3diRHgxNEVaZ3lDMjNVbFl1bEJDaTBtSnpW?= =?utf-8?B?Ui9HOXpnOUdKa1IwRXRramZhQVU3WEtjWG9KWE1KL0ZnMUI5MDhTdHBzaENZ?= =?utf-8?B?dGRBKzByZk5LUGpYc1lCeWdocEozQnNJelNtQmQvODNoY3JxeHNTU3dwdGdl?= =?utf-8?B?T09tNlhxUncvbEdKb1NlQk9FUGhVait6d2VQQnQ4ZU5HWUk3SlNaekRBYmFk?= =?utf-8?B?VkZ6T25VenluUUt4Qi9ucVU5aWZZTTBqNndnQmYrQ2l1cHoyZHJKVTRHMjBv?= =?utf-8?B?cGc5bVN0Y1Q1SDVRdUNqVHh5OGdEb2FNc0lVeWRyY0M0S2J2bURNWFpnT0xk?= =?utf-8?B?LytNT1JvUWpKRmpmdW1LaEdxNWJYa1l3a3ZiL1dnSmNtRnNkV3MrM000TDhj?= =?utf-8?B?SjU4NlhXa3RnV0U0RHRuTFROek5TQ28xbGdGRnhIR25HSXlYNmswdWdQYmpa?= =?utf-8?B?UmtWNTVyNU5VQVY4OU5mRDd0WWEzNUN5WEIxODFmamxqZ3lqbDBvb1hjL2lt?= =?utf-8?B?bkd0b1h2UGhjQU9ScEtCTlBjRmY0ZDRMVUJWM2lLWVBsaHErUmJpcFh1TDdP?= =?utf-8?B?aDNHZFRFNHVUTUZZbU5vMWJsVldHZ2k0dnF5T0tEOFdPMTVZTkN1ZWtYZHpt?= =?utf-8?B?QmI2bkY4STRKVS9MendRdzkrazRMcG1BRHhLL0E2MjAvVmFsaElIR29TWEQ2?= =?utf-8?B?NU1MUDh1TXJiaE9qc3dIT1IvVlF2M2FOZGJZakJxa2IrWitTYWJDa1MwQkFp?= =?utf-8?B?R1dyc1lpUlhVZDYwMkVkNHlzL09xVDAxSXBuWmZGT0s5V3EvcktnSklic3Ja?= =?utf-8?Q?3n/U4V3WgZEkJB5w=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef5ec7f1-f1c3-4501-1533-08da42553079 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 15:58:08.1284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Io/fUDpQBuhXGBtWoEX08uSA1xN4lnZZjhuNFYxGwvE0vIfguDSrJVjK0kD951VH7JjmlSQPfQtMTKGL8B7JMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2336 On Mon, May 30, 2022 at 05:48:51PM +0200, Jan Beulich wrote: > Avoid calling the function more than once, thus making sure we won't, > under any unusual circumstances, attempt to enable XEN_LER late (which > can't work, for setup_force_cpu_cap() being __init. In turn this then > allows making the function itself __init, too. > > While fiddling with section attributes in this area, also move the two > involved variables to .data.ro_after_init. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -126,11 +126,11 @@ DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_p > static int debug_stack_lines = 20; > integer_param("debug_stack_lines", debug_stack_lines); > > -static bool opt_ler; > +static bool __ro_after_init opt_ler; > boolean_param("ler", opt_ler); > > /* LastExceptionFromIP on this hardware. Zero if LER is not in use. */ > -unsigned int __read_mostly ler_msr; > +unsigned int __ro_after_init ler_msr; > > const unsigned int nmi_cpu; > > @@ -2133,7 +2133,7 @@ static void __init set_intr_gate(unsigne > __set_intr_gate(n, 0, addr); > } > > -static unsigned int calc_ler_msr(void) > +static unsigned int noinline __init calc_ler_msr(void) > { > switch ( boot_cpu_data.x86_vendor ) > { > @@ -2171,8 +2171,17 @@ void percpu_traps_init(void) > if ( !opt_ler ) > return; > > - if ( !ler_msr && (ler_msr = calc_ler_msr()) ) > + if ( !ler_msr ) > + { > + ler_msr = calc_ler_msr(); > + if ( !ler_msr ) > + { While doing this rework it might make sense to print some message here, like: "LER option requested but no LBR support available" or similar IMO. The rest LGTM: Reviewed-by: Roger Pau Monné Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 30 16:02:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 16:02:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338674.563474 (Exim 4.92) (envelope-from ) id 1nvhqO-0000ed-4i; Mon, 30 May 2022 16:02:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338674.563474; Mon, 30 May 2022 16:02:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhqO-0000eV-1L; Mon, 30 May 2022 16:02:12 +0000 Received: by outflank-mailman (input) for mailman id 338674; Mon, 30 May 2022 16:02:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhqM-0000eP-D0 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 16:02:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbc41cee-e031-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 18:02:09 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-SXw1-8XJM4GgAodYt57uKw-1; Mon, 30 May 2022 18:02:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5719.eurprd04.prod.outlook.com (2603:10a6:20b:a1::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 16:02:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 16:02:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbc41cee-e031-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653926528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=37TxpXbybYBIxNoDM6WFgoDWLtH6YyngDzP+YKk8ZIw=; b=XwjkitCScrK6y1i3UL/JXb87Bzr0DUDhb9G+gLUMZXH94HibbuTTTbNcWriirfqwNjRZ8v OKo5TPGzqfBeii/Z20AWOtHPrX/D4lUYi53YEddt11pW++bcLGqfWTWuc4HJk9xGUYpDvj 6dvT19otjXo6qZFU7gTCoce/Zy5NVck= X-MC-Unique: SXw1-8XJM4GgAodYt57uKw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JjmW9b5W8Bg7VSap1gLWdMAPUfsxuMH9Q6W84zCBqedHZsv0UUhhkW61pKeIqdk7J24Iiply1M6VUX96weW5q7dxie/JPr1QuejCNas7j/hywfJDBbLPaztXT8M2kA+ID9sDn7dO6K9a15MdVrR4QbJtH6FrJJm2awP/GCfm797vlYuZgOpKlOWKJGWCEI7JLULRPALbLTeWWdc+mLDLdr2rSoj8MKo2NkPQoA+wngXcAFxRCoOre3kfYxBHqkPl86F+u9XTyolhtk5DrJ7RtE4IDMVCYQS0GwV4GPSW5Y0YXT/p0rBsLs55dSbi87ZvIJGkHAuwwQpGUCzWhRGpQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=37TxpXbybYBIxNoDM6WFgoDWLtH6YyngDzP+YKk8ZIw=; b=AuBbPfayWRu8xIeK7UShNw5245j6YFo81ZGhJ/5QwVyQuTetpvDT2GX9eHGmuEg72HPjmhqKeLaLV7+0xK5Ph32lwXiwzR0SzVNSi5z70DT4ryBHr1e6a65Y+MfLVuB9igaZS02vxQuco2c8bSwCL4Ww1moKrOaWhnMBpC7zZy9WYUc2X54aYcxtCvNMUCTfQG0F7DC8tlk8IuKENtNdfOmTrgBF9sm7JzunhSTgxqUEXAVZRa7cdjJ7o4+nRCQBn/6P4kFamBHFQof0XCLh3DjpBTmwXUwa24GTDFzp2BSkWZKzObsPuvDcCMeKvbJe8THwlVWJRAiGrOBgjeJfsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <230bb122-de08-3279-29d7-1353449845ae@suse.com> Date: Mon, 30 May 2022 18:02:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/5] x86/vmx: handle no model-specific LBR presence Content-Language: en-US To: Roger Pau Monne Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-5-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220520133746.66142-5-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e1a4d1c-ed7f-42f9-e915-08da4255be22 X-MS-TrafficTypeDiagnostic: AM6PR04MB5719:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cY1QpWffffoKzJbDAXQ14NLyOQrOVrfOk7N+lnPc/UhOR94I4SpjbXe55ZckTZ3SV8iLY3EdMsOqG36ziHnuN5QQZjZOMBNIdLFEkhAJd8+y3exkKjZsY9K82tuLwrjZ6Dl99ld7I3VxXfWzDlK6ErQTLU5iVezng6rgaaj+zZXznE2OXxgSVHEtRoqy0HsPMBmSaUBFdzm6GsqWSjdP+6mL+n/I0PfiwGy4g4f0/CoDuUZ2yqMpwXfw3PULfNE0vkt3bmYqe9WnpGvkA5XEPp2EdSZkh8zQX3sYMm+BXueolDSpFkCHtSqW7b8ZbImIsed4JLGgifueT7OR/bQvg6oHRFsdgrH65I+bpLA+DV/KWaOo8eQkNpIFqMme34uwx6MpmZ4rkCKltZzcJ+QxUo7v/htdu2eygqHrho9MkTO08AYgIDlihROG0MTrbJ/JCZJjrQZFVdC2G6jct683+qp0YycOcgPEqsLmueoQeUtOmyMV7+DV+tpkM93/ttGXwSjxB9fd+1IWAQpjv6yhRheVnuIix7TgJNlPwKVrtUpZARN9MVo/2bm6f4rKjyGMpJqlpELgDUNAhPGJ/TGq1JvHbxZ7NYN5VSzHeH6X15CtRsfjFDKAxfreXdEtpyvNNokpyeNHYgwLMDcZooMGq3fc+C8r/zEo7Ns+c7rfbNgYGJ1rkP9zCcaLrVki7EVs5rDKmMibvqvSlXkrtzYg/vDaG1MSRxjHLEFkHc60hJgqExU9lhkLrj+O4uOq2fRf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(6486002)(53546011)(66946007)(8936002)(6506007)(86362001)(31696002)(26005)(6512007)(6666004)(2906002)(66556008)(38100700002)(2616005)(186003)(31686004)(54906003)(36756003)(6916009)(8676002)(316002)(4326008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEFLZ0gwS2xWRHlnTDUwZTVWanlFR1pTcUx2d0hWa0kyaVVEVFV3QjEvQmZQ?= =?utf-8?B?bzJ6NkdkL0JPaHo1alF3Z09SM1hPRWdiRTFYQjFIbXpFci9jN3h6dlNBamZF?= =?utf-8?B?SkFuUjRIa2lhUGswN0dpYkErUjFCeDFsc2ZQVXc3T1loR3Ayb3VEZGtNc29u?= =?utf-8?B?TW1ZZjg3bEtGWmxBZGh5MXNYTnFTWisyVTRMT1MzVXRPamhxQlB2bnR0VDNQ?= =?utf-8?B?dUxsY29rS2ZKMDZ4YjQxRWtGRmlweTNiY1JzTWN4UDlma3ZpYTRjcFF3MDY5?= =?utf-8?B?VDkvUEhyTFIwOGpsZ25JYkdUWUtIamhXbnV1c2xvUC9iTVN4MW5wS3Z2UVEz?= =?utf-8?B?YWl4Zi9Sb1FyZVdHTHFkYWo2Smp4bitCVzM0NFlCdGk1VnZTc2FBd0FCdmVK?= =?utf-8?B?YzBmMDhIdllES0p1VGhnNDZOaFl0QkQ2dmxnQVFLTG55QXNIbTN5Z3pGMmZx?= =?utf-8?B?bEdBU1ljaDFtdE5HZnh3UStDMnlxRGRqUWthSkVIWFBuSWFPWEFteFptTEpu?= =?utf-8?B?SlFDVnRFamVJdWF6M3RIcG5vVHR1b2R5YWovblRGM05OVzdCaFJNNVVZTGd4?= =?utf-8?B?WFQ2WVVuR1UrWXhTQ1MrY2gyTUJtK3FGVlB4NVYwUCs3a1lzWC9lVUpvOTl5?= =?utf-8?B?WmdpUzBQM0F2ZXUxcWtNc0NoSEJDNnhVWm1QT2Z0bG0yM3F2S3g2eERMeUF6?= =?utf-8?B?am1hTW1CSUMyS2FBbWdFemFvcFk4VytFSCtpQno2MkZ3M1ZRTmlQOURVNFJZ?= =?utf-8?B?MnJadWhodk5DU2VYc09LcXN4QjF0aFNSVS9udm1RbjdXT2ROYXEzTFZkUTNp?= =?utf-8?B?K1BYaGFENWZjekIwaEl2M3kvZ1JtWmg2TGRnUG1saFovYVIxSGZJTDVDWktR?= =?utf-8?B?Q3pZdW0rNFBZNXNCbTVsczFZVjNYYXhuU1hCNVg5REZxRTMvakh2VndTODBH?= =?utf-8?B?SVMrZ1BtSCt6MGtKS2lyYlRaQ29sQWRzVEFJcjFtSmxGeDZpMXBHVHBDNDkv?= =?utf-8?B?Sk5adUNGVXBPSDY3YVpQc1ozeml6aFhXSHA1QktMa0xFek5BeStxbHYrS1Jj?= =?utf-8?B?aTZNaVVWdktQanZjazlvMkxQNW93dmorcFU2blJYbE1rYWs5UHhyYWZ1Qmts?= =?utf-8?B?dHlTQi9RdmFFZTU0dHFkdUtvNjdSV0dlMmlCbllnWFpVdlRkWElUY01hSm1k?= =?utf-8?B?cXlZeWFSZUZBYkVaTkxsU0JaVHhYUFc2WWMrcFZsUVhIZVhLMHRHN3ZIUlFN?= =?utf-8?B?SXZNd1ByUzJtUzNEaDNwL1NxZ1dESjNHWUEyZWRNOXJnR3BtTEhIZkJ5emU4?= =?utf-8?B?emY1b2dBN2tHYWZrZi9tcndzaVRpc0QzZklzMUlXN0M0Z3A5ZlhpT3BIUjFx?= =?utf-8?B?aHZJY1RZdXNlMGFqMXhMSWJWQ0NZRTlpdzZNTm9xRVVydnQ0NXVyT1BDRmhE?= =?utf-8?B?eHRJKzd6a3pBY0Fic0thN0hQMEM5aWxvVWRLaktBejBSZnkvMjNCa2RVS01i?= =?utf-8?B?bTgwbWd1QmwzSFFBRGM4L1ZmNHNrcGI2c3h6aWJkbU9rclE5ZWVnTGlyaC9U?= =?utf-8?B?Q3hoTXdHNklTWGFhaFcvQzV4c2UrYlM4RkJidkMwSCt0U1NKNk9DaFp6a091?= =?utf-8?B?WFlkVDZ6cGZiQ0c3YVFjSHFWaFAwd1ViMG92V09mVkphbmNpb0F6RTVMK2JB?= =?utf-8?B?N2JnangzV1NQdlpsUEFVSXVBaVZtdGhETVZSbjl0UnArcHlwczlXa0lmVHVH?= =?utf-8?B?N2tMbXVNVXhYemRyQ1BRWVhEdEgwWnNOWmhxSVZGckFCaERhQi9wazVPbHFW?= =?utf-8?B?Mk0wdnRSVGw3UnJtSkZCajJXMHl3b3Q5VkRiZitZQnRxRGtzaE1haHZJbGt1?= =?utf-8?B?eGxjeUNiVGV1ME5Nam1qclMvZ0RabnhXdmtDSUIwckYxM25pU3d2MUlHckgr?= =?utf-8?B?TllIN0xJcWQ3REc3UG8vdmxTTXo2UU9WT1V3OWNxTlM4dzRmYU1uQnhucWth?= =?utf-8?B?cndmRFhFN0tqMmsybkF3MC9lYWdTd3ZYR0llT2R5TkFvdkJKcy9uU003RGx1?= =?utf-8?B?WlpVWjZibFExSWNINGREeUZETGJZREZmMTBNZ1haaDhqbUc4Y3l6b3h4a1E1?= =?utf-8?B?cytJdjQwZVRoV0xzZDdJdzdLVXNKNHczQUFpZGRMUGNPd1p1VHU4WlFoWUdP?= =?utf-8?B?S1RDbDRsaVdlVWpJSDBjemVDd2JkN0ZyendPbGh5RWRTZ0RuRExkM25VVHdO?= =?utf-8?B?WngzWFpmbWhVNlNVT2NNcWJ2d0FBUy9LTGh0OFZWUzhUNjdFeUJ3dFptN25r?= =?utf-8?B?N0xkVGxQTWFudWlQVXU1SkxINHhkRHZmRFFBbUIvSTlLRVorUk1OUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e1a4d1c-ed7f-42f9-e915-08da4255be22 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 16:02:05.7208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OQefZrzKfZ4kauy5NwKUSGS7An+ccNPozFaVNicFyw5EkvboC4KXjH7bP4iBZc86vYLA0aK3+eaeKuE7IoCwCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5719 On 20.05.2022 15:37, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3007,6 +3007,8 @@ static const struct lbr_info { > { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, > { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, > { 0, 0 } > +}, no_lbr[] = { > + {0, 0} > }; Instead of introducing this and ... > @@ -3070,6 +3072,21 @@ static const struct lbr_info *last_branch_msr_get(void) > /* Goldmont */ > case 0x5c: case 0x5f: > return gm_lbr; > + > + default: > + if ( cpu_has_pdcm ) > + { > + uint64_t cap; > + > + rdmsrl(MSR_IA32_PERF_CAPABILITIES, cap); > + if ( (cap & MSR_IA32_PERF_CAP_LBR_FORMAT) == 0x3f ) > + /* > + * On processors that do not support model-specific LBRs, > + * PERF_CAPABILITIES.LBR_FMT will have the value 0x3f. > + */ > + return no_lbr; ... doing this MSR read every time, can't you store a mask value once during boot, which you apply to msr_content ... > @@ -3521,6 +3538,8 @@ static int cf_check vmx_msr_write_intercept( > return X86EMUL_OKAY; > } > > + if ( lbr->count ) > + { > for ( ; lbr->count; lbr++ ) > { > unsigned int i; ... ahead of the bigger if() enclosing this code (thus also avoiding the need to re-indent)? Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 16:07:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 16:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338684.563485 (Exim 4.92) (envelope-from ) id 1nvhvY-0001Ih-Ob; Mon, 30 May 2022 16:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338684.563485; Mon, 30 May 2022 16:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhvY-0001Ia-LS; Mon, 30 May 2022 16:07:32 +0000 Received: by outflank-mailman (input) for mailman id 338684; Mon, 30 May 2022 16:07:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvhvW-0001IU-SX for xen-devel@lists.xenproject.org; Mon, 30 May 2022 16:07:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9abb3eea-e032-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 18:07:29 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-46-QtvCEhp3MAabW-aO7XH-Dw-1; Mon, 30 May 2022 18:07:27 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6327.eurprd04.prod.outlook.com (2603:10a6:20b:73::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Mon, 30 May 2022 16:07:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 16:07:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9abb3eea-e032-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653926849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0CRrXU6hBOHrwo6HUFdMLk90F7DGjnBpQQa+q6a6InA=; b=IUX09qEJ94HVOCqx528zfGWF/rcz1x8mxrMjmTjoThScIoAv9LMyfshHxBTF6xu/6NueL/ Q2mF2588FJ0VVbhvrJNbE9npMjzI3NP6A0Ls2kpidy5cFnzZZn01csO8+N6wbVSHuOhUlr 7/GGGUKz9yE2NBnjb+zD/u+EAgTRA94= X-MC-Unique: QtvCEhp3MAabW-aO7XH-Dw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhP/M9nTw2hG0oDnESPLD+ZOoV9ZvQJRR0T0K3aP1MfNdt4+haUsP05PvJbuOrFtc3eUcuAh5AURlNgLmz9mbZpmHjie9TvaHbHjKj1igz4jSwgqaMiGGQryS1RsxzQAXBkyCcZmnZioImINH5V2MTr7ZJFwmHhaWt5djzmluvPRZgJ4ruuf6ULIOn7Q/jaRrOs46LulwqbZ9AwNz5Lc0ydi8LXo0SdxlhyroVRrvW0JyubdY9S2AJha/8S28cx1WpmvJiEHgY09jCsQ3bzaumGskSHmCDY9LvGx2vS48wHaJkBm6t0ZKjKW4kXU7TLTeKPLqe+LrekAgRWTqyMsoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jP3OldByQNgi3aLknkPv0jNYUP6XcA/mWBkKrAJ6ZNs=; b=T9qRFCWvSVVETkYlagYRo7qLzQxE1hzbL4YmUubHFYF6qMi9yKdqHJwHyx9w4Wde3kRXgBqeOoGN38C2vvFQ04frBFQqIpLJ3FLkI00HCo238ds1cO0I01DJy2O/dbIBElWibWbQsPJGKbLpFC1wWJiqn6MisDokX8/nfwe7W7R9V+Rm3KMryONGAQ48f5oyJYBL8uz8B6fTsRBqBOXobmaefkIMW/Pz6/hzEZFTVYXWraA9WbYhG4hRGQmZgEdX1gc0+F5jp75GtaRgaVLVBChsuJJv/FuDsBB7ZqL3XhRTYjJmsUS2vF2+IvpEbqcJcX9QxUucNhLGwiSTTmJyfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <21cb8b91-3d7f-5490-ea8d-38ab18cf2dcc@suse.com> Date: Mon, 30 May 2022 18:07:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] x86: harden use of calc_ler_msr() Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0101CA0028.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::41) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee43f3cd-dda9-4103-c8fb-08da42567cb5 X-MS-TrafficTypeDiagnostic: AM6PR04MB6327:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sfxDXSM2sgL4WVtByw5ez4f3jAAZUCedp7ipej0KK47gnbSul8SUJZ5pzr/iJV1eLGuDruxDuiVxSDG2okov5fT+CSCeegUJOpQ2v0i3JcjHX0SKlRCIE/WKrD5Pt6viea9w11VCWLXCneIPfJWxG67joGiDQ7c+fMj5mdi1nG20lScbr3k2QRSxJw1IJEtcr5IwOee9m4YIQmcOy6CUsMaz3MBdvbNDGToYigKjHzLTW+hPwRH4fkQAB2VQhbLVaaQtJorUVqt9bsKqRlnjID4P2GBLN7aJWzP2IsiEGegQ7l4L1+GHz/hz7QnlUBuc7qfB1ho7RQnPwp4qxg+PWPNWgw5lwwZEnkO86ODbD67INj4uAdoMNepoAv1QScCt84inP46U1SPIbf4zKtrZDr/92qF0MQsONP+iT/kqPsJQ5ECKft/SE/qtRWM8YbChngkvj4elpScRDzOn19gRr6mYY7arIuYyXVXF+LwCXoDeVhMEGUutdQBnbe3IQh1jGSUtG5EuxNIg3deV9/+NBJoYJFP5dU/Jw1C9M6PwuxfdoEubFmbcwEEM0n8jz/BgW5zQw8DJoDoVO13cReGy7UboC9L7JuXDUm/RgLpp/4e0i1iuDpXpbuYqhSDTUQAPOOxAX1h7jW9RH9Q/NTlT3XeqrhhB8ybmGqMorukMeLJCNEaW1PIwjOJO+aG+p7je3++OhGtk5F3u1VKCvgZer56f66kSQ10QVE1SWnDLA8hk5bQWBsqW9tXfVhJk+zbktPoQ7v3vhq6eVtKtjnZ0Ow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(5660300002)(6486002)(53546011)(66946007)(8936002)(6506007)(86362001)(31696002)(26005)(6512007)(6666004)(2906002)(66556008)(38100700002)(2616005)(186003)(83380400001)(31686004)(54906003)(36756003)(6916009)(8676002)(316002)(4326008)(66476007)(354624002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y4vJa1Ffohwc5JssJXa71J+fWf6A2FM+ptfsZonkzncCdQ5WoYqTNkFTH/Ke?= =?us-ascii?Q?T2oXzFYn5QOT0l3XNnxemwsrm4ba1QpXkR/MhCyFP7FfmbKDtu/+7p/OGeb7?= =?us-ascii?Q?i4hXztyfAE0jc1791I+zkcSHo09MvhqSHfG+G7ccD/tiG/yCD5MCoR+WCfVE?= =?us-ascii?Q?uP+9YwAQ0JzB5JALv9fVMkQx9Y+32Ma+szJDjIWX1ZBnjR2mwyvwNX07plpA?= =?us-ascii?Q?6x8BLTuPzjvcMyYuWriJN+M4SBbFurD3QbG7mDt2EjF7AtixiLGOUCQ/ACei?= =?us-ascii?Q?2WLMw//LxmSi2DuDC3CXGGXCJ6WcJVRdVbFTjOpMhVS9ZXMcvL4t+fA0/jyU?= =?us-ascii?Q?j8PI2pluJYyO/8KRPhr7bhXC94WgPyQAfuXRVzsWIuEUY0IxLI2iLHZ9/YcN?= =?us-ascii?Q?Ldq+TJN9GTIfjPV634Kgx/pukdmWLq3PDCcqSlBVa/i3ZIHlcPYa2fGAQ1cS?= =?us-ascii?Q?ns9naHARM8/o81m02DjX9JmvjoZUZ0or0cuqAjgtjuvqWfHiJdDliRTu0oSp?= =?us-ascii?Q?uOiu2G701U6mc/GAlhvkLKxAEGOuoiTj0jutOhS2j7VvkFpkv/2XR0Shnq2t?= =?us-ascii?Q?r87U7sa43rVEehZ6qlEZJPZAYMmDLlgfQnfiFQZGVBHIQ2CtkjLPxGShgQJP?= =?us-ascii?Q?DOgsILtB9F+oj3l1bcRj+Ap6ncrbdJa68O7PwOlWE5WjZliB/1k+9nruPN/J?= =?us-ascii?Q?8uDspyzdnNeVi1nSuUbHfCd+l000YvVDXI13TpX0jLHRM2XPrgvJzAPHYo8w?= =?us-ascii?Q?aGYE+h81D40eWFhFO4OjmsCyKBJY36IKQtvfOA8/sMxZ4z/11RDY64Y3t5pj?= =?us-ascii?Q?xbz4sd6kQTyER1Q87Zg8XLSajQw11RuCjgpnm9E0S0Nxz89wfXxKznlkKhw3?= =?us-ascii?Q?9K6JYJ5jOzln8VRYkTE5jJYvUSIbQvbnmGhY58aJRg3o9+nfK9gc62+UIJTL?= =?us-ascii?Q?zkXkTbFTi4XgmqoODnKydUxJElTyVWQm6soCN2JUrKQi2Kydi1kCJpS66oiX?= =?us-ascii?Q?yGlPwyJoKW7zhmxo0dmfsj6VB3MATNNrv6a+voWbmZNNEeT7yd9x3g0egmhS?= =?us-ascii?Q?fC4M2LjSiMnqcZTTsblRCTcfS9Tu+GdPl2Ej8NBrjMt5tStdahilTXrY1luR?= =?us-ascii?Q?r7jtnIex4WhyGU1+5TflvlEjNsb/Vw+53UNwonOHic8ZX2OzfFLEBBOPNjdV?= =?us-ascii?Q?eZas3xWk2HiT0s7KJQE3MzzU3kbUF0ejICtB3b1C1fUqTT6rz7Mw2JoXK6gk?= =?us-ascii?Q?Ynbi2/rUjgVA6bzU4zO/DLIju+o4FuIKB0eGd7eita9knsuEGuAFcCxJgxFL?= =?us-ascii?Q?0gc5C3pLHtFL2EHrTgdAn3ZixJGnoHgRSpsgj4ET51kdMKbvKmAvhdms4SH/?= =?us-ascii?Q?8iBjn01Vol8tG7beI3U2h57GyY42IGVCJaNSZoBqR1etimeN6y3lQ9pX980l?= =?us-ascii?Q?FohNq8vzfH5aXnxx5xvzah3+rJuxkV+Coe5LJIpGCt7Fj/Ndl3gUHoG+MCVA?= =?us-ascii?Q?uB4QiKJkfYkWq99uiluRx4IYI23cCoeRZ48pgVWSQ6lD3GK/awP49gE++Bdv?= =?us-ascii?Q?tyb34UnU/ve5SFPCt8JyesiI7FjECQIRv8CJSUpb6Paf3XHc/xPxtaY8mOEM?= =?us-ascii?Q?13L8JvY4x/xzz3ocUJf4Ia267E9O5FCvpa3yIp4e0FZOz4O9IhvjD2ePm7vH?= =?us-ascii?Q?G9yZfA0o8dnuI5uHj8i1j19fHaXbUrN1zW2OR42PPWNJ5z0A70Ro58Nt6ZDX?= =?us-ascii?Q?4pjyzPhB/w=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee43f3cd-dda9-4103-c8fb-08da42567cb5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 16:07:26.0911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bUd3jtM2fF4YnAGj+9X5vgjTtS02rbboOFBkum6CFxUbTuxxYJBZtyS3PyyuhYpjsB368nqwPkwkqjtKSUrOPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6327 On 30.05.2022 17:58, Roger Pau Monn=C3=A9 wrote: > On Mon, May 30, 2022 at 05:48:51PM +0200, Jan Beulich wrote: >> Avoid calling the function more than once, thus making sure we won't, >> under any unusual circumstances, attempt to enable XEN_LER late (which >> can't work, for setup_force_cpu_cap() being __init. In turn this then >> allows making the function itself __init, too. >> >> While fiddling with section attributes in this area, also move the two >> involved variables to .data.ro_after_init. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -126,11 +126,11 @@ DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_p >> static int debug_stack_lines =3D 20; >> integer_param("debug_stack_lines", debug_stack_lines); >> =20 >> -static bool opt_ler; >> +static bool __ro_after_init opt_ler; >> boolean_param("ler", opt_ler); >> =20 >> /* LastExceptionFromIP on this hardware. Zero if LER is not in use. */ >> -unsigned int __read_mostly ler_msr; >> +unsigned int __ro_after_init ler_msr; >> =20 >> const unsigned int nmi_cpu; >> =20 >> @@ -2133,7 +2133,7 @@ static void __init set_intr_gate(unsigne >> __set_intr_gate(n, 0, addr); >> } >> =20 >> -static unsigned int calc_ler_msr(void) >> +static unsigned int noinline __init calc_ler_msr(void) >> { >> switch ( boot_cpu_data.x86_vendor ) >> { >> @@ -2171,8 +2171,17 @@ void percpu_traps_init(void) >> if ( !opt_ler ) >> return; >> =20 >> - if ( !ler_msr && (ler_msr =3D calc_ler_msr()) ) >> + if ( !ler_msr ) >> + { >> + ler_msr =3D calc_ler_msr(); >> + if ( !ler_msr ) >> + { >=20 > While doing this rework it might make sense to print some message > here, like: "LER option requested but no LBR support available" or > similar IMO. Hmm, yes, but you look to do so in your series already. Could we leave things silent here (as it always was) until your adding of arch-LBR support, and then taking care of both failure conditions with a single log message? Of course I could add a message here just for you to then (likely) alter it again ... > The rest LGTM: >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks, but I'll wait with applying this. Jan From xen-devel-bounces@lists.xenproject.org Mon May 30 16:16:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 16:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338694.563496 (Exim 4.92) (envelope-from ) id 1nvi4U-0002qm-TO; Mon, 30 May 2022 16:16:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338694.563496; Mon, 30 May 2022 16:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvi4U-0002qf-Oi; Mon, 30 May 2022 16:16:46 +0000 Received: by outflank-mailman (input) for mailman id 338694; Mon, 30 May 2022 16:16:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvi4T-0002qZ-I0 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 16:16:45 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4367d39-e033-11ec-837f-e5687231ffcc; Mon, 30 May 2022 18:16:43 +0200 (CEST) Received: from mail-dm6nam08lp2049.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 May 2022 12:16:40 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BYAPR03MB4680.namprd03.prod.outlook.com (2603:10b6:a03:139::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Mon, 30 May 2022 16:16:37 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Mon, 30 May 2022 16:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4367d39-e033-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653927403; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=53bPoT6QT8yPMZywDq9T1fdGNhjk67PJvP3VUrkkI8M=; b=aE/49jqAOJ523N9PA7ijym8ZoVXTYjrolnHOlupd/nSARvj4y2AMTQAO XjISsBdiS6F2OsVIHMiaU+okKX4R2gKB3KlUcOc/hxj0lDMI3ZPw1O8ze SK0f7/b26ivYxOwlafmD1Fcop8QU7YVOUagjXJYknsUSuTGbUw6NSSU1K M=; X-IronPort-RemoteIP: 104.47.73.49 X-IronPort-MID: 72458040 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pvCfGK+OJ2btAoAR/4wmDrUD9X+TJUtcMsCJ2f8bNWPcYEJGY0x3z mBLD2zVbPeDMTH1LYsgOtvk9E8AvMDdy94ySlNurC48E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPhW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaatSj4vHIj9pMEcdSQESA1XJ6hho7CSdBBTseTLp6HHW13F5q0ySW0TY8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHP6MuY4wMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKWEF+ArJ/cLb5UCQkSxf4KDkaOHla8WYHOJpnmmfg 0D/qjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsb5dw21pjiDpBF0ZjZLO+gz6QXIxq+K5Q+cXjgAVmQZNI1gs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/ g== IronPort-HdrOrdr: A9a23:FkCrNKF3vTm0acw1pLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,263,1647316800"; d="scan'208";a="72458040" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6RP9KjUyvzf4pViP0tc/p1VAv7n3JhuhpbZwvSHPATCUGDMorPxwG0ZAUnrZ8UCXE04/mpzoe8FD/rFRnGXf6Cz6mD7GZNjpApl+5be4QRfRwyJGHMPRBCLnKuf8SG7pnf49babkDd7lV+rWuFC0kBxFTu3he+BjE3IEI9dkBcMPldkK0fdGSxXcAKwV6QopDePewR8rKPCFtnvXs4RYqqBcshQb0L2DvCg9iKow1GVmVFYmWfg7XZ0aXjFqFgpXO3wBKiawvnWfBOKA8YzANOc3E5lu/0oPQ1blgVs+wHC+QdmnNTJOeRAx9744scwYsSyGnkb8vshfI+wYDKWdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwLUE4SfM5xfy2ULcIw9uUs7OnSu2cPnd1ruBooiV1c=; b=JX7qbqVMrhysNQsoUVcMIR4aiCDwtHIGIA+VveIu0Zz4kv3SsfRlYG2A/399D+27kfhsPuGzYzeObpu2MDPUjdevq5gAE2YPYEphKw2Jm9/A9i52TCktxUDubNDK72NLuy61rfQ87xLoel1+KxwGwZnkBRygKMXPqA7UOVZpqz7/zDgPwMMMOT+AYOSczTWYkctM7vnlQwNylYKEze4Hy0kjWBy9Lpj97C+Vc82lY5sKJ+WNVrkxXM/VrdksHe43UTjIDKJ+rW7X277mB0++FaiME4xKjevZ2/3mUyNBN0xdGin/2H9Z2aktIP1+O+czg7J7F00ZgxymciNA/Iaxtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JwLUE4SfM5xfy2ULcIw9uUs7OnSu2cPnd1ruBooiV1c=; b=XEgC8mG6ry5EMn5M7XGD9sNdS2c7bq4Rn0j3LbCMWULO3IuayFBDKXSw9aNYJinO20jYXWRuewhhVJW5azq0zQ9pvmKPMfoBiUvKxv0jlLe74RE4IE8jFnMYtliz59iCt3wc2FdRNn67UP7nS/GMquM7rDrh7bLPWwbtLqNQeVY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 30 May 2022 18:16:33 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH] x86: harden use of calc_ler_msr() Message-ID: References: <21cb8b91-3d7f-5490-ea8d-38ab18cf2dcc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21cb8b91-3d7f-5490-ea8d-38ab18cf2dcc@suse.com> X-ClientProxiedBy: LO4P265CA0179.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6424e13f-84e2-4d4d-6e75-08da4257c556 X-MS-TrafficTypeDiagnostic: BYAPR03MB4680:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hg6ZpvYajKCL+sD1ingUW4L+viepyPc05P40Z08sqFK6zLtnkqJJZrBYAV5E7mHzgNd+BsO08+3esBdDguD0JbwKGg0sZbw0ghV/LO2H17A8r71YXLs6oYY9aE9PNL2JZBByYfEVorRNsRfD9rcOd34WVQ+U3s1PMZqguswqQjtX3YJa3RHJqafJ85cfoe0Ci0QQnd1M3CiRNUsU8StatGCduaL7GVCrXKj6LxhUyiV9ySlZscPxxJ5CjL7zbXXmfgyrG5EOZJsgi4z0Hyg6WTSrDAvkhd4XsDsFOGg0ZTHIbYhSdYgqo77G2e6WS2sBAzNgQXH8MD54DXVGPVYM62f/1lphZafXdaD2wYaO7ROfKeuPq73+lvJRELVGAxfdsDzAcSIlmPKMckFT1DCq3x5Hh0nAASQEHiGPpEwpiqn1I6S/Tnae8JTusCcW3rJMndtIync8rO2NmXL1/cG/cFj1nnnT7Fte/gyswMGJn+we8ybGHAJXfN4xcL/bsE782v/u73IXp6j8TaKP62XaUqkZgcVFdonbvON5zjjiPbMrvFXR0MJqdwqnjizhkoFHOURu2k59JGeYuiMRmG4EYewB5a47XUhMDWHYj6DGvCmlQvG51+0rO1bSwrrFXdQEUHNMEYBwGSQkg+X0wYRaN0/seW+rtTboU8j/h1Q7F3AUK2CN5ex59Cgm5zaBRuhYJC42tqGFB74Nfwoxe8OwMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6916009)(316002)(86362001)(85182001)(2906002)(5660300002)(83380400001)(66946007)(66556008)(66476007)(33716001)(4326008)(38100700002)(8676002)(186003)(8936002)(6666004)(82960400001)(508600001)(6486002)(6506007)(9686003)(53546011)(6512007)(26005)(54906003)(354624002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a25PRmlrNUJQU21wWmFsR0oyeUpwUk5VOTdZYlRMczU5M3lzdGJZZDNGVWVo?= =?utf-8?B?bkFGM3RISy9rMTZjMmtkU3JEVTF5M3RqNi8xWk1VREQ4OXU3M3ZGb3BTL0hQ?= =?utf-8?B?YkMwbk1jM3RjczZ3Z1JRd3JySk1NVVNmaHFuMTFNSVpMYXppMzVOM1hDcU40?= =?utf-8?B?bmNjOEF6MTRNQ3Y1TlNxNjJ5VG5IOFRMZDlBOFdVaTdnZndBcFlqMzJpczNG?= =?utf-8?B?NVZxVkZqVlpMcnI0MnZseXl1L1Fqd1ZZOVJGMGJRMnZtTktVdEZ2eFpaNjVU?= =?utf-8?B?cW9JQkwyaGFkM1UxbWc4WkFsR0tNRVp6VFRtQTE1QlptNHcvbENpekpjd0Jj?= =?utf-8?B?TXowbkRadnhJMTJiZzd3MGN5R3p2bUZqMldlcSszR042Q2JTU1k4OGFLSkZ4?= =?utf-8?B?YUQ2M3NJL0tKY0tvamk3czNSMm9GTzQ0VDRBcFUxMkNqd1ovQS9ablRsOVoy?= =?utf-8?B?cmJIcThtSWRnMUYrYS9Eb211d21zdHkxMGkrY0FpNmJRYjNvd09CeGtLQkFz?= =?utf-8?B?RFAzYStsMUF2NXNZdkVBOTRmNlgxV1ExeStPc2J1TDRMOVZwb1UvQ3Q2L3FB?= =?utf-8?B?aFJYZ0VhdGxQVFc1b2QrT1VRQVRUOWlVUkRQdHRKaUdqL1RqQ1E2dnV0WE1t?= =?utf-8?B?UmN6UENsM2Z0YTZaWlJTWDhPM2lleUZqY2tkZHdNN085QXFaN3lRNmZWS2Yz?= =?utf-8?B?eXdGazBpeE1td2NqSGlLQUp6ZVQ1YnJQTzRhZXc0c0NVWkhHb3l5WGcyUTh2?= =?utf-8?B?aW9IVStiU1VtNEpVNmN6Y2RFVTd5cmk0M2VGTWpxR0ZvN2plTjNyWmdwU0lX?= =?utf-8?B?TkdDR3lPQXZTZGZvSU9rMnlzYzhmYyt3bmY4alpNOXVZeU5PeFhTTVBOT3lP?= =?utf-8?B?VmJqbUxrMXdpckxONmk4ZXJMb3BUejRBazZURlp2akp5M2dsTHJHU29XdUlp?= =?utf-8?B?cWhXbitrMlgrVFRTN2xaaHNiUktiazF1VVAzK3l2LzNCbmdTMnRCTmF4SDVp?= =?utf-8?B?MkJvMGtHRkNITmViOVB3ODh6L0NNZlNjbVF2NEZyYlJOQ3dSNFNrU1BmcG9j?= =?utf-8?B?NnMrMy91OXNlOGJtbldoQnJzeCtkREljTmJYbHBqS3U1NTVya293TG5DL0NY?= =?utf-8?B?aTZWdStaem1FejdiKzRVcnd4SmlrK0NBcUxmYzBGdzVCL3VYdFhKU2tLMmxU?= =?utf-8?B?cFlKRVpwZWJEMnEwQ2pGcVg2OHhxRnZZQnhEYmlkLzJVMlE5dlROYlpCcWl0?= =?utf-8?B?MExhQyt2ZjRjODVwbUl4aGV1SXpNN0pmSUVpS1R3S1FkMXI3aHNjbzlxWXg3?= =?utf-8?B?clh2dFlmbmZkK2d3bFkzTWxEdzJjZnpvVWxZUk9pVmV6eTNReFFXZmZRc2Vz?= =?utf-8?B?b1VCcmVkb1BHZ3J5UFVnRlcvQjhvUEJuSmJrdTJPd2kweU5uQVJYUlpKZGZX?= =?utf-8?B?S0EvWlBuWmIwMGw3eHMzNWZtc1QxVlgwVllUeXBsTGFEelFkM2F3b0FaREZD?= =?utf-8?B?NkxHb1hJMU5PNmhVcXVRdVd3OFJ3MmppZmJzTklrcXhod3psOXh3NDBXQmZo?= =?utf-8?B?R3NsbDUvdWJ4YjBzd3Q4K2wvU3o5aGNsMm10UE1QUFl4VVk2ZHI5Uk5XRlhi?= =?utf-8?B?bm4rSGZGbHhOT1U2ZnJLZ25GUG1wYkFvakIzY2lRZmFpK1J6dUExT08xSzhx?= =?utf-8?B?blhkamJPYk85cDlQU251ajRra0FHZnJmdkdOMGlLY2RyL2VyUWgzcFJSL29N?= =?utf-8?B?ZTFaM1hVRnc2UzdrZ3NzeEV3OTIwdGM3S0ZPTmpsckFpUWNYQ1pvUEI5RUFO?= =?utf-8?B?QkxQUDdiQldESUVadzZTeFlZWnFhZ09ORkZ6OEJzVm11TUY1TW5ud3ZWd3M4?= =?utf-8?B?TVdlc0MycGk4amFQQ01tVTVzT3NqclB1L2RTSVJrYTFwNlRSYnA1NXJmck1C?= =?utf-8?B?Vk5ScTM5TU9HSFVxOEw4T3ZZaUxzMDlDNXlkOTIwRkxBamYxaG5IL2hLOUdw?= =?utf-8?B?blozcG42L2IxUXQ1QnNUZE4vcW9UenVQREZIYkxCRmpyRUlXK3h4ZjZ0cXpu?= =?utf-8?B?MkdXcFhVeHo4dlp4QjhoenRHMDlrR2JvNTdoL3hVSFhVRkpTZTVwd09hYXZa?= =?utf-8?B?RjdySldhbTNQNllZRDhVb2c4enFsRTRScGR5TkNsZHBwL0N2c2JaRUdOOUZH?= =?utf-8?B?QkJJZEJqUVlKTDNVYnlEdUxTTUJ2NndDRk5jYXFHbFdLMHBxZUZESUdLb0V2?= =?utf-8?B?aVdBd1FDVEV4eXM3aXV3eHlIam9pRGJSVSsvVnNrSVlJRlUzMnFCSmRnQzkx?= =?utf-8?B?VkEwOHRZcnZ5blY0VVRrMTV3OWdPUTROWnNwdzh4Tnh1STkvMGxxZHpGeUlM?= =?utf-8?Q?gGbkSHms2zZrNNac=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6424e13f-84e2-4d4d-6e75-08da4257c556 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 16:16:36.9065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TzKyszp6DrHaQNvC4g2W2yIrCT+s1s3efpRtEhbNXc3tZDuaD5dzayHxJejMwBVWk+bbLf6U7Cj5yCSqY28gcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4680 On Mon, May 30, 2022 at 06:07:23PM +0200, Jan Beulich wrote: > On 30.05.2022 17:58, Roger Pau Monné wrote: > > On Mon, May 30, 2022 at 05:48:51PM +0200, Jan Beulich wrote: > >> Avoid calling the function more than once, thus making sure we won't, > >> under any unusual circumstances, attempt to enable XEN_LER late (which > >> can't work, for setup_force_cpu_cap() being __init. In turn this then > >> allows making the function itself __init, too. > >> > >> While fiddling with section attributes in this area, also move the two > >> involved variables to .data.ro_after_init. > >> > >> Signed-off-by: Jan Beulich > >> > >> --- a/xen/arch/x86/traps.c > >> +++ b/xen/arch/x86/traps.c > >> @@ -126,11 +126,11 @@ DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_p > >> static int debug_stack_lines = 20; > >> integer_param("debug_stack_lines", debug_stack_lines); > >> > >> -static bool opt_ler; > >> +static bool __ro_after_init opt_ler; > >> boolean_param("ler", opt_ler); > >> > >> /* LastExceptionFromIP on this hardware. Zero if LER is not in use. */ > >> -unsigned int __read_mostly ler_msr; > >> +unsigned int __ro_after_init ler_msr; > >> > >> const unsigned int nmi_cpu; > >> > >> @@ -2133,7 +2133,7 @@ static void __init set_intr_gate(unsigne > >> __set_intr_gate(n, 0, addr); > >> } > >> > >> -static unsigned int calc_ler_msr(void) > >> +static unsigned int noinline __init calc_ler_msr(void) > >> { > >> switch ( boot_cpu_data.x86_vendor ) > >> { > >> @@ -2171,8 +2171,17 @@ void percpu_traps_init(void) > >> if ( !opt_ler ) > >> return; > >> > >> - if ( !ler_msr && (ler_msr = calc_ler_msr()) ) > >> + if ( !ler_msr ) > >> + { > >> + ler_msr = calc_ler_msr(); > >> + if ( !ler_msr ) > >> + { > > > > While doing this rework it might make sense to print some message > > here, like: "LER option requested but no LBR support available" or > > similar IMO. > > Hmm, yes, but you look to do so in your series already. Could we > leave things silent here (as it always was) until your adding of > arch-LBR support, and then taking care of both failure conditions > with a single log message? Of course I could add a message here > just for you to then (likely) alter it again ... Oh, so I do introduce one, sorry I didn't remember. Then it's fine to go as-is. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon May 30 17:16:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 17:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338704.563507 (Exim 4.92) (envelope-from ) id 1nvj0O-0000W9-DH; Mon, 30 May 2022 17:16:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338704.563507; Mon, 30 May 2022 17:16:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvj0O-0000W2-9Q; Mon, 30 May 2022 17:16:36 +0000 Received: by outflank-mailman (input) for mailman id 338704; Mon, 30 May 2022 17:16:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvj0M-0000Vv-Ul for xen-devel@lists.xenproject.org; Mon, 30 May 2022 17:16:35 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f3824bc-e03c-11ec-837f-e5687231ffcc; Mon, 30 May 2022 19:16:32 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653930988362815.3065671106809; Mon, 30 May 2022 10:16:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f3824bc-e03c-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653930989; cv=none; d=zohomail.com; s=zohoarc; b=FZSmp3w6yb9TuGGL/tLA4W9hnHp5WDTpLElYoQsekbmyhBNRVHFhfqRc75HGvMH8zYHkozukU9iQrJMFxY9VPjgbNe2iq00L8bv3e/wryT5KIjzlnSdaYOaMNFUYDSIdrjAV0ClK1Hfd/dy0hKoXhfJknzNw84gOsYnzHdJBLYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653930989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=vEH37xc67Ijg3jQLE7drU5kLQbof2IZGxoa4VwC/JJA=; b=D9qHgPnBkg0LmOZqSpAamt8V/zydi9ktLdTaFijg/Av356APZpo19YH6diP7HQLe73ekgGXSy2ngF32+QI7M+6n/cZOPsIHgDVZYSx0OpnJYJ6rjZ2BpdeySU8oNXnq0jlo1vM+Z/aSt8NkNcmaYALqDHQetK+R1wJ+izGlRWhY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653930989; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=vEH37xc67Ijg3jQLE7drU5kLQbof2IZGxoa4VwC/JJA=; b=bHT54zAEXy0zwUQS8tv84Fj3LridkfQyE7HlxqxXKTi9bvMMEMdT2hxHteo47wdz iIaePxaoNgqQ/9gVHsXU9lRMJVmUslzNE56cj68WQ8uBehgrVVQrCxLn1tZfr1nsfLL 0GAL6koLpHVwLJesBMzKWgsdmqNB/H7KrYPFkqEs= Message-ID: <0c894277-85c1-faa7-a360-a82531733f12@apertussolutions.com> Date: Mon, 30 May 2022 13:15:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: xen-devel@lists.xenproject.org Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io References: <20220511113035.27070-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: PING: [PATCH v7 0/2] Adds starting the idle domain privileged In-Reply-To: <20220511113035.27070-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/11/22 07:30, Daniel P. Smith wrote: > This series makes it so that the idle domain is started privileged under the > default policy, which the SILO policy inherits, and under the flask policy. It > then introduces a new one-way XSM hook, xsm_transition_running, that is hooked > by an XSM policy to transition the idle domain to its running privilege level. > > Changes in v7: > - adjusted error message in default and flask xsm_set_system_active hooks > - merged panic messages in arm and x86 setup.c to a single line > Pinging to see if there are open issues I need to address or is the series acceptable? IIU I am missing an ACK on patch 1 of the series from x86 and sched maintainers. If it is already in your queues, apologies for the nag. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Mon May 30 17:50:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 17:50:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338713.563518 (Exim 4.92) (envelope-from ) id 1nvjXC-0004dp-2D; Mon, 30 May 2022 17:50:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338713.563518; Mon, 30 May 2022 17:50:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvjXB-0004di-Uj; Mon, 30 May 2022 17:50:29 +0000 Received: by outflank-mailman (input) for mailman id 338713; Mon, 30 May 2022 17:50:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvjXA-0004dc-0Z for xen-devel@lists.xenproject.org; Mon, 30 May 2022 17:50:28 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb5111e6-e040-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 19:50:25 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 94CB55C0076; Mon, 30 May 2022 13:50:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 30 May 2022 13:50:23 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 May 2022 13:50:22 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb5111e6-e040-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653933023; x= 1654019423; bh=HYNcAzcvwA3jPOCMpvHYfWi0Skxi5GTfqaUV0qrK9gg=; b=S pth8jQdSuwO44sgJMv3Y/gIHQTpHZs7u2XzstVORSqkekW5iLTQthWKeXk4kdDGs mzhaH4W/e6bDoH9yiD3hQiUzRhquJZXpWXJYU9jdwWJgUykV7GJg/rbfB1pTKVC0 4pXA4P50DLAHQX35VMnzfZn+4RNmTZ7fXz6EqM6AMl8e+EJ+e/Pr3JbPfivGwVc9 AesmDKjQw+gSd9z4g60SEyyoSD6eeoS+UWFTwF3rnsnlLJMt7Wpti04xq9X6eRCD XH2XuDRuPeUtBMT0LhiX1zPNVPwMl6Bbvw2mNo9KAHB/610qmgwLenAAocAMmy84 UqFyzSzZaViuKAG/FNQxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653933023; x=1654019423; bh=HYNcAzcvwA3jPOCMpvHYfWi0Skxi 5GTfqaUV0qrK9gg=; b=motbhBUaedsrcp8VBHcEXOM7zJtYgWkWTCLIGce60Pex NgePkc1lkZcnd8qB6TuXgfKQ5CabyBuilZzHTNKlIq1QLOhw7ORU3dufS8wBOlhr BI37skxdCWZ9uBQ/gRoJ7w+TbWm40CZur8ERsdUwVY1tpTpDJbKpbuan7y2f9FpL ireLzXAOVOsQf2WTIRxEhimz0lce8mUy31JZsi70fjXJ+oYmkXKR2Xontut+FvZq tSz+SQKT6TVHhAdRKAfkIq22eqHXJ8wS7MNip4IehFsMdCeW+yHv4CZ+zDUUEdB3 +vF4YhbvgMOIRhaicG61Myv3HXcMgnl8wyaorZ3eCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeeigdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuedthefhtddvffefjeejvdehvdej ieehffehkeekheegleeuleevleduteehteetnecuffhomhgrihhnpehgihhthhhusgdrtg homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 30 May 2022 13:50:18 -0400 From: Demi Marie Obenour To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages() Message-ID: References: <20220525184153.6059-1-demi@invisiblethingslab.com> <00c0b10c-a35d-6729-5b4f-424febd9d5a3@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+4H1oyCNBJ2i7PTh" Content-Disposition: inline In-Reply-To: <00c0b10c-a35d-6729-5b4f-424febd9d5a3@suse.com> --+4H1oyCNBJ2i7PTh Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 30 May 2022 13:50:18 -0400 From: Demi Marie Obenour To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Jennifer Herbert , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] xen/gntdev: Avoid blocking in unmap_grant_pages() On Mon, May 30, 2022 at 08:41:20AM +0200, Juergen Gross wrote: > On 25.05.22 20:41, Demi Marie Obenour wrote: > > unmap_grant_pages() currently waits for the pages to no longer be used. > > In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a > > deadlock against i915: i915 was waiting for gntdev's MMU notifier to > > finish, while gntdev was waiting for i915 to free its pages. I also > > believe this is responsible for various deadlocks I have experienced in > > the past. > >=20 > > Avoid these problems by making unmap_grant_pages async. This requires > > making it return void, as any errors will not be available when the > > function returns. Fortunately, the only use of the return value is a > > WARN_ON(), which can be replaced by a WARN_ON when the error is > > detected. Additionally, a failed call will not prevent further calls > > from being made, but this is harmless. > >=20 > > Because unmap_grant_pages is now async, the grant handle will be sent to > > INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same > > handle. Instead, a separate bool array is allocated for this purpose. > > This wastes memory, but stuffing this information in padding bytes is > > too fragile. Furthermore, it is necessary to grab a reference to the > > map before making the asynchronous call, and release the reference when > > the call returns. >=20 > I think there is even more syncing needed: >=20 > - In the error path of gntdev_mmap() unmap_grant_pages() is being called = and > it is assumed, map is available afterwards again. This should be rather= easy > to avoid by adding a counter of active mappings to struct gntdev_grant_= map > (number of pages not being unmapped yet). In case this counter is not z= ero > gntdev_mmap() should bail out early. Is it possible to just unmap the pages directly here? I don=E2=80=99t think there can be any other users of these pages yet. Userspace could race against the unmap and cause a page fault, but that should just cause userspace to get SIGSEGV or SIGBUS. In any case this code can use the sync version; if it gets blocked that=E2=80=99s userspace=E2=80=99s problem. > - gntdev_put_map() is calling unmap_grant_pages() in case the refcount has > dropped to zero. This call can set the refcount to 1 again, so there is > another delay needed before freeing map. I think unmap_grant_pages() sh= ould > return in case the count of mapped pages is zero (see above), thus avoi= ding > to increment the refcount of map if nothing is to be done. This would e= nable > gntdev_put_map() to just return after the call of unmap_grant_pages() i= n case > the refcount has been incremented again. I will change this in v3, but I do wonder if gntdev is using the wrong MMU notifier callback. It seems that the appropriate callback is actually release(): if I understand correctly, release() is called precisely when the refcount on the physical page is about to drop to 0, and that is what we want. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --+4H1oyCNBJ2i7PTh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKVA9wACgkQsoi1X/+c IsF9ZBAAikctLY/AMtbOiBJtLzm10XD7eKKXsULHrVKCvoqXCVKzLGw58uboGyGB hrLD5nM0b5fkiOdvsHuau4hm72mJIX7m/WBrtpUStMeipOUl5dZWNuz5NENNGnsx y5zafYGmc3VSx+bAv7+K8xb8GNJCX9HkNXT4frPrnYPSC4b/SzFpdxQyCQhreyyx 4w8FYVcSC0piMYJ5qY1JfZUIukFLGoCP0ckmn/lsjeYkTCG1FdxMYUdgkD7bLowr a34wI8z5a38UKADYZMdCdKuDR7zVvdj3hMrmuRsQygRhnYkzTCpWT8/3tkM8+cxP VnriSTIWNI8mnfbub1po8OmQJ3A1oIEYItiONFxhHXUmRxNwPkNwWpT3KdX6vk63 xmA1rUvuBfmVFlBQ3Oa2WJWUhknSxfcHA+g5/MDqKzoA5gv7h//O1lIAEwmgLXkb EHXPzI5KJmA/MyuMaILpCmJP6dI2OoWHv9fn+b+piG0Jlc+VUOBAB/yyXK3hKjLp C0sIJ4LIdrCTDnCr9enl69IuVH+yoIicflGuXmB7lWn5VO8rTgRz/RVpzdWNvVdM YJp5gvWl6JM/fwFcPBGVZmQArGubWKEaQ3LO1YOadIcOBuogOpCipsOBaYUPQ/Yc 9yI54267qpe32hXoC5kiVVUSassMgvi70p142cl7csLbhNRbJ8A= =PRoO -----END PGP SIGNATURE----- --+4H1oyCNBJ2i7PTh-- From xen-devel-bounces@lists.xenproject.org Mon May 30 18:21:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 18:21:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338723.563529 (Exim 4.92) (envelope-from ) id 1nvk0V-00083T-Gl; Mon, 30 May 2022 18:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338723.563529; Mon, 30 May 2022 18:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvk0V-00083M-Dy; Mon, 30 May 2022 18:20:47 +0000 Received: by outflank-mailman (input) for mailman id 338723; Mon, 30 May 2022 18:20:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvk0T-00083G-V0 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 18:20:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37946ee6-e045-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 20:20:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A689A60A54; Mon, 30 May 2022 18:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A69F6C385B8; Mon, 30 May 2022 18:20:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37946ee6-e045-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653934842; bh=Hc3v6vdkkxDNH9P1ieO6s1ciu8KhYr8gtAxQLKPMimw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XT441zRAvC/1owmtuGoqO6WhidhsFdKIOSl/NUSDeR9Nnwo49A/AFx2yXKeqSGZaZ l+OHT58o+mv4nGNzIgfCXXPUDXpQi5nWCl8ORKVgG3Pml0Y9dPchWBVw4lFe5ERz7A WKuNyDgyjVQo8HknhY9xUZxW+T0MkpnntiW7EO4OO0+jA7Dx7Ey1YELb40My5wJUrI lxfAupAdGJJUk2Geqs+64zElJAnh9LDEnZrUZ6FAAZw5Dw40aoVVZIQG/GOCZgf0YG l0mBY/aArdY6hkH5JoG/jyFti9BV/c674o3qycEgOYv+/kyFhDzx8Y9m5RlpVbt7rf mDqnU/2szUyng== Date: Mon, 30 May 2022 11:20:40 -0700 From: Jakub Kicinski To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH] xen/netback: do some code cleanup Message-ID: <20220530112040.43871e04@kernel.org> In-Reply-To: <20220530114103.20657-1-jgross@suse.com> References: <20220530114103.20657-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 30 May 2022 13:41:03 +0200 Juergen Gross wrote: > Remove some unused macros and functions, make local functions static. > > Signed-off-by: Juergen Gross # Form letter - net-next is closed We have already sent the networking pull request for 5.19 and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after 5.19-rc1 is cut. RFC patches sent for review only are obviously welcome at any time. From xen-devel-bounces@lists.xenproject.org Mon May 30 18:23:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 18:23:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338733.563540 (Exim 4.92) (envelope-from ) id 1nvk2e-0000IX-13; Mon, 30 May 2022 18:23:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338733.563540; Mon, 30 May 2022 18:22:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvk2d-0000IQ-U5; Mon, 30 May 2022 18:22:59 +0000 Received: by outflank-mailman (input) for mailman id 338733; Mon, 30 May 2022 18:22:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvk2c-0000I7-VC for xen-devel@lists.xenproject.org; Mon, 30 May 2022 18:22:58 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 877c0f86-e045-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 20:22:57 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C746D5C021A; Mon, 30 May 2022 14:22:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 30 May 2022 14:22:56 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 May 2022 14:22:55 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 877c0f86-e045-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653934976; x= 1654021376; bh=RcsuwO01lQJrmDh0EjNMgSodvLUsnLiIQcvQyO4BxqQ=; b=X 069/dAtK4t9AEWRc7gnSs08lLzkfoQRDcHVwQUpv9gPetF3I4AfUguHtpibJneqI 9okksSJjm+HL8xep12KjBZ68zd6rf9W4Jwybmx+8OVYhmAGNZSnqlJss5S6Y9/BX S7A0PlrgBlkaO1uBGM7/7Oxyj1b/ODGH2PG/WEoolrPHoKDO1lr1xJwMRQS83Y33 0KLjN79FVPPQkCXo/0NS9GeoXPXPv7QlOXnfrmh0h2fetNLIU/UWZk++5OsO9Gva gSiXx6UKoQshIQOLcHC4DPOgo2ZaYfDl7rYVtN4WezI446Z6zZhgaDWTLXLpOCOv QHXwvdlUNLkHz24sqJ5oA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653934976; x=1654021376; bh=RcsuwO01lQJrmDh0EjNMgSodvLUs nLiIQcvQyO4BxqQ=; b=gL0LE4KRz2K9qUDZdmclAbBwM6pnPeW0oa8K0XzlOab8 5O2kxLqT8XeBlLNEqf/A7Stw2GrWAX5zkzKRntLNrDnzvSLf43QpV4nlgiMklHJO /zbvQkohzFOZVwbRQUCLePPzCoqC7QtMjNEE06u9kmmr1PPpBYzeFMu3rzpvTEBt FJCcAmz9iJT89lDzICd5bNui1J6gxMdwGTC+7b0s4k+VdUNyWbCeaCAmYLEJDkeN kBXaRYfJBg+jyOq3VNO4heb8p5GQPLan8AQe4kzg7tPXYAJNkafVcHdxHXnT1Kxy xHDVVPFJjEC8uy9HJRr3DDLXT9go226KW8Auvxrh3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeeigdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 30 May 2022 14:22:51 -0400 From: Demi Marie Obenour To: Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it Message-ID: References: <0644ecd8-51cc-897a-5555-62d4c9ee9461@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IH2qeyERgb6SrlYF" Content-Disposition: inline In-Reply-To: --IH2qeyERgb6SrlYF Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Date: Mon, 30 May 2022 14:22:51 -0400 From: Demi Marie Obenour To: Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/4] Grab the EFI System Resource Table and check it On Mon, May 30, 2022 at 08:47:39AM +0000, Henry Wang wrote: > Hi, > > It seems that this series is stale for more than one month with maintainers > comments given for [1][2] and some discussions between maintainer and author > for [3]. So this email is a gentle reminder for the author about this series (no hurries > and pressure though, please take your time :) ). Thanks! Thanks for the reminder. This series has been superseded by a later one. -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --IH2qeyERgb6SrlYF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmKVC30ACgkQsoi1X/+c IsEpwg//ScgI2a41bQ8CUhM+brn3ksykzrQg1Y2bg1ek/rK+5pHF70L+qBI8DtJo V7xsisTZB80qZtrhSi+GEev7iGkzwZD+Ec+8rXfWr66kTbWPxIjxnD/XfhFCIPYa k6DomxImfdNPaZIIJGSr6EUs/rRgnaub6CTPb7hy51BF3FH/HKkNZzx0HJg/LUWe D8BlmwAPZgYMtFlGIj8we8+GDne+FzewlKYwLQxTlNa8U9Q1XwnMoeLDRRi+mdqq eKY2gKCoUvVMW5jAYA+M1Pj0DQs+rrhQvGVG8cfT3WmsXC4puKOcFEUf/5NMAVgS swqMX2BGDLn4x2lOKxPVNOs8Ucd9Nb35FtlW91bevF8yJF2iLtyhCLKGB4YebCB5 5nLC+VnfhnWWmEyf/VpVEIp0Ck/aK849/qPelBkJ42DOcD0KKzxs2szJYcJpWW9R IvWDDmH7oWkh8zoOf+kwGr7mRznVb4r7vRIzhXNhzoS6qRRUsqU62Qy9rVCqG7jN P5v2r3C/UU0G7fcEhugM32TwM1KBwg1HTM2S4g7ZjL3msd66dRnCLG9rU80vLjI9 MkMAT2EhHeyAJ1Pj+25TuIsJ+Q+GPb+5vgui1lvkRLRNK2H5jCR5Ggmv0Ry9YSpU csnVP4S7b/MDk63uomDtg2NJhcmer9XWA1oITTl0fYGvASw6h5c= =1NBu -----END PGP SIGNATURE----- --IH2qeyERgb6SrlYF-- From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338743.563551 (Exim 4.92) (envelope-from ) id 1nvmV5-0007LJ-63; Mon, 30 May 2022 21:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338743.563551; Mon, 30 May 2022 21:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV5-0007LC-1X; Mon, 30 May 2022 21:00:31 +0000 Received: by outflank-mailman (input) for mailman id 338743; Mon, 30 May 2022 21:00:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV3-0007Kr-N1 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:29 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8777b38a-e05b-11ec-837f-e5687231ffcc; Mon, 30 May 2022 23:00:26 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id w23so1926061ljd.11 for ; Mon, 30 May 2022 14:00:26 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8777b38a-e05b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pCuUv8q5/WjIfzAOA2DFkkQ9mqGV4kxo4YoM+Cvu6ro=; b=WiaI+KKEgRCNknoz8Uc1/yoDLF8mhbBdpNIhtRrX887u68NsU80S5MLVYN1hnPW7zZ +dTPIJuhRW7AyOX8kfFAcbdIjaFgsZsqJ22tA0rz1M0PUx+hdfJdyQjjJfSltyOzkOVM j5bkZUBb1pNLRM354pRd0Cs37ddJYAKbD+rCM2zjsuLVdDR2NnwDNFemZidMtFwTQNg5 I/2xxvKDxNxedVbMMg6cxnxOekrmwTDufwAlIvt5yfn1jIWc5/qMkroYWwZbDiJjue+y Zyg8VcXHD80UYJ/GrcTN34bY37mtfnV7suFPacqHYXpexTrq9BbpeIi3hH+fnocrm7Lc 1FIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pCuUv8q5/WjIfzAOA2DFkkQ9mqGV4kxo4YoM+Cvu6ro=; b=FKHslnztLhypkDavtRrwfuszHZrMq1aSEO8AHk8auaZkNgCtCz/DR8qFLZ9j6uPCHk Bi4ya0c3eflZKqlgknHHuJoFJayxAq9EXO6XjleGaJIykNNADDmirxuM3PRXUNpBwPfu lhA8NuW7ifn9rGpEUklsj10nM9a7U6dhxP1KGjfAYRiBA1jEOt8cv6z2AgvUg9H8xbNa NH4I4pFTeVzJYgxFdBCpNW0uZ5sRlP41pOUG8uWebaWPTYE0apoPBLwQOlZlijlal4BY qnElxMpmfFeNltW6R4KAEf+TB/zpKv2867z1C5qtmZwxVIYuZRfoGI95lWRlHepsJcrU NvmQ== X-Gm-Message-State: AOAM533MREUG1i5LqIgcmU8iWJcsMSPpUfUOoimnw7PT1D89sHQRFzLN 4RljiQztVYWiIeCFoPRTWyEF5SjfAl8= X-Google-Smtp-Source: ABdhPJxtPivFiIEh6T2ItZTRi/yK5GNRp+BWkq0NWB8Leq1OGP2eIcmRspv46TKfr7DKK6pwtHPgug== X-Received: by 2002:a2e:bd13:0:b0:246:1ff8:6da1 with SMTP id n19-20020a2ebd13000000b002461ff86da1mr33708820ljq.219.1653944425323; Mon, 30 May 2022 14:00:25 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, x86@kernel.org Cc: Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , Bertrand Marquis , Wei Chen , Henry Wang , Kaly Xin , Jiamei Xie , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH V3 0/8] virtio: Solution to restrict memory access under Xen using xen-grant DMA-mapping layer Date: Tue, 31 May 2022 00:00:09 +0300 Message-Id: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add support for restricting memory access under Xen using specific grant table [1] based DMA-mapping layer. Patch series is based on Juergen Gross’ initial work [2] which implies using grant references instead of raw guest physical addresses (GPA) for the virtio communications (some kind of the software IOMMU). You can find RFC-V2 patch series (and previous discussions) at [3]. The high level idea is to create new Xen’s grant table based DMA-mapping layer for the guest Linux whose main purpose is to provide a special 64-bit DMA address which is formed by using the grant reference (for a page to be shared with the backend) with offset and setting the highest address bit (this is for the backend to be able to distinguish grant ref based DMA address from normal GPA). For this to work we need the ability to allocate contiguous (consecutive) grant references for multi-page allocations. And the backend then needs to offer VIRTIO_F_ACCESS_PLATFORM and VIRTIO_F_VERSION_1 feature bits (it must support virtio-mmio modern transport for 64-bit addresses in the virtqueue). Xen's grant mapping mechanism is the secure and safe solution to share pages between domains which proven to work and works for years (in the context of traditional Xen PV drivers for example). So far, the foreign mapping is used for the virtio backend to map and access guest memory. With the foreign mapping, the backend is able to map arbitrary pages from the guest memory (or even from Dom0 memory). And as the result, the malicious backend which runs in a non-trusted domain can take advantage of this. Instead, with the grant mapping the backend is only allowed to map pages which were explicitly granted by the guest before and nothing else. According to the discussions in various mainline threads this solution would likely be welcome because it perfectly fits in the security model Xen provides. What is more, the grant table based solution requires zero changes to the Xen hypervisor itself at least with virtio-mmio and DT (in comparison, for example, with "foreign mapping + virtio-iommu" solution which would require the whole new complex emulator in hypervisor in addition to new functionality/hypercall to pass IOVA from the virtio backend running elsewhere to the hypervisor and translate it to the GPA before mapping into P2M or denying the foreign mapping request if no corresponding IOVA-GPA mapping present in the IOMMU page table for that particular device). We only need to update toolstack to insert "xen,grant-dma" IOMMU node (to be referred by the virtio-mmio device using "iommus" property) when creating a guest device-tree (this is an indicator for the guest to use Xen grant mappings scheme for that device with the endpoint ID being used as ID of Xen domain where the corresponding backend is running, the backend domid is used as an argument to the grant mapping APIs). It worth mentioning that toolstack patch is based on non upstreamed yet “Virtio support for toolstack on Arm” series which is on review now [4]. Please note the following: - Patch series only covers Arm and virtio-mmio (device-tree) for now. To enable the restricted memory access feature on Arm the following option should be set: CONFIG_XEN_VIRTIO=y - Patch series is based on "kernel: add new infrastructure for platform_has() support" patch series which is on review now [5] - Xen should be built with the following options: CONFIG_IOREQ_SERVER=y CONFIG_EXPERT=y Patch series is rebased on Linux 5.18-rc7 tag with "kernel: add new infrastructure for platform_has() support" and "xen: simplify frontend side ring setup" series applied and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with standalone userspace (non-Qemu) virtio-mmio based virtio-disk backend running in Driver domain and Linux guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy' use-cases work properly. I have also tested other use-cases such as assigning several virtio block devices or a mix of virtio and Xen PV block devices to the guest. Patch series was build-tested on Arm32 and x86. 1. Xen changes located at (last patch): https://github.com/otyshchenko1/xen/commits/libxl_virtio_next2_1 2. Linux changes located at (last 8 patches): https://github.com/otyshchenko1/linux/commits/virtio_grant8_1 3. virtio-disk changes located at: https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant Any feedback/help would be highly appreciated. [1] https://xenbits.xenproject.org/docs/4.16-testing/misc/grant-tables.txt [2] https://www.youtube.com/watch?v=IrlEdaIUDPk [3] https://lore.kernel.org/xen-devel/1649963973-22879-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1650646263-22047-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1651947548-4055-1-git-send-email-olekstysh@gmail.com/ [4] https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ [5] https://lore.kernel.org/xen-devel/20220504155703.13336-1-jgross@suse.com/ Juergen Gross (3): xen/grants: support allocating consecutive grants xen/grant-dma-ops: Add option to restrict memory access under Xen xen/virtio: Enable restricted memory access using Xen grant mappings Oleksandr Tyshchenko (5): arm/xen: Introduce xen_setup_dma_ops() dt-bindings: Add xen,grant-dma IOMMU description for xen-grant DMA ops xen/grant-dma-iommu: Introduce stub IOMMU driver xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices .../devicetree/bindings/iommu/xen,grant-dma.yaml | 49 +++ arch/arm/include/asm/xen/xen-ops.h | 2 + arch/arm/mm/dma-mapping.c | 7 +- arch/arm/xen/enlighten.c | 2 + arch/arm64/include/asm/xen/xen-ops.h | 2 + arch/arm64/mm/dma-mapping.c | 7 +- arch/x86/xen/enlighten_hvm.c | 2 + arch/x86/xen/enlighten_pv.c | 2 + drivers/xen/Kconfig | 20 ++ drivers/xen/Makefile | 2 + drivers/xen/grant-dma-iommu.c | 78 +++++ drivers/xen/grant-dma-ops.c | 345 +++++++++++++++++++++ drivers/xen/grant-table.c | 251 ++++++++++++--- include/xen/arm/xen-ops.h | 18 ++ include/xen/grant_table.h | 4 + include/xen/xen-ops.h | 13 + include/xen/xen.h | 8 + 17 files changed, 766 insertions(+), 46 deletions(-) create mode 100644 Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml create mode 100644 arch/arm/include/asm/xen/xen-ops.h create mode 100644 arch/arm64/include/asm/xen/xen-ops.h create mode 100644 drivers/xen/grant-dma-iommu.c create mode 100644 drivers/xen/grant-dma-ops.c create mode 100644 include/xen/arm/xen-ops.h -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338749.563612 (Exim 4.92) (envelope-from ) id 1nvmV9-0000EA-JV; Mon, 30 May 2022 21:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338749.563612; Mon, 30 May 2022 21:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV9-0000CF-7Z; Mon, 30 May 2022 21:00:35 +0000 Received: by outflank-mailman (input) for mailman id 338749; Mon, 30 May 2022 21:00:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV7-0007Ks-M4 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:33 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b846cca-e05b-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 23:00:33 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id l30so13361185lfj.3 for ; Mon, 30 May 2022 14:00:32 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b846cca-e05b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mQkUP6MgBXfhQ5VQQiDmITT3o08NX2ApOUY4yVu0jYM=; b=WLuL7ZtX5S8Xv18ibuMJgTR4erb8ZpBPwNgQjlFbayW2zb7WwwtgSMG27xiOGDSuJU t3lH3KrC8K70XpuiQssk+JCUs7nV1C8qMvmu8GlbQCB3xSYoXmR1M9Nc9ufsXuvW3mt8 DcY1/w/Hb6/YJG9Pju/b6NXDE8mDx7CA1G34ytNlbfUOCgdrkPf5e4eXIlWwv3Xot55x DKst6rZ2pt6JGpbxpAvA0SSPeOxYJ+q8Sa5fJiNmTLPUU6dn+b6+knXi3gy13ShQJKIl L9fiy2/l6/vfejfMGqzPvpcOzOJB79MdCDHNA8coqTK66MvgzAEG1v1LjKcoQX2Km6to 8aHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mQkUP6MgBXfhQ5VQQiDmITT3o08NX2ApOUY4yVu0jYM=; b=iTw7NXBu8pGUQGFvX+o95WPSl9DTjFF2yUeIgL2o+yQ4nuAh7ln8Rg34BRGUT0ew5x e8AJEcPz/z+tMfNuraAd+FMgX0aa4CqMt7xqbHnFOokH0FE+rtKEj4FQsbBUIL8+1Lij CnwmvB7DYVxdnhHk3cWGs0k0cnpxjowRmci/pFQ0VaNbIOMXh84AfSiEIEBjOC9GX/4O qsLixNl7B6KeTvWKrGnOiPoyqR+LnRAk3aWTjxahL2vaGzpeG7wH+dgzs7NmzJuGUZrN TGQylhiESLcGwK6xqXb4rD5bpE9AjYicGCwg8/HQhmVqiuShNmisNsSVpRsi/eQ+hNhh iI1w== X-Gm-Message-State: AOAM530P66On3/IjWTWJk+q8oPiyNdCtE/UvHg4BwwxngJperKkLcxKT QI9KcXdUn2WqXlvBgHIKeMwof0Hbd1Y= X-Google-Smtp-Source: ABdhPJyrEsxXy8rP0N5pXydrCG2JHswyhigBj0VPDBjmiPYCC6mscekUcRxdjLumVRMb+YbKh8/HBA== X-Received: by 2002:a05:6512:108a:b0:478:68e8:adce with SMTP id j10-20020a056512108a00b0047868e8adcemr31174023lfg.617.1653944432306; Mon, 30 May 2022 14:00:32 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 6/8] xen/grant-dma-iommu: Introduce stub IOMMU driver Date: Tue, 31 May 2022 00:00:15 +0300 Message-Id: <1653944417-17168-7-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko In order to reuse generic IOMMU device tree bindings by Xen grant DMA-mapping layer we need to add this stub driver from a fw_devlink perspective (grant-dma-ops cannot be converted into the proper IOMMU driver). Otherwise, just reusing IOMMU bindings (without having a corresponding driver) leads to the deferred probe timeout afterwards, because the IOMMU device never becomes available. This stub driver does nothing except registering empty iommu_ops, the upper layer "of_iommu" will treat this as NO_IOMMU condition and won't return -EPROBE_DEFER. As this driver is quite different from the most hardware IOMMU implementations and only needed in Xen guests, place it in drivers/xen directory. The subsequent commit will make use of it. Signed-off-by: Oleksandr Tyshchenko --- According to the discussion at: https://lore.kernel.org/xen-devel/c0f78aab-e723-fe00-a310-9fe52ec75e48@gmail.com/ Change V2 -> V3: - new patch --- drivers/xen/Kconfig | 4 +++ drivers/xen/Makefile | 1 + drivers/xen/grant-dma-iommu.c | 78 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 83 insertions(+) create mode 100644 drivers/xen/grant-dma-iommu.c diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index a7bd8ce..35d20d9 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -335,6 +335,10 @@ config XEN_UNPOPULATED_ALLOC having to balloon out RAM regions in order to obtain physical memory space to create such mappings. +config XEN_GRANT_DMA_IOMMU + bool + select IOMMU_API + config XEN_GRANT_DMA_OPS bool select DMA_OPS diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 1a23cb0..c0503f1 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -40,3 +40,4 @@ xen-privcmd-y := privcmd.o privcmd-buf.o obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF) += xen-front-pgdir-shbuf.o obj-$(CONFIG_XEN_UNPOPULATED_ALLOC) += unpopulated-alloc.o obj-$(CONFIG_XEN_GRANT_DMA_OPS) += grant-dma-ops.o +obj-$(CONFIG_XEN_GRANT_DMA_IOMMU) += grant-dma-iommu.o diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c new file mode 100644 index 00000000..16b8bc0 --- /dev/null +++ b/drivers/xen/grant-dma-iommu.c @@ -0,0 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Stub IOMMU driver which does nothing. + * The main purpose of it being present is to reuse generic IOMMU device tree + * bindings by Xen grant DMA-mapping layer. + * + * Copyright (C) 2022 EPAM Systems Inc. + */ + +#include +#include +#include + +struct grant_dma_iommu_device { + struct device *dev; + struct iommu_device iommu; +}; + +/* Nothing is really needed here */ +static const struct iommu_ops grant_dma_iommu_ops; + +static const struct of_device_id grant_dma_iommu_of_match[] = { + { .compatible = "xen,grant-dma" }, + { }, +}; + +static int grant_dma_iommu_probe(struct platform_device *pdev) +{ + struct grant_dma_iommu_device *mmu; + int ret; + + mmu = devm_kzalloc(&pdev->dev, sizeof(*mmu), GFP_KERNEL); + if (!mmu) + return -ENOMEM; + + mmu->dev = &pdev->dev; + + ret = iommu_device_register(&mmu->iommu, &grant_dma_iommu_ops, &pdev->dev); + if (ret) + return ret; + + platform_set_drvdata(pdev, mmu); + + return 0; +} + +static int grant_dma_iommu_remove(struct platform_device *pdev) +{ + struct grant_dma_iommu_device *mmu = platform_get_drvdata(pdev); + + platform_set_drvdata(pdev, NULL); + iommu_device_unregister(&mmu->iommu); + + return 0; +} + +static struct platform_driver grant_dma_iommu_driver = { + .driver = { + .name = "grant-dma-iommu", + .of_match_table = grant_dma_iommu_of_match, + }, + .probe = grant_dma_iommu_probe, + .remove = grant_dma_iommu_remove, +}; + +static int __init grant_dma_iommu_init(void) +{ + struct device_node *iommu_np; + + iommu_np = of_find_matching_node(NULL, grant_dma_iommu_of_match); + if (!iommu_np) + return 0; + + of_node_put(iommu_np); + + return platform_driver_register(&grant_dma_iommu_driver); +} +subsys_initcall(grant_dma_iommu_init); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338750.563624 (Exim 4.92) (envelope-from ) id 1nvmVB-0000cx-37; Mon, 30 May 2022 21:00:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338750.563624; Mon, 30 May 2022 21:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmVA-0000c0-Qn; Mon, 30 May 2022 21:00:36 +0000 Received: by outflank-mailman (input) for mailman id 338750; Mon, 30 May 2022 21:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV8-0007Ks-Sa for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:35 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c2e20ae-e05b-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 23:00:34 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id q1so12744266ljb.5 for ; Mon, 30 May 2022 14:00:34 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c2e20ae-e05b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uQ1JH7AWAJHsRRYFQY27acyYSyJWPZ/cZSwuKE03m9M=; b=F3Dp/1RfYd/CNOWtpufTjQ5KG1C/SjG2GTXBdmAnmkIZmIISp6swxVs8EtEn+CBphf bJoFFuN+PnP5FTSwKK7r/G8qOeglHY3GL5o10B5kKyNI3lbYT2QRFbJMxi4Am+JQI3ZN ehlzziC+FS40xWH5CO/plPfSgnEkPRbzN/ZpEuxVsyac3aY0NmGhhav6DE7ZZk3YYLiZ NIBnVA7VpoQLIsLbKcRgByxkCjJh6t4jRaz3uUTAJF0JG+Zo5N5/KlXzqzM6ILBj7ile v0bUG3G8bfZR3IgtGMst1ql3DwP8EUrB62vK7C0on5gaI+gMR/yHkjGBuGFC74oT++mK ISEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uQ1JH7AWAJHsRRYFQY27acyYSyJWPZ/cZSwuKE03m9M=; b=NIcxBWdKKSECCFXSQTFd4gjYbWy+sMfBVSdTw/tzcrjWHqMf4BJPwdM2GW5hF+c3nl ffr7tse8JcNGebrxKF0ikt83oYe0IcOIdgHE4GrqkJvvlHeJOeAL8KFGvWsSteFMLPsp GLy81hW3ZRavb1vghqtdznneVwqIQRBaeBz6V9kto/zTnWRg5OMIKc1xhz3Oais2yqTi b4tZ2jbOZ7ZhKzs9cdVi5Mjac0RaG7LKx5t0E88ZOU0xXlfbDs7epaXcHPuY1KDgW8KS uFFpuTzOjD+/r6TOjg6Qj0R5q2FuJBzpKvhLZb28ClG/ZugGQ+0imyo01GtCSA08kOkI NxAg== X-Gm-Message-State: AOAM5325QvQmbUvE6mLvt+NgFOPWhlkM12621ih+NuxDTy0Ad0ht1ds9 Pj8SO/n0cjU2/J1am4zcqOiANTKrR0U= X-Google-Smtp-Source: ABdhPJwO1sx6nXB3yQvX6BxgfoZrQPM9WyfnZcUaKJhUw7Qhdh1gVI5p09PHodbZD/CPwbZDBCk3cg== X-Received: by 2002:a2e:b88d:0:b0:253:ee2a:6b70 with SMTP id r13-20020a2eb88d000000b00253ee2a6b70mr22917522ljp.247.1653944433394; Mon, 30 May 2022 14:00:33 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 7/8] xen/grant-dma-ops: Retrieve the ID of backend's domain for DT devices Date: Tue, 31 May 2022 00:00:16 +0300 Message-Id: <1653944417-17168-8-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko Use the presence of "iommus" property pointed to the IOMMU node with recently introduced "xen,grant-dma" compatible as a clear indicator of enabling Xen grant mappings scheme for that device and read the ID of Xen domain where the corresponding backend is running. The domid (domain ID) is used as an argument to the Xen grant mapping APIs. To avoid the deferred probe timeout which takes place after reusing generic IOMMU device tree bindings (because the IOMMU device never becomes available) enable recently introduced stub IOMMU driver by selecting XEN_GRANT_DMA_IOMMU. Also introduce xen_is_grant_dma_device() to check whether xen-grant DMA ops need to be set for a passed device. Remove the hardcoded domid 0 in xen_grant_setup_dma_ops(). Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - new patch, split required changes from commit: "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" - update checks in xen_virtio_setup_dma_ops() to only support DT devices for now - remove the "virtio,mmio" check from xen_is_virtio_device() - remane everything according to the new naming scheme: s/virtio/grant_dma Changes V1 -> V2: - remove dev_is_pci() check in xen_grant_setup_dma_ops() - remove EXPORT_SYMBOL_GPL(xen_is_grant_dma_device); Changes V2 -> V3: - Stefano already gave his Reviewed-by, I dropped it due to the changes (significant) - update commit description - reuse generic IOMMU device tree bindings, select XEN_GRANT_DMA_IOMMU to avoid the deferred probe timeout --- drivers/xen/Kconfig | 1 + drivers/xen/grant-dma-ops.c | 48 ++++++++++++++++++++++++++++++++++++++------- include/xen/xen-ops.h | 5 +++++ 3 files changed, 47 insertions(+), 7 deletions(-) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 35d20d9..bfd5f4f 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -347,6 +347,7 @@ config XEN_VIRTIO bool "Xen virtio support" depends on VIRTIO select XEN_GRANT_DMA_OPS + select XEN_GRANT_DMA_IOMMU if OF help Enable virtio support for running as Xen guest. Depending on the guest type this will require special support on the backend side diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c index 44659f4..6586152 100644 --- a/drivers/xen/grant-dma-ops.c +++ b/drivers/xen/grant-dma-ops.c @@ -55,11 +55,6 @@ static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) * Such a DMA address is formed by using the grant reference as a frame * number and setting the highest address bit (this bit is for the backend * to be able to distinguish it from e.g. a mmio address). - * - * Note that for now we hard wire dom0 to be the backend domain. In order - * to support any domain as backend we'd need to add a way to communicate - * the domid of this backend, e.g. via Xenstore, via the PCI-device's - * config space or DT/ACPI. */ static void *xen_grant_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp, @@ -275,9 +270,26 @@ static const struct dma_map_ops xen_grant_dma_ops = { .dma_supported = xen_grant_dma_supported, }; +bool xen_is_grant_dma_device(struct device *dev) +{ + struct device_node *iommu_np; + bool has_iommu; + + /* XXX Handle only DT devices for now */ + if (!dev->of_node) + return false; + + iommu_np = of_parse_phandle(dev->of_node, "iommus", 0); + has_iommu = iommu_np && of_device_is_compatible(iommu_np, "xen,grant-dma"); + of_node_put(iommu_np); + + return has_iommu; +} + void xen_grant_setup_dma_ops(struct device *dev) { struct xen_grant_dma_data *data; + struct of_phandle_args iommu_spec; data = find_xen_grant_dma_data(dev); if (data) { @@ -285,12 +297,34 @@ void xen_grant_setup_dma_ops(struct device *dev) return; } + /* XXX ACPI device unsupported for now */ + if (!dev->of_node) + goto err; + + if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells", + 0, &iommu_spec)) { + dev_err(dev, "Cannot parse iommus property\n"); + goto err; + } + + if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") || + iommu_spec.args_count != 1) { + dev_err(dev, "Incompatible IOMMU node\n"); + of_node_put(iommu_spec.np); + goto err; + } + + of_node_put(iommu_spec.np); + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data) goto err; - /* XXX The dom0 is hardcoded as the backend domain for now */ - data->backend_domid = 0; + /* + * The endpoint ID here means the ID of the domain where the corresponding + * backend is running + */ + data->backend_domid = iommu_spec.args[0]; if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, GFP_KERNEL))) { diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index 4f9fad5..62be9dc 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -223,10 +223,15 @@ static inline void xen_preemptible_hcall_end(void) { } #ifdef CONFIG_XEN_GRANT_DMA_OPS void xen_grant_setup_dma_ops(struct device *dev); +bool xen_is_grant_dma_device(struct device *dev); #else static inline void xen_grant_setup_dma_ops(struct device *dev) { } +static inline bool xen_is_grant_dma_device(struct device *dev) +{ + return false; +} #endif /* CONFIG_XEN_GRANT_DMA_OPS */ #endif /* INCLUDE_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338744.563557 (Exim 4.92) (envelope-from ) id 1nvmV5-0007On-Hl; Mon, 30 May 2022 21:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338744.563557; Mon, 30 May 2022 21:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV5-0007Nl-BN; Mon, 30 May 2022 21:00:31 +0000 Received: by outflank-mailman (input) for mailman id 338744; Mon, 30 May 2022 21:00:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV4-0007Kr-9R for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:30 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88138123-e05b-11ec-837f-e5687231ffcc; Mon, 30 May 2022 23:00:27 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id s6so2496158lfo.13 for ; Mon, 30 May 2022 14:00:27 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88138123-e05b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bgYTJywCKcz2eZ3BdKiVmZnlK+gFcRjkQ0C/gcc8wL0=; b=WPbadUUFeZwVP4k9WAfhTLe83VpVBG119TgUz++U+jcFCuUBznYGsIC2lzKm27XdmH yXFP5yObX14uURGpzK7F5mfOnsgB0r/BmzpoUM+jVBTGg80yZgw9XLdeLfgwp9ErLoVW Q1TnTWrqcB0sDwHHSjrR/52HWB1qz43VoDo1QHHh9ceNvr40y+w6erOOroKP7WNK9jCV dGTfhe/dXDLi/T7GIkeydYCCaMf+TjgeRFjPvJnOV+kHivKBp/t3pH1T36Vqg8+3uxjR MnAy+xzObuU1AJa9GbSqXq88uHtnxJw/NER+9Xb7clISz49J9BSIQt8o8DWDArCwlTH1 WvpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bgYTJywCKcz2eZ3BdKiVmZnlK+gFcRjkQ0C/gcc8wL0=; b=7j/UclqJnDDuf4KbhQl9Rruk+2ZtuG8QzLH3gK/+/4kgDJBi3rLTR/SxzTXiqq/lvm RrrWpbzoYndQ1uyPDPnsBDOWFqXEJEWPHYatQLjou1npHVJSc7D3RVkrv4qt7i8DpsPH SMEXCBcs00Jn8psviLyGy42fcvSxlOueLpQ6Lu9uIHti+VCgz5sDAiYJLSpr+r7JKbyO eqSudO1e2EpSaCyNkFe4M6ExLTQme9bO79iqddDqh2imZLq7WD337aY+1w65I8avVnnj HxrCZgaG0CHdNkxv7wX2+4jfi5T9TSwtyiEJZMYLeo5TOsoAeGpDCiHDjjwqphYN/LBt iiQQ== X-Gm-Message-State: AOAM531hPzpVW6x+Qd4vyFSUcZLT1FKCbI8wGzNelNRywsQMRsLi7xhN nXbxzacAb49gJfjH/UU0LDaL5yea7k4= X-Google-Smtp-Source: ABdhPJxg9WbJjJF17bN45E1W6bO0HJs4dzI7IisXFVPM5nHpQcExbUbGQhg/zR9oTx50h6uUKqfR1w== X-Received: by 2002:a05:6512:20c9:b0:477:cc4f:b816 with SMTP id u9-20020a05651220c900b00477cc4fb816mr38993759lfr.521.1653944426468; Mon, 30 May 2022 14:00:26 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Catalin Marinas , Will Deacon , Boris Ostrovsky , Juergen Gross , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 1/8] arm/xen: Introduce xen_setup_dma_ops() Date: Tue, 31 May 2022 00:00:10 +0300 Message-Id: <1653944417-17168-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko This patch introduces new helper and places it in new header. The helper's purpose is to assign any Xen specific DMA ops in a single place. For now, we deal with xen-swiotlb DMA ops only. The one of the subsequent commits in current series will add xen-grant DMA ops case. Also re-use the xen_swiotlb_detect() check on Arm32. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini [For arm64] Acked-by: Catalin Marinas --- Changes RFC -> V1: - update commit description - move commit to the beginning of the series - move #ifdef CONFIG_XEN from dma-mapping.c to xen-ops.h Changes V1 -> V2: - add Stefano's R-b - add missing SPDX-License-Identifier to xen-ops.h Changes V2 -> V3: - add Catalin's A-b --- arch/arm/include/asm/xen/xen-ops.h | 2 ++ arch/arm/mm/dma-mapping.c | 7 ++----- arch/arm64/include/asm/xen/xen-ops.h | 2 ++ arch/arm64/mm/dma-mapping.c | 7 ++----- include/xen/arm/xen-ops.h | 15 +++++++++++++++ 5 files changed, 23 insertions(+), 10 deletions(-) create mode 100644 arch/arm/include/asm/xen/xen-ops.h create mode 100644 arch/arm64/include/asm/xen/xen-ops.h create mode 100644 include/xen/arm/xen-ops.h diff --git a/arch/arm/include/asm/xen/xen-ops.h b/arch/arm/include/asm/xen/xen-ops.h new file mode 100644 index 00000000..7ebb7eb --- /dev/null +++ b/arch/arm/include/asm/xen/xen-ops.h @@ -0,0 +1,2 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 82ffac6..059cce0 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include "dma.h" #include "mm.h" @@ -2287,10 +2287,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, set_dma_ops(dev, dma_ops); -#ifdef CONFIG_XEN - if (xen_initial_domain()) - dev->dma_ops = &xen_swiotlb_dma_ops; -#endif + xen_setup_dma_ops(dev); dev->archdata.dma_ops_setup = true; } diff --git a/arch/arm64/include/asm/xen/xen-ops.h b/arch/arm64/include/asm/xen/xen-ops.h new file mode 100644 index 00000000..7ebb7eb --- /dev/null +++ b/arch/arm64/include/asm/xen/xen-ops.h @@ -0,0 +1,2 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 6719f9e..6099c81 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -9,9 +9,9 @@ #include #include #include -#include #include +#include void arch_sync_dma_for_device(phys_addr_t paddr, size_t size, enum dma_data_direction dir) @@ -52,8 +52,5 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, if (iommu) iommu_setup_dma_ops(dev, dma_base, dma_base + size - 1); -#ifdef CONFIG_XEN - if (xen_swiotlb_detect()) - dev->dma_ops = &xen_swiotlb_dma_ops; -#endif + xen_setup_dma_ops(dev); } diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h new file mode 100644 index 00000000..288deb1 --- /dev/null +++ b/include/xen/arm/xen-ops.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_ARM_XEN_OPS_H +#define _ASM_ARM_XEN_OPS_H + +#include + +static inline void xen_setup_dma_ops(struct device *dev) +{ +#ifdef CONFIG_XEN + if (xen_swiotlb_detect()) + dev->dma_ops = &xen_swiotlb_dma_ops; +#endif +} + +#endif /* _ASM_ARM_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338747.563578 (Exim 4.92) (envelope-from ) id 1nvmV6-0007pY-SX; Mon, 30 May 2022 21:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338747.563578; Mon, 30 May 2022 21:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV6-0007kO-Ir; Mon, 30 May 2022 21:00:32 +0000 Received: by outflank-mailman (input) for mailman id 338747; Mon, 30 May 2022 21:00:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV5-0007Kr-Bt for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:31 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a11f7ee-e05b-11ec-837f-e5687231ffcc; Mon, 30 May 2022 23:00:30 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id y32so18499569lfa.6 for ; Mon, 30 May 2022 14:00:30 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a11f7ee-e05b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lW0Pzr6bA3fYtV1xJl8AeDQlMEnR60yW2//eH29vCxE=; b=dYVzMiNPLwEXkptKECpn5hcp6De3x3lUTo4ciWbKYGPqQkIveiVsSkLh+lm9XNk8OO yAr8NmkDNELrM/63UlINwvrxPLx+QCa8OxL10AORjrhke2k4eDiY7gC3JYaMgp0wo+sO /AFN96MvSkkvfDQ0gZ1vrbdJqZ0qSnbL9PmHpuugdoiwPHT+0SUItW/CwiKf2KGqM069 /DcWc96cbRY1d7tl+GgQ9Dn/NQuhq6hzc0idRTFkuI2ktSQUrk/qbsY6FglCgvJw1aY6 PhLVWMRL9Be3A/jl8PKTry4t7RUU8EE1LoMZWkD1cvciSdy6l4nUZyucDoho0BczJ802 0Vww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lW0Pzr6bA3fYtV1xJl8AeDQlMEnR60yW2//eH29vCxE=; b=yA0cqf8Zg4eeRjJK8ZVORnDBF0dm1sn2rE/TdfCj6J/N4oRL6IVfpCDuTfctp0N0wx reFiC0GNqrBcJ7xepTcBVjU0VbM7TsRxiNqrO2NXMsl9SzsYrAc5mdVFvdzCIhIm5OY3 jj6roKTnP0NsO3rFA+ssaEe5U1zZE2HWYNeYpjr7pCffXZos55PrjW8FaKLdHLrj8Hxt CBoFN1sRCvDfphrK5hBiUvEiX/zt1UWNyiaO7rejU3pBInCJAjsLyzIL+CUtksd2hxWJ PbXexjhR19qX8B5Jn8x2bxmHA5bEGkrh4y5G9xE0mgRHcOSh1BiZAQKLJ0oadn3cVqjb 25mQ== X-Gm-Message-State: AOAM5301dzKbn8bE4EO0rfnNKeMntJkGyFAGaOmIGAgdPETAm+UdcQqw 2t2JSFSF8mf0o6c67gLDPq8he00TA9A= X-Google-Smtp-Source: ABdhPJxBfcqMRHWX1lLOCfyubtXqqMjUSE+CHfX2MUUOYQPe/E98Wa9P4vwWYUQD0/M3EcTqNr0EBQ== X-Received: by 2002:a05:6512:2520:b0:478:7f50:b011 with SMTP id be32-20020a056512252000b004787f50b011mr27488605lfb.72.1653944429968; Mon, 30 May 2022 14:00:29 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Oleksandr Tyshchenko , Stefano Stabellini , Russell King , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 4/8] xen/virtio: Enable restricted memory access using Xen grant mappings Date: Tue, 31 May 2022 00:00:13 +0300 Message-Id: <1653944417-17168-5-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Juergen Gross In order to support virtio in Xen guests add a config option XEN_VIRTIO enabling the user to specify whether in all Xen guests virtio should be able to access memory via Xen grant mappings only on the host side. Also set PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS feature from the guest initialization code on Arm and x86 if CONFIG_XEN_VIRTIO is enabled. Signed-off-by: Juergen Gross Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini --- Changes V1 -> V2: - new patch, split required changes from commit: "[PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen" - rework according to new platform_has() infrastructure Changes V2 -> V3: - add Stefano's R-b --- arch/arm/xen/enlighten.c | 2 ++ arch/x86/xen/enlighten_hvm.c | 2 ++ arch/x86/xen/enlighten_pv.c | 2 ++ drivers/xen/Kconfig | 11 +++++++++++ include/xen/xen.h | 8 ++++++++ 5 files changed, 25 insertions(+) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 07eb69f..1f9c3ba 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -443,6 +443,8 @@ static int __init xen_guest_init(void) if (!xen_domain()) return 0; + xen_set_restricted_virtio_memory_access(); + if (!acpi_disabled) xen_acpi_guest_init(); else diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 517a9d8..8b71b1d 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -195,6 +195,8 @@ static void __init xen_hvm_guest_init(void) if (xen_pv_domain()) return; + xen_set_restricted_virtio_memory_access(); + init_hvm_pv_info(); reserve_shared_info(); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index ca85d14..30d24fe 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -108,6 +108,8 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc); static void __init xen_pv_init_platform(void) { + xen_set_restricted_virtio_memory_access(); + populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP)); set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info); diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 313a9127..a7bd8ce 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -339,4 +339,15 @@ config XEN_GRANT_DMA_OPS bool select DMA_OPS +config XEN_VIRTIO + bool "Xen virtio support" + depends on VIRTIO + select XEN_GRANT_DMA_OPS + help + Enable virtio support for running as Xen guest. Depending on the + guest type this will require special support on the backend side + (qemu or kernel, depending on the virtio device types used). + + If in doubt, say n. + endmenu diff --git a/include/xen/xen.h b/include/xen/xen.h index a99bab8..0780a81 100644 --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -52,6 +52,14 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, extern u64 xen_saved_max_mem_size; #endif +#include + +static inline void xen_set_restricted_virtio_memory_access(void) +{ + if (IS_ENABLED(CONFIG_XEN_VIRTIO) && xen_domain()) + platform_set(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); +} + #ifdef CONFIG_XEN_UNPOPULATED_ALLOC int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages); void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338745.563563 (Exim 4.92) (envelope-from ) id 1nvmV6-0007VZ-0H; Mon, 30 May 2022 21:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338745.563563; Mon, 30 May 2022 21:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV5-0007TR-M2; Mon, 30 May 2022 21:00:31 +0000 Received: by outflank-mailman (input) for mailman id 338745; Mon, 30 May 2022 21:00:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV4-0007Ks-9b for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:30 +0000 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [2a00:1450:4864:20::22b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88c75d84-e05b-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 23:00:28 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id k20so4127079ljc.1 for ; Mon, 30 May 2022 14:00:28 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88c75d84-e05b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3gzHOM+c5HMloZ7sIBCpupu74wnaQ0zWHpxDMyFFqtQ=; b=mGcUtPiCk4PHtAzNluJb0vuddgduTuyyBtyazANXcy5nD1Xf/KtR0S9gIx13RnyRds 8u3rO5oCXpCHS2mZHww++hLTinm0nlnfMeiYj9kthO3SthrbB6DbrlrStbvwNSsfHEGc wiHH2K4htOWLf1r5a4hre0y3UKmZdHF8K/c7gXAcXUD3rs+GntblOimOOCeOWM6mZlDQ huEslXMfOOdMOB+tThTkdTLjzZgql2u33u46YX03yaCDbnad6zTWS4UeCmckfztLnbor BEJwJe277/EujUTG6ud3+fVt64QbT0GJeL0322CCZeAMk5nIuSga2OUr9HENmiul55pB k7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3gzHOM+c5HMloZ7sIBCpupu74wnaQ0zWHpxDMyFFqtQ=; b=eW0FqDNRjNHzT6/0u2jFoqikJihMbnLRCH2GKCoGnGNNu3wI/nXLXGUCwkPj7rygTE 2xffO/KrwS6el6aHSfAq4SGJtzBzm8UxRlUwiriLYjX152KJ1pAB4ZaJDYqt9Lurehdb Nm/6nYH8+Nzp2mw09ag1mFVbnRPH+SFS2fEgSG56WlI8YXRg+NLhoBIzHRW8Yze2II8g Ifj41Gnd7XVAUb8/bJ3CBrjJVfCPy1FWLG8u+VJvoXr9pAKwC9d269NwW5DL3+LraaKt V6SR06Kq6PrZHPoCDj1FtTY/YREdZGMCZN20zIvHWY9GLVxTne1cOIpifcvy7ZffPUBp xdPg== X-Gm-Message-State: AOAM530qmZuWb9raGIrPXISC3enrDbhqW2ZeKhAKIf2nCWovJqDCflC3 nBZgQisipkfBN3M0545ghuWGl3dCcxw= X-Google-Smtp-Source: ABdhPJzpTG1IHR4PsqQEdQZUx9c91vwjmyp9o0CwooQn1XnsvHQd3A/2FTgg8PV1Fj5m7CxUzdqCUQ== X-Received: by 2002:a2e:7c15:0:b0:253:e242:1897 with SMTP id x21-20020a2e7c15000000b00253e2421897mr27412017ljc.72.1653944427560; Mon, 30 May 2022 14:00:27 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 2/8] xen/grants: support allocating consecutive grants Date: Tue, 31 May 2022 00:00:11 +0300 Message-Id: <1653944417-17168-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Juergen Gross For support of virtio via grant mappings in rare cases larger mappings using consecutive grants are needed. Support those by adding a bitmap of free grants. As consecutive grants will be needed only in very rare cases (e.g. when configuring a virtio device with a multi-page ring), optimize for the normal case of non-consecutive allocations. Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- Changes RFC -> V1: - no changes Changes V1 -> V2: - no changes Changes V2 -> V3: - rebase, move "if (unlikely(ref < GNTTAB_NR_RESERVED_ENTRIES))" to put_free_entry_locked() - do not overwrite "i" in gnttab_init(), introduce local max_nr_grefs - add a comment on top of "while (from < to)" in get_free_seq() - add Boris' R-b --- drivers/xen/grant-table.c | 251 +++++++++++++++++++++++++++++++++++++++------- include/xen/grant_table.h | 4 + 2 files changed, 219 insertions(+), 36 deletions(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 1a1aec0..947d82f 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -33,6 +33,7 @@ #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt +#include #include #include #include @@ -70,9 +71,32 @@ static grant_ref_t **gnttab_list; static unsigned int nr_grant_frames; + +/* + * Handling of free grants: + * + * Free grants are in a simple list anchored in gnttab_free_head. They are + * linked by grant ref, the last element contains GNTTAB_LIST_END. The number + * of free entries is stored in gnttab_free_count. + * Additionally there is a bitmap of free entries anchored in + * gnttab_free_bitmap. This is being used for simplifying allocation of + * multiple consecutive grants, which is needed e.g. for support of virtio. + * gnttab_last_free is used to add free entries of new frames at the end of + * the free list. + * gnttab_free_tail_ptr specifies the variable which references the start + * of consecutive free grants ending with gnttab_last_free. This pointer is + * updated in a rather defensive way, in order to avoid performance hits in + * hot paths. + * All those variables are protected by gnttab_list_lock. + */ static int gnttab_free_count; -static grant_ref_t gnttab_free_head; +static unsigned int gnttab_size; +static grant_ref_t gnttab_free_head = GNTTAB_LIST_END; +static grant_ref_t gnttab_last_free = GNTTAB_LIST_END; +static grant_ref_t *gnttab_free_tail_ptr; +static unsigned long *gnttab_free_bitmap; static DEFINE_SPINLOCK(gnttab_list_lock); + struct grant_frames xen_auto_xlat_grant_frames; static unsigned int xen_gnttab_version; module_param_named(version, xen_gnttab_version, uint, 0); @@ -168,16 +192,116 @@ static int get_free_entries(unsigned count) ref = head = gnttab_free_head; gnttab_free_count -= count; - while (count-- > 1) - head = gnttab_entry(head); + while (count--) { + bitmap_clear(gnttab_free_bitmap, head, 1); + if (gnttab_free_tail_ptr == __gnttab_entry(head)) + gnttab_free_tail_ptr = &gnttab_free_head; + if (count) + head = gnttab_entry(head); + } gnttab_free_head = gnttab_entry(head); gnttab_entry(head) = GNTTAB_LIST_END; + if (!gnttab_free_count) { + gnttab_last_free = GNTTAB_LIST_END; + gnttab_free_tail_ptr = NULL; + } + spin_unlock_irqrestore(&gnttab_list_lock, flags); return ref; } +static int get_seq_entry_count(void) +{ + if (gnttab_last_free == GNTTAB_LIST_END || !gnttab_free_tail_ptr || + *gnttab_free_tail_ptr == GNTTAB_LIST_END) + return 0; + + return gnttab_last_free - *gnttab_free_tail_ptr + 1; +} + +/* Rebuilds the free grant list and tries to find count consecutive entries. */ +static int get_free_seq(unsigned int count) +{ + int ret = -ENOSPC; + unsigned int from, to; + grant_ref_t *last; + + gnttab_free_tail_ptr = &gnttab_free_head; + last = &gnttab_free_head; + + for (from = find_first_bit(gnttab_free_bitmap, gnttab_size); + from < gnttab_size; + from = find_next_bit(gnttab_free_bitmap, gnttab_size, to + 1)) { + to = find_next_zero_bit(gnttab_free_bitmap, gnttab_size, + from + 1); + if (ret < 0 && to - from >= count) { + ret = from; + bitmap_clear(gnttab_free_bitmap, ret, count); + from += count; + gnttab_free_count -= count; + if (from == to) + continue; + } + + /* + * Recreate the free list in order to have it properly sorted. + * This is needed to make sure that the free tail has the maximum + * possible size. + */ + while (from < to) { + *last = from; + last = __gnttab_entry(from); + gnttab_last_free = from; + from++; + } + if (to < gnttab_size) + gnttab_free_tail_ptr = __gnttab_entry(to - 1); + } + + *last = GNTTAB_LIST_END; + if (gnttab_last_free != gnttab_size - 1) + gnttab_free_tail_ptr = NULL; + + return ret; +} + +static int get_free_entries_seq(unsigned int count) +{ + unsigned long flags; + int ret = 0; + + spin_lock_irqsave(&gnttab_list_lock, flags); + + if (gnttab_free_count < count) { + ret = gnttab_expand(count - gnttab_free_count); + if (ret < 0) + goto out; + } + + if (get_seq_entry_count() < count) { + ret = get_free_seq(count); + if (ret >= 0) + goto out; + ret = gnttab_expand(count - get_seq_entry_count()); + if (ret < 0) + goto out; + } + + ret = *gnttab_free_tail_ptr; + *gnttab_free_tail_ptr = gnttab_entry(ret + count - 1); + gnttab_free_count -= count; + if (!gnttab_free_count) + gnttab_free_tail_ptr = NULL; + bitmap_clear(gnttab_free_bitmap, ret, count); + + out: + spin_unlock_irqrestore(&gnttab_list_lock, flags); + + return ret; +} + static void do_free_callbacks(void) { struct gnttab_free_callback *callback, *next; @@ -204,21 +328,51 @@ static inline void check_free_callbacks(void) do_free_callbacks(); } -static void put_free_entry(grant_ref_t ref) +static void put_free_entry_locked(grant_ref_t ref) { - unsigned long flags; - if (unlikely(ref < GNTTAB_NR_RESERVED_ENTRIES)) return; - spin_lock_irqsave(&gnttab_list_lock, flags); gnttab_entry(ref) = gnttab_free_head; gnttab_free_head = ref; + if (!gnttab_free_count) + gnttab_last_free = ref; + if (gnttab_free_tail_ptr == &gnttab_free_head) + gnttab_free_tail_ptr = __gnttab_entry(ref); gnttab_free_count++; + bitmap_set(gnttab_free_bitmap, ref, 1); +} + +static void put_free_entry(grant_ref_t ref) +{ + unsigned long flags; + + spin_lock_irqsave(&gnttab_list_lock, flags); + put_free_entry_locked(ref); check_free_callbacks(); spin_unlock_irqrestore(&gnttab_list_lock, flags); } +static void gnttab_set_free(unsigned int start, unsigned int n) +{ + unsigned int i; + + for (i = start; i < start + n - 1; i++) + gnttab_entry(i) = i + 1; + + gnttab_entry(i) = GNTTAB_LIST_END; + if (!gnttab_free_count) { + gnttab_free_head = start; + gnttab_free_tail_ptr = &gnttab_free_head; + } else { + gnttab_entry(gnttab_last_free) = start; + } + gnttab_free_count += n; + gnttab_last_free = i; + + bitmap_set(gnttab_free_bitmap, start, n); +} + /* * Following applies to gnttab_update_entry_v1 and gnttab_update_entry_v2. * Introducing a valid entry into the grant table: @@ -450,23 +604,31 @@ void gnttab_free_grant_references(grant_ref_t head) { grant_ref_t ref; unsigned long flags; - int count = 1; - if (head == GNTTAB_LIST_END) - return; + spin_lock_irqsave(&gnttab_list_lock, flags); - ref = head; - while (gnttab_entry(ref) != GNTTAB_LIST_END) { - ref = gnttab_entry(ref); - count++; + while (head != GNTTAB_LIST_END) { + ref = gnttab_entry(head); + put_free_entry_locked(head); + head = ref; } - gnttab_entry(ref) = gnttab_free_head; - gnttab_free_head = head; - gnttab_free_count += count; check_free_callbacks(); spin_unlock_irqrestore(&gnttab_list_lock, flags); } EXPORT_SYMBOL_GPL(gnttab_free_grant_references); +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count) +{ + unsigned long flags; + unsigned int i; + + spin_lock_irqsave(&gnttab_list_lock, flags); + for (i = count; i > 0; i--) + put_free_entry_locked(head + i - 1); + check_free_callbacks(); + spin_unlock_irqrestore(&gnttab_list_lock, flags); +} +EXPORT_SYMBOL_GPL(gnttab_free_grant_reference_seq); + int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) { int h = get_free_entries(count); @@ -480,6 +642,24 @@ int gnttab_alloc_grant_references(u16 count, grant_ref_t *head) } EXPORT_SYMBOL_GPL(gnttab_alloc_grant_references); +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first) +{ + int h; + + if (count == 1) + h = get_free_entries(1); + else + h = get_free_entries_seq(count); + + if (h < 0) + return -ENOSPC; + + *first = h; + + return 0; +} +EXPORT_SYMBOL_GPL(gnttab_alloc_grant_reference_seq); + int gnttab_empty_grant_references(const grant_ref_t *private_head) { return (*private_head == GNTTAB_LIST_END); @@ -572,16 +752,13 @@ static int grow_gnttab_list(unsigned int more_frames) goto grow_nomem; } + gnttab_set_free(gnttab_size, extra_entries); - for (i = grefs_per_frame * nr_grant_frames; - i < grefs_per_frame * new_nr_grant_frames - 1; i++) - gnttab_entry(i) = i + 1; - - gnttab_entry(i) = gnttab_free_head; - gnttab_free_head = grefs_per_frame * nr_grant_frames; - gnttab_free_count += extra_entries; + if (!gnttab_free_tail_ptr) + gnttab_free_tail_ptr = __gnttab_entry(gnttab_size); nr_grant_frames = new_nr_grant_frames; + gnttab_size += extra_entries; check_free_callbacks(); @@ -1424,20 +1601,20 @@ static int gnttab_expand(unsigned int req_entries) int gnttab_init(void) { int i; - unsigned long max_nr_grant_frames; + unsigned long max_nr_grant_frames, max_nr_grefs; unsigned int max_nr_glist_frames, nr_glist_frames; - unsigned int nr_init_grefs; int ret; gnttab_request_version(); max_nr_grant_frames = gnttab_max_grant_frames(); + max_nr_grefs = max_nr_grant_frames * + gnttab_interface->grefs_per_grant_frame; nr_grant_frames = 1; /* Determine the maximum number of frames required for the * grant reference free list on the current hypervisor. */ - max_nr_glist_frames = (max_nr_grant_frames * - gnttab_interface->grefs_per_grant_frame / RPP); + max_nr_glist_frames = max_nr_grefs / RPP; gnttab_list = kmalloc_array(max_nr_glist_frames, sizeof(grant_ref_t *), @@ -1454,6 +1631,12 @@ int gnttab_init(void) } } + gnttab_free_bitmap = bitmap_zalloc(max_nr_grefs, GFP_KERNEL); + if (!gnttab_free_bitmap) { + ret = -ENOMEM; + goto ini_nomem; + } + ret = arch_gnttab_init(max_nr_grant_frames, nr_status_frames(max_nr_grant_frames)); if (ret < 0) @@ -1464,15 +1647,10 @@ int gnttab_init(void) goto ini_nomem; } - nr_init_grefs = nr_grant_frames * - gnttab_interface->grefs_per_grant_frame; - - for (i = GNTTAB_NR_RESERVED_ENTRIES; i < nr_init_grefs - 1; i++) - gnttab_entry(i) = i + 1; + gnttab_size = nr_grant_frames * gnttab_interface->grefs_per_grant_frame; - gnttab_entry(nr_init_grefs - 1) = GNTTAB_LIST_END; - gnttab_free_count = nr_init_grefs - GNTTAB_NR_RESERVED_ENTRIES; - gnttab_free_head = GNTTAB_NR_RESERVED_ENTRIES; + gnttab_set_free(GNTTAB_NR_RESERVED_ENTRIES, + gnttab_size - GNTTAB_NR_RESERVED_ENTRIES); printk("Grant table initialized\n"); return 0; @@ -1481,6 +1659,7 @@ int gnttab_init(void) for (i--; i >= 0; i--) free_page((unsigned long)gnttab_list[i]); kfree(gnttab_list); + bitmap_free(gnttab_free_bitmap); return ret; } EXPORT_SYMBOL_GPL(gnttab_init); diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h index 7d0f2f0..a174f90 100644 --- a/include/xen/grant_table.h +++ b/include/xen/grant_table.h @@ -127,10 +127,14 @@ int gnttab_try_end_foreign_access(grant_ref_t ref); */ int gnttab_alloc_grant_references(u16 count, grant_ref_t *pprivate_head); +int gnttab_alloc_grant_reference_seq(unsigned int count, grant_ref_t *first); + void gnttab_free_grant_reference(grant_ref_t ref); void gnttab_free_grant_references(grant_ref_t head); +void gnttab_free_grant_reference_seq(grant_ref_t head, unsigned int count); + int gnttab_empty_grant_references(const grant_ref_t *pprivate_head); int gnttab_claim_grant_reference(grant_ref_t *pprivate_head); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338748.563599 (Exim 4.92) (envelope-from ) id 1nvmV8-0008LM-AM; Mon, 30 May 2022 21:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338748.563599; Mon, 30 May 2022 21:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV8-0008Jy-5E; Mon, 30 May 2022 21:00:34 +0000 Received: by outflank-mailman (input) for mailman id 338748; Mon, 30 May 2022 21:00:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV6-0007Ks-Ip for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:32 +0000 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [2a00:1450:4864:20::234]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8adee398-e05b-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 23:00:31 +0200 (CEST) Received: by mail-lj1-x234.google.com with SMTP id 5so4109011lju.10 for ; Mon, 30 May 2022 14:00:31 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8adee398-e05b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+FJSf1vwMYB6K1+IygWHYLgdHKsQ/Ri86qwFQ7er7r4=; b=qQaEnEqIn8+KVCu3pPRo+BDQrdzTpsLMqbypvWjSdP/zBsAUHoF+Gerr5XT7DNRZW1 0bpkwfkPu1hMKNckTJkbfqyHKTvvxPuLi2IZmXv8DMFMNKXEOakkweh7lNNBTtPOBInP RK0XWq87slLWTrLyJGGcQJqd8OW+B3LmN9XSCB6PL+8FmxkWI4gWNWUhuz5hn/0OLywc FmS2FjqsGyViA9Q3hUbKnJx84AOsuqZKFmqJuUPb+jKs+WQqtD/joiFjLBoJ8UGFL5xq t9Y57ac2D/yaMy2ErqyyoxRbxwDkBaU13uHKzvKFZmAcaFPptLb+oQOVf2CD+OnQqqDE qNHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+FJSf1vwMYB6K1+IygWHYLgdHKsQ/Ri86qwFQ7er7r4=; b=c4g6Ih0YxDA5gCZ5C1V9JOf4wdMUapS8pQ0CpEjDRrfxArWTZC6UMCDKWGh+5LXUqR mC7/sWLk6eUlJ6De4zH/+3sZjFMV9E2J11TLBgPGjlVYxdxX00fg6e7btPdP6SQlHLl3 5RtXpjt9RPGrP2YfTfKy0QoaBVVUHymX6JQm80Jvz3QM0Tjur7rnwTtD7E7MQ1ILJJB0 5yZ2wXdUWaYAe4qUaIO4J0VJnXw7cKRpOQVxUSE/E+2zLMmXOcRgHY5Qq+Ei+aMp8pnb nLC77Dy26mIkdLa+MSU1I9svHu+wDkrmo0ncBuOz//c1cY7pFrjg9djcGd+98089u6W1 pccA== X-Gm-Message-State: AOAM533Nd+5YsCPcyrAFpjVJKWEl3WNg2pS2cJBAee6ONsRZcKJeqxzg YnB7X8rnW0HZ5CeTu++c8wE1FS+PdLQ= X-Google-Smtp-Source: ABdhPJy1j0CZ8u38C6o5Ly2O9aBU8Z/J0PR4IPWipSyv2hmVKkIJPggqQZ4sM6kw/XDqJU3SD8VYcQ== X-Received: by 2002:a2e:a36f:0:b0:253:d948:731c with SMTP id i15-20020a2ea36f000000b00253d948731cmr32005387ljn.159.1653944431239; Mon, 30 May 2022 14:00:31 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , Rob Herring , Joerg Roedel , Will Deacon , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Arnd Bergmann Subject: [PATCH V3 5/8] dt-bindings: Add xen,grant-dma IOMMU description for xen-grant DMA ops Date: Tue, 31 May 2022 00:00:14 +0300 Message-Id: <1653944417-17168-6-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko The main purpose of this binding is to communicate Xen specific information using generic IOMMU device tree bindings (which is a good fit here) rather than introducing a custom property. Introduce Xen specific IOMMU for the virtualized device (e.g. virtio) to be used by Xen grant DMA-mapping layer in the subsequent commit. The reference to Xen specific IOMMU node using "iommus" property indicates that Xen grant mappings need to be enabled for the device, and it specifies the ID of the domain where the corresponding backend resides. The domid (domain ID) is used as an argument to the Xen grant mapping APIs. This is needed for the option to restrict memory access using Xen grant mappings to work which primary goal is to enable using virtio devices in Xen guests. Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - update commit subject/description and text in description - move to devicetree/bindings/arm/ Changes V1 -> V2: - update text in description - change the maintainer of the binding - fix validation issue - reference xen,dev-domid.yaml schema from virtio/mmio.yaml Change V2 -> V3: - Stefano already gave his Reviewed-by, I dropped it due to the changes (significant) - use generic IOMMU device tree bindings instead of custom property "xen,dev-domid" - change commit subject and description, was "dt-bindings: Add xen,dev-domid property description for xen-grant DMA ops" --- .../devicetree/bindings/iommu/xen,grant-dma.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml diff --git a/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml new file mode 100644 index 00000000..ab5765c --- /dev/null +++ b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iommu/xen,grant-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Xen specific IOMMU for virtualized devices (e.g. virtio) + +maintainers: + - Stefano Stabellini + +description: + The reference to Xen specific IOMMU node using "iommus" property indicates + that Xen grant mappings need to be enabled for the device, and it specifies + the ID of the domain where the corresponding backend resides. + The binding is required to restrict memory access using Xen grant mappings. + +properties: + compatible: + const: xen,grant-dma + + '#iommu-cells': + const: 1 + description: + Xen specific IOMMU is multiple-master IOMMU device. + The single cell describes the domid (domain ID) of the domain where + the backend is running. + +required: + - compatible + - "#iommu-cells" + +additionalProperties: false + +examples: + - | + xen_iommu { + compatible = "xen,grant-dma"; + #iommu-cells = <1>; + }; + + virtio@3000 { + compatible = "virtio,mmio"; + reg = <0x3000 0x100>; + interrupts = <41>; + + /* The backend is located in Xen domain with ID 1 */ + iommus = <&xen_iommu 1>; + }; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338746.563570 (Exim 4.92) (envelope-from ) id 1nvmV6-0007bA-9D; Mon, 30 May 2022 21:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338746.563570; Mon, 30 May 2022 21:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV5-0007Yq-W9; Mon, 30 May 2022 21:00:32 +0000 Received: by outflank-mailman (input) for mailman id 338746; Mon, 30 May 2022 21:00:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV4-0007Ks-VD for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:30 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8967d4e1-e05b-11ec-bd2c-47488cf2e6aa; Mon, 30 May 2022 23:00:29 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id l11so2034850ljb.2 for ; Mon, 30 May 2022 14:00:29 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8967d4e1-e05b-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2t0W0Kf92gsyA+wOLOX+tpqo5IEanf8vKd5d+TCSHc4=; b=qaAXmDoctd89JEFM4Jisqij+yBHCzKG7SZBi45f6sMHo3m/4PUQ013lYcGtETGEHP2 /AEEO1rfDotHbRkTIa7Z0O47PnU1BnCW+N4DfnmMMp1iY2jlwgbm0ciYr1sNizqcorZK Za/tXIOhcIC1E9bHeVdvu5Ii/k+eEI65n/6juSFnVUWAn54XuypuXwUyJ7XDNlTVKj+W w7m77hzM5B1cfhfx6Q1V2tbmfWQsuQgk7dcd+0tAFHxP8YVibUYGQWO6nMl4/7gdJlzY pOkqGUg4EzHE2GqKmWbn6ffvHy/giVFbe9vSA9+yF9/b5QTHIm0AwLodYxcvXRuz9A9a jz/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2t0W0Kf92gsyA+wOLOX+tpqo5IEanf8vKd5d+TCSHc4=; b=NexsSv88nnechfTEpxJuVHkkXu//Xu3mpQ50Wi0km482/X+nj/6M0szNzIQ/37kwa+ kbBqSO5eIWt/9/iBoMYQJPcaDf5+yUNgES/wMKCRMZ34lnfH6j90K7u253rlNp2AsIBC 6zHa3hvId3LE/GWhv/qeIgDfFo2rQaHN/IUL6eWyXHl2XR8guUj/noJMF9v546Z7nS0O k2u6PpV0fBPqjUKVATzTN8ua6yoYy1FVYJakfFG51cqbOxSqVhbR8bUfmvoE6cP7Cv0n I1windFPnV8O5Fbuh0+QEjh6K88YdxKkNj5c8wjnsp7iTht/mfF0cz2/ouaIYDimOc9I xxjA== X-Gm-Message-State: AOAM532B0SA1vN5VY2K1wf2q1ZwWuoifJYiGvrRZ20xLf0m+rhKhviHi kbZi1Z1MVwSFT4JndKpMqTWBAGHeQQs= X-Google-Smtp-Source: ABdhPJyLamYJx4UbyuwE3IRLYem/SU5aTTXg8XDfI465PA9EXhxfERBgKB5WcKKauA7BqRl/UHkUMA== X-Received: by 2002:a2e:330f:0:b0:253:da40:de51 with SMTP id d15-20020a2e330f000000b00253da40de51mr32409091ljc.76.1653944428677; Mon, 30 May 2022 14:00:28 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 3/8] xen/grant-dma-ops: Add option to restrict memory access under Xen Date: Tue, 31 May 2022 00:00:12 +0300 Message-Id: <1653944417-17168-4-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Juergen Gross Introduce Xen grant DMA-mapping layer which contains special DMA-mapping routines for providing grant references as DMA addresses to be used by frontends (e.g. virtio) in Xen guests. Add the needed functionality by providing a special set of DMA ops handling the needed grant operations for the I/O pages. The subsequent commit will introduce the use case for xen-grant DMA ops layer to enable using virtio devices in Xen guests in a safe manner. Signed-off-by: Juergen Gross Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - squash with almost all changes from commit (except handling "xen,dev-domid" property): "[PATCH 4/6] virtio: Various updates to xen-virtio DMA ops layer" - update commit subject/description and comments in code - leave only single Kconfig option XEN_VIRTIO and remove architectural dependencies - introduce common xen_has_restricted_virtio_memory_access() in xen.h and update arch_has_restricted_virtio_memory_access() for both Arm and x86 to call new helper - use (1ULL << 63) instead of 0x8000000000000000ULL for XEN_GRANT_ADDR_OFF - implement xen_virtio_dma_map(unmap)_sg() using example in swiotlb-xen.c - optimize padding by moving "broken" field in struct xen_virtio_data - remove unneeded per-device spinlock - remove the inclusion of virtio_config.h - remane everything according to the new naming scheme: s/virtio/grant_dma - add new hidden config option XEN_GRANT_DMA_OPS Changes V1 -> V2: - fix checkpatch.pl warnings - remove the inclusion of linux/pci.h - rework to use xarray for data context - remove EXPORT_SYMBOL_GPL(xen_grant_setup_dma_ops); - remove the line of * after SPDX-License-Identifier - split changes into grant-dma-ops.c and arch_has_restricted_virtio_memory_access() and update commit subject/description accordingly - remove "default n" for config XEN_VIRTIO - implement xen_grant_dma_alloc(free)_pages() Changes V2 -> V3: - Stefano already gave his Reviewed-by, I dropped it due to the changes (minor) - remane field "dev_domid" in struct xen_grant_dma_data to "backend_domid" - remove local variable "domid" in xen_grant_setup_dma_ops() --- drivers/xen/Kconfig | 4 + drivers/xen/Makefile | 1 + drivers/xen/grant-dma-ops.c | 311 ++++++++++++++++++++++++++++++++++++++++++++ include/xen/xen-ops.h | 8 ++ 4 files changed, 324 insertions(+) create mode 100644 drivers/xen/grant-dma-ops.c diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 120d32f..313a9127 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -335,4 +335,8 @@ config XEN_UNPOPULATED_ALLOC having to balloon out RAM regions in order to obtain physical memory space to create such mappings. +config XEN_GRANT_DMA_OPS + bool + select DMA_OPS + endmenu diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 5aae66e..1a23cb0 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -39,3 +39,4 @@ xen-gntalloc-y := gntalloc.o xen-privcmd-y := privcmd.o privcmd-buf.o obj-$(CONFIG_XEN_FRONT_PGDIR_SHBUF) += xen-front-pgdir-shbuf.o obj-$(CONFIG_XEN_UNPOPULATED_ALLOC) += unpopulated-alloc.o +obj-$(CONFIG_XEN_GRANT_DMA_OPS) += grant-dma-ops.o diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c new file mode 100644 index 00000000..44659f4 --- /dev/null +++ b/drivers/xen/grant-dma-ops.c @@ -0,0 +1,311 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Xen grant DMA-mapping layer - contains special DMA-mapping routines + * for providing grant references as DMA addresses to be used by frontends + * (e.g. virtio) in Xen guests + * + * Copyright (c) 2021, Juergen Gross + */ + +#include +#include +#include +#include +#include +#include +#include + +struct xen_grant_dma_data { + /* The ID of backend domain */ + domid_t backend_domid; + /* Is device behaving sane? */ + bool broken; +}; + +static DEFINE_XARRAY(xen_grant_dma_devices); + +#define XEN_GRANT_DMA_ADDR_OFF (1ULL << 63) + +static inline dma_addr_t grant_to_dma(grant_ref_t grant) +{ + return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT); +} + +static inline grant_ref_t dma_to_grant(dma_addr_t dma) +{ + return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT); +} + +static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev) +{ + struct xen_grant_dma_data *data; + + xa_lock(&xen_grant_dma_devices); + data = xa_load(&xen_grant_dma_devices, (unsigned long)dev); + xa_unlock(&xen_grant_dma_devices); + + return data; +} + +/* + * DMA ops for Xen frontends (e.g. virtio). + * + * Used to act as a kind of software IOMMU for Xen guests by using grants as + * DMA addresses. + * Such a DMA address is formed by using the grant reference as a frame + * number and setting the highest address bit (this bit is for the backend + * to be able to distinguish it from e.g. a mmio address). + * + * Note that for now we hard wire dom0 to be the backend domain. In order + * to support any domain as backend we'd need to add a way to communicate + * the domid of this backend, e.g. via Xenstore, via the PCI-device's + * config space or DT/ACPI. + */ +static void *xen_grant_dma_alloc(struct device *dev, size_t size, + dma_addr_t *dma_handle, gfp_t gfp, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + unsigned long pfn; + grant_ref_t grant; + void *ret; + + data = find_xen_grant_dma_data(dev); + if (!data) + return NULL; + + if (unlikely(data->broken)) + return NULL; + + ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp); + if (!ret) + return NULL; + + pfn = virt_to_pfn(ret); + + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) { + free_pages_exact(ret, n_pages * PAGE_SIZE); + return NULL; + } + + for (i = 0; i < n_pages; i++) { + gnttab_grant_foreign_access_ref(grant + i, data->backend_domid, + pfn_to_gfn(pfn + i), 0); + } + + *dma_handle = grant_to_dma(grant); + + return ret; +} + +static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr, + dma_addr_t dma_handle, unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + + data = find_xen_grant_dma_data(dev); + if (!data) + return; + + if (unlikely(data->broken)) + return; + + grant = dma_to_grant(dma_handle); + + for (i = 0; i < n_pages; i++) { + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); + data->broken = true; + return; + } + } + + gnttab_free_grant_reference_seq(grant, n_pages); + + free_pages_exact(vaddr, n_pages * PAGE_SIZE); +} + +static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size, + dma_addr_t *dma_handle, + enum dma_data_direction dir, + gfp_t gfp) +{ + void *vaddr; + + vaddr = xen_grant_dma_alloc(dev, size, dma_handle, gfp, 0); + if (!vaddr) + return NULL; + + return virt_to_page(vaddr); +} + +static void xen_grant_dma_free_pages(struct device *dev, size_t size, + struct page *vaddr, dma_addr_t dma_handle, + enum dma_data_direction dir) +{ + xen_grant_dma_free(dev, size, page_to_virt(vaddr), dma_handle, 0); +} + +static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page, + unsigned long offset, size_t size, + enum dma_data_direction dir, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + dma_addr_t dma_handle; + + if (WARN_ON(dir == DMA_NONE)) + return DMA_MAPPING_ERROR; + + data = find_xen_grant_dma_data(dev); + if (!data) + return DMA_MAPPING_ERROR; + + if (unlikely(data->broken)) + return DMA_MAPPING_ERROR; + + if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) + return DMA_MAPPING_ERROR; + + for (i = 0; i < n_pages; i++) { + gnttab_grant_foreign_access_ref(grant + i, data->backend_domid, + xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE); + } + + dma_handle = grant_to_dma(grant) + offset; + + return dma_handle; +} + +static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, + size_t size, enum dma_data_direction dir, + unsigned long attrs) +{ + struct xen_grant_dma_data *data; + unsigned int i, n_pages = PFN_UP(size); + grant_ref_t grant; + + if (WARN_ON(dir == DMA_NONE)) + return; + + data = find_xen_grant_dma_data(dev); + if (!data) + return; + + if (unlikely(data->broken)) + return; + + grant = dma_to_grant(dma_handle); + + for (i = 0; i < n_pages; i++) { + if (unlikely(!gnttab_end_foreign_access_ref(grant + i))) { + dev_alert(dev, "Grant still in use by backend domain, disabled for further use\n"); + data->broken = true; + return; + } + } + + gnttab_free_grant_reference_seq(grant, n_pages); +} + +static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + struct scatterlist *s; + unsigned int i; + + if (WARN_ON(dir == DMA_NONE)) + return; + + for_each_sg(sg, s, nents, i) + xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir, + attrs); +} + +static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg, + int nents, enum dma_data_direction dir, + unsigned long attrs) +{ + struct scatterlist *s; + unsigned int i; + + if (WARN_ON(dir == DMA_NONE)) + return -EINVAL; + + for_each_sg(sg, s, nents, i) { + s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset, + s->length, dir, attrs); + if (s->dma_address == DMA_MAPPING_ERROR) + goto out; + + sg_dma_len(s) = s->length; + } + + return nents; + +out: + xen_grant_dma_unmap_sg(dev, sg, i, dir, attrs | DMA_ATTR_SKIP_CPU_SYNC); + sg_dma_len(sg) = 0; + + return -EIO; +} + +static int xen_grant_dma_supported(struct device *dev, u64 mask) +{ + return mask == DMA_BIT_MASK(64); +} + +static const struct dma_map_ops xen_grant_dma_ops = { + .alloc = xen_grant_dma_alloc, + .free = xen_grant_dma_free, + .alloc_pages = xen_grant_dma_alloc_pages, + .free_pages = xen_grant_dma_free_pages, + .mmap = dma_common_mmap, + .get_sgtable = dma_common_get_sgtable, + .map_page = xen_grant_dma_map_page, + .unmap_page = xen_grant_dma_unmap_page, + .map_sg = xen_grant_dma_map_sg, + .unmap_sg = xen_grant_dma_unmap_sg, + .dma_supported = xen_grant_dma_supported, +}; + +void xen_grant_setup_dma_ops(struct device *dev) +{ + struct xen_grant_dma_data *data; + + data = find_xen_grant_dma_data(dev); + if (data) { + dev_err(dev, "Xen grant DMA data is already created\n"); + return; + } + + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); + if (!data) + goto err; + + /* XXX The dom0 is hardcoded as the backend domain for now */ + data->backend_domid = 0; + + if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data, + GFP_KERNEL))) { + dev_err(dev, "Cannot store Xen grant DMA data\n"); + goto err; + } + + dev->dma_ops = &xen_grant_dma_ops; + + return; + +err: + dev_err(dev, "Cannot set up Xen grant DMA ops, retain platform DMA ops\n"); +} + +MODULE_DESCRIPTION("Xen grant DMA-mapping layer"); +MODULE_AUTHOR("Juergen Gross "); +MODULE_LICENSE("GPL"); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a3584a3..4f9fad5 100644 --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -221,4 +221,12 @@ static inline void xen_preemptible_hcall_end(void) { } #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */ +#ifdef CONFIG_XEN_GRANT_DMA_OPS +void xen_grant_setup_dma_ops(struct device *dev); +#else +static inline void xen_grant_setup_dma_ops(struct device *dev) +{ +} +#endif /* CONFIG_XEN_GRANT_DMA_OPS */ + #endif /* INCLUDE_XEN_OPS_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338751.563632 (Exim 4.92) (envelope-from ) id 1nvmVC-0000jl-0p; Mon, 30 May 2022 21:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338751.563632; Mon, 30 May 2022 21:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmVB-0000he-GZ; Mon, 30 May 2022 21:00:37 +0000 Received: by outflank-mailman (input) for mailman id 338751; Mon, 30 May 2022 21:00:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmV9-0007Kr-OS for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:00:35 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cc035c3-e05b-11ec-837f-e5687231ffcc; Mon, 30 May 2022 23:00:35 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id bf44so2884940lfb.0 for ; Mon, 30 May 2022 14:00:35 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k21-20020a2ea275000000b0025550e2693asm581541ljm.38.2022.05.30.14.00.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:00:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cc035c3-e05b-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6yQqHGmllGTqv5b6W6sRDmvHNQ6gC3VDGqt+iST1GP4=; b=S9MQR0ujpwPcnAyQYtPOzs9RCcNptzk0O/ZMxmFkOJnlI6mtmjxlbztcN0YE14G+/O CACKu4Iom63FSxFErPfKqe3D8u1NBDzLCPW0bP4ReCA8eMTw2li9C6ziCtU4wpuuXFOv qt8hKg4Ch3uraBa6Tn2+BZTqz64LBuzU3H+Y3p7d156cESE/deH1HCsjxMQApA/hMabB SVd/urKJWwl1w0Od8Z4zjUY6waUfCEhfljhE6SeNVuuV96Jjyfsdnq6mtPjXwQC9I81N 93RwoCNTdcACEhMhE6pcdd8EPkimavXlYSfpVDIUPItTBv+rAA4J2jKLCkS4egHb/581 YKqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6yQqHGmllGTqv5b6W6sRDmvHNQ6gC3VDGqt+iST1GP4=; b=lCuzT43KFWQ22T4geEuejMVIYecf+KBnL2Hsw9MtUSCtV+6cytoVdtM2YEEaKE0k7O BppglSwkgSPJxHh9WLAYp8HKbhGiJ4nDj+EZrMpe1T9BSygtRHkolDEIeeRTv/k4zeJP efSBXPksl7rbzENPMepfAN8qjKtU44eEuAHo+tok5a4v7nukw5A40I0xobW2ft/mkr4Z 7nD0qgg8I3DkyqzrzU2KNojen20rFq6oTdSl+5HcxtKyVyHpaQOr4A4oMiZSrXUKq+tT qs57WCsF7nHbX7zRN74Nd8ZnVhvNtmP+exuSWyaL0C4GLWgou8C99l5rB6XTABBx+9mN VPDg== X-Gm-Message-State: AOAM531xE5CHhO+I0InHE47vQVw48w0EqntaxQq/e2suSyeflhDJDD8F LEHHrzmVkEm8PK0ZHoedjWqK0dO+lwY= X-Google-Smtp-Source: ABdhPJxRI3M09HPtHmhTVLy5lEGHXzz2fTw91+bnwCJ2p93uOzuCHkjvEzV3hyRjrqV1bLRUpJbu/Q== X-Received: by 2002:a05:6512:22c2:b0:478:3ed7:f0f7 with SMTP id g2-20020a05651222c200b004783ed7f0f7mr37717893lfu.112.1653944434440; Mon, 30 May 2022 14:00:34 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Oleksandr Tyshchenko , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Julien Grall , "Michael S. Tsirkin" , Christoph Hellwig Subject: [PATCH V3 8/8] arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices Date: Tue, 31 May 2022 00:00:17 +0300 Message-Id: <1653944417-17168-9-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko By assigning xen-grant DMA ops we will restrict memory access for passed device using Xen grant mappings. This is needed for using any virtualized device (e.g. virtio) in Xen guests in a safe manner. Please note, for the virtio devices the XEN_VIRTIO config should be enabled (it forces ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS). Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini --- Changes RFC -> V1: - update commit subject/description - remove #ifdef CONFIG_XEN_VIRTIO - re-organize the check taking into the account that swiotlb and virtio cases are mutually exclusive - update according to the new naming scheme: s/virtio/grant_dma Changes V1 -> V2: - add Stefano's R-b - remove arch_has_restricted_virtio_memory_access() check - update commit description - remove the inclusion of virtio_config.h Changes V2 -> V3: - no changes --- include/xen/arm/xen-ops.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h index 288deb1..b0766a6 100644 --- a/include/xen/arm/xen-ops.h +++ b/include/xen/arm/xen-ops.h @@ -3,11 +3,14 @@ #define _ASM_ARM_XEN_OPS_H #include +#include static inline void xen_setup_dma_ops(struct device *dev) { #ifdef CONFIG_XEN - if (xen_swiotlb_detect()) + if (xen_is_grant_dma_device(dev)) + xen_grant_setup_dma_ops(dev); + else if (xen_swiotlb_detect()) dev->dma_ops = &xen_swiotlb_dma_ops; #endif } -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:07:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338822.563650 (Exim 4.92) (envelope-from ) id 1nvmbJ-0004Mj-Tx; Mon, 30 May 2022 21:06:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338822.563650; Mon, 30 May 2022 21:06:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmbJ-0004Mc-QR; Mon, 30 May 2022 21:06:57 +0000 Received: by outflank-mailman (input) for mailman id 338822; Mon, 30 May 2022 21:06:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmbJ-0004MW-41 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 21:06:57 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6fca2476-e05c-11ec-837f-e5687231ffcc; Mon, 30 May 2022 23:06:56 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id a23so12738371ljd.9 for ; Mon, 30 May 2022 14:06:55 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h1-20020a056512220100b0047255d211b2sm2508931lfu.225.2022.05.30.14.06.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2022 14:06:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fca2476-e05c-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yCj6CjDNcsvJy/tFMBx1tpvD/zYHLbLEZ8yli7AQ6SI=; b=IKxzkKOU44sZ/QR6lYJIszLKZPgyf3YMlXOaWcR/JafuI31OSawpfxMqkMCZCxv9Vd QR96mdbSFUaQtpbKMHB7QoPI1CDBafFfQZ/sAV48A4DemTZRNsqkLmBIr4PN40PGeKPE nNg6pfLF7ejgYP4UcNWfY6fYIiQH82wh7FZPdjBOXINxdjKaR0Dpg7eUO5n+MLb9HkG8 /nJQeyphbRqYbLvZUCNQwWtY+ECLv5FTghobkNH//WMJYLFqnTRKHCxI7OtXIBq0o7rf 4Wg+9fBEjUdsdjDTSgLsObFn41dED6t6Aii2ChkYtg5prnmLCFhW92wvSOohw8VPyDYU Q5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yCj6CjDNcsvJy/tFMBx1tpvD/zYHLbLEZ8yli7AQ6SI=; b=e7Hn/NoUTStuH38HdqGjb5mfl4aHZZWxn77Jb8/nA/2PZPo0sjTLTgqznh2fzptXVN V8TunhPgNzXzypzLk73fRSxufg+S0pgrxpEgKJj8QfB5nqB4cmsqTm13mRedBm9IwMS3 ePAFQGIr2yzSyO82SSL6f+XdEtSryDY+d7nwIphWYGbz7PD66pOc/6sV9DNVsW5Zk2Gp 1xHmOSJh+C52YjXtFg8DcKpRkCgdk0NGBeSO758B33qQcCeZMDw8hbVRVdeudSuUvg/4 mHQC9YUUg9IMEgwFhe7blV6vYg9EPqJq+cCPfL2ldMrIpRcVrzueDyAMMrYn2Jbuqd1C 1aXw== X-Gm-Message-State: AOAM531e7LAMH7m8ZJm+bG1qnKM0G6M8zjv4hzBUgzyCIehvhSR3LRlC pG3xhmLcs36Yp02rWCbNSCCDUSUXFMA= X-Google-Smtp-Source: ABdhPJwDqUfiK4FskpnJXVLIzTWuR2ZWMexcpjUyUOMUpDsPdBehARKygsXbdF+kzl31knxhY5H0yw== X-Received: by 2002:a2e:84c7:0:b0:24b:6842:1923 with SMTP id q7-20020a2e84c7000000b0024b68421923mr34895089ljh.166.1653944815285; Mon, 30 May 2022 14:06:55 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH V2] libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Date: Tue, 31 May 2022 00:06:53 +0300 Message-Id: <1653944813-17970-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko --- !!! This patch is based on non upstreamed yet “Virtio support for toolstack on Arm” V8 series which is on review now: https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ New device-tree binding (commit #5) is a part of solution to restrict memory access under Xen using xen-grant DMA-mapping layer (which is also on review): https://lore.kernel.org/xen-devel/1653944417-17168-1-git-send-email-olekstysh@gmail.com/ Changes RFC -> V1: - update commit description - rebase according to the recent changes to "libxl: Introduce basic virtio-mmio support on Arm" Changes V1 -> V2: - Henry already gave his Reviewed-by, I dropped it due to the changes - use generic IOMMU device tree bindings instead of custom property "xen,dev-domid" - change commit subject and description, was "libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node" --- tools/libs/light/libxl_arm.c | 49 ++++++++++++++++++++++++++++++++--- xen/include/public/device_tree_defs.h | 1 + 2 files changed, 47 insertions(+), 3 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 9be9b2a..72da3b1 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -865,9 +865,32 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, return 0; } +static int make_xen_iommu_node(libxl__gc *gc, void *fdt) +{ + int res; + + /* See Linux Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml */ + res = fdt_begin_node(fdt, "xen_iommu"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "xen,grant-dma"); + if (res) return res; + + res = fdt_property_cell(fdt, "#iommu-cells", 1); + if (res) return res; + + res = fdt_property_cell(fdt, "phandle", GUEST_PHANDLE_IOMMU); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; +} static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, - uint64_t base, uint32_t irq) + uint64_t base, uint32_t irq, + uint32_t backend_domid) { int res; gic_interrupt intr; @@ -890,6 +913,16 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property(fdt, "dma-coherent", NULL, 0); if (res) return res; + if (backend_domid != LIBXL_TOOLSTACK_DOMID) { + uint32_t iommus_prop[2]; + + iommus_prop[0] = cpu_to_fdt32(GUEST_PHANDLE_IOMMU); + iommus_prop[1] = cpu_to_fdt32(backend_domid); + + res = fdt_property(fdt, "iommus", iommus_prop, sizeof(iommus_prop)); + if (res) return res; + } + res = fdt_end_node(fdt); if (res) return res; @@ -1097,6 +1130,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; + bool iommu_created; unsigned int i; const libxl_version_info *vers; @@ -1204,11 +1238,20 @@ next_resize: if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); + iommu_created = false; for (i = 0; i < d_config->num_disks; i++) { libxl_device_disk *disk = &d_config->disks[i]; - if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) - FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && + !iommu_created) { + FDT( make_xen_iommu_node(gc, fdt) ); + iommu_created = true; + } + + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, + disk->backend_domid) ); + } } if (pfdt) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 209d43d..df58944 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -7,6 +7,7 @@ * onwards. Reserve a high value for the GIC phandle. */ #define GUEST_PHANDLE_GIC (65000) +#define GUEST_PHANDLE_IOMMU (GUEST_PHANDLE_GIC + 1) #define GUEST_ROOT_ADDRESS_CELLS 2 #define GUEST_ROOT_SIZE_CELLS 2 -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon May 30 21:12:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 21:12:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338836.563661 (Exim 4.92) (envelope-from ) id 1nvmgZ-0005vk-MW; Mon, 30 May 2022 21:12:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338836.563661; Mon, 30 May 2022 21:12:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmgZ-0005vd-IL; Mon, 30 May 2022 21:12:23 +0000 Received: by outflank-mailman (input) for mailman id 338836; Mon, 30 May 2022 21:12:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmgY-0005vT-Bx; Mon, 30 May 2022 21:12:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmgY-0004KO-6x; Mon, 30 May 2022 21:12:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvmgX-0007Cd-Jm; Mon, 30 May 2022 21:12:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvmgX-0004bp-J9; Mon, 30 May 2022 21:12:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1YmXVxr7/Y4Z2t+Oe37wxKn4L7h3u8ChPDSXEn4PIvQ=; b=jS6FLbd7EurMK6+iIWIkAPtHAg UWfo4yt40WtZAUuhMJoPKo2XGJ328PstLD3FFL0Cftj598yB8+a7LQtnLmLPhAtjXqmBvm5wGHFoe FSbKU+y+kSWbburCfd0MTNfzgbWlc/P1p7hLDRjCkU8yHOkRWvGEexHeOC8R9vlUUKw0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170777: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=b00ed48bb0a7c295facf9036135a573a5cdbe7de X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Mon, 30 May 2022 21:12:21 +0000 flight 170777 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170777/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux b00ed48bb0a7c295facf9036135a573a5cdbe7de baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 6 days Failing since 170716 2022-05-24 11:12:06 Z 6 days 19 attempts Testing same since 170771 2022-05-30 00:40:40 Z 0 days 3 attempts ------------------------------------------------------------ 1928 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 213846 lines long.) From xen-devel-bounces@lists.xenproject.org Mon May 30 22:40:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:40:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338847.563671 (Exim 4.92) (envelope-from ) id 1nvo3n-0006Ru-45; Mon, 30 May 2022 22:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338847.563671; Mon, 30 May 2022 22:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo3n-0006Rn-1M; Mon, 30 May 2022 22:40:27 +0000 Received: by outflank-mailman (input) for mailman id 338847; Mon, 30 May 2022 22:40:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo3m-0006Rh-28 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:40:26 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c6bf315-e069-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 00:40:22 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950416258935.3632297768722; Mon, 30 May 2022 15:40:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c6bf315-e069-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653950418; cv=none; d=zohomail.com; s=zohoarc; b=L3kGXoJAmUwxK01tMBFkX+e+lKNgWWpTkC9RFoe7df8hhd4P+HN9AQw7deolILP9T1ixuZ+lhe84czRVCfTN+mOrqZaPj9mCXHDTuEORASTOFpjDrhI/K5RwVj/a4CYj1vZMihWuPgATMOu5BFCuFUErOgpYDYcw2Pf7rwQU1MI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950418; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=qir7TLj3hUjcEYTpsw2J9YevK90J/8tO9fMu2SRDv64=; b=cwikIh2dnyNjahV3EJ2rMMWM9FUe4fTbMXn2dbaCQhxrr0bHprfDFggsQ0k4SBVnKn04+aWsHuD2XD+9vwKPpiG46nnAmy/KDNHDhNb85gYsj+NlIZfSjIYc6OHd54eFYXrMXnVqDJ9zhawKz14BVM369J3KHOIYJOXJmtYLfgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950418; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=qir7TLj3hUjcEYTpsw2J9YevK90J/8tO9fMu2SRDv64=; b=NtLwsIpTIHgjBDkOCosST2XSuUAVHBwVhs9LV+ZSaSkyJgqG3KEoEvhVpqLiTB35 lbJuy2gOe30oYT+mqqEZ9bs58debkMs6NdApZCUpSzGbBkS2S0RkrRyAhkmYEtVZzg6 sqjOrNlbQkHwKld6NxYRxEQfzCqIsDautUs0kn1M= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com Subject: [v2 0/3] xsm: refactor and optimize policy loading Date: Mon, 30 May 2022 22:39:40 -0400 Message-Id: <20220531023945.22196-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series was born out of some cleanup work done while crafting the hyperlaunch boot modules patch series. The primary purpose of this series was to stop walking all boot modules when it was not necessary, but the scope creeped during review. Changes in v2: * changed init_policy to policy_file_required * split the patch into a series * corrected casting of policy buffer * use IS_ENABLED() instead of #ifdef sequence * moved #ifdef inside of braces for xsm_dt_policy_init() * addressed lack of error handling of xsm{mb,dt}_init() Daniel P. Smith (3): xsm: only search for a policy file when needed xsm: consolidate loading the policy buffer xsm: properly handle error from XSM init xen/arch/arm/setup.c | 10 ++++---- xen/arch/x86/setup.c | 9 +++++-- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 56 +++++++++++++++++++++---------------------- xen/xsm/xsm_policy.c | 31 ++++++++++++++++++++---- 5 files changed, 68 insertions(+), 40 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:40:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:40:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338848.563682 (Exim 4.92) (envelope-from ) id 1nvo3s-0006ho-C4; Mon, 30 May 2022 22:40:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338848.563682; Mon, 30 May 2022 22:40:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo3s-0006hh-8r; Mon, 30 May 2022 22:40:32 +0000 Received: by outflank-mailman (input) for mailman id 338848; Mon, 30 May 2022 22:40:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo3r-0006Rh-KE for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:40:31 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8190b2a7-e069-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 00:40:30 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165395041836510.052349096133753; Mon, 30 May 2022 15:40:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8190b2a7-e069-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653950420; cv=none; d=zohomail.com; s=zohoarc; b=OcHcxNHbBQaLLq6H7Twbp6kwJsElx3wQQcGTWIhVXoSFZdGizJQVdR2oQqRq3l03F9CndUYg+V2YWMIjSxbMUgE9M0dMpjJEeJrS5D8Rjm3W9FcOSuUco8AIjpt7hIEnN6IfraiO5sQk7asy/G/uTxx3m+Lg6Tteze68xPJJHMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950420; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0S5/4L9LbrEvX7ep2X/hy4hvb0TSeot95E50192YMEs=; b=KDPXSkXlI9gzVbSWH2hTH/htLO0/8AUC7IKu7hVVaGov3exCSQEmAXWq3j6PBkAY0PwnfTDf9xDuixGUipwS9u4Ev4YWAYBTcMGqo/cMR1vw5vDQ7fhg6Ld8Ht+uFAaUUBUHbm/+u0vEGQk+37A5Hj6KVaaL+tAqCCW4sXICpVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950420; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=0S5/4L9LbrEvX7ep2X/hy4hvb0TSeot95E50192YMEs=; b=JTk1CUoJBkxrhY0eIfzMeBlVKISWSxQkYOrSIssbJSXYb4jTKAybCYtXRtJTbVSp ExSF92bmXTGDq4wqZHflOTZPrXMGrQqysM+C2ty+siFe2gjnKq9A4G8bkN9zT1Ve999 tmr5bvOfgdu6Im1MG9NrSI8GvYVn/qRIwdvD6ZcM= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [v2 1/3] xsm: only search for a policy file when needed Date: Mon, 30 May 2022 22:39:41 -0400 Message-Id: <20220531023945.22196-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> References: <20220531023945.22196-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It is possible to select a few different build configurations that results in the unnecessary walking of the boot module list looking for a policy module. This specifically occurs when the flask policy is enabled but either the dummy or the SILO policy is selected as the enforcing policy. This is not ideal for configurations like hyperlaunch and dom0less when there could be a number of modules to be walked or doing an unnecessary device tree lookup. This patch introduces the policy_file_required flag for tracking when an XSM policy module requires a policy file. Only when the policy_file_required flag is set to true, will XSM search the boot modules for a policy file. Signed-off-by: Daniel P. Smith --- xen/xsm/xsm_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..4a29ee9558 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -55,19 +55,31 @@ static enum xsm_bootparam __initdata xsm_bootparam = XSM_BOOTPARAM_DUMMY; #endif +static bool __initdata policy_file_required = + IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT); + static int __init cf_check parse_xsm_param(const char *s) { int rc = 0; if ( !strcmp(s, "dummy") ) + { xsm_bootparam = XSM_BOOTPARAM_DUMMY; + policy_file_required = false; + } #ifdef CONFIG_XSM_FLASK else if ( !strcmp(s, "flask") ) + { xsm_bootparam = XSM_BOOTPARAM_FLASK; + policy_file_required = true; + } #endif #ifdef CONFIG_XSM_SILO else if ( !strcmp(s, "silo") ) + { xsm_bootparam = XSM_BOOTPARAM_SILO; + policy_file_required = false; + } #endif else rc = -EINVAL; @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:40:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338853.563694 (Exim 4.92) (envelope-from ) id 1nvo48-0007CO-MV; Mon, 30 May 2022 22:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338853.563694; Mon, 30 May 2022 22:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo48-0007CF-JV; Mon, 30 May 2022 22:40:48 +0000 Received: by outflank-mailman (input) for mailman id 338853; Mon, 30 May 2022 22:40:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo47-0006Rh-LW for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:40:47 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b16ea55-e069-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 00:40:46 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165395041961343.19770802633229; Mon, 30 May 2022 15:40:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b16ea55-e069-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653950422; cv=none; d=zohomail.com; s=zohoarc; b=HaPbuXhvTV3X6Se6zXMBzcGDRhj3MDypTXFfiWd7HBCmoEeXAbCF3BKOieyMma85KzeEcOP37uWPyTlJCT/qPU07m39QVWQ07itW3vYl+C++tHB7/x8H0evkHx1ghinfy8NOeJM88zWtdaB6etHJoqUO25CsGD2H8qADhtYtgT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950422; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=C2+K4LrGQhQgI5/c0uDyjquPaNz/qaLDWh7HXB1QsBw=; b=DAvVEOemHHwllNmMfxOKFgYw0cvol/HZDanJ7SB8cEeaVo1VbAvfg8UwaKyEkA8g9Hw8skFXPpuwe6PZff2AGUtc2gz7c8B+iFfqS2pcmJWHE15kg29HEq2kftZkWZk+2FYmBqnwxDzWJMqedA4l1Vi10M8tT9e8rIRnqwz3Z94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950422; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=C2+K4LrGQhQgI5/c0uDyjquPaNz/qaLDWh7HXB1QsBw=; b=p+2ffkQ8+v9rkLWLkoI7WG7m6Y92l8Ixb2GEM+Hswve7eXqHY58klOSe1MvU6fiC kl3kUPOb3oRPIqKNKW3XxQ5i/VkyAXpzfOuU/jbO7FYtLx3r+e+BCITxXc1z2OGBNGy d4FBls6G0+n49Se8ADvVzui1096HezJsVc/kSg60= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [v2 1/3] xsm: optimize policy loading Date: Mon, 30 May 2022 22:39:42 -0400 Message-Id: <20220531023945.22196-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> References: <20220531023945.22196-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It is possible to select a few different build configurations that results in the unnecessary walking of the boot module list looking for a policy module. This specifically occurs when the flask policy is enabled but either the dummy or the SILO policy is selected as the enforcing policy. This is not ideal for configurations like hyperlaunch and dom0less when there could be a number of modules to be walked or unnecessary device tree lookups This patch introduces the policy_file_required flag for tracking when an XSM policy module requires a policy file. Only when the policy_file_required flag is set to true will XSM search the boot modules for a policy file. Signed-off-by: Daniel P. Smith --- xen/xsm/xsm_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..4a29ee9558 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -55,19 +55,31 @@ static enum xsm_bootparam __initdata xsm_bootparam = XSM_BOOTPARAM_DUMMY; #endif +static bool __initdata policy_file_required = + IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT); + static int __init cf_check parse_xsm_param(const char *s) { int rc = 0; if ( !strcmp(s, "dummy") ) + { xsm_bootparam = XSM_BOOTPARAM_DUMMY; + policy_file_required = false; + } #ifdef CONFIG_XSM_FLASK else if ( !strcmp(s, "flask") ) + { xsm_bootparam = XSM_BOOTPARAM_FLASK; + policy_file_required = true; + } #endif #ifdef CONFIG_XSM_SILO else if ( !strcmp(s, "silo") ) + { xsm_bootparam = XSM_BOOTPARAM_SILO; + policy_file_required = false; + } #endif else rc = -EINVAL; @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:41:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338862.563705 (Exim 4.92) (envelope-from ) id 1nvo4L-0007qn-5K; Mon, 30 May 2022 22:41:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338862.563705; Mon, 30 May 2022 22:41:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo4L-0007qf-1G; Mon, 30 May 2022 22:41:01 +0000 Received: by outflank-mailman (input) for mailman id 338862; Mon, 30 May 2022 22:40:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo4J-000799-2A for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:40:59 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 913f81d1-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:40:57 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950420926611.7977371210424; Mon, 30 May 2022 15:40:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 913f81d1-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950423; cv=none; d=zohomail.com; s=zohoarc; b=Q1nnC1nn3zePeyAu2QZJrs+CV8LOCaWnInhAuKCH0PWQF66UanH2JFPiEF4dh39r+Cd+Z1avIOpgx0qiSCygkaadiYWmiNNFZu/zsBkEPHDQSitKoagitMVeAEyopdBT4wrwD/5QeVHwsH1WoytgU0jvmpxqfacSxCLOg0Fo658= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950423; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Sjrnmu86gujeudz33+MAWmkOkhEiPemzBi/wKxHuwM0=; b=Y0Wr/Xef4SfE9Uhb9H/8QEI0HFA2qArR2RvbASNZTQNMvDP4LghQ39TmDthDLf08trl3+N2zb+0N4EXj8adoiW4C6ibss9IOb111rKpzmnlom7zosNJxrE1uFP6bn5EaQdSG3j4KaYN3yCUJj2fUYIslbAhVJdymYwutMUZEWYo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950423; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=Sjrnmu86gujeudz33+MAWmkOkhEiPemzBi/wKxHuwM0=; b=lJocetZNXMF8Sn3/gMH+c9NxySv2OYe6r1+QRh/pVzBoqnTgPE0wMrBfIQIJMdn+ S04mtPUFsjWMdQ4G34hDGfTYPRGg3vcivu96zsMUoONv/A7wtJpF2e+hLon8VU6plaM H0VybZ1ojBHiMYr0+qm8zSxpXSe93UUxOhea3Kos= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [v2 2/3] xsm: consolidate loading the policy buffer Date: Mon, 30 May 2022 22:39:43 -0400 Message-Id: <20220531023945.22196-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> References: <20220531023945.22196-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Previously, initializing the policy buffer was split between two functions, xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading the policy from boot modules and the former for falling back to built-in policy. This patch moves all policy buffer initialization logic under the xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error message is printed for every error condition that may occur in the functions. With all policy buffer init contained and only called when the policy buffer must be populated, the respective xsm_{mb,dt}_init() functions will panic if an error occurs attempting to populate the policy buffer. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 18 +++--------------- xen/xsm/xsm_policy.c | 31 +++++++++++++++++++++++++++---- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..1676c261c9 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -775,7 +775,7 @@ int xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi); int xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); + const unsigned char *policy_buffer[], size_t *policy_size); #endif #ifdef CONFIG_HAS_DEVICE_TREE diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 4a29ee9558..8f6c3de8a6 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -92,14 +92,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { const struct xsm_ops *ops = NULL; -#ifdef CONFIG_XSM_FLASK_POLICY - if ( policy_size == 0 ) - { - policy_buffer = xsm_flask_init_policy; - policy_size = xsm_flask_init_policy_size; - } -#endif - if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { printk(XENLOG_ERR @@ -155,7 +147,7 @@ int __init xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); @@ -167,8 +159,7 @@ int __init xsm_multiboot_init( if ( ret ) { bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } } @@ -192,10 +183,7 @@ int __init xsm_dt_init(void) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) - { - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..6a4f769aec 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -8,7 +8,7 @@ * Contributors: * Michael LeMay, * George Coker, - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. @@ -32,14 +32,21 @@ #ifdef CONFIG_MULTIBOOT int __init xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) + const unsigned char *policy_buffer[], size_t *policy_size) { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif + /* * Try all modules and see whichever could be the binary policy. * Adjust module_map for the module that is the binary policy. @@ -54,13 +61,14 @@ int __init xsm_multiboot_policy_init( if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); __clear_bit(i, module_map); + rc = 0; break; } @@ -68,6 +76,9 @@ int __init xsm_multiboot_policy_init( bootstrap_map(NULL); } + if ( rc == -ENOENT ) + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return rc; } #endif @@ -79,7 +90,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) paddr_t paddr, len; if ( !mod || !mod->size ) + { +#ifdef CONFIG_XSM_FLASK_POLICY + *policy_buffer = (void *)xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; return 0; +#else + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return -ENOENT; +#endif + } paddr = mod->start; len = mod->size; @@ -95,7 +115,10 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) *policy_buffer = xmalloc_bytes(len); if ( !*policy_buffer ) + { + printk(XENLOG_ERR "xsm: Unable to allocate memory for XSM policy\n"); return -ENOMEM; + } copy_from_paddr(*policy_buffer, paddr, len); *policy_size = len; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:41:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338872.563715 (Exim 4.92) (envelope-from ) id 1nvo4S-0008Ho-EK; Mon, 30 May 2022 22:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338872.563715; Mon, 30 May 2022 22:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo4S-0008Hh-BU; Mon, 30 May 2022 22:41:08 +0000 Received: by outflank-mailman (input) for mailman id 338872; Mon, 30 May 2022 22:41:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo4R-000799-Jk for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:41:07 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96a334e7-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:41:05 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950422129887.0158623525535; Mon, 30 May 2022 15:40:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96a334e7-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950424; cv=none; d=zohomail.com; s=zohoarc; b=mbmVHmKKxaCOIAv8wvakvVru164Uh3L/bS0tJI2/mGHlQb3VMW2HlZ536yC2dVMIuXSTjpaxJqcfoMtBtXbL/kayV4zZMB5mHt07Pvo8OLBS7xG2TwTi+K2KqAUVqcUbXfNNt6o6OHDORmgAfDnxyRosSFQNSbNcXC+eFooqNuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950424; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=527tT9WU0HgntC22WaUmTxYXfawaS2vBXUjSXSJ4Fmo=; b=B5qP2MX2+v3cK1Ur12RXPLY4Wg4T4GhcTVEB2HsIsg/HQIZlp3RHFQ5IJCbEHFOkQq3i1yViWrrZPmQ9zq1B4uEU+AlANFwsjXuy+XI+Ug/6GYEiEhlRbm/BmZGcOpzdGxzvQgZPBtyyz5eZ9KLPoHWfslpXlo6bM94wZuiJyE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950424; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=527tT9WU0HgntC22WaUmTxYXfawaS2vBXUjSXSJ4Fmo=; b=pfnpokIbgJE+lrYnquFN1jbTz8b4QZYQar4suUwlwJ4BIiSWxBM2eJ/90KNobZjL 2Aw4Y1Sy/0R4rTFWtk8wy2C/0JL3NjF7eseY8J+NepStbb7UrERop93HnWhjRuhknat 3opZAsh2XkNmj4FRJlLG0ZlJsXyEUb4XepnWYP1A= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [v2 2/3] xsm: refactor policy loading Date: Mon, 30 May 2022 22:39:44 -0400 Message-Id: <20220531023945.22196-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> References: <20220531023945.22196-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Previously initializing the policy buffer was split between two functions, xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading the policy from boot modules and the former for falling back to built-in policy. This patch moves all policy buffer initialization logic under the xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error message is printed for every error condition that may occur in the functions. With all policy buffer init contained and only called when the policy buffer must be populated, the respective xsm_{mb,dt}_init() functions will panic if an error occurs attempting to populate the policy buffer. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 18 +++--------------- xen/xsm/xsm_policy.c | 31 +++++++++++++++++++++++++++---- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..1676c261c9 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -775,7 +775,7 @@ int xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi); int xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); + const unsigned char *policy_buffer[], size_t *policy_size); #endif #ifdef CONFIG_HAS_DEVICE_TREE diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 4a29ee9558..8f6c3de8a6 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -92,14 +92,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { const struct xsm_ops *ops = NULL; -#ifdef CONFIG_XSM_FLASK_POLICY - if ( policy_size == 0 ) - { - policy_buffer = xsm_flask_init_policy; - policy_size = xsm_flask_init_policy_size; - } -#endif - if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { printk(XENLOG_ERR @@ -155,7 +147,7 @@ int __init xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); @@ -167,8 +159,7 @@ int __init xsm_multiboot_init( if ( ret ) { bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } } @@ -192,10 +183,7 @@ int __init xsm_dt_init(void) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) - { - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..6a4f769aec 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -8,7 +8,7 @@ * Contributors: * Michael LeMay, * George Coker, - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. @@ -32,14 +32,21 @@ #ifdef CONFIG_MULTIBOOT int __init xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) + const unsigned char *policy_buffer[], size_t *policy_size) { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif + /* * Try all modules and see whichever could be the binary policy. * Adjust module_map for the module that is the binary policy. @@ -54,13 +61,14 @@ int __init xsm_multiboot_policy_init( if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); __clear_bit(i, module_map); + rc = 0; break; } @@ -68,6 +76,9 @@ int __init xsm_multiboot_policy_init( bootstrap_map(NULL); } + if ( rc == -ENOENT ) + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return rc; } #endif @@ -79,7 +90,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) paddr_t paddr, len; if ( !mod || !mod->size ) + { +#ifdef CONFIG_XSM_FLASK_POLICY + *policy_buffer = (void *)xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; return 0; +#else + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return -ENOENT; +#endif + } paddr = mod->start; len = mod->size; @@ -95,7 +115,10 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) *policy_buffer = xmalloc_bytes(len); if ( !*policy_buffer ) + { + printk(XENLOG_ERR "xsm: Unable to allocate memory for XSM policy\n"); return -ENOMEM; + } copy_from_paddr(*policy_buffer, paddr, len); *policy_size = len; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:41:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338893.563726 (Exim 4.92) (envelope-from ) id 1nvo5C-0000sg-OH; Mon, 30 May 2022 22:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338893.563726; Mon, 30 May 2022 22:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo5C-0000sZ-Lc; Mon, 30 May 2022 22:41:54 +0000 Received: by outflank-mailman (input) for mailman id 338893; Mon, 30 May 2022 22:41:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo4a-000799-S6 for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:41:16 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9bc7b1ed-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:41:14 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950423920903.2613018163844; Mon, 30 May 2022 15:40:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bc7b1ed-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950426; cv=none; d=zohomail.com; s=zohoarc; b=XrvTuKYnQvr4VmxSf5tKRMwkglQkygeiNP8xPTO7MSvDJTb3+NNc27XqncdtfI4B0i8G+kfSlo6TrobfI/qBKVIHcZ+KXC+fxZ3Xj1los2vhTppGjMd5/LUklExRkJjKh1acQl1mfTy/2Vqida9Tifrrxl9R2Dr7JYFcTpm0GMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950426; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=nndS4b5R/wYFUWfqbrv+HVeHYowHUAVZYTBTrHEBrVY=; b=WQl/+jdaHNXtbkvckiP8rTWW8rTh7BA6MtU7VyRcG+jYKQ9J/8P+o9LW5n6/8PJFiPVo2Sbic/6rBkijPst/uTFtLG8QYbTXfnvn+hDXk8zJDCYOF2BF3GLj1Gg1xAI5rHywJpF1nTEiEl5fgLjE4THK7U1JHG7ZC3ur1HWbC2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950426; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=nndS4b5R/wYFUWfqbrv+HVeHYowHUAVZYTBTrHEBrVY=; b=H0EVJc5QO8n65Xn2pOmGFcrLtETK1L93L5emmI7SvD7IJmlm6N8jVKMKQ/qhtDC1 MsfbX0whXMUEVu/2dEbLGW/LniKy1bop36BnG46+2xl4EqUx0I6B9lmbreZx/ynolBc rcEVUD4PKjckwSAmnLCsLDyo7rxfcxxrm8CH+tsc= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Daniel De Graaf Subject: [v2 3/3] xsm: properly handle error from XSM init Date: Mon, 30 May 2022 22:39:45 -0400 Message-Id: <20220531023945.22196-6-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> References: <20220531023945.22196-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit is to move towards providing a uniform interface across architectures to initialize the XSM framework. Specifically, it provides a common handling of initialization failure by providing the printing of a warning message. For Arm, xsm_dt_init() was tailored to have an Arm specific expansion of the return values. This expansion added a value to reflect whether the security supported XSM policy module was the enforcing policy module. This was then used to determine if a warning message would be printed. Despite this expansion, like x86, Arm does not address any XSM initialization errors that may have occurred. Signed-off-by: Daniel P. Smith --- xen/arch/arm/setup.c | 10 +++++----- xen/arch/x86/setup.c | 9 +++++++-- xen/xsm/xsm_core.c | 22 +++++++++++----------- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index ea1f5ee3d3..6bf71e1064 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -967,11 +967,11 @@ void __init start_xen(unsigned long boot_phys_offset, tasklet_subsys_init(); - if ( xsm_dt_init() != 1 ) - warning_add("WARNING: SILO mode is not enabled.\n" - "It has implications on the security of the system,\n" - "unless the communications have been forbidden between\n" - "untrusted domains.\n"); + if ( xsm_dt_init() ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); init_maintenance_interrupt(); init_timer_interrupt(); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 53a73010e0..ed67b50c9d 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #ifdef CONFIG_COMPAT @@ -1690,7 +1691,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period); - if ( opt_watchdog ) + if ( opt_watchdog ) nmi_watchdog = NMI_LOCAL_APIC; find_smp_config(); @@ -1700,7 +1701,11 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + if ( xsm_multiboot_init(module_map, mbi) ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); /* * IOMMU-related ACPI table parsing may require some of the system domains diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 8f6c3de8a6..6377895e1e 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,23 +10,17 @@ * as published by the Free Software Foundation. */ -#include #include +#include +#include #include #include - -#include +#include #include -#ifdef CONFIG_XSM - -#ifdef CONFIG_MULTIBOOT #include -#endif -#ifdef CONFIG_HAS_DEVICE_TREE -#include -#endif +#ifdef CONFIG_XSM #define XSM_FRAMEWORK_VERSION "1.0.1" @@ -190,7 +184,13 @@ int __init xsm_dt_init(void) xfree(policy_buffer); - return ret ?: (xsm_bootparam == XSM_BOOTPARAM_SILO); + if ( xsm_bootparam != XSM_BOOTPARAM_SILO ) + warning_add("WARNING: SILO mode is not enabled.\n" + "It has implications on the security of the system,\n" + "unless the communications have been forbidden between\n" + "untrusted domains.\n"); + + return ret; } /** -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:51:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338912.563749 (Exim 4.92) (envelope-from ) id 1nvoEb-0002oS-2k; Mon, 30 May 2022 22:51:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338912.563749; Mon, 30 May 2022 22:51:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvoEa-0002oL-Vd; Mon, 30 May 2022 22:51:36 +0000 Received: by outflank-mailman (input) for mailman id 338912; Mon, 30 May 2022 22:51:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo5M-000799-1a for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:42:04 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7ffd025-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:42:01 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950517414802.6910809499935; Mon, 30 May 2022 15:41:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7ffd025-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950519; cv=none; d=zohomail.com; s=zohoarc; b=D0Qso4mixIKrtc7HLC3FRexzKc7sYDK7eDIhXrtA/9JZzDD+ZHnF05fHP3bmyyina0D+Fhc/LpEATvi+ZnYgHX9QrLgtAw7ooJKBKfeNembm1WMucLB+8wjeUNbnQ8QMPFDeM5e3+8Rk/k1l/mEd0QMvqNKtNRhbMszvES/cmB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950519; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=ZeXQSjEyyrrxxE3o1HiaJLRHDYVkRyJ+opFzPaTQpPQ=; b=fEuPcQ380F4ro17RpCSfYh5IkVnahTSVmVIjEjPdcM6snDJx5gyt/xCtb4oKh4UUlzscu8i+SjfKxre1Tshp1CNmukWkbzQAetj3JGDkJtCT58Dj7E/zUQEgh7Chrv4nGdnh3ZKiI82a3Om+9C0byrfdZLUJ/bRLg6YCfb6L5Xk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950519; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=ZeXQSjEyyrrxxE3o1HiaJLRHDYVkRyJ+opFzPaTQpPQ=; b=UKjEXab2BWtfCd5T1ZWusntTjiREg93Ijq7A+f3z/kCu2ZDIR+cBkJU5ZBgHIqGo I3BPo2d0DmK5VuzvFLbiW8zAJCWRwwQEBMtMnVhSRBqgcG20e8bMtI2VodaGmHljoFD zyMiY4ISuEcXvzr820YK/2vINxO0TNj7gHv5YW3s= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, sstabellini@kernel.org Subject: [RFC PATCH 0/4] Introducing a common representation of boot info Date: Mon, 30 May 2022 22:41:22 -0400 Message-Id: <20220531024127.23669-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series serves as a proposal to arrive at a common, cross-architecture way for boot information to be represented during startup. This proposal is derived from the structures devised to represent hyperlaunch boot information. The hyperlaunch boot information structures themselves were based on the boot info structures used by Arm and dom0less. A significant effort went into ensuring the structures are able to support dom0less as well as hyperlaunch. Arm and x86 both have arch specific information that must be represented. The approach here sought to support this through arch structures while attempting to maximize what was retained in the common structures. For this series, the focus was on converting x86 over to the new boot info structures. The motivation for this series is due to the fact that the multiboot v1 structures used by x86 are not sufficient for hyperlaunch. In the previously submited hyperlaunch RFC, this was managed by wrapping the mb structures inside⎄ the hyperlaunch structures. This at best was could be considered crude, but really it was just a hack. One of the goals of hyperlaunch is to unify as much as possible with dom0less to remove any unnecessary duplication. Adopting a common representation for boot information will provide a solid foundation for this unification. The added benefit is that in few places this will enable an unnecessary arch specific version of logic, XSM for example would be able to drop arch specific init functions. This series being submitted as an RFC due to,   * the number of design decisions being made within the series * the limited testing able to be completed * how extensive the changes will be for x86 NB: This series is built on top of the v2 patch series, "xsm: refactor and optimize policy loading". Daniel P. Smith (4): kconfig: allow configuration of maximum modules headers: introduce generalized boot info x86: adopt new boot info structures x86: refactor entrypoints to new boot info xen/arch/Kconfig | 12 ++ xen/arch/arm/include/asm/setup.h | 5 +- xen/arch/x86/boot/boot_info32.h | 81 ++++++++ xen/arch/x86/boot/defs.h | 17 +- xen/arch/x86/boot/reloc.c | 187 +++++++++++------ xen/arch/x86/bzimage.c | 16 +- xen/arch/x86/cpu/microcode/core.c | 134 ++++++++----- xen/arch/x86/dom0_build.c | 13 +- xen/arch/x86/efi/efi-boot.h | 96 +++++---- xen/arch/x86/guest/xen/pvh-boot.c | 58 ++++-- xen/arch/x86/hvm/dom0_build.c | 42 ++-- xen/arch/x86/include/asm/bootinfo.h | 45 +++++ xen/arch/x86/include/asm/bzimage.h | 5 +- xen/arch/x86/include/asm/dom0_build.h | 15 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/include/asm/setup.h | 14 +- xen/arch/x86/pv/dom0_build.c | 34 ++-- xen/arch/x86/setup.c | 234 ++++++++++++---------- xen/common/efi/boot.c | 4 +- xen/include/xen/bootinfo.h | 101 ++++++++++ xen/include/xsm/xsm.h | 26 ++- xen/xsm/xsm_core.c | 22 +- xen/xsm/xsm_policy.c | 44 ++-- 23 files changed, 804 insertions(+), 407 deletions(-) create mode 100644 xen/arch/x86/boot/boot_info32.h create mode 100644 xen/arch/x86/include/asm/bootinfo.h create mode 100644 xen/include/xen/bootinfo.h -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:51:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338906.563738 (Exim 4.92) (envelope-from ) id 1nvoEY-0002WS-Nb; Mon, 30 May 2022 22:51:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338906.563738; Mon, 30 May 2022 22:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvoEY-0002WL-Iz; Mon, 30 May 2022 22:51:34 +0000 Received: by outflank-mailman (input) for mailman id 338906; Mon, 30 May 2022 22:51:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo6I-0006Rh-Mt for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:43:03 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dafb0382-e069-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 00:43:00 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165395052385312.548724071218999; Mon, 30 May 2022 15:42:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dafb0382-e069-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653950525; cv=none; d=zohomail.com; s=zohoarc; b=LyctmwvFWMx31av57yID37Qi68+X4ucdKeqV6YkmP8mzN0KfeBvmJUQFbgZ+49CyC8tnGxazc80+bwKBgNUnZYFsPxJB3Pq5w43AdI+0w+4CmtzRVVKbSZZ6qhzSUYQaRe5+VcK6x9pdc8F4TkH/Z4pCTYuRbOCu9R+/BWGkEgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950525; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QsrPUqkDtUvJ+NOAy+kFxwJxYrCsp40uZ3+rvq7odxY=; b=Gouo+NXbdg4kORk1NrCvGCd8GnKwhs6uvCIlbn7kPMsjLBpDDMric1xOHQd7b4dNR2pJrls+5PHVfcN9/JVTP7T4jmGKMmJfIsV5wSlU2mwXvFDo+o20jqiV+TQYffocvSlIXam0s+0u1mvEkzzdiyCTcOceQcZ1ZBIDCN6DzF8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950525; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=QsrPUqkDtUvJ+NOAy+kFxwJxYrCsp40uZ3+rvq7odxY=; b=XV2fMoPrhoslbADyC77oBQFaEqy7NYBxgk8mCNcUFhdAcoioG/AWlSqQxH2DY7PO +EaV/mVhQQ+WpzxNUdj04ALCmK4d2tgBmHLwshHq8k+3nKRSYbg/kVCS3DmYmN9DjvN PCRT7OOA2cuBUEOPJ6uyjJB2C9sxhLTo7k+iP3X8= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC PATCH 4/4] x86: refactor entrypoints to new boot info Date: Mon, 30 May 2022 22:41:26 -0400 Message-Id: <20220531024127.23669-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531024127.23669-1-dpsmith@apertussolutions.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This previous commit added a transition point from multiboot v1 structures to the new boot info structures at the earliest common point for all the x86 entrypoints. The result is that each of the entrypoints would construct a multiboot v1 structure from the structures used by each entrypoint.  This meant that multiboot2, EFI, and PVH all converted their structures over to mutliboot v1 to only be converted again upon entering __start_xen(). This commit drops the translation function and moves the population of the new boot info structures down into the various entrypoints. Signed-off-by: Daniel P. Smith --- xen/arch/x86/boot/boot_info32.h | 81 ++++++++++ xen/arch/x86/boot/defs.h | 17 +- xen/arch/x86/boot/reloc.c | 187 +++++++++++++++------- xen/arch/x86/efi/efi-boot.h | 96 ++++++----- xen/arch/x86/guest/xen/pvh-boot.c | 58 ++++--- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/setup.c | 71 +++----- xen/common/efi/boot.c | 4 +- 8 files changed, 342 insertions(+), 178 deletions(-) create mode 100644 xen/arch/x86/boot/boot_info32.h diff --git a/xen/arch/x86/boot/boot_info32.h b/xen/arch/x86/boot/boot_info32.h new file mode 100644 index 0000000000..76c78e2cae --- /dev/null +++ b/xen/arch/x86/boot/boot_info32.h @@ -0,0 +1,81 @@ +#ifndef __BOOT_INFO32_H__ +#define __BOOT_INFO32_H__ + +#include "defs.h" + +typedef enum { + BOOTMOD_UNKNOWN, + BOOTMOD_XEN, + BOOTMOD_FDT, + BOOTMOD_KERNEL, + BOOTMOD_RAMDISK, + BOOTMOD_XSM, + BOOTMOD_UCODE, + BOOTMOD_GUEST_DTB, +} bootmodule_kind; + +typedef enum { + BOOTSTR_EMPTY, + BOOTSTR_STRING, + BOOTSTR_CMDLINE, +} bootstring_kind; + +#define BOOTMOD_MAX_STRING 1024 +struct boot_string { + u32 kind; + u64 arch; + + char bytes[BOOTMOD_MAX_STRING]; + u64 len; +}; + +struct arch_bootmodule { + bool relocated; + u32 flags; +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + u32 headroom; +}; + +struct boot_module { + u32 kind; + u64 start; + u64 mfn; + u64 size; + + u64 arch; + struct boot_string string; +}; + +struct arch_boot_info { + u32 flags; +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 +#define BOOTINFO_FLAG_X86_APM 1U << 10 + + u64 boot_loader_name; + + u32 mem_lower; + u32 mem_upper; + + u32 mmap_length; + u64 mmap_addr; +}; + +struct boot_info { + u64 cmdline; + + u32 nr_mods; + u64 mods; + + u64 arch; +}; + +#endif diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec..d742a2b52a 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -22,11 +22,11 @@ #include "../../../include/xen/stdbool.h" -#define __maybe_unused __attribute__((__unused__)) -#define __packed __attribute__((__packed__)) -#define __stdcall __attribute__((__stdcall__)) +#define __maybe_unused __attribute__((__unused__)) +#define __packed __attribute__((__packed__)) +#define __stdcall __attribute__((__stdcall__)) -#define NULL ((void *)0) +#define NULL ((void *)0) #define ALIGN_UP(arg, align) \ (((arg) + (align) - 1) & ~((typeof(arg))(align) - 1)) @@ -43,9 +43,10 @@ (void) (&_x == &_y); \ _x > _y ? _x : _y; }) -#define _p(val) ((void *)(unsigned long)(val)) +#define _p(val) ((void *)(unsigned long)(val)) +#define _addr(val) ((unsigned long)(void *)(val)) -#define tolower(c) ((c) | 0x20) +#define tolower(c) ((c) | 0x20) typedef unsigned char u8; typedef unsigned short u16; @@ -57,7 +58,7 @@ typedef u16 uint16_t; typedef u32 uint32_t; typedef u64 uint64_t; -#define U16_MAX ((u16)(~0U)) -#define UINT_MAX (~0U) +#define U16_MAX ((u16)(~0U)) +#define UINT_MAX (~0U) #endif /* __BOOT_DEFS_H__ */ diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index e22bb974bf..4c40cadff6 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -27,6 +27,7 @@ asm ( ); #include "defs.h" +#include "boot_info32.h" #include "../../../include/xen/multiboot.h" #include "../../../include/xen/multiboot2.h" @@ -138,65 +139,116 @@ static struct hvm_start_info *pvh_info_reloc(u32 in) return out; } -static multiboot_info_t *mbi_reloc(u32 mbi_in) +static struct boot_info *mbi_reloc(u32 mbi_in) { + const multiboot_info_t *mbi = _p(mbi_in); + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; int i; - multiboot_info_t *mbi_out; + uint32_t ptr; - mbi_out = _p(copy_mem(mbi_in, sizeof(*mbi_out))); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); - if ( mbi_out->flags & MBI_CMDLINE ) - mbi_out->cmdline = copy_string(mbi_out->cmdline); + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); - if ( mbi_out->flags & MBI_MODULES ) + if ( mbi->flags & MBI_CMDLINE ) + { + ptr = copy_string(mbi->cmdline); + binfo->cmdline = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; + } + + if ( mbi->flags & MBI_MODULES ) { module_t *mods; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; + + /* + * We have to allocate one more module slot here. At some point + * __start_xen() may put Xen image placement into it. + */ + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*bi_mods)); + binfo->nr_mods = mbi->mods_count; + binfo->mods = ptr; + bi_mods = _p(ptr); - mbi_out->mods_addr = copy_mem(mbi_out->mods_addr, - mbi_out->mods_count * sizeof(module_t)); + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); - mods = _p(mbi_out->mods_addr); + /* map the +1 allocated for Xen image */ + bi_mods[mbi->mods_count].arch = _addr(&arch_bi_mods[mbi->mods_count]); - for ( i = 0; i < mbi_out->mods_count; i++ ) + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; + + mods = _p(mbi->mods_addr); + + for ( i = 0; i < mbi->mods_count; i++ ) { + bi_mods[i].start = mods[i].mod_start; + bi_mods[i].size = mods[i].mod_end - mods[i].mod_start; + if ( mods[i].string ) - mods[i].string = copy_string(mods[i].string); + { + int j; + char *c = _p(mods[i].string); + + for ( j = 0; *c != '\0'; j++, c++ ) + bi_mods[i].string.bytes[j] = *c; + + bi_mods[i].string.len = j + 1; + } + + bi_mods[i].arch = _addr(&arch_bi_mods[i]); } } - if ( mbi_out->flags & MBI_MEMMAP ) - mbi_out->mmap_addr = copy_mem(mbi_out->mmap_addr, mbi_out->mmap_length); - - if ( mbi_out->flags & MBI_LOADERNAME ) - mbi_out->boot_loader_name = copy_string(mbi_out->boot_loader_name); + if ( mbi->flags & MBI_MEMMAP ) + { + arch_binfo->mmap_addr = copy_mem(mbi->mmap_addr, mbi->mmap_length); + arch_binfo->mmap_length = mbi->mmap_length; + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; + } - /* Mask features we don't understand or don't relocate. */ - mbi_out->flags &= (MBI_MEMLIMITS | - MBI_CMDLINE | - MBI_MODULES | - MBI_MEMMAP | - MBI_LOADERNAME); + if ( mbi->flags & MBI_LOADERNAME ) + { + ptr = copy_string(mbi->boot_loader_name); + arch_binfo->boot_loader_name = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; + } - return mbi_out; + return binfo; } -static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) +static struct boot_info *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) { const multiboot2_fixed_t *mbi_fix = _p(mbi_in); const multiboot2_memory_map_t *mmap_src; const multiboot2_tag_t *tag; - module_t *mbi_out_mods = NULL; memory_map_t *mmap_dst; - multiboot_info_t *mbi_out; + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; #ifdef CONFIG_VIDEO struct boot_video_info *video = NULL; #endif u32 ptr; unsigned int i, mod_idx = 0; - ptr = alloc_mem(sizeof(*mbi_out)); - mbi_out = _p(ptr); - zero_mem(ptr, sizeof(*mbi_out)); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); + + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); /* Skip Multiboot2 information fixed part. */ ptr = ALIGN_UP(mbi_in + sizeof(*mbi_fix), MULTIBOOT2_TAG_ALIGN); @@ -206,21 +258,28 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) tag = _p(ALIGN_UP((u32)tag + tag->size, MULTIBOOT2_TAG_ALIGN)) ) { if ( tag->type == MULTIBOOT2_TAG_TYPE_MODULE ) - ++mbi_out->mods_count; + ++binfo->nr_mods; else if ( tag->type == MULTIBOOT2_TAG_TYPE_END ) break; } - if ( mbi_out->mods_count ) + if ( binfo->nr_mods ) { - mbi_out->flags |= MBI_MODULES; /* * We have to allocate one more module slot here. At some point * __start_xen() may put Xen image placement into it. */ - mbi_out->mods_addr = alloc_mem((mbi_out->mods_count + 1) * - sizeof(*mbi_out_mods)); - mbi_out_mods = _p(mbi_out->mods_addr); + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*bi_mods)); + binfo->mods = ptr; + bi_mods = _p(ptr); + + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); + + /* map the +1 allocated for Xen image */ + bi_mods[binfo->nr_mods].arch = _addr(&arch_bi_mods[binfo->nr_mods]); + + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; } /* Skip Multiboot2 information fixed part. */ @@ -232,39 +291,38 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) switch ( tag->type ) { case MULTIBOOT2_TAG_TYPE_BOOT_LOADER_NAME: - mbi_out->flags |= MBI_LOADERNAME; ptr = get_mb2_string(tag, string, string); - mbi_out->boot_loader_name = copy_string(ptr); + arch_binfo->boot_loader_name = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; break; case MULTIBOOT2_TAG_TYPE_CMDLINE: - mbi_out->flags |= MBI_CMDLINE; ptr = get_mb2_string(tag, string, string); - mbi_out->cmdline = copy_string(ptr); + binfo->cmdline = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; break; case MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO: - mbi_out->flags |= MBI_MEMLIMITS; - mbi_out->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); - mbi_out->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); + arch_binfo->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); + arch_binfo->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); break; case MULTIBOOT2_TAG_TYPE_MMAP: if ( get_mb2_data(tag, mmap, entry_size) < sizeof(*mmap_src) ) break; - mbi_out->flags |= MBI_MEMMAP; - mbi_out->mmap_length = get_mb2_data(tag, mmap, size); - mbi_out->mmap_length -= sizeof(multiboot2_tag_mmap_t); - mbi_out->mmap_length /= get_mb2_data(tag, mmap, entry_size); - mbi_out->mmap_length *= sizeof(*mmap_dst); + arch_binfo->mmap_length = get_mb2_data(tag, mmap, size); + arch_binfo->mmap_length -= sizeof(multiboot2_tag_mmap_t); + arch_binfo->mmap_length /= get_mb2_data(tag, mmap, entry_size); + arch_binfo->mmap_length *= sizeof(*mmap_dst); - mbi_out->mmap_addr = alloc_mem(mbi_out->mmap_length); + arch_binfo->mmap_addr = alloc_mem(arch_binfo->mmap_length); + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; mmap_src = get_mb2_data(tag, mmap, entries); - mmap_dst = _p(mbi_out->mmap_addr); + mmap_dst = _p(arch_binfo->mmap_addr); - for ( i = 0; i < mbi_out->mmap_length / sizeof(*mmap_dst); i++ ) + for ( i = 0; i < arch_binfo->mmap_length / sizeof(*mmap_dst); i++ ) { /* Init size member properly. */ mmap_dst[i].size = sizeof(*mmap_dst); @@ -280,14 +338,27 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) break; case MULTIBOOT2_TAG_TYPE_MODULE: - if ( mod_idx >= mbi_out->mods_count ) + if ( mod_idx >= binfo->nr_mods ) break; - mbi_out_mods[mod_idx].mod_start = get_mb2_data(tag, module, mod_start); - mbi_out_mods[mod_idx].mod_end = get_mb2_data(tag, module, mod_end); + bi_mods[mod_idx].start = get_mb2_data(tag, module, mod_start); + bi_mods[mod_idx].size = get_mb2_data(tag, module, mod_end) + - bi_mods[mod_idx].start; + ptr = get_mb2_string(tag, module, cmdline); - mbi_out_mods[mod_idx].string = copy_string(ptr); - mbi_out_mods[mod_idx].reserved = 0; + if ( ptr ) + { + int i; + char *c = _p(ptr); + + for ( i = 0; *c != '\0'; i++, c++ ) + bi_mods[mod_idx].string.bytes[i] = *c; + + bi_mods[mod_idx].string.len = i + 1; + } + + bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]); + ++mod_idx; break; @@ -344,11 +415,11 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) video->orig_video_isVGA = 0x23; #endif - return mbi_out; + return binfo; } -void *__stdcall reloc(uint32_t magic, uint32_t in, uint32_t trampoline, - uint32_t video_info) +void *__stdcall reloc( + uint32_t magic, uint32_t in, uint32_t trampoline, uint32_t video_info) { alloc = trampoline; diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 4e1a799749..933eb30a28 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -11,14 +11,17 @@ #include static struct file __initdata ucode; -static multiboot_info_t __initdata mbi = { - .flags = MBI_MODULES | MBI_LOADERNAME -}; + +static struct boot_info __initdata efi_bi; +static struct arch_boot_info __initdata efi_bi_arch; /* * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; +static struct boot_module __initdata efi_mods[CONFIG_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata efi_arch_mods[CONFIG_NR_BOOTMODS + 1]; + +static const char *__initdata efi_loader = "PVH Directboot"; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { @@ -269,20 +272,37 @@ static void __init noreturn efi_arch_post_exit_boot(void) : [cr3] "r" (idle_pg_table), [cs] "i" (__HYPERVISOR_CS), [ds] "r" (__HYPERVISOR_DS), - "D" (&mbi) + "D" (&efi_bi) : "memory" ); unreachable(); } -static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static struct boot_info __init *efi_arch_bootinfo_init(void) { + int i; + + efi_bi.arch = &efi_bi_arch; + efi_bi.mods = efi_mods; + + for ( i=0; i <= CONFIG_NR_BOOTMODS; i++ ) + efi_bi.mods[i].arch = &efi_arch_mods[i]; + + efi_bi_arch.boot_loader_name = _p(efi_loader); + + efi_bi_arch.flags = BOOTINFO_FLAG_X86_MODULES | + BOOTINFO_FLAG_X86_LOADERNAME; + return &efi_bi; } -static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static void __init efi_arch_cfg_file_early( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) +{ +} + +static void __init efi_arch_cfg_file_late( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) { union string name; @@ -294,16 +314,15 @@ static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, name.s = get_value(&cfg, "global", "ucode"); if ( name.s ) { - microcode_set_module(mbi.mods_count); + microcode_set_module(efi_bi.nr_mods); split_string(name.s); read_file(dir_handle, s2w(&name), &ucode, NULL); efi_bs->FreePool(name.w); } } -static void __init efi_arch_handle_cmdline(CHAR16 *image_name, - CHAR16 *cmdline_options, - const char *cfgfile_options) +static void __init efi_arch_handle_cmdline( + CHAR16 *image_name, CHAR16 *cmdline_options, const char *cfgfile_options) { union string name; @@ -311,10 +330,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, { name.w = cmdline_options; w2s(&name); - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); } if ( cfgfile_options ) - place_string(&mbi.cmdline, cfgfile_options); + place_string((uint32_t *)efi_bi.cmdline, cfgfile_options); /* Insert image name last, as it gets prefixed to the other options. */ if ( image_name ) { @@ -323,16 +342,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, } else name.s = "xen"; - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); - if ( mbi.cmdline ) - mbi.flags |= MBI_CMDLINE; - /* - * These must not be initialized statically, since the value must - * not get relocated when processing base relocations later. - */ - mbi.boot_loader_name = (long)"EFI"; - mbi.mods_addr = (long)mb_modules; + if ( efi_bi.cmdline ) + efi_bi_arch.flags |= BOOTINFO_FLAG_X86_CMDLINE; } static void __init efi_arch_edd(void) @@ -695,9 +708,8 @@ static void __init efi_arch_memory_setup(void) #undef l2_4G_offset } -static void __init efi_arch_handle_module(const struct file *file, - const CHAR16 *name, - const char *options) +static void __init efi_arch_handle_module( + const struct file *file, const CHAR16 *name, const char *options) { union string local_name; void *ptr; @@ -715,17 +727,25 @@ static void __init efi_arch_handle_module(const struct file *file, w2s(&local_name); /* - * If options are provided, put them in - * mb_modules[mbi.mods_count].string after the filename, with a space - * separating them. place_string() prepends strings and adds separating - * spaces, so the call order is reversed. + * Set module string to filename and if options are provided, put them in + * after the filename, with a space separating them. */ + strlcpy(efi_bi.mods[efi_bi.nr_mods].string.bytes, local_name.s, + BOOTMOD_MAX_STRING); if ( options ) - place_string(&mb_modules[mbi.mods_count].string, options); - place_string(&mb_modules[mbi.mods_count].string, local_name.s); - mb_modules[mbi.mods_count].mod_start = file->addr >> PAGE_SHIFT; - mb_modules[mbi.mods_count].mod_end = file->size; - ++mbi.mods_count; + { + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, " ", + BOOTMOD_MAX_STRING); + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, options, + BOOTMOD_MAX_STRING); + } + efi_bi.mods[efi_bi.nr_mods].string.kind = BOOTSTR_CMDLINE; + + efi_bi.mods[efi_bi.nr_mods].start = file->addr; + efi_bi.mods[efi_bi.nr_mods].mfn = maddr_to_mfn(file->addr); + efi_bi.mods[efi_bi.nr_mods].size = file->size; + + ++efi_bi.nr_mods; efi_bs->FreePool(ptr); } diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 834b1ad16b..c7081e70d0 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -18,6 +18,7 @@ * * Copyright (c) 2017 Citrix Systems Ltd. */ +#include #include #include #include @@ -31,12 +32,26 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; -static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; +static struct boot_info __initdata pvh_bi; +static struct arch_boot_info __initdata pvh_bi_arch; +static struct boot_module __initdata pvh_mods[CONFIG_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata pvh_arch_mods[CONFIG_NR_BOOTMODS + 1]; static const char *__initdata pvh_loader = "PVH Directboot"; -static void __init convert_pvh_info(multiboot_info_t **mbi, - module_t **mod) +static void __init init_pvh_info(void) +{ + int i; + + pvh_bi.arch = &pvh_bi_arch; + pvh_bi.mods = pvh_mods; + + for ( i=0; i <= CONFIG_NR_BOOTMODS; i++ ) + pvh_bi.mods[i].arch = &pvh_arch_mods[i]; + + pvh_bi.arch->boot_loader_name = _p(pvh_loader); +} + +static void __init convert_pvh_info(struct boot_info *bi) { const struct hvm_start_info *pvh_info = __va(pvh_start_info_pa); const struct hvm_modlist_entry *entry; @@ -50,23 +65,22 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, * required. The extra element is used to aid relocation. See * arch/x86/setup.c:__start_xen(). */ - if ( ARRAY_SIZE(pvh_mbi_mods) <= pvh_info->nr_modules ) + if ( ARRAY_SIZE(bi->mods) <= pvh_info->nr_modules ) panic("The module array is too small, size %zu, requested %u\n", - ARRAY_SIZE(pvh_mbi_mods), pvh_info->nr_modules); + ARRAY_SIZE(pvh_mods), pvh_info->nr_modules); /* * Turn hvm_start_info into mbi. Luckily all modules are placed under 4GB * boundary on x86. */ - pvh_mbi.flags = MBI_CMDLINE | MBI_MODULES | MBI_LOADERNAME; + bi->arch->flags = BOOTINFO_FLAG_X86_CMDLINE | BOOTINFO_FLAG_X86_MODULES + | BOOTINFO_FLAG_X86_LOADERNAME; BUG_ON(pvh_info->cmdline_paddr >> 32); - pvh_mbi.cmdline = pvh_info->cmdline_paddr; - pvh_mbi.boot_loader_name = __pa(pvh_loader); + bi->cmdline = _p(__va(pvh_info->cmdline_paddr)); - BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mbi_mods)); - pvh_mbi.mods_count = pvh_info->nr_modules; - pvh_mbi.mods_addr = __pa(pvh_mbi_mods); + BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mods)); + bi->nr_mods = pvh_info->nr_modules; entry = __va(pvh_info->modlist_paddr); for ( i = 0; i < pvh_info->nr_modules; i++ ) @@ -74,15 +88,20 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, BUG_ON(entry[i].paddr >> 32); BUG_ON(entry[i].cmdline_paddr >> 32); - pvh_mbi_mods[i].mod_start = entry[i].paddr; - pvh_mbi_mods[i].mod_end = entry[i].paddr + entry[i].size; - pvh_mbi_mods[i].string = entry[i].cmdline_paddr; + bi->mods[i].start = entry[i].paddr; + bi->mods[i].size = entry[i].size; + if ( entry[i].cmdline_paddr) + { + char *c = _p(__va(entry[i].cmdline_paddr)); + + safe_strcpy(bi->mods[i].string.bytes, c); + bi->mods[i].string.kind = BOOTSTR_CMDLINE; + } } rsdp_hint = pvh_info->rsdp_paddr; - *mbi = &pvh_mbi; - *mod = pvh_mbi_mods; + *bi = &pvh_bi; } static void __init get_memory_map(void) @@ -99,9 +118,10 @@ static void __init get_memory_map(void) sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); } -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) +void __init pvh_init(struct boot_info **bi) { - convert_pvh_info(mbi, mod); + *bi = init_pvh_info(); + convert_pvh_info(*bi); hypervisor_probe(); ASSERT(xen_guest); diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 48ffd1a0b1..120baf4ebb 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -19,13 +19,13 @@ #ifndef __X86_PVH_BOOT_H__ #define __X86_PVH_BOOT_H__ -#include +#include #ifdef CONFIG_PVH_GUEST extern bool pvh_boot; -void pvh_init(multiboot_info_t **mbi, module_t **mod); +void __init pvh_init(struct boot_info **bi); void pvh_print_info(void); #else @@ -34,7 +34,7 @@ void pvh_print_info(void); #define pvh_boot 0 -static inline void pvh_init(multiboot_info_t **mbi, module_t **mod) +static inline void __init pvh_init(struct boot_info **bi) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index a7bf698d52..e3922f3a30 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -274,47 +273,6 @@ custom_param("acpi", parse_acpi_param); struct boot_info __initdata *boot_info; -static struct boot_info __initdata x86_bi; -static struct arch_boot_info __initdata x86_bi_arch; -static struct boot_module __initdata x86_mods[CONFIG_NR_BOOTMODS + 1]; -static struct arch_bootmodule __initdata x86_arch_mods[CONFIG_NR_BOOTMODS + 1]; - -static void __init mb_to_bootinfo(multiboot_info_t *mbi, module_t *mods) -{ - int i; - - x86_bi.arch = &x86_bi_arch; - x86_bi.mods = x86_mods; - - x86_bi.cmdline = __va(mbi->cmdline); - - /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ - x86_bi_arch.flags = mbi->flags; - x86_bi_arch.mem_upper = mbi->mem_upper; - x86_bi_arch.mem_lower = mbi->mem_lower; - x86_bi_arch.mmap_length = mbi->mmap_length; - x86_bi_arch.mmap_addr = mbi->mmap_addr; - x86_bi_arch.boot_loader_name = __va(mbi->boot_loader_name); - - x86_bi.nr_mods = mbi->mods_count; - for ( i = 0; i <= CONFIG_NR_BOOTMODS; i++) - { - x86_mods[i].arch = &x86_arch_mods[i]; - - if ( i < x86_bi.nr_mods ) - { - bootmodule_update_start(&x86_mods[i], mods[i].mod_start); - x86_mods[i].size = mods[i].mod_end - mods[i].mod_start; - - x86_mods[i].string.len = strlcpy(x86_mods[i].string.bytes, - __va(mods[i].string), - BOOTMOD_MAX_STRING); - } - } - - boot_info = &x86_bi; -} - unsigned long __init initial_images_nrpages(nodeid_t node) { unsigned long node_start = node_start_pfn(node); @@ -897,15 +855,13 @@ static struct domain *__init create_dom0( /* How much of the directmap is prebuilt at compile time. */ #define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) -void __init noreturn __start_xen(unsigned long mbi_p) +void __init noreturn __start_xen(unsigned long bi_p) { char *memmap_type = NULL; char *cmdline, *kextra, *loader; void *bsp_stack; struct cpu_info *info = get_cpu_info(), *bsp_info; unsigned int initrdidx, num_parked = 0; - multiboot_info_t *mbi; - module_t *mod; unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; @@ -942,16 +898,29 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( pvh_boot ) { - ASSERT(mbi_p == 0); - pvh_init(&mbi, &mod); + ASSERT(bi_p == 0); + pvh_init(&boot_info); } else { - mbi = __va(mbi_p); - mod = __va(mbi->mods_addr); - } + /* + * Since addresses were setup before virtual addressing was enabled, + * fixup pointers to virtual addresses for proper dereferencing. + */ + boot_info = __va(bi_p); + boot_info->cmdline = __va(boot_info->cmdline); + boot_info->mods = __va(boot_info->mods); + boot_info->arch = __va(boot_info->arch); + + boot_info->arch->boot_loader_name = + __va(boot_info->arch->boot_loader_name); - mb_to_bootinfo(mbi, mod); + for ( i = 0; i <= boot_info->nr_mods; i++ ) + { + boot_info->mods[i].mfn = maddr_to_mfn(boot_info->mods[i].start); + boot_info->mods[i].arch = __va(boot_info->mods[i].arch); + } + } loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) ? boot_info->arch->boot_loader_name : "unknown"; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..287e48b49a 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -11,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -1222,6 +1222,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_arch_relocate_image(0); + efi_arch_bootinfo_init(); + if ( use_cfg_file ) { EFI_FILE_HANDLE dir_handle; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:51:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338916.563760 (Exim 4.92) (envelope-from ) id 1nvoEj-0003Cp-Cg; Mon, 30 May 2022 22:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338916.563760; Mon, 30 May 2022 22:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvoEj-0003Ci-8a; Mon, 30 May 2022 22:51:45 +0000 Received: by outflank-mailman (input) for mailman id 338916; Mon, 30 May 2022 22:51:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo5z-0006Rh-OJ for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:42:44 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf2a065c-e069-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 00:42:40 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950522594696.5498699912004; Mon, 30 May 2022 15:42:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf2a065c-e069-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653950523; cv=none; d=zohomail.com; s=zohoarc; b=E/BunImJSl5fmbZFKPm/Ab/bh32c/HTZgu/DUPvDGyj8BuYI1UixOyD+xZU4QJG7pwaOlahwe8ygDuZ7YCAKx3SBmWDF/hGp7HlsXEijJLLqZB2pS6eYkYC/dRu+VtntrJ/T/uUGMkFuCsaXhhmdPr5co+GKzWRVDoqJmF019DQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950523; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=uWZhwVvs+kMg/Fm6P9a8fRK9wIT+9jMYCWMw8CQL0M0=; b=WY0BN37i/RORGEsWjkDLf/NXj1bBVO3XMCXJQooB5fsW042MivY0NeCCQWQyLjqE+5xlAowwaYyUF3wHVsYkEcoMPtTJeZV12yCdL76v+pXUGP6Az0rhj1aOkuLKv5/yYpRjpqvzvhjMz+nuR9mJzUqTyJyjpkDluD3iSCZNMm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950523; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=uWZhwVvs+kMg/Fm6P9a8fRK9wIT+9jMYCWMw8CQL0M0=; b=ofEpTkpvhNVYeIsq+XbWq3MdAgEmCBDxWQKQ4LUJXeT77AlcohC3IUyHp101QkLG smIia3M07LZ2eE+eWTTTRGOfUNwH8s3bDCTu6oFE8cda0mylemWHMbE40DI1qO9ER8W tmybM0RDqtYn/gwjT9NoRGHdUquJorKZs9114v1w= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Daniel De Graaf Subject: [RFC PATCH 3/4] x86: adopt new boot info structures Date: Mon, 30 May 2022 22:41:25 -0400 Message-Id: <20220531024127.23669-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531024127.23669-1-dpsmith@apertussolutions.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit replaces the use of the multiboot v1 structures starting at __start_xen(). The majority of this commit is converting the fields being accessed for the startup calculations. While adapting the ucode boot module location logic, this code was refactored to reduce some of the unnecessary complexity. Signed-off-by: Daniel P. Smith --- xen/arch/x86/bzimage.c | 16 +- xen/arch/x86/cpu/microcode/core.c | 134 ++++++++------ xen/arch/x86/dom0_build.c | 13 +- xen/arch/x86/hvm/dom0_build.c | 42 ++--- xen/arch/x86/include/asm/bzimage.h | 5 +- xen/arch/x86/include/asm/dom0_build.h | 15 +- xen/arch/x86/include/asm/setup.h | 14 +- xen/arch/x86/pv/dom0_build.c | 34 ++-- xen/arch/x86/setup.c | 249 +++++++++++++++----------- xen/include/xen/bootinfo.h | 47 +++++ xen/include/xsm/xsm.h | 26 ++- xen/xsm/xsm_core.c | 22 ++- xen/xsm/xsm_policy.c | 44 ++--- 13 files changed, 391 insertions(+), 270 deletions(-) diff --git a/xen/arch/x86/bzimage.c b/xen/arch/x86/bzimage.c index ac4fd428be..c742a04687 100644 --- a/xen/arch/x86/bzimage.c +++ b/xen/arch/x86/bzimage.c @@ -69,10 +69,8 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) return 1; } -static unsigned long __initdata orig_image_len; - -unsigned long __init bzimage_headroom(void *image_start, - unsigned long image_length) +unsigned long __init bzimage_headroom( + void *image_start, unsigned long image_length) { struct setup_header *hdr = (struct setup_header *)image_start; int err; @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, if ( elf_is_elfbinary(image_start, image_length) ) return 0; - orig_image_len = image_length; headroom = output_length(image_start, image_length); if (gzip_check(image_start, image_length)) { @@ -104,12 +101,15 @@ unsigned long __init bzimage_headroom(void *image_start, return headroom; } -int __init bzimage_parse(void *image_base, void **image_start, - unsigned long *image_len) +int __init bzimage_parse( + void *image_base, void **image_start, unsigned int headroom, + unsigned long *image_len) { struct setup_header *hdr = (struct setup_header *)(*image_start); int err = bzimage_check(hdr, *image_len); - unsigned long output_len; + unsigned long output_len, orig_image_len; + + orig_image_len = *image_len - headroom; if ( err < 0 ) return err; diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 452a7ca773..f773eb89e8 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -22,6 +22,7 @@ */ #include +#include #include #include #include @@ -32,6 +33,7 @@ #include #include + #include #include #include @@ -54,7 +56,6 @@ */ #define MICROCODE_UPDATE_TIMEOUT_US 1000000 -static module_t __initdata ucode_mod; static signed int __initdata ucode_mod_idx; static bool_t __initdata ucode_mod_forced; static unsigned int nr_cores; @@ -147,74 +148,113 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +#define MICROCODE_MODULE_MATCH 1 +#define MICROCODE_MODULE_NONMATCH 0 + +static int __init microcode_check_module(struct boot_module *mod) { - module_t *mod = (module_t *)__va(mbi->mods_addr); uint64_t *_blob_start; unsigned long _blob_size; - struct cpio_data cd; + struct cpio_data cd = { NULL, 0 }; long offset; const char *p = NULL; - int i; - - ucode_blob.size = 0; - if ( !ucode_scan ) - return; if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) p = "kernel/x86/microcode/AuthenticAMD.bin"; else if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) p = "kernel/x86/microcode/GenuineIntel.bin"; else + return -EFAULT; + + _blob_start = bootstrap_map(mod); + _blob_size = mod->size; + if ( !_blob_start ) + { + printk("Could not map multiboot module (0x%lx) (size: %ld)\n", + mod->start, _blob_size); + /* Non-fatal error, so just say no match */ + return MICROCODE_MODULE_NONMATCH; + } + + cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); + + if ( cd.data ) + { + ucode_blob.size = cd.size; + ucode_blob.data = cd.data; + + mod->kind = BOOTMOD_UCODE; + return MICROCODE_MODULE_MATCH; + } + + bootstrap_map(NULL); + + return 0; +} + +void __init microcode_scan_module(struct boot_info *bi) +{ + int idx = 0; + + if ( !ucode_scan ) return; /* - * Try all modules and see whichever could be the microcode blob. + * Try unidentified modules and see which could be the microcode blob. */ - for ( i = 1 /* Ignore dom0 kernel */; i < mbi->mods_count; i++ ) + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, idx); + while ( idx < bi->nr_mods ) { - if ( !test_bit(i, module_map) ) - continue; + int ret; - _blob_start = bootstrap_map(&mod[i]); - _blob_size = mod[i].mod_end; - if ( !_blob_start ) + ret = microcode_check_module(&bi->mods[idx]); + switch ( ret ) { - printk("Could not map multiboot module #%d (size: %ld)\n", - i, _blob_size); + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, ++idx); continue; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; } - cd.data = NULL; - cd.size = 0; - cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); - if ( cd.data ) - { - ucode_blob.size = cd.size; - ucode_blob.data = cd.data; - break; - } - bootstrap_map(NULL); } } -void __init microcode_grab_module( - unsigned long *module_map, - const multiboot_info_t *mbi) + +void __init microcode_grab_module(struct boot_info *bi) { - module_t *mod = (module_t *)__va(mbi->mods_addr); + ucode_blob.size = 0; if ( ucode_mod_idx < 0 ) - ucode_mod_idx += mbi->mods_count; - if ( ucode_mod_idx <= 0 || ucode_mod_idx >= mbi->mods_count || - !__test_and_clear_bit(ucode_mod_idx, module_map) ) - goto scan; - ucode_mod = mod[ucode_mod_idx]; -scan: + ucode_mod_idx += bi->nr_mods; + if ( ucode_mod_idx >= 0 && ucode_mod_idx <= bi->nr_mods && + bi->mods[ucode_mod_idx].kind == BOOTMOD_UNKNOWN ) + { + int ret = microcode_check_module(&bi->mods[ucode_mod_idx]); + + switch ( ret ) + { + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + break; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; + } + } + if ( ucode_scan ) - microcode_scan_module(module_map, mbi); + microcode_scan_module(bi); } +/* Undefining as they are not needed anymore */ +#undef MICROCODE_MODULE_MATCH +#undef MICROCODE_MODULE_NONMATCH + static struct microcode_ops __ro_after_init ucode_ops; static DEFINE_SPINLOCK(microcode_mutex); @@ -711,11 +751,6 @@ static int __init cf_check microcode_init(void) ucode_blob.size = 0; ucode_blob.data = NULL; } - else if ( ucode_mod.mod_end ) - { - bootstrap_map(NULL); - ucode_mod.mod_end = 0; - } return 0; } @@ -745,11 +780,6 @@ static int __init early_microcode_update_cpu(void) len = ucode_blob.size; data = ucode_blob.data; } - else if ( ucode_mod.mod_end ) - { - len = ucode_mod.mod_end; - data = bootstrap_map(&ucode_mod); - } if ( !data ) return -ENOMEM; @@ -799,7 +829,7 @@ int __init early_microcode_init(void) alternative_vcall(ucode_ops.collect_cpu_info); - if ( ucode_mod.mod_end || ucode_blob.size ) + if ( ucode_blob.size ) rc = early_microcode_update_cpu(); return rc; diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 79234f18ff..5a27e50e32 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -1,9 +1,10 @@ /****************************************************************************** * dom0_build.c - * + * * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -574,9 +575,9 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0(struct domain *d, const module_t *image, - unsigned long image_headroom, module_t *initrd, - char *cmdline) +int __init construct_dom0( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int rc; @@ -588,9 +589,9 @@ int __init construct_dom0(struct domain *d, const module_t *image, process_pending_softirqs(); if ( is_hvm_domain(d) ) - rc = dom0_construct_pvh(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pvh(d, image, initrd, cmdline); else if ( is_pv_domain(d) ) - rc = dom0_construct_pv(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pv(d, image, initrd, cmdline); else panic("Cannot construct Dom0. No guest interface available\n"); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 1864d048a1..4e903a848d 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -19,9 +19,9 @@ */ #include +#include #include #include -#include #include #include @@ -543,14 +543,13 @@ static paddr_t __init find_memory( return INVALID_PADDR; } -static int __init pvh_load_kernel(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, void *image_base, - char *cmdline, paddr_t *entry, - paddr_t *start_info_addr) +static int __init pvh_load_kernel( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, void *image_base, char *cmdline, + paddr_t *entry, paddr_t *start_info_addr) { - void *image_start = image_base + image_headroom; - unsigned long image_len = image->mod_end; + void *image_start = image_base + image->arch->headroom; + unsigned long image_len = image->size; struct elf_binary elf; struct elf_dom_parms parms; paddr_t last_addr; @@ -559,7 +558,9 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = + bzimage_parse(image_base, &image_start, image->arch->headroom, + &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); return rc; @@ -606,7 +607,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, * simplify it. */ last_addr = find_memory(d, &elf, sizeof(start_info) + - (initrd ? ROUNDUP(initrd->mod_end, PAGE_SIZE) + + (initrd ? ROUNDUP(initrd->size, PAGE_SIZE) + sizeof(mod) : 0) + (cmdline ? ROUNDUP(strlen(cmdline) + 1, @@ -620,8 +621,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, if ( initrd != NULL ) { - rc = hvm_copy_to_guest_phys(last_addr, mfn_to_virt(initrd->mod_start), - initrd->mod_end, v); + rc = hvm_copy_to_guest_phys(last_addr, maddr_to_virt(initrd->start), + initrd->size, v); if ( rc ) { printk("Unable to copy initrd to guest\n"); @@ -629,11 +630,11 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, } mod.paddr = last_addr; - mod.size = initrd->mod_end; - last_addr += ROUNDUP(initrd->mod_end, elf_64bit(&elf) ? 8 : 4); - if ( initrd->string ) + mod.size = initrd->size; + last_addr += ROUNDUP(initrd->size, elf_64bit(&elf) ? 8 : 4); + if ( initrd->string.kind == BOOTSTR_CMDLINE ) { - char *str = __va(initrd->string); + char *str = initrd->string.bytes; size_t len = strlen(str) + 1; rc = hvm_copy_to_guest_phys(last_addr, str, len, v); @@ -1216,10 +1217,9 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain *d) } } -int __init dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { paddr_t entry, start_info; int rc; @@ -1249,7 +1249,7 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, bootstrap_map(image), + rc = pvh_load_kernel(d, image, initrd, bootstrap_map(image), cmdline, &entry, &start_info); if ( rc ) { diff --git a/xen/arch/x86/include/asm/bzimage.h b/xen/arch/x86/include/asm/bzimage.h index 7ed69d3910..5a5a25b4d7 100644 --- a/xen/arch/x86/include/asm/bzimage.h +++ b/xen/arch/x86/include/asm/bzimage.h @@ -5,7 +5,8 @@ unsigned long bzimage_headroom(void *image_start, unsigned long image_length); -int bzimage_parse(void *image_base, void **image_start, - unsigned long *image_len); +int bzimage_parse( + void *image_base, void **image_start, unsigned int headroom, + unsigned long *image_len); #endif /* __X86_BZIMAGE_H__ */ diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index a5f8c9e67f..ad33413710 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -1,6 +1,7 @@ #ifndef _DOM0_BUILD_H_ #define _DOM0_BUILD_H_ +#include #include #include @@ -13,15 +14,13 @@ unsigned long dom0_compute_nr_pages(struct domain *d, unsigned long initrd_len); int dom0_setup_permissions(struct domain *d); -int dom0_construct_pv(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int __init dom0_construct_pv( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); -int dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..11bdfc5723 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -1,7 +1,8 @@ #ifndef __X86_SETUP_H_ #define __X86_SETUP_H_ -#include +#include + #include extern const char __2M_text_start[], __2M_text_end[]; @@ -33,20 +34,17 @@ static inline void vesa_init(void) {}; #endif int construct_dom0( - struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, - module_t *initrd, - char *cmdline); + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); void discard_initial_images(void); -void *bootstrap_map(const module_t *mod); +void *bootstrap_map(const struct boot_module *mod); int xen_in_range(unsigned long mfn); -void microcode_grab_module( - unsigned long *, const multiboot_info_t *); +void __init microcode_grab_module(struct boot_info *bi); extern uint8_t kbd_shift_flags; diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index e501979a86..f6131147ef 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -294,11 +295,9 @@ static struct page_info * __init alloc_chunk(struct domain *d, return page; } -int __init dom0_construct_pv(struct domain *d, - const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pv( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int i, rc, order, machine; bool compatible, compat; @@ -314,9 +313,9 @@ int __init dom0_construct_pv(struct domain *d, start_info_t *si; struct vcpu *v = d->vcpu[0]; void *image_base = bootstrap_map(image); - unsigned long image_len = image->mod_end; - void *image_start = image_base + image_headroom; - unsigned long initrd_len = initrd ? initrd->mod_end : 0; + unsigned long image_len = image->size; + void *image_start = image_base + image->arch->headroom; + unsigned long initrd_len = initrd ? initrd->size : 0; l4_pgentry_t *l4tab = NULL, *l4start = NULL; l3_pgentry_t *l3tab = NULL, *l3start = NULL; l2_pgentry_t *l2tab = NULL, *l2start = NULL; @@ -355,7 +354,9 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = + bzimage_parse(image_base, &image_start, image->arch->headroom, + &image_len)) != 0 ) return rc; if ( (rc = elf_init(&elf, image_start, image_len)) != 0 ) @@ -544,7 +545,7 @@ int __init dom0_construct_pv(struct domain *d, initrd_pfn = vinitrd_start ? (vinitrd_start - v_start) >> PAGE_SHIFT : domain_tot_pages(d); - initrd_mfn = mfn = initrd->mod_start; + initrd_mfn = mfn = mfn_x(initrd->mfn); count = PFN_UP(initrd_len); if ( d->arch.physaddr_bitsize && ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) @@ -559,12 +560,13 @@ int __init dom0_construct_pv(struct domain *d, free_domheap_pages(page, order); page += 1UL << order; } - memcpy(page_to_virt(page), mfn_to_virt(initrd->mod_start), + memcpy(page_to_virt(page), maddr_to_virt(initrd->start), initrd_len); - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; init_domheap_pages(mpt_alloc, mpt_alloc + PAGE_ALIGN(initrd_len)); - initrd->mod_start = initrd_mfn = mfn_x(page_to_mfn(page)); + bootmodule_update_mfn(initrd, page_to_mfn(page)); + initrd_mfn = mfn_x(initrd->mfn); } else { @@ -572,7 +574,7 @@ int __init dom0_construct_pv(struct domain *d, if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) BUG(); } - initrd->mod_end = 0; + initrd->size = 0; } printk("PHYSICAL MEMORY ARRANGEMENT:\n" @@ -583,7 +585,7 @@ int __init dom0_construct_pv(struct domain *d, nr_pages - domain_tot_pages(d)); if ( initrd ) { - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr, mpt_alloc, mpt_alloc + initrd_len); } @@ -804,7 +806,7 @@ int __init dom0_construct_pv(struct domain *d, if ( pfn >= initrd_pfn ) { if ( pfn < initrd_pfn + PFN_UP(initrd_len) ) - mfn = initrd->mod_start + (pfn - initrd_pfn); + mfn = mfn_x(initrd->mfn) + (pfn - initrd_pfn); else mfn -= PFN_UP(initrd_len); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 3f5e602e00..a7bf698d52 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -271,8 +272,48 @@ static int __init cf_check parse_acpi_param(const char *s) } custom_param("acpi", parse_acpi_param); -static const module_t *__initdata initial_images; -static unsigned int __initdata nr_initial_images; +struct boot_info __initdata *boot_info; + +static struct boot_info __initdata x86_bi; +static struct arch_boot_info __initdata x86_bi_arch; +static struct boot_module __initdata x86_mods[CONFIG_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata x86_arch_mods[CONFIG_NR_BOOTMODS + 1]; + +static void __init mb_to_bootinfo(multiboot_info_t *mbi, module_t *mods) +{ + int i; + + x86_bi.arch = &x86_bi_arch; + x86_bi.mods = x86_mods; + + x86_bi.cmdline = __va(mbi->cmdline); + + /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ + x86_bi_arch.flags = mbi->flags; + x86_bi_arch.mem_upper = mbi->mem_upper; + x86_bi_arch.mem_lower = mbi->mem_lower; + x86_bi_arch.mmap_length = mbi->mmap_length; + x86_bi_arch.mmap_addr = mbi->mmap_addr; + x86_bi_arch.boot_loader_name = __va(mbi->boot_loader_name); + + x86_bi.nr_mods = mbi->mods_count; + for ( i = 0; i <= CONFIG_NR_BOOTMODS; i++) + { + x86_mods[i].arch = &x86_arch_mods[i]; + + if ( i < x86_bi.nr_mods ) + { + bootmodule_update_start(&x86_mods[i], mods[i].mod_start); + x86_mods[i].size = mods[i].mod_end - mods[i].mod_start; + + x86_mods[i].string.len = strlcpy(x86_mods[i].string.bytes, + __va(mods[i].string), + BOOTMOD_MAX_STRING); + } + } + + boot_info = &x86_bi; +} unsigned long __init initial_images_nrpages(nodeid_t node) { @@ -281,10 +322,10 @@ unsigned long __init initial_images_nrpages(nodeid_t node) unsigned long nr; unsigned int i; - for ( nr = i = 0; i < nr_initial_images; ++i ) + for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { - unsigned long start = initial_images[i].mod_start; - unsigned long end = start + PFN_UP(initial_images[i].mod_end); + unsigned long start = mfn_x(boot_info->mods[i].mfn); + unsigned long end = start + PFN_UP(boot_info->mods[i].size); if ( end > node_start && node_end > start ) nr += min(node_end, end) - max(node_start, start); @@ -297,16 +338,15 @@ void __init discard_initial_images(void) { unsigned int i; - for ( i = 0; i < nr_initial_images; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; + uint64_t start = (uint64_t)boot_info->mods[i].start; init_domheap_pages(start, - start + PAGE_ALIGN(initial_images[i].mod_end)); + start + PAGE_ALIGN(boot_info->mods[i].size)); } - nr_initial_images = 0; - initial_images = NULL; + boot_info->nr_mods = 0; } extern char __init_begin[], __init_end[], __bss_start[], __bss_end[]; @@ -393,14 +433,14 @@ static void __init normalise_cpu_order(void) * Ensure a given physical memory range is present in the bootstrap mappings. * Use superpage mappings to ensure that pagetable memory needn't be allocated. */ -void *__init bootstrap_map(const module_t *mod) +void *__init bootstrap_map(const struct boot_module *mod) { static unsigned long __initdata map_cur = BOOTSTRAP_MAP_BASE; uint64_t start, end, mask = (1L << L2_PAGETABLE_SHIFT) - 1; void *ret; if ( system_state != SYS_STATE_early_boot ) - return mod ? mfn_to_virt(mod->mod_start) : NULL; + return mod ? maddr_to_virt(mod->start) : NULL; if ( !mod ) { @@ -409,8 +449,8 @@ void *__init bootstrap_map(const module_t *mod) return NULL; } - start = (uint64_t)mod->mod_start << PAGE_SHIFT; - end = start + mod->mod_end; + start = (uint64_t)mod->start; + end = start + mod->size; if ( start >= end ) return NULL; @@ -437,25 +477,25 @@ static void *__init move_memory( while ( size ) { - module_t mod; + struct boot_module mod; unsigned int soffs = src & mask; unsigned int doffs = dst & mask; unsigned int sz; void *d, *s; - mod.mod_start = (src - soffs) >> PAGE_SHIFT; - mod.mod_end = soffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - sz = mod.mod_end - soffs; + mod.start = src - soffs; + mod.size = soffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + sz = mod.size - soffs; s = bootstrap_map(&mod); - mod.mod_start = (dst - doffs) >> PAGE_SHIFT; - mod.mod_end = doffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - if ( sz > mod.mod_end - doffs ) - sz = mod.mod_end - doffs; + mod.start = dst - doffs; + mod.size = doffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + if ( sz > mod.size - doffs ) + sz = mod.size - doffs; d = bootstrap_map(&mod); memmove(d + doffs, s + soffs, sz); @@ -476,7 +516,7 @@ static void *__init move_memory( #undef BOOTSTRAP_MAP_LIMIT static uint64_t __init consider_modules( - uint64_t s, uint64_t e, uint32_t size, const module_t *mod, + uint64_t s, uint64_t e, uint32_t size, const struct boot_module *mod, unsigned int nr_mods, unsigned int this_mod) { unsigned int i; @@ -486,8 +526,8 @@ static uint64_t __init consider_modules( for ( i = 0; i < nr_mods ; ++i ) { - uint64_t start = (uint64_t)mod[i].mod_start << PAGE_SHIFT; - uint64_t end = start + PAGE_ALIGN(mod[i].mod_end); + uint64_t start = (uint64_t)mod[i].start; + uint64_t end = start + PAGE_ALIGN(mod[i].size); if ( i == this_mod ) continue; @@ -753,10 +793,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0(const module_t *image, - unsigned long headroom, - module_t *initrd, const char *kextra, - const char *loader) +static struct domain *__init create_dom0( + const struct boot_info *bi, const char *kextra, const char *loader) { struct xen_domctl_createdomain dom0_cfg = { .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, @@ -769,9 +807,14 @@ static struct domain *__init create_dom0(const module_t *image, .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, }; + struct boot_module *image = bootmodule_next_by_kind(bi, BOOTMOD_KERNEL, 0); + struct boot_module *initrd = bootmodule_next_by_kind(bi, BOOTMOD_RAMDISK, 0); struct domain *d; char *cmdline; - domid_t domid; + domid_t domid = 0; + + if ( image == NULL ) + panic("Error creating d%uv0\n", domid); if ( opt_dom0_pvh ) { @@ -798,7 +841,8 @@ static struct domain *__init create_dom0(const module_t *image, panic("Error creating d%uv0\n", domid); /* Grab the DOM0 command line. */ - cmdline = image->string ? __va(image->string) : NULL; + cmdline = (image->string.kind == BOOTSTR_CMDLINE) ? + image->string.bytes : NULL; if ( cmdline || kextra ) { static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; @@ -838,7 +882,7 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, headroom, initrd, cmdline) != 0 ) + if ( construct_dom0(d, image, initrd, cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -862,7 +906,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, modules_headroom, module_map[1]; + unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -907,12 +951,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } - loader = (mbi->flags & MBI_LOADERNAME) - ? (char *)__va(mbi->boot_loader_name) : "unknown"; + mb_to_bootinfo(mbi, mod); + + loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) + ? boot_info->arch->boot_loader_name : "unknown"; /* Parse the command-line options. */ - cmdline = cmdline_cook((mbi->flags & MBI_CMDLINE) ? - __va(mbi->cmdline) : NULL, + cmdline = cmdline_cook((boot_info->arch->flags & BOOTINFO_FLAG_X86_CMDLINE) ? + boot_info->cmdline : NULL, loader); if ( (kextra = strstr(cmdline, " -- ")) != NULL ) { @@ -1013,19 +1059,22 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (mbi->mods_count == 0) ) + if ( !(boot_info->arch->flags & BOOTINFO_FLAG_X86_MODULES) || + (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) + if ( boot_info->nr_mods > CONFIG_NR_BOOTMODS ) { - mbi->mods_count = CONFIG_NR_BOOTMODS; + boot_info->nr_mods = CONFIG_NR_BOOTMODS ; printk("Excessive multiboot modules - using the first %u only\n", - mbi->mods_count); + boot_info->nr_mods); } - bitmap_fill(module_map, mbi->mods_count); - __clear_bit(0, module_map); /* Dom0 kernel is always first */ + /* Dom0 kernel is the first boot module */ + boot_info->mods[0].kind = BOOTMOD_KERNEL; + if ( boot_info->mods[0].string.len ) + boot_info->mods[0].string.kind = BOOTSTR_CMDLINE; if ( pvh_boot ) { @@ -1049,19 +1098,19 @@ void __init noreturn __start_xen(unsigned long mbi_p) } else if ( efi_enabled(EFI_BOOT) ) memmap_type = "EFI"; - else if ( (e820_raw.nr_map = + else if ( (e820_raw.nr_map = copy_bios_e820(e820_raw.map, ARRAY_SIZE(e820_raw.map))) != 0 ) { memmap_type = "Xen-e820"; } - else if ( mbi->flags & MBI_MEMMAP ) + else if ( boot_info->arch->flags & BOOTINFO_FLAG_X86_MEMMAP ) { memmap_type = "Multiboot-e820"; - while ( bytes < mbi->mmap_length && + while ( bytes < boot_info->arch->mmap_length && e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) ) { - memory_map_t *map = __va(mbi->mmap_addr + bytes); + struct mb_memmap *map = __va(boot_info->arch->mmap_addr + bytes); /* * This is a gross workaround for a BIOS bug. Some bootloaders do @@ -1162,17 +1211,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); kexec_reserve_area(&boot_e820); - initial_images = mod; - nr_initial_images = mbi->mods_count; - - for ( i = 0; !efi_enabled(EFI_LOADER) && i < mbi->mods_count; i++ ) - { - if ( mod[i].mod_start & (PAGE_SIZE - 1) ) + for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) + if ( boot_info->mods[i].start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); - mod[i].mod_end -= mod[i].mod_start; - mod[i].mod_start >>= PAGE_SHIFT; - mod[i].reserved = 0; - } if ( xen_phys_start ) { @@ -1183,11 +1224,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[mbi->mods_count].mod_start = virt_to_mfn(_stext); - mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext; + bootmodule_update_start(&boot_info->mods[boot_info->nr_mods], + virt_to_maddr(_stext)); + boot_info->mods[boot_info->nr_mods].size = __2M_rwdata_end - _stext; } - modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); + boot_info->mods[0].arch->headroom = bzimage_headroom( + bootstrap_map(&boot_info->mods[0]), + boot_info->mods[0].size); bootstrap_map(NULL); #ifndef highmem_start @@ -1244,7 +1288,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, mbi->mods_count, -1); + boot_info->mods, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1348,31 +1392,32 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Is the region suitable for relocating the multiboot modules? */ - for ( j = mbi->mods_count - 1; j >= 0; j-- ) + for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - unsigned long headroom = j ? 0 : modules_headroom; - unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); + struct boot_module *mod = boot_info->mods; + unsigned long headroom = mod[j].arch->headroom; + unsigned long size = PAGE_ALIGN(headroom + mod[j].size); - if ( mod[j].reserved ) + if ( mod[j].arch->flags & BOOTMOD_FLAG_X86_RELOCATED ) continue; /* Don't overlap with other modules (or Xen itself). */ end = consider_modules(s, e, size, mod, - mbi->mods_count + relocated, j); + boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) continue; if ( s < end && (headroom || - ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) ) + ((end - size) >> PAGE_SHIFT) > mfn_x(mod[j].mfn)) ) { move_memory(end - size + headroom, - (uint64_t)mod[j].mod_start << PAGE_SHIFT, - mod[j].mod_end, 0); - mod[j].mod_start = (end - size) >> PAGE_SHIFT; - mod[j].mod_end += headroom; - mod[j].reserved = 1; + (uint64_t)mod[j].start, + mod[j].size, 0); + bootmodule_update_start(&mod[j], end - size); + mod[j].size += headroom; + mod[j].arch->flags |= BOOTMOD_FLAG_X86_RELOCATED; } } @@ -1384,8 +1429,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) while ( !kexec_crash_area.start ) { /* Don't overlap with modules (or Xen itself). */ - e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, - mbi->mods_count + relocated, -1); + e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), + boot_info->mods, + boot_info->nr_mods + relocated, -1); if ( s >= e ) break; if ( e > kexec_crash_area_limit ) @@ -1398,13 +1444,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( modules_headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && + !(boot_info->mods[0].arch->flags & BOOTMOD_FLAG_X86_RELOCATED) ) panic("Not enough memory to relocate the dom0 kernel image\n"); - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; + uint64_t s = (uint64_t)boot_info->mods[i].start; - reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(mod[i].mod_end)); + reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(boot_info->mods[i].size)); } if ( !xen_phys_start ) @@ -1469,10 +1516,10 @@ void __init noreturn __start_xen(unsigned long mbi_p) ASSERT(j); } map_e = boot_e820.map[j].addr + boot_e820.map[j].size; - for ( j = 0; j < mbi->mods_count; ++j ) + for ( j = 0; j < boot_info->nr_mods; ++j ) { - uint64_t end = pfn_to_paddr(mod[j].mod_start) + - mod[j].mod_end; + uint64_t end = mfn_to_maddr(boot_info->mods[j].mfn) + + boot_info->mods[j].size; if ( map_e < end ) map_e = end; @@ -1545,13 +1592,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) } } - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - set_pdx_range(mod[i].mod_start, - mod[i].mod_start + PFN_UP(mod[i].mod_end)); - map_pages_to_xen((unsigned long)mfn_to_virt(mod[i].mod_start), - _mfn(mod[i].mod_start), - PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR); + set_pdx_range(mfn_x(boot_info->mods[i].mfn), + mfn_x(boot_info->mods[i].mfn) + + PFN_UP(boot_info->mods[i].size)); + map_pages_to_xen((unsigned long)maddr_to_virt(boot_info->mods[i].start), + boot_info->mods[i].mfn, + PFN_UP(boot_info->mods[i].size), PAGE_HYPERVISOR); } #ifdef CONFIG_KEXEC @@ -1561,7 +1609,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned long e = min(s + PFN_UP(kexec_crash_area.size), PFN_UP(__pa(HYPERVISOR_VIRT_END - 1))); - if ( e > s ) + if ( e > s ) map_pages_to_xen((unsigned long)__va(kexec_crash_area.start), _mfn(s), e - s, PAGE_HYPERVISOR); } @@ -1701,7 +1749,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - if ( xsm_multiboot_init(module_map, mbi) ) + if ( xsm_bootmodule_init(boot_info) ) warning_add("WARNING: XSM failed to initialize.\n" "This has implications on the security of the system,\n" "as uncontrolled communications between trusted and\n" @@ -1774,7 +1822,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) init_IRQ(); - microcode_grab_module(module_map, mbi); + microcode_grab_module(boot_info); timer_init(); @@ -1906,7 +1954,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) do_initcalls(); - if ( opt_watchdog ) + if ( opt_watchdog ) watchdog_setup(); if ( !tboot_protect_mem_regions() ) @@ -1922,8 +1970,11 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, mbi->mods_count); - if ( bitmap_weight(module_map, mbi->mods_count) > 1 ) + initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); + if ( initrdidx < boot_info->nr_mods ) + boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; + + if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -1932,9 +1983,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, modules_headroom, - initrdidx < mbi->mods_count ? mod + initrdidx : NULL, - kextra, loader); + dom0 = create_dom0(boot_info, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 42b53a3ca6..dde8202f62 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -51,4 +51,51 @@ struct __packed boot_info { struct arch_boot_info *arch; }; +extern struct boot_info *boot_info; + +static inline unsigned long bootmodule_next_idx_by_kind( + const struct boot_info *bi, bootmodule_kind kind, unsigned long start) +{ + for ( ; start < bi->nr_mods; start++ ) + if ( bi->mods[start].kind == kind ) + return start; + + return bi->nr_mods + 1; +} + +static inline unsigned long bootmodule_count_by_kind( + const struct boot_info *bi, bootmodule_kind kind) +{ + unsigned long count = 0; + int i; + + for ( i=0; i < bi->nr_mods; i++ ) + if ( bi->mods[i].kind == kind ) + count++; + + return count; +} + +static inline struct boot_module *bootmodule_next_by_kind( + const struct boot_info *bi, bootmodule_kind kind, unsigned long start) +{ + for ( ; start < bi->nr_mods; start++ ) + if ( bi->mods[start].kind == kind ) + return &bi->mods[start]; + + return NULL; +} + +static inline void bootmodule_update_start(struct boot_module *b, paddr_t new_start) +{ + b->start = new_start; + b->mfn = maddr_to_mfn(new_start); +} + +static inline void bootmodule_update_mfn(struct boot_module *b, mfn_t new_mfn) +{ + b->mfn = new_mfn; + b->start = mfn_to_maddr(new_mfn); +} + #endif diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 1676c261c9..bd72c2220e 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -16,8 +16,8 @@ #define __XSM_H__ #include +#include #include -#include /* policy magic number (defined by XSM_MAGIC) */ typedef uint32_t xsm_magic_t; @@ -770,15 +770,14 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* XSM_NO_WRAPPERS */ -#ifdef CONFIG_MULTIBOOT -int xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi); -int xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - const unsigned char *policy_buffer[], size_t *policy_size); -#endif +#ifndef CONFIG_HAS_DEVICE_TREE +int xsm_bootmodule_init(const struct boot_info *bi); +int xsm_bootmodule_policy_init( + const struct boot_info *bi, const unsigned char *policy_buffer[], + size_t *policy_size); + +#else -#ifdef CONFIG_HAS_DEVICE_TREE /* * Initialize XSM * @@ -820,15 +819,14 @@ static const inline struct xsm_ops *silo_init(void) #include -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init ( - unsigned long *module_map, const multiboot_info_t *mbi) +#ifndef CONFIG_HAS_DEVICE_TREE +static inline int xsm_bootmodule_init(const struct boot_info *bi) { return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + static inline int xsm_dt_init(void) { return 0; diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 6377895e1e..f9066738b5 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,6 +10,7 @@ * as published by the Free Software Foundation. */ +#include #include #include #include @@ -136,9 +137,13 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) return 0; } -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi) +/* + * ifdef'ing this against multiboot is no longer valid as the boot module + * is agnostic and it will be possible to dropped the ifndef should Arm + * adopt boot info + */ +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_init(const struct boot_info *bi) { int ret = 0; const unsigned char *policy_buffer; @@ -148,8 +153,7 @@ int __init xsm_multiboot_init( if ( policy_file_required && XSM_MAGIC ) { - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, - &policy_size); + ret = xsm_bootmodule_policy_init(bi, &policy_buffer, &policy_size); if ( ret ) { bootstrap_map(NULL); @@ -162,9 +166,9 @@ int __init xsm_multiboot_init( return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_init(void) { int ret = 0; @@ -215,9 +219,9 @@ bool __init has_xsm_magic(paddr_t start) return false; } -#endif +#endif /* CONFIG_HAS_DEVICE_TREE */ -#endif +#endif /* CONFIG_XSM */ long cf_check do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 6a4f769aec..45ce013ead 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -18,24 +18,22 @@ * */ -#include -#ifdef CONFIG_MULTIBOOT -#include -#include -#endif #include +#include +#include + #ifdef CONFIG_HAS_DEVICE_TREE -# include # include #endif -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - const unsigned char *policy_buffer[], size_t *policy_size) +# include + +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_policy_init( + const struct boot_info *bi, const unsigned char *policy_buffer[], + size_t *policy_size) { - int i; - module_t *mod = (module_t *)__va(mbi->mods_addr); + unsigned long idx = 0; int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; @@ -47,17 +45,11 @@ int __init xsm_multiboot_policy_init( rc = 0; #endif - /* - * Try all modules and see whichever could be the binary policy. - * Adjust module_map for the module that is the binary policy. - */ - for ( i = mbi->mods_count-1; i >= 1; i-- ) + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, idx); + while ( idx < bi->nr_mods ) { - if ( !test_bit(i, module_map) ) - continue; - - _policy_start = bootstrap_map(mod + i); - _policy_len = mod[i].mod_end; + _policy_start = bootstrap_map(&bi->mods[idx]); + _policy_len = bi->mods[idx].size; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { @@ -67,13 +59,13 @@ int __init xsm_multiboot_policy_init( printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); - __clear_bit(i, module_map); + bi->mods[idx].kind = BOOTMOD_XSM; rc = 0; break; - } bootstrap_map(NULL); + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, ++idx); } if ( rc == -ENOENT ) @@ -81,9 +73,9 @@ int __init xsm_multiboot_policy_init( return rc; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) { struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:51:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338919.563765 (Exim 4.92) (envelope-from ) id 1nvoEj-0003G8-SO; Mon, 30 May 2022 22:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338919.563765; Mon, 30 May 2022 22:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvoEj-0003F9-Ig; Mon, 30 May 2022 22:51:45 +0000 Received: by outflank-mailman (input) for mailman id 338919; Mon, 30 May 2022 22:51:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo5R-000799-AV for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:42:09 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bbc29904-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:42:08 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950519242310.60530902135247; Mon, 30 May 2022 15:41:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbc29904-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950521; cv=none; d=zohomail.com; s=zohoarc; b=RxB74e1r1rnfOsVx9gK0CxQZgO3Hu8VtwZUSf6IgJAc5PflyNI0fbvpv6GEZ/XYjkBE6KpH5pn8JZiS22UvSHzHErKXuYSOVMb/dJzbw7T7NN1Hk4QJaOYk/q/YO+dZXGyKuLehkA6w5jSOn34FLnXVlCSTY2K0q7o2r4nm0FXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950521; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2+etTsXf8iWllebDioWmtCtaWII0LrkP35ocYWHoB/I=; b=hJFyPSqkOUVI3H9q3eLvGA8dISVN/rM4xp/FSaAavtGnhMFJlTSmXAsRSEam5Mx8sONqIc7l4HGKdaIV2NJ0PVFrKBbEscWNb4phcnBbguW1dUG5fcca+EU2iiXR2YC48Dk9gjYrUJCK0ycH7RSGogz123fS2/GPBMvrHOCgv98= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950521; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=2+etTsXf8iWllebDioWmtCtaWII0LrkP35ocYWHoB/I=; b=SxokjebdsIBmtYMxINXGexQDmrmm+sA2AyKe9T8m8htkd01gX7wnCaIPF00Is+K8 2wVnU4N+Eu5KyDztbTzgknca93xGh1G9b/yUFFueDxjthJCuu87mAoIUk6gSxXDatPP c1K4ez9khzvVrRGSvjVietSCeHREaba6n2cFtGXk= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, sstabellini@kernel.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Bertrand Marquis , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Date: Mon, 30 May 2022 22:41:23 -0400 Message-Id: <20220531024127.23669-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531024127.23669-1-dpsmith@apertussolutions.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External For x86 the number of allowable multiboot modules varies between the different entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and x86 this value is fixed to values based on generalized assumptions. With hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large allocations compiled into the hypervisor that will go unused by many use cases. This commit introduces a Kconfig variable that is set with sane defaults based on configuration selection. This variable is in turned used as the array size for the cases where a static allocated array of boot modules is declared. Signed-off-by: Daniel P. Smith --- xen/arch/Kconfig | 12 ++++++++++++ xen/arch/arm/include/asm/setup.h | 5 +++-- xen/arch/x86/efi/efi-boot.h | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/setup.c | 4 ++-- 5 files changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..57b14e22c9 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,15 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_BOOTMODS + int "Maximum number of boot modules that a loader can pass" + range 1 64 + default "8" if X86 + default "32" if ARM + help + Controls the build-time size of various arrays allocated for + parsing the boot modules passed by a loader when starting Xen. + + This is of particular interest when using Xen's hypervisor domain + capabilities such as dom0less. diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 2bb01ecfa8..312a3e4209 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -10,7 +10,8 @@ #define NR_MEM_BANKS 256 -#define MAX_MODULES 32 /* Current maximum useful modules */ +/* Current maximum useful modules */ +#define MAX_MODULES CONFIG_NR_BOOTMODS typedef enum { BOOTMOD_XEN, @@ -38,7 +39,7 @@ struct meminfo { * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. * The purpose of the domU flag is to avoid getting confused in * kernel_probe, where we try to guess which is the dom0 kernel and - * initrd to be compatible with all versions of the multiboot spec. + * initrd to be compatible with all versions of the multiboot spec. */ #define BOOTMOD_MAX_CMDLINE 1024 struct bootmodule { diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 6e65b569b0..4e1a799749 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[5]; +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 498625eae0..834b1ad16b 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -32,7 +32,7 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[8]; +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; static const char *__initdata pvh_loader = "PVH Directboot"; static void __init convert_pvh_info(multiboot_info_t **mbi, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index ed67b50c9d..3f5e602e00 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1017,9 +1017,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > sizeof(module_map) * 8 ) + if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) { - mbi->mods_count = sizeof(module_map) * 8; + mbi->mods_count = CONFIG_NR_BOOTMODS; printk("Excessive multiboot modules - using the first %u only\n", mbi->mods_count); } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon May 30 22:51:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 30 May 2022 22:51:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338924.563782 (Exim 4.92) (envelope-from ) id 1nvoEm-0003nG-9l; Mon, 30 May 2022 22:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338924.563782; Mon, 30 May 2022 22:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvoEm-0003n3-56; Mon, 30 May 2022 22:51:48 +0000 Received: by outflank-mailman (input) for mailman id 338924; Mon, 30 May 2022 22:51:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvo5k-000799-VG for xen-devel@lists.xenproject.org; Mon, 30 May 2022 22:42:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c77b6256-e069-11ec-837f-e5687231ffcc; Tue, 31 May 2022 00:42:27 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653950520786963.2599323551407; Mon, 30 May 2022 15:42:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c77b6256-e069-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653950523; cv=none; d=zohomail.com; s=zohoarc; b=e9pf82uT1+AgRUwvRHljQ3G2Zsg2NnZDD3cxpbCheLfPmFO2qJnrbI/9Sl8sP0QKOzkkMpwoVCkAK9NDwTHQ6zMH/hJ/jRPEnN2Z1Lk1WGJSqXbNib0TY1qVU8OPdxtSizwo7hDQtF5YrpZ2e6KElOHiPqpaQZrOW5RDb/40Ew8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653950523; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=iAGucPdV3glHdtZABJs2CPxR/bL8xV7VFYB5AxMoSfc=; b=J32e/CeBeSMVOOAhRY8ND7fWlBjx9I1BwOdOT4zT+inqN+M11Zs0HmF/naaLdCtufv2WV+KgAvYM4lSinFA0JWHG9KSi1Oow6ACwmdue5phWMqkHz6MKHEwdkLtcK10fJ2YK/X3OA1MspuIQlfsa2d62Ho9M4pC9l0ezUkn2Ykw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653950523; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=iAGucPdV3glHdtZABJs2CPxR/bL8xV7VFYB5AxMoSfc=; b=MKli1T29u3OeXeN0juTd4Hzsdz8wvXUTJUsgdL3YPmH0xIVY95lg5y1Q+9SLbiJK MuP/WcU8/xTvVPGKLAii86cvpn39DBYTtSKiVSJ5z3X8kmunxwoftWfTnu9IP0Y08wQ DT2uvis3q6cYMtPqU5yIXBGhKTgtfvCl4gW8Vc7U= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, sstabellini@kernel.org, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall Subject: [RFC PATCH 2/4] headers: introduce generalized boot info Date: Mon, 30 May 2022 22:41:24 -0400 Message-Id: <20220531024127.23669-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531024127.23669-1-dpsmith@apertussolutions.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The x86 and Arm architectures represent in memory the general boot information and boot modules differently despite having commonality. The x86 representations are bound to the multiboot v1 structures while the Arm representations are a slightly generalized meta-data container for the boot material. The multiboot structure does not lend itself well to being expanded to accommodate additional metadata, both general and boot module specific. The Arm structures are not bound to an external specification and thus are able to be expanded for solutions such as dom0less. This commit introduces a set of structures patterned off the Arm structures to represent the boot information in a manner that captures common data. The structures provide an arch field to allow arch specific expansions to the structures. The intended goal of these new common structures is to enable commonality between the different architectures.  Specifically to enable dom0less and hyperlaunch to have a common representation of boot-time constructed domains. Signed-off-by: Daniel P. Smith --- xen/arch/x86/include/asm/bootinfo.h | 45 ++++++++++++++++++++++++ xen/include/xen/bootinfo.h | 54 +++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+) create mode 100644 xen/arch/x86/include/asm/bootinfo.h create mode 100644 xen/include/xen/bootinfo.h diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h new file mode 100644 index 0000000000..13e49f2b87 --- /dev/null +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -0,0 +1,45 @@ +#ifndef __ARCH_X86_BOOTINFO_H__ +#define __ARCH_X86_BOOTINFO_H__ + +/* unused for x86 */ +struct arch_bootstring { }; + +struct __packed arch_bootmodule { +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + uint32_t flags; + uint32_t headroom; +}; + +struct __packed arch_boot_info { + uint32_t flags; +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 +#define BOOTINFO_FLAG_X86_APM 1U << 10 + + char *boot_loader_name; + + uint32_t mem_lower; + uint32_t mem_upper; + + uint32_t mmap_length; + paddr_t mmap_addr; +}; + +struct __packed mb_memmap { + uint32_t size; + uint32_t base_addr_low; + uint32_t base_addr_high; + uint32_t length_low; + uint32_t length_high; + uint32_t type; +}; + +#endif diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h new file mode 100644 index 0000000000..42b53a3ca6 --- /dev/null +++ b/xen/include/xen/bootinfo.h @@ -0,0 +1,54 @@ +#ifndef __XEN_BOOTINFO_H__ +#define __XEN_BOOTINFO_H__ + +#include +#include + +#include + +typedef enum { + BOOTMOD_UNKNOWN, + BOOTMOD_XEN, + BOOTMOD_FDT, + BOOTMOD_KERNEL, + BOOTMOD_RAMDISK, + BOOTMOD_XSM, + BOOTMOD_UCODE, + BOOTMOD_GUEST_DTB, +} bootmodule_kind; + +typedef enum { + BOOTSTR_EMPTY, + BOOTSTR_STRING, + BOOTSTR_CMDLINE, +} bootstring_kind; + +#define BOOTMOD_MAX_STRING 1024 +struct __packed boot_string { + bootstring_kind kind; + struct arch_bootstring *arch; + + char bytes[BOOTMOD_MAX_STRING]; + size_t len; +}; + +struct __packed boot_module { + bootmodule_kind kind; + paddr_t start; + mfn_t mfn; + size_t size; + + struct arch_bootmodule *arch; + struct boot_string string; +}; + +struct __packed boot_info { + char *cmdline; + + uint32_t nr_mods; + struct boot_module *mods; + + struct arch_boot_info *arch; +}; + +#endif -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338982.563793 (Exim 4.92) (envelope-from ) id 1nvsJv-00041b-MQ; Tue, 31 May 2022 03:13:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338982.563793; Tue, 31 May 2022 03:13:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsJv-00041U-JQ; Tue, 31 May 2022 03:13:23 +0000 Received: by outflank-mailman (input) for mailman id 338982; Tue, 31 May 2022 03:13:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsJu-000414-86 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9e21a824-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 712D823A; Mon, 30 May 2022 20:13:17 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1C1D23F66F; Mon, 30 May 2022 20:13:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e21a824-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v5 0/9] populate/unpopulate memory when domain on static allocation Date: Tue, 31 May 2022 11:12:32 +0800 Message-Id: <20220531031241.90374-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so they shall never go back to heap allocator. This patch serie intends to fix this issue, by adding pages on the new list resv_page_list after having taken them off the "normal" list, when unpopulating memory, and retrieving pages from resv page list(resv_page_list) when populating memory. --- v5 changes: - introduce three new commits - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes: - commit message refinement - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" - change name from "is_domain_static()" to "is_domain_using_staticmem" - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. - move #ifndef is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - change name from "is_domain_on_static_allocation" to "is_domain_static()" - put reserved pages on resv_page_list after having taken them off the "normal" list - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 - fix coding style Penny Zheng (9): xen/arm: rename PGC_reserved to PGC_staticmem xen: do not free reserved memory into heap xen: update SUPPORT.md for static allocation xen: do not merge reserved pages in free_heap_pages() xen: add field "flags" to cover all internal CDF_XXX xen/arm: introduce CDF_staticmem xen/arm: unpopulate memory when domain is static xen: introduce prepare_staticmem_pages xen: retrieve reserved pages on populate_physmap SUPPORT.md | 7 ++ xen/arch/arm/domain.c | 2 - xen/arch/arm/domain_build.c | 5 +- xen/arch/arm/include/asm/domain.h | 7 +- xen/arch/arm/include/asm/mm.h | 20 +++- xen/common/domain.c | 7 ++ xen/common/memory.c | 23 +++++ xen/common/page_alloc.c | 147 ++++++++++++++++++++---------- xen/include/xen/domain.h | 6 ++ xen/include/xen/mm.h | 7 +- xen/include/xen/sched.h | 6 ++ 11 files changed, 180 insertions(+), 57 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338983.563804 (Exim 4.92) (envelope-from ) id 1nvsJz-0004HF-0T; Tue, 31 May 2022 03:13:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338983.563804; Tue, 31 May 2022 03:13:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsJy-0004H6-SA; Tue, 31 May 2022 03:13:26 +0000 Received: by outflank-mailman (input) for mailman id 338983; Tue, 31 May 2022 03:13:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsJx-0004Go-IW for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a08f576b-e08f-11ec-837f-e5687231ffcc; Tue, 31 May 2022 05:13:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E393ED1; Mon, 30 May 2022 20:13:21 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EFC803F66F; Mon, 30 May 2022 20:13:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a08f576b-e08f-11ec-837f-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v5 1/9] xen/arm: rename PGC_reserved to PGC_staticmem Date: Tue, 31 May 2022 11:12:33 +0800 Message-Id: <20220531031241.90374-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PGC_reserved could be ambiguous, and we have to tell what the pages are reserved for, so this commit intends to rename PGC_reserved to PGC_staticmem, which clearly indicates the page is reserved for static memory. Signed-off-by: Penny Zheng --- v5 changes: - new commit --- xen/arch/arm/include/asm/mm.h | 6 +++--- xen/common/page_alloc.c | 20 ++++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 424aaf2823..1226700085 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,9 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is reserved */ -#define _PGC_reserved PG_shift(3) -#define PGC_reserved PG_mask(1, 3) + /* Page is static memory */ +#define _PGC_staticmem PG_shift(3) +#define PGC_staticmem PG_mask(1, 3) /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 319029140f..44600dd9cd 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,8 +151,8 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_reserved -#define PGC_reserved 0 +#ifndef PGC_staticmem +#define PGC_staticmem 0 #endif /* @@ -2286,7 +2286,7 @@ int assign_pages( for ( i = 0; i < nr; i++ ) { - ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_reserved))); + ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_staticmem))); if ( pg[i].count_info & PGC_extra ) extra_pages++; } @@ -2346,7 +2346,7 @@ int assign_pages( page_set_owner(&pg[i], d); smp_wmb(); /* Domain pointer must be visible before updating refcnt. */ pg[i].count_info = - (pg[i].count_info & (PGC_extra | PGC_reserved)) | PGC_allocated | 1; + (pg[i].count_info & (PGC_extra | PGC_staticmem)) | PGC_allocated | 1; page_list_add_tail(&pg[i], page_to_list(d, &pg[i])); } @@ -2652,8 +2652,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_reserved. */ - pg[i].count_info |= PGC_reserved; + /* In case initializing page of static memory, mark it PGC_staticmem. */ + pg[i].count_info |= PGC_staticmem; } } @@ -2683,7 +2683,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, for ( i = 0; i < nr_mfns; i++ ) { /* The page should be reserved and not yet allocated. */ - if ( pg[i].count_info != (PGC_state_free | PGC_reserved) ) + if ( pg[i].count_info != (PGC_state_free | PGC_staticmem) ) { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", @@ -2697,10 +2697,10 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, &tlbflush_timestamp); /* - * Preserve flag PGC_reserved and change page state + * Preserve flag PGC_staticmem and change page state * to PGC_state_inuse. */ - pg[i].count_info = PGC_reserved | PGC_state_inuse; + pg[i].count_info = PGC_staticmem | PGC_state_inuse; /* Initialise fields which have other uses for free pages. */ pg[i].u.inuse.type_info = 0; page_set_owner(&pg[i], NULL); @@ -2722,7 +2722,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, out_err: while ( i-- ) - pg[i].count_info = PGC_reserved | PGC_state_free; + pg[i].count_info = PGC_staticmem | PGC_state_free; spin_unlock(&heap_lock); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338986.563836 (Exim 4.92) (envelope-from ) id 1nvsK7-0005BS-Ub; Tue, 31 May 2022 03:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338986.563836; Tue, 31 May 2022 03:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsK7-0005BL-RY; Tue, 31 May 2022 03:13:35 +0000 Received: by outflank-mailman (input) for mailman id 338986; Tue, 31 May 2022 03:13:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsK6-0004Go-JT for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a77049b0-e08f-11ec-837f-e5687231ffcc; Tue, 31 May 2022 05:13:33 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3432723A; Mon, 30 May 2022 20:13:33 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D3D5E3F66F; Mon, 30 May 2022 20:13:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a77049b0-e08f-11ec-837f-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , Penny Zheng Subject: [PATCH v5 4/9] xen: do not merge reserved pages in free_heap_pages() Date: Tue, 31 May 2022 11:12:36 +0800 Message-Id: <20220531031241.90374-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The code in free_heap_pages() will try to merge pages with the successor/predecessor if pages are suitably aligned. So if the pages reserved are right next to the pages given to the heap allocator, free_heap_pages() will merge them, and give the reserved pages to heap allocator accidently as a result. So in order to avoid the above scenario, this commit updates free_heap_pages() to check whether the predecessor and/or successor has PGC_reserved set, when trying to merge the about-to-be-freed chunk with the predecessor and/or successor. Suggested-by: Julien Grall Signed-off-by: Penny Zheng Reviewed-by: Jan Beulich Reviewed-by: Julien Grall --- v5 changes: - change PGC_reserved to adapt to PGC_staticmem --- v4 changes: - no changes --- v3 changes: - no changes --- v2 changes: - new commit --- xen/common/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 6425761116..b1350fc238 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1482,6 +1482,7 @@ static void free_heap_pages( /* Merge with predecessor block? */ if ( !mfn_valid(page_to_mfn(predecessor)) || !page_state_is(predecessor, free) || + (predecessor->count_info & PGC_staticmem) || (PFN_ORDER(predecessor) != order) || (phys_to_nid(page_to_maddr(predecessor)) != node) ) break; @@ -1505,6 +1506,7 @@ static void free_heap_pages( /* Merge with successor block? */ if ( !mfn_valid(page_to_mfn(successor)) || !page_state_is(successor, free) || + (successor->count_info & PGC_staticmem) || (PFN_ORDER(successor) != order) || (phys_to_nid(page_to_maddr(successor)) != node) ) break; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338984.563814 (Exim 4.92) (envelope-from ) id 1nvsK1-0004XV-6l; Tue, 31 May 2022 03:13:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338984.563814; Tue, 31 May 2022 03:13:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsK1-0004XO-32; Tue, 31 May 2022 03:13:29 +0000 Received: by outflank-mailman (input) for mailman id 338984; Tue, 31 May 2022 03:13:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsJz-000414-G4 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:27 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a306f280-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:26 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ABB5523A; Mon, 30 May 2022 20:13:25 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 18EBA3F66F; Mon, 30 May 2022 20:13:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a306f280-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v5 2/9] xen: do not free reserved memory into heap Date: Tue, 31 May 2022 11:12:34 +0800 Message-Id: <20220531031241.90374-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. free_staticmem_pages will be called by free_heap_pages in runtime for static domain freeing memory resource, so let's drop the __init flag. Signed-off-by: Penny Zheng --- v5 changes: - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h --- v4 changes: - no changes --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - fix the indentation --- v2 changes: - new commit --- xen/arch/arm/include/asm/mm.h | 2 ++ xen/common/page_alloc.c | 16 +++++++++------- xen/include/xen/mm.h | 6 +++++- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 1226700085..56d0939318 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,11 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) +#ifdef CONFIG_STATIC_MEMORY /* Page is static memory */ #define _PGC_staticmem PG_shift(3) #define PGC_staticmem PG_mask(1, 3) +#endif /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 44600dd9cd..6425761116 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,10 +151,6 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_staticmem -#define PGC_staticmem 0 -#endif - /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -1443,6 +1439,13 @@ static void free_heap_pages( ASSERT(order <= MAX_ORDER); + if ( unlikely(pg->count_info & PGC_staticmem) ) + { + /* Pages of static memory shall not go back to the heap. */ + free_staticmem_pages(pg, 1UL << order, need_scrub); + return; + } + spin_lock(&heap_lock); for ( i = 0; i < (1 << order); i++ ) @@ -2636,8 +2639,8 @@ struct domain *get_pg_owner(domid_t domid) #ifdef CONFIG_STATIC_MEMORY /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; @@ -2652,7 +2655,6 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_staticmem. */ pg[i].count_info |= PGC_staticmem; } } diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3be754da92..ca2c6f033e 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,10 +85,10 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) -#ifdef CONFIG_STATIC_MEMORY /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +#ifdef CONFIG_STATIC_MEMORY int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); #endif @@ -212,6 +212,10 @@ extern struct domain *dom_cow; #include +#ifndef PGC_staticmem +#define PGC_staticmem 0 +#endif + static inline bool is_special_page(const struct page_info *page) { return is_xen_heap_page(page) || (page->count_info & PGC_extra); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338985.563826 (Exim 4.92) (envelope-from ) id 1nvsK4-0004qu-MM; Tue, 31 May 2022 03:13:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338985.563826; Tue, 31 May 2022 03:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsK4-0004qi-Hp; Tue, 31 May 2022 03:13:32 +0000 Received: by outflank-mailman (input) for mailman id 338985; Tue, 31 May 2022 03:13:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsK2-0004Go-MX for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a5204b3c-e08f-11ec-837f-e5687231ffcc; Tue, 31 May 2022 05:13:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54EAF23A; Mon, 30 May 2022 20:13:29 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 35FB23F66F; Mon, 30 May 2022 20:13:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5204b3c-e08f-11ec-837f-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v5 3/9] xen: update SUPPORT.md for static allocation Date: Tue, 31 May 2022 11:12:35 +0800 Message-Id: <20220531031241.90374-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SUPPORT.md doesn't seem to explicitly say whether static memory is supported, so this commit updates SUPPORT.md to add feature static allocation tech preview for now. Signed-off-by: Penny Zheng --- v5 changes: - new commit --- SUPPORT.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index ee2cd319e2..5980a82c4b 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -278,6 +278,13 @@ to boot with memory < maxmem. Status, x86 HVM: Supported +### Static Allocation + +Static allocation refers to system or sub-system(domains) for which memory +areas are pre-defined by configuration using physical address ranges. + + Status, ARM: Tech Preview + ### Memory Sharing Allow sharing of identical pages between guests -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:13:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:13:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.338991.563848 (Exim 4.92) (envelope-from ) id 1nvsKD-0005cL-Ad; Tue, 31 May 2022 03:13:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 338991.563848; Tue, 31 May 2022 03:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKD-0005cC-5z; Tue, 31 May 2022 03:13:41 +0000 Received: by outflank-mailman (input) for mailman id 338991; Tue, 31 May 2022 03:13:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKC-000414-1l for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id aa0ec9a7-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:38 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93B9823A; Mon, 30 May 2022 20:13:37 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B5D8B3F66F; Mon, 30 May 2022 20:13:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa0ec9a7-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v5 5/9] xen: add field "flags" to cover all internal CDF_XXX Date: Tue, 31 May 2022 11:12:37 +0800 Message-Id: <20220531031241.90374-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng Acked-by: Julien Grall --- v5 changes: - no change --- v4 changes: - no change --- v3 changes: - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - fix coding style --- xen/arch/arm/domain.c | 2 -- xen/arch/arm/include/asm/domain.h | 3 +-- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 +++ 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 8110c1df86..74189d9878 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d, ioreq_domain_init(d); #endif - d->arch.directmap = flags & CDF_directmap; - /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) goto fail; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index ed63c2b6f9..fe7a029ebf 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -29,7 +29,7 @@ enum domain_type { #define is_64bit_domain(d) (0) #endif -#define is_domain_direct_mapped(d) (d)->arch.directmap +#define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) /* * Is the domain using the host memory layout? @@ -103,7 +103,6 @@ struct arch_domain void *tee; #endif - bool directmap; } __cacheline_aligned; struct arch_vcpu diff --git a/xen/common/domain.c b/xen/common/domain.c index 7570eae91a..a3ef991bd1 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -567,6 +567,9 @@ struct domain *domain_create(domid_t domid, /* Sort out our idea of is_system_domain(). */ d->domain_id = domid; + /* Holding CDF_* internal flags. */ + d->cdf = flags; + /* Debug sanity. */ ASSERT(is_system_domain(d) ? config == NULL : config != NULL); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 463d41ffb6..5191853c18 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -596,6 +596,9 @@ struct domain struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; #endif + + /* Holding CDF_* constant. Internal flags for domain creation. */ + unsigned int cdf; }; static inline struct page_list_head *page_to_list( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339008.563858 (Exim 4.92) (envelope-from ) id 1nvsKx-0007Cc-MV; Tue, 31 May 2022 03:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339008.563858; Tue, 31 May 2022 03:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKx-0007CV-JR; Tue, 31 May 2022 03:14:27 +0000 Received: by outflank-mailman (input) for mailman id 339008; Tue, 31 May 2022 03:14:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKv-0007C8-VT for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:14:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b12c1803-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FFEAED1; Mon, 30 May 2022 20:13:49 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5AA8F3F66F; Mon, 30 May 2022 20:13:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b12c1803-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v5 8/9] xen: introduce prepare_staticmem_pages Date: Tue, 31 May 2022 11:12:40 +0800 Message-Id: <20220531031241.90374-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we want to use acquire_domstatic_pages() for populating memory for static domain on runtime, however, there are a lot of pointless work (checking mfn_valid(), scrubbing the free part, cleaning the cache...) considering we know the page is valid and belong to the guest. This commit splits acquire_staticmem_pages() in two parts, and introduces prepare_staticmem_pages to bypass all "pointless work". Signed-off-by: Penny Zheng --- v5 changes: - new commit --- xen/common/page_alloc.c | 61 ++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index b1350fc238..bdd2e62865 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2661,26 +2661,13 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, } } -/* - * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of - * static memory. - * This function needs to be reworked if used outside of boot. - */ -static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, - unsigned long nr_mfns, - unsigned int memflags) +static bool __init prepare_staticmem_pages(struct page_info *pg, + unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; unsigned long i; - struct page_info *pg; - - ASSERT(nr_mfns); - for ( i = 0; i < nr_mfns; i++ ) - if ( !mfn_valid(mfn_add(smfn, i)) ) - return NULL; - - pg = mfn_to_page(smfn); spin_lock(&heap_lock); @@ -2691,7 +2678,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", - i, mfn_x(smfn) + i, + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info, pg[i].tlbflush_timestamp); goto out_err; } @@ -2715,6 +2702,38 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, if ( need_tlbflush ) filtered_flush_tlb_mask(tlbflush_timestamp); + return true; + + out_err: + while ( i-- ) + pg[i].count_info = PGC_staticmem | PGC_state_free; + + spin_unlock(&heap_lock); + + return false; +} + +/* + * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of + * static memory. + * This function needs to be reworked if used outside of boot. + */ +static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, + unsigned long nr_mfns, + unsigned int memflags) +{ + unsigned long i; + struct page_info *pg; + + ASSERT(nr_mfns); + for ( i = 0; i < nr_mfns; i++ ) + if ( !mfn_valid(mfn_add(smfn, i)) ) + return NULL; + + pg = mfn_to_page(smfn); + if ( !prepare_staticmem_pages(pg, nr_mfns, memflags) ) + return NULL; + /* * Ensure cache and RAM are consistent for platforms where the guest * can control its own visibility of/through the cache. @@ -2723,14 +2742,6 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, flush_page_to_ram(mfn_x(smfn) + i, !(memflags & MEMF_no_icache_flush)); return pg; - - out_err: - while ( i-- ) - pg[i].count_info = PGC_staticmem | PGC_state_free; - - spin_unlock(&heap_lock); - - return NULL; } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:14:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:14:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339012.563870 (Exim 4.92) (envelope-from ) id 1nvsL1-0007U7-04; Tue, 31 May 2022 03:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339012.563870; Tue, 31 May 2022 03:14:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsL0-0007Ty-Rz; Tue, 31 May 2022 03:14:30 +0000 Received: by outflank-mailman (input) for mailman id 339012; Tue, 31 May 2022 03:14:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKz-0007C8-P3 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:14:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id aef75da2-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:46 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D017923A; Mon, 30 May 2022 20:13:45 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3C2063F66F; Mon, 30 May 2022 20:13:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aef75da2-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v5 7/9] xen/arm: unpopulate memory when domain is static Date: Tue, 31 May 2022 11:12:39 +0800 Message-Id: <20220531031241.90374-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never go back to heap allocator. This commit puts reserved pages on the new list resv_page_list only after having taken them off the "normal" list, when the last ref dropped. Signed-off-by: Penny Zheng --- v5 changes: - adapt this patch for PGC_staticmem --- v4 changes: - no changes --- v3 changes: - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. --- v2 changes: - put reserved pages on resv_page_list after having taken them off the "normal" list --- xen/arch/arm/include/asm/mm.h | 12 ++++++++++++ xen/common/domain.c | 4 ++++ xen/include/xen/sched.h | 3 +++ 3 files changed, 19 insertions(+) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 56d0939318..ca384a3939 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -360,6 +360,18 @@ void clear_and_clean_page(struct page_info *page); unsigned int arch_get_dma_bitsize(void); +/* + * Put free pages on the resv page list after having taken them + * off the "normal" page list, when pages from static memory + */ +#ifdef CONFIG_STATIC_MEMORY +#define arch_free_heap_page(d, pg) ({ \ + page_list_del(pg, page_to_list(d, pg)); \ + if ( (pg)->count_info & PGC_staticmem ) \ + page_list_add_tail(pg, &(d)->resv_page_list); \ +}) +#endif + #endif /* __ARCH_ARM_MM__ */ /* * Local variables: diff --git a/xen/common/domain.c b/xen/common/domain.c index a3ef991bd1..a49574fa24 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid, INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); INIT_PAGE_LIST_HEAD(&d->xenpage_list); +#ifdef CONFIG_STATIC_MEMORY + INIT_PAGE_LIST_HEAD(&d->resv_page_list); +#endif + spin_lock_init(&d->node_affinity_lock); d->node_affinity = NODE_MASK_ALL; diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 5191853c18..3e22c77333 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -381,6 +381,9 @@ struct domain struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ +#ifdef CONFIG_STATIC_MEMORY + struct page_list_head resv_page_list; /* linked list (size resv_pages) */ +#endif /* * This field should only be directly accessed by domain_adjust_tot_pages() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:22:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339040.563880 (Exim 4.92) (envelope-from ) id 1nvsSF-000199-O0; Tue, 31 May 2022 03:21:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339040.563880; Tue, 31 May 2022 03:21:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsSF-000192-LK; Tue, 31 May 2022 03:21:59 +0000 Received: by outflank-mailman (input) for mailman id 339040; Tue, 31 May 2022 03:21:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKI-000414-55 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:46 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ac9377a8-e08f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 05:13:42 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B102723A; Mon, 30 May 2022 20:13:41 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1E4673F66F; Mon, 30 May 2022 20:13:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac9377a8-e08f-11ec-bd2c-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v5 6/9] xen/arm: introduce CDF_staticmem Date: Tue, 31 May 2022 11:12:38 +0800 Message-Id: <20220531031241.90374-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng --- v5 changes: - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v4 changes: - no changes --- v3 changes: - change name from "is_domain_static()" to "is_domain_using_staticmem" --- v2 changes: - change name from "is_domain_on_static_allocation" to "is_domain_static()" --- xen/arch/arm/domain_build.c | 5 ++++- xen/arch/arm/include/asm/domain.h | 4 ++++ xen/include/xen/domain.h | 6 ++++++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 7ddd16c26d..f6e2e44c1e 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3287,9 +3287,12 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + if ( dt_property_read_bool(node, "direct-map") ) { - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) + if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !(flags & CDF_staticmem) ) panic("direct-map is not valid for domain %s without static allocation.\n", dt_node_name(node)); diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index fe7a029ebf..6bb999aff0 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -31,6 +31,10 @@ enum domain_type { #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) +#ifdef CONFIG_STATIC_MEMORY +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) +#endif + /* * Is the domain using the host memory layout? * diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 1c3c88a14d..c613afa57e 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -34,6 +34,12 @@ void arch_get_domain_info(const struct domain *d, #ifdef CONFIG_ARM /* Should domain memory be directly mapped? */ #define CDF_directmap (1U << 1) +/* Is domain memory on static allocation? */ +#define CDF_staticmem (1U << 2) +#endif + +#ifndef is_domain_using_staticmem +#define is_domain_using_staticmem(d) ((void)(d), false) #endif /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:22:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:22:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339073.563892 (Exim 4.92) (envelope-from ) id 1nvsSp-0001le-2d; Tue, 31 May 2022 03:22:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339073.563892; Tue, 31 May 2022 03:22:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsSo-0001lX-UG; Tue, 31 May 2022 03:22:34 +0000 Received: by outflank-mailman (input) for mailman id 339073; Tue, 31 May 2022 03:22:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvsKT-0004Go-KB for xen-devel@lists.xenproject.org; Tue, 31 May 2022 03:13:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b33e6112-e08f-11ec-837f-e5687231ffcc; Tue, 31 May 2022 05:13:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10233113E; Mon, 30 May 2022 20:13:53 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EF4A93F66F; Mon, 30 May 2022 20:13:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b33e6112-e08f-11ec-837f-e5687231ffcc From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v5 9/9] xen: retrieve reserved pages on populate_physmap Date: Tue, 31 May 2022 11:12:41 +0800 Message-Id: <20220531031241.90374-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220531031241.90374-1-Penny.Zheng@arm.com> References: <20220531031241.90374-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a static domain populates memory through populate_physmap at runtime, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. This commit also introduces a new helper acquire_reserved_page to make it work. Signed-off-by: Penny Zheng --- v5 changes: - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes： - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - move is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 --- xen/common/memory.c | 23 ++++++++++++++ xen/common/page_alloc.c | 70 +++++++++++++++++++++++++++++++---------- xen/include/xen/mm.h | 1 + 3 files changed, 77 insertions(+), 17 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index f2d009843a..cb330ce877 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) mfn = _mfn(gpfn); } + else if ( is_domain_using_staticmem(d) ) + { + /* + * No easy way to guarantee the retrieved pages are contiguous, + * so forbid non-zero-order requests here. + */ + if ( a->extent_order != 0 ) + { + gdprintk(XENLOG_WARNING, + "Cannot allocate static order-%u pages for static %pd\n", + a->extent_order, d); + goto out; + } + + mfn = acquire_reserved_page(d, a->memflags); + if ( mfn_eq(mfn, INVALID_MFN) ) + { + gdprintk(XENLOG_WARNING, + "%pd: failed to retrieve a reserved page\n", + d); + goto out; + } + } else { page = alloc_domheap_pages(d, a->extent_order, a->memflags); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index bdd2e62865..9448552bab 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2661,9 +2661,8 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, } } -static bool __init prepare_staticmem_pages(struct page_info *pg, - unsigned long nr_mfns, - unsigned int memflags) +static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; @@ -2744,21 +2743,9 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, return pg; } -/* - * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, - * then assign them to one specific domain #d. - */ -int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, - unsigned int nr_mfns, unsigned int memflags) +static int assign_domstatic_pages(struct domain *d, struct page_info *pg, + unsigned int nr_mfns, unsigned int memflags) { - struct page_info *pg; - - ASSERT(!in_irq()); - - pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); - if ( !pg ) - return -ENOENT; - if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) { /* @@ -2777,6 +2764,55 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } + +/* + * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, + * then assign them to one specific domain #d. + */ +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, + unsigned int nr_mfns, unsigned int memflags) +{ + struct page_info *pg; + + ASSERT(!in_irq()); + + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); + if ( !pg ) + return -ENOENT; + + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) + return -EINVAL; + + return 0; +} + +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + struct page_info *page; + + spin_lock(&d->page_alloc_lock); + /* Acquire a page from reserved page list(resv_page_list). */ + page = page_list_remove_head(&d->resv_page_list); + if ( unlikely(!page) ) + return INVALID_MFN; + spin_unlock(&d->page_alloc_lock); + + if ( !prepare_staticmem_pages(page, 1, memflags) ) + goto fail; + + if ( assign_domstatic_pages(d, page, 1, memflags) ) + goto fail; + + return page_to_mfn(page); + + fail: + page_list_add_tail(page, &d->resv_page_list); + return INVALID_MFN; +} #endif /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index ca2c6f033e..4665bcdd25 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -92,6 +92,7 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); #endif +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 03:59:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 03:59:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339085.563903 (Exim 4.92) (envelope-from ) id 1nvt2e-0005PF-2C; Tue, 31 May 2022 03:59:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339085.563903; Tue, 31 May 2022 03:59:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvt2d-0005P8-Us; Tue, 31 May 2022 03:59:35 +0000 Received: by outflank-mailman (input) for mailman id 339085; Tue, 31 May 2022 03:59:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvt2c-0005Oy-25; Tue, 31 May 2022 03:59:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvt2b-0001Zg-UB; Tue, 31 May 2022 03:59:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvt2b-0008Cv-Gt; Tue, 31 May 2022 03:59:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvt2b-0001Pp-GR; Tue, 31 May 2022 03:59:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EdS4+7ExYQWvwwf3LWi6zGo6ieOyC8JGUGNnj3ii2vM=; b=iBSDQAUCap2JcfRVuflVruNPHz iW8W1kSa0xBJ7Ar7RtkP6Aj+XNoWu4HIURPPdm4BNVGsQ7FGLlmFR6bcRPqC8Kkb4BbkmLWfV/fF2 qNwSezapAt+gsn9ezznvjLcMhWVHR9IBMC7Zv7I9LSQmixpS62K6fDP654KLyjRlmTfA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170778: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ed72f34421f8900d9fedef4a37722522cf0bf3e7 X-Osstest-Versions-That: qemuu=f7a1ea403e0282a7f57edd4298c4f65f24165da5 From: osstest service owner Date: Tue, 31 May 2022 03:59:33 +0000 flight 170778 qemu-mainline real [real] flight 170782 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170778/ http://logs.test-lab.xenproject.org/osstest/logs/170782/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 170782-retest test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 170782-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170773 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170773 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170773 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170773 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170773 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170773 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170773 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170773 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu ed72f34421f8900d9fedef4a37722522cf0bf3e7 baseline version: qemuu f7a1ea403e0282a7f57edd4298c4f65f24165da5 Last test of basis 170773 2022-05-30 02:06:56 Z 1 days Testing same since 170778 2022-05-30 20:07:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Icenowy Zheng Peter Maydell Philippe Mathieu-Daudé Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f7a1ea403e..ed72f34421 ed72f34421f8900d9fedef4a37722522cf0bf3e7 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 31 05:30:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 05:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339096.563914 (Exim 4.92) (envelope-from ) id 1nvuSj-0007OL-IM; Tue, 31 May 2022 05:30:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339096.563914; Tue, 31 May 2022 05:30:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuSj-0007OE-F8; Tue, 31 May 2022 05:30:37 +0000 Received: by outflank-mailman (input) for mailman id 339096; Tue, 31 May 2022 05:30:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuSh-0007O4-W7; Tue, 31 May 2022 05:30:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuSh-0003ai-UB; Tue, 31 May 2022 05:30:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuSh-0005Vd-HE; Tue, 31 May 2022 05:30:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvuSh-0005cf-CY; Tue, 31 May 2022 05:30:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4hTGaqK5R39Ljbe2H+KDsB8pYsKY8+iTbyywDzOLicA=; b=eC7I59Gvtbk5famZXJfaMibuQo tUTDUdu4PJeyUxQa8yoawwfPst50aYhu89lCOLH+vFe2oOdVA+FTUR/4cgPutLBngbumAUZwv5Nb2 lxbvUG6OD3THGhJFZ1s8lVEDFHPUeKjIBQWPjQfZlWRI+mvWRjZa5xex6pZne1SZpfLA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170779: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=8ab2afa23bd197df47819a87f0265c0ac95c5b6a X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Tue, 31 May 2022 05:30:35 +0000 flight 170779 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170779/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 8ab2afa23bd197df47819a87f0265c0ac95c5b6a baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 7 days Failing since 170716 2022-05-24 11:12:06 Z 6 days 20 attempts Testing same since 170779 2022-05-30 21:42:54 Z 0 days 1 attempts ------------------------------------------------------------ 1946 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 217025 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 31 05:31:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 05:31:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339107.563925 (Exim 4.92) (envelope-from ) id 1nvuTa-0007yd-2D; Tue, 31 May 2022 05:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339107.563925; Tue, 31 May 2022 05:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuTZ-0007yW-VZ; Tue, 31 May 2022 05:31:29 +0000 Received: by outflank-mailman (input) for mailman id 339107; Tue, 31 May 2022 05:31:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuTZ-0007yM-4b; Tue, 31 May 2022 05:31:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuTZ-0003bK-3c; Tue, 31 May 2022 05:31:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvuTY-0005Yf-Pm; Tue, 31 May 2022 05:31:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvuTY-0006PB-PH; Tue, 31 May 2022 05:31:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kQi6YH7XagAtMArvwlZ6bGioOstH3xSEXTG+e6xXPEc=; b=iT66UH2ODhXMo7S1XA9dvV/IrZ 0vIPiWpoIH4ElGtsv6zKvMc7AWldooTHsgifKGcjy4SQrGiQLA2Fezd9BmLi19nXjNQ/k2/OuHyQt m1xycn5lJPyjzfXSUVz3uabnUeZF4RsBgoFhkpS+oDNF6SWUa+C+u7Z8riLwhdug9YkI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170781: all pass - PUSHED X-Osstest-Versions-This: ovmf=fa2b212d61dfeb9c00a174280a73a4f573ef617d X-Osstest-Versions-That: ovmf=3ca7326b37c5d20d9473f47266074e61ea384c5b From: osstest service owner Date: Tue, 31 May 2022 05:31:28 +0000 flight 170781 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170781/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fa2b212d61dfeb9c00a174280a73a4f573ef617d baseline version: ovmf 3ca7326b37c5d20d9473f47266074e61ea384c5b Last test of basis 170776 2022-05-30 11:14:13 Z 0 days Testing same since 170781 2022-05-31 02:10:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Loo Tung Lun Loo, Tung Lun jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3ca7326b37..fa2b212d61 fa2b212d61dfeb9c00a174280a73a4f573ef617d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339125.563953 (Exim 4.92) (envelope-from ) id 1nvvzi-0000yg-Ui; Tue, 31 May 2022 07:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339125.563953; Tue, 31 May 2022 07:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzi-0000wf-O7; Tue, 31 May 2022 07:08:46 +0000 Received: by outflank-mailman (input) for mailman id 339125; Tue, 31 May 2022 06:58:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvpS-00080v-3u for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:58:10 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04acad78-e0af-11ec-837f-e5687231ffcc; Tue, 31 May 2022 08:58:04 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id h62-20020a1c2141000000b0039aa4d054e2so654757wmh.1 for ; Mon, 30 May 2022 23:58:09 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id n187-20020a1c27c4000000b0039c151298b7sm1279153wmn.10.2022.05.30.23.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:58:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04acad78-e0af-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CEpuS4nyL9xBeJ8gWg6KUIfHgSQdlLCHmTciU0vGv5I=; b=OtHXDSEXHUywGqt/aOY4wMPgBa0YKJSXraa0I4Y0zE+D1Z3DNEYumIlw/7ZKY4Rvnu 4G4XGLBLOwhl2l9RxwlWY+xHtvrhS7WEfsWYZFafQQElJEFkBBJpVRMcAu6YEWPDwHJX Lq63srqShfnyPTvUPcjO9pBqPy9/KIlfFqA1b5+DtXOgmQM+YygIeyH3FdswKFIudoUj Uy69c0gKEAECpcwUO+PCbBgJCHrE7ASss++GOJ+6xazwAfVtGHEOQ11uAs/R/wIgGgCe akH+Y08AbUh2N20c/e0VaLbJX4wMuoeFehbrkdpWmOq3C9gTFWcpscCDI4xxz9kvRbjd qV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CEpuS4nyL9xBeJ8gWg6KUIfHgSQdlLCHmTciU0vGv5I=; b=1VN5D13cFogFC7fKEFL1gxOxgzzBs7l2LcDUuLCktQ1dOwbUDIJXqs7E4IdJsTQUgE YnK3DudAuoROoUVLkku8Qn6er8Dpi5Er4myMHx171IQPIKveBsVixtSZnJfLiGVyit9g FAnqkjYFVm/FbiLoJtOEFP1+L8QDSyuCxc17DBU40ZrFfB85wlZYduuf7idgUpRngvXo q7HhSAHLpU7xh1t468tf/2UUe6uknHE8ldImcYE7HTR1S2b4V8cTsUuairswKzsxfsDJ 6nt4Gr3LrdtWPWS86wx9+SJiS1okE9Irh+4Pl3nqamfrmf338qI98ai+U1kj1XlrGFBw eKig== X-Gm-Message-State: AOAM531QEgvLVGRmB8NrGztUtFzbIsNJy1dJ8fBSG+DrIlRDA8ifcl4i Ga6iMkO3rZrnPhS6TmAWmLn1OHvDqm8= X-Google-Smtp-Source: ABdhPJwxB+/No5F95vSmzrt4YN9i3rg7L4H8aG4oml3GEuLelptEEhBsfCTROm6wewZ1UdIQl8RS8w== X-Received: by 2002:a1c:e903:0:b0:397:36b8:795a with SMTP id q3-20020a1ce903000000b0039736b8795amr22807136wmc.98.1653980288810; Mon, 30 May 2022 23:58:08 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis Subject: [RFC PATCH 3/6] xen/riscv: Add head.S Date: Tue, 31 May 2022 14:57:09 +0800 Message-Id: <0829a14c1fab18619fc0ef53cda6387e8bc09d1e.1653977696.git.xiexun162534@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit head.S initializes bss, calls _setup_initial_pagetables to set up initial page tables, switch from load address to virtual address, and jump to C entry start_xen. Signed-off-by: Xie Xun --- xen/arch/riscv/riscv64/head.S | 206 ++++++++++++++++++++++++++++++++++ 1 file changed, 206 insertions(+) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 5cccab09c7..66c44cadf7 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -7,7 +7,213 @@ .section .text.header, "ax", %progbits ENTRY(start) + /* Mask all interrupts */ + csrw CSR_SIE, zero + + /* + * Disable FPU to detect illegal usage of + * floating point in kernel space + */ + li t0, SSTATUS_FS + csrc CSR_SSTATUS, t0 + + /* Save HART ID and DTB base */ + lla a6, _bootcpu_reg0 + REG_S a0, (a6) + lla a6, _bootcpu_reg1 + REG_S a1, (a6) + + /* + * Select CPU 0, hang the rest. + * TODO: support SMP + */ + lla a3, hart_lottery + li a2, 1 + amoadd.w a3, a2, (a3) + bnez a3, _start_hang + +_save_load_addresses: + /* Save load addresses + * a2 -> load start + * a3 -> load end + * a4 -> execution start + * a5 -> execution end + */ + lla a2, _start + lla a6, __exec_start + REG_L a4, (a6) + lla a6, __exec_end + REG_L a5, (a6) + sub a6, a5, a4 + add a3, a2, a6 + lla a6, _load_start + REG_S a2, (a6) + lla a6, _load_end + REG_S a3, (a6) + lla a6, _end + REG_S a3, (a6) + +_bss_zero_start: + /* Zero-out bss section */ + lla a6, __bss_start + REG_L a0, (a6) + sub a0, a0, a4 + add a0, a0, a2 + lla a6, __bss_end + REG_L a1, (a6) + sub a1, a1, a4 + add a1, a1, a2 +_bss_zero_loop: + REG_S zero, (a0) + add a0, a0, __SIZEOF_POINTER__ + blt a0, a1, _bss_zero_loop + + /* Setup temporary stack */ + lla a6, __hvc_stack_end + REG_L a0, (a6) + sub a0, a0, a4 + add sp, a0, a2 + + /* Setup hang for IRQ vector w/ virtual address */ + lla a6, __debug_irq_vector + REG_L a4, (a6) + csrw CSR_STVEC, a4 + + /* Setup initial page table */ + lla a6, _load_start + REG_L a0, (a6) + lla a6, _load_end + REG_L a1, (a6) + lla a6, __exec_start + REG_L a2, (a6) + lla a6, __exec_end + REG_L a3, (a6) + call _setup_initial_pagetables + + lla a0, _bootcpu_reg0 + REG_L a0, (a0) + +/* a0 must equal the hartid */ +_set_xen_tp: + /* Load pcpu_info[NR_CPUS] address */ + lla a6, pcpu_info + + /* Adjust by phys_offset so it doesn't require the identity map */ + lla a7, phys_offset + REG_L a7, (a7) + sub a6, a6, a7 + + /* Index into pcpu_info array with hartid */ + li a7, PCPUINFO_sizeof + mul a7, a7, a0 + add a6, a6, a7 + + /* Set tp = &pcpu_info[hartid] */ + add tp, a6, zero + + /* set processor id of pcpu_info[hartid].processor_id */ + REG_S a0, RISCV_PCPUINFO_OFFSET(processor_id)(tp) + + /* Move stack pointer */ + lla t0, phys_offset + REG_L t0, (t0) + sub sp, sp, t0 + + + j _start_secondary_nopen + + .align 3 +_start_lottery: + RISCV_PTR 0 + .align 3 +__start_secondary_pen_release: + RISCV_PTR start_secondary_pen_release + + /* + * Note: From this point primary CPU startup is same as secondary CPU + */ +_start_secondary_nopen: + /* Set trap vector to spin forever to help debug */ + //lla a6, _start_hang + //csrw CSR_STVEC, a6 + + /* Jump to final execution address */ + lla a6, __cpu_init + REG_L a0, (a6) + jalr a0 + + .align 4 _start_hang: wfi j _start_hang + + .align 3 +__phys_offset: + RISCV_PTR phys_offset +__pgtbl_root: + RISCV_PTR xen_second_pagetable +__exec_start: + RISCV_PTR _code_start +__exec_end: + RISCV_PTR _code_end +__bss_start: + RISCV_PTR _bss_start +__bss_end: + RISCV_PTR _bss_end +__debug_irq_vector: + RISCV_PTR _start_hang +__cpu_init: + RISCV_PTR _cpu_init + + /* + * Boot register 0 passed by bootloader + */ + .globl _bootcpu_reg0 +_bootcpu_reg0: + RISCV_PTR 0x0 + + /* + * Boot register 1 passed by bootloader + */ + .globl _boot_reg1 +_bootcpu_reg1: + RISCV_PTR 0x0 + + /* + * Load start address storage + */ + .globl _load_start +_load_start: + RISCV_PTR 0x0 + + /* + * Load end address storage + */ + .globl _load_end +_load_end: + RISCV_PTR 0x0 + + .globl _end +_end: + RISCV_PTR 0x0 + + /* + * Exception stacks. + */ +__hvc_stack_end: + RISCV_PTR _hvc_stack_end + + .align 3 + .globl _cpu_init +_cpu_init: + /* Jump to C code */ + lla a6, _bootcpu_reg1 + REG_L a0, (a6) + lla a6, phys_offset + REG_L a1, (a6) + + call start_xen + + /* Hang !!! */ + j _start_hang ENDPROC(start) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339129.563973 (Exim 4.92) (envelope-from ) id 1nvvzj-0001I1-UQ; Tue, 31 May 2022 07:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339129.563973; Tue, 31 May 2022 07:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzj-0001FT-MS; Tue, 31 May 2022 07:08:47 +0000 Received: by outflank-mailman (input) for mailman id 339129; Tue, 31 May 2022 06:58:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvph-00080v-IZ for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:58:25 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0dfd4e5c-e0af-11ec-837f-e5687231ffcc; Tue, 31 May 2022 08:58:20 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id m32-20020a05600c3b2000b0039756bb41f2so628041wms.3 for ; Mon, 30 May 2022 23:58:24 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id d17-20020a05600c4c1100b0039771fbffcasm1222368wmp.21.2022.05.30.23.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:58:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0dfd4e5c-e0af-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xR88aQIK2zwu2ATjZh/yut3alhZFE53aCziDTvElipM=; b=e+fpZZdxcdgtkFmrHuonJoVhU1QO5uVLzNyppJdLUwvqOkkJ6rAkwKiEBpCxpCrstc xlMf9X3nj3n4Tf0VWvsinvl5lubDK+crb6a9D6jO6e/xywv87xBEiHaPY9GhJIEXQyqp btgY+6vCp/Y63Ya3sWM2YHHCNLPnHvnY8rqpviVljWZs95rq59oyVHf/v33NCelFwCGU g2CrBJ6AAn06tocKDmIcvY49B9jfaAqTbp5zmwJnViJl5bS/QwF5nKE/mo2dwOLm69tu PMq0/Mmv15gJFaLhfypUip9xq771NCi6H+GRwZfjoxt4NV3MIC+dV/1Sx1Fp3LeflGXy KAVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xR88aQIK2zwu2ATjZh/yut3alhZFE53aCziDTvElipM=; b=tsnq2SwBKOQ1Sy+yyffY8rNHy9nM2Q1/1IQTaEbL758rs3KUHyvbxGoH1CVUe71lmF v7qtokzzY3KZDqU+KuZEfa3qJYwyRjB9Dc1owup3qmGjgdAxJdYKLYNicuE5ojAJAXRK ELuDtkHbk7/BLgcX+mfMjnp0lmpkxy1J1f370EBpcT/J/fvld1J9cp0Z2WjxNArra92v YZGX2D9icx8A1YWzoO7or6Ps4UtmUioAuZc5zKsVdJ8LZReVw85iMAjfsh1Va286my+m d3UmwMV6SYCNO8s1v37BouG63KA6ln8NsdlqLXDqSBPR+gaZ3MF3zdLdZEpI/j47p+LJ 9J+g== X-Gm-Message-State: AOAM530duEXJOJTJUE6YS9+q8TROKsgibt/ZY3HLn/pG/Ypnkl06pLXw TMU4xhPPzZyjqsAw6RiL80xRMF+2eWY= X-Google-Smtp-Source: ABdhPJzpaCVD81IDg92fh2kKoJHqIQ6L1Nbta3AzK3lRcy2F9RO3vdQOsPzyIqWeXy0SQL3SNyD5uQ== X-Received: by 2002:a05:600c:3583:b0:397:3d93:75b8 with SMTP id p3-20020a05600c358300b003973d9375b8mr21570409wmq.76.1653980304447; Mon, 30 May 2022 23:58:24 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis Subject: [RFC PATCH 5/6] xen/riscv: Add early_printk Date: Tue, 31 May 2022 14:57:11 +0800 Message-Id: <016c56548eee75c2b713ef90e4069690c0ae11cb.1653977696.git.xiexun162534@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Xie Xun --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 48 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 10 +++++ 3 files changed, 59 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index c61349818f..f9abc8401b 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -3,6 +3,7 @@ obj-y += lib/ obj-y += domctl.o obj-y += domain.o obj-y += delay.o +obj-y += early_printk.o obj-y += guestcopy.o obj-y += irq.o obj-y += p2m.o diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..81d69add01 --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,48 @@ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include +#include +#include + +void _early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if (*s == '\n') + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +static void vprintk_early(const char *prefix, const char *fmt, va_list args) +{ + char buf[128]; + int sz; + + early_puts(prefix); + + sz = vscnprintf(buf, sizeof(buf), fmt, args); + + if ( sz < 0 ) { + early_puts("(XEN) vprintk_early error\n"); + return; + } + + if ( sz == 0 ) + return; + + _early_puts(buf, sz); +} + +void early_printk(const char *fmt, ...) +{ + va_list args; + va_start(args, fmt); + vprintk_early("(XEN) ", fmt, args); + va_end(args); +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..0d9928b333 --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,10 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#define early_puts(s) _early_puts((s), strlen((s))) +void _early_puts(const char *s, size_t nr); +void early_printk(const char *fmt, ...); + +#endif /* __EARLY_PRINTK_H__ */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339121.563942 (Exim 4.92) (envelope-from ) id 1nvvzi-0000ju-8G; Tue, 31 May 2022 07:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339121.563942; Tue, 31 May 2022 07:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzi-0000hp-3y; Tue, 31 May 2022 07:08:46 +0000 Received: by outflank-mailman (input) for mailman id 339121; Tue, 31 May 2022 06:57:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvpF-00080v-3m for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:57:57 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa89a466-e0ae-11ec-837f-e5687231ffcc; Tue, 31 May 2022 08:57:47 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id y24so7449003wmq.5 for ; Mon, 30 May 2022 23:57:52 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id 26-20020a05600c029a00b0039bc95cf4b2sm1243406wmk.11.2022.05.30.23.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:57:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa89a466-e0ae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EiUUvhcfkzFNIN2pfXahh8nCsRZ1m3WiWE9lRsHcZsk=; b=VcRwHCjMvMtez13ud8hj+4fCW0qa7ar6vPcP0SsTRSO4KC8aPlt2ArJj07u56Ns9to HSeJyWehj4AywLY2N4nZuG1opWmAMTiPZEhP60uSSneqA2L4b2bosmAv/hbQ8bnBlErk Vp+MgFv/q8D6ep70OLILyfiWwx9bjfGrSd7HKOCWxbIiZTUQmDh7jJW9vZNQO25cw0A8 pSti006F0p/04QG4GONP8Pe+V9YRRyC/KxwLw9ICa4eCvJAtZP3n1FBBWQARjYyqPq36 IoOwKVQdI6MOfvFCxpBpKqmZyVgdvZA5EZvinZD4vqSkYcR4AFsrThau2ldzgkf3iH7/ yCbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EiUUvhcfkzFNIN2pfXahh8nCsRZ1m3WiWE9lRsHcZsk=; b=psYBqDZIfCDP3iLIBn4+9iE3ZFx8zFS5P4gtTUBYD9SG6LNy1UYjZucO6989sBwNju chYZ7h7R/iMn74DcU3RKyHvBgii+GotN8XNDSScABN/JEhc0QWHzMMaVBAkmLE06e03D 06+k7uXfoDhJuNd1itLOypbvBIg2IaUE0bSLHMRgnB3ciFlZI0RLV3NdtbjnQJJHUfWY 2vrSaFiT1/AvF6VkFkRIRSmq1OOgYA+eDKIF5g+DSkQEUZavj6Me2/+Ma88F8vqhxY19 9bUT8QRKYSiFh1eRLm+pZnLuDp6txquZMmFyOHaDTFstGIBHRbKUZ+5kN1aW/3eREh7h IiVw== X-Gm-Message-State: AOAM531PDPfvbKMj7wMbZZfIWdDX5nXSYvcGyt6ybC1J8kutRU4HyKxC mSBp9eL9FwYDcjv7IWO7XDbMHbYLBVKchA== X-Google-Smtp-Source: ABdhPJxpbTH8tzTIkAlBTsnqASJHI1Mh3WR0XiJbXczBo9TkKJ/7sGbMom+NgrMQKTgisYskIRjR3A== X-Received: by 2002:a05:600c:3b2a:b0:397:3e63:3db8 with SMTP id m42-20020a05600c3b2a00b003973e633db8mr21452000wms.40.1653980270851; Mon, 30 May 2022 23:57:50 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Juergen Gross Subject: [RFC PATCH 1/6] xen/riscv: Add necessary headers and definitions to build xen. Date: Tue, 31 May 2022 14:57:07 +0800 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Target xen and xen-syms can be built with: $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- It can be tested with Qemu. $ qemu-system-riscv64 -machine virt -m 1G -kernel xen Xen will jump into an infinite loop and there will be no output. Signed-off-by: Xie Xun --- xen/arch/riscv/Kconfig | 2 + xen/arch/riscv/Makefile | 51 ++ xen/arch/riscv/Rules.mk | 57 ++ xen/arch/riscv/delay.c | 14 + xen/arch/riscv/domain.c | 191 ++++ xen/arch/riscv/domctl.c | 52 ++ xen/arch/riscv/guestcopy.c | 59 ++ xen/arch/riscv/include/asm/acpi.h | 9 + xen/arch/riscv/include/asm/altp2m.h | 39 + xen/arch/riscv/include/asm/asm.h | 76 ++ xen/arch/riscv/include/asm/atomic.h | 375 ++++++++ xen/arch/riscv/include/asm/bitops.h | 397 ++++++++ xen/arch/riscv/include/asm/bug.h | 67 ++ xen/arch/riscv/include/asm/byteorder.h | 16 + xen/arch/riscv/include/asm/cache.h | 24 + xen/arch/riscv/include/asm/cmpxchg.h | 382 ++++++++ xen/arch/riscv/include/asm/config.h | 149 ++- xen/arch/riscv/include/asm/cpufeature.h | 68 ++ xen/arch/riscv/include/asm/csr.h | 81 ++ xen/arch/riscv/include/asm/current.h | 41 + xen/arch/riscv/include/asm/debugger.h | 15 + xen/arch/riscv/include/asm/delay.h | 28 + xen/arch/riscv/include/asm/desc.h | 12 + xen/arch/riscv/include/asm/device.h | 93 ++ xen/arch/riscv/include/asm/div64.h | 23 + xen/arch/riscv/include/asm/domain.h | 80 ++ xen/arch/riscv/include/asm/event.h | 42 + xen/arch/riscv/include/asm/fence.h | 12 + xen/arch/riscv/include/asm/flushtlb.h | 56 ++ xen/arch/riscv/include/asm/grant_table.h | 93 ++ xen/arch/riscv/include/asm/guest_access.h | 125 +++ xen/arch/riscv/include/asm/guest_atomics.h | 62 ++ xen/arch/riscv/include/asm/hardirq.h | 27 + xen/arch/riscv/include/asm/hypercall.h | 12 + xen/arch/riscv/include/asm/init.h | 42 + xen/arch/riscv/include/asm/io.h | 283 ++++++ xen/arch/riscv/include/asm/iocap.h | 16 + xen/arch/riscv/include/asm/iommu.h | 46 + xen/arch/riscv/include/asm/iommu_fwspec.h | 68 ++ xen/arch/riscv/include/asm/irq.h | 62 ++ xen/arch/riscv/include/asm/mem_access.h | 35 + xen/arch/riscv/include/asm/mm.h | 320 +++++++ xen/arch/riscv/include/asm/monitor.h | 65 ++ xen/arch/riscv/include/asm/nospec.h | 25 + xen/arch/riscv/include/asm/numa.h | 41 + xen/arch/riscv/include/asm/p2m.h | 307 +++++++ xen/arch/riscv/include/asm/page-bits.h | 14 + xen/arch/riscv/include/asm/page.h | 319 +++++++ xen/arch/riscv/include/asm/paging.h | 16 + xen/arch/riscv/include/asm/pci.h | 31 + xen/arch/riscv/include/asm/percpu.h | 35 + xen/arch/riscv/include/asm/processor.h | 176 ++++ xen/arch/riscv/include/asm/random.h | 9 + xen/arch/riscv/include/asm/regs.h | 42 + xen/arch/riscv/include/asm/riscv_encoding.h | 960 ++++++++++++++++++++ xen/arch/riscv/include/asm/setup.h | 23 + xen/arch/riscv/include/asm/smp.h | 69 ++ xen/arch/riscv/include/asm/softirq.h | 16 + xen/arch/riscv/include/asm/spinlock.h | 13 + xen/arch/riscv/include/asm/string.h | 28 + xen/arch/riscv/include/asm/system.h | 98 ++ xen/arch/riscv/include/asm/time.h | 81 ++ xen/arch/riscv/include/asm/trace.h | 12 + xen/arch/riscv/include/asm/traps.h | 30 + xen/arch/riscv/include/asm/types.h | 73 ++ xen/arch/riscv/include/asm/vm_event.h | 63 ++ xen/arch/riscv/include/asm/xenoprof.h | 12 + xen/arch/riscv/irq.c | 126 +++ xen/arch/riscv/lib/Makefile | 1 + xen/arch/riscv/lib/find_next_bit.c | 285 ++++++ xen/arch/riscv/mm.c | 409 +++++++++ xen/arch/riscv/p2m.c | 97 ++ xen/arch/riscv/percpu.c | 84 ++ xen/arch/riscv/platforms/Kconfig | 31 + xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/asm-offsets.c | 39 + xen/arch/riscv/riscv64/head.S | 13 +- xen/arch/riscv/setup.c | 65 ++ xen/arch/riscv/shutdown.c | 24 + xen/arch/riscv/smp.c | 38 + xen/arch/riscv/smpboot.c | 78 ++ xen/arch/riscv/sysctl.c | 31 + xen/arch/riscv/time.c | 69 ++ xen/arch/riscv/traps.c | 87 ++ xen/arch/riscv/vm_event.c | 51 ++ xen/arch/riscv/xen.lds.S | 274 ++++++ xen/include/public/arch-riscv.h | 182 ++++ xen/include/public/arch-riscv/hvm/save.h | 39 + xen/include/public/hvm/save.h | 2 + xen/include/public/io/protocols.h | 3 + xen/include/public/pmu.h | 2 + xen/include/public/xen.h | 2 + 92 files changed, 8286 insertions(+), 8 deletions(-) create mode 100644 xen/arch/riscv/delay.c create mode 100644 xen/arch/riscv/domain.c create mode 100644 xen/arch/riscv/domctl.c create mode 100644 xen/arch/riscv/guestcopy.c create mode 100644 xen/arch/riscv/include/asm/acpi.h create mode 100644 xen/arch/riscv/include/asm/altp2m.h create mode 100644 xen/arch/riscv/include/asm/asm.h create mode 100644 xen/arch/riscv/include/asm/atomic.h create mode 100644 xen/arch/riscv/include/asm/bitops.h create mode 100644 xen/arch/riscv/include/asm/bug.h create mode 100644 xen/arch/riscv/include/asm/byteorder.h create mode 100644 xen/arch/riscv/include/asm/cache.h create mode 100644 xen/arch/riscv/include/asm/cmpxchg.h create mode 100644 xen/arch/riscv/include/asm/cpufeature.h create mode 100644 xen/arch/riscv/include/asm/csr.h create mode 100644 xen/arch/riscv/include/asm/current.h create mode 100644 xen/arch/riscv/include/asm/debugger.h create mode 100644 xen/arch/riscv/include/asm/delay.h create mode 100644 xen/arch/riscv/include/asm/desc.h create mode 100644 xen/arch/riscv/include/asm/device.h create mode 100644 xen/arch/riscv/include/asm/div64.h create mode 100644 xen/arch/riscv/include/asm/domain.h create mode 100644 xen/arch/riscv/include/asm/event.h create mode 100644 xen/arch/riscv/include/asm/fence.h create mode 100644 xen/arch/riscv/include/asm/flushtlb.h create mode 100644 xen/arch/riscv/include/asm/grant_table.h create mode 100644 xen/arch/riscv/include/asm/guest_access.h create mode 100644 xen/arch/riscv/include/asm/guest_atomics.h create mode 100644 xen/arch/riscv/include/asm/hardirq.h create mode 100644 xen/arch/riscv/include/asm/hypercall.h create mode 100644 xen/arch/riscv/include/asm/init.h create mode 100644 xen/arch/riscv/include/asm/io.h create mode 100644 xen/arch/riscv/include/asm/iocap.h create mode 100644 xen/arch/riscv/include/asm/iommu.h create mode 100644 xen/arch/riscv/include/asm/iommu_fwspec.h create mode 100644 xen/arch/riscv/include/asm/irq.h create mode 100644 xen/arch/riscv/include/asm/mem_access.h create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/monitor.h create mode 100644 xen/arch/riscv/include/asm/nospec.h create mode 100644 xen/arch/riscv/include/asm/numa.h create mode 100644 xen/arch/riscv/include/asm/p2m.h create mode 100644 xen/arch/riscv/include/asm/page-bits.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/include/asm/paging.h create mode 100644 xen/arch/riscv/include/asm/pci.h create mode 100644 xen/arch/riscv/include/asm/percpu.h create mode 100644 xen/arch/riscv/include/asm/processor.h create mode 100644 xen/arch/riscv/include/asm/random.h create mode 100644 xen/arch/riscv/include/asm/regs.h create mode 100644 xen/arch/riscv/include/asm/riscv_encoding.h create mode 100644 xen/arch/riscv/include/asm/setup.h create mode 100644 xen/arch/riscv/include/asm/smp.h create mode 100644 xen/arch/riscv/include/asm/softirq.h create mode 100644 xen/arch/riscv/include/asm/spinlock.h create mode 100644 xen/arch/riscv/include/asm/string.h create mode 100644 xen/arch/riscv/include/asm/system.h create mode 100644 xen/arch/riscv/include/asm/time.h create mode 100644 xen/arch/riscv/include/asm/trace.h create mode 100644 xen/arch/riscv/include/asm/traps.h create mode 100644 xen/arch/riscv/include/asm/types.h create mode 100644 xen/arch/riscv/include/asm/vm_event.h create mode 100644 xen/arch/riscv/include/asm/xenoprof.h create mode 100644 xen/arch/riscv/irq.c create mode 100644 xen/arch/riscv/lib/Makefile create mode 100644 xen/arch/riscv/lib/find_next_bit.c create mode 100644 xen/arch/riscv/mm.c create mode 100644 xen/arch/riscv/p2m.c create mode 100644 xen/arch/riscv/percpu.c create mode 100644 xen/arch/riscv/platforms/Kconfig create mode 100644 xen/arch/riscv/setup.c create mode 100644 xen/arch/riscv/shutdown.c create mode 100644 xen/arch/riscv/smp.c create mode 100644 xen/arch/riscv/smpboot.c create mode 100644 xen/arch/riscv/sysctl.c create mode 100644 xen/arch/riscv/time.c create mode 100644 xen/arch/riscv/traps.c create mode 100644 xen/arch/riscv/vm_event.c create mode 100644 xen/arch/riscv/xen.lds.S create mode 100644 xen/include/public/arch-riscv.h create mode 100644 xen/include/public/arch-riscv/hvm/save.h diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig index 468e250c86..e8c9ae6219 100644 --- a/xen/arch/riscv/Kconfig +++ b/xen/arch/riscv/Kconfig @@ -1,5 +1,7 @@ config RISCV def_bool y + select HAS_PDX + select HAS_DEVICE_TREE config RISCV_64 def_bool y diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 942e4ffbc1..3a57556631 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,2 +1,53 @@ +obj-y += lib/ + +obj-y += domctl.o +obj-y += domain.o +obj-y += delay.o +obj-y += guestcopy.o +obj-y += irq.o +obj-y += p2m.o +obj-y += mm.o +obj-y += percpu.o +obj-y += setup.o +obj-y += shutdown.o +obj-y += smp.o +obj-y += smpboot.o +obj-y += sysctl.o +obj-y += traps.o +obj-y += time.o +obj-y += vm_event.o + +obj-y += $(TARGET_SUBARCH)/ + +#obj-bin-y += ....o + +$(TARGET): $(TARGET)-syms + $(OBJCOPY) -O binary -S $< $@ + +$(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ + $(objtree)/common/symbols-dummy.o -o $(@D)/.$(@F).0 + $(NM) -pa --format=sysv $(@D)/.$(@F).0 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).0.S + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).0.o + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ + $(@D)/.$(@F).0.o -o $(@D)/.$(@F).1 + $(NM) -pa --format=sysv $(@D)/.$(@F).1 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort >$(@D)/.$(@F).1.S + $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ + $(@D)/.$(@F).1.o -o $@ + $(NM) -pa --format=sysv $(@D)/$(@F) \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + >$(@D)/$(@F).map + rm -f $(@D)/.$(@F).[0-9]* + +$(obj)/xen.lds: $(src)/xen.lds.S FORCE + $(call if_changed_dep,cpp_lds_S) + +.PHONY: clean +clean:: + rm -f $(objtree)/.xen-syms.[0-9]* + .PHONY: include include: diff --git a/xen/arch/riscv/Rules.mk b/xen/arch/riscv/Rules.mk index e69de29bb2..85e0cc5e64 100644 --- a/xen/arch/riscv/Rules.mk +++ b/xen/arch/riscv/Rules.mk @@ -0,0 +1,57 @@ +######################################## +# riscv-specific definitions + +# +# If you change any of these configuration options then you must +# 'make clean' before rebuilding. +# + +CFLAGS += -I$(BASEDIR)/include + +$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-option-add,CFLAGS,CC,-Wnested-externs) +$(call cc-option-add,CFLAGS,CC,-mstrict-align) +$(call cc-option-add,CFLAGS,CC,-mtune=size) + +EARLY_PRINTK := n + +ifeq ($(CONFIG_DEBUG),y) + +# See docs/misc/arm/early-printk.txt for syntax + +EARLY_PRINTK := 8250,0x1c021000,2 + +ifneq ($(EARLY_PRINTK_$(CONFIG_EARLY_PRINTK)),) +EARLY_PRINTK_CFG := $(subst $(comma), ,$(EARLY_PRINTK_$(CONFIG_EARLY_PRINTK))) +else +EARLY_PRINTK_CFG := $(subst $(comma), ,$(CONFIG_EARLY_PRINTK)) +endif + +# Extract configuration from string +EARLY_PRINTK_INC := $(word 1,$(EARLY_PRINTK_CFG)) +EARLY_UART_BASE_ADDRESS := $(word 2,$(EARLY_PRINTK_CFG)) + +# UART specific options +ifeq ($(EARLY_PRINTK_INC),8250) +EARLY_UART_REG_SHIFT := $(word 3,$(EARLY_PRINTK_CFG)) +endif + +ifneq ($(EARLY_PRINTK_INC),) +EARLY_PRINTK := y +endif + +CFLAGS-$(EARLY_PRINTK) += -DCONFIG_EARLY_PRINTK +CFLAGS-$(EARLY_PRINTK_INIT_UART) += -DEARLY_PRINTK_INIT_UART +CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\" +CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD) +CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS) +CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT) + +else # !CONFIG_DEBUG + +ifneq ($(CONFIG_EARLY_PRINTK),) +# Early printk is dependant on a debug build. +$(error CONFIG_EARLY_PRINTK enabled for non-debug build) +endif + +endif diff --git a/xen/arch/riscv/delay.c b/xen/arch/riscv/delay.c new file mode 100644 index 0000000000..4a712e97e8 --- /dev/null +++ b/xen/arch/riscv/delay.c @@ -0,0 +1,14 @@ +void __delay(unsigned long cycles) +{ +} +EXPORT_SYMBOL(__delay); + +void udelay(unsigned long usecs) +{ +} +EXPORT_SYMBOL(udelay); + +void ndelay(unsigned long nsecs) +{ +} +EXPORT_SYMBOL(ndelay); diff --git a/xen/arch/riscv/domain.c b/xen/arch/riscv/domain.c new file mode 100644 index 0000000000..c99023731f --- /dev/null +++ b/xen/arch/riscv/domain.c @@ -0,0 +1,191 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +DEFINE_PER_CPU(struct vcpu *, curr_vcpu); + +struct vcpu *alloc_dom0_vcpu0(struct domain *dom0) +{ + return vcpu_create(dom0, 0); +} + +void context_switch(struct vcpu *prev, struct vcpu *next) +{ + /* TODO */ +} + +void idle_loop(void) +{ + /* TODO */ +} + +void noreturn startup_cpu_idle_loop(void) +{ + struct vcpu *v = current; + + ASSERT(is_idle_vcpu(v)); + + reset_stack_and_jump(idle_loop); + + /* This function is noreturn */ + BUG(); +} + +void continue_running(struct vcpu *same) +{ + /* TODO */ +} + +void sync_local_execstate(void) +{ + /* TODO */ +} + +void sync_vcpu_execstate(struct vcpu *v) +{ + /* TODO */ +} + +unsigned long hypercall_create_continuation( + unsigned int op, const char *format, ...) +{ + /* TODO */ + + return 0; +} + +struct domain *alloc_domain_struct(void) +{ + return NULL; +} + +void free_domain_struct(struct domain *d) +{ + /* TODO */ +} + +void dump_pageframe_info(struct domain *d) +{ + /* TODO */ +} + +int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) +{ + return 0; +} + + +int arch_domain_create(struct domain *d, + struct xen_domctl_createdomain *config, + unsigned int flags) +{ + return -ENOSYS; +} + +void arch_domain_destroy(struct domain *d) +{ + /* TODO */ +} + +void arch_domain_shutdown(struct domain *d) +{ + /* TODO */ +} + +void arch_domain_pause(struct domain *d) +{ + /* TODO */ +} + +void arch_domain_unpause(struct domain *d) +{ + /* TODO */ +} + +int arch_domain_soft_reset(struct domain *d) +{ + /* TODO */ + return -ENOSYS; +} + +void arch_domain_creation_finished(struct domain *d) +{ + /* TODO */ +} + +int domain_relinquish_resources(struct domain *d) +{ + /* TODO */ + return -ENOSYS; +} + +void arch_dump_domain_info(struct domain *d) +{ + /* TODO */ +} + +long arch_do_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) +{ + /* TODO */ + return -ENOSYS; +} + +void arch_dump_vcpu_info(struct vcpu *v) +{ + /* TODO */ +} + +int arch_set_info_guest( + struct vcpu *v, vcpu_guest_context_u c) +{ + /* TODO */ + return -ENOSYS; +} + +/* taken from arm/domain.c */ +struct vcpu *alloc_vcpu_struct(const struct domain *d) +{ + return NULL; +} + +void free_vcpu_struct(struct vcpu *v) +{ + /* TODO */ +} + +int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) +{ + /* TODO */ + return -ENOSYS; +} + +int arch_vcpu_reset(struct vcpu *v) +{ + /* TODO */ + return -ENOSYS; +} + +int arch_vcpu_create(struct vcpu *v) +{ + return -ENOSYS; +} + +void arch_vcpu_destroy(struct vcpu *v) +{ + /* TODO */ +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/domctl.c b/xen/arch/riscv/domctl.c new file mode 100644 index 0000000000..5024118662 --- /dev/null +++ b/xen/arch/riscv/domctl.c @@ -0,0 +1,52 @@ +/****************************************************************************** + * Arch-specific domctl.c + * + * Copyright (c) 2012, Citrix Systems + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +void arch_get_domain_info(const struct domain *d, + struct xen_domctl_getdomaininfo *info) +{ + info->flags |= XEN_DOMINF_hap; +} + +long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, + XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) +{ + /* TODO */ + + switch ( domctl->cmd ) { + case XEN_DOMCTL_cacheflush: + case XEN_DOMCTL_bind_pt_irq: + case XEN_DOMCTL_unbind_pt_irq: + case XEN_DOMCTL_vuart_op: + default: + return 0; + } +} + +void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c) +{ + /* TODO */ +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/guestcopy.c b/xen/arch/riscv/guestcopy.c new file mode 100644 index 0000000000..76d6a82409 --- /dev/null +++ b/xen/arch/riscv/guestcopy.c @@ -0,0 +1,59 @@ +#include +#include +#include + +unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len) +{ + return -ENOSYS; +} + +unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, + unsigned len) +{ + return -ENOSYS; +} + +unsigned long raw_clear_guest(void *to, unsigned len) +{ + return -ENOSYS; +} + +unsigned long raw_copy_from_guest(void *to, const void __user *from, unsigned len) +{ + return -ENOSYS; +} + +unsigned long copy_to_guest_phys(struct domain *d, + paddr_t gpa, + void *buf, + unsigned int len) +{ + return -ENOSYS; +} + + +/** + * riscv_vcpu_unpriv_read -- Read machine word from Guest memory + * + * @vcpu: The VCPU pointer + * @read_insn: Flag representing whether we are reading instruction + * @guest_addr: Guest address to read + * @trap: Output pointer to trap details + */ +unsigned long riscv_vcpu_unpriv_read(struct vcpu *vcpu, + bool read_insn, + unsigned long guest_addr, + struct riscv_trap *trap) +{ + /* TODO */ + return -ENOSYS; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/acpi.h b/xen/arch/riscv/include/asm/acpi.h new file mode 100644 index 0000000000..efede99d65 --- /dev/null +++ b/xen/arch/riscv/include/asm/acpi.h @@ -0,0 +1,9 @@ +#ifndef _ASM_RISCV_ACPI_H +#define _ASM_RISCV_ACPI_H + +#include + +extern bool acpi_disabled; + + +#endif /*_ASM_RISCV_ACPI_H*/ diff --git a/xen/arch/riscv/include/asm/altp2m.h b/xen/arch/riscv/include/asm/altp2m.h new file mode 100644 index 0000000000..8554495f94 --- /dev/null +++ b/xen/arch/riscv/include/asm/altp2m.h @@ -0,0 +1,39 @@ +/* + * Alternate p2m + * + * Copyright (c) 2014, Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#ifndef __ASM_RISCV_ALTP2M_H +#define __ASM_RISCV_ALTP2M_H + +#include + +/* Alternate p2m on/off per domain */ +static inline bool altp2m_active(const struct domain *d) +{ + /* Not implemented on RISCV. */ + return false; +} + +/* Alternate p2m VCPU */ +static inline uint16_t altp2m_vcpu_idx(const struct vcpu *v) +{ + /* Not implemented on RISCV, should not be reached. */ + BUG(); + return 0; +} + +#endif /* __ASM_RISCV_ALTP2M_H */ diff --git a/xen/arch/riscv/include/asm/asm.h b/xen/arch/riscv/include/asm/asm.h new file mode 100644 index 0000000000..5ad4cb622b --- /dev/null +++ b/xen/arch/riscv/include/asm/asm.h @@ -0,0 +1,76 @@ +/* + * Copyright (C) 2015 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_ASM_H +#define _ASM_RISCV_ASM_H + +#ifdef __ASSEMBLY__ +#define __ASM_STR(x) x +#else +#define __ASM_STR(x) #x +#endif + +#if __riscv_xlen == 64 +#define __REG_SEL(a, b) __ASM_STR(a) +#elif __riscv_xlen == 32 +#define __REG_SEL(a, b) __ASM_STR(b) +#else +#error "Unexpected __riscv_xlen" +#endif + +#define REG_L __REG_SEL(ld, lw) +#define REG_S __REG_SEL(sd, sw) +#define SZREG __REG_SEL(8, 4) +#define LGREG __REG_SEL(3, 2) + +#if __SIZEOF_POINTER__ == 8 +#ifdef __ASSEMBLY__ +#define RISCV_PTR .dword +#define RISCV_SZPTR 8 +#define RISCV_LGPTR 3 +#else +#define RISCV_PTR ".dword" +#define RISCV_SZPTR "8" +#define RISCV_LGPTR "3" +#endif +#elif __SIZEOF_POINTER__ == 4 +#ifdef __ASSEMBLY__ +#define RISCV_PTR .word +#define RISCV_SZPTR 4 +#define RISCV_LGPTR 2 +#else +#define RISCV_PTR ".word" +#define RISCV_SZPTR "4" +#define RISCV_LGPTR "2" +#endif +#else +#error "Unexpected __SIZEOF_POINTER__" +#endif + +#if (__SIZEOF_INT__ == 4) +#define RISCV_INT __ASM_STR(.word) +#define RISCV_SZINT __ASM_STR(4) +#define RISCV_LGINT __ASM_STR(2) +#else +#error "Unexpected __SIZEOF_INT__" +#endif + +#if (__SIZEOF_SHORT__ == 2) +#define RISCV_SHORT __ASM_STR(.half) +#define RISCV_SZSHORT __ASM_STR(2) +#define RISCV_LGSHORT __ASM_STR(1) +#else +#error "Unexpected __SIZEOF_SHORT__" +#endif + +#endif /* _ASM_RISCV_ASM_H */ diff --git a/xen/arch/riscv/include/asm/atomic.h b/xen/arch/riscv/include/asm/atomic.h new file mode 100644 index 0000000000..d4849cf282 --- /dev/null +++ b/xen/arch/riscv/include/asm/atomic.h @@ -0,0 +1,375 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Taken and modified from Linux. + * + * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved. + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2017 SiFive + * Copyright (C) 2021 Vates SAS + */ + +#ifndef _ASM_RISCV_ATOMIC_H +#define _ASM_RISCV_ATOMIC_H + +#include +#include +#include +#include +#include + +void __bad_atomic_size(void); + +static always_inline void read_atomic_size(const volatile void *p, + void *res, + unsigned int size) +{ + switch ( size ) { + case 1: *(uint8_t *)res = readb((uint8_t *)p); break; + case 2: *(uint16_t *)res = readw((uint16_t *)p); break; + case 4: *(uint32_t *)res = readl((uint32_t *)p); break; + case 8: *(uint32_t *)res = readq((uint64_t *)p); break; + default: __bad_atomic_size(); break; + } +} + +#define read_atomic(p) ({ \ + union { typeof(*p) val; char c[0]; } x_; \ + read_atomic_size(p, x_.c, sizeof(*p)); \ + x_.val; \ +}) + + +#define write_atomic(p, x) ({ \ + typeof(*p) __x = (x); \ + switch ( sizeof(*p) ) { \ + case 1: writeb((uint8_t)__x, (uint8_t *) p); break; \ + case 2: writew((uint16_t)__x, (uint16_t *) p); break; \ + case 4: writel((uint32_t)__x, (uint32_t *) p); break; \ + case 8: writeq((uint64_t)__x, (uint64_t *) p); break; \ + default: __bad_atomic_size(); break; \ + } \ + __x; \ +}) + +/* TODO: Fix this */ +#define add_sized(p, x) ({ \ + typeof(*(p)) __x = (x); \ + switch ( sizeof(*(p)) ) \ + { \ + case 1: writeb(read_atomic(p) + __x, (uint8_t *)(p)); break; \ + case 2: writew(read_atomic(p) + __x, (uint16_t *)(p)); break; \ + case 4: writel(read_atomic(p) + __x, (uint32_t *)(p)); break; \ + default: __bad_atomic_size(); break; \ + } \ +}) + +/* + * __unqual_scalar_typeof(x) - Declare an unqualified scalar type, leaving + * non-scalar types unchanged. + * + * Prefer C11 _Generic for better compile-times and simpler code. Note: 'char' + * is not type-compatible with 'signed char', and we define a separate case. + */ +#define __scalar_type_to_expr_cases(type) \ + unsigned type: (unsigned type)0, \ + signed type: (signed type)0 + +#define __unqual_scalar_typeof(x) typeof( \ + _Generic((x), \ + char: (char)0, \ + __scalar_type_to_expr_cases(char), \ + __scalar_type_to_expr_cases(short), \ + __scalar_type_to_expr_cases(int), \ + __scalar_type_to_expr_cases(long), \ + __scalar_type_to_expr_cases(long long), \ + default: (x))) + +#define READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x)) +#define WRITE_ONCE(x, val) \ + do { \ + *(volatile typeof(x) *)&(x) = (val); \ + } while (0) + +#define __atomic_acquire_fence() \ + __asm__ __volatile__(RISCV_ACQUIRE_BARRIER "" ::: "memory") + +#define __atomic_release_fence() \ + __asm__ __volatile__(RISCV_RELEASE_BARRIER "" ::: "memory"); + +static inline int atomic_read(const atomic_t *v) +{ + return READ_ONCE(v->counter); +} + +static inline int _atomic_read(atomic_t v) +{ + return v.counter; +} + +static inline void atomic_set(atomic_t *v, int i) +{ + WRITE_ONCE(v->counter, i); +} + +static inline void _atomic_set(atomic_t *v, int i) +{ + v->counter = i; +} + +static inline int atomic_sub_and_test(int i, atomic_t *v) +{ + return atomic_sub_return(i, v) == 0; +} + +static inline void atomic_inc(atomic_t *v) +{ + atomic_add(1, v); +} + +static inline int atomic_inc_return(atomic_t *v) +{ + return atomic_add_return(1, v); +} + +static inline void atomic_dec(atomic_t *v) +{ + atomic_sub(1, v); +} + +static inline int atomic_dec_return(atomic_t *v) +{ + return atomic_sub_return(1, v); +} + + +static inline int atomic_dec_and_test(atomic_t *v) +{ + return atomic_sub_return(1, v) == 0; +} + +static inline int atomic_add_negative(int i, atomic_t *v) +{ + return atomic_add_return(i, v) < 0; +} + +static inline int atomic_inc_and_test(atomic_t *v) +{ + return atomic_add_return(1, v) == 0; +} + +/* + * First, the atomic ops that have no ordering constraints and therefor don't + * have the AQ or RL bits set. These don't return anything, so there's only + * one version to worry about. + */ +#define ATOMIC_OP(op, asm_op, I, asm_type, c_type, prefix) \ +static inline \ +void atomic##prefix##_##op(c_type i, atomic##prefix##_t *v) \ +{ \ + __asm__ __volatile__ ( \ + " amo" #asm_op "." #asm_type " zero, %1, %0" \ + : "+A" (v->counter) \ + : "r" (I) \ + : "memory"); \ +} \ + +#define ATOMIC_OPS(op, asm_op, I) \ + ATOMIC_OP (op, asm_op, I, w, int, ) + +ATOMIC_OPS(add, add, i) +ATOMIC_OPS(sub, add, -i) +ATOMIC_OPS(and, and, i) +ATOMIC_OPS( or, or, i) +ATOMIC_OPS(xor, xor, i) + +#undef ATOMIC_OP +#undef ATOMIC_OPS + +/* + * Atomic ops that have ordered, relaxed, acquire, and release variants. + * There's two flavors of these: the arithmatic ops have both fetch and return + * versions, while the logical ops only have fetch versions. + */ +#define ATOMIC_FETCH_OP(op, asm_op, I, asm_type, c_type, prefix) \ +static inline \ +c_type atomic##prefix##_fetch_##op##_relaxed(c_type i, \ + atomic##prefix##_t *v) \ +{ \ + register c_type ret; \ + __asm__ __volatile__ ( \ + " amo" #asm_op "." #asm_type " %1, %2, %0" \ + : "+A" (v->counter), "=r" (ret) \ + : "r" (I) \ + : "memory"); \ + return ret; \ +} \ +static inline \ +c_type atomic##prefix##_fetch_##op(c_type i, atomic##prefix##_t *v) \ +{ \ + register c_type ret; \ + __asm__ __volatile__ ( \ + " amo" #asm_op "." #asm_type ".aqrl %1, %2, %0" \ + : "+A" (v->counter), "=r" (ret) \ + : "r" (I) \ + : "memory"); \ + return ret; \ +} + +#define ATOMIC_OP_RETURN(op, asm_op, c_op, I, asm_type, c_type, prefix) \ +static inline \ +c_type atomic##prefix##_##op##_return_relaxed(c_type i, \ + atomic##prefix##_t *v) \ +{ \ + return atomic##prefix##_fetch_##op##_relaxed(i, v) c_op I; \ +} \ +static inline \ +c_type atomic##prefix##_##op##_return(c_type i, atomic##prefix##_t *v) \ +{ \ + return atomic##prefix##_fetch_##op(i, v) c_op I; \ +} + +#define ATOMIC_OPS(op, asm_op, c_op, I) \ + ATOMIC_FETCH_OP( op, asm_op, I, w, int, ) \ + ATOMIC_OP_RETURN(op, asm_op, c_op, I, w, int, ) + +ATOMIC_OPS(add, add, +, i) +ATOMIC_OPS(sub, add, +, -i) + +#define atomic_add_return_relaxed atomic_add_return_relaxed +#define atomic_sub_return_relaxed atomic_sub_return_relaxed +#define atomic_add_return atomic_add_return +#define atomic_sub_return atomic_sub_return + +#define atomic_fetch_add_relaxed atomic_fetch_add_relaxed +#define atomic_fetch_sub_relaxed atomic_fetch_sub_relaxed +#define atomic_fetch_add atomic_fetch_add +#define atomic_fetch_sub atomic_fetch_sub + +#undef ATOMIC_OPS + +#define ATOMIC_OPS(op, asm_op, I) \ + ATOMIC_FETCH_OP(op, asm_op, I, w, int, ) + +ATOMIC_OPS(and, and, i) +ATOMIC_OPS( or, or, i) +ATOMIC_OPS(xor, xor, i) + +#define atomic_fetch_and_relaxed atomic_fetch_and_relaxed +#define atomic_fetch_or_relaxed atomic_fetch_or_relaxed +#define atomic_fetch_xor_relaxed atomic_fetch_xor_relaxed +#define atomic_fetch_and atomic_fetch_and +#define atomic_fetch_or atomic_fetch_or +#define atomic_fetch_xor atomic_fetch_xor + +#undef ATOMIC_OPS + +#undef ATOMIC_FETCH_OP +#undef ATOMIC_OP_RETURN + +/* This is required to provide a full barrier on success. */ +static inline int atomic_add_unless(atomic_t *v, int a, int u) +{ + int prev, rc; + + __asm__ __volatile__ ( + "0: lr.w %[p], %[c]\n" + " beq %[p], %[u], 1f\n" + " add %[rc], %[p], %[a]\n" + " sc.w.rl %[rc], %[rc], %[c]\n" + " bnez %[rc], 0b\n" + " fence rw, rw\n" + "1:\n" + : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter) + : [a]"r" (a), [u]"r" (u) + : "memory"); + return prev; +} +#define atomic_fetch_add_unless atomic_fetch_add_unless + +/* + * atomic_{cmp,}xchg is required to have exactly the same ordering semantics as + * {cmp,}xchg and the operations that return, so they need a full barrier. + */ +#define ATOMIC_OP(c_t, prefix, size) \ +static inline \ +c_t atomic##prefix##_xchg_relaxed(atomic##prefix##_t *v, c_t n) \ +{ \ + return __xchg_relaxed(&(v->counter), n, size); \ +} \ +static inline \ +c_t atomic##prefix##_xchg_acquire(atomic##prefix##_t *v, c_t n) \ +{ \ + return __xchg_acquire(&(v->counter), n, size); \ +} \ +static inline \ +c_t atomic##prefix##_xchg_release(atomic##prefix##_t *v, c_t n) \ +{ \ + return __xchg_release(&(v->counter), n, size); \ +} \ +static inline \ +c_t atomic##prefix##_xchg(atomic##prefix##_t *v, c_t n) \ +{ \ + return __xchg(&(v->counter), n, size); \ +} \ +static inline \ +c_t atomic##prefix##_cmpxchg_relaxed(atomic##prefix##_t *v, \ + c_t o, c_t n) \ +{ \ + return __cmpxchg_relaxed(&(v->counter), o, n, size); \ +} \ +static inline \ +c_t atomic##prefix##_cmpxchg_acquire(atomic##prefix##_t *v, \ + c_t o, c_t n) \ +{ \ + return __cmpxchg_acquire(&(v->counter), o, n, size); \ +} \ +static inline \ +c_t atomic##prefix##_cmpxchg_release(atomic##prefix##_t *v, \ + c_t o, c_t n) \ +{ \ + return __cmpxchg_release(&(v->counter), o, n, size); \ +} \ +static inline \ +c_t atomic##prefix##_cmpxchg(atomic##prefix##_t *v, c_t o, c_t n) \ +{ \ + return __cmpxchg(&(v->counter), o, n, size); \ +} + +#define ATOMIC_OPS() \ + ATOMIC_OP(int, , 4) + +ATOMIC_OPS() + +#define atomic_xchg_relaxed atomic_xchg_relaxed +#define atomic_xchg_acquire atomic_xchg_acquire +#define atomic_xchg_release atomic_xchg_release +#define atomic_xchg atomic_xchg +#define atomic_cmpxchg_relaxed atomic_cmpxchg_relaxed +#define atomic_cmpxchg_acquire atomic_cmpxchg_acquire +#define atomic_cmpxchg_release atomic_cmpxchg_release +#define atomic_cmpxchg atomic_cmpxchg + +#undef ATOMIC_OPS +#undef ATOMIC_OP + +static inline int atomic_sub_if_positive(atomic_t *v, int offset) +{ + int prev, rc; + + __asm__ __volatile__ ( + "0: lr.w %[p], %[c]\n" + " sub %[rc], %[p], %[o]\n" + " bltz %[rc], 1f\n" + " sc.w.rl %[rc], %[rc], %[c]\n" + " bnez %[rc], 0b\n" + " fence rw, rw\n" + "1:\n" + : [p]"=&r" (prev), [rc]"=&r" (rc), [c]"+A" (v->counter) + : [o]"r" (offset) + : "memory"); + return prev - offset; +} + +#define atomic_dec_if_positive(v) atomic_sub_if_positive(v, 1) + +#endif /* _ASM_RISCV_ATOMIC_H */ diff --git a/xen/arch/riscv/include/asm/bitops.h b/xen/arch/riscv/include/asm/bitops.h new file mode 100644 index 0000000000..edb0f35449 --- /dev/null +++ b/xen/arch/riscv/include/asm/bitops.h @@ -0,0 +1,397 @@ +/* + * Copyright (C) 2012 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_BITOPS_H +#define _ASM_RISCV_BITOPS_H + +#include + +#define BITS_PER_WORD 32 +#define BIT_ULL(nr) (1ULL << (nr)) +#define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG)) +#define BIT_WORD(nr) ((nr) / BITS_PER_LONG) +#define BIT_ULL_MASK(nr) (1ULL << ((nr) % BITS_PER_LONG_LONG)) +#define BIT_ULL_WORD(nr) ((nr) / BITS_PER_LONG_LONG) +#define BITS_PER_BYTE 8 + +#define __set_bit(n,p) set_bit(n,p) +#define __clear_bit(n,p) clear_bit(n,p) + +#ifndef smp_mb__before_clear_bit +#define smp_mb__before_clear_bit() smp_mb() +#define smp_mb__after_clear_bit() smp_mb() +#endif /* smp_mb__before_clear_bit */ + +#if (BITS_PER_LONG == 64) +#define __AMO(op) "amo" #op ".d" +#elif (BITS_PER_LONG == 32) +#define __AMO(op) "amo" #op ".w" +#else +#error "Unexpected BITS_PER_LONG" +#endif + +#define __test_and_op_bit_ord(op, mod, nr, addr, ord) \ +({ \ + unsigned long __res, __mask; \ + __mask = BIT_MASK(nr); \ + __asm__ __volatile__ ( \ + __AMO(op) #ord " %0, %2, %1" \ + : "=r" (__res), "+A" (addr[BIT_WORD(nr)]) \ + : "r" (mod(__mask)) \ + : "memory"); \ + ((__res & __mask) != 0); \ +}) + +#define __op_bit_ord(op, mod, nr, addr, ord) \ + __asm__ __volatile__ ( \ + __AMO(op) #ord " zero, %1, %0" \ + : "+A" (addr[BIT_WORD(nr)]) \ + : "r" (mod(BIT_MASK(nr))) \ + : "memory"); + +#define __test_and_op_bit(op, mod, nr, addr) \ + __test_and_op_bit_ord(op, mod, nr, addr, .aqrl) +#define __op_bit(op, mod, nr, addr) \ + __op_bit_ord(op, mod, nr, addr, ) + +/* Bitmask modifiers */ +#define __NOP(x) (x) +#define __NOT(x) (~(x)) + +/** + * __test_and_set_bit - Set a bit and return its old value + * @nr: Bit to set + * @addr: Address to count from + * + * This operation may be reordered on other architectures than x86. + */ +static inline int __test_and_set_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + return __test_and_op_bit(or, __NOP, nr, addr); +} + +/** + * __test_and_clear_bit - Clear a bit and return its old value + * @nr: Bit to clear + * @addr: Address to count from + * + * This operation can be reordered on other architectures other than x86. + */ +static inline int __test_and_clear_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + return __test_and_op_bit(and, __NOT, nr, addr); +} + +/** + * __test_and_change_bit - Change a bit and return its old value + * @nr: Bit to change + * @addr: Address to count from + * + * This operation is atomic and cannot be reordered. + * It also implies a memory barrier. + */ +static inline int __test_and_change_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + return __test_and_op_bit(xor, __NOP, nr, addr); +} + +/** + * set_bit - Atomically set a bit in memory + * @nr: the bit to set + * @addr: the address to start counting from + * + * Note: there are no guarantees that this function will not be reordered + * on non x86 architectures, so if you are writing portable code, + * make sure not to rely on its reordering guarantees. + * + * Note that @nr may be almost arbitrarily large; this function is not + * restricted to acting on a single-word quantity. + */ +static inline void set_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + __op_bit(or, __NOP, nr, addr); +} + +/** + * clear_bit - Clears a bit in memory + * @nr: Bit to clear + * @addr: Address to start counting from + * + * Note: there are no guarantees that this function will not be reordered + * on non x86 architectures, so if you are writing portable code, + * make sure not to rely on its reordering guarantees. + */ +static inline void clear_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + __op_bit(and, __NOT, nr, addr); +} + +static inline int test_bit(int nr, const volatile void *p) +{ + const volatile unsigned long *addr = (const volatile unsigned long *)p; + + return 1UL & (addr[BIT_WORD(nr)] >> (nr & (BITS_PER_LONG-1))); +} + +/** + * change_bit - Toggle a bit in memory + * @nr: Bit to change + * @addr: Address to start counting from + * + * change_bit() may be reordered on other architectures than x86. + * Note that @nr may be almost arbitrarily large; this function is not + * restricted to acting on a single-word quantity. + */ +static inline void change_bit(int nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + __op_bit(xor, __NOP, nr, addr); +} + +/** + * test_and_set_bit_lock - Set a bit and return its old value, for lock + * @nr: Bit to set + * @addr: Address to count from + * + * This operation is atomic and provides acquire barrier semantics. + * It can be used to implement bit locks. + */ +static inline int test_and_set_bit_lock( + unsigned long nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + return __test_and_op_bit_ord(or, __NOP, nr, addr, .aq); +} + +/** + * clear_bit_unlock - Clear a bit in memory, for unlock + * @nr: the bit to set + * @addr: the address to start counting from + * + * This operation is atomic and provides release barrier semantics. + */ +static inline void clear_bit_unlock( + unsigned long nr, volatile void *p) +{ + volatile unsigned long *addr = p; + + __op_bit_ord(and, __NOT, nr, addr, .rl); +} + +/** + * __clear_bit_unlock - Clear a bit in memory, for unlock + * @nr: the bit to set + * @addr: the address to start counting from + * + * This operation is like clear_bit_unlock, however it is not atomic. + * It does provide release barrier semantics so it can be used to unlock + * a bit lock, however it would only be used if no other CPU can modify + * any bits in the memory until the lock is released (a good example is + * if the bit lock itself protects access to the other bits in the word). + * + * On RISC-V systems there seems to be no benefit to taking advantage of the + * non-atomic property here: it's a lot more instructions and we still have to + * provide release semantics anyway. + */ +static inline void __clear_bit_unlock( + unsigned long nr, volatile unsigned long *addr) +{ + clear_bit_unlock(nr, addr); +} + +#undef __test_and_op_bit +#undef __op_bit +#undef __NOP +#undef __NOT +#undef __AMO + +static inline int fls(unsigned int x) +{ + return generic_fls(x); +} + +static inline int flsl(unsigned long x) +{ + return generic_flsl(x); +} + + +#define test_and_set_bit __test_and_set_bit +#define test_and_clear_bit __test_and_clear_bit + +/* Based on linux/include/asm-generic/bitops/find.h */ + +#ifndef find_next_bit +/** + * find_next_bit - find the next set bit in a memory region + * @addr: The address to base the search on + * @offset: The bitnumber to start searching at + * @size: The bitmap size in bits + */ +extern unsigned long find_next_bit(const unsigned long *addr, unsigned long + size, unsigned long offset); +#endif + +#ifndef find_next_zero_bit +/** + * find_next_zero_bit - find the next cleared bit in a memory region + * @addr: The address to base the search on + * @offset: The bitnumber to start searching at + * @size: The bitmap size in bits + */ +extern unsigned long find_next_zero_bit(const unsigned long *addr, unsigned + long size, unsigned long offset); +#endif + +/** + * find_first_bit - find the first set bit in a memory region + * @addr: The address to start the search at + * @size: The maximum size to search + * + * Returns the bit number of the first set bit. + */ +extern unsigned long find_first_bit(const unsigned long *addr, + unsigned long size); + +/** + * find_first_zero_bit - find the first cleared bit in a memory region + * @addr: The address to start the search at + * @size: The maximum size to search + * + * Returns the bit number of the first cleared bit. + */ +extern unsigned long find_first_zero_bit(const unsigned long *addr, + unsigned long size); + +#define ffs(x) ({ unsigned int __t = (x); fls(__t & -__t); }) +/** + * ffs - find first bit in word. + * @word: The word to search + * + * Returns 0 if no bit exists, otherwise returns 1-indexed bit location. + */ +static inline unsigned long __ffs(unsigned long word) +{ + int num = 0; + +#if BITS_PER_LONG == 64 + if ((word & 0xffffffff) == 0) { + num += 32; + word >>= 32; + } +#endif + if ((word & 0xffff) == 0) { + num += 16; + word >>= 16; + } + if ((word & 0xff) == 0) { + num += 8; + word >>= 8; + } + if ((word & 0xf) == 0) { + num += 4; + word >>= 4; + } + if ((word & 0x3) == 0) { + num += 2; + word >>= 2; + } + if ((word & 0x1) == 0) + num += 1; + return num; +} + +/** + * ffsl - find first bit in long. + * @word: The word to search + * + * Returns 0 if no bit exists, otherwise returns 1-indexed bit location. + */ +static inline unsigned int ffsl(unsigned long word) +{ + int num = 1; + + if (!word) + return 0; + +#if BITS_PER_LONG == 64 + if ((word & 0xffffffff) == 0) { + num += 32; + word >>= 32; + } +#endif + if ((word & 0xffff) == 0) { + num += 16; + word >>= 16; + } + if ((word & 0xff) == 0) { + num += 8; + word >>= 8; + } + if ((word & 0xf) == 0) { + num += 4; + word >>= 4; + } + if ((word & 0x3) == 0) { + num += 2; + word >>= 2; + } + if ((word & 0x1) == 0) + num += 1; + return num; +} + +/* + * ffz - find first zero in word. + * @word: The word to search + * + * Undefined if no zero exists, so code should check against ~0UL first. + */ +#define ffz(x) ffs(~(x)) + +/** + * find_first_set_bit - find the first set bit in @word + * @word: the word to search + * + * Returns the bit-number of the first set bit (first bit being 0). + * The input must *not* be zero. + */ +static inline unsigned int find_first_set_bit(unsigned long word) +{ + return ffsl(word) - 1; +} + +/** + * hweightN - returns the hamming weight of a N-bit word + * @x: the word to weigh + * + * The Hamming Weight of a number is the total number of bits set in it. + */ +#define hweight64(x) generic_hweight64(x) +#define hweight32(x) generic_hweight32(x) +#define hweight16(x) generic_hweight16(x) +#define hweight8(x) generic_hweight8(x) + +#endif /* _ASM_RISCV_BITOPS_H */ diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h new file mode 100644 index 0000000000..2616c9ced1 --- /dev/null +++ b/xen/arch/riscv/include/asm/bug.h @@ -0,0 +1,67 @@ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2021 Vates + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_BUG_H +#define _ASM_RISCV_BUG_H + +#define BUGFRAME_NR 3 + +struct bug_frame { + signed int loc_disp; /* Relative address to the bug address */ + signed int file_disp; /* Relative address to the filename */ + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ + uint16_t line; /* Line number */ + uint32_t pad0:16; /* Padding for 8-bytes align */ +}; + +#ifndef __ASSEMBLY__ + +#define BUG() \ +do { \ + __asm__ __volatile__ ("ebreak\n"); \ + unreachable(); \ +} while (0) + +#define WARN() \ +do { \ + __asm__ __volatile__ ("ebreak\n"); \ +} while (0) + +#endif /* !__ASSEMBLY__ */ + +#ifndef __ASSEMBLY__ + +struct pt_regs; +struct task_struct; + +#endif /* !__ASSEMBLY__ */ + +#define assert_failed(msg) do { \ + BUG(); \ + unreachable(); \ +} while (0) + +extern const struct bug_frame __start_bug_frames[], + __stop_bug_frames_0[], + __stop_bug_frames_1[], + __stop_bug_frames_2[], + __stop_bug_frames_3[]; + +#define run_in_exception_handler(fn) do { \ + asm ("add a0, %0, zero" \ + :: "r" (fn)); \ + BUG(); \ + } while( 0 ) + +#endif /* _ASM_RISCV_BUG_H */ diff --git a/xen/arch/riscv/include/asm/byteorder.h b/xen/arch/riscv/include/asm/byteorder.h new file mode 100644 index 0000000000..320a03c88f --- /dev/null +++ b/xen/arch/riscv/include/asm/byteorder.h @@ -0,0 +1,16 @@ +#ifndef __ASM_RISCV_BYTEORDER_H__ +#define __ASM_RISCV_BYTEORDER_H__ + +#define __BYTEORDER_HAS_U64__ + +#include + +#endif /* __ASM_RISCV_BYTEORDER_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/cache.h b/xen/arch/riscv/include/asm/cache.h new file mode 100644 index 0000000000..1fdc702828 --- /dev/null +++ b/xen/arch/riscv/include/asm/cache.h @@ -0,0 +1,24 @@ +/* + * Copyright (C) 2017 Chen Liqin + * Copyright (C) 2012 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_CACHE_H +#define _ASM_RISCV_CACHE_H + +#define L1_CACHE_SHIFT 6 + +#define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) + +#define __read_mostly __section(".data.read_mostly") + +#endif /* _ASM_RISCV_CACHE_H */ diff --git a/xen/arch/riscv/include/asm/cmpxchg.h b/xen/arch/riscv/include/asm/cmpxchg.h new file mode 100644 index 0000000000..256facce13 --- /dev/null +++ b/xen/arch/riscv/include/asm/cmpxchg.h @@ -0,0 +1,382 @@ +/* + * Copyright (C) 2014 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_CMPXCHG_H +#define _ASM_RISCV_CMPXCHG_H + +#include +#include +#include + +#define __xchg_relaxed(ptr, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(new) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + " amoswap.w %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + " amoswap.d %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define xchg_relaxed(ptr, x) \ +({ \ + __typeof__(*(ptr)) _x_ = (x); \ + (__typeof__(*(ptr))) __xchg_relaxed((ptr), \ + _x_, sizeof(*(ptr))); \ +}) + +#define __xchg_acquire(ptr, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(new) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + " amoswap.w %0, %2, %1\n" \ + RISCV_ACQUIRE_BARRIER \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + " amoswap.d %0, %2, %1\n" \ + RISCV_ACQUIRE_BARRIER \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define xchg_acquire(ptr, x) \ +({ \ + __typeof__(*(ptr)) _x_ = (x); \ + (__typeof__(*(ptr))) __xchg_acquire((ptr), \ + _x_, sizeof(*(ptr))); \ +}) + +#define __xchg_release(ptr, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(new) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + RISCV_RELEASE_BARRIER \ + " amoswap.w %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + RISCV_RELEASE_BARRIER \ + " amoswap.d %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define xchg_release(ptr, x) \ +({ \ + __typeof__(*(ptr)) _x_ = (x); \ + (__typeof__(*(ptr))) __xchg_release((ptr), \ + _x_, sizeof(*(ptr))); \ +}) + +#define __xchg(ptr, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(new) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + " amoswap.w.aqrl %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + " amoswap.d.aqrl %0, %2, %1\n" \ + : "=r" (__ret), "+A" (*__ptr) \ + : "r" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define xchg(ptr, x) \ +({ \ + __typeof__(*(ptr)) _x_ = (x); \ + (__typeof__(*(ptr))) __xchg((ptr), _x_, sizeof(*(ptr))); \ +}) + +#define xchg32(ptr, x) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 4); \ + xchg((ptr), (x)); \ +}) + +#define xchg64(ptr, x) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + xchg((ptr), (x)); \ +}) + +/* + * Atomic compare and exchange. Compare OLD with MEM, if identical, + * store NEW in MEM. Return the initial value in MEM. Success is + * indicated by comparing RETURN with OLD. + */ +#define __cmpxchg_relaxed(ptr, old, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(*(ptr)) __old = (old); \ + __typeof__(*(ptr)) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + register unsigned int __rc; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + "0: lr.w %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.w %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + "0: lr.d %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.d %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define cmpxchg_relaxed(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) _o_ = (o); \ + __typeof__(*(ptr)) _n_ = (n); \ + (__typeof__(*(ptr))) __cmpxchg_relaxed((ptr), \ + _o_, _n_, sizeof(*(ptr))); \ +}) + +#define __cmpxchg_acquire(ptr, old, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(*(ptr)) __old = (old); \ + __typeof__(*(ptr)) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + register unsigned int __rc; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + "0: lr.w %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.w %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + RISCV_ACQUIRE_BARRIER \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + "0: lr.d %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.d %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + RISCV_ACQUIRE_BARRIER \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define cmpxchg_acquire(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) _o_ = (o); \ + __typeof__(*(ptr)) _n_ = (n); \ + (__typeof__(*(ptr))) __cmpxchg_acquire((ptr), \ + _o_, _n_, sizeof(*(ptr))); \ +}) + +#define __cmpxchg_release(ptr, old, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(*(ptr)) __old = (old); \ + __typeof__(*(ptr)) __new = (new); \ + __typeof__(*(ptr)) __ret; \ + register unsigned int __rc; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + RISCV_RELEASE_BARRIER \ + "0: lr.w %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.w %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + RISCV_RELEASE_BARRIER \ + "0: lr.d %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.d %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define cmpxchg_release(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) _o_ = (o); \ + __typeof__(*(ptr)) _n_ = (n); \ + (__typeof__(*(ptr))) __cmpxchg_release((ptr), \ + _o_, _n_, sizeof(*(ptr))); \ +}) + +#define __cmpxchg(ptr, old, new, size) \ +({ \ + __typeof__(ptr) __ptr = (ptr); \ + __typeof__(*(ptr)) __old = (__typeof__(*(ptr)))(old); \ + __typeof__(*(ptr)) __new = (__typeof__(*(ptr)))(new); \ + __typeof__(*(ptr)) __ret; \ + register unsigned int __rc; \ + switch (size) { \ + case 4: \ + __asm__ __volatile__ ( \ + "0: lr.w %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.w.rl %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + " fence rw, rw\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + case 8: \ + __asm__ __volatile__ ( \ + "0: lr.d %0, %2\n" \ + " bne %0, %z3, 1f\n" \ + " sc.d.rl %1, %z4, %2\n" \ + " bnez %1, 0b\n" \ + " fence rw, rw\n" \ + "1:\n" \ + : "=&r" (__ret), "=&r" (__rc), "+A" (*__ptr) \ + : "rJ" (__old), "rJ" (__new) \ + : "memory"); \ + break; \ + default: \ + ASSERT_UNREACHABLE(); \ + } \ + __ret; \ +}) + +#define cmpxchg(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) _o_ = (o); \ + __typeof__(*(ptr)) _n_ = (n); \ + (__typeof__(*(ptr))) __cmpxchg((ptr), \ + _o_, _n_, sizeof(*(ptr))); \ +}) + +#define cmpxchg_local(ptr, o, n) \ + (__cmpxchg_relaxed((ptr), (o), (n), sizeof(*(ptr)))) + +#define cmpxchg32(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 4); \ + cmpxchg((ptr), (o), (n)); \ +}) + +#define cmpxchg32_local(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 4); \ + cmpxchg_relaxed((ptr), (o), (n)) \ +}) + +#define cmpxchg64(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + cmpxchg((ptr), (o), (n)); \ +}) + +#define cmpxchg64_local(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + cmpxchg_relaxed((ptr), (o), (n)); \ +}) + +#endif /* _ASM_RISCV_CMPXCHG_H */ diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index e2ae21de61..1ca898bde5 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -1,6 +1,38 @@ #ifndef __RISCV_CONFIG_H__ #define __RISCV_CONFIG_H__ +#include +#include +#include + +/* + * RISC-V Layout: + * 0 - 2M Unmapped + * 2M - 4M Xen text, data, bss + * 4M - 6M Fixmap: special-purpose 4K mapping slots + * 6M - 10M Early boot mapping of FDT + * 10M - 12M Early relocation address (used when relocating Xen) + * and later for livepatch vmap (if compiled in) + * + * All of the above is mapped in L2 slot[0] (except for Unmapped) + * + * 1G - 2G VMAP: ioremap and early_ioremap (L2 slot 2) + * + * 2G - 5G: Unused + * + * 5G - 8G + * 0x140000000 - 0x200000000 + * Frametable: 24 bytes per page for 371GB of RAM, GB-aligned (slightly over 2GB, L2 slots [6..7]) + * + * 8G - 12G : Unused + * + * 0x300000000 - 0x5fffffffff : 371GB, L2 Slots [12...384) + * 1:1 mapping of RAM + * + * 0x6000000000 - 0x7fffffffff : 127GB, L2 slots [384..512) + * Unused + */ + #if defined(CONFIG_RISCV_64) # define LONG_BYTEORDER 3 # define ELFSIZE 64 @@ -26,14 +58,123 @@ #define OPT_CONSOLE_STR "dtuart" #define INVALID_VCPU_ID MAX_VIRT_CPUS +#ifdef CONFIG_RISCV_64 + +/* Bit counts for virtual address fields (sv39) */ +#define VPN2_BITS (9) +#define VPN1_BITS (9) +#define VPN0_BITS (9) +#define OFFSET_BITS (12) + +/* SLOT2_ENTRY_BITS == 30 */ +#define SLOT2_ENTRY_BITS (VPN1_BITS + VPN2_BITS + OFFSET_BITS) +#define SLOT2(slot) (_AT(vaddr_t,slot) << SLOT2_ENTRY_BITS) +#define SLOT2_ENTRY_SIZE SLOT2(1) + +#define DIRECTMAP_VIRT_START SLOT2(12) + +/* See above "RISC-V Layout" for description of layout (and + * where these magic numbers come from */ +#define DIRECTMAP_SIZE (SLOT2_ENTRY_SIZE * (384-12)) +#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) +#define XENHEAP_VIRT_START xenheap_virt_start +#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END + +#else /* RISCV_32 */ +#error "RISC-V 32-bit is not supported yet" +#endif + +#define FIXMAP_CONSOLE 0 /* The primary UART */ +#define FIXMAP_MISC 1 /* Ephemeral mappings of hardware */ + +#define CONFIG_PAGING_LEVELS 3 + +#define CONFIG_PAGEALLOC_MAX_ORDER 18 +#define CONFIG_DOMU_MAX_ORDER 9 +#define CONFIG_HWDOM_MAX_ORDER 10 + +#ifdef CONFIG_RISCV_64 +#define MAX_VIRT_CPUS 128u +#else +#define MAX_VIRT_CPUS 8u +#endif + +#define XEN_VIRT_START _AT(vaddr_t,0x00200000) +#define XEN_VIRT_END _AT(vaddr_t,0x40000000) +#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) + +#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) +#define BOOT_FDT_SLOT_SIZE MB(4) +#define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE) + + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#define INVALID_VCPU_ID MAX_VIRT_CPUS + +#define STACK_ORDER 3 +#define STACK_SIZE (PAGE_SIZE << STACK_ORDER) + +#define VMAP_VIRT_START GB(1) +#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1)) + +#define FRAMETABLE_VIRT_START GB(5) +#define FRAMETABLE_SIZE GB(1) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) +#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) + +/** + * All RISC-V implementations (except for with C extension) enforce 32-bit + * instruction address alignment. With C extension, 16-bit and 32-bit are + * both allowed. + */ +#ifndef __ALIGN +#define __ALIGN .align 4 +#define __ALIGN_STR ".align 4" +#endif + /* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define ALIGN __ALIGN +#define ALIGN_STR __ALIGN_STR + +#define ENTRY(name) \ + .globl name; \ + ALIGN; \ + name: -#define ENTRY(name) \ - .globl name; \ - ALIGN; \ +#define GLOBAL(name) \ + .globl name; \ name: + +#define WEAK(name) \ + .weak name; \ + ALIGN; \ + name: + +#define END(name) \ + .size name, .-name + +#ifndef ASM_NL +#define ASM_NL ; +#endif + +#define SYM_END(name, sym_type) \ + .type name sym_type ASM_NL \ + .size name, .-name + +#define SYM_FUNC_END(name) \ + SYM_END(name, STT_FUNC) + +/* If symbol 'name' is treated as a subroutine (gets called, and returns) + * then please use ENDPROC to mark 'name' as STT_FUNC for the benefit of + * static analysis tools such as stack depth analyzer. + */ +#define ENDPROC(name) \ + SYM_FUNC_END(name) + +#define __PAGE_ALIGNED_DATA .section ".data..page_aligned", "aw" +#define __PAGE_ALIGNED_BSS .section ".bss..page_aligned", "aw" #endif #endif /* __RISCV_CONFIG_H__ */ diff --git a/xen/arch/riscv/include/asm/cpufeature.h b/xen/arch/riscv/include/asm/cpufeature.h new file mode 100644 index 0000000000..45ad9dc69e --- /dev/null +++ b/xen/arch/riscv/include/asm/cpufeature.h @@ -0,0 +1,68 @@ +#ifndef __ASM_RISCV_CPUFEATURE_H +#define __ASM_RISCV_CPUFEATURE_H + +#define RISCV_NCAPS 1 + +#ifndef __ASSEMBLY__ + +#include +#include +#include + +extern DECLARE_BITMAP(cpu_hwcaps, RISCV_NCAPS); + +static inline bool cpus_have_cap(unsigned int num) +{ + return false; +} + +static inline int cpu_nr_siblings(unsigned int cpu) +{ + return 1; +} + +static inline void cpus_set_cap(unsigned int num) +{ + if (num >= RISCV_NCAPS) + printk(XENLOG_WARNING "Attempt to set an illegal CPU capability (%d >= %d)\n", + num, RISCV_NCAPS); + else + __set_bit(num, cpu_hwcaps); +} + +struct riscv_cpu_capabilities { +}; + +void update_cpu_capabilities(const struct riscv_cpu_capabilities *caps, + const char *info); + +void enable_cpu_capabilities(const struct riscv_cpu_capabilities *caps); +int enable_nonboot_cpu_caps(const struct riscv_cpu_capabilities *caps); + +/* + * capabilities of CPUs + */ +struct cpuinfo_riscv { +}; + +extern struct cpuinfo_riscv boot_cpu_data; + +extern void identify_cpu(struct cpuinfo_riscv *); + +extern struct cpuinfo_riscv cpu_data[]; +#define current_cpu_data cpu_data[smp_processor_id()] + +extern struct cpuinfo_riscv guest_cpuinfo; + +#endif /* __ASSEMBLY__ */ + +#endif +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ + diff --git a/xen/arch/riscv/include/asm/csr.h b/xen/arch/riscv/include/asm/csr.h new file mode 100644 index 0000000000..2e2bf5d706 --- /dev/null +++ b/xen/arch/riscv/include/asm/csr.h @@ -0,0 +1,81 @@ +/* + * Take from Linux. + * + * SPDX-License-Identifier: GPL-2.0-only + * + * Copyright (C) 2015 Regents of the University of California + */ + +#ifndef _ASM_RISCV_CSR_H +#define _ASM_RISCV_CSR_H + +#include +#include +#include + + +#ifndef __ASSEMBLY__ + +#define csr_swap(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrrw %0, " __ASM_STR(csr) ", %1"\ + : "=r" (__v) : "rK" (__v) \ + : "memory"); \ + __v; \ +}) + +#define csr_read(csr) \ +({ \ + register unsigned long __v; \ + __asm__ __volatile__ ("csrr %0, " __ASM_STR(csr) \ + : "=r" (__v) : \ + : "memory"); \ + __v; \ +}) + +#define csr_write(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrw " __ASM_STR(csr) ", %0" \ + : : "rK" (__v) \ + : "memory"); \ +}) + +#define csr_read_set(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrrs %0, " __ASM_STR(csr) ", %1"\ + : "=r" (__v) : "rK" (__v) \ + : "memory"); \ + __v; \ +}) + +#define csr_set(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrs " __ASM_STR(csr) ", %0" \ + : : "rK" (__v) \ + : "memory"); \ +}) + +#define csr_read_clear(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrrc %0, " __ASM_STR(csr) ", %1"\ + : "=r" (__v) : "rK" (__v) \ + : "memory"); \ + __v; \ +}) + +#define csr_clear(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ("csrc " __ASM_STR(csr) ", %0" \ + : : "rK" (__v) \ + : "memory"); \ +}) + +#endif /* __ASSEMBLY__ */ + +#endif /* _ASM_RISCV_CSR_H */ diff --git a/xen/arch/riscv/include/asm/current.h b/xen/arch/riscv/include/asm/current.h new file mode 100644 index 0000000000..82ed329289 --- /dev/null +++ b/xen/arch/riscv/include/asm/current.h @@ -0,0 +1,41 @@ +#ifndef __ASM_CURRENT_H +#define __ASM_CURRENT_H + +#include +#include + +struct vcpu; + +/* Which VCPU is "current" on this PCPU. */ +DECLARE_PER_CPU(struct vcpu *, curr_vcpu); + +#define current (this_cpu(curr_vcpu)) +#define set_current(vcpu) do { current = (vcpu); } while (0) +#define get_cpu_current(cpu) (per_cpu(curr_vcpu, cpu)) + +/* Per-VCPU state that lives at the top of the stack */ +struct cpu_info { + /* This should be the first member. */ + struct cpu_user_regs guest_cpu_user_regs; +}; + +static inline struct cpu_info *get_cpu_info(void) +{ + register unsigned long sp asm ("sp"); + return (struct cpu_info *)((sp & ~(STACK_SIZE - 1)) + STACK_SIZE - sizeof(struct cpu_info)); +} + +#define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) +#define guest_regs(vcpu) (&vcpu->arch.cpu_info->guest_cpu_user_regs) + +#define switch_stack_and_jump(stack, fn) \ + asm volatile ( \ + "mv sp, %0 \n" \ + "j " #fn :: "r" (stack) : \ + ) + +#define reset_stack_and_jump(fn) switch_stack_and_jump(get_cpu_info(), fn) + +DECLARE_PER_CPU(unsigned int, cpu_id); + +#endif /* __ASM_CURRENT_H */ diff --git a/xen/arch/riscv/include/asm/debugger.h b/xen/arch/riscv/include/asm/debugger.h new file mode 100644 index 0000000000..af4fc8a838 --- /dev/null +++ b/xen/arch/riscv/include/asm/debugger.h @@ -0,0 +1,15 @@ +#ifndef __RISCV_DEBUGGER_H__ +#define __RISCV_DEBUGGER_H__ + +#define debugger_trap_fatal(v, r) (0) +#define debugger_trap_immediate() ((void) 0) + +#endif /* __RISCV_DEBUGGER_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/delay.h b/xen/arch/riscv/include/asm/delay.h new file mode 100644 index 0000000000..cbb0c9eb96 --- /dev/null +++ b/xen/arch/riscv/include/asm/delay.h @@ -0,0 +1,28 @@ +/* + * Copyright (C) 2009 Chen Liqin + * Copyright (C) 2016 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_DELAY_H +#define _ASM_RISCV_DELAY_H + +extern unsigned long riscv_timebase; + +#define udelay udelay +extern void udelay(unsigned long usecs); + +#define ndelay ndelay +extern void ndelay(unsigned long nsecs); + +extern void __delay(unsigned long cycles); + +#endif /* _ASM_RISCV_DELAY_H */ diff --git a/xen/arch/riscv/include/asm/desc.h b/xen/arch/riscv/include/asm/desc.h new file mode 100644 index 0000000000..a4d02d5eef --- /dev/null +++ b/xen/arch/riscv/include/asm/desc.h @@ -0,0 +1,12 @@ +#ifndef __ARCH_DESC_H +#define __ARCH_DESC_H + +#endif /* __ARCH_DESC_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/device.h b/xen/arch/riscv/include/asm/device.h new file mode 100644 index 0000000000..e613f816be --- /dev/null +++ b/xen/arch/riscv/include/asm/device.h @@ -0,0 +1,93 @@ +#ifndef __ASM_RISCV_DEVICE_H +#define __ASM_RISCV_DEVICE_H + +enum device_type +{ + DEV_DT, +}; + +struct dev_archdata { + void *iommu; /* IOMMU private data */ +}; + +/* struct device - The basic device structure */ +struct device +{ + enum device_type type; + struct dt_device_node *of_node; /* Used by drivers imported from Linux */ + struct dev_archdata archdata; + struct iommu_fwspec *iommu_fwspec; /* per-device IOMMU instance data */ +}; + +typedef struct device device_t; + +#include + +/* TODO: Correctly implement dev_is_pci when PCI is supported on RISCV */ +#define dev_is_pci(dev) ((void)(dev), 0) +#define dev_is_dt(dev) ((dev->type == DEV_DT) + +enum device_class +{ + DEVICE_SERIAL, + DEVICE_IOMMU, + DEVICE_GIC, + /* Use for error */ + DEVICE_UNKNOWN, +}; + +struct device_desc { + /* Device name */ + const char *name; + /* Device class */ + enum device_class class; + /* List of devices supported by this driver */ + const struct dt_device_match *dt_match; + /* + * Device initialization. + * + * -EAGAIN is used to indicate that device probing is deferred. + */ + int (*init)(struct dt_device_node *dev, const void *data); +}; + +#if 1 +/** + * device_init - Initialize a device + * @dev: device to initialize + * @class: class of the device (serial, network...) + * @data: specific data for initializing the device + * + * Return 0 on success. + */ +int device_init(struct dt_device_node *dev, enum device_class class, + const void *data); + +/** + * device_get_type - Get the type of the device + * @dev: device to match + * + * Return the device type on success or DEVICE_ANY on failure + */ +enum device_class device_get_class(const struct dt_device_node *dev); + +#define DT_DEVICE_START(_name, _namestr, _class) \ +static const struct device_desc __dev_desc_##_name __used \ +__section(".dev.info") = { \ + .name = _namestr, \ + .class = _class, \ + +#define DT_DEVICE_END \ +}; +#endif + +#endif /* __ASM_RISCV_DEVICE_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/div64.h b/xen/arch/riscv/include/asm/div64.h new file mode 100644 index 0000000000..0a88dd30ad --- /dev/null +++ b/xen/arch/riscv/include/asm/div64.h @@ -0,0 +1,23 @@ +#ifndef __ASM_RISCV_DIV64 +#define __ASM_RISCV_DIV64 + +#include +#include + +# define do_div(n,base) ({ \ + uint32_t __base = (base); \ + uint32_t __rem; \ + __rem = ((uint64_t)(n)) % __base; \ + (n) = ((uint64_t)(n)) / __base; \ + __rem; \ + }) + +#endif +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/domain.h b/xen/arch/riscv/include/asm/domain.h new file mode 100644 index 0000000000..a8bbb1460f --- /dev/null +++ b/xen/arch/riscv/include/asm/domain.h @@ -0,0 +1,80 @@ +#ifndef __ASM_DOMAIN_H__ +#define __ASM_DOMAIN_H__ + +#ifndef __ASSEMBLY__ + +#include +#include +#include +#include +#include +#include +#include + + +struct hvm_domain +{ + uint64_t params[HVM_NR_PARAMS]; +}; + +#ifdef CONFIG_RISCV_64 +enum domain_type { + DOMAIN_32BIT, + DOMAIN_64BIT, +}; +#define is_32bit_domain(d) ((d)->arch.type == DOMAIN_32BIT) +#define is_64bit_domain(d) ((d)->arch.type == DOMAIN_64BIT) +#else +#define is_32bit_domain(d) (1) +#define is_64bit_domain(d) (0) +#endif + +/* The hardware domain has always its memory direct mapped. */ +#define is_domain_direct_mapped(d) ((d) == hardware_domain) + +struct arch_domain +{ + /* Virtual MMU */ + struct p2m_domain p2m; + + struct hvm_domain hvm; + +} __cacheline_aligned; + +struct arch_vcpu +{ + /* TODO */ +} __cacheline_aligned; + +struct arch_vcpu_io { + /* TODO */ +}; + +void vcpu_show_execution_state(struct vcpu *); +void vcpu_show_registers(const struct vcpu *); + +static inline struct vcpu_guest_context *alloc_vcpu_guest_context(void) +{ + return xmalloc(struct vcpu_guest_context); +} + +static inline void free_vcpu_guest_context(struct vcpu_guest_context *vgc) +{ + xfree(vgc); +} + +static inline void arch_vcpu_block(struct vcpu *v) {} + +#endif /* !__ASSEMBLY__ */ + +#endif /* __ASM_DOMAIN_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/event.h b/xen/arch/riscv/include/asm/event.h new file mode 100644 index 0000000000..88e10f414b --- /dev/null +++ b/xen/arch/riscv/include/asm/event.h @@ -0,0 +1,42 @@ +#ifndef __ASM_EVENT_H__ +#define __ASM_EVENT_H__ + +#include +#include +#include + +void vcpu_kick(struct vcpu *v); +void vcpu_mark_events_pending(struct vcpu *v); +void vcpu_update_evtchn_irq(struct vcpu *v); +void vcpu_block_unless_event_pending(struct vcpu *v); + +static inline int vcpu_event_delivery_is_enabled(struct vcpu *v) +{ + return 0; +} + +static inline int local_events_need_delivery(void) +{ + return 0; +} + +static inline void local_event_delivery_enable(void) +{ + +} + +/* No arch specific virq definition now. Default to global. */ +static inline bool arch_virq_is_global(unsigned int virq) +{ + return true; +} + +#endif +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/fence.h b/xen/arch/riscv/include/asm/fence.h new file mode 100644 index 0000000000..2b443a3a48 --- /dev/null +++ b/xen/arch/riscv/include/asm/fence.h @@ -0,0 +1,12 @@ +#ifndef _ASM_RISCV_FENCE_H +#define _ASM_RISCV_FENCE_H + +#ifdef CONFIG_SMP +#define RISCV_ACQUIRE_BARRIER "\tfence r , rw\n" +#define RISCV_RELEASE_BARRIER "\tfence rw, w\n" +#else +#define RISCV_ACQUIRE_BARRIER +#define RISCV_RELEASE_BARRIER +#endif + +#endif /* _ASM_RISCV_FENCE_H */ diff --git a/xen/arch/riscv/include/asm/flushtlb.h b/xen/arch/riscv/include/asm/flushtlb.h new file mode 100644 index 0000000000..083ca3a2be --- /dev/null +++ b/xen/arch/riscv/include/asm/flushtlb.h @@ -0,0 +1,56 @@ +#ifndef __ASM_RISCV_FLUSHTLB_H__ +#define __ASM_RISCV_FLUSHTLB_H__ + +#include +#include + +/* + * Filter the given set of CPUs, removing those that definitely flushed their + * TLB since @page_timestamp. + */ +/* XXX lazy implementation just doesn't clear anything.... */ +static inline void tlbflush_filter(cpumask_t *mask, uint32_t page_timestamp) {} + +#define tlbflush_current_time() (0) + +static inline void page_set_tlbflush_timestamp(struct page_info *page) +{ + page->tlbflush_timestamp = tlbflush_current_time(); +} + +/* Flush specified CPUs' TLBs */ +void arch_flush_tlb_mask(const cpumask_t *mask); + +/* Flush local TLBs, current VMID only */ +static inline void flush_guest_tlb_local(void) +{ + /* TODO */ +} + +/* Flush innershareable TLBs, current VMID only */ +static inline void flush_guest_tlb(void) +{ + /* TODO */ +} + +/* Flush local TLBs, all VMIDs, non-hypervisor mode */ +static inline void flush_all_guests_tlb_local(void) +{ + /* TODO */ +} + +/* Flush innershareable TLBs, all VMIDs, non-hypervisor mode */ +static inline void flush_all_guests_tlb(void) +{ + /* TODO */ +} + +#endif /* __ASM_RISCV_FLUSHTLB_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/grant_table.h b/xen/arch/riscv/include/asm/grant_table.h new file mode 100644 index 0000000000..40607ea2c8 --- /dev/null +++ b/xen/arch/riscv/include/asm/grant_table.h @@ -0,0 +1,93 @@ +#ifndef __ASM_GRANT_TABLE_H__ +#define __ASM_GRANT_TABLE_H__ + +#include +#include +#include +#include + +#define INITIAL_NR_GRANT_FRAMES 1U +#define GNTTAB_MAX_VERSION 1 + +struct grant_table_arch { + gfn_t *shared_gfn; + gfn_t *status_gfn; +}; + +void gnttab_clear_flags(struct domain *d, + unsigned long nr, uint16_t *addr); +int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, + unsigned int flags, unsigned int cache_flags); +#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0) +int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, + unsigned long new_gpaddr, unsigned int flags); +void gnttab_mark_dirty(struct domain *d, mfn_t mfn); +#define gnttab_release_host_mappings(domain) 1 + +/* + * The region used by Xen on the memory will never be mapped in DOM0 + * memory layout. Therefore it can be used for the grant table. + * + * Only use the text section as it's always present and will contain + * enough space for a large grant table + */ +#define gnttab_dom0_frames() \ + min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext)) + +#define gnttab_init_arch(gt) \ +({ \ + unsigned int ngf_ = (gt)->max_grant_frames; \ + unsigned int nsf_ = grant_to_status_frames(ngf_); \ + \ + (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ + (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ + if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ + { \ + while ( ngf_-- ) \ + (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ + while ( nsf_-- ) \ + (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ + } \ + else \ + gnttab_destroy_arch(gt); \ + (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ +}) + +#define gnttab_destroy_arch(gt) \ + do { \ + XFREE((gt)->arch.shared_gfn); \ + XFREE((gt)->arch.status_gfn); \ + } while ( 0 ) + +#define gnttab_set_frame_gfn(gt, st, idx, gfn) \ + do { \ + ((st) ? (gt)->arch.status_gfn : (gt)->arch.shared_gfn)[idx] = \ + (gfn); \ + } while ( 0 ) + +#define gnttab_get_frame_gfn(gt, st, idx) ({ \ + (st) ? gnttab_status_gfn(NULL, gt, idx) \ + : gnttab_shared_gfn(NULL, gt, idx); \ +}) + +#define gnttab_shared_gfn(d, t, i) \ + (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + +#define gnttab_status_gfn(d, t, i) \ + (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + +#define gnttab_status_gfn(d, t, i) \ + (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + +#define gnttab_need_iommu_mapping(d) \ + (is_domain_direct_mapped(d) && need_iommu_pt_sync(d)) + +#endif /* __ASM_GRANT_TABLE_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/guest_access.h b/xen/arch/riscv/include/asm/guest_access.h new file mode 100644 index 0000000000..fd1b458e3f --- /dev/null +++ b/xen/arch/riscv/include/asm/guest_access.h @@ -0,0 +1,125 @@ +#ifndef __ASM_RISCV_GUEST_ACCESS_H__ +#define __ASM_RISCV_GUEST_ACCESS_H__ + +#include +#include +#include +#include + +unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len); +unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from, + unsigned len); +unsigned long raw_copy_from_guest(void *to, const void *from, unsigned len); +unsigned long raw_clear_guest(void *to, unsigned len); + +/* Copy data to guest physical address, then clean the region. */ +unsigned long copy_to_guest_phys(struct domain *d, + paddr_t phys, + void *buf, + unsigned int len); + +unsigned long riscv_vcpu_unpriv_read(struct vcpu *vcpu, + bool read_insn, + unsigned long guest_addr, + struct riscv_trap *trap); + +#define __raw_copy_to_guest raw_copy_to_guest +#define __raw_copy_from_guest raw_copy_from_guest +#define __raw_clear_guest raw_clear_guest + +/* Remainder copied from ARM and x86 -- could be common? */ + +/* Is the guest handle a NULL reference? */ +#define guest_handle_is_null(hnd) ((hnd).p == NULL) + +/* Offset the given guest handle into the array it refers to. */ +#define guest_handle_add_offset(hnd, nr) ((hnd).p += (nr)) +#define guest_handle_subtract_offset(hnd, nr) ((hnd).p -= (nr)) + +/* Cast a guest handle (either XEN_GUEST_HANDLE or XEN_GUEST_HANDLE_PARAM) + * to the specified type of XEN_GUEST_HANDLE_PARAM. */ +#define guest_handle_cast(hnd, type) ({ \ + type *_x = (hnd).p; \ + (XEN_GUEST_HANDLE_PARAM(type)) { _x }; \ +}) + +/* Cast a XEN_GUEST_HANDLE to XEN_GUEST_HANDLE_PARAM */ +#define guest_handle_to_param(hnd, type) ({ \ + typeof((hnd).p) _x = (hnd).p; \ + XEN_GUEST_HANDLE_PARAM(type) _y = { _x }; \ + /* type checking: make sure that the pointers inside \ + * XEN_GUEST_HANDLE and XEN_GUEST_HANDLE_PARAM are of \ + * the same type, then return hnd */ \ + (void)(&_x == &_y.p); \ + _y; \ +}) + + +/* Cast a XEN_GUEST_HANDLE_PARAM to XEN_GUEST_HANDLE */ +#define guest_handle_from_param(hnd, type) ({ \ + typeof((hnd).p) _x = (hnd).p; \ + XEN_GUEST_HANDLE(type) _y = { _x }; \ + /* type checking: make sure that the pointers inside \ + * XEN_GUEST_HANDLE and XEN_GUEST_HANDLE_PARAM are of \ + * the same type, then return hnd */ \ + (void)(&_x == &_y.p); \ + _y; \ +}) + +#define guest_handle_for_field(hnd, type, fld) \ + ((XEN_GUEST_HANDLE(type)) { &(hnd).p->fld }) + +#define guest_handle_from_ptr(ptr, type) \ + ((XEN_GUEST_HANDLE_PARAM(type)) { (type *)ptr }) +#define const_guest_handle_from_ptr(ptr, type) \ + ((XEN_GUEST_HANDLE_PARAM(const_##type)) { (const type *)ptr }) + +/* + * Clear an array of objects in guest context via a guest handle, + * specifying an offset into the guest array. + */ +#define clear_guest_offset(hnd, off, nr) ({ \ + void *_d = (hnd).p; \ + raw_clear_guest(_d+(off), nr); \ +}) + +/* + * Copy an array of objects from guest context via a guest handle, + * specifying an offset into the guest array. + */ +#define copy_from_guest_offset(ptr, hnd, off, nr) ({ \ + const typeof(*(ptr)) *_s = (hnd).p; \ + typeof(*(ptr)) *_d = (ptr); \ + raw_copy_from_guest(_d, _s+(off), sizeof(*_d)*(nr));\ +}) + +/* Copy sub-field of a structure to guest context via a guest handle. */ +/* Copy sub-field of a structure from guest context via a guest handle. */ +#define copy_field_from_guest(ptr, hnd, field) ({ \ + const typeof(&(ptr)->field) _s = &(hnd).p->field; \ + typeof(&(ptr)->field) _d = &(ptr)->field; \ + raw_copy_from_guest(_d, _s, sizeof(*_d)); \ +}) + +/* + * Pre-validate a guest handle. + * Allows use of faster __copy_* functions. + */ +#define guest_handle_okay(hnd, nr) (1) +#define guest_handle_subrange_okay(hnd, first, last) (1) + +#define __copy_field_from_guest(ptr, hnd, field) ({ \ + const typeof(&(ptr)->field) _s = &(hnd).p->field; \ + typeof(&(ptr)->field) _d = &(ptr)->field; \ + __raw_copy_from_guest(_d, _s, sizeof(*_d)); \ +}) + +#endif /* __ASM_RISCV_GUEST_ACCESS_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/guest_atomics.h b/xen/arch/riscv/include/asm/guest_atomics.h new file mode 100644 index 0000000000..45064a1b10 --- /dev/null +++ b/xen/arch/riscv/include/asm/guest_atomics.h @@ -0,0 +1,62 @@ +#ifndef _RISCV_GUEST_ATOMICS_H +#define _RISCV_GUEST_ATOMICS_H + +/* + * TODO: implement guest atomics + */ + + +/* TODO */ +#define guest_testop(name) \ +static inline int guest_##name(struct domain *d, int nr, volatile void *p) \ +{ \ + (void) d; \ + (void) nr; \ + (void) p; \ + \ + return 0; \ +} + + +/* TODO */ +#define guest_bitop(name) \ +static inline void guest_##name(struct domain *d, int nr, volatile void *p) \ +{ \ + (void) d; \ + (void) nr; \ + (void) p; \ +} + +guest_bitop(set_bit) +guest_bitop(clear_bit) +guest_bitop(change_bit) + +#undef guest_bitop + +guest_testop(test_and_set_bit) +guest_testop(test_and_clear_bit) +guest_testop(test_and_change_bit) + +#undef guest_testop + +#define guest_test_bit(d, nr, p) ((void)(d), test_bit(nr, p)) + +static inline int guest_cmpxchg(void *d, void *ptr, uint32_t o, uint32_t n) +{ + (void) d; + (void) ptr; + (void) o; + (void) n; + + return 0; +} + +#endif /* _RISCV_GUEST_ATOMICS_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/hardirq.h b/xen/arch/riscv/include/asm/hardirq.h new file mode 100644 index 0000000000..67b6a673db --- /dev/null +++ b/xen/arch/riscv/include/asm/hardirq.h @@ -0,0 +1,27 @@ +#ifndef __ASM_HARDIRQ_H +#define __ASM_HARDIRQ_H + +#include +#include + +typedef struct { + unsigned long __softirq_pending; + unsigned int __local_irq_count; +} __cacheline_aligned irq_cpustat_t; + +#include /* Standard mappings for irq_cpustat_t above */ + +#define in_irq() (local_irq_count(smp_processor_id()) != 0) + +#define irq_enter() (local_irq_count(smp_processor_id())++) +#define irq_exit() (local_irq_count(smp_processor_id())--) + +#endif /* __ASM_HARDIRQ_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/hypercall.h b/xen/arch/riscv/include/asm/hypercall.h new file mode 100644 index 0000000000..8af474b5e2 --- /dev/null +++ b/xen/arch/riscv/include/asm/hypercall.h @@ -0,0 +1,12 @@ +#ifndef __ASM_RISCV_HYPERCALL_H__ +#define __ASM_RISCV_HYPERCALL_H__ + +#endif /* __ASM_RISCV_HYPERCALL_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/init.h b/xen/arch/riscv/include/asm/init.h new file mode 100644 index 0000000000..8410ccead3 --- /dev/null +++ b/xen/arch/riscv/include/asm/init.h @@ -0,0 +1,42 @@ +#ifndef _XEN_ASM_INIT_H +#define _XEN_ASM_INIT_H + +#ifndef __ASSEMBLY__ + +struct init_info +{ + /* Pointer to the stack, used by head.S when entering in C */ + unsigned char *stack; + /* Logical CPU ID, used by start_secondary */ + unsigned int cpuid; +}; + +#endif /* __ASSEMBLY__ */ + +/* For assembly routines */ +#define __HEAD .section ".head.text","ax" +#define __INIT .section ".init.text","ax" +#define __FINIT .previous + +#define __INITDATA .section ".init.data","aw",%progbits +#define __INITRODATA .section ".init.rodata","a",%progbits +#define __FINITDATA .previous + +#define __MEMINIT .section ".meminit.text", "ax" +#define __MEMINITDATA .section ".meminit.data", "aw" +#define __MEMINITRODATA .section ".meminit.rodata", "a" + +/* silence warnings when references are OK */ +#define __REF .section ".ref.text", "ax" +#define __REFDATA .section ".ref.data", "aw" +#define __REFCONST .section ".ref.rodata", "a" + +#endif /* _XEN_ASM_INIT_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/io.h b/xen/arch/riscv/include/asm/io.h new file mode 100644 index 0000000000..92d17ebfa8 --- /dev/null +++ b/xen/arch/riscv/include/asm/io.h @@ -0,0 +1,283 @@ +/* + * {read,write}{b,w,l,q} based on arch/arm64/include/asm/io.h + * which was based on arch/arm/include/io.h + * + * Copyright (C) 1996-2000 Russell King + * Copyright (C) 2012 ARM Ltd. + * Copyright (C) 2014 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_IO_H +#define _ASM_RISCV_IO_H + +#include + +/* + * The RISC-V ISA doesn't yet specify how to query or modify PMAs, so we can't + * change the properties of memory regions. This should be fixed by the + * upcoming platform spec. + */ +#define ioremap_nocache(addr, size) ioremap((addr), (size)) +#define ioremap_wc(addr, size) ioremap((addr), (size)) +#define ioremap_wt(addr, size) ioremap((addr), (size)) + +/* Generic IO read/write. These perform native-endian accesses. */ +#define __raw_writeb __raw_writeb +static inline void __raw_writeb(u8 val, volatile void __iomem *addr) +{ + asm volatile("sb %0, 0(%1)" : : "r" (val), "r" (addr)); +} + +#define __raw_writew __raw_writew +static inline void __raw_writew(u16 val, volatile void __iomem *addr) +{ + asm volatile("sh %0, 0(%1)" : : "r" (val), "r" (addr)); +} + +#define __raw_writel __raw_writel +static inline void __raw_writel(u32 val, volatile void __iomem *addr) +{ + asm volatile("sw %0, 0(%1)" : : "r" (val), "r" (addr)); +} + +#ifdef CONFIG_64BIT +#define __raw_writeq __raw_writeq +static inline void __raw_writeq(u64 val, volatile void __iomem *addr) +{ + asm volatile("sd %0, 0(%1)" : : "r" (val), "r" (addr)); +} +#endif + +#define __raw_readb __raw_readb +static inline u8 __raw_readb(const volatile void __iomem *addr) +{ + u8 val; + + asm volatile("lb %0, 0(%1)" : "=r" (val) : "r" (addr)); + return val; +} + +#define __raw_readw __raw_readw +static inline u16 __raw_readw(const volatile void __iomem *addr) +{ + u16 val; + + asm volatile("lh %0, 0(%1)" : "=r" (val) : "r" (addr)); + return val; +} + +#define __raw_readl __raw_readl +static inline u32 __raw_readl(const volatile void __iomem *addr) +{ + u32 val; + + asm volatile("lw %0, 0(%1)" : "=r" (val) : "r" (addr)); + return val; +} + +#ifdef CONFIG_64BIT +#define __raw_readq __raw_readq +static inline u64 __raw_readq(const volatile void __iomem *addr) +{ + u64 val; + + asm volatile("ld %0, 0(%1)" : "=r" (val) : "r" (addr)); + return val; +} +#endif + +/* + * Unordered I/O memory access primitives. These are even more relaxed than + * the relaxed versions, as they don't even order accesses between successive + * operations to the I/O regions. + */ +#define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; }) +#define readw_cpu(c) ({ u16 __r = le16_to_cpu((__force __le16)__raw_readw(c)); __r; }) +#define readl_cpu(c) ({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; }) + +#define writeb_cpu(v,c) ((void)__raw_writeb((v),(c))) +#define writew_cpu(v,c) ((void)__raw_writew((__force u16)cpu_to_le16(v),(c))) +#define writel_cpu(v,c) ((void)__raw_writel((__force u32)cpu_to_le32(v),(c))) + +#ifdef CONFIG_64BIT +#define readq_cpu(c) ({ u64 __r = le64_to_cpu((__force __le64)__raw_readq(c)); __r; }) +#define writeq_cpu(v,c) ((void)__raw_writeq((__force u64)cpu_to_le64(v),(c))) +#endif + +/* + * Relaxed I/O memory access primitives. These follow the Device memory + * ordering rules but do not guarantee any ordering relative to Normal memory + * accesses. These are defined to order the indicated access (either a read or + * write) with all other I/O memory accesses. Since the platform specification + * defines that all I/O regions are strongly ordered on channel 2, no explicit + * fences are required to enforce this ordering. + */ +/* FIXME: These are now the same as asm-generic */ +#define __io_rbr() do {} while (0) +#define __io_rar() do {} while (0) +#define __io_rbw() do {} while (0) +#define __io_raw() do {} while (0) + +#define readb_relaxed(c) ({ u8 __v; __io_rbr(); __v = readb_cpu(c); __io_rar(); __v; }) +#define readw_relaxed(c) ({ u16 __v; __io_rbr(); __v = readw_cpu(c); __io_rar(); __v; }) +#define readl_relaxed(c) ({ u32 __v; __io_rbr(); __v = readl_cpu(c); __io_rar(); __v; }) + +#define writeb_relaxed(v,c) ({ __io_rbw(); writeb_cpu((v),(c)); __io_raw(); }) +#define writew_relaxed(v,c) ({ __io_rbw(); writew_cpu((v),(c)); __io_raw(); }) +#define writel_relaxed(v,c) ({ __io_rbw(); writel_cpu((v),(c)); __io_raw(); }) + +#ifdef CONFIG_64BIT +#define readq_relaxed(c) ({ u64 __v; __io_rbr(); __v = readq_cpu(c); __io_rar(); __v; }) +#define writeq_relaxed(v,c) ({ __io_rbw(); writeq_cpu((v),(c)); __io_raw(); }) +#endif + +/* + * I/O memory access primitives. Reads are ordered relative to any + * following Normal memory access. Writes are ordered relative to any prior + * Normal memory access. The memory barriers here are necessary as RISC-V + * doesn't define any ordering between the memory space and the I/O space. + */ +#define __io_br() do {} while (0) +#define __io_ar(v) __asm__ __volatile__ ("fence i,r" : : : "memory"); +#define __io_bw() __asm__ __volatile__ ("fence w,o" : : : "memory"); +#define __io_aw() do { } while (0) + +#define readb(c) ({ u8 __v; __io_br(); __v = readb_cpu(c); __io_ar(__v); __v; }) +#define readw(c) ({ u16 __v; __io_br(); __v = readw_cpu(c); __io_ar(__v); __v; }) +#define readl(c) ({ u32 __v; __io_br(); __v = readl_cpu(c); __io_ar(__v); __v; }) + +#define writeb(v,c) ({ __io_bw(); writeb_cpu((v),(c)); __io_aw(); }) +#define writew(v,c) ({ __io_bw(); writew_cpu((v),(c)); __io_aw(); }) +#define writel(v,c) ({ __io_bw(); writel_cpu((v),(c)); __io_aw(); }) + +#ifdef CONFIG_64BIT +#define readq(c) ({ u64 __v; __io_br(); __v = readq_cpu(c); __io_ar(__v); __v; }) +#define writeq(v,c) ({ __io_bw(); writeq_cpu((v),(c)); __io_aw(); }) +#endif + +/* + * Emulation routines for the port-mapped IO space used by some PCI drivers. + * These are defined as being "fully synchronous", but also "not guaranteed to + * be fully ordered with respect to other memory and I/O operations". We're + * going to be on the safe side here and just make them: + * - Fully ordered WRT each other, by bracketing them with two fences. The + * outer set contains both I/O so inX is ordered with outX, while the inner just + * needs the type of the access (I for inX and O for outX). + * - Ordered in the same manner as readX/writeX WRT memory by subsuming their + * fences. + * - Ordered WRT timer reads, so udelay and friends don't get elided by the + * implementation. + * Note that there is no way to actually enforce that outX is a non-posted + * operation on RISC-V, but hopefully the timer ordering constraint is + * sufficient to ensure this works sanely on controllers that support I/O + * writes. + */ +#define __io_pbr() __asm__ __volatile__ ("fence io,i" : : : "memory"); +#define __io_par(v) __asm__ __volatile__ ("fence i,ior" : : : "memory"); +#define __io_pbw() __asm__ __volatile__ ("fence iow,o" : : : "memory"); +#define __io_paw() __asm__ __volatile__ ("fence o,io" : : : "memory"); + +#define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) +#define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) +#define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) + +#define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) +#define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) +#define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); }) + +#ifdef CONFIG_64BIT +#define inq(c) ({ u64 __v; __io_pbr(); __v = readq_cpu((void*)(c)); __io_par(__v); __v; }) +#define outq(v,c) ({ __io_pbw(); writeq_cpu((v),(void*)(c)); __io_paw(); }) +#endif + +/* + * Accesses from a single hart to a single I/O address must be ordered. This + * allows us to use the raw read macros, but we still need to fence before and + * after the block to ensure ordering WRT other macros. These are defined to + * perform host-endian accesses so we use __raw instead of __cpu. + */ +#define __io_reads_ins(port, ctype, len, bfence, afence) \ + static inline void __ ## port ## len(const volatile void __iomem *addr, \ + void *buffer, \ + unsigned int count) \ + { \ + bfence; \ + if (count) { \ + ctype *buf = buffer; \ + \ + do { \ + ctype x = __raw_read ## len(addr); \ + *buf++ = x; \ + } while (--count); \ + } \ + afence; \ + } + +#define __io_writes_outs(port, ctype, len, bfence, afence) \ + static inline void __ ## port ## len(volatile void __iomem *addr, \ + const void *buffer, \ + unsigned int count) \ + { \ + bfence; \ + if (count) { \ + const ctype *buf = buffer; \ + \ + do { \ + __raw_write ## len(*buf++, addr); \ + } while (--count); \ + } \ + afence; \ + } + +__io_reads_ins(reads, u8, b, __io_br(), __io_ar(addr)) +__io_reads_ins(reads, u16, w, __io_br(), __io_ar(addr)) +__io_reads_ins(reads, u32, l, __io_br(), __io_ar(addr)) +#define readsb(addr, buffer, count) __readsb(addr, buffer, count) +#define readsw(addr, buffer, count) __readsw(addr, buffer, count) +#define readsl(addr, buffer, count) __readsl(addr, buffer, count) + +__io_reads_ins(ins, u8, b, __io_pbr(), __io_par(addr)) +__io_reads_ins(ins, u16, w, __io_pbr(), __io_par(addr)) +__io_reads_ins(ins, u32, l, __io_pbr(), __io_par(addr)) +#define insb(addr, buffer, count) __insb((void __iomem *)(long)addr, buffer, count) +#define insw(addr, buffer, count) __insw((void __iomem *)(long)addr, buffer, count) +#define insl(addr, buffer, count) __insl((void __iomem *)(long)addr, buffer, count) + +__io_writes_outs(writes, u8, b, __io_bw(), __io_aw()) +__io_writes_outs(writes, u16, w, __io_bw(), __io_aw()) +__io_writes_outs(writes, u32, l, __io_bw(), __io_aw()) +#define writesb(addr, buffer, count) __writesb(addr, buffer, count) +#define writesw(addr, buffer, count) __writesw(addr, buffer, count) +#define writesl(addr, buffer, count) __writesl(addr, buffer, count) + +__io_writes_outs(outs, u8, b, __io_pbw(), __io_paw()) +__io_writes_outs(outs, u16, w, __io_pbw(), __io_paw()) +__io_writes_outs(outs, u32, l, __io_pbw(), __io_paw()) +#define outsb(addr, buffer, count) __outsb((void __iomem *)(long)addr, buffer, count) +#define outsw(addr, buffer, count) __outsw((void __iomem *)(long)addr, buffer, count) +#define outsl(addr, buffer, count) __outsl((void __iomem *)(long)addr, buffer, count) + +#ifdef CONFIG_64BIT +__io_reads_ins(reads, u64, q, __io_br(), __io_ar(addr)) +#define readsq(addr, buffer, count) __readsq(addr, buffer, count) + +__io_reads_ins(ins, u64, q, __io_pbr(), __io_par(addr)) +#define insq(addr, buffer, count) __insq((void __iomem *)addr, buffer, count) + +__io_writes_outs(writes, u64, q, __io_bw(), __io_aw()) +#define writesq(addr, buffer, count) __writesq(addr, buffer, count) + +__io_writes_outs(outs, u64, q, __io_pbr(), __io_paw()) +#define outsq(addr, buffer, count) __outsq((void __iomem *)addr, buffer, count) +#endif + +#endif /* _ASM_RISCV_IO_H */ diff --git a/xen/arch/riscv/include/asm/iocap.h b/xen/arch/riscv/include/asm/iocap.h new file mode 100644 index 0000000000..712f34528e --- /dev/null +++ b/xen/arch/riscv/include/asm/iocap.h @@ -0,0 +1,16 @@ +#ifndef __RISCV_IOCAP_H__ +#define __RISCV_IOCAP_H__ + +#define cache_flush_permitted(d) \ + (!rangeset_is_empty((d)->iomem_caps)) + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/iommu.h b/xen/arch/riscv/include/asm/iommu.h new file mode 100644 index 0000000000..c4f24574ec --- /dev/null +++ b/xen/arch/riscv/include/asm/iommu.h @@ -0,0 +1,46 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef __ARCH_RISCV_IOMMU_H__ +#define __ARCH_RISCV_IOMMU_H__ + +struct arch_iommu +{ + /* Private information for the IOMMU drivers */ + void *priv; +}; + +const struct iommu_ops *iommu_get_ops(void); +void iommu_set_ops(const struct iommu_ops *ops); + +#endif /* __ARCH_RISCV_IOMMU_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/iommu_fwspec.h b/xen/arch/riscv/include/asm/iommu_fwspec.h new file mode 100644 index 0000000000..1a791a19d2 --- /dev/null +++ b/xen/arch/riscv/include/asm/iommu_fwspec.h @@ -0,0 +1,68 @@ +/* + * xen/include/asm-riscv/iommu_fwspec.h + * + * Contains a common structure to hold the per-device firmware data and + * declaration of functions used to maintain that data + * + * Based on Linux's iommu_fwspec support you can find at: + * include/linux/iommu.h + * + * Copyright (C) 2007-2008 Advanced Micro Devices, Inc. + * + * Copyright (C) 2019 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms and conditions of the GNU General Public + * License, version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; If not, see . + */ + +#ifndef __ARCH_RISCV_IOMMU_FWSPEC_H__ +#define __ARCH_RISCV_IOMMU_FWSPEC_H__ + +/* per-device IOMMU instance data */ +struct iommu_fwspec { + /* this device's IOMMU */ + struct device *iommu_dev; + /* IOMMU driver private data for this device */ + void *iommu_priv; + /* number of associated device IDs */ + unsigned int num_ids; + /* IDs which this device may present to the IOMMU */ + uint32_t ids[]; +}; + +int iommu_fwspec_init(struct device *dev, struct device *iommu_dev); +void iommu_fwspec_free(struct device *dev); +int iommu_fwspec_add_ids(struct device *dev, const uint32_t *ids, + unsigned int num_ids); + +static inline struct iommu_fwspec *dev_iommu_fwspec_get(struct device *dev) +{ + return dev->iommu_fwspec; +} + +static inline void dev_iommu_fwspec_set(struct device *dev, + struct iommu_fwspec *fwspec) +{ + dev->iommu_fwspec = fwspec; +} + +#endif /* __ARCH_RISCV_IOMMU_FWSPEC_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/irq.h b/xen/arch/riscv/include/asm/irq.h new file mode 100644 index 0000000000..4323b6ba60 --- /dev/null +++ b/xen/arch/riscv/include/asm/irq.h @@ -0,0 +1,62 @@ +#ifndef _ASM_HW_IRQ_H +#define _ASM_HW_IRQ_H + +#include +#include + +/* + * These defines correspond to the Xen internal representation of the + * IRQ types. We choose to make them the same as the existing device + * tree definitions for convenience. + */ +#define IRQ_TYPE_NONE DT_IRQ_TYPE_NONE +#define IRQ_TYPE_EDGE_RISING DT_IRQ_TYPE_EDGE_RISING +#define IRQ_TYPE_EDGE_FALLING DT_IRQ_TYPE_EDGE_FALLING +#define IRQ_TYPE_EDGE_BOTH DT_IRQ_TYPE_EDGE_BOTH +#define IRQ_TYPE_LEVEL_HIGH DT_IRQ_TYPE_LEVEL_HIGH +#define IRQ_TYPE_LEVEL_LOW DT_IRQ_TYPE_LEVEL_LOW +#define IRQ_TYPE_LEVEL_MASK DT_IRQ_TYPE_LEVEL_MASK +#define IRQ_TYPE_SENSE_MASK DT_IRQ_TYPE_SENSE_MASK +#define IRQ_TYPE_INVALID DT_IRQ_TYPE_INVALID + +#define NR_LOCAL_IRQS 32 +#define NR_IRQS 1024 + +typedef struct { +} vmask_t; + +struct arch_pirq +{ +}; + +struct arch_irq_desc { +}; + +struct irq_desc; + +struct irq_desc *__irq_to_desc(int irq); + +#define irq_to_desc(irq) __irq_to_desc(irq) + +void arch_move_irqs(struct vcpu *v); + +#define domain_pirq_to_irq(d, pirq) (pirq) + +extern const unsigned int nr_irqs; +#define nr_static_irqs NR_IRQS +#define arch_hwdom_irqs(domid) NR_IRQS + +#define arch_evtchn_bind_pirq(d, pirq) ((void)((d) + (pirq))) + +int irq_set_type(unsigned int irq, unsigned int type); +int platform_get_irq(const struct dt_device_node *device, int index); + +#endif /* _ASM_HW_IRQ_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/mem_access.h b/xen/arch/riscv/include/asm/mem_access.h new file mode 100644 index 0000000000..aa7decb629 --- /dev/null +++ b/xen/arch/riscv/include/asm/mem_access.h @@ -0,0 +1,35 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef _ASM_RISCV_MEM_ACCESS_H +#define _ASM_RISCV_MEM_ACCESS_H + +#include +/* vm_event and mem_access are supported on any ARM guest */ +static inline bool p2m_mem_access_sanity_check(struct domain *d) +{ + return true; +} + +#endif /* _ASM_RISCV_MEM_ACCESS_H */ diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h new file mode 100644 index 0000000000..2f2ce6362e --- /dev/null +++ b/xen/arch/riscv/include/asm/mm.h @@ -0,0 +1,320 @@ +#ifndef __ARCH_RISCV_MM__ +#define __ARCH_RISCV_MM__ + +#include +#include +#include +#include +#include + +/* Align Xen to a 2 MiB boundary. */ +#define XEN_PADDR_ALIGN (1 << 21) + +/* TODO: Rewrite this file to be correct */ + +/* + * Per-page-frame information. + * + * Every architecture must ensure the following: + * 1. 'struct page_info' contains a 'struct page_list_entry list'. + * 2. Provide a PFN_ORDER() macro for accessing the order of a free page. + */ +#define PFN_ORDER(_pfn) ((_pfn)->v.free.order) + +extern unsigned long frametable_base_pdx; + +struct page_info +{ + /* Each frame can be threaded onto a doubly-linked list. */ + struct page_list_entry list; + + /* Reference count and various PGC_xxx flags and fields. */ + unsigned long count_info; + + /* Context-dependent fields follow... */ + union { + /* Page is in use: ((count_info & PGC_count_mask) != 0). */ + struct { + /* Type reference count and various PGT_xxx flags and fields. */ + unsigned long type_info; + } inuse; + /* Page is on a free list: ((count_info & PGC_count_mask) == 0). */ + union { + struct { + /* + * Index of the first *possibly* unscrubbed page in the buddy. + * One more bit than maximum possible order to accommodate + * INVALID_DIRTY_IDX. + */ +#define INVALID_DIRTY_IDX ((1UL << (MAX_ORDER + 1)) - 1) + unsigned long first_dirty:MAX_ORDER + 1; + + /* Do TLBs need flushing for safety before next page use? */ + bool need_tlbflush:1; + +#define BUDDY_NOT_SCRUBBING 0 +#define BUDDY_SCRUBBING 1 +#define BUDDY_SCRUB_ABORT 2 + unsigned long scrub_state:2; + }; + + unsigned long val; + } free; + + } u; + + union { + /* Page is in use, but not as a shadow. */ + struct { + /* Owner of this page (zero if page is anonymous). */ + struct domain *domain; + } inuse; + + /* Page is on a free list. */ + struct { + /* Order-size of the free chunk this page is the head of. */ + unsigned int order; + } free; + + } v; + + union { + /* + * Timestamp from 'TLB clock', used to avoid extra safety flushes. + * Only valid for: a) free pages, and b) pages with zero type count + */ + u32 tlbflush_timestamp; + }; + u64 pad; + +}; + +#define PG_shift(idx) (BITS_PER_LONG - (idx)) +#define PG_mask(x, idx) (x ## UL << PG_shift(idx)) + +#define PGT_none PG_mask(0, 1) /* no special uses of this page */ +#define PGT_writable_page PG_mask(1, 1) /* has writable mappings? */ +#define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. */ + + /* Count of uses of this frame as its current type. */ +#define PGT_count_width PG_shift(2) +#define PGT_count_mask ((1UL<count_info&PGC_state) == PGC_state_##st) + +/* Count of references to this frame. */ +#define PGC_count_width PG_shift(9) +#define PGC_count_mask ((1UL<count_info & PGC_xen_heap) +#define is_xen_heap_mfn(mfn) \ + (mfn_valid(_mfn(mfn)) && is_xen_heap_page(mfn_to_page(_mfn(mfn)))) + +#define is_xen_fixed_mfn(mfn) \ + ((mfn_to_maddr(mfn) >= virt_to_maddr(&_start)) && \ + (mfn_to_maddr(mfn) <= virt_to_maddr(&_end))) + +#define page_get_owner(_p) (_p)->v.inuse.domain +#define page_set_owner(_p,_d) ((_p)->v.inuse.domain = (_d)) + +#define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) + +#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) + +#define PDX_GROUP_SHIFT (PAGE_SHIFT + 9) + +/* XXX -- account for base */ +#define mfn_valid(mfn) ({ \ + unsigned long __m_f_n = mfn_x(mfn); \ + likely(pfn_to_pdx(__m_f_n) >= frametable_base_pdx); \ +}) + +/* Convert between machine frame numbers and page-info structures. */ +#define mfn_to_page(mfn) \ + (frame_table + (mfn_to_pdx(mfn) - frametable_base_pdx)) +#define page_to_mfn(pg) \ + pdx_to_mfn((unsigned long)((pg) - frame_table) + frametable_base_pdx) + +/* Convert between machine addresses and page-info structures. */ +#define maddr_to_page(ma) mfn_to_page(maddr_to_mfn(ma)) +#define page_to_maddr(pg) (mfn_to_maddr(page_to_mfn(pg))) + +/* Convert between frame number and address formats. */ +#define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) +#define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) +#define paddr_to_pdx(pa) mfn_to_pdx(maddr_to_mfn(pa)) +#define gfn_to_gaddr(gfn) pfn_to_paddr(gfn_x(gfn)) +#define gaddr_to_gfn(ga) _gfn(paddr_to_pfn(ga)) +#define mfn_to_maddr(mfn) pfn_to_paddr(mfn_x(mfn)) +#define maddr_to_mfn(ma) _mfn(paddr_to_pfn(ma)) +#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) +#define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) + +extern unsigned long max_page; +extern unsigned long total_pages; +extern unsigned long xenheap_base_pdx; + +/* Page-align address and convert to frame number format */ +#define paddr_to_pfn_aligned(paddr) paddr_to_pfn(PAGE_ALIGN(paddr)) + +static inline void *maddr_to_virt(paddr_t ma) +{ + ASSERT(ma - mfn_to_maddr(xenheap_mfn_start) < DIRECTMAP_SIZE); + + return (void *)(XENHEAP_VIRT_START - + (xenheap_base_pdx << PAGE_SHIFT) + + ((ma & ma_va_bottom_mask) | + ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); +} + +paddr_t __virt_to_maddr(vaddr_t va); + +#define virt_to_maddr(va) __virt_to_maddr((vaddr_t) (va)) + +/* Convert between Xen-heap virtual addresses and machine frame numbers. */ +#define __virt_to_mfn(va) paddr_to_pfn((vaddr_t)va) +#define __mfn_to_virt(mfn) (maddr_to_virt((paddr_t)(mfn) << PAGE_SHIFT)) + +/* + * Page needs to be scrubbed. Since this bit can only be set on a page that is + * free (i.e. in PGC_state_free) we can reuse PGC_allocated bit. + */ +#define _PGC_need_scrub _PGC_allocated +#define PGC_need_scrub PGC_allocated + +/* + * We define non-underscored wrappers for above conversion functions. + * These are overriden in various source files while underscored version + * remain intact. + */ +#define virt_to_mfn(va) __virt_to_mfn(va) +#define mfn_to_virt(mfn) __mfn_to_virt(mfn) + +/* Convert between Xen-heap virtual addresses and page-info structures. */ +static inline struct page_info *virt_to_page(const void *v) +{ + unsigned long va = (unsigned long)v; + unsigned long pdx; + + ASSERT(va >= XENHEAP_VIRT_START); + ASSERT(va < xenheap_virt_end); + + pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; + pdx += pfn_to_pdx(mfn_x(xenheap_mfn_start)); + return frame_table + pdx - frametable_base_pdx; +} + +static inline void *page_to_virt(const struct page_info *pg) +{ + return mfn_to_virt(mfn_x(page_to_mfn(pg))); +} + +#define domain_set_alloc_bitsize(d) ((void)0) +#define domain_clamp_alloc_bitsize(d, b) (b) + +/* + * RISC-V does not have an M2P, but common code expects a handful of + * M2P-related defines and functions. Provide dummy versions of these. + */ +#define INVALID_M2P_ENTRY (~0UL) +#define SHARED_M2P_ENTRY (~0UL - 1UL) +#define SHARED_M2P(_e) ((_e) == SHARED_M2P_ENTRY) + +/* Xen always owns P2M on RISC-V (no PV) */ +#define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while (0) +#define mfn_to_gfn(d, mfn) ((void)(d), _gfn(mfn_x(mfn))) + +/* Arch-specific portion of memory_op hypercall. */ +long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); + +extern void put_page_type(struct page_info *page); +static inline void put_page_and_type(struct page_info *page) +{ + put_page_type(page); + put_page(page); +} + +int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, + unsigned int order); + +unsigned long domain_get_maximum_gpfn(struct domain *d); + +static inline +int arch_acquire_resource(struct domain *d, unsigned int type, unsigned int id, + unsigned long frame, unsigned int nr_frames, + xen_pfn_t mfn_list[]) +{ + return -EOPNOTSUPP; +} + +/* + * On RISC-V, all the RAM is currently direct mapped in Xen. + * Hence return always true. + */ +static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr) +{ + return true; +} + +void setup_xenheap_mappings(unsigned long heap_start, unsigned long page_cnt); + +void setup_frametable_mappings(paddr_t ps, paddr_t pe); + +void __attribute__ ((section(".entry"))) +setup_initial_pagetables(pte_t *second, + pte_t *first, + pte_t *zeroeth, + unsigned long map_start, + unsigned long map_end, + unsigned long pa_start); + +void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned attributes); + +static inline void __iomem *ioremap_cache(paddr_t start, size_t len) +{ + return ioremap_attr(start, len, PAGE_HYPERVISOR); +} + +void set_fixmap(unsigned map, mfn_t mfn, unsigned int flags); +void clear_fixmap(unsigned map); +void setup_fixmap_mappings(void); +int pt_update(vaddr_t root, vaddr_t va, paddr_t pa, + bool use_xenheap, struct domain *d, unsigned long flags); + +paddr_t pt_walk(unsigned long root, vaddr_t va, bool is_xen); + +/* Map FDT in boot pagetable */ +extern void *early_fdt_map(paddr_t fdt_paddr); + +#endif /* __ARCH_RISCV_MM__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/monitor.h b/xen/arch/riscv/include/asm/monitor.h new file mode 100644 index 0000000000..e77d21dba4 --- /dev/null +++ b/xen/arch/riscv/include/asm/monitor.h @@ -0,0 +1,65 @@ +/* + * include/asm-RISCV/monitor.h + * + * Arch-specific monitor_op domctl handler. + * + * Copyright (c) 2015 Tamas K Lengyel (tamas@tklengyel.com) + * Copyright (c) 2016, Bitdefender S.R.L. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; If not, see . + */ + +#ifndef __ASM_RISCV_MONITOR_H__ +#define __ASM_RISCV_MONITOR_H__ + +#include +#include + +static inline +void arch_monitor_allow_userspace(struct domain *d, bool allow_userspace) +{ +} + +static inline +int arch_monitor_domctl_op(struct domain *d, struct xen_domctl_monitor_op *mop) +{ + /* No arch-specific monitor ops on RISCV. */ + return -EOPNOTSUPP; +} + +int arch_monitor_domctl_event(struct domain *d, + struct xen_domctl_monitor_op *mop); + +static inline +int arch_monitor_init_domain(struct domain *d) +{ + /* No arch-specific domain initialization on RISCV. */ + return 0; +} + +static inline +void arch_monitor_cleanup_domain(struct domain *d) +{ + /* No arch-specific domain cleanup on RISCV. */ +} + +static inline uint32_t arch_monitor_get_capabilities(struct domain *d) +{ + uint32_t capabilities = 0; + + return capabilities; +} + +int monitor_smc(void); + +#endif /* __ASM_RISCV_MONITOR_H__ */ diff --git a/xen/arch/riscv/include/asm/nospec.h b/xen/arch/riscv/include/asm/nospec.h new file mode 100644 index 0000000000..55087fa831 --- /dev/null +++ b/xen/arch/riscv/include/asm/nospec.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. */ + +#ifndef _ASM_RISCV_NOSPEC_H +#define _ASM_RISCV_NOSPEC_H + +static inline bool evaluate_nospec(bool condition) +{ + return condition; +} + +static inline void block_speculation(void) +{ +} + +#endif /* _ASM_RISCV_NOSPEC_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/numa.h b/xen/arch/riscv/include/asm/numa.h new file mode 100644 index 0000000000..52bdfbc16b --- /dev/null +++ b/xen/arch/riscv/include/asm/numa.h @@ -0,0 +1,41 @@ +#ifndef __ARCH_RISCV_NUMA_H +#define __ARCH_RISCV_NUMA_H + +#include + +typedef u8 nodeid_t; + +/* Fake one node for now. See also node_online_map. */ +#define cpu_to_node(cpu) 0 +#define node_to_cpumask(node) (cpu_online_map) + +static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) +{ + return 0; +} + +/* + * TODO: make first_valid_mfn static when NUMA is supported on RISCV, this + * is required because the dummy helpers are using it. + */ +extern mfn_t first_valid_mfn; + +/* XXX: implement NUMA support */ +#define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) +#define node_start_pfn(nid) (mfn_x(first_valid_mfn)) +#define __node_distance(a, b) (20) + +static inline unsigned int arch_get_dma_bitsize(void) +{ + return 32; +} + +#endif /* __ARCH_RISCV_NUMA_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/p2m.h b/xen/arch/riscv/include/asm/p2m.h new file mode 100644 index 0000000000..e13cad7b82 --- /dev/null +++ b/xen/arch/riscv/include/asm/p2m.h @@ -0,0 +1,307 @@ +#ifndef _XEN_P2M_H +#define _XEN_P2M_H + +#include +#include +#include +#include +#include + +#include +#include + +#define paddr_bits PADDR_BITS + +/* Holds the bit size of IPAs in p2m tables. */ +extern unsigned int p2m_ipa_bits; + +struct domain; + +extern void memory_type_changed(struct domain *); + +/* Per-p2m-table state */ +struct p2m_domain { + /* + * Lock that protects updates to the p2m. + */ + rwlock_t lock; + + /* Page containing root p2m table */ + struct page_info *root; + + /* Pages used to construct the p2m */ + struct page_list_head pages; + + /* Address Translation Table for the p2m */ + uint64_t hgatp; +}; + +/* + * List of possible type for each page in the p2m entry. + * The number of available bit per page in the pte for this purpose is 4 bits. + * So it's possible to only have 16 fields. If we run out of value in the + * future, it's possible to use higher value for pseudo-type and don't store + * them in the p2m entry. + */ +typedef enum { + p2m_invalid = 0, /* Nothing mapped here */ + p2m_ram_rw, /* Normal read/write guest RAM */ + p2m_ram_ro, /* Read-only; writes are silently dropped */ + p2m_mmio_direct_dev,/* Read/write mapping of genuine Device MMIO area */ + p2m_mmio_direct_nc, /* Read/write mapping of genuine MMIO area non-cacheable */ + p2m_mmio_direct_c, /* Read/write mapping of genuine MMIO area cacheable */ + p2m_map_foreign_rw, /* Read/write RAM pages from foreign domain */ + p2m_map_foreign_ro, /* Read-only RAM pages from foreign domain */ + p2m_grant_map_rw, /* Read/write grant mapping */ + p2m_grant_map_ro, /* Read-only grant mapping */ + /* The types below are only used to decide the page attribute in the P2M */ + p2m_iommu_map_rw, /* Read/write iommu mapping */ + p2m_iommu_map_ro, /* Read-only iommu mapping */ + p2m_max_real_type, /* Types after this won't be store in the p2m */ +} p2m_type_t; + +/* We use bitmaps and mask to handle groups of types */ +#define p2m_to_mask(_t) (1UL << (_t)) + +/* RAM types, which map to real machine frames */ +#define P2M_RAM_TYPES (p2m_to_mask(p2m_ram_rw) | \ + p2m_to_mask(p2m_ram_ro)) + +/* Grant mapping types, which map to a real frame in another VM */ +#define P2M_GRANT_TYPES (p2m_to_mask(p2m_grant_map_rw) | \ + p2m_to_mask(p2m_grant_map_ro)) + +/* Foreign mappings types */ +#define P2M_FOREIGN_TYPES (p2m_to_mask(p2m_map_foreign_rw) | \ + p2m_to_mask(p2m_map_foreign_ro)) + +/* Useful predicates */ +#define p2m_is_ram(_t) (p2m_to_mask(_t) & P2M_RAM_TYPES) +#define p2m_is_foreign(_t) (p2m_to_mask(_t) & P2M_FOREIGN_TYPES) +#define p2m_is_any_ram(_t) (p2m_to_mask(_t) & \ + (P2M_RAM_TYPES | P2M_GRANT_TYPES | \ + P2M_FOREIGN_TYPES)) + +/* All common type definitions should live ahead of this inclusion. */ +#ifdef _XEN_P2M_COMMON_H +# error "xen/p2m-common.h should not be included directly" +#endif +#include + +static inline +void p2m_altp2m_check(struct vcpu *v, uint16_t idx) +{ + /* Not supported on ARM. */ +} + +/* Second stage paging setup, to be called on all CPUs */ +void setup_virt_paging(void); + +/* Init the datastructures for later use by the p2m code */ +int p2m_init(struct domain *d); + +/* Return all the p2m resources to Xen. */ +void p2m_teardown(struct domain *d); + +/* + * Remove mapping refcount on each mapping page in the p2m + * + * TODO: For the moment only foreign mappings are handled + */ +int relinquish_p2m_mapping(struct domain *d); + +/* Context switch */ +void p2m_save_state(struct vcpu *p); +void p2m_restore_state(struct vcpu *n); + +/* Print debugging/statistial info about a domain's p2m */ +void p2m_dump_info(struct domain *d); + +static inline void p2m_write_lock(struct p2m_domain *p2m) +{ + write_lock(&p2m->lock); +} + +void p2m_write_unlock(struct p2m_domain *p2m); + +static inline void p2m_read_lock(struct p2m_domain *p2m) +{ + read_lock(&p2m->lock); +} + +static inline void p2m_read_unlock(struct p2m_domain *p2m) +{ + read_unlock(&p2m->lock); +} + +static inline int p2m_is_locked(struct p2m_domain *p2m) +{ + return rw_is_locked(&p2m->lock); +} + +static inline int p2m_is_write_locked(struct p2m_domain *p2m) +{ + return rw_is_write_locked(&p2m->lock); +} + +void p2m_tlb_flush_sync(struct p2m_domain *p2m); + +/* Look up the MFN corresponding to a domain's GFN. */ +mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t); + +/* + * Get details of a given gfn. + * The P2M lock should be taken by the caller. + */ +mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, + p2m_type_t *t, p2m_access_t *a, + unsigned int *page_order, + bool *valid); + +/* + * Direct set a p2m entry: only for use by the P2M code. + * The P2M write lock should be taken. + */ +int p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned long nr, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a); + +bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn); + +void p2m_invalidate_root(struct p2m_domain *p2m); + +/* + * Clean & invalidate caches corresponding to a region [start,end) of guest + * address space. + * + * start will get updated if the function is preempted. + */ +int p2m_cache_flush_range(struct domain *d, gfn_t *pstart, gfn_t end); + +void p2m_set_way_flush(struct vcpu *v); + +void p2m_toggle_cache(struct vcpu *v, bool was_enabled); + +void p2m_flush_vm(struct vcpu *v); + +/* + * Map a region in the guest p2m with a specific p2m type. + * The memory attributes will be derived from the p2m type. + */ +int map_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn, + p2m_type_t p2mt); + +int unmap_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn); + +int map_dev_mmio_region(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn); + +int guest_physmap_add_entry(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned long page_order, + p2m_type_t t); + +/* Untyped version for RAM only, for compatibility */ +static inline int guest_physmap_add_page(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned int page_order) +{ + return guest_physmap_add_entry(d, gfn, mfn, page_order, p2m_ram_rw); +} + +mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn); + +/* Look up a GFN and take a reference count on the backing page. */ +typedef unsigned int p2m_query_t; +#define P2M_ALLOC (1u<<0) /* Populate PoD and paged-out entries */ +#define P2M_UNSHARE (1u<<1) /* Break CoW sharing */ + +struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, + p2m_type_t *t); + + +struct page_info *get_page_from_gfn(struct domain *d, unsigned long gfn, + p2m_type_t *t, p2m_query_t q); + +int get_page_type(struct page_info *page, unsigned long type); +bool is_iomem_page(mfn_t mfn); +static inline int get_page_and_type(struct page_info *page, + struct domain *domain, + unsigned long type) +{ + int rc = get_page(page, domain); + + if ( likely(rc) && unlikely(!get_page_type(page, type)) ) + { + put_page(page); + rc = 0; + } + + return rc; +} + +/* get host p2m table */ +#define p2m_get_hostp2m(d) (&(d)->arch.p2m) + +static inline bool p2m_vm_event_sanity_check(struct domain *d) +{ + return true; +} + +/* + * Return the start of the next mapping based on the order of the + * current one. + */ +static inline gfn_t gfn_next_boundary(gfn_t gfn, unsigned int order) +{ + /* + * The order corresponds to the order of the mapping (or invalid + * range) in the page table. So we need to align the GFN before + * incrementing. + */ + gfn = _gfn(gfn_x(gfn) & ~((1UL << order) - 1)); + + return gfn_add(gfn, 1UL << order); +} + +/* + * A vCPU has cache enabled only when the MMU is enabled and data cache + * is enabled. + */ +static inline bool vcpu_has_cache_enabled(struct vcpu *v) +{ + /* Only works with the current vCPU */ + ASSERT(current == v); + + return 0; +} + +static inline bool arch_acquire_resource_check(struct domain *d) +{ + BUG(); /* unimplemented */ + return true; +} + +#endif /* _XEN_P2M_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/page-bits.h b/xen/arch/riscv/include/asm/page-bits.h new file mode 100644 index 0000000000..c0e3d80928 --- /dev/null +++ b/xen/arch/riscv/include/asm/page-bits.h @@ -0,0 +1,14 @@ +#ifndef __RISCV_PAGE_SHIFT_H__ +#define __RISCV_PAGE_SHIFT_H__ + +#define PAGE_SHIFT 12 + +#ifdef CONFIG_RISCV_64 +#define PADDR_BITS 39 +#else +#define PADDR_BITS 32 +#endif + +#define VADDR_BITS 32 + +#endif /* __RISCV_PAGE_SHIFT_H__ */ diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h new file mode 100644 index 0000000000..4730e21ffb --- /dev/null +++ b/xen/arch/riscv/include/asm/page.h @@ -0,0 +1,319 @@ +/* + * Copyright (C) 2009 Chen Liqin + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2017 SiFive + * Copyright (C) 2017 XiaojingZhu + * Copyright (C) 2019 Bobby Eshleman + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_PAGE_H +#define _ASM_RISCV_PAGE_H + +#include +#include +#include +#include +#include + +#define KERN_VIRT_SIZE (-PAGE_OFFSET) + +#define PAGE_ENTRIES 512 +#define VPN_BITS (9) +#define VPN_MASK ((unsigned long)((1 << VPN_BITS) - 1)) + +#ifdef CONFIG_RISCV_64 +/* L3 index Bit[47:39] */ +#define THIRD_SHIFT (39) +#define THIRD_MASK (VPN_MASK << THIRD_SHIFT) +/* L2 index Bit[38:30] */ +#define SECOND_SHIFT (30) +#define SECOND_MASK (VPN_MASK << SECOND_SHIFT) +/* L1 index Bit[29:21] */ +#define FIRST_SHIFT (21) +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) +/* L0 index Bit[20:12] */ +#define ZEROETH_SHIFT (12) +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) + +#else // CONFIG_RISCV_32 + +/* L1 index Bit[31:22] */ +#define FIRST_SHIFT (22) +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) + +/* L0 index Bit[21:12] */ +#define ZEROETH_SHIFT (12) +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) +#endif + +#define THIRD_SIZE (1 << THIRD_SHIFT) +#define THIRD_MAP_MASK (~(THIRD_SIZE - 1)) +#define SECOND_SIZE (1 << SECOND_SHIFT) +#define SECOND_MAP_MASK (~(SECOND_SIZE - 1)) +#define FIRST_SIZE (1 << FIRST_SHIFT) +#define FIRST_MAP_MASK (~(FIRST_SIZE - 1)) +#define ZEROETH_SIZE (1 << ZEROETH_SHIFT) +#define ZEROETH_MAP_MASK (~(ZEROETH_SIZE - 1)) + +#define PTE_ADDR_MASK 0x003FFFFFFFFFFC00ULL +#define PTE_SHIFT 10 +#define PTE_RSW_MASK 0x0000000000000300ULL +#define PTE_RSW_SHIFT 8 + +#define PTE_USER_SHIFT 4 +#define PTE_PERM_MASK (PTE_EXECUTE_MASK | \ + PTE_WRITE_MASK | \ + PTE_READ_MASK) + +#define PTE_VALID BIT(0, UL) +#define PTE_READABLE BIT(1, UL) +#define PTE_WRITABLE BIT(2, UL) +#define PTE_EXECUTABLE BIT(3, UL) +#define PTE_USER BIT(4, UL) +#define PTE_GLOBAL BIT(5, UL) +#define PTE_ACCESSED BIT(6, UL) +#define PTE_DIRTY BIT(7, UL) +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) + +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE | PTE_EXECUTABLE) +#define PTE_TABLE (PTE_VALID) + +/* Calculate the offsets into the pagetables for a given VA */ +#define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT) +#define first_linear_offset(va) ((va) >> FIRST_SHIFT) +#define second_linear_offset(va) ((va) >> SECOND_SHIFT) +#define third_linear_offset(va) ((va) >> THIRD_SHIFT) + +#define pagetable_zeroeth_index(va) zeroeth_linear_offset((va) & ZEROETH_MASK) +#define pagetable_first_index(va) first_linear_offset((va) & FIRST_MASK) +#define pagetable_second_index(va) second_linear_offset((va) & SECOND_MASK) +#define pagetable_third_index(va) third_linear_offset((va) & THIRD_MASK) + +#ifndef __ASSEMBLY__ + +#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) +#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) + +/* align addr on a size boundary - adjust address up/down if needed */ +#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1))) +#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1))) + +/* align addr on a size boundary - adjust address up if needed */ +#define _ALIGN(addr, size) _ALIGN_UP(addr, size) + +#define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) +#define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) + +#define clear_user_page(pgaddr, vaddr, page) memset((pgaddr), 0, PAGE_SIZE) +#define copy_user_page(vto, vfrom, vaddr, topg) \ + memcpy((vto), (vfrom), PAGE_SIZE) + +/* + * Attribute Indexes. + * + */ +#define MT_NORMAL 0x0 + +#define _PAGE_XN_BIT 3 +#define _PAGE_RO_BIT 4 +#define _PAGE_XN (1U << _PAGE_XN_BIT) +#define _PAGE_RO (1U << _PAGE_RO_BIT) +#define PAGE_XN_MASK(x) (((x) >> _PAGE_XN_BIT) & 0x1U) +#define PAGE_RO_MASK(x) (((x) >> _PAGE_RO_BIT) & 0x1U) + +/* + * _PAGE_DEVICE and _PAGE_NORMAL are convenience defines. They are not + * meant to be used outside of this header. + */ +#define _PAGE_DEVICE _PAGE_XN +#define _PAGE_NORMAL MT_NORMAL + +#define PAGE_HYPERVISOR_RO (_PAGE_NORMAL|_PAGE_RO|_PAGE_XN) +#define PAGE_HYPERVISOR_RX (_PAGE_NORMAL|_PAGE_RO) +#define PAGE_HYPERVISOR_RW (_PAGE_NORMAL|_PAGE_XN) + +#define PAGE_HYPERVISOR PAGE_HYPERVISOR_RW +#define PAGE_HYPERVISOR_NOCACHE (_PAGE_DEVICE) +#define PAGE_HYPERVISOR_WC (_PAGE_DEVICE) + +/* Invalidate all instruction caches in Inner Shareable domain to PoU */ +static inline void invalidate_icache(void) +{ + asm volatile ("fence.i" ::: "memory"); +} + +static inline int invalidate_dcache_va_range(const void *p, unsigned long size) +{ + /* TODO */ + return 0; +} + +static inline int clean_dcache_va_range(const void *p, unsigned long size) +{ + /* TODO */ + return 0; +} + +static inline int clean_and_invalidate_dcache_va_range + (const void *p, unsigned long size) +{ + /* TODO */ + return 0; +} + +/* + * Use struct definitions to apply C type checking + */ + +/* Page Global Directory entry */ +typedef struct { + unsigned long pgd; +} pgd_t; + +/* Page Table entry */ +typedef struct { + uint64_t pte; +} pte_t; + +typedef struct { + unsigned long pgprot; +} pgprot_t; + +typedef struct page *pgtable_t; + +#define pte_val(x) ((x).pte) +#define pgd_val(x) ((x).pgd) +#define pgprot_val(x) ((x).pgprot) + +static inline bool pte_is_table(pte_t *p) +{ + return (((p->pte) & (PTE_VALID + | PTE_READABLE + | PTE_WRITABLE + | PTE_EXECUTABLE)) == PTE_VALID); +} + +static inline bool pte_is_valid(pte_t *p) +{ + return p->pte & PTE_VALID; +} + +static inline bool pte_is_leaf(pte_t *p) +{ + return (p->pte & (PTE_WRITABLE | PTE_READABLE | PTE_EXECUTABLE)); +} + +/* Shift the VPN[x] or PPN[x] fields of a virtual or physical address + * to become the shifted PPN[x] fields of a page table entry */ +#define addr_to_ppn(x) (((x) >> PAGE_SHIFT) << PTE_SHIFT) + +static inline pte_t paddr_to_pte(unsigned long paddr) +{ + return (pte_t) { .pte = addr_to_ppn(paddr) }; +} + +static inline paddr_t pte_to_paddr(pte_t *p) +{ + return (paddr_t) ((p->pte >> PTE_SHIFT) << PAGE_SHIFT); +} + +#define pte_get_mfn(pte_) _mfn(((pte_).pte) >> PTE_SHIFT) + +#define MEGAPAGE_ALIGN(x) ((x) & FIRST_MAP_MASK) +#define GIGAPAGE_ALIGN(x) ((x) & SECOND_MAP_MASK) + +#define paddr_to_megapage_ppn(x) addr_to_ppn(MEGAPAGE_ALIGN(x)) +#define paddr_to_gigapage_ppn(x) addr_to_ppn(GIGAPAGE_ALIGN(x)) + +#define __pte(x) ((pte_t) { (x) }) +#define __pgd(x) ((pgd_t) { (x) }) +#define __pgprot(x) ((pgprot_t) { (x) }) + +#ifdef CONFIG_64BIT +#define PTE_FMT "%016lx" +#else +#define PTE_FMT "%08lx" +#endif + +extern unsigned long va_pa_offset; +extern unsigned long pfn_base; + +extern unsigned long max_low_pfn; +extern unsigned long min_low_pfn; + +#define __pa(x) ((unsigned long)(x) - va_pa_offset) +#define __va(x) ((void *)((unsigned long) (x) + va_pa_offset)) + +#define pfn_valid(pfn) \ + (((pfn) >= pfn_base) && (((pfn)-pfn_base) < max_mapnr)) + +#define ARCH_PFN_OFFSET (pfn_base) + +#endif /* __ASSEMBLY__ */ + +#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) + +#define virt_addr_valid(vaddr) (pfn_valid(virt_to_pfn(vaddr))) + +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | \ + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) + +/* Flush the dcache for an entire page. */ +void flush_page_to_ram(unsigned long mfn, bool sync_icache); + +static inline uint64_t va_to_par(vaddr_t va) +{ + register unsigned long __mepc asm ("a2") = va; + register unsigned long __mstatus asm ("a3"); + register unsigned long __bsstatus asm ("a4"); + unsigned long val; + unsigned long rvc_mask = 3, tmp; + asm ("csrrs %[mstatus], "STR(CSR_MSTATUS)", %[mprv]\n" + "csrrs %[bsstatus], "STR(CSR_BSSTATUS)", %[smxr]\n" + "and %[tmp], %[addr], 2\n" + "bnez %[tmp], 1f\n" +#if CONFIG_RISCV_64 + STR(LWU) " %[insn], (%[addr])\n" +#else + STR(LW) " %[insn], (%[addr])\n" +#endif + "and %[tmp], %[insn], %[rvc_mask]\n" + "beq %[tmp], %[rvc_mask], 2f\n" + "sll %[insn], %[insn], %[xlen_minus_16]\n" + "srl %[insn], %[insn], %[xlen_minus_16]\n" + "j 2f\n" + "1:\n" + "lhu %[insn], (%[addr])\n" + "and %[tmp], %[insn], %[rvc_mask]\n" + "bne %[tmp], %[rvc_mask], 2f\n" + "lhu %[tmp], 2(%[addr])\n" + "sll %[tmp], %[tmp], 16\n" + "add %[insn], %[insn], %[tmp]\n" + "2: csrw "STR(CSR_BSSTATUS)", %[bsstatus]\n" + "csrw "STR(CSR_MSTATUS)", %[mstatus]" + : [mstatus] "+&r" (__mstatus), [bsstatus] "+&r" (__bsstatus), + [insn] "=&r" (val), [tmp] "=&r" (tmp) + : [mprv] "r" (MSTATUS_MPRV | SSTATUS_MXR), [smxr] "r" (SSTATUS_MXR), + [addr] "r" (__mepc), [rvc_mask] "r" (rvc_mask), + [xlen_minus_16] "i" (__riscv_xlen - 16)); + + return val; +} + +/* Write a pagetable entry. */ +static inline void write_pte(pte_t *p, pte_t pte) +{ + *p = pte; + asm volatile ("sfence.vma"); +} + +#endif /* _ASM_RISCV_PAGE_H */ diff --git a/xen/arch/riscv/include/asm/paging.h b/xen/arch/riscv/include/asm/paging.h new file mode 100644 index 0000000000..6d1a000246 --- /dev/null +++ b/xen/arch/riscv/include/asm/paging.h @@ -0,0 +1,16 @@ +#ifndef _XEN_PAGING_H +#define _XEN_PAGING_H + +#define paging_mode_translate(d) (1) +#define paging_mode_external(d) (1) + +#endif /* XEN_PAGING_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/pci.h b/xen/arch/riscv/include/asm/pci.h new file mode 100644 index 0000000000..0ccf335e34 --- /dev/null +++ b/xen/arch/riscv/include/asm/pci.h @@ -0,0 +1,31 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef __RISCV_PCI_H__ +#define __RISCV_PCI_H__ + +struct arch_pci_dev { +}; + +#endif /* __RISCV_PCI_H__ */ diff --git a/xen/arch/riscv/include/asm/percpu.h b/xen/arch/riscv/include/asm/percpu.h new file mode 100644 index 0000000000..05faa187ab --- /dev/null +++ b/xen/arch/riscv/include/asm/percpu.h @@ -0,0 +1,35 @@ +#ifndef __RISCV_PERCPU_H__ +#define __RISCV_PERCPU_H__ + +#ifndef __ASSEMBLY__ + +#include +#include +#include + +extern char __per_cpu_start[], __per_cpu_data_end[]; +extern unsigned long __per_cpu_offset[NR_CPUS]; +void percpu_init_areas(void); + +#define per_cpu(var, cpu) \ + (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) + +#define this_cpu(var) \ + (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[get_processor_id()])) + +#define per_cpu_ptr(var, cpu) \ + (*RELOC_HIDE(var, __per_cpu_offset[cpu])) +#define this_cpu_ptr(var) \ + (*RELOC_HIDE(var, get_processor_id())) + +#endif + +#endif /* __RISCV_PERCPU_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h new file mode 100644 index 0000000000..30eb2c5987 --- /dev/null +++ b/xen/arch/riscv/include/asm/processor.h @@ -0,0 +1,176 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * Copyright 2021 (C) Bobby Eshleman + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef _ASM_RISCV_PROCESSOR_H +#define _ASM_RISCV_PROCESSOR_H + +#include + +#define RISCV_CPU_USER_REGS_zero 0 +#define RISCV_CPU_USER_REGS_ra 1 +#define RISCV_CPU_USER_REGS_sp 2 +#define RISCV_CPU_USER_REGS_gp 3 +#define RISCV_CPU_USER_REGS_tp 4 +#define RISCV_CPU_USER_REGS_t0 5 +#define RISCV_CPU_USER_REGS_t1 6 +#define RISCV_CPU_USER_REGS_t2 7 +#define RISCV_CPU_USER_REGS_s0 8 +#define RISCV_CPU_USER_REGS_s1 9 +#define RISCV_CPU_USER_REGS_a0 10 +#define RISCV_CPU_USER_REGS_a1 11 +#define RISCV_CPU_USER_REGS_a2 12 +#define RISCV_CPU_USER_REGS_a3 13 +#define RISCV_CPU_USER_REGS_a4 14 +#define RISCV_CPU_USER_REGS_a5 15 +#define RISCV_CPU_USER_REGS_a6 16 +#define RISCV_CPU_USER_REGS_a7 17 +#define RISCV_CPU_USER_REGS_s2 18 +#define RISCV_CPU_USER_REGS_s3 19 +#define RISCV_CPU_USER_REGS_s4 20 +#define RISCV_CPU_USER_REGS_s5 21 +#define RISCV_CPU_USER_REGS_s6 22 +#define RISCV_CPU_USER_REGS_s7 23 +#define RISCV_CPU_USER_REGS_s8 24 +#define RISCV_CPU_USER_REGS_s9 25 +#define RISCV_CPU_USER_REGS_s10 26 +#define RISCV_CPU_USER_REGS_s11 27 +#define RISCV_CPU_USER_REGS_t3 28 +#define RISCV_CPU_USER_REGS_t4 29 +#define RISCV_CPU_USER_REGS_t5 30 +#define RISCV_CPU_USER_REGS_t6 31 +#define RISCV_CPU_USER_REGS_sepc 32 +#define RISCV_CPU_USER_REGS_sstatus 33 +#define RISCV_CPU_USER_REGS_pregs 34 +#define RISCV_CPU_USER_REGS_last 35 + +#define RISCV_CPU_USER_REGS_OFFSET(x) ((RISCV_CPU_USER_REGS_##x) * __SIZEOF_POINTER__) +#define RISCV_CPU_USER_REGS_SIZE RISCV_CPU_USER_REGS_OFFSET(last) + +#define RISCV_PCPUINFO_processor_id 0 +#define RISCV_PCPUINFO_guest_cpu_info 1 +#define RISCV_PCPUINFO_stack_cpu_regs 2 +#define RISCV_PCPUINFO_tmp 3 +#define RISCV_PCPUINFO_last 4 +#define RISCV_PCPUINFO_OFFSET(x) ((RISCV_PCPUINFO_##x) * __SIZEOF_POINTER__) +#define RISCV_PCPUINFO_SIZE RISCV_PCPUINFO_OFFSET(last) + +#ifndef __ASSEMBLY__ + +register struct pcpu_info *tp asm ("tp"); + +struct pcpu_info { + unsigned long processor_id; + /* cpu_info of the guest. Always on the top of the stack. */ + struct cpu_info *guest_cpu_info; + /* CPU registers of the current trap. Differ from guest_cpu_info if trapped from xen. */ + struct cpu_user_regs *stack_cpu_regs; + + /* temporary variable to be used during save/restore of vcpu regs */ + unsigned long tmp; +}; + +/* tp points to one of these */ +extern struct pcpu_info pcpu_info[NR_CPUS]; + +#define get_processor_id() (tp->processor_id) +#define set_processor_id(id) do { \ + tp->processor_id = id; \ +} while(0) + +/* On stack VCPU state */ +struct cpu_user_regs +{ + register_t zero; + register_t ra; + register_t sp; + register_t gp; + register_t tp; + register_t t0; + register_t t1; + register_t t2; + register_t s0; + register_t s1; + register_t a0; + register_t a1; + register_t a2; + register_t a3; + register_t a4; + register_t a5; + register_t a6; + register_t a7; + register_t s2; + register_t s3; + register_t s4; + register_t s5; + register_t s6; + register_t s7; + register_t s8; + register_t s9; + register_t s10; + register_t s11; + register_t t3; + register_t t4; + register_t t5; + register_t t6; + register_t sepc; + register_t sstatus; + /* pointer to previous stack_cpu_regs */ + register_t pregs; +}; + +void show_execution_state(const struct cpu_user_regs *regs); +void show_registers(const struct cpu_user_regs *regs); + +/* All a bit UP for the moment */ +#define cpu_to_core(_cpu) (0) +#define cpu_to_socket(_cpu) (0) + +/* Based on Linux: arch/riscv/include/asm/processor.h */ + +static inline void cpu_relax(void) +{ + int dummy; + /* In lieu of a halt instruction, induce a long-latency stall. */ + __asm__ __volatile__ ("div %0, %0, zero" : "=r" (dummy)); + barrier(); +} + +static inline void wait_for_interrupt(void) +{ + __asm__ __volatile__ ("wfi"); +} + +#endif /* __ASSEMBLY__ */ + +#endif /* _ASM_RISCV_PROCESSOR_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/random.h b/xen/arch/riscv/include/asm/random.h new file mode 100644 index 0000000000..b4acee276b --- /dev/null +++ b/xen/arch/riscv/include/asm/random.h @@ -0,0 +1,9 @@ +#ifndef __ASM_RANDOM_H__ +#define __ASM_RANDOM_H__ + +static inline unsigned int arch_get_random(void) +{ + return 0; +} + +#endif /* __ASM_RANDOM_H__ */ diff --git a/xen/arch/riscv/include/asm/regs.h b/xen/arch/riscv/include/asm/regs.h new file mode 100644 index 0000000000..103cf1e91e --- /dev/null +++ b/xen/arch/riscv/include/asm/regs.h @@ -0,0 +1,42 @@ +#ifndef __ARM_REGS_H__ +#define __ARM_REGS_H__ + +#define PSR_MODE_MASK 0x1f + +#ifndef __ASSEMBLY__ + +#include +#include +#include +#include +#include + +#define hyp_mode(r) (0) + +static inline bool guest_mode(const struct cpu_user_regs *r) +{ + unsigned long diff = (char *)guest_cpu_user_regs() - (char *)(r); + /* Frame pointer must point into current CPU stack. */ + ASSERT(diff < STACK_SIZE); + /* If not a guest frame, it must be a hypervisor frame. */ + ASSERT((diff == 0) || hyp_mode(r)); + /* Return TRUE if it's a guest frame. */ + return (diff == 0); +} + +#define return_reg(v) ((v)->arch.cpu_info->guest_cpu_user_regs.r0) + +register_t get_user_reg(struct cpu_user_regs *regs, int reg); +void set_user_reg(struct cpu_user_regs *regs, int reg, register_t val); + +#endif + +#endif /* __ARM_REGS_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/riscv_encoding.h b/xen/arch/riscv/include/asm/riscv_encoding.h new file mode 100644 index 0000000000..a94ab5e652 --- /dev/null +++ b/xen/arch/riscv/include/asm/riscv_encoding.h @@ -0,0 +1,960 @@ +/* + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * + * Authors: + * Anup Patel + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * + * The source has been largely adapted from OpenSBI: + * include/sbi/riscv_encodnig.h + * + * The original code is licensed under the BSD 2-clause license. + * + */ + +#ifndef __RISCV_ENCODING_H__ +#define __RISCV_ENCODING_H__ + +#define _UL(X) _AC(X, UL) +#define _ULL(X) _AC(X, ULL) + +/* clang-format off */ +#define MSTATUS_SIE _UL(0x00000002) +#define MSTATUS_MIE _UL(0x00000008) +#define MSTATUS_SPIE_SHIFT 5 +#define MSTATUS_SPIE (_UL(1) << MSTATUS_SPIE_SHIFT) +#define MSTATUS_UBE _UL(0x00000040) +#define MSTATUS_MPIE _UL(0x00000080) +#define MSTATUS_SPP_SHIFT 8 +#define MSTATUS_SPP (_UL(1) << MSTATUS_SPP_SHIFT) +#define MSTATUS_MPP_SHIFT 11 +#define MSTATUS_MPP (_UL(3) << MSTATUS_MPP_SHIFT) +#define MSTATUS_FS _UL(0x00006000) +#define MSTATUS_FS_OFF _UL(0x00000000) +#define MSTATUS_FS_INITIAL _UL(0x00002000) +#define MSTATUS_FS_CLEAN _UL(0x00004000) +#define MSTATUS_FS_DIRTY _UL(0x00006000) +#define MSTATUS_XS _UL(0x00018000) +#define MSTATUS_XS_OFF _UL(0x00000000) +#define MSTATUS_XS_INITIAL _UL(0x00008000) +#define MSTATUS_XS_CLEAN _UL(0x00010000) +#define MSTATUS_XS_DIRTY _UL(0x00018000) +#define MSTATUS_VS _UL(0x01800000) +#define MSTATUS_VS_OFF _UL(0x00000000) +#define MSTATUS_VS_INITIAL _UL(0x00800000) +#define MSTATUS_VS_CLEAN _UL(0x01000000) +#define MSTATUS_VS_DIRTY _UL(0x01800000) +#define MSTATUS_MPRV _UL(0x00020000) +#define MSTATUS_SUM _UL(0x00040000) +#define MSTATUS_MXR _UL(0x00080000) +#define MSTATUS_TVM _UL(0x00100000) +#define MSTATUS_TW _UL(0x00200000) +#define MSTATUS_TSR _UL(0x00400000) +#define MSTATUS32_SD _UL(0x80000000) +#if __riscv_xlen == 64 +#define MSTATUS_UXL _ULL(0x0000000300000000) +#define MSTATUS_SXL _ULL(0x0000000C00000000) +#define MSTATUS_SBE _ULL(0x0000001000000000) +#define MSTATUS_MBE _ULL(0x0000002000000000) +#define MSTATUS_MPV _ULL(0x0000008000000000) +#else +#define MSTATUSH_SBE _UL(0x00000010) +#define MSTATUSH_MBE _UL(0x00000020) +#define MSTATUSH_MPV _UL(0x00000080) +#endif +#define MSTATUS32_SD _UL(0x80000000) +#define MSTATUS64_SD _ULL(0x8000000000000000) + +#define SSTATUS_SIE MSTATUS_SIE +#define SSTATUS_SPIE_SHIFT MSTATUS_SPIE_SHIFT +#define SSTATUS_SPIE MSTATUS_SPIE +#define SSTATUS_SPP_SHIFT MSTATUS_SPP_SHIFT +#define SSTATUS_SPP MSTATUS_SPP +#define SSTATUS_FS MSTATUS_FS +#define SSTATUS_FS_OFF MSTATUS_FS_OFF +#define SSTATUS_FS_INITIAL MSTATUS_FS_INITIAL +#define SSTATUS_FS_CLEAN MSTATUS_FS_CLEAN +#define SSTATUS_FS_DIRTY MSTATUS_FS_DIRTY +#define SSTATUS_XS MSTATUS_XS +#define SSTATUS_XS_OFF MSTATUS_XS_OFF +#define SSTATUS_XS_INITIAL MSTATUS_XS_INITIAL +#define SSTATUS_XS_CLEAN MSTATUS_XS_CLEAN +#define SSTATUS_XS_DIRTY MSTATUS_XS_DIRTY +#define SSTATUS_VS MSTATUS_VS +#define SSTATUS_VS_OFF MSTATUS_VS_OFF +#define SSTATUS_VS_INITIAL MSTATUS_VS_INITIAL +#define SSTATUS_VS_CLEAN MSTATUS_VS_CLEAN +#define SSTATUS_VS_DIRTY MSTATUS_VS_DIRTY +#define SSTATUS_SUM MSTATUS_SUM +#define SSTATUS_MXR MSTATUS_MXR +#define SSTATUS32_SD MSTATUS32_SD +#define SSTATUS64_UXL MSTATUS_UXL +#define SSTATUS64_SD MSTATUS64_SD + +#if __riscv_xlen == 64 +#define HSTATUS_VSXL _UL(0x300000000) +#define HSTATUS_VSXL_SHIFT 32 +#endif +#define HSTATUS_VTSR _UL(0x00400000) +#define HSTATUS_VTW _UL(0x00200000) +#define HSTATUS_VTVM _UL(0x00100000) +#define HSTATUS_VGEIN _UL(0x0003f000) +#define HSTATUS_VGEIN_SHIFT 12 +#define HSTATUS_HU _UL(0x00000200) +#define HSTATUS_SPVP _UL(0x00000100) +#define HSTATUS_SPV _UL(0x00000080) +#define HSTATUS_GVA _UL(0x00000040) +#define HSTATUS_VSBE _UL(0x00000020) + +#define IRQ_S_SOFT 1 +#define IRQ_VS_SOFT 2 +#define IRQ_M_SOFT 3 +#define IRQ_S_TIMER 5 +#define IRQ_VS_TIMER 6 +#define IRQ_M_TIMER 7 +#define IRQ_S_EXT 9 +#define IRQ_VS_EXT 10 +#define IRQ_M_EXT 11 +#define IRQ_S_GEXT 12 +#define IRQ_PMU_OVF 13 + +#define MIP_SSIP (_UL(1) << IRQ_S_SOFT) +#define MIP_VSSIP (_UL(1) << IRQ_VS_SOFT) +#define MIP_MSIP (_UL(1) << IRQ_M_SOFT) +#define MIP_STIP (_UL(1) << IRQ_S_TIMER) +#define MIP_VSTIP (_UL(1) << IRQ_VS_TIMER) +#define MIP_MTIP (_UL(1) << IRQ_M_TIMER) +#define MIP_SEIP (_UL(1) << IRQ_S_EXT) +#define MIP_VSEIP (_UL(1) << IRQ_VS_EXT) +#define MIP_MEIP (_UL(1) << IRQ_M_EXT) +#define MIP_SGEIP (_UL(1) << IRQ_S_GEXT) +#define MIP_LCOFIP (_UL(1) << IRQ_PMU_OVF) + +#define SIP_SSIP MIP_SSIP +#define SIP_STIP MIP_STIP + +#define PRV_U _UL(0) +#define PRV_S _UL(1) +#define PRV_M _UL(3) + +#define SATP32_MODE _UL(0x80000000) +#define SATP32_MODE_SHIFT 31 +#define SATP32_ASID _UL(0x7FC00000) +#define SATP32_ASID_SHIFT 22 +#define SATP32_PPN _UL(0x003FFFFF) +#define SATP64_MODE _ULL(0xF000000000000000) +#define SATP64_MODE_SHIFT 60 +#define SATP64_ASID _ULL(0x0FFFF00000000000) +#define SATP64_ASID_SHIFT 44 +#define SATP64_PPN _ULL(0x00000FFFFFFFFFFF) + +#define SATP_MODE_OFF _UL(0) +#define SATP_MODE_SV32 _UL(1) +#define SATP_MODE_SV39 _UL(8) +#define SATP_MODE_SV48 _UL(9) +#define SATP_MODE_SV57 _UL(10) +#define SATP_MODE_SV64 _UL(11) + +#define HGATP_MODE_OFF _UL(0) +#define HGATP_MODE_SV32X4 _UL(1) +#define HGATP_MODE_SV39X4 _UL(8) +#define HGATP_MODE_SV48X4 _UL(9) + +#define HGATP32_MODE_SHIFT 31 +#define HGATP32_VMID_SHIFT 22 +#define HGATP32_VMID_MASK _UL(0x1FC00000) +#define HGATP32_PPN _UL(0x003FFFFF) + +#define HGATP64_MODE_SHIFT 60 +#define HGATP64_VMID_SHIFT 44 +#define HGATP64_VMID_MASK _ULL(0x03FFF00000000000) +#define HGATP64_PPN _ULL(0x00000FFFFFFFFFFF) + +#define PMP_R _UL(0x01) +#define PMP_W _UL(0x02) +#define PMP_X _UL(0x04) +#define PMP_A _UL(0x18) +#define PMP_A_TOR _UL(0x08) +#define PMP_A_NA4 _UL(0x10) +#define PMP_A_NAPOT _UL(0x18) +#define PMP_L _UL(0x80) + +#define PMP_SHIFT 2 +#define PMP_COUNT 64 +#if __riscv_xlen == 64 +#define PMP_ADDR_MASK ((_ULL(0x1) << 54) - 1) +#else +#define PMP_ADDR_MASK _UL(0xFFFFFFFF) +#endif + +#if __riscv_xlen == 64 +#define MSTATUS_SD MSTATUS64_SD +#define SSTATUS_SD SSTATUS64_SD +#define SATP_MODE SATP64_MODE +#define SATP_MODE_SHIFT SATP64_MODE_SHIFT + +#define HGATP_PPN HGATP64_PPN +#define HGATP_VMID_SHIFT HGATP64_VMID_SHIFT +#define HGATP_VMID_MASK HGATP64_VMID_MASK +#define HGATP_MODE_SHIFT HGATP64_MODE_SHIFT +#else +#define MSTATUS_SD MSTATUS32_SD +#define SSTATUS_SD SSTATUS32_SD +#define SATP_MODE SATP32_MODE +#define SATP_MODE_SHIFT SATP32_MODE_SHIFT + +#define HGATP_PPN HGATP32_PPN +#define HGATP_VMID_SHIFT HGATP32_VMID_SHIFT +#define HGATP_VMID_MASK HGATP32_VMID_MASK +#define HGATP_MODE_SHIFT HGATP32_MODE_SHIFT +#endif + +#define TOPI_IID_SHIFT 16 +#define TOPI_IID_MASK 0xfff +#define TOPI_IPRIO_MASK 0xff + +#if __riscv_xlen == 64 +#define MHPMEVENT_OF (_UL(1) << 63) +#define MHPMEVENT_MINH (_UL(1) << 62) +#define MHPMEVENT_SINH (_UL(1) << 61) +#define MHPMEVENT_UINH (_UL(1) << 60) +#define MHPMEVENT_VSINH (_UL(1) << 59) +#define MHPMEVENT_VUINH (_UL(1) << 58) +#else +#define MHPMEVENTH_OF (_ULL(1) << 31) +#define MHPMEVENTH_MINH (_ULL(1) << 30) +#define MHPMEVENTH_SINH (_ULL(1) << 29) +#define MHPMEVENTH_UINH (_ULL(1) << 28) +#define MHPMEVENTH_VSINH (_ULL(1) << 27) +#define MHPMEVENTH_VUINH (_ULL(1) << 26) + +#define MHPMEVENT_OF (MHPMEVENTH_OF << 32) +#define MHPMEVENT_MINH (MHPMEVENTH_MINH << 32) +#define MHPMEVENT_SINH (MHPMEVENTH_SINH << 32) +#define MHPMEVENT_UINH (MHPMEVENTH_UINH << 32) +#define MHPMEVENT_VSINH (MHPMEVENTH_VSINH << 32) +#define MHPMEVENT_VUINH (MHPMEVENTH_VUINH << 32) + +#endif + +#define MHPMEVENT_SSCOF_MASK _ULL(0xFFFF000000000000) + +#if __riscv_xlen > 32 +#define ENVCFG_STCE (_ULL(1) << 63) +#define ENVCFG_PBMTE (_ULL(1) << 62) +#else +#define ENVCFGH_STCE (_UL(1) << 31) +#define ENVCFGH_PBMTE (_UL(1) << 30) +#endif +#define ENVCFG_CBZE (_UL(1) << 7) +#define ENVCFG_CBCFE (_UL(1) << 6) +#define ENVCFG_CBIE_SHIFT 4 +#define ENVCFG_CBIE (_UL(0x3) << ENVCFG_CBIE_SHIFT) +#define ENVCFG_CBIE_ILL _UL(0x0) +#define ENVCFG_CBIE_FLUSH _UL(0x1) +#define ENVCFG_CBIE_INV _UL(0x3) +#define ENVCFG_FIOM _UL(0x1) + +/* ===== User-level CSRs ===== */ + +/* User Trap Setup (N-extension) */ +#define CSR_USTATUS 0x000 +#define CSR_UIE 0x004 +#define CSR_UTVEC 0x005 + +/* User Trap Handling (N-extension) */ +#define CSR_USCRATCH 0x040 +#define CSR_UEPC 0x041 +#define CSR_UCAUSE 0x042 +#define CSR_UTVAL 0x043 +#define CSR_UIP 0x044 + +/* User Floating-point CSRs */ +#define CSR_FFLAGS 0x001 +#define CSR_FRM 0x002 +#define CSR_FCSR 0x003 + +/* User Counters/Timers */ +#define CSR_CYCLE 0xc00 +#define CSR_TIME 0xc01 +#define CSR_INSTRET 0xc02 +#define CSR_HPMCOUNTER3 0xc03 +#define CSR_HPMCOUNTER4 0xc04 +#define CSR_HPMCOUNTER5 0xc05 +#define CSR_HPMCOUNTER6 0xc06 +#define CSR_HPMCOUNTER7 0xc07 +#define CSR_HPMCOUNTER8 0xc08 +#define CSR_HPMCOUNTER9 0xc09 +#define CSR_HPMCOUNTER10 0xc0a +#define CSR_HPMCOUNTER11 0xc0b +#define CSR_HPMCOUNTER12 0xc0c +#define CSR_HPMCOUNTER13 0xc0d +#define CSR_HPMCOUNTER14 0xc0e +#define CSR_HPMCOUNTER15 0xc0f +#define CSR_HPMCOUNTER16 0xc10 +#define CSR_HPMCOUNTER17 0xc11 +#define CSR_HPMCOUNTER18 0xc12 +#define CSR_HPMCOUNTER19 0xc13 +#define CSR_HPMCOUNTER20 0xc14 +#define CSR_HPMCOUNTER21 0xc15 +#define CSR_HPMCOUNTER22 0xc16 +#define CSR_HPMCOUNTER23 0xc17 +#define CSR_HPMCOUNTER24 0xc18 +#define CSR_HPMCOUNTER25 0xc19 +#define CSR_HPMCOUNTER26 0xc1a +#define CSR_HPMCOUNTER27 0xc1b +#define CSR_HPMCOUNTER28 0xc1c +#define CSR_HPMCOUNTER29 0xc1d +#define CSR_HPMCOUNTER30 0xc1e +#define CSR_HPMCOUNTER31 0xc1f +#define CSR_CYCLEH 0xc80 +#define CSR_TIMEH 0xc81 +#define CSR_INSTRETH 0xc82 +#define CSR_HPMCOUNTER3H 0xc83 +#define CSR_HPMCOUNTER4H 0xc84 +#define CSR_HPMCOUNTER5H 0xc85 +#define CSR_HPMCOUNTER6H 0xc86 +#define CSR_HPMCOUNTER7H 0xc87 +#define CSR_HPMCOUNTER8H 0xc88 +#define CSR_HPMCOUNTER9H 0xc89 +#define CSR_HPMCOUNTER10H 0xc8a +#define CSR_HPMCOUNTER11H 0xc8b +#define CSR_HPMCOUNTER12H 0xc8c +#define CSR_HPMCOUNTER13H 0xc8d +#define CSR_HPMCOUNTER14H 0xc8e +#define CSR_HPMCOUNTER15H 0xc8f +#define CSR_HPMCOUNTER16H 0xc90 +#define CSR_HPMCOUNTER17H 0xc91 +#define CSR_HPMCOUNTER18H 0xc92 +#define CSR_HPMCOUNTER19H 0xc93 +#define CSR_HPMCOUNTER20H 0xc94 +#define CSR_HPMCOUNTER21H 0xc95 +#define CSR_HPMCOUNTER22H 0xc96 +#define CSR_HPMCOUNTER23H 0xc97 +#define CSR_HPMCOUNTER24H 0xc98 +#define CSR_HPMCOUNTER25H 0xc99 +#define CSR_HPMCOUNTER26H 0xc9a +#define CSR_HPMCOUNTER27H 0xc9b +#define CSR_HPMCOUNTER28H 0xc9c +#define CSR_HPMCOUNTER29H 0xc9d +#define CSR_HPMCOUNTER30H 0xc9e +#define CSR_HPMCOUNTER31H 0xc9f + +/* ===== Supervisor-level CSRs ===== */ + +/* Supervisor Trap Setup */ +#define CSR_SSTATUS 0x100 +#define CSR_SEDELEG 0x102 +#define CSR_SIDELEG 0x103 +#define CSR_SIE 0x104 +#define CSR_STVEC 0x105 +#define CSR_SCOUNTEREN 0x106 + +/* Supervisor Configuration */ +#define CSR_SENVCFG 0x10a + +/* Supervisor Trap Handling */ +#define CSR_SSCRATCH 0x140 +#define CSR_SEPC 0x141 +#define CSR_SCAUSE 0x142 +#define CSR_STVAL 0x143 +#define CSR_SIP 0x144 + +/* Supervisor Protection and Translation */ +#define CSR_SATP 0x180 + +/* Supervisor-Level Window to Indirectly Accessed Registers (AIA) */ +#define CSR_SISELECT 0x150 +#define CSR_SIREG 0x151 + +/* Supervisor-Level Interrupts (AIA) */ +#define CSR_STOPI 0xdb0 + +/* Supervisor-Level IMSIC Interface (AIA) */ +#define CSR_SSETEIPNUM 0x158 +#define CSR_SCLREIPNUM 0x159 +#define CSR_SSETEIENUM 0x15a +#define CSR_SCLREIENUM 0x15b +#define CSR_STOPEI 0x15c + +/* Supervisor-Level High-Half CSRs (AIA) */ +#define CSR_SIEH 0x114 +#define CSR_SIPH 0x154 + +/* Supervisor stateen CSRs */ +#define CSR_SSTATEEN0 0x10C +#define CSR_SSTATEEN1 0x10D +#define CSR_SSTATEEN2 0x10E +#define CSR_SSTATEEN3 0x10F + +/* ===== Hypervisor-level CSRs ===== */ + +/* Hypervisor Trap Setup (H-extension) */ +#define CSR_HSTATUS 0x600 +#define CSR_HEDELEG 0x602 +#define CSR_HIDELEG 0x603 +#define CSR_HIE 0x604 +#define CSR_HCOUNTEREN 0x606 +#define CSR_HGEIE 0x607 + +/* Hypervisor Configuration */ +#define CSR_HENVCFG 0x60a +#define CSR_HENVCFGH 0x61a + +/* Hypervisor Trap Handling (H-extension) */ +#define CSR_HTVAL 0x643 +#define CSR_HIP 0x644 +#define CSR_HVIP 0x645 +#define CSR_HTINST 0x64a +#define CSR_HGEIP 0xe12 + +/* Hypervisor Protection and Translation (H-extension) */ +#define CSR_HGATP 0x680 + +/* Hypervisor Counter/Timer Virtualization Registers (H-extension) */ +#define CSR_HTIMEDELTA 0x605 +#define CSR_HTIMEDELTAH 0x615 + +/* Virtual Supervisor Registers (H-extension) */ +#define CSR_VSSTATUS 0x200 +#define CSR_VSIE 0x204 +#define CSR_VSTVEC 0x205 +#define CSR_VSSCRATCH 0x240 +#define CSR_VSEPC 0x241 +#define CSR_VSCAUSE 0x242 +#define CSR_VSTVAL 0x243 +#define CSR_VSIP 0x244 +#define CSR_VSATP 0x280 + +/* Virtual Interrupts and Interrupt Priorities (H-extension with AIA) */ +#define CSR_HVIEN 0x608 +#define CSR_HVICTL 0x609 +#define CSR_HVIPRIO1 0x646 +#define CSR_HVIPRIO2 0x647 + +/* VS-Level Window to Indirectly Accessed Registers (H-extension with AIA) */ +#define CSR_VSISELECT 0x250 +#define CSR_VSIREG 0x251 + +/* VS-Level Interrupts (H-extension with AIA) */ +#define CSR_VSTOPI 0xeb0 + +/* VS-Level IMSIC Interface (H-extension with AIA) */ +#define CSR_VSSETEIPNUM 0x258 +#define CSR_VSCLREIPNUM 0x259 +#define CSR_VSSETEIENUM 0x25a +#define CSR_VSCLREIENUM 0x25b +#define CSR_VSTOPEI 0x25c + +/* Hypervisor and VS-Level High-Half CSRs (H-extension with AIA) */ +#define CSR_HIDELEGH 0x613 +#define CSR_HVIENH 0x618 +#define CSR_HVIPH 0x655 +#define CSR_HVIPRIO1H 0x656 +#define CSR_HVIPRIO2H 0x657 +#define CSR_VSIEH 0x214 +#define CSR_VSIPH 0x254 + +/* Hypervisor stateen CSRs */ +#define CSR_HSTATEEN0 0x60C +#define CSR_HSTATEEN0H 0x61C +#define CSR_HSTATEEN1 0x60D +#define CSR_HSTATEEN1H 0x61D +#define CSR_HSTATEEN2 0x60E +#define CSR_HSTATEEN2H 0x61E +#define CSR_HSTATEEN3 0x60F +#define CSR_HSTATEEN3H 0x61F + +/* ===== Machine-level CSRs ===== */ + +/* Machine Information Registers */ +#define CSR_MVENDORID 0xf11 +#define CSR_MARCHID 0xf12 +#define CSR_MIMPID 0xf13 +#define CSR_MHARTID 0xf14 + +/* Machine Trap Setup */ +#define CSR_MSTATUS 0x300 +#define CSR_MISA 0x301 +#define CSR_MEDELEG 0x302 +#define CSR_MIDELEG 0x303 +#define CSR_MIE 0x304 +#define CSR_MTVEC 0x305 +#define CSR_MCOUNTEREN 0x306 +#define CSR_MSTATUSH 0x310 + +/* Machine Configuration */ +#define CSR_MENVCFG 0x30a +#define CSR_MENVCFGH 0x31a + +/* Machine Trap Handling */ +#define CSR_MSCRATCH 0x340 +#define CSR_MEPC 0x341 +#define CSR_MCAUSE 0x342 +#define CSR_MTVAL 0x343 +#define CSR_MIP 0x344 +#define CSR_MTINST 0x34a +#define CSR_MTVAL2 0x34b + +/* Machine Memory Protection */ +#define CSR_PMPCFG0 0x3a0 +#define CSR_PMPCFG1 0x3a1 +#define CSR_PMPCFG2 0x3a2 +#define CSR_PMPCFG3 0x3a3 +#define CSR_PMPCFG4 0x3a4 +#define CSR_PMPCFG5 0x3a5 +#define CSR_PMPCFG6 0x3a6 +#define CSR_PMPCFG7 0x3a7 +#define CSR_PMPCFG8 0x3a8 +#define CSR_PMPCFG9 0x3a9 +#define CSR_PMPCFG10 0x3aa +#define CSR_PMPCFG11 0x3ab +#define CSR_PMPCFG12 0x3ac +#define CSR_PMPCFG13 0x3ad +#define CSR_PMPCFG14 0x3ae +#define CSR_PMPCFG15 0x3af +#define CSR_PMPADDR0 0x3b0 +#define CSR_PMPADDR1 0x3b1 +#define CSR_PMPADDR2 0x3b2 +#define CSR_PMPADDR3 0x3b3 +#define CSR_PMPADDR4 0x3b4 +#define CSR_PMPADDR5 0x3b5 +#define CSR_PMPADDR6 0x3b6 +#define CSR_PMPADDR7 0x3b7 +#define CSR_PMPADDR8 0x3b8 +#define CSR_PMPADDR9 0x3b9 +#define CSR_PMPADDR10 0x3ba +#define CSR_PMPADDR11 0x3bb +#define CSR_PMPADDR12 0x3bc +#define CSR_PMPADDR13 0x3bd +#define CSR_PMPADDR14 0x3be +#define CSR_PMPADDR15 0x3bf +#define CSR_PMPADDR16 0x3c0 +#define CSR_PMPADDR17 0x3c1 +#define CSR_PMPADDR18 0x3c2 +#define CSR_PMPADDR19 0x3c3 +#define CSR_PMPADDR20 0x3c4 +#define CSR_PMPADDR21 0x3c5 +#define CSR_PMPADDR22 0x3c6 +#define CSR_PMPADDR23 0x3c7 +#define CSR_PMPADDR24 0x3c8 +#define CSR_PMPADDR25 0x3c9 +#define CSR_PMPADDR26 0x3ca +#define CSR_PMPADDR27 0x3cb +#define CSR_PMPADDR28 0x3cc +#define CSR_PMPADDR29 0x3cd +#define CSR_PMPADDR30 0x3ce +#define CSR_PMPADDR31 0x3cf +#define CSR_PMPADDR32 0x3d0 +#define CSR_PMPADDR33 0x3d1 +#define CSR_PMPADDR34 0x3d2 +#define CSR_PMPADDR35 0x3d3 +#define CSR_PMPADDR36 0x3d4 +#define CSR_PMPADDR37 0x3d5 +#define CSR_PMPADDR38 0x3d6 +#define CSR_PMPADDR39 0x3d7 +#define CSR_PMPADDR40 0x3d8 +#define CSR_PMPADDR41 0x3d9 +#define CSR_PMPADDR42 0x3da +#define CSR_PMPADDR43 0x3db +#define CSR_PMPADDR44 0x3dc +#define CSR_PMPADDR45 0x3dd +#define CSR_PMPADDR46 0x3de +#define CSR_PMPADDR47 0x3df +#define CSR_PMPADDR48 0x3e0 +#define CSR_PMPADDR49 0x3e1 +#define CSR_PMPADDR50 0x3e2 +#define CSR_PMPADDR51 0x3e3 +#define CSR_PMPADDR52 0x3e4 +#define CSR_PMPADDR53 0x3e5 +#define CSR_PMPADDR54 0x3e6 +#define CSR_PMPADDR55 0x3e7 +#define CSR_PMPADDR56 0x3e8 +#define CSR_PMPADDR57 0x3e9 +#define CSR_PMPADDR58 0x3ea +#define CSR_PMPADDR59 0x3eb +#define CSR_PMPADDR60 0x3ec +#define CSR_PMPADDR61 0x3ed +#define CSR_PMPADDR62 0x3ee +#define CSR_PMPADDR63 0x3ef + +/* Machine Counters/Timers */ +#define CSR_MCYCLE 0xb00 +#define CSR_MINSTRET 0xb02 +#define CSR_MHPMCOUNTER3 0xb03 +#define CSR_MHPMCOUNTER4 0xb04 +#define CSR_MHPMCOUNTER5 0xb05 +#define CSR_MHPMCOUNTER6 0xb06 +#define CSR_MHPMCOUNTER7 0xb07 +#define CSR_MHPMCOUNTER8 0xb08 +#define CSR_MHPMCOUNTER9 0xb09 +#define CSR_MHPMCOUNTER10 0xb0a +#define CSR_MHPMCOUNTER11 0xb0b +#define CSR_MHPMCOUNTER12 0xb0c +#define CSR_MHPMCOUNTER13 0xb0d +#define CSR_MHPMCOUNTER14 0xb0e +#define CSR_MHPMCOUNTER15 0xb0f +#define CSR_MHPMCOUNTER16 0xb10 +#define CSR_MHPMCOUNTER17 0xb11 +#define CSR_MHPMCOUNTER18 0xb12 +#define CSR_MHPMCOUNTER19 0xb13 +#define CSR_MHPMCOUNTER20 0xb14 +#define CSR_MHPMCOUNTER21 0xb15 +#define CSR_MHPMCOUNTER22 0xb16 +#define CSR_MHPMCOUNTER23 0xb17 +#define CSR_MHPMCOUNTER24 0xb18 +#define CSR_MHPMCOUNTER25 0xb19 +#define CSR_MHPMCOUNTER26 0xb1a +#define CSR_MHPMCOUNTER27 0xb1b +#define CSR_MHPMCOUNTER28 0xb1c +#define CSR_MHPMCOUNTER29 0xb1d +#define CSR_MHPMCOUNTER30 0xb1e +#define CSR_MHPMCOUNTER31 0xb1f +#define CSR_MCYCLEH 0xb80 +#define CSR_MINSTRETH 0xb82 +#define CSR_MHPMCOUNTER3H 0xb83 +#define CSR_MHPMCOUNTER4H 0xb84 +#define CSR_MHPMCOUNTER5H 0xb85 +#define CSR_MHPMCOUNTER6H 0xb86 +#define CSR_MHPMCOUNTER7H 0xb87 +#define CSR_MHPMCOUNTER8H 0xb88 +#define CSR_MHPMCOUNTER9H 0xb89 +#define CSR_MHPMCOUNTER10H 0xb8a +#define CSR_MHPMCOUNTER11H 0xb8b +#define CSR_MHPMCOUNTER12H 0xb8c +#define CSR_MHPMCOUNTER13H 0xb8d +#define CSR_MHPMCOUNTER14H 0xb8e +#define CSR_MHPMCOUNTER15H 0xb8f +#define CSR_MHPMCOUNTER16H 0xb90 +#define CSR_MHPMCOUNTER17H 0xb91 +#define CSR_MHPMCOUNTER18H 0xb92 +#define CSR_MHPMCOUNTER19H 0xb93 +#define CSR_MHPMCOUNTER20H 0xb94 +#define CSR_MHPMCOUNTER21H 0xb95 +#define CSR_MHPMCOUNTER22H 0xb96 +#define CSR_MHPMCOUNTER23H 0xb97 +#define CSR_MHPMCOUNTER24H 0xb98 +#define CSR_MHPMCOUNTER25H 0xb99 +#define CSR_MHPMCOUNTER26H 0xb9a +#define CSR_MHPMCOUNTER27H 0xb9b +#define CSR_MHPMCOUNTER28H 0xb9c +#define CSR_MHPMCOUNTER29H 0xb9d +#define CSR_MHPMCOUNTER30H 0xb9e +#define CSR_MHPMCOUNTER31H 0xb9f + +/* Machine Counter Setup */ +#define CSR_MCOUNTINHIBIT 0x320 +#define CSR_MHPMEVENT3 0x323 +#define CSR_MHPMEVENT4 0x324 +#define CSR_MHPMEVENT5 0x325 +#define CSR_MHPMEVENT6 0x326 +#define CSR_MHPMEVENT7 0x327 +#define CSR_MHPMEVENT8 0x328 +#define CSR_MHPMEVENT9 0x329 +#define CSR_MHPMEVENT10 0x32a +#define CSR_MHPMEVENT11 0x32b +#define CSR_MHPMEVENT12 0x32c +#define CSR_MHPMEVENT13 0x32d +#define CSR_MHPMEVENT14 0x32e +#define CSR_MHPMEVENT15 0x32f +#define CSR_MHPMEVENT16 0x330 +#define CSR_MHPMEVENT17 0x331 +#define CSR_MHPMEVENT18 0x332 +#define CSR_MHPMEVENT19 0x333 +#define CSR_MHPMEVENT20 0x334 +#define CSR_MHPMEVENT21 0x335 +#define CSR_MHPMEVENT22 0x336 +#define CSR_MHPMEVENT23 0x337 +#define CSR_MHPMEVENT24 0x338 +#define CSR_MHPMEVENT25 0x339 +#define CSR_MHPMEVENT26 0x33a +#define CSR_MHPMEVENT27 0x33b +#define CSR_MHPMEVENT28 0x33c +#define CSR_MHPMEVENT29 0x33d +#define CSR_MHPMEVENT30 0x33e +#define CSR_MHPMEVENT31 0x33f + +/* For RV32 */ +#define CSR_MHPMEVENT3H 0x723 +#define CSR_MHPMEVENT4H 0x724 +#define CSR_MHPMEVENT5H 0x725 +#define CSR_MHPMEVENT6H 0x726 +#define CSR_MHPMEVENT7H 0x727 +#define CSR_MHPMEVENT8H 0x728 +#define CSR_MHPMEVENT9H 0x729 +#define CSR_MHPMEVENT10H 0x72a +#define CSR_MHPMEVENT11H 0x72b +#define CSR_MHPMEVENT12H 0x72c +#define CSR_MHPMEVENT13H 0x72d +#define CSR_MHPMEVENT14H 0x72e +#define CSR_MHPMEVENT15H 0x72f +#define CSR_MHPMEVENT16H 0x730 +#define CSR_MHPMEVENT17H 0x731 +#define CSR_MHPMEVENT18H 0x732 +#define CSR_MHPMEVENT19H 0x733 +#define CSR_MHPMEVENT20H 0x734 +#define CSR_MHPMEVENT21H 0x735 +#define CSR_MHPMEVENT22H 0x736 +#define CSR_MHPMEVENT23H 0x737 +#define CSR_MHPMEVENT24H 0x738 +#define CSR_MHPMEVENT25H 0x739 +#define CSR_MHPMEVENT26H 0x73a +#define CSR_MHPMEVENT27H 0x73b +#define CSR_MHPMEVENT28H 0x73c +#define CSR_MHPMEVENT29H 0x73d +#define CSR_MHPMEVENT30H 0x73e +#define CSR_MHPMEVENT31H 0x73f + +/* Counter Overflow CSR */ +#define CSR_SCOUNTOVF 0xda0 + +/* Debug/Trace Registers */ +#define CSR_TSELECT 0x7a0 +#define CSR_TDATA1 0x7a1 +#define CSR_TDATA2 0x7a2 +#define CSR_TDATA3 0x7a3 + +/* Debug Mode Registers */ +#define CSR_DCSR 0x7b0 +#define CSR_DPC 0x7b1 +#define CSR_DSCRATCH0 0x7b2 +#define CSR_DSCRATCH1 0x7b3 + +/* Machine-Level Window to Indirectly Accessed Registers (AIA) */ +#define CSR_MISELECT 0x350 +#define CSR_MIREG 0x351 + +/* Machine-Level Interrupts (AIA) */ +#define CSR_MTOPI 0xfb0 + +/* Machine-Level IMSIC Interface (AIA) */ +#define CSR_MSETEIPNUM 0x358 +#define CSR_MCLREIPNUM 0x359 +#define CSR_MSETEIENUM 0x35a +#define CSR_MCLREIENUM 0x35b +#define CSR_MTOPEI 0x35c + +/* Virtual Interrupts for Supervisor Level (AIA) */ +#define CSR_MVIEN 0x308 +#define CSR_MVIP 0x309 + +/* Smstateen extension registers */ +/* Machine stateen CSRs */ +#define CSR_MSTATEEN0 0x30C +#define CSR_MSTATEEN0H 0x31C +#define CSR_MSTATEEN1 0x30D +#define CSR_MSTATEEN1H 0x31D +#define CSR_MSTATEEN2 0x30E +#define CSR_MSTATEEN2H 0x31E +#define CSR_MSTATEEN3 0x30F +#define CSR_MSTATEEN3H 0x31F + +/* Machine-Level High-Half CSRs (AIA) */ +#define CSR_MIDELEGH 0x313 +#define CSR_MIEH 0x314 +#define CSR_MVIENH 0x318 +#define CSR_MVIPH 0x319 +#define CSR_MIPH 0x354 + +/* ===== Trap/Exception Causes ===== */ + +/* Exception cause high bit - is an interrupt if set */ +#define CAUSE_IRQ_FLAG (_UL(1) << (__riscv_xlen - 1)) + +#define CAUSE_MISALIGNED_FETCH 0x0 +#define CAUSE_FETCH_ACCESS 0x1 +#define CAUSE_ILLEGAL_INSTRUCTION 0x2 +#define CAUSE_BREAKPOINT 0x3 +#define CAUSE_MISALIGNED_LOAD 0x4 +#define CAUSE_LOAD_ACCESS 0x5 +#define CAUSE_MISALIGNED_STORE 0x6 +#define CAUSE_STORE_ACCESS 0x7 +#define CAUSE_USER_ECALL 0x8 +#define CAUSE_SUPERVISOR_ECALL 0x9 +#define CAUSE_VIRTUAL_SUPERVISOR_ECALL 0xa +#define CAUSE_MACHINE_ECALL 0xb +#define CAUSE_FETCH_PAGE_FAULT 0xc +#define CAUSE_LOAD_PAGE_FAULT 0xd +#define CAUSE_STORE_PAGE_FAULT 0xf +#define CAUSE_FETCH_GUEST_PAGE_FAULT 0x14 +#define CAUSE_LOAD_GUEST_PAGE_FAULT 0x15 +#define CAUSE_VIRTUAL_INST_FAULT 0x16 +#define CAUSE_STORE_GUEST_PAGE_FAULT 0x17 + +/* Common defines for all smstateen */ +#define SMSTATEEN_MAX_COUNT 4 +#define SMSTATEEN0_CS_SHIFT 0 +#define SMSTATEEN0_CS (_ULL(1) << SMSTATEEN0_CS_SHIFT) +#define SMSTATEEN0_FCSR_SHIFT 1 +#define SMSTATEEN0_FCSR (_ULL(1) << SMSTATEEN0_FCSR_SHIFT) +#define SMSTATEEN0_IMSIC_SHIFT 58 +#define SMSTATEEN0_IMSIC (_ULL(1) << SMSTATEEN0_IMSIC_SHIFT) +#define SMSTATEEN0_AIA_SHIFT 59 +#define SMSTATEEN0_AIA (_ULL(1) << SMSTATEEN0_AIA_SHIFT) +#define SMSTATEEN0_SVSLCT_SHIFT 60 +#define SMSTATEEN0_SVSLCT (_ULL(1) << SMSTATEEN0_SVSLCT_SHIFT) +#define SMSTATEEN0_HSENVCFG_SHIFT 62 +#define SMSTATEEN0_HSENVCFG (_ULL(1) << SMSTATEEN0_HSENVCFG_SHIFT) +#define SMSTATEEN_STATEN_SHIFT 63 +#define SMSTATEEN_STATEN (_ULL(1) << SMSTATEEN_STATEN_SHIFT) + +/* ===== Instruction Encodings ===== */ + +#define INSN_MATCH_LB 0x3 +#define INSN_MASK_LB 0x707f +#define INSN_MATCH_LH 0x1003 +#define INSN_MASK_LH 0x707f +#define INSN_MATCH_LW 0x2003 +#define INSN_MASK_LW 0x707f +#define INSN_MATCH_LD 0x3003 +#define INSN_MASK_LD 0x707f +#define INSN_MATCH_LBU 0x4003 +#define INSN_MASK_LBU 0x707f +#define INSN_MATCH_LHU 0x5003 +#define INSN_MASK_LHU 0x707f +#define INSN_MATCH_LWU 0x6003 +#define INSN_MASK_LWU 0x707f +#define INSN_MATCH_SB 0x23 +#define INSN_MASK_SB 0x707f +#define INSN_MATCH_SH 0x1023 +#define INSN_MASK_SH 0x707f +#define INSN_MATCH_SW 0x2023 +#define INSN_MASK_SW 0x707f +#define INSN_MATCH_SD 0x3023 +#define INSN_MASK_SD 0x707f + +#define INSN_MATCH_FLW 0x2007 +#define INSN_MASK_FLW 0x707f +#define INSN_MATCH_FLD 0x3007 +#define INSN_MASK_FLD 0x707f +#define INSN_MATCH_FLQ 0x4007 +#define INSN_MASK_FLQ 0x707f +#define INSN_MATCH_FSW 0x2027 +#define INSN_MASK_FSW 0x707f +#define INSN_MATCH_FSD 0x3027 +#define INSN_MASK_FSD 0x707f +#define INSN_MATCH_FSQ 0x4027 +#define INSN_MASK_FSQ 0x707f + +#define INSN_MATCH_C_LD 0x6000 +#define INSN_MASK_C_LD 0xe003 +#define INSN_MATCH_C_SD 0xe000 +#define INSN_MASK_C_SD 0xe003 +#define INSN_MATCH_C_LW 0x4000 +#define INSN_MASK_C_LW 0xe003 +#define INSN_MATCH_C_SW 0xc000 +#define INSN_MASK_C_SW 0xe003 +#define INSN_MATCH_C_LDSP 0x6002 +#define INSN_MASK_C_LDSP 0xe003 +#define INSN_MATCH_C_SDSP 0xe002 +#define INSN_MASK_C_SDSP 0xe003 +#define INSN_MATCH_C_LWSP 0x4002 +#define INSN_MASK_C_LWSP 0xe003 +#define INSN_MATCH_C_SWSP 0xc002 +#define INSN_MASK_C_SWSP 0xe003 + +#define INSN_MATCH_C_FLD 0x2000 +#define INSN_MASK_C_FLD 0xe003 +#define INSN_MATCH_C_FLW 0x6000 +#define INSN_MASK_C_FLW 0xe003 +#define INSN_MATCH_C_FSD 0xa000 +#define INSN_MASK_C_FSD 0xe003 +#define INSN_MATCH_C_FSW 0xe000 +#define INSN_MASK_C_FSW 0xe003 +#define INSN_MATCH_C_FLDSP 0x2002 +#define INSN_MASK_C_FLDSP 0xe003 +#define INSN_MATCH_C_FSDSP 0xa002 +#define INSN_MASK_C_FSDSP 0xe003 +#define INSN_MATCH_C_FLWSP 0x6002 +#define INSN_MASK_C_FLWSP 0xe003 +#define INSN_MATCH_C_FSWSP 0xe002 +#define INSN_MASK_C_FSWSP 0xe003 + +#define INSN_MASK_WFI 0xffffff00 +#define INSN_MATCH_WFI 0x10500000 + +#define INSN_16BIT_MASK 0x3 +#define INSN_32BIT_MASK 0x1c + +#define INSN_IS_16BIT(insn) \ + (((insn) & INSN_16BIT_MASK) != INSN_16BIT_MASK) +#define INSN_IS_32BIT(insn) \ + (((insn) & INSN_16BIT_MASK) == INSN_16BIT_MASK && \ + ((insn) & INSN_32BIT_MASK) != INSN_32BIT_MASK) + +#define INSN_LEN(insn) (INSN_IS_16BIT(insn) ? 2 : 4) + +#if __riscv_xlen == 64 +#define LOG_REGBYTES 3 +#else +#define LOG_REGBYTES 2 +#endif +#define REGBYTES (1 << LOG_REGBYTES) + +#define SH_RD 7 +#define SH_RS1 15 +#define SH_RS2 20 +#define SH_RS2C 2 + +#define RV_X(x, s, n) (((x) >> (s)) & ((1 << (n)) - 1)) +#define RVC_LW_IMM(x) ((RV_X(x, 6, 1) << 2) | \ + (RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 5, 1) << 6)) +#define RVC_LD_IMM(x) ((RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 5, 2) << 6)) +#define RVC_LWSP_IMM(x) ((RV_X(x, 4, 3) << 2) | \ + (RV_X(x, 12, 1) << 5) | \ + (RV_X(x, 2, 2) << 6)) +#define RVC_LDSP_IMM(x) ((RV_X(x, 5, 2) << 3) | \ + (RV_X(x, 12, 1) << 5) | \ + (RV_X(x, 2, 3) << 6)) +#define RVC_SWSP_IMM(x) ((RV_X(x, 9, 4) << 2) | \ + (RV_X(x, 7, 2) << 6)) +#define RVC_SDSP_IMM(x) ((RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 7, 3) << 6)) +#define RVC_RS1S(insn) (8 + RV_X(insn, SH_RD, 3)) +#define RVC_RS2S(insn) (8 + RV_X(insn, SH_RS2C, 3)) +#define RVC_RS2(insn) RV_X(insn, SH_RS2C, 5) + +#define SHIFT_RIGHT(x, y) \ + ((y) < 0 ? ((x) << -(y)) : ((x) >> (y))) + +#define REG_MASK \ + ((1 << (5 + LOG_REGBYTES)) - (1 << LOG_REGBYTES)) + +#define REG_OFFSET(insn, pos) \ + (SHIFT_RIGHT((insn), (pos) - LOG_REGBYTES) & REG_MASK) + +#define REG_PTR(insn, pos, regs) \ + (unsigned long *)((unsigned long)(regs) + REG_OFFSET(insn, pos)) + +#define GET_RM(insn) (((insn) >> 12) & 7) + +#define GET_RS1(insn, regs) (*REG_PTR(insn, SH_RS1, regs)) +#define GET_RS2(insn, regs) (*REG_PTR(insn, SH_RS2, regs)) +#define GET_RS1S(insn, regs) (*REG_PTR(RVC_RS1S(insn), 0, regs)) +#define GET_RS2S(insn, regs) (*REG_PTR(RVC_RS2S(insn), 0, regs)) +#define GET_RS2C(insn, regs) (*REG_PTR(insn, SH_RS2C, regs)) +#define GET_SP(regs) (*REG_PTR(2, 0, regs)) +#define SET_RD(insn, regs, val) (*REG_PTR(insn, SH_RD, regs) = (val)) +#define IMM_I(insn) ((s32)(insn) >> 20) +#define IMM_S(insn) (((s32)(insn) >> 25 << 5) | \ + (s32)(((insn) >> 7) & 0x1f)) +#define MASK_FUNCT3 0x7000 + +/* clang-format on */ + +#endif diff --git a/xen/arch/riscv/include/asm/setup.h b/xen/arch/riscv/include/asm/setup.h new file mode 100644 index 0000000000..682ed84aad --- /dev/null +++ b/xen/arch/riscv/include/asm/setup.h @@ -0,0 +1,23 @@ +#ifndef __RISCV_SETUP_H_ +#define __RISCV_SETUP_H_ + +#include + +extern domid_t max_init_domid; + +#define NR_VCPUS 2 + +/* Devices */ +#define PLIC_BASE 0xc000000 +#define PLIC_SIZE 0x0210000 +#define PLIC_END (PLIC_BASE + PLIC_SIZE) + +#endif /* __RISCV_SETUP_H_ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/smp.h b/xen/arch/riscv/include/asm/smp.h new file mode 100644 index 0000000000..dc6feda76d --- /dev/null +++ b/xen/arch/riscv/include/asm/smp.h @@ -0,0 +1,69 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef _ASM_RISCV_SMP_H +#define _ASM_RISCV_SMP_H + +#ifndef __ASSEMBLY__ +#include +#include +#endif + +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); + +#define HARTID_INVALID -1 + +/* + * Do we, for platform reasons, need to actually keep CPUs online when we + * would otherwise prefer them to be off? + */ +#define park_offline_cpus true + +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) + +static inline unsigned int __raw_smp_processor_id(void) +{ + unsigned long id; + + id = get_processor_id(); + + /* + * Technically the hartid can be greater than what a uint can hold. + * If such a system were to exist, we will need to change + * the raw_smp_processor_id() API to be unsigned long instead of + * unsigned int. + */ + BUG_ON(id > UINT_MAX); + + return (unsigned int)id; +} + +#define raw_smp_processor_id() (__raw_smp_processor_id()) +#define smp_processor_id() (__raw_smp_processor_id()) + +void smp_clear_cpu_maps (void); +int smp_get_max_cpus(void); + +#endif /* _ASM_RISCV_SMP_H */ diff --git a/xen/arch/riscv/include/asm/softirq.h b/xen/arch/riscv/include/asm/softirq.h new file mode 100644 index 0000000000..976e0ebd70 --- /dev/null +++ b/xen/arch/riscv/include/asm/softirq.h @@ -0,0 +1,16 @@ +#ifndef __ASM_SOFTIRQ_H__ +#define __ASM_SOFTIRQ_H__ + +#define NR_ARCH_SOFTIRQS 0 + +#define arch_skip_send_event_check(cpu) 0 + +#endif /* __ASM_SOFTIRQ_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/spinlock.h b/xen/arch/riscv/include/asm/spinlock.h new file mode 100644 index 0000000000..2f47b4d9ad --- /dev/null +++ b/xen/arch/riscv/include/asm/spinlock.h @@ -0,0 +1,13 @@ +#ifndef __ASM_SPINLOCK_H +#define __ASM_SPINLOCK_H + +#define arch_lock_acquire_barrier() smp_mb() +#define arch_lock_release_barrier() smp_mb() + +#define arch_lock_relax() cpu_relax() +#define arch_lock_signal() do { \ +} while(0) + +#define arch_lock_signal_wmb() arch_lock_signal() + +#endif /* __ASM_SPINLOCK_H */ diff --git a/xen/arch/riscv/include/asm/string.h b/xen/arch/riscv/include/asm/string.h new file mode 100644 index 0000000000..733e9e00d3 --- /dev/null +++ b/xen/arch/riscv/include/asm/string.h @@ -0,0 +1,28 @@ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + */ + +#ifndef _ASM_RISCV_STRING_H +#define _ASM_RISCV_STRING_H + +#endif /* _ASM_RISCV_STRING_H */ diff --git a/xen/arch/riscv/include/asm/system.h b/xen/arch/riscv/include/asm/system.h new file mode 100644 index 0000000000..434de6d512 --- /dev/null +++ b/xen/arch/riscv/include/asm/system.h @@ -0,0 +1,98 @@ +/* + * Based on arch/arm/include/asm/system.h + * + * Copyright (C) 2012 ARM Ltd. + * Copyright (C) 2013 Regents of the University of California + * Copyright (C) 2017 SiFive + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#ifndef _ASM_RISCV_BARRIER_H +#define _ASM_RISCV_BARRIER_H + +#include +#include + +#ifndef __ASSEMBLY__ + +#define nop() __asm__ __volatile__ ("nop") + +#define RISCV_FENCE(p, s) \ + __asm__ __volatile__ ("fence " #p "," #s : : : "memory") + +/* These barriers need to enforce ordering on both devices or memory. */ +#define mb() RISCV_FENCE(iorw,iorw) +#define rmb() RISCV_FENCE(ir,ir) +#define wmb() RISCV_FENCE(ow,ow) + +/* These barriers do not need to enforce ordering on devices, just memory. */ +#define smp_mb() RISCV_FENCE(rw,rw) +#define smp_rmb() RISCV_FENCE(r,r) +#define smp_wmb() RISCV_FENCE(w,w) +#define smp_mb__before_atomic() smp_mb() +#define smp_mb__after_atomic() smp_mb() + +#define __smp_store_release(p, v) \ +do { \ + compiletime_assert_atomic_type(*p); \ + RISCV_FENCE(rw,w); \ + WRITE_ONCE(*p, v); \ +} while (0) + +#define __smp_load_acquire(p) \ +({ \ + typeof(*p) ___p1 = READ_ONCE(*p); \ + compiletime_assert_atomic_type(*p); \ + RISCV_FENCE(r,rw); \ + ___p1; \ +}) + +static inline unsigned long local_save_flags(void) +{ + return csr_read(sstatus); +} + +static inline void local_irq_enable(void) +{ + csr_set(sstatus, SSTATUS_SIE); +} + +static inline void local_irq_disable(void) +{ + csr_clear(sstatus, SSTATUS_SIE); +} + +#define local_irq_save(x) \ +({ \ + x = csr_read_clear(CSR_SSTATUS, SSTATUS_SIE); \ + local_irq_disable(); \ +}) + +static inline void local_irq_restore(unsigned long flags) +{ + csr_set(CSR_SSTATUS, flags & SSTATUS_SIE); +} + +static inline int local_irq_is_enabled(void) +{ + unsigned long flags = local_save_flags(); + + return flags & SSTATUS_SIE; +} + +#define arch_fetch_and_add(x, v) __sync_fetch_and_add(x, v) + +#endif /* __ASSEMBLY__ */ + +#endif /* _ASM_RISCV_BARRIER_H */ diff --git a/xen/arch/riscv/include/asm/time.h b/xen/arch/riscv/include/asm/time.h new file mode 100644 index 0000000000..3fc1b891b5 --- /dev/null +++ b/xen/arch/riscv/include/asm/time.h @@ -0,0 +1,81 @@ + /* + * Copyright (C) 2012 Regents of the University of California + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _ASM_RISCV_TIMEX_H +#define _ASM_RISCV_TIMEX_H + +#include +#include + +typedef unsigned long cycles_t; + +static inline s_time_t ticks_to_ns(uint64_t ticks) +{ + return muldiv64(ticks, SECONDS(1), 1000 * cpu_khz); +} + +static inline uint64_t ns_to_ticks(s_time_t ns) +{ + return muldiv64(ns, 1000 * cpu_khz, SECONDS(1)); +} + +static inline cycles_t get_cycles_inline(void) +{ + cycles_t n; + + __asm__ __volatile__ ( + "rdtime %0" + : "=r" (n)); + return n; +} +#define get_cycles get_cycles_inline + +#ifdef CONFIG_64BIT +static inline uint64_t get_cycles64(void) +{ + return get_cycles(); +} +#else +static inline uint64_t get_cycles64(void) +{ + u32 lo, hi, tmp; + __asm__ __volatile__ ( + "1:\n" + "rdtimeh %0\n" + "rdtime %1\n" + "rdtimeh %2\n" + "bne %0, %2, 1b" + : "=&r" (hi), "=&r" (lo), "=&r" (tmp)); + return ((u64)hi << 32) | lo; +} +#endif + +#define ARCH_HAS_READ_CURRENT_TIMER + +static inline int read_current_timer(unsigned long *timer_val) +{ + *timer_val = get_cycles(); + return 0; +} + +extern void preinit_xen_time(void); + +extern void init_timer_interrupt(void); + +extern void timer_interrupt(unsigned long cause, struct cpu_user_regs *regs); + +extern void force_update_vcpu_system_time(struct vcpu *v); + +extern uint64_t boot_count; + +#endif /* _ASM_RISCV_TIMEX_H */ diff --git a/xen/arch/riscv/include/asm/trace.h b/xen/arch/riscv/include/asm/trace.h new file mode 100644 index 0000000000..e06def61f6 --- /dev/null +++ b/xen/arch/riscv/include/asm/trace.h @@ -0,0 +1,12 @@ +#ifndef __ASM_TRACE_H__ +#define __ASM_TRACE_H__ + +#endif /* __ASM_TRACE_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h new file mode 100644 index 0000000000..1db96a8e3b --- /dev/null +++ b/xen/arch/riscv/include/asm/traps.h @@ -0,0 +1,30 @@ +#ifndef __ASM_TRAPS_H__ +#define __ASM_TRAPS_H__ + +#ifndef __ASSEMBLY__ + +void __handle_exception(void); +void handle_exception(void); + +struct riscv_trap { + unsigned long sepc; + unsigned long scause; + unsigned long stval; + unsigned long htval; + unsigned long htinst; +}; + +#endif /* __ASSEMBLY__ */ + +#define RISCV_TRAP_sepc 0 +#define RISCV_TRAP_scause 1 +#define RISCV_TRAP_stval 2 +#define RISCV_TRAP_htval 3 +#define RISCV_TRAP_htinst 4 +#define RISCV_TRAP_last 5 +#define RISCV_TRAP_OFFSET(x) ((RISCV_TRAP_##x) * __SIZEOF_POINTER__) +#define RISCV_TRAP_SIZE RISCV_TRAP_OFFSET(last) + + +#endif /* __ASM_TRAPS_H__ */ + diff --git a/xen/arch/riscv/include/asm/types.h b/xen/arch/riscv/include/asm/types.h new file mode 100644 index 0000000000..48f27f97ba --- /dev/null +++ b/xen/arch/riscv/include/asm/types.h @@ -0,0 +1,73 @@ +#ifndef __RISCV_TYPES_H__ +#define __RISCV_TYPES_H__ + +#ifndef __ASSEMBLY__ + +typedef __signed__ char __s8; +typedef unsigned char __u8; + +typedef __signed__ short __s16; +typedef unsigned short __u16; + +typedef __signed__ int __s32; +typedef unsigned int __u32; + +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) +#if defined(CONFIG_RISCV_32) +typedef __signed__ long long __s64; +typedef unsigned long long __u64; +#elif defined (CONFIG_RISCV_64) +typedef __signed__ long __s64; +typedef unsigned long __u64; +#endif +#endif + +typedef signed char s8; +typedef unsigned char u8; + +typedef signed short s16; +typedef unsigned short u16; + +typedef signed int s32; +typedef unsigned int u32; + +#if defined(CONFIG_RISCV_32) +typedef signed long long s64; +typedef unsigned long long u64; +typedef u32 vaddr_t; +#define PRIvaddr PRIx32 +typedef u64 paddr_t; +#define INVALID_PADDR (~0ULL) +#define PRIpaddr "016llx" +typedef u32 register_t; +#define PRIregister "x" +#elif defined (CONFIG_RISCV_64) +typedef signed long s64; +typedef unsigned long u64; +typedef u64 vaddr_t; +#define PRIvaddr PRIx64 +typedef u64 paddr_t; +#define INVALID_PADDR (~0UL) +#define PRIpaddr "016lx" +typedef u64 register_t; +#define PRIregister "lx" +#endif + +#if defined(__SIZE_TYPE__) +typedef __SIZE_TYPE__ size_t; +#else +typedef unsigned long size_t; +#endif +typedef signed long ssize_t; + +#endif /* __ASSEMBLY__ */ + +#endif /* __RISCV_TYPES_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/include/asm/vm_event.h b/xen/arch/riscv/include/asm/vm_event.h new file mode 100644 index 0000000000..be9ef3bb8d --- /dev/null +++ b/xen/arch/riscv/include/asm/vm_event.h @@ -0,0 +1,63 @@ +/* + * vm_event.h: architecture specific vm_event handling routines + * + * Copyright (c) 2015 Tamas K Lengyel (tamas@tklengyel.com) + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program; If not, see . + */ + +#ifndef __ASM_RISCV_VM_EVENT_H__ +#define __ASM_RISCV_VM_EVENT_H__ + +#include +#include +#include + +static inline int vm_event_init_domain(struct domain *d) +{ + /* Nothing to do. */ + return 0; +} + +static inline void vm_event_cleanup_domain(struct domain *d) +{ + memset(&d->monitor, 0, sizeof(d->monitor)); +} + +static inline void vm_event_toggle_singlestep(struct domain *d, struct vcpu *v, + vm_event_response_t *rsp) +{ + /* Not supported on RISCV. */ +} + +static inline +void vm_event_register_write_resume(struct vcpu *v, vm_event_response_t *rsp) +{ + /* Not supported on RISCV. */ +} + +static inline +void vm_event_emulate_check(struct vcpu *v, vm_event_response_t *rsp) +{ + /* Not supported on RISCV. */ +} + +static inline +void vm_event_sync_event(struct vcpu *v, bool value) +{ + /* Not supported on RISCV. */ +} + +void vm_event_reset_vmtrace(struct vcpu *v); + +#endif /* __ASM_RISCV_VM_EVENT_H__ */ diff --git a/xen/arch/riscv/include/asm/xenoprof.h b/xen/arch/riscv/include/asm/xenoprof.h new file mode 100644 index 0000000000..3db6ce3ab2 --- /dev/null +++ b/xen/arch/riscv/include/asm/xenoprof.h @@ -0,0 +1,12 @@ +#ifndef __ASM_XENOPROF_H__ +#define __ASM_XENOPROF_H__ + +#endif /* __ASM_XENOPROF_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/irq.c b/xen/arch/riscv/irq.c new file mode 100644 index 0000000000..66aecdec25 --- /dev/null +++ b/xen/arch/riscv/irq.c @@ -0,0 +1,126 @@ +/* + * RISC-V Interrupt support + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include + +const unsigned int nr_irqs = NR_IRQS; + +/* Describe an IRQ assigned to a guest */ +struct irq_guest +{ + struct domain *d; + unsigned int virq; +}; + +static void ack_none(struct irq_desc *irq) +{ + /* TODO */ + BUG(); +} + +static void end_none(struct irq_desc *irq) +{ + /* TODO */ + BUG(); +} + +hw_irq_controller no_irq_type = { + .typename = "none", + .startup = irq_startup_none, + .shutdown = irq_shutdown_none, + .enable = irq_enable_none, + .disable = irq_disable_none, + .ack = ack_none, + .end = end_none +}; + +int arch_init_one_irq_desc(struct irq_desc *desc) +{ + /* TODO */ + BUG(); + return 0; +} + +struct pirq *alloc_pirq_struct(struct domain *d) +{ + /* TODO */ + BUG(); + return NULL; +} + +irq_desc_t *__irq_to_desc(int irq) +{ + /* TODO */ + BUG(); + return 0; +} + +int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share) +{ + BUG(); +} + +void pirq_guest_unbind(struct domain *d, struct pirq *pirq) +{ + + BUG(); +} + +void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask) +{ + BUG(); +} + +void smp_send_state_dump(unsigned int cpu) +{ + /* TODO */ +} + +void arch_move_irqs(struct vcpu *v) +{ + /* TODO */ +} + +int setup_irq(unsigned int irq, unsigned int irqflags, struct irqaction *new) +{ + /* TODO */ + BUG(); + return -ENOSYS;; +} + +int platform_get_irq(const struct dt_device_node *device, int index) +{ + struct dt_irq dt_irq; + unsigned int irq; + + if ( dt_device_get_irq(device, index, &dt_irq) ) + return -1; + + irq = dt_irq.irq; + + return irq; +} + +int irq_set_spi_type(unsigned int spi, unsigned int type) +{ + return 0; +} + +int irq_set_type(unsigned int irq, unsigned int type) +{ + return 0; +} diff --git a/xen/arch/riscv/lib/Makefile b/xen/arch/riscv/lib/Makefile new file mode 100644 index 0000000000..6fae6a1f10 --- /dev/null +++ b/xen/arch/riscv/lib/Makefile @@ -0,0 +1 @@ +obj-y += find_next_bit.o diff --git a/xen/arch/riscv/lib/find_next_bit.c b/xen/arch/riscv/lib/find_next_bit.c new file mode 100644 index 0000000000..bfae3e10de --- /dev/null +++ b/xen/arch/riscv/lib/find_next_bit.c @@ -0,0 +1,285 @@ +/* find_next_bit.c: fallback find next bit implementation + * + * Copyright (C) 2004 Red Hat, Inc. All Rights Reserved. + * Written by David Howells (dhowells@redhat.com) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + */ +#include +#include +#include +#include +#include + +#define BITOP_WORD(nr) ((nr) / BITS_PER_LONG) + +#ifndef find_next_bit +/* + * Find the next set bit in a memory region. + */ +unsigned long find_next_bit(const unsigned long *addr, unsigned long size, + unsigned long offset) +{ + const unsigned long *p = addr + BITOP_WORD(offset); + unsigned long result = offset & ~(BITS_PER_LONG-1); + unsigned long tmp; + + if (offset >= size) + return size; + size -= result; + offset %= BITS_PER_LONG; + if (offset) { + tmp = *(p++); + tmp &= (~0UL << offset); + if (size < BITS_PER_LONG) + goto found_first; + if (tmp) + goto found_middle; + size -= BITS_PER_LONG; + result += BITS_PER_LONG; + } + while (size & ~(BITS_PER_LONG-1)) { + if ((tmp = *(p++))) + goto found_middle; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + tmp = *p; + +found_first: + tmp &= (~0UL >> (BITS_PER_LONG - size)); + if (tmp == 0UL) /* Are any bits set? */ + return result + size; /* Nope. */ +found_middle: + return result + ffs(tmp); +} +EXPORT_SYMBOL(find_next_bit); +#endif + +#ifndef find_next_zero_bit +/* + * This implementation of find_{first,next}_zero_bit was stolen from + * Linus' asm-alpha/bitops.h. + */ +unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size, + unsigned long offset) +{ + const unsigned long *p = addr + BITOP_WORD(offset); + unsigned long result = offset & ~(BITS_PER_LONG-1); + unsigned long tmp; + + if (offset >= size) + return size; + size -= result; + offset %= BITS_PER_LONG; + if (offset) { + tmp = *(p++); + tmp |= ~0UL >> (BITS_PER_LONG - offset); + if (size < BITS_PER_LONG) + goto found_first; + if (~tmp) + goto found_middle; + size -= BITS_PER_LONG; + result += BITS_PER_LONG; + } + while (size & ~(BITS_PER_LONG-1)) { + if (~(tmp = *(p++))) + goto found_middle; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + tmp = *p; + +found_first: + tmp |= ~0UL << size; + if (tmp == ~0UL) /* Are any bits zero? */ + return result + size; /* Nope. */ +found_middle: + return result + ffz(tmp); +} +EXPORT_SYMBOL(find_next_zero_bit); +#endif + +#ifndef find_first_bit +/* + * Find the first set bit in a memory region. + */ +unsigned long find_first_bit(const unsigned long *addr, unsigned long size) +{ + const unsigned long *p = addr; + unsigned long result = 0; + unsigned long tmp; + + while (size & ~(BITS_PER_LONG-1)) { + if ((tmp = *(p++))) + goto found; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + + tmp = (*p) & (~0UL >> (BITS_PER_LONG - size)); + if (tmp == 0UL) /* Are any bits set? */ + return result + size; /* Nope. */ +found: + return result + __ffs(tmp); +} +EXPORT_SYMBOL(find_first_bit); +#endif + +#ifndef find_first_zero_bit +/* + * Find the first cleared bit in a memory region. + */ +unsigned long find_first_zero_bit(const unsigned long *addr, unsigned long size) +{ + const unsigned long *p = addr; + unsigned long result = 0; + unsigned long tmp; + + while (size & ~(BITS_PER_LONG-1)) { + if (~(tmp = *(p++))) + goto found; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + + tmp = (*p) | (~0UL << size); + if (tmp == ~0UL) /* Are any bits zero? */ + return result + size; /* Nope. */ +found: + return result + ffz(tmp); +} +EXPORT_SYMBOL(find_first_zero_bit); +#endif + +#ifdef __BIG_ENDIAN + +/* include/linux/byteorder does not support "unsigned long" type */ +static inline unsigned long ext2_swabp(const unsigned long * x) +{ +#if BITS_PER_LONG == 64 + return (unsigned long) __swab64p((u64 *) x); +#elif BITS_PER_LONG == 32 + return (unsigned long) __swab32p((u32 *) x); +#else +#error BITS_PER_LONG not defined +#endif +} + +/* include/linux/byteorder doesn't support "unsigned long" type */ +static inline unsigned long ext2_swab(const unsigned long y) +{ +#if BITS_PER_LONG == 64 + return (unsigned long) __swab64((u64) y); +#elif BITS_PER_LONG == 32 + return (unsigned long) __swab32((u32) y); +#else +#error BITS_PER_LONG not defined +#endif +} + +#ifndef find_next_zero_bit_le +unsigned long find_next_zero_bit_le(const void *addr, unsigned + long size, unsigned long offset) +{ + const unsigned long *p = addr; + unsigned long result = offset & ~(BITS_PER_LONG - 1); + unsigned long tmp; + + if (offset >= size) + return size; + p += BITOP_WORD(offset); + size -= result; + offset &= (BITS_PER_LONG - 1UL); + if (offset) { + tmp = ext2_swabp(p++); + tmp |= (~0UL >> (BITS_PER_LONG - offset)); + if (size < BITS_PER_LONG) + goto found_first; + if (~tmp) + goto found_middle; + size -= BITS_PER_LONG; + result += BITS_PER_LONG; + } + + while (size & ~(BITS_PER_LONG - 1)) { + if (~(tmp = *(p++))) + goto found_middle_swap; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + tmp = ext2_swabp(p); +found_first: + tmp |= ~0UL << size; + if (tmp == ~0UL) /* Are any bits zero? */ + return result + size; /* Nope. Skip ffz */ +found_middle: + return result + ffz(tmp); + +found_middle_swap: + return result + ffz(ext2_swab(tmp)); +} +EXPORT_SYMBOL(find_next_zero_bit_le); +#endif + +#ifndef find_next_bit_le +unsigned long find_next_bit_le(const void *addr, unsigned + long size, unsigned long offset) +{ + const unsigned long *p = addr; + unsigned long result = offset & ~(BITS_PER_LONG - 1); + unsigned long tmp; + + if (offset >= size) + return size; + p += BITOP_WORD(offset); + size -= result; + offset &= (BITS_PER_LONG - 1UL); + if (offset) { + tmp = ext2_swabp(p++); + tmp &= (~0UL << offset); + if (size < BITS_PER_LONG) + goto found_first; + if (tmp) + goto found_middle; + size -= BITS_PER_LONG; + result += BITS_PER_LONG; + } + + while (size & ~(BITS_PER_LONG - 1)) { + tmp = *(p++); + if (tmp) + goto found_middle_swap; + result += BITS_PER_LONG; + size -= BITS_PER_LONG; + } + if (!size) + return result; + tmp = ext2_swabp(p); +found_first: + tmp &= (~0UL >> (BITS_PER_LONG - size)); + if (tmp == 0UL) /* Are any bits set? */ + return result + size; /* Nope. */ +found_middle: + return result + ffs(tmp); + +found_middle_swap: + return result + ffs(ext2_swab(tmp)); +} +EXPORT_SYMBOL(find_next_bit_le); +#endif + +#endif /* __BIG_ENDIAN */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c new file mode 100644 index 0000000000..f366b1ca0c --- /dev/null +++ b/xen/arch/riscv/mm.c @@ -0,0 +1,409 @@ +/* + * xen/arch/riscv/mm.c + * + * MMU code for a RISC-V RV32/64 with hypervisor extensions. + * + * Copyright (c) 2019 Bobby Eshleman + * + * Based on code that is Copyright (c) 2018 Anup Patel. + * Based on code that is Copyright (c) 2011 Tim Deegan + * Based on code that is Copyright (c) 2011 Citrix Systems. + * + * Parts of this code are based on: + * ARM/Xen: xen/arch/arm/mm.c. + * Xvisor: arch/riscv/cpu/generic/cpu_mmu_initial_pgtbl.c + * (https://github.com/xvisor/xvisor/tree/v0.2.11) + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define XEN_TABLE_MAP_FAILED 0 +#define XEN_TABLE_SUPER_PAGE 1 +#define XEN_TABLE_NORMAL_PAGE 2 + +enum pt_level { + pt_level_zero, + pt_level_one, +#if CONFIG_PAGING_LEVELS == 3 + pt_level_two, +#endif +}; + +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) +#undef mfn_to_virt +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) + +/* Limits of the Xen heap */ +mfn_t xenheap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t xenheap_mfn_end __read_mostly; +vaddr_t xenheap_virt_end __read_mostly; +vaddr_t xenheap_virt_start __read_mostly; +unsigned long xenheap_base_pdx __read_mostly; + +/* Limits of frametable */ +unsigned long frametable_virt_end __read_mostly; +unsigned long frametable_base_pdx; + +static pte_t xen_fixmap[PAGE_ENTRIES] __attribute__((__aligned__(4096))); + +#define THIS_CPU_PGTABLE xen_second_pagetable + +/* Used by _setup_initial_pagetables() and initialized by head.S */ +extern unsigned long _text_start; +extern unsigned long _text_end; +extern unsigned long _cpuinit_start; +extern unsigned long _cpuinit_end; +extern unsigned long _spinlock_start; +extern unsigned long _spinlock_end; +extern unsigned long _init_start; +extern unsigned long _init_end; +extern unsigned long _rodata_start; +extern unsigned long _rodata_end; + +paddr_t phys_offset; +unsigned long max_page; + +static inline pte_t mfn_to_pte(mfn_t mfn) +{ + unsigned long pte = mfn_x(mfn) << PTE_SHIFT; + return (pte_t){ .pte = pte }; +} + +void *__init arch_vmap_virt_end(void) +{ + return (void *)VMAP_VIRT_END; +} + +static inline pte_t mfn_to_xen_entry(mfn_t mfn) +{ + return mfn_to_pte(mfn); +} + +/* Map a 4k page in a fixmap entry */ +void set_fixmap(unsigned map, mfn_t mfn, unsigned int flags) +{ + pte_t pte; + + pte = mfn_to_xen_entry(mfn); + pte.pte |= PTE_LEAF_DEFAULT; + write_pte(&xen_fixmap[pagetable_zeroeth_index(FIXMAP_ADDR(map))], pte); +} + +/* Remove a mapping from a fixmap entry */ +void clear_fixmap(unsigned map) +{ + pte_t pte = {0}; + write_pte(&xen_fixmap[pagetable_zeroeth_index(FIXMAP_ADDR(map))], pte); +} + +#ifdef CONFIG_DOMAIN_PAGE +void *map_domain_page_global(mfn_t mfn) +{ + return vmap(&mfn, 1); +} + +void unmap_domain_page_global(const void *va) +{ + vunmap(va); +} +#endif + +void flush_page_to_ram(unsigned long mfn, bool sync_icache) +{ + void *va = map_domain_page(_mfn(mfn)); + unmap_domain_page(va); + + /* TODO */ + + if ( sync_icache ) + invalidate_icache(); +} + +enum xenmap_operation { INSERT, REMOVE, MODIFY, RESERVE }; + +int map_pages_to_xen(unsigned long virt, mfn_t mfn, unsigned long nr_mfns, + unsigned int flags) +{ + return -ENOSYS; +} + +int populate_pt_range(unsigned long virt, unsigned long nr_mfns) +{ + (void) virt; + (void) nr_mfns; + + /* TODO */ + + return 0; +} + +int destroy_xen_mappings(unsigned long v, unsigned long e) +{ + (void) v; + (void) e; + + /* TODO */ + + return 0; +} + +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) +{ + (void) s; + (void) e; + (void) flags; + + /* TODO */ + + return 0; +} + +void arch_dump_shared_mem_info(void) +{ + /* TODO */ +} + +int donate_page(struct domain *d, struct page_info *page, unsigned int memflags) +{ + ASSERT_UNREACHABLE(); + return -ENOSYS; +} + +int steal_page(struct domain *d, struct page_info *page, unsigned int memflags) +{ + return -EOPNOTSUPP; +} + +int page_is_ram_type(unsigned long mfn, unsigned long mem_type) +{ + ASSERT_UNREACHABLE(); + return 0; +} + +unsigned long domain_get_maximum_gpfn(struct domain *d) +{ + BUG(); + return 0; +} + +void share_xen_page_with_guest(struct page_info *page, struct domain *d, + enum XENSHARE_flags flags) +{ + if ( page_get_owner(page) == d ) + return; + + spin_lock(&d->page_alloc_lock); + + /* TODO */ + + spin_unlock(&d->page_alloc_lock); +} + +int xenmem_add_to_physmap_one(struct domain *d, unsigned int space, + union add_to_physmap_extra extra, + unsigned long idx, gfn_t gfn) +{ + /* TODO */ + + return 0; +} + +long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) +{ + /* TODO */ + return 0; +} + +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + unsigned long x, y = page->count_info; + struct domain *owner; + + do + { + x = y; + /* + * Count == 0: Page is not allocated, so we cannot take a reference. + * Count == -1: Reference count would wrap, which is invalid. + */ + if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + return NULL; + } while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + + owner = page_get_owner(page); + ASSERT(owner); + + return owner; +} + +void put_page(struct page_info *page) +{ + unsigned long nx, x, y = page->count_info; + + do + { + ASSERT((y & PGC_count_mask) != 0); + x = y; + nx = x - 1; + } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); + + if ( unlikely((nx & PGC_count_mask) == 0) ) + { + free_domheap_page(page); + } +} + +bool get_page(struct page_info *page, const struct domain *domain) +{ + struct domain *owner = page_get_owner_and_reference(page); + + if ( likely(owner == domain) ) + return true; + + if ( owner != NULL ) + put_page(page); + + return false; +} + +/* Common code requires get_page_type and put_page_type. + * We don't care about typecounts so we just do the minimum to make it + * happy. */ +int get_page_type(struct page_info *page, unsigned long type) +{ + return 1; +} + +void put_page_type(struct page_info *page) +{ + return; +} + +/* + * This function should only be used to remap device address ranges + * TODO: add a check to verify this assumption + */ +void __iomem *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) +{ + mfn_t mfn = _mfn(PFN_DOWN(pa)); + unsigned int offs = pa & (PAGE_SIZE - 1); + unsigned int nr = PFN_UP(offs + len); + + void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); + + if ( ptr == NULL ) + return NULL; + + return ptr + offs; +} + +void *ioremap(paddr_t pa, size_t len) +{ + return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); +} + +#ifdef CONFIG_GRANT_TABLE +void gnttab_clear_flags(struct domain *d, unsigned long nr, uint16_t *addr) +{ + /* TODO */ +} + +void gnttab_mark_dirty(struct domain *d, mfn_t mfn) +{ + /* TODO */ +} + +int create_grant_host_mapping(unsigned long addr, mfn_t frame, + unsigned int flags, unsigned int cache_flags) +{ + /* TODO */ +} + +int replace_grant_host_mapping(unsigned long addr, mfn_t mfn, + unsigned long new_addr, unsigned int flags) +{ + /* TODO */ +} +#endif + +bool is_iomem_page(mfn_t mfn) +{ + return !mfn_valid(mfn); +} + +unsigned long get_upper_mfn_bound(void) +{ + /* No memory hotplug yet, so current memory limit is the final one. */ + return max_page - 1; +} + +/* + * Map the table that pte points to. + */ +void *map_domain_table(pte_t *pte) +{ + return map_domain_page(maddr_to_mfn((paddr_t)pte_to_paddr(pte))); +} + +void unmap_domain_table(pte_t *table) +{ + return unmap_domain_page(table); +} + +paddr_t __virt_to_maddr(vaddr_t va) +{ + /* TODO */ + return 0; +} + +int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, + unsigned int order) +{ + return 0; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/p2m.c b/xen/arch/riscv/p2m.c new file mode 100644 index 0000000000..54207f8230 --- /dev/null +++ b/xen/arch/riscv/p2m.c @@ -0,0 +1,97 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +void memory_type_changed(struct domain *d) +{ +} + +mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn) +{ + /* TODO */ + return INVALID_MFN; +} + +int map_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn, + p2m_type_t p2mt) +{ + return -ENOSYS; +} + +int unmap_regions_p2mt(struct domain *d, + gfn_t gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int map_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int unmap_mmio_regions(struct domain *d, + gfn_t start_gfn, + unsigned long nr, + mfn_t mfn) +{ + return -ENOSYS; +} + +int guest_physmap_add_entry(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned long page_order, + p2m_type_t t) +{ + return -ENOSYS; +} + +int guest_physmap_remove_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order) +{ + return -ENOSYS; +} + + +void vcpu_mark_events_pending(struct vcpu *v) +{ + /* TODO */ +} + +void vcpu_update_evtchn_irq(struct vcpu *v) +{ + /* TODO */ +} + +struct page_info *get_page_from_gfn(struct domain *d, unsigned long gfn, + p2m_type_t *t, p2m_query_t q) +{ + /* TODO */ + return NULL; +} + +int set_foreign_p2m_entry(struct domain *d, const struct domain *fd, + unsigned long gfn, mfn_t mfn) +{ + return -EOPNOTSUPP; +} + +unsigned long p2m_pod_decrease_reservation(struct domain *d, gfn_t gfn, + unsigned int order) +{ + return 0; +} diff --git a/xen/arch/riscv/percpu.c b/xen/arch/riscv/percpu.c new file mode 100644 index 0000000000..25442c48fe --- /dev/null +++ b/xen/arch/riscv/percpu.c @@ -0,0 +1,84 @@ +#include +#include +#include +#include +#include + +unsigned long __per_cpu_offset[NR_CPUS]; +#define INVALID_PERCPU_AREA (-(long)__per_cpu_start) +#define PERCPU_ORDER (get_order_from_bytes(__per_cpu_data_end-__per_cpu_start)) + +void __init percpu_init_areas(void) +{ + unsigned int cpu; + for ( cpu = 1; cpu < NR_CPUS; cpu++ ) + __per_cpu_offset[cpu] = INVALID_PERCPU_AREA; +} + +static int init_percpu_area(unsigned int cpu) +{ + char *p; + if ( __per_cpu_offset[cpu] != INVALID_PERCPU_AREA ) + return -EBUSY; + if ( (p = alloc_xenheap_pages(PERCPU_ORDER, 0)) == NULL ) + return -ENOMEM; + memset(p, 0, __per_cpu_data_end - __per_cpu_start); + __per_cpu_offset[cpu] = p - __per_cpu_start; + return 0; +} + +struct free_info { + unsigned int cpu; + struct rcu_head rcu; +}; +static DEFINE_PER_CPU(struct free_info, free_info); + +static void _free_percpu_area(struct rcu_head *head) +{ + struct free_info *info = container_of(head, struct free_info, rcu); + unsigned int cpu = info->cpu; + char *p = __per_cpu_start + __per_cpu_offset[cpu]; + free_xenheap_pages(p, PERCPU_ORDER); + __per_cpu_offset[cpu] = INVALID_PERCPU_AREA; +} + +static void free_percpu_area(unsigned int cpu) +{ + struct free_info *info = &per_cpu(free_info, cpu); + info->cpu = cpu; + call_rcu(&info->rcu, _free_percpu_area); +} + +static int cpu_percpu_callback( + struct notifier_block *nfb, unsigned long action, void *hcpu) +{ + unsigned int cpu = (unsigned long)hcpu; + int rc = 0; + + switch ( action ) + { + case CPU_UP_PREPARE: + rc = init_percpu_area(cpu); + break; + case CPU_UP_CANCELED: + case CPU_DEAD: + free_percpu_area(cpu); + break; + default: + break; + } + + return !rc ? NOTIFY_DONE : notifier_from_errno(rc); +} + +static struct notifier_block cpu_percpu_nfb = { + .notifier_call = cpu_percpu_callback, + .priority = 100 /* highest priority */ +}; + +static int __init percpu_presmp_init(void) +{ + register_cpu_notifier(&cpu_percpu_nfb); + return 0; +} +presmp_initcall(percpu_presmp_init); diff --git a/xen/arch/riscv/platforms/Kconfig b/xen/arch/riscv/platforms/Kconfig new file mode 100644 index 0000000000..6959ec35a2 --- /dev/null +++ b/xen/arch/riscv/platforms/Kconfig @@ -0,0 +1,31 @@ +choice + prompt "Platform Support" + default ALL_PLAT + ---help--- + Choose which hardware platform to enable in Xen. + + If unsure, choose ALL_PLAT. + +config ALL_PLAT + bool "All Platforms" + ---help--- + Enable support for all available hardware platforms. It doesn't + automatically select any of the related drivers. + +config QEMU + bool "QEMU RISC-V virt machine support" + depends on RISCV + select HAS_NS16550 + ---help--- + Enable all the required drivers for QEMU RISC-V virt emulated + machine. + +endchoice + +config ALL64_PLAT + bool + default (ALL_PLAT && RISCV_64) + +config ALL32_PLAT + bool + default (ALL_PLAT && RISCV_32) diff --git a/xen/arch/riscv/riscv64/Makefile b/xen/arch/riscv/riscv64/Makefile index 15a4a65f66..3340058c08 100644 --- a/xen/arch/riscv/riscv64/Makefile +++ b/xen/arch/riscv/riscv64/Makefile @@ -1 +1 @@ -extra-y += head.o +obj-y += head.o diff --git a/xen/arch/riscv/riscv64/asm-offsets.c b/xen/arch/riscv/riscv64/asm-offsets.c index e69de29bb2..d246e80413 100644 --- a/xen/arch/riscv/riscv64/asm-offsets.c +++ b/xen/arch/riscv/riscv64/asm-offsets.c @@ -0,0 +1,39 @@ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2017 SiFive + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, version 2. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define COMPILE_OFFSETS + +#include +#include +#include +#include +#include +#include +#include + +#define DEFINE(_sym, _val) \ + asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ + : : "i" (_val) ) +#define BLANK() \ + asm volatile ( "\n.ascii\"==><==\"" : : ) +#define OFFSET(_sym, _str, _mem) \ + DEFINE(_sym, offsetof(_str, _mem)); + +void asm_offsets(void) +{ + + BLANK(); + OFFSET(INITINFO_stack, struct init_info, stack); + DEFINE(PCPUINFO_sizeof, sizeof(struct pcpu_info)); +} diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 0dbc27ba75..5cccab09c7 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,6 +1,13 @@ +#include +#include +#include +#include #include +#include - .text - + .section .text.header, "ax", %progbits ENTRY(start) - j start +_start_hang: + wfi + j _start_hang +ENDPROC(start) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c new file mode 100644 index 0000000000..79beb25ff3 --- /dev/null +++ b/xen/arch/riscv/setup.c @@ -0,0 +1,65 @@ +/* + * xen/arch/riscv/setup.c + * + * + * Early bringup code for a RISC-V RV32/64 with hypervisor + * extensions (code H). + * + * Based off the ARM setup code with copyright Tim Deegan + * + * Copyright (c) 2019 Bobby Eshleman + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include + +domid_t max_init_domid = 0; + +struct domain *xen_dom; + +bool acpi_disabled = true; + +/* The lucky hart to first increment this variable will boot the other cores */ +atomic_t hart_lottery; +unsigned long boot_cpu_hartid; +unsigned long total_pages; + +void arch_get_xen_caps(xen_capabilities_info_t *info) +{ + /* Interface name is always xen-3.0-* for Xen-3.x. */ + int major = 3, minor = 0; + char s[32]; + + (*info)[0] = '\0'; + + snprintf(s, sizeof(s), "xen-%d.%d-riscv ", major, minor); + safe_strcat(*info, s); +} + +/** start_xen - The C entry point + * + * The real entry point is in head.S. + */ +void __init start_xen(paddr_t fdt_paddr, paddr_t boot_phys_offset) +{ +} +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/shutdown.c b/xen/arch/riscv/shutdown.c new file mode 100644 index 0000000000..90ade9a555 --- /dev/null +++ b/xen/arch/riscv/shutdown.c @@ -0,0 +1,24 @@ +#include +#include +#include +#include +#include + +void machine_halt(void) +{ + /* TODO */ +} + +void machine_restart(unsigned int delay_millisecs) +{ + /* TODO */ +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/smp.c b/xen/arch/riscv/smp.c new file mode 100644 index 0000000000..847517937c --- /dev/null +++ b/xen/arch/riscv/smp.c @@ -0,0 +1,38 @@ +#include +#include +#include +#include +#include +#include + +volatile unsigned long start_secondary_pen_release = HARTID_INVALID; + +/* tp points to one of these per cpu */ +struct pcpu_info pcpu_info[NR_CPUS]; + +void arch_flush_tlb_mask(const cpumask_t *mask) +{ + /* TODO */ + BUG(); +} + +void smp_send_event_check_mask(const cpumask_t *mask) +{ + /* TODO */ + printk("%s: smp not supported yet\n", __func__); +} + +void smp_send_call_function_mask(const cpumask_t *mask) +{ + /* TODO */ + printk("%s: smp not supported yet\n", __func__); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/smpboot.c b/xen/arch/riscv/smpboot.c new file mode 100644 index 0000000000..b3d19ff880 --- /dev/null +++ b/xen/arch/riscv/smpboot.c @@ -0,0 +1,78 @@ +/* + * Dummy smpboot support + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ +#include +#include +#include +#include +#include +#include +#include + +cpumask_t cpu_online_map; +cpumask_t cpu_present_map; +cpumask_t cpu_possible_map; + +DEFINE_PER_CPU(unsigned int, cpu_id); +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_mask); +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_core_mask); + +/* Fake one node for now. See also include/asm-arm/numa.h */ +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +/* Boot cpu data */ +struct init_info init_data = +{ +}; + +int __cpu_up(unsigned int cpu) +{ + /* TODO */ + BUG(); + return 0; +} + +/* Shut down the current CPU */ +void __cpu_disable(void) +{ + /* TODO */ + BUG(); +} + +void __cpu_die(unsigned int cpu) +{ + /* TODO */ + BUG(); +} + +int __init +smp_get_max_cpus(void) +{ + int i, max_cpus = 0; + + for ( i = 0; i < nr_cpu_ids; i++ ) + if ( cpu_possible(i) ) + max_cpus++; + + return max_cpus; +} + +void __init +smp_clear_cpu_maps (void) +{ + cpumask_clear(&cpu_possible_map); + cpumask_clear(&cpu_online_map); + cpumask_set_cpu(0, &cpu_possible_map); + cpumask_set_cpu(0, &cpu_online_map); + cpumask_copy(&cpu_present_map, &cpu_possible_map); +} diff --git a/xen/arch/riscv/sysctl.c b/xen/arch/riscv/sysctl.c new file mode 100644 index 0000000000..fbfdb44eff --- /dev/null +++ b/xen/arch/riscv/sysctl.c @@ -0,0 +1,31 @@ +/****************************************************************************** + * Arch-specific sysctl.c + * + * System management operations. For use by node control stack. + * + * Copyright (c) 2012, Citrix Systems + */ + +#include +#include +#include +#include +#include + +void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { } + +long arch_do_sysctl(struct xen_sysctl *sysctl, + XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) +{ + return -ENOSYS; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/time.c b/xen/arch/riscv/time.c new file mode 100644 index 0000000000..465ff63505 --- /dev/null +++ b/xen/arch/riscv/time.c @@ -0,0 +1,69 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +unsigned long __read_mostly cpu_khz; /* CPU clock frequency in kHz. */ + +uint64_t __read_mostly boot_count; + + +s_time_t get_s_time(void) +{ + uint64_t ticks = get_cycles() - boot_count; + return ticks_to_ns(ticks); +} + + +/* VCPU PV timers. */ +void send_timer_event(struct vcpu *v) +{ + /* TODO */ +} + +/* VCPU PV clock. */ +void update_vcpu_system_time(struct vcpu *v) +{ + /* TODO */ + BUG(); +} + +void force_update_vcpu_system_time(struct vcpu *v) +{ + update_vcpu_system_time(v); +} + +void domain_set_time_offset(struct domain *d, int64_t time_offset_seconds) +{ + /* TODO */ + BUG(); +} + +int reprogram_timer(s_time_t timeout) +{ + /* TODO */ + return -ENOSYS; +} diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c new file mode 100644 index 0000000000..083dbf7113 --- /dev/null +++ b/xen/arch/riscv/traps.c @@ -0,0 +1,87 @@ +/* + * RISC-V Trap handlers + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +/* Included just for hardcoded values during development */ +#include + +#include +#include + +void __handle_exception(void) +{ + /* TODO */ + BUG(); +} + +void show_stack(const struct cpu_user_regs *regs) +{ + /* TODO */ + BUG(); +} + +void show_execution_state(const struct cpu_user_regs *regs) +{ + /* TODO */ + BUG(); +} + +void vcpu_show_execution_state(struct vcpu *v) +{ + /* TODO */ + BUG(); +} + +void arch_hypercall_tasklet_result(struct vcpu *v, long res) +{ + /* TODO */ + BUG(); +} + +enum mc_disposition arch_do_multicall_call(struct mc_state *state) +{ + /* TODO */ + BUG(); + return mc_continue; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/vm_event.c b/xen/arch/riscv/vm_event.c new file mode 100644 index 0000000000..7433362686 --- /dev/null +++ b/xen/arch/riscv/vm_event.c @@ -0,0 +1,51 @@ +/* + * Architecture-specific vm_event handling routines + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public + * License along with this program; If not, see . + */ + +#include +#include + +void vm_event_fill_regs(vm_event_request_t *req) +{ + /* TODO */ + BUG(); +} + +void vm_event_set_registers(struct vcpu *v, vm_event_response_t *rsp) +{ + BUG(); + /* TODO */ +} + +void vm_event_monitor_next_interrupt(struct vcpu *v) +{ + /* TODO */ + BUG(); +} + +void vm_event_reset_vmtrace(struct vcpu *v) +{ + /* TODO */ + BUG(); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S new file mode 100644 index 0000000000..46f83d8f89 --- /dev/null +++ b/xen/arch/riscv/xen.lds.S @@ -0,0 +1,274 @@ +/** + * Copyright (c) 2018 Anup Patel. + * All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * + * @file linker.ld + * @author Anup Patel (anup@brainfault.org) + * @brief CPU specific linker script + */ + +#include +#include +#undef ENTRY +#undef ALIGN + +OUTPUT_ARCH(riscv) +ENTRY(start) + +PHDRS +{ + text PT_LOAD ; +#if defined(BUILD_ID) + note PT_NOTE ; +#endif +} + +SECTIONS +{ + . = XEN_VIRT_START; + . = ALIGN(PAGE_SIZE); /* Need this to create proper sections */ + _start = .; + PROVIDE(_code_start = .); + + /* Beginning of the code section */ + + .text : + { + PROVIDE(_text_start = .); + _stext = .; /* Text section */ + *(.text.header) + *(.entry) + *(.text) + . = ALIGN(8); + _etext = .; /* End of text section */ + PROVIDE(_text_end = .); + } :text = 0x9090 + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .init : + { + PROVIDE(_init_start = .); + + *(.init.text) + . = ALIGN(8); + + PROVIDE(__setup_start = .); + *(.setup.init); + PROVIDE(__setup_end = .); + + . = ALIGN(PAGE_SIZE); + *(.devtree) + . = ALIGN(PAGE_SIZE); + + PROVIDE(_init_end = .); + + . = ALIGN(PAGE_SIZE); + + PROVIDE(_initdata_start = .); + *(.init.data) + . = ALIGN(8); + PROVIDE(_initdata_end = .); + } + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .cpuinit : + { + PROVIDE(_cpuinit_start = .); + *(.cpuinit.*) + . = ALIGN(8); + PROVIDE(_cpuinit_end = .); + } + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .spinlock : + { + PROVIDE(_spinlock_start = .); + *(.spinlock.*) + . = ALIGN(8); + PROVIDE(_spinlock_end = .); + } + + /* End of the code sections */ + + /* Beginning of the read-only data sections */ + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .rodata : + { + PROVIDE(_rodata_start = .); + *(.rodata .rodata.*) + . = ALIGN(8); + _srodata = .; + /* Bug frames table */ + __start_bug_frames = .; + *(.bug_frames.0) + __stop_bug_frames_0 = .; + *(.bug_frames.1) + __stop_bug_frames_1 = .; + *(.bug_frames.2) + __stop_bug_frames_2 = .; + *(.bug_frames.3) + __stop_bug_frames_3 = .; + *(.rodata) + *(.rodata.*) + *(.data.rel.ro) + *(.data.rel.ro.*) + + . = ALIGN(POINTER_ALIGN); + __param_start = .; + *(.data.param) + __param_end = .; + + __proc_info_start = .; + *(.proc.info) + __proc_info_end = .; + PROVIDE(_rodata_end = .); + } + + . = ALIGN(4); + .note.gnu.build-id : { + __note_gnu_build_id_start = .; + *(.note.gnu.build-id) + __note_gnu_build_id_end = .; + } :note :text + + /* End of the read-only data sections */ + + /* Beginning of the read-write data sections */ + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .percpu : + { + PROVIDE(_percpu_start = .); + *(.percpu) + . = ALIGN(8); + PROVIDE(_percpu_end = .); + } + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .data : + { + PROVIDE(_data_start = .); + + *(.data.page_aligned) + *(.data) + . = ALIGN(8); + __start_schedulers_array = .; + *(.data.schedulers) + __end_schedulers_array = .; + *(.data.rel) + *(.data.rel.*) + CONSTRUCTORS + + PROVIDE(_data_end = .); + } + + . = ALIGN(8); + .dev.info : { + _sdevice = .; + *(.dev.info) + _edevice = .; + } :text + + . = ALIGN(PAGE_SIZE); /* Init code and data */ + __init_begin = .; + .init.text : { + _sinittext = .; + *(.init.text) + _einittext = .; + } :text + . = ALIGN(PAGE_SIZE); + .init.data : { + *(.init.rodata) + *(.init.rodata.rel) + *(.init.rodata.str*) + + . = ALIGN(POINTER_ALIGN); + __setup_start = .; + *(.init.setup) + __setup_end = .; + + __initcall_start = .; + *(.initcallpresmp.init) + __presmp_initcall_end = .; + *(.initcall1.init) + __initcall_end = .; + + . = ALIGN(4); + __alt_instructions = .; + *(.altinstructions) + __alt_instructions_end = .; + . = ALIGN(4); + *(.altinstr_replacement) + + *(.init.data) + *(.init.data.rel) + *(.init.data.rel.*) + + . = ALIGN(8); + __ctors_start = .; + *(.ctors) + *(.init_array) + *(SORT(.init_array.*)) + __ctors_end = .; + + } :text + . = ALIGN(STACK_SIZE); + __init_end = .; + + . = ALIGN(PAGE_SIZE); /* Ensure next section is page aligned */ + + .bss : + { + PROVIDE(_bss_start = .); + *(.bss.stack_aligned) + . = ALIGN(PAGE_SIZE); + *(.bss.page_aligned) + *(.bss) + . = ALIGN(SMP_CACHE_BYTES); + __per_cpu_start = .; + *(.bss.percpu) + . = ALIGN(SMP_CACHE_BYTES); + *(.bss.percpu.read_mostly) + . = ALIGN(SMP_CACHE_BYTES); + __per_cpu_data_end = .; + PROVIDE(_bss_end = .); + } + + . = ALIGN(STACK_SIZE); /* Ensure next section is aligned to the stack size */ + + .hvc_stack : + { + PROVIDE(_hvc_stack_start = .); + . = . + (STACK_SIZE * CONFIG_NR_CPUS); + . = ALIGN(8); + PROVIDE(_hvc_stack_end = .); + } + + /* End of the read-write data sections */ + + . = ALIGN(PAGE_SIZE); /* Need this to create proper pages */ + + PROVIDE(_code_end = .); + _end = .; +} diff --git a/xen/include/public/arch-riscv.h b/xen/include/public/arch-riscv.h new file mode 100644 index 0000000000..dfbe188d3b --- /dev/null +++ b/xen/include/public/arch-riscv.h @@ -0,0 +1,182 @@ +/****************************************************************************** + * arch-riscv.h + * + * Guest OS interface to RISC-V Xen. + * Initially based on the ARM implementation + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Copyright 2019 (C) Alistair Francis + */ + +#ifndef __XEN_PUBLIC_ARCH_RISCV_H__ +#define __XEN_PUBLIC_ARCH_RISCV_H__ + +#define int64_aligned_t int64_t __attribute__((aligned(8))) +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) + +#ifndef __ASSEMBLY__ +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ + typedef union { type *p; unsigned long q; } \ + __guest_handle_ ## name; \ + typedef union { type *p; uint64_aligned_t q; } \ + __guest_handle_64_ ## name + +/* + * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field + * in a struct in memory. On RISCV is always 8 bytes sizes and 8 bytes + * aligned. + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an + * hypercall argument. It is 4 bytes on aarch32 and 8 bytes on aarch64. + */ +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name +#define set_xen_guest_handle_raw(hnd, val) \ + do { \ + typeof(&(hnd)) _sxghr_tmp = &(hnd); \ + _sxghr_tmp->q = 0; \ + _sxghr_tmp->p = val; \ + } while ( 0 ) +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) + +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) +/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ +# define __DECL_REG(n64, n32) union { \ + uint64_t n64; \ + uint32_t n32; \ + } +#else +/* Non-gcc sources must always use the proper 64-bit name (e.g., x0). */ +#define __DECL_REG(n64, n32) uint64_t n64 +#endif + +struct vcpu_guest_core_regs +{ + unsigned long zero; + unsigned long ra; + unsigned long sp; + unsigned long gp; + unsigned long tp; + unsigned long t0; + unsigned long t1; + unsigned long t2; + unsigned long s0; + unsigned long s1; + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; + unsigned long a4; + unsigned long a5; + unsigned long a6; + unsigned long a7; + unsigned long s2; + unsigned long s3; + unsigned long s4; + unsigned long s5; + unsigned long s6; + unsigned long s7; + unsigned long s8; + unsigned long s9; + unsigned long s10; + unsigned long s11; + unsigned long t3; + unsigned long t4; + unsigned long t5; + unsigned long t6; + unsigned long sepc; + unsigned long sstatus; + unsigned long hstatus; + unsigned long sp_exec; + + unsigned long hedeleg; + unsigned long hideleg; + unsigned long bsstatus; + unsigned long bsie; + unsigned long bstvec; + unsigned long bsscratch; + unsigned long bsepc; + unsigned long bscause; + unsigned long bstval; + unsigned long bsip; + unsigned long bsatp; +}; +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); + +typedef uint64_t xen_pfn_t; +#define PRI_xen_pfn PRIx64 +#define PRIu_xen_pfn PRIu64 + +typedef uint64_t xen_ulong_t; +#define PRI_xen_ulong PRIx64 + +#if defined(__XEN__) || defined(__XEN_TOOLS__) + +struct vcpu_guest_context { +}; +typedef struct vcpu_guest_context vcpu_guest_context_t; +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); + +struct xen_arch_domainconfig { +}; + +#endif + +struct arch_vcpu_info { +}; +typedef struct arch_vcpu_info arch_vcpu_info_t; + +struct arch_shared_info { +}; +typedef struct arch_shared_info arch_shared_info_t; + +typedef uint64_t xen_callback_t; + + +/* Maximum number of virtual CPUs in legacy multi-processor guests. */ +/* Only one. All other VCPUS must use VCPUOP_register_vcpu_info */ +#define XEN_LEGACY_MAX_VCPUS 1 + +/* Current supported guest VCPUs */ +#define GUEST_MAX_VCPUS 128 + +#endif /* __ASSEMBLY__ */ + +#ifndef __ASSEMBLY__ +/* Stub definition of PMU structure */ +typedef struct xen_pmu_arch { uint8_t dummy; } xen_pmu_arch_t; +#endif + +#endif /* __XEN_PUBLIC_ARCH_RISCV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/public/arch-riscv/hvm/save.h b/xen/include/public/arch-riscv/hvm/save.h new file mode 100644 index 0000000000..fa010f0315 --- /dev/null +++ b/xen/include/public/arch-riscv/hvm/save.h @@ -0,0 +1,39 @@ +/* + * Structure definitions for HVM state that is held by Xen and must + * be saved along with the domain's memory and device-model state. + * + * Copyright (c) 2012 Citrix Systems Ltd. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */ + +#ifndef __XEN_PUBLIC_HVM_SAVE_RISCV_H__ +#define __XEN_PUBLIC_HVM_SAVE_RISCV_H__ + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.h index bea5e9f50f..c0b245596a 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -106,6 +106,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); #include "../arch-x86/hvm/save.h" #elif defined(__arm__) || defined(__aarch64__) #include "../arch-arm/hvm/save.h" +#elif defined(__riscv) +#include "../arch-riscv/hvm/save.h" #else #error "unsupported architecture" #endif diff --git a/xen/include/public/io/protocols.h b/xen/include/public/io/protocols.h index 52b4de0f81..b4d71f86c8 100644 --- a/xen/include/public/io/protocols.h +++ b/xen/include/public/io/protocols.h @@ -28,6 +28,7 @@ #define XEN_IO_PROTO_ABI_X86_32 "x86_32-abi" #define XEN_IO_PROTO_ABI_X86_64 "x86_64-abi" #define XEN_IO_PROTO_ABI_ARM "arm-abi" +#define XEN_IO_PROTO_ABI_RISCV "riscv-abi" #if defined(__i386__) # define XEN_IO_PROTO_ABI_NATIVE XEN_IO_PROTO_ABI_X86_32 @@ -35,6 +36,8 @@ # define XEN_IO_PROTO_ABI_NATIVE XEN_IO_PROTO_ABI_X86_64 #elif defined(__arm__) || defined(__aarch64__) # define XEN_IO_PROTO_ABI_NATIVE XEN_IO_PROTO_ABI_ARM +#elif defined(__riscv) +# define XEN_IO_PROTO_ABI_NATIVE XEN_IO_PROTO_ABI_RISCV #else # error arch fixup needed here #endif diff --git a/xen/include/public/pmu.h b/xen/include/public/pmu.h index cc2fcf8816..3fb1bcd900 100644 --- a/xen/include/public/pmu.h +++ b/xen/include/public/pmu.h @@ -28,6 +28,8 @@ #include "arch-x86/pmu.h" #elif defined (__arm__) || defined (__aarch64__) #include "arch-arm.h" +#elif defined (__riscv) +#include "arch-riscv.h" #else #error "Unsupported architecture" #endif diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h index e373592c33..1d80b64ee0 100644 --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -33,6 +33,8 @@ #include "arch-x86/xen.h" #elif defined(__arm__) || defined (__aarch64__) #include "arch-arm.h" +#elif defined(__riscv) +#include "arch-riscv.h" #else #error "Unsupported architecture" #endif -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339127.563960 (Exim 4.92) (envelope-from ) id 1nvvzj-000179-DD; Tue, 31 May 2022 07:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339127.563960; Tue, 31 May 2022 07:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzj-00014Y-7F; Tue, 31 May 2022 07:08:47 +0000 Received: by outflank-mailman (input) for mailman id 339127; Tue, 31 May 2022 06:58:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvpa-00084L-JZ for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:58:18 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bc3c42a-e0af-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 08:58:16 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id f7-20020a1c3807000000b0039c1a10507fso610141wma.1 for ; Mon, 30 May 2022 23:58:16 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id v21-20020a05600c215500b003973e8a227dsm1188377wml.46.2022.05.30.23.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:58:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bc3c42a-e0af-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0IuOTzNajWjkErQtIzVGnkdUea8B4HWED9kLxo7gdNE=; b=PJoGbKMwFHUXF/+pd/1LfBrDZgS13kIj7TkZLhW5QJgQ4+GGsjdBJvtGs9r63D5P65 RErXTGQ9SSiBsNOlf8eTuOD/2lCotlZui+TOEZeRQlCoZ3mRleD3piZTbaooCTjnotw+ Lv2XIVUbkDrWAVfN3vd3+RKNnC7BMesVqlF7us7s3EJ88KIoMoElk8fOdgeZriyZixPK X+jvyCTua511DxOon+rrH/M2hIZ6BeUdQla4V+N4BoBr8pj4UJfYQZXxqqukfPdOOD5Y P5Gx/wrayLnm2CR18GSw2+p+PC1xHJk0InF8ttVJPIHnXKH5hL0SbbtamtjbUSmjfEzq fPlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0IuOTzNajWjkErQtIzVGnkdUea8B4HWED9kLxo7gdNE=; b=UWRuef1XAiPXH5h4n1osPrEmM6X/hfKFpURJFY9T71HmiMZ4Or4xXA+K+x+BjV9hJ8 nn8hGDuI6wHUjeJpxrl4ZhSqqCJ4aN2qUxuQTXW4/sAuEIU74uMD0XpTupodUb4LvI0u PGMucC+lwbbNsDio08TwKKLI+v6uwDdC4Rq9DHPE9xDIuBeNgaN5bYI+oLbXBWypXe6b O2rbBzUTVDgggPUVF88HmRwW8WXGva8BBLwvhmbGHbndEpduGrcZHsaUL9+o4JacTF3q mYL99hhRTCC6cwgPeeGgVNyEUWXICr034Pe7ZoMnbZnwQMKHbrAcAbMeVQ73Hva/wedo IQsQ== X-Gm-Message-State: AOAM533orcViQQVlnFAWeR0Nght9AAtuxm/3roliHVoUgAYQ/9ADMIMQ jgcGFagPw2V8KGgDidLlIZj3inlE9jg= X-Google-Smtp-Source: ABdhPJzk5zUmY+1vM9HrPeHZTtEvMeYI/zRWy08tuD3nf4SoJQsNqQfbdZXBSvErqtOFSx9ayWxoMw== X-Received: by 2002:a1c:6a14:0:b0:397:39c4:8ac2 with SMTP id f20-20020a1c6a14000000b0039739c48ac2mr22188609wmc.112.1653980295971; Mon, 30 May 2022 23:58:15 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis Subject: [RFC PATCH 4/6] xen/riscv: Add sbi.c, sbi.h Date: Tue, 31 May 2022 14:57:10 +0800 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Xie Xun --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/sbi.h | 275 ++++++++++++++++++ xen/arch/riscv/sbi.c | 483 +++++++++++++++++++++++++++++++ 3 files changed, 759 insertions(+) create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/sbi.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 3a57556631..c61349818f 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -8,6 +8,7 @@ obj-y += irq.o obj-y += p2m.o obj-y += mm.o obj-y += percpu.o +obj-y += sbi.o obj-y += setup.o obj-y += shutdown.o obj-y += smp.o diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h new file mode 100644 index 0000000000..eb727f1a5e --- /dev/null +++ b/xen/arch/riscv/include/asm/sbi.h @@ -0,0 +1,275 @@ +/** + * Copyright (c) 2021 Vates SAS. + * + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Taken/modified from Xvisor project with the following copyright: + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + */ + +#ifndef __CPU_SBI_H__ +#define __CPU_SBI_H__ + +#include + +/* SBI Extension IDs */ +#define SBI_EXT_0_1_SET_TIMER 0x0 +#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1 +#define SBI_EXT_0_1_CONSOLE_GETCHAR 0x2 +#define SBI_EXT_0_1_CLEAR_IPI 0x3 +#define SBI_EXT_0_1_SEND_IPI 0x4 +#define SBI_EXT_0_1_REMOTE_FENCE_I 0x5 +#define SBI_EXT_0_1_REMOTE_SFENCE_VMA 0x6 +#define SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID 0x7 +#define SBI_EXT_0_1_SHUTDOWN 0x8 +#define SBI_EXT_BASE 0x10 +#define SBI_EXT_TIME 0x54494D45 +#define SBI_EXT_IPI 0x735049 +#define SBI_EXT_RFENCE 0x52464E43 + +/* SBI function IDs for BASE extension */ +#define SBI_EXT_BASE_GET_SPEC_VERSION 0x0 +#define SBI_EXT_BASE_GET_IMP_ID 0x1 +#define SBI_EXT_BASE_GET_IMP_VERSION 0x2 +#define SBI_EXT_BASE_PROBE_EXT 0x3 +#define SBI_EXT_BASE_GET_MVENDORID 0x4 +#define SBI_EXT_BASE_GET_MARCHID 0x5 +#define SBI_EXT_BASE_GET_MIMPID 0x6 + +#define SBI_SPEC_VERSION_MAJOR_SHIFT 24 +#define SBI_SPEC_VERSION_MAJOR_MASK 0x7f +#define SBI_SPEC_VERSION_MINOR_MASK 0xffffff + +/* SBI function IDs for TIME extension */ +#define SBI_EXT_TIME_SET_TIMER 0x0 + +/* SBI function IDs for IPI extension */ +#define SBI_EXT_IPI_SEND_IPI 0x0 + +/* SBI function IDs for RFENCE extension */ +#define SBI_EXT_RFENCE_REMOTE_FENCE_I 0x0 +#define SBI_EXT_RFENCE_REMOTE_SFENCE_VMA 0x1 +#define SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID 0x2 +#define SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA 0x3 +#define SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID 0x4 +#define SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA 0x5 +#define SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID 0x6 + +#define SBI_EXT_VENDOR_START 0x09000000 +#define SBI_EXT_VENDOR_END 0x09FFFFFF + +/* SBI return error codes */ +#define SBI_SUCCESS 0 +#define SBI_ERR_FAILURE -1 +#define SBI_ERR_NOT_SUPPORTED -2 +#define SBI_ERR_INVALID_PARAM -3 +#define SBI_ERR_DENIED -4 +#define SBI_ERR_INVALID_ADDRESS -5 + +#define SBI_SPEC_VERSION_DEFAULT 0x1 + +struct cpumask; + +struct sbiret { + long error; + long value; +}; + +struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5); + +/** + * Convert SBI spec error code into Xvisor error code + * + * @return errno error code + */ +int sbi_err_map_xvisor_errno(int err); + +/** + * Convert logical CPU mask to hardware HART mask + * + * @param cmask input logical CPU mask + * @param hmask output hardware HART mask + */ +void sbi_cpumask_to_hartmask(const struct cpumask *cmask, + struct cpumask *hmask); + +/** + * Writes given character to the console device. + * + * @param ch The data to be written to the console. + */ +void sbi_console_putchar(int ch); + +/** + * Reads a character from console device. + * + * @return the character read from console + */ +int sbi_console_getchar(void); + +/** + * Remove all the harts from executing supervisor code. + */ +void sbi_shutdown(void); + +/** + * Clear any pending IPIs for the calling HART. + */ +void sbi_clear_ipi(void); + +/** + * Send IPIs to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + */ +void sbi_send_ipi(const unsigned long *hart_mask); + +/** + * Program the timer for next timer event. + * + * @param stime_value Timer value after which next timer event should fire. + */ +void sbi_set_timer(u64 stime_value); + +/** + * Send FENCE_I to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + */ +void sbi_remote_fence_i(const unsigned long *hart_mask); + +/** + * Send SFENCE_VMA to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start virtual address start + * @param size virtual address size + */ +void sbi_remote_sfence_vma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size); + +/** + * Send SFENCE_VMA_ASID to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start virtual address start + * @param size virtual address size + * @param asid address space ID + */ +void sbi_remote_sfence_vma_asid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long asid); + +/** + * Send HFENCE_GVMA to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start guest physical address start + * @param size guest physical address size + */ +void sbi_remote_hfence_gvma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size); + +/** + * Send HFENCE_GVMA_VMID to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start guest physical address start + * @param size guest physical address size + * @param vmid virtual machine ID + */ +void sbi_remote_hfence_gvma_vmid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long vmid); + +/** + * Send HFENCE_VVMA to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start virtual address start + * @param size virtual address size + */ +void sbi_remote_hfence_vvma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size); + +/** + * Send HFENCE_VVMA_ASID to a set of target HARTs. + * + * @param hart_mask mask representing set of target HARTs + * @param start virtual address start + * @param size virtual address size + * @param asid address space ID + */ +void sbi_remote_hfence_vvma_asid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long asid); + +/** + * Check given SBI extension is supported or not. + * + * @param ext extension ID + * @return >= 0 for supported AND -EOPNOTSUPP for not-supported + */ +int sbi_probe_extension(long ext); + +/** + * Check underlying SBI implementation is v0.1 only + * + * @return 1 for SBI v0.1 AND 0 for higer version + */ +int sbi_spec_is_0_1(void); + +/** + * Check underlying SBI implementation has v0.2 RFENCE + * + * @return 1 for supported AND 0 for not-supported + */ +int sbi_has_0_2_rfence(void); + +/** + * Get SBI spec major version + * + * @return major version number + */ +unsigned long sbi_major_version(void); + +/** + * Get SBI spec minor version + * + * @return minor version number + */ +unsigned long sbi_minor_version(void); + +/** + * Initialize SBI library + * + * @return 0 on success, otherwise negative errno on failure + */ +int sbi_init(void); + +#endif // __CPU_SBI_H__ diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c new file mode 100644 index 0000000000..be5f337a88 --- /dev/null +++ b/xen/arch/riscv/sbi.c @@ -0,0 +1,483 @@ +/** + * Taken and modified from the xvisor project with the copyright Copyright (c) + * 2019 Western Digital Corporation or its affiliates and author Anup Patel + * (anup.patel@wdc.com). + * + * Modified by Bobby Eshleman (bobby.eshleman@gmail.com). + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * Copyright (c) 2021 Vates SAS. + * All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + */ + +#include +#include +#include + +#include +#include + +static unsigned long sbi_spec_version = SBI_SPEC_VERSION_DEFAULT; + +struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, + unsigned long arg1, unsigned long arg2, + unsigned long arg3, unsigned long arg4, + unsigned long arg5) +{ + struct sbiret ret; + + register unsigned long a0 asm ("a0") = (unsigned long)(arg0); + register unsigned long a1 asm ("a1") = (unsigned long)(arg1); + register unsigned long a2 asm ("a2") = (unsigned long)(arg2); + register unsigned long a3 asm ("a3") = (unsigned long)(arg3); + register unsigned long a4 asm ("a4") = (unsigned long)(arg4); + register unsigned long a5 asm ("a5") = (unsigned long)(arg5); + register unsigned long a6 asm ("a6") = (unsigned long)(fid); + register unsigned long a7 asm ("a7") = (unsigned long)(ext); + asm volatile ("ecall" + : "+r" (a0), "+r" (a1) + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7) + : "memory"); + ret.error = a0; + ret.value = a1; + + return ret; +} + +int sbi_err_map_xen_errno(int err) +{ + switch (err) { + case SBI_SUCCESS: + return 0; + case SBI_ERR_DENIED: + return -EACCES; + case SBI_ERR_INVALID_PARAM: + return -EINVAL; + case SBI_ERR_INVALID_ADDRESS: + return -EFAULT; + case SBI_ERR_NOT_SUPPORTED: + case SBI_ERR_FAILURE: + default: + return -EOPNOTSUPP; + }; +} + +void sbi_cpumask_to_hartmask(const struct cpumask *cmask, + struct cpumask *hmask) +{ + u32 cpu; + unsigned long hart; + + if (!cmask || !hmask) + return; + + cpumask_clear(hmask); + for_each_cpu(cpu, cmask) { + if (CONFIG_NR_CPUS <= cpu) { + printk(XENLOG_ERR "SBI: invalid hart=%lu for cpu=%d\n", + hart, cpu); + continue; + } + hart = pcpu_info[cpu].processor_id; + cpumask_set_cpu(hart, hmask); + } +} + +void sbi_console_putchar(int ch) +{ + sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0); +} + +int sbi_console_getchar(void) +{ + struct sbiret ret; + + ret = sbi_ecall(SBI_EXT_0_1_CONSOLE_GETCHAR, 0, 0, 0, 0, 0, 0, 0); + + return ret.error; +} + +void sbi_shutdown(void) +{ + sbi_ecall(SBI_EXT_0_1_SHUTDOWN, 0, 0, 0, 0, 0, 0, 0); +} + +void sbi_clear_ipi(void) +{ + sbi_ecall(SBI_EXT_0_1_CLEAR_IPI, 0, 0, 0, 0, 0, 0, 0); +} + +static int __sbi_send_ipi_v01(const unsigned long *hart_mask) +{ + sbi_ecall(SBI_EXT_0_1_SEND_IPI, 0, + (unsigned long)hart_mask, 0, 0, 0, 0, 0); + return 0; +} + +static void __sbi_set_timer_v01(u64 stime_value) +{ +#ifdef CONFIG_RISCV_64 + sbi_ecall(SBI_EXT_0_1_SET_TIMER, 0, stime_value, 0, 0, 0, 0, 0); +#else + sbi_ecall(SBI_EXT_0_1_SET_TIMER, 0, stime_value, + stime_value >> 32, 0, 0, 0, 0); +#endif +} + +static int __sbi_rfence_v01(unsigned long fid, + const unsigned long *hart_mask, + unsigned long start, unsigned long size, + unsigned long arg4, unsigned long arg5) +{ + int result = 0; + + switch (fid) { + case SBI_EXT_RFENCE_REMOTE_FENCE_I: + sbi_ecall(SBI_EXT_0_1_REMOTE_FENCE_I, 0, + (unsigned long)hart_mask, 0, 0, 0, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA: + sbi_ecall(SBI_EXT_0_1_REMOTE_SFENCE_VMA, 0, + (unsigned long)hart_mask, start, size, + 0, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID: + sbi_ecall(SBI_EXT_0_1_REMOTE_SFENCE_VMA_ASID, 0, + (unsigned long)hart_mask, start, size, + arg4, 0, 0); + break; + default: + printk("%s: unknown function ID [%lu]\n", __func__, fid); + result = -EINVAL; + break; + }; + + return result; +} + +static void __sbi_set_timer_v02(u64 stime_value) +{ +#ifdef CONFIG_RISCV_64 + sbi_ecall(SBI_EXT_TIME, SBI_EXT_TIME_SET_TIMER, stime_value, 0, + 0, 0, 0, 0); +#else + sbi_ecall(SBI_EXT_TIME, SBI_EXT_TIME_SET_TIMER, stime_value, + stime_value >> 32, 0, 0, 0, 0); +#endif +} + +static int __sbi_send_ipi_v02(const unsigned long *hart_mask) +{ + struct cpumask tmask; + unsigned long hart, hmask, hbase; + struct sbiret ret = {0}; + int result; + + if (!hart_mask) { + sbi_cpumask_to_hartmask(&cpu_online_map, &tmask); + hart_mask = cpumask_bits(&tmask); + } + + hmask = hbase = 0; + for_each_set_bit(hart, hart_mask, CONFIG_NR_CPUS) { + if (hmask && ((hbase + BITS_PER_LONG) <= hart)) { + ret = sbi_ecall(SBI_EXT_IPI, SBI_EXT_IPI_SEND_IPI, + hmask, hbase, 0, 0, 0, 0); + if (ret.error) { + result = sbi_err_map_xen_errno(ret.error); + printk("%s: hmask=0x%lx hbase=%lu failed " + "(error %d)\n", __func__, hmask, + hbase, result); + return result; + } + hmask = hbase = 0; + } + if (!hmask) { + hbase = hart; + } + hmask |= 1UL << (hart - hbase); + } + if (hmask) { + ret = sbi_ecall(SBI_EXT_IPI, SBI_EXT_IPI_SEND_IPI, + hmask, hbase, 0, 0, 0, 0); + if (ret.error) { + result = sbi_err_map_xen_errno(ret.error); + printk("%s: hmask=0x%lx hbase=%lu failed " + "(error %d)\n", __func__, hmask, + hbase, result); + return result; + } + } + + return 0; +} + +static int __sbi_rfence_v02_real(unsigned long fid, + unsigned long hmask, unsigned long hbase, + unsigned long start, unsigned long size, + unsigned long arg4) +{ + struct sbiret ret = {0}; + int result = 0; + + switch (fid) { + case SBI_EXT_RFENCE_REMOTE_FENCE_I: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + 0, 0, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, arg4, 0); + break; + case SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, arg4, 0); + break; + case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, 0, 0); + break; + case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID: + ret = sbi_ecall(SBI_EXT_RFENCE, fid, hmask, hbase, + start, size, arg4, 0); + break; + default: + printk("%s: unknown function ID [%lu]\n", + __func__, fid); + result = -EINVAL; + break; + }; + + if (ret.error) { + result = sbi_err_map_xen_errno(ret.error); + printk("%s: hbase=%lu hmask=0x%lx failed (error %d)\n", + __func__, hbase, hmask, result); + } + + return result; +} + +static int __sbi_rfence_v02(unsigned long fid, + const unsigned long *hart_mask, + unsigned long start, unsigned long size, + unsigned long arg4, unsigned long arg5) +{ + struct cpumask tmask; + unsigned long hart, hmask, hbase; + int result; + + if (!hart_mask) { + sbi_cpumask_to_hartmask(&cpu_online_map, &tmask); + hart_mask = cpumask_bits(&tmask); + } + + hmask = hbase = 0; + for_each_set_bit(hart, hart_mask, CONFIG_NR_CPUS) { + if (hmask && ((hbase + BITS_PER_LONG) <= hart)) { + result = __sbi_rfence_v02_real(fid, hmask, hbase, + start, size, arg4); + if (result) + return result; + hmask = hbase = 0; + } + if (!hmask) { + hbase = hart; + } + hmask |= 1UL << (hart - hbase); + } + if (hmask) { + result = __sbi_rfence_v02_real(fid, hmask, hbase, + start, size, arg4); + if (result) + return result; + } + + return 0; +} + +static void (*__sbi_set_timer)(u64 stime) = __sbi_set_timer_v01; +static int (*__sbi_send_ipi)(const unsigned long *hart_mask) = + __sbi_send_ipi_v01; +static int (*__sbi_rfence)(unsigned long fid, + const unsigned long *hart_mask, + unsigned long start, unsigned long size, + unsigned long arg4, unsigned long arg5) = __sbi_rfence_v01; + +void sbi_send_ipi(const unsigned long *hart_mask) +{ + __sbi_send_ipi(hart_mask); +} + +void sbi_set_timer(u64 stime_value) +{ + __sbi_set_timer(stime_value); +} + +void sbi_remote_fence_i(const unsigned long *hart_mask) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_FENCE_I, + hart_mask, 0, 0, 0, 0); +} + +void sbi_remote_sfence_vma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_SFENCE_VMA, + hart_mask, start, size, 0, 0); +} + +void sbi_remote_sfence_vma_asid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long asid) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_SFENCE_VMA_ASID, + hart_mask, start, size, asid, 0); +} + +void sbi_remote_hfence_gvma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA, + hart_mask, start, size, 0, 0); +} + +void sbi_remote_hfence_gvma_vmid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long vmid) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID, + hart_mask, start, size, vmid, 0); +} + +void sbi_remote_hfence_vvma(const unsigned long *hart_mask, + unsigned long start, + unsigned long size) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA, + hart_mask, start, size, 0, 0); +} + +void sbi_remote_hfence_vvma_asid(const unsigned long *hart_mask, + unsigned long start, + unsigned long size, + unsigned long asid) +{ + __sbi_rfence(SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID, + hart_mask, start, size, asid, 0); +} + +static long sbi_ext_base_func(long fid) +{ + struct sbiret ret; + + ret = sbi_ecall(SBI_EXT_BASE, fid, 0, 0, 0, 0, 0, 0); + if (!ret.error) + return ret.value; + else + return ret.error; +} + +#define sbi_get_spec_version() \ + sbi_ext_base_func(SBI_EXT_BASE_GET_SPEC_VERSION) + +#define sbi_get_firmware_id() \ + sbi_ext_base_func(SBI_EXT_BASE_GET_IMP_ID) + +#define sbi_get_firmware_version() \ + sbi_ext_base_func(SBI_EXT_BASE_GET_IMP_VERSION) + +int sbi_probe_extension(long extid) +{ + struct sbiret ret; + + ret = sbi_ecall(SBI_EXT_BASE, SBI_EXT_BASE_PROBE_EXT, extid, + 0, 0, 0, 0, 0); + if (!ret.error && ret.value) + return ret.value; + + return -EOPNOTSUPP; +} + +int sbi_spec_is_0_1(void) +{ + return (sbi_spec_version == SBI_SPEC_VERSION_DEFAULT) ? 1 : 0; +} + +int sbi_has_0_2_rfence(void) +{ + return (__sbi_rfence == __sbi_rfence_v01) ? 0 : 1; +} + +unsigned long sbi_major_version(void) +{ + return (sbi_spec_version >> SBI_SPEC_VERSION_MAJOR_SHIFT) & + SBI_SPEC_VERSION_MAJOR_MASK; +} + +unsigned long sbi_minor_version(void) +{ + return sbi_spec_version & SBI_SPEC_VERSION_MINOR_MASK; +} + +int __init sbi_init(void) +{ + int ret; + + ret = sbi_get_spec_version(); + if (ret > 0) + sbi_spec_version = ret; + + printk("SBI specification v%lu.%lu detected\n", + sbi_major_version(), sbi_minor_version()); + + if (!sbi_spec_is_0_1()) { + printk("SBI implementation ID=0x%lx Version=0x%lx\n", + sbi_get_firmware_id(), sbi_get_firmware_version()); + if (sbi_probe_extension(SBI_EXT_TIME) > 0) { + __sbi_set_timer = __sbi_set_timer_v02; + printk("SBI v0.2 TIME extension detected\n"); + } + if (sbi_probe_extension(SBI_EXT_IPI) > 0) { + __sbi_send_ipi = __sbi_send_ipi_v02; + printk("SBI v0.2 IPI extension detected\n"); + } + if (sbi_probe_extension(SBI_EXT_RFENCE) > 0) { + __sbi_rfence = __sbi_rfence_v02; + printk("SBI v0.2 RFENCE extension detected\n"); + } + } + + if (!sbi_has_0_2_rfence()) { + printk("WARNING: SBI v0.2 RFENCE not available !\n"); + } + + return 0; +} + +__initcall(sbi_init); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339119.563936 (Exim 4.92) (envelope-from ) id 1nvvzh-0000gA-U9; Tue, 31 May 2022 07:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339119.563936; Tue, 31 May 2022 07:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzh-0000g3-RD; Tue, 31 May 2022 07:08:45 +0000 Received: by outflank-mailman (input) for mailman id 339119; Tue, 31 May 2022 06:57:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvoj-0007zl-9G for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:57:25 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8c71bdf-e0ae-11ec-837f-e5687231ffcc; Tue, 31 May 2022 08:57:17 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id t13so17293977wrg.9 for ; Mon, 30 May 2022 23:57:22 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id n1-20020adfe341000000b0020e68dd2598sm10560448wrj.97.2022.05.30.23.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:57:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8c71bdf-e0ae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c0bMw9AJl7TeQCQj406kPF3Bu90A+j+TU6LdtIz6Az0=; b=Vsq7qAY0e3aDExFl4jXCTLXFiB0qDqvkz3reOxmcg3bJLmI0js2GukBlY3ZXncaOOM hcPiFXtzrDtV0213wwLX5MeemxJ0ZCxIHg7oBogJeZ+TxFI3twbxI+mW4sFQwXbsHX4U j3yew6/4Fq4HoGAVVj0e3BV5M+oursZvro68FM6wbkLo6767vJ9Yamk+HHfS10hLs40t Dy/j66TbiAw8gtI4g2NaGcXKxVcnopJ8oM+IaERO0u8q4QzyZ/pxyN5TD53b3jGx0FTd kkl8L1hSPe9G9S5XJV5QmYwHjnSMN4tf/wXmJNyoYxzqhEDvaifVYc8klej/74JUHtH6 fKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c0bMw9AJl7TeQCQj406kPF3Bu90A+j+TU6LdtIz6Az0=; b=KqSDXq3jdV/C6MPPcywmL3mJa0B2snQvOmWyRaFyQT24yoDRPa7IJ2fFshYw2WbL94 an3UfS94T0EF8oS1R4vIzunqXvm5cMOtzg6CRMg6deDha9taZYTZEvciLRpU9zYMsir1 O7CeNoBu1aVlFESrGzqjAudUohDH93YGwGoaGbi/+6eJtOqzfHaC0AynaamQEPJjs+05 WoxVIGSbM55f1RwPs7RVmQdnWCZdDt3mCbsR2fj9Xdsh8omet/bBwOxD8bXSijQ2hivb tfhuPGCwIg/mWlylJnRgdkIZXEcf9VUvEnEVvLkHcuPzNXnZfFj8v8MESNd4PLF42D2S CfDA== X-Gm-Message-State: AOAM533oQAS7XrEmcrkwmTsYfxpliboRhYY07v5ZzBjrSr6tD7KuO26i lLOUfdllhS3ProseVW3/pc7loB6woerJzQ== X-Google-Smtp-Source: ABdhPJzMQwNXXt38e3xEdAE/qGE5Qqp7Dx/onDpLZUii6xIw5i8FYV3hsvLz7w9QNLOpBxr8UCPWCw== X-Received: by 2002:a05:6000:344:b0:210:2a22:9ca4 with SMTP id e4-20020a056000034400b002102a229ca4mr11155744wre.276.1653980241992; Mon, 30 May 2022 23:57:21 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Juergen Gross Subject: [RFC PATCH 0/6] xen/riscv: Add necessary files for RISC-V Xen build. Date: Tue, 31 May 2022 14:57:06 +0800 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello everyone, My name is Xie Xun and I am a graduate student in computer science. I spend some time porting Xen to RISV-V based on Bobby's work. Now Xen can use device tree to initialize memory and load guest kernel. Timer interrupt is also enabled for both xen and guest kernel. This patch series is the first part of the work. It only adds necessary files for a successful xen build. The only thing xen will do is printing a message. There are some problems though. The first patch of this series is very large, but it seems most of the code is necessary for building xen. I am trying my best to remove some code but it still has more than 8000 lines of code. Looking forward to your feedback. Xen can be built with: $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- tiny64_defconfig $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- Run with Qemu: $ qemu-system-riscv64 -machine virt -m 1G -kernel xen Bobby and Alistair's patch: https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg01731.html This patch series is based on Bobby's Repo: https://gitlab.com/xen-on-risc-v/xen/-/tree/riscv-rebase This patch series is available in: https://github.com/xiexun162534/xen/tree/riscv-patch My latest work: https://github.com/xiexun162534/xen/tree/riscv-port Xie Xun (6): xen/riscv: Add necessary headers and definitions to build xen. xen/riscv: Add early page table setup code. xen/riscv: Add head.S xen/riscv: Add sbi.c, sbi.h xen/riscv: Add early_printk xen/riscv: Print "xen start" in start_xen using early_printk. xen/arch/riscv/Kconfig | 2 + xen/arch/riscv/Makefile | 53 ++ xen/arch/riscv/Rules.mk | 57 ++ xen/arch/riscv/delay.c | 14 + xen/arch/riscv/domain.c | 191 ++++ xen/arch/riscv/domctl.c | 52 ++ xen/arch/riscv/early_printk.c | 48 + xen/arch/riscv/guestcopy.c | 59 ++ xen/arch/riscv/include/asm/acpi.h | 9 + xen/arch/riscv/include/asm/altp2m.h | 39 + xen/arch/riscv/include/asm/asm.h | 76 ++ xen/arch/riscv/include/asm/atomic.h | 375 ++++++++ xen/arch/riscv/include/asm/bitops.h | 397 ++++++++ xen/arch/riscv/include/asm/bug.h | 67 ++ xen/arch/riscv/include/asm/byteorder.h | 16 + xen/arch/riscv/include/asm/cache.h | 24 + xen/arch/riscv/include/asm/cmpxchg.h | 382 ++++++++ xen/arch/riscv/include/asm/config.h | 149 ++- xen/arch/riscv/include/asm/cpufeature.h | 68 ++ xen/arch/riscv/include/asm/csr.h | 81 ++ xen/arch/riscv/include/asm/current.h | 41 + xen/arch/riscv/include/asm/debugger.h | 15 + xen/arch/riscv/include/asm/delay.h | 28 + xen/arch/riscv/include/asm/desc.h | 12 + xen/arch/riscv/include/asm/device.h | 93 ++ xen/arch/riscv/include/asm/div64.h | 23 + xen/arch/riscv/include/asm/domain.h | 80 ++ xen/arch/riscv/include/asm/early_printk.h | 10 + xen/arch/riscv/include/asm/event.h | 42 + xen/arch/riscv/include/asm/fence.h | 12 + xen/arch/riscv/include/asm/flushtlb.h | 56 ++ xen/arch/riscv/include/asm/grant_table.h | 93 ++ xen/arch/riscv/include/asm/guest_access.h | 125 +++ xen/arch/riscv/include/asm/guest_atomics.h | 62 ++ xen/arch/riscv/include/asm/hardirq.h | 27 + xen/arch/riscv/include/asm/hypercall.h | 12 + xen/arch/riscv/include/asm/init.h | 42 + xen/arch/riscv/include/asm/io.h | 283 ++++++ xen/arch/riscv/include/asm/iocap.h | 16 + xen/arch/riscv/include/asm/iommu.h | 46 + xen/arch/riscv/include/asm/iommu_fwspec.h | 68 ++ xen/arch/riscv/include/asm/irq.h | 62 ++ xen/arch/riscv/include/asm/mem_access.h | 35 + xen/arch/riscv/include/asm/mm.h | 320 +++++++ xen/arch/riscv/include/asm/monitor.h | 65 ++ xen/arch/riscv/include/asm/nospec.h | 25 + xen/arch/riscv/include/asm/numa.h | 41 + xen/arch/riscv/include/asm/p2m.h | 307 +++++++ xen/arch/riscv/include/asm/page-bits.h | 14 + xen/arch/riscv/include/asm/page.h | 319 +++++++ xen/arch/riscv/include/asm/paging.h | 16 + xen/arch/riscv/include/asm/pci.h | 31 + xen/arch/riscv/include/asm/percpu.h | 35 + xen/arch/riscv/include/asm/processor.h | 176 ++++ xen/arch/riscv/include/asm/random.h | 9 + xen/arch/riscv/include/asm/regs.h | 42 + xen/arch/riscv/include/asm/riscv_encoding.h | 960 ++++++++++++++++++++ xen/arch/riscv/include/asm/sbi.h | 275 ++++++ xen/arch/riscv/include/asm/setup.h | 23 + xen/arch/riscv/include/asm/smp.h | 69 ++ xen/arch/riscv/include/asm/softirq.h | 16 + xen/arch/riscv/include/asm/spinlock.h | 13 + xen/arch/riscv/include/asm/string.h | 28 + xen/arch/riscv/include/asm/system.h | 98 ++ xen/arch/riscv/include/asm/time.h | 81 ++ xen/arch/riscv/include/asm/trace.h | 12 + xen/arch/riscv/include/asm/traps.h | 30 + xen/arch/riscv/include/asm/types.h | 73 ++ xen/arch/riscv/include/asm/vm_event.h | 63 ++ xen/arch/riscv/include/asm/xenoprof.h | 12 + xen/arch/riscv/irq.c | 126 +++ xen/arch/riscv/lib/Makefile | 1 + xen/arch/riscv/lib/find_next_bit.c | 285 ++++++ xen/arch/riscv/mm.c | 633 +++++++++++++ xen/arch/riscv/p2m.c | 97 ++ xen/arch/riscv/percpu.c | 84 ++ xen/arch/riscv/platforms/Kconfig | 31 + xen/arch/riscv/riscv64/Makefile | 2 +- xen/arch/riscv/riscv64/asm-offsets.c | 39 + xen/arch/riscv/riscv64/head.S | 219 ++++- xen/arch/riscv/sbi.c | 483 ++++++++++ xen/arch/riscv/setup.c | 67 ++ xen/arch/riscv/shutdown.c | 24 + xen/arch/riscv/smp.c | 38 + xen/arch/riscv/smpboot.c | 78 ++ xen/arch/riscv/sysctl.c | 31 + xen/arch/riscv/time.c | 69 ++ xen/arch/riscv/traps.c | 87 ++ xen/arch/riscv/vm_event.c | 51 ++ xen/arch/riscv/xen.lds.S | 274 ++++++ xen/include/public/arch-riscv.h | 182 ++++ xen/include/public/arch-riscv/hvm/save.h | 39 + xen/include/public/hvm/save.h | 2 + xen/include/public/io/protocols.h | 3 + xen/include/public/pmu.h | 2 + xen/include/public/xen.h | 2 + 96 files changed, 9536 insertions(+), 8 deletions(-) create mode 100644 xen/arch/riscv/delay.c create mode 100644 xen/arch/riscv/domain.c create mode 100644 xen/arch/riscv/domctl.c create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/guestcopy.c create mode 100644 xen/arch/riscv/include/asm/acpi.h create mode 100644 xen/arch/riscv/include/asm/altp2m.h create mode 100644 xen/arch/riscv/include/asm/asm.h create mode 100644 xen/arch/riscv/include/asm/atomic.h create mode 100644 xen/arch/riscv/include/asm/bitops.h create mode 100644 xen/arch/riscv/include/asm/bug.h create mode 100644 xen/arch/riscv/include/asm/byteorder.h create mode 100644 xen/arch/riscv/include/asm/cache.h create mode 100644 xen/arch/riscv/include/asm/cmpxchg.h create mode 100644 xen/arch/riscv/include/asm/cpufeature.h create mode 100644 xen/arch/riscv/include/asm/csr.h create mode 100644 xen/arch/riscv/include/asm/current.h create mode 100644 xen/arch/riscv/include/asm/debugger.h create mode 100644 xen/arch/riscv/include/asm/delay.h create mode 100644 xen/arch/riscv/include/asm/desc.h create mode 100644 xen/arch/riscv/include/asm/device.h create mode 100644 xen/arch/riscv/include/asm/div64.h create mode 100644 xen/arch/riscv/include/asm/domain.h create mode 100644 xen/arch/riscv/include/asm/early_printk.h create mode 100644 xen/arch/riscv/include/asm/event.h create mode 100644 xen/arch/riscv/include/asm/fence.h create mode 100644 xen/arch/riscv/include/asm/flushtlb.h create mode 100644 xen/arch/riscv/include/asm/grant_table.h create mode 100644 xen/arch/riscv/include/asm/guest_access.h create mode 100644 xen/arch/riscv/include/asm/guest_atomics.h create mode 100644 xen/arch/riscv/include/asm/hardirq.h create mode 100644 xen/arch/riscv/include/asm/hypercall.h create mode 100644 xen/arch/riscv/include/asm/init.h create mode 100644 xen/arch/riscv/include/asm/io.h create mode 100644 xen/arch/riscv/include/asm/iocap.h create mode 100644 xen/arch/riscv/include/asm/iommu.h create mode 100644 xen/arch/riscv/include/asm/iommu_fwspec.h create mode 100644 xen/arch/riscv/include/asm/irq.h create mode 100644 xen/arch/riscv/include/asm/mem_access.h create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/monitor.h create mode 100644 xen/arch/riscv/include/asm/nospec.h create mode 100644 xen/arch/riscv/include/asm/numa.h create mode 100644 xen/arch/riscv/include/asm/p2m.h create mode 100644 xen/arch/riscv/include/asm/page-bits.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/include/asm/paging.h create mode 100644 xen/arch/riscv/include/asm/pci.h create mode 100644 xen/arch/riscv/include/asm/percpu.h create mode 100644 xen/arch/riscv/include/asm/processor.h create mode 100644 xen/arch/riscv/include/asm/random.h create mode 100644 xen/arch/riscv/include/asm/regs.h create mode 100644 xen/arch/riscv/include/asm/riscv_encoding.h create mode 100644 xen/arch/riscv/include/asm/sbi.h create mode 100644 xen/arch/riscv/include/asm/setup.h create mode 100644 xen/arch/riscv/include/asm/smp.h create mode 100644 xen/arch/riscv/include/asm/softirq.h create mode 100644 xen/arch/riscv/include/asm/spinlock.h create mode 100644 xen/arch/riscv/include/asm/string.h create mode 100644 xen/arch/riscv/include/asm/system.h create mode 100644 xen/arch/riscv/include/asm/time.h create mode 100644 xen/arch/riscv/include/asm/trace.h create mode 100644 xen/arch/riscv/include/asm/traps.h create mode 100644 xen/arch/riscv/include/asm/types.h create mode 100644 xen/arch/riscv/include/asm/vm_event.h create mode 100644 xen/arch/riscv/include/asm/xenoprof.h create mode 100644 xen/arch/riscv/irq.c create mode 100644 xen/arch/riscv/lib/Makefile create mode 100644 xen/arch/riscv/lib/find_next_bit.c create mode 100644 xen/arch/riscv/mm.c create mode 100644 xen/arch/riscv/p2m.c create mode 100644 xen/arch/riscv/percpu.c create mode 100644 xen/arch/riscv/platforms/Kconfig create mode 100644 xen/arch/riscv/sbi.c create mode 100644 xen/arch/riscv/setup.c create mode 100644 xen/arch/riscv/shutdown.c create mode 100644 xen/arch/riscv/smp.c create mode 100644 xen/arch/riscv/smpboot.c create mode 100644 xen/arch/riscv/sysctl.c create mode 100644 xen/arch/riscv/time.c create mode 100644 xen/arch/riscv/traps.c create mode 100644 xen/arch/riscv/vm_event.c create mode 100644 xen/arch/riscv/xen.lds.S create mode 100644 xen/include/public/arch-riscv.h create mode 100644 xen/include/public/arch-riscv/hvm/save.h -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339122.563948 (Exim 4.92) (envelope-from ) id 1nvvzi-0000qs-IN; Tue, 31 May 2022 07:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339122.563948; Tue, 31 May 2022 07:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzi-0000qB-Eo; Tue, 31 May 2022 07:08:46 +0000 Received: by outflank-mailman (input) for mailman id 339122; Tue, 31 May 2022 06:57:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvpG-00080v-8j for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:57:58 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcff5801-e0ae-11ec-837f-e5687231ffcc; Tue, 31 May 2022 08:57:51 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id s24so9970727wrb.10 for ; Mon, 30 May 2022 23:57:56 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id m19-20020a05600c4f5300b003942a244f2esm1322707wmq.7.2022.05.30.23.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:57:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcff5801-e0ae-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eX+ztoF4ccJF8k/eqM9yWtCts93a8EoroUDLXMjz3+c=; b=No8PvNxyNem0mBq0AAqZNlO/B8Sa7VmBm0BYQzDRGDwhGgIwH771G5tX8l1C199ZEF XgihrXOLf/x4+LJNXBNgQp0UCE7iRUHBvFA6Pn/c5iNneoNOldgvVlXbv5DzW41yDYuL zqugKijI3zr0lemPTJjMjgXh+yPKQTn8fZg7T+nbpfp3B2JTFgWLs/MYDuYDQvBo5QTv gd3SHk+UvldhL+oTLuBCTrIcUFBtpRtU86s+8IC3gsBaL9krAWU0DJNeA+5pNm8PtTnh +FHvN72N2C1MA3BuwKcKDdqfc/WGBpXOECn+qqIoFYO8s4E9WNqgVlOg3kvTGkH1M2rl FRhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eX+ztoF4ccJF8k/eqM9yWtCts93a8EoroUDLXMjz3+c=; b=2aFI5eYNxMFS58qINv1UF1UFoFN8VGhg9eVteMpuPcixMI1pcahTkgEvkIJXZQhN6l OvAVBef9hOYRFaYiKfq2tVdncN2oH8Sgi/Lp7r8IrxQkRalyO9ofxaZ+nOJSRiIR5l7Z jQKD33vwTWft4lIAJNCUWoEowhSyeoCpZhFNwMJh2Wq9VSqYvS02vXXkmQ+/VyfNNOJd ra8lca3Xdlg/avGObql1AFaYr5zs1waBoaFzv2oHyODQWOJjJpZ4Vj2qDflW0o0MGTgG I9xEJt9ixa2IdEevlpr40eP/qpfhMjWnIa63EUsJKGr07UzRkBeetorWkuHsdEFx58ms 39/Q== X-Gm-Message-State: AOAM532vVjlAL04z+eDcjwEn5gsNeGgLK7qj825sEtVMW4F3tBoj5phB JCjkxv1/y/Ay0AH6/DNc82I6TX5V/Vc= X-Google-Smtp-Source: ABdhPJwpu7/xA7yXAXr68E7aFhi7RWpGZld0Yat8+AE4OcjjJKMVLWopCdMwcFhHh0eKynSB3/zAiw== X-Received: by 2002:adf:f38f:0:b0:210:30cf:6e4a with SMTP id m15-20020adff38f000000b0021030cf6e4amr8560078wro.676.1653980275934; Mon, 30 May 2022 23:57:55 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis Subject: [RFC PATCH 2/6] xen/riscv: Add early page table setup code. Date: Tue, 31 May 2022 14:57:08 +0800 Message-Id: <94a7c66306c31113c808f2a33664ab84b09db4ec.1653977696.git.xiexun162534@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This code sets up initial page table. Signed-off-by: Xie Xun --- xen/arch/riscv/mm.c | 224 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 224 insertions(+) diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index f366b1ca0c..074a2a4396 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -81,6 +81,17 @@ unsigned long xenheap_base_pdx __read_mostly; unsigned long frametable_virt_end __read_mostly; unsigned long frametable_base_pdx; +/* + * xen_second_pagetable is indexed with the VPN[2] page table entry field + * xen_first_pagetable is accessed from the VPN[1] page table entry field + * xen_zeroeth_pagetable is accessed from the VPN[0] page table entry field + */ +pte_t xen_second_pagetable[PAGE_ENTRIES] __attribute__((__aligned__(4096))); +static pte_t xen_first_pagetable[PAGE_ENTRIES] + __attribute__((__aligned__(4096))); +static pte_t xen_zeroeth_pagetable[PAGE_ENTRIES] + __attribute__((__aligned__(4096))); + static pte_t xen_fixmap[PAGE_ENTRIES] __attribute__((__aligned__(4096))); #define THIS_CPU_PGTABLE xen_second_pagetable @@ -374,6 +385,219 @@ unsigned long get_upper_mfn_bound(void) return max_page - 1; } +/* Set up leaf pages in a first-level page table. */ +void setup_megapages(pte_t *first_pagetable, unsigned long virtual_start, + unsigned long physical_start, unsigned long page_cnt) +{ + unsigned long frame_addr = physical_start; + unsigned long end = physical_start + (page_cnt << PAGE_SHIFT); + unsigned long vaddr = virtual_start; + unsigned long index; + pte_t *p; + + BUG_ON(!IS_ALIGNED(physical_start, FIRST_SIZE)); + + while ( frame_addr < end ) + { + index = pagetable_first_index(vaddr); + p = &first_pagetable[index]; + p->pte = paddr_to_megapage_ppn(frame_addr); + p->pte |= PTE_LEAF_DEFAULT; + + frame_addr += FIRST_SIZE; + vaddr += FIRST_SIZE; + } +} + +#define resolve_early_addr(x) \ + ({ \ + unsigned long * __##x; \ + if ( load_addr_start <= x && x < load_addr_end ) \ + __##x = (unsigned long *)x; \ + else \ + __##x = (unsigned long *)(x + load_addr_start - linker_addr_start); \ + __##x; \ + }) + +void __init clear_pagetables(unsigned long load_addr_start, + unsigned long load_addr_end, + unsigned long linker_addr_start, + unsigned long linker_addr_end) +{ + unsigned long *p; + unsigned long page; + unsigned long i; + + page = (unsigned long)&xen_second_pagetable[0]; + + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_second_pagetable); i++ ) + { + p[i] = 0ULL; + } + + page = (unsigned long)&xen_first_pagetable[0]; + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_first_pagetable); i++ ) + { + p[i] = 0ULL; + } + + page = (unsigned long)&xen_zeroeth_pagetable[0]; + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_zeroeth_pagetable); i++ ) + { + p[i] = 0ULL; + } +} + +void __attribute__((section(".entry"))) +setup_initial_pagetables(pte_t *second, pte_t *first, pte_t *zeroeth, + unsigned long map_start, unsigned long map_end, + unsigned long pa_start) +{ + unsigned long page_addr; + unsigned long index2; + unsigned long index1; + unsigned long index0; + + /* align start addresses */ + map_start &= ZEROETH_MAP_MASK; + pa_start &= ZEROETH_MAP_MASK; + + page_addr = map_start; + while ( page_addr < map_end ) + { + index2 = pagetable_second_index(page_addr); + index1 = pagetable_first_index(page_addr); + index0 = pagetable_zeroeth_index(page_addr); + + /* Setup level2 table */ + second[index2] = paddr_to_pte((unsigned long)first); + second[index2].pte |= PTE_TABLE; + + /* Setup level1 table */ + first[index1] = paddr_to_pte((unsigned long)zeroeth); + first[index1].pte |= PTE_TABLE; + + /* Setup level0 table */ + if ( !pte_is_valid(&zeroeth[index0]) ) + { + /* Update level0 table */ + zeroeth[index0] = paddr_to_pte((page_addr - map_start) + pa_start); + zeroeth[index0].pte |= PTE_LEAF_DEFAULT; + } + + /* Point to next page */ + page_addr += ZEROETH_SIZE; + } +} + +/* + * WARNING: load_addr() and linker_addr() are to be called only when the MMU is + * disabled and only when executed by the primary CPU. They cannot refer to + * any global variable or functions. + */ + +/* + * Convert an addressed layed out at link time to the address where it was loaded + * by the bootloader. + */ +#define load_addr(linker_address) \ + ({ \ + unsigned long __linker_address = (unsigned long)(linker_address); \ + if ( linker_addr_start <= __linker_address && \ + __linker_address < linker_addr_end ) \ + { \ + __linker_address = \ + __linker_address - linker_addr_start + load_addr_start; \ + } \ + __linker_address; \ + }) + +/* Convert boot-time Xen address from where it was loaded by the boot loader to the address it was layed out + * at link-time. + */ +#define linker_addr(load_address) \ + ({ \ + unsigned long __load_address = (unsigned long)(load_address); \ + if ( load_addr_start <= __load_address && \ + __load_address < load_addr_end ) \ + { \ + __load_address = \ + __load_address - load_addr_start + linker_addr_start; \ + } \ + __load_address; \ + }) + +/* + * _setup_initial_pagetables: + * + * 1) Build the page tables for Xen that map the following: + * 1.1) The physical location of Xen (where the bootloader loaded it) + * 1.2) The link-time location of Xen (where the linker expected Xen's + * addresses to be) + * 2) Load the page table into the SATP and enable the MMU + */ +void __attribute__((section(".entry"))) +_setup_initial_pagetables(unsigned long load_addr_start, + unsigned long load_addr_end, + unsigned long linker_addr_start, + unsigned long linker_addr_end) +{ + pte_t *second; + pte_t *first; + pte_t *zeroeth; + + clear_pagetables(load_addr_start, load_addr_end, + linker_addr_start, linker_addr_end); + + /* Get the addresses where the page tables were loaded */ + second = (pte_t *)load_addr(&xen_second_pagetable); + first = (pte_t *)load_addr(&xen_first_pagetable); + zeroeth = (pte_t *)load_addr(&xen_zeroeth_pagetable); + + /* + * Create a mapping of the load time address range to... the load time address range. + * This mapping is used at boot time only. + */ + setup_initial_pagetables(second, first, zeroeth, load_addr_start, + load_addr_end, load_addr_start); + + /* + * Create a mapping from Xen's link-time addresses to where they were actually loaded. + * + * TODO: Protect regions accordingly (e.g., protect text and rodata from writes). + */ + setup_initial_pagetables(second, first, zeroeth, linker_addr(&_text_start), + linker_addr(&_text_end), load_addr(&_text_start)); + setup_initial_pagetables(second, first, zeroeth, linker_addr(&_init_start), + linker_addr(&_init_end), load_addr(&_init_start)); + setup_initial_pagetables(second, first, zeroeth, + linker_addr(&_cpuinit_start), + linker_addr(&_cpuinit_end), + load_addr(&_cpuinit_start)); + setup_initial_pagetables(second, first, zeroeth, + linker_addr(&_spinlock_start), + linker_addr(&_spinlock_end), + load_addr(&_spinlock_start)); + setup_initial_pagetables(second, first, zeroeth, + linker_addr(&_rodata_start), + linker_addr(&_rodata_end), + load_addr(&_rodata_start)); + setup_initial_pagetables(second, first, zeroeth, linker_addr_start, + linker_addr_end, load_addr_start); + + /* Ensure page table writes precede loading the SATP */ + asm volatile("sfence.vma"); + + /* Enable the MMU and load the new pagetable for Xen */ + csr_write(CSR_SATP, + (load_addr(xen_second_pagetable) >> PAGE_SHIFT) | SATP_MODE_SV39 << SATP_MODE_SHIFT); + + phys_offset = load_addr_start - linker_addr_start; +} + /* * Map the table that pte points to. */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339131.563979 (Exim 4.92) (envelope-from ) id 1nvvzk-0001Px-AC; Tue, 31 May 2022 07:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339131.563979; Tue, 31 May 2022 07:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvzk-0001MZ-2d; Tue, 31 May 2022 07:08:48 +0000 Received: by outflank-mailman (input) for mailman id 339131; Tue, 31 May 2022 06:58:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvvpm-00084L-Kg for xen-devel@lists.xenproject.org; Tue, 31 May 2022 06:58:30 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13d62d9c-e0af-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 08:58:30 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id f23-20020a7bcc17000000b003972dda143eso646639wmh.3 for ; Mon, 30 May 2022 23:58:30 -0700 (PDT) Received: from localhost ([2a03:b0c0:1:d0::944:e002]) by smtp.gmail.com with ESMTPSA id l1-20020a5d6d81000000b0020e63ab5d78sm10704346wrs.26.2022.05.30.23.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 23:58:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13d62d9c-e0af-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xDHqlxRoY9ROqi5ycivwmlnHxIhH5v0psmixFXh0iC8=; b=Chojm0gDMdUqtuSeOnMCAIdZhuxc8AKyL5wWHbln45TEaLvbQcDOaqxnQiQMN/mZd9 BUJC+Q9J6xXKBNPH4FP/1OnCpCLeJLL6V/P5/1o0wRzVeQXYnOp1jNEmD8dpSIQN2Y7E yCYEekkcNahlx8MWg5vaEg0Z/mvyNID9QuBuGIx+zmDMzveUZm5Uco/Sfi4sQ1Q1e11D XVZh4w6LV7RELwKA9ZfRlKctjW4KXulM0wNce2gFdYBsw1TcjxGJiolOfX73mHBOHs/a ie/25tsgx7iYjHW8l2iRS/KxROi/E9VyGi/vc0nNU2Dkddtd7376TNaINc7Xzk0imh7d qzPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xDHqlxRoY9ROqi5ycivwmlnHxIhH5v0psmixFXh0iC8=; b=lqsgDeg24AMH1/JlxzCsF09GT7mgoe12Cn7LBM/RTwQW3J5Cfv9/p4vwVWjznKc/RU meXQ0qbGvcQo4GFYUfyD90l5okqdekZKCA50QqGYgoKLUyoW3jR309hpF3cNMMwzlgNY IKIHNJMp6UGn/f3OJCOnx2IhXLJcvVkaH3/SOX92ZLyJXh+i2w4xtLL8KIzqABqgRXxR 3kMMJIzg1SPjMkNIXBYkIt8TX0yjBon7lswYB+v0P9YJabjTEDxyR7InAAp39y1RRilC rb0oD2T9L58R5R3xCITzMHeD8+6UyJwkFzqEhsKbhJ+vqoIfzucrTVePQpevsxEXng6A 9jKA== X-Gm-Message-State: AOAM531ldz+wDko8V/4g73wGN7BccFPa0HH2Nm33h3Ugj18YhNX9p8QX Il5kN1nEV1vu4LPYRNOweTko68xnBiY= X-Google-Smtp-Source: ABdhPJzVs54mi1z1fj4mznUdv/evoZpz9q8IGUNSUG42dlmjVSM+JNqMJCSdl8JCaRim1YOl0ZbdBw== X-Received: by 2002:a7b:ce90:0:b0:397:5cb4:a2ce with SMTP id q16-20020a7bce90000000b003975cb4a2cemr22504265wmj.23.1653980309628; Mon, 30 May 2022 23:58:29 -0700 (PDT) From: Xie Xun To: xen-devel@lists.xenproject.org Cc: Xie Xun , Bob Eshleman , Alistair Francis , Connor Davis Subject: [RFC PATCH 6/6] xen/riscv: Print "xen start" in start_xen using early_printk. Date: Tue, 31 May 2022 14:57:12 +0800 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Xie Xun --- xen/arch/riscv/setup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 79beb25ff3..ae25e4d516 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -22,6 +22,7 @@ #include #include +#include #include #include @@ -54,6 +55,7 @@ void arch_get_xen_caps(xen_capabilities_info_t *info) */ void __init start_xen(paddr_t fdt_paddr, paddr_t boot_phys_offset) { + early_printk("xen start\n"); } /* * Local variables: -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Tue May 31 07:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339192.564012 (Exim 4.92) (envelope-from ) id 1nvwi9-0001Eg-N3; Tue, 31 May 2022 07:54:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339192.564012; Tue, 31 May 2022 07:54:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvwi9-0001EZ-K5; Tue, 31 May 2022 07:54:41 +0000 Received: by outflank-mailman (input) for mailman id 339192; Tue, 31 May 2022 07:54:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvwi8-0001ET-Ax for xen-devel@lists.xenproject.org; Tue, 31 May 2022 07:54:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e925f40b-e0b6-11ec-837f-e5687231ffcc; Tue, 31 May 2022 09:54:34 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-43-EIB31IJ_OdKhky1jwuu5Aw-1; Tue, 31 May 2022 09:54:36 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6033.eurprd04.prod.outlook.com (2603:10a6:208:13b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 07:54:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 07:54:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e925f40b-e0b6-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653983678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XHOSTUy1FnbFA7QjAi/DOZvPLsWqa2smmUvHnWE6jaA=; b=eHBCJ2cvdBCj53Du/NN8V/FhmvVEuLtiFxHBRxPfMSlZOh9XBx68jLVed8HkMCZuO3bsn4 uzQcQk2HRUurQ8JMZyYWHdK2HUnZ0PkyDY7mi8xxpnzI75KzPekwyQSzB6yG6LlOxRxbW6 kHB1uRF/L3J9tVoXzmZ2A+eU6583dEs= X-MC-Unique: EIB31IJ_OdKhky1jwuu5Aw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1f4wU4VsiLGZAbz+n/SzJi8fcWnVwLhDiMUf9dwihj5GSn9Ib7w9NEKupnMxEiNeZq5oELxV2ou02nJfQSgQAd/fEUZXvjQSpPp5UlhShJTd9MdpUrg6DA6V23eMeoDHs55eLGCLw3rl0YqcVVNnpokqDQLgIHeAJx/CEaWhswL1Pae2OYCp/nLmloSzgZyuxU2VZ5hrOnforADzFyUtNZtTOnu61B2kehU/443YyAgkZqjEPFR/tvRQGVCgpTWO3vf+/8imbJvHtueks8dqhhSWD2uq2xjG9332ivVqDIm7mPx9/S22WW9m+MXO4pGiJ8PwNAqH//qkt5Hsg2b5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XHOSTUy1FnbFA7QjAi/DOZvPLsWqa2smmUvHnWE6jaA=; b=nOYwGJyg7/M6UuaULsa8lvly4wyKzjUc+ureruCNQS/XxKbP5Staj9jm0ZK9Wo+QpEiqhm7QtGsc7/xPVyGtWhsZx6mRXfJ6UWi2wibGoF3ZGNVTcvbjlk7x4L9mvTW+tSOd4GHQQXva2PEJL9DfOKWPGs4jIDCBmZfLIl0beSbCJn9ubGapt7pGsQ128rPeHZavq6sIE+wzgfrgodpR2oVH0p83vPjJia+dyCS+GRBOHDT5F1Qmo/el3ylboUsb53Ni0vK3qQZxv4hClfQpxO11vZ3nQQ783nUcFjzzrhKz0on7FUBUY2m1waa5Lw//zIeUlRdZE3ihH6m8s+AxZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55710c63-c531-3330-786d-ec6349690311@suse.com> Date: Tue, 31 May 2022 09:54:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 4/6] xen/riscv: Add sbi.c, sbi.h Content-Language: en-US To: Xie Xun , Bob Eshleman Cc: Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0137.eurprd06.prod.outlook.com (2603:10a6:20b:467::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b851272-bbd6-434b-788b-08da42dacd1c X-MS-TrafficTypeDiagnostic: AM0PR04MB6033:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1DZBCEKLdnSp0ZwTfJCyD59n157Usb4+MibhhJctduTwo3Sc7NjDV0J2P4RSA0E9wwXbCvM8zSTuiIdmnpj4aYbWsKs9Y0psEhI1hIryVPCQoJ/748P93etZ5TlNwfGGojxBZTTDp+e+NEP6scB8ohJXJusLmu4y7O8k2WjwMHo4sWXhWka21PwMeEDM8/9A/+7RHgtlOg3DcHiv5lx7fPN2cEQRNAFcc+kBLhXJBFekQUusAEbrLyahIUmyz2S/A09W5ud9eabiNKMcmu3fI68WlphB4QSxdt14wuzbwURwHxkKUtRsEGz2lz7i+/jLWBWT/VffZYVJZpKDRdckpji76ualQFXzDjcPRIShD9WOl0+TaFtMzGFSyAOJZnzMFWwJHZQGnZ8AOidMbo867gSDh3VUc3X1SsC8lO14Le96DNy6aZwsK+ydFKhOEcjRJSuuOXw/oI7Hxk4q5cYG7iI17t8glgTbDeYmSpTynna4+3ccYEpVUHE/Zm42QAhOWIk2Iu5e3G+FWLipQs4LJbm7FsBSmI2e87IqUbtLkC4Ps/Tx6v7UcBPL3ReZd+TepIng6KtkCdsSof0OYsfE4LtduPJqHjfls2YnPK67Q7x7yFHW7A8Bjem2s5HQx85BiXmw0+eaxI4h62Lq9lc1Uq/o3EicUtvWIFbdSMZFJGaWZpIbqa34HhC5zOjaQPnmfe6GBleAADzrnvoy9N3WGKX2071StuVwkzNYe3WW13c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(86362001)(31686004)(5660300002)(54906003)(4326008)(8936002)(110136005)(36756003)(31696002)(2906002)(4744005)(6486002)(66556008)(26005)(53546011)(316002)(66476007)(38100700002)(186003)(508600001)(2616005)(6666004)(66946007)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE91dldpL2JmU2lFRWRkVEdRQ3graDNxZTdrRkFERzByMFBqZVBUOXdzamZL?= =?utf-8?B?d0lIUE11TkdESUlvTFpKRW8rYlpYMTRTdW1GdW5ieE9ZSktLSWF5bEpoNERl?= =?utf-8?B?OWZwU3ZvNGRsemdmQXlVVmx5UGxjVE05NjRzbTFtUTMzM2ZXcTFGYjRQSy9G?= =?utf-8?B?VXJwTVc0cjVZb1h5MmYwN01udVZjSytPcS9JS3BYY3BTOTRNWGNhWDZyVXlD?= =?utf-8?B?cVUwcVpWTkdvNjZIUkU2NkxNMU4vOVUzZ3ZaZlhaN1lxWi9kTkwyZFk1UTBO?= =?utf-8?B?akxXdmU2RTRYUDRHZWZ6OVNBb3czM2I1RXpMK2g0bWluZGNiT0JTdG5oL050?= =?utf-8?B?RjFQdExuLytESnFjUmkreUVtR1RQQUJnTlJxQy9NQU1vNEdhMURYNWtDV2Zp?= =?utf-8?B?M2dTZlhvNVlzYi96ZVR1c3dRdDJOZ1Q4Z0dHM2lFMjZwMENxZlIzckRMUThu?= =?utf-8?B?a01PVVVhZEtFWkRHenJNN2FlNy9MZktVQ3d5a3RxMFpiNzFlQWhnODRuNTZ2?= =?utf-8?B?WTZ2QVM4bzNlRUJYMWhNR1J0QjJxVzVQMkwvOHVZWWRVbDJwZ1RTazRZYWFC?= =?utf-8?B?RkZNaFcrZ2F2SDllK1daYVI2U0JmbVkvRjcrb2ovbWR0Z2VHbnUzazZDMklz?= =?utf-8?B?blUxM01XeFd1N0M0Rm45ZjhyUDV1QjlWKzNzWXBNTmhoZVp5ek1jSDY2VG5I?= =?utf-8?B?RXVySUl6YzhzQi9zYmgyWXc1NEFIVjVtb2FENm5BZ3B5MXpOdm0rUlIyM1hq?= =?utf-8?B?eitra09xS0lJdFNjTmR6SVJlRlFKcmlVZzY1Z051TmF5UnpwVnhBNDJYZWhT?= =?utf-8?B?dStGelU5TWh6ZFhTbmxmT3NMWTFKKy9FM3JxNkpaeXRyRkdOakhySTIzb2dJ?= =?utf-8?B?SExreUJrTFlXZlRCT1RsRDFQeFgxQ3lSZ1EvSUM0YStBTE4vT0pEQjQzM3Uv?= =?utf-8?B?Nmw3a2RKRmh3NXlGVXNqMUx2ZFJkQVozYjRLOG5SMi9iNmRGQ0pzSkRQMmw4?= =?utf-8?B?WStsTmRYdE9GTFU5ck5xS0xIK1FtaHU4QTBJMjBSekxFTmVWb0luOHNnSHdI?= =?utf-8?B?U2pQUVVyejRxTmpRd0ZVc0U1VFhlb0ZiOTZsNnI4bVpLVnB3WXlVYnYwZUNF?= =?utf-8?B?WGYyT1M0dWkvWXFmYWxMWVBRK2o3U1FFbWs5ZnZEZi9vcmt6dDZIQTJuaytT?= =?utf-8?B?cWF3WGRCTkR1MTBkS3BDUm9Va1A3M05tNndmY2p2bzl6ZFRBSVNMSHkzbWZS?= =?utf-8?B?elkwODRoaXhTQVJHeEF5UHFURUhOMnZ2ZFhGU2E5UTgzSm5OQTV5RlR5MXFX?= =?utf-8?B?THdIc0FuclR3aGNwcEpkTmd3T0plZ2ZiSFc5b2NMMWl4SEoycXhIYWJyYTBP?= =?utf-8?B?aEdVcC9GYjZXSWVYbmhHWFFjTnhFOERSNnVMZGVtMHNnbHFGSGgvUWhOeC9P?= =?utf-8?B?S3c0ZHhsdXMyeGFkN21uZDZ5cm5hcER3dURjd3dGTVpXSkxjdldrdm42S1l6?= =?utf-8?B?MGYyZFJVRHBhRzkxcmxhWHkvNEhrQ0hzMTI2cmJyMG9XQ0JqVUNxRUszWUlI?= =?utf-8?B?YWhJWWFoSWEwMXRYT1FKc1poRHdYSmpDR0tRcTJNcnNDWm1Fd2hzT3duSHlp?= =?utf-8?B?aFFGd0lXaVMzbjUyeXhSTjZuU2pCOVVKd3htekRSWVpnYXJmcFpEeGlWZWdQ?= =?utf-8?B?emp0Z3NYRTdHVDFJblNnYmZQb0lrUmx6cnI1RDJrUDJLeFNiNFE5V1pkUVcr?= =?utf-8?B?ajZZSEhBeEhLRmU1QW04aWZTT2l2d2I1WUpMSVJpNEVESWNNRjdzTFRkeEJF?= =?utf-8?B?aUNWeXYxaENoamlqWmNkQ2FNdjZWSXVPdjN4dzQ5azQ1WjVvWUVlMnU5UCtU?= =?utf-8?B?aUVGTlBUK3loZkJML0VhelBhYktCZlpUNUlMTXdIc3lYVG9tWURPZ1BNbnU1?= =?utf-8?B?VXE1c2JBYjB4YkdCakhJeklodjVUR3hkSFlSMkNVclEwUFlHOEUzWlNpSktj?= =?utf-8?B?bmppZ2RXSmRLVVVZbjBPOFVrQWdKK2NEenk0eG5kSWpBQkt2ZGdObjJKc3dI?= =?utf-8?B?ZE1SVHZTWURWZVNIQnNNaVVUSTFDSzZNL2Rua1ZIckRzbmY2ZU1Vc3NRd0Ja?= =?utf-8?B?UzlwcUhtZFJzQkJTRCtXYkZ2Rmd6OU4yVW1UN1F4Q0h6WEhqdW5nK2thdzNO?= =?utf-8?B?QXFiM0tESGM5R1BsZHVmamtmT3VPY05SQ2QxTDRKS2ZaQVFvMHFxcnhiWmg4?= =?utf-8?B?Ykl1ZUYzbTY1MHA1TExiUzRPQlFSK0orTDk1SXV5cG84QUlKd09ZSlZBcU4w?= =?utf-8?B?SDhOcjEwZUxpV0FMMHcvQnN0alQ2VTl3UXFZK3E5RW5iYmtpZFpWQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b851272-bbd6-434b-788b-08da42dacd1c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 07:54:33.9720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qNNlTY4Ot4xJlUN7H/0l/v3NWFf0KajBWF1KNNWndqRQQXGZy0Oc8058BRAr8TV+LqQiQlKgSc2qNSJT2XqHlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6033 On 31.05.2022 08:57, Xie Xun wrote: > Signed-off-by: Xie Xun Is this correct / complete, considering .... > --- /dev/null > +++ b/xen/arch/riscv/include/asm/sbi.h > @@ -0,0 +1,275 @@ > +/** > + * Copyright (c) 2021 Vates SAS. > + * > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). ... this? Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 07:56:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 07:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339201.564024 (Exim 4.92) (envelope-from ) id 1nvwk4-0001oD-4O; Tue, 31 May 2022 07:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339201.564024; Tue, 31 May 2022 07:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvwk4-0001o6-0j; Tue, 31 May 2022 07:56:40 +0000 Received: by outflank-mailman (input) for mailman id 339201; Tue, 31 May 2022 07:56:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvwk2-0001o0-Fh for xen-devel@lists.xenproject.org; Tue, 31 May 2022 07:56:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e359ffa-e0b7-11ec-837f-e5687231ffcc; Tue, 31 May 2022 09:56:31 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 03:56:32 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3794.namprd03.prod.outlook.com (2603:10b6:408:2f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Tue, 31 May 2022 07:56:30 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 07:56:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e359ffa-e0b7-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653983796; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=UzFNEjrzoo7jc/jJK3Y7ejN2sx/ofgJmthypCHh7BOQ=; b=iIVDt5+brXGKNSBH47OYZqblMNyjjowgqAD3F+0gYfhC+IWop+WTxdeA 3KRVJ/wVsPvxH5xZQbCZD7j4WSipW7QT+gMSh5A7m6JNgxzUE8ZQmgUE6 n42bcFQ0BBOoQ+n/eva/ys5U5yDE4FwstwNB4MPD157uc91L4+nrR3zcy c=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 72506169 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RJh+3q4+LzZ+GMWXNWuXqAxRtDHHchMFZxGqfqrLsTDasY5as4F+v jBNUD3VPvbZajP3co13Pdyw/UgP7J7XzdA2HVFu+C82Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXiWlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSgdRcMNIyQst0lCRRUKQFhFKNnoO/udC3XXcy7lyUqclPK6tA3VgQcG91d/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YHhV/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IC9QrL/PRmi4TV5CEqir+xG+XPRoPJGNVRhXqHi 3uZ8U2sV3n2M/Tak1Jp6EmEivfUmCLnWKobDLCi6uNxm1qX23ASDxsNE1C8pJGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JuFOk95BCI27DjyQ+TDWgZTRZMcNUj8sQxQFQCy Vuhj97vQzt1v9W9Unma6qvSoTqsODM9NnMLfysNR00E5LHLoog1ggjeU9VLH6u8j9mzEjb1q xiBrDI/nKkUlc4GzeOw+VndgBq3upHTSgc/oATQNkqh8whwIoCsYYel7VzGxf9aKcCSSVzpl HoLgcGa6MgHCJifkyrLS+IIdJmy/OqMOjDYhV9pHrEi+i6r9nrleppfiBl8OUNoP8AsaTLvJ kjJtmt57pJJIGGja6MxZourEtkr1oDpD9GjXffRBvJMaJVscA6M/Al1eFWdmWvqlSAEna82N piadsKtJW0HEqkhxz2zL88R3rMmyTo37X/CTpD8iRK82PyRY2D9dFseGF6Hb+R85qXUpgzQq oxbL5HTlEwZV/DiaC7K94JVNUoNMXUwGZHxrYpQa/KHJQ1lXmomDpc93I8cRmCspIwN/s+gw 513chYwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:7/faSKk1m6umNS2Gto5NtTdLwcvpDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp r525RT5c5zp/AtHNNA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,264,1647316800"; d="scan'208";a="72506169" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FjWOPOlPJ/IeIubNn39vaQl2GZUtjdbo4nqPFUd22ak6AZ4rHLDnsGUt0C7zCixjSu7mecQvSBtcZH5RFlL4v4DEq/WjiZTXx11PxznaZRXcbLJ/OazVAZbzPaPNaI2CuVXG0ywrTo3jstY5yuqHlbdI9FuuLKUzxvYBLAL56197JYUHZnUr2HtC85mJst8FJvgFzI0KXwU6Bg31x1P5ZfUpVYfIke55OyHyZoxs3b+FEma8YeTHmC6LA0os7XLZkqTC+oxcCEfb0ZqCcfw2mQSUx3Slcnt3yd1mbAHuVhGylTwzqRfHqxbYM2rKP82YVAO/GMpU2KhpB2R6KRTWxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mlToD4p0rQc138ujI6eF7wOsecnpiZoWIk8SOWgxohQ=; b=QJINiHumhw9MSZ2Bx17+Ci01k4jI8PC8xCTDMaPu1DSc7azjc0wttr4OjT/5YvtNPR6SWI2jTaNlPAzAsIEM16AippvX+GwPAW3vuUiLngZ6JDzWArV2EPlvnhLBkEigYOAb7jS41jy51Vyt9XFgVhvVT9/NtccBJDCkY5nwBGXVXyzxUf67VyzKsmmUzqNJxgK9V0mBVq+OIZBlzO/QWgQ0kL7GgcoxSKlYufNpSd+Pd2hX21JiMj0ap0GL6oGidtwC3XWT0Ac1TOa86FnR7D3VpNWqSehoubw9kvsvR4xw6cUScryJEzxiK+PMvmH5DTHGrQbX21Dk8UaFngAz5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlToD4p0rQc138ujI6eF7wOsecnpiZoWIk8SOWgxohQ=; b=ZqPyh3GxvFG5NxPhRgLCoZOlqgxrWCsv0feuRkrwHIIxVFsRb7tfBZZM7prZmyniwDViKBJbKbTPF5zpB0w/grqg1tlTtCtjGHPUR/q9XNuks2fqDAuAfea3Psb88T0d1hTL2XbA8qfn0vB3zjJVm6ElL428RiwFAVD1roCZCTE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 09:56:25 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Daniel P. Smith" Cc: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: Re: [PATCH v7 1/2] xsm: create idle domain privileged and demote after setup Message-ID: References: <20220511113035.27070-1-dpsmith@apertussolutions.com> <20220511113035.27070-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220511113035.27070-2-dpsmith@apertussolutions.com> X-ClientProxiedBy: MR2P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::13) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e977387d-9128-400a-9518-08da42db128c X-MS-TrafficTypeDiagnostic: BN7PR03MB3794:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KjrZ49pzLPQn3OCXLzIClE/DjMJF6wteEXiTQcY5v7+ErWb+jB/A80ln5HDY9xVpUjJvAOiL5Qv4nndSh3NpF0spTAAEeGfcfkEkc6GOknbclkcajT5JMEIxGfwyi9ChGGbdHu6gRDotwhIkbuP6Jq5DcC6IlvwshlMf/vuLWUjupUc6rs2rAQAPs5z/qDjc/8skspXDhMTZGRy3h88yCSD9vTgtO1EfkEWBM/Ugjzr6iK5VR4YvjQeGTbsv4JGN3ZvysUeVhDO2hqBhgIWhCxrj9Ys5LoW5ND2BJAZ+yto2BvTbDnRpp+fPJIV5VNgD/KpnRnX9HwfCilFwqAiL7ktMtdl3GVRYZACiR6fsfsR3tnje2t0qWgFjK0SjT5LXTWDjCeioY7PeQICIGB3JIumDtOoYcqjtXKgXNITST60GKnYz38b/Kby78TBk/5kMaEz/MCApnFHThoeLL6bp3yIqMtL7BtdiMYOS6N7GHT7WZxsll++VS8jnAtrmOeUgI6hV+R8e5Pt+JlO1FqZNodH4XxED5FDdVr7iiLDvIV7HRPTbR5aUcRRVGK9+5XPLj1GEwPtzXneWKOcVg0yIXP5GwlPUIrs6dJoKD4dCLm+bu4/6TgQcCsb3YPcZaugjsk7G855XfhSGwlFfBHruHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(83380400001)(8936002)(66946007)(6486002)(33716001)(5660300002)(54906003)(6916009)(7416002)(316002)(8676002)(4326008)(66476007)(66556008)(85182001)(9686003)(6512007)(6506007)(186003)(82960400001)(86362001)(38100700002)(6666004)(508600001)(26005)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHpIVmxSWVo3TzBBUldDcXF4UG5NVVo1ODRzazVmYytacGtheENKODJhcEFv?= =?utf-8?B?VVpGM1V3Q0VORCs1bHI5Ynp6YXhVVk9OTEE2V0QxSUwzekI2UVUrTDJ1SUdS?= =?utf-8?B?NjlYeGt0RzdOTUEvczA2Q1ljWDM4WEkxV1lUd1BRZG5lSERtMlkyVVFjcHht?= =?utf-8?B?bE9ZMDBGOXE5TUdhcGJoblFiWmF0ODZQTkhxUG9weEVUclpXeUVmZG9PZnJs?= =?utf-8?B?c1pMYU9YMW9NSGF3dkR5SkhEbFpvOWVhSDBGZ2lhZHZ1ZXA4SmkrQSsxdFhT?= =?utf-8?B?L3pQODRZbW1aYXM3b3EyVkVUWC9MQWR6blhoSVNpL055SVloUEE5cUg4OTMr?= =?utf-8?B?TXhHSHZGUDFNM2RIV3hDUU9hQXRTR09DZGFURm1vWFI0UWc4QmNsbUhXREd2?= =?utf-8?B?VSt0aDJ6eTNnOFNnL2RWVitmQVN6bGhGVytvVjZGbU1uRWF2ZmxScUdSelR2?= =?utf-8?B?VkU5dGMvenBOeVd5RHhCZ0wxKzFOa3I2VVJ4VDg1UmNJaklGNDl5aCtNL3JF?= =?utf-8?B?V3VJUEJOMjRPTDA5bisvaDdKRVZMQ0RjdS9xQXdIeVA5V2hPWFBFdW56TGtR?= =?utf-8?B?T3Z4cHp0eVlRS0JvYWdFNEN4blpTQnRnL0p0d3UydnNoNm1Zd2s4UzNwSlpO?= =?utf-8?B?TzJ0a0V5RytIWXd3TWVRSFZtdkZGNXM4NWRtNDB3bktGNEd4SmpzalBQMjB6?= =?utf-8?B?S1FXNmV0SUJkWmdsTExGMU8wancxWlNuOHJzSTFJdjBIZDZrQUtXN3dTbkRl?= =?utf-8?B?a2hqczBoOEJXWnhITk10Qk8zUnF2bkxCRXJvMm1lQlZVN2ZXZkJjTkZFYnM1?= =?utf-8?B?SXZ6cTY1VTA4YUI2cUNOTVd4blErZ0RZRXlmV3lJR1h1c0JGOWZtVDVQYjIx?= =?utf-8?B?cXNnL0UvZkpCdGhVRSsvRCswQWVBOFNvMlIvNHNENkVrUFBreWltUC9iUkp1?= =?utf-8?B?dTBNWEo0WEpDQXlsOUYyMGdPYktQM281S0Vwd2t5YkxNWHpJeDhnMW8vdEVC?= =?utf-8?B?cmRrNlVwb0ptMGhoOTZNTE9mcDdWT1l3N3FxL283azR1KzBvWVJncmdKMzhr?= =?utf-8?B?NUY5MVI4cVZiQ1phemhyRGd2NzROTEI4aE5tSGZuZkR2eXNSOWNnSHNuWFVr?= =?utf-8?B?TnFFS2x4dzVrUk5wVFQvVG5DWmdnOWU2OVlJUE01Z2U4UUJ2dTBBOGpyNkdL?= =?utf-8?B?cVl1UlI5VWZWdVA0ZXVzbU5FL3diQlhJd2hocm1tT2lsWW95MEoyU0NSb29J?= =?utf-8?B?UUZCWnhWU3kyTm4yNXFBK082TS9ydllWMGdmcVpZemliVnloV0haV2VCVnZw?= =?utf-8?B?Rm1yaFBZTmtBZy93TCtBZExnbVVmLytiMU1ReUVyT1pCR2NScEtqbUduNjhW?= =?utf-8?B?SEJyMiszZmFOMDM5SGRlNVVNaFFwRm9XaGFFclg5cW5PQUNhK1k4d2xiUkx3?= =?utf-8?B?cmhmYUdwbU1qMEdkSUREYTV1cGhKeHU0K3NnUFJNQXlQQ1QwWStmclZQOGJB?= =?utf-8?B?ekRTYkJZb3hON0JRamZBK2R2bTBkOEl3YlJ5ZEhvUWRyVlBWQU1jSGNHYkZP?= =?utf-8?B?bnRNeGNObXV3Zml0QzQvdmVGaVZxajY2YTQyclZxSHdOR1ltdTJ3REpVeEVo?= =?utf-8?B?MThVd2pzYzJ1cGlXRTB4NWtyMk9JT051Ym0xMGcvemppbTlSSk1LQ0tQTmRj?= =?utf-8?B?RDU0eWhCODNXQ3lEekx2VU9tN0Q3TkJEblJYZVpnOUkxU1FyaVljdHc2NVFh?= =?utf-8?B?dCswcE5PYkNDTTdaZHB1anJSNldSd0VtWXdxTDV5ZTY2azcxT1grVC9Fb1Iz?= =?utf-8?B?NE5yZGtBaGFoUUdPL1JCV2QzN2QyR2FxZ2pwUTBMZFdveGxwQnhVeW5QVnNO?= =?utf-8?B?d3IyV3U5cmgvdE0rWXpoRExwRzV3bVhQTTVwUjlJZ3R4dzlSUG1ZaUVOeFdu?= =?utf-8?B?c1BHNWFWT3h3M05EUnNRWnY3ZldyOG1LQzBUbEx5aHBJWEJjdXFUR09TczZv?= =?utf-8?B?UWlvZzBRa0RReGJUQ3NTT3VBTmMrNlJhcE91dXhOeHNSa3RXZllFZzM0eVd6?= =?utf-8?B?TVZaMEgveVJGU2x1T2FPVUpoZ1lYU2dWMVRnRTFUWTFlZHZtYnlLMXFzZ0NL?= =?utf-8?B?Y3NnNmFTSENOS3Zkc0RRUDFvbzdUTXFXeDgvZ01ZR094am13UkhZcFRzaHpJ?= =?utf-8?B?NGlIMGprdzBRT1JHenNLRnh1Y0NYZlNVd2hrMWxyWUJJTEZPTm9KWmcxcEds?= =?utf-8?B?N2dmeTNvc0hHYTFuVlI1WDkveXkrK1Y4WFk4cVczR09oMmlONkFXdXRMS1pN?= =?utf-8?B?V2lSNUllU3NLMzNEbnNXNnZBbklrWEU1ejE2eERtZ1IxTTFiejhyY3RYT3c2?= =?utf-8?Q?RZZvDeAxgUdGNyy4=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e977387d-9128-400a-9518-08da42db128c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 07:56:30.4695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jqtFIODcYNwDpNujy92f1XqXBqNtGyc/CiQIkbNScbWBeuyuufchiWSUqTT+svQWLobjz9ceGF3OQTXT1ORRJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3794 On Wed, May 11, 2022 at 07:30:34AM -0400, Daniel P. Smith wrote: > There are new capabilities, dom0less and hyperlaunch, that introduce internal > hypervisor logic which needs to make resource allocation calls that are > protected by XSM access checks. This creates an issue as a subset of the > hypervisor code is executed under a system domain, the idle domain, that is > represented by a per-CPU non-privileged struct domain. Should you mention that this subset of hypervisor code that requires extended privileges but executed in the idle vCPU context strictly only happens during initial domain(s) creation? > To enable these new > capabilities to function correctly but in a controlled manner, this commit > changes the idle system domain to be created as a privileged domain under the > default policy and demoted before transitioning to running. A new XSM hook, > xsm_set_system_active(), is introduced to allow each XSM policy type to demote > the idle domain appropriately for that policy type. In the case of SILO, it > inherits the default policy's hook for xsm_set_system_active(). > > For flask a stub is added to ensure that flask policy system will function > correctly with this patch until flask is extended with support for starting the > idle domain privileged and properly demoting it on the call to > xsm_set_system_active(). > > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk > Reviewed-by: Luca Fancellu > Acked-by: Julien Grall # arm > --- > xen/arch/arm/setup.c | 3 +++ > xen/arch/x86/setup.c | 4 ++++ > xen/common/sched/core.c | 7 ++++++- > xen/include/xsm/dummy.h | 17 +++++++++++++++++ > xen/include/xsm/xsm.h | 6 ++++++ > xen/xsm/dummy.c | 1 + > xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ > 7 files changed, 60 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index d5d0792ed4..7f3f00aa6a 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset, > /* Hide UART from DOM0 if we're using it */ > serial_endboot(); > > + if ( (rc = xsm_set_system_active()) != 0 ) > + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", rc); > + > system_state = SYS_STATE_active; > > for_each_domain( d ) > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 6f20e17892..57ee6cc407 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -620,6 +620,10 @@ static void noreturn init_done(void) > { > void *va; > unsigned long start, end; > + int err; > + > + if ( (err = xsm_set_system_active()) != 0 ) > + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); Can you place err on a new line to make the line length no longer than strictly necessary. I think you could also reduce the printed message to: "unable to switch to SYSTEM_ACTIVE privilege: %d\n" Which could likely fit in a line (seeing as others are fine with the longer message I'm not going to insist). > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 0bf63ffa84..54745e6c6a 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) > return 0; > } > > +static int cf_check flask_set_system_active(void) > +{ > + struct domain *d = current->domain; > + > + ASSERT(d->is_privileged); > + > + if ( d->domain_id != DOMID_IDLE ) > + { > + printk("%s: should only be called by idle domain\n", __func__); > + return -EPERM; > + } > + > + /* > + * While is_privileged has no significant meaning under flask, set to false > + * as is_privileged is not only used for a privilege check but also as a type Nit: I think this line is over 80 cols. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 08:17:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:17:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339215.564035 (Exim 4.92) (envelope-from ) id 1nvx4N-0004yW-9B; Tue, 31 May 2022 08:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339215.564035; Tue, 31 May 2022 08:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvx4N-0004yP-6R; Tue, 31 May 2022 08:17:39 +0000 Received: by outflank-mailman (input) for mailman id 339215; Tue, 31 May 2022 08:17:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvx4L-0004yF-SP for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:17:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1dfc1311-e0ba-11ec-837f-e5687231ffcc; Tue, 31 May 2022 10:17:31 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-3nUSs_j_PjmRPSBbNEwR0Q-2; Tue, 31 May 2022 10:17:34 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4773.eurprd04.prod.outlook.com (2603:10a6:20b:10::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:17:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:17:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dfc1311-e0ba-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653985055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hgszuEWJ8PlB1T2UprLpogzfv1/FWWEjNMDO1Rvbo+w=; b=ltcWCjX26j8KuswLaV/JhD/5CSuNziK7HnU0nA1RycChoToAcuyLbtIZAUUvNsn51BT8Fk yyr+CwnZkNPF91qivplxbLDcKxRttMxXW4oBoY7eX2lPun7v2wMuRsx2UrFmS9MkjP6DyK HCtQoOUi1sbONB8aPOG3Cr36OCkXORc= X-MC-Unique: 3nUSs_j_PjmRPSBbNEwR0Q-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWoL5eNUVkvxt4C4C9beBAHyUqbrh6dZ7c5ih5gmGBny1hEjsUCWxCI9f9WZPB7ybp6KWsMUWAH3ItwfoQgXZariYT4OQZvJZZwAb8IvIvbvIGQ8KHXdhQkWAYmGFF4AUTJL7qpTBg0EZXIf48Gh4OMBZDnxYTCjm/yY6U47uY+NqRwG1taG+fgfjC/oE91PJbkAJTJDs4k0qIpPP+cIYM/JZ00b5QzArCeO8ziS4hP/Lu3qFmOWXKTYqYHpDk7J8qmE0RcoBMN+8tVshtB77jY6Rcxm8xa3UeuUlxESBb6+PIstfwzfOYtd68MxQ8tufdkCWjpjFREAPwCnKtNhRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hgszuEWJ8PlB1T2UprLpogzfv1/FWWEjNMDO1Rvbo+w=; b=cAQxEvrk1wjMF+zqRMw60LKsXqESLlrovpyApUgAYVnqC07B40ecidU+hctzSrRcH2esC7zb1y2O5Cq+8zHlN2nlPLB+fYxIOqnpTDc6+ut5h4BjSCVIFi7+Ndr6OvSg5Kq/ptIwbsqDjY+BuPMgwdvaWp0Xwp+F5YxzjqaJCW8LiJshb56YHRt+JJeLTANiSuafjgWOWJMlzFQUzJdV/8Wa6bU1DSWVyEpgty++4ci+9C8ggoxFoSqVFn/DOnCqVP2W2Ttk8TCHUfSIXo7qhmotO0TnsfGKxl0BlUtweRDp/jCRzMR5ACnt2hHPoXCKQGALQ+dmOXyA4sH3hm6SIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 10:17:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 1/6] xen/riscv: Add necessary headers and definitions to build xen. Content-Language: en-US To: Xie Xun Cc: Bob Eshleman , Alistair Francis , Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Juergen Gross , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:20b:46c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: efa7fd42-0989-4768-84bf-08da42de019e X-MS-TrafficTypeDiagnostic: AM6PR04MB4773:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W5MzvATm1CC/9FnkKtIJkcQuSVwRv84UwCsbQWLk3tAd0ZEI1RIpmytEUPiBn7TZb3qhTvHsrBFkl8uSYlsKRa0o7Jz+5hBZeFMmZx05vQ7s1MfA1igt0tSeFTxiukuzlJHw3tsU+ArP8VgltJIvup+hZT1DBzC+oxO+/JQmNUC8whvBu1fiD1Y4V15iTlV+FLh7q3BAqg4vYq98GNZzavowS/9EfYYh2Q7CnTfi+Qm36sdyw6+wb8E+3lCH+m6fTTpkJU63sXB7mJ6n2RfNcTOGRVkTlBXHF6R7p7WJPtTAZRdHoyucUVZw/84A0Bmr2HLPuAEN2HM7399yOZUHQ8I4dzgr2JMdeGY2UPyyzA28y8Ns8hdjnylz37Z9WkGjguld7cWgUBqrFTONNo5pmYv4tPZdkvqwoh0zk36KvG07Gqxm2ofSw+k1uS+TmlMkp9NLTlHZuUobE/90nbarT3YvFExwZgrDeUXpU2f0qnniTMCp1FoLoy5e3TrCSgPrsWXptr3f+nWqcxi+NEcBEtX2+TKmTV8x/234aKwiNQZ4cofIPSvNEARl9vj3bwJl2RjlzmD95wUR4t9GjvmRr/e/rSVJxgPGv+UXvZHm9VDdemdG4CnxVoIMi24B74Ftjh+4P1oV5+IqUkkxPe8o1uyYAO0gNOOt+wohO5n6PS6xbqb6YK3VOvKFanpgELzTZUZTsc/x2fXRAIFSFe8JA74DGo3Vm14uAhRX+8PxY0GZqhqQjlNLMMwgQeuYsuVkyY7x1BKocnyN34smxMW6sA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(38100700002)(86362001)(31686004)(7416002)(5660300002)(66556008)(66946007)(66476007)(4326008)(83380400001)(8936002)(36756003)(8676002)(2906002)(54906003)(6916009)(316002)(2616005)(6512007)(6506007)(26005)(53546011)(508600001)(6486002)(31696002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzRVTlZ4cmRCeTk3cHh6cG5uS0k2dWszL1Z1MGNEbE5XUGI0Q0UwakNrc2ow?= =?utf-8?B?ZENTOVA5U2xzZDc4Q3g5MnZxNm1nNlZBWE9PaE5HMk1yd2RSL3dNeWhsMUZu?= =?utf-8?B?dTRHdlBiWHozbmNxNSs4K0hmQm1RN1lEODd5cVRmOG5YNGVYcG1zanRHMWpP?= =?utf-8?B?a3REY3dNK3RzVitrOFp1RjI1Nmp2VlF2TDRxWllrRVlnQmRsVEdGOWZ4VEIx?= =?utf-8?B?Lzl6dlF2dHNkKzg4cVl4Z2xuTkZVMmp6UDBGNVdMYVVXZ0NETXoyanN6Rmhx?= =?utf-8?B?c092TXkzTWROZ243S045Vmg1SGpUTkxwTi9vdHBtbnpJOTFZWHcwbE50d29s?= =?utf-8?B?VEYzMUE1amR1YUF5VHBuT0Y2YkN0a2VpR0dWZkxqQkRDMkVvSlQwVW1BVEo4?= =?utf-8?B?c0xpOVorZnhrZGpKSlgzL0krRzFhWElvMHQ3dW5ZZno0djZ4NDlNa1JJbktU?= =?utf-8?B?WFQrMGlHTlBzTDFiZHFnY3RBSXp3RXpsUFdGY24vSStLOEdMVEY0MnY0VjNP?= =?utf-8?B?YmE4QzBzR3M0dlVBbzdNS2prMXVJemd3TEdTR1ZMd3VnMzJCK0gxcXdlRFox?= =?utf-8?B?OUcxTC9ORFpSZFFKTDdLbW84RDZiY1l4SWJZRUtTTnlHWXFTdmZoZlErS3FB?= =?utf-8?B?c0xFaDMxc3M4bDE2MVZMMmRUMEdhWGlIS0RSTlhtSFdHazk0aXpMK2N6TGlw?= =?utf-8?B?VmNVQWRtQXlRWGdXZ2M3TGsySGtpT2FvOHU4RDAyV3dsVUcrRGxIdktUR2wy?= =?utf-8?B?RVlUNkpmVW82M1FGR0JiZ09sdUF3dEwvc3hueGRJOUZaR1hOTFMwRlF1WEJs?= =?utf-8?B?M1hKb2dOZ0h2dFVNZkhQOXRIb1FRdlpSMHhnU05lVDU4MDNLWUo1cnlYK2lu?= =?utf-8?B?Z0FBbUF0bGgybkFCdUV5TStRWkhXOW5YZXZGQ3c3cHJqNVI5NmVCWlg1aWpF?= =?utf-8?B?Ym9kaS9UNnB3a2tGT0o3WVJ0TFZDaHNMaTY0VFZoYTBkWDcybGJUbnNSZmZE?= =?utf-8?B?VnBnK1p2V2JDYkRYQlozemQ2UURKbXVyQVpTRTh4RXlCTG5ZTWk0QlFsZ01R?= =?utf-8?B?MkxMRHFWYnFZWktqWnZGZjdyWlFCTThtOW5iZnl2UlozQ2kvQU94L2xUVWVQ?= =?utf-8?B?a0tyOGc3cElCbFIwb0wvaG1kdEpWL1lQMEVwM1BaRlUzOE9yQlMwL2xja0Vu?= =?utf-8?B?OWJ0OVRvTEtwT09QcitCSS9OclBLSE13ZGI5akZ4enFzV2FwL3V1cnpZT2Rn?= =?utf-8?B?bjFRZTJPemFMVUpLcWVaRE41VXcxWDVMMEVLK1U4RnFhYVMwSmUySXdjRUVx?= =?utf-8?B?NWVKd3A1QTdkVVVWRDhMMWJWdjN3eGNuYWZHMk1kYklSVTRqZmpDZHVyYVhE?= =?utf-8?B?dGZsa01Zd1dLYjNOZEErZEJOMXJwNmlyMGMzZUtDTUJxd1NvYjJCZStYVHpa?= =?utf-8?B?dUYrci9ZS2ttT3doS1JRcWp0clJscURzNTR5NFQ2YVM5cm5hRkFDdjZNeGFm?= =?utf-8?B?Z3ZmUU1TdUp6RHdoRjFrUk5laU1EV1JqcUZrTDYwSFhHbkNUdFl5eXJyVVZE?= =?utf-8?B?YUxpN3RsQjNNTnRFWjFySi8vUGpSZ29lOUY0SGpYeVRtYlFtcmVDVy9SOXJi?= =?utf-8?B?MUhOdHVwMXA3NWF3VzFENVhWT0hUckc0TUx1bnFkYXRscDRiRVBFVnUrdmpo?= =?utf-8?B?bU1CMis4UFZTSS9ia2ZPa0hueFo5SGhtSjNUTDRaeDU1L1RBVlp3T2xUMEI5?= =?utf-8?B?RExKOGg0aUhMbUZVWmJ2UWRrWWM2Q0orYlZWNkYzWE5ka255MmFYUVEyQWZi?= =?utf-8?B?WTFxalJ4KzB5NFg1OUdUYUxOOWVHanJDbjJlQjVTUVdleTVwZjRienZJeGxC?= =?utf-8?B?b3hNckFWd0ZDSXFGdWFPdTVqNUVXeERwSVZJMnViZTQ4WFFsT25sUTc3azhF?= =?utf-8?B?bXRsUEcvVjlKNWJKbWh0S2duZTA5aVhJdzVsajhiay9meXNZM3pUdUJ1N3hE?= =?utf-8?B?VnZrdHVMR0VvUU90dW1OeU10ZFh6Y0JQczRxdnd2WjZSaGNHZFVzRTBZRkVk?= =?utf-8?B?dm9MaGpOYW5nTXpFblI0cytnMThFUjh5aTg1WWlaeDNRMmJ6U1Bvb2hZcUtC?= =?utf-8?B?OUZWakd1a0ppYXU2WWxHcE5pWGVheEFrMDdxQTN4M04zbXBEWUZGQXFaSUNB?= =?utf-8?B?UnlZVUhDZ1ZmVVdCWDQxVVovSHYxeFduQ20xWU9zTk1VbjdnN0czcmxRVmly?= =?utf-8?B?Y2FWdmJ5c0RqcHh3Y0xHTG1GeG9SdGtzcTBKQ3FUR201RXJUT2lPbnFQRm5N?= =?utf-8?B?eVIxNHFtaHZWN2wxNnVXRENXSzRtblJMdCtPeUtOZVdhSFV1K1gwZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efa7fd42-0989-4768-84bf-08da42de019e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:17:30.4778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i70nfoZ10ShPVex8MqF4TjKkOe8YECwpDPhYrlF+mPHSseQ16F1kDM+0dEePdV/omzxqh5wAzjqVSHxMx+N+/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4773 On 31.05.2022 08:57, Xie Xun wrote: > --- /dev/null > +++ b/xen/arch/riscv/xen.lds.S > @@ -0,0 +1,274 @@ > +/** > + * Copyright (c) 2018 Anup Patel. > + * All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2, or (at your option) > + * any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > + * > + * @file linker.ld > + * @author Anup Patel (anup@brainfault.org) > + * @brief CPU specific linker script > + */ > + > +#include > +#include At the example of this - how up-to-date a code base was this written / re-based against? The Arm version of this file, which likely would be the closest reference, makes use of e.g. the recently introduced xen/xen.lds.h. > --- /dev/null > +++ b/xen/include/public/arch-riscv.h > @@ -0,0 +1,182 @@ > +/****************************************************************************** > + * arch-riscv.h > + * > + * Guest OS interface to RISC-V Xen. > + * Initially based on the ARM implementation > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. > + * > + * Copyright 2019 (C) Alistair Francis > + */ > + > +#ifndef __XEN_PUBLIC_ARCH_RISCV_H__ > +#define __XEN_PUBLIC_ARCH_RISCV_H__ > + > +#define int64_aligned_t int64_t __attribute__((aligned(8))) > +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) > + > +#ifndef __ASSEMBLY__ > +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ > + typedef union { type *p; unsigned long q; } \ > + __guest_handle_ ## name; \ > + typedef union { type *p; uint64_aligned_t q; } \ > + __guest_handle_64_ ## name > + > +/* > + * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field > + * in a struct in memory. On RISCV is always 8 bytes sizes and 8 bytes > + * aligned. > + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an > + * hypercall argument. It is 4 bytes on aarch32 and 8 bytes on aarch64. > + */ aarch{32,64}? I understand that despite the base architecture having provisions for 128-bit mode, there's no intention to have provisions for this mode in the public interface? But perhaps at least #error on unsupported __riscv_xlen values? > +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ > + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ > + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) > +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) > +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name > +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) > +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name > +#define set_xen_guest_handle_raw(hnd, val) \ > + do { \ > + typeof(&(hnd)) _sxghr_tmp = &(hnd); \ Would be nice if new code could avoid cloning name space issues, like use of identifiers with leading underscores (which are reserved for use by file-scope objects/functions/macros). > + _sxghr_tmp->q = 0; \ > + _sxghr_tmp->p = val; \ > + } while ( 0 ) > +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) > + > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) > +/* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ > +# define __DECL_REG(n64, n32) union { \ > + uint64_t n64; \ > + uint32_t n32; \ > + } > +#else > +/* Non-gcc sources must always use the proper 64-bit name (e.g., x0). */ > +#define __DECL_REG(n64, n32) uint64_t n64 > +#endif What is this good for when ... > +struct vcpu_guest_core_regs > +{ > + unsigned long zero; > + unsigned long ra; > + unsigned long sp; > + unsigned long gp; > + unsigned long tp; > + unsigned long t0; > + unsigned long t1; > + unsigned long t2; > + unsigned long s0; > + unsigned long s1; > + unsigned long a0; > + unsigned long a1; > + unsigned long a2; > + unsigned long a3; > + unsigned long a4; > + unsigned long a5; > + unsigned long a6; > + unsigned long a7; > + unsigned long s2; > + unsigned long s3; > + unsigned long s4; > + unsigned long s5; > + unsigned long s6; > + unsigned long s7; > + unsigned long s8; > + unsigned long s9; > + unsigned long s10; > + unsigned long s11; > + unsigned long t3; > + unsigned long t4; > + unsigned long t5; > + unsigned long t6; > + unsigned long sepc; > + unsigned long sstatus; > + unsigned long hstatus; > + unsigned long sp_exec; > + > + unsigned long hedeleg; > + unsigned long hideleg; > + unsigned long bsstatus; > + unsigned long bsie; > + unsigned long bstvec; > + unsigned long bsscratch; > + unsigned long bsepc; > + unsigned long bscause; > + unsigned long bstval; > + unsigned long bsip; > + unsigned long bsatp; > +}; ... you don't use it anywhere? The use of "unsigned long" here needs to be changed anyway, as you need to express both views (rv32 and rv64), unless you mean to never support 32-bit guests. > +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; > +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); > + > +typedef uint64_t xen_pfn_t; > +#define PRI_xen_pfn PRIx64 > +#define PRIu_xen_pfn PRIu64 > + > +typedef uint64_t xen_ulong_t; > +#define PRI_xen_ulong PRIx64 > + > +#if defined(__XEN__) || defined(__XEN_TOOLS__) > + > +struct vcpu_guest_context { > +}; At least struct vcpu_guest_core_regs should have an instance in here, shouldn't it? Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:22:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339224.564046 (Exim 4.92) (envelope-from ) id 1nvx8y-0006RE-Sv; Tue, 31 May 2022 08:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339224.564046; Tue, 31 May 2022 08:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvx8y-0006R7-Pj; Tue, 31 May 2022 08:22:24 +0000 Received: by outflank-mailman (input) for mailman id 339224; Tue, 31 May 2022 08:22:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvx8x-0006Qj-SJ for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:22:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cadd93ad-e0ba-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 10:22:22 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-13-zzBRJ-5kPQ-xEZEzF10PcA-1; Tue, 31 May 2022 10:22:20 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4773.eurprd04.prod.outlook.com (2603:10a6:20b:10::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:22:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:22:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cadd93ad-e0ba-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653985341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4mGml9iN/Ky/RiMOrdboD8kbCJsxPinu45pIM4N7ZUQ=; b=FXuqMrK1PBal3uVQdW2AtGA9hpS1tC9BTbx8kAZY4ZSBYG1uox4NqUdCtFFmsk+C1Y24qN t3/r5PHpzcjVLLnjdFX+XbwMwaH58zabyDXZ5O+at6gvmjolmk0j3hMlnQglPctyPxg6e8 rCf9T15cYWIVhw6SwEO9XKeZSQtd7sA= X-MC-Unique: zzBRJ-5kPQ-xEZEzF10PcA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XiWyUQt4M2PHCaVwG11YnRU9IEcu0fuwWqV7axrmrY2tdLxN4uQEhTdy4Y0vWdZnW3p2udoZXDPmftzdW/bu7S1cKc+K8wpA1BfaLs9IxWoDacY9hoWQ0Y0/kVi3UhITReHg/LYaEATHiodgA5oXEd08pda0qmQIeALqa9hkImXhW3D1IvKnmJuqe8xaJv+MknXO/SrhuNIZhoikd7jmdvN6DUXLXT71kykzghbzvIwMSmH/T7y/Bjd7/a+OUP7fgc55HbDvMo8igvgFfFtHQw60QRPObdTbY3ndjEaVkelJ57dLvzMtsBgDz/NjCKCAStqdMxE9z+zb7tjTk+RO1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4mGml9iN/Ky/RiMOrdboD8kbCJsxPinu45pIM4N7ZUQ=; b=X6XQjAR5SkEaiJQIy4DCMcOYfyjeztU2KqGAhPpNuKD41Wty3sivnEUsbyxYEflLMGz1NDOQtjztEO6y2Q7PWuRN6Yx5jmfaEJFvgqXBteuW3rgkIrVsHuKN7FD7f5oUXerrcFxU34hdH4hJ6nFkkPijqGZr3YP5ShHHk2IH4RHCIbKxJOPrOllhnwWio0eYg3Pi+Jy0g1jamTT5FTEOrbmn0ikGL9+GD8FDBanpGDAp3KFfR0Lo8uLaofj7rP4l5zhqAaBb3Q/5lpidbMIGKrvv9mEbmlUS7OBxich74o2YH9k4d4mx4T4/rCCQDYcNajnLgsVGgZ4lpd0Q6Ivp0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <18765793-1fdb-34e8-a669-5c799df94345@suse.com> Date: Tue, 31 May 2022 10:22:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: PING: [PATCH v7 0/2] Adds starting the idle domain privileged Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, xen-devel@lists.xenproject.org References: <20220511113035.27070-1-dpsmith@apertussolutions.com> <0c894277-85c1-faa7-a360-a82531733f12@apertussolutions.com> From: Jan Beulich In-Reply-To: <0c894277-85c1-faa7-a360-a82531733f12@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0080.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad272b2e-de6d-4c48-dd76-08da42dead7b X-MS-TrafficTypeDiagnostic: AM6PR04MB4773:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MRhFtov83UxwWgOdrzsXY6M9qbneqnjUO6WRT14EfKJsHdNkombQBz0J6HzhsqN0FxxSRyuWX2enzVUg2jqnSFjykFNEcQeHpB9Hs2UZDSOKPaatv0pzrCpLXvDqAxDflJo+4RoyHSluPPBQDAweiuoW11XFZz/gmkd+9m1Ot0ylBGl0RQitLQaUoy2G41F7qNTmhpyYKu5LrI2Y56erzhT14d6rk/onymaBCkOFwot4ahXjSZcvDPWftEzd//q2WVKvE2cMqe6E4Y8wJyleq0UCI5wfZJwE5K5eSymdQPVL7gHaptMs4q9/OxRPhe7xtaRVLH69FFnrxIGLz4+NV0FFCZWhyCVtzhhKYqvnkxUxN0TYdfreRBnOnECDExC23iXadAW3BaKruPMABBLnKzbgDC2q35n1RdaxU23SPlIQFRHybtUeGD/eGRgweNXEMmnFHA0eaLilPFcyzMGlXUVhfQKH7yPhyeBmUAuY87+I28krHT07V0roFszef4XFUlKuLH2EG2ZcRHHlvQYPXX09Z0v2eTfibHnzhIATJKyYqqRLpCCiMrA1bXlXg0NqfFQCXS9+JCpcJvJOPYAi6+a0v4crx67gOncJLWx4W5yaTghgB2DeCxloBssuShNzidyA8mC55liP7m3jYjWKL4Zfdw1rsNbpTILOY+AV6BO+SQiHML8iQxPaiqXyq6+/fQhbBb1OEpdaYjXAlM0mNSD2+FE0BcOI+iP/SoorIUA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(38100700002)(86362001)(31686004)(5660300002)(66556008)(66946007)(66476007)(4326008)(83380400001)(8936002)(36756003)(8676002)(2906002)(6916009)(316002)(2616005)(4744005)(6512007)(6506007)(26005)(53546011)(508600001)(6486002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2JpY0F3Ym1Ud0hYdnFGc003M29SSzI0bXlycE0zQnI1d2dFM2xLOE5SOFd2?= =?utf-8?B?dy96cXI3NXNvTzAvZDBiT2prT0hUL0s3MG1rUjR6VEhkazFzWmVyTEZGMURT?= =?utf-8?B?U0ppbFZUenhNdmxYRmJ6RldtTHVwMDBnV0FsUlcyM1Jna203eG5QYWcxdWhO?= =?utf-8?B?RUdTaTR3SFEyWnVaZkV6QjRFUUNhOGhhZzNOZ2YxaVVrZkNlUWdKRUpkUWlZ?= =?utf-8?B?NnM3UXV1MFFFM1BzOU9kWFBxa21aSjlEcmtObnl2cmRiODU4YjZqVllNTzdr?= =?utf-8?B?NXdtaEsvY1pndElHMHdvYTNZT3IwUkxhMGRsUnNZK3JDMnFkSmhNWVA4U29h?= =?utf-8?B?cUNxZE1aK3RVclJ6WFhiSHlzWlY1R21EMkxCV2U0L2Rpak5kWFp5alRPS3hs?= =?utf-8?B?aStxZnhFZHVxYWdqaHArMUgvaGszMnZVVkpvZE1FM25ZUSthelZFdkNBWnZC?= =?utf-8?B?MW9PakswUTRDRjRZTW1DaEZyNlZ0emd4ZXd2aklEK0JsMHNjeldBdWpJbjQy?= =?utf-8?B?TjVHRENRSkh5K0JLRmk4R0VCY053eFJycDY1Q2VPNWd3b1BKUGxlS2ZJc1dj?= =?utf-8?B?aFJtMXNDaW5pem82a0lMNDAyaytoQkp5c1pBMWtTRjJ2Z1VwZWVHOFM5cjhE?= =?utf-8?B?T0NRSGp3UGdtZ2xCZXJvbkRuOVhqbGp3SDdlV0laZXN2bDJ0M01LYmt2Umt2?= =?utf-8?B?dGRyK1gyTE5LRmhQYUEzMGFldFlHdXBuWVFmSTlnQUQ5Nzc2U2l3enJlOXZI?= =?utf-8?B?ZlRkSmFVT1hzY0xLUUZ1S1NKTkIvc21zZmRxM29SeXJUSHFKYW1Dc1lIejB5?= =?utf-8?B?VTc3ODNmSFBORUFwRmlOd3BKaWN4SWo1RUZ2TEFieHY1SWFQWnhUQ1U5N1Jm?= =?utf-8?B?UTA4cDd1SnpSdnVsdFJRUGRFQVE0SUo3VFFRRFdreHJxSk1GZ1dwSGF0ZW5X?= =?utf-8?B?YXQyRmNrZk1BUGdJbGphU0NOeDZtVTZ3Yk5OcElDQnp2RWJaZEdNdmVTUmIy?= =?utf-8?B?VVp1c0VscURuck1PWEZ6RkgrZXl6U0lBdkNLQjFrVTlGSVZyaXkxNE9Fd0Za?= =?utf-8?B?U3ltK21mK1pHRnJyQlF5dlp4S3A2cHo2bmMwWTJoUG9BL0xWU01GZitzdWU5?= =?utf-8?B?UVFRelJqRVBMeWk1OTVEdUxmelFHejRNTEVxdmxKdFZaY05ORGgyekxMVkZz?= =?utf-8?B?enJiM2pJaXVUOU03UFlWQ3FKdHFvNFMreVFReU1obVY2T1kvcC83QTJIcERk?= =?utf-8?B?MzhlL1o1cmV5QUdURVQyNWc4OEIvMVI3V3JMTzM3anF5TGJJTjVZenlHR1V1?= =?utf-8?B?Wk9EM25uV2NlM3prUUZRV1ZZQVlkeFBCNDF3bllBYzVmejNqcXFqMHY1dEpr?= =?utf-8?B?NDhROXloTnVMdXBXektjdVhONVloQ3htZk95NGpaRkZtK041SlNvOFR1aFJ5?= =?utf-8?B?M2RGd3ZCbW9tbkFNdjV4ZUp6cFVScHBQRE5LOCtaem1uTzFIdlgvSjQwSFg3?= =?utf-8?B?eTVYSDExUWd3ekdXY3YrNkRLRTFEa0J2eXdlWGJGVnN5b2tXZmdBUFFvdFpZ?= =?utf-8?B?WHlQNnNPTWh5R1REQWZPWERDVnhRU1hVUDJlQzYzWFRZRkxrdVpLMWJQV09K?= =?utf-8?B?TmttMS9YcmhJblphNDhjcW5CRjJRWXdYRkJYcGp0alE5SXJ5bmtNZC9OUWl2?= =?utf-8?B?b3ZYZUg2bmw1T3Z5RnY0ejJpY0FQeTIwV0w4NUMvRGVQc0lhZlA1czNwVnpv?= =?utf-8?B?L1ZEcHk0MFlSWFpTVFU5eUU4SVlscFFKd084ZElGOFNYTEJpcmFnQnB0aTVT?= =?utf-8?B?b2tIZnpOSkJOVC9IT0V6SCtLaktoQVJZUVlad2VRL1NEcEZqR0Y5clh6N0sy?= =?utf-8?B?QkgrRHNmV3NZcUgvMUtUOEF6WitBNkRCWTErM0pDUEtyZGZSM25mL2V0Vzhy?= =?utf-8?B?alp2dmRJYk1LOXdNMmlFTUFMR0J6eC9PbXgwazE3enh0NG5kYnNVNlVvaFpo?= =?utf-8?B?d05MbDNmRkc2d3R3RUxjTWRIbCt3cnpZNi9mcHpuMWJFY0lJb013VDJxTmlM?= =?utf-8?B?V3VjV2FEcDRWanpKb2hqSnBJb1cwaklMaCtqQlRSVHNKNmQvRThHZEJ4VUYz?= =?utf-8?B?QmhiM3FwWUh1SktyYTF3Qy9yNGhaaVVLQTdlNDYwdFFnV25hQUxVRXBxbDA5?= =?utf-8?B?c2dyaE05OEEvSTA0WEhZYTFnVDkzc0txMTN6RnQ4bkxCSmdRSUJucitSclBa?= =?utf-8?B?VWg0cUNhM2gyRENTRDBjVGEwZHYvTU55TG9RUVJQREpjbW11bTJzZ3BpMStP?= =?utf-8?B?USszczhxZVE5RDJqUzhoK1YwQ1l5Z0xZTENJcUZRUUliS25LTEsxUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad272b2e-de6d-4c48-dd76-08da42dead7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:22:18.9439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wk8xPeS8cVVOnGazcx6r0Ys6wF8u9X0wyyO5vN/6vN3hizYkzEIvLoIE3wbcvKMbe894Qbi+FIO6Y/4Y8sEC+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4773 On 30.05.2022 19:15, Daniel P. Smith wrote: > > On 5/11/22 07:30, Daniel P. Smith wrote: >> This series makes it so that the idle domain is started privileged under the >> default policy, which the SILO policy inherits, and under the flask policy. It >> then introduces a new one-way XSM hook, xsm_transition_running, that is hooked >> by an XSM policy to transition the idle domain to its running privilege level. >> >> Changes in v7: >> - adjusted error message in default and flask xsm_set_system_active hooks >> - merged panic messages in arm and x86 setup.c to a single line >> > > Pinging to see if there are open issues I need to address or is the > series acceptable? IIU I am missing an ACK on patch 1 of the series from > x86 and sched maintainers. And a REST maintainer ack (to stand in for the designated maintainer continuing to play dead). Also I notice your ping did include neither x86 nor sched maintainers as (at least) Cc. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:25:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:25:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339235.564057 (Exim 4.92) (envelope-from ) id 1nvxBQ-00074G-BV; Tue, 31 May 2022 08:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339235.564057; Tue, 31 May 2022 08:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxBQ-000749-8r; Tue, 31 May 2022 08:24:56 +0000 Received: by outflank-mailman (input) for mailman id 339235; Tue, 31 May 2022 08:24:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxBP-000743-Bi for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:24:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxBO-00079a-LH; Tue, 31 May 2022 08:24:54 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvxBO-0004pR-Bp; Tue, 31 May 2022 08:24:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Du5xHSul6RTd8t8x6Gk6tSf9s/tzR3JxR6fxZf5RDbM=; b=ngY16bBDFMdCl8L2LeBWdpK8Up 4gln1o5OL43QSekO2/QtCOqPrMUqVA5eyCIVk/LqaKZF4F9fSMU6/JFAG5eexUiMfSdyct2h3Jnw9 pJSsUR/bbinOchwVEGYmQHtcIQidurY2jYpyoFpnHaEjD0Cm91nkvXVrByXeDBMfv7NU=; Message-ID: <767b6984-8b35-4aff-a0e4-4b16dadf228e@xen.org> Date: Tue, 31 May 2022 09:24:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 1/6] xen/riscv: Add necessary headers and definitions to build xen. To: Xie Xun , xen-devel@lists.xenproject.org Cc: Bob Eshleman , Alistair Francis , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Juergen Gross References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xie, Thank you for the contribution. On 31/05/2022 07:57, Xie Xun wrote: > Target xen and xen-syms can be built with: > > $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- tiny64_defconfig > $ make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- > > It can be tested with Qemu. > > $ qemu-system-riscv64 -machine virt -m 1G -kernel xen > > Xen will jump into an infinite loop and there will be no output. I will answer here what you wrote in the cover letter: "There are some problems though. The first patch of this series is very large, but it seems most of the code is necessary for building xen. I am trying my best to remove some code but it still has more than 8000 lines of code." I think it would be beneficial to split this patch in smaller logical one even they don't build one by one. Briefly looking through the series, it looks like some code (such as the atomic) was imported from another project. So you could move them in one (or multiple) separate patch. Also, if you took code from other project, it would be good to specify where this coming from and what was the baseline. This will help to re-sync the code in the future. > > Signed-off-by: Xie Xun > --- > xen/arch/riscv/Kconfig | 2 + > xen/arch/riscv/Makefile | 51 ++ > xen/arch/riscv/Rules.mk | 57 ++ > xen/arch/riscv/delay.c | 14 + > xen/arch/riscv/domain.c | 191 ++++ > xen/arch/riscv/domctl.c | 52 ++ > xen/arch/riscv/guestcopy.c | 59 ++ > xen/arch/riscv/include/asm/acpi.h | 9 + > xen/arch/riscv/include/asm/altp2m.h | 39 + > xen/arch/riscv/include/asm/asm.h | 76 ++ > xen/arch/riscv/include/asm/atomic.h | 375 ++++++++ > xen/arch/riscv/include/asm/bitops.h | 397 ++++++++ > xen/arch/riscv/include/asm/bug.h | 67 ++ > xen/arch/riscv/include/asm/byteorder.h | 16 + > xen/arch/riscv/include/asm/cache.h | 24 + > xen/arch/riscv/include/asm/cmpxchg.h | 382 ++++++++ > xen/arch/riscv/include/asm/config.h | 149 ++- > xen/arch/riscv/include/asm/cpufeature.h | 68 ++ > xen/arch/riscv/include/asm/csr.h | 81 ++ > xen/arch/riscv/include/asm/current.h | 41 + > xen/arch/riscv/include/asm/debugger.h | 15 + > xen/arch/riscv/include/asm/delay.h | 28 + > xen/arch/riscv/include/asm/desc.h | 12 + > xen/arch/riscv/include/asm/device.h | 93 ++ > xen/arch/riscv/include/asm/div64.h | 23 + > xen/arch/riscv/include/asm/domain.h | 80 ++ > xen/arch/riscv/include/asm/event.h | 42 + > xen/arch/riscv/include/asm/fence.h | 12 + > xen/arch/riscv/include/asm/flushtlb.h | 56 ++ > xen/arch/riscv/include/asm/grant_table.h | 93 ++ > xen/arch/riscv/include/asm/guest_access.h | 125 +++ > xen/arch/riscv/include/asm/guest_atomics.h | 62 ++ > xen/arch/riscv/include/asm/hardirq.h | 27 + > xen/arch/riscv/include/asm/hypercall.h | 12 + > xen/arch/riscv/include/asm/init.h | 42 + > xen/arch/riscv/include/asm/io.h | 283 ++++++ > xen/arch/riscv/include/asm/iocap.h | 16 + > xen/arch/riscv/include/asm/iommu.h | 46 + > xen/arch/riscv/include/asm/iommu_fwspec.h | 68 ++ > xen/arch/riscv/include/asm/irq.h | 62 ++ > xen/arch/riscv/include/asm/mem_access.h | 35 + > xen/arch/riscv/include/asm/mm.h | 320 +++++++ > xen/arch/riscv/include/asm/monitor.h | 65 ++ > xen/arch/riscv/include/asm/nospec.h | 25 + > xen/arch/riscv/include/asm/numa.h | 41 + > xen/arch/riscv/include/asm/p2m.h | 307 +++++++ > xen/arch/riscv/include/asm/page-bits.h | 14 + > xen/arch/riscv/include/asm/page.h | 319 +++++++ > xen/arch/riscv/include/asm/paging.h | 16 + > xen/arch/riscv/include/asm/pci.h | 31 + > xen/arch/riscv/include/asm/percpu.h | 35 + > xen/arch/riscv/include/asm/processor.h | 176 ++++ > xen/arch/riscv/include/asm/random.h | 9 + > xen/arch/riscv/include/asm/regs.h | 42 + > xen/arch/riscv/include/asm/riscv_encoding.h | 960 ++++++++++++++++++++ > xen/arch/riscv/include/asm/setup.h | 23 + > xen/arch/riscv/include/asm/smp.h | 69 ++ > xen/arch/riscv/include/asm/softirq.h | 16 + > xen/arch/riscv/include/asm/spinlock.h | 13 + > xen/arch/riscv/include/asm/string.h | 28 + > xen/arch/riscv/include/asm/system.h | 98 ++ > xen/arch/riscv/include/asm/time.h | 81 ++ > xen/arch/riscv/include/asm/trace.h | 12 + > xen/arch/riscv/include/asm/traps.h | 30 + > xen/arch/riscv/include/asm/types.h | 73 ++ > xen/arch/riscv/include/asm/vm_event.h | 63 ++ > xen/arch/riscv/include/asm/xenoprof.h | 12 + > xen/arch/riscv/irq.c | 126 +++ > xen/arch/riscv/lib/Makefile | 1 + > xen/arch/riscv/lib/find_next_bit.c | 285 ++++++ This is a copy from the Arm version, right? If so, please move the Arm one in common/lib/ so you can re-use it. > xen/arch/riscv/mm.c | 409 +++++++++ > xen/arch/riscv/p2m.c | 97 ++ > xen/arch/riscv/percpu.c | 84 ++ > xen/arch/riscv/platforms/Kconfig | 31 + > xen/arch/riscv/riscv64/Makefile | 2 +- > xen/arch/riscv/riscv64/asm-offsets.c | 39 + > xen/arch/riscv/riscv64/head.S | 13 +- > xen/arch/riscv/setup.c | 65 ++ > xen/arch/riscv/shutdown.c | 24 + > xen/arch/riscv/smp.c | 38 + > xen/arch/riscv/smpboot.c | 78 ++ > xen/arch/riscv/sysctl.c | 31 + > xen/arch/riscv/time.c | 69 ++ > xen/arch/riscv/traps.c | 87 ++ > xen/arch/riscv/vm_event.c | 51 ++ > xen/arch/riscv/xen.lds.S | 274 ++++++ > xen/include/public/arch-riscv.h | 182 ++++ > xen/include/public/arch-riscv/hvm/save.h | 39 + > xen/include/public/hvm/save.h | 2 + > xen/include/public/io/protocols.h | 3 + > xen/include/public/pmu.h | 2 + > xen/include/public/xen.h | 2 + The public headers could be moved separately. [...] > diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig > index 468e250c86..e8c9ae6219 100644 > --- a/xen/arch/riscv/Kconfig > +++ b/xen/arch/riscv/Kconfig > @@ -1,5 +1,7 @@ > config RISCV > def_bool y > + select HAS_PDX > + select HAS_DEVICE_TREE The indentation looks incorrect to me. Kconfig is using hard tab rather than soft tab. [...] > diff --git a/xen/arch/riscv/Rules.mk b/xen/arch/riscv/Rules.mk > index e69de29bb2..85e0cc5e64 100644 > --- a/xen/arch/riscv/Rules.mk > +++ b/xen/arch/riscv/Rules.mk > @@ -0,0 +1,57 @@ > +######################################## > +# riscv-specific definitions > + > +# > +# If you change any of these configuration options then you must > +# 'make clean' before rebuilding. > +# > + > +CFLAGS += -I$(BASEDIR)/include > + > +$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) > +$(call cc-option-add,CFLAGS,CC,-Wnested-externs) > +$(call cc-option-add,CFLAGS,CC,-mstrict-align) > +$(call cc-option-add,CFLAGS,CC,-mtune=size) > + > +EARLY_PRINTK := n > + > +ifeq ($(CONFIG_DEBUG),y) > + > +# See docs/misc/arm/early-printk.txt for syntax > + > +EARLY_PRINTK := 8250,0x1c021000,2 Is the UART standardized in RISCv? > + > +ifneq ($(EARLY_PRINTK_$(CONFIG_EARLY_PRINTK)),) On Arm, we converted the early printk to Kconfig. I would recommend to do the same because otherwise the user would have to specify the option on most of "make" options. This lead to quite a few errors on the Arm side. > diff --git a/xen/arch/riscv/delay.c b/xen/arch/riscv/delay.c > new file mode 100644 > index 0000000000..4a712e97e8 > --- /dev/null > +++ b/xen/arch/riscv/delay.c > @@ -0,0 +1,14 @@ > +void __delay(unsigned long cycles) This doesn't seem to be used in the common code. How did you decide what was needed? I am asking that because I think it would be good to avoid adding helpers that will never get used. > +{ I am assuming this is going to be implemented at some point. At minimum, I would recommend to add a TODO. But I would also consider to add ASSERT_UNREACHABLE() so anyone can notice when you use a function that has to be implemented. This is less a problem for function like delay. However... > +} > +EXPORT_SYMBOL(__delay); > + > +void udelay(unsigned long usecs) > +{ > +} > +EXPORT_SYMBOL(udelay); > + > +void ndelay(unsigned long nsecs) > +{ > +} > +EXPORT_SYMBOL(ndelay); > diff --git a/xen/arch/riscv/domain.c b/xen/arch/riscv/domain.c > new file mode 100644 > index 0000000000..c99023731f > --- /dev/null > +++ b/xen/arch/riscv/domain.c > @@ -0,0 +1,191 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +DEFINE_PER_CPU(struct vcpu *, curr_vcpu); > + > +struct vcpu *alloc_dom0_vcpu0(struct domain *dom0) > +{ > + return vcpu_create(dom0, 0); > +} > + > +void context_switch(struct vcpu *prev, struct vcpu *next) > +{ > + /* TODO */ ... you may have hard time to debug some of those functions here. > +} > + > +void idle_loop(void) > +{ > + /* TODO */ > +} > + > +void noreturn startup_cpu_idle_loop(void) > +{ > + struct vcpu *v = current; > + > + ASSERT(is_idle_vcpu(v)); > + > + reset_stack_and_jump(idle_loop); > + > + /* This function is noreturn */ > + BUG(); > +} > + > +void continue_running(struct vcpu *same) > +{ > + /* TODO */ > +} > + > +void sync_local_execstate(void) > +{ > + /* TODO */ > +} > + > +void sync_vcpu_execstate(struct vcpu *v) > +{ > + /* TODO */ > +} > + > +unsigned long hypercall_create_continuation( > + unsigned int op, const char *format, ...) > +{ > + /* TODO */ > + > + return 0; > +} > + > +struct domain *alloc_domain_struct(void) > +{ > + return NULL; > +} > + > +void free_domain_struct(struct domain *d) > +{ > + /* TODO */ > +} > + > +void dump_pageframe_info(struct domain *d) > +{ > + /* TODO */ > +} > + > +int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) > +{ > + return 0; > +} > + > + > +int arch_domain_create(struct domain *d, > + struct xen_domctl_createdomain *config, > + unsigned int flags) > +{ > + return -ENOSYS; > +} > + > +void arch_domain_destroy(struct domain *d) > +{ > + /* TODO */ > +} > + > +void arch_domain_shutdown(struct domain *d) > +{ > + /* TODO */ > +} > + > +void arch_domain_pause(struct domain *d) > +{ > + /* TODO */ > +} > + > +void arch_domain_unpause(struct domain *d) > +{ > + /* TODO */ > +} > + > +int arch_domain_soft_reset(struct domain *d) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +void arch_domain_creation_finished(struct domain *d) > +{ > + /* TODO */ > +} > + > +int domain_relinquish_resources(struct domain *d) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +void arch_dump_domain_info(struct domain *d) > +{ > + /* TODO */ > +} > + > +long arch_do_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +void arch_dump_vcpu_info(struct vcpu *v) > +{ > + /* TODO */ > +} > + > +int arch_set_info_guest( > + struct vcpu *v, vcpu_guest_context_u c) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +/* taken from arm/domain.c */ > +struct vcpu *alloc_vcpu_struct(const struct domain *d) > +{ > + return NULL; > +} > + > +void free_vcpu_struct(struct vcpu *v) > +{ > + /* TODO */ > +} > + > +int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +int arch_vcpu_reset(struct vcpu *v) > +{ > + /* TODO */ > + return -ENOSYS; > +} > + > +int arch_vcpu_create(struct vcpu *v) > +{ > + return -ENOSYS; > +} > + > +void arch_vcpu_destroy(struct vcpu *v) > +{ > + /* TODO */ > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/riscv/domctl.c b/xen/arch/riscv/domctl.c > new file mode 100644 > index 0000000000..5024118662 > --- /dev/null > +++ b/xen/arch/riscv/domctl.c > @@ -0,0 +1,52 @@ > +/****************************************************************************** > + * Arch-specific domctl.c > + * > + * Copyright (c) 2012, Citrix Systems > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +void arch_get_domain_info(const struct domain *d, > + struct xen_domctl_getdomaininfo *info) > +{ > + info->flags |= XEN_DOMINF_hap; > +} > + > +long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, > + XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > +{ > + /* TODO */ > + > + switch ( domctl->cmd ) { > + case XEN_DOMCTL_cacheflush: > + case XEN_DOMCTL_bind_pt_irq: > + case XEN_DOMCTL_unbind_pt_irq: > + case XEN_DOMCTL_vuart_op: > + default: > + return 0; > + } You are not implementing any of those domctl yet. So I think it would be better to print an error message (gprintk(XENLOG_ERR...) and return -ENOSYS. > + > +#define write_atomic(p, x) ({ \ > + typeof(*p) __x = (x); \ > + switch ( sizeof(*p) ) { \ > + case 1: writeb((uint8_t)__x, (uint8_t *) p); break; \ > + case 2: writew((uint16_t)__x, (uint16_t *) p); break; \ > + case 4: writel((uint32_t)__x, (uint32_t *) p); break; \ > + case 8: writeq((uint64_t)__x, (uint64_t *) p); break; \ > + default: __bad_atomic_size(); break; \ > + } \ > + __x; \ > +}) > + > +/* TODO: Fix this */ What's the problem? > +#define add_sized(p, x) ({ \ > + typeof(*(p)) __x = (x); \ > + switch ( sizeof(*(p)) ) \ > + { \ > + case 1: writeb(read_atomic(p) + __x, (uint8_t *)(p)); break; \ > + case 2: writew(read_atomic(p) + __x, (uint16_t *)(p)); break; \ > + case 4: writel(read_atomic(p) + __x, (uint32_t *)(p)); break; \ > + default: __bad_atomic_size(); break; \ > + } \ > +}) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 31 08:25:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:25:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339242.564068 (Exim 4.92) (envelope-from ) id 1nvxBy-0007d0-No; Tue, 31 May 2022 08:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339242.564068; Tue, 31 May 2022 08:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxBy-0007ct-L2; Tue, 31 May 2022 08:25:30 +0000 Received: by outflank-mailman (input) for mailman id 339242; Tue, 31 May 2022 08:25:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxBx-0007Ou-7u for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:25:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a029da5-e0bb-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 10:25:28 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-16-EslTSaQ3NrCctrbHjE4sTg-1; Tue, 31 May 2022 10:25:25 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5396.eurprd04.prod.outlook.com (2603:10a6:208:116::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:25:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:25:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a029da5-e0bb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653985528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XiG6PFZfhjVGsIA/wdDcU84fErX3fpItHievOS/np0w=; b=lTTNLTHJIWCxHck3a4a0agCn+w6VayzNMlIyJh1tjxE+tfVsX7R5Od7J30rXJOlCGxLSMs VLLz8xzYFYJECn+XfhnRYRagAGvXrKnx3OBnQ87I2ycGRxNLQwNPwitCdlLNC2KWJA5VLv c1R5VMgO7A6A7BrW3XEYckMcQfxxAdQ= X-MC-Unique: EslTSaQ3NrCctrbHjE4sTg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aipddmgkwVdHdZtf2wqN1R0q6r4txLSsdCtKp8QnJprjeDmGGQwTNIu1ttY8ZZoVrCuGRAX9SZFc+X//dbAI9lWZKaGl4dab024appP/AHwh/qEgYI7OIXEC6yicsJNCqpiGnp1CNGPGq6rfkCNFQqP73Ji6ciOQla3eMv2DBScxHd0I8tk2HSrdPCLNEGCTdmaAtRe4YKkc5sFzoC+mZ37FLGO2qvvw3q8hyQ0fzMLV6bfhqmuNhh4PhOeEsKX5BIA+Z3DzOgDjXs+jnpsWwuB0BUlYVwAYDak3OSVMCO5lZ/8fjJn0DDlvgHlexrkjrQffQHTc6X8yNrXf8B8xXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XiG6PFZfhjVGsIA/wdDcU84fErX3fpItHievOS/np0w=; b=mAoQKyzehSjfAX7avLBJRLYHVy8UoazmKrgG/1S/JwZgazV525Gh824U4OrzP1ivHYyj+DdNy3j39S+vpjCHfmCAXQxxS9bgZ5vX83vyYpqzRVW162PFK3zR8uiyh3lB1lq4MqmVkMQHR8bfwX1TP7RehIBaCLEcIRnNX3/7nyELCQ/LkcI/ZgtgElpul8tGsY5QP6xIodA53iPEv4AUWpfr/PyvAB6iGcicYRGNFt0d1yGbeA2K6h4V0pL5fAwqE+GBPOfhmaC72FWy1kk5+n9XeSQgaO+Co2cEKFPH8g8qvy0tPJVXdI8w1de3n/jRfZjfFOr6h3djK6qf/l0XNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 10:25:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [v2 0/3] xsm: refactor and optimize policy loading Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220531023945.22196-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220531023945.22196-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0201CA0015.eurprd02.prod.outlook.com (2603:10a6:203:3d::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c9ae122-8885-45f4-f6c5-08da42df1c03 X-MS-TrafficTypeDiagnostic: AM0PR04MB5396:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8P5AmW42s5yzD6mfqcwkoZbs7YB2vhNzYs7M+ajNx4fsBytrjzXygCx6RzYiO0mKBynuceay3Ra1jU9tVvez2b427/+1cKfRwODgaParo+2duA5/aLyGzNZ/SSC7Ty3kVdOhJDL6Z6dAQJmD9lqHOtphcKjhS7KpcukSrhQh3ZaOKEJy54YgtfLnw8Dq0eGc7E7IEpcB3tWrIGpN5+UMTcrmEftiQdvK64rCiv/PDPKP2TYxLXHGb0WY4UcSlb8QwU11thqDRuGeGpmS0gK23blFMmhhGhdAsoXJU7XY7oHRiAqpWuWFwvbJAwar9w+MqNSVD/La21NCwb7L9ObJ9Y77TqKBYBC9fLHhHLL4rrvF009RMvyw5Bp5nvOiH8O9lXmAaYtsbB9bxz42+hnRvAjNthwGInyuvFYBqP63vccjNiGMZ+ueUQ4CQZ1756EDh8eOpYkfFAUFZBVk08+Ip2ucCxCYCLDj0Lek2cfztyOaStyTTOXFNxlyNI11i5IVYpVXGucligeBRFEXR+IceV8iwQWZxezULDn8sptL2RZYpkXnSgNtBvuhgXLRtMy9yfqwlbnpBN1OsEXZYh4NFEQqsCOMN2Y/MqWe+lYvIoW0DZQ9fJ6Yz1EJ/NWTAOMDzWENyBwvIk9NNHKT+VNwyelZbgwCVpGsRiBinDE8bFc0a5WBVJgq4WCmjyZ8h8geUwy0W8KRSn8UYCVFbde6VlDtAyz/ERUXx44SsCo0ZOLG9ltASVac6M0Wq1O+kswy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(36756003)(508600001)(31696002)(66946007)(66556008)(186003)(4326008)(2616005)(86362001)(2906002)(38100700002)(31686004)(6506007)(26005)(6512007)(5660300002)(8936002)(53546011)(6486002)(4744005)(6916009)(316002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHJRdFp4Y2d1R3hDREZCMnNWOHdFZkk3U3ZCcFd6OHdNdEErU3RpemxhMU1z?= =?utf-8?B?QjlKVHcyQktJQ3dJVlJzbjF4ODFZVm5qOG9aU0RydUpSREFUTCtDNnNKbkNO?= =?utf-8?B?bFJXRDREVitIM096SlM2aEZuanZ3eDg2emtvQ2J6dFpYOEIwZFAzVjFsNkNM?= =?utf-8?B?MzZHTmgrS0VhNHZPdE5Vd1lNeVVkN0N1YkFBa3BDVE0rYUpQSkVFa1B5M2FP?= =?utf-8?B?VWlqc2VhQ0x6ejZkNnFOUlcvaEtTL1ZMOXMvTCtNS2o4RmtVeHo5RFJUdXBw?= =?utf-8?B?YWNIZGcxRzJHa2J5cTA3Z2NIZXYvNmxIZ1k4RGVrNmpsaGJJQ1lvTlJsV2c2?= =?utf-8?B?aEdXaHdwc2lhOHRLTWkzekh1Nm9ROGNabUpXUU1LTUo0dFBzREhTeGRleDJt?= =?utf-8?B?ZkxSRHdzNlVMWTJ4Vjk3NmZxVEdvU3c5WERmcVB2Vm5ESmhnTHIwZTJ2U1NX?= =?utf-8?B?Ynd0Wm9qa2tIQzVkMW5sVEt2Y0lvUVJlVjFwMmV1MWF0dGhQUHVKL3FiclZk?= =?utf-8?B?QmNXU3BWR3JZZGlOWG95aTRPVzZOQU16b011S3hqKzdVWjBXTnpvbkdJZ2VE?= =?utf-8?B?dnNOVnk3NG9MVmpWVjhjamNoUXZsKzVzMWQvN3ZxcTF4QS8zZmRpVU9hMTFr?= =?utf-8?B?SC90RUVFUFNQZVJDOG9PdmJIRmJ4Sm1EdHk5U2N1bnlCNDJpRFFDbnZUeEgx?= =?utf-8?B?d0w1akhveVNRS2ZmMzVRVW1SbkFjTENPWEhPRG1GaVdNQzE2Rm44SjN2azll?= =?utf-8?B?TU0wTkNiSkZzTkdIQXBrQzdXNTFvNlJBUnc1N2RvUVRVNE5waWp4Z2dLMytH?= =?utf-8?B?RGxhWnpaOHRSM2J6WGprNGZHY25jTGdLUGxtSnRTTHZYcXo0RUNBdWE5ditH?= =?utf-8?B?Q0xqYWU1YW9wYkx5b2Rya2lhVXhHVlBBNVdzNTFsM3RhaGRWMXU3eGlOSkpm?= =?utf-8?B?alRXNkRWdEdqMVNZR2h5Y0pudmZJTTJVNTZ2b3cyQm5OZWNwUVI1S1lCQzZ0?= =?utf-8?B?YW5OUFV0SGUzOGdjK3hlZlVQV0hEc2hMVSt0RWxPbDlSVHBJVWpOM3NKeWk0?= =?utf-8?B?R1Y4ZGUyT01qMDcrTDlML2llYThEb0QwVHBsYkRmM1J2ZWx3enpkTFVMSXdq?= =?utf-8?B?ME5zVENsdEJlcnN5OEtibDJ6dFdYVFVWd2RtMlpBb0hLMTYvYkNtZXdkQmw2?= =?utf-8?B?amovczNDejJxeWdzVGdwanNCSEErSjVnMjNzZFpqa29nT0t0dzlyQ3N2SHV1?= =?utf-8?B?dEt0WU9vaEg0N2pYU1c1SjFSdkY5QTVxbExGS1p4K3RXTzdHZDZXUXlBQ1hH?= =?utf-8?B?NmlQelJuMGFtYzBGdW9rbVFObDRDT2ZSb3hiSloxTUk0elFZUTRLaFhKVUZC?= =?utf-8?B?ZUZ3QXRUMzl3M1dGbHgvb1VIbWFCNUZmZG5yd1dFN1ZzWU9rMGQzY2VsaGhU?= =?utf-8?B?M0tLS3RkUVZtaEZrbU1jT0lBQmEydmFZTGJSN1BvbWFud0JvaU00UTNwQzNz?= =?utf-8?B?dlJQQzFEZ08xdmR0VXd3RmhhTzRxYnpOak5DNEltYlVXRVkrWE1kY3FyRTFs?= =?utf-8?B?dlZOMHRLNlk0U2syaXFWRUs5OExEWHRQY3ZXZ21KdGRhaGpkd0w5V0ZwVkY3?= =?utf-8?B?MXY4cTY3Mk9RNUpPSEh0aXpvdXROZGExc1NLNWUyRmN3WG5iQTlsMHpmVGdO?= =?utf-8?B?OUZOeVg3dG5FdW9weURwSWcwNXNDSVR0UytObGZpSzFxRmZtWnBHUlhVa1p1?= =?utf-8?B?UjZqRHlZN1JlNWtDNUFiNm42YVU3RFRoWnE2WWxBdHpreWtFdmJ1d2ExRVFP?= =?utf-8?B?N2Qxa3AvNTF4VFFVTVNzU0UvRmtuWXdXbHVYRXByUVhiSVNQUWZRczdaMjBp?= =?utf-8?B?OC82K2poM0s5ZUpTMUlpTDIzenV5a3hRZ1BybGhPZitWQUEzSUU5NlhhWXpT?= =?utf-8?B?Q2d1MEJiZU1MblpvbXU1YmF4bHRuSHdqR1pGZ1d4b1kyNExRZzR3Q1RGQWxl?= =?utf-8?B?U2E0Y2JIMy9tYW92NHdSZ0pWd1RRVHo4NGtaSng4UTBSV3AyUjFDbjE2NHFq?= =?utf-8?B?cUtIdTdiWE1PVm0zRUd6NjA0VUVDcThHR01jZi84MTlUU2p2eXViczBxQzlN?= =?utf-8?B?S0gzOHhRRUkrOHRMUTBkaXRMd2ZTVDVBNnRobUh4cEhZM21URlprRzRlS1hT?= =?utf-8?B?S2xHRTJXdklNQVlHaUZ0WHRCUDRLeW9GUDN5U1dkSGtKUStNbHFoSERveFov?= =?utf-8?B?SDg3M21KNVpSZml3K3h6Y0pEcnBnZS85NW5ySm5FQTVvaWVDenFpNXlVRGFT?= =?utf-8?B?eU43VitGV084MTl1TWRpek9zb0IwYVdoTTZ4Y0NsWTFQdnRkOGprUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9ae122-8885-45f4-f6c5-08da42df1c03 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:25:24.2758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9VphjTy93o097MHJv8WLyGWClykwVNc8wRch3oBjL5nTk8NGMTsSrBxo5oIWAA/VaEBwVi/cuLPdXK0/2G5Hng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5396 On 31.05.2022 04:39, Daniel P. Smith wrote: > This series was born out of some cleanup work done while crafting the > hyperlaunch boot modules patch series. The primary purpose of this series was > to stop walking all boot modules when it was not necessary, but the scope > creeped during review. > > Changes in v2: > * changed init_policy to policy_file_required > * split the patch into a series > * corrected casting of policy buffer > * use IS_ENABLED() instead of #ifdef sequence > * moved #ifdef inside of braces for xsm_dt_policy_init() > * addressed lack of error handling of xsm{mb,dt}_init() > > Daniel P. Smith (3): > xsm: only search for a policy file when needed > xsm: consolidate loading the policy buffer > xsm: properly handle error from XSM init The thread consists of 5 follow-ups, including two different 1/3 and two different 2/3. This wants sorting and then perhaps (properly) resending. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:32:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:32:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339233.564079 (Exim 4.92) (envelope-from ) id 1nvxIz-0000oQ-Gf; Tue, 31 May 2022 08:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339233.564079; Tue, 31 May 2022 08:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxIz-0000oJ-By; Tue, 31 May 2022 08:32:45 +0000 Received: by outflank-mailman (input) for mailman id 339233; Tue, 31 May 2022 08:23:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxAC-000727-Ux for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:23:42 +0000 Received: from m12-16.163.com (m12-16.163.com [220.181.12.16]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id f6fbf7ef-e0ba-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 10:23:36 +0200 (CEST) Received: from localhost.localdomain (unknown [202.112.113.212]) by smtp12 (Coremail) with SMTP id EMCowACXPLd60JVim1EkAA--.3140S4; Tue, 31 May 2022 16:23:35 +0800 (CST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6fbf7ef-e0ba-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=ZG+PeFg6fhZlDO5LBF hyhcdyBLVHiTzJWCs/9b9ygXM=; b=Ipgx3G+B/aHp2V/YD2ixPMHClUZrZQpsSQ bnIbMyzAGS3XhZyzZJXg2nc/h2obIozp2WDDljlxrR/f1ZU8nvgRDn31nFwLR3IE zKUv1jmvSINsDjZUB9PrgoohvLfC3wZ0MGT3D7LXNb6LwzD1Fb4fS152IDShdmJT 8EueZWjIo= From: Yuanjun Gong To: xen-devel@lists.xenproject.org Cc: Yuanjun Gong Subject: [PATCH 1/1] tools/symbols: fix memory leak in build_initial_tok_table() Date: Tue, 31 May 2022 16:23:20 +0800 Message-Id: <20220531082320.31294-1-ruc_gongyuanjun@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID:EMCowACXPLd60JVim1EkAA--.3140S4 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjfUUhL0UUUUU X-Originating-IP: [202.112.113.212] X-CM-SenderInfo: 5uxfsw5rqj53pdqm30i6rwjhhfrp/xtbB0AcS5WEsqwoTLgAAsx Free the table[i].sym field of the invalid sym_entry since it is malloc'ed data. Signed-off-by: Yuanjun Gong --- xen/tools/symbols.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c index 710e9785d3..8daa588d2f 100644 --- a/xen/tools/symbols.c +++ b/xen/tools/symbols.c @@ -422,6 +422,8 @@ static void build_initial_tok_table(void) table[pos] = table[i]; learn_symbol(table[pos].sym, table[pos].len); pos++; + } else { + free(table[i].sym); } } table_cnt = pos; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 08:33:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:33:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339256.564090 (Exim 4.92) (envelope-from ) id 1nvxJH-0001Ds-NQ; Tue, 31 May 2022 08:33:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339256.564090; Tue, 31 May 2022 08:33:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxJH-0001Dl-Ju; Tue, 31 May 2022 08:33:03 +0000 Received: by outflank-mailman (input) for mailman id 339256; Tue, 31 May 2022 08:33:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxJF-00018p-JN for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:33:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 444282af-e0bc-11ec-837f-e5687231ffcc; Tue, 31 May 2022 10:32:54 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-7-OPH9IvrJPVOvaakZ7zmXTw-1; Tue, 31 May 2022 10:32:57 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9190.eurprd04.prod.outlook.com (2603:10a6:20b:44d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Tue, 31 May 2022 08:32:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:32:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 444282af-e0bc-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653985979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pUCkiladp1haNjXb+MHEHk58VBfkjSSmo+m4jwxW9cc=; b=naKFXXBHyLbkSkxEAHAvwQ4jBUexov0NPSm9+fOomPiCW6zBSVFxIRvt3cZH2Ne2apux08 btqvzPQSdrcEX6lSopIsfdxlE0BqzbUhWvvILvkMFj1SSqVKq5q/qXOlbm8DNie3EVVLgG VeFIUXO+BdG3aPB9ZAB0b328WrZML6w= X-MC-Unique: OPH9IvrJPVOvaakZ7zmXTw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsKtQpWQ59rH2b4fm6p5DKsGp3FVnrtECHHnGlxqzpVoND3Gc3JxKEvyyN2JZMAIciO0LxhcbCrqbuMmqZuDRCc9d41beMoVZFOjOwg5NiyH0Syih5BuljI1EXPtBmNFfl8WaAPzI90boyKqp57BQCgXkzaldyckNC2OFqYsEXtt2nfTsTEvHpyHwdwBC1IHa1f4rOuVC/+LCPxbjRZHEjtdjvEcdrPsP/0i5Hg34+aThFHYkk0SxymXTcC1Ea7fboKYM3Xo/o03L2x0CwDx4wnjtF5Sd84bq0Jelm8aqhgY3VS15gLR/gUSaIszaBk6fF3nPLuZ9k2+qrH4eW4Ryg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pUCkiladp1haNjXb+MHEHk58VBfkjSSmo+m4jwxW9cc=; b=iVyw2WSOI/OD7j+FmZmr959AZLpp0Q13IBmOKVq++aIabABAodLqZTfuJiwEiXVuALvzMTeFi+EL8WOWy+bl7lkZ3pUe+CVIjZjBZ4HXiiZGGfRTV/RNhyQhUsgxr1/Au3l5cni0nCxFs5OZkp3Tk/2IMtklOmeLWuvng5urYx/BsUrojpxJnYkDx8y+ZGWLYkpzOWvJUTOxwwzORwU12Ek9BdLZK9QSfnnWX/lxx+qNV7lO0e2vum4pYeqKeBMtI2RIm+Ie9o4ev3HBzeez2/FrnNa9hiMh2pdXX+gh6rz23O7CjZOx+shVxHkvhBVIyiKch90XC8R7+sIIt4/A8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6cb78106-3d5b-4fc4-7f51-9919f161d69f@suse.com> Date: Tue, 31 May 2022 10:32:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 1/9] xen/arm: rename PGC_reserved to PGC_staticmem Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-2-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0031.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::44) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 817710fc-b91b-4cb3-83d3-08da42e029a2 X-MS-TrafficTypeDiagnostic: AS8PR04MB9190:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nIpKCRnI0wH550G6EVvqRO79/oE+DpEa3cyOedg0VX6/03Mt2MesjKK/BA/aa7A3GU7pZBlPe5SJneEqDYk6Hg4vlcPE3joWdmruwQtZv7+4+v41pwUIbvFmbtLOnwklMM+pFizwjhlKfW2bM7YkRy9O6jjl9yvGCiPteSR79yEdXtIQKQ4/RqjdU84R5u+tvAk2dRxDv4Ex10ZgwzWro6D0Gf36ikitO1+pl98vdyBcT0es5qMLv+xnDf0OJcqJI7sxXKsMXfTb1EjxpL/UKmevTjbuaK65FGFG+3rVPSlg1D79rU0sCwDXW0YzGQGg5yQScM1W2vJ7DYalLnbe2EkdGXgB6QXKjgMFzMUCA3PFvLX9gqF3mEBSCBNjwWOzSmw6j6w63axrSHLbgtaT6g3IIYiuJwWCCxwVCNl8B+S3iMBhFBFCqua080T0YE72PTLEYxIdFvtu9nbbboVVn83G10ovoAP5OelNjMym68tuMyu8JODRz8vcGLwq9DWYHRhY0fxjP8RcMyNdvhwRt79DTFbGzBWouKvau0YqJtWlDEURjr6xJlNlRlE+jr4swwGPJJWhr6zJmFEPx84Te/NdHP6mvnNezzJBWiG18JBbiUqFpeqK+hAysSGjol+58FaKVBXdnxtcghlJIiKoCA7tp8SVJhBdkwVZ094CM9PM8a7TtoBs8zrBxgzZUesngxl5JBGeUrY+S51VPfHRaNf0u7Fifzfv6lz17sdxbuQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(4744005)(86362001)(508600001)(5660300002)(36756003)(8936002)(2616005)(31686004)(186003)(7416002)(4326008)(6506007)(8676002)(54906003)(6916009)(316002)(53546011)(66946007)(26005)(66476007)(66556008)(6486002)(2906002)(38100700002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVUvVytBUG5GNUVPSUxYK2dISUxsWk9weTFIVlJWY2VzWnVISTRxYjE0TGJU?= =?utf-8?B?N284aHhFVndoMEpMNVZOVU04QWFFdFZTRkNyREQycW5KRyttYUtRZXJIdTls?= =?utf-8?B?VTV5WGdPY2hONFV2bUdUOVBPV3RFVUFLTGVIdEdsTVRxeEZ1NmVGU0dwU0Jm?= =?utf-8?B?TUhyZE11VkhrM3VMRTd3blluTjRxT3pkcUs5bnlHcDJrZjdvU0dSa2toYmhl?= =?utf-8?B?NGg3d1BlWXNhTVpGNUpNNC81WkdWTW1iQW9BY2NrSzQwMy9iWFcxWUU4VWtZ?= =?utf-8?B?MmpETTZ0ZDg3WlVZdzAveWdXc244WEwrVVdzMUQ3YmVlbU0xTkx2aU5NL0ox?= =?utf-8?B?R3dtWjRoSWFXaUNmUnFWRjZ0RFlZZGduMTlHRStvOWVsQU84eXdIS2toVmQ4?= =?utf-8?B?ckU4aUxRK2tnY3dhckVoOHk1alVQWXh6UlFMTEp2ZGhPcEQvTkhoMUtTN1dy?= =?utf-8?B?WE42ME1CbVN6NzhpYk0waWs2VjhNMlhLaXhqQTRpczJpQVBXSEcwUmRrWmJH?= =?utf-8?B?c0hMaGtDaWtReHpxaEdSZjhIRVkzQnpkSlp2dHZRa3dSY1dydzAvWDErL21Z?= =?utf-8?B?TnFma002RDc5NFRXck96SVFudjNvVitJTXF6Z2s1V0xSRnVoMWsxNmFEUGFh?= =?utf-8?B?SWVRY3YrU3lYV2p2UlphS1MrWEdEdklNU0NlVWJFOG1GRW4rNE92ZzZsbkFv?= =?utf-8?B?WnZqNlFYeXJxVnQ5TDMvUWt3bGQ1S2NRS1h4VTF1WGptMFl2VXlvdm92QmNP?= =?utf-8?B?R2gvcVdDL1NORVBXNVJaYWxSQld5andHN2x3eU1PZFRzMG42VWU1c25NUlQz?= =?utf-8?B?OHJGQk0zRzBtSW1lejlFYXZ1OTdEMWpmdkJYL3JMTEk4MDJmamkxbi9SWlRX?= =?utf-8?B?eHZxbE9HNUdvM2RaZDN6cTNsSThUTlNHQ3dyeFBncG5SSlJJUk05aVRXV2ZC?= =?utf-8?B?NGdsYTJNS2JENDJ5MmkrQTlMY1lodkJLMGVrNGQ3UEhheW55ZHlUQVRmcmxB?= =?utf-8?B?aFFxZjlnc3BMQkpiUTN0aVZzTVJRMnE5WmVTMVFiSVd0OHY2ZDVCNXZTalFi?= =?utf-8?B?U2ZjeVI3RmozNHhaK0QwY1RzOXJlOEFnOWRGMkNiaGZZTEg0WnNHR3hWd2RY?= =?utf-8?B?SkdoVzQ3NXB0d1R1ZkZ1S2dCT0VCVzJEOVg2MjlTRmZtY1E2RDB4SkxHWVFM?= =?utf-8?B?RFVmZ24yc0RYN0Z0TUhuRkwyREtFVWdTSzYzRjE2cFFzV2kzZFI5WjVUbklV?= =?utf-8?B?M2lGOVl6RzhDdkM2aWc3TTlyMUlvdVlMOC9ZM3VBZFhDS0t4VWE4RHRhTHFl?= =?utf-8?B?V21sUS9KNC9FSTFVVnZXVUxWancrMlBTeFZaMEdSRHBTMHdueVhkYnZJbkRp?= =?utf-8?B?SGUwRlhObjUzZVJnTVc2enZBWHhWMmZ0UTlHaDljV0Znc1FTaGk1N1dNSFVQ?= =?utf-8?B?N0JjclJ6NXN5V2ZZL0Vlb2xkc1FObGppWGRRRFkvSUlzb0krTVJ3K1lROFVO?= =?utf-8?B?NURxcW1JNnNINy9lZ3lONHZPMkU0b1pzck1ndVh4dHd3cUM3d2tWVlJ6dTRK?= =?utf-8?B?cEdYbjBEaTRka3lzUy9lYnpoZlIzYm5DdmV6dzlqY0tOOHVOWlowRk1leXov?= =?utf-8?B?aVNaVzBXS0JGeEg4UG1YMU1LZGtRVE9qK3g0TXE5cU9sbFp1TUs1UEFIemFG?= =?utf-8?B?MHpJbDJBdWdXUm1iMWg4NEVHQWlQak9wK3EwdnF4bTRWcFpFczRnWVlSSklh?= =?utf-8?B?eHZqTWtiSXFIL2VTK0ZmbFNBQ01oWHFzZkxKT1dJWWZsb2N4aGhkV2ZBZGhI?= =?utf-8?B?ZnpZNVdsaDQ2c0dwVzVyd2RHN3l4eHBpVFJrRnJibXd2eDJESThmYXdNV3ls?= =?utf-8?B?NGhBVjFnMGdpd0Z5L0w1N0xuc29ZanIyQWFVZ1d6SFJuSDR1RWQydGo2R2FG?= =?utf-8?B?THpiYTAxR1JSUEh0SlptTEpveHJGMVZsYW9neFgvdU1HaWZwLzlFYkUveVgr?= =?utf-8?B?UVlva3BKMkthV0Y1VXM1VzNtM3JZcUoxTEUxQjhBZnFSdTcvcTQvR2VNeHhI?= =?utf-8?B?dEM0TXliY051L3NCUTVzREJ1NkZHeDJBN0lMRXBNQ1FJRTY5VmxPQnNrWVU4?= =?utf-8?B?akovTjB3RUhaeTJpeGd0WDgvMGhnS3MwZkdvYkVad2tIOHpadlVtT0RvMjY5?= =?utf-8?B?Z25JRllQRjRpb1owWnZ6YW40L3gzbFp4Mm15ODFXOUxETXViMTNKYThmS2xD?= =?utf-8?B?b1NiQlpZTFBDNEtwbnFobU9KZkVoa1ZWQnlsbHRkdG1IdDBYNFFHTlo3OHIy?= =?utf-8?B?ME5Mb0xBZzR3c3JyTmlWMkJiMUk2bW9uQVJUak8vSFpzZ0ZSeDdtUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 817710fc-b91b-4cb3-83d3-08da42e029a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:32:56.5907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qtHYQy2Cx5ViNdUci/UxVGZcFKQ+fwIbql5N9geMWQ2UU2+/WMq7pYZb20Z1cEFXb9L14HL+2s/ja+0sf9uJng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9190 On 31.05.2022 05:12, Penny Zheng wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -151,8 +151,8 @@ > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > #endif > > -#ifndef PGC_reserved > -#define PGC_reserved 0 > +#ifndef PGC_staticmem > +#define PGC_staticmem 0 > #endif Just wondering: Is the "mem" part of the name really significant? Pages always represent memory of some form, don't they? Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:37:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339271.564101 (Exim 4.92) (envelope-from ) id 1nvxNB-00021P-Ad; Tue, 31 May 2022 08:37:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339271.564101; Tue, 31 May 2022 08:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxNB-00021I-5a; Tue, 31 May 2022 08:37:05 +0000 Received: by outflank-mailman (input) for mailman id 339271; Tue, 31 May 2022 08:37:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxN9-00021C-R4 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:37:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d54a852f-e0bc-11ec-837f-e5687231ffcc; Tue, 31 May 2022 10:36:58 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-AeFmhA16NrisHjxngcJEog-1; Tue, 31 May 2022 10:36:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8583.eurprd04.prod.outlook.com (2603:10a6:10:2da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 08:36:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:36:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d54a852f-e0bc-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653986222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=plUvyu+jMPuD6s3oTwsFMxsNbOlAIf56SLfvlxkIZ1E=; b=YLap8ZM5HxP3cxMvR8+u+pyh/yxbMkwWt6P/v122/WtHUAcNUATPAh5B2wamvBhJqp+N74 GuFaJDqchJntNGdWs+WAt6jOVLDQqJjd1a/sP+cZuLZzQFy2Bnkk9KC2SomWeyR40c3k2i IaLR0KDh++Y813jCh3ZpzjyCCtI88SA= X-MC-Unique: AeFmhA16NrisHjxngcJEog-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRnSDadgl7SMWFbnPyAGnlf+XqdY4nU6Vud84Ch53gEbOtdNUdxW9w1uwlOExqlxScW2Bs9NcZHC1761Ss72WBVZYjtF0/9P71jD9B0mgxG7fuUB6JsOhssCFwvc3/oy9M5OARq3KTd11oVan5c2EBBC9XdIPvq2d8FCHINrzw4mrSCSnE0qUhBMrvYAZK293gd45eeC6MgQ49S9PdjOop8CzctJATgb3MxNbYYSMp0uGrtZiyXWuZxWgwxH8pltxfgFggbGynj1l28JJy0BWfBM19yqwpVut33wafKqb4de2IEJ3OU+Nz9x13TT9kQ2JMUGr/IhPMflWjlHbCf9Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=plUvyu+jMPuD6s3oTwsFMxsNbOlAIf56SLfvlxkIZ1E=; b=bOALTS7kwIU3bJqAAon4+AR0pIIfF60yJTNRSX4/OhNAH1JY8YfnTAjaQ8GbuIJ+H/lYM7LWBr31kGSyuLsTG0fzYNBD7DACgOax9U/otph+OR5cerzCsCfic7vRD1yPrpsZoQACP/rsUBNBOUUst2ZHNBfCxBh2J2Ah6FPJW6kyC7GX5LJgZIuEhsn/jbKhlaoQzeTiXxzlzYwZehozGLIOK9lr5GHL4CNqVWAZWNLNsIxoDwZfGjOD727vkBLr6uXZoCSlPKHRR6lIzCW/QNse8vMt5hB3sCczDf0h/sq+YzFCqrnVkGVRgtR3m73yzSZDN7tFyqpIH/iRI52fDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f0d9d47-236a-d7c5-3498-d8706c616fcd@suse.com> Date: Tue, 31 May 2022 10:36:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 2/9] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0701CA0005.eurprd07.prod.outlook.com (2603:10a6:203:51::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8780d869-b789-4bb3-01b9-08da42e0b94d X-MS-TrafficTypeDiagnostic: DU2PR04MB8583:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J/rPMJk1WSjQTS8DAJHrAoTToKMxoxv8utotsNeH5ZJeNniGIs8FB/UKhlhUVWKj8FnXNqr9TM24O8yPkLaRm1iVO2V3j12fhKfuzbIs0akOBZK8SLG8L35nkoEgAYi1IGQI+YHjK1dK2GVJUcB8GmnE73Z4L/j5oK/alvf8JFbIrBu4Hc50O7icC5XQgyFHbTK8gMzsVOC9yUknXfW6JBc9Na++eYvKpUKh0rX6prE7pFuhffBoxHTtSuWnsd22Csblzhe8Z/C1LJ0m3iAcwfccwTWK2zYoOn4RIYizgtkqyjGhgZPjGanbQtrzq9YPKLrb5FxgwGLroOnfaz9PaE7+F8/VZMH3x4ICcNCCiKmI9mJ7sq3DYF3T/9Zsb6ehYLi87BJvIpuNF8zopjtvAkcS1DEDQM57xTf8ZY+RWsr+FkxyEgEBYAWULTUGXoEONeInZhuWodTPp3xisFuCAQnEk0d6T07xKUmW/Zwqdiz8/JqTN4Z34KDzDqO9XMh5IsREOOSOg0272meSjjEATxIhefe7FjpyZ/UTifFP9Gdv4aAqEDyGB2L2ISksYTFPxBHWCEHXcmSRjCdNY4KMwdkx36ukIfEtCZMx96mCFNaxVIPjBawtZWrGPTDZenyu4T1zXZ90nl+a5gZlFKKBwtFi6IUvc0GmOUI0FoZQvOgh8YNbheEf+zNzTWChBL718TXdQBRarVn5I34R/kKN4Sv0wpnmPlO4YGC9v4mMsowawQ/mPirnZRr4hE7o5O66 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(6512007)(186003)(6506007)(53546011)(2616005)(8936002)(5660300002)(36756003)(31686004)(2906002)(7416002)(508600001)(54906003)(66946007)(66556008)(8676002)(4326008)(66476007)(86362001)(6486002)(83380400001)(38100700002)(31696002)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlBrOHBrbnpzeHZqSVloTVFhY2JuSWZ1RXlVTSt6TWdkcFc3WDk1NllFTEEr?= =?utf-8?B?WmNRalRMWGNIMzh4M1JJNjR0SG4xbXhGV0lKT1VBRVFFTFZhV1FPMi96VzZD?= =?utf-8?B?TzNVMVltWHNSUk5ZK3dUYXA0VGJITzdkVE8wTmNsOFd3elpLVC9wamkzcDBC?= =?utf-8?B?M3F1Vkx5c1ErZDJDZzRBdGtrVVkzSjJ5Z3Q0b3k5YVNCM09EWExFQitYTVVC?= =?utf-8?B?MVhYUzdIM1VwRDVxNzJBL0sxZndkWE9rRnNyNXNhSSsyUmhyei9aZHVnK1gz?= =?utf-8?B?Q2NKT0ZaYS9GemxMRzFneUQ2cFgwQkEyQmJtNmd2dWdIc1Uvd1R0cFhZTmlT?= =?utf-8?B?T1Bmc2RzSkRuaTQvMnppME91SXBXcHBCblNBNWYxWGtxQ0JNeEQ5ak94VUIw?= =?utf-8?B?emQ2d1lyK1BaSmVJMEJPRTRNMTRtNmhJYzJFS3VGb3JlbmNtMnNOUzNzbjJ4?= =?utf-8?B?dGswM0dOT2tLT2ZPaXU0RmpVQVNES2hGa3dHVktkL3NObS9nN1gzdHRydHMx?= =?utf-8?B?bERRZmE2V29JVldvQTYxVllIZzF0NmxPb3crMWF5c3Z6QnFyNm5XZFhGUlZT?= =?utf-8?B?dkIxVkdqY3BZTkFTd0x1Ykw1ZUZpV1BId1dxeWo0cHpUZEJZcjZvMjlvQzRm?= =?utf-8?B?ZTVDdUxoNk1BVnNhU1RKZlV3eTQ3OEpZNnpaakx4dy9MRCtMempZVnlzM2Mv?= =?utf-8?B?S2E1SEI0aTdZdTJEWkpDWHhvT0FuNlo1YkJvZUNTZWRVRGZNbUYyWmxYYXFy?= =?utf-8?B?dVVHZ0pSbmlmbTRhbkZIb2ZiZUsyQUdIQkxGUTBhT1F6c2V0c2J1ZmZoSFk4?= =?utf-8?B?bEVOWnNBLzRLL2k1ay81dFVFaGgvQ1ozUEd5ZTV5UlF6eE5KeFhrVjdGVnd1?= =?utf-8?B?MXJXdFM0VjRzblA1YWN5YWpMTlVnSUtwbmdtRkNnbjFpN1g5QS94STZSSzQw?= =?utf-8?B?enpTb3hyVkluS1JjR2UycDRUVEJ4a1NFQWpnZ1FVcTRhUERmSVJpR1NRZ0d5?= =?utf-8?B?aEhIZXNIUEswSUpQOG1SaFBUeW1KL0MwUmwvSDh2R2NzRllRa2d0S1B0Tnd4?= =?utf-8?B?RXh6RUtDQlhSVm9BalZsNmxSb1k1ZjhreXEzdlFoS1NFK1hEM1o4MlRpVFNI?= =?utf-8?B?MUN1T21zNzZET1hqd3hOWHZUcEM3QVo2MEhQeHdNSWx2SmF0R1lEQm96bG50?= =?utf-8?B?S2d1TmFkOVpMbkVwVTl5WmJYTGlBUHVhbGV4LzdVWldxMXgzYm90Z0hwZWt6?= =?utf-8?B?ckNENXR6VEVzMXBiTzM1RkxVMXdRcjlhU3FndzN4eW1tSXE2a2JzcEpLUWpD?= =?utf-8?B?UjdyVmtydnNoU2krZ1ZlSjN0TWZHeWlHQWVaWGVycVpDdzFYMkMyTGc2OHZa?= =?utf-8?B?b1V2c1pvczFKTS8yTEN6VzdIOG5XaWN0Y0dZdy9QeHBRRmk4dFZGaWhaTDZD?= =?utf-8?B?eGdOUUthNGJ5MkN1eTBwRUdZeUZCOXk1YldoTGtXS2NCTUdqckxCeEdkTGNK?= =?utf-8?B?SWlIdHRBTUZ3ZmVMZDB3cmVwWU1qbGxvaEhEdDhUczFCVjlTendNOXZ5NFNu?= =?utf-8?B?U3hUVSt6cjRGT3U2cHRQWkkrU1ZwblFwOTY0M3hYWnI1a3R0UmRXLy9rWSs4?= =?utf-8?B?TC95b3FFU0hGQkoxTXRuNlJyWFFvaTVML0kvNUUxQkxnajNwazRoOWJrR3dp?= =?utf-8?B?SWxkNFZKL1lFOTZJQUtPb01scTdzTHBXbXVIQmJib2hhcSsxVkpET0R5enBj?= =?utf-8?B?ZUljSnNoMFd6Y3RLU2VJVS9pVUUvUzVkc1hMck1WS0FUeHBHblNnd3ZDTXA4?= =?utf-8?B?NkNVZFEzckU5VmpzempTdlNvcmZGcGhoZmdKT0VFVGxEcFVIWXNla3ZGaGxx?= =?utf-8?B?SEMwbVovYWkycllTWFdiOGNzenZJUFQ1U3ZVOWw2OGgvSitYZytaY0VmeVoz?= =?utf-8?B?bWUzV0RNbGpmK3NENE4vSGY1VG5tbFd4SXk1cHFDdkpWaWpMWTI2OFhmU09m?= =?utf-8?B?M0JnMkxqSDI4cXZvSnBLa004Z0cvVWdVUkJZZXI3ZE1XR1NtdTlWNEZpYUhM?= =?utf-8?B?aXUwV3RSSVIySVE5SWVHOVpucERaZ2RsK2ZmQS9aNlhRMUZSelRRdHo2U2ZO?= =?utf-8?B?TVJrQ2JydmJUTVNrUndDdE5laE5ZQlVERTQyWFJCanpkVGFiQlBmK0N4WS85?= =?utf-8?B?U2NyTlJLWlkwRkpTYlU4UVExNVpKb3FLMkc5MlZyTWpneTc4bVg1anBJWDFU?= =?utf-8?B?WXdISFptd25YaUw5QS9qWFBBa1g0aUsrUGpYakFWNHdKUkpqaGU1cDl4ZDJV?= =?utf-8?B?Qm55UmltNEdYMHdNTlpPejJwdHc1YVRYOHVIcFdXalBGRHI0ZlhLdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8780d869-b789-4bb3-01b9-08da42e0b94d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:36:57.6848 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gANvYMhyJfmtRcFuDIKVOIhvbhFYAgGiqmxOqJtH53qYyIRVJKHOChDb/x6XAxhuP5WuhkLS9meUCvC7MS2JdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8583 On 31.05.2022 05:12, Penny Zheng wrote: > Pages used as guest RAM for static domain, shall be reserved to this > domain only. > So in case reserved pages being used for other purpose, users > shall not free them back to heap, even when last ref gets dropped. > > free_staticmem_pages will be called by free_heap_pages in runtime > for static domain freeing memory resource, so let's drop the __init > flag. > > Signed-off-by: Penny Zheng > --- > v5 changes: > - In order to avoid stub functions, we #define PGC_staticmem to non-zero only > when CONFIG_STATIC_MEMORY > - use "unlikely()" around pg->count_info & PGC_staticmem > - remove pointless "if", since mark_page_free() is going to set count_info > to PGC_state_free and by consequence clear PGC_staticmem > - move #define PGC_staticmem 0 to mm.h > --- > v4 changes: > - no changes > --- > v3 changes: > - fix possible racy issue in free_staticmem_pages() > - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case > - move the change to free_heap_pages() to cover other potential call sites > - fix the indentation > --- > v2 changes: > - new commit > --- > xen/arch/arm/include/asm/mm.h | 2 ++ > xen/common/page_alloc.c | 16 +++++++++------- > xen/include/xen/mm.h | 6 +++++- > 3 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 1226700085..56d0939318 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -108,9 +108,11 @@ struct page_info > /* Page is Xen heap? */ > #define _PGC_xen_heap PG_shift(2) > #define PGC_xen_heap PG_mask(1, 2) > +#ifdef CONFIG_STATIC_MEMORY > /* Page is static memory */ > #define _PGC_staticmem PG_shift(3) > #define PGC_staticmem PG_mask(1, 3) > +#endif > /* ... */ > /* Page is broken? */ > #define _PGC_broken PG_shift(7) > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 44600dd9cd..6425761116 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -151,10 +151,6 @@ > #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) > #endif > > -#ifndef PGC_staticmem > -#define PGC_staticmem 0 > -#endif > - Is the moving of this into the header really a necessary part of this change? Afaics the symbol is still only ever used in this one C file. > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -85,10 +85,10 @@ bool scrub_free_pages(void); > } while ( false ) > #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) > > -#ifdef CONFIG_STATIC_MEMORY > /* These functions are for static memory */ > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub); > +#ifdef CONFIG_STATIC_MEMORY > int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > unsigned int memflags); > #endif Is the #ifdef really worth retaining at this point? Code is generally better readable without. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:41:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339281.564112 (Exim 4.92) (envelope-from ) id 1nvxR4-0003TQ-UK; Tue, 31 May 2022 08:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339281.564112; Tue, 31 May 2022 08:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxR4-0003TJ-RU; Tue, 31 May 2022 08:41:06 +0000 Received: by outflank-mailman (input) for mailman id 339281; Tue, 31 May 2022 08:41:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxR3-0003TD-NV for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:41:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67fc9a6d-e0bd-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 10:41:04 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-R-wPVTNlPBShMZdoW3X3vQ-1; Tue, 31 May 2022 10:41:03 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7596.eurprd04.prod.outlook.com (2603:10a6:10:201::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:41:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67fc9a6d-e0bd-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653986464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MdQ0tv9ZY927eDAi9KWK6S8eybd4UghsqJGeP20ui00=; b=OZA6mMvONTKbn8pckAY9Q9t06eLq1+KpqvU5D8cBCauAodQ02KO9Kye5blmt52kuc0cB8S WDKQYz/75V+KNJR7gkqt1Qgqq4KLYYXW3WZY/DeB27CmitRQ4yA+EGfOPmcXSPvyvORxZm bp3O+CGHoHMj05dZPfyY0K+Gqri4sjc= X-MC-Unique: R-wPVTNlPBShMZdoW3X3vQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hyX4wipu7NPCWeCV3puswQdF4GdS8XHVE7QaowKidcGVndH9Dnt17dH+rcI9Mhpju0JVl5B/E+Jk9Hc4tu1cEMAs2SkCaebFPuabT4RJwTXy5ZxJkR+lxIipnqcFpA90ba+ZqDtWoOW6ZRFRlmzVRznjWrWPjN02AeUr7rifRLDjkJWJSwvYltP95im+YqUQV+tTnvfm4SmB5xyCOe7L3IhH1ZN/eu7cRZ6+E6gatOGVtPdQWGrni/bpzf0+sDkRPYaFlMfa0ewPTyY0TiI06AY79cd7gRrL4ThHHVYFwOYCfBXxLKbIwtEil0Czt2NEJ2CHo7Le44YNzY+lxGS2zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdQ0tv9ZY927eDAi9KWK6S8eybd4UghsqJGeP20ui00=; b=HWbRdpsBS0DXfNQ4pY2ccj8QnLyCtFWIyYttGMofdbp9xL+tZIj+IpP3JgifSssq0S4dSSXzErnL6KA6hB0LfIq2eyYnHZ56931fQggkPEyEeRiev1ooDJ7abPu6r9N0eABAxZUwlGYXS6e2ohcG9Znk4MpWZseDlplIyr4OZcv5+WYjeiiMMsS5Qv6RaK7xDiFjzZX+doBJnDGZAyc8XN6KFqZESb+HY6fpcWi06LEXj9cULDHnIYIfFl60xMlJCQ2YSKF5PiI7brITj+A3bCWaVEWImkIEe26sVT3IX4Vz0t4fjo+ZoF+T3RSFy8BbyZAxj0O3/FsiPoee92TuMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 10:40:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 6/9] xen/arm: introduce CDF_staticmem Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0044.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb64f5d3-d83f-492b-b640-08da42e14a79 X-MS-TrafficTypeDiagnostic: DBBPR04MB7596:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yDSlmmZP25pr0c996ETBEM1ZGBkjTAaTJ4tj7AfBbWp7G+Im0OyzPAHamy2i0btUuh31xNCzRIZXoanmtxGsVvguUowUWTkhpcq369B5QNC0RHGVcbuiBQuaCMThAR0v6MRM8vXH3lZL+aEIwDPFrDiOYqR/fVAEXQLMd0W+yalyx72Q4+X2Jto+UxIcW6qTT0+VnYCpEGC+XVxUy/HB7ZarNZWwIYWeM4k0JskDXaQzbhLRvCAgRdK8I1yCJQwyL+HXjWUHa4zr2h2pszBmNCidA3RiUFpd0SNkozJX+5X96zYDhmTnrtvlPB7IggeSCXW/HOOx6K00++ys3GoKdTJq3Ip+NcSDSB6g224S2C8BCy8iqqwaW/79CgLGV4ZDZ7SOJPOgjBFXPoFOZUP4YMD67nMLhz3qJBF8P9uI9NbITgTC/naL28uGj4LaVwePJUhfKM50Ujsvb+UwUjkZHQc5XWkM4Qv+tEW6kQ1Ur5+mbgcZBm+ZzF+TzhVQzHJLuvgsxsSymRYXb4KNfQfFlQil3Q8AFlN/4ufp6ndysLNaNJEobT60BKj+z+IoJvNMuLEUnJbE/huNR/aVBapVVRpNPpMCmhvslZUhj+RtyGOGy8sZ1sOdgDUzLKRvAl1j8EQ1QM7GDS3PuevqXoDkGWmKwQ/NTfc1EJZYO7PaS4wlSISPlpqnsymFa9BvelX4pDOMIzdgrCN64RX2XqXcllR7qPY87u+08+jmiuCCup0mlo1bNX4d95czCXIL4C22 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(66556008)(66946007)(66476007)(38100700002)(36756003)(31696002)(7416002)(4326008)(8676002)(316002)(8936002)(186003)(5660300002)(6916009)(2616005)(2906002)(508600001)(83380400001)(53546011)(6506007)(6512007)(26005)(6486002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFNrVU14RVlHU0x1OEdOTzVXYkltQW5BNG9GYXZjOWk1emJYaFRqODVScGIy?= =?utf-8?B?aHVZcTQxVkdEcnptZGs2azRrdFNzdTZRSjlJU3licE5qUVFVdlBxOE1yTWgr?= =?utf-8?B?aytKRy8vZjBKejhJYStueFN1N3p6Wk9BTzZUbGFjYlBRWGxGMzh6RDRPMTcy?= =?utf-8?B?RWFzK1BHOEpKOVk3c1Bab1V0SVpuZzkwSGVJUEhTUktGZ1hPcjZxZDRyL1RM?= =?utf-8?B?ZnQ2NDI1djFKMFluZGdUTEIwMVVQN0s1d1QyOXFBdjdSWEU1dVpVc3VNT3Y1?= =?utf-8?B?bC80TmJaOUttSXJsRmVhYmlZVTlQU2hrd0FxNVdsRDFlTTkvNDViZFhhVWV2?= =?utf-8?B?NnM0dTdZQjRmVFhoZjJwSWZzRUtMMzZLT1hJZ3ZqRjg1a3hxKzBRVjVpTnEz?= =?utf-8?B?QUNDTDN1SXkzdDcyKzJBbWVFR3hkcG1IT0ZaTS9DTWQzSWlYckpjMGpCcUEx?= =?utf-8?B?YlRON3hmdzZJRlBrN0tOOS9pVzYrUkQ1SzIvRjhCMDFjOXVWcWVCZXlqcmZC?= =?utf-8?B?MStGZlNlTnpMTGlidTNiQXRjT1hCaXc1eGFCZDk3QzdjSFF5bDZUZEpYV2Jq?= =?utf-8?B?NFRmaFNYcFFCSUs3RFg2NEFTZnJEZjEzTTRRT3RRTjRPTXF2LzdXMGtiejFp?= =?utf-8?B?Q3hyTDNSc0JPdmR5MWZNMVFwNjNDa2RHY1k0bVcxakhacXhpZngyV0gxWTV4?= =?utf-8?B?NW15Y0d0MkxBRW9LNytmS0hHSGJQWTBCWU5YeEErWDQrVHVydzRsaE5rUWF2?= =?utf-8?B?ekZuLzlkRDFXL0xVVGUxRnJQTnpPSmMrbDhYSURxaUZ0ZHl5L2poUmRBaERl?= =?utf-8?B?OTBnNDNmWVJGNjZ0cCt5NmdtNGpRN1QvM0R4M1A2eWJpaHVFL0NWODhZYUF4?= =?utf-8?B?Tm9vQXUwbWFiTlBUVDBtc2VkNzNGSU1zWGZzcFVKaCtxVjZTVUtPU1BzTEtF?= =?utf-8?B?Ymlvc2taZzhCRTdEWFRVbzV6U1FBK0ZhQ3FYYXNPM2tDUzRYL210UWdOQ3ll?= =?utf-8?B?WjJGbmpRNkVmM2xQSXhmcXZOVnBtTFJLQkFMSjhQREx1aGZTbSs5VXdqSXFo?= =?utf-8?B?aFd4ZDh1RDB0Y2VkZE1ZVFBETlY1YmVNVFM5TVBDMUQvbUZIV1RqV2Mvc2pQ?= =?utf-8?B?OTFxQlM5eVNWRTNSbDYxUXVSUGhrMjI2S1BGbEhtTEMwRnI1cEY4ZFlUdThw?= =?utf-8?B?SkNpTURJODZ5cWd1aUVDQjNQOTlFRlh4M2JiOWxKWGFzcG1YOHFqRlBBNDFX?= =?utf-8?B?dEt6aXhTN2tTMzZTM21pZXVUemQ3aG9vZFdMeUY4Nnh4SVJRdGlET3FtbWxk?= =?utf-8?B?d1k3THlvSTViREU2cnVNclYyUXN4elA4SFpJa2NTZGRXajdxNUYwLzZxQmJF?= =?utf-8?B?NGdBS2JaeFZhWEM4TmxXL3I2MHpLYWIySVZRazF2WHd5S0ovd24yYk9ZZXhT?= =?utf-8?B?eXBINVN1bFFsV3hXQWx5QmxRdndWajgxY1Zid3F6a1pTTjQrem5RdFQ4bnBZ?= =?utf-8?B?Tk9PbHJhdTQwM21lNUFrVjZIMzQ0YUlWb2dhTTJDd0xCZnRsOHVKUG9QbEJS?= =?utf-8?B?aXpXYzFVR3BTK01sK2lHRWhBV1VjenNta3c1eUpRUnMxVU9heERTMkFTSVNL?= =?utf-8?B?RVF5NmxnN25PaGRORFRQS2VTdm0wcXBneG9ZK1AxRlNWOXB4YmxGbWF0VzZR?= =?utf-8?B?NWtteGVjd3RPb3hKTklPaUJIUTN1V3FrdHkzUm9tRUFDNmE3dm1OK2hRd2Vp?= =?utf-8?B?LzVxdWxPWTFTM0RqRG13enFTUS9rU2UzSGVRUGFscHl4WTdQYUZrbHFiekxM?= =?utf-8?B?bk5KSndxVDQrL3VwREJuc1JXRkY1eklyWFRyaDdkNUJSTXZ3dmU4ekxBVnBY?= =?utf-8?B?NkZjSCtWcFdwM29QZE5SMmlla01Xdmo2V2pHbU93bEhOOS9weGdHTGNCT2pj?= =?utf-8?B?N0YvRHE5MGxPeFlvYjBIeitPa2V4YVlGNFV5d3lrQ2h5QWJCTVIySnliSzNy?= =?utf-8?B?N2hJcEx5U0tMRkVkaEdyQjdOVTg0Y1dBTGVhS1BFSGhrY0JvTEh5R1ZhUUNE?= =?utf-8?B?OEttRldFcWRQRnhoc0t6YmF2TlVtRTFDT0FqQU5VVFJzcnZsLzZZbmZja2ZO?= =?utf-8?B?dWV3ejhQM1BNOG1UUHVGTzNNeVZNVWZxQkd2TGoxR0dBZ1pWNlFmQnlTem9N?= =?utf-8?B?VVprK2lxMndpRzBLSkdRb2hLcVVzMjhmcVdRcDlIMTZyaTJNbTJVeFhOb2d4?= =?utf-8?B?cTdqNEVpTi9QVmVNSWw2UDljb1B3VUFXNzN2Vnl0cUI2NUdXdXJxVU1yMUR4?= =?utf-8?B?RjM4QjVWd2UyUjg5MnR6eTFPNThvZ3dySjJQa3dNK0Y3cU5CRkJDUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb64f5d3-d83f-492b-b640-08da42e14a79 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:41:01.2005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7sMu4UY7VxAeEUBhGTCnm4KDZxCz8qtEMZ97MDLG2Ii5qBrgvima0GM3AKaGn5NdQp4Bfv0xJCcDuxyl5mhtVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7596 On 31.05.2022 05:12, Penny Zheng wrote: > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -31,6 +31,10 @@ enum domain_type { > > #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) > > +#ifdef CONFIG_STATIC_MEMORY > +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) > +#endif Why is this in the Arm header, rather than ... > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -34,6 +34,12 @@ void arch_get_domain_info(const struct domain *d, > #ifdef CONFIG_ARM > /* Should domain memory be directly mapped? */ > #define CDF_directmap (1U << 1) > +/* Is domain memory on static allocation? */ > +#define CDF_staticmem (1U << 2) > +#endif > + > +#ifndef is_domain_using_staticmem > +#define is_domain_using_staticmem(d) ((void)(d), false) > #endif ... here (with what you have here now simply becoming the #else part)? Once living here, I expect it also can be an inline function rather than a macro, with the #ifdef merely inside its body. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:46:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:46:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339290.564123 (Exim 4.92) (envelope-from ) id 1nvxW3-0004D4-JN; Tue, 31 May 2022 08:46:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339290.564123; Tue, 31 May 2022 08:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxW3-0004Cx-FN; Tue, 31 May 2022 08:46:15 +0000 Received: by outflank-mailman (input) for mailman id 339290; Tue, 31 May 2022 08:46:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxW1-0004Cr-NC for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:46:13 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fc62516-e0be-11ec-837f-e5687231ffcc; Tue, 31 May 2022 10:46:12 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-18-VLhYCD4QNLC9A2aGCCpjOg-2; Tue, 31 May 2022 10:46:10 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4901.eurprd04.prod.outlook.com (2603:10a6:20b:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:46:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:46:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fc62516-e0be-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653986772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vKY1dVlvPdK3bVGlGUHgCNx1jyaSyO5QBUThZQNC66A=; b=OFChTjT+F6xEGV1GPwYznVRQ2/Qel2Oyx9DX5VrjDpKc2fwtwDRxwhw2KQ56qO4l8NBwNN VUYMPZ7LGPpl6HzWlADfFJw5XjgWjpT85YDZcKCzcLMZLOnCWpFgzb7TCOD13vzWq7XCK2 oK770yJlYJZ41nHeXxSMfuk0HeCYoag= X-MC-Unique: VLhYCD4QNLC9A2aGCCpjOg-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hORlFMMdoGURrZAV/Bmq7MtOuWP+kZMMsWrRNiuW1I3Ie/SIxOTwSp+2ORrKr8nQcNAkwrEgXSFzJUJRFe1wX0oiTt85gEu9ugHPVj8YqWrsB4hgk99ruMDwtPuV2sbxqEdK0e3glMbQcArTON8Id3F89WIJyEvWDGfRLcWTw0H9yfsOAWj3LLDbKytRER+ShZfagll27WyzZDCWGbahdIiZdXrVSi24iFY03oHgPyZPOGOVbA0fpFatq1zRay8yb0adZP0PvWYgKH3Xx7alhZ5AB3Cd/tUt7kdjefUcDANt+hZxXM4n8UswoHw2hPv4j+dI+PMPLuEZRxCQsjRTQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vKY1dVlvPdK3bVGlGUHgCNx1jyaSyO5QBUThZQNC66A=; b=W4sZgCk5D8a0uMORXvATIQxHNNo9t8KoRpgIXNHEn0uypB+FAtQAab0nlgj3FtKhUAOyJdSwHnR+HnbFn50hDeHMQ12WxH76ToYJenK7xhknK++ce2wjLj5ApxE7FPDapmDS29y+O05822MmbSGKcM4HuFX5aY/cUQSy6VgJ8LET01Dc8+9mHgPigbX0lIGE0/TTLme2rzaBUbU9tJE/8HiRXf5ao/Jd5mBxrUipi4cZu0YBgJ9WNuahymXYMu1eQKpIShRQqK3ZGofSKeNCpJzz4ieABlnTCDvA364LT/1x66zWuV/xbuBOTKfKAZMon/adGbJ17b5tRTlVTvx+Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 10:46:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 7/9] xen/arm: unpopulate memory when domain is static Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-8-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-8-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0041.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a21caa9a-dd23-400a-6a4d-08da42e201cb X-MS-TrafficTypeDiagnostic: AM6PR04MB4901:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NcHiECoUCexKyHpS929k0qMroup4Rlh4dG+UObqft8LJ08dPO4Rj8+sAC6G3B7AH3biePJgBFqlee8q6//6qaPUAAhH0WuxZzO80KBYMWD2KijuiUF2bxQeC3DIuwxDx7TQVoPArkc/aCsajvydPdv+6Y3LmF0Vs3Ku69rjz4kIkOov3tq8GW9YbBeA2pVcUQ1KGN42Gcid+LPVkIL4pgPmgfNhqrVgDdShBvnngW/dn5zOoRJSTmFUomJCOdmB3JbRNqUMDt3kXQCthWLHSuZQJsw38L9KKsTmL+9p8+V6ZaYZyKmiGVSzWffS0PXxvLVb1wEAJ6VBnd8EOwP4OmXA9mjZF95gs1JY2XdFnWnKCmtpACDUbN+CX6bKQ2oBRdLN405mW6SHHDGFvWPLXaFPCa4Zv7qgyAzo2HIVnJXtZSC7kC1ua3xccKbYeobga+H6GdpgIeJ0qmPMj8SfovbPctFgz+cdhRuZmyCRntsRidybhQkabbD0xRp8CcZmTYVPEF1lxKdWXd/2pcxnQfQO1OQrTPnuOC6y4ebIY/62Y+Jb/f8VXEio6nol0P6xaLcIJwqrHHAVmc/eDwzAZSbIsGUoz2xNH15YVM3VOs6xnQcJHS9as/Fh1s9H7AtjAwz16eKR09NFY5iZVcg0z/gBjPvhhtdhVwObFy336FoulJRCMDcIEzAjlFFLSQLFV0fEauLu5rd2V6X3+YaPVUAck2fM6sAR6XIkWquizD5kNs9WwvDkr+5RUBqVkkB7K X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(186003)(2616005)(66946007)(66556008)(6916009)(36756003)(54906003)(8676002)(316002)(4326008)(66476007)(31686004)(8936002)(7416002)(6506007)(86362001)(508600001)(31696002)(53546011)(4744005)(5660300002)(6486002)(6512007)(26005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm1mWkVDbWw1L2RiSTIyOU0wb0xsMk01SnBHYXZSZXZIQWI5Y1ZJUEVNc01x?= =?utf-8?B?dUlsUUc2d1lsODkwbHFTaHhZWWJ0bVlSQVBjbVR5TWJrVUYxT1gzUjZYRmV1?= =?utf-8?B?OGtQeEhrMkRsRVBRdUhTRDVlVGh0QU5Ea1lGVVBNQ3NZem5sWFBRZmQ5RU1T?= =?utf-8?B?L1A3RnR1U3Q3V01Tc0lzb1RKVC9FeDZmVTVyL1NHN3o5Y3A3am1tK0cyUmt4?= =?utf-8?B?a1R2d0RhbEZIVkVtUnNjUnRTOTJTdGNpQWJQVW45TU43NWhubjd5UkxoWVov?= =?utf-8?B?L2liWVExWXFiYityWXEzYnVsUzMxNSs5OXVNVUVmT0pwcS9IUHVZZEhLVVlJ?= =?utf-8?B?cXVaNEprVU8wL29NMUZKK1Nla1FRR0lsdTBZLzRMSG5TdmtETC82V0E5L1Jr?= =?utf-8?B?bExxWmJ0dGg4eERMdTR1RE9JWXV5TFgvVk04S3ZqSVN5MmNuYjkzZVp5ajJm?= =?utf-8?B?aFZRQ3d2c1dYQTFGTDRSRGNpM28xbzZLT3d0cGw2Rk52V1hxMWRaeHFsV1Bh?= =?utf-8?B?cHBxVk82alNvUmJnek45WjZiSWxsMnBJV016RGdSbnhJN2orcDBzL2ZJbzNo?= =?utf-8?B?YS9pZjY3TjFROGhZUFAvMEl3UU5xaUQyS3BMSDJuMkxaZkNVOVFFWmkrSXVI?= =?utf-8?B?TXVRVERLeE9xZi9zc1JEL3JGdXVzNm1PdTdNb3krWW1qRTB5d0hnVUN1UHh3?= =?utf-8?B?azNHTllrSkR0NWVBQllsUGNOVDBDbXhadjJGR3YxQ3hlaDlCeFRRZ0lkMHBO?= =?utf-8?B?NFdDV3pJYkpqSE5xQndMb0tsc3VmUlFydm5FWWQ1SW14bmdGUCtLVXRRaEQ4?= =?utf-8?B?NmFDb3RobVVDT2poTHBNWTU5YWI5V0NyTEFaWHpqQnh2UE1TTlpzZ3kzVm5a?= =?utf-8?B?Mk9ZMHBkR2NnalB1VUZsa2hxTUlCY293TTJ4bURubXlJVDE4Tm4wS1V3WXZZ?= =?utf-8?B?b1lmUEF5TG4vNlF1WjVZclJ1ZTZNZlZ5bVN2SkVhZGdlK3puWTc5ZUVQYXFN?= =?utf-8?B?eGowbXRDb1hmSmVvRkJkbTdEQ1NrWFFudDlJYVp2ZDRxZW1DMkpyeVNHUlFB?= =?utf-8?B?MjQwWFJXNjZvQmpLOHBVV2pqcjUyb2dwcVpibEZFWWp0YjVFVmNMSlFVbzMv?= =?utf-8?B?b2xzUERBS3lYbnErdzBZc1liSUNTWVpmRXlPTmNXRkQzR1pJRHFXcUZ4NUFz?= =?utf-8?B?S2RhQ1AwNFdqajloUTY3Y2JibGN2dm9BODN1VURZS3gvVkQ5UnIyVGJCc2ZO?= =?utf-8?B?dHBlSHNkM1lIdUJLQ3BRY0NXc0x4dDE2MkNJNjk1VTdqcGIzQ0tOT0dVY3Ar?= =?utf-8?B?akI0R1NoczFBcHFwamRHRVBvYkFmZEJ6SDBwT3N1NDlOVC81UFoyTW1JcVdp?= =?utf-8?B?VmZnRkhXSG9Ka2E1YmpRU3l1ZXMzbm0xaDhxVGhtcGlDbGM2S3QrbTFDQm5P?= =?utf-8?B?NUtvbXNVNG82eG55dlhzV1BuODVaczNCNHRvSFY2MkFrVDRoOWpBY1lnVTIz?= =?utf-8?B?T0U0U3g1RVRyT0lLdmpjam5mdjIzSXd0REZhNStwZlBLOXlhUUpwMTNqRjVR?= =?utf-8?B?Tk90NDhqSFBWcFFaQi9ETExEbGg4N21DZ3FRWmFHUnVkY1pWVHQ1RW4rc0Vl?= =?utf-8?B?UmlxNnhyZTZDdFo4RWVsd2FHRGFaRmJ3cDRQOVdjSzhYellYTWNxV3RuNktp?= =?utf-8?B?RTNTYjIrejEwOE9zKzg3d25MMUNXdCttcSt2dDhCMTFvL29Rc3JwNmNUbGRp?= =?utf-8?B?OWRObmNSdklUTTM5c0doaDRGMTFBNjlIVnVLRldrZDlheVdkZ282Wld2cU1a?= =?utf-8?B?TXN6UHJBdjByZnczTmJTcVBneFdoQWEvWWEyM0FWYk1VTDJRYlBucnBnTi9Y?= =?utf-8?B?bXU0QXdPcEloL0RTQjZuM3VvMFl3dC9tODhVWmJ1L1Jhc01NSnRJV1p5Umtj?= =?utf-8?B?NldLNFRyNm1kd05SeVk3UzVJdHdVNVhMNlhoUE1XbFlzUm4yMlppU2ZwalJL?= =?utf-8?B?cHZ6SUlZZm1PWXFGNUVEZ0Q4d20yUE9rMUowSW1ZMkhLK21EeHBOOEtrZ1hj?= =?utf-8?B?a2VUL25Xd1lhYk1WMnhCbWVuWVpuTUNNUDR6eGN6cUxQc3JHSFJ1MjN4dVNU?= =?utf-8?B?UHlYNUhJbXE0K0IwWHlIWEhMUWFIN0R0WFZHVUhEdGhldW11T2lNajBpZHll?= =?utf-8?B?RzY1NFlkN1FqWE42US9ZYmNCdkZXcmM0aWVQRjg2VkdOSHJzZDVjekxaSDFi?= =?utf-8?B?ZjMyT1JlbXdTTDloTzlSQVBmWGZnNm1Tem5JdzdOSC9PR2FCTHAyUGVVdHF2?= =?utf-8?B?YU5BbzVSUzJlWHN3cHZBZ0RwczVxcFB1TWF3VDZXUUNrSUxvM0NvUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a21caa9a-dd23-400a-6a4d-08da42e201cb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:46:08.7434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z56bD5xNuRO+eOoymjfvfY2AEN/ixWfn0nVIGmxQZTtuqixuDHtOxBUTeGyFooMHMmXXl+VCjFXFW3yS7bToQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4901 On 31.05.2022 05:12, Penny Zheng wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -381,6 +381,9 @@ struct domain > struct page_list_head page_list; /* linked list */ > struct page_list_head extra_page_list; /* linked list (size extra_pages) */ > struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ > +#ifdef CONFIG_STATIC_MEMORY > + struct page_list_head resv_page_list; /* linked list (size resv_pages) */ > +#endif The comment part in parentheses isn't applicable just yet. Please move that to where that counter actually is introduced. While this may be in this same series, there's no guarantee that all parts of this series will be committed together. With that adjustment Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 08:49:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:49:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339299.564133 (Exim 4.92) (envelope-from ) id 1nvxYm-0004pR-2g; Tue, 31 May 2022 08:49:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339299.564133; Tue, 31 May 2022 08:49:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxYl-0004pK-Vh; Tue, 31 May 2022 08:49:03 +0000 Received: by outflank-mailman (input) for mailman id 339299; Tue, 31 May 2022 08:49:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxYk-0004pE-RI for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:49:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84bc0136-e0be-11ec-837f-e5687231ffcc; Tue, 31 May 2022 10:49:01 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-22-eW0TRB5XNcmtU0wCinHNZg-1; Tue, 31 May 2022 10:48:58 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4767.eurprd04.prod.outlook.com (2603:10a6:803:5e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Tue, 31 May 2022 08:48:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:48:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84bc0136-e0be-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653986941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yB5KMgF/thjv6/fbxCHH/G63rFuKteY0TBslkJ4aQT8=; b=P2pe00P9SW4U0R8y5OOsroth5XcGXZsd1tBO6+hyLOaPRZXvRHL/owIuVSsSgaLI78B0Mo NCD8VhYf8G+ebhsA4nz268MqBvgV7QoHHBVXTGLAct3SvaLDrk93EzRCkRt15VeHYugukk laTx3tPC+FqZioFlkJioWQbuKpqUsaA= X-MC-Unique: eW0TRB5XNcmtU0wCinHNZg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akrHeXIw3ELb4RU0QTfaXOvS2rkbMOiXketzfsmCgYqNXDt8x2HNTNx9r0IqPxxwYKg9AmZoD4Xi8UYQ5cjItycooPuSUIxEaPRfR+INiFrYrxBR3nOu+xOiAqfki13TpbXPknpbD86Vhzo0sx1WSL0ZacYHIiSFWnpPV2jQX5dSah7jqLrrHxuEUJ29iMPLIs3Pw131Ji8I/tWR4ASBjwu9sVG8JJ+huDp2I4zI45ruUBUemx9OLWNmphAO+uXenKC/zMWxAOU2NlUs4h1MjnMdwVLk66OJVNZzAl5K8Gs233fAvUZJcjwcomN7oT25iOw2FI0EGKt/C2z2c/WnuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yB5KMgF/thjv6/fbxCHH/G63rFuKteY0TBslkJ4aQT8=; b=ait56F43DyG8SzuVl8lRzQwud3cAJUuQ9bURLOKBdnOhorI7ina4hbY29HaRFZ7jF71K/zzEZkDr6swe3v5XWpJA4TQLpAUFO9OAbDi7kCfyG4oSEcsC+NarvNizrqNaV5bNdxv1OmO9yBYCBjZzzgKa0ldAHL8uqrnkiH7xYJ5gNCWjHg6kHGP9sJw5QXoFAYQtrtS47Y5GI+xtk6bqpskuhz2tbH9zAZvOfffoYFBmKnnqq12f+ZszbBhGTl9uwDSaaYqlgRfb1dDBKw/XGOP+siY5499f0r9CFtQl3pfjNfUaLJ1oFpIu7Ad6sUCGGV9ugJUjcR4C+ONOJUfZIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8f8b6b07-fe70-5468-90b1-ae5da1495200@suse.com> Date: Tue, 31 May 2022 10:48:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 8/9] xen: introduce prepare_staticmem_pages Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-9-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-9-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0016.eurprd04.prod.outlook.com (2603:10a6:20b:310::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b692c38-f13d-4450-a0c8-08da42e265e0 X-MS-TrafficTypeDiagnostic: VI1PR04MB4767:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +PA0EECeJXKCUPEzD7EDuchfHyYPOLGg/7YeJ7mmhFbPMTlSyoB6aaPwS4852tpDB/HjABECZQ95+lNUmOkHetUKDXPPLmRJ9+jC9k+3lQCrZWGEyLpRdgg9k8H0c1mDExIl8N6vQaLyy1EQ+7qc628iDrBuLy6FOfUfKIoY1rllWfIclA3Ol3grIeUi2kb+UsmIb4zBjEao5GqC5f9G3d1HY4i8TwFTCvwPUAThNH/Js6vn20ZRZiGY5lIjloaIEOCJW9x1FxDoc6yMz6XuooSVL0w5pBGctyIJEZVoVpsL9tMmp7OEbsz2B98To5CpAc/C8SL9d74z1+2LaDEp6VpN31m9ZioXmODSgCBPCWtNwta7kqqnw8RJqSoUWj50F1AgPR8Gra0B8QUTDLDZvYFrYJRBzjuRVS2RJZ1hyNlopx+ISoPCZt+Axuw9enE+WhGQl6bB6bC/pdl2JzxVf7WD3czClojtHXZnVYqRvc26JCuAwgsVJSK4zGsQW5zy3JogKUxl97WWe8Faszlf1SxtvbEXqj8H03UzVzHbQKXuVafo6e8uC3+8W0KnsaDguOHQrXpPlvm9qyNiWcOjDUAnuhRVnEgK1dDzH8cTKTmrR2k3iXqzBIwsPAeL17fkCJma7vXNEupoAc8UvApZbiRHr3ujmmSQln0I4CUN5xiEHA3Hf2mr2ZH11NI1x4sEB7PECutap67chd7qgrhj+kAA+F88NgS+wgfPBXv8inwVWMs32rk/xzURPk4dzti/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(186003)(66556008)(66476007)(2616005)(54906003)(36756003)(4326008)(8676002)(6486002)(6512007)(53546011)(6916009)(26005)(316002)(2906002)(508600001)(5660300002)(6506007)(8936002)(4744005)(86362001)(31686004)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXloaEhEZ1Vrc2l5bUI0VzZHM1lLYTEydGZQalk2aU5RcUgwazZSRjR1bFBz?= =?utf-8?B?bWc1aGVjZGFLcWNRMU5FRjdIaGVGVE9TMW1NN08wSm1KTEp6S1p6aE0xcXpo?= =?utf-8?B?QS9Hc2tpZUh6NUI3enBka3V4bHZrQ01yQURJRkRpNXRrNHNxVVpyZTI3QkRy?= =?utf-8?B?UlFkUmEycGVvOUU0Q1JSVzJpZTNybk1JaDJJaFMyMFNuOXY1dGpBU0lsSXBt?= =?utf-8?B?SVhnalJncDFWUnVDL3J1ZlFIY3ltT2c3RE1WTFEzTktqVXYvMWZqN1BlRGRi?= =?utf-8?B?MEFqZU9MZkJOa1ZkS3owN1dCVG4yYTNWZ1UrT0ROcC9jSnh1bmk0aWdoY0VH?= =?utf-8?B?cGt6Q1ZJVk1VL1dQUlFVZ0tHcXdDeVVPLytFMnl3L21mSStuUzZ4ZHl4c294?= =?utf-8?B?WnEySGl3b1FSRUR2UGhkTWhBRjFaWWc4R25ObTV6a1VMTEFuSS9ZRkkzTzNr?= =?utf-8?B?SE1NWk9UMDBlYXlnVjV6cVMwZFpuSDhUdzVsNUpHb0J0eC9oWkk5NnRMbzVP?= =?utf-8?B?V1pTSjdFMTU2ZXRtQmJ1bjNmb3NHalZsZjgwUnlaeUQvT3ZleEhYTVQzb2pY?= =?utf-8?B?VElXeXltTjdnODIxdEUvVjFuMmF4WDcxS1pNbG4wbkJKa29PY2dZSm9HSFNq?= =?utf-8?B?U0JaWTg1Ykw1akFnUkU4ZitxckNvM1VUeGpZR20vbTJDbG9qekZ4cGc5TWFL?= =?utf-8?B?djF1a25SQVpHaDM3WnJVSjc4MDg4MUJhMGVaNVNDekFvczdHNTRaUWlTN2lC?= =?utf-8?B?aVpOSStWMkZmVmR1YmREaGZyZmNPckJkTldmcCtjeDZGOXhDZHM2OG1McHk5?= =?utf-8?B?eitYWThoRDI2cS9RL3BGbEc5ekJ6UG5MNHV1RmhYakdJSXZlc3hscERTK014?= =?utf-8?B?bVZ2dHYvNUhTdTR3MmxzbDU4UWVuNk51WFM4czNTZkdxTkJxNHl2b2E3aDFr?= =?utf-8?B?VWpWdVRhZjcvQVZUeDIwUTFxWFh3RnVjMUdac1gxVXQwcGc2NmRHZFRMRWxj?= =?utf-8?B?dy9sTnZ2VmNJeHA1M1Z6L2pLY0VpeTBVaElaS0RGYTBpSVNaN2R6eHcxNDAz?= =?utf-8?B?dkNYQXJQdUFLV1Fzb3lrSUQ5eFRlNGpHOUNpaGlJT2gwNUtROVVib1NFNHZE?= =?utf-8?B?NjB5WmU3Tmw4YytOOVZQSS9XcjNWcTBxUUJua1NOK2ZvM09HSml5elN3SFV0?= =?utf-8?B?TzhGYUl3SFB1cDBMUk5PNGdsVDhRNkJKdzIwSmo4UE5LRVg1YUVSYzNYUGxF?= =?utf-8?B?cXgvQk9VRTJFVGM5T2p3S1hOS3phRVNYT29zMFRxUFh0RDdjVmFiNDkrK0lh?= =?utf-8?B?TUZoOHlHdXdHV1VpYWR3Z2hCTUpKYnpoNUNLc0hMTmwwNGYxOVAyMEtsZU1r?= =?utf-8?B?WXJHeDZRK1d3cmtUY2YyeVVrQjdyVi9CeHZkTTNIdzluTVlJYk9STjFDZ0NN?= =?utf-8?B?Z28yMUJna2p1S2NGTE9FMFZ1N0svRE1xcFJXMFZNNmo2ZGk0MUljWjN1Uldq?= =?utf-8?B?Ymxyd1dqdDRUVFoyNUErNWpUU3FCRGxBUFpqVkZNbzczVjNtU1lIbTRaM0hK?= =?utf-8?B?YjVpeEpiZXRVS21qU3l4MUtXc1Z2NEJNMTFLdUoxV0ZiS1BuTk55YUNOSHJx?= =?utf-8?B?eVFSd1F1ZjBKQ3YxMEtkTGhXdEtZTG1BLzJxL2E0dTE0S0MzUkExQ0tmZTVH?= =?utf-8?B?VE9GNkxrN3pEVEduL0E0dFdKdW9XWEx3bm1RV1I5OFRGQVVHZXd5UTlEMitM?= =?utf-8?B?UGIxRlhFcUwwd2s0a3B2ME9nZ2lHS2VJTVV1TWlpbkpnUldqNHFWSG0zSDVl?= =?utf-8?B?cGVrdWE5eTlWbnpmaGdOUmlzeVc3S1FFOHRTMWltMmhxd2xFYU5LUWNZeWJI?= =?utf-8?B?V0dqckJvMUFhTkZrSFV3dUYzU0ZCS2RQZU9JOXkxWFZLL3lQZlo3R29YMzFm?= =?utf-8?B?bWZpOU5NSmFIa29nTlYzRkpWbEw3U0tmSUhBZlNVWjZHZ0MyZG9NbTRuTmJP?= =?utf-8?B?T0Qvc29TY2xFNlpwbmhvVnFTUXhJbTZVdXo3TzZzcXppeGdSUWQxWVM3WVBI?= =?utf-8?B?d2ZXVUErREQ1dHd2SEFVeGZSUUxQWVh1ckpnZmV6WkR1aTYrM2piSlM3MjBM?= =?utf-8?B?SndyVy82cm4yM3A1a1dxM1NNam1zMElPeWRQeC9WcHNlTHo2MndHMi9ucVY2?= =?utf-8?B?NFdqT0tYeTlsMklMTDAwelJzTkdEOEZKNE8wcTBoaFJvNUdaall6ajYxVFds?= =?utf-8?B?TXRRVVdIeE9JS1UwZVozbE5xRFJqTVpTaHhRMTdpbXlFUmptRHFJNTVkM09i?= =?utf-8?B?UndkMjhaNU9oZVpwY0htWStJWExzangzR3lHWFlzOXp6MURZUEJVdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b692c38-f13d-4450-a0c8-08da42e265e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:48:56.7171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y8k7PpLu3wGO1g4VXZAdvqF03B5W/gPQxhfHdBPxDQGlxP+nq35Ymf4q+oq+XsxJthvYrFjwh37qjXfox+AR3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4767 On 31.05.2022 05:12, Penny Zheng wrote: > Later, we want to use acquire_domstatic_pages() for populating memory > for static domain on runtime, however, there are a lot of pointless work > (checking mfn_valid(), scrubbing the free part, cleaning the cache...) > considering we know the page is valid and belong to the guest. > > This commit splits acquire_staticmem_pages() in two parts, and > introduces prepare_staticmem_pages to bypass all "pointless work". > > Signed-off-by: Penny Zheng Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue May 31 08:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 08:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339309.564145 (Exim 4.92) (envelope-from ) id 1nvxeH-0006OF-Ti; Tue, 31 May 2022 08:54:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339309.564145; Tue, 31 May 2022 08:54:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxeH-0006O8-PS; Tue, 31 May 2022 08:54:45 +0000 Received: by outflank-mailman (input) for mailman id 339309; Tue, 31 May 2022 08:54:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxeH-0006O2-2S for xen-devel@lists.xenproject.org; Tue, 31 May 2022 08:54:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5083e47a-e0bf-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 10:54:44 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-PLW9RIjTP6CRdQTac1KSIQ-1; Tue, 31 May 2022 10:54:41 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5665.eurprd04.prod.outlook.com (2603:10a6:208:129::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 08:54:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 08:54:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5083e47a-e0bf-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653987283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aE2dBkuFXE78Hg51qAgZl+LxP+fyUswFpq7Dg+SfDAQ=; b=jmiotiq/mCHJLKcn+ax+I3W5BIXQ+cvCs2oV3rv6IIGr2OX9+/QIvP10YYR98FOgJI7ToK wahswTJwrnURyZAqVlmn3pQG2B5VyglwQjZaqXp8N5mMi5BPdUCzrEyGsRUPu3gj/42u2Z iJ4tu+ECfv0YyzCuQYeBuBpqxVdcbhQ= X-MC-Unique: PLW9RIjTP6CRdQTac1KSIQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aw4q0OnawBzI0Io9SIznulXJ5f3diVWycJckKK+IAPsznx4Rt/Bworaoylf82N6XRhm7RKf0rghAdzACUv33MKjB7ak3XB+TFhcHvANPJNeqkXwnrw2PmKzBL5YpPpKfYcoBJGVSxsloeJKdhnuQT1htjvRdep5g0eqNGpH1gY+/hyM9YE4EtvraN0w5D2N2FLXR+2DvwDEJVIfx5mCvyRX6g19C5pe9a8g9idzBqDn0Vo3zVaFqBkAMMVqO3c0SP7Re/MkqWvUyRFxWIO8kkLBqUVQk8OvNWjIl9HjA1SGy6smH6HpVrE1cCmyx9YAwoNE4KPrt9Iqx4GpEaigVJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aE2dBkuFXE78Hg51qAgZl+LxP+fyUswFpq7Dg+SfDAQ=; b=nNnfBmZHVu7GqE2WaeUymtxmf+ZBzUoVYiqFwV8hQtwi1G2FekuI8NGR3q7BAElPJKmg6fW+iDXm69o7cEBrAITDieATzxETFfSAmzWYk2hgPWYuXRLCc0I1YlBzQa9a3GvPujmv+hVj1NIOp73q88UIyWCpj7IeVuUhjz6RbmC1PfXDEzxM2RGuLG2Uwc5xKQyG00IfNLSbMZ1Ju2dYV0URo0Ts270JJ3+6R898JrsPvELmR0kjXq7YHXhSsTLzg24rhCZBOcPOqBEa49di+TrKDA+7KDdv02Dfrv1xMVG2WLMVGd5hgq7xFvchxqcr0tuaLt7gcx+u6izgSdUQcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <104c921e-68ad-209b-5b3d-797a58e47fbf@suse.com> Date: Tue, 31 May 2022 10:54:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 9/9] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-10-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220531031241.90374-10-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0035.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::48) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fab3e40a-d052-411d-f6cb-08da42e331f1 X-MS-TrafficTypeDiagnostic: AM0PR04MB5665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wbsohjJBRmOJnUuLRNb7Kq9S+MlKrxHMHz3ibG5NomM3W6uJlR5EYWTOOLo2ELvlMyY8FTzpn7Sqm7nT7FIRZdMkiBEa8Ky5n4W/qmEkkd4J7AQR5FYBTHkrPRB+37UBGgYPCB8kj7QEG4UT1KVLVyq6hHkKHzNj3tvf4/NhjJ12GizEGUYP5t9zPrLmxeZXqVGFCT2E8yZzYpywpk/3wvZbCAvyFra0d6FK4Dm6W5d8HkJo6hO3sfd0vHzRV2qyiwFQRmFbu9rWTZ5aHmbElrBiFfhuhTbTriiiu3wvoU8LTgY5e9eNra4QIyjINJbrabGS3KbRMqlVIlP5iJDwSP2j5rQqzz6K+s3R8Fn0T3BJ3w5AQuu3GI61IloKeywVTmbw8j1B9zlZ5ezJ09m/E4wKaWDaTZg6w+HFPjGWNkWjbJm4zOlUToDDCRRJq7kq2ZqY4Z0o6qo5INKG1muJpc/t2F6SsaTUXtGOma718g6yQXIhhYzD75LKJFSfFhhTAIiCeknbIhu245BzFcIEOMhi6p1ybi/Uv5wIEGWfdq6NSu1ZFj9gRYAAgB6ofs+HIxicXFIvRaDWKt23Mk5oEq+49vuiH7m/7q4JOoCwjZiTz7X8zUe1IHs6uhnxYF6QpsqSsaWSgUnn4KJ9SKyvaNBdy4HAnt1K0sZ2XUbHBiXGVgMpkSCWoQykl3Y61oeUh8rllnqsmBmX0iyGFmyk1Tz3qwQ8YxsoGlVNlZaTMBk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(31696002)(86362001)(54906003)(66476007)(66556008)(66946007)(36756003)(6512007)(2616005)(186003)(38100700002)(53546011)(2906002)(83380400001)(8676002)(4326008)(508600001)(6486002)(316002)(26005)(5660300002)(31686004)(6916009)(8936002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlRERHAxbEJ5aHc4ZTlnRWFaRk44V2tZUndvNWdaL3ZVeWROTTlrdS80YU5X?= =?utf-8?B?QlhCYzMxZ0ZuR25VOGI3WkFNTDdyK3BDN0VXT1pXbFhmOGFFUnR0M2tCNzJx?= =?utf-8?B?aFV3bEd0ejZSbUpZcnFpMHNtQUxReFpGUUhNNTh3aEtTT3UydjNIVjZLRkpo?= =?utf-8?B?UEF6QzlBN0RYRVNlU1FPWmpYMmg0UVlCVEZNK1dGb3hqbUZXSHRtNnpqYTk5?= =?utf-8?B?WE9lbElVZ1ZianV6aEJUeERkZHNKQW1XQjByYVNIU3FvYVZzRmJKQk9YYXgv?= =?utf-8?B?dzVocVVKa2p6RmM0MVBld25MUENmUE96Z3ZyVnFKVHFveVJFRmNWRHJTRUds?= =?utf-8?B?SXRiSjhxTzNNckhXUU1YRmNkVENKS3o0WXFwbGg2WWw2K292VFVqaVd3bytt?= =?utf-8?B?enF0K1pDYVdhV2J1SWw1V056akJJYnMyazNWZWovUGFlQTVOMk9RdklNaWtE?= =?utf-8?B?QW55bEQxWjlIaWQ1S3M0aGtWQ1V0clBXZUlqZnUxYVF1Ly9tOVhGaWdLUVYz?= =?utf-8?B?ZFI4Ukl0bnFENW84Y0dlYmU3MlNkcHNBUHNqRTFNd2N6UHlOSnNPd3d2RkVa?= =?utf-8?B?UXdTY05uYmsxVHJsYUhsZmp1aDg4c3NjYkJROFM1YXFSTTJVYjY4VU05SUdk?= =?utf-8?B?RFZEdFl4cEFwSUtmcmxFUHdDREZjNUhCR3BhcllFc0FIcHhFL0NGRVZkMDFx?= =?utf-8?B?SzRGWFo4azA0eEM0TTdNZ1RBcmN1ZXk0ZlgxWlY5OFc1dFg5T1duR2NTdDdY?= =?utf-8?B?Z0xOZmIrbnV5SUkvTFBma09kT1A2bElYSlhWeXJWNmVMZ002SitIbzV0WDBT?= =?utf-8?B?ZjhOQjRPYlQ2eGRjWFpOTGg5REg4bngrRy9UdDE4T3gvT0x1a0hIWFczanhT?= =?utf-8?B?OXhsbEx0S1dEOWVIMGQ1OHR4WnlmLzB4akJsNnBvNlltaUllWjlvS2MvQ2Rx?= =?utf-8?B?RzhVL04wRXhvWk42ZVoyb01wVE5rRmo2WE1EdnVyYlBLNGZ4MzhwUVAyME5N?= =?utf-8?B?QUNCQ3R0L3V6VklHbHNBQklIdTB6QXFDWEgydmxiNjloUGRCWEhxbUJzOVJo?= =?utf-8?B?RDhtVmx3N3JTdHRXNEhRY3FXWnBSbmVKSzV1d1RmbXcwb0RyWTk4UDgzU3Vl?= =?utf-8?B?YVdUSU4xelpDYkRkVDNWSUdYL3c0MXBZUFBwOUpnQW9VSE1ZNXlIMG0zdFh2?= =?utf-8?B?RWM3eUoxOXdYWXBYcnJzalpyYi9RQnF6QWw3azZqbWFyUTA5TWxKTWRwb0No?= =?utf-8?B?cjd4cC9tSUdZTnVnbkdKVit2VTlEK1YyY2s1aHNGaFhrWWt1dEpXQTkwNCtD?= =?utf-8?B?UHJuSXp6Ty9tcityWUxROU16dnhUdzdyNE85ZU9NTnhYREx6a0Jaa3NnZnBv?= =?utf-8?B?NWNxVG1ySmtWaWJpTGpUcDNiYi95bnNIV2FLVGZqRFBrTWhIUkpaK0pSYm9Y?= =?utf-8?B?OU90VGM5bFl1dnI0ZHhmTktjNWlMbHZKd0puTXBDcEluTmd0M2tBNXU1RXNu?= =?utf-8?B?TlJiazc3Z0ltSUhGdnBPZHkrNUhTcUx5ZFJYSUpGQ2VaUC9qcWdPQS9vRVkr?= =?utf-8?B?VUJqTDAzUzFaeHZrVG8zR1cvYndTenRPbGZQeXA4Z3U5empSUk5uRktQQ1FP?= =?utf-8?B?UGFHRU85Rjc0N3VNMkE3RUhLeVQ2WmQ4WFNPZmI1R1VRdENDWjN5b3JuK0VY?= =?utf-8?B?S2FMcXM5amQ1WlczdHJWZWRlZGsrSFZERmZZZFdJbDhNS0ZneVp1WnFGNnRn?= =?utf-8?B?NUlxTFBuQUJRdGwzaFlaYjFjbUF1ZytHMU9mSXdyNWhYbmFtZThqc2tPU2V3?= =?utf-8?B?RGRFUUlJOXliZnNhcVpvb1k0RUFQUFNGdXpteXJ5MWw4UDFDakd2Z1N2cmNF?= =?utf-8?B?RHA2R1ZPdElJT0JLZGdEZWpmRHh6N1hIeUFMK2c2ZHpjdVBxdEFEWWRDRGYr?= =?utf-8?B?TEFaQlA0dUkwVTJPOEEzWStGQlZ4cGhxVzFldVo1RndhUWlpMXdSeTVoREMx?= =?utf-8?B?d2NPYkdMRDNLa0kydCtCd201ZlZPK1lzdE5wem1xbC9tWXFJSkpMTHFjQ2dB?= =?utf-8?B?RnI2MGQzemt1Z2RuR1IxeGU2Y2tXU0loK3h1SURwTUx1Z3llRjVnTXhaeGJD?= =?utf-8?B?VnZ6eFpKUmw4ekZBQ3dyMUV2ZjZGeUlqNjBzMEt1V0JLaTV0bHJ5UFRSVTNp?= =?utf-8?B?OHc0UTdNNzRSZWprWHlqVUo2NG5YbEx5R2FNNit6VG9CUWZBb2UxcW1vOWVz?= =?utf-8?B?WnYxbzFFY3pyZ0ZHSnNad2VITFdFTGNQSnR6NXZ5T28wMi9ydkFPQ0hBZUM3?= =?utf-8?B?Y0dNaHBhdlFqcnlncmw3SytLbzBwUUp5YnpsOFU0dFhZN3hSMFlDQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab3e40a-d052-411d-f6cb-08da42e331f1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 08:54:39.0390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IAlsJYkbMMCR8+Hi1pOlQSl18TIp84UVndapQ/wGF43n1FxjwFdicTtyivwEBxHrMvbj6S3R2nSHebX18aSuSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5665 On 31.05.2022 05:12, Penny Zheng wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) > > mfn = _mfn(gpfn); > } > + else if ( is_domain_using_staticmem(d) ) > + { > + /* > + * No easy way to guarantee the retrieved pages are contiguous, > + * so forbid non-zero-order requests here. > + */ > + if ( a->extent_order != 0 ) > + { > + gdprintk(XENLOG_WARNING, > + "Cannot allocate static order-%u pages for static %pd\n", > + a->extent_order, d); > + goto out; > + } > + > + mfn = acquire_reserved_page(d, a->memflags); > + if ( mfn_eq(mfn, INVALID_MFN) ) > + { > + gdprintk(XENLOG_WARNING, > + "%pd: failed to retrieve a reserved page\n", > + d); > + goto out; > + } > + } I'm not convinced of having these gdprintk()s here. The adjacent is_domain_direct_mapped() code is somewhat different - iirc only Dom0 can be direct-mapped, and Dom0 having a problem can certainly be worth a log message. > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + > + spin_lock(&d->page_alloc_lock); > + /* Acquire a page from reserved page list(resv_page_list). */ > + page = page_list_remove_head(&d->resv_page_list); > + if ( unlikely(!page) ) > + return INVALID_MFN; > + spin_unlock(&d->page_alloc_lock); You want to drop the lock before returning. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 09:00:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:00:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339318.564156 (Exim 4.92) (envelope-from ) id 1nvxjU-0007kd-Kv; Tue, 31 May 2022 09:00:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339318.564156; Tue, 31 May 2022 09:00:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxjU-0007kW-Gz; Tue, 31 May 2022 09:00:08 +0000 Received: by outflank-mailman (input) for mailman id 339318; Tue, 31 May 2022 09:00:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxjT-0007kP-5q for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:00:07 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10b3e9a3-e0c0-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 11:00:06 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id j10so20288166lfe.12 for ; Tue, 31 May 2022 02:00:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10b3e9a3-e0c0-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xn241K/WzSuVszlXSeXsZNWKauUQmaANW/CPCHgDjaA=; b=I9ioFXkH6MqeWIQyuvvtsUJSE2RMM9LL3+SoyTmAnNPZdD35SZcdzInnnTHdvYGihh q4gDqzrTFON6HmACP0FRVF3ajwvssfcqmZo4qqurFGNFbUkIhzu6SDrmWfSzs4qZdL+J yfld1NEtwMe+MmPCanKaOzvMlWrg3ul9LANu5yeDiUgSEJkxTebvhWdp+QBYKLKNHI+t iBud6NrohGBFBcSSgfsgHqzvPnRL5jJChNGdJep6FCgcjkxyH3X4gJ0KJcNECEvqwcJO FOeMfXm2EVA7nJiEIMrn+ESCZkbXJxlZlCF9jzoEe4rW0C4DgxVE99vl/lxVdFt7gEUh QDLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xn241K/WzSuVszlXSeXsZNWKauUQmaANW/CPCHgDjaA=; b=vJ5AaLN8ae3QO16AeAzX+kOsBzKOXceE0CGoDRDHCOlZGtd8LeYbmyLPk9TNiMaT3z zurBKVzP9Q+on9UBGsvBS8dY5aOlPz7OUh0E2v+ZttXKM23YsLEhN/392dFsF9uGS+XP pr7fa+N/1h4m1BjKaq+/eWPRNySZ1drhyfeVPISR/7A+JxsMxqtJd3BbxCmOQqUDG19K CsCvYt6NH/pqGH4U7khD/TrQMX1D4VkE/yo9U3+Zu1Wp0xPahQN721UHuvpCQODXqETp GEjkLIijRxcxqOIRU2hmm/BC60/OSojecqOqFZ29C2zVRPDgReZB2NJXYZQikoA+7ZfM fHMw== X-Gm-Message-State: AOAM530/wXNUwYEBVFWaAd2XhFO8KlTHj7BtOItWqH0Y0rPcqh0xOlKp 6OJKgiGkLpuIzQdHflmf6DjONBaC4pd0+ZuxO3Q= X-Google-Smtp-Source: ABdhPJwIW/uQxYLqLH+1KGOhSAO2rLxzaNU5jCVrikbRAIQr+7P6DW7lIPZZcYlcRCWEnaHE+lltYUJjchlPv+sIYRM= X-Received: by 2002:a05:6512:3401:b0:473:ce5f:7945 with SMTP id i1-20020a056512340100b00473ce5f7945mr42054983lfr.636.1653987605663; Tue, 31 May 2022 02:00:05 -0700 (PDT) MIME-Version: 1.0 References: <55710c63-c531-3330-786d-ec6349690311@suse.com> In-Reply-To: <55710c63-c531-3330-786d-ec6349690311@suse.com> From: Xie Xun Date: Tue, 31 May 2022 16:59:52 +0800 Message-ID: Subject: Re: [RFC PATCH 4/6] xen/riscv: Add sbi.c, sbi.h To: Jan Beulich Cc: Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Hi Jan, On Tue, 31 May 2022 at 15:54, Jan Beulich wrote: > > On 31.05.2022 08:57, Xie Xun wrote: > > Signed-off-by: Xie Xun > > Is this correct / complete, considering .... Thank you for pointing out this problem. I have read the submitting guide https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by and it says that signed-off-by indicates I certify the patch under the "Developer's Certificate of Origins". And in the "Developer's Certificate of Origins": (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or Because Xvisor is also distributed under GPL, i think it will be correct if it is signed-off-by Bobby. The problem is that I did not modify this part of the code, so I want to know how to submit this patch in a correct way? Thank you for replying. > > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/sbi.h > > @@ -0,0 +1,275 @@ > > +/** > > + * Copyright (c) 2021 Vates SAS. > > + * > > + * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com). > > ... this? > > Jan > From xen-devel-bounces@lists.xenproject.org Tue May 31 09:03:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339327.564167 (Exim 4.92) (envelope-from ) id 1nvxmh-0008Ti-5C; Tue, 31 May 2022 09:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339327.564167; Tue, 31 May 2022 09:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxmg-0008Tb-Vx; Tue, 31 May 2022 09:03:26 +0000 Received: by outflank-mailman (input) for mailman id 339327; Tue, 31 May 2022 09:03:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxmf-0008T2-5Q for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:03:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8680490f-e0c0-11ec-837f-e5687231ffcc; Tue, 31 May 2022 11:03:24 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-OdJEqrylM4WWzzIKq-maCg-1; Tue, 31 May 2022 11:03:21 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4389.eurprd04.prod.outlook.com (2603:10a6:20b:1d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 09:03:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8680490f-e0c0-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653987803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+XXGINd+vyXCDIMq8ifrggk2Suqyy/MwmeDVjy+D6I=; b=jyffy3i0btNLTKOEvnIH/k5Za8a3l8pUxtK2YQKs3HBZ9bf2wzBW9Z48mBfGTQdTZpWi/c GCqHVcPSmervjS9kRhAGgDj7KbKUmwbgAwI4SjtIDFMpj1LafoRjGzi3lKrD19zEU8OPTm 7wD5R3qjaPvST6CBRk1e4JEJteYH2Jc= X-MC-Unique: OdJEqrylM4WWzzIKq-maCg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRciIQ+M4v5+OH5K68a38/7wLHisXcXFNAZocZrgUbd8wDlmA0LLsLPz+mLeLyXO0708ZUFbMMqI4WMoubyAJ25PhR2jTv+C5EDPgw+g1OAtGDfnQFUgHI0UnGBc4IbzivExPfANS/tHLJYcIx1Y9zIVxjFzkWP9ChHUPkLK8AOk5i/9CBdEQNhS8h9eloCUrRyM7ZibG3grtd50u2V6C3HBAGSP32yj3pk8iZ9giDmelFzAPPdqemmQHXZK6v0RQxBbRHliy6JKLajfduTSuxQw1vOR/p3qmjcji7rxpKcOEHUatBY79786RlUBZxzfJmAJmZXrST7jo49d3J9DnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y+XXGINd+vyXCDIMq8ifrggk2Suqyy/MwmeDVjy+D6I=; b=JKmnCqnPkdEDdd0ZzEUtYSVaTHin6RyNmJAm9OsjMwmoEcpXwncHQbCWVYc2Xr9B4rbv9T1x76esyjihcSAYGRWrL+Y8l7dnwma2ZTEH63ifUMjh1KxPHhZYFmK4PuZ8NtgKk9KTZ8/A5Fgbe3Whk8QRthZ5oSDslQd93nis8UC31fiYInL0AFVaChlBIkRhXf1cj0hfbsF+Xe+BrHZSEP5zqvXjPv341kWZaTAPZNAvsCCJjc1l8Is7Z44VxqFCGfkEYaIJuubbBRLdDV0D31LKUt7a9fFshb5+5GA31C1NjxQSoxPM4RTVCKiMvkR2eROydRnPkn/N/GPU0/G1bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55be7afb-dc71-fa26-a1dd-59e573b9ac4c@suse.com> Date: Tue, 31 May 2022 11:03:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/1] tools/symbols: fix memory leak in build_initial_tok_table() Content-Language: en-US To: Yuanjun Gong References: <20220531082320.31294-1-ruc_gongyuanjun@163.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20220531082320.31294-1-ruc_gongyuanjun@163.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0018.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1d77d3b-118a-4bb1-1db6-08da42e46826 X-MS-TrafficTypeDiagnostic: AM6PR04MB4389:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K3OvK+v/yU8Ul2OKIu+oIqXpNlp/stHoQBNNgbXXup+PTdM3MokQXcZm6v4Djy4PAgdotASlgBwTDmiR7ArcQpe3wAdMSIASi+V1pFZguQ4pwaV4ukzzrAOO/8O0/IDNVwaS+odrGBTwA3/a3hEoi69EDIA8WHbjqyMVe0H4hMrULCLcTHEj5mpYvT4meIiKEbXkJE2oU4LUCH/WwM12KQy8HJkNQD14bLRvlXYbCpzusbuLjsHf2cB0Gc3Ynh7kTGrlMz1nEnRfnWPjygltZZB8dEMlyjRgM/FR5kCU94WW+IEP6yfvg4sngcDb1tAbyvUDuWQDLaMtm7pUlZBmt17WTdngQruADC7cJzvXAl/nOitys+J+PsoAoeIroCCQVUXntb0IQzUyl1bvg4ZtkEt+bwWxNNgCihE09pKS2RKRKecVmSV+ec5Q5E+E61Y3KVJXZBsdkfYai4STT2kD8v4zfuEe/Zo1c2mTOacfVemG5j4eulcATdeH5RqgC4hKx5HSBJsVIZXoTLjRUiNUTwZe0EfOXaN9ViVRVGnsXbt0zutsq4rRwD8azjBKOuAR40HdlVqnqWHtRXMurhMYSHh4LxgImMXS1K+ejVJk6N8DtUuN4mDJ4ZTKYIXE0gbuoeD9AGyIyWQbqElEXG/KbZLFr68q7DHgwd0/gFfzEiKCRDA2AYzSdjE2DSuQZUBCXzB4MhvvVSfzUbghBYjMioqyhFhKzZjbj7OVlfX6aZQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66476007)(2616005)(66946007)(4326008)(8936002)(66556008)(31696002)(8676002)(26005)(6512007)(86362001)(508600001)(53546011)(6506007)(6486002)(38100700002)(36756003)(6916009)(2906002)(186003)(31686004)(5660300002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjlhVFNxWjQ5SHVmcUtHbXcrR0tHR0pwYUE1YStjUkFFR3g3RmxOcmdKbEhW?= =?utf-8?B?RU94amI0SkxFTVY4L1UxK2NHQmVmZlBhTGJCSXZMSmNWNjQ4YnI2RjQyRGsw?= =?utf-8?B?Q3FHY1I1d3U1OFNCcU9Tc21PR0hsVlloTkVhNC8vM1ZNK2x3Y09KQlJ5Tjdt?= =?utf-8?B?K291OFpYQlAyKzVJUGcyVGFOOW1JWllFUTh0MXljRVBtSGdob0FJTVdmV0R5?= =?utf-8?B?SXRTcFlYbE5zamNMUnBzSTFvOGltaTdIaGNVMXhMQmlSeDQ0MFh4c2YvSEFk?= =?utf-8?B?RUo3NEcwR3llcll3OFpES0YrY0tUODcya1kxd2l4TU1MN0N4cGlTcWI0T1Zv?= =?utf-8?B?WUMzQlJlQ2tBZFJpQWQxZ0oxcHhOaTRuMWhPV0xPNjlvNXJ1YURvTElsenp6?= =?utf-8?B?Z2ZSbjh0ZTMwNFFYS0JZdFgzZkVBaGlycDdzM3ZXSWNJQlRtUzlVT25hRm1i?= =?utf-8?B?SXNleWlvNUpxb0ZzbGR3ZDZLTGtBTXNyQ3ZFM1hFcHkvREpBV255SFdFOUxK?= =?utf-8?B?ZXFFR3YxaXFpTWV0NHhsaXh5ZVZZN2p1NHphYzlvY1ZuYjZBQnIva1NPSVda?= =?utf-8?B?ejBkamhIQTR6RENuQVgzUkN5U1N1MmtyOS9qN2xXQ052N1FRMzdPS050RTRP?= =?utf-8?B?L3N0NHZoYlZkOTVCQmpJWEJrS3NMdmhwTE05WDd6eHM0Zm9KS2dXR0xIcFBl?= =?utf-8?B?dkh1Rk5HTkRqSzBxY0h4eWFqeDVDLzAwSWwxYWVtN29qaUNTajlnQjE2bzBq?= =?utf-8?B?cmRwc1N5QkZpSnpPcy9wRlQ3eWpYUHd0NnF3cmJCMVZFcnpiNkl4MWlCVko1?= =?utf-8?B?UW1aOGZUaUViVFp5RlZ5ZWJTeEhjcFFuYkRDeHpPNFJhYjlNQm9TLzByTTVt?= =?utf-8?B?VzJzRkIzNk8reGJCRms0YjNnNEFLWUxXQjF4UTY3dGRFUjlrQXdML29LNkJr?= =?utf-8?B?a2FQci9zclg5eVlVUUx1TWQ1S2tKQ2FmbXB0Q2FYK09LamxBb3d2ajkxbTVo?= =?utf-8?B?bGs2byt1ZS9sK3BSSmFFVUJEeC9sLzR3cHoyTEJaNG4xcU9YZEk1S3paVXVG?= =?utf-8?B?WStMdnF2emxXWGZhalhCQllPUlRyVjlmaG15WXhQMyt0Umxuai9hdVhHMnd0?= =?utf-8?B?akprSUFXQnZjR3VHYVpMWXQzeEp6aWJjNmxwalY4eUxzejZ0djRNd2Q4SlZp?= =?utf-8?B?OElyUmIxWXpiV3ZTTGs5SFdLRnhYR25UY1AvcERLZlRXZTFkNXpRQ28zQ3Zk?= =?utf-8?B?T0JxRWtjajZLaGhtRzN6KzR1Y3VnMHJyV3dWcFFEd3M5bFp5RW9vYXZhY2NZ?= =?utf-8?B?SGd2eGtTOCtZOHhxaTJqMTkzSjNtTklQTnZ4Y0k2bTNTNm5rNEdjZmpOUTA5?= =?utf-8?B?Y0ZrKzBaWENMRWJ0amxoUVVTVkdxMDk0RlZFRk1iclFaNVVIbjRQMkhYTURq?= =?utf-8?B?SUdSRzNpOXhXbEV5R3J0amtwOTNaZGxFYkpBandYdmYxd0tQSFFGcWpBR01E?= =?utf-8?B?NGhpSGdwbUtodC9xb0x0RTlpYjBrdTU5MVRCYmh6WWp3aENhanBXK2QxV216?= =?utf-8?B?Y2poOFI0ajQxUGlDa1VMTzYwa1RObFlpN3dNN1lVZFNWMzQ5OWxYYUF0a3Fj?= =?utf-8?B?MWdtSW1yczJ5dlhtL0UwbmhBWmZreVFRMWNOVk9IMFE5Q0twa25Hdmd2S1N1?= =?utf-8?B?d1ErY1JxZFBmQ2NodUQyeWVUTzByM3ZmODgyREZkTlVRbWxGNVY0bVNUT1Ri?= =?utf-8?B?OExyZDN0TkRMTjc2eUZUa0dzMGRrcUVOTGZ0czRMb0RxMlBYUS9EZG1uaGVt?= =?utf-8?B?WG9UL09reDQvRkovOGw1N0VnUUxMVlV1ckowVWVqbW10K0hDU2lET3lLejYz?= =?utf-8?B?VHhZckM1R28rKzRDSWxsVXFremJrdXJ3QU5rN3BObll5MGlJRHRhdERpVnQ3?= =?utf-8?B?MTRIRGhYSTNkL1l0OVErTnk0RTN4VlZpUHk5ZlBxRDV0UVUyWEkvaWhBelhO?= =?utf-8?B?UDRYckpEaE9TalF3Y0lnSTJUdmxNYlRKQmdvcFd0T3JWZUllWG5hRnU5UnJn?= =?utf-8?B?cHZwdXoxLzNFKy9Yb3RzVXN1RDNnWmROZFJ1VXpuRkNBbTlRekpvb05XaEtJ?= =?utf-8?B?czlLWEZTUjR6QzVHNVZVTm8yOHN6TEtucmtHOVJSMXVidlcyV3hxUnJyQ2U1?= =?utf-8?B?ejRFV0cwdzFiWGRpaVhDb0p4d3FJRjE1cTZFVUt4MnBjaHBIcjllb1N4SVZq?= =?utf-8?B?ZWw0cHIxZ1RsRFlHM0JUVnRKS2xQb0xsOCtoMlJqcmd3L1JDVXIxVGRMem13?= =?utf-8?B?cWROZXgzdWN0WVdSOG4vck1kdVp5UHV3YWtvSkhxMDc0aWY3ZzF0Zz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1d77d3b-118a-4bb1-1db6-08da42e46826 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:03:19.5370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dVT15eUC3HrlVNXNc25XNwJQNzb7mnqZs0oif/wRC1jGYYauUYlnHp5xblTRpXafw2jw1upRq8Pu+Gep433PMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4389 On 31.05.2022 10:23, Yuanjun Gong wrote: > Free the table[i].sym field of the invalid sym_entry since > it is malloc'ed data. It would help if you said whether this was just an observation from e.g. static code analysis vs you actually having observed the tool running out of memory. This is a short-lived process after all, so "leaking" memory is not normally much of a problem. > --- a/xen/tools/symbols.c > +++ b/xen/tools/symbols.c > @@ -422,6 +422,8 @@ static void build_initial_tok_table(void) > table[pos] = table[i]; > learn_symbol(table[pos].sym, table[pos].len); > pos++; > + } else { > + free(table[i].sym); Indentation is wrong here. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 09:07:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339335.564178 (Exim 4.92) (envelope-from ) id 1nvxqv-0000gf-M0; Tue, 31 May 2022 09:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339335.564178; Tue, 31 May 2022 09:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxqv-0000gY-IX; Tue, 31 May 2022 09:07:49 +0000 Received: by outflank-mailman (input) for mailman id 339335; Tue, 31 May 2022 09:07:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxqu-0000gS-PU for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:07:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23889afc-e0c1-11ec-837f-e5687231ffcc; Tue, 31 May 2022 11:07:47 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-54bS3FilMem3609zHU7ELA-1; Tue, 31 May 2022 11:07:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9265.eurprd04.prod.outlook.com (2603:10a6:20b:4e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 09:07:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:07:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23889afc-e0c1-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653988067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=np4roSaQGCbI5NIEruu7cTBnjPhBJmeFXZtpH5BoncE=; b=Z+BbezJIx19K8Oyul8CBiVO/3Mlbi1FJjNSZDvC2nL0u03rcUWaOh12btB0OnSkG95pGwu 3Lb2jSIhkmL8owBoYo5XlhYuzF5tAL+d8pl8+zKn/UGN4amCfu3bU8ZSYqAPahoEHaOVi2 c8phyre2pYGDoW9QpTmcX2uT8jyKBBc= X-MC-Unique: 54bS3FilMem3609zHU7ELA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjlpBzuMqLNuaplUTOmC6hF+uywikCFj+lOtdynQOM272sF4rDffzAh+nAfg9W64bdD1YRHDqAia82FpVneZ6zY5Il7jI5AlNQ8WJWNEAJ+AtYl4c3bRhgqopPoFUHutSsmKYBz7VjylajSpeAKIHvSR10Lo81TKpAkoQuuZVvqoU1vTO7mT5agdNilGSDLaR5jee3biq73N0R4qy+xxtJazGEAvgtYlzuvQf4KhO+4Na9acHs0g8CbeCazI+KeNrC3JL9HmfyH4sNFRt/hI+OT9lteCOu9B4O2gS21pB+qHOFQYGhOVZda8FXRkc+YLwlO48vlpS1L95KIVaRSEPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=np4roSaQGCbI5NIEruu7cTBnjPhBJmeFXZtpH5BoncE=; b=S0vM0lh4EgEVhhGI76ZFIUQ8JCxKzGooJo+nzqvV2UJe/0t8tiEB2rYL2NN4KFjN93MdWrcIUSKy0VoXyHRNHX5r9HcaygdXynRYTYm5T3wOeIAx9DzBtYzrVKREv9qMsNrNcC+3i1D4PJQC9u8vVtP1As5sgi22DqK8KIm96Q8keyyX32hskV9HTBtZXDDTtJR5DLdr7fmWN4FPAa1NR7bhxpEsD6Ct5BqxR//WOtJ8bGYGgWPMkvB4V+ObTe0hN0xGq3QjOzJu9IZmFfvYtiF3NTUCJJrXHvf9oHPl5rTPzf6lnGk8aY+nLcSPvrAvzF6fWnO+8EInoTK7gAXL3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <19c9c316-4d6c-b449-8d3f-c04f1a1f5f97@suse.com> Date: Tue, 31 May 2022 11:07:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 4/6] xen/riscv: Add sbi.c, sbi.h Content-Language: en-US To: Xie Xun Cc: Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <55710c63-c531-3330-786d-ec6349690311@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0766.eurprd06.prod.outlook.com (2603:10a6:20b:484::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3580e32a-a797-4298-0080-08da42e50666 X-MS-TrafficTypeDiagnostic: AS4PR04MB9265:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yXu2zJ5K9ghbBW5Q7MdaDPKNswlaSdJQGybfpVWfR+iEAmdFb/UghF85yuyCwOz68xaRjyo9WGRLIVep3MbJyTDJ3FTrMSoZOlhowk3yxZmc0HNPJlO9MvXHbdfSd+TPqaxiJWu6ABWu1SJBdJsK3tLOeWWiFf3JXcfAqbnJqojeXvkLVAjIZE6xd5dqZ2R7SmoP6XYd4ZANSPHSZYhsaqeZ2Y4lkNupPs89q0oPo2G065Tp3oBF9B2rIiPTEk5aqtJ84FwoWEANhAspUTIcyMV00MfD1h4DU4+wgIaBgVwPgL98ugvANX+8OpAreE3qvM37s0Wn2it6nrPswtR5JvD0/8rES8jsv8PWJCt+4klvNywxFUR82rjHTUKYKapgBRgj4eouHOt7HxNcDDav+YNZl4p+/m13mScK7suzq1EHFzN4qMCzZhY+/IVuYdCIdFHJuiIV/TFt4f9uBnwZkzaEAtlh/9YxebxtIxB/LILpSk+wRBxwu9GUorPQ94/4hIe7GxdFdD2gmAHkvQEecrFcejFMCBtKBPjOlsRyYcVMXj7RxFNzv3C5DeNtr4AYE1/GKtkPbvPK4+4KZPUTaxBkR/Zt1lKYlNbH8MfKeUHHwJoxxC1MCfyFIJxrG2riM7JesDnuIqla0AfFLWmpz4fgq5mSj6LXDm7KQGBdHgtLeXnW+xamrIOB3Q0FzcpHo6cJP0ith8CHXnQ4P4hQJGsSTVrBdmBBMfD5ED6xdaOugJnGdgBltK63I69thKFYc5stxEwd/incXfbk6c8PN50ClsUNL1cGj6uRc6eG8/iO9PMoPLtQJkBDoClRipEZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(31696002)(4326008)(66556008)(8676002)(86362001)(54906003)(66946007)(6916009)(508600001)(966005)(6486002)(186003)(316002)(6506007)(6512007)(26005)(38100700002)(53546011)(2616005)(31686004)(2906002)(8936002)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDJoT0xnc0Y1ZHRhaGFDc0l5U1JLUTlZTGQzdmU0Rmx1Mk1kZVdGZUJ2Q1Nt?= =?utf-8?B?SkY3K3RmejJ1VzlnRXFJSUdtRkhxTHRVdm5OcXJKaG40WHF3bkRqSkxjSGZI?= =?utf-8?B?WEd3bFl5byttQ2FzSXpSRTZJUU9LL3Y5OEVNMHJXL1dzc1VwTmN6YXl2Wk02?= =?utf-8?B?ek1iS3U0VXp5SEZHOVNIQnpTMFprcEUvdWRLOXRGLzZIemQvK3oxL3I2SXpp?= =?utf-8?B?WjZxQzBWMGNTV1duL0QrS1R0Z3N5Wk1JS2N3SzdITkVnbVpEbmxuVk12M2pQ?= =?utf-8?B?QVA3VlUwc3duREdDTlZrK2JYQTA0ZDlQZEU4R3I0OEpWS2RNS044RENva2E4?= =?utf-8?B?T0d4bVZMdmRKaWllaWM2elp4UjFSUk45MU1udDVZM2l1ZXRBUGtDMWFydncv?= =?utf-8?B?eE1OVE1yZ2ZjQU9INjMvR0pqUWJCR0tXeVRDNUlKNEVRZmdSU3Y5S01SMEFR?= =?utf-8?B?eTQrMXlQVVB6dGU5anAwNE55bFdPVjNNNzZHV1Z4SlJVcERFSG1nZzg2N3RY?= =?utf-8?B?TmJ1V1dQZFBoWGVJUzYrMUt3KzRuenhPWUFYbWZiSnY5K0I5T0lkeWt3UnYx?= =?utf-8?B?YlNFSkJqY09jUXduY2x0M1BrbkxtcHl0ZDZOYkNrbXdueUNtelRrMnN4YXY2?= =?utf-8?B?bURscnpuUlhTZlV6SDN0R3FqZjJHWVRycHZ4MEZzdm5nL2JBODB6UXBUck1P?= =?utf-8?B?TEZlMkNLY3dSMzhqbTdDUTBsamQ4SDV4N0JtdzIxUk5XWXl1RU1EcUV4YU9m?= =?utf-8?B?eTNTZXR6YitJaHBUZHNPejh2NDVHRmhsZEZxeUprMkJybHZ6bDdMZnR3KzIr?= =?utf-8?B?OFVndko4ZCtJdksxNFYvUzcrVFdTcXRuektGVFk1Q3dnTmlMdUpFWG9pWnRh?= =?utf-8?B?eUh1bFlSNmZPZWl5WXhvc0hyZ3FVYWVlRjVYOFBqaFZwTEU0MUgwdHREcGJG?= =?utf-8?B?Y1dTV2cvK0ZQc2wvcldQakhhbFpDV2xaS2pLT2x2YUpnT1Z2Nm43OGJSNmVE?= =?utf-8?B?THRPTTNQOEkzTUZzSTRPakVNbWRwbDhtUWpEK05zcWZUbEIxczVmRENRM3Bp?= =?utf-8?B?TWkwR2xDV0Rsanc0QlFFejF0L3h5S2RUdG04Rkp0YjB4MXErc3NycnFYbHp0?= =?utf-8?B?dWFEbVN3TnBQV25GaHZhaG01TVd0TW9odjVzbkFLRzZCRWFJcTcwK2g0cWpp?= =?utf-8?B?eWp0NUkzSnExeHpkV2NxY1pQWTBOZkFPZGNhRjlCa3BxMUJFdVRpSWVBM1VW?= =?utf-8?B?WVR0a28rRTVCd1Q2b2N2cWRPSTVrUktMSHFNTVBCQnM1d253b1dwSHJnUklV?= =?utf-8?B?Y0JNUU5tNHZ1cE4yMktDdEk3dTk5RFF1R2NqT2FqRldubTYrNGdWeTRCcitn?= =?utf-8?B?cEZRcjFmUFA5NEhCRG9mM0hnaEV0QmRkL3IyaWNsQlRYRCsxU1pHMlhyUzVn?= =?utf-8?B?K2J6ZEoyTHBiRXBIdTlEZDBQTEcyOE95K2lWeDVoTXE5NzR6OFhrVmdPTTQw?= =?utf-8?B?azNNMkZ4N0crdlg3d3ViT0NhWEFCalppVG1uM1V2NEJNYmc0RWdxcjhLYXBC?= =?utf-8?B?M0pubU5ENjZXVFByNW01OTg1d3R1cTQrczNaQi9hbHRWL2xpR3U0bWNRK1pu?= =?utf-8?B?blp5dU9veVdiM2pSNlRlMmlYeTF2V0JybERybzh4MDViYldMS2ZFMlpMWnZU?= =?utf-8?B?MHNnbG91RnpaYkFZQnVjMHpvbUp2V0RBZkNBRzlVZUU3b25jcTBHYXl2ZE4x?= =?utf-8?B?dlo1dUExZlJpMXNYV0NKeURVU2M1eU96N1hSM0hCZVF3UnU4RTlJUk4xc2lp?= =?utf-8?B?LzcveXlqa2xMM0N5YnBJSEo0NGM0YXM3UUczMW9nTUFQODVEUDcySkdpVDh6?= =?utf-8?B?Z00yb3NTWTVZMkphTlNCTVhuYXRZZ1hoaE9NTVFadkNCR3FneVZFeUxpdnMy?= =?utf-8?B?WEZMejk0NnMrakJ3ZzNoZm1UTmtHbmg2MnZId0hLY1NXWWVsNnVqa296Y0Mz?= =?utf-8?B?c2krWEdlWEFndjRhYjNFa25iazJaL2w4WU96ZWQrbUtyZVljZ2Y3bTFDZnpx?= =?utf-8?B?U0xCbWF2dDFTWlROWmlaeUw3MUtSSG10VWJzZzNVbk5zQVpwUU11ZklVTUJz?= =?utf-8?B?dnVkeE5qK0lpRms1MndFaDJseFBjMk4rN0hUK054YUIwblZSNis3SEF0a3lE?= =?utf-8?B?K1JQTll4Ylk2d3BranVNMVR6U3V1eGtuOVpxOWlwb2tyRm9mVWIwOTMrS3R0?= =?utf-8?B?MzRWZGNKczJ4QTI3bUN3OWpld3VGSmlvd015aGtNRHErbm5CblcyQ3dlWFVR?= =?utf-8?B?L202S2NHbURobGhSWDVjb1VMcit1YmxLb3hEZ3JGZmYwazU4YW9NZz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3580e32a-a797-4298-0080-08da42e50666 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:07:45.0825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vvyO2LtK7mYc/KcHs5PesrWsJvbeANpMgtF3T9c0P5j7K5sncL/Stxb/A9a/+48nn1SpvbcWHfnZ5fLjlVMUfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9265 On 31.05.2022 10:59, Xie Xun wrote: > On Tue, 31 May 2022 at 15:54, Jan Beulich wrote: >> On 31.05.2022 08:57, Xie Xun wrote: >>> Signed-off-by: Xie Xun >> >> Is this correct / complete, considering .... > > Thank you for pointing out this problem. > > I have read the submitting guide > https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by > > and it says that signed-off-by indicates I certify the patch under the > "Developer's > Certificate of Origins". > And in the "Developer's Certificate of Origins": > (b) The contribution is based upon previous work that, to the best > of my knowledge, is covered under an appropriate open source > license and I have the right under that license to submit that > work with modifications, whether created in whole or in part > by me, under the same open source license (unless I am > permitted to submit under a different license), as indicated > in the file; or > > Because Xvisor is also distributed under GPL, i think it will be > correct if it is > signed-off-by Bobby. The problem is that I did not modify this part of the code, > so I want to know how to submit this patch in a correct way? If you didn't alter this patch at all (or just minimally), then I guess first of all you want to set From: to Bob. Whether he has given his S-o-b of the code I don't know; hence my earlier question. If so, having his first and then yours is quite usual an arrangement. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 09:08:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:08:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339341.564189 (Exim 4.92) (envelope-from ) id 1nvxrR-0001Dz-31; Tue, 31 May 2022 09:08:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339341.564189; Tue, 31 May 2022 09:08:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrQ-0001Dr-VR; Tue, 31 May 2022 09:08:20 +0000 Received: by outflank-mailman (input) for mailman id 339341; Tue, 31 May 2022 09:08:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrP-0000gS-3Z for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:08:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060c.outbound.protection.outlook.com [2a01:111:f400:fe0e::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35824951-e0c1-11ec-837f-e5687231ffcc; Tue, 31 May 2022 11:08:17 +0200 (CEST) Received: from AM6P191CA0019.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::32) by VE1PR08MB5696.eurprd08.prod.outlook.com (2603:10a6:800:1ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 09:08:10 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::e7) by AM6P191CA0019.outlook.office365.com (2603:10a6:209:8b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:08:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:08:09 +0000 Received: ("Tessian outbound 4ab5a053767b:v120"); Tue, 31 May 2022 09:08:09 +0000 Received: from 684ad91d00a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AE263822-C70E-4176-B3B7-1BCE86C73302.1; Tue, 31 May 2022 09:08:02 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 684ad91d00a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 09:08:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB3841.eurprd08.prod.outlook.com (2603:10a6:208:106::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 09:07:53 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:07:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35824951-e0c1-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BFzkmnXvIziPJg/KN78R/aSVgnhodnMLPhkkpEaWGUeNhg0OxRy8Ef3ikqIqxIRR/Bre8QfRDu6LPXVxPVDfihJ4Xu7zwajIMjBB5/Ix0l6Z5Qc6zwV3SWb4gEp6pZe8k8dl3oxe5YPmHQW1oJVRqrTzWjeyiUyjWh+D6CuAgX7rGXxircpqckx0wZsRfFuopabx/KX5sdb3I028tMdjEhUC5q+aYb9nqJdqqRiKUMcto7MkXD6v5Sqav7qlsKSYJKvmvmbN98P32Y7fndEnSHJiXQGU1Zmpv9KiCKbSmqiwG8rHNxDDo1NjyvxSH55fgZOPhxYBxjiIlhkLa0IL6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Th7N1XGg19r4bdlU/NzYKD779beWdYoKYuv9n9pzro=; b=elOg8y+nWl2Hv44jcqXisq+EXwlGP6gE+eIeZJ8a562/eRYMsuCNzX0iyAmW0AxQWTYLX5bloyTwhfhGaGpwC/8uuyNfemD6Pa8KsXByMLNopkzThdWRLbu3Ezug59+c8R4zSM7MDlXHrale1+z7UK2TU9HF6aW/QKILRZ4C3aRqb8dP7wHUf4FkRPX+GeNFKS6Qgs9rEoll0fdps78/jOWaPbUCpPJb+g4hSjBCavS383x+mmA4/O4PfyaAlEjQTJgzlq4CiJX5pQiYOQrpkAHAx6IZxh2HSdNGfUB7zu+W2SFpn5rwn1nfXM/Wl4H+N80ZGX7wYyqH/DvF8HqcIQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Th7N1XGg19r4bdlU/NzYKD779beWdYoKYuv9n9pzro=; b=O0SgVtVhOxHZTfSnZ40kqXknb/W9tGKG0zbtwe6ifn81hvdvuzzTG40defWBn5lP9NMLwvFbrilkvMjgC9lAHxSp5VV8+pvhkZlPf9wnsT/C8R593qZXmngSHZNVBdcwUlZTs+1Yt76ci6nsfYsDlwsManTkwOPrWuw2Qs5fSKI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6655d99dfacbec38 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=axTk7wJNDuBFt33rViw+8wbva1Sm3O+7Xf2ZcUqYl2C8DAiUhQAbtvwJHO8Z6n8exX4hbH35C1RUzlu0H4p/nVOHVahSxbm+e5MbHg14ffaW0ZmK2AeBs9BGMwwMbDqHnb220TTNlS/nvaoVgmoeV6L6m+VIEGVuDEZ3TesqRL5L7ityDGmm2smrP9YxywuQGbQbipWvqszLcE8f0xwAvMXLC91booNTTlYxpdzuxb0TXQBOoY6kjex5gdOGNHqxUEga4liQ/iV19TXbUJND4/am6VkJS9Q4u+yQD7dQ3l/ed71ZcMtEBFCzSrexC9eI5l/gr66qIfAm8bvP+LRbig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Th7N1XGg19r4bdlU/NzYKD779beWdYoKYuv9n9pzro=; b=bLbqCksbFHm9l41sSrBBBKcapDrVIQcc1AdzxNIyDug4SPhnHNualx9MNR5UE2LHqDxnoTzNZZfqiKSgMun/dDY5zuWANwQoS3HHamXcvbxNT1DMMeNS+hnEQWbcULs/xAK/SD7vS8Zn/7KCyfdZcBawOkONe9brnqby3Be69ginYhXjHFzHuu3l3Ks338DJukU0Hx8zJ6Vkm90wG0sBcI3chFrqOgypQBkbv21+IAR3ZJkbCMBCGtqEP3xPQs95P+b1PhLh48EDZBysbQZRkLGw4EBVV/CtHAY36yUsDxG4n+LqDhQNIyOZ7r6WoHADou6VgMAYB2OhIhaH1fls9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Th7N1XGg19r4bdlU/NzYKD779beWdYoKYuv9n9pzro=; b=O0SgVtVhOxHZTfSnZ40kqXknb/W9tGKG0zbtwe6ifn81hvdvuzzTG40defWBn5lP9NMLwvFbrilkvMjgC9lAHxSp5VV8+pvhkZlPf9wnsT/C8R593qZXmngSHZNVBdcwUlZTs+1Yt76ci6nsfYsDlwsManTkwOPrWuw2Qs5fSKI= From: Bertrand Marquis To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Thread-Topic: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Thread-Index: AQHYdHaP7qNDYyBbfkiCxkS8602Jcq04suAA Date: Tue, 31 May 2022 09:07:52 +0000 Message-ID: <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> In-Reply-To: <20220531024127.23669-2-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b340d022-7393-4464-b715-08da42e51560 x-ms-traffictypediagnostic: AM0PR08MB3841:EE_|VE1EUR03FT039:EE_|VE1PR08MB5696:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 190Kj213UAum/kLC04kYsifDHU8nAXljU5ovjtdbeDsvTWILtWiRVMAEhB+M9/eYfndtX9Koa21FCY0IKwCynIQsQrExyFSDpj/2sVRyZmSKQRFz6gi9E/KzgPgLr2q+cGMruszCsleaTBk3Xo5B8SBY2NEkLpDSK/9dj3XfYzK/JtX/iqmaghs1GSdPl70Ar/BE58jIkw2Ny1z9L89lmejj+JacU6+m5zAVwsstsZ+HTootrFCpLg5BdKhWAr9xgkeVMULFr95SspH6QL0FzKt6srlp9lvp6fxbT2chuBSExuvdbvaIfXZBmoHUSIlB8PVH74CiR6pSgF2gjvEcDTjEsIp/4XYHtSU3Z/1nTlDK40SQ8ItY8qtFOyJJ+a3YiOxmm54dojYszmWyjQsGhMCSYyDT05VYRRk6hZCC/ufrS5mGUMXC6XR/FgnZUUEhcDkp+VTm1rGdCfG0Jd7YlxsM2b1dU4ZSKQf8+j5O3Nqwf/fxJmOFt/MJ9eLyh51H45T4VtdBZqG6ieCyPDiOmZaau6GFPGAMDS8TFSh79myZYsDjOBYNM3CFG1Mo79roWE7iVioFWgVM/dqam3Ma4a3y3rQHcDvetlkj6mmybO5/PwqG/W86xT1BxBpbtYvqD/Kfa3Z5r5vMGzvmLjONIh2rPpDqsgKLi8clMoC82lOEyBXpllB/r3CZ66e0Hrvqy0D1Jr2VzcBlTs0jx0fEYsWpU7KV7vLLUfP8HTUoE9lxTued2bmTGbG36H2FwbfS X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(53546011)(86362001)(6506007)(26005)(2616005)(38070700005)(2906002)(36756003)(54906003)(4326008)(91956017)(8676002)(38100700002)(316002)(6916009)(66556008)(64756008)(66476007)(66446008)(76116006)(66946007)(6486002)(7416002)(71200400001)(83380400001)(186003)(6512007)(508600001)(33656002)(5660300002)(122000001)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <2B039E18807B7F489025C8DED631AA07@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3841 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f2cc364-4f3e-4ddd-4d08-08da42e50ad5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xCFv+eYAvfs79vOMk26RkyUl5qRfEY4XvXQAid/SpbEo2QtxefHX0flvltWObL4gA4e1Wl+lM6F8n9bR4zE7wZ+if0xZiuQYAkKQr54AOZeHBWEkHRQhXZ+wx1XDJ3u8yIeC7yaIESN+/PPOeLDWK6HBylgohPb+jXI57FYUSpGg7ZAxov+cWwXsePLa7A6yUsnQtbmwTZz20TOhjhoPYTXVzXHGw8rq6BCcxVDPfGPULoIJtMTRk69dPRsN9Pl+nMMgzsWuy6evorxsCM+m9KgqArqlvyyB7Pv1mCpPXjizzKJJVcC6V2db8rRMLydkGYubZB3p91UZzm3Y+zEmUavtbHj3CJL+f17iv3p2qT2q+5lpDtZbVCiO+6yfnU5eSQkV8h1yoCdYq6Du400O+Gp/veUsGBrmmDrzIb050NCUo78UQBWVzjWuslbYjCdrUeO0dFWJPcsAmliDybexa1bMcouH8Io7s1L5/7OPUyLsKWxpSrQDIG/M4Zdwkuzj1cqlXfqorsEnMitqpkYZQXvq6zeav8OJkdc1/gEdA+D5i1PhjjTA9H10GyDj/FInoFNXKan+cT31mWzyRJynecI2F2BiKDmI6ROm1hXrBLCldGfOBr6OhzpC0QIw5J/3zfgMbi1PrQsWDmkDv5op5zGBDdQ+Jxx8qw4E6mvMOZkmuwRQPzgU5XRL5kHdhAeh X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(54906003)(53546011)(81166007)(2906002)(316002)(26005)(6506007)(6512007)(36756003)(8936002)(356005)(47076005)(83380400001)(336012)(6862004)(4326008)(2616005)(70206006)(86362001)(5660300002)(82310400005)(70586007)(8676002)(40460700003)(508600001)(6486002)(33656002)(107886003)(186003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:08:09.8856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b340d022-7393-4464-b715-08da42e51560 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5696 Hi Daniel, > On 31 May 2022, at 03:41, Daniel P. Smith = wrote: >=20 > For x86 the number of allowable multiboot modules varies between the diff= erent > entry points, non-efi boot, pvh boot, and efi boot. In the case of both A= rm and > x86 this value is fixed to values based on generalized assumptions. With > hyperlaunch for x86 and dom0less on Arm, use of static sizes results in l= arge > allocations compiled into the hypervisor that will go unused by many use = cases. >=20 > This commit introduces a Kconfig variable that is set with sane defaults = based > on configuration selection. This variable is in turned used as the array = size > for the cases where a static allocated array of boot modules is declared. >=20 > Signed-off-by: Daniel P. Smith > --- > xen/arch/Kconfig | 12 ++++++++++++ > xen/arch/arm/include/asm/setup.h | 5 +++-- > xen/arch/x86/efi/efi-boot.h | 2 +- > xen/arch/x86/guest/xen/pvh-boot.c | 2 +- > xen/arch/x86/setup.c | 4 ++-- > 5 files changed, 19 insertions(+), 6 deletions(-) >=20 > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index f16eb0df43..57b14e22c9 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,15 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_BOOTMODS > + int "Maximum number of boot modules that a loader can pass" > + range 1 64 > + default "8" if X86 > + default "32" if ARM > + help > + Controls the build-time size of various arrays allocated for > + parsing the boot modules passed by a loader when starting Xen. > + > + This is of particular interest when using Xen's hypervisor domain > + capabilities such as dom0less. > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/= setup.h > index 2bb01ecfa8..312a3e4209 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -10,7 +10,8 @@ >=20 > #define NR_MEM_BANKS 256 >=20 > -#define MAX_MODULES 32 /* Current maximum useful modules */ > +/* Current maximum useful modules */ > +#define MAX_MODULES CONFIG_NR_BOOTMODS >=20 > typedef enum { > BOOTMOD_XEN, > @@ -38,7 +39,7 @@ struct meminfo { > * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. > * The purpose of the domU flag is to avoid getting confused in > * kernel_probe, where we try to guess which is the dom0 kernel and > - * initrd to be compatible with all versions of the multiboot spec.=20 > + * initrd to be compatible with all versions of the multiboot spec. This seems to be a spurious change. With that fixed, for the arm part: Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 31 09:08:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339347.564200 (Exim 4.92) (envelope-from ) id 1nvxrr-0001mr-C2; Tue, 31 May 2022 09:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339347.564200; Tue, 31 May 2022 09:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrr-0001mk-8y; Tue, 31 May 2022 09:08:47 +0000 Received: by outflank-mailman (input) for mailman id 339347; Tue, 31 May 2022 09:08:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrq-0001mO-9Z; Tue, 31 May 2022 09:08:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrq-0007zv-6K; Tue, 31 May 2022 09:08:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxrp-00014l-KI; Tue, 31 May 2022 09:08:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvxrp-0000SN-Jj; Tue, 31 May 2022 09:08:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ptWWBWMpyQ2NBvkKAkCXbrTgMCFaAh+SNUW8a1dy5Tk=; b=SzOHzqV2sbp1/olmEzmvJ1Wkdi jyY7ZUcTUE+ZPWMgNp88gYM8J7Q/NnFatp80yLy5eJmn5Dgtlg/Big2X7aZH+5znMFzYHtAIA+cEP meRG/owEZZofT9bMuReILfT/2s+LtD0L0qSc642MoftkXDWc9oft/C59GZtt9zWOpeMk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 170780: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a X-Osstest-Versions-That: xen=49dd52fb1311dadab29f6634d0bc1f4c022c357a From: osstest service owner Date: Tue, 31 May 2022 09:08:45 +0000 flight 170780 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170780/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 170772 pass in 170780 test-amd64-amd64-qemuu-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 170772 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 170766 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170772 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170772 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170772 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 170772 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 170772 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170772 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170772 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170772 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170772 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170772 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170772 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170772 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a baseline version: xen 49dd52fb1311dadab29f6634d0bc1f4c022c357a Last test of basis 170780 2022-05-31 01:53:10 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue May 31 09:10:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:10:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339358.564210 (Exim 4.92) (envelope-from ) id 1nvxtY-0003La-VS; Tue, 31 May 2022 09:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339358.564210; Tue, 31 May 2022 09:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxtY-0003LR-SR; Tue, 31 May 2022 09:10:32 +0000 Received: by outflank-mailman (input) for mailman id 339358; Tue, 31 May 2022 09:10:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxtX-0003LI-5y for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:10:31 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on060f.outbound.protection.outlook.com [2a01:111:f400:fe08::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84677e9b-e0c1-11ec-837f-e5687231ffcc; Tue, 31 May 2022 11:10:30 +0200 (CEST) Received: from AS9PR06CA0489.eurprd06.prod.outlook.com (2603:10a6:20b:49b::13) by DB8PR08MB5114.eurprd08.prod.outlook.com (2603:10a6:10:e7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 09:10:26 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::ad) by AS9PR06CA0489.outlook.office365.com (2603:10a6:20b:49b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:10:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 09:10:25 +0000 Received: ("Tessian outbound 1766a3bff204:v120"); Tue, 31 May 2022 09:10:25 +0000 Received: from e68040609057.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3B396DB2-DD7B-4AA2-A02F-CF0641244690.1; Tue, 31 May 2022 09:10:18 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e68040609057.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 09:10:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB6356.eurprd08.prod.outlook.com (2603:10a6:20b:36b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 09:10:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:10:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84677e9b-e0c1-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DfYH4WdIMrH4vDhwTJWs/NqWoDArOjSqws4bTZaJDj3ixDmqyNY2Ey//3yPdB2ZDOh7Ezm1C3dll/kIUzqz07EnCW50G018yrn/FvVdJydHyjgzSyS57mKvmkC+uFHUmEuPezsigCibzviKoZXMRTmwq43VgugxbkUgbETrCc2nqdK2P9NkFRY5mRVOXbt8D0no3eusUdXorUZCgv2o51JNVb/dFRu0e7q7L0/7s+f8FTeR82UsZu3uvJKM5DSijGLS/P3L93npSGH99ux5Sag0VfpsLjCYXkyeKv7wgV/C0krCEMdVlrC0/iFa+aXFtslihuGdMNm69I3H4dRacmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZ+euNN5l2t86xNwjY4BHVGDgJbhWVlfAUToXePuX20=; b=AYD9hcNGdKCTqbFkEzBWaDyw88MUG2+hLRKd81Y/O6M+WDoVzG1LbfXHPQkx1SUpZdKPWjnLXIGNK0X2dkbeup39dmNSpmno3vkqyWCt2jUdrV+iQHcyFGNKEEnqFKv9azr9rK4Xgm3WJIxdcEIAIVa0IKzOEmePb5bicv3D0PdUQb0H1Qj4/kG9zR5NATFNe77XuK4ejFEzruqcqxA0q4aX+QffHS5RCyAMJcqD3XclRkXYpxSs2oPJ0R6kKz1fewtRPFhM3U43C8GlwyUwo8OgZFRBKkxx2cwRJ//AVtoy0fpEr2ecgxDPi+XUOXDbbO65rRB5otsXj1D1GISZbw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZ+euNN5l2t86xNwjY4BHVGDgJbhWVlfAUToXePuX20=; b=6hNzaBd0E6x9jLHkBw4G/5mGkOzkH2iZ6jsaRNzjfMf99cvIggLXT3wh0ebqCnQUnojGsenOR5bYDth2dAr7EFoYpwhABeGCTogMQ4eTWAJrn4/dm6ncDwoikf8TiyVAnL1UeHTPi8lenNcDNt2af9z1nxNLossCg/Zx8ayjP9o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8f1b65eb93e0fcd6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kc56nxQAZGqwi7/2iiOeySzkdasRUVXZ0QGEauUKCLnoud2N/OGDHr0qWtcX+RShwqv64SvHtfOSvuZJt/upNXiUzOuYLxxBlLwWHGjphzdpgA5Bhk+gKf1Pm4T5x081nxTCpmBuHHF7FtRi7SEHgF3TTpliz41D+UPa0DMJq9zHxSko3jl1FYjzBhoLbFn3mo9gOPJvXVWL7JYDsX4v65d9T1k0HTbj2Z+l0rm8Z0mg2s/NDyu2Dxod8ZrgBEpAFSLrsjFQE3z13LbKioQpmhQIjjdEwbT0k+6+hkdd/3YH0Yub5wAmqkKJxktOZvcBO0gjONMi/Zbx4xi1JIRj3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZ+euNN5l2t86xNwjY4BHVGDgJbhWVlfAUToXePuX20=; b=FLH+dGLZLJPN7dNE/dLTgfeDdDRhIULY3tVh/r1LAhOmls9QWTG7e5dnUPZyC79LgL07LgUHkccNLQi3+StZOD8uoKw2HaKQ0WOXSviYVJH9BhqdrxXOomZHBOJa73+KN2bpPzXRR5/G58VpY8OjTgj6/UQO2pP+Xb51qW8M4aACAx85TyqT5L0cYn+0bjy5gZrGkKlBYUnWfGaidgsdkN7QwQE0AoQmiLVJwTRblrhBMUUf+ja0DQsKeDVic3DF9uhR7fw+dMU1XtvJmr81UFJUbM9yr2zj6XWfWOALEuBZxB0vNA6lSWtb8x8At9AkovFmH+n++lC8zEBq1AlEtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZ+euNN5l2t86xNwjY4BHVGDgJbhWVlfAUToXePuX20=; b=6hNzaBd0E6x9jLHkBw4G/5mGkOzkH2iZ6jsaRNzjfMf99cvIggLXT3wh0ebqCnQUnojGsenOR5bYDth2dAr7EFoYpwhABeGCTogMQ4eTWAJrn4/dm6ncDwoikf8TiyVAnL1UeHTPi8lenNcDNt2af9z1nxNLossCg/Zx8ayjP9o= From: Bertrand Marquis To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "jandryuk@gmail.com" , Stefano Stabellini , Julien Grall , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Daniel De Graaf Subject: Re: [v2 3/3] xsm: properly handle error from XSM init Thread-Topic: [v2 3/3] xsm: properly handle error from XSM init Thread-Index: AQHYdHZ7mUVqfmYJ+0G1eO3EqIdC6q04s42A Date: Tue, 31 May 2022 09:10:16 +0000 Message-ID: References: <20220531023945.22196-1-dpsmith@apertussolutions.com> <20220531023945.22196-6-dpsmith@apertussolutions.com> In-Reply-To: <20220531023945.22196-6-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 22666112-538a-419f-0b1c-08da42e56655 x-ms-traffictypediagnostic: AM8PR08MB6356:EE_|VE1EUR03FT064:EE_|DB8PR08MB5114:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OoE2/nDnTCyWfvzZvKEwH0forFgVIx46j0ueW4H3tcTsK860shhIQWjLqmQq6N7MNQIWv4KxJ6G4e5swlGFRmnpwKZMnO5UqQGxBLDdphJ5s4jCVqnTCyhenwDT9T/mpHIG9u4T8iCULMCd96G/ksp3hCHT9Qq4N5tsSZDywW5aziH1dZ5iijyPxD/0AsDX5AZ3mlcJ+tOPULBWm3Myho++ZRi2IiBBAOAnQWjsp6W9+NtgBU5+fkfKqp3OxedimoG5FsX71x9am7pXIbZ7b/QALK16OBy5sltiCCGcO9ta9XB2gkMF4pi94/Ez3kQBetnid398NLu7H+NmDlEBwdYufduv9J+uYJmYFJ+hN+xKgUrCJxRnLH7voH90Hqs8YAnT1H/h7xuLuv1S2kurINuKQnUBCYB0ax37kzKmZ6HTGcusO3zvFUQPrhYn0hoDc7KsR7FVn1hO/B5LJKad/095uvbeD74v/YPSteNs4edH60W6AW689xpXn+ZcmnYk9oeWqcBOTXkTj63xnWfoySsmSGpTws7OsVPYmz/+lTXgS4886VTcv3TTQuvF31EYAcorfYAq8Gc5g/zB0r+Dd1Bq+IfofqfaE4WY1jI+snImIA0LbfBg6d2ukYQY7//P06V2YcHk9mOfoI2TVcc+WVAWsMiErb71E3aN5R18xuVOn4MQl+tteY7NPeD21gJBSF7JIW+dmm2n5wbqCMHu13fgXlxUZ7q+bNbV8aJAqaZBT5uf3Uu1dRSAG/s7z90I4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6916009)(4744005)(71200400001)(33656002)(5660300002)(7416002)(83380400001)(54906003)(38100700002)(122000001)(316002)(66946007)(53546011)(6506007)(4326008)(2906002)(64756008)(66446008)(66556008)(76116006)(6486002)(66476007)(91956017)(38070700005)(2616005)(6512007)(86362001)(8936002)(26005)(36756003)(508600001)(8676002)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <1B6A2506CB06B54F9AA6D64430223AB9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6356 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 266ce073-da97-4024-49a7-08da42e560b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ws5CQyp7BfsXdJP15AaQ/r9Htp8UaiiYfLj0Ekzd0bggRw2E0ppDghsW8aTUWpiY0Ltt7S3QEtKp/hMpNtAer+79JCoiJphY9RgDq1Em7z7Fj7qEIY3xoppsCj0Z34SkBdlS4gUKpKFhNvJOab4mfhqXmiggaFNQEy0AQMA05UDWkwZ0Bz0Bh8UzpoFBkWiaNW/L2GKAT+4oD3RH+oUAbyJTLtOLSF1MQNsCc2wfBuophSg3wggLjhxEqgMJ1p+QHP2V8AXsUHK4/FN2jQOWDJ94PDOmnF1t/++FQVyMc42ENqvLC5v8mLjIDNRPssmvygVAL7UAfW7WDnbDvOioagp9pVXuwGNKOzqhWDB1efbPpxQZC79STClXX3UelqQy0h+LouYNiX/dTDof3ABcAkNc0Etwaf7hhSRj0mrwM5rJY9GxEck/5caeO+zO+UAkww33RiSJbcncCYEtz5LBkcND/iBzLNnJQxmZ0JbqMK2JGf6ZOLmfToAi/z8JmRM5B0tKjzC5uSj4KSCt8nDZtMUK9jRRR9KAR5P++a/8eODrOBR1+4VMj2O77QA6aS/RbXHkO3Q8RZqRJUzTHjI6ZyDyE1/wBeDOASgnosTyej0+fxCsQrmlMlkM0MNtpc8wT8pwbSecNmK9K7+1TNEUe23+A8O3BjFtFW39bT8AQ5DHdBzOEa39XytDCTDb8eBe X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(8676002)(4744005)(356005)(53546011)(5660300002)(40460700003)(83380400001)(6506007)(6862004)(4326008)(36756003)(82310400005)(2616005)(8936002)(70206006)(70586007)(508600001)(186003)(316002)(2906002)(36860700001)(81166007)(86362001)(54906003)(47076005)(26005)(6486002)(6512007)(33656002)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:10:25.7202 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22666112-538a-419f-0b1c-08da42e56655 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5114 Hi Daniel, > On 31 May 2022, at 03:39, Daniel P. Smith = wrote: >=20 > This commit is to move towards providing a uniform interface across > architectures to initialize the XSM framework. Specifically, it provides = a > common handling of initialization failure by providing the printing of a > warning message. >=20 > For Arm, xsm_dt_init() was tailored to have an Arm specific expansion of = the > return values. This expansion added a value to reflect whether the securi= ty > supported XSM policy module was the enforcing policy module. This was the= n used > to determine if a warning message would be printed. Despite this expansio= n, > like x86, Arm does not address any XSM initialization errors that may hav= e > occurred. >=20 > Signed-off-by: Daniel P. Smith For the arm part: Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue May 31 09:25:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339376.564222 (Exim 4.92) (envelope-from ) id 1nvy88-00056G-Ac; Tue, 31 May 2022 09:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339376.564222; Tue, 31 May 2022 09:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvy88-000569-7H; Tue, 31 May 2022 09:25:36 +0000 Received: by outflank-mailman (input) for mailman id 339376; Tue, 31 May 2022 09:25:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvy87-000563-Jh for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:25:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvy86-0008KF-II; Tue, 31 May 2022 09:25:34 +0000 Received: from [54.239.6.187] (helo=[192.168.31.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvy86-0000cy-BC; Tue, 31 May 2022 09:25:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1GvnPgw/r0ABpH8jfYa0EnI+qy0pxiaphto3Lnt1lZM=; b=roGoviSNdWli3oWXzAaYLpZYD5 AGkvPcTzjDzVNF5E8GR99HyvGK7aal1TwDXwHdHF3lvMFwidqZUJitTEZntlciyfqzqn+mBN2bWDD eR15bZwsIvoBBn9LqJdtwCGMt3NSshfcBL2gYoPU/q91X3BSA8ZB0Em8QNA4y7p2d5/0=; Message-ID: Date: Tue, 31 May 2022 10:25:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules To: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, sstabellini@kernel.org, Andrew Cooper , George Dunlap , Jan Beulich , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20220531024127.23669-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 31/05/2022 03:41, Daniel P. Smith wrote: > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index f16eb0df43..57b14e22c9 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,15 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_BOOTMODS > + int "Maximum number of boot modules that a loader can pass" > + range 1 64 OOI, any reason to limit the size? > + default "8" if X86 > + default "32" if ARM > + help > + Controls the build-time size of various arrays allocated for > + parsing the boot modules passed by a loader when starting Xen. > + > + This is of particular interest when using Xen's hypervisor domain > + capabilities such as dom0less. > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 2bb01ecfa8..312a3e4209 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -10,7 +10,8 @@ > > #define NR_MEM_BANKS 256 > > -#define MAX_MODULES 32 /* Current maximum useful modules */ > +/* Current maximum useful modules */ > +#define MAX_MODULES CONFIG_NR_BOOTMODS There are only a handful number of use of MAX_MODULES in Arm. So I would prefer if we replace all the use with CONFIG_NR_BOOTMODS. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 31 09:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339385.564232 (Exim 4.92) (envelope-from ) id 1nvyHv-0006fF-9R; Tue, 31 May 2022 09:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339385.564232; Tue, 31 May 2022 09:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyHv-0006f8-6d; Tue, 31 May 2022 09:35:43 +0000 Received: by outflank-mailman (input) for mailman id 339385; Tue, 31 May 2022 09:35:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyHt-0006f2-Q7 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:35:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyHq-0008UQ-DG; Tue, 31 May 2022 09:35:38 +0000 Received: from [54.239.6.187] (helo=[192.168.31.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvyHq-0001KV-6j; Tue, 31 May 2022 09:35:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=APC904ThHUPVDWQUcZPfNr6hS6iJvtg+do/fLTiG6lI=; b=gb1see10w5X1eXt+lDj4ybDZFg 2j3PNbuK0pRAlBjA0Qy+QW2EvSzhuvhpSYGpimtKbkyZFiCqDoZHSqwius9lb1MlVrAr3Ws8xeMey FrCfSASAYd2l9TWjA6tFBEYtAJlfqDuCHqx2+L3linM32dbeINLMdgJKaqto6oPIjbVU=; Message-ID: <776a312f-29a8-6bd9-1f4b-55be5d0f12bd@xen.org> Date: Tue, 31 May 2022 10:35:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 9/9] xen: retrieve reserved pages on populate_physmap To: Jan Beulich , Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-10-Penny.Zheng@arm.com> <104c921e-68ad-209b-5b3d-797a58e47fbf@suse.com> From: Julien Grall In-Reply-To: <104c921e-68ad-209b-5b3d-797a58e47fbf@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 31/05/2022 09:54, Jan Beulich wrote: > On 31.05.2022 05:12, Penny Zheng wrote: >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) >> >> mfn = _mfn(gpfn); >> } >> + else if ( is_domain_using_staticmem(d) ) >> + { >> + /* >> + * No easy way to guarantee the retrieved pages are contiguous, >> + * so forbid non-zero-order requests here. >> + */ >> + if ( a->extent_order != 0 ) >> + { >> + gdprintk(XENLOG_WARNING, >> + "Cannot allocate static order-%u pages for static %pd\n", >> + a->extent_order, d); >> + goto out; >> + } >> + >> + mfn = acquire_reserved_page(d, a->memflags); >> + if ( mfn_eq(mfn, INVALID_MFN) ) >> + { >> + gdprintk(XENLOG_WARNING, >> + "%pd: failed to retrieve a reserved page\n", >> + d); >> + goto out; >> + } >> + } > > I'm not convinced of having these gdprintk()s here. There are a number of time where I wished some error paths would contain debug printk(). Instead, I often end up to add them myself when I struggle to find the reason of a failure. They are debug printk() and therefore there is no impact on the production build. So I would leave them around. > The adjacent > is_domain_direct_mapped() code is somewhat different - iirc only Dom0 > can be direct-mapped, and Dom0 having a problem can certainly be worth > a log message. There are plan to use direct-mapped domU. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 31 09:40:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:40:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339394.564244 (Exim 4.92) (envelope-from ) id 1nvyMp-00083p-TD; Tue, 31 May 2022 09:40:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339394.564244; Tue, 31 May 2022 09:40:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyMp-00083i-Pk; Tue, 31 May 2022 09:40:47 +0000 Received: by outflank-mailman (input) for mailman id 339394; Tue, 31 May 2022 09:40:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyMo-00083c-St for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:40:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be90ca0e-e0c5-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 11:40:45 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-FrcnVOeuO-aNg0yuKmY5Kg-2; Tue, 31 May 2022 11:40:43 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2349.eurprd04.prod.outlook.com (2603:10a6:800:27::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 09:40:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 09:40:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be90ca0e-e0c5-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1653990045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRrEYUr1PhB3yQHjeFKf3cDCjzXMujI4Hq1C9vwnkvI=; b=mJKHOuVr7BSeoSTaazU91+XRndX+uffktJAErFMwkJjqF2QKcVP7pkrwp3J6qotQWPp56t K/mtgyHPARzGNucOP9OZDcG6J4BcfmdGiO21rW31ZIVOVL0+Xdb1a7Vqjpmcm+8Z8NDmLo UoO6qYO+SEpKwkdROclDbyCV4xY7Y/c= X-MC-Unique: FrcnVOeuO-aNg0yuKmY5Kg-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+7HpAxEfWF3qYQYQHsiduRs0orIRYTLtc/LZr1U+GdG14UR70btuzkZERTg+YFOA+KUFZaXyxsyMljvNXvPgwB5KqygwpniRglBnTauT/HkeKSQYxe78YZm8Qm8wonf7I+dykO3aawqQ6/iUcep9uY1rbYh+QdAvCHuuRHE+hqrzjBhMAhB/8qxPBUEzsQK7KNfg5XthWc0wjr8VAISReu9JGmi0Fegsic/q+alLjHIfHJOrOAJMQcIZKG3Jn1Mp40+Mtwy6VABRQyCYj1Flfhdm9wayyvfOcFktnLpCI1bDUa3tEQpF+WqyFUE4ckDKeoF98LzE02tS6tFm8+ASA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRrEYUr1PhB3yQHjeFKf3cDCjzXMujI4Hq1C9vwnkvI=; b=oAVth+f22xen9vHKY3/HRGw7z/llmMj3XXwjuKJbwfVW6Lv0rSPeuGWCaFaTRV5M+tGoyZQCJBks5i1YX80phGkbkQnejyNhMUhbeAs62iGGLsCTIi2biHegZURq8XmbXdOz4g0WcH8DVSQvX06IGTN30mvgT7ThNRLOKqM1SVEUhV2AFR69JX3EHcgDoY8zi4yKOD/RudRNlYbpmjsFALi60Bae5bafQijxTUbwRgrrFajDLDshzYe+lVMZDyOq7T1+Ly6uugOns3w9AGv6Afn43mNCy4GJO7RtALbS3AaPWKw09MOfBxOibE9LGa+5Lhr2ICcD3X09bTYTmpI7XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e5a4192-66b8-aa15-19e6-a28f5b19d8b0@suse.com> Date: Tue, 31 May 2022 11:40:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 9/9] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Julien Grall Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Penny Zheng References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-10-Penny.Zheng@arm.com> <104c921e-68ad-209b-5b3d-797a58e47fbf@suse.com> <776a312f-29a8-6bd9-1f4b-55be5d0f12bd@xen.org> From: Jan Beulich In-Reply-To: <776a312f-29a8-6bd9-1f4b-55be5d0f12bd@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0002.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f630d403-1c94-4053-5fe1-08da42e9a047 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2349:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SWARJQ0YIIzxf3LpJR/kavbc9HLyN5zfxra2z5AUESHKK7qEvLdjlZfehfzBR7qKHd0rME7xqtz55uq8NTg18F1IRPPFmeGt5TJrRJezryy1liPq1QiMrR6QzJwTm7e5T+N6o31BmW616m0nBCZ75DoI4aVlEovt7kIe9t85lJFW/n6srGwqlPmBliH/OW1oe8N8CkmG4/4oePhj2g+JVqWXenE6e28CP4Ss+uW7AYpOe/aHc4HCW5YEQ8dCY63KRDDDWinqW4AKhuGps/1kvWKYj8yYXYRXi4P9fhah21D34iiS2l3rDmXVAmqqYHMTk1EztmeBtKv9+3PitMwYakU/n+9fXxDyDPMyl+nOabqsH/5hQ/I6Yl5H0f+dqni4o1/jugM48+zD44vAbYT5iUvA3tmg76mzQHrukMbMTwq7S6gC7epSj5Vg1WEk9Meb0DtuKzvFuSJgrM3dCPepydxWXKJUbTOxl9ssGuLOg2hamki59OAZJlJVL05PLX3313TvXAe0710ZixfMiaiuQu2gTfQPghW4fUqUdqmhwIyiMbkFm+GH0lCCnHjxWZTRwC4xaM1+xrPnAKRCSfd6YZGGgwBdk78DPThP8LXNRWXZRSWuPxReI6/jqkTOks/n84mmr+OX0BV1KpVZtibx6inihty+Uisx4OaAdMJJHNpvoKNU6hBFcyghFGS5BKAbBZ4UXGZPvvO/ufp914Y/TzzI8hri34DQrBzCsnauJQk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(8936002)(6916009)(83380400001)(508600001)(31686004)(54906003)(26005)(5660300002)(31696002)(6486002)(66556008)(186003)(66946007)(66476007)(53546011)(6512007)(316002)(6506007)(2616005)(86362001)(2906002)(36756003)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWNwQURwMmFUU1NNUUJ0dWlFcmlNRkY3N2lDUGtHdEU3eGc1d0dVMTVKU0F6?= =?utf-8?B?dFFXRERBMGo4R1FvM0c3NUdWWWlxTy9RVTFUMExDUDUwMk4xMmRrb1ZKM0pM?= =?utf-8?B?UHdXOVFFUzU3VU16bWJ5a0VhRkZzSG5MMmZDd0NVUld6VWMrZTV1b2s3Tmxt?= =?utf-8?B?RWlXTWtQSC9DUmtLZ2dsOXZ3Q1kxaWltMGpxZVJPY1A1SE5BUWxES2doc1lM?= =?utf-8?B?bHduNHBHZG9nZ0pDSEFjbEV0V0hMd3JEL0w0K3dGakRnc1VXZmxJbUhocmFu?= =?utf-8?B?OUdWUHhvNTRCWFZKblN1TUVhVVZibG9HS2dwcWYwRDJFWk5scDNNMW1jYVZh?= =?utf-8?B?Qll6RmFSTjJZWFdIZUVaTkp2WWYyVTdlaHJEZG52d1d0VDRJcjBNbmhaL1hQ?= =?utf-8?B?d3ZpL05lcmRlTlVqSllhRlhxeWJYVWxkK1BlWmtJb1dtRFR6SVErS1pNdzVt?= =?utf-8?B?akdhYzVyWEc3VWF6d2s2RTkrb2wyeHVRYm1BQ1ZscnFrVUZYOXkwSHlGMlc5?= =?utf-8?B?YmlqZWM5Slg0OGpHSG1BTzljWDRjSkV3NjE3c3JOZFQ2d0dSaUUweHAxOWZW?= =?utf-8?B?WG9xVW90QTBZZ0lOQW1zVHlRMFkwelVHNkpPQlFYTmRwRzQzWEFML2NreE55?= =?utf-8?B?b2Z5Tjc5NFY3UVdvdG1JajFFUVN4NkR2ejMxb2d3NDZyUVJoTUd0c0wrSzZQ?= =?utf-8?B?eEhaTCtYU2RIOUxob0RsZHYxL1hRVnBOR0dDQjgwNUQ4ZGtwSmxCd1F3MDY3?= =?utf-8?B?SDhsUnBaRXR2N1V0Z3ppZUV3UUVwc1h3N3A2TURaaDdFNzV6ak5ZRjljZEND?= =?utf-8?B?UG5BNGJHVm94ZVZjL2ZBT0xtSGd4UFJIaEpBYzNISllOOVplOVh6UnUzT3Fr?= =?utf-8?B?eVR4U2dkOG5oUWtLMVJuRk4wcEZSMzh4Y3FEV1FuQ1d4a3Qvbi9lT3daK3Fp?= =?utf-8?B?VHY2Mi9hN2JpcjB6ZFZSTyt6QlFuM2llbklUa3FoVlVnZmdYRkFlYjB1anBk?= =?utf-8?B?SEE2VGh5SUpRckxuTEsra0VDRi84a2pzREE5TFhGOEdGVGVabFVtdEJkTXJk?= =?utf-8?B?ZE5ZZGErNnlmUTNjRWc0c0hZeGdwbzIvV2V0eXROc1BFNnpXWWI3VmZCdFl1?= =?utf-8?B?dWRYNkNnRStTazNGNm1pMVNBanNhTHRkTGRQZDF5WEw1R3F1RStQcGt2SjRq?= =?utf-8?B?S1VHNmw4NGpSRnJvUWhkcUNiSFUzd3M2WDhwTCt6MU5jbTgxRE42SFVMb0JT?= =?utf-8?B?Yll0NUw5dDRobEFKOUpOR1NiUEc3WWZ0MGNzMXJtdEtkM0Vpc0ZrRU5hNmpU?= =?utf-8?B?MzJLTkpSM2J4a3hTcURSUTdSeC8zUTNjTmswZEJ4amI1VERqUVo3bGx6b1RY?= =?utf-8?B?SmIzQXZNR2dMa0xReGtqYk4wWHlUVEVDYXlRV0xZWkNJMlJsaXdtNHRUYmhw?= =?utf-8?B?R2RtNUttK1FVc0ZaVExNc0Y0WnJZbXJOdTdaY1Q4SHJOSHlJL2RxUUhsY2hq?= =?utf-8?B?cDR1MVhhYVhqVG8zSFRHZXU0MEVqZnA4TjdZMGFUYUFtOE9OL09tN2IzOTVZ?= =?utf-8?B?Z1hkUzJiN3JyR3dZUGdZZWF4Tm1hVG11Z2JNV05XcDgvaGdYbDZLbmFTZVU5?= =?utf-8?B?MndGUTRKQUw5R3BFcmZIc2NpQmU4dk5vcHhoRnNVTWJRQUR6ZGc0OStCRUhi?= =?utf-8?B?TytmTG5NVFpMTVYxWk5FRnN2dW1ra3B3L2IycytQWWgvU1NsdkxvLysrdFhq?= =?utf-8?B?V2EwSnQ1WWJVWE1Ddm9FVkJKOGt3RmdZNTc0ZEJrMmNZTmNuN2xlZ1BCWUdp?= =?utf-8?B?RjFWVldsTFBMWldoVU9XMVo1NjI5SDJYTHRkaGhQdjFmZWRaWFQ2RHlTd1hx?= =?utf-8?B?bTlvRXJvSk9jVlJpY1NjVHhDVHovSTMzZ3l0NGIyQjZlVkVFcU9JSkQwQWpr?= =?utf-8?B?K2orS09CckdTU1VJOExvOTdxSmVoUlNWZHFBK3NWeGJBZ3JQc0FVdHVBdk1P?= =?utf-8?B?U3FYWmJJRzNTc1hiV0hid0xGdm5XejV5NFhaOU1SclRxWUM2VytkSVNhczVM?= =?utf-8?B?THhuekR1WVoxakw5OXZ3NWVKakkzcDJ5QnI0S1BkemQyWHZFSEh6M0pWcmF5?= =?utf-8?B?VGlUUTNmeVpwclNLOXhLZ3hrUkEvKzhldnlWT25IR3pUWjU2aDFLWGNDdW9R?= =?utf-8?B?cWZhcUJuMUdNMGZGTk9TU1JGaXdLRzhRTmJXSlM5WXd3azRxTDhIUzg0NU82?= =?utf-8?B?VzFqVDJvai9VL2JrdldpOWtFM3FUSW16dXlMNk82bGliMHA1TUFJRFdBS1N0?= =?utf-8?B?WU5Zb0p3ckxRSnpBVGVJcFRZNUJvK1YxSWhqSHhISjJlRG9DMlVPdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f630d403-1c94-4053-5fe1-08da42e9a047 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 09:40:41.1441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e7z5+FhFbIWaH0JtD0XeVYlLaZEzaDlO6JAyPxrkque5VaLd+H+1DTU77DKKVVX4acsafd+U7JMxYzsxaBbRPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2349 On 31.05.2022 11:35, Julien Grall wrote: > On 31/05/2022 09:54, Jan Beulich wrote: >> On 31.05.2022 05:12, Penny Zheng wrote: >>> --- a/xen/common/memory.c >>> +++ b/xen/common/memory.c >>> @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) >>> >>> mfn = _mfn(gpfn); >>> } >>> + else if ( is_domain_using_staticmem(d) ) >>> + { >>> + /* >>> + * No easy way to guarantee the retrieved pages are contiguous, >>> + * so forbid non-zero-order requests here. >>> + */ >>> + if ( a->extent_order != 0 ) >>> + { >>> + gdprintk(XENLOG_WARNING, >>> + "Cannot allocate static order-%u pages for static %pd\n", >>> + a->extent_order, d); >>> + goto out; >>> + } >>> + >>> + mfn = acquire_reserved_page(d, a->memflags); >>> + if ( mfn_eq(mfn, INVALID_MFN) ) >>> + { >>> + gdprintk(XENLOG_WARNING, >>> + "%pd: failed to retrieve a reserved page\n", >>> + d); >>> + goto out; >>> + } >>> + } >> >> I'm not convinced of having these gdprintk()s here. > > There are a number of time where I wished some error paths would contain > debug printk(). Instead, I often end up to add them myself when I > struggle to find the reason of a failure. But this model doesn't scale - we don't want to have log messages on each and every error path. I agree having such for very unlikely errors, but order != 0 is clearly a call site mistake and memory allocation requests failing also ought to not be entirely unexpected. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 09:41:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:41:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339397.564255 (Exim 4.92) (envelope-from ) id 1nvyNB-0008WD-AB; Tue, 31 May 2022 09:41:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339397.564255; Tue, 31 May 2022 09:41:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyNB-0008W4-72; Tue, 31 May 2022 09:41:09 +0000 Received: by outflank-mailman (input) for mailman id 339397; Tue, 31 May 2022 09:41:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyNA-0008Vm-2g for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:41:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyN8-00009B-4v; Tue, 31 May 2022 09:41:06 +0000 Received: from [54.239.6.187] (helo=[192.168.31.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvyN7-0001fK-UU; Tue, 31 May 2022 09:41:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=KMb7jxQSPc/OMyDnquFQK7AvqnxlS10nnNQbZD4mO7Q=; b=bdP7jQgSkv2XbHUpYGryO7CrIb EWOfMKT0gr1CnWikFpaObK8VGG84JAMGHbOjaCzwNlCbc/GCewp/GEVTEzQOzXyNhjneHXDWYx4tc 4MPz/i9nKcWlJtZLc9Q8reAb7kGWsV13TFdbPBeBGWchIglc9owGfwQmVuNZ6f3qUJuE=; Message-ID: <10687069-5498-11f8-5474-fa34ee837025@xen.org> Date: Tue, 31 May 2022 10:41:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst To: Bertrand Marquis , George Dunlap Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Andrew Cooper , Roger Pau Monne , Stefano Stabellini , Stefano Stabellini References: <0cf7383d-896e-76f0-b1cc-2f20bd7f368e@suse.com> <765738F2-97E9-40EF-A50E-2912C7D2A286@arm.com> <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> <5b790260-dd5c-9f62-7151-7684a0dc18fa@suse.com> <0cc9c342-f355-5816-09e9-a996624c6a79@xen.org> <6d6115a9-2810-0c9b-bba3-968b3ac50110@suse.com> <138D3C39-74A6-46CB-B598-2FC5FAD1E52D@arm.com> From: Julien Grall In-Reply-To: <138D3C39-74A6-46CB-B598-2FC5FAD1E52D@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 30/05/2022 14:35, Bertrand Marquis wrote: >> Obviously something *else* we might want is a more convenient way to keep that rationale for the future, when we start to officially document deviations. Given that the scanner will point out all the places where deviations happen, I don’t think an unstructured comment with an informal summary of the justification would be a problem — it seems like it would be a lot easier, when we start to officially document deviations, to transform comments in the existing codebase, than to search through the mailing lists and/or git commit history to find the rationale (or try to work out unaided what the intent was). But I don’t have strong opinions on the matter. > > Maybe agreeing on a simple tag to start that can later be improved (Luca Fancellu on my side will start working on that with the FuSa SIG and Eclair next month). > > So I would suggest: > > /** > * MISRA_DEV: Rule ID > * xxxxx justification > * > */ > > Whenever we will have defined the final way, we will replace those entries with the new system. > > Would that be an agreeable solution ? I am fine with that. With one NIT thought, in Xen comments the first line of multi-line comment is "/*" rather than "/**". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 31 09:50:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 09:50:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339415.564266 (Exim 4.92) (envelope-from ) id 1nvyVx-0001ov-7j; Tue, 31 May 2022 09:50:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339415.564266; Tue, 31 May 2022 09:50:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyVx-0001oo-4w; Tue, 31 May 2022 09:50:13 +0000 Received: by outflank-mailman (input) for mailman id 339415; Tue, 31 May 2022 09:50:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyVv-0001oi-Vb for xen-devel@lists.xenproject.org; Tue, 31 May 2022 09:50:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvyVt-0000IE-I0; Tue, 31 May 2022 09:50:09 +0000 Received: from [54.239.6.187] (helo=[192.168.31.167]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nvyVt-0002GI-A1; Tue, 31 May 2022 09:50:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EsU6oy8x0NWg8sJFpxBvf2A+UkORh59g+lsy5zQZtZU=; b=K0MyN3xg7WdTKgkILKd09+C7KG lcPAlYyCbDlK2rNKGx1M0GpibO17Aisgrnf9tjabxLpFbSTHbiLa3kSfiROa6FaOymgxquqWSTUuQ t7aLbB2Q5CYNGXFL1pwqtC66eVrID6MWopFWT8NIbazyylOTYcir37ETlwMkMWym7oAE=; Message-ID: Date: Tue, 31 May 2022 10:50:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 9/9] xen: retrieve reserved pages on populate_physmap To: Jan Beulich Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Penny Zheng References: <20220531031241.90374-1-Penny.Zheng@arm.com> <20220531031241.90374-10-Penny.Zheng@arm.com> <104c921e-68ad-209b-5b3d-797a58e47fbf@suse.com> <776a312f-29a8-6bd9-1f4b-55be5d0f12bd@xen.org> <9e5a4192-66b8-aa15-19e6-a28f5b19d8b0@suse.com> From: Julien Grall In-Reply-To: <9e5a4192-66b8-aa15-19e6-a28f5b19d8b0@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 31/05/2022 10:40, Jan Beulich wrote: > On 31.05.2022 11:35, Julien Grall wrote: >> On 31/05/2022 09:54, Jan Beulich wrote: >>> On 31.05.2022 05:12, Penny Zheng wrote: >>>> --- a/xen/common/memory.c >>>> +++ b/xen/common/memory.c >>>> @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) >>>> >>>> mfn = _mfn(gpfn); >>>> } >>>> + else if ( is_domain_using_staticmem(d) ) >>>> + { >>>> + /* >>>> + * No easy way to guarantee the retrieved pages are contiguous, >>>> + * so forbid non-zero-order requests here. >>>> + */ >>>> + if ( a->extent_order != 0 ) >>>> + { >>>> + gdprintk(XENLOG_WARNING, >>>> + "Cannot allocate static order-%u pages for static %pd\n", >>>> + a->extent_order, d); >>>> + goto out; >>>> + } >>>> + >>>> + mfn = acquire_reserved_page(d, a->memflags); >>>> + if ( mfn_eq(mfn, INVALID_MFN) ) >>>> + { >>>> + gdprintk(XENLOG_WARNING, >>>> + "%pd: failed to retrieve a reserved page\n", >>>> + d); >>>> + goto out; >>>> + } >>>> + } >>> >>> I'm not convinced of having these gdprintk()s here. >> >> There are a number of time where I wished some error paths would contain >> debug printk(). Instead, I often end up to add them myself when I >> struggle to find the reason of a failure. > > But this model doesn't scale - we don't want to have log messages on > each and every error path. I agree having such for very unlikely > errors, but order != 0 is clearly a call site mistake and memory > allocation requests failing also ought to not be entirely unexpected. The problem is from the guest PoV, the error for both is the same. So it would be difficult (not impossible) for the developper to know what's the exact problem. But note that we already have a gdprintk() for allocation failure in the non-direct map case. So I think they should be here for consistency. If you want to drop the existing one, then this is a separate discussion. And, just so you know, I would strongly argue against removing them for the reason I stated above. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue May 31 10:40:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:40:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339426.564276 (Exim 4.92) (envelope-from ) id 1nvzIG-0007Ji-4E; Tue, 31 May 2022 10:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339426.564276; Tue, 31 May 2022 10:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzIG-0007J2-0c; Tue, 31 May 2022 10:40:08 +0000 Received: by outflank-mailman (input) for mailman id 339426; Tue, 31 May 2022 10:40:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzIE-0007C2-NE for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:40:06 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0701e400-e0ce-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 12:40:04 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653993601174192.65366825164335; Tue, 31 May 2022 03:40:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0701e400-e0ce-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653993602; cv=none; d=zohomail.com; s=zohoarc; b=WdDk0I9HfLtwu0zz8dawgMVtoRrKcbqrWZ561ocB2rvCfViaSYAUEE2K2uvtKLozZRbVG29Rn59vW4tE8IVnmpgeIcklsQ5QXn4uiu4DslRWzTvYlqVcI+o8yBo8EP0BnVhzDsW10xht2Uv9BcpkpbJjlDRp9sdAThmZqN1xCxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653993602; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=I2QvtA0PYsYVOZIvSOMYE6WUfmymfnA0ryQYhzCsR3Y=; b=fYVp4Wv/m75Jya56irOrbkTXp51uItxXWlDLg8xI4rR5yJB39froN+aXYAKvDIQDJW5K6ToTr8TubJv2ic+cSuTpt4B+IaKXAef2Lb0oT9h21hK/GCvAyJK9SvclOLnS+RjnSMDI78OaB3eYvsmk/J5M10nj3xtoiHmArtNFcug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653993602; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=I2QvtA0PYsYVOZIvSOMYE6WUfmymfnA0ryQYhzCsR3Y=; b=JoPSoo7jrfcOQoKgXyGhDMnKZbQAx0EYaVEFh+WmV6InHvqLpk+l+aqDg81FMvTI apt4Rxg1bxKJep6A8cYBrRfUdcAyfQvKwVVf3o+Y7P6127hKUcL4539+FdqbcDI9rj+ aQtvzbhLv88aduZagvTTAjitfjYmF0xRKnh0GhEg= Message-ID: Date: Tue, 31 May 2022 06:38:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [v2 0/3] xsm: refactor and optimize policy loading Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, xen-devel@lists.xenproject.org References: <20220531023945.22196-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 04:25, Jan Beulich wrote: > On 31.05.2022 04:39, Daniel P. Smith wrote: >> This series was born out of some cleanup work done while crafting the >> hyperlaunch boot modules patch series. The primary purpose of this series was >> to stop walking all boot modules when it was not necessary, but the scope >> creeped during review. >> >> Changes in v2: >> * changed init_policy to policy_file_required >> * split the patch into a series >> * corrected casting of policy buffer >> * use IS_ENABLED() instead of #ifdef sequence >> * moved #ifdef inside of braces for xsm_dt_policy_init() >> * addressed lack of error handling of xsm{mb,dt}_init() >> >> Daniel P. Smith (3): >> xsm: only search for a policy file when needed >> xsm: consolidate loading the policy buffer >> xsm: properly handle error from XSM init > > The thread consists of 5 follow-ups, including two different 1/3 and two > different 2/3. This wants sorting and then perhaps (properly) resending. Yep, looks like I had stray copies from an internal review spin. My apologies. Will resend clean version. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 10:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339435.564288 (Exim 4.92) (envelope-from ) id 1nvzLN-00081B-KB; Tue, 31 May 2022 10:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339435.564288; Tue, 31 May 2022 10:43:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLN-000814-HH; Tue, 31 May 2022 10:43:21 +0000 Received: by outflank-mailman (input) for mailman id 339435; Tue, 31 May 2022 10:43:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLM-00080t-DE for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:43:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7c02f61f-e0ce-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 12:43:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4F9923A; Tue, 31 May 2022 03:43:18 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F0BBB3F73D; Tue, 31 May 2022 03:43:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c02f61f-e0ce-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 0/4] Spectre BHB follow up Date: Tue, 31 May 2022 11:43:03 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Following up the handling of Spectre BHB on Arm (XSA-398), this serie contain several changes which were not needed in the XSA patches but should be done in Xen: - Sync sysregs and cpuinfo with latest version of Linux (5.18-rc3) - Add new fields inside cpufeature - Add sb instruction support. Some newer generations of CPU (Neoverse-N2) do support the instruction so add support for it in Xen. - Create hidden Kconfig entries for CONFIG_ values actually used in arm64 cpufeature. Changes in v2 - remove patch which was merged (workaround 1 when workaround 3 is done) - split sync with linux and update of cpufeatures - add patch to define kconfig entries used by arm64 cpufeature Bertrand Marquis (4): xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 xen/arm: Add sb instruction support arm: add ISAR2, MMFR0 and MMFR1 fields in cpufeature arm: Define kconfig symbols used by arm64 cpufeatures xen/arch/arm/Kconfig | 28 +++++++++ xen/arch/arm/arm64/cpufeature.c | 18 +++++- xen/arch/arm/cpufeature.c | 28 +++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- xen/arch/arm/include/asm/cpufeature.h | 34 +++++++++-- xen/arch/arm/include/asm/macros.h | 33 +++++++--- xen/arch/arm/setup.c | 3 + xen/arch/arm/smpboot.c | 1 + 8 files changed, 193 insertions(+), 28 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 10:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339436.564299 (Exim 4.92) (envelope-from ) id 1nvzLO-0008H9-TL; Tue, 31 May 2022 10:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339436.564299; Tue, 31 May 2022 10:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLO-0008Gw-PB; Tue, 31 May 2022 10:43:22 +0000 Received: by outflank-mailman (input) for mailman id 339436; Tue, 31 May 2022 10:43:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLN-00080t-62 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:43:21 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7c877d60-e0ce-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 12:43:20 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E3DBED1; Tue, 31 May 2022 03:43:19 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DCA8F3F73D; Tue, 31 May 2022 03:43:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c877d60-e0ce-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 1/4] xen/arm: Sync sysregs and cpuinfo with Linux 5.18-rc3 Date: Tue, 31 May 2022 11:43:04 +0100 Message-Id: <6b828874989f198afe9041185075938f718dd495.1653993431.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sync existing ID registers sanitization with the status of Linux kernel version 5.18-rc3 and add sanitization of ISAR2 registers. Sync sysregs.h bit shift defintions with the status of Linux kernel version 5.18-rc3. Changes in this patch are splitted in a number of patches in Linux kernel and, as the previous synchronisation point was not clear, the changes are done in one patch with a status possible to compare easily by diffing Xen files to Linux kernel files. Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b2d229d4ddb1 Signed-off-by: Bertrand Marquis --- Changes in v2 - move changes in cpufeature.h in an independent patch - add proper origin tag in the commit - rework the commit message --- xen/arch/arm/arm64/cpufeature.c | 18 +++++- xen/arch/arm/include/asm/arm64/sysregs.h | 76 ++++++++++++++++++++---- 2 files changed, 80 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index 6e5d30dc7b..d9039d37b2 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -143,6 +143,16 @@ static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { ARM64_FTR_END, }; +static const struct arm64_ftr_bits ftr_id_aa64isar2[] = { + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64ISAR2_CLEARBHB_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), + FTR_STRICT, FTR_EXACT, ID_AA64ISAR2_APA3_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_GPA3_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64ISAR2_RPRES_SHIFT, 4, 0), + ARM64_FTR_END, +}; + static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV3_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV2_SHIFT, 4, 0), @@ -158,8 +168,8 @@ static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_FP_SHIFT, 4, ID_AA64PFR0_FP_NI), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL3_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL2_SHIFT, 4, 0), - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_EL1_64BIT_ONLY), - ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_EL0_64BIT_ONLY), + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_ELx_64BIT_ONLY), ARM64_FTR_END, }; @@ -197,7 +207,7 @@ static const struct arm64_ftr_bits ftr_id_aa64zfr0[] = { }; static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { - ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_FGT_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EXS_SHIFT, 4, 0), /* @@ -243,6 +253,7 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { }; static const struct arm64_ftr_bits ftr_id_aa64mmfr1[] = { + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_AFP_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_ETS_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_TWED_SHIFT, 4, 0), ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_XNX_SHIFT, 4, 0), @@ -588,6 +599,7 @@ void update_system_features(const struct cpuinfo_arm *new) SANITIZE_ID_REG(isa64, 0, aa64isar0); SANITIZE_ID_REG(isa64, 1, aa64isar1); + SANITIZE_ID_REG(isa64, 2, aa64isar2); SANITIZE_ID_REG(zfr64, 0, aa64zfr0); diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index eac08ed33f..54670084c3 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -144,6 +144,30 @@ /* id_aa64isar2 */ #define ID_AA64ISAR2_CLEARBHB_SHIFT 28 +#define ID_AA64ISAR2_APA3_SHIFT 12 +#define ID_AA64ISAR2_GPA3_SHIFT 8 +#define ID_AA64ISAR2_RPRES_SHIFT 4 +#define ID_AA64ISAR2_WFXT_SHIFT 0 + +#define ID_AA64ISAR2_RPRES_8BIT 0x0 +#define ID_AA64ISAR2_RPRES_12BIT 0x1 +/* + * Value 0x1 has been removed from the architecture, and is + * reserved, but has not yet been removed from the ARM ARM + * as of ARM DDI 0487G.b. + */ +#define ID_AA64ISAR2_WFXT_NI 0x0 +#define ID_AA64ISAR2_WFXT_SUPPORTED 0x2 + +#define ID_AA64ISAR2_APA3_NI 0x0 +#define ID_AA64ISAR2_APA3_ARCHITECTED 0x1 +#define ID_AA64ISAR2_APA3_ARCH_EPAC 0x2 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2 0x3 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC 0x4 +#define ID_AA64ISAR2_APA3_ARCH_EPAC2_FPAC_CMB 0x5 + +#define ID_AA64ISAR2_GPA3_NI 0x0 +#define ID_AA64ISAR2_GPA3_ARCHITECTED 0x1 /* id_aa64pfr0 */ #define ID_AA64PFR0_CSV3_SHIFT 60 @@ -165,14 +189,13 @@ #define ID_AA64PFR0_AMU 0x1 #define ID_AA64PFR0_SVE 0x1 #define ID_AA64PFR0_RAS_V1 0x1 +#define ID_AA64PFR0_RAS_V1P1 0x2 #define ID_AA64PFR0_FP_NI 0xf #define ID_AA64PFR0_FP_SUPPORTED 0x0 #define ID_AA64PFR0_ASIMD_NI 0xf #define ID_AA64PFR0_ASIMD_SUPPORTED 0x0 -#define ID_AA64PFR0_EL1_64BIT_ONLY 0x1 -#define ID_AA64PFR0_EL1_32BIT_64BIT 0x2 -#define ID_AA64PFR0_EL0_64BIT_ONLY 0x1 -#define ID_AA64PFR0_EL0_32BIT_64BIT 0x2 +#define ID_AA64PFR0_ELx_64BIT_ONLY 0x1 +#define ID_AA64PFR0_ELx_32BIT_64BIT 0x2 /* id_aa64pfr1 */ #define ID_AA64PFR1_MPAMFRAC_SHIFT 16 @@ -189,6 +212,7 @@ #define ID_AA64PFR1_MTE_NI 0x0 #define ID_AA64PFR1_MTE_EL0 0x1 #define ID_AA64PFR1_MTE 0x2 +#define ID_AA64PFR1_MTE_ASYMM 0x3 /* id_aa64zfr0 */ #define ID_AA64ZFR0_F64MM_SHIFT 56 @@ -228,17 +252,37 @@ #define ID_AA64MMFR0_ASID_SHIFT 4 #define ID_AA64MMFR0_PARANGE_SHIFT 0 -#define ID_AA64MMFR0_TGRAN4_NI 0xf -#define ID_AA64MMFR0_TGRAN4_SUPPORTED 0x0 -#define ID_AA64MMFR0_TGRAN64_NI 0xf -#define ID_AA64MMFR0_TGRAN64_SUPPORTED 0x0 -#define ID_AA64MMFR0_TGRAN16_NI 0x0 -#define ID_AA64MMFR0_TGRAN16_SUPPORTED 0x1 +#define ID_AA64MMFR0_ASID_8 0x0 +#define ID_AA64MMFR0_ASID_16 0x2 + +#define ID_AA64MMFR0_TGRAN4_NI 0xf +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0 +#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MAX 0x7 +#define ID_AA64MMFR0_TGRAN64_NI 0xf +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0 +#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MAX 0x7 +#define ID_AA64MMFR0_TGRAN16_NI 0x0 +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MIN 0x1 +#define ID_AA64MMFR0_TGRAN16_SUPPORTED_MAX 0xf + +#define ID_AA64MMFR0_PARANGE_32 0x0 +#define ID_AA64MMFR0_PARANGE_36 0x1 +#define ID_AA64MMFR0_PARANGE_40 0x2 +#define ID_AA64MMFR0_PARANGE_42 0x3 +#define ID_AA64MMFR0_PARANGE_44 0x4 #define ID_AA64MMFR0_PARANGE_48 0x5 #define ID_AA64MMFR0_PARANGE_52 0x6 +#define ARM64_MIN_PARANGE_BITS 32 + +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_DEFAULT 0x0 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_NONE 0x1 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MIN 0x2 +#define ID_AA64MMFR0_TGRAN_2_SUPPORTED_MAX 0x7 + /* id_aa64mmfr1 */ #define ID_AA64MMFR1_ECBHB_SHIFT 60 +#define ID_AA64MMFR1_AFP_SHIFT 44 #define ID_AA64MMFR1_ETS_SHIFT 36 #define ID_AA64MMFR1_TWED_SHIFT 32 #define ID_AA64MMFR1_XNX_SHIFT 28 @@ -271,6 +315,9 @@ #define ID_AA64MMFR2_CNP_SHIFT 0 /* id_aa64dfr0 */ +#define ID_AA64DFR0_MTPMU_SHIFT 48 +#define ID_AA64DFR0_TRBE_SHIFT 44 +#define ID_AA64DFR0_TRACE_FILT_SHIFT 40 #define ID_AA64DFR0_DOUBLELOCK_SHIFT 36 #define ID_AA64DFR0_PMSVER_SHIFT 32 #define ID_AA64DFR0_CTX_CMPS_SHIFT 28 @@ -284,11 +331,18 @@ #define ID_AA64DFR0_PMUVER_8_1 0x4 #define ID_AA64DFR0_PMUVER_8_4 0x5 #define ID_AA64DFR0_PMUVER_8_5 0x6 +#define ID_AA64DFR0_PMUVER_8_7 0x7 #define ID_AA64DFR0_PMUVER_IMP_DEF 0xf +#define ID_AA64DFR0_PMSVER_8_2 0x1 +#define ID_AA64DFR0_PMSVER_8_3 0x2 + #define ID_DFR0_PERFMON_SHIFT 24 -#define ID_DFR0_PERFMON_8_1 0x4 +#define ID_DFR0_PERFMON_8_0 0x3 +#define ID_DFR0_PERFMON_8_1 0x4 +#define ID_DFR0_PERFMON_8_4 0x5 +#define ID_DFR0_PERFMON_8_5 0x6 #define ID_ISAR4_SWP_FRAC_SHIFT 28 #define ID_ISAR4_PSR_M_SHIFT 24 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 10:43:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:43:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339437.564310 (Exim 4.92) (envelope-from ) id 1nvzLQ-00005V-4l; Tue, 31 May 2022 10:43:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339437.564310; Tue, 31 May 2022 10:43:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLQ-0008WO-0I; Tue, 31 May 2022 10:43:24 +0000 Received: by outflank-mailman (input) for mailman id 339437; Tue, 31 May 2022 10:43:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLO-00080t-9k for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:43:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7d81cf07-e0ce-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 12:43:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B72B1480; Tue, 31 May 2022 03:43:21 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A806A3F73D; Tue, 31 May 2022 03:43:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d81cf07-e0ce-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 3/4] arm: add ISAR2, MMFR0 and MMFR1 fields in cpufeature Date: Tue, 31 May 2022 11:43:06 +0100 Message-Id: <4a0aef106ac7b6c16048ff3554eda1d8b3eab61a.1653993431.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Complete AA64ISAR2 and AA64MMFR[0-1] with more fields. While there add a comment for MMFR bitfields as for other registers in the cpuinfo structure definition. Signed-off-by: Bertrand Marquis --- Changes in v2: - patch introduced to isolate changes in cpufeature.h - complete MMFR0 and ISAR2 to sync with sysregs.h status --- xen/arch/arm/include/asm/cpufeature.h | 28 ++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index 9649a7afee..57eb6773d3 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -234,6 +234,7 @@ struct cpuinfo_arm { union { register_t bits[3]; struct { + /* MMFR0 */ unsigned long pa_range:4; unsigned long asid_bits:4; unsigned long bigend:4; @@ -242,18 +243,31 @@ struct cpuinfo_arm { unsigned long tgranule_16K:4; unsigned long tgranule_64K:4; unsigned long tgranule_4K:4; - unsigned long __res0:32; - + unsigned long tgranule_16k_2:4; + unsigned long tgranule_64k_2:4; + unsigned long tgranule_4k:4; + unsigned long exs:4; + unsigned long __res0:8; + unsigned long fgt:4; + unsigned long ecv:4; + + /* MMFR1 */ unsigned long hafdbs:4; unsigned long vmid_bits:4; unsigned long vh:4; unsigned long hpds:4; unsigned long lo:4; unsigned long pan:4; - unsigned long __res1:8; - unsigned long __res2:28; + unsigned long specsei:4; + unsigned long xnx:4; + unsigned long twed:4; + unsigned long ets:4; + unsigned long __res1:4; + unsigned long afp:4; + unsigned long __res2:12; unsigned long ecbhb:4; + /* MMFR2 */ unsigned long __res3:64; }; } mm64; @@ -297,7 +311,11 @@ struct cpuinfo_arm { unsigned long __res2:8; /* ISAR2 */ - unsigned long __res3:28; + unsigned long wfxt:4; + unsigned long rpres:4; + unsigned long gpa3:4; + unsigned long apa3:4; + unsigned long __res3:12; unsigned long clearbhb:4; unsigned long __res4:32; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 10:43:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:43:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339438.564321 (Exim 4.92) (envelope-from ) id 1nvzLR-0000Os-Jf; Tue, 31 May 2022 10:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339438.564321; Tue, 31 May 2022 10:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLR-0000Oh-GT; Tue, 31 May 2022 10:43:25 +0000 Received: by outflank-mailman (input) for mailman id 339438; Tue, 31 May 2022 10:43:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLO-0008DB-O8 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:43:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7d2380f5-e0ce-11ec-837f-e5687231ffcc; Tue, 31 May 2022 12:43:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72A531474; Tue, 31 May 2022 03:43:20 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3EB83F73D; Tue, 31 May 2022 03:43:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d2380f5-e0ce-11ec-837f-e5687231ffcc From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 2/4] xen/arm: Add sb instruction support Date: Tue, 31 May 2022 11:43:05 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch is adding sb instruction support when it is supported by a CPU on arm64. A new cpu feature capability system is introduced to enable alternative code using sb instruction when it is supported by the processor. This is decided based on the isa64 system register value and use a new hardware capabitility ARM64_HAS_SB. The sb instruction is encoded using its hexadecimal value to avoid recursive macro and support old compilers not having support for sb instruction. Arm32 instruction support is added but it is not enabled at the moment due to the lack of hardware supporting it. Signed-off-by: Bertrand Marquis --- Changes in v2: - fix commit message - add comment to explain the extra nop - add support for arm32 and move macro back to arm generic header - fix macro comment indentation - introduce cpu feature system instead of using errata --- xen/arch/arm/cpufeature.c | 28 +++++++++++++++++++++++ xen/arch/arm/include/asm/cpufeature.h | 6 ++++- xen/arch/arm/include/asm/macros.h | 33 ++++++++++++++++++++------- xen/arch/arm/setup.c | 3 +++ xen/arch/arm/smpboot.c | 1 + 5 files changed, 62 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index a58965f7b9..5d1421dc67 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -26,6 +26,24 @@ DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); struct cpuinfo_arm __read_mostly guest_cpuinfo; +#ifdef CONFIG_ARM_64 +static bool has_sb_instruction(const struct arm_cpu_capabilities *entry) +{ + return system_cpuinfo.isa64.sb; +} +#endif + +static const struct arm_cpu_capabilities arm_features[] = { +#ifdef CONFIG_ARM_64 + { + .desc = "Speculation barrier instruction (SB)", + .capability = ARM64_HAS_SB, + .matches = has_sb_instruction, + }, +#endif + {}, +}; + void update_cpu_capabilities(const struct arm_cpu_capabilities *caps, const char *info) { @@ -70,6 +88,16 @@ void __init enable_cpu_capabilities(const struct arm_cpu_capabilities *caps) } } +void check_local_cpu_features(void) +{ + update_cpu_capabilities(arm_features, "enabled support for"); +} + +void __init enable_cpu_features(void) +{ + enable_cpu_capabilities(arm_features); +} + /* * Run through the enabled capabilities and enable() them on the calling CPU. * If enabling of any capability fails the error is returned. After enabling a diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index f7368766c0..9649a7afee 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -67,8 +67,9 @@ #define ARM_WORKAROUND_BHB_LOOP_24 13 #define ARM_WORKAROUND_BHB_LOOP_32 14 #define ARM_WORKAROUND_BHB_SMCC_3 15 +#define ARM64_HAS_SB 16 -#define ARM_NCAPS 16 +#define ARM_NCAPS 17 #ifndef __ASSEMBLY__ @@ -78,6 +79,9 @@ extern DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); +void check_local_cpu_features(void); +void enable_cpu_features(void); + static inline bool cpus_have_cap(unsigned int num) { if ( num >= ARM_NCAPS ) diff --git a/xen/arch/arm/include/asm/macros.h b/xen/arch/arm/include/asm/macros.h index 1aa373760f..33e863d982 100644 --- a/xen/arch/arm/include/asm/macros.h +++ b/xen/arch/arm/include/asm/macros.h @@ -5,14 +5,7 @@ # error "This file should only be included in assembly file" #endif - /* - * Speculative barrier - * XXX: Add support for the 'sb' instruction - */ - .macro sb - dsb nsh - isb - .endm +#include #if defined (CONFIG_ARM_32) # include @@ -29,4 +22,28 @@ .endr .endm + /* + * Speculative barrier + */ + .macro sb +alternative_if_not ARM64_HAS_SB + dsb nsh + isb +alternative_else + /* + * SB encoding in hexadecimal to prevent recursive macro. + * extra nop is required to keep same number of instructions on both sides + * of the alternative. + */ +#if defined(CONFIG_ARM_32) + .inst 0xf57ff070 +#elif defined(CONFIG_ARM_64) + .inst 0xd50330ff +#else +# error "missing sb encoding for ARM variant" +#endif + nop +alternative_endif + .endm + #endif /* __ASM_ARM_MACROS_H */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index ea1f5ee3d3..b44494c9a9 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -961,6 +961,8 @@ void __init start_xen(unsigned long boot_phys_offset, */ check_local_cpu_errata(); + check_local_cpu_features(); + init_xen_time(); gic_init(); @@ -1030,6 +1032,7 @@ void __init start_xen(unsigned long boot_phys_offset, */ apply_alternatives_all(); enable_errata_workarounds(); + enable_cpu_features(); /* Create initial domain 0. */ if ( !is_dom0less_mode() ) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 9bb32a301a..fb7cc43a93 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -389,6 +389,7 @@ void start_secondary(void) local_abort_enable(); check_local_cpu_errata(); + check_local_cpu_features(); printk(XENLOG_DEBUG "CPU %u booted.\n", smp_processor_id()); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 10:43:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339439.564327 (Exim 4.92) (envelope-from ) id 1nvzLS-0000T8-3t; Tue, 31 May 2022 10:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339439.564327; Tue, 31 May 2022 10:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLR-0000S9-R2; Tue, 31 May 2022 10:43:25 +0000 Received: by outflank-mailman (input) for mailman id 339439; Tue, 31 May 2022 10:43:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzLP-00080t-GP for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:43:23 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7e249c40-e0ce-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 12:43:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4299C14BF; Tue, 31 May 2022 03:43:22 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 911AB3F73D; Tue, 31 May 2022 03:43:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e249c40-e0ce-11ec-bd2c-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v2 4/4] arm: Define kconfig symbols used by arm64 cpufeatures Date: Tue, 31 May 2022 11:43:07 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Define kconfig symbols which are used by arm64 cpufeatures to prevent using undefined symbols and rely on IS_ENABLED returning false. All the features related to those symbols are unsupported by Xen: - pointer authentication - sve - memory tagging - branch target identification Signed-off-by: Bertrand Marquis --- Change in v2: - patch introduced --- xen/arch/arm/Kconfig | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ecfa6822e4..c9a4e40e9b 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -97,6 +97,34 @@ config HARDEN_BRANCH_PREDICTOR If unsure, say Y. +config ARM64_PTR_AUTH + def_bool n + depends on ARM64 + help + Pointer authentication support. + This feature is not supported in Xen. + +config ARM64_SVE + def_bool n + depends on ARM64 + help + Scalar Vector Extension support. + This feature is not supported in Xen. + +config ARM64_MTE + def_bool n + depends on ARM64 + help + Memory Tagging Extension support. + This feature is not supported in Xen. + +config ARM64_BTI + def_bool n + depends on ARM64 + help + Branch Target Identification support. + This feature is not supported in Xen. + config TEE bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED default n -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 10:47:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339460.564343 (Exim 4.92) (envelope-from ) id 1nvzPO-0002Yu-KT; Tue, 31 May 2022 10:47:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339460.564343; Tue, 31 May 2022 10:47:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzPO-0002Yn-Gq; Tue, 31 May 2022 10:47:30 +0000 Received: by outflank-mailman (input) for mailman id 339460; Tue, 31 May 2022 10:47:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzPN-0002Yh-Ed for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:47:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e40817d-e0cf-11ec-837f-e5687231ffcc; Tue, 31 May 2022 12:47:28 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653994041443155.03033999045203; Tue, 31 May 2022 03:47:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e40817d-e0cf-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653994042; cv=none; d=zohomail.com; s=zohoarc; b=INq2fM7GewiNjQuC5y5cwtvzv+bz9MosgVRkUp/ExScKFhhSimSSIQRJLHHHF/sSP1Yd0fTrdO0wlL6FfWmA40wH/Ju4EJU4/UYDikbyxpZIjOz3OwSWlh3wqJgEdBAwZbiLubLb7QqkUvy9mu8royy/1N7jq1QvSnal7urRGI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653994042; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3sdYTeR7TY3vKJj6+W2HbHp6SQVoGgEhQXZr7L1Q75w=; b=QVPAXOFcROLixvlFp70FkBs2Y9XQvXtuDK4fRyZGcoCy2xiLd1ovcjznos2Wuzym0KlM3SpFHZs8KFmVAga7IPljUgkLAi/h5UMH0Jy1vJHo8VsrIC30onueM1k60NeZJBKdUQgrJM4IY2z04+cvUu6lvwNYIo/yuJ2PsCDm+Kk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653994042; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3sdYTeR7TY3vKJj6+W2HbHp6SQVoGgEhQXZr7L1Q75w=; b=SFkr7mdY9duxEeK7QZglXJOZfPGZtdWZ8kA3Kik7rNoZYI5r02NEpQNckMgSqflT 3LSc9KFD7VmKWcaws0qwYh/Isg1RDtCrbGqWTNy6jjyyMF76UVKpVIPm810tv7Eh8l7 tN56+ehmoWWjj4pz3JPQSv3xGqhWJlVMiF3iVo+Q= Message-ID: <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> Date: Tue, 31 May 2022 06:45:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Content-Language: en-US To: Bertrand Marquis Cc: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> From: "Daniel P. Smith" In-Reply-To: <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 05:07, Bertrand Marquis wrote: > Hi Daniel, Greetings Bertrand. >> On 31 May 2022, at 03:41, Daniel P. Smith wrote: >> >> For x86 the number of allowable multiboot modules varies between the different >> entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and >> x86 this value is fixed to values based on generalized assumptions. With >> hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large >> allocations compiled into the hypervisor that will go unused by many use cases. >> >> This commit introduces a Kconfig variable that is set with sane defaults based >> on configuration selection. This variable is in turned used as the array size >> for the cases where a static allocated array of boot modules is declared. >> >> Signed-off-by: Daniel P. Smith >> --- >> xen/arch/Kconfig | 12 ++++++++++++ >> xen/arch/arm/include/asm/setup.h | 5 +++-- >> xen/arch/x86/efi/efi-boot.h | 2 +- >> xen/arch/x86/guest/xen/pvh-boot.c | 2 +- >> xen/arch/x86/setup.c | 4 ++-- >> 5 files changed, 19 insertions(+), 6 deletions(-) >> >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >> index f16eb0df43..57b14e22c9 100644 >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -17,3 +17,15 @@ config NR_CPUS >> For CPU cores which support Simultaneous Multi-Threading or similar >> technologies, this the number of logical threads which Xen will >> support. >> + >> +config NR_BOOTMODS >> + int "Maximum number of boot modules that a loader can pass" >> + range 1 64 >> + default "8" if X86 >> + default "32" if ARM >> + help >> + Controls the build-time size of various arrays allocated for >> + parsing the boot modules passed by a loader when starting Xen. >> + >> + This is of particular interest when using Xen's hypervisor domain >> + capabilities such as dom0less. >> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >> index 2bb01ecfa8..312a3e4209 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -10,7 +10,8 @@ >> >> #define NR_MEM_BANKS 256 >> >> -#define MAX_MODULES 32 /* Current maximum useful modules */ >> +/* Current maximum useful modules */ >> +#define MAX_MODULES CONFIG_NR_BOOTMODS >> >> typedef enum { >> BOOTMOD_XEN, >> @@ -38,7 +39,7 @@ struct meminfo { >> * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. >> * The purpose of the domU flag is to avoid getting confused in >> * kernel_probe, where we try to guess which is the dom0 kernel and >> - * initrd to be compatible with all versions of the multiboot spec. >> + * initrd to be compatible with all versions of the multiboot spec. > > This seems to be a spurious change. I have been trying to clean up trailing white space when I see it nearby. I can drop this one if that is desired. > With that fixed, for the arm part: > Reviewed-by: Bertrand Marquis Thank you, will add it in when I respin it for submission. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 10:48:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:48:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339469.564354 (Exim 4.92) (envelope-from ) id 1nvzQA-00037v-Tt; Tue, 31 May 2022 10:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339469.564354; Tue, 31 May 2022 10:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzQA-00037o-R1; Tue, 31 May 2022 10:48:18 +0000 Received: by outflank-mailman (input) for mailman id 339469; Tue, 31 May 2022 10:48:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzQ9-00036o-FV; Tue, 31 May 2022 10:48:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzQ9-0001QA-BP; Tue, 31 May 2022 10:48:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzQ8-0004pj-MG; Tue, 31 May 2022 10:48:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nvzQ8-0002F0-Lq; Tue, 31 May 2022 10:48:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w05x/o6ybx/yShR8iCO79svQwDFfcpeZvh0VyP2raDE=; b=dryaplMm0M6DRPvl13hq7ytgw+ mmRSWY5BZOiXd9hu8tDNnVogPmxUBwhWEavK2uHy7vpGhRzzHyJPvOLYSAAxJZhRvLYBlPznfXUPo QDHpHsbMnoHA8y8go+8fNvmSyeno85Q4jlMerXTldNF9iP/JWgg5GnZObT4R1zc0uS88=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 170784: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b4161c2d426d628913c1122de17c78b62133349a X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 31 May 2022 10:48:16 +0000 flight 170784 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170784/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b4161c2d426d628913c1122de17c78b62133349a baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 690 days Failing since 151818 2020-07-11 04:18:52 Z 689 days 671 attempts Testing same since 170784 2022-05-31 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 110152 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 31 10:50:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339481.564365 (Exim 4.92) (envelope-from ) id 1nvzRy-0004a6-Gu; Tue, 31 May 2022 10:50:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339481.564365; Tue, 31 May 2022 10:50:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzRy-0004Zz-CK; Tue, 31 May 2022 10:50:10 +0000 Received: by outflank-mailman (input) for mailman id 339481; Tue, 31 May 2022 10:50:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzRw-0004VS-J5 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:50:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0e::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f4ec877-e0cf-11ec-837f-e5687231ffcc; Tue, 31 May 2022 12:50:07 +0200 (CEST) Received: from AS9PR06CA0731.eurprd06.prod.outlook.com (2603:10a6:20b:487::22) by DB9PR08MB6683.eurprd08.prod.outlook.com (2603:10a6:10:2ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 10:50:00 +0000 Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::a9) by AS9PR06CA0731.outlook.office365.com (2603:10a6:20b:487::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 10:50:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 10:50:00 +0000 Received: ("Tessian outbound 5b5a41c043d3:v120"); Tue, 31 May 2022 10:50:00 +0000 Received: from 20d5c47f2dca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8734D44D-3D5B-4359-8B74-9283B0935C27.1; Tue, 31 May 2022 10:49:53 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 20d5c47f2dca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 10:49:53 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5084.eurprd08.prod.outlook.com (2603:10a6:10:38::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 10:49:50 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 10:49:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f4ec877-e0cf-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BTudENzgMkGr7XzVJb1Nlr8whRx4YaLDEUp9wxcx8rAp8m9z/rFejhTybr8+SYiEVutKdSLYRk8kC05d80OPW/LQFF6JXTou2pZLSfJj2xymhd1NQqhVwCBcfhAMqpHIUW5lqSC1AWaacrd+JvWsS273X26V3iOyWVi2sD/GS9Gt8F8MTNYqDpCNh1Jw7KTytpMEfKe15Whd3ZhQuaq+8SCTOoAytnXQxvNNjLeyNDFE0n45SZ/iDJ8qZc7WTnku/XbZQxhtqOocxP6zCXUmHIObH5ktV6D01bN7RBwc4epsriXbPxtTstdPKka4mvgSVN/m1NkudHo8NkJe/G6FmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nt0BiWc4Qk2mUTO+wWjDgSo14elBfR7b1c5gfQnBeyE=; b=TerzhIz934b0JxjlS14QUoX8ocZw2kM7YVdHjLS/ziut8PliHimVa2M8LE+1c7MdLtrE2mscfsMXTU9VTBpS19RZru3LAsjtP7XjkXiyefB8F0ri2cGUovSik3b29wt/QPFMqKkwPbRFYSqPg+A8DjPGMZe3lThKqm2He7Rp6WnxFlROhm2jLfyQ8JkuECy6c2Z0B8Rtlkh8GhX5/1VwF5DvCm9EhNgLjNb493/tMJ+3Ye4rB4cItljJEaYLRj43rMrCoXEEzE6jcfzI2ilsytuwMXNCKMERAfcAgNYKO6B/zP5zJ/dl+rUAnC7tw5U0Y2DTSls6Gtv06lmOs+JQAA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nt0BiWc4Qk2mUTO+wWjDgSo14elBfR7b1c5gfQnBeyE=; b=AzqUwIlE8e5WrvZ4sDi/2MS966sbEQ2kyuslCX2T6S674x0tFkVOFzN5ZWIAUWqOazX5R0c5gF+D7bKjiCjDe4KHGfdRkBAatoqUFhDApmmTlCGXpOJ+m6VjTzJD+aVaAJhdn7FbWd8NDNGzWw/R3m63LyZQuZU52unrMZRQ1t8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e2cdd268ca7404be X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q4KTmD0nfI5E2ZBAL/OS6tCqqUhxyyfUcjZQJ8WJM87Duff+XHEEpACoJnZlJ3jL9Yn015/qcMfhRvG2VgTNFqTf6simQ4q+aW/6ASCQD0/01zxGf1+cHL0SjxZModG3hzx2oQGRJxoRPW8Rjjhz6C/jBvS+E4Hrt/aCrsd1WEI9AV501TSuknHHN49t6sq+w0i1b/FCyX5cSG3xfZxXS0y3SaUMUizZ9xfFrtttyu7S9v3o2a7dNF2IdLqld/bRmDTBCWGXeFJfxs4TYhGIEQQ+C7zP95aTdIe6bfvTUX+iX9K81pnlgnAeHSiNcsbrMC4NtPXz6GzVkhSnlDs2dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nt0BiWc4Qk2mUTO+wWjDgSo14elBfR7b1c5gfQnBeyE=; b=CLwZm2OgBW7xoGef82yBsZoqN/rZPQPXKAk0Q6udXfY1WAqYIRccsbRjsZHkduG/BN7FKFKoooHMoF6SCXQN/H6Kk/0AvANB9W7COMMkB2prCA44iDOoOxZHOaRyUO/xh+L9tV3AdFaVU7vh15EgUFMKH5lyrIyEpTIkuvZQdcdd/XDIK1pjdWDZvAKFQO2l0WHeVsmJLJxPj70aSBCq2Ugq1+6ky/g3q8c1+DmbX6ao811hyFs7bqr0VPEspoINTMXGfepKiXmUNIb3aZTOTtbblqrW+szejE6UOYZayEjDaB5OS016eWVHwL4s0UBUoEr9/RbDSbW3rL4sl3aEZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nt0BiWc4Qk2mUTO+wWjDgSo14elBfR7b1c5gfQnBeyE=; b=AzqUwIlE8e5WrvZ4sDi/2MS966sbEQ2kyuslCX2T6S674x0tFkVOFzN5ZWIAUWqOazX5R0c5gF+D7bKjiCjDe4KHGfdRkBAatoqUFhDApmmTlCGXpOJ+m6VjTzJD+aVaAJhdn7FbWd8NDNGzWw/R3m63LyZQuZU52unrMZRQ1t8= From: Bertrand Marquis To: "Daniel P. Smith" CC: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Thread-Topic: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Thread-Index: AQHYdHaP7qNDYyBbfkiCxkS8602Jcq04suAAgAAbZACAAAEcAA== Date: Tue, 31 May 2022 10:49:50 +0000 Message-ID: <674E45E3-0B50-4098-9B15-B51EEEC54534@arm.com> References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> In-Reply-To: <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0df3cf04-47ae-4388-7360-08da42f34f48 x-ms-traffictypediagnostic: DB8PR08MB5084:EE_|AM5EUR03FT037:EE_|DB9PR08MB6683:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oD/nh9VdAEIvJD2v6Vx2PbtZsvA5d4hZiwgfCbbomXegArw8FpZ/ELAiunqhdhK8SlkAVH3PM9Hcha9SHP/pWJgFZMqjZm3Wf4LwcYKYX8vg/WWEPNON7Yp2KfgGjC7akHgUkEuHAJGm2CssZdIBpuuCGzdcBo6y6jSFgWP0dnRd98Kkq7xLY170WMl0xiPc6ovHGTRIyj00yQPEh6Qj88+br/Zkm3LPrIeOy7yUG07XH3OM+ezrEMHVq+3bwGbz77wG5SGEOyAZ/hVyQUh1Y1Zp7ZDCQAd32muXial9mOWkyM7YV3n1flIzZA/MnhjOaJyWZVrU4AeCXZgeOR9DlBoBIvIOYKese1O+kNdKmmkfRtk29Da4kiSs2o8oHL9GenAjpKepqPHBXniXUG0JGXtufI1pTsd8nxdU3Rk2U6kd3NQwu6IKqy3hYTyV0k5J7J7159IuV3CsMghjK8bEXtvrdzMP8GyTfVASE+qVvXtNa62e+aWsJz9lcoToyUtuXEMMlzutZc1TOQaJX96y098CMCqXHu/HbQK/zNWri7JAxkD3S+rsuqOJDZgkrJf6lRuhYdr3DjQjP8ILFsrG01lFRMWPvXF4xqTQJGYX4OnlB48Mxo8EKkAVmylP1DEQciv9gqB+5ycjCzKLsdphKVZiJ4+gGx84YQEw4wDixnor+0V0w1EMyXQ4/s0pnFJZuCsG5B+wsbzHsGL7W8EfnP1gH9un9i87uWoZ251D19qTuJvUC9VsdHNM6KtL0OJ0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(508600001)(5660300002)(64756008)(66446008)(66476007)(66556008)(4326008)(8676002)(33656002)(76116006)(91956017)(71200400001)(7416002)(186003)(38070700005)(66946007)(86362001)(8936002)(26005)(6512007)(38100700002)(122000001)(2616005)(53546011)(6506007)(2906002)(6916009)(54906003)(36756003)(316002)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5084 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a9674703-42ab-4b12-e6a3-08da42f349c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Os5OHsB8793hLPdz+OTp67aaSo1k5Ea605TCwLhzhXV0mzhXmr7SX7okQ/hs+GP4SzhStJ0K7fTHFb0gOOwgQ1SuR5moaG7NbDchQK2xzVLClk4BhplefMsBBNXLCKCuyR6wCamHpoihDVwX1H3U3RChghdQavL3KwxuOEsoIvlOhe9QVLN0F3FIFBqkBhq3qAwVsuhuumkGPn7ahHa57jdtES3Ha/IjUe+Zo2pnGjwDQGkArq8vxucpjzWhm7BUEucU9A3h6MePra14zJR+XSBUmTEo140sw49euHbQkrLNDupz3Nd+tg+I7c/fwy5mC1BLufvR/23qrERqGgtgdKu5JlLCJdscxNkhC5RlBgP2Fl4ssb74Y4d2OGg4t9zmpmwVXjfrRQRZYxU782zOTWZWvV6g5wjXGm+33oeAFpZ+agAA8uoeK8CPCHSlgFgw8vQe3RuDk+zZwRFk4Sn5jka0FwdGoIuqiQCZffu7mzdNOHuQtlymTjGOC8FaI1KvBwysGfq+rIqYRwlAIt2o9ebN6W68fthWRENmUdx2IaAkkjVgFDyip7aK0aAB9gPSYYwN/IUQ37UN8WUI9gvV2zrBBqV/VtitRtqhGvGmTyM9uy9k0cUYHskSJBgsrJ95JdnBx/goCargmeZ5vgYc081+ExR555cE/p/thlW1mIUO84OCtMmjVXkhvLgXukoB X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6506007)(40460700003)(5660300002)(83380400001)(81166007)(2906002)(47076005)(33656002)(336012)(8936002)(508600001)(86362001)(186003)(356005)(36860700001)(54906003)(2616005)(82310400005)(316002)(107886003)(53546011)(8676002)(6862004)(70586007)(70206006)(4326008)(36756003)(26005)(6512007)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 10:50:00.0355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0df3cf04-47ae-4388-7360-08da42f34f48 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6683 Hi Daniel, > On 31 May 2022, at 11:45, Daniel P. Smith = wrote: >=20 > On 5/31/22 05:07, Bertrand Marquis wrote: >> Hi Daniel, >=20 > Greetings Bertrand. >=20 >>> On 31 May 2022, at 03:41, Daniel P. Smith wrote: >>>=20 >>> For x86 the number of allowable multiboot modules varies between the di= fferent >>> entry points, non-efi boot, pvh boot, and efi boot. In the case of both= Arm and >>> x86 this value is fixed to values based on generalized assumptions. Wit= h >>> hyperlaunch for x86 and dom0less on Arm, use of static sizes results in= large >>> allocations compiled into the hypervisor that will go unused by many us= e cases. >>>=20 >>> This commit introduces a Kconfig variable that is set with sane default= s based >>> on configuration selection. This variable is in turned used as the arra= y size >>> for the cases where a static allocated array of boot modules is declare= d. >>>=20 >>> Signed-off-by: Daniel P. Smith >>> --- >>> xen/arch/Kconfig | 12 ++++++++++++ >>> xen/arch/arm/include/asm/setup.h | 5 +++-- >>> xen/arch/x86/efi/efi-boot.h | 2 +- >>> xen/arch/x86/guest/xen/pvh-boot.c | 2 +- >>> xen/arch/x86/setup.c | 4 ++-- >>> 5 files changed, 19 insertions(+), 6 deletions(-) >>>=20 >>> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >>> index f16eb0df43..57b14e22c9 100644 >>> --- a/xen/arch/Kconfig >>> +++ b/xen/arch/Kconfig >>> @@ -17,3 +17,15 @@ config NR_CPUS >>> For CPU cores which support Simultaneous Multi-Threading or similar >>> technologies, this the number of logical threads which Xen will >>> support. >>> + >>> +config NR_BOOTMODS >>> + int "Maximum number of boot modules that a loader can pass" >>> + range 1 64 >>> + default "8" if X86 >>> + default "32" if ARM >>> + help >>> + Controls the build-time size of various arrays allocated for >>> + parsing the boot modules passed by a loader when starting Xen. >>> + >>> + This is of particular interest when using Xen's hypervisor domain >>> + capabilities such as dom0less. >>> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/as= m/setup.h >>> index 2bb01ecfa8..312a3e4209 100644 >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -10,7 +10,8 @@ >>>=20 >>> #define NR_MEM_BANKS 256 >>>=20 >>> -#define MAX_MODULES 32 /* Current maximum useful modules */ >>> +/* Current maximum useful modules */ >>> +#define MAX_MODULES CONFIG_NR_BOOTMODS >>>=20 >>> typedef enum { >>> BOOTMOD_XEN, >>> @@ -38,7 +39,7 @@ struct meminfo { >>> * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. >>> * The purpose of the domU flag is to avoid getting confused in >>> * kernel_probe, where we try to guess which is the dom0 kernel and >>> - * initrd to be compatible with all versions of the multiboot spec.=20 >>> + * initrd to be compatible with all versions of the multiboot spec. >>=20 >> This seems to be a spurious change. >=20 > I have been trying to clean up trailing white space when I see it > nearby. I can drop this one if that is desired. If this is wanted this is ok, just mention it in the commit message so that= we know it was on purpose. >=20 >> With that fixed, for the arm part: >> Reviewed-by: Bertrand Marquis >=20 > Thank you, will add it in when I respin it for submission. Cheers Bertrand >=20 > v/r, > dps From xen-devel-bounces@lists.xenproject.org Tue May 31 10:55:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:55:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339516.564376 (Exim 4.92) (envelope-from ) id 1nvzXA-0005Ob-3t; Tue, 31 May 2022 10:55:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339516.564376; Tue, 31 May 2022 10:55:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzXA-0005O3-0u; Tue, 31 May 2022 10:55:32 +0000 Received: by outflank-mailman (input) for mailman id 339516; Tue, 31 May 2022 10:55:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzX8-0005Nx-Oy for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:55:30 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e7d0d70-e0d0-11ec-837f-e5687231ffcc; Tue, 31 May 2022 12:55:29 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653994524615896.5098825753747; Tue, 31 May 2022 03:55:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e7d0d70-e0d0-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653994526; cv=none; d=zohomail.com; s=zohoarc; b=Q5hYiaNQ+seHpdqU9T8mf6eg3pXyLU0qo/XN5Oz3QhbhKDbOCceLTOXjNBlgTo+/yh7E0ZhYBfxlRMIcbX+p0At3BFVHu/XFQTCoMpMHsiNmjSGHnZFEbV1kGWlL1chccO9fCr6C/U5cvk/u+5iql/4YfPX8Cf5Omh4gygy3M2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653994526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=aPB5Bo/TIfYepxMvaIZKO/gBg5lzxObijRmyeLGPZZA=; b=gWtaM8NMzp/X7ea5kTSQJpRf46wq3XD0CxGgIH0C/ILoJ8R+PCG1s2s9iYJuOLFiMPjFtohiL+p6FDUVUA3Fby5RDE0k2YEHuX361N+m7eGsXQLx3QS9ZhfyJk9bjEDaVcxk7slFmU5F2jdtJGtDQAZ2FOroeU5Eqz8Ktj2PQJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653994526; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=aPB5Bo/TIfYepxMvaIZKO/gBg5lzxObijRmyeLGPZZA=; b=HOOl6DtiX6zWL3DAT0L5gNLV4PkTmfnl6tHpZWMlR4SZEqF8dmZZTK8LygqeN3LW psQvr0eHJqfu7Eay/g9ql7EHbg/JTEgvuQI4ZQDe5A+mQjOYMHgHKLviTcVuUCTtNxp ZP81N191IRzixEc0YXC/3ck3kLM7lpHKLPKxQAH8= Message-ID: Date: Tue, 31 May 2022 06:53:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, sstabellini@kernel.org, Andrew Cooper , George Dunlap , Jan Beulich , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/31/22 05:25, Julien Grall wrote: > Hi, > > On 31/05/2022 03:41, Daniel P. Smith wrote: >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >> index f16eb0df43..57b14e22c9 100644 >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -17,3 +17,15 @@ config NR_CPUS >>         For CPU cores which support Simultaneous Multi-Threading or >> similar >>         technologies, this the number of logical threads which Xen will >>         support. >> + >> +config NR_BOOTMODS >> +    int "Maximum number of boot modules that a loader can pass" >> +    range 1 64 > > OOI, any reason to limit the size? I modelled this entirely after NR_CPUS, which applied a limit, and it seemed reasonable to me at the time. I choose 64 since it was double currently what Arm had set for MAX_MODULES. As such, I have no hard reason for there to be a limit. It can easily be removed or adjusted to whatever the reviewers feel would be appropriate. >> +    default "8" if X86 >> +    default "32" if ARM >> +    help >> +      Controls the build-time size of various arrays allocated for >> +      parsing the boot modules passed by a loader when starting Xen. >> + >> +      This is of particular interest when using Xen's hypervisor domain >> +      capabilities such as dom0less. >> diff --git a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >> index 2bb01ecfa8..312a3e4209 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -10,7 +10,8 @@ >>     #define NR_MEM_BANKS 256 >>   -#define MAX_MODULES 32 /* Current maximum useful modules */ >> +/* Current maximum useful modules */ >> +#define MAX_MODULES CONFIG_NR_BOOTMODS > > There are only a handful number of use of MAX_MODULES in Arm. So I would > prefer if we replace all the use with CONFIG_NR_BOOTMODS. No problem, as I stated above, I mimicked what was done for NR_CPUS which did a similar #define for MAX_CPUS. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 10:57:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 10:57:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339525.564386 (Exim 4.92) (envelope-from ) id 1nvzZI-0005yR-GM; Tue, 31 May 2022 10:57:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339525.564386; Tue, 31 May 2022 10:57:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzZI-0005yK-Db; Tue, 31 May 2022 10:57:44 +0000 Received: by outflank-mailman (input) for mailman id 339525; Tue, 31 May 2022 10:57:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzZG-0005yC-Sl for xen-devel@lists.xenproject.org; Tue, 31 May 2022 10:57:42 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d25f850-e0d0-11ec-837f-e5687231ffcc; Tue, 31 May 2022 12:57:41 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653994655582538.6852066276887; Tue, 31 May 2022 03:57:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d25f850-e0d0-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1653994657; cv=none; d=zohomail.com; s=zohoarc; b=LRojUMfkMO+UsYj0YYtnNX8XELtlFTK5wI21ZV3qIS0udfWNos/QJGMB5MGZREkmphzkQneEi4rBndI1YKcvkGWKAiYGwlB3SGDJQ7Y0gpy8HsT3FkAIJov+CQG5Nl1aoTPpB47Ez7nGNO4trGeDlJQfa9rOkTUOglTmIp0sVWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653994657; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0/Nwvt0WlVLbNtmWgUYZVBw3bPmqHqhHp8vPjk6fsVA=; b=CT3fEDVORE09ccWXrSFJhwgHZwjyWaMFWbCuIVC/6VmZ2fuUXC5TAwH/vM4dtZcFXY8+HrVETSs3lk+RrBfytINlEFmhTC8NAXf/+KdI/63V9MI0eFwOFBYEhEJ9aLQjf+sGz9TyTYVghtk7twA8qSjhLdPxjmhgV1vtqa5KhPQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653994657; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=0/Nwvt0WlVLbNtmWgUYZVBw3bPmqHqhHp8vPjk6fsVA=; b=sWdAB0tWTE9jn+CoV1TJGy9KqBasVRyrGlQ2BOQCDzzi4XP/waB3wQKAzugMpM8e iL14TcVikOsBkCaDgwZTfdg+TGa5pldy5UAB5I4bma8H3EeZ6r8I0zu1rppYZGdI3nk 2Q6eK9NKwFUj3OQwwW818Sa1V+YSfTAs3oZTSNt0= Message-ID: Date: Tue, 31 May 2022 06:56:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Content-Language: en-US To: Bertrand Marquis Cc: xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> <674E45E3-0B50-4098-9B15-B51EEEC54534@arm.com> From: "Daniel P. Smith" In-Reply-To: <674E45E3-0B50-4098-9B15-B51EEEC54534@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 06:49, Bertrand Marquis wrote: > Hi Daniel, > >> On 31 May 2022, at 11:45, Daniel P. Smith wrote: >> >> On 5/31/22 05:07, Bertrand Marquis wrote: >>> Hi Daniel, >> >> Greetings Bertrand. >> >>>> On 31 May 2022, at 03:41, Daniel P. Smith wrote: >>>> >>>> For x86 the number of allowable multiboot modules varies between the different >>>> entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and >>>> x86 this value is fixed to values based on generalized assumptions. With >>>> hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large >>>> allocations compiled into the hypervisor that will go unused by many use cases. >>>> >>>> This commit introduces a Kconfig variable that is set with sane defaults based >>>> on configuration selection. This variable is in turned used as the array size >>>> for the cases where a static allocated array of boot modules is declared. >>>> >>>> Signed-off-by: Daniel P. Smith >>>> --- >>>> xen/arch/Kconfig | 12 ++++++++++++ >>>> xen/arch/arm/include/asm/setup.h | 5 +++-- >>>> xen/arch/x86/efi/efi-boot.h | 2 +- >>>> xen/arch/x86/guest/xen/pvh-boot.c | 2 +- >>>> xen/arch/x86/setup.c | 4 ++-- >>>> 5 files changed, 19 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >>>> index f16eb0df43..57b14e22c9 100644 >>>> --- a/xen/arch/Kconfig >>>> +++ b/xen/arch/Kconfig >>>> @@ -17,3 +17,15 @@ config NR_CPUS >>>> For CPU cores which support Simultaneous Multi-Threading or similar >>>> technologies, this the number of logical threads which Xen will >>>> support. >>>> + >>>> +config NR_BOOTMODS >>>> + int "Maximum number of boot modules that a loader can pass" >>>> + range 1 64 >>>> + default "8" if X86 >>>> + default "32" if ARM >>>> + help >>>> + Controls the build-time size of various arrays allocated for >>>> + parsing the boot modules passed by a loader when starting Xen. >>>> + >>>> + This is of particular interest when using Xen's hypervisor domain >>>> + capabilities such as dom0less. >>>> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >>>> index 2bb01ecfa8..312a3e4209 100644 >>>> --- a/xen/arch/arm/include/asm/setup.h >>>> +++ b/xen/arch/arm/include/asm/setup.h >>>> @@ -10,7 +10,8 @@ >>>> >>>> #define NR_MEM_BANKS 256 >>>> >>>> -#define MAX_MODULES 32 /* Current maximum useful modules */ >>>> +/* Current maximum useful modules */ >>>> +#define MAX_MODULES CONFIG_NR_BOOTMODS >>>> >>>> typedef enum { >>>> BOOTMOD_XEN, >>>> @@ -38,7 +39,7 @@ struct meminfo { >>>> * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. >>>> * The purpose of the domU flag is to avoid getting confused in >>>> * kernel_probe, where we try to guess which is the dom0 kernel and >>>> - * initrd to be compatible with all versions of the multiboot spec. >>>> + * initrd to be compatible with all versions of the multiboot spec. >>> >>> This seems to be a spurious change. >> >> I have been trying to clean up trailing white space when I see it >> nearby. I can drop this one if that is desired. > > If this is wanted this is ok, just mention it in the commit message so that we know it was on purpose. Understood, I will update the commit message on this one and the others where there is done. >> >>> With that fixed, for the arm part: >>> Reviewed-by: Bertrand Marquis >> >> Thank you, will add it in when I respin it for submission. > > Cheers > Bertrand > >> >> v/r, >> dps > v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 11:16:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 11:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339535.564401 (Exim 4.92) (envelope-from ) id 1nvzrA-0000CF-7O; Tue, 31 May 2022 11:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339535.564401; Tue, 31 May 2022 11:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzrA-0000C8-4D; Tue, 31 May 2022 11:16:12 +0000 Received: by outflank-mailman (input) for mailman id 339535; Tue, 31 May 2022 11:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzr8-0000C2-Bq for xen-devel@lists.xenproject.org; Tue, 31 May 2022 11:16:10 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10a91562-e0d3-11ec-837f-e5687231ffcc; Tue, 31 May 2022 13:16:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10a91562-e0d3-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1653995768; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZdOpUvFK8lDyOMY93Nxgv6haNdCdSCdZwnYbBpkxaCc=; b=UBNwHOjvpZOYXz24d27PTfN4zqQ+Dokt9bLQ8c1co3VXT/8lK+u+ARC1 Q1L7PCUkGlsqVG3Uyv3CmmrO69lFJezCSyGYGJVvQD+Nwp5RaXnmhr86w KJ4/XDRN0kfdu/bI6hSoqkvnSa9l9T4UXXTsWE80Uv/wABA3sxaC6tIB0 c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72518022 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mRTXVKDIRjVXnhVW/1jjw5YqxClBgxIJ4kV8jS/XYbTApG4j0j0Hy jRNC22GOa2KY2v0c9AiOYvl8UoP75/WzYJiQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ni29Yy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh7y /JXtYeoGTs0M6Ps38MkDUhjMBhxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8UQK+OP 5BDAdZpRD/tUk10PUYnMooRxeqG2GunVAJ2ol3A8MLb5ECMlVcsgdABKuH9f9WWRMxO2FiRv Gvu4W3lDwpcOsb34SWB2mKhgKnIhyyTcIcbCLyx7fN0iUea7mMWARwSE1C8pJGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMVjtlvLkPCNpV/EWC5UFVatdeDKquc8Rhsw1 kSRz+/0CDJP95qsFyOm1Y6b+Gba1TcuEYMSWcMVZVJbvoK9+dxu0EKnosVLS/Ds0ICscd3k6 3XT9XVl2e1O5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg JTns5LHhAz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4Nu2AleRk3bJ1cKFcFh XM/XisIv/du0IaCN/crM+pd9ex2pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFySARfVUEE c7DK66EVC9CYYw+lWbeb7pMitcDm3FhrV4/sLimlnxLJ5LFPC7LIVrEWXPTBt0EAFSs+16Nq owDbJfQln2ykoTWO0HqzGLaFnhSRVBTOHw8g5A/mjKrSua+JFwcNg== IronPort-HdrOrdr: A9a23:e9CFgqDfedu5SRDlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72518022" Date: Tue, 31 May 2022 12:16:02 +0100 From: Anthony PERARD To: Matias Ezequiel Vara Larsen CC: , Matias Ezequiel Vara Larsen , Wei Liu Subject: Re: [RFC PATCH 2/2] tools/misc: Add xen-stats tool Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Hi Matias, On Tue, May 17, 2022 at 04:33:15PM +0200, Matias Ezequiel Vara Larsen wrote: > Add a demostration tool that uses the stats_table resource to > query vcpu time for a DomU. > > Signed-off-by: Matias Ezequiel Vara Larsen > --- > diff --git a/tools/misc/Makefile b/tools/misc/Makefile > index 2b683819d4..b510e3aceb 100644 > --- a/tools/misc/Makefile > +++ b/tools/misc/Makefile > @@ -135,4 +135,9 @@ xencov: xencov.o > xen-ucode: xen-ucode.o > $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS) > > +xen-stats.o: CFLAGS += $(CFLAGS_libxenforeginmemory) > + > +xen-stats: xen-stats.o The tools seems to be only about vcpu, maybe `xen-stats` is a bit too generic. Would `xen-vcpus-stats`, or maybe something with `time` would be better? Also, is it a tools that could be useful enough to be installed by default? Should we at least build it by default so it doesn't rot? (By adding it to only $(TARGETS).) > + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) > + > -include $(DEPS_INCLUDE) > diff --git a/tools/misc/xen-stats.c b/tools/misc/xen-stats.c > new file mode 100644 > index 0000000000..5d4a3239cc > --- /dev/null > +++ b/tools/misc/xen-stats.c > @@ -0,0 +1,83 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include It seems overkill to use this header when the tool only use xenforeignmemory interface. But I don't know how to replace XC_PAGE_SHIFT, so I guess that's ok. > +#include > +#include What do you use this headers for? Is it left over? > +static sig_atomic_t interrupted; > +static void close_handler(int signum) > +{ > + interrupted = 1; > +} > + > +int main(int argc, char **argv) > +{ > + xenforeignmemory_handle *fh; > + xenforeignmemory_resource_handle *res; > + size_t size; > + int rc, nr_frames, domid, frec, vcpu; > + uint64_t * info; > + struct sigaction act; > + > + if (argc != 4 ) { > + fprintf(stderr, "Usage: %s \n", argv[0]); > + return 1; > + } > + > + // TODO: this depends on the resource > + nr_frames = 1; > + > + domid = atoi(argv[1]); > + frec = atoi(argv[3]); > + vcpu = atoi(argv[2]); Can you swap the last two line? I think it is better if the order is the same as on the command line. > + > + act.sa_handler = close_handler; > + act.sa_flags = 0; > + sigemptyset(&act.sa_mask); > + sigaction(SIGHUP, &act, NULL); > + sigaction(SIGTERM, &act, NULL); > + sigaction(SIGINT, &act, NULL); > + sigaction(SIGALRM, &act, NULL); > + > + fh = xenforeignmemory_open(NULL, 0); > + > + if ( !fh ) > + err(1, "xenforeignmemory_open"); > + > + rc = xenforeignmemory_resource_size( > + fh, domid, XENMEM_resource_stats_table, > + vcpu, &size); > + > + if ( rc ) > + err(1, " Fail: Get size: %d - %s\n", errno, strerror(errno)); It seems that err() already does print strerror(), and add a "\n", so why print it again? Also, if we have strerror(), what the point of printing "errno"? Also, I'm not sure the extra indentation in the error message is really useful, but that doesn't really matter. > + > + if ( (size >> XC_PAGE_SHIFT) != nr_frames ) > + err(1, " Fail: Get size: expected %u frames, got %zu\n", > + nr_frames, size >> XC_PAGE_SHIFT); err() prints strerror(errno), maybe errx() is better here. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 31 11:17:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 11:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339543.564412 (Exim 4.92) (envelope-from ) id 1nvzsq-0000ly-Jk; Tue, 31 May 2022 11:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339543.564412; Tue, 31 May 2022 11:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzsq-0000lr-GR; Tue, 31 May 2022 11:17:56 +0000 Received: by outflank-mailman (input) for mailman id 339543; Tue, 31 May 2022 11:17:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nvzso-0000le-N0 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 11:17:54 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f7d9116-e0d3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 13:17:53 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1653995865650167.2590047952341; Tue, 31 May 2022 04:17:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f7d9116-e0d3-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1653995867; cv=none; d=zohomail.com; s=zohoarc; b=R2utZavWzXD2nx8Avk5EoZTaNcgUyoTU+BYbzsdtHChvZvpP9r0dx+CixTNXnJLK7+tE7DZHP/li9edKf0pV/HD5uu8KyV8HHuksnACpKPq/QXQSEXoxBhNeFo0Nj9shy95PO6JCFN/rm3Q7Sc6blusrh5UhxOAhWEAWwsQugKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653995867; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Z9I7HnQLALuF6Cupxgl8g/hDsQchtrid4tZPgFOIJR4=; b=N2xj1XHYOFYz6Qkwo7IvBpgDHqtMZG82a+khclIaJAl3n/kEeblFpAQEhXtlezJn216NNuMAH/53pcQQ3RAxqwhgWQOmKIX9BZyDSZKCs4H7mudR19j7orvohCayMCZze+XPLwNbVWJWid3bVxcqjZB2XF89QewdaZlkZExl+rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653995867; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Z9I7HnQLALuF6Cupxgl8g/hDsQchtrid4tZPgFOIJR4=; b=B92kXVqzxUriD0GGzN08JfwCrKs6F9EjIyd8f2qwik93PyrSvSE4krCLmpT1MfGK VvXa4vE8xymk3dTTGFsMkmmINnMmD4Sxqydw7Mfx0AAEUAtBU2Z0iE+Ht51U0BbluSW +6Jvov+IxKHb/SzyYFbfF7OUW9xR9uqgP9vmtru8= Message-ID: Date: Tue, 31 May 2022 07:16:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , George Dunlap , Dario Faggioli , Daniel De Graaf References: <20220511113035.27070-1-dpsmith@apertussolutions.com> <20220511113035.27070-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v7 1/2] xsm: create idle domain privileged and demote after setup In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/31/22 03:56, Roger Pau Monné wrote: > On Wed, May 11, 2022 at 07:30:34AM -0400, Daniel P. Smith wrote: >> There are new capabilities, dom0less and hyperlaunch, that introduce internal >> hypervisor logic which needs to make resource allocation calls that are >> protected by XSM access checks. This creates an issue as a subset of the >> hypervisor code is executed under a system domain, the idle domain, that is >> represented by a per-CPU non-privileged struct domain. > > Should you mention that this subset of hypervisor code that requires > extended privileges but executed in the idle vCPU context strictly > only happens during initial domain(s) creation? Sure, I will work in some wording to clarify that point. >> To enable these new >> capabilities to function correctly but in a controlled manner, this commit >> changes the idle system domain to be created as a privileged domain under the >> default policy and demoted before transitioning to running. A new XSM hook, >> xsm_set_system_active(), is introduced to allow each XSM policy type to demote >> the idle domain appropriately for that policy type. In the case of SILO, it >> inherits the default policy's hook for xsm_set_system_active(). >> >> For flask a stub is added to ensure that flask policy system will function >> correctly with this patch until flask is extended with support for starting the >> idle domain privileged and properly demoting it on the call to >> xsm_set_system_active(). >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Jason Andryuk >> Reviewed-by: Luca Fancellu >> Acked-by: Julien Grall # arm >> --- >> xen/arch/arm/setup.c | 3 +++ >> xen/arch/x86/setup.c | 4 ++++ >> xen/common/sched/core.c | 7 ++++++- >> xen/include/xsm/dummy.h | 17 +++++++++++++++++ >> xen/include/xsm/xsm.h | 6 ++++++ >> xen/xsm/dummy.c | 1 + >> xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ >> 7 files changed, 60 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >> index d5d0792ed4..7f3f00aa6a 100644 >> --- a/xen/arch/arm/setup.c >> +++ b/xen/arch/arm/setup.c >> @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset, >> /* Hide UART from DOM0 if we're using it */ >> serial_endboot(); >> >> + if ( (rc = xsm_set_system_active()) != 0 ) >> + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", rc); >> + >> system_state = SYS_STATE_active; >> >> for_each_domain( d ) >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index 6f20e17892..57ee6cc407 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -620,6 +620,10 @@ static void noreturn init_done(void) >> { >> void *va; >> unsigned long start, end; >> + int err; >> + >> + if ( (err = xsm_set_system_active()) != 0 ) >> + panic("xsm(err=%d): unable to set hypervisor to SYSTEM_ACTIVE privilege\n", err); > > Can you place err on a new line to make the line length no longer than > strictly necessary. > > I think you could also reduce the printed message to: > > "unable to switch to SYSTEM_ACTIVE privilege: %d\n" > > Which could likely fit in a line (seeing as others are fine with the > longer message I'm not going to insist). Nope, I am with you on this. I would prefer to have less than 80 or wrap. I like the suggestion, it will get it below 80 without any loss of meaning. >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index 0bf63ffa84..54745e6c6a 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) >> return 0; >> } >> >> +static int cf_check flask_set_system_active(void) >> +{ >> + struct domain *d = current->domain; >> + >> + ASSERT(d->is_privileged); >> + >> + if ( d->domain_id != DOMID_IDLE ) >> + { >> + printk("%s: should only be called by idle domain\n", __func__); >> + return -EPERM; >> + } >> + >> + /* >> + * While is_privileged has no significant meaning under flask, set to false >> + * as is_privileged is not only used for a privilege check but also as a type > > Nit: I think this line is over 80 cols. Ugh, probably spell check pushed it over, and I didn't catch it. Will fix. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 11:54:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 11:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339554.564423 (Exim 4.92) (envelope-from ) id 1nw0SK-0005HF-GU; Tue, 31 May 2022 11:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339554.564423; Tue, 31 May 2022 11:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw0SK-0005H8-CW; Tue, 31 May 2022 11:54:36 +0000 Received: by outflank-mailman (input) for mailman id 339554; Tue, 31 May 2022 11:52:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw0Q8-0005Dc-3T for xen-devel@lists.xenproject.org; Tue, 31 May 2022 11:52:20 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e60e39b-e0d8-11ec-837f-e5687231ffcc; Tue, 31 May 2022 13:52:17 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id h11so17136787eda.8 for ; Tue, 31 May 2022 04:52:17 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id c13-20020a50d64d000000b0042617ba63cfsm8278497edj.89.2022.05.31.04.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 04:52:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e60e39b-e0d8-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=pgwp2VdYx+Vpnhun4TNi+eC2topHBL0Uwk1ptGJfZcE=; b=iS5jhowOcF/lfXAMYJ1n2lLpF7hUtwsQikH8pir763iCnTkaHoMbpuD2JWonqpofGu qjyArBVFBAgZQ9fQpr/S/sNnTQgp1XR5p/rqsj3MhdJ+R24/EaY9Jbv7/STxX0BhfOae vvpJfMMcFbUtqlhICqYrW8DyeWTZfTB31dRM0WNqVaDsLbFsSSYIr3kJMkl8EIu8eyG0 IjQQuD7laFKec1PktUnxtrsiM3a+rYcN+wihWCwjJw7hyQww5pG4m0uXI4PcjIotDFcu f+NP9XC8R9LGUd3NPhygDtKFvwynWln1GjMt/3m1CHmsTLxPB1Nv/M1Gb8i3wsWht7ok zmHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pgwp2VdYx+Vpnhun4TNi+eC2topHBL0Uwk1ptGJfZcE=; b=HwLHP02j2myKoykIPklrw5GeDhNdes6kHrUqMGGTnhD1w69Fv9Hi/tj0JEoQbiBQMq pFBNPpZgbRwgb0XA/ywyr5QawY4ue27J1gqBooeQT/3KsIJabF7cDHR84bAJsaodw+D2 Cf6u/qM4nQjMIhCYGZEXYCh00k/aeC5bsyDot41OgQgO0Oi8y8YJfiYS+BseE7new3yr 7S3fC06rtjHSdCUPK5igLohYCF+bkAhSxD09uLAa8YfMG7ncv4G+PSI2KonLQV6RAmP1 se0H6tk2xFkWjPf1aFst0FtUVwtaeLuc1OPJZRK/D2BNz2acGXe3usVrgYY7rka4UnvD F9Kw== X-Gm-Message-State: AOAM531BmPQkLBLqjZdWG5KFDaXQ5USvFg6ry5kkvnlA5edrpfKpw/A3 WiAjpQ0+91xva2co9MEelbURbA== X-Google-Smtp-Source: ABdhPJzLoz1xLJgBhIhIcXu/CVKt7lUZqurHOJkAtVo1mU8l+2AAQXVVLJ65/yyrjl+Cx6OqWRo0rg== X-Received: by 2002:aa7:c852:0:b0:42d:70d8:2864 with SMTP id g18-20020aa7c852000000b0042d70d82864mr19815609edt.379.1653997936660; Tue, 31 May 2022 04:52:16 -0700 (PDT) Message-ID: <15eef004-74c7-0eb5-3f87-86e164ef70ff@linaro.org> Date: Tue, 31 May 2022 13:52:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V3 5/8] dt-bindings: Add xen,grant-dma IOMMU description for xen-grant DMA ops Content-Language: en-US To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , Rob Herring , Joerg Roedel , Will Deacon , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Arnd Bergmann References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> <1653944417-17168-6-git-send-email-olekstysh@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <1653944417-17168-6-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/05/2022 23:00, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml > new file mode 100644 > index 00000000..ab5765c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iommu/xen,grant-dma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xen specific IOMMU for virtualized devices (e.g. virtio) > + > +maintainers: > + - Stefano Stabellini > + > +description: > + The reference to Xen specific IOMMU node using "iommus" property indicates > + that Xen grant mappings need to be enabled for the device, and it specifies > + the ID of the domain where the corresponding backend resides. > + The binding is required to restrict memory access using Xen grant mappings. > + > +properties: > + compatible: > + const: xen,grant-dma > + > + '#iommu-cells': > + const: 1 > + description: > + Xen specific IOMMU is multiple-master IOMMU device. > + The single cell describes the domid (domain ID) of the domain where > + the backend is running. > + > +required: > + - compatible > + - "#iommu-cells" > + > +additionalProperties: false > + > +examples: > + - | > + xen_iommu { No underscores in node names, generic node names, so this looks like "iommu". > + compatible = "xen,grant-dma"; > + #iommu-cells = <1>; > + }; > + > + virtio@3000 { > + compatible = "virtio,mmio"; > + reg = <0x3000 0x100>; > + interrupts = <41>; > + > + /* The backend is located in Xen domain with ID 1 */ > + iommus = <&xen_iommu 1>; There is no need usually to give consumer examples in provider binding. If there is nothing specific here (looks exactly like every IOMMU consumer in Linux kernel), drop the consumer. > + }; Best regards, Krzysztof From xen-devel-bounces@lists.xenproject.org Tue May 31 13:10:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339565.564433 (Exim 4.92) (envelope-from ) id 1nw1db-0005De-3t; Tue, 31 May 2022 13:10:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339565.564433; Tue, 31 May 2022 13:10:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1db-0005DX-11; Tue, 31 May 2022 13:10:19 +0000 Received: by outflank-mailman (input) for mailman id 339565; Tue, 31 May 2022 13:10:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1dZ-0005DR-K3 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:10:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 029348eb-e0e3-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:10:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E725E6123B; Tue, 31 May 2022 13:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4BEECC3411D; Tue, 31 May 2022 13:10:13 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 2B888F03944; Tue, 31 May 2022 13:10:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 029348eb-e0e3-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654002613; bh=LaTXhCuMwgI4WA45VBnWzAMyaiH/DYYEL0PrWaBNUW4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=K1Tm64+RqHAbNl8i7qETqWYBbV8Ox/aZ3zddS2YiAdsffS425PSi8XFVJt5Cuy42F pwoOq7HZLY4R85tXusK2ITuquZqnEWx+nX1GCv0bmWrnXHE9bQU6oWUaMGOkBO6rRo /N0BJ/hf3FkYWxFzK5Siibnzxwc+LT0XMsgcrMM0AxINZw9XNjGEj42LLq3sto+MWd iHMieWSWHgHM/IAeTw8FBQn1bQNcYI+8rTJZp4D0ZokzVmPaKki3Prmi4Pr4tqGH32 BfwmRlaDq8bv8Wc7N9ySlEwBBesltaYdIg0s0QNHH/g6fJW6cHfV2jdHOurhvZwPHQ xe8pPC23zUlxg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165400261317.8298.1056578023912493620.git-patchwork-notify@kernel.org> Date: Tue, 31 May 2022 13:10:13 +0000 References: <20220530113459.20124-1-jgross@suse.com> In-Reply-To: <20220530113459.20124-1-jgross@suse.com> To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jbeulich@suse.com Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni : On Mon, 30 May 2022 13:34:59 +0200 you wrote: > Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case > of RING_HAS_UNCONSUMED_REQUESTS(). > > Reported-by: Jan Beulich > Fixes: 6fac592cca60 ("xen: update ring.h") > Signed-off-by: Juergen Gross > > [...] Here is the summary with links: - xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() https://git.kernel.org/netdev/net/c/09e545f73814 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Tue May 31 13:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339574.564445 (Exim 4.92) (envelope-from ) id 1nw1hb-0005xP-Lp; Tue, 31 May 2022 13:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339574.564445; Tue, 31 May 2022 13:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1hb-0005xI-IV; Tue, 31 May 2022 13:14:27 +0000 Received: by outflank-mailman (input) for mailman id 339574; Tue, 31 May 2022 13:14:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1ha-0005xA-Ks for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:14:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98073128-e0e3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 15:14:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3739E21B94; Tue, 31 May 2022 13:14:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD9C113AA2; Tue, 31 May 2022 13:14:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X/yNNLAUlmI/CAAAMHmgww (envelope-from ); Tue, 31 May 2022 13:14:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98073128-e0e3-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1654002865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cV/s8ODRud3oWVglCBDUwrUrLfXeHFQRFDXz4o/zOxk=; b=Yp8KtEW8fu1R6+kQT/RmNX93Av1Gab3KwaMDoDaPwI9+FoItS9/IuNxi09vczHvAkkn4fL Q6RvRT2HF8Igoq+0aT+nyRauYNj4uFllo5uX5xeKSaHBlD5vI6JdY7xKeNuB9l1qi1uCfA gz69UF1g1xoYPSQY9Fs6cBaBX4dwzQI= Message-ID: <69d69ca2-6b5e-b1bb-ed3f-3a8a8f166923@suse.com> Date: Tue, 31 May 2022 15:14:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership Content-Language: en-US To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> From: Juergen Gross In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IGVNTe8sDM9aBfStIJFkHrSI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IGVNTe8sDM9aBfStIJFkHrSI Content-Type: multipart/mixed; boundary="------------yQuddWP3Gq7gYW96q7pz0TnT"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Message-ID: <69d69ca2-6b5e-b1bb-ed3f-3a8a8f166923@suse.com> Subject: Re: [PATCH] MAINTAINERS: Update Xen maintainership References: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> In-Reply-To: <1653674225-10447-1-git-send-email-boris.ostrovsky@oracle.com> --------------yQuddWP3Gq7gYW96q7pz0TnT Content-Type: multipart/mixed; boundary="------------QCx2UWGf0ljN140bQk2Zs6Cy" --------------QCx2UWGf0ljN140bQk2Zs6Cy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDUuMjIgMTk6NTcsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gRHVlIHRvIHRp bWUgY29uc3RyYWludHMgSSBhbSBzdGVwcGluZyBkb3duIGFzIG1haW50YWludGVyLiBJIHdp bGwgc3RheQ0KPiBhcyByZXZpZXdlciBmb3IgeDg2IGNvZGUgKGZvciB3aGljaCBjcmVhdGUg YSBzZXBhcmF0ZSBjYXRlZ29yeSkuDQo+IA0KPiBTdGVmYW5vIGlzIG5vdyBtYWludGFpbmVy IGZvciBYZW4gaHlwZXJ2aXNvciBpbnRlcmZhY2UgYW5kIE9sZWtzYW5kciBoYXMNCj4gZ3Jh Y2lvdXNseSBhZ3JlZWQgdG8gYmVjb21lIGEgcmV2aWV3ZXIuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPg0KDQpw dXNoZWQgdG8geGVuL3RpcC5naXQgZm9yLWxpbnVzLTUuMTkNCg0KDQpKdWVyZ2VuDQo= --------------QCx2UWGf0ljN140bQk2Zs6Cy Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------QCx2UWGf0ljN140bQk2Zs6Cy-- --------------yQuddWP3Gq7gYW96q7pz0TnT-- --------------IGVNTe8sDM9aBfStIJFkHrSI Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmKWFLAFAwAAAAAACgkQsN6d1ii/Ey+I 9AgAkbqfJcwiPxYHzKtNXhHEWQBFjpRa7KlC+K50Mbc/DVP1Xa5jLXeWKy5w5kopAUOjeGWnsN/4 CzJD0og2mAXbwDWOccqxJjxZEGdKbo3AM5NNWoRlbv8qLnkJIEQHxvBXsYmd7W7u3hui+UJ4zXDz bKXspljPx9kgfidSEOOqfewPabN2FXFAYbKc/U5PXFee9FnbE7Wi/E5Bs5IGRKthB7X7Zj/z+3oe y2li8aY7PXUHET7MGxqdEOmcZpHrhOZhDHvZFUd7M8eNGtXNJY4LhLRkKOz5IXoKTKeJDV9o248t JEy6/1aAce17PSBzx2XTBwtkjvOEofDRRuEU+oG5lw== =lWW6 -----END PGP SIGNATURE----- --------------IGVNTe8sDM9aBfStIJFkHrSI-- From xen-devel-bounces@lists.xenproject.org Tue May 31 13:17:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:17:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339583.564456 (Exim 4.92) (envelope-from ) id 1nw1kv-0006Z4-69; Tue, 31 May 2022 13:17:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339583.564456; Tue, 31 May 2022 13:17:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1kv-0006Yx-2T; Tue, 31 May 2022 13:17:53 +0000 Received: by outflank-mailman (input) for mailman id 339583; Tue, 31 May 2022 13:17:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1kt-0006Yn-99; Tue, 31 May 2022 13:17:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1kt-000423-7G; Tue, 31 May 2022 13:17:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1ks-0008Q6-Jf; Tue, 31 May 2022 13:17:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nw1ks-0003Jm-JB; Tue, 31 May 2022 13:17:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y5eyhnebZXE+SOf5k7KD0B+6LcGYECXBTOXD918sHbw=; b=2pZYRCAsK+VGidFM3D5ru3HWVA UP9DAbDKhE6zKOmACO5Eg1OYrg+x8kihpMsxtAahdx+4ZliprUHDA8B+OtWiCsYj/H2RHZM600H/u GayTKMRyyAKokGCpZoC+V1uUFtgjD01JzYuu3L1UXfnSsmPP4SWGPaeE0Hlic7hCls5s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 170783: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7077fcb9b68f058809c9dd9fd1dacae1881e886c X-Osstest-Versions-That: qemuu=ed72f34421f8900d9fedef4a37722522cf0bf3e7 From: osstest service owner Date: Tue, 31 May 2022 13:17:50 +0000 flight 170783 qemu-mainline real [real] flight 170787 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170783/ http://logs.test-lab.xenproject.org/osstest/logs/170787/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 170787-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 170787-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 170778 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170778 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 170778 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170778 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170778 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 170778 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 170778 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170778 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170778 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 7077fcb9b68f058809c9dd9fd1dacae1881e886c baseline version: qemuu ed72f34421f8900d9fedef4a37722522cf0bf3e7 Last test of basis 170778 2022-05-30 20:07:05 Z 0 days Testing same since 170783 2022-05-31 04:03:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Maciej S. Szmigiero Philippe Mathieu-Daudé Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ed72f34421..7077fcb9b6 7077fcb9b68f058809c9dd9fd1dacae1881e886c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue May 31 13:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339595.564467 (Exim 4.92) (envelope-from ) id 1nw1oX-00087p-Qn; Tue, 31 May 2022 13:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339595.564467; Tue, 31 May 2022 13:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1oX-00087i-N8; Tue, 31 May 2022 13:21:37 +0000 Received: by outflank-mailman (input) for mailman id 339595; Tue, 31 May 2022 13:21:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1oW-00085J-H6 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:21:36 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97dda21f-e0e4-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:21:34 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2058.outbound.protection.outlook.com [104.47.2.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-19-eqlT9RGtPdqClCKzNrwbdg-1; Tue, 31 May 2022 15:21:32 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9491.eurprd04.prod.outlook.com (2603:10a6:102:2c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 13:21:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 13:21:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97dda21f-e0e4-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654003294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aKeLTfjmLj2HPOt3sxPPU5/SalvdxhLk9cWVAhXxD9k=; b=go/KICIaAvX7mO0621beJoBINJ0xkuxN2iM0dnWCjYIMIM29eTGEhJmox0pfleLAmpC4wK 9uAD0mOjmoKN9dCKXE5r39aFTWhOcK6B7Liod75AKFarLU6vFA+hLgqNb7CAGFzf7wnarq 7woPz+O7i0MIC53W0y+krRnH9mV+cDI= X-MC-Unique: eqlT9RGtPdqClCKzNrwbdg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/l4Lb1n/L2F+pWPzfKroTuM6J2pJjOJlH9f82/CtUhf1wGrzPpGR6WZB6YJ34sRhWJ967BT8nmL2Sm6sWYExYvgXq1WUcuPkGm1JG3PdU/9DW4WbogfX/4Q6vvbADoNxnhlzPkqjhwZmJf4DmGn+1fddY/Jo4SQC2RfSsIjhQQMo+OREJFapY0dW3aGIqYzS12u9/nGTaQyW4BqZeLvbWzMWDjtudwU2aEBl9CrKrQ8kb/Sc560zLuIrPxxGrq10o1wSK3zA10S8T02WbLK0K091jRQ3F0+m9foHRftwDpnyfTsT/DzL1r+4WJFKmz/mkkda3pzjxssgZNqfmoXAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7l5gmN4fJvaF7RUFhpxP4W0t1hLpWHSY0G+tfL2gwM=; b=bTPwTyq0W6ulUN4LyOUnGA1lo33GCJaM/yECW5p4HhXG6+Mfl0b7ZZKS6bRZUL87diry8dCEYUSrNNnuzmx7AjCQ4H9PIgxVPRpAkN0ZiDP7fhJPmWZ1J2tTCcECT6EW++HonO7yPjsss3CvPW4h2Mwv3TEtI19XqEvf0WPPAPV26u2wtJjGnIb1gxodwhvY/550lFpWF8Xnm2I8l36LHoquITNnAnAAo7DPDWhkcQ0puleEamsrVWIrcHeMxRamp+dFYi+XfWY1Xuph80S3OvM0kzGAyvjldqgnZsWHU+elHTQAIlMyF0cr2JpdcWsK4orXL6hMnJ280x0tv4u1zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6003b7a5-63c5-9bd3-03db-a4bac5ba8e00@suse.com> Date: Tue, 31 May 2022 15:21:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 7/8] xen/x86: add detection of memory interleaves for different nodes Content-Language: en-US To: Wei Chen CC: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220523062525.2504290-1-wei.chen@arm.com> <20220523062525.2504290-8-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220523062525.2504290-8-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR07CA0028.eurprd07.prod.outlook.com (2603:10a6:20b:451::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b6caf7c-9ee8-41c1-1650-08da430879b5 X-MS-TrafficTypeDiagnostic: PAXPR04MB9491:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EDU1c0Bma/wZ5W7x3jnz02XqorYPp4wPWbOYAYAEMkFImmlcWqDxY5zdUOjpqfCWai7TWFOQGg76FkfXAHE9Nqa3vUh1nozFZuO0rc57uzqFxWw8nDyWntJcz0nYtYQPcSu2zFH0dCfyOZpT4P8UjXU7MjRox1W8yQpkdwDYP1bLvSSVi6pAXq8WC/at0WMX1saJJmo4dFLu/I0xWBPkbXAnpgWpfzNmevGSE47yShg+AygR75wXuGl4Eq58XTgtV7ua1RhfdpImeByuST2Bzhd5fFS3/Jls+MkxjD3pVaSYVS8TKKqePvxG9QnsFS9TblDa8CJAxoyYRRWp5qzjQqKWNjyz/lzW4fO3eBliWhbS30T8gMLpkGTdkE97GaDrbFbGBXOwVUrmmzYGi3QQ0calYGRGdABUiwPSWqK9CaA5wam/nXXk2aZghGOC7LjU+mXsTwDXmYJkUcRChK0LlJSFQKkCm3Bf+Uq14R+4h/IghQBcIzlOQ0bHjnqGJ5w8BTxe7CBifJ/7jR+8atgxPx9hCyNDEQ/bf4/I1nuUdLeDfmeDmQH7kXRQIWs5tHRhg5lUfFFKPE6wZ9wiN3qvjGhZ7G+b+uNCgbqcE8NUIfcoQfCrKJ0F75HRIGMbljUPzPpyRpN1nTD2TQrzyudTEaan8GK4xfdIvWx3VolufUJ9eLbNRKN/5eUl5qeI7nw4NJao4OndF63otvnIHbHpAJYPqeIOXwkW0k+Be4l8dxU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(38100700002)(4326008)(316002)(6916009)(54906003)(26005)(6512007)(6506007)(5660300002)(53546011)(6486002)(8936002)(508600001)(31686004)(2906002)(83380400001)(66556008)(66476007)(66946007)(86362001)(8676002)(31696002)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U+WD9TbWRYblndem/9JDYovVj/I/oy1ZTFbQY4OMTiQJbqoCHeSYXVChj8RX?= =?us-ascii?Q?7fDL85+GiHxU6q5M24KC0/ZvbfHAGH1rmAtnzr12KDCJvt4FP+OHCoYJxphF?= =?us-ascii?Q?QTqPusgTdAwFZKnPKnLzovaTCvOOHAlOOHEXWTCc/67TwhKwV6NvxecPrC4N?= =?us-ascii?Q?zas5/23vTxGyPlK1JMu2lc9QhamHThyG5k+qJLBrl50UC3JadVI/IP7KbeA0?= =?us-ascii?Q?hLWpqX+BXM8QqlFyYLQjoWbpdIUkA/nSKiR6VqkKSPdj4HfaKeqGkMXpwpSI?= =?us-ascii?Q?j+wh31e+7N7XbCa7oUl5j0VocghwE7cu2+b8BSF7eNg66QOnMIuoT/eJVAro?= =?us-ascii?Q?kptDhPlBA/FlCFZa8pyWvyrpGHABzT6kGxYMbqIkqb4Ke3p2wXxOy7mzWAhO?= =?us-ascii?Q?x0RheqMeWOGjzwk2/HM1Q2Yq3bml6X1wTrb9hd2S64OzLtFGZP1C7rmvR5e7?= =?us-ascii?Q?nWAm3BLLO/uV+iLPvwccZALrvNwS+nUxaLLLCSrx3p9SFutQW3G6E2pMCuoi?= =?us-ascii?Q?mEgo2/Nbs3Nm3Jniaa2K2bmaeccq74U+9x32Hyv5s6seOEivy6g9HnFjk1M+?= =?us-ascii?Q?3My6DfJKfn3eOVpmzyLAqJI03BwxcIo6qQul3J2FNcLhdhwzEyObR6xQyU8C?= =?us-ascii?Q?tLMVc5AjsEBFC6sKDN9CmFQYUla64FDXYZ05oVp6PAKI7wzbS/tWwTopGhgr?= =?us-ascii?Q?GSy7IyS3O204kG635NcY/doBYPMZ6Yr0BQB3ct60W4g1QkMFDSrrwOjDtANx?= =?us-ascii?Q?rK7KRZqf3z0aDqlsnsbi3+D+ui/FdewxVR6nEdMJ3VCbTvgPafPzOTD01koF?= =?us-ascii?Q?xOrSRgOsu4NiaKny9oLadJrOKva0tEHLVyGf0rka4TgZ0szdsAC5YjvjEA9O?= =?us-ascii?Q?h6bphuOCv7DdxThTM9nJ/ownSk5t125gOui85lxf7qqdoTD6GMU1ZEtukdYb?= =?us-ascii?Q?VTPsi8NL9cHoAS1GHy6iEtCf1yhO2yXC09HKJ1FkQpwpxmOt7lIbL1K9ajp1?= =?us-ascii?Q?bgcGwVAClRBrn+opA1suIMEH6TynVtaHKt8l3h5flu8LLkcdy9dakpljqjGA?= =?us-ascii?Q?ucEzMGKMiHNQPgq6GBj31HDZOIEqpgyqcYG9c5mRpnxqHUinHLjzNcuVl9bp?= =?us-ascii?Q?Ozu/dLaat+TUm+TyyLBT38aHzo6w+xNrThPLfc+6z3GDt8NKQixdnfpUsp8F?= =?us-ascii?Q?xgaqVRI6CcBSLXd7DpkMupSz46BvRKhoNe9V5xzK0qkWNvVw2pOWU7lSVPIv?= =?us-ascii?Q?i2n+F4fN+u/L6ew5TSz8Wu6fUIYaNiPoKue6rE+Yhfy9EdFzEKUosFcL69hE?= =?us-ascii?Q?cUg8jkkOlkMj/RdBOr3MlNIz9L3A6Pjwh802uTeJdMpxL2V6RF5Uf1Tz3g+z?= =?us-ascii?Q?42q+x6TafGUtqA3nKIDq47PbDTuPxtfOqHBJyPhq9oNLPdO9ldvF/6tIHq/b?= =?us-ascii?Q?gJuECDvKprDRqpU9l3tlOJXZim9D8UV28hQqHBrXbw03urQ1MkLG9NhR06Mh?= =?us-ascii?Q?DvgaIs9NtrNKg/RjwkqYbO2lZe7TfMQl/+8eFNmY0frdvpsJe9/A0OddLk0F?= =?us-ascii?Q?QU37zt9TTkjdWL0r8IV5WSpG4584fyMlIBsnT+gMuNQVzveHVfeA2x/54v56?= =?us-ascii?Q?vChE3h8Q0FJ9AZt7Pf1+S9gKD/SjJXWWIExs/13himf7Qj/4okQEDV68klGI?= =?us-ascii?Q?ddNwYiizY4rSKE0tN9h4kkQDn8J30cu2plAD2xTUKZZSx4fzmE6Gb5ZUflnU?= =?us-ascii?Q?o+bL2ppAaQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b6caf7c-9ee8-41c1-1650-08da430879b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 13:21:30.8462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WwjcZNHQy6tzW9yqU+MdzwhSG3UZ27aXckWThOJTH6yZ9uC+61AfiiLOwCXn6F6Gi259fXBW3cRM++I+fVQPiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9491 On 23.05.2022 08:25, Wei Chen wrote: > @@ -119,20 +125,45 @@ int valid_numa_range(paddr_t start, paddr_t end, no= deid_t node) > return 0; > } > =20 > -static __init int conflicting_memblks(paddr_t start, paddr_t end) > +static > +enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, > + paddr_t end, paddr_t nd_start, > + paddr_t nd_end, unsigned int *mblkid) > { > - int i; > + unsigned int i; > =20 > + /* > + * Scan all recorded nodes' memory blocks to check conflicts: > + * Overlap or interleave. > + */ > for (i =3D 0; i < num_node_memblks; i++) { > struct node *nd =3D &node_memblk_range[i]; > + > + *mblkid =3D i; > + > + /* Skip 0 bytes node memory block. */ > if (nd->start =3D=3D nd->end) > continue; > + /* > + * Use memblk range to check memblk overlaps, include the > + * self-overlap case. > + */ > if (nd->end > start && nd->start < end) > - return i; > + return OVERLAP; > if (nd->end =3D=3D end && nd->start =3D=3D start) > - return i; > + return OVERLAP; Knowing that nd's range is non-empty, is this 2nd condition actually needed here? (Such an adjustment, if you decided to make it and if not split out to a separate patch, would need calling out in the description.) > + /* > + * Use node memory range to check whether new range contains > + * memory from other nodes - interleave check. We just need > + * to check full contains situation. Because overlaps have > + * been checked above. > + */ > + if (nid !=3D memblk_nodeid[i] && > + (nd_start < nd->start && nd->end < nd_end)) > + return INTERLEAVE; Doesn't this need to be <=3D in both cases (albeit I think one of the two expressions would want switching around, to better line up with the earlier one, visible in context further up). > @@ -275,10 +306,13 @@ acpi_numa_processor_affinity_init(const struct acpi= _srat_cpu_affinity *pa) > void __init > acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) > { > + enum conflicts status; I don't think you need this local variable. > @@ -310,42 +344,78 @@ acpi_numa_memory_affinity_init(const struct acpi_sr= at_mem_affinity *ma) > bad_srat(); > return; > } > + > + /* > + * For the node that already has some memory blocks, we will > + * expand the node memory range temporarily to check memory > + * interleaves with other nodes. We will not use this node > + * temp memory range to check overlaps, because it will mask > + * the overlaps in same node. > + * > + * Node with 0 bytes memory doesn't need this expandsion. > + */ > + nd_start =3D start; > + nd_end =3D end; > + nd =3D &nodes[node]; > + if (nd->start !=3D nd->end) { > + if (nd_start > nd->start) > + nd_start =3D nd->start; > + > + if (nd_end < nd->end) > + nd_end =3D nd->end; > + } > + > /* It is fine to add this area to the nodes data it will be used later*= / > - i =3D conflicting_memblks(start, end); > - if (i < 0) > - /* everything fine */; > - else if (memblk_nodeid[i] =3D=3D node) { > - bool mismatch =3D !(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) !=3D > - !test_bit(i, memblk_hotplug); > - > - printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself = (%"PRIpaddr"-%"PRIpaddr")\n", > - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end, > - node_memblk_range[i].start, node_memblk_range[i].end); > - if (mismatch) { > + status =3D conflicting_memblks(node, start, end, nd_start, nd_end, &i); > + switch(status) > + { Style: Missing blank before ( and the brace goes on the same line here (Linux style). > + case OVERLAP: > + { Please omit braces at case labels unless you need a new scope to declare variables. > + if (memblk_nodeid[i] =3D=3D node) { > + bool mismatch =3D !(ma->flags & > + ACPI_SRAT_MEM_HOT_PLUGGABLE) !=3D > + !test_bit(i, memblk_hotplug); > + > + printk("%sSRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with itself= (%"PRIpaddr"-%"PRIpaddr")\n", > + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, > + end, node_memblk_range[i].start, > + node_memblk_range[i].end); > + if (mismatch) { > + bad_srat(); > + return; > + } > + break; > + } else { > + printk(KERN_ERR > + "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (= %"PRIpaddr"-%"PRIpaddr")\n", > + pxm, start, end, node_to_pxm(memblk_nodeid[i]), > + node_memblk_range[i].start, > + node_memblk_range[i].end); > bad_srat(); > return; > } To limit indentation depth, on of the two sides of the conditional can be moved out, by omitting the unnecessary "else". To reduce the diff it may be worthwhile to invert the if() condition, allowing the (then implicit) "else" case to remain (almost) unchanged from the original. > - } else { > + } > + > + case INTERLEAVE: > + { > printk(KERN_ERR > - "SRAT: PXM %u (%"PRIpaddr"-%"PRIpaddr") overlaps with PXM %u (%= "PRIpaddr"-%"PRIpaddr")\n", > - pxm, start, end, node_to_pxm(memblk_nodeid[i]), > + "SRAT=EF=BC=9A PXM %u: (%"PRIpaddr"-%"PRIpaddr") interleaves wi= th PXM %u memblk (%"PRIpaddr"-%"PRIpaddr")\n", > + node, nd_start, nd_end, node_to_pxm(memblk_nodeid[i]), Hmm, you have PXM in the log message text, but you still pass "node" as first argument. Since you're touching all these messages, could I ask you to convert all ranges to proper mathematical interval representation? I.e. [start,end) here aiui as the end addresses look to be non-inclusive. > node_memblk_range[i].start, node_memblk_range[i].end); > bad_srat(); > return; > } > - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { > - struct node *nd =3D &nodes[node]; > =20 > - if (!node_test_and_set(node, memory_nodes_parsed)) { > - nd->start =3D start; > - nd->end =3D end; > - } else { > - if (start < nd->start) > - nd->start =3D start; > - if (nd->end < end) > - nd->end =3D end; > - } > + default: > + break; This wants to be "case NO_CONFLICT:", such that the compiler would warn if a new enumerator appears without adding code here. (An alternative - which personally I don't like - would be to put ASSERT_UNREACHABLE() in the default: case. The downside is that then the issue would only be noticeable at runtime.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 13:30:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:30:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339604.564478 (Exim 4.92) (envelope-from ) id 1nw1wz-00018P-P7; Tue, 31 May 2022 13:30:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339604.564478; Tue, 31 May 2022 13:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1wz-00018I-Ko; Tue, 31 May 2022 13:30:21 +0000 Received: by outflank-mailman (input) for mailman id 339604; Tue, 31 May 2022 13:30:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw1wy-00018C-Kg for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:30:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d058ff7a-e0e5-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:30:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73A7523A; Tue, 31 May 2022 06:30:18 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 506C33F766; Tue, 31 May 2022 06:30:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d058ff7a-e0e5-11ec-837f-e5687231ffcc From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen: Add MISRA support to cppcheck make rule Date: Tue, 31 May 2022 14:30:09 +0100 Message-Id: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cppcheck MISRA addon can be used to check for non compliance to some of the MISRA standard rules. Add a CPPCHECK_MISRA variable that can be set to "y" using make command line to generate a cppcheck report including cppcheck misra checks. When MISRA checking is enabled, a file with a text description suitable for cppcheck misra addon is generated out of Xen documentation file which lists the rules followed by Xen (docs/misra/rules.rst). By default MISRA checking is turned off. Signed-off-by: Bertrand Marquis --- This change depends on the patch from Stefano Stabellini adding the list of misra rules in the documentation (docs/misra: introduce rules.rst). --- .gitignore | 2 + xen/Makefile | 32 +++++++- xen/tools/convert_misra_doc.py | 139 +++++++++++++++++++++++++++++++++ 3 files changed, 171 insertions(+), 2 deletions(-) create mode 100755 xen/tools/convert_misra_doc.py diff --git a/.gitignore b/.gitignore index 18ef56a780..65a58ba7e4 100644 --- a/.gitignore +++ b/.gitignore @@ -297,6 +297,8 @@ xen/.banner xen/.config xen/.config.old xen/.xen.elf32 +xen/cppcheck-misra.txt +xen/cppcheck-misra.json xen/xen-cppcheck.xml xen/System.map xen/arch/x86/boot/mkelf32 diff --git a/xen/Makefile b/xen/Makefile index 82f5310b12..aee6660556 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -548,7 +548,7 @@ _clean: rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h rm -f .banner .allconfig.tmp include/xen/compile.h - rm -f xen-cppcheck.xml + rm -f cppcheck-misra.json cppcheck-misra.txt xen-cppcheck.xml .PHONY: _distclean _distclean: clean @@ -642,6 +642,10 @@ CPPCHECK_HTMLREPORT ?= cppcheck-htmlreport # build directory. This can be changed by giving a directory in this variable. CPPCHECK_HTMLREPORT_OUTDIR ?= cppcheck-htmlreport +# By default we do not check misra rules, to enable pass "CPPCHECK_MISRA=y" to +# make command line. +CPPCHECK_MISRA ?= n + # Compile flags to pass to cppcheck: # - include directories and defines Xen Makefile is passing (from CFLAGS) # - include config.h as this is passed directly to the compiler. @@ -666,6 +670,15 @@ CPPCHECKFILES := $(wildcard $(patsubst $(objtree)/%.o,$(srctree)/%.c, \ $(filter-out $(objtree)/tools/%, \ $(shell find $(objtree) -name "*.o")))) +# Headers and files required to run cppcheck on a file +CPPCHECKDEPS := $(objtree)/include/generated/autoconf.h \ + $(objtree)/include/generated/compiler-def.h + +ifeq ($(CPPCHECK_MISRA),y) + CPPCHECKFLAGS += --addon=cppcheck-misra.json + CPPCHECKDEPS += cppcheck-misra.json +endif + quiet_cmd_cppcheck_xml = CPPCHECK $(patsubst $(srctree)/%,%,$<) cmd_cppcheck_xml = $(CPPCHECK) -v -q --xml $(CPPCHECKFLAGS) \ --output-file=$@ $< @@ -690,7 +703,7 @@ ifeq ($(CPPCHECKFILES),) endif $(call if_changed,merge_cppcheck_reports) -$(objtree)/%.c.cppcheck: $(srctree)/%.c $(objtree)/include/generated/autoconf.h $(objtree)/include/generated/compiler-def.h | cppcheck-version +$(objtree)/%.c.cppcheck: $(srctree)/%.c $(CPPCHECKDEPS) | cppcheck-version $(call if_changed,cppcheck_xml) cppcheck-version: @@ -703,6 +716,21 @@ cppcheck-version: exit 1; \ fi +# List of Misra rules to respect is written inside a doc. +# In order to have some helpful text in the cppcheck output, generate a text +# file containing the rules identifier, classification and text from the Xen +# documentation file. Also generate a json file with the right arguments for +# cppcheck in json format including the list of rules to ignore +# +# Replace current by goal in the dependency to generate an analysis for all +# rules we would like to respect. +cppcheck-misra.json cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst + $(Q)$(srctree)/tools/convert_misra_doc.py -i $< -o cppcheck-misra.txt \ + -j cppcheck-misra.json + +# Prevent parallel make issues as script is generating both files +cppcheck-misra.json: cppcheck-misra.txt + # Put this in generated headers this way it is cleaned by include/Makefile $(objtree)/include/generated/compiler-def.h: $(Q)$(CC) -dM -E -o $@ - < /dev/null diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py new file mode 100755 index 0000000000..47133a33a6 --- /dev/null +++ b/xen/tools/convert_misra_doc.py @@ -0,0 +1,139 @@ +#!/usr/bin/env python + +""" +This script is converting the misra documentation RST file into a text file +that can be used as text-rules for cppcheck. +Usage: + convert_misr_doc.py -i INPUT [-o OUTPUT] [-j JSON] + + INPUT - RST file containing the list of misra rules. + OUTPUT - file to store the text output to be used by cppcheck. + If not specified, the result will be printed to stdout. + JSON - cppcheck json file to be created (optional). +""" + +import sys, getopt, re + +def main(argv): + infile = '' + outfile = '' + outstr = sys.stdout + jsonfile = '' + + try: + opts, args = getopt.getopt(argv,"hi:o:j:",["input=","output=","json="]) + except getopt.GetoptError: + print('convert-misra.py -i [-o ] [-j ') + sys.exit(2) + for opt, arg in opts: + if opt == '-h': + print('convert-misra.py -i [-o ] [-j ') + print(' If output is not specified, print to stdout') + sys.exit(1) + elif opt in ("-i", "--input"): + infile = arg + elif opt in ("-o", "--output"): + outfile = arg + elif opt in ("-j", "--json"): + jsonfile = arg + + try: + file_stream = open(infile, 'rt') + except: + print('Error opening ' + infile) + sys.exit(1) + + if outfile: + try: + outstr = open(outfile, "w") + except: + print('Error creating ' + outfile) + sys.exit(1) + + # Each rule start with '- Rule: Dir' + pattern_dir = re.compile(r'^- Rule: Dir ([0-9]+.[0-9]+).*$') + pattern_rule = re.compile(r'^- Rule: Rule ([0-9]+.[0-9]+).*$') + pattern_severity = re.compile(r'^ - Severity: (.*)$') + pattern_text = re.compile(r'^ - Summary: (.*)$') + + rule_number = '' + rule_state = 0 + rule_list = [] + + # Start search by cppcheck misra + outstr.write('Appendix A Summary of guidelines\n') + + for line in file_stream: + + line = line.replace('\r', '').replace('\n', '') + + if len(line) == 0: + continue + + # New rule + if rule_state == 0: + res = pattern_rule.match(line) + if res: + rule_state = 1 + rule_number = res.group(1) + rule_list.append(rule_number) + continue + res = pattern_dir.match(line) + if res: + rule_state = 1 + rule_number = res.group(1) + rule_list.append(rule_number) + continue + + # Severity + elif rule_state == 1: + res = pattern_severity.match(line) + if res: + outstr.write('Rule ' + rule_number + ' ' + res.group(1) + '\n') + rule_state = 2 + continue + + # Summary + elif rule_state == 2: + res = pattern_text.match(line) + if res: + outstr.write(res.group(1) + ' (Misra rule ' + rule_number + + ')\n') + rule_state = 0 + rule_number = '' + continue + else: + print('Error impossible case !!!') + + skip_list = [] + + # Search for missing rules and add a dummy text with the rule number + for i in list(range(1,22)): + for j in list(range(1,22)): + if str(i) + '.' + str(j) not in rule_list: + outstr.write('Rule ' + str(i) + '.' + str(j) + '\n') + outstr.write('No description for rule ' + str(i) + '.' + str(j) + + '\n') + skip_list.append(str(i) + '.' + str(j)) + + # Make cppcheck happy by starting the appendix + outstr.write('Appendix B\n') + outstr.write('\n') + if outfile: + outstr.close() + + if jsonfile: + with open(jsonfile, "w") as f: + f.write('{\n') + f.write(' "script": "misra.py",\n') + f.write(' "args": [\n') + if outfile: + f.write(' "--rule-texts=' + outfile + '",\n') + + f.write(' "--suppress-rules=' + ",".join(skip_list) + '"\n') + f.write(' ]\n') + f.write('}\n') + f.close() + +if __name__ == "__main__": + main(sys.argv[1:]) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 13:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339614.564488 (Exim 4.92) (envelope-from ) id 1nw29V-0002qT-So; Tue, 31 May 2022 13:43:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339614.564488; Tue, 31 May 2022 13:43:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw29V-0002qM-Om; Tue, 31 May 2022 13:43:17 +0000 Received: by outflank-mailman (input) for mailman id 339614; Tue, 31 May 2022 13:43:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw29U-0002ov-JD for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:43:16 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9dd0d9a2-e0e7-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 15:43:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dd0d9a2-e0e7-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654004594; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lwJFOnLotaUEvEayBxsHt8xZHdydzYclJGPE8piF508=; b=c8j/J4nk8cFDbXKjJSPiwe4ztran9JDSW35M8j7cPVObDLh7kLmN/zhq +gEyEtSV7s8qKvXJ0wFOC5dOitlAw/uFw3DSjcF358ScQ6VvlA4pssTU8 l1sivnZWwzhgVpUaR0nWO9V2wP2slq2Q1nSLp4ZnESImN/Uf5XAvTPC8P E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 72519238 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:EGfTBq9JwVVsejvbQnJ1DrUD9H6TJUtcMsCJ2f8bNWPcYEJGY0x3y WoXWmjUbKrcZmegfdAkaN7jpkIH75OBmNJlTgo/+SE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnby2SRwIIIPjovkcczNHPB1MF797wIaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O JBEMGs1N0SojxtnIU0uU8s4xsWUhUKjcXp8rliMrpcS/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkYO8aY0iGt6W+3i6nEmiaTcJ4bEbSjsPpnhlKCy2g7CRsKWF/9qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobRws1 kSogf3GPyFukJeKZk6v3KWplQrnbED5MlQ+iT84oRotuoe++99q00+RHr6PA4bu0ISrRGiYL ySi6XFn2u5N1ZNjO7CTpwivvt66mnTeoufZDC3zV3nt0A52bZXNi2eAuQmCtqYowGp0ozC8U Jk4dyu2trlm4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmwldRw0bJhaIme4C KM2he+2zMYIVEZGkIctO97hYyjU5fSI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B1+ZzTz ayzKJ72ZV5DUPwP5GPvG481jO5wrghjlDy7eHwO50n+uVZoTCXNGelt3ZrnRr1R0Z5oVy2Mq 4sFapLRkUgDOAA8CwGOmbMuwZkxBSBTLfjLRwZ/LIZv/iIO9LkdNsLs IronPort-HdrOrdr: A9a23:pQyRfaFy1Ke9AWAfpLqF5pLXdLJyesId70hD6qkoc20tTiSZ// rOoB1p726NtN9xYgB/pTnuAtjkfZqxz/FICMwqTNGftWrdyTqVxeNZnO/fKlTbckWUnIMw6U 4jSdkYNDSaNzhHZLPBkWuF+qEbsbq6Gc6T69s2hE0dNj2CI5sQlTuQ9mygYwZLrPYtP+twKH JjjPA37gZIME5nE/hSfRE+LqL+jsyOm5T8bREcARk7rAGIkDOz8bb/VwOVxxEETlp0sMMfGE X+4n7ED5+YwoSGI97nph7uxoUTnMGkxspIBcSKhMRQIjLwihywbIAkX7GZpjg6rOym9V5vyb D30mEdFtU272mUcnC+oBPr1QWl2DEy62X6wVvdhXf4u8T2SD8zFsIEj4NEdRnS7VYmobhHod V29nPcs4ASAQLLnSz76dSNXxZ2llCsqX5niuIXh2w3a/psVJZB6YgEuE9FGpYJGyz3rIo9Fv N1Ec3a7PFKNVuHcnHQpABUsZGRd2V2Gg3DTlkJu8ST3TQTlmt+1VEEyMsWmWpF/I4hSoND+/ /PPs1T5f1zpoZ/V9M9OA92KfHHSlAkb3n3QSGvyRWOLtBJB5q7w6SHroncxIqRCd41JVsJ6e T8uCAxjx92R6vDM7zw4HQQyGGwfIyUZ0WS9ildj6IJ/oHUVf7xNzGfRBQgiM2l5/UFBMrDXe 2vUagmXMMKdwbVaMF0Ny6SYegVFZFfPfdl4urSFT+105n2wsOBjJ2GTB5gSYCdSAoMSyfjBn MYUHzpKN9d613DYA6jvDHBH27oclbyuY19C7Lb+e978vlRCrFx X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72519238" Date: Tue, 31 May 2022 14:43:04 +0100 From: Anthony PERARD To: Tamas K Lengyel CC: , Wei Liu , Juergen Gross , Andrew Cooper Subject: Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, May 19, 2022 at 01:16:35PM -0400, Tamas K Lengyel wrote: > Make the do_memory_op function accessible to tools linking with libxc. > Similar functions are already available for both domctl and sysctl. As part > of this patch we also change the input 'cmd' to be unsigned int to accurately > reflect what the hypervisor expects. > > Signed-off-by: Tamas K Lengyel Is exposing do_memory_op necessary? This kind of looks like a revert of 35e135f116 ("libxc: make xc_memory_op library private"). Anyway, if there isn't a better alternative: Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 31 13:46:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:46:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339624.564500 (Exim 4.92) (envelope-from ) id 1nw2CZ-0003XU-G3; Tue, 31 May 2022 13:46:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339624.564500; Tue, 31 May 2022 13:46:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2CZ-0003XN-DC; Tue, 31 May 2022 13:46:27 +0000 Received: by outflank-mailman (input) for mailman id 339624; Tue, 31 May 2022 13:46:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2CX-0003XD-Dt; Tue, 31 May 2022 13:46:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2CX-0004WO-Cp; Tue, 31 May 2022 13:46:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2CW-0000iX-UJ; Tue, 31 May 2022 13:46:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nw2CW-0002Vu-Tt; Tue, 31 May 2022 13:46:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T4ORhjQ0h/4Nj85BzhUMKZXh3wLC58eeMzUUAlNvLx4=; b=fdt3q/eTTfd0gZb1BgNRqGq7BF hC7XvhXKJstCZp9xZ3fMaZEuiwI244nTzSdxTigyc1aPwM+tbC3Xxre4iBo4PH86/qkX0aFD4lvuz niU0ww4ON16eQkH5ELrWq6bXbx4NCThJ/5JdJIhK1dHjapYh+gcVdn634VwEy1k2t7zs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 170786: all pass - PUSHED X-Osstest-Versions-This: ovmf=df1c7e91b46db364ba1ce5e21660987c29c35334 X-Osstest-Versions-That: ovmf=fa2b212d61dfeb9c00a174280a73a4f573ef617d From: osstest service owner Date: Tue, 31 May 2022 13:46:24 +0000 flight 170786 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170786/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf df1c7e91b46db364ba1ce5e21660987c29c35334 baseline version: ovmf fa2b212d61dfeb9c00a174280a73a4f573ef617d Last test of basis 170781 2022-05-31 02:10:26 Z 0 days Testing same since 170786 2022-05-31 11:42:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: cbduggap Duggapu, Chinni B jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fa2b212d61..df1c7e91b4 df1c7e91b46db364ba1ce5e21660987c29c35334 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 31 13:50:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:50:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339636.564511 (Exim 4.92) (envelope-from ) id 1nw2GQ-0004x9-13; Tue, 31 May 2022 13:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339636.564511; Tue, 31 May 2022 13:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2GP-0004x2-UB; Tue, 31 May 2022 13:50:25 +0000 Received: by outflank-mailman (input) for mailman id 339636; Tue, 31 May 2022 13:50:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2GO-0004ww-3v for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:50:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9dfddd6c-e0e8-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:50:23 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-wxh45arZPUyKyAlUFHlg1g-1; Tue, 31 May 2022 15:50:20 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB3215.eurprd04.prod.outlook.com (2603:10a6:802:7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 13:50:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 13:50:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dfddd6c-e0e8-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654005022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhBfe7fJ/6IkP0ufiPQN+ugxwDMuXeorZ0TLifc3u5k=; b=Qrl67Fqqr8MWwgx1kRcMBHrKvUb4ew22U/s9JRwyxoNPBaAKhS1sJ1yfZ5UDixoRQGfC2R uQgdlko9ZYvP2mTBa1FH6Z/6k3XnCXIvUKyBRUtVbVkmkSqMyLkUX82ded4r4ugRCMNYU4 0Wnf/DH0wkezMSKVSjaSgP6EA1tU1qs= X-MC-Unique: wxh45arZPUyKyAlUFHlg1g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RwSqmmgRueSIJJLlLrldooPHYmpjCP1Zs1itOmBNnVZpRZIQOMKxDszLk99XI8WlLyb58t9jnOrUEH8hTultinc4UWNPqZT+2m7tRFknRez70gLL30DPzXK/qFrvK+iNEqwpz0PBEHgfA6A6gG5afekDlcnRPjMXFWIUK52mjVdvKEfQ3pYdunkaJ4oQM/Hb0tIR/U0WrymAcEHbqjIYGkRrv7wF8eYmjNgHPXDsYE6ES8tRtoVJ4rk3yrqZVZerM1qk4J8G3DFD4sFlv1gIValoykxad7buLqxI2t3r6Cy1M3g8jnTEMhbLb4mqD+CZMrUMOYMZMDMhMm2yY/RMPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yhBfe7fJ/6IkP0ufiPQN+ugxwDMuXeorZ0TLifc3u5k=; b=m7Jek54VdzUso/gEX6nUhFJdJHFAQctHx2h4iB8oAinsGVdZCS1i6jMaVAs2uA+Iy24TpD8TO9R5sKYgH4Eg0wRGOSl5PKLXErqrT/UImL0wXTylkFE01n25gE4sK0n471Zt7R1W23HyDW+ktOhwIY/UDMmGgDoJ+I749BvIPPiktkhoA6Asx7xEEw3S436NelaihyacyAAD95lkMxUCExmneCRBZycvBgf9yoQm1NMg31MVfPchMzPWB7TzjQB3MEsCSje89bFqf352o3HPZ0+Ck1o2Mo+qeNuR0fSPGBa7teltQlC0WSw9hdjyScATNi00O9JTv7UGJxLq0Eu+Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 15:50:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen: Add MISRA support to cppcheck make rule Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> From: Jan Beulich In-Reply-To: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0386.eurprd06.prod.outlook.com (2603:10a6:20b:460::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b7e43d1-c030-44fc-3e60-08da430c7f52 X-MS-TrafficTypeDiagnostic: VI1PR04MB3215:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ATkGImlGACN8OW97LNeuf3TDsP7Y8CfA7517v1W7l5RcmmE0xEu9WUIBO+kBYSuOlBcD+hduZA/DZAomEDkwqD2FvJJFdaUb6hyu8vH/V83t8LcdXfpMW9DftcqLpYtn1OaP9/bgF3xn3vlRkWv87dHUB7tr1Ay35PzMEe8Ki1GwG3IdPE9K0T6iajC8t1NBZOBr+UW9n0CEokAj60fjX1YjODYwIMac5+6PrOlh2BxdrfdfMng4Cx2kMw9XPw+RRuOdbSXzjXel6pmC88Gs4tAx0sJ8AVUarDPwbhiqvFCiB+IFlwaynRY7O3MHb3h5Fmx1Yep6GAR7Q7PR1OPvyuxorqffLn5GpBPTmk+8zbYfcMdZzBdzIlg1SdCL3E235TzQ9f6XaTyqIP0il6Me0M/zd+6hB27xBbHEPZXbgJBh8omgcqyendKs3EyMbKl0Jmgq5P1eGVgTMrW/+94cRtkTysKOymf9bgoAL5/LaaE3/IPD3lZXNPW5lsVMNjt8FmxX6/vlfk1Zc+CXxWqlfjeEeIJhXbzMLWoOAMAQHb5GIWPGwf0CuqT5x9cTJ4SK2FhkxouxpeN82SZDkQkx2O4x5jONwhFcn3GOFOhY0M2fMnpncCR+0qYVXjGvbmbitqMW7ELN8PHOayS0V64oOdxrV5AFUofqhDwbu8RmqME+ImN1n4IEwO9IWa4pwpEZUtD8/7oi8jnbTctNbK+fpmOnchg7LvdEGBGvftF0SIM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(53546011)(2906002)(6512007)(26005)(83380400001)(186003)(2616005)(38100700002)(8676002)(4326008)(5660300002)(8936002)(508600001)(86362001)(66946007)(6916009)(54906003)(66556008)(66476007)(6486002)(31686004)(31696002)(36756003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZWOUs1VDduT1NDVU5TSW9RK2lVUUxaWHZFbEZMMjJaSFVXK1dxdk00WTI2?= =?utf-8?B?ekFoU24rU2hTcHVzVXVOZXhaSkdBRFlxTUh1b2ZUSVpvcWZEVlNkd0VsMjhu?= =?utf-8?B?ajltWTZHUlRJeGFxUlkyem5kRGcrZ2szcnBSY3VSdkU3QWptTGdtRmZPTHdn?= =?utf-8?B?eWlkbkZQYUYrVzFuUC9jblNGRCs4dE9JQzB0WVVEampVUmFFZGlFVU4xdVd1?= =?utf-8?B?dGtWRWZOcEFjTkpZUnp5UWlYOGxCU2VQb3VmYXJPVWxzdk5HVE5Ic1EzWmR5?= =?utf-8?B?czJCd1RtTDBTVVAwN0hZRC84eEpVMUdNeDhPZDdNL3FCaUdrK0lVTXAvMlZI?= =?utf-8?B?aTNkd0tEWWJhNHdBRDQ2b3hOUk1reXZ4dHJlSmVNaVNuQkh2ais0bitGdGh5?= =?utf-8?B?UjJUd0FVOGRUb3pKS2tXcGpKdUpzMkI3aUJILy90ZGE2a1BDSE02QUY5M3oz?= =?utf-8?B?L3Y4NTQwWDNBeVpUU2dhU2U5dGduOE54eTRPNjgxTXdjbGw0dUtNU0VFY1k1?= =?utf-8?B?R1gwNDFjUWtQOUl2QTBtRlVicWNmaGFtQlBKSy93d1RoeDNQR01RV1BIR3ZF?= =?utf-8?B?emxUTngxYzlZWTlFV1pqNVBRYTl6OEs4NzIxcFEyVm1BeHJGazFIaDZTMXhr?= =?utf-8?B?VGJYb0RqUzRtbjA3UzN5WHIrM1ZkeUd5aTNUMEpDTDlIRGVETzJZMzZ1N2JK?= =?utf-8?B?OURJeStSL0FvSlBJZGJVdVFFdEtobXdOamxaaUt3Q1pUb1dlTXZzaWtPMjJz?= =?utf-8?B?RkF5dXhZVjl4NUVXSWp6U1BLOVhRYUwzOTBuKzBCNWZqMHM1cWJmQmRTYXo3?= =?utf-8?B?aUw5RjVoYlgzdUJJRHMxM2I4ZC82cjk1aGtCTU10bXJSQWt3cWJsTVd6ZmNJ?= =?utf-8?B?WWFZbDJFOVUyS2pHSjhYUHRwWS8zQU5uWHZaWHl0RG53MUZ2Mkp4MnJPUFlo?= =?utf-8?B?Z3FCWjZZSkNyWmhwdzFrL1Y1QW42Nzg3MFJOV2xOSzQ4YXU3QWZrbXlwL2hO?= =?utf-8?B?Q2wzbWllakFteS9SeHlpTExHQVFrbmpkeUgreUpOZEY4YkxiV2syc2l1bEJl?= =?utf-8?B?VGtjN2pSd3RPcjVjaGZrTlhET1cvazJpQ2Fva0tPcVpJaDRGc0Y2TmFDZG5T?= =?utf-8?B?bDBLUzl6MGpSRWhieWtTcFpvb0tmeXMrTzFmZ3Vmenl5UXNrd01mNS91UUVJ?= =?utf-8?B?S25RNTZGc3RwTDV0YlMvSHVZSzh4UWlGeEJGNmZuQmhOQ2RuK2gySjJubzVB?= =?utf-8?B?OStNZFB3Y0syT3lWc0UvS1QxWm15M3BwSklLZTEzOWg4Y0tjeitlYytKWWhN?= =?utf-8?B?REtiUEJQU28vMDBBUDV0V2hPaXg2TDRKMzNLSzkrTTB2d3YzM3BoUVdyanQ5?= =?utf-8?B?RHZNSEFmamtzQmljMkpFbm96UlUrMWszL3VDK0s4S09vblVtOVFMTVhhWWtx?= =?utf-8?B?cVlqTm9nN2RMWmhwK3laUzVKcjE3eFVKL3M3UEJNR0I4K25HR05GL25QdU5Y?= =?utf-8?B?eDJZTHBKanlrVUw4MzNXUE9lZ3BKQWJ5TmJlaTZubkpNRWpvbDc4OHNuc0NZ?= =?utf-8?B?VVpaZ240NkRyS1hPOHpicjdlSS83MzUyOVd2Zjk2dEJDbjFpS3hoWnFRaXV1?= =?utf-8?B?Nmt3WHk1MHYzeWRzSXJjckN3b2xFWnZnZFRJZFNPQlRNN3N2WFluV3BWdUQw?= =?utf-8?B?d2hQaTNNSlZyMGdNYWpXUGE4TCtDVmZobk1ub1piR2pQV1dHRFJqQWRVSHdy?= =?utf-8?B?OG03ZjM0bW9sMm4vZmtyUmNVVnhpRnc5VVA2d2ZLUjBNN0cvQ0ptTzdQSXUw?= =?utf-8?B?cEI2M0ZpcnZBNDRMS0Jhb2hpQ09USVVjZGNseVNaVTUrQjkrWDdEblFpdUhY?= =?utf-8?B?SUtVUzRMUGxyWi9uUmp4bkQrUkdiWUpjaG5mVFJFMGZqVDd5UHp4RU1sbk01?= =?utf-8?B?M3dESHU0dlVFZ0JFcVNGaUE1S2R6Mnd1eVcyT3BSNUlpbDBvNlgydVJiZFhn?= =?utf-8?B?K0xLNEdWVXdOaGxkSGhveE4xNGVPdEtBeFF3SnYwR3k3NGJJSVVuMmlVd1l4?= =?utf-8?B?VVIyVHBqdzFXbEZUK1lxcFdjWGhiRDRGYWlnQm1GcnhSUzNMSzYzWjdNcTlR?= =?utf-8?B?ZW1MSWlYbzErdlZDY0poNW5PaWp6SWhjMFBpRllNS3Azb0tWbDk1MFcwTnpn?= =?utf-8?B?VmFzaUV1QW5pRHFwLzQycWxYSGhQUGRkVmZwTmxrWVBVdkZyK3JpeDVWbGdS?= =?utf-8?B?RG5xc2YxQm84akxXSmZ0OWVETWNPVVlJRzBiS2xnZ2FJTFJ1VWhWQncwTmNp?= =?utf-8?B?dGhlRmQ2dm02U1dRYWRPckQ3bmpHVncxakNDN0NkV09vK3RjeUtQdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7e43d1-c030-44fc-3e60-08da430c7f52 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 13:50:18.2361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NWZxWI5bdY9Ikb4BGtr2D4L0+jCVL5aZHl68bzPsIncHKm6VrelfrHm0b2C/Eo/bDqLYH45bz16HsWkHb1nvhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3215 On 31.05.2022 15:30, Bertrand Marquis wrote: > --- a/.gitignore > +++ b/.gitignore > @@ -297,6 +297,8 @@ xen/.banner > xen/.config > xen/.config.old > xen/.xen.elf32 > +xen/cppcheck-misra.txt > +xen/cppcheck-misra.json > xen/xen-cppcheck.xml > xen/System.map > xen/arch/x86/boot/mkelf32 Please can you obey to sorting here, inserting next to xen/cppcheck-htmlreport? Seeing that xen/xen-cppcheck.xml was added here by you at the same time as xen/cppcheck-htmlreport, may I further ask that you move that line to where it belongs as well? Additionally I wonder if you couldn't use just one line, specifying xen/cppcheck-misra.* ; this could then also hold for the _clean rule addition further down in the patch. > @@ -703,6 +716,21 @@ cppcheck-version: > exit 1; \ > fi > > +# List of Misra rules to respect is written inside a doc. > +# In order to have some helpful text in the cppcheck output, generate a text > +# file containing the rules identifier, classification and text from the Xen > +# documentation file. Also generate a json file with the right arguments for > +# cppcheck in json format including the list of rules to ignore Nit: Missing full stop at the end. > +# Replace current by goal in the dependency to generate an analysis for all > +# rules we would like to respect. > +cppcheck-misra.json cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst > + $(Q)$(srctree)/tools/convert_misra_doc.py -i $< -o cppcheck-misra.txt \ > + -j cppcheck-misra.json > + > +# Prevent parallel make issues as script is generating both files > +cppcheck-misra.json: cppcheck-misra.txt With this dependency the earlier rule should not list multiple targets (and it generally should not, for not being a pattern rule). If I'm not mistaken the way you have it the Python script would be invoked twice, and all you prevent is that it is invoked twice in parallel. And then please use $@ inside the rule. Additionally, with the script being an in-tree one, the rule should also have a dependency on that script (such that the targets would be rebuilt if the script alone changes). Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 13:52:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339645.564521 (Exim 4.92) (envelope-from ) id 1nw2Ip-0005ex-En; Tue, 31 May 2022 13:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339645.564521; Tue, 31 May 2022 13:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2Ip-0005eq-Bd; Tue, 31 May 2022 13:52:55 +0000 Received: by outflank-mailman (input) for mailman id 339645; Tue, 31 May 2022 13:52:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2Io-0005ek-AZ for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:52:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f640eb7a-e0e8-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:52:52 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 09:52:49 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6301.namprd03.prod.outlook.com (2603:10b6:a03:3aa::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 13:52:48 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 13:52:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f640eb7a-e0e8-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654005172; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=P50d2cIm7kn+eFdB7UGO7iqgfOSzdyVrPeqX7LdpKaA=; b=MjXUuXN25dvHI+MxHjzyaj/tAYRHOXLIeeOqH7pUJG8JReGTqMdqxdWT 35l8+m8+z5BGFwz6u3AvLJaFXQHQY2FpoIDhc54ywVq7F4fz0pZHW0vK1 TkveGE7iWh2HnBum0+6iY0ivR9HyFC7a8bFoQIFtZuL4Kf1rIQsNzPigW w=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 72530620 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Po/+jKpA0ucsZ6uP1mxESX3aH8FeBmK/ZBIvgKrLsJaIsI4StFCzt garIBmCaavbNmDzLoogOoSy8k1XvseHyYIyQQVr/ygwQntEoJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 oqq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBPPWdmPVDdDBjLH96AqNk5KHmfCiYvpnGp6HGWyOEL/RGKmgTZNdd39ktRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkGgnFs3aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3P+PFvvTKLpOB3+KPSNsOFVp+yfOFYg0CZo 26dpDz/CShPYbRzzhLAqBpAnNTnkTvgXYMOFJWx7vNwnECI3WsXFQEXUl2g5/K+jyaWcd9FN 1Yd/CZoiKEo7VGqVfH0RRj+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ mGOm9TlFDl+qoq/QHiW9qqXhT6qMC1TJmgHDQcbSSMV7t+lp5s85jrURdF/DOi5h8P0Ahnr3 zmQqCE0wbQU5eYA17+65kzAmzKhvN7CSgcv5S3MQmu/6gpzIo+iD6Sz8kTS5/tEKIefT3GCs WIClszY6/oBZbmPniGQROQGHJmy+u2IdjbbhDZHHYQl9jmr026ue8ZX+j4WGatyGsMNeDusZ VCJvwpUvcVXJCHyMfQxZJ+tAcM3y6SmDc7iSv3fcttJZN52aROD+yZtI0WX2ggBjXQRrE32A r/DGe7EMJrQIf8PIOaeLwvF7YIW+w== IronPort-HdrOrdr: A9a23:hIMZnKjC5v1AcH/9r1CK6kA9FXBQX0Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCJSWa+eAcWSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AWV0gK1XYcNu/0KDwVeOEQbqBJbq Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0md gsAp4Y642mcfVmHJ6VJN1xNfdfWVa9Ni4lDgqpUCTaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd L6IRhliVI= X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72530620" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xv6790iImzoRyx26sREWnVKDXHVukJAe+czRMQ/cawM8PcDyVAMoufv0/KyEtb9B4P/Lh6HLQd7Zb5v1SDhZnITx2XefqetKu1dcuTPOmXbQfNtRmCLT741gzl2v5K8XLZfTG1hx+r3a8fn0lrBm+u6XasVhxUbtk/OSAFM0Maq1ZBzmnLYsNL3otYZBHDOusAoP4V5IXD1RN0oGWSlTzmD+cK4ydsVQcz9Y3aHjRUgUCyaGp5BrjYklqyfcIReYjQ/71BLxZFpVhmEwEykF2MVw1+zPCMOXfzVKYf1xtkaphVcFdYGRt4NSO2tp5q2foe3ykEDFLZKukm+z5m3adA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cIn1C4Yf2sYQVQqc1+sjrjhbdIG+DLfOkbzzWo1orWk=; b=TvM1ZD6Qxk+cz82MPPBZU3z/CF1uM+ma5kI3mK66n4nhbcerRpuACpTKs++8HkpwyJ3vlZb/N0fK2cPIl2sDPi6SnydOpNi3x0fM1h4dDvAPkrjzmVtES8Ck2hk/LTRYjSdCBxySnSSyjSuRNagvcXR6myzwhppgB5wnN8nTd+4iotQOcgUsiZ8ffbH5TP1aXUBYZtw+XUg1igeZcxlO1U9YIYO3ouFQ7wpqBkyoXX1LxzilBaaA7UFLkXdZpV5XK7dRzmXNTWQOSJDPOHVipnrZPIKA6q5YZIO57vQCw47wZr3A0SwEJqLCAxmsYCkFYy7OR0xbGUh8RR/U82lMwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cIn1C4Yf2sYQVQqc1+sjrjhbdIG+DLfOkbzzWo1orWk=; b=MXzEuigqcFmPU+kZACDmgYCDC/6GJriUn7H4jrYpZE79lpxX33/n4Ywfa+A3qbH/I4tWWWmOtYB+B1tGhAEwRfG8W3Kt/PtXEZFjc9VCFxkB8tNByzAijfITzOtxd5YnsH10r2oni+WwbhVYMWi/o1xAhxTm3hS2oA90YGnOm5o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 15:52:42 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "Daniel P. Smith" Cc: Bertrand Marquis , xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Message-ID: References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> X-ClientProxiedBy: LO4P123CA0235.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c8f2822-c557-4844-f03e-08da430cd85b X-MS-TrafficTypeDiagnostic: SJ0PR03MB6301:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W6PTe+ON0qKytxaoTthawYXCUmvxfn7TyYnFZ3vu+h3Wknjbyd6WQSqVo0Mcy+66+AjouEbHqg6sw3aMada1Okx/OAitfUAbxgu3/E2ufcVlG1c7zkzQzG3H0pD5RxKOtEpXg0KJ5ibcyOg8sPrPnXOgIKWZdU8v2MWBqS9Zc1kSAIv6jb6nmI8DpGIbqy7DkNnYI2KGKPC6+E4m9oeveYn0T3wbI7BVchCQWM3EcUNMTN1zrM3LjQT5c6xFokWlz3JP2aUSJ7v3GF8xO89vQxCr8QQ4YbNeim7cLz0eY5XnKoMs2wf9yFBF+z5u1o9yO8ipGiBbPu37gctFbIruWCq5C7Wl5cv+ZXoUphADE0san1zH8HCpQgm3ImfBflynZZ8UZY1su4fJSKBkN4VCIU3Va5B9wK4j7gH/YKcdO9ldVHraFjjFjTBbi0/pdthKACdhKeddDj7vHZpuKXqnLmHpSJ0+4mE2k0kjQWeTC5OEjuc1C8jbXKlT9yRuiub+itj/hof5wwxo231gxYXBS0nj7K0xL5TUUUlcZ6pAyZLzfxJz5vLFs6hPcx7AUf7K+gkX8Iu4+HZJXKNWxzTKS1CZx89lNyDHcl1S6eUzvW8VH29tMSmRc7bLNRvWWGoJ8TOcQu/kLLf2kn01tn8hUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(8676002)(6486002)(82960400001)(66946007)(26005)(85182001)(508600001)(6512007)(9686003)(66476007)(7416002)(4326008)(66556008)(83380400001)(5660300002)(6666004)(33716001)(38100700002)(316002)(6506007)(2906002)(8936002)(186003)(53546011)(6916009)(86362001)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0xCeFFpaDh4VThWRGpENjF6WW1PQmJXOFQ5a0ZUMDBzRWdWajdNVURIRGZY?= =?utf-8?B?NEIxd0VucHFYTDVkT2tDa3BnQXBYVHB5eWx2UXovWjQyRkQxT09ZOXEyQ20w?= =?utf-8?B?ajZsdjdrQlE4YVNlOHZhTGY1OGs5K2tGNHVNWmhwSEtKK0tpODloN1FleWlZ?= =?utf-8?B?ZkNVbitRTURSR2pLNVBBaVBHYlJvRHlqM2J4dW5wbldpWGtUWDE5UGRwbmMy?= =?utf-8?B?Y1djM28rbmYvVE84Y0poTjNyYjFEZ0ZCR2hZTnlRd1ZLb3d3WEpTVGl5bCtV?= =?utf-8?B?VmdlbFhLdUlmc2lCaHZuT2ZZdkRzLzZHWGs5Rkp2QlR5eUhabmNSMGluY2Fa?= =?utf-8?B?bHNHM3dyeStkZ0tvNmI2b01FY0I2NDJCQ0QrZlFFeFNxTnZNQm1DTUNkK09q?= =?utf-8?B?U1MxeXVRU3VhSGNkVUxId1lhRE85TVNZMnFIUHRVVDV1QURYYURiVElEODFC?= =?utf-8?B?Y0lZbGx4ckh1K3FyUklBOTVOM3VvRUhsRHlrRFNSVWRDc1ZUTDAvNkJTQUNK?= =?utf-8?B?L3ZQWnQyMHZPdlB3aStyU3dqYWJvdFpXTlhoUDhHRzdENW5GUlUzUlZvNzBL?= =?utf-8?B?MHVMdi9aKzN3bkZDNmEvY3ZBQmhkWUpwTFdOZE9mNUxCT2hVVHVTVDIyd3A1?= =?utf-8?B?QWxhZzc1MHY2TmVmaGVTU0ZMblFoSWc1RUVuUU1nZ3RTSzgrU09HU3hNYWZa?= =?utf-8?B?VGFCRmkxN1JUdjhob3ozNjNHcEsxZlpsOGlNU0xmRElic0RQdVRIeUQyaDdh?= =?utf-8?B?dzc2UTFaM1c3Y2l2T2NYWFk2M3pPUDlRZDVneEY3ME1IL2ZpempXRUZZSlN4?= =?utf-8?B?WlZHSGdiUCtnbGJlZnRhbkQ2UmxaNTRidXBPOWZnSHFyZEIvUU10aHBRMGc5?= =?utf-8?B?aGx1UThzN24rbU9aNU5NMUMyQWZWRThPS0loL0tmcW5NTFlEZTRidGtvL2VW?= =?utf-8?B?OXE1QnJCUnd0MEdKL09vOWplbHI1LzVYWHhoalhhTVNaZGFVY2dvUmtzZjNX?= =?utf-8?B?bEhyN3BhRklhUzQ4d1k3L01lUkYzdEcwNjJvRkRsUzBKcWx6empTWUg4N3VH?= =?utf-8?B?U0N6dkc1M2RjMVMrSjd5ZzJPQUpBeHRkTzIvMnVqV1NnTmE2ZVBQTkFYbzZ2?= =?utf-8?B?QytScGJNK3NSY2U0Y2tUUFJKd1pTZFVKdFk5SjQ4UWNvSEFtTUUzK2pYL1hO?= =?utf-8?B?NDhzayt0bTZWS1EyMVRFaGVZV2pkMjl2UTArdFZad1dialJ4eHBmQlExL0Yy?= =?utf-8?B?dENZMTgxNjNTNTdCMjNTemZoZ1htMGs2US9kTVlnSVRFemYxVGZJRjU1ZWln?= =?utf-8?B?WGNCMzQ4UkdnQnpuekFpVmphZjdzbjZvVnY5ODBEOVFnR0dpNVBkM1JWN2Nu?= =?utf-8?B?SlNmMmhQTmw2MmNKZFluQXlBbFB4S0JyYm15SEtqemZ5N2lseXpaemxJbUJO?= =?utf-8?B?eDFMY0QraG42OGRadzJYekh4bFdHTlVjS1ExY3FmSU54V3g1c2U5bmo4OHZz?= =?utf-8?B?SkdYcEtrS0RZTDVoN1hYczdCSDYyU1ZhSlFQbFBXSEpMZ05oOTg0dzUzWUF5?= =?utf-8?B?S1BBOXdKMnIxK3Z3cnZFTEh6MTlnd3V1dzZuc3pYSTNTMDRtUTI5Z3lKZWtZ?= =?utf-8?B?M2JLUWdwU0hseXBiMS9QKzNzeFB3VGZkeHBNZ1FTdUlMaytVMWxIQWEwR05D?= =?utf-8?B?OGM0STNnbGpZQTJxWThFN3NWWCtXYWdPZnllQy9MbjU5UlZnaWJRVDhNZzE5?= =?utf-8?B?bUtlUmhHUDhicXkxaWpBeUwwcTl2SVFVSTlLZzBaeXZ6cEg4WVNKLy9lL1dx?= =?utf-8?B?b0hnQjY3ZXJDTEsrZnlzQkRkWWxnYUtwQnhISSt5U25YZnVud1M2ZE4yRm5w?= =?utf-8?B?U3ZmamxRTG5aYnkwV0lZMkRKMHJrVlpGOUJvT1Z0dU9ybk9zd2RYaVBLVHli?= =?utf-8?B?NzNRYXF4NFhqdGZydnlXd1ZxaUNkbHM5UE5vSHcvbmc1ODBIdUtIT09aVWxR?= =?utf-8?B?SVFBcGxwSXF6MFhoZHc1Y0ZSYlg0Q1dxcVhtVlp3RHVDa040cTdubWJKMjJV?= =?utf-8?B?NHBnSlNLQlFqdG52VFAwSHQ4VTNyMHc4dTFnbFFYSHZMQWNGZTQxZEFJT1M0?= =?utf-8?B?MmpYZjhtKzB5QlFLS1kveUgwOVRSQUpidGJRalFvVUQydjZLbWhFM2lSZXhR?= =?utf-8?B?NjV4Z0krNnZWSUFnWnlaUXdhU1M4TDJxdGF0akFOdDVPUDhrZmt0blZITFp2?= =?utf-8?B?QTc3WXJiUFNOVEZVZk1JeFNFNlJDK2R5bHNrd0h5UGsxakZrdE9zQjhuOXgv?= =?utf-8?B?QlZERVdVRFJ5K2cwbmIzU0tBZUlyNVlmVUpyMUFzdTQzVlFqdzg3dz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8f2822-c557-4844-f03e-08da430cd85b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 13:52:47.8355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iogy5yYYMMkW0EHjK2zF2wfjJDOzVcgJRpSJB3eeu8NvTNsA49bXBzXzX8enYJxd861I8CPW9ISzpOraD1tcTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6301 On Tue, May 31, 2022 at 06:45:52AM -0400, Daniel P. Smith wrote: > On 5/31/22 05:07, Bertrand Marquis wrote: > > Hi Daniel, > > Greetings Bertrand. > > >> On 31 May 2022, at 03:41, Daniel P. Smith wrote: > >> > >> For x86 the number of allowable multiboot modules varies between the different > >> entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and > >> x86 this value is fixed to values based on generalized assumptions. With > >> hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large > >> allocations compiled into the hypervisor that will go unused by many use cases. > >> > >> This commit introduces a Kconfig variable that is set with sane defaults based > >> on configuration selection. This variable is in turned used as the array size > >> for the cases where a static allocated array of boot modules is declared. > >> > >> Signed-off-by: Daniel P. Smith > >> --- > >> xen/arch/Kconfig | 12 ++++++++++++ > >> xen/arch/arm/include/asm/setup.h | 5 +++-- > >> xen/arch/x86/efi/efi-boot.h | 2 +- > >> xen/arch/x86/guest/xen/pvh-boot.c | 2 +- > >> xen/arch/x86/setup.c | 4 ++-- > >> 5 files changed, 19 insertions(+), 6 deletions(-) > >> > >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > >> index f16eb0df43..57b14e22c9 100644 > >> --- a/xen/arch/Kconfig > >> +++ b/xen/arch/Kconfig > >> @@ -17,3 +17,15 @@ config NR_CPUS > >> For CPU cores which support Simultaneous Multi-Threading or similar > >> technologies, this the number of logical threads which Xen will > >> support. > >> + > >> +config NR_BOOTMODS > >> + int "Maximum number of boot modules that a loader can pass" > >> + range 1 64 > >> + default "8" if X86 > >> + default "32" if ARM > >> + help > >> + Controls the build-time size of various arrays allocated for > >> + parsing the boot modules passed by a loader when starting Xen. > >> + > >> + This is of particular interest when using Xen's hypervisor domain > >> + capabilities such as dom0less. > >> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > >> index 2bb01ecfa8..312a3e4209 100644 > >> --- a/xen/arch/arm/include/asm/setup.h > >> +++ b/xen/arch/arm/include/asm/setup.h > >> @@ -10,7 +10,8 @@ > >> > >> #define NR_MEM_BANKS 256 > >> > >> -#define MAX_MODULES 32 /* Current maximum useful modules */ > >> +/* Current maximum useful modules */ > >> +#define MAX_MODULES CONFIG_NR_BOOTMODS > >> > >> typedef enum { > >> BOOTMOD_XEN, > >> @@ -38,7 +39,7 @@ struct meminfo { > >> * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. > >> * The purpose of the domU flag is to avoid getting confused in > >> * kernel_probe, where we try to guess which is the dom0 kernel and > >> - * initrd to be compatible with all versions of the multiboot spec. > >> + * initrd to be compatible with all versions of the multiboot spec. > > > > This seems to be a spurious change. > > I have been trying to clean up trailing white space when I see it > nearby. I can drop this one if that is desired. IMO it's best if such white space removal is only done when already modifying the line, or else it makes it harder to track changes when using `git blame` for example (not likely in this case since it's a multi line comment). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 13:54:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 13:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339655.564533 (Exim 4.92) (envelope-from ) id 1nw2K9-0006KJ-TS; Tue, 31 May 2022 13:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339655.564533; Tue, 31 May 2022 13:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2K9-0006KC-QK; Tue, 31 May 2022 13:54:17 +0000 Received: by outflank-mailman (input) for mailman id 339655; Tue, 31 May 2022 13:54:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2K8-0006K4-4B for xen-devel@lists.xenproject.org; Tue, 31 May 2022 13:54:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2823d663-e0e9-11ec-837f-e5687231ffcc; Tue, 31 May 2022 15:54:15 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-xL8jQEicOPu0w72fvyHefQ-1; Tue, 31 May 2022 15:54:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7575.eurprd04.prod.outlook.com (2603:10a6:20b:29c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 13:54:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 13:54:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2823d663-e0e9-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654005254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Us5R4VsO1R4Ot8DRk2rKDbDqbN8gvDQoF4WJJAeZrWA=; b=H2wxZvRhLiW+v8QA3jAWeWjSms+PiWGFeu+6l1nxNfvisEGlP/Cc5ZUBnohUNRGvv2HgT8 rt6KLl6EfNLRW8z8Z7sCTObhD9mySOSbwg1AOZBZQDFU92UPk9bHaSbAeOHtKQZM1JaWA1 YPYqs9Yp3JIG9NjgkGce0Fxk7YYElAQ= X-MC-Unique: xL8jQEicOPu0w72fvyHefQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JuWKW6+pzoffZIN0+31ni16SLulr/sQWor5Feo9FerRzxKNhxvqqxhq54FzQbjk/3EezL3BGagnkqvrETHwFHI8yqbJ66LtAF231RWJLGfTd61xBbP46Av13rLkinSuC2u6mDynvIJ1ZcW9dSYqC0SbbbxjnvhdQR3hIgGCvYI1bldCksQPn2l+dQBOhE5Yg7z2hA+PBvX7+CS4DuW+xXDeB3wyHGW8/u/HgWhzfzw9BXh/FyAbU1g7e0QVIYDn2SXGnNhWJKAa1FFyvsEFiKjMg0vLycMATVHflK499Aicw/iP4L62Tb+u1f8uyxjjYhwl97ypwBfVN4KdgWu6Ldw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nMOZ9lOX2mNrBi6/JYl8p98MUBZnHa260B069jDXq6c=; b=d6iHhS88LRaEAb7b/L0K6q1rU5UA90R127M4l0MFRxYoQvXqTtt5HBCAryqWJBcnotU6EiNt7zirEMAgtEOw4JZjhuhS4ESJ7/ucdGmyYey/GPaBudmYWM6P8swYQb3+A12kvTKFkWIGqMD494T7DHTl+Ou46PDpLAt4chS6bQYBpk4xbIred7H3KLkClnXQflto7Nk8+4FYLKltT5d8G9+/AWe0Kv9CMGOwNSuXTpQsD7fYSFtcjpGvFgX2q5r/2WllSkXnNKnw3R5IVqCJkn6iMjDFcJTYkNaLMZpgJWdruCpRh9vp2k+pi3E5cnKmik9S52XXmbVpgjTciBNZcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <02cd3ff9-85d6-61f8-6e46-7f0240c1cf7b@suse.com> Date: Tue, 31 May 2022 15:54:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "Daniel P. Smith" CC: Bertrand Marquis , xen-devel , Volodymyr Babchuk , Wei Liu , "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , Andrew Cooper , George Dunlap , Julien Grall References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <20220531024127.23669-2-dpsmith@apertussolutions.com> <2F13F24D-0A55-4BC3-9AC6-606C7E1626E8@arm.com> <4ebbb465-00ec-f4ba-8555-711cd76517ed@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM6P194CA0047.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 644b16af-8704-41d7-fe10-08da430d06e4 X-MS-TrafficTypeDiagnostic: AS8PR04MB7575:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rH/jlxB22Yr4LwX5+IW7wKKxPoBH5Xevbrfo87PWr5jHHxDro/OlpuJSGZUjp7COlwGlIOpbnXLJ/Z6kWt5nkwvr6THg0QLhnFzWM/oODMlUW2w2QeOgtENTYDEWBbxhMPpWrSqemJn0NpS9FJg0M5ITbzywuk7hwyGCCuxLxbrCIJB/ZYQd5yxA+NDpMQf+Vyi/yAED/AHc2z7hJET3imVhGtswgcpJ0zpbSS5Xuo98eO0BvhJj2R78gTJf2iSzk0JuyKF+oIDzL4eoS8swH/c104GfYdeMESg1viYmvS1cKQFAtXGOSEjY/lnP7e9cYqYkGBYU6PR72qm4GMY5GxX6ge0UFhGOiTEM+7ZJLUAkvqhHPek6PVLBTLkJtGreBO2432Kb7a+0SO1zqiWqE4qZ3ZYLmPpcOzlZixI/HFNDeJw4VZcvc57s6KpV32cdlmCoJG14lewb1ryIT2ISThUvnMKd2cafmNWXX3l7WbEYULfg/RWUvQ+ySRUeWZTX/mDLkz4J+2EQBJHhZynTVkOSHP7pKCfrOCjpmM/AkaYntlzNNg3BVXQTAv5+IzJcBuE6kBofniSISPOeMDd0UzwpZEv6jYGWAj0CSyfo8UqVSxAGRbhFI4JMCzZLqjAkV8M1e7Fv798jY8S0/GQyHq9awpa184HE4fKJLoPnX7vjll0KJqPS1bNrcwVYtqrYbSo5YmN/BTX3dAAU5qPUt7HrYqM0NZiolLvosFSJhodxjXD8YBwuihTVMFR19GtN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(66556008)(66946007)(8676002)(4326008)(26005)(86362001)(66476007)(6512007)(53546011)(110136005)(31696002)(54906003)(6486002)(316002)(508600001)(38100700002)(2616005)(186003)(83380400001)(36756003)(8936002)(31686004)(5660300002)(2906002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5JWX7GkqcKEHVICP3MncdxFQQ4A907waFKiARt5bG5CMTgoHj2cOh1XXwcm5?= =?us-ascii?Q?8tPt23HQo3rynjhv9arQzq8t/+3darGyuHUT2cDUBZ9Yzs+rVMYw2SlCGM4I?= =?us-ascii?Q?j6vjOKY8z1i4nSeTl4hRDzj4OGqTKqNpMSq8XeDTjWbkWz8bvJdGbfHYynyc?= =?us-ascii?Q?hkjJPeSx299Bhm8zbntBAEMVnuTX5Dl98h98clzny0EWYWrnpRWiOXwG44Cs?= =?us-ascii?Q?H41K9TCvnuJ+6+9ENMC2YvHSKq5fM7RwurrKqWMmfo/anAnUbtTbFvAZdgpe?= =?us-ascii?Q?bJBXd8SzzfpfWZUi/knl7sDEGB9c5H7pGxD2hQsNSZIhg1KO3hnQ7thJ4Vua?= =?us-ascii?Q?mdnplzFjlemlXh6DQgAVJpdTMc68OiE7OBLl+ITlbfEXnUd082Oy5DmoRNBR?= =?us-ascii?Q?XbUd/lPF3PcdW7njYcCq6wsKkkzvnw4iwYWK9OG1oY5EG5kLSAFH2lA8YnM0?= =?us-ascii?Q?8HKCKDpY/lYXCGtXjRP906kYwHI9j/3VNtgEb8VqWpefZaBtQHQ8R0NLV8st?= =?us-ascii?Q?9NK/OIL/CJTMJP9+KAcR49m/1XFRLSeCdV/vatUvLhVelEF/N8XqzHRuC4EK?= =?us-ascii?Q?i1n/pxOb136qIvyiOPmXrcDOk+kEZvXkdl3FDFrYJEqHO/juVxeucBKNhLcV?= =?us-ascii?Q?2CRX/eHgtXX38r/NE2wz3z2VZNU+UGVPnAPfIcN/w+hTdpE/7FOwDobQz0Ui?= =?us-ascii?Q?+v9QDlAou04F7rVF4Shz3tcfr3k19b9yEljKZr8MLrzd6Mjak9nFG6lRd8HO?= =?us-ascii?Q?7JhDVSW7eK5Ot4WErAJiEMTzUbDe/xEMHwKZXUZ4MtAeW8cNX1IeLL35LJqz?= =?us-ascii?Q?KZZ8ybaxc9O18okSsVbmMee1ZUlQfx+qzdJRu/y3tNCNpjrgq8tAW4vMnzpq?= =?us-ascii?Q?qqUVrk63qcN/ZjaUcZ+6uaG87AUKPCMorT+B4p4udvSEfwlh+CiCrlPIZDUS?= =?us-ascii?Q?9NJbT9blzvW+qWGaht9WkDlVK5SxdetZ3HcCs3oB9lzj+mlW5/bw4YH1RcYa?= =?us-ascii?Q?WquMbmS1+wwuMXM5QbM1J/2Ii7Af5g+0LtVMSDJvOA9hXVcMBUOwdSEikPO/?= =?us-ascii?Q?Q7rAZ8PkVEp53ouEn/wgK+/O5X1cdewCpK7GzgaQ91Tzx7bwlRZNsNeRKjTI?= =?us-ascii?Q?JuDpAwyU/Woqn/btE1gUFwzBjSasYtr+bDqL1J6H8F19tsLx5B3MPuE7Pc52?= =?us-ascii?Q?ccP00xVjaXEnhBA1F0i1ecr1MA8RUcafdsQ5GDUM28WKwKaMyGr4HxuBcSWh?= =?us-ascii?Q?ml/LNBUdeZ4cQBcf6PEdt9Td4eTZ90lqzHn1IarEbMsqvAxFktpuDKMVXkOT?= =?us-ascii?Q?ympEBs0CpQANAH64jEQZRZLkMK/6M05S6NQ95oyHhtwpmDpc+axme7S86NXl?= =?us-ascii?Q?cqSqY9eCNvGxIfqlABkEAaJtGdYUNjQodlQkHAYfwWRDw3pIm1QfCicuVVBd?= =?us-ascii?Q?GT8JdQ3ZYHUcBe8JD1xZ30Aax5ZYfa2KVRA2HUVBYxMH6GRoR4YKuFb9U/0t?= =?us-ascii?Q?Jfg/LPf2JJBo44qTVwEdMj7rOAzWFYgEWVLAra29dcEYyZl7rsQZqvvUqVtt?= =?us-ascii?Q?wJ8rzivoEBwmlwGGbtT7fi0qb0mCcQHux0nusfKDka7F+kKxRyfpQm9TaeLQ?= =?us-ascii?Q?kSRDrZeFRrdGyBSgB8w+7S0oSUNsKh1GgQmfyfVYG4OktNom2edojskPxIEj?= =?us-ascii?Q?tebu0KTXQVUNX2RS4sr53yua/EfQcUjfzVviZ++5YDoYq1jZ/4O+IdzN3LHh?= =?us-ascii?Q?Fjk5mFPecg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 644b16af-8704-41d7-fe10-08da430d06e4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 13:54:05.6902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SO1P0MxWcgg6Ca9cyi2lX67muqNZkIKgURzj/kcytQkECtl4pCAU5P0obYBrQSCGAwb1waeBchOjpLwcQ4Xo1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7575 On 31.05.2022 15:52, Roger Pau Monn=C3=A9 wrote: > On Tue, May 31, 2022 at 06:45:52AM -0400, Daniel P. Smith wrote: >> On 5/31/22 05:07, Bertrand Marquis wrote: >>> Hi Daniel, >> >> Greetings Bertrand. >> >>>> On 31 May 2022, at 03:41, Daniel P. Smith wrote: >>>> >>>> For x86 the number of allowable multiboot modules varies between the d= ifferent >>>> entry points, non-efi boot, pvh boot, and efi boot. In the case of bot= h Arm and >>>> x86 this value is fixed to values based on generalized assumptions. Wi= th >>>> hyperlaunch for x86 and dom0less on Arm, use of static sizes results i= n large >>>> allocations compiled into the hypervisor that will go unused by many u= se cases. >>>> >>>> This commit introduces a Kconfig variable that is set with sane defaul= ts based >>>> on configuration selection. This variable is in turned used as the arr= ay size >>>> for the cases where a static allocated array of boot modules is declar= ed. >>>> >>>> Signed-off-by: Daniel P. Smith >>>> --- >>>> xen/arch/Kconfig | 12 ++++++++++++ >>>> xen/arch/arm/include/asm/setup.h | 5 +++-- >>>> xen/arch/x86/efi/efi-boot.h | 2 +- >>>> xen/arch/x86/guest/xen/pvh-boot.c | 2 +- >>>> xen/arch/x86/setup.c | 4 ++-- >>>> 5 files changed, 19 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >>>> index f16eb0df43..57b14e22c9 100644 >>>> --- a/xen/arch/Kconfig >>>> +++ b/xen/arch/Kconfig >>>> @@ -17,3 +17,15 @@ config NR_CPUS >>>> For CPU cores which support Simultaneous Multi-Threading or similar >>>> technologies, this the number of logical threads which Xen will >>>> support. >>>> + >>>> +config NR_BOOTMODS >>>> + int "Maximum number of boot modules that a loader can pass" >>>> + range 1 64 >>>> + default "8" if X86 >>>> + default "32" if ARM >>>> + help >>>> + Controls the build-time size of various arrays allocated for >>>> + parsing the boot modules passed by a loader when starting Xen. >>>> + >>>> + This is of particular interest when using Xen's hypervisor domain >>>> + capabilities such as dom0less. >>>> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/a= sm/setup.h >>>> index 2bb01ecfa8..312a3e4209 100644 >>>> --- a/xen/arch/arm/include/asm/setup.h >>>> +++ b/xen/arch/arm/include/asm/setup.h >>>> @@ -10,7 +10,8 @@ >>>> >>>> #define NR_MEM_BANKS 256 >>>> >>>> -#define MAX_MODULES 32 /* Current maximum useful modules */ >>>> +/* Current maximum useful modules */ >>>> +#define MAX_MODULES CONFIG_NR_BOOTMODS >>>> >>>> typedef enum { >>>> BOOTMOD_XEN, >>>> @@ -38,7 +39,7 @@ struct meminfo { >>>> * The domU flag is set for kernels and ramdisks of "xen,domain" nodes= . >>>> * The purpose of the domU flag is to avoid getting confused in >>>> * kernel_probe, where we try to guess which is the dom0 kernel and >>>> - * initrd to be compatible with all versions of the multiboot spec.=20 >>>> + * initrd to be compatible with all versions of the multiboot spec. >>> >>> This seems to be a spurious change. >> >> I have been trying to clean up trailing white space when I see it >> nearby. I can drop this one if that is desired. >=20 > IMO it's best if such white space removal is only done when already > modifying the line, or else it makes it harder to track changes when > using `git blame` for example (not likely in this case since it's a > multi line comment). +1 Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 14:03:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:03:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339665.564544 (Exim 4.92) (envelope-from ) id 1nw2Sc-0007xQ-QX; Tue, 31 May 2022 14:03:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339665.564544; Tue, 31 May 2022 14:03:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2Sc-0007xJ-MT; Tue, 31 May 2022 14:03:02 +0000 Received: by outflank-mailman (input) for mailman id 339665; Tue, 31 May 2022 14:03:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2Sb-0007xD-1n for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:03:01 +0000 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [2607:f8b0:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60c44cff-e0ea-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 16:03:00 +0200 (CEST) Received: by mail-oi1-x232.google.com with SMTP id w130so17581515oig.0 for ; Tue, 31 May 2022 07:02:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c44cff-e0ea-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zSsDGmPBqc1850fXMxxYy77h0suShb99cQI9DzpTn+8=; b=BoZZawlLXMLqxyuY4/8YSEJfQBy4GSO9j2NFQonAgKUx38zInyQBAAsu028kkBeY4/ EWrEgj8JKcK3gjTpbBLO/hDZQuvf7NK4Ucvonfgxmfrc0nR3aV5IxARtRkSChcAOyUGH fZUp7hpCN97Nr0N5G72fbztZXEgroQZUf4y8zJ0ICznxwwcjxXWlLZ6hOeJ8KhA7kxHY 3PyzHAHqugoTIIUILcHqNnutUpPTIzpUW8Wwg62JXjUGpjx6Qe1go6gq+bKI2BO7J093 hYisqTqf7Sg3k48IprW9DX6V14+GdfrBorB4cJR70cn56+b1Xq/a19wePRHt7r45h5sg oQnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zSsDGmPBqc1850fXMxxYy77h0suShb99cQI9DzpTn+8=; b=nYAgAqZM+HrgKLPoAx6+hZUkTdECmxO3CLlNx7iW6Aprv+Fly2tscvVNjzhl0FE0ZO H7M/Uq/mSOqRTov9hOmaG582BM2KvymO8tPdVX9Zkc8RWCDEE+BcK0xmOHeX5G4jfqOh 9B3v2RE0knyLcLnPEqFlYZ+sSW6IU9y/ox+O0NxTDDoy6WkMRMhmthgQYm9chXKEGvlB x7XdFmURrUMqz8qsMFfuH2zEpZkxiAGO1p5bA3rq3C8Pz2dmVOKB0AUAsfSG1TM0yDJf Cot0SpKN1ybUuxJmJqqjZIDp9OvmWYo9hWEu3jhJ6GZW/iEq7o61qmQSCt8UTJrY9BuH e4Qw== X-Gm-Message-State: AOAM532JVELWIonJe1viLKz5BW10p1t6ODuLD9oqadSs9zjuQuC310qJ 3iR4WitTCzSaPN8xVUKbpycOHi2bhRy0W4Fc0dY= X-Google-Smtp-Source: ABdhPJxcOP3uljOuiNuxyefdakdbso4LHWx6ApDiZfsH6aS7Gpmq9fd+9szeUlsBhjgyyYZWQ9Ed1xBYttWfHDhQ2Mc= X-Received: by 2002:a05:6808:180d:b0:32b:d6a5:524d with SMTP id bh13-20020a056808180d00b0032bd6a5524dmr9510814oib.9.1654005778677; Tue, 31 May 2022 07:02:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Tue, 31 May 2022 10:02:23 -0400 Message-ID: Subject: Re: [PATCH v2] tools/libs/ctrl: rename and export do_memory_op as xc_memory_op To: Anthony PERARD Cc: Tamas K Lengyel , xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross , Andrew Cooper Content-Type: text/plain; charset="UTF-8" On Tue, May 31, 2022 at 9:43 AM Anthony PERARD wrote: > > On Thu, May 19, 2022 at 01:16:35PM -0400, Tamas K Lengyel wrote: > > Make the do_memory_op function accessible to tools linking with libxc. > > Similar functions are already available for both domctl and sysctl. As part > > of this patch we also change the input 'cmd' to be unsigned int to accurately > > reflect what the hypervisor expects. > > > > Signed-off-by: Tamas K Lengyel > > Is exposing do_memory_op necessary? This kind of looks like a revert of > 35e135f116 ("libxc: make xc_memory_op library private"). Anyway, if > there isn't a better alternative: Acked-by: Anthony PERARD Thanks! For compatibility reasons it's easier for tools supporting multiple versions of Xen to have direct access to xc_memory_op instead of having to look up different versions of libxc functions and cast them via dlsym based on the Xen version detected. It also makes it possible to access memory_op hypercalls for which there are no libxc wrappers. Tamas From xen-devel-bounces@lists.xenproject.org Tue May 31 14:14:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339674.564554 (Exim 4.92) (envelope-from ) id 1nw2de-00017l-UM; Tue, 31 May 2022 14:14:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339674.564554; Tue, 31 May 2022 14:14:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2de-00017e-RZ; Tue, 31 May 2022 14:14:26 +0000 Received: by outflank-mailman (input) for mailman id 339674; Tue, 31 May 2022 14:14:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2dc-00017X-E7 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:14:24 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0629.outbound.protection.outlook.com [2a01:111:f400:fe08::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f77fd89e-e0eb-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:14:21 +0200 (CEST) Received: from AM6PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:20b:c0::14) by PAXPR08MB6830.eurprd08.prod.outlook.com (2603:10a6:102:130::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 14:14:20 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::e1) by AM6PR08CA0026.outlook.office365.com (2603:10a6:20b:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 14:14:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 14:14:19 +0000 Received: ("Tessian outbound e40990bc24d7:v120"); Tue, 31 May 2022 14:14:19 +0000 Received: from 6233080cacf7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 50E14D55-93C9-4914-98C6-957D1342AB10.1; Tue, 31 May 2022 14:14:12 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6233080cacf7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 14:14:12 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB8100.eurprd08.prod.outlook.com (2603:10a6:150:7a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 14:14:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:14:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f77fd89e-e0eb-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LPgRh4zBhc8MZ1M1wpJgcdi7hhM5fDFu1oaGkBvmpOglVlE0cSjHvd91Qv9zTAqOdS2SjXtjHwuMLEWYzfq/E1D7eiHHcv5/kQu8rmIWwsradcSwtnAbQ1xGJSdnE62wuMcWTojlrnV4GTn1sqnsVT8tkRTV5/9lGp1DqQMhOujtRToG6fq6Fdx6fBpjdGrPpCVt3cHPyWYaPzggxpXokLqpSdbevPQ1n40matwojlNadGKgYOdQYqJaHI7Us8WgsuU2VMXTW4NWyspxZjQCdgilH1XREhUOIs9UakT/g7Ru4e/6Hqt34GaagJSqzBVfXpJtO3B583+6duBoYNLJ6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XxHEcgMM49qBHPljpDfj5LGFJA9osm1VHxdl5+Cmsb8=; b=lotoNgrF8JD0hA6fkkhny8QGCNl51XceVoRdrG2AWFzGbaQQN2PPs+HKYEm43SYk6m2U45FmP6OTmB7t1e8THsDY/egw3h7ORGaNeedgEz2N8bgc+Ct0mzoBLKIvEMZkeE0GUch7/GClcKrNKVRJ3LxacaKwEkBMi4w9aK5JnqU/FSdAnW857YHD+Oc2mUTPxu/hzmS6eMOskvJ8Fp5tKpdtls3TPEB+21NQ9k1wT823B2ITYbL/U2vcLEROTzInhTlBqxDine+hdLLnYfiJgexUA8T/56sw6fJVU0VK1cKisuH+1RLmXg6MaI0bgYXnQGVyMnt4r9G4cL7SVcXp5g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XxHEcgMM49qBHPljpDfj5LGFJA9osm1VHxdl5+Cmsb8=; b=mT8jIrrcjhqIhUkCQMHMmkT0mmfuTPbTId6TjKgVOTdqkMaTHvzrghSNxtH1SFnHcPsk0CvAi5A2AkQPX7FEX+up8NsV4zz0Li51HcKD3RDRyEdew062Ysj5YZ/psec5vVFmLRnGbqAAixeyhnCxGwopiwD0OJs+i2jaR9LwMxE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4d39288f946aac56 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1cs0bA1goyIJ16z+BO58BZGZ/qxQqppKLo9GiUiTJho2BfbwZF20K/JUwjRAutFipZvGXjB+WFAEoSLxdS7229jQ3Lm4VF5A+WdqoiVX3Piw0CmLtKMduTufYB0wqX9yPmlFC14UlTg2DTgOjLnPpUJprdZCet0+/NU0BFbBB+ydP6AoPMsAlLyT/kxHXgsGNkngwVZhIwLP8Sgnv5aySPVkkbZjkybUBdQJPoK5/7E3GHB9TaR50j2Q54Mw1gqDrpzDdaszkXn8FZoWWBi7OmvKGuPcrS832oGjn/mqlkrSfZejKjCsYAMCmnfi5es05N61EC8wXDeJmnyYtoeMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XxHEcgMM49qBHPljpDfj5LGFJA9osm1VHxdl5+Cmsb8=; b=WWtRE7PZ3FpbMERuqxlcu25D/uNLxHrVJanriJMCytwAhhHhTmp1nHWkHa5MHnfRXT1YFQ4VSuisFH8raZgb5lfbwJPLQnoiKSgwWEizm1JxkjcQE4bJrOwIPd2rirHvM7xyd3fUNedI7HrrWX31GwwuiBZi9WQjRCRZfPErlhDTQT6Y99kboqUBuzhQFVJnIZB90haxUJ3q726Z8LwNSLBzjip1SqKgMt+DT5lujBuDtDztUrNgi5XLEEDhR1/4Yom9kEKUmADoIOsV6eYU3fU+nnKW4lH6nQhWETV/9/5WKmJ9APpXqsQRHUt6Y4OSLK3zUmfkpS1sWbEJdSUT2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XxHEcgMM49qBHPljpDfj5LGFJA9osm1VHxdl5+Cmsb8=; b=mT8jIrrcjhqIhUkCQMHMmkT0mmfuTPbTId6TjKgVOTdqkMaTHvzrghSNxtH1SFnHcPsk0CvAi5A2AkQPX7FEX+up8NsV4zz0Li51HcKD3RDRyEdew062Ysj5YZ/psec5vVFmLRnGbqAAixeyhnCxGwopiwD0OJs+i2jaR9LwMxE= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen: Add MISRA support to cppcheck make rule Thread-Topic: [PATCH] xen: Add MISRA support to cppcheck make rule Thread-Index: AQHYdPKgb8OwohyX90ebe0mOYdpVU605ANEAgAAGrYA= Date: Tue, 31 May 2022 14:14:10 +0000 Message-ID: References: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7fbd7ff6-346e-488d-3b00-08da430fda7d x-ms-traffictypediagnostic: GV2PR08MB8100:EE_|VE1EUR03FT044:EE_|PAXPR08MB6830:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vWT5y4T+RPFSAFTU4HUN6fVh8JEtr+7o4rlFcTA1C/KGuO3K8fFosnnZBXNdfeieaADOLyydPOR+6VfFi01zquxF1q2V+6rA1z8U3zfD+0YPUtoExmyOiDnwOHCdarP/Du4hjiuoOROLOFrw3NgFFqYql0arS3RXG0RWZ6sv391VgwBCqKJAcr+b8qZvcIvVp9N9IMp438ji/RleVoC6/IPSom1ecvv7I72tPCZY81H2mTa0FHnesS8fHIpHrqpkfWelrl76lYVRQATu1xF9H6mT4hffmBADgEBy9bpK27I2OlokcDuGMEa8Am3CXIc4tlhFJFgl8XZGRFNv90PPScyGRpDk0s0XDLIrG5JV/yikpEObX4YB9HSt6CxrTNch7T7gD+hHYjMotbTUSnvJSWn29V95+x6rs1BgaP7F39cDILA1K7gLN5FsUcs6eElHZ87vnlOfvOnYsjCEP1XQcV0uSgTBjI8WmhU1ouIml5Gxg60h2e7Pk44MFVi0AwS3R3OPCFJ3ZMwkWtthATO8jgCWIDFDjLgLHAj6kshf4ffMzY7MQxS0+Z4bCgX1qr2rFLfU3ru86o0CmyNlr+YmZdj7tPenEGKmEM62RWOnPIG+5XW27lNODGLhOnP+ey6Gvf1rOEwi2wNh5YjelGgrw0ziwt8BnqarXkyO11t56b/nXpVmQYlf883UET/3utzO8/dyGBCPyRGbdlWA4jJhwizf+nEHyjk7NMmCebqT4c+Y5ZPi2KX7UohJWSEHwWA7 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8936002)(66476007)(36756003)(508600001)(64756008)(66946007)(66556008)(66446008)(54906003)(316002)(5660300002)(6486002)(71200400001)(2906002)(38070700005)(33656002)(26005)(53546011)(6512007)(6506007)(186003)(83380400001)(8676002)(4326008)(76116006)(91956017)(38100700002)(122000001)(6916009)(86362001)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <8DF3916E46EFD248AB662D3FFACDB7D9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8100 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cc7538ad-68e8-4c78-dff1-08da430fd4ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pUpoHejbn6lN2v+c+1+CAL9SvZtdb7iVYmEMgG0/b2kC0hzhj0fLP5p93Ckw+Hyff6TisscPM3KGXsA0JoQ/3PyadQ653uU2rDtHePqWwPNtm5TFzgzIqm0FkX8wsGXBOvkKQjfht4DXYlK+H/xAgHArmtSxDkxdH6tNs2TKUOtt5g0mmImh2V8mbjtUl/LupsvGnQ9vOH2OiFWJknvETKgfYZOZM8iXgaE6EgjcSFdtr5y67hCXcICNg44BgwY1LtPnBRC/Q5TNHWdzR3ybqyP/H60b7mm5V8lJDz4esC4dzQK859s/V9f6hmaSSoM86tI1+SNGlgFRXzfqe+O4z45V9SbbCWRU2+GxFWRwu0W+UD89eDz+dzU8QVq2ddCoBO+2sHRZ2+5WP7sWozTwbVMDIlO5U7+2AKdBMcg0fcbIYset1VR/tbs9+yq2K2SIJZVl++mgs9AswJzDZ71yuXknkdjmTJhvSjof70HxsN8Tn/CbVqSXzuaGYNl/jzHdMXXbOQFoeVXJ1eikmvFxX9Dhf2cglk6HhiUV4mQHpe6kFOkz+WP/DqqkfRqFnqRCBVT1gXhJzqeg8MAYEEMQ8AM6Bv3KVMVjCt5WliASLBdh/ZG9PuRaO5Hjv53oEOrIty7mS6Bh3o6jOxV9uvc/gHGksQTSZ460lrcZ/E34QtIh+vornQjiWdIh9MOAvnxu X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(6862004)(2906002)(36756003)(4326008)(8676002)(36860700001)(508600001)(2616005)(70586007)(70206006)(83380400001)(5660300002)(33656002)(53546011)(6512007)(81166007)(26005)(186003)(86362001)(356005)(6506007)(6486002)(82310400005)(336012)(8936002)(40460700003)(54906003)(47076005)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 14:14:19.4463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbd7ff6-346e-488d-3b00-08da430fda7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6830 Hi Jan, > On 31 May 2022, at 14:50, Jan Beulich wrote: >=20 > On 31.05.2022 15:30, Bertrand Marquis wrote: >> --- a/.gitignore >> +++ b/.gitignore >> @@ -297,6 +297,8 @@ xen/.banner >> xen/.config >> xen/.config.old >> xen/.xen.elf32 >> +xen/cppcheck-misra.txt >> +xen/cppcheck-misra.json >> xen/xen-cppcheck.xml >> xen/System.map >> xen/arch/x86/boot/mkelf32 >=20 > Please can you obey to sorting here, inserting next to > xen/cppcheck-htmlreport? Seeing that xen/xen-cppcheck.xml was added > here by you at the same time as xen/cppcheck-htmlreport, may I further > ask that you move that line to where it belongs as well? Sure will do. >=20 > Additionally I wonder if you couldn't use just one line, specifying > xen/cppcheck-misra.* ; this could then also hold for the _clean rule > addition further down in the patch. Ok. >=20 >> @@ -703,6 +716,21 @@ cppcheck-version: >> exit 1; \ >> fi >>=20 >> +# List of Misra rules to respect is written inside a doc. >> +# In order to have some helpful text in the cppcheck output, generate a= text >> +# file containing the rules identifier, classification and text from th= e Xen >> +# documentation file. Also generate a json file with the right argument= s for >> +# cppcheck in json format including the list of rules to ignore >=20 > Nit: Missing full stop at the end. Will fix >=20 >> +# Replace current by goal in the dependency to generate an analysis for= all >> +# rules we would like to respect. >> +cppcheck-misra.json cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rs= t >> + $(Q)$(srctree)/tools/convert_misra_doc.py -i $< -o cppcheck-misra.txt = \ >> + -j cppcheck-misra.json >> + >> +# Prevent parallel make issues as script is generating both files >> +cppcheck-misra.json: cppcheck-misra.txt >=20 > With this dependency the earlier rule should not list multiple targets > (and it generally should not, for not being a pattern rule). If I'm not > mistaken the way you have it the Python script would be invoked twice, > and all you prevent is that it is invoked twice in parallel. And then > please use $@ inside the rule. Additionally, with the script being an > in-tree one, the rule should also have a dependency on that script > (such that the targets would be rebuilt if the script alone changes). I am a bit lost on the $@, previous patch adding cppcheck was changed to use $(Q) instead. So can you justify this request ? For the rest, thanks for the finding, I agree and will fix. Cheers Bertrand >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Tue May 31 14:29:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339684.564566 (Exim 4.92) (envelope-from ) id 1nw2ro-0002oH-ES; Tue, 31 May 2022 14:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339684.564566; Tue, 31 May 2022 14:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2ro-0002oA-AT; Tue, 31 May 2022 14:29:04 +0000 Received: by outflank-mailman (input) for mailman id 339684; Tue, 31 May 2022 14:29:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw2rn-0002o4-8x for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:29:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04059e35-e0ee-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:29:01 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-45-jl5pgO8qPmGnuhzRAT8trw-2; Tue, 31 May 2022 16:28:59 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0402MB2933.eurprd04.prod.outlook.com (2603:10a6:4:9c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 14:28:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:28:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04059e35-e0ee-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654007341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6j9mqNrhmK9XxBuGTNN7DA3oCNdIfkJ/LVoT20sdNOo=; b=W4SPIMxCL6EwoyBuEj0Ig7qx6w1g+n1IGV65Ix0Xi6dYTbN9QXdaL+XuQsRn2ZUM5ai7tf CXN7rdNuVkbfkY+oIxp89+K38l/+12j1j8/0qccDw0qNwY+ur5y1Qc0+3tG/BDRH6ZM0SE IiqrJX5YGnH0B7N5FH5R+uQQbEd8nP8= X-MC-Unique: jl5pgO8qPmGnuhzRAT8trw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9YmhSOHLUYihU8vXm52nvilljZ8t4x0GV3aLiBNklW6L/ZaVPXgwBSwzgZl0sxMYyXH9/kJh79KqrP8+WiX9xVCJic9ViAfeIilxWN4qT9HS1PkGIc6alh6eZ1cTtS/ikuP++XA3jPxcPWEdZaJsiGzqrMNwSugrmmCHeFBkWAATurtEiMp79CGhcMN24//4bypFcjIN8Iges3K0udBPnQ4GdlzCi4tY9DXaapqOVCiAdrvqWfqr2v7zxFIuGlC/YOmH4LCT3oFQNhT039CMMu9zk7KAIAwhPXDrcap96h+DfXtSVN7QSrmyPaBLRLfTLBymiuHGjaqJi3A1tlltA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6j9mqNrhmK9XxBuGTNN7DA3oCNdIfkJ/LVoT20sdNOo=; b=YFdjCzm+h+HS5XzkBvwmKfN6ImWGzX68YDYle3w0vL/D05LsA4OJMCPIYi7QwIhFsY+5ZCGWWDMjnOtWjkKuAtiEIdi3IpsBf+5Z4cfOm74hJXbw07pG5upsl2/8wQDKT1iXWLmXmXix1WMd3W8E7KDn8RhGKPU6XpigWk+m06Wbzfm3zqtVNn8rTteiJAf23omvZpQ6bpvTFRczqAvvAIBEhYszslBGsommpFUwQ9Hq99O7ikj+jdwYkTMJBNJ2TZ6uS61scqUlXpSuywpyyD+/fGdfFkdoJlhq3Cd1XoayULHqBsSWT3fTV3j4JX7OTeBkGi0JoMXLAWHVyt5WGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 16:28:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen: Add MISRA support to cppcheck make rule Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6eed766f-d7b5-4ea5-9db1-08da4311e574 X-MS-TrafficTypeDiagnostic: DB6PR0402MB2933:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lac44j5MGKBaptk+ez07VigrUHza0rIU6nJhfOI+nB+BH+2SCNY5pOj9b+RC+P+stNuJrG6zW5P9AvMEwtLwIe6weFYAu2Ca85tqc5twUeAqrOd4idh4L/Mybzl4IRdYRuOkFbDOFU0H3v++aVb4zRAeUTWzCaVJHGesWxLKi3MLoaYYY10CaUktNhfaIvIrgO/jndHu/EBm/ItEeoWrDUpFvhmu6JunNC7BKG3w85ht0LDiZeV6g8mKPKoaxAIR1P4jeEUVd9aZeGYR/iAITNd+i836Rr2WA/ZEaIIGh4TFcEJvVBJuKX+E/BRzWaxhKbaKtyKs0SUYH176CC4ScC/p2yzA5pRTYb4FZL4K8ss0L+sKirn6IzbeLXfwEkuwIo0sGnHacxP/rHRiZ2UHIFt/VTvBM6KHxeyR0enlVKI/f5IcBkNDHp0QOVUV2A37hdSoAELYgW+u6Tunmbu9iCOX8upk+AtKyp5iXf7r88nkiFwzFNBvyavaYbYkIRUrSeocICEWKKm1T0kdrMms6RA0bOEjjQMEldhFVNr8ABf392K+aLj6qJF6EGSd/9wp3mWb3pBNRIOlQeEaQFDHInPAyOHN8WQ7NTAiqmorvhuQfXyw/zFoEKa3dbU12TPjvxRiDXN/r1tE02XjdzJyA+mTLroQfKyCDqtvrvRj9c3NnvSaSJtwzyZP1SKhSJLi6xhSdUzFdd/qPy/PBJL0+TC5xdT9JvA5T5b6+0Dftb4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(83380400001)(6916009)(54906003)(36756003)(31686004)(53546011)(186003)(6506007)(6512007)(26005)(2616005)(6666004)(8676002)(2906002)(4326008)(86362001)(508600001)(66476007)(66946007)(66556008)(38100700002)(6486002)(31696002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UE1YRDhoQ0FTdGZnQ3dtWTBObWV3MlNwcXFOUHZYbGVaZmtVM0lFenp1RnVS?= =?utf-8?B?S3pkNGJ4S085TTEvVWtSdC94czJxQzlvcWEyYTdEYWR2MENJOExzVkhhVWw0?= =?utf-8?B?dy9BbXVFa2RMa1NoaGhxSVpldWdmWmU5RHN1bkJpK3ZCNytjUi9QdXZEc1Vr?= =?utf-8?B?a3R0Zjg0VDVBeTNHVzUyN2kycGhUdyt1bFdETWIwMllmNnZ4bTgrdmhLL2sy?= =?utf-8?B?WXJ5UWp2bjFtZHFGa3A1cWEzenJhRUU2TE1XcDV1RVJXdkFNenhLaEt3NFBR?= =?utf-8?B?T2VmUVE1N3lTbmRWZHVQR1RXNG9JV2hhcU1JSkJPTENTZ3lQZWtpWE1VTXBr?= =?utf-8?B?VGRSY21QSU5XekRIbGJkaVhMd3lxM2orb0Q5ZFV4RnhGQjFuZElJVjJ1SU82?= =?utf-8?B?aUg1dU40T2NLeGZIMEVrdThtby8vNVN3em5UQmFvd2R5U1BMUE5HRytuY20w?= =?utf-8?B?MHdLWDV1L1F2b0ZKamprZ3lObWkxSlk1ZFYwRkhlckpCM21SZm1IR2R0T1Iv?= =?utf-8?B?aU1XZnUxR1JMcXdBSm1idHh0bURHNjhlZTExYk5ycXFIYW1UUmRxWkNDd0NO?= =?utf-8?B?bW42cHpUMUovT3dwUHJjQWdkWHl0NVRabUxmbUdYdnhWRWplSnJBd0hXRFY1?= =?utf-8?B?TDZEa3RYQStNTkhUTWZrbEVJMk1kNzVNTk9rYjRsZEFHUTdIdlRiMHhndUx5?= =?utf-8?B?VSsvRWQwdFZUNnEramRLZEFIYkRidUZQU2d0TzdMN0pPSUppM2RQVVJub1Fn?= =?utf-8?B?SzBaRXlGK2RrdGNCcHZGQ3pkbmNLL1VEN0J4dU5hVldEV3BLYlVVY1dQVXIv?= =?utf-8?B?K2ZRYjlyS3NEUEd6UE9pazJKS25MVjZ3Z045RmQxV1VjblNKaVhPREdEdkt0?= =?utf-8?B?bmNTUmhTeitXYjBKMXRXSER2aU1GQ2VyRlAwaHc0M3JpZ3dTRTFYYTBubk13?= =?utf-8?B?WUV4c0RBRC9hejZxVWovZWY5ZWdTcEFUMXhsZ3haK0JlZXpqM2pxSkVibFBR?= =?utf-8?B?M2dFTFZLQUluUTJsRmF0bTVna0JRQW9teTQ0Zm1MeG1rUGdqcFFXK1dnOFhF?= =?utf-8?B?UDFxYWtaeVRpVGRacEZON3lVVVc5dWxnZTM5M0VrTlhpTkdhbjk2QmhoNTNj?= =?utf-8?B?cGtsV2pCRHNSYU9Va0N2dWpyU0F3Sk9pV2wwTkYxRUVtSTJNOTJBZlFuejlJ?= =?utf-8?B?NEJxOU0xNUNFZitrampCT2NQd3ljbXB1dWFUMG1qTTZ2S0R1VlozSE1KK0s3?= =?utf-8?B?cUFCdlN4UHFoZUVrSzZ4bUlsb1FMNlMzVUs2dnBFc2lLdnJDZFRSSVlhUmhW?= =?utf-8?B?RlEyekhhbXFqdjZ2WVk1cGhZRFROWWVuemJRTW1QcHlWOHZXS1M0V20rOTk0?= =?utf-8?B?clNJYkxkTDg0d3NHOGtQZTJKRDkrN3JrTUFLSXFLcWgrblpUV01mSnhJOFBt?= =?utf-8?B?bmJtRzhsY0tSWHBvVW0zcnFaOEpSaTNFZ1pkcGhsSWR4MlVQMW51b09CaWNU?= =?utf-8?B?VWJxanp6am0xdi9pN0MyRGdhR05Tc3RCQ29XQkJjQzBHNURtckNhc0puYUpQ?= =?utf-8?B?QXFjOGUzb3ZFZ2hVa2U5UFFtaEI0aUw3M2hFYzA5dnZMM054dGxyV2xNbnZM?= =?utf-8?B?ZUdVUytIU2hxZVJvK09mNzN4ZEt4ZHhVUEdnQ2R4b1hsNWY1K0ZPRlhHa2Ny?= =?utf-8?B?SVhSNEF4S1RlbHZaWWI1L1FTMENTRVp5N3NWeW4yUWdiQkR1RWlRMU5sUGhx?= =?utf-8?B?cFFCcmdVVlpxN2dzRFVGWi9uZ1cxbEtvZEtwNWNXcWtsUVNxcFlQSEFNWjdW?= =?utf-8?B?V0syUWYyWUNsaDIxdFhqRC9Dc0xNV3RlQ0NBYzM5dWJhaStpbGV1d3VQc3B3?= =?utf-8?B?dDF4WjN4dVVoL3hSMW9HZHZaVW5qcE9IYUcyOVI4emhhRjVabnhiOWd3TWN3?= =?utf-8?B?VllacmltUWcyNjBjU0l0SjZwazZPOEdCMkU2cUpGTWh4M0YzWjZOTUl6YWVE?= =?utf-8?B?aC9yK0hoWU9aUTU5VUE1cGdTSWhrVkdFZnR0eHZId05rU3R0cTBYTzA4a2xF?= =?utf-8?B?TVFDTXhCRlNDdXVQaG81UU9BNmsrN01pUzNYZmEzYUpNUE5VRW9sNFdrcEpv?= =?utf-8?B?YlJ1T1paa1pNQnEwUUh6UndrU2h1MjE2cjJGNG12aktPZzdHWWo3YWNTbk1o?= =?utf-8?B?SUV4TkJzaUNTM2puMVNKYnh2K3lLUW54aWtpSTBoZGtuSTJkWTdycVJhcVhC?= =?utf-8?B?M0FqWTFkZGxDN1R5aEhrZ1d6bzVxa0lUa2hMb0V6ZC9MbmpTMnk4Rk5XRUhS?= =?utf-8?B?VmdwUXpBYjZ0YWk1OXJ1V3lKb1ZuWW15QTNjOENRbXBwQ3hScjZrQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eed766f-d7b5-4ea5-9db1-08da4311e574 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 14:28:57.1351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhhKGvDZFa/sLwcTMQHt5nutsx4M0whWDmoHkwgcF5wMYLOwoR5FtIZPxRa/26enYrOg5aKBl+BVzutVpUegzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2933 On 31.05.2022 16:14, Bertrand Marquis wrote: >> On 31 May 2022, at 14:50, Jan Beulich wrote: >> On 31.05.2022 15:30, Bertrand Marquis wrote: >>> +# Replace current by goal in the dependency to generate an analysis for all >>> +# rules we would like to respect. >>> +cppcheck-misra.json cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.rst >>> + $(Q)$(srctree)/tools/convert_misra_doc.py -i $< -o cppcheck-misra.txt \ >>> + -j cppcheck-misra.json >>> + >>> +# Prevent parallel make issues as script is generating both files >>> +cppcheck-misra.json: cppcheck-misra.txt >> >> With this dependency the earlier rule should not list multiple targets >> (and it generally should not, for not being a pattern rule). If I'm not >> mistaken the way you have it the Python script would be invoked twice, >> and all you prevent is that it is invoked twice in parallel. And then >> please use $@ inside the rule. Additionally, with the script being an >> in-tree one, the rule should also have a dependency on that script >> (such that the targets would be rebuilt if the script alone changes). > > I am a bit lost on the $@, previous patch adding cppcheck was changed > to use $(Q) instead. So can you justify this request ? I'm talking of $@ (a macro expansion), not @ as a prefix to suppress command echoing. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 14:40:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:40:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339695.564580 (Exim 4.92) (envelope-from ) id 1nw32s-0005Dy-J0; Tue, 31 May 2022 14:40:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339695.564580; Tue, 31 May 2022 14:40:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw32s-0005Dr-F4; Tue, 31 May 2022 14:40:30 +0000 Received: by outflank-mailman (input) for mailman id 339695; Tue, 31 May 2022 14:40:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw32r-0005DR-0n for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:40:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b0fb8d1-e0ef-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:40:26 +0200 (CEST) Received: from mail-dm3nam02lp2043.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 10:40:19 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5680.namprd03.prod.outlook.com (2603:10b6:a03:2da::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 14:40:18 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:40:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b0fb8d1-e0ef-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654008026; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VzAtl4PM+X21W25T6m5ON3TlrJQJeZ7bxTtbXjB59ms=; b=alsPJEkUzdU5ZH9Rs0yFx3nQASs6s7ihFKqKgOPKx6A85QkC1LqXTQT3 RHmHOifBj7bzm23L0NoTamEpA+Vh1Uy5APQuD8OesO/1fM8G6w+TaBW0k +N7C2HUzsSMLQKcmxAPQCvcst5zczumsJvO2Wu+8TNJszzhE/VvILpw2p 0=; X-IronPort-RemoteIP: 104.47.56.43 X-IronPort-MID: 71887967 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KxW8T6IR2cP97gvWFE+RppQlxSXFcZb7ZxGr2PjKsXjdYENS0DEBz WodWGGEOqrfM2f3fI1waITn90oG78fSn4ViTQtlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Ux2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 MV97qXtcCQkBLPviuk/fxBXIR4uPoQTrdcrIVDn2SCS52vvViO2htlLVwQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM6FH/6iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33ymvLGwG9zp5o4I9w27P3jAs4YTAc9uPUYSIf59fo0+h8 zeuE2PRR0ty2Mak4TiP/2+oh+TPtTjmQ49UH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK UEf5mwpt6da3FSiU93VTxC+5nmesXYht8F4FuQ77ESBz/HS6gPBXGwcFGYdM5ohqdM8QiEs2 hmRhdT1CDdzsbqTD3WA6rOTqjD0Mi8QRYMfWRI5ocI+y4GLiOkOYtjnFL6PzIbdYgXJJAzN IronPort-HdrOrdr: A9a23:K+IBcaFT9bckCKtVpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="71887967" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkZIv+Z4MA1M09stJ1czNjfhpdPk+ATwynZv3aKvNWeh5sDF20O3coIjJaSwPNMbZD7EOrhIBMM7n7Jbpy798Vbqhr4owgIg7FI2bgeFG31HYmmjz68tHPpPbyXiMz1cfJgrn8Cw79AopZR71dfDC3ODsfvYM0OR2wq3OlEKKl00FsGmQLBUFG4OYYDRVb7mmU6PPiG6+cML1DvedAnlhl55NSySRKIz5KCFOXefhzkGL0gBXG5UkhtmJUGKXWpLwJdHZOEWLVO9oiezNe95DAt3gLqyeuocZC1ZOUcoDQKQydvYq0UUnWX0qQ0DYAifmKK/zQRVRyndRSs2/mSDkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wHdPgxuigPMScz+40o/3BAfBKyZ11tfPFxmg2k/N4o=; b=i0S9xswuOa6a7/U7whqhIciPMxJalEqlQWJuMWaOZen8D0nK0d/EobhFIhKDZTePuUoSSpYlUf023WUr76Z2scq+lxFCdSK6yZ/t5xKfyXhXBX0eOd7PfjAYEgEAWFH7HRlQGUvxkqgs5wtMVnWZYrnABzSqsGbhY4yKFMbhM/KpYY5VsVcCC7Z9ybWVMVwJ336B8YIgDLhxXwy5KKbXNpRmVwxPmed6PmePqA/RcIk4yDHIdNjTDDdXhq445qp6fIflL2NeRI2J1yR0XM0OxZlaaFd3KYlge2hR3yRq35TZzpAvj7TDE/25lMOJ5S0AYJujDlfbABHZ4MmJUQwilA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wHdPgxuigPMScz+40o/3BAfBKyZ11tfPFxmg2k/N4o=; b=Izhqgeeo4l5M4dCRtukhbkUmjidDRLEovjXLCqOo4dJgIke68nLVIOJNS8DUnJdlED/EAb8hXr1qDOXw4Gi27sluJb2SPARZmdHwa78/is0naDQPNWcS5wITI4FC67H/7qXwYxPAKmVgeK0i80uq1N7D4AhTYNW9i7/UtCZ/8Qw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 16:40:12 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v5 01/15] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> <1de2cc0a-e89c-6be9-9d6e-a10219f6f9aa@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1de2cc0a-e89c-6be9-9d6e-a10219f6f9aa@suse.com> X-ClientProxiedBy: LO2P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a04522d4-dae1-41fc-f7b0-08da43137b12 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5680:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EXxJJr4najynZZD7zsEP2NQdTFIedVFa7v7pGIE6MBHHY+rVTwIChYDQLjC5UjED6JeuKbN2cnfJOpHJ99TKQbi396ZOD4UJN3L5PAzRYcWAR8XdAbrmntMDJELc5BZE0uTYsRS7oSADKs+H59vPSRWH8xKlUsdGrbWoYLyZfe1EbTkaSWEAF0b3fTld7PhTkSSZT/AmJNPthq7yBqdZzRZvYU8qYyz5A3PaWEzZL+ApX++ZCu36i6yvfIl+A5/NYTk0mIAVY7v2u9eedOehJHHxUml0xgvOxL4lS1JqA1EA2oPma+YvVgwfGgpvZxstkuhfQfZixTsQH7yOMqAslhCmEJQgpWGKMgScNSLRzqqd75G5i2aKm7/C2d30dDiawHl/5cdS7c5jqjdEsByGifJtfdeEe1kLstpW/okZyl2oo8j04GXTZhiK07j9A1amzaRtB5ZUxYXQMZe4z74zidUIQJ1wOmp3wN9UrCRfmfMXBy+PUTfi/jqu6ECNDsLx/8UFDtTNZqHlL1HaRQOzz1g9YTBa3PtRRUvv+TiGh3jcdir7pRl01+wpxoQuv8bKMSV9lW9eAenCy/RlaTjfAy8zoC5PYv/81SvuB8EISqg8MZ8hI7LY83QOFrvuxD2vx+7ZG4I+cEEEbaTiZeqrqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(38100700002)(186003)(66946007)(6916009)(54906003)(316002)(85182001)(8676002)(4326008)(66476007)(66556008)(83380400001)(8936002)(508600001)(6506007)(86362001)(6486002)(5660300002)(33716001)(82960400001)(26005)(6512007)(9686003)(6666004)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFdPMUd1QVNGZVZ3R2F2elVTWnVuVFBldURsZnljckd4ZVNBT1RzQVFkL25F?= =?utf-8?B?UGhBbUlXQk1IUFZWUVo2d1gxYXdRRGNkbG9EOWo0WWhUUytFSVpPZXpDRlE2?= =?utf-8?B?Q3VMU2p3UldkYjZRRkxhYWRwWExVOUJadVJxL2RIUXN5dkhCcThGcHB5RllL?= =?utf-8?B?djBZN3BRZjI2SG44d29UOThKaWw5M2FkWjFOS0NzT0xuNjBBUnJqZ2dWRHE3?= =?utf-8?B?L1RrUWJ0aldEeTB1L3JmMkgyU1VSVGQrUlEwd1JJMnJmUDNpekk0YUF2b1d2?= =?utf-8?B?Z2VveTQ0MCs1OWpmMURId1hYcU9RMHJPVjZycndkeUZkVS9YOTB0cUh5aTlJ?= =?utf-8?B?M1V2QzBFUnNvUk55U3lnS3lyN1FYaDFWWlFVVzdvclA4dnI1ZnJNZWJ0alNU?= =?utf-8?B?WnB0dVAzOHVNVDVxUVpRSkd6T0k5UE9mdG9yYUhCaGVmOVA1YjllNzFobFY5?= =?utf-8?B?ejdaVFhkRUsySGJaNlluMXVUUHlGbmVtQ1RndWlKWTNzdkFsWEI3Yks1aUdI?= =?utf-8?B?QkZPenpwRDVmbmxDdmxRQ3lpU0NEVzlVRGNBWCt5dEwvUCtXSFRmV0RCYjhG?= =?utf-8?B?K0Q1RUROalI5VFZpdDNVMlZkdnJDejJ6NldVNGRpVEs2VUtoMjR1RFNha3Nz?= =?utf-8?B?ZnBhZy9aUTdUWjY5NVRWMWZtLzdlNU5pM053MzBLSE9qNno1R3pSdnN6bzNk?= =?utf-8?B?RVJCSkNJVWxHdE5DcmRjWTlGK1NVYy9WSVFSdEVzeVVrMVp2NGcvT2hKNW9y?= =?utf-8?B?TjR0Nlo5b3JGb2dRU2FkY0xMNHBCcEFabFJOQkFmajVQL045R0w4NVVEaW9I?= =?utf-8?B?MTBpK2t4NHJsZEdvMjRIdjZ2aFZ0TThhVGNRSlU1bWZKN0JGYjRyc0plakxZ?= =?utf-8?B?SStnZlhNdmcySW9HZmNmbHlMM3FtbHNwM3ZFRHVvOEp2ZG56KzN0Y25EdFdm?= =?utf-8?B?WWpKeU8zR21QaFJJNkk1bStUQVVmNHJXKzlBbzhlc01YLzFmU0wxMms4Q01P?= =?utf-8?B?UDE2aVFZRXAvUGZQZTQrNGhweXI3eGVWdDNaWlJDMHFpUEJiMTZHcmlnTitv?= =?utf-8?B?SjhUU2d3MSthb0pUbFBnTTlaaDhXVXE3WjdYMWwvYXM3YnE3dzQzYkNKZTJH?= =?utf-8?B?SjdBUC9ZNkgrbkZTYWt6WFdlOGN4cjIwS2NMQ1pZbmVic2xrbFZuclFDZzQ2?= =?utf-8?B?U0V6SzROZ2Y1THAzWEZ1MDNJcUh0RTUvTnF3ZVVFcTRscDBKMHJ3enp3dUtL?= =?utf-8?B?MW8vdnRScjNlY2pCZFZ1Mlh3VjRtTEhpYnVZY2ExRm1ZVkk2VVNLZjRGdTV2?= =?utf-8?B?TXR1MnFCS21OUmFvLytRZU51TTZoOWtXM0pNSXBydDl5T2UzVXB5cXEvVGJW?= =?utf-8?B?UFF4bXJyUVB5ajlkVi9OWlp1STNSMjNOd0hxd3U1R3gvMmN2SHVXd3k2Vk5V?= =?utf-8?B?Rjh1Y2lBQ29qdUMrRTNpWFQ3elJKbXZmMkZ1WXh6YndzdlR0UDhLZFVwS1pG?= =?utf-8?B?dlFiZG5vRU12MHVEUExmRVdOcDE0K2w0L3I2QlBoMkc4VGlKMlBoay9kZFpJ?= =?utf-8?B?dE1DSllRL2s1OHdZV0ZnbzVuRVVETmJLdW1kcHVZVk95NEdTWmhzV015ZUdM?= =?utf-8?B?VnhLcEJuSHBDWmlNeHM4R0pxVkJ3WXc3OGJqR2FoS2ZaVStjVmNWRDk4M3RL?= =?utf-8?B?ZEJPVDFlVWM2dkg3TDhSeUI5TS84VjJQSEhjUnFWVU02aUJTd2RzZ1JORzU5?= =?utf-8?B?WXhuNURTREdiRHhVWGZuaHZYWDZZWHo3OW9xZ0QzODgwWVB0Rk9rSWNlalZp?= =?utf-8?B?NDJld3lPMm1KdlZ4bmhqZHJVSFpPcUc4TmY3YXNjcmxzMHhPUnc2YURTZzNu?= =?utf-8?B?Z3d1RTdXV0tnenl3U21nWWFoRnJXL3MrRE81VXIzbFZ1TUpndXhoZmFnZzh3?= =?utf-8?B?UmlYN211WURmd1RJUkJzY3R5Y3pQVFcxcndySWZDb3UrZkdiN2ZVMzA4eFh5?= =?utf-8?B?RXBoRUNzQ0NUUEtnZ0tIeUZZa2g2SFY4UlVGeGNlQ0s5VFdzVzA0WHVtNCtF?= =?utf-8?B?ZFR3d1AxNjZNc0R1Yjd2OTNxR3J5NzFwSjNoRFJlQmxzS3Z1eWJwUFN3WkhQ?= =?utf-8?B?NTFjWnh6dmtuTGNmVmlmYUhPcDVQcEVVRWp5UkpncHQ4aDZmUUo5NmZaOFpQ?= =?utf-8?B?bVlFclJ1c0JVNGNUYmx6c2hMMlc0Qi8yNDZCcWtKeUNGZXZwQ2R3TFduYUt3?= =?utf-8?B?T0k4WitnNGZ5Q1I5ay9IdFNzRnRmU1ErVytPQVE1S2d0L2J4cVhYSmtkMk9u?= =?utf-8?B?SVlOWTFmRy85NXFVMzZBWUhTRU11OVFyVzgwN3dmOE40Si83T1NXU1NCWm1v?= =?utf-8?Q?okOdP133/avZoO00=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a04522d4-dae1-41fc-f7b0-08da43137b12 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 14:40:17.7907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BFzCsAaCEo3L4XOa0FKhJY8M5S7Q6ruabX1m7A+UXbe6tP2ApWwl8mm6aoGGLCO7Tbgy+E21hy1Jp2ePPCT6Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5680 On Fri, May 27, 2022 at 01:12:06PM +0200, Jan Beulich wrote: > While already the case for PVH, there's no reason to treat PV > differently here, though of course the addresses get taken from another > source in this case. Except that, to match CPU side mappings, by default > we permit r/o ones. This then also means we now deal consistently with > IO-APICs whose MMIO is or is not covered by E820 reserved regions. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Just one comment below. > --- > v5: Extend to also cover e.g. HPET, which in turn means explicitly > excluding PCI MMCFG ranges. > [integrated] v1: Integrate into series. > [standalone] v2: Keep IOMMU mappings in sync with CPU ones. > > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -13,6 +13,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -275,12 +276,12 @@ void iommu_identity_map_teardown(struct > } > } > > -static bool __hwdom_init hwdom_iommu_map(const struct domain *d, > - unsigned long pfn, > - unsigned long max_pfn) > +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d, > + unsigned long pfn, > + unsigned long max_pfn) > { > mfn_t mfn = _mfn(pfn); > - unsigned int i, type; > + unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable; > > /* > * Set up 1:1 mapping for dom0. Default to include only conventional RAM > @@ -289,44 +290,75 @@ static bool __hwdom_init hwdom_iommu_map > * that fall in unusable ranges for PV Dom0. > */ > if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) > - return false; > + return 0; > > switch ( type = page_get_ram_type(mfn) ) > { > case RAM_TYPE_UNUSABLE: > - return false; > + return 0; > > case RAM_TYPE_CONVENTIONAL: > if ( iommu_hwdom_strict ) > - return false; > + return 0; > break; > > default: > if ( type & RAM_TYPE_RESERVED ) > { > if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) > - return false; > + perms = 0; > } > - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) > - return false; > + else if ( is_hvm_domain(d) ) > + return 0; > + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) > + perms = 0; > } > > /* Check that it doesn't overlap with the Interrupt Address Range. */ > if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) > - return false; > + return 0; > /* ... or the IO-APIC */ > - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) > - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > - return false; > + if ( has_vioapic(d) ) > + { > + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) > + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > + return 0; > + } > + else if ( is_pv_domain(d) ) > + { > + /* > + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o > + * ones there (also for e.g. HPET in certain cases), so it should also > + * have such established for IOMMUs. > + */ > + if ( iomem_access_permitted(d, pfn, pfn) && > + rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > + perms = IOMMUF_readable; > + } > /* > * ... or the PCIe MCFG regions. > * TODO: runtime added MMCFG regions are not checked to make sure they > * don't overlap with already mapped regions, thus preventing trapping. > */ > if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) ) > - return false; > + return 0; > + else if ( is_pv_domain(d) ) > + { > + /* > + * Don't extend consistency with CPU mappings to PCI MMCFG regions. > + * These shouldn't be accessed via DMA by devices. Could you expand the comment a bit to explicitly mention the reason why MMCFG regions shouldn't be accessible from device DMA operations? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 14:50:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:50:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339705.564591 (Exim 4.92) (envelope-from ) id 1nw3CL-0006nb-GW; Tue, 31 May 2022 14:50:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339705.564591; Tue, 31 May 2022 14:50:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3CL-0006nU-DV; Tue, 31 May 2022 14:50:17 +0000 Received: by outflank-mailman (input) for mailman id 339705; Tue, 31 May 2022 14:50:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3CK-0006nO-7D for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:50:16 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0608.outbound.protection.outlook.com [2a01:111:f400:fe07::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fabe6018-e0f0-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:50:15 +0200 (CEST) Received: from AM5PR0701CA0053.eurprd07.prod.outlook.com (2603:10a6:203:2::15) by GV1PR08MB7361.eurprd08.prod.outlook.com (2603:10a6:150:20::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 14:50:12 +0000 Received: from AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::28) by AM5PR0701CA0053.outlook.office365.com (2603:10a6:203:2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Tue, 31 May 2022 14:50:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT021.mail.protection.outlook.com (10.152.16.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 31 May 2022 14:50:12 +0000 Received: ("Tessian outbound 6f53897bcd4e:v120"); Tue, 31 May 2022 14:50:12 +0000 Received: from 45a7cead38c6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C66D9E34-1F6B-4D4C-AEBF-93DAF2879751.1; Tue, 31 May 2022 14:50:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45a7cead38c6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 31 May 2022 14:50:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB8PR08MB5531.eurprd08.prod.outlook.com (2603:10a6:10:11e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 14:50:02 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 14:50:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fabe6018-e0f0-11ec-837f-e5687231ffcc ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gcEuIwOHN1qJAoTv5VFUkC0t+mnU3LXBp6uZtjEhTlgTHpRbgYSLaqbQxKOnRdps34apQ2lA/oX4YrnOvEwcaJtRotkE97m5/kO4aCuEVb6qhyAJyAOMEpYLWm+T+6BRJuq2rXM5kdiQBGSc7ciosl6HTncPcYdElNSiB2aqAE71yjcRGZdCBPEUDsRXECE5FuSrnfNxvi5eUHlC79bt/sjzp0GgUROBj6WrFzrYEcgusUrNAD+rJOe9QvJQ0wxR6EFQMEuaEJt2fAydDAuWAPTsJxP3TTxIG63n2FHcLlLjzr6BW4GWSGgTjAypemqdXeZqakakb5yDEUvs8hKVxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woTtoY/Yu0DZ7KYZFusF/MiSekw8kB15eXAdmD2W55c=; b=Swhq9vot+YrkAaY0gZOMCpnFsqzHFrmbqEXwycEgoDvkK5uz0ktbke9UBTmoQLKBuNsygQQeGNIiWmNP2lH7AYJ4pvm6uH3eZQu71wboQMmi6SahmqiAQsMxKE8HT6/NoA2LSgR+MtoiPkmoYIVunHTBfwuyYpPKf6Lkl4X/yul4LSt/ICs0CrLiNuXvvBkDbUuXaxENmyBQWBYolUlAZYFVnyA8vptT+1cUC6+eNiijouqGWMFdzIFtTHIN6YH4fOplak68C+vO2Ngp+e0/fdJJQOO9nIwp6dNlsslFMosxz3JFK9uhKyqbu2mHrdPxYhrbXBiVmaZ3RzH2Ct0Vzw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woTtoY/Yu0DZ7KYZFusF/MiSekw8kB15eXAdmD2W55c=; b=tkJs0JdJd+lXqADlPd25zKcg9IDytwB1uCcAMr+BVCMMU7Ijz7cKM5bzK9RKKkWUPtc3QZvPakms1/AQkyJvc+NpLfV17c6UPli9a3y+W1rrVxqI/fB/5noxlrcYH4JB1yzOCc1n6bNltGttZX8ugINS9i0WNVPDj6uj7pnkgjs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4b5a2b729e7e433d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CVQtnMpNVZ0W5A7n4mRU2bt8UPfJdXCaWpyEDsxkjAF8jXxDsHN8TfFsmbdsC6FsMIkGG4+ZbP4cu+Wqll7XE4m/Xbak8cVzAjGyw/2gi393307z43F5g0VzZicRMo+aL0P7coAiDZJx9DwkoPaCjKw7ckxJWWDN4TqMMOYV5U0+/it8tynKy8gZ9ZcmFQOGvfGSzVQ/kZJQsz2q5DVNP7DoUS33vLmTFAwBr3hmDkBhtloEY2DWPlhg4xAEVeejFq2h1u5EvQOT9y9kslkagrbWvesePd4az/yQtd++WryyUu94KM3KxTo+X+q0Sw34aILS0UNxo/15xjHbYP6G9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woTtoY/Yu0DZ7KYZFusF/MiSekw8kB15eXAdmD2W55c=; b=LrJX+fTCfIYYuJBI3aHTh0N2iaql9uN22xP3bBpNw7zciwwPFYmqRhM35P42D1eDhK/VENzeJ+5u9VAPIHLCcR+Le0l5OlnbbbsKbX3XbJE7qZrI4+luUSR+H8l+m50KOVCYOcUdgSsug1YYpmkfhM/zgPF7IBSVR+NMotTW63CMYYM4FhvLQuxYl2T/MnHNhqwy9AtcEyKf4fCo4EwYgikb4XF2IKdtgY017CEE2uQ8ItxWKUJtnu8xtGnY+x5hTBwNTfQHUWyp14osW7ozlBEhvvi8J75g6S3YpY5mvVyMxo9nJg2/XrlwSBnEwUL+0nwWeN0AbM+uhp+UOcl16g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woTtoY/Yu0DZ7KYZFusF/MiSekw8kB15eXAdmD2W55c=; b=tkJs0JdJd+lXqADlPd25zKcg9IDytwB1uCcAMr+BVCMMU7Ijz7cKM5bzK9RKKkWUPtc3QZvPakms1/AQkyJvc+NpLfV17c6UPli9a3y+W1rrVxqI/fB/5noxlrcYH4JB1yzOCc1n6bNltGttZX8ugINS9i0WNVPDj6uj7pnkgjs= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen: Add MISRA support to cppcheck make rule Thread-Topic: [PATCH] xen: Add MISRA support to cppcheck make rule Thread-Index: AQHYdPKgb8OwohyX90ebe0mOYdpVU605ANEAgAAGrYCAAAQfAIAABecA Date: Tue, 31 May 2022 14:50:02 +0000 Message-ID: References: <5467d017fa1c6721436e21f8cc10c5d74adeb5bf.1654002661.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d7d0288f-5f6f-415d-69c4-08da4314ddbe x-ms-traffictypediagnostic: DB8PR08MB5531:EE_|AM5EUR03FT021:EE_|GV1PR08MB7361:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MO3k+ONslgl9Y1/KnGWZm5In9PC5N0YKH4t8GlBCvRP97TWnIYSHiSWN2ls32ZIE2XyKJLGOLhr8HkAGNsFXiWGlesbD3GP6T9+HYEQcLHnhPWaLo8UPRSjdSxKgJwHub1g/XKE0oDwr20v1/NjfM9EPZQyCoXUCvS9XjFtIoxmVDsjwKJnYQ/Fq8UhFMgoyNVNGSuENy4c9EddZLZfLsauOjeOMwJzvqatCRKiwwWwjgmG5zOZH4oMGCoIbIFmxtykwyxA75Y32DKYDmjwKshKNf/PNzdWwhLms5yVlj+N+KnATx5y0ecs0OSvvkoyJIQHmwjej1MV136J19AyrlcbG9wGdT8CEfyvNLTzrnHawCMVfREXAhmoxYj7XDoSlscj8QH/g6hcAo9xoiLpaxwySMjexCwl+aY8l/t/sW4fKQlMB3pWp+J1dIDk5g54ZWRYoP0CphcvxprKfkVCAZUDNwQqU66Re9WTHxh/LtBwew5UacSI9RzL/eXJLwOws63uvG7cbDRikT4E+eUj9h0sqIvAR3eb8mVyBlIi4UnDPXPAddeJeWRbNP8MSCHYGUy380qydyKk7y+KxR04y2ozgRfxV1nZq14S+1w4PNg9+C0SQ2mYaTnIe2fftSinLzF/R3WVcz59I4kkOsbaC9lRGDQJgI+XXMsf73YiGSjmQv09KEvA2NhxB3uUEBXh8PNy6DhqenSIHv3T0XnwAcZyp+u3WRNCgrS0e6A4HBvE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(54906003)(53546011)(316002)(2906002)(26005)(6506007)(6916009)(6512007)(122000001)(36756003)(38070700005)(8936002)(83380400001)(4326008)(2616005)(86362001)(66946007)(5660300002)(38100700002)(66476007)(76116006)(8676002)(91956017)(64756008)(66556008)(66446008)(508600001)(6486002)(33656002)(71200400001)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5A679810D4A6CA4B815C368BF3E826F4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5531 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0d70a25c-f909-4ae4-c697-08da4314d7db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tUG7ir9AxhStLq+AQO0a0uEN5RL88miADD7SBFYcC3qoa11P0ZLkmOn4f7VNKl2AQNxlgsNYw/AWVlVcvImlRXmPHIIglXdsItwaL0k/UIWsXQF5J7a0yV7iaB9ax+N+VLoq1cd9rdm298bzHAyyUlzmVKEMldoRKCvw5yGVouMxWE0W/gu6DNMeKw/fw3aMNk6Hd43LdT2K+viyRdIjZR5Kqr3EXtQR98P5C5+r8R3mvQOCs2nHv5cflSQJXmtT/f66oWprNJz+7vv1lGSvyClcOt1imcJZ1pDKYOdtH8sx5lR0ImJGbQcfhQVnbt7lNsKUOup/PhVfpIh7+AKvG3hpifrQaNEEC0cMUhGJ1L0rTQVbaIcg82KzDCp2Hbds5jELKWzW2WZwQd4FdxKquOBqizSnjRsMNQOUW0KddXf/PsgxKs67+0DBC+MLK7mQny20roB4HUs1tiGWczwDUTnNP74gNA1e9flYPneKlH5ZBlkRXUj41HlBDRORCNnjn//dvuuGe9IQcUjBtFxBVx6oDzBMRqhIJuQzv9Wvxd+4cJ6aAqy0W0Be3UKS6D+pfExW2PrSfmznuyFIiq7Adw6E7+/OlxuxAgCIs97Jji4Mhtc1wTmArAm7RruMpiQXyWO5EpjDDoo550d3LfyqxfXshwLKUhyZoABsVvFjfoky+RaHY+anAw7XsnOFnghJ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(53546011)(26005)(2906002)(6506007)(6512007)(2616005)(33656002)(356005)(36860700001)(83380400001)(81166007)(186003)(6486002)(70206006)(8936002)(47076005)(336012)(5660300002)(54906003)(4326008)(6862004)(40460700003)(70586007)(8676002)(316002)(36756003)(86362001)(508600001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 14:50:12.4372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7d0288f-5f6f-415d-69c4-08da4314ddbe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7361 Hi, > On 31 May 2022, at 15:28, Jan Beulich wrote: >=20 > On 31.05.2022 16:14, Bertrand Marquis wrote: >>> On 31 May 2022, at 14:50, Jan Beulich wrote: >>> On 31.05.2022 15:30, Bertrand Marquis wrote: >>>> +# Replace current by goal in the dependency to generate an analysis f= or all >>>> +# rules we would like to respect. >>>> +cppcheck-misra.json cppcheck-misra.txt: $(XEN_ROOT)/docs/misra/rules.= rst >>>> + $(Q)$(srctree)/tools/convert_misra_doc.py -i $< -o cppcheck-misra.tx= t \ >>>> + -j cppcheck-misra.json >>>> + >>>> +# Prevent parallel make issues as script is generating both files >>>> +cppcheck-misra.json: cppcheck-misra.txt >>>=20 >>> With this dependency the earlier rule should not list multiple targets >>> (and it generally should not, for not being a pattern rule). If I'm not >>> mistaken the way you have it the Python script would be invoked twice, >>> and all you prevent is that it is invoked twice in parallel. And then >>> please use $@ inside the rule. Additionally, with the script being an >>> in-tree one, the rule should also have a dependency on that script >>> (such that the targets would be rebuilt if the script alone changes). >>=20 >> I am a bit lost on the $@, previous patch adding cppcheck was changed >> to use $(Q) instead. So can you justify this request ? >=20 > I'm talking of $@ (a macro expansion), not @ as a prefix to suppress > command echoing. >=20 That make a lot more sense. Thanks Bertrand > Jan >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue May 31 14:58:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339715.564601 (Exim 4.92) (envelope-from ) id 1nw3KQ-0007fI-FA; Tue, 31 May 2022 14:58:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339715.564601; Tue, 31 May 2022 14:58:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3KQ-0007fB-CO; Tue, 31 May 2022 14:58:38 +0000 Received: by outflank-mailman (input) for mailman id 339715; Tue, 31 May 2022 14:58:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3KP-0007f3-59 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:58:37 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2456b17e-e0f2-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:58:35 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009109378667.0943403791821; Tue, 31 May 2022 07:58:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2456b17e-e0f2-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654009111; cv=none; d=zohomail.com; s=zohoarc; b=dKv6CTgzmEQXPD+OSXoPuZnqX6UUKa6wmgQ9wZ2yUWy1KjYBnzLpQ/8srYxsipOjNPhfYyX+J+MEoZrY+mDHQIAgdcYyJVKzncii+iBKsZB+gEYaMYizzjTmAK+1hkyAUQQmEpyF1QuRNQ3zN6CwaYyJmmca859g7M/9GI971NM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009111; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=exIHAbauRw6+XBT2OB/0h0ijm5e3O0CgmhlvDXicHiI=; b=hxHBQfABM2HuuUpRGp2HcYE1j3drQHonX5nvOZTCy/lHIVnuNK6l1ofzf13vh6raO/faFyKSjUHnae43uVie9f8kHx7H5XWUK6Xn7vOmfFpDfmAVs/jtj9PE4/o5uukMJxENUvD/5p46lpEcs5OcuGBLq0IXgM5FtCy6rgby09Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009111; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=exIHAbauRw6+XBT2OB/0h0ijm5e3O0CgmhlvDXicHiI=; b=Z/9rO0LfYvXosJTAi9opnnG94bp7zdllVLhP4Pltag4udY8fpYLZYcVTMeeqoOHi DppIpbc12ii3wCZwhTW4ZISlnUci2qToaw8vFYaQmfx/4Ij3b6qW0JYqA6Cl1t2uIUT OYvVzIUsg/otOGprJt49iSOe4QpPBYU/rgKO4EAE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com Subject: [PATCH v8 0/2] Adds starting the idle domain privileged Date: Tue, 31 May 2022 10:56:44 -0400 Message-Id: <20220531145646.10062-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series makes it so that the idle domain is started privileged under the default policy, which the SILO policy inherits, and under the flask policy. It then introduces a new one-way XSM hook, xsm_transition_running, that is hooked by an XSM policy to transition the idle domain to its running privilege level. Changes in v8: - adjusted panic messages in arm and x86 setup.c to be less than 80cols - fixed comment line that went over 80col - added line in patch #1 commit message to clarify the need is for domain creation Changes in v7: - adjusted error message in default and flask xsm_set_system_active hooks - merged panic messages in arm and x86 setup.c to a single line Changes in v6: - readded the setting of is_privileged in flask_set_system_active() - clarified comment on is_privileged in flask_set_system_active() - added ASSERT on is_privileged and self_sid in flask_set_system_active() - fixed err code returned on Arm for xsm_set_system_active() panic message Changes in v5: - dropped setting is_privileged in flask_set_system_active() - added err code returned by xsm_set_system_active() to panic message Changes in v4: - reworded patch 1 commit messaged - fixed whitespace to coding style - fixed comment to coding style Changes in v3: - renamed *_transition_running() to *_set_system_active() - changed the XSM hook set_system_active() from void to int return - added ASSERT check for the expected privilege level each XSM policy expected - replaced a check against is_privileged in each arch with checking the return value from the call to xsm_set_system_active() Changes in v2: - renamed flask_domain_runtime_security() to flask_transition_running() - added the missed assignment of self_sid Daniel P. Smith (2): xsm: create idle domain privileged and demote after setup flask: implement xsm_set_system_active tools/flask/policy/modules/xen.if | 6 +++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/arch/arm/setup.c | 3 +++ xen/arch/x86/setup.c | 4 ++++ xen/common/sched/core.c | 7 +++++- xen/include/xsm/dummy.h | 17 ++++++++++++++ xen/include/xsm/xsm.h | 6 +++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 32 +++++++++++++++++++++++++- xen/xsm/flask/policy/initial_sids | 1 + 11 files changed, 77 insertions(+), 2 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 14:58:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:58:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339716.564613 (Exim 4.92) (envelope-from ) id 1nw3KW-0007wY-Ok; Tue, 31 May 2022 14:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339716.564613; Tue, 31 May 2022 14:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3KW-0007wR-Ko; Tue, 31 May 2022 14:58:44 +0000 Received: by outflank-mailman (input) for mailman id 339716; Tue, 31 May 2022 14:58:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3KV-0007f3-3N for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:58:43 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 286a185d-e0f2-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:58:42 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009111682798.9130906503007; Tue, 31 May 2022 07:58:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 286a185d-e0f2-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654009113; cv=none; d=zohomail.com; s=zohoarc; b=YUq6ctigvBfOFQocfDkaVCXnaCsiLGi1NtAIc08oHwJZN5sSNK/nW2q6IgijaY47jP2wnfFdGVuKkzcouR3XsR1D/qOvDNJ134RRsb8AgeCJL9dl/0eGuZnlRzLbPO6K8Fv5FFI9ic9hxNjr0uXinnOW4ysvMdCIqMo7WK1PV/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009113; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Ks2c7JaIJxWCU/pu9Stk/4/VXT5nNoOMHKXZhTnoHIc=; b=g4sug2uJ6cswralN2qgQpUzHr9VauB/nfv77m+ZscOsg3n9ZL0x/GIAMxsRX4TLX4Ley6hmOdaU3dlILoVjGXdzUFgbwk9OvzpnLZbRmci17+AEMCMuHdVAam1P++tp6MBHPlH3SClkf/Dpi7UQo1nlC4CwU1iyRA4MuY4Ioc1I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009113; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=Ks2c7JaIJxWCU/pu9Stk/4/VXT5nNoOMHKXZhTnoHIc=; b=orLya5kkb1Ph0mqzCb0XVuJbq6h8GBoIGkiJq4t2MSrqZzRGbgOtSJm4fCymaYDA 3/9+ScLKRyi6deScCHPdvQ5bMvRa6wbMRYdlEa8CpM1T0zyMlLROqOJhIgvR71d6vJr UFfHhPGow4KCuhh1/W8YXIUZtFDf8e2WqlczYJ8w= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Dario Faggioli , Daniel De Graaf Subject: [PATCH v8 1/2] xsm: create idle domain privileged and demote after setup Date: Tue, 31 May 2022 10:56:45 -0400 Message-Id: <20220531145646.10062-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531145646.10062-1-dpsmith@apertussolutions.com> References: <20220531145646.10062-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External There are new capabilities, dom0less and hyperlaunch, that introduce internal hypervisor logic, which needs to make resource allocation calls that are protected by XSM access checks. The need for these resource allocations are necessary for dom0less and hyperlaunch when they are constructing the initial domain(s).  This creates an issue as a subset of the hypervisor code is executed under a system domain, the idle domain, that is represented by a per-CPU non-privileged struct domain. To enable these new capabilities to function correctly but in a controlled manner, this commit changes the idle system domain to be created as a privileged domain under the default policy and demoted before transitioning to running. A new XSM hook, xsm_set_system_active(), is introduced to allow each XSM policy type to demote the idle domain appropriately for that policy type. In the case of SILO, it inherits the default policy's hook for xsm_set_system_active(). For flask, a stub is added to ensure that flask policy system will function correctly with this patch until flask is extended with support for starting the idle domain privileged and properly demoting it on the call to xsm_set_system_active(). Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk Reviewed-by: Luca Fancellu Acked-by: Julien Grall # arm --- xen/arch/arm/setup.c | 3 +++ xen/arch/x86/setup.c | 4 ++++ xen/common/sched/core.c | 7 ++++++- xen/include/xsm/dummy.h | 17 +++++++++++++++++ xen/include/xsm/xsm.h | 6 ++++++ xen/xsm/dummy.c | 1 + xen/xsm/flask/hooks.c | 23 +++++++++++++++++++++++ 7 files changed, 60 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index d5d0792ed4..6b88320588 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -1048,6 +1048,9 @@ void __init start_xen(unsigned long boot_phys_offset, /* Hide UART from DOM0 if we're using it */ serial_endboot(); + if ( (rc = xsm_set_system_active()) != 0 ) + panic("xsm: unable to switch to SYSTEM_ACTIVE privilege: %d\n", rc); + system_state = SYS_STATE_active; for_each_domain( d ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 6f20e17892..962da03f80 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -620,6 +620,10 @@ static void noreturn init_done(void) { void *va; unsigned long start, end; + int err; + + if ( (err = xsm_set_system_active()) != 0 ) + panic("xsm: unable to switch to SYSTEM_ACTIVE privilege: %d\n", err); system_state = SYS_STATE_active; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 19ab678181..7b1c03a0e1 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -3021,7 +3021,12 @@ void __init scheduler_init(void) sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US; } - idle_domain = domain_create(DOMID_IDLE, NULL, 0); + /* + * The idle dom is created privileged to ensure unrestricted access during + * setup and will be demoted by xsm_set_system_active() when setup is + * complete. + */ + idle_domain = domain_create(DOMID_IDLE, NULL, CDF_privileged); BUG_ON(IS_ERR(idle_domain)); BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu)); idle_domain->vcpu = idle_vcpu; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 58afc1d589..77f27e7163 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -101,6 +101,23 @@ static always_inline int xsm_default_action( } } +static XSM_INLINE int cf_check xsm_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("%s: should only be called by idle domain\n", __func__); + return -EPERM; + } + + d->is_privileged = false; + + return 0; +} + static XSM_INLINE void cf_check xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..8dad03fd3d 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -52,6 +52,7 @@ typedef enum xsm_default xsm_default_t; * !!! WARNING !!! */ struct xsm_ops { + int (*set_system_active)(void); void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); int (*domain_create)(struct domain *d, uint32_t ssidref); @@ -208,6 +209,11 @@ extern struct xsm_ops xsm_ops; #ifndef XSM_NO_WRAPPERS +static inline int xsm_set_system_active(void) +{ + return alternative_call(xsm_ops.set_system_active); +} + static inline void xsm_security_domaininfo( struct domain *d, struct xen_domctl_getdomaininfo *info) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index 8c044ef615..e6ffa948f7 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -14,6 +14,7 @@ #include static const struct xsm_ops __initconst_cf_clobber dummy_ops = { + .set_system_active = xsm_set_system_active, .security_domaininfo = xsm_security_domaininfo, .domain_create = xsm_domain_create, .getdomaininfo = xsm_getdomaininfo, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 0bf63ffa84..06ca4e7a91 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -186,6 +186,28 @@ static int cf_check flask_domain_alloc_security(struct domain *d) return 0; } +static int cf_check flask_set_system_active(void) +{ + struct domain *d = current->domain; + + ASSERT(d->is_privileged); + + if ( d->domain_id != DOMID_IDLE ) + { + printk("%s: should only be called by idle domain\n", __func__); + return -EPERM; + } + + /* + * While is_privileged has no significant meaning under flask, set to false + * as is_privileged is not only used for a privilege check but also as a + * type of domain check, specifically if the domain is the control domain. + */ + d->is_privileged = false; + + return 0; +} + static void cf_check flask_domain_free_security(struct domain *d) { struct domain_security_struct *dsec = d->ssid; @@ -1766,6 +1788,7 @@ static int cf_check flask_argo_send( #endif static const struct xsm_ops __initconst_cf_clobber flask_ops = { + .set_system_active = flask_set_system_active, .security_domaininfo = flask_security_domaininfo, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 14:59:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 14:59:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339723.564624 (Exim 4.92) (envelope-from ) id 1nw3Kt-00006i-0K; Tue, 31 May 2022 14:59:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339723.564624; Tue, 31 May 2022 14:59:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3Ks-00006Z-Tr; Tue, 31 May 2022 14:59:06 +0000 Received: by outflank-mailman (input) for mailman id 339723; Tue, 31 May 2022 14:59:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3Kr-0007f3-At for xen-devel@lists.xenproject.org; Tue, 31 May 2022 14:59:05 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35b550b0-e0f2-11ec-837f-e5687231ffcc; Tue, 31 May 2022 16:59:04 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009113158416.5010936264822; Tue, 31 May 2022 07:58:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35b550b0-e0f2-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654009114; cv=none; d=zohomail.com; s=zohoarc; b=mAS/dafHYoecO+N1XrQOYS22XWhJqSAsRX7rL+rLqDabsYjIpckQnfnCIkriRAzCtgQ6eCelxREijZcmSuC9KT773v9P9ET7NKn8F2qbcVTtTYFE1PKoHyTQUYuAQLJTwzjEGvu8t9V+KkgNHAHPLc+JGsHF8CNz8Ca+AzSHqys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009114; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=R5XvVKen+sbJH8JNhyfJKLsT/ygvKCBUq2nmnlxg3h8=; b=n1KHXO0csx2a27N+7iHX2OHAbRScHqlMcc+kw8qGUloanZz1pzHMfuj5CR2NELZoJqxp+XMIA8nvIBigej0yP6HywLwBxSSxmMQFVeYhzQVGHVsb2GTYEYR7x3EAYv1zl5qcNLuaYkuwVg9+L1Qc1Rrre266vlgwpoixgQ5p+4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009114; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=R5XvVKen+sbJH8JNhyfJKLsT/ygvKCBUq2nmnlxg3h8=; b=mBqxSaYo/QxaK5jUTM1FXO6K/0JxrnSf6sGRDY8TfFHNph+phC+qc1pfb8Iefpwp 5uxk4ecwRGL3Pbf0zQSc4n1bjijaxHkh5a19/2lZWXFhBjwrF/+8YrZOPgBG+UgEHq1 NkQmXHZfSh4k+MltIeqvUBKrKV4V8j5/a8JojhHU= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Luca Fancellu , Daniel De Graaf , Wei Liu , Anthony PERARD Subject: [PATCH v8 2/2] flask: implement xsm_set_system_active Date: Tue, 31 May 2022 10:56:46 -0400 Message-Id: <20220531145646.10062-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531145646.10062-1-dpsmith@apertussolutions.com> References: <20220531145646.10062-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit implements full support for starting the idle domain privileged by introducing a new flask label xenboot_t which the idle domain is labeled with at creation. It then provides the implementation for the XSM hook xsm_set_system_active to relabel the idle domain to the existing xen_t flask label. In the reference flask policy a new macro, xen_build_domain(target), is introduced for creating policies for dom0less/hyperlaunch allowing the hypervisor to create and assign the necessary resources for domain construction. Signed-off-by: Daniel P. Smith Reviewed-by: Jason Andryuk Reviewed-by: Luca Fancellu Tested-by: Luca Fancellu --- tools/flask/policy/modules/xen.if | 6 ++++++ tools/flask/policy/modules/xen.te | 1 + tools/flask/policy/policy/initial_sids | 1 + xen/xsm/flask/hooks.c | 9 ++++++++- xen/xsm/flask/policy/initial_sids | 1 + 5 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if index 5e2aa472b6..4ec676fff1 100644 --- a/tools/flask/policy/modules/xen.if +++ b/tools/flask/policy/modules/xen.if @@ -62,6 +62,12 @@ define(`create_domain_common', ` setparam altp2mhvm altp2mhvm_op dm }; ') +# xen_build_domain(target) +# Allow a domain to be created at boot by the hypervisor +define(`xen_build_domain', ` + allow xenboot_t $1_channel:event create; +') + # create_domain(priv, target) # Allow a domain to be created directly define(`create_domain', ` diff --git a/tools/flask/policy/modules/xen.te b/tools/flask/policy/modules/xen.te index 3dbf93d2b8..de98206fdd 100644 --- a/tools/flask/policy/modules/xen.te +++ b/tools/flask/policy/modules/xen.te @@ -24,6 +24,7 @@ attribute mls_priv; ################################################################################ # The hypervisor itself +type xenboot_t, xen_type, mls_priv; type xen_t, xen_type, mls_priv; # Domain 0 diff --git a/tools/flask/policy/policy/initial_sids b/tools/flask/policy/policy/initial_sids index 6b7b7eff21..ec729d3ba3 100644 --- a/tools/flask/policy/policy/initial_sids +++ b/tools/flask/policy/policy/initial_sids @@ -2,6 +2,7 @@ # objects created before the policy is loaded or for objects that do not have a # label defined in some other manner. +sid xenboot gen_context(system_u:system_r:xenboot_t,s0) sid xen gen_context(system_u:system_r:xen_t,s0) sid dom0 gen_context(system_u:system_r:dom0_t,s0) sid domxen gen_context(system_u:system_r:domxen_t,s0) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 06ca4e7a91..96f8167deb 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -168,7 +168,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) switch ( d->domain_id ) { case DOMID_IDLE: - dsec->sid = SECINITSID_XEN; + dsec->sid = SECINITSID_XENBOOT; break; case DOMID_XEN: dsec->sid = SECINITSID_DOMXEN; @@ -188,9 +188,14 @@ static int cf_check flask_domain_alloc_security(struct domain *d) static int cf_check flask_set_system_active(void) { + struct domain_security_struct *dsec; struct domain *d = current->domain; + dsec = d->ssid; + ASSERT(d->is_privileged); + ASSERT(dsec->sid == SECINITSID_XENBOOT); + ASSERT(dsec->self_sid == SECINITSID_XENBOOT); if ( d->domain_id != DOMID_IDLE ) { @@ -205,6 +210,8 @@ static int cf_check flask_set_system_active(void) */ d->is_privileged = false; + dsec->self_sid = dsec->sid = SECINITSID_XEN; + return 0; } diff --git a/xen/xsm/flask/policy/initial_sids b/xen/xsm/flask/policy/initial_sids index 7eca70d339..e8b55b8368 100644 --- a/xen/xsm/flask/policy/initial_sids +++ b/xen/xsm/flask/policy/initial_sids @@ -3,6 +3,7 @@ # # Define initial security identifiers # +sid xenboot sid xen sid dom0 sid domio -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 15:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339744.564635 (Exim 4.92) (envelope-from ) id 1nw3W2-0002ly-5v; Tue, 31 May 2022 15:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339744.564635; Tue, 31 May 2022 15:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3W2-0002lr-2P; Tue, 31 May 2022 15:10:38 +0000 Received: by outflank-mailman (input) for mailman id 339744; Tue, 31 May 2022 15:10:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3W0-0002ll-UE for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:10:36 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d179d326-e0f3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:10:35 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009831597725.6408293875925; Tue, 31 May 2022 08:10:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d179d326-e0f3-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1654009832; cv=none; d=zohomail.com; s=zohoarc; b=VuNh5T56RjoCpstSmPnhtDy8P4z4ozgBJXlIQh5tDpgIgTiCwls+3T4jLLhXTRpL6wSj8lABQsuMRjBKDTaFcI+iWMgqJNYZbg1Iz0s+ccisWEB9CKYuc6G3kIjIdGi4ILjiU8nzIZLo2WShN46Nxi6XIuju+PGnet1RkmxCzfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009832; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=j1HktkrmvpiBISVz8NJU02AjYlC6cm7hboaefj1cMXA=; b=dfBQRY9VtUFojQpGteQTat2se+z2iRmX33WieR9TUaQgIjBLa06Q9GwLUUnonZ4tmk0nJSo8fv0wyl7+alNjRpk+43FD+UvJGYqgefKlHPORoAEiBkE7TgAhXZd1gh25cuew1zQOwcNZGLqLmoh5a4CaaQd0u0z65Wl+II6lWVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009832; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=j1HktkrmvpiBISVz8NJU02AjYlC6cm7hboaefj1cMXA=; b=oFEaygcDThITCWUoEXpIL8Lo/QF68RsI/SwoPox9RVIW+imYe57V7TzXvgWnspS3 Q7MH6Ujp6N1zd/HKGcSFKCI/wX8dGSmkkdv/MRzAFkTuAsKpTv4KOL80NzOeMN1XnK5 /7ah6rnR7i1EIXPcMvrMzLBb3dVcQqUxlLuSnuM4= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com Subject: [PATCH v3 0/3] xsm: refactor and optimize policy loading Date: Tue, 31 May 2022 11:08:54 -0400 Message-Id: <20220531150857.19727-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series was born out of some cleanup work done while crafting the hyperlaunch boot modules patch series. The primary purpose of this series was to stop walking all boot modules when it was not necessary, but the scope creeped during review. Changes in v3: * added arm Rb for patch #3 * mainly a resend due to fubar on sending v2 Changes in v2: * changed init_policy to policy_file_required * split the patch into a series * corrected casting of policy buffer * use IS_ENABLED() instead of #ifdef sequence * moved #ifdef inside of braces for xsm_dt_policy_init() * addressed lack of error handling of xsm{mb,dt}_init() Daniel P. Smith (3): xsm: only search for a policy file when needed xsm: consolidate loading the policy buffer xsm: properly handle error from XSM init xen/arch/arm/setup.c | 10 ++++---- xen/arch/x86/setup.c | 9 +++++-- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 56 +++++++++++++++++++++---------------------- xen/xsm/xsm_policy.c | 31 ++++++++++++++++++++---- 5 files changed, 68 insertions(+), 40 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 15:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339745.564646 (Exim 4.92) (envelope-from ) id 1nw3W7-00032J-G4; Tue, 31 May 2022 15:10:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339745.564646; Tue, 31 May 2022 15:10:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3W7-00032C-Bx; Tue, 31 May 2022 15:10:43 +0000 Received: by outflank-mailman (input) for mailman id 339745; Tue, 31 May 2022 15:10:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3W6-0002ll-0k for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:10:42 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4fbaa28-e0f3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:10:41 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009832776172.65391536782158; Tue, 31 May 2022 08:10:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4fbaa28-e0f3-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1654009834; cv=none; d=zohomail.com; s=zohoarc; b=IKFkJUdxPRhapDkL3848JX6fvYi2lANC/kjZygZZbyt3Jsvbam5CkaZXE8UZ/NZVQNYoTpS8DAkUBtghJ6mcPC3IRXQOqt47swjFCxvSnnlbEol2B4Ku5k19a3NY2rUI+NPMCY7KE9lcXbGnmVWfCJ1VABS99f/Oo9CfhFSBB/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009834; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0S5/4L9LbrEvX7ep2X/hy4hvb0TSeot95E50192YMEs=; b=JxbH0x8jZ/EDew1BDsgDR+cUXW4vd81e1D2i4ivw3aslxcBXNXxnjv/gGePNTDnWx13ztBswJT1L9ms4IVae99LpdGDEdq8Ca3zRQtls9fBjOx2TaidBVUrE+sYnLvI3tXf894d5w8/uudV9l/lL70+YFqvRCjc+c4caKyiWgnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009834; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=0S5/4L9LbrEvX7ep2X/hy4hvb0TSeot95E50192YMEs=; b=nnBATZCIBsfNMYD6Xw7PiEbTp5wCQjcnYXNcZGYwh0MoR7z/3koE2zIyPOduOxyN gSLmdpFmdaXJSzcWnyL3QNaz2xzGMCvysjM6FEkZdPUT05E+g3Lj1UdT3wYX3iWDDS3 2noTfvixdBG0cv0ip2nl3NPY6b7JS691C2WNOqfg= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [PATCH v3 1/3] xsm: only search for a policy file when needed Date: Tue, 31 May 2022 11:08:55 -0400 Message-Id: <20220531150857.19727-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531150857.19727-1-dpsmith@apertussolutions.com> References: <20220531150857.19727-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It is possible to select a few different build configurations that results in the unnecessary walking of the boot module list looking for a policy module. This specifically occurs when the flask policy is enabled but either the dummy or the SILO policy is selected as the enforcing policy. This is not ideal for configurations like hyperlaunch and dom0less when there could be a number of modules to be walked or doing an unnecessary device tree lookup. This patch introduces the policy_file_required flag for tracking when an XSM policy module requires a policy file. Only when the policy_file_required flag is set to true, will XSM search the boot modules for a policy file. Signed-off-by: Daniel P. Smith --- xen/xsm/xsm_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..4a29ee9558 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -55,19 +55,31 @@ static enum xsm_bootparam __initdata xsm_bootparam = XSM_BOOTPARAM_DUMMY; #endif +static bool __initdata policy_file_required = + IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT); + static int __init cf_check parse_xsm_param(const char *s) { int rc = 0; if ( !strcmp(s, "dummy") ) + { xsm_bootparam = XSM_BOOTPARAM_DUMMY; + policy_file_required = false; + } #ifdef CONFIG_XSM_FLASK else if ( !strcmp(s, "flask") ) + { xsm_bootparam = XSM_BOOTPARAM_FLASK; + policy_file_required = true; + } #endif #ifdef CONFIG_XSM_SILO else if ( !strcmp(s, "silo") ) + { xsm_bootparam = XSM_BOOTPARAM_SILO; + policy_file_required = false; + } #endif else rc = -EINVAL; @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required && XSM_MAGIC ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 15:11:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:11:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339753.564657 (Exim 4.92) (envelope-from ) id 1nw3WO-0003bY-U4; Tue, 31 May 2022 15:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339753.564657; Tue, 31 May 2022 15:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3WO-0003bN-RF; Tue, 31 May 2022 15:11:00 +0000 Received: by outflank-mailman (input) for mailman id 339753; Tue, 31 May 2022 15:10:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3WN-0002ll-Bi for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:10:59 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df4f9f20-e0f3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:10:58 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009833869201.3186546902441; Tue, 31 May 2022 08:10:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df4f9f20-e0f3-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1654009835; cv=none; d=zohomail.com; s=zohoarc; b=SlxY3qGZpKXfT3Nzp4ojdk7Lf7W5tssj1miR6PmyrdOtV02u6EwI5CNgTUIO5q1svC5J7WIHt1tZWCk2z/mtMdPaE3d/lWNTxXP5S4FvQlt+MPCWL3cOjCB9fkKj8r8rZWzxzVeZPM8oh7f5S7sXSa+BMA9i5Af4tlqepDQxE64= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009835; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Sjrnmu86gujeudz33+MAWmkOkhEiPemzBi/wKxHuwM0=; b=BCnuEboAIurMmDpb3680KTHgh1W/xJIHSJ0MjD2Q6IAcZ5sas4e42HFnBTnJYlhwNXXMpeG4NR/1c3FVVTcwFYSjOlAfiAz2PNDyz3Eed8etLhxdVdEA2uHh8iISCidlhptWnmMHr2kdQwMiR4rCrYJJq+UJFFu8onCW1HrgCXc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009835; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=Sjrnmu86gujeudz33+MAWmkOkhEiPemzBi/wKxHuwM0=; b=kcXSqp+zK4RpqFtyfzoigZy03wy7gIPQC6+HgUjpPQMgrhMRBKrtbLmqr4Y/8uy9 TT2HFhqhB04z+Zo+xhIIqjLw6KkVe+iltlktfGkSEFXLdC4sutgT7BAS5LF5LaHbCPK HakTcp4WoZfCjW6aScicE0lJw2sn6s9w5qN+VpEE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [PATCH v3 2/3] xsm: consolidate loading the policy buffer Date: Tue, 31 May 2022 11:08:56 -0400 Message-Id: <20220531150857.19727-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531150857.19727-1-dpsmith@apertussolutions.com> References: <20220531150857.19727-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Previously, initializing the policy buffer was split between two functions, xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading the policy from boot modules and the former for falling back to built-in policy. This patch moves all policy buffer initialization logic under the xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error message is printed for every error condition that may occur in the functions. With all policy buffer init contained and only called when the policy buffer must be populated, the respective xsm_{mb,dt}_init() functions will panic if an error occurs attempting to populate the policy buffer. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 18 +++--------------- xen/xsm/xsm_policy.c | 31 +++++++++++++++++++++++++++---- 3 files changed, 31 insertions(+), 20 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..1676c261c9 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -775,7 +775,7 @@ int xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi); int xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); + const unsigned char *policy_buffer[], size_t *policy_size); #endif #ifdef CONFIG_HAS_DEVICE_TREE diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 4a29ee9558..8f6c3de8a6 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -92,14 +92,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { const struct xsm_ops *ops = NULL; -#ifdef CONFIG_XSM_FLASK_POLICY - if ( policy_size == 0 ) - { - policy_buffer = xsm_flask_init_policy; - policy_size = xsm_flask_init_policy_size; - } -#endif - if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { printk(XENLOG_ERR @@ -155,7 +147,7 @@ int __init xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); @@ -167,8 +159,7 @@ int __init xsm_multiboot_init( if ( ret ) { bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } } @@ -192,10 +183,7 @@ int __init xsm_dt_init(void) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) - { - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + panic(XENLOG_ERR "Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..6a4f769aec 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -8,7 +8,7 @@ * Contributors: * Michael LeMay, * George Coker, - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. @@ -32,14 +32,21 @@ #ifdef CONFIG_MULTIBOOT int __init xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) + const unsigned char *policy_buffer[], size_t *policy_size) { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif + /* * Try all modules and see whichever could be the binary policy. * Adjust module_map for the module that is the binary policy. @@ -54,13 +61,14 @@ int __init xsm_multiboot_policy_init( if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); __clear_bit(i, module_map); + rc = 0; break; } @@ -68,6 +76,9 @@ int __init xsm_multiboot_policy_init( bootstrap_map(NULL); } + if ( rc == -ENOENT ) + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return rc; } #endif @@ -79,7 +90,16 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) paddr_t paddr, len; if ( !mod || !mod->size ) + { +#ifdef CONFIG_XSM_FLASK_POLICY + *policy_buffer = (void *)xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; return 0; +#else + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return -ENOENT; +#endif + } paddr = mod->start; len = mod->size; @@ -95,7 +115,10 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) *policy_buffer = xmalloc_bytes(len); if ( !*policy_buffer ) + { + printk(XENLOG_ERR "xsm: Unable to allocate memory for XSM policy\n"); return -ENOMEM; + } copy_from_paddr(*policy_buffer, paddr, len); *policy_size = len; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 15:11:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339756.564668 (Exim 4.92) (envelope-from ) id 1nw3Wa-000444-5c; Tue, 31 May 2022 15:11:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339756.564668; Tue, 31 May 2022 15:11:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3Wa-00043x-2Y; Tue, 31 May 2022 15:11:12 +0000 Received: by outflank-mailman (input) for mailman id 339756; Tue, 31 May 2022 15:11:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3WY-0002ll-34 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:11:10 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e544f357-e0f3-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:11:08 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654009835556426.3417674232287; Tue, 31 May 2022 08:10:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e544f357-e0f3-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1654009838; cv=none; d=zohomail.com; s=zohoarc; b=OJLP+9jHjwII8G59UpMBuxVdvooVsmxuTNH7LC2KmAx0uop8eEVZqSlsKLlUmjh5eWAwYMB7E5mKmx2i9atGSY9fNAqjtMfQN9l1g3eyE3tVRmJk3Syn/kUdEXtaM1FVL/OfBN3WY+hzpoA99PwtYpWBkchsRcqQlG+T8bAemKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654009838; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/itM5oH8P546jOtaqfXF7dt1u8YSqmz3yqRhRU6zukM=; b=F8CzgC5Dtk22p9lDWm9iTY/QcG3gEWSMcPfpCD2yJDLdvw7BfqO2zlPPHq0eefPyTd8/mpWJ3BElyKPkkJrUe4QswUvgRana7vuijqHGnsMdPW2oBAMFMjCSy1P5NrZvA/N3pc/f+szfex7nen/z5oLUb7BP3138GJFmi5ezS2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654009838; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=/itM5oH8P546jOtaqfXF7dt1u8YSqmz3yqRhRU6zukM=; b=KmdbP0tEpFHfezGkght3uPOAZUvNc3z9h4+3GkA0ohhmln8Gl7paPnEzEFr2vLD7 u7reg+w1tHmUAIKxGOlpnfCXlPNAdqwe3+19DNvJXRDoJHIpPTuMOlrX5f7u4ywizkf MauJ279SaiiWVvylqsJgtOsFSEZAdhS3gB7YYyNk= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Bertrand Marquis , Stefano Stabellini , Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Daniel De Graaf Subject: [PATCH v3 3/3] xsm: properly handle error from XSM init Date: Tue, 31 May 2022 11:08:57 -0400 Message-Id: <20220531150857.19727-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531150857.19727-1-dpsmith@apertussolutions.com> References: <20220531150857.19727-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit is to move towards providing a uniform interface across architectures to initialize the XSM framework. Specifically, it provides a common handling of initialization failure by providing the printing of a warning message. For Arm, xsm_dt_init() was tailored to have an Arm specific expansion of the return values. This expansion added a value to reflect whether the security supported XSM policy module was the enforcing policy module. This was then used to determine if a warning message would be printed. Despite this expansion, like x86, Arm does not address any XSM initialization errors that may have occurred. Signed-off-by: Daniel P. Smith Reviewed-by: Bertrand Marquis # arm --- xen/arch/arm/setup.c | 10 +++++----- xen/arch/x86/setup.c | 9 +++++++-- xen/xsm/xsm_core.c | 22 +++++++++++----------- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index ea1f5ee3d3..6bf71e1064 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -967,11 +967,11 @@ void __init start_xen(unsigned long boot_phys_offset, tasklet_subsys_init(); - if ( xsm_dt_init() != 1 ) - warning_add("WARNING: SILO mode is not enabled.\n" - "It has implications on the security of the system,\n" - "unless the communications have been forbidden between\n" - "untrusted domains.\n"); + if ( xsm_dt_init() ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); init_maintenance_interrupt(); init_timer_interrupt(); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 53a73010e0..ed67b50c9d 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #ifdef CONFIG_COMPAT @@ -1690,7 +1691,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period); - if ( opt_watchdog ) + if ( opt_watchdog ) nmi_watchdog = NMI_LOCAL_APIC; find_smp_config(); @@ -1700,7 +1701,11 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + if ( xsm_multiboot_init(module_map, mbi) ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); /* * IOMMU-related ACPI table parsing may require some of the system domains diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 8f6c3de8a6..6377895e1e 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,23 +10,17 @@ * as published by the Free Software Foundation. */ -#include #include +#include +#include #include #include - -#include +#include #include -#ifdef CONFIG_XSM - -#ifdef CONFIG_MULTIBOOT #include -#endif -#ifdef CONFIG_HAS_DEVICE_TREE -#include -#endif +#ifdef CONFIG_XSM #define XSM_FRAMEWORK_VERSION "1.0.1" @@ -190,7 +184,13 @@ int __init xsm_dt_init(void) xfree(policy_buffer); - return ret ?: (xsm_bootparam == XSM_BOOTPARAM_SILO); + if ( xsm_bootparam != XSM_BOOTPARAM_SILO ) + warning_add("WARNING: SILO mode is not enabled.\n" + "It has implications on the security of the system,\n" + "unless the communications have been forbidden between\n" + "untrusted domains.\n"); + + return ret; } /** -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 15:16:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339772.564679 (Exim 4.92) (envelope-from ) id 1nw3bt-0005Le-SG; Tue, 31 May 2022 15:16:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339772.564679; Tue, 31 May 2022 15:16:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3bt-0005LX-Ox; Tue, 31 May 2022 15:16:41 +0000 Received: by outflank-mailman (input) for mailman id 339772; Tue, 31 May 2022 15:16:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3bs-0005LR-5r for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:16:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aab39833-e0f4-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:16:38 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-33-TgkxTEMBOWuYIENMfnSkNg-1; Tue, 31 May 2022 17:16:31 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4819.eurprd04.prod.outlook.com (2603:10a6:208:cd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 15:16:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 15:16:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aab39833-e0f4-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654010198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mVMchtsxbO9suTZf/GVqqb/ifq0kA61qKm6O6h9u8dI=; b=HcJ8ypcjisRGCPOx7GUnxHPlZRLJJMoT738bcZp5/XUC0RqwGsoRjgid2Ef/Rca9+6fvcX gtXPWYo/ofNB8XhbALj81Fv/97bOJj86wxyNlXvPv5Ox2eatuPg4slfsyQpiWhQlCgxhlO AuSPdASHFZDNLiMoIsolmJ+DhFXS2UQ= X-MC-Unique: TgkxTEMBOWuYIENMfnSkNg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmkC66iq/dOa2+/U6CDdIu1SYMgexExooMDPioSLNdGcLpnaXnLoAD9jODdQpvfYtb0ERr5pbAMk+NKjwMETxCjblHP/8UblHOtuvDcnmzovFyqbFR4aujEgRtgxqxBmsN9uM6IXkM8xxesp/Xmh5pP+E4BcdYo07XiXKlC7jnqxqJLRdatVRJQBPEbi/AsXedt0XadZyi75sl4XwCzHuBgQ+otVROySPywCuwh5MPT3m+9aZbv/B8/zDnZNsCKdGD+e+M1AiVm/EDhvpyIJ+DG+Smj1wfEsI8eleVMPTW3VBEag+yTwgpK+K1oF4xhqUkUakEBheUy0kMDysl4ooA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JGNsVT/2X3jfLFHWXSIrC98CabJV1aAOdssUcDVOrsE=; b=E84qTX0MhTnI9yek4nTKdIr1Wfeno77DwqxrWqOfyRZptF0h4urm5F5qgReKAFceo+itipRsP6z+y17PqSElO9Y5sgwtdB0eqopwioX69PrOQw1pdkXiJgTFHTpQOplzYb/0hxPpaXQ3SIvZQAiHgf8e5TxqdkjoHAkxwMWKwdAoErhoQMVqS1U/ldETbMLPiH5Vf8oIHHL12IR7Em47GjBAhGwFYFJsqhspAtBt30YckGW3VSRPUyxyFMUJZasZU79FFL3DXr1oJ2tFkAzVrG6QwqELQftCsg9hTJFx1QgzrA7N9S978lb6XCsNSm5Ivc+LNRZMvKThxIIIMY1YHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <73072b2b-0cb8-6a7e-04fe-11dd2085e9ad@suse.com> Date: Tue, 31 May 2022 17:16:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: "Daniel P. Smith" CC: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220531145646.10062-1-dpsmith@apertussolutions.com> <20220531145646.10062-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220531145646.10062-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0301CA0017.eurprd03.prod.outlook.com (2603:10a6:206:14::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da885849-075a-40bf-699a-08da43187fe2 X-MS-TrafficTypeDiagnostic: AM0PR04MB4819:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QyJZQAA0WlMoI48iCRsx17SRTp+lxk9zPBO9z2ptAQXXxW302I8JhSaO5AWN4arpHcj0PoDsDAfoCbopGIV26G+f1p4Y2N9G9OE/pvv/Y3oOluI9nnLoc6zJ62q+TWcmCMqGZAeQsSba1ZFb95kt3E1sw6Ew83W8V/LmaThA3Ym3U8FncsHya9k3wR4XWir9ADiYQlQA+ZcQd3JikucxUoIIOrstMxlvGHgWTVZlk5J78I8BLIxg1+/nN35PbmXXUkRujdgc6h61ityv8ajZmT+drBKbx+NhY0b+XyKJoEtwjHPiAk/oxjxn4+oUBNo2pZ8xD+5lrsxQnkd0MP9BewBf+z2XH7C+EVUfG0Pwe0oDIYIDE924VaEdIGac/C3KwCY/8d2Yf7tF9s9PerQc6kVufi5Ry8JkmkcX3DTXSPYVBgNtD0rfxAqoTeDXKOpmkDEq4EN2j9cHzXJPG/Ou4VA5LcpuYCjfXSBdO47fwRoszR4b0jnm7fY0cPHdWNu5dcp5J4G/fQNenUi0RaIE+hyGgOwyKSsq3u+4lBTnia/pim3aB/jEXorfyc833/C19Ja52Z0rAHhouWrjPUDNQwG96GSDa0wrucBOTLkPi3fO/QLkcjltqBiNw0GERQ7zY//OzCHZYsjgVNeHWwpJK7Bh0W4Sv1537bIY7veLxAp+N+bCkhluOk361tm3rhjfmGUs7dEWswfXxVKkRWpoR9oZajaWxXmwbsfDsS+7jKI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(4326008)(66946007)(6506007)(38100700002)(2616005)(31686004)(66476007)(26005)(66556008)(6512007)(2906002)(36756003)(8936002)(508600001)(6486002)(54906003)(31696002)(5660300002)(86362001)(186003)(83380400001)(53546011)(316002)(7416002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n4ftJMRur8vpgYWODK9CFDMbu1PUj1eYHxZP4f5BPprRLcK+5blP6I+7j6l0?= =?us-ascii?Q?gWkGYrYlKOpOTySSZBGKlpKBWBYLATIUy0xJekoNRqY9Dz0fZ0qZP1uKpssE?= =?us-ascii?Q?K7kONOO2iRgbazHcRmfWBc6pC77OwZwhaIFnsUByMKwoPNhBjPULUXRGXyjA?= =?us-ascii?Q?mImMilSJMWHQQromLblt8Fo6WIRUbfZFHFhehx/AGNatQIPOiDzfFFeFzTtN?= =?us-ascii?Q?MRWF2gViWO7U7UDxQFYwzLbleS0pa5lAc8xMUuMON03BvYp1N818yEzUlmD7?= =?us-ascii?Q?EWuUX+cfWvJ9d/c+fyvpVx8uonVr02VtZg5jxZI2kalFlZ341YcFlbbZxWiA?= =?us-ascii?Q?XfxdS/x5dbgACrpQAl53goRDaKrvE1/vtotzfLzqWfnaBB6HldL7yRG8U2IX?= =?us-ascii?Q?j6ARAXz2kTv5eE8xjUEuDlcogRugtxt31nr2z5Nn9eQhOo2MlJqE0ELhpvMC?= =?us-ascii?Q?MvPECDXgE5LDi57ZXtViv0wwRi5F3vgUwGvyKsvxMaj4ElZAh5Ex8T+HxS9a?= =?us-ascii?Q?YxvMwoORqm9stOc8CAn9PZO/LrQh1ZJoRACzJ4bpT9gkysoY4ccP+EvZYM1l?= =?us-ascii?Q?riJQ0/8Meo+rv+bQbdAaeyjDAE9qzXCWsTcRRp5B0Fnj8IwIwiOw7IGoYLnK?= =?us-ascii?Q?hHmqoas/ntY3/nTpYy15oAAW48MPhpGKCKDaJ2F4DPurF0hsVrRjL0qxu+Ty?= =?us-ascii?Q?/X0s/E59doUvCg7e1TurnWRfAQQCjm3SaMq7IcqtvS3C/dco4PSollchIVio?= =?us-ascii?Q?ZntXhyqGzaOdSGQE2TXVRzmUVSq3+5+mR+JvNS5meGDMelfLjN0+6uU2nf6l?= =?us-ascii?Q?j9O/vM4ykmUhSREBQchDG0aDqx/5uodcYkTcHr7cXNm97Nyy9b4xx0UwStta?= =?us-ascii?Q?oQgXMscXxBkpYOv5vKlRQQkqq7Raj9k9hTNTkQUgihS5fOg0L3bWU5ZsfzJU?= =?us-ascii?Q?/bBn6p/c5JLMZOVrJk0pjwOIyaFWPz18m8VXEbJvVJBluUEe9kp8c0qAvban?= =?us-ascii?Q?9qxyVQRdD1ZQSENNg9EzwDjOGEduyXSDBj0mMhlqbjEP8vEgsRevryZnVBvk?= =?us-ascii?Q?NRF2eA3e6OC4UkEyV3aCY0F1fZAHF1Jgglc8d4JyuOIJUqfyOZlGPVh4p4gb?= =?us-ascii?Q?lH8hQoKclPY6HnYSm+T9v/PBV9qXDnen2WpJEtH12yNLFUDoqb4q2fgoRpnw?= =?us-ascii?Q?a7eLmT+B7DISW0JM14P64uIFO3UmEbFk04+qUT3XQksgxhFYgwvHd71blBTH?= =?us-ascii?Q?fLjwtW6LlzYSYXvMojuEnDcs/D5chN4ms3v3kmKKw3mWZm0qC+HsCHljsI0F?= =?us-ascii?Q?zGODYxrfxycev9F5sScbeo7h8/sB4XoiVXn8qeyEtyomTjCIV08Y6T0q0GjT?= =?us-ascii?Q?omhlv+ZdE8PtO2z/lajlfRrUOGD753J0d6pfrtO/wOgW4qFG4YhlDkg3UijS?= =?us-ascii?Q?U4nTlkhBACeeDQLR6rPIjhG4zA+Zen95rO9GzsPk+y2GhHdJ82fJsUI8kvJl?= =?us-ascii?Q?Qvm73qSQAwM6m4VMLyywSrXGCjc/inCmfhwVVavWqWfE92R/9LbFEErIpKOZ?= =?us-ascii?Q?Mg79eTiYtoCodUd03wLVAn2QNiGWD7hkNFhzahJtmnevIsCW+G12/W6Ej3L8?= =?us-ascii?Q?9yRdwo7DyhEhEqqKcIpDogHdyP83rRZ4pw+DgT8yoc5gcNtqOBfAgchMdBgP?= =?us-ascii?Q?/vU9lGFBiv4GzxX98xspUi1qpDilFfAgjLjUGhMn26lW+YQpyCxe0ed3cjAt?= =?us-ascii?Q?uZavLXpDeA=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: da885849-075a-40bf-699a-08da43187fe2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 15:16:13.3135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HM5hTswjfywejGHye8pmyIWa8tjMDr9q+62AlypFo2SkmYjCSqDLHnzmH2oA4nmRbhSV/hxZxucSMtdMPrPOoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4819 On 31.05.2022 16:56, Daniel P. Smith wrote: > There are new capabilities, dom0less and hyperlaunch, that introduce inte= rnal > hypervisor logic, which needs to make resource allocation calls that are > protected by XSM access checks. The need for these resource allocations a= re > necessary for dom0less and hyperlaunch when they are constructing the ini= tial > domain(s). =C2=A0This creates an issue as a subset of the hypervisor code= is > executed under a system domain, the idle domain, that is represented by a > per-CPU non-privileged struct domain. To enable these new capabilities to > function correctly but in a controlled manner, this commit changes the id= le > system domain to be created as a privileged domain under the default poli= cy and > demoted before transitioning to running. A new XSM hook, > xsm_set_system_active(), is introduced to allow each XSM policy type to d= emote > the idle domain appropriately for that policy type. In the case of SILO, = it > inherits the default policy's hook for xsm_set_system_active(). >=20 > For flask, a stub is added to ensure that flask policy system will functi= on > correctly with this patch until flask is extended with support for starti= ng the > idle domain privileged and properly demoting it on the call to > xsm_set_system_active(). >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Jason Andryuk > Reviewed-by: Luca Fancellu > Acked-by: Julien Grall # arm Hmm, here and on patch 2 you've lost Rahul's R-b and T-b, afaict. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 15:21:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339781.564691 (Exim 4.92) (envelope-from ) id 1nw3gR-0006kG-J3; Tue, 31 May 2022 15:21:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339781.564691; Tue, 31 May 2022 15:21:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3gR-0006k9-D0; Tue, 31 May 2022 15:21:23 +0000 Received: by outflank-mailman (input) for mailman id 339781; Tue, 31 May 2022 15:21:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3gQ-0006k3-5b for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:21:22 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5209ab2b-e0f5-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 17:21:20 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165401046882150.27441617519514; Tue, 31 May 2022 08:21:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5209ab2b-e0f5-11ec-bd2c-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1654010470; cv=none; d=zohomail.com; s=zohoarc; b=jXQL5afCFOHY0iy8n/JQfeFSw6x+Mt8NbKltWVAxIg+aJxl4WDkmHXm512nDm6u/yE7+g0PsZ7Skfd0/4aIGIeZO5EbmCjOdXgj6+Zo9dOcA2GQFikoJjLqX4CMGizIKwlYswxEFvI7rW/pDqDdQfziwVeVNJRwS6S8gaGw33vU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654010470; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OrjEDt0PWKPZrYPxCeiDha30EHSPR1QIo3aE2v8sutU=; b=E8DLoE7MNdiRw5XzOh0sInMROdVYLZvFnJu/bGfG5fMdiRlIbCGhc8g1hCgWu+tb5HDvFtQg35PbCKOEVXkMeGyIW76W6vlfKbS6E8rYGjdnQXZ8QFCzQCeyJk74PxT6inOtRREw2ZXb38yE4oO+WGMaxVCe3AVUHU/npp9OmtI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654010470; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=OrjEDt0PWKPZrYPxCeiDha30EHSPR1QIo3aE2v8sutU=; b=oi+azsdUUz55nUJWgB/U+fP9F6gq1Og91b/XBXf8RdGAdJhkestHIKHnLN+WAGDD 8sX4DYVKWqMd9cdAAyBOCOQfshpSAqPXJ3KiepJ3LjXUT34Ja9w2KUHdpud/ItV28SD 5qqXD0+Vvrlwzz4ixMXaMSmuMQHLsK/P/p8vwLxM= Message-ID: <28239bb1-686f-af94-0e38-b2e056c8acc6@apertussolutions.com> Date: Tue, 31 May 2022 11:19:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220531145646.10062-1-dpsmith@apertussolutions.com> <20220531145646.10062-2-dpsmith@apertussolutions.com> <73072b2b-0cb8-6a7e-04fe-11dd2085e9ad@suse.com> From: "Daniel P. Smith" In-Reply-To: <73072b2b-0cb8-6a7e-04fe-11dd2085e9ad@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 5/31/22 11:16, Jan Beulich wrote: > On 31.05.2022 16:56, Daniel P. Smith wrote: >> There are new capabilities, dom0less and hyperlaunch, that introduce internal >> hypervisor logic, which needs to make resource allocation calls that are >> protected by XSM access checks. The need for these resource allocations are >> necessary for dom0less and hyperlaunch when they are constructing the initial >> domain(s).  This creates an issue as a subset of the hypervisor code is >> executed under a system domain, the idle domain, that is represented by a >> per-CPU non-privileged struct domain. To enable these new capabilities to >> function correctly but in a controlled manner, this commit changes the idle >> system domain to be created as a privileged domain under the default policy and >> demoted before transitioning to running. A new XSM hook, >> xsm_set_system_active(), is introduced to allow each XSM policy type to demote >> the idle domain appropriately for that policy type. In the case of SILO, it >> inherits the default policy's hook for xsm_set_system_active(). >> >> For flask, a stub is added to ensure that flask policy system will function >> correctly with this patch until flask is extended with support for starting the >> idle domain privileged and properly demoting it on the call to >> xsm_set_system_active(). >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Jason Andryuk >> Reviewed-by: Luca Fancellu >> Acked-by: Julien Grall # arm > > Hmm, here and on patch 2 you've lost Rahul's R-b and T-b, afaict. erg, you are right, my apologies. Would you like me to respin as v9 to get it in there, so it is not lost? v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 15:24:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:24:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339799.564701 (Exim 4.92) (envelope-from ) id 1nw3jm-0007Zs-5p; Tue, 31 May 2022 15:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339799.564701; Tue, 31 May 2022 15:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3jm-0007Zl-21; Tue, 31 May 2022 15:24:50 +0000 Received: by outflank-mailman (input) for mailman id 339799; Tue, 31 May 2022 15:24:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3jk-0007Zf-QC for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:24:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce62c22d-e0f5-11ec-837f-e5687231ffcc; Tue, 31 May 2022 17:24:47 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-43-Q2GDql4qOHC12voHXuGANw-1; Tue, 31 May 2022 17:24:43 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7400.eurprd04.prod.outlook.com (2603:10a6:10:1b3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 15:24:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 15:24:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce62c22d-e0f5-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654010687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KjklcfaR88s4NlQvNtqCPvVeyqSk2X5x4BS25Bw1FvY=; b=l3UW5u7DP7BH5S5FQYVNYnCJ7nsLsKCn1XOduYjZUAeIYT7xJ7AF6ra/uv3EmLVAlILReS vtyeRjKM/HA7GZDVYltC0vWZ7A9PEbOWlp19E8PZ7DK616c7xZyKTJWtaSuoVHCDFPWrzE c2wPL5a2ekwqRzfL8oLPCNAqCgSmQE0= X-MC-Unique: Q2GDql4qOHC12voHXuGANw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mcb/hifkokMXg8BHNIvhJK2sREnlxKq6tXIktUOKVuCpPXTmcywQrFHLHJ6PdxyuwQtZ1wha9AaNkWJG8A7/JG4HqdVIlN26E4R0V0hn3r+f1EWqYkj1DJOS7j5QcO6csmzfXU1mvNhxUACNdxSxfX/hlaY0wqtySzHrvifOI5dxbOaK0RiNNhqiFCjFNaazkZy9MYK0uRwITJAVKJ74tpXiY+9SonKP/VXV0WBUMM8tDWYfq1NYDZWnO+dCX5n6cyavsAhaQWVFkxXI4803dxlFALF5VP/637p9ql2ADIXv+GngQNZIEz4WQ82m9nEmSNJnc1wGo+gTXdvKvAcpdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoBP46remYpKdGDxjL5PUvGN+MnUbVlVnLxc2Kbq3sM=; b=asAWeqV2dX995abquAxFXIwHTTFYEBoqszVo8JCYfi/Em3B91jmqc9dYAnDRFFzVYoAcuJaYCLCAMZ+q8NnR/MYOegz7/EmeS/7X5PSalMxVF1IgF+fID9De338ciPdyzz0EeheyyiBQEDvEmdEXkmVG5IwcyDqyLekMyjTTFzVyL0JC6rzl8frCJULfj3MPheTjMhyP1gRoK4Dx8EicqIHu0WO05m2g2D9he4/yVDJomgaDhwBk+2Q/PwcNjkhunthUGAqw6gToo5NC3/3YEYZFDwOMjjVOTOKLSIyp9zbcetiTj0Q+2s6gx5TogeDp8q4EgJ2TQuzJ/W9jzmrCmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 31 May 2022 17:24:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 1/2] xsm: create idle domain privileged and demote after setup Content-Language: en-US To: "Daniel P. Smith" CC: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Luca Fancellu , Julien Grall , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Dario Faggioli , Daniel De Graaf , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220531145646.10062-1-dpsmith@apertussolutions.com> <20220531145646.10062-2-dpsmith@apertussolutions.com> <73072b2b-0cb8-6a7e-04fe-11dd2085e9ad@suse.com> <28239bb1-686f-af94-0e38-b2e056c8acc6@apertussolutions.com> From: Jan Beulich In-Reply-To: <28239bb1-686f-af94-0e38-b2e056c8acc6@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM7PR03CA0004.eurprd03.prod.outlook.com (2603:10a6:20b:130::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d6a1782-6eb6-48fe-b6d0-08da4319aee3 X-MS-TrafficTypeDiagnostic: DBAPR04MB7400:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CFpCwf5WcsGv7oW38tw2O1rr77Z1dmUKZEtTdzxJAll/7Ab4nn+KHxMSwDnd3/lLPHUr5A/JVoZDzZYLKh7EJN6Z1Bd64guVQobVaPgcfChORR6ehl8Pn+eK/LCD+sAFocIgRmMSm3RRcKybmVtuanujILz9tNRW3kj7DnXElYGYMjO6BsAUSPlHo4B5FrEH6RdfZftsuV/vfGT30bYzKqnik+WgpKRFNzfo5jSAPjFaXR3FtxL1ZbisZKogSjE3aSUzBJFgV0ENGI/i5n8kPSsFZ59dsAAvA2DMgWP9xBuAQXE2vr9Pxre9Stq1afAL8COyGSXm1HSLEADi2nt9ahvBWivMlFsyqqH0mDmxBTnQ8QY++IoBHw6vlBXw5QEmtQQRGPRjCDyTb/xU2QS7KuebAavpJb31E0kStiSZro+pcUwoxov7Amz6lj3kv0mOM5rA/RbYLb/t27K2g5ZTGZ3k2M8JwUJypqMiicOEWwxRn+tYc4vhkiov2hpeYVGPqe8X9MsPehxxfHevVMQOwUWdKS+FqrFEa53JSMNNzGERYTnZUm9zcaG6XrbrHvSKJgbk+jmS5audMXEiVH7iWdC+D3Hs1NfLBipfUnv4drSsQttfnjmOGCSeab32Qwjx5OnT1LaCQ/RrYDn94QTY32fQCFnOP6XmmQus5NpWSVXnOZhNxiJi8NdU3/6haA6HhXPaC9a8b7WOxHLEcA3q0gHa+Xt2ywP90WJ0a5p0mgwpw5kY1wReaYaCBxN6LG05 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(66476007)(66556008)(4326008)(8676002)(53546011)(6512007)(31696002)(26005)(6506007)(2906002)(6666004)(508600001)(83380400001)(8936002)(6486002)(6916009)(5660300002)(7416002)(2616005)(36756003)(186003)(54906003)(31686004)(316002)(66946007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+wnTHPiLgCjXBBj8izmrjv0IkdIffL73qtxaRLcUvY152iaygIWY3k245j89?= =?us-ascii?Q?WA7u7OU/1ciRqQX4kKMJ/ClMyoMslpGtLG7GmbwSKsZ74StD7bopL3FsjK6U?= =?us-ascii?Q?GBXtcxEak+W1YBTnineo0HDlQS4lkfxub1MccDNokiwWDRovK0aVLVXjmqQj?= =?us-ascii?Q?Q37p5zUpHYyY/cCR8ujHjQ3/u3i2EtHURcBamge2qh8B+uQ6NmIos/YOMizP?= =?us-ascii?Q?+q8bOx6w774PwrqEu2uQhSLB+MWYTIAuD+NuBMdYjsqf84JNz7z0iKJ1+DbU?= =?us-ascii?Q?1bNJ/JNJZZjNJLEG5Da1FRVm28c2KPIMKgUHttid18FFPfobqdCXGokHdINr?= =?us-ascii?Q?TImAPkUpkAc9uaXuuEZIlfDlMkYRfdWWr+eAEvWjlnpkUShY71e/7doyHjx4?= =?us-ascii?Q?0wKPnm3GMELPIn1YJkaUsRo8+Jkv0WI6HJ0jgL4jSqn5no03pUlBfC8LDgYf?= =?us-ascii?Q?gzMvPdBKjtjbTc0ODsNqAhd2zEUuCcKzTsLit31fREGlZs7hkF0Y+1U5Fyv/?= =?us-ascii?Q?DmbJrQT2mq1AKmdj0sAnjnUn2f5diD/6kDK+wayaFoLyo2V6RV/Qes5KSVIK?= =?us-ascii?Q?yvSzX827W3kAaIvIc8ABrJhkNsz9xS/Rk4UMdDLpyQ0LoyhvaQWyAASVI/Jb?= =?us-ascii?Q?5bwJkbzkaogV28KXMDJmgXAj2uVEsCAtf81eCW/kCxKcFnoLvkg0l2mK+60M?= =?us-ascii?Q?XwTz3/U5cEVZh7RkQdq7adeER2URIzV93oiJlVqMeAWRHf2+1gRJ2CgJAeHl?= =?us-ascii?Q?FMOnSXmLQPRE4Is/rxvQTJRiwt1qo1448nTXRbIiiMIGn7t+1kcBrShd4Ria?= =?us-ascii?Q?HncNqquT+2ej7Gc1/6GUGWetGRYIEn+7o+iR+B1nX39I12mfNRefltD8fMn0?= =?us-ascii?Q?E5EXW/MOBVLcUNyDSyBRXZNxmn6mqEhonXvm0V6CG2ZbHTqth9HZhu4MsBMK?= =?us-ascii?Q?NGKrGsuvVFcKPbk86ZiskK+4irmtTlBpM1wTFgQ+cgvvP9KGncLoYglzJJqb?= =?us-ascii?Q?KrgRJkbfRDhk3F7DCH9gV1sBNqmdyTKK6P9HUMg/2/aOYEc2niU8c8+FviVP?= =?us-ascii?Q?yWSUVw+WStJ4YMbb5PVQE9qVEIMO2bnuV9yQywPFmdrhZWjIolLq0enAgLjb?= =?us-ascii?Q?URjWl93lR32BdSOgpZUq1JeLCOlx3+s0BLljjy+VJcRdIYJ+jCEF9muk36FF?= =?us-ascii?Q?Fz7GnJlLjR1CurTGbwAf4NOZvK3F13A+YuLUmDgAc1g8XIxJX7UkLzwBkT6/?= =?us-ascii?Q?0xWQ500e4uTKwMmgV93Eq77n1lnYVCmExTtERkzKLQa2wIy3hvDBLQ1JmBPx?= =?us-ascii?Q?IwSZ2BqC6wwjx3mTzGJR0OriXUmGWa/aKMEiNfAokvCHmogpC/E1CubGTdZf?= =?us-ascii?Q?0YPgCuGd/duq4Wr+SFqOQvYRgGlY8AlsCPabaX3VTbmGyocFgkkcl0/J+/sr?= =?us-ascii?Q?VBPWDdz1WISMix5MKoCHJUmnnb17i4rTt4E3fcYTP8eI1DXLMeVceNbBuPMe?= =?us-ascii?Q?B4kEkJVcSGGDdbIVoSK6WluPaeVwqIvpeAcC6rclv91wO84HJvtUQW8UZ3rn?= =?us-ascii?Q?hqu6E2iSZTmveTcfv29EbzcneS0NMG4tXI6/odjXABVBsbfcn/LTBDofCqdo?= =?us-ascii?Q?R/0McogI1iJMFw4/P77GhZxxjO0gmokdHNSvOIQg2NLyGvJfnRrzQX62yJ4T?= =?us-ascii?Q?e/fTt8Mfb/vd41h186QKmrl0WeSDMe9DtHU/mp/6BrLToFm6et2Cfz3thL1r?= =?us-ascii?Q?3LTeQwGHYw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d6a1782-6eb6-48fe-b6d0-08da4319aee3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 15:24:41.4998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XnVyCQtvj3eWO5EIz4QqvvGfAZ/7J34KwX7F7j6CePzcdDAT4pb8wdy26ofokT/j+7xw3QwaCt7He/3ALqSF8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7400 On 31.05.2022 17:19, Daniel P. Smith wrote: >=20 > On 5/31/22 11:16, Jan Beulich wrote: >> On 31.05.2022 16:56, Daniel P. Smith wrote: >>> There are new capabilities, dom0less and hyperlaunch, that introduce in= ternal >>> hypervisor logic, which needs to make resource allocation calls that ar= e >>> protected by XSM access checks. The need for these resource allocations= are >>> necessary for dom0less and hyperlaunch when they are constructing the i= nitial >>> domain(s). =C2=A0This creates an issue as a subset of the hypervisor co= de is >>> executed under a system domain, the idle domain, that is represented by= a >>> per-CPU non-privileged struct domain. To enable these new capabilities = to >>> function correctly but in a controlled manner, this commit changes the = idle >>> system domain to be created as a privileged domain under the default po= licy and >>> demoted before transitioning to running. A new XSM hook, >>> xsm_set_system_active(), is introduced to allow each XSM policy type to= demote >>> the idle domain appropriately for that policy type. In the case of SILO= , it >>> inherits the default policy's hook for xsm_set_system_active(). >>> >>> For flask, a stub is added to ensure that flask policy system will func= tion >>> correctly with this patch until flask is extended with support for star= ting the >>> idle domain privileged and properly demoting it on the call to >>> xsm_set_system_active(). >>> >>> Signed-off-by: Daniel P. Smith >>> Reviewed-by: Jason Andryuk >>> Reviewed-by: Luca Fancellu >>> Acked-by: Julien Grall # arm >> >> Hmm, here and on patch 2 you've lost Rahul's R-b and T-b, afaict. >=20 > erg, you are right, my apologies. Would you like me to respin as v9 to > get it in there, so it is not lost? Not sure; much depends on who would commit this if this ends up being the final version. (If you re-send, I'd suggest v8.1 rather than v9.) Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 15:29:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:29:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339809.564712 (Exim 4.92) (envelope-from ) id 1nw3o0-0008DL-P4; Tue, 31 May 2022 15:29:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339809.564712; Tue, 31 May 2022 15:29:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3o0-0008DE-LD; Tue, 31 May 2022 15:29:12 +0000 Received: by outflank-mailman (input) for mailman id 339809; Tue, 31 May 2022 15:29:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3ny-0008D8-BS for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:29:10 +0000 Received: from mail133-7.atl131.mandrillapp.com (mail133-7.atl131.mandrillapp.com [198.2.133.7]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 694924ae-e0f6-11ec-837f-e5687231ffcc; Tue, 31 May 2022 17:29:08 +0200 (CEST) Received: from pmta13.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail133-7.atl131.mandrillapp.com (Mailchimp) with ESMTP id 4LCGQp67hZzHXYrfr for ; Tue, 31 May 2022 15:29:06 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 32977d6bc0d145a2ab54db276006ee38; Tue, 31 May 2022 15:29:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 694924ae-e0f6-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1654010946; x=1654313346; i=marc.ungeschikts@vates.fr; bh=xGjweMUChBEpMJELXAky/wCxnWiJIfOGFy9r8gt2YLk=; h=From:Subject:To:Cc:In-Reply-To:References:Message-Id:Feedback-ID: Date:MIME-Version:Content-Type:CC:Date:Subject:From; b=CPxKZzodusRDVmjcji39TLJOlmw24ttlGsfjr+xcBq4Rw6aEwqRHa+Hr9nt4cd95Z wkN4IWPvvS8Stb1bW10BZ6yMn31K/34657hwW/wfoxS1z3xRDWh/LD0SJHQ6K3bXcU 9H3bhAY8qGf5R7QFJRqW/lWTv8AOKoanClVfOfTQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1654010946; h=From : Subject : To : Cc : In-Reply-To : References : Message-Id : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=xGjweMUChBEpMJELXAky/wCxnWiJIfOGFy9r8gt2YLk=; b=TId9DdzwbSpdtOcqfmj7yXcqbu6bqlYDXGzunrn2OalEOwScIKFCSe39Ie7kCmCv24JhHk vlauQVEIiYWqaQu9ellqW/WTkYIbmEFpl/t7BohjfUugLhg409MT7OPxrhKHHcHl4hZbqTbO ckF43DLSuPlmxj55Ea2gmJlCNbS7s= From: Marc Ungeschikts Subject: =?utf-8?Q?RE=C2=A0:=20Xen=20Project=20management=20working=20group?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 348ca8f7-dc84-4a0f-8a8b-6a438783ca12 X-Bm-Transport-Timestamp: 1654010944740 To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, george.dunlap@citrix.com, Olivier Lambert , christopher.clark@starlab.io, christopher.clark@starlab.io In-Reply-To: References: Message-Id: <20220531152904.A7C24E5EEC@mail2.vates.fr> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.32977d6bc0d145a2ab54db276006ee38 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20220531:md Date: Tue, 31 May 2022 15:29:06 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-QrtrINWR5ADZucrqzrYytQ" --_av-QrtrINWR5ADZucrqzrYytQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Following previous meeting of the 18th May 2022, I updated the report in Cryptpad(https://cryptpad.fr/pad/#/2/pad/edit/jIxKbWO9tQYhWQHb4w+gcgpk/) For the next meeting, here is the doodle to pick the date : - https://doodle.com/meeting/participate/id/elYKAv7a Here are some homeworks to do before the meeting, if it suits to you, : WHAT: Create some EPICS directly in Jira(https://xenproject.atlassian.net/jira/software/c/projects/XENMGT/board= s/5/roadmap)=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B and in Gitlab (https://gitlab.com/xen-project in the group) WHO: Christopher, Georges(Andrew?), Bertrand and Olivier WHEN: before next meeting WHY: The goal is to focus first only on the high level workflow (Product/Project manager view) in order to : - Give stakeholders visibility (list of projects and advancement) - Help with potential problem detection (specific status, bottleneck in kanban view) It will help us to choose the better tool and help us to start and see what might be missing We will manage other workflow later (maintainer, developer, potential contributors, ...) Regards, Marc UNGESCHIKTS | Vates Project Manager XCP-ng & Xen Orchestra - Vates solutions w: vates.fr | xcp-ng.org | xen-orchestra.com *De : *Marc Ungeschikts *Envoy=C3=A9 le :*vendredi 13 mai 2022 19:05 *=C3=80 : *xen-devel@lists.xenproject.org *Cc : *bertrand.marquis@arm.com ; george.dunlap@citrix.com ; Marc Ungeschikts ; Olivier Lambert ; christopher.clark@starlab.io *Objet :*Re: Xen Project management working group Conclusion of the Doodle https://doodle.com/meeting/organize/id/dyPg8MWb : The next working group meeting will take place *Wednesday 18th May at 3PM UTC* (4PM London time, 5PM Paris time) Meeting place will be: https://meet.vates.fr/xenmgmt See you soon! On Monday, 04/11/2022, 01:21 PM, Olivier Lambert wrote: https://doodle.com/meeting/participate/id/b822G1ge I will probably leave the Doodle opened for few days (like up to Monday evening) until we can decide the best schedule without waiting too long. When I'll have the validated time slot, I'll communicate about it here. So, as planned, here is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5PM London time, 6PM Paris time). Don't forget to add this to your calendar :) Meeting place will be: https://meet.vates.fr/xenmgmt See you soon! Regards, * Olivier Lambert | Vates CEO* *XCP-ng & Xen Orchestra - *Vates solutions *w:* vates.fr | xcp-ng.org | xen-orchestra.com * Marc Ungeschikts | Vates Project Manager* *Mobile: 0613302401* *XCP-ng & Xen Orchestra - *Vates solutions *w:* vates.fr | xcp-ng.org | xen-orchestra.com --_av-QrtrINWR5ADZucrqzrYytQ Content-Type: multipart/related; boundary="_av-Fm6KDZsPBN2qstBcksTWkw" --_av-Fm6KDZsPBN2qstBcksTWkw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Hello,
Following previous meeting of the 18th= May 2022, I updated the report in Cryptpad(https://cryptpad.fr/pad/#/2/pad= /edit/jIxKbWO9tQYhWQHb4w+gcgpk/)

 

For the next meeting, here is = the doodle to pick the date :
- https://doodle.com/meeting/partici= pate/id/elYKAv7a

Here are some homeworks to do before the meeting, i= f it suits to you,  :

       WHAT: Create some EPICS directly

in Jira(https://xenproject.atlassian.net/jira/software/c/projects/XENMGT/= boards/5/roadmap)=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B=E2=80=8B= =E2=80=8B=E2=80=8B

and in Gitlab (https://gitlab.com/xen-project in the group)

      WHO:  Christopher, Georges(Andrew?), = Bertrand and Olivier

       WHE= N: before next meeting

       &nb= sp;WHY: The goal is to focus = ;first only on the high level workflow (Product/Project manager view) in or= der to :

&n= bsp;           - &nb= sp;Give stakeholders visibility (list of projects and advancement)

&n= bsp;           -  He= lp with potential problem detection (specific status, bottleneck in kanban = view)

It will  help u= s to choose the better tool and help us to start and see what might be= missing

We will manage other= workflow later (maintainer, developer, potential contributors, ...)

 

Regards,

 

Marc UNGESCHIKTS | Vates Project Manager

XCP-ng & Xen Orchestra - Vates solutions w: v= ates.fr | xcp-ng.org | xen-orchestra.com

 

 

 

De : <= /b>Marc Ungeschikts
= Envoy=C3=A9 le :vendredi 13 mai 2022 19:05
=C3=80 : xen-devel@lists.xenproje= ct.org
Cc : = bertrand.marquis@arm.com; g= eorge.dunlap@citrix.com; M= arc Ungeschikts; Olivier La= mbert; christopher.clar= k@starlab.io
Objet :Re: Xen Project management working g= roup

 

Conclusion of the Doodle https://doodle.com/meeting/organize/id/dyPg= 8MWb :
The next working group meeting will take place Wednesday 18th May at 3PM UTC<= span style=3D"font-size: 12px"> (4PM London time, 5PM Paris time)


Meeting place will be: https://meet.vates.fr/xenmgmt

See = you soon!

On Monday, 04/11/2022, 01:21 PM, Olivier Lambert wrote:


https://doodle.com/m= eeting/participate/id/b822G1ge


I will probably leav= e the Doodle opened for few days (like up to Monday evening) until we can d= ecide the best schedule without waiting too long. When I'll have the valida= ted time slot, I'll communicate about it here.



So, as planned, here = is the selected date. I picked this Thursday, April the 14th, at 4PM UTC (5= PM London time, 6PM Paris time). Don't forget to add this to your calendar = :)


Meeting place will be= :

https://meet.vates.fr= /xenmgmt


See you soon!




Regards,

 
 

 
Olivier Lambert | Vates CEO
XCP-ng & Xen Orchestra - Vates solu= tions
w: vates.fr | xcp-ng.org | x= en-orchestra.com
">
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solution= s
w: vates.fr | xcp-ng.org | xen-or= chestra.com
--_av-Fm6KDZsPBN2qstBcksTWkw Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline /9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/ 2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEB AQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB0ALsDAREAAhEBAxEB/8QA HwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUF BAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkK FhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1 dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXG x8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEB AQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAEC AxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRom JygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOE hYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU 1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+/igAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoA/kj/4O5fhR 8ftE/Y7+FP7bf7Nnxe+Mnws8Ufs1/EnTfDPxTX4XfE7xx4EtL/4VfFG7ttN0 nxNqll4b8T6XY3+o+D/ipZ+CdM09xpNzqP2Lxzql5cahBYaKsLgH7/8A/BN7 9r/Rf29P2HP2a/2sdHawS5+Lnw10rUvF2n6a0P2PRPiNoclx4X+JWgwQxajq rWkGj+O9E8QWNpaXV/cXsFlDbLeP9oMgoA+sfHvjnwt8MfA3jP4k+ONXttA8 F/D/AMK+IfGvi7XbwlbXRvDPhbSbvXNd1S5IyfJsNMsbq6k2gsUiIUEkCgD+ Kn/g2R8Y/tIf8FEf26f2/wD/AIKdfGb4kfF29+ENr4s8R+Bvg18Kda+IXjS5 +GPhvxl8UdYh8WX1ppHg6TVbnwiL/wCFfwpsfDfhiC2thJaWEPxCN+uni5fS b60AP7FviR+0t+zl8HNUg0P4vfH/AOCfwr1q6gFza6R8SPir4E8D6pc2xCsL iDT/ABPr2l3c0BV0IljhaMh1O7DDIB6L4O8beDPiL4c03xj8PvF3hjx14R1m J5tH8U+Dtf0rxP4c1WGOR4ZJtN1zRLu+0y+iSaOSJ5LW6lRZEeNiGVgAD4p/ 4Kn/ABh8YfAf/gnP+238V/hp42PgD4peAv2Xfjb4x+G/ie2n0pNW0jxd4a8B axqekapo1vrENzaXeoadfRW09vE9ndfv/JAhaRowQD4F/wCDdH9sn4t/tYf8 Euvhh8a/2rPjUnxH+L+v/Er4y6TqfirxZd+FtH1a60rw746v9M0Syay0m00W 0WGw0+OGGA/YhM0RR5JJA6NQB+91peWmoW0F7YXVtfWdzGJba7tJ4rm2uIm+ 7JBPCzxSxt2eN2U9jQB5r8Tfjp8EvgpBpl18ZfjF8K/hJba1JPFo1x8TfiF4 S8BQatLbKjXMemS+KtX0qO/kt1kjadLVpWiV0MgUMuQDo/AnxD8AfFHw5aeM fhl458H/ABF8I37yx2PirwJ4m0Xxd4cvZIGCzx2mueH73UNMuXhYhZUhunaN iA4UkUAdhQB89eNf2uf2Ufhr4kvvBvxF/ad/Z68A+L9MZE1Lwr41+NPw38K+ JNPeVFkiS+0PXfEthqdo0kbpIiz2sZdHVlBVgSAe0eGvFHhnxpoeneJ/B3iL QvFnhrV4BdaT4h8Navp+u6HqlsWKi407VtLuLqwvYCysomtriWMspAbIIoA3 aAPNfizb/GG48FakPgXq/wANtI+IsRil0d/ix4e8T+IfBN4FcCex1SLwh4l8 M67p4njLGLVLOfUjayohfSbyNmQcOYRzKWFn/ZVTBU8YmnTeYUa9bCySfvQm sNXoVYXW1SLnytK9OS0PqOD6vBdLPMM+PsHxPjeGpKcMZHhDMsqy3PKLcf3e Iws85yrNcvxPs5pc+ErU8N7aDfLjKEkm/wCZX9sf/gr/AP8ABW/9hTX/AOy/ j9+xh+z1p3hq8v207w78U/C6/FTxL8K/FUx+0NbppHi638Z26WV/eQ2txdW/ hzxRZ+HfFn2OJ7mfQYIVL1+H8S+I3iFwnW9nm3DOURoSm4Ucfh1j6+AxD15f Z144pcspKMpRoV40cRyJylSikz/U7wR+hh9Dn6QGXLFeHvjj4jVs1pYeOIzL hLN58JZXxZlMP3SqPGZRVyGcsRQo1K1KhUzPK6uY5Q6840aWYVZtJ+g/se/8 HL/7P3xNudJ8H/tbeAdT+AHii9lgtB8Q/Cv23xr8IpbiRp1M2s2yK/jnwbDI /wBihgK6Z4z02Iy3V1rGu6PZWnny9XDfjjk+PlTw3EOEnlFebUfrlDmxOXtt y1qx1xWGTfIo2hioK8pVKtKMbv5/xr/ZZ+JHCdLGZ14PcQ4TxFymhCdZ8N5r 7DJOMYU4qm/Z4GrJxyHO5xiq9SrzYnI8TJQpUcFgMdiKvs4/0heAPiH4D+K3 hHRPH3wz8YeG/HvgnxHZpf6F4q8JaxY67oWqWsg/1lpqOnT3FtI0bZjnh3ia 2nV4LiOKaN41/a8HjMJmGHpYvA4mhi8LWip0sRh6kKtKpF9Yzg3FtPSSveLT jJJpo/zE4i4b4g4RznHcO8U5LmfD2e5ZWlh8wynOMFiMvzDCVY/ZrYbE06dW KkrSpz5XCrTcalOU4SjJ9jXSeIFABQAUAFAHgf7VH7PHgv8Aa0/Zv+OH7M/x D3x+Dvjj8MvF3w31q8hh+0XWkJ4m0i5sLLxBYwGe2WbUfDuoyWeu6bFJPFE9 /p1uszeUXBAP4/f+DRP9orxx8HvE37bP/BI/493L6P8AEv8AZ0+I/iD4geBP DmoXsf8AogsPEMngH42+HtBjvLmG5utMsPFdn4X8XaYNM097e7h8Va7rc0yx XEJkAPu//g7V/bYH7Mn/AATLvPgT4b1N7P4l/tqeLrf4TaRDaTRpqUXw18LT 6V4t+LeqQQk+bNZXFh/wjfgPUTArOifEGAHb5gYAH23/AMEov+Cceo/so/8A BGrwD+x5bate/CH4y/F34F+OvEHxT8f6LYXsXivwd8bv2gvCt/Nf+JZrYS+F tUuPE/wntdX8N+E9Pia80bUI7f4e6TYLqlvJbJfgA/Pzwj/wahf8EdfhV4Rt X/aT8TfFr4weONRc3Gu/FP4rfHzUfhzca7q8qIb+4stL8L6h4Z023glu3kuI re+ude1GFZUiu9Wv3Vp5QD8Zfjr8MfDH/BtP/wAFIv2Qfjl+xB+1TqXjj9hb 9q34hTeBv2gfgHq3xC0Xxx/wjnhyx17w9ZeLBqw0U3Fvrdr4f8NeLrPxR8Mv F15pln410nW/DOpaDqOu6tpGsammogH9Kf8AwcYfsEfs7/tZf8E+fjp8c/jJ pfi3UPHv7Gn7PH7RXxW+CE/h/wAX6l4e0nTvGcngKPUku/EmkWivZ+JbOO88 KaQRZ3yAC2+3W0csaX0xoA/nv/4IEf8ABvz/AME5f+ChP/BNj4a/tLftGeFf izqXxT8RfED4t+HdXvvCXxb8QeFNFn07wn42v9F0VYdDsYXtLaSLTreGOeSM 77mYPPKxZwqAH9Dv/BRz9oj4bf8ABvz/AMEdhZ/s52Nwt78PrLR/2d/2UNE8 e6nd+L5W+JXjybxLrmlX/iC+vkD67B4M0Gw8bfEGbTbz7NaarZ+Eh4dVraG7 i2AH5B/8E2f+Dbf4c/tvfBfwx+3x/wAFf/iX8bv2lv2kv2rvDWk/FX/hFrz4 ka54Y03wN4P8U28Op+B49T13w9dW/iDWdfvvCMmkX/8AZNjqGheDvBunX9t4 P0fw066GuqXIB8rf8FDf2QPGX/Brv+0N8A/+ChX/AATt+IfxDuv2Rfit8TLD 4V/tC/su+OPFN3r+i6iW07UPEMXhp9Uuk/4nekeIvC+keKpPBniLxBb3njD4 ceMNIgvIde1vTtbm0+3AP2z/AODnP9uf4t/s8/8ABIXSvit+yb491Lw1J+01 8UfhV8LV+KnhKa+03xFpHwg+J/w9+IHxDvdd8JaxEkN/4d1DxTp3g/SPDUet R/Y9U07S/FN82mXGna21hd2wB8o/8E+/+DXj/gj98XP2PvgT8XfH2o+N/wBq /wAZ/Fb4b+F/H3if4x6D8bfFnh/w1qviLxVo9lq+t2HhnR/Aer6XZ6fp2g6n dXWkpZ+IH1TxNBcWs8fiO5/tNZ7W2AP2C/4Jlf8ABFX9nX/glF8Uv2gvGf7M vxA+LF54A+P2i+CrG5+E3xE1my8TaT4G1PwZq3im/h1Hwv4ghtdO1O5t76y8 SR6bLb6/b6rqqDTUnl1+6WcW1uAfsfQB+dn7cvwg/b78TaFfeNf2Ef2qLT4Y +NtO0wF/g94++Hnwx8U+AvGk9qjAnR/GXiTwfq/iTwP4guogEi+13OreFb67 SFLq28PrPd6zH8bxVl3FtelPFcKZ9HA4qFPXLcXg8BXwmJlFP+Hia+Gq18LW krJc0qlCcklJUeaVVf0n4CcZfR5yrMMPkfj/AOE1birIsTi3bjTh7iTirKuI Mkp1ZKyxuSZZnWCyvPcuozvKbo0sJm1CjKcqdTMvZ0cDL8M/2d/+C6zya74n /Yt/4LCfA/TdC1H7dcfD7x944vfBcY0KKSVYYns/jF8JXsry2gsrjfHqC+MP A63GjS2l1p2pWHhW10xV11/yrJvFdutX4X8R8qp0ajnLB4vFTwy9ld2XLmOX uEoqMrqX1jCp03GUJww6p/vn/fXiV9ABRy3K/HT6FvHuKzHBrD0+I+H8iw+d yeYcsHKSrcG8XxxFGtKtSSnQeTZ9KOMhVo4rDYnOamJl/Z6+IP8Agrr/AMEa fC3wI8GP+2f+xFfw+N/2V9ehsNe8SeEtB1d/GUPw00bXFtjpfjLwb4pivtWm 8XfCnUpbmMyXlze3t/4VFza3MupatoFxLd6F8r4jeGeHyrCvifhaaxWRVVCt Xw9Gp9ZWDpVVH2eJw1eMqjxGAm5L33KU6HNGUp1KUnOl++/Qw+nBm/HueQ8D fHjDzyLxXy6eIy7K85zHBrJKvEuOwEqqxWSZ3lNShg4ZNxZhIUpKOHp0KFDN PZVaVPC4PH0oUMf+Pn7IP7dv7Tf7DfjYeMv2fPiLfeHra9uYJvFHgXVVOtfD vxvBFsRrbxR4UupBZ3Ez26fZodb05tN8S6bEx/snWrB/mr824b4uz3hTFfWc oxk6UJSTr4Sp+9weJirXjXw8nySbiuVVY8laC/h1YPU/tjxq+jx4VePuRPJf EThrD4+vQpVI5TxBg39R4jyOpU5pKrlebUY+3pwVSXtZ4KusTlmKml9cwOJg uQ/0AP8AgmV/wVG+Dv8AwUc+HN1c6JBb+APjn4Lsbeb4n/By91OO9vdNgkmS 0i8X+D72SO1n8S+BNQupIIDqIs4b3w9qdzBomv28Mlzo2oa5/X/A3HmW8a4K U6KjhM0w0E8flsqilKmm1FYjDyajKthZyaXPyqVGpJUqq1pVKv8AzlfSo+if xt9GTiinh8wlV4g4DzuvUjwpxrQwsqNDFTjCVaWT5xRhKrTyzPsPShUmsO60 qOZYWlUx2XzkqWOwuX/qDX3Z/KQUAFABQAUAfwJ/8FebK+/4I+f8HFP7Hv8A wU38PifRfgN+1xqek6X8dDY2jw6TFHaWnh/4QftB21xbWV3YwX98fAWteEPj BpMWqXNvFqnj+1uNQnW4i0y6cAFP9rQ2v/Bar/g6K+Ef7Mdi48Zfsuf8E94z B8SFgb+0/Cdxd/CW5Txz8XIb+zubXUdJkbxJ8Zbnwl8CPEMV1YxLqcPh427z 3Fla2k4AP6lv+C3v7bvj3/gnr/wTO/aP/aZ+FENk3xU0LS/DPgr4cX+o28N5 Z+HvF3xM8WaN4F03xdJYXVrd2OpS+EE1y48TWel6lC2male6VbWV+s1rPLbz AH86f/BNn/g3F+DH/BRD9lX4S/t1/wDBTD9pf9qj9pP44ftReFLL4ry2LfFx 7fRfCWh69PcHw1YSa7qdr4s8ReIdYl8NQ6TLqEn9raNpOib4vDOlaBa2+iC8 vgD8YP8Ag5T/AOCU3/BP/wD4JZal+x74T/ZJ/wCE+074l/FfUfiH4i8f6H44 +IN/41uI/A/h6fwfpvhTV7a3uNNs4dLivNfu/ElnHMszSXz6fcoIttmzgA/v +/4LNAt/wSY/4KPgAk/8MYftDHj0X4aeIWY/QAEn2FAH5pf8GlBB/wCCLfwb AIJHxe/aABAOcH/hZOqHB9Dgg4PYg9CKAPmH/g9J8I+J9d/4Jg/BPxHo1rf3 uheCP20vh9qfi9LS3mmttL07WfhB8cPDml+INUkjUxWllBr2qad4eiuJyqtq XiiwtEJkulUgHm/7Hf8Awbz+CP2mf2Uf2c/j38PP+Cv3/BS208G/Fb4MfDrx fpGkeGfjdbN4f8OHUPC+mDUfCWlxWqLBZ2vhDVor7wwumIqnSW0htMkHmWj0 Aep/EL/g0g+F/wAWtDj8MfFP/gp7/wAFDfiX4cg1CHVrfw/8QvHfh7xpocGr W0E9tbapHpHiPTtRsE1C3t7q5ghvEgS5iguJ4o5USaQMAf0P+P8A9gz9n340 fsTaJ+wX8efDjfGH4KaZ8IPAPwjvG8SeTY+I7+P4c+HdG0Lw344s9T0WKx/4 Rzxzp93odl4i07WtASxOmaym+ziS03WrgH8vni3/AINO/jh+zzqeueKv+CWn /BWH9pD9mO8uTeXNl4F8S654z8PWOoTy3qT2ml6r8Svgj4p8F3SaPBbmSC4G o/C/xXPfbIhdpKJJywB7R/wQb/4Knft++Lf23v2kf+CRX/BTiXQ/G/x//Z38 KeKPE/hn4x6daaRa63rcXgjxD4Q0XU/Dev3nhmx0rQfF+la54f8AGWkeNfA/ jI6Fouv3GkW2oweLW1DVr60SwAP666ACgD+OX/g6Y+D/AMO9J1n9lz45abZ2 mnfE7xinjz4eeKJrZLeGbxN4X8JQeH9Z8PX2oJHEs1zd+HbvXtS06K/mleRr HVbWxbMFhaJD/Nnj5luDpzyLNYRjDHYj63g67jyp16GHVCpRlNJXlKjKtOCm 3dxnCDuoRS/2y/ZI8a8SYvC+LHAOJrVcTwtk74f4jyuFV1ZwyvNM3nmeDzGh h5yqOnSo5jSy/DYmWHjBRWIwtfER5Z4iu6no/wDwbSfEvxl8aPgH+1z+yr8U YpvGXwI8HWPheHQbDXTDf6Voul/Giy+IumfEDwGINQ+0RSeH/EMOivraaSsD adaXl54kubqJ317a3b4H47E5pk/EOQY9PE5ThoUFShWtOnSp5nHG08ZhLTun RrKk6vs7OEZyrykm62vy/wC1L4VyPgTxF8HfFvhKcMj8QM6r5rUzDEZfz4fF 43FcEVuGsVw7n/tMN7OcMxyyeOjgXjHUWJq4elldKjOMcuTX8ffjnStO0Hxt 4x0PSJGm0nRfFXiHSdLleVZ3l07TdXvLOykadQFmZ7aGJmlUBZCS6gBgK/m7 G04UcZiqVNt06WIrU4NvmbhCpKMW2tG2kndaPdH+1fDWNxWY8O5FmGNio4zH ZPl2LxcYwdKMcTiMJRrVoxpyblTSqTklBtuCXK9UfcX/AASj+JXj74Xf8FEP 2TNY+HdxfJqniP4y+DPh7renWU6QLr3g3x9rVn4Z8W6Le+aGt3s59Gv7i6Ju FaO1urO11CMx3NnBLH9X4eY7GYDjPh+pg5T562Y4bCVYQdlWw2LqxoYinO94 uLpTk7te64qatKKa/Afpi8LcOcWfRq8XsJxLTw31XK+C874iy/FYinKo8vzr IMDXzTKMZQ9m1VjWjjsNRpWpyTq06tShNTpVZwl/p61/dh/ykBQAUAFABQB+ J3/Be7/gl54j/wCCrP7C178Efhfc+CdI+PXgT4i+D/ib8Gde+IOqapoXha21 OxupNA8Z6TrOt6LoPifVLGz1nwDrniH7Ktvod7HdeIrDw9DePY2Zn1G0APj3 /g3M/wCCJHxh/wCCU2lftM/EX9qjXPhn4y/aH+OviDw3oWm698OPFGv+NNO0 r4XeGoLnWriO51vxT4K8H6xBr/i/xtrd/f8AiWCNdRtL+18N+E7qWdb2CaNQ D9pP+ChP7FXgD/gob+x58bv2Q/iRqV5oOhfFvwzFZ6b4o0+Jrm98H+MtB1Ox 8S+BvF8NgLmzTVV8N+LdI0fVrnR57q3g1iztrjTJbi3W6M8QB/KV+yb+zV/w dc/8Ev8AwAn7Hf7PXgz9jL9qb9nzwZqM8Xwq8ffETxjot1pvgrQNavbrV73T vDP9rfET4H/Eu30mDU9Wu9QvtC8XeGPFqaNqC3On+ELy50CO0S6APC/25v8A g2N/4Kn/ALaOn+BP2jfjP+098Dfjv+3n408c+I7341ax4k8a+LvAnwT+GPwe 0fTtCT4TfCD4N6Tovwiv5NSj03V7jxprHiDVT4b8G6dYyajZWFho+u3ra14v 14A/uk+Ofwe8HftC/BX4t/Ab4hW0t54E+NHw18b/AAs8Y28DIlzJ4a8e+G9S 8L6z9kkkSRIrxLDU55LSZkYQ3KRS7SUxQB/HN+zf/wAEdv8Ag48/4JlaN4y+ BH/BPf8Abv8A2Otd/ZdvPHmu+LfBOifF/RdQPie0k1iKxiutX1Hw/wCIP2f/ AIgReDdR1NbOE6noPhP4k6/4bnvoJ9ZWG3v9TuwwB/S9oH7KXj/9qr/gnPY/ sof8FRm8EfFr4mfFD4W3Pg/9o/VPhkYdL8M6l4nbV7q+0rxV4Bubfwx4Yh0X WfDktr4d1/w/qNt4XsItK8TaTBdx2FxFBi4AP5nfhD/wTK/4OLP+CNl94j+G n/BMv4y/s/ftpfsg6v4k1nVPBHwd+Ol5p3h7WvBLarIup3Wsaj4e8V618P7T wpqFxfXV5BfR/C/41Xvh/wAW6j9q8Va54I0fUb+K2sgD2jVPgl/wds/txxr4 M+L3xq/ZI/4JvfDCe5s7HxlefBu9g1D4ja/okt3Dc3d54T1TwZqPxq8UW2pW iRfZ2sbX4wfCOHUbWSe0utSmhlcOAftv/wAFaP2d/wDgoh+0F8FPhVH/AMEy /wBpjwt+zJ+0P8MfjfofxFvde8davr2meCvHPgOy8HeNdE1fwJ4jtdJ8EfEr S/ENpd65rXhzWovDvi3wLrPhnUZtGU3s+nSwQTuAfikPin/weS6Rpb+Aj+zd +wF4ovIbZ9DX41nXPAdvql3IU+yjxkmlL8e/Duhpcqz/ANpJaS/CW1tS8exv CjR5sHAPrj/gih/wRR+M/wCxD8bf2gf2+v27/jfoPx+/b6/aat/EGj+LNZ8E T6jeeAvB3hbxV4n0Xxh4jjtNS1Xw34Pm1rxT4l1jw54cS8OneEvDvhnwVo+i Q+EvB9veaNNcahdgH9I9AHx9+2D+3d+zN+wz4CufHPx/+Ien6LdPaS3Hhr4e aNPp+q/FHx5NG4iFn4M8FvqFle6kDcMkF1rF7NpvhnSHkjk13XdKt3E1fOcR 8V5HwrhJYrN8ZClLlcqGDpOFTHYtp25cNhueMprmtGVWbp0KbadWrTTuftHg v9H/AMUvHviGjkHh3w3iMdSVeNLM+JMdDEYPhTh+Eo87rZ3niw9ehhmqSlVp YHDwxWa4yMZRy/L8XUXsz+NbxX8L/wBvv/g4J/afj+L+k+AW+FP7P2gwSeE/ BPi3xhHqlp8K/hr4BsdXmuL6z0rVVsYp/ih8StUurma71/8A4Ry0eS+1dbHT NTu/CnhTSdNfSP5pxOX8XeMOerMYYT+z8mop4fC4jEKpHA4LCQqNyjTqcl8b jakpOVZUYuU6nJCo8Ph6dN0v9t8l4u+jv+zi8KqnBuJ4hjxh4k5lUhm2e5Pk 0sJX4r4k4gr4OnChWxeF+sSp8L8MYWjTp0su/tGtGlh8J7fEYSlm+cYvGLHf oz+2p+0n+zN/wRg/Y31f/gn5+xpr9r4s/af+Iel6nZ/E7xsZrHUfEPg258Ua VaWPiX4ifEO50y4gi0jx5qnh66XTvhR4Jti48KadDp3iHV7eSysrP/hNPteJ 88yLwx4aqcIcNVYYjPcZTnDG4i8J1sPKvTjGvjMZKnJKni6lGXJgMMm/q8OS tUTjGP1r+ZvArwt8VfpyeN2C+kT425fXyjwq4cxeFxHDGS8lfDZbnNHKsXWr 5Xw5w3TxdKrLG5BhsyovEcW51UUf7XxMsTluCnCpVr/2F/G7pum6jrGoWGj6 Pp97qurapeW2naXpemWlxf6jqOoXkyW9nYWFjaxy3V5eXdxJHBbWtvFJPPM6 RRRu7Kp/manTqVqkKdKE6tWpKMIQhFynOcmoxjGKTcpSbUYxSu20krn+4GLx mDy3CYjG47FYfBYLB0KuJxWLxVanQw+Gw1CnKrWr161WUadKlSpxlUq1JyjC EIynJqKbP7X/APghr/wRn8Wfs+a3pX7Y/wC1doh0T4sPpd7D8Hfg9qEccmo/ Da01eKSxvfG/j6KSBltPH2oaa09p4d8OW1zKPCejapdXevkeL7yPSfBv9R+F PhniMlqU+JM/pezzGVOSy7LppOeCjUTjLE4tNe7i5wvGjRi39XpzlKt/tElT w3+EH0/PpwZR4l4PF+CnhFjvr3BtPF0J8ZcaYeUo4fietg5Rr0cj4fnCovbc PYfFclXMszqUo/2vjMJRo5b/AMI1KeLzv+pSv3o/yYCgAoAKACgAoAazKis7 sqIoLMzEKqqBkszEgAAckkgAcmgDFu/E3hywkEN9r+jWcrBWWO51OygdlYZU qssysQwIIIBBBGKXNHuvvQ+WX8r8tHr6aa/I07e9s7sBrS7trlWRZVNvPFMD GxIWQGNmyjEEK4+U4OCaE09mn6aiaa0as97PTTuWaYBQAUAFABQAUAFABQAU AFAHyp+0R4N/ZT8OaVrHxj+OXwM8D/EPUo7ex0mS+T4BJ8a/iTr20G30zQtF 0LQPBni7xtrhQMwS1sbKaz061E99fSWOnW91dw/P5zhuH6NOpmWbZVhMZNKF Nz/shZpjattKdKlSo4XE4qrbpGMHCnG85uEIykv1zw2zvxdzLFYPgrgHj/P+ GsJKpiMbHDvxFnwLwvl/NapjMwxuPzDPMmyLAc1k5VK1eFfF1nTw+GhiMVVo 0an84n7cX/BUD/gpB8QvD9z8IP2E/wBhH9p79nH4ZWtsdFh+I9/8CPF8PxMv tAgims4bHwj4d07wrceHPhZp7WhiEEthca14ks1jhk0vU/Dk8TRn8W4q4740 xlGWW8J8KZ7k2CjH2Sxs8qxMcbKjFOEYYajChKjgIONrODqVopL2dWg00f6a eAX0U/ox8O5nT4z+kF9IHwq8SuJ6tRY6fDOG4/yarwxRzGrKFepiM4zLEZtT zHivERrc7nHE08HlleUqkcZg8ypSjN/lz+yj/wAEFv2+P2s9Xj8b/F7S7z9n XwR4g1F9S1nxz8bI729+JWuveXlw+q6nY/DSW+g8Z3upySK139q8cXHg611h ry3u7LVL6CWe5h+C4f8ACTi7iKqsXmcJZPha03Orisz5pY2tzSbqThgnOOKl Nu8ubFPDRq80ZwqzTlJf1v4vftDfo8eDmBlkHA+JoeJOeZdho4XA5DwNKhR4 YwEaNCmsJhq/FEMPUyOhhoxkqKpZHDOq2B9hUoYjBUKkKdKf9c37CX/BIn9k P9g2DTfEPgnwo/xD+NEFikGo/Gv4hxW2qeKEuZYEjvz4P0wK2jeAtPuZPOWK HQoDrJspvsOq+IdZVTK/9FcJ+HfDnCUYVsJh/rmZKCjPM8Yozr8zSU/q8Lez wkJO9lSTq8j5Klaqlc/xo+kD9Mrxm+kJVxWX5/nC4d4JqYiVTDcDcOVKuFyl 0o1HLDrOcU2sbn9elHkcpY6ccAsRB4nB5bgpS5Y/qNX3h/J4UAFABQAUAFAH x3+27+3H8Bf2BPgnrPxt+PPiU6VpFtKuleGfDumwHUvFnjvxZeW91Po/g/wd oUUkdxrPiHV/sdybW1EltZ21ra3+r6zqOj+H9K1jWtN1oUKuJqxpUY803q7u 0YRXxTnLaMI9Xq27KKcmk8MRiaOFpSrV58sI2SsuaU5tNxp04rWU5WbS0SSc pOMU2v4IP21v+C/v7ev7WWt6vp3w98aXv7Kfwjee5i0Pwj8JtSeH4j3enO7i C68Y/FM77y21l7dgjW/w6tPC1rpytNYya14mQvqd19Fh8rwtFJ1V9Zqaczmm qKdtVCje0ku9VybfSK0XyuJzrGV21Rk8JS1UVTadZro51rNxlbdUvZpXs3LV v8b9a+IfxL8Talc614n+Kvxa8TazeytPeax4j+KvxD13VLmZiS0k19qniW6u WYkkgCQIucIqrgD0IxjFKMKdOKW0Y0qaXpZRPKlUqSblOrVk93KdWpJ/Nyk2 fS37Of7cP7dPwB8TaHH+z9+018cdKu47lZLDwXrHjvXfiB4Eu/IcXEwv/B3x A1DXfD1np8Uauby/sl0W5sbSSdrXVLGV0lHBmc8pwWCxGY5q8NhcHhoKVfFT i4ThzNQpxh7CPtq1erUahh8PTjUq16j5YQk0e/wvlfFPE2e5bw1wnhMdnWe5 rVnRy/KqE4yjWdKm62IrYieKnHCYLAYOhGWIzDMcXWw+EwOHjKtXr001f+nD xB/wVy/4KL/E/wCCOg+DNe1r4ffs5eOL7wvFa+IPid8IvCNxr3jPUPEO2SSP X9AsvinJ4h8NeEtHkhewkvPDN1o/ibxBcSi+a18WaDbXdlDa/wA1Zp4tv+0l /q/gaFbLsLiE6lPMqyeKxtCNSUZ060sJLlwMqsLxpygq8qFWMJ1HiIxq0Z/6 WcKfQuwFDhma8Q+IM0p8T5tl81h8Xw3hXRybIMZUo0Z0a2ChmtGNfiVYOulL EuvLLKGY4WrVpUKGAlUwuOpfQX/Bun8Q/wBvvxz8XP20dN/av+N3xV+MXgDw fovwkTw1qfxJ8Va5450O98aeJtR8c3j6z8Mtb1ppF0TSJPDOkxDxP4V077DB p99eaFBeaPYX9hM9z+1YPPcg4iyrBZpkUl7OrKtTxGHqWhjsBXpKmqmDzCin JRrwlLmp1YN0cTRccRh51KNSLj/CvFXh9xz4Z8VZtwrxxhuTFYWGHr5fmWFU 62R8QZfiJV/q+dcP42UISrYHERp8lfCVoxx2V4yFbLcwo4fGYWqqv9VdWeIF AHxx+3v+0p8Q/wBkX9l74jftA/Df4L3Xxz1T4eWK6vrfha38RL4cg0DwnEk7 694+1iePTNZ1S/8ADvg2BE1bxFYaHptzqq6Ml7qIa1sNPv7618DibN8VkWTY vNMJl8synhI+0qUFV9iqVBJuriqjUKk5UsOkp1Y04OapqU/dhCUl+t+B3h3k Pir4lcPcCcQ8YUuCsLn9d4TB5nUwDzCeNzScoRwOR4SEsTg8NQx+bzlLDYCv jcTTwzxbo4dKtiMRQoVf5APE3/BxX/wUa8Qak9/oY/Zy8D6cz7rfRND+FXiH XbeODbhEm1TxN8RdRvbyRhiSW5hTT45ZCXhtbaFhAv4PW8V+LKs+amspw8el OngqtRJdE51sXOUn3a5E3tGK0P8AWPLf2fv0fcDhlQxsvEHOcQopTxmN4my/ BVHO95OOGy3IMPRpRTvGFObryjBJTq1J3qP7B/Ze/wCDl34g2HiGw0L9sr4L +E9Y8H3U0Ntc/Ev4B2utaN4h8PRPIivqetfDXxX4g8RW/iWzt42knv38MeKt L1SK3hP9l+GtXu2W0f3sm8X8VGrGnxBl9CdCTUXjMsVSnVpJv46mEr1aqqxW 8/Y14TSXuUqj91/k3iX+znyKtl9bHeEXGGaYXNqUJ1YcOcc1MHjMDj5RjKSw 2D4hyrAYCpl1ao4xhh45jleKw86k0sTmOFpJ1l/WZ8OfiX4G+LXw78H/ABY+ HniK08SfDzx74Y0rxn4S8TwRXljZ6v4Z1qxi1LTdVWDVbaxv7OK4spo52h1G 0tLq2BaO6gglR0X9wwmLw2OwtDHYWrGrhcTRhiKFZKUIzo1IqcJ2qKMopxad pxjJbSSaaP8ALTP+Hc64Xz/NeF8+wFTL8+yTMsTlGaZdKdGvVwuY4OtLD4jD e0wtSvQryhWhKEamHq1qVXSVKpOEoyf82v7dP/Bxh4b+Gni/Xfhh+xN4G8If GXUPDl7PpOs/G7x9faw3wnfWLKeW21Kx8C+HPDV1pOvfELT7OZPI/wCEuXxP 4Z8N3l1DOdAk8SaX5WqSfknEnixRweIq4Ph3DUMwnRk4VMxxUqn1H2kW4zhh qNGVOri4Rat7dV6NKUk/ZOtC03/of4J/s/Mx4kyrBcSeMmdZtwhh8wowxWD4 NyOjg1xSsHWpxqYavnWYZjTxeCyHEVoNVP7KllmY5hSpVKf15ZfilPCx/Ke2 /wCDhr/gpXb6supS65+z9f2ayiX/AIR67+DF/Ho8iqcm3eex+INprywuPkZ0 1oThSSsoYA18SvFTi9T53UyuUb39lLL5Km/7rccTGrb0qX8z+n6n0Bfo61MI 8NHCceUKzjy/X6XF2Hli4t6e0jTr5FVwPOt0pYN072vBq6f7BfsPf8HFnwt+ Lev6J8Nv2xvBei/s+eK9ZuINP0z4teG9Xu9R+B19qNwZEhg8UDXX/wCEk+Fy 3U/2e0s7/Vr3xV4YWacyaz4p0OFFaT7zhzxXwWPq08Hn+Hp5VXqNRhjqVRyy 2U22kq3tX7XB3fLGMpyr0bu9StTSP5N8af2f3E3CeBxnEXhJnGN49yvCQqV8 RwrmGDp0ONKGHpqMpzy14GP9ncTSpwVWrWoYWhleYuEFHB5ZjZysv6V0dJEW SNldHVXR0YMjowDKyspIZWBBVgSCCCDg1+vJpq6d09U1s13P86mnFuMk1JNp ppppp2aaeqaejT1THUCCgAoAKACgAoAKAKOp6jaaRp17ql9KsNnp9rNd3Mjv FGqxQIXb55pIolZgNqmSSNNxAZ1ByAEru3fQ/wAsz/gqv+3p4m/4KFfte+Nv ie+sz3Pwa8BanrPgT9njw4Jd+maV4Ls5bTTde8bxIoCTa18VdX0RfEc9+4Nz B4QTwf4byiaNMZ/rcDhVhcPGLVq1RKpXf953cKf+GlF8qWl5ucrJyZ8NmWMe NxLnF3oUeanh105U7Tq9uas1zX3UOSF7R1/OCus4D6s/Zs+E3wj+JWm+Pb74 meMtL0WXQ7F1sNP/AOE00nw1q+kQyWvmxeLZ7C/u4JL7S4J1mRnngn0x2t4r Sd4XvHr8m8RuLeMOH8yyXCcMZVicTQrRp18XiFkmIzXD4+vUq1YwyeNenQqR oVXh6fPKFGdLGSdb2tOXLQjf+wfo1eEHgz4hcLca5x4pcUZXgcywmIxGX5Rl kuOsBwpmXDuWYbAYWrW41rYDEY7CVMww8sxx0cPh62Op4vI6UMvqYfFU1Vx0 nD6c/Zv+AOp+EvA/ibxIt9pkPxK1jS9e0/wp4hMc76VpWu29rfW/h7VkS7tJ JRp2iaw1jflW0+YPrMV7cz2t6NH0lF/KPEHjulxRnWX0lQxa4Zy+thK08snO nTxeJpVHQnmkq0qNadNYrE4dVsHhZ+2mqGE5HTlSni8Xf+u/o/eAmL8I+CeI pzx+Tz8VOJcBnGDnxVh6GJxGU5XWowx1LhLDYGnjcNSxLyjLcfLBZ7nNL6lT lmObOrTrU8VQyjKeT9YvjDq37GHijwx8AdU/Zt+A/iX9lex+Evw61u4/bA+K Xj7RI/Dmmaja3Ogkad4R8TeJbnxDqo/aV+MSeNoovGWkfGdbnVWvNJsPE8Un jKa18ea5o2nfWeIuecHcTZFgct4b+rZpm9XN8uhkOGyjAThicny72cqFTK3Q jh8MqWKzGHs8NQyP95NV1TxdSFHD4KWLX4L9F3w78ePC3j7iPifxaxWO4a4J wvBfElbj/NuL+IKFXLOMuKqmPhmNDi3DYypmWYvE5Rw23isbiOMeXC0KmBrV cqwzxOMzanlEP2+/4N8/2rvg/wDtGfszfE3QPh94auvBvir4cfGHxPa+LNC1 W5hutY1LQtVFrP8ADjxbM8ccMkdrrHgZNEs7m3mhRrbxVpfiu3aW6uYbydvs 8g4WfCWV4XL6vsZ4ytSWLx9WhP2lKWLqNqph6VTlj7SlgoqnhYVV7tfkeKUY PEOJ+F+Kvir/AMRd40zbiPCfWqOQ4Wssq4awWMpSw+Ko5LhYRVHG4vDuc1Qx mdYl4rNsRh23PBfWoZY5zhgISP34r2T85Pxk/wCC2v7fetfsUfsx2nh34Xay NJ+P/wAf9Q1HwP8ADzVLaaH+0vAnhuxs0uvH/wATra3kWQm88PaddWGg+G5i gS18YeKdA1FhPBpt1byfn/iLxPU4dyZUsFU9nmmaSnhsJNNc+GoxinisYl/N ShKNKk/s161Keqg4v+vvobeBeE8ZPEipj+JcG8VwJwLQw+c8QYapGSw+dZhX rSp5Fw3UqJpeyx+IpV8bmFNczq5TlmOw65J4inUj+HX/AARk/wCCvF58Fda0 H9j39rPxRJrvwD8Z36eHfhd8S/GmoLqDfCHXPEF1NH/wiPj7XdblkkvvhN4p 1C9NtZa3rl1MPh9qt2tlqE//AAgt+sng/wDOfD/juWX1KeQ57XdXLMRNUsFj MRJS+o1Ksmvq+KqVH72BrSlaNSo2sLN8s39Wleh/aH0vfon0eLsHjfFjwryy OC43yehLMOJeHMooyo/614LAUoS/tXIsHhIpUeKctoUVUrYLB04vPsNTdbDx /tqg4Zr8a/8ABYb/AIJ4S/sIftFnVfAOlXKfs1fHK61nxN8JJ4Ynl0/wDrkM n23xV8Grm625gi8Oi5TWfAAumaW+8DXB02O4v7zwfrV0PnuPeFXw1m3tMLB/ 2PmUqlbAtK8MLUXvVsvcuipX9phebWeHfIpTlQqyP1/6JPj7Hxu8Pvqme4qn LxF4Kp4PLeKITny4jPcHUjKllnF1Ok9Jyx/sng889laNHOaf1h08PQzXBUTH /wCCRf8AwT1vP2+P2kraPxlplyf2b/gxPo/i742ag32i3svF87XSXHhj4LWd 5bNFcfbPHbW9xeeKns57aXSvAGnavi+sNW8QeGWuY4F4VlxPm6+sQl/ZGXun XzGeqjiHzXo5fGUWpc2Js5V3FxcMNCp70KlWjzdf0rvHul4G+HlR5Piaf/EQ uMKeMyng+guSdbKYKlKnmXGFWlUUqXsskU4UcsjWhVhic9xGEvh6+FwOYqn9 6f8ABaT/AIK2j4rXXiT9iD9kzWrXSPgL4YE/gv4zfEPwpJbQWXxVn0sW9lcf C74f3mmFIrH4T+HZbWbRvFmq6Y6RfEC7gm8M6W8fgOx1KXxp9N4hcc/XXW4c yOoqeWUb4fMMXQcVHGuFovBYWUNI4Kk06depCyxTTo02sNGbxH4b9Dz6Kv8A qzSy/wAZ/FPBVMXxtmLhm/CGQZmqs63DMMT7StT4lz6jiE5VuKMfGpDGZXhM SpSyKlOGZYqLzuvhoZR/NmqqiqiKFVVVVVQFVVUBVVVAAVVUBVUABVAAAAAr 8j22P9E22229W2229W23dtt6tt6tvVvcdQIa6K6sjqro6sjK6hlZGBVlZWBV lZSVZWBVlJVgQSKGk001dPRp7NdmNNppxbi00002mmndNNWaaeqa1T1Wp/YL /wAG637fWu+OND1z9g74p63PquqfDHwnP41/Z81rVrmFr2X4X6Zf6bpXiL4W G6mMdzqb/D6+1fTdU8HxSPe6hB4J1S80aIw6D4Fs44P3nwp4nq4mlU4ZxtRz ngqDxGV1ZtOTwcJQhVwTk9ZvCynCdBNymsPOVNWpYaNv8l/2gHgXgckx2D8b +GcHTwuF4lzWGT8d4LC05RpQ4kxNDEYrAcTeyhzU8Os+pYTE4fN5xjRw885w 9DFz58dndWVT+pWv2c/zOCgAoAKACgAoAKAPzs/4Kx+P/Fnw5/4J5ftS6x4B ZY/HetfDDWvAvgqeS9k06C18V/ECMeDtAuru+iZJLWzttS1m3mu7hJI3gt0k mRxIig74WKniaEZK8faxlK6v7sH7SStZ3uotWt1OfFycMLiJK/N7KcY8tlJS qL2acbtK657q7S01aR/LLqf/AAa+6VeC3t/hL+3FLYaDpfw70/RoI/iL8Ebf XdUvvjZosl1pmsWl9/whvjnQbXwh8JL8W1hc2MOPGHxD8Oi9lS6XxHBb2815 60c7UrSnhneUm3yVElGDs09U+aau72ag+ljwp8OuN408WkoQ5ffpc3NVimmr xnHlptrTSU1fXms7/wAvPxB8CeKvhV8RfiR8J/Hdhb6X48+EvxF8d/Crx1pl nfwarY6f40+G/ivV/Bfiq00/VbUC21XTYtd0S/Gm6nCsaahYfZrzyYGmMEft RlGcYzi7xnGM4u1m4zipRbXRtNXV7p3TPnpxlTnOnNJTpznTkk00pQk4SSa3 s4vU/S3/AIJlfsbeIf2y5fEdt411W08O/slfB74n+Hda+KWtadaWEnxA8TfE jXPD11b+HvAfw6vr/StVsDc+F7aPTviH410rVW0zR7zTF07w5qN4t34v0690 H+dfHLxa4N8IcyyXGZpg+Isy4t4vyPH5JhaHD+KpUJ5Pwvh8S4ZhxLVpYqcM NiMdSr4yWCynD2niMXOhiIUauBWHnXr/ANA+D2G4z4xwGW8C4PC8NY7gvhzj 7C+JuIwPEeWwrUMz4gy/B4GlSyXGZjTjPMKPD2Lhl2G/tDBYBUnWxWLjWxcs ZhYzo4T7L+Jmo/CT9mn4iWPwR+I/xFg1PxFbazD4X8K6b4Y0q5srnxhYR3N1 ZWnizXBK+rXPwy07U7i0ubvV9I1qy1PX9HuZbm1nRLeKPWpfy2jwpmuY5ZU4 nyel/b3ClXKqXEGX8S4CUMJlOa5Nib/VcRh6uYSoYiliuaM8JicnnhqmbYTG 4bEYSrhlKFOpV/0xyHx/8NM6rcM5LXz/AA+QcacR53PhWXA2Phic34oyjifD 3eY4PGYTI8NicNXymipQxuF4tlisHwzjsvxWFxUcdSq/W8Fg/wAzP23viv8A HDXfENn8OfGGg6f8O/hHaXWoan8P/CPhPUYb/wAO+MLHT9RazTxhrupW91Pd anr00sVtd3mleIFh1XTJpNOl1NNQmh0y/i/e/CTJ+Ef7OWd5Vi3m2fUKVPDZ hPE4Wrg3w7XxmHjVr5dl2DrR0jVhzUqueQrYytmcKVWlTxdHDqpg4/w39MHj TxdnxF/qPxTk8OEPD7GYnEZpw1hctzTC5vS8RMDk2YVMLg+JOIc3wVZupVwm IVPE4XgrEYTKcNw1WxGDxWIyrGY94bN5frN/wayfELVfDv7fHxe+HMFx/wAS P4lfs6z69e2BHyPrXw28b6Lb6bqKkc+db6V4/wBatMMdhjuc7S6KV/TM5inh 6M+sK7jf+7UpybXzlTWi6/I/kzh+bWJxFP7M8Mp9/epVYJP/AMAqyV339T/Q Ir50+rP4Qv8Ag4r+JGo+Mv8Agoda+CpZrhdF+DvwF+HvhzTrJpS1muteM9V8 T+PPEWqwwkkRXeoadqfhDTbpxtEkGgWI25Rmb+avFfFyxHFUcM2/Z4DLMLSj G94qpiJ1sTVqJdJThOhCXdUoH+3f7P3h6jlHgHWzmMKbxXF3HGfZhXrKFqzw mT4bLsjwOFnP7dHD18PmmIpJ6xqY+v0at+EMkccqPFKiSRyI0ckcih0kjdSr xurAhkdSVdTwykg8GvzRpNNNXT0aezXZn9vRk4tSi2pRalFptNSi7xkmtU4v VPoz+oH/AIJ6/HTwv/wVE/Y0+IP/AASl/ag8Q2h+NHhDwh/wkv7J/wAU/EDC 61q9tfAlqZvCTi4lgNzc+MvgzP8AZ9L1iS3vDq3j34M6xqVjdR3B03xpqN9+ ycLZlR4z4fxXBOc1Y/2hQw/tskxtXWpKOGi3Qd7XdfL3aFS0ufE4CpODT5MR OX+anj3wRmf0afF3IvpP+GuX1v8AU7Nc2WXeKHDOB5qeDo1c7qKGaxcVNQp5 TxfBVMThI1aTw2ScXYTD16coLE5RhqFr9uz4w6B/wSW/Yi+Hv/BMP9m/xVbf 8NIfFHwxJ42/ai+LXhYS2Oq6VZeMo/svi/WbK9VY7rTPFXxNnsH8G+BS8o1v wX8JvDaXoXT9Sk8I6pJXEuPpcD8OYXg3KK6WbY2i8RnOOoe7OEcRpiKkZWTh Xxji8Phm/wB5h8FRUrQm6EzLwR4Sx/0qPGfP/pI+IeV1P+IecNZnHJvDfhfM 2quFxNbKJOtlODq0eacMTlnDka0c3zpJPBZvxRmMqPNiMPDNcIv5c4oo4Y44 YkSOKJEjjjRQqRxxqFSNFHCoigKqjgAAV+MJJJJaJKyXZI/0xlKUpOUm5Sk3 KTbu3Ju7k31berfVklMkKACgD7m/4Jj/ABD1f4X/APBQ79jbxRo1xNbTah8e PB3w91HyZDGbnQfixPL8M9aspiCokt5bbxUs8kLko8tpA+0vHGV+k4Oxc8Fx Vw/WptpzzPD4SVt5Usc3g6kX3TjXu1s3FPdI/FPpI5BhOJfAHxdyzGU4VIYf gjN8/wAPzq6pY7haEeI8JWjpLlqRqZY6cZpJqNWa5kpM/wBLKv68P+dIKACg AoAKACgAoA/P/wD4KnfCTxJ8bv8Agn1+1Z8P/BMVxP47u/hD4q1rwDBalfOu PHPhfT5fEXhG2RTzI1zr2mWFukMf7yaSRI05bFb4apGliKE525I1Yc972UG+ WbevSLb1ula9mc+LpyrYXE04fHKhU9npe9SMXKC+ckl/wDyH9mv4t+CPi58G /CXxw+HsOrHRvid4Y8LfF+0CX2mXeoan/wAJx4X0vxXYvoYudTsLSO7jgvIr CbTLy9sYtJ12C50281RxAboZSpulKVGdlKnKVOXNsnBuLb0eml9np3No1Y1Y RrQu41IxqLlabtNKVk07Nq9l7yV9Lrc/A3xX/wAEOfgj8ZP21fjL8dPiReze Dfgv8RviFH4x8A/sZ/s/a9bx+Ltd1O90jTrvx9rPxf8Ai5ZfafDHwW0Px14+ TxP481j4cfB278Xa1oFl4hms4Pif4anFzawess1nSw9OlTSqVYR5XXmvdtdt Wg7ObSduefLe13CV9PElk1Oviales5QpTcWqEZtzXLypL2i0hHlioqEedQi+ WE48qZ6H/wAFYP2xNE/4Jg/An4I/s2fstaD8LPh98dPGNg+teAfBnhHwD4fP ww/Z3+A+karrFhrnxCsPCGoxTJ4i8e/ELxvFd+EvBOteMrTVZfE95p3xW+If iu41q/8ADmk2Wtfz/wARfRx4a8VfEDHcfeJGcZ9nGDoYHAZFkXCeU46WS5Ng sqwDq4j2eaZjTpVs6zPGY/H4zH5jmCy7GZFhMO8Vh8FRp4lYKnjKv3lPxHx/ B3DlPhvhfD4fLK+KqVcXmGaKKqY/FVJ2jCFNRnToYbB0Y06FOlCvSxtTELD1 JTlh3iqsV/Idpnx18eWXiDxf4z1iHw146+IXjv4j6L8WPFPxN8daXea18RNV 8baPr8XiKW8n8SQanYIdO167Sez13TV05I59Lv7ywspbC3TTo9P/AHHF8C8P 4nCZVlmH+v5PkuSZBjuGcs4eyavQwuQYXKcbgJZfanl1XC4jlxmEounUweN9 u6sK+GoVayrS9u6/k8D+LvEvAGHzCnk2UcI47H5jxVwnxjV4kznKMbiOK6OZ 8HZvh84y3L8PneCzbA8nDuMq0a+EzXJJYOVLE4PM8yVGvQr1cNVwmP8AFH4u eOvjHrlprvji+sJX0u1nsNE0jRNOGkaBodjc3P2q4g06x8+7uJJrmURfa9Q1 K+v9RuktrWKS5EFtDDH28NcKZHwjgq2ByShXisVVp18bi8ZiHisdja1OmqVO eIrclKnGFOPOqWHw9ChhqTqVZQpOdSc5c3if4tcc+MOd4TPON8dgKk8sw1fB ZLlOTZesqyLJMHicQ8TiKOX4J18XiJ1cTVVJ4vH5hjsdmGKjh8NTqYmNDDUK FP8Aou/4NWPhTrHiX9tP48fGFYHHh34Y/Amw8FNe+RKyP4j+JXjCz1hLRJvL 8hVh0bwDNJdkTebG9/piNEUukcdWczSo0KXWdWVRq+0acHG9r9ZVElp0eulj 5bh+m3XxNb7MKMaV7bzqVIztfyjTbfa601P76K+fPqT+Dn/g4m+H2oeD/wDg oufFkyStpXxc+Anw08V6bdeS6Wx1HwrqXiv4fa5pyTlVSe8sbXQPDl/dIjO0 FtrenbyolQV/NHithZYfiv27vyY/LMJXg7WjzUJ1sLUgn1lFUqUpLpGpDuf7 f/QAz+jm/wBH95VBwWJ4U444iyzEU+dOt7DNMPlme4PESgm3ChWqY7H0KLaX PVweJtflZ+FbMqKzuyqqqWZmIVVVQWZmZiAqqASSSAACSQBX5ttuf20k20km 22kkk223okkrtt9Ek2+h/TV/wSt/Zz8GfsHfs2+N/wDgsN+1totzC2l+A7g/ sp/D26ENnr+qab46tF0LS/GWm213bSXNt4r+Nh1a18H/AA6lMezTPhrrWueL L6C50nxYk2l/sPBWU4fhnKMTx7nlOS5MK3kuFklGrOGJj7OGIhFpyVfMeeND COyUMJUq15J066cP83vpO+IWb+OPiJkv0TPCvGUpRxGe04+J2f05Tq4HDYnJ qqxmJyjE1KdSFGeWcHPC1c1z+KblieIsJg8qoVKeKyx08T8OeO/2Pfiv+2P+ wj4w/wCCrtp4n1b4mfH69+Ovxn1f9q3wZYO99p2l/DrQL6203SdX8B6OiXGp 6RbfCTQNN025u/Dctxeo/wAKtSg1C2ktB4MtbfWPnMVkONz/AIZr8bxrVMZm ksyzCpneHj70IYSlOMITw1PWdNYGlCEpUryX1KaknH6ulU/acj8W+GfCHxuy n6LtbLMLw7wLR4K4RwnhhnFeKoYrEZ9j6FXE4jC55i37PD4ypxTj8RXpUsxj Toy/1mw86E1W/tepLC/jwjpIiyRuskbqro6MHR0YBldHUlXRlIZWUlWUhlJB Br4FNNXTunqmtmu5/XDTi3GScZJtSi004taNNPVNPRp2aejVx1AgoAKAPtv/ AIJqeAtV+JX/AAUI/Yy8L6Pbvcz237QfgHxxeoiuwh0T4W3z/E/W7uUorFI7 fTvCE5DsAnnPDG7qJM19FwhhZ4zirh+jBNuOa4XEyt0p4Kf1ypJ6PRQoS12u 1qrn4z9IzPMLw74CeMGZYupGlCpwFnmS0XJpc+M4mox4awdKN3G8p4jNoaJu XIpySbif6Xtf18f85oUAFABQAUAFABQBDc28N3bz2twnmQXMMkEybnTfFKhR 1DxssiEqxAdGV1OGRlYAgaumns9GCdndbrVH8yX/AAhE37Cf7Q99+x543tF0 n4D/ABf8a+KfGH7Avj6+hji8PNq/jnU9T+IHxQ/Yt1PVmijtdN8b6F431jxd 8Sf2bNIv7kN49+G+veJfhn4YWbXvhPbaPebSUq0ZVk+apBRWIjrzciSjDEJS lJyjaLjWcVGNK0PdUfeeMP3UlStam7uhKySUpSvKg+WMVFpyi6bm5TquTvOV ScYr9M/glF4SSxntra6ePxBJ9kbxPO1m63Vhp006qLbSoJD/AKVYaQxMd6YU j+06yALlWt20xhibddfn/X/AP5Lv+Cv/APwS5/a/1E/tDf8ABTn4ifFT4X+O I7nVP+Er8f8AwQ0LTtc0nXf2ev2ePDVxbeDPhppOi+PNU1CXwr8TIfhf4OXw 0nxAsNH0jwpNda9q/jLxf4em8VXBvxrH0WBxuGXs8HGM4JJqNWVuWpO3NJuN 3KHM02m29LXjHZfK5lluKm6mNclUlJpyoQTc6cXKMIxhJJRna6vFK/NpGU0k z+ayGaG4iSaCWOeGVd0U0MiSxSJkjdHJGzI65BG5WIyCM5BA9Y8FNPVO67o1 tE0PxD4q17QfCXg/w7rfi/xh4s1mw8OeEvCPhqwl1XxH4p8R6tMLfS9B0LTY B5t5qWoTnZEmUhgiWa8vJraxtrm5iTcYpylJRjFOUpSaUYxiruTb0sl39Bxj KcowjGUpzkoQjFOUpSk7JRUU236LRXeybP8ATc/4Iwf8E9f+Hev7H3h7wR4s XTL342/EbULn4j/GvW9NlN1ayeMNbhtoIfDulXmTHcaB4M0Cw0TwfpF3bBIN bttBXxLIkV1rc9vb/JY3E/WsRKqrqmkqdGMlZqnFtptdJTk5TknqnLl15bv7 rL8IsFhYUnyurJupXlFtp1ZWXKm27xpxShFqybUpJLmsv1yrlO0/E3/guT+w R4i/bL/Zm0vxt8J9Em1348/s6X+r+MvBugWMUk2qePfA+rWdvD8SPh3pcEbr 9p17U7PS9H8TeFLcQ3Nzf+I/Clj4ds0ibxFPOn534j8MVeIMnhicFTdXM8pl UxGHpxTc8ThpxSxeEgk9as4wp1qCs5SrUI0ope1bP7I+hZ454Dwh8R8Tk/FG NjguB/EChhcnzjHVpRhhsjznC1qk+Hs/xM5r93gsNVxOLy7M6nPSp0MvzStm FaU45fCnL8I/+CNf/BIO/wD2q9a0L9pz9pjwvd2P7MWg3yX/AIG8Ca9ZXFjc /tBa5p9w4S41HT7n7NfWvwk0HULZTqP2qCNPiHqMLaJEk/ha31g6l+a8AcBy zqpTzjOKEo5PSkp4bC1YuLzSpFv3pwdpRwVKa97mS+tTXs1elGpz/wBt/S7+ ljR8M8HjfDfw4zKlW8RsbRlQzvPMDWhWjwLg68IuVPDYil7SjU4oxtCbVD2U 3LIsPP65JwzGphPYeX/8Fu/+Chdj+158dbT4G/CLVoJ/2av2ata1TRdHuNIl gfQviT8XNNF/4a8S+O9MkswLK98JeE7Fr3wP8PLm0e50+/gk8VeKNLvLnSfE ejmDi8RuKo57mUctwNRSyjKKk6cHTa9ni8fDmpVcTBx92VChFyw+FlHmhJOt WhJwq02vpvoY+Adfwo4Jq8bcV4WpT8RPEXBYbF4qli4TjjeHuFMQ8PmOXZLi Y1W69HNc0rKjnOfUaqpV6E1lmW4qjTxeXYtTxP8Agip/wUOT9i39oNvhj8T9 bjtP2Z/2h9V0zQvGkup3EEOj/Dj4lTi00Xwf8U55rqNorPQryEQeC/iI73Fl ZJodzofirUrg2/glre6z8POK1w9mn1PGVFHKM1qU6WIc2lTwmMfLToY2TkrR pSXLh8U3KMVTdOtN2w9n2/TH8ApeMHAa4m4bwcq3iNwDhcTjcohhqU54riHh 2m6uMzXhqnClJSrY2lJ1M3yGMaVetLG0sZlmHpxnnHtKf0D/AMFmv+CQFz+z NqviP9q79mLw9Nd/s4a9qFxrHxN+HejWsk5+AWq6hKkt14j0OBJJ5pvg/reo 3Fxc3NtDFHB8Lr2YQQqvge5tYvCvqeIHATyedbPMmpOWU1ZOpjMJTV/7MnJp utSV23gakm3KKVsHJ2X+zySo/B/RB+llS8RcNl/hf4lZhCl4gYLD08Jw5xDj Kqj/AK84agnCll+Om4whHivB4eMKdKrOTnxHRp88285p1ZZl/O8CGAIIIIBB ByCCMggjgggggjggggkGvyo/v9qzae6dn029dfvFoEISFBJIAAJJJAAAGSST gAAAkkkAAEkgAmgaTbsk2+y1eui/HQ/rn/4N0P2CvEHhuDxB+3t8T9Gm0o+N PDF/8Pf2eNG1W1aK/uPBeo39he+Mvi0kMyB7Sx8X3Glaf4a8E3LLFdX/AIb0 7xDrcIfQPFmj3V7+6eFHDNWiqvE+MpuH1ijLC5VTnG0nh5SjLEY5J6xjXcI0 cO9JSpQq1FelXpyl/lJ+0D8ccBmVTAeB/DWLhilk2ZUc+49xmFqqVCGcUKFa jlPC0pwk4Va2U08TXzHOKac6VDMcRgMHKUcdlmMpUf6sq/bD/MEKACgAoAKA CgAoAKAPDf2i/wBnD4OftV/CjxR8F/jn4J0bx14D8V2X2a903VbbdPY3cMsV 5peuaHqUDQap4f8AEmgarbWOu+G/E2gX2l+IvDXiDTdL8QeHtW0rXNM07UbV xlKEozi3GUXdNfimno01pKLTTV000JpSjKLV1JNPdOzTV01Zxkru0otSV3Zq 5+L/AIg/Zj/4KKfsh6kifDnP7fvwb0nI8L6vrvxB0f4UftueCdIVTaRaFrnx A8TJF8Iv2mYbOxMMR8Q/EWf4Q/EfVbaB18TeN/iDrVy17W0fq9RLnlLD1Osl B1MPJt78lNe1o+kY1obaLVrGbxNN3hCOJpqNlB1FSxMbJ/bqydGtd8q950p/ FK9koPK0f9r+7fUItL+Lfwj/AG2/hvKmvWtz4k8I/ET9kH4jfFSC7/s27s5I 7B5PgxafGf4d69ZA2EN3p0Vr4g/sm31FLXVY5YdQtrW7Q9hJNOFfCy6qUcVC m9dNFU9nUT3TTin06kfWYPSphsZF9YSwc6qbW3vUvbUmtmnzKzW6aPwV/am/ 4JW/tUf8FGv23fiB8YP2Qv2H9S/ZI/Z78Z2vg+zuvFPx2Hgz4MWHjHxppWli x8cfGSP4I+C7/wASeIvCNx46vHsWufDlr4e0+61S90mXxr4zn0TxP4r8RxWP tUMfh8Nh4062IeJqw5rRoxlUtHeMHWlaDS1SbldL3Yxair/P4nKsRi8VKrh8 PDC0KkYNuq/ZWnqpydBL2im1ZyUIOLfvObnKdv6Nv+CWv/BCv4Cf8E+bi2+K 3jTU4/jt+0zd6Y9nP8SfEOiWNno3gS21C2RNX0H4U+GS+op4Q029y9nq2ry6 nrPi7xJZo1nq/iWXQZ08O2nmYzH1cY+VpUqCd40ou/M1qpVpWXPJPVRSVOLs 1FyXMezgMso4H31J1sQ1Z1pRUeS6acaMNfZxabTk3KpNNqUlF8p+7dcJ6IUA FAHyn+2p8GvjL8ev2Y/if8GP2f8A4t6X8C/H3jzw+/hm18e33h+/1lbDw9ej 7N4g0XTZNI1fSL/wve6/pDT6JD4t06PVNR8N213cX2j6W2rJYX1h4nEOX5hm eT4zL8rx0MtxWJpOjHEypSqctKWlWnB05wlRlUhemq8FOdKMpSpw9pyzh+n+ D3F3CPA/iPw1xfx1wtieNciyPHxzGrkdDH0cG6+OoP2mBxeIjicNiaOY0sFi lDFyyuvLDYfH1aVOli8Q8I6+HxH8VHir/ggB/wAFOPCmqnR9B+Ffwr8f6ZAf Ittf8G/GrwppujtBCTFC32Lx7B4N1y3QwojLENKmaNSIySVOf55r+F/GNCfs 6WCwWKgtFVoZjRhTaWi93ErD1Fp05HbY/wBjcr+nb9G7NMKsXjuJuJ8hxM1z 1MBm3B2Z4jFKc/emlWyOeb4Ko+aUryeJgm9UrPT7L/Zc/wCDa342eL9X0/WP 2xvib4T+GXgVHEmqfDr4R6g3jf4heILTeI7jR73xnqek2Hg7wbDdwmTzdR0r T/Hd0YCIbddPuZjdWn0GS+EWY16kKmf4yhg8MneeEwMvrOKqrZ05YicI4fDp q754RxLtZJRbbj+QeJv7RPg7KsJiMH4R8OZrxFnUo8uG4g4rw8cmyLA1bc0M XSyjDYrEZtm0qUlFRw+JxGSU1U9+cq9Omqdb+wHwd8OvCXgb4ceGPhPounS3 HgXwl4M0j4f6VpHiK/1DxXLN4U0TRbfw9ZaZrWpeJLnVNT8QmTSLaO1v7rW7 u/u9TBle/muJJpWb94w+EoYbCUcDTg3hqGHp4WFOrKVZuhTpqlGFSdVznVvT ioylUlKU9XJttn+TebcQZrnXEOZcU4zERp53mucYvPsVi8voUMrjDNMbjKmP rYjB4fLqeGw+A5cVUlVoUsFSoUsM1GNCFOMIpfzC/t1/8G5g8W+M9b+Jv7Cf i3wX4BsfEE1xqmr/ALP/AMRG1XS/BekazcXFzc3cnws8X6Hp2tT+FvD94ZYh a+AdX8P3mi6FOk40DXtH0KSx8O6X+OcS+E/t8RUxnDVfD4WNVudTK8Vzww9O pJtyeCr041HRpSurYapSlTpu/sqtOlyUYf6S+CX7QV5Tk+C4b8bMqzjPauAp 08Lg+OuH44XE5xisJSp06dGPE2VY3EYOnmeOoqEva57hMdSxmNg6bx2BxeNj XzDE/k3bf8EFf+CpE+sjSpPgf4AsrTzkiPiW6+Onw7bw+EZgGufKsry88TmG MHey/wDCNi4IVgkDNtDfER8MuM3U5Hl2FjG9vbSzLC+yt/NaMpVrdf4N/I/q ap9OT6M8MH9ajxnn1atyOX9m0+Cs+WO5kr+z561KllvO3on/AGi6eqvNK9v2 R/Yf/wCDcjwd8P8AxBonxJ/bc8b6B8Y9T0ie21HT/gX4FtNQi+Ef9oW+6SI+ P/EWu29l4g+JenxStFKPDMeh+D/Dc81r5Ov2/ivSrqfTz99w54T4fC1aeM4i xNLH1KbjOGW4aMlgeeN2niatVRq4uKdmqKp0KTcbVVWg3A/kTxp/aDZvn+Ax vDvg3kuO4RwmLp1cNiONM7q4efFX1epyxl/YeAwU62B4dryjGcf7Sljs2zCF Os3gp5ZiaUMQf0+WdnaafaWthYWtvY2NjbwWdlZWcEVtaWdpbRLDbWtrbQqk Nvb28KJFBBEiRRRIscaqigD9kjGMYxjGKjGKUYxikoxilZRilZJJJJJKyWiP 82qtWriKtWvXq1K1etUnVrVqs5VKtWrUk51KtWpNynUqVJyc5zm3KUm5Sbbb LFMzCgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKA CgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAoAKACgAo AKACgD//2Q== --_av-Fm6KDZsPBN2qstBcksTWkw-- --_av-QrtrINWR5ADZucrqzrYytQ-- From xen-devel-bounces@lists.xenproject.org Tue May 31 15:40:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:40:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339819.564723 (Exim 4.92) (envelope-from ) id 1nw3yf-0002C7-0a; Tue, 31 May 2022 15:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339819.564723; Tue, 31 May 2022 15:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3ye-0002C0-Sx; Tue, 31 May 2022 15:40:12 +0000 Received: by outflank-mailman (input) for mailman id 339819; Tue, 31 May 2022 15:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw3yd-0002Bu-HM for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:40:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f43aa6fd-e0f7-11ec-837f-e5687231ffcc; Tue, 31 May 2022 17:40:10 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-43-UG1w__QZOhSNoXeAGfW0kg-1; Tue, 31 May 2022 17:40:07 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3843.eurprd04.prod.outlook.com (2603:10a6:208:12::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 15:40:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 15:40:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f43aa6fd-e0f7-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654011610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZFGT0bpgc4mcISyhFAvxLZl2rXWqtez4FRysOjQtK9s=; b=emUTFxWH7COd1TFRaozItxYTapngziTmS+96EYApqKewRzrg4GFOeS2WWFxBantaopLrrB ws3ewK6E3xmaki5ao/jjmOEexmCt00A8Ask3FTJol6z6O6tS6Vr64vWPVhAdfBa4W4b+tG GpYSCGU2DfQv34PlRti9Qzhu01DCSaY= X-MC-Unique: UG1w__QZOhSNoXeAGfW0kg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HR+OBMvvbIfgohbkHci23Y8qYwz7OkQFYkFlKEnbz+ZFAInQlr7c8hbooTkWTb/bMEHOhUGYsmCzrwZAlj+IRqFeHlio9yHIE49kabTuv6uYk3qp9sIWbscg4Ih6aEPZJvnkXuTrmHDoJBi6d5g59AsPnK7A0G6PGLCl8UufWQXM/vel25R+zKGY/zm2v9qphr0gJpnlTwOlmTwNc1O5Vr7K4Gsl39kJn+PbjhlCJWSUiudUrTBYPjYSJwiLIEeFK0GpeusJGUxFvNhO4mJav047TCrZlqI25ToqGYbRJ/pN4l/ZgIpA1SCzp1EGapa9/7U8MuUsZ3UJBbFMPyHEuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXxV7bJ6vjyzQILnL6lUhIakTT67DbLkDsIxoJtck5s=; b=JgJ8cRDOqYS34XyRdMf4Qtnw6PPQYEv7zERc9OkDd/4KM6fmBWQCMnz1XCX48N04aTGk9sWYT0G9gIZ3Qc1WcJMsmOJEClgRJKWBHaFgzJyBOfzrEsNkkP+ZWRNrl+2QpY9rr3eB5MvMhm+9V0MOee8At3gdjO02nV0zEJE9HmmOJ3HRmAWc5V7GJSFleHcLGlyO0ViZ4AMin4ncTTCC4wPBBm51QNX0dlXrw40kXrOB4MSX9AaWhvxD4qEsYeD10WLBqmoTldzw2WZZbeOY0AV96Vc0t/Tk8zonHFBqYerOPkLRO8AOfCJcWUiMxIxXyTyBehj8IkavZN8/DmMVHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22d2f071-4046-52c6-6f11-23fb23fb61c1@suse.com> Date: Tue, 31 May 2022 17:40:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 01/15] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> <1de2cc0a-e89c-6be9-9d6e-a10219f6f9aa@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS8PR04CA0085.eurprd04.prod.outlook.com (2603:10a6:20b:313::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 846b18c2-2e07-4712-1693-08da431bd5df X-MS-TrafficTypeDiagnostic: AM0PR0402MB3843:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gObI+APLp8ZE9mHLGUROT4FbYQ4GK+2s+MzgYNbBS0YbF81zq8Xmb6aMrN40ZiY8E3+w/+yDnKyaqV+R/NnurNWmq/em6a8KsCzRF2rICnke+pzBqIDFmAcyRxB5wEHn0CDU8DXgzW8P+9Gi+7lBFbityksajgaXq5UbSFDt8GCfkEZhT73gqxloAXkwLa7VdRj/dZXAWqkIVk8ldadB7cONofDSW9TG97+yiiVrNb00aRiV2V10DW8Wb878nPS9neYGOncke5XpMP5aU75KGCdSN8L0L5XHr17kAvwlOZaLrZDA+suwFCKOmZEJIhxli1i0kxPRn+r/08BBuYTSgrthvM+w5wMm0xkaH7mgNVeRwZwcA8j1+SxrEpaafS04qZhKGCSARlVi6gu+5xtfbD2nNk2ga9JCfGyd4prbAZefEBkVeUF5coDL/RgbSbuSv9OuVRm9uR5ciUvhVjUcAJhG4J6NcK2+3Qaa9+OQKJs8Z9PsFVm51feaag+gJNVNO0Yhp27vb22mtr1S5DUqLwFO9GmCe70ROoJ3fpK8HvrY6LdqoaqJSS3f/I1p+ioi5pYnnGcq6mHLDHdAQlmQ6Sp3tIr/mkjqldUwGf4Q7SLYxhhz86wZwOs3piZM97waEK6FfAt63UUEp7VTBTogzY9QwlG6EC4MBw8Tr9WQdHXzYzpfNFmjFiwVW7nzspGaypour2hVxLUEY/NfhuUjNoUqQAXlrkEv0XQrkYjyRMU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(6506007)(5660300002)(4326008)(83380400001)(26005)(31686004)(8676002)(2906002)(66946007)(66556008)(53546011)(66476007)(6512007)(6486002)(38100700002)(31696002)(508600001)(36756003)(6916009)(316002)(86362001)(54906003)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZHZISIVLUxHxniY6200fwiQyRRL/2diBDqTbKS6X2MNI129mPVDQpbMoMDGY?= =?us-ascii?Q?F3pLKXPBzwrbFGo4lx8/rlc+ylUfspoEo1ughkTxOsTeDtw2Q8Nfz2xq7HWW?= =?us-ascii?Q?v+aZPMwW5Xcs9d6k7Snj27FokKL0+i6WYaQjLpvp3Mc59lCDkkpqfgt0qlXS?= =?us-ascii?Q?jK155thz2UjwgmrwGVnJDENF7eqeCw5TvnV9A73xXyRjtH96SYkIBcDOYu5k?= =?us-ascii?Q?DJcylc5r7kG+ovkP77i7dL9Tek20U6y7O32YQ93bXzhYwxLNf+IRf4oenqe/?= =?us-ascii?Q?3Cv6SVGrdR3FHKZRzrQpLZjhsoDPkDZONedLvi2jxyxFAX/dsHizo5+llnJ2?= =?us-ascii?Q?AkMcl/vY6K4QIcgF7iTi+CngnBhCda9oWtmCArlrP2+mHjL3Y/xXL2dKQ9UI?= =?us-ascii?Q?Fchqc/0DhvwkEakxbY8229SLAf6seCd1OR2bsr4S0uMaMn29w+XJnGXLg4yF?= =?us-ascii?Q?tnALyO/ALh8iffDNssSPbuDIE6QXBLXdmWBWZTKKZ5oFQQ3nefBdcQtC/qdF?= =?us-ascii?Q?64l+ih0BcZf2hDctrDYVmMdjCCqUltFzi0Zdjw16jXimGNqaGue4WJ+ofU8O?= =?us-ascii?Q?7W20FD8kjqzmO3RNcFy8jWs8sJEgLkUzt+YNK6GLIatKHgSOBVuTMNOuuAfw?= =?us-ascii?Q?W5bXmzRSNH1wZ1S86BFcqppXQ3EMQ3oK4/Yl9cqJOkOxe8LLaL2V3UDkhYn0?= =?us-ascii?Q?A8qm9RQB9fqV+g5skxrnoQuV88KLzyS3ASD3LHrHgZEHJfyslKGys6xN3NVe?= =?us-ascii?Q?9s0Hd6qHeCZv34PDXHVMByursRtxJ+A80oFupmO0icImsZq+cV10bQf0Azk2?= =?us-ascii?Q?h1522uy3q+96LB/+A2LgBNQ+767ETcVBNfa+x/ikNUDz9/yn+TH/6IcmLVqI?= =?us-ascii?Q?CfCFbOOGLBiGHnzHk3MVfLFHm/Za5iv49jwCWqDrOyQeyzLdVJZpkzuD6wsL?= =?us-ascii?Q?hFvN+fSmqWToXNfk4icb48TB6rhJkB5JbiLysRego+TjRXgv2iAmcRr2NVPe?= =?us-ascii?Q?0MWDrhLPGo9/MypKaYYfWkQWrZPXCbaFhnxqvsHzK5iCFe1mRbgbhD0OyvcW?= =?us-ascii?Q?dhZlcF5l90WtMovA7iiFyFFkDsTkA50qv5XuuSf9EOU4nHuB5d3FWObNWKhx?= =?us-ascii?Q?oK9ydCWvcv+0Rb5THFTMHhX1CF0+bSWEhZAfvnsX9Llayclk6/80y0ZmiuMV?= =?us-ascii?Q?Pci8Z67Jec6Wq6VHMhalECEs90rxxiRCx/ZhfbCcwPCi7EvejdKu/4/ZJyGR?= =?us-ascii?Q?BL9LkSlA2/l2rcr0BxQADsvUMh0mEWoDtsEb8usdVn3RfmRwsrVgPKy7Oyj0?= =?us-ascii?Q?QQD6q/ByPYo/IiSgOwnROVK+AlCG7rw8CzsKxrFSOi8B1ukncG3QXYBN0v9A?= =?us-ascii?Q?z7UTNhrJkZfZQfdGEUew5yCskZ5o0SMMB/lFvBNcBcCAFJy7VJvzTpOrEKbw?= =?us-ascii?Q?1AAy9LfNW4A1ejU7NCD744HFtIyg/2XCSHD66KE2w+TmcOqc8S3SnG4F8PHQ?= =?us-ascii?Q?xNM4TmTm79gFqep6FiQwERIwNWcwtTQmRKIM4uwlh/dBCZDEqR/tb9AUDZUQ?= =?us-ascii?Q?/f3UflwCCT78V6ytOdFrgSUXgX4tT0GgiZl+KydkIYXQMJwXQo94HKjXClhM?= =?us-ascii?Q?qXjBipjytxhJ51+C/4aaYcPhcmMby/z5YXzdTi26PfkbsHwUdjS1qGMtma/e?= =?us-ascii?Q?MyXLNflM5lSfvkf+tLKgi33nFINdfDfeTFdcHvipL5Jpop8WUiY2N7miY9ij?= =?us-ascii?Q?fxDP0nGMTg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846b18c2-2e07-4712-1693-08da431bd5df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 15:40:05.8629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hAq6hW1HyfaVf4I8iQFt8/ItlVFtRQSA7alagxaxF0fgItD0dksJYgYHnuxsEIK7BKw8yjHMFtnYXDy1uVxbEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3843 On 31.05.2022 16:40, Roger Pau Monn=C3=A9 wrote: > On Fri, May 27, 2022 at 01:12:06PM +0200, Jan Beulich wrote: >> While already the case for PVH, there's no reason to treat PV >> differently here, though of course the addresses get taken from another >> source in this case. Except that, to match CPU side mappings, by default >> we permit r/o ones. This then also means we now deal consistently with >> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >> >> Signed-off-by: Jan Beulich >=20 > Reviewed-by: Roger Pau Monn=C3=A9 Thanks. >> @@ -289,44 +290,75 @@ static bool __hwdom_init hwdom_iommu_map >> * that fall in unusable ranges for PV Dom0. >> */ >> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) >> - return false; >> + return 0; >> =20 >> switch ( type =3D page_get_ram_type(mfn) ) >> { >> case RAM_TYPE_UNUSABLE: >> - return false; >> + return 0; >> =20 >> case RAM_TYPE_CONVENTIONAL: >> if ( iommu_hwdom_strict ) >> - return false; >> + return 0; >> break; >> =20 >> default: >> if ( type & RAM_TYPE_RESERVED ) >> { >> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) >> - return false; >> + perms =3D 0; >> } >> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > m= ax_pfn ) >> - return false; >> + else if ( is_hvm_domain(d) ) >> + return 0; >> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) >> + perms =3D 0; >> } >> =20 >> /* Check that it doesn't overlap with the Interrupt Address Range. = */ >> if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff ) >> - return false; >> + return 0; >> /* ... or the IO-APIC */ >> - for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) >> - if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address) ) >> - return false; >> + if ( has_vioapic(d) ) >> + { >> + for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ ) >> + if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address= ) ) >> + return 0; >> + } >> + else if ( is_pv_domain(d) ) >> + { >> + /* >> + * Be consistent with CPU mappings: Dom0 is permitted to establ= ish r/o >> + * ones there (also for e.g. HPET in certain cases), so it shou= ld also >> + * have such established for IOMMUs. >> + */ >> + if ( iomem_access_permitted(d, pfn, pfn) && >> + rangeset_contains_singleton(mmio_ro_ranges, pfn) ) >> + perms =3D IOMMUF_readable; >> + } >> /* >> * ... or the PCIe MCFG regions. With this comment (which I leave alone) ... >> * TODO: runtime added MMCFG regions are not checked to make sure t= hey >> * don't overlap with already mapped regions, thus preventing trapp= ing. >> */ >> if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) ) >> - return false; >> + return 0; >> + else if ( is_pv_domain(d) ) >> + { >> + /* >> + * Don't extend consistency with CPU mappings to PCI MMCFG regi= ons. >> + * These shouldn't be accessed via DMA by devices. >=20 > Could you expand the comment a bit to explicitly mention the reason > why MMCFG regions shouldn't be accessible from device DMA operations? ... it's hard to tell what I should write here. I'd expect extended reasoning to go there (if anywhere). I'd be okay adjusting the earlier comment, if only I knew what to write. "We don't want them to be accessed that way" seems a little blunt. I could say "Devices have other means to access PCI config space", but this not being said there I took as being implied. Or else what was the reason to exclude these for PVH Dom0? Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 15:51:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339828.564734 (Exim 4.92) (envelope-from ) id 1nw49u-0003vY-2p; Tue, 31 May 2022 15:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339828.564734; Tue, 31 May 2022 15:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw49t-0003vR-Uc; Tue, 31 May 2022 15:51:49 +0000 Received: by outflank-mailman (input) for mailman id 339828; Tue, 31 May 2022 15:51:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw49s-0003vL-Sg for xen-devel@lists.xenproject.org; Tue, 31 May 2022 15:51:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93c295ab-e0f9-11ec-837f-e5687231ffcc; Tue, 31 May 2022 17:51:47 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-24-crvH-rB3M_6uebFOCQUaGQ-1; Tue, 31 May 2022 17:51:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0401MB2563.eurprd04.prod.outlook.com (2603:10a6:203:36::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 15:51:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 15:51:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93c295ab-e0f9-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654012307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J+gb4sJ+/ewSSupf5o5IjWHAiGlAUe7ETcuOmm89aLM=; b=kx+rvLuph1sACVD2LUhTsNugVWLiHZhZt93gt8fKsEatY/PX+WCApHMzcwIIcjSbnfTjL7 bcBW+Kr8Xv4+taT6u02Jdr8baVEudSaBe2wxxsgObIePuR3cAhACN+nyPJV9+dsF3Rulxb 9KqKwOyNzn/y5cw0qBg6wRLuNG4nlNk= X-MC-Unique: crvH-rB3M_6uebFOCQUaGQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hFsq7NfsgiHloXfKCTYk2qsZQErNYRPYbmT6I2zvKE8yJel3fad9qmXTFWtLYjJdLSZ7Yk3SxdjWEVrGqeJnympJZP446S1Cx8ce87BG12fGoyqvC+RSE9tIZUIF1w/aW20G+zqhdWg11fZxKFJ9jd2wTFZkINO06z2JzhqbkF+ZPBDLADoEPhP6Ww89EmFv5NEzTLzYrIlUMgEzYlSVcd9gmzp/+8/Z8A+F2hu5WepVdBxQJ0kOmDQ6ENt9J0VztUzstwwfMSijP0AADutXbqVSTE5nFK6LXDhQlf7MSLPgIKJEkdmsSmXhKdhCcP6IOMdfUd35P0oO3nl97HPomg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+gb4sJ+/ewSSupf5o5IjWHAiGlAUe7ETcuOmm89aLM=; b=oSYDg1XQAA6zuaCEYjRcYM58hOlp3QnVP0O4av0pHObueOyKKAnWuGywepst1cwG2aHByFiWZ9ZENZN6bHT0DHRQm9e9e2BzUNeYP7RZ3sEPyRajO0dNm71Uw4nE9HjcjWTuSUR6q7FmkVfRm+8XY/hwV9vNeKM7X+y43SDAFJdjNEN4Qu1mHY+9iWUMnXZyoPZw8cXx1Uet9IVYoSCJG4KFeFvw+lUozVCzz+YgDT61hTm0+1nikAVmlyKo4lGpSjQq1T3JLK1ZK6KhUcdEyv8P3st20xwApy42IIKwJOosOlencPVHJo7j3eOpLbpli6GT0yLbOYo8RAaAc+93pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1358771f-32ae-8a6b-9894-980014d7112c@suse.com> Date: Tue, 31 May 2022 17:51:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 1/3] xsm: only search for a policy file when needed Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220531150857.19727-1-dpsmith@apertussolutions.com> <20220531150857.19727-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220531150857.19727-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:20b:92::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5641874e-c3ac-41db-3136-08da431d762a X-MS-TrafficTypeDiagnostic: AM5PR0401MB2563:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zLJBZ9ZgVHkJtZXzHobLV5YrtoCecdH19GTPUox7Gf1SMovH4/nqhbY2W2RFYyvXPei5e7gFhnAcbBPBQffPEY0sJESMAb2JRc+rVGar8/EeaR7EigRhbu8MoAQzPvMB/Ry+OTR7VZ5iAvzzp3UFpAdzyA3YMY9+xweJe1Gdi3DhKizX43IiqrR4L6pxH8/C/zeaz/84fpmKaHwxcp4xZx+YwXWvFQOzRqCCwW9b5HRrTyOYTonKKRA3XKhKF3yegFUJoCxhLbeXF7umuApxixKfi0bYNRYygsPE6SqkxOGvJ4wy4Cp4S33fmiHjICAtfl6oS3ZlnUrIFfoP6OAxmTwBaHN25SdlNAAAfkXA0oKocACRm3eu+wLu2YlEbnb2PkQUyJDMW25H3oO6Sc4kiMfp5u8Z1WaGFnS5VN1+MgRLm55CM+whj/alpLjjaTxEdE4eW1aQp3AA7of3yFnbenNvFPIPYA0wko8q3vnapDGhwrxZEVPFCc/dyVfBS+C0TgSR8Dng/Dr6A+XaZJ7eJcIbF1klQkrwQe8/9nazye7JSN9ciYngxR0RMydk42rz569rfFo6s3yknDZXcBhwFewB5TX35qGaCVC5B5tDsw3ia/j1P6csJ7Y3+x+iIBcSPY+uuP8mAZiteQOYv3eLRt4RBL0bJcxGvT198Uq962Ij3BY0Qmz3r4sKz5ZwPoK5CerAc5iIGXKzBTprodjhzh/zfalOYdOU5x3zmfnPfXHBloYPyYzFohbDWAIr3kKu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(186003)(2616005)(31686004)(36756003)(4326008)(8676002)(316002)(6916009)(66556008)(66476007)(66946007)(8936002)(508600001)(31696002)(6506007)(86362001)(53546011)(6486002)(5660300002)(26005)(6512007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmV2cm5LdnVFTy81bGRmb0ladk92RFZZSUV2T2NEbzlNSGNYVDh5M29JQTZ5?= =?utf-8?B?Q2NqZ21pOExKUHU3SFc4NGM3aWlVWUUzRkVYMEJyeHZhOExMYW5ZVzUxU3Iz?= =?utf-8?B?Q25nZXZtZG1RTk1kVkJ2TTgvM09JWFJtM2ZDSFprbGhzMS9ZeVgyMG0yVFpQ?= =?utf-8?B?SW9kYWZNRWhtRlRXSUs2UmNLRFNnOFFLSFFubWlTVVhjbDM2OXpBczRXWjdH?= =?utf-8?B?ZGE1T2l0aSsreTJUVlVVWDdqUkt3ODlnQTg3TmxRaVlRYWNQMHk1ZGIrYjc0?= =?utf-8?B?WmhaQ3BIV2hraDdpQ1F4Mm84NjdjZmlVaE5xOXhWaFFWazZ1L1dVeVVFd2dT?= =?utf-8?B?NldLdEEwaDFYYmRyTzM5cTBkRi95eVZQM1RiU1c4Um9QWXBmb2c5dU03UFhq?= =?utf-8?B?K3dTOVEzc1g4Y0NudGJJLzVkVnd5UHhEbnpTamgyVFYyMkphT2JNa3hLTVJD?= =?utf-8?B?MWYxdzVaWHhmaW5yZVBwbndtQjdDUDJDRlMyNEVKMG54d1lmL2wxVGNIVmVY?= =?utf-8?B?cTRsd2ZVNGgzWnMzYUxISnFmS010VkhSaVRjcSt5UGtsOTJ4eWNiTEZhSytm?= =?utf-8?B?YXJOc3RNL2duSFpMT3ZEdnU1SjFwc1kzKzExbU1WYWs3dm1SbEdkSW1rZmR0?= =?utf-8?B?NjArcnVscHVOMmZVZGRwcWs0QjRaQno0MWVPZ0dZZUZQbFJtNkdzOHQwSWhh?= =?utf-8?B?UmY4b2ZNVm9Cem1aNGtnbWNkMTNubmhWM1hkSm5PNGNBL1dZd2IrVWVSWDhM?= =?utf-8?B?eGJFaVkrUms5OUU1WElWWDZzdGp2VEJHMTc0RDFadzNUblIyeHlKZ2pPM3ZV?= =?utf-8?B?ZXYyeUgwUzRFbkVPVnI0NGhVK0VZWW80K0tGSU9CSUVFbVJscXEvRlIxTFcx?= =?utf-8?B?bjByRDl6UnAyeXk0TkNpaWJ4eFRqZkJWNElXNzBaTUc4dGo5VGZJT1ZGQ2E3?= =?utf-8?B?NTFMYjM5bHRUNTFKTEc3UHBhbEtvZjhiYjg4R3E2bkZJdUtaY0Zhb0FuakNr?= =?utf-8?B?RmhsUDNEZy82djI2eFJyU1preDIwek5ZbEYxZWc5b2gwYWFEekJKVTRwUyt0?= =?utf-8?B?blZGa0ZCbngwSVl4eVZZTFNPbTFCTFFQL1ZYVUhURjBxVXJrZzRPblEraFcz?= =?utf-8?B?d3FsTmhDSFlpU0dlV0VSai9lTE1hTWZiMGpQUXJiQk54b2c1eXYwaVdibkRw?= =?utf-8?B?Uncyb1M4c1NUenJCemU1UHV0akJ4Z3lRVmx1ei9VdGsrVm9idlVYV3R0VTlz?= =?utf-8?B?dW51enoxd1ArWE50a3JCYU5GelBRbkFuY1ppVnFNRTNvRDViM3dRcEFFSnR2?= =?utf-8?B?dEZCd2dmZVRvU2UyZWs1YzNUYTEwTTRMZFRyK1I5aWRhd3VMdXBwNi9IYTFz?= =?utf-8?B?U1AyQ0FzeTVMRGpnUWg1dGI0cFJaL3l6ZlRjLzQvS1RWYW9lSWdYQ0JOWmdG?= =?utf-8?B?djNCU2FvVDlJVDBMblcyTG0yVzNNbTB1VDZnZnVkOTdhZzdJa05zK1JTeDU1?= =?utf-8?B?dUhFK3A3akxDSnRmNm15WHVLZ0RSeUl6amRnRUlnczN5bTlLZjhFN1o2bFZO?= =?utf-8?B?ZXNKcVArL3RvSlc4Q1FHeFBjUzlnVTNWZkxMMm1lSUVqUTRJOW1WY3dGSi9J?= =?utf-8?B?b1MrckltaWZYT0FkUkZhUGNwOUhyUmk1SzU0T0lUUHp2ZGM2YmExRFR6UGZy?= =?utf-8?B?dytUdCtWTWVtbmVyRk9pL3FCWnVQSGVtZEpXaHplS3h1WGdzTm1ydGxUczdI?= =?utf-8?B?ZVV6Z1ZUTVU3Ump2NXQ5WWg2cW9Temg3UjlpSDBOZXN6Q0kzU2xyeFZVMmhv?= =?utf-8?B?bWRnWlBpM1Rqd2prZkhacktMVHR5ZkdiMzRFeUM0NW41SWRYckhFVm9pejBW?= =?utf-8?B?MWN0YjBKTVdWQzRFTWhMdlM2eDJTUS9yS1FXV0FEZTJSZzIrbzRCaGM2Y1pB?= =?utf-8?B?U1ZWdVdrNS9KamVvOUhYKzAzaTVCM3hWTVpaRHR3aHp4N0dib3ZYajRDN1RY?= =?utf-8?B?elorT3pGSFpBMDNzQ2UvT0xNd2J0aXppMEdpYXhFMGFiZ2l1eUdNOHZwdzZD?= =?utf-8?B?YWFpdnFUaVo0cUdaRFB0VUQwNng2dURwUklrdVQ4c09KT0Fzeng2NmJFK2dL?= =?utf-8?B?OXdVSUx3V0QrNnBNdXJSMUxIR0hnL3Zpc0daWFo1VXcra1lMaGx2bkR5R01t?= =?utf-8?B?MWlrMlhwRVFNZlRaZ1ljMDY4ZDE2QVdubWxGeTNpSDkvZ0RyQXJCWW1iQ2FJ?= =?utf-8?B?akU2Z3YwMC81MlRaK09rQnFGOXRHdG1EYlpWN2R1V0M3aGZ0enNsYUJlMld5?= =?utf-8?B?T2xDZW9YZFJQU0duU0hqUDdvY1hVNGtVMUNlUVlNSWsvTlBGb0IzQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5641874e-c3ac-41db-3136-08da431d762a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 15:51:44.3185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rLKLOGYZrY8Xu43FHnQD/iqgsygUTP8i54VExiJ/Y8A/3r5b1mR4M685VwmdGsyLDc2SipAuZKDVpWeTUUcV+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2563 On 31.05.2022 17:08, Daniel P. Smith wrote: > It is possible to select a few different build configurations that results in > the unnecessary walking of the boot module list looking for a policy module. > This specifically occurs when the flask policy is enabled but either the dummy > or the SILO policy is selected as the enforcing policy. This is not ideal for > configurations like hyperlaunch and dom0less when there could be a number of > modules to be walked or doing an unnecessary device tree lookup. > > This patch introduces the policy_file_required flag for tracking when an XSM > policy module requires a policy file. Only when the policy_file_required flag > is set to true, will XSM search the boot modules for a policy file. > > Signed-off-by: Daniel P. Smith Looks technically okay, so Reviewed-by: Jan Beulich but couldn't you ... > @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( > > printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); > > - if ( XSM_MAGIC ) > + if ( policy_file_required && XSM_MAGIC ) > { > ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, > &policy_size); > @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) > > printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); > > - if ( XSM_MAGIC ) > + if ( policy_file_required && XSM_MAGIC ) > { > ret = xsm_dt_policy_init(&policy_buffer, &policy_size); > if ( ret ) ... drop the two "&& XSM_MAGIC" here at this time? Afaict policy_file_required cannot be true when XSM_MAGIC is zero. Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 15:55:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 15:55:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339837.564745 (Exim 4.92) (envelope-from ) id 1nw4Dm-0004Z2-JL; Tue, 31 May 2022 15:55:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339837.564745; Tue, 31 May 2022 15:55:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Dm-0004Yv-GF; Tue, 31 May 2022 15:55:50 +0000 Received: by outflank-mailman (input) for mailman id 339837; Tue, 31 May 2022 15:55:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Dk-0004Yk-L1; Tue, 31 May 2022 15:55:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Dk-0006vp-Gz; Tue, 31 May 2022 15:55:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Dj-0003bP-VT; Tue, 31 May 2022 15:55:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nw4Dj-0007sq-V2; Tue, 31 May 2022 15:55:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vbNHWhi8YAhywP9orFYRp0aHdvH6mumJVbqXFwgGhgU=; b=0bUm7/f55H+OR+LwOr+3TO9rGG lbrq73arZHFNREvG0LOhYvetpkBp3AH3HZxjsiKlH8Gp3yW1TuDg9oSpY8U5ejbaiGp8Bbuha5KsG MzRnpV/NlBEl1Ze2ynZkSqADgEtnfFCkBiaaUpKgBVccWFcAkSfwgiVVqz93HdONi3Mk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170785: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=8ab2afa23bd197df47819a87f0265c0ac95c5b6a X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Tue, 31 May 2022 15:55:47 +0000 flight 170785 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 8ab2afa23bd197df47819a87f0265c0ac95c5b6a baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 7 days Failing since 170716 2022-05-24 11:12:06 Z 7 days 21 attempts Testing same since 170779 2022-05-30 21:42:54 Z 0 days 2 attempts ------------------------------------------------------------ 1946 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 217025 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 31 16:01:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 16:01:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339849.564756 (Exim 4.92) (envelope-from ) id 1nw4JO-0006dI-CB; Tue, 31 May 2022 16:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339849.564756; Tue, 31 May 2022 16:01:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4JO-0006dB-8O; Tue, 31 May 2022 16:01:38 +0000 Received: by outflank-mailman (input) for mailman id 339849; Tue, 31 May 2022 16:01:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4JM-0006d2-UF for xen-devel@lists.xenproject.org; Tue, 31 May 2022 16:01:37 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f06a67b5-e0fa-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 18:01:34 +0200 (CEST) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 12:01:30 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6313.namprd03.prod.outlook.com (2603:10b6:510:e3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 16:01:29 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 16:01:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f06a67b5-e0fa-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654012894; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=IKq3yEw4IpgbqYVNdKvP5vhfnCDlPkyF+XT7F6+xzow=; b=S2Tm7g5E9pv1VcF3CvJi29TWXv0SQtVJjnxNCFhqWmfrRJLJD7jOdGmT WkKqrPYH2W509iA1jmgwVLCr6kobQ/TejkNHL6OxOL5QCex+/AKiwPKKF 1vV8Yw6X2duWVZyKZhA+h19z3RkDKjvSRivEsIWO8l200ma2LAD0xlbl1 w=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 72544678 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eh78yqyWpPSeiXA5mnl6t+dNxyrEfRIJ4+MujC+fZmUNrF6WrkUCz WUfW2CFbqrYYGLzLdF2PI2y9xsDvMDRzd82SwJtqyAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12oHhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplk6eWEx0Vb6P3s/k4FBJRAQA9F50W5+qSSZS/mZT7I0zuVVLJmqwrIGRoeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHOOTu44wMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKWAE9AzK9cLb5UDy4itI+r+uOeDyReOgfu9HxxqHm UX/qjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsH0QhmQsHOC+BkGVLJ4DOkS+AyLjK3O7G6k6nMsSzdAbJkqsZEwTDlzj 1uRxYq3VHporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9UDSW517YRY36piG IronPort-HdrOrdr: A9a23:pLd4rKF3D7bxnuWlpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72544678" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DQUVqL0XSkyVTkhpExje4biuCULNzYakUwo/2YynJS0oYZxjlpduZw97XDyHlBAO3kcpjtE3jLEFRRUlCbSGz91sTTgzSaB3MOyLmBORnXo0AifHrYWm/Y+mjxmLAzXLH+e87d7lEygEW6jnO9dO0XRIA5lPrL+JvmRxbKm2RRwH3bpttDKGbwkeWBm19CEOUXztcSbYuQaagg5qtD5b2BDlU9D+sKRYXgWZT18u04dT4Uv3LTzG+Q3IM9vDkNn2LIL5yz1ilixJAKReJrlhCEz7JI2geGM4LonhgaddTftqkuAHcu2QcxSVWkykqQzENL35/ftCU8w2r3+VNdKWdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RYpT6ALAe8NCcFBFfjwCnKc+VRgSWanZdXJjpsA+WWc=; b=L6rWwzyvH0aEi8pLU0armT9dYGeyREbG2hYsBmFd46/UKeIIMECIsWdFtivCKxj8Nt8aK5OEFjrBpZZ/6dpYw0PVdKHFa3fVBVz4Bg/vjoLAV8Bbh8kSKTufTUp4WT97pZOSKpgcDkyMenICs+s9p1Z4P0cYlU4CZ+0Wrqe1Dg9ucTpMaBJUcaw8DfjXCaTbF0CjRK/lMBncA3+3Y/lPkEm0E1FP9TfJeHjOIJtlswsQuKEe39zcw6nLgsPolHtBTyNEqtnLChva2QgsaDmS4YZvhhuOH7rCY2wLXLKXFhlnWqja8pwgpC/olDtfRD83Ddgr8iTXP7pR3QAA5JN+9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RYpT6ALAe8NCcFBFfjwCnKc+VRgSWanZdXJjpsA+WWc=; b=PjBzlfSpItBTJOzHTX/nKbiLKtAO5oAptSbOeI54MP4EziMNxDWc7ZbseRilNKw+6lj2DAiTIAD3qrXL7BZ3GlG+cH5pWPySEjyfqTxwd+LpalSIpxjPbn7WJsjGc3/HqEskT7pbmQwL+cyDnpsS6YAO9deqlSlovBInNY16dj8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 18:01:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu Subject: Re: [PATCH v5 02/15] IOMMU/x86: perform PV Dom0 mappings in batches Message-ID: References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> <67fd1ed1-4a62-c014-51c0-f547e33fb427@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67fd1ed1-4a62-c014-51c0-f547e33fb427@suse.com> X-ClientProxiedBy: LO3P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 791824b2-b983-4b53-3cb6-08da431ed2aa X-MS-TrafficTypeDiagnostic: PH0PR03MB6313:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kyf6c+RQxThYDKgvCl6V3QsDJZ+ySEOm5/7TURUpew2AdRfK/R0vDXQYTLmRggMqkeuNpTXbKJHbph3gWp1qPqYA0a3TCqBTV6V6EtG1L0RPUQyubmMueIb3UnzuXkQ3BfgIZrAdLAWtNpTJOyt9gRTamNi25MShLNoKziLibe2S8SFRRP+b3qS3LLXmCQl1qVCH0RS+OTJ1N2TmZ2OrSF8rWHSMZ1n/HeBHPkmLlpZ8vG5KapsTrJvl5UKpDIdUrJF8rSMEOJchU1lTtfrc+Q7yGSiVXu8V+4M+F2/KuQp+OUQEbY8bl4DG73BB+bR8frvhtH+9WwaV7iWzI/YY0rdtsvMvGvF2cJpnmVoWaRebLmfBvo5KTxPl6unSzr2pkntwV12P3gYCFxuq1iRv6Z7F8qdsIIldNdm05/spG8gsMTkwY46oxXx0+79/3dRx2A9q49FNIKyxlseJ9e2yqoLMLBuWEad0bWhYiwFHprSMeJj03ogG8zjEZxcgjzrSusJy4W1JFm9/oxZAnXMKiaXRdoVsfCRE20yilN/CGu6dmp7yISu6zp3lH2DD8dbe8yk0mpJDIk3IQBxjy7X+RdBqaS9skkwT5/sFm/cNHsl2GR9wOXmzYN/EdnrNZltckTwiyy8xfUbTkE0KSz/QIjr4vG4CBI1tseB7R0pzvrX9IRZivTMxdJFKFTLRMps4yT79vj8/T+vLEdysyIQcYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(4636009)(366004)(6666004)(86362001)(316002)(508600001)(186003)(2906002)(9686003)(33716001)(54906003)(6486002)(6916009)(26005)(6512007)(5660300002)(6506007)(83380400001)(82960400001)(8676002)(85182001)(66946007)(4326008)(8936002)(66476007)(38100700002)(66556008)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1hsVmlhbE9NcXlaOXRQRlBEMDdhMWFJYTVySWJvQURjVnl1RnZkOThoNHBv?= =?utf-8?B?SFZrRDkvZ0FEdldySHl2VkJOVXlFMENNakhhQS9rR2FFcnpRVXNjTmk3d3hE?= =?utf-8?B?T0YxZHFlOHc0Q3lvZU9oN1U0VUxPd0xvM1hLMzJCNTZkVXNuYkg5RFppSzZo?= =?utf-8?B?d0NnaVVxM0gycExLRjNBN0FzcXQ1T2RMaUd4OWZ2K1ZFRFdXTXcyZlFubGxC?= =?utf-8?B?VTkwZXl6cWZPTnRhYkZVcXZGOTlDV005WStXTTdBTVg4VUZJMnNiVFFYd0pt?= =?utf-8?B?V1MwOXZTdGtNd1MxMVVWdHM3ZG5nTFllZlAxNWhHTVhyRGROU002bngybDA1?= =?utf-8?B?RGhKRXlKVldaL0x1RXVhL2R5WWFjTk8zanhIcE1XakIvSVNKd1dHUDBjVEpt?= =?utf-8?B?ZjBaVGNneWw4clN5WmtIcSsvUXNaRDJJYUZZclhMa3pMVThiQTFJdkdFMVlq?= =?utf-8?B?bmZJRGVDQXV6ZGpFZGE5bElkcVNtV3BTUUFjWWZFZWFDOXE0a2F0WDlDSkJ6?= =?utf-8?B?aWFWT3N2WDZycjJHRmtTTUR6czBRQnY2dlJSOStaYzNqeW15TnB6S3RHSDdU?= =?utf-8?B?RmlRaFMwR0FEcUM5d1RSYjdRSFJRdXg0TWpCZjhCcFBEcmVjOXhuYXZLQjQz?= =?utf-8?B?S0E1Y01PNkxQMjBvRTBscVJzaFRUZjIxZzFmK2tlcjV5NFMxcHplYmc4TVJh?= =?utf-8?B?Nk9Wd09JRDNHNmxHcXZBZkdVUlNwQ2xUUWZyME9QRjdPVEZTSEZvSzA5YzRl?= =?utf-8?B?MXNCODZHdjg0SE02WVA4QzUvYVMwRlpBRnBHNjFqYkRPNWV0OEx3bFkvTnps?= =?utf-8?B?Uk9OZDU0WWNibDBHa1NYMkxxT2JscGdkbGZMMVpxeDVTd1M0Z09MRGFrSnR1?= =?utf-8?B?UXlGbjA5TDZ4aUdYNGJ3c0drSVE4bElKbDAybmIxWG05UzZ0aUgzYlpaOVdu?= =?utf-8?B?ZUNzMHlRZE55TDE3VDZSNDBOT3VrV0xEZzNYQ1R2eFV2RTVFenFEOTNSSlBG?= =?utf-8?B?cXIzM1hMZlR4WG43V3cvRFVKSmx4bVhNdHFNQUdkZ1dUaGtYdlk4MnkxSUFY?= =?utf-8?B?OHkvQ2VUZzFKSk5COUQ5MURpNVdtRlRreXBBZ2dISVBoUjNwYlAwZjdvOHBV?= =?utf-8?B?UVJNYU9ZQzZMdGhZVktVYWp4bFFBT01FZlc4UzVXYklqRkpnU1lhclZ2YXZ4?= =?utf-8?B?RGdLYVRHQVV3M1lKVVZ1ZUIxYW01a3dDcVlDSUdmc2RnVnhndnUzL2VKYlZL?= =?utf-8?B?MENUTEN6dkNyN1VuUDJRQ0hVblNaNUZ3V2ZJdk9CMlNjeDUxMkFmb1FvaUEy?= =?utf-8?B?UVB2OXRDbkkvLzZEbWt6bW9pek9xRUFUZDNySGNhRWhxUDZHV0dnT2RXYlFv?= =?utf-8?B?cWxJTkQ1ek5jRmJINkh5bEpud3QrRXdpTlp2QkdYa09ncG4xRjlPendnUnhM?= =?utf-8?B?T1B5UmlwTnFib05zdEZRdDZKZ1JmQlN3S1hGUFRYZGtzYkNYdy9tQzNiU0NV?= =?utf-8?B?Yk56dHN4SGRzK09MVGh2ZUN6Ny9vSi9uNnR3RHh2bmhrZEhLZW92a3RTTDJD?= =?utf-8?B?NTFhczgvcDdJQnJTSUJZQ24rSWhUTWdUTnVRVU84dnpsbzVva3RxT3MwWXBu?= =?utf-8?B?eEVsOE9tbi94Nnp6RWlYNEhUSDlBT1N5Z05HWlk4WlRmWlZOd1BBMGE3RVAx?= =?utf-8?B?UVBwTmQrQjczQjdDc253TzhWMlpzZHMwRy8wTzZoQmRWLzhHOE1BaDRHNXhF?= =?utf-8?B?WG5nOUp1ZW9LVjI0eCsrTVhEeUlaNVQ4OHBabjhGalhsYUNyVC9zSjRqSEN2?= =?utf-8?B?S2JMOFphcEluTjNUd3FBZ2E5WjZuUURKSWFtYVFqTWZIT0dtaXcvZkRtV3pa?= =?utf-8?B?Q3dDTWdWd2hiZFpjSzJEQzlkVTNnYWh2dkg0aWdsR1JueTlqTVBsOFhpejlF?= =?utf-8?B?c3liYjBLdDFQVXNOZnNYL29xNUFJTTg0NXdkTHl3R2Y1OEZ3QXFVYWpBc2Q1?= =?utf-8?B?dWNRLzhjN1lqRkhGSUk4aUlFN21GREljT2hwdWd2d2pIK3ZWMWZ5SFdONUxi?= =?utf-8?B?b2RYUU5NVSsrc3lpMUJDYlZIZFEzVklwTUZ2UnI1UXltekpSTVlhamg5dHFS?= =?utf-8?B?ZnVGZ1ZKQ0Z0RWhvdE5rTW50ZDNzRWxqU0sxeldkSnQreDA0WGRZa2xnbDlV?= =?utf-8?B?c3M5MzFCVGRZWDFmdGhnU3dkbnZQLy8xdnhhaUkwN09FTFhLb3I1NUo4NGNp?= =?utf-8?B?MTY0ZTM1TmZrWXQwS1pKdHRPYVNzR2hLUkpJSTBRc1FkUEpJOHUvM2RxcG1C?= =?utf-8?B?akxRVkFOZVYrWkFkaEo0dWlFUzgyQ2FnOWQrWDVhWEI0L3VQNFYrTmJxRmk1?= =?utf-8?Q?FUaktGZCxZiLLaCQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 791824b2-b983-4b53-3cb6-08da431ed2aa X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 16:01:29.0985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /8hAMIjuqdrjSc7NKItg+zUn61/huoAplYeY72ursjZE9GwJIlJlzXysEm0ghup9+ub0c9o/TCO+eScflSYLFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6313 On Fri, May 27, 2022 at 01:12:48PM +0200, Jan Beulich wrote: > For large page mappings to be easily usable (i.e. in particular without > un-shattering of smaller page mappings) and for mapping operations to > then also be more efficient, pass batches of Dom0 memory to iommu_map(). > In dom0_construct_pv() and its helpers (covering strict mode) this > additionally requires establishing the type of those pages (albeit with > zero type references). > > The earlier establishing of PGT_writable_page | PGT_validated requires > the existing places where this gets done (through get_page_and_type()) > to be updated: For pages which actually have a mapping, the type > refcount needs to be 1. > > There is actually a related bug that gets fixed here as a side effect: > Typically the last L1 table would get marked as such only after > get_page_and_type(..., PGT_writable_page). While this is fine as far as > refcounting goes, the page did remain mapped in the IOMMU in this case > (when "iommu=dom0-strict"). > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné > --- > Subsequently p2m_add_identity_entry() may want to also gain an order > parameter, for arch_iommu_hwdom_init() to use. While this only affects > non-RAM regions, systems typically have 2-16Mb of reserved space > immediately below 4Gb, which hence could be mapped more efficiently. > > Eventually we may want to overhaul this logic to use a rangeset based > approach instead, punching holes into originally uniformly large-page- > mapped regions. Doing so right here would first and foremost be yet more > of a change. > > The installing of zero-ref writable types has in fact shown (observed > while putting together the change) that despite the intention by the > XSA-288 changes (affecting DomU-s only) for Dom0 a number of > sufficiently ordinary pages (at the very least initrd and P2M ones as > well as pages that are part of the initial allocation but not part of > the initial mapping) still have been starting out as PGT_none, meaning > that they would have gained IOMMU mappings only the first time these > pages would get mapped writably. Consequently an open question is > whether iommu_memory_setup() should set the pages to PGT_writable_page > independent of need_iommu_pt_sync(). Hm, I see, non strict PV dom0s won't get the pages set to PGT_writable_page even when accessible by devices by virtue of such domain having all RAM mapped in the IOMMU page-tables. I guess it does make sense to also have the pages set as PGT_writable_page by default in that case, as tthe pages _are_ writable by the IOMMU. Do pages added during runtime (ie: ballooned in) also get PGT_writable_page set? > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -363,8 +363,8 @@ static unsigned int __hwdom_init hwdom_i > > void __hwdom_init arch_iommu_hwdom_init(struct domain *d) > { > - unsigned long i, top, max_pfn; > - unsigned int flush_flags = 0; > + unsigned long i, top, max_pfn, start, count; > + unsigned int flush_flags = 0, start_perms = 0; > > BUG_ON(!is_hardware_domain(d)); > > @@ -395,9 +395,9 @@ void __hwdom_init arch_iommu_hwdom_init( > * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid > * setting up potentially conflicting mappings here. > */ > - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; > > - for ( ; i < top; i++ ) > + for ( i = start, count = 0; i < top; ) > { > unsigned long pfn = pdx_to_pfn(i); > unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); > @@ -406,20 +406,41 @@ void __hwdom_init arch_iommu_hwdom_init( > if ( !perms ) > rc = 0; > else if ( paging_mode_translate(d) ) > + { > rc = p2m_add_identity_entry(d, pfn, > perms & IOMMUF_writable ? p2m_access_rw > : p2m_access_r, > 0); > + if ( rc ) > + printk(XENLOG_WARNING > + "%pd: identity mapping of %lx failed: %d\n", > + d, pfn, rc); > + } > + else if ( pfn != start + count || perms != start_perms ) > + { > + commit: > + rc = iommu_map(d, _dfn(start), _mfn(start), count, start_perms, > + &flush_flags); > + if ( rc ) > + printk(XENLOG_WARNING > + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %d\n", > + d, pfn, pfn + count, rc); > + SWAP(start, pfn); > + start_perms = perms; > + count = 1; > + } > else > - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, > - perms, &flush_flags); > + { > + ++count; > + rc = 0; > + } > > - if ( rc ) > - printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n", > - d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc); > > - if (!(i & 0xfffff)) > + if ( !(++i & 0xfffff) ) > process_pending_softirqs(); > + > + if ( i == top && count ) Nit: do you really need to check for count != 0? AFAICT this is only possible in the first iteration. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 16:05:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 16:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339859.564766 (Exim 4.92) (envelope-from ) id 1nw4NT-0007Kx-Tv; Tue, 31 May 2022 16:05:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339859.564766; Tue, 31 May 2022 16:05:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4NT-0007Kq-Qs; Tue, 31 May 2022 16:05:51 +0000 Received: by outflank-mailman (input) for mailman id 339859; Tue, 31 May 2022 16:05:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4NS-0007Kk-GH for xen-devel@lists.xenproject.org; Tue, 31 May 2022 16:05:50 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 897e0c02-e0fb-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 18:05:49 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-35-i8juIK0JPfK34o7iLT-K8Q-1; Tue, 31 May 2022 18:05:46 +0200 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 16:05:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.019; Tue, 31 May 2022 16:05:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 897e0c02-e0fb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1654013148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RXFilAsXVY1I7q6k0txm2ejLetW03uIyctVCES+Ti9E=; b=hDBszHxdFCJIbXudTprhN+AqXAxdyQT7ybOsjlrlexwxhJVX2izcKMKLB7QNDmXyBi+aQZ IFhWKZBtp5LmyhcMfhYQN3GR1X/Bw4mXFgVfQ5/uVvaLg8dfKQDrx3lOPxNoCAFGNKyLEt 2FsdmMsSyq4GtnoV3LxhlkReOCm5tPc= X-MC-Unique: i8juIK0JPfK34o7iLT-K8Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CA9pnhDjJkKu9XsJM361iVutVqnOrbQiwVvvPf4ytTvBjCHZ5jZGGYS48XQdYT8cNuDhv2yRt8sr1G+AoC0ZSLYqXunb/k1zvSFwodSlT51aUGdpYmcJnpmlZfMv6yWQg+ozEi+OFU1lKZkhI/Q8/+v081TuF3BG+6ZgDONkzE7rV/ue0qt1VbjUrkz7ujkJ8K03BbKOLcRx8hKaQViE3oXzE4d6+fD0abclsG4tHSDlKTc8LgZcmR1WZkvs8XsnhxoVMAgWuXn/fiMKrs5psuyzIObeSnO0PJeq/m7k5Om/HK+0usF2vU2DVK3U4XYa03r9G4FWHcSme59ZvfWUwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXFilAsXVY1I7q6k0txm2ejLetW03uIyctVCES+Ti9E=; b=ZPfw3erQLEHw7/N751XE1BnLn6nBlQjg447M6hh3ySU+lYKZgKMk0sIHu7duvOVnwidvV9lKtq8SjsoAbz5E+7uUTtLKGLNDM6RPi98J/QTxMEahNnrPe0pO4cTXhESBpQNSbXMepq5oCryCRdQmbHFHI0y71TQCwPmk/CRTXhkKb3ih0iDbsEwQvWhOGLM2okH92HcUyJsr9cDLz0lzFPgo9+PJmbQqf0txSmKRM9Kf/Mw6xz2V1h+DSuyl7vvDQMQrWBQHllwQcK/nwpYQDeyxEcqX9ZydvG3ru0lNu8TAIOITgLrdvRBa78bS14fp3QBiBak6TIsDN7ge7fR2ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <53a64002-5369-26b9-cd30-119983518cc6@suse.com> Date: Tue, 31 May 2022 18:05:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 2/3] xsm: consolidate loading the policy buffer Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220531150857.19727-1-dpsmith@apertussolutions.com> <20220531150857.19727-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220531150857.19727-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0072.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::49) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e1ab0a0-50da-4e3d-c11f-08da431f6b76 X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCtelB7Tiohw/22kGjZ8+F3cHSeRzN3wyAvgJVru3NJOBVVSg8NwfLvoaXA2Rr057UEzql3b79NP8zLFOsjELvfFJ5+6fv0am2U9Yl99TCihGBzKGnXsuyW+PjPM2+0s76+mA+tFAPafIeKCH019YE5Cinzkhf9XT3U9K3lstprAWOeotZdRvXciT6ILcJnYgkZ7lwiSSjjqRPUXLOd/uSG2gTe7YPELMQE9S6XWk6xrX2xQdE7PWx3nCXHH3A55v8di7HONR0DS2mMpvuabvTetEkXrjKZCn5MyDCGxvsz5kx/giBLu2GzjRLTlj78yGRD8TJwAFSBDrDcb4TcG5WTLO1i1pRX8gLKZYm9UHDA84Of29vi1Tl/67bsSirSGoiUsX9V9LoQWqJtPz+H0wySuoFWpDjTNODhBh9aJn23yLFLJtz7lY+HlsJx0MtnQQ9lvYGQYlYNrQaJj2o0itzuTpEYCmXVHW5nMUiRi/uEuXvCkxY08Qje7EA3bzFkCghR5fTz0O6CFRXfRLBZhmtMGI6BNiekHHGTxvRR0XC0hl489oEw3PgV+13eLGtjreyVxlRbKZ5RCMWbGKuCoSNsQHv03zR+knp69rI+A2sWFb4Rmxh/Wd2ipbv+yZJjMmqqVg9pCozVZJn7hRqtj4SltNAKl6C8ZuOoqNreC0g/MAqESGIxpQIUaDoSljie4KDAgAGu8NVE9fFsFu3fvTFi8zoR9O3PmhzYl9GFYQ5TE/IjBNbshdV7+92xe1R8f X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(86362001)(2906002)(186003)(2616005)(6506007)(5660300002)(83380400001)(6486002)(31696002)(38100700002)(4326008)(66476007)(8676002)(6512007)(66946007)(66556008)(8936002)(31686004)(53546011)(316002)(6666004)(6916009)(26005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blM1dWl5TytjRVZqSm54MXFjL3c4N1FtRWlwTHR2b3NXdGlyK2lnL3hoZzUx?= =?utf-8?B?Z1RoUGtvdysrR25WelhXaWJoTHVWRUdQSktMRlo0bUF6K1VLU1NqNlV5SDVN?= =?utf-8?B?WFd1eTB6RGQvSGxhemxUdG85UUNZMW9JdGFYQmpLQiszMERRMC9ScDBHQXpi?= =?utf-8?B?K3N1N1BEcG80bEJVUkZsdjcxN3YrUHhmcHk3dnhGTTdEVzBBUk1DTEx6Q3la?= =?utf-8?B?bWh1N2R6c05kV3RGb3FWUHRqNXNJeXlDcXVWK2c1SS9GUEJTRHRLSEUzL1du?= =?utf-8?B?VnFFZFFzMzl0bjhnMXlrTWRISlljckhZTnpRUUVxaTZBRjFIRFFWQnJrUU5v?= =?utf-8?B?MGt4VmZ4SUxHb3NobzRsUmdITldJOVlxWHk1dVhCT0dHbng0d3NaMmVmMDBq?= =?utf-8?B?MEtqMEtxUFJzRmR1Mk9XelpKc284WFpyTk83c0dQTXM0QnJUOEtoVXh1VFV0?= =?utf-8?B?ZXM4ZlhzQVR0bE1aQ3R2ajFYazFSRVBwenZRS0ViTzRPN2pUVThRQlJES240?= =?utf-8?B?QmZCSGpQMnB6cU5rUnpkczQ4ZXB1c1BIRk9CM08rQlNiMkpGR2Vwcm9SZG82?= =?utf-8?B?QVpYVUpxNTU4TkVnWWhJTmUvdGc4dEpuSVJnU2JSOXRxaERiMUtsZFk5eWoz?= =?utf-8?B?a2dQYVVaNjdOQmMwWk1LMEdhYlMrbGd3OUZCYkhvNUUzTG1LUkE2MXhuaGJ6?= =?utf-8?B?QldsZXBEUnBzdnRKWGZUWGo1clZSL3dxd1V2UnY1VEg3MElnKzJjSzlDRkxz?= =?utf-8?B?WGJ6T0haSkprLzdEdk9xeFM4RFhjS2Z2ZCs1QmY0U0N1ODlDWXZLWHo4eHVa?= =?utf-8?B?YkgwQWtkdXdVM3hYM3JybGd5Y0o5a3RoSWpsc1B1dU95R0xXczR5TEtPanlP?= =?utf-8?B?M0VnY2ZKdmF1U1B2Qi8yczRURVNUKy9BbC9saSs5MVpvOTZGOU01OTFmQXVO?= =?utf-8?B?SkZGN1RYZFhhaUwvc0ltV1gvc2V5Y1BHNGs2cE1ZNXpZbWFTbGw2T3Z3c0ZE?= =?utf-8?B?RnNFdXg3dU04TlNOUGZ5YW1KNkU5QzM0T293N1lwaE9idDhjbUpNZStMTGxS?= =?utf-8?B?Q3JtVVhlaDloNThrOHhsSWFHdkI2aEtrSUJlQnFyZ2ZMSVpPSlJ3NXh2dFpv?= =?utf-8?B?UnZBc29HQS9vSE5mTnA2RWFLa0J0TnBsV2tvWWZvS3N0WkhHeHB2TlloMkI3?= =?utf-8?B?K29sWmN4eHJRV080VjVPMjg5NlZpVXVKTk1pWTVRZG1oZmFVLzVZNWFRb2Vl?= =?utf-8?B?NDVNUDRFRmJDdmg2aURWdVpGVTFqQTVKdWJxK0p2SDI0bTJVTUxuUERXZTN6?= =?utf-8?B?OTIwUG82aHZBQy9DYkx6NkZKWXJhZ29mcXBHd1FiY1c2dlpmOERIV2VYaVN5?= =?utf-8?B?d3ZucS9DZ1AwTEoyNXBsMWJWMjNSbkZBMnBCYnozZnNvWlVYd3AvcXNkalR0?= =?utf-8?B?WlErdHl0Umk0RFpaQ21ONW5YUVRISlJMaGRVMzl6NFVoUXRVRFBYS3UyeEtU?= =?utf-8?B?V3V4aDhYYXNVcXd1Ti9CZ2JGYzZ2d2FPNVhjQVBFNVgrM2phU2dKK2tWSVpK?= =?utf-8?B?SVY3dzIxWVZVRURIYWFGTFBHVmo0TzZjRTNBUHhveERxMGlCOGtVZEJjR3B2?= =?utf-8?B?aC9xK2FabjRZQ0tTWVFlcEptNkR6Wnp6UWUwdE1DNEIvKzlQK2hEdGRna0lE?= =?utf-8?B?NWZEZVJrTXp6aStMSG1pbUo3R243U3pKdFc2OVlCbnN4TWsyYzdhYUtoYiti?= =?utf-8?B?YkhycFZtb2t2eUpmRDZwZjFObDRNQS9pWWszNTZUU2hMSVphaEpMVEZRdlRX?= =?utf-8?B?VWxYcXJ6NDVtVThGSlpCRTllYXZCQjNGcEhGelBJWUdsWk9MQ3JnR1FjWEVB?= =?utf-8?B?VzhadGdJd01mZ3psOGxVMVdGQ0V1ZnBzQmxXczR5dW5Ldy92a0g5SlA0RWFu?= =?utf-8?B?K0x5aWJTMHBXYmEwM3V5SHpLbjN2TDUzNWt2SU1FanFyNlBQMUxIdWQ4MEZh?= =?utf-8?B?RHYxcUc0dENDZTJQbnYzWXhwZTNjdTYyZFZKQjcwdXFmZllrRlBnVGNxMlZO?= =?utf-8?B?MFU4TzhBclRRald5MXpOWEJhSm5aT3lLRUpXSGZ5WjJJdnRxbmVkR1ZmRDVF?= =?utf-8?B?OGszNG0zLzZweDA3OVo3bXdsNnpDOHROWlI1U1B5MnZiSWdUSXQ3MkVSdlBR?= =?utf-8?B?eG5vMGtsYjY3L2MzSmFkY04xN0lkNU43dCtLd0tUZjhEcWV6VEh6eDlJS0I1?= =?utf-8?B?dloyZkZRQVJVRmdWNTU5anB5cFBvSTFCNVBpdHNZWlpGMDNNSmsvM1loTnNs?= =?utf-8?B?K2psMGRvR3lpQjBTYU1ZTklJTFNLYWhZa0RJWEV3Sk45VXgvQ0JQdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e1ab0a0-50da-4e3d-c11f-08da431f6b76 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 16:05:45.3900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4UL2NSFa+BU5N2VOxQ0zK8G3/xmfwiMs+wKoHovdShPZXCgfRxj9hgmcVc0zBzBVT/lKCCuyQOohfg5Qbn1pow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 On 31.05.2022 17:08, Daniel P. Smith wrote: > Previously, initializing the policy buffer was split between two functions, > xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading > the policy from boot modules and the former for falling back to built-in policy. > > This patch moves all policy buffer initialization logic under the > xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error > message is printed for every error condition that may occur in the functions. > With all policy buffer init contained and only called when the policy buffer > must be populated, the respective xsm_{mb,dt}_init() functions will panic if an > error occurs attempting to populate the policy buffer. "flask=late" is also a mode where, afaict, no policy is required. I can't, however, see how you're taking care of that (but maybe I'm overlooking something); inspecting flask_bootparam in generic XSM code would actually be a layering violation. > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -775,7 +775,7 @@ int xsm_multiboot_init( > unsigned long *module_map, const multiboot_info_t *mbi); > int xsm_multiboot_policy_init( > unsigned long *module_map, const multiboot_info_t *mbi, > - void **policy_buffer, size_t *policy_size); > + const unsigned char *policy_buffer[], size_t *policy_size); I don't think we're dealing with an array here, so const unsigned char ** would seem the more correct representation to me. Also - what about the DT counterpart function? Jan From xen-devel-bounces@lists.xenproject.org Tue May 31 16:16:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 16:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339868.564778 (Exim 4.92) (envelope-from ) id 1nw4Xb-0000Us-Tx; Tue, 31 May 2022 16:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339868.564778; Tue, 31 May 2022 16:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Xb-0000Ul-Qz; Tue, 31 May 2022 16:16:19 +0000 Received: by outflank-mailman (input) for mailman id 339868; Tue, 31 May 2022 16:16:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Xa-0000Ue-CC for xen-devel@lists.xenproject.org; Tue, 31 May 2022 16:16:18 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdfcc787-e0fc-11ec-837f-e5687231ffcc; Tue, 31 May 2022 18:16:16 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 12:16:03 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN7PR03MB3939.namprd03.prod.outlook.com (2603:10b6:408:25::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Tue, 31 May 2022 16:16:02 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 16:16:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdfcc787-e0fc-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654013776; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=kbwgNz4mFNW6+xZxRB1VW5GX1OZj27txPQswu2mAgTw=; b=KpTgLXWc0OcBpztww/Gd//2ZFOzAwAwhJACmlmCD7Suebx4/2J0BxYXw W88cf2raRBp241ntR5E9snGHQtlRkR3E6I+2S2X0RS1IRQdvIuEJcYZtk /fRvuw+AUBMjl8vHlNV4YjGp2HI5IoI6OUp80bKrvxWIdN+2aR0On5P1A Q=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 72941733 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:s3mQV6/MzKB/aZ8wxSRjDrUD9n+TJUtcMsCJ2f8bNWPcYEJGY0x3y TZNXmrUP/+PMTTyLdglb4rk8xgFvsTWyYJiSlBor3w8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCncW3Uyp2fe7No+IMCiICPhpCB6Rfo4aSdBBTseTLp6HHW13F5qw0SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHfuMuYQwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgKWwE8Q3O/sLb5UDi8xMg3KHoPeaWWe2yVflHux6K/ TjvqjGR7hYycYb3JSC+2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM 1YT+Cclse417kPDZsH0QhmQsHOC+BkGVLJt//YS7QiMzu/R/FyfD21dFDpZMoR674kxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSvDdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:WZWoSqHG4RjYj4FspLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LW90Y27MAvhHPlOkPIs1NaZLXDbUQ6TQL2KgrGD/9SNIVycygcZ79 YbT0EcMqyOMbEZt7ec3ODQKb9Jrri6GeKT9IHjJh9WPH1XgspbnmNE42igYy9LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUtcPpZ3fSLlMB26ffrzWFjiUmjPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72941733" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZCN3r/+SFHf2HgkclEiCvl/Urz7DIfOsP/Hs5VB45Z2uUk7jtSxzubnc6Rkz3PsfjoQzrc8zSRwnp0iyzjmCjhyKEakS0YI4Xd9WbUtWFG7J9MLNGTKacBidxbDh6DyU+c1TyiLrQ3LF0T9CM9SeLQZe7YYbqUnj/f8Zwai48YHA9guHVP5ex9jP6s+iZieCaUpXWkaCcwQCR/2FvjEW4qVws633oX624X5/w+Pd5I+G665JVdA7fA1UKec2DXRvlWh7CwpfkUrCOA/vLfCl58LmzFmGctlVCGTU8eT7eip2AcjSkRvGMHQ+5nBBZkGGSkXbDGm9/EjDvLTfb5qpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tv6JrPyWyvBirgVn/N0qBAcfJniTmSjhtQuSiaBExcA=; b=IsRlSsK7MMGD/J7N+oaCJeWaDYCraCSxs0dJlGMsyFBNA4eJ2tyA17sb/nvcNSO1TzCSuUldDCa7GdKlEFpnsVOQtoBIJKFVze5db+G5fIk4rDHllAU9NJMBvSMRttAc8pX//b6EPGcJdSoIqdJdCr+Q/93hHt6AgcCsJm1RynxmWY/J0LdSqwK+sBINsYQOWRjkw0BaCa+sTzVgYrM9GmMf5KTUOld3CFDVHQCQm3+UgUgkEvRaqDSi18JW8dIu4XybLtMz9YCXPzGsPd3R2iGUASAs4LkoUc5aFoxkO3J2qgdhlJ2xKt9GWzvJhuKaWIWbwMn7A9Y8ito5cTzt/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tv6JrPyWyvBirgVn/N0qBAcfJniTmSjhtQuSiaBExcA=; b=RNuV2VkTihs+5zd+sCJafsUSKcnqATEfDA2l60/mgIqTMnDjFkq5dU6n9vmgUP+VsMyIo1GW3NIYxHP3QReNuHvCdt/uAaL4hn8316gTjOiV9DlpRQg5COK/OadWvDDNRUqg9FmWrcbLoyZWjL63ZzSkK4iXj1eR/0tYdRfXKJs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 18:15:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v5 01/15] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> <1de2cc0a-e89c-6be9-9d6e-a10219f6f9aa@suse.com> <22d2f071-4046-52c6-6f11-23fb23fb61c1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <22d2f071-4046-52c6-6f11-23fb23fb61c1@suse.com> X-ClientProxiedBy: LO4P123CA0371.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::16) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a4b02da-f1c8-43b3-44c8-08da4320db18 X-MS-TrafficTypeDiagnostic: BN7PR03MB3939:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3joPW+Y99AqVT77rLI+xRgifpCWbRy9W/cWkBWzEiu5ZZ2dJCbBXUyfMe4lqDaC3SWxa+WoBprWMZ6mivYnZzxZGMjZyYQtLH3F29S6IoOnhQSs9He0vBiB4/2JjzNzAkFWde9W8lHxc6OCaJCchpfzG25wT9ayP+54y2OCZwpoKWZC8B+P/erpFYWy4t0IYpjNKdMDahA2xRYIoFN9jvLDkCIrK7XfALlZQfELw30KVJXSRKf/MtXZoQ0Km1KfXXwyO8opMaQSD+MGa2KWD1R4jo6dVT5WAJi+bMmXZizjb/iTnlnfTQnsfMmz4+eAvOCCvY3G/X49x8VlLGnLRhHVAOGA5NOa5Hi4Z7QZkwMrJrevRWsS3hdj1Cd6qJlKtiKCKfFVdoh0/Na76ggC+Iaib9xa/B1/Gs+YBlzvxmf/LJf1mk4ctwuQ68OtANLGs6nHSLWuCUr8M8wocfYjUye37yw4iwR3wcpA6DfpTrnM838CcKoAoCKEhgdqIKvf+PRwHol8CB4I4G4cL/+EvRIIojBZsFkUI8tKhUvnY9YvBWr3+4WnEcc9J7oQeYCpqr7XYBe50bgsHFYBxcwlpqIIr76xRDi2VO9fEpmLp/+byK5eOsFT6msc5NsYrTWD3stLNijtno6fjmXqg4SJ6wg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(8936002)(6486002)(86362001)(26005)(9686003)(6512007)(6666004)(2906002)(82960400001)(38100700002)(186003)(83380400001)(6506007)(66946007)(53546011)(5660300002)(8676002)(4326008)(508600001)(85182001)(66476007)(316002)(33716001)(66556008)(6916009)(54906003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG5aeVNuNnJmblhkdVVaeUlZb2JndG8xcFUrbDFpbitCT056cFVENE1WdmFO?= =?utf-8?B?TVNhdG5rMStZUmxicWhnZGpudHo3QnlJajk3N1JzdHNZWGFhbm9HNU1XNkll?= =?utf-8?B?dGRVQUV5YkJwTnJWQzZBc0JGaVVrZ1lsUnkzNzlJOFZBdDZGNUNuYnpQajdj?= =?utf-8?B?cWk1ME5VNDU1SmRXemloSG1OS2ZqSEVRWmtMTUQ5SDlyeCtWSkluMnpOaFAz?= =?utf-8?B?a3cyS2tpQTdVS2RwNVQ5OWFjdnd6ejVzR2U0SVR1ZHlxd0RKRW1lYmdoMW56?= =?utf-8?B?UzBxTXlPbVY4YUZ3MjFoTFlKUUVGWlJjYmRzNzMxREFLaDMwV3UxQ0VoVEU1?= =?utf-8?B?Q25OUk5sRFdsR1FuYkE3QmNIM2U2WjhZZ2dqS2J5Z2hVVEZZOXJWV0lWN0Q0?= =?utf-8?B?VkJ5VS8wMlpYYU5Jc3o0ZTc2aTZzWUtvUlp0RDB2YkVzOUl5SndXOEYxclhB?= =?utf-8?B?VmpYbC92dUVhYXV3bGsrNHJXVEdLeVgvMjFwWE0yT3gvR2dnZ2xyZVpGVVhp?= =?utf-8?B?Uk5Kd2U2R0R4SllDU0lSbG5tQk9lWUdvVGFrWVoxcDRRTDUweUVHWkt5Ykwy?= =?utf-8?B?dngyZ1dGY05FcWJjNU1rQnFUQlNSY3JDbWM5bHpWOHNBdllZL2MwZTV0RCsz?= =?utf-8?B?WFhZMm1HZEkvWjNGUDRoTWc5ZHY1dHhpSjExNXJzU1RQNnR6L0FkaDFONGhs?= =?utf-8?B?Qkl1UjBEMms4OUxGSjl4NFBuNW1QdEtUWUFONFJOenAyNm9SdDhFMW5YWUZB?= =?utf-8?B?Q1Y2RG0wODljRHdidkhCUG1sUFF5ckYwUXllR1lHL3p4N0FlYXJSdDd5cGFR?= =?utf-8?B?dDhEQ2llVzB3b09TZE9Uc29ibjlXZFJzemFUcEk1WWprekxtQ2FBTGFnOU42?= =?utf-8?B?NXoyOFRnUFhrQU4wN1h6RjhPZDhTRHZDWXd5R0VXQndKbi9LZ1hYTmw4Z1FY?= =?utf-8?B?UFpVQmdxc25ST1Z2bFEvbW8vUGtEQzZWZE1Velk0RVMveCtOd0hSaFplYVpv?= =?utf-8?B?WFUwcUd4bVcrOGlxYlNLRExoV2NOTU5QVFQ5UEJMclpZT1IrdGZvRFp4cHll?= =?utf-8?B?ejBGSWdXamRRaUJQcHJSTG9uQXlVeGF4Qi8xMVdVeDA5TDBEcVl6dDg5RzNk?= =?utf-8?B?dmRnVkIzc216ZTdqRzNMTys0OVZMbTNRd3QwWUpLSmVVVzB5ajRmTENPT2wz?= =?utf-8?B?U05ZZ2xNbzR0bmU1cUpWVndVWXAzT3QwdkE1cGk0djVNSkJKRmFKQ2JYd2hy?= =?utf-8?B?S295RnNpbnl1RXpTUjlvaEc4VzdHWVorWXVNSnpmVEk5eklZdFJFMng1NlRS?= =?utf-8?B?TUhqWU9peWNrL3IxbHpWS0JPRFhYMWcyeEhhZzVRN0VuanJJTURjSTI2SnZO?= =?utf-8?B?UEJnbTcvVVIwUWROMFVrbFhmRWZaL002L095d3l1RnhhY0trdE80eVJvQXRt?= =?utf-8?B?VUpxY3k2ODZDdllyb0lheDc5Zm1Zc0lRTHBkbkRPaTl5RExSTzFxOHJLNVQ5?= =?utf-8?B?VHZMLzJMa01WVXhmQ29TR1gvaWNvOHRHYXNDOXk4aEJZYlFJUzlzRDJKS1Jy?= =?utf-8?B?SUdGZWwrRmIzdkV1SmIvR2FJejRoM2FpOUcxenVCNUZ4dE5PMmZYSFBsOUx5?= =?utf-8?B?RmRBSnJwSW5MajlHdU1EL2NCTGE4dDE2eGhUWnZDY3Bsd3QwUEpnSEtmdnhL?= =?utf-8?B?dGFidURvQS90NmZPUCtuVjltN0ZITXdLZ2dXMmhvNlA0UnczZVdxaUJpWE5W?= =?utf-8?B?WWpFeWFrSHpwNzEwWXZhbkVnRHlyaXNoOTQzellsK0VGcEZIY284bTJRSUlr?= =?utf-8?B?UE5ONUdrYjVOUjk2Wk9HYUNTeXlyeS9YQk02bG9iZG1XeVJBREhPcGR4Qjdr?= =?utf-8?B?ck9iNjVScGV6WCtJUDlHaDJtU0ZrMk5qamlxaTFoNUI0cVNXZUM5SDZ6Tysz?= =?utf-8?B?Z1NVaU9kM2JISGxDSHdGZHM4YlUrN0hraTlzZnNKaW5IaE11WnJGU2hkL2RV?= =?utf-8?B?Mnp0ODRQZ2xucW5XZ2NFS2p0K2U5d2Ywc3IrQStYMldtTmVGbHIyRkk5QXJD?= =?utf-8?B?MHBTVEpDejNzOVRmdlpvUTk1S0hzbVM5L1NJUzNIcHpwWVNLbTZNaW5PK3gw?= =?utf-8?B?TE0rai9aaU5YWVZTdHV6S3J4VlVsRk9kZk5Fc041cjlJOGhmVysrQmM3cStX?= =?utf-8?B?bXlMemZiRzVRd0dzL2JlYkkwd0FkRE9KbVFycmhkd0p3bUlScnJCRzB4ZUVi?= =?utf-8?B?amVadEJER0pXUjJjSm9jSkVlV1NML0FYYVBxNkZXYjJLMUE1d1hsdEI2WU5l?= =?utf-8?B?ZTJLbG5YOWlWWE1Wa0g4WVg0Z3FUczlPVjhKK2JZMGZSU0ZBWXQxR283S3Vm?= =?utf-8?Q?RpqmUrol2dKtIvZQ=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a4b02da-f1c8-43b3-44c8-08da4320db18 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 16:16:02.2192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZxC/daKAQFlUbwtVqd53TrcQmAPsRZfszYDvRtbLiPs5ivDlvh+ODWPTaoZqMp9A/8NYpb82tqwwJ3NFryzhgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR03MB3939 On Tue, May 31, 2022 at 05:40:03PM +0200, Jan Beulich wrote: > On 31.05.2022 16:40, Roger Pau Monné wrote: > > On Fri, May 27, 2022 at 01:12:06PM +0200, Jan Beulich wrote: > >> @@ -289,44 +290,75 @@ static bool __hwdom_init hwdom_iommu_map > >> * that fall in unusable ranges for PV Dom0. > >> */ > >> if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) ) > >> - return false; > >> + return 0; > >> > >> switch ( type = page_get_ram_type(mfn) ) > >> { > >> case RAM_TYPE_UNUSABLE: > >> - return false; > >> + return 0; > >> > >> case RAM_TYPE_CONVENTIONAL: > >> if ( iommu_hwdom_strict ) > >> - return false; > >> + return 0; > >> break; > >> > >> default: > >> if ( type & RAM_TYPE_RESERVED ) > >> { > >> if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved ) > >> - return false; > >> + perms = 0; > >> } > >> - else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn ) > >> - return false; > >> + else if ( is_hvm_domain(d) ) > >> + return 0; > >> + else if ( !iommu_hwdom_inclusive || pfn > max_pfn ) > >> + perms = 0; > >> } > >> > >> /* Check that it doesn't overlap with the Interrupt Address Range. */ > >> if ( pfn >= 0xfee00 && pfn <= 0xfeeff ) > >> - return false; > >> + return 0; > >> /* ... or the IO-APIC */ > >> - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ ) > >> - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >> - return false; > >> + if ( has_vioapic(d) ) > >> + { > >> + for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ ) > >> + if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) ) > >> + return 0; > >> + } > >> + else if ( is_pv_domain(d) ) > >> + { > >> + /* > >> + * Be consistent with CPU mappings: Dom0 is permitted to establish r/o > >> + * ones there (also for e.g. HPET in certain cases), so it should also > >> + * have such established for IOMMUs. > >> + */ > >> + if ( iomem_access_permitted(d, pfn, pfn) && > >> + rangeset_contains_singleton(mmio_ro_ranges, pfn) ) > >> + perms = IOMMUF_readable; > >> + } > >> /* > >> * ... or the PCIe MCFG regions. > > With this comment (which I leave alone) ... > > >> * TODO: runtime added MMCFG regions are not checked to make sure they > >> * don't overlap with already mapped regions, thus preventing trapping. > >> */ > >> if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) ) > >> - return false; > >> + return 0; > >> + else if ( is_pv_domain(d) ) > >> + { > >> + /* > >> + * Don't extend consistency with CPU mappings to PCI MMCFG regions. > >> + * These shouldn't be accessed via DMA by devices. > > > > Could you expand the comment a bit to explicitly mention the reason > > why MMCFG regions shouldn't be accessible from device DMA operations? > > ... it's hard to tell what I should write here. I'd expect extended > reasoning to go there (if anywhere). I'd be okay adjusting the earlier > comment, if only I knew what to write. "We don't want them to be > accessed that way" seems a little blunt. I could say "Devices have > other means to access PCI config space", but this not being said there > I took as being implied. But we could likely say the same about IO-APIC or HPET MMIO regions. I don't think we expect them to be accessed by devices, yet we provide them for coherency with CPU side mappings in the PV case. > Or else what was the reason to exclude these > for PVH Dom0? The reason for PVH is because the config space is (partially) emulated for the hardware domain, so we don't allow untrapped access by the CPU either. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 16:17:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 16:17:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339878.564788 (Exim 4.92) (envelope-from ) id 1nw4Ye-00016k-AE; Tue, 31 May 2022 16:17:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339878.564788; Tue, 31 May 2022 16:17:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Ye-00016d-7V; Tue, 31 May 2022 16:17:24 +0000 Received: by outflank-mailman (input) for mailman id 339878; Tue, 31 May 2022 16:17:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4Yd-0000Ue-93 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 16:17:23 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 258afb33-e0fd-11ec-837f-e5687231ffcc; Tue, 31 May 2022 18:17:21 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 16540138379315.054051441504043; Tue, 31 May 2022 09:17:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 258afb33-e0fd-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654013839; cv=none; d=zohomail.com; s=zohoarc; b=Lp0cZBacg2y9/sc5/afICGrKtarrhdLwoXwFUumbt4zSohnuao5/VCAvRuma2znsk7czKXBawFUlSj5iqGMaM75iKyf4T8MQYMpLAKQ+CDOIa13RwWu79cTRJoHl65bFpxY7VHYjDq3008iipKopNm4OMnATBNXT5VyMgOwo79c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654013839; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=vrGrsXsKMeGJYOjt6Ch9wm5kkhtaTzHolvvolDcSGk4=; b=XTUmsg2kUotzjzg7Taxy/iBPuh7cDhCLzIskHJtJ34GtndYAeOGolxcQ8vO9kFwKgRW24rGv+NSrXUzFuhBcGzwyt6x1bfOla42QDJIXvzDYaE2IU7S6z/9zwf5TXDcivjZ2UswCIwe9M/vVR1u62+dTO0rkQpiSc7wjtRA9SfM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654013839; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=vrGrsXsKMeGJYOjt6Ch9wm5kkhtaTzHolvvolDcSGk4=; b=jGc7OKLbf9oS2/4oMunYLbM7svks/dpo2QflI4sGAQVWhWzsXXUfN/z2VT7EJqT2 TxRzghO4DV0g+/t08p4oLwGdYBMUTgeH+3LUkgMwJjTyLgXY/773MH8viwxs35GF00S xKXc63gN+/s4Xbv4EfxM9uVha+3U5wAEokQW8bOE= Message-ID: <604e79d6-d07f-1a28-83a0-55fede499e12@apertussolutions.com> Date: Tue, 31 May 2022 12:15:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/3] xsm: only search for a policy file when needed Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220531150857.19727-1-dpsmith@apertussolutions.com> <20220531150857.19727-2-dpsmith@apertussolutions.com> <1358771f-32ae-8a6b-9894-980014d7112c@suse.com> From: "Daniel P. Smith" In-Reply-To: <1358771f-32ae-8a6b-9894-980014d7112c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 11:51, Jan Beulich wrote: > On 31.05.2022 17:08, Daniel P. Smith wrote: >> It is possible to select a few different build configurations that results in >> the unnecessary walking of the boot module list looking for a policy module. >> This specifically occurs when the flask policy is enabled but either the dummy >> or the SILO policy is selected as the enforcing policy. This is not ideal for >> configurations like hyperlaunch and dom0less when there could be a number of >> modules to be walked or doing an unnecessary device tree lookup. >> >> This patch introduces the policy_file_required flag for tracking when an XSM >> policy module requires a policy file. Only when the policy_file_required flag >> is set to true, will XSM search the boot modules for a policy file. >> >> Signed-off-by: Daniel P. Smith > > Looks technically okay, so > Reviewed-by: Jan Beulich > but couldn't you ... > >> @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( >> >> printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); >> >> - if ( XSM_MAGIC ) >> + if ( policy_file_required && XSM_MAGIC ) >> { >> ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, >> &policy_size); >> @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) >> >> printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); >> >> - if ( XSM_MAGIC ) >> + if ( policy_file_required && XSM_MAGIC ) >> { >> ret = xsm_dt_policy_init(&policy_buffer, &policy_size); >> if ( ret ) > > ... drop the two "&& XSM_MAGIC" here at this time? Afaict policy_file_required > cannot be true when XSM_MAGIC is zero. I was on the fence about this, as it should be rendered as redundant as you point out. I am good with dropping on next spin. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue May 31 16:26:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 16:26:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339888.564800 (Exim 4.92) (envelope-from ) id 1nw4h0-0002j5-6g; Tue, 31 May 2022 16:26:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339888.564800; Tue, 31 May 2022 16:26:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4h0-0002iy-2c; Tue, 31 May 2022 16:26:02 +0000 Received: by outflank-mailman (input) for mailman id 339888; Tue, 31 May 2022 16:26:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw4gy-0002is-J4 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 16:26:00 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59829579-e0fe-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 18:25:58 +0200 (CEST) Received: from mail-dm6nam08lp2049.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 12:25:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN6PR03MB2498.namprd03.prod.outlook.com (2603:10b6:404:15::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 16:25:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::5df3:95ce:4dfd:134e%4]) with mapi id 15.20.5293.019; Tue, 31 May 2022 16:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59829579-e0fe-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654014358; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=8Xo1VWN3y0gketalO3c/EWQZ16/ncwxFjsYGosKpl4o=; b=bbFP7mtXPKkbk6UYrxHc6KszhTSqRrdbAM7g/azfbCGRXxG1TKwU0/dL +aAxDm0JX2G4LJN8N0wDKRua84KztIDHZUwjubhJqJlJBBKVmRHG7xysm X8xdb1LpcSTZAyInr3j5osYFS3knZq/KxiqYFw1zDvG6eatg6yZlGNaWA U=; X-IronPort-RemoteIP: 104.47.73.49 X-IronPort-MID: 72537546 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zFmOga7QtKAWKnaPHMpCrAxRtE/GchMFZxGqfqrLsTDasY5as4F+v jFOUWGBaPaCYmXwe4p/PIux8RtVu5PUmINlSwBt+CA3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXiWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSxbFwCYKH1hd1edDB8DxAiYpFEofjYdC3XXcy7lyUqclPK6tA2UAQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfqRo4MJtNszrpkm8fL2f c0WZCApdB3dSxZOJk0WGNQ1m+LAanzXLGcF8w3I+fRfD277nCtx9aryOtXuPcXRX8kSu32en EjI8DGsav0dHJnFodafyVqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL VQO/SgjprR081akJvHlVgC8iG6JuFgbQdU4LgEhwASEy66R7wPHAGEBFm5FcIZ+6J5wQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPTdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:zYBax6kbUjzWdYgFWpx/Z97oGhvpDfOwimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe ChD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp r525RT5c5zp/AtHNNA7cc6ML+K4z/2MGXx2Fz7GyWWKIg3f1TwlrXQ3JIZoMmXRb1g9upApH 2GaiISiVIP X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="72537546" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UywujExXW2Bu9/UdeXRRU0W8D0rrAeeqn6U+kJXRr+oeki4hITmUSDs4HKMcBYOPC299q8/v4YqyIS9M26whsibgGDf/5wIxrGrqE31a15+qdoqKT1743GihW/WFPGiz5sv7Olm/bSj0X5pKcSpfgLwytO9mPUdVVD+qfekR2hXOQ2WyXSe9lmPBB8Zn85bPi/bAY/+ncGfeE6UuzOCGkK1Adnk0vuK8mmJSNQj6vzEcms3FQRh4ypyTamuxE7fzpGraV9RYzrY5synsw1BaA6QcB8jHenN0MxiCZwVqmwpcGqNCRLtrhPqnT7/6xt3qcME9uiYOYvgFSyS35v9Jhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EVAW9MHPBvthcSE5X9oVg97dafPQVum65wpdyBvxjw8=; b=U0WIQMbI/Gs6EO98mpZlxCrMCRwXoxJV62+YTXtw4YzGtXwvzGuwvg/CR6I2Fto0VKxMP+ZWS1oomUurV8gAOQgjeZ6MrCj6VeDxUWLV9aQK+6v/NrAx1tPOC3JjAmRJSLkYrz2BQIa2giz18E6mkd6nBNVZlS4tncTo89KhvID4Y1Oo2/kYyxgspDtBKzfN9vPGuWiOjxrgBsY3PbUEoWefXNMLwNPmiIS8pVBKvwiOUltZgHfxR60AIWzPAa9elqEgGYYvC0ws6pSOcaWfeZSKzo7kwUaRO8jnhm2J9tNTgl+GEW3RPr+rI36WMthKhSz5TjOCDwu0lPWQLak/gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVAW9MHPBvthcSE5X9oVg97dafPQVum65wpdyBvxjw8=; b=mvi1wGZvniTOrSWqSBAzDYluHiTq+US0BOihpRaXOoXkCBDPkbg+FM1VCcrghnERSByfjpYBHaNG0Hx0dyWhLWvTPIyg6fr5X879qBPAhmhiZGpmy3g93YBGnKk61xcYktubggFS0GORugYFiVdO4gw0K7CK6QV9rsGThlO1wDM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Tue, 31 May 2022 18:25:49 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant Subject: Re: [PATCH v5 03/15] IOMMU/x86: support freeing of pagetables Message-ID: References: <80448822-bc1c-9f7d-ade5-fdf7c46421fe@suse.com> <614413d8-5043-f0e3-929b-f161fa89bb35@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <614413d8-5043-f0e3-929b-f161fa89bb35@suse.com> X-ClientProxiedBy: LO2P265CA0168.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 497d8be2-e013-4034-0dd7-08da43223ba6 X-MS-TrafficTypeDiagnostic: BN6PR03MB2498:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JXd1p3nNlK1Hrd164soth1c1hWBxryACsxNmT3/MSdeVn3T9A/po5/1RQQrT4ATfzPBcIyVXFbqyL4An4aeR9G46C0LrWEIrb+gcMYUCe+5MLBr3V4S4v4srMVqtei60JOWcwdYnUYQgAlP7dGikVam92iZ3orjBcLwl0qvAu7ElsuvzqsMP4xWUFQiAED0WruroQP0EallGeNmfP/njo5TMeONSEq7x6hG/qo6hJupujPwfsmFNUZKlp5cDx+4r1FJ+ptRFy5WAUV1JdmduS+hIMV2XqAPYnBAlLjJ2Xs3GQyW1z9+2SULd8mkf4E9vZEldn7bk/T66YpzJVq07Ht7ignzQkgvl5rLweFaYi7w2IZyZeS1HIqzcyn+HN/v+ADevfNDAF5lDRg41Kh676XUuE6y3ZMZS29N68CEoC/NhaejsSLA4pC4oleJInuFSW/yBaF9K0VfDdqenYLIIzHEQx/9uZxm/oYiH58xxBP9HhCcr98YztDJMES4W5isibdcGiXRmOcp1vm2RUmuaGULPl6ko0+wEWziqCrasqPvjVAr17Nm0g+IUPxfFgI2POr+hIC7rvfwWiyC2ZYSN9M6jP8eoWJuzBL+Gjikf3HTKDHt53+e4VXK+NAan1gr6PDtQmGzDPWD+gIsXo4Y6k57EwJAW/f6j/YuiIopQJFx9yQdCQ+sdNkMWJf4E7Jf9LKU1HgFsBiiLKgED+1yOu0aNxWoVu3fg8he/ZtVT20U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(7916004)(366004)(54906003)(9686003)(316002)(2906002)(33716001)(26005)(6506007)(6512007)(6916009)(83380400001)(85182001)(82960400001)(8936002)(4326008)(66946007)(5660300002)(38100700002)(86362001)(66556008)(8676002)(66476007)(508600001)(6486002)(186003)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGJNZ2VXQzBsNFBlaUJiNUM2WE1sb29NSHdQNjVOQjJYZmhuQnFWQTVFS1JG?= =?utf-8?B?dER3bWtKSG9FQ3F3OFJTazNSc2xhL01OYWt1NEVzanB6NHpoa0tuamxMaGhV?= =?utf-8?B?SDRTblBlOE1qcUNmRldjdUFQTHZURUtyRjVDdFBnUmREeklDcGxteXZxbXZR?= =?utf-8?B?bW1EdS9rbU1vMEFOTkJ2NW9nZHJ1WlprQWpYT3BFMzJ3YzYwRER2NU1JOTVw?= =?utf-8?B?YTZ2ODh2QXVDRjdkS09IS3JaditUMkt6RXdxU3l3UDZWK2Q5L2lhM0JvcUdr?= =?utf-8?B?c2FPK3ZiTlY3aWNRQ2t5YStKS0ZaR09IRm5zN1BGVlV6N0pGOUEvU01TSkR6?= =?utf-8?B?YlIxV0ZiMC9lMWYxeDFxOCttQ3VCZ2RDdmxoSTlHcDVTazRtU1NaNGNCMmgz?= =?utf-8?B?YVdBdTFIaWxzUWIzSzE2YWVvQklJNzVBYk9sOTU5cEpXOVFBQ0ZEam1WOEJh?= =?utf-8?B?RTJHL0dSek0vYW12dGl4WmlweitSVHhUSGZvTWFxSUt1NXJuL1k2Q0VFVDFC?= =?utf-8?B?dG94WklSYWYwWURwUW9wdWM3QnpyazF5WHg1SkVwbk1VQ1NPVXd1cGpiT29R?= =?utf-8?B?VkMxVFZrT3RiVGdMYkNvL0xxN1JjSEQxbGlBc1crYkQ0dG5CY2tWUllqV2Ix?= =?utf-8?B?ckNONDl4cXJ4ZWYxVkxaL1MrNGcyODBidTJlNDZjNGlFQ1AzNVc4bnR4RCtD?= =?utf-8?B?M0ZsbVcwQVhPNFNDbGxiTWpwRVl2Smt0c1NVQlhrYlVKOVRuTURLY0lWdjZK?= =?utf-8?B?YTBIZmZORlFHYTRBa0kyb29lRHdITHp5TXVFT1dHaHVKY2FnUk9qTTlSN1c4?= =?utf-8?B?Zng0NDEyV091Uks2RG5LVXBDLzE5Y3NnKzlEWHI3ZTVNSUNOazZ5WXNPYVlw?= =?utf-8?B?bWFsUWZKRG1yNTZtekJmellKZDlacjVKZ2xEZFlSbkZSUUY0eHdJZis4MjJh?= =?utf-8?B?MWZRU1RDY0dRMXlNS2ZrT0tjWUxwdk91YWV2NW9oZEozS2pMWDBLa1N4VkRD?= =?utf-8?B?dlFxVEtibVNMU2prSlJyMU1yQXFQU1JCYVpWaEpGSGVkazI1S25aa1VSLzRC?= =?utf-8?B?dUMyWnJyK3Q3SjE3dGVBeG8zS1BPWk1xR2NLODd2TDUzaWM3TWloTEhMN1F6?= =?utf-8?B?eHdNQlhMTG9NMW5NUmNMTzU1Um42QUdwVzhoWG1aQzNJNEVVS2prYVh6dXNT?= =?utf-8?B?UnM2QWsweFRrUWNFYjNMQnJJaGNSclFyREVSQlB4R1IvSjRIZHVnZTVGL0Fi?= =?utf-8?B?dWRTWElCKzFDS253MjBiWlFBczJCN3h3R3hHcEVRN1Zta1I5S05RR0dKVkFO?= =?utf-8?B?NWxuaVRFRDZrTzBlQ1pNVnF3bC9xeENkNWt6VzEyWG1sNjhsemxQR29LaWFF?= =?utf-8?B?SmhXMkdTZEc2N2lFYS9NTW9LVHI0VlBnYTBUamZQdEM0TUlhVnJKQUdEcEVW?= =?utf-8?B?cTVXWTllMHVPNkpXU1hPRDdrWFlPaEl3MmtXdkwrOU8yQ1YyS2dEQTc4MzEx?= =?utf-8?B?a3pNT1ZLRDhyWlpVcWJOUUpOUlV5clRCcE1OK3dGTWxLNTN6TWxtUmlaUXRi?= =?utf-8?B?eTFqZlJjUDE3YkJjMWJicStlOGNKWWxSckZuZHA5aTRqRFpESkN5d1BjSjhw?= =?utf-8?B?bVpxdFVUU251RUFFemtaODdDUUt6eFE5bmM0Q3o5Yi9XKzVidnR2WjRXYzR5?= =?utf-8?B?ZnZhUGFhSzVwTmJBUmtSckFNc0tON1ZSYnE5Nzh6UDZJdHk5NzdEZHhMRktl?= =?utf-8?B?KzZlWFQ3dnFmL3BLU3FrcjFDM0xHME9uQWkreTg3VHAxL3FpQVI2ajNueDY2?= =?utf-8?B?WENpZ2NUQnpBd2xSWGpQZTlUdzFybENhYzVlRUd5di93MU9DZUVWNlpMazJ5?= =?utf-8?B?L1d3Q1pMSWYreDZtTHRCbDBuNHlmMGJ3clg5RkxjQ000Wm9mV3dNVFIxckFz?= =?utf-8?B?a1dYNzFSVklhYlNWTGhMUDJkMkUwWThoVEUxSlZTQUp1Qm9vazQ3ZDF4eWl3?= =?utf-8?B?eThuODRqMUxON09JU2gyM1lRc0JDQVlOeE9LTGtxa3c5dEhuQmtBV1g0YUU1?= =?utf-8?B?YmpMdWxaZmVPSHZDa0ZZMVZRU1duQkcyMk9OS0ZkUlNmSUlNMjN2WUlnOXJi?= =?utf-8?B?UkY1TmwyUk9uc3ZTS1AzVlh6b3o4Y3hOaVE3ZnhsdHJiL040VWxWQjVXRmdQ?= =?utf-8?B?VGpSTXl1eVBiZ3FiUGc1cFBjUUdLWHU2VDBHU1BlU0hGWFdnM2luRkx2K1VN?= =?utf-8?B?MWF5OHVvUXhmNFcrSjlyOC9qZG82MEpOWk5PZkVXNGZVblp4UGRFdW4wVEhF?= =?utf-8?B?VWkzLzlKQll5RDcxejV6WnpNbW9nWHhlalhsZjIxYnBrWUlKcHBOZzhRN1Ax?= =?utf-8?Q?YYydc6S6+jnJc+Jw=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 497d8be2-e013-4034-0dd7-08da43223ba6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 16:25:53.7377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rFobUGDRhk3IXilUaC0Xp1NQ05/I0VYANZjYvdXvwi+b9lMaqLFrDrG1oPHXZfOC4xyKlBRhdtXfeKmNikr4zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2498 On Fri, May 27, 2022 at 01:13:09PM +0200, Jan Beulich wrote: > For vendor specific code to support superpages we need to be able to > deal with a superpage mapping replacing an intermediate page table (or > hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > needed to free individual page tables while a domain is still alive. > Since the freeing needs to be deferred until after a suitable IOTLB > flush was performed, released page tables get queued for processing by a > tasklet. > > Signed-off-by: Jan Beulich > --- > I was considering whether to use a softirq-tasklet instead. This would > have the benefit of avoiding extra scheduling operations, but come with > the risk of the freeing happening prematurely because of a > process_pending_softirqs() somewhere. > --- > v5: Fix CPU_UP_PREPARE for BIGMEM. Schedule tasklet in CPU_DOWN_FAILED > when list is not empty. Skip all processing in CPU_DEAD when list is > empty. > v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base. > v3: Call process_pending_softirqs() from free_queued_pgtables(). > > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns > int __must_check iommu_free_pgtables(struct domain *d); > struct domain_iommu; > struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); > +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); > > #endif /* !__ARCH_X86_IOMMU_H__ */ > /* > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -12,6 +12,7 @@ > * this program; If not, see . > */ > > +#include > #include > #include > #include > @@ -566,6 +567,98 @@ struct page_info *iommu_alloc_pgtable(st > return pg; > } > > +/* > + * Intermediate page tables which get replaced by large pages may only be > + * freed after a suitable IOTLB flush. Hence such pages get queued on a > + * per-CPU list, with a per-CPU tasklet processing the list on the assumption > + * that the necessary IOTLB flush will have occurred by the time tasklets get > + * to run. (List and tasklet being per-CPU has the benefit of accesses not > + * requiring any locking.) > + */ > +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); > +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); > + > +static void free_queued_pgtables(void *arg) > +{ > + struct page_list_head *list = arg; > + struct page_info *pg; > + unsigned int done = 0; > + > + while ( (pg = page_list_remove_head(list)) ) > + { > + free_domheap_page(pg); > + > + /* Granularity of checking somewhat arbitrary. */ > + if ( !(++done & 0x1ff) ) > + process_pending_softirqs(); Hm, I'm wondering whether we really want to process pending softirqs here. Such processing will prevent the watchdog from triggering, which we likely want in production builds. OTOH in debug builds we should make sure that free_queued_pgtables() doesn't take longer than a watchdog window, or else it's likely to cause issues to guests scheduled on this same pCPU (and calling process_pending_softirqs() will just mask it). Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Tue May 31 17:03:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 17:03:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339898.564811 (Exim 4.92) (envelope-from ) id 1nw5HU-0007Nb-3U; Tue, 31 May 2022 17:03:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339898.564811; Tue, 31 May 2022 17:03:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5HT-0007NU-Vn; Tue, 31 May 2022 17:03:43 +0000 Received: by outflank-mailman (input) for mailman id 339898; Tue, 31 May 2022 17:03:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5HS-0007NO-3P for xen-devel@lists.xenproject.org; Tue, 31 May 2022 17:03:42 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9dc21c47-e103-11ec-837f-e5687231ffcc; Tue, 31 May 2022 19:03:40 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654016615660296.8406884390141; Tue, 31 May 2022 10:03:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dc21c47-e103-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654016617; cv=none; d=zohomail.com; s=zohoarc; b=aYv0es7mKYVjwZB2c485H9L/8xXYP5xBh8Q9P1pEtHHhx0gDHGpwckKA2B8OpjdzMHSRmlV6d9W1KOd+fB2bBLspxrw20Sw7mOIveO579dTQUBWOwtfynqIQ05DvNov9MX/jv3sdIjsbH3cftlms0/R1jTADhnjvYrpVQGZ+OBU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654016617; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tcGpwATKnB8tjbSMB7ke1FkWwTgORrNPTiS1SBigrjo=; b=T1u+IDvK6IDvzrkb05shI7LY9OqUMQBr2Hd0H8bd+YA+DTlssrshO4rTndE/hpKDNUU3mEh8FzAfq2DCLnvRqKgeSo+2L9FZXDvF7P54kkWd+9Mkuv70eUGbz0iCRJp4E9ml9xdGX1zFDGPBtqWfoTKtDI/P+xkUDv8L5rozMC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654016617; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=tcGpwATKnB8tjbSMB7ke1FkWwTgORrNPTiS1SBigrjo=; b=PbnHfDTQV5e/tYQkbXEZNEndIVE5LTw6meRYgpKeWD0a6FdsLnZv9R/j3OuOHEm3 E25dM9cm6zqI/k77+0A5xc1Uu2Mlc40RoRVR2iku0xRfo813cC3VpVoUtNtFrjOoBwB M1opRPmA4WwNtMJWbDgT30BPltWWLc/VXrMyPDKU= Message-ID: <0c9a0874-6afb-0ac0-fc6d-26d14081efe3@apertussolutions.com> Date: Tue, 31 May 2022 13:02:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf , xen-devel@lists.xenproject.org References: <20220531150857.19727-1-dpsmith@apertussolutions.com> <20220531150857.19727-3-dpsmith@apertussolutions.com> <53a64002-5369-26b9-cd30-119983518cc6@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v3 2/3] xsm: consolidate loading the policy buffer In-Reply-To: <53a64002-5369-26b9-cd30-119983518cc6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 12:05, Jan Beulich wrote: > On 31.05.2022 17:08, Daniel P. Smith wrote: >> Previously, initializing the policy buffer was split between two functions, >> xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading >> the policy from boot modules and the former for falling back to built-in policy. >> >> This patch moves all policy buffer initialization logic under the >> xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error >> message is printed for every error condition that may occur in the functions. >> With all policy buffer init contained and only called when the policy buffer >> must be populated, the respective xsm_{mb,dt}_init() functions will panic if an >> error occurs attempting to populate the policy buffer. > > "flask=late" is also a mode where, afaict, no policy is required. I can't, > however, see how you're taking care of that (but maybe I'm overlooking > something); inspecting flask_bootparam in generic XSM code would actually > be a layering violation. Good point, flask=late is meant to be enforcing with a late loading of a policy file. I will address it. >> --- a/xen/include/xsm/xsm.h >> +++ b/xen/include/xsm/xsm.h >> @@ -775,7 +775,7 @@ int xsm_multiboot_init( >> unsigned long *module_map, const multiboot_info_t *mbi); >> int xsm_multiboot_policy_init( >> unsigned long *module_map, const multiboot_info_t *mbi, >> - void **policy_buffer, size_t *policy_size); >> + const unsigned char *policy_buffer[], size_t *policy_size); > > I don't think we're dealing with an array here, so const unsigned char ** > would seem the more correct representation to me. > > Also - what about the DT counterpart function? Ack. v/r dps From xen-devel-bounces@lists.xenproject.org Tue May 31 17:09:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 17:09:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339907.564822 (Exim 4.92) (envelope-from ) id 1nw5My-00081a-Qr; Tue, 31 May 2022 17:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339907.564822; Tue, 31 May 2022 17:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5My-00081T-Ly; Tue, 31 May 2022 17:09:24 +0000 Received: by outflank-mailman (input) for mailman id 339907; Tue, 31 May 2022 17:09:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5Mx-00081N-Dn for xen-devel@lists.xenproject.org; Tue, 31 May 2022 17:09:23 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a59f916-e104-11ec-837f-e5687231ffcc; Tue, 31 May 2022 19:09:22 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id c19so22500664lfv.5 for ; Tue, 31 May 2022 10:09:22 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id i6-20020a196d06000000b00477cab33759sm3072432lfc.256.2022.05.31.10.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 10:09:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a59f916-e104-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=oXC+omMyhQE+yQOLbS6KJe5K78bZY03LjtAozxlOWS4=; b=TAyjZkyHiTXmbmHCSrE2qWJwfpy2mK18RqayHB9KPwF3D5Pg+bZ6eGYNeN34jbspjz XKAIAKaqLBFgTkjxxqEqqjzKoQ4toUSB64OhXxsfMMRXeKBxTuUTXvyIQGUiGfioo7kC oMkYvmT4C0UXva0czCxfN3JpmbeZVhWBsYi1qGOpj0WhxatmjVmbr0Qp0zNQmGicVbqD XOkcjG3W1KKt5f0akOma0UDAHja0EIq/KJOrVyQ2kluOg8ugvRzH57Wsp2EqTBQKNt5m 4tqMtwtv+jysyfjiBaAa2EYLry0bXPvGexMdU0w2FewQWJm/hZYWq2QWm7FRLYNLGMi4 npkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=oXC+omMyhQE+yQOLbS6KJe5K78bZY03LjtAozxlOWS4=; b=KOoCajg+vB3ofPie6lungNNm3VDC4Prd30ebICI1FIDksJeYXRQY93FyFkbN5Fb35q PzmGQtilF5mD8EPUpxY7BxAjFKzhgsOBnEzbxVm6y5fyxe3GoIEJ5/2JA9qHsVBQaUN3 L6BeW4luJXTuJ5BRFX3CM7Wkh6uUjZnR5B/u+3gjMxmKJQr8l7sblBOZdme8TWHcdunh iO9v3Dmc2LURoO41cfB5B4WZVuJg6om6Tathg9l0A9FxB1VB3JfKBLhB0McRZg3YuWN2 a5C28TvSyJJEL23kNFq7kH7lPVoDNzNrSBmfAoYNl/wnuPKPuiy4OBGCSyp0V/Y4uXJp +ENg== X-Gm-Message-State: AOAM533j4FkxSx4vdha5MqQRXhpnoF+adDs03ERut4cHD/MXX2iHGgm4 bnl8wb9+FgwLijEDPln5Aqk= X-Google-Smtp-Source: ABdhPJwx9hqwCt9lTBlhLuxF3159ZiuKQMGeaQRRGSerHfQCM1lHwBJOFfe0u0PJDGwPNceRQMYbag== X-Received: by 2002:ac2:4f09:0:b0:478:6c80:64fc with SMTP id k9-20020ac24f09000000b004786c8064fcmr26696653lfr.34.1654016961692; Tue, 31 May 2022 10:09:21 -0700 (PDT) Subject: Re: [PATCH V3 5/8] dt-bindings: Add xen,grant-dma IOMMU description for xen-grant DMA ops To: Krzysztof Kozlowski , xen-devel@lists.xenproject.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , Rob Herring , Joerg Roedel , Will Deacon , Krzysztof Kozlowski , Julien Grall , Juergen Gross , Stefano Stabellini , "Michael S. Tsirkin" , Christoph Hellwig , Arnd Bergmann References: <1653944417-17168-1-git-send-email-olekstysh@gmail.com> <1653944417-17168-6-git-send-email-olekstysh@gmail.com> <15eef004-74c7-0eb5-3f87-86e164ef70ff@linaro.org> From: Oleksandr Message-ID: Date: Tue, 31 May 2022 20:09:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <15eef004-74c7-0eb5-3f87-86e164ef70ff@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 31.05.22 14:52, Krzysztof Kozlowski wrote: Hello Krzysztof > On 30/05/2022 23:00, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko > Thank you for your patch. There is something to discuss/improve. > >> diff --git a/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml >> new file mode 100644 >> index 00000000..ab5765c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml >> @@ -0,0 +1,49 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iommu/xen,grant-dma.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific IOMMU for virtualized devices (e.g. virtio) >> + >> +maintainers: >> + - Stefano Stabellini >> + >> +description: >> + The reference to Xen specific IOMMU node using "iommus" property indicates >> + that Xen grant mappings need to be enabled for the device, and it specifies >> + the ID of the domain where the corresponding backend resides. >> + The binding is required to restrict memory access using Xen grant mappings. >> + >> +properties: >> + compatible: >> + const: xen,grant-dma >> + >> + '#iommu-cells': >> + const: 1 >> + description: >> + Xen specific IOMMU is multiple-master IOMMU device. >> + The single cell describes the domid (domain ID) of the domain where >> + the backend is running. >> + >> +required: >> + - compatible >> + - "#iommu-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + xen_iommu { > No underscores in node names, generic node names, so this looks like > "iommu". ok, will change > >> + compatible = "xen,grant-dma"; >> + #iommu-cells = <1>; >> + }; >> + >> + virtio@3000 { >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The backend is located in Xen domain with ID 1 */ >> + iommus = <&xen_iommu 1>; > There is no need usually to give consumer examples in provider binding. > If there is nothing specific here (looks exactly like every IOMMU > consumer in Linux kernel), drop the consumer. I got it.  There is nothing specific from the device tree's perspective, I was thinking to draw attention to the IOMMU specifier (in our case, the master device's ID == backend's domain ID). But  '#iommu-cells' description above already clarifies that. Will drop. > >> + }; > > Best regards, > Krzysztof -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue May 31 17:22:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 17:22:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339917.564832 (Exim 4.92) (envelope-from ) id 1nw5ZL-0002Cr-2I; Tue, 31 May 2022 17:22:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339917.564832; Tue, 31 May 2022 17:22:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5ZK-0002Ck-Vm; Tue, 31 May 2022 17:22:10 +0000 Received: by outflank-mailman (input) for mailman id 339917; Tue, 31 May 2022 17:22:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5ZJ-0002Ce-V0 for xen-devel@lists.xenproject.org; Tue, 31 May 2022 17:22:10 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 310e22a6-e106-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 19:22:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 310e22a6-e106-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654017727; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Qhk2n5usJqKedYq7mN0FzsbpOhYj3dAcM2lzVNe5OVI=; b=EK27l0aHO1fTSjzGV4htEt1CbtfmQ9qX8DTCU9Gs33EoRWZzeCvUwBLG te2WabR8936II2xXukxYfRYR611WKIYdNjJjp1MlraPLXCBIh2iVwofWV q1uk5UH37wU/gpgNpfr7HdyrH0ZtvrBzuxA39nNgQqgVXwkGtUnoHqBpT A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75082381 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:k9v3Xq5EzfTBPXnDjPVbCAxRtFDHchMFZxGqfqrLsTDasY5as4F+v moXUTzUbPffNGf3Kd9zaIu+8EgP6pSAyNFrGQJr/no8Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXiWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurT3UFcDB6Pmht8ydB5ZEHpXPrBg2LLudC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT 5VEMWo1N0SZC/FJEntJKIogu9mLvXTcLSFqlV2Yq4RuumeGmWSd15CyaYGIK7RmX/59gUKwt m/AuWPjDXkyNtOFziGe2mmxneKJliT+MKoQHbu07O93g3Wcw2USDFsdUl7Tiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXYht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIO89ZmbwUk/ EGysPTuBD80mb6Ib1KQ3+LBxd+tAhT5PVPudAddE1ZevYC+/d9j5v7cZo09SfDo17UZDRm1m mnX93Zm2t3/mOZRj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX 1BewqByFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9INsBu2wgehkyapdsldrVj Kj74Fg52XOuFCHyMf8fj3yZV6zGMpQM5fy6D6uJP7Kik7B6dROd/TEGWKJj9zmFraTYqolmY c3zWZ/1VR4yUP07pBLrFrx1+eJ6mUgDKZb7GMmTI+KPiuLOOhZ4iN4tbTOzUwzOxPrc/V+Iq o0FapfiJtc2eLSWXxQ7OLU7dTgiRUXXz7iv9qS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:6sxuJ6kgTpb1UlkeJFLjSOHQXqTpDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A== X-IronPort-AV: E=Sophos;i="5.91,265,1647316800"; d="scan'208";a="75082381" Date: Tue, 31 May 2022 18:21:37 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , Juergen Gross Subject: Re: [PATCH] libxl: Don't leak self pipes Message-ID: References: <20220524163152.19948-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220524163152.19948-1-jandryuk@gmail.com> On Tue, May 24, 2022 at 12:31:52PM -0400, Jason Andryuk wrote: > libxl is leaking self pipes to child processes. These can be seen when > running with env var _LIBXL_DEBUG_EXEC_FDS=1: > > libxl: debug: libxl_aoutils.c:593:libxl__async_exec_start: forking to execute: /etc/xen/scripts/vif-bridge online > [Detaching after fork from child process 5099] > libxl: execing /etc/xen/scripts/vif-bridge: fd 4 is open to pipe:[46805] with flags 0 > libxl: execing /etc/xen/scripts/vif-bridge: fd 13 is open to pipe:[46807] with flags 0 > libxl: execing /etc/xen/scripts/vif-bridge: fd 14 is open to pipe:[46807] with flags 0 > libxl: execing /etc/xen/scripts/vif-bridge: fd 19 is open to pipe:[48570] with flags 0 > libxl: execing /etc/xen/scripts/vif-bridge: fd 20 is open to pipe:[48570] with flags 0 > > (fd 3 is also open, but the check only starts at 4 for some reason.) > > For xl, this is the poller created by libxl_ctx_alloc, the poller > created by do_domain_create -> libxl__ao_create, and the self pipe for > libxl__sigchld_needed. Set CLOEXEC on the FDs so they are not leaked > into children. > > Signed-off-by: Jason Andryuk > --- > Maybe the setting wants to move into libxl__pipe_nonblock()? Poller & > sigchld are the only callers of that function. No because we could want a pipe which survive fork/exec. The function would need to be renamed. I think it's fine to set cloexec on the spot. > --- > diff --git a/tools/libs/light/libxl_event.c b/tools/libs/light/libxl_event.c > index c8bcd13960..8d24613921 100644 > --- a/tools/libs/light/libxl_event.c > +++ b/tools/libs/light/libxl_event.c > @@ -1800,6 +1800,9 @@ int libxl__poller_init(libxl__gc *gc, libxl__poller *p) > rc = libxl__pipe_nonblock(CTX, p->wakeup_pipe); > if (rc) goto out; > > + libxl_fd_set_cloexec(CTX, p->wakeup_pipe[0], 1); > + libxl_fd_set_cloexec(CTX, p->wakeup_pipe[1], 1); I think that's ok. I tried to find out if pollers needs to survive a fork/exec, but that doesn't seems to be the case. Pollers are only used by libxl's event machinery, and in a single CTX I think. > diff --git a/tools/libs/light/libxl_fork.c b/tools/libs/light/libxl_fork.c > index 676a14bb28..b13659d231 100644 > --- a/tools/libs/light/libxl_fork.c > +++ b/tools/libs/light/libxl_fork.c > @@ -387,6 +387,8 @@ int libxl__sigchld_needed(libxl__gc *gc) /* non-reentrant, idempotent */ > if (CTX->sigchld_selfpipe[0] < 0) { > rc = libxl__pipe_nonblock(CTX, CTX->sigchld_selfpipe); > if (rc) goto out; > + libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[0], 1); > + libxl_fd_set_cloexec(CTX, CTX->sigchld_selfpipe[1], 1); These ones should be also ok, as the pipe is only used for the SIGCHLD handler so not shared outside of libxl. So the patch looks good, and hopefully we don't break libvirt. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue May 31 17:28:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 17:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339927.564844 (Exim 4.92) (envelope-from ) id 1nw5fR-0002uM-Qu; Tue, 31 May 2022 17:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339927.564844; Tue, 31 May 2022 17:28:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5fR-0002uF-Nt; Tue, 31 May 2022 17:28:29 +0000 Received: by outflank-mailman (input) for mailman id 339927; Tue, 31 May 2022 17:28:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw5fP-0002u5-5J for xen-devel@lists.xenproject.org; Tue, 31 May 2022 17:28:27 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12b4b6f0-e107-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 19:28:25 +0200 (CEST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VHHIkh011768; Tue, 31 May 2022 17:27:49 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gbcaunubu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 May 2022 17:27:49 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 24VHFb1r014571; Tue, 31 May 2022 17:27:48 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gc8kf7yxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 May 2022 17:27:47 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CY4PR10MB1846.namprd10.prod.outlook.com (2603:10b6:903:125::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.17; Tue, 31 May 2022 17:27:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::f961:32c1:44e0:6517]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::f961:32c1:44e0:6517%3]) with mapi id 15.20.5293.019; Tue, 31 May 2022 17:27:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12b4b6f0-e107-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=139RGQp/kOZy2vDpFFv/rH65u5e5cCcUG4ouCJbTr+M=; b=GATKNAnKAFJ0ZbEh5fxzNFOW5fsYoS7IlXsVNEyTUGOILlWITWAx8h0RzKPuuaBI9v49 PXZXl7lWcCTIqf4+oQ9ktf1GFA1Fl5tSyspm6zOY1boEl5RmtF4vLThYWCrXQmJEhL/5 rLKdqTUpebi+q+ebZDnsfNH50j8y4/SU94ZtSFtV7ODy4/J0FlFq8qkQCRUeYa3j2mft rnWjshT08N59pC3oOLe34pHKuRHMs48kvyYtmrClvxOrA8VW6dsy7blueSEG2D2Fok31 IXpxtm6eGvnDtnDDTGWhIZzxBgOj/E/noXMwqhMHDFOvhYp/2EEHmGmMX4YvM3ZCH/2a kA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOjjvf0MlL1HQOK6+rNbXDFVcq1FPfJwVMpcsFBsUPmcWLy4svFpAP+ZnLfsrV6PyxfjqwN9LMpx5RQGlNm75N6qVObmf2VnwoahuXYKOX3ABqe3Vi27z0p1DInN+rgBqh++eQqMyDiXYEfCYKkM4WpJ3LOso9id7EECq0ccOZ9sVCkOfi262mFHbg0gRNvJgBHp6AgbTqNX7UiEM8IiGdlgPkj5EAMfkk7/7nfOb8dikgi4+6Z2FTywyZEMoXE1YE2iFWM+8rHdBI0dpahXUBdXKF4V1lAd8fdetVhISMjRnCe3/EkEmMQloBnl/rHHR8sdLdgRBANeEQobuTzVEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=139RGQp/kOZy2vDpFFv/rH65u5e5cCcUG4ouCJbTr+M=; b=VYSkO0nAkOQTfu2OVKAI2q/yG57z56G0p8saUC6Mdpdwhk3sRI5uxdZB53ZvISzwxGNqNOg40jncH60l9fnQ0FnKpWxZqBEuCuW5ONkZ/zcrF0xwtrREQzRWYkDIIzcfiHJ1BdUXbcfmzAUH/5LZGtKd5YP86l1BzM3M7HjuO+6h3oqRyWxzVNSTyetwICCBDJY5Oam69f9StGs0jQlr9Zcz29JKSavdg3xDjIfPjY3TEjAGL9V/i01VpnMbvuFqWdEF73CTqZzioGy+hj00HHQCf7h0O/rJeolULLURelXh5LukxN4GDHW/J8hoKDEE/ywDeiZ1QyIDqUXPrip/eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=139RGQp/kOZy2vDpFFv/rH65u5e5cCcUG4ouCJbTr+M=; b=FAIzrevvBhjKTXJqiZjp7pVhPHhjurw6NAeDaOzba+z9e3m9NCtxjyWnew0LGCGEcjFfI4VhE5xTOw30fZRHxv3i4xrWmiIpPwCx9T9adWru0Mc7LlaSAWcqZ7ubaXALtW6n6GW3tkAFCWYtSRPykCwAwn4fguTchmLEiAfHfwI= Message-ID: <50fc0322-78b2-061a-46f1-dc13e4ec7184@oracle.com> Date: Tue, 31 May 2022 13:27:24 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen: replace xen_remap() with memremap() Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Greg Kroah-Hartman , Jiri Slaby , kernel test robot References: <20220530082634.6339-1-jgross@suse.com> From: Boris Ostrovsky In-Reply-To: <20220530082634.6339-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR13CA0159.namprd13.prod.outlook.com (2603:10b6:806:28::14) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6b0b92d-1547-4047-9ccb-08da432ae080 X-MS-TrafficTypeDiagnostic: CY4PR10MB1846:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eKblSy644DUa8GzhJUo9Md3DQFY/ehZ4ujwSIdc7+xP1elZ0WuBqax7HFt5THp/QxOh6lLIC2Nk64SYHJfpzZu0GCW7fYCZgy7zgKwfsTxOPfwte/G5CGKh8rzIfUId7eK8QjwuvGcFA5xLIjbUaWmRJDidgxkc3rR5+7ITPCzKJfCheIZBB3Y0/deSGdhsqikFW1uOClK8SUF34tXGwyWlRKRAYd95pk5abNZCw8u0zh8xG+6t2f6X45wNALEb7moiX6dIfGZVXBdQbdlKD85YpOl8PIuFXZ4vgHxw72Eqx31kvqdr/nXNDidGN6Jnxs2bZw9ygZvhFP8G0DHkSqD1AP+v1bUBeixj+1NDGTgRFCLKPqdux8o/9fE4dIddfkmaJstVR2HObfYWOciXPRdTEiDlShle0rNSNWA+UMXr+OuwzAkkMuO/X+XoxgtcDVQy+qDakeU2gxpD9AjyLklHttlZR2R141LL8enni9lZPzbdFPSHSKyCCou1tRg3YXCKnEfKaxH3qmGazqnFSwiQU4qwL5m+3JQG8qjra23Co5t+rzkeEa3NYB3iQJO5dQcC4n+eqbH7Hujw8kOWh0EYX369IbiPhRumKSc7q/KkxL5YDYlokLRGBZxDRCQIjii+njZ4awbQ5gXGYA4gWTHx1YoCsC2MhSo45FerqbVI/Ya++DxXHMsx3LSHSWqr8XGDxZOQVeDOFbAR6zYhoSJ4THsSrK3MrctYTDxmGK3Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(31686004)(2616005)(54906003)(36756003)(2906002)(316002)(26005)(6512007)(53546011)(186003)(5660300002)(31696002)(66946007)(6506007)(86362001)(8676002)(4326008)(66556008)(66476007)(6666004)(8936002)(508600001)(6486002)(7416002)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVViZDVXeGV2V0hnUTM1d1pua1Y1WWgyQXBnU2RCa2J6Y0dHY1F1Q3ZtUjN0?= =?utf-8?B?UC9uM2hiT0gxUmt4UHNCOWFJbjh5dDA5SUZ4MmJHQVg3amhHcVgzcTdjQ2p1?= =?utf-8?B?ZWV1OERORk8yS3M2ZE5NOEpWYW94Z3lIY1paTXJDK2RhalFNV3hHU2xETzNp?= =?utf-8?B?ekkrNDlNcnc5Vk1nTUM5VWhnRk1rT28zOVdCcFk1djlPYXZERUVYODE4OWxD?= =?utf-8?B?R3IybmJORHBHZFZZMjR2bmZkNXBnMkhnem5pTHhUVDdkbU5KMFJQRTBwR1Jm?= =?utf-8?B?ejVyc01tMXliWXhnUk93d1AvQm9RdEZoWlhEN0VHU2ZIK1MxajQxVzRDREMy?= =?utf-8?B?MTE2Q2hnZWErRkUzL09UTktNd1ZzK2wrclNvK2dnTWVmS3BmODJuSmVXSmQ3?= =?utf-8?B?N052dm1xTlBobVAwaFRpQVR3emdSeUNyaVEyaS9RYjdDODdzWGVua3lEWVNs?= =?utf-8?B?bHo4SmphNkZVdnVCRkhtNEQzYzBTSFNzam5uMWdzcHBRMEQzTkViVGcya3dH?= =?utf-8?B?ajYrMG9pbHRlZjI1bkk2bm13TkZES1F0a2hYbDdHdmFBSUh0b0kvdklta2NP?= =?utf-8?B?UEFSb0dZcFYvRFRRNFRjY25KZ1JRalpHeGN5VjZ6cTRob0o2cXVRVHcrNXFx?= =?utf-8?B?aUFIcnpGWWZkYXZ1amhnQWJFN1RwNzh5MGdUbVJlZjVqSGVjVjBDN1ZjeFJX?= =?utf-8?B?STdNeDExRmdWZUxWU2pWanlMMjd4dnRpZ1UycW9mNkEyMnZlRTgvNU83T1kw?= =?utf-8?B?endkaG4rb3lVQVl6blpXR09nQlcvbG9idDNqUElyZjRoSzQ3a2JZYkMyWkZ5?= =?utf-8?B?cU1oRXYxUm53Nnd2dHViRk1KaDVTZ0d1VElqbkF5anpLWW9oL3pYcDhERGk5?= =?utf-8?B?Z1RUUmR6RXY0Y1grWTdBOVVOeDc0bnl4eFgxSDBRUGdOTzBCSUpGT0kxN1cv?= =?utf-8?B?NWhxUmFIL0t2OGZBSmF5VFIrOWFDZmhzY3ZHZVVVT1RyWi8rdENCWFdQT1Zr?= =?utf-8?B?eHdlT0RVWDlxdzNNVk4wRG5HcGU5dkhjMVMrWTFScGFSUlZsc05SQzV2RkZL?= =?utf-8?B?VStNdGcrczlmenlFZVcwTXRDeXo0Z1p0UVp2THB0NThvWVFyS2IrZ1BFajE5?= =?utf-8?B?NkNBVldzaFpNeXJHNUkzNUx3dzhabEVwQml0ZFFHR2VTQXloRktOUDQvUmp5?= =?utf-8?B?Z3FnOC9qSjRjVzF5ck4yYThDKzBIWnMrZ09OaTIrYjZyd016bTRtVjhwU0d3?= =?utf-8?B?cTFHK2NnR1AvcTQveDgzTjFLZHdRVVhNNkE3TTRtU0wrZFFVVVFjdG8va1ph?= =?utf-8?B?R1ZtVzhCelBQb1FmOWx4WVYwWVB0aDNaR0Zaa1FMd2NwbW9pTlorQjRER1I2?= =?utf-8?B?QWFtM1ZDdnJ0Vm9Bd21GdFVzY0pyZEExZE1DYzg1UnRnc01UY1BBTVNnTXYy?= =?utf-8?B?SFV2MmlpRk80YXZlSEdGVVQ2K016Y2JlVXhBd2dmVU96WDZTRXVMNnRBZFRC?= =?utf-8?B?blhaTC94Uk5sMDZHOTF6eUhteFBWb1dwRzcyUlczZFBGVkl4ZFJOVzNHRWZ0?= =?utf-8?B?K1puQjFNOG9zRUl4TStHZ2N3bVM2SVBRWUxvMnB3eUlIMFJ1bGlVU0xobkNn?= =?utf-8?B?Si9ZWmxMWXcvVnR4WkpxUlo4MmtvMjdKYkg5Y01oKzJkOVZMZDRZc3MxWkt6?= =?utf-8?B?R3FSR2tMZWZqWXZBTnJtU3dKazNKakZQeHpWREN3b1QxVThGeFRYako2WVF4?= =?utf-8?B?aTZIcFdXcFNOM3NxYzlCTUQ4ZGRZbkJPeHlzOG1ic2hUVldqN1Z6Z1QzWWZB?= =?utf-8?B?VkhNaWNpMjJYa1NKN3Y0QnpFVGN0RnU3c2ZBRGZnRjY3Umxxam5zSk9xazI5?= =?utf-8?B?dmM2d29Ga3dxOUpocnpmWWZWckVSMFhobUVycnE2Y1ArZEtkbk1NMGZwSzFi?= =?utf-8?B?TFMwZzI1WUJXSHZidkFydjJiMitrUGd6dm9jUDR5L0xBTWRrQUtUaVlNeEp1?= =?utf-8?B?bU9weDN1N3dvRWw5T2hCbWhRR1hMNmxPU1gvVGt3SzlRUlR6UHI3SnhTdUlK?= =?utf-8?B?dURRVlYvZHhvaVpzT2RvR1dHa2Fuajk0K2EyYkFTMElKM0NoS2VUelcrcTh6?= =?utf-8?B?VzZvc093OXdxeWV5RytycXVTSXBjOVpPazgralNkeFoxTUtnSHFvU2ZTLzRs?= =?utf-8?B?RWxJbTFDank5MlZTN055WHhjS1B1OXhqTDQwdWJDVHp1Q25hQStOOGFPcTFu?= =?utf-8?B?M21aSkZKRy9yNGxrNWpoSGVYc1oydmwzMjRmblprZEFZWGRqOXl3QlhmaEdy?= =?utf-8?B?ZE16d3g0WVIwYkY5R0pEUWMxQm82eno5d21zZlJReFhidDZwM1loajdpWnpX?= =?utf-8?Q?aCtzrj0FpMYXF/1o=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6b0b92d-1547-4047-9ccb-08da432ae080 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 17:27:46.1496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FToyA8KUwIaDrUS7VVEJR8cAydo/ABLKvjST829zwOfNIiuslBxfHREgJ0dnmhhh0hb3iSczgFzOKsLuTagzg1WIXEaSQGn5rYntu4MFEgo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1846 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874 definitions=2022-05-31_07:2022-05-30,2022-05-31 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205310081 X-Proofpoint-ORIG-GUID: 1OduQthX29qWivf9uxvq95tNT4ajXpIS X-Proofpoint-GUID: 1OduQthX29qWivf9uxvq95tNT4ajXpIS On 5/30/22 4:26 AM, Juergen Gross wrote: > xen_remap() is used to establish mappings for frames not under direct > control of the kernel: for Xenstore and console ring pages, and for > grant pages of non-PV guests. > > Today xen_remap() is defined to use ioremap() on x86 (doing uncached > mappings), and ioremap_cache() on Arm (doing cached mappings). > > Uncached mappings for those use cases are bad for performance, so they > should be avoided if possible. As all use cases of xen_remap() don't > require uncached mappings (the mapped area is always physical RAM), > a mapping using the standard WB cache mode is fine. > > As sparse is flagging some of the xen_remap() use cases to be not > appropriate for iomem(), as the result is not annotated with the > __iomem modifier, eliminate xen_remap() completely and replace all > use cases with memremap() specifying the MEMREMAP_WB caching mode. > > xen_unmap() can be replaced with memunmap(). > > Reported-by: kernel test robot > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Tue May 31 18:22:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339936.564854 (Exim 4.92) (envelope-from ) id 1nw6VY-0001C8-Un; Tue, 31 May 2022 18:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339936.564854; Tue, 31 May 2022 18:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6VY-0001C1-Rw; Tue, 31 May 2022 18:22:20 +0000 Received: by outflank-mailman (input) for mailman id 339936; Tue, 31 May 2022 18:22:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6VY-0001Bv-0t for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:22:20 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99b19747-e10e-11ec-837f-e5687231ffcc; Tue, 31 May 2022 20:22:18 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654021329834917.9817460474425; Tue, 31 May 2022 11:22:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99b19747-e10e-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654021334; cv=none; d=zohomail.com; s=zohoarc; b=Wp5+TSjauFy6EGGZIt5qjwVblic4+pobd2jhIwU8RPb+NktbA3DP4NtPqmsEfV7Nd83YKJu5JwV4Sm+A3MUVO1S5wOOrxo/CVg0zcLUGR7WtnrJTZgEmZ85olsgayuVdaBOU+hxsaJANsxe9QAvTK2o3jUj+4e0oFXJfz87ICVQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654021334; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=jWXI3JIoau3kt0MxfNomZ5YC5oHP8ua1nV5SsGfTDV4=; b=XXTenUnRWMrKfnUizNQ3fpUabGStmdsa7SHxLYCX6oNWznKCIem+p3O4skTIigo2aSlip27iDoce3e8bod7vHrQZzQiQ+mfRbzibNhgxpLK15FZOaoDfiAkb1p6rcvpy/F+vBHR9M/fqdN3+jiPX6eRTcSaeQrBKLVJklNOq3yk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654021334; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=jWXI3JIoau3kt0MxfNomZ5YC5oHP8ua1nV5SsGfTDV4=; b=IOm2LFXvSVnuxzdbdUZJ12Tm1VxrHAccaZG6npp9OLWwLxFr8I67OhNAM9jrXqD1 WATn7pApjxC8qIsO97QGA/7EKWaY99+oP6HuMJ8Mi2V/O2ssgzN94SSh9pKwyVP29Os ErAZqgiOeBE1J7f8fEJeiXNFR3LFO55P/HsPowOI= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com Subject: [PATCH v4 0/3] xsm: refactor and optimize policy loading Date: Tue, 31 May 2022 14:20:38 -0400 Message-Id: <20220531182041.10640-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This series was born out of some cleanup work done while crafting the hyperlaunch boot modules patch series. The primary purpose of this series was to stop walking all boot modules when it was not necessary, but the scope creeped during review. Changes in v4: * rewroked xsm_{multiboot,dt}_init() to support flask=late * applied the correct types to the policy_buffer for DT * change type from array to pointer on xsm_multiboot_policy_init() Changes in v3: * added arm Rb for patch #3 * mainly a resend due to fubar on sending v2 Changes in v2: * changed init_policy to policy_file_required * split the patch into a series * corrected casting of policy buffer * use IS_ENABLED() instead of #ifdef sequence * moved #ifdef inside of braces for xsm_dt_policy_init() * addressed lack of error handling of xsm{mb,dt}_init() Daniel P. Smith (3): xsm: only search for a policy file when needed xsm: consolidate loading the policy buffer xsm: properly handle error from XSM init xen/arch/arm/setup.c | 10 ++--- xen/arch/x86/setup.c | 9 ++++- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 89 ++++++++++++++++++++++++------------------- xen/xsm/xsm_policy.c | 34 ++++++++++++++--- 5 files changed, 91 insertions(+), 53 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 18:22:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339937.564865 (Exim 4.92) (envelope-from ) id 1nw6Vd-0001Rr-5v; Tue, 31 May 2022 18:22:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339937.564865; Tue, 31 May 2022 18:22:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6Vd-0001Rg-2l; Tue, 31 May 2022 18:22:25 +0000 Received: by outflank-mailman (input) for mailman id 339937; Tue, 31 May 2022 18:22:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6Vc-0001Bv-4G for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:22:24 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cc2d719-e10e-11ec-837f-e5687231ffcc; Tue, 31 May 2022 20:22:23 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654021331693774.6960042471216; Tue, 31 May 2022 11:22:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cc2d719-e10e-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654021334; cv=none; d=zohomail.com; s=zohoarc; b=Bvd6GbCqZn3R4EQJ81pbDxE7AZfJguAFwQqXKIsxLFjzS3vsuR4apnMRKK6GuSqQcrxtQDlasTKZb+tyVEqjUEGpN58QVWlA4wQoEgEm654DPeBE+uOjbeDrM0MAZcTWvn8B8jDCaZtYGaW1D1tNJo04AIyLK9lL5Ru+gi2nIdM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654021334; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=KBY2xXMWGEMcMlJzy44xfoRM1aSupSi2T4p8kowrFvI=; b=Oa7AGmnYeVrVnp7FXaiCqyplfhh31yIZRiV1u9h5Ark33I55CKSK8d+eHFddCjtSImVPmTQuwSKQW6RXMd82BkI9ki6qWPSb0Q1hv9ZKr8Ug/9oLpl+WiwiwJjYtdqGMfRKAIL6eFFqFGJbUiR7uNQjcsFugGBp1eM5rByz1sh8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654021334; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=KBY2xXMWGEMcMlJzy44xfoRM1aSupSi2T4p8kowrFvI=; b=R5y+ohRsEVbOl5jnu31oTMSRf73GGsQx1Qt9wrzKKxonxWcddVh9MTtFSun/HXAg AiB15z+afNvl5443gtxKs3k4bgcFEj8dHo+OX3oGEtu94qAVzwWtKojewJjilGZiGtK XRpRUKNGGlbpXwnX/pQA9eIpKU7WfJuyon55nOAQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Jan Beulich , Daniel De Graaf Subject: [PATCH v4 1/3] xsm: only search for a policy file when needed Date: Tue, 31 May 2022 14:20:39 -0400 Message-Id: <20220531182041.10640-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531182041.10640-1-dpsmith@apertussolutions.com> References: <20220531182041.10640-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It is possible to select a few different build configurations that results in the unnecessary walking of the boot module list looking for a policy module. This specifically occurs when the flask policy is enabled but either the dummy or the SILO policy is selected as the enforcing policy. This is not ideal for configurations like hyperlaunch and dom0less when there could be a number of modules to be walked or doing an unnecessary device tree lookup. This patch introduces the policy_file_required flag for tracking when an XSM policy module requires a policy file. Only when the policy_file_required flag is set to true, will XSM search the boot modules for a policy file. Signed-off-by: Daniel P. Smith Reviewed-by: Jan Beulich --- xen/xsm/xsm_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..675e4f552c 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -55,19 +55,31 @@ static enum xsm_bootparam __initdata xsm_bootparam = XSM_BOOTPARAM_DUMMY; #endif +static bool __initdata policy_file_required = + IS_ENABLED(CONFIG_XSM_FLASK_DEFAULT); + static int __init cf_check parse_xsm_param(const char *s) { int rc = 0; if ( !strcmp(s, "dummy") ) + { xsm_bootparam = XSM_BOOTPARAM_DUMMY; + policy_file_required = false; + } #ifdef CONFIG_XSM_FLASK else if ( !strcmp(s, "flask") ) + { xsm_bootparam = XSM_BOOTPARAM_FLASK; + policy_file_required = true; + } #endif #ifdef CONFIG_XSM_SILO else if ( !strcmp(s, "silo") ) + { xsm_bootparam = XSM_BOOTPARAM_SILO; + policy_file_required = false; + } #endif else rc = -EINVAL; @@ -148,7 +160,7 @@ int __init xsm_multiboot_init( printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required ) { ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); @@ -176,7 +188,7 @@ int __init xsm_dt_init(void) printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); - if ( XSM_MAGIC ) + if ( policy_file_required ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); if ( ret ) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 18:22:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339944.564877 (Exim 4.92) (envelope-from ) id 1nw6Vu-0001xd-Ms; Tue, 31 May 2022 18:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339944.564877; Tue, 31 May 2022 18:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6Vu-0001xU-JH; Tue, 31 May 2022 18:22:42 +0000 Received: by outflank-mailman (input) for mailman id 339944; Tue, 31 May 2022 18:22:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6Vt-0001Bv-CO for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:22:41 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6f22442-e10e-11ec-837f-e5687231ffcc; Tue, 31 May 2022 20:22:40 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165402133284993.92840751191375; Tue, 31 May 2022 11:22:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6f22442-e10e-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654021335; cv=none; d=zohomail.com; s=zohoarc; b=dZ2eIA7qYawzC7eXfN54pWpsHSrDuTSItfpDqYJH51vXEYT14cPu9aZtLpSv2BRRJ3Rcb4IBjoMy3I8hoDDxeia5TRSBgpngtfYFlcg2qcMyFYBzlcRldApF8hmnBJc49GgQnlkxLIK78ULJJkrH98G6uFF8rOBh+qg+2Nka7/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654021335; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GFL69TM/rWsqG1UsJSNR/jCSJfExay3yhIv9zgA8Pao=; b=bLn4+sSit+K4cdsBFDWYS1YYgpM3CWSfbO0+xxuX1xOZEMTQrBLsTliq/mdI8UJHoPUq3IhhZ2ODLL3ujYS/FqkJA4nG5pdz5LltzxOlHreuZndl3KWc5F21inW7Scs9w0chpRZVlpgRX83jF9sDTUxgQ1s8QwE/E8w8Ym4p+7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654021335; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=GFL69TM/rWsqG1UsJSNR/jCSJfExay3yhIv9zgA8Pao=; b=MEDSOWUA/M8+0Ai3mt2vDAMtVkNEBTqym6nm4+wd4L2wfmPdMtDt5VE/ZwgZ9wEs PZFkUdbCofs7OEHyBcF1+Our8fRvmpI8HyIVCutxYO6BjuEZqY/0VxVMBBD3K63QG+w 2R9FBNUJR8DeqpzvF2cu3Jzia/E+uqiwbzHeYLd0= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf Subject: [PATCH v4 2/3] xsm: consolidate loading the policy buffer Date: Tue, 31 May 2022 14:20:40 -0400 Message-Id: <20220531182041.10640-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531182041.10640-1-dpsmith@apertussolutions.com> References: <20220531182041.10640-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Previously, initializing the policy buffer was split between two functions, xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading the policy from boot modules and the former for falling back to built-in policy. This patch moves all policy buffer initialization logic under the xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error message is printed for every error condition that may occur in the functions. With all policy buffer init contained and only called when the policy buffer must be populated, the respective xsm_{mb,dt}_init() functions will panic for all errors except ENOENT. An ENOENT signifies that a policy file could not be located. Since it is not possible to know if late loading of the policy file is intended, a warning is reported and XSM initialization is continued. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 2 +- xen/xsm/xsm_core.c | 51 ++++++++++++++++++++----------------------- xen/xsm/xsm_policy.c | 34 ++++++++++++++++++++++++----- 3 files changed, 54 insertions(+), 33 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3e2b7fe3db..1676c261c9 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -775,7 +775,7 @@ int xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi); int xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); + const unsigned char *policy_buffer[], size_t *policy_size); #endif #ifdef CONFIG_HAS_DEVICE_TREE diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 675e4f552c..a3715fa239 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -92,14 +92,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { const struct xsm_ops *ops = NULL; -#ifdef CONFIG_XSM_FLASK_POLICY - if ( policy_size == 0 ) - { - policy_buffer = xsm_flask_init_policy; - policy_size = xsm_flask_init_policy_size; - } -#endif - if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { printk(XENLOG_ERR @@ -154,28 +146,29 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) int __init xsm_multiboot_init( unsigned long *module_map, const multiboot_info_t *mbi) { - int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); if ( policy_file_required ) { - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, + int ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, &policy_size); - if ( ret ) - { - bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + bootstrap_map(NULL); + + if ( ret == -ENOENT ) + /* + * The XSM module needs a policy file but one was not located. + * Report as a warning and continue as the XSM module may late + * load a policy file. + */ + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); + else + panic("Error %d initializing XSM policy\n", ret); } - ret = xsm_core_init(policy_buffer, policy_size); - bootstrap_map(NULL); - - return 0; + return xsm_core_init(policy_buffer, policy_size); } #endif @@ -183,7 +176,7 @@ int __init xsm_multiboot_init( int __init xsm_dt_init(void) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); @@ -191,11 +184,15 @@ int __init xsm_dt_init(void) if ( policy_file_required ) { ret = xsm_dt_policy_init(&policy_buffer, &policy_size); - if ( ret ) - { - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + if ( ret == -ENOENT ) + /* + * The XSM module needs a policy file but one was not located. + * Report as a warning and continue as the XSM module may late + * load a policy file. + */ + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); + else + panic("Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..690fd23e9f 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -8,7 +8,7 @@ * Contributors: * Michael LeMay, * George Coker, - * + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. @@ -32,14 +32,21 @@ #ifdef CONFIG_MULTIBOOT int __init xsm_multiboot_policy_init( unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) + const unsigned char **policy_buffer, size_t *policy_size) { int i; module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif + /* * Try all modules and see whichever could be the binary policy. * Adjust module_map for the module that is the binary policy. @@ -54,13 +61,14 @@ int __init xsm_multiboot_policy_init( if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); __clear_bit(i, module_map); + rc = 0; break; } @@ -68,18 +76,31 @@ int __init xsm_multiboot_policy_init( bootstrap_map(NULL); } + if ( rc == -ENOENT ) + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return rc; } #endif #ifdef CONFIG_HAS_DEVICE_TREE -int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) +int __init xsm_dt_policy_init( + const unsigned char **policy_buffer, size_t *policy_size) { struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); paddr_t paddr, len; if ( !mod || !mod->size ) + { +#ifdef CONFIG_XSM_FLASK_POLICY + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; return 0; +#else + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); + return -ENOENT; +#endif + } paddr = mod->start; len = mod->size; @@ -95,7 +116,10 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) *policy_buffer = xmalloc_bytes(len); if ( !*policy_buffer ) + { + printk(XENLOG_ERR "xsm: Unable to allocate memory for XSM policy\n"); return -ENOMEM; + } copy_from_paddr(*policy_buffer, paddr, len); *policy_size = len; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 18:22:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339946.564887 (Exim 4.92) (envelope-from ) id 1nw6W0-0002RQ-Uu; Tue, 31 May 2022 18:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339946.564887; Tue, 31 May 2022 18:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6W0-0002RJ-RZ; Tue, 31 May 2022 18:22:48 +0000 Received: by outflank-mailman (input) for mailman id 339946; Tue, 31 May 2022 18:22:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6W0-0001Bv-Bn for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:22:48 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab20d6a3-e10e-11ec-837f-e5687231ffcc; Tue, 31 May 2022 20:22:47 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654021334373232.38234809614937; Tue, 31 May 2022 11:22:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab20d6a3-e10e-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654021337; cv=none; d=zohomail.com; s=zohoarc; b=AsuYly0VWy8e71su1i/AHWaxzZt9xGmSQJfgrjhb+cIx0ksEypGFW4C50B7wNxTz1SohtP0vUvKcwSpNpDJbtcy1eOsEy8jJAIf0HKRfV0mBZTT3kCJsbWl2RYk7XRiZG2G05FdHIB3cuR2d4RlXzQYOA+nCs47g5te5rfUf7uo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654021337; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=YjPh9YmDNkWWBLcePvW+k5QuQW9YQ7i+jWEwgIPyRtU=; b=hBIC15yxLw2ltpAI1SkWpquCGRQeIndknB9cO20F2yBghRPihYk5410OHw14bb7mSsJLO+qHyhHjk55TV02RySiivPUHAU7/auWq5vIDd2PmKrMQlpmHoNC9vhMw7IxUkDY908ufDRV/9vcZgFMW/w761wUyJJSMibkI4ExEUu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654021337; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=YjPh9YmDNkWWBLcePvW+k5QuQW9YQ7i+jWEwgIPyRtU=; b=ImgQlZtfltHT1AN3zPRYVH601IEzpBb63GbaTAG1qA8QPK4UNeBTRIdD0DngvThr uyrBxf0DUkLkpt9lCAkuqnt05B4VoO4Xln1QbcDxebhJeZpeDfA6NnQ+Iu+i0bjKUrV jLx3n7xlKRLM7qRO5ld6LmDF8Ai3M0iYmaaEn9Xw= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Bertrand Marquis , Stefano Stabellini , Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Daniel De Graaf Subject: [PATCH v4 3/3] xsm: properly handle error from XSM init Date: Tue, 31 May 2022 14:20:41 -0400 Message-Id: <20220531182041.10640-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220531182041.10640-1-dpsmith@apertussolutions.com> References: <20220531182041.10640-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit is to move towards providing a uniform interface across architectures to initialize the XSM framework. Specifically, it provides a common handling of initialization failure by providing the printing of a warning message. For Arm, xsm_dt_init() was tailored to have an Arm specific expansion of the return values. This expansion added a value to reflect whether the security supported XSM policy module was the enforcing policy module. This was then used to determine if a warning message would be printed. Despite this expansion, like x86, Arm does not address any XSM initialization errors that may have occurred. Signed-off-by: Daniel P. Smith Reviewed-by: Bertrand Marquis # arm --- xen/arch/arm/setup.c | 10 +++++----- xen/arch/x86/setup.c | 9 +++++++-- xen/xsm/xsm_core.c | 22 +++++++++++----------- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index ea1f5ee3d3..6bf71e1064 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -967,11 +967,11 @@ void __init start_xen(unsigned long boot_phys_offset, tasklet_subsys_init(); - if ( xsm_dt_init() != 1 ) - warning_add("WARNING: SILO mode is not enabled.\n" - "It has implications on the security of the system,\n" - "unless the communications have been forbidden between\n" - "untrusted domains.\n"); + if ( xsm_dt_init() ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); init_maintenance_interrupt(); init_timer_interrupt(); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 53a73010e0..ed67b50c9d 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #ifdef CONFIG_COMPAT @@ -1690,7 +1691,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period); - if ( opt_watchdog ) + if ( opt_watchdog ) nmi_watchdog = NMI_LOCAL_APIC; find_smp_config(); @@ -1700,7 +1701,11 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + if ( xsm_multiboot_init(module_map, mbi) ) + warning_add("WARNING: XSM failed to initialize.\n" + "This has implications on the security of the system,\n" + "as uncontrolled communications between trusted and\n" + "untrusted domains may occur.\n"); /* * IOMMU-related ACPI table parsing may require some of the system domains diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index a3715fa239..fa17401a5f 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,23 +10,17 @@ * as published by the Free Software Foundation. */ -#include #include +#include +#include #include #include - -#include +#include #include -#ifdef CONFIG_XSM - -#ifdef CONFIG_MULTIBOOT #include -#endif -#ifdef CONFIG_HAS_DEVICE_TREE -#include -#endif +#ifdef CONFIG_XSM #define XSM_FRAMEWORK_VERSION "1.0.1" @@ -199,7 +193,13 @@ int __init xsm_dt_init(void) xfree(policy_buffer); - return ret ?: (xsm_bootparam == XSM_BOOTPARAM_SILO); + if ( xsm_bootparam != XSM_BOOTPARAM_SILO ) + warning_add("WARNING: SILO mode is not enabled.\n" + "It has implications on the security of the system,\n" + "unless the communications have been forbidden between\n" + "untrusted domains.\n"); + + return ret; } /** -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue May 31 18:26:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339960.564899 (Exim 4.92) (envelope-from ) id 1nw6ZH-0003an-GD; Tue, 31 May 2022 18:26:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339960.564899; Tue, 31 May 2022 18:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6ZH-0003ag-Cg; Tue, 31 May 2022 18:26:11 +0000 Received: by outflank-mailman (input) for mailman id 339960; Tue, 31 May 2022 18:26:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6ZF-0003aN-ST; Tue, 31 May 2022 18:26:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6ZF-0001lH-PS; Tue, 31 May 2022 18:26:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6ZF-0007mE-CO; Tue, 31 May 2022 18:26:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nw6ZF-0008AT-Bv; Tue, 31 May 2022 18:26:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2J24G2R9G+nejzBfSvqcmHDi0b0e3ZjnF2gjf54l+4Q=; b=Ajh8ByoXvD9FHDzgUwCOgXCSEU YvksVdhRCFig2Brnv1xnii+idlZg+5ftbOEnngC1cI0e+JJ3Il1zjN3rKWAXF4lzXWvsibgqbBUIp zBg5R5yfnpiQ/5w5tct+9exIQGRwiQlWZeqF9+pQyxTVJQSPiTIJuGX8RuPPyTUYHs50=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xtf test] 170789: all pass - PUSHED X-Osstest-Versions-This: xtf=37ea4e513a2ce0cd22f9c9a32b18d5c022e38e12 X-Osstest-Versions-That: xtf=bc0abf2a5498d4691538bf34496ca0f0f189951b From: osstest service owner Date: Tue, 31 May 2022 18:26:09 +0000 flight 170789 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170789/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 37ea4e513a2ce0cd22f9c9a32b18d5c022e38e12 baseline version: xtf bc0abf2a5498d4691538bf34496ca0f0f189951b Last test of basis 168044 2022-02-07 11:41:42 Z 113 days Testing same since 170789 2022-05-31 17:41:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xtf pass build-amd64 pass build-amd64-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xtf.git bc0abf2..37ea4e5 37ea4e513a2ce0cd22f9c9a32b18d5c022e38e12 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue May 31 18:28:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:28:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339971.564909 (Exim 4.92) (envelope-from ) id 1nw6bv-0004F0-Ua; Tue, 31 May 2022 18:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339971.564909; Tue, 31 May 2022 18:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6bv-0004Et-RS; Tue, 31 May 2022 18:28:55 +0000 Received: by outflank-mailman (input) for mailman id 339971; Tue, 31 May 2022 18:28:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6bu-0004En-4P for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:28:54 +0000 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [2607:f8b0:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 859f81d1-e10f-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 20:28:53 +0200 (CEST) Received: by mail-il1-x12d.google.com with SMTP id f7so3726567ilr.5 for ; Tue, 31 May 2022 11:28:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 859f81d1-e10f-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sqoYlTKISt4pYqngzf0Xnq2lJyvUsnaz0a7MCsINQvI=; b=JbnmzjRBKBBueKQElvFIh4fX8U9QD0j9YUxKehSiF6fr5Ua7Q0kUB6FKin1WnAU91r b4o857CHCTZe6t98HKLJrr/cbO3Mbp3RDFjfwxo9sVd/7I+o6NAaKBv8dr8Fcnx/vFX2 sgWWP14/0+KMHOdJnwMabzkM3zNaG2JldL/H26OZj2X4hgdzcaGSI/7imaTlX6QR5H9T EwxEYCHtjbjRU5HPjpn9biatGz8USCsh5Ra5pIf9ZMhaxGpEzLAVvg5QeVbCOvaH2rIL UUGSyrcQOBcCTTXFEW5XFLmCwZOumnTda0w9xgeoM/+QP9+a/19pWU2Bz7S3azdCJPoQ f9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sqoYlTKISt4pYqngzf0Xnq2lJyvUsnaz0a7MCsINQvI=; b=BhOkYwWsvz1kat+Ncm8ny7yGVrxRJua+o8vE0lHZri+2eSNe+ZnTJ2ZX/QE8RfN0Ay GnM/jl/ElgUXv/XxrZroa1qWyQynd6ivEYrQUfmG9DJLi+afyQ57UNExkMrMvk9nf18L ahOqB5z8C+9tWm7Mtn0IkUhsciDP3JS3jOgOYQuTp20OxpcI/K9X/57QZhIZ6QfuwCIw K5vCdccxy/C4MujLyb8R8J+Zpeh1Ul/pndMlQfIdvBqAS6yjmUJ56/uOaMGm3mMeEtzp gZfmFKOqEljnrgtCy4/pepqq6NLeD64aERo7qZvhtJFzVkQDPrA3M6AY+VhNjZArZGbu X9Gw== X-Gm-Message-State: AOAM530uCpGeSRNYeiJoAyKtyJ8d5tD6pn3fsVSm0cnl9Kj6gtTShxxp Mzx/GHEVXoJqwu5jQVlK/Srcohi9xrNHGrmmSTEWZHYi X-Google-Smtp-Source: ABdhPJwjBlkOZhJYCXTV5XBgzIfkozEBXFELlWJu2X0oyWX2cIG4Z4c08v9n1iyuLepDTorgWBGiyrbIpQ0bY6mUmOs= X-Received: by 2002:a05:6e02:198e:b0:2cf:4a7a:faf8 with SMTP id g14-20020a056e02198e00b002cf4a7afaf8mr30353315ilf.206.1654021731940; Tue, 31 May 2022 11:28:51 -0700 (PDT) MIME-Version: 1.0 References: <20220531182041.10640-1-dpsmith@apertussolutions.com> <20220531182041.10640-2-dpsmith@apertussolutions.com> In-Reply-To: <20220531182041.10640-2-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Tue, 31 May 2022 14:28:40 -0400 Message-ID: Subject: Re: [PATCH v4 1/3] xsm: only search for a policy file when needed To: "Daniel P. Smith" Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Jan Beulich , Daniel De Graaf Content-Type: text/plain; charset="UTF-8" On Tue, May 31, 2022 at 2:22 PM Daniel P. Smith wrote: > > It is possible to select a few different build configurations that results in > the unnecessary walking of the boot module list looking for a policy module. > This specifically occurs when the flask policy is enabled but either the dummy > or the SILO policy is selected as the enforcing policy. This is not ideal for > configurations like hyperlaunch and dom0less when there could be a number of > modules to be walked or doing an unnecessary device tree lookup. > > This patch introduces the policy_file_required flag for tracking when an XSM > policy module requires a policy file. Only when the policy_file_required flag > is set to true, will XSM search the boot modules for a policy file. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Jan Beulich Reviewed-by: Jason Andryuk From xen-devel-bounces@lists.xenproject.org Tue May 31 18:42:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 18:42:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.339993.564920 (Exim 4.92) (envelope-from ) id 1nw6pF-0006ns-4I; Tue, 31 May 2022 18:42:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 339993.564920; Tue, 31 May 2022 18:42:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6pF-0006nl-1b; Tue, 31 May 2022 18:42:41 +0000 Received: by outflank-mailman (input) for mailman id 339993; Tue, 31 May 2022 18:42:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw6pD-0006nf-KE for xen-devel@lists.xenproject.org; Tue, 31 May 2022 18:42:39 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70aeb73a-e111-11ec-837f-e5687231ffcc; Tue, 31 May 2022 20:42:37 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1654022553572260.7125117426111; Tue, 31 May 2022 11:42:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70aeb73a-e111-11ec-837f-e5687231ffcc ARC-Seal: i=1; a=rsa-sha256; t=1654022555; cv=none; d=zohomail.com; s=zohoarc; b=SCoVdfwcMNYFAGp9/KFSwNQtMswTPY/oqEmkEkXVZet6PXBzJ+CG7ib9S3Yl+1ApNBQ4s/6echjL0iEckka67tXxHWNM7eCDoDxAzHNj7R8lmtBhZyTCzyWIf8AGY4d2NEVuiq2xmCpIkYm4hHh5GDyrkU9bJylhghNWo2OnYIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654022555; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=aTwFNk7tW621SF6+ViguXLN6YsO1wyymwaU1/IXPzdQ=; b=Ua295ZoyYCOHZOjTKs5OdxjFfnF2Ryy6+0hIu9+pF5XvkRd6j/BdXoRY2HI207mfmQEALCQTxT5OKOYZj6Ba2vVcnxXWUXRgbf/GzKyTxH9CkhMzD59zzl9QHQQhWdzhtIVVKUgF2bK2YSDosOk7UnjoP9Kxc0XaaQu+ds4CGlQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1654022555; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=aTwFNk7tW621SF6+ViguXLN6YsO1wyymwaU1/IXPzdQ=; b=JGHHqgLgkZncqYylYkIqGSGJQyRtlQouKabH8dGdWbTs6J1lijJ+CKF0Qvcl+mUj xe48sSw+vXsMWy0ov6kcRC0JYpQwK6DEdYcSqdlft6XSrxG9m3P+pV+MwJxdG3ykXsr /aaIAXPYLYrms45YWGeYGZ3YiR7bBtoYloPc5JuQ= Message-ID: <6d02621e-3106-4924-3307-37b4174fe766@apertussolutions.com> Date: Tue, 31 May 2022 14:41:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: xen-devel@lists.xenproject.org Cc: scott.davis@starlab.io, christopher.clark@starlab.io, jandryuk@gmail.com, Daniel De Graaf References: <20220531182041.10640-1-dpsmith@apertussolutions.com> <20220531182041.10640-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v4 2/3] xsm: consolidate loading the policy buffer In-Reply-To: <20220531182041.10640-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 5/31/22 14:20, Daniel P. Smith wrote: > Previously, initializing the policy buffer was split between two functions, > xsm_{multiboot,dt}_policy_init() and xsm_core_init(). The latter for loading > the policy from boot modules and the former for falling back to built-in > policy. > > This patch moves all policy buffer initialization logic under the > xsm_{multiboot,dt}_policy_init() functions. It then ensures that an error > message is printed for every error condition that may occur in the functions. > With all policy buffer init contained and only called when the policy buffer > must be populated, the respective xsm_{mb,dt}_init() functions will panic for > all errors except ENOENT. An ENOENT signifies that a policy file could not be > located. Since it is not possible to know if late loading of the policy file is > intended, a warning is reported and XSM initialization is continued. > > Signed-off-by: Daniel P. Smith > --- > xen/include/xsm/xsm.h | 2 +- > xen/xsm/xsm_core.c | 51 ++++++++++++++++++++----------------------- > xen/xsm/xsm_policy.c | 34 ++++++++++++++++++++++++----- > 3 files changed, 54 insertions(+), 33 deletions(-) > > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index 3e2b7fe3db..1676c261c9 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -775,7 +775,7 @@ int xsm_multiboot_init( > unsigned long *module_map, const multiboot_info_t *mbi); > int xsm_multiboot_policy_init( > unsigned long *module_map, const multiboot_info_t *mbi, > - void **policy_buffer, size_t *policy_size); > + const unsigned char *policy_buffer[], size_t *policy_size); > #endif > > #ifdef CONFIG_HAS_DEVICE_TREE > diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c > index 675e4f552c..a3715fa239 100644 > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -92,14 +92,6 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) > { > const struct xsm_ops *ops = NULL; > > -#ifdef CONFIG_XSM_FLASK_POLICY > - if ( policy_size == 0 ) > - { > - policy_buffer = xsm_flask_init_policy; > - policy_size = xsm_flask_init_policy_size; > - } > -#endif > - > if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) > { > printk(XENLOG_ERR > @@ -154,28 +146,29 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) > int __init xsm_multiboot_init( > unsigned long *module_map, const multiboot_info_t *mbi) > { > - int ret = 0; > - void *policy_buffer = NULL; > + const unsigned char *policy_buffer; > size_t policy_size = 0; > > printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); > > if ( policy_file_required ) > { > - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, > + int ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, > &policy_size); > - if ( ret ) > - { > - bootstrap_map(NULL); > - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); > - return -EINVAL; > - } > + bootstrap_map(NULL); > + > + if ( ret == -ENOENT ) > + /* > + * The XSM module needs a policy file but one was not located. > + * Report as a warning and continue as the XSM module may late > + * load a policy file. > + */ > + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); > + else > + panic("Error %d initializing XSM policy\n", ret); > } > > - ret = xsm_core_init(policy_buffer, policy_size); > - bootstrap_map(NULL); > - > - return 0; > + return xsm_core_init(policy_buffer, policy_size); > } > #endif > > @@ -183,7 +176,7 @@ int __init xsm_multiboot_init( > int __init xsm_dt_init(void) > { > int ret = 0; > - void *policy_buffer = NULL; > + const unsigned char *policy_buffer; > size_t policy_size = 0; > > printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); > @@ -191,11 +184,15 @@ int __init xsm_dt_init(void) > if ( policy_file_required ) > { > ret = xsm_dt_policy_init(&policy_buffer, &policy_size); > - if ( ret ) > - { > - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); > - return -EINVAL; > - } > + if ( ret == -ENOENT ) > + /* > + * The XSM module needs a policy file but one was not located. > + * Report as a warning and continue as the XSM module may late > + * load a policy file. > + */ > + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); > + else > + panic("Error %d initializing XSM policy\n", ret); > } > > ret = xsm_core_init(policy_buffer, policy_size); > diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c > index 8dafbc9381..690fd23e9f 100644 > --- a/xen/xsm/xsm_policy.c > +++ b/xen/xsm/xsm_policy.c > @@ -8,7 +8,7 @@ > * Contributors: > * Michael LeMay, > * George Coker, > - * > + * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License version 2, > * as published by the Free Software Foundation. > @@ -32,14 +32,21 @@ > #ifdef CONFIG_MULTIBOOT > int __init xsm_multiboot_policy_init( > unsigned long *module_map, const multiboot_info_t *mbi, > - void **policy_buffer, size_t *policy_size) > + const unsigned char **policy_buffer, size_t *policy_size) > { > int i; > module_t *mod = (module_t *)__va(mbi->mods_addr); > - int rc = 0; > + int rc = -ENOENT; > u32 *_policy_start; > unsigned long _policy_len; > > +#ifdef CONFIG_XSM_FLASK_POLICY > + /* Initially set to builtin policy, overriden if boot module is found. */ > + *policy_buffer = xsm_flask_init_policy; > + *policy_size = xsm_flask_init_policy_size; > + rc = 0; > +#endif > + > /* > * Try all modules and see whichever could be the binary policy. > * Adjust module_map for the module that is the binary policy. > @@ -54,13 +61,14 @@ int __init xsm_multiboot_policy_init( > > if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) > { > - *policy_buffer = _policy_start; > + *policy_buffer = (unsigned char *)_policy_start; > *policy_size = _policy_len; > > printk("Policy len %#lx, start at %p.\n", > _policy_len,_policy_start); > > __clear_bit(i, module_map); > + rc = 0; > break; > > } > @@ -68,18 +76,31 @@ int __init xsm_multiboot_policy_init( > bootstrap_map(NULL); > } > > + if ( rc == -ENOENT ) > + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); > + > return rc; > } > #endif > > #ifdef CONFIG_HAS_DEVICE_TREE > -int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) > +int __init xsm_dt_policy_init( > + const unsigned char **policy_buffer, size_t *policy_size) I just caught that I missed the matching header declaration. ( ._.) I noticed there is a one-liner at the end of INSTALL for doing cross-compile. I will see if I can get that to work to incorporate in my build/test system. > { > struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); > paddr_t paddr, len; > > if ( !mod || !mod->size ) > + { > +#ifdef CONFIG_XSM_FLASK_POLICY > + *policy_buffer = xsm_flask_init_policy; > + *policy_size = xsm_flask_init_policy_size; > return 0; > +#else > + printk(XENLOG_ERR "xsm: Unable to locate policy file\n"); > + return -ENOENT; > +#endif > + } > > paddr = mod->start; > len = mod->size; > @@ -95,7 +116,10 @@ int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) > > *policy_buffer = xmalloc_bytes(len); > if ( !*policy_buffer ) > + { > + printk(XENLOG_ERR "xsm: Unable to allocate memory for XSM policy\n"); > return -ENOMEM; > + } > > copy_from_paddr(*policy_buffer, paddr, len); > *policy_size = len; From xen-devel-bounces@lists.xenproject.org Tue May 31 19:04:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 19:04:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340003.564932 (Exim 4.92) (envelope-from ) id 1nw7AX-00013f-2i; Tue, 31 May 2022 19:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340003.564932; Tue, 31 May 2022 19:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7AW-00013Y-Ve; Tue, 31 May 2022 19:04:40 +0000 Received: by outflank-mailman (input) for mailman id 340003; Tue, 31 May 2022 19:04:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7AV-00013S-PW for xen-devel@lists.xenproject.org; Tue, 31 May 2022 19:04:39 +0000 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8418e4b0-e114-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 21:04:38 +0200 (CEST) Received: by mail-qk1-f170.google.com with SMTP id l82so13910601qke.3 for ; Tue, 31 May 2022 12:04:38 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id x4-20020a05622a000400b002f39b99f67fsm10243003qtw.25.2022.05.31.12.04.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 12:04:35 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id l204so14829617ybf.10 for ; Tue, 31 May 2022 12:04:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8418e4b0-e114-11ec-bd2c-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1ZeGJTUXZPxAO5jhONwtVhilmc3GtYxBhVB9MqXOe9g=; b=bbNuy6GGnqhCzxdm5M5AYNaFP6sF5iSssQSZWQQVM9IEsPCp/XoC/WIOIx2v8/ipJl RCPDsDzvhdP3Dcy3/c72z7+v1hgM10HeUi5pn5cMvtmeWt+aMtYtBqH96N2wWwpflhWH 0JRK6GXBCqWLO/vBHZnRkbvKOv/ULc/cB8zTp8wr8SZYHTT74M79vUQ7f0hYEdUd7xUy pxpieQoKTnhmS2N0Xfx15P7tTGz1ctwmNycZuBdnRKwcMs8yqYRrzIOiFDZsXuQNSBHJ lmEHh2XgDmeVjkPYSCKinOebwkw2JcE2v3PUga/1COjybUns+ZoqrrI14bWVhfBX+2lc 5YiQ== X-Gm-Message-State: AOAM5304pcj1Q2/2qY/cnPwl6pcIc5emT9AOZ9BZ+qmZ5s4e3usEKxfW q5SVRNt3sNuXhfDLaO+kLSoEUGXGe4+uag== X-Google-Smtp-Source: ABdhPJxyqeVu0LSkHESkSCAU1VXDRr7WuU91RAaM4FMLTufljhoC7v+acq7a1DnFfvoyNStI+mdRfA== X-Received: by 2002:a37:a642:0:b0:6a3:5952:c044 with SMTP id p63-20020a37a642000000b006a35952c044mr36488156qke.770.1654023876508; Tue, 31 May 2022 12:04:36 -0700 (PDT) X-Received: by 2002:a05:6902:905:b0:64a:2089:f487 with SMTP id bu5-20020a056902090500b0064a2089f487mr61384058ybb.202.1654023864081; Tue, 31 May 2022 12:04:24 -0700 (PDT) MIME-Version: 1.0 References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-17-dmitry.osipenko@collabora.com> In-Reply-To: <20220509233235.995021-17-dmitry.osipenko@collabora.com> From: Geert Uytterhoeven Date: Tue, 31 May 2022 21:04:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 16/27] m68k: Switch to new sys-off handler API To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dmitry, On Tue, May 10, 2022 at 1:34 AM Dmitry Osipenko wrote: > Kernel now supports chained power-off handlers. Use > register_power_off_handler() that registers power-off handlers and > do_kernel_power_off() that invokes chained power-off handlers. Legacy > pm_power_off() will be removed once all drivers will be converted to > the new sys-off API. > > Normally arch code should adopt only the do_kernel_power_off() at first, > but m68k is a special case because it uses pm_power_off() "inside out", > i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing]= , > while it's machine_power_off() that should invoke the pm_power_off(), and > thus, we can't convert platforms to the new API separately. There are onl= y > two platforms changed here, so it's not a big deal. > > Acked-by: Geert Uytterhoeven > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko Thanks for your patch, which is now commit f0f7e5265b3b37b0 ("m68k: Switch to new sys-off handler API") upstream. > --- a/arch/m68k/emu/natfeat.c > +++ b/arch/m68k/emu/natfeat.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -90,5 +91,5 @@ void __init nf_init(void) > pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16, > version & 0xffff); > > - mach_power_off =3D nf_poweroff; > + register_platform_power_off(nf_poweroff); Unfortunately nothing is registered, as this is called very early (from setup_arch(), before the memory allocator is available. Hence register_sys_off_handler() fails with -ENOMEM, and poweroff stops working. Possible solutions: - As at most one handler can be registered, register_platform_power_off() could use a static struct sys_off_handler instance, - Keep mach_power_off, and call register_platform_power_off() later. Anything else? Thanks! > --- a/arch/m68k/mac/config.c > +++ b/arch/m68k/mac/config.c > @@ -12,6 +12,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -140,7 +141,6 @@ void __init config_mac(void) > mach_hwclk =3D mac_hwclk; > mach_reset =3D mac_reset; > mach_halt =3D mac_poweroff; > - mach_power_off =3D mac_poweroff; > #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP) > mach_beep =3D mac_mksound; > #endif > @@ -160,6 +160,8 @@ void __init config_mac(void) > > if (macintosh_config->ident =3D=3D MAC_MODEL_IICI) > mach_l2_flush =3D via_l2_flush; > + > + register_platform_power_off(mac_poweroff); > } This must have the same problem. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds From xen-devel-bounces@lists.xenproject.org Tue May 31 19:07:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 19:07:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340013.564943 (Exim 4.92) (envelope-from ) id 1nw7D3-0001hM-G0; Tue, 31 May 2022 19:07:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340013.564943; Tue, 31 May 2022 19:07:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7D3-0001hF-Cu; Tue, 31 May 2022 19:07:17 +0000 Received: by outflank-mailman (input) for mailman id 340013; Tue, 31 May 2022 19:07:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7D2-0001h9-5r for xen-devel@lists.xenproject.org; Tue, 31 May 2022 19:07:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0a2dbe1-e114-11ec-837f-e5687231ffcc; Tue, 31 May 2022 21:07:14 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 15:07:10 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6790.namprd03.prod.outlook.com (2603:10b6:303:178::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 19:07:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 19:07:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0a2dbe1-e114-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654024034; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6fmpXhd8Nkq59qOHrKEQ95y2cZuWs+vh0baw+s8478k=; b=elByjeEtqH8e2ZJFNE+B1wV4TWdpmAtTsx9XDYDofdCGRjXvQ+GRgJSC 1Zw9pfRPfFp+L6/2UTwjzb7x2Fyjny/rJThIUXQzfjazx00f+qU8e2RBT ug8xVsjUkWwPG3/jmhXs8rFQSnuTNQUJFUIh7zV7IkfvrqjsxZbEv9GvI U=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 72956401 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8TGbKa/Ddpr3FK7DIYtdDrUDU3+TJUtcMsCJ2f8bNWPcYEJGY0x3z GYfXTuCPviCazfzeNlwbtmw9x5T6pTSmtAxSAVl+Sg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPgW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCna6ZWykPAI6VpPoEYTBSNn1aAK9l1paSdBBTseTLp6HHW13F5qw0SWsQbcgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHviMvIACtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK//tqvTSLlWSd1pDqb9jFW4ylffxPg3SBg EfZ/G++IDwFYYn3JT2ttyjEavX0tS/jQ4cTCL2Q/+ZnmkGO3XcUDAAKVFy9ur+yjUvWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS8wqK1raS7w+HB3MsVSJIctgvvok3QlQC3 V+Tnsj1AiRvvafTQnaU7LS8ti+7IywcJykDYkcsTwID78PyvYIbgRfGT9IlG6mw5vX5Fj39z CqDhDQvjLUUy8gQ3uO0+k6vvt63jp3ATwpw7AOHWGugt1l9fNT8ONbu7kXH5/FdKorfVkOGo HUPh8mZ6qYJEI2JkyuOBu4KGdlF+sq4DdEVunY3d7FJythn0yfLkVx4iN2mGHpUDw== IronPort-HdrOrdr: A9a23:BdytmKxWK1rVh+q9hWn3KrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2RYUh27D3xnklWavo3RiKmrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.91,266,1647316800"; d="scan'208";a="72956401" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bnqB7lnZVQ4N2RJsJwfcdM1ZwMpWgOOwWyIW+w003SSwkn31KZbhXVCZJLdXr4udBwbMch9sZKPEsyBIIYM1heGFVzWmZxrvhWxDABd3IuqDEaiKS/wLncm0d+Kk0ztcXbnf8h3Boy0geTfBzvy4/7xHjQOpEqc8gRb/dmuTw+JNPr7Qf+Zi2Ix+4veN4da33yj8gT8UZbeYSxdEU1AIAtucBchxqb9nMJlt0TDUH6BSbYQg/wMQHfLlDRlMcW+dG9ulG4nDI+MavY+yg59Xqc5M+gPDk8a2jSAuRoAm94/1XyBcVAQL3+RvicvpkfxhDuNKx69JNqM80MYg8uukhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6fmpXhd8Nkq59qOHrKEQ95y2cZuWs+vh0baw+s8478k=; b=Z+GalL5xZs8QNc94wVsDXd7Y5JTFkxiI1brVgJQ7Ac9YLZBuAsSYQkkpf/6xA8lBeRamfJPn2VEt7A7kJlSq4St4Jtkr9K93p5Cp9ypyKRCxZA0U8Ah2OA7iTnSz2h+S2DyBXGQvQAUKvdHJWQxFsRuMtG2Cz68Cr4o4Q4LgAikJvEuNpLw/SVhjVlEVxSuZ63rydQ/gKGwPeGstt5eryf35Q3+v0xRp80lofcwavmbqBiN+/FgDhAVDU5I1gCj4yGO4P83AJtOmFvM69W2+0fajlIUlXs8kuLksqGQJ+YH6SxIHMAzl+ZYlur80njQLH8Hpb7EkSBB7cyv/oCizww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6fmpXhd8Nkq59qOHrKEQ95y2cZuWs+vh0baw+s8478k=; b=gF/sykDVdV3EGEhD/7nT0IY8EdAk6R4n35/DDiEDgCs6+KvrBaEN34eQmj7gFwKz+xJqbSpVEi/fu4Gnfuhcc2JIL9HpqD65TrZJ1MBqY+/AzkEngTrRghnSoZb3CoAEORx6dRZqvE0HHkssZc/toQAgtmox7faCFmqXNZtjOWI= From: Andrew Cooper To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "jandryuk@gmail.com" , Daniel De Graaf Subject: Re: [PATCH v4 2/3] xsm: consolidate loading the policy buffer Thread-Topic: [PATCH v4 2/3] xsm: consolidate loading the policy buffer Thread-Index: AQHYdRttYyzERFwD3EWagofaBthvzK05WQKA Date: Tue, 31 May 2022 19:07:04 +0000 Message-ID: <6f177e81-9c97-0f7f-2f79-88cc4db83e02@citrix.com> References: <20220531182041.10640-1-dpsmith@apertussolutions.com> <20220531182041.10640-3-dpsmith@apertussolutions.com> In-Reply-To: <20220531182041.10640-3-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 518f84a7-ebc2-441b-6581-08da4338c00a x-ms-traffictypediagnostic: CO3PR03MB6790:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fyU3ZiI8VeHmDxFw/L7vM1O+8vEyQ5C+pSBMdJcdAP3H1ZsrLa3eK9QvLUd+8ztT1MnPGA66jpjMFyPnCkHTPPwkTLKy/IcRU90O1BPXyHdCViQ7uHbZyJQ1GLwqteZSDnh6/bx2zuLv2AwnKj0hqAEoSpuw5VBfsXDToL1k2Ee2LHqEHAzoGCrxEZREeie3pEPZA4VuJ/VfjiKiIIirK+qwp0C4QDX7Vx0n9z1i/TzpXkwRLOmeTUnCridktJPXWbDorWL4r3peeNDJGwtVW/4wYMFQFiG9e0kL447NO3ny116WLuTLFvZA5dDnThEDMZcBImGwlI1h51Yo64TjTeV+tURYco7arq8EJBiSU2vfsLtHTb/96r8dzCZ1/qgxBoyntYK2qLrllXip+8Rqsrr7Ljv6oRRLjmXFD8MZyFLcJ8n9+xkp3rn0wXGDpvS+1J5dQ9uXQdFwu6FVY4o7W+JZ577a3e7lHS3DLpZf12q/x2Gu2lgH8g4MUttWZNTthj2AlMrlzeFS95FvIXybW9KI13OfhSg3RPafKeAk/2fvpZbKWd9Nl43eohpB481kwcAuoU9q8/5LDPbAuvLe9OfRL5I0zI2hYsP9iBT0MF1DqVtWuyi7B1oukfiv2KACiInus7JE/7pgKzM7UJxvmCZG1oZEa08sNqcQVPhuIHSfAvd76g+EdAzxtUsQNVEgu90BrkmSIuB2sZ4i3uo48bykf6OouI4XXdIZqnxbNHqCPMnwVQpmlvbbv9Iw4EgCvIdQlP3IgwQ/bqF3ZWRKhfJB2tngdrGaEmmzsK65byc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(508600001)(122000001)(6512007)(36756003)(26005)(6506007)(38070700005)(31696002)(53546011)(71200400001)(86362001)(38100700002)(2616005)(186003)(54906003)(76116006)(110136005)(31686004)(66446008)(8676002)(66476007)(66946007)(82960400001)(66556008)(8936002)(64756008)(91956017)(5660300002)(2906002)(6486002)(316002)(4326008)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S1FsSTV6Z0pTWkdjRHFZMzFCM2lzSTREOVlWM2NaUFZJbzRNdllYZFpYQWFN?= =?utf-8?B?VVNVc1ZMMlpvUiswKy9zdE9FZDlONjVxMVQ1TVdWbm9wOGhOQW9lcUFMQTRm?= =?utf-8?B?RzJLWEZ2ck40Z25oOUNFVXpFYWZ3TVpJYU53OXJmd1dLUUdXYXh3Zzc2K2lv?= =?utf-8?B?SnZlL3BMTGhqUGNMTGtaa2szdFdWTks1RmkvcVZCeVVRNC9VeTNmNGcvUVdL?= =?utf-8?B?U2tPZmdZV3NlaTNnR3NsUE8rSmptdU9vMU9hSElVdmI5ekdvWjZaVlM3OVZB?= =?utf-8?B?VUhNL003N0xOeVZET1NpWWcra0ErQ21hS05JZERDRHNiYU5vMnZnTlpYR04x?= =?utf-8?B?YVhtTUJMRm1qR0VtdndyOU1CMHlxY0hnS0lTcHZiRGx0NHdaSVBDN3dqOUda?= =?utf-8?B?NEJkbUE3dWFybGZkNVp6TnRFaU5YYUQvcktuejZpOXlzZUMzVUp5cEcwQU1q?= =?utf-8?B?NDVrOTFoVFZLOFpnZW5MaWVabStPVGFMZ2ZMeHVmQTEwbkNzSmx3Z2lJN3hM?= =?utf-8?B?TUZBQnRNQVhhYTladXhsY0dLTVhwMXFUdjVUblZMbVZTMVZuRDJtNFpCU0pw?= =?utf-8?B?NDIxOGN4Um9FOVJldmgxQXZJaEtpMG40NVRUMVN4ZEtKODdiZ0VWRUxQMUdC?= =?utf-8?B?SzlSWlI1MlJaYk9sdkdRYzNMbjlxcTBpS1lSMENwZW1iVGVReXhRR3ZNUTI1?= =?utf-8?B?SmJTU3FoU3RHd1dGcGw4NEh3NTJubVpXTHBWM3d0a204SlREbEVHRHhEK2Za?= =?utf-8?B?K3ZvME8yYjlrd2l2S2FUTVFWNGJ5QnpUWTNIczlnSTRSSnVuM1NHaXQvNUVZ?= =?utf-8?B?R20rdkFLU0FvOGNMNjRnOTh3YlNZaVc4dGhsSzdFeWQ4UVlEVkxUZWFFejFy?= =?utf-8?B?NjIvNWUrbXpJbWN4WEZNV2xFV2luTU1QT0dNV1ZvOGhrVXluTkdkclhjNmZF?= =?utf-8?B?V1ZVZkwzSDBUeURkSjBUSjNncFRzeTRsM2JSQmt6SWpmbXpJREhaWGR2Yzd4?= =?utf-8?B?eWtRVXdCeVp5bE0vK25ybHdyRTBEYXZHODhST1l3dnlJWDUxb2RQVDh1Qkh1?= =?utf-8?B?Wi96RWVuZ2NFdzRIRkw2UDQ1b2xMeUVseEhpOURxVEdDbzJDSDNmcWtrNUFm?= =?utf-8?B?ejJTbnBmRm9WaVFKR3VaNk1GNW1XbFF1ZkRTMlRHOXlWaXhOb0Z3b2gxTFJQ?= =?utf-8?B?Q1M2b0pXdU9RK3pmL1FGM1l0Z096Q0hENXRtSEpHYnhmVEFneFdmb2R5REkx?= =?utf-8?B?cGl6MldMYnpTZXlRa0FDaHB1SkppZ3NMcXpIZnNaSXBwaW5xczFqMEZyL0hp?= =?utf-8?B?U2g1QzBxdk5KYkNKdnVuR0E5VTdCejNyVkNXZGFVMHFvRnFmd2xTTXB4OG1P?= =?utf-8?B?M3JVUG9qVVVkM3E0MjV4QlFieUdwRXVDMGpIR0dwd0xHSE5JT1pieW5iaCtI?= =?utf-8?B?SHhCbXRTUmphZXhQYTZkUTFLRnNwaHJLN25zeXJTMWEyRGNlTkNEdms0SHVS?= =?utf-8?B?ZTZLU2xtV1h2bnl5THFReVAzRzN5QTVwM0hWTFFWUm1qZlp1Rk5aejJpYmJ5?= =?utf-8?B?S0JRMXNjeW5YZGcrVk56cmM5ZFVPU1ZYT0JnN3MwUWJBbUNDS2wzOVRuL3Nu?= =?utf-8?B?Y3FaejZ3SE9CakRYVFdVbExWaG94eDJ4TE5jejhJK29OemkzODd1SnBPWFRz?= =?utf-8?B?bmFpbG5yNzcxYkI1V1NDTVRPUzlTYmhPRFBWSmErWUpzUG81NkZJQkQyUVJ3?= =?utf-8?B?YzI1eTVVRExHT1JFYVhvZDFBclJzY2Y1NXdNVDYwTk96MW4zbjRrYmJsS2ds?= =?utf-8?B?akhJSVFBTGZ0UVRTYVVyNFMrRk9Wem1ySW5yQWxMVXNWaHBvMWhpZlRTeG9V?= =?utf-8?B?eGd6Qmg1dDRxeVp6azEraW1mVm1hNlRlditOQUQ1UEUyTG0vZ25ORy8rSGFK?= =?utf-8?B?ZGFlS2hNQkpIdlJaREhicy9BMzlhelhtNldQQnZ4eHY3S0dOZG5vckZ1S0dV?= =?utf-8?B?MHlacThPSVh6TkRxejlaWitXbm1GTDg5aE91ZG9sWGNlQXh6bDNpS3hGK0hI?= =?utf-8?B?WHoxOTdxOGNMNjVpRUxmaFJmUzhSb2pOR2lpYnArUmxjdWd2cnhyTTV3QkVt?= =?utf-8?B?V0hOU2lPL01TaHByR0hBN3hsV21DWG13R3JwTllGUVRxV2s5UGxzS0xWNkpX?= =?utf-8?B?emp4TTlwRjBmNVFKR0J3MWY4cXRQSVRBMm9KdGtDY3pubU1LVW9BS01IcXFl?= =?utf-8?B?WGs5NGZnMEo5U2FTR0t1OFd4MU8ydmRteGZlSW9ISkNtaVJVOGQxdEhCRTR0?= =?utf-8?B?d3pzUHJ5dnBraW55azhINldoL2JIci9lRXovbFMvVEJiaHY1MXd2NUo2Y0ND?= =?utf-8?Q?s3YlvvjJqifTezS4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 518f84a7-ebc2-441b-6581-08da4338c00a X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 19:07:04.4857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DLgGpGLH65X1gessWszPsoQ/HWuWmn8Pi/p7O/IJeeIfCjqYXtsd4IBCKMQhrZVsLPPDbZHv096Am2eKNlpn3J+3RDTHdM0KsaIiHiz7zQU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6790 T24gMzEvMDUvMjAyMiAxOToyMCwgRGFuaWVsIFAuIFNtaXRoIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEveGVuL3hzbS94c21fcG9saWN5LmMgYi94ZW4veHNtL3hzbV9wb2xpY3kuYw0KPiBpbmRleCA4 ZGFmYmM5MzgxLi42OTBmZDIzZTlmIDEwMDY0NA0KPiAtLS0gYS94ZW4veHNtL3hzbV9wb2xpY3ku Yw0KPiArKysgYi94ZW4veHNtL3hzbV9wb2xpY3kuYw0KPiBAQCAtOCw3ICs4LDcgQEANCj4gICAq ICBDb250cmlidXRvcnM6DQo+ICAgKiAgTWljaGFlbCBMZU1heSwgPG1kbGVtYXlAZXBvY2gubmNz Yy5taWw+DQo+ICAgKiAgR2VvcmdlIENva2VyLCA8Z3Njb2tlckBhbHBoYS5uY3NjLm1pbD4NCj4g LSAqICANCj4gKyAqDQo+ICAgKiAgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBj YW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkNCj4gICAqICBpdCB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMiwNCj4gICAqICBh cyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbi4NCj4gQEAgLTMyLDE0 ICszMiwyMSBAQA0KPiAgI2lmZGVmIENPTkZJR19NVUxUSUJPT1QNCj4gIGludCBfX2luaXQgeHNt X211bHRpYm9vdF9wb2xpY3lfaW5pdCgNCj4gICAgICB1bnNpZ25lZCBsb25nICptb2R1bGVfbWFw LCBjb25zdCBtdWx0aWJvb3RfaW5mb190ICptYmksDQo+IC0gICAgdm9pZCAqKnBvbGljeV9idWZm ZXIsIHNpemVfdCAqcG9saWN5X3NpemUpDQo+ICsgICAgY29uc3QgdW5zaWduZWQgY2hhciAqKnBv bGljeV9idWZmZXIsIHNpemVfdCAqcG9saWN5X3NpemUpDQo+ICB7DQo+ICAgICAgaW50IGk7DQo+ ICAgICAgbW9kdWxlX3QgKm1vZCA9IChtb2R1bGVfdCAqKV9fdmEobWJpLT5tb2RzX2FkZHIpOw0K PiAtICAgIGludCByYyA9IDA7DQo+ICsgICAgaW50IHJjID0gLUVOT0VOVDsNCj4gICAgICB1MzIg Kl9wb2xpY3lfc3RhcnQ7DQo+ICAgICAgdW5zaWduZWQgbG9uZyBfcG9saWN5X2xlbjsNCj4gIA0K PiArI2lmZGVmIENPTkZJR19YU01fRkxBU0tfUE9MSUNZDQo+ICsgICAgLyogSW5pdGlhbGx5IHNl dCB0byBidWlsdGluIHBvbGljeSwgb3ZlcnJpZGVuIGlmIGJvb3QgbW9kdWxlIGlzIGZvdW5kLiAq Lw0KPiArICAgICpwb2xpY3lfYnVmZmVyID0geHNtX2ZsYXNrX2luaXRfcG9saWN5Ow0KPiArICAg ICpwb2xpY3lfc2l6ZSA9IHhzbV9mbGFza19pbml0X3BvbGljeV9zaXplOw0KPiArICAgIHJjID0g MDsNCj4gKyNlbmRpZg0KDQpEb2VzDQoNCmlmICggSVNfRU5BQkxFRChDT05GSUdfWFNNX0ZMQVNL X1BPTElDWSkgKQ0Kew0KwqDCoMKgIC4uLg0KfQ0KDQpjb21waWxlIHByb3Blcmx5P8KgIFlvdSds bCBuZWVkIHRvIGRyb3AgdGhlIGlmZGVmYXJ5IGluIHhzbS5oLCBidXQgdGhpcw0Kd291bGQgYmUg YSBiZXR0ZXIgYXBwcm9hY2ggKG1vcmUgY29tcGlsZXIgY292ZXJhZ2UgaW4gbm9ybWFsIGJ1aWxk cykuDQoNClNhbWUgZm9yIHRoZSByZWxhdGVkIGh1bmsgb24gdGhlIERUIHNpZGUuDQoNCj4gKw0K PiAgICAgIC8qDQo+ICAgICAgICogVHJ5IGFsbCBtb2R1bGVzIGFuZCBzZWUgd2hpY2hldmVyIGNv dWxkIGJlIHRoZSBiaW5hcnkgcG9saWN5Lg0KPiAgICAgICAqIEFkanVzdCBtb2R1bGVfbWFwIGZv ciB0aGUgbW9kdWxlIHRoYXQgaXMgdGhlIGJpbmFyeSBwb2xpY3kuDQo+IEBAIC01NCwxMyArNjEs MTQgQEAgaW50IF9faW5pdCB4c21fbXVsdGlib290X3BvbGljeV9pbml0KA0KPiAgDQo+ICAgICAg ICAgIGlmICggKHhzbV9tYWdpY190KSgqX3BvbGljeV9zdGFydCkgPT0gWFNNX01BR0lDICkNCj4g ICAgICAgICAgew0KPiAtICAgICAgICAgICAgKnBvbGljeV9idWZmZXIgPSBfcG9saWN5X3N0YXJ0 Ow0KPiArICAgICAgICAgICAgKnBvbGljeV9idWZmZXIgPSAodW5zaWduZWQgY2hhciAqKV9wb2xp Y3lfc3RhcnQ7DQoNClRoZSBleGlzdGluZyBsb2dpYyBpcyBob3JyaWJsZS7CoCBUbyBzdGFydCB3 aXRoLCB0aGVyZSdzIGEgYnVmZmVyIG92ZXJydW4NCmZvciBhIG1vZHVsZSBvZiBmZXdlciB0aGFu IDQgYnl0ZXMuwqAgKFNhbWUgb24gdGhlIERUIHNpZGUuKQ0KDQpJdCB3b3VsZCBiZSBzbGlnaHRs eSBsZXNzIGhvcnJpYmxlIGFzDQoNCmZvciAoIC4uLiApDQp7DQrCoMKgwqAgdm9pZCAqcHRyOw0K DQrCoMKgwqAgaWYgKCAhdGVzdF9iaXQoaSwgbW9kdWxlX21hcCkgfHwgbW9kW2ldLm1vZF9lbmQg PCBzaXplb2YoeHNtX2hlYWRlcikgKQ0KwqDCoMKgIMKgwqDCoCBjb250aW51ZTsNCg0KwqDCoMKg IHB0ciA9IGJvb3RzdHJhcF9tYXAoLi4uKTsNCg0KwqDCoMKgIGlmICggbWVtY21wKHB0ciwgWFNN X01BR0lDLCBzaXplb2YoWFNNX01BR0lDKSkgPT0gMCApDQrCoMKgwqAgew0KwqDCoMKgIMKgwqDC oCAqcG9saWN5X2J1ZmZlciA9IHB0cjsNCsKgwqDCoCDCoMKgwqAgKnBvbGljeV9sZW4gPSBtb2Rb aV0ubW9kX2VuZDsNCg0KwqDCoMKgIMKgwqDCoCAuLi4NCsKgwqDCoCDCoMKgwqAgYnJlYWs7DQrC oMKgwqAgfQ0KDQrCoMKgwqAgYm9vdHN0cmFwX21hcChOVUxMKTsNCn0NCg0KYmVjYXVzZSBhdCBs ZWFzdCB0aGlzIGdldHMgcmlkIG9mIHRoZSBpbnRlcm1lZGlhdGUgdmFyaWFibGVzLCB0aGUgYnVm ZmVyDQpvdmVycnVuLCBhbmQgdGhlIGF3a3dhcmQgY2FzdGluZyB0byBmaW5kIFhTTV9NQUdJQy4N Cg0KVGhhdCBzYWlkLCBpdCdzIHN0aWxsIHVuY2xlYXIgd2hhdCdzIGdvaW5nIG9uLCBiZWNhdXNl IGhhc194c21fbWFnaWMoKQ0Kc2F5cyB0aGUgaGVhZGVyIGlzIDE2IGJ5dGVzIGxvbmcsIHJhdGhl ciB0aGFuIDQgKGFzc3VtaW5nIHRoYXQgaXQgbWVhbnMNCnVpbnQzMl90LsKgIHBvbGljeWRiX3Jl YWQoKSB1c2VzIHVpbnQzMl90KS4NCg0KQWxzbywgcG9saWN5ZGJfcmVhZCgpIHVzZXMgbGUzMl90 b19jcHUoKSBzbyB0aGUgbXVsdGlib290L2R0IGNoZWNrcyBhcmUNCndyb25nIG9uIGJpZy1lbmRp YW4gc3lzdGVtcy4NCg0KQWxzbyBhbHNvLCBwb2xpY3lkYl9yZWFkKCkgcmVhbGx5IGRvZXNuJ3Qg bmVlZCB0byBtYWtlIGEgdGVtcG9yYXJ5DQptZW1vcnkgYWxsb2NhdGlvbiB0byBjaGVjayBhIGZp eGVkIHN0cmluZyBvZiBmaXhlZCBsZW5ndGguwqAgVGhpcyBpcw0KaG9ycmlibGUuDQoNCkkgc3Vz cGVjdCB3ZSdyZSBnZXR0aW5nIGludG8gImluIGEgc3Vic2VxdWVudCBwYXRjaCIgdGVycml0b3J5 IGhlcmUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue May 31 19:18:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 19:18:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340023.564954 (Exim 4.92) (envelope-from ) id 1nw7O6-0003MK-K3; Tue, 31 May 2022 19:18:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340023.564954; Tue, 31 May 2022 19:18:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7O6-0003MD-Gh; Tue, 31 May 2022 19:18:42 +0000 Received: by outflank-mailman (input) for mailman id 340023; Tue, 31 May 2022 19:18:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7O5-0003M7-DU for xen-devel@lists.xenproject.org; Tue, 31 May 2022 19:18:41 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 790bd1d4-e116-11ec-837f-e5687231ffcc; Tue, 31 May 2022 21:18:39 +0200 (CEST) Received: from mail-sn1anam02lp2046.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2022 15:18:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6330.namprd03.prod.outlook.com (2603:10b6:303:11d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 31 May 2022 19:18:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::50a2:499b:fa53:b1eb%5]) with mapi id 15.20.5293.019; Tue, 31 May 2022 19:18:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 790bd1d4-e116-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654024719; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FHHPmNQdu/8LaseeoLzbafUTfMJua3Vle91SravkGVY=; b=MoCEFbDOdjuu3iClLwDVuk9jzzB1f6rU0wBI3s+y5cQiInU3WV4EhRMU /FozG/soovZyFBEe7Ck3PRuj80XxSMS2ZpPcSUJHSbgxlsqh6JM9vGiyF 6GqZ2G0i2kSnXNSMROtVSv4Hcp+J29aBZqVVFnjr/ZBP4BpfDUlvAmwvu A=; X-IronPort-RemoteIP: 104.47.57.46 X-IronPort-MID: 72561332 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:C5uJgKJLaIyDXvt3FE+Rh5UlxSXFcZb7ZxGr2PjKsXjdYENS0jdSx 2UYUWHVb63eMGenLtklYIq0pBsF75fSzYVgQAVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA149IMsdoUg7wbRh39Ux2YPR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 PVBhaSwZTY5ApbjnuEAEDxxDyY5D4QTrdcrIVDn2SCS52vvViO2hs5IVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM+FH/uiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2IC9QzM/vFti4TV5C1wj7b8DdXvQfCDettRgQWah F+f3nusV3n2M/Tak1Jp6EmEivfUmCLnWKobDLCi6uNxm1qX23ASDxsNE1C8pJGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JuFOk95BCI27DjyQ+TDWgZTRZMcNUj8sQxQFQCy Vuhj97vQzt1v9W9Unma6qvSoTqsODM9NnMLfysNR00E5LHLq4EpjwnTSc5jHbTzhdn8AzLY2 CyDtiw3jfMSiqYj1ay98UrWnjGEqZ3ATwpz7QLSNkqv4xllfoeja8qt4ELC8PdbBI+DSx+Ku 31ss9OF8OkEAJWJlSqMaOYABrek47CCKjK0qVxyG5gs8Ry99njleppfiBl8Lkp0NscPeRfyf VTe/whW4fd7MHSmYKBtaqqtGs8qyu7mDt2jWffKBueiebB0fQ6DuTpoPEeW1mW1ykw0y/ljZ 9GcbNqmCmscBeJ/1j2qSuwB0LgtgCcj2WfUQpO9xBOiuVaDWEOopX4+GAPmRogEAGms+205L /432xO29ihi IronPort-HdrOrdr: A9a23:W6K8vaOEQOX9nsBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.91,266,1647316800"; d="scan'208";a="72561332" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QwfBOVIDi1ebPb5l6hTGDtMbwR1quoGh+1Dy661VKkEPvJW6JNEAs6BTz7WAOqPSeR9Ph6k1xAFdvTAz/TVoVNt8k0nfj05cEN31d2R6v2oi4JhDyAsHCDQktRrM4eCJC7QF9rtBXvGHTz/Gw8/8PQ2lBghR9pT3k2AUf6U7Ok3TWDmdQGSYDNi7N4FJbrQFv4muZH5v6FeHdh6d/dlRGknPEb/alFAXOE7buiuQGwoznjacscTms/lWnyKO+JjQxFWTYQKx6QlAqpSRhXq8EFNhRau4UxmVykFwO+XR7D8X6O5yNZA9rY3scW0vkEUYgz/DOfhsWhPxDjoIiQH/0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FHHPmNQdu/8LaseeoLzbafUTfMJua3Vle91SravkGVY=; b=moIwngWll1MNwzNKc6yeeO0vdcs5G9mrATYtX2XjLwJmk5zzkqV5G/GIqnaTE3IUf41bXsuok0Pj+UyC0k+w8IEQ4a1YJO7Mq5GaTNy55WKJxuo4dRirYxFG4rNAar+LMUwkosVfJ+MginD1OQ6wBuivcIQdM9CvO2AhGEayUpFCOKzvOYTrIqfByonB5eA1WV1hzvyiRvPSow/j+iTuwVVXbr+/OQkCgZiunwu6Q55YayJin71x8y6wyoRx9U978bL5Bi7pZzh5+eI03u76jt0TjjQC0o/qdqkba7AORio2InskEeF8LUspnHowdDsjyqvG/DHKDNQuNXi/+d0SOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHHPmNQdu/8LaseeoLzbafUTfMJua3Vle91SravkGVY=; b=TDfXgURpsAGawAglmstKHEdZEzthURAeFCsCKuGkJ6fLK792T0zgp0cQhFQ+PBlLtymIFQJoYTkeUYiT6TImTDqn9mjU3/cXlPx07GpEfxh34RUBIh+u3jw/R38mwwJ8Yneyg8GBX9Vo9D/aDIP7L6rW8BMNo1NiZFZyGdNU464= From: Andrew Cooper To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk , Wei Liu CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "jandryuk@gmail.com" , Bertrand Marquis , Stefano Stabellini , Julien Grall , Jan Beulich , Roger Pau Monne , Daniel De Graaf Subject: Re: [PATCH v4 3/3] xsm: properly handle error from XSM init Thread-Topic: [PATCH v4 3/3] xsm: properly handle error from XSM init Thread-Index: AQHYdRtxX+A3YwtAuUu8lGLDBtUPnK05XDiA Date: Tue, 31 May 2022 19:18:33 +0000 Message-ID: References: <20220531182041.10640-1-dpsmith@apertussolutions.com> <20220531182041.10640-4-dpsmith@apertussolutions.com> In-Reply-To: <20220531182041.10640-4-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c967b1f-86ff-4384-dc3b-08da433a5aed x-ms-traffictypediagnostic: MW4PR03MB6330:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YE7PnD5igCgWps/rq3qxUzPskVLfdgwPqJe1XmnTVHWu3QAnLAewIl+KiW6Y4xSKwXMSmyLR5W6DnGiHYBwnlf7JMHfHiFs+HbJ6mQzaEgwbDKe3KNNkSlYixshv+skqh8u1kE2+ANn5y7KUSFFbVb+m8NvBTPwccxxdDXsfY5auDrCLF3rmarYnoTbAiXsihnoq7imN333avoEKfzCyr6woAw+0ouSfpMh+6BnLJq0EFgVjqya1BIJEXTVaF0AORsDBqHaKsb4BnapzKOBNL9bYwKDttm2lAzoPxkQdOkW2TVc2Ju2AiYrQ+PouSe3Jnsu7eSKv7MRzsc9q/+Vf2+WGxjXQPxQEiBsRjD8G28fjE7iHPkHHrfDJwqg73uhFifmoWEaBQmuFMxDhZTUxGIRRT3V4lw/yBEwmNzSbTYQFNIZ/SHBQnEXAeaM7lLk92zvXDTQFLkyoYBoh8tjDJheRw8JIc8fgyv9KIHD3noN+1RM0GcqIgA/mPjZD2EGlRMMRCu34geCMvbl3aVUpXFcYLQ/CvGolzs7c5AJDdmnQ3ZHswcD53huDIgq/APbfBWuXrW5oO6Pe/24qVeKKI1s7OjIpu6ECa8/nPYAf7QQfh1Qx6j+lpbvYtLwaEWiRriC9waz2NfqmtZpO7Rwrbn1OgqOKGppjlLVk2FzHDGO+VIBrgq+4rL6Sy1zmYXahE36R9z+U+QBwB5Ekb543WiDTimo4NsN7aX57kb8mbQCKifT1KO5OAqBZE0BenMswlJI8/FWsSx/ODcGZ6cch3A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(26005)(6512007)(53546011)(6506007)(38070700005)(66556008)(66476007)(110136005)(4326008)(36756003)(316002)(82960400001)(64756008)(122000001)(76116006)(66946007)(91956017)(66446008)(71200400001)(8676002)(31686004)(8936002)(54906003)(6486002)(5660300002)(7416002)(38100700002)(508600001)(2906002)(86362001)(83380400001)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YXNsZFJqQTZHUCsycW9GcmtYVXN6ZzNVM1BhK0FySWROQ1AvcVlWQWRuVWl6?= =?utf-8?B?QXBlRk80cnUzQmxUN2xWYWNnUDJXNUM4M2QvY1VTVkRMYTFQeDdFb2lVUUxz?= =?utf-8?B?Ty9jV2tiOEdhQ2Mxa0JJODNJVzY5dXRXVGVpUkc3ZUVBUTlOTkpJa0RwSFUx?= =?utf-8?B?T1o3R0dtVHF1SGJ0U0VNS3Y5dzVwU3RpazhMVExJOFdXSzVCaW5CbnljTGx2?= =?utf-8?B?Sk01TmJ4bUZNbExQODYwU1BlVENxZ3JsOTcxdlJzOGR6UU02R3N2MFB0ZjA3?= =?utf-8?B?V1hpMi9vRi8wODlBVzJ6L2IwQ2ZPU3djYmNjdkJHanRDcWlpMVpPdUZJa2Jz?= =?utf-8?B?WDhUOFZpZG44NS9mUENORFhObmNkempuN0dNekFHZVd4K29FMTR5VCtsMXFU?= =?utf-8?B?S3RINm05R25Sb1U2WEZYdTNoclZ0Ti95UWV0cWphODZOcWI0YjEwSlVEOHNy?= =?utf-8?B?bXIyVUQ1ZWxWNmxWSzJYZHFheUJxSnNFRUozYVZsMmhPYXBpZzlvbDREUjNj?= =?utf-8?B?TGNDK3ZxOGcwbFpta3M5U1cySFhmV2Q4NU9kUTNpOVJQcG5nTTd4WEpPT083?= =?utf-8?B?cTVWSnNEKzZReGZYRkpMVGowQ2NYOGJBZUFQQnJEekVTYmg2aTlDcGpYYnEv?= =?utf-8?B?czNrd2RJMCtoR1ZJOXo0WmZNZlBzY254MjZnL2lmUWREZEtkVEFtTmxpYmFI?= =?utf-8?B?MW9XN1p1N25QOWVIcUdpSU5sVU9EMGVyRmYwQ2lDMG44aFc1REthQ1lKN2lQ?= =?utf-8?B?NkpPTTB3MDFBQU85YVkvOWNXdWdiOHVHNjBxOEVJRmg2T0JYcXBWV2ZlQkNp?= =?utf-8?B?dWI5VjZHYlVqQk9DWDdwOGxFdkFRb2hCVmhsSUtEWmFlUFdWNnQzZXVuYjhN?= =?utf-8?B?b2RWSitzV3FvVkR2bURaWXFkMVAzdEUydzBVeWhtQ1hOMFEyNjNmTkpwcmFN?= =?utf-8?B?THhHRi9vZ1hld3N5S3djaXZEWXJIUldPSzQwS1N1bmJScFhPRkwzN05sL2pp?= =?utf-8?B?OHRqdlA3UnBNMXdnMGZaemtReS9XT1cvQnNYQ3VacnR2c0lMaFI1NzFoSENx?= =?utf-8?B?WUNjNzh1QW96Rmp1eHVnV29UQ2pSeXVuYU95aEgwWUVKT3hST0FtenNQRlVr?= =?utf-8?B?U0JjNHUyRkEzWUh3NTdjY1JuZVVnYWg3Q0ZmWWY1eFc0TEVKbk1IazF6cDY3?= =?utf-8?B?WUNsYmJpc2xmWHVOdDVGM3ZKRDJBUzMrWnU5NXdlckFYRjVDRGNJaEVNS1ZL?= =?utf-8?B?Mk9zVithRlhSNUVVemFmRTZ1SVBIdnpRZzJzVDNHQUxHeEFrNERialNYbkJv?= =?utf-8?B?NnJ0L2krV2QvSEx1OU5ocVZac3hVTThVZWJ3WjlnRDBvSjUyQ2xnMUlOMW96?= =?utf-8?B?YVpPdU9lUDY0VVdTYm5tVjJpcVp0MkhqbG9JK1RiY0hmbFJmRVlvNG1jMHhY?= =?utf-8?B?L0ZZQ0JqT2VEWGJBUm8vU2VIU1JwYTl3ZzEwdzdzL2tlVHpXUS9mU1pwbUpL?= =?utf-8?B?ZVhHUkNWbFNFSmdYYmpmWjhnV0FSbUg4NnAxaXBCT1R5eDI4ZWJqTCsrcG95?= =?utf-8?B?WWx1UXFBRm13MUc3TWVWdDBWbmlQL3Z5STkxMDZ4VXYxMWNTWFd1VjQ3eUU5?= =?utf-8?B?N3ZMby90TVI4S3k0VW9rWHlpd3QvK25uODlDeGgyRWt0THFjclJ2d2RsMWht?= =?utf-8?B?eFplOVEyYzFGRU5LMWUxQ3liMHVvK2o0UEtUY2NCYWZSTWtwK29QUWNJaTBw?= =?utf-8?B?d0FUdmpGYjcwNDNYN0dxMVUvbExPM3BTL3BGM1Y2L2krUTRzb1JPSHg5UWF3?= =?utf-8?B?YXhFOXZPUW05NlRveEc3VUg1ZHdhbHJ6VThtZ3dtcnV6blJPYittWTFnL0dq?= =?utf-8?B?bjFDNmoyQVlGQVRZd0NsL0d5Yi94WnhFTzNjTk02SlJRcWpDUkpBZkNCd3pX?= =?utf-8?B?WkdjV21sU2VwK3V6RG15TTIrK0s5dEdTczZHaXFSRmtIU1JjNHg5NE1hbDlz?= =?utf-8?B?N1NnZXE4L3BjYXBnUkNXUXRHeXlYVUY5MEtvQk0yejR3enJqVWpBRWIzMTBr?= =?utf-8?B?YitlZzFSUFp4blorelkrYkQ5akw5RjFxb3hPa3l5NE05RGM0dk54K0VBQVFv?= =?utf-8?B?U0VFUE5hQWp5c0Y1OWZ3UkFCeEptTjBRR1RJTk8welZLZTM2aTFDcTNXQjdC?= =?utf-8?B?QzhHbmJSelB6RUZucXM0NTlWN1NQTVZJdURSRU1IcEdoUGdOazZjK2dIejF2?= =?utf-8?B?NWl1RytCbmJXY0VuQWExV0VrK1hZV1VrSEcxTzB5R3cyai91eEJ6QmhjTzdL?= =?utf-8?B?akxnTUpLbEx6TXdHUXJuWUh2NW5iVFB2VTVSZHZWREJNZjNoUThybk1IaGg0?= =?utf-8?Q?jJJgOpe/85t7khWs=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <89ED2E496A8DEF4B9BE30133F77073BD@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c967b1f-86ff-4384-dc3b-08da433a5aed X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 19:18:33.8579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xxLdpEvAUQZYf2LqHJsEDurjIsl5vIk31XjZwx80yUa5nTjeLk4r0KMz3K2D/haWpwlSvbI8aq4CXvwPkbRb6rhmBaJgmkTahwNQVAfW7tc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6330 T24gMzEvMDUvMjAyMiAxOToyMCwgRGFuaWVsIFAuIFNtaXRoIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gveDg2L3NldHVwLmMgYi94ZW4vYXJjaC94ODYvc2V0dXAuYw0KPiBpbmRleCA1 M2E3MzAxMGUwLi5lZDY3YjUwYzlkIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvc2V0dXAu Yw0KPiArKysgYi94ZW4vYXJjaC94ODYvc2V0dXAuYw0KPiBAQCAtMTcwMCw3ICsxNzAxLDExIEBA IHZvaWQgX19pbml0IG5vcmV0dXJuIF9fc3RhcnRfeGVuKHVuc2lnbmVkIGxvbmcgbWJpX3ApDQo+ ICAgICAgbW1pb19yb19yYW5nZXMgPSByYW5nZXNldF9uZXcoTlVMTCwgInIvbyBtbWlvIHJhbmdl cyIsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkFOR0VTRVRGX3ByZXR0 eXByaW50X2hleCk7DQo+ICANCj4gLSAgICB4c21fbXVsdGlib290X2luaXQobW9kdWxlX21hcCwg bWJpKTsNCj4gKyAgICBpZiAoIHhzbV9tdWx0aWJvb3RfaW5pdChtb2R1bGVfbWFwLCBtYmkpICkN Cj4gKyAgICAgICAgd2FybmluZ19hZGQoIldBUk5JTkc6IFhTTSBmYWlsZWQgdG8gaW5pdGlhbGl6 ZS5cbiINCj4gKyAgICAgICAgICAgICAgICAgICAgIlRoaXMgaGFzIGltcGxpY2F0aW9ucyBvbiB0 aGUgc2VjdXJpdHkgb2YgdGhlIHN5c3RlbSxcbiINCj4gKyAgICAgICAgICAgICAgICAgICAgImFz IHVuY29udHJvbGxlZCBjb21tdW5pY2F0aW9ucyBiZXR3ZWVuIHRydXN0ZWQgYW5kXG4iDQo+ICsg ICAgICAgICAgICAgICAgICAgICJ1bnRydXN0ZWQgZG9tYWlucyBtYXkgb2NjdXIuXG4iKTsNCg0K VGhlIHByb2JsZW0gd2l0aCB0aGlzIGFwcHJvYWNoIGlzIHRoYXQgaXQgZm9yY2VzIGVhY2ggYXJj aGl0ZWN0dXJlIHRvDQpvcGVuY29kZSB0aGUgZmFpbHVyZSBzdHJpbmcsIGluIGEgZnVuY3Rpb24g d2hpY2ggaXMgdmVyeSBidXN5IHdpdGggb3RoZXINCnRoaW5ncyB0b28uDQoNCkNvdWxkbid0IHhz bV97bXVsdGlib290LGR0fV9pbml0KCkgYmUgdm9pZCwgYW5kIHRoZSB3YXJuaW5nX2FkZCgpIG1v dmUNCmludG8gdGhlbSwgbGlrZSB0aGUgU0xJTyB3YXJuaW5nIGZvciBBUk0gYWxyZWFkeT8NCg0K VGhhdCB3b3VsZCBzaW1wbGlmeSBib3RoIEFSTSBhbmQgeDg2J3MgX19zdGFydF94ZW4oKSwgYW5k IGJlIGFuDQppbXByb3ZlbWVudCBmb3IgdGhlIFJJU0MtViBzZXJpZXMganVzdCBwb3N0ZWQgdG8g eGVuLWRldmVsLi4uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue May 31 19:22:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 19:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340033.564965 (Exim 4.92) (envelope-from ) id 1nw7Rb-0004wS-7A; Tue, 31 May 2022 19:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340033.564965; Tue, 31 May 2022 19:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7Rb-0004wL-2r; Tue, 31 May 2022 19:22:19 +0000 Received: by outflank-mailman (input) for mailman id 340033; Tue, 31 May 2022 19:22:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw7Ra-0004wF-3B for xen-devel@lists.xenproject.org; Tue, 31 May 2022 19:22:18 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fabd491b-e116-11ec-bd2c-47488cf2e6aa; Tue, 31 May 2022 21:22:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fabd491b-e116-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1654024936; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7h7PX7RlSkGJjR7XUpJqrkxgy5v0lPFG2diRMD1lqF0=; b=JcVt89BSy5Qd4T/BdgFizVrNjS0RslX6GYf4BvCFehcbyvBvWCT4W464 vM/AvL2Lb5W0ugGvmGivpyU9fRoRIKwA9I/wpFHVeMGJKq3/XH7J2W7HP RY/6lj0eD4RgBRPbh4JWYdbalKtkjEkKiSW4HyCPldCRf5YVEdL1c2jfI k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 71913602 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:JDIWrq8mREloy7H8jYp5DrUD0H6TJUtcMsCJ2f8bNWPcYEJGY0x3n GNOUGuFPv/cZmCkctx3a4zi909VvpHUy4VgHQFlrSA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw3IPgW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbKITQQIY5f2ofwieRRdSCRSHKMFo5aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O JNIMGExNE6ojxtnF2Y9MdEmrteR32jCawFgmEqvtaMJyj2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajk4HtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUU0AWO6/fu2T+BOUIJS2VERP0o95QfEGlCO kCyoz/5OdB+mOTLFCnDr+rJ82Pa1Ts9djFbO3JdJecRy5y6+dxo0EqSJjp2OPTt5uAZDw0c1 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+aTNT8D2BQwQKHhcus1a7AJrV7g FAKmtKF8McFBoyXmSqGTY0lRe/0u67famWD3wE2RvHNEghBHFb6JOhtDMxWfh81Yq7ohxeyC KMshe+hzMAKZyb7BUOGS4mwF94r3cDdKDgRbdiNNoAmSsEoLGevpXgyDWbNjjuFuBV9zskC1 WKzLJ/E4YAyUvw3klJbho41jNcW+8zJ7TiLHcGnn07+ieL2ibz8Ye5tDWZip9sRtMusyDg5O f4FXydW432ziNHDXxQ= IronPort-HdrOrdr: A9a23:UuwRl6jouRlt8MWnrZvncNBkAXBQXtYji2hC6mlwRA09TySZ// rBoB19726StN9xYgBFpTnuAsm9qB/nmaKdgrNhWItKPjOW21dARbsKheCJrgEIcxeOkNK1vp 0AT0ERMrLN5CBB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.91,266,1647316800"; d="scan'208";a="71913602" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/spec-ctrl: Enumeration for new Intel BHI controls Date: Tue, 31 May 2022 20:21:37 +0100 Message-ID: <20220531192137.12468-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/technical-documentation/branch-history-injection.html Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu These are defined now, but support in hardware hasn't been released yet. --- xen/arch/x86/include/asm/msr-index.h | 7 +++++++ xen/include/public/arch-x86/cpufeatureset.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 31964b88af7a..6c250bfcadad 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -36,7 +36,12 @@ #define SPEC_CTRL_IBRS (_AC(1, ULL) << 0) #define SPEC_CTRL_STIBP (_AC(1, ULL) << 1) #define SPEC_CTRL_SSBD (_AC(1, ULL) << 2) +#define SPEC_CTRL_IPRED_DIS_U (_AC(1, ULL) << 3) +#define SPEC_CTRL_IPRED_DIS_S (_AC(1, ULL) << 4) +#define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5) +#define SPEC_CTRL_RRSBA_DIS_S (_AC(1, ULL) << 6) #define SPEC_CTRL_PSFD (_AC(1, ULL) << 7) +#define SPEC_CTRL_BHI_DIS_S (_AC(1, ULL) << 10) #define MSR_PRED_CMD 0x00000049 #define PRED_CMD_IBPB (_AC(1, ULL) << 0) @@ -66,6 +71,8 @@ #define ARCH_CAPS_IF_PSCHANGE_MC_NO (_AC(1, ULL) << 6) #define ARCH_CAPS_TSX_CTRL (_AC(1, ULL) << 7) #define ARCH_CAPS_TAA_NO (_AC(1, ULL) << 8) +#define ARCH_CAPS_RRSBA (_AC(1, ULL) << 19) +#define ARCH_CAPS_BHI_NO (_AC(1, ULL) << 20) #define MSR_FLUSH_CMD 0x0000010b #define FLUSH_CMD_L1D (_AC(1, ULL) << 0) diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 0c27f5bbaf37..101698941074 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -304,6 +304,9 @@ XEN_CPUFEATURE(INTEL_PPIN, 12*32+ 0) /* Protected Processor Inventory /* Intel-defined CPU features, CPUID level 0x00000007:2.edx, word 13 */ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A MSR_SPEC_CTRL.PSFD */ +XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* MSR_SPEC_CTRL.IPRED_DIS_* */ +XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /* MSR_SPEC_CTRL.RRSBA_DIS_* */ +XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S */ XEN_CPUFEATURE(MCDT_NO, 13*32+ 5) /*A MCDT_NO */ #endif /* XEN_CPUFEATURE */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue May 31 21:25:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 21:25:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340045.564980 (Exim 4.92) (envelope-from ) id 1nw9MP-000141-3O; Tue, 31 May 2022 21:25:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340045.564980; Tue, 31 May 2022 21:25:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9MO-00013u-Vg; Tue, 31 May 2022 21:25:04 +0000 Received: by outflank-mailman (input) for mailman id 340045; Tue, 31 May 2022 21:25:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9MN-00013l-9q for xen-devel@lists.xenproject.org; Tue, 31 May 2022 21:25:03 +0000 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 203a2227-e128-11ec-837f-e5687231ffcc; Tue, 31 May 2022 23:25:00 +0200 (CEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id 4C9F21F43F0B X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 203a2227-e128-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654032299; bh=dWPjJiUcTEsCTwSVeYSxHnF1/ruJ13+dt9/M97DHXpY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iw1cl93DawB1wUr9b6KkZdHCFs5+L/GBohLHlROEAOks05zME/v6MXMPk6D7ui5Yi RNRHdZFdzCLwhRjjb38P9M6JexB3Wbp2yKOPr5eeU8sVg/8ntyHzURiHlZSY6J8Cm9 q6oV/gJyO14M2ElVzYwoEuvi7LeAOBJpJO7JVAQIQbIk2iZISrAGCD8WEks6N0mo8W PABIM3KRc5wMYvZgEpozGR6zO7yQLUE2dke3U5CmMfjFhmLTkzt3Ddgs0XBxEfDRJn c+JlwyAdHThzhqLupTWaB45a5dOVfxT+a6WiHu8uAbSXS41ExvvXWl05U0ZRpjuSZP ldNnEXKzwDRFg== Message-ID: Date: Wed, 1 Jun 2022 00:24:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v8 16/27] m68k: Switch to new sys-off handler API Content-Language: en-US To: Geert Uytterhoeven Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , "Rafael J. Wysocki" , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linux-csky@vger.kernel.org, "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Parisc List , linux-riscv , Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM list , linux-tegra References: <20220509233235.995021-1-dmitry.osipenko@collabora.com> <20220509233235.995021-17-dmitry.osipenko@collabora.com> From: Dmitry Osipenko In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/31/22 22:04, Geert Uytterhoeven wrote: > Hi Dmitry, > > On Tue, May 10, 2022 at 1:34 AM Dmitry Osipenko > wrote: >> Kernel now supports chained power-off handlers. Use >> register_power_off_handler() that registers power-off handlers and >> do_kernel_power_off() that invokes chained power-off handlers. Legacy >> pm_power_off() will be removed once all drivers will be converted to >> the new sys-off API. >> >> Normally arch code should adopt only the do_kernel_power_off() at first, >> but m68k is a special case because it uses pm_power_off() "inside out", >> i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing], >> while it's machine_power_off() that should invoke the pm_power_off(), and >> thus, we can't convert platforms to the new API separately. There are only >> two platforms changed here, so it's not a big deal. >> >> Acked-by: Geert Uytterhoeven >> Reviewed-by: Michał Mirosław >> Signed-off-by: Dmitry Osipenko > > Thanks for your patch, which is now commit f0f7e5265b3b37b0 > ("m68k: Switch to new sys-off handler API") upstream. > >> --- a/arch/m68k/emu/natfeat.c >> +++ b/arch/m68k/emu/natfeat.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -90,5 +91,5 @@ void __init nf_init(void) >> pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16, >> version & 0xffff); >> >> - mach_power_off = nf_poweroff; >> + register_platform_power_off(nf_poweroff); > > Unfortunately nothing is registered, as this is called very early > (from setup_arch(), before the memory allocator is available. > Hence register_sys_off_handler() fails with -ENOMEM, and poweroff > stops working. > > Possible solutions: > - As at most one handler can be registered, > register_platform_power_off() could use a static struct sys_off_handler > instance, > - Keep mach_power_off, and call register_platform_power_off() later. > > Anything else? > Thanks! > >> --- a/arch/m68k/mac/config.c >> +++ b/arch/m68k/mac/config.c >> @@ -12,6 +12,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -140,7 +141,6 @@ void __init config_mac(void) >> mach_hwclk = mac_hwclk; >> mach_reset = mac_reset; >> mach_halt = mac_poweroff; >> - mach_power_off = mac_poweroff; >> #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP) >> mach_beep = mac_mksound; >> #endif >> @@ -160,6 +160,8 @@ void __init config_mac(void) >> >> if (macintosh_config->ident == MAC_MODEL_IICI) >> mach_l2_flush = via_l2_flush; >> + >> + register_platform_power_off(mac_poweroff); >> } > > This must have the same problem. The static variant should be better, IMO. I'm not sure whether other platforms won't face the same problem once they will start using register_platform_power_off(). I'll send the fix, thank you for the testing! --- >8 --- diff --git a/kernel/reboot.c b/kernel/reboot.c index a091145ee710..4fea05d387dc 100644 --- a/kernel/reboot.c +++ b/kernel/reboot.c @@ -315,6 +315,37 @@ static int sys_off_notify(struct notifier_block *nb, return handler->sys_off_cb(&data); } +static struct sys_off_handler platform_sys_off_handler; + +static struct sys_off_handler *alloc_sys_off_handler(int priority) +{ + struct sys_off_handler *handler; + + /* + * Platforms like m68k can't allocate sys_off handler dynamically + * at the early boot time. + */ + if (priority == SYS_OFF_PRIO_PLATFORM) { + handler = &platform_sys_off_handler; + if (handler->cb_data) + return ERR_PTR(-EBUSY); + } else { + handler = kzalloc(sizeof(*handler), GFP_KERNEL); + if (!handler) + return ERR_PTR(-ENOMEM); + } + + return handler; +} + +static void free_sys_off_handler(struct sys_off_handler *handler) +{ + if (handler == &platform_sys_off_handler) + memset(handler, 0, sizeof(*handler)); + else + kfree(handler); +} + /** * register_sys_off_handler - Register sys-off handler * @mode: Sys-off mode @@ -345,9 +376,9 @@ register_sys_off_handler(enum sys_off_mode mode, struct sys_off_handler *handler; int err; - handler = kzalloc(sizeof(*handler), GFP_KERNEL); - if (!handler) - return ERR_PTR(-ENOMEM); + handler = alloc_sys_off_handler(priority); + if (IS_ERR(handler)) + return handler; switch (mode) { case SYS_OFF_MODE_POWER_OFF_PREPARE: @@ -364,7 +395,7 @@ register_sys_off_handler(enum sys_off_mode mode, break; default: - kfree(handler); + free_sys_off_handler(handler); return ERR_PTR(-EINVAL); } @@ -391,7 +422,7 @@ register_sys_off_handler(enum sys_off_mode mode, } if (err) { - kfree(handler); + free_sys_off_handler(handler); return ERR_PTR(err); } @@ -422,7 +453,7 @@ void unregister_sys_off_handler(struct sys_off_handler *handler) /* sanity check, shall never happen */ WARN_ON(err); - kfree(handler); + free_sys_off_handler(handler); } EXPORT_SYMBOL_GPL(unregister_sys_off_handler); From xen-devel-bounces@lists.xenproject.org Tue May 31 21:45:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 21:45:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340054.564991 (Exim 4.92) (envelope-from ) id 1nw9gP-0003gf-QF; Tue, 31 May 2022 21:45:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340054.564991; Tue, 31 May 2022 21:45:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9gP-0003gY-Mw; Tue, 31 May 2022 21:45:45 +0000 Received: by outflank-mailman (input) for mailman id 340054; Tue, 31 May 2022 21:45:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9gO-0003gO-Ty; Tue, 31 May 2022 21:45:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9gO-0005JU-Qb; Tue, 31 May 2022 21:45:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nw9gO-0004oV-DP; Tue, 31 May 2022 21:45:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1nw9gO-00039G-Cv; Tue, 31 May 2022 21:45:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P+/949qTAlXcJqM3n3nU39LxGdM8y0eiKtZ9eXXnDPE=; b=W7ZFP1lRm0kQi0qS+DzzUPLw3U 2vKIiQ5D1bBP5LUfLpXFZR5GX4nPg68Q2qKRSzBfMCd5isAMwRmdL9BhisX8jiF3INp5OVauRpufh Cew3+ARa2PE7qTQo0gx5iJBO+bGLnm+AUfFG5AyZ/TVml4YG5V0tm44sqlM+1YyVv7PA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 170788: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:guest-start/debian:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start:fail:regression linux-linus:test-amd64-coresched-amd64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-arndale:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-pygrub:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-vhd:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression linux-linus:test-armhf-armhf-xl:guest-start:fail:regression linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking X-Osstest-Versions-This: linux=8ab2afa23bd197df47819a87f0265c0ac95c5b6a X-Osstest-Versions-That: linux=d6ecaa0024485effd065124fe774de2e22095f2d From: osstest service owner Date: Tue, 31 May 2022 21:45:44 +0000 flight 170788 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-intel 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-libvirt-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvhv2-amd 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-examine 8 reboot fail REGR. vs. 170714 test-arm64-arm64-xl 8 xen-boot fail REGR. vs. 170714 test-arm64-arm64-xl-credit2 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-pvshim 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-pair 25 guest-start/debian fail REGR. vs. 170714 test-amd64-amd64-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-amd64-coresched-amd64-xl 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 170714 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 170714 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-arndale 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-shadow 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemut-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-qemuu-nested-intel 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-debianhvm-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 170714 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-cubietruck 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-examine 8 reboot fail REGR. vs. 170714 test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-xsm 8 xen-boot fail REGR. vs. 170714 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 170714 test-amd64-amd64-pygrub 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl-credit2 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt 14 guest-start fail REGR. vs. 170714 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 170714 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-raw 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail REGR. vs. 170714 test-armhf-armhf-xl 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-vhd 12 debian-di-install fail REGR. vs. 170714 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 14 guest-start fail REGR. vs. 170714 test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 170714 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 170714 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170714 version targeted for testing: linux 8ab2afa23bd197df47819a87f0265c0ac95c5b6a baseline version: linux d6ecaa0024485effd065124fe774de2e22095f2d Last test of basis 170714 2022-05-24 03:27:44 Z 7 days Failing since 170716 2022-05-24 11:12:06 Z 7 days 22 attempts Testing same since 170779 2022-05-30 21:42:54 Z 1 days 3 attempts ------------------------------------------------------------ 1946 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 217025 lines long.) From xen-devel-bounces@lists.xenproject.org Tue May 31 23:14:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 31 May 2022 23:14:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.340066.565002 (Exim 4.92) (envelope-from ) id 1nwB3e-0005Az-B6; Tue, 31 May 2022 23:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 340066.565002; Tue, 31 May 2022 23:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nwB3e-0005As-7u; Tue, 31 May 2022 23:13:50 +0000 Received: by outflank-mailman (input) for mailman id 340066; Tue, 31 May 2022 23:13:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nwB3d-0005Am-EK for xen-devel@lists.xenproject.org; Tue, 31 May 2022 23:13:49 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51d75319-e137-11ec-837f-e5687231ffcc; Wed, 01 Jun 2022 01:13:45 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2BF0AB815DD; Tue, 31 May 2022 23:13:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95193C3411C; Tue, 31 May 2022 23:13:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51d75319-e137-11ec-837f-e5687231ffcc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654038823; bh=vxDe7CffRQNFdc8ngfbpVMNugay2JDNtTPWJSoqctW0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=KmEXd0mo7qHuvNGEzSLJmj0mQMd/vZRBDkNFP8V0iqbP4+FYWI0PboSP8fSyYbK7u GR3/qJQudH/D/ajkCh41UfwOEZIHbfrNFl0ydwTEzuFjL+WDOkb/DV+faIsOiGtHfn PWjV6QoqaXhOnRXQMDHqfpK2tUe0az0gbv2mxqisbhCJhvZ/HY0Ohbhdv2jecdmhHW e7khy9h8/boWrmYu3I6Bqwx1AjWgcLnGEGWWpEbZQEG+g5AXDUpARYlLHYqib57pFA t6DnDIWIZIpzFQSuWZ8cO0gu24n2TEEIdlKIjuYUUGoV9ErU0TWdg6/7IR1OzZUl95 171vAjKSI9qAQ== Date: Tue, 31 May 2022 16:13:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Oleksii Moisieiev , "xen-devel@lists.xenproject.org" , Peng Fan , Bertrand Marquis , Stefano Stabellini Subject: Re: [Xen-devel] SMMU permission fault on Dom0 when init vpu_decoder In-Reply-To: Message-ID: References: <20220530152102.GA883104@EPUAKYIW015D> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 30 May 2022, Julien Grall wrote: > (+ Stefano) > > On 30/05/2022 16:21, Oleksii Moisieiev wrote: > > Hello, > > Hi Oleksii, > > > I'm getting permission fault from SMMU when trying to init > > VPU_Encoder/Decoder > > in Dom0 on IMX8QM board: > > (XEN) smmu: /iommu@51400000: Unhandled context fault: fsr=0x408, > > iova=0x86000a60, fsynr=0x1c0062, cb=0 > > This error appears when vpu_encoder/decoder tries to memcpy firmware image > > to > > 0x86000000 address, which is defined in reserved-memory node in xen > > device-tree > > as encoder_boot/decoder_boot region. > > It is not clear to me who is executing the memcpy(). Is it the device or your > domain? If the former, where was the instruction fetch from? > > The reason I am asking that is, from what you wrote, mempcy() will write to > 0x86000000. So the write should not result to a instruction abort. Only an > instruction fetch would lead to such abort. > > > > > I'm using xen from branch xen-project/staging-4.16 + imx related patches, > > which were > > taken from https://source.codeaurora.org/external/imx/imx-xen. > > > > After some investigation I found that this issue was fixed by Peng Fan in > > commit: 46b3dd3718144ca6ac2c12a3b106e57fb7156554 (Hash from codeaurora), but > > only for > > the Guest domains. > > It introduces new p2m_type p2m_mmio_direct_nc_x, which differs from > > p2m_mmio_direct_nc by XN = 0. This type is set to the reserved memory region > > in > > map_mmio_regions function. > > > > I was able to fix issue in Dom0 by setting p2m_mmio_direct_nc_x type for the > > reserved memory in map_regions_p2mt, which is used to map memory during Dom0 > > creation. > > Patch can be found below. > > > > Based on initial discussions on IRC channel - XN bit did the trick because > > looks > > like vpu decoder is executing some code from this memory. > > This was a surprise to me that device could also execute memory. From the SMMU > spec, this looks a legit things. Before relaxing the type, I would like to > confirm this is what's happenning in your case. Yes, this is very interesting > [...] > > > --- > > arm: Set p2m_type to p2m_mmio_direct_nc_x for reserved memory > > regions > > > > This is the enhancement of the 46b3dd3718144ca6ac2c12a3b106e57fb7156554. > > Those patch introduces p2m_mmio_direct_nc_x p2m type which sets the > > e->p2m.xn = 0 for the reserved-memory, such as vpu encoder/decoder. > > > > Set p2m_mmio_direct_nc_x in map_regions_p2mt for reserved-memory the > > same way it does in map_mmio_regions. This change is for the case > > when vpu encoder/decoder works in DomO and not passed-through to the > > Guest Domains. > > > > Signed-off-by: Oleksii Moisieiev > > --- > > xen/arch/arm/p2m.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > index e9568dab88..bb1f681b71 100644 > > --- a/xen/arch/arm/p2m.c > > +++ b/xen/arch/arm/p2m.c > > @@ -1333,6 +1333,13 @@ int map_regions_p2mt(struct domain *d, > > mfn_t mfn, > > p2m_type_t p2mt) > > { > > + if (((long)gfn_x(gfn) >= (GUEST_RAM0_BASE >> PAGE_SHIFT)) && > > + (((long)gfn_x(gfn) + nr) <= > > + ((GUEST_RAM0_BASE + GUEST_RAM0_SIZE)>> PAGE_SHIFT))) > > I am afraid I don't understand what this check is for. In a normal setup, we > don't know where the reserved regions are mapped. Only the caller may know > that. > > For dom0, this decision could be taken in map_range_to_domain(). For the domU, > we would need to let the toolstack to chose the memory attribute. I think the intent of the check is to recognize that map_regions_p2mt was called for a normal memory location and, if so, change the p2m type to p2m_mmio_direct_nc_x. As a downstream, the patch below is one of the easiest way to have a self-contained change to fix the problem described above. However, as upstream this is the wrong location for the check and also maybe the wrong check. For dom0, as Julien said, it is easier because we could just have a check in map_range_to_domain whether the range we are trying to map is a reserved_memory range (in pseudo-code): if ( reserved_memory ) p2mt = p2m_mmio_direct_nc_x; I think that would be doable. For dom0less domUs and for regular xl domUs it is more difficult because there is no way to say "I want to reassign this reserved-memory range to a domU". Reserved-memory doesn't have a special API or mapping operation today. It would be done via a regular xen,reg or iomem mapping request which doesn't have a cacheability parameter. It is always non-cacheable. It is not possible to specify any different cacheability types or NX type or other mapping attributes. > Stefano > attempted to do that a few years ago (see [1]). Maybe we should revive it? I have a couple of patches to add cacheability for dom0less and also normal guests: - one patch to introduce xen,reg-cacheable for dom0less domUs https://github.com/Xilinx/xen/commit/8dbbf64ebf442f4d6e5772b43e8536fa5566ca94 - one patch to add a cacheability parameter to iomem for xl domUs https://github.com/Xilinx/xen/commit/67bb93dd0fd338aeef624233fc1793c64b6ab0df I haven't had the time to upstream either of them yet. They would need some changes to also cover the p2m_mmio_direct_nc_x case. > > + { > > + p2m_remove_mapping(d, gfn, nr, mfn); > > + return p2m_insert_mapping(d, gfn, nr, mfn, p2m_mmio_direct_nc_x); > > + } > > return p2m_insert_mapping(d, gfn, nr, mfn, p2mt); > > } > > > > Cheers, > > [1] > https://lore.kernel.org/xen-devel/alpine.DEB.2.10.1902261501020.20689@sstabellini-ThinkPad-X260/ > > -- > Julien Gral >